Automated cherry pick of #5177

Cherry pick of #5177 on release-5.22.

#5177: MM-11387: tweak tooltip CSS

/cc  @lieut-data

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@lieut-data FYI that the PRs need to be first approved before the auto-merge works.

Trying to auto merge this PR.

Pull Request successfully merged
SHA: 3b7b2b5acfeb4b93015445d7a97fc2e76a62bd39


[Bug Report] In complex situations such as router-view, slot, if, slot under el-table, the parent component passes in the slot under el-table-column [Vue warn]: Duplicate keys detected:'el-table_1_column_1'. This may cause an update error. found in - > < ElTable Header >

Element UI version
2.5.4
OS/Browsers version
last 2 chrome version
Vue version
2.6.7
Reproduction Link
https://jsfiddle.net/panhezeng/xw5k40yq
Steps to reproduce
在非常复杂的cms项目下，在router-view,slot,if多种复杂情况下，el-table下面的slot，父组件通过slot传入el-table-column  [Vue warn]: Duplicate keys detected: 'el-table_1_column_1'. This may cause an update error.  found in  --->
What is Expected?
无Vue warn
What is actually happening?
[Vue warn]: Duplicate keys detected: 'el-table_1_column_1'. This may cause an update error.
found in
--->
 at packages/table/src/table.vue
 at src/ElTreeTable.vue
 at src/components/common/Page/List.vue
 at src/components/common/Page/Content.vue
 at src/components/pages/Organization/index.vue
 at src/components/layouts/Basic.vue
 at src/App.vue

Issues without a valid reproduction link will be closed directly.


Bug: On Admin User - Reservations Tab , Some of the pre-existing reservations made around oct. have bugged previews panels. Assessed - Missing files from Github repos?

Does this mean the images store cannot be found in the database?   incorrect directory address?

Maybe the uploaded file was not uploaded on the Github, that is why it shows missing file.

what should I do? maybe I delete these reservations on my side since these reservations are made during earlier stages sa development...

I will ignore these missing files.... I will not open these old reservations during project presentation...
Ill close it


prefetch_related merges entries when many-to-many fields point to the same table

First of all, thanks for creating Ormar! I've just started testing it, and I really like what I see so far.
I have, however, run into some problems with many-to-many fields with Ormar. The problem described here is the first I've successfully been able to recreate in a fashion that's made me want to start an issue.
Describe the bug
Let's say I have a model called Book with two many-to-many fields pointing to the same model, Author.
The Book-fields pointing to Author is authors and co-authors.
I understand that there are mainly two ways to fetch the Books with their relations:
await Book.objects.select_related(['authors', 'co_authors']).all()
and
await Book.objects.prefetch_related(['authors', 'co_authors']).all()
The difference, as I understand it, is that the former builds one large query to fetch the data, while the latter executes one query per model.
The select_related becomes way too slow for the actual db-setup I've been testing with, so I've had to resort to the prefetch_related.
However, I've noticed that the prefetch_related joins authors and co-authors and adds all of them to both fields.
When select_related gives me:
{'authors': [{'id': 1, 'name': 'Veronica Porter'},
             {'id': 2, 'name': 'Charlene Diaz'}],
 'co_authors': [{'id': 3, 'name': 'John Turner'},
                {'id': 4, 'name': 'Pamela Nguyen'},
                {'id': 5, 'name': 'Stephanie Carr'}],
 'description': None,
 'id': 1,
 'name': 'Book titled something'}

prefetch_related gives me:
{'authors': [{'id': 1, 'name': 'Veronica Porter'},
             {'id': 2, 'name': 'Charlene Diaz'},
             {'id': 3, 'name': 'John Turner'},
             {'id': 4, 'name': 'Pamela Nguyen'},
             {'id': 5, 'name': 'Stephanie Carr'}],
 'co_authors': [{'id': 1, 'name': 'Veronica Porter'},
                {'id': 2, 'name': 'Charlene Diaz'},
                {'id': 3, 'name': 'John Turner'},
                {'id': 4, 'name': 'Pamela Nguyen'},
                {'id': 5, 'name': 'Stephanie Carr'}],
 'description': None,
 'id': 1,
 'name': 'Book titled something'}

select_related above is correct in respect to how I created the book-entry and added the related authors.
prefetch_related bunches them all together in both the authors and co_authors-field
To Reproduce
Models to reproduce:
from typing import Optional

import ormar
import sqlalchemy

from app.core.db import database

class BaseMeta(ormar.ModelMeta):
    database = database
    metadata = sqlalchemy.MetaData()

class Author(ormar.Model):
    class Meta(BaseMeta):
        tablename = "authors"

    id: int = ormar.Integer(primary_key=True)
    name: str = ormar.String(max_length=256)

class BookAuthor(ormar.Model):
    class Meta(BaseMeta):
        tablename = 'book_authors'

    id: int = ormar.Integer(primary_key=True)

class BookCoAuthor(ormar.Model):
    class Meta(BaseMeta):
        tablename = 'book_co_authors'

    id: int = ormar.Integer(primary_key=True)

class Book(ormar.Model):
    class Meta(BaseMeta):
        tablename = "books"

    id: int = ormar.Integer(primary_key=True)
    name: str = ormar.String(max_length=256)
    description: Optional[str] = ormar.String(max_length=256, nullable=True)
    authors: Optional[list[Author]] = ormar.ManyToMany(
        Author, related_name='author_books', through=BookAuthor
    )
    co_authors: Optional[list[Author]] = ormar.ManyToMany(
        Author, related_name='co_author_books', through=BookCoAuthor
    )

Test to reproduce:
from random import randint

from faker import Faker
import pytest

from app.core.db import database
from app.models.library import Author, Book

@pytest.mark.asyncio
async def test_db():
    fake = Faker()
    async with database:
        for _ in range(6):
            await Author.objects.create(name=fake.name())

        book = await Book.objects.create(name=fake.sentence(nb_words=randint(1, 4)))
        for i in range(1, 3):
            await book.authors.add(await Author.objects.get(id=i))
        for i in range(3, 6):
            await book.co_authors.add(await Author.objects.get(id=i))

        print('')
        prefetch_result = await Book.objects.prefetch_related(['authors', 'co_authors']).all()
        import json
        prefetch_dict_result = [x.dict() for x in prefetch_result if x.id == 1][0]
        print(json.dumps(prefetch_dict_result, indent=4))

        select_result = await Book.objects.select_related(['authors', 'co_authors']).all()

        import json
        select_dict_result = [
            x.dict(
                exclude={'authors': {'bookauthor': ...}, 'co_authors': {'bookcoauthor': ...}}
            ) for x in select_result if x.id == 1
        ][0]
        print(json.dumps(select_dict_result, indent=4))
        assert prefetch_dict_result == select_dict_result

Expected behavior
I would expect that the resulting members of authors and co_authors would be the same as select_related for prefetch_related.
Screenshots
diff-view after running the above test:

Versions (please complete the following information):

Database backend used: postgres
Python version: 3.10
ormar version: 0.11.3
pydantic version: 1.10.2
if applicable fastapi version: 0.85.0
alembic: 1.8.1

Additional context
Add any other context about the problem here.

Hey @collerek , any thoughts? 😊


App crashing on opening.

The app crashes seconds after opening.
In an attempt to temporarily solve the issue I tried using older versions of the apk but the issue still persisted.
I am on Samsung s20 fe. I have noticed however that if airplane mode is on then the app does not crash.

Can you please specify the version you are using?
I had similar issue after updating from r3672 to r3679.
I uninstalled the old version of the app and installed new r3686 version, its fine now

I am facing the same problem as well!

Uninstalling and fresh installation worked fine for me. I guess updating new version crashes the app.

fixed by https://github.com/jmir1/aniyomi/commit/e5cdf74587afe9dde61a7f69d45f101d8ce0a5b8


Dot after return consistency helpful description

Maybe the description of the dot after return consistency result could describe whether the dot is consistenly there or is consistently missing.

Thanks for your input!
The latest commit (https://github.com/hpi-swa-teaching/SwaLint/commit/b48037d527de73e0c4de465727836bd4f8e11e2d) includes your requested feature.
I hope it is in your favour!


Date range picker/filter

It would be nice to have support for date fitlers. For example with a datetime-picker like the one from Airbnb [1] or some range filters.
I have seen that Semantic-UI has no such components. However, both calendar[2] and slider[3] are available in Fomantic-UI (A seem-to-be better community maintained fork of SUI).
I am willing to work on this an contribute to it.
[1] https://github.com/airbnb/react-dates
[2] https://fomantic-ui.com/modules/calendar.html
[3] https://fomantic-ui.com/modules/slider.html

mantab

Implementing something similar here: https://github.com/inveniosoftware/invenio-app-ils/pull/783
Since Semantic UI does not have a calendar widget out of the box, this issue is tricky: adding a calendar lib might "collide" with the another calendar widget adopted in the main app.


Feat/watching nonexistant dependencies

Branched off https://github.com/whitecolor/ts-node-dev/pull/93
Fixes for dependencies on not (yet) existing files

ping @whitecolor - separated this out now

Why need to add chokidar? And what are "nonexistant dependencies" could you elaborate workflow for this case?

@whitecolor I think @jonjaques explained it quite well

A.ts requires B.ts but B.ts doesn't exist
B.ts is created. This should lead to a recompile

That requires "watching" files that don't yet exist. I found no such support outside of chokidar. Again, I'm willing to migrate to using chokidar throughout.

ping again @whitecolor

This doesn't work in the general case, as it is not possible to correctly resolve not existing dependency.


Incorrect confirmation message being shown when max allowed delegation / nomination per validator node is breached

Steps to Reproduce -

Ensure the user have staked tokens in the wallet.
Attempt to nominate a very high stake / token such that it exceeds max allowed delegation / nomination per validator node.

Expected -
The confirmation message shows the correct amount of nominated / delegated token rather than the intended tokens for nomination / delegation
Actual -
Right now we are incorrectly showing the confirmation message for intended tokens to be delegated and not the token actually delegated. The discrepancy shown in screenshot below.

The pending issue would be addressed as #714


Spatial Reverb

Hello Devs!
I am experiencing cut offs with the Spatial Reverb plug-in in Wwise on trigger sounds.
For example a voice (file length about 600-800ms) gets reverberated, but there is no audible tail.
The Metadata RTPCs are set to linear, so it should at least play for 5 seconds, but the reverberated signal is as short as the file length of the source. I can also hear clicking while it cuts off (Spatial Reverb soloed). I tried different curves, but can not find any lengthening, only more predelay and diffuse energy.
Also wondering why sound emitters placed on the map have RTPC values updated in the GameSync profiler, but any trigger sound (weapon, voice on trigger) does not receive any updates or visible cues.
Am I missing something?
Thanks :)

Update: It also happens on my 1P footsteps, the shorter, the worse is my experience. Do you know of any bugs regarding the Spatial Reverb or is it really me? Worst case is using only the Convolution Reverb, as both do not work in one instance of a game, but then I don't have any Early Reflections, right?

Hi dr0p1n, thank you for reaching out with your issue, apologies for the delay. It sounds as though WWISE might be tearing down the spatial reverb bus once the voice count goes to 0. We are working on a bugfix for this, but in the meantime, you may be able to get around the issue by sending WWISE a constantly-active silent audio source, to keep the voice count > 0. Let me know if that helps you with your issue. Regarding your second issue, when you say "trigger sound does not receive any updates or visible cues" do you mean you're not seeing the acoustic parameters when enabling the debug view? Or is there a different configuration you had in mind? Looking forward to helping you further!


Test and document finance module.

Task

Test all the methods of the module finance, (relative path is src/scrape_up/finance ).
Add docstring to each class and module of the module (can take reference from other published modules like github or Flipkart).
Test all the methods by running the program and later remove all the print statements from the code.

Can u assign me this issue @nikhil25803

Go ahead @nikhil25803
Note

Create a separate module for this, as per the folder and project structure
Do not use the `selenium web driver as it is incompatible with all devices and cloud platforms.
Before making any changes, please check whether the module you want to add exists. If yes, then you can just add your functionality as a method only make a separate module and class for it.

All the best 👨💻


FEATURE: PAAS-6660 Update cron_run.sh

@msurovcak could you double check it from private cloud perspective ? Especially icinga integration


Popup not closing and performing the redirect

I have a working login and redirect in Chrome but when running the same code in IE 11 the login form opens but after creds are entered a white page remains
the redirect back to the page never happens in IE

Can you enable logging and see if there are errors in either window.

No errors that I can see.. I am getting the following in IE
Received authorization endpoint https://localhost:44332/connect/authorize
SigninState.toStorageString
WebStorageStateStore.set c4122622afcb4f06a5cf6b816ea7fa2c
got signin request
PopupWindow.navigate
Setting URL in popup
then an endless list of
PopupWindow._checkForPopupClosed
for each timer call to the method
when I close the popup I get
Popup window closed
Unhandled promise rejection Error: Popup window closed

in chrome its a little different
after the _checkForPopupClosed events kick off i get
PopupWindow._message
processing message
PopupWindow._cleanup
PopupWindow._cleanup
Successful response from popup window
_signinEnd
OidcClient.processSigninResponse
.....
and it successfully logs the user in and closes the form

I switched to the oidc-token-manager and everything is working as expected in IE and Chrome now. I was unable to resolve IE with the oidc-client

Could it be that the es6-promise polyfill is missing for IE users? Try installing this package via npm and execute the line
require('es6-promise').polyfill();
at the beginning of your code (assuming you are using npm) and see if it helps. It's a wild guess but the error you're getting seems to point in that direction.

As @maxmantz is getting at, which .js file did you include? Meaning from which folder?

I tested in IE (in emulation from IE11) and it seems to work. I know emulation isn't perfect.

The other thing to test is if the npm start server and samples work for you on IE. Again, they do for me, and if they also do for you, then my guess is that you're hitting a cross zone issue in IE.

Any updates?

I ended up not using the Popup as to many issue with blockers.  I went the redirect route instead.
Adam

On Jul 17, 2016, at 4:45 PM, Brock Allen<EMAIL_ADDRESS>wrote:
Any updates?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Decoded Text is empty for io.BytesIO

I have an WebSocket API for Speech To Text and I want to use moonshine as an alternative for faster-whisper but the decoded text is empty.
This is my log after receiving the audio signal:
MoonShineTranscriotionService.py:66 - transcribe stream
2024-11-05 13:10:33 2024-11-05 12:10:33 [INFO] MoonShineTranscriptionService.py:90 - Audio shape before reshaping: (41472,)
2024-11-05 13:10:33 2024-11-05 12:10:33 [INFO] MoonShineTranscriptionService.py:96 - Audio shape after reshaping: (1, 41472)
2024-11-05 13:10:33 2024-11-05 12:10:33 [INFO] MoonShineTranscriptionService.py:101 - Max. token length: 15
2024-11-05 13:10:33 2024-11-05 12:10:33 [INFO] MoonShineTranscriptionService.py:110 - Token count: 1
2024-11-05 13:10:33 2024-11-05 12:10:33 [INFO] MoonShineTranscriptionService.py:115 - Decoded text:
This is the used function:
def transcribe_stream(self, audio_stream: io.BytesIO):
import soundfile as sf
from scipy.signal import resample
    logger.info("transcribe stream")

    try:
        audio_stream.seek(0)
        audio, samplerate = sf.read(audio_stream)

        # Check if audio_data is empty
        if audio.size == 0:
            logger.info("Audio stream is empty")
            return None

        # Convert from double to float
        audio = audio.astype(np.float32)

        # Downsample audio from 48000 Hz to 16000 Hz
        if samplerate != 16000:
            num_samples = int(len(audio) * (16000 / samplerate))
            audio = resample(audio, num_samples)
            samplerate = 16000

        # Single channel
        audio = audio.copy().flatten()

        # Check shape before reshaping
        logger.info(f"Audio shape before reshaping: {audio.shape}")

        # Reshape audio to (batch_size, input_features)
        audio = audio[np.newaxis, :]

        # Log the new shape
        logger.info(f"Audio shape after reshaping: {audio.shape}")

        # Max. token length
        max_len = int((audio.shape[-1] / samplerate) * 6)

        logger.info(f"Max. token length: {max_len}")

        tokens = self.model.generate(audio, max_len)

        # Tokens are generated successfully
        if tokens is None or len(tokens) == 0:
            logger.info("No tokens generated")
            return None

        logger.info(f"Token count: {len(tokens)}")

        # Decode the tokens
        text = self.tokenizer.decode_batch(tokens)[0]

        logger.info(f"Decoded text: {text}")

        return "", -1.0, text

    except Exception as e:
        logger.error(f"An error occurred: {e}")
        return "", -1.0, ""

Has someone an idea why it returns nothing

It could be because you are using a stream and not providing a large enough chunk of audio from that stream to the model. What happens if you write the audio from one pass to a wav file rather than transcribing it? What does it sound like?

I have noticed this issue with moonshine before (running onnx model in a swift iOS app).
However, the lack of output does not (at least in my limited testing) correspond with the number of samples passed in. I suggest using another model as backup in case this result is empty.

Interesting. If you are able to provide an audio sample or test case where the issue is repeatable, that would be very helpful.

Interesting. If you are able to provide an audio sample or test case where the issue is repeatable, that would be very helpful.

Don't think I will be able to provide those at this time since I am running what is essentially live_captions.py on my Swift app with mic input which makes it difficult to run reproducible tests.

In my case I modified my code to export data in different spots
debug_audio_float32.txt -> after convert audio data to numpy
debug_audio_downsampled.txt -> after downsampling from 48000 to 16000
debug_audio_flattened.txt -> after flattern the audio data
audio.wav -> exported audio
debug_audio.zip

I wonder why it doesn't work with the Numpy array then

It looks like I had a problem with the preprocesing of the audio data.
Here is my updated code:
def transcribe_stream(self, audio_stream: io.BytesIO, **kwargs) -> Optional[str]:
from pydub import AudioSegment
    try:
        text = ""

        # Preprocessing
        # Load audio from BytesIO
        audio_segment = AudioSegment.from_file(audio_stream)

        # Convert to mono
        audio_segment = audio_segment.set_channels(1)

        # Set frame rate to 16000
        audio_segment = audio_segment.set_frame_rate(16000)

        # Set sample width to 2 bytes (16-bit PCM)
        audio_segment = audio_segment.set_sample_width(2)

        # Convert the audio segment to raw bytes
        audio_bytes = audio_segment.raw_data

        # Convert audio to NumPy array
        audio = (
            np.frombuffer(audio_bytes, np.int16) / 32768.0
        )  # Normalize to [-1, 1]
        audio = audio.astype(np.float32)[None, ...]  # Add batch dimension

        tokens = self.model.generate(audio)

        # Decode the tokens to get text
        logger.info("Start decoding")
        text = self.tokenizer.decode_batch(tokens)
        logger.info(f"Decoded text: {text}")

        return "", -1.0, text

    except Exception as e:
        # Log and save any error that occurs
        logger.error(f"An error occurred: {e}")
        return "", -1.0, ""

I used pydub to preprocess the audio data
This fixed my concern
Thank you for your support


Unable to locate helper/Model error

When first installing on a clean build of EE 2. Get the following error when trying to create a new channel field.
Unable to load the requested file: helpers/vwm_polls_helper.php
After some troubleshooting it turns out this is caused by the ft.vwm_polls.php file..
public function __construct()
{
	parent::__construct();

	// Load helper & model
	$this->EE->lang->loadfile('vwm_polls');
	$this->EE->load->helper('vwm_polls');
	$this->EE->load->model('vwm_polls_m');

	// Get member groups
	$this->member_groups();
}

Because the super object EE is loaded from the parent EE_Fieldtype class, the Loader class isn't looking in the module for the helper/Module files.

0.4.1 now throws the following: Unable to locate the model you have specified: vwm_polls_m
EE v2.3.1 - Build: date  20111017

@rdhrkns On what page are you receiving this error?

When I try to install a new field in a field group for the channel I've set up.

I just installed and tested the module in EE 2.3.1 and did not encounter any errors. Are you sure you replaced all the module files? Sometimes, if working on a remote server, you may run into permission errors where it will skip files.

I downloaded the latest here from Github, deleted the old files via FTP and uploaded the new files... I presume 775 grants sufficient acces for the files.

Just double checked the procedure with the same result: 'Unable to locate the model you have specified: vwm_polls_m' when trying to ad a new field type to a group.
EE 2.3.1
poll_ft 0.4.1
poll_mod 0.4.1

@rdhrkns If you are available later we could try some remote support with Windows Remote Assistance or something similar. Send me a private message if interested.

How / where do I contact you via PM ?
2012/1/11 Victor Michnowicz <
<EMAIL_ADDRESS>

@rdhrkns If you are available later we could try some remote support with
Windows Remote Assistance or something similar. Send me a private message
if interested.

Reply to this email directly or view it on GitHub:
https://github.com/vmichnowicz/vwm_polls/issues/6#issuecomment-3449752

Haha, I guess there is no PM in GitHub. Just send an email then. My email is {my github<EMAIL_ADDRESS>

This should be fixed in the latest version of the code.


Complete rework of barbuk theme

Description
This is a complete rework of my theme.
Motivation and Context
I'm using more tools at work or for personal usage that need context in my shell:

ruby version
terraform
aws / scw profil

The theme is the same, but with more flexibility.
You can now configure it to display different information by setting BARBUK_PROMPT env variable.
How Has This Been Tested?
All new block are inspired from base theme or powerline theme.
I use the theme to work, it's was tested in real work condition :).
Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[X] If my change requires a change to the documentation, I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[X] If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
[X] I have added tests to cover my changes, and all the new and existing tests pass.

Just a precision:

Theme display does not change
The rework is only to make it more customizable / modular

I changed the title to make it less scary :)
The major thing is:

if people are using this theme, it will not change after update
the theme is now modular and can be configured with BARBUK_PROMPT env.

BARBUK_PROMPT="git-uptream-remote-logo ssh path scm python_venv ruby node terraform cloud duration exit"

Feedback and review are welcome.


[WIP] Dataset indexer

This is work in progress to support features indexer for chainer dataset class.
Refer:
[New feature] Feature extraction support for Chainer dataset class

Are you thinking of supporting indexers for TupleDataset and DictDataset?

I already implemented the support of dict_dataset as well.
https://github.com/chainer/chainer/pull/3252/files#diff-afabfc7ee7723839c8042dc74a3b23b5
As you can see, I'm going to implement for DatasetMixin, ImageDataset, LabeledImageDataset class too.

Remaining task is to

For DatasetMixin class, I think it is better for default behavior to create a cache to return features.
(currently, it is calling get_example every time in extract_feature)
write a test

Once I got positive comment for the idea, I will proceed above implementation.

It is a handy feature as I frequently do like labels = [d[1] for d in dataset]. So I want to proceed the PR. By the way, is it possible to separate it into smaller ones so that we can review it smoothly?

I separated the PR, and at first submit a PR for only TupleDataset.
#3343

I'm implementing PickableDataset (https://github.com/chainer/chainercv/pull/454) which is another solution for #3251. You can see the usage of it here. I would like to migrate this dataset from ChainerCV to Chainer because it is not only for CV. With this dataset, we can implement efficient feature selection more easily than Indexer.

@Hakuyume
Thank you for your comment, I don't know similar discussion is going on in chainer cv (while I was making PR from almost 2 month ago...).

One important use case for me is that I want to extract label information after splitting the dataset into train and validation, which is SubDataset (subclass of DatasetMixin), as written in this discussion,
Therefore, even specific dataset class support this feature, I cannot extract labels information efficiently when I split the dataset.
https://github.com/chainer/chainer/pull/3343

I guess actually DictDataset can do the similar job, which PickableDataset want to support.
Please refer this test for demo.
https://github.com/chainer/chainer/pull/3252/files#diff-afabfc7ee7723839c8042dc74a3b23b5R48

I think you already noticed it, as you are discussing in the chainercv thread (https://github.com/chainer/chainercv/pull/454).
One another motivation for this PR is to support efficient data extraction, which means, do not copy numpy array but use view reference when possible.
It can be done by overriding extract_feature_by_slice method.
https://github.com/chainer/chainer/pull/3343/files#diff-81b6edfb9c10c745e45d1990196ec9f6R73

One troublesome stuff is that if the user want to optimize their own DatasetMixin class, user need to re-implement their own extract_feature method or extract_feature_by_slice method.

One important use case for me is that I want to extract label information after splitting the dataset into train and validation, which is SubDataset (subclass of DatasetMixin), as written in this discussion (#3343),
Therefore, even specific dataset class support this feature, I cannot extract labels information efficiently when I split the dataset.

As you pointed out, SubDataset erases pickable feature.
One solution is adding split or sub method to PickableDataset which can make sub dataset with pickable feature. Another solution is modifying SubDataset to treat PickableDataset in different way.

I guess actually DictDataset can do the similar job, which PickableDataset want to support.
Please refer this test for demo.

DictDataset seems not to provide the feature I want. I want to support efficient access for multiple data.
Assume that dataset has three data types, data_0, data_1 and data_2. The i-th values of data_0 and data_1 can be retrieved from a getter get_0_1(i). And the i-th value of data_2 can be retrieved from another getter get_2(i).
In the case of PickableDataset.
sub_dataset = dataset.pick('data_0', 'data_1')
sub_dataset[i]  # get_0_1[0] is called only once

In the case of `DictDataset, I guess it will be as follows.
data_0, data_1 = dataset[:, ['data_0', 'data_1']]
sub_dataset = DictDataset(data_0=data_0, data_1=data_1)
sub_dataset[i]  # get_0_1[0] is called twice

I think you already noticed it, as you are discussing in the chainercv thread (chainer/chainercv#454).
One another motivation for this PR is to support efficient data extraction, which means, do not copy numpy array but use view reference when possible.
It can be done by overriding extract_feature_by_slice method.
https://github.com/chainer/chainer/pull/3343/files#diff-81b6edfb9c10c745e45d1990196ec9f6R73

Yes. That is a disadvantage of PickableDataset.

One troublesome stuff is that if the user want to optimize their own DatasetMixin class, user need to re-implement their own extract_feature method or extract_feature_by_slice method.

I think that is a huge burden for users. With PickableDataset, it becomes more easy.

Actually, it is not only the case for SubDataset, but also when we used ConcatenatedDataset and TransformDataset etc. So I thought it was easier/user-friendly to introduce unified interface for all chainer dataset, rather than develop specific dataset class.

Sorry, I could not get your point.
If you want to extract i-th 'data_0' and 'data_1' from DictDataset

data_0, data_1 = dict_dataset.features[i, ['data_0', 'data_1']]

is enough.
Also if you want to extract 100-200-th data for example, you can call
data_0, data_1 = dict_dataset.features[100:200, ['data_0', 'data_1']]

and it returns "view" (not copy) of the dataset.

Yeah I agree implementing one extra method for dataset_mixin class is troublesome for users.
But even if you don't override the method, the code works. (but it is just not optimized to return view, but copy can be returned.)
https://github.com/chainer/chainer/pull/3252/files#diff-6ec23c4ee85004cde0ad58ad3fa9877dR117

Sorry, I could not get your point.
If you want to extract i-th 'data_0' and 'data_1' from DictDataset
data_0, data_1 = dict_dataset.features[i, ['data_0', 'data_1']]
is enough.
Also if you want to extract 100-200-th data for example, you can call
data_0, data_1 = dict_dataset.features[100:200, ['data_0', 'data_1']]

I want to get a dataset which contains both data_0 and data_1. Not two datasets.

Ah I see.
I don't mind the backend method of how to achieve this feature, and I'm happy if you can proceed this feature support.
I just would like to request that it would be great if this feature can be applicable to extended dataset like SubDataset, ConcatenatedDataset and TransformDataset etc.

@beam2d @Hakuyume @corochann we will consider a unified way to satisfy some related demands (https://github.com/chainer/chainer/pull/3976, https://github.com/chainer/chainer/pull/3343). Let us make this PR pending until we make the decision. (I changed the assignee to @delta2323 because he has already reviewed some part of this PR.)

I understand, please make it pending or closed.

Seems that Chainer team will consider another way to provide this functionality.


operators [R] special-resource-operator (4.8.1 4.8.2 4.9.0)

Backport of https://github.com/openshift-psap/special-resource-operator/pull/141
Updates to existing Operators

[ ] Did you create a ci.yaml file according to the update instructions?
[ ] Is your new CSV pointing to the previous version with the replaces property if you chose replaces-mode via the updateGraph property in ci.yaml?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml or annotations.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[x] Is your submission signed?

Your submission should not

[x] Modify more than one operator
[ ] Modify an Operator you don't own
[x] Rename an operator - please remove and add with a different name instead
[x] Modify any files outside the above mentioned folders
[x] Contain more than one commit. Please squash your commits.

/merge possible

/merge possible

/approve


POST form array values

Is there a way to submit an array form data? The HTML names have "[]" as their suffix for the form I'm scraping such as "language_ids[]" where each is added via checkboxes.
This is an example of what I have but doesn't seem to work. The endpoint I'm hitting is suppose to set a particular cookie on success. I have the cookie feature enabled and I know the feature works because I have a different call to log in and have successfully tested that part of my code.
let form = reqwest::multipart::Form::new()
    .text("regular_field_1", "value1")
    .text("regular_field_2", "value2")
    .text("language_ids[]", "1")
    .text("language_ids[]", "2");

let client = reqwest::Client::new();

let resp = client.post("https://example.com/display_language/ajax_endpoint")
    .form(form)
    .send()
    .await?;

I'm guessing that the names are being percent encoded? What if you call Form::percent_encoding_noop()?

That didn't fix my issue unfortunately. 😞
This is what I tried, along with a few other variations:
let mut form = multipart::Form::new()
    .percent_encode_noop()
    .text("theme_id", "1")
    .text("display_lang_id", "1");

// `lang` is `u8`.
for lang in self.languages {
    // Also tried using `form.part()` here.
    form = form.text("default_lang_ids[]", lang);
}

let client = reqwest::Client::new();

let resp = client
    .post("https://example.com/ajax_endpoint")
    .multipart(form)
    .send()
    .await?;

I did find a workaround by setting the cookie directly with the RequestBuilder for my other request like so:
// ...
let mut req = client.get("https://example.com/other_endpoint");

if !self.languages.is_empty() {
    req = req.header(
        reqwest::header::COOKIE,
        format!(
            "filter_langs={lang_ids}",
            lang_ids = self.languages
                .iter()
                .map(|lang_id| lang_id.to_string())
                .collect::<Vec<String>>()
                .join(",") // This gets properly percent-encoded.
        )
    );
}

let resp = req.send().await?;
// ...
}

Doing it with my workaround for my use-case has the added benefit of reducing an extra HTTP request call so I'm going to stick with this solution. Still, it'd be nice to know how I might submit a form array for future reference.

Does it need to be a multi part form? Or can it be form-urlencoded? If the latter, you can do so using serde_qs (I think), and setting the body directly.

It may not have to be a multipart form, though these are the request headers sent from the web form itself:
Host: example.org
User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Firefox/78.0
Accept: */*
Accept-Language: en
Accept-Encoding: gzip, deflate, br
Referer: https://example.org/
cache-control: no-cache
X-Requested-With: XMLHttpRequest
Content-Type: multipart/form-data; boundary=---------------------------313331041822757932722222483833
Content-Length: 550
Origin: https://example.org
DNT: 1
Connection: keep-alive
Cookie: __ddg1=mc8QEJe1J9a12cuP3kmh
Sec-GPC: 1
Pragma: no-cache
TE: Trailers

And this is the request body (From the Network tab of the browser inspector):
-----------------------------313331041822757932722222483833
Content-Disposition: form-data; name="theme_id"

1
-----------------------------313331041822757932722222483833
Content-Disposition: form-data; name="default_lang_ids[]"

1
-----------------------------313331041822757932722222483833
Content-Disposition: form-data; name="default_lang_ids[]"

8
-----------------------------313331041822757932722222483833
Content-Disposition: form-data; name="display_lang_id"

1
-----------------------------313331041822757932722222483833--

I can try to make it form-urlencoded and see how that goes.


Add the possibility to use IP Group name in the rules

Description
This update introduces the ability to use IP Group names within firewall rules, allowing for more readable and maintainable Terraform HCL configurations. By referencing IP Group names, rather than resource IDs, managing large-scale firewall policies becomes simpler and more intuitive, especially in environments with many IP Groups. This feature enhances the readability and reduces the complexity of maintaining extensive firewall configurations in Terraform.
-->
Type of Change

[ ] Non-module change (e.g. CI/CD, documentation, etc.)
[ ] Azure Verified Module updates:

[ ] Bugfix containing backwards compatible bug fixes

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[X] Feature update backwards compatible feature updates.
[ ] Breaking changes.
[ ] Update to documentation

Checklist

[ ] I'm sure there are no other open Pull Requests for the same update/change
[ ] My corresponding pipelines / checks run clean and green without any errors or warnings
[ ] I did run all  pre-commit checks

Hey @heintonny thank you for the PR. Before approving the PR the checks need to pass. If you have docker running you can run the ./avm pre-commit to fix the linting issues. let me know if you have any issues.


My wallet was disapeared after airdrop transfer

Hi,
After transfer from airdrop, my stelar wallet was disapeared from desctop application and not reconected.
I don't know secret key but i see that the secretkeys.<user_name>.mpack file is placed correctly and not changed.
How to back my wallet visible in desctop application?
Keybase GUI Version: 5.0.0-20191114143658+f73f97dac6

Wallet isnt working at this moment

I don’t know what happens. I have to read about

Same here. My wallet suddenly empty after a transaction, just 30 minutes ago

Hi, i have the same problem.

I suppose there is a network congestion, probably along with some bug in the keybase wallet.
Tip for Paranoids: your lumens are still there, you can check your balance at explorer, using also your federated address username*keybase.io

I suppose there is a network congestion, probably along with some bug in the keybase wallet.
Tip for Paranoids: your lumens are still there, you can check your balance at stellar explorer, using also your federated address username*keybase.io

Exactly ...
In my wallet... which finally it's loaded.... I see 0XLM, but in stellar explorrer I have the right balance....
I hope that this is a temporaneous issue.

The same problem here, in explorer balance is correct

Probable duplicate of #21076 which has more details (and has now come right).


[BUG] Unit size of storage-size parameter for gstreamer should be Mbytes in documents

Describe the bug
In the README of this repo and AWS documentation, it is describe that the unit of storage-size parameter of gstreamer should be kilobytes.
On the other hand, In the code base, the unit of storage size looks intended to be megabytes.
https://github.com/awslabs/amazon-kinesis-video-streams-producer-sdk-cpp/blob/76e697c13e61de4fda29e0ec050339532fdfb8ea/src/gstreamer/gstkvssink.cpp#L538-L541
Is my understanding correct?
If there's difference in documentation, It's better to fix it.

It worked for me by specifying with Mbytes

I would have preferred this to be in kilobytes but we won't change this to KB in the code. Instead, the documentation will need to change. Would you like to push a PR for the README fix? Please let me know. Alternatively, I will update the doc when I make some changes later

I will make PR and let you know. Thanks

Merged.  Thank you @toshitanian


Use new exclude_claimtrietx option in lbryum getbalance command, fix maturity use

This uses the exclude_claimtrietx option in lbryum pull request https://github.com/lbryio/lbryum/pull/30
Thus the balance should now be displayed as the available amount of credits, not used for any claim trie transactions (claim,support,update).
This also fixes an incorrect use of the field 'unmatured' which would have resulted in some strange behaviors if you held some new coins (probably someone had to patch this in during the early stage of testing where they were testing with unmatured coins ).
This patches to show the fully confirmed balance only, but if we want to show the unconfirmed and insecure balance (with the confirmed balance) it should be result['confirmed'] + result['unconfirmed'] + result['unmatured'] , we could potentially  add another function to show the unconfirmed and insecure balance.
I've not yet actually tested this patch myself.

Was able to test this with lbryum and balance gets updated correctly when you make a claim ,
From a UX viewpoint, there is no way to know how much you spent in claims however.


en-fr: Append Note To Alternative Linux Install

Add link to alternative Linux installation notes in the Minikube documentation.

@mhamdisemah updated.

@oussemos can you have a look and approve

/approve


[Feature] Open links in new tab on trigger

Summary
Allow users to open custom URLs in a new browser tab in response to a trigger.
Motivation
In some scenarios, the content which the user can follow by clicking on a button or on success of an API response will be available in an external page. The developer would want users to have the content open in a separate tab without losing Appsmith's context.

Applicable widgets:

Text widget
Table widget

Should this be the default behaviour of a link click in Appsmith? Are there scenarios where the user would like to click on a link & open the URL on the same page?

I believe the use case here was to add a param to the navigateTo function so that it could open a page in a new tab. Links by default can be opened in a new tab using cmd + click or the  tag so that a single click opens in a new tab

This issue was requested by a user because they were unable to include clickable URLs in the table widget. I created #1935 for that specific issue. But they also asked if they can use HTML in UI widgets and their use-case was to open links in a different tab.

This was fixed in #2706


Add Contour installed by Operator to kind-e2e test

This patch adds contour test installed by operator in kind-e2e test.
net-contour should verify that it works with contour-operator.
Note operator yaml (./config/contour-operator/) is not included in release bundle for now.
Fixes https://github.com/knative-sandbox/net-contour/issues/385

If so then the operator should probably use the vendored contour

Should we have the operator use our vendored ko version
https://github.com/projectcontour/contour-operator/blob/main/cmd/contour-operator.go#L34-L35
ie. add the flag to on the operator deployment? --contour-image ko://github.com/projectcontour/contour/cmd/contour
https://github.com/knative-sandbox/net-contour/blob/eccaac502cac9168c94027a3595b8ad9db26ad23/hack/update-deps.sh#L61-L63

Hmm... ko apply  command can resolve the image in --contour-image ko://github.com/projectcontour/contour/cmd/contour option? I tried but it seems not possible.

It should work - ko checks every string in a yaml file for a ko:// prefix I believe
ie. https://github.com/knative/serving/blob/main/config/core/configmaps/deployment.yaml#L27
You would just need to manipulate the operator yaml and add that argument to the container

Umm... The configmap works as:
$ ko resolve -f config/core/configmaps/deployment.yaml |grep queueSidecarImage
  queueSidecarImage: gcr.io/gcp-compute-engine-223401/queue-39be6f1d08a095bd076a71d288d295b6@sha256:136c0d19dc4094f326b300a20e9737ff0fe8da6b50e1622daa63671469050be1

But opertor deployment's command line is not working.
$ ko resolve  -f config/contour-operator/operator.yaml  |grep contour-image
            - --contour-image ko://github.com/projectcontour/contour/cmd/contour

Okay, it seems that the ko with the following format can work but it does not work with  --contour-image in front of ko://.
somekey: ko://github.com/projectcontour/contour/cmd/contour

Ah - maybe make it two separate items in the args array?
On Wed, May 19, 2021 at 22:04 Kenjiro Nakayama @.***>
wrote:

Okay, it seems that the ko with the following format can work but it does
not work with --contour-image in front of ko://.
somekey: ko://github.com/projectcontour/contour/cmd/contour
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/knative-sandbox/net-contour/pull/499#issuecomment-844625465,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAERAWK5VYTWGZJKE6GDQLTORU3RANCNFSM4462FCXQ
.

Yeah, the separated line as below works with ko but now it hits contour-operator's issue https://github.com/projectcontour/contour-operator/issues/363
        - --contour-image
        - ko://github.com/projectcontour/contour/cmd/contour

In short, contour-operator creates label from image tag, but ko command creates 64 length tag which exceeds labels length limiation.


Support FlySystem v3

Describe the bug
FlySystem v2 was released as stable on November 24th, 2020. v3 was released on January 13th 2022.
Are there any plans to move filegator to use more recent versions of FlySystem?
Are there any big problems that need to be dealt with for realizing this?

Hi,
The ZipAdapter is not implemented in v3, and we need that here
https://flysystem.thephpleague.com/v1/docs/adapter/zip-archive/

@SamMousa @alcalbg can u guys help me out
https://github.com/filegator/filegator/issues/348

I have helped myself by blocking you. Not sure why you would randomly post in an issue unrelated to your issue and ping issue creators that are not even related to this project.


django tensorflow

django version:2.1.1
python version:3.5.2
tensorflow-gpu version:1.9.0
keras version:2.2.4
anaconda:4.5.11
I have a tensorflow project, I ran it with pycharm and it worked. then I want to run it in django ,but there have some import problem. through set source path or  append os.path, it didn't work.
the frame of the project:
tmp/
---ocr_django/
-------ocr_django/
----------ocr/
-------------ctpn/
-------------demo/
-------------densenet/
-------------train/
-------------init.py
-------------demo.py
-------------ocr.py
-------------recongnize.py
----------init.py
----------original.py
----------setting.py
----------test.py
----------urls.py
----------view.py
----------wsgi.py

the problem as follow:
Traceback (most recent call last):
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/utils/autoreload.py", line 225, in wrapper
fn(*args, **kwargs)
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/core/management/commands/runserver.py", line 117, in inner_run
self.check(display_num_errors=True)
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/core/management/base.py", line 379, in check
include_deployment_checks=include_deployment_checks,
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/core/management/base.py", line 366, in _run_checks
return checks.run_checks(**kwargs)
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/core/checks/registry.py", line 71, in run_checks
new_errors = check(app_configs=app_configs)
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/core/checks/urls.py", line 13, in check_url_config
return check_resolver(resolver)
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/core/checks/urls.py", line 23, in check_resolver
return check_method()
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/urls/resolvers.py", line 396, in check
for pattern in self.url_patterns:
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/utils/functional.py", line 37, in get
res = instance.dict[self.name] = self.func(instance)
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/urls/resolvers.py", line 533, in url_patterns
patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/utils/functional.py", line 37, in get
res = instance.dict[self.name] = self.func(instance)
File "/home/cq/anaconda3/lib/python3.5/site-packages/django/urls/resolvers.py", line 526, in urlconf_module
return import_module(self.urlconf_name)
File "/home/cq/anaconda3/lib/python3.5/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 986, in _gcd_import
File "", line 969, in _find_and_load
File "", line 958, in _find_and_load_unlocked
File "", line 673, in _load_unlocked
File "", line 665, in exec_module
File "", line 222, in _call_with_frames_removed
File "/home/cq/桌面/tmp/ocr_django/ocr_django/urls.py", line 18, in
from . import view
File "/home/cq/桌面/tmp/ocr_django/ocr_django/view.py", line 22, in
from .ocr.recognize import recognize
File "/home/cq/桌面/tmp/ocr_django/ocr_django/ocr/recognize.py", line 7, in
from .ctpn.text_detect import text_detect
File "/home/cq/桌面/tmp/ocr_django/ocr_django/ocr/ctpn/text_detect.py", line 7, in
from .lib.utils.timer import Timer
File "/home/cq/桌面/tmp/ocr_django/ocr_django/ocr/ctpn/lib/init.py", line 4, in
from ocr_django.ocr.ctpn.lib import fast_rcnn
File "/home/cq/桌面/tmp/ocr_django/ocr_django/ocr/ctpn/lib/fast_rcnn/init.py", line 5, in
from . import train
File "/home/cq/桌面/tmp/ocr_django/ocr_django/ocr/ctpn/lib/fast_rcnn/train.py", line 5, in
from ..roi_data_layer.layer import RoIDataLayer
File "/home/cq/桌面/tmp/ocr_django/ocr_django/ocr/ctpn/lib/roi_data_layer/init.py", line 4, in
from . import roidb
File "/home/cq/桌面/tmp/ocr_django/ocr_django/ocr/ctpn/lib/roi_data_layer/roidb.py", line 5, in
from ocr_django.ocr.ctpn.lib.utils.bbox import bbox_overlaps
File "/home/cq/桌面/tmp/ocr_django/ocr_django/ocr/ctpn/lib/utils/init.py", line 11, in
from ocr_django.ocr.ctpn.lib.utils import bbox
ImportError: cannot import name 'bbox'

there are three files named:"bbox.c", "bbox.pyx","bbox.cpython-36m-x86_64-linux-gnu.so" in the package of ocr/ctpn/lib/utils. I've found a lot of solutions online, but none of them succeeded.
the solutions include:
1.right-click the project name in pycharm - > Mark Directory as - > source root to set the package as sources root
2.file - >setting - >project structure to set the package as source
3.change the code "from . import bbox" in /home/cq/桌面/tmp/ocr_django/ocr_django/ocr/ctpn/lib/utils/init.py to "from ocr_django.ocr.ctpn.lib.utils import bbox"

This question is better asked on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
If you think we've misinterpreted a bug, please comment again with a clear explanation, as well as all of the information requested in the issue template. Thanks!


mysql database backup

Hi! I am using your docker-compose-wamp its very useful. Now i want to do a backup of my database, do you have any script to do that? Or some advise.
Thanks

The mysqldump client utility can dump a database including the SQL statements required to rebuild the database.
By default, the dump file includes the SQL commands to restore the tables and data.
To back up your MySQL database, the general syntax is:
sudo mysqldump -u [user] -p [database_name] > [filename].sql
Replace [user] with your username and password (if needed).
The [database_name] is the path and filename of the database.
The > command specifies the output.
[filename] is the path and filename you want to save the dump file as.


Fix AtlasTexture get_image() return null

Port of https://github.com/godotengine/godot/pull/53157 for master branch
Bugsquad edit: Fixes #44529

Thanks! Congrats for your first merged Godot contribution :tada:


Add imagePullPolicy and imagePullSecrets to domain-home-in-image sample

The PR contains the following changes:

Add image, imagePullPolicy  and imagePullSecrets to create-domain-inputs.yaml.
Add the new elements to domain-template.yaml
Refactor the create-domain.sh for on pv sample and moved the related code to common validate.sh.
Update the README.md.

I am still having trouble pulling the image but the generated yaml file looks good.

Jenkins run is clean http://wls-jenkins.us.oracle.com/job/weblogic-kubernetes-operator-javatest/746/.


Multiple syntactic errors slows vim down quite a lot

Hi,
I'm just editing an old project I got from a colleague and its index.html alone is kind of full with syntactic errors (90+) - like missing close-tags and unsupported or wrong attributes like empty targets on links. Navigating around that page is really slow. I fixed a few errors so I got down to around 50 but it still is quite slow to navigate through the page. I then disabled the plugin and it works just fine.
:ver " system
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled May  2 2017 03:55:34)
MacOS X (unix) version
Included patches: 1-596
Compiled by Homebrew
Huge version without GUI.  Features included (+) or not (-):
+acl             +clipboard       +dialog_con      +file_in_path    +job             -lua             +mouse_sgr       +path_extra      +rightleft       +tag_old_static  +user_commands   +writebackup
+arabic          +cmdline_compl   +diff            +find_in_path    +jumplist        +menu            -mouse_sysmouse  +perl            +ruby            -tag_any_white   +vertsplit       -X11
+autocmd         +cmdline_hist    +digraphs        +float           +keymap          +mksession       +mouse_urxvt     +persistent_undo +scrollbind      -tcl             +virtualedit     -xfontset
-balloon_eval    +cmdline_info    -dnd             +folding         +lambda          +modify_fname    +mouse_xterm     +postscript      +signs           +termguicolors   +visual          -xim
-browse          +comments        -ebcdic          -footer          +langmap         +mouse           +multi_byte      +printer         +smartindent     +terminfo        +visualextra     -xpm
++builtin_terms  +conceal         +emacs_tags      +fork()          +libcall         -mouseshape      +multi_lang      +profile         +startuptime     +termresponse    +viminfo         -xsmp
+byte_offset     +cryptv          +eval            -gettext         +linebreak       +mouse_dec       -mzscheme        +python          +statusline      +textobjects     +vreplace        -xterm_clipboard
+channel         +cscope          +ex_extra        -hangul_input    +lispindent      -mouse_gpm       +netbeans_intg   -python3         -sun_workshop    +timers          +wildignore      -xterm_save
+cindent         +cursorbind      +extra_search    +iconv           +listcmds        -mouse_jsbterm   +num64           +quickfix        +syntax          +title           +wildmenu
-clientserver    +cursorshape     +farsi           +insert_expand   +localmap        +mouse_netterm   +packages        +reltime         +tag_binary      -toolbar         +windows
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/usr/local/share/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -fstack-protector -L/usr/local/lib -L/usr/local/opt/libyaml/lib -L/usr/local/opt/openssl/lib -L/usr/local/opt/readline/lib  -L/usr/local/lib -o vim        -lncurses -liconv -framework Cocoa   -mmacosx-version-min=10.12 -fstack-protector-strong -L/usr/local/lib  -L/usr/local/Cellar/perl/5.24.1/lib/perl5/5.24.1/darwin-thread-multi-2level/CORE -lperl -lm -lutil -lc -F/usr/local/opt/python/Frameworks -framework Python   -lruby.2.4.1 -lobjc

:ver " MacVim
VIM - Vi IMproved 8.0 (2016 Sep 12, compiled Jul 25 2017 05:00:22)
MacOS X (unix) version
Included patches: 1-771
Compiled by<EMAIL_ADDRESS>Huge version with MacVim GUI.  Features included (+) or not (-):
+acl             +clipboard       +dialog_con_gui  +file_in_path    +insert_expand   +localmap        +mouse_netterm   +odbeditor       +quickfix        +syntax          +timers          +vreplace        -xterm_clipboard
+arabic          +cmdline_compl   +diff            +find_in_path    +job             +lua/dyn         +mouse_sgr       +packages        +reltime         +tag_binary      +title           +wildignore      -xterm_save
+autocmd         +cmdline_hist    +digraphs        +float           +jumplist        +menu            -mouse_sysmouse  +path_extra      +rightleft       +tag_old_static  +toolbar         +wildmenu
+balloon_eval    +cmdline_info    +dnd             +folding         +keymap          +mksession       +mouse_urxvt     +perl/dyn        +ruby/dyn        -tag_any_white   +transparency    +windows
+browse          +comments        -ebcdic          -footer          +lambda          +modify_fname    +mouse_xterm     +persistent_undo +scrollbind      -tcl             +user_commands   +writebackup
++builtin_terms  +conceal         +emacs_tags      +fork()          +langmap         +mouse           +multi_byte      +postscript      +signs           +termguicolors   +vertsplit       -X11
+byte_offset     +cryptv          +eval            +fullscreen      +libcall         +mouseshape      +multi_lang      +printer         +smartindent     +terminal        +virtualedit     -xfontset
+channel         +cscope          +ex_extra        -gettext         +linebreak       +mouse_dec       -mzscheme        +profile         +startuptime     +terminfo        +visual          +xim
+cindent         +cursorbind      +extra_search    -hangul_input    +lispindent      -mouse_gpm       +netbeans_intg   +python/dyn      +statusline      +termresponse    +visualextra     -xpm
+clientserver    +cursorshape     +farsi           +iconv           +listcmds        -mouse_jsbterm   +num64           +python3/dyn     -sun_workshop    +textobjects     +viminfo         -xsmp
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  system gvimrc file: "$VIM/gvimrc"
    user gvimrc file: "$HOME/.gvimrc"
2nd user gvimrc file: "~/.vim/gvimrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
    system menu file: "$VIMRUNTIME/menu.vim"
  fall-back for $VIM: "/Applications/MacVim.app/Contents/Resources/vim"
Compilation: clang -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_MACVIM -Wall -Wno-unknown-pragmas -pipe  -DMACOS_X_UNIX  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: clang   -L. -fstack-protector -L/usr/local/opt/libyaml/lib -L/usr/local/opt/readline/lib -L/usr/local/opt/libksba/lib -L/usr/local/opt/openssl/lib  -L. -fstack-protector -L/usr/local/opt/libyaml/lib -L/usr/local/opt/readlin
e/lib -L/usr/local/opt/libksba/lib -L/usr/local/opt/openssl/lib   -L/usr/local/lib -o Vim -framework Cocoa -framework Carbon       -lm  -lncurses -liconv -framework Cocoa   -fstack-protector  -L/System/Library/Perl/5.16/darwin-threa
d-multi-2level/CORE

Syntastic version: 3.8.0-34 (Vim 800, Darwin)
Info for filetype: html
Global mode: active
Filetype html is active
The current file will be checked automatically
Available checkers: tidy validator w3
Currently enabled checker: tidy

:mer
Messages maintainer: Bram Moolenaar<EMAIL_ADDRESS>"~/Clients/kalbeck/gutmann/gutmann-add-site/index.html" [noeol] 253L, 12712C
Syntastic version: 3.8.0-34 (Vim 800, Darwin)
Info for filetype: html
Global mode: active
Filetype html is active
The current file will be checked automatically
Available checkers: tidy validator w3
Currently enabled checker: tidy
Syntastic version: 3.8.0-34 (Vim 800, Darwin)
Info for filetype: html
Global mode: active
Filetype html is active
The current file will be checked automatically
Available checkers: tidy validator w3
Currently enabled checker: tidy

Yes, syntastic is as slow (or as fast) as the linters it's running, which is why you aren't supposed to run it unconfigured.  Read :h 'syntastic_mode_map' to find out how to turn off automatic checking.  Read :h syntastic-html-tidy and :h syntastic-filtering-errors to find out how to weed out some of the useless messages (which won't speed up running tidy though).  Start reading the manual from the beginning (:h syntastic) to find out what else you can tweak to suit your needs.
Alternatively, switch to a plugin that runs linters asynchronously, such as ALE or Neomake, and / or complain to tidy developers about tidy being too slow.

Thank you :) that is already great help


JsonField not rendering correctly in Dark Theme

+Logo on welcome page in toolbox not accounting for themes either


Remove retry methods from non-reactive types

retry can throw an exception if it ultimately fails and non-reactive types don't handle this cleanly (rethrow introducing a source of errors)

Merged


Add options to the Email engagement area

Options to resend, delete, view need to be added

I'm not sure if this is needed. At least not for the MVP. I'm working on a proper pages for the influencer and distribution lists.

This is not necessary for the MVP, however, we should perhaps hide some of the functionality for the initial release that does not work.

Actually, reopening and moving outside of MVP.


Dynamic serviceaccount/role/rolebinding creation

This PR dyamically creates the above resources within the namespace of the requested Horizon instance.
The above resources are no longer created via OLM.
This allows the operator to deploy openstack service into any namespace within the OpenShift cluster.

/lgtm


[Feature] Support Google Fonts

Feature Description
Add support to test Google Fonts
Reason for Change
To allow more flexibility to use the app.
Where are the changes needed?
Probably in FontUploader.tsx, maybe in FontPreview.tsx.
Code Snippets
No response
Anything Else?
For release 3

Feature has been implemented, closing issue.


Cleanse text on Record name field on save.

This change is

Coverage increased (+0.02%) to 67.995% when pulling f9e78b23e8e504bb70d45dab1f21f6d5080d49a8 on ropable:master into 977659c080d59b168c6de9e8ce9784e6dd083a68 on parksandwildlife:master.


Add "Raw search" mode to new search UI

Checklist

[x] the contributor license agreement is signed
[x] commit message follows commit guidelines
[x] tests are included
[x] screenshots are included showing significant UI changes

Description of change

Adds a toggle to the search page for "raw search" mode.
When raw search is off, search queries are de-bounced type-ahead, sent to the server side with an appended '*' wildcard
When raw search is on, search queries are sent as-is, and only when you hit enter
Helper-text to remind the user to hit Enter appears when in raw search mode
Tool-tip appears when hovering on the toggle to explain the purpose of raw search mode
Jest tests to assert that type-ahead and wildcard append happen in simple search mode
Jest test to assert that type-ahead and wildcard append do not happen in raw search mode

Test failures are caused by using jest.advanceTimersByTime alongside setTimeout. Run individually, each test passes. I'm reluctant to fix them before #2032 gets merged in as it changes the way this is done in this test file and would need accounting for anyway.

Closing and redoing the PR as for some reason it isn't showing my latest commits to this branch.


How do I write a function call component with mitosis?

I am interested in helping provide a feature!
Yes
Which generators are impacted?

[X] All
[ ] Angular
[ ] HTML
[ ] Qwik
[ ] React
[ ] React-Native
[ ] Solid
[ ] Stencil
[ ] Svelte
[ ] Vue
[ ] Web components

What problem does this feature solve?
How do I write a function call component with mitosis?
Example:
import { Message } from 'xxxx'

Message.xxx()

What does the proposed API look like?
I'm hoping to help me answer this confusion and successfully write functional components!
Additional Information
No response

I'm not sure what a "function call component" means here. Can you show an example in a web framework (like React, Vue, Svelte, Qwik)?

OK, let's take the most notable examples of react and vue.
react
https://ant.design/components/message
vue
https://arco.design/vue/en-US/component/message

These docs are long, I'm not sure what I'm meant to be looking at.
For reference though:

in Mitosis, you can only have one default export in your .lite.tsx files. You cannot export anything else from the Mitosis component files themselves. If you want to export anything else, it should come from a plain .ts file.
in Mitosis, we have no support for any custom use* hooks at this moment.

These docs are long, I'm not sure what I'm meant to be looking at.
For reference though:

in Mitosis, you can only have one default export in your .lite.tsx files. You cannot export anything else from the Mitosis component files themselves. If you want to export anything else, it should come from a plain .ts file.
in Mitosis, we have no support for any custom use* hooks at this moment.

I think you should look at the way functional components are used to understand! It can be not hooks, it can be static method's!

@samijaber Can you help me figure out how to implement a component with functional calls?

As I wrote in my last comment:
in Mitosis, you can only have one export in your .lite.tsx files: the default export (which will be your component). You cannot export anything else from the Mitosis component files. If you want to export a function, it should be written in a separate .ts file and exported that way.

Okay, I'll try it when I have time!


Floating UI: Navbar

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the Modus style guidelines

Proposal
This is a ticket outlining the work to be done on the Navbar in the floating UI style that has been discussed with the modus team.
This development can be carried out by the Creator/Nexus team.
Original Navbar:

Floating UI Navbar:

Trimble Creator Navbar:

We would like to develop this as a modus web-component, and then contribute it back to modus
Motivation and context
Floating UI is a critical part of a canvas-style application such as Trimble Creator, SketchUp, Maps, and more. This UI allows the user to focus more o the creative space rather than the encompassing UI.
What is the issue regarding ?
@trimble-oss/modus-web-components
Priority
Medium
What product/project are you using Modus Components for ?
Trimble Creator
What is your team/division name ?
Nexus
Are you willing to contribute ?
Yes
Are you using Modus Web Components in production ?
Not yet, this will be one of the first steps on our migration to web-components in Trimble Creator.

Question to clarify:

MoAB decisions 9/22/2023:

Corner radius should be the same as Toolbar component, Figma - 4px
https://www.figma.com/file/wyfVJUHWRMkeCfdB38HFEE/Modus---Web?node-id=23208%3A3351&mode=dev
Spacing between each floating element inside the Navbar is 4px.
Minimum requirement for navbar elements: logo and user profile. Others optional. Currently no restriction.
@msankaran0712

Great, thanks Sonia! We will have to start back up on the floating UI work after dimensions, as we will no longer have time to fit it into our sprints before then. it'll be picked back up early-mid November.


AttributeError: module 'typing' has no attribute 'GenericMeta'

This issue occurs with python 3.8, typing==<IP_ADDRESS>

I have the same issue and I'm using 3.6 , could you please tell me how to solve it?

We now fully support Python 3.8.


v2.9.2 additional folders break dependent builds on windows

Environment
azure-pipelines-task-lib version: v2.9.2
Issue Description
We had our package.json set to ^v2.7.7, so we automatically received the v2.9.2 package when it was shipped Friday. This includes a _download/archive folder of nested node_modules folders that exceeds 256 character file paths. When our build copies these files or attempts to delete the folder on Clean, it fails.
Expected behaviour
npm install azure-pipelines-task-lib --production only includes necessary files
Actual behaviour
npm install azure-pipelines-task-lib --production includes additional files that are longer than 256 characters, breaking some copy/clean up build steps on dependent Windows consumers
Steps to reproduce

Install azure-pipelines-task-lib on Windows (anywhere)
Open a File Explorer to the folder
Attempt to delete the folder
Observe errors

Mitigation
We updated our build to hard reference v2.8.0. Non-blocking, no rush.

Hey, sorry we didn't close the loop here - we published 2.9.3 to fix this a little while back. I'm going to close here, if this is still causing issues please comment and we can reopen


updatedoc

update SynapseML documentation

Learn Build status updates of commit 669db98:
:warning: Validation status: warnings

File
Status
Preview URL
Details

[articles/synapse-analytics/Cognitive Services with SynapseML - Overview.md](https://github.com/JessicaXYWang/azure-docs/blob/master/articles/synapse-analytics/Cognitive Services with SynapseML - Overview.md)
:warning:Warning

Details

[articles/synapse-analytics/Cognitive Services with SynapseML - Overview.md](https://github.com/JessicaXYWang/azure-docs/blob/master/articles/synapse-analytics/Cognitive Services with SynapseML - Overview.md)

Line 4, Column 9: [Warning: author-not-found - See documentation] Invalid value for author: 'mhamilton723, serena-ruan, ppruthi, k-rush' is not a valid GitHub ID.
Line 10, Column 24: [Warning: alt-text-missing - See documentation] Missing alternate text for image 'https://mmlspark.blob.core.windows.net/graphics/Readme/cog_services_on_spark_2.svg'. Alt text is required for accessibility.
Line 12, Column 1: [Warning: h1-not-first - See documentation] Markdown content is not allowed before H1 'Cognitive Services'.
Line 14, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 19, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/computer-vision/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 28, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/face/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 36, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/speech-services/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 43, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/text-analytics/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 52, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/translator/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 62, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/form-recognizer/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 73, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/anomaly-detector/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 78, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/bing-image-search-api/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 79, Column 3: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/azure/search/search-what-is-azure-search' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 83, Column 24: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/azure/cognitive-services/big-data/getting-started' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 141, Column 5: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/text-analytics/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 176, Column 5: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/azure/cognitive-services/language-service/text-analytics-for-health/overview?tabs=ner' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 201, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/translator/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 235, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/form-recognizer/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 274, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/computer-vision/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 310, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/bing-image-search-api/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 345, Column 5: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/speech-services/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 370, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/text-to-speech/#overview' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 408, Column 1: [Warning: hard-coded-locale - See documentation] Link 'https://azure.microsoft.com/en-us/services/cognitive-services/anomaly-detector/' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 0, Column 0: [Suggestion: external-image] Image 'https://mmlspark.blob.core.windows.net/graphics/Readme/cog_services_on_spark_2.svg' references an external site. This poses a security risk and external images are unavailable in some environments. Reference an image file within the repo instead.
Line 5, Column 12: [Suggestion: ms-author-invalid - See documentation] Invalid value for 'ms.author', 'marhamil, serenaruan, ppruthi, kyrush' is not a valid Microsoft alias.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@JessicaXYWang
Microsoft authors and contributors need to make content contributions through the private repository so the content can be staged and validated by the current validation rules.
After you make your changes in the private repo, review the articles on staging, and fix any validation issues, you can add the sign-off comment to let PR reviewers know that the updates are ready to be merged.
Read about authors working in the public repo for more information.
If you need help getting set up to work in the private repo, see Set up Git repository locally for documentation.
We'll close this PR. Thank you.


Update User Profile Feature

Create an edit option for user so that he/she can update information.

User will be able to update profile information. (#152 )


Linked Account does not display non-ASCII characters

Issue Type: Bug
If the display name of a microsoft account contains non-ASCII characters, they are not displayed correclty encoded
Azure Data Studio version: azuredatastudio 1.19.0 (4095037f2578c23033867e611e82c13de114ca5a, 2020-06-11T22:06:05.429Z)
OS version: Windows_NT x64 10.0.18363

Closing as we now support UTF8 characters


Qt 6 support

I was wondering if there were any plans to support Qt 6, if so any idea when we can expect the crate to support it?

FWIW, I'm trying to port Fu510nTrader from Python/PyQt6 to Rust and was disappointed to only find Qt5 supported in Rust so I'm taking a crack at getting rust-qt/ritual working with Qt 6.6.2.  I've gotten fairly far down the GTK4 path (which has had it's own set of issues) but generating the chart UI is a "non-trivial task" so figured it worth seeing if I can get my existing code ported first.


Improve cross-mod compatibility in Fabric.

I received a report from a user that their game was crashing when my mod (Iceberg) was installed alongside MapTooltip. (https://github.com/AHilyard/Iceberg/issues/10)
Iceberg is a library that does a lot of work with tooltips behind the scenes to support other mods that modify tooltips.  I looked into the issue and found it was due to the mixin you are using in the Fabric version of MapTooltip, this method of adding components to tooltips unfortunately makes it difficult to support in other mods that process tooltip components.
Luckily Fabric API has an event that is meant for this situation, so this PR implements that event.  The only downside would be that Fabric API will once again be a dependency for your mod, but I believe most Fabric users will have it installed already anyways if they have more than a few mods installed.
Thanks for your consideration!

Yeah this is way better than what I was doing.
Is there any benefit to renderTooltip being a static method?

If there is any benefit to using static methods for event handlers, the difference is likely negligible.  I just made it static out of habit, as that's how I make all my handlers.  You could do away with the static and just reference it as this::renderTooltip if you prefer. 😄

Ok, just wanted to make sure


ES6 modules

Would be nice if the project was using ES6 modules and then transpiled to cjs, amd and global. Would you accept a PR to do so ?

I don't think modules would really help here; the library is literally just one file and I want to keep it that way for now. Each piece of functionality to too small to split out and it would just make it hard to work in this case.

If there's anything I can do to make it easier to consume this lib from other module systems, let me know.


chore: auto lint

Description
solve linter issues

Codecov Report

Merging #1889 (23c98a0) into main (8167223) will increase coverage by 0.08%.
The diff coverage is 17.85%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1889      +/-   ##
==========================================
+ Coverage   55.97%   56.05%   +0.08%
==========================================
  Files          93       93
  Lines        8941     8930      -11
==========================================
+ Hits         5005     5006       +1
+ Misses       3565     3553      -12
  Partials      371      371

Impacted Files
Coverage Δ

util/decmath/decmath.go
92.98% <ø> (ø)

x/leverage/types/proposal.go
33.33% <ø> (ø)

x/oracle/keeper/params.go
71.92% <ø> (ø)

x/uibc/query.pb.gw.go
0.00% <0.00%> (ø)

x/uibc/quota/keeper/quota.go
37.05% <11.76%> (-1.84%)
:arrow_down:

x/oracle/keeper/msg_server.go
65.11% <100.00%> (+0.41%)
:arrow_up:

x/uibc/params.go
63.41% <100.00%> (ø)


Removed root processes

Context

Continuation of #167
Allows container to be ran with --user but still runs with PUID & GUID.

Choices

Keeping the ability to still run as root as to not break anything. Ideally we would later change the image so PUID/PGID is not used and --user must be used.

Test instructions

[!IMPORTANT]
You must set user to NUMBERICAL_UID:NUMBERICAL_GID
To find your UID run id -u & to find your GID run id -g. In the examples they are listed as 1000:1000.
If you wish to run it as a different UID/GID this can by done by changing the ownership: chown UID:GID palworld/
or by changing the permissions for all other: chmod o=rwx palworld/

Try to start the container as root:root, It should work
Try to start the container as root:steam, Given error
Try to start the container as steam:root, Given error
Start container with 1000:1000 (This is the same as steam:steam)
Verify rcon-cli is working: docker exec palworld-server rcon-cli showplayers
Verify backup works: docker exec palworld-server backup
Verify no processes are running as root: docker exec -t palworld-server top -n 1
Verify supercronic is running: docker exec -t palworld-server bash -c "top -n 1 | grep --color supercronic"

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I've added documentation about this change to the README.
[x] I've not introduced breaking changes.

Still in progress.

Would it be possible to port these changes to a true rootless container? Like the one https://github.com/CM2Walki/steamcmd offers?

Would it be possible to port these changes to a true rootless container? Like the one https://github.com/CM2Walki/steamcmd offers?

Yes.
Now if we do that we have two options.

Only start as steam (1000:1000) however this means the files that are created are owned by 1000:1000 in your binds so you must make sure 1000 has permission in the bind.
Allow them to start as any nonroot user. Just need to remove the su and all root specific tasks.

@thijsvanloef There is no advantage to switching from cm2network/steamcmd:root to cm2network/steamcmd:steam as we would have to change to root in the dockerfile to install packages then switch back to steam.
If you want to move forward on dropping PUID/PGUID and running with user: 0:0 then let me know and I can implement that.

There is no advantage to switching from cm2network/steamcmd:root to cm2network/steamcmd:steam as we would have to change to root in the dockerfile to install packages then switch back to steam.

Yeah I believe that is why I opened this repo with the base image with the :root tag.
I want to keep the PUID/PGUID as that keeps it backwards compatible, and close to the linuxserver.io standard.
I would much rather keep the PUID PGID and drop the user: 0:0 from the examples as that confuses people