running markbind returns syntax error

Installed markbind using npm as suggested in the Quickstart -> Install page.
When I try to run markbind I get the following error:
anarayan@minibuntu1604:~/Workspace/CS2103/website$ markbind
/usr/lib/node_modules/markbind-cli/index.js:30
);
^

SyntaxError: Unexpected token )
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:542:28)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:383:7)
    at startup (bootstrap_node.js:149:9)

My setup:
anarayan@minibuntu1604:~/Workspace/CS2103/website$ npm --version
3.10.10
anarayan@minibuntu1604:~/Workspace/CS2103/website$ node
node    nodejs
anarayan@minibuntu1604:~/Workspace/CS2103/website$ nodejs --version
v6.12.3
anarayan@minibuntu1604:~/Workspace/CS2103/website$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=16.04
DISTRIB_CODENAME=xenial
DISTRIB_DESCRIPTION="Ubuntu 16.04.3 LTS"
anarayan@minibuntu1604:~/Workspace/CS2103/website$

What is the suggested node version? Install page said 6.5 above; I installed 6.12

We probably need to update the instructions. Current node version is 8.*
BTW, we updated markbind just a few days ago. That why it needs the latest node. Node 6 was enough for the previous markbind, but not the latest one.

Thanks for the feedback! I've updated the Installation and Developer Environment sections.

v1.4.3 and above: Node.js with version 8.0 or higher is required.

Works with Node.js 8.9; I will close this issue


Server bundles are minified by default

🐞 Bug report
Command (mark with an x)

[ ] new
[x] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[ ] update
[ ] lint
[ ] xi18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
No
Description
By default, the production server bundles generated by the Angular CLI are minified, making debugging much harder, despite the code comment at https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/common.ts#L416 reading:

// On server, we don't want to compress anything. We still set the ngDevMode = false for it
// to remove dev code, and ngI18nClosureMode to remove Closure compiler i18n code

The reason being that, when buildOptions.platform == 'server' is true, the following object is passed to the TerserPlugin compress option:
{
  ecma: terserEcma,
  global_defs: angularGlobalDefinitions,
  keep_fnames: true,
}

However, according to the TerserPlugin's docs, most compress flags default to true, so this effectively causes the server code to be minified.
In addition, unsetting the scripts optimizations in angular.json causes other side effects, namely ngDevMode no longer being explicitly set to false, causing the server code to run in dev mode by default.
"optimization": {
  "scripts": false,
  "styles": true
},

One workaround is to set the NG_BUILD_DEBUG_OPTIMIZE flag, which does turn off compress, but my concern is that it would get removed & renamed at some point since it's undocumented.
I think compress  should be set to false for server builds, as per the code comment currently reads, as working with minified code on the server is a pain. It would cause server-side bundles to jump in size, e.g. for my (fairly large) app is goes from 20 MB (with optimization: true) to 32 MB (with optimization: true but compress: false), but is definitely worth it IMO.

Ivy Workspace:

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.901.1
@angular-devkit/core         9.1.1
@angular-devkit/schematics   9.1.1
@schematics/angular          9.1.1
@schematics/update           0.901.1
rxjs                         6.5.4

Hi @laurentgoudet,
This was one of the changes in version 9 where server production code is minified, one of the main reasons behind this is to speed up server cold starts and reduce deployment times.
What I suggest is to generate sourcemaps and attach them, which will provide a better debug experience.
That being said, in the future we should probably provide different levels of optimizations.

Hi, lets continue tracking this in #15761


dev tooling: Make streams and initial messages more like production.

The pseudo-code for setting up a realm in production is
realm = do_create_realm(..)
setup_initial_streams(realm)
user = do_create_user(..) # the admin, e.g. Iago
setup_initial_private_stream(user)
send_initial_pms(user)
send_initial_realm_messages(realm)

The task is basically to replace the creation of zulip_realm and possibly also mit_realm in populate_db.py with code like above.
It will also require some changes to how the admin user is created, and then changes later on down the file in terms of stream creation and other things. Though we also don't need to keep any of the stream_list or zulip_stream_dict streams, if that simplifies things.

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot  claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@zulipbot claim

@rishig sir may be this issues seems already solved, If I'm wrong so please guide me


Added Wiremock helper

Codecov Report

Merging #1 (5bb704c) into main (40cc787) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              main      #1   +/-   ##
=======================================
  Coverage     0.00%   0.00%
- Complexity      44      57   +13
=======================================
  Files           12      13    +1
  Lines          139     172   +33
=======================================
- Misses         139     172   +33

Flag
Coverage Δ

unittests
0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/Helper/WireMockHelper.php
0.00% <0.00%> (ø)

src/TestCase/FunctionalTestCaseAbstract.php
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40cc787...5bb704c. Read the comment docs.


Remove rsync from build step

replace with cp and rm commands

JIRA: RAIL-4047

Build succeeded (check pipeline).

https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/374/ : SUCCESS in 1m 06s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-oss-check/294/ : SUCCESS in 14s

Build in pipeline check aborted.

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-merge-compliance-check/154/ : SUCCESS in 19s
https://checklist.intgdc.com/job/client-libs/job/gooddata-create-gooddata-react-app-unit-tests-zuul-docker-el7/376/ : SUCCESS in 56s
https://checklist.intgdc.com/job/compliance/job/gooddata-create-gooddata-react-app-fossa-scanning-zuul-el7/119/ : SUCCESS in 43s (non-voting)


Xavivars bugfix/trailingslash in pagination

Fixed test for #1112

Coverage increased (+5.1%) to 93.628% when pulling 4720b8d66a351db62105f91a63d85b276964e228 on xavivars-bugfix/trailingslash-in-pagination into ce467707192d42c868570e94572847316f1b4261 on master.

Coverage increased (+5.1%) to 93.628% when pulling 8d5b6e7774d987c80be056769b6847c1f9681e05 on xavivars-bugfix/trailingslash-in-pagination into ce467707192d42c868570e94572847316f1b4261 on master.

This closes #1109 and #1112 — thanks @xavivars for your help!

Thank you @jarednova! I missed a bunch of cases, but it seems the my changes were in the right direction!


Update to 1.23.1

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Distance Matrix url has "/maps/api/distanceMatrix/json" should be "/maps/api/distancematrix/json".  Was receiving a 404 not found

Thanks for stopping by to let us know something could be better!

PLEASE READ
If you have a support contract with Google, please create an issue in the support console. This will ensure a timely response.
Discover additional support services for the Google Maps Platform, including developer communities, technical guidance, and expert support at the Google Maps Platform support resources page.
If your bug or feature request is not related to this particular library, please visit the Google Maps Platform issue trackers.
Check for answers on StackOverflow with the google-maps tag.

Please be sure to include as much information as possible:
Environment details

DistanceMatrixApi
Windows 10
[v1.17.6]

Steps to reproduce

Calling DistanceMatrixApi

Code in specification
"/maps/api/distanceMatrix/json": {       "get": {         "operationId": "distanceMatrix",         "servers": [           {             "url": "https://maps.googleapis.com"           }         ],         "tags": [           "Distance Matrix API"         ],         "description": "The Distance Matrix API is a service that provides travel distance and time for a matrix of origins and destinations. The API returns information based on the recommended route between start and end points, as calculated by the Google Maps API, and consists of rows containing duration and distance values for each pair.",         "parameters": [           {             "$ref": "#/components/parameters/arrival_time"           },           {             "$ref": "#/components/parameters/departure_time"           },           {             "$ref": "#/components/parameters/distancematrix_avoid"           },
# example

Stack trace
# example

Following these steps will guarantee the quickest resolution possible.
Thanks!

@chrisgrimaldi70 Please take a moment to fill out this short survey. Thank you!
This is an automated message, feel free to ignore.

@chrisgrimaldi70 Thank you for opening this issue. 🙏
Please check out these other resources that might be applicable:

Support Console - If you have a support contract.
Discord - chat with other developers
StackOverflow - use the google-maps tag
Google Maps Platform issue trackers

This is an automated message, feel free to ignore.

this was fixed in #266

looks like the release workflow hasn't been executing for some reason. triggered it with a comment.


I'll give you a step-for-step introduction of what I did and what I found, maybe this can help you to help me:

I'll give you a step-for-step introduction of what I did and what I found, maybe this can help you to help me:
I first took a look at Kokadas' derivation and saw that it was primarily rounded on that "solutions" entry after adding the "mkDerivation". So I searched how to write one of those, which led me to this README that I've used as the source of truth.
My first doubt was, "Should I use the paths relative to input or output?" and well, that was written there, "$out-relative paths".
The second was an observation that I've seen in Kokadas' code. He was using "sh" instead of "bash" as interpreter, which led me to ask him and then discovering bash includes a posix-mode.
Then a small try after just adding the "scripts", "interpreter", and the "inputs" I've already known lead me to that regex parsing issue of oilshell, which I solved with the sed s|^(.+) =~ ([^\$].+) ]]|regexp='\2'; \1 =~ $regexp ]]| that I based in a commit from you in 2021.
After that I had to deal with a Can't resolve dynamic argument in 'source' -- that's because airgeddon sources its scripts with source "${scriptfolder}${rc_file_name}" and well, I don't know how to correctly solve these even now :see_no_evil: -- Should I replace this with relative-hardcoded-paths, I know that I can't use absolute-hardcoded-paths -- Kokada pointed me to "keep.source" but this didn't help, "fix" somehow did the trick for the "strings" and "known_pins", and for the "plugins" in a little hacky way. But I had to leave ".airgeddonrc" out of this and use "keep" on it. (very :lost: even now)
At this point, I had already taken a look at the resholve docs. And well, I've started to add all the deps that weren't documented and resholve was finding :trophy: . That lead me to these issues in the way:

"There is not yet a good way to resolve 'ping' in Nix builds." (Which don't come up with any suggestion, I've added it as an external)

"timeout" had a "15" where the lore was expecting an "executable argument" (No clue how to say it to skip only this parameter, so I changed it to "cannot", which I'm pretty sure I should not)

you repeat "execer" twice here: https://github.com/abathur/resholve/blob/f3faceb58d731e8d9f0dd244527007cf7a1fbfcc/docs/examples/lore.nix#L14 -- should be "wrapper" right? (This repeats in that README)

"tmux" is executing its arguments, even worse, airgeddon uses "send-keys" to throw commands in it. (What should I do here? Again I went with "cannot")

I had to come up with a hacky solution to keep optional dependencies optional, using the "external".

In the end, it ran, but the scripts in heredocs inside it were not using absolute references. They were even using the unpatched shebang. Airgeddon starts running one of these inside tmux and that wasn't finding the executables.
Originally posted by @PedroHLC in https://github.com/NixOS/nixpkgs/pull/173885#discussion_r882733398

Preserving this since there are at least a few things in here that need to get individually fixed ~ASAP.

:thinking: what if, for every fatal error, resolve added a link to the wiki in the message, as shellcheck does.

There is not yet a good way to resolve 'ping' in Nix builds.
See more: https://github.com/abathur/resholve/wiki/RS00042

Like: https://github.com/koalaman/shellcheck/wiki/SC1118
It could even link to a blank page, GitHub allows you to toggle the option to "Restrict editing to collaborators only".

That (or something similar) is the long-term intent. There are a few boxes I'd like to check there...

provide specific recommendations at error time since they're a good reminder of what to do
probably link out to some other resource
drive the documentation and code from a single source

I tend towards over-thinking, and error messages and systems of appropriate codes are both things I can easily waste a lot of time what-ifing about.
I tried to sneak up on this about a year ago, as you can see in this diff, but I was spinning my wheels on specifics and decided to just freeze that effort for a bit (I think it makes sense to privilege features over docs in the short run, and at the time I was still trying to land all of this "lore" work).
This fall/winter I sorted out the basics of the documentation single-sourcing part, and started modularizing resholve's code a bit (to make it easier to generate the exceptions).
I guess that's all to say that the time is close to right. Probably a this-year sort of thing.

I'll make 2 different posts addressing this. The first focuses on things you noted that I've fixed today. The 2nd will just record some thoughts on the open questions...

That lead me to these issues in the way:

"timeout" had a "15" where the lore was expecting an "executable argument" (No clue how to say it to skip only this parameter, so I changed it to "cannot", which I'm pretty sure I should not)

Correct. You found a bug in resholve's parser for timeout. For illustration I addressed it in separate test/fix commits:

test:

commit: f6efaee4d51dd1d5e57d509bde976fc10434d61a
CI: https://github.com/abathur/resholve/runs/6638357579?check_suite_focus=true#step:4:2838

fix:

commit: 45583b78f3b6427a996ecbc306afefe8fdb1ace7
CI: https://github.com/abathur/resholve/runs/6638375722?check_suite_focus=true

you repeat "execer" twice here: https://github.com/abathur/resholve/blob/f3faceb58d731e8d9f0dd244527007cf7a1fbfcc/docs/examples/lore.nix#L14
-- should be "wrapper" right? (This repeats in that README)

Good spot. I fixed it in 99cd196f45f8e1c12389aa4cfdeff9a04f3beac3.
Both of these will need to get released and propagated to nixpkgs; not sure how quickly I'll cut a release.

"There is not yet a good way to resolve 'ping' in Nix builds." (Which don't come up with any suggestion, I've added it as an external)

Yes. Sorry that one's a bit unhelpful, but I'm intentionally making this a little disruptive. I'm hoping to make more people aware of the underlying problem to build pressure for trying to find a fix up at the Nix/nixpkgs layer.

After that I had to deal with a Can't resolve dynamic argument in 'source' -- that's because airgeddon sources its scripts with source "${scriptfolder}${rc_file_name}" and well, I don't know how to correctly solve these even now 🙈 -- Should I replace this with relative-hardcoded-paths, I know that I can't use absolute-hardcoded-paths -- Kokada pointed me to "keep.source" but this didn't help, "fix" somehow did the trick for the "strings" and "known_pins", and for the "plugins" in a little hacky way. But I had to leave ".airgeddonrc" out of this and use "keep" on it. (very :lost: even now)

I noticed this one as well. I'm not quite sure what the "right" fix will be. The ideal way to do it would be something like:
  fix = {
    # ...
    "$scriptfolder" = [ "lib/airgeddon/" ];
    "$language_strings_file" = [ "language_strings.sh" ];
    "$known_pins_dbfile" = [ "known_pins.db" ];
    # ...
  };

But...

The airgeddonrc being in share instead of lib causes trouble with this. I tried using an empty string for scriptfolder, but IIRC that broke the Nix API. I started considering a kludge like setting rc_file_name to "../share/airgeddon/.airgeddonrc".
I decided to stop fiddling with it because I wasn't 100% sure if baking in the .airgeddonrc path was the right approach in the first place? Would it be fairly normal for users to modify it? Would a fair fraction of the people who use the package expect it to be picking up ~/.airgeddonrc or something?

But as I write this out, I wonder if this would work (on macOS atm, not easy to just test...):
  fix = {
    # ...
    "$scriptfolder" = [ "./" ];
    "$language_strings_file" = [ "lib/airgeddon/language_strings.sh" ];
    "$known_pins_dbfile" = [ "lib/airgeddon/known_pins.db" ];
    "$rc_file_name" = [ "share/airgeddon/.airgeddonrc" ];
    # ...
  };

"tmux" is executing its arguments, even worse, airgeddon uses "send-keys" to throw commands in it. (What should I do here? Again I went with "cannot")

I'm not a tmux user so I'm just kinda shooting from the hip here.
If the tmux arguments are very regular, it may just be a matter of creating a parser for it in resholve. Searching through the codebase for tmux invocations didn't make it terribly obvious what all commands are getting passed through it, since it seems like most of these are in utility functions.
But, I did see a lot of run-time code-generation behavior (such as https://github.com/v1s1t0r1sh3r3/airgeddon/blob/master/airgeddon.sh#L3732-L4142) that looks like the kind of thing I'd usually mark in my notes as as too dynamic for resholve to have much hope of handling.
This may still be fine if you don't actually need to resolve commands down in these dynamic structures (for example, if the entire thing is just using shell functions that do get resolved)? If they do hold external executable references, resholve will likely end up being a ~code-intel tool for you here, with the real solution needing to be some wrapping/patching combo?
resholve also has prologue and epilogue arguments--I suppose you could use that to also inject a PATH for the same dependencies at the top of the script. (But, of course, there's a risk these scripts hold additional unknown dependencies)

I had to come up with a hacky solution to keep optional dependencies optional, using the "external".

I liked what you came up with--I've been doing the same. I haven't quite decided if resholve needs a special lever for cases like this (there's a related case with scripts that will use the first found of N alternative programs for something--curl OR wget and is a common example) or just better documentation that fits the scenarios.

In the end, it ran, but the scripts in heredocs inside it were not using absolute references. They were even using the unpatched shebang. Airgeddon starts running one of these inside tmux and that wasn't finding the executables.

Aha. Hehe. Should've kept reading. Yes--the heredocs aren't really intelligible as Shell to resholve. If a general wrapper approach doesn't work for some reason, perhaps patching it to inject a generated PATH after the #!/usr/bin/env bash lines would.


this checkin fixes parking space accounting in the dev model

In particular, I wasn't really accounting for the space use of parking when doing accounting of residential units and non-res spaces before.  Thankfully, this is now fixed.  Most of these changes were a result of the MTC parking project.

should we close this pr?

It's a good question - as long as we can get it back from history I'm fine with deleting it.  It does seem trivial to dig it out of the history though.

We can definitely close the PR - I just don't know about deleting the branch...


Perception: support v2x traffic lights

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.guiyilin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Can't load modules from modules

This doesn't seem to behave correctly in the following case:
// LimitImports.scala
val res = 1
@
val asd = 1

// Foo.scala
import ammonite.ops._

load.module(wd/"LimitImports.scala")

@

println(res)
println(asd)

@ // Repl Session
@ import ammonite.ops._
@ load.module(wd/"Foo.scala")
ammonite.repl.CompilationError: Compilation Failed
Main.scala:174: not found: value res
println(res)
        ^
Main.scala:177: not found: value asd
println(asd)
        ^
    ammonite.repl.interp.Interpreter.loop$1(Interpreter.scala:97)
    ammonite.repl.interp.Interpreter.processScript(Interpreter.scala:86)
    ammonite.repl.interp.Interpreter.processModule(Interpreter.scala:67)
    ammonite.repl.interp.Interpreter$$anon$1$load$.module(Interpreter.scala:134)
    cmd4$$anonfun$1.apply$mcV$sp(Main.scala:110)
    cmd4$.<init>(Main.scala:111)
    cmd4$.<clinit>(Main.scala:-1)

This should work. Will take some refactoring to make load.module put the imports in the right place depending on whether it's being called in a module or directly from the REPL, but shouldn't be hard in principle

@laci37 this is probably on you when you come back, since you own much of the module/script loading stuff =)

it's broken again
// Foo.scala
import ammonite.ops._
interp.load.module(pwd/"LimitImports.sc")

@
import ammonite.$file.dummy.LimitImports._
println(res)
import ammonite.$file.dummy.LimitImports_2._
println(asd)

this makes writing script compatible with different versions through interp.load.module really hard.
as old version e.g. 1.6.7 does not support import ammonite.$file.dummy.LimitImports_2._
need 1.6.7 to support scala 2.11 and spark.

1.6.7 does support import ammonite.$file.dummy.LimitImports_2._ as long as you clear the cache in the start, rm -rf ~/.ammonite/cache


bug/446 Close buttons have wrong style in TargetingOverlay

446
Relevant 446(https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)

Resolves #446

Please check the following

[ ] Do the tests still pass? (see Run the Tests)
[ ] Is the code formatted properly? (see Linting (Formatting))
For New Features:

[ ] Have tests been added to cover any new features or fixes?
[ ] Has the documentation been updated accordingly?

Please describe additional details for testing this change
the issue mentionned ScrapDialog and RuleaDialog but i find that this issue has been already resolved when the design have been updated

the issue mentionned ScrapDialog and RuleaDialog but i find that this issue was already resolved when the design have been updated

ok the button the RuleaDialog is updated


padrino-gen plugin for adding honeybadger to a padrino app

Honeybadger integration would be nice!

If anyone is interested in adding explicit Padrino support to Honeybadger, here is how they hook into Sinatra: https://github.com/honeybadger-io/honeybadger-ruby/blob/master/lib/honeybadger/init/sinatra.rb

I maintain the honeybadger gem, and am happy to help however I can. We also detect the framework here:
https://github.com/honeybadger-io/honeybadger-ruby/blob/af4273d1e143d7bef67c7da3608cff37bb6f2005/lib/honeybadger.rb#L219
If we must hook into Padrino differently, I think we can add a check for it before checking for Sinatra (like we do for Rails); the plugin/initialization code for Padrino is what I'm less familiar with. We just need to be able to install two Rack middleware and optionally pick up configuration from Padrino when starting our agent (for example, in Sinatra you can do set :honeybadger_api_key, 'foo' and it will use that setting if it's found.) Open to suggestions.

+1

So far I've been copy/pasting this:
config/honeybadger.rb
require 'honeybadger'
HONEYBADGER_CONFIG = Honeybadger::Config.new(env: env)
Honeybadger.start(HONEYBADGER_CONFIG)

app/app.rb
configure :production do
  use Honeybadger::Rack::ErrorNotifier, HONEYBADGER_CONFIG
end

@postmodern I'd love to see that contributed to here: https://github.com/padrino/padrino-recipes/tree/master/plugins so we can run padrino-gen plugin honeybadger. See https://github.com/padrino/padrino-recipes/blob/master/plugins/hoptoad_plugin.rb for a point of reference.

Is there a cleaner, more padrino way, to expose the HONEYBADGER_CONFIG object? Setting a global constant seems awkward.

I had a similar issue and setting the constant seemed to be the best option. Though in the case of Honeybadger, it looks like you can just override honeybadger_config and set :notices to false when not in production.
Does that work for your scenario?

A PR for https://github.com/padrino/padrino-recipes is welcome.


Increase specificity of heading anchors, rename as modifier of govuk-link

https://github.com/x-govuk/markdown-it-govuk/commit/f30e7c37e8512b203ebbd48ad71371a0335a15a2 fixed an issue where heading anchors had 2 separate class attributes, one for the heading anchor class, the other the injected govuk-link class. This was flagged as a warning by the HTML validator.
Fixing this issue however, means that govuk-link now gets applied to heading anchor links as intended, resulting in a specificity issue, and heading anchors appearing as normal links.
This PR:

Increases the specificity of the heading anchor class
Renames it to follow the naming conventions used when extending a class provided by govuk-frontend (from app-heading-anchor to app-link--heading).

Oops, the "rename as modifier" bit of this meant this was a breaking change for any downstream apps using app-heading-anchor classes. The design history did this in the screenshots component.
In hindsight, the short term fix could have been:
.app-heading-anchor,
.govuk-link.app-heading-anchor {
  ...
}

😳


Add @jcelerier to maintainers

After discussion on nixpkgs-audio matrix channel (@minijackson)
Description of changes
Adding myself to the maintainers list to co-maintain ossia-score

Please do not remove the checklist from the PR.

Do you kneed help with something?

I'd like to access the template without having to redo the PR ^^'

here you go https://github.com/NixOS/nixpkgs/blob/master/.github/PULL_REQUEST_TEMPLATE.md?plain=1

sorry, this fell a bit far in the backlog...

what's the process to get this merged ? :)

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1716

what's the process to get this merged ? :)

Normally this list is added in the same PR where the maintainer is also used, to not collect unused maintainers.

I've pushed this commit into #315409


Verification Id added in certificate

Description:
Verification ID displayed on Certificate
Fixes #20

Type of change:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Screenshots / Video:

@Shubham-Kumar-2000  changes made.
Can u please check and revert back?


Launch remote yanking from a different keybinding

Hi, I'm loving this plugin! I'm mostly a newbie in nvim and I was wondering how can I launch the remote operations with a different key than 's'. My usecase is that I use nvim as a pager inside other app and "s" is already bound. A :leap-remote-yank command that I could bind to, e.g. C-s, would solve my issue. Is that even possible?

Hi! I don't understand, you trigger remote yanking with y (spooky just defines text objects - :help text-objects). E.g. to yank a remote inner word (iw), via targeting an ab pair in it, you type: yirwab.

Hi, thanks for your reply and sorry for the vagueness in my question. I'm using things like the yirwab and it's great. What I was wondering is if there is a way to launch leap-spooky in directly from the ex-line.
The usecase is that I'm using vim as a pager inside my mail client. Then, while I'm reading a message, I'd like to yarw (copy a remote word or line), but r is bound to replying the email, so I can't do it. It'd be great to be able to call the remote selection part of leap-spooky as an independent command.

I just discovered a way to enable a passthrough mode in my mail client which allows me to do everything I want in the pager. Closing this now, thank you so much!


added fast shutdown

Create a Fast Shutdown entry in shutdown menu, the process disable the gamelist saves by setting IgnoreGamelists setting to true so when SystemData are deleted they do not save the gamelist.
https://github.com/recalbox/recalbox-emulationstation/compare/rb-4.0.X...recalbox:rb-4.0.X-fastshutdown?expand=1#diff-0d7037121f70d0897714deabb3ea71e1R395

Thanks for this! Do you have a release planned date?

@torra87 it's been merged to the 4.0 branch, so the feature will be available on 4.0.0beta4 :)

Great!
Do you know when beta4 will be availible?

When it will be


How to reuse an existing iam role or pre provision one for users?

Feature Description
I dont have access to create iam roles
The security department can do this but they require doing it in terraform.
Is there a way to define an iam role in the config that has already been created so users do not need iam perms to use basti
Use Case
See above
Proposed Solution
Define iam role in cli and or config file
Related Issues/PRs
N/A

Hi @nitrocode, nice to see you again!
Unfortunately, there's no way to provide an existing IAM role for the bastion instance in the basti init command as of today.
However, this could be easily added as another advanced input option (source). I can't promise to implement this feature soon but PRs are very welcome!


Error failed to connect to esxi host: client connection error

Summary
My configuration worked with terraform but didn't work with pulumi.
failed to connect to esxi host: client connection error

Diagnostics
The only version 1.0.0
Previewing update (esxi):
     Type                                Name          Plan       Info
 +   pulumi:pulumi:Stack                 esxi-esxi     create     1 warning; 6 debugs
     └─ esxi-native:index:VirtualSwitch  InternetOnly             1 error

Diagnostics:
  esxi-native:index:VirtualSwitch (InternetOnly):
    error: failed to connect to esxi host: client connection error

  pulumi:pulumi:Stack (esxi-esxi):
    debug: Registering resource: t=pulumi:pulumi:Stack, name=esxi-esxi, custom=false, remote=false
    debug: RegisterResource RPC prepared: t=pulumi:pulumi:Stack, name=esxi-esxi
    debug: RegisterResource RPC finished: resource:esxi-esxi[pulumi:pulumi:Stack]; err: null, resp: urn:pulumi:esxi::esxi::pulumi:pulumi:Stack::esxi-esxi,,,,
    debug: Running program '/Users/namphan/code/upbase/infra/esxi' in pwd '/Users/namphan/code/upbase/infra/esxi' w/ args:
    debug: Registering resource: t=esxi-native:index:VirtualSwitch, name=InternetOnly, custom=true, remote=false
    debug: RegisterResource RPC prepared: t=esxi-native:index:VirtualSwitch, name=InternetOnly
    warning: resource plugin esxi-native is expected to have version >=1.0.0, but has 0.0.1; the wrong version may be on your path, or this may be a bug in the plugin

Message from the maintainers:

Hi @sockyone did you provide the config as explained here


Card validation

Codecov Report

Merging #218 into master will increase coverage by 1.07%.
The diff coverage is 75.8%.

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
+ Coverage   72.14%   73.22%   +1.07%
==========================================
  Files          27       29       +2
  Lines         298      422     +124
==========================================
+ Hits          215      309      +94
- Misses         83      113      +30

Impacted Files
Coverage Δ

SwiftValidator/Parsers/CardParser.swift
73.07% <73.07%> (ø)

SwiftValidator/Rules/CardNumberRule.swift
90% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d03c54...bd3eb11. Read the comment docs.

Mastercard number validation fails for now. i will have a fix soon. if you do get a fix please help and notify me so i can merge into my branch


Docs refer to seemingly non-existent MemoryLeakWarningPlugin::turnOnNewDeleteOverloads()

http://cpputest.github.io/manual.html#memory_leak_detection has a code example:
void setup()
{
    MemoryLeakWarningPlugin::turnOffNewDeleteOverloads();
}

void teardown()
{
    MemoryLeakWarningPlugin::turnOnNewDeleteOverloads();
}

In the v4.0 source, there is no method MemoryLeakWarningPlugin::turnOnNewDeleteOverloads().
Also, turnOnNewDeleteOverloads does not appear anywhere in the source code for that release.

Ok, fixed. It changed to save and restore.


Weird error message when a target is not connected or unpowered

Describe the bug
Probe-rs generates the following error when a target is not connected (or un-powered):
Error: An error with the usage of the probe occured

Caused by:
    0: An error specific to the selected architecture occured
    1: An error occured in the SWD communication between DAPlink and device.

To Reproduce
Steps to reproduce the behavior:

Have no target connected
Use a download command eg download_file_with_options

Expected behavior
An error message that says that the target cannot be found.
Desktop (please complete the following information):

Arch Linux

Hmm I am aware of this message, but reading it with the 2024 me, the message seems correct 🤔

Definitely correct from an accuracy perspective. Is it helpful from a UX perspective?

A more specific "cannot find a device" error message would definitely be more helpful, if possible.


Check if goto label has no corresponding statement

Fixes #154

Actually, I think it's incorrect for a goto label to be associated with a statement.
php > while(false) label: echo "test";
test

That example gets parsed equivalently to while(false) { label: } echo "test"; by php, but tolerant-php-parser incorrectly treats it as while (false) {label: echo "test"}
Looking at the php-src parser implementation, a goto label is a standalone statement just like any other statement
	|	';'	/* empty statement */ { $$ = NULL; }
	|	T_TRY '{' inner_statement_list '}' catch_list finally_statement
			{ $$ = zend_ast_create(ZEND_AST_TRY, $3, $5, $6); }
	|	T_GOTO T_STRING ';' { $$ = zend_ast_create(ZEND_AST_GOTO, $2); }
	|	T_STRING ':' { $$ = zend_ast_create(ZEND_AST_LABEL, $1); }
;


feat: reformat pipeline

Todo

[x] general cleanup, fix GPU + integration tests

[x] test for transformers model

[x] rework toydata

[x] ressurect eval

[ ] bubble up new args to fit functions

[ ] port to paddle

[ ] port to keras

Closing due to git conflicts, new one in #192


[Rendering]  Incorrect value for submit Input.ChoiceSet option

Copied bug from: https://github.com/microsoft/AdaptiveCards/issues/8626
Details from original post:
Target Platforms
NodeJS
SDK Version
1.4
Application Name
Teams
Problem Description

set a default value(eg: 1,2,3) in Input.ChoiceSet
toogle choise 2 ant toogle again

except result:  1,2,3
result: when i get taskModuleRequest.data.requiredMultiselectId.   it is 1,2
it confused me.
Screenshots
_No resp
https://github.com/microsoft/AdaptiveCards/assets/38236070/b0a66bf9-0330-4c7b-8c74-63566ed69a6e
onse_
Card JSON
body: [
      {
        type: 'Input.ChoiceSet',
        id: 'requiredMultiselectId',
        style: 'expanded',
        isMultiSelect: true,
        label: 'Manage notifications',
        isRequired: true,
        errorMessage: 'Select at least one items',
        value: defaultValue,
        choices: [
          {
            title: '11111',
            value: 'watcher',
          },
          {
            title: '222222',
            value: 'creator',
          },
          {
            title: '333333',
            value: 'assignee',
          },
          {
            title: '44444',
            value: 'comment_mentioned',
          },
        ],
      },
      {
        type: "Input.Text",
        placeholder: "card_type",
        id: 'card_type',
        isVisible: false,
        value: TaskSubmitType.NotifyChange
      },
      {
        type: 'Container',
        items: [
          {
            type: 'ActionSet',
            actions: [
              {
                type: 'Action.Submit',
                title: 'Update',
              },
            ],
            horizontalAlignment: 'right',
          },
        ],
      },
    ],

Sample Code Language
en
Sample Code
No response---
Document Details
⚠ Do not edit this section.It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3fb4394d-25b1-8752-3996-fe3a2934732d
Version Independent ID: 6d391381-89d0-117c-27cc-00043bd26a36
Content: Cards reference - Teams
Content Source: msteams-platform/task-modules-and-cards/cards/cards-reference.md
Product: msteams
GitHub Login: @surbhigupta12
Microsoft Alias: surbhigupta12

Hello @86driver - Thanks for raising your query.
We will look into it and let you know the updates.

Hi @86driver,
We have tried this JSON.
Card JSON.txt
When we open the card and click on submit. It is sending a default selected value as response.

But, later after opening the same card without refreshing, if we selected any other option along with default value and submit it. The response is submitting as only for selected value instead of both selected value and default value.

Here, we are checking with engineering team whether it is a by design feature or a bug. We will look into it and let you know the updates.

Hi @86driver, we got update from engineering team that the issue is fixed. Please do verify.


Analyzing dependencies [!] Unable to find a specification for ReactorKit

CleverKit pod install 하려고 하니 에러가 납니다
Analyzing dependencies [!] Unable to find a specification for ReactorKit

It's because your local pod spec repository is not up-to-date. Do as following:
$ pod repo update  # update local pod spec repo
$ pod install

오, 감사합니다


Use Wikidata subsets for Chemistry + Scholia data

Will discuss with Jose first

Update from today: Jose will have 3 students working on the Wikidata Dumper subsetting ; expected to finish in August.
1 student will work on slurper, 1 on dev ops, 1 one wikidata dumper.
Scholia ShEx templates developed by @ammar257ammar will be used as example.
The chemistry usecase needs to be extended with more ShEx templates, before the pipeline can be tested.
Use visualiser tool from Jose to create visual documentation on RDF.


Head of develop will not build: corrupt tarballs and mysterious invalid version messages

This issue is a Bug
Expected Behaviour
I expect that following the instructions in the MD file, like this:
git clone --recursive -b develop https://github.com/readium/readium-js-viewer.git readium-js-viewer
cd readium-js-viewer
git checkout develop && git submodule foreach --recursive "git checkout develop"
npm run prepare:all
Will complete without fatal errors and result in a usable system that can be tested with npm run http.
Observed behaviour
Instead, I get the following errors: many warnings about deprecation, and then
npm WARN tarball tarball data for jquery-sizes<EMAIL_ADDRESS>(sha512-l2fcLLlCSYeWGPdGeWnadY/REi/qshKzwGwVvL89TGzDqh52vGZFgZPt7qeI2Clxq1c9EGuflWRtChS5HN4TMw==) seems to be corrupted. Trying again.
npm WARN tarball tarball data for css-element-queries<EMAIL_ADDRESS>(sha512-yv5N3bSzfwZu2NP3vgc9r6AbbbdOJHbm6GTw+Hds7HULlufIrKyuBIipAOBA+2VkJE65cKlhilRYAAgoKpy/yg==) seems to be corrupted. Trying again.
npm WARN tarball tarball data for jquery-sizes<EMAIL_ADDRESS>(sha512-l2fcLLlCSYeWGPdGeWnadY/REi/qshKzwGwVvL89TGzDqh52vGZFgZPt7qeI2Clxq1c9EGuflWRtChS5HN4TMw==) seems to be corrupted. Trying again.
npm WARN tarball tarball data for http-server<EMAIL_ADDRESS>(sha512-481V03ReScl/ZFWfdq9HLxAXX+puIjyZ2lqRZktQXA9LIY+QEx6ztl9U4xUgNlYE3WtU9rIIpFKH7WzAIjqYiA==) seems to be corrupted. Trying again.
npm WARN tarball tarball data for css-element-queries<EMAIL_ADDRESS>(sha512-yv5N3bSzfwZu2NP3vgc9r6AbbbdOJHbm6GTw+Hds7HULlufIrKyuBIipAOBA+2VkJE65cKlhilRYAAgoKpy/yg==) seems to be corrupted. Trying again.
npm WARN tarball tarball data for http-server<EMAIL_ADDRESS>(sha512-481V03ReScl/ZFWfdq9HLxAXX+puIjyZ2lqRZktQXA9LIY+QEx6ztl9U4xUgNlYE3WtU9rIIpFKH7WzAIjqYiA==) seems to be corrupted. Trying again.
npm ERR! Invalid Version: 3.5.0pr2
npm ERR!      C:\Users\Thomson\AppData\Local\npm-cache_logs\2023-04-04T20_17_46_157Z-debug.log
npm WARN deprecated<EMAIL_ADDRESS>Use uuid module instead
npm WARN deprecated<EMAIL_ADDRESS>CoffeeScript on NPM has moved to "coffeescript" (no hyphen)
npm WARN deprecated<EMAIL_ADDRESS>This package is unmaintained and deprecated. See the GH Issue 259.
npm ERR! Invalid Version: 3.5.0pr2
npm ERR!      C:\Users\Thomson\AppData\Local\npm-cache_logs\2023-04-04T20_17_48_641Z-debug.log
Product
readium-js-viewer
Additional information
Working on Windows 11, in a bash shell in Visual Studio Code.
npm version 8.1.2
node version 16.13.1
commit 51f2aa0e76e3880fef0866e06ea15f1c7f607f1c of readium-js-viewer
The string 3.5.0pr2 is not found anywhere in the source tree, so I have no idea what npm is trying to get that version of or why.
I considered changing package.json to get a numbered version of jquery-sizes and http-server, but there is no indication I could find of even approximately what version might be needed.
Apologies for not reading your contribution guidelines. The link leads to a page with a further link that is broken (404).
I have attached the log mentioned in the error message.
2023-04-04T20_43_43_484Z-debug.log

This looks to be an issue with NPM that was fixed in version v8.13+. Simply upgrading will fix the issue.
See the following issue for further detail: https://github.com/npm/cli/issues/4992


[Discussion] Ideas to improve deep learning on a particular music style

Newbie here. First approach to Git, Python/PiP and commands.
I'm really interested in the development of this tool and the use of it. My main focus is to separate stems in a particular field of music: jazzfunk. I'm not fully aware of how neural networks learn themselves and evolve. So, I need basic info to clarify how to improve Spleeter performance.
Does every song we input to Spleeter makes it gets better results therefore?
Does remaining in a particular style of songs makes it even better with the output results?
Has it progressive learning steps? This meaning if I input "easier" songs, then other a little bit more complicated and then songs more chaotic or freeform, it will learn better than if the first input are complex.
Thanks in advance
(please if anyone can label this into "training", it would be appreciated)

I don't think this is the right place to ask the question. I'd ask it in a more general place somewhere. You're asking a very basic ML question, and I recommend watching a few YouTube videos about ML and how AI is trained.
But for a simple explanation: A training model is generated when the AI is trained. The training model is a snapshot of the neural network.
The training model only knows what it has been trained, nothing more.
Spleeter has 3 training models so far.
Yes, you can train your own model and everything is in the Wiki.
No, every song you input does not make Spleeter better.

As an outsider it helps a lot be given this kind of answers to guess more conviniently what to expect using it. I know there's lots of info about that general topic. It's only that using this for the first time with no IT background (just audiophile) seems confusing at times.


Integrate with ECR

ECR currently does not automatically create repositories on push unlike docker hub. How (where) should we handle this logic ?

One way is to ask the repo in gitkube CR and use tags instead of repositories i.e.
tirumarai/test:247ff5 (dockerhub) becomes
tirumarai:test-247ff5 (ecr)

How easy is it to create the registry? Provided the cluster has required IAM to do so?

I don't know enough about this problem, but for now we should just have
documentation that can be a manual step.
I think all these problems will go away in the months to come anyway. So we
should definitely not try to solve it from inside gitkube or the gitkube
CLI.
--
Tanmai
On Thu, May 24, 2018 at 11:36 PM Shahidh K Muhammed <
<EMAIL_ADDRESS>wrote:

How easy is it to create the registry? Provided the cluster has required
IAM to do so?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/hasura/gitkube/issues/68#issuecomment-391956423, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAIAWCOy0_Up8USd4R8eh6Ng02Ke3BRzks5t16ZpgaJpZM4ULe7j
.

It is either an HTTP call or aws cli. Either way it breaks the current pattern and proves an exception (till now). If we come up with some other registry which also has the same problem then we need to think about solving the problem more generally. I guess for the time being we can make it a manual step.

Also the authentication to the AWS container registry lasts only for 12 hours. You have to keep renewing the docker credentials. Something like this cronjob will have to be run to keep the imagePullSecret renewed.

@nizar-m Yes, but that is clearly out of the scope of gitkube.

Docker push will fail.


[1.1.1] Fix to #6534 - Problems with LINQ async methods

Problem was that during result operator processing, when creating expression for GetResult involving InjectParameter call we were not propagating CancellationToken. Fix is to call a helper method that takes care of that, rather than Expression.Call.

@anpete @divega


Allow custom PR templates

https://github.com/zeebe-io/backport-action/blob/186066470a540eb4a8d2b1bed1e8e12ab12b8120/src/backport.ts#L212
At the time of writing this action uses a constant backport PR body. Would it be possible to make it configurable?
Specifically the use case I have here is that the backport PRs the action opens are themselves subject to further actions, but GitHub won't let an action run an action so the required checks on the backport PRs are never triggered.
One hacky but very lightweight workaround for this issue is to just have the reviewer close and immediately reopen the PR to trigger the CI, so ideally I'd like the backport PR description to include a note to reviewers that they can just close and reopen the PR to trigger CI. Eventually I might add a /ci command or similar that is slightly less hacky, but I'd still like to document that in the PR body.

Hi @negz, that sounds like a good addition. I can imagine other use cases for this as well. But, allow me first to focus on your case.

One hacky but very lightweight workaround for this issue

In your case, it's probably better to look at the 2nd option from this workaround section:

Use a repo scoped Personal Access Token (PAT) created on an account that has write access to the repository that pull requests are being created in. This is the standard workaround and recommended by GitHub. However, the PAT cannot be scoped to a specific repository so the token becomes a very sensitive secret. If this is a concern, the PAT can instead be created for a dedicated machine account that has collaborator access to the repository. Also note that because the account that owns the PAT will be the creator of pull requests, that user account will be unable to perform actions such as request changes or approve the pull request.

If you change the github_token input value to the PAT of a machine account that is contributor in your repo, the backport-action should simply interact with your repository from that machine account. This should then trigger your workflows normally.
Please let me know if you're still interested in this feature knowing this. If you happen to try the above solution, please also let me know if you run into any issues.

Having said that, I see 2 options to support more dynamic PR descriptions:

allow configuring a template for the PR description

this requires some input property, e.g. pr_description_template
this requires special keywords that when used in the template are replaced with:

the original pr_number
the target branchname

allow configuring a footer/postfix for the PR description

this requires some input property, e.g. pr_description_footer
just appends the value to the PR description

Clearly the latter is easier to implement, but the prior seems more flexible and extendable in the future. My preference would go to the prior. I'm also open to other ideas.

Please let me know if you're still interested in this feature knowing this.

I am. I don't disagree that the PAT approach is likely better, but I'm using this action quite extensively across two orgs and many repos, so being able to turn on a prompt to close and reopen the PR is a more compelling short-term fix than going through and figuring out setting up a bot account, PAT, etc etc across both orgs. Especially considering the potential security implications.

@negz I've created a pull request to add support for this, using the first option I described. Note that the naming has changed from that first proposal. For the full documentation, please have a look at the README.
You can use the version of this pull request by configuring the action in your workflow:
   ...
   uses: zeebe-io/backport-action@custom-pull-descriptions
   with:
     version: custom-pull-descriptions
     pull_description: |-
       Your custom description here,
       It can contain new lines and ${placeholders}
       See the README linked above for more details

Please let me know whether this works correctly for you 🙂


Doing Manual translation before using substitution file

is there any way to have some of the manual translation to run before doing substitution ?
like placing it on a specific folder ?
in this case when the translation was made before having the substitution file, making the text that need to be translated is different , so it would be a lot of work to change the translation that already translated

No, this is not possible.
I would generally suggest avoiding substitutions and make use of regexes instead if possible in the situation.


d3.scaleQuantileP

How about in addition to d3.scaleQuantile, which requires you to specify a range with q elements to compute q-quantiles, you also have d3.scaleQuantileP, whose range is continuous and defaults to [0, 1], computing the p-quantile of an input value from the domain.
And then you can specify an output interpolator, say d3.interpolateViridis, so that you can map the p-quantile of the input value to a color.
Though this is somewhat tricky because it’s not clear whether d3.scaleQuantileP should function more like a d3.scaleSequential that takes a fixed output interpolator, or d3.scaleLinear where you can specify both the range and the interpolator.

This is closely related to #62 as implemented in @393b9a5: d3.scaleSequentialQuantile computes the p-quantile prior to applying the interpolator.


Grid Download buttons

As a  user
I want to be able to download any grid in track
so that I can easily export data
Acceptance Criteria
Scenario 1:
GIVEN I am on a page that has a grid
WHEN I select the download button
THEN I receive an excel document with only the data I've filtered down to
Scenario 2:
xxxxxx
Validation Rules?
(If yes, list here)
Screenshot
(Link above will always be the most up-to-date version.)

TODO: find all pages with grids

@djnunez-aot
missing on:

project dashboard
admin users
team tab (should match nation tab)

broken on:

resource forecast (no name field in csv)

can't test the resource forecast CSV download because resource forecast is not showing anything

@djnunez-aot  can we make the consistency with download buttons and reuse the one we have in the workplan grid? Thanks!


Add nullable in StateFieldArgs

I think given the existing nth function, we should let nullable configurable. And, the nullability is actually for the list element.  We should add nullable in StateFieldArgs.

let mut fields = vec![Field::new_list(
            format_state_name(self.name(), "nth_value"),
            Field::new("item", args.input_type.clone(), self.nullable),
            false)]

@eejbyfeldt is working on it in #11063
Originally posted by @jayzhan211 in https://github.com/apache/datafusion/pull/11287#discussion_r1667222783

Hold on, I think it is outdated, since I found that most of the sql database returns null if no row qualified. #11299

This comment is also outdated because of #11299.
https://github.com/apache/datafusion/blob/1dfac86a89750193491cf3e04917e37b92c64ffa/datafusion/functions-aggregate/src/nth_value.rs#L136-L139

This one looks good to me too. But, it is nice to have a case that benefit on the nullability of the element (like the query that is optimized based on this)
let mut fields = vec![Field::new_list(
            format_state_name(self.name(), "nth_value"),
            Field::new("item", args.input_type.clone(), self.nullable),
            true)]

Otherwise for simplicity, we can assume it is nullable
let mut fields = vec![Field::new_list(
            format_state_name(self.name(), "nth_value"),
            Field::new("item", args.input_type.clone(), true),
            true)]

This comment is also outdated because of #11299.
https://github.com/apache/datafusion/blob/1dfac86a89750193491cf3e04917e37b92c64ffa/datafusion/functions-aggregate/src/nth_value.rs#L136-L139

Oh, so actually the current code is incorrect 😕 I though that is the one you proposed to change. But why the result is expected 🤔

Sorry, I do not follow. Could you please elaborate on the incorrect part.

Like what we have in #11299 . To returns null if row qualified, the nullable for list should be true, but the current code is false which is not what I thought of.

For nth_value aggregation there are 3 possible states:

The nth row exists and the value is returned.
The nth row is out of range and NULL is returned.
No rows qualified for aggregation and NULL is returned.

2 & 3 is covered by the else branch in Accumulator::evaluate. The result does not depend on nullable of list in the accumulator state.
https://github.com/apache/datafusion/blob/1dfac86a89750193491cf3e04917e37b92c64ffa/datafusion/functions-aggregate/src/nth_value.rs#L337-L342
The nullable(Line 141) for the list is rendered no-op. https://github.com/apache/datafusion/blob/1dfac86a89750193491cf3e04917e37b92c64ffa/datafusion/functions-aggregate/src/nth_value.rs#L134-L142
This possibly explains passing tests. Thoughts?

My guess is because the query is not multiple phase aggregate so there is no result that check with state_field. Maybe we should figure out some complex query that has state result for each aggregate partition

When adding trace statements in nth_value aggregate I can see that the following are executed in order:

update_batch()
state()
merge_batch()
evaluate()

nth_value always exists - In the query below the 2nd item in C13 is always present because for all groups a..=e the count in each group is either 18, 19 or 21.

SELECT C1
       , COUNT(C1) as n
       , NTH_VALUE(C13, 2 ORDER BY C1, C13 ASC) as nth -- get 2nd row
    FROM aggregate_test_100
   GROUP BY C1
   ORDER BY C1;
+----+----+--------------------------------+
| c1 | n  | nth                            |
+----+----+--------------------------------+
| a  | 21 | Amn2K87Db5Es3dFQO9cw9cvpAM6h35 |
| b  | 19 | 6FPJlLAcaQ5uokyOWZ9HGdLZObFvOZ |
| c  | 21 | 6WfVFBVGJSQb7FhA7E0lBwdvjfZnSW |
| d  | 18 | 1aOcrEGd0cOqZe2I5XBOm0nDcwtBZO |
| e  | 21 | 3BEOHQsMEFZ58VcNTOJYShTBpAPzbt |
+----+----+--------------------------------+
5 row(s) fetched.

nth_value is sometime out of bounds - Since 'b' and 'd' groups have only 18 and 19 values, we can set N to be 20.

SELECT C1
       , COUNT(C1) as n
       , NTH_VALUE(C13, 20 ORDER BY C1, C13 ASC) as nth -- get 20th row
    FROM aggregate_test_100
   GROUP BY C1
   ORDER BY C1;
+----+----+--------------------------------+
| c1 | n  | nth                            |
+----+----+--------------------------------+
| a  | 21 | waIGbOGl1PM6gnzZ4uuZt4E2yDWRHs |
| b  | 19 |                                |
| c  | 21 | pLk3i59bZwd5KBZrI1FiweYTd5hteG |
| d  | 18 |                                |
| e  | 21 | ukOiFGGFnQJDHFgZxHMpvhD3zybF0M |
+----+----+--------------------------------+
5 row(s) fetched.

Create Table
CREATE EXTERNAL TABLE aggregate_test_100 (
  c1  VARCHAR NOT NULL,
  c2  TINYINT NOT NULL,
  c3  SMALLINT NOT NULL,
  c4  SMALLINT,
  c5  INT,
  c6  BIGINT NOT NULL,
  c7  SMALLINT NOT NULL,
  c8  INT NOT NULL,
  c9  BIGINT UNSIGNED NOT NULL,
  c10 VARCHAR NOT NULL,
  c11 FLOAT NOT NULL,
  c12 DOUBLE NOT NULL,
  c13 VARCHAR NOT NULL
)
STORED AS CSV
-- path is relative to `datafusion-cli`
LOCATION '../testing/data/csv/aggregate_test_100.csv'
OPTIONS ('format.has_header' 'true');

This is a recent change introduced in #11093.
https://github.com/apache/datafusion/blob/0965455486b7dcbd8c9a5efa8d2370ca5460bb9f/datafusion/functions-aggregate/src/nth_value.rs#L404-L407
In state_fields the nullability is set to false. But inside Accumulator::evaluate() the nullability of the list is overridden to always be true.
It is surprising to me that the schema defined in state_fields doesn't match the Accumulator and still this works.

Maybe the schema matching is not correct

I tested this out in many more ways. Each time making sure it's multi-phase grouping. So that state fields are being used. This is the understanding I've reached about the correct nullable value for both the list and the items in the list:

It is impossible for the intermediate state of values (the list) to ever be null. It can be empty, but never null. So the current setting of nullable: false for the list of values is correct.
The nullable for items in the list need not be configurable(like I initially thought). The computation of nth row does not depend on the nullable defined in schema of the input column expression. It should remain set to true to allow null value to exist as an item in the list. Adding this field to StateFieldArgs for the sake of nth_value is unnecessary in my opinion.

let mut fields = vec![Field::new_list(
	format_state_name(self.name(), "nth_value"),
	Field::new("item", args.input_type.clone(), true), // See [2]
	false, // See [1]
)];

It will be beneficial to future readers of this code to add some comments here. It took me more time than I think was necessary to reach the conclusions stated above because of how they are now implicit in code.
But other than that the good news is no code changes are required.

cc @eejbyfeldt and @alamb I think @jcsherin find something interesting that nullable for list element should be true in order to allow computing with null element. I think the idea here applies to array_agg too. We probably could set nullable to false for list in state_fields
    fn state_fields(&self, args: StateFieldsArgs) -> Result<Vec<Field>> {
        if args.is_distinct {
            return Ok(vec![Field::new_list(
                format_state_name(args.name, "distinct_array_agg"),
                Field::new("item", args.input_type.clone(), true),
                false,
            )]);
        }

        Ok(vec![Field::new_list(
            format_state_name(args.name, "array_agg"),
            Field::new("item", args.input_type.clone(), true),
            false,
        )])
    }

I think we should definitely add docs about this, we had several PRs dealing with nullability already. It would be helpful for others too.

@jcsherin  would you be willing to draft a PR updating the docs?

@jcsherin would you be willing to draft a PR updating the docs?

Yes, I'll be happy to take care of this.

Thanks again @jayzhan211.


Checkpoint cleanup for simultaneous experiments

Currently, if multiple experiments are running in parallel, they all use the same checkpoints directory by default.  This is a problem, because they are then all overwriting the same best_model.pth asynchronously, which can cause experiment A to load experiment B's checkpoint.
We should move the checkpoints for a given experiment to its log folder, and then clean them up by default when the run is complete.

Resolved in v0.5, I believe.


Fix backup-target setting doesn't set to the latest value

Summary
Watch settings data to update harvester settings list.
PR Checklist

Is this a multi-tenancy feature/bug?

[ ] Yes, the relevant RBAC changes are at:

Do we need to backport changes to the old Rancher UI, such as RKE1?

[ ] Yes, the relevant PR is at:

Are backend engineers aware of UI changes?

[x] Yes, the backend owner is: @WebberHuang1118

Related Issue #
https://github.com/harvester/harvester/issues/4463
Technical notes summary
harvester backend will auto hide (set to null in API response) below three fields once saved the backup target info. See https://github.com/harvester/harvester/issues/4463#issuecomment-2328016995

access key id
secret access key
cert

We just need to refresh the whole settings on UI.
Screenshot/Video
https://github.com/user-attachments/assets/46bcb657-1aae-4693-a713-cd3b6dda0716

@mergify backport release-harvester-v1.4


[Backport 2.8] Cannot Provision RKE1 on vSphere

Backport for https://github.com/rancher/rancher/issues/47938

The fix can be validated on the latest v2.8-head image

Ticket #47941 - Test Results - ✅

Scenario
Test Case
Result

1.
provision RKE1 cluster
PASS

Verified with (HA Helm or Docker) on Rancher v2.8.10-alpha2:
Scenario 1: Provision RKE1 cluster

Provision an RKE1 cluster
Verify that no permission error is observed
Login to one of the nodes
Verify that the permissions for cloud-config are set properly

Results: No error was observed the cluster provisioned successfully


jca_issue_970

sct_register_multimodal: created new type=label for landmark-based registration
sct_register_to_templatecreated new flag -ref

let's merge it even if Travis errored-- the error is likely related to a temporary bug in Travis (only affects OSX builds)


[web] Flake in framework tests: Failed to load

Seen in web_tests-5-linux
https://cirrus-ci.com/task/6682615207952384?command=main#L268
[   +3 ms] [CHROME]:Inconsistency detected by ld.so: ../elf/dl-tls.c: 493: _dl_allocate_tls_init: Assertion `listp->slotinfo[cnt].gen <= GL(dl_tls_generation)' failed!
03:04 +399 ~22 -1: loading /tmp/flutter sdk/packages/flutter/test/widgets/pageable_list_test.dart [E]
  Failed to load "/tmp/flutter sdk/packages/flutter/test/widgets/pageable_list_test.dart":
  Unable to connect to Chrome debug port: 43493
   SocketException: OS Error: Connection refused, errno = 111, address = localhost, port = 49234
  package:flutter_tools/src/base/common.dart 14:3                throwToolExit
  package:flutter_tools/src/web/chrome.dart 302:9                ChromiumLauncher._connect
  ===== asynchronous gap ===========================
  dart:async/future.dart 279:46                                  new Future.error
  package:test_core/src/runner/loader.dart 246:26                Loader.loadFile.<fn>
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1129:19                                   _CustomZone.registerBinaryCallback
  dart:async-patch/async_patch.dart 94:8                         _asyncErrorWrapperHelper
  package:test_core/src/runner/loader.dart                       Loader.loadFile.<fn>
  package:test_core/src/runner/load_suite.dart 98:31             new LoadSuite.<fn>.<fn>
  package:test_core/src/runner/load_suite.dart 108:8             new LoadSuite.<fn>
  package:test_api/src/backend/invoker.dart 229:15               Invoker.waitForOutstandingCallbacks.<fn>
  dart:async/zone.dart 1190:13                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 1630:10                                   _runZoned
  dart:async/zone.dart 1550:10                                   runZoned
  package:test_api/src/backend/invoker.dart 226:5                Invoker.waitForOutstandingCallbacks
  package:test_api/src/backend/invoker.dart 381:17               Invoker._onRun.<fn>.<fn>.<fn>
  ===== asynchronous gap ===========================
  dart:async/zone.dart 1121:19                                   _CustomZone.registerUnaryCallback
  dart:async-patch/async_patch.dart 83:23                        _asyncThenWrapperHelper
  package:test_api/src/backend/invoker.dart                      Invoker._onRun.<fn>.<fn>.<fn>
  dart:async/zone.dart 1190:13                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 1630:10                                   _runZoned
  dart:async/zone.dart 1550:10                                   runZoned
  package:test_api/src/backend/invoker.dart 368:9                Invoker._onRun.<fn>.<fn>
  dart:async/zone.dart 1190:13                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 1630:10                                   _runZoned
  dart:async/zone.dart 1550:10                                   runZoned
  package:test_api/src/backend/invoker.dart 148:7                Invoker.guard
  package:test_api/src/backend/invoker.dart 411:15               Invoker._guardIfGuarded
  package:test_api/src/backend/invoker.dart 367:7                Invoker._onRun.<fn>
  package:stack_trace/src/chain.dart 102:24                      Chain.capture.<fn>
  dart:async/zone.dart 1190:13                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 1630:10                                   _runZoned
  dart:async/zone.dart 1550:10                                   runZoned
  package:stack_trace/src/chain.dart 100:12                      Chain.capture
  package:test_api/src/backend/invoker.dart 366:11               Invoker._onRun
  package:test_api/src/backend/live_test_controller.dart 152:11  LiveTestController.run
  dart:async/future.dart 201:37                                  new Future.microtask.<fn>
  dart:async/zone.dart 1182:47                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 997:7                                     _CustomZone.runGuarded
  dart:async/zone.dart 1037:23                                   _CustomZone.bindCallbackGuarded.<fn>
  dart:async/zone.dart 1190:13                                   _rootRun
  dart:async/zone.dart 1093:19                                   _CustomZone.run
  dart:async/zone.dart 997:7                                     _CustomZone.runGuarded
  dart:async/zone.dart 1037:23                                   _CustomZone.bindCallbackGuarded.<fn>
  dart:async/schedule_microtask.dart 41:21                       _microtaskLoop
  dart:async/schedule_microtask.dart 50:5                        _startMicrotaskLoop
  dart:isolate-patch/isolate_patch.dart 118:13                   _runPendingImmediateCallback
  dart:isolate-patch/timer_impl.dart 404:11                      _Timer._runTimers
  dart:isolate-patch/timer_impl.dart 428:5                       _Timer._handleMessage
  dart:core-patch/function.dart                                  _Closure.call
  dart:isolate-patch/isolate_patch.dart 168:12                   _RawReceivePortImpl._handleMessage

@ferhatb assigning to you to triage / re-assign.  Trying to get rid of flakes since our eng-prod is really suffering from flaky tests -- so marked as P2 (critical)

I didn't spend time on framework tests so far.  They are using flutter test to run tests, not felt.
@jonahwilliams have you seen this before? Please let me know if I can help with anything.

@tvolkert @godofredoc are these tests migrated to LUCI, may be we can close Cirrus CI.

@yjbanov suggested in increasing the number of shards in this is issue for the same problem: https://github.com/flutter/flutter/issues/61462  Looks like it worked back then so we can retry it.

I do not have time to work on this right now

@jonahwilliams no worries, I found the related Chrome issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1106485&q="Inconsistency Detected"&can=2
I'll try some alternatives until Chrome issue is closed.
Investigation so far:

This happens time to time in Chrome, is not related to a particular test. I'll also ping the Chrome bug to see if they can increase the priority.
2 weeks ago we closed a similar issue by increasing the number of shards.
Another solution can be, we can pick an 1-2 month older version of Chrome for running the tests.

@yjbanov Do you have any suggestions for this issue.
So far, I prepared PRs for increasing the shard count. The engine one is for 3 days and it seemed to zero the flakes (for now). I'm also planning to merge the Framework one.

I'm closing this issue for now. Please re-open if you keep observing flakes on flutter/flutter. I'll reduce the shard number for engine: https://github.com/flutter/engine/pull/20164#issuecomment-668741939

Alternatively we can just migrate this test to LUCI, are there any blockers to do that?

That is the ultimate plan. The only blocker for me is I don't have an example of starting different shards from a test. If there is any example for that in the migrated SDK code, we can try to apply that method.
Is there any other tests with shards, migrated in the SDK side?

I'm creating the recipes for this test in the sdk, I think the only difference will be building the engine and isolating. Everything else can be reused. I'll share the CL in a couple of hours.

I've seen this before. At the time I solved it by removing concurrency and increasing shard count. Recently, @pennzht and @fkorotkov changed a shared memory parameter in Docker that was causing Chrome crashes in one of the benchmarks. I wouldn't be surprised if that same parameter caused this flake as well.

Thanks for the information. Do you have a link to the change?

Here is the feature request on Cirrus side: https://github.com/cirruslabs/cirrus-ci-docs/issues/688
And here are the new benchmarks on Flutter side: https://github.com/flutter/flutter/pull/62906


Get the CPU model in all mode

The model is populated only in fallback mode, we need it in all mode for #247

Fixed here https://github.com/mlco2/codecarbon/pull/247/commits/0651929cb9770d26444fc6d7373b8eef8ace3d89


Request for re-invitation as maintainer

Comment:
Hello,
I was previously invited as a maintainer for this repository, but the invitation has expired. Could you please send me a new invitation? My GitHub username is jroulet.
@conda-forge/core Could someone please assist with this?
Apologies for the inconvenience, and thank you in advance.

@conda-forge-admin, please ping core

@conda-forge-admin, please ping conda-forge/core


Panics with unknown export format version -1

panic: unknown export format version -1 ("i\x00\xe9\x03\xc6\x06\x18$GOROOT\\src\\fmt\\print.go\x00\x05Write\x01b\x01n\x03err\x05Width\x03wid\x02ok\tPrecision\x04prec\x04Flag\x01c\x06Format\x01f\x05State\x06String\bGoString\x01w\x06Writer\x02io\x06format\x01a\aesc:0x1\aesc:0x9\x17$GOROOT\\src\\fmt\\scan.go\bReadRune\x01r\x04size")
1(runtime.call32): C:/Go191/src/runtime/asm_amd64.s:509
2(runtime.gopanic): C:/Go191/src/runtime/panic.go:491
3(main.(*gc_bin_parser).parse_export): C:/Go/bin/src/github.com/nsf/gocode/package_bin.go:126
4(main.(*package_file_cache).process_package_data): C:/Go/bin/src/github.com/nsf/gocode/package.go:132
5(main.(*package_file_cache).update_cache): C:/Go/bin/src/github.com/nsf/gocode/package.go:92
6(main.update_packages.func1): C:/Go/bin/src/github.com/nsf/gocode/autocompletecontext.go:455
7(runtime.goexit): C:/Go191/src/runtime/asm_amd64.s:2337

Not sure what needs clearing/removing.

I'm getting this as well after switching to Go 1.11beta1. Switching back to Go 1.10 seems like has no effect. Maybe it's a coincidence, I don't know.
Any suggestions on how to debug this issue?

Another detail, that may be relevant: my Go 1.11 installation is a binary installation (I didn;t compile it myself).
Package files seems to have totally different encoding that crashes gocode. I can't find docs or commits that explain the diff, though.
Here is an output of pkg files for fmt for Go 1.10 and Go 1.11.
head -c 300 /usr/local/go1.10/pkg/darwin_amd64/fmt.a | less | pbcopy
!<arch>
__.PKGDEF       0           0     0     644     1384      `
go object darwin amd64 go1.10 X:framepointer
build id "KHuqXkHLVgkW_Ou5euoy/tdMow2Eq6Ax6uwLF86Xb"
----

build id "KHuqXkHLVgkW_Ou5euoy/tdMow2Eq6Ax6uwLF86Xb"

$$B
version 5

�fmt�
L
|SGOROOTsrcprint.go	State��	Write"b�

head -c 300 /usr/local/go1.11beta1/pkg/darwin_amd64/fmt.a | less | pbcopy
!<arch>
__.PKGDEF       0           0     0     644     1568      `
go object darwin amd64 go1.11beta1 X:framepointer
build id "NzYrUFEPyrRrj_uyqpl5/n8zsFBLs-yT__ncV8geh"
----

$$B
i�È∆$GOROOT/src/fmt/print.go�WritebnerrWidthwidok	PrecisionprecFlagcFormatfStateStringGoStringwWri

There is no version info and that's causing a crash.

Okay, I found it, it's called indexed export format and has been introduced recently: https://groups.google.com/forum/#!msg/golang-codereviews/6vqMfk1krNU/lzoJtkbuCQAJ
Some more info: https://groups.google.com/forum/#!topic/golang-dev/Lj_B-O6OMv8

Yeah I ran my own go 1.10+dev when I started seeing this.

So the proper solution would be to implement a parser for the indexed export format. I started to work on this, but it might take longer than from people who already worked with it. It actually requires a lot of copying and adapting from internal packages of Go codebase.

Is it correct that until gcode understands the new format, it is broken for Go >= 1.11?

I've opened an issue over at https://github.com/mdempsky/gocode/issues/43

Hm, turns out my test case was wrong, it works for me with Go 1.11beta2 and mdempksy's fork at https://github.com/mdempsky/gocode

I do not understand why this issue is closed... I am keep getting panic with go 1.11

It's not closed

oh, yes... sorry

Same issue here, even with go-langserver. Not working with go 1.11.

I'm having the same issue after upgrading to go  1.11

Hi! Is there a workaround for this issue. I am seeing the same with go version go1.11 darwin/amd64

The fork at https://github.com/mdempsky/gocode fixes this issue.


feat: make a fully hermetic, ephemeral, and reproducible build

Hello all. I'm not sure how useful -- if at all -- this is for y'all, but I thought I'd share. Feel free to disregard and close the PR if it is not of interest.
This README shows what this is about.
In its current form, the PR is not production ready.  I am sending it to get feedback of whether this approach makes sense for kythe. I have found it quite onerous otherwise to get from zero to working kythe on a pristine machine. This change makes the setup into a robust one liner that gets you all the software you need for the build environment, then builds and tests with success. It's like magic, except it's bazel.

Makes the necessary changes to allow an ephemeral nix instance to be used for providing all the build prerequisites.
The result is a hermetic, ephemeral and reproducible ("her") build.
As a result, provided that you have bazel installed, it is possible to compile the entire kythe distribution with a one-liner in shell.  It still takes a preposterous time to complete, unless you have a 96-core machine like I do. In which case it's about 10 minutes.
If you are curious why this works, see:
https://hdlfactory.com/post/2024/04/20/nix-bazel-/

On Sun, Aug 25, 2024 at 1:30 PM Shahms King @.***>
wrote:

As I'm not at Google anymore, I'm not in a position to say, but it seems
like a beneficial change.

o7, kind sir, your contributions remain in our fond memory.
Message ID: @.***>

We want to thank you for this effort and appreciate your contribution. Unfortunately, we don't have the capacity to look into this right now. We limit our engagement to critical bug fixes for now.
We might get back to this at a later point in time.
Sorry that I don't have a better answer for you.

It's OK, I understand. Good luck, folks.
On Fri, Sep 6, 2024 at 12:23 AM lfolger @.***> wrote:

We want to thank you for this effort and appreciate your contribution.
Unfortunately, we don't have the capacity to look into this right now. We
limit our engagement to critical bug fixes for now.
We might get back to this at a later point in time.
Sorry that I don't have a better answer for you.
—
Reply to this email directly, view it on GitHub
https://github.com/kythe/kythe/pull/6133#issuecomment-2333414607, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB4GMEIYYSDNK2HY3R554LZVFJ5RAVCNFSM6AAAAABNCZ762WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZTGQYTINRQG4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Hanging application when opening some ewebsock connections

Hi,
My egui application completly hang sometimes, it looks like it is related to cloning/requesting a repaint from the Context.
My project can be found on this repository at this exact commit, it looks like it happens only when multiple ewebsock are opened at the same time.
Here is a backtrace of all threads and we can see that it hang when a request_repaint was called (Context::write).
Hanging riemann-egui-dash.txt

Probably a double-locking of a mutex in Context.
Try running in debug (it catches some problems), or use the new deadlock_detection feature (https://github.com/emilk/egui/pull/1619) or try https://github.com/emilk/egui/pull/1732


Loaded a fine-tuned model produce gibberish text.

I follow the  bnb-4bit-training.ipynb
and then after finetuning, at the end attempt to save the model using the following:
trainer.save_model("./gdrive/MyDrive/fine-tuned-model_gpt-neo-1.3B")
model.config.to_json_file("./gdrive/MyDrive/fine-tuned-model_gpt-neo-1.3B/config.json")

and then load it with
model2 = AutoModelForCausalLM.from_pretrained("./gdrive/MyDrive/fine-tuned-model_gpt-neo-1.3B", device_map={"":0})
I expect model and model2 should give me same result, i.e.
output1= model.generate(**inputs, max_new_tokens=20)
output2 = model2.generate(**inputs, max_new_tokens=20)

but output2 gives me completely gibberish text, and not even close to output1
the tokenization is the same as before.
Do I miss something? Anything else need to save??

Find out what I need is
model.save_pretrained("output_dir")
from peft import PeftModel, PeftConfig
model = PeftModel.from_pretrained(model, peft_model_id)
mentioned in
https://github.com/huggingface/blog/blob/main/peft.md


Set correct file timestamp

Referenced: #845
Uncompressing..tar: ./release.yaml: implausibly old time stamp 1970-01-01 08:00:00
tar: ./bin/heron: implausibly old time stamp 1970-01-01 08:00:00
tar: ./bin: implausibly old time stamp 1970-01-01 08:00:00
tar: ./conf/local/client.yaml: implausibly old time stamp 1970-01-01 08:00:00
tar: ./conf/local/heron_internals.yaml: implausibly old time stamp 1970-01-01 08:00:00
tar: ./conf/local/metrics_sinks.yaml: implausibly old time stamp 1970-01-01 08:00:00
tar: ./conf/local/packing.yaml: implausibly old time stamp 1970-01-01 08:00:00
Though it is a WARNING, it is good if we can remove it.

Travis-ci building also shows this WARNING during untar:
[2016-06-14 02:05:18 +0000] com.twitter.heron.spi.common.ShellUtils FINE:  $> [tar, -xvf, /home/travis/.herondata/topologies/local/heron-staging/1465869225_IntegrationTest_OneBoltMultiTasks_de8c043e-7d22-4ac4-ba17-902fbba5db81/topology.tar.gz]
integration-tests.jar
1465869225_IntegrationTest_OneBoltMultiTasks_de8c043e-7d22-4ac4-ba17-902fbba5db81.defn
./heron-conf/
./heron-conf/heron_internals.yaml
tar: ./heron-conf/heron_internals.yaml: implausibly old time stamp 1970-01-01 00:00:00
./heron-conf/packing.yaml
tar: ./heron-conf/packing.yaml: implausibly old time stamp 1970-01-01 00:00:00
./heron-conf/uploader.yaml
tar: ./heron-conf/uploader.yaml: implausibly old time stamp 1970-01-01 00:00:00
./heron-conf/client.yaml
tar: ./heron-conf/client.yaml: implausibly old time stamp 1970-01-01 00:00:00
./heron-conf/scheduler.yaml
tar: ./heron-conf/scheduler.yaml: implausibly old time stamp 1970-01-01 00:00:00
./heron-conf/statemgr.yaml
tar: ./heron-conf/statemgr.yaml: implausibly old time stamp 1970-01-01 00:00:00
./heron-conf/metrics_sinks.yaml
tar: ./heron-conf/metrics_sinks.yaml: implausibly old time stamp 1970-01-01 00:00:00
./heron-conf/release.yaml
tar: ./heron-conf/release.yaml: implausibly old time stamp 1970-01-01 00:00:00
./heron-conf/override.yaml
tar: ./heron-conf: implausibly old time stamp 1970-01-01 00:00:00

This is a bazel issue. All timestamps get reset upon build. Need to investigate more to see if we can change this.
https://github.com/bazelbuild/bazel/issues/1299
https://groups.google.com/forum/#!topic/bazel-discuss/cprd0UhRMAs

These are warnings that can be ignored. Untarring with --warning=no-timestamp should suppress the warning. See https://www.gnu.org/software/tar/manual/html_node/warnings.html

@billonahill - awesome. Can we fix the scripts where we untar? They are the installer scripts.

Ideally we'd fix the timestamps but that looks tricky due to bazel magic. Instead we suppressed the warnings for now. Will close this, but we can revisit to see if it's still an issue after upgrading to the latest bazel.