Move ClassStructure to Style

Is your feature request related to a problem? Please describe.
With one significant exception, --fix-layout behaves the way we might expect a code formatter to behave: "Layout cops inspect your code for consistent use of indentation, alignment, and white space."  The entire Layout department will only make whitespace changes when auto-formatting, except for one cop (or are there others?).  Likewise, there is only one cop in the Layout department that is unsafe and could potentially change the semantics of the code.
Likewise, "Style cops check for stylistic consistency of your code" is a perfect description of what the ClassStructure cop is doing.
Related: #11904
Describe the solution you'd like
Move Layout/ClassStructure to Style/ClassStructure
Describe alternatives you've considered
If only constant literals, and def/def.self method definitions were reordered, and if they were only between "macros", then ClassStructure could be safe.  However it still doesn't fit in with the "purely syntax formatting" nature of the other layout cops.  Even if it were perfectly safe, it should still be moved (in my opinion).

Yeah, it's a bit tricky to classify this cop, but I prefer for it to stay as part of the Layout department, mostly because it's about the layout of a class. If I were naming it today it'd be something like ClassLayout or just Class, given it's already Layout/name.
I acknowledge it's more complex than many of the cops in the department, but this doesn't make it fundamentally different. Classes should have consistent layout (structure) in the end of the day. The implementation of this cop is a different topic altogether - there's a lot of room for improvement there and I recall they were some suggestions here and there, but we never made much headway in this direction.

@bbatsov That makes sense, and thanks for considering my request.  And yeah, I love this cop, even though I only have it enabled for a fraction of the files in my various codebases.  And I can work around my issue by locally configuring it as unsafe (#11904).  Even in that other ticket, I tried to distinguish between "unsafe because of current implementation" vs "unsafe because it simply isn't possible to be truly safe".
But perhaps I should have started with my primary motivation, and that might have led to a better feature request.  What I really want is an option to only execute the ultra-safe and completely unsurprising "formatting" cops.  To me, that means only running cops where the autocorrections will not change the AST.  With this one exception, I think that all of the layout cops fit this criteria, so rubocop -x almost does what I want.
However, when using rubocop -x as a formatter there are also several Style cops that I wish ran as well.  E.g: double vs single quote string literals (uninterpolated), semicolon vs then keyword, trailing commas, and others result in the same exact AST (verified with ruby --dump=parsetree).  And, there are cops from other gems that I'd like to run under -x as well, e.g: RSpec/EmptyLineAfterSubject.  But I don't think those should be moved from Style or RSpec or Rails (etc) into Layout.
So, I suppose what I really want is a attribute on cops that means that "autocorrections will only format the code, while leaving the AST unchanged".  And (perhaps) that attribute could default to true for Layout cops and false for all others.  That seemed like a bigger change to suggest than just moving this cop, but... what do you think?
Thinking through this a bit more, the popular "format on save" use-case provides good examples why its useful to have rubocop -x (or rubocop --format or whatever) as distinct from reordering code or other rubocop -a autocorrections, even when they are semantically identical, even when they compile into the same iseqs.  For example: even a perfectly safe reordering of methods can be incredibly confusing when you're in the middle of working on something and your code simply "disappears" (is moved to elsewhere in the file).  And converting from a ternary into if/then/else or vice versa can have the same iseq but does change the grammar in a way that a formatter shouldn't.  The formatter may know that the two are semantically identical, but it doesn't know that I'm halfway through refactoring from error objects to exceptions (from cond? ? ok : err to if cond? then ok else raise Err end) or vice versa or perhaps I'm about to add an elsif clause and I wanted to run the tests first.  In other words, even when rubocop -a is perfectly safe, it still isn't safe as a formatter.
What do you think?

Looking at #11904, as already discussed, the Layout department should conform to the formatting that operates with rubocop -x. This means that ClassStructure cop, which may change the AST and makes unsafe modifications, might be better suited for the Style department.
This proposed department change seems to align with the unsafe autocorrect in #11904.

Yeah, I get this perspective as well. In theory the cop mostly re-arranges stuff in the class, but metaprogramming can mean that some of this reordering is unsafe.


Output from ombt2 in machine readable format, like JSON

It would be nice if ombt2 could output in a machine readable format, like JSON.

That's maybe not exactly what you want, but there's an option --output that can be passed to the agents.
I'm using mostly the controller one : https://github.com/kgiusti/ombt/blob/879faa754ed2bde605d3f11057030db7ea3f9d58/ombt/_main.py#L344
For the controller, this output 2 lines (each in JSON format) with the non aggregated results for the clients (first line) and the servers (second line). The format  is questionnable, but this is what I rely on so far.


Changes to actions

Please wait until confirmation of merger. Waiting for proper checks to pass. Referencing previous errors with current errors for proper diagnoses of issue.

@joethorley Is this a repo we could archive? All the checks are failing at this point, it appears they have broken since the actions stopped running.

We will merge this for now and make an issue to correct the errors in testing


PullRequestEvent -> PullRequest -> Labels does not have an object

Fixed in https://github.com/doodla/octohook/commit/3fd6548142f4a2a36a270a95ccc21bee3f80f051


photometric error jacobian w.r.t host frame idepth

hi, thank you for open sourcing your excellent work. i am derivating the jacobians used in pba, and having problems about the term: "Vector3d dp1_dq0 = T10_fej.translation(); " , in function AdjustCost::CalcJacGeo( ) of adjust.cpp, , according to my derivation, this term is something like "dp1_dq0 = -T10_fej.linear()*point0.pt()/q0", when i run my modification, the optimization won't converge. may i ask for some detailed derivetions about this term? thanks a lot.

The p1 in there is actually p1'.
You can see in L468 and L469.
This is needed to avoid dividing by 0 (if q0 is 0).

thank you for your immediate reply. i should've deriveted the jacobians with L469 instead of L468, lesson learned.


intersect_ray() result normal can be inverted or length 0.

Godot version:
0edcb8e
OS/device including version:
Win10 64-bit
Issue description:
intersect_ray can have unpredictable normal return values when the origin of the ray starts inside of geometry it can collide with.
https://docs.godotengine.org/en/3.2/classes/class_physicsdirectspacestate.html#class-physicsdirectspacestate-method-intersect-ray
Some cases it points to a random edge, other times completely inverted, and on occasion it might return Vector2(0, 0).

It would be nice if it were more robust, or at least didn't return results at all.
Steps to reproduce:
Cast a ray with it's starting point inside the collision geometry.
Minimal reproduction project:
Intersect Ray.zip

I confirm this to be somewhat a problem in my project too when checking, but I'm not sure if this is by design. It might be computationally expensive to check whether a point lies inside those shapes.
Casting a continuous rays which reflects against colliders works:

But when a ray starts inside the collider, it's basically stuck:

There are also somewhat rare occasions where a ray gets stuck like that even if it wasn't initially "emitted" inside a collider, but I think that happens because I do some hacks to avoid continuous detection (see also https://github.com/godotengine/godot/issues/35344#issuecomment-576308249):
# Minimize the chance of collider penetration
from = raycast.position + dir * safe_margin

which might lead to a situation where the next ray might indeed start inside a collider and not outside.
The same behavior persists with RayCast2D node.
I guess the workaround is to check whether there are any colliders at position by calling intersect_point method.

on occasion it might return Vector2(0, 0)

I think that happens when you cast a ray just exactly between internal adjacent convex shapes.

It's unexpected, and actually a bit difficult and limiting to work around this.
The wrinkle I've had is with whiskers on enemy steering.  If they're too far outside their collision shape, they're likely to end up in a wall during a twist and turn.

In this example the goal is ahead, but a backwards contact with a wall would be fine to help create a separation force, but here it becomes an attractor, since the normal (white arrow) is inverted.

@pouleyKetchoupp This one may or may not be an issue, but if not, maybe it's still worth considering having some clarity or well defined behavior for what's supposed to happen.  Only because sometimes one can get usable results, and other times not.  It can mislead one to first think the code is working.  In my case, I did some tests on some geometry that didn't quite capture what would later appear in the game.  Initially it looked good, and for many weeks things appeared to be working, and I went on a bad development path.
The summary:
What's supposed to happen with rays (or even shapes) that have points originating inside geometry?
And what of compound geometries like many concave polygons created to represent a single convex polygon?
If things need to get ejected from a collection of shapes acting as one, the developer is probably only interested in the shared border.  If it were a wall, it wouldn't be desirable to have something juggle around inside of the internal edges.
If convex polygons don't get treated as a whole in certain cases, it would be a very nice thing for the API to provide information somehow to figure out a solution in the game logic.


User/sahrbini/pin taskbar1

Summary of the pull request
Adding new entries to the "dot" menu, for pinning Dev Environments.
References and relevant issues
Detailed description of the pull request / Additional comments
Added checks to see if a Dev Env supports pinning to taskbar and/or start menu.  If yes then we add the corresponding pinning entries to the "triple dot" menu.
Validation steps performed
Tested with DevBox entries, which is the only Dev Env that  is suppported at this time.
PR checklist

[ ] Closes #xxx
[ ] Tests added/passed
[ ] Documentation updated

Can you put a gif in the PR to show an example?


Prevent escaping in arguments

While for most cases the test condition is valid, when $1 is a space-delimited string,
the [] evaluate it as extra parameters which can lead to escaping and erroneous
behavior.
Example:
Old code:
$ ./conjurcli.sh 'somevar -o 0 -eq 0'
No argument received

Good catch, thanks!


CARGO_RUSTC_CURRENT_DIR is causing forced rebuilds

Problem
In the cargo repo, there is an environment override setting the CARGO_RUSTC_CURRENT_DIR environment variable: https://github.com/rust-lang/cargo/blob/79866e12c663e866a904d713c29745563a64aafa/.cargo/config.toml#L7-L10
This is causing testsuite to always be considered dirty on my system. I am getting:
FsStatusOutdated(StaleItem(ChangedEnv
{ var: "CARGO_RUSTC_CURRENT_DIR",
previous: Some("/Users/eric/Proj/rust/cargo"),
current: Some("/Users/eric/Proj/rust/cargo/")
}

Steps

Check out rust-lang/cargo
cargo test --test testsuite --no-run
cargo test --test testsuite --no-run -- This should build testsuite again.

Possible Solution(s)
No response
Notes
No response
Version
cargo 1.84.0-nightly (031049782 2024-11-01)
release: 1.84.0-nightly
commit-hash:<PHONE_NUMBER>a7a673a330a5dd068b7aaa579a265e
commit-date: 2024-11-01
host: aarch64-apple-darwin
libgit2: 1.8.1 (sys:0.19.0 vendored)
libcurl: 8.7.1 (sys:0.4.74+curl-8.9.0 system ssl:(SecureTransport) LibreSSL/3.3.6)
ssl: OpenSSL 1.1.1w  11 Sep 2023
os: Mac OS 14.6.1 [64-bit]

I'm not able to reproduce this on my system on stable
❯ cargo test --test testsuite --no-run
warning: ignoring `resolver` config table without `-Zmsrv-policy`
   Compiling cargo v0.85.0 (/home/epage/src/personal/cargo)
   Compiling cargo-util v0.2.17 (/home/epage/src/personal/cargo/crates/cargo-util)
   Compiling cargo-credential v0.4.7 (/home/epage/src/personal/cargo/credential/cargo-credential)
   Compiling crates-io v0.40.7 (/home/epage/src/personal/cargo/crates/crates-io)
   Compiling cargo-util-schemas v0.7.1 (/home/epage/src/personal/cargo/crates/cargo-util-schemas)
   Compiling rustfix v0.9.0 (/home/epage/src/personal/cargo/crates/rustfix)
   Compiling cargo-platform v0.1.9 (/home/epage/src/personal/cargo/crates/cargo-platform)
   Compiling cargo-credential-libsecret v0.4.10 (/home/epage/src/personal/cargo/credential/cargo-credential-libsecret)
   Compiling cargo-test-support v0.6.0 (/home/epage/src/personal/cargo/crates/cargo-test-support)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 37.46s
  Executable tests/testsuite/main.rs (target/debug/deps/testsuite-b494325e491a8e98)

cargo on  clippy is 📦 v0.85.0 took 37s
❯ cargo test --test testsuite --no-run
warning: ignoring `resolver` config table without `-Zmsrv-policy`
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.10s
  Executable tests/testsuite/main.rs (target/debug/deps/testsuite-b494325e491a8e98)

Reproduces on nightly
cargo on  clippy is 📦 v0.85.0
❯ cargo +nightly test --test testsuite --no-run
   Compiling cargo-util v0.2.17 (/home/epage/src/personal/cargo/crates/cargo-util)
   Compiling cargo v0.85.0 (/home/epage/src/personal/cargo)
   Compiling cargo-credential v0.4.7 (/home/epage/src/personal/cargo/credential/cargo-credential)
   Compiling crates-io v0.40.7 (/home/epage/src/personal/cargo/crates/crates-io)
   Compiling cargo-util-schemas v0.7.1 (/home/epage/src/personal/cargo/crates/cargo-util-schemas)
   Compiling rustfix v0.9.0 (/home/epage/src/personal/cargo/crates/rustfix)
   Compiling cargo-platform v0.1.9 (/home/epage/src/personal/cargo/crates/cargo-platform)
   Compiling cargo-test-support v0.6.0 (/home/epage/src/personal/cargo/crates/cargo-test-support)
   Compiling cargo-test-macro v0.3.3 (/home/epage/src/personal/cargo/crates/cargo-test-macro)
   Compiling cargo-credential-libsecret v0.4.10 (/home/epage/src/personal/cargo/credential/cargo-credential-libsecret)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 32.26s
  Executable tests/testsuite/main.rs (target/debug/deps/testsuite-ffba239b1f3ab958)

cargo on  clippy is 📦 v0.85.0 took 32s
❯ cargo +nightly test --test testsuite --no-run
   Compiling cargo v0.85.0 (/home/epage/src/personal/cargo)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 4.08s
  Executable tests/testsuite/main.rs (target/debug/deps/testsuite-ffba239b1f3ab958)

Wonder if this was #14701

My nightly isn't too old yet if I run out of master, I don't see it
cargo-14701 on  main is 📦 v0.1.0
❯ nargo check
warning: ignoring `resolver` config table without `-Zmsrv-policy`
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.11s
     Running `/home/epage/src/personal/cargo/target/debug/cargo -Zscript -Zmsrv-policy check`
    Checking cargo-14701 v0.1.0 (/home/epage/src/personal/dump/cargo-14701)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.09s

cargo-14701 on  main is 📦 v0.1.0
❯ nargo check
warning: ignoring `resolver` config table without `-Zmsrv-policy`
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.10s
     Running `/home/epage/src/personal/cargo/target/debug/cargo -Zscript -Zmsrv-policy check`
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s

I even switched to 8315873f5ad771fb45a59754f63712067062c7ca and didn't see it

A reproduction without the cargo repo:
// src/main.rs
fn main() {
    println!("{:?}", option_env!("CARGO_RUSTC_CURRENT_DIR"));
}

# .cargo/config.toml
[env]
CARGO_RUSTC_CURRENT_DIR = { value = "", relative = true }

cargo build

When I run nargo, I'm using the default rustc.
I wonder if rustc changed something about how it records paths...

I switched my default rustc to nightly and still not reproducing this out of cargo master.

   0.006690626s  INFO main:exec:compile_ws:compile:compile{unit=Unit { pkg: Package { id: PackageId { name: "cargo-147
01", version: "0.1.0", source: "/home/epage/src/personal/dump/cargo-14701" }, ..: ".." }, target: TargetInner { name:
"cargo-14701", doc: true, ..: with_path("/home/epage/src/personal/dump/cargo-14701/src/main.rs", Edition2021) }, profi
le: Profile { debuginfo: Resolved(LineTablesOnly), split_debuginfo: Some("unpacked"), ..: default_dev() }, kind: Host,
 mode: Check { test: false }, features: [], rustflags: [], rustdocflags: [], links_overrides: {}, artifact: false, art
ifact_target_for_features: None, is_std: false, dep_hash:<PHONE_NUMBER>356721367 } force_rebuild=false}:prepare_target{fo
rce=false package_id=cargo-14701 v0.1.0 (/home/epage/src/personal/dump/cargo-14701) target="cargo-14701"}: cargo::core
::compiler::fingerprint:     dirty: FsStatusOutdated(StaleItem(ChangedEnv { var: "CARGO_RUSTC_CURRENT_DIR", previous:
Some("/home/epage/src/personal/dump/cargo-14701"), current: Some("/home/epage/src/personal/dump/cargo-14701/") }))
       Dirty cargo-14701 v0.1.0 (/home/epage/src/personal/dump/cargo-14701): the environment variable CARGO_RUSTC_CURR
ENT_DIR changed
     Running `CARGO=/home/epage/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo CARGO_BIN_NAME=cargo-147
01 CARGO_CRATE_NAME=cargo_14701 CARGO_MANIFEST_DIR=/home/epage/src/personal/dump/cargo-14701 CARGO_MANIFEST_PATH=/home
/epage/src/personal/dump/cargo-14701/Cargo.toml CARGO_PKG_AUTHORS='' CARGO_PKG_DESCRIPTION='' CARGO_PKG_HOMEPAGE='' CA
RGO_PKG_LICENSE='' CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=cargo-14701 CARGO_PKG_README='' CARGO_PKG_REPOSITORY='' CA
RGO_PKG_RUST_VERSION='' CARGO_PKG_VERSION=0.1.0 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=1 CARGO_PKG_VERSION_
PATCH=0 CARGO_PKG_VERSION_PRE='' CARGO_PRIMARY_PACKAGE=1 CARGO_RUSTC_CURRENT_DIR=/home/epage/src/personal/dump/cargo-1
4701 LD_LIBRARY_PATH='/home/epage/src/personal/dump/cargo-14701/target/debug/deps:/home/epage/.rustup/toolchains/night
ly-x86_64-unknown-linux-gnu/lib' foo=bar /home/epage/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/rustc --c
rate-name cargo_14701 --edition=2021 src/main.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-
incompat --crate-type bin --emit=dep-info,metadata -C embed-bitcode=no -C debuginfo=line-tables-only -C split-debuginf
o=unpacked --check-cfg 'cfg(docsrs)' --check-cfg 'cfg(feature, values())' -C metadata=d0f79a6560e2ae7d -C extra-filena
me=-d0f79a6560e2ae7d --out-dir /home/epage/src/personal/dump/cargo-14701/target/debug/deps -C incremental=/home/epage/
src/personal/dump/cargo-14701/target/debug/incremental -L dependency=/home/epage/src/personal/dump/cargo-14701/target/
debug/deps`

Specifically
dirty: FsStatusOutdated(StaleItem(ChangedEnv { var: "CARGO_RUSTC_CURRENT_DIR", previous:
Some("/home/epage/src/personal/dump/cargo-14701"), current: Some("/home/epage/src/personal/dump/cargo-14701/") }))

yet the env variable we pass  to rustc is different.

Ah, this is specific to CARGO_RUSTC_CURRENT_DIR.  We decided to not stabilized it in #13644 but I never removed the code.  The [env] is setting it one way and then we are overriding it a different way.
I'll remove that code.

This is indeed related to #14701, and was pointed out as a caveat https://github.com/rust-lang/cargo/pull/14701#issuecomment-2436775171.

If any "internal" environment Cargo sets for crates is set the [env] table, it would be captured in dep-info files. If values from [env] and from Cargo internal don't match, Cargo rebuilds.
I think it is generally a mistake to set Cargo internal envs, as they won't have any effect. We could do something to improve the situation,

Warn if those are set.
Filter out those when needed, like when fingerprint comparison.

https://github.com/rust-lang/cargo/pull/14811#issuecomment-2550083683 is closed.
Some directions we can move foward to

Track metadata by Cargo's dep-info file, instead of manual track in fingerprint. https://github.com/rust-lang/cargo/pull/14811#discussion_r1880431940
Update docs and tell don't set Cargo internal envs in the [env] table. It either doesn't work, and triggers unnecessary rebuild.

Track metadata by Cargo's dep-info file, instead of manual track in fingerprint. fix(env): dont track envs set by cargo in dep-info file  #14811 (comment)

FYI, https://github.com/rust-lang/cargo/pull/14973 is an attempt to address this part.


Update to Angular 8

Test with Angular 8. There will be some changes like query timings on ViewChild.
https://angular.io/guide/static-query-migration

I tested the starter angular project and the only change I had to make was adding the @ViewChild('mapViewNode', {static: true}) private mapViewEl: ElementRef;
As far as I can tell, everything else is working as intended. :)

@mamallama thanks! I also noticed a small CSS change in the map component where I had to remove the height percentage and replace it with a specific height. I haven't researched that further yet.
.esri-view {
  height: 500px;
}

Closing. Updated repo to work with Angular 8. Switched from css to scss. Reference https://github.com/Esri/angular-cli-esri-map/commit/7aa92d9a892474ace22a7e1fb65c1ce8725bd26d. If there are any issues let me know.


Get community pools on Polygon

https://community.pooltogether.com/pools/matic/0x9e299cf900a81b55024398ff2cdb1c9c0fcec902/home
Pool not displaying on https://community.pooltogether.com/ when on Polygon Mainnet

Looks like this has been added to PRIZE_POOL_LIST_FALLBACK constant in useAllCreatedPrizePools - should be good to go


Features/retry unavailable inputs

Add ability to pass the head of an error message to feed-rerun, to rerun based on a user-specified error message

This was merged in 1ec452c. Sadly, github does not detect that merge and I do not see a way to mark this PR as merged. How sad.


Browser opens twice

I'm using macbook bigsur,
when i call the code, it opens the browser 2 times and same evaluation happening 2 times.
Can any one help to solve this

I couldn't reproduce that behavior here.
I just ran the first example of the readme in 2 macbooks, one with Big Sur and the other with Mojave. In both cases it worked as expected, only one chrome instance was opened.

can we connect on skype(live:manobala.s)?
so i can show you ...

That wouldn't help. If the error is not reproducible in another machine, the issue is probably in your end. What chrome version are you using and what is the specific code that causes this behavior?

Here is the code that I've used
<?php
require 'vendor/autoload.php';
use HeadlessChromium\BrowserFactory;
$browserFactory = new BrowserFactory();
$browser = $browserFactory->createBrowser(['headless' => false]);

try {
    $page = $browser->createPage();
    $page->navigate('https://api.upstox.com/index/login')->waitForNavigation();
    $page->evaluate("document.getElementsByClassName('pure-input-1 input-fields')[0].value = 918");
    $page->evaluate("document.getElementsByClassName('pure-input-1 input-fields')[1].value = ''");
    $page->evaluate("document.getElementsByClassName('pure-input-1 input-fields')[2].value = ''");
    $page->evaluate("document.getElementsByClassName('pure-button-primary')[0].click()");
    $page->evaluate("document.getElementsByClassName('pure-button-primary')[0].click()");
} finally {
    $browser->close();
}

Version 90.0.4430.212 (Official Build) (x86_64)

I tested the same code here and it worked normally.

anything fishy ?
When i run that, it completes all the commands and then again it runs again...
Another Question: I;m planning to put this code in ubuntu server, is there the problem will be ? or it will be good ?

Here it just runs all commands once and exit. If you plan to use it in a server, test in a server.

I think this is possibly fixed in v0.11.0 owing to the removal of the version checking code. Can you please confirm?


#98 Changed on_delete behaviour of API requests to CASCADE

Make users deletable again, by changing on_delete from PROTECT to CASCADE. This means that when deleting a users, all corresponding API logs will also be removed. With PROTECT users were not deletable at all, until all corresponding API request logs were manually removed. See #98

I would set SET_NULL, I wouldn't want to lose data that can help me to know more about my API


Initialize RTTI's mInitMembers object with 'this' by default,

removing the need to initialize it in every RTTI-able object.
Took significantly less time than I anticipated.
I'd like to point out again that I really enjoy how clean and modern you've kept the bsf code. So many projects out there are... well, unreadable, i guess is the most polite way to say it.
Bsf / Banshee is beautiful by comparison to almost everything else I've seen out there.
Take, as an example, the Ninja build system. I've been using it at work, and wanted to hack some compatibility features into it. It's... it's bad.
I've got a couple of patches to it that clean it up a little bit using C++11 features, but the maintainers have no interest in using anything newer than C++98. So I'm probably going to fork it (Maybe name it Splinter, after the famous ninja master from the popular cartoon involving turtles). shrug.
Banshee / Bsf is just so damn pretty by comparison.

Btw, kind of unrelated to this PR, but I noticed when looking at the CI systems that they're downloading the dependencies almost every time (every time?).
I know that at least for Travis, there's some way to pre-upload the dependencies to their system, so the download doesn't keep happening (or at least only happens internally, instead of across the internet).
Not sure if that's something you want to address or not. I imagine bandwidth from github.com isn't a big deal.

Thanks for the compliments, nice to hear it's being appreciated. And it's getting prettier by the day with your help :)
I think I investigated caching for CI, but couldn't get it working at the time. But I no longer remember exactly what was the issue. I should take another look.
I'll merge in a sec. I think we can get rid of the constructor's completely, instead of = default.

RE: Prettier. Yup, glad to help. I'm learning a lot about how game engines work. Great learning experience.
RE: Caching. Sure, makes sense.
RE: Dropping constructors. Sure, that'd be fine w/ me. I normally specify all of the constructors / assignment operator, even if with = default, but that's because a lot of the guys I work with are still in the C++98 mindset, and they sometime struggle to handle post C++11 code, so I do that to make it clear what's happening for their sake.

Merged.


Connect metering point upon receiving metering point connected integration event

When a metering point is connected in the metering point domain the resulting "metering point connected" integration event needs to result in a connection of the corresponding accounting point.

State not changed in MR domain. The resulting connect is not created as an internal command.


Create Docker image and wrapper script

Docker image is now created and installation and usage are described on the installation wiki page.


getCurrenButtonsCount typo

From<EMAIL_ADDRESS>on July 25, 2010 08:29:08
Solo.getCurrenButtonsCount() should be Solo.getCurrentButtonsCount(). What version of the product are you using? On what operating system? robotium-1.6.0
Original issue: http://code.google.com/p/robotium/issues/detail?id=12

From<EMAIL_ADDRESS>on July 25, 2010 11:46:31
You are absolutely right. This will be corrected in the next version.
Status: Accepted

From<EMAIL_ADDRESS>on August 12, 2010 09:41:07
Owner: renasreda

From<EMAIL_ADDRESS>on August 23, 2010 21:54:32
Old legacy method that has been deprecated.
Status: Done


Example usage with ArmApiControl passes body incorrectly

The example usage of ArmApiControl together with a Textbox passes the body to ArmApiControl as a string instead of an object as it is supposed to be. See https://docs.microsoft.com/en-us/azure/azure-resource-manager/managed-applications/microsoft-solutions-armapicontrol for proper usage.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c578c136-4390-fa22-082f-b342c9174964
Version Independent ID: ec89ef9d-ab26-8e36-94dc-69231d3158e9
Content: TextBox UI element - Azure Managed Applications
Content Source: articles/azure-resource-manager/managed-applications/microsoft-common-textbox.md
Service: managed-applications
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@ascott18 Thanks a lot for your feedback, I have assigned this issue to our document author @tfitzmac to further review and update the document accordingly.

#reassign:davidsmatlak

@ascott18 I noticed while making some other changes that the body property for the ArmApiControl is documented as an object. The commit history shows someone submitted the fix but the issue wasn't closed. I made some other updates to the article and when that pull request is merged, this issue will automatically close.


Conditional Access Policy validation is broken

The sessionControls field of conditional access policies is validated incorrectly and inconsistently. When updating an existing conditional access policy to disable signInFrequency, sometimes this is not possible because the API does not accept the request. This happens with both the v1.0 and beta endpoints.
Example Request
PATCH /v1.0/57934744-b9ca-4e29-b5df-7578783cc31b/identity/conditionalAccess/policies/8eca5441-5a49-4273-b494-5171957fa938 HTTP/1.1
Host: graph.microsoft.com
User-Agent: HashiCorp Terraform/1.0.6 (+https://www.terraform.io) Terraform Plugin SDK/2.7.0 terraform-provider-azuread/dev Hamilton (Go-http-client/1.1) pid-222c6c49-1b0a-5959-a213-6608f9eb8820
Content-Length: 835
Accept: application/json
Authorization: Bearer [redacted]
Content-Type: application/json; charset=utf-8
Accept-Encoding: gzip

{
  "conditions": {
    "applications": {
      "includeApplications": [
        "All"
      ],
      "excludeApplications": [],
      "includeUserActions": []
    },
    "users": {
      "includeUsers": [
        "All"
      ],
      "excludeUsers": [
        "GuestsOrExternalUsers"
      ],
      "includeGroups": [],
      "excludeGroups": [],
      "includeRoles": [],
      "excludeRoles": []
    },
    "clientAppTypes": [
      "browser"
    ],
    "locations": {
      "includeLocations": [
        "All"
      ],
      "excludeLocations": []
    },
    "platforms": {
      "includePlatforms": [
        "all"
      ],
      "excludePlatforms": []
    },
    "signInRiskLevels": [],
    "userRiskLevels": []
  },
  "displayName": "acctest-CONPOLICY-210916131029741032",
  "grantControls": {
    "operator": "OR",
    "builtInControls": [
      "block"
    ],
    "customAuthenticationFactors": [],
    "termsOfUse": []
  },
  "id": "f0b63446-86b9-4f21-8668-5923f4d9db6e",
  "sessionControls": {
    "applicationEnforcedRestrictions": {
      "isEnabled": false
    },
    "cloudAppSecurity": {
      "isEnabled": false
    },
    "signInFrequency": {
      "isEnabled": false
    }
  },
  "state": "disabled"
}

400 Response
HTTP/1.1 400 Bad Request
Date: Thu, 16 Sep 2021 12:46:18 GMT
Content-Type: application/json
Cache-Control: no-cache
Transfer-Encoding: chunked
Content-Encoding: gzip
Vary: Accept-Encoding
Strict-Transport-Security: max-age=31536000
request-id: 33432bcb-7152-4559-a46a-72b6a86466de
client-request-id: 33432bcb-7152-4559-a46a-72b6a86466de
x-ms-ags-diagnostic: {"ServerInfo":{"DataCenter":"UK South","Slice":"E","Ring":"3","ScaleUnit":"000","RoleInstance":"LN2PEPF00003AC1"}}

{
  "error": {
    "code": "BadRequest",
    "message": "1019: SignInFrequency type is invalid. It must be a valid hour or day. For examples, please see API documentation at https://docs.microsoft.com/en-us/graph/api/conditionalaccesspolicy-update?view=graph-rest-1.0.",
    "innerError": {
      "date": "2021-09-16T12:46:18",
      "request-id": "33432bcb-7152-4559-a46a-72b6a86466de",
      "client-request-id": "33432bcb-7152-4559-a46a-72b6a86466de"
    }
  }
}

Note that this error only happens in some (as yet undetermined) circumstances, other times the same request is accepted without error:
Request
PATCH /v1.0/57934744-b9ca-4e29-b5df-7578783cc31b/identity/conditionalAccess/policies/9374b53d-7b5c-43b8-9d69-777db20ac896 HTTP/1.1
Host: graph.microsoft.com
User-Agent: HashiCorp Terraform/1.0.6 (+https://www.terraform.io) Terraform Plugin SDK/2.7.0 terraform-provider-azuread/dev Hamilton (Go-http-client/1.1) pid-222c6c49-1b0a-5959-a213-6608f9eb8820
Content-Length: 835
Accept: application/json
Authorization: Bearer [redacted]
Content-Type: application/json; charset=utf-8
Accept-Encoding: gzip

{
  "conditions": {
    "applications": {
      "includeApplications": [
        "All"
      ],
      "excludeApplications": [],
      "includeUserActions": []
    },
    "users": {
      "includeUsers": [
        "All"
      ],
      "excludeUsers": [
        "GuestsOrExternalUsers"
      ],
      "includeGroups": [],
      "excludeGroups": [],
      "includeRoles": [],
      "excludeRoles": []
    },
    "clientAppTypes": [
      "browser"
    ],
    "locations": {
      "includeLocations": [
        "All"
      ],
      "excludeLocations": []
    },
    "platforms": {
      "includePlatforms": [
        "all"
      ],
      "excludePlatforms": []
    },
    "signInRiskLevels": [],
    "userRiskLevels": []
  },
  "displayName": "acctest-CONPOLICY-210916133840745958",
  "grantControls": {
    "operator": "OR",
    "builtInControls": [
      "block"
    ],
    "customAuthenticationFactors": [],
    "termsOfUse": []
  },
  "id": "ac7412c6-bfdc-4d3b-9ef2-04a2e51f7c24",
  "sessionControls": {
    "applicationEnforcedRestrictions": {
      "isEnabled": false
    },
    "cloudAppSecurity": {
      "isEnabled": false
    },
    "signInFrequency": {
      "isEnabled": false
    }
  },
  "state": "disabled"
}

204 Response
HTTP/1.1 204 No Content
Date: Thu, 16 Sep 2021 12:43:13 GMT
Content-Length: 0
Cache-Control: no-cache
Strict-Transport-Security: max-age=31536000
request-id: e699dce6-122f-4be9-9130-5a4bf79f8a3e
client-request-id: e699dce6-122f-4be9-9130-5a4bf79f8a3e
x-ms-ags-diagnostic: {"ServerInfo":{"DataCenter":"UK South","Slice":"E","Ring":"3","ScaleUnit":"000","RoleInstance":"LN2PEPF00003315"}}

Related to: https://github.com/hashicorp/terraform-provider-azuread/pull/569

This seems to be fixed in the v1.0 API at least, setting {"sessionControls": null} for an existing policy seems to work now.


feature/new-type-REACTIVE_PANACHE

add a new TemplateType which will be full reactive with JDBC

branch: feature/REACTIVE_PANACHE

Only integration-tests are failing


SRD result is missing.

Hi. I'm doing an evaluation while looking at the paper, and I have a question. Among the result images for test data set, the image for SRD data set is missing. Can you provide this?

And The SRD pre-trained Model  is also Missing.

Hi. Are you gonna add SRD pre-trained Model weights?

Can you reproduce the results of SRD？
I train the SRD dataset ，but PSNR is very low only 20.


Get ache running on deployment server.

Plots and data are not being gathered.

Thanks @quasiben for finally getting this working.


Custom css doesn't affect copilot

I am not able to remove the footer in copilot, however I am able to do the same in main UI using custom css.
It seems the css doesn't impact copilot, is that by design? If yes, what's the workaround?
Please help.
If can't remove footer, then I need to change "Built with {chainlit logo}" to "{my-custom-logo}".
I already tried using custom logo like putting logo_dark.png in /public. This changes the header logo, but not the footer logo.
I am using: chainlit==1.1.202

I am having the same issue. Has anyone found a fix for this?

Here is the workaround I ended up with:
<script>
  function checkAndHideWatermark() {
      var widget = document.querySelector('#chainlit-copilot');
      var shadowRoot = widget && widget.shadowRoot;
      var watermarkDiv = shadowRoot && shadowRoot.querySelector('div.watermark');
      if (watermarkDiv) {
          watermarkDiv.style.display = 'none';
      }
      setTimeout(checkAndHideWatermark, 100);
  }
  checkAndHideWatermark();
</script>

Hi Hareesh,
Thanks for this. Did you add it into the chainlit custom js file or added it into the header where u embed the copilot?

Hi Hareesh,
Thanks for this. Did you add it into the chainlit custom js file or added it into the header where u embed the copilot?

It should be added in the html page where you are embedding the copilot.

At Chainlit 1.1.202 version, can try to use this way to remove watermark.
<script> 	function checkAndHideWatermark() { 		var widget = document.querySelector('#chainlit-copilot-popover'); 		watermarkDivs = widget && widget.querySelectorAll('.watermark') 		if (watermarkDivs && watermarkDivs.length > 0) { 			watermarkDiv = watermarkDivs[0] 			watermarkDiv.style.display = 'none'; 		} 		setTimeout(checkAndHideWatermark, 100); 	} 	checkAndHideWatermark(); </script>

@hareeshmu Can you please tell if you know a way to override css styles such as colours of font color for the copilot mode?


Added fuzzer

This PR adds a fuzzer.
Signed-off-by: Adam Korczynski<EMAIL_ADDRESS>

Without an explanation describing

what this does
what this is intended to fix
a lack of tests covering this feature
no documentation

I'm going ahead and closing this. In the future, please follow the process as described in CONTRIBUTING.md. Thanks.


KAFKA-9786 fix flaky MetricsTest.testGeneralBrokerTopicMetricsA…

java.lang.AssertionError: expected:<18> but was:<23>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
	at kafka.metrics.MetricsTest.testGeneralBrokerTopicMetricsAreGreedilyRegistered(MetricsTest.scala:108)

As gradle may use same JVM to run multiples test (see https://docs.gradle.org/current/dsl/org.gradle.api.tasks.testing.Test.html#org.gradle.api.tasks.testing.Test:forkEvery), the metrics from other tests can break MetricsTest.testGeneralBrokerTopicMetricsAreGreedilyRegistered.
  private def topicMetrics(topic: Option[String]): Set[String] = {
    val metricNames = KafkaYammerMetrics.defaultRegistry.allMetrics().keySet.asScala.map(_.getMBeanName)
    filterByTopicMetricRegex(metricNames, topic)
  }

MetricsTest.testGeneralBrokerTopicMetricsAreGreedilyRegistered is not captured by QA since the test which leaves orphan metrics in JVM is ReplicaManagerTest and it belongs to integrationTest. By contrast, MetricsTest is a part of unitTest. Hence, they are NOT executed by same JVM (since they are NOT in the same task). MetricsTest.testGeneralBrokerTopicMetricsAreGreedilyRegistered fails frequently on my jenkins because my jenkins verify kafka by running "./gradlew clean core:test".
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

retest this please


feature/hero-update

hi y'll the new design in the home has been for you.
watch that and tell me what you reckon.

quite the last title and put the new title with the button to go down
Also include
fixed the error about the title in title carrousel

index.js say you have conflict files.

Tienes conflictos.

all of the classes with hdlp don't really make sense, even if hdlp is hostal donde las paisas, these classes should be fine using words like logo, headline, text, etc... depending on each case.
==========
Todas las clases con hdlp no tienen mucho sentido, aun siendo que hdlp es hostal donde las paisas, todas estas clases deberian funcionar con palabras como logo, headline, text, etc... segun sea cada caso.

the buttons on the part of the carousel were on the contrary are, they were good before uploading this commit, please check that you moved


Update login.php

Since we we will be taking users name as an input to query our database we should also look at malicious risk .

Since we we will be taking users name as an input to query our database we should also look at malicious risk .

yes correct, I will look into it and update.


Not Professional Code 👎

Really Sorry to Said that but your work is not professional like you do the work to up the haps and do the work 👍

Thank you so much for the professional response kindly first learn it then comment it 😂😂😂😂


Link to an analysis or a view

Idea
Allow users to share a link to a specific analysis / selection / view

Yes, definitely need this in our roadmap. We eventually need to support an alert system which generates an email / message to a user that draws them into PRISM with a specific view

Since redux state is serialized, you might be able to export a snapshot of the state as base64 and pass it around as a link?

I was thinking something simpler. Rather than transferring the state, we should be able to link to an analysis by its parameters in the URL like this:
prim_url.org/analysis?hazard_layer=pasture_anomaly&statistic=mean&basline_layer=children&date=2020-05-21

While we are doing this, can we make this apply to views more broadly, and not just an analysis? I.e. also load a specified view based on URL parameters: prim_url.org/view?hazard_layer=pasture_anomaly&date=2020-05-21

Update 2021
Several PRs have attempted to solve this issue, but didn't follow the kind of pattern we were hoping for. You can view them here:

#103
#120

We hope to build an approach which is both scalable (as new fields get added, little to no extra work is needed to update this code) and also simple/modular (we could eventually extend this code to support new types of layers as they come).
Requirements:

The URL query is created dynamically - we shouldn't be hard coding the query like what is done here.

This can be done by storing the fields inside an object instead of in separate state fields. A single useState or useReducer - complex but might be worthwhile if you can think of a lot of actions to update from url, edit fields etc - should be used to store the whole field state.

The analysis dropdown opens if there is a valid query, with all fields filled in.
There is an error checker. Nothing advanced, but if there's something obviously wrong with the url we can create a notification with the notification state slice.

Tips:

I recommend useReducer since I envision many actions we can easily encapsulate such as urlToState, stateToUrl, updateField etc. However, until we put into practise we won't know if its really any better than a simple useState. It'll be up to you to experiment!
In the future, we'd like for these url queries to also open layers for us. For example, a user should be able to open a layer, select a date, copy the address field and share it so others can instantly jump to the same layer. Keep this in mind, since we need a solution that applies well in both cases (analysis UI and opening layers).
You could maybe use a library: https://github.com/pbeshai/use-query-params, but I haven't looked into whether it fits our use-case. If you see it working well for both cases mentioned above, maybe we can save some time and complexity by using it.

Bumping up in priority. This is something we need for meaningful alert messages

Addressed through https://github.com/WFP-VAM/prism-frontend/pull/255


Password escapes

Just to capture this as a possible docs fix or code fix:

passwords with a % in them are susceptible to a Golang parsing error, this is likely a bug in the ODB broker code or service adapter but I haven’t tracked it down yet, it might be also in Kubo-release itself but I haven’t confirmed.  Can be worked around with “%%” if the bug is triggered.  See https://github.com/cloudfoundry/bosh-cli/issues/330 for details

passwords with backslashes (“\”) for vsphere need to be escaped in one spot and not escaped in a different spot - see this PR https://github.com/cloudfoundry-incubator/kubo-release/pull/121 for one solution.

hey @svrc-pivotal,
Have you confirmed if the Kubo-Release is also subject to the behaviour you described? If so, can you please provide us with steps to reproduce?

Hi @glestaris , the vsphere one I think is being incorporated as my PR https://mail.google.com/mail/u/0/#search/kubo-release/15f875f657283f79
the double %% is only on the ODB, having to do with the way it generates manifests.   I can close this an file a ticket on that repo now that the vsphere permission issue is being fixed here.

Hey @svrc-pivotal, the link you posted above does not work for me... Seems like a link to Gmail?

@glestaris updated, too many tabs open ;)

thanks @svrc-pivotal. I scheduled the PR: https://www.pivotaltracker.com/story/show/151965138.

https://github.com/cloudfoundry-incubator/kubo-release/pull/121 is not merged. Closing this. Feel free to reopen if not done.


Added outer edge clipping

Outer edge clipping only affects slick with variable width on.
This new option outerEdgeLimit allows the last element of the slider to stop at its limit, instead of leaving empty space.

Thanks!

I noticed a bug.
When more than one item is visible and the outer edge has been reached, the next button should be disabled, but it stays visible.
Unfortunately I currently don't have time to fix it up. If someone would take a look at that it would be great.

Hi I have tried to solve the same issue using a different approach unfortunately I didn't check other pull requests before starting to write.
Look at this https://github.com/kenwheeler/slick/pull/2817 and tell me what you think about.
It seems your solution is more efficient, does it work fine?

@falkartis I haven't been able to test it a lot and still haven't fixed the bug I wrote about before.
From what I remember from the code, to fix the bug I need some small conditions here and there (mainly to enable and disable prev-next buttons), but never got around to do them.

Well, the prev-next buttons, my approach has the same issue. I'll write a
fix if my costumer asks me to.
El dc., 29 març, 2017 13:44, Ricardo Rodrigues<EMAIL_ADDRESS>va escriure:

@falkartis https://github.com/falkartis I haven't been able to test it
a lot and still haven't fixed the bug I wrote about before.
From what I remember from the code, to fix the bug I need some small
conditions here and there (mainly to enable and disable prev-next buttons),
but never got around to do them.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/pull/2635#issuecomment-290064832,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGUZCfRo-X7_wVAItYXNxDZ2h8ptTdRCks5rqkQUgaJpZM4K9-Os
.

@RicardoEPRodrigues Exactly what I need. Didn't found the fix for the next button yet. But I'll use this in my website.
Thanks !

Thank you!

I didn't test or check if this was the solution, and even if you already tried this, but, what if we call _.updateArrows(); after the calcs are made? Or just duplicate the code inside (I would prefer not :) )

@RicardoEPRodrigues after a quick test, i saw that this example fiddle with release didn't update the right arrow as well, so, maybe is not a problem with this patch itself.
Fiddle with this fix
But unfortunately, i tried the same example but with your patch, and i saw that the drag of the slide was flickering. so maybe we need to change the position of the track on other function so it doesn't become flickerish when dragged.

@kenwheeler @leggomuhgreggo is this going to be merged in base at some point?

Fixed for me the problem with the arrows:
my updateArrows function - added a new condition:
`Slick.prototype.updateArrows = function() {
    var _ = this,
        centerOffset;

    centerOffset = Math.floor(_.options.slidesToShow / 2);

    if ( _.options.arrows === true &&
        _.slideCount > _.options.slidesToShow &&
        !_.options.infinite ) {

        _.$prevArrow.removeClass('slick-disabled').attr('aria-disabled', 'false');
        _.$nextArrow.removeClass('slick-disabled').attr('aria-disabled', 'false');

        if (_.currentSlide === 0) {

            _.$prevArrow.addClass('slick-disabled').attr('aria-disabled', 'true');
            _.$nextArrow.removeClass('slick-disabled').attr('aria-disabled', 'false');

        } else if (_.currentSlide >= _.slideCount - _.options.slidesToShow && _.options.centerMode === false) {

            _.$nextArrow.addClass('slick-disabled').attr('aria-disabled', 'true');
            _.$prevArrow.removeClass('slick-disabled').attr('aria-disabled', 'false');

        } else if (_.currentSlide >= _.slideCount - 1 && _.options.centerMode === true) {

            _.$nextArrow.addClass('slick-disabled').attr('aria-disabled', 'true');
            _.$prevArrow.removeClass('slick-disabled').attr('aria-disabled', 'false');

        }

    }
    if ( _.options.arrows === true &&
        _.slideCount > _.options.slidesToShow &&
        !_.options.infinite && _.options.outerEdgeLimit){
        var lastSlide = _.$slides.last();
        var lastSlideOffsetRight = ($(window).width() - (lastSlide.offset().left + lastSlide.outerWidth()));

        if(lastSlideOffsetRight > -1) {
            _.$nextArrow.addClass('slick-disabled').attr('aria-disabled', 'true');
        }
        else {
            _.$nextArrow.removeClass('slick-disabled').attr('aria-disabled', 'true');
        }
    }

};`

my postSlide function - just added " _.updateArrows();":
`Slick.prototype.postSlide = function(index) {
    var _ = this;

    if( !_.unslicked ) {

        _.$slider.trigger('afterChange', [_, index]);
        _.updateArrows();

        _.animating = false;

        _.setPosition();

        _.swipeLeft = null;

        if ( _.options.autoplay ) {
            _.autoPlay();
        }

        if (_.options.accessibility === true) {
            _.initADA();
        }

    }

};`

Now you are able to apply styles to .slick-disabled or :not(.slick-disabled)

When I have time I'll update my branch.

Edited my post:
Added a relativity to the width of the slider

Updated to the most recent version of Slick and corrected bug where when more than one item is visible and the outer edge has been reached, the next button should be disabled, but it stays visible.
Thanks @sanchez089 ! :smile:

@RicardoEPRodrigues I rolled back with your new version I can't have more than one slide at the time. The variableWidth seems to not work anymore.

@groomain I tested the latest fixes and everything seems to work.
I don't seem to know what your problems are. Can you detail them a bit?

@sanchez089 thank you again! It works great!

@RicardoEPRodrigues I have a width 100% that is automatically added to all my slider :/

@groomain could you give me an example (.zip file or something) where I can test the bug?

Can we have this fix in the library, it works well!

Hey folks, I'm having this issue too and it would be really nice if this PR is merged to the library. Is there anything blocking it? Is it tests? Looking to help so we can have this available for everyone. Thanks!

@joaopslins I don't know why it still hasn't been merged. I created this fix and @sanchez089 contributed to "polish the edge", but still no comment or merge from the developers.

@RicardoEPRodrigues I see, I've copy pasted our code here to check if it solves my issue and it does! I just noticed 1 minor issue:

After load, the arrows don't appear at first, if I slide one item, they appear, and then can be used normally - only happens when outerEdgeLimit: true.

Just found another issue, it looks like there is a certain threshold where the last element does not fully appear, the next button appears, but it does not work when clicked. I'll try to work on a shareable example tomorrow.

@RicardoEPRodrigues Got the example for the threshold not working on the last element: http://jsfiddle.net/yfvp78xr/19/
The last item does not show fully, the button appears but does not work. Probably your screen resolution can affect this repro but I got this on 1920x1080 and 1366x768 resolutions.
About the arrows not appearing when opening the page, I couldn't reproduce on the fiddle. By debugging, I can see that when the updateArrows() function is called, the calculation is getting the wrong value. In this case, _.$slider.outerWidth() is reading 40000px.

Because of that, the last arrow is set as disabled. The slick-track element has the inline style setting width: 40000px. But the example on the fiddleJS also has the inline width: 30000px but the function reads the correct value. I have no clue why it's reading that value.

Managed to solve the hidden arrow issue by calling updateArrows() after the .slick() call, not ideal but works for me.

@RicardoEPRodrigues about the threshold bug I've posted here earlier, I noticed it works as expected if I comment this on line 1232:
            // [...]
            var slideOuterWidth, slideOffset, slideRightBoundary;
            slideOuterWidth = $(slide).outerWidth();
            slideOffset = slide.offsetLeft;
            /* if (_.options.centerMode !== true) {
                slideOffset += (slideOuterWidth / 2);
            } */

            slideRightBoundary = slideOffset + (slideOuterWidth);
            // [...]

Could you explain what was the motivation of this condition? For me it only works if I remove this piece of code.

I took some time a fixed 2 or 3 bugs.
Basically I restricted outerEdgeLimit for when centerMode is off, which was creating some issues.
:clap: :clap: Next Bug
I removed the code referenced by @joaopslins https://github.com/kenwheeler/slick/pull/2635#issuecomment-463408945, thank you! :tada:
:clap: :clap: Next Bug
I also fixed an annoying bug when the last element has width greater than the window, this would allow the arrows to remain active, which is now fixed! :smile:
Try the fixes here: http://jsfiddle.net/RicardoEPRodrigues/284ruc1d/ . Mess around with the widths to test it out.

Nice! Thanks for these changes! The center mode really doesn't make much sense with this new option on so the restriction is good.
Just a heads up, I think the jsfiddle you posted didn't include the latest changes, I've pasted the code on the previous fiddle. Here is an updated version: http://jsfiddle.net/bcgLaj46/

Hey, I just wanted to comment on the lack of updates in the master branch of the Slick. It does appear to be dead or inactive. There are 865 open issues and 169 pull requests dating back to 2014.
Those doing Pull Requests are the ones keeping this alive. Thank you everyone!

Hello again folks,
Got another issue when I used a slidesToScroll option greater than 1.
Steps to reproduce:

This fiddle is the same as the previous one, but with slidesToScroll: 2 setting: http://jsfiddle.net/muh1yka9/
Go to the last slide
Then go to the first one, except you'll notice it stops on Slide 2, the arrow appears, but once clicked no action is performed.

I managed to get this working by adding a new condition on the method slideHandler :
if (_.options.outerEdgeLimit && _.options.centerMode === false) {
    outerEdgeSlideNumber = _.getOuterEdgeSlideNumber();

    if (outerEdgeSlideNumber < index) {
        index = outerEdgeSlideNumber
    }

    if (index < 0) { // new condition
      index = 0;
    }
}

Fiddle with this fix: http://jsfiddle.net/j3dt5suv/3/
I'm not sure if more checks are needed elsewhere but this worked for me, what do you think @RicardoEPRodrigues ?

@joaopslins Hello! On future improvements I invite you to do pull requests on my branch, this way we can workout the kinks more easily :smile:
Ok, some notes here:

On main master branch (not my branch), infinite:true + slidesToScroll: 2 breaks the roll. You can test it out on our previous fiddle (http://jsfiddle.net/bcgLaj46/). Could someone confirm the bug? I believe there are already issues posted (https://github.com/kenwheeler/slick/issues/3526 and https://github.com/kenwheeler/slick/issues/3517).

We should ignore outerEdgeLimit: true if infinite: true.

@joaopslins, I'll incorporate your changes in my next commit, thank you!

It turns out that the index bug is from Slick, not from the outerEdgeLimit option, the option basically allows a scenario for the bug to appear.
New fiddle available: https://jsfiddle.net/RicardoEPRodrigues/284ruc1d/
Please comment and report more bugs.

@RicardoEPRodrigues
I'm trying to use this update in one of my sites but it seems to be breaking my slider. The fiddle you provided (https://jsfiddle.net/RicardoEPRodrigues/284ruc1d/) also doesn't seem to be working?
Maybe I'm missing something here?

For some reason it looks like jsfiddle is broken. Not even the default jsfiddle works (this one).
@k-cogswell I'm using this PR code and it is working well. It will be hard to help you without the jsfiddle working though.

I am looking for this PR to be merged. Please let me know if this can be merged ?

How do you do this without changing the slick.js? Please let me know

The PR is not yet merged by the SlickJS team yet. We cant accomplish this
without changing the slickjs library code.
Thanks,
Sindu
On Thu, Dec 19, 2019 at 12:00 PM shielakn<EMAIL_ADDRESS>wrote:

How do you do this without changing the slick.js? Please let me know
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/kenwheeler/slick/pull/2635?email_source=notifications&email_token=AEYP3YS54M6USVVJHSTAIWLQZOZFRA5CNFSM4CXX4OWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHKNTFA#issuecomment-567597460,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYP3YV7BUNS6FTMYJNAFZDQZOZFRANCNFSM4CXX4OWA
.

Unfortunately this fix doesn't work properly.
Or if you click the next arrow and the slides are at the end, then you won't be able to click prev button, until you click the same amount of times, you clicked the next button.

Hey, @tylik1 can you show us the changes in a jsfiddle? So we can try them out and correct the code.
If you'd like you can make a pull request with the changes on my repository! :smile:

Hey, @tylik1 can you show us the changes in a jsfiddle? So we can try them out and correct the code.
If you'd like you can make a pull request with the changes on my repository! 😄

I've implemented this, more like a hack. I'm calculating the width of the slider container, then counting number of slides, that fits that container, to pouplate slidesToShow. Sorry, don't have much time to create a fiddle, but will post some code here, hopefully it will becme a bit clear.
function sliderMenu() {
//Slick container
var $sliderMenu = $('.js_object_detail-nav__items');
    //Slick container width
    var sliderMenuWidth = $sliderMenu.width();

    //Calculated total width of slides
    var sliderMenuChildrenWidth = 0;

    //Amount of slides fitting in a visible area
    var sliderMenuChildLastVisibleIndex = 0;

    $sliderMenu.children('.object-detail-nav__item').each(function (ind) {
       //Loop through each slide and add its width to a variable
        sliderMenuChildrenWidth += $(this).width()

       // If slider container element width is bigger then calculated slides width, then increment visible index of slides
        if (sliderMenuWidth > sliderMenuChildrenWidth) {
            sliderMenuChildLastVisibleIndex += 1
        }
    });

        $sliderMenu.slick({
            slidesToShow: sliderMenuChildLastVisibleIndex,
            slidesToScroll: sliderMenuChildLastVisibleIndex,
            infinite: false,
            variableWidth: true
        });
}

The swipeToSlide option becomes unstable. Here is a demo.

Hey @RicardoEPRodrigues
I have added Version: 1.9.0 in my project it is working good
White spacing issues solved and it is working properly but I have seen the new issue is that when I use the
variableWidth: true,
infinite: false,
outerEdgeLimit: true,
slider next arrow not disable on last slide.

Slick Slider
$('.items').slick({     infinite: false,     slidesToShow: 1,     variableWidth: true,     centerMode: true,     centerPadding: '0',     outerEdgeLimit: true, });
OR
$('.items').slick({     infinite: false,     slidesToShow: 1,     variableWidth: true,     outerEdgeLimit: true, });

I have one weird issue.
Without this fix, I have empty whitespace at the end of variableWidth slick slider:

With this plugin, I don't have it on one slider, but the other slider cannot be scrolled at all.


JsonType fails for Map types without generic types

When a field which is mapped to json type, is assigned a value of a custom map type, which doesnt have generic types
Trying to save the entity will fail with below error.
Caused by: java.lang.IllegalArgumentException: Cannot create TypeBindings for class org.grails.web.json.JSONObject with 2 type parameters: class expects 0
        at com.fasterxml.jackson.databind.type.TypeBindings.create(TypeBindings.java:139)
        at com.fasterxml.jackson.databind.type.TypeBindings.create(TypeBindings.java:98)
        at com.fasterxml.jackson.databind.type.TypeFactory.constructParametricType(TypeFactory.java:1008)
        at com.fasterxml.jackson.databind.type.TypeFactory.constructParametricType(TypeFactory.java:977)
        at io.hypersistence.utils.hibernate.type.util.ObjectMapperJsonSerializer.clone(ObjectMapperJsonSerializer.java:40)
        at io.hypersistence.utils.hibernate.type.util.ObjectMapperWrapper.clone(ObjectMapperWrapper.java:145)
        at io.hypersistence.utils.hibernate.type.json.internal.JsonTypeDescriptor$1.deepCopyNotNull(JsonTypeDescriptor.java:54)
        at org.hibernate.type.descriptor.java.MutableMutabilityPlan.deepCopy(MutableMutabilityPlan.java:35)
        at org.hibernate.type.AbstractStandardBasicType.deepCopy(AbstractStandardBasicType.java:308)
        at org.hibernate.type.AbstractStandardBasicType.deepCopy(AbstractStandardBasicType.java:304)
        at org.hibernate.type.TypeHelper.deepCopy(TypeHelper.java:55)

I am using JsonType with Grails. One of the field  of type Map in my entity class is mapped to JsonType Every thing works fine during tests and when a HashMap or LinkedHashMap etc are assigned
However, when a custom implementation of Map - eg Grails JSON Object which implents map (but does not have generic types) is assigned to the field. Trying to save the object would fail with above error.
The problem is with ObjectMapperSerializer which fails if the Map implementation does not have Generic types
Here's the problamatic code
I am on Hibernate 5.4 version of the hypersistance-utils

@snimavat Try to debug it and investigate what causes the issue and how it could be prevented.
Once you have a replicating test case and a fix proposal, send me a Pull Request so that I can review it. Looking forward to your contribution.

I will reproduce it in tests of this project itself.

You can try with a non-generic Map or a class that extends one such Map.

Closed as no Pull Request was provided to replicate the issue.


[SPARK-7664][WebUI] DAG visualization: Fix incorrect link paths of DAG.

In JobPage, we can jump a StagePage when we click corresponding box of DAG viz but the link path is incorrect.
When we click a box like as follows ...

We jump to index page.

/cc @andrewor14

Merged build triggered.

Merged build started.

Test build #32814 has started for   PR 6184 at commit faba3ba.

Test build #32814 has finished for   PR 6184 at commit faba3ba.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32814/
Test PASSed.

Other than the typo this LGTM. I'm merging this into master 1.4 thanks @sarutak for testing this out. By the way I'm changing much of this code in my other patch #6171 so I will likely update my changes there based on this.


maxvalue for time

What's the max value for put? I put in 30 days in ms,<PHONE_NUMBER>, and i only got cache misses.

2147483647.
http://stackoverflow.com/questions/3468607/why-does-settimeout-break-for-large-millisecond-delay-values

Thanks :)


Update chart readme's

Adding more details to each of the helm chart Readme files using helm-docs tool.
Denis Neuling<EMAIL_ADDRESS>Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

@florianrusch-zf, sufficient as it is?


PTA extending forest trust information

It's important that we mention the requirement of two-way trust, because customers need this information to be able to configure their environment properly.

@githubarpyka : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Fix react15 warning about unknown props

Links

Upgrading to React 15.2.0 throws "unknown props" warning
react-unknown-prop.md

Problem
"The unknown-prop warning will fire if you attempt to render a DOM element with a prop that is not recognized by React as a legal DOM attribute/property." In this case, since @props are passed as-is to the child div using ..., the div ends up with invalid html properties.
Solution
Coffeescript doesn't seem to have support for the succinct solution:
const { layout, ...rest } = props;
return <div {...rest} />

So I used Object.assign for making a copy of props and then removing the unwanted keys.
Test plan
I built the project by:

Running npm install
Installing webpack globally
Installing React locally (perhaps consider including it in peerDependencies)
Running make build

And tested it in my project using npm link. It stopped showing the warning!

Hi, @KyleAMathews ! Just wanted to ping you 😄

This is great! Thanks @jairtrejo! Just reviewed and will now merge and create a new release.


Command 'vvm' not found after pip install vvm

Environment information

vvm Version: 0.0.1
Python Version: 3.6.15
OS: linux

What was wrong?
Command 'vvm' not found after pip install vvm
(env) nikos@EC2AMAZ-7DD6R45:/mnt/c/Snapshot/dev/awesome/uniswap-v1/contracts$ pip install vvm
Requirement already satisfied: vvm in /home/nikos/.pyenv/versions/3.6.15/envs/env/lib/python3.6/site-packages (0.1.0)
Requirement already satisfied: semantic-version<3,>=2.8.1 in /home/nikos/.pyenv/versions/3.6.15/envs/env/lib/python3.6/site-packages (from vvm) (2.8.5)
Requirement already satisfied: requests<3,>=2.19.0 in /home/nikos/.pyenv/versions/3.6.15/envs/env/lib/python3.6/site-packages (from vvm) (2.26.0)
Requirement already satisfied: idna<4,>=2.5; python_version >= "3" in /home/nikos/.pyenv/versions/3.6.15/envs/env/lib/python3.6/site-packages (from requests<3,>=2.19.0->vvm) (3.3)
Requirement already satisfied: charset-normalizer~=2.0.0; python_version >= "3" in /home/nikos/.pyenv/versions/3.6.15/envs/env/lib/python3.6/site-packages (from requests<3,>=2.19.0->vvm) (2.0.9)
Requirement already satisfied: urllib3<1.27,>=1.21.1 in /home/nikos/.pyenv/versions/3.6.15/envs/env/lib/python3.6/site-packages (from requests<3,>=2.19.0->vvm) (1.26.7)
Requirement already satisfied: certifi>=2017.4.17 in /home/nikos/.pyenv/versions/3.6.15/envs/env/lib/python3.6/site-packages (from requests<3,>=2.19.0->vvm) (2021.10.8)
You are using pip version 18.1, however version 21.3.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
(env) nikos@EC2AMAZ-7DD6R45:/mnt/c/Snapshot/dev/awesome/uniswap-v1/contracts$ vvm

Command 'vvm' not found, did you mean:

  command 'kvm' from deb qemu-kvm (1:4.2-3ubuntu6.18)
  command 'pvm' from deb pvm (3.4.6-2build2)
  command 'vvp' from deb iverilog (10.3-1build1)
  command 'vam' from deb vim-addon-manager (0.5.10)
  command 'lvm' from deb lvm2 (2.03.07-1ubuntu1)
  command 'vwm' from deb vmware-manager (0.2.0-3)
  command 'vim' from deb vim (2:8.1.2269-1ubuntu5.4)
  command 'vim' from deb vim-tiny (2:8.1.2269-1ubuntu5.4)
  command 'vim' from deb vim-athena (2:8.1.2269-1ubuntu5.4)
  command 'vim' from deb vim-gtk3 (2:8.1.2269-1ubuntu5.4)
  command 'vim' from deb vim-nox (2:8.1.2269-1ubuntu5.4)
  command 'vim' from deb neovim (0.4.3-3)
  command 'vym' from deb vym (2.6.11-3build1)
  command 'vm' from deb mgetty-voice (1.2.1-1)
  command 'vrm' from deb atfs (1.4pl6-14)

Try: sudo apt install <deb name>

/cc @klimisa

This library does not have an entry point, it can only be used by importing it within a python script.

Thank you. Can you provide some basic example? I'm not that much into Python yet...

Only reason I'm asking is because you mention pip install in the README... And there's really no other usage scenario show anywhere. If you can point to some other projects on GitHub using vvm (e.g. perhaps Curve.fi?) then that'd be enough.

vvm is near-identical in usage to solcx, the documentation for that might prove useful: https://solcx.readthedocs.io/en/latest/index.html
You could also check the brownie source code, it's in use there

Thank you! (Also, thank you for solcx which I wasn't aware of it.)


Get avoid snapshot interval calculate int overflow

Motivation
When the user uses Integer.MAX_VALUE as keepNSnapshots, it will touch integer overflow, and persistence will never delete those events.
This change will not change anything besides avoid overflow, because the persistence actor version already designed as a long type.
This screenshot was  happened in the real world:

@Roiocam  just saw this in production @pjfanning

@Roiocam Would you like to cherry pick this to 1.0.x ? Thanks.

@Roiocam Probably hard to test but could you consider if it's possible?

Yes, the reproduction can be implemented on persistence-plugin, I will pick it up and check it out if any possible to implement on pekko-persistence

There is no need to write a plugin for just test this...

There is no need to write a plugin for just test this...

I mean verified in such as  pekko-persistence-jdbc


Code's  structure changed after converted

I have a  cjs module, and import in rollup project, however after converted, I found my code can not run  anymore, after I check the code, I found my code's structure has totally change,
it change into some code like these:
var unWrapModule = unwrapExports(nativeModule);
var finallyObj = Object.freeze({
	default: unWrapModule,
	__moduleExports: nativeModule
});

and the finallyObj runs with many errors, cause  nativeModule's functions can not be accessed.
and Object freeze is not what I expected.

https://gist.github.com/Rich-Harris/88c5fc2ac6dc941b22e7996af05d70ff

No repro, closing


Enabling dictionary override optimization on the segment reload path

Problem:  The decision to override dictionary config in the segment generation path  (indexConfig options -> optimizeDictionaryForMetrics, optimizeDictionary) gets reverted in the segment reload path. This was not handled in the reload path (a regression?).
These override options (optimizeDictionaryForMetrics, optimizeDictionary) were added as a safeguard to prevent issues when dictionary can cause more harm than good.
Solution: Factored out common logic that'll be shared between segment generation and reload path. This ensures that segment generation and reload use the same logic to take the decision to override.
Tests:

Added unit tests for core logic that makes the override decision
Quickstart run to verify that dictionary -> noDictionary happens after segment reload

@somandal , @KKcorps - I took a stab at this. Please review.
cc @snleee

Codecov Report

Merging #10557 (22d6482) into master (513fa31) will decrease coverage by 53.98%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #10557       +/-   ##
=============================================
- Coverage     67.84%   13.86%   -53.98%
+ Complexity     6001      439     -5562
=============================================
  Files          1575     2049      +474
  Lines         81930   110298    +28368
  Branches      12870    16685     +3815
=============================================
- Hits          55586    15296    -40290
- Misses        22450    93754    +71304
+ Partials       3894     1248     -2646

Flag
Coverage Δ

unittests1
?

unittests2
13.86% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ment/creator/impl/SegmentColumnarIndexCreator.java
0.00% <0.00%> (-84.94%)
:arrow_down:

.../segment/index/dictionary/DictionaryIndexType.java
0.00% <0.00%> (-93.62%)
:arrow_down:

...ocal/segment/index/loader/ForwardIndexHandler.java
0.00% <0.00%> (-82.68%)
:arrow_down:

...ot/segment/spi/creator/SegmentGeneratorConfig.java
0.00% <0.00%> (-80.66%)
:arrow_down:

.../apache/pinot/spi/config/table/IndexingConfig.java
0.00% <0.00%> (-95.51%)
:arrow_down:

... and 1870 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks for your contribution! mostly looks good but have a few comments. Please take a look at the integration test failure as well to see if it's related to this change.

The integration test passes when I run locally (intellij). I'll rerun them here.


Retry uploads on failure

Coverage remained the same at 100.0% when pulling cf0c3369066733d712dd5dcb7908a00ba3817372 on retry-uploads into 365ccb43bb31e96e215ca430bf98eac01d471cbb on master.


setting release

@rultor merge

@rultor merge

@andrey-vasilyev OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@andrey-vasilyev Done! FYI, the full log is here (took me 3min)


issues#110 - Popovers with same id in Coral.Actionbar.

Description -
These changes fix the id duplication of popover when an action is moved to/from more popover.

Related Issue
https://github.com/adobe/coral-spectrum/issues/110

Motivation and Context  -->
These changes fix the id duplication of popover when an action is moved to/from more popover.

How Has This Been Tested?  -->
Manually

Screenshots (if appropriate):
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.

Does the last example "With action menu" from Action Bar still work ? Can you open the popover ?

        <coral-actionbar id="switchBar1">
          <coral-actionbar-item>
            <button is="coral-button" variant="quiet" icon="copy">Copy</button>
          </coral-actionbar-item>
          <coral-actionbar-item>
            <button is="coral-button" variant="quiet" icon="globe">Publish</button>
          </coral-actionbar-item>
          <coral-actionbar-item>
            <button is="coral-button" variant="quiet" icon="globeRemove">Unpublish</button>
          </coral-actionbar-item>
          <coral-actionbar-item>
            <button class="popover-button" is="coral-button" icon="search" title="Delete">Open Popover</button>
            <coral-popover target=".popover-button" placement="bottom">
              <coral-buttonlist>
                <button is="coral-buttonlist-item" icon="add">Add</button>
                <button is="coral-buttonlist-item" icon="move">Move</button>
                <button is="coral-buttonlist-item" disabled="">Delete</button>
              </coral-buttonlist>
            </coral-popover>
          </coral-actionbar-item>
          <coral-actionbar-item>
            <button is="coral-button" variant="quiet" icon="copy">Copy</button>
          </coral-actionbar-item>
          <coral-actionbar-item>
            <button is="coral-button" variant="quiet" icon="globe">Publish</button>
          </coral-actionbar-item>
          <coral-actionbar-item>
            <button is="coral-button" variant="quiet" icon="globeRemove">Unpublish</button>
          </coral-actionbar-item>
        </coral-actionbar>

@icaraps  >Does the last example "With action menu" from Action Bar still work ? Can you open the popover ?
How can check that? I mean how can I run the examples with my changes?

You can do cd coral-component-actionbar && gulp then open localhost:9001

@icaraps  >Does the last example "With action menu" from Action Bar still work ? Can you open the popover ?
Yes and No.
Yes, in normal scenario when the action is visible in the list.
No, in scenario when the action is not visible and becomes visible in more popover. But this is is the case without the changes in this PR. let me fix that as well.
Thanks for reviewing.

@icaraps  Fixed the target issue.
The last example now works fine for both the cases.

When popover button is inside more popover.
When it is outside more popover.

Could you please help in reviewing...

@icaraps  Gentle reminder.


run failed

Dear all,
while I certainly appreciate appreciate your efforts to produce new and interesting tools, I have a hard time to get them to run. This, of course, is mainly due to my inexperience with the necessary computational tools. Howver, it would be really nice, if the provide installation tools would work "out of the box".
I have tried to install synapse-net as described, got no errors, could open Napari, but from there on things got awry. The attached file is the out put I get when opening a 2D-EM image and tried to run the segmentation plugin.
Hope that at some stage the tool reaches a state where it can be applied by dummies like me, or comes as a Windows- executable, although I fear that developers strive for more and better tools, which of course is laudable, but excluded the broader community to benefit.
Wish you all a happy new year and all the best for 2025.
Matthias
Successfully built synapse_net.txt

Thank you for the feedback. First to address the general point, as we state in https://computational-cell-analytics.github.io/synapse-net/synapse_net.html , we haven't fully tested this tool on Windows, which is a very difficult operating system to develop for, and in my opinion should be avoided in research relying on computational tools.
Please also be aware that SynapseNet requires a GPU for application to 3D volumes, and that GPU support on Windows is not tested and very hard to support.
For the specific issue: we know now what causes this issue and I have updated the installation instructions in https://computational-cell-analytics.github.io/synapse-net/synapse_net.html to include windows specific instructions (it needs a different environment file). It should also be possible to fix this in an existing environment by running conda install -c conda-forge "nifty=1.2.1=*_4".

Dear Constantin, thanks for your answer.
Of course you are right. However, some of us potential users grew up in a
Windows world and did not quite made the transition ;-)
In any case, do you think operating under WSL would make things easier?
Thanks and all the best for 2025.
Matthias
Constantin Pape @.***> schrieb am Mo., 30. Dez. 2024,
11:49:

Thank you for the feedback. First to address the general point, as we
state in
https://computational-cell-analytics.github.io/synapse-net/synapse_net.html
, we haven't fully tested this tool on Windows, which is a very difficult
operating system to develop for, and in my opinion should be avoided in
research relying on computational tools.
Please also be aware that SynapseNet requires a GPU for application to 3D
volumes, and that GPU support on Windows is not tested and very hard to
support.
For the specific issue: we know now what causes this issue and I have
updated the installation instructions in
https://computational-cell-analytics.github.io/synapse-net/synapse_net.html
to include windows specific instructions (it needs a different environment
file). It should also be possible to fix this in an existing environment by
running conda install -c conda-forge "nifty=1.2.1=*_4".
—
Reply to this email directly, view it on GitHub
https://github.com/computational-cell-analytics/synapse-net/issues/90#issuecomment-2565316572,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AILKPUDNVWRB4TFAWCKTJKD2IEQMXAVCNFSM6AAAAABUK7YR4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRVGMYTMNJXGI
.
You are receiving this because you authored the thread.Message ID:
@.***>


[Dependency Scanning] Make dependency scanner cache specific to a given target triple.

In order to do so, first refactor the dependency kinds to model the main modules of individual scanning actions as separate dependency kind: SwiftSource. These kinds of modules differ from SwiftTextual modules in that they do not have an interface and have source-files. It is cleaner to enforce this distinction with types, instead of checking for interface optionality everywhere, as we did prior to this change.
Then, make GlobalModuleDependenciesCache aware of the current scanning action's target triple and only resolve cached dependencies that came from scanning actions with the same target triple.
This change means that the GlobalModuleDependenciesCache must be configured with a specific target triple for every scanning action, and it will only resolve previously-found dependencies from previous scannig actions using the exact same triple only.
Furthermore, the GlobalModuleDependenciesCache now separately tracks source-file-based module dependencies as those represent main Swift modules of previous scanning actions, and we must be able to resolve those regardless of the target triple.
This change is largely required due to the introduction of the -clang-target optimization which means that the driver is no longer re-scanning Clang modules against different target sets in a given module's build graph.
Resolves rdar://83105455

Existing scanner tests ensure we do not regress on current functionality.
Cross-triple test will be added in the swift-driver repository.

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 36cfa4964619c83384a6ad06db27d055693f4130

@swift-ci please test

@swift-ci please test


STAGE 2: Proposal - Please remove automated message 'Your application has been reviewed and the outcome is: Approved'

When the proposal PM sends the determination from within WebApp, it triggers an automated email notification to the applicant: “Your application has been reviewed and the outcome is: Approved.”
Please remove 'Your application has been reviewed and the outcome is: Approved' as an automated message.
Dear Jane Doe,

Please review our Proposal Guide (https://guide.opentech.fund/appendix-ii-proposal-guide) to learn more about the information we’d like to see. In the proposal please also address the feedback we provided in the concept note determination.

Here is the link to create your proposal: [proposal submission link]

The system will allow you to save a draft of your Proposal as you work on it. When you feel it is ready for OTF to review, please click the “Submit” button. We’ll reply to you with feedback as quickly as possible.

Please submit any questions related to your Proposal here [link to the communications tab of their application].  Please do not reply to this email with questions related to your Proposal.

If you have issues accessing the submission system or general inquiries, please email us (hello@opentech.fund).

Kind regards,
OTF

Current Message:

Why does OTF not want to send out the Determination e-mail? Are you doing it manually?

Invite for proposal template:
{% extends "messages/email/applicant_base.html" %}
{% load i18n %}
{% block content %}{% blocktrans %}We’ve reviewed your Concept note and think it could be a good fit for {{ ORG_SHORT_NAME }} funding. We would like to invite you to submit a Proposal with more details about your project. You will receive a second email linking to a determination message with detailed feedback.{% endblocktrans %}
{% blocktrans %}Please review our Proposal Guide at {{ ORG_GUIDE_URL }} to learn more about the information we’d like to see. In the proposal please also address the feedback we provided in the concept note determination.{% endblocktrans %}{% endblock %}
{% block more_info %}{% trans "Here is the link to start creating your proposal" %}: {{ request.scheme }}://{{ request.get_host }}{{ source.get_absolute_url }}
{% trans "If you have any questions, please submit them here" %}: {{ request.scheme }}://{{ request.get_host }}{{ source.get_absolute_url }}#communications
{% blocktrans %}The system will allow you to save a draft of your proposal as you work on it. When you feel it is ready for our review, please click the “Submit” button and we’ll know to take a look at it. We’ll reply to you with feedback on your Proposal as quickly as possible.{% endblocktrans %}
{% blocktrans %}If you have any issues accessing the submission system or other general inquiries, please email us at {{ ORG_EMAIL }}{% endblocktrans %}{% endblock %}

Determination template:
{% extends "messages/email/applicant_base.html" %}
{% load bleach_tags i18n %}
{% block content %}{% trans "Your application has been reviewed and the outcome is" %}: {{ determination.clean_outcome }}
{{ determination.message|bleach|striptags }}
{% trans "Read the full determination here" %}: {{ request.scheme }}://{{ request.get_host }}{{ determination.get_absolute_url }}{% endblock %}


fix: pass domain/project name to ddev sequelace, fixes #5394

The Issue
Fixes #5394. The domain name is sent to SequelAce instead of <IP_ADDRESS>, which means that it shows in the SequelAce window title.
See #5397 however -- this was the only env var I could see which was suitable, but the docs for it are suspicious. An array here would clearly be wrong.
Manual Testing Instructions
Do ddev sequelace. The new SequelAce window should show the domain, allowing the project to be identified.
Automated Testing Overview

Related Issue Link(s)
Release/Deployment Notes

Thanks for all the good work on this!


[Spanner] feat: Add SpannerDate struct

The Spanner client library currently uses datetime as the default type for both TIMESTAMP and DATE columns. That produces some challenges:

Setting a datetime value on a SpannerParameter without explicitly also setting the DbType or SpannerDbType, will always create a SpannerParameter with type TIMESTAMP. This makes it difficult to make a good default mapping for generic frameworks that only set a value and not a specific type for a parameter (e.g. Entity Framework).
datetime values always contain a time component and a kind (local, UTC, unspecified). This indicates that the datetime represents a specific moment in time, while a DATE value in Cloud Spanner explicitly does not do so.

Having a SpannerDate struct similar to the SpannerNumeric struct would mitigate the above problems. We should consider adding that to the client library and use that as the default type for DATE columns.

(Sorry for the double report, GitHub gave a 404 on the first submit)

(Sorry for the double report, GitHub gave a 404 on the first submit)


Fix quantization error during generation resulting in crashes.

I didn't mean to do it in this PR, but I am about to push a new version, so might as well.

Will this PR make quantization less accurate?  It seems that it reduces the duration of all the notes by one step.

This shouldn't affect the duration of individual notes, but the start/end times of generated sequences.  Are you observing any difference in note durations?

Oh my bad.


add test suffix to test cases

Some test cases don't run because the way phpunit is configured, it's looking for test classes with the suffix of Test. This PR just adds those suffixes.

Thanks @dallincoons !


Request for clarification about rsa-x509-pub

What is the expected payload for rsa-x509-pub "RSA public key (X.509 encoded)" (#226)?
Is it...

DER-encoded  RSAPublicKey from RFC 3447 (PKCS #1)
DER-encoded SubjectPublicKeyInfo from RFC 2459 / RFC 5280
DER-encoded Certificate (X.509 v3 certificate) from RFC 2459 / RFC 5280
Hash of DER-encoded Certificate, like for the value of a x5t (X.509 Certificate SHA-1 Thumbprint)
or x5t#S256 (X.509 Certificate SHA-256 Thumbprint) JOSE Parameter (RFC 7517 / RFC 7515) - without the base64url encoding?
Something else?

@rvagg @expede @b5

My expectation when filing for the codec was your second option: x509 PKIX, ASN.1 DER form.  The encoded public key is a SubjectPublicKeyInfo structure RFC 5280, Section 4.1.
https://pkg.go.dev/crypto/x509#MarshalPKIXPublicKey
This is to match the "raw" output of the libp2p.crypto library, which attempts to normalize asymmetric key handling.
here's a sample deserializing a did:key identifier encoded using this multicodec: https://github.com/qri-io/ucan/blob/a725af2c2ab328d4179f3ee763688939622a3d8d/didkey/key.go#L83-L97

It's a very good question @clehner. I'll file a PR clarifying in the codec table.

Thanks @b5. I would close this issue if such a PR were merged; and/or if @rvagg and/or @expede can confirm this usage.

Are we able to differentiate between all of these variants by inspecting the bytes and doing a set of try-parse operations on the data? Or do we need multicodec to do all of that differentiation work if we wanted to support other variants?

and/or @expede can confirm this usage.

@clehner thanks for asking! Pretty much what @b5 said above. The previous PR came out of @b5's and my project trying to have interoperable DIDs. I don't care so much about which format as that we're using the same one. Which is the long way of saying: confirmed, and we should have been more specific before!

differentiation work if we wanted to support other variants?

@b5 and I discussed this earlier in the process. There's even more ways than those listed above for representing RSA keys, these are just the X509 variants (and yes, we should be crystal clear on which one the multiformat refers to). There's quite a few libraries for converting between various formats.
We were mainly going for ease-of-use for our use case: DIDs (compact) and libp2p. It's true that this isn't necessarily what everyone else needs. There's an open question about how many variants we should have for RSA, because there's a lot of permutations of encoding, certificates headers, key lengths, and so on. I'm certainly not against adding more, but from a practical standpoint it may make sense to add them on a by-need basis.
I fully agree with @clehner that we should be crystal clear on which one this multiformat refers to. @b5 or I will have a PR for that shortly.
As an aside: it would also be nice to have test fixtures to go along with the formats

Thanks @expede.
+1 for test vectors.
@rvagg these particular DER-encoded data structures can be distinguished by their structure.
e.g. (pseudo-code): RSAPublicKey is sequence(integer, integer), while
SubjectPublicKeyInfo is sequence(sequence(OID, something), bitstring).
So if the entry were changed from SubjectPublicKeyInfo to RSAPublicKey, backwards compatibility would be possible. I'm not sure about for the hash types - I think those are opaque except for the length.
A multicodec entry for an arbitrary DER value could be useful. But it is useful to associate DER data with a type, because while ASN.1/DER can represent arbitrary data structures, it has a limited set of types, and so relies on either external type definitions or using OIDs (object identifiers) within the data structure. ASN.1 in this way could perhaps be seen as somewhat analogous to JSON (and DER to JCS).
rsa-x509-pub as SubjectPublicKeyInfo, however, I think may be more complex than necessary. SubjectPublicKeyInfo is analogous to JWK: it can represent multiple types of keys (algorithms). Indeed, in WebCrypto we can see spki (DER encoding of SubjectPublicKeyInfo) and JWK as alternative key formats:
https://w3c.github.io/webcrypto/#dom-keyformat-spki
A spki entry in multicodec might be useful, to encode arbitrary SubjectPublicKeyInfo values.
But for did:key, we already use multicodec to determine the type of the key, so SubjectPublicKeyInfo may be redundant. Therefore, I think an entry using RSAPublicKey (DER-encoded) might make more sense. This would improve the compactness of the key representation: With RSA public key in SubjectPublicKeyInfo, you have a RSAPublicKey value embedded in the SubjectPublicKeyInfo value. The RSAPublicKey could be used instead without the surrounding algorithm identifier and optional parameters of SubjectPublicKeyInfo. This would also simplify/clarify implementation, i.e. what to do when parsing an expected RSA SubjectPublicKeyInfo if the algorithm is not rsaEncryption, but is for example, sha256WithRSAEncryption. In WebCrypto, there is a table showing the different Algorithm OIDs that can be used with SubjectPublicKeyInfo embedding a RSAPublicKey:
https://w3c.github.io/webcrypto/#spki-mapping
We can see some more listed in RFC 3447 (PKCS #1):
https://datatracker.ietf.org/doc/html/rfc3447#page-57
For some of these algorithm types, it might be possible to construct a sensible DID document using corresponding JWK algorithms.
But if using JsonWebSignature2020, I think it is expected that the key does not include an algorithm parameter, but specific algorithms are allowed by the suite, e.g. PS256 for signatures from an RSA key. As for the key length, JsonWebSignature2020 says 2048 - the minimum length in JWK (e.g. https://datatracker.ietf.org/doc/html/rfc7518#section-3.3). I think it might be reasonable to change that allow larger lengths. But regardless, it doesn't affect the type of encoding: RSAPublicKey and analogous types are irrespective of the key length. I think RSAPublicKey (DER) can be parsed with  MarshalPKCS1PublicKey.
RSAPublicKey contains two integer components: modulus (n) and publicExponent (e). These correspond to the "n" (Modulus) and "e" (Exponent) parameters of JWK public keys (RFC 7518).
Part of the simplicity and excellence of did:key, I think is that it encodes just a key of a type, without algorithm parameters or optional values. The only optionality I have seen in currently specified types is regarding whether to use elliptic curve compression - and it seems the answer is yes for that: https://github.com/w3c-ccg/did-method-key/pull/36, https://github.com/w3c-ccg/did-method-key/pull/38.
@b5 and @expede, for your use cases, do you need to encode the allowed algorithms or other parameters in the key representation (e.g. for did:key)? Or would just the public key material alone suffice (i.e. modulus and exponent)?
If the modulus and public exponent is enough, I think RSAPublicKey (DER) would be a reasonable choice, for its ubiquity. In the work-in-progress implementation at @spruceid (https://github.com/spruceid/ssi/pull/309) I count the representation as 270 bytes for a 2048-bit RSA key, not including the multicodec prefix or multibase encoding. The modulus is 256 bytes and the exponent is 3 bytes, so I think that means there is up to 11 bytes of overhead. It would be possible to reduce that by using a different encoding if we wanted to that. With the test vector in ucan, I count 294 bytes for the SubjectPublicKeyInfo representation; that is containing a 270-byte RSAPublicKey representation.
I hope this is useful. I'm sorry I was not active in the discussion with the earlier registration.