[$500] Distance - Able to request money by distance by adding a stop same as finish point without enterring start point From

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @rakshitjain13
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697639775327799
Action Performed:
Action Performed:

Open app
Click on '+' FAB icon in LHS
Click on Request Money
Select Distance tab
Click on Add stop and fill India
Click on Stop and fill India
Click on Next button to proceed further
Able to Create Request

Expected Result:
It should not create request with not valid waypoints
Actual Result:
Able to create distance request with duplicate waypoints
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/93399543/633981e9-1809-4c40-bd9a-cc49d651f9f3

Android: mWeb Chrome

https://github.com/Expensify/App/assets/93399543/08d274f0-6e1c-4420-af21-d1a46f000984

iOS: Native

https://github.com/Expensify/App/assets/93399543/689f84d5-6b74-411f-ba77-32e580cd3b9b

iOS: mWeb Safari

https://github.com/Expensify/App/assets/93399543/bad19b9b-e733-4552-84dc-2ee167413a77

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/93399543/2826f26f-f291-4b7d-b93b-9671cc93a898
https://github.com/Expensify/App/assets/93399543/7f6fceaa-656f-43ad-8e58-47f8c517c941

MacOS: Desktop

https://github.com/Expensify/App/assets/93399543/6956ba72-a2ef-42ee-ae18-9617905c994d

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f177f4854fa6146e
Upwork Job ID:<PHONE_NUMBER>702423552
Last Price Increase: 2023-11-01

Proposal
Please re-state the problem that we are trying to solve in this issue.
Next Button Activated with Same Stop and Finish Point in Request Money
What is the root cause of that problem?
In src/components/DistanceRequest.js
we check for validwaypoint and then decide wether we have to go on next step or not . The logic is to check the size of validatedWaypoints array which is shown below .
https://github.com/Expensify/App/blob/6cd9c84cba8ac9d0a55573e7118192478c6913df/src/components/DistanceRequest/index.js#L183-L191
Now to generate validatedWaypoints the code is in fileSrc/libs/TransactionUtils.js
https://github.com/Expensify/App/blob/6cd9c84cba8ac9d0a55573e7118192478c6913df/src/libs/TransactionUtils.ts#L416-L445
This function fails in a edge case where starting waypoints are invalid because here lastWaypointIndex is equal to -1 in starting which suggests that first waypoint will always be valid when waypoints size > 1 .
What changes do you think we should make in order to solve the problem?
We have to have increment lastWaypointIndex till we find some valid waypoint and then it is good to go . Here is my solution

function getValidWaypoints(waypoints: WaypointCollection, reArrangeIndexes = false): WaypointCollection {
     const sortedIndexes = Object.keys(waypoints).map(getWaypointIndex).sort();
     const waypointValues = sortedIndexes.map((index) => waypoints[`waypoint${index}`]);
     // Ensure the number of waypoints is between 2 and 25
     if (waypointValues.length < 2 || waypointValues.length > 25) {
         return {};
     }

     let lastWaypointIndex = -1;
     let foundFirstValidWaypoint = false;

     return waypointValues.reduce<WaypointCollection>((acc, currentWaypoint, index) => {
         const previousWaypoint = waypointValues[lastWaypointIndex];

           // Skip all starting invalid waypoints
            if (foundFirstValidWaypoint == false && !waypointHasValidAddress(currentWaypoint)) {
                lastWaypointIndex += 1;
                return acc;
            } else {
                foundFirstValidWaypoint = true;
            }

         // Check if the waypoint has a valid address
         if (!waypointHasValidAddress(currentWaypoint)) {
             return acc;
         }

         // Check for adjacent waypoints with the same address
         if (previousWaypoint && currentWaypoint?.address === previousWaypoint.address) {
             return acc;
         }

         const validatedWaypoints: WaypointCollection = {...acc, [`waypoint${reArrangeIndexes ? lastWaypointIndex + 1 : index}`]: currentWaypoint};

         lastWaypointIndex += 1;

         return validatedWaypoints;
     }, {});
 }

Here I have introduced a new variable named as foundFirstValidWaypoint which is false in starting and once we find a validwaypoint we will set it to true till the time we will increment lastWaypointIndex in each iteration .

What alternative solutions did you explore? (Optional)
NA

Linked PR https://github.com/Expensify/App/issues/27045

I'm not able to recreate this following the steps in the report.
I see an error:

Checking the link PR shared above, this GH is a regression.
Anyone able to recreate this still?

Doubled checked and both staging and prod show the error.

@strepanier03 I think you misread the steps. You can follow one of the videos for information.

I think My PR https://github.com/Expensify/App/pull/28308 will fix this bug too

@DylanDylann I don't think so as in the above case validatedWaypoints size will be 2

Proposal
Please re-state the problem that we are trying to solve in this issue.
Distance - Able to request money by distance by adding a stop same as finish point without enterring start point From
What is the root cause of that problem?
Let's see the logic to validate waypoints
https://github.com/Expensify/App/blob/732d48e23ac132b1f91fcd004d6941d1b0237c34/src/libs/TransactionUtils.ts#L424-L444
The logic to update lastWaypointIndex in the end of function
https://github.com/Expensify/App/blob/732d48e23ac132b1f91fcd004d6941d1b0237c34/src/libs/TransactionUtils.ts#L441
Then if the condition here is true
https://github.com/Expensify/App/blob/732d48e23ac132b1f91fcd004d6941d1b0237c34/src/libs/TransactionUtils.ts#L430
lastWaypointIndex will be not updated. It causes this bug
What changes do you think we should make in order to solve the problem?
I suggest we should remove lastWaypointIndex and use index-1 instead
What alternative solutions did you explore? (Optional)
we also can move this line
https://github.com/Expensify/App/blob/732d48e23ac132b1f91fcd004d6941d1b0237c34/src/libs/TransactionUtils.ts#L441
before the condition
https://github.com/Expensify/App/blob/732d48e23ac132b1f91fcd004d6941d1b0237c34/src/libs/TransactionUtils.ts#L430

After retesting I see where I messed up the steps and was able to create the expense.

@rushatgabhane friendly bump on the proposal here when you get a chance.

@rushatgabhane - Do you have the bandwidth to review soon? Is there something else we should be doing with this?

Proposal
Please re-state the problem that we are trying to solve in this issue.
We are able to create two consecutive duplicate waypoints when there are stops added to the waypoints. So, we are trying to solve the problem by implementing the comment here
What is the root cause of that problem?
Currently, the logic supports consecutive duplicate waypoints when there are no stops added to the waypoints (i.e when only two waypoints are present). Support for consecutive duplicate waypoints with additional stops in waypoints is not there. That is the root cause.
What changes do you think we should make in order to solve the problem?
In the logic of determining validatedWaypoints here, we already check if we have two consecutive duplicate waypoints and ignore such duplicates here. This means that the length of waypoints and validatedWaypoints will be different when there are duplicates. We can use this information to solve this problem.

First, let us ensure that on submitWaypoints here, we will prevent the user to go to the next page by comparing the lengths of waypoints and validatedWaypoints like this:
 if (_.size(validatedWaypoints) < 2 || _.size(validatedWaypoints) !== _.keys(waypoints).length || hasRouteError || isLoadingRoute || isLoading) {
     setHasError(true);
     return;
 }

Now, since we already have hasError set, let us ensure that the rendering also happen by replacing our condition here like this:
         {((hasError && (_.size(validatedWaypoints) < 2) || _.size(validatedWaypoints) !== _.keys(waypoints).length) || hasRouteError) && (

Finally, we need to set the error message for duplicates here like this:
 if (_.keys(waypoints).length > 2 &&  _.size(validatedWaypoints) !== _.keys(waypoints).length) {
     return {0: translate('iou.error.duplicateWaypointsErrorMessage')};
 }

What alternative solutions did you explore? (Optional)

All good Melvin, things are moving forward.

I think we can simplify the solution.

We should always have a start and an end point
No two consecutive waypoints should be same. (This allows for A -> B -> and back to A)

What do you think? Any edge cases?

Adding the start as compulsory can solve the problem as our getValidatefunction fails in that case only. Thus adding this solution in my proposal as optional https://github.com/Expensify/App/issues/29895#issuecomment-1769064322

c+ reviewed 🎀 👀 🎀

We have another issue with new UX behavior: we only display add button if user fill 2 waypoints. It will make this bug can't reproduce more

@rushatgabhane the info @DylanDylann mentioned above was also discussed with you here: https://expensify.enterprise.slack.com/archives/C01GTK53T8Q/p1698999067236989
Was there any further discussion about the "add stop" button functionality that led to proceeding with this issue?

I think we can simplify the solution.

We should always have a start and an end point
No two consecutive waypoints should be same. (This allows for A -> B -> and back to A)

@rushatgabhane
Few queries I have:
A) Which specific scenario do you think in (1) mentioned above is not addressed by my proposal here? It would be great if you share the test steps for this.
B) Does the approved proposal here handle the scenario (A->B->B->A)? I think this scenario is part of (2) mentioned above.
Or am I missing something obvious here?
Please clarify

@rojiphil sorry i missed your proposal

A) Which specific scenario do you think in (1) mentioned above is not addressed by my proposal here? Can you please share the test steps for this?

@rushatgabhane
Oh ok! I notice the scenario for (A). No need to share the steps. This happens if the start is not entered.
A peculiar observation here is that when start and finish destination is not entered and stop destination is attempted, it will populate the finish destination. Also, an empty stop destination is displayed. This does not look right.
I think, either
i) The add stop destination should be disabled until start and finish is entered OR
ii)The add stop destination should fill in the empty start or finish destination (in the same order) and prevent an empty stop destination to be shown.
I think, based on your comment in slack here, it looks like (ii) is the way to go.
Does this make sense?

Proposal
Updated

ii)The add stop destination should fill in the empty start or finish destination (in the same order) and prevent an empty stop destination to be shown.

I have updated the proposal with the required changes for the above additional objective.
Also, the remaining part of the proposal still holds good. It addresses A->B->B->C scenario.

We have https://github.com/Expensify/App/issues/29886 with new UX behavior: we only display add button if user fill 2 waypoints. It will make this bug can't reproduce more

Also,  if handling of add button display is managed by the other issue, we can restrict our scope to handling the duplicate waypoint scenario addressed here in my proposal.

Hmmm... I should have read through the other issue also here.
Looks like there is a consensus on showing Add button only after Start and Finish are populated.
I think that would leave us with the pending issue of handling duplicates.

I think handling duplicate is not necessary as Google Maps also allows to have duplicate addresses. Also, duplicate addresses are handled by getValidWaypoints.

duplicate addresses are handled by getValidWaypoints.

While I agree that getValidWaypoints will ignore the consecutive duplicate addresses, I think some additional work is required to display the message for duplicate entries (i.e. in A->B->B->A scenarios) and also to prevent the usage of next to move ahead. no?

I think the current implementation suffices the above scenario without any error messages cc: @rojiphil

@rushatgabhane
What are your thoughts on addressing the consecutive duplicate endpoints scenario of A->B->B->A?

@strepanier03 can you maybe take this discussion RE https://github.com/Expensify/App/issues/29895#issuecomment-1800974078 to product?

What are your thoughts on addressing the consecutive duplicate endpoints scenario of A->B->B->A?

A->B->B->A should not be a valid endpoint sequence.
I think any two consecutive endpoints shouldn't be same

We should also make the start field mandatory regardless of the button disable / enable.
What I mean is, even without the disable UX the validate function should be correct when the user clicks next.
I hope this makes sense. What do you think? @rojiphil

We should also make the start field mandatory regardless of the button disable / enable. What I mean is, even without the disable UX the validate() function should be correct when the user clicks next.
I hope this makes sense. What do you think? @rojiphil

@rushatgabhane
I still do not understand why we need to make the start field mandatory as the appropriate message is displayed on click of Next. Sorry if I am missing something simple here.
Can you please share a failure test video when we do not make the start field mandatory?
Also, I noticed that the latest version has some changes for the implementation.
Here is the latest test video.
https://github.com/Expensify/App/assets/3004659/b932db4e-10b9-48bd-8dc7-5e00e67d14dd

Proposal
Updated
Have integrated changes to adjust according to the recent changes to PR here
Also, have updated the logic and added test video.
Kindly review.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Users can go to the next page when entering two consecutive same endpoints
What is the root cause of that problem?
We don't have logic to prevent user from clicking next button when they enter two consecutive same endpoints
What changes do you think we should make in order to solve the problem?
Note that in getValidWaypoints function we had logic to remove a waypoint if 2 consecutive endpoints is same
In here
https://github.com/Expensify/App/blob/bf2d545b5e2d40d7e72a51983112ef9fa9daf3f7/src/components/DistanceRequest/index.js#L180
we should check if _.size(validatedWaypoints) < _.size(waypoints) we will prevent user from submitting
Also need to update here
https://github.com/Expensify/App/blob/bf2d545b5e2d40d7e72a51983112ef9fa9daf3f7/src/components/DistanceRequest/index.js#L220
In this function https://github.com/Expensify/App/blob/bf2d545b5e2d40d7e72a51983112ef9fa9daf3f7/src/components/DistanceRequest/index.js#L147
we also add a message like "please remove duplicated waypoints" if _.size(validatedWaypoints) < _.size(waypoints)
We also prevent user going to next page by deeplink when they enter 2 consecutive same waypoints
https://github.com/Expensify/App/blob/bf2d545b5e2d40d7e72a51983112ef9fa9daf3f7/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js#L98
In here we also need to add condition like we did in DistanceRequest Page (_.size(validatedWaypoints) < _.size(waypoints))

I'm going to close this GH as the linked one above was opened before this one and the issues is resolved there.

@strepanier03 i think we should reopen because the validate func isn't correct https://github.com/Expensify/App/issues/29895#issuecomment-1792954251

This issue is fixed and we removed the duplicate error context here: #29803 (comment).

@dukenv0307
Can you please explain how is this issue fixed?
As I understand from the comment you referred to, the errors under point (2) has been addressed by the PR you mentioned.
However, the duplicate endpoint scenario of  A > B > B > A is still not addressed.
And, that is precisely what this issue is all about.

@strepanier03 @rushatgabhane
I also think that we should reopen this.
If we know that A > B > B > A is going to be considered as A > B > A in server, then, I think it is always better to prevent the user from entering this. I think, this will be confusing to the user.

Reopening based on the earlier comments!

@rushatgabhane Please help to take a look at my proposal

@rushatgabhane Please help to check my updated proposal that cover deeplink case

Bumped @rushatgabhane on Slack

Thank you @danieldoglas 🙌

Yeah, I think we should go forward with @rojiphil's proposal https://github.com/Expensify/App/issues/29895#issuecomment-1792954251
@rojiphil  actively pushed this issue to find the root cause

🎀 👀 🎀

@rojiphil's proposal doesn't cover deeplink case, user still go to next page by deeplink when they enter 2 consecutive same waypoints. Please help to check my proposal again.

@DylanDylann
I will check this out tomorrow.

@rojiphil's proposal doesn't cover deeplink case, user still go to next page by deeplink when they enter 2 consecutive same waypoints. Please help to check my proposal again.

@DylanDylann
For the deeplink case, can you please share the test steps with actual and expected result on the current staging version?
I tried reproducing this but could not. Not sure if I am missing something.
If you could also attach a test video that would be great.

@rojiphil I updated proposal to detail it
cc @rushatgabhane

@rojiphil's proposal doesn't cover deeplink case, user still go to next page by deeplink when they enter 2 consecutive same waypoints

@rushatgabhane
As I understand, the approach to the primary solution in @DylanDylann proposal is same as my proposal. However, an additional edge case is identified where the user comes via deep link to the participants page. Here, we check if there are at least two waypoints to continue further which makes sense as it would be useless to proceed further without having at least two waypoints. Unlike this, I think it is not critical to consider duplicates for scenarios with >2 waypoints as BE handles it gracefully.But, I think it may be better to include this for consistency. The same condition that is used in my proposal can be used here.
What do you think about this? Include or do not include?
If the decision is to be included, I would happily share $125 from my compensation to @DylanDylann for his contribution.

@rushatgabhane

@rojiphil actively pushed this issue to find the root cause
I greatly appreciate his support and his participation in the ongoing discussion about the expected behavior.
But my proposal is the best one to cover all cases and give more value. There are many issues where the completed proposal is selected instead of the proposal that only fixing one case

I greatly appreciate his support and his participation in the ongoing discussion about the expected behavior.
But my proposal is the best one to cover all cases and give more value. There are many issues where the completed proposal is selected instead of the proposal that only fixing one case

@DylanDylann
While I thank you for your appreciation towards finding the root cause, I think my involvement is not just limited to discussions.
I actively proposed a solution with 4 distinct steps which was presented before your proposal.
And your proposal consists of the same 4 distinct steps with a slight change in condition. Not sure of the additional value that is brought here.
However, I do agree that you brought forth the deep link case. But, here, I think it is not a critical implementation in the context of this issue as we are dealing with >2 waypoint scenarios.
It is understandable If the solution to an issue is simple and another proposal with additional non-critical fixes gets selected. But, curious to know if there are any issues where a large part of the proposal is taken from another proposal and it gets approved with a non-critical value added on top of it. I think, normally there would be a separate GH issue for additional fixes.
Nevertheless, every issue is different. So, I would leave it to @rushatgabhane to conclude on this.

@rojiphil

@rushatgabhane little bump when you get the chance to weigh in on the above.

Issue not reproducible during KI retests. (First week)

@danieldoglas i think we should go with @rojiphil's proposal because the edge case could have been caught in a PR review

@danieldoglas @strepanier03 could you please add waiting for copy label.
We need a copy for an error message when duplicate waypoints are entered.
"Please remove duplicate waypoints"

This was merged today, should be deployed to staging soon.

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/28618

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28618/files#r1454558927

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N.A.

Determine if we should create a regression test for this bug. Sure!

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again
1. Click Request Money via Global FAB(+)
2. Select Start Address (A)
3. Select Finish Address (B)
4. Click Add stop and add Address (B)
5. Verify that you see a duplicate waypoint error message.

@strepanier03 could you please add payment summary. Thank you! 🙇

Yup, will do, today is the release day so that is the plan.

@strepanier03 Accepted the offer

@rakshitjain13 - After reviewing this more carefully, I'm not sure why the payment comment had your name listed. I don't see that you worked on the PR or the review for this bug.
I am going to need to cancel the contract and we won't be able to pay it.
If you can link me to the work you did for this bug, I can reconsider but at this point, I don't think there's any work related to this that you need to be paid for. Is that correct?

Got it thank you @0xmiroslav , looks like it got in right before we paused the program so I'll get it sorted.

@rakshitjain13 sorry about the confusion there, that's my bad. I have sent over a new offer for the right price as the original one I sent was for $500 and it should be $50.

All that's left is the manual request payment for @rushatgabhane
Payment summary is here. Closing and assigning Jason.


prune internal frames from exception stack traces

I think this is only an issue for callbacks that throw exceptions (functions created in notebook and then passed down and called in library code; e.g. function passed to list.map).

Actually this is particularly important during interrupts. Edited title to reflect this.


DevTools overlay only shows while hovering text in control tree

While hovering over an element in the DevTools control tree, the corresponding element is highlighted in the application window. However this only happens while the mouse cursor is positioned over the actual text (the control type name, class list or element name). It's pretty annoying, especially with controls like Grid or Panel, since the type name is so short you actually have to aim to hit the text.
The reason for the current behavior is that the AddAdorner and RemoveAdorner event handlers are added to the stack panel containing the text elements, but that stack panel doesn't have a background set, so only its children receive pointer events.
https://github.com/AvaloniaUI/Avalonia/blob/2a7b5568b7f61fe6df9c46a05bf1c9d474c9290e/src/Avalonia.Diagnostics/Diagnostics/Views/TreePageView.xaml#L14-L20
An easy improvement would be to just add a transparent background, but that still isn't a perfect solution. The stack panel doesn't cover the full height of the tree view item, so when moving the mouse from one item to the next the adorner flickers, even if both controls have the same bounds. Also hovering the chevron or the area left to it would still not show the adorner
Ideally the event handlers would be attached to the TreeViewItem itself, but without event setters I'm not sure how one would do that.

probably the event can be added to the TreeView itself. e.Sender could point to the control that first send the event.

Yeah that appears to work. I'll get a PR ready.


StackOverflow Exception - Specific Avro Messages - Apache Avro 1.10.0

Description
When upgrading to Confluent Kafka 1.5.0 from 1.3.0, for our separate Avro message projects, we upgraded the Avro messages projects to use Apache.Avro version 1.10.0 from Confluent.Kafka.Avro -> <IP_ADDRESS>. At the time I noted that the minimum version of the dependency should be 1.9.2, but went with latest here. This has been fine so far but for this specific message I noticed StackOverflow exceptions in the consumer.
For a specific avro type we have:
{
  "namespace": "[namespace]",
  "type": "record",
  "doc": "[doc]",
  "name": "[message]",
  "fields": [
		{
			"name": "Field1",
			"type": "string"
		},
		{
			"name": "Field2",
			"type": "string"
		},
    {
      "name": "Field3",
      "type": "string"
    }
  ]
}

One thing to note is the strings in the fields will be quite large. I can try and get exact sizes if this helps.
When specifically targeting Apache.Avro 1.10.0 the following happens:
>	Avro.dll!Avro.IO.BinaryDecoder.ReadString()	Unknown
 	Avro.dll!Avro.Generic.DefaultReader.Read<System.__Canon>(Avro.Schema.Type tag, Avro.Schema readerSchema, Avro.Generic.Reader<System.__Canon> reader)	Unknown
 	Avro.dll!Avro.Generic.DefaultReader.Read(object reuse, Avro.Schema writerSchema, Avro.Schema readerSchema, Avro.IO.Decoder d)	Unknown
 	Avro.dll!Avro.Specific.SpecificDefaultReader.ReadRecord(object reuse, Avro.RecordSchema writerSchema, Avro.Schema readerSchema, Avro.IO.Decoder dec)	Unknown
 	Avro.dll!Avro.Generic.DefaultReader.Read(object reuse, Avro.Schema writerSchema, Avro.Schema readerSchema, Avro.IO.Decoder d)	Unknown
 	Avro.dll!Avro.Generic.DefaultReader.Read<>( reuse, Avro.IO.Decoder decoder)	Unknown
 	Avro.dll!Avro.Specific.SpecificReader<>.Read( reuse, Avro.IO.Decoder dec)	Unknown
 	Confluent.SchemaRegistry.Serdes.Avro.dll!Confluent.SchemaRegistry.Serdes.SpecificDeserializerImpl<>.Deserialize(string topic, byte[] array)	Unknown

How to reproduce

Create a consumer with default settings. I used the Apache Avro Example from the repo as my basis
Create a AVRO message with large strings
Reference Apache Avro 1.10.0 rather than 1.9.2

Should we use the latest Apache.Avro version? I have a lot more complex Avro messages targeting this version and working fine thus far. The only thing I can think of is the large strings?
Checklist
Please provide the following information:

[ ] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[1.5.0] Confluent.Kafka nuget version.
[ ] Apache Kafka version.
[ ] Client configuration.
[Windows+Linux] Operating system.
[ ] Provide logs (with "debug" : "..." as necessary in configuration).
[ ] Provide broker log excerpts.
[] Critical issue.

I just want to share my insight as I also experienced this issue recently and it was a real hell to find out what is wrong as 99% messages were consumed/deserialized correctly in my case. It all started with StackOverflowException in the consumer, too.
It seems there's a limitation for the length of the text for the string fields in Apache.Avro 1.10.0 (and 1.10.1 as well) that causes Avro.AvroException : End of stream reached in field XY. You can find the code snippet to reproduce this issue below. Once I downgraded Apache.Avro to 1.9.2, test below passes as a charm.
It looks like a bug to me, but if anyone thinks it's something else (configuration issue or so), please speak up. It will definitely help at least me/my team and @michael-huxtable 😄
    [Test]
    public void should_serialize_long_text()
    {
        ISchemaRegistryClient schemaRegistry = new CachedSchemaRegistryClient(config);
        IDeserializer<Topic> avroDeserializer = new AvroDeserializer<Topic>(schemaRegistry).AsSyncOverAsync();

        var objectToSerialize = new Topic
        {
            InfoText = "with more than 256 characters passed here the deserialization should not fail using version 1.10. with more than 256 characters passed here the deserialization should not fail using version 1.10. with more than 256 characters passed here the deserialization should not fail using version 1.10."
        };

        var avroBytes = new AvroSerializer<Topic>(schemaRegistry).SerializeAsync(objectToSerialize, SerializationContext.Empty).Result;

        var result = avroDeserializer.Deserialize(avroBytes, isNull: false, SerializationContext.Empty);
        Assert.That(result, Is.Not.Null);
    }

I have hit the same issue - likewise downgrading to Confluent.SchemaRegistry.Serdes.Avro 1.5.2 which uses Avro 1.9.2 fixed the problem
The Avro release notes are no help.
Did you discover anything else @marek-vrana ?

I have hit the same issue - likewise downgrading to Confluent.SchemaRegistry.Serdes.Avro 1.5.2 which uses Avro 1.9.2 fixed the problem
The Avro release notes are no help.
Did you discover anything else @marek-vrana ?

Currently there are two open bugs related to our investigation:

Deserialization of string with > 256 characters fails
Unknown logical types are not ignored during deserialization but lead to an exception.

let's hope for a soonish fix for the first one at least 🤞

Currently there are two open bugs related to our investigation:

Deserialization of string with > 256 characters fails
Unknown logical types are not ignored during deserialization but lead to an exception.

let's hope for a soonish fix for the first one at least 🤞

FYI: version 1.10.2 is out 🎉 large strings issue is fixed.
https://github.com/apache/avro/releases/tag/release-1.10.2

Just created https://github.com/confluentinc/confluent-kafka-dotnet/pull/1566 to hopefully speed this up. :)

Think this one can be resolved now that 1.6.3 has been released!

I have hit the same issue - likewise downgrading to Confluent.SchemaRegistry.Serdes.Avro 1.5.2 which uses Avro 1.9.2 fixed the problem
The Avro release notes are no help.
Did you discover anything else @marek-vrana ?

For anyone that hits a similar issue to me the above helped me.
we upgraded the avro nuget package from 1.5.2 -> 1.5.3 and then on consumption we started getting the following errors:
Confluent.Kafka.ConsumeException: Local: Value deserialization error
 ---> Avro.AvroException: End of stream reached in field FieldName

The fix was to downgrade back to 1.5.2


[Offline sync] Implement pending SQLite store work (marked in code with TODO)

Either addressed the TODO or opened an issue for each.


criterion validation not working

count return 1 even if criteria is not post

@martinfojtik Hi Thank you for your contribution. Could you fix the conflicting file in your PR (with rebase, if possible) ?

Closing as it seems author has moved to other topics.
@martinfojtik  if you come back, please tell us we can reopen the PR 😉


Some minor bugs.

This error occurs while using methods.
Also update the example of "README.MD"

Gotcha! Will fix it ASAP

Is this issue is fixed or not ?


Update circe-core, circe-generic, ... to 0.14.0

Updates

io.circe:circe-core
io.circe:circe-generic
io.circe:circe-parser

from 0.13.0 to 0.14.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (0.13.0).
You might want to review and update them manually.
documentation/build.sbt

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.circe" } ]

labels: library-update, semver-minor, old-version-remains

Superseded by #826.


External account only

What if I do not want use local account login and only use external accounts to login?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a4c264c0-0c5c-298e-bb45-9b4891c8d162
Version Independent ID: ce69b990-0b4c-abda-cd2d-68f85cd8031e
Content: Microsoft Account external login setup with ASP.NET Core
Content Source: aspnetcore/security/authentication/social/microsoft-logins.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Are you asking how to disable the creation of local accounts? If so, scaffold Identity and remove or comment out the code to create local accounts.

Thanks @Rick-Anderson for the reply. Yes, I want to disable all the UI related to that local accounts. When the user tries to access the page which requires authentication, I want the browser to be redirected to the external account login page and upon completion of login, the browser should be at the original page. I still want to store the user details in database to manage authorization to various pages but the user should never be prompted to enter any details.

I got this to work without using identity. I used a callback for OAuthEvents.OnCreatingTicket to modify the ClaimsIdentity (adding additional claims) and it does exactly what I need.

@nvmkpk Can you please post your solution somewhere?  I'm trying to do the same essential thing, but with an external Identity Server (using WS-Fed) and I'm tripping over the need to have an internal login page and identity database.


APP-1447: Integration Bridge needs support proxy server to connect to POD

Added a proxy model and field to Integration Properties.
Fixed unit tests and added new ones based on the proxy model.

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished.

Codecov Report

Merging #136 into dev will increase coverage by 0.02%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##              dev     #136      +/-   ##
==========================================
+ Coverage   88.52%   88.54%   +0.02%
==========================================
  Files         133      134       +1
  Lines        2413     2436      +23
  Branches      281      281
==========================================
+ Hits         2136     2157      +21
- Misses        168      170       +2
  Partials      109      109

Impacted Files
Coverage Δ

...ss/integration/model/yaml/ProxyConnectionInfo.java
100% <100%> (ø)

...on/api/client/AppAuthenticationProxyApiClient.java
100% <100%> (ø)
:arrow_up:

...yoss/integration/api/client/SymphonyApiClient.java
86.95% <100%> (ø)
:arrow_up:

...ation/api/client/AuthenticationProxyApiClient.java
100% <100%> (ø)
:arrow_up:

...onyoss/integration/webhook/WebHookIntegration.java
86.74% <100%> (ø)
:arrow_up:

...honyoss/integration/model/yaml/ConnectionInfo.java
100% <100%> (ø)
:arrow_up:

.../integration/model/yaml/IntegrationProperties.java
96.39% <75%> (-1.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fa48d...89fb894. Read the comment docs.

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished.

Build triggered. sha1 is merged.

Build started sha1 is merged.

Build finished.


build and publish docker images through github CI

I'm not sure if this is related to #194 but I don't see automation yet for publishing docker images, and wanted to contribute it.
Also not sure of a great way to test things like this, but feel free to grab me on discord (@booniepepper) if there are any issues

Not sure this is needed, as images are already built and published using goreleaser:
https://github.com/refaktor/rye/blob/9a678140a2c523805f79d03bc0bcbbaf75d474d1/.goreleaser.yaml#L63-L72
See https://github.com/refaktor/rye/pkgs/container/rye
May cause conflicts on next release.

@booniepepper, can you please check if the existing released images at https://github.com/refaktor/rye/pkgs/container/rye are ok or is there something that should be changed / improved?
See https://github.com/refaktor/rye?tab=readme-ov-file#binary-docker-image

As far as i can tell the issue described in linked #194 now works fine:
docker run ghcr.io/refaktor/rye:latest -do "print 123 + 123"
Unable to find image 'ghcr.io/refaktor/rye:latest' locally
latest: Pulling from refaktor/rye
250c06f7c38e: Download complete
50967c6354e2: Download complete
01948aa61ab5: Download complete
Digest: sha256:e73d6d8a7c66dd65e578271e1fc4e625e992108b748f3103cc748dab034e6dfd
Status: Downloaded newer image for ghcr.io/refaktor/rye:latest
246


Catch error in check selector dependencies

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines          19     20    +1
=====================================
+ Hits           19     20    +1

Impacted Files
Coverage Δ

src/index.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ffaa47...4f96221. Read the comment docs.

Coverage increased (+0.03%) to 98.246% when pulling 4f962219dc2bb3b9a6ab32e84380014b0a281490 on veksa:master into 4ffaa47917aee937202456f0886c8674d478a3ba on skortchmark9:master.

Coverage increased (+0.03%) to 98.246% when pulling 4f962219dc2bb3b9a6ab32e84380014b0a281490 on veksa:master into 4ffaa47917aee937202456f0886c8674d478a3ba on skortchmark9:master.


Bug:  Git sensor got error and return exit code 128

📜 Description
Logs:
│ git-sensor {"level":"info","ts":1723014048.660751,"caller":"pkg/RepoManages.go:468","msg":"errored material ","id":4,"errMsg":"exit status 128"}                                                         │ │ git-sensor {"level":"error","ts":1723014050.2870855,"caller":"git/GitBaseManager.go:185","msg":"error in git cli operation","msg":"fatal: not a git repository (or any of the parent directories): .git\ │ │ git-sensor {"level":"error","ts":1723014050.2873294,"caller":"git/RepositoryManager.go:204","msg":"error in updating repository","err":"exit status 128","location":"git@xxxx │ │ git-sensor {"level":"error","ts":1723014050.287529,"caller":"git/Watcher.go:200","msg":"error in fetching material details ","repo":"git@xxxxxxxx","err":"exit s │ │ git-sensor {"level":"error","ts":1723014050.2898335,"caller":"git/GitBaseManager.go:185","msg":"error in git cli operation","msg":"fatal: not in a git directory\n","err":"exit status 128","stacktrace" │ │ git-sensor {"level":"error","ts":1723014050.2899919,"caller":"git/RepositoryManager.go:367","msg":"error in configuring ssh command while adding repo","errorMsg":"","err":"exit status 128","stacktrace │ │ git-sensor {"level":"error","ts":1723014050.2901144,"caller":"git/Watcher.go:212","msg":"error in creating/configuring ssh private key on disk ","repo":"git@xxxxxx │ │ git-sensor {"level":"info","ts":1723014050.4152596,"caller":"pkg/RepoManages.go:468","msg":"errored material ","id":4,"errMsg":"exit status 128"}
👟 Reproduction steps
When I run Build and Deploy. Got an error:

👍 Expected behavior
Pulling code should successfully
👎 Actual Behavior
Return code 128
☸ Kubernetes version
1.28
Cloud provider

openstack

🌍 Browser
Chrome
🧱 Your Environment
No response
✅ Proposed Solution
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find any similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Hi @tommy04062019 , If you are still facing this issue then can you please tell us steps to reproduce this ?

Hi @tommy04062019 , we believe this error happened because either you didn't have proper access to the target repo or repo url was incorrect. Either way, we have done improvements on our side to show meaningful error messages on UI.
I am closing this issue for now but feel free to open this if you feel otherwise.


Ambiguous method call

Hi,
We use your project in ViaVersion due to you changing the method signature we get compilation errors.
[ERROR] /home/travis/build/MylesIsCool/ViaVersion/common/src/main/java/us/myles/ViaVersion/api/type/types/minecraft/NBTType.java:[44,18] reference to writeTag is ambiguous
  both method writeTag(java.io.OutputStream,org.spacehq.opennbt.tag.builtin.Tag) in org.spacehq.opennbt.NBTIO and method writeTag(java.io.DataOutput,org.spacehq.opennbt.tag.builtin.Tag) in org.spacehq.opennbt.NBTIO match

Is there a chance of version bump & deploy to maven?

Cast to the one you want to use.

Maybe I was a bit unclear, the issue is we have some systems using an older version of your library and some using the latest.
This is because both are known as 1.0, so is there a chance you can version bump & deploy to maven because I consider the latest change a breaking one which is the issue.
Kind Regards


Display financial details for accounts

Display market details (convert to USD/BTC/etc, totals)

#120 https://github.com/ethereumproject/emerald-wallet/pull/120


Feature request: same component with the multiple paths

I'm building a social website and there're a lot of the different paths with the same component routes like this:
{
    // My favorites
    path     : '/favorites',
    component: FavoriteList
},
{
    // The other user's favorites
    path     : '/:username/favorites',
    component: FavoriteList
},
{
    // Create the post
    path     : '/post/create',
    component: Post
},
{
    // Edit the post
    path     : '/post/edit/:id',
    component: Post
},

Maybe we can use an array in the path property?
{
    path     : ['/:username/favorites', '/favorites'],
    component: FavoriteList
},
{
    path     : ['/post/create', '/post/edit/:id'],
    component: Post
},

Use alias with an array: https://router.vuejs.org/en/essentials/redirect-and-alias.html

We also need this as well, because our final url pathing changes depending on environment.

just loop some paths:
const routes = [   {     path: '/a',     component: A,   },   ...['/:username/favorites', '/favorites'].map(path => ({     path,     component: FavoriteList   })),   ...['/post/create', '/post/edit/:id'].map(path => ({     path,     component: Post   })),   {     path: '/z',     component: Z,   }, ];

you can just put a name for each one like :
{
    // My favorites
    path     : '/favorites',
    name: 'favorites',
    component: FavoriteList
},
{
    // The other user's favorites
    path     : '/:username/favorites',
    name: 'favorites_2',
    component: FavoriteList
},
{
    // Create the post
    path     : '/post/create',
    component: Post
},
{
    // Edit the post
    path     : '/post/edit/:id',
    component: Post
},


Beta 4 Focus upgrade - stack overflow

(I don't have a screenshot right now because I'm making this issue from my phone.)
You can put in a medium (bolt, etc. I forger what they're called) into the center slot, but putting in a modifier in any slot erases the inventory, JEI disappears, and the rest of the focus options are gone. The "stack overflow" issue shows up in chat.
If you right-click the slot of where you put the modifier, the inventory will return and the other focus upgrade options are available. (JEI doesn't show up again, but not a big deal.)
I think this only works with the new focus upgrades.
I stubbed my toe and I'm not at my computer right now, so I'll get more info later if needed.

*p.s.: thanks to Azanor for... all his stuff. No long explanation needed.

JEI didn't disappear, I guess. I remembered wrong.

I also did some testing, if you do a fresh install (i even deleted .minecraft) it simply crashes, optifine prevents the crash
Here is a screenshot of the crash report

I also can't find the "Quicken" medium, but that may be just my issue.


Jni based Fuse hung when mount on macosx

Alluxio Version:
HEAD of master branch..
Describe the bug
Stuck when mount alluxio when enable jnifuse, but it can work well when disable jnifuse
To Reproduce
set alluxio.fuse.jnifuse.enabled=true in the alluxio-site.properties to enable jnifuse
exexute the following command line to mount alluxio /abc to local path /tmp/mp_target
integration/fuse/bin/alluxio-fuse mount /tmp/mp_target /abc

Expected behavior
see the log AlluxioJniFuseFileSystem mounted and can execute ls /tmp/mp_target well.
Urgency
High
Additional context
Not sure what is the root cause.
I got a stack
"main@1" prio=5 tid=0x1 nid=NA runnable
  java.lang.Thread.State: RUNNABLE
	  at alluxio.jnifuse.LibFuse.fuse_main_real(LibFuse.java:-1)
	  at alluxio.jnifuse.AbstractFuseFileSystem.execMount(AbstractFuseFileSystem.java:108)
	  at alluxio.jnifuse.AbstractFuseFileSystem.mount(AbstractFuseFileSystem.java:88)
	  at alluxio.fuse.AlluxioJniFuseFileSystem.mount(AlluxioJniFuseFileSystem.java:603)
	  at alluxio.fuse.AlluxioFuse.main(AlluxioFuse.java:123)

@apc999 Please take a look at this issue. Thank you for telling me Macosx cannot run jnifuse for now.

@apc999 Please take a look at this issue. Thank you for telling me Macosx cannot run jnifuse for now.

currently alluxio.jnifuse.struct.FileStatTest does not pass on MacOS with failed asserts on some fields. I am working on it

@apc999 's PR #12836 is able to launch the JNI FUSE and run ls mv cat rm vi + modify file command successfully.
Some commands are failed:

cp

$ cp fileA fileB
cp: fileB: fchmod failed: Function not implemented

chmod

$ chmod 777 fileA
chmod: Unable to change file mode on fileA: Function not implemented

chown

$ chown alluxio:wheel fileA
chown: fileA: Function not implemented


linkify_issues: Test suite

Make a test suite, especially to improve testing areas like #1 via pytest.mark.parametrize

We have tests now for this


WIP - Root emails

WIP for #13. Currently in it:

Delegation zone with MX, DKIM and verification records
Mail bucket and appropriate policies
Website redirect configuration on the bucket to serve as zone delegation status health check (alarm missing)
SES rule set creation for inbound mail handling and rule set activation

Specific points for the review:

IMHO the custom resource function blueprint could be reduced a bit - WDYT?

I'll rebase to just 4ab6532 after the review.

@yawn feel free to merge and continue with mainline development :)

merging and then mainline dev


Scale/Resize Output

Hi,
i have image 1000x1000 px
but i want to resize output. Because its take 100sec to generate output. So how can i do it sir?
Thanks.

Hello @jeffywilburn you can resize using cv2. I mention some example
import cv2
Load your image
image = cv2.imread('input_image.jpg')
Define the new size (e.g., 500x500 pixels)
new_size = (500, 500)
Resize the image
resized_image = cv2.resize(image, new_size)
Save the resized image
cv2.imwrite('output_image.jpg', resized_image)


renaming dal lib

in this change we rename daal_sycl to onedal_sycl starting from Beta08

/azp help

/azp list

/azp run


feat: Add new ptn modules avm/ptn/azd/container-app-upsert

Description
Fixes https://github.com/Azure/Azure-Verified-Modules/issues/1222
Currently, this PR contains the development of two ptn modules: azd/container-app-upsert and azd/container-app, since this module azd/container-app-upsert depends on azd/container-app. After https://github.com/Azure/bicep-registry-modules/pull/3234 is released, we will update the current PR to directly reference ptn model azd/container-app.

Pipeline Reference

Pipeline

Type of Change

[ ] Update to CI Environment or utilities (Non-module affecting changes)
[x] Azure Verified Module updates:

[ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:

[ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
[ ] The bug was found by the module author, and no one has opened an issue to report it yet.

[ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
[ ] Breaking changes and I have bumped the MAJOR version in version.json.
[ ] Update to documentation

Checklist

[x] I'm sure there are no other open Pull Requests for the same update/change
[x] I have run Set-AVMModule locally to generate the supporting module files.
[x] My corresponding pipelines / checks run clean and green without any errors or warnings

@jongio for notification.

@NanaXiong00
We have added examples for Bicep parameter files to the Readme. This has been applied to all published modules but needs to be done for PRs as well. Can you please run the Set-AVMModule utility as detailed here. It is required for the validation pipeline to succeed and the contribution to be published.
Please reach out if any support is needed.


Fix React 18 throw error issue

@Cow258 Hey! Thanks for the PR!
I'm wondering... why did you remove the workflows? 😅

Closing due to no response.

@Cow258 Hey! Thanks for the PR!
I'm wondering... why did you remove the workflows? 😅

I apologize for any inconvenience caused by my previous actions. I would like to respectfully inform you that after attempting to contribute via a pull request, I discovered that my method was not sufficient in solving the problem at hand. In order to test my code on certain environments that required installation from npm, I made some changes and force pushed and published to npm. However, I neglected to remove the pull request.
I sincerely apologize for any confusion or disruption this may have caused. Please note that my final solution involved using CloudFlare Turnstile.
Thank you for your understanding and patience.

@Cow258 No problem 👍


Mesh has non manifold vertices

Hi, I have downloaded and built boundary-first-flattening console application recently. I was trying to use it to flat triangulated hemisphere which was triangulated with Netgen but got an error "Unable to load file: test.obj. Mesh has non manifold vertices.". I don't understand why I got this error because it was triangulated very similarly to your hemisphere which I found in repository input/hemisphere.obj. My file: https://drive.google.com/file/d/1A5PkvTeRvQtVI8xt5lNF1JtvoTK6gOrK/view?usp=share_link
I would appreciate any help, thank you.

It looks like the triangles in the mesh are not oriented properly. You can do that using meshlab:

BFF works once you reorient the triangles.

@rohan-sawhney thank you for your answer I will try to follow it.


Mixing computed properties and literal properties

Seems like ending an object literal with a computed property causes other properties not to be defined?
var obj = {
  first: "first",
  ["second"]: "second",
};

generates
"use strict";

var _defineProperty = function (obj, key, value) {
  return Object.defineProperty(obj, key, {
    value: value,
    enumerable: true,
    configurable: true,
    writable: true
  });
};

var obj = _defineProperty({}, "second", "second");

while
var obj = {
  ["second"]: "second",
  first: "first",
};

generates
"use strict";

var _defineProperty = function (obj, key, value) {
  return Object.defineProperty(obj, key, {
    value: value,
    enumerable: true,
    configurable: true,
    writable: true
  });
};

var obj = (function () {
  var _obj = {};

  _defineProperty(_obj, "second", "second");

  _defineProperty(_obj, "first", "first");

  return _obj;
})();

Reproduced in 2.4.8.

Gah, using the wrong array to build properties for the object literal. I'll push out a new version shortly, sorry!
These issues should be biten before they're even released in the future as following the esnext merger I've integrated their entire test suite. I'm currently working on integrating the entire Traceur test suite.

Fixed as of 2.4.9


Adding service in layer control through dnd widget

Hello Brian,
I am using your dnd widget to add shape file and services. Is it possible to show the added service in the layer control menu? The purpose is to turn on/off the layers in the service.
Thanks

@deepal13 Support for adding layers/services to the layerControl widget using topic publish/subscribe was added to cmv in the current develop branch in the cmv repo. If you are using that version of cmv with the layerControl widget and the dnd widget, the layer/service will be added automatically.

@tmcgee I just downloaded the code from https://github.com/BrianBunker/cmv-widgets and tried it. It didn't add it to layer control. Am I referring the wrong link?

That DnD widget is the correct version. However, at present this will only work with the layerControl widget found in the un-released develop branch of cmv.

@tmcgee I downloaded the code from the link you provided. The widget adds the service but in layerControl widget it doesn't expand to show all its layers.

@deepal13 I have a few changes to both the layerControl and Dnd widgets to handle more Service types and better error handling. I will be submitting PRs for both in this repo and in the cmv repo.

@deepal13 PR #34 which has already been committed addresses the changes needed to the Dnd widget.

@deepal13 Here's the pending PR in the cmv repo that addresses the changes needed to the layerControl widget.

@tmcgee I tried the updated code, it still adds in drag-n-drop widget. Can you please check once?
Thanks

@deepal13 Do you have an example service that demonstrates the issue?

@tmcgee I added the following service: http://nowcoast.noaa.gov/arcgis/rest/services/nowcoast/guidance_model_ocean_grtofs_offsets/MapServer

@deepal13 I don't see any issues with adding that service with DnD:

I downloaded the code from: https://github.com/BrianBunker/cmv-widgets.
Can you please share the code link?

@deepal13 That is correct for the DnD widget. For the layerControl widget, you will need to use the code from the develop branch of cmv.  Here is a working example that will be running for a few days.

@tmcgee  It is working now but as soon as I turn on/off any layer of the added service, the service vanishes from map and doesn't turn back on.

@tmcgee

@deepal13 I see the behavior you describe. This is because the DnD widget assigns the url of the service as the layer id. Instead of using the url, I think it would be better to assign a random id such as what happens for other types such as shape files or exclude the id and let the map assign one like Layer123.

@deepal13 Try again with the latest DnD widget. Yesterday I added code to create layer IDs instead using the url.

@tmcgee It works fine now. Thank you so much.
I want to request you to please add a feature to change color/symbols of layer.
Thanks again.

@tmcgee I am having trouble with printing. When I am using a secure service with proxy setup, the print fails giving error.
error Error: Unable to complete operation.
at Error (native)
at Object.g.load (https://js.arcgis.com/3.17compact/init.js:663:426)
at https://js.arcgis.com/3.17compact/init.js:87:450
at c (https://js.arcgis.com/3.17compact/init.js:103:393)
at d (https://js.arcgis.com/3.17compact/init.js:103:182)
at resolve.callback (https://js.arcgis.com/3.17compact/init.js:105:10)
at c (https://js.arcgis.com/3.17compact/init.js:104:96)
at d (https://js.arcgis.com/3.17compact/init.js:103:182)
at resolve.callback (https://js.arcgis.com/3.17compact/init.js:105:10)
at https://js.arcgis.com/3.17compact/init.js:92:118

@deepal13 This is not the right place for new requests or asking for support other than for @BrianBunker widgets. Please submit your issues at the cmv-app repo or post questions on gis.stackexchange.


Add chroma

@bmcfee, I am getting a librosa warning when I run the below test:
librosa/core/pitch.py:147: UserWarning: Trying to estimate tuning from empty frequency set.
I do not get this error in Jupyter, which seems odd.
Also, I like giving pitches real names, and it works well with making chroma a FeatureCollection.  We could alias 'c#' and 'db', maybe?

Coverage increased (+0.9%) to 97.917% when pulling 2045145aaf1aa2b480e7ac43c1e6baed4f9e241a on add-chroma into 7fe1413013214411c268e8cf228add7e8be4f939 on master.

@bmcfee, still seeing that librosa warning when running tests, for the record.
Coverage increased (+0.9%) to 97.917%
:fire:


Use default locale without language prefix

Is it possible to set up the module to use the default locale when there is no language prefix?
For example, if I enter mysite.com/page/, and the default locale is en_US, it would display mysite.com/en_US/page.
Hope you understand what I need, since it's important for SEO.
Thanks,
Ivan

Is there a good solution for this problem? I have two languages configured, and since Swedish is the main language, and the English version of the site just as a bonus, I would like the default language pages to use URLs without a language prefix.

Is there some other module that manages to solve this?

I don't know about any other modules that would support this. I was hoping someone would come up with a good starting point for this, because unfortunately at this moment I don't have the time available to delve into this...
Also I'm not quite convinced - can someone please explain to me why this would be a good thing?

In my case, the Swedish version is the main version. Probably 95% of all visitors will want to access the Swedish version. Therefore, it's convenient and a better user experience to have URLs without the language code. It's shorter, easier to remember individual URLs. And it's cleaner. Basically I would like the Swedish version of the site to behave like just any normal Silverstripe site when it comes to URLs and have the English version below /en.

With the most recent build of silverstripe and translatable module, it
already appears to do this out of the box. Unique urls, without any
language prefix at all.
On Fri, May 8, 2015 at 12:15 PM, Andreas Lindahl<EMAIL_ADDRESS>wrote:

In my case, the Swedish version is the main version. Probably 95% of all
visitors will want to access the Swedish version. Therefore, it's
convenient and a better user experience to have URLs without the language
code. It's shorter, easier to remember individual URLs. And it's cleaner.
Basically I would like the Swedish version of the site to behave like just
any normal Silverstripe site when it comes to URLs and have the English
version below /en.
—
Reply to this email directly or view it on GitHub
https://github.com/Martimiz/silverstripe-languageprefix/issues/7#issuecomment-100318615
.

I'm not sure if I understand you correctly but in Translatable it has always been possible to have multiple languages without using prefixes. The languageprefix module was created for people that wanted to use them...

Which build are you referring to? The build I'm using adds the locale to the end of the URLSegment

I may be assuming url . it adds the locale as a query string param to the
end of the url in the admin only. But not in the front end of the site.
I am using "silverstripe/cms": "3.1.12", "silverstripe/translatable":
"2.0.*"
I have ditched the silverstripe-languageprefix module altogether.
On Fri, May 8, 2015 at 12:30 PM, Andreas Lindahl<EMAIL_ADDRESS>wrote:

Which build are you referring to? The build I'm using adds the locale to
the end of the URLSegment
—
Reply to this email directly or view it on GitHub
https://github.com/Martimiz/silverstripe-languageprefix/issues/7#issuecomment-100321219
.

So what URLs do you get on the front end site?

I browse to /about-us and see the site tree menu for all pages set as
english.
I browse to /a-propos-de-nous  and see the site tree for all french pages.
On Fri, May 8, 2015 at 12:37 PM, Andreas Lindahl<EMAIL_ADDRESS>wrote:

So what URLs do you get on the front end site?
—
Reply to this email directly or view it on GitHub
https://github.com/Martimiz/silverstripe-languageprefix/issues/7#issuecomment-100322664
.

Ah, ok. The thing is I would like to have the French version at /fr/a-propos-de-nous instead, while the english version will be located at /about-us.

Yep. that is what i wanted, also. And i never found a good way to do that.
I opted to explain to clients that we simply did not need the /fr in front,
seeing as all the urls were unique anyways.  On the home page for french, I
simply made the url segment "fr".  So you hit /fr and it goes to french
home.  Every other page was just a regular page with french urls. I now see
no added benefit of adding /fr in front of the main url :)
On Fri, May 8, 2015 at 12:42 PM, Andreas Lindahl<EMAIL_ADDRESS>wrote:

Ah, ok. The thing is I would like to have the French version at
/fr/a-propos-de-nous instead, while the english version will be located at
/about-us.
—
Reply to this email directly or view it on GitHub
https://github.com/Martimiz/silverstripe-languageprefix/issues/7#issuecomment-100323534
.

@quinnmerio - as I said: no reason to use it if you do not need it. Ditch doesn't sound very nice though :(
@andreaslindahl - it would have to be a bit of a rewrite, because the module expects the prefix (see PrefixModelAsControler ~ #34.
It would have to be optional, because links would either have to be generated with or without prefix for the default language...

I'll try and have a look on monday to see if it's at least feasible.

That would be awesome! :)

Perhaps ditch isn't the right word.. ;-) .. opted to not use.
On Fri, May 8, 2015 at 12:56 PM, Andreas Lindahl<EMAIL_ADDRESS>wrote:

That would be awesome! :)
—
Reply to this email directly or view it on GitHub
https://github.com/Martimiz/silverstripe-languageprefix/issues/7#issuecomment-100327603
.

I've set up a test branch called 'no-prefix-for-default'. By adding the following config setting in /languageprefix/_config/languageprefix.yml (and flush):
  prefixconfig:
    ...
    disable_prefix_for_default_lang: true

It should: skip the prefix for the Default Translatable locale, perform a permanent redirect for links that still use it, and update the links in the CMS URLSegment field. The alternative links in the header also work.
I would appreciate it if you would test this (think forms, images, etc)
Martine

Great! I will give it a try ASAP!

Hi
Form actions doesn't seem to work. I get a 404...

Yes I see - it is harder then I thought:  basically this testversion doesn't support subpages nor actions, so it is sort of useless so far :(
I would have to subclass the ContentController to change the request handler, and that is not an option at this point. I'll think about another way, but for now - sorry...

No problem! I'm glad you gave it a try!

I've uploaded a new version of the 'no-prefix-for-default' branch. It is a bit of a rewrite, because the original version could not be persuaded to do this. So it definitely needs testing, especially with the subsites module.
@andreaslindahl: If you are still interested, please let me know if you can do some of the testing?

I would be happy to test it!

well, it's ready for download, just not for production yet. Let me know :)

Yup, I downloaded and have tested it. So far everything seems to work as it should, including forms. :)

Well, that's a start :) basically now it's about what should happen with all kinds of urls. For instance if you disable the prefix for the default language 'en', links that have /en/ in them get 301 redirected to the links without prefix. But there can be all kinds of other options.
For instance what happens the other way around, what happens with older links, what happens to, say, french pages called without prefix, etc. Easy to just generate 404's, but what kind of support for 'wrong' or older links would be necessary from a SEO point of view? These are serious questions :)

Hi again :)
Found a bug. BaseLinkForLocale() doesn't seem to work. I believe the reason is this line (#203):
$prefix = LanguagePrefix::get_prefix();
Changed it to
$prefix = LanguagePrefix::get_prefix($this->owner->Locale);
and got it working

Yes I can see that this is a bug, because it will alwas set the BaseLinkForLocale to the default locale. Thanks for spotting it! Care to create a pull request?

Thanks, merged.
Have you found this version working as it should otherwise? I'd like to make this the master branch, and I don't see any problems myself, but as it's a substantial rewrite, I'd like to be as sure as possible :)

So far it seems to work perfectly. You should perhaps get someone else to test it as well, however. I have only used it on a very small website, with just two languages, so far.

I don't think having two or ten languages, nor two or a hundred pages would really make a difference - the basics are the same. Further more it's alle about page urls. My only worries were things like forms and homepages, but they seem to work fine now.
Other problems might be caused by modules that extend the Link functionality in a non-standard way, but I think that's outside the scope of this module.
Would be nice if other people would test it too, but unfortunately I can't reach out to people other then asking it here :) And I don't really know how big the target audience for this mod is anyway, that's another thing...
But thanks for pointing out bug(s) :)
Cheers, Martine

can you merge this to master and tag it?
seems to work here very welll.

I've moved the current version to a separate branche 2.0, and taggedit as 2.0.0. I'm doing some final tests on the new version after upgrading to PSR-2 and I will shortly release it as v3.0.0

The new version is now released as v3.0.0


prefix for environment variables

It would be great to have a function like "SetEnvPrefix" or something to be able to add a prefix to the environment variables. As an example:
var age int

flag.IntVar(&age, "age", 27, "my age")
flag.SetEnvPrefix("svc")

And then be able to do the following:
$ SVC_AGE=25 go run gopher.go

What do you think ?

Any ETA on the merge ?

I'm just another user, but it's already possible to do either:
flag.CommandLine = flag.NewFlagSetWithEnvPrefix("my-set", "MY_PREFIX", flag.ExitOnError)
...
flag.Parse()

Or to use your own FlagSet directly:
set :=  flag.NewFlagSetWithEnvPrefix("my-set", "MY_PREFIX", flag.ExitOnError)
...
set.Parse(os.Args[1:])

@smyrman Hey you're right - wow that function was hidden in extras and I never saw it.  😄

Indeed.
It was just missing from the doc.
@smyrman: kudos to you


TextField(type="number") deny number more than 309 digits

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example:
https://codepen.io/nishidemasami/pen/ExRNXLp
Steps:

create type="number" TextField
add numbers over than 310 digits (number over then about 1.8e+308)
the onChange event target value is empty string
the onChange event does not work when add numbers over than 311 digits

Current behavior 😯
the onChange event target value is empty string, or, the onChange event does not work
Expected behavior 🤔
I want to get number at least as text
Context 🔦
No response
Your environment 🌎
No response

it's not a material UI bug, replace Textfield with  you will still see same issue

Thanks for the explanation, @sai6855.
What's more, representing such large numbers in JS is problematic. You'll likely want to use input type"text".
If I may ask - what's the use case for having an input accepting so large numbers?

I understand. Thank you very much!


Nightly builds

It would be useful to setup nightly builds of master (and branches?), so that users can easily try bug fixes on their systems without compiling from source every time or waiting for a next release to be available.
It would also be a way to detect build failures caused by errors in the packages, like new dependencies that have not been specified as required in the generated packages.

@thefosk happy to lend a hand if you need help ;). I think an initial step towards this is to include your Dockerfile in the kong repository, right?

Not necessarily? We don't want the nightly builds to only be Docker. In fact the Dockerfile was in this repository but we decided to split it, and consider it as yet another distribution (package builders are separated, AWS AMIs too, Homebrew too etc...). In fact, since we are working towards an official Docker image I think those must be in their own repository anyways (might be wrong on this).
The point is, we just want to consider Docker as a distribution among others, and let people who use Docker discover the Docker way of using Kong. Nightly builds should ideally consists of the packages too.

On another note, what should nightly builds be exactly? If was thinking of building the next branch of the upstream repo as well as be able to manually trigger a build for a hotfix (or other) branch, like we did yesterday for testing the URI encoding fix.

@thibaultCha if the Docker file is in another repo then I don't see a clear way of using Docker Hub, unless a hook chain is in place, which honestly does not look right to me. Anyhow, I see your point about considering Docker just another way of distributing Kong and looks to me like you need something like Jenkins/Bamboo/Travis but you're probably using some of those ;)

Oh no but I wouldn't want to use Dockerhub for the nightly builds. Ideally yes, Jenkins/Travis which we already use and the jobs should perform several builds including the Docker one, and those should be available somewhere, like nightly.getkong.org (really just an example, just saying we should host them somewhere).

Looks good to me. Happy to help in anyway possible ;)

Currently when building our releases, we do the following things:

We tag a new release for Kong
We execute the build-package.sh script at https://github.com/Mashape/kong-distributions telling it which tag/branch to build, and that creates the pkg, rpm and deb packages.
After we upload the packages into our Releases section, we create a new tag in https://github.com/Mashape/docker-kong updating the configuration files accordingly, create a new tag in DockerHub, and trigger the build.
Then we manually update the AWS AMIs.
We also update manually Luarocks, Homebrew, and Bintray packages.

In order to have a fully automated nightly builds, we need to change some things:

The scripts are https://github.com/Mashape/kong-distributions assume they will be running in a OSX system, which I don't really like. The script should start an OSX Vagrant instance when building the pkg package, and the only requirement on the build machine should be Docker + Vagrant. Or they should only start OSX into Vagrant with built-in Docker support inside, so that the only dependency would be Vagrant.
The script is very slow, and builds should be parallelized.
Our Docker repo currently has its own configuration file stored in a folder. We should use sed to change those couple properties that need to be changed for Docker, so that we can run on any configuration file, even if it's being modified across multiple major releases.
Docker expects the files to be in a GitHub release - we may want to change this because when building packages for a branch/release that doesn't necessarily mean we have a release.

Updating the AWS AMIs, Homebrew and Bintray is a process that we can relegate to the official releases, so we may decide not to automate them in our Nightly builds (although if there was a script to execute them, that would be great).

About Docker and Nightly builds: those should probably not be pushed to Dockerhub, hence I don't think tagging the release is the way to go. We could simply provide the Dockerfile, updated to point to one of Kong's branches or tag. "Edge release" (because it'd be nice to not just do nightly, but also provide testing releases like yesterday) users could simply get the Dockerfile, and build the image.

 (2) Kong nightly builds

There are nightly builds for Kong these day! :D https://bintray.com/kong/kong-community-edition-nightly


Custom task callbacks not take effect.

This is my dir with default custom task location
├── custom-tasks
│   ├── after-cleanup.yml
│   ├── after-code-update.yml
│   ├── after-symlink.yml
│   ├── before-cleanup.yml
│   ├── before-code-update.yml
│   └── before-symlink.yml

any task in these ymls takes no effect.
Is there something wrong with my configuration?

Take a look to ansistrano_custom_tasks_path variable in https://github.com/ansistrano/deploy#role-variables, the trick is to use playbook_dir ansible variable.


Code is not compatible with most recent yew 'master' code base

I want to use a new version of workers from 'yew'master' - which is working for me.
However, I can't compile it with the current version of ybc. Please spend some time migrating on the recent 'yew' version.
Thank you!

FWIW - you can try this branch:
https://github.com/mneilly/ybc/tree/yew-0-19-update
which is just https://github.com/thedodd/ybc/pull/25 rebased on the latest master.
Also, I have an updated ybc-example repo that works with the above:
https://github.com/mneilly/ybc-example/tree/mneilly/update-to-ybc-yew19
I make no quality claims and haven't done any testing... these are just me trying to get things running so I can experiment with ybc.

Updated 🎉


Contribution flow: Contribute As step is not centered on large screens

Describe the bug
Screens with big resolution have a centering issue for "contribute as" step in the contribution flow (see screenshot below).
Also the value we use for the column width, 24em, is unclear and undocumented.
To Reproduce
Steps to reproduce the behavior:

Sign in
Go to http://opencollective.com/babel/donate/
Enlarge your window's width to something like 2200px
Component starts to shift on the left

Expected behavior
Component should be centered by copying the behaviour that we have for the 3 other steps (step details, step payment and step summary) where we do width={1/5} | width={3/5} | width={1/5}. If that's not possible then a clear explanation should be given about why it's not and the code should be commented to be more understandable.
Screenshots

Additional context
This issue is a follow up of https://github.com/opencollective/opencollective-frontend/pull/1681#discussion_r280721416

This will be addressed in the new contribution flow


Set various entities with 'diagnostic' entity category?

There are quite a few entities which are not measurements that a user wants to monitor normally, they are diagnostic indicators. These include most of the "PVS" entities, but could include others.
I'm happy to send a PR to add entity_category: diagnostic to these entities if that would be welcome. A side effect of this is that these entities would no longer appear in the default dashboard, so users would need to go to Settings -> Devices -> PV Supervisor  to see them (or of course they can be explicitly added to a dashboard).

Happy to take a PR with that, seems very reasonable.  A quick read here: https://developers.home-assistant.io/blog/2021/10/26/config-entity/#entity-categories makes it seem like a great addition.

this is now released...  now to see how people feel about my choice of 'diagnostic' (/me prepares fireproof suit)


Please review my Professional Portfilio

Hi there,
Please review my professional portfilio:-
Click here
Or
https://pulkitsinghdev.github.io

@eddiejaoude sir please review my github profile and let me know how is it ?

Wow super cool!!! I loved your portfolio, this is what I want to see ^_^. You motivated me to edit my Portfolio
Maybe add more features? Like your favorite Projects (that you can explain to somebody?)

Thanks, will surely try to add some of my projects as well :)

This is impressive, a couple of things I've noticed:

Freecodecamp icon is broken
The landing page is a bit laggy when moving your cursor over elements, it can be because of the background animation

 I don't think that free code camp 's icon is broken

Would like to tell you that background's image is an gif image and it's not any animation :)
and Thank you so much for your reply

This is impressive, a couple of things I've noticed:

Freecodecamp icon is broken
The landing page is a bit laggy when moving your cursor over elements, it can be because of the background animation

Oh, okay.....but it may not show for some users

Thanks for sharing, I will review on a live stream soon 👍

Thanks for sharing, I will review on a live stream soon 👍

Thank you so much sir :)

Maybe consider checking the console errors, your portfolio is throwing out

DevTools failed to load SourceMap: Could not load content for https://pulkitsinghdev.github.io/assets/vendor/swiper/swiper-bundle.min.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

Also the highlighting hover feature is not working correctly if I directly more from one card to another

Hi everyone, as I have got many bugs in the website, The website will be down for some time and will let you all once it's ready :)

Why not keep it up :)

You could work on your site in the meanwhile. Having one kinda helps you out.

I have fixed the bugs, is it now working correctly ??

The website looks amazing!!
One thing I noticed was the menu bar tilting on hover provides a bad user experience, try something else there?

I would strongly recommend removing these - let your projects speak for your proficiency :)

Changing the voice/perspective feels a bit clunky imho

Buttons overlap here

I think that it is a bit distracting when I try to click on one of the navigation bar links and this happens

I agree with @Rahma-AlWadhahi - interactable elements should not move when I try to interact with them.

That title is too long, maybe shorten it up.

The tilting menu bar is distracting.

Replace 'him' with 'me' or 'Pulkit'

The tilting is distracting, not the best design choice here. The space in the parantheses is irregular. Figure out a way to not use links as texts.

Get rid of the blue link.

Taka a look at the mobile view of your website

Some Improvements to consider!

Since the animation is a gif it becomes choppy on initial load, and also after staying on the website for a long time!
Maybe consider changing it to a CSS Animation
Also please improve the mobile responsiveness of the website!

Thank you for sharing, reviewed on live stream https://youtu.be/ugEJ8LBb1r0
Website

audio auto plays, not great UX
typewriter text for the longer text for example cloud computer enthusiast the text bounces to the 2nd line multiple times
testimonials are great 👍

repo

looks great: use of releases, description, link, tags 💥
filenames are inconsistent, suggest using a single style
syntax highlighting for the html code

To quote @adityaraute

I have heard about this website where you can check the color contrast. Contrast Ratio

I have heard about this website where you can check the color contrast. Contrast Ratio. You can check that to help test the colors before using them in the website.
Testing colors also is implemented into lighthouse (integrated in chromium based browsers)

Simple Addition To @eddiejaoude's comment:

The Social Icons Are Not Spaced Up.
The Icons are hard sized. They stretch up

Solution
.icon {
display: flex;
justify-content: space-evenly;
align-items: center;
min-width: 0; // Add A Min Width That Suits The Need.
min-height: 0; // Add A Min Height That Suits The Need.
}

Thank you so much everyone :)
I will take a look on each and everything you all mentioned and will resolve it as soon as possible :)


[Improvement]: Implement and Deploy Citrus Test for Choreo Deploy and InvokeURL monitor using Azure functions

Connector Name
other (None Listed Above)
Suggested improvement
This will be the 1st monitor of the set.
Related issues
No response

closing as this was completed


typo in U256 multiplication

Closes https://github.com/FuelLabs/sway/issues/3567

Excellent, thanks! Do you mind just adding the failing test from #3567 to our test suite?

Excellent, thanks! Do you mind just adding the failing test from #3567 to our test suite?

Done


How to do file upload mutation?

How does one include a file upload in a mutation?
Awesome project btw.

Related apollostack/apollo-client#586

thanks @kamilkisiela  i looked into that but i have a hard time transferring the idea in the referenced tutorial to angular 2. especially this bunch of code:
           for(let { node, path } of new RecursiveIterator(request.variables)) {                  if (node instanceof File) {                     const id = Math.random().toString(36);                     formData.append(id, node);                     objectPath.set(request.variables, path.join('.'), id);                 } }
i'd appreciate an example using angular2apollo. Thanks
Peace

Thinking in scalable architecture designs I prefer to directly upload to s3 or a comparable cloud asset service. Some services even provide resizing etc. Thus my way to go is to make a request to graphql returning a s3 signed hash token which can be used for a direct upload to s3. Sample see froala editor s3 upload. Gonna implement something similar in the next days.

@manuelfink Can you please share your solution?
If you are using a newer version/method I would prefer that one. ;)

It's more related to apollo-client and graphql server implementation than to apollo-angular


Bump vulnerable dev deps

quick PR to (try to) get rid of:

Oh boy, our ci deps are in a big mess. @JamesCropcho have you ever ran into issues like this one?

@etpinard I suspect the issue is that we are using the same keys to save caches for Node v6 and v8.

Closing in favor of Closed in favor of https://github.com/plotly/image-exporter/pull/71


Building release 1.2.0

@fpesce: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
72012aba23b1ed5a77d793d885e7dfbc02353fe6
link
/test release-e2e-bookinfoTests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fpesce: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
72012aba23b1ed5a77d793d885e7dfbc02353fe6
link
/test release-e2e-bookinfoTests

prow/release-e2e-mixer-no_auth
72012aba23b1ed5a77d793d885e7dfbc02353fe6
link
/test release-e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-e2e-bookinfoTests
/test release-e2e-mixer-no_auth

@fpesce: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/release-e2e-bookinfoTests
72012aba23b1ed5a77d793d885e7dfbc02353fe6
link
/test release-e2e-bookinfoTests

prow/release-e2e-mixer-no_auth
72012aba23b1ed5a77d793d885e7dfbc02353fe6
link
/test release-e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test release-e2e-bookinfoTests
/test release-e2e-mixer-no_auth

/test release-e2e-mixer-no_auth


Attempted import error: 'Preview' is not exported from 'sanity' (imported as 'o').

<EMAIL_ADDRESS>Attempted import error: 'Preview' is not exported from 'sanity' (imported as 'o').
I am attempting to add Orderable Document List to nextjs-blog-cms-sanity-v3.
I also notice that the docs on sanity.io and github are different, and SructureBuilder is imported but not used.
When I am at /studio it lists Orderable post, Orderable author, etc. When I click I get this error: Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports..
Is there a working example of this plugin in Sanity Studio v3?
Thanks!

I was able to fix this by using the latest versions of sanity and orderable document-list.
    "sanity": "^3.0.0-rc.3",
    "@sanity/orderable-document-list": "^1.0.1",


gh-2119 Add Create Input Array to Join Operation

#2119

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@8e67628). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             develop    #2123   +/-   ##
==========================================
  Coverage           ?   66.33%
  Complexity         ?     2256
==========================================
  Files              ?      890
  Lines              ?    29306
  Branches           ?     3660
==========================================
  Hits               ?    19439
  Misses             ?     8376
  Partials           ?     1491

Impacted Files
Coverage Δ
Complexity Δ

...a/uk/gov/gchq/gaffer/operation/impl/join/Join.java
92.72% <100%> (ø)
19 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e67628...bcfd172. Read the comment docs.


CI: enable commit msg check

this pr use https://github.com/GsActions/commit-message-checker with regex as implementation.
Signed-off-by: Sam Yuan<EMAIL_ADDRESS>

resolve #253

What are the magic format look like? Should the format be documented?

What are the magic format look like?

https://www.kubernetes.dev/docs/guide/pull-requests/#commit-message-guidelines
it's not any magic format, as it discussed in #253 , pre discussed with @marceloamaral before, we want to have some commit message check to ensure commit message is meaningful.

Should the format be documented?
good idea.

lgtm
@marceloamaral any feedback?


chore(theme-default): remove unused styles

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.66%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1002

Relevant Lines:
1582

💛  - Coveralls


Propose: Parallel await

var a = await {
  yield 1;
  yield 2;
  yield 3;
}

// a == [1,2,3]

var a = await {
  for(var i=1;i<=3;i++)
  {
    yield i;
  }
}

// a == [1,2,3]

// consider existing async function loadfile(filename)

var a = await {
  for(var i=1;i<=3;i++)
  {
    var file_content = await loadfile(i+'.json')
    yield JSON.parse(file_content);
  }
}

// a is an array with contents of 1.json, 2.json and 3.json, every parsed to Javascript objects

Important: This is just a draft. If you like this idea explain better in your standards.

I like this capability but it should stand as a separate proposal now that this has advanced to stage 3. Thanks for the suggestion!

Wouldn't this just be:
await Promise.all([1, 2, 3])


Typo

Under config>system>secret tools the display debug tools option is misspelt as display debug toosl

Fixed for next release.


How to init net parameters for sphere net when train from scratch

Hi clcarwin,
I cannot see any code to initialize when create the net.
What initialization method should I choose when use Spherenet except in AngleLinear?
Will the below method be ok for sphere net?
def weights_init(m):
    classname = m.__class__.__name__
    if classname.find('Conv') != -1:
        m.weight.data.normal_(0.0, 0.02)
        n = m.kernel_size[0] * m.kernel_size[1] * m.out_channels
        m.weight.data.normal_(0, math.sqrt(2. / n))
        if m.bias is not None:
            m.bias.data.zero_()
    elif classname.find('BatchNorm') != -1:
        m.weight.data.fill_(1)
        m.bias.data.zero_()
    elif classname.find('Linear') != -1:
        n = m.weight.size(1)
        m.weight.data.normal_(0, 0.01)
        m.bias.data.zero_()

thanks

Maybe the init is not necessary. It is needed to try by yourself.


[SPARK-14634][ML][FOLLOWUP] Delete superfluous line in BisectingKMeans

What changes were proposed in this pull request?
As commented by @jkbradley in https://github.com/apache/spark/pull/12394, model.setSummary(summary) is superfluous
How was this patch tested?
existing tests

Test build #67502 has started for PR 15619 at commit 81460d4.

Test build #67503 has started for PR 15619 at commit 03f6a47.

Test build #67502 has finished for PR 15619 at commit 81460d4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67502/
Test PASSed.

Test build #67503 has finished for PR 15619 at commit 03f6a47.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67503/
Test PASSed.

LGTM, merged into master. Thanks!


Debug log is in INFO not DEBUG

2023-09-05 21:35:34,566 [5900545]   INFO - Discord - Scheduling render, force=false
2023-09-05 21:35:34,566 [5900545]   INFO - Discord - Render result: hidden

Resolved by 430e61763e754a1aaf83cc861685bbc2bed344a5


Fix public pages description

Fixes #2985

Also fixed the geocoder modal tab pane title while at it (#2985):

:es:

Go go go

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)


Planning for Usability Session

Planning for Usability Session:

[x] Book viewing room
[x] Book testing room
[x] Send out recruitment email
[x] get amazon vouchers
[x] check bluejeans set up working
[x] get consent forms/script
[x] write script for 30 min session
[x] create form to say money received? (Check if needed).
[x] email team with viewing room invitation

Aims: To gather qualitative feedback on new website features including: (this list will be edited once planning is nearing completion)

Exhibition pages
Events page
how well do users understand the information presented at the top of the events pages?
is the order of information logical?
where do users want to click through to from these pages? (are they searching for more information that they can't see/find on the page?)

signature to say payment received is within the consent form to allow recording of the session.

Session planning complete - new ticket for actual session info. #1647


Discovering all services

Hi,
The plugin works great to discover service by known types, for example
zeroconf.watch('_http._tcp.', 'local.', function(result) { ...
It works perfectly on android and ios.
But is there a way to discover for exemple all _tcp. services ?
I tried:
zeroconf.watch('_tcp.', 'local.', function(result) {
...nothing
Any idea ?
Regards,

Hi,
I don't know if _tcp. alone is allowed by the protocol.
Could you try _services._dns-sd._udp. as it seems to be a special type to query all services.

I try this tonight !
Le ven. 10 févr. 2017 à 18:44, becvert<EMAIL_ADDRESS>a écrit :

Hi,
I don't know if _tcp. alone is allowed by the protocol.
Could you try _services._dns-sd._udp. as it seems to be a special type to
query all services.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/becvert/cordova-plugin-zeroconf/issues/24#issuecomment-279012806,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJns_-oEzhGuHEiMV2Poqb14hUavXMwXks5rbKINgaJpZM4L9nAy
.

nothing more, I wanted to list all services to see if I can find my custom type created by https://www.npmjs.com/package/bonjour
ex: _myType._tcp. itdoes not work too, if I change the type to http it works.
I'm going to search a little with command line tools

OK. I'll do my own tests tomorrow.

In fact it works !
I saw my custom service but after a very very long time (may be 5 minutes) on an android tab.
After killing and relaunching the app the services appear after 15/20 seconds
I'm still waiting to see it on my iphone...
I think I saw a similar issue so you may close this one
thank you for all

Hi, this morning I tried to publish the service via avahi instead of the nodejs bonjour module (npm bonjour) and both ios and androïd devices find it in a very short time.
Sorry for the noise ! and thanks for all


kubectl documentation does not mention POD_NAMESPACE or inside-kubernetes-cluster mode

This is a Bug Report

Problem:
Apparently kubectl has two hidden features with respect to what it uses as the default namespace for commands:

If POD_NAMESPACE environment variable is set, then it uses that.
If KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT environment variables are set, and there is a service account token file mounted at "/var/run/secrets/kubernetes.io/serviceaccount/token", then it uses its pod's namespace by default.

These were not clearly documented, resulting in confusion that lead to https://github.com/kubernetes/kubernetes/issues/99884
Proposed Solution:
Add this information to the kubectl documentation.
Page to Update:
https://kubernetes.io/docs/reference/kubectl/overview/ (or one of it siblings)

/sig cli

/remove-lifecycle stale

Yea this is coming from clientcmd.
https://github.com/kubernetes/kubernetes/blob/ea0764452222146c47ec826977f49d7001b0ea8c/staging/src/k8s.io/client-go/tools/clientcmd/client_config.go#L582
This might help https://github.com/kubernetes/kubectl/issues/927#issuecomment-693483957.

/assign @geoffcline
teamwork makes the dreamwork @eddiezane

If KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT environment variables are set, and there is a service account token file mounted at "/var/run/secrets/kubernetes.io/serviceaccount/token", then it uses its pod's namespace by default.

can someone explain this just a bit?
This is what I'm getting

If you are ssh'd into a pod (as defined by having these env variables defined, and a service acct token), then the cli uses the pod's namespace by default.

can someone explain this just a bit?

I wrote it down in https://developers.redhat.com/blog/2020/11/20/kubectl-developer-tips-for-the-kubernetes-command-line#
@geoffcline hope that might clear it a bit :)

The original post in this thread also covers what the envs are a bit.
IMHO the two things that trip users up here to be well aware of are:

If you are using kubectl in a way that you depend on the default namespace (none of your yaml or commands specify the namespace), it will no longer be the default you typically have if that was unset, it will instead be the namespace of the pod you are running in.

If you meant to interact with another cluster and fail to configure access (e.g. due to some bug in your tooling) you may accidentally try to instead run commands against the cluster you are in

Also probably useful for documenting this: https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#use-the-default-service-account-to-access-the-api-server
It is possible to disable this behavior by configuring either the service account in the cluster or the pod with automountServiceAccountToken: false. See also this thread https://github.com/kubernetes/kubernetes/issues/57601

It is possible to disable this behavior by configuring either the service account in the cluster or the pod with automountServiceAccountToken: false.

Of course, this doesn't really help if another container (perhaps one injected via a hook) is expecting the token file.


Opinionated client libraries

The intent of this change is to make Netty HTTP client the default for all client libraries as this is the most common scenario for non-Android users. For Android users, Netty can be excluded from the dependency and OkHTTP can be included.
Fixes #5511

Fixes #5511

/azp run java - keyvault - ci.data


ESM version exposed to environments that don't support ESM (e.g. jest 28)

Describe the bug
The package.json exports field declares that for envrionments other than node, only the ESM version of the library can be used. The CJS version of this library is exposed to node, but not to browsers.
Jest v28 with jsdom will honour exports, but does not babelize files in node_modules. Therefore it will crash if you import this library.
  "exports": {
    ".": {
      "default": "./dist/esm-browser/index.js"
    },
  },

How to reproduce
Run this script:
# install jest and uuid
yarn add jest jest-environment-jsdom uuid

# create test scenario
cat << TESTFILE > ./tests.spec.js
test("should import uuid without crashing", () => require("uuid"));
TESTFILE

yarn jest --env jsdom

Expected behavior
non-nodejs CJS code that imports uuid should receive the CJS version of the library.
Runtime

OS: macOS
Runtime: anything other than node that honours package.json exports but doesn't have ESM support enabled e.g. jest 28
Runtime Version: [e.g. 14.2.0]

Additional information
[Any other information or comments that you think will help]

Duplicate of #616, right?  (If not, please comment why and I'll reopen.)


Website - Show User who are not using EasyCloudBooks

Currently only staff comes up on webiste
Client wants to show Users on website, but he/she is not using Easycloudbooks, this is just website team show purpose
Initiated by @vinpahilwani
Verified by @mitulpanch

ACId - 485

Staff should not be charged, in monthly billing, as these are just to show on website