Add some recordings params

Add RecordingChannels, RecordingStatusCallback and RecordingStatusCallbackMethod params to make calls

I just merged another PR that came in a few hours before yours and it conflicts with your change. Can you rebase against master and comment on this thread?

@sfreiberg done :)

@hesidoryn Thanks!


Fix lua_*upvalue() when upvalue names aren't in debug info

lua_getupvalue() and lua_setupvalue() don't behave as expected when working with Lua closure whose Proto has no debug info. The code currently uses sizeupvalues to do bounds checking of upvalue indices, but that's the size of the upvalue names array. It will always be 0 if the Proto doesn't have debug info.
This uses nups instead, and just returns "" as the upvalue name if we don't have one, same as for C closures.

Add a unit test that only passes with the code change?

Good call, added a test that compiles a script with no debug info, then yields in the middle of executing a closure to examine its upvalues.


Uploader submission confirmation page shows file name.

Problem statement
As someone who used the RS CSV upload feature to submit data to public health authority, I would like to see the name of the file I submitted on the confirmation page.
What you need to know
File name comes through on the upload and submission page.
Acceptance criteria

[ ] File name is visible on the confirmation page.

To do

[ ] ...

This ticket is being added to the list for consideration for Simple Report. Closed as experienced ticket.

This ticket is being added to the list for consideration for Simple Report. Closed as experienced ticket.


selecting -- as option in a new form results in _ in postag

Reported by @gcelano
A student has found an error in how the positive/comparative/superlative feature is saved, in the sense that when --- is selected ,instead of having a dash - saved, an underscore _ is saved. This of course creates problems when I try to compare the annotations because the two characters are different.
This is kinda important, because otherwise I get ptoblems with evaluating their annotations. If you can change it as soon as you can, that would be great. Thanks.

not sure if this is a tagset problem or an arethusa problem, quite possibly the former.

@gcelano - I'm not sure but I think this is maybe a long standing problem with creating new forms, and it's not limited to superlatives.  I.e. if you create a new noun form, for example, and leave any of the options (case, number, etc.) as -- you get an _ saved in that place in the postag.

It seems the problem comes from the underscore assigned to postag.
I've created a pull request.

@gcelano please see comments in #694


[ci skip] Implement renovate and remove dependabot

Mentioned by riley in discord, this PR remove the dependabot config and implement the configuration for renovate.
In concradiction to https://github.com/PaperMC/bibliothek/pull/129 this PR try to migrate the configuration in dependabot, testing with a validator founded in google...

i think i cannot test this in forks... but based in docs can work.

Thanks! Can you rebase off the renovate/configure branch instead?

Thanks! Can you rebase off the renovate/configure branch instead?

i reset to the another branch and make the changes base in this, moving the file to .github (mostly like a standar based in how dependabot has the config in this directory) and change the target of the PR.

this changes are still need or wanna keep the default renovate config?


Add possiblitity for second device in one Home Assistant-Instance

Is your feature request related to a problem? Please describe.
I do have to Stiebel-Eltron Heatpumps that i want to manage in one home assistant instance. Sadly this is not possible, because the device and the entities from the second device get the same unique_id´s that the first one gets.
Describe the solution you'd like
Please Add a "name" oder "device_number" to the config flow that ist added to the unique IDs so that it ist possible to add multiple instances.
Describe alternatives you've considered
I tried to fork your repository and do it my self, but i´m not skilled enough for that. :(
Additional context
I really LOVE your Stiebel Eltron ISG-integration. Thank you so much!

Could you please check if this is working for you in the new release 0.1.0?

Thank you for your fast answer.
I found my own solution via modbus: in configuration.yaml. That works perfect.
To test you update i:

freshly downloaded and installed version 0.1.0 via hacs
removed my solution via configuration.yaml
restarted home assistant
startet adding both heat-pumps via you integration

This was the result:

I hope that helps

Testet it with both my Heat Pumps and got NO errors because they could be added without a problem. Works like a charm.

Thank you for adding this feature! ❤


Add ability to include and filter via detail fields on pages' list endpoints

Is your proposal related to a problem?

There is currently no way to "find" pages via fields (the typical example being by slug and retrieve the values for "detail" fields of the model in one go: you have to use the list endpoint to search, retrieve the ID, then use the ID to call the detail endpoint and retrieve the data. This is extremely wasteful considering how common this operation is, and I'm not aware of any better alternative.
Describe the solution you'd like

As alleged¹ in the answer to the aforelinked SO question citing a Slack response, Wagtail itself runs into this issue and solves it by expanding the PagesAPIViewSet. Instead of forcing users of Wagtail's API to do this themselves for every project, a generic solution could be integrated into PagesAPIViewSet itself.
It would be helpful if any user who already wrote a solution to this for themselves or is already familiar with that part of Wagtail's code would share their code in a PR so that everyone can use it.
The features needed would essentially be:

When a fields query parameter is supplied to the list endpoint, lookup the fields in the specific() model.
When an individual field is supplied in the query parameters with a value to match it (e.g. ?slug=my-slug), the value is looked up in the specific() models instead of the reduced list version of it.

¹ The links to the old Wagtail docs and code are now dead.

As a note for anyone wanting to attempt this, I solved it in my own project with the following:
# The wagtail_router points to this class instead of PagesAPIViewSet.
class BlogPagesAPIViewSet(PagesAPIViewSet):
    # BlogPost is a Page subclass. The default PagesAPIViewSet.model is Page itself,
    #  so fields that are specific to BlogPost are not found by the methods that use
    #  self.model to check for its fields.
    model = BlogPost

I plan to have separate API routes (hence separate ViewSets) for different kinds of pages, but a general solution would need to somehow have the specific model in place of PagesAPIViewSet.model, or get it at runtime wherever relevant instead/on top of using PagesAPIViewSet.model.

This gets a bit more complicated in that we'd need to iterate through all Page models and use Q objects, but only if the field is defined on the specific Page model.
Your separate API routes approch is the right way, IMHO and perhaps what we need to do is add a recipe to the docs, rather than make PagesAPIViewSet do everything

I agree, since it's a simple solution anyway, but I can't shake off the thought that having the detail and list endpoints behave so differently violates the {principle of least astonishment](https://en.wikipedia.org/wiki/Principle_of_least_astonishment) (having been baffled by it myself very recently when I found out).
A documentation addition is certainly a sufficient "solution" in the short term, but if a real one can come baked into Wagtail without considerable drawbacks, I think it would be nice to have it. In my case, I had to subclass and separate the viewset for other reasons too, but the typical user probably needs this feature even on its own (I find it very likely that someone using Wagtail headlessly also wants infinite scrolling, for example).


DBZ-7368: add more documentation for converters in outbox router

Re-structure and add more documentation about setting up the converters in the Outbox Event Router SMT. My objective is make it clear how to properly use JSON and Avro regarding the value converters, the db column types, and the delegate converter configuration.
I'm also adding an extra example of how to setup a delegate converter in Avro format.
Needless to say, this is just a suggestion and is open to any comment or recommendation.
Jira DBZ-7368

I've started a review, but was unable to finish today. I'll complete the work tomorrow (1 FEB).
Please hold off on merging pending the completed review. Thanks.

Thanks @roldanbob for the thorough review. The result exceeds my original expectations. The only remaining question is about Apicurio Registry vs Schema Registry.

Thanks @roldanbob for the thorough review. The result exceeds my original expectations. The only remaining question is about Apicurio Registry vs Schema Registry.

Oh, great. My comment about Apicurio comes from the Red Hat perspective, since I'm familiar with it bc one of my colleagues works on the documentation for it. But I realize that you might have intended a generic reference. Assuming that's the case, and you weren't referring to a specific project, I've modified my original comment to use lowercase
s and r to indicate a generic vs. specific project or product.

@enzo-cappa ICYMI, in my last comment, I identified an extra space on L34. Other than that this LGTM. Thanks!

Thanks for the review, @roldanbob. My part of this PR is ready to be merged whenever you consider it appropriate (I don't have write access).


Pstrunc/3365 role req

https://redmine.czechidm.com/issues/3365

You are my hero and gigachad.

Code review OK.


NeonScience clone

This PR fixes the issue Clone this webpage #655.
Kindly review it sir

@SupriyaGembali Make it responsive

@SupriyaGembali complete it in 2 days.

@SupriyaGembali any updates?

@SupriyaGembali i am merging this PR because u had done a great work but make it responsive and make another PR

@SupriyaGembali  #734

@SupriyaGembali  check #734


Add Softmax::validate_and_infer_types

Currently element::Types and Shapes are not propagated for Softmax. This adds Softmax::validate_and_infer_types to fix that. Without this, bf16 support via provenance metatype tags in NNP does not function correctly as the assumption is that types will always be inferred when validation is run.

Thank you!


how to preserve empty line?

set "htmlOptions. preserve_newlines = true" is not work. thinks your help.

hi @dworld can you show an example of what you try to accomplish?
Can you try your code here as well? http://requirebin.com/embed?gist=0d67452e01754269660f

input:
var foo = React.createClass({
  render: function() {
    return (

      );
  }
});

output:
var foo = React.createClass( {
  render: function () {
    return (

    );
  }
} );


Public routes doesn't trigger token refresh

Frontend is sending auth token with every request and when 401 (auth.guard) returned sends a single attempt to refresh token.
Though if route is public refresh token isn't happens and auth.guard pass execution to visibility.guard witch returns an error for private or unauthenticated group/event.
Proposed solution is handle token expiration (if provided) before checking for isPublic decorator.

Thanks for catching that.  I'll have to look into it.


Would like panning to stop at outer edges

Notice how I can drag the map until there is no data. Can boundary detection please be implemented to avoid this? If you have it already let me know which attribute to pass in where.

@zimrick, any ETA on this?

There are a couple of issues with this feature. The way panning works right now, if you prevent it from going out of bounds, you will have issues when setting the center of the map to any place towards the edges of the map.

In that case, (i.e. say you are centering near an edge and the svg dimensions exceed the world map...) maybe you implicitly apply a translate and wrap the world map around along those edges.

Do you have any news on that problem?
Are you working on that?
I will need to implement something like that and not sure how to handle it.
Do you thing i will be able to find a way to do that with the current features (zoom and center)?
Thanks!

I have been looking into this issue. It's a bit complex, given how other functionality of the library is handled (setting center and animation), also in terms of how it integrates with other libraries, like react-motion and how state is managed. I would really like to see this feature, hence I am also keeping this issue open, but it will likely require some more thinking.
Unfortunately I also don't think you can create anything like this with zoom and center at the moment, as you don't have a way of hooking into panning and zooming events.

Is this something that has managed to be implemented yet? If not is it possible to disable panning, but keep the zoom effects from react-motion?

Hello all! I was wondering if anyone has come up with a solution for this yet? I would be eager to hear :)

Hello all! I was wondering if anyone has come up with a solution for this yet? I would be eager to hear :)

Hi @LaikaTheSpaceDog,
Does this codesandbox solve the problem you are trying to solve?
https://codesandbox.io/s/react-simple-maps-constrained-panning-3tr6z?file=/src/MapChart.js
Let me know if this helps

Hi @LaikaTheSpaceDog,
Does this codesandbox solve the problem you are trying to solve?
https://codesandbox.io/s/react-simple-maps-constrained-panning-3tr6z?file=/src/MapChart.js
Let me know if this helps

@zimrick that was a massive help. thanks a lot!

@zimrick that was a massive help. thanks a lot!


added callback onNextStep and onPreviousStep, to get notified when a …

Added two callbacks to get notified when a user moves to the next step on back to a previous step. Useful to be able to trigger certain events based on which step that is visible

+1

+1 for sure!


ASP.NET Profile Properties Overview (not fully correct example)

Link to article:
Problem:
On the Page shown example, which won't work without additional code. Are commonly, when user testing anything features from "Microsoft Doc Site", it used simple Web Site without users authentication. In this case, that example  won't work.
Please add comment regarding that this example will work only if site used by authenticated users, and make link to the page "User Identification for ASP.NET Profile Properties", which describing it more detail.

@scottaddie FYI

@DSivtsov "We're no longer updating this content regularly."
#please-close


Make leader redirection work when both plainText and TLS ports are set

When both plainText and TLS ports are set in druid, the redirection to a different leader node can fail. This is caused by how we compare a redirect path and the leader locations registered with a druid node. While the registered location has both plainText and TLS port set, the redirect path only has one port since it's a URI.

Build failed. Seems to be a flaky IT. Restarted that one test.


Google Log In not working

I can not log in with Google when I deploy the application (doesnt matter if Debug or Release deploy).
The Google log-in works on local build but it does not work after deploying to production machine.
The localhost and the domain are both whitelisted in the Google Developer Console (http and https).
Log:
      Request starting HTTP/1.1 GET http://xxxxxxxxx.com/signin-google?state=xxxxxxx&code=4
/yyyyyyy&authuser=0&session_state=zzzzz&prompt=none
info: Microsoft.AspNetCore.Authentication.Google.GoogleHandler[4]
      Error from RemoteAuthentication: OAuth token endpoint failure: Status: BadRequest;Headers: Vary: X-Origin, Origin, Accept-Encoding
      Date: Tue, 19 Dec 2017 13:48:23 GMT
      Cache-Control: max-age=0, private
      X-Content-Type-Options: nosniff
      X-Frame-Options: SAMEORIGIN
      X-XSS-Protection: 1; mode=block
      Server: GSE
      Alt-Svc: hq=":443"; ma=2592000; quic=51303431; quic=51303339; quic=51303338; quic=51303337; quic=51303335,quic=":443"; ma=2592000; v="41,39,38,37,35"
      Accept-Ranges: none
      Transfer-Encoding: chunked
      ;Body: {
       "error": "redirect_uri_mismatch",
       "error_description": "Bad Request"
      }
      ;.
   at Microsoft.AspNetCore.Authentication.RemoteAuthenticationHandler`1.<HandleRequestAsync>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.<Invoke>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Localization.RequestLocalizationMiddleware.<Invoke>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at NetEscapades.AspNetCore.SecurityHeaders.Infrastructure.CustomHeadersMiddleware.<Invoke>d__7.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Joonasw.AspNetCore.SecurityHeaders.Csp.CspMiddleware.<Invoke>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Hosting.Internal.RequestServicesContainerMiddleware.<Invoke>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Frame`1.<ProcessRequestsAsync>d__2.MoveNext()

Uncommenting the signin-google route does not solve the issue and also causes issues with the Steam OAuth login.

@Trojaner25 does google allow you to have multiple domains and callback urls against same application. For production I have seperate google app created with its own domain and callback and it works fine.

Thanks for the fast response.
I will try and report back

I have set up a new google app (removed the domain from the other app) but I still get the same error message

ahhh, it must be this line then. Better if this is a configuration coming from appsettings.json as well. I will update that. But meanwhile try by changing this. Note, if you have already seeded the database, you need to update your datastore accordingly.

Hi Asadsahi, I think this may be related to my issue #180 where I posted the problem and the fix.
Regards

@Trojaner25 @pvagnini  This setting is in appsettings.json and appsettings.Development.json based on which environment you are configuring. also, this should fix  couple of other issue. Let me know if you find any other issues.


Openssl doc update: Removed note for KeyUsage and ExtendedKeyUsage

Closes #3726

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/5bd7175487297f66540772a6aecaea9180158d16/

LGTM


Changing the mask dynamically?

I have a form where the mask for some fields might vary based on the current value of another form field. Basically I'm trying to have country specific masks for things like area code, phone number, ssn etc, and country is an editable field.
<InputMask @bind-Value="M[fld.Name]!.StringValue"<EMAIL_ADDRESS>/>
I've verified that the mask values are updating correctly, but they are not being applied. I think the mask is applied only on first render of the component?
Can there be a parameter to change that behaviour, or is there some other issue that would prevent it working?

Hello, you can try by putting a @key value directive to the input Mask. If it still doesn't work maybe you can send some more code ?

Hello,
Sorry for the late reply !
I have added a function updateMask (also in latest nuget), please see here for details:
https://github.com/raphadesa/BlazorInputMask/blob/master/BlazorInputMask/Pages/Index3.razor

Thanks, I will have a look at it. But it looks like, to update the input mask, I need a have a reference to the inputmask component.
This may be my lack of experience with Blazor, but I'm finding it very awkward to work with component references. The content of my component is built dynamically from backend parameters. Usually to obtain a component reference you declare a settable property in your component and use the @ref attribute to target that property. But I don't statically know what instances of inputmask I will have.
I already ran into this problem because I am interested in the raw input value which I can only get via the inputmask reference.

Hello, you're absolutely right !
Based on your feedback I've implemented an event OnChange,  which returns both the value and the mask raw value.
See here for more  details: https://github.com/raphadesa/BlazorInputMask/blob/master/BlazorInputMask/Pages/Index.razor


show-config

cli option would show currently selected config values.
is it something that makes sense?

Easily implemented. See also https://github.com/haxmeister/funtoo-reporter/pull/96.

@ShadowM00n implemented this in pull request #96 (commit b38d1fc, specifically).


Bumped spellcheck version to lastest release 0.30.0

Hello
As the maintainer of the spellcheck GitHub action I am sunsetting version 0.22.1 as by the proposed sunset policy
I just updated the action to version 0.30.0, so this PR offers an update to the latest version.
Let me know if you have any issues with the proposed PR and I will do my best to accommodate.
I can recommend Dependabot for keeping your GitHub actions up to date, alternatively there are Renovate, if you want a PR proposing a basic configuration for Dependabot, please let me know.
jonasbn

Hi,
The Spellcheck action version 0.22.1 will be removed from DockerHub shortly.
REF:

https://github.com/rojopolis/spellcheck-github-actions/discussions/148
https://github.com/rojopolis/spellcheck-github-actions/wiki#sunset-policy


Add bunq_me list

Pull Request Test Coverage Report for Build 131

39 of 39 (100.0%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 98.865%

Totals

Change from base Build 129:
0.2%

Covered Lines:
610

Relevant Lines:
617

💛  - Coveralls

Pull Request Test Coverage Report for Build 131

39 of 39 (100.0%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 98.865%

Totals

Change from base Build 129:
0.2%

Covered Lines:
610

Relevant Lines:
617

💛  - Coveralls


Add intra42 client secret matcher

intra42 is the intranet and API of "42 School", a Computer-Science school.
The API is open to all students in 57 campus around the world. It is thus often subject to credentials leaks on GitHub.
See https://github.com/search?q=s-s4t2ud-&type=code&ref=advsearch for an example.
Public website: https://42.fr
API doc: https://api.intra.42.fr/

Thanks for adding!


Windows: add some WinSock2 constants

This is the bare minimum of the WinSock2 constants that are needed for
the Foundation port to Windows which uses the socket APIs for
-[NSTask run] internal signalling.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test and merge


Manual resolution is still appearing as conflict?

Here in this case I see a "manual resolution" as one of the conflicts, but I am a bit confused: if the conflict was automatically manually resolved, why is it still appearing as conflict?

merge.json.zip

I'm quite sure this goes away with "mergeEditor.diffAlgorithm": "experimental",.

I tried, and it is the same:

This is probably because the result file does not have conflict markers anymore.
Can you add <<<<<<<<<<<<<<\n>>>>>>>>>>>>>> to the result file and try again?

Closing as duplicate of #160801


<EMAIL_ADDRESS>hash check failed

Installing 'hashtab' (<IP_ADDRESS>) [64bit] from DEV-Tools bucket
Checking hash of HashTab_v<IP_ADDRESS>_Setup.exe ... ERROR Hash check failed!
App:         DEV-Tools/hashtab
URL:         http://implbits.com/products/hashtab/HashTab_v<IP_ADDRESS>_Setup.exe#/dl.7z
First bytes: 3C 21 64 6F 63 74 79 70
Expected:    85caa9ea0bb91da273e4d02b5f0a1c1736cc7314c4f2c839882339cc69ddaf10
Actual:      e4759a977d79acbf2b27a5509a0bbf92b16672bfc7d81c23800034c84bcd2e51

@Fumeze  This program was deprecated from the official site, but there are alternatives, namely OpenHashTab is one of them, it is also available through Scoop buckets, via this bucket scoop install anderlli0053_DEV-tools/openhashtab-np or via "official" one as scoop install nonportable/openhashtab-np

I got it, thank you👌

I got it, thank you👌

You're welcome!


Any option to generate to keep separate bin files?

Is there any option to keep the bin files separate, optimizing them individually? Thx

This will automatically happen if the output has a .gltf extension.

Thx for the quick response. We are testing with a source gltf with 300+ .bin files, and even if we state a .gltf output file, we only get a single .bin file.
gltfpack -v -i ../source/model.gltf -o ./out/model.200422a.gltf
results in a folder with a .gltf and a .bin
Here is the output with -v
input: 386 nodes, 363 meshes (469 primitives), 364 materials, 0 skins, 0 animations input: 4444632 triangles, 13333896 vertices output: 705251 triangles, 780699 vertices output: 749 nodes, 363 meshes (363 primitives), 26 materials output: JSON 234412 bytes, buffers 13599896 bytes output: buffers: vertex 9368388 bytes, index 4231506 bytes, skin 0 bytes, time 0 bytes, keyframe 0 bytes, image 0 bytes

Oh - this is by design. gltfpack groups buffer views so it’s not possible for it to preserve the original set of files, this the output is a single bin file for geometry and associated data. I am not sure it’s beneficial to split that without splitting the buffers as to display most parts of the scene you will need most buffers.

Thx. I understand.
But there are some optimizations that, even it not optimal, could still be done in each file at the time, keeping the same number of target files. For instance, we could want to optimize only the number of vertexes and/or quantises in each .bin.
Would this be possible (ie, treat each file individually)?
Thx

The problem (apart from less optimal results) is that it would substantially change the program structure.
The way gltfpack works is by loading the entire scene, processing it, and then writing the new scene into the .gltf/.glb/.bin files - some elements of the scene are preserved verbatim right now, but most elements change.
So there's no concept (within how gltfpack is implemented) of "an input .bin file".
In theory it's possible to output separate files for separate locations in the scene, but doing this based on the source data doesn't seem best. It could be a long-term feature perhaps, I'm not sure. Just for clarity, why is it important that your asset contains many individual .bin files?

Thx for the clarification. It's not the number of individual .bin files that we are looking at, but rather keeping the ones we had in origin. We have a requirement where we rely on deduplicating different versions of uploads, and this relies on the fact that a complex scene only changes a few ".bin" files in every "save". If we cannot rely on it, we will have to store the whole scene every time.
Same issue with download caching. It's easier to cache smaller non-changing files than have to download a single big file.
I understand this is prob a specific application, but in our case this can make a difference.

Right - I think I understand the motivation. But I'm not sure how to reconcile this with gltfpack requirements - I really don't want to maintain logic long term that is dependent on the input file split. I feel like the possibly reasonable option is to use another program to pre-split the level according to the desired breakdown.
In the future gltfpack might gain some automatic options to split the output into multiple buffers, but this is really low on my priority list right now and I'd want to use heuristics based on object size / priority / spatial locality to group data together to optimize incremental loading instead of blindly trusting the input.
If anyone has other use cases for producing multiple .bin files, please comment on this issue so that I can gather more data on this.

Thanks for sharing.
Just for clarification, in our case, we are not looking into splitting in arbitrary ways, but keeping a 1-1 mapping between input and output .bin files.
In this conceptual scenario, we would be happy that the applicable subset of optimisation processes is done on each .bin independently, just like if they were independent. As mentioned above, in our use case, good-enough optimization would suffice, while keeping the split.
But naturally, I understand that this a very specific requirement, and the code is not structured that way, so changing this without other people having this use case would constrain the evolution.
Thx

Right, I understand the requirements, they just aren't really compatible with what I'd ideally want to do with gltfpack going further.
My hope is that gltfpack can stay opinionated about the structure of the output, but can be sometimes guided by semantical hints, e.g. -kn says "names may be referenced externally and thus we can't make assumptions about the transform of these nodes staying static".
However, the buffer split is just an encoding artifact, it's not semantically meaningful and can evaporate under some transformations, e.g. merging the entire scene in a single .glb file; additionally buffers are pervasive, and tracking this relationship becomes complicated. What if some attributes are in one .bin and some others are in another .bin? What if gltfpack decides to discard some data that makes some .bin files redundant, should we drop the reference to that file? It's hard to preserve this well.
I feel like the best option for gltfpack here is to split the scene into multiple .gltf files at a higher level, before gltfpack processes the results - then updating a single file would naturally only require updating one .glb/.gltf+.bin/etc., and this splitting scheme would be compatible with other tools. My understanding is that 3D Tiles format (which is the only glTF-related initiative that allows composition of multiple glTF scenes as far as I know) follows this as well.
I'm going to close this issue since I don't anticipate it becoming a feature, but happy to hear about more cases where splitting into .bin within a single glTF scene is crucial.

Thanks for the insightful explanation.


__toString

Hello,
Nice work.
Is it possible to add à __toString method in Multi entity ?
The __toString method should return $this->getProtocolAppropriateAddress().
Twig rendering and forms will be simpler with a __toString()
Regards

In the documentation it states that __toString() maps to the getBinary() method.
But then I realised that I never actually implemented that functionality. Thanks for pointing it out.
So yes, I'll add __toString() in the interface and then implement it with the most appropriate method in each of the version classes. Hopefully will have this done in the next couple of days.

Sorry it took me so long to get round to this, getting PHPUnit working for both 5.6 and 8.0 wasn't as easy as I thought it was going to be so I left it for a while and completely forgot to finish it until now.
Version 4.0.1 has been released which includes string casting.


feat: Add network discovery via go micro library

Closes https://github.com/ethereum-optimism/mocktimism/issues/6

Current dependencies on/for this PR:

10-18-feat_Add_cli_action_config

PR #39   👈

This comment was auto-generated by Graphite.


Question: write way to use catch

When i use catch i don`t have any error from javascript code anymore!
I think its not good way to work catch like js try catch
For example look at this code
somePromissyFunction()
.then(() => {
  someBuggyFunction();
})
.catch(() => {
  console.log('You always see me! but there is no error happened in somePromissyFunction!');
})
;

function someBuggyFunction (){
  var a={};
  // make some error
  var b=a.undefinedname.bug;
  // you dont see any error becouse this founction call from some promissy function
}

Do you think its write way for make promise catch ? or i don't understand the benefited ?
Thank you in advance.

By the way for skip this issue we must use setTimeout for call someBuggyFunction
.then(() => {
  setTimeout(()=>{
    someBuggyFunction();
  })
})

Any other solution ?

the catch and then belong to the somePromissyFunction and so when this function returns a success (resloved case ) the code wrapped with **then ** will be executed , and if it returns a failure (rejected ) then the code wrapped with catch will be executed ,
the catch here has nothing to do with JavaScript error handling or exceptions, it's the pre-defined failur case of your promise
and Yes, this is not the correct place for this question, you could put it in stackoverflow
cheers

I w


no timm despite pip install

Hello,
In my dedicated python environment, I tried with latest timm and forced 0.4.5 without luck:
pip install timm==0.4.5
Defaulting to user installation because normal site-packages is not writeable
Collecting timm==0.4.5
  Downloading timm-0.4.5-py3-none-any.whl (287 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 287.4/287.4 kB 2.8 MB/s eta 0:00:00
Requirement already satisfied: torch>=1.4 in /home/pm/.local/lib/python3.10/site-packages (from timm==0.4.5) (1.12.1)
Requirement already satisfied: torchvision in /home/pm/.local/lib/python3.10/site-packages (from timm==0.4.5) (0.13.1)
Requirement already satisfied: typing-extensions in /home/pm/.local/lib/python3.10/site-packages (from torch>=1.4->timm==0.4.5) (4.3.0)
Requirement already satisfied: pillow!=8.3.*,>=5.3.0 in /usr/lib/python3/dist-packages (from torchvision->timm==0.4.5) (9.0.1)
Requirement already satisfied: numpy in /usr/lib/python3/dist-packages (from torchvision->timm==0.4.5) (1.21.5)
Requirement already satisfied: requests in /usr/lib/python3/dist-packages (from torchvision->timm==0.4.5) (2.25.1)
Installing collected packages: timm
Successfully installed timm-0.4.5
(midas) pm@pop-os:~/Documents/github$ python run.py --model_type dpt_large
Traceback (most recent call last):
  File "run.py", line 11, in <module>
    from midas.dpt_depth import DPTDepthModel
  File "/home/pm/Documents/github/midas/dpt_depth.py", line 6, in <module>
    from .blocks import (
  File "/home/pm/Documents/github/midas/blocks.py", line 4, in <module>
    from .vit import (
  File "/home/pm/Documents/github/midas/vit.py", line 3, in <module>
    import timm
ModuleNotFoundError: No module named 'timm'

Any idea?

For easy inference see #259

Thanhks @NielsRogge  I forgot about this ticket (sept 22).


Update sensor fails

Since today I get the following errors for every sensor of mijnafvalwijzer:
Update for sensor.trash_gft fails

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 221, in async_update_ha_state
    await self.async_device_update()
  File "/usr/local/lib/python3.6/site-packages/homeassistant/helpers/entity.py", line 349, in async_device_update
    await self.hass.async_add_executor_job(self.update)
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/sensor/mijnafvalwijzer.py", line 135, in update
    for item in self.data.data:
TypeError: 'NoneType' object is not iterable

I'm running hassio version 0.87.1 on a PI3.

Fixed in release 2.0.7

Works. (for now)
Wouldn't be better to use the JSON output rather the html page? Everytime they change something in the HTML page, you have to update the sensor.

Correct, but I received an email from mijnafvalwijzer that it's not allowed to use json.mijnafvalwijze.nl. It's only for paying customers.

issue is still alive though, so please don't close this, see:
https://community.home-assistant.io/t/garbage-pickup-date-mijnafvalwijzer-nl-custom-component/34631/210?u=mariusthvdb
sent a PM with address, hope it will be resolved anytime soon. Now have a constant flooding in the logs

I think I`m going to switch back to json anyway, scraping mijnafvalwijzer is way to messy. Fingers crossed mijnafvalwijzer won't complain again about this component. If so, I'll discontinue this component. Tomorrow evening I have all night to fix this!

I haven't check your Python code, but maybe increase the interval time. Once a day should be enough. (in mine opinion)
Maybe for the future split it up as component and sensor, that way you should be able to manually update the information.

Once loaded, the speedtestdotnet component will expose a service (speedtestdotnet.speedtest) that can be called to run a Speedtest.net speed test on demand. This service takes no parameters. This can be useful if you have enabled manual mode.

https://www.home-assistant.io/components/speedtestdotnet/


Bug fix core dump on 2nd phase aggregate

Proposed changes
Issue Number: close #11786
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Pls add regression test


Improve body encoding enforcement

validate encoding upon body instance creation
enforce encoding on each and readpartial too
return Enumerator if no block was given to #each

@httprb/core comments/suggestions/critics are highly welcome. :D
@kylekyle as you were the one who added encoding validation, would like to know your opinion.

To handle string encodings properly we'd need the entire API to work around characters instead of bytes (handling of which has been a bit conflated, see #339, but Ruby doesn't make this easy)
#force_encoding will let through invalid data, which is fine if the caller is buffering, but working with bytewise operations for the underlying I/O you may wind up with partial multibyte characters.
Generally in other languages I've seen a sort of two-stage processing pipeline involving a byte array or byte buffer type that you then convert into a string type (which is typically canonically utf-8 in most modern languages)

Thanks for detailed explanation @tarcieri.

@ixti err, you don't have to close this PR, you just need to make sure the encoding is handled correctly :smile:
I think you can pass the :encoding option when you perform the #readpartial on the underlying socket and Ruby should buffer along character boundaries.

Yeah, but that sounds like a totally different PR :D


GUVNOR-2379 - Overview tab saving is not working

@tsurdilo  https://github.com/droolsjbpm/jbpm-designer/pull/215 has been merged this morning (Use Base64 class from commons-codec intead of own Base64Backport) and after this, DefaultDesignerAssetServiceTest fails to compile. (The reference to Base64Backport in this file need to be replaced with Base64,and the import of Base64Backport deleted).

@jlindop amended

+1

@tsurdilo Glad to see you found a (what looks like) simple solution :)


Make setup problem with xcode 9.3

trying to fix this problem since yesterday
high sierra 10.13.4
using xcode 9.3 with commandline tools installed
brew, ldid, openssl etc. installed
( sdk & heades are installed in theos )

im also having the exact same issue.

Hi guys, try this out. This is what my makefile inside respring_simulator now contains. I'm running macOS 10.13.5 and Xcode 9.4. @BarryWhite007  @berkeelevent
TARGET = macosx:clang::10.9
ARCHS = x86_64
include $(THEOS)/makefiles/common.mk

TOOL_NAME = respring_simulator
respring_simulator_FILES = respring_simulator.mm
respring_simulator_CFLAGS = -Wno-deprecated-declarations -std=c++11

include $(THEOS_MAKE_PATH)/tool.mk

after-all::
	@echo "Copying binaries..."
	@mkdir -p ../bin
	@cp -v $(THEOS_OBJ_DIR)/respring_simulator ../bin/


[FEATURE REQ]

Is your feature request related to a problem? Please describe.
There is a performance issue when using Case Insensitive querying with CosmosDB and functions. Currently the code is wrapping all of those calls with UPPER() around the parameters. UPPER() forces a table scan without indexes per https://docs.microsoft.com/en-us/azure/cosmos-db/sql/sql-query-upper. This is easy to see the performance implications with some simple querying:
--13.87 RUs
SELECT * FROM c where c.boatId = "TEST3"

--3,268.83 RUs
SELECT * FROM c where STARTSWITH(UPPER(c.boatId), UPPER("TEST3"))

--14.37 RUs
SELECT * FROM c where STARTSWITH(c.boatId, "TEST3", true)

It becomes very clear when comparing this scenario that there is room for improvement. Those numbers are from actual queries in an actual database.
Describe the solution you'd like
The example above alludes to my suggestion for a solution also. This method - https://github.com/Azure/azure-sdk-for-java/blob/53aa670585cee8e1554fa58b9d56e499506fd532/sdk/cosmos/azure-spring-data-cosmos/src/main/java/com/azure/spring/data/cosmos/core/generator/AbstractQueryGenerator.java#L100 currently handles the UPPER() logic. If it were adapted more along these lines:
 private fun getFunctionCondition(
        ignoreCase: IgnoreCaseType, sqlKeyword: String,
        subject: String, parameter: String
    ): String {
        return if (IgnoreCaseType.NEVER == ignoreCase) {
            String.format("%s(r.%s, @%s)", sqlKeyword, subject, parameter)
        } else {
            String.format("%s(r.%s, @%s, true)", sqlKeyword, subject, parameter)
        }
    }

Then it would benefit from the index scan performance improvements.
Additional context
That call relies on a check of CriteriaType.isFunction(CriteriaType type). Currently that check would also return true for IS_NULL and IS_NOT_NULL. Those functions do not support the third parameter per https://docs.microsoft.com/en-us/azure/cosmos-db/sql/sql-query-is-null and would need some additional logic to prevent accidental usage. Perhaps a check of some kind around CriteraType.isUnary(CriteriaType type) returning false or something along those lines.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[X] Description Added
[X] Expected solution specified

@kushagraThapar - If you've got someone looking at the QueryGenerator code, here's an easy, big win.

Thank you @azizabah - this is great, appreciate the insights. We will investigate and  incorporate this.


Set storybook to be based on light theme

If your OS (such as macOS) is set to use the dark theme, some browsers (like Firefox) pass this through to Storybook which will then use the dark theme as default. This means components will then not have a white background when viewing them within Storybook.
This PR sets the base theme to be the light Storybook theme, regardless of what your OS setting is, as the components are meant to be placed on a white background.
Changed from:

To:

Checklist:

[ ] Documentation N/A
[ ] Tests N/A
[x] Ready to be merged

Thanks! I think I'd prefer the canvas background to be set to white, and still allow storybook to be dark theme, but this is definitely an improvement as-is so will merge it in.

@penx possible to have this deployed to GitHub Pages before the next version release?
https://govuk-react.github.io/govuk-react

@davidwinter that should be done, are you able to test and let me know?

Sorry for delay @penx - just to confirm this is now working as expected :+1:


Fixes to the apigee module

Alternative implementation to #1648

Allows creating organizations without configuring the VPC peering to the tenant network
Allows creating instances without the troubleshooting range
Allows the user to override the instance name

Checklist

I applicable, I acknowledge that I have:

[x] Read the contributing guide
[x] Ran terraform fmt on all modified files
[x] Regenerated the relevant README.md files using tools/tfdoc.py
[x] Made sure all relevant tests pass

@wiktorn can you tal?

LGTM


Update content scope scripts to version 4.61.0

Task/Issue URL: https://app.asana.com/0/488551667048375/1206550824714055/f

Automated content scope scripts dependency update

This PR updates the content scope scripts dependency to the latest available version and copies the necessary files.
If tests have failed, see https://app.asana.com/0/1202561462274611/1203986899650836/f for further information on what to do next.

[ ] All tests must pass

Closing in favor of https://github.com/duckduckgo/Android/pull/4174


build(flux): update flux to v0.182.0

Will be replaced by https://github.com/influxdata/influxdb/pull/23739.


RBAC features for embedded automation manager credentials

RBAC features for embedded automation manager credentials
Links
https://www.pivotaltracker.com/story/show/139194201

@miq-bot add_label enhancement

@miq-bot assign @Fryguy

@Fryguy , @dclarizio - please review
/cc @jntullo

:+1:  Looks good with respect to the current implementation, however I'm concerned on the lack of parity with External AutomationManager.  I would expect anything added to Embedded would also be added to External.  To me it's a lot like the VMs/Instances split, which although split between Infra and Cloud, they are both VM objects under the covers.
cc @abellotti @chessbyte

@lgalis just need to add edit feature
@Fryguy we will add the features for external once we allow them in the UI or API, right now we are concentrating on embedded

@dclarizio  - edit feature added

👍 looks good to me


Document "Hash vs. Block" Gotcha

I stubbed my toe porting some Perl 5 code, and thought others might benefit from having it documented:
my %fruits = apple => 'McIntosh', pear => 'Bartlett';
given (%fruits) {
  my $fails = { red => $_<apple>, green => $_<pear> };
  say $fails.WHAT;          # Block
  say $fails<red>;          # ERROR: Type Block does not support associative indexing
}

:-1: on string interpolation suggestion. Just use %( ) instead of curlies:
    my $yummy = %( red => $_<apple>, green => $_<pear> );

In general the examples do not feel very idiomatic to me, but it is a bit of a corner case to begin with so I guess awkward syntax is the name of the game.
I agree with @zoffixznet that the interpolation example is less important than the %( ) constructor. Personally I would rather not see that kind of non-idiomatic example in doc.

Sorry about that, fat-fingered the 'close and comment' button!
I wanted to also point out that this is also, at the root, caused by being too rushed to bother with naming the topic variable. I think that would be better to just point out that you can get around the entire issue with 'given %fruits -> %f { ... }'.
But all that said, I want to thank you for documenting this corner case! Other than what I've noted, I think this a great commit 👍

Thanks for the feedback!
As Just Another Perl 5 --> Perl 6 switcher, there's obviously a lot to "unlearn".  Coming to grips with the various nuances of the language can be challenging (but that is, after all, the purpose of 5to6-nutshell in the first place, right? «grin»)
Until one groks the various constructors and type conversion/coercion operators, it can be tricky to know when to use { } and when to use %( ) — especially when the former DIDN'T Do What I Meant, even though the docs made it sound like it should have.  So I was trying to stay as close to the original construct as possible, just to ease the transition...
Anyway, I'm definitely okay with providing better right examples; I'm still learning the new idioms, myself, hehe!  :-D
PS: FWIW, the original code I was porting was actually in a map block — kind of like below — but I thought given made for a tighter (albeit contrived) example...
# Perl 5
use ojo;
my @people = map {
    my $query = {
        firstName => $_->{'firstName'},
        lastName => $_->{'lastName'},
    };

    p( 'https://example.com/api/personLocator', json => $query ).json;
} @{ g( 'https://example.com/api/rosterList' ).json };

Does the following strike a better balance between informative and idiomatic?
B<NOTE:> If one or more values reference the topic variable, C<$_>, the
right-hand side of the assignment will be interpreted as a L<Block|/type/Block.html>,
not a Hash:

    my @people = [
        { id => "1A", firstName => "Andy", lastName => "Adams" },
        { id => "2B", firstName => "Beth", lastName => "Burke" },
        # ...
    ];

    sub lookup (Hash $h) { #`(Do something...) $h }

    my @names = map {
        my $query = { name => "$_<firstName> $_<lastName>" };
        say $query.WHAT;   # Block
        say $query<name>;  # ERROR: Type Block does not support associative indexing

        lookup($query);    # Type check failed in binding $h; expected Hash but got Block
    }, @people;

Instead, you should either assign to a hash directly:

        my %query = name => "$_<firstName> $_<lastName>";  # No brackets

or use the C<%( )> hash constructor:

        my $query = %( name => "$_<firstName> $_<lastName>" );
        say $query.WHAT;   # Hash
        say $query<name>;  # Andy Adams, Beth Burke, etc.

and/or avoid the issue altogether by explicitly naming the topic variable:

    my @names = map -> $person {
        my $query = { name => "$person<firstName> $person<lastName>" };
        say $query.WHAT;    # Hash
        say $query<name>;   # Andy Adams, Beth Burke, etc.

       lookup($query);
    }, @people;

Even in the final case, however, specifying the C<%()> hash constructor
is still the most idiomatic and unambiguous solution:

    my @names = @people.map: -> $person {
        lookup( %( name => "$person<firstName> $person<lastName>" ) );
    };

it can be tricky to know when to use
I've been burnt by the $_ inside curlies for Hash problem too, so it's definitely should be documented :smile_cat:

Does the following strike a better balance
:+1: looks good to me.

This is some great 5to6-nutshell writing, right there! I like the change to stringify-ing names in the example content too.

when to use { } and when to use %( ) — especially when the former DIDN'T Do What I Meant,

This is a good point. Do you remember specific examples? This kind of thing should probably be elaborated when discussing the differences in Context between P5 and P6.

This is some great 5to6-nutshell writing, right there!

Aww, shucks...  Flattery will get you everywhere! (But thanks!)  :-D
And you know what they say: "The Penalty for Good Work is MORE Work!" «grin»


Multi-package repo

Turn this (mono-)repo into a multi-package repo. That gives a lot more flexibility and ensures that we can provide TypeScript implementations of various aspects of LionWeb in a lean way (with as few dependencies per aspect as possible).
These packages should be NPM-packages that are scoped under the lionweb organization.
Possible packages:

core: LionCore and base types
serialization: everything regarding (de-)serialization
validation: Jos' work on validators of serialization chunks
utilities
cli
test: tests - not to be published on NPM!

Look at Freon4Dsl does this, e.g. using workspaces and Verdaccio to not have to use npm link (and burn yourself).
This setup also implicitly whether using these packages works because ultimately test relies on most of the others.

I would definitely not go for something like Verdaccio, that is not needed. In our company we're moving into Nx, which also fulfills these needs. To just have multiple packages in a repo and let them reference each other, the only thing you basically need is to reference the path to the other packages in the tsconfig file.

I might try out both, at least to gain some understanding of both, and then pick one. Until then, npm link kind-of works, as long as you don't forget to fix references before publishing.

And maybe contents of src/utils of core → a separate package base?

I have been using verdaccio only for testing releases with clients that are outside the mono repo. Nx seems to be something different, providing a complete local build system for managing a mono repo. It looks like they are complementary to each other.

That's correct indeed. Like I said, the only thing you need is to reference the local packages to be able to work with multiple packages in a single repo (no external tools whatsoever). Even that can be done in different ways. For example, either by referring to them in the package.json or by providing the correct paths in a tsconfig file.

I still have some trouble with getting everything working in a development situation in which you want to point to the local version of packages, so I'm leaving this issue open for now.

I solved that in the meanwhile in the sense that the pointing works, and doesn't pose a risk for accidentally publishing packages with "file:../"-type versions for deps.
Splitting of (de-)serialization is something that I'm not entirely sure about, still, so I'll leave on the Implicit Backlog ;)


Scroll to specific coordenates

I couldn't find this feature...
I have a document and a list of annotations. It would be nice if there were a feature to scroll the document to a specific coordinate. This way, when I select a specific annotation, it would jump to that point in the document.

Hi @igormicadei, the scroll is not implemented at the moment. It's a feature nice to have but hard to implement with streamlit. If you have an idea on how to do it feel free to drop us a PR

@igormicadei I've released version 0.0.18-dev0 that should implement this feature. Please have a go and let me know if you have feedback.
Please see here for more details.


Allow filter repos

What changed?
Support HelmRepository annotation for profiles.
This adds support for a new annotation on Flux HelmRepositories
  weave.works/profiles: "true"

If the annotation exists, all charts discovered in the repository are considered to be Profiles.

Why was this change made?
Simplify getting profiles in from existing HelmCharts.

How was this change implemented?
This is a fairly trivial change, expanding the predicate to accept the helm repository, and checking for either chart of repo annotation.

How did you validate the change?

Release notes

Documentation Changes

This raises an interesting question, how do we want to divide the weave.works label/annotation namespace?


Feature Enhancement: Adding bombs and lives to the game

Fixes Issue🛠
Closes #134
Description👨💻
Aplied Changes

Introduction of Bombs: I have included bombs in the game, i.e, while the edibles appear, some bombs might also appear with a 50% probability. The maximum number of bombs that can be on the screen is limited to 5, to avoid crowding. Also, the lifespan of each bomb ranges between 1 to 6 seconds.

Updated Game Logic: To accommodate the Introductions of bombs and the lives of the player, to allow gameover condition on all the lives getting wasted, has all been implemented.

Addition of lives: The player will have a max of 3 lives when playing, on clicking a bomb one live is lost. When all 3 lives are lost, it is game over.

Inclusion of assets: Some assets, mainly, the image of the bomb, the image when a bomb explodes, and the sound played when the bomb explodes has been included.

Type of change📄

[x] New feature (non-breaking change which adds functionality)

How this has been tested✅
I have applied the changes and tested them out in my local machine. I have played the game muliple times to ascertain the randomness of the appearance of the bombs, and also seen to the fact that on clicking 3 bombs the game gets over properly and without bugs.
Checklist✅

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added demonstration in the form of GIF/video file
[x] I am an Open Source Contributor

Screenshots/GIF📷
Screen-shot 1

Screen-shot 2

Screen-shot 3

Nice work!! Merged 🎉🥳 @SoumyadevSaha

Nice work!! Merged 🎉🥳 @SoumyadevSaha
give @SoumyadevSaha 150 points

Nice work!! Merged 🎉🥳 @SoumyadevSaha
give @SoumyadevSaha 150 points

Thankyou @Rakesh9100 😊

give @SoumyadevSaha 150 points


Is it possible to disable caching for a single model?

I like the json versioning and properties features, but I don't really need the caching for one of my models (for now). So is it possible to disable caching for a single model? Is it viable? What are your thoughts?

I think it's viable, I would track down where we use Mongoid::CachedJson.config.disable_caching and extend the DSL to be able to say something like disable_caching: true. Would take a PR with this.


fix(aws): construct proper URL for core

Summary:
This (actually, finally) fixes the Lambda builds. There was an unforeseen change that had to do with how the core handles paths (equality instead of ends_with when checking for /graphql in path) with how API Gateway constructs URLs (cannot call the base without an API key, must use a stage and call https://{host}/{stage}/graphql). This PR adds extra logic to the request converter to construct core-compatible URLs.
Build & Testing:

[x] I ran cargo test successfully.
[x] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

[x] I have added relevant unit & integration tests.
[x] I have updated the documentation accordingly.
[x] I have performed a self-review of my code.
[x] PR follows the naming convention of <type>(<optional scope>): <title>

Here's some proof it actually works now (you can run it too):
$ curl -X POST -H "Content-Type: application/json" https://zznym6zvdc.execute-api.eu-central-1.amazonaws.com/live/graphql --data '{"query": "query { user { id } }"}'
{"data":{"user":{"id":1}}}


Steering unavailable Ram 1500 DT Ltd

Describe the bug
I have just installed the comma 3X when the adaptive cruise control is turned on, I get an error message steering temporarily unavailable. I have restarted and reset the device and reinstalled the current version of open pilot. 0.9 .4 with no success. I have checked the compatibility for the vehicle and it is compatible, the Comma team have set up the same, comma 3X on a ram 1500 DT Ltd
Provide a route where the issue occurs
https://useradmin.comma.ai/?onebox=56f7f07241e11132|2023-10-19--01-36-29
openpilot version
0.9.4
Additional info
I have tried these branches
https://installer.comma.ai/commaai/nightly
https://installer.comma.ai/commaai/master-ci
https://github.com/commaai/openpilot/tree/nightly
https://github.com/commaai/openpilot/tree/master-ci
And they don't work I am back to the same error can you please link the original ram fault branch
that worked.
Please try this branch: https://github.com/commaai/openpilot/tree/fix-ram-1500-fault
Or use this installer URL during setup: https://installer.comma.ai/commaai/fix-ram-1500-fault
Cheers

duplicate of https://github.com/commaai/openpilot/issues/30266


added numpydoc to requirements.txt

This is meant to resolve an issue causing the readthedocs documentation to fail

Pull Request Test Coverage Report for Build 2733

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.034%

Totals

Change from base Build 2731:
0.0%

Covered Lines:
7404

Relevant Lines:
8507

💛  - Coveralls


[MRTK 2.8.3 Build Call] Eye tracking sliders are not moving in Eye Tracking Targeting position example

Describe the bug
Eye tracking is working, the user is able to manipulate and move the cubes in the same scene.
When gazing at the sliders and pinching to grab on, no matter what action the user takes the slider does not move
To reproduce
Steps to reproduce the behavior:

Ensure eye tracking is enabled properly - MRTK Eye Tracking Setup
Launch MRTK 2.8.3 Example scene 'Eye Tracking Targeting position'
Gaze at either slider bar in the example scene
air tap to grab ahold of the slider
observe the slider does not move regardless of what action is taken by the user

Expected behavior
Sliders move with the users gaze
Video
https://user-images.githubusercontent.com/110259320/206291858-4960f06a-c883-42e0-8dde-eb2af7350f9b.mp4
Your setup (please complete the following information)

Unity Version 2020.3.42f1
MRTK Version 2.8.3 Build Call Preview

Target platform (please complete the following information)

HoloLens 2

Confirmed not a regression, occurs on public version 2.8.2. May already have an issue open

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all-new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visit https://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Add task preview component & clean up task detailed view

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01596b77af2c9c79b0
Upwork Job ID:<PHONE_NUMBER>741620736
Last Price Increase: 2023-05-11

@thienlnam what's the difference with getting like this one generated automatically? https://github.com/Expensify/App/issues/18790
Will need to update the title of this issue when it hits prod.

Okay, cool!
On Fri, May 12, 2023 at 4:36 PM Jack Nam @.***> wrote:

I think that's when a PR is linked to an E/E issue. This PR I added was
cleaning up an existing issue that already had another PR linked to it. I
think this title should update once the PR is deployed to production
—
Reply to this email directly, view it on GitHub
https://github.com/Expensify/App/issues/18785#issuecomment-1545934779,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD3246KUKP7P6RETTMR3JKLXFZKF7ANCNFSM6AAAAAAX6OCQTE
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
*Tom Rhys Jones *
Expensify

Ready for payment cc @trjExpensify

Indeedy, I've been away at EC3 and back in the office today.
@fedirjh, I've sent you an offer for $1,000 on this job here.


Confirm screen overlaps with status bar on iOS

The same issue was reported in the telegram group:

fixed in #969


fix(website): make right-click ➝ /branding only for logo, not entire navbar

Closes #1552

Removed data-navbar from navbar.
Added data-home-link to anchor tag wrapping the logo.
Updated selector that applies right-click listener accordingly.

✅ Checklist

[ ] I have followed every step in the contributing guide (updated 2022-10-06).
[x] The PR title follows the convention we established conventional-commit
[x] I performed a functional test on my final commit

Changelog
Minor, website navbar, right-click redirects to /branding page only for logo anchor, not entire navbar.
No packages need a version bump, no changeset applicable, website change only.

👍🏼


connect gitlab with the ssl error

2017-04-19 14:24:00,537 INFO  c.c.d.collector.CollectorTask - I/O error on GET request for "https://X.X.X.X:443/api/v3/projects?per_page=100": java.security.cert.CertificateException: No subject alternative names present; nested exception is javax.net.ssl.SSLHandshakeException: java.security.cert.CertificateException: No subject alternative names present
I add "gitlab.selfSignedCertificate=true" to the application.properties,but it does not work,anyone help?

  That collector didn't have that property available to it.  I did just create a branch now that implements the same thing the scm collector has.  Would you mind testing out this branch for me before I submit a pull request?

Thank you,it fixs my problem!

Good deal, I'll get the pull request out soon.


[FEAT]: Create API keys with different permissions

What would you like to see?
Currently when you create an API key, it has full access to the AnywhereLLM API, I would really like to be able to have permissions that mirrors permissions granted to users.  So one that could only get and receive chats, one that could do that as well as update embeddings and then a third that has full access like the default one does now.

This would be very viable for us, too.
Iirc @timothycarambat already proposed that they are working on rbac support? Is there any update regarding this?


"Add other labellers" shouldn't show everyone's emails

Since the site is public-facing, we shouldn't be leaking email addresses

Addressed in 14c0b13771e3c60b49887ce0bbee0861b1b5d86d


CMakeFiles in source directory on out of source-tree build

In file https://github.com/zlib-ng/zlib-ng/blob/2.0.2/cmake/detect-arch.cmake#L27, the try_run call for the bindir parameter uses CMAKE_CURRENT_SOURCE_DIR instead of CMAKE_CURRENT_BINARY_DIR.

Steps to reproduce?

Steps to reproduce:
[phprus@mbp-phprus zlib]$ wget https://github.com/zlib-ng/zlib-ng/archive/refs/tags/2.0.2.tar.gz
[phprus@mbp-phprus zlib]$ tar xzf 2.0.2.tar.gz
[phprus@mbp-phprus zlib]$ cd zlib-ng-2.0.2
[phprus@mbp-phprus zlib-ng-2.0.2]$ mkdir build
[phprus@mbp-phprus zlib-ng-2.0.2]$ ls CMakeFiles    <--- Before run cmake
ls: CMakeFiles: No such file or directory
[phprus@mbp-phprus zlib-ng-2.0.2]$ cd build/
[phprus@mbp-phprus build]$ cmake -DCMAKE_BUILD_TYPE=Release ..
-- Using CMake version 3.15.4
-- ZLIB_HEADER_VERSION: 1.2.11
-- ZLIBNG_HEADER_VERSION: 2.0.2
-- The C compiler identification is AppleClang <IP_ADDRESS>00033
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Arch detected: 'x86_64'
-- Basearch of 'x86_64' has been detected as: 'x86'
-- Architecture supports unaligned reads
-- Architecture supports unaligned reads of > 4 bytes
-- Looking for stdarg.h
-- Looking for stdarg.h - found
-- Looking for sys/sdt.h
-- Looking for sys/sdt.h - found
-- Looking for unistd.h
-- Looking for unistd.h - found
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of off64_t
-- Check size of off64_t - failed
-- Check size of _off64_t
-- Check size of _off64_t - failed
-- Check size of __off64_t
-- Check size of __off64_t - failed
-- Looking for fseeko
-- Looking for fseeko - found
-- Looking for strerror
-- Looking for strerror - found
-- Performing Test HAVE_NO_INTERPOSITION
-- Performing Test HAVE_NO_INTERPOSITION - Failed
-- Performing Test HAVE_ATTRIBUTE_VISIBILITY_HIDDEN
-- Performing Test HAVE_ATTRIBUTE_VISIBILITY_HIDDEN - Success
-- Performing Test HAVE_ATTRIBUTE_VISIBILITY_INTERNAL
-- Performing Test HAVE_ATTRIBUTE_VISIBILITY_INTERNAL - Success
-- Performing Test HAVE_BUILTIN_CTZ
-- Performing Test HAVE_BUILTIN_CTZ - Success
-- Performing Test HAVE_BUILTIN_CTZLL
-- Performing Test HAVE_BUILTIN_CTZLL - Success
-- Performing Test HAVE_PTRDIFF_T
-- Performing Test HAVE_PTRDIFF_T - Success
-- Performing Test HAVE_SSE2_INTRIN
-- Performing Test HAVE_SSE2_INTRIN - Success
-- Performing Test HAVE_SSSE3_INTRIN
-- Performing Test HAVE_SSSE3_INTRIN - Success
-- Performing Test HAVE_SSE42CRC_INLINE_ASM
-- Performing Test HAVE_SSE42CRC_INLINE_ASM - Success
-- Performing Test HAVE_SSE42CRC_INTRIN
-- Performing Test HAVE_SSE42CRC_INTRIN - Success
-- Performing Test HAVE_SSE42CMPSTR_INTRIN
-- Performing Test HAVE_SSE42CMPSTR_INTRIN - Success
-- Performing Test HAVE_PCLMULQDQ_INTRIN
-- Performing Test HAVE_PCLMULQDQ_INTRIN - Success
-- Performing Test HAVE_AVX2_INTRIN
-- Performing Test HAVE_AVX2_INTRIN - Success
-- Architecture-specific source files: arch/x86/x86.c;arch/x86/slide_avx.c;arch/x86/chunkset_avx.c;arch/x86/compare258_avx.c;arch/x86/adler32_avx.c;arch/x86/insert_string_sse.c;arch/x86/compare258_sse.c;arch/x86/chunkset_sse.c;arch/x86/slide_sse.c;arch/x86/adler32_ssse3.c;arch/x86/crc_folding.c
-- The following features have been enabled:

 * CMAKE_BUILD_TYPE, Build type: Release (selected)
 * WITH_GZFILEOP, Compile with support for gzFile related functions
 * ZLIB_ENABLE_TESTS, Build test binaries
 * WITH_OPTIM, Build with optimisation
 * WITH_NEW_STRATEGIES, Use new strategies
 * WITH_UNALIGNED, Support unaligned reads on platforms that support it
 * WITH_AVX2, Build with AVX2
 * WITH_SSE2, Build with SSE2
 * WITH_SSSE3, Build with SSSE3
 * WITH_SSE4, Build with SSE4
 * WITH_PCLMULQDQ, Build with PCLMULQDQ
 * AVX2_SLIDEHASH, Support AVX2 optimized slide_hash, using "-mavx2"
 * AVX_CHUNKSET, Support AVX optimized chunkset, using "-mavx2"
 * AVX2_COMPARE258, Support AVX2 optimized compare258, using "-mavx2"
 * AVX2_ADLER32, Support AVX2-accelerated adler32, using "-mavx2"
 * SSE42_CRC, Support SSE4.2 optimized CRC hash generation, using "-msse4"
 * SSE42_COMPARE258, Support SSE4.2 optimized compare258, using "-msse4"
 * SSSE3_ADLER32, Support SSSE3-accelerated adler32, using "-mssse3"
 * PCLMUL_CRC, Support CRC hash generation using PCLMULQDQ, using "-mssse3 -msse4 -mpclmul"

-- The following features have been disabled:

 * ZLIB_COMPAT, Compile with zlib compatible API
 * ZLIB_DUAL_LINK, Dual link tests against system zlib
 * WITH_SANITIZER, Build with sanitizer (Memory, Address, Undefined)
 * WITH_FUZZERS, Build test/fuzz
 * WITH_NATIVE_INSTRUCTIONS, Instruct the compiler to use the full instruction set on this host (gcc/clang -march=native)
 * WITH_MAINTAINER_WARNINGS, Build with project maintainer warnings
 * WITH_CODE_COVERAGE, Enable code coverage reporting
 * WITH_INFLATE_STRICT, Build with strict inflate distance checking
 * WITH_INFLATE_ALLOW_INVALID_DIST, Build with zero fill for inflate invalid distances
 * INSTALL_UTILS, Copy minigzip and minideflate during install

-- Configuring done
-- Generating done
-- Build files have been written to: /Users/phprus/Devel/zlib/zlib-ng-2.0.2/build
[phprus@mbp-phprus build]$ ls ../CMakeFiles
CMakeTmp
[phprus@mbp-phprus build]$ cd ../
[phprus@mbp-phprus zlib-ng-2.0.2]$ ls CMakeFiles    <--- After run cmake
CMakeTmp                                        <--- ??? In source dir
[phprus@mbp-phprus zlib-ng-2.0.2]$

And after run tests (in source dir):
/crc32_comb_tbl._h
/crc32_tbl._h
/inffixed_tbl._h
/test/data/lcet10.txt-minigzip-lcet10-6-xmM5Bu.gz
/test/data/lcet10.txt-minigzip-lcet10-6-xmM5Bu.gzip.out
/test/data/lcet10.txt-minigzip-lcet10-6-xmM5Bu.out
/trees_tbl._h

This should be resolved now in develop.


Clickable links don't work for things posted in minecraft chat

But they do work for things posted from IRC.

This is MC-30864, a vanilla bug. EiraIRC currently only fixes this issue for things from IRC chat or when installed on the server.
I probably have a simple way to make it work (and by make it work I mean fix the vanilla bug) on the client-side only for Minecraft chat, might look into that again.

Actually, I just saw this should have been fixed by Minecraft Forge already.
Gonna have to check if something on EiraIRC's client-side is breaking it or if your server owner is just super out of date on Forge.

Just tested on a Forge <IP_ADDRESS>8 with no mods and a client with only EiraIRC and I could click links fine, even without the hacky fix I unnecessarily made.
Either your server's Forge version is way out of date or you have some other mod installed that's breaking links.

Hey, you said you had asielib installed, right?
There's your culprit. Unless I've missed something in their code, they're breaking links.


Just encoder and decoder without refining

Hi,
What is the RMSE using only encoder and decoder that is not refined(propagation)?
I wonder how big the performance improvement that compared to when there was no NLSPN module.
Thank you

Hi, I don't have the exact number for that option currently.
However, you can train a network with this option: --prop_time 0


add X-ray inspector mode for leaflet frontend

Because the Leaflet frontend already assumes the leaflet dependency, we can reuse some DOM elements to display the feature ID, type and properties.

very basic implementation in v1.3.0, screenshot:

issues right now:
it does hit detection based on bounding box, which will include way too many features: we need a very primitive distance-to-linestring, as well as point-in-polygon implementation to do this more accurately. open to feedback

scrolling around aggressively and clicking on zoom transition seems to break the inspector. also consider:
maybe using console.log is a better option?
maybe a hovering window instead of reusing leaflet popups?


Is this project still alive?

I read that Seatgeek no longer uses Soulmate and I see that a fork of this project is born.
I find this project very useful when one needs only autocompletion and not full text search, however I'd like to know if it's worth to rely on this project anymore.
What's the current project status? Will it be updated?
Please advice

The project still works - code doesn't have an expiration date! - and we'd be happy to merge any pull requests. I just got back from vacation, but I'll take a look at the open PRs this weekend :)

Ok, thanks for the update.

Hey @josegonzalez, I did fork the project to add some features that I wanted to have, and I'm pretty excited about the updates. Can I add a link to Soulmate's readme?

How does your project differ? Ideally we just combine the two and call it a day :)

Well... I thought about that, and it's what I originally intended. But I realized it would be better off not being backward compatible.
There are minor things, like using cors instead of jsonp, but also major things, like the way that you load data in and the server response. The parameters passed to the server have all been renamed. When you submit multiple categories (soulmate calls them "types"), my updated fork responds with weighted projects of any of the categories, rather than separate lists.

Backwards compatibility can be broken by major releases ;)

After thinking about it for a while, I'm going to continue on with soulheart as a separate gem.
It feels like a new project (with different goals) and I feel guilty about my reckless commit history. I hope you aren't too sad.

No worries, that's how open source works :)


Improve public headers includes

Now the public headers are a mess. Need to make one or two public includes and hide all other code inside details. As a result, users would clearly understand which headers they should include. Maybe the only usage of ureact namespace without detail should be done there. Also, version number would be added there.

Need to move all public methods and classes into ureact/ureact.hpp. So all the docs can be seen there.
Below need to make a plan to improve all the entities.
context

[ ] Need constructor
[ ] Need do_transaction method
[ ] Optionally add make_var method
[ ] Hide everything else inside details

observer

[ ] observe ()
[ ] scoped_observer

signal
temp_signal

[ ] make_signal()
[ ] operator->*

var_signal

[ ] make_var()

signal_pack

[ ] with()
[ ] operator,

flatten
type_traits (should be internal?)

More or less done. Closing


Unable to set config.allowUnfree on the jupyterWith nixpkgs config

Describe the bug
I added an unfree python package to my jupyterWith environment, and I got the warning that I needed to allow unfree packages, so I added it like so:
jupyterWith = import (builtins.fetchTarball "https://github.com/tweag/jupyterWith/archive/c71a01a39a3f51951da0dbf0192cf9d1d000151b.tar.gz") {
  overlays = [
    (self: super: {
      python3 = super.python3.override (old: {
        packageOverrides =
          pkgs.lib.composeExtensions
            (old.packageOverrides or (_: _: {}))
            pythonPackageOverrides;
      });
    })
  ];
  config.allowUnfree = true;
};

however this had no effect and I got the same warning about unfree packages when I rebuilt the configuration.
To Reproduce

Add an unfree package to your jupyterWith config
Build your configuration and get the warning about this package having an unfree license and refusing to build your config (expected)
Pass config.allowUnfree = true; to the invocation of the jupyterWith module
Build your configuration and get the warning about this package having an unfree license and refusing to build your config (not expected)

Expected behavior
I expected adding config.allowUnfree = true; where I did, to allow the build to proceed without without getting the unfree error
Environment

OS: Nixos 22.05
Version of the code: https://github.com/tweag/jupyterWith/archive/c71a01a39a3f51951da0dbf0192cf9d1d000151b.tar.gz

Additional context
I think this bug was introduced here: https://github.com/tweag/jupyterWith/commit/61c76ed0b0d22ac9f6e53873ec2a57e6bc8fe227

Hey @asariley
@garbas submitted https://github.com/tweag/jupyterWith/pull/302 to fix the config problem. Pretty sure you were correct about where the bug was introduced.
Try changing your commit SHA to 0e26d3c0026c02bdc5bfdb2a37149d3bdd097eeb and let us know if it works for you.

Tried the updated hash and the problem is fixed. Thank you!

Glad that it works for you now! I've merged the PR into the main branch.


Remove obsolete property types

Background
There are a number property types that are obsolete and no longer used, e.g., delegated, real, float.
Proposed solution
These property types should be removed from the gldcore code.
Alternative solutions
Leaving them as is and continuing to maintain the code they require.
Additional context
This should be done as part of the general core upgrade.

The properties should be changed to DEPRECATED first with a warning if used until the next major release.


Maintained release versions

Right now, we only release from the main branch.
Should we also release from a release/8.5 and release/8.6 branch and make the main branch a development branch only?

100% agree

Cool, I will go ahead and set up a release branch accordingly. Will be comparable to https://github.com/camunda-community-hub/camunda-operate-client-java

Done


Add config for disabling skipping the night (add #208)

You can disable players skipping the night now. Closes (#208)

Rebased after the NMS repackage


Token Storage

How does this library store tokens? I am planning to use this in a browser setting (with authorization_code) grant. Does this library store tokens automatically? I'm also trying to understand whether to store using HTTP-only cookies or localStorage. How would a setup with HTTP-only cookies work with this library.
Thanks!

passport-sbhs

https://github.com/badgateway/oauth2-client#storing-tokens-for-later-use-with-fetchwrapper


Update go-github to v44

cc @wlynch / @bradleyfalzon, if you don't mind taking a look  :)

Thanks again @asvoboda


Refactor crypto and other WASM-based modules

Description
Re-implement the functionality of @lit-protocol/crypto package as follows (WIP!):

[x] create a new nx workspace (currently in the ng/ dir), with a simpler/standard build system,
[x] create a unified Rust crate exposing an API to js,
[x] merge all Rust crates, which expose functionality via wasm, into the unified one,
[x] set up a mechanism to generate TypeScript types from Rust (beyond those created by wasm-bindgen, if needed),
[ ] add a thin (type-safe) JS layer on top of Rust, dealing with data conversion (the less, the better),
[ ] migrate all tests for @lit-protocol/crypto to the new implementation,
[ ] migrate all uses of/references to @lit-protocol/crypto to the new implementation.

Design choices

esbuild as bundler

supports embedding binary files out-of-the box, useful for wasm
fast
supported by jest via esbuild-jest-transform

single javascript package (currently named @lit-protocol/ng, to be renamed)

tree-shaking should remove unused functionalities,
better split into modules, before splitting into packages,
split into packages later, when useful/needed (e.g. to reduce build time, to support different build pipelines, what not).

Notes
The build does not generate .d.ts TypeScript declaration files yet.
Not adding this for now, since it could come for free if recent PR https://github.com/nrwl/nx/pull/21084 is merged (or https://github.com/nrwl/nx/issues/20688 fixed anyway).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

To do:

make the exported wasm function handle multiple curves dynamically (the api is identical, less code, no/less need for macros)
see what happens if we bypass nx entirely
set up a long-lived feature branch and/or split this PR into smaller ones for easier reviews (@joshLong145)


RowCoverter::convert that targets an existing Rows

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
I am trying to make group by really fast in DataFusion https://github.com/apache/arrow-datafusion/pull/6800
The grouping code uses the Arrow Row format 👍  and calls RowConverter::convert_columns
My traces imply that some non trivial amount of time is spent zeroing out newly allocated memory for Rows:

Describe the solution you'd like
I would like  a method like RowConverter::convert_columns_in_place that writes to an pre-existing rows (clearing it out first)
Perhaps something like
impl RowConverter {
...
    /// Convert [`ArrayRef`] columns into pre-existing [`Rows`], first calling `Rows::reset()`
    ///
    /// See [`Row`] for information on when [`Row`] can be compared
    ///
    /// # Panics
    ///
    /// Panics if the schema of `columns` does not match that provided to [`RowConverter::new`]
    pub fn convert_columns_in_place(&mut self, columns: &[ArrayRef], dst &mut Rows) -> Result<ArrowError> {

https://docs.rs/arrow-row/43.0.0/src/arrow_row/lib.rs.html#712
Describe alternatives you've considered

Additional context

I'm not very familiar with the Instruments profile, but it seems off to me that alloc_zeroed is under update_group_state and not convert_columns? If the allocation was occurring as part of row conversion I would have perhaps expected it to appear under convert_columns?

I couldn't find anything else that does allocations per group, but I agree the profile is somewhat ambiguous

(BTW this is like 2% of the total time, so more like a nice to have feature, rather than anything critical or really important)

label_issue.py automatically added labels {'arrow'} from #4533


Communicating between modules

Good question from Discord posted for visibility:

I have an app that uses ui.navset_tab_card to hold multiple ui.nav elements, for which each ui.nav element's ui and server function content takes the form of a module (https://shiny.posit.co/py/docs/workflow-modules.html). What I want to do:

Within a ui.nav module, can I navigate through the ui.navset_tab_card with the ui.update_navs function, even though ui.navset_tab_card is outside the scope of the ui.nav module.

Can I access and manipulate specific ui elements within a module. For example, I want to run ui.update_text for a ui.output_text ui element within a module.

Modules exist in their own namespace, which is what allows you have multiple instantiations of module without causing namespace conflicts. As a result in order to have a module interact with its parent you need to explicitly communicate between the module's namespace and the parent namespace. There are generally two ways to do this:

Pass arguments from the parent to the child module
Return values from the module to the parent

In both cases you can communicate reactive values, and operate on them like you would other values.  Since you're trying to use update functions, you can pass and return the namespace IDs to accomplish your goals. The namespaced id can be retrieved with session.ns()
Update tab from module
Since the tabset id exists at the parent level, we need to pass it from the parent to the module as an argument. Once we do that we can update the tabset from within the module.
    button_1 = tab_server(
        "counter1",
        tabset=session.ns("tab_set"),
        exit_tab="B",
    )

Update button text from parent
To update the button text from the parent, we need to know the id of that element within the module namespace. An easy way of doing this is to return that value from the module with return session.ns("button"). Once you have that id, you can update its value from the parent like you would any other value.
Example app with both functions
from shiny import App, Inputs, Outputs, Session, module, reactive, render, ui

@module.ui
def tab_ui(label: str = "Increment counter") -> ui.TagChild:
    return ui.div(
        {"style": "border: 1px solid #ccc; border-radius: 5px; margin: 5px 0;"},
        ui.input_action_button(id="button", label=label),
    )

@module.server
def tab_server(input: Inputs, output: Outputs, session: Session, tabset, exit_tab):
    @reactive.Effect
    @reactive.event(input.button)
    def _():
        ui.update_navs(tabset, selected=exit_tab)

    return session.ns("button")

# =============================================================================
# App that uses module
# =============================================================================
app_ui = ui.page_fluid(
    ui.navset_tab_card(
        ui.nav("A", tab_ui("counter1", "Go to Tab B")),
        ui.nav("B", tab_ui("counter2", "Go to Tab A")),
        id="tab_set",
    ),
    ui.input_action_button("exclaim", "Add '!'"),
)

def server(input: Inputs, output: Outputs, session: Session):
    def go_to(tab):
        ui.update_navs(session.ns("tab_set"), selected=tab)

    button_1 = tab_server(
        "counter1",
        tabset=session.ns("tab_set"),
        exit_tab="B",
    )

    button_2 = tab_server(
        "counter2",
        tabset=session.ns("tab_set"),
        exit_tab="A",
    )

    @reactive.Effect
    @reactive.event(input.exclaim)
    def add_exclamations():
        ui.update_action_button(button_1, label="Go to Tab B!")
        ui.update_action_button(button_2, label="Go to Tab A!")

app = App(app_ui, server)


Fixes Issues with Histeq, changes the dtype argument.

Changed dtype argument
Fixed #503
Fixed #502

Some unsolved issues :

#504
#503 (The convert(Array{GrayA}, img) method is not working. The returned datatype for transaparent images is Array{Any} instead of Array{Gray}. This causes an error while saving the image.)

julia> img = testimage("house")
GrayA Images.Image with:
  data: 512×512 Array{ColorTypes.GrayA{FixedPointNumbers.UFixed{UInt8,8}},2}
  properties:
    colorspace: Gray
    spatialorder:  x y

julia> h=Images.histeq(img, 1000)
Gray Images.Image with:
  data: 512×512 Array{Any,2}
  properties:
    colorspace: Gray
    spatialorder:  x y

julia> save("test.jpg", h)
WARNING: MethodError(ImageMagick.mapinfo,(
Gray Images.Image with:
  data: 512×512 Array{Any,2}
  properties:
    colorspace: Gray
    spatialorder:  x y,))
 in save_ at /home/jarvis/.julia/v0.5/ImageMagick/src/ImageMagick.jl:158 [inlined] (repeats 2 times)
 in #save#5(::Array{Any,1}, ::Function, ::FileIO.File{FileIO.DataFormat{:JPEG}}, ::Images.Image{Any,2,Array{Any,2}}, ::Vararg{Images.Image{Any,2,Array{Any,2}},N}) at /home/jarvis/.julia/v0.5/ImageMagick/src/ImageMagick.jl:68
 in save(::FileIO.File{FileIO.DataFormat{:JPEG}}, ::Images.Image{Any,2,Array{Any,2}}, ::Vararg{Images.Image{Any,2,Array{Any,2}},N}) at /home/jarvis/.julia/v0.5/ImageMagick/src/ImageMagick.jl:68
 in #save#18(::Array{Any,1}, ::Function, ::FileIO.File{FileIO.DataFormat{:JPEG}}, ::Images.Image{Any,2,Array{Any,2}}, ::Vararg{Images.Image{Any,2,Array{Any,2}},N}) at /home/jarvis/.julia/v0.5/FileIO/src/loadsave.jl:95
 in save(::FileIO.File{FileIO.DataFormat{:JPEG}}, ::Images.Image{Any,2,Array{Any,2}}) at /home/jarvis/.julia/v0.5/FileIO/src/loadsave.jl:89
 in #save#14(::Array{Any,1}, ::Function, ::String, ::Images.Image{Any,2,Array{Any,2}}, ::Vararg{Images.Image{Any,2,Array{Any,2}},N}) at /home/jarvis/.julia/v0.5/FileIO/src/loadsave.jl:51
 in save(::String, ::Images.Image{Any,2,Array{Any,2}}) at /home/jarvis/.julia/v0.5/FileIO/src/loadsave.jl:51
 in eval(::Module, ::Any) at ./boot.jl:225
 in macro expansion at ./REPL.jl:92 [inlined]
 in (::Base.REPL.##1#2{Base.REPL.REPLBackend})() at ./event.jl:46
ERROR: MethodError: no method matching mapinfo(::Images.Image{Any,2,Array{Any,2}})
 in save_ at /home/jarvis/.julia/v0.5/ImageMagick/src/ImageMagick.jl:158 [inlined] (repeats 2 times)
 in #save#5(::Array{Any,1}, ::Function, ::FileIO.File{FileIO.DataFormat{:JPEG}}, ::Images.Image{Any,2,Array{Any,2}}, ::Vararg{Images.Image{Any,2,Array{Any,2}},N}) at /home/jarvis/.julia/v0.5/ImageMagick/src/ImageMagick.jl:68
 in save(::FileIO.File{FileIO.DataFormat{:JPEG}}, ::Images.Image{Any,2,Array{Any,2}}, ::Vararg{Images.Image{Any,2,Array{Any,2}},N}) at /home/jarvis/.julia/v0.5/ImageMagick/src/ImageMagick.jl:68
 in #save#18(::Array{Any,1}, ::Function, ::FileIO.File{FileIO.DataFormat{:JPEG}}, ::Images.Image{Any,2,Array{Any,2}}, ::Vararg{Images.Image{Any,2,Array{Any,2}},N}) at /home/jarvis/.julia/v0.5/FileIO/src/loadsave.jl:95
 in save(::FileIO.File{FileIO.DataFormat{:JPEG}}, ::Images.Image{Any,2,Array{Any,2}}) at /home/jarvis/.julia/v0.5/FileIO/src/loadsave.jl:89
 in #save#14(::Array{Any,1}, ::Function, ::String, ::Images.Image{Any,2,Array{Any,2}}, ::Vararg{Images.Image{Any,2,Array{Any,2}},N}) at /home/jarvis/.julia/v0.5/FileIO/src/loadsave.jl:51
 in save(::String, ::Images.Image{Any,2,Array{Any,2}}) at /home/jarvis/.julia/v0.5/FileIO/src/loadsave.jl:51
 in eval(::Module, ::Any) at ./boot.jl:225
 in macro expansion at ./REPL.jl:92 [inlined]
 in (::Base.REPL.##1#2{Base.REPL.REPLBackend})() at ./event.jl:46

The test is failing due to ERROR: LoadError: LoadError: UndefVarError: U16 not defined. Doesn't it use the latest version of Colors automatically?

Travis will use the latest tagged version of packages by default. We can tag a new release. Anything else you know of that needs to be changed in ColorTypes before we do so?
Also, FYI as a temporary measure you can change the test script to check out the master version of a package. But it's important to not forget to change it back! So in general the best approach is to tag a new version of whatever package needs to be bumped.
Finally, please do add some tests---I won't merge this without them :wink:. Test would have likely caught the problem originally. As a tip, I often try to write the tests before I write the code to implement the functionality; it really helps clarify one's thinking about what the API should look like.

Completely agree. Will add tests to this PR :)
Regarding ColorTypes, I can't think of anything right now. I can change the test script for a few days before a new release is tagged so that any new changes can be included in that too.

I'll go ahead and submit a PR for a new release right now.

OK, it's merged, so any new pushes will be tested with the new ColorTypes.

This is a good step forward, so I'll merge. We can polish further later.


The error message is "Io Error: operation not supported on this platform". I replicated on MacOS and a RHEL container.
If I set  load_remote_stylesheets: false then the problem stops.
Not sure if there is something specific about the google font api or a larger problem with loading remote stylesheets.

Hi @glove99
Thank you for reporting and sorry for the confusing error message!
The issue is that our core crate sends requests via attohttpc which does not support WASM. Can you share some code snippets so I can work with them and maybe use them in the test suite?
Probably, the solution will be to switch to reqwest (#246) or make it extendable, so in wasm bindings, we use e.g. web_sys to make network calls

Ah that makes sense. Here is a simple test case that fails:
  it('replicate remote link error', async () => {
    const html =
      '\
      <link href="https://fonts.googleapis.com/css?family=IBM+Plex+Sans:100,200,300,400,500,600,700&display=swap" rel="stylesheet">\
      <link href="https://fonts.googleapis.com/css?family=IBM+Plex+Mono:100,200,300,400,500,600,700&display=swap" rel="stylesheet">\
    Test';

    const output = inline(html, {});
    console.log(output);
  });

BTW, while debugging this problem I dived into your project code. Really impressive. I always love learning I don't know near as much as I thought I did.  😄

@glove99 Sorry for the delay!
Thank you for the reproduction code! Happy to hear that you found the source code useful :) Let me know if you have any questions about it, I'd be happy to chat :)
On the issue side - I will fix the ongoing build failure and then look into switching the library that makes requests in the core crate first (maybe in a couple of weeks) and then will update the WASM bindings.

FWIW, I updated the error text, so it clearly communicates the current state of things. Network requests are not supported on WASM now (though they work in the new, not yet released napi bindings) + the readme is updated to reflect it too.
Though, it should be possible, here is an example with fetch


LibWeb/CSS: Add support for hwb, oklab and oklch color functions

This PR breaks the original parse_rgb_or_hsl_color method into several parse_*_color methods for each color function.
It passes all existing ladybird tests (if you want new tests in this PR then I'll need to be told how to add them), and I didn't find any regressions in the web platform tests.
Here's some before and after screenshots from a website that uses oklch:

Hi there, welcome to Ladybird! :^)
I don't have time to properly look at this right now, so I'll come back to it soon. But yes, new tests would be appreciated! If you look through Tests/LibWeb you'll get an idea of what tests look like. I've made a note to add some documentation for this (#398) because we don't have any and people keep asking. :sweat_smile:
Specifically because this is testing colours, which are visual, it would make sense as a reference test in the Ref subdirectory. Those work by having two different pages, which the test runner loads, takes screenshots of, and makes sure they look identical. So you would:

Create an html file in Tests/LibWeb/Ref called something like css-color-functions.html, that uses those color functions.
Then create a "reference" html file in Tests/LibWeb/Ref/reference - by convention the reference for foo.html is foo-ref.html. This would look identical to your test, but use more basic colour definitions, like a hex colour.
Inside your first test file, add <link rel="match" href="reference/ref-test-file-name.html" /> to the <head>, with the name of your reference file. That tells the test runner where to look.

Feel free to ask if you have any more questions. :^)

I've added some tests now (and they helped catch a bug!). There seems to be some kind of accumulated rounding error in a few cases (marked in the reference file) although they're all within 1/256th of the expected rgb values.

You need to run some command to generate the tests expected files, but as this is a Ref test I have no idea which one. A maintainer will chime in on that probably

Do I? The test seems to run correctly (and correctly caught an error at first).

Sorry I was mistaken how a Ref test worked

This caused the following diags on serenity's CI:
/home/runner/work/serenity/serenity/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp:2633:23: error: implicit conversion from 'float' to 'double' to match other operand of binary expression [-Werror=double-promotion]
 2633 |     if (w_val + b_val >= 1.0) {
      |         ~~~~~~~~~~~~~~^~~~~~
/home/runner/work/serenity/serenity/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp: In member function 'AK::Optional<Gfx::Color> Web::CSS::Parser::Parser::parse_oklch_color(const AK::Vector<Web::CSS::Parser::ComponentValue>&)':
/home/runner/work/serenity/serenity/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp:2745:44: error: implicit conversion from 'float' to 'double' to match other operand of binary expression [-Werror=double-promotion]
 2745 |         h_val = hue.token().number_value() * AK::Pi<float> / 180;
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~

I'm mentioning this in case you're not intentionally using more permissive diags in ladybird.

This fixes it, fwiw:
% git diff
diff --git a/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp b/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
index 4c67c4193c..8f31d12349 100644
--- a/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
+++ b/Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
@@ -2630,7 +2630,7 @@ Optional<Color> Parser::parse_hwb_color(Vector<ComponentValue> const& component_
             return {}; // should have consumed all arguments.
     }

-    if (w_val + b_val >= 1.0) {
+    if (w_val + b_val >= 1.0f) {
         u8 gray = clamp(llroundf((w_val / (w_val + b_val)) * 255), 0, 255);
         return Color(gray, gray, gray, clamp(llroundf(alpha_val * 255), 0, 255));
     }
@@ -2742,7 +2742,7 @@ Optional<Color> Parser::parse_oklch_color(Vector<ComponentValue> const& componen
         return {};

     if (hue.is(Token::Type::Number)) {
-        h_val = hue.token().number_value() * AK::Pi<float> / 180;
+        h_val = static_cast<float>(hue.token().number_value()) * AK::Pi<float> / 180;
     } else {
         auto numeric_value = hue.token().dimension_value();
         auto unit_string = hue.token().dimension_unit();