[Breadth Coverage] Portal

Speclet: https://aka.ms/AA7uas2
Files have customizations should focus on:

src/portal/azext_portal/generated/commands.py
src/portal/azext_portal/generated/custom.py
src/portal/azext_portal/generated/_help.py
src/portal/azext_portal/generated/_params.py
src/portal/azext_portal/tests/latest/dashboard.json
src/portal/azext_portal/tests/latest/properties-update.json
src/portal/azext_portal/tests/latest/properties.json
src/portal/azext_portal/tests/latest/test_portal_scenario.py
src/portal/azext_portal/vendored_sdks/portal/operations/_dashboard_operations.py

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:
docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/YalinLi0312/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

Portal

Portal

Nice catch! :)

hi @fengzhou-msft could you pls help Yalin reviewing this? thanks.

@fengzhou-msft Thanks for your review, and addressed your comments. PTAL

In az portal dashboard create, there is only one parameter --input-path. I suggest expose the parameters to users instead of asking for a json file. I don't know how my json file should be like and I can't get help from examples unless I read the REST reference. Only advanced users have the ability and intention to learn REST reference. This design violates the purpose of Azure CLI.
Example in swagger,
{
  "parameters": {
    "dashboardName": "testDashboard",
    "resourceGroupName": "testRG",
    "api-version": "2019-01-01-preview",
    "subscriptionId": "00000000-0000-0000-0000-000000000000",
    "dashboard": {
      "properties": {
        "lenses": {
          "aLens": {
            "order": 1,
            "parts": {
              "aPart": {
                "position": {
                  "x": 1,
                  "y": 2,
                  "rowSpan": 4,
                  "colSpan": 3
                }
              },
              "bPart": {
                "position": {
                  "x": 5,
                  "y": 5,
                  "rowSpan": 6,
                  "colSpan": 6
                }
              }
            }
          },
          "bLens": {
            "order": 2,
            "parts": {}
          }
        },
        "metadata": {
          "metadata": {
            "X": 4,
            "Y": 3,
            "RowSpan": 1,
            "ColSpan": 2
          }
        }
      },
      "location": "eastus",
      "tags": {
        "aKey": "aValue",
        "anotherKey": "anotherValue"
      }
    }
  }

/azp run

In az portal dashboard create, there is only one parameter --input-path. I suggest expose the parameters to users instead of asking for a json file. I don't know how my json file should be like and I can't get help from examples unless I read the REST reference. Only advanced users have the ability and intention to learn REST reference. This design violates the purpose of Azure CLI.
Example in swagger,
{
  "parameters": {
    "dashboardName": "testDashboard",
    "resourceGroupName": "testRG",
    "api-version": "2019-01-01-preview",
    "subscriptionId": "00000000-0000-0000-0000-000000000000",
    "dashboard": {
      "properties": {
        "lenses": {
          "aLens": {
            "order": 1,
            "parts": {
              "aPart": {
                "position": {
                  "x": 1,
                  "y": 2,
                  "rowSpan": 4,
                  "colSpan": 3
                }
              },
              "bPart": {
                "position": {
                  "x": 5,
                  "y": 5,
                  "rowSpan": 6,
                  "colSpan": 6
                }
              }
            }
          },
          "bLens": {
            "order": 2,
            "parts": {}
          }
        },
        "metadata": {
          "metadata": {
            "X": 4,
            "Y": 3,
            "RowSpan": 1,
            "ColSpan": 2
          }
        }
      },
      "location": "eastus",
      "tags": {
        "aKey": "aValue",
        "anotherKey": "anotherValue"
      }
    }
  }

A user should not be expected to configure this file themselves. This files is generated from the portal designer and the user just grabs it from there. They don't need any advanced knowledge or anything of that sorts as you are suggesting. Not sure if the service team was directly consulted on this, though. Also, comments "this design violates the purpose of Azure CLI" aren't very helpful without further explanation.

In az portal dashboard create, there is only one parameter --input-path. I suggest expose the parameters to users instead of asking for a json file. I don't know how my json file should be like and I can't get help from examples unless I read the REST reference. Only advanced users have the ability and intention to learn REST reference. This design violates the purpose of Azure CLI.
Example in swagger,
{
  "parameters": {
    "dashboardName": "testDashboard",
    "resourceGroupName": "testRG",
    "api-version": "2019-01-01-preview",
    "subscriptionId": "00000000-0000-0000-0000-000000000000",
    "dashboard": {
      "properties": {
        "lenses": {
          "aLens": {
            "order": 1,
            "parts": {
              "aPart": {
                "position": {
                  "x": 1,
                  "y": 2,
                  "rowSpan": 4,
                  "colSpan": 3
                }
              },
              "bPart": {
                "position": {
                  "x": 5,
                  "y": 5,
                  "rowSpan": 6,
                  "colSpan": 6
                }
              }
            }
          },
          "bLens": {
            "order": 2,
            "parts": {}
          }
        },
        "metadata": {
          "metadata": {
            "X": 4,
            "Y": 3,
            "RowSpan": 1,
            "ColSpan": 2
          }
        }
      },
      "location": "eastus",
      "tags": {
        "aKey": "aValue",
        "anotherKey": "anotherValue"
      }
    }
  }

The dashboard JSON template can export from the Azure website, this is an easy way user know how the JSON file should look like. For creating a dashboard the cmd is az portal dashboard create --name  --location -rg --input-path <the path to dashboard properties JSON file> --tag. I was planned to expose every parameter to users, but lenses and metadata can be very complex, that's the main reason I put them to one parameter in a JSON file.

If the file can be generated, it is great. My personal understanding of one of goals of Azure CLI: provide a more user-friendly way to manage resource compared to writing and sending HTTP request.
Personally, I like JSON file. It saves lots of time developing CLI commands. But usually we need to expose parameters and add help for them to users. This is how most CLI commands are designed.

/azp run

/azp run Azure.azure-cli-extensions

The CI actually passed, but the status is not updated in the PR. It won't block PR merge.

I find it does not support --ids.
https://github.com/Azure/azure-cli/blob/dev/doc/authoring_command_modules/authoring_commands.md#supporting-the-ids-parameter

I find it does not support --ids.
https://github.com/Azure/azure-cli/blob/dev/doc/authoring_command_modules/authoring_commands.md#supporting-the-ids-parameter

This comment has not been resolved.

I find it does not support --ids.
https://github.com/Azure/azure-cli/blob/dev/doc/authoring_command_modules/authoring_commands.md#supporting-the-ids-parameter

This comment has not been resolved.

since this pr is for portal breadth coverage, it may not be included.
@RodgeFu do you think this support can be involved in CodeGen to avoid customization?

I find it does not support --ids.
https://github.com/Azure/azure-cli/blob/dev/doc/authoring_command_modules/authoring_commands.md#supporting-the-ids-parameter

This comment has not been resolved.

since this pr is for portal breadth coverage, it may not be included.
@RodgeFu Rodge Fu FTE do you think this support can be involved in CodeGen to avoid customization?

sure, issue https://github.com/Azure/autorest.az/issues/339 created for this. thanks.


Support SOCKS proxies

If pysocks is available, urllib3 supports SOCKS proxies, but you can't use the urllib3.ProxyManager class and must instead use urllib3.contrib.socks.SOCKSProxyManager. It would be very nice if sentry_sdk.transport.HttpTransport could detect a proxy set to socks:// (or one of the many variants) and Do The Right Thing.

I vote one.  It is great that sentry_sdk itself has SOCKS proxy support (integrated in the class HttpTransport.).
Rationale:

There are situations we have to use sentry under SOCKS proxy.  E.g., IoT device with restricted network access.
I tried to write external class Socks5HttpTransport, but it's not cool to use.

And then, here's some implementation options.
How to designate proxy URL
A. From http_proxy/https_proxy option, like requests and https://github.com/getsentry/sentry-python/pull/1050 .
B. From other new option like socks_proxy.
I guess the members of sentry prefer B because https://github.com/getsentry/sentry-python/issues/178#issuecomment-460059346 .

@untitaker @ahmedetefy Could you let us know your thoughts?


type-based constraints are slightly incorrect for positive numbers

https://github.com/wesleyi23/GTFS-Frictionless/blob/master/lookup_tables/type_based_constraints.csv

"Positive integer" minimum should be 1
"Positive float" minimum should be 1.175494e-38 (per https://stackoverflow.com/a/39232328)

Thanks for looking at this. These are now updated.

Thanks for looking at this. These are now updated.


IphoneX + SafeArea + landscape + pushReplacement = screen flicker

I have an app on the Apple store :
https://itunes.apple.com/us/app/aac-keyboard-with-friends/id1434587499?ls=1&mt=8
Unfortunately I get a flickering screen on the IPhone X. It is primarily intended to be used in landscape mode. I have reproduced the problem with a small amount of code. Attached are the minimum files which reproduce the glitches.
glitches.tar.gz
@cbracken

Attached are 2 screen recording video files which show the screen glitches as they happen.
glitch_vids.tar.gz

[✓] Flutter (Channel master, v0.8.5-pre.7, on Mac OS X 10.13.6 17G65, locale en-CA)
• Flutter version 0.8.5-pre.7 at /work/installs/flutter
• Framework revision 2bca8007bd (3 days ago), 2018-09-16 12:30:34 -0400
• Engine revision 72665c6827
• Dart version 2.1.0-dev.4.0.flutter-bb56d4592f
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.1)
• Android SDK at /Users/david/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.1
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
• All Android licenses accepted.
[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 9.4.1, Build version 9F2000
• ios-deploy 1.9.2
• CocoaPods version 1.5.3
[✓] Android Studio (version 3.1)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 28.0.1
• Dart plugin version 173.4700
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
[✓] Connected devices (1 available)
• iPhone X • 9717A4E1-0F44-455A-979D-3CBD0B7D8BD0 • ios • iOS 11.4 (simulator)
• No issues found!

@Rockvole thanks for reporting!
Labelling as both framework and engine until we've figured out where the issue lies (possibly both).
/cc @HansMuller @Hixie who are far more familiar with routes/navigation than I am for ideas, and @GaryQian who's currently looking at some SafeArea-related issues.

Thanks @cbracken . Does anyone know if the new flutter release preview 2 will have changes to fix this problem ? I actually have not seen the problem myself (I don't have an IPhone X) its my friend who lives 1,000s of miles away (he is a developer) - he was helping me using testflight.

Problem still present in
Flutter (Channel master, v0.11.1-pre.57, on Mac OS X 10.13.6 17G65, locale en-CA)

Are you still seeing this?

Looks like it is fixed - thank-you.
Tested in :
Flutter 1.2.2-pre.43 • channel master • https://github.com/flutter/flutter.git
Framework • revision 5169ab5974 (8 hours ago) • 2019-02-21 09:27:07 +0100
Engine • revision 6d7eb52185
Tools • Dart 2.1.2 (build 2.1.2-dev.0.0 c92d5ca288)


[Bug]: Failed to generate an image and displayed "AssertionError: could not find upscaler named SwinIR_4x"

What happened?
"AssertionError: could not find upscaler named SwinIR_4x" was displayed when using model deliberate_v2 to generate images failed
Colab cell output
Total progress: 0it [00:00, ?it/s]Error completing request
Arguments: ('task(lr12fuphifbbrmg)', "(Masterpiece, 4K resolution, ultra-realistic, very detailed:1.3), tall and curvy woman with loose ponytail framing her face, wearing a fully ripped open white Spider-Man costume revealing her plump and round breasts:1.2, shiny smooth skin with small freckles and sweat droplets that shows pores, detailed face with deep ((blue eyes:1.2)) and (rosy lips:1.1) that look inviting. Her body features a thin (waist:1.1), wide and rounded hips, thick legs and round buttocks:1.1. She stands confidently on the side of a building, hanging from a web, looking directly at the viewer, daring them to resist her charms. The surrounding environment is a sandy urban cityscape that is dimly lit by dynamic lights and a full moon.\nIn the background, there's a girl on top of town, beautiful shaded face, wearing the same Spider-Man costume as the protagonist, she's another superheroine who looks charismatic. She is shown in a spider-man pose with a show of strength, jumping from one building to another. The sandy urban environment shows rough texture and has a photorealistic feel (0.8). It contains sparks and sunlight that make it vibrant and colorful.\nThe entire image is shot using a DSLR camera with natural lighting and subsurface scattering. It has a film grain effect, which gives it a raw photo feel. The image quality is at high-resolution UHD (8k), making it sharp and clear. The composition is symmetrical, with the main focus being on the protagonist. The image has won multiple awards for its hyper-detailed and vivid depiction of White Spider-Woman in action.\nOverall, the painting portrays a seductive and confident female superheroine with exquisite physical features, hanging on the side of a building, ready to save the city from any danger that might arise.", 'mask, bad-hands-5, badhandv4, easynegative, By bad artist, monotone, low quality, close up, cropped, greyscale, watermark, hands, finger, cleavage, child', [], 50, 13, True, False, 1, 1, 6,<PHONE_NUMBER>.0, -1.0, 0, 0, 0, False, 768, 512, True, 0.3, 2, 'SwinIR_4x', 0, 0, 0, [], 0, False, '', 0, False, False, 'LoRA', 'None', 0, 0, 'LoRA', 'None', 0, 0, 'LoRA', 'None', 0, 0, 'LoRA', 'None', 0, 0, 'LoRA', 'None', 0, 0, None, 'Refresh models', <scripts.controlnet_ui.controlnet_ui_group.UiControlNetUnit object at 0x7fd5390764a0>, False, '1:1,1:2,1:2', '0:0,0:0,0:1', '0.2,0.8,0.8', 150, 0.2, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, False, False, 'positive', 'comma', 0, False, False, '', '', 1, '', 0, '', 0, '', True, False, False, False, 0, None, None, False, 50) {}
Traceback (most recent call last):
  File "/content/drive/MyDrive/stable-diffusion-webui-colab/stable-diffusion-webui/modules/call_queue.py", line 56, in f
    res = list(func(*args, **kwargs))
  File "/content/drive/MyDrive/stable-diffusion-webui-colab/stable-diffusion-webui/modules/call_queue.py", line 37, in f
    res = func(*args, **kwargs)
  File "/content/drive/MyDrive/stable-diffusion-webui-colab/stable-diffusion-webui/modules/txt2img.py", line 56, in txt2img
    processed = process_images(p)
  File "/content/drive/MyDrive/stable-diffusion-webui-colab/stable-diffusion-webui/modules/processing.py", line 503, in process_images
    res = process_images_inner(p)
  File "/content/drive/MyDrive/stable-diffusion-webui-colab/stable-diffusion-webui/extensions/sd-webui-controlnet/scripts/batch_hijack.py", line 42, in processing_process_images_hijack
    return getattr(processing, '__controlnet_original_process_images_inner')(p, *args, **kwargs)
  File "/content/drive/MyDrive/stable-diffusion-webui-colab/stable-diffusion-webui/modules/processing.py", line 653, in process_images_inner
    samples_ddim = p.sample(conditioning=c, unconditional_conditioning=uc, seeds=seeds, subseeds=subseeds, subseed_strength=p.subseed_strength, prompts=prompts)
  File "/content/drive/MyDrive/stable-diffusion-webui-colab/stable-diffusion-webui/modules/processing.py", line 866, in sample
    assert len([x for x in shared.sd_upscalers if x.name == self.hr_upscaler]) > 0, f"could not find upscaler named {self.hr_upscaler}"
AssertionError: could not find upscaler named SwinIR_4x

Which colab and model(s) were you using when the error occurred?
https://github.com/camenduru/stable-diffusion-webui-colab/tree/drive
model ：deliberate_v2
Which Public WebUI Colab URL were you using when the error occurred?
trycloudflare.com
If you used HiRes mode when the error occurred, please provide the Hires info
No response

Please try selecting the upscaler manually after loading configurations.

maybe fixed please try again

Based on my experience, the upscaler name consistently changes from SwinIR_4x to SwinIR 4x every time I start the sdwebui.
This issue occurs in both the original version and this Colab versions.


Idea - Expose some kind of service?

Hello
To take the package one step further, maybe it would be a good idea to expose a service that allows other packages to access information we're already reading (such as proxy.methods, a getCurrentMethod method, ...). The base we're developing here has so much potential beyond our current scope:

We could lint class names that we don't recognize (we're already scanning for class names in comments anyway).
We could lint members that aren't recognized or are incorrectly accessed (e.g. private methods from an outside scope).
We could lint docblocks if the type hint isn't the same as the docblock (or parameters are missing).
We could automatically generate getters and setters for known properties of classes.
We could automatically create missing properties the caret is on when pressing a shortcut such as alt-enter.
We could automatically create missing interface methods or abstract methods that need to be implemented the caret is on.
...

I would like to do all of these things myself but just as you (and probably everyone) I don't have an infinite supply of time and I'd rather spend it focusing on bugfixes and improvements on the current code right now. Maybe exposing a service that allows access to our information will encourage other developers to start developing these features and keep the scope of this package contained? Ideally Atom could even be turned into a full PHP IDE by installing this package along with other packages that do the things listed above!
Thanks in advance

Hello,
Interesting in fact, but I prefer joining all efforts in a same package (so having contributions to improve this one), in order to avoid installing 100 packages.
But, I would like to provide some events to enable framework's plugins. Because framework specific support should not be part of this plugin in my opinion. But perhaps it should. I don't know..

Even though it allows you to easily disable parts (and compilation) of code you don't require, I must say I agree with finding it more convenient to have one central package.
I guess the problem we currently have, is that the name of the package is not really correct anymore; we're already doing a lot more than just autocompletion (tooltips, code navigation, annotations, ...). The question then becomes: "If the current name isn't good anymore, what would be a good name?".
What we're doing right now is already evolving towards basic IDE-like functionality. However, people have widely varying thoughts on what an IDE should and shouldn't do. For example, a lot of people might also start expecting debugger integration. This is something we could also do. I guess all of this depends a bit on how far (or not) you want to take this package?

I just wanted to let you know that I'm doing some experimenting with this so you have a better idea what I'm thinking of ([1] and [2]). Regarding the problem of having too many small packages, would it perhaps be a solution to have some kind of convenience 'bundle' package that uses e.g. Git submodules to fetch all the repositories and then directly activates all the subpackages by itself?
[1] https://github.com/Gert-dev/php-integrator-base
[2] https://github.com/Gert-dev/php-integrator-tooltips

I don't like.
I don't want to take time to maintain some modules completely decoupled. I want to keep the possibility to add an ugly fix in some files if there's a big bug with just side effects on this plugin and not on an other one.
Perhaps the plugin should be renamed in fact, because it gives more than autocomplete today.
Note : If this plugin were not rely on composer to work, decoupling things would be interesting, but here it's too specific to composer.

Hello,
As I see, you're now working on your side.
Should I remove you from repository collaborator or will you contribute there again ?
Thank you for your answer,
Peekmo

Hello
You are correct, but was never my intention to create a competing fork. What you say here is certainly valid and I respect your opinion, so I didn't want to disturb you further with this. However, I feel I must try this out to see if it will benefit the community (in the sense that it might stimulate the creation of more PHP-related packages.
What I wanted to do is create several packages that each use the service from the base package (which handles indexing and exposes convenient functionality) and handle their own tasks: tooltips, autocompletion, annotations, etc. In theory it would also be possible to make this package a 'consumer' of the service that I'm now exposing in the 'base' package (which is essentially just the PHP side, proxy, parser, config, etc.). However, you already stated that you'd rather avoid this, which of course is a valid choice. On the other hand this leaves me with the choice to either drop my idea completely or do it anyway, but at the cost of our collaboration. I can't really say I'm happy with either of these choices as I enjoy working on this package with you.
If you wish, you may remove me as collaborator. If I find any serious bugs, I'll continue to report them here so you can also benefit from this.

Hi,
No problem, so I remove you as you're not happy from these choices and you'll (of course) not working on it anymore.
Regards


Extract Indirect call's Targets

Hi, is there any api to extract indirect call's targets?
Thanks!

Yes, you'll want to use the .possible_value APIs: https://api.binary.ninja/search.html?q=possible&check_keywords=yes&area=default
The simplest way to do that is to find the MLIL instruction of a call and access the .possible_value attribute on the variable representing the register. If our data-flow system was able to calculate the range on the register it will be returned there. If you get undefined then it's likely the result of something like a virtual function call that isn't calculable within the existing function and requires inter-function dataflow which we don't automatically calculate due to path explosion.

Great! Thx!


ImportError: cannot import name '_unicodefun' from 'click'

🐛 Bug Report
This error occurs.
make pre-commit-install
> ImportError: cannot import name '_unicodefun' from 'click'

https://github.com/psf/black/issues/2964
I can fix by this command
poetry add click==8.0.2

This is also fixed by upgrading black in your project.
https://stackoverflow.com/questions/71673404/importerror-cannot-import-name-unicodefun-from-click
I would just upgrade the black version in your local project in the poetry files.
It would also probably make sense to upgrade black in the cookie cutter template

You can also pin the click package in the .toml file by setting
click = "8.0.2"


Don't suggest NumericUnderscores for four-digit numbers

This is related to #578 and excludes the common case of four digit integers.

Thanks, this looks great!


Timing-problems at waveforms and wavechains

I use your PIGPIO library on a „Raspbian Pi 3 Model B V 1.2“ for sending Infrared signals. That did not work.
Using your tool „irrp.py“ I can read the signals sent from my remote-control. But sending this to my TV did not work because of wrong timing (??)
I recorded the wave while sending it – both with „irrp.py“. This is the result („PWR“ recorded from the remote-control, „PWR1“ recorded while sending)
{"PWR": [900, 2299, 459, 1633, 459, 938, 459, 938, 459, 1633, 459, 1633, 459, 1633, 459, 938, 459, 938, 459, 938, 459, 1633, 459, 938, 459, 1633, 459, 938, 459, 1633, 459, 1633, 459, 938, 459, 1633, 459, 938, 459, 1633, 459],
"PWR1": [1844, 4563, 967, 3249, 967, 1773, 967, 1773, 967, 3249, 967, 3249, 967, 3249, 967, 1773, 967, 1773, 967, 1773, 967, 3249, 967, 1773, 967, 3249, 967, 1773, 967, 3249, 967, 3249, 967, 1773, 967, 3249, 967, 1773, 967, 3249, 967]}
I startet the test-scripts:
x_pigpio.py
Connected to pigpio daemon.
Testing pigpio Python module 1.78
Python 2.7.16 (default, Oct 10 2019, 22:02:15)  [GCC 8.3.0] pigpio version 78.
Hardware revision 10625154.
reported errors:
TEST  5.4  FAILED got 25 (callback: 50)
TEST  5.10 FAILED got 1743 (wave tx busy, callback: 1702)
TEST  5.11 FAILED got 0 (wave tx busy, serial read: 1)
TEST  5.26 FAILED got 25 (callback: 50)
TEST 13.7 FAILED got 2688 (glitch filter, wave chain, tally: 1792)
TEST 13.8  FAILED got 1792 (glitch filter, wave chain, tally: 896)
TEST 13.9  FAILED got 1792 (glitch filter, wave chain, tally: 0)
TEST 13.10 FAILED got 748 (noise filter, wave chain, tally: 1500)
TEST 13.12 FAILED got 13 (noise filter, wave chain, tally: 0)
I created a work-around, because it seams that sending takes nearly twice the time:
in "irrp.py" I created a new line between 463 (ci = code[i]) and 464 (if i and 1:)
"ci = int(ci/2)"
This pulse-tuning works good for me. Maybe there is a better way, but it works.

Something is wrong in your system configuration.  You should be able to run a clean (100% pass) of the python tests.

reported errors:
TEST 5.4 FAILED got 25 (callback: 50)
TEST 5.10 FAILED got 1743 (wave tx busy, callback: 1702)
TEST 5.11 FAILED got 0 (wave tx busy, serial read: 1)
TEST 5.26 FAILED got 25 (callback: 50)
TEST 13.7 FAILED got 2688 (glitch filter, wave chain, tally: 1792)
TEST 13.8 FAILED got 1792 (glitch filter, wave chain, tally: 896)
TEST 13.9 FAILED got 1792 (glitch filter, wave chain, tally: 0)
TEST 13.10 FAILED got 748 (noise filter, wave chain, tally: 1500)
TEST 13.12 FAILED got 13 (noise filter, wave chain, tally: 0)

You may want to experiment with setting core_freq=250 in /boot/config.txt.

I have a similar problem with pigpio controlling a stepper motor.
The application was working correctly but recently, probably after rpi-update, the motor is running half as fast.
If I multiply the frequency of the wave by two the speed is good as before !
Kernel version:
Linux raspberrypi 5.10.14-v7+ #1401 SMP Mon Feb 8 14:23:24 GMT 2021 armv7l GNU/Linux

Please verify that you have not enabled audio inadvertently - connecting hdmi to monitor,  enabling sound in config.txt.
Try running the daemon using the alternate clock source, PWM: sudo pigpio -t 0

No audio or HDMI
With the alternate source normal behavior and normal speed for the motor.
This factor 2 is intriguing, there have probably been changes in the firmware and/or kernel (with rpi-update I get the version under development)
Not blocking for me but tell me if I need to do more tests.
Thanks !

@RolfKausH
Did you update you Pi recently ?

With the alternate (clock) source normal behavior and normal speed for the motor.

Something is now altering the PCM peripheral after the fw update.  The usual suspects are ALSA, pulseaudio.

The raspberrypi forum has a lot of chatter about recent changes in the audio system:

Since December 2020 Raspberry Pi with Desktop Operating Systems* have
utilised PulseAudio Sound Server which sits atop ALSA to handle ALL Audio I/O.

Thank you,
Yes I've seen changes in pulse audio in the last updates, but the debug is a bit beyond my skills !
I would like to take this opportunity to thank you for your work on pigpio.

I've seen changes in pulse audio in the last updates, but the debug is a bit beyond my skills !

Mine also.  You mention that this issue is non-blocking for you but have you since found a workaround or any additional insight into the problem?
Cheers.

I use the alternate source clock as you suggested to me.

Thank you @dgalland  for your input.
@RolfKausH , I'm closing this issue since there has been no dialogue with you.


Build failure when building Tensorflow MLIR

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 18.04.3 LTS
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): source
TensorFlow version: 7221ec4eace8d163954fd391c8f8e5accd3ae771
Python version: Python 3.6.9
Installed using virtualenv? pip? conda?:
Bazel version (if compiling from source): 3.7.2
GCC/Compiler version (if compiling from source): 7.5.0
CUDA/cuDNN version:
GPU model and memory:

Describe the problem
A build failure is seen while compiling for MLIR from the current HEAD, using a standard build command that's otherwise always worked. The error appears to be absl usage related, within  tensorflow/compiler/mlir/tfrt/jit/tf_cpurt_kernels.cc
Assumed this was transient, but it has been present for 4 days now.
Provide the exact sequence of commands / steps that you executed before running into the problem
$ bazel build --config=v2 --linkopt="-fuse-ld=lld" tensorflow/compiler/mlir/...  -j 32
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
ERROR: {$MYPATH}/tensorflow/compiler/mlir/tfrt/BUILD:136:16: C++ compilation of rule '//tensorflow/compiler/mlir/tfrt:tf_cpurt_kernels' failed (Exit 1): gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 419 argument(s) skipped)
In file included from ./tensorflow/core/profiler/lib/traceme.h:27:0,
from tensorflow/compiler/mlir/tfrt/jit/tf_cpurt_kernels.cc:32:
./tensorflow/core/profiler/lib/traceme_encode.h: In instantiation of 'tensorflow::profiler::TraceMeArg::TraceMeArg(absl::lts_20210324::string_view, Value) [with Value = llvm::StringRef]':
tensorflow/compiler/mlir/tfrt/jit/tf_cpurt_kernels.cc:285:70:   required from here
./tensorflow/core/profiler/lib/traceme_encode.h:35:61: error: no matching function for call to 'absl::lts_20210324::AlphaNum::AlphaNum(llvm::StringRef&)'
TraceMeArg(absl::string_view k, Value v) : key(k), value(v) {}
^
In file included from external/com_google_absl/absl/container/internal/layout.h:176:0,
from external/com_google_absl/absl/strings/internal/cord_rep_ring.h:25,
from external/com_google_absl/absl/strings/cord.h:81,
from ./tensorflow/core/platform/default/cord.h:22,
from ./tensorflow/core/platform/cord.h:25,
from ./tensorflow/core/platform/tstring.h:24,
from ./tensorflow/core/platform/types.h:23,
from ./tensorflow/core/platform/logging.h:20,
from ./tensorflow/core/platform/status.h:25,
from ./tensorflow/core/lib/core/status.h:19,
from ./tensorflow/core/util/device_name_utils.h:21,
from ./tensorflow/compiler/mlir/tensorflow/ir/tf_structs.h:28,
from ./tensorflow/compiler/mlir/tensorflow/ir/tf_op_interfaces.h:27,
from ./tensorflow/compiler/mlir/tensorflow/ir/tf_ops.h:39,
from ./tensorflow/compiler/mlir/tensorflow/dialect_registration.h:24,
from tensorflow/compiler/mlir/tfrt/jit/tf_cpurt_kernels.cc:24:
external/com_google_absl/absl/strings/str_cat.h:283:3: note: candidate: template<class T, typename std::enable_if<(std::is_class<_Tp>::value && (std::is_same<T, std::_Bit_reference>::value || std::is_same<T, bool>::value))>::type*  > absl::lts_20210324::AlphaNum::AlphaNum(T)
AlphaNum(T e) : AlphaNum(static_cast(e)) {}  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:283:3: note:   template argument deduction/substitution failed:
external/com_google_absl/absl/strings/str_cat.h:282:11: error: no type named 'type' in 'struct std::enable_if<false, void>'
nullptr>
^~~~~~~
external/com_google_absl/absl/strings/str_cat.h:282:11: note: invalid template non-type parameter
external/com_google_absl/absl/strings/str_cat.h:271:3: note: candidate: template<class T, class> absl::lts_20210324::AlphaNum::AlphaNum(T)
AlphaNum(T e)  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:271:3: note:   template argument deduction/substitution failed:
external/com_google_absl/absl/strings/str_cat.h:269:13: error: no type named 'type' in 'struct std::enable_if<false, void>'
typename = typename std::enable_if<
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:252:3: note: candidate: template absl::lts_20210324::AlphaNum::AlphaNum(const std::__cxx11::basic_string<char, std::char_traits, Allocator>&)
AlphaNum(  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:252:3: note:   template argument deduction/substitution failed:
In file included from ./tensorflow/core/profiler/lib/traceme.h:27:0,
from tensorflow/compiler/mlir/tfrt/jit/tf_cpurt_kernels.cc:32:
./tensorflow/core/profiler/lib/traceme_encode.h:35:61: note:   'llvm::StringRef' is not derived from 'const std::cxx11::basic_string<char, std::char_traits, Allocator>'
TraceMeArg(absl::string_view k, Value v) : key(k), value(v) {}
^
In file included from external/com_google_absl/absl/container/internal/layout.h:176:0,
from external/com_google_absl/absl/strings/internal/cord_rep_ring.h:25,
from external/com_google_absl/absl/strings/cord.h:81,
from ./tensorflow/core/platform/default/cord.h:22,
from ./tensorflow/core/platform/cord.h:25,
from ./tensorflow/core/platform/tstring.h:24,
from ./tensorflow/core/platform/types.h:23,
from ./tensorflow/core/platform/logging.h:20,
from ./tensorflow/core/platform/status.h:25,
from ./tensorflow/core/lib/core/status.h:19,
from ./tensorflow/core/util/device_name_utils.h:21,
from ./tensorflow/compiler/mlir/tensorflow/ir/tf_structs.h:28,
from ./tensorflow/compiler/mlir/tensorflow/ir/tf_op_interfaces.h:27,
from ./tensorflow/compiler/mlir/tensorflow/ir/tf_ops.h:39,
from ./tensorflow/compiler/mlir/tensorflow/dialect_registration.h:24,
from tensorflow/compiler/mlir/tfrt/jit/tf_cpurt_kernels.cc:24:
external/com_google_absl/absl/strings/str_cat.h:249:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(absl::lts_20210324::string_view)
AlphaNum(absl::string_view pc) : piece(pc) {}  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:249:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'absl::lts_20210324::string_view'
external/com_google_absl/absl/strings/str_cat.h:248:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(const char*)
AlphaNum(const char* c_str) : piece(c_str) {}  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:248:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'const char*'
external/com_google_absl/absl/strings/str_cat.h:244:3: note: candidate: template absl::lts_20210324::AlphaNum::AlphaNum(const absl::lts_20210324::strings_internal::AlphaNumBuffer&)
AlphaNum(  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:244:3: note:   template argument deduction/substitution failed:
In file included from ./tensorflow/core/profiler/lib/traceme.h:27:0,
from tensorflow/compiler/mlir/tfrt/jit/tf_cpurt_kernels.cc:32:
./tensorflow/core/profiler/lib/traceme_encode.h:35:61: note:   'llvm::StringRef' is not derived from 'const absl::lts_20210324::strings_internal::AlphaNumBuffer'
TraceMeArg(absl::string_view k, Value v) : key(k), value(v) {}
^
In file included from external/com_google_absl/absl/container/internal/layout.h:176:0,
from external/com_google_absl/absl/strings/internal/cord_rep_ring.h:25,
from external/com_google_absl/absl/strings/cord.h:81,
from ./tensorflow/core/platform/default/cord.h:22,
from ./tensorflow/core/platform/cord.h:25,
from ./tensorflow/core/platform/tstring.h:24,
from ./tensorflow/core/platform/types.h:23,
from ./tensorflow/core/platform/logging.h:20,
from ./tensorflow/core/platform/status.h:25,
from ./tensorflow/core/lib/core/status.h:19,
from ./tensorflow/core/util/device_name_utils.h:21,
from ./tensorflow/compiler/mlir/tensorflow/ir/tf_structs.h:28,
from ./tensorflow/compiler/mlir/tensorflow/ir/tf_op_interfaces.h:27,
from ./tensorflow/compiler/mlir/tensorflow/ir/tf_ops.h:39,
from ./tensorflow/compiler/mlir/tensorflow/dialect_registration.h:24,
from tensorflow/compiler/mlir/tfrt/jit/tf_cpurt_kernels.cc:24:
external/com_google_absl/absl/strings/str_cat.h:241:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(absl::lts_20210324::Dec)
AlphaNum(Dec dec);  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:241:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'absl::lts_20210324::Dec'
external/com_google_absl/absl/strings/str_cat.h:240:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(absl::lts_20210324::Hex)
AlphaNum(Hex hex);  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:240:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'absl::lts_20210324::Hex'
external/com_google_absl/absl/strings/str_cat.h:237:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(double)
AlphaNum(double f)  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:237:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'double'
external/com_google_absl/absl/strings/str_cat.h:235:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(float)
AlphaNum(float f)  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:235:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'float'
external/com_google_absl/absl/strings/str_cat.h:231:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(long long unsigned int)
AlphaNum(unsigned long long x)  // NOLINT()
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:231:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'long long unsigned int'
external/com_google_absl/absl/strings/str_cat.h:228:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(long long int)
AlphaNum(long long x)  // NOLINT()
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:228:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'long long int'
external/com_google_absl/absl/strings/str_cat.h:225:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(long unsigned int)
AlphaNum(unsigned long x)  // NOLINT()
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:225:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'long unsigned int'
external/com_google_absl/absl/strings/str_cat.h:222:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(long int)
AlphaNum(long x)  // NOLINT()
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:222:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'long int'
external/com_google_absl/absl/strings/str_cat.h:219:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(unsigned int)
AlphaNum(unsigned int x)  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:219:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'unsigned int'
external/com_google_absl/absl/strings/str_cat.h:216:3: note: candidate: absl::lts_20210324::AlphaNum::AlphaNum(int)
AlphaNum(int x)  // NOLINT(runtime/explicit)
^~~~~~~~
external/com_google_absl/absl/strings/str_cat.h:216:3: note:   no known conversion for argument 1 from 'llvm::StringRef' to 'int'
INFO: Elapsed time: 3705.770s, Critical Path: 377.10s
INFO: 11312 processes: 719 internal, 10593 local.
FAILED: Build did NOT complete successfully

I think this should be fixed now. Please reopen if that's not the case.
Culprit: TFRT introduced C++17 code via MLIR/LLVM but TF is using C++14.


Labels for unlabeled data

Hi, I want to test mcnet2d model on my in-house dataset and I have one question regarding of use of unlabeled data. Code was running successfully with ACDC data because all images had labels but when using my in-house dataset it throws error because unlabeled data in my case doesn't have labels. Question is would it be ok if I use random labels for unlabeled data? Thanks

Random labels cannot evaluate the performance of given unlabeled data. You can only output the predictions and ignore the performance evaluation part. If you apply random labels, the obtained performance is not reliable. Thanks.

Thank you, what if I divide my labeled data 80/20 and train my model with 80% labeled + unlabeled data and then evaluate on remaining 20?

That would be fine


get_xs_points() to multiple points

Hey @dblodgett-usgs great stuff as always! I'm really digging the new get_xs_points() function and had an idea of allowing more than two points at the fork here. The idea is to take each point within a sf object (geometry = 'POINT'); apply the check_point() function; then loop through the points while updating the distance_m variable on each iteration. I've played around with it and seems to work pretty well with multiple points (even and odd) and different num_pts (even and odd). Let me know what you think and I can do a PR? Thanks again for the efforts with this package as it's one of my favs to use for work (resource management).

Been a bit since I looked at that code. Go ahead and open a PR. Can you put in a little reprex with a graphic too so I can see what it does?


Upgrades to Hive 3

This is the doc for operating Hive 3: https://cwiki.apache.org/confluence/display/Hive/AdminManual+Metastore+3.0+Administration
Notice that I used standalone release so the container tag should be 3.0.0.
The trick of altering guava-19.0.jar with guava-27.0-jre.jar from Hadoop package comes from https://blog.csdn.net/weixin_43231331/article/details/103066837

Why delete the log4j properties file?

there's default one under ${HIVE_HOME}/conf/log4j.properties so we don't need to customize it again since the default one meets our need. (no super long logs anymore)


Can't build crash-context on arm-unknown-linux-gnueabihf

I'm unable to build crash-context on arm-unknown-linux-gnueabihf, either locally (using a raspberry pi) or using github actions: https://github.com/msirringhaus/minidump_writer_linux/actions/runs/1992494641
Unfortunately, the error is only

error: could not compile crash-context

even when running --verbose.
Is this supposed to work?

These are working fine:
- x86_64-unknown-linux-gnu
- x86_64-unknown-linux-musl
- i686-unknown-linux-gnu
- aarch64-unknown-linux-gnu
https://github.com/msirringhaus/minidump_writer_linux/actions/runs/1992598643

Hmm, I will install cross locally and try and figure out what the actual error is, as you say the error output from GHA is useless.

I can't even get cross working locally at all because I use podman and using main switched to GHCR which doesn't have proper image tags. :stuck_out_tongue:

I suspected it was the global_asm! and sure enough I had missed replacing a preprocessor define with its constant during the port. It gives a not great error when building the package directly, but at least show the line that was problematic, but appears to just entirely give up when being compiled as a dependency, even for crates in the same workspace.

I've bumped and published crash-context to 0.0.2.

I am still having the same issue for ARM v7 cross compilatoin. Somehow inserting "nop" seems to solve the problem for me. Could someone look into this again?
// Return 0
"mov   r0, #0",
"nop",
"bx    lr",

Can you please add what target triple doesn't compile and what the compile error actually is? `armv7-unknown-linux-gnueabihf`` compiles just fine.

Can you please add what target triple doesn't compile and what the compile error actually is? armv7-unknown-linux-gnueabihf compiles just fine.

Here is the mysterious error message:
error: :23:1: invalid instruction, any one of the following would fix this:
bx    lr
^
error: could not compile crash-context (lib)

Ok well I'm not seeing that, either you are using a different target triple or you're on an older version of rustc?

Ok well I'm not seeing that, either you are using a different target triple or you're on an older version of rustc?

The error only occurs when using the 'release' flag. Building without this flag ('cross build') is successful.

https://github.com/EmbarkStudios/crash-handling/pull/89


updated storybook to 6.4

Overview

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61b12001197024497462f092--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61c226a34c42e464fb1e550c--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://61d31992add95ebaca46c241--gamut-preview.netlify.appDeploy Logs


snowflake roles appear as deleted after upgrading from provider 0.84.1 to 0.85.0

Terraform CLI and Provider Versions
Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:

  # module.team_roles["A"].module.team_role.snowflake_role.role has been deleted
  - resource "snowflake_role" "role" {
        id      = "a"
      - name    = "A" -> null
        # (1 unchanged attribute hidden)
    }

  # module.team_roles["B"].module.team_role.snowflake_role.role has been deleted
  - resource "snowflake_role" "role" {
        id      = "b"
      - name    = "B" -> null
        # (1 unchanged attribute hidden)
    }

Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  ~ update in-place
 <= read (data resources)

Terraform will perform the following actions:

  # module.team_roles["A"].module.team_role.snowflake_role.role will be created
  + resource "snowflake_role" "role" {
      + comment = "A ROLE"
      + id      = (known after apply)
      + name    = "A"
    }

  # module.team_roles["B"].module.team_role.snowflake_role.role will be created
  + resource "snowflake_role" "role" {
      + comment = "B ROLE"
      + id      = (known after apply)
      + name    = "B"
    }

Plan: 7 to add, 1 to change, 0 to destroy.

Warning: Account role not found; marking it as removed

  with module.team_roles["A"].module.team_role.snowflake_role.role,
  on ../../../modules/snowflake/role/main.tf line 1, in resource "snowflake_role" "role":
   1: resource "snowflake_role" "role" {

Account role name: "a", err: object does not exist

(and 6 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Terraform Configuration
terraform {

  required_version = ">= 1.7.0"

  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "~> 5.33"
    }
    snowflake = {
      source  = "Snowflake-Labs/snowflake"
      version = "0.85.0"
    }
  }
}

provider "snowflake" {
  account       = local.snowflake_account_id
  authenticator = "JWT"
}

provider "snowflake" {
  alias         = "account_admin"
  role          = "ACCOUNTADMIN"
  account       = local.snowflake_account_id
  authenticator = "JWT"
}

provider "snowflake" {
  alias         = "security_admin"
  role          = "SECURITYADMIN"
  account       = local.snowflake_account_id
  authenticator = "JWT"
}

provider "snowflake" {
  alias         = "sys_admin"
  role          = "SYSADMIN"
  account       = local.snowflake_account_id
  authenticator = "JWT"
}

Expected Behavior
I expected my terraform plan to no changes besides deprecated resource warning. I am upgrading from provider version 0.84.1 to 0.85.0
Actual Behavior
Snowflake is saying that the roles it is managing have deleted outside of terraform. When I run SHOW ROLES; in snowsql, I see the roles that terraform is saying was deleted
Steps to Reproduce

create a role using provider 0.84.1 or older
upgrade to provider 0.85.0
terraform init
terraform plan

How much impact is this issue causing?
Medium
Logs
No response
Additional Information
No response

+1 with this; same issue.

Hey @jacobcbeaudin @philippeboyd
Could you help with the steps to reproduce the error? I created a role in 0.84.1 and upgraded to 0.85.0 without any changes suggested by the terraform plan.
Tested config (also tested with lowercase):
resource "snowflake_role" "test" {
  name = "TEST_ROLE_TEST_UPGRADE"
}

@sfc-gh-jcieslak honestly not sure how to reproduce it on my end, it happened with a role inside a module, but I'm putting my money on this commit specifically
I'll have to reverse engineer the commit to understand what could've gone wrong...

Hey @jacobcbeaudin @philippeboyd Could you help with the steps to reproduce the error? I created a role in 0.84.1 and upgraded to 0.85.0 without any changes suggested by the terraform plan. Tested config (also tested with lowercase):
resource "snowflake_role" "test" {
  name = "TEST_ROLE_TEST_UPGRADE"
}

To clarify, the roles in question were not initially created with version 0.84.1 of the Snowflake provider; they were created with an even earlier version, and since then, we have been consistently upgrading the provider across several versions up to 0.85.0. This iterative upgrade process over multiple versions might be contributing to the observed behavior.
Additionally, I should mention that our Terraform configuration uses an S3 remote backend for state storage. This detail might also play a role in how state discrepancies and external changes are detected by Terraform.
Given these nuances—specifically the use of an earlier version for initial role creation and the continual provider upgrades, as well as the configuration of an S3 remote backend—could these factors be influencing the issue at hand?

@sfc-gh-jcieslak honestly not sure how to reproduce it on my end, it happened with a role inside a module, but I'm putting my money on this commit specifically

So, we already checked that commit a few times and couldn't spot any difference in the inner workings of the provider.

To clarify, the roles in question were not initially created with version 0.84.1 of the Snowflake provider; they were created with an even earlier version, and since then, we have been consistently upgrading the provider across several versions up to 0.85.0.

We also tried to upgrade from earlier versions like v0.80.0, but still couldn't reproduce the described behavior. Please, try to provide working steps to reproduce the issue. Otherwise, I can only suggest importing the state back with Terraform CLI. It's described in our latest migration guide for the grants, but that applies to any other resource. It's here - if you don't have those resources in your state you can start with 3rd point to import the state back.
In the case of the external state storage, maybe @sfc-gh-swinkler knows if that could be the root cause, but I'm assuming that it shouldn't be any different than local state management.

@sfc-gh-jcieslak honestly not sure how to reproduce it on my end, it happened with a role inside a module, but I'm putting my money on this commit specifically

So, we already checked that commit a few times and couldn't spot any difference in the inner workings of the provider.

To clarify, the roles in question were not initially created with version 0.84.1 of the Snowflake provider; they were created with an even earlier version, and since then, we have been consistently upgrading the provider across several versions up to 0.85.0.

We also tried to upgrade from earlier versions like v0.80.0, but still couldn't reproduce the described behavior. Please, try to provide working steps to reproduce the issue. Otherwise, I can only suggest importing the state back with Terraform CLI. It's described in our latest migration guide for the grants, but that applies to any other resource. It's here - if you don't have those resources in your state you can start with 3rd point to import the state back.
In the case of the external state storage, maybe @sfc-gh-swinkler knows if that could be the root cause, but I'm assuming that it shouldn't be any different than local state management.

Thank you for the suggestions and guidance, @sfc-gh-jcieslak.
After attempting to replicate the issue in a separate environment without success, it appears that the problem might be unique to the specific state or configuration of the original environment. I also tried following the migration guide to import the role back into the state, but unfortunately, I was unable to import the role successfully.
Given the urgency to resolve the issue and considering the inability to replicate or rectify it through suggested methods, I opted to delete the role outside of Terraform and then re-create it. This approach was not ideal, but it allowed us to quickly restore the desired state within a 10-minute maintenance window.

Could you share the details on error messages or commands that you were running during unsuccessful imports? We would like to take a look at them and adjust migration notes if needed.

Could you share the details on error messages or commands that you were running during unsuccessful imports? We would like to take a look at them and adjust migration notes if needed.

Unfortunately, I no have access to those logs.

Hey @jacobcbeaudin
As we don't have anything to work on (I mean lost logs) we can close this issue, right?

Hey @jacobcbeaudin As we don't have anything to work on (I mean lost logs) we can close this issue, right?

Yes, feel free to close this issue

I know this has been closed for a while but I have been banging my head against this issue so I thought people would appreciate the context I have found.
The cause of the issue here for us is a combination of 2 things.
The first of those is that we renamed a role.
It used to be called READER_PROD and was renamed to READER.
This resulted in our state looking like this:
{
    "mode": "managed",
    "type": "snowflake_role",
    "name": "role",
    "provider": "provider[\"registry.terraform.io/snowflake-labs/snowflake\"]",
    "instances": [
        {
            "index_key": 0,
            "schema_version": 0,
            "attributes": {
                "comment": "The comment for the role",
                "id": "READER_PROD",
                "name": "READER",
                "tag": []
            }
        }
    ]
}

So a previous version of the Snowflake Terraform provider changed the name but not the id of the resource.
Then in this commit in file pkg/resources/role.go the code for reading a role changed from getting the resource by name (if set) to only getting the resource by ID.
- id := d.Id()
- // If the name is not set (such as during import) then use the id
- name := d.Get("name").(string)
- if name == "" {
- 	name = id
- }
- builder := snowflake.NewRoleBuilder(db, name)
- role, err := builder.Show()
+ client := sdk.NewClientFromDB(db)
+ id := helpers.DecodeSnowflakeID(d.Id()).(sdk.AccountObjectIdentifier)
+ accountRole, err := client.Roles.ShowByID(ctx, sdk.NewShowByIdRoleRequest(id))

These two things added together results in the situation outlined in this issue.
Terraform cannot find the role anymore and it wants to recreate it.
We do not get this issue on roles that have not been renamed as the state has id and name as the same value.
I think the resolution here is for me to manually change the Terraform state to set id to be equal to name.


⚠ Samsung has degraded performance

In e4feaad, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2292 ms

Resolved: Samsung performance has improved in 5d741fd.


Conditions categories set to 4 but Eve shows 9 options

I set up conditions categories to 4 via the GUI but in the Eve app, it shows 9 possible options.  I tested on a cloudy day and it would trigger only if >=3 instead of >=1.
Config is set to "simple"
{
    "units": "us",
    "interval": 5,
    "stations": [
        {
            "nameNow": "Home",
            "service": "openweathermap",
            "language": "en",
            "compatibility": "both",
            "conditionCategory": "simple",
            "now": true,
            "extraHumidity": false,
            "hidden": [
                "Air Pressure",
                "Dew Point",
                "Ozone",
                "UV Index",
                "Visibility"
            ]
        }
    ],
    "platform": "WeatherPlus"
}

The Eve app will always show 9 possible options (0 - 9). I believe very old versions of Eve were limited to 4.
That said, it should still work as the Eve app just looks at the number.
Can you send me a screenshot of your automation? I am not an expert in it, but can take a look.
My test below works. I read it as:
"When Condition Category changes to '1' (aka simple === 'overcast'), and it is after Sunrise then turn on the Office Light".

Closing as stale.


Unorthodox use of "makesPiglinsNeutral" causes NPE with mod expecting standard behavior

Minecraft version
1.19.2
LibX version
1.19.2-4.2.7
UtilitiX version
UtilitiX-1.19.1-0.6.2
Forge version
43.1.43
The latest.log file
https://gist.github.com/ZeMilkmann/1aa3c43b89764b557df96bbfb026b58e
Issue description
In GildingArmorRecipe.java you pass a null value for the wearer parameter in the makesPiglinsNeutral method.
Since this method is supposed to pass a valid LivingEntity when it is called by the Piglin-AI, the creator of the mod "Upgraded Netherite" has not made contingencies for a null value being passed which causes a crash whenever attempting to insert an ArmorItem from these mods into an anvil when UtilitiX is installed as well.
I did ponder for a while which mod was ultimately responsible to fix it and landed on you, since there is no indication that the wearer parameter is nullable in the Forge docs and during intented use it will never be null.
The fix should be relatively simple and universal if you pass a FakePlayer instead of null
Steps to reproduce
No response
Other information
No response

Thank you for the report. You're right, null isn't the best solution, but it's allowed: The parameter isn't annotated with NotNull nor Nullable. Thus, it's technically okay to set it null in my opinion.
Using a FakePlayer would be a good idea, but it's not very simple as this requires a ServerLevel which I can't provide in this recipe class. I decided to use try/catch. When a NullPointerException is thrown, it simply returns false. This could cause issues with other mods overriding this method and don't check for null, but I don't think that many use this. And if they do, they mainly are items which can be converted in other ways, if they aren't "gilded" items. This doesn't look nice in code but it's the best solution in that case I guess :)


cache looking for base libtracy

I guess this will be changed at some point but putting this up anyway. Avoids having to call dllist for every zone.

Thanks for the PR! ccall will of course already cache the handle for each individual tracepoint, but it'd definitely be nice to have this cached once overall
Would you be able to re-work this not to be dependent on #5? I don't think I want to go in that direction for bindings right now

It wasn't intended to push the Clang stuff here. Fixed.


Tensorflow 1.6.0 on ARMv7 import error

Hi there,
I compiled Bazel and Tensorflow 1.6.0 on an ARMv7 board (OrangePI Zero 512MB) successfully without any error and built the python wheel, Here are related info :
System information

Have I written custom code : no
OS Platform and Distribution : Armbian 5.41 (Ubuntu 16.04.3 LTS - Kernel 4.14.18-sunxi)
TensorFlow installed from : source
TensorFlow version : 1.6.0
Bazel version : 0.11.1
CUDA/cuDNN version : N/A
GPU model and memory : N/A
Exact command to reproduce : import tensorflow as tf
Build command :
bazel build -c opt --copt="-mfpu=neon-vfpv4" --copt="-funsafe-math-optimizations" --copt="-ftree-vectorize" --copt="-fomit-frame-pointer" --local_resources 512,1.0,1.0 --verbose_failures tensorflow/tools/pip_package:build_pip_package

In python when I import tensorflow I get this error :
ImportError: /home/user/.local/lib/python3.5/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so: undefined symbol: _ZN10tensorflow9ConcatCPUINS_8bfloat16EEEvPNS_10DeviceBaseERKSt6vectorISt10unique_ptrINS_6TTypesIT_Li2EiE11ConstMatrixESt14default_deleteIS9_EESaISC_EEPNS8_6MatrixE

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

Updated the first post

Hi! I encountered a similar error and I was able to solve it. Check it out here: https://github.com/tensorflow/tensorflow/issues/17790

Ok, thanks for the tip I removed concat functions from that file and currently building tensorflow again which on my board will take 2 days :) lets hope this time it works !

It worked ! actually it didn't take 2 days because it only compiled changed files. thanks a lot !

@Lexicographical thanks very much!
@rezaxdi closing, thanks to @Lexicographical 's help.


Video, etc.

Part of https://github.com/gratipay/inside.gratipay.com/issues/1160. 💃
Todo

[ ]  change base back to master

Started looking at pulling updates from Medium.
https://gratipay.news/feed
https://stackoverflow.com/questions/10943544/how-to-parse-an-rss-feed-using-javascript
No CORS so we'll have to do it server-side, which means either doing it manually or caching so we don't slow down page load too much.

Actually though let's not block this on https://github.com/gratipay/gratipay.com/pull/4656. It's too cool let's get it deployed! 💃
cc: @mattbk @JessaWitzel et al.

Pause! @ChrisECJohns is looking at fixing up the bit where I say "$250" instead of "$250 per developer."

Rendering one more once. slack

Planning to merge per @mattbk's approval once right video is in place ...

Rebased and switched to final video. Was 2e5eac74e5a2477bfc1c16fdb9d7cf041cc4303d.

Merge approval because @mattbk is traveling: slack.


Add example showing how to set g:syntastic_ruby_mri_exec

I believe your addition is in direct contradiction to the two paragraphs immediately above it.  You're supposed to either (1) activate rbenv and run Vim from inside the environment.  Then you don't need to set *_exec.  Or (2) write a wrapper script that activates rbenv, and point *_exec to the script.  Then you don't need to care about rbenv which ruby.  Actually, pointing *_exec to the ruby executable instead of running from a virtual environment is explicitly not supported and doesn't work, that's what that section in the FAQ is supposed to address. shrug
Sorry, but no.

Thanks for the prompt (if unnecessarily dismissive/sarcastic) reply. So you're saying it's better to do:
silent let g:syntastic_ruby_mri_exec = substitute(system('~/bin/my_script'),'\n\+$','','')

where my script is something like:
rbenv which ruby

? easy change to make if that's the recommended way of doing things.

Thanks for the prompt (if unnecessarily dismissive/sarcastic) reply.

If you read my reply as dismissive / sarcastic, I'm sorry, that was not my intention.
The recommended way is to activate rbenv, run Vim, and leave g:syntastic_ruby_mri_exec unset.  Does this fail to work for you?

No worries, easy to misconstrue things over the Internet! The issue I was trying to solve is that I usually have a whole bunch of MacVim windows open, each one associated with a different Ruby project, some of which have different Ruby versions, so I want to use a different syntax check in each window. Would it make more sense for me to set b:syntastic_ruby_mri_exec to the value I listed, using an auto-command? I'm new to vimscript so I apologize if this sounds naive.

This won't work.  It isn't enough to run the executable version X to make sure modules for version X are loaded at run time instead of those for other versions, that's why things like rbenv and rvm exist in the first place.
So you really want to have an environment for version X in a window, and an environment for a different version Y in another window.  From the little I know about rbenv this is not possible, since rbenv just creates symlinks.  It's possible in rvm though, just activate the right version in each window.  Nothing of this have anything to do with syntastic though. shrug


Export input types for typescript-modern

This was down for flow-modern but not typescript

@martijnwalraven this looks good to merge.


added tests for ignore/unignore methods being provided different argu…

…ment types

Coverage increased (+5.5%) to 100.0% when pulling 0e0c9687eea01bef82dcef93891570fb662f969e on ignore-unignore-arg-tests into db35dcfc749a71681f8f15950e9a7511ff0c1c55 on master.


update to rc.5

merge changes from https://github.com/AngularClass/angular2-seed
Angular 2 Seed will be the simple version of this repo. Both will be updated to Webpack 2

Great!

I have a simple version of the starter here https://github.com/gdi2290/angular2-webpack2-starter that's updated to rc.5 it's where I experiment for changes in this repo

I tried to use RC5 and ran into an issue with uri.match is not a function, which is caused by _split being called on moduleId by angular, which in the case of webpack is a number.
https://github.com/angular/angular/pull/10595 is a PR created by @mhamel06 to fix the issue.

don't use moduleId in webpack

How about dependencies being used in the project that are using moduleId that we have no control over?

How about dependencies being used in the project that are using moduleId
that we have no control over?
On Tue, Aug 9, 2016 at 9:26 PM, PatrickJS<EMAIL_ADDRESS>wrote:

don't use moduleId in webpack
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/AngularClass/angular2-webpack-starter/issues/843#issuecomment-238748978,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC44SoHtc-GvM2c3iTqL8JYdIrMajznCks5qeTa7gaJpZM4JgXnM
.

@shahmirn are they public deps on github? if so can you give me a link to the repo. You would use a loader to rewrite it and remove the moduleId but I need to create it.

sorry not at computer now but I think my issue may have been from the material repo, since I still had the issue after removing my moduleIDs. this is with the latest Ng module version. https://github.com/angular/material2/blob/master/src/components/sidenav/sidenav.ts
I think ensuring that the _split function is only called with the expected type should fix the core issue.

@mhamel06 @shahmirn
ok fixed via
https://github.com/AngularClass/angular2-seed/commit/84aacc18682bbe38631cd3c457d9e90944d6fd0e

when rc5 will be updated in this project?

@gdi2290 the seed repo uses webpack 2, is it planned to update this starter repo to webpak 2 as well?

yup this repo will be updated to webpack2 and rc5

eta?

Looking forward to this, if you'd like me or the 100 other people here waiting for this to help, let us know how!
I noticed when trying to update my own project that the hot loading stuff might be a bit ?? with rc5. Because you have to declare all of the components in a single place. Are we going to make multiple modules for a project, maybe? Seems really a lot more complicated than before.

Agree with @paralin , I also concern that if we're putting all the deps in one place, isn't it break the encapsulation of each component as they might depend on other libs that are not imported.

I'm currently playing with this repo, and I see that using modules changed pretty much everything in the app organization. Hope to see the updated version soon, this is a really good starting point for new apps.

Has anyone hacked together a workaround that will allow use with rc5 for existing rc4 applications?

I can work on a webpack loader that will convert code from rc4 to rc5 NgModule

I would prefer to see how we can integrate aot compilation into webpack build process.

In the release notes they said something like "rc4 apps should still work" but they really don't, I don't see how they think it's a good idea to release another rc and just completely nuke the entire workflow everyone had been using, I mean it makes sense in unstable development software but these are release candidates, not alpha or beta versions. And the fact that we have to declare all of our modules at start means we can't shard with webpack anymore, as far as I can tell.
There's a pretty big discussion on this on an issue on the angular repo, I don't have the link right now, but it's possible they will change a lot of these things before rc6.
At the moment I'm a resigned to staying with rc4 until they fix this stuff.

Actually rc5 is made to be compatible with rc4. Anyway my app worked fine after some adjustments, just have to change about everything from bootstrap to the router, enclose components in modules, change the way directives are loaded and it should work.

yup this repo will be updated to webpack2 and rc5

what does it mean exactly? that it will be update to webpack2 and rc5 at the same time?

Has anyone forked this and got this to work with rc5 and webpack 2?

Do you really think it'll work with Webpack 2? Have you seen their current list of issues? Come on, guys...

@alvipeo, angular works fine with webpack 2... cli runs on webpack 2 and angular class also has another repo that is running webpack 2

Show me the app built with it then, a real one, not the "overly complex" ToDo app.

@alvipeo I'm using it in my main project. What exactly do you think doesn't work right with it?

@alvipeo , this is an open source project, given to everyone here for free. No one has to "prove" anything to you, and there is a way to ask questions nicely.
That said, the tone here is really harsh for some reason, so I just want to say thank you to @gdi2290 and everyone else at "angular class" for the awesome work here.

I had someone argue with me the other day that they were not going to fix a bug in their project that made it not work against Typescript 2.x because "it's bad practice to use pre-release software so im going to force people to use typescript 1.x to make the world a better place."
Getting the same vibe here from @alvipeo .
You use prerelease software when starting a new project because Typescript 2.x, Angular2, etc will soon become stable versions, and I'd rather start off with the latest than have to upgrade later.

Yeah, not sure what the aggression is about. Webpack 2 virtually the same as Webpack 1 other than a few minor configuration changes. I upgraded my old project over to it over a hot cup of tea and it works fine with absolutely no issues.

@qdouble do u use cli?

@DzmitryShylovich I only demo cli... in my real project I just use a webpack build that's a hybrid of different seed projects that I've customized for my needs.

ok, sorry it was sounded a little harsh. the point is it's not ready for a production use. that's all.

@alvipeo you're saying that but you're not pointing out what exactly works with webpack 1 that doesn't work with webpack 2? If it wasn't project ready, why would angular-cli be using it?

Honestly I would worry more about angular2 not being production ready than about webpack2.

it's both actually. I really hope they'll have real RC at angular connect. I hope...

@NgModule was the only thing preventing Angular from being released. The only thing that will delay Angular 2 from being released is if they decide to rename @NgModule to something else like @Container. Angular 2, Ionic 2, Webpack 2, RxJS 5, and TypeScript 2 are all going to be released in their stable version soon. (Also don't quote me on this :p)

@gdi2290 I agree. I've read everything I could on NgModule and I have a strong feeling we anticipate some big changes in this area ;) It's not polished least to say.

BTW, I'd rename NgModule to NgScope... Just sayin'...

I have a prod app running with this repo.  Suggestions going forward?  Is Webpack 2 a necessity now?  I like this repo much more than the seed since it accounts for dev/test/prod environments.

Do we have a sense of when this might get moved to RC 5?

@BeanoKing I also have a prod app on this. I'd say stay with what you have for now. The NgModule stuff will be resolved / tweaked by the next RC. Same with Webpack 2.
@MacBaird The problem is the hot loading stuff / Angular Universal (server side rendering) is not really compatible with the new NgModule requirements (list all the dependencies at module creation time). We're trying to work it out with the Universal team and Angular upstream.

I have a feeling @gdi2290 is waiting for rc.6 because he knows about some breaking changes we don't... or he could just be busy with actual work. 😊 Either way I'm hesitant to update my apps until I see how's rc.5 handled in this repo.

And he'd be right to wait for RC6.

@alvipeo Fwiw, I'm using Webpack2, Typescript2, Angular2 RC5 in a 150+ components, 10 ngModules site that we'll release to business customers very soon.
It works very well and I'm (after initial depressive thoughts) very happy about the ngModules stuff. It makes it so much nicer and easier to structure larger projects into different parts.
I haven't implemented AoT compilation yet though.
As for RC6 - this will be a bugfix release, and a "remove-deprecated-apis"-relelase.
If your app works with RC5 without warning messages deprecated use of APIs, it should be working out of the box with RC6... I'm pretty sure about this.

@spock123 Glad to hear that! Do you have a repo to share?
RC6 will also bring testing back which is a big deal to my projects personally. And I'm really looking forward to it.
I've learnt you can't be sure about things in programming :)

Not right now I'm afraid.. but will try to do a hello-world version.
Although testing have changed so much I've given up trying to implement
that until ng final is released, haha.
I've used Patrick's repos as inspiration so really not much different than
they are now... Although a lot simpler due to lack of testing, code
coverage etc... ;)
On Thu, Aug 18, 2016, 22:33 Alex<EMAIL_ADDRESS>wrote:

@spock123 https://github.com/spock123 Glad to hear that! Do you have a
repo to share?
RC6 will also bring testing back which is a big deal to my projects
personally. And I'm really looking forward to it.
I've learnt you can't be sure about things in programming :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/AngularClass/angular2-webpack-starter/issues/843#issuecomment-240904728,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABNWdIH5uKylch2Nzf_NdxlpnYXHGkNcks5qhQfVgaJpZM4JgXnM
.

Has anyone been able to make HMR work with RC5?

@FabioAntunes I work on business app with RC5 and HMR works pretty fine. Currently I'm about to make a PR with update to RC5.

@redwhitelabel cool give a shout when your PR is ready so I can take a look, hot to setup HMR

@FabioAntunes sure mate ;)

@alvipeo I have put together a rough version of what I use for my project: Angular2 RC5, WebPack2, Typescript 2, Angular2-Material
It's basically a demo app for Angular-Material components
It showcases how to do shared modules, module routing.
I've provided a Docker-image so you don't have to install all those ugly global dependencies.
The repo is inspired by this repo, but I've simplified things: no testing, no deployment, no linting. I'm not saying you shouldn't do those things, but Angular has changed testing so much that I want to wait till the dust settles.  Also, Typescript2 has some issues with tslint.
The repo is here:
https://github.com/spock123/angular2-webpack2-typescript2

@spock123 Thank you! I'm gonna try it.
Meanwhile, RC.6 is 80% done... Hopefully, we'll get to 100% next week! Exciting!

I've got very basic rc5 set up forked from this seed. However, async/lazy routes are screwed up. HMR as well. Due to that reluctant to open up a PR for that.
https://github.com/AngularClass/angular2-webpack-starter/compare/master...dherges:feature/ng2-rc5
If anyone has went past these issues, that'll be nice. If not, let's wait 😎  🏄

can someone also make a PR that will update this repo with hmr and hmr loader as shown in https://github.com/AngularClass/angular2-seed

I'm confused, are you not going to update this repo yourself? Are you waiting for something, or you want to leave it to the community? I mean there seem to be quite a few changes in the angular2-seed repo, not only rc5 and webpack2, is that the go-to starter repo from now on?

Sorry for not being transparent. We're working on big changes for this repo that will improve the experience. The seed repo will be the new place to test out new build designs and hopefully hold everyone over until we're done. For example, the new DLL build system that improves the build by 5-10x by isolating the vendor files to only build once. It would help if the community could help me update this repo in the mean time. What needs to be done is to follow the new designs in the seed repo which uses webpack2 and update this repo with the updated hmr/async/build. I can also update the repo faster if everyone doesn't mind losing some features such as docs and lint

I do not mind losing the auxiliary features like docs and lint over rc.5 upgrade.
(leaving this comment here for others interested to do 👍)

@gdi2290 Thanks for sharing your plans, really appreciate what you and the rest of the members are doing here. You guys simplified my life a lot and I learned a lot from these repos. Keep up the good work.

This is a great repo, and am glad I've put together something based on it. I'm good with deferring docs and lint, etc. I've done a few tries at moving it forward locally, but I'm new at this Angular 2 and webpack stuff, so haven't had much success.

@gdi2290 thank you very much. I have successfully updated to RC5 .

Awesome!
In the process of updating myself. Ran into the following,
Can't bind to '<attribute>' since it isn't a known property of '<component>'.
The same challenge is referenced in this issue: https://github.com/angular/angular-cli/issues/1644

@qq83387856 can you share some code? maybe a diff what you've changed?

hmr was fixed in the recent update just by changing the angular router dependency (the only bit I pulled in so far)

I recently updated angular-cli with webpack and started using that with RC-5.
metadata_resolver.js:377 Uncaught Type RouterOutlet is part of the declarations of 2 modules: RouterModule and AppModule!. Any suggestions on how to fix this?

alright webpack2, async, hmr are all working now

Great. What's next now @gdi2290? I wonder whether I should wait for that DLL stuff before I start refactoring everything..

DLLs will take some time since I have to deconstruct the config folder and move all of the comments into the type definition file

@gdi2290 great advanced work!
I wonder if DLL's can be later on used for lazy routes/modules.
In big apps it might be useful.

I tried merging DLL myself. Failed miserably, there are countless typescript errors just by changing configs from js to ts.
Should the config folder be part of exclude in tsconfig or something?

ya exclude the config folder

What do I do with Cannot find name 'require'. etc. then though?

Any plan for the migration guide?

@gdi2290 any update on those dlls? :)

I had some similar errors and had to remove my typings folder from app root. Hope that helps someone else.


add skip ci functionality

Adds the possibility to skip workflow execution if the commit message contains a string like [skip ci] or similar.
The default strings are the same as on GitHub, users can also set custom ones in app.ini
Reference: https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs
Close #28020

I'll be probably be able to review on saturday.

app.example.ini should also be updated.

@wxiaoguang Done

@denyskon please fix the merge conflicts. :tea:

Still need to fix the config example
https://github.com/go-gitea/gitea/pull/28075#pullrequestreview-1737639131


Change the number to a string to preserve the precision of UInt64

The data received by Http automatically convert from string to JSON internally.
I changed the number to a string to preserve the precision of UInt64 in JSON string
Related to #99

Stoa's issue #99 was resolved as Agora's issue #1213 was resolved.
However, this problem can occur at any time because the ulong type can be used in Agora at any time.
Therefore, I request a review of this PR.


TypeError: path.charCodeAt is not a function in getEncodedRootLength

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.73.0 %8fa188b2b301d36553cbc9ce1b0a146ccb93351f %x64

OS Version:  21H2 for home %19044.1889

Steps to Reproduce:

open my work,some ts file
Press ctrl and click on some variable, or just mouse over, to see information about the variable (Indefinite time, sometimes a few minutes, sometimes longer)

Prompt to crash five times, no more restarts

normal ：
crash ：

log.zip
Personal computers, theoretically do not contain sensitive information

and i think,,,,,

CPU usage is high because log files are created continuously and some programs try to restart

This is because your package has a tsconfig.json with unterminated baseUrl and typeRoots properties:
{
    "compilerOptions": {
        "module": "commonjs",
        "lib": ["es6"],
        "target": "es6",
        "forceConsistentCasingInFileNames": true,
        "noEmit": true,
        "noImplicitAny": true,
        "noImplicitThis": true,
        "strictFunctionTypes": true,
        "strictNullChecks": true,
        "baseUrl": "..,
        "typeRoots": ["..],
        "types": []
    },
    "files": [
        "index.d.ts"
    ]
  }

On our side the fix is easy - we need to validate that when we check option.isFilePath that the current value is actually a string.
-    if (option.isFilePath) {
+    if (option.isFilePath && typeof value === "string") {

This is still a bug in our compiler - please leave this open until it's resolved.

The crash was fixed with #53331

Upgrade typescript to v5+.
Apart from this, if you're using any bundlers (e.g., Rollup, Webpack), don't forget to upgrade their TypeScript-related packages as well.
I had to upgrade rollup-plugin-ts.


Chait/optimist fixes

What does this implement/fix? Explain your changes.
checkAlreadyInBlock inside transactionSubmittedEventHandler is not be relevant because checking for duplicate transaction hashes is an incomplete check. Duplicacy check is done by commitments and nullifiers which is handled inside checkTransaction already. Also, this function caters to remine logic before the code transitioned to waiting for certain number of confirmation blocks before assuming the event is final to be processed.. Also error thrown from checkAlreadyInBlock would create a challenge incorrectly because it does not hold the necessary arguments required by services/challenges.mjs.
On a different note, if optimist receives a transaction as part of an L2 block that it was not aware of, then optimist  does not save l2BlockNumber whilst saving this transaction to it’s database. As a result, when rollbackEventHandler is called during a rollback of an L2 block, if an incorrect transaction, for example duplicate nullifier/commitment is being deleted, it risks deleting the original correct transaction too.
An even more important implication of this, when removeTransactionsFromMemPool which removes transactions from mempool is called inside blockProposedEventHandler for transactions in an L2 block, it does not work correctly because this function updates transactions by querying based on blockNumberL2 too which in this case is unset.
Does this close any currently open issues?
Fixes the issues
https://github.com/EYBlockchain/nightfall_3_private/issues/236
https://github.com/EYBlockchain/nightfall_3_private/issues/234
What commands can I run to test the change?
github actions
Any other comments?

Please close the relevant issues in the other repo when merged


Fixed form content encoding

Changed form content encoding from PHP_QUERY_RFC3986 -> PHP_QUERY_RFC1738. This was the default in v5.0.0-beta.7.
It seems this inadvertently changed when http_build_query() was replaced with League\Uri\QueryString for whatever reason. The default in that library is different.
Closes #333.

Thanks, manually merged as https://github.com/amphp/http-client/commit/4a962fe1d96ca0ca956401f08eb3eb72e90e5d2b with a test.

Why didn't you use my commit?

Because I wrote a failing test locally first, then fixed it and then the test was green, but I already had everything ready to commit locally, so I just committed. I also wanted to avoid using named params for libraries we don't control.


Image contents inconsistency if used by > 1 containers over overlay2

Description
We have noticed, that in case we have more than 1 container is using image, when ever we do update, image data is not updated until we remove containers manually. Even though, they were removed by docker-compose during update procedure.
root@bhss-fra3-prod-26:~# docker pull anchorfree/ar-php-fpm:blue
blue: Pulling from anchorfree/ar-php-fpm
Digest: sha256:1515c38254bc8ac0e5cebafbbca7a99c4299134a1a3aab8571324e19ecc6b809
Status: Image is up to date for anchorfree/ar-php-fpm:blue

root@bhss-fra3-prod-26:~# docker ps
CONTAINER ID        IMAGE                             COMMAND                  CREATED             STATUS              PORTS                      NAMES
e2ba6c990f24        anchorfree/bhss-nginx:blue        "entrypoint.sh"          12 seconds ago      Up 11 seconds                                  bhss-nginx
f639ea17ea01        anchorfree/ar-php-fpm:blue        "/entrypoint.sh"         15 seconds ago      Up 11 seconds                                  php-fpm-hsselite
cd2465f78813        anchorfree/ar-php-fpm:blue        "/entrypoint.sh"         15 seconds ago      Up 13 seconds                                  php-fpm-www
05fa354046b4        anchorfree/ar-php-fpm:blue        "/entrypoint.sh"         15 seconds ago      Up 13 seconds                                  php-fpm-hss
312936e11c45        anchorfree/ar-php-fpm:blue        "/entrypoint.sh"         16 seconds ago      Up 11 seconds                                  php-fpm-rss2search
03a59031a273        anchorfree/ar-php-fpm:blue        "/entrypoint.sh"         16 seconds ago      Up 12 seconds                                  php-fpm-deliverycurl
...

so the image is up to date, containers restarted, everything is fine.
root@bhss-fra3-prod-26:~# docker exec -i -t php-fpm-www shasum /var/www/hss.hotspotshield.com/classes/SdBuilder/Android.php
65f31d4e52528e46e5b7d420cd4e4a938c5601d9  /var/www/hss.hotspotshield.com/classes/SdBuilder/Android.php

checkusm is from the old image, lets delete all containers which use the image:
root@bhss-fra3-prod-26:~# docker rm -f php-fpm-hsselite  php-fpm-www php-fpm-hss php-fpm-rss2search php-fpm-deliverycurl
php-fpm-hsselite
php-fpm-www
php-fpm-hss
php-fpm-rss2search
php-fpm-deliverycurl

then start up containers:
root@bhss-fra3-prod-26:~# compose-updater.sh run
skipping pull state
...
Creating php-fpm-www
Creating php-fpm-rss2search
Creating php-fpm-deliverycurl
Creating php-fpm-hsselite
Recreating bhss-nginx

and final check:
root@bhss-fra3-prod-26:~# docker exec -i -t php-fpm-www shasum /var/www/hss.hotspotshield.com/classes/SdBuilder/Android.php
13f23ff665b2dd37f9d2ad9a6d2502189a7a173b  /var/www/hss.hotspotshield.com/classes/SdBuilder/Android.php

checksum is different completely.
compose-updater is the script which is wrapping the compose -f files:
#!/usr/bin/env bash

compose="/usr/local/bin/docker-compose "

include () {
    [[ -f "$1" ]] && source "$1"
}

for i in $( ls -1 ${COMPOSE_FILES:-/etc/docker-compose/*.yml}); do
    compose+=( -f "${i}" )
done

# make sure we always have the latest image
if [[ $1 = 'run' ]]; then
    echo "skipping pull state"
else
/usr/bin/flock -en -x /tmp/compose-pull.lock ${compose[@]} pull
fi

# start it all up
if [[ $1 = 'pull' ]]; then
    echo "skipping up state"
else
/usr/bin/flock -en -x /tmp/compose-up.lock ${compose[@]} up -d --remove-orphans
fi

# images cleanup
if [[ $(docker images -q --filter "dangling=true") ]]; then
    docker rmi $(docker images -q --filter "dangling=true")
fi

Output of docker version:
docker version
Client:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 22:01:48 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 22:01:48 2016
 OS/Arch:      linux/amd64

Output of docker info:
docker info
Containers: 31
 Running: 31
 Paused: 0
 Stopped: 0
Images: 24
Server Version: 1.12.3
Storage Driver: overlay2
 Backing Filesystem: extfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge null host overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: apparmor seccomp
Kernel Version: 4.4.0-47-generic
Operating System: Ubuntu 16.04.1 LTS
OSType: linux
Architecture: x86_64
CPUs: 4
Total Memory: 7.796 GiB
Name: bhss-fra3-prod-26
ID: LUK6:655X:4ES3:IMWZ:PIGX:R2VP:TYPR:DN6U:2K67:7YMV:3PIK:PGPP
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Username: afprod
Registry: https://index.docker.io/v1/
WARNING: No swap limit support
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
It is running on DigitalOcean boxes

apparently this is due to default compose behavior to preserve volumes


Gradle properties vs project properties vs system properties

Issue type
Wrong or misleading information
Problem description
(sorry for the category, it's in-between the "wrong or misleading" and the "missing information")
I find the doc a bit confusing about the different types of properties that Gradle supports, what each configure, and their order of precedence.
Types/sets of props VS mechanisms to set them
On the surface, when looking at the Build Environment doc, there are 3 sections about properties: Gradle properties, System properties, Project properties. The sections about Gradle properties and System properties also provide a list of properties, suggesting that those sections define sets (or subsets) of properties. However, all 3 sections also mention different mechanisms to set those properties: JVM system properties with -D on the command line, env vars like JAVA_OPTS and GRADLE_OPTS which can also make use of -D to define JVM system properties, gradle.properties files in various places, -P for project properties, etc.). There is no 1-to-1 mapping between the sets of properties and the mechanisms, which makes it rather unclear which properties are of which type and what this means.
All of them can be set via JVM system properties (-D on the CLI or in env vars), even the ones that are not defined in the System properties section: -Dorg.gradle.caching=true is valid (a Gradle property), and so is -Dorg.gradle.project.someProp=value (a Project property).
All of them can be set in gradle.properties files, even the ones that are not defined in the Gradle properties section. However, some require the systemProp. prefix, and some don't (although as we established all of them could be set via system props too). An interesting consideration: what happens if I put a systemProp.org.gradle.caching=true in my root project's gradle.properties? Does it have the same effect as org.gradle.caching=true? Does it affect the precedence?
So, if those sections don't segregate properties based on the mechanism to set them, what is the separation about? What exactly is the difference between the JVM system properties that are Gradle properties and the JVM system properties that require systemProp. prefix in properties files? Do they affect/control different parts of Gradle? This leads me to the next point.
What each property type configures
Gradle properties are said to "configure the Java process that will be used to execute your build", which is unclear about whether this is about the client/daemon/build VM. But the intro paragraph carries on saying that "it’s possible to configure these in your local environment via GRADLE_OPTS or JAVA_OPTS" - and those are said to affect the client VM (not the build VM) in the docs about Environment variables. What I think this means is that the JVM system property mechanism used in GRADLE_OPTS and JAVA_OPTS (when using -D there) are indeed configuring JVM system properties of Gradle's client VM, but then that client can use the subset of these system props that we consider to be Gradle properties (the ones starting with org.gradle.*) to configure the daemon or build VM when it starts it. That's still unclear to me and just based on assumptions, so it'd be nice to clarify that.
The System properties section reads: "you can pass a system property to the JVM which runs Gradle". Again, not sure which of the client/daemon/build VM this is talking about. If we're specifically talking about the subset that requires the systemProp. prefix in properties files, do they configure the same thing as Gradle properties or something different? Are they used earlier in the process / are they more "meta"? What makes them different?
Precedence
In the very first intro paragraph of the Build Environment doc page, an order of precedence is mentioned. But this order mixes properties from different sets (for instance System and Gradle properties). If we consider these sets of properties independent, it is irrelevant to consider the precedence between them. The precedence should be between multiple mechanisms affecting the same property.
I believe it would be better to define an order of precedence for each type of property, listing all their mechanisms, just like it was done for Gradle properties:

command line, as set using -D
org.gradle.foo=value in gradle.properties in GRADLE_USER_HOME directory.
org.gradle.foo=value in gradle.properties in the project’s directory, then its parent project’s directory up to the build’s root directory.
org.gradle.foo=value in gradle.properties in Gradle installation directory

(By the way, where are environment variables GRADLE_OPTS and JAVA_OPTS here? Are they at the end, like the intro paragraph mentioned?)
Applying the same idea for Project properties, we could define this one:

command line argument -Pfoo / -Dorg.gradle.project.foo (by the way, which is first?)
foo=value in gradle.properties in the GRADLE_USER_HOME directory
foo=value in gradle.properties in the project’s directory, then its parent project’s directory up to the build’s root directory
foo=value in gradle.properties in Gradle installation directory
GRADLE_OPTS/JAVA_OPTS with -Dorg.gradle.project.foo inside (does this work? is this the right precedence?)
ORG_GRADLE_PROJECT_foo env var (is this the right precedence?)

Applying the same idea for System properties, we could define this one:

command line argument -Dfoo=value
systemProp.foo=value in gradle.properties in GRADLE_USER_HOME directory
systemProp.foo=value in gradle.properties in the project’s root directory
systemProp.foo=value in gradle.properties in Gradle installation directory
GRADLE_OPTS/JAVA_OPTS with -Dfoo inside (does this work? is this the right precedence?)

Sorry for the very long read. I hope this is useful nonetheless! 🙏
Context (optional)
No response
Page with the problem
https://docs.gradle.org/current/userguide/build_environment.html

Thank you for your interest in Gradle!
This is a valid documentation issue that we will address.

Related to this issue, the relation between gradle properties and project properties and unqualified groovy properties isn't clear from the documentation. Gradle properties are neither mentioned in the project properties page, nor in the groovy dsl primer page. From the doc, project and gradle properties seem distinct property scopes. A groovy build file property evaluation shouldn't lookup gradle properties but only project properties and associated scopes (ext, extensions, conventions, etc).

Adding to the confusion, while the docs explicitly say that "Gradle properties" can be set using -D, custom Gradle properties read with providers.gradleProperty("foo") cannot be set with -Dfoo=bar, only -Pfoo=bar.