Request: highlight the active window's buffer in NERDtree

I'd like to see at a glance which file in the dir tree is currently opened in a buffer.
Even more awesome would be if NERDtree would (in addition to the above) autoexpand the filesystem hierarchy to reveal the active buffer.

Hey, @unphased. Your idea is neat, but I don't think it's feasible or to be recommended. There would need to be some complicated mechanism for keeping this special highlighting up to date as the user moves around among other windows or switches buffers. This is the kind of code that the NERDTree needs to avoid for a number of reasons (including how difficult it is to do this kind of thing in Vim).
To reveal the file in the NERDTree, you can use :NERDTreeFind (see the documentation).
I suggest to @PhilRunninger that this feature request be rejected and that this issue be closed.

Pretty reasonable.
I do make heavy use of :NERDTreeFind.

By the way @unphased, :NERDTreeFind may get an update soon so keep an eye out. See pull request #419.

Okay! Nice. I thought about it a little more and maybe I don't agree that such a solution has to be so complicated. There are auto commands for buffer switching, and that would be the only ones needed. It'd be more simplistic than the tracking that TagBar would  need to do for instance... but, that pr you linked looks quite promising.

Most users don't know this, but the NERDTree ignores select autocommands for efficiency reasons. This would make what you're talking about difficult as the functions that update the highlighting in the NERDTree could not be reliably called. There's a lot of debate about this. If you come up with a solution, I'm sure the maintainers would at least look at it... merging is likely not guaranteed, however.


Add method or configuration to avoid throwing exception when adding non-unique schema(s).

What version of Ajv you are you using?
5.1.0
What problem do you want to solve?
There is no way to control weather .addSchema method throws exception upon uniqueness check.
I see why this is. As with the keyword methods, it is expected that you remove the keyword then add it if you wish to change/overwrite it.
It's possible I'm missing something in the documentation, but I find throwing when adding an existing schema to be rather unexpected (and in some cases difficult to avoid).
What do you think is the correct solution to problem?
While it would be ideal to provide configuration around this behavior, it would be most simple to add a method .setSchema that looks something like this:
// ... @this Ajv
setSchema(schema, key) {
  try {
    this.addSchema(schema, key);
  } catch(e) {
    this.removeSchema(key);
    this.addSchema(schema, key);
  }
}
// ...

I would have to further review the source of Ajv in order to assess how a configurable solution would look.
Will you be able to implement it?
Sure. I'd like some thoughts/feedback before moving forward though.

@lukaswelinder sorry, I'd rather not do it. Given that the method you are suggesting is purely for convenience and the use case is not so common (what it is by the way) it belongs in your app code rather than in the library.
Instead of catching the exception you can:
if (ajv.getSchema(key)) this.removeSchema(key);
this.addSchema(schema, key);

Bear in mind, that if any previously compiled schema references the replaced schema it would still use the previous schema, it will not be recompiled.
Also see: https://github.com/epoberezkin/ajv/blob/master/FAQ.md#can-we-change--extend-api-to-add-a-method-that-would-return-errors-rather-than-assign-them-to-errors-property


snips.ai addon does not install, without error in log

I'm running the latest hass.io 0.74.2 on Raspberry Pi 3B+ and HassOS 1.7.
I try to install the snips.ai add-on:

the button gets briefly a red background, then white again, and nothing happens.
the full home-assistant error log says nothing more than:

2018-07-26 18:24:10 INFO (MainThread) [homeassistant.components.http.view] Serving /api/hassio/addons/core_snips/info to <IP_ADDRESS> (auth: True)
2018-07-26 18:24:11 INFO (MainThread) [homeassistant.components.http.view] Serving /api/hassio/addons/core_snips/install to <IP_ADDRESS> (auth: True)
2018-07-26 18:24:11 INFO (MainThread) [homeassistant.components.http.view] Serving /api/hassio/addons/core_snips/info to <IP_ADDRESS> (auth: True)

I wait ... but nothing happens. So, why does it not install? At least: why does it not give an indication of what is wrong?

Other add-ons (a.o. appdaemon, ide, mosquitto, influxdb) installed and run without problems, my 64GB sdcard has plenty of space left, my internet connection is working.
I look forward to some advice to make it run.

Turns out that the snips.ai add-on does only run on 32-bit HassOS, unfortunately not on 64-bit HassOS. The error message is visible in the hass.io system log page, not in the so-called full home-assistant log. A message on the add-on details page right under the install button would be welcome.


Refactor watch to support multi task watch and auto cancel when drop the receiver

Detials described in design issue: https://github.com/datenlord/etcd-client/issues/44

Please don't checkin the protobuf generated files.

These files already added into .gitignore in last pr https://github.com/datenlord/etcd-client/pull/42.

There are spelling errors in the comments. Please try searching for "shutdowm" and "registed". To prevent additional spelling errors, if you are using VSCode, you can install the "Code Spell Checker" plugin.


Add support for Gitea or Codeberg

Gitea is basically a self-hosted Github
https://gitea.io
If Gitea isn't possible, support for Codeberg instead should be fine
https://codeberg.org/

Gitea itself isn't really possible to support since there don't seem to be a way like on Mastodon to generate OAuth keypairs on the fly, and there don't seem to be a "main" instance like GitLab has (unless try.gitea.io is actually used?)
Codeberg support will be added in the future.

Gitea itself isn't really possible to support since there don't seem to be a way like on Mastodon to generate OAuth keypairs on the fly, and there don't seem to be a "main" instance like GitLab has (unless try.gitea.io is actually used?)
Codeberg support will be added in the future.


question re: hyperkube binaries

The project can be modified to fetch other hyperkube binaries, but I was wondering if there were any special modifications to either the coreos provided hyperkube binaries or google provided binaries?
it makes tracking security vulnerabilities (CVE) and other issues very difficult prior to launching the binary on a system.
for comparison:
CoreOS: https://quay.io/repository/coreos/hyperkube?tab=tags
Kubespray: https://quay.io/repository/smana/kubernetes-hyperkube?tab=tags

As far as I can tell, it just downloads the official binaries for kubectl and hyperkube, and sticks them in / of the container. I agree the way this is handled is a sore spot of this project.

We decided to build our own image because we had to wait weeks to get an official updated image.
Maybe it's faster now, i'll have a look to the CoreOS image and see if we can use it instead.

yeah, that makes sense and i can understand that. i had the same issue a while back. i think this is why CoreOS started deploying their own. would an acceptable solution be to use theirs? it would maybe give folks some confidence that their images can be scanned for CVE issues (even if that is a superficial sense of security)?

I need to check what they ship with it, it is not as simpler as our image and maybe we should use the google's one

Looks like the coreos image is about the same as google's.

i think at one point google had trouble keeping hypercube up-to-date, but that may be resolved now. at least if coreos is used, users would see CVE issues via clair/quay and there would be some sort of visualization of this: https://quay.io/repository/coreos/hyperkube/image/6cf635ef8bd8747af5cbe0786157197248d270a817c5fadd96f87faf3e097668?tab=vulnerabilities
that said, any thoughts on: #321?

I'll +1 on switching to CoreOS's hyperkube or at least ensuring that the hyperkube that we're building out checked for vulnerabilities by quay as well if that's a possibility.
Just as a general thought, it seems easier to explain (in the enterprise) that the image comes from some official release, rather than a personal repo.

Merged

@Smana...you're awesome. thank you :)


IE 11 Error

An error in IE happens...
https://github.com/mirego/ember-best-language/blob/e4e43583883ca7d2b0f3b3cf7d33522c0c52ecaa/addon/services/best-language.ts#L66
new Set() works, but new Set(mySet) is not supported by IE11.
const set = new Set();
languages.forEach(lang => set.add(lang));
languages = Array.from(languages);

but if the uniqueness is the purpose this might be nicer
languages.filter((val, i, arr) => arr.indexOf(val) === i).

https://caniuse.com/#feat=mdn-javascript_builtins_set_set_iterable_allowed

@basz Thanks for reporting! You can update to 2.0.3 to get the new version with the fix. Cheers!

Hi Thanks for your fix...
Just wanted to say older Edge versions still crash apps on an unsupported es6 feature. the object spread notation is not supported in Edge Legacy.
https://caniuse.com/#feat=mdn-javascript_operators_spread_spread_in_object_literals

@basz We support IE11 in most of our apps at Mirego and Babel usually takes care of compiling this stuff down to ES5 with a polyfill for Object.assign. Maybe the app recompiles the addon to support legacy targets? 🤔
I think maybe I can configure TypeScript to output ES5 instead of modern JS, I’ll need to investigate. In the meantime, if you could tell me a bit about your setup that would help to reproduce the bug. Thanks!


ClientCredentialsHelper should check if ClientId or ClientSecret are not yet added to request

Hello,
I am using HttpClientTokenRequestExtensions from IdentityModel v3.10.0.
For method RequestTokenAsync I am passing clientId and clientSecret by my self like:
var parameters = new Dictionary<string, string>
{
    {"grant_type", "delegation"},
    {"client_id", clientId},
    {"client_secret", clientSecret},
    {"token_hint", userAccessToken},
};

var tokenResponse = await _client
    .RequestTokenAsync(new TokenRequest
    {
        Address = tokensEndpoint,
        ClientId = clientId,
        ClientSecret = clientSecret,
        GrantType = "delegation",
        Parameters = parameters
    }, cancellationToken)
    .ConfigureAwait(false);

I am aware that I am duplicating stuff.. however having the code like above will throw exception:
An item with the same key has already been added. Key: client_id
Short investigation showed that ClientCredentialsHelper does not check if parameters are already added which causes this exception:
https://github.com/IdentityModel/IdentityModel2/blob/master/src/Internal/ClientCredentialsHelper.cs#L32
However its fine with GranType, which is checked and added in RequestTokenAsync method:
https://github.com/IdentityModel/IdentityModel2/blob/master/src/Client/New/HttpClientTokenRequestExtensions.cs#L115
if (!request.Parameters.ContainsKey(OidcConstants.TokenRequest.GrantType))
{
    request.Parameters.AddRequired(OidcConstants.TokenRequest.GrantType, request.GrantType);
}

I guess should be the same also with other arguments.

And why are you doing that?

and what should have precedence in your opinion - the properties on the class or the dictionary values?

Well.. I was just migrating code away from obsolete TokenClient class and simply replaced RequestTokenAsync call with new HttpClient extension method which obviously was wrong and caused exception.

Not sure about precedence here.. but if I understand right, values from dictionary are added first and later goes values from request, so only check is missing to avoid dictionary error (which means priority goes to parameters dictionary).
However I am fine with any of these, I already remove these values from properties dictionary, but from library API perspective maybe it should not cause the error, or should be better described.

and what should have precedence in your opinion - the properties on the class or the dictionary values?

I am doing a more defensive check now. thanks for reporting.


Add an error to go-runtime/compile when local Go identifier casing differs from FTL

Currently it's possible for a symbol to have two different casings within an FTL system - the native casing and the normalised FTL casing. We normalise casing across all languages to lowerCamelCase for fields and values, and UpperCamelCase for all types.
For example, if you have the following Go type:
type UserID struct {
  Name string
  ID string
}

This will be case-transformed to:
data UserId {
  name String
  id String
}

We should raise an error in this case.

@alecthomas the team had some questions around this in standup and we wanted to make sure we understand the issue we're trying to solve here. Do you mind clarifying what behavior you want to error on?
I was guessing it was the case where you write time.go with a UserID and it would then have this different casing in the schema as UserId and perhaps even generate echo.go with UserId, which would then have different casing between 2 go modules.
Thanks!

That's exactly right. In the owning module time.go the casing would be UserID but in all consumers the casing would beUserId, which would be confusing.


how to start training the code

I am not able to understand that how to initialize variables and start training

See #46 for more details on this.


sometimes i get PING, where do you reckon it's coming from?

after a while, sometimes i get PING command sent for "no reason" using the modified files.
it is to detect for connection alive, and if so, where should i be looking at?
i dont need the PING part.

You can remove this https://github.com/rueian/rueidis/blob/121d5bf34785327ce869c56b7e83304420bbadd6/pipe.go#L213


had better synchronize eact-router.d.ts to react-router

I assumed that typings file for react-router was managed by a official repository.

https://github.com/andrew-w-ross/typings-react-router

// Type definitions for react-router v2.0.0

react-router.d.ts is following older version.
react-router is one of the measure packages, TypeScript also. Especially, The progress of react-router is remarkable. I'm worried that TypeScript users will be divided.
Do you have any plans?

Why not use DefinitelyTyped?
I don't believe any of the maintainers on this project use TypeScript, so just putting an index.d.ts is not going to give reasonable guarantees that the typings will stay up-to-date.
See also https://github.com/reactjs/react-router/issues/3193.

@taion
Thank you for your response.
Why not use DefinitelyTyped?
Below is a that reason:

DEPRECATED: TSD is deprecated, please use Typings and see this issue for more information.

https://github.com/DefinitelyTyped/tsd/blob/master/README.md#tsd
but I found react-router.d.ts on DefinitelyTyped.

See also #3193.

Thanks. I'll read.


RequestValidationError: 'field required' error although no query param specified

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
def get_db():
    db = SessionLocal()
    try:
        yield db
    finally:
        db.close()

class Api:
    def __init__(self, base_route: str):
        self.router = APIRouter()
        self.router.add_api_route(
            f"{base_route}/some/route",
            self.get,
            methods=["GET"],
            response_model=List[Entity],
            status_code=status.HTTP_200_OK,
        )

    def get(
        self,
        reader: EntityReader = Depends(),
        db_session: Session = Depends(get_db)
    ):
       return reader.read(db_session)

Description
I have upgraded from  fastapi==0.86.0 to fastapi==0.88.0.
The example code stopped working and throws a request validation error resulting in 422 Unprocessable Entity with the following content:
{
    "detail": [
        {
            "loc": [
                "query",
                "args"
            ],
            "msg": "field required",
            "type": "value_error.missing"
        },
        {
            "loc": [
                "query",
                "kwargs"
            ],
            "msg": "field required",
            "type": "value_error.missing"
        }
    ]
}

If I remove reader and db_session as function parameters, it starts working again.
Operating System
Linux
Operating System Details
No response
FastAPI Version
0.88.0
Python Version
3.10.0
Additional Context
I am using pipenv.

Seems like the behavior changed for dependencies having sub-dependencies and being classes?
Creating an instance from EntityReader manually resolves the error...
    def get(
        self,
        db_session: Session = Depends(get_db)
    ):
       reader = EntityReader(mapper=EntityMapper())
       return reader.read(db_session)


Feature/george iFrame score submission

Added an iFrame score submission along with a version bump to the dev
Have set the url to https://cr-frame-dev-testing.vercel.app/ for testing purposes

Merging this one, since it doesn't break anything and I'm testing some iFrame changes on the live dev server @amitsinghsutara ! 🎉


Add message history related mappings.

does this field exist in command block gui? consider mapping if it does.

It doesn't look like command blocks have command history.


Upgrade rustup script

Compatible with arm8l cpu (Raspberry Pi 3 B).
/cc @josephroberts

@TimothyKlim can you check with the latest master? I did update it little bit.

Can't test it now until I will receive new rpi3.


fix(amplify-codegen-appsync-model-plugin): update swift protocol

Updated the swift protocol for Class loader
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4fa3a53). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2911   +/-   ##
=========================================
  Coverage          ?   62.75%
=========================================
  Files             ?      219
  Lines             ?    11162
  Branches          ?     2311
=========================================
  Hits              ?     7005
  Misses            ?     3844
  Partials          ?      313

Impacted Files
Coverage Δ

...model-plugin/src/visitors/appsync-swift-visitor.ts
0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa3a53...eedaaa0. Read the comment docs.


Improve the readme - Easy pull request #Hacktoberfest

Here!

I would like to add

I would like to add

Please go ahead

I raised pull request. Can you please check


[feature] Account info now says if it's missing a required field.

Purpose
Give more useful error message if required field is left blank. Close Issue #3434.
Changes
Now check to see if error is caused by missing field and changes error message accordingly.
Side Effects
None that I know of.

@lyndsysimon I've been really puzzling over how to fix this, but it seems like it should be a quick fix given the validation already in place. Any thoughts?

@lyndsysimon This is done, it was a quick fix after all.

@lyndsysimon Now this is really done.

No changes required - @sloria, this one is all yours :)

As a general comment - there are a few superfluous lines that have been added in your PR, and a couple of places where whitespace has been modified. I believe this was simply overlooked.
To avoid this, I recommend adding code to a pending commit using the command git add -p .. This will give you the opportunity to review every line and character that gets added to the commit - I use this command almost exclusively, to the point that I've aliased it in my shell to simply g a.  Entering ? in the interactive prompt it gives you will print a list of commands and their definitions.

Good advice, @lyndsysimon .
This has already been merged into release/0.43.0


Create new release with Sentry SDK 3.7

This isn't a bug per se, but I would like to use the performance tracing features, and Sentry complains my server-side SDK is outdated. I can't update it, however, because the Laravel package limits the SDK version to 3.2 (released in March 2021).
Therefore, I'd like to kindly ask you to release a new version with the current SDK dependency. Thank you 🙏

Looking at the composer.json, we require
"sentry/sentry": "^3.3",
"sentry/sdk": "^3.1",

So you should always get the latest minor version when you run composer upgrade.
sentry/sdk is our so-called meta-package, which includes an http-clinet, the latest release is 3.2.
sentry/sentry is the SDK without an http-client, the latest release here is version 3.7.
It's confusing, I know 😄
What is the output of composer info if you run it in your application?
@stayallive Out of curiosity, why do we require both the SDK and meta-package?

@stayallive aaah, got it. sentry/sdk is a meta package, and shows up as locked to 3.2.0 in composer output, but installs<EMAIL_ADDRESS>already... sorry, confusion on my part.
^_^ Styx backend $ composer why sentry/sdk
sentry/sentry-laravel  2.13.0  requires  sentry/sdk (^3.1)
^_^ Styx backend $ composer why sentry/sentry
sentry/sdk             3.2.0   requires  sentry/sentry (^3.5)
sentry/sentry-laravel  2.13.0  requires  sentry/sentry (^3.3)

No worries! Thanks for reporting back 😄


[BUG] Volume fails to reattach when the node is powered down and the pod migrates

Describe the bug
Volume fails to reattach when the node is powered down and the pod migrates
To Reproduce

Attach a volume to a pod on node 1
Power down node 1
The pod/workload goes into "Unknown" state when seen from Rancher UI.
The pod migrates to another node
But the volume fails to reattach. Error: Multi-Attach error for volume "vol1" Volume is already used by pod(s) wk01-5669c54dd5-wxr4

Expected behavior
Volume should be able to reattach to the pod on another node
Environment:

Longhorn version: master

It's #820 . After #820 is solved, this should be good.
The pod must be a part of deployment for #820 to work.

Duplicate of #820


base changes & updates integration

Changes

Context

With #1804 merged, this here PR is no longer needed, and the merge conflicts I pointed out no longer need to be resolved.


Features/ticket no10.2 note section

This pool request implements special node features which can be seen on the job page and detail page and the notes reside in the jobs table

Currently performing beta testing


⚠ Fortnite has degraded performance

In 6ffc769, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1438 ms

Resolved: Fortnite performance has improved in 320d76f.


YARN-10055. bower install fails.

JIRA: https://issues.apache.org/jira/browse/YARN-10055

abdmob/x2js was renamed to x2js: https://github.com/abdolence/x2js/commit/185e410b3fa621070fea1f86a389b477afa216b9

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
28m 47s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
20m 49s
trunk passed

+1 :green_heart:
shadedclient
34m 37s
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 11s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 40s
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

80m 28s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1778/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1778

Optional Tests
dupname asflicense shadedclient

uname
Linux cf843e0e79ba 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / bc825b9

Max. process+thread count
308 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1778/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I do not understand why I did not see this last week but I can reproduce the issue today.
src/main/webapp/ember-cli-build.js seems to be fixed too. I got the error below on ember build with the patch applied.
ENOENT: no such file or directory, stat '/srcs/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/target/webapp/tmp/concat_with_maps-input_base_path-xjxA5XCi.tmp/0/bower_components/abdmob/x2js/xml2json.js'

@iwasakims Thank you for your review. Updated the patch.
I think the error occurs because the redirect setting (abdmob:x2js -> x2js) is expired in this week.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
jshint
0m  0s
jshint was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
20m  5s
trunk passed

+1 :green_heart:
shadedclient
34m 20s
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 12s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m  4s
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 28s
The patch does not generate ASF License warnings.

53m 20s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1778/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1778

Optional Tests
dupname asflicense shadedclient jshint

uname
Linux b26313b48ac5 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c44943d

Max. process+thread count
312 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1778/2/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Thank you, @iwasakims !


Adding Custom ProjectSettings prints errors to console

Godot version
3.3.3.stable.mono.official
System information
Windows 10
Issue description
Adding Custom ProjectSettings like this (c#):
var propInfo = new Dictionary();
propInfo["name"] = "test;
propInfo["type"] = Variant.Type.Bool;
ProjectSettings.SetSetting("some_path/test", true);
ProjectSettings.AddPropertyInfo(propInfo);
ProjectSettings.SetInitialValue("some_path/test", false);

prints this to the log output on editor start:
"core/project_settings.cpp:947 - Condition "!props.has(pinfo.name)" is true."
Steps to reproduce
Open the attached project, build solution, enable 'My Plugin' in projectsettings/plugins and observe the log panel
Minimal reproduction project
ProjectSettingsBug.zip

This turned out to be an error on my side, the "name" field doesn't take the name as parameter, but expectes the whole path instead.


After nuxt3 is packaged and run after viewing the web source code, can the style be introduced through the connection?

Describe the feature
After nuxt3 is packaged and run after viewing the web source code, can the style be introduced through the connection?

Additional information

[X] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[ ] Read the contribution guide.
[ ] Check existing discussions and issues.

I'm not sure what you're asking. Can you explain more?

I'm not sure what you're asking. Can you explain more?

After packaging, can css styles be packaged into files and imported using the link tag?

I'm not sure what you're asking. Can you explain more?

Can css styles be packaged into files and imported using the link tag? Instead of inserting it into the head with a style tag like the one I posted.

I am currently archiving this by setting inlineSSRStyles to false. https://nuxt.com/docs/guide/going-further/experimental-features#inlinessrstyles. Be aware that this could have some side effects I am currently not aware of.

Yes, that's exactly right. 👌  If you don't want the styles inlined it can be turned off as @madebyfabian says.

I am currently archiving this by setting inlineSSRStyles to false. https://nuxt.com/docs/guide/going-further/experimental-features#inlinessrstyles. Be aware that this could have some side effects I am currently not aware of.

Perfect solution. Thank you very much.

Yes, that's exactly right. 👌 If you don't want the styles inlined it can be turned off as @madebyfabian says.

Thank you very much.

Another problem is that the.output file after build is super large. node_modules exists in the server folder, is this normal?

It takes a long time to upload to the server.

Yes, it is normal. And the size depends on your project and what you use at runtime.

Yes, it is normal. And the size depends on your project and what you use at runtime.

Ok, got it. Thank you


User guide

resolution_fixed   |    by<EMAIL_ADDRESS>

Issue migrated from trac:33 at 2024-01-31 17:25:56 +1100

ibc599 changed reviews which not transferred by tractive

ibc599 changed status from new to assigned

<EMAIL_ADDRESS>removed milestone (was Future)

ibc599 changed owner from `` to Admin

<EMAIL_ADDRESS>commented

Milestone Future deleted

<EMAIL_ADDRESS>changed status from assigned to closed

<EMAIL_ADDRESS>changed resolution from `` to fixed


[Enhancement] Method invocation 'getRetCode' may produce 'NullPointerException'[EventMeshHttpConsumer]

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request

located at:
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/http/consumer/EventMeshHttpConsumer.java line 102,131,157
Describe the solution you'd like
reference:

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

I would like to work on it if no one is working.

I would like to work on it if no one is working.

Welcome.


Document how to run websocketd behind a frontend

In some production setups, it's desirable to run websocketd behind another HTTP frontend such as Nginx or HAProxy. Benefits include:

Easily fit into existing web infrastructure setup
Load balancing, throttling, etc
SSL offloading
Sharing the same host/port with other services

Add to the wiki configuration example of how to do this.

Would love to see how this is addressed. In our production environments, if this service is to be used, it must be load balanced.

Websockets are somewhat different than regular HTTP sessions and there is certain trickery that would be specific for each use case.... But... if we write about "usual"... what would it be? How many clients connecting to service per minute? How long session stays open? How many hosts we think needed to be balanced to handle that load?  My websocketd numbers are all for internal tools so they are really low and not that interesting... (it's somewhat around ~10 clients a day keeping session open for 3-12 hours)

I have added a basic documentation on the wiki to implement Nginx as a frontend in different ways. I hope it is useful.
https://github.com/joewalnes/websocketd/wiki/Websocketd-behind-Nginx


add: watchexec

Add an initial version of watchexec package. The project supports more architectures and provides completion for more shells, I only added the ones I use and can easily test.

Thanks for the quick review Elsie!


[WIP] Switch to "\033[2K\r" in erase

See #37
Status

Successfully overwrides previous line
Tests fail

Questions

Is lastOutput necessary, or can I remove it?
Why do the tests fail?  Removing that solved the issue. However, I still see this PR as an improvement, as long as we can fix the tests.

Closing for now. Please feel free to open it again if you want to work on the tests.


Premium Features

Account system
Search history
Sidebar
Multiple graphs
Automations
Expand w/AI

Looks good to me. Fixed the search history to show the latest 5 searched addresses
Nevertheless, the userAuthState is a bit different on other PRs, it also returns two booleans "isAuthenticated" and "isLoading". Also, the isAuthenticated flag is true not only if the user exists but also if the email is verified.
PS: Love the Expand with AI feature and I think it has a lot of potencial to improve. For example, when the user expands using AI, there is an explanation of what was expanded and why.
Great job @tubarao312  ;)


Linking figures (with thumbnails) to papers

It would be cool to associate individual figures with each paper, and provide thumbnails that can be followed to the full-size images.
I solved a good chunk of this problem for a related project, but the solution only works for articles in EuropePMC: open_access_figures.
The  getfigures script there runs getpapers with a user-specified query to download the XML and figure images (where available) for all papers matching the query in EuropPMC. It then parses the XML to identify the figures and extract the captions, and it also generates URLs linking to the thumbnails on EuropePMC (which are predictable once you have the full image filenames).
So, I think the initial goal should be to generate the following:

a dataset containing all the figures from EuropePMC
another with the thumbnails for those figures
metadata for each article - an array of figures with:

caption
thumbnail (url / checksum)
full figure image (url / checksum)

Here's how to achieve that:

the captions can be generated using the EuropePMC fulltext dumps here:
the full figures can be pulled using getpapers (or the EuropePMC api directly)
the thumbnails can be scraped once the full images are pulled, the same way as in the getfigures script linked above.

Help and ideas very welcome. I'm happy to do this myself, but won't get to it for at least a few days, possibly longer.

This is really related to PDFs, which aren't planned to be included in v1. Closing this but we can revisit later if we decide to add PDFs.


fix warp from onConnectionLost, corrected some error logging

Related to #83

I think it should be console.log("Error loading scene-options") instead of console.error, because not every scene will have a scene options object.

Ah right. Maybe don't use the "Error" wording, but it's still useful debug to know that no scene-options was found. How about console.log("No scene-options object found")


Webdav Adaptor fails to connect to /webdav/workingdir

I have a webdav server running at localhost/webdav/, but the webdav connector thinks that /webdav is the working directory.

From the definition of URI, the "webdav" part is part of the path. So if you are using:
http://localhost:8080/webdav/workdir
Then the /webdav/workdir part of the URI is the path.
The webdav adaptor will assume the whole thing to be the working directory. This does not necessarily mean all subpaths are accessible (like /webdav). Note that this is also true for other adaptors like FTP, SFTP or even local)
Can you specify a bit more what problem you ran into, so I can try to replicate it in a test?

The problem lies in the fact that the webdav connector tries to connect to the base url:
http://localhost:8080/ however this is not a webdav endpoint (that is actually running the frontend of my application) so it fails to connect.
The webdav is running at http://localhost:8080/webdav/, however I supply a subdir within this as a working dir to the adaptor, for instance http://localhost:8080/webdav/input.

The xenon webdav Docker image also does not have / as an webdav endpoint.
Not working:
xenon filesystem webdav --location http://<IP_ADDRESS>/ list  .

Working:
xenon filesystem webdav --location http://<IP_ADDRESS>/downloads list .
xenon filesystem webdav --location http://<IP_ADDRESS>/ list downloads/filesystem-test-fixture
xenon filesystem webdav --location http://<IP_ADDRESS>/downloads list filesystem-test-fixture

What connection/command is failing for you?

After testing a bit more I found that without credentials this works just fine indeed, however when I put basic authentication on my webdav server (I tested with a http webdav docker) I get the following error:
nl.esciencecenter.xenon.XenonException: webdav adaptor: Failed to check existence of directory: /webdav/input/echo.cwl
	at nl.esciencecenter.xenon.adaptors.filesystems.webdav.WebdavFileSystem.exists(WebdavFileSystem.java:248)
	at nl.esciencecenter.xenon.filesystems.FileSystem.assertPathExists(FileSystem.java:1622)
	at nl.esciencecenter.xenon.filesystems.FileSystem.assertFileExists(FileSystem.java:1674)
	at nl.esciencecenter.xenon.adaptors.filesystems.webdav.WebdavFileSystem.readFromFile(WebdavFileSystem.java:256)
	at nl.esciencecenter.computeservice.rest.service.staging.StagingManifestFactory.createStagingManifest(StagingManifestFactory.java:46)
	at nl.esciencecenter.computeservice.rest.service.tasks.CwlStageInTask.run(CwlStageInTask.java:59)
	at nl.esciencecenter.computeservice.rest.service.tasks.XenonMonitoringTask.startStageInForSubmittedJobs(XenonMonitoringTask.java:327)
	at nl.esciencecenter.computeservice.rest.service.tasks.XenonMonitoringTask.update(XenonMonitoringTask.java:117)
	at sun.reflect.GeneratedMethodAccessor85.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.springframework.scheduling.support.ScheduledMethodRunnable.run(ScheduledMethodRunnable.java:65)
	at org.springframework.scheduling.support.DelegatingErrorHandlingRunnable.run(DelegatingErrorHandlingRunnable.java:54)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)

Looking at it again this may be an issue of Sardine as it issues a HEAD request to see if the url exists, but perhaps does not supply the Authorization header.
I know the OPTIONS http request should be possible without authorization header (to allow for preflight requests), do you know if HEAD requires the same?

Always send credentials in 6130e6bfceb305ba5ab1c75413e5e9695860668c

Tried the new build, but it does not seem to fix the issue.
The webdav server returns a 401 Unauthorized header, with the correct WWW-Authenticate header set.

The https://www.w3.org/TR/cors/#cross-origin-request-with-preflight-0 says that a client should exclude the user credentials headers.

We finally figured out that the problem was with a base64 encoding I used somewhere in my application that meant I supplied the wrong password to the fileadaptor.
So in the end there was no bug with xenon or sardine, but with my config.
Sorry for the hassle :)

No worries.


docs: cloud docs are hard to use

I find the cloud docs pretty hard to navigate right now, the top nav links me to the cloud page that only has the index https://docs.meltano.com/cloud/. I'm never quite sure where to go from there and how to find what I'm looking for.
Some ideas and suggestions:

Add some kind of marketing blurb to the cloud docs page. What is cloud? Why use it over self hosted? Main features? How to get started today or get more info?
Link to https://meltano.com/cloud/
The cloud index page should probably have a "next" link to encourage users to go to the next appropriate page. I think that would be onboarding but not sure.
Maybe add "references" as a subgroup that encapsulates stuff like: CLI, platform info, security
Adding a new section related to Support or troubleshooting. Redirecting people to slack or where ever else.
Remove https://docs.meltano.com/cloud/encrypting_secrets because I dont think its used anywhere
"Meltano cloud" is an item in the index which links to the page youre already on

Agreed! PRs welcome 😄 We're also going to move to Docusaurus pre-GA which will help (but also make more evident any information architecture problems)

Closed by https://github.com/meltano/meltano/pull/7758


BuildStream is now completely broken on MacOS

See original issue on GitLab
In GitLab by [Gitlab user @cs-shadow] on Nov 5, 2020, 19:55
Summary
Last time I was using BuildStream on Mac (a good few months ago now) I was able of running most (if not all) non-integration tests locally. And the CLI also used to work fine for the most part. Of course, anything that needed a real sandbox wouldn't work, but import elements etc would work fine.
It seems like now, things are completely broken and a bst build on our first example project results in a failure with a BUG message.
Steps to reproduce
pre-requisites:

Find a MacOS machine
Clone and install BuildStream master

then:
# this works fine
$ bst -C doc/examples/first-project show
...
   buildable b7a8b07d97bafb0ac1029d7f6164a49b636b1dcea34efa89ca5eb951aeeef401 hello.bst

# build fails miserably, pages and pages of the same error is repeated
$ bst -C doc/examples/first-project build
...
[--:--:--][b7a8b07d][    main:hello.bst                     ] STATUS  Fetch terminating
[--:--:--][        ][    main:core activity                 ] BUG     'NoneType' object has no attribute 'terminate'

    Traceback (most recent call last):
      File "/usr/local/Cellar/python[[Gitlab user @3]](https://gitlab.com/3).8/3.8.5/Frameworks/Python.framework/Versions/3.8/lib/python3.8/asyncio/events.py", line 81, in _run
        self._context.run(self._callback, *self._args)
      File "/Users/enigma/git/buildstream/buildstream/src/buildstream/_scheduler/scheduler.py", line 496, in _terminate_jobs_real
        job.terminate()
      File "/Users/enigma/git/buildstream/buildstream/src/buildstream/_scheduler/jobs/job.py", line 216, in terminate
        self._process.terminate()
      File "/usr/local/Cellar/python[[Gitlab user @3]](https://gitlab.com/3).8/3.8.5/Frameworks/Python.framework/Versions/3.8/lib/python3.8/multiprocessing/process.py", line 133, in terminate
        self._popen.terminate()
    AttributeError: 'NoneType' object has no attribute 'terminate'

[--:--:--][b7a8b07d][    main:hello.bst                     ] STATUS  Fetch terminating
[--:--:--][        ][    main:core activity                 ] BUG     'NoneType' object has no attribute 'terminate'

    Traceback (most recent call last):
      File "/usr/local/Cellar/python[[Gitlab user @3]](https://gitlab.com/3).8/3.8.5/Frameworks/Python.framework/Versions/3.8/lib/python3.8/asyncio/events.py", line 81, in _run
        self._context.run(self._callback, *self._args)
      File "/Users/enigma/git/buildstream/buildstream/src/buildstream/_scheduler/scheduler.py", line 496, in _terminate_jobs_real
        job.terminate()
      File "/Users/enigma/git/buildstream/buildstream/src/buildstream/_scheduler/jobs/job.py", line 216, in terminate
        self._process.terminate()
      File "/usr/local/Cellar/python[[Gitlab user @3]](https://gitlab.com/3).8/3.8.5/Frameworks/Python.framework/Versions/3.8/lib/python3.8/multiprocessing/process.py", line 133, in terminate
        self._popen.terminate()
    AttributeError: 'NoneType' object has no attribute 'terminate'

What is the current bug behavior?
Pages and pages of bug messages repeated over and over again, that is even hard to ctrl-c.
What is the expected correct behavior?
Ideally, we'd get back to the previous behavior of being able to build elements that don't require a sandbox.

I'm not sure when this started happening but is at least an issue since 9f205147b5461cc29486f2c1830e88913a8d098e (which is what I tried today).

In GitLab by [Gitlab user @cs-shadow] on Nov 5, 2020, 20:14
mentioned in merge request !1982

In GitLab by [Gitlab user @cs-shadow] on Nov 5, 2020, 20:14
mentioned in merge request !1982

In GitLab by [Gitlab user @nanonyme] on Nov 5, 2020, 20:46
I wonder if this has to do with Mac defaulting to spawn start method for multiprocessing unlike all other POSIX platforms. (which use fork)

In GitLab by [Gitlab user @nanonyme] on Nov 5, 2020, 20:46
I wonder if this has to do with Mac defaulting to spawn start method for multiprocessing unlike all other POSIX platforms. (which use fork)


HE-legacy discord

Hi everyone,
I have created a discord that people can join
https://discord.gg/TCgBpA2
I feel there should be a central place where all people can go ask for help, talk about programming things and watch or help other developers in there efforts to do whatever there doing with HE.
I personally am working on a recode myself it will most likely go into a branch of the official legacy fork on my github for now it is not ready to be pushed but when it is i will have notices the discord.
Things I'll be using in my recode so far:
composer - dependency management
Doctrine dbal - database management
Phinx - database migration
Twig - Html templating
Html_Purify - XXS ad other security features
sendgrid or mailchimp - email management
If you have a recode in works or are working on fixing or doing something awesome with the legacy source then join up approved developers will get a rank and a github channel they will be able to setup webhook for.
Join the discord below:
https://discord.gg/TCgBpA2

looking for people to help with larvel recode i started here
https://github.com/advocaite/hackerEx


rockhopper output file names are ambigous

name rockhopper output files with the user provided output name. Otherwise, rockhopper runs that are different sets of conditions that map to the same reference genome will be named the same.
Also, make RNAseq results visible in the Diff Exp Import chooser.

Picture 1: Shows the ambiguity.
![screen shot 2015-06-20 at 10 15 59 am]
(https://cloud.githubusercontent.com/assets/991769/8267858/8f05c342-1735-11e5-9cb6-4209a31564b6.png)
Picture 2: Shows that the user can not navigate to the .gmx file because the chooser doesn't see the rna seq result object.

Picture 3: Shows that there is an RNA seq result object in the workspace.

Assigning to Andrew. Andrew, please reassign as necessary.

Andrew, these should prefix the output with the output name like genome annotation does.

The generation of the *.gmx file for rockhopper is a recent addition to the RNA-Seq wrapper. Outside of Fangfang this will probably be easiest for Bob to fix. Assigning it to him.
Bob it looks like this line might be a likely target.
https://github.com/levinas/app_service/commit/c62968a426c66b2769fff314d6d1decdb291bca0#diff-850e7ee9804d73bc168e17d02a37c086R171
This brings up a more general issue: do we want to require universal prepending for all service output files from now on? This will produce long names and is only informative from outside the job. I think that a more elegant solution would be to show the name of job_result prepended to the file name with a slash so it would be governed by the "OuputName". For example:
my_exp1/Rockhopper_1310581_gene_exp.gmx

I agree - if the output folder name is already distinguishing, repeating that in the file names just for the purpose of the shortcut dropdowns seems redundant.
On Jun 23, 2015, at 2:08 PM, Andrew Warren <notifications<EMAIL_ADDRESS>wrote:
The generation of the *.gmx file for rockhopper is a recent addition to the RNA-Seq wrapper. Outside of Fangfang this will probably be easiest for Bob to fix. Assigning it to him.
Bob it looks like this line might be a likely target.
levinas/app_service@c62968a#diff-850e7ee9804d73bc168e17d02a37c086R171https://github.com/levinas/app_service/commit/c62968a426c66b2769fff314d6d1decdb291bca0#diff-850e7ee9804d73bc168e17d02a37c086R171
This brings up a more general issue: do we want to require universal prepending for all service output files from now on? This will produce long names and is only informative from outside the job. I think that a more elegant solution would be to show the name of job_result prepended to the file name with a slash so it would be governed by the "OuputName". For example:
my_exp1/Rockhopper_1310581_gene_exp.gmx
—
Reply to this email directly or view it on GitHubhttps://github.com/PATRIC3/patric3_website/issues/320#issuecomment-114613171.

@olsonanl @dmachi I have committed some prepend functionality for the ObjectSelector dropdowns. Check out beta.

I downloaded 4 rockhopper results recently, they were named the same. I
could rename each after downloading.
On Jul 1, 2015 5:47 AM, "Andrew Warren"<EMAIL_ADDRESS>wrote:

@olsonanl https://github.com/olsonanl @dmachi
https://github.com/dmachi I have committed some prepend functionality
for the ObjectSelector dropdowns. Check out beta.
—
Reply to this email directly or view it on GitHub
https://github.com/PATRIC3/patric3_website/issues/320#issuecomment-117354549
.

The above update should fix the ambiguity issue.


Issue with song crossfade and/or ads

I finished the first song I used with it, the display froze and now I need to restart the StatusApplet, probably due to song crossfade

Is this reproducible?

It appears to happen randomly, though ALWAYS at the end of the song. It always occurs when a commercial appears, and sometimes when a song ends.

The latest changes add a bit more handling for Ads, let me create a new binary package for testing and I'll point you at it once available.

Thank you! (Oh and BTW it works perfectly on my Logitech G15 when it functions.)

Ok so v1.3 beta 1 is now available on http://lucaspardue.com/spotifystatusapplet/
It may or may not help you out, lets see if I can look into it in the background.

I'll be back soon with results.


[Feature Request] Enable Streaming for ChatGPT Models

Would it be possible to enable streaming for ChatGPT models?
Langchain does have support, but it seems the mechanism (via callbacks) is different from the current implementation.
Support for this would go a long way in reducing costs while maintaining that low perceived latency.

Relevant article: https://blog.langchain.dev/streaming-support-in-langchain/

Here's a potential approach: https://github.com/hwchase17/langchain/discussions/1706

Would it be possible to enable streaming for ChatGPT models? Langchain does have support, but it seems the mechanism (via callbacks) is different from the current implementation.
Support for this would go a long way in reducing costs while maintaining that low perceived latency.

streaming is available already. set streaming=True
https://gpt-index.readthedocs.io/en/latest/reference/response.html#gpt_index.response.schema.StreamingResponse

There’s an instance check that blocks anything other than the standard OpenAI class from leveraging streaming. Someone just posted another issue with the relevant code block.
Implementing this will require a signification rework of the response class.

There’s an instance check that blocks anything other than the standard OpenAI class from leveraging streaming. Someone just posted another issue with the relevant code block.
Implementing this will require a signification rework of the response class.

Oh, I get what you mean.

Hi @decent-engineer-decent-datascientist @Smyja , we put out an initial PR adding streaming to llamaindex with the callback manager: https://github.com/jerryjliu/llama_index/pull/1059
Tbh it's a bit hacky but would love for you to try it out. The key challenge right now is that we don't have a good way to delineate what the "final" llm generated output is, so that we only stream that instead of all intermediate outputs.

@decent-engineer-decent-datascientist did you manage to test this out?
I got it to work but only if the text is shorter than max_input_size. Anything longer ran into this issue here
For now I'm falling back to just using the callback_manager as part of the llm class directly.

@jerryjliu looks like langchain reworked their callbacks. this should allow selective stream:
https://python.langchain.com/en/latest/modules/callbacks/getting_started.html#using-multiple-handlers-passing-in-handlers

We've fixed streaming! https://github.com/jerryjliu/llama_index/pull/3125
guide here: https://gpt-index.readthedocs.io/en/latest/how_to/customization/streaming.html


Stop using std::wstring in our code.

Chromium's coding style (as well as Google's) says using wstring is
frowned upon for multiple reasons. There is even a check in Chromium's
main PRESUBMIT.py that prevents new wstrings from being added in
crosswalk-platform code.
The only use was in code copied from content_shell in
2013 (RuntimeDownloadManagerDelegate::ChooseDownloadPath()), which
could be rewritten using only base::FilePaths and Chromium's
OPENFILENAME wrapper class. In any case, Crosswalk on Windows still
does not support downloads so the change cannot break anything (even
though I have verified it does build).
This change is another step towards enabling more PRESUBMIT checks for
our code.

ping @darktears @pozdnyakov

LGTM


Adding ServiceNow adapter in knowledge-connector-app

Adding ServiceNow adapter in knowledge-connector-app

Only the last commit needs to be reviewed: https://github.com/MyPureCloud/knowledge-connector-app/pull/10/commits/9fcf61eb241b146fe11519e1722de689dc3f08a5
The others were merged into main within an other PR.


fix: Tasks QA bug fixes

This PR resolves EMI-2166, EMI-2169, and EMI-2171
Description
This PR fixes 2 issues from the Tasks QA

Attempting to fix the onboarding animation
Navigate the user to the order details screen instead of the web view (and maybe fix the Android issue of the blank screen)

This PR also adds /orders/:orderID to the routers
Videos
Videos
Before

Android
iOS

Tapping tasks

Send Wire screen

View Pending Order

View Offer

After

Android
iOS

Tapping tasks

Send Wire screen

View Pending Order

View Offer

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

fix tasks onboard animation
add order details URL to routes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (fix tasks onboard animation,add order details URL to routes - MrSltun)

  Generated by :no_entry_sign: dangerJS against 828fa2efa7451648724669e06726edb1fc22d34f


Timeout while connecting through react native (Specifically Android, for iOS it is working)

What version were you using?
Server Version: 2.8.4
Client Version: 1.11.2 - nats.ws (nats.js file is being used)
What environment was the server running in?
The client is running on android (tried both, the emulator and the actual device)
Is this defect reproducible?
connect({         servers: server, //My Server URL i.e. wss://url.to.server/ws         noEcho: true,         token: sdjfhjsERDFDf, //A String is being used here       })         .then((nc: NatsConnectionImpl) => {           resolve(nc);         })         .catch((reason) => {           console.log("REASON>>>", reason);           resolve(null);         })     });
Given the capability you are leveraging, describe your expectation?
This should connect to the web socket and not give the timeout as it is running for the iOS version with the same code mentioned above.
Given the expectation, what is the defect you are observing?
For Android devices, I am getting connection timeout while it is working fine for iOS.

I'm facing the same problem here.

Same problem here

Are you setting the timeout? - The timeout means that the client was not able to get a handshake within the specified timeout window - by default it is 20s.

There's a duplicate, that has some additional information:
https://github.com/nats-io/nats.ws/issues/221

NATS seems to take a while to connect, and sometimes it doesn’t connect at all. From my experience, it takes significantly longer to connect on Android—sometimes over a minute.
On iOS, however, the connection time is much shorter, being noticeably faster than on Android, even when using the same network.
Also, depending on the version of Android, the connection time appears to increase further.
This is how I’m making the connection. When I get a timeout, I have to try reconnecting
export async function createConnection(
  localId: string,
  userId: string,
  authenticator: string,
) {
  try {
    const server: string[] = ['wss://serverhost'];
    const clientId: string = `${localId}-${userId}-${
      Math.floor(Math.random() * 100) + 1
    }`;
    const connection: NatsConnection = await connect({
      name: clientId,
      servers: server,
      authenticator: credsAuthenticator(
        new TextEncoder().encode(authenticator),
      ),
      tls: null,
      debug: false,
      noEcho: true,
      inboxPrefix: `${localId}._INBOX`,
      timeout: 3000,
      reconnect: true,
    });
    console.log('NATS CONNECTED');
    return new BrokerClient(clientId, connection);
  } catch (exception) {
    console.error(exception);
    return null;
  }
}

Você está definindo o tempo limite? - O tempo limite significa que o cliente não conseguiu obter um handshake dentro da janela de tempo limite especificada - por padrão, é 20s.

NATS seems to take a while to connect, and sometimes it doesn’t connect at all. From my experience, it takes significantly longer to connect on Android—sometimes over a minute.
On iOS, however, the connection time is much shorter, being noticeably faster than on Android, even when using the same network.
Also, depending on the version of Android, the connection time appears to increase further.
This is how I’m making the connection. When I get a timeout, I have to try reconnecting
export async function createConnection(
localId: string,
userId: string,
authenticator: string,
) {
try {
const server: string[] = ['wss://serverhost'];
const clientId: string = ${localId}-${userId}-${       Math.floor(Math.random() * 100) + 1     };
const connection: NatsConnection = await connect({
name: clientId,
servers: server,
authenticator: credsAuthenticator(
new TextEncoder().encode(authenticator),
),
tls: null,
debug: false,
noEcho: true,
inboxPrefix: ${localId}._INBOX,
timeout: 3000,
reconnect: true,
});
console.log('NATS CONNECTED');
return new BrokerClient(clientId, connection);
} catch (exception) {
console.error(exception);
return null;
}
}

Você está definindo o tempo limite? - O tempo limite significa que o cliente não conseguiu obter um handshake dentro da janela de tempo limite especificada - por padrão, é 20s.

NATS seems to take a while to connect, and sometimes it doesn’t connect at all. From my experience, it takes significantly longer to connect on Android—sometimes over a minute.
On iOS, however, the connection time is much shorter, being noticeably faster than on Android, even when using the same network.
Also, depending on the version of Android, the connection time appears to increase further.
This is how I’m making the connection. When I get a timeout, I have to try reconnecting
export async function createConnection(
  localId: string,
  userId: string,
  authenticator: string,
) {
  try {
    const server: string[] = ['wss://serverhost'];
    const clientId: string = `${localId}-${userId}-${
      Math.floor(Math.random() * 100) + 1
    }`;
    const connection: NatsConnection = await connect({
      name: clientId,
      servers: server,
      authenticator: credsAuthenticator(
        new TextEncoder().encode(authenticator),
      ),
      tls: null,
      debug: false,
      noEcho: true,
      inboxPrefix: `${localId}._INBOX`,
      timeout: 3000,
      reconnect: true,
    });
    console.log('NATS CONNECTED');
    return new BrokerClient(clientId, connection);
  } catch (exception) {
    console.error(exception);
    return null;
  }
}

Há uma duplicata que contém algumas informações adicionais:
#221

I tried this, but the connection is still either slow or not connecting at all.


gRPC references old protobuf submodule version

Please answer these questions before submitting your issue.
Should this be an issue in the gRPC issue tracker?
Create new issues for bugs and feature requests. An issue needs to be actionable. General gRPC discussions and usage questions belong to:

grpc.io mailing list
StackOverflow, with grpc tag

Please don't double post your questions in more locations; we are monitoring both channels, and the time spent de-duplicating questions is better spent answering more user questions.
What version of gRPC and what language are you using?
v1.7.2 C++
What operating system (Linux, Windows, …) and version?
Linux
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc7
What did you do?
If possible, provide a recipe for reproducing the error. Try being specific and include code snippets if helpful.
Cloned fresh 1.7.2 branch locally, compiled it (using built in protobuf third party submodule), and then attempted to build my app against this version (using pregenerated protobuf headers with the protoc 3.5 compiler).
What did you expect to see?
My app to compile :) It would be great to have the .gitmodules file updated to the recent protobuf versions (especially so they match what vcpkg is set to, i.e. gRPC 1.7 and protobuf 3.5)
What did you see instead?
The current outdated third party protobuf submodule causes compile errors because the submodule for protobuf within gRPC is old (i.e. v3.0-3.4 even for branches like 1.7 or 1.8).
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
/app/halcyon/Proto/proto/google/api/annotations.pb.h:14:2: error: #error your headers.
 #error your headers.
  ^~~~~
In file included from /app/halcyon/Proto/proto/google/api/annotations.pb.h:30:0,
                 from /app/halcyon/Proto/proto/AssetService.pb.h:32,
                 from /app/halcyon/Proto/proto/AssetService.grpc.pb.cc:5:
/app/halcyon/Proto/proto/./google/api/http.pb.h:12:2: error: #error This file was generated by a newer version of protoc which is
 #error This file was generated by a newer version of protoc which is
  ^~~~~
/app/halcyon/Proto/proto/./google/api/http.pb.h:13:2: error: #error incompatible with your Protocol Buffer headers. Please update
 #error incompatible with your Protocol Buffer headers.  Please update
  ^~~~~
/app/halcyon/Proto/proto/./google/api/http.pb.h:14:2: error: #error your headers.
 #error your headers.
  ^~~~~
In file included from /app/halcyon/Proto/proto/google/api/annotations.pb.h:30:0,
                 from /app/halcyon/Proto/proto/AssetService.pb.h:32,
                 from /app/halcyon/Proto/proto/AssetService.grpc.pb.cc:5:
/app/halcyon/Proto/proto/./google/api/http.pb.h: In member function 'google::api::CustomHttpPattern* google::api::HttpRule::release_custom()':
/app/halcyon/Proto/proto/./google/api/http.pb.h:1454:44: error: 'DuplicateIfNonNull' is not a member of 'google::protobuf::internal'
       temp = ::google::protobuf::internal::DuplicateIfNonNull(temp, NULL);

Anything else we should know about your project / environment?

The 1.8.x branch which will be released soon pulls in protobuf 3.5.0.
However, gRPC and protobuf at runtime are mostly independent at runtime. The submodule mainly influences the gRPC protoc plugin that gets built. If you generate your pb2 files with a newer protoc version, you can simply link your app to a newer protobuf runtime library and it should work. Is there a reason that would not be satisfactory for your use case?


Update dependencies using pip-compile-multi

Description
At the moment, tests are failing in Python 3.12-dev due to DeprecationWarning. Updated versions using pip-com[ile-multi in order to fix to problem
Fixes #2489
Checklist:

[ ] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
[ ] Add or update relevant docs, in the docs folder and in code.
[ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
[ ] Add .. versionchanged:: entries in any relevant code docs.
[X] Run pre-commit hooks and fix any issues.
[X] Run pytest and tox, no tests failed.

Needs to be applied to 8.1.x first, then merged forward into main. I changed the target of the PR, but you'll need to rebase:
$ git rebase --onto origin/8.1.x origin/main
$ git push -f

Also note that you need to check mypy again when upgrading mypy (you can just make an extra "fix mypy findings" commit). There's also pre-commit autoupdate, although pre-commit.ci just ran a few days ago so it probably won't update anything.


Compilation errors include of non-modular headers and duplicate interface definition

use_frameworks!
use_modular_headers!
Installing AppAuth (1.6.0)
Installing GTMAppAuth (1.3.1)
Installing GTMSessionFetcher (2.3.0)
Installing GoogleSignIn (6.2.4)
Installing RNGoogleSignin (8.2.1)
Hi guys!

I'm using Google Sign-in with cocoapods through react-native.  I have an objective c and swift project with a few views in react native. One view in react native is used for logging in a specific type of user and a swift view is used for logging in another type of user.  Everything compiles and works wonderfully with react-native-google-sign version 7.2.2 which uses GoogleSignIn 6.1.0.  When I upgrade to use react-native-google-sign version 8.2.1 which uses GoogleSignIn 6.2.4.  I receive numerous compilation errors that I haven’t been able to figure out the issue.
Podile has
use_frameworks!
use_modular_headers!
And installed these versions
Installing AppAuth (1.6.0)
Installing GTMAppAuth (1.3.1)
Installing GTMSessionFetcher (2.3.0)
Installing GoogleSignIn (6.2.4)
Installing RNGoogleSignin (8.2.1)
using Xcode 13.4.1
These are the errors:
In File GTMSessionFetcherLogging.h
App/Pods/GTMSessionFetcher/Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcherLogging.h:16:9: Include of non-modular header inside framework module 'GTMSessionFetcher.GTMSessionFetcherLogging': 'App/../Pods/GTMSessionFetcher/Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcher.h'
App/Pods/GoogleSignIn/GoogleSignIn/Sources/Public/GoogleSignIn/GIDAuthentication.h:24:9: While building module 'GTMAppAuth' imported from'App//Build/Products/Debug-iphonesimulator/GoogleSignIn/GoogleSignIn.framework/Headers/GIDAuthentication.h:24:
App/Pods/GTMAppAuth/GTMAppAuth/Sources/Public/GTMAppAuth/GTMAppAuthFetcherAuthorization.h:22:11: While building module 'GTMSessionFetcher' imported from'App//Build/Products/Debug-iphonesimulator/GTMAppAuth/GTMAppAuth.framework/Headers/GTMAppAuthFetcherAuthorization.h:22:
App/Nearpod/:1:9: In file included from :1:
App/Pods/Target Support Files/GTMSessionFetcher/GTMSessionFetcher-umbrella.h:14:9: In file included from'App//Build/Products/Debug-iphonesimulator/GTMSessionFetcher/GTMSessionFetcher.framework/Headers/GTMSessionFetcher-umbrella.h:14:
App/Pods/GTMSessionFetcher/Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcherLogging.h:16:9: In file included from'App//Build/Products/Debug-iphonesimulator/GTMSessionFetcher/GTMSessionFetcher.framework/Headers/GTMSessionFetcherLogging.h:16:
In file GTMSessionFetcher.h
App/Pods/GTMSessionFetcher/Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcher.h:420:1: Duplicate interface definition for class 'GTMSessionFetcherUserDefaultsFactory'
App/Pods/GTMSessionFetcher/Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcher.h:420:12: Previous definition is here
App/Pods/GoogleSignIn/GoogleSignIn/Sources/Public/GoogleSignIn/GIDAuthentication.h:24:9: While building module 'GTMAppAuth' imported from App/Build/Products/Debug-iphonesimulator/GoogleSignIn/GoogleSignIn.framework/Headers/GIDAuthentication.h:24:
App/Pods/GTMAppAuth/GTMAppAuth/Sources/Public/GTMAppAuth/GTMAppAuthFetcherAuthorization.h:22:11: While building module 'GTMSessionFetcher' imported from App/Build/Products/Debug-iphonesimulator/GTMAppAuth/GTMAppAuth.framework/Headers/GTMAppAuthFetcherAuthorization.h:22:
App/:1:9: In file included from :1:
App/Pods/Target Support Files/GTMSessionFetcher/GTMSessionFetcher-umbrella.h:14:9: In file included from App/Build/Products/Debug-iphonesimulator/GTMSessionFetcher/GTMSessionFetcher.framework/Headers/GTMSessionFetcher-umbrella.h:14:
App/Pods/GTMSessionFetcher/Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcherLogging.h:16:9: In file included from App/Build/Products/Debug-iphonesimulator/GTMSessionFetcher/GTMSessionFetcher.framework/Headers/GTMSessionFetcherLogging.h:16:
App/Pods/GTMSessionFetcher/Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcher.h:430:28: Redefinition of 'GTMSessionFetcherError'
App/Pods/GTMSessionFetcher/Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcher.h:430:28: Previous definition is here
App/Pods/GoogleSignIn/GoogleSignIn/Sources/Public/GoogleSignIn/GIDAuthentication.h:24:9: While building module 'GTMAppAuth' imported from App/Build/Products/Debug-iphonesimulator/GoogleSignIn/GoogleSignIn.framework/Headers/GIDAuthentication.h:24:
App/Pods/GTMAppAuth/GTMAppAuth/Sources/Public/GTMAppAuth/GTMAppAuthFetcherAuthorization.h:22:11: While building module 'GTMSessionFetcher' imported from App/Build/Products/Debug-iphonesimulator/GTMAppAuth/GTMAppAuth.framework/Headers/GTMAppAuthFetcherAuthorization.h:22:
App/:1:9: In file included from :1:
App/Pods/Target Support Files/GTMSessionFetcher/GTMSessionFetcher-umbrella.h:14:9: In file included from App/Build/Products/Debug-iphonesimulator/GTMSessionFetcher/GTMSessionFetcher.framework/Headers/GTMSessionFetcher-umbrella.h:14:
App/Pods/GTMSessionFetcher/Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcherLogging.h:16:9: In file included from App/Build/Products/Debug-iphonesimulator/GTMSessionFetcher/GTMSessionFetcher.framework/Headers/GTMSessionFetcherLogging.h:16:
Any solutions?
Thanks in advance
M

After a few days and reaching out to you, I finally found the culprit.  I changed a "@import GoogleSignIn;" to "#import  #import <GoogleSignin/GIDSignIn.h>" in an objective c file.
Thanks so much

Glad you were able to get it building.  Had you considered removing use_modular_headers! from your podfile?


correct emphasis for Startup.cs

Hi @colhountech, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Thanks, :shipit:

@colhountech  Thanks. Merged e7b7dec5a1907a66bc651de855fe6471b01ca212


Changes to support imported structs with ptruath qualified field function pointers

Details in individual commit messages.

@swift-ci test

@swift-ci test macOS platform


Small fixes on first article about web

Really good article overall, I'm looking forward to read the next ones :)

Hi @JeremyJames!
Thanks a lot for this PR 💜. Glad to see that you love the article, I hope that you’ll love the next ones 😉.
(And if you’re in Lyon, don’t hesitate to send a mail, I’ll be happy to drink a beer with you!)


Discounts` Admin UI

Hi @biilmann ,
As discussed in the Netlify office, here's my take on how an ideal Discounts Admin UI should be structured:
Discount Code:

[ ] Input field

Conditions:

[ ] Percentage value
[ ] or Absolute value (with values for EUR & USD)

For:

[ ] All Orders
[ ] Orders Over ...
[ ] Product Category
[ ] Product

Usage Limits:

[ ] Unlimited
[ ] Limited number of uses
[ ] 1 use only (tracked by customer's email)

[ ] Date range: Start date, End date, No end date

A quick solution would be to handle those inside the CMS because the coupons are already living in the git and accessed via the static page.
We could then make special issues if the coupon logic in gocommerce is not sufficient.


Clean up old mono repo files

🤔 What's changed?

Merged all the duplicate LICENSE files.
Removed Makefiles
Remove miscellaneous build scripts

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.17%. Comparing base (3994eaa) to head (915f166).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   91.17%   91.17%
=======================================
  Files           2        2
  Lines          34       34
=======================================
  Hits           31       31
  Misses          3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


chore: add provenance as an input CLI option

Closes #34 .
This PR includes the following additions:

A CLI option --provenance-file is added to received the provenance path from the user.
The provenance content is loaded using the existing load_provenance_payload method.
The provenance payload is stored within the AnalyzeContext that we generate from the main software component.
This PR does not implements the validation and extracting information from the provenances. That will be added within https://github.com/oracle/macaron/pull/653.

Can you please add this new option to the CLI documentation?

Should the provenance_available_check be updated to check the analysis context for user provided provenance?

Should the provenance_available_check be updated to check the analysis context for user provided provenance?

Changing the provenance check and the related refactoring can be done in the next PR.

Can you please add this new option to the CLI documentation?

I have added it in this commit https://github.com/oracle/macaron/pull/654/commits/ca2061eda7ec754c168d1bfdcfcf413a253d5457


sprinkle llvm_unreachable for covered switches (NFC)

Annotate the covered switches with llvm_unreachable to avoid the MSVC
warning which does not recognise the covered switches.  This allows us
to avoid a spew of warnings.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test


Improve high-order horizontal derivatives

Purpose

This PR fixes a potential issue with high-order horizontal derivatives at element boundaries that was identified while writing the dycore paper. Specifically, it replaces every "strong derivative" (an ill-defined notion for our hybrid CG-DG discretization) with a "weak derivative" (defined in terms of the weak formulation and GLL quadrature rule) and a call to DSS. Hopefully this will reduce numerical oscillations at element boundaries from hyperdiffusion and the viscous sponge layer.
To-do
Find a specific example where this leads to a behavioral change.

[ ] I have read and checked the items on the review checklist.

Following a conversation with Oswald, it looks like this is not the way we want to compute horizontal derivatives. Certain derivatives in the hyperdiffusion and sponge tendencies should remain strong, as they are now. I'm still unclear on the details, but hopefully we can hash them out in one of the paper appendices.


Add translatable help page

This looks good. I added a first draft for the Help page.
@danielfdsilva would it be possible make the anchors work? This will be important if we stick to a one-page help text.

Great, thanks!


Gcmon 797: re-implement StationCreditSpec as mybatis

Looks good to me, tested fine as well. I thought I saw an issue but it's the same way on the prod site so no problem here ;) (the credit data on the reach page isn't sorted the same as it is on the station page 🤷♀ - but it is the same on prod)


Figure out why PR 13944 was accidentally merged

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

cc @Expensify/mobile-deployers creating this issue so we make sure to figure out how this happened
Action Performed:

I created https://github.com/Expensify/App/pull/12168 a while ago
Then I split off a couple branches from my development branch, and extracted two other PRs from it:

https://github.com/Expensify/App/pull/13943
https://github.com/Expensify/App/pull/13944
Then I simplified the original PR #12168 to remove those changes

Then https://github.com/Expensify/App/pull/12168 got tested and approved, so I merged it.

Expected Result:
Merging https://github.com/Expensify/App/pull/12168 should not have caused any other PR to be merged. I should not have been able to merge https://github.com/Expensify/App/pull/13944 without:

Removing the HOLD prefix
Removing the WIP prefix
Making it a non-draft PR
Getting it approved

Actual Result:
Merging https://github.com/Expensify/App/pull/12168 automatically merged https://github.com/Expensify/App/pull/13944 somehow.

The code from https://github.com/Expensify/App/pull/13944 does not appear to have been actually merged to main, so I think this must have just been a GitHub bug


feat [IDP-1796] : Added the release-notes for IDP v0.16.0

Harness Developer Pull Request
Added the release-notes for IDP v0.16.0
What Type of PR is This?

[ ] Issue
[x] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6571ece3120bbc086dce38b9--harness-developer.netlify.app


Can't load the kernel driver on the latest Windows 11 23H2 build 22631.3593

Brief description of your issue
Kernel driver unable to load after 2024-05 Cumulative Update for Windows 11 Version 23H2 for x64-based Systems (KB5037771) installed on my PC.
Steps to reproduce (optional)
Launch System Informer as usual (in administrator mode). Open Options > ☑ Enable kernel-mode driver. Restart System Informer.
Expected behavior (optional)
It should load the kernel driver normally after restart.
Actual behavior (optional)
Got an error message that current System Informer's kernel-mode driver is not supported.

Environment (optional)
System Informer 3.07579 (fc042be) Canary
Windows 11 23H2 build 22631
Kernel version 10.0.22621.3593

Duplicate: https://github.com/winsiderss/systeminformer/issues/1823

Duplicate: #1823

Oh, sorry. I'll forwarding on that anyways.


Use array_replace_recursive instead of array_merge when collecting result

This fixes #138, but see https://github.com/Youshido/GraphQL/issues/138#issuecomment-323066259

Thank you!


Modal is pushed to bottom of screen and cutoff on mobile devices

I'm testing this on my iPhone 10X and the modal appears at the bottom of the screen and a portion of the modal is cutoff, you have to scroll the modal up with your finger for it to fit on the screen. I've messed around with some of the stylings to see what's causing this but haven't been able to figure it out. Does anyone know what's causing this?

Same thing happens for me on a Pixel 4a.
Looks to be intentionally aligned to the bottom on < sm breakpoints,
https://github.com/livewire-ui/modal/blob/0fe7036574868758f328e2266ecf27d3b30b7555/resources/views/modal.blade.php#L20

@jacovdbergh on mobile the modal is pushed down to make it easier to reach with your fingers. @jringeisen did you change the markup of the modal? Because it should fill the entire screen and become scrollable if the modal is quite big.

@PhiloNL the modal is scrollable and I can use my finger to scroll and bring it into view, but this is a small modal and should fit on the screen without having to scroll. When I use Enter Responsive Mode in safari on my MacBook it looks good and does what it's supposed to, but when I use the modal on my mobile device it gets cut off. I didn't make any changes to the modal markup.

@jacovdbergh items-center fixed this issue for me.

Seems like the issue (on Android Chrome at least) is when the URL/menu bar is shown at the top. Then the min-height: 100vh; element is pushed off by the menu's height at the bottom, and the modal also gets cut off at the bottom.

Hi, @jringeisen sorry for the late reply the bellow is my code.
`

        <div
                x-show="show && showActiveComponent"
                x-transition:enter="ease-out duration-300"
                x-transition:enter-start="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95"
                x-transition:enter-end="opacity-100 translate-y-0 sm:scale-100"
                x-transition:leave="ease-in duration-200"
                x-transition:leave-start="opacity-100 translate-y-0 sm:scale-100"
                x-transition:leave-end="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95"
                x-bind:class="modalWidth"
                class="inline-block w-full align-bottom bg-white rounded-lg text-left overflow-hidden shadow-xl transform transition-all sm:my-8 sm:align-middle sm:w-full"
        >
            @forelse($components as $id => $component)

                    @livewire($component['name'], $component['attributes'], key($id))

            @empty
            @endforelse

`

I found there is a conflict with my CSS

Hello. Anyone how uses this package with bootstrap 5. Because I still facing the same challenge but when I comment on my CSS link it works fine.

This is what happening

Hi, just want to make sure if the items-center has been fixed? or should we implement it ourselves? Thank you

Always remember you can publish the views and configs to tailor it to your needs! Just keep in mind to not just blindly upgrade without looking at the tag changes. Sometimes, in a case like this when I want someone to maintain most of the burden and I just want to use the package I'll lock it at a tag, and if a new version comes out that fixes it, I'll pull out my overrides and jump back to defaults. If your overrides are pretty extensive, you can fork the repository and use it in the project instead. That way you can break off the trunk at that point and either PR in fixes, or just continue to maintain your own upgrade paths. I do that from time to time when I have needs that differ from the main intention of the project but it starts off as a great base. Or when people just run out of time. We all get smoked occasionally.

i have the opposite problem: modal visible on small screens. not visible on taller screens. managed to resolve the issue by removing this line:
https://github.com/wire-elements/modal/blob/b5786ea5fc9ca68e166e6cff2e2efb5de25e0590/resources/views/modal.blade.php#L35

Hi. This issue seems to be still pending. Any fix?

I´m getting that same issue, and figured out that it´s caused by a conflict with boostrap 5 css
that is the basis CSS framework from the original project. And I´ve tried to use livewire/wire-elements to exhibit dynamic data in modal screens. Well, watching console I´ve found the piece of code that is "Bugging" the position of the modal, as seen at pics below. In that prints are also, the change I´ve made in the code by the console, and it´s worked, but the question now is, where I may correct this on my code?

@jringeisen @jacovdbergh let's clarify something, items-center will just pull up the modal to the center of the viewport, while the modal is meant to stay at the bottom on mobile and be full-width for various reasons. It does not fix the problem it just makes it visible.
That said, let's outline the problem - chrome and safari put their controls in a bar on top of the viewport in some strange way. It behaves almost like the controls bar is part of the page and is .absolute inset-x-0 bottom-0 :)
Now having that said as well, any ideas how to fix it? I am thinking getting the size of it with JS and account for it somehow. 📐

A proper fix (tested)
Yeah, that seem to be working for me.

Create a utility class in the root CSS file for my tailwind build (I've called it min-h-calc-screen ..but hey!)

@tailwind base;
@tailwind components;
@tailwind utilities;

@layer utilities {
    /** Fix for the VH unit in webkit browsers. See: https://css-tricks.com/the-trick-to-viewport-units-on-mobile/ */
    .min-h-calc-screen {
        min-height: 100vh; /* Fallback for browsers that do not support Custom Properties */
        min-height: calc(var(--vh, 1vh) * 100);
    }
}

Add the function and event listener script into your document (or in your build)

Replace .min-h-screen with your custom utility class (.min-h-calc-screen in my case)

diff --git a/resources/views/vendor/livewire-ui-modal/modal.blade.php b/resources/views/vendor/livewire-ui-modal/modal.blade.php
index e196f0944..df2c1b1f7 100644
--- a/resources/views/vendor/livewire-ui-modal/modal.blade.php
+++ b/resources/views/vendor/livewire-ui-modal/modal.blade.php
@@ -40,7 +40,7 @@
         class="fixed inset-0 z-30 overflow-y-auto"
         style="display: none;"
     >
-

+

             <div
                 x-show="show"
                 x-on:click="closeModalOnClickAway()"

Result

latest Chrome on iOS
Latest Safari on iOS

I was having this same problem in Safari desktop, and this reply fixed it for me. Maybe it's the same issue on mobile browsers?
https://github.com/wire-elements/modal/issues/244#issuecomment-1228054906

I was having this same problem in Safari desktop, and this reply fixed it for me. Maybe it's the same issue on mobile browsers?
#244 (comment)

It is completely different issue.

I had the same issue on iPhone X MAX in Safari and Chrome latest versions 2022/11
The solution from @reppair worked perfect.
Issue is closed, but still an issue.

Could it be possible to have a param so you can choose bottom or top alignment?

I am Also Having the same issue

It seems that the container that is holding the modal has a class that aligns it to the bottom. I tried removing that class but that did not fix it.
Only fix I could find so far (not the best option to be honest) is to access #modal-container in css and give it margin-bottom

Works perfectly, and is much better than having to make the user work to see the modal content.

I saw the issue and I've dig a little bit.
I know, that's not good approach but I've found inside \vendor\wire-elements\modal\resources\views\modal.blade.php on the line 17th next to flex class, the definition of items-end instead of items-center.

I've changed this to items-center and it goes back to the middle spot on the page.
Maybe it should be a root cause, maybe not. If you have any ideas or thoughts, please let me know.

@peroxovy https://github.com/wire-elements/modal/issues/91?notification_referrer_id=NT_kwDOAKSQurMyNDc4MDgzMTk3OjEwNzg0OTU0#issuecomment-1240948925

@reppair, so what about people who want's to have their modal on middle on mobiles? The fixed bottom on mobile devices was imposed from above.

@peroxovy sure, if centering the modal on mobile works for what you are building that's fine.. I just wanted to point you to a description of the actual problem with it.

Yep. @Wraxton and I both tested it. Seems to be fixed on mobile browsers level!

This seems to be working for me.
#modal-container {
    @apply !align-middle;
}

or
#modal-container {
   vertical-align: middle !important;
}

Still having this issue, made a couple of changes to the modal view after publishing and mostly fixed.


Test refactoring(new)

Added Test Classes, refactored Classes, and Added Documentation
Your Changes
Description:
Added Test Classes and Documentation for, and refactored LoansScoreCalculator, LoanResponseConstructor, Updates BasicLoanTest
Type of change (select all that apply):

[ ] New feature (additional functionality separate from existing code)
[X] Refactoring (changing code structure only)
[ ] Breaking change (changing code functionality)
[X] Documentation update (adding more comments)
[ ] Bug fix (non-breaking change that solves an error/issue)
[ ] User Interface change (design changes)
[X] Test update (adding test code)
[ ] Other (please specify):

Testing
Completed and passed the Test Classes
Notes
BackEnd all DONE!
Checklist

[ ] Code is up to date with main branch (no merge conflicts)
[X] Code has been properly tested
[X] Code has been properly documented
[ ] One or two people have reviewed this pull request

Looks good!

Looks good!

Looks good!


Ensure all objects are destroyed before unloading dll in PushNotificationManager

Describe the bug
Currently PushNotificationManager is a static variable inside the SDK and need to make sure that everything is run down correctly even if the dll is unload.
Steps to reproduce the bug
PushNotificationManager.cpp/h
Expected behavior
No response
Screenshots
No response
NuGet package version
No response
Packaging type
No response
Windows version
No response
IDE
No response
Additional context
No response

PR merged.


⚠ Bofrost.at has degraded performance

In f63e535, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1741 ms

Resolved: Bofrost.at performance has improved in f4b0639 after 6 minutes.