Comment tags for all replacement ranges

everywhere we will be replacing variable numbers of columns, wrap that in comments before and after for ease of removal.
Also add a comment with a format-specific tag and create an associated method to generate that format (stubs for now).

I started with this as the tag:
/NaturalKey_ReplacementPoint|NK_SourceSystemID1/
but I might also add the join-string:
/NaturalKey_ReplacementPoint|NK_SourceSystemID1|,/
or
/*NaturalKey_ReplacementPoint|NK_SourceSystemID1|AND */
so I know how to delimit the repetitions of items in the list


regression: emails were not correctly retrieved from conf file

Coverage remained the same at 48.924% when pulling 07b526d487371a52e4f26f52f99a6c707c10a667 on calixteman:regression_fix_email into ef03e60f284d42c2cf4b96f446d1bb3c8e290f9a on mozilla:master.


STORM-1040. SQL support for Storm.

This PR rebases all the changes in the STORM-1040 branch towards the latest master.

+1. Great work @haohui to pull it off  :). Looking forward to get this into master branch. I've ran the tests with java 7 and java 8 all the tests are passing . Travis build failures not relevant to this PR.

+1 Great work

@haohui Thank you for you Great Work :+1:  I want to know which SQL pattern had support ?
such as count , distinct and sum ?

+1. Nice job.

For some reasons I can't reopen this PR now. Created #919 as a duplicate for this PR.
Thanks everybody for the comments. I have addressed them in the latest PR.

Currently the implementation does not support any aggregation (i.e., count, sum, max) yet. It will be added once StormSQL supports windowing.


Set up environment for Unconditional Social Cash Transfer

Target sandbox can be the same, with separate scripts.
Need payments, messaging, registration, registries, IDV.

Blocked on https://github.com/GovStackWorkingGroup/IM_Demo_InstallingScripts/issues/4


Reinstalling OSD node but preserving encrypted OSDs

Bug Report
What happened:
Re-installing the operating system but preserving the lvm-provioned, dmcrypt encrypted, disks will cause the ceph-ansible Play to succeed, but the OSDs will not start and are not visible when querying the monitors.
What you expected to happen:
Ansible-ceph should, in my opinion, add the existing (untouched but encrypted OSDs) to the cluster.
How to reproduce it (minimal and precise):

On a fresh OS (because of a corrupted operating system or a failed system drive (non-OSD)
Run default site.yaml playbook
Play succeeds, but OSD services are not running on OSD node and show down/out in ceph osd tree
If affected OSDs were purged using ceph osd purge, the OSDs are also not added

Environment:

OS (e.g. from /etc/os-release): Ubuntu 16.04.5 LTS (Xenial Xerus)
Kernel (e.g. uname -a): 4.15.0-43-generic
Docker version if applicable (e.g. docker version): N/A
Ansible version (e.g. ansible-playbook --version): 2.5.0 (Python 2.7.15)
ceph-ansible version (e.g. git head or tag or stable branch): v3.1.12
Ceph version (e.g. ceph -v): 12.2.10 (Luminous stable)

This issue only persists when using the dmcrypt variable, so I assume it has something to do with the encryption and the the way the disks are mapped. I cannot seem to find documentation which explains how to re-add encrypted OSDs without formatting them and discarding their data. Could someone advice?
Thanks in advance.

Would backing up /var/lib/ceph/osd/ help?

ceph-volume lvm activate --all did the trick. Thanks to @wido .


Mark pop/clear error stack in der2key_decode_p8

This commit sets the error mark before calling d2i_X509_SIG
and clear it if that function call is successful.
The motivation for this is that if d2i_X509_SIG returns NULL then the
else clause will be entered and d2i_PKCS8_PRIV_KEY_INFO will be
called. If d2i_X509_SIG raised any errors those error will be on the
error stack when d2i_PKCS8_PRIV_KEY_INFO gets called, and even if it
returns successfully those errors will still be on the error stack.
We ran into this issue when upgrading Node.js to 3.0.0-alpha15.
More details can be found in the ref links below.
Refs: https://github.com/nodejs/node/issues/38373
Refs: https://github.com/danbev/learning-libcrypto/blob/master/notes/wrong-tag-issue2.md
Checklist

[x] tests are added or updated

I've tried to reproduce the failing address sanitizer test locally but I've not been able to reproduce these failures.
Has anyone run into something like this before?

@levitte still OK?

ping @levitte for re-review

This pull request is ready to merge

Pushed to master, so closing.
Thanks for the submission and working to resolve the review comments!


Support for Github Actions, dependabot and up-to-date dependencies

Updated all dependencies.
Added support for dependabot to keep dependencies up to date.
Added support Github Actions, which now runs Lint and Tests.
Updated the example in the readme with support for coverage regex. This will allow the coverage badges in gitlab-ci to show the aggregated percentage.

@ggere Can you take a look at this PR, Thanks!
Also, is this project still under development, or are there any updates planned for it?

@ggere Ping

@ggere Any chance of getting merged? I rather not fork the project.

@ggere Any chance you can get this merged? This module is very useful in GitLab. Thanks!


Add Flash attention 2 support for MPT

Flash Attention 2 implementation is not written with explicit attention biasing support (MPT uses alibi). AFAIK only triton flash attention supports that. Same problem happens for AMD (released implementation does not support biasing).
So I guess this will take some time...

Duplicate of #464


chore: update lint rule

Codecov Report

Merging #503 (ca9fd62) into master (3648e8d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #503   +/-   ##
=======================================
  Coverage   90.26%   90.26%
=======================================
  Files          21       21
  Lines         760      760
  Branches      191      191
=======================================
  Hits          686      686
  Misses         72       72
  Partials        2        2

Impacted Files
Coverage Δ

...babel-plugin-transform-jsx-stylesheet/src/index.ts
99.09% <ø> (ø)

...kages/babel-plugin-track-id-generator/src/index.js
91.42% <100.00%> (ø)


Update scalafmt-core to 3.7.9

About this PR
📦 Updates org.scalameta:scalafmt-core from 2.7.5 to 3.7.9 ⚠
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-major, semver-spec-major, commit-count:1

Superseded by #203.


Loading & unloading GDNative EditorPlugin crashes editor

Godot version:
3.2 ~ 3.3.rc.custom_build.6da21f472
OS/device including version:

Ubuntu 20.04
OpenGL ES 3.0 Renderer: Mesa Intel(R) UHD Graphics 620 (KBL GT2)

Issue description:
Unload and reload GDNative EditorPlugin can crashes Godot editor.
The crash occurs if EditorPlugin with reloadable=on, any activity which trigger plugin unloading may leave some sort of invalid references (through pointer) owned by unloaded plugin in Godot editor. If editor access any of these resources, segmentation fault.
https://github.com/godotengine/godot-cpp/issues/535
I also found that the handle pass into gdotot_nativescript_init and godot_nativescript_terminate are different. Since there are not much document about the interface of GDNative, I'm not sure it is ok or not.
Steps to reproduce:

Build the minimal GDNative EditorPlugin
Run Godot Editor
Make sure the reloadable=on in .gdnlib
Enable the plugin from Project Settings (now plugin been loaded)
Switch to another window (unfocus Godot editor, the plugin should be unloaded now)
Switch back to Godot editor. If no crash, Alt-Tab multiple times till it crash (segmentation fault)

The step 6 can replace with exit from Godot editor, it will terminated with segmentation fault.
Minimal reproduction project:
Use cpp/simple project of godot-cpp as base
// MainScreen.hpp
#include <Godot.hpp>
#include <String.hpp>
#include <Control.hpp>
#include <EditorPlugin.hpp>

using namespace godot;

class MainScreen : public EditorPlugin {
    GODOTCLASS(MainScreen, EditorPlugin)

public:
    static void _registermethods();

    bool has_main_screen();

    Ref<Texture> get_plugin_icon();

    String get_plugin_name();
};

```cpp
// MainScreen.cpp
#include <Godot.hpp>
#include <EditorInterface.hpp>

#include "MainScreen.hpp"

using namespace godot;

void MainScreen::_register_methods() {
    register_method("has_main_screen", &MainScreen::has_main_screen);
    register_method("get_plugin_icon", &MainScreen::get_plugin_icon);
    register_method("get_plugin_name", &MainScreen::get_plugin_name);
}

bool MainScreen::has_main_screen()
{
    return true;
}

godot::String MainScreen::get_plugin_name()
{
    return String("Main Screen");
}

Ref<Texture> MainScreen::get_plugin_icon()
{
  return get_editor_interface()->get_base_control()->get_icon("Node", "EditorIcons");
}

extern "C" void GDN_EXPORT godot_gdnative_init(godot_gdnative_init_options *o) {
    godot::Godot::gdnative_init(o);
}

extern "C" void GDN_EXPORT godot_nativescript_init(void *handle) {
    godot::Godot::nativescript_init(handle);

    godot::register_tool_class<MainScreen>();
}

extern "C" void GDN_EXPORT godot_gdnative_terminate(godot_gdnative_terminate_options *o) {
    godot::Godot::gdnative_terminate(o);
}

# mainscreen.gdnlib
[general]

singleton=false
load_once=true
symbol_prefix="godot_"
reloadable=true

[entry]

X11.64="res://bin/libmain_screen.so"

[dependencies]

X11.64=[  ]

# mainscreen.gdns
[gd_resource type="NativeScript" load_steps=2 format=2]

[ext_resource path="res://addons/mainscreen/mainscreen.gdnlib" type="GDNativeLibrary" id=1]

[resource]
class_name = "MainScreen"
library = ExtResource( 1 )

My understanding from #19686 and #32580 is that reloadable must be disabled with a GDNative EditorPlugin or tool script. I just stumbled upon this open issue while investigating a similar issue I was experiencing.
If there is anything that will improve the situation, though, I'm all for it! For instance, a reloadable EditorPlugin could be removed from the scene tree when unloaded and fully initialized when reloaded.

Happen with Godot 4 beta 17 too.
I use Git Plugin https://godotengine.org/asset-library/asset/1581 and when I remove it godot close aromatically without errors


pyimport segmentation fault in virtualenv

Activating virtualenv, then starting Julia. A python package (call it pypkg) is installed in virtualenv from source via pip install -e git+https... and resides in src/ of virtualenv.
using PyCall
@pyimport pypkg

signal (11): Segmentation fault
pthread_join at /lib/x86_64-linux-gnu/libpthread.so.0 (unknown line)
blas_thread_shutdown_ at /usr/lib/libblas.so.3 (unknown line)
__libc_fork at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
_IO_proc_open at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
popen at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 735531670)
PyEval_EvalFrameEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalFrameEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalFrameEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCodeEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCode at /usr/lib/libpython2.7.so (unknown line)
PyImport_ExecCodeModuleEx at /usr/lib/libpython2.7.so (unknown line)
unknown function (ip: 736367470)
unknown function (ip: 736369356)
unknown function (ip: 736189889)
unknown function (ip: 736370911)
PyImport_ImportModuleLevel at /usr/lib/libpython2.7.so (unknown line)
unknown function (ip: 735313135)
PyObject_Call at /usr/lib/libpython2.7.so (unknown line)
PyEval_CallObjectWithKeywords at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalFrameEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCodeEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCode at /usr/lib/libpython2.7.so (unknown line)
PyImport_ExecCodeModuleEx at /usr/lib/libpython2.7.so (unknown line)
unknown function (ip: 736367470)
unknown function (ip: 736369356)
unknown function (ip: 736189759)
unknown function (ip: 736370980)
PyImport_ImportModuleLevel at /usr/lib/libpython2.7.so (unknown line)
unknown function (ip: 735313135)
PyObject_Call at /usr/lib/libpython2.7.so (unknown line)
PyEval_CallObjectWithKeywords at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalFrameEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCodeEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCode at /usr/lib/libpython2.7.so (unknown line)
PyImport_ExecCodeModuleEx at /usr/lib/libpython2.7.so (unknown line)
...
Running Julia Version 0.3.7 (2015-03-23 21:36 UTC) from Ubuntu 12.04 stable repository. NOTE: Just updated Julia version from 0.3.6 today, not sure but that update may have something to do with the error since in the past @pyimport worked for pypkg (although some required packages were updated so I can not be completely sure it was Julia update that broke things down).
Tried also including package pypkg source in the current dir (instead of virtualenv, keeping only prereq. in virtualenv) and doing unshift!(PyCall.PyVector(PyCall.pyimport("sys")..... Still the same segmentation fault. Everything works in a pure python shell from virtualenv.

UPDATE: Interestingly enough, the same steps work fine on another machine with the same Julia, Python, virtualenv, and Ubuntu versions. Quite puzzling: not sure what to start checking on the machine that gives the segmentation fault described above.

a) since you updated to 0.3.7 from 0.3.6, suggest you try on 0.3.6.  even tho you got it 0.3.7 working on a different machine, something might still be broken in your updatecloser process.
if it works on 0.3.6 and fails on 0.3.7 on the same machine, you have somewhere to start doing diffs
b)  since you have seemingly identical versions running and failing.  check all the configuration files and environmental settings that get created by Julia, between the two versions running on the same machine.
c) check all your config and environments between the two machines.
d) run and log as verbose as you can  on working and failing versions of 0.3.7 and look for departure points.  you may actually not have updated cleanly.
e) reinstall 0.3.7 from scratch after as deep of a reboot as you can do.  some queue or flag somewhere may be trashed
f) good luck!
en
-----Original message-----
From: multidis<EMAIL_ADDRESS>To: "stevengj/PyCall.jl"<EMAIL_ADDRESS>Sent: Fri, Mar 27, 2015 16:48:44 PDT
Subject: [PyCall.jl] pyimport segmentation fault in virtualenv (#127)
Activating virtualenv, then starting Julia. A python package (call it pypkg) is installed in virtualenv from source via pip install -e git+https... and resides in src/ of virtualenv.
using PyCall
@pyimport pypkg
signal (11): Segmentation fault
pthread_join at /lib/x86_64-linux-gnu/libpthread.so.0 (unknown line)
blas_thread_shutdown_ at /usr/lib/libblas.so.3 (unknown line)
__libc_fork at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
_IO_proc_open at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
popen at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 735531670)
PyEval_EvalFrameEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalFrameEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalFrameEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCodeEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCode at /usr/lib/libpython2.7.so (unknown line)
PyImport_ExecCodeModuleEx at /usr/lib/libpython2.7.so (unknown line)
unknown function (ip: 736367470)
unknown function (ip: 736369356)
unknown function (ip: 736189889)
unknown function (ip: 736370911)
PyImport_ImportModuleLevel at /usr/lib/libpython2.7.so (unknown line)
unknown function (ip: 735313135)
PyObject_Call at /usr/lib/libpython2.7.so (unknown line)
PyEval_CallObjectWithKeywords at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalFrameEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCodeEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCode at /usr/lib/libpython2.7.so (unknown line)
PyImport_ExecCodeModuleEx at /usr/lib/libpython2.7.so (unknown line)
unknown function (ip: 736367470)
unknown function (ip: 736369356)
unknown function (ip: 736189759)
unknown function (ip: 736370980)
PyImport_ImportModuleLevel at /usr/lib/libpython2.7.so (unknown line)
unknown function (ip: 735313135)
PyObject_Call at /usr/lib/libpython2.7.so (unknown line)
PyEval_CallObjectWithKeywords at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalFrameEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCodeEx at /usr/lib/libpython2.7.so (unknown line)
PyEval_EvalCode at /usr/lib/libpython2.7.so (unknown line)
PyImport_ExecCodeModuleEx at /usr/lib/libpython2.7.so (unknown line)
...
Running Julia Version 0.3.7 (2015-03-23 21:36 UTC) from Ubuntu 12.04 stable repository. NOTE: Just updated Julia version from 0.3.6 today, not sure but that update may have something to do with the error since in the past @pyimport worked for pypkg (although some required packages were updated so I can not be completely sure it was Julia update that broke things down).
Tried also including package pypkg source in the current dir (instead of virtualenv, keeping only prereq. in virtualenv) and doing unshift!(PyCall.PyVector(PyCall.pyimport("sys")..... Still the same segmentation fault. Everything works in a pure python shell from virtualenv.
—
Reply to this email directly or view it on GitHubhttps://github.com/stevengj/PyCall.jl/issues/127.

It starts to look like a virtualenv problem. When I run
using PyCall
@pyimport numpy

everything works NOT from virtualenv (numpy installed as Ubuntu 12.04 package).
Repeating the same from an activated virtualenv that has only python 2.7 and numpy (pip install numpy) returns
signal (11): Segmentation fault
pthread_join at /lib/x86_64-linux-gnu/libpthread.so.0 (unknown line)
blas_thread_shutdown_ at /usr/lib/libblas.so.3 (unknown line)
blas_shutdown at /usr/lib/libblas.so.3 (unknown line)
unknown function (ip: -2103445234)
unknown function (ip: -2126498383)
unknown function (ip: -2126498251)
unknown function (ip: -2119380018)
quit at client.jl:38
jlcall_quit_20841 at  (unknown line)
jl_apply_generic at /usr/bin/../lib/x86_64-linux-gnu/julia/libjulia.so (unknown line)
unknown function (ip: -2119450580)
unknown function (ip: -2119455727)
unknown function (ip: -2119394232)
jl_f_top_eval at /usr/bin/../lib/x86_64-linux-gnu/julia/libjulia.so (unknown line)
eval_user_input at REPL.jl:53
jlcall_eval_user_input_19963 at  (unknown line)
jl_apply_generic at /usr/bin/../lib/x86_64-linux-gnu/julia/libjulia.so (unknown line)
anonymous at task.jl:95
jl_handle_stack_switch at /usr/bin/../lib/x86_64-linux-gnu/julia/libjulia.so (unknown line)
julia_trampoline at /usr/bin/../lib/x86_64-linux-gnu/julia/libjulia.so (unknown line)
unknown function (ip: 4199453)
__libc_start_main at /lib/x86_64-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 4199509)
Segmentation fault (core dumped)
Where does it seem to be on a {python issue} ... {julia issue} scale?

Ended up upgrading to Ubuntu 14.04 and rebuilding everything I could (Python, Julia, BLAS libs etc.). Everything works now from virtualenv; closing the issue as too specific.

sounds you diagnosed it properly:  a mismatch somewhere.  sometimes a clean rebuild on a stable rev is all you can do.
en
nathan kohn
<EMAIL_ADDRESS>CS*mathematics:DATA+DNA+SLA+ASL+#
BU Metropolitan College
617 596 3626 cell/text 7x24
follow me @en_zyme

From: multidis<EMAIL_ADDRESS>Sent: Thursday, April 02, 2015 4:30 PM
To: stevengj/PyCall.jl
Cc: Kohn, Nathan
Subject: Re: [PyCall.jl] pyimport segmentation fault in virtualenv (#127)
Ended up upgrading to Ubuntu 14.04 and rebuilding everything I could (Python, Julia, BLAS libs etc.). Everything works now from virtualenv; closing the issue as too specific.
—
Reply to this email directly or view it on GitHubhttps://github.com/stevengj/PyCall.jl/issues/127#issuecomment-89036470.


[GHSA-jwfr-h6jp-9p2g] Unspecified vulnerability in Jenkins before 1.498,...

Updates

Affected products
References
Source code location
Summary

Comments
Add patch links and source code location related to CVE-2013-0158.

Just to check. You're proposing that there is no fix for the affected product?

Same as：
In the field of patch research, it is necessary to handle cases with multiple branches separately. Although the modified code is mostly similar, different branches have different commit IDs. For some work, determining the version range of vulnerability existence relies on commit IDs. Therefore, for situations where multiple branches are fixed, multiple commit IDs need to be provided for accurate determination. Therefore, even though the modified code is the same, I will still submit new issues for different branches. For example, the current vulnerability 36342d71e29e0620f803a7470ce96c61761648d8 is fixed in some versions above 1.5x, while 757bc8a53956e6fbab267214e6e0896f03c3c262 modifies some versions in the 1.4x range.


chore: unify WaitForCleanup function

What kind of change does this PR introduce?
Refactor
What is the current behavior?
WaitForCleanup function defined for observability and api packages are the same.
What is the new behavior?
Consolidates WaitForCleanup functions into one. Moving it to utilities package.
Additional context

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 15 (0.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 57.91%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/api/cleanup.go
0
1
0.0%

internal/observability/cleanup.go
0
1
0.0%

internal/utilities/context.go
0
13
0.0%

Totals

Change from base Build<PHONE_NUMBER>0:
0.03%

Covered Lines:
9140

Relevant Lines:
15783

💛  - Coveralls


[Feature Request] Separate sorting for replies

Checklist

[x] I am running the latest version. Installing Isso from GitHub from the master branch does not fix my issue
[x] I have checked the troubleshooting guide
[x] I have searched the open issues, but my issue has not already been reported

What is not working?
When using the new sorting system introduced in #1005, replies are sorted the exact same as regular comments. If comments are sorted by newest first, the replies to said comments will also be sorted as such. This can potentially confuse the reader, as the reading order for threads is usually always oldest first. Here's an example of what it looks like now:

Note how the thread starts with the oldest post (the OP), then immediately after that, the newest post (the reply.)
How can one reproduce this issue?
On the client-side configuration, set data-isso-sorting to newest. (This is possibly also visible in upvotes too, but haven't tested yet.) Then, post a comment, and reply to it at least twice.

My personal preference would also be to list child comments chronologically (oldest first), that's how it is done on most platforms I know which only allow for 1 level of nesting.

Hello cal is not working for Invidious Piped Beatbump Hyperpipe

Hello cal is not working for Invidious Piped Beatbump Hyperpipe

You're on the repo for the commenting system, not in the comment section...

Looking at this a second time, I noticed this has the "needs-decision" tag. I don't know the internal discussion, but IMO it's down to two choices:

Make replies always sort by oldest first.

This would be the most sensible option, and IMO my preferred pick. Most people using this are for people like myself, running a blog or some kind of small site that just needs a comment section. With that, and with how the comment system is designed, it's pretty much natural to have replies sort by oldest first.
This will also be the easiest to implement out of the two.

Sort by oldest first by default, but have a separate client config option to sort by newest or most upvotes.

This will allow for hosters using unconventional setups (possibly a reddit clone or forum-like site) to choose the sorting system best fit for their use case.
This will also be the hardest to implement as it involves putting in an extra config value, handling it, and documentation.

If both are to be considered, you can have the first come in on v0.13.1, and the second come in v0.14.

Since no one else has weighed in on this issue so far, I'm making the decision to go with option 1.
@ggtylerr it would be great of you to implement the change in a PR.

Sure, I'll try my hand at an implementation in a few.


An idea for getting rid of the power distribution board.

Guidelines

[x] I have reviewed the guidelines for contributing to this repository.

Is your feature request related to a problem? Please describe.
Sourcing the power distribution board is hard, and this idea reduces the component count and screw count.
Describe the solution you'd like

No power board.
LED ring takes power from +5V and GND (which were connected to the distrib board).
Screen takes power from VCC and GND on the ICSP header. These pins are directly connected to +5V and GND above.
Rotary encoder takes VCC and GND from digital pins 11 and 10, which are set to output HIGH and LOW respectively. I'm hoping the power requirements of the encoder don't exceed the arduino's ability to source and sink current on its digital pins. I've tried it and it seems to work.

The small piece of plastic which holds down the arduino gets in the way of the ICSP header. Fortunately GND and VCC are both on the 3 pins nearer the middle of the board, so shortening that piece by approx 1.5mm should still give OK grip, and not get in the way.
Describe alternatives you've considered
I tried making a 4-way wire to distribute the power without the board, but it way unwieldy and difficult to assemble.
Additional context
I've (only just) assembled a test of this arrangement, and it seems to all work (at least initially). A good first step to support this idea (but not necessarily jump in both feet) is to change the firmware code to set pin 11 high and pin 10 low, both as outputs. This doesn't affect the original configuration, but allows this.
I can submit a (trivial) PR to enable that, if you like the idea.

Hey @tocklime!
Thanks a lot for taking the time to thinking about this, it's amazing!
The reason for the power bus is to minimize soldering as much as possible, keep things tidy and easily extensible.
I am thinking for instance about adding an extra RGB LED. With the current setup, all I have to do is plug power and gnd into the power bus and data into an available pin.
IMO the power bus is the simplest, cleanest and most future-proof solution.
The only issue with the power bus was that it's only available in AliExpress and delivery time was high. Some users raised concerns about this so I ordered in bulk and made them available in Tindie.
Lots of people have already purchased them from there and I haven't heard any other complaints since then.
Assembly of DIY projects can get complex very quickly and that scares off non-experienced users.
I think the availability problem should be solved at this moment AFAIK.
The next version of the hardware IMO will be swapping off-the-shelf components for a custom PCB with everything integrated. A user on Twitter is already working on that and will make it available to the community very soon.
Thoughts?

If you've got plans going in other directions, that's fine. Other than sharing the idea, my motivation for suggesting this is it'd be slightly more convenient for me if I was on stock firmware rather than one I've fiddled with to get the voltages right on 10 and 11, but I can keep my own fork running just fine.
Your right that the flaw with this suggestion is there is no spare high current 5v sources, but with the power bus there's 1. (2 if you count the ICSP).
The increase in soldering here is minimal though - 3 extra pins on the ICSP.
If you're building the no led-ring option this has an even lower part count (no power bus, no LED) - and no extra soldering. (screen on 5v/GND, encoder on D10/11).
I think it has merit as an option, at least until you have something more important to do with pins 10 and 11.

Ha! I just got it working with stock firmware using the second GND pin and D4 as gnd and vcc for the encoder. D4 is high output because it's set as the reset pin for the display, and so is held high while the display is not resetting. Very hacky though, I think I'd rather run a custom firmware than relying on that...
More soldering for that way though - the official instructions only solder 5 of the header pins on that side of the board...

Yeah I absolutely understand you wanting this pulled into the main repo to avoid the headache of keeping the fork in sync. And yeah it has zero impact on the code at the moment.
However it is possible that we start using other pins soon and I'd hate for you to all of the sudden get a new version of the firmware and your device stops working.
I absolutely understand what you've done. I think it's a fantastic idea and I really appreciate your attitude, mindset and approach, I mean it.
But it does add complexity to the build process, it is soldering extra pins and it's not extensible unfortunately. The power buses can be daisy chained, we can easily add another one next to that one.
Since I mean that I really appreciate the work you've put into this but I also think that from my own point of view the power bus is a better solution, I propose that I send you a few power buses free of charge. What do you think about that?

@tocklime Use this code in the Tindie store 62F18DB4

That's a kind offer, thanks, but it doesn't seem to work. I'll DM you on twitter.

The power is just pinheaders on a pcb. Wouldn't be hard to make them instead of ordering them.  I'm just going to bridge all pins on 2 of them and then glue them together. Pin headers are dirt cheap and can be found on Amazon and eBay. Blank pcbs are also pretty cheap
https://cdn.discordapp.com/attachments/399670410565910529/745801151773147136/IMG_20200819_202632.jpg two of those each with all their pins bridged is all the power board is. Also knowing this may make it easier to find in the us

You can totally do that, you can also solder the wires together or buy the part from our Tindie store. Either one of those will work!


Pointnet++ integration

The init.py file of the "modules" package tries to import the pn2_modules file. However, that script does not exist. I would like to ask whether there are implementations of Pointnet++ for ManiSkill2-Learn available?
If there are none available, I would like to ask for some guidance, on how to correctly integrate the Pointnet++ architecture into the ManiSkill2-Learn framework.
I have implemented a Pointnet++ module based on this repository
However, I am not sure how to integrate it correctly into the ManiSkill2-Learn framework so that it correctly parallelizes over multiple GPUs using DDP.
All I have done was to create a thin wrapper around the original implementation from the repository mentioned above. The wrapper inherits from ExtendedModule:
from pointnet2.models.pointnet2_ssg_cls import PointNet2ClassificationSSG

@BACKBONES.register_module(name='PointNet2')
class PointNet2(ExtendedModule):
    def __init__(self, hparams):
        super(PointNet2, self).__init__()
        print("CONSTRUCTING POINTNET++")
        print(hparams)
        self.model = PointNet2SemSegSSG(hparams)

    def forward(self, pointcloud):
        return self.model.forward(pointcloud)

During the construction of the RL agent the pointnet++ backbone is built through the Backbones registry. The underlying network structure (MLPs, ConvMLPs, activation functions etc.) are not built through the registry and they do not inherit from ExtendedModule.
I am not sure if this approach is compatible with how ManiSkill2-Learn's multi-GPU parallelization works.

I believe it's fine to do so. Each GPU will receive its copy of the agent network.


SDBooster Issue

Hi! After upgrading from 4.7.1 to 4.9 we are getting errors for our own SDBooster extension. This error can be replicated with the SDBooster included in AK.
Specifically this line: float* in  = (float*)inBufferListPtr->mBuffers[0].mData + frameOffset;
throws the error: AURemoteIO::IOThread (19): EXC_BAD_ACCESS (code=1, address=0x10)

You'll need to provide more details for me to reproduce the problem. I just obtained the latest code from the AudioKit develop branch, recompiled everything with Xcode 11, and tested both versions of the ExtendingAudioKit project at AudioKit/Developer/macOS (which uses SDBooster), and it runs fine. (iOS version has completely different issues which I'm investigating, likely related to iOS 13.) Can you provide a test project?

I wasn't able to replicate this problem with a new project as we have such an elaborate AK implementation. Most probably it is an iOS 13 issue though.

@themichael123 please close the issue unless you think there is something more that can be done now.

Ok, so we are still seeing this issue. It also affects the SDBooster i.e. not just our customization.
iOS: 13.3.1
Xcode: 11.2
AudioKit: Develop Branch

This is from the logs:
[general] AKBooster.swift:init(:gain:):123:Parameter Tree Failed (AKBooster.swift:init(:gain:):123)

Okay, but if you scroll up I still think this shane's response is valid. Is there a small project that you can make available that demonstrates this? What happened with your new project that did not replicate the problem?

Ok, solved the problem. It was an old header file which I forgot to update. Thanks for your help.


Updated examples with the removal of "jscript" codes

Removed "jscript" codes from Basic example 06 and Technology showcase example 07.

@samigithub2022 : Removed jscript codes from these examples. Please review it accordingly. Thanks !

@vnamdeo - looks good to me. Can we merge it?


Display Ordinal inscriptions alongside Stacks NFTs

To complement the release of https://github.com/hirosystems/stacks-wallet-web/issues/1028

@mica000 copying your designs guidance here since this issue is Ordinals-specific: https://github.com/hirosystems/stacks-wallet-web/issues/1028#issuecomment-1433796449

I'm reopening because the API endpoint on which we're depending here (https://ordapi.xyz/address/${address}) seems very non-performant and I can't get my inscriptions to load. Thankfully these (or similar) in combination should work for us:

We query a generic blockchain API (mempool or blockstream in our case?) in a similar manner to how they're hitting up https://api.blockcypher.com/v1/btc/main/addrs/bc1ptxztnn7yuv2c2hz5p6lxwyccv8z3yzw8ntzv6afpjqqn5qp920ms5vscmv?unspentOnly=true&limit=50 to get unspent transactions for the address and cherrypick the first to appear
Then we pass that tx_hash to https://ordapi.xyz/output/ca84578e541353673a66608d7d95608e48a7cdce7830f638efd0214f538e6842:0 to get the inscription ID
Then we use the inscription ID to query https://ordapi.xyz/inscription/9f165f481c23ba6eab848618bfebed149a43950d96ca053ae53ae7a54d3d3b70i0 for the inscription metadata and https://ordinals.com/content/9f165f481c23ba6eab848618bfebed149a43950d96ca053ae53ae7a54d3d3b70i0 for its content

FYI @rafaelcr


macos-11 agents stuck on "Queued" status for hours

Description
Starting on 9/28/21, my builds in on Azure hosted agents (United States) running macos-11 are stuck in the "Queued" state for hours on end with the only output being:
Acquiring an agent from the cloud:
Request queue position information is unavailable.

I have 5 Azure hosted agents (United States) and my builds have two parallel jobs that run. There are free agents and they are operational, but the pipeline doesn't progress for over an hour.
They do eventually start progressing and finish, but instead of 15 minutes normally, it's over 2 hours.
It also seems that many others are having issues as well as of the past few days:
https://developercommunity.visualstudio.com/t/Build-pipeline-stuck-for-hours/1541300?space=21&entry=problem&sort=newest&moreInfo=true&viewtype=all
https://developercommunity.visualstudio.com/t/Azure-DevOps:-Agent-Microsoft-hosted-MAC/1541643?space=21&entry=problem&sort=newest&moreInfo=true&viewtype=all
https://developercommunity.visualstudio.com/t/macOS-11-VM-Stuck-in-Empty-Queue/1537876?space=21&entry=problem&sort=newest&q=stuck
Virtual environments affected

[ ] Ubuntu 16.04
[ ] Ubuntu 18.04
[ ] Ubuntu 20.04
[ ] macOS 10.15
[X] macOS 11
[ ] Windows Server 2016
[ ] Windows Server 2019
[ ] Windows Server 2022

Image version and build link
Current Image Version: 20210917.1
Is it regression?
No response
Expected behavior
No response
Actual behavior
No response
Repro steps
Seems to only be on macos-11 environments.

Hi @pluck011!
We are aware of the issue and the engineering team is currently working on adding capacity to macOS-11 in Azure DevOps. Sorry for the inconvenience.


Assignee names not getting mapped, instead their JIRA id's are

Assignee's name or email is not showing up even after mapping in users.txt doc. Instead, JIRA id's are being shown. Please look into @Alexander-Hjelm

@Bikrammabzone, you must map the user IDs first. Check the docs :)

Fixed, thanks

Perfect! Closing :)

I have a similair problem, but the email from Jira is getting mapped versus the Azure email/id on the imported items even though I have that user mapped, see below.  After import it shows<EMAIL_ADDRESS>instead of<EMAIL_ADDRESS>bobby.bowden<EMAIL_ADDRESS>

@btbowden please create a new support issuse


Add a building with Af == 0 to reference-case-open

This will let us test that case in future much quicker (currently we have to run the slow masterplan) and find bugs much faster.

@JIMENOFONSECA can you do this please?

done!


Migrate sqlite3

This PR switches out mysql in favor of sqlite3, originally suggested in issue #83. Latest version of sqlite is placed as a submodule under this project so it can be part of the build process. When git cloning or pulling, you may need to also do git submodule update --init so the submodules properly sync.
I'm unsure of whether to keep the UseDatabase config setting. I opted to remove it and have blackbird always use a db -- sqlite is lightweight enough that I didn't see a reason to not always have it enabled. The sqlite CLI shell is also included so you can inspect the blackbird.db file from outside the program.
Leave feedback and comments.

Thank you @greatwolf.
I confirm that I had to run git sumbmodule update --init beforemake. Then it worked like a charm.


Allow users to specify headqa subset

HeadQA has two subsets: "en", "es". The default one is the spanish one.

Can you merge these changes into your branch? https://github.com/EleutherAI/lm-evaluation-harness/tree/thomas/fix_head_qa


Panic in naive_bayes when class not populated

If a class column is present, but is never populated in the training set, it causes a 0 sized matrix to be created, then when calculating the variance in the distribution we get an invalid index operation.
Since it shouldn't hurt if we just skip the iteration for that class which has 0 population, we should just be able to add a len() == 0 check here:  https://github.com/AtheMathmo/rusty-machine/blob/master/rusty-machine/src/learning/naive_bayes.rs#L165
I'm happy to put in a PR, but figured I would wait on that since its a single line change.

Thanks for posting this issue!
Looking to our good friend scikit-learn; from my understanding it seems they only update the classes which have existing labels in the training set.
I agree this is a good approach - and also paves the way to have partial training as in the scikit code. I'd be glad to accept a PR with your suggested change. Later (I think) we should adopt their approach and check the classes defined in the training set then iterate over these.


monitor rate-limiting

Occasionally the application has run into rate limits. These incidents were rare and typically self-resolving. But I've tried to document incidents and then either optimize API calls or tune back crontab frequency. See #16 & #36.

@mattkiefer Can do.
Right now, I've got some changes cooking in the python3 branch (which is at this point just a general dev branch). One of these patches select_unlabeled_msgs() to actually do what it says it does. This should cut back on the API calls quite a bit.


Stats per track

New tests for telemetry + implementation of per track statistics.

Looks great @ashellunts !!! Nice work!
Left a few comments. But, I am not hitting approve as I am not fully familiar with this part of the code and more 👀 would be nice.
Also, the buffer is per layer of simulcast. These stats are going to aggregate across simulcast layer if I understand right. I think it is worth doing per layer per track stats. Not sure if you all have already discussed that level of granularity and decided against it or do it later.

Thank you for review! I did not realise buffers are different per layer. Current implementation only tracks bytes for last reported buffer. I would need to change implementation to handle them correctly.
For upstream, I looked how to differentiate RTCP stats, but looks like there is only 1 mediaTrack through which RTCP is reported and track.ssrc is ssrc of minimal layer.
In general I would prefer to finish per stream stats and merge it so that we have working version. After we can discuss if we want per layer stats.

Merging now, @davidzhao thank you for approve. @frostbyte73 please let me know if you have any other feedback for the PR.

Merging now, @davidzhao thank you for approve. @frostbyte73 please let me know if you have any other feedback for the PR.

Nope, good to go


Disable dev preview on exit

WHY are these changes introduced?
Extracted disable dev preview when dev command finishes

WHAT is this pull request doing?

Disable developer preview when dev commands finishes
Modify ConcurrentOutput component to finish the command (press q or ctrl + c using the AbortController instead of treeKill
dev add a graceful finishing process to close every open external process.

Include a timeout to force the finishing of the command
dev analytics is sent when the command is finished

How to test your changes?

Generate a Remix app with theme app extension, checkout UI extension and one function
Run the dev command with the --verbose flag
Check in the partners dashboard that the dev preview is enabled
Press q or CTRL+C and check debug messages about the different child processes being stopped
Check in the partners dashboard that the dev preview is disabled

Post-release steps

Measuring impact
How do we know this change was effective? Please choose one:

[ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[ ] I've considered possible documentation changes
[ ] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

Quitting dev with q worked as expected, but it didn't work when I tried with CTRL+C:
https://github.com/Shopify/cli/assets/65420305/a4042cf8-07b4-4455-9400-d44ffad1539b
I also have to enter CTRL+C twice to get the process to fully stop.

Quitting dev with q worked as expected, but it didn't work when I tried with CTRL+C:
11-26-r593f-q3y0v.mp4
I also have to enter CTRL+C twice to get the process to fully stop.

Hey @mattnoakes 👋 , thanks for jumping into this!, I will check it again

Quitting dev with q worked as expected, but it didn't work when I tried with CTRL+C:
11-26-r593f-q3y0v.mp4
I also have to enter CTRL+C twice to get the process to fully stop.

Hey @mattnoakes 👋 , thanks for jumping into this!, I will check it again

Hey @mattnoakes!, I have already fixed it. If you have some free time I'd like you could test this again.

Works great!! Can/should this also handle the case when I close my terminal application? Also, I'd wait for another 👍 from someone with a better understanding of the cli code than me 😅

Thanks for the review @mattnoakes and @raluka! I've discussed handling terminal close with @Arkham, and it seems like handling the SIGHUP process doesn't allow for awaiting async processes (probably because when you close a terminal, it terminates all processes and the design most likely doesn't allow for creating hanging additional async processes). @Arkham has also done some experiments with handling node processes and it seems like the behaviour isn't reliable, so we are handling only the best case scenario - that q and ctrl + c work.

@matteodepalo could you take a look at the ConcurrentOutput changes in this PR?


Add Django GraphQLTestClient for testing

Add a Strawberry's GraphQLTestClient class ready to use in the test.
Should provide one for integration

Django

Flask

Asgi

Requests sync -> for e2e test is useful

aiohttp asyn

Description

Types of Changes

[ ] Core
[ ] Bugfix
[x] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release adds a GraphQLTestClient for Django. It hides the http request's details and asserts that there are no errors in the response (you can always disable this behavior by passing asserts_errors=False). This makes it easier to test queries and makes your tests cleaner.
If you are using pytest you can add a fixture in conftest.py
import pytest

from django.test.client import Client

from strawberry.django.test import GraphQLTestClient

@pytest.fixture()
def graphql_client():
    yield GraphQLTestClient(Client())

And use it everywere in your test methods
def test_strawberry(graphql_client):
    query = """query Hi($name: String!) {
        hi(name: $name)
    }
    """

    result = graphql_client.query(query, variables={"name": "Marcotte"})

    assert result.data == {"hi": "Hi Marcotte!"}

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to Etty for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

Hey @BryceBeagle I change a few things... (don't hate me 😅 )
Because speaking with @marcoacierno most of the logic in the previous Django's GraphQLTestClient can be reused, so I moved most of the logic in the BaseGraphQLTestClient and split into simple methods, so every client can override the part of logic that is slightly different:
For Example: in asgi, so Starlette's TestClient the files are not sent in the body, instead of for Django and Flask they are included... for Flask we will have to do the request with content_type="multipart/form-data" instead of format="multipart"...
For asgi, as far I understand,  the response will always be in json format (so just response.json()), instead for the other clients if it's multipart we must decode data = json.loads(response.data.decode()) instead if it's json we can use response.json()...

With this change, I hope that writing the other Client (in another PR :D ) will be more simpler...


fix: update version of eth-ape to >=0.6.0 and <0.7.0

What I did
update requirements for eth-ape for version 0.6

fixes: #
How I did it
How to verify it
Checklist

[x] Passes all linting checks (pre-commit and CI jobs)
[ ] New test cases have been added and are passing
[ ] Documentation has been updated
[x] PR title follows Conventional Commit standard (will be automatically included in the changelog)

I don't believe this should require new tests or documentation updates?


Subcomponents stay open on page chagne

These don't seem to be working for me.
collapseOnSortingChange={true}
collapseOnPageChange={true}
collapseOnDataChange={true}

I've documented my problem on stack overflow, and would appreciate any feedback from the team:
https://stackoverflow.com/questions/59041013/react-table-how-do-i-trigger-a-hide-close-of-a-subcomponent

This is a question concerning v6, which is no longer maintained. Please ask this question on our support forum: https://spectrum.chat/react-table


Experiment with runAnimations utility pattern

This cleans up the orchestration flow a little bit. What we're aiming for will likely not be this but at least we're batching the actual web animations now to play together. Theoretically, in the old situation, if a Sprite.startAnimation() call takes more than a frame the animations may be out of sync. This prevents that.

With this API, how would you handle a situation where you want to start sprite A and sprite B animating at the same time but you want sprite B to animate for 2000ms and sprite A to animate for 1000ms, and once sprite A's animation completes, initiate a 1500ms animation of sprite C.

We don't yet! This is sort of an in between step as it now very clearly highlights what problems we need to solve (your example being one of them). If you run the demo and go from the detail page to the index page you can see a bunch of issues that would need to be resolved by any API we design. More tomorrow...

I've updated this to make what you state possible in a more straightforward way by passing the sprites rather than the changeset to runAnimations.
Also fixed up the motion-study demo to work correctly in all cases w/ interruption. Nicely highlights what kind of "features" we'll need to provide/make more straightforward to use. Main example being a more ergonomic way of filtering/checking if a sprite was interrupted. For this demo I'm manually doing it by checking if there's a boundsDelta https://github.com/cardstack/animations-experiment/pull/23/files#diff-6fc5493e9ed188b40ea534176252b6d029fb8336a21100dbb6802aab16e0f8ffR62
I'm working on an initial version of a "DSL" with the features we discussed. I doubt the end result will look exactly like it, but it does provide an easy way to verify what kind of hooks/config options we'll need and how to provide them from a lower level.


ArraySegment from nullable

I am using Bond.Core.4.0.2, Bond.CSharp.4.0.2 and Bond.Core.NET.3.0.63. I just realized that BOND CSharp compiler does the following type transformation:
BOND:
245: nullable<blob> PeHeader = nothing;

C#:
 [global::Bond.Id(245), global::Bond.Type(typeof(global::Bond.Tag.nullable<System.ArraySegment<byte>>))]
        public System.ArraySegment<byte> PeHeader { get; set; }

Well, I would expect to see something really nullable here and ArraySegment is not such. In case if PeHeader field is missing from the payload, BOND will create an ArraySegment with null array instead of simple null instance. Some downstream components, like Newtonsoft.Json serializer inside OWIN, will fail deserializing such ArraySegements with InvalidOperationException(“The underlying array in null.”).
Is this a known issue? What would be you recommendations?

This got discussed outside of GitHub. Summarizing for here:
The behavior you are seeing is how nullable<blob> and blob = nothing are represented in C#. Changing it now would be a breaking change in the generated code, which is not something we take lightly. In hindsight, could we have come up with a different way of representing these cases, yes.
To make Newtonsoft happy, you'll probably need to assign a new byte[0] to the ArraySegment. Note that in Bond, an empty array is different from a null array. Whether this causes problems will depend on how your components use the blob field.


CVE-2021-3450 blocking all AzCopy traffic due to X509_STRICT in TLS request

Which version of the AzCopy was used?
AzCopy v 10.7 10.8 & 10.9
Which platform are you using? (ex: Windows, Mac, Linux)
Windows Server 2016 & MacOS Mojave
What command did you run?
azcopy login
azcopy copy C:\filename.csv https://**.blob.core.windows.net//CSV/?se=2099-05-16t07%3A16%3A14z&sig=-REDACTED-&sp=rwdlacup&spr=https&srt=sco&ss=bfqt&st=2019-05-15t23%3A16%3A14z&sv=2018-03-28 --log-level ERROR
What problem was encountered?
Put "https://*.blob.core.windows.net//CSV/filename.csv?se=2099-05-16T07%3A16%3A14Z&sig=-REDACTED-&sp=rwdlacup&spr=https&srt=sco&ss=bfqt&st=2019-05-15T23%3A16%3A14Z&sv=2018-03-28&timeout=901": read tcp <IP_ADDRESS>:50912-><IP_ADDRESS>:443: wsarecv: An existing connection was forcibly closed by the remote host.
How can we reproduce the problem in the simplest way?
add IPS for CVE-2021-3450 in firewall
Have you found a mitigation/solution?
Vewing traffic from the WatchGuard Firebox firewall shows all requests originating from AzCopy being blocked with signature_name="SSL OpenSSL X509_V_FLAG_X509_STRICT and signature_algorithms Vulnerabilities (CVE-2021-3450)"
After adding an exception to ignore CVE-2021-3450 AzCopy traffic is able to resume and complete successfully. accessToken.json able to be successfully generated again if needed.
TLS traffic from firewall shows that requests have X509_STRICT mode being applied which according to the latest CVE should be disabled.  Other TLS traffic on our network has not been impacted.

Hi @magauto, are you still experiencing this issue with more recent versions of AzCopy?

Closing this issue due to inactivity. Please open a new issue if you are still experiencing this with latest versions of AzCopy.


Step 6.5 is not clear

[Enter feedback here]
Step 6.5 is not clear. Why another port is used - not the same as before? If a separate web server has to be started on this port - we need a script for this and this has to be described.
For the API call part in the example text you have "hello" endpoint, but in the code "graphcall". This is not clear.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0407c4d4-90ed-8056-293f-195dadcb2ddc
Version Independent ID: 9b6b0534-ded1-c50c-bc85-c6fe25adfc05
Content: Configure authentication in a sample Python web application by using Azure Active Directory B2C
Content Source: articles/active-directory-b2c/configure-authentication-sample-python-web-app.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@smargo171
Thanks for your feedback! We will investigate and update as appropriate.

Thanks! I made a pull request to make the examples more aligned. https://github.com/MicrosoftDocs/azure-docs-pr/pull/211102
CC @kengaderdus


[Bug]: didn't release GPU memory when generating embedding batch by batch

Bug Description
Hi,
I met the OOM issue when building vector index. GPU Memory usage keep increasing while generating embedding per batch.
I found the memory would not be released after generated a batch of embedding.
Could you help to check and fix it? Thanks a lot.
Version
0.9.26
Steps to Reproduce
It takes more than 48GB GPU memory when build index with more than 2048 * 100 nodes using embed model "jinaai/jina-embeddings-v2-base-en".
Relevant Logs/Tracbacks
No response

@rayneznv I've never seen this before. I just tried to replicate this, and the GPU memory held steady at ~12.3GB with a batch size of 40 (the jump to 12GB was because I killed and restarted the embeddings to use a larger batch size)
https://colab.research.google.com/drive/1WC_3AQl2tVx2rciCp7SnjXhu9VPB2iQk?usp=sharing

@rayneznv I've never seen this before. I just tried to replicate this, and the GPU memory held steady at ~12.3GB with a batch size of 40 (the jump to 12GB was because I killed and restarted the embeddings to use a larger batch size)
https://colab.research.google.com/drive/1WC_3AQl2tVx2rciCp7SnjXhu9VPB2iQk?usp=sharing

Hi @logan-markewich,
Thanks for your quick reply.
it works well when using replicates of same text to generate embedding in your sharing code. But if I use texts with different word and length, it will report OOM error.
https://colab.research.google.com/drive/1uBggAidg9t-tuT9yoIHywx3PIWuQJ1El?usp=sharing

I think this is just a batch size/max length issue. Since jina embeddings can take longer sequences than most embedding models, it also uses much more memory.
Models only allocate memory for sequence lengths once they encounter them. So it might read a sequence that's 400 tokens, allocate memory for that, read another that's 500 tokens, and allocates another 100 tokens worth of memory. Basically, it's constant up to the longest sequence the model has seen.
For example, this worked for me (ignore the previous memory bumps, that was me figuring this out lol)

Going to close this out for now -- I suggest adjusting the max length and batch size to fit on your GPU.


Issue 1697 - Create a dashboard which shows live graphs of the current cpu, ram and some jvm stats

Implementation for strongbox/strongbox#1697

Thank you for your contribution, @aosousa ! :)


Treat maximum ERC20 allowance as infinite

If an ERC20 allowance is set to type(uint256).max, it is wasteful and impractical to update storage when part of this allowance is spent.  Instead, this value should be treated as equal to infinity, and left unchanged.
A new helper function will be needed to encapsulate this along with the existing allowance update logic.

While in the majority of cases the gas savings would be desirable, I think the potential for unexpected behavior outweighs the benefit.
For reference, the Solmate ERC20 implementation includes this feature.


AccessibilityWrapper breaks on android

I am using accessibility wrapper and it breaks on android.

Hi, @bbereczky-wecan can you provide me with some information to try to reproduce the issue?
Are you using Expo?
Expo / React Native version?

Hi @leiteszeke
This is how I use it.
import AccessibilityWrapper from 'react-native-accessibility-wrapper';

<AccessibilityWrapper
              elements={[settingsListRef, logoutRef, appVersionRef]}
              style={styles.contentViewStyle}>
              <FlatList
                bounces={false}
                ref={settingsListRef}
                showsVerticalScrollIndicator={false}
                ListHeaderComponent={() => (
                  <ImageConstants.svgImages.settings.SettingsLogo
                    height={normalize(215)}
                    width={normalize(215)}
                    style={styles.settingsLogoStyle}
                  />
                )}
                ListFooterComponent={listFooterComponent}
                data={settingsArray}
                renderItem={renderListItem}
                keyExtractor={(item) => item.id.toString()}
              />
            </AccessibilityWrapper>

react native version:  "react-native": "0.71.1",
I am not using expo.

@leiteszeke  I found the issue and created a pr. Can you check it?

@leiteszeke I found the issue and created a pr. Can you check it?

Sure, thanks.


JSON saving and backend

Assigned to: Michael

This is now done, actual journal nav needs to be worked on.


[config] new tasks in example files

UpdateTitleStats: see https://github.com/PokemonGoF/PokemonGo-Bot/pokemongo_bot/cell_workers/update_title_stats.py for more info
      {
        "type": "UpdateTitleStats",
        "config": {
            "min_interval": 10,
            "stats": ["uptime", "stardust_earned", "xp_earned", "xp_per_hour", "stops_visited"],
            "terminal_log": true,
            "terminal_title": true
        }
      }

SleepSchedule: see https://github.com/PokemonGoF/PokemonGo-Bot/pokemongo_bot/cell_workers/sleep_schedule.py for more info
      {
        "type": "SleepSchedule",
        "config": {
          "time": "22:54",
          "duration":"7:46",
          "time_random_offset": "00:24",
          "duration_random_offset": "00:43"
        }
      }

I just created PR https://github.com/PokemonGoF/PokemonGo-Bot/pull/3467.
If it gets merged before yours, please update the worker title in the config files.
If yours gets merged before mine, I'll take care of it.
👍

will do! thanks.

requires #3467

One challenge we have related to this is that most people just copy and paste the example config into their config and expect the bot to run as expected. So I'd be concerned putting things in here that will have an unexpected effect when run.
For example, we at one point had nickname pokemon in the example config. We got tons of complaints about that really quickly. Perhaps it makes more sense to create a markdown file in the docs folder that contains the task configuration if our intention was to have every task in the config.json

Maybe adding them as disabled tasks #3417

@achretien good point, done

:+1:

This seems fine. We should really figure out how to merge all of these files.
:+1:

+1 to the mergiing the example files with disabled tasks


[RI-357] Override tempest whitelist

Instead of blacklisting the test_minimum_basic_scenario we are providing
a good whitelist.
Issue: RI-357
(cherry picked from commit b861cad7a91b7a8112bd32cb07aa742487c75b3d)
Issue: RI-357

Thank you for submitting a pull request to this project!
Once all check jobs have passed and the pull request has received a
sufficient number of reviews, the repository's gate jobs can be triggered by
adding a comment of :shipit: to this pull request.
When the gate jobs have completed successfully, this pull request will get
merged automatically.


Africa/Casablanca offset incorrect

The offset seems to be incorrect (see below), I believe it should be 3600? Or am I misunderstanding something?

Your time zone data is probably out of date. Morocco's change to permanent UTC+1 was included in the 2018g release of the IANA Time Zone Database. Further changes were made to include fallbacks for Ramadan in 2018h.
With the latest data, I get the expected result:
tz = TZInfo::Timezone.get('Africa/Casablanca')
# => #<TZInfo::DataTimezone: Africa/Casablanca>
tz.current_period.utc_offset
# => 3600

If you are using ZoneinfoDataSource, check to see if there is an updated tzdata package available for your operating system. Otherwise, you can add tzinfo-data version 1.2018.7 or later to your Gemfile and use RubyDataSource.

The 2018h 'main' definition of Africa/Casablanca uses a base offset of UTC+1 throughout the year and observes negative daylight savings during Ramadan. There is a separate 'rearguard' version of the IANA Time Zone Database that changes this around so that a base offset of UTC+0 is used throughout the year and positive daylight savings is observed at all times other than during Ramadan.
If you are using ZoneinfoDataSource and have up to date zoneinfo files built from the 'rearguard' definitions, then utc_offset will return 0, but utc_total_offset will return 3600 for most of the year.
Note also that utc_offset and utc_total_offset have been renamed base_utc_offset and observed_utc_offset respectively in tzinfo version 2.0.0.

I am receiving the following error when looking up the Timezone info for Africa/Casablanca
irb(main):031:0> tz = TZInfo::Timezone.get('Africa/Casablanca')
TZInfo::InvalidTimezoneIdentifier: The first offset indicated by the POSIX-style TZ string did not match the final defined offset in file '/usr/share/zoneinfo/Africa/Casablanca'.


[FlashbackBridge] Add new bridge

Add new bridge for Swedish forum.
https://www.flashback.org/

@dvikan changes since previous code.

You can add commits to a pull request rather than opening a new one.
You seem to have added an additional bridgere my mistake here. [WulffmorgenthalerBridge] Add new bridge

gj!


rot.js missing

The Ananas aus Caracas app is broken, because the rot.js resource is missing:
https://ondras.github.io/rot.js/rot.js

I just copied the minified rot.js locally.  The source changed their repo a lot, having a local copy (with source attribute link, of course) will ensure these problems don't occur again in the future.


Create Execution RFC For E2E Demo

Let's use this ticket to evolve and RFC for how we expect execution will work for the e2e demo.


Is it possible to get text suggestions as I type in VS Code?

There is an option called Show text suggestions as I type in Windows 10:

I am not a native speaker of the English language, so this feature really helps me a lot. I could get suggestions in Word:

I mainly use Visual Studio Code as a Markdown and LaTeX editor, so I wish I can get text suggestions as I type in VS Code!

@septsea the setting you are pointing to are for the Windows OS. VS Code has its own settings (File->Preferences->Settings)
This being said VS Code doesn't have out of the box support for what you are looking for. It has suggestions only for programming languages and words not for human languages. But you might find an extension in VS Code's marketplace. There are at least spell checkers for Markdown.


Using exact version constraint without boundaries are faling the validation

Using the testfile drupal/drupal/CVE-2019-6342.yaml
With content:
title: Critical - Access bypass
link: https://www.drupal.org/sa-core-2019-008
cve: CVE-2019-6342
branches:
    8.7.x:
        time:     2019-07-16 16:24:00
        versions: ['8.7.4']
reference: composer://drupal/drupal

Results in a failing validation:
Run php.exe -d memory_limit=-1 C:\Users\marco\projects\security-advisories\validator.php
Output:
...
+----------------------------------+------------------------------------------------------------+
| File                             | Issues                                                     |
+----------------------------------+------------------------------------------------------------+
| drupal\drupal\CVE-2019-6342.yaml | Version constraint "8.7.4" is not in an acceptable format. |
|                                  | "versions" must have an upper bound for branch "8.7.x".    |
+----------------------------------+------------------------------------------------------------+`
...

IMHO $isAcceptableVersionConstraint should allow this kind of version constraint.
Opinions?

@fabpot would the checkers (server-side and in the symfony binary) work properly with such constraint ? Or would it break existing tooling ?

@Ocramius probably also needs to check how the script that updates roave/SecurityAdvisories would handle these cases

I don't think that SecurityAdvisories can handle exact versions at this point in time, but I can most certainly adapt the code, given some time.

Important to be noted that while single projects do not necessarily support x.y.z.w versioning, 8.7.4 is equivalent to <IP_ADDRESS>.0, which does not include <IP_ADDRESS>.0, for example.

Source code is now open-source (https://github.com/fabpot/local-php-security-checker), so anyone is free to check the logic and provide a fix if needed. Let's close here.


The pods started by mysql operator use default service account

The pods started by the mysql-operator as a part of mysql cluster have service account default. Rather they should have their own dedicated service account created and assigned.

This is a nice observation. I've already opened a PR that allows specifying on the cluster the service account name, #286.
What do you think?

The code wise extension looks good to me, what I also trying to solve with this is making mysql operator related all pods run within an environment that has PSP enabled.
And hence #258 #291 and this issue #274 are baby steps towards it. So having a broader picture of how we can automatically install PSP if needed when doing this could be of help. Not sure if the PSP needed for the mysql cluster pods should be installed by the operator or by the chart itself.

Continuing here from the discussions on #286. The current proposed solution is:

Add --default-cluster-service-account cli option, which defaults to mysql-cluster
If user doesn't specify any serviceAccountName use the one from options

Continuing here from the discussions on #286. The current proposed solution is:

Add --default-cluster-service-account cli option, which defaults to mysql-cluster
If user doesn't specify any serviceAccountName use the one from options

Hi, as we are currently testing out the MySQL operator in our environment and also want to take advantage of specifying the Service Account of the Cluster Pods:
Does this also affect the sidecar Pods (e.g. for taking backups)?
We'd like to use the new "Workload Identity" Feature of GKE, which maps Kubernetes SAs directly to GCP IAM SAs.
For this we ideally need two things:

Have a different service account than default also for the sidecar (as we don't want to map the GCP SA with write access to our GCS bucket to the default SA in the namespace)
Make rclone in the sidecar image use gcloud application default credentials (we have rebuilt the sidecar image for this, which just omits the service account file option so that rclone uses default credentials with which the Pod is running)


how can i use YCSB to test hbase with java

i want to write a program like a web client to test hbase with YCSB,but  how can i use the YCSB in my own java program

YCSB isn't really made to be programmatically driven. You can take a look at the core/src/main/java/com/yahoo/ycsb/Client.java file to see what it invokes when run from the command line.

closing as stale. If you still are trying to get this working, please let us know!


LIIKUNTA-259 | Fix ontologies overlapping datetime picker

Description
Changes z-index so that date time picker isn't rendered below keywords.
Issues
Closes
LIIKUNTA-259:
Screenshots

Having issues running this branch locally.

Something going on with collections:
 graphQLErrors: [
    {
      debugMessage: 'Cannot return null for non-nullable field "Collection.id".',
      message: 'Internal server error',
      extensions: [Object],
      locations: [Array],
      path: [Array]
    }
  ],

They do look strange, but some of that is due to the data being a bit difficult to navigate. The amount of tags is limited to an amount that would look good when the keyword has a one/two word label.

I added a fix to the collection issue you mentioned.


Croatian PKCS11 module path is invalid

Hi, the new version of croatian middleware is no longer by default installed in the eID Middleware folder. It's now installed in the Certilia Middleware folder.
I have made a PR
Can you please merge and release a new version of web-eid?
EDIT: The best solution would be to read the path from the registry (for windows)

Thanks a lot for the fix! The v2.6.0 release is already frozen and going through release testing, but we will do a follow-up v2.6.1 release with this fix as soon as possible.

We have made an unofficial, untested version 2.6.1 release candidate with support for Luxembourg cards and new version of Croatian eID middleware, it is available here.
I included your work by cherry-picking your commit to this PR: https://github.com/web-eid/libelectronic-id/pull/92.
Thanks for your contribution again! Please test v2.6.1 and let us know if it works as expected.

Thank you. I have tested this version and it is working as expected.

Good to hear, thanks for testing!

We have made the second unofficial, untested version 2.6.1 release candidate support for Luxembourg cards, new version of Croatian eID middleware and fixed BelEID v1.7 support, it is available here.
Please test v2.6.1-rc2 and let us know if it works as expected.
Thanks in advance for your help!


Place graphlib imports in the top group?

A minimal code snippet that reproduces the bug:
"""Demonstrate ruff's problem with graphlib."""
import graphlib
import sys

sys.exit(graphlib.CycleError is None)

With ruff check, this produces "I001 [*] Import block is un-sorted or un-formatted".
With ruff check --fix, it reformats this to
"""Demonstrate ruff's problem with graphlib."""
import sys

import graphlib

sys.exit(graphlib.CycleError is None)

However, graphlib is a Python standard library: https://docs.python.org/3/library/graphlib.html
AIUI, it should stay where it originally was.
Ruff version: 0.1.5
Ruff settings:
# Common Ruff configuration.

line-length = 88

# Rule sets from https://beta.ruff.rs/docs/rules/
# We list all the rule sets here, even the ones we do not enable. This way, when
# comparing this list to the page the next time, we know which ones on the page are new
# and which ones are pre-existing but not used by us. To make comparisons with the
# documentation easier, the order here is the same as on the page (instead of the
# standard lexical order).
select = [
    "F",        # pyflakes
    "E", "W",   # pycodestyle
    # "C90",      # mccabe: Unclear value.
    "I",        # isort
    "N",        # pep8-naming
    "D",        # pydocstyle
    "UP",       # pyupgrade
    "YTT",      # flake8-2020
    "ANN",      # flake8-annotations
    "S",        # flake8-bandit
    "BLE",      # flake8-blind-except
    # "FBT",      # flake8-boolean-trap: Unclear value.
    "B",        # flake8-bugbear
    "A",        # flake8-builtins
    # "COM",      # flake8-commas: Handled by Black.
    "C40",      # flake8-comprehensions
    "DTZ",      # flake8-datetimez
    "T10",      # flake8-debugger
    "DJ",       # flake8-django
    # "EM",       # flake8-errmsg: Unclear value.
    "EXE",      # flake8-executable
    "ISC",      # flake8-implicit-str-concat
    "ICN",      # flake8-import-conventions
    "G",        # flake8-logging-format
    # "INP",      # flake8-no-pep420: Unclear whether we want this.
    "PIE",      # flake8-pie
    "T20",      # flake8-print
    "PYI",      # flake8-pyi
    # "PT",       # flake8-pytest-style: We don't use pytest.
    "Q",        # flake8-quotes: We
    "RSE",      # flake8-raise
    "RET",      # flake8-return
    "SLF",      # flake8-self
    "SIM",      # flake8-simplify
    # "TID",      # flake8-tidy-imports: Unclear application.
    # "TCH",      # flake8-type-checking: Unclear value.
    "ARG",      # flake8-unused-arguments
    "PTH",      # flake8-use-pathlib
    "ERA",      # eradicate
    "PD",       # pandas-vet
    "PGH",      # pygrep-hooks
    "PL",       # pylint (small subset)
    "TRY",      # tryceratops
    "NPY",      # numpy
    "RUF",      # ruff
]
# To make it easier to find codes here, they are ordered lexically.
ignore = [
    # We don't normally annotate `self`.
    "ANN101",   # missing-type-self
    # Allow the use of `Any`.
    "ANN401",   # any-type
    # 1 blank line required before class docstring. Incompatible with D211 "No blank
    # lines allowed before class docstring".
    "D203",     # one-blank-line-before-class
    # Multi-line docstring summary should start at the second line. Incompatible with
    # D212 "Multi-line docstring summary should start at the first line".
    "D213",     # multi-line-summary-second-line
    # This is reST formatting that we don't normally use.
    "D407",     # dashed-underline-after-section
    # Allow f-strings with logs. Use only with `INFO` and up.
    "G004",     # logging-f-string
    # Allow variable assignments followed by `return <var>`.
    "RET504",   # unnecessary-assign
    # Allow the use of `assert`.
    "S101",     # assert
    # Allow composed messages (e.g. f-strings) as exception arguments.
    "TRY003",   # raise-vanilla-args
]

[flake8-quotes]
inline-quotes = "single"

[isort]
known-first-party = ["etl", "etl_shared"]

[pylint]
max-args = 8

Can you try setting a target-version in your ruff.toml (https://docs.astral.sh/ruff/settings/#target-version)? graphib was added in Python 3.9, so it's only treated as a standard-library import of your Python version is 3.9 or later.

Can you try setting a target-version in your ruff.toml ... ?

Thanks for the tip. Adding --target-version=py311 to the command line made it behave correctly.
But why is this necessary? Ruff is installed in a venv based on Python 3.11.1:
❯ python --version
Python 3.11.1

We don't use the virtualenv to determine the minimum version for a few reasons though it's been discussed in the past. I guess the most succinct explanation would be: just because you're using Python 3.11 doesn't mean your project doesn't need to support lower versions than that. So our default is the lowest supported Python version, which is Python 3.8.
If you set requires-python in your pyproject.toml (which is a Python standard, not a custom Ruff setting), we'll also respect that.

Thanks, that makes sense.


Fixes hallotoolbar misplacement within StreamField StructBlock

Fixes #1511 which now also considers if the element is a part of a struct-block. The specific classname .stream-field pushes the HalloToolbar up for a negative margin offset. Whereas in a StructBlock it is sufficient to apply the the regular margin offset which comes along with .hallotoolbar

[x] Fixed it for a StructBlock within a StreamField.
[x] Validated it is still working within a StreamBlock
[x] Validated the direct RichTextField usage on a Page.
[x] Do some cross-browser testing.

I am not completely sure if there are additional scenarios to look in to?
I'd also rather have a deep look into what's happening with .stream-field and .hallotoolbar in general so I'm not completely happy with the solution. On the other hand, this is probably good enough with #2409 in mind.
Also I wanted to attach a screenshot but it seems GitHub uses S3 storage for that.
Update:
What it looks like:

Thanks for reviewing @BertrandBordage! I have updated the PR with your suggestions.

Thanks @jjanssen! I tested on different scenarii, with and without streamfield, using different depths/levels, and it works flawlessly.
Merging it!

Pefect!


Fix issue introduced in v3 with QB Cache

If CI_DB_query_builder qb_caching is TRUE and a query has been executed prior to the session save, the parameters can bleed into the session saving to DB.
Ideally, developers will use stop_cache() and flush_cache() but this issue did not occur in v2 and was not noted in upgrade instructions.
Only potential improvement to the pull request may be to store the cached query, flush, then reapply, in case the session write is called before the end of the page.

But here's the thing ... while an easy flush_cache() call may prevent sessions from breaking, it may in fact cause you more trouble - when the session breaks, you immediately know there's something wrong, and that's not necessarily the case if you silently discard the cache.
So, while I agree that there's a problem, I'm not sure if there's an appropriate solution for it.

Yeah - it's not ideal, but as the errors only occurred since the migration to CI v3, it should be mentioned in the upgrade docs or some fix pushed to the release

Since the constructor of the session database driver throws an exception if $this->_db_cache_on, wouldn't it make sense for the driver to throw an exception if qb_caching is true, as well? That would probably require a check every time the driver tries to access the database, though, and I'm not really sure it's worth it just to remind someone not to call the session while they're using QB caching.

@adam-bell CI2 did utilize the query builder, so it's not correct to say that this is a breaking change in CI3. It may be when it affected your application, but it's not at all something new ...
Except of course that it is now a completely different Session library, which is very thoroughly explained in the upgrade instructions. We can't document every tiny detail about it.
Either way, I don't think this particular change is appropriate, so I'm closing the PR.
@mwhitneysdsu Such check would be useless, because this "cache" is started at runtime.

@adam-bell thanks for your help.  I'll be trying this code snippet on my side and will report to you if the behavior persists


AsciiDoc converter

I don't think it's popular, but it'd be great to have AsciiDoc converter supported by Holocron.

There's no elegant way to implement AsciiDoc converter, since the last one isn't available on PyPI and there no API. Looks like the only way we have is to implement it via subprocess call to external binary. It's no good, and such complex solution shouldn't be distributed within Holocron distribution. Any attempt to resolve this issue should be done in external extension.