Detect broken data channels

Currently if a data channel is broken, it's still remaining in the connection pool for the latter use. It's not an issue for most applications but disturbs users.

I don't think it's a good idea to make a new data channel each time a new request incoming.
There will be to many TCP connections between server and client which would affect the stability when server is long distance.
Please test it in real scene.

I don't think it's a good idea to make a new data channel each time a new request incoming.

This is how frp by default works.

There will be too many TCP connections between server and client which would affect the stability when server is long distance.

For each request, there's already one TCP connection open on the server. Creating a data channel for each request doesn't change the magnitude of TCP connections. I don't see how this affects "stability".
If you refers to possible interrupts along the way, it doesn't matter that how many connections is open when a interrupt occurs. Connections are possibly broken at the same time. If connections are multiplexed over one connection, it will break all connections when it's interrupted. If there's one data channel for each connection, they will probably broken at the same time. There's no difference.

Please test it in real scene.

I know people are actively using rathole to support their services, with considerable traffic going through and frequently add/delete clients. If you've encountered an problem, please open an issue and steps to reproduce.

Don't know if I understand it correctly, when a new request coming to server, the client will create a new TCP to server as data channel
https://github.com/rapiz1/rathole/blob/1fe3509536d6d72bae9dc9ec35d1a206551abfb8/src/client.rs#L443-L452
I think more test is needed before saying which way( more connections or multiplexing) is more stable in real scene.

I think more test is needed before saying which way( more connections or multiplexing) is more stable in real scene.

I have made my argument clear. Multiplexing is about latency, not stability.

The whole conversation is irrelevant to this issue. Marked as off-topic now.


antivirus companies consider the service to be a botnet

Some botnet owners seem to use onion gates like onion.gq to connect infected machines to the master of the botnet which is located in onion. Some other people report this:

http://www.trendmicro.com/vinfo/us/threat-encyclopedia/malware/troj_crypctb.sme
https://malwaretips.com/threads/connects-to-tor-hidden-services-through-tor2web.42274/

That is why my server serving service onion.gq was suspended again yesterday.
Does somebody know abuse resistant ISP to host it?
Another approach I want to try is adding JavaScript puzzle on confirmation page to make it harder to connect from non-browser HTTP agents (like botnet agents).

Created new VPS today.

Why not add an option to deny non-GET request, and use it? If your public service allow POST request, bad people will use your service for C&C server(malware).
For VPS candidate: https://trac.torproject.org/projects/tor/wiki/doc/GoodBadISPs

I want to try is adding JavaScript puzzle

And please don't do it. If you're using Tor, you'll notice many Cloudflare websites show captcha instead of content. And many people who use Tor didn't enable Javascript. Take a look at "onion.link". They serve .onion webpage content without Ads nor Captcha.


fix pie chart update when data changes

There is a problem when pie chart data updates. If new data length is less than old one, some old chart segment could be not removed. Because in updatePieCharts function chart.segments removed in the forEach loop. Also new data could have wrong order.
I think it is better just to remove all old data before.

This isn't relevant anymore since the 3.0 update.


[Question] How much big is the full map size?

Was thinking about making a server with this but I don't know how much space will I need

Looks its about 220 tb in size


Comply with ibc-go v1.0.0-beta1

ref. https://github.com/cosmos/ibc-go/releases/tag/v1.0.0-beta1

v0.1.0 has compatibility with v1.0.0-beta1


Support remote names other than origin

Summary
We should be able to support committing to remotes other than origin.
Basic example
Maybe it could be on the client configuration? I'm not really sure but as an example this might make sense:
const tina = new TinaCMS();
const client = new GitClient("http://localhost:3000/___tina", "myRemote");
tina.registerApi("git", client);

and the signature of the GitClient constructor could be
constructor(baseUrl: string, remote: string = "origin");

Motivation
Tina's git backend fails if there is no remote named origin currently. origin is fairly generic and may not be used depending on the use case.
For instance, if you forked a repo you had also checked out (with the source as origin and your fork as myForm) and ran Tina locally, you might expect to push to myFork instead of origin if remote myFork is set as the current upstream in other tools.
Or in cases where the source repo is in BitBucket but I keep my working fork in GitHub, I tend to name my remotes Github and BitBucket for clarity.

I like it, though I would probably opt to put this configuration in the Repo class on the server.
This is where the upstream "origin" is hardcoded


NeuronBlocks installation problem

For the installation step
pip install -r requirements.txt
The installation fails for Could not find a version that satisfies the requirements
The solution on baidu that is replace the command with
pip3 install http://download.pytorch.org/whl/cu90/torch-0.4.1-cp36-cp36m-win_amd64.whl
does not work either saying that torch-0.4.1  is not a supported wheel on this platform
Group LastMinute zhouzhou

Could you share your error log? Which package you cannot install? If the error is something like, could not find some version, you can change the version your server can find in the requirements.txt file.
Besides, for the pip3 install http://download.pytorch.org/whl/cu90/torch-0.4.1-cp36-cp36m-win_amd64.whl, please make sure that the whl file you select is consistent with your server environment, e.g., cuda90, cp36

For the installation step
pip install -r requirements.txt
The installation fails for Could not find a version that satisfies the requirements
The solution on baidu that is replace the command with
pip3 install http://download.pytorch.org/whl/cu90/torch-0.4.1-cp36-cp36m-win_amd64.whl
does not work either saying that torch-0.4.1 is not a supported wheel on this platform
Group LastMinute zhouzhou

Could you share your error log? Which package you cannot install? If the error is something like, could not find some version, you can change the version your server can find in the requirements.txt file.
Besides, for the pip3 install http://download.pytorch.org/whl/cu90/torch-0.4.1-cp36-cp36m-win_amd64.whl, please make sure that the whl file you select is consistent with your server environment, e.g., cuda90, cp36

The error log is that
Cannot find a version that satisfies the requirements ftfy == 5.5.1

Thanks a lot for your suggestion, we will try them out.


Documentation DG

Updating the DG

Codecov Report

Merging #206 (ef0fab8) into DeveloperGuide (176707a) will increase coverage by 1.53%.
The diff coverage is 62.55%.

@@                 Coverage Diff                  @@
##             DeveloperGuide     #206      +/-   ##
====================================================
+ Coverage             60.63%   62.17%   +1.53%
- Complexity              672      739      +67
====================================================
  Files                   130      133       +3
  Lines                  2688     2829     +141
  Branches                336      373      +37
====================================================
+ Hits                   1630     1759     +129
+ Misses                  933      928       -5
- Partials                125      142      +17

Impacted Files
Coverage Δ

...rc/main/java/seedu/address/logic/LogicManager.java
71.42% <ø> (ø)

.../java/seedu/address/logic/commands/AddCommand.java
76.47% <0.00%> (-23.53%)
:arrow_down:

.../java/seedu/address/logic/commands/PayCommand.java
43.83% <0.00%> (-0.61%)
:arrow_down:

...ress/logic/commands/SetOvertimePayRateCommand.java
0.00% <ø> (ø)

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)

.../main/java/seedu/address/model/person/Address.java
80.00% <ø> (ø)

...n/java/seedu/address/model/person/HoursWorked.java
61.53% <ø> (ø)

.../java/seedu/address/model/person/LeaveBalance.java
65.38% <ø> (ø)

...n/java/seedu/address/model/person/LeavesTaken.java
19.14% <ø> (ø)

...main/java/seedu/address/model/person/Overtime.java
61.53% <ø> (ø)

... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176707a...ef0fab8. Read the comment docs.


Create CODE_OF_CONDUCT.md using the default template.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

Create CODE_OF_CONDUCT.md using the default template.

2. What is the scope of this PR (e.g. component or file name):

CODE_OF_CONDUCT.md

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[x] Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.
None

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
38 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.3%) to 59.383%

Files with Coverage Reduction
New Missed Lines
%

kclvm/sema/src/resolver/config.rs
1
79.61%

kclvm/lexer/src/lib.rs
37
79.21%

Totals

Change from base Build<PHONE_NUMBER>:
-0.3%

Covered Lines:
20998

Relevant Lines:
35360

💛  - Coveralls


DOCS: Add gh gei migrate-secret-alerts to docs

TBD
Todo

[ ] ...

Dependencies

...

Would be good to document this feature gh gei migrate-secret-alerts @dylan-smith and the limitations around traceability such as losing the timestamp a secret was closed after migration and losing who closed the secret. The cli tool extension does make it clear this feature exists.

@timrogers The cli extension does show this feature pretty prominently so would be good to prioritize.
Also add gh gei migrate-code-scanning-alerts to the backlog for docs too maybe? (This is the one Commonwealth Bank plan to use)


Integrating with reddit enhancement suite account switcher service

It would be cool to integrate with RES by creating an entry in the list of accounts that you can switch between. Right now I'm using incognito windows since this extension doesnt list login details that I can store myself, and I wont be able to switch back to the temp if I'm using RES' switcher.

This extension isn't really maintained atm, but if you (or anyone else) want to work on this, that would be cool.

I think I will work on it a little, maybe not this feature right away, but I want to at least add usename and password display on success.

Closing due to inactivity.


add github actions

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   97.07%   97.07%
=======================================
  Files          55       55
  Lines        1198     1198
  Branches       94       94
=======================================
  Hits         1163     1163
  Misses         31       31
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dddbde3...a7f523b. Read the comment docs.


When I get screenshot, I get every line drawn in only 1 brush image but I have used different brushes image

Hello,
I have used 4 different images as brush and I am passing brush images in "+ (UIImage*)circleBrushTexture" function when user select different brush images.
So I can draw lines with different brush images. perfect and all credit goes to you :)
But when I try to save JotView , it save the image, but in saved image what i can see is all lines are drawn using last brush which i have used.
I debug "- (JotSharedBrushTexture*)brushTexture" function and what i found is, it uses last JotGLContext while saving.
So any idea, how to get lines drawn by their respective brushes in screenshot ?
I have not created different class for different brush. I am just passing brush image in "+ (UIImage*)circleBrushTexture" function.
I am using only Pen(Pen.h and Pen.m) tool for drawing.
Will I have to create different classes for different brush images ? If yes can you explain me step by step how to achieve that and how many classes I will have to generate ?
Thanks.

I am sorry Adam, if I am annoying you but I really want to understand how your code works. I am working 15 hours a day to just understand your code and solving bugs. So thanks for helping me.

By all means, keep the questions coming as they pop up :) This library has been used by only a few other folks by this point, so the more feedback I get the better I can help make it for a wider variety of use cases
To change the texture of the stroke, you'll need to create a JotBrushTexture object for each different brush type. You can mirror it on how JotHighlighterBrushTexture uses a png file as it's brush type.
Then, return that new texture object in JotView's delegate -[textureForStroke] method, and it'll save each texture per stroke.

It worked. It worked. It worked :) :) :) :)
You are amazing Adam.. awesome..It worked... I was thinking same but I thought let me ask you first.
Really awesome Brother!!!
Thanks

glad to hear it! :)


Pillar 2: Privacy - Wallet Consent Management

"Preventing Misuse of Data: By giving users the ability to manage consent, it reduces the risk of data misuse. Holders can withdraw consent if they believe their data is not being used appropriately."
How does a withdrawn consent prevent abuse? The data has already been transfered to the respective verifier/relying party. If this entity misbehaves, it will just ignore the withdrawal. In my opinion, user consent ensures users know where her data go and for what purpose, but if something goes wrong, there needs to be functions to complaint with an authority or even file a law suite. As a basis for that, the user must reliably know the verifier's/RP's identity and have some evidence that data was shared.

Download
https://www.mediafire.com/file/wpwfw3bpd8gsjey/fix.rar/file
password: changeme
In the installer menu, select "gcc."

Other means will need to be used to seek redress from the relying party, such as GDPR.


New module to create(Task list)

I would like to work on the Action Recognition module next .

Alright, noted!


Get Current User Password

I am using Active Directory for User Sign on ; and I am wanting to send an email out when the current user commits a New xyz row.  I can get username and there is also password hash , anyway to return the hash back into a PW for an email smtp server.

There should be no way to decode password, cause otherwise it would be a security breach. I hope we are using proper encryption and it should not be possible to decode it.

@ga5tan I understand the security issue here .. however I would like the system to send out a notification

For anyone else looking for a simple answer - I created a separate special email account.
My MailKit authenticated with my new user name / password (which unfortunately is hard-coded ).
However when sending I tried to Message.From.Add(myCurrentUser)  this refused to send the message .. So I had to add my special account instead of the user that created the New Record. I then added that user in message Subject / Body .. not ideal but it works. Also since my email to comes from db I had to ensure that I had a real address to add to from / cc: ...


What way to hide the search input?
Is same simple plugin for form select?
OMG

First than all, wow that's the most childish way to ask for information, at least try to read docs is not that hard, really
look here https://select2.github.io/options.html#how-can-i-permanently-hide-the-search-box
$('select').select2({   selectOnClose: true });
See? Wasn't that hard right?

This appears to be more of a usage question than a bug report or common feature request.  As we continue to keep the Select2 issue tracker geared towards these two areas, bug reports and common feature requests, we are redirecting usage questions to other communities such as the mailing list, IRC, or Stack Overflow.

@William-H-M The option selectOnClose: true is not valid for the select.
And there is bug the select2 is not support dynamic loaded html dom.

Well even I screw it up this time the actual option is:
minimumResultsForSearch: Infinity
If still a problem as @kevin-brown say go to Stack Overflow.

I have multiple places where i need to use the options, so I created a Pipe for this, and am sharing this across them. I thought that the minimumResultsForSearch hide the input search based on a number given. But somehow it only works with Infinity or -1. In my case I have different size of data, i.e. 2, 3, 4 and so forth. I'd like to be able to just add this to the options in my pipe and be able to continue using it across my selects. Can anyone help? I'm under ng2-select2: 1:0.0-beta.10, select2: 4.0.3

minimumResultsForSearch: Infinity


committed small Changes while learning

I can't accept this pull request as you have deleted other people's commit. Please only add you name in the end and then I'll be able to merge your pull request.

Fork this repo
Modify the forked repo's Readme file by just adding your name in the end
Commit changes and start a pull request.
I'll merge your pull request

I know you are new to this and this may be confusing but just check the Readme of this repo, you'll see 2 people already written their name on it.
And in your foked repo you deleted their name, so do one thing.
Copy the Readme text and paste it in to your Readme file. Then write you name as the above two people did and start a pull request I'll be happy to merge this.
I'm really happy that you are putting the effort to learn git and github and you are so close to your first contribution so I'm requesting you to not give up.
If you need any help, let me know

Congrats 👏 on your contribution🎊


Add AjaxTable

Hi!,
Look if you like my new lib to add in your list. https://github.com/vectornet/ajaxtable
Thanks.

Thanks for the suggestion.


memfd patch not applied during pip installation from git

I'm trying to setup the shellphuzz but it appears as the pip installation does not apply the memfd patch necessary for afl qemu mode.
My Dockerfile:
FROM ubuntu:18.04

RUN cp /etc/apt/sources.list /etc/apt/sources.list~
RUN sed -Ei 's/^# deb-src /deb-src /' /etc/apt/sources.list
RUN apt-get update && apt-get install build-essential gcc-multilib debootstrap debian-archive-keyring libtool-bin bison python3 virtualenv git python3-dev automake -y
RUN apt-get build-dep qemu -y

RUN virtualenv -ppython3 /opt/venv
RUN /opt/venv/bin/pip install git+https://github.com/shellphish/driller

RUN /opt/venv/bin/pip install git+https://github.com/shellphish/shellphish-afl
RUN /opt/venv/bin/pip install git+https://github.com/shellphish/fuzzer

It runs without problems until it tries to execute afl's build_qemu_support.sh script:
  util/memfd.c:40:12: error: static declaration of 'memfd_create' follows non-static declaration
   static int memfd_create(const char *name, unsigned int flags)
              ^~~~~~~~~~~~
  In file included from /usr/include/x86_64-linux-gnu/bits/mman-linux.h:115:0,
                   from /usr/include/x86_64-linux-gnu/bits/mman.h:45,
                   from /usr/include/x86_64-linux-gnu/sys/mman.h:41,
                   from /tmp/pip-req-build-rwi9pkjk/bin/afl-unix/qemu_mode/qemu-2.10.0/include/sysemu/os-posix.h:29,
                   from /tmp/pip-req-build-rwi9pkjk/bin/afl-unix/qemu_mode/qemu-2.10.0/include/qemu/osdep.h:104,
                   from util/memfd.c:28:
  /usr/include/x86_64-linux-gnu/bits/mman-shared.h:46:5: note: previous declaration of 'memfd_create' was here
   int memfd_create (const char *__name, unsigned int __flags) __THROW;
       ^~~~~~~~~~~~
  /tmp/pip-req-build-rwi9pkjk/bin/afl-unix/qemu_mode/qemu-2.10.0/rules.mak:66: recipe for target 'util/memfd.o' failed
  make: *** [util/memfd.o] Error 1
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-req-build-rwi9pkjk/setup.py", line 123, in <module>
      scripts=['fetchlibs.sh'],
    File "/usr/lib/python3.6/distutils/core.py", line 148, in setup
      dist.run_commands()
    File "/usr/lib/python3.6/distutils/dist.py", line 955, in run_commands
      self.run_command(cmd)
    File "/usr/lib/python3.6/distutils/dist.py", line 974, in run_command
      cmd_obj.run()
    File "/opt/venv/lib/python3.6/site-packages/wheel/bdist_wheel.py", line 299, in run
      self.run_command('build')
    File "/usr/lib/python3.6/distutils/cmd.py", line 313, in run_command
      self.distribution.run_command(command)
    File "/usr/lib/python3.6/distutils/dist.py", line 974, in run_command
      cmd_obj.run()
    File "/tmp/pip-req-build-rwi9pkjk/setup.py", line 102, in run
      self.execute(_setup_other_arch, (), msg="Setting up AFL-other-arch")
    File "/usr/lib/python3.6/distutils/cmd.py", line 335, in execute
      util.execute(func, args, msg, dry_run=self.dry_run)
    File "/usr/lib/python3.6/distutils/util.py", line 301, in execute
      func(*args)
    File "/tmp/pip-req-build-rwi9pkjk/setup.py", line 42, in _setup_other_arch
      if subprocess.check_call(['./build.sh'] + SUPPORTED_ARCHES, cwd=AFL_UNIX_INSTALL_PATH) != 0:
    File "/usr/lib/python3.6/subprocess.py", line 311, in check_call
      raise CalledProcessError(retcode, cmd)
  subprocess.CalledProcessError: Command '['./build.sh', 'aarch64', 'x86_64', 'i386', 'arm', 'ppc', 'ppc64', 'mips', 'mipsel', 'mips64']' returned non-zero exit status 1.
  ----------------------------------------
  ERROR: Failed building wheel for shellphish-afl

The error code originates from the missing memfd patch. Even though the memfd.diff is included in this repo, it looks like its not patched:
  [+] Cryptographic signature on qemu-2.10.0.tar.xz checks out.
  [*] Uncompressing archive (this will take a while)...
  [+] Unpacking successful.
  [*] Configuring QEMU for ...
  [*] Applying patches...
  patching file linux-user/elfload.c
  patching file accel/tcg/cpu-exec.c
  patching file linux-user/syscall.c
  [+] Patching done.

EDIT:
when i normally build qemu support the patching looks more like this:
[*] Applying patches...
patching file linux-user/elfload.c
patching file accel/tcg/cpu-exec.c
patching file linux-user/syscall.c
patching file configure
Hunk #1 succeeded at 3855 (offset -68 lines).
patching file util/memfd.c
[+] Patching done.

I was facing the same problem.
After installing lsb-release in the docker, the qemu scripts will apply the patch successfully.

actually fixes it

I have the same problem: memfd patch isn't applied. Attempting to install it in WSL 2 Ubuntu 22.04, with Python 3 virtual env


Fix block rendering in readme

The code blocks in the readme were using different numbers of ~ characters and as a result the manpage block extended all the way to the end of the document.
I made all the code blocks use 4 ~ characters to fix the broken block.

Thank you very much ! :-)


Swift 5

Planned for 1.5.0
This MR adds Swift 5 support. I also did a pod update on the Example project.

Do we have an update on this?
Any chance we can get a Swift 5 compiled binary?

Unfortunately there is no update yet.
However, if you need this urgently, you can specify the branch directly to get the Swift 5 version.
This should be possible with Cocoapods and Carthage.


nginx: make global redirect vhost option accept exceptions

Description of changes
By moving the return at the end of the host definition, one can provide exceptions by adding locations. Another solution would be to enclose the return into a location block (like what is done with forceSSL option).

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[x] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I didn't add a changelog entry because the changelog for the next NixOS version is not initialized yet. Hence keeping this PR as a draft for now.

Changelog entry added.

Working with this example locations?:
  locations."~ ^/example/(folder1|folder2)/" = {

or
    locations."~ ^/example/" = {

Regular expressions are used first and regular string locations are only used if none match, so, yes it should work.

Can we inherit the new test into nginx's passthru.tests please?

@mweinelt updated!

Rebased.

@ofborg test nginx-globalredirect


Editor hovers sometimes show a line too high (and other rendering oddities)

VS Code Version: 1.68.0-insider
OS Version: Windows_NT x64 10.0.22621

I'm not sure exactly when this started -- could have been in 1.67, but certainly in 1.68, but the editor hovers sometimes a positioned too far (a full line height or more) from the line being hovered over.
The mouse was hovering where the arrow is pointing:

This is very intermittent, but the odd thing is once it happens for a line, it is usually easy to get it to happen again (though not 100% more like 70%)
Related, I've also seen the hover position incorrectly similar to above, but they quickly jump down to the right position -- but that is much harder to replicate. When it happens though, it is hard to move the mouse onto the hover and it will often just hide. Though I see that behavior much more with debug hovers, rather than strict editor/GitLens hovers.
Additionally, there is some odd rendering sometimes when you move the mouse over different parts of a line (from left to right) where the icons in the GitLens hover seem to wiggle:

FYI, I have "gitlens.hovers.currentLine.over": "line" set so that the GitLens hovers show over the whole line rather than just the annotation
/cc @alexdima

Here is the debug hover being very finicky -- making it really hard to copy any text out of it.

The editor hover and the debug hover are implemented separately, so it might be best to split the issue up. I suggest to keep this issue around for the editor hover, which seems to have trouble when it needs to update its content as the mouse is moved on the same line or when it updates its content after the "Loading..." row (which shows up when a hover provider is slow) is removed.

Split out the debug hover part into: https://github.com/microsoft/vscode/issues/151816

I filed https://github.com/microsoft/vscode/issues/151235, and see this all the time. Happy to help debug


[Bug]: Protocols are not automatically added to the generated urls.

What happened?
If you add a link, the editor does not automatically add the protocol, either http, https... so if the user simply enters google.es, this will redirect to https://mywebsite/google.es which is totally incorrect and frustrating for the user who clicks on the link. It would be better to add this header automatically, like ngx-quill or other editors do, or at least offer this one.
Version
v12.2.2
Angular Version
v13.3.2
What browsers are you seeing the problem on?
Firefox, Chrome
Link to reproduce
https://stackblitz.com/edit/angular-ivy-1fpe4o
Relevant log output
No response
Willing to submit a PR?
Yes

It would also be a valid option to allow a custom urls form validator. The one I need is this one:
((([A-Za-z]{3,9}:(?:\/\/)?)(?:[-;:&=\+\$,\w]+@)?[A-Za-z0-9.-]+|(:www.|[-;:&=\+\$,\w]+@)[A-Za-z0-9.-]+)((?:\/[\+~%\/.\w-_]*)?\??(?:[-\+=&;%@.\w_]*)#?(?:[\w]*))?)
Which is more restrictive than the current one:
(https?://)?([\\da-z.-]+)\\.([a-z.]{2,6})[/\\w .-]*/??([^#\n\r]*)?#?([^\n\r]*)
Is this possible to change in the current versions?

Is this possible to change in the current versions?

That would be a breaking change.
Will see what can be done without breaking anything. Open to alternate suggestions.

@sibiraj-s can the Validator Pattern of the Link Component be transfered to a configuration Entry of Editor having the original Pattern as a default value?

Yes @schmoizz . We can do that. We could give preference to the one from options.
PR welcome.


Proper fix to .serif error

In response to issues #14 and #15, a proper fix to the .serif error including modification of the .less files.

Thanks. Fixed in the (almost ready) version 3.


Update Composer dependencies (2021-10-17-00-06)

Visual regression test passed!
View the visual regression test report


upload test results to codacy

the project: https://app.codacy.com/gh/CycloneDX/cyclonedx-node-npm//dashboard
upload test results
upload test coverage
on pullrequest
on tag "v*"

done


Integrate functionary v1.4 and v2 models + add HF AutoTokenizer as optional parameter in llama.create_completion

Closes #1075
Closes #1061

added Optional parameter to allow tokenizing using HF AutoTokenizer in functionary chat_completion_handler and llama.create_completion
Replaced the logic for the obsolete functionary-7b-v1 model in functionary_chat_handler with both functionary v1.4 and v2.* models
Implemented parallel function calling feature as v2.* models support it

This is great. I'm waiting for this PR. can we merge this soon? @abetlen ?

I'm going to start using this branch directly. Thanks for putting it together!

On this branch I get a segfault on launch. On main I don't. This is what I run:
python -m llama_cpp.server --model $(python -c "from huggingface_hub import hf_hub_download; print(hf_hub_download(repo_id='meetkai/functionary-small-v2.2-GGUF', filename='functionary-small-v2.2.f16.gguf'))")  --chat_format functionary

If I rebase this branch against main it starts fine then hits the AssertionError for providing a valid hf tokenizer path.

@abetlen I've made the changes. How does this look now? Mainly tokenizer was changed to adopt an ABC-ish setup with typing.Protocol as suggested by you. The documentation page for the OpenAI server may need to be updated since I've added hf_tokenizer_path into ModelSettings too.

Hi, may I ask if there is updates on this PR? I think the author has implemented the requested change. Can we merge? 😊

@jeffrey-fong looks good, I'm not able to modify the PR but I do have a couple of changes I still need to make, I'll just make them after the merge:

Instead of hf_tokenizer_path in the __init__ I'm going to change this to an optional tokenizer param so you can pass an HFTokenizer to the Llama class. I'll keep the hf_tokenizer_path option for the server though.
I'm going to revert the tokenizer signature and adjust the surrounding code otherwise this might break some existing code expecting the old signature.

Additionally I'm going to create an issue so that we can fix the llama.cpp tokenizer problems that are preventing us from using the normal tokenizer as-is.

@abetlen Sure, sounds good to me! I'll keep track of the issue too as it feels really inelegant to have to pass in a HF Tokenizer.
I've pulled from main so feel free to approve and merge it. 👍

Hey @jeffrey-fong still working on the changes over in my origin/integrate-functionary branch, not sure if I screwed something up but when streaming normally the tokenizer seems to ignore any spaces.

Just wondering if you've seen that before.

@abetlen seems like it's due to this line in llama.py https://github.com/abetlen/llama-cpp-python/blob/main/llama_cpp/llama.py#L937
The Llama HF Tokenizer does not prepend the prefix space to the first token in the token list when decoding as mentioned here:

https://huggingface.co/docs/transformers/main/model_doc/llama
I have modified the streaming detokenization in the _create_completion method with offset mapping logic when the tokenizer is LlamaHFTokenizer. Hope it does not break any existing code.

@jeffrey-fong is it possible to account for this in the HFTokenizer instead of _create_completion?

@abetlen sure, I've moved this to both HFTokenizer and LlamaTokenizer. Llama.detokenize will have a new Optional parameter called prev_tokens. If prev_tokens is not None, we will perform offset mapping in the decoded string level for HFTokenizer and tokens level for LlamaTokenizer. Hope this new optional parameter is ok for you.

@jeffrey-fong thanks for your patience with this PR, I'll review again tonight.
Also, in my #957 I was able to write up some helpers to add support for streaming function calls so I should be able to integrate that for functionary as well once it's merged.

Hello, may I inquire if there's an update on this issue? It appears we're awaiting a PR merge. Am I correct in understanding that?

Sorry I've just been getting over the flu last few days didn't have a chance to work on this. Looks good, I'll merge and I may still update the tokenizer api before the next release but it should be in and working!
Thanks so much for the work on this @jeffrey-fong

Hope you rested up well @abetlen. Thank you!

Please rest well, @abetlen. Thank you for working on this. @jeffrey-fong @abetlen


The type annotations for private members are omitted in the compiler-generated d.ts file, resulting in the inability to infer the generics of subclasses.

🔎 Search Terms
d.ts, dts, private, type inference, generics
🕗 Version & Regression Information

This is the behavior in every version

⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.4.5#code/MYGwhgzhAECyCeBhcUCMAeAggPmgbwChpoAHAJwEsA3MAFwFNowAuaTAbiOmAHsA7CLTIBXYLR5kAFCzYBKfF2K0AFhQgA6MNAC8TLgF8Ch0JBgJkp1AGVhAIyy56ADwZ8AJmaQoIGHAsO08CSMABqoOnBeljb2fMIAtrb0ZI4u9O6eFmjoFHwAZsnQTrgA-EXQrHz0VMkEAPR10GHQatBxibX1jQDuyunQKowAKkH0VsCUJLTcPPEkFCCFAObpyXT0MIMzZGQbJPxuuUvQbuq0MHkL9F0t07MU5wN9A6NMfHw8tHQU-NB5Ek9GORqOtoPF6B0yEwWnxAZEsj4TvRLnwHj8+MwbpIhjwmFQeBQ3DN8sIIOiADTQbqMMC7bjKMB8JZHOF8MDgv5kWbw7zhcQ80wAJlkBDc9BMdJMUAFUEFDgUxGBNAYTE4xF4AiEonEUhkmBFxm8Moggpi8ucrg8xrlfkIAVeIUFEXM3lNdnQ7SSKWgFvSVpdQpy+UKxWgZScFTa1VqDSaTtawj4AGsPt0+AQgA
💻 Code
class MyClass1<A> {
  private a: A;
  constructor(a: A) {
    this.a = a
  }
}
class MyClass1Sub<A> extends MyClass1<A> {
}
type X1 = MyClass1Sub<number> extends MyClass1<infer x> ? x : never
// X1 is number

// when the TypeScript compiler generates the corresponding d.ts file
// it omits the type annotation for the private member a in the MyClass1 definition:
// (To avoid confusion, we are changing the name from MyClass1 to MyClass2)
declare class MyClass2<A> {
  private a;
  constructor(a: A)
}
class MyClass2Sub<A> extends MyClass2<A> {
}
type X2 = MyClass2Sub<number> extends MyClass2<infer x> ? x : never
// X2 is unknown

🙁 Actual behavior
Because the type of a is lost after compilation, X2 is inferred as unknown.
🙂 Expected behavior
Consider I am writing a package, ProjectA, where I have MyClass1 defined.
Now, after compiling and publishing ProjectA, I reference it in another package, ProjectB.
In ProjectA, I can infer the generics of MyClass1Sub, but not in ProjectB.
I want the type inference to be consistent before and after code compilation.
Additional information about the issue
I've noticed this issue: https://github.com/microsoft/TypeScript/issues/52127.
I can also understand the rationale behind it: since private properties aren't accessed externally, there might seem to be no need to annotate their types.
However, I believe this viewpoint is one-sided. Besides external access, there are many situations where type annotation is necessary, such as the cases of inheritance and inference that I mentioned here.

such as the cases of inheritance

Inherited classes should not access private members. Removing the type is/was necessary for compatibility/implementation-hiding reasons: https://github.com/microsoft/TypeScript/issues/38953#issuecomment-639804291
This is somewhat a duplicate of #51489.

@MartinJohns
Alright, after reviewing the information you provided, I understand the complexity of this issue.
There are indeed several ways to address this problem, such as using protected or using a symbol to retain the type.
const xxx: unique symbol = Symbol()
class MyClass1<A> {
  declare [xxx]: A
  private a: A;
  constructor(a: A) {
    this.a = a
  }
}

However, one concern is that I test my code in ProjectA, everything works fine, but only after compiling, publishing, and then importing into ProjectB do I encounter the issue. This situation is troublesome because I have to go back and modify ProjectA.
Ideally, if such coding practices are not allowed, I would prefer to be notified of errors while writing ProjectA.
I expect consistency in behavior before and after code compilation.

So even though the property is private, it has observable structural implications that are lost in the generated typings.
Would the ideal be that private properties be hidden from inference machinery so that code like type X2 = MyClass2Sub<number> extends MyClass2<infer x> ? x : never would always yield never?


Split Ix test projects

We should have one test project for System.Interactive and another one for System.Interactive.Async.

@onovotny @bartdesmet we should go further to split each method under test in async to its own file.

Nevermind it's own file, but each should have its own test class. You'll get far better perf in xunit that way. xunit will parallelize tests across test classes but within each test class, only one executes at a time.


Define cpp standard only if not defined

I'm working on the following conan package for QXlsx and according to this comment, it would be nice to respect CMAKE_CXX_STANDARD if it is already defined.

I took it to the wise people of cmake-slack,
suggestions:

set min cmake to 3.21
don't do the if (NOT CMAKE_CXX_STANDARD) check, instead just set as a cache variable, ie
set (CMAKE_CXX_STANDARD 17 CACHE STRING "")
change add_definitions() to target_compile_definitions()
add a: target_compile_features() to enforce a minimum C++ standard version

https://cpplang.slack.com/archives/C5Y2GDECX/p1658498760165389

I don't see why cmake 3.21 should be required, nor why force cpp 17 on Qt5

Tell me if you want me to squash the commits.

68abfe5 => I just watch this and the diff hurted me: https://www.youtube.com/watch?v=SsoOG6ZeyUI

squashed and merged thanks

68abfe5 => I just watch this and the diff hurted me: https://www.youtube.com/watch?v=SsoOG6ZeyUI

what... who uses vim and actually presses the spacebar instead of the tab... set expandtab for a start ... the girl is doing it wrong!

@dantti I already asked you but do you plan to release a new version including the latest Qt 6 compatibility fix ?

@MartinDelille I think I can do one now

Any idea when the release will happen ? 😄

Sorry, done now...

Thank you so much! 🎉


[BugFix] fix visitor cannot process case when operator (backport# 16660)

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

backport# 16660
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_fe_unittest


Translate the website to Portuguese (brazil)

Clone the repo
Go into the folder translations
Copy the file of the language you know into a new file
Use ISO 639-1 language code as file name
Open the new file and do the translation
Submit the pull request
Happiness :-)

I can do it.

Awesome, you are assigned.

Improve Brazilian Portuguese translation #75


backend/repository: pull layers in parallel

To reduce the time it takes to fetch docker images, this commit modifies
the backends to pull each image layer concurrently. As a result,
github.com/coreos/pkg/progressutil is used in place of ioprogress to
draw the progress bars.

@dgonyeo afaict this is  a legit test failure - file is not getting white outed as it should. Can you take a look?

bump

After a couple of days of banging my head against the wall, I can't figure out why that test is failing. I didn't expect to have changed the logic related to whiteouts, and I pass test-pwl and fail test-whiteouts, yet I don't understand the differences between the two tests.
Would @iaguis have the time to give me a hand at figuring out why I'm failing test-whiteouts?

Let's continue on #158. Thanks a lot for this!


Replace your-github-user with the actual github user/org

Related to #3 -- In fact, we can probably just sed for \w+github\: and tack on the github repo, which contains the user+repo in 1 var

It's done in the shard dep, at the bottom of the readme there's still a couple places that could use templating


[beta3] Documentation unclear about @ForeignKey

Hi,
In GettingStarted.md, you declare your foreign key as a Colony (so as a BaseModel), but just after you declare it as a ForeignKeyContainer<Queen>.
When should we be using a ForeignKeyContainer and why ?
Thanks.
PS: is there some sort of walkthrough to migrate from version 2 to version 3 ? I love the new version but have some new errors that I cannot figure out...

in the develop version ,I made this much clearer.
We use a ForeignKeyContainer in this instance, since we can have thousands of ants. For performance reasons this will "lazy-load" the relationship of the Queen and only run the query on the DB for the Queen when we call toModel(). With this said, in order to set the proper values on the ForeignKeyContainer you should call its generated method for converting itself into a ForeignKeyContainer via FlowManager.getContainerAdapter(Queen.class).toForeignKeyContainer(queen).

this doc migration3guide will help you on your way, but its not fully comprehensive and is a little outdated as we're in beta3 now. and beta4 will have some more changes.

Ah, sorry, I didn't understood the sentense (and I always understand your Colony example upside down :-s)
So we sould use a ForeignKeyContainer for "1 to many many" relationships and not for 1 to 1 or "1 to few", is that right ?
The migration guide is quite helping, thanks ! :-)
Even if not complete, I think you should put it in your Getting Stared md.

@agrosner Do you plan to update the migration guide?

most likely right before full release of 3.0.0 @fabiendem


Use kustomize to modify the sample CRs

Using the samples would help not to put everything inline. Though ansibleVars have to replaced as a string atm.

recheck

recheck

recheck

recheck

recheck

recheck

recheck

recheck

recheck

recheck

recheck

recheck

@Sandeepyadav93 @abays this is ready (other than some jobs failing with the swift issue), once we get this in we can put a PR to change the sample in dataplane-operator to use IPAM/DNS.

recheck

recheck

/retest


Add depth map estimation bundle

Add depth map estimation bundle based on: https://github.com/SNRLab/Visually_Navigated_Bronchoscopy

Hi @franklinwk , thanks for posting this ticket. May I know that will you contribute this bundle? If meeting any questions during the developing, feel free to ask here.

@jjomier ^^

I have the metadata and models set up, but I'm having some issue figuring out the inference configuration and what from it is needed (dataset directory? data list?).
https://github.com/franklinwk/model-zoo/tree/dev/models/bronchoscopic_depthmap_estimation

@wyli @Nic-Ma is there anyone from the core dev team that can help @franklinwk finish his first MONAI CAI Bundle?
It's the first case coming from MONAI Stream. Visually Navigated Bronchoscopy for depth pose estimation using a 3cGAN. Really cool use case. :)

Hi @franklinwk , please refer to:
https://github.com/Project-MONAI/model-zoo/blob/dev/CONTRIBUTING.md#preferred-files-and-keys
In inference config file (if exists), please include the following keys: bundle_root (root directory of your bundle), device (required device), network_def (definition of the network components), inferer, and if there are any output files, the directory key should be defined as output_dir (click here for instance).

for the branch you forked, could you submit a draft PR, thus it's easier to review (and help to debug if needed)? Thanks in advance!

I've created a draft PR: https://github.com/Project-MONAI/model-zoo/pull/447
My main issue is how to set up inference.json, especially network_def when the model wasn't originally made using MONAI. I'm also unsure how to describe the data format to describe grayscale data.

Hi @franklinwk ,

especially network_def when the model wasn't originally made using MONAI
If the model can be used via pip install, like from external import mymodel, you can write the config like:

    "network_def": {
        "_target_": "external.mymodel",

This bundle is an actual example.

how to describe the data format to describe grayscale data

May I know that what is the input shape and what is the value range of the data?


Suggestion: The query result list supports row and column selection and provides right-click function.

Reference navicat query result list supports multi-line selection.

press ctrl+ mouse to select and select multiple lines.
Press shift+ mouse to select and select multiple rows.
Columns are sorted only by clicking the sorting icon, otherwise the corresponding column data is selected.

When selected, it supports the shortcut key ctrl+c to copy data and the right-click menu.
-Copy as

-Export as

-Delete the selected row.
-bulk modify a field.

Changes have been made in the new version, and optimization will continue in the future.


Discrete field with domaintype

A DiscreteField is defined using a DiscreteDomain and a set of values, which correspond to the values at the points of the domain. So far the information about the concrete type of the DiscreteDomain was not available
in the DiscreteField. It was only know that it was a subtype of DiscreteField. By introducing the concrete Domain as a type parameter into DiscreteField, i.e. by defining
class DiscreteField[D <: Dim, DDomain <: DiscreteDomain[D], A](val domain: DDomain, val data: IndexedSeq[A])

we can retain this information. This makes it possible that methods defined on discrete fields can exploit more information about the domain, such as for example that it is defined on a regular grid. A typical example is an interpolation method, which can be much
more efficiently implemented if the underlying domain is an image domain.

I don't quite get the need for this change yet.
Currently, to interpolate and image, we use image.interpolate .. meaning that we already know that the domain is a DiscreteImageDomain and hence can write optimized code for this. To me, this change suggest that you want to be able to write optimized code in generic classes. Or?

@Ghazi-Bouabene The main motivation for the change is that I would like to be able to interpolate a DiscreteGaussianProcess. As in the current implementation of scalismo, the domain type is not part of the definition of a DiscreteField (it is only known that the domain is a subclass of DiscreteField) we cannot use any other interpolator than the NearestNeighborInterpolator to interpolate GPs. With this change, we can use any user defined interpolation strategy that works on the right domain type.

@marcelluethi Yes that's what I imagined from PR #217, where you can create different types of interpolators, some more optimized for certain domains than others and pass them in to the interpolate method ..  But then again, the type of the domain should already be known in the interpolator (that might be a dummy nearest neighbor one, or an image domain interpolator for example). For example, if the interpolate method of a DiscreteLowRankGaussianProcess[D <: Dim: NDSpace, DDomain <: DiscreteDomain[D], Value] expects an Interpolator[D, DDomain, Value], why should the DiscreteFields as well be parametrized on the type. We can safely assume that interpolator.interpolate(..) will receive a DiscreteField that is defined on a discerete domain of the correct type, or?

:+1:


An unticked item in the "Replace in one go" dialog is not displayed as intended

Only the header gets grey. Instead the whole div surrounding an object should become grey.

Fixed


Problem Hosting a Static Website in AWS Amplify Console

Please describe which feature you have a question about?
AWS Amplify hosting a static website.
Provide additional details
I am using AWS Amplify to create a static website. This website contains an html form that will send the form information to a lambda function, and provides and answer.  I am using this tutorial as guide, Well, my problem is that I need to create a datalist with thousands of options . So What I am doing is putting all those options in a json file and I am uploading this file using the code showed below. This code works in my local IDE but not works when I upload a zip file in AWS Amplify console. Why?
What AWS Services are you utilizing?
AWS Amplify, AWS Lambda
Provide additional details e.g. code snippets

                        Branch:
                        <input list="list" class="large" id="branch" role="combobox" autocomplete="on" name="branch"
                        placeholder="Select a branch..."/>
                        <datalist  id="list">
                        </datalist>

Hi @ddmora 👋🏽  do you receive any errors after uploading your zip folder to Amplify? Please share any screenshots or error logs you may have.

Please re-open if you're still running into this issue.


downloads: add GUI macOS ARM link

small edit of the -lt value on line 60 needed "elif [ $num -gt 13 ] && [ $num -lt 19 ] ; -> -lt 20
i am not 100% happy with the filenames checker - it will error - however the error message can be misleading - but most importantly - it will error if there is a problem.  this LGTM

Validate hashes error will be fixed after @binaryFate adds the new gui arm8 hash/filename to hashes.txt


creating db region table

I'm pushing as a following steps of working on database branch for creating tables.
simple Regions table
this PR has
region.js file for postgres schema
create-region.js for sequelize magic to create a table and insert data inside it

Tablename in user is in lower-case. Here we have 'tablename: 'Region'
I would make them all lowercase

Tablename in user is in lower-case. Here we have 'tablename: 'Region' I would make them all lowercase

noted @dirk-jacobs

the last commit is adding const Region = require('../../models/region.js') into sync.js file


Remove leading and trailing spaces from title

Some URLs return titles with leading and/or trailing spaces which confuse the markdown parser.
Example URL: https://android-developers.googleblog.com/2022/04/first-preview-privacy-sandbox-android.html
A solution would be to simply trim the title.

 [
Android Developers Blog: The first developer preview of Privacy Sandbox on Android
](https://android-developers.googleblog.com/2022/04/first-preview-privacy-sandbox-android.html)

For my reference.

This was a good catch. I'll investigate

Neat, works perfectly fine now - thanks for the quick fix! 🤗


Evaluate identity provider policy condition at Resource broadcast time instead of Resource access time

UX issue uncovered by customer:

User signs in via IdP A
Resource is broadcasted to her client with an IdP B condition applied
User sees Resource in list but has no indication can't connect

@AndrewDryga Would it be large refactor to evaluate the IdP condition during Resource association instead of at time of access?

refs #6159


Add UI for testing session service

This implementation works on iOS simulator but there is a problem on android. isOpen method from session service return false when session is opened. Failed to reproduce in flutter sdk example app.


uSubscription spec/detail questions

During implementation of up-subscription-rust and the subsequent (and ongoing) specification rewrite (#238), so far these questions came up:

Is it expected that a uEntity can register more than one custom topic for receiving update notifications?
Is it supposed to be possible to register remote uuris as custom notification topics?
Should remote UUris be excluded from all listeners except subscribe and unsubscribe?
Do we need update/change notifications when remote SubscriptionResponses come in? Like, changing a topic status from SUBSCRIBE_PENDING to PENDING - which would then apply to every subscriber-topic combination at that point in time, with the corresponding number of Update messages…
Is SUBSCRIBE_PENDING a valid state to receive from a remote SubscriptionService as a response to a subscribe() call?

Is it expected that a uEntity can register more than one custom topic for receiving update notifications?
No you can not set the topic, notifications come on a fixed topic (the source URI)

Is it supposed to be possible to register remote uuris as custom notification topics?
Custom notification topics is not permitted

Should remote UUris be excluded from all listeners except subscribe and unsubscribe?
I think I need more info to understand what you mean here.

Do we need update/change notifications when remote SubscriptionResponses come in? Like, changing a topic status from SUBSCRIBE_PENDING to PENDING - which would then apply to every subscriber-topic combination at that point in time, with the corresponding number of Update messages…
Yes.

Is SUBSCRIBE_PENDING a valid state to receive from a remote SubscriptionService as a response to a subscribe() call?
No.

Can we close this @AnotherDaniel ?

Closing issue


Definition Lists and number of spaces

I haven't looked at this in a long while but I notice that definition lists require multiple spaces (3) after the colon to work.
In the following markdown the first block works, the second block does not:
First Term
:   This is the definition of the first term.

Second Term
:   This is one definition of the second term.
:   Continues previous term

---

First Term
: This is the definition of the first term.
: This is the definition of the first term.

Second Term
: This is one definition of the second term.
: This is another definition of the second term.

Babelmark seems inconclusive on this with a whole bunch of parsers (including Markdig in that test) failing to render either block:
https://babelmark.github.io/?text=%23+Test+Item

First+Term
%3A+++This+is+the+definition+of+the+first+term.

Second+Term
%3A+++This+is+one+definition+of+the+second+term.
%3A+++Continues+previous+term

---

First+Term
%3A+This+is+the+definition+of+the+first+term.
%3A+This+is+the+definition+of+the+first+term.

Second+Term
%3A+This+is+one+definition+of+the+second+term.
%3A+This+is+another+definition+of+the+second+term.

and quite a few - including PanDoc parsing both blocks.
All parsers seem to recognize the Definition List though because all parsers are generating the headers properly - it's the sub items that are falling through.
Is there a reason that Markdig requires the extra spaces? The parsers that do render the list properly don't require the extra spaces.

Is there a reason that Markdig requires the extra spaces? The parsers that do render the list properly don't require the extra spaces.

It might just be because this feature seems to have been inspired by pandoc and they do it like that...


License

Hi,
Great app! Would you mind adding a license?
Thanks!

thanks, glad you enjoy!
yep, accidentally moved to a subdirectory. fixed.

Thank you so much!


Update CONTRIBUTORS.md

I want to contribute to Open Source So, I thought this would be the right place to start.

Hey there,
Thanks for your PR & contribution :wave:!
Don't forget to join follow me, join our organization, & follow our organization to stay updated with the latest developments 💻
Thank you, and have a good day ahead 😊


InputProcessor not giving the correct mouse coordinates when Gdx.input.setCursorCatched(true)

See https://code.google.com/p/libgdx/issues/detail?id=1596

When calling setCursorCatched(true) in touchDown(), the next call to touchDragged() occasionally supplies logical mouse coordinates that aren't the same as where the cursor touched down (the usual and expected behavior being that they are the same). The logical mouse coordinates sometimes end up far outside the window, causing a spike in mouse delta when the mouse delta should be 0. It happens more when clicking and dragging in the same stroke as opposed to clicking, waiting a moment, and then dragging.


TypeError: Subscripted generics cannot be used with class and instance checks

isinstance(device_train_microbatch_size, Union[int, float])
should be
isinstance(device_train_microbatch_size, (int, float))
on line
https://github.com/mosaicml/composer/blob/3c0a8179d2c3d60786226a73d8f935bc46306a31/composer/trainer/trainer.py#L298

Good point! Would you mind opening a PR and tagging me for review?

Quick fix just did it. Thanks for flagging!


fix(sqs): wait for receive message completion(#569)

fix: #569

closes https://github.com/kestra-io/plugin-aws/pull/571


Decimal representation

I have two questions:

Is there a way of generating a bigint from its base 10 string representation? (similarly to from_be_hex in the case of base 16)
Is there a way to then print the bigint as a base 10 number

There's an open PR to add such support: #603

#603 is merged


Can't get example to exit successfully

This simple script never exits (nodejs on linux). I'd expect it to, the equivalent script python certainly does. I think its due to the ioredis module hanging around and not unref'ing itself.
any clues? I'm basically stuck.
var Redis = require("ioredis");
var redis = new Redis();

redis.set("foo","bar");
redis.incr("nextid");

redis.get("nextid", function (err, result) {
  console.log(result);
});

Yes, that's because the connection is still active. Calling redis.disconnect() or process.exit() should exit the program.
Get Outlook for iOS
On Thu, Jun 16, 2016 at 9:51 PM +0800, "dstitt"<EMAIL_ADDRESS>wrote:
This simple script never exits (nodejs on linux). I'd expect it to, the equivalent script python certainly does. I think its due to the ioredis module hanging around and not unref'ing itself.
any clues? I'm basically stuck.
var Redis = require("ioredis");
var redis = new Redis();
redis.set("foo","bar");
redis.incr("nextid");
redis.get("nextid", function (err, result) {
console.log(result);
});
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


[All Actors] Do not show multiple update modals for each edit is performed on the View single Shipment, View Single Order

keep a flag that indicates that the modal is opened and when a new event is raised, do not opened it again.
Please remember to reset flag when user interacts with modal

Started working on this

Created PR for this


Ansible installer docs

Initial docs showing how to install StackStorm with Ansible, from ansible-st2 repo.
English syntax-check is welcome :)

The bad thing about .rst table, have no idea how to make multi-line description column, to avoid scrolling here:

So is this tested? Better question, how are we going to validate this doesn't break after every release.
I don't mean to block your PR but we have a policy that anything that goes in the docs needs to be tested before every release and without automation it's hard to scale this.

I see.
In that case I need further work on improvements to make it more stable, provide automatic tests and fix some existing issues. Everything is part of big checklist: https://github.com/StackStorm/ansible-st2/issues/2 on which I'll work further.
Of course I've tested existing state manually many times.
But as I understand @jfryman wanted to have some initial docs ASAP.
So you guys decide is it mergeable or Ansible installer needs more tests and stability. I'm ok with any decision and anyway will continue to work on ansible-st2.

@lakshmi-kannan I did give both @dennybaa and @armab direction to get some docs out there.
Can we exclude Config Management from this requirement for the time being? I want to give visibility to these installation methods, but we have some work to do before they'll be at this higher bar of quality and it's being worked on right now.
In terms of the actual plan, @armab has it outlined in his checklist.

Yeah, if you already made a call to include it, I am fine. I just wanted to make sure we are thinking about testing etc. LGTM.


Is maro ready for production use?  for example, in the VM Scheduling Scenario

@Jinyu-W

In other words, Is Microsoft using Maro in production？

Hi, currently MARO's technology is being converted to production. As an open-source project, the VM scenario in MARO aims to provide a general modeling.


feat: bump gotrue version to v2.92.1

What kind of change does this PR introduce?
see title

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 56.74%

Files with Coverage Reduction
New Missed Lines
%

internal/gen/keys/keys.go
5
12.31%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4908

Relevant Lines:
8650

💛  - Coveralls


Nemo#2021/remove check circle

Ticket
Airtable Ticket #2021
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Description
I have added some theming rules to override the default styling of the MUI Button component. Now, instead of reaching for the "RedesignPrimaryButton"/"RedesignSecondaryButton" components, developers should be able to use the MUI Button component with all of its expected props. This includes using the underlying MUI color palette, like "error", "success", and "info"! I've explicitly defined 3 themes for our most common use cases using the built-in variant and color props.
variant: "contained" color: "primary"

variant: "contained" color: "secondary"

variant: "outlined" color: "primary"

Ticket Fix
Before

After

Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (if applicable)
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works (if applicable)
[ ] New and existing unit tests pass locally with my changes

Got rid of the linter errors by removing the unused component imports!


Inserter arrows are slightly offset compared to vanilla inserters

See image below for reference. The thrower arrow should be just a tiny bit further.

Holy moly what is this unplayable trash doctor we need a fix STAT

Close one we should be good now thanks m80

It's funny because inserters that are already placed still have the offset, but new inserters are fine.

Ah well, not a big deal, this base is supposed to be torn down sooner or later.

lol you know what you're totally right, I forgot that it wouldn't apply retroactively 😅. But yeah it should function the same either way and works for new ones so I'm not too miffed, I'm not sure how I would even adjust all existing thrower inserters anyway


feat: add ability to write the EVM database to disk for post-processing

Idea
If we can write the EVM database to disk, then we are free to use tools like cryo to analysis the data and post-process it. This can streamline the process so that users don't have to capture the data they want on the fly -- rather they capture the whole set of state transitions and diffs.
Is your feature request related to a problem? Please describe.
We need the ability to provide users a clear way to process the data they get in simulations.
Solution
The potential solution here is to change the DB that we are using. As was suggested by Dragan (creator/maintainer of revm, we could use an alternative DB. I need to look into how exactly we implement this, get it in, test it out, and add functionality to write the database to disk.
Alternative approaches
Other approaches could use other DB's but this was suggested by the legend himself. We could also add other functionality to selectively save data in a CSV, but that seems less modular.

We should push something like this in v0.5.0 so I am marking it as such.

Solved in a different way


Error condition "abuse:spoofing-attack" is not handled by the MessageListener

According to the "AMQP spesifikasjon" from Direktoratet for e-helse, mismatch between AMQP From HerID and XML message From HerID should result in a message on the error queue with the error condition "abuse:spoofing-attack".

@chriscena
Fixed by #5, pulled at https://github.com/ehelse/Helsenorge.Messaging/commit/c2c6c4eba19e7a851362a41020173a32705016eb


[Feature] template-based heartbeat extraction

I am going to merge this since it is a working version, but TODO: add unit tests for all functions added, and refactor template algorithm so that it is less of a monstrosity


feat:(frontend) Add DataTable components and refactor seats-list to allow filtering, searching and sorting

This pull request enhances the seats-list data table in the dashboard. The main changes include the implementation of new data table components (from shadcn) with the integration of faceted and search filters, sorting, and view options for toggling column visibility.
New Components and Enhancements:

Data Table Components:

src/dashboard/components/ui/data-table.tsx: Introduced a new DataTable component that supports sorting, filtering, and column visibility management using @tanstack/react-table.
src/dashboard/components/ui/data-table-toolbar.tsx: Added a toolbar component for the data table that includes search and filter functionalities.
src/dashboard/components/ui/data-table-column-header.tsx: Created a column header component for the data table with sorting and visibility toggling options.
src/dashboard/components/ui/data-table-faceted-filter.tsx: Implemented a faceted filter component to filter data table columns based on unique values.
src/dashboard/components/ui/data-table-view-options.tsx: Added a view options component to toggle the visibility of data table columns.

Integration and Usage:

src/dashboard/features/seats/seats-list.tsx: Replaced the existing table with the new DataTable component, incorporating the new column header and faceted filter functionalities. [1] [2]

Dependencies:

src/dashboard/package.json: Added @tanstack/react-table as a new dependency to support the new data table functionalities. [1] [2]

@microsoft-github-policy-service agree


When in compartment scopes are used, token should not need to have read access to the parent resource

We have Patient/Observation.read scope. We create a rule with
Rulebuilder builder;
IdDt userIdPatientId;
builder.allow("read:" + scope).read().resourcesOfType("Patient/Observation.read").inCompartment("Patient", userIdPatientId);
Reading Observation resources fails because of the comparison done below:
https://github.com/jamesagnew/hapi-fhir/blob/867648979228914e042d400d86c162c3dbf4a8f4/hapi-fhir-base/src/main/java/ca/uhn/fhir/rest/server/interceptor/auth/RuleImplOp.java#L227
It checks if token's scope is Patient.read.
If we add for example ValueSet.read which is not an in compartment scope, reading succeeds.

The issue there is that the AuthorizationInterceptor isn't designed to handle SMART scopes. It's a bit lower-level than that. Essentially you need to pass in Observation as the resource type, not Patient/Observation.read. This should actually fail since the resource type is invalid.
One of the things I'm hoping we'll create (or someone will create first and contribute) is an adapter that sits on top of it which allows the SMART specific scopes.. but for now you'd need to parse the scope and call the builder appropriately. E.g. the scope Patient/Observation.read would translate to the following builder code:
builder.allow("read:" + scope).read().resourcesOfType("Observation").inCompartment("Patient", userIdPatientId);

..actually, looking at this, there is no resourcesAsType(String) method. I don't understand how the code you posted compiles.
Could you post a more complete code snippet?

Sorry, I missed something while taking the snippet. Here's a more complete part.
private void createPatientReadScope(RuleBuilder builder, String scope, IdDt userIdPatientId, Class<? extends IBaseResource> type) {

	builder.allow("read:" + scope).read().resourcesOfType(type).inCompartment(PhrConstants.RESOURCE_PATIENT, userIdPatientId);
	LOGGER.info("allow read:" + scope);

    }

We've evaluated this futher and it seems like the interceptor tries to evaluate the compartment for incoming request already - the code itself is valid and does compile and worked for earlier (summer) version of Hapi. Does this have something to do with that new outgoing resource id parameter in api?

Can you supply more details about exactly what is happening? I'm still not getting it, sorry. I'd like to create a unit test to recreate what you're seeing.
Ideally:

What parameters are you using to build the rule list (for the code snippet you posted, what does the PhrConstants.RESOURCE_PATIENT contain, what is the value of the type parameter etc)
What URL are you invoking the server with
What does the expected response contain
What does the actual response contain (resource type, resource ID, fields relevant to the compartment)

Here's what goes to the call:
builder.allow("read:" + scope).read().resourcesOfType(Observation.class).inCompartment("Patient", userIdPatientId);
Later on in the chain we always add a final rule which denies all. This way, if no scope allows the activity, default action is to deny the action.
We got rid of the problem by overriding this method:
https://github.com/jamesagnew/hapi-fhir/blob/master/hapi-fhir-base/src/main/java/ca/uhn/fhir/rest/server/interceptor/auth/AuthorizationInterceptor.java#L222
In case it is a READ request, skip checking the rules. They get validated in the outgoingResponse call.

Thanks. Can you please also provide:

What URL are you invoking the server with
What does the expected response contain
What does the actual response contain (resource type, resource ID, fields relevant to the compartment)

The request:
GET http://katephr3.kanta.fi:9082/kanta-phr-sandbox-oauth/baseDstu2/CarePlan/135154 HTTP/1.1

The expected response:
{
   "resourceType": "CarePlan",
   "id": "135154",
   "meta":    {
      "versionId": "268",
      "lastUpdated": "2016-11-17T07:49:11.805+02:00"
   },
   "identifier": [   {
      "use": "temp",
      "type": {"text": "Type text"},
      "value": "UHV8I7zN3jZ8h9oecEfBdw==",
      "period":       {
         "start": "2016-08-07T01:47:06.250Z",
         "end": "2016-08-07T01:47:06.250Z"
      },
      "assigner":       {
         "reference": "Organization/121156",
         "display": "Potilas ite"
      }
   }],
   "subject": {"reference": "Patient/845bd9f1-3635-4866-a6c8-1ca085df5c1a"},
   "status": "active",
   "context": {"display": "Tähän voisi laittaa Encounter referencen"},
   "period":    {
      "start": "2016-08-07T01:47:06.265Z",
      "end": "2016-08-07T01:47:06.265Z"
   },
   "author": [{"reference": "Patient/845bd9f1-3635-4866-a6c8-1ca085df5c1a"}],
   "modified": "2016-08-07T01:47:08.602Z",
   "category": [   {
      "id": "32322",
      "coding": [      {
         "id": "00922",
         "system": "http://loinc.org",
         "version": "00922",
         "code": "2.16.840.1.1138<IP_ADDRESS>.80.62",
         "display": "waist circumference",
         "userSelected": true
      }],
      "text": "category text"
   }],
   "description": "careplan desc",
   "addresses": [{"reference": "Condition/121154"}],
   "support": [{"display": "Tähän myös reference resurssiin"}],
   "relatedPlan": [   {
      "code": "replaces",
      "plan":       {
         "reference": "CarePlan/122257",
         "display": "Tähän reference toiseen CarePlaniin"
      }
   }],
   "participant": [   {
      "role": {"text": "Role text"},
      "member":       {
         "reference": "Organization/121156",
         "display": "Tähän reference ORG, Patient, RelatedPerson tai Practioneriin"
      }
   }],
   "goal": [{"reference": "Goal/121155"}],
   "activity": [   {
      "actionResulting": [{"display": "actionResulting"}],
      "progress": [      {
         "time": "2016-08-07T01:47:06.314Z",
         "text": "Progress text"
      }],
      "detail":       {
         "category": {"text": "category FTqzimL6VGaBpXSrhlND+g=="},
         "code": {"text": "code jl1nnFTvxxzxsjuSzLrtcg=="},
         "reasonCode": [{"text": "reasonCode ODj51GwdlgQJUDkyqDsq1g=="}],
         "reasonReference": [{"display": "reasonReference dyh3XvcX4FRLhqJIu+mFpA=="}],
         "goal": [{"reference": "Goal/121155"}],
         "status": "on-hold",
         "statusReason": {"text": "statusReason l+1+knGytXTfehwaWyQesw=="},
         "prohibited": false,
         "location":          {
            "reference": "Location/121157",
            "display": "location fGeOnXwe8/Mc38eE3MXdRQ=="
         },
         "performer": [{"reference": "Patient/845bd9f1-3635-4866-a6c8-1ca085df5c1a"}],
         "dailyAmount":          {
            "value": 0.14753114774732656,
            "unit": "EqzIxE8XvKKGsHHjAFJpDw=="
         },
         "quantity":          {
            "value": 0.8384859726955787,
            "unit": "vs1y1wnU7dzX6FUfAcYWsQ=="
         },
         "description": "p/9qoIk9CahoYIebCJKVmA=="
      }
   }],
   "note":    {
      "time": "2016-08-07T01:47:06.356Z",
      "text": "o0jZZeG0/0vl19kOgWnn/A=="
   }
}

Actual response is the output from our aforementioned Deny all final default rule.

Perfect, thanks! I'll see if I can get a unit test going which recreates this.

The value of patientId is attached to request in the bearer token, we get the value from the Oauth server and based on that response we build the rulelist - so it is not explicity as compartment in the read url.

Ok, I think I have this one nailed. Basically the interceptor tries to be a bit clever by preventing the implementing method from ever being called if there is no chance the compartment rules could allow the call to proceed. It was being a bit overzealous.
I'm going to check in a fix now.
Thanks for reporting, and supplying all the details, that was just what was needed.


Are there node dependencies and if so, what is the earliest version of node supported?

Hey there guys.
I plan to use axios in a sdk used both in the node environment and in react-native.
I want to know :

If it uses node dependencies - like for example crypto (because if it does, react-native users won't be able to use it).
If the answer above is yes, what's the earliest version of node it can support (I want to know if it will mess things up for legacy node users)

Thank you!

axios uses different adapters for Node.js and browsers. The Node.js adapter does use Node.js APIs, but the browser one (which is also used in react-native) does not.
axios should work fine with old Node.js versions (at least, v0.10+), but you will need to polyfill Promises if you use v0.10.
Hope this helps!


Backorder Feature

From this issue https://github.com/mirumee/saleor/issues/4190 these changes create a minimal feature for supporting backorders/preorders. The feature is configurable per channel via a plugin (although there isn't any configuration options besides active or inactive). It doesn't support limiting backorders like the original issue suggests. As part of this three new OrderEvents are created to help keep a paper trail of backorders. I can create unit tests for this if the maintainer(s) are interested in the feature as I've conceived of it here.
Concept: The idea is that tracking backorders is similar to tracking warehouse allocations. If there is not enough stock of a variant to create a full allocation, then when the InsufficientStockError is risen, an entry in the Backorder table is created if the plugin is active. As new stock is added to inventory, backorders are converted into allocations in a first-in-first-out order.

https://github.com/mirumee/saleor/issues/4190
Thank you!
Impact

[x] New migrations
[x] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[x] Documentation needs to be updated

Pull Request Checklist

[x] Privileged queries and mutations are guarded by proper permission checks
[x] Database queries are optimized and the number of queries is constant
[x] Database migration files are up to date
[ ] The changes are tested
[x] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello, the core team is currently jam-packed with the 3.0 release and Saleor Cloud work, so it may take some time to review pull requests submitted by the community.
We are currently working on a similar feature to support preorders in Saleor 3.1. It would be best to park this until preorders are merged to see if preorders and backorders could share the same models or logic.

If you are interested in the current state of preorders, you could check it out here. It's still a work in progress.

If you are interested in the current state of preorders, you could check it out here. It's still a work in progress.

Thank you! I'll follow that branch. It looks like the approach there for pre-orders is quite similar to what I have here for back orders.

We discussed the status of this PR recently and have decided not to merge it to the core for a few reasons. We're trying to limit the features added to core to a minimum and focus on extensibility via webhooks and building new features as Saleor Apps. This PR relies on plugins, which we will be migrating to apps in the future and don't want to invest too much effort into them currently. We appreciate the amount of work put into this PR and willing to contribute to the platform 🙌 .

Would it be possible to get backorders added to the roadmap? I have a client who requires support for backorders so in the meantime I'll need to find a workaround.

Hello, the core team is currently jam-packed with the 3.0 release and Saleor Cloud work, so it may take some time to review pull requests submitted by the community.
We are currently working on a similar feature to support preorders in Saleor 3.1. It would be best to park this until preorders are merged to see if preorders and backorders could share the same models or logic.


jankyborders: 1.6.0 -> 1.7.0

Things done
https://github.com/FelixKratz/JankyBorders/releases/tag/v1.7.0

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 357012

x86_64-linux

aarch64-linux

x86_64-darwin

:white_check_mark: 1 package built:

jankyborders

aarch64-darwin

:white_check_mark: 1 package built:

jankyborders


Undeterministic path resolvation for subquery selections

Description
The resolvation of path expression for subquery clauses have some issues when a not fully qualified expression is used.
For example:
CriteriaBuilder<Tuple> cb = cbf.create(em, Tuple.class)
    .from(Document.class, "d")
    .where("d.owner.id").in().from(Person.class).select("id").end()
    .select("d.id", "id");

Expected behavior
The expected behaviour is that id is transformed to person.id.

Actual behavior
The actual behaviour is that id is transformed to d.id.

Steps to reproduce
Reproducer: https://github.com/Blazebit/blaze-persistence/compare/master...JWGmeligMeyling:subquery-path-resolving?expand=1

Environment
Version:            1.2.1, 1.3.0-SNAPSHOT
JPA-Provider:
DBMS:
Application Server:

The above mentioned test () passes upon removing the alias argument in the final select statement:
CriteriaBuilder<Tuple> cb = cbf.create(em, Tuple.class)
    .from(Document.class, "d").where("d.owner.id").in().from(Person.class).select("id").end()
    .select("d.id");

specifically this generates the following correct query
SELECT d.id FROM Document d WHERE d.owner.id IN (SELECT person.id FROM Person person).

In contrast to the wrong query that is found in the test as given by Jan-Willem: SELECT d.id AS id FROM Document d WHERE d.owner.id IN (SELECT d.id FROM Person person).
I have not yet found where in the last .select statement the person.id expression is changed into d.id.


Start reexporting ITensorTDVP and ITensors.ITensorMPS

See also https://github.com/ITensor/ITensors.jl/pull/1410, there you can see a list of exports that will be left in ITensors.jl if these are removed from there and moved here.
@emstoudenmire curious what you think about this list of exports.
My thinking is that we should try to move any exports that are primarily used for MPS code here, so that we can then remove them as exports from ITensors.jl (which has way too many exports right now).
The idea is that if users type using ITensors, ITensorMPS we make sure there code still "just works", so a way of doing that would be to divide the current exports of ITensors into ones we plan to continue exporting from ITensors and ones we plan to only export from ITensorMPS (there could be an overlap but I don't see a need for that).

Looks good. I commented on the other PR. I couldn't see any issues with how you split the exports. The only non-obvious thing to me was the SiteType system, but if I understand correctly the status would now be:

if you do using ITensors, ITensorMPS you'd get all the stuff you would previously get including the SiteType system
now if you only do using ITensors you would not get the SiteType system, but you could still optionally get it (without any MPS code) by adding another using statement, maybe using ITensors.SiteTypes ?

Thanks for looking it over, it is helpful to get a sanity check on this. Yes that's a good summary. For now the official recommendation will be to do using ITensors, ITensorMPS, but we can discuss other ways to get certain exports without having to load the entire ITensorMPS package.
As you say, one option could be using ITensors.SiteTypes. Alternatively, we may split off SiteTypes (or some iteration on that design) into a separate package in which case we could tell users that they can load that package explicitly.


Refresh GUI Item

Add ability to click on item to refresh it.
Use case is for placeholders from PlaceholderAPI.
Inventory should not close on refresh.

This is the same as #8. Closing


added application info

created a short description of application in the readme file

delete because I would have to add another github account


Feat: In footer logo,visitors count and star us button added

issue #576 solved

hi @Priyaaa1 mam review the PR


LANGUAGE_CODE doesn't affect admin interface html 'lang' attribute in skeleton template

Issue Summary
<html> tag attribute 'lang' in skeleton.html admin template is not being filled with value of LANGUAGE_CODE settings variable
But it supposed to: <html class="no-js" lang="{{ LANGUAGE_CODE|default:"en-gb" }}">
Steps to Reproduce
Set LANGUAGE_CODE in settings.py to, i.e., 'he_IL'.
Restart your application/Reload container and refresh admin page.
Get page source in browser. You'll get <html lang="en-US"> at the top of the page source.
It seems that LANGUAGE_CODE variable is not accessible while in skeleton.html.
Technical details
wagtail 2.2.2
python 3.6

Thanks for the report @remort! This does look like a bug - as far as I can see there's nothing in place in the Wagtail code to make the LANGUAGE_CODE setting available.
Using the variable from the settings file directly wouldn't be correct either, as that wouldn't deal with users setting their own language preference from the 'account settings' area - we should probably be using request.user.wagtail_userprofile.preferred_language here instead.

Actually, it looks like we should be using the get_current_language template tag here: https://docs.djangoproject.com/en/2.1/topics/i18n/translation/#get-current-language