chore(ui): Upgrade @types/react to version 18

Description
Updates the React typings (17), which were mismatched against the actual version (18) of React we were using.
There were a good handful of errors that popped up when doing this, so for the fixes I opted for minimal runtime impact and suppressing ts errors instead of more substantial changes. I'll annotate the changes inline.
I'm targeting bradr/remove-previous-compliance-coverage-code instead of master since there was an error in compliance code that is deleted in that branch, and this avoids a merge conflict.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Clear node modules, yarn, and build the app.
Manual smoke test that the app is functioning as before.

/retest


Indicate brew installs pre 0.35.x #93

That's not correct. The macOS package will be updated to 0.35 once the recent CI problem are resolved (already done as of now) and it's turn for deno in the currently large CI backlog.
It's just that you can't install it on Linux, because of the not satisfiable python@2 requirement.

I was confused with the answer from bartlomieju in https://github.com/denoland/deno/issues/4047#issuecomment-593099880 ... closing


make management policy optional

we're managing access by attaching policies directly to roles so the aws_elasticsearch_domain_policy isn't needed

@antonbabenko If you have the time please take a look or mention someone who might be a good reviewer. Thank you!

+1

This repository and https://github.com/terraform-community-modules org, in general, are pretty much stale. I don't have enough time and incentives to manage these repositories on the proper level as I'm doing with https://github.com/terraform-aws-modules

No problem, thanks for your work!
Btw, what's is the main difference? Why don't we move this repository to the other organization?
Regards,


Add sails v0.11.0 requirement to readme

This PR updates the readme to let users know that the minimum supported version of sails for this library is v0.11.

nice, but remember that all sails hooks need >= 0.11, not only this :-)


Update documentation with downstream build instructions

Currently, there are no instructions on how to configure and build for consumers who are importing PatternFly Less. There has been recent confusion about the file structure and how dependencies work in our distribution, so some clarification may be necessary.

Explain that the dist/dependencies folder is not used by PatternFly but is included for edge cases where our standard distribution might not work for a consumer.

Describe how the consumer should configure their build tool to include node_modules in their search path when building less, and how this allows the import statements in PatternFly Less to be resolved. Possibly include examples or links for some common build tools like Grunt, Gulp, and Webpack.

Ensure that it is clear that only files in the dist/ folder should be consumed (not src/) since src was not meant for consumption and has been removed as of v3.30.0.

Created in the wrong repo. This should in the patternfly core repo.


Feature/issue 1260

Description
This PR implements the enhancement proposed in issue #1260

TODOs
Read the Gruntwork contribution guidelines.

[X] Update the docs.
[X] Run the relevant tests successfully, including pre-commit checks.
[X] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[ ] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

[X] Added DeploymentNotAvailable struct.
[X] Added Deployment functions.
[X] Updated tunnel. go to support port forwarding for deployment resources.
[X] Added test related to tunnel support port forwarding for deployment resources.

Migration Guide
There aren`t backward incompatible changes

Hi, With the modifications I did in this PR those tests in CI supposed to break? Do I have to do something to fix those CI fails?

Hi @marcellmartini - thanks so much for your PR and contribution - we're getting this queued up for review!

Failed tests aren't related to added changes

@zackproser and @denis256 Thank you. I will get other issues to help. Are there any issues you´d like to prioritize?


change flag name: enable-communication -> disable-isolation

r? @oli-obk  -- I think this is a better name for the flag but it is still somewhat clumsy. Suggestions?

Don't we want this on by default and have --isolate to disable communication?

Eventually, yes. My thinking was to leave it off-by-default for now, let people experiment with it, see if it works all right, and only then switch the default.

@bors r+

:pushpin: Commit 55efee91406f17beab46273210318b7259632345 has been approved by oli-obk

:hourglass: Testing commit 55efee91406f17beab46273210318b7259632345 with merge 2be0db4c0baabfb400ec3f502c908ba5a30f2b25...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 2be0db4c0baabfb400ec3f502c908ba5a30f2b25 to master...


Merge pull request #83 from camaraproject/main

Fixing MoMs
What type of PR is this?
Add one of the following kinds:

cleanup

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for reviewers:
Changelog input
 cleanup

Additional documentation
This section can be blank.
docs

no changes


Add Editable Merge feature

Add Editable Merge feature (issue #20)

Editable merge fields should allow for editable fields that are not required.

Editable merge fields have been implemented.

FYI, @cquilboss - We appreciate your PR, and slightly modified it alongside some other changes (which is why the PR isn't showing up as "merged"). Thanks!


Export CSV exports also Array prototype

If you add any methods on Array/Object prototype then the for in loop from getBody() method will try to export it.
https://github.com/alhazmy13/angular-csv-ext/blob/master/Angular-csv.ts#L136
As a fix I would suggest using the hasOwnProperty method to avoid iterate over inherited properties, or maybe use Object.keys() and iterate over them to fully avoid for in loop
How to reproduce:
Array.prototype.myFunct = function () { return this; }

const data = [1, 2, 3];
new AngularCsv(data, 'My Report');

// the output will be a CSV file with
// 1, 2, 3, function () { return this; }

For moment, as a hack workaround I override the toString() method for prototype functions:
Array.prototype.myFunct = myFunct;

function myFunct() { return this; }
myFunct.toString = () => '';

Hi @vladrusu04
Can you please send a PR for this?
Thanks


Adds map previews to the new dashboard

This branch adds map previews to the new dashboard using our Static Map API:

the _renderMapThumbnail method requests a thumbnail using the visualization vizjson and updates the default image placeholder with the returned URL.
In case of error, a random error image is shown instead.
Adds lib/assets/javascripts/cartodb/common/map_previews.js to render the previews cards from the new_public_maps.html.erb

Frontend tests were OK :+1: (details)

@xavijam, @viddo: can you please review this PR?

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

Frontend tests were OK :+1: (details)

I've updated the code with your suggestions, @viddo and @javisantana. Could you please review it again?
Last changes

Added custom class to generate the previews (mapcard_preview.js)
Added a new method to return the vizjson path in the vis model.
Removed duplication in the new public dashboard (file entry.js)
Added specs.

Frontend tests were OK :+1: (details)

:ok_hand::ok_hand::ok_hand:

Frontend tests were OK :+1: (details)

:es:

Thanks! :)

Frontend tests were OK :+1: (details)


Dev updates

Blackduck scan failure details
Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/firebolt-certification-suite/4/rdkcentral/firebolt-certification-suite

Commit: 938331f01b738bfc6c60ac04695288feb4cbf2c5

Report detail: gist


Geolocate in Chrome

April 29th marks the update to Chrome 50 Web Browser. Following this update, Google's Geolocate API will no longer support non https sites. Although Heroku makes this a non issue currently, as we are registered as https, any future changes to hosting may result in issues.

https://mobiforge.com/news-comment/no-https-then-bye-bye-geolocation-in-chrome-50


home: reduce MSRV to 1.64

In #12654 the MSRV for home was set to #12654. The actual crate still works fine with 1.64 (except for some warnings about the unrecognized lints key). Though I read the discussion in the original PR (and so I recognize this PR might be controversial), I would like to suggest that for a crate as popular as home (with 9.1M recent downloads) -- and as small/low on change -- IMO it would be nice to be a little more conservative and at the very least avoid bumping the MSRV proactively unless there is a need to do so.
(As a library maintainer of a bunch of very popular libraries, I am pretty unhappy with a N - 2 sliding window approach to MSRV -- asking people to justify an MSRV bump is a good thing IMO especially if the bump is aggressive -- or if you want to do a sliding window, at least be more conservative about the window; at least N - 4, preferably more like N - 6 or N - 8. Most of the libraries I maintain are currently in the 1.61 - 1.63 range.)

(If there is a need to do any legwork to make this work better in CI, I can probably do that work if the idea of this PR is accepted.)

Could you describe the problem you are trying to solve.
For example,

Make dependency updating painless until MSRV-aware resolver is out

This means we specifically need a wider MSRV policy than you, accounting for justification-required MSRV updating which is a variable policy making it difficult to target

Needing a specific change: what?
Reducing risk for if there is a bug, feature, or security fix we need

The problem I'm trying to solve is that I have a downstream library for which I'd like to maintain a less aggressive MSRV. In general, it seems wasteful to restrict a popular library to a higher MSRV than what it really needs, since this in turn restricts all downstream libraries to a higher MSRV than what is actually needed.

Our choice of MSRV does not affect the MSRV of dependents unless except in their risk profile to catastrophic bugs or vulnerabilities.

Our choice of MSRV does not affect the MSRV of dependents except in their risk profile to catastrophic bugs or vulnerabilities.

Because MSRV-aware cargo update will just prevent dependents from getting newer versions of the library? That really seems more like a workaround rather than something to rely on.

Looking back the PR #12381 proposing MSRV for all member packages, we've listed some concerns aware https://github.com/rust-lang/cargo/pull/12381#issuecomment-1668310413. To me, I am fine lowering the MSRV for home specifically, as it is not even released with the standard Rust release. This is documented:

This library is shared between cargo and rustup and is used for finding their home directories.
This is not directly depended upon with a path dependency; cargo uses the version from crates.io.
It is intended to be versioned and published independently of Rust's release system.
Whenever a change needs to be made, bump the version in Cargo.toml and cargo publish it manually, and then update cargo's Cargo.toml to depend on the new version.

In #13167 we opt out home from semver-checks against beta/stable Rust release, so should be fine adding more special treatments.

Keep in mind a lower MSRV for home affects cargo development. We have a PR up where we can't use the latest features in some packages because of our N-2 packages. We also share deps but home only depends on windows-sys.

We have a PR up where we can't use the latest features in some packages because of our N-2 packages

https://github.com/rust-lang/cargo/pull/13254#issuecomment-1885213506 as an example of this.

We have a PR up where we can't use the latest features in some packages because of our N-2 packages

#13254 (comment) as an example of this.

As I said in https://github.com/rust-lang/cargo/pull/13254#issuecomment-1894808631, as far as I know, it is possible to avoid the problem while maintaining a low MSRV, at least for this problem.

:umbrella: The latest upstream changes (presumably #13324) made this pull request unmergeable. Please resolve the merge conflicts.

Keep in mind a lower MSRV for home affects cargo development. We have a PR up where we can't use the latest features in some packages because of our N-2 packages. We also share deps but home only depends on windows-sys.

Maybe we should move home out of this repo to avoid it making Cargo development harder? I'd volunteer to help out as a maintainer.

Maybe we should move home out of this repo to avoid it making Cargo development harder? I'd volunteer to help out as a maintainer.

As there isn't any functionality being blocked from getting the users with older MSRVs, I feel like that time would be better spent on getting this back into the standard library.
I will go ahead and propose we talk about this in the cargo team meeting.

We talked about this in the cargo team meeting.  We understand that home is used by a lot of people.  However, it is also a "mature" crate for their purposes and the latest versions exist mainly for logistical reasons.  From this, we need to weigh out the cost of applying a longer MSRV.  We are skittish about applying a lazy MSRV update policy, especially because of the burden users place on maintainers to justify an MSRV change.  An MSRV policy also has affects on all packages within the repo.  cargo hack exists but excluding private packages only helps with some of the problems.  Overall, the long term solution for this is to get the core function back into the standard library so long as T-libs-api has interest in that (which they seemed to last we saw).
In an effort to balance the different needs, we are willing to extend the N-2 policy to N-4 as a bridge for users while an ACP is being worked on.  This offer is only good so long as the ACP is being actively driven to a resolution or else this turns from a bridge to a general policy.

The logistical reasons are that we've automated when a package must be released based on if there are any changes to the directory because we've had too many times where we incorrectly publish packages from the cargo repo.
We briefly talked about splitting the workspace or moving it to a separate repo but both of those take work and short term efforts and we felt it better to focus on the long term effort, given what seems like a low user impact from this situation.

Well, that's disappointing.

FYI https://github.com/rust-lang/libs-team/issues/372


Application breaking when Zf\Hal is not 1.4

This module uses the getEntity method, but this method only exists in version 1.4.
https://github.com/zfcampus/zf-content-negotiation/blob/1.2.1/src/JsonModel.php#L82
https://github.com/zfcampus/zf-hal/blob/1.4.0/src/Entity.php#L84
https://github.com/zfcampus/zf-hal/blob/1.3.1/src/Entity.php
I believe it should be required not require-dev
https://github.com/zfcampus/zf-content-negotiation/blob/master/composer.json#L44

This module uses the getEntity method, but this method only exists in version 1.4

Prior to the 1.2.0 release of this component, it was using property overloading vs the method itself. We still had zf-hal listed as a dev dependency. This was because the JsonModel would work without the zf-hal classes being present; essentially, those checks would fail, and it would fall through to either generating a JSON-P callback or a JSON payload.
My point is: your diagnosis is incorrect. What we need to do is check to see if the method exists and use it if present, and fallback to the property access if it doesn't; that allows usage with earlier versions of zf-hal.
I'll get a pull request with that ready shortly.


update maven core and compat 3.2.5 -> 3.3.1

Coverage decreased (-0.44%) to 80.53% when pulling c42f3a6d33edb1732891819fd9f1568b5a86d851 on maven-updates into 7864b28da386676d1c1889db2ae5a4d25ae954f7 on master.

Coverage decreased (-0.44%) to 80.53% when pulling 57bde5fbb702019b13cda0bc19b2084602f81546 on maven-updates into 7864b28da386676d1c1889db2ae5a4d25ae954f7 on master.

Coverage remained the same at 80.97% when pulling 7aef2afe2983eb4e472e4e51aa16d07e0d29fedc on maven-updates into 7864b28da386676d1c1889db2ae5a4d25ae954f7 on master.

Coverage decreased (-0.44%) to 80.53% when pulling 5fbd82f747b6514ca216311aa44a622d2458ac2e on maven-updates into 23279a7d027d636ce3a0fa67b780aa5d33587458 on master.

Coverage remained the same at 80.62% when pulling 4db0d84454be8cf43c837a2555d2f8888746e824 on maven-updates into 091424aa3199935f248a5d6c819dd881476df709 on master.


Additions to get-started.md regarding editors and schemas.

I don't like my Linux /website/static/img/docs/schema.png and think a Windows version would be more consistent with the images in the rest of the website, if someone can supply one, please?

Thanks - that's better.


Secret keys stored in CoreData?

I think there's a security flaw. Shouldn't the secret keys be stored in the Keychain instead of a CoreData model which can be extracted from the app and access them with small effort?
Thanks for your great work!

Hi @ricardopereira
Yes, it is a weakness. I do plan to reimplement it with Keychain, but I don't have that time yet.
This project was started as an experimental project at first, it isn't well designed.
With iOS Sandbox, I think the current data security is acceptable if we're not extremely concern about it.


Host logs configuration

Maybe I’m missing something in docs but how can you forward /var/log directories from the hosts to splunk? The container logs are sending fine but not  the local host logs.

You can update your values.yaml to include custom paths, assuming the volume is mounted into the pod...
https://github.com/splunk/splunk-connect-for-kubernetes/blob/eab9ab19617fcd153e47aac417c80727f7edf0e7/helm-chart/splunk-connect-for-kubernetes/values.yaml#L191-L258

So in other words, I need to mount a hostPath volume to the Splunk connect container at the requisite hostPath and then specify the associated container file system path.
Which section in that Config is that?

Or is that the docker section with docker.log?

Hey @vennemp,

So in other words, I need to mount a hostPath volume to the Splunk connect container at the requisite hostPath and then specify the associated container file system path.

yes

Which section in that Config is that?

you need to mound your path using volumeMounts and volumes in https://github.com/splunk/splunk-connect-for-kubernetes/blob/develop/helm-chart/splunk-connect-for-kubernetes/charts/splunk-kubernetes-logging/templates/daemonset.yaml.

I want to add that  host machine's /var/log directory is already mounted. So you only need to add your file to splunk-kubernetes-logging.logs config .
Reference: https://github.com/splunk/splunk-connect-for-kubernetes/blob/develop/helm-chart/splunk-connect-for-kubernetes/values.yaml#L242-L245

Closing the issue for now. Feel free to reopen or create a new one if needed.


Publish meteor-elements in bower

Hello,
Do you plan to publish meteor-elements so it can be installed using bower install meteor-elements?
Now installs using git url

I'm not sure, because this package is "meteor specific", may be create a meteor package to wrap insallation of this bower one is a better solution ?


net: Listen is unfriendly to multiple address families, endpoints and subflows

The following example program:
package main

import (
        "net"
)

func main() {
        net.Listen("tcp", "localhost:8080")
        select{}
}

Currently yields this result:
$ netstat -nl | grep 8080
tcp        0      0 <IP_ADDRESS>:8080          <IP_ADDRESS>:*               LISTEN

While the following result would be optimal:
$ netstat -nl | grep 8080
tcp6       0      0 <IP_ADDRESS>:8080          :::*                    LISTEN
tcp6       0      0 ::1:8080                :::*                    LISTEN

(Note that the first socket is actually dualstack, and bound to ::ffff:<IP_ADDRESS>, but that's less critical than adding the second socket bound to ::1.)
More generally, when you call net.Listen() on a hostname which resolves to multiple IPv4/IPv6 addresses, only the first IPv4 address is selected.  An analogous problem occurs if you Listen("tcp", ":8080") on an operating system that doesn't support dualstack sockets: instead of returning a pair of sockets bound to [::]:8080 and <IP_ADDRESS>:80, you only get IPv4.
The fundamental flaw is that Listen() assumes a single socket, which is a leaky abstraction that's inappropriate for high-level things like example servers, e.g.:
http://golang.org/pkg/net/#pkg-overview
Go should either adapt the Listen() API to support multiple sockets, or if that's not feasible, a new multi-socket API should be introduced, which deprecates Listen() for all cases except simple non-wildcard addresses.

We perhaps need to support this eventually. In that case the new stuff should support not only for dual-stack TCP listeners but for SCTP, MPTCP listeners.
Random thoughts on API:

New interface such as MultiListener seems reasonable
It would also implement Listener interface
Addr method of MultiListener returns a list of addresses, or always returns the first address

Random thoughts on testing:

We can make a small, dedicated testbed network by using builders (even though GCE not support IPv6 yet)
The testbed would also be useful for testing some layer's keep-alive, recovery scenarios

Random thoughts on roadmap:

For now, adding a concrete type into the net package seems wrong
We need to make a easy way to inject external types that implements Conn, Addr interface into the net package for keeping the package small
Most hard part would be to re-plumb runtime-integrated network poller

References:

https://tools.ietf.org/html/rfc6458
https://tools.ietf.org/html/rfc6897

PS: Moreover, I'd want to see what happens with the IP Stack Evolution Program: http://www.ietf.org/proceedings/91/slides/slides-91-iab-techplenary-6.pdf

Is this related issue? #7598

No, #7598 is a simple, Windows-specific investigation; how Windows dual IP stacks behave when we use it.

The correct way to listen for both tcp4 and tcp6 is to leave out the
hostname part.
net.Listen("tcp", ":8080")

A counterpoint to this, as it listens to all interfaces. I have a system which has multiple interfaces, each is dual stack and I need my application to listen to only a single interface. I got caught by issue as I used hostname:9100 (which resolves to IPv4 and IPv6 on the interface) as the most common behaviour for a networking stack which accepts a hostname is to listen on all addresses that the hostname references at application initialization.
Another approach would be to accept the interface name and port (e.g. bge0:9100) and listen to all IPs allocated to the interface at the time of initialization.
It's rare to see software which supports the IPs changing after application start, so no matter whether the name resolution or interface approach is taken, after initial resolution I would expect that it's up to the admin to either reconfigure or restart the application if those changes are required.
Obviously, having a way of telling the system to re-check every X seconds would be a nice to have, but that's far from expected behaviour, whereas resolving all IPs at start is expected behaviour (as can be seen by the large number of references to this issue).

Has anyone written a sane example of multi-listen?

Has anyone written a sane example of multi-listen?

I wrote https://github.com/tsavola/listen, but I'm not too happy about the implementation.

@tsavola With your implementation, what would need to be changed for you to be happy with it?

@tsavola With your implementation, what would need to be changed for you to be happy with it?

Each acceptLoop goroutine accepts underlying connections before they are requested by the application; one or more TCP connections may be established before the application calls Accept. If the listener is wrapped by a connection limiter or such, there might be a long delay before the connection is actually passed to the application--or the connection might never be seen by the application.
I would be happy if the application's Accept call would directly cause the establishment of at most one TCP connection.

I don't expect to tilt the scales much compared to the very impressive selection of open source projects that appear to have run into this, but add my vote to the pile in favor of allowing binding on a hostname or on a network interface name to listen to all associated IPs. It shouldn't be so hard to listen on both an IPv4 and IPv6 address associated with a given hostname (without listening on all interfaces).

as the most common behaviour for a networking stack which accepts a hostname is to listen on all addresses that the hostname references at application initialization.

Do you have any examples of networking stdlibs that behave this way? I agree that the proposed behavior would be an improvement, but unfortunately Node.js doesn't have it either:
Welcome to Node.js v20.3.1.
> require('http').createServer((_, res) => res.end("hi")).listen(3000, "localhost")
; curl <IP_ADDRESS>:3000
curl: (7) Failed to connect to <IP_ADDRESS> port 3000 after 6 ms: Couldn't connect to server
; curl localhost:3000
hi
; cat /etc/hosts
<IP_ADDRESS>		localhost
<IP_ADDRESS>		broadcasthost
::1                          localhost


Automated install running screen again

This adds starting screen in automated_install.sh again. We launch to wait-for-hosts.sh but still allow one to easily catch the VM's booting without having to race the VM's. If one does not have screen installed it falls back to only wait-for-hosts.sh. I needed to get to the VM's quickly to see the step in the installer on which they failed -- screen launching at boot helped me a lot with this.

Oof; forgot to add the kill screen back in to make sure it exits out happily once all VM's start...

In #1242 serial support for VM clusters was slid in; closing this as needless now.


fix(browser): remove support for IE

Removed polyfills, updated browserlist and removed references to cssVars
Fixes #563
Checklist:

[x] The commit messages follow the convention for this project

This may need marking as a breaking change in the commit which is used to generate the semantic versioning. https://github.com/Legal-and-General/canopy/issues/563 details this as a breaking change

This may need marking as a breaking change in the commit which is used to generate the semantic versioning. #563 details this as a breaking change

the actual changes in the pr look good and make sense :-)

Removed polyfills, updated browserlist and removed references to cssVars
Fixes #563
Checklist:

[x]  The commit messages follow the convention for this project

Removed polyfills, updated browserlist and removed references to cssVars
Fixes #563
Checklist:

[x]  The commit messages follow the convention for this project

Nice work @adamdot 👍
Just two things to mention here.

You can also sign your commit. It gives the ability to prove that you are the author of the code change. You can refer to the Github doc https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits
If we come to the conclusion that this is a breaking change then you have to raise a PR to merge into the next branch instead. @aaronBery @paul-request or @owensgit please correct me if I am wrong.

@HarshaDewani

If we come to the conclusion that this is a breaking change then you have to raise a PR to merge into the next branch instead. @aaronBery @paul-request or @owensgit please correct me if I am wrong.

That's right, it does make sense that this is technically a breaking change as it removes support, so some consuming apps may want to know about it before they update.
As Harsha mentioned, our process for breaking changes is to merge them into the next branch where they can be installed in a pre-release version, and then released in the next major version of Canopy, alongside all other breaking changes from the next branch.


Update azure-stack-key-vault-deploy-vm-with-secret.md

Fixed space in example as the indentation was confusing and looked like a nested property.

@anwather : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@anwather  Thanks for noticing this and submitting an update.
#sign-off


Logging improvements

rsyslog: Enable "--mark--" message every 10 minutes to facilitate monitoring of the logging
rsyslog: Enable stats module
logstash: Fix spurious ${[json][someting]} values set by logstash that end up in kibana
Add "rsyslog" and "logstash" Ansible tags to the common tole for updating only those parts

To apply these changes run ansible-playbook site.yml with rsyslog and logstash tags


Bluetooth: Fix deadlock issues when running low on buffers

The first patch is from #16870. The second patch is what I think is a better approach to handling lots of discardable events hogging up buffers that may be needed for other more important events. By allocating these from a separate pool we make sure not to starve the more important buffer pools.
Johan Hedberg (2):
      Bluetooth: Add dedicated pool for HCI_Num_Completed_Packets HCI event
      Bluetooth: Introduce separate pool for discardable events

 drivers/bluetooth/hci/h4.c                         | 11 ++---
 drivers/bluetooth/hci/h5.c                         | 11 +----
 drivers/bluetooth/hci/ipm_stm32wb.c                |  6 +--
 drivers/bluetooth/hci/spi.c                        |  7 +--
 drivers/bluetooth/hci/userchan.c                   | 11 ++---
 include/bluetooth/buf.h                            | 13 ++++++
 include/bluetooth/hci.h                            |  1 +
 samples/bluetooth/mesh/prj.conf                    |  1 -
 samples/bluetooth/mesh/prj_bbc_microbit.conf       |  2 +
 samples/bluetooth/mesh_demo/prj.conf               |  1 -
 samples/boards/nrf52/mesh/onoff-app/prj.conf       |  1 -
 .../mesh/onoff_level_lighting_vnd_app/prj.conf     |  1 -
 samples/boards/reel_board/mesh_badge/prj.conf      |  1 -
 subsys/bluetooth/controller/hci/hci.c              |  4 +-
 subsys/bluetooth/controller/hci/hci_driver.c       |  6 ++-
 subsys/bluetooth/host/Kconfig                      | 21 +++++++++
 subsys/bluetooth/host/hci_core.c                   | 54 ++++++++++++++++++++++
 subsys/bluetooth/host/hci_ecc.c                    |  2 +-
 subsys/bluetooth/host/hci_raw.c                    | 12 +++++
 tests/bluetooth/hci_prop_evt/src/main.c            |  2 +-
 tests/bluetooth/mesh/dbg.conf                      |  1 -
 tests/bluetooth/mesh/friend.conf                   |  1 -
 tests/bluetooth/mesh/gatt.conf                     |  1 -
 tests/bluetooth/mesh/lpn.conf                      |  1 -
 tests/bluetooth/mesh/pb_gatt.conf                  |  1 -
 tests/bluetooth/mesh/prj.conf                      |  1 -
 tests/bluetooth/mesh/proxy.conf                    |  1 -
 tests/bluetooth/mesh_shell/prj.conf                |  1 -
 tests/bluetooth/shell/mesh.conf                    |  1 -
 29 files changed, 121 insertions(+), 56 deletions(-)

Fixes #16864

@xiaoliang314  would you be able to run some tests on this PR? It's a second attempt at solving the deadlocks. The first patch is the same from the original PR for the num_completed_pkts pool, but the second patch is new.

@jhedberg Of course, I will test it next Monday.

https://github.com/zephyrproject-rtos/zephyr/blob/4cd675c59ce75372d258c07a73b3c103407ffd6b/subsys/bluetooth/host/hci_core.c#L3126-L3132
@jhedberg My advertising can't be used. It reports a warning message here. Is this a miss?

@xiaoliang314 that warning comes when the HCI driver does not use bt_buf_get_cmd_complete() to allocated a buffer for a command complete/status event, or if bt_buf_get_cmd_complete() is used but the host doesn't have any pending command to match it with.

@xiaoliang314 since you're not using any upstream HCI driver, rather some modified h4.c (if I understood right), have you looked the changes I've done to the upstream h4.c in this PR?

@xiaoliang314 that warning comes when the HCI driver does not use bt_buf_get_cmd_complete() to allocated a buffer for a command complete/status event, or if bt_buf_get_cmd_complete() is used but the host doesn't have any pending command to match it with.

Sorry, correction: bt_buf_get_cmd_complete() is (after this PR) effectively internal to the host stack. You should just be using bt_buf_get_evt() and it should take care of the rest. What your description sounds like is that you're passing true as the value for the discardable parameter of bt_buf_get_evt() even in the case of a command complete/status event, which is wrong - you should only pass true for advertising reports, and anything else should be false.

@jhedberg Yes, only adversting is marked as true, I have referenced the changes in your PR h4.c

I will revisit your changes to make sure I have not missed

@jhedberg I still can't find the reason, this is my log, for your reference.
bt_hci_core: opcode 0x0c03 pool id 0 pool 0x20009904 != &hci_cmd_pool 0x200099a4
bt_hci_core: opcode 0x1003 pool id 0 pool 0x20009904 != &hci_cmd_pool 0x200099a4

@jhedberg I am very sorry, I am writing wrong. Because my work network is isolated and cannot be copied directly.

@xiaoliang314 any further update? I haven't found anything wrong myself when re-reviewing the PR, however I did make one change to bt_buf_get_evt() it now only allocates from the discardable pool when the event code has first been checked and it isn't one of the critical ones the host stack cares about (num complete, cmd status, cmd complete). This shouldn't make much difference though if the driver is correctly implemented. So if you're still investigating, please try also with the latest version of this PR.

@jhedberg Thank you, it has been resolved. Your PR is working properly


Exclude paths

Hi,
Thanks for a great library. 🌹
I'm using lint-staged to run tslint on typescript files (*.ts) but I'd like to exclude certain directories from being linted.
How can I exclude certain paths from being linted?
Cheers

The best way to do that is to use .eslintignore and TS alternative (not using it, sorry). In this case it won't matter what runner you're using and your files will always be excluded. If you still want to make the exclusion lint-staged specific then check out the minimatch docs. I assume something like !your_path should work

@okonet Have tried using .eslintignore to ignore some .js files, but it didn't work. eslint still tries to fix the ignored config file (webpack.config.dev.js). Any help would be appreciated.
.eslintignore
# Webpack configs
webpack.config.dev.js

.lintstagedrc
{
    'gitDir': '../../../../',
    'linters': {
        '*.js': ['eslint --fix', 'git add']
    }
}

You should probably refer to https://github.com/eslint/eslint documentation. I assume this is because you have your .eslintignore in an unexpected place due to 'gitDir': '../../../../'. Try running eslint on its own and see if it is working without lint-staged.

@okonet Thepackage.json file is in subfolder and .git located at root level that's why I have configured the 'gitDir': '../../../../' this way.I have kept the .eslintignore and package.json under the same folder so the path shouldn't be the problem I believe, I have verified that eslint without lint-staged it does ignores the file as expected in addition to the below message.
 File ignored because of a matching ignore pattern. Use "--no-ignore" to override

"precommit": "eslint --fix  webpack.config.dev.js"

Hmm that's weird. Can you create a repo where I could reproduce it please?

@okonet I'm unable to reproduce this issue now with my current repo as well as in the below new repo I've created to simulate the behavior. I'm not sure what was wrong earlier 😕
https://github.com/karthilxg/lint-staged-precommit

So, can I close this issues then?

Yes!! Thanks for your support.

@okonet how would I use the exclude pattern in minimatch to ignore certain files? I need to ignore compiled files. how should my lint-staged config look? what I want is something like this:
"lint-staged": {
  "linters": {
    "*.js,!public/dist/*.js": [
      "prettier --write"",
      "git add"
    ]
  }
}

However, I don't think *.js,!public/dist/*.js is valid minimatch pattern. Do you know how I could use that?

@tnguyen14 it seems it is not. And the whole discussion about negation patterns doesn't see to make it easier: https://github.com/isaacs/minimatch/issues/65
I think https://github.com/okonet/lint-staged/pull/188#issuecomment-309735299 will be the solution to this. Thoughts?

Yes, I think the solution mentioned in that comment and #201 would be ideal, i.e. providing an array of of patterns for matching.

The proposed solution at https://github.com/okonet/lint-staged/issues/123#issuecomment-315179381 is working to me
{
  "lint-staged": {
    "linters": {
      "*.js,!*.min.js": [
        "prettier-standard",
        "git add"
      ]
    }
}

I'm not sure if something changes in the internal match library 🤔

If anyone like me stumbles upon same issue when trying to exclude some folder from lint-staged scope, here's the solution:
{
  "linters": {
    "!(client)/**/*.{ts,tsx}": ["npm run lint:server --", "git add"]
  }
}

Here lint-staged will run for every .ts or .tsx file in the project except these in root client folder (I've got separate tslint.json for my client files).
Some additional exclude patterns can be found here: https://github.com/mysticatea/cpx/issues/24#issuecomment-285389024.

in case you would like just to specify some path src for example:
    "src/**/*.js": [
      "yarn run pretty",
      "yarn run lint",
      "yarn run test",
      "git add"
    ]
  },```

As of now, is there a solution for this? The ones mentioned above don't work for me.

@vicasas This works;
const ignoredGeneratedFiles = [
  'relative/excluded/path/**/*'
];

const eslintPattern = `!(${ignoredGeneratedFiles.join(',')})*.{js,ts,jsx,tsx}`;

module.exports = {
  [eslintPattern]: ['prettier --write', 'eslint --fix --color', 'git add'],
  '*.{md,json,yml,html,scss}': ['prettier --write', 'git add'],
};


Resolve placeholder in datasource configuration

Fixes #1011 .
Changes proposed in this pull request:

fix an issue where placeholder like ${} in datasource configuration can't be resolved
add integration test case for placeholder resolving

Codecov Report

Merging #1020 into dev will increase coverage by 0.04%.
The diff coverage is 92.3%.

@@            Coverage Diff             @@
##              dev    #1020      +/-   ##
==========================================
+ Coverage   54.93%   54.98%   +0.04%
==========================================
  Files         630      630
  Lines       12325    12349      +24
  Branches     1972     1976       +4
==========================================
+ Hits         6771     6790      +19
- Misses       5142     5144       +2
- Partials      412      415       +3

Impacted Files
Coverage Δ

...c/orchestration/spring/boot/util/PropertyUtil.java
53.84% <92.3%> (+16.8%)
:arrow_up:

...dingsphere/jdbc/spring/boot/util/PropertyUtil.java
53.84% <92.3%> (+16.8%)
:arrow_up:

...ngsphere/opentracing/sampling/SamplingService.java
88% <0%> (-12%)
:arrow_down:

...OrchestrationMasterSlaveDataSourceFactoryBean.java
66.66% <0%> (-11.12%)
:arrow_down:

.../internal/config/ConfigurationListenerManager.java
56.75% <0%> (+2.7%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e42a9a...44060da. Read the comment docs.

thank you for contribute code


Allow Parquet Ingestion To Deal With Files With Missing Attributes

Superseded by https://github.com/kelindar/talaria/pull/77


Detect and process different output formats

Adjust the response element so it conforms to the data being produced; also, allow the custom processing function to return the entire response element, thus truly empowering it.


Pass exceptions out close #377

Coverage decreased (-0.7%) to 78.27% when pulling cb04f8a097583f894d97ce2c70445af95a4e1ae9 on queue-timeout into 87a4cf37cc21d3834e94e8fa3417dec793bb66e5 on master.


Renumber segments [feature request]

I'd like to renumber the segments starting with 01 for the largest segment and proceeding to 99 for the smallest segment, zero-padding on the left with as many 0 as necessary for this particular graph.

I implemented this feature using gfapy. You can close this pull request, unless you'd also like to implement it in gfak.
See https://github.com/ggonnella/gfapy/pull/8


Bugfix for miekg/dns#748

w.msg was being prematurely cleared prior to use by TsigVerify in server.go
Analysis in miekg/dns#748

Codecov Report

Merging #749 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #749      +/-   ##
==========================================
- Coverage   56.18%   56.15%   -0.03%
==========================================
  Files          41       41
  Lines       10796    10798       +2
==========================================
- Hits         6066     6064       -2
- Misses       3643     3646       +3
- Partials     1087     1088       +1

Impacted Files
Coverage Δ

server.go
68.02% <66.66%> (+0.14%)
:arrow_up:

msg.go
77.77% <0%> (-0.63%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5debfee...a8f558d. Read the comment docs.

This is more or less what I’d propose the fix be:
func (w *response) disposeBuffer() {
	if w.udp != nil && cap(w.msg) == srv.UDPSize {
		srv.udpPool.Put(w.msg[:srv.UDPSize])
	}
	w.msg = nil
}

func (srv *Server) serveDNS(w *response) {
	req := new(Msg)
	err := req.Unpack(w.msg)
	if err != nil { // Send a FormatError back
		x := new(Msg)
		x.SetRcodeFormatError(req)
		w.WriteMsg(x)
	}
	if err != nil || !srv.Unsafe && req.Response {
		w.disposeBuffer()
		return
	}

	w.tsigStatus = nil
	if w.tsigSecret != nil {
		if t := req.IsTsig(); t != nil {
			if secret, ok := w.tsigSecret[t.Hdr.Name]; ok {
				w.tsigStatus = TsigVerify(w.msg, secret, "", false)
			} else {
				w.tsigStatus = ErrSecret
			}
			w.tsigTimersOnly = false
			w.tsigRequestMAC = req.Extra[len(req.Extra)-1].(*TSIG).MAC
		}
	}

	w.disposeBuffer()

	handler := srv.Handler
	if handler == nil {
		handler = DefaultServeMux
	}

	handler.ServeDNS(w, req) // Writes back to the client
}

Agreed. I didn't initially understand that the semantics of a sync.Pool "get" is like a "malloc" and "put" is like a "free". Calling out the intent explicitly with a function named "disposeBuffer" makes the intent clearer too.
I've made it a function on the server rather than the message though, since it needs to refer to the server's pool, and UDPSize fields.
I'll add a TSIG query creation/validation unit test to go along with this.


ci: test Node.js 6, 8, 10 and 11

Fails on 6 and 8 due to async / await usage in testfiles.
Should we add node: >= 10 to engines?

Pull Request Test Coverage Report for Build 53

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.275%

Totals

Change from base Build 52:
0.0%

Covered Lines:
131

Relevant Lines:
208

💛  - Coveralls

Pull Request Test Coverage Report for Build 53

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.275%

Totals

Change from base Build 52:
0.0%

Covered Lines:
131

Relevant Lines:
208

💛  - Coveralls


Making concurrent requests

Hi,
First thanks for this project.
It seems that we can't really make concurrent requests, if we open 2 windows and submit  a prompt in each the responses aren't generated simultaneously, the second one has to wait for the first one to finish.
I've tested in the playground and it's not a limitation of openAI's free trial.
Imo it negates the multi user functionality since 2 people can't use it at the same time.

I second to this. May I suggest the project use more than 1 api key to reduce the frequency of concurrent request calls. For example if the first api is being used to fulfil a request, the second api can be used to satisfy the concurrent request.
Or the concurrent request can wait until the first one has been fulfilled.
For consideration please.

I second to this. May I suggest the project use more than 1 api key to reduce the frequency of concurrent request calls. For example if the first api is being used to fulfil a request, the second api can be used to satisfy the concurrent request.
Or the concurrent request can wait until the first one has been fulfilled.
For consideration please.

I agree that concurrent requests is a must, but I don't think it's a limitation of the API, as the point of the API is to be able to use it en-mass, so it's likely something else that's blocking the concurrent request. Adding additional API keys might not solve the issue, and if it did, it'd be more of a work-around than a solution.

I second to this. May I suggest the project use more than 1 api key to reduce the frequency of concurrent request calls. For example if the first api is being used to fulfil a request, the second api can be used to satisfy the concurrent request.
Or the concurrent request can wait until the first one has been fulfilled.
For consideration please.

I agree that concurrent requests is a must, but I don't think it's a limitation of the API, as the point of the API is to be able to use it en-mass, so it's likely something else that's blocking the concurrent request. Adding additional API keys might not solve the issue, and if it did, it'd be more of a work-around than a solution.

Yes it's not, after all the API is also meant to make products from it.
I was thinking about a limitation of the free trial but it isn't either as I said in my original message.

@WongSaang does the latest update fix the concurrent request problem?

https://github.com/WongSaang/chatgpt-ui/releases/tag/v2.3.6
Is this what you're looking for?
spencerwongfeilong @.***> 于 2023年3月30日周四 22:38写道：

@WongSaang https://github.com/WongSaang does the latest update fix the
concurrent request problem?
—
Reply to this email directly, view it on GitHub
https://github.com/WongSaang/chatgpt-ui/issues/100#issuecomment-1490422400,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALAX6FARJU2LE76KV5Y7AGTW6WLE3ANCNFSM6AAAAAAWL3P54M
.
You are receiving this because you were mentioned.Message ID:
@.***>

I was not clear in my question and i apologise.
In the release v2.3.6, the changes are

Support conversation routing, isolating each conversation and supporting simultaneous chat in multiple conversations
Localized prompt support for conversation title generation
Fix some variables with ambiguous naming
What does "Support conversation routing, isolating each conversation and supporting simultaneous chat in multiple conversations" mean?

This means that you can chat in multiple conversations at the same time

@WongSaang
I tried logging in to 2 differents accounts and send different questions to openai.
Both questions were not answered simultaneously. I had the impression that v2.3.6 fixed that.

Are you working in two tabs simultaneously?

Are you working in two tabs simultaneously?

One tab in incognito (account A)
And
One tab in normal (account B)

Hello, after investigation, I found that the issue was caused by the backend service. The backend uses gunicorn for hosting, and by default, it only has one worker. This can cause blocking when multiple requests are made at the same time.
Solution:
An environment variable SERVER_WORKERS has been added to control the number of workers in the backend. The default worker number is 3.
If 3 workers are not enough, you can configure the environment variable under wsgi-server. We recommend setting the number of workers to (2 x $num_cores) + 1, where $num_cores is the number of cores allocated for your container. For example:
backend-wsgi-server:
    image: wongsaang/chatgpt-ui-wsgi-server:latest
    environment:
      - SERVER_WORKERS=5

works great. Thank you!!

👌


Request to add Narasimha Prasanna HN (myself) as mentor

Hi, I would like to volunteer myself as a mentor for the upcoming Hacktoberfest 2021.

Thanks @Narasimha1997


Parser should use dependency injection

JSDoc requires you to provide instances of various things when you create a Parser object. We should use a DI framework to wire this stuff up automatically. (This would also give us a jumping-off point to expose pieces of JSDoc programmatically.)
BottleJS is one DI framework to consider. It's simple, which is nice.

Eh, not sure this would buy us much unless we used it more comprehensively, and I'm not certain that I want to go that route.


Next Greater element (in C++)

💥 Proposal
(A clear and concise description of what the proposal is.)
Have you read the Contributing Guidelines on Pull Requests?
Yes I have read the Contributing Guidelines on pull request.
This algorithm will print the next greater element for all the indices in an array. For the index which has no greater element to the right , -1 shall be printed.
Sample input : 4 5 2 25
Sample output: 5 25 25 -1
I will solve this in O(n) time complexity.

/assign

@ankitaggarwal23 sir please open  this issue now. Both of my issues , that were raised earlier, have been completed. Please allow me to work on this issue.

Create a new one, as it is closed by bot we can't reopen otherwise it again closed


CLI to get/set dask config values

Here's something I think would be nice, since it's often easier to tell people "run this CLI command" rather than "dig around in some YAML files looking for foo and change the value to 123".
dask config get foo.bar  # prints value of foo.bar (or nothing if not set?)
dask config get  # prints entire dask config
dask config set foo.bar 123  # adds/updates foo.bar in the appropriate YAML file

set is trickier than get, because we'd have to pick the right YAML file to write to. Here's the logic I have in mind:

If key already is set in a config, then update value in highest priority config file where it's set.
If key isn't set then... my inclination is to have a default file (maybe dask.yaml, maybe something new like extra-config.yaml) in ~/.config/dask/ where this would go, but maybe also allow something like:

dask config set foo.bar 123 --file ~/.config/dask/my-desired-config-file.yaml

(or maybe you could just give file name and it would always be in ~/.config/dask).
For bonus points, I think it would be handy to have
dask config find foo.bar

which would tell you all the different places (in config search paths) that foo.bar is set.
Note that this relates to/interacts with https://github.com/dask/dask/issues/9702.

Re-opening as the current implementation of set always writes to dask.yaml, whereas the ticket correctly points out that it would be better to write to the correct config file (distributed.yaml etc). This can create problems where the same config key appears, with differetn values, in multiple files inside ~/.config/dask/.

Closed by #10930, please reopen if I'm mistaken. :)


change setup-go actions to be workspace compatible

Codecov Report
Patch and project coverage have no change.

Comparison is base (9e8cde9) 54.66% compared to head (fda48a8) 54.66%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #387   +/-   ##
========================================
  Coverage    54.66%   54.66%
========================================
  Files           24       24
  Lines         1586     1586
========================================
  Hits           867      867
  Misses         653      653
  Partials        66       66

Flag
Coverage Δ

unittests
54.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Merge the src/driver.cpp and python/py_driver.cpp

Merge these two files, to remove unnecessary duplicated codes in two files.
At the same time, we want to decouple codes in driver.cpp, make driver.cpp clean and short. So that, we can create variations of executables (e.g. a separate plan validator executable) easier, without duplicated codes shown in multiple executable entrance files (avoid changing one functionality need to change the same code at several places.)

I merged py_driver.cpp and driver.cpp in the "merge_driver" branch.


Staff adding Management Consideration can add, select concern/opportunity (thus creating an entry) but then unable to add “details”

Make details field editable by staff.

@LisaMoore1 Does that mean this editable field document is inaccurate?

@calebissharp If we are making all content editable on web (like it is on iPad for staff to help AH) then it needs to be editable by staff (like all sorts of other things that show AH on the table you reference but are available for staff CRUD). AHs ONLY get what says Agreement Holder.

@LisaMoore1 So staff should be able to edit everything?

@calebissharp Yes -- definitely in staff draft status.  I couldn't test what those were looking like as I couldn't submit as an agreement holder. We're basically there.

@LisaMoore1 Ok, that's good to know.


Opening/closing accounts that have the same text are all opened/closed at the same time

If 2 linked accounts are in the same squad "expanding" one of them expands both.
If A and B are linked, expanding one results in
> A
> B

to
> A
  B
  Overall
> B
  A
  Overall

with 1 click.

I see it problematic, when two people, that have their account linked to each other, are in the same squad.
But i will fix that error nonetheless :)

This happens to all accounts that are added in the same second. This bug has nothing to do with linked accounts.

Fixed in 2.7.0


Adding VoiceOver Accessibility compatibility.

This is in reference to: #212
I've added some generic Accessibility Labels to the content view for each type. If there is a specific title or subtitle, it will speak that text instead.
Known issue: After HUD is dismissed, the VoiceOver will focus on the first UI element directly behind it (typically right in the center).

Hi, thanks for the PR. Can you upload some screens about what changes with this feature?

@PGLongo funny thing is, there are no visual changes. Only someone using VoiceOver will be able to hear the difference. VoiceOver is an accessibility tool built into iOS that will read out loud what each element on a screen is.
Whenever the HUD is shown, VoiceOver will speak whatever is in the accessibilityLabel.
Below are what I've set the accessibilityLabel to for each HUD type:
        switch content {
        case .success:
            self.accessibilityLabel = "Success!"
        case .error:
            self.accessibilityLabel = "Error!"
        case .image(_),
             .rotatingImage(_):
            self.accessibilityLabel = "Image"
        case .label(let title):
            guard let label = title else { break }
            self.accessibilityLabel = label
        case .labeledSuccess(let title, let subtitle),
             .labeledError(let title, let subtitle),
             .labeledProgress(let title, let subtitle),
             .labeledImage(_, let title, let subtitle),
             .labeledRotatingImage(_, let title, let subtitle):
            guard title != nil || subtitle != nil else { break }
            self.accessibilityLabel = (title ?? "") + "\n" + (subtitle ?? "")
        default:
            self.accessibilityLabel = "Please wait."
        }

The labels aren't ideal in that they don't always present with perfect context (i.e. "Image" tells me nothing), but it's at least a start.


XML files not guessed with .txt extension

Describe the bug
XML file not be guessed when we change the extension or remove the extension
To Reproduce
Steps to reproduce the behavior:

Go to 'OpenRifine'
Click on 'Choose files'
choose the XML file with .txt extension.

Current Results
When I use XML file with .txt Extension :-

Expected behavior
It will work with or without or any extensions.
Desktop:

OS: Ubuntu 18.04
Browser Version: chromium
JRE or JDK Version:  JDK version "11.0.7" 2020-04-14

Looking at your screenshots, you are trying to load a PDF file, not an XML file.

I make changes in the Issue
Please check

@chetan-v It's also helpful to include the Test File that you saw the issue with (attach the .txt file in your first comment on this issue).  Then if you would like to work on this, we can assign this issue to you.

@chetan-v Generally, when you make a new issue that is file related, it is also helpful to include that Test File that you saw the issue with (attach the .txt file in your first comment on this issue). Then if you would like to work on this, we can assign this issue to you.

I got it.
Yes, I want to do that

This is the same bug as #2820, but I suspect you knew that. When you upload your test file, please make sure that it has the name that you intend. Although the anchor text says Test.txt the actual filename is test.xml so it needs to be renamed when downloaded.

This is the same bug as #2820, but I suspect you knew that. When you upload your test file, please make sure that it has the name that you intend. Although the anchor text says Test.txt the actual filename is test.xml so it needs to be renamed when downloaded.

I think, I should close this Issue. it has no meaning Now.


Add history list subcommand to CLI

[Left as draft while some related bug fixes are merged in]
List the most recent entries in the evaluation history log, and allow for filtering of the results.
Note that this does not support fetching results beyond the first page at this time, or applying multiple values to the same filter. That is left as future work.
Fixes #3814
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[x] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[x] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 53.058% (-0.02%) from 53.077%
when pulling 2844741f4009fa7bf9e51f062c6e1c97ad337152 on history-cli-ii
into 9877dba1b0602c4bb38f1ed407b0e67740a20663 on main.


Extended PHP dotenv functionalities with env_or_fail

I would like to discuss about the possibility of having an env_or_fail function that would throw an Exception when the variable is not defined or empty
As a project grows, maintaining the variables become challenging.
Option 1:

function env_or_fail($variableName)
{
    if (!$value = env($variableName)) {
        throw new \Exception("Variable '$value' not defined in the .env");
    }

    return $value;
}

Option 2:
alternatively there could be one file (config) that would be read by the PHP dotenv package (https://github.com/vlucas/phpdotenv) that would allow an extended usage of the package.

$dotenv->required(['DB_HOST', 'DB_NAME', 'DB_USER', 'DB_PASS']);
$dotenv->required('DATABASE_DSN')->notEmpty();
$dotenv->required('SESSION_STORE')->allowedValues(['Filesystem', 'Memcached']);

Option 3:
This would be the proposed config file using the default Laravel Validation (http://laravel.com/docs/5.1/validation)

    // config/env.php
    return [
        'SESSION_STORE' => 'required|sometimes|in:FileSystem,Memcached',
        'APP_ENV '              => 'required|in:production,local',
       // ...
    ]

They don't need to be mutually exclusive and in fairness I think the option 1 and 3 can work well together.

Quick dirty implementation
https://gist.github.com/mathiasgrimm/da38b385bef1be6a6a4e

Probablt just define these in your app, or make a packae.

alright
On 20 November 2015 at 12:02, Graham Campbell<EMAIL_ADDRESS>wrote:

Probablt just define these in your app, or make a packae.
—
Reply to this email directly or view it on GitHub
https://github.com/laravel/framework/issues/11016#issuecomment-158376184
.


k8up sometimes leaves the restic repository with a stale lock

Describe the bug
Occasionally we see backup failures where the restic repository has a stale lock. See below for logs.
Additional context
Once a restic repository gets into this state k8up cannot recover by itself.
The only way to fix it seems to be to manually run restic unlock.
Logs
wrestic/snapshots "level"=0 "msg"="getting list of snapshots"
wrestic/snapshots/restic "msg"="unable to create lock in backend: repository is already locked exclusively by PID 104 on k8up-foo-backup-schedule-check-d6c6d-tpspc by root (UID 0, GID 0)" "error"="error during command"
wrestic/snapshots/restic "msg"="lock was created at 2021-07-04 12:04:01 (17h0m36.860846153s ago)" "error"="error during command"
wrestic/snapshots/restic "msg"="storage ID 23024633" "error"="error during command"
wrestic/snapshots/restic "msg"="the `unlock` command can be used to remove stale locks" "error"="error during command"
wrestic "msg"="failed to list snapshots" "error"="EOF"

Expected behavior
I'd expect that k8up can recover from this situation by itself, but I don't know what the best way to recover would be.
Maybe locks older than some configurable period can be removed by k8up automatically? For example, by default maybe k8up should remove locks older than 12h?
The only problem I see with that solution is that in some edge cases (e.g. lots of data) a backup may genuinely take >12h.
So I guess this should be configurable.
Or maybe there is a better solution altogether?
To Reproduce
I'm not sure how to reproduce this behaviour, but I suspect that it happens when a backup pod is killed instead of being terminated gracefully.
Environment:

Image Version: quay.io/vshn/k8up:v1.0.5 / Wrestic Version: v0.2.3-dirty
K8s Version: v1.18.16-eks-7737de
K8s Distribution: Amazon EKS

Restic itself has an unlock feature. It will cleanup all non-exclusive locks that were not renewed within 5 minutes.
Triggering unlock here right before the first repository action in wrestic should do the trick: https://github.com/vshn/wrestic/blob/master/cmd/wrestic/main.go#L85. Unlock itself is already implemented in wrestic: https://github.com/vshn/wrestic/blob/master/restic/unlock.go. But it looks like i'ts not called where necessary.

I'd expect that k8up can recover from this situation by itself, but I don't know what the best way to recover would be.
Maybe locks older than some configurable period can be removed by k8up automatically? For example, by default maybe k8up should remove locks older than 12h?
The only problem I see with that solution is that in some edge cases (e.g. lots of data) a backup may genuinely take >12h.
So I guess this should be configurable.

@Kidswiss @cimnine Is this something to watch out for?

@ccremer
Restic can handle that on it's own. As long we don't force the cleanup it is save.

It will cleanup all non-exclusive locks that were not renewed within 5 minutes.

Context: a running restic job will renew the lock every 5 minutes. So if a lock has not been updated for that time it's considered stale and will be removed by unlock.

Restic can handle that on its own. As long we don't force the cleanup it is save (there's a flag for that. Also already implemented in wrestic.).

From that I can read that it's safe to unlock, correct?

Yes. This is a regression. Legacy wrestic actually did an unlock very early during a job run.
Something to consider: we should ensure that we only trigger unlock if we're sure there's an initialized repository.


Sort out the embedCONTROL.JS and websocket support.

Productionize the current web socket and webserver support so that it is of a quality I that it could be used inside a product.

This is now getting very close to working for LwIP on STM32, once working there, I will also get working on ESP32 and make a release. These will be the two targets for the first release.

The way it's implemented now is very much like the screen drivers, we can easily add support for more network stacks, and longer term, we can even move all the current ethernet transports to use this layer if it performs significantly better.

This has been moved out to another repo, where I can play around with this and try to get something working, but realistically, I don't think trying to service circa 100K of JS and HTML from an embedded board + a websocket is a good idea any more. I think it's better this is done from say a Raspberry PI or other Linux / Windows server and use the Menu In Menu support to present all local boards through this one server.


transitionConfig doesn't seem to work using screenInterpolator

So I have ttransition config and have transition with screen interpolator, but it doesn't seem to work. Any ideas? I would like to help if you give me an idea where to start searching

const transitionConfig = () => {

    return {
        transitionSpec: {
            duration: 750,
            easing: Easing.out(Easing.poly(4)),
            timing: Animated.timing,
            useNativeDriver: true,
        },

        screenInterpolator: sceneProps => {
            const { layout, position, scene } = sceneProps
            const thisSceneIndex = scene.index
            const width = layout.initWidth
            const translateX = position.interpolate({
                inputRange: [thisSceneIndex - 1, thisSceneIndex],
                outputRange: [width, 0],
            })

            return { transform: [ { translateX } ] }
        },
    }
}

export default Fluid.FluidNavigator(

    {
        LoginScreen,
        RestorePasswordMethodScreen,
        RestorePasswordContactInfoConfirmScreen,
        RestorePasswordNewPasswordScreen,
        RestorePasswordFailedScreen
    },
    {
        transitionConfig: transitionConfig(),
        initialRouteName,
        defaultNavigationOptions: ({ navigation }) => {
            return {
                headerLeft: () => navigation.state.routeName !== initialRouteName ? <Text onPress={() => navigation.pop()}>go back</Text> : <Text onPress={() => navigation.dispatch(DrawerActions.toggleDrawer())}>menu</Text>
            }
        }
    }
);

Fluid Navigator uses its own transition - this is how we drive the shared element and appear/disappear transitions so adding a custom transitionConfig won't work.


fix(footer): add additional slot to support rh-site-status composition

What I did

Added main-tertiary slot to support rh-site-status composition.
Added SlotsController in order to place empty class and display none this new class when there is nothing slotted in the new main-tertiary slot.
Added demo showing rh-site-status composition using this new slot

Closes #1620
Testing Instructions

 View Deploy Preview

Notes to Reviewers

Closing.  After further evaluation, we've decided to compose site-status using the current footer API workarounds: Example: https://codepen.io/zeroedin/pen/rNgYgJq


Utility Tests

resolves #1 and #3
Initial test environment created as well as tests for Utility classes/methods.
Reviewing responsibility: @Cdsspnks96

Implemented Tests are functional, specific error messages not present for certain tests.


Bad state after event creation tx was send

After I clicked on "create event" and submitted the transaction I end up in this state:

which feels like I would create the event again.
Feels like I should end up in some pending state until the event is indexed.
Also the tx is now already more than 10 minutes ago - so it should be indexed already - so maybe something else is going wrong there also:
https://optimistic.etherscan.io/tx/0x8ea878cc6faa84ff9ded4f6affdd642c74486e6153ac4d46d31a2834766c0027

Fixed an issue where the transaction notification failed after creating the event.
I think this prevented further feedback and status/UX updates.


Video and GIF/Animation Support

Is your feature request related to a problem? Please describe.
Lack of video and/or GIF support on the BlueSky platform.
Describe the solution you'd like
Coded so that animation and GIF are supported on the platform.
Describe alternatives you've considered
None
Additional context
None

Duplicate of #1047 and #1052.


Exporting urlQueryDecoder, adding urlQueryEncoder

addUrlProps HOC makes you create a handy configuration, but as of now, this config cannot be reused with another parts of the library.
This PR does 2 things to make this config more useful:

exports urlQueryDecoder.
adds the urlQueryEncoder helper.

Any updates on this?

Hi, thanks for this! I’ve been very busy, apologies for the delay and am in
transit now. If I recall correctly my thoughts on this were:

This is a great idea
This is a very thorough PR, thank you
It could use tests of the decode function and tests where only a subset
of the keys in the config are passed (to both encode and decode)

If you don’t mind adding in those tests, I’m happy to merge. Otherwise we
will have to wait until I have more time.
On Fri, Dec 22, 2017 at 7:41 AM Jakub Korzeniowski<EMAIL_ADDRESS>wrote:

Any updates on this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pbeshai/react-url-query/pull/38#issuecomment-353590991,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAwc97WbrC_BELGWu4vyxblz5TEkH3Tbks5tC6NrgaJpZM4RAuvE
.

Sure, will do that

Upon further inspection, I've got some more questions:

You already seem to have the tests for both urlQueryDecoder https://github.com/pbeshai/react-url-query/blob/master/src/__tests__/urlQueryDecoder-test.js and decode https://github.com/pbeshai/react-url-query/blob/master/src/__tests__/serialize-test.js#L301-L333.
In such case, does it mean I should only add the tests with missing keys?

Please see https://github.com/pbeshai/react-url-query/pull/38/commits/e6848f32f581448d2e69d23a63d2f41103aac60e for the added tests


Check Box Not Working

My Template not support default checkbox where need to change the checkbox

Sorry the english on this is really rough, could you provide a code example on what is the problem?

hi, i have used ivh tree view in my application , i am using beyond admin template for my application, tree view checkbox not showing..

Can you include the template that you are using so we can take a look?


Add zap stanza to vox 3.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

I'm not sure about the workflow for deleting LaunchAgents.
Do cask zap take care of unloading the launchctl entry automatically? Should the plist file in ~/Library/LaunchAgents be deleted in the zap stanza?

uninstall launchctl
https://github.com/caskroom/homebrew-cask/blob/e97dfeb3fd102933186acaedbf496500de42eac5/Casks/gifox.rb#L14

I'll RTFM next time 😄


How to set seccomp to unconfined while starting docker service ?

ARCH : S390X
OS : SLES 12 SP2
I am getting the below error while creating container on SLES using docker-18.03 installed from static binary.
"docker: Error response from daemon: OCI runtime create failed: container_linux.go:265: starting container process caused "seccomp: config provided but seccomp not supported": unknown.
"
I have installed libseccomp dependency and able to create a container by including --security-opt seccomp=unconfined while executing docker run command, but I want to disable seccomp while initializing the docker service itself.
I have tried to do it by passing the same parameter to docker service file but could not start the docker. Please let me know if there is any way.

@chakravarthy392, some remarks from the noob: my gut feeling, that in spite of docker itself, seems, and you can easily prove it with docker info, was built with seccomp enabled, the underlying containerization env was not. The only way, here someone can correct me, is either to build runc with seccomp enabled, replace the docker-runc, shipped with static binaries, and enjoy the default docker's seccomp profile or to avoid static binaries in the way they are available today. If my guess is right, hope, Dockerers will provide fixed binaries some day.

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


[SPARK-16215][SQL] Reduce runtime overhead of a program that writes an primitive array in Dataframe/Dataset

What changes were proposed in this pull request?
This PR optimize generate code of projection for an primitive type array. While we know primitive type array does not require null check and has contigious data region, current generated code performs null checks and performs copy for each element (at Lines 075-082 at Generated code before applying this PR)

Eliminate null checks for each array element
Perform bulk data copy by using Platform.copy
Eliminate primitive array allocation in GenericArrayData when https://github.com/apache/spark/pull/13758 is merged
Eliminate setting sparse index for UnsafeArrayData when https://github.com/apache/spark/pull/13680 is merged

They are done in a helper method UnsafeArrayWrite.writePrimitive<PrimitiveType>Array() (at Line 075 at Generated code after applying this PR).
For now, 3 and 4 are not currently enabled. But, code are ready.
Benchmark program
  def writeArray(iters: Int): Unit = {
    import sparkSession.implicits._

    val iters = 5
    val n = 1024 * 1024
    val rows = 15

    val benchmark = new Benchmark("Read primitive array", n)

    val intDF = sparkSession.sparkContext.parallelize(0 until rows, 1)
      .map(i => Array.tabulate(n)(i => i)).toDF()
    intDF.count() // force to create df

    benchmark.addCase(s"Write int array in DataFrame", numIters = iters)(iter => {
      intDF.selectExpr("value as a").collect
    })

    val doubleDF = sparkSession.sparkContext.parallelize(0 until rows, 1)
      .map(i => Array.tabulate(n)(i => i.toDouble)).toDF()
    doubleDF.count() // force to create df

    benchmark.addCase(s"Write double array in DataFrame", numIters = iters)(iter => {
      doubleDF.selectExpr("value as a").collect
    })

    benchmark.run()
  }

  test("Write an array in DataFrame") {
    writeArray(1)
  }

An example program
val df = sparkContext.parallelize(Seq(0.0d, 1.0d), 1).toDF
df.selectExpr("Array(value + 1.1d, value + 2.2d)").collect

Generated code before applying this PR
/* 028 */   protected void processNext() throws java.io.IOException {
/* 029 */     while (inputadapter_input.hasNext()) {
/* 030 */       InternalRow inputadapter_row = (InternalRow) inputadapter_input.next();
/* 031 */       double inputadapter_value = inputadapter_row.getDouble(0);
/* 032 */
/* 033 */       final boolean project_isNull = false;
/* 034 */       this.project_values = new Object[2];
/* 035 */       double project_value1 = -1.0;
/* 036 */       project_value1 = inputadapter_value + 1.1D;
/* 037 */       if (false) {
/* 038 */         project_values[0] = null;
/* 039 */       } else {
/* 040 */         project_values[0] = project_value1;
/* 041 */       }
/* 042 */
/* 043 */       double project_value4 = -1.0;
/* 044 */       project_value4 = inputadapter_value + 2.2D;
/* 045 */       if (false) {
/* 046 */         project_values[1] = null;
/* 047 */       } else {
/* 048 */         project_values[1] = project_value4;
/* 049 */       }
/* 050 */
/* 051 */       final ArrayData project_value = new org.apache.spark.sql.catalyst.util.GenericArrayData(project_values);
/* 052 */       this.project_values = null;
/* 053 */       project_holder.reset();
/* 054 */
/* 055 */       project_rowWriter.zeroOutNullBytes();
/* 056 */
/* 057 */       if (project_isNull) {
/* 058 */         project_rowWriter.setNullAt(0);
/* 059 */       } else {
/* 060 */         // Remember the current cursor so that we can calculate how many bytes are
/* 061 */         // written later.
/* 062 */         final int project_tmpCursor = project_holder.cursor;
/* 063 */
/* 064 */         if (project_value instanceof UnsafeArrayData) {
/* 065 */           final int project_sizeInBytes = ((UnsafeArrayData) project_value).getSizeInBytes();
/* 066 */           // grow the global buffer before writing data.
/* 067 */           project_holder.grow(project_sizeInBytes);
/* 068 */           ((UnsafeArrayData) project_value).writeToMemory(project_holder.buffer, project_holder.cursor);
/* 069 */           project_holder.cursor += project_sizeInBytes;
/* 070 */
/* 071 */         } else {
/* 072 */           final int project_numElements = project_value.numElements();
/* 073 */           project_arrayWriter.initialize(project_holder, project_numElements, 8);
/* 074 */
/* 075 */           for (int project_index = 0; project_index < project_numElements; project_index++) {
/* 076 */             if (project_value.isNullAt(project_index)) {
/* 077 */               project_arrayWriter.setNullAt(project_index);
/* 078 */             } else {
/* 079 */               final double project_element = project_value.getDouble(project_index);
/* 080 */               project_arrayWriter.write(project_index, project_element);
/* 081 */             }
/* 082 */           }
/* 083 */
/* 084 */         }
/* 085 */
/* 086 */         project_rowWriter.setOffsetAndSize(0, project_tmpCursor, project_holder.cursor - project_tmpCursor);
/* 087 */         project_rowWriter.alignToWords(project_holder.cursor - project_tmpCursor);
/* 088 */       }
/* 089 */       project_result.setTotalSize(project_holder.totalSize());
/* 090 */       append(project_result);
/* 091 */       if (shouldStop()) return;
/* 092 */     }
/* 093 */   }
/* 094 */ }

Generated code after applying this PR
/* 028 */   protected void processNext() throws java.io.IOException {
/* 029 */     while (inputadapter_input.hasNext()) {
/* 030 */       InternalRow inputadapter_row = (InternalRow) inputadapter_input.next();
/* 031 */       double inputadapter_value = inputadapter_row.getDouble(0);
/* 032 */
/* 033 */       final boolean project_isNull = false;
/* 034 */       this.project_values = new Object[2];
/* 035 */       double project_value1 = -1.0;
/* 036 */       project_value1 = inputadapter_value + 1.1D;
/* 037 */       if (false) {
/* 038 */         project_values[0] = null;
/* 039 */       } else {
/* 040 */         project_values[0] = project_value1;
/* 041 */       }
/* 042 */
/* 043 */       double project_value4 = -1.0;
/* 044 */       project_value4 = inputadapter_value + 2.2D;
/* 045 */       if (false) {
/* 046 */         project_values[1] = null;
/* 047 */       } else {
/* 048 */         project_values[1] = project_value4;
/* 049 */       }
/* 050 */
/* 051 */       final ArrayData project_value = new org.apache.spark.sql.catalyst.util.GenericArrayData(project_values);
/* 052 */       this.project_values = null;
/* 053 */       project_holder.reset();
/* 054 */
/* 055 */       project_rowWriter.zeroOutNullBytes();
/* 056 */
/* 057 */       if (project_isNull) {
/* 058 */         project_rowWriter.setNullAt(0);
/* 059 */       } else {
/* 060 */         // Remember the current cursor so that we can calculate how many bytes are
/* 061 */         // written later.
/* 062 */         final int project_tmpCursor = project_holder.cursor;
/* 063 */
/* 064 */         if (project_value instanceof UnsafeArrayData) {
/* 065 */           final int project_sizeInBytes = ((UnsafeArrayData) project_value).getSizeInBytes();
/* 066 */           // grow the global buffer before writing data.
/* 067 */           project_holder.grow(project_sizeInBytes);
/* 068 */           ((UnsafeArrayData) project_value).writeToMemory(project_holder.buffer, project_holder.cursor);
/* 069 */           project_holder.cursor += project_sizeInBytes;
/* 070 */
/* 071 */         } else {
/* 072 */           final int project_numElements = project_value.numElements();
/* 073 */           project_arrayWriter.initialize(project_holder, project_numElements, 8);
/* 074 */
/* 075 */           project_arrayWriter.writePrimitiveDoubleArray(project_value);
/* 076 */         }
/* 077 */
/* 078 */         project_rowWriter.setOffsetAndSize(0, project_tmpCursor, project_holder.cursor - project_tmpCursor);
/* 079 */         project_rowWriter.alignToWords(project_holder.cursor - project_tmpCursor);
/* 080 */       }
/* 081 */       project_result.setTotalSize(project_holder.totalSize());
/* 082 */       append(project_result);
/* 083 */       if (shouldStop()) return;
/* 084 */     }
/* 085 */   }

How was this patch tested?
Added test suites into DataFrameComplexTypeSuite

Test build #61256 has started for PR 13911 at commit b1f6289.

Test build #61256 has finished for PR 13911 at commit b1f6289.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61256/
Test FAILed.

Test build #61262 has started for PR 13911 at commit 333f7b6.

Test build #61262 has finished for PR 13911 at commit 333f7b6.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61262/
Test PASSed.

Test build #61651 has started for PR 13911 at commit 2e8fb0e.

Test build #61651 has finished for PR 13911 at commit 2e8fb0e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61651/
Test PASSed.

Test build #62312 has started for PR 13911 at commit 4b70df9.

Test build #62312 has finished for PR 13911 at commit 4b70df9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62312/
Test PASSed.

Test build #68066 has started for PR 13911 at commit 88aad46.

Test build #68066 has finished for PR 13911 at commit 88aad46.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68066/
Test FAILed.

Test build #68073 has started for PR 13911 at commit 25ddd8e.

Test build #68073 has finished for PR 13911 at commit 25ddd8e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68073/
Test FAILed.

Test build #68140 has started for PR 13911 at commit 6204298.

Test build #68140 has finished for PR 13911 at commit 6204298.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/68140/
Test PASSed.

This was implemented by another approach in #15044


CNN based results

Hi,
thank you for the great work. I read the paper it is very informative. I would like to ask you if you can share also results based on CNN classifier instead of a random forest classifier. As I understand from the paper, you were running couple of classifier experiments on top of the signature features. So I would like to know if combining "signature features" + "a CNN classifier" improves the results.
And I would really appreciate if you can explaing your method for important feature selection.
Thank you!

Thank you for your kind words about the paper!
I don't believe I still have the CNN results I am afraid. However, I can say that it did not perform very well. The final model we used was a RandomForest which, given the sizes of the datasets, was a more sensible choice. All of the deep models performed relatively poorly. This could be due to poor tuning, but more likely the datasets were in general not large enough to warrant their use.
Do you have any specifics regarding important feature selection? I'm not sure what you mean.

Thanks for the answer.
Yes you say that you apply Lasso for the feature selection, can you explain your approach !


example of doing simple inference with lightning

I have an existing model where I load some pre-trained weights and then do inference (one image at a time) in pytorch. I am trying to basically convert it to a pytorch lightning module and am confused about a few things.
So currently, my __init__ method for the model looks like this:
self._load_config_file(cfg_file)
# just creates the pytorch network
self.create_network()

self.load_weights(weights_file)

self.cuda(device=0)  # assumes GPU and uses one. This is probably suboptimal
self.eval()  # inference mode

What I can gather from the lightning docs, I can pretty much do the same, except not to do the cuda() call. So something like:
self.create_network()

self.load_weights(weights_file)
self.freeze()  # inference mode

So, my first question is whether this is the correct way to use lightning? How would lightning know if it needs to use the GPU? I am guessing this needs to be specified somewhere.
Now, for the inference, I have the following setup:
def infer(frame):
    img = transform(frame)  # apply some transformation to the input
    img = torch.from_numpy(img).float().unsqueeze(0).cuda(device=0)
    with torch.no_grad():
        output = self.__call__(Variable(img)).data.cpu().numpy()
    return output

This is the bit that has me confused. Which functions do I need to override to make a lightning compatible inference?
Also, at the moment, the input comes as a numpy array. Is that something that would be possible from the lightning module or do things always have to use some sort of a dataloader?
At some point, I want to extend this model implementation to do training as well, so want to make sure I do it right but while most examples focus on training models, a simple example of just doing inference at production time on a single image/data point might be useful.
I am using 0.7.5 with pytorch 1.4.0 on GPU with cuda 10.1
Thank you for your work and patience with this newbie questions.

Hi @pamparana34 , do you find a way to do simple inference with lightning?


[Doc] update format in streamLoad

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test


Question

Is it possible to use wonder3d's multi-view pretrained weight to produce 3d assets by means of sds?

It think it's feasible. You may refer to paper MVDream for this task.


Unblocking redirection logic

Docs Build status updates of commit 43425a9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/.vscode/settings.json
:white_check_mark:Succeeded

articles/README.md
:white_check_mark:Succeeded

articles/TOC.yml
:white_check_mark:Succeeded

articles/breadcrumb/toc.yml
:white_check_mark:Succeeded

articles/concepts/advanced-matrices.md
:white_check_mark:Succeeded

articles/concepts/circuits.md
:white_check_mark:Succeeded

articles/concepts/dirac-notation.md
:white_check_mark:Succeeded

articles/concepts/index.md
:white_check_mark:Succeeded

articles/concepts/multiple-qubits.md
:white_check_mark:Succeeded

articles/concepts/oracles.md
:white_check_mark:Succeeded

articles/concepts/pauli-measurements.md
:white_check_mark:Succeeded

articles/concepts/the-qubit.md
:white_check_mark:Succeeded

articles/concepts/toc.yml
:white_check_mark:Succeeded

articles/concepts/vectors-and-matrices.md
:white_check_mark:Succeeded

articles/docfx.json
:white_check_mark:Succeeded

articles/index.yml
:white_check_mark:Succeeded

articles/license.md
:white_check_mark:Succeeded

articles/media/1.svg
:white_check_mark:Succeeded

articles/media/2.svg
:white_check_mark:Succeeded

articles/media/3.svg
:white_check_mark:Succeeded

articles/media/4.svg
:white_check_mark:Succeeded

articles/media/5-qubit-qccc.png
:white_check_mark:Succeeded

articles/media/5.svg
:white_check_mark:Succeeded

articles/media/6.svg
:white_check_mark:Succeeded

articles/media/7.svg
:white_check_mark:Succeeded

articles/media/8.svg
:white_check_mark:Succeeded

articles/media/8b.svg
:white_check_mark:Succeeded

articles/media/Broombridge.png
:white_check_mark:Succeeded

articles/media/DLvsQCC.PNG
:white_check_mark:Succeeded

articles/media/ItQPE.png
:white_check_mark:Succeeded

articles/media/ItQPE.svg
:white_check_mark:Succeeded

articles/media/QPE.png
:white_check_mark:Succeeded

articles/media/QPE.svg
:white_check_mark:Succeeded

articles/media/beau.svg
:white_check_mark:Succeeded

articles/media/binder-install.png
:white_check_mark:Succeeded

articles/media/blank.png
:white_check_mark:Succeeded

articles/media/bloch.svg
:white_check_mark:Succeeded

articles/media/bloch2.svg
:white_check_mark:Succeeded

articles/media/circuit_model_1.PNG
:white_check_mark:Succeeded

articles/media/concepts_bloch.png
:white_check_mark:Succeeded

articles/media/concepts_stack.png
:white_check_mark:Succeeded

articles/media/dot_net.png
:white_check_mark:Succeeded

articles/media/draper.svg
:white_check_mark:Succeeded

articles/media/file-extension.png
:white_check_mark:Succeeded

articles/media/git-workflow-step0.png
:white_check_mark:Succeeded

articles/media/git-workflow-step1.png
:white_check_mark:Succeeded

articles/media/git-workflow-step2.png
:white_check_mark:Succeeded

articles/media/git-workflow.vsdx
:white_check_mark:Succeeded

articles/media/grover.png
:white_check_mark:Succeeded

articles/media/hostprograms_command_line_diagram.png
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Removed unused codec methods

Removed unused codec methods. Increased the line coverage from 84% to 87%.
Also, a fix for iqueue to use relevant codec for take method.
Please check related protocol PR for auto generated code changes https://github.com/hazelcast/hazelcast-client-protocol/pull/364

Linux test FAILed.

Linux test FAILed.

Windows test FAILed.

Windows test FAILed.

Linux test PASSed.

Linux test PASSed.

Windows test PASSed.

Windows test PASSed.

Linux test PASSed.

Linux test PASSed.

Windows test PASSed.

Windows test PASSed.


owners: add new maintainers

Description of your changes
Added new maintainers to share the load.
How has this code been tested
N/A

I've added @turkenh @ulucinar @AaronME to the github permissions for this repo with Maintainer access 🎉


conflicting peer dependency requirements between<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

I was using "react-hook-form": "^5.4.2" so when I installed this devtools package via npm install @hookform/devtools -D which resulted in "react-hook-form-devtools": "^1.1.3", but I saw this message:

<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

I wasn't aware my RHF was outdated so then I updated my package.json, ran install, then I saw this:

<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.

So it looks like those 2 have conflicting peer dependency requirements.

for v5, you should keep using react-hook-form-devtools

I'm cool updating to v6 but the mutually-exclusive peerDeps is wrong, isn't it?

you mean<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed?
v6 need v2 because we having breaking change with form state names.

are you still getting that message? that's strange.

confirmed no longer getting the issue. tyvm for helping.


Doesn't generate any sentences other than hello world

Hi,
I've followed all the steps in the Colab notebook. In the end, I wanted to generate my own sentence, like this:
!python -m vall_e 'why this is not working' data/test/test.wav toy.wav

But it always returns errors like this:
Traceback (most recent call last):
  File "/usr/local/lib/python3.10/runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/local/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/content/vall-e/vall_e/__main__.py", line 43, in <module>
    main()
  File "/content/vall-e/vall_e/__main__.py", line 29, in main
    phns = torch.tensor([symmap[p] for p in g2p.encode(args.text)])
  File "/content/vall-e/vall_e/__main__.py", line 29, in <listcomp>
    phns = torch.tensor([symmap[p] for p in g2p.encode(args.text)])
KeyError: 'AY1'

What could be wrong?

The model doesn't know any other phenom pairs. With the default audio, you can try things like "world hello" or "hello hero".

https://github.com/enhuiz/vall-e/issues/22


Error being ignored and silently dropped with raw_query()

I am not sure if I missed something, but it seems that raw_query() ignores all database errors by definition.
I need to use the raw API bindings because I am in a special situation while building Hiqlite, where I built a Raft cluster on top of rusqlite and therefore need to be able to serialize Params and send them over the wire in certain situations, to get the best possible DX and native rusqlite error messages.
As mentioned already I am using the raw API and most things work fine so far (only found one other problem which I will open another issue for). I am now in the situation where I found out, that raw_query() just returns Rows, but not wrapped inside a Result<_> like all other functions. Because of this, I now got stuck at a point where a unique constraint violation from an index is not forwarded, but actually silently dropped and I have no chance of ever seeing this error. I just get empty Rows back, the error is impossible to get.
The only situation where I have to use the raw_query() is with RETURNING, because all other queries can run local.
A short and simplified example of when this issue occurs:
// way above I have `q` defined, which basically is a wrapper to serialize my sql + params

let mut stmt = conn.prepare_cached(q.sql.as_ref()).unwrap();

let mut idx = 1;
for param in q.params {
    stmt.raw_bind_parameter(idx, param.into_sql()).unwrap();
    idx += 1;
}

// here I only get `Rows`, but no `Result` in case of any error like unique constraint
let mut rows = stmt.raw_query();

When I construct a query that violates a unique constraint for instance and execute it manually, it fails (of course), but when I execute the exact same query using the described method, I only get empty Rows and have no idea what happened and why.
So now my question is:
Am I missing something or is there another way of getting the query actually to fail in case an error, or is this just "missing"?

Because Rows is a lazy iterator (a faillible streaming iterator).

Oh yeah, sorry.
I was consuming it with row.next() of course, but used an if let Ok(...). What a bad mistake. ^^
Thanks for the quick answer and sorry for annoying you, should have seen that myself.


Printer settings

This works great with PDF files but is there a way to select which paper tray the printer uses?

Depends on the printer, the file is sent directly to the printer bypassing the printer driver where tray selection would normally be made.
You could insert printer control codes into the stream ahead of the PDF, I'm not sure how that's going to work for your particular printer though.