Animation sheet recorder

Description
This PR adds support for golden-testing animating widgets in an animation sheet.
This does NOT support Web because it uses toImage, which is necessary to build animation sheets but not supported by Web.
The change introduces 2 new APIs:

WidgetTester.pumpFrames, which renders a series of frames with a fixed interval.
AnimationSheetBuilder, which creates a session that can record the painting result of its child, then display them in an animation sheet.

This is an example of testing the animation of an InkWell that is long pressed and then released.

This can be achieved by the following code:
testWidgets('Inkwell animation sheet', (WidgetTester tester) async {
  // Create instance
  final AnimationSheetBuilder animationSheet = AnimationSheetBuilder(size: const Size(48, 24));

  final Widget target = Material(
    child: Directionality(
      textDirection: TextDirection.ltr,
      child: InkWell(
        splashColor: Colors.blue,
        onTap: () {},
      ),
    ),
  );

  // Optional: setup before recording (`recording` is false)
  await tester.pumpWidget(animationSheet.record(
    recording: false,
    child: target,
  ));

  final TestGesture gesture = await tester.startGesture(tester.getCenter(find.byType(InkWell)));

  // Start recording (`recording` is true)
  await tester.pumpFrames(animationSheet.record(
    target,
    recording: true,
  ), const Duration(seconds: 1));

  await gesture.up();

  await tester.pumpFrames(animationSheet.record(
    target,
    recording: true,
  ), const Duration(seconds: 1));

  // Optional: adjust view port size
  tester.binding.setSurfaceSize(animationSheet.sheetSize(width: 500));

  // Display
  final Widget display = await animationSheet.display();
  await tester.pumpWidget(display);

  // Compare against golden file
  expect(
    find.byWidget(display),
    matchesGoldenFile('inkwell.press.animation.png'),
  );
});

Related Issues

Blocks https://github.com/flutter/flutter/pull/50412, which needs an animation test
Affected by https://github.com/flutter/flutter/issues/54511, golden tests yield incorrect result on chrome

Tests
I added the following tests:
Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide

@yjbanov Can you take a look and see if the implementation will work on browsers once #54551 is fixed?
Basically I used RepaintBoundary.toImage to convert the composited result to an ui.Image, and later displays the images in a grid before a final matchesGoldenFile.

Gold has detected about 1 untriaged digest(s) on patchset 13.
Please triage them at https://flutter-gold.skia.org/search?issue=55527.

Gold has detected about 3 untriaged digest(s) on patchset 14.
Please triage them at https://flutter-gold.skia.org/search?issue=55527.

@Piinks I've addressed most comments and replied the rest. Can you take a look?


Support for ingest of imaging data - DICOM

As well as typical relational data, following the implementation of #160 we can ingest any type of file. We should implement a Data Pot template that can ingest DICOM images and store / process them through stages of the datalake.

Suggested requirements for allowing ingress of medical imaging data

Role based access control - users should only be able to access studies and images that they have been given access to
Encrypted transfer of images (DICOM or a compatible API which can transfer linked images and metadata)
Reduce load on hospital imaging systems (Picture Archiving and Communication System [PACS] and Vendor-Neutral Archive [VNA]) by extracting studies and images once and storing in a central location
Users should be able to access the image server in the TRE while data is being uploaded
Imaging module should be optional

improvements on PACS and VNA so this hopefully would have caught up, so could pull more data
would need to be driven by a project
@RichardClarke-dm to go through (existing?) list, or create one and then review the priority for this.


UTF-8 BOM not properly handled

Using Spark 1.4.1 & spark-csv_2.11 version 1.2.0
I have two simple CSV files, address and people, with the following contents.
addrId,city,state,zip
0,sometown,wi,4444
2,bedrock,il,1111
first,last,addrId
your,mom,1
fred,flintstone,2
I load them into DataFrames using:
DataFrame pDf = sqlContext.read().format("com.databricks.spark.csv")
            .option("header", "true")
            .option("inferSchema", "false")
            .option("delimiter", ",")
            .load("/Users/sfelsheim/data/people.csv");

    DataFrame aDf = sqlContext.read().format("com.databricks.spark.csv")
            .option("header", "true")
            .option("inferSchema", "false")
            .option("delimiter", ",")
            .load("/Users/sfelsheim/data/address.csv");

When I try to join pDf and aDf like this:
    DataFrame joined = aDf.join(pDf,
            aDf.col("addrId").equalTo(pDf.col("addrId")));

if fails with this exception:
Exception in thread "main" org.apache.spark.sql.AnalysisException: Cannot resolve column name     "addrId" among (addrId, city, state, zip);
at org.apache.spark.sql.DataFrame$$anonfun$resolve$1.apply(DataFrame.scala:159)
at org.apache.spark.sql.DataFrame$$anonfun$resolve$1.apply(DataFrame.scala:159)
at scala.Option.getOrElse(Option.scala:121)
at org.apache.spark.sql.DataFrame.resolve(DataFrame.scala:158)
at org.apache.spark.sql.DataFrame.col(DataFrame.scala:558)
at dw.dataflow.TestJoin.main(TestJoin.java:81)

If I create DataFrames using the exact same two CSV files like this:
JavaRDD<Person> people = context.textFile("/Users/sfelsheim/data/people.csv").map(
            new Function<String, Person>() {
                public Person call(String line) throws Exception {
                    String[] parts = line.split(",");

                    Person person = new Person();
                    person.setFirst(parts[0]);
                    person.setLast(parts[1]);
                    person.setAddrId(parts[2]);

                    return person;
                }
            });
DataFrame pDf = sqlContext.createDataFrame(people, Person.class);

and
  JavaRDD<Address> address = context.textFile("/Users/sfelsheim/data/address.csv").map(
            new Function<String, Address>() {
                public Address call(String line) throws Exception {
                    String[] parts = line.split(",");

                    Address addr = new Address();
                    addr.setAddrId(parts[0]);
                    addr.setCity(parts[1]);
                    addr.setState(parts[2]);
                    addr.setZip(parts[3]);

                    return addr;
                }
            });
 DataFrame aDf = sqlContext.createDataFrame(address, Address.class);

The join I mentioned above works as I would expect.
Any ideas?
Thanks
Steve

One other note.  In application I am working that this problem came from, I am writing the DataFrame created by the CSV reader to HDFS in Parquet format.  This problem persists even when I read the data back into DataFrames from Parquet.

Is there a leading space in address.csv? I'm wondering if the column name has an extra space character in it, since the spacing in Cannot resolve column name     "addrId" among (addrId, city, state, zip); looks funny to me.

Just found #96, so I wonder if spaces could be the issue.

No, no leading spaces.  Proved this to myself using this code, which works fine.
JavaRDD address = context.textFile("/Users/sfelsheim/data/address.csv").map(
new Function<String, Address>() {
public Address call(String line) throws Exception {
String[] parts = line.split(",");
                Address addr = new Address();
                addr.setAddrId(parts[0]);
                addr.setCity(parts[1]);
                addr.setState(parts[2]);
                addr.setZip(parts[3]);

                return addr;
            }
        });

DataFrame aDf = sqlContext.createDataFrame(address, Address.class);
From:  Josh Rosen
Reply-To:  databricks/spark-csv
Date:  Tuesday, September 8, 2015 at 8:51 PM
To:  databricks/spark-csv
Cc:  Steve Felsheim
Subject:  Re: [spark-csv] DataFrames created using CSV reader failing join (#142)
Is there a leading space in address.csv? I'm wondering if the column name has an extra space character in it, since the spacing in Cannot resolve column name     "addrId" among (addrId, city, state, zip); looks funny to me.
—
Reply to this email directly or view it on GitHub.

The problem seems to be that the CSV was encoded as UTF-8 with BOM.  When I changed the CSV (address.csv) to UTF-8 (no BOM), then it works fine.
Would you like to me to delete issue #142 and create a new one for BOM handling?
Thanks
Steve
From:  Josh Rosen
Reply-To:  databricks/spark-csv
Date:  Tuesday, September 8, 2015 at 8:51 PM
To:  databricks/spark-csv
Cc:  Steve Felsheim
Subject:  Re: [spark-csv] DataFrames created using CSV reader failing join (#142)
Is there a leading space in address.csv? I'm wondering if the column name has an extra space character in it, since the spacing in Cannot resolve column name     "addrId" among (addrId, city, state, zip); looks funny to me.
—
Reply to this email directly or view it on GitHub.

I think that we can repurpose #142 to handle this. Otherwise, feel free to open a new issue and close #142.

+1

So this issue is still there with Scala 2.11.7 and Spark-Core 1.5.2 , databricks 1.3.0.

Just hit this with databricks 1.4, Scala 2.11, spark 1.6.2

Same for Scala 2.11 on Spark 2.0.0 using databricks community edition.
Anyone know of a workaround? I don't have control over the originating csv files so they'll keep coming in this format.

Not clean and perfect and not even tested but I think this might be a workaround.
val UTF8_BOM = "..."
val path = "..."
val csvRdd = sparkContext.textFile(path)
val droppedCsvRDD = csvRdd.mapPartitionsWithIndex { (idx, iter) =>
  if (idx == 0) {
    var shouldStripBom = true
    iter.map { line =>
      if (bomSkipped) {
        if (line.startsWith(UTF8_BOM)) {
          // Here, strip BOM.
          line.substring(1);
          bomSkipped = false
        }
      } else {
        line
      }
    }
  } else {
    iter
  }
}
val csvDf = new CsvParser().csvRdd(sqlContext, droppedCsvRDD)

+1


Reproducing results with multiple GPUs

Hi Yuedong, thank you for open source your great work!
When I trained the model using 3 Nvidia RTX 3090s (batch size 4 per GPU), I got significantly worse results on the re10k.
psnr 22.12379274863242
ssim 0.7298626045353773
lpips 0.22073094525619313

Will fewer batchsize or multi-GPU training significantly affect the performance of the model?
By the way, I use the official weights and can get results consistent with the paper.
psnr 26.386906073201686
ssim 0.8690403559103327
lpips 0.12837660807718004

Hi @RuijieZhu94, thanks for your interest in our work.
Yes, there is a small bug regarding feature extraction due to code cleaning. It is mainly related to (batch, view) dimension conversion, it does not affect the testing since testing keeps batch_size=1. We have already corrected it in our last commit (297338f54d74e7beb4ca5e0700dee22090b836a4).
We have re-trained the model (after fixing the above-mentioned bug) using both single GPU and mutli GPUs configurations, and they both reproduced the results of the released model. Would you mind updating the code following our last commit (297338f54d74e7beb4ca5e0700dee22090b836a4) and re-training the model? Let us keep this commit open for you to update the results. For a quicker debugging process, your model should reach around PSNR=23 at step 10K with the updated code, which is around PSNR=20 at step 10K if it contains the aforementioned feature extraction bug.
By the way, we use batch_size=14 by default (smaller batch_size might slightly harm the performance but should be OK). And the LPIPS weight is 0.05, the lr scheduler is 1cycle with lr=2.e-4, as we have updated in this commit (660f49cb7127166af6221f1df2c0d09606b56270). Make sure you have also synchronised your code base (if you have made any changes) with the aforementioned commits.

Hi Yuedong, thanks for your prompt reply, I will retrain this model in the next few days.

Hi Yuedong, I retrained this model with bs=12, and got the result:
psnr 26.31555430801481
ssim 0.8676635705885196
lpips 0.12932708359573464

Thank you for your help.

Could you share the link of the training dataset? I reach out the author of the pixelsplat for link. However, i can not open the link.

@RuijieZhu94 Could you share the link of the training dataset? I reach out the author of the pixelsplat for link. However, i can not open the link.

@RuijieZhu94 Could you share the link of the training dataset? I reach out the author of the pixelsplat for link. However, i can not open the link.

Please contact me by email<EMAIL_ADDRESS>

@RuijieZhu94  Hi, how can we monitor the training process like a tensorboard? The output folder generated by the code includes some files that I don't know how to use. Especially the *.log files are all empty.


catkin: 0.8.5-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository catkin to 0.8.5-1:

upstream repository: git@github.com:ros/catkin.git
release repository: https://github.com/ros-gbp/catkin-release.git
distro file: noetic/distribution.yaml
bloom version: 0.9.7
previous version for package: 0.8.4-1

catkin
* stop catkin from trying to find C++ libraries if not needed (#1083 <https://github.com/ros/catkin/issues/1083>)
* [Windows] make more relocatable wrapper (#1086 <https://github.com/ros/catkin/issues/1086>)
* suppress FPHSA name mismatch for empy (#1093 <https://github.com/ros/catkin/issues/1093>)

@sloretz Please merge whenever convenient.

@sloretz Please merge whenever convenient.

Roger; holding for rebuild later tonight


Waymo provided poses and feature matched 3D points give far worst reconstruction results.

Firstly, I want to express my appreciation for your exceptional work.
I've been working with your model on a Waymo sequence, using the data provided via Google Drive.I have trained the model on waymo sequence with the provided data from google drive.
In the first stage I obtain the below results.json output
{
"ours_30000": {
"SSIM": 0.9492816925048828,
"PSNR": 34.894405364990234,
"LPIPS": 0.23500429093837738
}
}
and after second stage
{
"ours_30000": {
"SSIM": 0.9568189978599548,
"PSNR": 35.58356857299805,
"LPIPS": 0.21078823506832123
},
"ours_1": {
"SSIM": 0.682416558265686,
"PSNR": 10.946518898010254,
"LPIPS": 0.519730269908905
}
}
However, when I train the same first stage by giving poses as provided in waymo and use colmap to compute the 3D points by feature matching and triangulation. I obtain far worse results for stage 1
{
"ours_30000": {
"SSIM": 0.8782076835632324,
"PSNR": 27.07659149169922,
"LPIPS": 0.277131587266922
}
}
Do you have any idea on why this might be happening?

Hi, thanks for your recognition. Regarding your question, here is some of my thoughts. First, have you aligned the coordinate systems of the pose you input and the point cloud? Second, 3DGS itself makes strong assumptions about camera intrinsic parameters, seemingly independent of the principal point. Is it possible that some parameters in your new input intrinsics were discarded?

I have taken care of them. However, the depth seems to be off? I notice that depth values end up between 0 to 1.2. However, for waymo provided poses the depth should be much higher. Has the depth been normalized. If yes, can you share more details on it?


Feature Differences Link Broken

[Enter feedback here]
The link for feature differences between Table API in Azure Cosmos DB and Azure table storage in top Tips section provided is broken. The correct link is - https://docs.microsoft.com/en-us/azure/cosmos-db/table-api-faq#table-api-in-azure-cosmos-db-vs-azure-table-storage
Link in documentation - https://docs.microsoft.com/en-us/articles/cosmos-db/table-api-faq.yml#table-api-in-azure-cosmos-db-vs-azure-table-storage

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ba460612-aea2-45da-dacb-ddc8324be954
Version Independent ID: 666c7881-ef9d-1595-0c72-2a03a70d8f9c
Content: Design Azure Cosmos DB tables for scaling and performance
Content Source: articles/cosmos-db/table-storage-design-guide.md
Service: cosmos-db
Sub-service: cosmosdb-table
GitHub Login: @sakash279
Microsoft Alias: akshanka

@chirag-singhal Thank you for taking the time to report this issue.
We will fix this at the earliest.

@KalyanChanumolu-MSFT Thank you for this. I was looking at the repo for solving it but couldn't find how the docs are generated from these markdown and yaml files.

@chirag-singhal I have raised a PR and awaiting review from @sakash279
This issue will be fixed once the PR is merged.

@KalyanChanumolu-MSFT  can you point me towards the PR?

And Thank You for fixing this.

@chirag-singhal The PR is on an internal private repo.

@sakash279 Please take the decision on PR https://github.com/MicrosoftDocs/azure-docs-pr/pull/159223 We are assigning this case to you.

@chirag-singhal the above PRs fix the link. Fix will be live tomorrow. We will close this issue.
#please-close


What does YOUR_INPUT_FILE look like? Can you provide an example? Thanks very much!

cd retrieval_lm
python passage_retrieval.py
--model_name_or_path facebook/contriever-msmarco --passages psgs_w100.tsv
--passages_embeddings "wikipedia_embeddings/*"
--data YOUR_INPUT_FILE
--output_dir YOUR_OUTPUT_FILE
--n_docs 20

cd retrieval_lm python passage_retrieval.py --model_name_or_path facebook/contriever-msmarco --passages psgs_w100.tsv --passages_embeddings "wikipedia_embeddings/*" --data YOUR_INPUT_FILE --output_dir YOUR_OUTPUT_FILE --n_docs 20

its script has some problems, it doesn't have --data argument, only has --dataset or --query, you need change it ,and i try to run it just by simple jsonl or json file with questions @XiaozhuLove

@innovation64 Could you please share your json file?

cd retrieval_lm python passage_retrieval.py --model_name_or_path facebook/contriever-msmarco --passages psgs_w100.tsv --passages_embeddings "wikipedia_embeddings/*" --data YOUR_INPUT_FILE --output_dir YOUR_OUTPUT_FILE --n_docs 20

its script has some problems, it doesn't have --data argument, only has --dataset or --query, you need change it ,and i try to run it just by simple jsonl or json file with questions @XiaozhuLove

They may have mistakenly written --data instead of --query. If you use --query YOUR_INPUT_FILE, you can see that it runs correctly, as shown in the image below.


Update all branch aliases to 1.0

This will help us to test and tag new versions

Codecov Report

Merging #175 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #175   +/-   ##
=========================================
  Coverage     80.98%   80.98%
  Complexity      542      542
=========================================
  Files            26       26
  Lines          1383     1383
=========================================
  Hits           1120     1120
  Misses          263      263

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45368d...c8f676b. Read the comment docs.


Migrate from cronjob to systemd timer

Right now we are running create_snapshot.sh using a Cronjob. Instead, let's move this to a Systemd timer, such that we get more robust error handling as well as better logging.
While we are at it, let's also structure this a bit better such that we base this on the git repo.
Checklist

[x] Create a new runtime user (that is part of the docker group)
[x] Check out this repository using the above user
[ ] Create a Systemd Timer that runs the Cronjob from the code repository above (such that we can do a simple git pull to bring in the latest changes)

User added called snapshot and added to docker group.


Commit graph sometimes does not "find" parent

First of all sorry for not responding to #46 anymore, I had a week of from work. Anyway that works now.
However, there is another bug (which if I remember correctly was already in the javascript version).
Sometimes the plugin appears to not find the parent of a commit correctly:

Commit 25b8447 does not have a parent in your plugin (the line goes until the bottom), but in both stash itself and git log it does have a parent (aa1acf3):

This part of the graph is completely "above" the infinite-scroll-AJAX part, so it seems it has nothing to do with that.

Sorry, I think this issue is a duplicate of #6 now I look at it...


Archiving Logs in Multi-IIS-W3WP scenario does not work

Type: Bug
NLog version: 4.4.12
Platform: .Net 4.5.2
Current config (snippet):
        <target xsi:type="File"
                name="FileTarget"
                fileName="c:\data\mylog.log"
                concurrentWrites="true"
                keepFileOpen="true"
                autoFlush="true"
                archiveEvery="Day"
                maxArchiveFiles="25"
                archiveFileName="c:\data\mylog-${date:format=yyyy-MM-dd-HH-mm}.log" />

Application Setting:

Microsoft IIS Version 10.0
Web Application spawns multiple worker processes
All worker processes share single log-file
User permissions are sufficient (sucessfully testet with one worker process)

Result:

Archive file was not created
NLOG Internal Log-File reports:
2017-11-07 01:46:03.1440 Info Archiving c:\data\mylog.log to c:\data\mylog-2017-11-07-01-46.51.log
2017-11-07 01:46:04.2379 Error Cannot archive file 'c:\data\mylog.log'. Exception: System.UnauthorizedAccessException: Access to the path is denied.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.File.InternalMove(String sourceFileName, String destFileName, Boolean checkHost)
at NLog.Targets.FileTarget.ArchiveFile(String fileName, String archiveFileName)
at NLog.Targets.FileTarget.DynamicFileArchive.AddToArchive(String archiveFileName, String fileName, Boolean createDirectory)
2017-11-07 01:46:04.2533 Warn Failed to archive file 'c:\data\mylog.log'. Exception: System.UnauthorizedAccessException: Access to the path is denied.
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.File.InternalMove(String sourceFileName, String destFileName, Boolean checkHost)
at NLog.Targets.FileTarget.ArchiveFile(String fileName, String archiveFileName)
at NLog.Targets.FileTarget.DynamicFileArchive.AddToArchive(String archiveFileName, String fileName, Boolean createDirectory)
at NLog.Targets.FileTarget.DynamicFileArchive.Archive(String archiveFileName, String fileName, Boolean createDirectory)
at NLog.Targets.FileTarget.DoAutoArchive(String fileName, LogEventInfo eventInfo)
at NLog.Targets.FileTarget.TryArchiveFile(String fileName, LogEventInfo ev, Int32 upcomingWriteSize)
This behavior shows every time an existing log must be archived.

Remarks:

Archiving works as expected in single worker process configuration
Logging into log-file from multiple processes works as expected

I think   keepFileOpen="true" won't working with archiving and multi threading.

It seems so that this solves my problem.
Thanks for the fast feedback!

@occcy Could you try this setup, and see if you also get UnauthorizedAccessException ?
    fileName="c:\data\mylog.log"
    archiveFileName="c:\data\mylog-{#}.log"
    archiveDateFormat="yyyy-MM-dd"
    archiveNumbering="Date"
    archiveEvery="Day"
    maxArchiveFiles="25"
    concurrentWrites="true"
    keepFileOpen="true"
    autoFlush="true"

It is a really bad idea to use keepFileOpen="true", if you are logging more than 50 messages/sec. So if the above fails, then I recommend the following config:
    fileName="c:\data\mylog-${date:format=yyyy-MM-dd}.log"
    archiveFileName="c:\data\mylog-{#}.log"
    archiveDateFormat="yyyy-MM-dd"
    archiveNumbering="Date"
    archiveEvery="Year"
    maxArchiveFiles="25"
    concurrentWrites="true"
    keepFileOpen="true"
    autoFlush="true"

I assume your question has been answered, if not, let us know!


[Enhancement] Change Create Resource Group Grammar

Proposed changes
Issue Number: close #20170
<--Describe your changes.-->
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall


Macros with DAE variables not executing

Hi there, I'm trying to have a macro fire when a token enters an aura, applying an effect to that token. I'm doing this in the same way I'd set up a normal DAE macro execution effect, with an attribute key of macro.execute, change mode of custom, and effect value of MacroName @target. However whenever a token enters the aura, I get a warning message saying "No macro + found".
If I'm not mistaken this line is the issue: https://github.com/kandashi/Active-Auras/blob/main/src/aura.js#L223
It seems to be geared specifically for adding variable values to other attributes, but breaks down when used for macro execution. Is there another way I should be trying to do this?

Ahh shoot yeah. I can add a check for this

Ahh shoot yeah. I can add a check for this


Support KubeOVN VPC and Subnet

What this PR does / why we need it:
This PR adds support for KubeOVN subnet and VPC in kubevirt provider.
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?
/kind feature

Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

KubeOVN vpc and subnet support

Documentation:

none

/approve

/lgtm


Abstract events

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Related Issue #
Resolves #

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@coderabbitai summary

@coderabbitai full review


feat(including bugs): minor changes that increases functionality

Hi @sumeshir26,
This is a really great project! Although it has a few glitches(listed below), it's a chance for me to learn some new things too. So, after long research(and switching between computers), I have made a series of minor changes in the source file(main.py) and removed the spec listing from the .gitignore(later on that). I have also generated a newer executable with the TimerX icon you provided in the assets directory. And, I think you don't need the setup.py file anymore since PyInstaller can build everything for you(more on that later).
Now, the glitches are as follows:

You need to click the Play button twice to start the timer.
The timer takes one second to start and the rest 5 seconds as countdown, so reducing the extra second seems like a good idea.
This has been happening for me, but whenever the timer ends, I get a driver error(it doesn't play the audio but my driver's all cool, I can see YT videos, and hear audio content). Does the same happen for you too?

Next, why did I remove the spec file from the .gitignore?
I think you used Pyinstaller the first time you built it. And there is an additional tool with PyInstaller called pyi-makespec, which generates SPEC files for making building the app easier. Basically, clone the repo, get PyInstaller, and run this: pyinstaller main.spec in the root. You get an absolutely smashing executable with the TimerX logo(put it in the root dir to run that, so that it will detect the assets), and it has no consoles open(although, a console might open during errors like running the app from the dist dir due to assets).
So, I'm done here.  I need your opinions on this, and also about the driver error I mentioned above.

@im-coder-lg no, I do not get any driver errors🤔🤔

❤Awsome work! Do you want me to merge?

❤Awsome work! Do you want me to merge?

Well not yet because I am still analyzing the code... The icon seems zoomed in when it's a plain exe... Need to check that, and can you try sharing the original TimerX icon file? Maybe I can try making it into an .ico file and test with that...

@im-coder-lg no, I do not get any driver errors🤔🤔

As expected because you run Windows 11 which has advanced drivers, so I think this could be the time to upgrade to Linux soon... But other than that, great! I just need to find how to make macOS builds and add that here so that Mac users don't need to feel loft alone or also they won't need to install Wine(compatibility layer) to run TimerX...  Will see that tomorrow.

Do you know anyone who has a Mac @sumeshir26? Maybe you can test TimerX's Mac build on that. It seems that you can use py2exe as well as PyInstaller, so if we could get a hand at macOS, we could try building TimerX from the terminal. If it succeeds, we are good on a Mac app file.

The Linux build is failing. I have a Raspberry Pi running Raspbian Buster(Debian 10 for Raspberry Pi) and tried building it. The build started well, but the file doesn't execute. I mean, in Geany, if you execute main.py, it'll throw up an error saying that assets/logo.ico isn't found. Linux doesn't use .ico files, so we need to find a proper icon file for Linux. Think macOS has this same error?

The video is called an Asciicast, used for showing console logs as videos. On the Pi, I have configured it to show a Neofetch result at the beginning to show the OS. That's proof it's Raspbian. After that, I changed the directory to TimerX's dir, showed my branch(fork not the base TimerX), and entered python3 main.py and I ended up with the error. Can you try sharing the original logo image? Maybe I can make macOS and Linux icons from that.

@im-coder-lg the original logo is in the assets/images dir

We got some issues.

The .ico code works only on Windows, which means we need different files+icons for each OS.
The logo doesn't work as a JPEG or as a JPG, it works as a PNG, and the PNG I generated was low-quality. Making an icon is the best idea.
Your about window's icon doesn't work due to the JPEG error, so we need different icons and different files for each OS, which makes 3 main.py files, 3 configurator.py files and 3 main.spec files, which squares the file load.

We need a solution to this soon. I could change the ABout page's icon to a bitmap icon(.ico) but Macs use .icns and Linux uses .icon(I guess). How can we fix this?

I just hopped onto the GAUDC project(that gave me a lot of ideas to implement here) and saw the app/res/icons folder and I saw a horde of icons! And as expected, there was an ICNS. So, Linux seems to have PNGs or SVG images, but you need an ICNS for Mac. So, we hit something here, and maybe I could get a fresh ICNS for Mac. @sumeshir26 does Python recognize OSes? Like, if I run TimerX from source on Linux, will the file  know that it runs on Linux? If it does, we could use if and elif commands to manage the icon issue. And also, if the system is neither Windows nor MacOS or Linux, it will resort to the PNG(for now). Is this possible?

We could use this solution I found in Stack Overflow:
from sys import platform
if platform == "linux" or platform == "linux2":
    # linux
elif platform == "darwin":
    # OS X
elif platform == "win32":
    # Windows...

We also need a requirements.txt so that users get the deps like so: pip install -r rquirements.txt

@im-coder-lg Let me add it real quick..

Wait what? You are adding the code? We need the icon files! An ICNS, a Linux icon file and an improved PNG(no more JPEG, it throws up an error)

It is hard to make an ICNS file. I have used online converters and always fail under that.

@im-coder-lg Let me try to make a icns

Does py2exe support SPEC files? If they do, we could use py2xe for the generation of files and pyinstaller for modifying the SPEC file. Could that be possible?

Mac failed. Maybe we need to use a different build platform for Macs. What about PyInstaller?

@sumeshir26 jackpot. I made the ICNS using an online tool, it's on my device, uploading here now.

The thing is since it was made from the PNG, how'd the quality be?

@im-coder-lg The build fails on line 63 of setup.py

Anyway, i got the icns

Uploding in the assets directory on your fork...

I was about to do the same thing! Hope you made it from the JPEG, because the PNG looked strange as an icon(during my tests)  but anyway, we got the ICNS, we need a Linux icon file.

@im-coder-lg I dont hawe write access

I get this
Maybe you force-push(git push origin branch --force). Change origin and branch to my repo origin(git remote add im-coder-lg https://github.com/im-coder-lg/TimerX.git) and checkout to upgrade

@im-coder-lg As far as I know, linux uses png

@im-coder-lg As far as I know, linux uses png

Same. We need a higher photo quality of the logo.

I sent a collaborator invite to you on my fork, maybe you can accept, switch branches and push the ICNS.

maybe MS Paint had a part of messing this up. I need another PNG and some time. Will report here after Raspbian test.

Im sorry, pushed to the wrong branch

Woah, Linux succeeds, Windows stops and MacOS fails. Kinda similar to my checks upgrade(see Actions tab in my fork)

@im-coder-lg You could possibly test it through WSL

Problem is, my Windows10 PC has a problem, and my only shot, Gitpod is kinda failing.

Let me try

@im-coder-lg Buut... dont we need a .deb or .rpm for linux?

Can't we make it? We could use a third-party executable creator for Linux(Mac+Win needed, can be easily created using the same tool if it allows) and make .deb and .rpm files, right?

Or we could create an AppImage file, they seem to work on Linux.

I found the problem... The build and the dist folders where in the gitignore!

@im-coder-lg The build fails on line 63 of setup.py

About this, well...
https://github.com/im-coder-lg/TimerX/blob/68bdaf5038b6633d271b74496c7ecc6fe686dea0/setup.py#L1-L4
The code is literally four lines, how would it be 63+ lines? Unless the issue is in main.py...

I found the problem... The build and the dist folders where in the gitignore!

Also about this, how would it affect TimerX? We just need to confirm if the build works. I know that Windows works, Linux build does work but the file doesn't(yet) and more issues.

Mac, idk, I need to push changes, made one on my Raspberry Pi(platform icon config) but shut it down before pushing it here.

Force-pushed here so that Raspbian ignores issues and just pushes the change.

The main.py platform code works, but configurtor.py doesn't. Need to investigate.

The taskbar icon does not change😕

Same, but I think I need to try building TimerX from the upgrade branch.

It works in the build. Try building TimerX using PyInstaller.

The macos build fails?

The macOS build fails?

Guess so. If Mac users don't get TimerX, they could use compatibility layers. Hoped to get a Mac build but don't have a Mac... Does Mac use AppImage? If it does, we could use one Linux build for the Mac, that'd work. But the next hurdle is the M1 processors, but it uses ARM. So, if Macs support AppImage, we need an AMD(Intel?) and an ARM(Apple Silicon) build. @sumeshir26 about the About page, why can't we use a separate file? The file doesn't recognise the PhotoImage module.

We need to fix one last thing for now. Configurator.py split. We need the about window to be separate or it should recognise what a PhotoImage line is.

@im-coder-lg I'll try after I get the dark mode working

The icon can be used from the Material Icons library(open-source here on GitHub).

@im-coder-lg What icon?

I think I will just use darkdetct to detect the system theme

@im-coder-lg What icon?

Dark mode toggle.  Make sure to use a lighter shade of black so that users can see things properly.

@im-coder-lg What OS are you on?

Windows 7, but I am hoping to switch to Zorin OS within the next few weeks. I also have a Raspberry Pi running Raspbian Bullseye, the Linux tests I said were from that.

Windows 7, but I am hoping to switch to Zorin OS within the next few weeks. I also have a Raspberry Pi running Raspbian Bullseye, the Linux tests I said were from that.

@im-coder-lg Should I merge?

Idk anyone with a mac

@im-coder-lg Should I merge?

Not yet

Idk anyone with a mac

Same. I hate getting a Hackintosh as a VM, so we need to make Windows and Linux builds only, till you find a person using a Mac. I know I can't find one, but I will try.

What else do you want to add?

@im-coder-lg

Sorry man, I was too busy+had headache, I will push the changes by tonight.

@im-coder-lg No problem 😉 Get well soon…

@im-coder-lg No problem 😉 Get well soon…

Thanks man, got rid of them, happens, now I am ready to get the PR for merge 😀

Whoa. Never expected to see the fact that, once I made breaking changes to configuration.py, and thought I pushed the changes here, the PR is ready for erge

Was

I don’t see any changes?

Well because there are no changes. I thought I made some breaking changes so I asked for time.
The PR is ready for merge.


Increase line-height for  in s

Text in our <code> elements is larger than the default Transport font on OSX, due to it using the Monaco font. This creates a taller formatting box for each line of text it has.
We set a smaller font-size, and line-height in <td>s. This works for Transport but text in <code> sections appears squashed vertically.
This sets the line-height for <code> to match that of content outside tables, to stop it
squashing up.
This has been tested with Consolas (the font Windows uses for <code>) and all other
fallbacks.
Here's an idea of the changes this introduces, viewed on OSX Firefox.
Before

After

I wonder if this is related: https://github.com/alphagov/tech-docs-gem/pull/131

What impact does this have to code elements within paragraphs?

It seems to work OK:

(from Notify's REST API docs.)
Looks like the line-height leaves enough space for the padding on the top and bottom.

I'm still wondering if the reason this has broken is because the relative font units is not working in that area for some reason 🤔

Would you mind adding an example to: http://<IP_ADDRESS>:4567/code.html#code-examples please?

I'm still wondering if the reason this has broken is because the relative font units is not working in that area for some reason 🤔
The text looks a lot bigger than the surrounding regular text.

On smaller screens, the <code> is larger than the normal table text, 15px vs 14px, whatever the monospace font-family. On larger screens, they're both 16px.
I did some testing on the differences in vertical size between the monospace font-families and New Transport.
I measured the height from the ascender to the descender on various combinations, all at 16px, and found:

Monaco and New Transport at 16px were roughly the same
Consolas and New Transport showed some difference with Consolas being about 3px smaller
monospace was the same as Consolas

All was on Firefox on OSX.

I'll try and review this when I get some free time, please ping me if I don't.

I'll try and review this when I get some free time, please ping me if I don't.

Will do 👍


do not always error out while checking for existence of resources

controllers also get reconciles for deletion events and it may happen that resource at api server be deleted first before it being purged from cache and during that time if we error out the reconciliation will never be successful in standard conditions.
fixes: #78

I'm a bit divided b/n where the handling should happen, like, err returned from the load function can't always be same as returned by api server.
To be moved inside the function it needs to copied at a couple of places, pls review.


Clang format pipeline

This PR contains :

A modification to the current pipeline to verify that the files respect the the .clang-format settings
The .clang-format file that the pipeline uses
Modifications for a successful pipeline execution

Please see this PR for a sample execution on our fork

Thank you @nicholaslegrand102


CLIMATE-853 Fixing broken documentation in dap.py and making it PEP8 …

…compliant

This PR addresses issue CLIMATE-853.
I have removed '_' in the function '_current_times_to_date', I have removed this because sphinx does not load any function that starts with underscore in its automodule docstrings, hopefully this should fix it.

Merged build triggered. Test Failed.

This PR is broken @Omkar20895 please fix. If this is part of GSoC (which it is) then please clean it up.
The fixes are simple.

@lewismc this PR was opened way before @jarifibrahim fixed the tests and hence travis-ci build failed then, I have asked @jarifibrahim to cross check it in his local machine, after his 'GO' I will merge this PR. Thanks.

The doc build works fine on my machine. Please rebase and then merge.


Receiving push alerts from unsubscribed channels (iOS)

In some iPhone 6s/6s plus devices (iOS 9.3.3), the push alerts sent through a channel are being received even if the channel is unsubscribed. I am using the latest parse version 1.14.2. These are test devices where we keep installing/uninstalling apps with parse integration.
As we are migrating the apps from parse, the below code is used to unsubscribe all the parse channels :-
PFInstallation *currentInstallation = [PFInstallation currentInstallation];
currentInstallation.channels = [NSArray array];
[currentInstallation saveEventually];

But, still the notifications are received from parse. Is there any parse channel/installation settings that are cached on the device ? Please advise.

Did you solve this? If not, is the Installation + channel updated on the server?


Increment version for storagesync releases

Increment package version after release of Azure.ResourceManager.StorageSync

API change check
API changes are not detected in this pull request.


Element type is invalid; BasePropertyComponent error

Did you find any solutions regarding those two issues:
#https://github.com/SoftwareBrothers/adminjs-upload/issues/25
#https://github.com/SoftwareBrothers/adminjs-upload/issues/4
Javascript Error
Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports. Check the render method of BasePropertyComponent.
See development console for more details...

#https://github.com/SoftwareBrothers/adminjs/issues/605#issuecomment-692706364
Deleting the .adminjs folder seems to have fixed the issue.


image upload resize force to 1800px ?

Laravel Version: 5.5.33
Voyager Version: 1.0.15
PHP Version: 7.0.5
Database Driver & Version: MYSQL - 5.7.12

Description:
When uploading an image (edit profile or post for example), the image is resize to 1800px.. For avatar it seems pretty big :)
Maybe it came from here: #1214 ?
Or a parameter is missing ?
Steps To Reproduce:
Change your profile image and inspect the result uploaded image.
Regards.

This was fixed in #2693. I guess this will be included in the next release of Voyager.
Thank you for reporting!

Ok nice,
It tried with the fix and i confirme it work.
Thanks !


Integrate with ActiveJob via ActiveSupport::Notifications

We could empower the ActiveJob integration with what makes SemanticLogger so special - the payload!
Right now when I add rails_semantic_logger to an application with active_job I have rather useless lines in the log, most probably duplicated by the adapter internal logging. This could/should be improved however.
ActiveJob emits a bunch of useful events via ActiveSupport::Notifications:

perform_start
perform
enqueue_at
enqueue

Events have structured payload which comes handy in the situations you turn to logs(namely when something isn't working well or takes too much time). Unfortunately ActiveJob already have a subscriber for that and it assumes classical logger in place.
https://github.com/rails/rails/blob/master/activejob/lib/active_job/logging.rb
But we can patch it and have the payload nicely integrated. And then do proper filtering by job class, queue or duration. One probably would want to refuse native job adapter logging when this one is setup.
Overriding ActiveJob::Logging::LogSubscriber and re-subscribing to the *.active_job events does the trick.
Pull Request
https://github.com/rocketjob/rails_semantic_logger/pull/87

@reidmorrison what do you think?

Fixed in #87
Well Done. Thank you!


Make C# threadpool compatible with Reactive pattern.

Currently, gRPC C# has a thread pool of 4 threads (hardcoded).

make threadpool size configurable
make sure that if long-running user-defined actions reacts to a grpc event, we eventually don't run out of threads that are waiting on grpc_completion_queue_next.

Probable solution:
Instead of having dedicated threads react to gRPC completion queue events, have a predefined number of Tasks wait for events. If an event is triggered by gRPC, make sure a new Task with completion_queue_next is spawned.
Before doing this, it would be good to collection some numbers on performance to be able verify that this approach doesn't hurt performance.

#6498 exposes thread pool size setting as part of experimental API.

You can use Environment.ProcessorCount for a good default size to start with.
https://msdn.microsoft.com/en-us/library/system.environment.processorcount(v=vs.110).aspx

Yes, the change has been submitted and is part of 0.15.0 release.
The current default is min(4, Environment.ProcessorCount / 2) which seemed to be a reasonable heuristic.


When installing FeatureToggle 4.0.2 to a "classic" .NET 4.6.1 app or library Nuget wants to install 47 other dependencies

I wanted to use FeatureToggle 4.0.2 in our web application, which currently runs on "classic" .NET 4.6.1. However, when I tried to install via the NuGet package manager in Visual Studio 2017, it presented me with a list of 47 other dependencies - all different versions of system libraries relating to .NET Core and .NET Standard - that it wanted to install:

This seems both excessive and unnecessary for a (relatively) simple utility library, as well as being liable to cause problems. Is it possible to build FeatureToggle 4.x.x and later, as per FeatureToggle 3.5.1, in such a way that these dependencies are not required, please?
(In the meantime I will use FeatureToggle 3.5.1 to avoid this issue.)

+1

+1

This is not a FeatureToggle issue, but the way that .NET Standard packages work in .NET 4.6.1 which uses the packages.config style for dependency tracking.
FeatureToggle package depends on FeatureToggle.Common which targets .NET Standard 1.6.1 which will add all the assembly references in "classic" projects.

Thanks for replying @mikanyg - version 5 is likely to be a fully/pure .NET standard library. https://github.com/jason-roberts/FeatureToggle/issues/155

for the time-being, any consuming application can try using the Microsoft.Packaging.Tools.Trimming package


0.21.0 release

A placeholder for the next minor release. Remaining items (feel free to edit or add more):

[x] Finish up the implementation for Cumulative APIs (https://github.com/census-instrumentation/opencensus-java/pull/1856).
[ ] Decide whether to drop event when disrupter queue is full (https://github.com/census-instrumentation/opencensus-java/pull/1837).
[ ] Investigate the issue with Stackdriver exporter (https://github.com/census-instrumentation/opencensus-java/issues/1841).

/cc @paivagustavo

Seems like #1837 is going to take longer than expected because it must be discussed on the opencensus-specs. Can this be delayed to next release? It would help me a lot if the new changes on master get released.

I would suggest that we skip, but with the idea to do a new release sooner that will include that change to not block people that need the non-blocking.

SGTM, we'll hold https://github.com/census-instrumentation/opencensus-java/pull/1837 till next release (which waits on the conclusion of https://github.com/census-instrumentation/opencensus-specs/issues/262). Will do a release without that change first.

Release is done: https://github.com/census-instrumentation/opencensus-java/releases/tag/v0.21.0.


403 Forbidden Error on PUT Request

Hello, I've followed the instructions from Microsoft on setting this up here. When I run locally in debug mode, I'm getting a consistent 403 Forbidden error--
C:\Users\talaniz>nuget push C:\bin\Octopus\DiagnosticsPackage.<IP_ADDRESS>.nupkg -ApiKey test123 -Source http://localhost:53405/nuget Pushing DiagnosticsPackage.<IP_ADDRESS>.nupkg to 'http://localhost:53405/nuget'...   PUT http://localhost:53405/nuget/   Forbidden http://localhost:53405/nuget/ 803ms Response status code does not indicate success: 403 (Forbidden).
I'm using nuget client v.<IP_ADDRESS>6, the Verbosity flag tracestack was not helpful but I wanted to include it here--
C:\Users\talaniz>nuget push C:\bin\Octopus\DiagnosticsPackage.<IP_ADDRESS>.nupkg -ApiKey test123 -Source http://localhost:53405/nuget -Verbosity detailed NuGet Version: <IP_ADDRESS>6 Pushing DiagnosticsPackage.<IP_ADDRESS>.nupkg to 'http://localhost:53405/nuget'...   PUT http://localhost:53405/nuget/   Forbidden http://localhost:53405/nuget/ 444ms System.AggregateException: One or more errors occurred. ---> System.Net.Http.HttpRequestException: Response status code does not indicate success: 403 (Forbidden).    at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()    at NuGet.Protocol.Core.Types.PackageUpdateResource.<>c.<PushPackageToServer>b__19_1(HttpResponseMessage response)    at NuGet.Protocol.HttpSource.<ProcessResponseAsync>d__14 1.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.Protocol.Core.Types.PackageUpdateResource.<PushPackageToServer>d__19.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.Protocol.Core.Types.PackageUpdateResource.<PushPackageCore>d__13.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.Protocol.Core.Types.PackageUpdateResource.<PushPackage>d__12.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.Protocol.Core.Types.PackageUpdateResource.<Push>d__8.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.Commands.PushRunner.<Run>d__0.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.CommandLine.PushCommand.<ExecuteCommandAsync>d__28.MoveNext()    --- End of inner exception stack trace ---    at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)    at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)    at NuGet.CommandLine.Command.Execute()    at NuGet.CommandLine.Program.MainCore(String workingDirectory, String[] args) ---> (Inner Exception #0) System.Net.Http.HttpRequestException: Response status code does not indicate success: 403 (Forbidden).    at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()    at NuGet.Protocol.Core.Types.PackageUpdateResource.<>c.<PushPackageToServer>b__19_1(HttpResponseMessage response)    at NuGet.Protocol.HttpSource.<ProcessResponseAsync>d__14 1.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.Protocol.Core.Types.PackageUpdateResource.<PushPackageToServer>d__19.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.Protocol.Core.Types.PackageUpdateResource.<PushPackageCore>d__13.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.Protocol.Core.Types.PackageUpdateResource.<PushPackage>d__12.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.Protocol.Core.Types.PackageUpdateResource.<Push>d__8.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.Commands.PushRunner.<Run>d__0.MoveNext() --- End of stack trace from previous location where exception was thrown ---    at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)    at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)    at NuGet.CommandLine.PushCommand.<ExecuteCommandAsync>d__28.MoveNext()<---
I am also attaching my webconfig--
Webconfig.zip
A few changes that I made to note--

RequireApiKey was set to true (I'm including this flag in my call when I put)
Packages Path was updated to C:\NugetPackages (I created it in advance)
A "Feeds_AddPackage" tag was added with the value attribute set to "true"
I have tried commenting out and adding in the following lines with the same effect:

 <!-- <add name="ExtensionlessUrlHandler-Integrated-4.0" path="*." verb="GET,HEAD,POST,PUT,DEBUG" type="System.Web.Handlers.TransferRequestHandler" preCondition="integratedMode,runtimeVersionv4.0" />-->```

I see I'm logged in as an anonymous user in my requests, but assumed the API key would allow me to auth. Can someone please take a look and advise if there's something obvious I've maybe missed? Apologies for the messy formatting on the stack, I couldn't get the code formatting to work in multi-line without it turning everything into code formatting unless I switched to single line :(

@talaniz , which version of NuGet.Server are you using? I followed the instructions here: https://docs.microsoft.com/en-us/nuget/hosting-packages/nuget-server with the latest version, and it worked smoothly. Also, I couldn't find a setting called "Feeds_AddPackage", can you provide more details?

@skofman1 Apologies for the delay. I wiped the installation and retried the steps again, this time I was able to push and pull successfully. I'm not sure what happened, but it must have been a user error. Thanks for following up.
Closing out.


What Drives LightRAG's Superiority Over GraphRAG?

Thank you for your excellent work. I still have a few questions I’d like to ask:
After thoroughly reading your paper, I’m still unclear as to why your approach, though similar to GraphRAG, achieves better results. I’d like to understand where the improvements in your method come from.
The comparison between the two in the paper is as follows:
“LightRAG’s Superiority over GraphRAG: While both LightRAG and GraphRAG use graph-based retrieval mechanisms, LightRAG consistently outperforms GraphRAG, particularly in larger datasets with complex language contexts. In the Agriculture, CS, and Legal datasets—each containing millions of tokens—LightRAG shows a clear advantage, significantly surpassing GraphRAG and highlighting its strength in comprehensive information understanding within diverse environments. Enhanced Response Variety: By integrating low-level retrieval of specific entities with high-level retrieval of broader topics, LightRAG boosts response diversity. This dual-level mechanism effectively addresses both detailed and abstract queries, ensuring a thorough grasp of information. Complex Query Handling: This approach is especially valuable in scenarios requiring diverse perspectives. By accessing both specific details and overarching themes, LightRAG adeptly responds to complex queries involving interconnected topics, providing contextually relevant answers.”
The statement, “While both LightRAG and GraphRAG use graph-based retrieval mechanisms, LightRAG consistently outperforms GraphRAG, particularly in larger datasets with complex language contexts. In the Agriculture, CS, and Legal datasets—each containing millions of tokens—LightRAG shows a clear advantage, significantly surpassing GraphRAG and highlighting its strength in comprehensive information understanding within diverse environments,” is more of an observation rather than an explanation of why this is happening. Meanwhile, the sections on “Enhanced Response Variety” and “Complex Query Handling” seem more like optimizations specific to the datasets used, focusing on particular types of queries or features.
I still don’t fully understand why your method outperforms GraphRAG. What exactly leads to this improvement? Also, I didn’t see an ablation study comparing your method directly with GraphRAG. Could you clarify this?
Thanks again!

Hi @HKUDS
Just to be clear the term "light" comes from having a vector DB for Relationships, Entities and Text Units, which makes it faster to retrieve information to answer the queries, right?


Copy change (lodge -> log)

Found in two files.

Thanks. I believe "lodge" is actually intended here though. 😃


[Feature Request] Youtube Stream Notification

I don't think this is in, and I'm not sure what happened to the idea in 2016. If it wasn't possible then, I'm guessing something may have changed because I've seen another bot do it recently. Hopefully, that is the case.
Feature request. Please add Youtube stream notification option for channels.

There are no plans to add it as of right now, you can add that suggestion to the #suggestions channel on the #NadekoLog server when it reopens.

Whatever, I'll just do it myself.


Is there any way to flip the Y coordinate?

Hi there, thanks so much for the wonderful crate!
I am currently using this crate with my ray tracer I'm implementing in Rust, but due to difference in coordinate systems between my ray tracer and OpenGL (possibly), the image comes up as flipped:

Is it possible to have an option to fix this by some configuration option? Thanks again!

Hey and thanks!
While it would be possible to implement such feature I'm not sure if it's worth the added complexity in this case. As the data comes from OpenGL it's possible to flip one of the sign for -y in your projection matrix (I think, not fully sure of your setup) to allow it to be displayed the other way around.
Otherwise a different loop to copy the data row by row backwards would do the trick as well.


Clipboard history

Clipboard history does not work anymore on Ubuntu  22.04.2, Gnome version 42.9, Wayland. The icon shows up in the tray but I get no response when clicking on it.
Describe the bug
A clear and concise description of what the bug is.
How To Reproduce
Versions

PASTE_OUTPUT_HERE
Steps to repro
What causes the crash/bug?
Additional context (if a crash, provide stack trace)
Add any other context about the problem here.

Not actionable.


Day2ops skel

What does this PR do?
Add a new folder for day2ops ref. arch. and a first playbook
How should this be manually tested?
Run the playbook to check the active controller
Is there a relevant Issue open for this?
Nope
Who would you like to review this?
cc: @rlopez133  @dav1x  PTAL

@e-minguez This is great and convenient for me since I need the functionality for my next commit. lgtam, shipit


GSOC | Unit Test added for _raise_for_status function under run.py

I've tested this test in my local and it raises CommandFailedError when check_status is true, returncode is != 0

Can one of the admins verify this patch?

@zmc @kamoltat @amathuria
Do something needs to be done from my end.
There is a job failure while running the pipeline.
https://github.com/ceph/teuthology/runs/6057949717?check_suite_focus=true


Add getPermissionStatus to PagedContacts

Would be very helpful to query if the contacts access is already granted, with out invoking the system's request access dialog.

Added in 1.0.10


Restyled sidebar and columns for 1280px viewport

Asana task: Make Screenplay work in a 1280px wide window
Sidebar has been shrunk to minimum decent-looking width, and columns were adjusted so that widths don't need to be hardcoded but the longest text never gets cut off

Mmm yeah, I agree the buttons look shrimpy at bigger sizes. Guess we'll wait to see what the PIOs see on the reg and adjust sizing and layout


Retrieve a uniform's type and name

UniformType::Enum getUniformType(UniformHandle _handle);
const char* getUniformName(UniformHandle _handle);
May i suggest adding these to the public api. I believe they are really helpful and are straight forward to add. For example i use them to do some focus pocus stuff and have some kind of info of what uniforms my shader has so that i can eventually show them in an editor or smth.
P.s recently i find myself posting here a lot. Sry about that. I just enjoy the library

I would do that by keeping track of all uniforms info in my own code, bgfx imho doesn't need this. It's also an issue because bgfx runs in a separate thread on most  platforms/configurations.

Added, see bgfx::getUniformInfo https://bkaradzic.github.io/bgfx/bgfx.html#_CPPv2N4bgfx14getUniformInfoE13UniformHandleR11UniformInfo


NIFI-1193: Add Hive support to Kite storage processor.

This adds a Hive dataset implementation that shades and minimizes the
classes needed to connect to the Hive MetaStore.
To test this:

Create a table in Hive: create table test (id bigint, s string) stored as avro
Create a simple pipeline: GetFile to ConvertCSVToAvro to StoreInKiteDataset
Configure ConvertCSVToAvro with this schema:

{
  "type" : "record",
  "name" : "test",
  "fields" : [ {
    "name" : "id",
    "type" : [ "null", "long" ],
    "doc" : "Converted from 'bigint'",
    "default" : null
  }, {
    "name" : "s",
    "type" : [ "null", "string" ],
    "doc" : "Converted from 'string'",
    "default" : null
  } ]
}

Configure StoreInKiteDataset to use a dataset URI for the Hive table you created: dataset:hive://metastore-host:9083/test
Drop a CSV file into the GetFile's directory:

1,hello
2,world

Validate the data shows up in the test table: select * from test;

Ryan,
Definitely appreciate you trying to make it less size prohibitive.  I think we'll want to avoid having shaded jars and such being utilized for this.  It complicates the licensing and related concerns and we have done an extremely good job getting those clean even to the point of every binary artifact we produce (nars) having embedded license/notice data correct to all sub-dependencies.
This is an area which really highlights our need to tackle the extension registry.  We need to, on the other side of this release, figure out how we as a community can get more agility for releasing extensions like this versus the core framework.
OlegZ: We do need to tackle any copyright assertions on contributed source and ensure all proper license and notice adherence occurs.  I'm overly generalizing here but there are like maybe five people on earth (I'm looking at you Sean Busbey) that care about following the strict guidance of licensing and notices at the level we do.  In basically every contrib that brings in dependencies we'll have to help others most likely.  Feels like a fine trade in exchange for contributions of helpful things the community will benefit from.
We also need to ensure that there is appropriate testing.  However, above all else we need to keep in mind this community is powered by contributions.  So in every exchange let's make sure our discussions stay focused on helping folks bring contribs along.  As specific example consider the lack of unit tests.  We could as part of the review build them.  Or as part of the feedback ask if there are ideas on how to include some.  Some extensions and contributions are inherently really hard to unit test.  I don't know if this one is or isn't.  Adding unit tests or asking if unit tests can be included is more powerful than saying we can't accept the contrib without them.  The difference can at times be subtle but the effect on the community and tenor of discussion can be dramatic.
So far everyone in the community has done an awesome job of helping each other find the middle ground on contributions so that we can be inclusive and encouraging while increasing quality as well.
Thanks
Joe

@rdblue I'm guessing that you used the shade plugin due to the hive-exec jar embedding so many libraries in unshaded package names?
If so, I've got a pom that pulls in direct dependencies that can talk to the Hive metastore without the hive-exec jar. Let me know if that would help here.

yes pleas @joey

@joey, that's exactly the problem. If you have a solution that avoids hive-exec, that would be great!

@rdblue @joey @busbey maybe we just don't add the nar to the assembly itself but put this in the source tree.  Once we get a template/extension registry built then this is ok anyway.  What do you think?

Here's what we've been using to avoid hive-exec:
   <dependency>
      <groupId>org.apache.hive.hcatalog</groupId>
      <artifactId>hive-hcatalog-core</artifactId>
      <exclusions>
        <exclusion>
          <groupId>com.google.code.findbugs</groupId>
          <artifactId>jsr305</artifactId>
        </exclusion>
        <exclusion>
          <artifactId>jersey-servlet</artifactId>
          <groupId>com.sun.jersey</groupId>
        </exclusion>
        <exclusion>
          <artifactId>jersey-core</artifactId>
          <groupId>com.sun.jersey</groupId>
        </exclusion>
        <exclusion>
          <artifactId>jersey-server</artifactId>
          <groupId>com.sun.jersey</groupId>
        </exclusion>
        <exclusion>
          <artifactId>servlet-api</artifactId>
          <groupId>javax.servlet</groupId>
        </exclusion>
        <exclusion>
          <artifactId>jetty-all</artifactId>
          <groupId>org.eclipse.jetty.aggregate</groupId>
        </exclusion>
        <exclusion>
          <groupId>org.apache.hive</groupId>
          <artifactId>hive-exec</artifactId>
        </exclusion>
        <exclusion>
          <artifactId>parquet-hadoop-bundle</artifactId>
          <groupId>com.twitter</groupId>
        </exclusion>
      </exclusions>
    </dependency>


Some major changes to the project

I want to make some major changes to the project and want community feedback on them.

Option to mux video and audio only after the recording has finished.
Most of the synchronisation and pipe broke errors can be avoided in this way.
This would add some waiting time after recording before a video is ready.

Removing the FFmpeg writer and making it post-processing only
Once the Media Foundation writer is well tested, I would like to limit FFmpeg support for encoding to different formats after recording is finished.
The reason being many users are reporting Pipe Closed exception with FFmpeg.
The way it is implemented in Captura causes a lot of CPU usage.
This will fix #220, #243, #330, #352
EDIT: The performance is somewhat improved by converting to YUV or NV12 using GPU (VideoProcessor MFT) before passing the frames to FFmpeg. #411

~Making NAudio the default audio library
The current default is BASS. I would still keep an option to switch to BASS for anyone who needs that. But, since NAudio is open-source too, it would be better to make it default.
Also, I think the way I've implemented BASS support is causing problems for some users.
This might fix #224~

Simplified UI
A prototype:

I would like to organize the settings better.

Specifying overlay size and position in percentages
This would cause them to adapt to the size of the recording.
Currently, the webcam overlay needs to resized every time for a recording of a different size.

Done

Moving to .Net 4.7.2 #403
Region selector made drag and select type.
Basic implementation FFmpeg post-encoding writers
Removed BASS support. Uses NAudio.

Great, I support your ideas, I makes that captura is an excellent software to record the screen, and it must go in constant evolution.
I thank you for your time dedicated to the development of this software and also for making it open source (free)

Many of these things I can't really speak to but I do like 3 and 4 - the UI looks really sharp and like the NAudio shift just to get more time and energy put towards open toolsets.

I am looking at Captura and I really like the ease of getting started.  Is there a way to change the size of the webcam video which is nicely embedded in the screencast.  A little smaller would be great.  Thanks

@ekaplan323 Go to Settings / Overlays / Webcam.
There you can find option for webcam size.

HOW DO I STREAM ON YOUTUBE AFTER UPDATE???


helmConfig has no s

this is goofy, but this PR is exhibiting a dryrun bug in CI.  I have no idea why.  I'll poke it a bit.

It just needs rebased on the non-broken dryrun code.

okay, its running now.  weird though, I didn't see a git history for this branch that had the busted dryrun code in it.  my eyes they are a-failin?

I had rebased on master, originally, when a broken dryrun patch had been self-merged into master by a developer who shall remain nameless. Until this morning I had not rebased again after the revert.

Manual override:  have seen all steps in process succeed but not at once.  Failures are obvious jenkins issues or known k2/e2e flakes.  Merging.


help  for tuple Invalid use of Function(<class 'tuple'>) with argument(s) of type(s): (list(([unichr x 35], float32, int64, float32)))

Hi ,
I have function:
def Search(compare_desc):
    tupZ = [('reft', 18.265, 100, 0.1)]
    # tupZ = tuple(tupZ)
    for x in range(people_names_np.shape[0]):
        dist = np.sum(np.square(compare_desc - _desc_np[x]))
        # print(x)
        ##ChangindTO List

        if dist < 1.00:
            tmp_tupXX = [(_names_np[x], float(dist), x, sim)]
            tmp_tupXX = tuple(tmp_tupXX)
            tupZ = tupZ + tmp_tupXX
    return tupZ

this code gives error:
> Failed in nopython mode pipeline (step: nopython frontend)
Invalid use of Function(<class 'tuple'>) with argument(s) of type(s): (list(([unichr x 35], float32, int64, float32)))
 * parameterized
In definition 0:
    All templates rejected with literals.
In definition 1:
    All templates rejected without literals.
This error is usually caused by passing an argument of a type that is unsupported by the named function.
[1] During: resolving callee type: Function(<class 'tuple'>)
[2] During: typing of call at /Users/alpullu/Projects/new_/insightface/deploy/FAST-mqt-production-RemoteCam.py (97)

File "x.py", line 97:
def Search(compare_desc):
    <source elided>
            tmp_tupXX = [(_names_np[x], float(dist), x, sim)]
            tmp_tupXX = tuple(tmp_tupXX)
            ^

This is not usually a problem with Numba itself but instead often caused by
the use of unsupported features or an issue in resolving types.

To see Python/NumPy features supported by the latest release of Numba visit:
http://numba.pydata.org/numba-doc/dev/reference/pysupported.html
and
http://numba.pydata.org/numba-doc/dev/reference/numpysupported.html

For more information about typing errors and how to debug them visit:
http://numba.pydata.org/numba-doc/latest/user/troubleshoot.html#my-code-doesn-t-compile

If you think your code should work with Numba, please report the error message
and traceback, along with a minimal reproducer at:
https://github.com/numba/numba/issues/new

how can I use tupple and edit inside the jit?
any idea?

Thanks for the report. I think the issue is that using tuple as a constructor is not supported at present.

What is your advise ? I need to return a list of tuple or similar may be list after return I can convert again to tuple for sorting.

I think you may be better off with lists, but without a minimal working example, including example input, it is quite hard to advise.


fix(versions): update Activiti/activiti-cloud-full-chart-security versions

UpdateBot pushed helm dependency: activiti-cloud-full-example to: 7.1.143

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-full-example 7.1.143


about the button of time range

As the figure shows, I choose the time range is 3d, while the buttons of 7d and 14d do not work. That is to say, the time range can only be narrowed, not expanded. The only way to show the larger time range is reloading the data. Besides, it would be better if the selected time range button is highlighted.
@ldp12416

Hello, the latest version has been fixed, please update the code, if there are problems, I will continue to follow up, thank you


feat(TFD-3109): Improve PythonRow performances by pre-compiling python.

What is the current behavior? (You can also link to an open issue here)
The python row is slow
What is the new behavior?
The time of computation of the python row is now reduced to a third of the previous execution time by compiling the python code during the setup phase.
This is done by creating a python definition with the user code, compiling this definition into python bytecode and use this bytecode instead of a string.
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features) ?
[x] The code coverage on new code >75%
[x] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:
Sonar results


Crash in CCheaterDetection::ReportDamage()

Fedoraware Version Date: dd38d62
Windows Version:  W10 Pro 1909
Configs used:
visuals.txt
functions.txt
Description:

Game randomly crashed while running CCheaterDetection::ReportDamage, tabbed out, and while the game was still in freezecam view.
video

The attacker index was also unusually high at 510, maybe it's a map object?

its a userid

I::ClientEntityList->GetClientEntity(I::EngineClient->GetPlayerForUserID(pEvent->GetInt("attacker")))
should fix this

player_hurt
Note: When a player is hurt

Name:
player_hurt

Structure:
short  userid  victim   short  health  victim health   short  attacker  attacker   short  damageamount  damage amount of victim take damage   short  custom     bool  showdisguisedcrit  if our attribute specifically crits disguised enemies we need to show it on the client   bool  crit  if has crit on fire or hurt with crit   bool  minicrit  if has minicrit on fire or hurt with minicrit   bool  allseecrit     short  weaponid  weapon id of attacker   byte  bonuseffect

short
userid

short
health

short
attacker

short
damageamount

short
custom

bool
showdisguisedcrit

bool
crit

bool
minicrit

bool
allseecrit

short
weaponid

byte
bonuseffect


Implement deep linking on Program Dashboard

Description
LEARNER-7010

Implement the deep linking on Program dashboard.
Create a custom method named onNewIntent in BaseFragment that mock the behavior of Activity.onNewIntent(Intent), and used to pass the data to the fragment.

@miankhalid Please review this PR.

@miankhalid Ready for the next pass.

LGTM 👍 Once PR #1262 is merged in master and this branch is rebased on master I'll give this PR another pass.

@miankhalid Ready for another pass.


Does not work in a gradle project bug:

Did you check docs and existing issues?

[X] I have read all the plugin docs
[X] I have searched the existing issues
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.9.5 Build type: Release LuaJIT 2.1.1702233742
Operating system/version
Archlinux 6.7
Describe the bug
I installed the plugin with LazyVim using the provided instructions, but when I arrive on my gradle project the plugin launch but once it has started I have errore everywhere as if  my code is wrong even though it is just a hello world in java. The java.utils package are marked as not recognise, String cannot be resolved to a type, etc. What it is weird is the fact that it provide autocompletion but in the ui have error and I cannot launch using JavaTestRunCurrent... It throws error
Steps To Reproduce
Opening a simple java file
Expected Behavior
I expect it to work and that i can be able to launch using JavaTestRunCurrentClass on a gradle project

@MxDx Is this still the case? Could you please re-open the issue and send the logs. It's in ~/.local/share/nvim location. nvim-java.log & nvim-java-core.log


Implement additional gemini backend

see https://ai.google.dev/gemini-api/docs/models/gemini

workaround: use a proxy such as https://github.com/zhu327/gemini-openai-proxy

Regarding https://developers.googleblog.com/en/gemini-is-now-accessible-from-the-openai-library/
Content safety settings are not supported via Gemini's OpenAI chat completion API, as shown in the example at https://www.reddit.com/r/GoogleGeminiAI/comments/1ffb4by/is_there_a_way_to_change_the_safety_settings/

Consider a workaround, such as a proxy, that turns off the content safety settings by default.
For example:
gemini-openai-proxy at https://github.com/zhu327/gemini-openai-proxy/blob/559085101f0ce5e8c98a94fb75fefd6c7a63d26d/pkg/adapter/chat.go#L230-L246
and
litellm at https://github.com/BerriAI/litellm/blob/70aa85af1fc01d30934ee71a703b8d3982420d05/litellm/llms/vertex_ai_and_google_ai_studio/vertex_ai_non_gemini.py#L203-L213
The above nuances are better suited for projects that act as proxies, such as gemini-openai-proxy, litellm, etc.
Adding a Gemini backend to hackingBuddyGPT would require ongoing maintenance to adapt to continuously evolving changes in Gemini's API, which is in beta (v1beta) rather than OpenAI's non-beta (v1) API.
For instance, maintainers and contributors might spend time trying to understand and justify why Gemini v1beta offers an OpenAI chat completion API but does not fully support content safety settings:

https://www.reddit.com/r/GoogleGeminiAI/comments/1ffb4by/is_there_a_way_to_change_the_safety_settings/
https://www.reddit.com/r/LocalLLaMA/comments/1gn3zhh/gemini_is_now_accessible_from_the_openai_library/

In conclusion, using proxies is a more sensible approach, given the current state of the Gemini v1beta API, as it helps avoid the overhead of adapting to its ongoing changes.

Relates to Mac target localhost container via gemini openai proxy https://github.com/ipa-lab/hackingBuddyGPT/pull/94


docs(paeckchen): add build and contrib docs

Coverage remained the same at 100.0% when pulling 584a00b46683fefe77cc3b9a8068767329bf85f8 on docs/readme into 62461a63e2dea23f51465714bf38cb222bd41aa7 on master.


Allow editor.scrollBeyondLastLine to specify number of lines past end

Issue Type: Feature Request
The option editor.scrollBeyondLastColumn allows you to specify the number of additional characters worth of scrolling to allow and defaults to a sane value.
I'd like to be able to specify a value for editor.scrollBeyondLastLine similar to editor.scrollBeyondLastColumn.

/duplicate of #97561 which needs upvoting to get onto Backlog


Don't know if this is related, but I'm having a similar issue with dotnet-sdk-3.1-3.1.405-1.x86_64:

Don't know if this is related, but I'm having a similar issue with dotnet-sdk-3.1-3.1.405-1.x86_64:

Same file size issue:

Originally posted by @beanotj in https://github.com/dotnet/core/issues/5856#issuecomment-763108525

beanotj reported this issue was resolved in https://github.com/dotnet/core/issues/5856#issuecomment-763176708.
@Rezaclipper, Maybe you meant to copy @Chardrazle's comment from later in https://github.com/dotnet/core/issues/5856? It's the last comment in the thread (no resolution) and has to do with the same package:

We're still seeing issues trying to acquire a non-corrupted version of: dotnet-sdk-3.1.405-x64.rpm
The corrupted version appears to have spread around the Azure nodes.
Sometimes we've got lucky and acquired the correct package, but most times not. Depends on which mirror we ultimately hit, I guess.
For example:
wget http://csd-apt-weu-d-4.westeurope.cloudapp.azure.com/yumrepos/microsoft-rhel7.3-prod/dotnet-sdk-3.1.405-x64.rpm -O- | md5sum
The corrupted version returns the checksum: 5eb9c4854342778b93d5ef55e83d265a
This file is 68MB and fails to install.
The correct version returns the checksum: 3d4b099cbc73b62e673c9c84a234f0a2

I'm not able to reproduce the issue after 30 downloads from my machine, but you never know when mirrors are involved.
@rbhanda

I'm going to close this now: it looks like that other issue has also been resolved (at least, it appears to have been working ok for a week): https://github.com/dotnet/core/issues/5856#issuecomment-773572078
@Rezaclipper, if you're running into a similar issue, please open a new issue with some more details and make sure to include the IP address and/or specific server and URL you're downloading from, so we can follow up. (Like http://csd-apt-weu-d-4.westeurope.cloudapp.azure.com/yumrepos/microsoft-rhel7.3-prod/dotnet-sdk-3.1.405-x64.rpm)


Beam, Underline cursor not working

Hi there, I've commented on #608 but I guess here it's more appropriate.
I'm using Alacritty 492d1bd and I don't see the cursor changing when using Neovim. When using iTerm or Terminal.app I do see that, I that should rule out issues with my copy of Neovim.
Is there anything I can do to help test/diagnose this?

Hmm, might be good to verify that you can manually change with these escape sequences:
printf "\e[6q" # pipe
printf "\e[4q" # underline
printf "\e[2q" # block

Ah, that is very interesting. They indeed actually work from outside neovim. But they are persisted inside neovim, i.e. if I do printf "\e[6q" then I get the pipe, and upon launching neovim the cursor remains a pipe, independently of the mode (normal/insert).
Does that help?

Sounds like neovim isn't emitting these sequences in Alacritty. What is the value you're using for TERM in both cases?

You mean the TERM env variable? It's xterm-256color in Alacritty, xterm in iTerm.
However if I manually change it to xterm in Alacritty, that doesn't help. In nvim the cursor shape still doesn't change.

@gglanzani put this in your .vimrc / init.vim:
set guicursor=n-v-c-sm:block,i-ci-ve:ver25,r-cr-o:hor20

It's there already

Huh, otherwise it would have been too simple :)
Are you using tmux, and what is your nvim version?
For tmux there is another thing needed:
set -ga terminal-overrides ',*:Ss=\E[%p1%d q:Se=\E[2 q'

It works on my side, with and without tmux, nvim is v0.2.0, so I guess it must be some kind of configuration difference.

No tmux, but fish is the underlying shell.
I'm using neovim head (of two days ago).

Just tried neovim head, the cursor shapes work there as well. Perhaps try with bash (works for me), and try my nvim config (just to eliminate the possibility of configuration difference) - remove the first Plugins section entirely, nvim will complain on the missing color theme, but the cursor shapes should work.

Interestingly enough, in Alacritty the neovim cursors are working for me only in tmux. iTerm 2 has the cursors working in and out of tmux.
NVIM v0.2.1-780-g5b32bce73
tmux 2.5
Alacritty 4e9b1c590e8b0990f5f43fa9d7c53a31a92840a8
zsh 5.4.1 (x86_64-apple-darwin16.7.0)
xterm-256color (outside tmux)
screen-256color (inside tmux)

So, I'm not using tmux. I've set alacritty to start with Bash, TERM set to xterm, and I've tried using an empty .vimrc (with the -u option) as well as with a .vimrc with set guicursor=n-v-c-sm:block,i-ci-ve:ver25,r-cr-o:hor20. I've also tried a .vimrc with the relevant parts from @maximbaz 's nvim config, i.e.
set termguicolors
set background=dark
set guioptions+=c
set guioptions-=T
set guioptions-=m
set guicursor=n-v-c-sm:block,i-ci-ve:ver25,r-cr-o:hor20

but I had no luck :(

For terminal cursor shapes to work in nvim with alacritty, you need to use a TERM that defines that the terminal supports it.
It should work if you use a new enough xterm term info. However, if you have modified your xterm term info, then chances are that this cursor info stuff was discarded.
An other posibility is that mac comes with outdated term info databases. IE on mac xterm term info is missing the cursor stuff as this was added a few years ago.
It works for me in linux with xterm term info (no tmux etc).

@Darkdefender how would I update that term info? And if that'd be the case, would it work with iTerm but not with Alacritty while both have TERM set to xterm?

It works with iTerm because neovim has special workarounds for popular terminals. Less popular termials are expected to do things correctly :p
Anyways, I've found other bug reports like https://github.com/lionheart/openradar-mirror/issues/15500 so it seems like I guessed correctly that OSX ships with too old terminfo files. On linux these are supplied but ncurses. But I don't know if you could easily upgrade them yourself on OSX.
Here is my xterm terminfo file:
xterm-256color.zip
You could just be able to put it in ~/.terminfo/ (so ~/.terminfo/xterm-256color) and you should be good to go. You can check where your terminfo is read from by typing the infocmp command in the terminal. That way, you can see if it reads you new local terminfo or not.

Sorry for the long silence.
It seems like the xterm info file doesn't help and it indeed seems that, inside tmux, nvim cursor shapes change as they should (using Alacritty).

I am getting the same behavior, in Neovim 0.2.1, but I wasn't having the issue in Neovim 0.2.0. The issue is also fixed for me if I use tmux.

When using iTerm or Terminal.app I do see that, I that should rule out issues with my copy of Neovim.

FWIW I have the same problem with Terminal.app.

The issue is also fixed for me if I use tmux.

alias nvim="TERM=tmux-256color nvim" Seems to work well enough as a workaround (you don't have to actually be using tmux). Not sure if it works if you don't even have it installed though (although it's only a brew install tmux away).

@DarkDefender

Here is my xterm terminfo file:
You should just be able to put it in ~/.terminfo/ (so ~/.terminfo/xterm-256color) and you should be good to go. You can check where your terminfo is read from by typing the infocmp command in the terminal. That way, you can see if it reads you new local terminfo or not.

For meinfocmp shows  ~/.terminfo/78/xterm-256color replacing that file with the one you uploaded does indeed fix the problem on both Alacritty and Terminal.app.
▶▶▶ ls                                                                                ~/.terminfo
31             35             39             4d             58             64             68             6c             70             74             78
32             36             41             4e             61             65             69             6d             71             75             7a
33             37             45             50             62             66             6a             6e             72             76
34             38             4c             51             63             67             6b             6f             73             77

Is there a recommended way to get an up to date terminfo file (other than copying from your comment 😁 )?
For anyone else having this problem, this is what I did:
curl -sL -O https://github.com/jwilm/alacritty/files/1236221/xterm-256color.zip
unzip xterm-256color.zip
cp ~/.terminfo/78/xterm-256color ~/.terminfo/78/xterm-256color.bak
mv xterm-256color ~/.terminfo/78/xterm-256color

@gibfahn Sadly I do not think there is a recommended way to do that. The best would of course be if Apple updated their system libraries to more recent versions.
Correct me if I'm wrong, but to me it seems like most libraries are quite outdated on mac, so the workflow on mac usually involves using a 3rd party packaging system (like brew) to update and get the libraries that you are interested in.
But as other people has reported, it seems like the ncurses library (at least this is the one that usually supplies the terminfo files on linux) does not update the terminfo files (if installed via brew that is).
So I guess that we'll have to add back a previously removed hack into neovim to fix this. (Or everyone could just migrate to linux... Just kidding ;) )

Correct me if I'm wrong, but to me it seems like most libraries are quite outdated on mac, so the workflow on mac usually involves using a 3rd party packaging system (like brew) to update and get the libraries that you are interested in.

Yep, to be honest I'm surprised there isn't a brew install terminfo command that gives you a ~/.terminfo folder. I just checked and clean installs don't have it at all, so it wouldn't overwrite the system /usr/local/share/terminfo.
It's certainly common to update all the old BSD tools to their GNU equivalents (e.g. to enable sed -i). Probably just waiting for someone to write it.

seems like this can be closed as it's not an issue with alacritty?

Yeah seems like this is a macos issue, the only potential workaround would be setting up our completely own terminfo file that doesn't relay on xterm-256color. But that's probably better covered in a different issue, this issue should probably be solved by just using a different terminfo/updating the system's terminfo.

I'm the original reporter of lionheart/openradar-mirror#15500. For fish, I ended up just using hard-coded escapes for dim and italics if we're running on a Mac 😢. I'd encourage anybody that's had a hard time due to ancient terminfo on macOS to report the issue to Apple. My issue has been open for years now, but they keep track of the number of duplicates in order to figure out what the squeaky wheels are.


Adding SASL Auth to Postfix

Let me know what you think of these changes. I tried to follow your style as best as I could. Once the changes are accepted and merged to the public docker image I will most likely remove my repo. You can follow the process I was following here and here.

Updates Dockerfile to install sasl binaries

libpam-pwdfile is used to read the passwd file, sasl2-bin is the actual service that does the client authentication, and whois includes mkpasswd which isn't strictly necessary but is useful to end users when creating their passwd files.

Updates Readme with example of basic auth situation.

Includes a link to the official Postfix docs where this situation is covers for people who may want to modify. After that, an example is included with basic PAM auth backed by a file and how to generate the file. The number of env variables that need to be set isn't pretty but I figure that's better than having users try to go figure it out.

Updates run file to configure SASL

I tried to follow your style here so feel free to make stylistic updates if I missed on anything. My changes will only run if the user passes the $SASL_Passwds variable since the passwds file must be generated by the user first. My changes then create the smtpd config file if needed, update the saslauthd service for postfix chroot, then update PAM to use the user's passwd file. saslauthd will not be run if the user doesn't specify a passwd file to save resources. Postfix needs to start after these changes.

Do you plan on doing more changes to the PR?

Everything I plan on doing is submitted. I did have one cleanup change in my editor that wasn't submitted but it's in there now.
Replyed to your comments. Let me know if I need to clarify more.

Getting a bit late here, will build and test tomorrow

@hemberger hey, looks ok to you? your usually good a spotting things :)

Did some basic testing and didn't see anything strange. As this is disabled by default i think it should be quite safe to merge.
@MeCJay12 Some last things you want to do or ready to merge?
@hemberger Feel free to review even after this i merged

Ready here

👍

If someone else can confirm. This wasnt working for me, in fact after a few hours I received an email from my server provider blocking my port 25 because of spam.
After some tests this is what worked for me:
version: "2"

services:

  smtp:
    image: mwader/postfix-relay:latest
    restart: always
    ports:
      - "587:25"
    volumes:
      - ./passwd_file:/etc/postfix/sasl/sasl_passwds
    environment:
      - SASL_Passwds=/etc/postfix/sasl/sasl_passwds
      - POSTFIX_smtp_sasl_password_maps=hash:/etc/postfix/sasl/sasl_passwds
      - POSTFIX_smtpd_sasl_auth_enable=yes
      - POSTFIX_smtpd_sasl_security_options=noanonymous
      - POSTFIX_smtpd_recipient_restrictions=permit_sasl_authenticated, permit_mynetworks, reject_unauth_destination
      - POSTFIX_smtpd_delay_reject-yes
      - POSTFIX_smtpd_client_restrictions=permit_sasl_authenticated, reject
      - POSTFIX_myhostname=mail.domain.com
      - OPENDKIM_DOMAINS=mail.domain.com

I got the configuration from here but I dont understand it to much
To test it, i used swaks, now authentication seems to be working correctly, but probably the environment variables can be improved

Sorry have no experience with SASL auth, maybe @MeCJay12?
BTW i noticed POSTFIX_smtpd_delay_reject-yes should the - be a =?

Yes, my mistake, then that line is probably not necesary

Hey all,
I'm not an expect in Postfix either and they changed how access lists work in 2.10 so here is the config section for more context: https://www.postfix.org/postconf.5.html#smtpd_relay_restrictions
That said, if that is your full docker-compose config, the issue is including 'permit_mynetworks' in 'POSTFIX_smtpd_recipient_restrictions'. By default, this container/Postfix (need to look into it some more for a proper fix) sets permit_mynetworks = <IP_ADDRESS>/0. smtpd_recipient_restrictions work on an OR basis so your config says "allow authenticated users OR anyone coming from permitted networks i.e. the Internet".
Short term fix, just remove 'permit_mynetworks' from 'POSTFIX_smtpd_recipient_restrictions'. Long term fix will be in an upcoming pull req.

@wader Quick update from testing for the update, 'smtpd_relay_restrictions' is specified by default which merges with 'smtpd_recipient_restrictions' so my new recommendation is to replace 'POSTFIX_smtpd_recipient_restrictions=...' with 'POSTFIX_smtpd_relay_restrictions=permit_sasl_authenticated, reject' in your config. That said, it looks like fixing 'POSTFIX_smtpd_delay_reject' in your config will also resolve your issue. The Postfix docs are a bit unclear IMHO.


Software reset does not work

no idea why

did you tried to change RC values of EN pin, Lolin use 10K/100nF couple not 10K/1uF https://www.wemos.cc/en/latest/_static/files/sch_c3_mini_v1.0.0.pdf
Worth giving a try

Sure, may be the issue


New buttons are submitting the form they are placed in

Describe the bug
With the 5.0.0 release, the refactor of <div role="button"> to <button> are causing <form> to submit when they are clicked. Looks like HTML Buttons default to a "submit" action.
To Reproduce
This playground has a form with a submit event that shows an alert.
https://stackblitz.com/edit/vuepic-vue-datepicker-u7qfy5?file=src%2Fcomponents%2FPlayground.vue

Click on any of the new buttons and it will popup the submit alert.

Expected behavior
Form should not be submitted when clicking on the UI buttons.

Correct me if I'm wrong, but it seems that this bug isnt't fixed in SelectionOverlay.vue


Automation

Add static analysis checks via "make qa"
Fix mispellings reported by "mispell";
Add newer GO versions in the Travis-CI build and coverage report (needs to be enabled in coveralls).

@nicolaasuni Thanks for the additional automation – note that I've incorporated them into the master branch and deleted the develop branch (moving to the simpler GitHub flow process)

@willf Thanks, I have just sent a new PR to improve the Makefile, as the original PR was quite old :-)

Thanks @nicolaasuni -- hopefully, it won't be months before I look again :)


Errors in Russian and Ukrainian translations

The two translations have a function time2, which changes "tomorrow-afternoon" ("завтра днем" [ru], "завтра вдень" [uk]) to "tomorrow-morning" ("завтрашнего утра" [ru], "завтрашнього ранку" [uk]). Here should "завтрашнего дня" [ru], "завтрашнього дня" [uk] be.

Thanks for pointing this out. I would be very appreciative of a patch, if you don't mind submitting one—Cyrillic is completely foreign to my eyes, and I would likely make a mistake in doing so myself!

done

This has been merged in. Thanks so much!