Clock sync fixes

There are some problems if the host clock is wrong.
If the host clock is ahead and staking is started, then once new block is found by this node and it is propagated between peers, they will reject the block and ban your node.
If the host clock is behind, once a new block is found by the network this node will reject it and ban all peers that propagated the block.
Even 1 second difference can cause this all these problems.
@TheQuantumPhysicist  suggested setting the BlockFromTheFuture ban score to 0. I tried this, but it did not work. Because once the first block is rejected by the chainstate, the block synchronization process is broken and later blocks are rejected with the PrevBlockNotFound error.
I think we should require the host clock to be in sync.
I did a little research and it looks like some other blockchains require this as well:
From https://geth.ethereum.org/docs/fundamentals/peer-to-peer
Local time might be incorrect. An accurate clock is required to participate in the Ethereum network. The local clock can be resynchronized using commands such as sudo ntpdate -s time.nist.gov (this will vary depending on operating system).

And from https://iohk.zendesk.com/hc/en-us/articles/360010230873-Machine-clock-out-of-sync-with-Cardano-network
Daedalus is displaying a red screen message related to your machine time being out of sync.

So I think this is acceptable, and I don't see how else we can make it work.
Requiring high clock accuracy (less than 1 second) is probably too strong, so we can allow some tolerance. I chose 10 seconds (the new max_clock_diff parameter in P2pConfig). Making it too large can result in a poor performance, and making it too small can make it too difficult for the users to join the network.
To check the clock, I added the new current_time field to p2p handshakes. If two peers disagree on the current time (the difference is more than MaxClockDiff), the handshake will fail.
As I mentioned above, even a 1 second difference can cause issues.
To prevent this, the BlockSyncManager peer tasks will delay processing new block messages until they can be accepted by the chainstate (but not more than max_clock_diff).
I may be missing something, so feedback is welcome.

There was a question about security implications in the presence of malicious nodes. This new approach should be fine as long as the clock is correct. But if the node's clock is wrong, it will be trivial to isolate the node by connecting malicious nodes with the same invalid clock (while honest nodes can't connect). After that, the node will be open to all kinds of attacks.

What happens if the clock drifts over time? I've seen that computer clocks (that don't automatically synchronize) drift by around 10 seconds per week.
This topic seems shaky the more I think about it. We need a campaign to study this problem separately.
I'm not saying this to reject this PR, btw. Just random thoughts on the topic.


Fixes grid tablet override

Changes css property flex-basic with flex-basis

Thanks for this @hidnasio
LGTM @MikeBallan

Looks good, going to merge this..!


Sourcemaps not generated on production build

No sourcemaps are generated when building with ember build --environment production. Sourcemaps are generated if built with ember build. Using ember 2.16.3 and ember-cli-babel 6.12.0.

Yep. Sourcemaps are disabled for production builds, but you can turn them back on.
Checkout https://ember-cli.com/user-guide/#source-maps for more details.

Thanks @rwjblue, I jumped the gun on this one. We deleted this property between changes somehow between Ember upgrades.


Allow h2-h6 version titles multi-indented changelogs

That code 1:1 copied from Platform. We would have with your change an incompatible changelog 🤔

What do you mean that it is an incompatible changelog?

https://github.com/shopware/platform/pull/947 I see what mean

The core PR got declined. I don't know we want this here

I am aware of the decline but I have an objection there. I am aware of the connection of these two :)

Please open the PR again, when it's merged in the Core :)


getbtpcli fails with a grep-related error on macOS

This issue relates to the content in the 2021-09-01-btp-cli-installation branch of this repo.
Running the getbtpcli script on a standard macOS device results in an error relating to grep:
; getbtpcli
Proceed (with Enter) only if you accept the SAP Developer Licence 3.1
(see https://tools.hana.ondemand.com/developer-license-3_1.txt) ...
usage: grep [-abcDEFGHhIiJLlmnOoqRSsUVvwxZ] [-A num] [-B num] [-C[num]]
	[-e pattern] [-f file] [--binary-files=value] [--color=when]
	[--context[=num]] [--directories=action] [--label] [--line-buffered]
	[--null] [pattern] [file ...]
# ~
;

This issue was encountered and logged in this comment to the blog post SAP Tech Bytes: btp CLI – installation that accompanies this repo branch.

The line where this error occurs is this one, in the get_version function of the getbtpcli script:
"$file" --version 2> /dev/null | grep -P -o '(?<=v)\d+\.\d+\.\d+'

This tries to determine the version of the btp executable (in $file) by parsing the output from the --version option. Here's what that looks like (i.e. when btp --version is invoked):
SAP BTP command line interface (client v2.8.0)

OK

The empty line and the "OK" are actually emitted to STDOUT so we throw them away by redirecting STDOUT to nowhere (2> /dev/null).
Then we have the single line to parse a version number from. We're looking for the form "x.y.z" which in this example would be "2.8.0". In order to identify such a version number as "accurately" as possible, the regular expression is being employed:
(?<=v)\d+\.\d+\.\d+

This uses a lookbehind assertion (?<=v) which says what is to be matched (\d+\.\d+\.\d+) must directly follow a lower case v; the assertion is there because the v needs to be there but not included in what's matched. Such assertions are part of the Perl Compatible Regular Expressions family, which are not available with the stock macOS version of grep (identified at the time of writing as "2.5.1-FreeBSD"). They are available with the more widespread GNU version of grep, via the -P option, which is used here.
I'd recommend you install the GNU version of grep as it's more powerful and arguably more widespread. You can do this simply by using Homebrew, and then adding the path to the newly installed executable, so that it comes before the location of the stock macOS grep. In other words:
brew install grep

export PATH=/usr/local/opt/grep/libexec/gnubin:$PATH

(add this export to your .bashrc file).
For those wondering, the -o option tells grep to just return the actual string that matched (i.e. just the "x.y.z" version number), rather than the default which would be the entire line that it found with such a match.


Devices are not supported!!!

[11/7/2023, 9:02:31 PM] [LGThinQ] [워시타워] Setting up device!
[11/7/2023, 9:02:31 PM] [LGThinQ] [워시타워] This device may not "smart" device. Ignore it!
[11/7/2023, 9:02:31 PM] [LGThinQ] Device not supported: thinq2: 07322beb-: 워시타워 (undefined WTL_KPK_BDH_KR_01)
[11/7/2023, 9:02:31 PM] [LGThinQ] [스틱청소기] Setting up device!
[11/7/2023, 9:02:31 PM] [LGThinQ] Device not supported: thinq2: 8d13a7c5-: 스틱청소기 (undefined HWWA9XC_F2U)
[11/7/2023, 9:02:31 PM] [LGThinQ] [정수기] Setting up device!
[11/7/2023, 9:02:31 PM] [LGThinQ] Device not supported: thinq2: be25963d-: 정수기 (WATER_PURIFIER 1WPD4CIBIR__3)
Hi,
installed homebridge-lgthinq, but some devices are not supported.
are you planning to supported these devices?
(all devices are 2023 series)

please turn on homebridge debug mode and upload some device data appeared in debug logging


[SPARK-23415][SQL][TEST] Make behavior of BufferHolderSparkSubmitSuite correct and stable

What changes were proposed in this pull request?
This PR addresses two issues in BufferHolderSparkSubmitSuite.

While BufferHolderSparkSubmitSuite tried to allocate a large object several times, it actually allocated an object once and reused the object.
BufferHolderSparkSubmitSuite may fail due to timeout

To assign a small object before allocating a large object each time solved issue 1 by avoiding reuse.
To increasing heap size from 4g to 7g solved issue 2. It can also avoid OOM after fixing issue 1.
How was this patch tested?
Updated existing BufferHolderSparkSubmitSuite

Test build #87541 has started for PR 20636 at commit 39a715c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/959/
Test PASSed.

Test build #87541 has finished for PR 20636 at commit 39a715c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87541/
Test PASSed.

cc @dongjoon-hyun

Thank you for pining me and working on this issue, @kiszk .

ping @liufengdb and @gatorsmile

ping @gatorsmile and @liufengdb

ping @gatorsmile and @hvanhovell

ping  @hvanhovell

retest this please

Test build #89146 has started for PR 20636 at commit 39a715c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2172/
Test PASSed.

Test build #89146 has finished for PR 20636 at commit 39a715c.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89146/
Test FAILed.

retest this please

Test build #89447 has started for PR 20636 at commit 39a715c.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2386/
Test PASSed.

Merged build finished. Test PASSed.

Test build #89447 has finished for PR 20636 at commit 39a715c.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89447/
Test FAILed.

Test build #89475 has started for PR 20636 at commit 21b3708.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2406/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2408/
Test PASSed.

Test build #89475 has finished for PR 20636 at commit 21b3708.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89475/
Test FAILed.

retest this please

Test build #89485 has started for PR 20636 at commit 21b3708.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2418/
Test PASSed.

Test build #89477 has finished for PR 20636 at commit 21b3708.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89477/
Test PASSed.

Merged build finished. Test PASSed.

Test build #89485 has finished for PR 20636 at commit 21b3708.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89485/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2426/
Test PASSed.

Test build #89494 has started for PR 20636 at commit 21b3708.

@kiszk Why do we need to allocate a large array several times? I thought the objective of this test is to check if we can safely grow to int max? I don't really see the need for resetting the array before every grow call. Am I missing something here?

Ah, I see. I thought the objective is to check if we can safely allocate buffer with each size. According to my understanding, you think to reuse buffer is an intention of this test.
While buffer.reset() has existed before I submitted this PR, we do not need buffer.reset() since we do not update cursor. I also remove setBuffer(holder, smallBuffer) to enable reuse of a buffer.

@hvanhovell BTW, could you favor me?
I realized that grow(roundToWord(Integer.MAX_VALUE)) does nothing. We may see integer overflow here.
At holder.grow(roundToWord(Integer.MAX_VALUE)), the given argument Integer.MAX_VALUE is passed as roundToWord(0x7FFF_FFFF) ->  ByteArrayMethods.roundNumberOfBytesToNearestWord(0x7FFF_FFFF)
In the method roundNumberOfBytesToNearestWord, the return value will be 0x7FFF_FFFF + (8 - (0x7FFF_FFFF & 7) = 0x8000_0000.
  public static int roundNumberOfBytesToNearestWord(int numBytes) {
    int remainder = numBytes & 0x07;  // This is equivalent to `numBytes % 8`
    if (remainder == 0) {
      return numBytes;
    } else {
      return numBytes + (8 - remainder);
    }
  }

Then, we execute grow(0x8000_0000). Since neededSize is negative, in grow(), we do not execute both of then block.
  void grow(int neededSize) {
    if (neededSize > ARRAY_MAX - totalSize()) {
      throw new UnsupportedOperationException(
        "Cannot grow BufferHolder by size " + neededSize + " because the size after growing " +
          "exceeds size limitation " + ARRAY_MAX);
    }
    final int length = totalSize() + neededSize;
    if (buffer.length < length) {
      // This will not happen frequently, because the buffer is re-used.
      int newLength = length < ARRAY_MAX / 2 ? length * 2 : ARRAY_MAX;
      final byte[] tmp = new byte[newLength];
      Platform.copyMemory(
        buffer,
        Platform.BYTE_ARRAY_OFFSET,
        tmp,
        Platform.BYTE_ARRAY_OFFSET,
        totalSize());
      buffer = tmp;
      row.pointTo(buffer, buffer.length);
    }
  }

As a result, when roundToWord(Integer.MAX_VALUE) is passed to grow(), no allocation happens.
Should we keep this? Or, should we add check if neededSize is zero or positive? What do you think?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2546/
Test PASSed.

Test build #89653 has finished for PR 20636 at commit f946631.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/89653/
Test FAILed.

@hvanhovell  When I added the new check code to see whether the growth value is negative, we see the following error. Finally, Integer.MAX_VALUE is changed to negative value.
How do we handle this? Should we pass Integer.MAX_VALUE - n (where n is 64 or something) instead of Integer.MAX_VALUE? WDYT?
 Exception in thread "main" java.lang.UnsupportedOperationException: Cannot grow BufferHolder by size -2147483648 because the size is nevative
        at org.apache.spark.sql.catalyst.expressions.codegen.BufferHolder.grow(BufferHolder.java:65)
        at org.apache.spark.sql.catalyst.expressions.codegen.BufferHolderSparkSubmitSuite$.main(BufferHolderSparkSubmitSuite.scala:69)
        at org.apache.spark.sql.catalyst.expressions.codegen.BufferHolderSparkSubmitSuite.main(BufferHolderSparkSubmitSuite.scala)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.apache.spark.deploy.JavaMainApplication.start(SparkApplication.scala:52)
        at org.apache.spark.deploy.SparkSubmit.org$apache$spark$deploy$SparkSubmit$$runMain(SparkSubmit.scala:838)
        at org.apache.spark.deploy.SparkSubmit.doRunMain$1(SparkSubmit.scala:166)
        at org.apache.spark.deploy.SparkSubmit.submit(SparkSubmit.scala:193)
        at org.apache.spark.deploy.SparkSubmit.doSubmit(SparkSubmit.scala:85)
        at org.apache.spark.deploy.SparkSubmit$$anon$2.doSubmit(SparkSubmit.scala:913)
        at org.apache.spark.deploy.SparkSubmit$.main(SparkSubmit.scala:924)
        at org.apache.spark.deploy.SparkSubmit.main(SparkSubmit.scala)

ping @hvanhovell

ping @hvanhovell

ping @hvanhovell

cc @cloud-fan

BufferHolderSparkSubmitSuite is really a bad test. What we want to guarantee is, BufferHolder is always word-aligned. Is there a better way to test it?

Sure, I will update this

When I check callers of BufferHolder.grow(), some of them call ByteArrayMethods.roundNumberOfBytesToNearestWord() and other do not call it (i.e. implicitly ensure word-aligned).
Is it better way to call ByteArrayMethods.roundNumberOfBytesToNearestWord() at BufferHolder.grow() instread of a caller to gurantee word-aligned?
Then, we can check whether UnsafeRow.getSizeInBytes() is a multiple of 8 in BufferHolderSparkSubmitSuite.

SGTM.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/80/
Test PASSed.

Test build #91751 has started for PR 20636 at commit b305eab.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3970/
Test PASSed.

Test build #91751 has finished for PR 20636 at commit b305eab.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91751/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3979/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/89/
Test PASSed.

Merged build finished. Test PASSed.

Test build #91767 has started for PR 20636 at commit b305eab.

Test build #91767 has finished for PR 20636 at commit b305eab.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91767/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4023/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/134/
Test PASSed.

Test build #91834 has started for PR 20636 at commit aca2ee6.

Test build #91834 has finished for PR 20636 at commit aca2ee6.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91834/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/143/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4032/
Test PASSed.

Test build #91847 has started for PR 20636 at commit aca2ee6.

Test build #91847 has finished for PR 20636 at commit aca2ee6.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91847/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/148/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4038/
Test PASSed.

Test build #91858 has started for PR 20636 at commit aca2ee6.

Test build #91858 has finished for PR 20636 at commit aca2ee6.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91858/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4042/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/151/
Test PASSed.

Test build #91863 has started for PR 20636 at commit aca2ee6.

Test build #91863 has finished for PR 20636 at commit aca2ee6.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91863/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/161/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4052/
Test PASSed.

Test build #91876 has started for PR 20636 at commit b0d13bf.

Test build #91876 has finished for PR 20636 at commit b0d13bf.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91876/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/163/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4054/
Test PASSed.

Test build #91879 has started for PR 20636 at commit 9a96475.

Test build #91879 has finished for PR 20636 at commit 9a96475.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91879/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4055/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/164/
Test PASSed.

Test build #91880 has finished for PR 20636 at commit 2995a9c.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91880/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/167/
Test PASSed.

Test build #91884 has started for PR 20636 at commit d8dcdae.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4058/
Test PASSed.

Test build #91884 has finished for PR 20636 at commit d8dcdae.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91884/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4060/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/169/
Test PASSed.

Test build #91886 has started for PR 20636 at commit d8dcdae.

Test build #91886 has finished for PR 20636 at commit d8dcdae.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91886/
Test FAILed.

Test build #91888 has started for PR 20636 at commit d8dcdae.

Test build #91888 has finished for PR 20636 at commit d8dcdae.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91888/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4072/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/183/
Test PASSed.

Test build #91896 has finished for PR 20636 at commit d8dcdae.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91896/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4079/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/188/
Test PASSed.

Test build #91908 has started for PR 20636 at commit d8dcdae.

Test build #91908 has finished for PR 20636 at commit d8dcdae.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91908/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/193/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4084/
Test PASSed.

Test build #91918 has started for PR 20636 at commit 96f8eff.

Test build #91918 has finished for PR 20636 at commit 96f8eff.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91918/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/198/
Test PASSed.

Test build #91924 has started for PR 20636 at commit 96f8eff.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4089/
Test PASSed.

Test build #91924 has finished for PR 20636 at commit 96f8eff.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91924/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4091/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/200/
Test PASSed.

Test build #91927 has started for PR 20636 at commit a134091.

Test build #91927 has finished for PR 20636 at commit a134091.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91927/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/201/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4092/
Test PASSed.

Test build #91928 has started for PR 20636 at commit a134091.

Test build #91928 has finished for PR 20636 at commit a134091.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91928/
Test FAILed.

retest this please

Test build #91929 has started for PR 20636 at commit a134091.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/202/
Test PASSed.

Test build #91929 has finished for PR 20636 at commit a134091.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91929/
Test FAILed.

retest this please

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4094/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/203/
Test PASSed.

Test build #91931 has started for PR 20636 at commit a134091.

Test build #91931 has finished for PR 20636 at commit a134091.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91931/
Test FAILed.

retest this please

Test build #91933 has started for PR 20636 at commit a134091.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4096/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/205/
Test PASSed.

Test build #91933 has finished for PR 20636 at commit a134091.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91933/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4097/
Test PASSed.

Test build #91934 has started for PR 20636 at commit a134091.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/206/
Test PASSed.

Test build #91934 has finished for PR 20636 at commit a134091.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91934/
Test FAILed.

retest this please

retest this please

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/207/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.


[DNM] add 1.6 version for docs-tidb-operator pdf

Add TiDB Operator release-1.6
Do not merge until the release date (presumably 3/27)

/cc @purelind


Love Calculator added

Developer Checklist

[x] Followed guidelines mentioned in the readme file.

Summary
t's a Love Calculator where Users have to put his/her name with partner's name and the calculator calculates the Love percentage randomly between them and display
Tech Stack Used: HTML5,CSS3
Screenshot

Kindly view and merge the PR.

please review and merge the changes requesteed.


MGMT-17132: Trigger SSH key validations when user changes this field

Related to https://issues.redhat.com/browse/MGMT-17132

/lgtm


[NIFI-13535] - Fix: Issues selecting GitHub branch on version control screens in new UI

NIFI-13535
Properly include the branch query param in API calls to the backend registry API when provided.

Also, we need the same behavior on the "Start Version Version Control" screen. I am not sure if that is backed by save-version-dialog.component.ts, but in there I see we have branchChanged which will reload the buckets based on the branch, but we don't have anything for bucketChanged to reload flows, or flowChanged to reload versions. It is possible I am looking at the wrong thing.

Also, we need the same behavior on the "Start Version Version Control" screen. I am not sure if that is backed by save-version-dialog.component.ts, but in there I see we have branchChanged which will reload the buckets based on the branch, but we don't have anything for bucketChanged to reload flows, or flowChanged to reload versions. It is possible I am looking at the wrong thing.

Start version control doesn't load flows or flow versions since we are adding a new flow to the repository. I'm not sure I understand what needs changed there.

Will review...


ci: migrate test/lint to GH actions

lyft/flyte#423
This removes our Travis configuration in favor of using Github Actions for all CI steps.

Removed travis.yml
Updated .github/workflows/pull_request.yml to include steps for running the tests and linting. Additionally added yarn caching action to each step to speed up dependency installation
Removed supporting code for uploading to Codecov, as there is a Github action built for it.

Codecov Report

Merging #136 (2c6cf80) into master (d8daf6c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   74.43%   74.43%
=======================================
  Files         415      415
  Lines        7310     7310
  Branches     1154     1154
=======================================
  Hits         5441     5441
  Misses       1869     1869

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9076cce...2c6cf80. Read the comment docs.

Codecov Report

Merging #136 (2c6cf80) into master (d8daf6c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   74.43%   74.43%
=======================================
  Files         415      415
  Lines        7310     7310
  Branches     1154     1154
=======================================
  Hits         5441     5441
  Misses       1869     1869

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9076cce...2c6cf80. Read the comment docs.

+1

+1

:tada: This PR is included in version 0.19.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.19.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fatal: failed to unpack tree object

I'm running dep ensure on commit this repo & commit, getting following error.
dep was installed with go get -u at commit 7d5cd199ce454707f81c63b7ea4299151b8b981d (most recent at time of posting).
Looks somewhat similar to https://github.com/golang/dep/issues/1439.
$ dep ensure -v
Gopkg.lock was already in sync with imports and Gopkg.toml
(1/39) Wrote gopkg.in/macaroon.v2@bed2a428da6e56d950bed5b41fcbae3141e5b0d0
(2/39) Wrote git.schwanenlied.me/yawning/bsaes.git@master
(3/39) Wrote github.com/jessevdk/go-flags@f88afde2fa19a30cf50ba4b05b3d13bc6bae3079
(4/39) Wrote github.com/jrick/logrotate@a93b200c26cbae3bb09dd0dc2c7c7fe1468a034a
(5/39) Wrote github.com/juju/loggo@master
(6/39) Wrote github.com/kkdai/bstream@f391b8402d23024e7c0f624b31267a89998fca95
(7/39) Wrote github.com/lightninglabs/gozmq@master
(8/39) Wrote github.com/davecgh/go-spew@8991bc29aa16c548c550c7ff78260e27b9ab7c73
(9/39) Wrote github.com/aead/chacha20@master
(10/39) Wrote github.com/aead/siphash@master
(11/39) Wrote github.com/awalterschulze/gographviz@761fd5fbb34e4c2c138c280395b65b48e4ff5a53
(12/39) Wrote github.com/btcsuite/btclog@84c8d2346e9fc8c7b947e243b9c24e6df9fd206a
(13/39) Wrote github.com/btcsuite/fastsha256@master
(14/39) Wrote github.com/btcsuite/go-socks@master
(15/39) Wrote github.com/btcsuite/websocket@master
(16/39) Wrote github.com/btcsuite/golangcrypto@master
(17/39) Wrote github.com/coreos/bbolt@4f5275f4ebbf6fe7cb772de987fa96ee674460a7
(18/39) Wrote github.com/Yawning/aez@4dad034d9db2caec23fb8f69b9160ae16f8d46a3
(19/39) Wrote github.com/go-errors/errors@a6af135bd4e28680facf08a3d206b454abc877a4
(20/39) Wrote github.com/lightninglabs/neutrino@601b7eda6e5c9e8ca91c097f0bb7be2664802ab3
(21/39) Wrote github.com/lightningnetwork/lightning-onion@6d4b1353e2835def84ee240f40499464521c6046
(22/39) Wrote github.com/grpc-ecosystem/grpc-gateway@f2862b476edcef83412c7af8687c9cd8e4097c0f
(23/39) Wrote github.com/golang/protobuf@bbd03ef6da3a115852eaf24c8a1c46aeb39aa175
(24/39) Wrote github.com/miekg/dns@79bfde677fa81ff8d27c4330c35bda075d360641
(25/39) Wrote github.com/ltcsuite/ltcd@5f654d5faab99ee2b3488fabba98e5f7a5257ee3
(26/39) Wrote github.com/roasbeef/btcutil@c3ff179366044979fb9856c2feb79bd4c2184c7a
(27/39) Wrote github.com/rogpeppe/fastuuid@master
(28/39) Wrote github.com/tv42/zbase32@501572607d0273fc75b3b261fa4904d63f6ffa0e
(29/39) Wrote github.com/urfave/cli@1efa31f08b9333f1bd4882d61f9d668a70cd902e
(30/39) Wrote github.com/roasbeef/btcd@e6807bc4dd5ddbb95b4ab163f6dd61e4ad79463a
(31/39) Wrote golang.org/x/crypto@49796115aa4b964c318aad4f3084fdb41e9aa067
(32/39) Wrote golang.org/x/net@ae89d30ce0c63142b652837da33d782e2b0a9b25
(33/39) Wrote google.golang.org/genproto@df60624c1e9b9d2973e889c7a1cff73155da81c4
(34/39) Wrote google.golang.org/grpc@b3ddf786825de56a4178401b7e174ee332173b66
(35/39) Wrote gopkg.in/macaroon-bakery.v2@94012773d2874a067572bd16d7d11ae02968b47b
(36/39) Wrote gopkg.in/errgo.v1@v1
(37/39) Wrote golang.org/x/sys@master
(38/39) Failed to write github.com/roasbeef/btcwallet@45445d1b09670109410174cb01fab0b133e3a904
(39/39) Failed to write<EMAIL_ADDRESS>grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export github.com/roasbeef/btcwallet: fatal: failed to unpack tree object 45445d1b09670109410174cb01fab0b133e3a904
: exit status 128

Also getting this:
dep ensure -vendor-only
grouped write of manifest, lock and vendor: error while writing out vendor tree: failed to write dep tree: failed to export gopkg.in/fsnotify.v1: fatal: failed to unpack tree object c2828203cd70a50dcccfb2761f8b1f8ceef9a8e9

I'm having this on a CentOS-based VPS, but not on my Arch system. A clue as to what this might possibly be related to would be very helpful.

The logic in deduce.go specific to https://gopkg.in is broken.  If you have a dependency to gopkg.in/fsnotify.v1 dep tries to construct the source on its own by prepending a go- rather than doing a ?go-get=1 request (as it probably should, although I don't know the details of why it operates the way it does).  However, https://github.com/go-fsnotify/fsnotify is a placeholder repo and thus dep fetches garbage.
Sigh, why couldn't they have just copied one of the numerous dependency management tools from other languages that actually works...

I was able to get this working by adding the following to my Gopkg.toml file.
[[override]]
  name = "gopkg.in/fsnotify.v1"
  version = "1.2.9"
  source = "git@github.com:fsnotify/fsnotify"

Ah, great suggestion @pkrull , I'm guessing that will fix it for me.  Thanks!

Does dep hard-code gopkg.in logic? Instead of just have gopkg.in do what it
does: redirect to github using the therefore intended protocol..
On Fri, 23 Mar 2018, 22:11 Tim Garton<EMAIL_ADDRESS>wrote:

The logic in deduce.go specific to https://gopkg.in is broken. If you
have a dependency to gopkg.in/fsnotify.v1 dep tries to construct the
source on its own by prepending a go- rather than doing a ?go-get=1
request (as it probably should, although I don't know the details of why it
operates the way it does). However,
https://github.com/go-fsnotify/fsnotify is a placeholder repo and thus
dep fetches garbage.
Sigh, why couldn't they have just copied one of the numerous dependency
management tools from other languages that actually works...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/golang/dep/issues/1760#issuecomment-375811861, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA0F3F96Nj9hYUKLhbH-h1PqFxOV_W9Oks5thXMkgaJpZM4SvR8-
.

That fixes it for me @pkrull , thanks again for the suggestion.  @stevenroose yes I believe that dep does hard-code gopkg.in logic, if I am reading the code here correctly: https://github.com/golang/dep/blob/master/gps/deduce.go#L284

fsnotify is failing for me as well.

We have separate hard-coded logic for gopkg.in because we already had to have something special in order to filter the available versions list in a way that makes sense for the implied constraint within the gopkg.in package path, so i figured it'd be fine to skip the HTTP request and just do the work locally.
All of that was fine as long as gopkg.in acted according to its specified, regular behaviors. It stopped doing so as of a week ago -  added a special rule for fsnotify. @niemeyer, i don't suppose you have any plans to return to the regular rules?
If not, we'll probably have to reorganize the way that our gopkg.in support works to reintegrate the HTTP request. Might just add the fsnotify exception rule as a stopgap, though - might be a bit of a tricky refactor.

Sigh, why couldn't they have just copied one of the numerous dependency management tools from other languages that actually works...

super.

@sdboyer I apologize for my comment above, I realize you spend a lot of your own time working on this so that other people can benefit (myself being one of them), so thank you for that.  The go dependency scene has been frustrating over the years and I have spent (hard not to say wasted) dozens of hours at this point wrestling with dependency issues what with all the different tools (godeps, glide, dep, now perhaps the upcoming vgo?).  But still doesn't excuse snarky comments like the one I posted, my bad :(

@sdboyer Per the long discussion in issue #1 of go-fsnotify/fsnotify, this was a necessary workaround to an unfortunate sequence of events in a popular package. I have no plans to keep adding such workarounds.
At the same time, I can't make any promises. Just a few days ago I'd have claimed we'd not have redirects at all.

@sdboyer IMO, if there is an issue with version-discovery using gopkg.in and the default ?go-get=1 protocol, then that's not something dep should fix. That's the decision of the publisher of the package that suggests using gopkg.in instead of github or of the user that imports using gopkg.in instead of github.
With dependency managers like dep, gopkg.in becomes quite useless actually, so it's use with dep should be discouraged.
I still believe the best solution here is to remove all gopkg.in-specific logic like suggested in https://github.com/golang/dep/issues/1782.


Rollup changes are not reflected during watch mode. [Linux]

So, I don't know since when that happen as I used to often reload rollup due to #141
Rollup only reload a file the first time it change. After that, my terminal regarding rollup doesn't change.  Elderjs reload as expected though (but doesn't apply the change).

@nickreese  i will find your in discord but nout fainded, my discord Нурбек Ахмедов#7361

As an update to this. @kiuKisas Have compared notes and this appears to be a linux bug.
Essentially rollup is not outputting recompiled files into the ./___ELDER___/components folder.

This appears to be a rollup issue with linux.
"Unix/Linux uses inotify, OSX uses FSWatch"1 to implement file watching.
According to @lukeed we can probably just override watch.chokidar:true in our rollup process. @kiuKisas is testing it.

Sorry, it used to be true in an older Rollup version. Now it's the full Chokidar options object: https://rollupjs.org/guide/en/#watchchokidar
Just a guess, but maybe something like this?
// rollup.config.js
watch: {
  chokidar: {
    usePolling: !/^(win32|darwin)$/.test(process.platform)
  }
}

Fixed in 1.4.0


json-viewer disables up, down, Home, and End keys

The Home and End keys normally, of course, scroll to the top or the bottom of a web page, and the up and down arrow keys scroll the page up and down a bit. For some reason, json-viewer is intercepting these keys and preventing them from operating.

Also, space should go down a page...


chore: prod deployment, 2022-04-27

Reviewers
Functional:
Readability:

Changes

add
remove
modify

Definition of Done (from ticket)
QA steps (optional)
Known Issues

Note: There is a functional test failing on staging, but as decided, proceeding with prod deployment.


Smart LED Driver

Simple led driver by Shenzhen Homa
https://www.alibaba.com/product-detail/mini-9w-12w-led-downlight-zigbee_60763629064.html

Thanks!


Update marketplace-grow-your-business-with-appsource.md

#sign-off

@yijenj : Thanks for your contribution! The author, @ellacroi, has been notified to review your proposed change.


Notification Channels Docs Differ

Expected Behaviour
Expected Behavior of Notification Channel Create
Actual Behaviour
PushNotification.createChannel(); expects 1 argument not 3 so success and error callbacks don't go in the function call. I tested adding them to the Promise portion but doesn't like the success variable.
so either i'm using the wrong imported object or the docs are different from the build.
Reproduce Scenario (including but not limited to)
npm install latest phonegap-plugin-push v2.2.3
Steps to Reproduce
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
N/A
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
N/A
Cordova CLI version and cordova platform version
cordova: 8.0.0
cordova platform version android: 7.0.0

Plugin version
cordova plugin version | grep phonegap-plugin-push   # e.g. 1.5.3

Sample Push Data Payload
N/A
Sample Code that illustrates the problem
cosntructor(private push: Push){
    if (platform.is('android')) {
    var channelId = 'appdefault';
    push.createChannel(
      () => {
        console.log('success');
      },
      () => {
        console.log('error');
      },
      {
        id: 'testchannel1',
        description: 'My first test channel',
        importance: 3,
        vibration: true
      }
    );
    // this is my attempt at using it the way it says
    // push.createChannel( { options: object } ).then((err: any) => { });
  }
}

Logs taken while reproducing problem
N/A

well darn guys 4 days and nothing back??

Are you paying for premium support or something?
Also, of those 4 days, 2 were weekend.
I think you have very high expectations on free open source projects/plugins. Considering there are another 199 open issues, 4 days is nothing.

BTW, are you using typescript? where did you get the types from? probably the problem is there

its not like i'm reporting a bug @jcesarmobile  i'm just wondering the correct format of the notification channel object. i dont want to crowd the issues inbox about stupid little stuff like why the PushNotification.createChannel function doesn't take 3 arguments but thats what the Documents say it takes and its not taking those arguments in practice.

the types came from the npm package. soooo i guess what your saying is yes there is an issue with the phonegap-plugin-push types file

The types don't even have createChannel, so yes, there are problems with the types.
The js method takes the 3 params.

hmmm well that explains some except . . .

So you are using ionic-native types, not the plugin ones.
So you have to do it the ionic-native way, just pass the channel, the then part should contain your current success callback, and add a catch for the error one
this.push.createChannel({
 id: "testchannel1",
 description: "My first test channel",
 // The importance property goes from 1 = Lowest, 2 = Low, 3 = Normal, 4 = High and 5 = Highest.
 importance: 3
}).then(() => console.log('Channel created'));

Ionic native wraps the callbacks into a promise, that's why it only has one param instead of the 3 the js API has.

unfortunately i might have to open a new issue for this as the way the createChannel is setup and tested is the Correct way to do it and is still not working for Android O.


added documentation for image driver forcing file

This PR addresses #548.

looks good. just a few minor suggestions.

@jhamman this should be ready to merge.


Is this library compatible with IdentityServer4

Hi There,
Since ResourceOwnerPassword is deprecated and ClientCredentials are not a recommended way for native WPF Applications I wanted to use this library to talk to IdentityServer4.
Will ResourceOwnerPassword grant will be removed in future versions of IdentityServer?
Is this library at the moment can be used with IdentityServer4?
If yes, then how can I allow other users to log in to the same app by effectively logging out? at the moment when I try to open the browser again, it's directly taking to concent screen.
Please help me.

This library is compatible with IS4.
Logout is a separate issue.


pie menu

custom pie menu:

merge by distance + auto merge
snapping modes:

tranform pivot point to 3D Cursor + Snap with Center

Transform orientation from Face

No need to reinvent the wheel, here a nice pie menus addon: https://github.com/oRazeD/PieMenusPlus


conda_env in local Docker cluster

Add a new dockerfile with miniconda installed to be able to test conda default_env in a local docker cluster. Unfortunately changing the dockerfile to use the miniconda base image did not work for the other local clusters which don't use conda default env, not for lack of trying. Ideally we can consolidate these somehow soon.

#1053  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @dongreenberg and the rest of your teammates on  Graphite

Merge activity

Jul 22, 11:32 PM EDT: @dongreenberg started a stack merge that includes this pull request via Graphite.


As knative admin, I want to unset custom domain

Now we have kn admin domain set to set custom-domain. But we are missing to unset the custom domain if it is not used or incorrect.
unset Knative route domain for service

For example:
# To unset a route domain
kn admin domain unset --custom-domain mydomain.com

Usage:
  kn admin domain unset [flags]

Flags:
  -d, --custom-domain string  Custom domain to unset
  -h, --help                   help for unset

Global Flags:
      --config string   config file (default is $HOME/.config/kn/plugins/admin.yaml)

/assign
I would take a look at this new command.

Function code is ready, now I am waiting on https://github.com/knative/client-contrib/issues/14, then add test for unset.  I know @int8dev is working issue 14. Thank you.

PR submitted, https://github.com/knative/client-contrib/pull/38

PR merged, closing...


please complete eggwars plugin

make generators,shop,and more...

It is complete!

What!! itsn't Completed yet! test plugin

how to make generator signs and the villager isn't Spawn

Villager You must Spawn With Egg,and Generator With sign.

How write for me all the commands to make arena plz.

Invalid


EHPR-113 | Migrating to LZ2

let's rename this folder back to terraform after tearing down the temp env.
this way we don't have to have a big diff.


Throw an error if you try to pass an existing scribble to the scribble() function instead of text

So I don't know if this is by design or not, but it would probably not be a bad idea to make scribble complain if you try to pass an existing scribble (or just a struct in general ...or an array, or something else that you probably shouldn't be stringifying). Doing this wrongly can lead to some exotic consequences.

(I also got it to stack overflow once, although I'm not sure what the recursive structure was.)

Considered this in the past, but I came to the conclusiom that I don't want to make assumptions about what people want to draw

FINE but it's going to throw an error

Implemented for v7.2.0pre002


Add more optional features to the main futures crate

For convenience, the futures (well, futures-preview for now) crate re-exports from all of the futures-*. This can be a nice first experience, being able to use streams, sinks, channels, and what-not out-of-the-box. However, due to this, other libraries have been removing their dependency on futures to a smaller group that they need (such as futures-core and futures-util).
I think it could be useful if a library could depend on futures while disabling the pieces they don't need. So, like in hyper, it could have futures = { version = "0.3", default-features = false, features = ["util"] }.

Unfortunately, that doesn't work. Imagine you have this crate layout:
    futures
 /          \
A            B
 \          /
      C

Let's suppose that crate A uses default-features = false, but crate B does not.
In that case all of the default features will be enabled, and there is nothing crates A or C can do about it.
Some more context here.

That’s absolutely fine, if A only needs some limited subset of features but B needs them all then that is features working as intended. If B doesn’t need them all then that indicates that there needs to be more understanding in the ecosystem that default-features = false should be the default stance you take to all dependencies, and just activate what features you need.

@Nemo157 If B doesn’t need them all then that indicates that there needs to be more understanding in the ecosystem that default-features = false should be the default stance you take to all dependencies, and just activate what features you need.

Yes, that's exactly the problem. Every crate would need to use default-features = false and only enable the features they want. Even a single crate messing it up will affect every other crate.
Unfortunately, it's far too easy to mess up default-features and forget to use it. That problem doesn't happen nearly as much with separate crates (where there is a clear implicit understanding that an umbrella crate pulls in everything).
So, as an alternative suggestion, what if nothing was enabled by default in futures, and you had to selectively enable individual features. Then there would be an all feature which enables all the other features:
[dependencies]
util = { version = "0.3.0", optional = true, package = "futures-util" }
core = { version = "0.3.0", optional = true, package = "futures-core" }
executor = { version = "0.3.0", optional = true, package = "futures-executor" }

[features]
all = ["core", "util", "executor"]

This means you don't need to use default-features = false (which avoids all the issues with it), and it makes it impossible to screw up: you cannot accidentally enable all features.

Closing in favor of https://github.com/rust-lang/futures-rs/issues/2295.


Fit height of text facet to its contents when few options are present

When creating a text facet in a column where few different values are present, I get a facet with a lot of whitespace:

Proposed solution
When few options are present, the facet should shrink to a smaller size, without introducing a scroll bar:

When more options are available, it could potentially expand more than its default size, but that should not happen indefinitely: we should introduce a scroll bar past a certain length.
The facets should remain resizable by the user in any case.
Alternatives considered
None.
Additional context
Prompted by @ostephens's video on doing the Advent of Code 2022 with OpenRefine

I work with longer strings oftentimes, and so this is also highly dependent on the length of values (or the expression that created them to be longer).
I feel that a box size height of 1/3 the height of the left-panel could work as a sensible default? or should it be 1/2?  In other words, allow the height to grow up until either 1/3 or 1/2 the height of the left-panel ?

I would not try to change the default size of the facet or making it a proportion of the left panel. With the right CSS it should be possible to just fit to the content (which takes into account longer values which need wrapping on multiple lines).

OK, but at what height do we say a facet can grow to before we start showing a scrollbar?


Add Italian translation

Thanks a lot for the translations.
I have sent you invitation for this repository aswell (see mail), in-case you wish to update values in future.

Thanks a lot for the translations. I have sent you invitation for this repository aswell (see mail), in-case you wish to update values in future.

Thank you! I've accepted the invitation!


publicPath: settings.urls.publicPath() in webpack.common.js gives error

publicPath: settings.urls.publicPath() gives an error when running devmode.
Changing it to publicPath: settings.urls.publicPath solves it.

That doesn't make sense... it is indeed a function

Sorry. There seems to be something wrong with the settings file when we pull from this report.
It still was set to '/' instead of the function.


Additonal databases

Are there plans so the user can use a mysql/postgres db?

Thanks for opening an issue.
There are not plans to make different dbs configurable. There would be a lot of work required to swap out the models.


Decode htmlentities in emails and logs

It's real annoying (and I'm sure confusing to new users) to see escaped entities in emails and in the logs on the requests... I understand escaping for the purpose of the database, but these things should be decoded before being displayed and sent in emails.  I'm assuming that we are throwing them in the db with http://us2.php.net/manual/en/function.htmlentities.php and as such, when we pull them back out we should be using http://us2.php.net/html_entity_decode

Fixed in newinternal


cache with concatenated string of input function as key

tSache.h - added LRU cache implementation with concatenated string as key for a map based LRU cache

This was to test out the idea of using concatenated string as key which unfortunately does not improve performance. However, this repository is our own version of lru benchmark. I thought it would be good to have this for posterity purposes and may be it is useful in some other condition. Your call - we can keep that in this branch itself and not merge it.

This was to test out the idea of using concatenated string as key which unfortunately does not improve performance. However, this repository is our own version of lru benchmark. I thought it would be good to have this for posterity purposes and may be it is useful in some other condition. Your call - we can keep that in this branch itself and not merge it.

Yeah, I'd prefer that code in main is production quality (for all of our repos).


Code Implementation

I am getting the error-
Traceback (most recent call last):   File "carxcount.py", line 22, in <module>     detection_graph, category_index = backbone.set_model('ssd_mobilenet_v1_coco_2017_11_17') NameError: name 'backbone' is not defined

Can you try to run the program on python3?

Did you clone the whole repo or did you download just one file?


Add option to just "absolufy" level-up imports

At Astropy we are considering adopting absolute imports (https://github.com/astropy/astropy/issues/14021) but may not be ready to go all in. An option to only absolufy level-up imports, like from ..import <> would be greatly appreciated!

Hey @nstarman
thanks for the suggestion, but no thanks (you're welcome to fork though, this is MIT licensed)


Make array macros work with native JS arrays

The array macros (or most of them) assumed the source arrays to be Ember.Arrays which I don't think is necessary (and breaks without prototype extensions, e.g. in FastBoot).
Although CPs won't update correctly when defined on native JS arrays there's no reason why they should not compute correctly initially (and that's also what Ember's own array CP macros do).

@kellyselden: would be great to get this merged

Thanks a lot.


Add readme

Closes #540

See the branch in GitHub to see how the README renders: https://github.com/maxrchung/S2VX/tree/add-readme


Transient Networking Errors & Timing Delay

Hello,
I am running into a failure in our production environment with the async sensor.  I have observed a few odd behaviors in this and I'm looking for direction on troubleshooting steps. Ultimately we were able to clear the task and it ran successfully.

Network issue:

[2023-05-12, 09:22:00 UTC] {taskinstance.py:1851} ERROR - Task failed with exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/fivetran_provider_async/sensors.py", line 55, in execute_complete
    raise AirflowException(msg)
airflow.exceptions.AirflowException: error: Cannot connect to host api.fivetran.com:443 ssl:default [Connect call failed ('<IP_ADDRESS>', 443)]

[2023-05-12, 11:14:02 UTC] {taskinstance.py:1851} ERROR - Task failed with exception
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/fivetran_provider_async/sensors.py", line 55, in execute_complete
    raise AirflowException(msg)
airflow.exceptions.AirflowException: error: API requests to Fivetran failed 3 times. Giving up.

It would appear that this is a networking issue that might have been caused by a service outage from Fivetran.  However, we were able to trigger the sync in an upstream task and the sync completed without error in Fivetran.  The Fivetran status page isn't showing any server issues on the day.  Any troubleshooting suggestions would be appreciated.

Timing Delay

We are observing large delays between the task initialization and the execution.  Any information you can provide about why we might be seeing these timing delays would be appreciated.
Attempt 1: 1 hr 22 mintues
[2023-05-12, 08:00:16 UTC] {taskinstance.py:1465} INFO - Pausing task as DEFERRED. dag_id=marketing_app_data, task_id=sensor_fivetran_marketing_app, execution_date=20230511T080000, start_date=20230512T080016
[2023-05-12, 08:00:16 UTC] {local_task_job.py:164} INFO - Task exited with return code 0
[2023-05-12, 08:00:16 UTC] {local_task_job.py:273} INFO - 0 downstream tasks scheduled from follow-on schedule check

[2023-05-12, 09:22:00 UTC] {taskinstance.py:1165} INFO - Dependencies all met for <TaskInstance: marketing_app_data.sensor_fivetran_marketing_app scheduled__2023-05-11T08:00:00+00:00 [queued]>

Attempt 2: 1 hr
[2023-05-12, 09:23:01 UTC] {taskinstance.py:1465} INFO - Pausing task as DEFERRED. dag_id=marketing_app_data, task_id=sensor_fivetran_marketing_app, execution_date=20230511T080000, start_date=20230512T092301
[2023-05-12, 09:23:01 UTC] {local_task_job.py:164} INFO - Task exited with return code 0
[2023-05-12, 09:23:01 UTC] {local_task_job.py:273} INFO - 0 downstream tasks scheduled from follow-on schedule check

[2023-05-12, 10:22:40 UTC] {taskinstance.py:1165} INFO - Dependencies all met for <TaskInstance: marketing_app_data.sensor_fivetran_marketing_app scheduled__2023-05-11T08:00:00+00:00 [queued]>
[2023-05-12, 10:22:40 UTC] {taskinstance.py:1165} INFO - Dependencies all met for <TaskInstance: marketing_app_data.sensor_fivetran_marketing_app scheduled__2023-05-11T08:00:00+00:00 [queued]>

Attempt 3: 2 minutes
[2023-05-12, 10:23:42 UTC] {taskinstance.py:1465} INFO - Pausing task as DEFERRED. dag_id=marketing_app_data, task_id=sensor_fivetran_marketing_app, execution_date=20230511T080000, start_date=20230512T102342
[2023-05-12, 10:23:42 UTC] {local_task_job.py:164} INFO - Task exited with return code 0
[2023-05-12, 10:23:42 UTC] {local_task_job.py:273} INFO - 0 downstream tasks scheduled from follow-on schedule check

[2023-05-12, 10:25:49 UTC] {taskinstance.py:1165} INFO - Dependencies all met for <TaskInstance: marketing_app_data.sensor_fivetran_marketing_app scheduled__2023-05-11T08:00:00+00:00 [queued]>
[2023-05-12, 10:25:49 UTC] {taskinstance.py:1165} INFO - Dependencies all met for <TaskInstance: marketing_app_data.sensor_fivetran_marketing_app scheduled__2023-05-11T08:00:00+00:00 [queued]>

Attempt 4: 47 minutes
[2023-05-12, 10:26:51 UTC] {taskinstance.py:1465} INFO - Pausing task as DEFERRED. dag_id=marketing_app_data, task_id=sensor_fivetran_marketing_app, execution_date=20230511T080000, start_date=20230512T102650
[2023-05-12, 10:26:51 UTC] {local_task_job.py:164} INFO - Task exited with return code 0
[2023-05-12, 10:26:51 UTC] {local_task_job.py:273} INFO - 0 downstream tasks scheduled from follow-on schedule check

[2023-05-12, 11:14:01 UTC] {taskinstance.py:1165} INFO - Dependencies all met for <TaskInstance: marketing_app_data.sensor_fivetran_marketing_app scheduled__2023-05-11T08:00:00+00:00 [queued]>
[2023-05-12, 11:14:01 UTC] {taskinstance.py:1165} INFO - Dependencies all met for <TaskInstance: marketing_app_data.sensor_fivetran_marketing_app scheduled__2023-05-11T08:00:00+00:00 [queued]>

@mivinson could you share the DAG as well, please? I am not able to replicate the above scenario mentioned.

@mivinson can you kindly confirm if issue persists?


New developer trying my hand at this

https://developer.android.com/studio/run/emulator-acceleration#vm-mac

Since you're a new developer you probably didn't realise but you've filed an issue on the Now in Android app project. Issues are for letting the project team (and everyone else) that there's a bug in the project, or that you have a feature request. This doesn't seem to be either of those. Please open a new issue if there's something specific you'd like to report.


Target selection is spawned twice when debugging with npx

Bug Description
The target selection can be seen twice when debugging a typescript file using npx
refer #1061
Steps to Reproduce
start debugging a typescript file with this config:
{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch Control plane backend",
            "type": "node",
            "request": "launch",
            "cwd": "${workspaceFolder}",
            "runtimeExecutable": "npx",
            "runtimeArgs": [
                "ts-node",
                "main.ts"
            ],
         }
    ]
}

Backtrace
No response
Relevant Logs
No response
Your operating system and version
Darwin mehuls-air.lan 21.4.0 Darwin Kernel Version 21.4.0: Mon Feb 21 20:36:53 PST 2022; root:xnu-8020.101.4~2/RELEASE_ARM64_T8101 arm64
Local process
/opt/homebrew/bin/npx ts-node main.ts
Local process version
mehularora@mehuls-air ts-test % node -v v19.6.0, mehularora@mehuls-air ts-test % npx -v 9.4.0
Additional Info
No response

Fixed with #1080 #1081


update responsibleai-text and responsibleai-vision packages to responsibleai 0.32.0

Description
update responsibleai-text and responsibleai-vision packages to responsibleai 0.32.0
Checklist

[ ] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (596fc41) 88.49% compared to head (1388e5a) 75.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2420       +/-   ##
===========================================
- Coverage   88.49%   75.71%   -12.79%
===========================================
  Files         134       14      -120
  Lines        7702     1326     -6376
===========================================
- Hits         6816     1004     -5812
+ Misses        886      322      -564

Flag
Coverage Δ

unittests
75.71% <ø> (-12.79%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add Shining Lights by karin houou ft. PSYQUI

Song Name
Shining Lights
Artist Name
Karin Houou ft. PSYQUI
Source
Youtube
Youtube Link
RzTwehkbHkM
Direct File Link
No response
Song ID
202275
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 110972315
Downloaded: No

level ready to receive rate


EXC_BAD_ACCESS while serializing the data

Please be sure to include:

IOS 11.1

XCode 9.4

Swift 4.1

pod 'SwiftProtobuf', '~> 1.0'

My code is crashing when i try serialize Message with BinaryDelimited
Code Snippet:
let outputstream = OutputStream()
do {
try BinaryDelimited.serialize(message: message, to: outputStream, partial: false) //Crashes here
}
catch {
print(error.localizedDescription)
}
Thank you!

Sorry, but there really isn't enough to go on here.  What's the stack trace look like?  Can you make an example project that shows this?  We do have tests using the API that work, so it likely is something specific to your outputStream and/or message.

Can you please add a sample snippet how i should use BinaryDelimited.serialize ?
Thanks

This does look like a bug to report to Apple for the Swift wrapper on OutputStream. OutputStream() doesn't appear to make a working stream, but OutputStream(toMemory:()) and OutputStream.toMemory() do seem to be usable.

Thanks a lot @thomasvl . :)
It worked for me now after reading you test case.


Update command format and example messages

Closes #172
Closes #174

Codecov Report

Merging #212 (8fd3918) into master (edf290f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #212   +/-   ##
=========================================
  Coverage     51.14%   51.14%
  Complexity      616      616
=========================================
  Files           118      118
  Lines          2706     2706
  Branches        322      322
=========================================
  Hits           1384     1384
  Misses         1223     1223
  Partials         99       99

Impacted Files
Coverage Δ

...java/seedu/address/logic/commands/EditCommand.java
93.33% <ø> (ø)

...main/java/seedu/address/model/person/JobTitle.java
72.72% <ø> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
92.56% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf290f...8fd3918. Read the comment docs.


add priorityClassName value and logic

to address https://github.com/IBM/core-dump-handler/issues/150

@cqwense Sorry this took so long to land but I needed to fix the linting checks.
Thank you very much for this patch and I hope to get a new version out in the next week or so.


Enhancement/expose workfile artist note

Changelog Description
Exposing workfile artist note data so it can be easily be set programmatically, without having to interact directly with the UI. This can be use, for instance to set workfile artist note.
Additional info
Related to issue #5719.
Requested in PR #5660.
Testing notes:

Open any workfile.
Open workfile Qt menu.
Set artist note and save it.

Nice stuff - and great start!
I think it might be slightly too targeted to only artist notes by putting it in artist_notes.py - I'm not sure what a better filename would be however, but most of the functions are generalized enough for the Workfile document which I think is the interface we want.
In the end it'd be great if someone would be able to use it to also set and get studio specific metadata for a workfile.
data = get_workfile_data(filepath) or {}

Or something like
data = get_workfile_data(filepath) or {}
data["note"] = "my_note"
data["other_metadata"] = "other_value"
set_workfile_data(filepath, data)

Or am I over-generalizing the potential use cases?

Nice stuff - and great start!
I think it might be slightly too targeted to only artist notes by putting it in artist_notes.py - I'm not sure what a better filename would be however, but most of the functions are generalized enough for the Workfile document which I think is the interface we want.
In the end it'd be great if someone would be able to use it to also set and get studio specific metadata for a workfile.
data = get_workfile_data(filepath) or {}

Or something like
data = get_workfile_data(filepath) or {}
data["note"] = "my_note"
data["other_metadata"] = "other_value"
set_workfile_data(filepath, data)

Or am I over-generalizing the potential use cases?

In this case, it only takes a really small change to make it more reusable, so might as well do it. Good point.

Because we're splitting OpenPype into ayon-core and individual host addons, this PR would have to be re-created to target one of those.
We're closing it down, but we'll he happy for a new PR to ynput/ayon-core repository once it's up.


Unable to use Snap packages on Ubuntu images

On a fresh install the snap install ubuntu-core fails. Seems to have been fixed in 4.8.14-apparmor-1 but broken again in 4.8.14-apparmor-2 ? https://github.com/scaleway/kernel-tools/issues/313
root@chat:~# uname -r
4.8.14-apparmor-2

root@chat:~# lsb_release -r
Release:        16.04

root@chat:~# snap install ubuntu-core
64.48 MB / 64.48 MB [======================================] 100.00 % 2.79 MB/s

error: cannot perform the following tasks:
- Make snap "ubuntu-core" available to the system (can not set next boot: cannot determine bootloader)

looks like it's due to missing xz support in squashfs:
[14731.123184] squashfs: SQUASHFS error: Filesystem uses "xz" compression. This is not supported

so the solution would be to enable CONFIG_SQUASHFS_XZ in the kernel config

actually, at least on arm, the latest kernel (armv7l 4.10.8 apparmor) seems to work; I would still look at dmesg to see if it complains about something

I cannot use snaps in any of the 4.10 kernels

It's posisble to use snaps on:
4.10.8-apparmor-1
Distributor ID:	Debian
Description:	Debian GNU/Linux 9.0 (stretch)
Release:	9.0
Codename:	stretch

I confirm that Ubuntu Xenial images both for ARM and x64 do not work :(

I confirm that, snaps not working on Xenial x64.
Screenshot of the error: http://joxi.ru/Y2Ll9Q9iR8R126

Confirmed not working on Xenial x86_64.

Not working with Xenial on an amd64 server :(

Not working either for me, Xenial on x86_64

SOLVED, to anyone looking for a solution, changing the bootscript to 4.9.20 in the scaleway control panel fixes the issue

the problem presists

@tcarrondo try different bootscripts (preferably more recent ones, that will probably solve the problem)
In fact I found that updating the bootscript solved many issues, notably using SHA512 on OpenVPN on an old bootscript was unbearably slow, updating the bootscript solved it for me

I've already tried all of them

Had same issue on an instance created today, solved by using this bootscript: x86_64 4.10.8 apparmor #1


Reverts both "[#4245] Allow password to nil (#4261)" and "Add more tests (#4970)"

Closes #5033
More info in https://github.com/plataformatec/devise/issues/5033#issuecomment-476386275.

Thanks! Will there be a release shortly that includes this?

@jbeker We already released 4.6.2 including these changes 😄
https://github.com/plataformatec/devise/releases/tag/v4.6.2
https://rubygems.org/gems/devise/versions/4.6.2

@mracos brilliant! thanks!


Ads pause/resume on click instead of click through on mobile

The issue is that preroll ads pause/resume on click rather than trigger navigation to the click through url for the ad - but only on mobile devices.
I've been wrestling with this in my implementation so I went back to the advanced example and found the same out-of-the-box behavior with those files. I changed the relative links to absolute just to avoid downloading those files, but otherwise I'm just using the raw example index.html, ads.js and style.css files served via python SimpleHTTPServer. I see this when testing in Chrome as well as on an iOS device.
To reproduce:

serve up the advanced example files (somewhere)
with the browser window open in normal desktop mode, navigate to the example index.html
click the sample link to load the sample tag
click the play button and see the ad start playing
click the ad and see a new window open to the click through url
close ad window
put browser in mobile simulator mode (for Chrome: opt-cmd-j, toggle device toolbar, select a mobile device - I chose iPhone X)
navigate to/refresh example index.html
click the sample link to load the sample tag
click the play button and see the ad start playing
click the ad and see the ad pause without opening a new window to the ad click through url as expected

Is this expected behavior that I missed described somewhere? If so, can it be changed to have mobile devices navigate to the ad click through urls? Thanks!

My slightly altered index.html, just in case that helps...
index.html.zip

So after a few days of poking at this and reading around it looks like this behavior is by design. In my case the only thing on the screen was a navbar at he top that was just tall enough to cover the "Learn More" button on the full screen video. I've now hidden that navbar during video playback and the "Learn More" button shows and works.
The lack of any kind of response here makes me think no one is reading these issues, but on the off chance this does get seen I'd like to suggest finding some way to surface these kinds of issues and make them more visible. I had to dig into update notes 3+ years old (https://developers.google.com/interactive-media-ads/docs/sdks/html5/v3/history) to find the information that ads no longer had a full screen tap target. If issues like this are already presented somewhere that I managed to not find (entirely possible), then please point me in that direction so I can refer to that resource with questions like this in the future.

This is designed. On mobile there will be something like "Learn More" button to click through, not the whole player!


Add a new rendering approach for far distance chunks to support very far rendering distances

@KaiKratz and I discussed a new and very stylized rendering approach for supporting very, very far rendering and viewing distances.
Summary

We'll create a new chunk tessellator based on the Marching Cubes algorithm for chunks in the distance
Those chunks will be created using a grid which size we'll increase according to viewing distance
The rendering of the vertices will be based on a baked vertex color which can be defined for each cube
The shader for those chunks will be very simplistic and will only use vertex colors for rendering
The meshes of those far distance chunks will be written to the HD and directly uploaded to the GPU if needed
The meshes of the chunks will only be updated if anything changes within the chunk

Open questions

Lighting?

This approach should reduce the overall vertex count and the overall memory usage drastically while using much larger viewing distances.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/487243-add-a-new-rendering-approach-for-far-distance-chunks-to-support-very-far-rendering-distances?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F5279&utm_medium=issues&utm_source=github).

For those who want to do this ticket:
Be aware that distance rendering is more than just rendering. The world needs be generated/loaded first. Having everything in memory might not be possible. The world gets loaded chunk wise. Each chunk is 32x32x64 blocks large. The game loads and unloads chunks as the player moves through the world. Unloaded chunks remain in memory till they got saved to disk via a automatically occurring autosave.
Objects (called entities in terasology) in a chunk get currently loaded and saved together with the chunks. The entities do not just get loaded with the chunk but get also activated with the chunk. It is questionable if we need for example a deer to walk around in a chunk that got just loaded to render a chunk that is far far away. Changing the timing of how objects/entities get loaded/unloaded will propably not something done quickly. An alternative could be to generate an optimized render only structure for chunk that get loaded and save it for quick reuse once the chunk the player is on is far away. This isn't easy either since it also means that a new way to load/save this light weight chunk versions of the chunk is needed.
A chunk goes through multiple steps till it is fully loaded and gets rendered. For example before a chunk gets loaded, the game first calculates how light gets to it from the bordering chunks. In addition to that the game renders a chunk only once all adjacent chunks are also ready for rending in order to get border blocks correctly done. This means that currently 5x5x5 chunks need to be loaded before the first chunk can be rendered. See https://github.com/MovingBlocks/Terasology/issues/1886 for more details about that issue. Even if you don't have a nice idea for fixing it, having a look at the code
might get you started in the area of chunk loading.
Another aspect to keep in mind is multiplayer. Transfering also chunks in great distances to all clients might be to much for the server. One possible solution could be to offer a "Render skybox/sphere for this chunk" option. The option could allow a player to render a skybox with the surroundings of a chunk in very very far distances. The rendering could be performed with the normal renderer. The final rendering could then be stored on the server and sent to other clients when the client enters the chunk. Sending other optimized far distance simplifications to clients might also be an option.

Could just be simple and only cache the data locally only when once
downloaded normally from the server (perhaps just a simple 3d array of
integer colors to render the 'far' blocks with or something, could even do
2d if it is truly far), so they will not see the far distance until
visited, but after that they will see it fine, the server could even send
such 'cached color data' on occasion too.
On Fri, Mar 4, 2016 at 4:26 PM, flo<EMAIL_ADDRESS>wrote:

For those who want to do this ticket:
Be aware that distance rendering is more than just rendering. The world
needs be generated/loaded first. Having everything in memory might not be
possible. The world gets loaded chunk wise. Each chunk is 32x32x64 blocks
large. The game loads and unloads chunks as the player moves through the
world. Unloaded chunks remain in memory till they got saved to disk via a
automatically occurring autosave.
Objects (called entities in terasology) in a chunk get currently loaded
and saved together with the chunks. The entities do not just get loaded
with the chunk but get also activated with the chunk. It is questionable if
we need for example a deer to walk around in a chunk that got just loaded
to render a chunk that is far far away. Changing the timing of how
objects/entities get loaded/unloaded will propably not something done
quickly. An alternative could be to generate an optimized render only
structure for chunk that get loaded and save it for quick reuse once the
chunk the player is on is far away. This isn't easy either since it also
means that a new way to load/save this light weight chunk versions of the
chunk is needed.
A chunk goes through multiple steps till it is fully loaded and gets
rendered. For example before a chunk gets loaded, the game first calculates
how light gets to it from the bordering chunks. In addition to that the
game renders a chunk only once all adjacent chunks are also ready for
rending in order to get border blocks correctly done. This means that
currently 5x5x5 chunks need to be loaded before the first chunk can be
rendered. See #1886
https://github.com/MovingBlocks/Terasology/issues/1886 for more details
about that issue. Even if you don't have a nice idea for fixing it, having
a look at the code
might get you started in the area of chunk loading.
Another aspect to keep in mind is multiplayer. Transfering also chunks in
great distances to all clients might be to much for the server. One
possible solution could be to offer a "Render skybox/sphere for this chunk"
option. The option could allow a player to render a skybox with the
surroundings of a chunk in very very far distances. The rendering could be
performed with the normal renderer. The final rendering could then be
stored on the server and sent to other clients when the client enters the
chunk. Sending other optimized far distance simplifications to clients
might also be an option.
—
Reply to this email directly or view it on GitHub
https://github.com/MovingBlocks/Terasology/issues/319#issuecomment-192519223
.


feat: Consume Docker system events asynchronously

This feature make it possible to consume docker system events asynchronously using the DockerAsync client implementation.
Fixes issue #312
How to use
<?php

// filename : ./examples/listen-to-docker-events-async.php

use Docker\DockerAsync;
use Docker\Stream\ArtaxCallbackStream;

require dirname(__DIR__) . '/vendor/autoload.php';

Amp\Loop::run(function () {
    $docker = DockerAsync::create();

    /** @var ArtaxCallbackStream $events */
    $events = yield $docker->systemEvents();
    $events->onFrame(function ($event): void {
        // Do something with the docker event
        // var_dump($event);
    });

    // Start listening to Docker events
    $events->listen();

    // Close the request when a SIGINT signal is received
    Amp\Loop::onSignal(SIGINT, function (string $watcherId) use ($events) {
        $events->cancel();
        Amp\Loop::cancel($watcherId);
    });
});

@joelwurtz The job that generate the coverage report keep failing on me. And yet, #ItWorkOnMyMachine ;)
Do you have the same issue on your machine ? I'll try to use the same Docker binary than the job in question.

@joelwurtz Okay, after much investigation I found why the Travis job that generate the coverage report was failing :
In the .travis.yml at https://github.com/docker-php/docker-php/blob/master/.travis.yml#L40 you are specifying the --prefer-lowest flag which make composer retrieve an unstable version of amphp/artax. The issue in question was fixed in version 3.0.6. But for good measure, I just replaced $events->cancel() by Loop::stop() in my test case.

Thanks for this and sorry for the long awaited time.


Yatin: Watch<PHONE_NUMBER>2

Yatin requests the watch of the watch_number<PHONE_NUMBER>2. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by tripleee in Charcoal HQ

Approved by tripleee in Charcoal HQ


Be able to save a picture from the frontend and have it saved in the backend

 Be able to save a picture from the frontend and have it saved in the backend


Ruff fails to exclude a file, tries to parse it, and bails

I have a git repository. Since it’s a cookiecutter template, it contains a directory called {{cookiecutter.project_name}}[sic]. I try to run Ruff on the other files in the repo like this:
$ ruff "--extend-exclude=\\{\\{cookiecutter.project_name\\}\\}/**" --force-exclude -v .
[2023-04-27][17:17:32][ruff::resolver][DEBUG] Ignored path via `exclude`: "/Users/phil/Dev/cookiecutter-scverse/.git"
error: TOML parse error at line 50, column 1
   |
50 | {% if cookiecutter.project_name.lower().replace('-', '_') != cookiecutter.package_name -%}
   | ^
invalid key

Ruff shouldn’t try to parse that TOML file, I’m excluding it!

Hmm yeah, that does look like a bug. I thought I'd fixed this in #3588, just confirming that you're on a recent release?

The linked PR suggests v0.0.250 -- mind checking if something like v0.0.260 or newer resolves this?

Huh, did use a freshly installed command line Ruff to verify (without actually checking if it was the newest version), but now I can’t reproduce it.
Apologies!


fix if router name or cluster name is too long, write file will be fa…

…iled
Issues associated with this PR
Your PR should present related issues you want to solve.
Solutions
You should show your solutions about the issues in your PR, including the overall solutions, details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases. And you need to show the UT result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result.
Code Style

Make sure Goimports has run
Show Golint result

Codecov Report

Merging #1163 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
- Coverage   56.16%   56.14%   -0.02%
==========================================
  Files         268      268
  Lines       25425    25540     +115
==========================================
+ Hits        14279    14340      +61
- Misses       9780     9823      +43
- Partials     1366     1377      +11

Impacted Files
Coverage Δ

pkg/config/v2/common.go
100.00% <ø> (ø)

pkg/config/v2/route.go
74.11% <0.00%> (-1.79%)
:arrow_down:

pkg/config/v2/upstream.go
68.91% <0.00%> (-1.92%)
:arrow_down:

pkg/admin/store/effectiveconfig.go
76.54% <0.00%> (-16.00%)
:arrow_down:

pkg/module/http2/transport.go
78.47% <0.00%> (-0.15%)
:arrow_down:

pkg/admin/server/server.go
90.32% <0.00%> (+0.66%)
:arrow_up:

pkg/upstream/cluster/cluster.go
80.95% <0.00%> (+0.75%)
:arrow_up:

pkg/upstream/healthcheck/healthchecker.go
88.17% <0.00%> (+1.17%)
:arrow_up:

pkg/admin/server/apis.go
50.72% <0.00%> (+11.27%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1bfa89...874ff4f. Read the comment docs.


Can no longer control more than one vessel

Somewhere, I've lost the ability to control two or more vessels. Seems everything is fine if I stick to one vessel, but the OFF commands get very lost if I have more than one.

This seems to be related to the number of HEAT_PIN units I have set in the config. If I have a second pin configured, the first pin will lose track of what's going on when I enable the second vessel. By commenting out the second pin, I can track two temperatures and control the first vessel.


Adds a skeleton NUSense as a module with arduino based firmware

Add code to compile a NUSense compatible binary using the Ardiuno framework.
It adds the necessary.
This PR is just here as a reference of what is possible. There is no expectation that you use this for NUSense itself.
I'm not the biggest fan of the cmake code I stole to integrate the arduino code into a cmake project
If I get bored I might rewrite it better.

@Bidski does not like the idea at all

The idea doesn't even like this idea lol


Create custom 404.html page

Created a simple 404 page in the app's theme.  Probably good enough for now.  Closing issue.


Implement Magma and Searing Totem for use with Elemental Devastation

Hey there!
To get correct sims using the Elemental Devastation talent we need to have either (or both) Magma and Searing totem implemented since they both can trigger the talent.
If you don't have the time for this I would love to help out but I'm a C# developer by trade so I need a push in the right direction on how to do that.

Apparently, Wowhead lied to me when it said that the talent affected the totems and it doesn't work so I'm closing this.


A few fixes/simplifications to TrioManager

While debugging a crash on a trio-based Service, I noticed TrioManager was swallowing the exception causing the crash and instead reporting me just a DaemonTaskExit. I fixed that in the first commit here, but when doing so I realized there were a couple things which could be simplified
The second commit changes the run() method to cancel the system nursery directly instead of relying on an async task to do so
Finally, the third commit does away with the system nursery altogether, as well as the _cancelled event
Looking at the diff from each commit is probably useful, but ultimately I'd suggest reviewing the whole run() method in its new state
I'd be happy to split this into separate PRs if you'd prefer

My changes here seem to have broken some discv5 tests in trinity. I'm trying to find out how to write a test that reproduces it so that I can fix. I'll wait until I have that fixed to merge this

Ok, found and fixed the bug in the last commit. Care to have another pass at it, @pipermerriam?