Reject FHIR resources with the null char \u0000 or similar control chars

Is your feature request related to a problem? Please describe.
During a database reindex, the server began returning 500 Server Errors for a specific resource instance.
It turns out that one of the resources contained a string that included \u0000 but PostgreSQL does not allow the null char in its strings.
The original resource content was stored successfully because we gzip the resource contents before saving it to the DB.
However, now the element that contains this character is matching on a new search parameter and so that is what causes the problem.
The spec says this:

Strings SHOULD not contain Unicode character points below 32, except for u0009 (horizontal tab), u0010 (carriage return) and u0013 (line feed).

Describe the solution you'd like
Strictly enforce this guidance as part of constructing model types that extend String or Uri.  Instead of allowing it in resource content but not in extracted fields, just reject resources with it up front.
This is the preferred approach because it avoids data quality issues up-front.  For example, the NULL char can be used for certain exploits as described at https://owasp.org/www-community/attacks/Embedding_Null_Code
As part of https://github.com/IBM/FHIR/issues/2424 we are no longer running parse validation when we read resources from the database, so it should be safe to add without introducing an "escape hatch" that disables the added validation.
A consequence of this is that certain actions like Patch or Reindex could fail (potentially in a confusing way) until the previously-ingested data is fixed to avoid these problem characters.
Describe alternatives you've considered
The main alternative is to allow these characters in both resource content and extracted/indexed fields.
In this case, we should still probably add a WARNING to the output so that users are still informed that they are not following this SHOULD clause in the spec.
To work around the specific issues with the \u0000 char in postgresql, we'd want to replace this character with something like https://www.fileformat.info/info/unicode/char/fffd/index.htm.
Acceptance Criteria

GIVEN a resource contains the \u0000 char
WHEN its posted to the server
THEN it is rejected with a clear error message

GIVEN a resource has already been ingested with the \u0000 char
WHEN the resource is reindexed
THEN it fails with a clear error message

Additional context
https://github.com/IBM/FHIR/issues/2424 contains some related discussion, but I don't think that we ever really addressed the root issue.

team decision:  default should be to reject resources that include invalid Unicode character points below 32.  validation to be done during object construction.  we should also introduce a new config parameter on ModelConfig and expose that from fhir-server-config (default to strict and keep out of default/example configs)

Test cases:
I played with the Resource string as an InputChannel and injected invalid characters under 32 (not 9,10,13) and the JSON parser from Eclipse Parsson throws an Exception as an invalid. I have test cases to support JSON, and I don't think there is any action needed to further protect the JSON payload and UNICODE character set.
Next steps:

Try specialized search value parameter coding
Try XML

With the XML Parser it's possible to get the control characters.


Deploy to PyPI

Hello. I looked for this package on PyPI and didn't see it there. I was wondering if it could be deployed to PyPI so I don't have to use a Git repo/commit hash in my requirements.txt file. Thanks!

Hi Grant, I'm glad you're finding this package useful.
To be honest, we're mostly ruby developers here so the Python package hasn't seen much love since @ruairif our main python guy moved on.
If the package is useful to you, I'll look into deploying it to PyPi.

@grantmcconnaughey Sorry for the delay. I've uploaded this package to the pypi test server.
Before I deploy it to the main PyPi servers, would you be able verify that it's working as expected? I'm not a python developer and it's my first time packaging a library, so an experienced set of eyes would be great.
You can install the package from the PyPi test servers by running:
pip install -i https://testpypi.python.org/pypi onepagecrm

Sure thing! Give me a day or two please. Gotta attend a wedding tomorrow.

@grantmcconnaughey did you get a chance to take a look?
Thanks again!

@peteretep Apologies, I got busy with work and completely forgot about this. I just created a new virtual environment and installed the package with pip. Then I started the python interpreter and imported the onepagecrm module. Everything worked fine.

that's great - thanks. I'll put it onto pypi later today.

can now be installed by running pip install onepagecrm


Turbolinks fails with target = "_self"

Describe the bug
When the target of a link is set to self, target = "_self", turbolinks stops working on that link
Steps to reproduce the behavior:

add target = "_self" to anchor tag.

Expected behavior
Since "_self" is the default target for a link, I believe it should not trigger a full page reload.

maybe this code snippet helps you. :not([target])
r.prototype.getVisitableLinkForNode = function (t) {
    return this.nodeIsVisitable(t) ? e.closest(t, "a[href]:not([target]):not([download])") : void 0;
};


Issues using helm with a Rancher Kubernetes Stack cluster

I was trying to connect to the Rancher Kubernets cluster via kubectl, in order to run some PODs creations via helm, and reuse some codes ...
helm ls
Error: client version is incompatible
kubectl --namespace=kube-system get pods | grep tiller
tiller-deploy-3991468440-fvx63          1/1       Running   0          9d
Any Idea?
helm version
Client: &version.Version{SemVer:"v2.2.3", GitCommit:"1402a4d6ec9fb349e17b912e32fe259ca21181e3", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.1.3", GitCommit:"5cbc48fb305ca4bf68c26eb8d2a7eb363227e973", GitTreeState:"clean"}
Here my kube config (Directly from Rancher Console):
kubectl config view
apiVersion: v1
clusters:

cluster:
insecure-skip-tls-verify: true
server: https://rancher-server-master.riglet:8080/r/projects/1a29/kubernetes
name: Kubernetes1
contexts:
context:
cluster: Kubernetes1
user: Kubernetes1
name: Kubernetes1
current-context: Kubernetes1
kind: Config
preferences: {}
users:
name: Kubernetes1
user:
username: 379...........2BE0BC
password: kqK1W....................i5Xee

As the error suggests, your helm client and tiller versions differ. Follow the docs to upgrade your tiller instance to v2.2.3 and you're all set.

helm init --upgrade
$HELM_HOME has been configured at /Users/hellgate75/.helm.
Tiller (the helm server side component) has been upgraded to the current version.
Happy Helming!
helm ls
Error: client version is incompatible

@fabriziotorelli-wipro Is the tiller-deploy pod showing the correct tiller image version?

Any update on this one?

closing as inactive.


Unread messages counter issue

With the last 1.4.1 prebuilt version on Mac OS Sierra, I got an issue about the number of unread messages.
When I receive one message, the counter shows 20+ over the profile pics in the conversation list.

Known bug, already solved but not included in the release, thanks for reporting!!
:)
see #476


Task server Docker changes and backend tasks changes

What changes were proposed in this pull request?
Task server docker changes. Created a process hue_celery and hue_redis which is controlled by Supervisord. Added helper functions which fetches the status of tasks from redis and passes on to the react component (task server page).
How was this patch tested?
Manual testing(File uploads on HDFS, S3, Azure, Ozone. Task server page fetches the tasks. Tested scheduling and killing tasks in task server page), bug bash.
Following hue.ini configs required to test:
[desktop]
enable_chunked_file_uploader=true
[filebrowser]
max_file_size_upload_limit=-1 # Bytes
[[task_server]]
enabled=True
beat_enabled=True
fetch_result_limit=20000
result_storage='{"BACKEND": "django.core.files.storage.FileSystemStorage", "properties": {"location": "./logs"}}'
broker_url="redis://localhost:6379/0"
celery_result_backend="redis://localhost:6379/0"
celeryd_opts='--time-limit=300'
execution_storage='{"BACKEND": "django.core.cache.backends.locmem.LocMemCache", "LOCATION": "celery-hue"}'

I'll create a new PR with Unit tests and submit it.


Setup a auth for NATS with nk on POC

The idea here is setup auth for NATS using NK

Closed on #32


Add license header lint

Copied over from ec-cli repository.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (518b1c4) to head (85732d0).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #958   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          103       103
  Lines         4884      4884
=========================================
  Hits          4884      4884


Add  to delete a word, like command line mode

In command line typing mode <CTRL-U> is used to delete the whole input, and vim-clap already implements that. Similarly,  <CTRL-W> deletes a single word in command line, however vim-clap doesn't implement <CTRL-W>.
There are potentially other command-line editing key mappings in vim, I suggest that moving forward, vim-clap adopts those as much as possible.
p.s. I want to thank @liuchengxu for implementing my previous feature request #536 within hours

Neovim already has this, but not vim as it's not focusable and I won't do this kind of job in the plugin, ref https://github.com/vim/vim/issues/5639 and #306.

Seemingly not super hard to support this feature, feel free to try #927.


Allow updating fixtures output with --update-snapshots

Right now, it's impossible to update fixtures output automatically. You have to delete the output files and regenerate them.
This PR allows us to automatically update fixture output when --update-snapshots is passed in as we do for snapshots.
@sebmck since fixtures output aren't exactly snapshots (output is *.txt), Would it be better to have a different flag --update-fixture? Or should we update the fixture to output *.md and maybe make use of SnapshotManager?

The current fixtures stuff predates Rome having snapshots so it's definitely very janky.

@sebmck since fixtures output aren't exactly snapshots (output is *.txt), Would it be better to have a different flag --update-fixture? Or should we update the fixture to output *.md and maybe make use of SnapshotManager?

I'm wondering if we can just use t.snapshot here instead of doing any of the output.txt stuff. It's problematic since there's only one snapshot per test file. But I wonder if we can solve that somehow by automatically sharding them, or maybe it's actually not that big of a deal to have a multi megabyte snapshot since we're going to end up having to read them all anyway.

The current fixtures stuff predates Rome having snapshots so it's definitely very janky.

@sebmck since fixtures output aren't exactly snapshots (output is *.txt), Would it be better to have a different flag --update-fixture? Or should we update the fixture to output *.md and maybe make use of SnapshotManager?

I'm wondering if we can just use t.snapshot here instead of doing any of the output.txt stuff. It's problematic since there's only one snapshot per test file. But I wonder if we can solve that somehow by automatically sharding them, or maybe it's actually not that big of a deal to have a multi megabyte snapshot since we're going to end up having to read them all anyway.

I think it should be possible to refactor SnapshotManager a bit to allow us to use t.snapshot and still output separate files as it's doing now. I'll look into it
I'll try to avoid having one giant snapshot file

@sebmck I updated the snapshot api to add an optional output filename. If the output filename is given, then we write the snapshot using that filename instead of the default .test.md.
This allows us to have a different output file for each fixture by specifying the output file name like so t.snapshot(ast, undefined, outputFile.join());
I didn't include the snapshots themselves in this PR to avoid diff noise. Let me know what you think and if it's good, I'll update the snapshots to make CI pass.

Nice! That's a great solution. I'll review this PR when I can but just wanted to leave a comment first.

This is awesome, thank you! I'll merge as-is and do a follow up PR with some nits.


V2.0.7

Coverage decreased (-0.02%) to 86.646% when pulling 3c7466995b9e9e214abc9fa2b3567e068562e5f2 on v2.0.7 into cc7a6756c99402ce5c7bb575c0fc92df385e5ec4 on master.

Coverage decreased (-0.02%) to 86.646% when pulling 3c7466995b9e9e214abc9fa2b3567e068562e5f2 on v2.0.7 into cc7a6756c99402ce5c7bb575c0fc92df385e5ec4 on master.


Station list

Pull online station list and choose from it
Overview page:
https://www.ncei.noaa.gov/products/land-based-station/global-historical-climatology-network-daily
Station_list:
https://www.ncei.noaa.gov/pub/data/ghcn/daily/ghcnd-stations.txt

done!


[Feature Request]: Breadcrumb component

Couldn't find a Breadcrumb component:
https://ui.shadcn.com/docs/components/breadcrumb

oh please nevermind https://github.com/sek-consulting/solid-ui/pull/98


HV-1239 Programmatic API for configuring container element constraints

@gsmet Could you take a first look and let me know what you think? It only supports getters right now, but it puts all the foundations in place, adding the other elements will be very simple.

Ok, thanks!

@gsmet, @emmanuelbernard: one thing I've been wondering: should we rename containerElement() to containerElementType()? It may appear as splitting hair, but the constraints are put to the type, not the element itself.
Alternatively, one could split it up into typeArgument() (generic containers) and componentType() (arrays). The names would be a bit better to comprehend, but both would do the same, so I don't like it too much.
Note my considerations are primarily driven by applying the same concepts/names to the spec XML schema, hence the extensive consideration.
Thoughts?

@gsmet Ready for review (apart from the renaming discussing above, I'd favor containerElementType(). Also there is one glitch with the API, there are some illegal state transitions. E.g. you can do:
.type( FishTank.class )
    .property( "model", FIELD )
        .containerElement()
            .parameter( 1 )

Going straight to a method parameter doesn't make sense of course. I'm sure it could be resolved (by having multiple ContainerElementConstraintMappingContext interfaces, one for property/parameter/return-value.
But I couldn't make it work impl-wise so I gave up on this eventually (a runtime exception is raised when calling the methods in an unsupported location). Should someone else have the energy to give it a try, I'd be happy to merge it as a follow-up, otherwise I think it's good enough.

Btw. that's another project idea I had ;) Define the states of such an internal DSL and the valid transitions (ie. allowed method calls) in some abstract means (external DSL?) and then have a generator for creating the required interfaces for only exposing the allowed ops in each state and class bodies to be implemented. Just dreaming of this, though :)

Rebased. Added one more commit more geared towards HV-1245, too, @gsmet.

Alternatively, one could split it up into typeArgument() (generic containers) and componentType() (arrays). The names would be a bit better to comprehend, but both would do the same, so I don't like it too much.

So I tend to agree that splitting it would make the names clearer but as it's the exact same thing, it feels weird to have 2 different names. So I concur with you that keeping one name is better.

Should someone else have the energy to give it a try, I'd be happy to merge it as a follow-up, otherwise I think it's good enough.

Agreed, it's good enough as is.
I added one commit to reindent a test and removed the last commit. Expect a follow-up on this very subject.


Add ability to reorder deep array items.

I have an array, defined in fields like array[].key1, array[].key2.
Besides the usual operations on nested fields, I also need an ability to re-order items in array in a way I see fit.
Right now, I'm doing this using value copying and then doing removeField(oldIndex) addField(item, newIndex), but addField behavior is very strange on me.
Instead of re-initializing nested values with values provided to addField, it adds a new item in the provided index, with only a field called value containing values object I have passed to addField.
I suggest either fixing this, or adding an explicit method called reorder that would accept old and new indexes for re-ordering.
Also, removing element from array somehow does not update form state, and form remains pristine.

Related to #391

There is a swapFields(indexA, indexB) function, but if you're doing complex sorting, that is potentially a lot of actions to dispatch for every swap.
I'll consider some sort of remapping option, but it might require thunk middleware...

See https://github.com/erikras/redux-form/issues/386#issuecomment-215758323


Help: How to stop the chain if no chunks are retrieved?

Issue you'd like to raise.
I am using ConversationalRetrievalChain for RAG based chatbot and I am using custom retriever to get the relevant chunks.
custom_retriever = FilteredRetriever(
        vectorstore=vectorstore.as_retriever(search_kwargs={"k": 5, "filter": {}}, search_type="mmr"),
        category=sess_metadata["category"],
        product=sess_metadata["product"],
        service=sess_metadata["service"],
    )

qa_chain = ConversationalRetrievalChain.from_llm(
        llm=llm,
        retriever=custom_retriever,
        chain_type="stuff",
        combine_docs_chain_kwargs=QA_PROMPT,
        return_source_documents=True,
        verbose=True,
    )
    result = qa_chain({"question": translated_query, "chat_history": chat_history})

If no chunks are retrieved then I don't want the LLM to execute and just return a simple response to the customer.
How can I do that?
Suggestion:
No response

I have a question how does llm chain stops.What are the stoping criteria for llm chain.How does llm chains knows whent to stop
.In coding where it is written.


scroll up is very slow in vim file when scrolloff=0

Steps to reproduce
gvim --clean -c "set scrolloff=0" $VIMRUNTIME/autoload/python.vim
And continue to press  'j' key. Scroll down is comfortably fast.
Then, continue to press  'k' key. Scroll up is very slow.
Expected behaviour
Scroll up is as comfortable as scroll down.
Version of Vim
Probably 9.0.673 or later (9.0.672 has no problem)
Environment
Windows 10
Logs and stack traces
No response

What if you disable syntax highlighting?
You do have 'smoothscroll' off, right?
Could you build Vim with parts of the 9.0.673 patch reversed, and check which one matters?
E.g. you could change this line:
	if (curwin->w_topline > 1 || curwin->w_skipcol > 0)

Back to:
if (curwin->w_topline > 1 )

If the line 2136 is commented out, it becomes fast.
	    redraw_later(UPD_NOT_VALID);

I tried to change line 1855 but both are still slow. However, when looking at 672 and 673, line 2307  on 9.0.887 looks like what we should check and tried to change the line. Then, UPD_SOME_VALID is still slow but UPD_REDRAW_TOP becomes fast.

I tried to change line 1855 but both are still slow. However, when
looking at 672 and 673, line 2307  on 9.0.887 looks like what we
should check and tried to change the line. Then, UPD_SOME_VALID is
still slow but UPD_REDRAW_TOP becomes fast.

Please show the diff of the changes you made.
--
Ed's Radiator Shop: The Best Place in Town to Take a Leak.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

That is now line 1855. We can't remove it, when w_skipcol is changed a redraw is needed. But we should not need to redraw everything.

I think we can add a check to make sure smoothscroll is active so we don't unnecessarily redraw:
diff --git a/src/move.c b/src/move.c
index e255bd68e..c8b7316e6 100644
--- a/src/move.c
+++ b/src/move.c
@@ -2301,7 +2301,7 @@ scroll_cursor_top(int min_scroll, int always)
        check_topfill(curwin, FALSE);
 #endif
        // TODO: if the line doesn't fit may optimize w_skipcol
-       if (curwin->w_topline == curwin->w_cursor.lnum)
+       if (curwin->w_topline == curwin->w_cursor.lnum && curwin->w_skipcol != 0)
        {
            curwin->w_skipcol = 0;
            redraw_later(UPD_NOT_VALID);

I checked that the tests still pass with this change.
FWIW I think smoothscroll is currently doing a lot of unnecessary redraws with redraw_later(UPD_NOT_VALID) so it's worth looking at proper ways to redraw it at a later time (it's on my bucket list to file after the immediate bugs were fixed), but for now I don't think we need to do these redraws at all unless we have smoothscroll active, to avoid causing regressions for people not using this.

Here is a diff on 9.0.887.
*** moveOrig.c	Fri Oct 21 10:47:38 2022
--- move.c	Thu Nov 17 10:15:55 2022
***************
*** 2304,2310 ****
  	if (curwin->w_topline == curwin->w_cursor.lnum)
  	{
  	    curwin->w_skipcol = 0;
! 	    redraw_later(UPD_NOT_VALID);
  	}
  	if (curwin->w_topline != old_topline
  		|| curwin->w_skipcol != old_skipcol
--- 2304,2310 ----
  	if (curwin->w_topline == curwin->w_cursor.lnum)
  	{
  	    curwin->w_skipcol = 0;
! 	    redraw_later(UPD_REDRAW_TOP);
  	}
  	if (curwin->w_topline != old_topline
  		|| curwin->w_skipcol != old_skipcol

That is now line 1855. We can't remove it, when w_skipcol is changed
a redraw is needed. But we should not need to redraw everything.

I think we can add a check to make sure smoothscroll is active so we
don't unnecessarily redraw:
diff --git a/src/move.c b/src/move.c
index e255bd68e..c8b7316e6 100644
--- a/src/move.c
+++ b/src/move.c
@@ -2301,7 +2301,7 @@ scroll_cursor_top(int min_scroll, int always)
        check_topfill(curwin, FALSE);
 #endif
        // TODO: if the line doesn't fit may optimize w_skipcol
-       if (curwin->w_topline == curwin->w_cursor.lnum)
+       if (curwin->w_topline == curwin->w_cursor.lnum && curwin->w_skipcol != 0)
        {
            curwin->w_skipcol = 0;
            redraw_later(UPD_NOT_VALID);

Perhaps this UPD_NOT_VALID could be something else too.

I checked that the tests still pass with this change.

Updating the display isn't tested much, it would require making a screendump.

FWIW I think smoothscroll is currently doing a lot of unnecessary
redraws with redraw_later(UPD_NOT_VALID) so it's worth looking at
proper ways to redraw it at a later time (it's on my bucket list to
file after the immediate bugs were fixed), but for now I don't think
we need to do these redraws at all unless we have smoothscroll active,
to avoid causing regressions for people not using this.

We need to keep it functional and logic.  In this code there is no check
for the 'smoothscroll' value, thus the conditions should not depend on
it.  When w_skipcol changes a redraw is needed, it doesn't matter why
w_skipcol changes.
--
hundred-and-one symptoms of being an internet addict:
89. In addition to your e-mail address being on your business
cards you even have your own domain.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Updating the display isn't tested much, it would require making a screendump.

The display update is tested by Test_smoothscroll_wrap_scrolloff_zero, which is what was added alongside the redraw change as part of v9.0.0673. It does use screen dumps. That's why I had to add the test.

We need to keep it functional and logic.  In this code there is no check for the 'smoothscroll' value, thus the conditions should not depend on it.  When w_skipcol changes a redraw is needed, it doesn't matter why w_skipcol changes.

If you look at my diff, I just added a curwin->w_skipcol != 0 check, which is exactly what you mentioned. The previous logic didn't have this check which is why it's doing unnecessary work when smoothscroll is off. I just said "check for smoothscroll" in a casual sense but the logic did only check for whether curwin->w_skipcol needs to be updated.

Updating the display isn't tested much, it would require making a screendump.

The display update is tested by
Test_smoothscroll_wrap_scrolloff_zero, which is what was added
alongside the redraw change as part of v9.0.0673. It does use screen
dumps. That's why I had to add the test.

We need to keep it functional and logic.  In this code there is no
check for the 'smoothscroll' value, thus the conditions should not
depend on it.  When w_skipcol changes a redraw is needed, it doesn't
matter why w_skipcol changes.

If you look at my diff, I just added a curwin->w_skipcol != 0 check,
which is exactly what you mentioned. The previous logic didn't have
this check which is why it's doing unnecessary work when smoothscroll
is off. I just said "check for smoothscroll" in a casual sense but the
logic did only check for whether curwin->w_skipcol needs to be
updated.

You seemed to assume that when w_skipcol is non-zero that 'smoothscroll'
must be set.  That's not always true.  Making assumptions like this is
tricky, it might work now, but when other features are added or changed
later it may be wrong to assume the direct relation.  That is why it's
OK to check the value of w_skipcol, but if you would have checked the
value of the 'smoothscroll' option here it would be wrong.  So you did
the right thing in the code, but the explation didn't match with that.
--
hundred-and-one symptoms of being an internet addict:
90. Instead of calling you to dinner, your spouse sends e-mail.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Here is a diff on 9.0.887.
*** moveOrig.c	Fri Oct 21 10:47:38 2022
--- move.c	Thu Nov 17 10:15:55 2022
***************
*** 2304,2310 ****
  	if (curwin->w_topline == curwin->w_cursor.lnum)
  	{
  	    curwin->w_skipcol = 0;
! 	    redraw_later(UPD_NOT_VALID);
  	}
  	if (curwin->w_topline != old_topline
  		|| curwin->w_skipcol != old_skipcol
--- 2304,2310 ----
  	if (curwin->w_topline == curwin->w_cursor.lnum)
  	{
  	    curwin->w_skipcol = 0;
! 	    redraw_later(UPD_REDRAW_TOP);
  	}
  	if (curwin->w_topline != old_topline
  		|| curwin->w_skipcol != old_skipcol

Well, I suppose we can't really predict if there is a situation where
UPD_REDRAW_TOP is insufficient.  Let me make a patch to use that in all
places where w_skipcol is changed, then you will have to report any
cases where the display is wrong.  With reproduction steps in script
form, so that it will be easy to turn it into a test, please.
--
hundred-and-one symptoms of being an internet addict:
91. It's Saturday afternoon in the middle of May and you
are on computer.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Here is a diff on 9.0.887.
*** moveOrig.c	Fri Oct 21 10:47:38 2022
--- move.c	Thu Nov 17 10:15:55 2022
***************
*** 2304,2310 ****
  	if (curwin->w_topline == curwin->w_cursor.lnum)
  	{
  	    curwin->w_skipcol = 0;
! 	    redraw_later(UPD_NOT_VALID);
  	}
  	if (curwin->w_topline != old_topline
  		|| curwin->w_skipcol != old_skipcol
--- 2304,2310 ----
  	if (curwin->w_topline == curwin->w_cursor.lnum)
  	{
  	    curwin->w_skipcol = 0;
! 	    redraw_later(UPD_REDRAW_TOP);
  	}
  	if (curwin->w_topline != old_topline
  		|| curwin->w_skipcol != old_skipcol

Well, I suppose we can't really predict if there is a situation where
UPD_REDRAW_TOP is insufficient.  Let me make a patch to use that in all
places where w_skipcol is changed, then you will have to report any
cases where the display is wrong.  With reproduction steps in script
form, so that it will be easy to turn it into a test, please.

I found one case where UPD_REDRAW_TOP was not enough.  This is when the
top line height increases by a screen line, the following lines are then
not redrawn.  Thus I used UPD_SOME_VALID now.
Perhaps UPD_REDRAW_TOP can be made to work, if we can somehow detect
that the topline has changed the number of screen lines it occupies.  We
do already have some information stored for that, but figuring out what
is valid is going to require quite a bit of digging.
Anyway, please check if display updating works faster after patch
9.0.0892 and doesn't cause problems.
--
From "know your smileys":
;-0	Can't find shift key
,-9	Kann Umschalttaste nicht finden
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Thank you, I checked and it is now comfortably fast.

You seemed to assume that when w_skipcol is non-zero that 'smoothscroll' must be set. That's not always true. Making assumptions like this is tricky, it might work now, but when other features are added or changed later it may be wrong to assume the direct relation. That is why it's OK to check the value of w_skipcol, but if you would have checked the value of the 'smoothscroll' option here it would be wrong. So you did the right thing in the code, but the explation didn't match with that.

That's true. I wasn't being clear. I think the other place I know where w_skipcol is nonzero is when we have a super long line that spans more than a window height and we use it to show the current cursor.


Fix HAProxy stop commands

The cat binary was not fully specified.

https://ocd.appscale.com:8080/job/Daily Build/3762/
The Hawkeye failure was a cassandra timeout.
The Blobstore failure was a rabbitmq issue.
I think the tools-test and euca-faststart was this issue: https://github.com/AppScale/appscale/pull/2529


Linter rule (+ refactoring) to detect child resources and nest them within parent

Is your feature request related to a problem? Please describe.
Based on the note at the bottom of https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/child-resource-name-type#full-resource-name-outside-parent, child resources should be bound to parents in a type-safe manner (either through nesting within the parent declaration or through explicit parent: keyword).
Describe the solution you'd like
Have a linter rule that detects the pattern of declaring children with a full resource type.

Before 1.0, we plan to actually deprecate this way of declaring child & extension resources. We plan to add a resource() function to make it easier to get a resource reference in a property value without having to declare the existing equivalent. Though, it would be nice if we offer a code-fix for the transition period before we completely remove support for it.

@alex-frankel make sure to fix all the bugs where we have to use the other method instead of parent() first. I certainly know for a bug (4453) that hasn't been fixed for quite some time.

Linking to #2446


Enchancement to pdf rendering

Refractor to use base-pdf.html
Fix html tags rendering in pdf
Refractor pdf rendering logic of PAF
Convert PDFSetting to be a generic setting
Upgrade xhtmltopdf to latest

This is a massive improvement! This would've been a problem for OTF so thanks for getting in front of it @theskumar!

in testing this I did find #4259 which I could take a look at


env var context function

Adds an env_var function to grab system environment variables. Can be used in the dbt profile, or in models.
profile:
  target: dev
  outputs:
    dev:
      type: postgres
      host: localhost
      user: {{ env_var('DBT_USER') }}
      pass: {{ env_var('DBT_PASSWORD') }}
      ....

For https://github.com/fishtown-analytics/dbt/issues/450

:shipit:


Changed regex pattern for repo_url match

Previous regex pattern was not suitable for GitLab Repo URL. Now it is suitable for both GitHub and GitLab
///////////////////⚡///////////////////
🚫 AWESOME A PR!

You can just delete all of this and start your PR text anytime -

Hello there, just a quick pre-warning of some of the Danger rules we run on Danger PRs.
The big one is we request that every code change to Danger include a CHANGELOG entry,
this is so that:

People know what changes are between versions
Orta doesn't get all the credit for other people's work

Danger will look for a modification to the CHANGELOG.md when there are changes including
lib/* - if you're fixing unreleased code, or doing a simple typo change, you can
include #trivial in the title or the body of the PR and this is skipped.
We also request that you fill in the body of your PR, a title should be tweet length, but
ideally you can explain the PRs reasoning in the body. We look that it's longer than 5 chars.
Other than that, a lot of the other Danger rules are trickier to trigger so we can address
them as they come up!
❤ THANKS FOR HELPING OUT :D
///////////////////⚡///////////////////

          1 Error

:no_entry_sign:
Tests have failed, see below for more information.

          1 Warning

:warning:
Tests were not updated

Tests:

File
Name

bitrise_spec.rb
Danger::Bitrise#new sets the repo_slug from a repo https url

  Generated by :no_entry_sign: Danger

This failed tests, and you've not explained why you made the changes - any chance we can get some context?

Sorry about that. But the previous RegEx pattern was not suitable if there are more than 2 subgroups in gitlab.
For example : git@git.com:xxxxx/xxxxx/project.git works fine.
However, if it is more than 2 subgroups then the url becomes
git@git.com:xxxxx/xxxxx/xxxxx/project.git in this case it fails.
I overlooked the test cases, as my approach fails for the "https://" case.
I have tried out another approach which works for all the test cases, which I will submit another pull request for.


Remove envelope to indicate contact information

It is unclear what the envelope next to a person name is supposed to indicate. See e.g. http://demo.gbif.org/dataset/83e20573-f7dd-4852-9159-21566e1e691e/origin

and

Is it to indicate

contact person: than the second person (me) should also get that icon, as I'm also a contact person
primary contact: not an EML term, so I guess derived from "first person listed as resource contact"

In the second screenshot, the envelop icon appears twice, with a double meaning: email + contact person.

Thanks - i like that you notice that. Tt was intended to indicate the first person listed as an administrative contact - that is the primary contact. There might be more, but the first listed as such (which might not be the first originator). This was to avoid scenarios with 10 administrative contacts and to adhere to the IPT principle of respecting provided order. We could consider showing them all, but i somehow like showing a single primary assuming they have been listed in that order for a reason. The others are still available of course and marked as contacts. I see what you mean with the doubly use of the icon. It is a bit odd.

it still appears in the header next to the first person listed as an administrative contact.
in the full name+address it still appears next to the mail address. But it has been removed next to the persons name as it weren't inline with the use of the 'institution icon'
I personally think it makes ok sense to direct people to the first person listed as a contact and not mark all people in the header. The information is still available on hover and spelled out elsewhere on the page

Yes, seems fine to use it as such, although I don't think the email addresses in the full contact info need an envelope icon.

Gone it is. and much has changed. Hopefully to the better. Orcids are now there. Thanks

ahh - just notice that it doesn't anchor as well as it should.


Fix bugs related to the journal recovering from a UFS failure

Fixes #9722
Fixes several edge cases in journal recovery.

If we fail to flush to the journal, do not try to recover, instead
flag the stream as needsRecovery and handle the recovery on next
operation
When recovering, make sure there is a previous journal entry
When recovering, create a new log file starting with the latest
committed journal entry (instead of our current one)
When recovering, fail if the latest journal entry recovered from our
buffer is not equal to our expected next sequence number - 1
When recovering, do not consider incomplete logs when inferring the
last persisted sequence number from the file name (it will be
INTEGER_MIN)

Cherry-pick of existing commit.
pr-link: Alluxio/alluxio#9723
change-id: cid-63623a4e96d91f9619605dd9cad1b7da7679ac9c

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/5109/
Test PASSed.

alluxio-bot, merge this please.


Add values

This adds values section on the website ..

@kaizer1v is working on this now, hence closing


Good start!

@alishabab ,
Thank you for your presentation. No issues.
Good luck with your next challenges.

Thanks!


prevent scrollTo from being converted from false to 0

In the loadUrl function there is an explicit check for false as a means to disable the scrollTo behavior however if the scrollTo option is passed to the constructor as false the gaud statement was converting false to 0.

No time for this for now. Are you interested to get write access ?

If you're comfortable with that I'm up for it.

You should now have full access to the repo. Be careful ;)
What is your npm username if you have any (otherwise I will make the release when needed)?

lgtm, merging so we can move forward

Sorry I didn't get on that faster had another project cannibalize my time for a bit.

Also interestingly write access doesn't seem give you the ability to merge pull requests.

Where did you see that?
(I merged your PR).

After you gave me write access I looked at the pull request and there was no option to merge it in. At least not that I could find. Might have something to do with the fact that I submitted it. Thanks for the merge anyway. I submitted a few bug fixes also as just normal commits. Wanted to let you know but didn't know where to message you at.

I merged your PR before you take a look (when I give you write access).
As a collaborator, you can create branch into this repo directly (no need for a fork) & make a pull request + merge. By doing that, you offer other collab to make a review (even if you merge directly) of what have been merged. Nice way to notify collaborators.
Or you can just ping me (like "poke @MoOx") in commit message (in what is considered as a description (below the first line)).

Just looked at your commit. You are doing a great job. Thanks !


Authenticate using User JWT-Token

It would be great to support User JWT Token-based authentication for a database connection. The benefit is that the python-arango client would not need to know any username/password credentials, and a user does not need the superuser access that the current superuser_token argument supports. This does come with added responsibility for a user authenticating this way since there is no guarantee that the token is still valid.
For example, loading a JWT from environment variables:
from arango import ArangoClient
import os

# Initialize the ArangoDB client.
client = ArangoClient()

# get user JWT
token = os.environ["ARANGODB_USER_JWT"]

# Connect to "test" database as a user using the token.
db = client.db('test', user_token=token)

Hi @geenen124
The request has been added to our backlog and will be prioritized for a future release.


Deployment

#Deployment
##User Story
As a marketing agency,
I want a website with a codebase that follows accessibility standards
So that so that our own site is optimized for search engine.
##Acceptance Criteria
GIVEN a website with codebase which meets accessibility standard,
WHEN I visit the website using the URL,
THEN I can access my website from any browser

[](https://getnetgit.github.io/HoriseonPage-Code-Refactor/#social-media-marketing)


Values of missingval still shown in the overview of the Raster

I am still working with the data from #605 and I am constructing a Raster object from the Netcdf subgroup.
Setting the missingval keyword seems to have no effect and I can still see the missingval in the array when the Raster is shown.
This is a reproducer with small data:
arr = rand(10,10)
r = Raster(arr, (X(1:10,Y(1:10)), missingval=arr[1,1])

I would have expected that the first element of the Raster is shown as missing.
skipmissing works as expected.

It doesnt do sentinel missings by default. That has never been implemented and I rarely want it myself becapuse uts slow. So it needs to be optional.
If you can write out a syntax and specific behaviours in lazy/non lazy modes we can implement it.


Migrate continuous integration from travis to github actions

See https://github.com/hbz/lobid/issues/433.

Done, closing.

Done, closing.


Templates for Chat Models for HuggingFace

https://huggingface.co/docs/transformers/v4.40.2/chat_templating

#1131


The popup view dismisses when apply masksToBound and clipsToBound

When I apply masksToBound or clipsToBound, the popup view dismisses. Please support this

The popup view isn't dismissed, it is not visible, as setting clipsToBounds will clip to the progress bar bounds. The popup view is designed to overlay the view above, so setting the view bounds to include the popup wouldn't make sense. If you need it to behave differently then the source code is available for you to change as required. Alternatively you could place the progress view inside a super view with a frame that you set manually to accommodate the popup view.

Thanks


Use '\n' to join the template cache entries regardless of platform

Also leaves the template cache contents untouched, rather than using normalizelf().
This will ensure that developers using the same repo on different OSes will have identical grunt build output, avoiding constant churn when the built files are committed to the repository.
I've used '\n' for the joins since the rest of grunt-angular-templates uses it, as do other grunt plugins like grunt-contrib-uglify and grunt-usemin.
Fixes #125.
@ericclemmons, could you take a look? :-)

@ericclemmons, let me know if I need to do anything else before this can be merged :-)

Going to merge this, but probably bump versions because people have varying opinions on the "right" linefeed ending =/

Ok, thank you :-)

@ericclemmons any news on this? :-)

Would you be interested in #137?  I need help...

@edmorley What do you think about making this optional? Based on @edmorley's comment I think it might be the best approach. Default behavior would be the current handling of line feeds, but passing in the linefeed option with your preferred linefeed string would override it. Thoughts?

Would you be interested in #137? I need help...

Unfortunately I don't think I have the grunt expertise to help out at the moment. My team has also changed its deployment strategy, so we no longer run into this issue (the grunt build is performed on deploy instead of being committed to the repo).
If someone wants to take over the PR, they are most welcome :-)

Created https://github.com/ericclemmons/grunt-angular-templates/issues/154 as an alternative to this, going to close this one.


Problems showing Chunks with mods like Sodium or Starlight enabled(Anvil Example)

Valence Version
e83c2641dc13328c28e35be97d0ae5eab8c6201d
What You Did
I run and slightly modified version of the anvil_loading example. I changed the spawn not to be at 0 0, but it was not far from 0 0.

Playground
#![allow(clippy::type_complexity)]

use std::path::PathBuf;

use clap::Parser;
use valence::abilities::{FlyingSpeed, FovModifier, PlayerAbilitiesFlags};
use valence::message::SendMessage;
use valence::prelude::*;
use valence_anvil::{AnvilLevel, ChunkLoadEvent, ChunkLoadStatus};

const SPAWN_POS: DVec3 = DVec3::new(88.5, 87.5, -29.5);

#[derive(Parser, Resource)]
#[clap(author, version, about)]
struct Cli {
    /// The path to a Minecraft world save containing a `region` subdirectory.
    path: PathBuf,
}

pub fn main() {
    let cli = Cli::parse();

    if !cli.path.exists() {
        eprintln!(
            "Directory `{}` does not exist. Exiting.",
            cli.path.display()
        );
        return;
    }

    if !cli.path.is_dir() {
        eprintln!("`{}` is not a directory. Exiting.", cli.path.display());
        return;
    }

    App::new()
        .add_plugins(DefaultPlugins)
        .insert_resource(cli)
        .add_systems(Startup, setup)
        .add_systems(
            Update,
            (
                despawn_disconnected_clients,
                (init_clients, handle_chunk_loads).chain(),
                display_loaded_chunk_count,
            ),
        )
        .run();
}

fn setup(
    mut commands: Commands,
    dimensions: Res<DimensionTypeRegistry>,
    biomes: Res<BiomeRegistry>,
    server: Res<Server>,
    cli: Res<Cli>,
) {
    let layer = LayerBundle::new(ident!("overworld"), &dimensions, &biomes, &server);
    let mut level = AnvilLevel::new(&cli.path, &biomes);

    // Force a 16x16 area of chunks around the origin to be loaded at all times.
    // This is similar to "spawn chunks" in vanilla. This isn't necessary for the
    // example to function, but it's done to demonstrate that it's possible.
    for z in -8..8 {
        for x in -8..8 {
            let pos = ChunkPos::new(x, z);

            level.ignored_chunks.insert(pos);
            level.force_chunk_load(pos);
        }
    }

    commands.spawn((layer, level));
}

fn init_clients(
    mut clients: Query<
        (
            &mut EntityLayerId,
            &mut VisibleChunkLayer,
            &mut VisibleEntityLayers,
            &mut Position,
            &mut GameMode,
            &mut PlayerAbilitiesFlags,
            &mut FlyingSpeed,
            &mut FovModifier,
        ),
        Added<Client>,
    >,
    layers: Query<Entity, With<ChunkLayer>>,
) {
    for (
        mut layer_id,
        mut visible_chunk_layer,
        mut visible_entity_layers,
        mut pos,
        mut game_mode,
        mut abilities,
        mut flying_speed,
        mut fov_modifier,
    ) in &mut clients
    {
        let layer = layers.single();

        layer_id.0 = layer;
        visible_chunk_layer.0 = layer;
        visible_entity_layers.0.insert(layer);
        pos.set(SPAWN_POS);
        *game_mode = GameMode::Adventure;
        abilities.set_allow_flying(true);
        flying_speed.0 = 0.1;
        fov_modifier.0 = 0.05;
    }
}

fn handle_chunk_loads(
    mut events: EventReader<ChunkLoadEvent>,
    mut layers: Query<&mut ChunkLayer, With<AnvilLevel>>,
) {
    let mut layer = layers.single_mut();

    for event in events.iter() {
        match &event.status {
            ChunkLoadStatus::Success { .. } => {
                // The chunk was inserted into the world. Nothing for us to do.
            }
            ChunkLoadStatus::Empty => {
                // There's no chunk here so let's insert an empty chunk. If we were doing
                // terrain generation we would prepare that here.
                layer.insert_chunk(event.pos, UnloadedChunk::new());
            }
            ChunkLoadStatus::Failed(e) => {
                // Something went wrong.
                let errmsg = format!(
                    "failed to load chunk at ({}, {}): {e:#}",
                    event.pos.x, event.pos.z
                );

                eprintln!("{errmsg}");
                layer.send_chat_message(errmsg.color(Color::RED));

                layer.insert_chunk(event.pos, UnloadedChunk::new());
            }
        }
    }
}

// Display the number of loaded chunks in the action bar of all clients.
fn display_loaded_chunk_count(mut layers: Query<&mut ChunkLayer>, mut last_count: Local<usize>) {
    let mut layer = layers.single_mut();

    let cnt = layer.chunks().count();

    if *last_count != cnt {
        *last_count = cnt;
        layer.send_action_bar_message("Chunk Count: ".into_text() + cnt.color(Color::LIGHT_PURPLE));
    }
}

What Went Wrong
On clients with sodium or starlight or both installed, the chunks didn't shown up correctly and the client was long stuck at the "Loading terrain..." screen. I also tried this with different maps, so I can say for sure that this isn't a problem of this map.
I disused this problem on the discord server, a other user can reproduce this problem.
This Issue only occur on clients with sodium or starlight installed. On a vanilla client it works fine.
Additional Information
Link to the discord thread
My screenshot where you can see no chunks showing up

Screenshot of the other user in the discord thread

This is also happening with me for a completely vanilla 1.20.1 client when loading an Anvil world.
I will try to do some investigating when I can, but I can re-confirm it occurs whenever the spawn position is set away from 0,0 for me.

I found out that the difference in ordering of the player position and default spawn position packets in relation to the chunks was due to me using a encrypted/authenticated server in one case, and not in the other.
I've got the new logs which have much more detail:
https://gist.github.com/Mac898/700a91d6dec5b78e5571aa6f0dfd2a74
However, looking over the diff carefully I see one main difference: "Set Chunk Cache Center"
https://wiki.vg/Protocol#Set_Center_Chunk
It's sent immediately after the default spawn position by the vanilla server.
My guess: Since we haven't initialized the buffer here the client isn't expecting the correct chunks and it ends up failing in some way. So i'm going to try and send this packet as the next debugging step.
We also send "Set Chunk Cache Radius", which according to the wiki is only sent by the integrated server:
https://wiki.vg/Protocol#Set_Render_Distance
That's another thing to check.

Any update on this issue? I also have this problem


Update pins (#2167)

Pick 5b14c5ef78a25ec2527bd7d7163ffefaf84fb39e

/merge-when-ready

OK, I will merge the pull request when it's ready, leave the commits as is when I merge it, and leave the branch after I've merged it.


[DS-4575]  v.7 - Exposed more parameters for DBCP2

Exposed more parameters for DBCP2 in the DSpace config.
Notably, maxConnLifeTime and removeAbandoned
See:

#3070
#3080
#3164

See also:
http://dspace.2283337.n4.nabble.com/Notes-on-PostgreSQL-connection-pooling-with-a-Tomcat-JNDI-resource-td4687149.html

@tdonohue, I just removed changes to local.cfg, so it's left untouched


[RTD] Enable auto-build on RTD

Like xplot, it seems that xeus-cling does not trigger automatic build on RTD upon commit.

This is now fixed.


added ammonite console REPL

I added ammonite-REPL as it is much-much better than scala-s default one and it allows to do some advanced staff, like loading dependencies from scala-console and running shell commands in an easy way.

I also deleted redundant imports of typesafe-releases repo as 1) it moved to bintray 2) latest sbt imports type-safe releases by default

hey @antonkulaga thanks for the PR, I just had a lil time to check it out. Indeed, the REPL is better and I'm not against having it.
However, this adds the below dependencies to the runtime, which I'd like to avoid because we can have a lot of clashes out there (like ivy and jline for instance).
And in a sense, they are just necessary for the sbt console, since we don't use it elsewhere.
So, could you have a look how this deps on ammonite can be scoped to only the console classpath please?
Thanks a lot man
[info]   +-com.lihaoyi:ammonite-repl_2.10.4:0.4.5 [S]
[info]   | +-com.github.scopt:scopt_2.10:3.3.0 [S]
[info]   | +-com.lihaoyi:ammonite-ops_2.10:0.4.5 [S]
[info]   | | +-com.lihaoyi:pprint_2.10:0.3.4 (evicted by: 0.3.5)
[info]   | | +-com.lihaoyi:pprint_2.10:0.3.5 [S]
[info]   | | | +-com.lihaoyi:derive_2.10:0.3.5 [S]
[info]   | | |
[info]   | | +-org.scalamacros:quasiquotes_2.10:2.0.1 [S]
[info]   | |   +-org.scala-lang:scala-reflect:2.10.4 [S]
[info]   | |
[info]   | +-com.lihaoyi:ammonite-terminal_2.10:0.4.5 [S]
[info]   | | +-org.scalamacros:quasiquotes_2.10:2.0.1 [S]
[info]   | |   +-org.scala-lang:scala-reflect:2.10.4 [S]
[info]   | |
[info]   | +-com.lihaoyi:pprint_2.10:0.3.5 [S]
[info]   | | +-com.lihaoyi:derive_2.10:0.3.5 [S]
[info]   | |
[info]   | +-com.lihaoyi:scalaparse_2.10:0.2.1 [S]
[info]   | | +-com.lihaoyi:fastparse_2.10:0.2.1 [S]
[info]   | | | +-com.lihaoyi:fastparse-utils_2.10:0.2.1 [S]
[info]   | | | | +-org.scalamacros:quasiquotes_2.10:2.0.0 [S] (evicted by: 2.0.1)
[info]   | | | | | +-org.scala-lang:scala-reflect:2.10.4 [S]
[info]   | | | | |
[info]   | | | | +-org.scalamacros:quasiquotes_2.10:2.0.1 [S]
[info]   | | | |   +-org.scala-lang:scala-reflect:2.10.4 [S]
[info]   | | | |
[info]   | | | +-org.scalamacros:quasiquotes_2.10:2.0.0 [S] (evicted by: 2.0.1)
[info]   | | | | +-org.scala-lang:scala-reflect:2.10.4 [S]
[info]   | | | |
[info]   | | | +-org.scalamacros:quasiquotes_2.10:2.0.1 [S]
[info]   | | |   +-org.scala-lang:scala-reflect:2.10.4 [S]
[info]   | | |
[info]   | | +-org.scalamacros:quasiquotes_2.10:2.0.0 [S] (evicted by: 2.0.1)
[info]   | | | +-org.scala-lang:scala-reflect:2.10.4 [S]
[info]   | | |
[info]   | | +-org.scalamacros:quasiquotes_2.10:2.0.1 [S]
[info]   | |   +-org.scala-lang:scala-reflect:2.10.4 [S]
[info]   | |
[info]   | +-com.lihaoyi:upickle_2.10:0.3.5 [S]
[info]   | | +-com.lihaoyi:derive_2.10:0.3.5 [S]
[info]   | | +-org.spire-math:jawn-parser_2.10:0.7.0 [S]
[info]   | |
[info]   | +-jline:jline:2.12
[info]   | +-org.apache.ivy:ivy:2.4.0
[info]   | +-org.scala-lang:scala-compiler:2.10.4 [S]
[info]   | | +-org.scala-lang:scala-reflect:2.10.4 [S]
[info]   | |
[info]   | +-org.scala-lang:scala-reflect:2.10.4 [S]
[info]   | +-org.scalamacros:quasiquotes_2.10:2.0.1 [S]
[info]   |   +-org.scala-lang:scala-reflect:2.10.4 [S]
[info]   |

The simpliest thing to do is to add ammonite to another scope (test scope for instance, so it will work only for Console in test).

@antonkulaga I think you're right!

I think @alexarchambault has the solution, he has just updated sbt-ammonite so it will be possible to use ammonite as sbt-plugin

indeed, again not against ammonite integration, but I never use the REPL
since I have the notebooks :),in a sense it's a counter sense since the
notebook is there to get rid on REPL.
So it must be lightweight and without side effect.
maybe the plug-in will put the deps still, so please check the different
classpath before :).
you know what I'd like also to have a bit of an highlight which use cases
would require the repl in the notebook project. thanks
Le mer. 19 août 2015 19:17, Anton Kulaga<EMAIL_ADDRESS>a
écrit :

I think @alexarchambault https://github.com/alexarchambault has the
solution, he has just updated sbt-ammonite
https://github.com/alexarchambault/sbt-ammonite so it will be possible
to use ammonite as sbt-plugin
—
Reply to this email directly or view it on GitHub
https://github.com/andypetrella/spark-notebook/pull/289#issuecomment-132853271
.

--
andy

let's close this.


titan: Introduce titan zstd dict compression

What is changed and how it works?

Issue Number: Close https://github.com/tikv/tikv/issues/5743
What's Changed:

Introduce titan zstd dict compression

Related changes

PR to update pingcap/docs/pingcap/docs-cn:

Check List
Tests

Unit test

Release note
None

/merge

/merge


Publish on Dockerhub

For easier deployment.
Should happen automatically during the publication phase in Jenkins

Focusing on the CLI and REST tool of the descriptorgen ipmlemented in tng-sdk-project


fs: Entries pointing back to root bug

Entries pointing to root directory have a value that is inconsistent with offsets.. time to read the manual more closely
This can be seen by going into a folder in terminal and then trying to go back to root through the ".." entry

Although I'm not entirely sure how it's all supposed to be done, since mkfs.fat deviates from the specification given by Microsoft, I have made my version handle the case where root sector is not cluster 0.


don't override paginationTextValue if provided

Describe the bug
My custom paginationTextValue gets overridden if totalRecords is 0
To Reproduce
Add a custom paginationTextValue
remove all items
with no items paginationTextValue gets replaced with ...

Thanks!
This is now fixed in v.1.7.10.

One more thing: you can now customize the loadingText if you're not happy with the default ....


[BUG] Issues with multiplayer, Null Reference

Beatsaber Optimizer Version and Download Source
v0.1.0 and I'm pretty sure at some point it was posted in #PC-Mods on the BSMG discord, but I can't find it there so either I'm losing it or that is where I found it but it was removed.
Your Platform
PC Steam V1.16.1 & 1.16.2 (it was happening on both.)
Describe the bug
Causes multiplayer to hang on song start/song load
To Reproduce

Go to 'Multiplayer/Online'.
Host or join a lobby.
Select a song and click play.

Expected behavior
Load into multiplayer session.
Log
[DEBUG @ 12:50:02 | SiraUtil] Installing: OptimizationInstaller (BeatsaberOptimizer)
[CRITICAL @ 12:50:02 | UnityEngine] ZenjectException: Unable to resolve 'PlayerTransforms'. Object graph:
[CRITICAL @ 12:50:02 | UnityEngine] Zenject.DiContainer.Resolve (Zenject.InjectContext context) (at <d0da33e76e734eb2a6363882a54b9841>:0)
[CRITICAL @ 12:50:02 | UnityEngine] Zenject.DiContainer.ResolveId (System.Type contractType, System.Object identifier) (at <d0da33e76e734eb2a6363882a54b9841>:0)
[CRITICAL @ 12:50:02 | UnityEngine] Zenject.DiContainer.Resolve (System.Type contractType) (at <d0da33e76e734eb2a6363882a54b9841>:0)
[CRITICAL @ 12:50:02 | UnityEngine] Zenject.DiContainer.Resolve[TContract] () (at <d0da33e76e734eb2a6363882a54b9841>:0)
[CRITICAL @ 12:50:02 | UnityEngine] BeatsaberOptimizer.Installers.OptimizationInstaller.InstallBindings () (at <deac3f5df545498aa96c2154e21b664b>:0)
[CRITICAL @ 12:50:02 | UnityEngine] Zenject.Context.InstallInstallers (System.Collections.Generic.List`1[T] normalInstallers, System.Collections.Generic.List`1[T] normalInstallerTypes, System.Collections.Generic.List`1[T] scriptableObjectInstallers, System.Collections.Generic.List`1[T] installers, System.Collections.Generic.List`1[T] installerPrefabs) (at <d0da33e76e734eb2a6363882a54b9841>:0)
[CRITICAL @ 12:50:02 | UnityEngine] (wrapper dynamic-method) Zenject.Context.Zenject.Context.InstallInstallers_Patch2(Zenject.Context)
[CRITICAL @ 12:50:02 | UnityEngine] (wrapper dynamic-method) Zenject.SceneContext.Zenject.SceneContext.InstallBindings_Patch1(Zenject.SceneContext,System.Collections.Generic.List`1<UnityEngine.MonoBehaviour>)
[CRITICAL @ 12:50:02 | UnityEngine] Zenject.SceneContext.Install () (at <d0da33e76e734eb2a6363882a54b9841>:0)
[CRITICAL @ 12:50:02 | UnityEngine] Zenject.SceneContext.RunInternal () (at <d0da33e76e734eb2a6363882a54b9841>:0)
[CRITICAL @ 12:50:02 | UnityEngine] Zenject.RunnableContext.Run () (at <d0da33e76e734eb2a6363882a54b9841>:0)
[CRITICAL @ 12:50:02 | UnityEngine] Zenject.RunnableContext.Initialize () (at <d0da33e76e734eb2a6363882a54b9841>:0)
[CRITICAL @ 12:50:02 | UnityEngine] Zenject.SceneContext.Awake () (at <d0da33e76e734eb2a6363882a54b9841>:0)
[CRITICAL @ 12:50:02 | UnityEngine] UnityEngine.GameObject:SetActive(Boolean)
[CRITICAL @ 12:50:02 | UnityEngine] UnityScenesHelper:SetActiveRootObjectsInScene(Scene, Boolean)
[CRITICAL @ 12:50:02 | UnityEngine] GameScenesManager:SetActiveRootObjectsInScenes(List`1, Boolean)
[CRITICAL @ 12:50:02 | UnityEngine] <ScenesTransitionCoroutine>d__36:MoveNext()
[CRITICAL @ 12:50:02 | UnityEngine] UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
[CRITICAL @ 12:50:02 | UnityEngine] NullReferenceException: Object reference not set to an instance of an object
[CRITICAL @ 12:50:02 | UnityEngine] VRRenderingParamsSetup.OnEnable () (at <f466e163166b4073b6dd391947ee7cac>:0)
[CRITICAL @ 12:50:02 | UnityEngine] UnityEngine.GameObject:SetActive(Boolean)
[CRITICAL @ 12:50:02 | UnityEngine] UnityScenesHelper:SetActiveRootObjectsInScene(Scene, Boolean)
[CRITICAL @ 12:50:02 | UnityEngine] GameScenesManager:SetActiveRootObjectsInScenes(List`1, Boolean)
[CRITICAL @ 12:50:02 | UnityEngine] <ScenesTransitionCoroutine>d__36:MoveNext()
[CRITICAL @ 12:50:02 | UnityEngine] UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
[CRITICAL @ 12:50:02 | UnityEngine] NullReferenceException: Object reference not set to an instance of an object
[CRITICAL @ 12:50:02 | UnityEngine] FadeInOnSceneTransitionFinished.OnEnable () (at <f466e163166b4073b6dd391947ee7cac>:0)
[CRITICAL @ 12:50:02 | UnityEngine] UnityEngine.GameObject:SetActive(Boolean)
[CRITICAL @ 12:50:02 | UnityEngine] UnityScenesHelper:SetActiveRootObjectsInScene(Scene, Boolean)
[CRITICAL @ 12:50:02 | UnityEngine] GameScenesManager:SetActiveRootObjectsInScenes(List`1, Boolean)
[CRITICAL @ 12:50:02 | UnityEngine] <ScenesTransitionCoroutine>d__36:MoveNext()
[CRITICAL @ 12:50:02 | UnityEngine] UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr)
[INFO @ 12:50:02 | Custom Avatars] [PlayerAvatarManager] Player height set to 1.684758 m
[INFO @ 12:50:02 | Custom Avatars] [SpawnedAvatar(Lumine)] Avatar resized with scale: 1.580503
[CRITICAL @ 12:50:02 | UnityEngine] NullReferenceException: Object reference not set to an instance of an object
[CRITICAL @ 12:50:02 | UnityEngine] MultiplayerConditionalActiveByLayout.Start () (at <ed5f1dff68954975944aebd4c110b7aa>:0)

Additional context
I went through multiple logs carefully to determine at what point the game was throwing a NullReferenceException to try and determine which mod/mods were causing it, disabled/removed several till i noticed the following part of the log above. after which once it gets to NullReferenceException it starts to just loop like that listing different parts of the multiplayer layout until the game is closed.

Addendum:
Forgot to attach beefy boi log that has the loop. lol
2<IP_ADDRESS>.47.38.log

fixed in bb46fb7


WFLY-9001 Upgrade Narayana to 5.5.26.Final

https://issues.jboss.org/browse/WFLY-9001

retest this please

retest this please

retest this please

Retest this please


JSDoc: Resolve return type of construct signature

Pre-3.7, this was handled by the weird try-again catchall case. Now we need to explicitly handle the case of value that has a constructable type:
declare var Image: { new (): HTMLImageElement }

This is not a commonly written construction, but the DOM uses it for Image, so that means it's widely consumed. In Typescript, the reference must be typeof Image, but in Javascript, JSDoc references should allow Image as well.
Fixes #34803
Two notes:

This needs to be in 3.7 too.
The existing test was just testing that the type resolved at all. But it assumed the Typescript semantics for the reference, which is not correct. You'll see the types change accordingly, plus I changed the test to avoid a compile error.

I checked our old baselines and the Typescript semantics were the previous semantics. This change would be nice, but it's probably easier, and certainly safer, to add a type alias lib.dom.d.ts: type Image = HTMLImageElement.


US-11 Editing Vehicle Properties

AP-14 This acceptance test should validate the following:

Editing properties should happen in the vehicle details page/modal
Prompt user to save changes if changes were made

Passed


Update ToolUI.mdx

The examples are missing the export statement, which may cause confusion, especially for beginners.

Thank you!


registry check now works on old + new registry, and checks all availa…

…ble registries

:+1:

:+1:


vim-prettier not working when editing files that have white spaces on its path

I'm getting Prettier: failed to parse buffer. error when I run :Prettier or :PrettierAsync.
Running the executable itself (i.e., npx prettier or npm run prettier) doesn't causes any issue.
Version info:
vim-prettier: latest (updated just today)
Prettier version: 1.10.2 (local node_modules)
OS: macOS 10.13.3
Vim:
8.0 (2016 Sep 12, compiled Jan  7 2018 10:47:02)
macOS version
Included patches: 1-1420

I'm still getting the same error, if my files are in a path that has spaces in it. Everything works great elsewhere.
:PrettierVersion : 0.2.7
:PrettierCliVersion: 1.13.7
:PrettierCliPath: prettier
I'm on macOS 10.13.6

I could not reproduce this on the same version as you:
This is the path to my file: ~/Sites/test test/src/test test/test test.js
Do you mind posting your path as well?

It's ~/Work/Festival Scope/fspro/src/FSPro/FrontBundle/Resources/src/scss/header.scss

I tried with other paths as well and they all fail if they contain a white space.

This is really strange, I just can't reproduce this at all. Just a sanity check: you file doesn't contain errors right? If you use the following file as your header.scss, does it still occur?
body {
  text-align: center;
}

I just checked with the above snippet and it still gives Prettier: failed to parse buffer.
Maybe Node version at play? I have v10.6.0

@bfulop, is this issue still happening to you ? If so I will reopen this issue

Yes, Prettier is still failing when there's a space in the file path. (I just run PlugUpdate, but the plugin was already up to date).

Will look into this again

This issue has been fixed on release/1.x


Bump min version for training to 0.3.2

This release includes a fix for the broken --lora-target-modules CLI option.
Closes: #2021
Checklist:

[X] Commit Message Formatting: Commit titles and messages follow guidelines in the
conventional commits.
[ ] Changelog updated with breaking and/or notable changes for the next minor release.
[ ] Documentation has been updated, if necessary.
[ ] Unit tests have been added, if necessary.
[ ] Integration tests have been added, if necessary.

Dup of https://github.com/instructlab/instructlab/pull/2024


Add StateObject backport

[x] Have you read the Contributing Guidelines?

Describe your changes
This adds a @StateObject backport.
Screenshots
The implementation was manually checked with some test code.

init for the ObservableObject is called only once, unless the view identity changes
Updates in the parent view don't reset the StateObject backport state
Updates to @Published properties propagate to the view
Binding created from this backport behaves as expected

https://user-images.githubusercontent.com/38748295/176349845-8b1fa23d-50bd-4c8f-bc71-2a375ff55fdd.mp4
(Gist: https://gist.github.com/auramagi/4a810e2c64b1be04a40e0c2d775a3529)

Hey thanks for this it looks great at a glance. Just to let you know I may not be able to properly review and test this today as I'm on another project.
Couple small things did stand out to me though.

Would be great if you could bring in the official header docs so it matches expectations and usually Apple's included sample code etc which helps a lot.

Also could you add @availability(iOS, deprecated: 14) as well as the other platforms.

Interesting, can this backport the same behavior as iOS 14 :)
Though I'm not a SwiftUI advaned user, I have iPhone running iOS 13 and simulate from the old @ObservedObject for actually @StateObject is a really pain.

@dreampiggy that's very similar actually and yes the idea is that this would support iOS 13+

@auramagi v1.0.9 is now available 👍 Thanks again.


holdApplicationUntilProxyStarts breaks rewriteAppPropers

Bug description
Recently upgraded to v1.7.0 (upgraded over multiple upgrades from ~1.4.2). No major custom configuration besides values.global.proxy.holdApplicationUntilProxyStarts=true, but when I try to enable mutual TLS on a namespace with a PeerAuthentication, the healthchecks start to fail (even with the samples/health-check/liveness-http.yaml example). rewriteAppHTTPProbers is enabled cluster-wide and changing it in the pod annotations also does not yield a change.
I get these logs in the istio-proxy container before the pod is terminated an restarted leading to a CrashLoopbackOff.
2020-08-27T21:40:03.205178Z	error	Request to probe app failed: Get "http://localhost:8001/foo": dial tcp <IP_ADDRESS>:8001: connect: connection refused, original URL path = /app-health/liveness-http/livez
app URL path = /foo

[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
Istio mutal TLS working with liveness and readiness probes.
Steps to reproduce the bug
Upgrade to version 1.7.0 and try out to enable mTLS in a namespace using PeerAuthentication.
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
1.7.0
How was Istio installed?
istioctl install / upgrade
I'm really not sure if this is because of the upgrading of one version to the next, but I would really be thankful for some help. I am happy to provide additional data on request.
Update 08/28/20 10:55 UTC:
Forgot to mention values.global.proxy.holdApplicationUntilProxyStarts=true was set during installation. Added it in the description

Does your application listen on <POD_IP> instead of <IP_ADDRESS> or localhost?
Can you do curl localhost:8001/foo from the app container and/or the sidecar container?

I can curl from the sidecar container (the liveness-http sample does not seem to provide curl):
keti -n test liveness-http-64c6856745-lxjvg -c istio-proxy -- curl http://localhost:8001/foo
-> Listening on 8001: foo %

same problem in here when enabling values.global.proxy.holdApplicationUntilProxyStarts=true

@dntosas You're absolutely right, I have enabled that as well but forgot to mention it. Will edit original issue to reflect that.

i think we got something
when enabling proxy.holdApplicationUntilProxyStarts=true looking at istio-proxy container template:
    Liveness:   http-get http://:15020/app-health/papyrus/livez delay=0s timeout=10s period=10s #success=1 #failure=6
    Readiness:  http-get http://:15020/app-health/papyrus/readyz delay=0s timeout=10s period=10s #success=1 #failure=6

when disabling proxy.holdApplicationUntilProxyStarts=false looking at istio-proxy container template:
    Readiness:  http-get http://:15021/healthz/ready delay=1s timeout=1s period=2s #success=1 #failure=30

the difference is that no Liveness probe is present when this feature is disabled
cc @howardjohn @luksa

Maybe we got something
When DISABLED global.proxy.holdApplicationUntilProxyStarts looking at container template using kubectl describe pod:
istio-proxy:
  Readiness:  http-get http://:15021/healthz/ready delay=1s timeout=1s period=2s #success=1 #failure=30

When ENABLED global.proxy.holdApplicationUntilProxyStarts looking at container template using kubectl describe pod:
istio-proxy:
    Liveness:   http-get http://:15020/app-health/MYAPP/livez delay=0s timeout=10s period=10s #success=1 #failure=6
    Readiness:  http-get http://:15020/app-health/MYAPP/readyz delay=0s timeout=10s period=10s #success=1 #failure=6

The are differences seem to be present on how Liveness/Readiness is defined when feature is enabled ^^
cc @howardjohn @luksa

I can reproduce this
@luksa I think its applying the rewrite app probe to container[0] or something - which is now the sidecar

I can reproduce this
@luksa I think its applying the rewrite app probe to container[0] or something - which is now the sidecar

Ref --> https://github.com/istio/istio/blob/1cc05bcf798644262547032d6714fab2603121e3/pkg/kube/inject/app_probe.go#L142-L144

@dntosas Does this work when  holdApplicationUntilProxyStarts is set to false?

I think I figured out the issue for this.
Sending a fix shortly

Just wanted to send an update. It looks like the fix is far more complicated than I thought. Fixing this would require more thought since we face the risk of setting of regressions.

This can be closed

@tariq1890 is this closed because that PR resolves it? Should we avoid implementing this until the next 1.7.1?

@danquack Yes. I had tested the fix for it in release-1.7 alpha and it works as expected. You can try this feature out in 1.7.1

FYI, tested the fix delivered with 1.7.1 and works as expected :tada:


[WIP issue] Improve developer onboarding experience

Is your feature request related to a problem? Please describe.
Penumbra is a niche-within-a-niche of the crypto world. There's a ton of domain-specific knowledge, lingo, and practices that new developers need to learn to be able to contribute effectively to Penumbra.
At the moment, though, new developers at Penumbra start in the deep end of all this, with limited guidance, due to the lack of a structured onboarding process. As a result, we spend many hours spinning our wheels on trying to navigate our way through the Penumbra codebases — especially when other developers are unavailable for pairing. This ticket is a placeholder for discussion about 1) pain points in the onboarding process and 2) suggestions for improvements to it.
Describe the solution you'd like
Please add comments below with two points: 1) pain points in your onboarding process, or in onboarding processes you've witnessed; and/or 2) suggestions for how to improve onboarding. This ticket will be a sort of wiki, in which responses will be consolidated into this ticket description.
Describe alternatives you've considered
n/a (for now, at least)

My pain points during onboarding

Slow sync times with testnet, with its 600k+ blocks to sync.
Didn't know how to submit invoices or where to set up payment information.
No idea how to set up testnet locally
Didn't know about various places where we have documentation (such as procotol.penumbra.zone and guide.penumbra.zone)

Suggestions
Tasks to complete
🍐 = pairing
All devs

🍐Install pcli and send a transaction with it.
🍐Get a local testnet instance running.

Docs

🍐Point pcli at your local testnet, give yourself allocations, and send a transaction.

Web

Read README plus entire docs directory.
Get the web repo up and running, including the unpacked extension.
Import the test account wallet and send a transaction with it.

Internal tasks

Business admin: Set up new employee in Gusto.
Tech lead: Allocate a dev to pair with the new dev on each onboarding task that requires pairing. (Can be the same dev for multiple tasks.)
Tech lead: Allocate issues tagged as “good first issue” to the new dev.
Tech lead: Allocate a dev to pair with the new dev on the “good first issue”s.


[B10 - 1.12.2] Crafting result with empty arcane workbench

The user phantom_kasper has opened an issue in my backpacks mod.
When the arcane workbench is empty a medium tier backpack is shown in the crafting result slot.
After a little debugging I figured out that the problem is a wrong size of InventoryArcaneWorkbench.
According to the debugger it has an inventory width of 5 when it actually only has 3 slots per row.
This messes up the recipe matching logic of my mod.
I will also add some code to address issues with wrongly sized crafting inventories.

The workbench actually has more slots than just the crafting slots in the middle, each of those colored circles around it is a slot where vis crystals need to go. That is most likely why the width is configured the way it is.

Still the logic has to be fixed. As it is a crafting table it will iterate over all recipes and try to find the correct one. Even if the slots around are for additional crafting materials like crystals the actual crafting grid is only 3x3 and the code has to correspond to that.
Currently as an example if you take some oak wood planks ant put on in the top left corner and one in the right slot of the middle row you are able to craft sticks. The result of the method craftingGridInventory.getStackInRowAndColumn(row, column) will not return the items like they are placed in the visual crafting grid.

Possibly related to #485

Indeed this is related.

Yup, this should be fixed in the next release.


Error: Slot was not found. Have you defined it?

I'm passing QucikStart guide.
Currently I'm trying to branch stories using slots.

At stories->Slots tab I added a slot:
name=bookclass
initial value=not_set
Categories: eco/business/not_set
and saved it

At stories->stories tab I defined a story (in additino to the rest at "CancelBooking" story group):

cancel_booking

slot{"bookclass":"eco"}
utter_booking_not_cancellable

But botfront shows me an error "Slot was not found. Have you defined it?" at "- slot{"bookclass":"eco"}" string.
But "Train everything" doesn't throw errors.
Maybe I'm doing something wrong?

This is indeed a bug, it's being fixed now, and will be resolved in the next release. You can expect the release by the end of the week.

Ok, thanks
Should I close the issue now?

@MatthieuJnon fixed?

This is fixed, merged and released, closing the issue.


mwc-wallet API documentation should be updated, default values should be properly set

Users asking:
Same for the all API calls.
Hi, I am trying to send coins via wallet owner API, but get an error. Anyone knows what's an issue?
Request:
{
"jsonrpc":"2.0",
"method":"init_send_tx",
"params":{
"args":{
"src_acct_name":null,
"amount":1000000000,
"minimum_confirmations":10,
"max_outputs":500,
"num_change_outputs":1,
"selection_strategy_is_use_all":true,
"message":"Take money!",
"target_slate_version":null,
"estimate_only":null,
"send_args":{
"method":"http",
"dest":"http://<IP_ADDRESS>:3415/",
"finalize":true,
"post_tx":true,
"fluff":false
}
}
},
"id":1
}
Response:
{
"error": {
"code": -32602,
"message": "InvalidArgStructure "args" at position 0."
},
"id": 1,
"jsonrpc": "2.0"
}

it is because they are missing these two parameters in the args:
"payment_proof_recipient_address"
"ttl_blocks"

Tried that and still getting an error:
$ curl -u mwc:11ne3EAUtOXVKwhxm84U --request POST --data-raw
'{"jsonrpc":"2.0","method":"init_send_tx","params":{"args":{"src_acct_name":null,"amount":1000000000,"minimum_confirmations":10,"max_outputs":500,"num_change_outputs":1,"selection_strategy_is_use_all":true,"message":"Take
money!","target_slate_version":null,"estimate_only":null,"send_args":{"method":"http","dest":"
http://<IP_ADDRESS>:3415/","finalize":true,"post_tx":true,"fluff":false,"payment_proof_recipient_address":null,"ttl_blocks":1000}}},"id":1}'
http://<IP_ADDRESS>:3429/v2/owner
{
"error": {
"code": -32602,

"message": "InvalidArgStructure \"args\" at position 0."

},
"id": 1,
"jsonrpc": "2.0"
}$
On Sat, Mar 14, 2020 at 11:29 AM yyangli<EMAIL_ADDRESS>wrote:

it is because they are missing these two parameters in the args:
"payment_proof_recipient_address"
"ttl_blocks"
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mwcproject/mwc-qt-wallet/issues/207#issuecomment-599116707,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXFVN2E2ZNCYI6G2E3PJTDRHPEHJANCNFSM4LJMTIXA
.

Actually this worked:
curl -u mwc:11ne3EAUtOXVKwhxm84U --request POST --data-raw
'{"jsonrpc":"2.0","method":"init_send_tx","params":{"args":{"src_acct_name":null,"amount":1000000000,"minimum_confirmations":10,"max_outputs":500,"num_change_outputs":1,"selection_strategy_is_use_all":true,"message":"Take
money!","target_slate_version":null,"estimate_only":null,"send_args":{"method":"http","dest":"
http://<IP_ADDRESS>:3415/","finalize":true,"post_tx":true,"fluff":false},"payment_proof_recipient_address":null,"ttl_blocks":1000}},"id":1}'
http://<IP_ADDRESS>:3429/v2/owner
Those params need to be outside of "send_args".
On Sat, Mar 14, 2020 at 11:37 AM Christopher Gilliard <
<EMAIL_ADDRESS>wrote:

Tried that and still getting an error:
$ curl -u mwc:11ne3EAUtOXVKwhxm84U --request POST --data-raw
'{"jsonrpc":"2.0","method":"init_send_tx","params":{"args":{"src_acct_name":null,"amount":1000000000,"minimum_confirmations":10,"max_outputs":500,"num_change_outputs":1,"selection_strategy_is_use_all":true,"message":"Take
money!","target_slate_version":null,"estimate_only":null,"send_args":{"method":"http","dest":"
http://<IP_ADDRESS>:3415/","finalize":true,"post_tx":true,"fluff":false,"payment_proof_recipient_address":null,"ttl_blocks":1000}}},"id":1}'
http://<IP_ADDRESS>:3429/v2/owner
{
"error": {
"code": -32602,

"message": "InvalidArgStructure \"args\" at position 0."

},
"id": 1,
"jsonrpc": "2.0"
}$
On Sat, Mar 14, 2020 at 11:29 AM yyangli<EMAIL_ADDRESS>wrote:

it is because they are missing these two parameters in the args:
"payment_proof_recipient_address"
"ttl_blocks"
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mwcproject/mwc-qt-wallet/issues/207#issuecomment-599116707,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXFVN2E2ZNCYI6G2E3PJTDRHPEHJANCNFSM4LJMTIXA
.

yes they are outside of send_args, and in args.

Yang, this issues and about making parameters optional if possible. All Option instead of mandatory null can be optional parameters.  Non optional, that can have defaults, can be done the same way.
There are macros that allow specify default values for fields that are not in Jsons.
It will require going through the all APIs and update that.
We don't want users specify extra parameters. Also, what will make migration easier for them.
Grin design is not user-friendly, we should do better.
Are you going to take all of that?  I will be able to take in a few days, when I finish with my current task.

Kontantin,
Yes you can work on this. I will wrap up the mqs feature.

https://github.com/mwcproject/mwc-wallet/commit/37af2824d6ca935b4f6e634232602de932c3a3c4


Acrylic transparency not working

I have set the useAcrylic to true and I changed the acrylicOpacity to 0.2, but it is still a solid color. Has anyone run into this issue before? Have I done something wrong?

what's your gpu?

what's your gpu?

Intel HD Graphics, integrated in the laptop

My old PC has intel G33 and had same problem with acrylic. I had to buy a cheap nvidia G710 to see transparency effects.

@leptr do you get acrylic transparency in any modern windows application? Try Calculator, its entire window is acrylic!

@leptr do you get acrylic transparency in any modern windows application? Try Calculator, its entire window is acrylic!

No I do not! I didn't even know calculator was like that. How's it different from the transparency on Linux? I have dual boot and terminal in linux is transparent, do those two have anything to do with each other?

Windows has some policies about when it will turn on blurred transparency—it prefers to save battery, to not overly tax the GPU, etc. Unfortunately, since we are trying to be good citizens we aren’t trying to override that ... and I don’t think it’s possible, anyway :)

@leptr Linux transparency is often done in OpenGL while the new Fluent Design in Windows 10 uses DirectX. If the gpu is old then you won't get transparencies on your laptop.

So while you are correct and transparency isn't supported by my GPU, I have also found that it can be turned off in the settings. If you right click onto the Desktop and click Personalize and then go to Colors, you will find a button called Transparency effects. It can enable/disable the transparency throughout your system and while it still hasn't enabled the acrylic for me, some parts of the UI have become transparent now. So maybe this will help anyone who has the same problem as me.

I've found that the app installed from the Store does not have working acrylic, but the app compiled from github has working acrylic (my build is a bit older, and not sure what commit the Store version is generated from...). Should I file a new issue?

@leptr try turning on transparency effects on windows at Settings>Personalization>Colors. Should probably show the acrylicOpacity. I was also wondering for the same thing for days and it turns out my windows settings is preventing it 🙂

So while you are correct and transparency isn't supported by my GPU, I have also found that it can be turned off in the settings. If you right click onto the Desktop and click Personalize and then go to Colors, you will find a button called Transparency effects. It can enable/disable the transparency throughout your system and while it still hasn't enabled the acrylic for me, some parts of the UI have become transparent now. So maybe this will help anyone who has the same problem as me.

THANK YOU!

I have the same issue.
Version: 0.5.2762.0
CPU: AMD 3900x
GPU: Nvidia 2080
Powersettings: Ryzen High Performance
Transparency in Windows: on
Opacity in settings: 0.5
Any suggestions?
@DHowett-MSFT

if your using a laptop and it's not plugged in, acrylic is turn off (probably to save battery).

Similar to @iamkentleom I had "Transparency effects" turned off in Settings => Personalization => Colors, turning that back on I had to close/re-open Windows Terminal to see the transparency take effect.

Is it not possible to use this without enabling the option globally in Windows? I don't want acrylic for the rest of my system.

Nope, sorry.

you need to put the acrylic configuration in global setting, not in each terminal setting area.

@toomding not a great suggestion as it doesn't solve the underlying problem the user is having. Using the acrylic option in the global settings will not make it work as opposed to using it in a specific terminal setup.

@toomding it's not working for me :(

@toomding it's not working for me :(

Try turn on personalization's transparent setting, or just copy your setting file to another computer see will it work, try to pinpoint the problems from config or windows.
and if maybe try go to app store update windows teminal preview .
if all of that didn't help. i recommend you to use alacritty . it is the emulator what i am using now.the windows's blur effect isn't that attractive to me . so i changed to alacritty for transparent effect.

@toomding it's not working for me :(

sorry for that.

@toomding it's not working for me :(

sorry for that.

Thank you for your kind help. To give you more context, the problem does not seem to lie in the config of windows terminal but Windows. There used to be translucency effect, but it disappeared after a recent Windows Insider Update. I'm using 10.0.19603.1000 currently.
I use both Alacritty for WSL2 and Windows Terminal for some Windows specific jobs :D

It works again after upgrading to 10.0.19608.1006 (Windows is not really easy to debug except for Windows systems developers)

19613.1005 not working

Same exact thing as @railjty but with 19631.1 still nothing.

i fixed it , go to windows costumize settings , colors , switch trans effect to on , done :)

Still doesn't work for me.

I got same problem,
but done by enabling Transparancy effects

it works!

tried that too @kgfathur and nothing yet :( wonder if it has to do with anything related to RDP/terminal services on Windows since I'm trying this on an Azure VM.

i'm having this problem as well. i just updated to 19041 from 18063 though. not sure what's different when it comes to transparency between the two but none of these solutions work for me. i've had the option in personalization on already, and i have transparency on everything else.

Hey I've got totally crazy idea - for the people who acrylic absolutely just isn't working for, does it work in Notepads? They're using a custom acrylic implementation which might help debug this situation further.

@zadjii-msft No. No transparency whatsoever. I using a Surface Studio 2 and this has been an issue i've noticed for the past month. I'm running the May 2020 update as well  (19041.329). I've already did an entire reinstall of the OS and still nothing. I figured it was something with maybe a "battery" but as you know this is a desktop so I'm really confused. I can get transparency in the taskbar but for anything else (calculator, settings, etc...). And yes, I've tried both of the transparency buttons in the settings (even tried some registry edits and that didn't do anything but reverted back)

Huh. That's really peculiar. I honestly don't have any idea why even the Notepads version of acrylic wouldn't work, they're just using the Composition effects directly, without the battery (and others) policy applied.

Yea, there's a bug somewhere (seems rare) as doing a system restore (full wipe) should have fixed it for me but I don't know what to do at this point. I left feedback through the feedback app (or maybe +1 someone else who had the same issue.

We get reports of this pretty constantly (#5698 was one of the more recent ones with plenty of details), so I've reached out to the Composition team to see if they have any ideas what might be going on here. No promises, but they'll probably be better at debugging this than I will.

Okay, the initial feedback was:

Acrylic doesn't work if there's not the GPU hardware for it. A Surface Studio probably has the hardware, but it won't work if you're running the app in a VM or over remote desktop (for example).
If you wanted to help investigate, could you run dxdiag (instructions here), and send the output to the email in @DHowett's profile? He'll be able to share that with the Composition team so they can investigate exactly why it's not working.

Thanks @zadjii-msft ...I'll do that. (and no vm or rdp usage but thanks for that info)

@chriswoelfel as a sanity check, is there Acrylic in the Start Menu?
I get a very faint amount using the host backdrop on the main body of the Start Menu:

and a little bit of in-app as well with the sidebar:

Nope, which is why I said it's a system level thing. I have transparency in the taskbar (and transparency works within apps like terminal ONLY if I have a background image...). There's no acrylic throughout the entire system (like settings). All of it is opaque.

@zadjii-msft nothing yet, but as I mentioned I am on an Azure VM over RDP so that may explain why. Gonna try dxdiag and provide output just for the sake of it. Thanks for clarifying that.

hmm. well in my instance i'm not using RDP or an azure vm, which is understandable as to why it wouldn't produce acrylic effects over those connections. start menu and notepads produces a transparent effect so i am still seeing it, just having problems with terminal. i emailed the above my dxdiag info, but i'll post some more stuff here shortly.

The windows terminal lost transparency after I updated the system, but the start menu still have. I have changed the json but it does not work. After I turn off and on the transparency effects in the system settings, the terminal had an acrylic effect again.

Setting the useAcrylic property to true, got things working for me.

turns out for me this was a antialiasingMode and cursorShape conflict. these two cant seem to be enabled with each other and it produces the black box effect for me as I posted in the picture above.

I might got a solution from microsoft/microsoft-ui-xaml repo.
https://github.com/microsoft/microsoft-ui-xaml/issues/2737#issuecomment-650471950

I have the latest windows update and just installed the Terminal, transparency setting is "on" and it doesn't work, maybe because of hardware as already said but thing is.. Powershell has transparency, then what!?

After 19041.388 I lost taskbar transparency also. On PC with Gigabyte GTX 2070 super

For those who can't, it is on system level not specific windows terminal issue, when you enable transparency on windows settings it work for me (after restart the windows terminal).
The question now is how could i enable acrylic without enabling windows 10 transparency settings ??

As mentioned here https://github.com/microsoft/terminal/issues/1414#issuecomment-640125263 turn on transparency and then re-start Windows Terminal

When I enable this, the acrylic opacity is not working. When I disable this, it works

Having the same issue on Thinkpad X1 carbon 6th gen with Windows 2004. There is also no acrylic effect on start menu with the transparency effect on.
Processor: i7-8550u
GPU: UHD620
OS Build 19041.423
In my case, the issue is related to Intel GPU's DPP feature, which is an OEM enabled feature that loads a 3D LUT colour mapping profile to GPU. My laptop needs that feature to map screen colour gamut to sRGB otherwise everything will be oversaturated. If I disable that (by deleting HKEY_LOCAL_MACHINE\SOFTWARE\Intel\IGFX key in the registry and restart), the acrylic effect can work again.

I could fix this problem by first disable the transparency mode in windows and then turn it on again. (Windows Settings -> Customize -> Colors -> "Transparancy effects")
Afterwards start new Windows Terminal.

Setting the useAcrylic property to true, got things working for me.

Well that's how you enable it you smartass
but it does not work for some of us

@AkgunFatih if you don’t have anything nice to say, you are welcome to not leave a comment on this repository.


Sporadic 502 responses after introducing traefik in EKS

Do you want to request a feature or report a bug?
Bug
What did you do?
Deployed traefik in EKS, using CRD and listening in two namespaces. The application it points to is a spring boot application with netty. Before Traefik we had the loadbalancer connect directly to the application with no 502s.
What did you expect to see?
No errors in the requests
What did you see instead?
Traefik sporadically returns "502 Bad Gateway" for about 1% of the requests (over 35k)
Output of traefik version: (What version of Traefik are you using?)

Platform: EKS 1.15
Provider: KubernetesCRD
args
--global.checknewversion=true
--global.sendanonymoususage=false
--entryPoints.traefik.address=:9000
--entryPoints.web.address=:8000
--entryPoints.websecure.address=:8443
--api.dashboard=true
--api.insecure=true
--ping=true
--providers.kubernetescrd
--log.level=TRACE
--accesslog=true
--accesslog.format=json
--accesslog.fields.defaultmode=keep
--accesslog.fields.headers.defaultmode=drop
--accesslog.fields.headers.names.X-Trace-Id=keep
--accesslog.fields.headers.names.X-Environment=keep
--providers.kubernetescrd.namespaces=custcomm,custcomm-dev
--serversTransport.maxIdleConnsPerHost=-1
--serversTransport.forwardingTimeouts.idleConnTimeout=1s

If applicable, please paste the log output in DEBUG level (--log.level=DEBUG switch)
time="2020-04-09T14:03:40Z" level=debug msg="'502 Bad Gateway' caused by: readfrom tcp <IP_ADDRESS>:53528-><IP_ADDRESS>:8080: read tcp <IP_ADDRESS>:8000-><IP_ADDRESS>:16428: read: connection reset by peer"

The chain of calls should be: NLB -> traefik -> application with the kube-proxy in between where appropriate.

Hi! I'm Træfiker :robot: the bot in charge of communication regulation.
Thanks for your interest in Traefik!
We dedicate the issue tracker to bug reports and feature requests only. My advanced AI has spotted that your issue might be a configuration problem or relates to something that doesn't look like a bug.
To confirm this, please join our Community Forum and reach out to us on the Traefik section.
In case I'm wrong (well, that would be embarrassing :sweat_smile:), my developers will re-open the issue and fix me!
In the meantime, you can double check Traefik's documentation.

I guess his AI is not that advanced :P, can any human have a look on this please?


Help doesn't print help for subcommands

Help message for subcommands doesn't work as expected: despite being provided, version, about and author do not appear upon calling binary subcommand --help. Also, none of the options and flags which can be used with subcommand appear in the subcommand help message.
As outlined in the subcommands example, subcommands can have their own author, version, about and options. However, the only thing that actually appears in the binary subcommand --help output is the help of the corresponding subcommand, which is probably incorrect behaviour.
Rust Version
rustc 1.26.2 (594fb253c 2018-06-01)
Affected Version of clap
clap 2.31.2
Expected Behavior Summary
My understanding is that calling binary subcommand --help would output a message similar to the one generated for upper-level command. However, this is not the case in my setup.
Actual Behavior Summary
As seen below, the upper-level help message looks valid, but help messages for both subcommands do not have any
[I] kbobyrev@archlinux ~/d/p/minimal> cargo run -- --help
minimal 0.0.1
Kirill Bobyrev<EMAIL_ADDRESS>Minimal project for reproducing clap-rs bug
USAGE:
    minimal [SUBCOMMAND]
FLAGS:
    -h, --help       Prints help information
    -V, --version    Prints version information
SUBCOMMANDS:
    code     Minimal project for reproducing clap-rs bug
    help     Prints this message or the help of the given subcommand(s)
    sleep    Minimal project for reproducing clap-rs bug

[I] kbobyrev@archlinux ~/d/p/minimal> cargo run -- code --help
code for a while

[I] kbobyrev@archlinux ~/d/p/minimal> cargo run -- sleep --help
sleep for a while

Steps to Reproduce the issue

Build the project via cargo build
Run cargo run -- --help to see the upper-level help message
Run cargo run -- code --help to see first subcommand's help message
Run cargo run -- sleep --help to see second subcommand's help message

Link to minimal code for reproducing the issue and debug output
https://gist.github.com/kbobyrev/95ca5697ce602cca4666884090ad8b8b

I would need to see the code you're using, do you have a link to it? I can't build your project otherwise to test it.

Hi @kbknapp!
There's a link on the bottom, the gist contains both code and debug output:
https://gist.github.com/kbobyrev/95ca5697ce602cca4666884090ad8b8b

Ah, sorry! I usually don't look at the debug output unless I'm unsure what's going on :stuck_out_tongue_winking_eye:
This is extremely strange though. I'm digging in now!

Ok, I found the issue and it's something I overlooked.
If you use App::help as you're doing in line 10 and line 30 it replaces the auto-generated help message with whatever you specify.
I know this can be confused with Arg::help which sets the help message. However, for subcommands you must use App::about and App::long_about in order to only set the small "about/help message" and not replace the entire generated message.

Also, in the v3 branch which is being worked on for release, these methods are more intuitively named :wink:

@kbknapp ah, okay, I see! Thank you very much for looking into this and clarifying!
I'm so sorry this was my misuse of the library, I spent some time investigating this issue myself but I couldn't figure out what you pointed out.
Thank you!

No worries, I'm glad I could help :smile: Feel free to ping me any time with a question, or ask in the Gitter chat linked at the top of the readme