[W5][W16-2]CHEN Wen

Add "Find By Address" feature which will returns people whose address satisfy some keywords.

Just some minor coding standard issues.

[Parser.java] For the imports, list all the imports separately, instead of contracting to one * statement (i.e. import seedu.address.commands.*). I believe IntelliJ automatically contracted them for yours, so you can change the settings to not contract the import statements.
[FindCommand.java] For one-liner methods, leave it in Egyptian style, instead of one whole line. (Again this could have been automated by IntelliJ, so have to check.)
[Name.java] I think you accidentally added a redundant empty line.

Other than that, I believe it's fine! Great work!

Thanks for your suggestions! I should check those before PR ><.

Just some minor coding standard issues.
1. [Parser.java] For the imports, list all the imports separately, instead of contracting to one * statement (i.e. import seedu.address.commands.*). I believe IntelliJ automatically contracted them for yours, so you can change the settings to not contract the import statements.

2. [FindCommand.java] For one-liner methods, leave it in Egyptian style, instead of one whole line. (Again this could have been automated by IntelliJ, so have to check.)

3. [Name.java] I think you accidentally added a redundant empty line.

Other than that, I believe it's fine! Great work!

Regarding 1, Is it not recommended to contract the import statements?

@yongxiang1095 have correctly pointed out the main formatting issues, good job! Please do check your IDE's settings and configure them accordingly. @tanlongbin, to clarify, you will need to import classes explicitly, which is specified in the coding standard on the website.
Implementation wise, no major issues found, so good job! You are encouraged to update your I/O and JUnit tests to test if your enhancement is working, and update the User Guide to reflect the enhancement that you have done.


Memory leak with Request Scope and Fault Tolerance

Environment Details

Helidon Version: 2.3.0
Helidon MP
JDK version: 11.0.9
OS: MacOS 11.4

Problem Description
With Helidon MP 2.3.0 I’m seeing a potential memory leak in our application. In a heap dump from one load test I could see 595,000 instances of org.jboss.weld.contexts.SerializableContextualInstanceImpl with reference to an instance of Hk2RequestScope being hung on to by HelidonCdi instanceCache.
It seems to happen when injecting ServerRequest into a resource to use in an endpoint, while also using a Fault Tolerance annotation on the endpoint. Without the FT annotation I’m not seeing any instance of org.jboss.weld.contexts.SerializableContextualInstanceImpl created with reference to Hk2RequestScope.
Steps to reproduce
Create a new helidon-quickstart-mp app.
Inject ServerRequest and update the GET endpoint to use ServerRequest. Also add @Timeout annotation to the GET endpoint:
@Context
ServerRequest mServerRequest;

@Path("/{name}")
@GET
@Produces(MediaType.APPLICATION_JSON)
@Timeout
public JsonObject getMessage(@PathParam("name") String name) {
  return createResponse(name + " tenant " + mServerRequest.headers().first("X-CCTenantId").get());
}

Make n number of requests to the endpoint:
for ((i=1;i<=1000;i++)); do   curl -v --header "X-CCTenantID: tenant1" "localhost:8080/greet/gareth"; done

Take a heap dump, you can see n number of SerializableContextualInstanceImpl with instance=org.glassfish.jersey.inject.hk2.Hk2RequestScope. Eclipse MAT OQL query:
SELECT instance AS instance FROM org.jboss.weld.contexts.SerializableContextualInstanceImpl s WHERE instance.toString().contains("org.glassfish.jersey.inject.hk2.Hk2RequestScope")

Force GC, take another heap dump and still see n number of SerializableContextualInstanceImpl.

Although in the simple reproducer I see one instance per request, in our app, with multiple CDI beans using FT annotations and injecting ServerRequest, we see 9 instances created per request. Just adding in case it adds any extra layer of complication.

@gmpatter Do you have a sense as to whether this issue was present in earlier versions of Helidon? Or was 2.3.0 the first version you tried this with?

@spericas unfortunately I don't. 2.3.0 is the first version I've noticed it in, but our load tests hadn't been run in quite a while so  can't really say when it might have started.

I'm able to confirm the problem. Information collected is as follows, with O(N) or O(1) based on number of requests:

Number of SerializableContextualInstanceImpl instances grows monotonically and O(N).
Number of instances from package io.helidon.microprofile.faulttolerance (MP) is O(1).
Number of instances from package io.helidon.faulttolerace (SE) is O(1).

Currently investigating other places in Helidon and Jersey.

Multiple entries in CDI cache related to Hk2RequestScope:

PR #3214

@gmpatter A couple of issues you reported recently have been fixed in SNAPSHOT. Do you have some time to build from sources and try the fixes? Should be useful before the next release.

@spericas I've tested #3199 and #3194 with latest snapshot locally and both are resolved. Thanks!


Merge develop into master

Update the master branch with changes from the develop branch

Coverage decreased (-0.4%) to 95.755% when pulling c51c96130f8ef91d5e7fe224922547f8ea514c7a on develop into 12ba0be0bf56a383160db40973d92839c04ce882 on master.


Provide Symbolic Icon

VSCode Version: 1.18.1
OS Version: Fedora 27 (64bit / GNOME 3.26.2), effects all Linux distros esp those using GNOME3

Steps to Reproduce:

Open VSCode
Look at topbar

Reproduces without extensions: N/A
GNOME displays the current application icon in the topbar next to the application menu
Where possible a symbolic icon is used in place of the full-colour icon
As VSCode does not provide a symbolic icon it looks rather out of place:

The blue broken infinity just dissapears into a world of gray and black
However by placing an svg such as this in [prefix]/share/icons/hicolor/symbolic/apps as code-symbolic.svg we get a much better effect whilst retaining the full colour icon in the applications menu and app switchers

In GNOME symbolic icons are also used in high contrast mode instead of the colour icons
Whilst this primarily effects GNOME it may be of benifits to other Desktop Environments and GNOME is used on Ubuntu, Fedora and many other distros by default

We are currently considering our icon as final. Please see https://code.visualstudio.com/blogs/2017/10/24/theicon and thanks for understanding.

No! I'm not suggesting the colour icon is replaced, I'm suggesting a symbolic icon is provided to complement the colour icons on the Linux releases as is common in the GNOME environment.
For example, GNOME Calculator has a full-colour standard icon used in the Applications menu, Search, About ext

However, when running a symbolic icon is used on the topbar

@bpasero  consider reopening?

Please see https://code.visualstudio.com/blogs/2017/10/24/theicon


Provide vtables from COM and WinRT as raw bindings

Motivation
I recently wanted some raw bindings for mmdevice and mme api so I used the windows-sys crate as a dependency. It all went smoothly in the beginning but soon I needed to construct and call the MMDeviceEnumerator COM Interface. From there on it was a huge pain. The windows-sys crate as stated in "Choosing between the windows and windows-sys crates" does not support COM in favor of compilation speed. At first I just copied the required vtables provided by the windows crate into my project but that was really unpleasant experience. I still wanted raw bindings but had no easy access to the vtables for COM Interfaces. So I chose to scrap the idea and just import both windows and windows-sys and use the windows crate whenever I need COM.
Why is there no crate with the full set of raw bindings for the windows apis?
I think this is a big issue for usability, especially for other rust libraries. I have seen some examples on the way (e.g cpal PR#778) which also just copy the vtables into their source code to interact with COM while using windows-sys. The windows crate provides a lot of convenient wrappers but I would still appreciate to have a complete raw binding crate like other C-style apis for rust provide. What are your thoughts?
Drawbacks
I am not sure if this would require a new crate. I would expected it from the windows-sys crate because the "sys" suffix seems to be used for raw binding libraries but as stated COM and WinRT were explicitly removed to improve compilation speed.
Rationale and alternatives
No response
Additional context
This also relates to #2187

Rust doesn't directly support virtual functions the way that C++ does (and required by COM) so simply providing the "raw" bindings does not in practice help very much to call COM or WinRT APIs since a lot of code is still required to deal with calling conventions, membership, vtable indirection, queries, and ownership. As such, adding all of that to the windows-sys crate would negate the benefits of the crate.
Your best bet it is to use the windows crate as I described here:
https://kennykerr.ca/rust-getting-started/windows-or-windows-sys.html
If the compilation cost is too high due to the overall size of the windows crate, standalone code generation is provided and lets you generate just the bindings you need:
https://kennykerr.ca/rust-getting-started/standalone-code-generation.html
This is what @Jake-Shadle, the author of the PR you cite, indicated he would use for such scenarios (#1720) so it's unclear why he's taken the approach of adding all that hand-rolled/copied code into the PR. That seems entirely unmaintainable.

For me its not so much about the compilation time, but more about the idea that bindings should provide a minimal interop to C/C++ even for virtual functions. In this case it would translate to a crate for rust wrapped types (windows) and a crate with only the minimum but still complete set of unsafe interop with vtables, structs and no altered function parameters. An example are these C# interop packages (P/Invoke) that basically act like a bare metal bridge between C# and C/C++.

I appreciate that the "idea" of raw COM bindings might be appealing in Rust, but they're not very practical due to the amount of extra scaffolding required to actually make them work in practice. I continue to optimize and streamline the windows crate and its code gen to eliminate or minimize the real or perceived overhead, but providing another alternative doesn't seem beneficial at this point.

Anyway, closing for now but feel free to keep the conversation going!

Could there be a middle ground with another crate for COM support ? Something like https://lib.rs/crates/com or https://lib.rs/crates/com-rs.
It would not weigh in on windows-sys and would be far lighter than using windows.

The windows-implement and windows-interface crates are essentially equivalent to the old com crate. They are dependencies of the windows crate but could in theory be standalone:
https://crates.io/crates/windows/dependencies
But that's different to providing the pre-generated bindings for existing COM and WinRT interfaces in the Windows SDK.


rootless k3s: allow configuring the mtu of slirp4netns

Is your feature request related to a problem? Please describe.

I'm trying to change the mtu of slirp4netns used by k3s when running a mostly default rootless configuration and I don't see any option. This is because I suspect I'm hitting performance issues related to the following https://github.com/rootless-containers/slirp4netns/issues/128
Is this already supported?
Describe the solution you'd like

Ideally this would be configurable directly in the config.yaml of k3s

I would defer to @AkihiroSuda on where this sort of configuration belongs.

Probably in https://github.com/k3s-io/k3s/blob/f2585c1671b31b4b34bddbb3bf4e7d69662b0821/pkg/daemons/config/types.go#L38 ?

Is this just a flag that needs to be passed to the command, or ?

I think so - slirp4netns starts with the following parameters:
slirp4netns --mtu 65520 -r 3 --disable-host-loopback --cidr <IP_ADDRESS>/16 121584 tap0

I think doing just mtu is enough for most people hitting performance issues; maybe --disable-host-loopback as a toggle could be interesting. Everything else seems to have sane defaults.
For reference:
# slirp4netns --help
Usage: slirp4netns [OPTION]... PID|PATH [TAPNAME]
User-mode networking for unprivileged network namespaces.

-c, --configure          bring up the interface
-e, --exit-fd=FD         specify the FD for terminating slirp4netns
-r, --ready-fd=FD        specify the FD to write to when the network is configured
-m, --mtu=MTU            specify MTU (default=1500, max=65521)
-6, --enable-ipv6        enable IPv6 (experimental)
-a, --api-socket=PATH    specify API socket path
--cidr=CIDR              specify network address CIDR (default=<IP_ADDRESS>/24)
--disable-host-loopback  prohibit connecting to <IP_ADDRESS>:* on the host namespace
--netns-type=TYPE        specify network namespace type ([path|pid], default=pid)
--userns-path=PATH       specify user namespace path
--enable-sandbox         create a new mount namespace (and drop all caps except CAP_NET_BIND_SERVICE if running as the root)
--enable-seccomp         enable seccomp to limit syscalls (experimental)
--outbound-addr=IPv4     sets outbound ipv4 address to bound to (experimental)
--outbound-addr6=IPv6    sets outbound ipv6 address to bound to (experimental)
--disable-dns            disables <IP_ADDRESS> (or configured internal ip) to host dns redirect (experimental)
--macaddress=MAC         specify the MAC address of the TAP (only valid with -c)
--target-type=TYPE       specify the target type ([netns|bess], default=netns)
-h, --help               show this help and exit
-v, --version            show version and exit

It doesn't look like we're actually setting the MTU, according to the code here we are setting it to 0 which I suspect causes slirp4netns.NewParentDriver() to configure it automatically?
https://github.com/k3s-io/k3s/blob/master/pkg/rootless/rootless.go#L156-L167

Check out the PR I just merged. You should be able to use a commit build from the installer once CI is done.

Tested slirpnet mtu configuration here at the bottom of the second detail section - https://github.com/k3s-io/k3s/issues/6488#issuecomment-1339946080


Permission denied error

loading annotations into memory...
Traceback (most recent call last):
File "/jmain02/home/J2AD014/mtc11/rxt49-mtc11/.conda/envs/semi/lib/python3.8/site-packages/mmcv/utils/registry.py", line 52, in build_from_cfg
return obj_cls(**args)
File "/jmain02/home/J2AD014/mtc11/rxt49-mtc11/Semi-DETR/thirdparty/mmdetection/mmdet/datasets/custom.py", line 90, in init
self.data_infos = self.load_annotations(self.ann_file)
File "/jmain02/home/J2AD014/mtc11/rxt49-mtc11/Semi-DETR/thirdparty/mmdetection/mmdet/datasets/coco.py", line 48, in load_annotations
self.coco = COCO(ann_file)
File "/jmain02/home/J2AD014/mtc11/rxt49-mtc11/Semi-DETR/thirdparty/mmdetection/mmdet/datasets/api_wrappers/coco_api.py", line 23, in init
super().init(annotation_file=annotation_file)
File "/jmain02/home/J2AD014/mtc11/rxt49-mtc11/.local/lib/python3.8/site-packages/pycocotools/coco.py", line 81, in init
with open(annotation_file, 'r') as f:
PermissionError: [Errno 13] Permission denied<EMAIL_ADDRESS>How to handle this error?

It looks like there is a problem with the target files. could you check whether the file exists in the target folder, or authorize the corresponding permission to the files(read permission)?


[Snyk] Upgrade isolated-vm from 4.6.0 to 4.7.2

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade isolated-vm from 4.6.0 to 4.7.2.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released a month ago, on 2024-01-20.

The recommended version fixes:

Severity
Issue
PriorityScore (*)
Exploit Maturity

Prototype Pollution SNYK-JS-XML2JS-5414874
372/1000  Why? Proof of Concept exploit, CVSS 5.3
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Release notes

Package name: isolated-vm

4.7.2 - 2024-01-20No content.

4.6.0 - 2023-07-25No content.

    from isolated-vm GitHub release notes

Commit messages

Package name: isolated-vm

fc9d899 Bump npm version -> 4.7.2
fba4d3c Fix platform delegate race condition
aabf3cd Update dependencies (#449)
df2e49a Use max jobs also on rebuild (#445)
5228f7f CI: Update actions and fix prebuild on osx (#444)
c4f99f7 Fix repeated word "as" (#397)
f6cc843 Fix use after free issue
478815b Fix return type of `IsolateEnvironment::GetCurrent()`
90a4746 Fix running on Node 20.11 (#441)
b44f7d0 Prebuild: Trigger on tag instead of release (#440)
79ba8d2 Prebuild: Update versions (#437)
c96a618 CI: Workaround node-gyp issue (#439)
7a9137c Bump npm version -> 4.7.1
7f70d25 Fix inspector on nodejs v20
266d9e8 Scale node-gyp automatically (#429)
61bc6a8 Bump npm version -> 4.7.0
7760c6f Add manual workflow dispatch
01e027f Improve support for reloading module in multiple workers (#402)
202b4b2 Update README.md (#408)
87e9abc FAQ
c3fe026 Update README.md (#406)
32a9738 Issue template
918b111 properly set up the struct sigaction (#386)
8b6b237 prebuild on ubuntu 20.04 (#382)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

duplicate


feat(constraints): Supports constraints for docker backend

Related to #311 #342
[docker]
endpoint = "unix:///var/run/docker.sock"
constraints = ["tag==api", "tag==he*ld"]

$ docker run -d -P --label traefik.tags=api,helloworld emilevauge/whoami

One minor comment.
Other than that, LGTM :)
Thanks @samber !
/cc @vdemeester

LGTM 🐼 with @emilevauge's comment taken care of and a rebase :angel:

Humm, I'm  trying to use the suggested syntax but it is not working. Error log:
Error reading TOML config file /etc/traefik/traefik.toml : Type mismatch for 'main.TraefikConfiguration.Docker': Type mismatch for 'provider.Docker.Constraints': Type mismatch for types.Constraint. Expected map but found 'string'.

But I found a workaround (maybe a workaround) configuring the Constraints globally, described at #451.
Can you point what's the correct TOML syntax to configure constraints inside [docker] section?
Thanks!


BUG: incorrect nearest neighbor search using workers=-1

Describe your issue.
If I using KDTree().query() with the argument workers and the values 1 or -1 I got different results. The result, using multiple workers, is wrong. The error only appears using many points in the query task (maybe you have to increase the number of points of coo2 in my code example). Using fewer points, all is fine.
Reproducing Code Example
import numpy as np
from scipy.spatial import KDTree

coo1 = np.random.rand(int(3e3), 2)
coo2 = np.random.rand(int(3e8), 2)

tree = KDTree(coo1)
_, idx_single = tree.query(coo2, k=1, workers=1)
idx_single_bin = np.bincount(idx_single)

_, idx_multi = tree.query(coo2, k=1, workers=-1)
idx_multi_bin = np.bincount(idx_multi)

if idx_single_bin[0] != idx_multi_bin[0]:
    raise ValueError("result is not equal")

Error message
Traceback (most recent call last):
  File "d:\studom\CodeProjects\voxel_compare\issue-workers.py", line 1
5, in <module>
    raise ValueError("result is not equal")
ValueError: result is not equal

SciPy/NumPy/Python version and system information
1.11.1 1.25.0 sys.version_info(major=3, minor=11, micro=4, releaselevel='final', serial=0)
lapack_armpl_info:
  NOT AVAILABLE
lapack_mkl_info:
  NOT AVAILABLE
openblas_lapack_info:
  NOT AVAILABLE
openblas_clapack_info:
  NOT AVAILABLE
flame_info:
  NOT AVAILABLE
accelerate_info:
  NOT AVAILABLE
atlas_3_10_threads_info:
  NOT AVAILABLE
atlas_3_10_info:
  NOT AVAILABLE
atlas_threads_info:
  NOT AVAILABLE
atlas_info:
  NOT AVAILABLE
lapack_info:
    libraries = ['lapack', 'blas', 'lapack', 'blas']
    library_dirs = ['.../Miniconda3/envs/env\\Library\\lib']
    language = f77
blas_armpl_info:
  NOT AVAILABLE
blas_mkl_info:
  NOT AVAILABLE
blis_info:
  NOT AVAILABLE
openblas_info:
  NOT AVAILABLE
atlas_3_10_blas_threads_info:
  NOT AVAILABLE
atlas_3_10_blas_info:
  NOT AVAILABLE
atlas_blas_threads_info:
  NOT AVAILABLE
atlas_blas_info:
  NOT AVAILABLE
blas_info:
    libraries = ['cblas', 'blas', 'cblas', 'blas', 'cblas', 'blas']
    library_dirs = ['.../Miniconda3/envs/env\\Library\\lib']
    include_dirs = ['.../Miniconda3/envs/env\\Library\\include']
    language = f77
    define_macros = [('HAVE_CBLAS', None)]
blas_opt_info:
    define_macros = [('NO_ATLAS_INFO', 1), ('HAVE_CBLAS', None)]
    libraries = ['cblas', 'blas', 'cblas', 'blas', 'cblas', 'blas']
    library_dirs = ['.../Miniconda3/envs/env\\Library\\lib']
    include_dirs = ['.../Miniconda3/envs/env\\Library\\include']
    language = f77
lapack_opt_info:
    libraries = ['lapack', 'blas', 'lapack', 'blas', 'cblas', 'blas', 'cblas', 'blas', 'cblas', 'blas']
    library_dirs = ['.../Miniconda3/envs/env\\Library\\lib']
    language = f77
    define_macros = [('NO_ATLAS_INFO', 1), ('HAVE_CBLAS', None)]
    include_dirs = ['.../Miniconda3/envs/env\\Library\\include']
Supported SIMD extensions in this NumPy install:
    baseline = SSE,SSE2,SSE3
    found = SSSE3,SSE41,POPCNT,SSE42,AVX,F16C,FMA3,AVX2,AVX512F,AVX512CD,AVX512_SKX
    not found = AVX512_CLX,AVX512_CNL,AVX512_ICL

cc @sturlamolden

Several people have messed with the multithreaded code since I last layed my hands on it. It might be that someone has not understood it properly.
But before I start to debug, can you please make sure there are no ties in your data set? Ties in the context of a kd-tree are points with equal distance to the query point. In the presence of ties it might be that both queries in theory is correct, but if someone has made a race condition results cound be different. We should consider such a race condition a bug, but it is a different kind of bug than a simple logics error.
I am tempted to move the multithreaded code into C++ (threads are now in the standard, just to make it more temper proof).

Also get rid og np.bincount. I don’t care for a wild goose chase that turns out to be an error in NumPy. Use e.g. np.array_equal – and also compare the single-threaded result with itself, as a negative control.

Thanks for the hints. I improved my Code Example, but the error still exists:
import numpy as np
from scipy.spatial import KDTree

coo1 = np.random.rand(int(3e3), 2)
coo2 = np.random.rand(int(3e8), 2)

tree = KDTree(coo1)
dist_single, idx_single = tree.query(coo2, k=1, workers=1)
if not np.array_equal(idx_single, idx_single):
    raise ValueError("single itself is not equal")
dist_single_u = np.unique(dist_single)
if not len(dist_single_u) == len(dist_single):
    print("similar distances detected")

dist_multi, idx_multi = tree.query(coo2, k=1, workers=-1)
if not np.array_equal(idx_multi, idx_multi):
    raise ValueError("multi itself is not equal")

if not np.array_equal(idx_single, idx_multi):
    raise ValueError("results are not equal")

Which of the tests fails?

Your check for equal distances are wrong. You are taking the query results but you need to check all 3e8 x 3e8 pairs.

Which of the tests fail?

Only the last one, so I got the message: ValueError("results are not equal")

Your check for equal distances is wrong. You are taking the query results but you need to check all 3e3 x 3e8 distances against eachother. Basically you have ((3e3 x 3e8)**2 - 3e3x3e8)/2 pairs to compare. Compute all 3e3 x 3e8 distances and push them into a set to verify that they are all unique.

Did you agree with this code?
from scipy.spatial import distance

# check for equal distances
distances = distance.pdist(coo2)
equal_distances = np.isclose(distances, 0)
if np.any(equal_distances):
    print("similar distances detected")

But the problem is: I can not compute it, because it needs too much memory 😞 .
Did you have any idea, how to compute it, using less memory or do another check?

Did you agree with this code?
from scipy.spatial import distance

# check for equal distances
distances = distance.pdist(coo2)
equal_distances = np.isclose(distances, 0)
if np.any(equal_distances):
    print("similar distances detected")

No, I do not.

But the problem is: I can not compute it, because it needs too much memory 😞 .
Did you have any idea, how to compute it, using less memory or do another check?

Memory is not the problem, a small loop in C will do this with almost zero memory overhead.
The real issue is time.


Optimize analytical solutions

Moulas 2021

@b Stokes2D_Moulas2021($coords)
# base line 4.780 μs
# new 171.631 ns

Very nice 🍡
thanks for the contribution!


Add Chatbots

https://github.com/jstumpp/awesome-chatbots
This list is about chatbots. We list services and open source projects in this area to help newcomers to find the required resources.

[x] I have read and understood the contribution guidelines and the instructions for creating a list.
[x] This pull request has a descriptive title. (For example: Add Node.js)
The list I added

[x] has been around for at least 20 days,
[x] is a non-generated Markdown file in a GitHub repo,
[x] is not a duplicate,
[x] only has awesome items with descriptions (Awesome lists are curations of the best, not of everything),
[x] contains the awesome badge on the right side of the list heading,
[x] has a Table of Contents section named Contents as the first section,
[x] has an appropriate license (Meaning something like CC0, NOT a code licence like MIT, BSD, Apache, etc),
[x] has contribution guidelines,
[x] has been checked for inconsistent formatting, spelling, and grammar (This includes starting each link description with an uppercase character and ending it with a period ., and consistent naming),
[x] has been added at the bottom of the appropriate category.

Thanks!

Seems like a slight duplicate of https://github.com/hackerkid/bots.

😢 I did not see this before. Probably add it anyway because people search for chatbots, like I did?

Maybe you could co-operate with @hackerkid?

Yep, first come first serve. That is life.
Thanks anyway.


LAU-491 Update Case Disposer functional tests to use API instead of D…

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/LAU-491
Change description
Update Case Disposer functional tests to use API instead of Database calls
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[X] No

Opening a new one


Configure hostIP of Pod's status and support hostNetwork

What type of PR is this?

/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #284
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

The commit message may contain some special characters that cause do-not-merge/invalid-commit-message

Indicates that a PR should not merge because it has an invalid commit message.

https://github.com/kubernetes/community/blob/49fde191a905ae4bf165ef5850821fbe8fb36d96/contributors/guide/pull-requests.md?plain=1#L437
It looks like the title is causing the labels
/retitle Configure hostIP of Pod's status and support hostNetwork

https://github.com/kubernetes-sigs/kwok/blob/cef98dea6bd74b1fcd5262f601bc293196c72fa5/pkg/kwok/controllers/pod_controller.go#L419
Additional, we should ignore HostNetwork in IP recycling
if c.nodeHasFunc(pod.Spec.NodeName) && pod.Status.PodIP != pod.Status.HostIP && !pod.Spec.HostNetwork {

https://github.com/kubernetes-sigs/kwok/blob/cef98dea6bd74b1fcd5262f601bc293196c72fa5/pkg/kwok/controllers/pod_controller.go#L419
Additional, we should ignore HostNetwork in IP recycling
if c.nodeHasFunc(pod.Spec.NodeName) && pod.Status.PodIP != pod.Status.HostIP && !pod.Spec.HostNetwork {

I think we may not add condition pod.Status.PodIP != pod.Status.HostIP. Adding this condition will affect the case !pod.Spec.HostNetwork and c.enableCNI . The enabled CNI might somehow set pod.Status.PodIP=pod.Status.HostIP. In that case, cni.Remove will be skipped.

Thank you, change LGTM
https://github.com/kubernetes-sigs/kwok/blob/cef98dea6bd74b1fcd5262f601bc293196c72fa5/test/kwok/kwok.test.sh#L111
Can we add a test to cover this change.

For Pods without HostNetwork, PodIP and HostIP are not equal.
For Pods with HostNetwork, PodIP and HostIP are equal.
The Pod's HostIP is equal to the IP on its node

Thank you, change LGTM
https://github.com/kubernetes-sigs/kwok/blob/cef98dea6bd74b1fcd5262f601bc293196c72fa5/test/kwok/kwok.test.sh#L111
Can we add a test to cover this change.

For Pods without HostNetwork, PodIP and HostIP are not equal.
For Pods with HostNetwork, PodIP and HostIP are equal.
The Pod's HostIP is equal to the IP on its node

Amended  for changes.  However, I think we should not check the first condition because there may be the future case that supporting CNI like host-device that PodIP and Host IP are equal without HostNetwork. Each CNI should have its own test .

Amended for changes. However, I think we should not check the first condition because there may be the future case that supporting CNI like host-device that PodIP and Host IP are equal without HostNetwork. Each CNI should have its own test .

With the CNI case in a separate test https://github.com/kubernetes-sigs/kwok/tree/main/test/kwok-with-cni, this one is a standalone.

Amended for changes. However, I think we should not check the first condition because there may be the future case that supporting CNI like host-device that PodIP and Host IP are equal without HostNetwork. Each CNI should have its own test .

With the CNI case in a separate test https://github.com/kubernetes-sigs/kwok/tree/main/test/kwok-with-cni, this one is a standalone.

I think we should let that CNI test check Pod IP correctness (such as within CIDR) when hostNetwork=false (including For Pods without HostNetwork, PodIP and HostIP are not equal) and that could be in another PR.

I think we should let that CNI test check Pod IP correctness (such as within CIDR) when hostNetwork=false (including For Pods without HostNetwork, PodIP and HostIP are not equal) and that could be in another PR.

I agree with you, I also have such expectations

/approve
/lgtm
Thank you for your contribution


loki_handler disable, Halo spinner implement while uploading to NAS

loki_handler disable, Halo spinner implement while uploading to NAS  (￣▽￣)"

every thing look good!


Months name wrong output

selected date is  6  june  2016.
(show toast message )
but wrong displyed calender title month. ( 7월 -> july ) 월 is korean mean month.

Test results have looked like any other language will be output.
on Android 6.0.1 and Android 5.0


Basic Server Network Monitoring

Adds the first half of the implementation for basic server network monitors in #87.
Adding functionality to upgrade the monitor stratum levels is required before closing out #87.

Coverage remained the same at 99.76% when pulling 86b7d33d60356d19255d1eee16405996cf5c6f28 on ju2wheels:monitoring into bdae747c15df6807691db6692cb1ce544be88dca on softlayer:master.

Coverage remained the same at 99.76% when pulling 86b7d33d60356d19255d1eee16405996cf5c6f28 on ju2wheels:monitoring into bdae747c15df6807691db6692cb1ce544be88dca on softlayer:master.


Add groundwork to have queries like: "actor name and unwatched movie"

This adds groundwork to have queries like: "actor name and unwatched movie".
It adds MovieSection methods to get Actor/Writer/Genre.. objects from their names.
These can then be used in Section.search() as query arguments.
Changes:

Additional MovieSection methods to query by genre and writer (plex directly supports it).
VideoTag objects can be created from dict.

From a first glace at this changeset, it looks like you did a lot more than the title states.  Also sending commands to client via RPC, etc. Many of the changes would be welcomed, but I its really hard to merge a branch with multiple unrelated features added.

It Is only adding functions. It won't break stuff. It contains 3 mayor things. First the rpc call to navigate a client to a certain detail screen. Second, additional objects like the already existing actor e.g. director, genre, rating... And third, functions for all the object to create these objects from a name.
The problem it fixes is to get the plex id of for example an actor just by name. These ids contained in the objects can then be used in search queries.
If you want to see it used have a look at my natural language plex remote project.

OK, I understand whats going on now and it looks good, thanks. I'll look at merging this one in next after I get the master branch back to a stable state from the audio merge. Things are a bit in flux at the moment form that one.
Did you end up writing a search function on your end that allows you mix and match these available filters?  I'm contemplating changing the search function to be a bit more usable.  This code will give me a huge head start, what would you think about something like the following:
Change the prototype of the Library.search() function:
def search(query, vtype='all', **kwargs):
    # kwargs could be any of the following:
    # 'unwatched': boolean
    # 'duplicates': boolean
    # 'year': ['1963', ...]
    # 'decade': ['1960', ...]
    # 'genre': [list of strings]
    # 'content_rating': [list of strings]
    # ...you get the idea...

The idea here is that search supports everything the current web client supports. Items like actor could be passed in as an int or a string and the conversion is done automatically.

In my use case/library I do the search basically in two steps there. First is the translation of name strings to objects/ids. The second step is your search function that already supports searching/filtering by objects/ids.
The translation works by requesting all items of a kind and comparing the name to the given one, e.g. filtering by genre 'Comedy' would request all genres and then compare their name with 'Comedy'. If it matches the object with its id is returned.
You can insert this step into you search function to make it possible to directly search/filter by strings.
One thing to consider… different use cases may require different compare functions.
For example actors can be compared word wise or by equality. "Bruce Wills" == "Bruce"?.
An additional optimization would be to have the list of all actors, genres etc. cached.

I really appreciate the contribution here. I'm not going to merge this change directly, but I believe the issues address are largely covered in the master branch.

Library.Section.Search() now accepts sort and filters in a much more friendly api. A few usage examples are below. One thing I noticed when searching for actors by name is that not all actors are listed in the /library/section/x/actor resultset, it looks like it only shows the top 100 or so. In those cases you'll need to know the id of the actor directly. See the test test_crazy_search for a working example.

movies = plex.library.section(MOVIE_SECTION)
movies.search(director='Trevorrow')   # search by string.
movies.search(director=['Adam Brooks', 'Adam Green'])   # search by a list of strings (results are OR'd).
movies.search(director=[1234,4567])  # search by ids directly

steven = movies.get('Jurassic Park').directors[0]
movies.search(director=steven)  # search by director object

# Find all movies containing at least one actor from Jurassic Park and directed by steven..
actors = movies.get('Jurassic Park').actors  # note actors is a list
related = movies.search(actors=actors, director=steven)

The second part of this merge request is adding RPC command ability to the client.  I was looking at this and had it implemented but decided its just not time to bring that in yet. Currently everything in this API is working off the XML documents, and introducing a new protocol in the mix is a bit confusing. Especially in the client code which I feel still needs some more tlc to get what is currently there working  a bit more solidly.
That said, I did add the new abilities through the XML API. We can now set the audio, language, and navigate to directly to a media object on the client. The only thing I could not figure out is how to call subtitle.next. The way it currently gets set is by getting the subtitle object and calling client.setSubtitleStream() with the object directly.
Whew.. that was long. If you have time, play around with the master branch and let me know what else you may need.

Looks awesome. I will port my lib to use it.
I guess getting around changing subtitles will not be hard. I will try.
The only feature request that now comes to mind… and it is really just a non functional feature, would be caching of library.listChoices() results for speed improvements ;D.
The code is very concise and clean. Good work!

I agree caching would be nice. I have been thinking about it but neglected to put it in just yet. I was thinking it could be done more globally. If all requests go through server.query() then we can cache everything. The tricky part is knowing how long something should stay in cache and making sure there is a clean easy way to clear and and optionally not use it. We should probably open a discussion in the issues of there isn't one already.

Concerning the caching… doing it in server.query is probably a good idea. Although keep in mind a lot of the server requests have side effects like playing a movie ;D.
One thing I just saw in your search implementation. The ALLOWED_FILTERS in the shows section is weird. They do not include filters for episode level.
For example:
if you filter shows by year you get all shows that started that year. If you filter episode by year you get the episodes in that year. Other things like 'writer' can only be filtered on episode level, not show level.
And the other way around actors can only be filtered on show level but not episode level.
filterable in episode:  'director', 'writer', 'year', 'decade'
filterable in show: 'actor', 'genre', 'contentRating'
And I see you left filter by actor out completely. Any reason for that?


angular Sweet Alert

I used to use this url https://leftstick.github.io/angular-sweetalert/bower/sweetalert/dist/sweetalert.css but it says 404 not found ?? why  is that so ?? I am using this for one of my client please help me asap

sweetalert was pushed by accident, it should be maintained by sweetalert itself, not me.
I was not expecting anyone referring it from my repo, that's why i removed it yesterday(Just found i pushed them yesterday^^).
You can referring it from sweetalert.css directory


PostgreSQL returning not accepting functions

Hi,
I've noticed that PostgreSQLQueryBuilder does not accept any function to be present in returning list. It makes a false assumption that all functions are aggregates, but this is not true.
I propose to fix that by replacing checking if term has type Function with checking if a term is an aggregate by checking its is_aggregate member.
Piece of code in question:
    @builder
    def returning(self, *terms: Any) -> "PostgreSQLQueryBuilder":
        for term in terms:
            if isinstance(term, Field):
                self._return_field(term)
            elif isinstance(term, str):
                self._return_field_str(term)
            elif isinstance(term, ArithmeticExpression):
                self._return_other(term)
            elif isinstance(term, Function):
                raise QueryException("Aggregate functions are not allowed in returning")
            else:
                self._return_other(self.wrap_constant(term, self._wrapper_cls))

Please let me know if in your opinion my approach is valid. When I get the confirmation, I can submit a PR.

Thanks for merging the PR. Could you please release it with the new version? I need that functionality in my project now.


mountlib: check if directory is not empty before mounting - fixes #1386

Signed-off-by: Ernest Borowski<EMAIL_ADDRESS>

@ncw
Can you revisit changes?
I revisited my commit using your tips.

@ncw
Can you make review ?

Very nice - thank you :-)


Modernize Codebase

The age of the codebase is quite apparent in some places (e.g. boost::filesystem instead of std::filesystem and similar for optional and others). This pull-request aims to improve on this by modernizing the CMake build files, integrating protobuffs and antrl into the CMake build process instead of providing separate scripts, and updating the code to use C++23 features.

[ ] Modernize the CMake configuration to be compiler-agnostic and use CMakes to manage include-directories and linking of dependencies

[x] For netspeak
[ ] For tests
[ ] For python bindings

[x] Integrate protobuffs and gRPC with CMake
[x] Integrate antrl4 with CMake
[ ] Replace C Code with C++ Code

[ ] Use limits instead of UINT32_MAX and co

[x] Replace boost::filesystem with std::filesystem

[x] boost::filesystem::ofstream was deprecated and remove and should be replaced

[x] Replace boost::optional  with std::optional
[ ] Remove deprecated C++ features

[ ] Remove std::unary_function
[ ] Remove std::binary_function

[ ] Use GitHub Actions

[ ] To test the code
[ ] To build and publish a docker container for netspeak
[ ] To build and deploy documentation

std::filesystem, std::ifstream, std::ofstream, and std::optional are currently used as drop-in replacements for their boost counterparts. This should hold in large parts but may have introduced minor differences.


tests improvements

[ ] use assertion package consistently for all unit tests
[ ] convert to table-driven tests
[ ] add function to allow overriding/generate expected output
[ ] avoid issues of line endings \n\r vs \n for output comparison
[ ] on require/assert calls, add message with details about test name

table-driven tests:
https://adlerhsieh.com/blog/a-deep-dive-into-table-driven-testing-in-golang
https://www.gopherguides.com/articles/table-driven-testing-in-parallel
https://gist.github.com/posener/92a55c4cd441fc5e5e85f27bca008721
https://medium.com/code-chasm/unit-test-in-go-8d17d3910818


Future Development

Markdown Edit uses a couple of technologies that are essentially dead. Namely, Avalon Edit and the built in WPF Web viewer which relies on the ancient and no longer maintained IE technology. Cleary the push is towards UWP applications. Having never written a UWP app before I spent the weekend ramping up on this new technology. I was somewhat disappointed at first in that it felt like WPF with a lot of noise and restrictions.
I eventually whittled one of the starter templates down to something I could understand. Their starter templates are overly verbose and needlessly complex. Next, I decided to try to figure out how to use IOC. I didn't do this with Markdown Edit because the technologies to do this were not fully baked. I get dinged for that a lot but the technologies at the time added up to 10 seconds to the start time. Plus they gave me a headache 😄.
I looked at Prism again and it looks like they have cleaned things up quite a bit. Spent a frustrating afternoon making it work with UWP. Oddly, there are no starter templates for UWP using Prism (at the time of this writing). I had to start with a blank UWP and work in the Prism stuff. There are a few samples buried in the docs that help.
OK so now, I could measure how long it takes to start a modern windows app with IOC and MVVM. Cold start is about 2 seconds. Hot start is less than a second. That's acceptable although I would have liked to see a faster cold start.
UWP apps enjoy lots of other benefits, not the least is a modern web view. The installation experience is much better as well.
One key component missing is a good text editor control. The only one I've found is by http://www.actiprosoftware.com and it runs about $400. Maybe there's one out there for less?
In the meantime, I'll use the UWP TextBox and skip syntax highlighting until I get further along. Right now it's just an experiment but if I can prove out a few technologies I might make it the successor to MDE.
I've resisted UWP for some time thinking it might die (like Windows Phone). But with MS Office now in the app store, I'm thinking it's time to get on board.  So what are your thoughts about this?
https://github.com/mike-ward/TypeDown

I admit I'm in love with MarkdownEdit and would hate to see it no longer receive updates. That said, I also have no problems using UWP, and employ a great number of them in my workflow. I'm down for trying the new thing!

Some rambling thoughts.
I generally don't like UWP applications, they invariably seem dumbed down compared to traditional applications. However, given that MDE doesn't have much of a UI anyway, it would probably be a good fit. (I don't mean that in a negative way!)
I did dabble with UWP before I realised that MS had screwed over us Windows Phones users yet again and it was a bit of a shock coming from my classic WinForms development head (I skipped WPF completely for various reasons) with the permission system, e.g. you can't open a file unless the user actually selects it first. Might make creating a MRU a little difficult without those tokens! With that said, I was very impressed that the application I wrote worked on my desktop and my Windows Phone without lifting a finger, so perhaps I'm just being curmudgeonly.
As far as the Windows Store goes - the Office versions aren't UWP, they are still the Win32 applications; just using Project Centennial (I believe). So therefore there's probably nothing stopping you from packing MDE up on the Store if you really wanted (although I'd hope you still keep the traditional version as well if you went that route).
Frankly at this point I couldn't care less about UWP - there's no Windows RT, they are doing their utmost best to kill Windows Phone, so realistically it only applies to Windows 10 (maybe XBox but would you really be using MDE on that?) and anyone on 7 or 8 are stuffed. Or maybe Windows 10 Mobile.Next will magically save the day as so many previous platform changes didn't (yeah, right). So it seems to limit your user base significantly for little gain. That's my personal opinion though and I'm probably completely wrong - maybe I'll change my mind when I actually do something real with UWP instead of toy test applications. Same goes for .NET Core too I guess.
shrugs Rambling thoughts indeed.

As I play with UWP more I'm finding too many restrictions (like the file thing you mentioned). All in all, I think my little experiment is coming to an end. I think my next fork is going to be a traditional WPF app with Prism. I need to shop for a new editor since Avalon Edit is dead. Just wish I could find a web view that didn't rely on IE and worked in WPF. I tried Awsome-ium or whatever it's called and its performance was miserable.

Isn't AvalonEdit the backbone of SharpDevelop? Is that project dead too or why do you think AvalonEdit is dead? As far as embedded browsers go I haven't got much to offer as I still use embedded IE myself the few times I need it. If I remember rightly the problem with Awesomium when I last looked at it was its nuts footprint; it was huge. Have you tried CefSharp? I remember looking at probably a couple of years ago but maybe it's matured since. I haven't really had any issues with MDE in regards to its embedded browser - the odd scroll issue where it isn't quite in sync but nothing earth shattering. It just works. At least from my end user perspective, I don't know what spit and wire you're using behind the scenes.

It is but it hasn't been released in over a year. The fact is there is not much if any competition for a WPF text editor. Most of the offering are for Rich editors.
I knocked out a quick framework using Prism and WPF last night. It feels much better. UWP isn't meant for desktop applications and I can see that now. I'm going to port the current code over to the new Prism architecture. Same look and feel and features. If I do my job right, you shouldn't see a difference.


added the 'try' spin lock since this is required by some code in mldb…

… pro.

This was superseded by #42 and is thus being closed.


The efficiency of 'insertBatch' function

Hi there,
I have a concern about the efficiency of 'insertBatch'. Would it be better to use 'insert into xx select xx union select xx ' instead of loop when having  small data?
well...exclude duplicate rows
thx & kind rgds

Possibly. Care to create some benchmarks and test it?
My biggest concern would be that it works for all of the database engines that CI3 currently supports. Aside from that, if there's a boost for small datasets but it slows down on larger datasets, we'd have to do a bunch of testing on all of those platforms to find where the happy medium is across all of them.
While I wasn't involved in writing the insertBatch query, I'm guessing those elements played a big part in it.


fix vertico /ssh: tramp hostname completion

enable tramp hostname completion in vertico find file. according to vertico docs: https://github.com/minad/vertico#tramp-hostname-completion
https://discord.com/channels/406534637242810369/406554085794381833/870236834687492116

I think it would be a better idea to use the completion style method using basic-remote that's listed there.

I  added the basic-remote completion and it works although I am not sure I can verify if everything else still works.

should the overwrite be with orderless (like it was before) or without (like in the vertico doc)?

This portion of the readme is currently going through an overhaul (started after you submitted the PR :D), and might also get released as a separate small package for extra completion styles. I suggest this PR be put on hold until that gets sorted. It might end up getting superseded by a solution that requires adding another package.

Nevermind, the situation is staying as is in the end, so no changes relating to that needed.

Hey, I've adapted this commit to the current vertico improvements pr (#5353), since the current one has some merge conflicts and doesn't follow the new git commit conventions (and it will also probably get merged faster this way :stuck_out_tongue:). I've added you as co-author as well.


NO-ISSUE: Modify OWNERS

Since we are now running the team with core members, OCTO disengaged and there are only a few collaborations with other teams, we reduce the scope of the reviewers to the core members while keeping them in emeritus approvers for a second informed opinion if there is a need This way we avoid spamming folks who have no time to devote to MicroShift and we also dont slow down PR merge flow.

Which issue(s) this PR addresses:

Closes #

/verify-owners

/lgtm


Resolve various typos throughout the SDK

Description
This PR resolves various typos found throughout the project in code comments and class/struct/function names. Not sure how helpful this is and I don't want to pollute the git history if that is a concern. Just wanted to clean up a few things as I get familiar with the codebase! :)
Checklist

[x] PR Description to summarize changes
[x] Add sufficient test coverage
[x] Read Contributing Guidelines
[x] Agree to Embrace CLA

Hey @jstart! Thank you very much for the PR! You did a huge code review! And it's very helpful because anything that improves code readability is always beneficial 😁
I made a couple of brief comments, but overall it looks very good!

@jstart seems there's a compiling issue on SessionRecordTests regarding a typo you fixed: fetchOldestSesssion to fetchOldestSession. Seems like it's missing a replacement there too:
-> ❌  /Users/runner/work/embrace-apple-sdk/embrace-apple-sdk/Tests/EmbraceStorageInternalTests/SessionRecordTests.swift:275:35: value of type 'EmbraceStorage' has no member 'fetchOldestSesssion'

SessionRecordTests

Ah thanks for catching that! I'll make sure all the test targets build and run.

@ArielDemarco I think I got the tests green finally! Let me know if you think any other changes are required!

This looks like it needs to be rebased off main. Should fix the conflicts and the test failures in LogExport

This looks like it needs to be rebased off main. Should fix the conflicts and the test failures in LogExport

Just pulled from main and handled the conflict! @ArielDemarco

I'll merge it as seem tests are working fine and xcresultool is not working properly to get coverage.
Great job @jstart


Cherry-picks for Firestore 1.8.3

This is everything we've found required to support C++ and Unity based on iOS M61.

Note that if perform a regular merge of this PR (rather than squash/merge) then there will be no conflict with the corresponding changes on master).

No need to change the config; I did it from the command-line.


Avoid depending on appengine-api-1.0-sdk

As @aozarov mentioned in #45, it'd be nice to avoid depending on appengine-api-1.0-sdk (17Mb jar) when not necessary.
Alternate options include:

Use "provided" or a like as a maven dependency
Use reflection to invoke methods on AppIdentityService. gcloud-java used to do the latter.

I'd like to understand this better.
The main http-oauth2 assembly does not have a hard dependency on this. It makes a late bound call to the SDK method that tells you definitively if you are running in a GAE process. Only if true does it make a second late-bound call to the appengine-specific auth component. That in turn has a hard dependency on the appengine-api-i1.0-SDK. So this should avoid needing to take any app-engine related .jar file along for non GAE scenarios, either the SDK or the auth component.
For the case where you are running in GAE, the app-engine specific component does have a hard depedency. But any app-engine app will also have this dependency. Is there a case on App engine where you want to dependent on the app-engine specific auth component, but not the app-engine SDK?

The gcloud-java library supports users running on App Engine, but it can also be used from outside of App Engine.  As a result, gcloud-java has to take the appengine module as a dependency, even if we don't run on App Engine.

It is also the case that the Http-OAuth2 component is used inside and outside app engine. In both cases there is a late bound call for good reasons. The OAuth2 libraries also don't take a direct dependency on the App-engine SDK. Only the App-Egine-specific component does and that is itself already invoked late bound by the Oauth2 component.

@anthmgoogle gcloud-java has one artifact for all platforms.
As I see it, in the current state, that means we have 2 options:

Add to our pom a dependency on google-auth-library-appengine and pay the price of depending and pulling 17Mb even when not needed.

Direct people that use gcloud-java on AE to also add a dependency on google-auth-library-appengine

I would like to avoid (2) in all cost. I think we can also avoid (1) by using the suggestions mentioned above.
Do you think we can avoid pulling appengine-api-1.0-sdk without requiring gcloud-java users on AE to add the dependency themselves?

Having gcloud-java dependend on google-auth-library-appengine seems wrong, because this will also pull that binary around for non GAE scenarios. It is currently small, but when 3LO logic is added, it will be bigger and have more of its own dependencies.
I'll follow up on the tradeoffs related to (2) shortly.

Any updates on your take on this issue @anthmgoogle?

Thoughts on the tradeoffs of using reflection for the GAE identity.
Without reflection a GAE app needs to know about this indirect dependency. Without it, they will fail when they try to get the application working for the first time. It would be better if this "just worked".
The GAE credential could be implemented completely in reflection to address the getting started dependency above. The biggest cost I can see is that this will add a per-request reflection call to get the access token. In common synchronous cases, this is probably dwarfed by the network round-trip. But in async or CPU-bound cases you may want to avoid it. A secondary cost is that reflection code is more costly to write and maintain.
For the code in gcloud-java this has the additional benefit of saving a whole compilation unit. This is not the case for the auth libraries, because App-Engine specific surface is needed for explicit use of App Identity and 3LO.
One way to solve both the performance and getting started issues is to implement a second fall back component in reflection and only use it if the app-engine auth library is not present. Cost is in duplicated logic. A performance-sensitive customer may prefer initial failure to silently falling back to a slower mode of operation.
It may be worth understanding ways of mitigating the the getting started problem:

Ensuring all GAE samples have this dependency.
Adding this dependency by default to GAE templates.
Ensuring the error message when the assembly is missing is very specific. (It already should be, but we can test whether people are getting confused by it).
Documentation in appropriate locations.

I think there is a nuanced tradeoff. I can see the appeal of eliminating one more piece of getting started friction. However, steps that have very clear failure modes don't cause much friction, and there is long term benefit in having a single, fast implementation.

To be clear, as of today we are only talking about this simple class.
Therefore, I don't think changing this class to use reflection is a big deal (maintenance wise).
Reflection should happen only when calling appIdentityService.getAccessToken(scopes), which
is using an RPC call, therefore the cost of the reflection part should be negligible.
If you insist of not using reflection, did you consider the maven proivded scope option?
One of the nice things about gcloud-java is the easy setup and get started. I would really want to avoid
this extra documentation and setup step. Therefore, if you choose to keep it as is, we will keep our existing reflection based AE credentials (though we can clean it up to match AppEngineCredentials.java) and use it as a fallback.

Going through the steps of setting up reflection is slow, but calling invoke() isn't all that slow if on a hot-path.
I'd find it hard to believe that calling invoke() each getAccessToken() call could be prohibitive.

OK. If the method can be cached this feature should be OK.

This was fixed in #71


[AIRFLOW-1502] Implement possibility to search runs

Implement possibility to search runs via experimental api.
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following:

AIRFLOW-1502 Implement possibility to search dag runs via experimental api

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

Implement possibility to search dag runs via experimental api.
Format:
http://localhost:8080/api/experimental/dag_runs/search/<query>

Example:
http://localhost:8080/api/experimental/dag_runs/search/scheduled

Response:
{
  "items": [
    {
      "dag_id": "trigger_1",
      "dag_run_url": "/admin/airflow/graph?execution_date=2017-08-10+09%3A03%3A00&dag_id=trigger_1",
      "execution_date": "2017-08-10 09:03",
      "run_id": "scheduled__2017-08-10T09:03:00",
      "start_date": "2017-08-10 12:02",
      "state": "running"
    },
    {
      "dag_id": "trigger_1",
      "dag_run_url": "/admin/airflow/graph?execution_date=2017-08-10+09%3A04%3A00&dag_id=trigger_1",
      "execution_date": "2017-08-10 09:04",
      "run_id": "scheduled__2017-08-10T09:04:00",
      "start_date": "2017-08-10 12:02",
      "state": "running"
    }
  ]
}

Tests

[x] My PR adds the following unit tests:

tests.models:TestDagRun.test_to_json
tests.www.api.experimental.test_endpoints

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2511 into master will increase coverage by 0.12%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master    #2511      +/-   ##
==========================================
+ Coverage   69.95%   70.07%   +0.12%
==========================================
  Files         146      146
  Lines       11448    11457       +9
==========================================
+ Hits         8008     8029      +21
+ Misses       3440     3428      -12

Impacted Files
Coverage Δ

airflow/www/api/experimental/endpoints.py
94.57% <100%> (+5.34%)
:arrow_up:

airflow/models.py
87.38% <91.66%> (+0.1%)
:arrow_up:

airflow/jobs.py
78.04% <0%> (+0.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa84d49...1b50596. Read the comment docs.

@saguziel, so all good? :)

@r39132 @criccomini @bolkedebruin will you have time to review this? Please.

Please address @saguziel points or clarify (explain elaborately) why you want some changes. If you are changing endpoints for example then this has an effect on running systems. It then needs to be properly documented and marked for a major release. Only then you can get a +1

@bolkedebruin ok, I see your point. I can keep existing one as-is. Will update this PR.

@bolkedebruin updated, please review. Thanks)

@bolkedebruin, please review. Thanks!

This PR should follow the generic architecture for APIs:

Please make sure business logic is in airflow.api.common.experimental
Expose API definitions in airflow.api.client.json/local

Do not add business logic to models (search should probably be in common.experimental.search_dagrun.py)

@bolkedebruin thanks! Will fix.


[SoftDeleteable] Is there a 'undelete' event?

Is there a undelete event?

@ping

no as far as I remember, look at the source code, will be faster than asking this question :)

Thanks, closing.


[Android] [iOS] Integrate Azure B2C

There should be a proper way to authenticate users in the app.
The best solution for this would be Azure B2C, because it is reliabel and safe to use.

Instead of Azure B2C I will implement Auth0.


Allow for very basic autoscaling (HPA) of workloads

I don't think we need anything too crazy at the moment but being able to leverage k8s to give autoscaling

This will be able to be done via #361 as well


Add a line comment to downstream e2e commits

This will ensure that each push appears unique
and retriggers the downstream e2e jobs.
Change-type: patch
Signed-off-by: Kyle Harding<EMAIL_ADDRESS>

I self-certify!


Build Failed

Build Failed
Task failed with exit code 65:
/usr/bin/xcrun xcodebuild -workspace /Users/michael/Desktop/Carthage/Checkouts/AlamofireObjectMapper/AlamofireObjectMapper.xcworkspace -scheme AlamofireObjectMapper\ OSX -configuration Release -derivedDataPath /Users/michael/Library/Caches/org.carthage.CarthageKit/DerivedData/10.0_10A255/AlamofireObjectMapper/5.0.0 ONLY_ACTIVE_ARCH=NO CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES archive -archivePath /var/folders/2n/lwg103354nj3gs9hh6x_x7300000gn/T/AlamofireObjectMapper SKIP_INSTALL=YES GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=NO CLANG_ENABLE_CODE_COVERAGE=NO STRIP_INSTALLED_PRODUCT=NO (launched in /Users/michael/Desktop/Carthage/Checkouts/AlamofireObjectMapper)
This usually indicates that project itself failed to compile. Please check the xcodebuild log for more details: /var/folders/2n/lwg103354nj3gs9hh6x_x7300000gn/T/carthage-xcodebuild.eOmvAN.log
Installing version: 5.0.0.

@tristanhimmelman  +1

Probably related with this one
*** Fetching AlamofireObjectMapper
*** Fetching ObjectMapper
*** Fetching Alamofire
*** Checking out Alamofire at "4.8.0"
*** Checking out ObjectMapper at "3.4.1"
*** Checking out AlamofireObjectMapper at "5.0.0"
*** xcodebuild output can be found in /var/folders/lt/7mft4y8n0_5gxyn0l9785_800000gn/T/carthage-xcodebuild.NwqaYJ.log
*** Building scheme "Alamofire iOS" in Alamofire.xcworkspace
*** Building scheme "ObjectMapper-iOS" in ObjectMapper.xcworkspace
*** Building scheme "AlamofireObjectMapper iOS" in AlamofireObjectMapper.xcworkspace
carthage_log.txt


use richEditorView as the cell of uitabbleView

Is it possible to use richEditorView as the cell of uitabbleView?
There's a problem with sliding.
Using OC programming

You definitely can, and I definitely have, but it's not necessarily recommended.
The problem comes down to embedding scroll views inside scroll views:

You should not embed UIWebView or UITableView objects in UIScrollView objects. If you do so, unexpected behavior can result because touch events for the two objects can be mixed up and wrongly handled.
https://developer.apple.com/documentation/uikit/uiwebview

I would suggest that you disable scrolling for the webview inside the RichEditorView. We had to do some workarounds when we did it, so we would have to grab the content size through the delegate method, and change the height of the cell if it changed. This was almost 3 years ago, so I'm sorry I don't remember the details!
Hope it works out for you :+1:


Farming Station crash with Rustic Berry Bush

Issue Description:
This issue occured in the modpack Enigmatica 2, of which I am the pack dev.
What happens:
One of my users reported a server crash, when his Ender IO Farming Station attempted to harvest a Rustic Berry Bush
What you expected to happen:
The Berry Bush to be harvested
Steps to reproduce:

Setup Farming Station with power and tools
Give it berry bushes, or place them within it's area

...

Affected Versions (Do not use "latest"):

Minecraft 1.12.2
Forge 1.12.2-<IP_ADDRESS>05
EnderCore-1.12.2-0.5.31
EnderIO-1.12.2-5.0.26
rustic-1.0.5

Your most recent log file where the issue was present:
https://pastebin.com/bYBmD9NX

https://github.com/the-realest-stu/Rustic/blob/master/src/main/java/rustic/common/blocks/crops/BlockBerryBush.java

Thank you :)


bug: collapsible header: do not animate ion-back-button when not in start slot

Bug Report
Ionic version:
[x] 4.x
Current behavior:
When using a collapsible header on the leaving view in combination with an ion-back-button on the entering view which is not used at the default iOS position (start slot) but e.g. in the primary slot as a "Done" button, it is animated, which looks a bit odd because it scales into position out of nowhere.

Expected behavior:
The ion-back-button should only be animated if its used in the start slot.
Steps to reproduce:

Create a page with a collapsible header
Create another page (also with a collapsible header) with an ion-back-button, but ion-buttons is placed in the primary slot
Navigate from page one to two

Related code:
<ion-buttons slot="primary">
    <ion-back-button></ion-back-button>
</ion-buttons>

Let me know if you need an example repository.
Ionic info:
Ionic CLI                     : 5.4.5 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.11.3
   @angular-devkit/build-angular : 0.803.12
   @angular-devkit/schematics    : 8.3.12
   @angular/cli                  : 8.3.12
   @ionic/angular-toolkit        : 2.0.0

Cordova:

   Cordova CLI       : 9.0.0<EMAIL_ADDRESS>   Cordova Platforms : ios 5.0.1
   Cordova Plugins   : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 4.1.2, (and 26 other plugins)

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   ios-deploy : 1.9.2
   ios-sim    : 8.0.2
   NodeJS     : v12.4.0 (/usr/local/bin/node)
   npm        : 6.11.3
   OS         : macOS Catalina
   Xcode      : Xcode 11.2 Build version 11B52

Thanks for the issue. Can you give this dev build a try and see if it resolves the issue?
npm i<EMAIL_ADDRESS>

@liamdebeasi Yes its working correctly with the dev build, thank you!

Thanks for checking! I've merged this fix in. It will be available in an upcoming release of Ionic.


noob question

I can not for my life find the settings.php file on my disk. How do i map the runtime to my disk so i can edit the file ?

👋 😅 https://docs.docker.com/storage/bind-mounts/#choosing-the--v-or---mount-flag


Route structure refactor and healthcheck improvements

I might have gone slightly overboard with the route refactoring but I hope you can now appreciate the better organisation :)
Regarding the healthcheck, I've updated the status code and logic for the healthcheck to pass

Will close this and raise a related issue


Error TAPO protocol with Frigate

Hi Alex
Cannot get tapo protocol to work with Dockered Frigate 0.13 and go2rtc 1.8.4.
I removed (just in case all references to rtsp protocol in config) and added tapo:// trying all 3 versions one by one.
When trying to access the stream I get
mse: streams: parse "tapo://admin:XXXXXXXXXX/<IP_ADDRESS>": invalid port ":***********************" after host.
This is a message in the viewer, no message in the logs for frigate or go2rtc or nginx.

You shouldn't have / between password and IP

You shouldn't have / between password and IP

Omg, how did I miss it... Terribly sorry Alex

All works now. Thank you


Close Icon on Login and Sign-in Page

Description

When users click on the login and sign-in buttons, they often find it difficult to go back to the previous page. To solve this problem, I recommend adding a close icon. This will help users easily navigate back to where they were browsing before.

Use Case

Adding a close icon to the login and sign-in buttons can indeed improve user experience by providing a more intuitive way for users to navigate back to the previous page. This feature can be especially useful for users who may be unfamiliar with website navigation or have difficulty finding their way back to the previous page.

By incorporating a close icon, users can quickly dismiss the login or sign-in prompt and return to their previous browsing activity without getting lost or confused. This small but important detail can enhance the overall usability of your website and contribute to a more seamless user journey.

Additional Information

[x] I am an Open Source Contributor in GSSOC'24.

Allow me to work on this issue under GSSOC' 2024 @krishnaacharyaa

What are you talking? Have you checked out our application? @Shashanktriathi1703

Yes, I have seen your  @krishnaacharyaa  Application that's why I raised the issue.

Sign in:

Sign up:


Help with Single Component Mount Animation

Trying to have this fade out when it is unmounted. Any ideas?
const TextField = (props) =>
  <TransitionMotion
    styles={[{ key: 'a', style: {opacity: spring(1, {...presets.gentle})} }] }
    willLeave={() => {opacity: spring(0)} }>
    {is => <TF key={is[0].key} style={{...is[0].style}} {...props} />}
  </TransitionMotion>

Check https://github.com/chenglou/react-motion/issues/311

@emilebosch I had tried a few things based on that. No luck.


fix overlflow issues

Description
If the event location contains long text, the entire table gets overflowed to other cards. This PR fixes that by enforcing an overflow wrap.
This comes as an addition to the fix in #543
Motivation and Context
The display is horrible when the location has long text. I can't take a snapshot due to privacy issues
How has this been tested
I uploaded the fix to my HA instance and it is working perfectly
Types of changes

[ ] Docs change / refactoring.
[x] Non-breaking change (fix or feature that wouldn't cause existing functionality to change/break).
[ ] Breaking change (fix or feature that would cause existing functionality to change/break).

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes don't generate new warnings.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests pass.

@totaldebug @marksie1988 can you please CR?


KERNELBASE.dll exception with missing method exception VssEnvironment.EnumerateVssPaths()

Have you try trouble shooting doc?
Yes.
Agent version and platform

v2.114.0
v2.115.0
v2.116.1

Platform:

Windows Server 2016
VS2015 Professional (Update 3)

VSTS type and version
VisualStudio.com
What's not working?
tf.exe in the vstsom  folder from the installed local agent.

See following when i try to run tf.exe manually:

Event log entry:
Faulting application name: TF.exe, version: 15.108.25929.0, time stamp: 0x583e1c41 Faulting module name: KERNELBASE.dll, version: 10.0.14393.1066, time stamp: 0x58d9f07f Exception code: 0xe0434352 Fault offset: 0x000da932 Faulting process id: 0x19f0 Faulting application start time: 0x01d2c7384050cee8 Faulting application path: C:\Users\Administrator\agent\externals\vstsom\TF.exe Faulting module path: C:\Windows\System32\KERNELBASE.dll Report Id: 6095e440-f263-4213-8901-0bbc0b167ef5 Faulting package full name:  Faulting package-relative application ID:
What have i tried?

Checked for corruption on server level.
Repaired VS2015.
Redownloaded and configured the agent.
Checked permissions.
Tried it as a different Windows user.
Checked 'Turn on DEP for essential Windows programs and services only'

I now realize that there is no official support for Windows Server 2016... I guess that's what's up?

@erwinkramer no i think it should work. i can setup a server 2016 machine tomorrow and try.
do you have .net 4.6 installed? i think that was related last time we hit a missing-method-exception.
how are you running tf.exe? is this during the get-sources step? or are you running it from one of your scripts?

does it work when the agent runs the get sources step against at TF Version Control repository? iirc, the agent validates that .NET 4.6.
but in the screenshot you pasted, it looks like you are not running the agent at all.

@ericsciple

do you have .net 4.6 installed?

Yes.

but in the screenshot you pasted, it looks like you are not running the agent at all.

That's correct, i tried it manually to see if it created the same missing method exception, and it did. I originally got the message in my build definition output on the Get Sources step. See attached logfile.
logs_10.zip

oh ok, gotcha

I'm unable to repro. Look under the reg key HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full
What is the decimal value for Release? Mine is 394802 which corresponds to 4.6.2 ...which is a bit stange. Since it's not Win 10 I would have expected to see 394806. I ran winver.exe and it reports Windows Server 2016 Version 1607 (OS Build 14393.0)

@ericsciple ,i have the same 394802.

My OS Build is 14393.1066

I uninstalled KB4015217  so now my OS Build is 14393.447, still no luck. Unfortuanly i can't uninstall the KB to go back to 14393.0. Could you update to my OS Build to rule out security updates?

Yes I'll update my VM. In the meantime I'm going to loop in someone from the version control team to see if they have heard of this issue. I was hoping to get a repro.

@ericsciple , thanks for the support.
Just to be clear, this machine has BizTalk 2016 enterprise, MS SQL Server 2016 enterprise and VS2015 installed as well.

Even on Windows 14393.1066 I still can't repro. I've sent a mail to the appropriate Version Control folks and log a bug internally for them to investigate (bug 992928).

@erwinkramer thanks for bringing this to our attention.
Give me some time to sync with @ericsciple and get a similar VM setup so I can attempt to reproduce the issue.
One question: does your Server 2016 have VS2015 and/or VS2017 installed on it? If so, into which path(s)? and which build(s)?
Thanks!

@erwinkramer also can you dump the externals\vstsom dir and send me the output. Something like:
dir D:\vsts-agent\externals\vstsom -r | foreach-object { "$($_.length) $($_.fullname)" } > ~\Desktop\externals.txt

I want to diff against a fresh download and rule out a corrupted layout,

@ericsciple  externals.txt
@whoisj  Only VS2015. See:

Path: C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\IDE
Other VS stuff:

Also worth noting, SQL info:

i diff'd my file against yours and the layout is exactly the same

I'm completely out of ideas. Without a local repro this is going to very difficult to resolve.
Tomorrow, I'll perform a codewalk and see if there's any hints as to why VssEnvironment.EnumeratePaths could result in a MissingMethodException while still successfully loading the strong name signed DLL.

... Of course, as soon as I claim to be out of ideas publicly, I have an idea. 🐑
@erwinkramer can you, from a Developer Command Prompt, run the following command?
gacutil /l | findstr /I Microsoft.VisualStudio.*
... and share the output. I'm wondering if the GAC isn't out enemy here. Perhaps there's a GAC version of the assembly that's being loaded that's actually older than the version shipped with the Agent. It's worth a try!

@erwinkramer as @whoisj  mentioned, check the GAC, another way to check it is when tf.exe crash, attach VS Debugger, check where is Microsoft.VisualStudio.Service.Common.dll loading from. you can see it under VS->Debug->Windows->Modules

@whoisj  output.txt

it's in the GAC. :D
  Microsoft.VisualStudio.Services.Client, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL
  Microsoft.VisualStudio.Services.Common, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL
  Microsoft.VisualStudio.Services.ReleaseManagement.WebApi, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL
  Microsoft.VisualStudio.Services.WebApi, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL

@TingluoHuang : Oh well so all i have to do is unGAC it? How did it end up there anyway? Output from all that i could get when attaching the debugger below. I guess this hints to GAC'd stuff too.
'TF.exe' (CLR v4.0.30319: TF.exe): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_32\mscorlib\v4.0_<IP_ADDRESS>__b77a5c561934e089\mscorlib.dll'. Symbols loaded. 'TF.exe' (CLR v4.0.30319: TF.exe): Loaded 'C:\Users\Administrator\agent\agent\externals\vstsom\TF.exe'. Cannot find or open the PDB file. 'TF.exe' (CLR v4.0.30319: TF.exe): Loaded 'C:\Users\Administrator\agent\agent\externals\vstsom\Microsoft.TeamFoundation.Client.dll'. Cannot find or open the PDB file. 'TF.exe' (CLR v4.0.30319: TF.exe): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Drawing\v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a\System.Drawing.dll'. Symbols loaded. 'TF.exe' (CLR v4.0.30319: TF.exe): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System\v4.0_<IP_ADDRESS>__b77a5c561934e089\System.dll'. Symbols loaded. 'TF.exe' (CLR v4.0.30319: TF.exe): Loaded 'C:\Users\Administrator\agent\agent\externals\vstsom\Microsoft.TeamFoundation.Common.dll'. Cannot find or open the PDB file. 'TF.exe' (CLR v4.0.30319: TF.exe): Loaded 'C:\Users\Administrator\agent\agent\externals\vstsom\Microsoft.TeamFoundation.VersionControl.Client.dll'. Cannot find or open the PDB file. 'TF.exe' (CLR v4.0.30319: TF.exe): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\System.Core\v4.0_<IP_ADDRESS>__b77a5c561934e089\System.Core.dll'. Symbols loaded. 'TF.exe' (CLR v4.0.30319: TF.exe): Loaded 'C:\Windows\Microsoft.Net\assembly\GAC_MSIL\Microsoft.VisualStudio.Services.Common\v4.0_<IP_ADDRESS>__b03f5f7f11d50a3a\Microsoft.VisualStudio.Services.Common.dll'. Cannot find or open the PDB file. The program '[8240] TF.exe' has exited with code 0 (0x0).

Removing Microsoft.VisualStudio.Services.Common from the GAC did the trick. Pfew, thanks a lot for your assistance guys.
Still curious what installer put that file in the GAC. It cerainly wasn't me. This machine is brand new and i did nothing with the GAC yet.

@erwinkramer  can you find the dll under C:\Windows\Microsoft.Net\assembly\GAC_MSIL, check file properties->details->fileversion?

@TingluoHuang  fileversion 15.98.25225.0

More info:

@erwinkramer can you share a full list of installed software on your box?

@erwinkramer is that dll has ditail signatures? we never ship that version of assembly into TFS product. :(
do you have ReleaseManagement installed on your box?

*digital signature

@erwinkramer are you using a physical PC or VM? can you easily re-setup the machine, install all software you had one by one, then check GAC after every software installed?

@erwinkramer have you or anyone manually put those dll into GAC?

@TingluoHuang  It was a brand new VM, nothing done with the GAC. I could re-setup the machine, however i didn't save any snapshots and i don't have much time atm. I do however suspect BizTalk Server 2016 Feature Pack 1  because it adds some VSTS integration features and it's the main reason i'm setting this VM up.
I can check on another machine if i install the feature pack, if it gac's stuff.

@erwinkramer Great, thanks for the inportant information, i will try install BizTalk myself. :D

@TingluoHuang Have fun ;)

@erwinkramer I confirmed BizTalk feature pack 1 is the evil. :D
it will put those dll into GAC. uninstall will remove them from GAC.
I will follow up with their product team to solve this problem.

@TingluoHuang Great! Glad we identified the program.
@ericsciple Shouldn't the .NET versioning info on How to: Determine Which .NET Framework Versions Are Installed still be addressed because it corresponds with Win 10 like you mentioned?

@erwinkramer true. i'll see if i can find an appropriate internal distribution list to email regarding the issue.

@TingluoHuang Do you have any news to this error. I am also setting up BizTalk Feature Pack 1 ALM and I am hanging at the same Point. It would be great to get a solution for this. Thanks in advance!

BizTalk Feature feature pack 1 CU1 should release soon and has the fix.

I managed to resolve it by:

have a separate build server.
install BTS FP1
create a copy of BizTalk Server 2016\Developers Tools
uninstall BTS FP1
replace Developers Tools folder with the copy created at step 3
copy missing assembly Microsoft.BizTalk.ALM.JsonSchema from BTS server and GAC it on build server
got a successful build
create a new queue for Release and host its build agent on BTS FP1 server

Also note that we worked with the biz talk team to fix this for their next update.

I am stuck with this, we are migrating from BizTalk 2013 to 2016 I need to set up build & releases. Help how to fix this!

@manisko what version of biztalk you installed, have you try 2016 CU3? have you check your GAC on that box as the issue mentioned above?

I have in my build server BizTalk 2016 FP1, haven't tried CU3 - can I install CU3 with FP1 ?

@manisko i got confirmed from BizTalk team, the following release should contains the fix.
https://www.microsoft.com/en-us/download/details.aspx?id=55100

@manisko i think you can. :)

Juest sec ago installed CU1/CU2 (BTS2016-KB4014788-ENU.exe) and it works for me!

@manisko cool, glad you unblocked.

I had the same problem with the project. @erwinkramer was close to the solution.
The problem lies in the wrong .NET Framework runtime version.
One has to install the correct .NET Framework runtime version!
i.e. I had 4.6.2 on the Windows Server 2016, but an application requires 4.7.2, this is why I got a method not found in Unity object exception and KERNELBASE.dll exception also in Events.
https://docs.microsoft.com/en-us/dotnet/framework/migration-guide/how-to-determine-which-versions-are-installed?redirectedfrom=MSDN


[CARBONDATA-1018] Add unsafe ColumnPage implementation

This PR is based on #987
In this PR, an UnsafeColumnPage is added, it can reduce memory requirement for data loading.
Before loading, user can add following property to enable this feature
    CarbonProperties.getInstance()
      .addProperty(CarbonCommonConstants.ENABLE_LOADING_UNSAFE_COLUMN_PAGE, "true")

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/105/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2232/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2237/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/110/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2304/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2307/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/180/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2308/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/181/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/199/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2322/

apache:retest this please

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2324/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/201/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/211/Failed Tests: 1carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test: 1org.apache.carbondata.spark.testsuite.allqueries.InsertIntoCarbonTableTestCase.insert into carbon table from carbon table union query

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2334/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2452/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/333/

LGTM

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2481/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/366/Failed Tests: 2carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test: 2org.apache.carbondata.spark.testsuite.bigdecimal.TestNullAndEmptyFields.test filter query on column is nullorg.apache.carbondata.spark.testsuite.bigdecimal.TestNullAndEmptyFields.test filter query on column is not null

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2486/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2487/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/371/Failed Tests: 1carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test: 1org.apache.carbondata.spark.testsuite.bigdecimal.TestDimensionWithDecimalDataType.test unsafe with bigdecimal

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/372/Failed Tests: 1carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test: 1org.apache.carbondata.spark.testsuite.bigdecimal.TestDimensionWithDecimalDataType.test unsafe with bigdecimal

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2491/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2494/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/387/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/390/Failed Tests: 8carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test: 8org.apache.carbondata.spark.testsuite.allqueries.InsertIntoCarbonTableTestCase.insert into carbon table from carbon table union queryorg.apache.carbondata.spark.testsuite.dataload.TestLoadDataWithHiveSyntaxDefaultFormat.test data loading and validate query outputorg.apache.carbondata.spark.testsuite.dataload.TestLoadDataWithHiveSyntaxUnsafe.test data loading and validate query outputorg.apache.carbondata.spark.testsuite.dataload.TestLoadDataWithHiveSyntaxV1Format.test data loading and validate query outputorg.apache.carbondata.spark.testsuite.dataload.TestLoadDataWithHiveSyntaxV2Format.test data loading and validate query outputorg.apache.carbondata.spark.testsuite.partition.TestDataLoadingForPartitionTable.data loading for partition table: range partitionorg.apache.carbondata.spark.testsuite.partition.TestDataLoadingForPartitionTable.Insert into for partition table: range partitionorg.apache.carbondata.spark.testsuite.partition.TestQueryForPartitionTable.detail query on partition table: range partition

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2509/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2521/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/406/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2526/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/414/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/415/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2528/

retest this please

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2546/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/438/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2551/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/443/Failed Tests: 2carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test: 2org.apache.carbondata.spark.testsuite.dataload.TestBatchSortDataLoad.test batch sort load by passing option and compactionorg.apache.carbondata.spark.testsuite.dataload.TestBatchSortDataLoad.test batch sort load by passing option in one load and with out option in other load and then do compaction

retest this please

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2558/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/450/Failed Tests: 1carbondata-pr-spark-1.6/org.apache.carbondata:carbondata-spark-common-test: 1org.apache.carbondata.spark.testsuite.allqueries.InsertIntoCarbonTableTestCase.insert into carbon table from carbon table union query

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/2574/

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/carbondata-pr-spark-1.6/468/

LGTM


Docker-In-Docker during the build process (Java / TestContainer)

Hi,
Thx for this repository action.
I'm wondering how you can use a Docker build approach when you need to embed Docker during the build process. For example, if we want to use TestContainer for a Java application. You can't because you can mount a file during a build process (/var/run/docker.sock)
Best,
Mickael

Bonjour


Add function for creating unmodifiable typed data

In https://github.com/flutter/engine/pull/35468 it became apparent that having a way to create unmodifiable views directly from the Dart API would be ideal (the name Dart_NewUnmodifiableTypedData  was suggested).  This would allow sharing of unmodifiable views across isolates in the same group and it's also a more convenient interface.

Adding a new parameter bool unmodifiable to the existing API functions Dart_NewTypedData and Dart_NewExternalTypedData should suffice ?

Adding a new parameter bool unmodifiable to the existing API functions Dart_NewTypedData and Dart_NewExternalTypedData should suffice ?

I wouldn't recommend it since if the API is C it would require casting a const buffer to use it.

Looks like @rmacnak-google already has a CL for this https://dart-review.googlesource.com/c/sdk/+/255816


Publish example bundles on push

Publish example bundles on push
When changes are pushed to the main branch, publish any bundles that have changed. If that bundle is already published, don't overwrite it.
Standardize example bundle names
Publish all bundles to ghcr.io/getporter/examples so that it's easier to filter the example bundles. Each bundle should be named examples/NAME, and ideally the bundle directory should match the bundle name.
Remove service fabric example
The example for service fabric doesn't demonstrate any new or unique
techniques.
Assign new issues and PRs to our project board
I realized that I missed this action when copying things over from the Porter repository. I figured I'd add it while I'm mucking with all our github actions / repo setup.
Here are all the packages that I pushed while testing this out. Once we merge it should build the bundles but only push ones with an updated version when changed. https://github.com/orgs/getporter/packages?repo_name=examples

Yay! Worked just like I had hoped
Skipping publish for example bundle: plugins-tutorial. The bundle is already published to ghcr.io/getporter/examples/plugins-tutorial:v0.2.0.

==========================
Skipping publish for example bundle: private-assets. The bundle is already published to ghcr.io/getporter/examples/private-assets:v0.1.0.


Add an MIT license file

In the spirit of open-source, add a file named LICENSE to the root directory. It should contain the MIT license text with "2015 Justin J Stark".

If you've never done a pull-request before, this is a good one. Feel free to make a comment if you need any help or have any questions. I'm a nice guy, I promise. :smile:
I'll leave this one open for a few weeks. If I don't have a pull request by then I'll add the license myself in preparation for a first stable release.
http://www.firsttimersonly.com/


Ability to use extractionFns in any filter

It would be great to have the ability to express a filter on a dimension with and extractionFn.
Problem
It is currently not easy to express:
LOOKUP(`some_id`, 'some_lookup') REGEXP "^lol"

As a Druid filter. See this issues: https://github.com/implydata/pivot/issues/119
Note: this is technically possible with the newly added Cascade extractionsFn by using a javascript extractionFn, and the extraction filter like so: Cascade(lookup(some_lookup), javascript(d.match(/^lol/))) == "true" but that is cumbersome and while Plywood could be programmed to do it users using the Druid API directly will have a hard time working that one out.
Sugested solution
Every filter that takes a dimension should be able to also take an extraction function also. I.e. the filter dimension would become a DimensionSpec
So:
{
  "type": "regex",
  "dimension": "city",
  "pattern": "^lol"
}

Would be equivalent to:
{
  "type": "regex",
  "dimension": {
    "type": "default",
    "dimension": "city"
  },
  "pattern": "^lol"
}

But would could also write:
{
  "type": "regex",
  "dimension": {
    "type": "extraction",
    "extractionFn": {
        "type": "lookup",
        "lookup": ...
     }
  },
  "pattern": "^lol"
}

This would apply to all filters.
Note that this change will make the extraction filter redundant as you could simply write:
{
  "type": "selector",
  "dimension": {
    "type": "extraction",
    "extractionFn": ...
  },
  "value": "blah"
}

BTW this might be related to: https://github.com/druid-io/druid/issues/2604


Add field position selector

For far blue, middle red, etc.

But why? 2017 is over

We can use it next year.

Yeah but it may not be as clear cut as far blue, middle red, etc

I will leave this up to this year's maintainers to decide how to implement this. A very simple implementation can be found in the branch position-selector.


post_recipients() does not support errors in response

The errors has been added in official docs. This should be supported in sendgrid4r.
https://sendgrid.com/docs/API_Reference/Web_API_v3/Marketing_Campaigns/contactdb.html#Add-Recipients-POST

The errors has been supported.
https://github.com/awwa/sendgrid4r/wiki/Contacts-Recipients#post_recipients


lowered speeds

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Associated Issue(s)
Issue: #96
Steps to Test

Shoot at low range

Changelog
Lowered speeds
What?
Lowered speeds
Why?
So we don't launch the ball out of the arena

no changes


Moved template status updates to webhooks

This seems to work for non-privileged users.
@Someone0nEarth I need your help on this issue for testing. I've lost my ability to test on a Vivoactive3 watch. Please can you verify this on yours?
This is a bug fix update.

Hey @philipabbey, I can test this bugfix. There is a small chance I can do it tonight, but more likely it will be on Monday.

Thank you!


BE-19 Create route backend /api/artworks/id/[id].js to get artworks by id

 BE-19 Crear ruta backend /api/artworks/id/[id].js para obtener artworks por id