Meet AA contrast requirements

I'm combining all of our open issues around contrast into one. Our goal is AA, not AAA.
Buttons:

[ ] Primary #7103
[ ] Secondary #7104
[ ] Success #7376
[ ] Alert #7377
[ ] Warning #7378
[x] Disabled #7379

Disabled is an open question, as according to the W3C's guidelines, contrast requirements are not necessary for disabled elements.
If any other components don't meet AA requirements, let's add them here also.

@gakimball the difference between disabled and aria-disabled should be, that not all elements support disabled according to HTML standard and that disabled actually disables the element, while aria-disabled just indicates a disabled UI component to AT. This means, buttons would go with the disabled attribute, and a would need to use aria-disabled or .disabled. I feel like we should include all three ways in the CSS selector, and then recommend disabled for button and input in the docs.

Another place with too low ratio is the title of Off-canvas list titles: http://webaim.org/resources/contrastchecker/?fcolor=8a8a8a&bcolor=2c2c2c

Also of too low ratio:

regular $primary-color links
links in callouts
header small
.tabs-title (especially .is-active)
blockquotes
.subheader

I'm not sure about the requirements for progress bars. It's not text on a background, but the ratio is too low.

@Owlbertz is right. Disabled elements don't need to meet WCAG criteria. We can skip that one.

I think if we check colors with backgrounds and foregrounds, we can fix all possible issues:
$primary-color: #2199e8;
$secondary-color: #777;
$success-color: #3adb76;
$warning-color: #ffae00;
$alert-color: #ec5840;
$light-gray: #e6e6e6;
$medium-gray: #cacaca;
$dark-gray: #8a8a8a;
$black: #0a0a0a;
$white: #fefefe;
$body-background: $white;
$body-font-color: $black;

I've taken a stab here:
https://github.com/zurb/foundation-sites/pull/7603
If anyone wants to make a pass and see if they cvan bring some of the vibrance back it would be appreciated. @davefuentes @andycochran @Owlbertz @gakimball

Can you provide a screenshot between old colors and the new ones you proposed?

Trying to tackle this one. It's tricky.
Here's the slightest change to the existing palette that would meet AA contrast requirements… if the warning button used $button-color-alt for its text:
$foundation-palette: (
  primary: #1a7cbd,
  secondary: #767676,
  success: #238748,
  warning: #ffae00,
  alert: #cc4b37,
);

The problem is, @function foreground() uses lightness() to determine if the light or dark text color should be used. This article, which explains how lightness() fails at calculating contrast, recommends using a luminance based method — something like this — to calculate contrast ratios.
It's also worth noting that $button-color and $button-color-alt must be set to light and dark values respectively for foreground() to work. The description of $button-color-alt even says, "Font color for buttons, if the background is light," which makes the assumption that buttons are by default dark. Perhaps $button-color-light and $button-color-dark would be more semantic?
Any thoughts before I reeeeally complicate the foreground() function?
/cc @brettsmason @JeremyEnglert @ncoden @rafibomb

@andycochran hum... Nothing to say, we should use the function of the article instead of lightness ().
$button-color-{light, dark} would refer to light/dark color or color for light/dark button ?

Good point, @ncoden; $button-color-light could be misunderstood. Might the default vars be enough context?
$button-color-light: $white;
$button-color-dark: $black;

^ That PR probably isn't quite ready. I'd appreciate any feedback.

@ncoden So, I didn't even use two variables for button colors. We only define one explicit button background color. So we only need to define one button font color. That button's font color can either be set to a specific color or to this function pick-best-color($button-background), which defaults to choosing from $black or $white:
pick-best-color($base: $background, $colors: ($white, $black))

…but it can also accept custom vars:
pick-best-color($tab-background, ($primary-color, $white))

As I'm explaining this, rubber duck is telling me I should amend my PR by keeping $button-color and $button-color-alt in settings and have pick-best-color() default to those instead of putting the function in settings. That way, you'll be able to choose font colors for the buttons generated by $foundation-palette().

Okay, lots of updates on the #9319 PR. Check 'em out.

Closing this as #9319 will give v6.3 accessible colors! Woot.

Also of too low ratio:
* `header small`

* `.tabs-title` **(especially `.is-active`)**

* blockquotes

* `.subheader`

The default colors for these still fall below WCAG AA requirements. Except for .tab-title.is-active, the culprit is the default $dark-gray. It is too light on the default background color ($white: #fefefe)

@theschmocker it's probably worth opening a separate issue for this as this particular ticket is pretty old.

Drives me nuts that header>small has an explicit color. All my apps override this.


WIP: Preserve DataFrame divisions when reading from parquet using pyarrow

WIP towards #3383.
I updated a bunch of tests in test_parquet.py to check the read_parquet dask DataFrame against the expected dask DataFrame, rather than the expected pandas DataFrame. I only check_divisions when the reader is fastparquet or pyarrow >= '0.9.0'.  This has the added benefit of checking the read_parquet divisions logic for the fastparquet path, which I don't think was really verified previously.
I added a bit of logic to _read_pyarrow to use pyarrow's column metadata stats to compute the min/max of each row group and the use these pairs to build the divisions. It's rough, but it works in many cases.
I ran into a handful of tangentially related issues during a couple of hours of working through the failing tests.  I'm not sure if I'll be able to see this through the the finish, but I wanted to at least share my progress.
@jcrist Is this division calculation logic the kind of approach you had in mind in #3383?
@mrocklin Does this division calculation logic give you pause performance-wise?

[ ] Tests added / passed
[ ] Passes flake8 dask
[ ] Fully documented, including docs/source/changelog.rst for all changes
and one of the docs/source/*-api.rst files for new API

A couple of notes on the "tangentially related issues" I mentioned above.

test_read_glob: In order to get this to pass for pyarrow reader I added the non_empty_pieces logic in _read_pyarrow (See here). This was needed because the _common_metadata file shows up in the dataset.pieces list, but this shouldn't be a valid partition for the DataFrame.
test_empty: The change above results in a failure for the pyarrow-pyarrow cases. This is because my logic added above results in no non-empty pieces, which now sends us down the no-partitions path here. I think this is appropriate, but there seems to be an issue with the dtypes = _get_pyarrow_dtypes(schema, categories) logic above. When the empty DataFrame is both written and read using pyarrow the dtype for the a column/index is incorrectly determined to be float64 rather than object (which is the correct dtype).  Interestingly, this isn't a problem when the file is written using fastparquet, so perhaps there is an error in the pyarrow writing logic for empty DataFrames.
test_columns_index_with_multi_index: This fails because the min/max statistics in the column metadata seems to be less than full precision. E.g. when the underlying DataFrame has a min of -0.67432957233535817 the min statistic is -0.67433

There are also failures in test_read_parquet_custom_columns and test_timestamp_index, test_partition_on, test_columns_name, and a few others I haven't looked into.

Does this division calculation logic give you pause performance-wise?

It's not the logic of calculating the divisions, it's the possibility that we would need to read data from many files on a remote store, and that this might take up a significant amount of time.  If PyArrow isn't writing a metadata file then my understanding is that we'll have to read a bit of data from each of the parquet files in the dataset, which in practice gets into the thousands (or so I believe).  What is the cost for each remote access in this case?  I would not be surprised to learn that it was in the hundreds of milliseconds, which means that the read_parquet call might take a few minutes just to read metadata.  So some questions I would have here:

Is the hundreds of milliseconds estimate accurate?  Lower?  Higher?
Is it possible for PyArrow to write the metadata file, or are there reasons against this?
Can we bail out early if we find that the min/max values aren't well formed for dask divisions
Should we make this optional, defaulting to off?

For the arrow and divisions logic we might also ping @xhochy here in case he has time.

I won't have time to fully review this until tomorrow, but I just want to respond to:

It's not the logic of calculating the divisions, it's the possibility that we would need to read data from many files on a remote store, and that this might take up a significant amount of time.

Currently when reading parquet with pyarrow, the schema is grabbed from every file. This could be turned off by passing validate_schema=False to ParquetDataset, but there are (or at least were) some issues with constructing that way (bug in arrow that I never filed :( ). This hasn't shown to be a bottleneck for at least my workflows, but may be for a large number of files (we're in the ~500 file range).
The statistics information is also available at known byte offsets in the files, and so may also be efficiently read in for filesystems that support efficient random access (hdfs, local, not sure about others). A single metadata file would certainly be more efficient (https://issues.apache.org/jira/browse/ARROW-1983) but I'm not sure if pulling the stats from every file would be bad enough to warrant an api change. Benchmarking needed.

Does anyone know the rationale for not writing metadata files? Is it a problem of a blocking finalizer task following parallel writing? For example, spark used to, but no longer does by default.

Another observation:
test_read_parquet_custom_columns fails because pyarrow returns the pieces property of the ParquetDataset is sorted lexicographically by filename, not by part number.
Here's an example from inside test_read_parquet_custom_columns.
Notice the ordering of the parts (0, 1, 10, 11, 12, ..., 18, 19, 2, 3, 4, ..., 8, 9)
dataset.pieces
Out[3]:
[ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.0.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.1.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.10.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.11.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.12.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.13.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.14.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.15.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.16.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.17.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.18.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.19.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.2.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.3.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.4.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.5.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.6.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.7.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.8.parquet', row_group=None, partition_keys=[]),
 ParquetDatasetPiece('/private/.../test_read_parquet_custom_colum1/part.9.parquet', row_group=None, partition_keys=[])]

This seems unintuitive to me. Is this the expected behavior? If so, determining divisions accuratley will involve sorting the partitions by their min value and then checking to make sure the max values don't overlap with the next min.
But, even apart from the divisions issue, the fact that pyarrow doesn't return pieces ordered by part number suggests that the order of the partitions in the resulting dask dataframe won't necessarily match the order in which they were written.

After poking around at the parquet datasets created by fastparquet, it looks like fastparquet creates the _metadata file in the output directory and that this file contains the order of the pieces/parts.
I also tried using the fastparquet engine to read a dataset created by the pyarrow engine but this errors out because it looks like fastparquet won't treat a directory as a parquet dataset unless it has a _metadata file in it.

Does anyone know the rationale for not writing metadata files? Is it a problem of a blocking finalizer task following parallel writing? For example, spark used to, but no longer does by default.

If your Parquet dataset is not the result from a single job but will get appended on e.g. a daily basis updating the _metadata file must be done by a central instance. This is often possible but not simple.
But the actual lack of writing _metadata in pyarrow is due to nobody having implemented it yet. An implementation would be welcome and probably a reasonable performance boost in many cases. Accessing every file in a dataset is really expensive when you have a large dataset. I think we already do this in the PyArrow class ParquetDataset and it would be probably one of the first things I would remove once I do some performance tuning on that path.

@xhochy Thanks for your feedback.  If you can spare another moment, do you any perspective/guidance on the following remaining issues?

min/max statistics in the column metadata seems to be less than full precision. E.g. when the underlying DataFrame has a min of -0.67432957233535817 the min statistic is -0.67433
Pieces property of the ParquetDataset is sorted lexicographically by filename, not by part number. In this PR a resorted the pieces using a 'natural' sort so that the parts are ordered by part number. Is this a reasonable thing to do in general?

Test failure notes:
test_columns_name fails with a SIGSEGV on the third line of
pf = piece.get_metadata(pq.ParquetFile)
rg = pf.row_group(0)
col_meta = rg.column(divisions_col_index)  # SIGSEGV here

At this point divisions_col_index is 0 and the row group looks like this.
rg
Out[2]:
<pyarrow._parquet.RowGroupMetaData object at 0x1158c45a0>
  num_columns: 2
  num_rows: 2
  total_byte_size: 88

And the schema looks like this.
pa_schema
Python 3.5.2 |Continuum Analytics, Inc.| (default, Jul  2 2016, 17:52:12)
Type 'copyright', 'credits' or 'license' for more information
IPython 6.1.0 -- An enhanced Interactive Python. Type '?' for help.
PyDev console: using IPython 6.1.0
Out[1]:
idx: string
A: int64
metadata
--------
{b'pandas': b'{"columns": [{"metadata": null, "name": "idx", "numpy_type": "ob'
            b'ject", "pandas_type": "empty"}, {"metadata": null, "name": "A", '
            b'"numpy_type": "int64", "pandas_type": "int64"}], "index_columns"'
            b': ["idx"], "pandas_version": "0.23.0.dev0+208.g35812ea"}'}

And, interestingly, calling rg.column(1) (rather than 0) returns fine.

I made a few more changes and now there are only 2 failing tests cases, summarized below.

test_columns_index_with_multi fails due to the apparent truncation of the min field in the RowGroupStatistics object. See here:

https://github.com/jmmease/dask/blob/efab4d3648bec7a4e46e3ff48dd1de50c9218e70/dask/dataframe/io/parquet.py#L684-L687

test_empty: When an empty DataFrame with a string datatype column is both written and read by pyarrow, the datatype of the column on read is null which is converted to numpy.float64 by the field.type.to_pandas_dtype() method.

I think this is as far as I can take this without some help from the pyarrow side.  Anyone available/willing to take a look?
@mrocklin @jcrist @xhochy

test_columns_index_with_multi fails due to the apparent truncation of the min field in the RowGroupStatistics object.

I guess not only is min truncated but max is probably then also truncated?

test_empty: When an empty DataFrame with a string datatype column is both written and read by pyarrow, the datatype of the column on read is null which is converted to numpy.float64 by the field.type.to_pandas_dtype() method.

This is the expected behaviour as an empty string column in Pandas is simply an empty column of type object. Sadly object does not tell us much about the type of the column at all. We return numpy.float64 in this case as it's the most efficient type to store nulls in Pandas.

The code looks good. I'm worried a bit that it might be costly due to a lot of I/O.

This is the expected behaviour as an empty string column in Pandas is simply an empty column of type object. Sadly object does not tell us much about the type of the column at all. We return numpy.float64 in this case as it's the most efficient type to store nulls in Pandas.

This seems unintuitive at best to me. An empty object column in pandas is treated differently in many operations than an empty float64 column (str accessor is available, excluded from numeric operations, etc..). Having an empty file read in as a different dtype than was written could lead to errors in processing code downstream. Would arrow be willing to change this behavior?

I'm worried a bit that it might be costly due to a lot of I/O.

Upon further thought, I am too. I think we should provide a kwarg to turn this behavior on/off. Proposed semantics:
    """
    ...
    infer_divisions : bool or None (default).
        By default divisions are inferred only if a global `_metadata` file
        is found for the dataset. Set to ``True`` to force divisions to be
        inferred in all cases. Note that without a `_metadata` file, this
        requires reading metadata from each file in the dataset, which may be
        expensive. Set to ``False`` to never infer divisions.
    """

This is the expected behaviour as an empty string column in Pandas is simply an empty column of type object. Sadly object does not tell us much about the type of the column at all. We return numpy.float64 in this case as it's the most efficient type to store nulls in Pandas.

This seems unintuitive at best to me. An empty object column in pandas is treated differently in many operations than an empty float64 column (str accessor is available, excluded from numeric operations, etc..). Having an empty file read in as a different dtype than was written could lead to errors in processing code downstream. Would arrow be willing to change this behavior?

We should probably use another method than field.type.to_pandas_dtype() in this case. The column saved in Parquet should be saved with NA as type which sadly does not provide enough information.
We also store the original dtype in the Pandas metadata that is used for the actual DataFrame reconstruction later on. If we would also pick up the metadata when it was written, we should be able to correctly reconstruct the dtype.

https://issues.apache.org/jira/browse/ARROW-2444

Thanks for the feedback @xhochy , I'll switch to looking directly at the pandas metadata. If I recall correctly this did have the object datatype

test_columns_index_with_multi fails due to the apparent truncation of the min field in the RowGroupStatistics object.

I guess not only is min truncated but max is probably then also truncated?

That's correct, max is truncated as well.
@jcrist The option you describes sounds reasonable. So setting this to False would disable the division calculation logic for fastparquet as well?
I'll take a stab at updating the pyarrow dtype logic to look at the pandas metadata, and adding the infer_divisions kwarg.
Assuming this doesn't uncover any other fundamental issues, I think the last remaining blocker is the min/max truncation.
If we knew how this truncation works, we might be able to add a little padding to each division to account for it. But I fear this could also produce unexpected results in cases where the truncation isn't neccessary. Thoughts?

If I recall correctly, it looked like fastparquet requires a _metadata file in order to treat a directory of parquet files as a dataset. Please correct me if I'm wrong @martindurant
So raising a NotImplementedError does make sense in this case.

fastparquet requires a _metadata file or a list of data-files - it will not glob/walk the directory tree to look for parquet-like files for you. There is also a convenience function to make a _metadata file out of a set of data-files, so that reading their individual footers need only happen once.

Ok, I think this might be just about good to go (we'll see how the CI tests fair). @jcrist @xhochy @mrocklin
Summary of updates

I now use the numpy_dtype from the pandas metadata if available and fallback to the pyarrow schema to_pandas_dtype otherwise.

I added an infer_divisions kwarg to read_parquet. I altered the semantics and description slightly from @jcrist 's suggestion.

infer_divisions : bool or None (default).
        By default, divisions are inferred if the read `engine` supports
        doing so efficiently and the `index` of the underlying dataset is
        sorted across the individual parquet files. Set to ``True`` to
        force divisions to be inferred in all cases. Note that this may
        require reading metadata from each file in the dataset, which may
        be expensive. Set to ``False`` to never infer divisions.

With this change,

infer_divisions of None (default) should match the legacy behavior for both read engines (infer for fastparquet when possible and never infer for pyarrow)
infer_divisions of False means that neither engine will infer divisions
infer_divisions of True means that both engines will attempt to infer divisions and will raise an exception if this is not possible (if the index can't be identified, if the column is not sorted across parts, or if the engine version doesn't support it). This will continue to be inexpensive for fastparquet, and it will be potentially expensive for pyarrow.

I added/updated tests for infer_divisions so that they should work for pyarrow 0.8 and 0.9.0.

I updated the changelog

Note: We're no longer hitting the min/max truncation error in the tests because the divisions are not being inferred by default. So I don't think that's a blocker any more, but someone may want to investigate this further on the pyarrow side.

friendly ping @mrocklin @jcrist

Thanks for the comments and for helping me make this better @jcrist I believe I've incorporated all of your suggestions.

Looks like you have failures on python 2.

Great!  Thanks for all your help on this @jcrist @mrocklin @xhochy


IOS Teams app stopped displaying image | Teams Bot | Mobile Teams app

Hi Team,
I have create a Bot using Botframework v3 and using the Bot in Teams channel.
Bot is working when using the Teams in Windows/PC.
While when I use it in mobile app(IOS) the images which are present in QnA Answer are not getting displayed.
Images I have saved in azure storage(BLOB) with anonymous read.
IOS teams version : 1.0.78
Please help me for this.
Regards
Subham Awasthi

@subhamawasthi Are you able to debug the bot using ngrok? I'm curious to know if when using the teams mobile app on iOS if you are getting any exceptions. Also; do images that don't come from QnA answers (but from the bot) work in the iOS app?

Closing due to no action. Please reopen if the issue persists and you still need assistance.


DeviantArt ripper does not download entire gallery

Ripme version: 1.7.83
Java version: 1.8.0_201
Operating system: 6.1.7601
Exact URL you were trying to rip when the problem occurred: https://www.deviantart.com/heavenhellexe/gallery/?catpath=/ (Warning: NSFW)
Please include any additional information about how to reproduce the problem:

Expected Behavior
The full gallery of the user gets ripped.
Actual Behavior

Oh, also can anyone explain what this error message is saying? It had no problem like this before.

Oh, also can anyone explain what this error message is saying?

A unsupported url was passed to ripme.

It had no problem like this before.

The DA ripper was recently rewritten to work around the DA api being terrible and useless

So what if I want to rip the primary gallery? What should I do? This thing
is making me confused.
On Thu, May 9, 2019, 5:23 AM cyian-1756<EMAIL_ADDRESS>wrote:

Oh, also can anyone explain what this error message is saying?
A unsupported url was passed to ripme.
It had no problem like this before.
The DA ripper was recently rewritten to work around the DA api being
terrible and useless
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/RipMeApp/ripme/issues/1303#issuecomment-490637058,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC2JFICANEZKL2ZNG75S3MTPUMZENANCNFSM4HLKURAQ
.

I'll look into fixing the ripper so it takes all url formats this weekend

Does this cover PDF downloads at all or just the image frame?

Also having issues, using latest Java and on Windows 10.
I'm almost positive it's because of the awful way they've got their site set up now. Noticed that the pics that were downloaded when I tested were older, before this year.

I will take a look into it as well.

@cyian-1756 can you change the DeviantartRipper in line 622 to
Http.url(parts[0]).connection().ignoreContentType(true).execute().statusCode() == 404
that should fix at least the download for now but that part will need some work.
Once I am more familiar with Github I will create a new pull request with more commentary on my code :smile:

So what if I want to rip the primary gallery? What should I do? This thing is making me confused. The main gallery doesn't have the numbers (IDs, presumably) so if it's expecting the ID I cannot provide it. Example: https://www.deviantart.com/max-dunbar/gallery/  As you can see, no IDs or folder to be seen, thus I cannot provide the URL in the format the ripper is expecting.

https://www.deviantart.com/max-dunbar/gallery/ should be working fine. I cannot see a reason why it should not. I agree the error message is clearly misleading. Sorry for that.
and the scoutdoodles URL in your image... I am confused why it errors but will look into it.


Removed double dashes from enable option on line 58

@rhoads-zach
The enable command, similar to apply, doesn't requite the --. Using the double dashes causes an error.

Can one of the admins verify this patch?

nice catch @huntley. LGTM

Thank @huntley  for the fix.


Casks fail to install

I'm getting repeated variations of issue #16475 not just with java but other packages too
ex:
failed: [venus] => (item=firefox) => {"failed": true, "item": "firefox"}
msg: Error: Permission denied - (/Library/Caches/Homebrew/firefox-43.0.4.dmg, /Library/Caches/Homebrew/Casks/firefox-43.0.4.dmg)
  Most likely, this means you have an outdated version of homebrew-cask. Please run:

      brew uninstall --force brew-cask; brew untap phinze/cask; brew update; brew cleanup; brew cask cleanup

  If this doesn’t fix the problem, please report this bug:

      https://github.com/caskroom/homebrew-cask#reporting-bugs

/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:349:in `symlink'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:349:in `block in ln_s'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:1568:in `fu_each_src_dest0'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:347:in `ln_s'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/fileutils.rb:370:in `ln_sf'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/download.rb:45:in `create_cache_symlink'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/download.rb:15:in `perform'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/installer.rb:94:in `download'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/installer.rb:68:in `install'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli/install.rb:20:in `block in install_casks'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli/install.rb:17:in `each'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli/install.rb:17:in `install_casks'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli/install.rb:6:in `run'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli.rb:78:in `run_command'
/usr/local/Library/Taps/caskroom/homebrew-cask/lib/hbc/cli.rb:116:in `process'
/usr/local/Library/Taps/caskroom/homebrew-cask/cmd/brew-cask.rb:26:in `<top (required)>'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/usr/local/Library/brew.rb:69:in `require?'
/usr/local/Library/brew.rb:149:in `<main>'

sudo chown -R $USER /Library/Caches/Homebrew/

Is Stackoverflow's suggested fix


More friendly range-error messages for BlockGraphics

Fixed in 16c66e45 (wrongly labelled as #756)

Duplicated by #756


Set up tests on gitlab

A significant update. Several changes:

Most importantly, incorporates @ktsai7 's work to set up continuous integration on a gitlab mirror.
Runs clang-format on the repo and bases clang format on clang-format 12
Revives SpinerEOS tests. Cleans them up significantly to compare against eospac directly rather than hardcoded numbers
Generates spiner tables at test time, rather than storing them as gold files

This has already gone under significant internal review, so if someone could give it a quick ok before we merge in, that would be great.

I gave it a quick look, but I admit I'm probably not one to find serious bugs here. Looks okay to me though.

@Yurlungur Sorry I didn't catch this earlier but there is a typo in the .gitlab-ci.yml

Ah no problem. Thanks for the catch. Merged it.


Suppress tracing for Metrics Export

Currently Spans are being generated when Metric export involves HTTP calls

Thanks for adding a PR so quickly


Update got dependency to avoid deprecation warning

using node 12.9 I get af deprecation warning:
[DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated
Which seems to be related to an old version of the "got" module.
Could the dependency be updated?

Same issue.
I thinks it is related to timeout in options.
After adding timeout value in options, the warning is occured in my case.

Posted a similar ticket just now. I don;t think streaming is working with the version of got used by download. V11, the latest version handles streams correctly.

@und3rs @pbvahlst Have a look #212


[$250] Start creating optimistic transactionThreadReportID and createdReportActionIDForThread and passing it in HoldRequest

We are about to change some of our backend code to not create the transaction thread reports when we create a new money request.
In order to do that, we need to ensure that on the action IOU.putOnHold, we start creating the data for the transaction thread report and its created action optimistically (if the data does not exist yet), the same way we do it for the requestMoney action and pass the transactionThreadReportID and createdReportActionIDForThread to the API request.
I also see that the API.write call for putOnHold is not using the HOLD_MONEY_REQUEST constant, so let's fix that too.
Issue OwnerCurrent Issue Owner: @allroundexperts
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021869115090392228823
Upwork Job ID:<PHONE_NUMBER>392228823
Last Price Increase: 2024-12-17

Proposal
Please re-state the problem that we are trying to solve in this issue.
Start creating optimistic transactionThreadReportID and createdReportActionIDForThread and passing it in HoldRequest
What is the root cause of that problem?
New Feature - start creating optimistic transactionThread report and created action for the thread when the transaction thread doesn't exist
What changes do you think we should make in order to solve the problem?

First now that we are not guaranteed to always have a transaction thread we will base our navigation on parentReportID and parentReportActionID params
https://github.com/Expensify/App/blob/64eaf2fdd357bd06008adfb9c0c049e09cd375b9/src/ROUTES.ts#L427-L430
getRoute: (type: ValueOf<typeof CONST.POLICY.TYPE>, transactionID: string, parentReportID: string, parentReportActionID: string, backTo: string, searchHash?: number) => {
            const route = searchHash
                ? (`${type}/edit/reason/${transactionID}/${searchHash}/?backTo=${backTo}&parentReportID=${parentReportID}&parentReportActionID=${parentReportActionID}` as const)
                : (`${type}/edit/reason/${transactionID}/?backTo=${backTo}&parentReportID=${parentReportID}&parentReportActionID=${parentReportActionID}` as const);

We should navigate accordingly here
 Navigation.navigate(
            // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
            ROUTES.MONEY_REQUEST_HOLD_REASON.getRoute(
                policy?.type ?? CONST.POLICY.TYPE.PERSONAL,
                transactionID,
                moneyRequestReportID ?? '',
                reportAction.reportActionID,
                backTo || activeRoute,
                searchHash,
            ),

We will update HoldReasonPage here according to the new params
https://github.com/Expensify/App/blob/64eaf2fdd357bd06008adfb9c0c049e09cd375b9/src/pages/iou/HoldReasonPage.tsx#L39-L47
    const {transactionID, parentReportID, parentReportActionID, backTo, searchHash} = route.params;

    const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${parentReportID || -1}`);

    // We first check if the report is part of a policy - if not, then it's a personal request (1:1 request)
    // For personal requests, we need to allow both users to put the request on hold
    const isWorkspaceRequest = ReportUtils.isReportInGroupPolicy(parentReport);
    const parentReportAction = ReportActionsUtils.getReportAction(parentReportID ?? '-1', parentReportActionID ?? '-1');

and then we will pass only the iou parent action from here
https://github.com/Expensify/App/blob/64eaf2fdd357bd06008adfb9c0c049e09cd375b9/src/pages/iou/HoldReasonPage.tsx#L56
        IOU.putOnHold(transactionID, values.comment, parentReportAction, searchHash);

Then inside putOnHold we will create the transaction thread and created action if the transaction thread report doesn't exist
function putOnHold(transactionID: string, comment: string, iouAction?: OnyxEntry<ReportAction>, searchHash?: number) {
    let reportID = iouAction?.childReportID;
    const optimisticData: OnyxUpdate[] = [];
    if (!reportID) {
        const iouReportID = ReportActionsUtils.getOriginalMessage(iouAction)?.IOUReportID ?? 0;
        const iouReport = ReportUtils.getReport(iouReportID);
        const transactionThread = ReportUtils.buildTransactionThread(iouAction, iouReport);
        reportID = transactionThread.reportID;
        const createdActionForTransactionThread = ReportUtils.buildOptimisticCreatedReportAction(currentUserEmail);
        optimisticData.push(
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
                value: transactionThread,
            },
            {
                onyxMethod: Onyx.METHOD.MERGE,
                key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${transactionThread}`,
                value: {
                    [createdActionForTransactionThread.reportActionID]: createdActionForTransactionThread as ReportAction,
                },
            },
        );
    }

and also pass the transaction thread report id and created action id as a param here
https://github.com/Expensify/App/blob/64eaf2fdd357bd06008adfb9c0c049e09cd375b9/src/libs/actions/IOU.ts#L7959-L7964
And on more thing is our areHoldRequirementsMet will be false here for our case
https://github.com/Expensify/App/blob/64eaf2fdd357bd06008adfb9c0c049e09cd375b9/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx#L187-L188
as the calculation depends on the child report of the report action where the context menu is displayed for but in our case there is no transaction thread so we need to determine it only from the report action :
https://github.com/Expensify/App/blob/64eaf2fdd357bd06008adfb9c0c049e09cd375b9/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx#L185

    const isParentActionOfRequest = !isEmptyObject(parentReportAction) && ReportActionsUtils.isTransactionThread(parentReportAction);
    const isMoneyRequestOrReport = isMoneyRequestReport || isSingleTransactionView || isParentActionOfRequest;

What alternative solutions did you explore? (Optional)

@parasharrajat can you review the proposal please?

@parasharrajat have you had a chance to look at the proposal yet? Could you give an ETA for when you can take a look?

Bump @parasharrajat

@parasharrajat hope you're feeling better! Do you need me to reassign this?

@allroundexperts please can you review https://github.com/Expensify/App/issues/52935#issuecomment-2506838441?

Sure. On it now!

@iwiznia Why do we need to create the transaction thread on the IOU.putOnHold action? Shouldn't we create the transaction thread and action optimistically when a money request is created instead?
It seems to me from looking at your proposal @FitseTLT that we won't be creating the transaction thread and the action till the user puts the request on hold. What would happen in the case when the user clicks on the IOU action in the IOU report? What will we do at that point?

It seems to me from looking at your proposal @FitseTLT that we won't be creating the transaction thread and the action till the user puts the request on hold. What would happen in the case when the user clicks on the IOU action in the IOU report? What will we do at that point?

Obviously, OpenReport API will be called to create the transaction thread report.

Obviously, OpenReport API will be called to create the transaction thread report.

Hm... but since the optimistic transaction thread has not been created, how would the OpenReport API create the transaction thread?

Obviously, OpenReport API will be called to create the transaction thread report.

Hm... but since the optimistic transaction thread has not been created, how would the OpenReport API create the transaction thread?

One of the purpose of Open Report is to create the report if it doesn't exist like in the case of reply in thread
https://github.com/Expensify/App/blob/430110857357fe9e65febe0e653433ffdd713e65/src/libs/actions/Report.ts#L1179-L1199

@FitseTLT Are you sure that this will create a transaction thread without any changes?

@FitseTLT Are you sure that this will create a transaction thread without any changes?

I think the fetchReport in report screen here will handle the openReport
https://github.com/Expensify/App/blob/430110857357fe9e65febe0e653433ffdd713e65/src/pages/home/ReportScreen.tsx#L547-L557

But let's wait for @iwiznia response on the plan on how to proceed 👍

Why do we need to create the transaction thread on the IOU.putOnHold action? Shouldn't we create the transaction thread and action optimistically when a money request is created instead?

No, that's what we are trying to change. Most of the times, the transaction thread report will not be used at all, so we are trying to create it only when it is needed instead of proactively creating it when the money request is created.

Reviewing again today!

Okay. I went through @FitseTLT's proposal in more detail today again. My only concern was on how we would be creating a transaction thread report if the user clicked on the IOU action. For that case, navigateToAndOpenChildReport function should handle creation of the optimistic thread report and action. If it does not, we can modify it to handle that case. I think we can handle that in the PR, and the proposal seems clear enough to me for starting this.
@FitseTLT's proposal LGTM!
🎀 👀 🎀 C+ reviewed

First now that we are not guaranteed to always have a transaction thread we will base our navigation on parentReportID and parentReportActionID params

Not sure I get why we need this. Can't we generate the URL with the optimistic reportID that will be created when you open it?


refactor: handle binary sensors updates in the coordinator

Proposed change

Handle binary sensor update in the coordinator.
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests
[ ] Documentation update
[ ] Adds a new shipper
[ ] Update existing shipper

Additional information

This PR is related to issue: #996

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 61.11111% with 14 lines in your changes missing coverage. Please review.

Project coverage is 93.25%. Comparing base (8608d22) to head (f40b367).
Report is 43 commits behind head on dev.

Files with missing lines
Patch %
Lines

custom_components/mail_and_packages/__init__.py
61.11%
14 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1003      +/-   ##
==========================================
- Coverage   95.07%   93.25%   -1.82%
==========================================
  Files           8        8
  Lines        1482     1616     +134
==========================================
+ Hits         1409     1507      +98
- Misses         73      109      +36

Files with missing lines
Coverage Δ

...stom_components/mail_and_packages/binary_sensor.py
100.00% <ø> (+2.81%)
:arrow_up:

custom_components/mail_and_packages/__init__.py
85.07% <61.11%> (-7.04%)
:arrow_down:

... and 3 files with indirect coverage changes


Add music and more sfx

This is the audio PR plus implementation of menu music and sound effects for each skill.

Should this all be documented as well? Is there a section in the docs specifically for Neuro/WebSockets features? Should there be? Should it be in this repo or the Neuro one? :thinking:

There is no place to document those things, essentially by design. I don't want Ranvier to require Neuro to be useful and vice versa. I think if they were documented it should be within the README of Neuro and not in the official Ranvier docs for the reason that Ranvier doesn't actually care what features Neuro has since all that stuff is within bundles and we don't document specific bundle features.


Nonbreaking space ({nbsp}) not rendered correctly in Quick Start titles in HCC UI

For the Managed Application Services docs, I recently updated the org-name attribute to include a non-breaking space:
:org-name: Red{nbsp}Hat
The output from the asciidoctor command generated a HTML file where the text was rendered as expected. However, the titles of the docs in the Hybrid Cloud Console UI did not render the nbsp correctly -- they showed the text Red Hat instead. The text seems to be rendered correctly in the body text in the HCC UI, it is just the titles that show the problem.
Any idea what we need to do to fix this formatting output, please?

I think the formatting for this would be: :org-name: Red&nbspHat
If this doesn't work, feel free to reach out to @dlabaj

Thanks @jessiehuff I'll try that. Note however that the Red{nbsp}Hat notation is rendered correctly in the body text currently, it's only in the title text that the attribute is changed to Red Hat instead of inserting the nonbreaking space. Is it expected that we should be able to use the same attribute value in both the title and body text?

@bredamc  Do you have the example of where it's not working.

Hi @dlabaj , I reverted my change again because it was broken in the UI. I'm planning to try your suggestion in a test document, but a colleague is due to release from the same repo this week, so I'm waiting until after that release, to avoid merge conflicts or any other problems that might interfere with the release schedule.

@dlabaj Here are the steps, if you want to reproduce in an AsciiDoc file:

Define the org-name attribute as follows:
:org-name: Red{nbsp}Hat

Replace the text "Red Hat" with the {org-name} attribute in another attribute:
:product-long-api-designer: {org-name} OpenShift API Designer

Use the {product-long-api-designer} attribute in a title and in the body text of a quick start.

View the quick start in the UI.

A colleague mentioned that he uses {nbsp} in adoc and   in XML. The {nbsp} notation worked in the AsciiDoc body text, but not in the title, so I think it might be the PatternFly side that needs tweaking, not the AsciiDoc?

@bredamc Are you ding this only in AsciiDoc or Markdown as well?

AsciiDoc only

ah okay do you have a link to the document that's giving you a problem

@dlabaj As mentioned above, I reverted my change again because the title was broken in the UI. It's difficult for me to test in a test doc because the problem was only visible after the doc was published. I provided the reproducer steps above -- not sure if you can reproduce the problem and test the fix in your team without publishing?

@jschuler I can't see how to reopen this issue, but I just confirmed that it still exists. Can you please reopen it for me? Thanks :)

Reopening since the issue still presents itself
https://qaprodauth.console.redhat.com/application-services/learning-resources

Thanks for reopening, J! As you can see in the screenshots, the problem is in the titles only -- the {nbsp} is rendered correctly in the body text.

@jschuler Thank you for confirming that the problem is fixed in V2.3.3, and that the UI has not yet been updated to use that version. You can close this ticket again -- thanks again for all your help!


Add CandyGuard program from IDL, Update CandyMachine IDL generated code

Problem
Generated code for CandyMachines was lacking certain crucial aspects, as well as having some incorrect implementations.
Solution
Added IDL generated CandyGuard code, as well as updating CandyMachine generated code to use the latest IDL.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 9 (0.0%)  changed or added relevant lines in 1 file are covered.
251 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.6%) to 5.183%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

Solana.Unity.Metaplex/Utilities/PDALookup.cs
0
9
0.0%

Files with Coverage Reduction
New Missed Lines
%

Solana.Unity.Metaplex/CandyMachine Program/Accounts/CandyMachineAccounts.cs
11
0%

Solana.Unity.Metaplex/CandyMachine Program/CandyMachineClient.cs
14
0%

Solana.Unity.Metaplex/Metadata Program/Types/MetadataTypes.cs
18
69.57%

Solana.Unity.Metaplex/CandyMachine Program/Types/CandyMachineTypes.cs
78
0%

Solana.Unity.Metaplex/CandyMachine Program/CandyMachineprogram.cs
130
0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.6%

Covered Lines:
369

Relevant Lines:
7325

💛  - Coveralls

LGTM!


Add util/fpga/bitstream_bisect.py

This tool enables us to bisect over cached bitstreams, and optionally narrow down ambiguous results in a second phase.
Proposal: https://github.com/lowRISC/opentitan/issues/16406
This implementation pulls in the existing bitstream cache Python library and defers to git bisect run as much as possible. The meat is mostly code to parse Git's output and tests.
This PR does not address @luismarques's suggestion for detecting flakiness. However, the caller can effectively do this by baking the canary command into the "fast" and "slow" commands.

I'm not sure this is as portable as I'd like it. Could we check this out on one directory and run it on a different directory? Or will it only help bisecting subsequent commits?

I'm not sure this is as portable as I'd like it. Could we check this out on one directory and run it on a different directory? Or will it only help bisecting subsequent commits?

@drewmacrae The tool expects to be run by Bazel, so it just chdirs into BUILD_WORKSPACE_DIRECTORY. (I can confirm this works nicely with git worktrees.) Why would you want to run it on another directory, is there another workflow you have in mind?
Once you start executing the tool, that's the version that's running. It doesn't matter whether git overwrites its source, so it will happily bisect over commits that predate it.

I can confirm this is the case, I don't know how I missed that comment and didn't mark it as invalid.

Sweet, I think this is ready to merge.


ux: hotline / help

i feel the hotline is not obvious and usable enough to be found by people that do have actual technical problems and are therefore already in a stressed mindset.

language ist an aspect here too and the current placement will prevent many non-en/de-speaking user from finding it effectively, i would expect. (it is now under 'App-informationen' the 6th item in a list of 7)

anecdotal reference: https://www.zeit.de/digital/mobil/2020-06/corona-warn-app-gesundheitsaemter-anfragen-hotline-nutzer-downloads

i propose to put a section on the mainscreen in an appropriate position, probably before or inside the FAQ teaser.

Haben Sie technische Probleme oder Fragen? [individual OS lang i18n]
Do you have technical problems or questions? [english]

[ +49 800 754001 (kostenfrei, free call) ]

in addition i would like to propose a [help icon] next to [share icon] as a persistant access to help/faq/hotline

secondary, i dont quite understand, why the hotline ist restricted to technical issues.

thank you for your work so far, your doing a good job in a good way

This is currently being discussed and we'll get back to you as soon as we have a result.


[Popover, Tooltip] Fix PopoverTrigger and TooltipTrigger prop types

Fix wrong prop types.

[x] I have followed (at least) the PR section of the contributing guide.

It's a great first pull request on Base UI @okmr-d! Thank you for working on it 👌


Change death message.

With the change to the new falling blocks wouldn't it be possible to make your own death message? Instead of "Player was killed by a falling block" you could have "Player was killed by a falling tree" or something of the likes.

Oh right that was the other thing I wanted to do.


Make monolog a optional dependency

A logger should not be a required dependency for a library.

@googlebot I signed it

@jdpedrie Do you think it would make sense to include this in #2302? Moving it out of the require section might break things for projects that haven't required monolog/monolog in their root composer.json, though

Thanks for the PR - Please know I'm definitely not opposed to this in nature, but it would be a breaking change. We've got some other items on the table for a 2.0 release and we'll make sure this is considered as part of those design decisions.


Unable to put wait totake scrrenshot for lazyloaded webpages

im trying to take a screenshot for lazyloaded page, inorder to achieve that i am calculating the length of the page, scrolling till the length and then had to put wait time before taking the screenshot .
But it is not working

thanks a lot brother @NimaSoroush


Xcode build error: Could not build module 'WebKit'

[x] I have read the Getting Started section
[x] I have already searched for the same problem

Environment

Technology
Version

Flutter version
3.13.9

Plugin version
6.0.0-beta.26

Android version
34.0.0

iOS version
17.0

macOS version
14.1.1

Xcode version
15.0.1(15A507)

Device information:
Apple iPhone 15 Pro Max
Description
Expected behavior:
Xcode build done.
Current behavior:
Failed to build iOS app
Could not build the precompiled application for the device.
Error (Xcode): type argument 'nw_proxy_config_t' (aka 'struct nw_proxy_config *') is neither an Objective-C object nor a block type
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS17.0.sdk/System/Library/Frameworks/WebKit.framework/Headers/WKWebsiteDataStore.h:119:46

Parse Issue (Xcode): Could not build module 'WebKit'
/Users/ra1n/dev/github_repos/eaglemask-wallet/build/ios/Debug-iphoneos/flutter_inappwebview/flutter_inappwebview.framework/Headers/flutter_inappwebview-Swift.h:286:8

Steps to reproduce
flutter run

Stacktrace/Logcat
err.log

https://github.com/pichillilorenzo/flutter_inappwebview/issues/1735#issuecomment-1744298306_


Need a property to provide custom styles on specific board squares.

Use case:
In order to display possible valid/legal moves, moves resulting in threats, best moves, and other analytical display, I'd like to be able to use a prop to customize specific board squares. Thus the following would render the g5 square as solid red:
      <Chessboard
        id="board"
        position={this.state.fen}
        width={320}
        squareStyles={{
          g5: { backgroundColor: "red" }
        }}
        ... />

This could, in time, deprecate the use of selectedSquareStyle and selectedSquares since it would allow customization of board display in a number of ways. I would recommend retooling these two properties to simply overwrite (or merge) the value of squareStyles for each entry in selectedSquares with the value of selectedSquareStyle. This should reduce the maintenance of the two similar features.

Thanks for putting all of this out at once.  It would be nice to get all these features out in one release.
This is very straightforward; I prefer this approach over selectedSquares.  It seems squareStyles as you have it is flexible and easy to implement

Take a look at Square.js in the following commit.  It was an easy change that allowed me to delete selectedSquareStyle and squareStyles.  It's a much clearer way to style squares.
Thanks for the recommendation!
https://github.com/willb335/chessboardjsx/pull/22/commits/42c1ddfd7eec4db818c173b4bd9cd9152181b05e

A working example:
https://github.com/willb335/chessboardjsx/blob/pieces-render-prop/src/integrations/HumanVsHuman.js

In release 2.0


Find photos, occupations, social media for Republicans

Want to help? Look at the Republicans sheet on this spreadsheet - we need help with the columns highlighted in yellow. Feel free to right-click and add comment to any cell you know, or reply to this thread on GitHub

Found all but 24 just by perusing facebook. I think that's enough to launch.


Change order of syschecks

The latter (ID: 4 recreation required) will be removed easily in future CrateDB version with ES 5.

Codecov Report

Merging #5101 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5101      +/-   ##
============================================
- Coverage     82.44%   82.32%   -0.12%
+ Complexity    10805    10790      -15
============================================
  Files          1305     1305
  Lines         44956    44956
  Branches       5681     5681
============================================
- Hits          37062    37011      -51
- Misses         5230     5277      +47
- Partials       2664     2668       +4

Impacted Files
Coverage Δ
Complexity Δ

...ys/check/cluster/TablesNeedRecreationSysCheck.java
100% <ø> (ø)
3 <0> (ø)
:x:

...e/sys/check/cluster/TablesNeedUpgradeSysCheck.java
75% <ø> (ø)
7 <0> (ø)
:x:

...n/java/io/crate/exceptions/JobKilledException.java
0% <0%> (-66.67%)
0% <0%> (-1%)

...t/executionphases/FailureOnlyResponseListener.java
40% <0%> (-33.34%)
2% <0%> (-2%)

...o/crate/analyze/SafeExpressionToStringVisitor.java
83.33% <0%> (-16.67%)
7% <0%> (-1%)

...crate/executor/transport/TransportShardAction.java
77.5% <0%> (-12.5%)
8% <0%> (-1%)

...o/crate/operation/projectors/SortingProjector.java
81.57% <0%> (-7.9%)
10% <0%> (-1%)

...ate/operation/projectors/SortingTopNProjector.java
87.5% <0%> (-7.5%)
13% <0%> (-1%)

...rc/main/java/io/crate/analyze/UnboundAnalyzer.java
85% <0%> (-5%)
2% <0%> (ø)

.../java/io/crate/blob/TransportDeleteBlobAction.java
75% <0%> (-5%)
5% <0%> (-1%)

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab05ec3...f426caf. Read the comment docs.


Wrong formula when applying Great Weapon Fighting

Great Weapon Fighting allows the PC to reroll a 1 or 2 damage dice roll upon attacking. The roll formula generated for 2h weapons (let's take the great sword[2d6] for example) while having this feature has the damage type in the wrong place:
What's generated: 2d6[slashing]r<=2 + @mod
Result: 2d6 + ability modifier
What is should be: 2d6r<=2[slashing] + @mod
Result: 2d6r<=2 + ability modifier

Resolved in 0.6.19


chore(deps): update dependency execa to v4.0.1

This PR contains the following updates:

Package
Type
Update
Change

execa
devDependencies
patch
4.0.0 -> 4.0.1

Release Notes

sindresorhus/execa
v4.0.1
Compare Source
Bug fixes

Fix checking for Error instances (#423)

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 5.0.41 :tada:
The release is available on:

v5.0.41
GitHub release

Your semantic-release bot :package::rocket:


Refresh task at startup

Hi @itchyny ,
I love your plugin more every day. I have however one minor problem: if I add a new task and a new event through the web  and then open the calendar app with :Calendar -task the new task is not shown in the tasklist. I need to open and close the Calendar app for it to refresh (on the other hand the new event is automatically shown).
Can you reproduce this behaviour?
Thanks in advance

As I have explained in #81, the app does refresh the calendar events three hours after the last update, and the task list as well. Otherwise the app would causes too much download events and results into the performance down. If you switch to the app, why don't you insert your new task with this app?

@itchyny  I understood what you explained in #81. What I mean is that if for instance I create a new task with my mobile phone and after three hours I open the vim app with :Calendar -task the new task does not show up. I need to close the app and re open it for it to appear.  This doesn't happen with a regular calendar event (i.e if I create a new event with my mobile phone and after three hours I open the vim app then the event shows up).

Thank you!


--full-refresh handling differs from core

Hi,
Today, I found two discrepancies between the exasol incremental implementation and the dbt core one

A failed --full-refresh in exasol leads to a dropped table
Core avoids this by doing a swap
{% elif full_refresh_mode %}
{% set build_sql = get_create_table_as_sql(False, intermediate_relation, sql) %}
{% set need_swap = true %}
(and then renaming and dropping if everything else works)
adding full_refresh=false or true to your config has no impact in Exasol
in core it's
{%- set full_refresh_mode = (should_full_refresh()  or existing_relation.is_view) -%}
and the should_full_refresh handles the config part
dbt exasol only checks
{%- set full_refresh_mode = (flags.FULL_REFRESH == True) -%}

I feel like the second point is an easy fix as should_full_refresh should be readily available from dbt core, so all it needs is to swap the columns.
The first point is a bit more intertwined.
If there aren't any open branches regarding incremental materilization I'd volunteer to try and fix these issues.
Cheers
Hannes

Hi Hannes,
I was starting to work on the branch feature/38-incremental-materialization-strategies to actually get incremental materialilzation back into sync with core - but did not manage to commit anything. So please go ahead and fix your finding on that branch.
Thx a lot and any help is highly appreciated!
Regards, Torsten

Hi @johannes-becker-otto ,
I changed our incremental model implementation back to re-use what is default in dbt-core. Pushed changes to https://github.com/tglunde/dbt-exasol/pull/62.
Could you double check, wether this changes the behaviour as expected?
Cheers, Torsten

Hi Torsten,
it should, I'll run the branch as soon as I find the time.
All the best
Hannes

I will go ahead and close this issue for now - please feel free to re-open once you get testing it in failure. BR Torsten


derived_system_data function

New function to pull System Buy Price (SBP) and System Sell Price (SSP) from the BMRS

New function to import System Buy and System Sell Prices contained in the Derived System Data set.


Overhaul put_resource logic.

Introduce a generic format and precedence for calls into EnvServlet.
All functions will take in data and serialization. They can put whatever
they want in the data field and unpack them as tuples before and after, as
done in this PR. This will support pickle and json serialization.
The other parameters to EnvServlet functions will be explicit.
The EnvServlet should also only call local ObjStore functions, and the
ObjStore should deal with all the outside-of-env logic and call the right Env.

Current dependencies on/for this PR:

main

PR #356   👈

This stack of pull requests is managed by Graphite.

Merge activity

Jan 19, 11:52 AM: @rohinb2 started a stack merge that includes this pull request via Graphite.


Project Fails to build/Publish

Sample csproj from user:
<Project ToolsVersion="15.0" Sdk="Microsoft.NET.Sdk.Web"> <PropertyGroup> <TargetFramework>netcoreapp1.1</TargetFramework> <TypeScriptCompileBlocked>true</TypeScriptCompileBlocked> <IsPackable>false</IsPackable> <TypeScriptToolsVersion>2.3</TypeScriptToolsVersion> </PropertyGroup> <ItemGroup> <PackageReference Include="Microsoft.AspNetCore" Version="1.1.2" /> <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="1.1.2" /> <PackageReference Include="Microsoft.AspNetCore.Identity" Version="1.1.2" /> <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="1.1.3" /> <PackageReference Include="Microsoft.AspNetCore.SpaServices" Version="1.1.1" /> <PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="1.1.2" /> <PackageReference Include="Microsoft.Extensions.Logging.Debug" Version="1.1.2" /> <PackageReference Include="Serilog.Extensions.Logging" Version="1.4.0" /> </ItemGroup> <ItemGroup> <!-- Files not to show in IDE --> <None Remove="yarn.lock" />
 <!-- Files not to publish (note that the 'dist' subfolders are re-added below) -->
 <Content Remove="ClientApp\**" />
</ItemGroup> <ItemGroup> <Content Include="ClientApp\dist\papaparse.min.js" /> </ItemGroup> <ItemGroup> <ProjectReference Include="..\Domain.Data\Domain.Data.csproj" /> <ProjectReference Include="..\Domain.Model\Domain.Model.csproj" /> </ItemGroup> <Target Name="RunWebpack" AfterTargets="ComputeFilesToPublish"> <!-- As part of publishing, ensure the JS resources are freshly built in production mode --> <Exec Command="npm install" /> <Exec Command="node node_modules/webpack/bin/webpack.js --config webpack.config.vendor.js --env.prod" /> <Exec Command="node node_modules/webpack/bin/webpack.js --env.prod" />
 <!-- Include the newly-built files in the publish output -->
 <ItemGroup>
   <DistFiles Include="wwwroot\dist\**; ClientApp\dist\**" />
   <ResolvedFileToPublish Include="@(DistFiles->'%(FullPath)')" Exclude="@(ResolvedFileToPublish)">
     <RelativePath>%(DistFiles.Identity)</RelativePath>
     <CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory>
   </ResolvedFileToPublish>
 </ItemGroup>
</Target> </Project>

Additional context on the issue - https://developercommunity.visualstudio.com/comments/103876/view.html

Hi @vijayrkn. I'm afraid the information posted here doesn't give us anything we could use to diagnose or investigate any issue. Was there a specific error that occurred? Also the "additional context" you linked to doesn't seem related to the project templates in this repo - that's a thread about ASP.NET publishing in general.
If you have specific repro steps and error information, could you please post them as a new issue? Thanks!

He posted this on behalf of an issue I am having.
I have a .Net Core 1.1 Web Application that is using Webpack and Angular 2 front end.
Up until yesterday, I could publish with no issues. Starting yesterday, When I click publish, nothing happens. It doesnt build, and it doesnt publish. I am publishing to a folder location.
It is set to go to a remote location, but I have also tried it to a local location, and it also does nothing.The above is the sample csproj from me. I cant supply a sample project, because of restrictions of the company I am at currently.

@dsslayers I would need more info to be able to investigate this. Ideally repro steps, but failing that, an example of a project that surfaces the issue. Sorry I can't infer what's changed in your project without that info!


Change main page name

Now, acc to w3schools, they'll display 50-60 chars of the title max. This is under 60, but not 50. we can test it, and here's an under 50 version, although tbh I don't like it: Free Community First Minecraft Server Host|Minefly
This is the title that displays in search results as well, so I didn't just want to do "Home | Minefly"

too long the tabs are very short and it'll just display a ...

many other websites do it for their main page to stand out in search results:

This is done through meta tags for SEO, not the actual page title

nope, check it out:
https://pokemon.com
https://github.com/home
https://discord.com
I did notice one website did it that way tho

¯_(ツ)_/¯ Since the PR was closed, going to delete the unused branch


use_eval with scrolling after component is rendered

Specific Demand
I want to execute eval each time after the component is rendered (I want to make scroll to a particular object)
In the code below scrolling doesn't work. I think because eval executes before HTML is rendered.
Looks like it's not implemented https://github.com/DioxusLabs/dioxus/issues/631 https://github.com/DioxusLabs/dioxus/issues/517 but maybe you can suggest me any better workaround that I have?
Because I've found nothing better than just sleeping in the "Component" function
    let eval = dioxus_desktop::use_eval(cx);
    let res = cx.render(rsx! {
        div {
            dangerous_inner_html: "{html}"
        }
    });
    eval(JsScroll.to_string()); // document.querySelector(...).scrollIntoView({behavior: 'smooth'})
    res

Workaround 1
    static JsScroll: &str = r#"
      setTimeout(function(){
      document.querySelector(`[data-sourcepos='138:1-138:14']`).scrollIntoView({behavior: 'smooth'})
      }, 100);
    "#;

    let eval = dioxus_desktop::use_eval(cx);
    let res = cx.render(rsx! {
        div {
            dangerous_inner_html: "{html}"
        }
    });
    eval(JsScroll.to_string());
    res

Workaround 2
I use use_effect where I "update" Component with the same value, it triggers "Component function" again and scrolling (eval call) works a second time as expected
static MARKDOWN_CONTENT: Atom<String> = |_| "".to_string();
static JsScroll2: &str = r#"
document.querySelector(`[data-sourcepos='138:1-138:14']`).scrollIntoView({behavior: 'smooth'})
"#;
#[inline_props]
pub fn Markdown(cx: Scope<'a>) -> Element {
    let con = use_read(cx, MARKDOWN_CONTENT);
    let setContent = use_set(cx, MARKDOWN_CONTENT).clone();

    use_effect(cx, con, |con| async move {
        setContent(con);
    });

    let parser = &mut markdown_it::MarkdownIt::new();

    let html = parser.parse(con).render();
    let eval = dioxus_desktop::use_eval(cx);
    let res = cx.render(rsx! {
        div {
            dangerous_inner_html: "{html}"
        }
    });
    eval(JsScroll2.to_string());
    res
}

Implement Suggestion

I think you can just use push_future. From the docs:

Pushes the future onto the poll queue to be polled after the component renders.
https://github.com/DioxusLabs/dioxus/blob/d521da1991719760e271457dfe4f9ddf281afbb3/packages/core/src/scopes.rs#L413

    let eval = dioxus_desktop::use_eval(cx).clone();
    cx.push_future(async move {
        eval("document.write('hello');".to_string());
    });

Yeap! Exactly what I need. Thank you,  @terhechte
I didn't find it in the documentation because it mentioned only once and in another context

Futures are Rust's version of promises that can execute asynchronous work by an efficient polling system. We can submit new futures to Dioxus either through push_future which returns a TaskId or with spawn.

And I can't find the push_future description in docs/guide* maybe there is someplace to mention the description of this feature with the words "after the component renders."
P.S. Issue can be closed


Input element should not require focus when component is mounted

It is generally a bad idea to force set the input field's focus. This skips input field focus when component is mounted, instead triggering the associated onFocus handler event.

@gleuch Thanks for the PR! Will test it out today and merge if all is ok.

Would love to see this too ;)


Implement registration for 2D data of the MD

Currently, the apply registration to image task is not implemented for the cyx and yx cases that data from the MD would typically have.
Goal: Get some MD test data and implement this.
If getting real test data proves cumbersome, try the same approach as for testing Yokogawa data by faking the MD data (may mess with the metadata, to be tested)

Next steps: @fstur is preparing some MD test data for multiplexing and we'll be working on the MD parser for multiplexing.
Once we have that one, come back to this issue


Successfully deployed but no custom attribute defined

Would there be any reason why the addition of a custom attribute would not appear in the attributes section of the Cognito user pool after being defined? (see log)
Serverless: CognitoAddCustomAttributesPlugin: Start
Serverless: [AWS cloudformation 200 0.224s 0 retries] describeStacks({ StackName: [redacted]})
Serverless: CognitoAddCustomAttributesPlugin: Found userPoolId: [redacted]
Serverless: CognitoAddCustomAttributesPlugin: End
Serverless: CognitoAddCustomAttributesPlugin: Found userPoolClientId: [redacted]
Serverless: Invoke aws:deploy:finalize
Serverless: [AWS s3 200 0.218s 0 retries] listObjectsV2({ Bucket:
   [redacted],
  Prefix: [redacted] })
Serverless: Removing old service artifacts from S3...
Serverless: [AWS cognitoidentityserviceprovider 200 0.244s 0 retries] describeUserPool({ UserPoolId: [redacted]})
Serverless: [AWS cognitoidentityserviceprovider 200 0.152s 0 retries] describeUserPoolClient({ ClientId: '***SensitiveInformation***',
  UserPoolId: [redacted]})
Serverless: CognitoAddCustomAttributesPlugin: Adding 1 attribute(s) to pool: subscription

Your Environment Information -----------------------------
     OS:                     darwin
     Node Version:           11.5.0
     Serverless Version:     1.39.1

I have the same problem; no change shows in my user pool. Below are my logs. After the following lines, execution ends.
Serverless: CognitoAddCustomAttributesPlugin: Start Serverless: CognitoAddCustomAttributesPlugin: Found userPoolId: [redacted] Serverless: CognitoAddCustomAttributesPlugin: End Serverless: CognitoAddCustomAttributesPlugin: Found userPoolClientId: [redacted] Serverless: Removing old service artifacts from S3... Serverless: CognitoAddCustomAttributesPlugin: Adding 1 attribute(s) to pool: store_id
Here is my environment:
Your Environment Information -----------------------------      OS:                     darwin      Node Version:           10.0.0      Serverless Version:     1.35.1

Seemed to work after I tore down the entire deploy


add pan then flash

@topowright @mcalamito @dhagens please review and merge, do note that core changes at Pro 1.3 will cause the flash animation position to be inaccurate.  Adding a new issue for that.


popup.close() not removing the popup element from DOM

In ionic 1.1 you have added !$ionicModal.stack.isHighest(self) condition to self.remove function.
if (self.removed) return;  --->  if (self.removed || !$ionicModal.stack.isHighest(self)) return;
I run into a problem when I open a popup from click on another popup.
When first popup is opened:

the self.show function is called and object is added to the $ionicModal.stack.
When second popup is opened from click on the first popup:
first popup self.hide is called and object is removed from $ionicModal.stack.
second popup self.show is called and object is added to the $ionicModal.stack.
When popup.close() is called on the second popup:
first popup self.show is called and object is added to the $ionicModal.stack.
second popup self.remove is called, but is returned, because $ionicModal.stack.isHighest(self) === false (first popup is the highest object on the stack)

I am not sure if i am somehow misusing it or it is a bug!?

Greetings @avainola!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Sounds like leaving the first popup open would mitigate the issue entirely.

@simplesmiler could you please explain what do you mean by leaving the first popup open?
As i wrote in the first post, i'm not explicitly closing the first popup, but opening new popup when user clicks on an element on the first popup. Hiding of the first popup is handled in the ionic library.


Debugbar doesn't display API queries

I can't seem to get the debugbar to display any queries performed from the API. I don't know if I'm just missing something plainly obvious, but I've even tried a straight-forward \Debugbar::info('Hello, world!'); to no avail.
It works from top-level controllers like WelcomeController.php without problems.
I don't know if it's got anything to do with this Dingo issue. Anyone else got any issues with debugbar?

Hi @edbentinck
Thanks for your feedback
Indeed this is related to the dingo issue you mentioned. I remember stumbling upon it when I originally had the same issue.
Although this issue says that it's working
I'm going to keep this open and dig through DebugBar
I'll keep you posted if I can make it work

In the meantime, this package might be useful

Thanks, @jadjoubran. Bittersweet knowing that I'm not just mad... Hope we can find a fix soon! :grin:
That other package will do for now.

Mentioned limitation in documentation - must keep it in sync if this gets resolved
https://laravel-angular.readme.io/docs/debugbar

There seems to be an upcoming upstream fix for this here

Interesting... let's hope they move along with it. Keep up the awesome work!

Debugbar has been removed as of version 3.1 since it doesn't work with APIs yet..
Will re-open as soon as there's progress on the upstream issue


Rounded flags

Noticed you only had the rectangular version of the flags set on the repo and I needed the rounded ones for my project. I have them all properly named and cleaned up on one of my projects in case anyone needs them. Ideally they'd sit under /assets/flags-rounded and the same could be done for the square ones.
Let me know if you're interested on a PR that adds them. The only issue I can think of is flags will need to be contributed to all sets instead of just one like you're doing now. If that's too much overhead, I'll probably share them on a new repo and link back to the plugin.

Sure! They're the ones under the Rounded tab of the author's site.

Hello @hacknug, I will redesign to make them the same as the ones I use. I am closing the issue for now. 🙂


Typo in 2.2?

I think some words are missing in this sentence in Section 2.2:
"At the same time, the alpha of 5% guarantees that (in the long-run) 5% of the 100 studies where the null hypothesis is true will Type 1 errors: 5% = 5."
Also, "long run" in usually written as two words in the phrase "in the long run" (this applies throughout this chapter).

For consistency, the following sentence could also have the proportion expressed as a percentage:
"When we do 200 studies, at most 0.05 = 10 could possibly be false positives (if was true in all experiments)."
Instead of 0.05, I suggest writing 5% to better connect to the previous sentence and avoid the mathematically odd statement of "0.05 = 10".


Fix documentation for deprecated 'reports' object (Issue #5908)

Hi,@cortinico
I wanted to let you know that I've submitted a draft pull request for my recent changes to the documentation. However, one of the checks has failed. Specifically, the codecov report shows that merging my changes into the main branch would decrease coverage by 0.11%. The diff coverage is 88.88%.
I'm not sure why this is happening, and I would appreciate your guidance in resolving this issue.  Can you please take a look at the failed check and let me know what I can do to fix the coverage issue?
Thank you for your time and help.

@cortinico I am really sorry but i am new to open source so i had no idea how to improve this existing PR.
I have made another PR that will be ready as the checks gets completed.
I am extremely sorry for this kind of behaviour, I apologize for any inconvenience caused.

how to improve this existing PR

There are a few ways, but the easiest way is to make your changes, commit them, then push the new commits to your remote repository again.
For more info, try:
https://www.atlassian.com/git/tutorials/saving-changes
https://www.atlassian.com/git/tutorials/syncing/git-push
There are lots of sources of intro level information out there!


Adding Analyze command to guacone

Description of the PR
Analyze command for guacone
PR Checklist

[ ] All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
[ ] All new changes are covered by tests
[ ] If GraphQL schema is changed, make generate has been run
[ ] If OpenAPI spec is changed, make generate has been run
[ ] If collectsub protobuf has been changed, make proto has been run
[ ] All CI checks are passing (tests and formatting)
[ ] All dependent PRs have already been merged

@pxp928 ready for review.

Cool, @arorasoham9 can you add some screenshots to what the output will look like for the CLI?

Cool, @arorasoham9 can you add some screenshots to what the output will look like for the CLI?

Added some screenshots.

@arorasoham9 did the node functionality get fixed?

@pxp928  Ready for review. Please let me know what changes you require to the output presentation.

@nathannaveen Done! I have moved the HasSBOM JSON test files for gaucanalyze to guac-test. I have also added some explanation for having these JSON files to the description of this PR.
I will require this  PR merged before I can send a final commit to reflect the code changes to accept the JSON test from guac-test.

@arorasoham9 any luck in improving the output? It is very hard to understand.

@pxp928 I am still thinking of ways to show only the relevant information. This is a better explanation for why you see so much even with just a small difference between two sboms. The diff works at the granularity of a path, not a node, so when it finds even one node different it classifies all paths with that participating node as different (and prints them). I believe the original aim to find missing/different paths bw two sboms was to also offer a graph "structural" difference. I am trying to think how we can still offer the same differences in an easier to understand manner.

Hey @arorasoham9 , would you be able to chat at bit more amount helping to turn the corner to complete the PR.


Migrate from sphinx to mkdocs

For better quality and easier maintainability, let's move our docs to mkdocs from sphinx. There are automatic tools to convert the files from rst to md so take a look at that.

The project for converting files is pandoc


Ben 10 and Danny Phantom not seeing 2.5.4?

I'm trying to make a modpack for streaming, but I'm having an issue where Ben 10 and Danny Phantom won't detect the core mod. But, when I backport them to the one it says, I get a crash saying the poses don't work. What's going on?
1.16.5 Minecraft, forge version 36.2.39

Ben 10 is 0.2.3, Danny Phantom is 0.1

use 2.5.3

I try, but then it throws the pose error.

can u give a crash log in our discord server?

I can try, but it could take a bit.

which channel do I send it in?


Upgrade Form Controls

Upgrade Form Controls
Enhance the input and output language selectors by upgrading the dropdown UI for better user experience.
Action Items:

Use Headless UI or any similar libraries for enhanced functionality.
Add Tailwind-styled dropdowns for language selection.
Ensure they are visually appealing and responsive.

please assign to me @aayushai

@aayushai can i work on this issue now?

Go ahead

@aayushai  can you provide some examples , how it should be done .

@thevashuydv Use these libraries for form selector UI enhancement
Radix-UI
HeadlessUI

@aayushai  sure

hey @aayushai does it look fine if I do the dropdown like this

@thevashuydv Try to use Headless UI, it's more clean.

Hey @aayushai greetings!
Can you assign this task to me?

Go Ahead @Rehannn03 .

Thank You

Hey @aayushai I have made the above changes and made a PR kindly review it.

Yeah it's done. I've merged.

Thank You!


Add my first file.

you have: created a new branch, created a file, and made a commit.

you have: created a new branch, created a file, and made a commit. and have pulled the file en merge it to main

done


Time issue in micro_speec

@tensorflow/micro
System information

Host OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
TensorFlow installed from (source or binary):
Tensorflow version (commit SHA if source):
Target platform (e.g. Arm Mbed OS, Arduino Nano 33 etc.):

When the micro_speech loop is executed for the first time, current_time is 0. In this case, the Feature Provider requests kFeatureSliceCount audio data packages of kFeatureSliceDurationMs length. However, since previous_time is set equal to  current_time after calling feature_provider->PopulateFeatureData(). So running the next time, current time has increased by the number of ms that the audio provider has been recording but also have 990 ms of data already been used. The Feature Provider just sees the difference in the recorded time since the last call and asks for more data that should be available. But since audio provider has no data, it waits till the data has been recorded which takes exactly the time that is missing which are 990 ms.
Am I the only one with this issue? Is it my mistake or common?
There are multiple ways to fix this:

start the time of the audio provider at -990 ms
don't let the feature provider request data if there is none recorded (needs audio provider init to be called separately I guess)
don't set previous_time to current_time but to how_many_new_slices * kFeatureSliceStrideMs

@nixmeer Is this still an issue for you? Can you please test with recent TF2.7 and tf-nightly and let us know whether the issue persists with recent TF version. Also, share a complete standalone code to reproduce the issue. Thanks!

@nixmeer @jvishnuvardhan BTW, the examples repo for Espressif solutions is now maintained at: https://github.com/espressif/tflite-micro-esp-examples
If issue still persists for you, I would request you to try out the above repo.


feat: narrow type based on status code

Changes
The various client methods (GET, POST, PUT e.t.c.) now have an additional status property.
This property allows users to narrow the type of their data/error based on their documented response status codes.
How to Review
How can a reviewer review your changes? What should be kept in mind for this review?
Checklist

[x] Unit tests updated
[ ] docs/ updated (if necessary)
[ ] pnpm run update:examples run (only applicable for openapi-typescript)

I LOVE this! Please let us know if you need any help with the tests or the current direction. This would be amazing to land

@drwpow I think this is ready for a review now :)


Device Identifier not recognized! ipad6,12

hello,
If "iPad 5 (Cellular)" is selected than it ends with "Device Identifier not recognized! ipad6,12"
but iPad 5 (WiFi) works ok (I have both devices)
I think there is some typo in Cellular option, could you please look at it?
Thank you

This has been fixed


P3 preview

Connects to https://github.com/vaadin/components-team-tasks/issues/368

This change is

One tests failing but will be fixed when working on #30

Reviewed 1 of 9 files at r1, 12 of 17 files at r2, 1 of 2 files at r3, 3 of 3 files at r4, 1 of 1 files at r6, 1 of 1 files at r7.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable


Matching #as patterns

The frontend uses \and to generate patterns which match on a function argument and simultaneously introduce a variable assigned to the match, e.g.
axiom andBool(false ∧ x, _) = x

There are two unresolved items:

[x] We simplify all axioms once before we begin execution; how does that affect this type of rule?
[ ] Does the matcher for function arguments probably does handle such patterns correctly?

See also: #789

This is handled by simplifyRulePattern, verified by unit test in #803.


This step is using an outdated fastlane version

I'm getting this error in the upload_to_app_store command.
[18:22:12]: fastlane finished with errors
Looking for related GitHub issues on fastlane/fastlane...
➡  Spaceship::UnexpectedResponse: [!] The URL path is not valid - The relationship 'appReviewAttachments' does not exist
    https://github.com/fastlane/fastlane/issues/16732 [closed] 3 💬
    2 weeks ago
➡  Having deliver/upload_to_app_store issues? Install 2.150.0.rc5
    https://github.com/fastlane/fastlane/issues/16639 [closed] 116 💬
    a week ago
🔗  You can ⌘ + double-click on links to open them directly in your browser.
#######################################################################
# fastlane 2.159.0 is available.
# You should use the latest version.
# Please update using `bundle update fastlane`.
#######################################################################
bundler: failed to load command: fastlane (/Users/vagrant/.rbenv/versions/2.6.5/bin/fastlane)
Spaceship::UnexpectedResponse: [!] The URL path is not valid - The relationship 'appReviewAttachments' does not exist

Caused by:
fastlane 2.159.0 is available.

What mechanism decides which Fastlane version is being used? We're still on 2.150.0.rc7 which is from July while 2.159.0 is already out. We're more than 24 releases behind.

Nevermind, I just found this in my Gemfile:
source 'https://rubygems.org' do
  gem "fastlane", ">= 2.150.rc7"
end

Forgive me, it's still early in the morning here in The Netherlands 🤦.


Add comment keyboard shortcut

Add a keyboard shortcut for commenting in a CSS file.
Default to Meta + /, but allow it to be customizable if possible.

Did some discovery. Turns out the toggle comment keybind already works if Obsidian's default keybind for toggle comments is turned off or changed to another keybind.
Ideally, the CSS Editor plugin should follow the same keybind as setup in Obsidian settings, and should override Obsidian's command when run in a CSS Editor View.

Found a solution for ignoring Obsidian keybinds while in a CSS Editor View, this is sufficient for my needs at the moment. Released in 0.5.0.


has anyone found a workaround for using SocketIO?

The documentation gives an example of using socketio, but using it throws an error:
import { Server, SocketIO } from 'mock-socket';

Module '"mock-socket"' has no exported member 'SocketIO'.

I realize this repo seems to have been abandoned, but does anyone have a usable workaround?

the type defs are out of date, stick this in your code:
declare module 'mock-socket' {
  type SocketIO = any
}

you can do better than just using any, if you want.

I got that error now
'SocketIO' only refers to a type, but is being used as a value here.

class SocketIO {
    constructor(uri: string, opts?: any);
    close: () => void;
    disconnect: () => void;
    emit: (event: string) => SocketIO;
    send: (data: any) => SocketIO;
    on: (type: string, callback: (data: any) => void) => SocketIO;
    off: (type: string, callback: (data: any) => void) => SocketIO;
    hasListeners: (type: string) => boolean;
  }


How to connect the pins?

Do you know how to connect the pins correctly?

This is a big issue with this accelerometer with all these pins: did you find out?


Novena feature. As A user I want to be able to pray the Novena and move from a day to the other

4c89a5b56976df7147e6bc19b8ee7519638b8c70


Cannot create account

Version: Fuji
Environment:

X86_64 Ubuntu16.04
X86_64 macOS Catalina 10.15.1

Description: Cannot create account by following the README instructions. (In Edinburgh release, it works)
Steps to reproduce:

docker-compose -f docker-compose-fuji-no-secty.yml up -d
docker-compose -f docker-compose-fuji.yml up -d vault
docker-compose -f docker-compose-fuji.yml up -d vault-worker
docker-compose -f docker-compose-fuji.yml up -d kong-db
docker-compose -f docker-compose-fuji.yml up -d kong-migrations
docker-compose -f docker-compose-fuji.yml up -d kong
docker-compose -f docker-compose-fuji.yml up -d edgex-proxy
docker-compose -f docker-compose-fuji.yml run edgex-proxy --useradd=user --group=admin

or

docker-compose -f docker-compose-fuji.yml up -d
docker-compose -f docker-compose-fuji.yml run edgex-proxy --useradd=user --group=admin

Expected result: Return the access token for user
Received result:

Starting kong-db     ... done
Starting edgex-files ... done
Starting edgex-core-consul ... done
Starting edgex-vault       ... done
Starting kong-migrations   ... done
Starting kong              ... done
+ cd /consul/scripts
+ command -v jq
+ JQ=
+ '[' -z  ]
+ LD_LIBRARY_PATH=.
+ export LD_LIBRARY_PATH
+ JQ=/consul/scripts/jq
+ export JQ
+ /consul/scripts/jq -r '.[] | select(.ServiceName == "kong") | .Status == "passing"'
+ curl -s -G edgex-core-consul:8500/v1/agent/checks
+ '[' true '=' true ]
+ cd /consul/scripts
+ command -v jq
+ JQ=
+ '[' -z  ]
+ LD_LIBRARY_PATH=.
+ export LD_LIBRARY_PATH
+ JQ=/consul/scripts/jq
+ export JQ
+ curl -s -G edgex-core-consul:8500/v1/agent/checks
+ /consul/scripts/jq -r '.[] | select(.ServiceName == "security-secretstore-setup") | .Status == "passing"'
+ '[' true '=' true ]
level=ERROR ts=2019-12-23T09:11:57.639625Z app=edgex-security-proxy-setup source=logger.go:73 msg="logTarget cannot be blank, using stdout only"
Creating directory: ./logs
level=INFO ts=2019-12-23T09:11:57.6417117Z app=edgex-security-proxy-setup source=requestor.go:40 msg="successfully loaded rootCA certificate."
level=INFO ts=2019-12-23T09:11:57.6504506Z app=edgex-security-proxy-setup source=service.go:64 msg="the service on http://kong:8001 is up successfully"
level=DEBUG ts=2019-12-23T09:11:57.6904699Z app=edgex-security-proxy-setup source=service.go:151 msg="trying to upload cert to proxy server"
level=ERROR ts=2019-12-23T09:11:57.6957547Z app=edgex-security-proxy-setup source=service.go:182 msg="failed to add certificate with errorcode 400, error {"message":"schema violation (snis: edgex-kong already associated with existing certificate '49b0a17f-599d-45dd-9496-33b9a0af14d1')","name":"schema violation","fields":{"snis":"edgex-kong already associated with existing certificate '49b0a17f-599d-45dd-9496-33b9a0af14d1'"},"code":2}"
level=INFO ts=2019-12-23T09:11:57.6970807Z app=edgex-security-proxy-setup source=service.go:98 msg="skipping as the initialization has been done successfully"

edgex-proxy is now in the edgex-go repo


Description on PyPI isn't formatted correctly

This is a relatively minor issue but the formatting on https://pypi.org/project/click-man seems broken - the markdown is rendered literally for some reason.

This appears to be fixed now — at least, everything looks fine to me when I visit https://pypi.org/project/click-man

You are right, it seems alright now.
Let's close this. Thanks!


RangeError: Maximum call stack size exceeded

Hello, im trying to implement relationships with this code:
Manufacturers = new Mongo.Collection('manufacturers');
Manufacturers.attachSchema(new SimpleSchema({
name: {
type: String
}
}));
Colors = new Mongo.Collection('colors');
Colors.attachSchema(new SimpleSchema({
name: {
type: String
}
}));
Cars = new Mongo.Collection('car');
Cars.attachSchema(new SimpleSchema({
manufacturer: {
type: Manufacturers
},
color: {
type: Colors,
optional: true
}
}));
and I'm having this error:
/home/rafa93br/.meteor/packages/meteor-tool/.1.1.4.p2mczn++os.linux.x86_64+web.browser+web.cordova/mt-os.linux.x86_64/dev_bundle/server-lib/node_modules/fibers/future.js:245
throw(ex);
^
RangeError: Maximum call stack size exceeded
Exited with code: 8
Your application is crashing. Waiting for file change.
Am I'm doing something wrong? :(

You are referencing other collections in your type definition. But you should be referencing schemas.
Manufacturers = new Mongo.Collection('manufacturers');
Manufacturers.Schema = new SimpleSchema({
  name: {
    type: String
  }
});
Manufacturers.attachSchema(Manufacturers.Schema);

Colors = new Mongo.Collection('colors');
Colors.Schema = new SimpleSchema({
  name: {
    type: String
  }
});
Colors.attachSchema(Colors.Schema);

Cars = new Mongo.Collection('car');
Cars.Schema = new SimpleSchema({
  manufacturer: {
    type: Manufacturers.Schema
  },
  color: {
    type: Colors.Schema,
    optional: true
  }
});
Cars.attachSchema(Cars.Schema);

But my mind is still clouded about some things
When you create an field with type equals another schema, you are creating a field that contains an entire document of the another collection, right? thats not what i want.. i want just to store a reference id... not duplicate the referenced document every time

obviously i could just create a field with type String and store the other document Id, but then it`s not a relationship behavior, its just a string store

A reference to another schema means that that part of the document structure within a single document must conform to the schema rules that are proposed by the referenced schema.
Schema definitions are applied per document.
So it is like embedding a single document within a field of the single parent document. So it is not a "join" type relationship, nor a reference. It does not facilitate nor provides a context for a relationship.
A relationship is what you can achieve by setting the type to string and storing the referenced document's id. So with a second database call, you can fetch the referenced document.
Or if you want to reference mutiple documents, make it a [String] type and reference multiple id's.
So as you said it it sill is not a formal sql world type of relationship but mongodb is not a relational database so perhaps you should first brush up on your mongodb skills which will put the meteor side of things into more perspective for you.
For further discussion about relationships and joins in meteor, search the forum where there's loads of information and examples.

There is a design for implementing pseudo-relationship support through collection2 similar to how you're trying to do it, but that is not currently a feature. You need to store the string ID and do your own joins as @serkandurusoy said. If in publication, then use one of the reactive join packages.

Now everything is clear to me! Thanks guys


Remove paper and add Dotted Line Divder

Remove Paper component when displaying pre-encounter mode panels and add dotted line to more accurately reflect mockups.
Pull requests into Flux require the following. Submitter and reviewer should :white_check_mark: when done. For items that are not-applicable, note it's not-applicable (N/A) and :white_check_mark:.
Submitter:
Running the Application

[x] Manually tested in Chrome
[x] Manually tested in IE

Documentation

[x] This pull request describes why these changes were made
[x] Recognizes any potential shortcomings/bugs in the description
[x] N/A Cheat sheet is updated
[x] N/A Demo script is updated
[x] N/A Documentation on Wiki has been updated
[x] N/A Additional technical components and libraries are documented and added to wiki as needed

NoteParser

[x] N/A Note parser has been updated if structured phrases change

Code Quality

[x] 4-space indents - convert any tabs to spaces
[x] Use public class field syntax for binding functions - ex. handleChange = () => { ... };
[x] Code is commented

Tests

[x] Existing tests passed
[x] N/A Added UI tests for slim mode
[x] N/A Added UI tests for full mode
[x] N/A Added backend tests for fluxNotes code
[x] N/A Added note parser examples to test new functionality

Reviewer 1: Julia

[x] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[x] The tests appropriately test the new code, including edge cases
[x] You have tried to break the code

Reviewer 2: Name

[ ] Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
[ ] The tests appropriately test the new code, including edge cases
[ ] You have tried to break the code

This looks good to me and looks in line with the designs. One small thing I noticed is that we probably want to take out the console.log on the editor focusing, unless there's a reason for keeping it. Other that, it looks good to me!

All done!

Looks good to me!