'escape' doesn't exit Quick Add Task or Add label

After bring up "Quick Add Task" with 'q' or "Add label" with '@' hitting 'esc' to cancel the changes and close the dialog box no longer works. The only way to dismiss the dialog is with the mouse.

Hmm, curious!  At first I didn't see this problem.  Then I refreshed once, and saw it happen, but after switching projects the problem went away.  Subsequent refreshes didn't have the problem.  So, it seems to be some sporadic bug.
Handling of escape for that is done by Todoist.  It is conceivable that it could be due to an issue with todoist-shortcuts, since it does some keyboard event interception.  It seems unlikely to me that the behavior of this interception would vary sporadically, so I am thinking this is an upstream bug.

It was always broken for me. I'd also found it did't work with the comment dialog either. I removed and added the extension back and now things are working. 🤷♂

One of the changelog notes in Todoist version 940 is

🐛The keyboard shortcuts for adding and editing a task were acting up but that's been fixed.

Perhaps that's related to this issue


Removing dependency gives error

I have removed a dependency from my app. Now mix release --verbosity=verbose fails with:
{error,
  {rlx_prv_relup,
    {relup_script_generation_error,
      systools_rc,
      {muldef_module,
        'Elixir.Phoenix.HTML.Safe.Calendar.DateTime'}}}}

I remove the dependency both from applications and deps.
The release works when I remove rel and _build.

After more testing, I noticed that this does not have anything to do with removing the dependency.
I managed to remove the dependency, while still being able to release.
But I was implementing the Phoenix.HTML.Safe protocol before. This is not the case now. I will investigate further.

The library is not removed when I release.
Also I noticed that are multiple versions of other libraries I updated in rel/<app>/lib.
Shouldn't these be removed?

@ThijsWouters rel/<yourapp/lib can potentially contain multiple versions of your dependencies if you are doing upgrades. If you aren't doing upgrades, then you can use the release.clean task to clean up unnecessary files. However if you are doing upgrades, then those older versions of dependencies are necessary for recreating prior releases. When building the tarball package, only the current version's dependencies are included.
If you are expecting a previous version's dependency which is no longer in the current version to be removed from rel/<your app>/lib, that won't happen, because it is kept around in order to permit downgrading to that older version.
Does that answer your question?

Yes, that makes sense.
But then there is still a problem, the library I removed is loaded when I start my application.

@ThijsWouters Loaded or just in the code path? How are you testing whether or not it's loaded? For instance, if you try to call a function on a module contained in that library, if the module is on the code path, it will be loaded. You'd need to call :code.all_loaded and check the first element of each tuple in the result list for that library's name. If it's there, then something has to still be loading it.

When I load my application with iex -S mix:
iex(1)> Enum.map(:code.all_loaded, &elem(&1, 0)) |> Enum.map(&to_string/1) |> Enum.filter(&String.starts_with?(&1, "Elixir.Phoenix.HTML.Safe.Calendar"))
[]

When I run it with rel/<app>/bin/<app> console:
Enum.map(:code.all_loaded, &elem(&1, 0)) |> Enum.map(&to_string/1) |> Enum.filter(&String.starts_with?(&1, "Elixir.Phoenix.HTML.Safe.Calendar"))
["Elixir.Phoenix.HTML.Safe.Calendar.DateTime"]

But only after I used it once. Otherwise it is empty. I tried using it with iex, but then it gives an error.

I've been digging deeper. I noticed that it has to do with consolidation. When I check the consolidated file it shows that the implementation is still there.
While in the _build directory, it is gone.

@ThijsWouters What's the path to the consolidated file you're checking?

In rel/<app>/lib/consolidated/Elixir.Phoenix.HTML.Safe.beam the implementation is present.
In _build/prod/consolidated/Elixir.Phoenix.HTML.Safe.beam the implementation is not present.
These are built from the same version of my application.
Btw, I am building both with MIX_ENV=prod.

@ThijsWouters rel/<app>/lib/consolidated is no longer the correct path for consolidated beams. They are now placed in each application's lib directory, so rel/<app>/lib/<some_dep>/. The reason for this is that upgrades/downgrades have to use the correct version of the consolidated beams, and this wasn't possible when they lived in lib/consolidated.

@bitwalker I've created a repro w/ steps. https://github.com/smdern/exrm_moving_module_repro/tree/master


Add labels

It would be nice add labels to the expanded FABs.

https://callstack.github.io/react-native-paper/docs/components/FAB/FABGroup

Sorry for the delay in replying.
Since children is an array of widgets, you can place any widget you like, not limited to FloatingActionButton.
You can also include labels by doing the following.
floatingActionButton: ExpandableFab(
  key: _key,
  type: ExpandableFabType.up,
  childrenAnimation: ExpandableFabAnimation.none,
  distance: 70,
  overlayStyle: ExpandableFabOverlayStyle(
    color: Colors.white.withOpacity(0.9),
  ),
  children: const [
    Row(
      children: [
        Text('Remind'),
        SizedBox(width: 20),
        FloatingActionButton.small(
          heroTag: null,
          onPressed: null,
          child: Icon(Icons.notifications),
        ),
      ],
    ),
    Row(
      children: [
        Text('Email'),
        SizedBox(width: 20),
        FloatingActionButton.small(
          heroTag: null,
          onPressed: null,
          child: Icon(Icons.email),
        ),
      ],
    ),
    Row(
      children: [
        Text('Star'),
        SizedBox(width: 20),
        FloatingActionButton.small(
          heroTag: null,
          onPressed: null,
          child: Icon(Icons.star),
        ),
      ],
    ),
    FloatingActionButton.small(
      heroTag: null,
      onPressed: null,
      child: Icon(Icons.add),
    ),
  ],
),


Integrate PGVector as a VectorStore

Allow using Postgres+PGVector as VectorStore
PGVector is Open-source vector similarity search for Postgres.
It comes with pgvector-java support.

Resolved with #15


[WIP] Remove now that qpid is unsupported! :heart:

Depends on: https://github.com/ManageIQ/manageiq/pull/4291
cc @blomquisg

cc @simaishi

so much joy :sob:


Android 6.0 permissions

Hi, would you mind do add support to Android 6.0 permissions in your sample?
Thanks.

Hi, when I find some time I will look into that. Though, if you open the camera for the first time after deploying the app it already ask for permission. I've seen the app crashing when using the image picker option before using the camera (and giving permissions) though. This is because the image picker requires the same permission as the camera but doesnt show the popup asking for the permissions like the camera does.
So if you give permissions to the camera and then use the Image Picker it should work.

Hi. I've updated my file-transfer-upload example the ionic native file transfer plugin. See this release. Still no permission popup for when using the image-picker though. But when using the camera on 6.0 it asks for the required permissions.

Solution is here: https://github.com/apache/cordova-plugin-file-transfer/pull/150

Hi, I know its been a while. But the app has been updated to the latest ionic framework in this brand new app release. The latest Ionic Native plugins are used and they include a permission check for android 6.0+.


[backport v2.8] Rancher monitoring chart is failing with error unknown flag: --logtostderr on rancher-monitoring-prometheus-adapter

Issue created to track the backport of https://github.com/rancher/rancher/issues/46919 to v2.8

Retest passed : Rancher monitoring chart rancher-monitoring:103.2.0-rc.1+up57.0.3 successfully got installed without any failure or error.
Details
rancher : v2.8.9-alpha10
monitoring : rancher-logging:103.1.3-rc.1+up4.8.0
Cluster : RKE2


Implement Value Caching and Diffing for Optimized Change Detection

This pull request introduces value caching and diffing mechanisms to optimize change detection. By caching previous values and diffing them against current values, we ensure that only the property that has changed is passed to the callback function as discussed in #1
Changes

Added a value caching system to store previous state values
Implemented a diffing algorithm to efficiently compare current values against cached values
Modified callback functions to receive only the properties that have changed, based on the diffing results

@faizanu94 I’m not sure if you are looking for a review yet or not, but here goes: the core of this PR looks really good.
The only thing that is missing is a flag to get back the old behavior, where an author can choose between getting only these changedProperties (default behavior) or getting back all the monitored properties.
The logic for that is similar to the flag you wrote in #1.
(Once this PR is in, we can pick up #1 again to let users choose between the current simple format, or the more rich format)

Thanks for the reminder about taking care of the old behavior - I’ve added the flag observeAllProperties to toggle between the old and new behaviors, and updated the README accordingly. All set now!

I’ve added the flag observeAllProperties to toggle between the old and new behaviors, and updated the README accordingly. All set now!

Instead of a boolean here, this needs to be the { callbackMode: CallbackMode.INDIVIDUAL } that you introduced in #3. Maybe a better name would be NotificationMode.

Thanks for the feedback! I've replaced the boolean flag with NotificationMode as suggested, using NotificationMode.INDIVIDUAL and NotificationMode.ALL. This approach can easily scale to other options like ReturnFormat in the future. README has been updated accordingly

Thanks for the suggestions - I’ve applied the changes. Appreciate the guidance!


Add a Formsy.values prop to set all initial values of the form

Let's say I am Editing an object. The object already exists and I want to provide a form to modify its values.
It would be nice if I could simply inject all the values at once using a value or values prop on the parent form.
Right now I think I would have to set the value of each individual fields. This could still be possible, but if value props is not provided on a field, a default one from the parent form's 'values' prop would be used.

+1 this will be nice.

+1

Makes sense, let me add it to next release, https://github.com/christianalfoni/formsy-react/issues/206


Add ES11/Babel private accessors

Is your feature request related to a problem? Please describe.
#1 - Looks like private accessors aren't working as expected. Updating deps/installing plugins causes others to be out of date
Describe the solution you'd like
Private accessor transpile works
Describe alternatives you've considered
leaving it at _method for now is fine
Additional context
n/a

should be working now.
pseudo methods _method( should be converted to #method( if possible. cc @andymoody
closing issue


"No module named ibm_db_dbi"

Hi,
I cannot use your module since I get an main error. I took this is from your documentation
from sqlalchemy import create_engine
e = create_engine("db2+ibm_db://user:pass@host[:port]/database")

but get this error
Traceback (most recent call last):
  File "ibm_db2_test3.py", line 2, in <module>
    e = create_engine("db2+ibm_db://user:pass@host:1111/database")
  File "/usr/lib/python2.7/dist-packages/sqlalchemy/engine/__init__.py", line 386, in create_engine
    return strategy.create(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/sqlalchemy/engine/strategies.py", line 75, in create
    dbapi = dialect_cls.dbapi(**dbapi_args)
  File "/usr/lib/python2.7/dist-packages/ibm_db_sa/ibm_db.py", line 58, in dbapi
    import ibm_db_dbi as module
ImportError: No module named ibm_db_dbi

I can also use another engine (or same kind of alias)
from sqlalchemy import create_engine
import ibm_db_sa.ibm_db
e = create_engine('ibm_db_sa://user:pass@host:1111/database')

with the same error. The system has the follwing properties:

Debian Linux Strech 64bit
Python 2.7 (as you see from the errors) in version 2.7.13-2 via apt
Your lib is installed via apt as 'python-ibm-db-sa ' in recent version 0.3.0-3
sqlalchemy via apt in version 1.0.15

Searching for "No module named ibm_db_dbi" via google shows some guys with the same problems but no real solution. Do you think that the Debian package is some kind of broken?

@keynator  Can you share your pip list please.TIA

I have not used pip before but now installed pip and then did
pip install ibm_db_sa
pip install ibm_db

but before removed the debian package python-ibm-db-sa . Now it does work.


Minor Integ Test and Jenkins Improvements

Description

Creates a vars folder at the root level for the Jenkins shared library. This is required to load the shared library dynamically and makes branch testing much easier.
Minor fixes from running integ_tests library

Issues Resolved
N/A
Is this a backport? If so, please add backport PR # and/or commits #
Testing
N/A
Check List

[ ] New functionality includes testing

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Should these be able to execute now? Can we update the CI workflow to exercise them?

We can execute them in our Jenkins pipelines, but our docker setup still doesn't have support for RFS or starting/stopping the Replayer


Support bitmap in jdbc

Hi, I'm looking for a solution to insert bitmap into clickhouse through clickhouse-jdbc. However, it seems there's no interface for it. Can we support that?

Please check https://github.com/ClickHouse/ClickHouse/issues/16798

Please check https://github.com/ClickHouse/ClickHouse/issues/16798

Duplicate of #422

Duplicate of #422


when use GroundingDINO as the detector

Hi . I want to know when you use the box from the GroundingDINO as the prompt, if only boxes greater than the threshold are used as input？

hi, please check out evaluation script here

yes, when visualization we only show the bboxes higher than the threshold; when computing AP for quantitative evaluation, we take the top100.


Addressing multiple issues for v10.0.0. Fixes #126, #136, #171, #174.

Renamed decimalValue to numericValue
Changes to Person, including name and hasBirthDate
Refactored network connections, renaming properties and tightening up their definition
Clarified definition of ContemporaneousEvent

Tagging @Jamie-SA for numericValue, the usual suspects for the rest.

@sa-bpelakh Need to resolve conflicts in release notes.


Toggle Passphrase GUI

Adds a "Toggle Passphrase" button to the GUI, enabled for Trezor and Keepkey devices (0075e7f).
This PR also fixes Keepkey error where the command finished with an error message while it should have told the user to use sendpin to confirm the change, since unlike Trezor, Keepkey requires to send the pin to confirm the change of device settings (ff6cdfa).

ACK 0075e7fde2c9bf904035490bdefe2399a6e3bfd8


Remove check-docforge

What this PR does / why we need it:
Removes check-docforge from unit tests
Part of https://github.com/gardener/gardener/pull/8692
Special notes for your reviewer:

/approve


Revert "constrain WorldQuery::init_state argument to ComponentInitial…

…izer (#13442)"
This reverts commit 5cfb063d4ae4b6abb40c3e7d2c7752a68ab5eb3d.

This PR broke bevy-trait-query, which needs to be able to write a resource in init_state. See #13798 for more details.
Note this doesn't fix everything as transmutes for bevy-trait-query will still be broken,. But the current usage in that crate is UB, so we need to find another solution.

This should reopen #13358 on merge.
This was initially done to make the trait design consistent, so it is fine to revert for now.


composer.json and package.json should be in the root directory

Hi folks,
could you please move composer.* and package.json to the root of the app?
You can always adjust the vendor dir:
{
  "config": {
    "vendor-dir": "web/concrete/vendor"
  }
}

Having it in the root enables a flow of

git clone
composer install
npm install

Services like Heroku or CloudFoundry detect the type of app based on these files, and they run composer install on push in the root directory of an app. It's common practice :)

I think this makes sense until we can get around to really getting into #360. Honestly this might be the next best thing....

Hi All,
I'm just using composer to install bootforms's library
(Easy forms for bootstrap's compatibility - https://github.com/adamwathan/bootforms)
In my root:
me$ composer require adamwathan/bootforms
Now, I have got well a new folder in my root: vendor
(In it : Folder adamwathan + folder composer + autoload.php)
Now, I want to use it...
But this code in my page:
BootForm::text('First Name', 'first_name')->placeholder('John Doe');
(As you see, with 'façade')
But this gives:
Class 'BootForm' not found
Of course, I try to override providers and put in my application/config/app.php :
return [
'providers' => [
\AdamWathan\BootForms\BootFormsServiceProvider'
]
];
Can someone be simple to explain the good way ?
Note: I use the fantastic (but hard to understand if english is poor as for me) <IP_ADDRESS> version.

this doesn't work well at the moment, check these issues for more information:

https://github.com/concrete5/concrete5-5.7.0/issues/360
https://github.com/concrete5/concrete5-5.7.0/pull/2087

concrete5 keeps all the autoloader stuff in the core which makes it impossible for you to extend. You can create an additional composer.json but you'll have to include the autoloader in a package startup method. But please note that you'll soon have other problems because if you use a library which has a dependency which is part of the core things will start to break.
Imho the only option is to fix the problem mentioned in the issues above..

Thanks, Remo, for your answer
I try lot of things and effectively, I can't succeed in make my own serviceprovider + facade/alias
I'm very sad to read it's seems impossible...
Imagin the number of excellent libraries... And all this potential lost...
I.E., with BootForm, only taping this:
BootForm::select('Color', 'color')->options(['red' => 'Red', 'green' => 'Green'])->select('green');
gives:

Color

Red
Green

...
Another question: Will you update your book, for the v5.7+ :-) ?

Well, it is possible, but you'll have to include the autoloader manually and create class aliases yourself. Not a big deal, but pretty hacky...
No I'm afraid, there are no plans to update my book for 5.7 at the moment.

Ah :-) !
Good ! Tanks for this good news and I will go on to try to have my own serviceprovider + façade (y) (For libraries or other) !
For your book, I understand it's perhaps too early to decide to publish the update or not...
Again thanks for your last post, and to soon !


Thorchain client refactor

Thorchain client migration to use the cosmos-sdk package as its foundation:
Breaking changes:

getPrivateKey is now async and response is Uint8Array type
getPubKey is now async and response is Uint8Array type
getDepositTransaction is deprecated in favour of getTransactionData
fetchTransaction removed
setClientUrl removed
getClientUrl removed
setExplorerUrls removed
getCosmosClient removed
setNetwork removed
setChainId removed
getChainId removed

With this new commit, client uses the cosmjs function and it is compatible with old packages versions


Refactored pmu logic - Added support for recorder type. Refactored lo…

…gic to track pmu count to PMUCtrl module

Codecov Report

Merging #13 into master will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   59.85%   59.98%   +0.12%
==========================================
  Files          79       79
  Lines        5498     5498
==========================================
+ Hits         3291     3298       +7
+ Misses       2207     2200       -7

Impacted Files
Coverage Δ

scripts/lib/xpedite/txn/extractor.py
87.5% <0%> (+0.96%)
:arrow_up:

scripts/lib/xpedite/txn/loader.py
67.26% <0%> (+3.57%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2809aba...b997a7d. Read the comment docs.


serialize.js: Node.nodeName uses uppercase

At least in HTML5, see http://ejohn.org/blog/nodename-case-sensitivity/

Thanks!


Promote the Qdrant extension to native mode

Describe the feature here
https://github.com/apache/camel/tree/main/components/camel-qdrant

Hello @aldettinger: FYI there's now a testcontainer for Qdrant. cf https://issues.apache.org/jira/browse/CAMEL-20612


Ft edit product view

Currently Blocked from being completed by the inventory being broken
Description
View to edit created products
Required Functionality

[ ] On arrival fields are pre-filled based upon object
[ ] Delete button removes the item from DB, confirms with a message and pushes the user to the dashboard
[ ] Save button does a PUT to the DB, updates the object, and based on status shows a message.

Link to Trello card
https://trello.com/c/w8REsvSf/84-edit-product-view

Looks great, no noticeable bugs, just some quick changes then you'll be good to go, first please remove where it says "Create Product", and also try moving down the rest of the form. (This might turn into a chore, but the main thing I want you to do is to remove that create product text

All of the functionality seems to be working as intended. Those animations are awesome!


docs: getting started guide is truncated at the beginning

Just a quick note so we don't forget: The getting started guide got truncated somehow, it literally starts with "Then ..." :rofl:

Fixed


File Locksmith: Path scrollbar blocks path text

Microsoft PowerToys version
0.70.0
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
File Locksmith
Steps to reproduce
In Windows 11, use File Locksmith to open a file with a long path, then click on the file name in the top left corner. Under "Selected file paths" the scrollbar obscures the text.
✔ Expected Behavior
Scrollbar will not obscure the text.
❌ Actual Behavior

Other Software
No response

Reproducing this, I believe the behavior is now different (not fixed, still), it just truncates the path now if it too long which in a way is worse.

This has been worked on during the 0.80 release cycle.
Please update to the latest release: https://github.com/microsoft/PowerToys/releases


Dropdown menu is no dropdown anymore

Since I have installed yard-cucumber (and it really is nice, thank you!), the dropdown menu on the upper right (with Features, Tags, Steps, etc.) doesn't drop down anymore but it loads a new page with the dropdown content. Any idea why this happens? Thanks.

I am also seeing this problem. It's very bothersome. I thought it might have something to do with another javascript error I'm getting in the console
ReferenceError: hasFrames is not defined

It looks like it's a problem with serving with yard server vs opening the files manually


SQL Queries and Sub Queries

Description
Description

About Queries, syntax, example
About Sub Queries, syntax, example

Domain
Database
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

First thing query means what have your doubts or we can say  A request for data or information from a database table combination of tables here many features are involved like CREATE, UPDATE,INSERT,DELETE ALTER ete

documentation/


Add support for sqflite

:scroll: Description

:bulb: Motivation and Context
Closes https://github.com/getsentry/sentry-dart/issues/1201
:green_heart: How did you test it?
:pencil: Checklist

[ ] I reviewed submitted code
[ ] I added tests to verify changes
[X] No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
[ ] I updated the docs if needed
[ ] All tests passing
[X] No breaking changes

:crystal_ball: Next steps

I'm not using sqflite but the approach looks reasonable to me (The app I'm working on sadly uses Hive for our offline storage needs)

I looked at sqflite/src and it makes sense to me, but I don't have a comparison with the implementations on the other platforms.

@krystofwoldrich @brustolin ready for final review


Direct Messages - Step 4: Modify Datastore to store a recipient.

PR:
https://github.com/FluffySheep/CodeU2019-Team28/pull/15

PR 15 was merged to develop. Closing this issue.


I need Some further Instruction to perform the chat-with-PDF

I need Some further Instruction to perform the chat-with-PDF repo , as followed i pasted my errors , why this project needs Gcloud Authentication , it lot n lot stuf , i need some help to do this !
Microsoft Windows [Version 10.0.22631.4602]
(c) Microsoft Corporation. All rights reserved.
C:\Users\subinesh\Downloads\Chat-with-PDF>streamlit run main.py
You can now view your Streamlit app in your browser.
Local URL: http://localhost:8501
Network URL: http://<IP_ADDRESS>:8501
2024-12-18 15:41:51,250 - INFO - API key submitted successfully.
2024-12-18 15:41:56,429 - INFO - Successfully extracted text from REFOO - REPORT F .pdf.pdf
2024-12-18 15:41:56,429 - INFO - Text successfully split into chunks
2024-12-18 15:41:56,429 - DEBUG - Checking None for explicit credentials as part of auth process...
2024-12-18 15:41:56,429 - DEBUG - Checking Cloud SDK credentials as part of auth process...
2024-12-18 15:41:58,163 - DEBUG - Making request: POST https://oauth2.googleapis.com/token
2024-12-18 15:41:58,163 - DEBUG - Starting new HTTPS connection (1): oauth2.googleapis.com:443
2024-12-18 15:41:58,460 - DEBUG - https://oauth2.googleapis.com:443 "POST /token HTTP/11" 200 None
2024-12-18 15:41:58,898 - ERROR - Error creating or saving vector store: Error embedding content: 403 Request had insufficient authentication scopes. [reason: "ACCESS_TOKEN_SCOPE_INSUFFICIENT"
domain: "googleapis.com"
metadata {
key: "service"
value: "generativelanguage.googleapis.com"
}
metadata {
key: "method"
value: "google.ai.generativelanguage.v1beta.GenerativeService.BatchEmbedContents"
}
]
2024-12-18 15:41:58,898 - INFO - PDFs processed successfully.
2024-12-18 15:42:12,708 - DEBUG - Simplified question: what is the main topic here
2024-12-18 15:42:12,708 - DEBUG - Simplified question: what is the main topic here
2024-12-18 15:42:12,708 - DEBUG - Checking None for explicit credentials as part of auth process...
2024-12-18 15:42:12,708 - DEBUG - Checking Cloud SDK credentials as part of auth process...
2024-12-18 15:42:13,615 - DEBUG - Environment variable FAISS_OPT_LEVEL is not set, so let's pick the instruction set according to the current CPU
2024-12-18 15:42:13,615 - INFO - Loading faiss with AVX2 support.
2024-12-18 15:42:13,646 - INFO - Successfully loaded faiss with AVX2 support.
2024-12-18 15:42:13,662 - ERROR - Error retrieving relevant context for question 'what is the main topic here ': Error in __cdecl faiss::FileIOReader::FileIOReader(const char *) at D:\a\faiss-wheels\faiss-wheels\faiss\faiss\impl\io.cpp:68: Error: 'f' failed: could not open faiss_index\index.faiss for reading: No such file or directory
2024-12-18 15:42:13,662 - ERROR - Error handling user input: 'NoneType' object is not iterable

I've Completed Your Project with some little changes

No Need For Authentications , Service Acc , Scopes etc,.
Used Gemini AI model="gemini-pro" .

Check My Repo : The-Whiz-Guy/Ask_Anything_From_This_Doc

To run this project locally on your machine, you will need to make a few adjustments. Specifically, you will lose the API key input feature in UI, but you can work around this by creating a file named .env and defining the GOOGLE_API_KEY=your_gemini_api_key variable with your actual API key. Additionally, you will need to make some changes to the main function in your code.
def main():
    st.set_page_config(page_title="TSR")
    st.header("Chat with PDF")
    user_question = st.text_input("Ask a Question from the PDF Files")

    if user_question:
        user_input(user_question)

    with st.sidebar:
        st.title("Menu:")

        load_dotenv()
        genai.configure(api_key=os.getenv("GOOGLE_API_KEY"))

        pdf_docs = st.file_uploader("Upload your PDF Files", accept_multiple_files=True, type="pdf")
        if st.button("Submit & Process PDFs"):
            if pdf_docs:
                with st.spinner("Processing PDFs..."):
                    raw_text = get_pdf_text(pdf_docs)
                    text_chunks = get_text_chunks(raw_text)
                    get_vector_store(text_chunks)
                    st.success("PDFs processed successfully!")
            else:
                st.error("Please upload PDF files to process.")

I've Completed Your Project with some little changes

No Need For Authentications , Service Acc , Scopes etc,.
Used Gemini AI model="gemini-pro" .

Check My Repo : The-Whiz-Guy/Ask_Anything_From_This_Doc

That's quite impressive! I'm glad you enjoyed the project. I'd be happy to connect on Discord or LinkedIn. I'm currently working on a new project, and I think it could be a great opportunity for us to collaborate.

👍


Update for sponsorship migration and JupyterLab 4

This is yet another part of the sponsorship migration.
Related pull requests cross-linked at: https://github.com/WorldWideTelescope/worldwidetelescope.github.io/pull/88
Including README updates that never made it onto GitHub.

Ah, yes, we need to update this for JupyterLab v4 while we're at it! There's a lot of meta-stuff to deal with but I believe that we don't need much in the way of deep code changes.
I am choosing to drop support for the 2.x and 3.x series of JupyterLab here; I'm not sure how easy it would be to maintain simultaneous compatibility, and this package evolves slowly enough that it feels OK to have new releases jump their requirements.


Add Polish UI translations

Description
This PR adds Polish translations and fixes one minor typo in the i18n schema.

I've been on a fence with a few translations, here's what I am choosing and why:

search.shortcutLabel: (Naciśnij /, aby wyszukać) – the comma after the slash looks weird, but that's the rule in Polish. I've been thinking about:

Naciśnij / i szukaj ("Press / and serach"), but it's not better, as there are two single characters next to each other.
Aby wyszukać, naciśnij / – I can't tell if it's less or more visually annoying, and it sounds weird. It also conveys the

search.devWarning: uruchomić aplikację literally means "run the app". "previewing the site" doesn't translate well, and I think it could cause confusion.
page.previousLink: I added "page" to the word "Previous", as in Polish we decline adjectives according to nouns they go with, and leaving just "Poprzednia" / "Poprzedni" / "Poprzednie" implies the gender anyways, and it's rather rare to see it on the Polish websites. The same goes for nextLink.
aside.danger: That was the worst to translate, because direct translations of niebezpieczeństwo and zagrożenie are both strongly charged words (prime definitions regard a threat of hurting or offing someone), so I went with "ważne" – "important", which I've seen in other wikis to be used for aside red sections as well.

Hello! Thank you for opening your first PR to Starlight! ✨
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any issues you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.


Added clang-format and new option to format after document save.

Added clang-format for C/C++ language and introduced new option to automatically format a document after save if the the following config is set:
config.format_on_save = true

Also imported the reload_doc function from the autoreload plugin to reload the document after a format since sometimes it wasn't been reloaded.

The code looks good, I'll test it and merge tonight or tomorrow.

looks good. merged


Where to set locales in Next

Hi,
I've installed the latest CockpitNext and I'm evaluating it, after a brief evaluation of the old Cockpit.
I've noticed that fields in collections can be localized also in Cockpit Next, but I don't see how to set the locales used in my site.
The documentation refers to Cockpit older-version, since the Settings don't have a Locale tab or the like.
Anybody can help me?
Thanks

Hi,
you need to create a config file: config/config.yaml then define your additional languages like so:
languages: [fr,de,en]

Greets,
Artur

Thanks, it works!
Can be done from interface via Settings / Settings (editing the YAML file on line)

👍🏻

Just an afterthought, can we get rid of the "default" language, or your suggestion is to use the default as the main language of the site?
As an example, I plan to write my site (btw, to be staticized with Hugo or Jekyll) in English and Italian.
In the config.yaml file I've put languages: [it,en] and now when I edit an entry in a Collection, if the field is localizable,  I have the choice between "default", "italian" and "english".
Is there a way to make one of the two language the "default", or the solution is maybe to specify:
languages: [en] and simply treat Italian as the default language (I'm italian as you may have guessed)
Thanks

right, default should be your primary language.

Ok, makes kinda sense. Really closed now :)


[$1000] Web -  Heading after quote is not rendering

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go a chat and add a comment

> quote
# heading

Notice that heading is displayed in plain text

Expected Result:
Heading should be rendered
Actual Result:
Markdown heading syntax is not rendering
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.32-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/8626f832-2e3e-4705-9f42-59b82d7d7172
https://github.com/Expensify/App/assets/93399543/7f95a2a1-6c96-4a48-afbe-712edae38043
Expensify/Expensify Issue URL:
Issue reported by: eh2077
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687921581684809
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e498007bd2f0de5b
Upwork Job ID:<PHONE_NUMBER>139329024
Last Price Increase: 2023-06-29

Proposal
Please re-state the problem that we are trying to solve in this issue.
heading in the new line in "quote" section is not formatted.
What is the root cause of that problem?
The root cause is in this function.
ReportUtils.getParsedComment / ExpensiMark.replace()
The replace function applies rules to convert the text as HTML.(convert markdown characters to HTML tags)

There are several rules.(not all markdown, ex: There is no heading2, heading3 rules, etc)

Reason1:
 is applied to only the first line.
image1 is the sample text, image2 is the replaced text. so the heading text in the 2nd line is outside of the blockquote.

Reason2:
heading1 rule does not work by lines(regarding the new line tags)
It means:  Even if we fix the reason1, it will have an issue still like the example.
When sending this text "> # heading1\n# heading again", it should be replaced like
"heading1heading again"
but the result is:

What changes do you think we should make in order to solve the problem?
So the solution has 2 steps:
Step1( for reason1) -
if the blockquote ">" should be applied on the multiline text, then we should apply the "new line" rule before applying the  rule. So  should wrap the full text, not the first line.
Step2(for reason2) - heading1 rule should consider a new line tag.
What alternative solutions did you explore? (Optional)
N/A

I reproduced on OSX desktop and  too. Given that this is markdown, we can probably assume it's affecting all platforms.

I see this previous discussion, but it doesn't look entirely similar as that was for whitespace on a single line (and this is multi-line, where only one is a block quote)

Please check my proposal kindly.
https://github.com/Expensify/App/issues/21846#issuecomment-1612307209
Thank you.

@spcheema Thanks for the proposal. Your RCA is about right. The new line seems to be lost in modifyTextForQuote but not in formatTextForQuote, not a blocker though. However I think the solution can be improved. Can't we just move the heading1 rule to be before quote? This will make the input that we pass to modifyTextForQuote already have the heading tag handled and avoid the problem.

@code0406 Thanks for the proposal. I don't think your RCA is correct:

 is applied to only the first line.

This is expected, the blockquote will only be applied to lines that start with >, for new lines if they don't start with > then the block quote tag won't be applied.

@code0406 Thanks for the proposal. I don't think your RCA is correct:

 is applied to only the first line.

This is expected, the blockquote will only be applied to lines that start with >, for new lines if they don't start with > then the block quote tag won't be applied.

okay. if that is the requirement, I can skip the new line tag problem.
let me update my comment.
I have a question to clarify. Even though the second line is not blockquote, should the heading1 style be formatted?
Looking forward to hearing from you.
Thank you.

@code0406

Even though the second line is not blockquote, should the heading1 style be formatted?

Yes, we should always format such styles, this has nothing to do whether the text is inside a quote or not. Please update your proposal and tag me again.

@spcheema Oops we just inverted the bug :sweat_smile:. I don't think we should go with option 1 for now, it's better to find a solution that does not involve making one rule aware of the other, let's make that our last resort solution. Please update your proposal and tag me again.

Proposal
[Updated]https://github.com/Expensify/App/issues/21846#issuecomment-1612307209
@s77rt

@code0406

Even though the second line is not blockquote, should the heading1 style be formatted?

Yes, we should always format such styles, this has nothing to do whether the text is inside a quote or not. Please update your proposal and tag me again.

Perfect. all clear now.
I updated my comment. and tagged you.
Thank you.

@code0406 Thanks for the update but your RCA is still incorrect.

@code0406 Thanks for the update but your RCA is still incorrect.

sorry about it, I think. I submitted the best solution including the video where the issue was fixed.

@spcheema Thanks for the update. The suggested solution also makes one rule aware of the other. Maybe we have better chances fixing the edge case after changing the order of rules.

@code0406 I'm referring to the root cause of the problem, it was not updated. Besides the solution of changing the order of rules is not complete as we have some edge cases where parsing does not work as intended as highlighted by @spcheema here https://github.com/Expensify/App/issues/21846#issuecomment-1613895345.

@spcheema I understand the solution, just looking for more alternatives. I see that the heading1 rule also captures the newline \n. Maybe we can remove that and adjust what needs to be adjusted accordingly e.g. # hi\n should still be parsed as
hi<\h1> and not
h1<\h1>

@code0406 I'm referring to the root cause of the problem, it was not updated. Besides the solution of changing the order of rules is not complete as we have some edge cases where parsing does not work as intended as highlighted by @spcheema here #21846 (comment).

as you can see here. I explained the reason(root cause) here.
If you didn't check it. then I can update it. add the text in the first line.

@code0406 I don't see how that's correct, the new line is not replaced with
. The new line char is just lost in modifyTextForQuote where textToCheck is split on newlines (and we don't add it back building replacedText).

@spcheema The heading rule captures the new line, that's why # hi\n is parsed as
hi
. That's intended but cause a problem in case we want to go with the switch order of rules approach.
What I meant to say is that there may be this approach to explore

Change order of rules, heading1 before quote
Make the heading rule not capture the newline i.e. change regex to: /^# +(?! )((?:(?!
|\n|\r\n).)+)/gm (this will fix the mentioned edge cases)
But now we have a regression  # hi\n is parsed as
hi

 which is an unwanted behaviour

@code0406 I don't see how that's correct, the new line is not replaced with
. The new line char is just lost in modifyTextForQuote where textToCheck is split on newlines (and we don't add it back building replacedText).

ah, I understand what was missed.
Let me explain why it's the root cause.

The reportComment where the new line tag "\n" was changed is from "ReportUtils.buildOptimisticAddCommentReportAction()" function.

and it is from ExpensiMark().replace() function like this:

this function applies the rules.

the order of rules is like this:

'quote' and 'heading1', and it is applied by the order in the for loop.
so the new line tag "\n" was replaced with "".
This is the root cause. So I shared the fixed video. It proves my root cause is right.
I hope this is clear to understand.
Looking forward to hearing from you.
Thank you.

@code0406 Thanks for the update. I still don't think that's the correct root cause. Even if the proposed solution is okay, this does not necessary mean that the root cause is correct. But again the solution does not work well with cases like: > a\n# da\n> test
Expected:

a

da

test

Got:

a

da
> test

@spcheema That was just an approach that I suggested to explore hoping for it to be an inspiration for better solutions. I think  we are still looking for better solutions here.

@code0406 Thanks for the update. I still don't think that's the correct root cause. Even if the proposed solution is okay, this does not necessary mean that the root cause is correct. But again the solution does not work well with cases like: > a\n# da\n> test
Expected:
a

da

test

Got:
a

da
> test

So I suggested an alternative solution. Of course, we should update the regex in the rules. but I think the root cause based on the current code is right.

@code0406 I think the alternative solution is suggested by @spcheema already. For now we are looking for better solutions

@code0406 I think the alternative solution is suggested by @spcheema already. For now we are looking for better solutions

okay. I will share the better solution soon.

@spcheema

I believe checking next tag is heading a better approach

I'm sorry, can you please clarify which approach is that exactly?

@spcheema This results in extra
, testing with > a\n# da\n> test
Expected:

a

da

test

Got:

a

da

test

@code0406 Thanks for the update. I still don't think that's the correct root cause. Even if the proposed solution is okay, this does not necessary mean that the root cause is correct. But again the solution does not work well with cases like: > a\n# da\n> test
Expected:
a

da

test

Got:
a

da
> test

So I suggested an alternative solution. Of course, we should update the regex in the rules. but I think the root cause based on the current code is right.

I found a good solution in my direction.
Let me share the detail. Meanwhile, please check the fixed screen in the following video.
Thank you.
https://drive.google.com/file/d/1W0G2M_mPHwImeS5lNQUXv9mQjNNxNsFT/view?usp=sharing

@code0406 Thanks for the update. I still don't think that's the correct root cause. Even if the proposed solution is okay, this does not necessary mean that the root cause is correct. But again the solution does not work well with cases like: > a\n# da\n> test
Expected:
a

da

test

Got:
a

da
> test

So I suggested an alternative solution. Of course, we should update the regex in the rules. but I think the root cause based on the current code is right.

Please check my solution again. I explained it more detail.
https://github.com/Expensify/App/issues/21846#issuecomment-1612307209
Thank you.

@code0406 Thanks for the update. I think that solution is more complicated than it should be.

@spcheema Thanks for the update. I think if we want to add new rules to take care of the extra
 then the switch order solution is cleaner since it does not make one rule aware of the other.

Move heading1 rule to be before quote
Modify heading1 rule to not capture the newline: /^# +(?! )((?:(?!
|\n|\r\n).)+)/gm
Add replaceh1br and replacebrh1 rules (pretty similar to replacepre and replacebr)

I have also being checking with altering the heading regex approach. It's a one line change solution that works but I think it's better to avoid that approach for now. Also I'm not sure how well the lookbehind assertion is supported
/(?<=<\/blockquote>|^)# +(?! )((?:(?!
|\n|\r\n).)+)\n?/gm

@code0406 Thanks for the update. I think that solution is more complicated than it should be.

just need to change the rule order, and update 2 lines.

change rule order (heading1->qoute)
do not remove the "\n" tag in the heading1 rule.
do not add the "\n" tag in the modifyTextForQuote function.

Explained enough reason.
That's all.
Thank you for your considering my solution.

@code0406 I don't think we should modify heading1 rule the way you did, we don't need to add the line break on every match (it will cause unnecessary line breaks), we should just remove it from the regex not to be captured. Also I would prefer to keep modifyTextForQuote untouched, it feels awkward to have this function check for
 tag.

@spcheema Thanks, that should do it. But let's try get this even better. Maybe we can explore another solution that does not involve adding new rules.

@spcheema I understand that. Usually such regex issues can be fixed in many ways, the best way often requires an out of the box thinking, I just don't want to miss that :sweat_smile: but we have good solutions already so we will most likely choose a solution this week.
Can you please add the "modify heading1 regex to conditionally capture the new line" approach to your proposal (in alternative solutions section)

@code0406 I don't think we should modify heading1 rule the way you did, we don't need to add the line break on every match (it will cause unnecessary line breaks), we should just remove it from the regex not to be captured. Also I would prefer to keep modifyTextForQuote untouched, it feels awkward to have this function check for
 tag.

It's a perfect solution based on the logic and principle of the "heading1 regex", modifyTextForQuote, and heading1 ui panel format. Let me consider a more look-good approach.

@code0406 and @spcheema Thank you for your continuous work here. I think we can go with @spcheema's proposal.
:ribbon: :eyes: :ribbon: C+ reviewed

This was just assigned to contributors, so it's not overdue

@cead22 @s77rt PR is up for review Expensify/expensify-common#557

@spcheema this is merged now

The PR that introduced the bug has been identified: This existed since day one https://github.com/Expensify/expensify-common/pull/468
The offending PR has been commented on: https://github.com/Expensify/expensify-common/pull/468#discussion_r1264522145
A discussion in #expensify-bugs has been started: I don't think this is needed here, the automatic tests should be enough to prevent such bugs.
Determine if we should create a regression test for this bug: No

I will check in on is one, and confirm before paying. I'm OoO on Monday and Tuesday, and will be back to this on Wednesday 26th with confirmation

Not overdue per @conorpendergrast 's update above

@cead22 and I agree with an exception here as the C and C+ acted with urgency.
Everyone has been paid accordingly, and contracts ended. We're all done, thanks!


Discuss: don't dispatch tbuffer in CameraBuf::accquire

I don’t think we can call tbuffer_dispatch in CameraBuf::acquire. we still use this buffer(cur_rgb_buffer) at somewhere else such as  camera_process_frame(),dispatch it earyly may cause problems(Maybe the UI will also hang).
@ZwX1616  am I right?
related PR: https://github.com/commaai/openpilot/pull/2613

This is going away in #2668.


Sanity check the build flag

Sanity check the build flag

@dmitrig01
A handful of miscellaneous things. Please see inline comments for details.

Not sure if this is what you had in mind, PTAL @dmitrig01

:+1:


configure issue

If following the instruction in README, I got
% ./configure
./configure: line 61: ucc not found: command not found
./configure: line 62: -E: command not found
dirname: missing operand
Try 'dirname --help' for more information.
dirname: missing operand
Try 'dirname --help' for more information.

It is fixed with ucc compiler, which I doesn't have. Nonetheless, I have no problems to build directly with make and the game runs properly.
And the binary is built at /tmp/$USER/make/gjid/gjid, that's kind of strange to me.

Fixed by commit 68af2b97478a5403e09d1b154ec7edfab33f0147.
I really have to figure out some way to synchronize these configure scripts between projects. Each project ends up with its own version, with various things broken that were fixed in some other project, and when I try to update one script with another, bugs like this happen.
As for the /tmp location for the builddir, that is intentional. Modern distributions make /tmp a ramdisk, a good place to store temporary files. This is particularly helpful if your home directory is on an SSD; then frequent builds during development do not count toward its write endurance. You can change builddir location with configure --builddir yourplace.


Inference mode

Hi ! First great work thank you !
I don't get why we need label values for the inference mode. Is there a way to write a predict function directly from the input variables ? thx

Hello @guigxx ! Thank you for the nod. It took me some time to go back into the code base. You are right. There is no need for the label values in the inference mode. In inference mode, all the ops are replicated with the reuse of weights from training. take a look here -> Inference scope of computations.
As coded there, you only have to evaluate the inf_outputs tensor which upon retracing backwards does not have a dependency on the labels placeholder. Infact the interface_dict also returns the handle to the same under the key: inference here.
To stay consistent with the structure of the code, you can add another method called infer in the class Model here and then use the model API for inference.
The reason why I never ended up writing the infer method is because as soon as the model was trained, we directly started working on the TFServing part of it. Feel free to open a PR for the same.

@guigxx Closing this issue now. LMK if you need any more help.


feat(hp): Add displayArea option for Hanging protocols and example with Mamo

Context
Add a mammography hanging protocol, mostly as a test/demonstration code.
Changes & Results

Testing

Checklist
PR

[] My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

[] OS:
[] Node version:
[] Browser:

Can you post a link to the Mamo example?


2to3 test/

is it possible to break this down in:

assert replacements and prints
and other stuff
and maybe ignore/ disable list around .values()..I have got the feeling this should work ok automatically

(there might not be much diff left after the this)

(this for the actual tests, not for the code in src/amuse/test)

(this for the actual tests, not for the code in src/amuse/test)

I included those later...

is it possible to break this down in:

assert replacements and prints
and other stuff
and maybe ignore/ disable list around .values()..I have got the feeling this should work ok automatically

(there might not be much diff left after the this)

Sure, but I'll wait for Travis to finish checking this one first.

there are failures, osx reports as passed, but also has errors...
nothing overly serious though

I created a separate PR for print+asserts changes, need to make a third one which re-applies the other changes onto that PR... This is a bit tricky, will do it later.

closing this one...


Merge pull request #1 from banchichen/master

Merge pull request #1431 from cnjsyyb/master

error


Tensorflow-gpu 1.0.0 issue

Hi, I followed udemy tutorial and it seems they followed tensorflow 1.0.0 cpu version. I have CUDA compatible gpu. I tried installing that but it seems I need to reinstall older versions of CUDA toolkit 8 and cuDNN5.1 to run train this model on tensorflow GPU. I did that and I'm still unable to train it. I tried using pip install tensorflow-gpu==1.0.0 as an alternative but it gives me error. Any idea as to what do I do. Should I port my tensorflow 1.0 code to 2.0 or anything else.

Hi @sunn-e,
This project does not use tensorflow 1.0.0 as the Udemy course does. It is compatible with 1.5.0 minimum and any higher version along the 1.x.x line, such as 1.13.1. I am using CUDA 9, but with the latest you should be able to upgrade to CUDA 10.

Okay. Thanks.

Even on latest version of tensorflow with cuda 10, Im geting Dst tensor is not initialized error. I tried changing the rnn size and batch size but still it did not solve my problem. My trining stops after around 13-14th batch of 1st epoch. Should I downgrade to cuda 9?

Also, I used python instead of run command. Is it oky to do so?

That sounds like an out of memory error. The batches get progressively larger (memory-wise) later in each epoch, since the training set is sorted by question sequence length in ascending order. By the 13th batch TF is trying to allocate more space on your GPU and you get the allocation error (should also say "OOM") because TF failed to find enough free space.
If you are training on a smaller GPU, in addition to the rnn_size and batch_size you can lower training_hparams/max_question_answer_words and training_hparams/conv_history_length.
Try:
"max_question_answer_words": 30
"conv_history_length": 4
"rnn_size": 512
"batch_size": 32

Thanks. It worked. How will this affect the performance of the model.

max_question_answer_words specifies the number of words that are included in any question or answer from the dataset when training. Anything longer than that is truncated after the last end of sentence (.!?) before the max length.
conv_history_length specifies the number of previous dialog turns that are prepended to each input question when training. More history means longer sequences which take up more memory on the GPU. Making this shorter just means that the network will recognize less dialog context for each response.
rnn_size is the number of units in the LSTM memory cell. making this smaller theoretically means that it won't be able to learn as much, but making it too high can lead to overfitting. It is unfortunate that there is no good automated metric (like accuracy) to perform cross validation on free dialog models - because of this, hyperparameter tuning for layer size, number of layers, etc. is really a manual process.
batch_size is the number of question-answer samples per batch. smaller batches mean more frequent and granular weight updates at the cost of training performance, but can help if larger batches won't fit on the GPU. Typical values range from 32-128


Error - [tsc] node_modules/@uifabric/merge-styles/lib/IStyleSet.d.ts(15,67): error TS1005: ';' expected.

Ah.  Bug in the docs.  The problem is that OUIFR is being referenced, but there is no explicit reference in package.json, so it's picking up an incompatible ambient type.
Can you add "office-ui-fabric-react": "6.143.0" to the dependency section of your package.json file, rerun npm install, then rebuild?
Originally posted by @patmill in https://github.com/SharePoint/sp-dev-docs/issues/3622#issuecomment-474526941

I tried above but still i'm getting error
[11:58:52] Error - [tsc] node_modules/@uifabric/merge-styles/lib/IStyleSet.d.ts(15,67): error TS1005: ';' expected.
[11:58:52] Error - [tsc] node_modules/@uifabric/merge-styles/lib/IStyleSet.d.ts(15,114): error TS1005: '(' expected.
[11:58:52] Error - [tsc] node_modules/@uifabric/merge-styles/lib/IStyleSet.d.ts(15,136): error TS1005: '(' expected.
[11:58:52] Error - 'tsc' sub task errored after 3.06 s

package.json?

This is my package.json. Yes I did npm install
{
"name": "office-fabric-ui",
"version": "0.0.1",
"private": true,
"engines": {
"node": ">=0.10.0"
},
"scripts": {
"build": "gulp bundle",
"clean": "gulp clean",
"test": "gulp test"
},
"dependencies": {
"react": "16.7.0",
"react-dom": "16.7.0",
"@types/react": "16.4.2",
"@types/react-dom": "16.0.5",
"@microsoft/sp-core-library": "1.8.0",
"@microsoft/sp-property-pane": "1.8.0",
"@microsoft/sp-webpart-base": "1.8.0",
"@microsoft/sp-lodash-subset": "1.8.0",
"@microsoft/sp-office-ui-fabric-core": "1.8.0",
"@types/webpack-env": "1.13.1",
"@types/es6-promise": "0.0.33",
"office-ui-fabric-react": "6.143.0"
},
"resolutions": {
"@types/react": "16.4.2"
},
"devDependencies": {
"@microsoft/sp-build-web": "1.8.0",
"@microsoft/sp-tslint-rules": "1.8.0",
"@microsoft/sp-module-interfaces": "1.8.0",
"@microsoft/sp-webpart-workbench": "1.8.0",
<EMAIL_ADDRESS>"0.4.0",
"gulp": "~3.9.1",
"@types/chai": "3.4.34",
"@types/mocha": "2.2.38",
"ajv": "~5.2.2"
}
}

Hi,
got the same error. Upgrading the project from using TypeScript 2.7 to 3.2 fixed that.
You can find a very good explanation of the upgrade process on Elio's Blog:
https://www.eliostruyf.com/using-the-full-potential-of-react-in-sharepoint-framework-1-8-0/
Generally speaking we fixed a lot of different compile errors we got in solutions upgraded to SPFx 1.8 simply by upgrading Typescript from 2.7 to 3.2. In our experience so far it seems to be a bad choice using 2.7 as default for SPFx 1.8.

My appologies.  I tested this against TS 2.9. not 2.7.  In order to stick with TS 2.7, you need to reference office-ui-fabric-react version 5.132.0
I've double checked and built correctly with this.  Bumping up the version of the build tools to 2.9 will also solve the problem.  I've updated the backing documentation to reflect this.  Need to figure out why it is not rolling to the official site.  Can you confirm that changing the fabric react version fixes the issue?

Thank you Pat, Yes it worked. This is my new package json.
{
"name": "office-fabric-ui",
"version": "0.0.1",
"private": true,
"engines": {
"node": ">=0.10.0"
},
"scripts": {
"build": "gulp bundle",
"clean": "gulp clean",
"test": "gulp test"
},
"dependencies": {
"react": "16.7.0",
"react-dom": "16.7.0",
"@types/react": "16.4.2",
"@types/react-dom": "16.0.5",
"@microsoft/sp-core-library": "1.8.0",
"@microsoft/sp-property-pane": "1.8.0",
"@microsoft/sp-webpart-base": "1.8.0",
"@microsoft/sp-lodash-subset": "1.8.0",
"@microsoft/sp-office-ui-fabric-core": "1.8.0",
"@types/webpack-env": "1.13.1",
"@types/es6-promise": "0.0.33",
"office-ui-fabric-react": "5.132.0"
},
"resolutions": {
"@types/react": "16.4.2"
},
"devDependencies": {
"@microsoft/sp-build-web": "1.8.0",
"@microsoft/sp-tslint-rules": "1.8.0",
"@microsoft/sp-module-interfaces": "1.8.0",
"@microsoft/sp-webpart-workbench": "1.8.0",
<EMAIL_ADDRESS>"0.4.0",
"gulp": "~3.9.1",
"@types/chai": "3.4.34",
"@types/mocha": "2.2.38",
"ajv": "~5.2.2"
}
}


Implement a Signer which is not constrained by a lifetime

Using Signer::new(...) requires that the signer has the same lifetime as
the passed in Context. This makes it impossible to write a function
which returns a Signer. This change adds a new constructor
Signer::new2() which does not have this constraint.
Signed-off-by: Shawn T. Amundson<EMAIL_ADDRESS>

Added doc comments to new_boxed()


are the images posted in steepshot not displayed in the gallery?

@muhammadarif1 no. we have no integration plan for steepshot images with gallery for now. what do you think @feruzm

@talhasch steepshot has their internal gallery and we have our own, just like steemit has their own. For now, there is no way or plans to integrate 3rd party gallery.


Add procedurally-generated billboard clouds

This PR implements the cloud enhancement as outlined in #9691, including the following features.

New CumulusCloud class and CloudCollection API, with a similar interface to BillboardCollection
Procedural cloud textures based on a combination of techniques in Gardner's Visual Simulation of Clouds and the Real-Time Volumetric Cloudscapes of Horizon: Zero Dawn.
Parameters in both CumulusCloud and CloudCollection that the user can tweak to vary the appearance of their clouds
"Cloud Parameters" Sandcastle (localhost) that demonstrates how each parameter affects the cloud.

This is still a work in progress. Remaining tasks:

[ ] Add images to CumulusCloud and CloudCollection documentation.
[ ] Create a Sandcastle showcasing multiple clouds in a non-empty scene.

Thanks for the pull request @j9liu!

:heavy_check_mark: Signed CLA found.

Reviewers, don't forget to make sure that:

[ ] Cesium Viewer works.
[ ] Works in 2D/CV.
[ ] Works (or fails gracefully) in IE11.

I pushed some small tweaks in https://github.com/CesiumGS/cesium/pull/9737/commits/41db4a8a0d894aa5f299ce16ce25fd01c42926c3 and updated CHANGES.md.
Thanks again @j9liu


[3.x] embree: Allow use of embree4 as distro package

Sadly embree changes its library name and include paths on new majors, and doesn't provide any pkgconfig file we can rely on to query this info.
So this is a manual process for now to select embree4 with use_embree4=yes.
This is needed for Fedora which is upgrading its embree package to embree4 and needs Godot rebuilt against it.
Haven't tested yet as I don't have embree4 on my Linux setup yet.
(Compiling now but it takes forever so I won't get to test it today.)
master version: #73631

Closing for now as this isn't usable, I'll revisit for 3.x if needed after #73631 is finalized.


HC-377

From NSDS-1427 (Pele mods for Cal/Val use cases).
Used osgeo.ogr package instead of rasterio since the former supports layered files. Added optional parameter to identify named layer in the event the file contains > 1 (default is to use the first layer in file). Returns polygon in Pele/ES geospatial friendly format.

should we add the osgeo library to setup.py or requirements.txt

@jimmie: can you run pip freeze --exclude-editable > requirements.txt and add it to this repo?

With HC-378 (separate pele client repo), I am going to close this PR and clobber the branch. The client.py change will be placed in the new client repo.


(SERVER-1160) Fix command parsing

Previously, Puppet Server failed to correctly parse more complex commands
(with lots of string escaping) passed to it by Puppet for execution.
This PR fixes that problem by updating execution.rb such that when an
array is passed it no longer concatenates that array to be a string, but
instead the first argument is passed to ShellUtils/executeCommand as a
string and the rest are passed as an array.

:+1:

This already ran successfully in Travis for #950 when targeted at the master branch, so I don't see a need to wait for a full Travis run again against the stable branch (since the two are basically identical at this point).  Merging...


Duplicate KeyboardInterrupt exception delivered in onefile mode

Summary
When I build an executable on Windows in onefile mode, exiting the program with a Ctrl+C seems to generate two KeyboardInterrupt events. It only happens in onefile mode - NOT in standalone mode.
Reproducing
Here is a simple test program:
import time

print("Started")
try:
    time.sleep(20)
except KeyboardInterrupt:
    print("Got first KeyboardInterrupt")

for sleep_time in (0.001, 0.01, 0.1):
    try:
        print()
        print("About to sleep for", sleep_time)
        time.sleep(sleep_time)
        print("Completed sleep of", sleep_time)
    except KeyboardInterrupt:
        print("Got another KeyboardInterrupt while sleeping for", sleep_time)

print("Exiting")

I build it with this command:
c:\src\nuitka_test>python -m nuitka --mingw64 --onefile nuitka_keyboardinterrupt_test.py
Nuitka-Options:INFO: Used command line options: --mingw64 --onefile nuitka_keyboardinterrupt_test.py
Nuitka:INFO: Starting Python compilation with Nuitka '0.7.5' on Python '3.8' commercial None.

Then run it like this (I only press Ctrl+C once):
c:\src\nuitka_test>nuitka_keyboardinterrupt_test.exe
Started
Got KeyboardInterrupt while waiting for input

About to sleep for 0.001Got another KeyboardInterrupt while sleeping for 0.001

About to sleep for 0.01
Completed sleep of 0.01

About to sleep for 0.1
Completed sleep of 0.1
Exiting

I sometimes get slightly different results:

As above, sometimes the second event happens during the first sleep() in the loop.
Sometimes the "About to sleep for 0.001" message does not appear, suggesting that the second KeyboardInterrupt triggered during the call to print().
On one occasion, I didn't even see "Got KeyboardInterrupt while waiting for input", suggesting that the second KeyboardInterrupt was delivered while still in the except: branch of the first.
I found this problem as part of a much larger program, notably with threads that are shut down and joined from the main thread. In that, the second KeyboardInterrupt is delivered a little later, not even in the sleep(0.01). So far, sleep(0.1) seems to work.

Workaround
It's possible to use a sleep like above and catch the second exception but that's not very reliable - it might get delivered afterwards if the sleep is too short, and it's even possible that the second exception could be delivered early. I think the safest thing is probably a custom signal handler:
keyboard_interrupt_count = 0
def keyboard_interrupt_handler(signum, frame):
    global keyboard_interrupt_count
    keyboard_interrupt_count += 1
    if keyboard_interrupt_count == 1:
        raise KeyboardInterrupt()
signal.signal(signal.SIGINT, keyboard_interrupt_handler)

Hello James,
the onefile bootstrap binary is passing on a CTRL-C it receives to the compiled Python program. Not sure if this has anything to do with MSVC vs. MinGW64, because there was, at some point, a report that CTRL-C was not passed to a compiled Python program. It might be some sort of default handling of MinGW64 that is happening here, otherwise I am confused now.
Would it be possible for you to try MSVC with your test easily?
Yours,
Kay

Forget my last request, I reproduced it with MSVC just the same.

Actually, according to docs, all processes of the terminal should receive the CTRL-C signal. I wonder, how I ever had that report then, maybe it's possible to detach from the console, e.g. by replacing standard outputs, or something, I will need to revisit this issue first, to see if it was only in our hears. But I think the first CTRL-C is from the terminal, and the second from onefile, but this is all a bit hard to trace naturally. Adding traces though.

Thanks for the quick response Kay. I should note this issue is no longer affecting me thanks to the workaround I included. (In a sense, that signal handler is probably a good idea anyway for my program, even if this bug didn't exist.) But I thought it best to make it publically know.

This has been fixed in another issue indeed, and works on Windows perfectly now.


Crash: 'Debug adapter process has terminated unexpectedly' on arch and manjaro

Environment data
dotnet --info output:
.NET Command Line Tools (1.0.1)

Product Information:
 Version:            1.0.1
 Commit SHA-1 hash:  005db40cd1

Runtime Environment:
 OS Name:     manjaro
 OS Version:
 OS Platform: Linux
 RID:         ubuntu.16.10-x64
 Base Path:   /opt/dotnet/sdk/1.0.1

VS Code version:
Version 1.10.2
Commit 8076a19fdcab7e1fc1707952d652f0bb6c6db331
Date 2017-03-08T14:00:46.854Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0

C# Extension version:
1.8.0
Steps to reproduce

install dotnet, dotnet-cli and dotnet-sdk on archlinux (see additional info for building from aur)
install C# extension
try to debug anything

Expected  behavior
running the debugger
Actual behavior
instant crash when trying to run the debugger

Debug adapter process has terminated unexpectedly
Additional info
Linux railgun 4.9.13-1-rt11-MANJARO #1 SMP PREEMPT RT Wed Mar 1 17:46:29 UTC 2017 x86_64 GNU/Linux

System Info
 OS: Manjaro 17.1-dev Gellivara
 Kernel: x86_64 Linux 4.9.13-1-rt11-MANJARO
 Uptime: 5d 12h 23m
 Packages: 1655
 Shell: zsh 5.3.1
 Resolution: 1920x1080
 DE: XFCE4
 WM: Xfwm4
 WM Theme: Vertex-Maia
 GTK Theme: Vertex-Maia-Square [GTK2]
 Icon Theme: Vertex-Maia
 Font: Cantarell 10
 CPU: Intel Core i5-6200U @ 4x 2.8GHz
 GPU: Mesa DRI Intel(R) HD Graphics 520 (Skylake GT2)

to make dotnet build on archlinux/manjaro
i remember i had to patch a single line in corefx build because of
ignoring return value of function declared with 'warn_unused_result'
attribute [-Werror,-Wunused-result]
pipe2(waitForChildToExecPipe, O_CLOEXEC);

with
-    pipe2(waitForChildToExecPipe, O_CLOEXEC);
+    if (pipe2(waitForChildToExecPipe, O_CLOEXEC)) { } else { }

i wonder if something similar happens with corclr, because i have seen patch files for that flying around too https://gist.github.com/leafi/9404f79bcd3c64e4d828c0c5e06f056d although the line numbers and commit hashes are different now...
followed the steps on #564 https://github.com/OmniSharp/omnisharp-vscode/issues/564#issuecomment-285960000
to install the debugger for 14.04 as well, did not help
tried installing the 16.10 debugger as well (because dotnet --info suggested that it might be compatible with that.. as expected a "Debug adapter process has terminated unexpectedly"

had the same issue (Archlinux 4.9 Kernel, Dotnet 1.0.1, Vscode 1.10.2, C# Extension 1.8.0), but for me it works after i downloaded the ubuntu 14.04 debugger as suggested above.

same versions.. although i do not know if mnjaro-rt 4.9 is the same as archlinux 4.9 that it is based on.. but it does not help as i mentioned before
same issue, shows the debug controls for a split second and then opens the error popup

ok. steps i did:

deleted everything from .debugger folder in vscode c# extension
downloaded the following zip:  wget https://vsdebugger.azureedge.net/coreclr-debug-1-8-6/coreclr-debug-ubuntu.14.04-x64.zip
extracted zip to .debugger folder in c# extension dir
needed to set execute right on vsdbg-ui (otherwise would get an SPAWN error in vscode when starting the debugger)

i did the same and tried with all versions of the debugger for ubuntu

16.04 obviously
14.04 as suggested
16.10 too
same result everwhere

I tested on a normal arch installation. Same issue. Also tried 16.04, 14.04 and 16.10

Running vsdbg is fine. Running vsdbg-ui responds with:
[starquake@archmonkey .debugger]$ ./vsdbg-ui
Failed to initialize CoreCLR, HRESULT: 0x80131500

So apparently the wrong version of icu is expected. ArchLinux has icu 58.
I executed this command in the debugger folder:find *.so -type f | xargs ldd 2> /dev/null | grep not\ found
which gave met the following output:
	liblldb-3.6.so => not found
	libvsdebugeng.so => not found
	libvsbaseservices.so => not found
	libvsbaseservices.so => not found
	libicuuc.so.55 => not found
	libicui18n.so.55 => not found
./System.Net.Http.Native.so: /usr/lib/libcurl.so.4: version `CURL_OPENSSL_3' not found (required by ./System.Net.Http.Native.so)

I installed icu55 which can be found in the AUR here: https://aur.archlinux.org/packages/icu55/
Now debugging works again!

I installed icu55

with 16.10 same error as before
with 16.04:

popup says: Error processing 'configurationDone' request. Unknown Error: 0x89720010
Output->Extensions prints: Waiting for communication on stdin/stdout...

with 14.04 same error as before

dotnet --info:
.NET Command Line Tools (1.0.1)

Product Information:
 Version:            1.0.1
 Commit SHA-1 hash:  005db40cd1

Runtime Environment:
 OS Name:     manjaro
 OS Version:
 OS Platform: Linux
 RID:         ubuntu.16.10-x64
 Base Path:   /opt/dotnet/sdk/1.0.1

after installing icu55, find *.so -type f | xargs ldd 2> /dev/null | grep not\ found still returns:
./System.Net.Http.Native.so: /usr/lib/libcurl.so.4: version `CURL_OPENSSL_3' not found (required by ./System.Net.Http.Native.so)
        liblldb-3.6.so => not found
        libvsdebugeng.so => not found
        libvsbaseservices.so => not found
        libvsbaseservices.so => not found

16.10 and 14.04 expect other icu versions so that's not going to work.
Maybe remove the ms-vscode.csharp-1.8.0 extension and reinstall it.
"Waiting for communication on stdin/stdout..." Actually sounds like it's working. Did you try restarting visual studio code?

ah yes of course, that makes sense.
tried to reinstall the whole extension but got the same result.
I did restart vs code and also it was closed while I changed the packages.
Tried it again with

14.04 and icu52
16.10 and icu57
which both result in the same error/result as before with 16.04 (0x89720010)

The problem seems to be attaching to the process. If I do a dotnet run in the console and use ".NET Core Attach" in vs code I get the error.
If I use ".NET Core Launch" I can see two dotnet processes spawn for a short time in the system monitor and then I get the error.
Any idea why that might be? maybe a rights issue?

@JBildstein which version of VSCode are you running?

@rajkumar42 Version 1.10.2 - (8076a19fdcab7e1fc1707952d652f0bb6c6db331)
I installed it from the AUR: visual-studio-code-oss

@JBildstein please install stable or insiders.

@rajkumar42 curios, the version from code.visualstudio.com works (using 16.10/icu57) even though it is the exact same version and commit hash as the one from AUR.
Anyway, glad it works now, thanks for the help!

isu55 and ubuntu 16.04 works on my manjaro system.. yay
i guess the issue should stay open until this is adressed in the debugger installer though..

@NikkyAI are there things that you think the exception can reasonable do today to fix this?
In the longer term (a few months) .NET Core is making changes that they believe will eliminate this class of issue.

could you check which version of icu is available and suggest installing one that matches the debugger ?

@NikkyAI what is the right way on arch to see what version of icu is installed?

You can install multiple versions of icu: https://aur.archlinux.org/packages/?O=0&SeB=n&K=icu&outdated=&SB=n&SO=a&PP=50&do_Search=Go
Instead of checking if the package is installed I would rather check if the library is available.
I would check if the needed version is installed using something like:
ldconfig -p | grep libicu
(currently working out which exact query should be done)

In my humble opinion the real solution would be give the user a setting to configure the .NET Core debugger path manually, I'm thinking something like omnisharp.debuggerPath.
That way it would be possible to create a working version of the debugger by replacing all *.so and *.Native.dll with the ones from the dotnet AUR package and persist these changes across omnisharp updates.
Fumbling with icu/curl/$whatnot versions is time consuming, error prone and just not the right way to do it.

Here is my tentative plan, let me know if anyone hates this. I haven't finished implementing this yet, so I may change my mind if something doesn't work as well as I am expecting.

Add a new preference to VS Code to select what version of the debugger to use on Linux
Add a new wiki page with the relevant parts of this issue to this repo
Add a new error message when installing on arch that will direct folks to the wiki page

👍
@gregg-miskelly would this selector show up only on arch (unsupported coreclr distros) ?

@rajkumar42 my thought is that we would look at the setting on any Linux distro other than the few officially supported ones (ex: Ubuntu16).

@gegenschall I tried your solution but now when I open Vs Code it immediately gives me:
[ERROR]: An error occured while installing the .NET Core Debugger:
Error: Error during installation.

I've also tried to add on /etc/os-release the line
ID_LIKE=arch

And to install isu55.
I'm using Manjaro. Do you know if there is something I'm missing?
This is bugging me so much that I'm about to give up on Manjaro/Arch, I've been trying to fix this issue for more than 3 hours already.

@Merurino Ignore the error and don't install funky icu versions, just use the one from [core] it should be working just fine.

Hey @gegenschall thanks for the reply.
By core you mean the AUR package you made? It didn't work. Is it dangerous to install icu packages? I got them from AUR and checked the script before installing.

@Merurino By core I mean the default Arch Linux core repository. No, it's not dangerous to install icu packages but the dotnet dependency of vscode-coreclr-debug is (partially) compiled from the coreclr source code anyway and should correctly link to the latest icu version from the core repository. This means that there shouldn't be any need to "clog" your system with additional icu version.
But hey: If your method works, then all is good. Whatever works, right? :-)

@gegenschall Totally missed your edit on the new AUR package. Sounds great! Will try it ASAP.
Thanks!

Closing this as it should be fixed in upcoming 1.9.

If anyone would like to try the private before 1.9 is out, here are instructions --

Download csharp-1.9.0-beta2-private.zip
Rename the extension from '.zip' to '.vsix'
Follow instructions on https://github.com/OmniSharp/omnisharp-vscode/wiki/Installing-Beta-Releases for installing it.


fix(release): make sure we are not on a detached branch else semantic release has issues

Can one of the admins verify this patch?


Avoid compile error in old GCC (CentOS6)

I got following error on CentOS6.
cupy/core/_scalar.cpp:964: error: member '__pyx_t_float_complex __pyx_t_4cupy_4core_7_scalar_Scalar::complex64_' with constructor not allowed in union
cupy/core/_scalar.cpp:965: error: member '__pyx_t_double_complex __pyx_t_4cupy_4core_7_scalar_Scalar::complex128_' with constructor not allowed in union

Jenkins, test this please.

Jenkins CI test (for commit cd3f2544a9922812762fd5879ce7bba98e19c9c0, target branch master) failed with status FAILURE.
(For contributors, please wait until the reviewer confirms the details of the error.)

This line expects the existance of CScalar.val.
https://github.com/cupy/cupy/blob/b63795a0b4d1e63bc2894ddfbe4988e89c7743b7/cupy/core/reduction.pxi#L160-L161

Thanks! I fixed. @kmaehashi

Thanks!
Jenkins, test this please.

Jenkins CI test (for commit ef935e9cfa3fac1534360877f0b19e3f338cdeb4, target branch master) succeeded!

LGTM!


[CHORE] Cleanup ExprResolver

Follow-up from #3399

BTW most of these commits are just from the previous PR


Seed everytime when calling generateRandString

This isn't in a hot path, so no performance hit. Also want to avoid side
effects from doing in an init

Codecov Report

Merging #130 into master will increase coverage by 0.2%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #130     +/-   ##
=========================================
+ Coverage   76.78%   76.98%   +0.2%
=========================================
  Files          23       23
  Lines        1904     1899      -5
=========================================
  Hits         1462     1462
+ Misses        314      310      -4
+ Partials      128      127      -1

Impacted Files
Coverage Δ

mdns.go
100% <ø> (+33.33%)
:arrow_up:

util.go
53.19% <0%> (-0.98%)
:arrow_down:

gather.go
65.12% <0%> (-0.87%)
:arrow_down:

agent.go
77.69% <0%> (+0.31%)
:arrow_up:

selection.go
73.41% <0%> (+1.15%)
:arrow_up:

candidate_base.go
89% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95907d9...6a2fbb7. Read the comment docs.


Fix/pagination

What does this pull request change?

Refactor usePagination into reusable component
When adding new item to list, it moves to last page so that one can see the new item.
Fixed bug where pagination was messed up when on 2. page and changing itemsPerPage

will use this hook in TablePlugin as well, but that is next PR.
Why is this pull request needed?
Issues related to this change

Should it show which page you are currently on? 🤔

Should it show which page you are currently on? 🤔

Perhaps?


[fix] Prevent exception when connection is closed

When the MongoDB connection disconnects, it currently unsets the connection property altogether. This causes the following exception when trying to use a MongoDB connection afterwards: Prevent Undefined property: MongoDB\Laravel\Connection::$connection
This PR sets the connection (client) to null instead of using unset().
Unfortunately there doesn't seem to be a reconnector configured by default, otherwise $connection->reconnect() could be used, but this has no effect right now. Could be a good next step for someone to implement.
It's possible that this issue only occurs when using Database Transactions (that's my use case. Didn't get any exceptions locally despite long periods of heavy load, but on our Atlas instance it is getting this exception a real lot)
Checklist

[x] Add tests and ensure they pass
[ ] Add an entry to the CHANGELOG.md file
[ ] Update documentation for new features

Thank you @SanderMuller


fix: consolidate terraform apply command across cloud-account cmds

Summary
When generating terraform for an azure integration the command line option used is terraform-apply this is not consistent with gcp and aws which use simply apply, therefore this consistent these other cloud account integration options and simply use apply

How did you test this change?
Built the CLI and ran azure commands with combinations of apply andterraform-applyto ensure that both flags can be set, also made sure that terraform-apply is not shown when help flag showing list of command options is used

Issue
https://lacework.atlassian.net/browse/GROW-1542

cli/docs/lacework_generate_cloud-account_azure.m


apple: Investigate sleep() in the tunnel stop handler

See if it's useful to incorporate https://developer.apple.com/forums/thread/84920?page=2
Previous discussion: https://github.com/firezone/firezone/pull/1737#discussion_r1254409705

In macOS 13.4, I don't see the sleep() making any difference. It works fine with with and without the sleep.
The earlier issue I was seeing about disconnect taking too long was because at that time, the exit was called before the adapter.stop()'s completion handler. That was fixed earlier.
In fact, I see that it works fine in macOS 13.4 even without the exit(), but we'll keep it in as long as we support macOS 12.


implementing #10334

implementing #10334
I added the error 0x80072F8F as reported, and classified it based on this link, please verify:
https://windowsinstructed.com/how-to-fix-0x80072f8f-a-security-error-occurred/

@Gitprakhar13
Hi, Prakhar,
Please confirm that the change in this PR is accurate.
Thank you!


rhood/1996-NewValueSet

This PR adds a new valueset named sender-automation.valuesets
If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.
Changes

Added sender-automation.valuesets

Checklist
Testing

[x] Tested locally?  sender-automation.valuesets is included in #2004 and #2008 and fully tested within these two new CSV sender schemas.
[x] Ran quickTest all?
[x] Ran ./prime test against local Docker ReportStream container?
[ ] Downloaded a file from http://localhost:7071/api/download?
[ ] Added tests?

Fixes
List GitHub issues this PR fixes

#1996

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Merged Pull Request #2009 , #2010 , and 2008 into one Pull Request #2004


[Bug]: Microphone input not detected on MacOS

Describe the bug?
GDTuber does not detect microphone input on MacOS. The input sources list has the correct input devices, but selecting one and speaking does not result in anything being picked up by the program (changing the gain also results in no change).
The program does not appear request microphone access on initial launch (no popup appears), which might be the cause. Godot also spams an audio related error (??) during execution, which I have provided below, although I am not sure if this is part of the issue or is an issue with the Godot setup on my system (testing on other devices would be preferable).
E 0:00:05:0276   input_callback: AudioUnitRender failed, code: -10863
  <C++ Source>   drivers/coreaudio/audio_driver_coreaudio.cpp:238 @ input_callback()

To Reproduce

Run GDTuber on Mac
Select an input source.
Make sound.

Expected behavior
The indicator next to the slider below the input device button should indicate that microphone input is being received. The image should also bounce and react to the microphone input.
Screenshots

While making sound:

Godot Version
4.2.2
What Platforms does this occur on?
macOS
Additional Context
Device info: Macbook Air M1 running MacOS Sonoma 14.5
Tested in both Godot Stable, Mono, and also after exporting the app.

This is most likely related to higher sampling rates in OSX.
Related Issue is still open: https://github.com/godotengine/godot/issues/64583

@Shilo


enableCache() isn't actually enabling caching

Follow up on the recent cache control changes slated for 4.2.0
Overview
I believe there's a regression in there, or at least a misinterpretation of the spirit of the whole caching API. In short, the enableCache() meaning got changed halfway through the discussion, in a way which prevents both browsers and CDNs from actually caching. The headers instruct them to call back to the origin server with their If-Modified-* headers, and the server can choose to return a 304. That's not saving any server resources, since we still need to process the entire request execution. It just saves bandwidth. It's also inconsistent with our 3.x implementation.
I think it's critical that we remove no-cache from enableCache() before we call 4.2.0 stable
Context
@dhensby submitted a PR with a commit titled State default should be state enabled (no-cache is an enabled state), which @tractorcow  merged into 4.2.
HttpCacheControlMiddleware::stateDirectives
    protected $stateDirectives = [
        self::STATE_DISABLED => [
            'no-cache' => true,
            'no-store' => true,
            'must-revalidate' => true,
        ],
        self::STATE_PRIVATE => [
            'private' => true,
            'must-revalidate' => true,
        ],
        self::STATE_PUBLIC => [
            'public' => true,
            'must-revalidate' => true,
        ],
        self::STATE_ENABLED => [
            'no-cache' => true,
            'must-revalidate' => true,
        ]
    ];

In the PR, he comments:

An important thing to note here is that no-cache is actually a kind of enabled state; ETags are generated and 304 responses are possible. So I've removed my "default" state which was just a soft enabled state and turned the "enabled" state to be what was the default. This means by default we will allow 304 responses, but it's for a developer to set a max-age. The framework still protects them from caching during sessions and so on.

Our docs say on enableCache():

Simple way to set cache control header to a cacheable state. Use this method over publicCache() if you are unsure about caching details. Removes no-store and no-cache directives; other directives will remain in place. Use alongside setMaxAge() to indicate caching.

Further down we use enableCache() in a code example described as:

Global opt-in for page content
Enable caching for all page content (through PageController).

Notes

There was a discussion about making the default state no-cache. That's still OK, since the default state is disabled.

@sminnee Keen to hear your thoughts on this

I just tested this in 4.2.x-dev and it seems to work as expected. If I setMaxAge in the controller I get chrome loading from disk cache and not hitting the server for validation of current cache

OK I worked this through with Dan and Sam:
It was an issue of docs and implementation getting out of sync, which lead me down a rabbit hole of questioning the implementation rather than the docs :wink: I’m doing some minor API and docs additions to be cherry picked into 4.2.0 (not 4.2.x)

Yup, unless the developer defines a specific max-age, it's not up to framework to decide that for them; you can't cache until you know that, so allowing 304's etc makes sense. Looks like a doc issue 👍  🌮
I guess we should also make it clear that enableCache() has to be used with setMaxAge or you're not going to get HTTP caching.

glad we got to the bottom of this :)

PR at https://github.com/silverstripe/silverstripe-framework/pull/8274


cxxfilt.c compilation fails on xcode 12

Describe the bug
Building of newest ghidra fails on newest public xcode release.
3 errors are generated from compiling cxxfilt.c due to missing explicit decleration, xcode clang has -Werror=implicit-function-declaration on by default.
A fast workaround is to manually set the following flag in /ghidra/GPL/DemanglerGnu/build.gradle:
-Wno-error=implicit-function-declaration
To Reproduce
Steps to reproduce the behavior:

Git clone ghidra
Try to build (gradle buildGhidra) with newest Xcode 12 installed
See error

Expected behavior
Installation should succeed without overriding the Werror flag.
Attachments
compiling cxxfilt.c failed.
/Users/User/git/ghidra/GPL/DemanglerGnu/src/demangler_gnu_v2_33_1/c/cxxfilt.c:81:7: error: implicit declaration of function 'free' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
free (result);
^
/Users/User/git/ghidra/GPL/DemanglerGnu/src/demangler_gnu_v2_33_1/c/cxxfilt.c:135:3: error: implicitly declaring library function 'exit' with type 'void (int) attribute((noreturn))' [-Werror,-Wimplicit-function-declaration]
exit (status);
^
/Users/User/git/ghidra/GPL/DemanglerGnu/src/demangler_gnu_v2_33_1/c/cxxfilt.c:135:3: note: include the header <stdlib.h> or explicitly provide a declaration for 'exit'
/Users/User/git/ghidra/GPL/DemanglerGnu/src/demangler_gnu_v2_33_1/c/cxxfilt.c:246:42: error: implicitly declaring library function 'strchr' with type 'char *(const char *, int)' [-Werror,-Wimplicit-function-declaration]
while (c != EOF && (ISALNUM (c) || strchr (valid_symbols, c)))
^
/Users/User/git/ghidra/GPL/DemanglerGnu/src/demangler_gnu_v2_33_1/c/cxxfilt.c:246:42: note: include the header <string.h> or explicitly provide a declaration for 'strchr'
3 errors generated.
Environment (please complete the following information):

OS: MacOS 10.15.6
Java Version: openjdk@11
Ghidra Version: git ghidra (9.2 DEV)

We will update cxxfilt.c to include stdlib.h

String.h is required as well, for the third error


Feature idea: metadata option to omit field

I make extensive use of structured config with dataclasses, where the classes have a lot of their own logic. Their fields are generally their configuration, but I'd like to have some fields which are linked to program logic but not to configuration, and some of these I want to allow passing to __init__.
Proposed solution
My current idea is to change OmegaConf.structured so that it looks for some indication in a field's metadata that it should ignore that field. For example, we could decide to check for a value "omegaconf_ignore". Then the following would print {"a": 3, "b": 3}.
from dataclasses import dataclass, field

@dataclass
class A:
    a: int = 3
    b: int = field(default=3, metadata = {"omegaconf_ignore": False})
    c: int = field(default=3, metadata = {"omegaconf_ignore": True})

print(OmegaConf.structured(A))  # prints {"a": 3, "b": 3}

(If an ignored field was undefaulted, then you would not be able to call to_object() on the config.)
Would this be a good idea? Could I make a PR?

Hi @bottler,
I'd like to get a better feel for how you are using structured configs. How do you translate between DictConfig instances and dataclass instances? Are you using OmegaConf.to_object?
Or do you call the constructor for A directly in your code (e.g. A(**cfg))?

I generally call the constructor directly.

The reason we avoid to_object is because of considerations about what should happen when a notebook user redefines a class.

Adding a check for metadata["omegaconf_ignore"] seems reasonable to me. I'll bring this up with the rest of the OmegaConf dev team next week to see if there is consensus.
One detail to iron out: how would "omegaconf_ignore" interact with OmegaConf.to_object? Here is an example using the dataclass A from your original post:
cfg = OmegaConf.structured(A)
assert cfg == {'a': 3, 'b': 3}  # information regarding 'c' is discarded
OmegaConf.to_object(cfg)  # What happens here? What value for 'c' is passed to `A.__init__`?

My instinct is that, in my example above, OmegaConf.to_object should succeed if the dataclass A has a default value for field c. If c does not have a default value, then then invoking A(a=3, b=3) will cause a TypeError which we can pass through to the user.
Details for potential implementation
If you make a PR, here are some things to keep in mind:

The behavior change should be the same for dataclasses and for attr classes
As for where in the OmegaConf codebase to check for "omegaconf_ignore" metadata, here are the routines that would need modification:

omegaconf._utils.get_dataclass_init_field_names
omegaconf._utils.get_dataclass_data
omegaconf._utils.get_attr_class_init_field_names
omegaconf._utils.get_attr_data

A PR would ideally mention the "omegaconf_ignore" API somewhere in docs/source/structured_config.rst
I think that testing for this feature should include at minimum:

adding an example dataclass to tests/structured_conf/data/dataclasses.py, and adding an equivalent attr class example to tests/structured_conf/data/attr_classes.py. The example class A from your original post (renamed to something more descriptive) should be sufficient, though a field d: int = field(metadata={"omegaconf_ignore": True}) with no default value should be added. These example classes would be tested in tests/structured_conf/test_structured_config.py to confirm the following:

OmegaConf.structured(A) == {'a': 3, 'b': 3}
OmegaConf.structured(A(a=0, b=1, c=2, d=3)) == {'a': 0, 'b': 1}

There should be an integration test in tests/test_to_container.py confirming that interaction with OmegaConf.to_object is as expected.

Closed by PR #988.


License of logos?

I would like to post a hex sticker (common in R packages) on prqlr.
Is there a License or Terms of Use posted somewhere for the prql logo? (I think the logos are very cool!)
https://eitsupi.github.io/prqlr/

We don't have anything official yet, but you're more than welcome to use it for the prqlr sticker. Is that sufficient for the moment?

It is enough. Thank you for answering so quickly!

It was late, but the work was done. eitsupi/prqlr#67
By the way, it would be very useful to have an image of the logo alone without text.

Great!

By the way, it would be very useful to have an image of the logo alone without text.

Added in https://github.com/PRQL/prql-brand/commit/c73248897ec3aadea97122f119280bb87b14934d, let me know if that's sufficient. I didn't make all the formats (and just did it in Apple Preview...)

Thank you for your quick response to this, this is good enough for me!
However, I think it would be better to keep this issue open as others will want to use the logo as PRQL grows in popularity.

Good idea — let me add something to the Readme

Done — https://github.com/PRQL/prql-brand/commit/7bc3133ca13057f842279552f4b2cae7073dc337 — do you think that's sufficient?

Done — 7bc3133 — do you think that's sufficient?

Thank you for the immediate support!
This is great as it clarified how we should proceed.