[QBD] Restrict QBD to Control plans

Details
[QBD] Restrict QBD to Control plans
Fixed Issues

$ https://github.com/Expensify/App/issues/50704
PROPOSAL:
Tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Create workspaces with Collect plan

Sign in on an account above
Go to any Workspace with Collect plan -> Accounting
Click on Connect under QuickBooks Desktop connection
Verify that before connection to QuickBooks Desktop you need to upgrade your workspace to Control plan

[x] Verify that no errors appear in the JS console

Offline tests

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Create workspaces with Collect plan

Sign in on an account above
Go to any Workspace with Collect plan -> Accounting
Click on Connect under QuickBooks Desktop connection
Verify that before connection to QuickBooks Desktop you need to upgrade your workspace to Control plan

QA Steps

Prerequisites:

Turn on Beta quickbooksDesktopOnNewDot on your account
Create workspaces with Collect plan

Sign in on an account above
Go to any Workspace with Collect plan -> Accounting
Click on Connect under QuickBooks Desktop connection
Verify that before connection to QuickBooks Desktop you need to upgrade your workspace to Control plan

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/d835091a-b11b-4e95-ac68-874700f130eb

Android: mWeb Chrome
https://github.com/user-attachments/assets/d39c7960-26d2-42aa-bdd1-140719aadc94

iOS: Native
https://github.com/user-attachments/assets/dc012e24-68ea-4564-bbc7-40439631243e

iOS: mWeb Safari
https://github.com/user-attachments/assets/cebadbd9-2552-494a-a59a-1f27ab6ba00f

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/b801fd48-e2de-4e62-a6ae-946cff6c24c6

MacOS: Desktop
https://github.com/user-attachments/assets/0bd51bb0-0043-4f26-84c5-592e6aa716ef

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


Implement exporting tables from models describing topics

Rationale:
Topics can already be described in the models by using the print_topics() method. The problem is that this does not output the table in a reusable format. If some user wants to topic descriptions as a format that can be reused and imported in other types of software, this is impractical.
We should provide some easy method to achieve this in Turftopic.
Implementation:
I have a couple of approaches up my sleeve for this:

We can create a new method, which returns the topic descriptions in a pd.DataFrame. This would make it easy for data scientists to work with, but would introduce pandas as a dependency, which I would love to avoid.
We can add a parameter to print_topics(), that specifies the format in which it should be printed,
e.g. model.print_topics(format="csv"). This would allow users to pipe stdout into a csv file. This would not introduce dependencies, but would be a bit less intuitive.
We could add a method that returns a string model.export_topics(format="csv") and then users are able to print this or write it out to a file.

Addressed by #13


Convert #stub -> #allow (newer expect syntax for mocks)

This converts all of our uses of .stub (and related methods) to RSpec 3+ expect syntax, preceeding us disabling should syntax for both rspec-expectations and rspec-mocks.

@miq-bot add_label rspec3, test

@Fryguy @chessbyte Review?


Adding an un- and an optimized PNG file

This should showcase the travis check for unoptimized PNGs.
Travis should not allow merging.

For future reference: https://github.com/0xB10C/bitcoinops.github.io/pull/2/checks?check_run_id=193408766


sensory neurons and hair cells

Hi all,

These comments on sensory neurons and hair cells were motivated by issues we've
had in marking up the text of PMID:12585968 with CL.

First, 'auditory hair cell' is an indirect subclass of both 'neuron' and
'epithelial cell'--is this intended?

Also, 'sensory hair cell' is an indirect subclass of 'neuron' but not of
'sensory neuron'.  It seems it should be, but  my reading of this article
suggests that sensory neurons and hair cells are indeed different (disjoint?),
e.g., the Table 1 caption.  So, is it the case that sensory neurons and sensory
hair cells are either disjoint or overlapping, but the former doesn't subsume
the latter, as is currently modeled?  If so, then why are sensory hair cells,
which are neurons, not sensory neurons?  If this is the case, it seems mentions
of sensory neurons might be referring to either.  On the other hand,
categorizing sensory hair cells as sensory neurons doesn't seem to jive with
this article to me, so I'm stuck.  And would the mentions of vestibular and
cochlear sensory neurons in the article refer to vestibular and cochlear hair
cells already represented in CL?

Mind you, I'm not an expert in this at all, so I'd be curious to hear opinions.

Thanks!
Mike

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 14 Mar 2014 at 4:07

First, 'auditory hair cell' is an indirect subclass of both 'neuron' and
'epithelial cell'--is this intended?

I think this is correct, hair cells – are highly specialized epithelial cells located within the inner ear. [PMID:23545368]

It seems it should be, but  my reading of this article
suggests that sensory neurons and hair cells are indeed different (disjoint?),
e.g., the Table 1 caption.

I think what this means is that it seems that hair cells and sensory neurons seem to refer to different things in the article? It seems that this is specific to the article and I'm not 100% sure if they meant hair cells as a subset or neurons. Noting their methods, they only did IHC for hair cells and used cresyl violet to count neurons (which seems to include hair cell) - it is a bit confusing here

If so, then why are sensory hair cells,
which are neurons, not sensory neurons?

They actually are, see screenshot:

Will close this ticket for now, please do open again if there are other concerns (cc @nicolevasilevsky as your email is in this thread, not sure who mikeb...@gmail is)


Add CircleCi Contexts

Same change as we've done in all other repos. Disable nightly builds too.

Thanks for the review! Merging now.


Rasterize text for rotations

This is arguably the most important issue to tackle before we use SMILe in Fall 2024.

One complication here is that Text is a VectorGraphic and thus its rotations are expected to return a VectorGraphic, too.


inference error

I would like to express my sincere gratitude for sharing the code on GitHub. It's really helpful.
However, I've encountered a bug. When I run the infer_avg.py, I get the following error message:
Traceback (most recent call last):
  File "/opt/tiger/laps/Diarization/DiariZen/recipes/diar_ssl/infer_avg.py", line 412, in <module>
    c_result = diarize_session(
  File "/opt/tiger/laps/Diarization/DiariZen/recipes/diar_ssl/infer_avg.py", line 108, in diarize_session
    count = pipeline.speaker_count(
  File "/opt/tiger/laps/Diarization/DiariZen/pyannote-audio/pyannote/audio/pipelines/utils/diarization.py", line 148, in speaker_count
    count = Inference.aggregate(
  File "/opt/tiger/laps/Diarization/DiariZen/pyannote-audio/pyannote/audio/core/inference.py", line 559, in aggregate
    duration=frames.duration,
AttributeError: 'function' object has no attribute 'duration'

Could you please take a look at this issue and give some advice on how to fix it? Thank you very much!

Hi, did you use the correct Pyannote version (from this repo)?


How to add thumbnail for blog post written in word on the main page?

Word format does not support this at the moment.  I would suggest converting your word document to markdown if you want to unlock extra features.  This is just a limitation of fastpages, perhaps something we could address in the future.  Thanks

Sure will do that thank you!


Document configuration for async/await

Partially addresses the following issues:
https://github.com/glimmerjs/glimmer-application-pipeline/issues/83
https://github.com/glimmerjs/glimmer-application/issues/55
https://github.com/glimmerjs/glimmer-component/issues/41
https://github.com/glimmerjs/glimmer-website/issues/43
https://github.com/glimmerjs/glimmer-application/issues/58
https://github.com/glimmerjs/glimmer-website/issues/62
https://github.com/glimmerjs/glimmer-vm/issues/451
@rwjblue

Thank you!!!!


Don't render signup link if registration feature is disabled

Hides the signup link since the controller just redirects back to root path if the registration feature is disabled.

Going to fix the system tests.

@mgomes but the system test shouldn't fail by making this change because the feature is enabled by default so the link should be there. I actually think your conditional is backwards :)

@krschacht Ok, fixed the logic and added a system test. I had to move some of the private methods in the feature tests to helpers. I think they'll be useful, though, as more features get introduced and need to be tested in isolation.

Good call, thanks for cleaning that up! Merging in


Support Multi-Group Access to AdminAPI

Is your feature request related to a problem? Please describe.
Currently, when adding AdminAPI functionality to a project, the CLI only affords me the ability to grant access to a single user group. As a result, in a scenario in which I have two “admin” user groups—say “ops-admin” and “domain-admin”—I cannot authorize both.
Describe the solution you'd like
As a user following the principle of least privilege, I should be able to authorize multiple user groups to access the AdminAPI so that I can support multiple groups with administrative functionality.
Describe alternatives you've considered
Alternatively, I could create another group--say "api-admin"--and assign users in my existing admin groups to this new group for AdminAPI-access purposes; however, this increases the ops/sec burden.
Additional context
I can manually implement this functionality by editing the AdminAPI source in ./amplify/backend/function/AdminQueries<SOME_ID>. The checkGroup functionality that the AdminAPI utilizes lives in app.js file contained in the src directory. On line 45 of that file, the allowed group specified via the CLI is pulled in from the environment. Thereafter, starting on line 47, the service runs through a series of checks to determine whether it should authorize the request. The implementation that would need to be changed begins on line 57 (copied below).

// Only perform tasks if the user is in a specific group
const allowedGroup = process.env.GROUP;

const checkGroup = function(req, res, next) {
  if (req.path == '/signUserOut') {
    return next();
  }

  if (typeof allowedGroup === 'undefined' || allowedGroup === 'NONE') {
    return next();
  }

  // Fail if group enforcement is being used
  if (req.apiGateway.event.requestContext.authorizer.claims['cognito:groups']) {
    const groups = req.apiGateway.event.requestContext.authorizer.claims['cognito:groups'].split(',');
    if (!(allowedGroup && groups.indexOf(allowedGroup) > -1)) {
      const err = new Error(`User does not have permissions to perform administrative tasks`);
      next(err);
    }
  } else {
    const err = new Error(`User does not have permissions to perform administrative tasks`);
    err.statusCode = 403;
    next(err);
  }
  next();
};

As a workaround, you can do this by hacking the generated CloudFormation template and Lambda code.

Give any group admin access using Amplify cli.
Update the generated CloudFormation template in amplify/backend/function/AdminQueries<some id>/AdminQueries<another id>.json, find "GROUP": "<group name>", in the environment variable section, add as many groups as you want here, use some kind of delimiters so you can parse it in the Lambda function.
Update amplify/backend/function/AdminQueries<some id>/src/app.js, find this line, it checks if the user is in the group defined in CloudFormation. Here you can parse the group list you set in the above step and check multiple groups.

You need to reapply the workaround every time you run amplify update auth. Also, the Lambda function code template may change in future versions.

@a9udn9u is this really works?
Can you share the amplify/backend/function/AdminQueries<some id>/src/app.js code?

Dear contributors, make this as a feature

Temporarily, I created a new group and add the uesrs to that group.

Update the generated CloudFormation template in amplify/backend/function/AdminQueries/AdminQueries.json, find "GROUP": "", in the environment variable section, add as many groups as you want here, use some kind of delimiters so you can parse it in the Lambda function.

Update amplify/backend/function/AdminQueries/src/app.js, find this line, it checks if the user is in the group defined in CloudFormation. Here you can parse the group list you set in the above step and check multiple groups.

It is not working. looking for further updates.

@a9udn9u  I am not sure how to parse, a group in the link you provided. Can you please provide a snippet?

@gurusabarish , if you have snippet, you can also help

This issue is 3 years old and is still not implemented? What is the limitation of this feature preventing its progression?


Consider a new release?

Release 0.1.0 does not yet include the tokio feature, which I find very useful.
Would be great if there was a new release with this feature included.
I'm currently using the git version.

You may also find the reis::tokio::ei_handshake function I added last week helpful.
I actually didn't remember that the tokio module was added after 0.1, so that's good to note. With https://github.com/ids1024/reis/commit/b27f8eeeae40e88b4cc5970d30aa42af25afb5fe, the next release is a breaking change (though only slightly), so I'll have to think if there are any other breaking changes I'd be making soon.
I've just recently tested Reis with the RemoteDesktop/InputCapture portals on Gnome 45 (rather than just a fake test server) so I'm just starting to figure out how it could provide a somewhat higher-level API. (Definitely easy to iterate on an API design using Reis as a client rather than trying to integrate a server in a Wayland compositor.)

Good to hear! Some higher level event type like in the c library would definitely be great.

Yeah. I'm thinking to should be fairly simple to map events to a higher level event enum. With accessors for the device/seat like ei_event has. Most events just map one-to-one, while seat/device have done events, so the higher-level SeatAdded event would let you access all the device properties set before that.
If that wraps per-event structs, that would provide an API like the input (libinput bindings) crate. I'll need something like that with eis to cleanly integrate server support for sender contexts into Smithay.
Could probably be a little more type-safe than libei by distinguishing at a type level between sender/receive contexts. Not sure about device methods. The way ei uses "capabilities" rather than device types makes it a little less natural to represent a type that only offers the methods supported on the device.

There is two more things, I noticed:

Maybe it is possible to throw an error if a capability was requested that is not included in the devices selected through the remote desktop session. (when such an interface is added).

It would be helpful to have a way to retrieve the device from an interface, (currently one has to remember the device that emitted the interface event together with the device.

I guess the second thing will be sorted when a higher level event api is in place.

ei_seat_bind_capabilities() says "Calling this function for a capability that does not exist on the seat is permitted (but obviously a noop)". I think it makes sense to provide the same behavior in the higher level API. Applications can bind all the capabilities they are potentially interested in, and also query if a capability is supported.
Accessing the device behind an event, and any interfaces for a given device, would by part of the higher-level API as well.
There's a bit of boilerplate that can't quite be generated dealing with each event, but now that I have an idea how I want it to work I'm making progress on a higher-level event type: https://github.com/ids1024/reis/compare/event?expand=1.

I've merged an initial version of that, though it still needs some fixes and refinement.
The tokio module is also somewhat preliminary since I want to also support async-io, and it should proably poll for writeability if there is any data to flush. Then with the higher level event API, lets see how minimal async uses of reis can be.
But some of these things could be in a later release.

FYI: I tried it out and it is working great so far!
Now I need to figure out how to get ashpd to connect to multiple portals at once without panicing ...
The error types (HandshakeError) should probably implement std::error::Error so that they are compatible with e.g. anyhow.
Also: Is there no way for a libei client to "release" an ongoing input capture? I have read all of the protocol documentation several times and to me it seems like the only way to hand control of a device back to the compositor is through the input capture portal interface... org.freedesktop.portal.InputCapture.html#org-freedesktop-portal-inputcapture-release

Yeah, the error type need more information, and implementations of Display and Error.
I'm fairly happy with the higher EiEvent and EisRequest types I've added, though the conversion logic still needs to handle destroyed events, and some other things. And I'm not sure how best to name and organize things. I guess those could be reis::Event and reis::Request in contrast to the lower level reis::ei::Event and reis::eis::Request. Or maybe the generated lower level types could be in a submodule like reis::ei::proto::Request. Hm.
libei just doesn't expose generated APIs in the public API of the library. But that's not the case with reis for now.

Now I need to figure out how to get ashpd to connect to multiple portals at once without panicing ...

Not sure why that's happening, without seeing what error it shows, but I'd open an issue on ashpd with a minimal reproduction.

Also: Is there no way for a libei client to "release" an ongoing input capture? I have read all of the protocol documentation several times and to me it seems like the only way to hand control of a device back to the compositor is through the input capture portal interface...

Yeah, that seems to be how libei is designed to be used. Libei mostly just provides a channel for input events (in either direction) while the portal API is needed for other operations like that. Libei isn't concerned with the fact that input is "captured" by the client, just that the server is sending input events to the client.

Figured out the ashpd issue: I was trying to create the proxies simultaneously: ashpd/issues/185

Yeah, that seems to be how libei is designed to be used. Libei mostly just provides a channel for input events (in either direction) while the portal API is needed for other operations like that. Libei isn't concerned with the fact that input is "captured" by the client, just that the server is sending input events to the client.

Thanks for confirming!
As for the Struct names, Imo having a Type for Requests is better than the "C" way of generating function calls.
The naming seems fine. I dont think it matters too much whether its eis::Request or eis::proto::Request as long as the meaning is clear.
proto is a good choice I would say, even though it breaks backwards compatibility

In particular that's mentioned in the README in https://gitlab.freedesktop.org/libinput/libei:

libei does not provide a method for deciding when events should be captured, it merely provides the transport layer for events once that decision has been made.

The new reis::event::EiEvent is a higher-level event similar to ei_event in libei. Except as a Rust enum. Events their have accessors for the Device and time (based on frame events), similarly to libei.

Oh I remember reading this at some point, now that you mentioned it. I still think this could be stated a bit more clearly ...

Any updates?
The input capture portal in ashpd is now working for my intents and purposes and the current status of reis would be absolutely fine for what I need.

There are a few things I wanted to fix in EiEventConverter before releasing a version with it. But they're fairly simple details, so I've pushed a few commits for that. Some of the server-side/EIS abstractions are a bit more incomplete, but if needed I could just disable those modules for now in a release.
Although the API could still use some (breaking) improvements, the client-side APIs should be fairly functional and usable. Could be good to add as an example in ashpd. So yeah, it's probably good to do a release with them.

I've marked the less complete (server-side/calloop) APIs as #[doc(hidden)] for now. The non-hidden APIs should be pretty usable. (Though error types could be improved, there should be some higher level API for sending requests, etc.)
This is now released as version 0.2 on crates.io.

Awesome, thank you :)


Import from XLSX dist folder causing errors

Is this intentional?
https://github.com/HalitTalha/ng-material-extensions/blob/129187e2ebceaa37127f2eecf18ccf3f203afc16/projects/cdk-table-exporter/src/lib/services/exporters/xls-exporter.service.ts#L2
I am getting errors when trying to serve and angular app.. even after adding @types/xlsx:

ERROR in node_modules/cdk-table-exporter/lib/options.d.ts:1:32 - error TS7016: Could not find a declaration file for module 'xlsx/dist/xlsx.mini.min'. '/node_modules/xlsx/dist/xlsx.mini.min.js' implicitly has an 'any' type.
Try npm install @types/xlsx if it exists or add a new declaration (.d.ts) file containing declare module 'xlsx/dist/xlsx.mini.min';

1 import { WritingOptions } from 'xlsx/dist/xlsx.mini.min';
~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/cdk-table-exporter/lib/services/exporters/csv-exporter.service.d.ts:2:23 - error TS7016: Could not find a declaration file for module 'xlsx/dist/xlsx.mini.min'. '/node_modules/xlsx/dist/xlsx.mini.min.js' implicitly has an 'any' type.
Try npm install @types/xlsx if it exists or add a new declaration (.d.ts) file containing declare module 'xlsx/dist/xlsx.mini.min';

2 import * as XLSX from 'xlsx/dist/xlsx.mini.min';
~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/cdk-table-exporter/lib/services/exporters/worksheet-exporter.d.ts:1:23 - error TS7016: Could not find a declaration file for module 'xlsx/dist/xlsx.mini.min'. '/node_modules/xlsx/dist/xlsx.mini.min.js' implicitly has an 'any' type.
Try npm install @types/xlsx if it exists or add a new declaration (.d.ts) file containing declare module 'xlsx/dist/xlsx.mini.min';

1 import * as XLSX from 'xlsx/dist/xlsx.mini.min';
~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/cdk-table-exporter/lib/services/exporters/xls-exporter.service.d.ts:1:23 - error TS7016: Could not find a declaration file for module 'xlsx/dist/xlsx.mini.min'. '/node_modules/xlsx/dist/xlsx.mini.min.js' implicitly has an 'any' type.
Try npm install @types/xlsx if it exists or add a new declaration (.d.ts) file containing declare module 'xlsx/dist/xlsx.mini.min';

Thanks for reporting.
This was intentional to keep the bundle size smaller. We will try to fix as soon as possible.

I downloaded:
npm install --save<EMAIL_ADDRESS>And didn't receive this same error anymore.

You won't be getting this with the latest version 10.2.3


Small fixes

Fix code so nari command will run and add fix for closing file when ActLogReader instance is GCd

Whoever was working on this branch has a lot of code that doesn't lint??
nari/types/statuseffect.py:7:0: C0304: Final newline missing (missing-final-newline)
nari/types/statuseffect.py:1:0: C0114: Missing module docstring (missing-module-docstring)
nari/types/statuseffect.py:3:0: C0115: Missing class docstring (missing-class-docstring)
nari/types/statuseffect.py:1:0: W0611: Unused List imported from typing (unused-import)
Like this.. I didn't touch any of those files. I'll work on fixing them.

I cleaned up a lot, but there's still a lot in nari.types.. it even seems like there's duplicated events under event? I think because the branch is called event-rewrite the plan is to move those? I looked at the git history and that seems to be whats happening.. can I remove nari.types.event.act then?

@ayyaruq following up on this.. not sure if that module is safe to remove or not

I cleaned up a lot, but there's still a lot in nari.types.. it even seems like there's duplicated events under event? I think because the branch is called event-rewrite the plan is to move those? I looked at the git history and that seems to be whats happening.. can I remove nari.types.event.act then?
@ayyaruq following up on this.. not sure if that module is safe to remove or not

As far as I recall that was the plan. If you're comfortable with doing it, please feel free!

@ayyaruq as discussed on discord, this PR should be ready to merge.


Integrate LNSwap into swap screen

https://www.lnswap.org/
For swapping BTC – either via Lightning or not – onto Stacks as STX or xUSD
See project

added screenshots in this figma file: https://www.figma.com/file/nY5UTVUoJdLQ30sk7YGQ3Y/🔁-Swap?type=design&node-id=201-17001&mode=design&t=v9uU3JtbPjYvFKX6-0


AutoDarkModeX changed windows theme to dark but VS Code stays in light theme

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.83.1
OS Version: Windows 11 (current version)

Steps to Reproduce:

Install AutoDarkModeX (v<IP_ADDRESS>)
Set Auto Detect Color Scheme = enabled
VS Code should be open. AutoDarkModeX will now change the windows theme from light to dark or dark to light. When now VS Code is closed and opened again the theme of VS Code is the same as before (and not changed to be the same theme of windows).

=> in this case the theme of VS Code should be the samer as windows

any news on that?

This worked for me.

VS Code open, dark, Auto Detect Color Scheme = enabled
AutoDarkModeX (<IP_ADDRESS>) changes to light, VS Code changes to light
Close VS Code, reopen VS Code. VS Code is still light

@aeschli Did you try it over a longer period with multiple switches from dark to light and back?

yesterday I have the strange behaviour that I opened VSCode on the evening (system war dark theme) and then VSCode switched from dark to light theme -> dark theme was here correct

with the current version it seams to be solved. I did not had the problem which I mentioned above several days. Therefore I close this ticket


Slightly cleanup 2 js files

For badge.js:

Use ES6 classes
Don't reach into the DOM to get build token and baseUrl.
This will help with writing tests in the future
Use => functions, so we can stop writing const that = this.
See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions.
Particularly, it does not rebind this, so we can continue
to access the parent context's this.

For badge.js:

Stop using global constants for config.
Use a single function that can switch on syntax type, rather than unique functions for
each syntax. Helps reduce boilerplate.

Eventually this could be part of a binder-client JS package that
can be used by other projects (like thebe)
Ref https://github.com/jupyterhub/binderhub/issues/1373

definitely looks unrelated

@consideRatio do you know why the pre-commit.ci PR is failing?

Because it doesnt see a pre-commit config yet, ignore it for now. I enabled it for this repo for the pre-commit related pr.

Thanks yuvi!!!


Melbourne Tram Tours Maintenance

The Melbourne Tram Tours website is currently undergoing Maintenance works.
These will be completed by 21:45 this evening.
Thank You. - MPM

Maintenance Complete. Thank You. - MPM


test(semantic): add a test for UpdateExpression

related: https://github.com/oxc-project/oxc/pull/7388#issuecomment-2496044394

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#7495  👈 (View in Graphite)
#7494
#6388
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Nov 26, 9:00 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Use existing server settings when creating the ConfigSection

This should help with https://github.com/jupyterlab-contrib/jupyterlab-tour/issues/82 and https://github.com/jupyterlite/jupyterlite/pull/1329#issuecomment-1969348261

Notebook test failure might be related to the new 7.1.0 release:
23e896c7a3cccd53b84837f70b276f1abc49f98e.webm


Ionic 2: Getting deprecated color warning on html elements

Ionic version:  (check one with "x")
[ ] 1.x
[x] 2.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
Putting an element on the page with a color attribute as of RC0 e.g:

Hello

Yields the warning in the console:
Deprecated: The color input has been removed from HTML elements. Please add the `ion-text` attribute in order to use the color input. For example: `<a ion-text color="secondary">Link</a>`

Expected behavior:
No warnings.
If we should be replacing the attributes as stated, then this should be reflected in the release notes as I can't see it mentioned anywhere.

Just add ion-text

Hello

you right, we missed this one in the release notes.

this sets the background color and the text color of the element. Is this on purpose? usually I was a blue button with white text not both blue...


Partial server-side support

We should simply allow something like the exec method to work server-side. This way, you can pass it the request path and let your route handlers do any rendering they normally would do on the client side.
I can work on a PR if you agree with the idea.

Sounds great! PR is welcome. Thanks :-)

https://github.com/riot/route/pull/19

Now @gdub22 's works have been merged with #43 and #45 on riot-route#2.3.13! Thank you so much.


relative symbolic links

Does google-drive-ocamlfuse support relative symbolic links?
given a root tree mounted in /export/home/support
and a directory: /export/home/support/bnh/onefile
I can:
cd /export/home/support/bnh
ln -s onefile onelink
but i can not
ln -s ../bnh/onefile onelink
absolulte paths dont work eiither
ln -s /export/home/support/bnh/onefile onelink
also fails.
i can understand why the absolute path does not work...but why wouldn't a relative path contained entirely within the scope of the ocamlfuse mount work

Relative symlinks should work, but only in the latest versions (previous versions had a bug that prevented creating them correctly).

#response_container_BBPPID{font-family: initial; font-size:initial; color: initial;}  I we are running 0.7.25 just downloaded a few weeks ago using the opam instructions...was it fixed since that version?                                                                                Brian HawleyLuminex Software, Inc.1-951-781-4100 x112www.luminex.com                                                                                From<EMAIL_ADDRESS>February 17, 2021 12:17 PMTo<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Re: [astrada/google-drive-ocamlfuse] relative symbolic links (#701)
Relative symlinks should work, but only in the latest versions (previous versions had a bug that prevented creating them correctly).
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

just checking in...whether 0.7.25 should work or not.

No, sorry, you are right. There is a bug because target paths are not normalized, so it returns "File not found".

are there any plans to make this possible?
On 2/28/2021 12:19 PM, Alessandro Strada wrote:

No, sorry, you are right. There is a bug because target paths are not
normalized, so it returns "File not found".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/astrada/google-drive-ocamlfuse/issues/701#issuecomment-787515933,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS4CM77KYBQ5GWYT35S2QLTTBKQNFANCNFSM4XXMVTDQ.

--
Brian Hawley
Luminex Software, Inc.
1-951-781-4100 x112
www.luminex.com

To test the fix, please run:
opam pin add google-drive-ocamlfuse https://github.com/astrada/google-drive-ocamlfuse.git#beta

After testing, if you want to remove the pin, run:
opam pin remove google-drive-ocamlfuse

this seems to be working.    I assume that is now the version that is
installed.   If I were to 'unpin', I would stay at this level, or a next
release if i recompiled, or somehow pulled the git again?
I am not very familiar with ocaml and opam.
On 2/28/2021 1:00 PM, Alessandro Strada wrote:

To test the fix, please run:
|opam pin add google-drive-ocamlfuse
https://github.com/astrada/google-drive-ocamlfuse.git#beta |
After testing, if you want to remove the pin, run:
|opam pin remove google-drive-ocamlfuse |
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/astrada/google-drive-ocamlfuse/issues/701#issuecomment-787522175,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS4CM75YC4ERN5MDNHVUX6TTBKVHVANCNFSM4XXMVTDQ.

--
Brian Hawley
Luminex Software, Inc.
1-951-781-4100 x112
www.luminex.com

You can unpin, because I've published the fixed version.


other platforms to integrate

it would be nice to have bot for other platforms, like mattermost or telegram

i'd really like to see these be community projects created and maintained by someone else who has an interest in telegram and mattermost. the engineer man team maintains piston and the discord bot since that is where our community is headquartered at. we wouldn't really have to time to create and maintain the other ones.

i know I'm very late to this issue , but I'm working on a telegram bot using piston's API, it will be a simple open source telegram bot.


Move parse options to Parser class level properties

Rather than accept options every time a packet is parsed, these should either be passed in the constructor or set via public properties in the aprsParser class.
parseaprs(packet: string, options?: any)

After careful consideration and testing refactoring ideas for this, this will not be done at this time to avoid multiple source issues as outlined above.


Does not work on Windows 10 with JDK 8

Windows 10, JDK 8, start up produces a blank screen. Trying to quit produces a blank quit dialog. Have to end process in task manager.

Upgraded to JDK 10, same problem.

Restart fixed the problem - must have been because I had leiningen running in terminal or something maybe?


Use improved PubSub [auto] nacking for ManagedMessageRecoverer class

Motivation and Context
The Spring Google Pub/Sub libraries don't offer any obvious way to handle errors... it's fairly undocumented. Previously, we were manually nack'ing Pub/Sub messages that we wanted to be retried. On reflection, it would be better if Spring nack'ed the messages, because there's a concern that we might be nack'ing a message which Spring goes on to ack, creating a race condition between what we've done, and what Spring is trying to do.
What has changed
Instead of nack'ing the message ourselves, we throw an exception, so that Spring nacks the message. However, this would cause unwanted logging, so we've changed the logging level to suppress the warnings about auto-nacking.
How to test?
Send in some bad messages and make sure that they don't get lost.
Links
Trello: https://trello.com/c/0WllcvES

 SPIKE: improve ManagedMessageRecoverer nacking (1 day)


[Question] How to configure continue training for a model

What is your question?
I trained a baseline checkpoint for 50 epochs with a LinearLR schedule starting from 1.0 to 0.0 in 50 iters. If I try to continue training that checkpoint on the same dataset or a new dataset, the learning rate is set to zero, eval accuracy remains the same even though the loss is decreasing. Can you please help me continue training so that I can use existing baselines on new datasets
What have you tried?
I tried training a model with a baseline config and update it with a new config to continue training.
Code (if necessary)
No response
What's your environment?

AdaSeq Version (e.g., 1.0 or master):
ModelScope Version (e.g., 1.0 or master):
PyTorch Version (e.g., 1.12.1):
OS (e.g., Ubuntu 20.04):
Python version: 3.7.5
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@Dhanasekar-S Sorry for the lack of documentation. We are now working hard to complete it.
You can add load_all_state: false in your config file, and then run python scripts/train.py -c ${config_file} -ckpt ${checkpoint_path} to do continue training.
An example snippet:
  hooks:
    - type: BestCkptSaverHook
      save_file_name: best_model.pth
      metric_key: macro-f1
      save_optimizer: false
      restore_best: true
      load_all_state: false
    - type: CheckpointHook
      load_all_state: false


docs(plugins) document how to use plugins in DB-less mode

Adds a new way to add "tabs" using liquid templates ({% tabs %} ... {% endtabs %}). Since currently there's no CSS to render tabs, for now this utility renders both options one after the other.
Uses the {% tabs %} utility to render "tabs" in all the generated code which precedes plugins.
Includes manual fixes / rewordings of all Open Source plugin docs to include db-less instructions when possible.

Example of generated code:

I changed the plugin code, it should be good now


Add documentation outlining the steps to transition from placementRul…

Add documentation outlining the steps to transition from placementRule to placement
Ref: https://issues.redhat.com/browse/ACM-12698

/cc @dhaiducek @mprahl


chore: Ensure JS drivers updates happen synchronously

At the moment, dev and production dependencies are split into different
groups. That means that JS driver in adapter packages (where it is a dev
dependcy) might update at a different time than production dependency in
bundled-js-drivers. The whole point of bundled-js-drivers packages
was to avoid version conflicts when adapter are used for engine tests
and that breaks it.

Maybe add @types/pg?


TestPluginActive consistently failing

9c8e1c3c06d8a9cab623e75dcdab3ba9e84c6856
$ TESTFLAGS='-check.f TestPluginActive' make test-integration-cli
...

All profile caches have been cleared, but no profiles have been unloaded.
Unloading profiles will leave already running processes permanently
unconfined, which can lead to unexpected situations.

To set a process to complain mode, use the command line tool
'aa-complain'. To really tear down all profiles, run the init script
with the 'teardown' option."
Makefile:127: recipe for target 'test-integration-cli' failed
make: *** [test-integration-cli] Error 1

docker.log
Even failing on CI: https://jenkins.dockerproject.org/job/Docker-PRs-experimental/26202/console

The test depends on tiborvass/no-remove, which seems updated two days ago
PTAL @tiborvass please
https://github.com/docker/docker/blob/6ee25e6277c930c71ff0e5c68ec6d66845b7f88f/integration-cli/docker_cli_plugins_test.go#L13-L15
https://hub.docker.com/r/tiborvass/no-remove/tags/

Fixed

thank you :smile:

And can we use a non-"latest" tag for determinism?


[Question] Save timeline of a thread as an svg

Is there a way to dump/save SVG/pdf plots for each thread timeline?

No there is no such feature nor would we want to add any such feature to the Perfetto UI. Not sure what you're trying to accomplish but whatever it is can probably be done better by querying the trace programatically with trace processor (e.g. with the Python API: https://perfetto.dev/docs/analysis/trace-processor#python-api)


New version to maven central

Hi,
i just want to know if you plan to create a new release and distribute it to maven central?
Do you like to continue development ? Cause i'm interested in continuing...
Kind regards
Karl HEinz Marbaise

I would say simply. Make a release and continue. If we found problems we will file in issues...don't hesitate to make new released which improves only small things...Please continue your good work....If you like having help please ask...
Kind regards
Karl Heinz Marbaise

Then the answer is simple ;).

I agree with you guys.
If we let things get bigger it will be more difficult to release a new version after all.
@cosmin, if you need help, please ask. :+1:

I'll push a version to central select as 0.3.0.

Version 0.3.0 should be making its way through the Sonatype tubes and hit Maven Central in the next few hours. Thank you all for the patches in this version. Please keep them coming.


Link vscode controlled json files to jsonc (json with comments) snippets instead of to json.

If you want to make a snippet for vscode controlled user editable json files, settings.json, keybindings.json, tasks.json, snippets/*.json, .vscode/*.json etc.., essentially, I believe, all json with comments files which really ought to have been named *.jsonc, you have to use the snippets/json.json and not the actual available snippets/jsonc.json.
My proposals/suggestions are:

Link vscode controlled user editable json files to snippets/jsonc.json snippet instead of snippets/json.json
Alternative: Rename all vscode user *.json files to *.jsonc to reflect what they really are.

Ok, now I understand. I'll push a fix.
It's a dup of #120190

Oh thanks for the fix.
(Technically #120190 is a dup of this as it's 7 days younger than this)


[RIP-10] Add test case for ConsumeMessageOrderlyService

What is the purpose of the change
[RIP-10] Add test case for ConsumeMessageOrderlyService
Brief changelog
ConsumeMessageOrderlyServiceTest
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.1%) to 48.781% when pulling 13f88c798db9ceae9d9dc291560e6d7a1a8e6c5d on tandanzZ:develop into 3e1a5ccd697616352119dc63b6b1c3ff716c6950 on apache:develop.


Cmake C++ Flags fix

Fix for cmake, which didn't add the C++ compiler flags.
There's currently a build failure of cmake clang – anyone an idea what's the problem there?

Coverage remained the same at 99.875% when pulling<PHONE_NUMBER>20a7adc58c5da5c77f9da0ea9d7427 on offa:cmake_cpp_flags_fix into 33376c201252cf172948fae0104ffe6133f28593 on cpputest:master.

no idea :/

I've sent you a PR on your own branch that fixes the problem.
This happens in old versions of cmake, because internally in check_cxx_source_compiles, which is indirectly called by check_cxx_compiler_flag, something like if("${VAR}" MATCHES "^${VAR}$") is performed in the passed variable, and that really messes up things a bit if the variable name (e.g. WARNING_CXX_FLAG_flag_which_is_being_tested) contains an special regex character like "+".
In newer versions of cmake it's been replaced by if(NOT DEFINED ${VAR}), so this problem wouldn't happen, but anyway, the workaround that I propose is necessary to maintain compatibility with older cmake versions.

This happens in old versions of cmake,

I see, this explains why it fails for CI (Cmake 2.8) but works for me (Cmake 3.x).
@jgonzalezdr thank you very much for your help! I've merged your PR.

Coverage remained the same at 99.875% when pulling ee62cb0d80133fe9692355ddab502611f3e69714 on offa:cmake_cpp_flags_fix into 33376c201252cf172948fae0104ffe6133f28593 on cpputest:master.


Switch network proxy in settings

Would it be possible that we can switch network proxy just in settings because players in some area may suffer from bad local network.

Are we talking about the GalaxyClient settings, or a way to provide these settings to the plugins? The former is out of the context of this repo and should be reported directly via GLX cogwheel menu -> Share feedback.


Address cpp-check issues

Scope & Purpose
Address cppcheck issues

[x] :hankey: Bugfix
[ ] :pizza: New feature
[ ] :fire: Performance improvement
[ ] :hammer: Refactoring/simplification

Checklist

[ ] Tests

[ ] Regression tests
[ ] C++ Unit tests
[ ] integration tests
[ ] resilience tests

[ ] :book: CHANGELOG entry made
[ ] :books: documentation written (release notes, API changes, ...)
[ ] Backports

[x] Backport for 3.9: (Please link PR)
[ ] Backport for 3.8: (Please link PR)
[ ] Backport for 3.7: (Please link PR)

Related Information
(Please reference tickets / specification / other PRs etc)

[ ] Docs PR:
[ ] Enterprise PR:
[ ] GitHub issue / Jira ticket:
[ ] Design document:

[ ] https://jenkins.arangodb.biz/job/arangodb-any-cppcheck/87/

[ ] https://jenkins.arangodb.biz/job/arangodb-any-cppcheck/88/


chore: pull in SDL scan as part of main build pipeline

This PR pulls in the APIScan and BinSkim scans as a new stage to the main build pipeline. In turn, it removes the need for a separate SDL pipeline.
This PR is an intermediate solution; I believe that we'd optimally want the APIScan and BinSkim scans, and the configurations required for them, to be part of the Windows build pipeline.
Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=278624&view=results

LGTM, should this pipeline be disabled as part of the PR https://dev.azure.com/monacotools/Monaco/_build?definitionId=197&_a=summary ?

That's a good idea considering the SDL template changes with this PR. I have disabled the VS Code Scan (SDL) pipeline.

Is there a reason why we are pursuing this "intermediary" solution? What what I can tell the 1ES pipeline template does not automatically inject the API Scan job but based on Teams messages it does look like the SDLBinaryAnalysis stage does have parameters to control the API Scan job. The job would have to be added as a PostAnalysis task.

I'm keeping APIScan and BinSkim in a separate stage for now because I wasn't able to get the 1ES template to scan the BinSkim files nicely, and because I'm not sure whether we want to publish the product with the flags required for APIScan.


feat(agents): add killswitch binary

Motivation
Enable quicker response to black swan events
Solution
CLI tool that exposes command(s) for manually disconnecting replicas from the token bridge (or other future apps)
PR Checklist

[x] Added Tests
[x] Updated Documentation
[x] Updated CHANGELOG.md for the appropriate package
[ ] Ran PR in local/dev/staging

Couple remaining minor nits but this overall lgtm. Pretty awesome.
We should run in local-env first I'd say, then merge :)

Thanks, should all be addressed now


Good bye react-native-gifted-spinner!

Thank you React-Native-Gifted-Spinner for all the fun we had while waiting lazy APIs load data from the backend..
ActivityIndicator you have big shoes to fill..

Thank you @rturk :)

Many thanks @rturk

Many Many Thanks rturk


add encode_to_mut_string

As i understand it your now managing this crate, hope this is right else i can make a pull request at bt/rust_urlencoding.
Today i wanted to build a query string generator and found no way to use an already existing buffer/string.
This pull request just adds this functionality. I'm not sure about the name, maybe you have a better one.
If you want i can also add an equivalent function decode_to_mut_string that however would probably require to create decode_into.

I've implemented Encoded(str) that supports zero-copy io::Write and Display instead. You can use it with format! or write! macros.

Nice, thanks.


Release to marketplace

:tada: This PR is included in version 0.117.0 :tada:
The release is available on:

v0.117.0
v0.117.0
GitHub release

Your semantic-release bot :package::rocket:


fix(deps): update logs agent to version 1.3.2

Description
Update logs agent to version 1.3.2. (There is an internal tracking issue to have renovate do this)
Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 2.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Scala.Names.encode does not handle Scala keywords

While checking whether a name should be quoted, Scala.Names.encode does not check for Scala keywords. For example, a variable named macro should be encoded as `macro` but right now it's not quoted after being encoded. I believe this is the root cause of https://github.com/liancheng/scalafix-organize-imports/issues/101.
The following diff is probably good enough to fix it:
diff --git a/semanticdb/semanticdb/src/main/scala/scala/meta/internal/semanticdb/Scala.scala b/semanticdb/semanticdb/src/main/scala/scala/meta/internal/semanticdb/Scala.scala
index c38c3f153..64b892fb4 100644
--- a/semanticdb/semanticdb/src/main/scala/scala/meta/internal/semanticdb/Scala.scala
+++ b/semanticdb/semanticdb/src/main/scala/scala/meta/internal/semanticdb/Scala.scala
@@ -175,6 +175,8 @@ object Scala {
     private[meta] def encode(value: String): String = {
       if (value == "") {
         "``"
+      } else if (tokenizers.keywords(value)) {
+        "`" + value + "`"
       } else {
         val (start, parts) = (value.head, value.tail)
         val isStartOk = Character.isJavaIdentifierStart(start)

Thank you for reporting! I think the current behavior is working as expected according to the SemanticDB spec https://scalameta.org/docs/semanticdb/specification.html#symbol-1

For other definition, the name of the binding introduced by the definition [70]. If the name is not a Java identifier [22], it is wrapped in backticks.

You can use “scala.meta.Term.Name” as an alternative if you want to generate valid source code that handles things like backticking identifiers.

Thanks for the pointers, @olafurpg! I later realized that I was using Term.Name and TreeSyntax indrectly instead of the Scala.Names.encode method while generating the source code. (I got the wrong impression due to https://github.com/scalacenter/scalafix/issues/1097.)
However, we still had the issue that the name macro is not properly quoted. Further investigation showed that it's because macro is not listed as a keyword in scala.meta.internal.tokenizers.keywords. On the other hand, a token class named KwMacro can be found in scala.meta.tokens.Token, which seems to suggest that macro is indeed a keyword. And, macro is indeed listed as a "reserved word" in the Scala 2.13 language specification. Is this a bug?

Here is a simple reproduction using Ammonite:
@ import $ivy.`org.scalameta::scalameta:4.3.20`, scala.meta._
import $ivy.$                                , scala.meta._

@ val Import(Importer(ref, _) :: Nil) = q"import `macro`.X"
ref: Term.Ref = Term.Name("macro")

@ ref.syntax
res13: String = "macro"

That looks like a bug then. The macro keyword got introduced in 2.10 I think. We should add macro to the keyword list.

Thanks! I'm gonna close this one and create another issue to track the missing macro keyword issue.


Update docs to indicate support for NSX-T 2.3

Updates RNs and NSX-T upgrade sections to indicate PKS 1.2.x supports NSX-T 2.3. Please hold off on merging until the word is official. thanks

Thanks @lparis!


more model classes tested locally

Benchmark
: a sorted array of boundaries between achievement levels
Standard
: a dictionary of Benchmarks which uses test times as keys

This should work just fine.


How can I make extension for lapce

Is your feature request related to a problem? Please describe.
As I am coming from VsCode I was using several extensions for syntax highlighting, and bracket colouring. How can use them or make one and publish it?
Describe the solution you'd like
Make an extension portal where developers can access the extension.

Not 100% on this, but I've started looking at making a LSP plugin for csharp_ls. If you are looking to create a LSP plugin, there is a template here: https://github.com/lapce-community/lapce-volt-template
If you want to install the plugin, you can compile the wasm and dump it in the lapce plugin directory which should get picked up on start.
Otherwise lapce uses tree-sitter parsers for most languages, you can see the support list here: https://github.com/lapce/lapce/issues/272
The whole theming thing is a little over my knowledge. Hope this helps, cheers

Duplicate of https://github.com/lapce/lapce/issues/123


[Request] Make some fields, methods public / make public methods to access fields

Currently making OCRocketry addon and it would be awesome if you will make some fields, methods public or if you will make a way to access them:
TilePlanetaryHologram:

[ ] TilePlanetaryHologram#selectedPlanet
[ ] TilePlanetaryHologram#currentStar
[x] Public methods to get/set size
-----------------------------------
[ ] Maybe something to prevent destination selection for warp controller with holographic planet selector. I mean, it's cool, but what if I don't want it to be set immediately? So... Any way to prevent it
-----------------------------------

Altitude Controller | Gravity Controller | Orientation Controller | Big Gravity Controller:

[ ]  Get current values and set target values

TileSpaceElevator:

[ ] Get capsule entity

And any way to use

[x] TileWarpShipMonitor#meetsArtifactReq
[x] TileWarpShipMonitor#getTravelCost
(maybe even make them static or move outside of their classes. As you wish)

Sorry for any grammar mistakes, english isn't my native language

Now that the sides of the entity are exposed, is getting capsule entity even needed?


sBTC draft doc add more content to sections

Looks like the draft PR was merged. Here are some more unmerged additions.

this PR will close https://github.com/stacks-network/sbtc-docs/issues/13

outdated


[gen-readme] Allow custom templates

Summary
This adds:
Flag that saves default template
devbox generate readme [path] --save-template

Flag that uses custom template
devbox generate readme [path] --template <custom-template>

It also:

defaults readme [path] to README.md
defaults template [path] to readme.tmpl
If there is readme.tmpl in root, then devbox generate readme will use it automatically.
Fixed missing env vars from default template

How was it tested?
devbox generate readme --save-template # generate template
vi readme.tmpl # modified template
devbox generate readme devbox.md # tested creating new readme

@savil gentle ping

@mikeland73 sorry for the delay in reviewing this. I'm a little hesitant with this design. I don't love having golang templates be the expected UX for our users.
I'm curious if there's a markdown template where one can more natively separate the auto-generated parts from the user-written parts of the markdown file...

@savil we already use golang templates for plugins, and generally go applications expose go templating (e.g. Helm being a fairly prominent example) so I don't think it's unexpected or bad UX.
I think if we try to use markdown for this we will end up inventing our own templating. I would much rather re-use golang templates.
I also considered  allowing injecting the readme into a specific portion of a manually created file, but that is very limiting (so limiting, that we would probably not use it ourselves). But as built, this would be useful for us right away in Axiom.


Ship updated packages once the manifests are changed with min Unity version

Ship updates to all packages to include correct the minimum version of Unity.
This is blocked by the following:

9/13 - decided to hold release until slider audio scripts are checked in by David Kline, and min version of Unity is updated in package manifests by shaynie

Updating title for core package only


Remove empty array used to initially set global pbjs object variable

When prebid is not returned the empty array used to set the initial object is passed and appended to the last object instead of ignored. This invalidates the json structure.

resolved with recent refactor


bug: Ionic View Android cannot login or load an app

Type: bug
Platform: android 4.4 webview
Environment: Ionic View 0.0.2, Android 5.0.1
Login issue: Open app, enter username and password and hit submit. App does not log me in nor provide any error or feedback whatsoever.
Load app issue: Manually enter an app ID or scan QR code, app returns "Invalid app id or no connection to server".
Sorry if this is the wrong place to report, I couldn't find any issue tracker for the app.

Greetings @bostondv!
My sensors indicate that you need to update your issue through our custom issue form. We are now requiring all issues to be submitted this way, to ensure that we have all of the information necessary to fix them as quickly as possible.
Click Here To Update Your Issue
I will have no choice but to close this issue if it is not resubmitted through the form. Please fill out the rest of the form, so that I may use my friendly robot powers to assist you.
Thank you!

Hey sorry to hear you're having issues, that is a really old version of View, try updating to 1.0.0.

Just grabbed 1.0.0 when it was released the other day. Works great!
On Mar 4, 2015 12:52 PM, "Tim Lancina"<EMAIL_ADDRESS>wrote:

Hey sorry to hear you're having issues, that is a really old version of
View, try updating to 1.0.0.
--
Reply to this email directly or view it on GitHub
https://github.com/driftyco/ionic/issues/3183#issuecomment-77208800.

Awesome! Glad it's working.

I am facing the same issue.
I have view 1.0.0. When I install the app through ioninc run android, it opens the app fine. But when I upload and view the app from view, it does not view from there. Any suggestions?

I've just installe the 1.0.5 versión and the same password problem. At the same time I login in ionic dashbord web so I coudt be a password problem.
Please help,
regards !!!!


How can I run the DAMD with the L_sto loss ?

Thanks for your nice work!
I try run the damd model.
After Estimated Behavior Policy, I only get the fn_Gs_10_0.0_act_soft.json, but not fn_Qs_10_0.0_act_soft.json.
Thus, when I run the end-2-end damd, I only can use the L_det loss, but can not use the L_sto loss.
What's the problem ? How can I get the fn_Qs_10_0.0_act_soft.json ?

@FlyingCat-fa Hello, I also run this code with paper. In my experience, I made a result fn_Gs_10_0.0_act_soft.json after Reward Learning, got a result fn_Qs_10_0.0_act_soft.json from Estimated Behavior Policy. I hope it helps you.

@FlyingCat-fa Hello, I also run this code with paper. In my experience, I made a result fn_Gs_10_0.0_act_soft.json after Reward Learning, got a result fn_Qs_10_0.0_act_soft.json from Estimated Behavior Policy.

Thanks a lot. I got the fn_Qs_10_0.0_act_soft.json according to your comment.


Redesign AST to use Vec

ast::Expression is the most central node in the AST. Currently it uses a lot of Box. It might be that reserving some memory upfront and packing the nodes in a Vec will improve performance a bit.

[ ] Redesign to use usize and Vec<Expression>
[ ] Test performance before merging

Before:
test tests::bench_add_two ... bench:  25,862,367 ns/iter (+/- 821,304)
test tests::bench_main    ... bench:   2,133,498 ns/iter (+/- 103,981)

test tests::bench_add_two ... bench:  24,893,790 ns/iter (+/- 648,306)
test tests::bench_main    ... bench:   2,136,041 ns/iter (+/- 84,958)

test tests::bench_add_two ... bench:  25,113,612 ns/iter (+/- 589,557)
test tests::bench_main    ... bench:   2,118,409 ns/iter (+/- 78,786)

Before (rustc 1.8.0-nightly (fae516277 2016-02-13)):
test tests::bench_add_two ... bench:  42,703,942 ns/iter (+/- 497,623)
test tests::bench_array   ... bench:  44,365,455 ns/iter (+/- 653,030)
test tests::bench_call    ... bench:  44,378,526 ns/iter (+/- 507,701)
test tests::bench_main    ... bench:   2,400,300 ns/iter (+/- 29,974)
test tests::bench_n_body  ... bench: 235,848,354 ns/iter (+/- 1,685,919)
test tests::bench_object  ... bench:  53,252,451 ns/iter (+/- 737,784)

I suspect that the shallow clone on left argument in ?= https://github.com/PistonDevelopers/dynamo/issues/19 to check the type causes the regression in performance.

Nope, wasn't the shallow clone.

Hmm... this seems to be slower:
test tests::bench_add_two ... bench:  45,273,587 ns/iter (+/- 577,767)

Think there are some bugs, but won't go further with this.
Closing.


[nri-bundle] Bump newrelic-logging and newrelic-k8s-metrics-adapter

Is this a new chart
No
What this PR does / why we need it:
Bump newrelic-logging and newrelic-k8s-metrics-adapter to latest versions, as discussed in #583
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [mychartname])

Thanks for the contribution @neilfordyce ! 🚀


Version v14 is deprecated. Requests to this version will be blocked.

Hello. Today after sending a request that message was shown :
An error with code INVALID_ARGUMENT occurred: errors {
  error_code {
    request_error: UNSUPPORTED_VERSION
  }
  message: "Version v14 is deprecated. Requests to this version will be blocked."
}
request_id: "sJs1CcJFOPnhVftPDbYPSA"

Will you upgrade the code for the new version?

I upgrade the dependencies... And it works again, so my bad. 😖

I upgrade the dependencies... And it works again, so my bad. 😖


Fork for this repo

Somebody have a fork for this repo with updates? The last updated version in PyPi is in 2016, pull request for quick replies pending and Issues pending to close.
I'm very grateful with David for this repo, but, I think this project need updates with urgency.

this repository seems to be no longer maintained.
you can try the framework Ampalibe for creating bot messenger


MEDIA_ROOT en STATIC_ROOT should be overriden in dev

By adding:
STATIC_ROOT = '/home/web/static'
MEDIA_ROOT = '/home/web/media'

to django_project/core/settings/dev_dodobas.py and writing a clear instruction in README.md this installation issue can be prevented. For my personal setup, I have changed them to:
STATIC_ROOT = '../deployment/static'
MEDIA_ROOT = '../deployment/media'

this was fixed, https://github.com/healthsites/healthsites/blob/master/django_project/core/settings/base.py#L48


initial support for i18n

closes #53

When this PR gets merged:
Should translations be contributed directly to this repo or are they managed via Damned Lies, the GNOME Translation Project?

Glad to see someone already willing to contribute! :o
Is Damned Lies open to 3rd party softwares? I am under the impression it is not.
Either way, I'm just getting started with GNU gettext, I'd prefer simple pull requests for now while I get used to it :p

Thanks for the appreciation ;)
Yes, there is a section for 3rd party software in DL. I'm not sure if it is a hard requirement to host the repo on GNOME's GitLab instance though...
If you are willing to try it, feel free to contact the l18n mailing list!


Added prometheus docker swarm discovery (python)

Added a link to my docker swarm implementation

To encourage the community to rally around one solution, and not continuously create new ones from scratch,  we aim to avoid duplicates in these lists. Which of these is the most popular and/or in line with best practices?

My project is hardly going to win a popularity contest in a week, that's sure. But I will take my odds vs a project that is advertised as a POC that has issues that are still unresolved, if memory leaks and file descriptor depletion is best practice, my odds shouldn't be so bad.

It'd be better to work to improve what's already there, rather than creating a brand new thing from scratch. Otherwise we end up with many okay integrations, rather than one really good one.

It'd be better to work to improve what's already there, rather than creating a brand new thing from scratch. Otherwise we end up with many okay integrations, rather than one really good one.

I respectfully disagree. Having many integrations doesn't mean you'll have many okay integration instead of a good one. With the way things are going it's closer to one poor integration than many okay ones. Sometimes it's better to rewrite from 0 than to carry old code with its bugs around. Having multiple integration is not inherently bad. As some developer from one community might not be in a position to contribute in a language they don't know enough to contribute.
If there was an active maintainer and the project was being updated at least headed somewhere, things would be a bit different. This project has been dead a week after its creation and it did get a few forks and receives changes in forks that arguably "improvements" but more personal requirements.
My integration drastically changes the way it works and how it can be implemented so even if I wanted to contribute, I'd still probably end up with a complete rewrite... I'd want to get it merged I'd receive the answer: "It's too different from the original project." if I received any answer at all. So instead of wasting my time, I implemented something that fulfils most of my needs and gives similar feature as the original (as a compatibility feature) including improved functionality and stability. The developers of the original project had 3 years to do that. If nobody help improve the project in 3 years, may be there's nothing worth improving.
On the other side, my project, while pretty stable and functional does still have ways to be improved. It has been written in roughly 3 days, so there's a lot of things to clean up and simplify without breaking existing functionality. Eventually support other backend than docker swarm.
Then it wouldn't fall into the Docker Swarm integration wouldn't it?

I was stating the general goal behind the curation rules applied here, specifics vary of course. It is not a good strategy to list every new integration here of a given type that has been created as that ultimately does not serve the long terms needs of the community. For example we'd be listing at least 5 different Swarm integrations here, and be leaving it up to the users to figure out which ones actually work. Google can provide that service, without us having to maintain an explicit list.
Keep in mind that this is only one list, and it does not aim to be definitive or exhaustive. Nothing stops you from developing and promoting your integration outside of this (e.g. posting to prometheus-users) and building a good community around it. It'd be premature to list it here though.


gdx-lwjgl3-angle extension to add rendering support through ANGLE

(Original discussion, redid PR so commits are clean)
What and why
This PR adds and extension to support rendering through ANGLE instead of emulating OpenGL ES 2.0 via the desktop OpenGL APIs. On Windows, DirectX 9 or 11 is used to render. On Linux calls are passed through to the desktop OpenGL implementation or, if available, a native OpenGL ES and EGL implementation. On macOS, OpenGL ES 2.0 is emulated via Metal.
This extension is especially useful on macOS, where Apple will eventually remove OpenGL entirely. And even if not, their OpenGL-on-top-of-Metal implementation is already a buggy mess, especially on Apple Silicon.
On Windows, the extension can be useful to increase compatibility with hardware that has shoddy OpenGL drivers.
ANGLE is used extensively by Chrome and Firefox on Windows and is thus battle tested and very stable. It is also a free alternative to MoltenGL on macOS.
Usage

Add gdx-lwjgl3-angle as a dependency to your gdx-lwjgl3 desktop project.
Call config.setOpenGLEmulation(GLEmulation.ANGLE_GLES20, 0, 0) on your Lwjgl3ApplicationConfiguration instance before creating your Lwjgl3Application.

Caveats

~Doesn't work on macOS at the moment, due to dylib loading shenanigans. Will fix and amend the PR.~
~For some reason, the frame rate drops when multiple windows are opened on macOS.~ There's either a bug in ANGLE or GLFW, in any case, there's a workaround, see https://github.com/badlogic/libgdx/commit/2c32d11dcc94ada252f0e1480798d9a964d5f677#diff-424a1076f33ca5f397d61490a4f2e1500e7a1287d24cdccf72f999eea0c5270bR69
Wasn't tested on Linux, but should work (TM)
Does only support OpenGL ES 2.0, as the macOS ANGLE Metal backend only supports OpenGL ES 2.0 at this point in time.
Requires LWJGL 3.3.0-SNAPSHOT, as that contains a more recent GLFW version and binds ANGLE specific constants.
The ANGLE binaries are commited directly into the repository. They are taken from https://github.com/xiaozhuai/angle_builds and can be updated as needed. Building them ourselfs as part of the libGDX CI adds significantly to the build time (30-50 minutes per platform).

LWJGL 3.3.0 is out. I'll publish the ANGLE binaries as a separate package to Maven on which gdx-lwjgl3-angle will depend. They won't need uodating often anyways. Then I shall !erge this glorious PR.

What is the purpose/reasoning for the seperate ANGLELoader class over SharedLibraryLoader?

shared lib suffixes is one reason, but this is the main reason:
https://github.com/libgdx/libgdx/pull/6672/files#diff-06240c617472b87c94e1b16cee91ea906828e974b830bb64af6d26a3f1a672b9R198
On Sat, Nov 27, 2021, 17:37 PokeMMO @.***> wrote:

What is the purpose/reasoning for the separate ANGLELoader class over
SharedLibraryLoader?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/pull/6672#issuecomment-980688579, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5QBDQP4QEXWM53MNPU2TUOECOJANCNFSM5FM3FBAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

I've addressed all issues above and rebased the fork on the current master. The ANGLE natives are now stored here: https://github.com/libgdx/gdx-angle-natives. They are fetched from there through fetchNatives and placed in extensions/gdx-lwjgl3-angle.

Stupid question: Doesn't the library need to be added in publish.gradle?
At least when I'm trying to build it myself to mavenLocal I can't figure it out without that.
Something like this:

Yes, @pokeMMO already did that PR was merged a few hours ago, pull the
latest changes.
On Fri, Jan 21, 2022, 17:55 Lyze @.***> wrote:

Stupid question: Doesn't the library need to be added in publish.gradle?
At least when I'm trying to build it myself to mavenLocal I can't figure
it out without that.
Something like this:
[image: idea64_G8bHED9Ekc]
https://user-images.githubusercontent.com/11274700/150567578-b9b262fd-cf75-41bf-b228-c410169d8279.png
—
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/pull/6672#issuecomment-1018686141, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5QBET3FSEKIXEIKPQH2LUXGFW7ANCNFSM5FM3FBAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you modified the open/close state.Message
ID: @.***>


An error appears when trying to authorize Last.fm in Linux Ubuntu 18.08

OS: Linux Ubuntu 18.04
GPMDP Version: 4.6.1
Issue Descriptions:
When trying to authorize Last.fm from settings there is always an error stating: "You appear to have left the authorization process, if this is a mistake, please try authorizing again"
Steps to Reproduce:

Open GPDMP
Open Desktop Settings
Open the Last.fm tab
Click the link "Login to Last.fm"
Wait for the page to appear
Enter credentials
Press Login
Notice that an error appears

I've having the same issue but on Windows 10, tested from https://www.googleplaymusicdesktopplayer.com/ as well as building it and putting my own API keys in the constants.js folder and still no luck. When I try to hit the button it just instantly kicks me before I can even put in my information.

Same issue while trying to login for the first time on Mac OS Mojave 10.14.1

Same thing is happening to me on Windows 10, just downloaded the app and tried connecting last.fm getting errors every time i press the "Let me in!" button.

Duplicate #3486


Scons does not detect X11

Godot version:
major = 4
minor = 0
patch = 0
status = "dev"
module_config = ""
year = 2020
OS/device including version:
Ubuntu 18.04.4
Issue description:
Scons does not detect X11
Steps to reproduce:

Clone the repo
cd godot
scons3 -j4 platform=x11 (scons3="/usr/bin/env python3 $(which scons)")

Output:
scons: Reading SConscript files ...
Invalid target platform "x11".
The following platforms were detected:

	haiku
	linuxbsd
	server

Please run SCons again and select a valid platform: platform=<string>

But I have X11 installed. Here the output of my dpkg -l | grep xserver-xorg-core
ii  xserver-xorg-core-hwe-18.04                                 2:1.20.5+git20191008-0ubuntu1~18.04.1                       amd64        Xorg X server - core server

This commit seems to imply that x11 was renamed to linuxbsd.
But if that's the case, then the documentation has to be changed.

I wonder if we should alias x11 to linuxbsd to prevent errors like this. Many third-party documentation websites will never be updated :slightly_frowning_face:

@Ev1lbl0w  That is how I got it to work. Ran it with platform=linuxbsd and everything went off fine.

This should make it rather obvious:
The following platforms were detected:

        haiku
        linuxbsd
        server

Still, I somehow missed that and ended up finding this issue instead :man_facepalming:


[SPARK-15248][SQL] Make MetastoreFileCatalog consider directories from partition specs of a partitioned metastore table

What changes were proposed in this pull request?
Table partitions can be added with locations different from default warehouse location of a hive table.
CREATE TABLE parquetTable (a int) PARTITIONED BY (b int) STORED AS parquet
ALTER TABLE parquetTable ADD PARTITION (b=1) LOCATION '/path/1'
Querying such a table throws error as the MetastoreFileCatalog does not list the added partition directory, it only lists the default base location.
The solution in this PR to get the paths to list from the partition spec. This is okay because this FileCatalog is only used for partitioned tables.
How was this patch tested?
unit tests.

Test build #58224 has started for PR 13022 at commit 29148c9.

Test build #58224 has finished for PR 13022 at commit 29148c9.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58224/
Test FAILed.

Merged build finished. Test FAILed.

@yhuai Please take a look.

Test build #58284 has started for PR 13022 at commit 8ab243c.

Test build #58284 has finished for PR 13022 at commit 8ab243c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58284/
Test PASSed.

Merged build finished. Test PASSed.

Test build #58297 has started for PR 13022 at commit 6b81f8f.

Test build #58297 has finished for PR 13022 at commit 6b81f8f.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58297/
Test PASSed.

LGTM. Merging to master and branch 2.0


Data disk attachment on VM creation

Add the ability to attach disks to VMs on creation, to prevent timing issues

@JSpon Thanks for your contribution. Can you please add tests for this?  It's also good to follow this once you've added your tests as this can help catch things before the github workflow runs it.


Not showing all dates for calendar column type in React

All dates are not visible for some months in date picker for calendar column type. Attaching screenshot for reference

Above screenshots displays Mar month but shows dates till 28th only.
Can you please provide solution for the same.

This has been fixed quite some time ago. I would suggest you get the most recent version of both jexcel and jsuites.

Thank you for the help.


Feature 2373- move widgets to all locations

Changes Made

Moved the following widgets from road_segment_widgets to all_location_widgets:

killed_and_injured_count_per_age_group
killed_and_injured_count_per_age_group_stacked
injured_count_by_severity

Fixed the /api/infographics-data endpoint's news_flash_id argument (reflects the update in the Swagger documentation).

Resolved a bug in the histogram within the killed_and_injured_count_per_age_group widget. Previously, when there were no accidents with the "unknown" type, the widgets crashed. This issue can be observed in the production logs. For instance, the following API call was successful:

https://www.anyway.co.il/api/infographics-data?lang=he&news_flash_id=154488&years_ago=5

However, the same API call with a 3-year parameter instead of 5 resulted in a crash:

https://www.anyway.co.il/api/infographics-data?lang=he&news_flash_id=154488&years_ago=3

The issue arises when there are no accidents with an "unknown" type within the last 3 years, as all the accident ages are known during that period.

Codecov Report
Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (dfca9c4) 52.98% compared to head (9d19879) 53.27%.

Files
Patch %
Lines

...ed_and_injured_count_per_age_group_widget_utils.py
60.00%
6 Missing :warning:

...ations_widgets/injured_count_by_severity_widget.py
80.00%
3 Missing :warning:

anyway/widgets/widget_utils.py
71.42%
2 Missing :warning:

anyway/models.py
0.00%
1 Missing :warning:

...s/killed_and_injured_count_per_age_group_widget.py
83.33%
1 Missing :warning:

...ously_injured_killed_in_bicycles_scooter_widget.py
0.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2512      +/-   ##
==========================================
+ Coverage   52.98%   53.27%   +0.29%
==========================================
  Files         117      117
  Lines        9645     9674      +29
==========================================
+ Hits         5110     5154      +44
+ Misses       4535     4520      -15

Flag
Coverage Δ

unittests
53.27% <73.07%> (+0.29%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@EliorGigi great! Can you fix black (see this - can be executed in anyway container) and pylint issues? (you can see details here


Update scripts

Codecov Report

Merging #214 into release-rc2 will not change coverage.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##             release-rc2     #214   +/-   ##
==============================================
  Coverage          28.58%   28.58%
  Complexity           330      330
==============================================
  Files                110      110
  Lines               3579     3579
  Branches             256      256
==============================================
  Hits                1023     1023
  Misses              2476     2476
  Partials              80       80

Impacted Files
Coverage Δ
Complexity Δ

...nk/wecross/p2p/engine/RestfulP2PMessageEngine.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)

...k/wecross/p2p/netty/response/ResponseCallBack.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)


Call on('notification') immediately in background (Android)?

How can this plugin be configured so that on('notification') gets called immediately while it is in the background?
Essentially we need to make it so that the user receives a normal push notification (for example, a messaging app of someone saying "hi"), but the message will already have been handled and visible in the app whether the user taps the notification or the app icon itself.  Right now, if the user taps the app icon, it brings the app to the foreground but they will not see that the sender said "hi".

Please read: https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#push-message-arrives-with-app-in-background

Perfect, I can't believe I overlooked that, I was trying to find an flag for it in the option parameters -- including content-available in the payload does exactly the trick.  Thanks!


Clarify licenses used

Hi, from what I can see the repo is primarily licensed under MIT but the third party notice file includes many other packages that I don't directly see in here.
Are these the licenses of possible dependencies or where are they from? If they're pulled in when running pip install they shouldn't really be needed in here, I would assume. Or are they in here for a different reason?
Thanks!

@BastianZim, yes, this repo is licensed under MIT. The Third Party Notice file includes the licenses of package dependencies but are not relevant to the code maintained in the repo.


[1040] Fix backlinks

Context
https://trello.com/b/BBEuhbHM/publish-register-sprint-board
Changes proposed in this pull request

Fix the backlinks on defer and withdaw pages. The URL of these pages, e.g. /trainees/:trainee_id/withdraw poses a problem for PageTracker because it if we visit say /trainees/:trainee_id/withdraw/confirm beforehand, the confirm page will get removed from history after entering the /trainees/:trainee_id/withdraw.
Fix url for some hardcoded backlinks
All backlinks in form pages use the word "Back" only
Minor I18n changes

Guidance to review

Visit the defer and withdraw pages. Entering the form page the backlink should bring you back to either the trainee record page (if you came from there), or the confirm page (if you came from there).
Check that all backlines on form pages use the word "Back"

 Back to record, needs to go to trainee


Update Composer dependencies (2024-07-27-00-19)

Visual regression test passed!
View the visual regression test report


Great documentation but not easily to maintain.

Great documentation but not easily to maintain.
Generally apps are done by IT or citizen developer in his own language.  Then he ask business user (because often terms used are business oriented) to translate terms.
This solution as import excel table uses static data.  And Excel is easier to maintain than json file.
Now, if we want business user to translate, either we give them excel file or we pull all translation in SharePoint list.
Do you see another way to easily maintain translations ?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 70b557d3-7967-698e-38e0-e28ad06df9df
Version Independent ID: 55105264-7746-12ac-b3db-c34eb96b429f
Content: Build a multi-language app - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/multi-language-apps.md
Service: powerapps
Sub-service: canvas-maker
GitHub Login: @mduelae
Microsoft Alias: lunune

@vincentnoiset This is a great question. Unfortunately, we're unable to handle Support requests for the product here. To contact Support, see here: https://powerapps.microsoft.com/support.
Thanks,
Mints


Proposal: Alter/improve/split file format for .vha2 files

Having a vha2 file be json might come with serialization/deserialization implications as it grows in size so there might be wisdom in migrating to sqlite or some similar local database variant.
In the absence of a full file format migration or split, there may be wisdom in refactoring the schema to better account for the predominant access pattern (which forgive my ignorance) is:

Doing a lookup by vha custom hash (seems unlikely).
Doing a lookup by partialPath and fileName (most likely).

Assuming that is the most common access pattern it would make some sense to refactor this "images" array to be a map with partialPath and fileName being the compound key.
I don't see a strong use case for the ordering benefit of an array here given the probable access patterns

Thank you for the proposal! There are likely benefits to going to a database.
I am strongly in favor of a simple JSON because it makes is SUPER easy for even non-technical people to open & edit the file safely. I guess what you might be suggesting is to simply use SQLite under the hood - even if we don't change the saved file format.
While size is a concern (so many duplicate keys!), I've not seen any problems with a 10,000 video hub (no problem with storing, opening, saving, browsing, searching, or sorting).
A rewrite of this magnitude is a serious undertaking and I'm not yet sold on the benefits.
Where do you see the biggest improvements for the users would be?

Well... you're certainly asking the right question: Where do you see the biggest improvements for the users would be?
That basically shuts down down my argument, but here it is anyway:
Immediate benefit to the user: 0.00000000001.
But this foundation raises the ceiling of of what one can do, but I think I agree it doesn't provide enough value for consideration.

😅 I've been itching to get back to Face Detection work in VHA and I have 2 other projects I've been meaning to start since about 2 years ago -- never find enough time 😓
I've been trying to say 'no' to most things that take time :trollface:
I'm thinking after version 3.0.0 release (and possibly face detection work) I'll finally feel comfortable to work on the other two ideas. Video Hub App is already 99% of what I wanted it to be and I don't see much need to add many more (major) features at this time.
I appreciate the suggestion and I always welcome a discussion 🙇

I agree this would be a massive overhaul of the app - currently everything is loaded into RAM and modified in RAM, and then written back to disk when it's finished.
With a database, every lookup gets sent off individually, and you get a result returned. For smaller hubs (I'm thinking <50k videos), this would probably actually be slower. Pipes in VHA are incredibly fast given just how much data they sift through! 🎉
On the other hand - this would open up the app to the possibility of having the option of a remote database, allowing for multiple instances to operate at the same time, which could realise my idea of having a "server" importing videos and doing all the work, and a client that just adds tags, and interacts with the videos! 🤔

Sqlite, or sqlite variants have in memory version of their db for small dbs which I imagine would be just as fast. BUT, ultimately this isn't about speed it is about raising the ceiling of "max videos" or for allowing "db on other host" as you mentioned.
A db access/updated at runtime also allows for more 3rd party interactions against said db, outside the runtime.
The server that does the work, and a client that interacts with videos is kind of the "plex" route, which the project can choose to pursue or not.
But making the vha2 file a database makes it so people can do this type of thing on their own with the project not being on the hook for it.

From my brief look into it, it seems like the theoretical limit for arrays is 4.2 billion items. @TheTacoScott -- you said you have about 1.4 million videos -- have you tried running them (or a subset of them) through the app? I'm curious if you've witnessed some sluggishness.
I was never planning on taking the app in the Plex direction -- hosting anything non-locally. I think currently you could have the vha file and its associated folder on a network drive - when the app opens the file it will fetch all the images from the server as needed (though likely less 'instantly' as it would on a local hard drive).
I'm aware of how Plex can be used but I didn't mean to compete with it.
A bit of history: I decided to code VHA as a toy project to see if Angular could handle things. Everything worked out and it was a cool-enough app that I thought "I just need to polish up and release". Thankfully enough people loved it (and @cal2195 encouraged me to open source it). Since I put up the code online, Cal contributed great improvements and the app became better. But for about a year now all the features I've been adding are because customers email praises and requests for more features -- so I keep thinking "may as well".
I'm not opposed to getting VHA into a server-ready form. A refactor to get us there could be done somewhat gradually: move all the interaction with the finalArray away from home.component into a dedicated service. After that, just swap out all the pipes for a custom sql query builder and it's mostly ready.
I feel like hosting files locally on the PC is faster (especially with an SSD) than having them over a network. Opening the app up to further interactions by having a server can be cool, but I guess I'm currently just focused on getting VHA 3 released without bugs first.
I love the excitement over this feature ... I'm not saying 'no' -- just want to manage expectations -- it might take some time 😅

I am in the process of creating a vha2 file that has everything it needs and will report back on the performance. It'll end up being about 90M total tags, so I can report on search perf as well.

Also: I totally get it. I'm not a pushy guy about anything here. I can learn and code this all myself and PR it if I had the time. =)
We're both fighting the same battle of not having enough time to tackle the lower priority things. =)


Mistake in text

Please find where it says "Optional parameters aren't supported"... this should say "Optional parameters ARE supported" based off the content that immediately follows the statement :)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 35474d24-8039-f04a-de14-1530b8e8506c
Version Independent ID: b6cb2574-6326-a40d-0b6c-d1661328e828
Content: ASP.NET Core Blazor routing and navigation
Content Source: aspnetcore/blazor/fundamentals/routing.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @MollsAndHersh ... It's considered a hack. At 3.1 formal optional parameters aren't supported. Optional params are supported for 5.0 or later.


Automated cherry pick of #1723: Avoid reconciles without any meaningful changes when the

Cherry pick of #1723 on release-0.5.
#1723: Avoid reconciles without any meaningful changes when the
For details on the cherry pick process, see the cherry pick requests page.

/release-note-none
/assign @alculquicondor

/lgtm