Rails 6: undefined method `stub_connection'

I was using this gem in Rails 5.x/RSpec before it was merged into Rails 6, and it worked great. I've got Rails 6 beta 1 running, and obviously I've commented out the gem now.
However, when I run my ActionCable tests, I'm getting NoMethodError: undefined method 'stub_connection'. It looks like I need to include something, and require "action_cable/testing/rspec" is no longer available. What am I missing here?
Thanks for the hard work, and congratulations on getting it merged into Rails.

Thanks for the report!
We plan to add RSpec support for Rails 6 soon (right after #46).
For now you can try the following:
# do not load the whole gem by default
gem "action-cable-testing", require: false

In your rails_helper.rb, after require "action_cable/testing/rspec" add the following (see https://github.com/palkan/action-cable-testing/pull/46/files#diff-fe8e12e25dcfdac5a034c51ff1cf1998R24):
RSpec::Rails::ChannelExampleGroup.include ActionCable::Connection::TestCase::Behavior

Hope that would help.

@palkan Thanks for the quick response! I ended up with this:
Bundler could not find compatible versions for gem "actioncable":
  In snapshot (Gemfile.lock):
    actioncable (= 6.0.0.beta1)

  In Gemfile:
    action-cable-testing (~> 0.4) was resolved to 0.4.0, which depends on
      actioncable (~> 5.0)

    rails (~> 6.0.0.beta1) was resolved to 6.0.0.beta1, which depends on
      actioncable (= 6.0.0.beta1)

Which is totally fine, obviously we need the rest of the Rails ecosystem to catch up. I've got a few other gems that aren't compatible as well. I will just sit tight and wait for things to progress.


I tried to use ADE to extend Building properties, but I didn't know how to write a Schema file

I tried to use ADE to extend Building properties, but I didn't know how to write a Schema file

Hi caidc,
The draft document below would be help for you. Those are explaining how to use ADE of CityGML 3.0 GML Encoding.
https://github.com/nob140/CityGML3_ADE/blob/main/document/annex-examples-ADE-realworld.adoc
https://github.com/nob140/CityGML3_ADE

Thank you very much.This is very helpful to me.

Hi caidc,
Please note that the contents are subject to change.
BTW, could you please close this issue? Thanks!


I can't edit the endpoint after edit once, the only way is to restart it if I want to update endpoint

After open emulator(V4 PREVIEW), I can get the menu (edit setting, open in emulator, remove) first time. it doesn't show my change to uri and name, and also I can't get the menu when I click right mouse button.

Are you able to open the dev tools (ctrl + shift + i) and look in the console for uncaught errors? This would help in diagnosing the issue.


167134181 fix hash alignment

Delivers Pivotal #167134181

Changes alignment of all hashes to "key". See Slack discussion starting at https://mushroomobserver.slack.com/archives/C040TH9FV/p1562555355004800
Update configuration so that RuboCop will complain about new AlighHash offenses and a few other offenses that are normally suppressed by .rubocop_todo.yml.

Coverage remained the same at 91.817% when pulling 4124a5065e506a9279e7192af05d814c061619b9 on JoeCohen:167134181-fix-hash-alignment into 18dee9059245a93162976f2adb407d23662a4380 on MushroomObserver:master.

Codeclimate found 57 offenses. They (almost) all relate to extra spacing within hash values. In order to completely correct them with autocorrect, I need to temporarily, locally change Layout/ExtraSpacing AllowForAlignment: false.

Wrong. In almost every case, the extra space is to align other things. RuboCop allows that by default.
I think the only time extra spaces for alignment are not the default is alignment of hash values. Feels weird.


Running Weave Net with privileged: false

Is it possible to run Weave Net as unprivileged?
I am trying to integrate weave with Rancher K3s v18.6, Weave 2.8.1.
I wish to not allow privileged containers, so I have a pod security policy that does not allow privileged containers.
The weave-net daemonset creates the weave-net-XXXXX pods but the weave-init container fails. The logs for that container show:
ipset v7.2: Kernel error received: Operation not permitted
I see no SELinux denials and the dontaudit rules have been turned off.
This failure seems to be because the pod is running with privileged: false.
I have tried experimenting with Linux capabilities but nothing seems to make any difference. Does anyone know a way around this?

OK. Partially answered my own question. You not only have to add Linux capabilities to the PodSecurityPolicy but also to the container in the pod created by the Weave Daemonset. Now I am seeing an SELinux denial associated with the weave-npc container.

I have overcome all of my problems with running weave net unprivileged save one. The weave container is failing with this message in the logs:
$ kubectl -n kube-system logs weave-net-cnnlq -c weave
DEBU: 2021/07/27 21:57:14.624867 [kube-peers] Checking peer "ca:88:1e:45:e4:86" against list &{[]}
Peer not in list; removing persisted data
INFO: 2021/07/27 21:57:14.803655 Command line options: map[conn-limit:200 datapath:datapath db-prefix:/weavedb/weave-net docker-api: expect-npc:true http-addr:<IP_ADDRESS>:6784 ipalloc-init:consensus=0 ipalloc-range:<IP_ADDRESS>/16 log-level:debug metrics-addr:<IP_ADDRESS>:6782 name:ca:88:1e:45:e4:86 nickname:bbking no-dns:true no-masq-local:true port:6783]
INFO: 2021/07/27 21:57:14.803703 weave  2.8.1
FATA: 2021/07/27 21:57:15.166253 creating bridged fastdp veth pair: setting accept_ra to 0: open /proc/sys/net/ipv6/conf/vethwe-bridge/accept_ra: read-only file system
I don't see the /proc/sys/net/ipv6/conf/vethwe-bridge directory at all so I'm assuming that the weave container is failing to create the veth pair at all much less modify the value in accept_ra. I've tried adding every Linux capability that seemed relevant with no change and I'm not seeing any SELinux denials. Any help would be appreciated.

I'm not seeing any SELinux denials

Try temporarily disabling SELinux dontaudit rules by running the semodule -DB command on your nodes where Weave is running and looking for more AVC denials.
Run semodule -B after you're done with your investigation to reenable dontaudit rules.

I appreciate the comment. I have set SELinux to Permissive and I am still seeing the above failure. The problem seems to be that I cannot create the veth pair. Since writing the above I have tried adding every Linux capability with no change. Not sure what I have to do to set permissions appropriately.


west.yml: Update CMSIS to pull GCC 12 warning fixes

This commit updates the CMSIS module to pull in the fixes for the
uninitialised variable warnings reported by GCC 12 and above.
Signed-off-by: Stephanos Ioannidis<EMAIL_ADDRESS>Fixes #49637
Hotfix for CMSIS-DSP related test failures seen in the CI for some PRs

https://github.com/zephyrproject-rtos/cmsis/pull/19 has been merged. Ready for review.


LV timing model workaround

There is currently a workaround in place around the LV pip timing model.
There are two changes in prjxray for the workaround.  First is here:
https://github.com/SymbiFlow/prjxray/blob/84b1457b885861fee221c5c6255d41cfb962ffc0/utils/create_timing_worksheet_db.py#L147-L155
Second is here:
https://github.com/SymbiFlow/prjxray/blob/84b1457b885861fee221c5c6255d41cfb962ffc0/fuzzers/074-dump_all/jobtiles.tcl#L51-L64
And one change in symbiflow-arch-defs, here:
https://github.com/SymbiFlow/symbiflow-arch-defs/blob/2bf2ed6ca1f8f158fa8fa8a9c0d506f2ca284029/xc7/utils/prjxray_edge_library.py#L545-L551
When/if the LV pip timing model is improved, these workarounds will likely no longer be required.

This issue will track any progress to improving the LV pip timing models, and work to remove the current hack-y solution that is present.  The current solution appears to generate error in the ~2-5% range, but further testing may show the workaround to behave worse in some circumstances.

FYI - @daveshah1


Polkadot v0.9.4

It seems only account linker and identity are adapted, but ocw is not. Is it on purpose?

It seems only account linker and identity are adapted, but ocw is not. Is it on purpose?

ocw is updated

Let's have a small description when opening PR, it would really help to give others context.

Here are only refactoring due to the polkadot upgrade?

Yes

Let's have a small description when opening PR, it would really help to give others context.

Ok I will try to do my best. There wasn't one is because this is quite regular. Maybe I should have set the title to "bump deps to v0.9.4"


Update stable version in repo from 2.2.0 to 2.3.0

Think about update stable version to 2.3.0
Version: stable=2.2.0 (65 days old) => latest=2.3.0 (15 days old)
Installs: stable=185 (66.31%), latest=57 (20.43%), total=279
Click to use developer portal
Click to edit
Do not close this issue manually as a new issue will be created if condition for update still exists.
Please drop a comment if any reason exists which blocks updating to version 2.3.0 at this time.
Note: This is an automatically generated message and not personally authored by bluefox!
@mcm1957 for evidence

Is there any reason to delay adding this adapter to stable any longer?
Please drop a commit if you know any reason to refrain from adding.
If there is no response until 1.10.2024 we could decide to update anyway.

This issue seems to be outdated.
This issue suggests to update the stable version of this adapter to 2.3.0 but the current stable version is already 2.3.0.
So this issue should be closed.
@mcm1957 for evidence


Feature/add upload script

What's New:

The mbot-upload-firmware script has been moved from the mbot_firmware repository to the mbot_sys_utils repository.
Added the pico-sdk as a git submodule in the mbot_sys_utils repository.
Introduced PICO_SDK_PATH as an environment variable in ~/.bashrc to ensure the mbot_firmware CMakeLists.txt can locate the pico-sdk.
Thesetup.sh from mbot_firmware has been moved and renamed to install_scripts/install_picosdk.sh in the mbot_sys_utils repository.
The README file has been updated to reflect these changes.

Issue: #10
PR in mbot_firmware: https://github.com/mbot-project/mbot_firmware/pull/14

Thanks Shaw!
I don't think that it's necessary to add picosdk as a submodule, or add the path permanently to the bashrc. The repo only needs to be found to build picotools, so it's an install requirement rather than a development requirement for this repo. I think it's best to treat it like picotools itself and remove it once installed.
Can we also install the upload firmware script in the install script rather than making the instructions more complicated?


Add further checks for invalid code to workshop request forms

Depends on #2552 . Closes #2533. Updated 08 Nov.
This PR:

checks that membership is active at time of form submission
~checks that membership has workshops remaining~
adds info about related membership to WR details page (edit: this fixes #2393!)

@sheraaronhurt @Talishask I want to check this with you:
What is your usual workflow when a member has no workshops remaining but wants to request another workshop? How do you update AMY to represent this? Do you treat it as a paid COW separate from the membership?
I'm trying to understand if any nuance is necessary when validating the code and discovering there are no workshops left, or if it's okay to just block submission in that case.

@elichad thanks for checking. While this is a rare occurrence, yes they will contact us and we give them additional workshops at a discounted rate. In AMY it would be tracked by the discounted workshops section. @Talishask feel free to chime in :)

So as I understand it, we agree on extra workshops with the member, but there's nothing in AMY that indicates 'this member is allowed X more workshops than the original contract (and should be allowed to submit X further requests).' We just remember that they have extras when we're processing the requests that come through with their code. Looking at the code, the 'discounted workshops' field is actually just counting all the Events connected with the membership, and subtracting the original allowance.
If that's how things work, then those members won't actually be able to submit requests if they've used their original allowance, because the form will see '0 workshops remaining' in AMY and block the submission.
To solve that, I think we need to add an 'additional workshops' number field to the membership, in the same manner as the 'additional instructor training seats' that we have at the moment. That way, when a member buys an additional 2 workshops, we can edit their membership to record that, and then they will be able to submit 2 more workshop requests after that.
Does that make sense?

Great questions.
Member Workshops
When members need additional workshops they typically submit a workshop request form before contacting us and then we discuss this with them. My current process is to update the number of allowed workshops once the member is invoiced. In most cases Danielle is already working with them.  The downside of updating the allowed workshops field is that we lose data on added workshops, so this is not optimal. We used to have a 'Members included in membership" and an 'Additional workshops' field but we lost the second field with some updates last year. I agree and would be excited to get that field back.
Given that members typically submit requests before they are invoiced for additional workshops, I would recommend we have a warning internally but do not block any submissions due to '0 workshops remaining.
Discounted Workshops Field
The current discounted workshops field assumes that any COWs above the allowed workshops are discounted. That is not correct. Typically these are workshops that are either above the limit or not yet paid. It would be more helpful for workshop allowances to be structured just the same as IT seats with "allowed", "used", "remaining".
Alacarte Workshops
Alacarte workshops are a little bit different. Our current workflow is to create the membership (so that we can tie the event to it because planning can start while we are working on paperwork), but wait to add the allowed workshop until the invoicing happens. Essentially we are waiting to confirm payment before adding the allowed workshop. We changed this order for a la carte workshops because they are easier to fall through the cracks and not get invoiced. I have a report that lets me see workshops where the allowed is zero then I check to see if we received payment or not and update the allowed workshops once we invoice it. It might be a good idea to have a conversation with the TT about some of these things to help me find better solutions and standardize more with our regular workflows.

@Talishask Thanks for this information, I'll schedule a short call with you to talk through a couple of follow-up questions I have

@pbanaszkiewicz this is now ready for review!

Thanks Piotr! I addressed all your comments so I'll go ahead and merge.


jq + wget shell one-liner

curl https://storage.googleapis.com/panels-api/data/20240916/media-1a-i-p~s | jq '.data | .[] | select(.dhd) | .dhd' | xargs wget

jq <3

If you want you can have that go to a file and pass it in to wget -i so it will reuse the same connection as to not constantly disconnect and reconnect to the server.

File is saved with wrong extension -AdamM~Pixelized~Key3.jpeg@expires=1728508444399&fm=jpg&s=23cac714f045d42bd940bb17c58a2e0f%0D

File is saved with wrong extension -AdamM~Pixelized~Key3.jpeg@expires=1728508444399&fm=jpg&s=23cac714f045d42bd940bb17c58a2e0f%0D

Yeah there's probably some obscure wget option to make that work better, I've just been doing something like
for i in *@* ; do mv "$i" "$(echo $i | cut -f1 -d@)"

but the -d parameter varies by operating system (like on macOS and Linux it's ?).

Yeah there's probably some obscure wget option to make that work better
Not really unless you explicitly specify file names for every file

Not really a one-liner, but this will get rid of the weird file names
wget -qO- https://storage.googleapis.com/panels-api/data/20240916/media-1a-i-p~s | jq -r '.data[] | select(.dhd) | .dhd'  | while read -r url; do
  name="$(printf "%s" "$url" | awk -F/ '{print $NF}' | cut -d '?' -f 1)"
  wget "$url" -O "$name"
done

curl -OJ automatically saves it as the content dispotion filename
wget -qO- https://storage.googleapis.com/panels-api/data/20240916/media-1a-i-p~s | jq -r '.data[] | select(.dhd) | .dhd' | while read line; do curl -OJ $line; done```

curl -OJ automatically saves it as the content disposition filename, which strips the extra chars.
wget -qO- https://storage.googleapis.com/panels-api/data/20240916/media-1a-i-p~s | jq -r '.data[] | select(.dhd) | .dhd' | while read line; do curl -OJ $line; done

Well then in that case we should go full circle and make it a curl oneliner:
curl https://storage.googleapis.com/panels-api/data/20240916/media-1a-i-p~s | jq -r '.data[] | select(.dhd) | .dhd' | while read f ; do curl -OJ $f ; done


Supports multiplying by number of participants in meal model

Issue
https://github.com/tmrowco/bloom/issues/338
Description
Updates Meal model to support multiplying the emission by number of meals/participants.
Changes

Wrote tests to cover existing model
Added new functionality
Bumped model version

Preview

:warning: FYI/NOTE
I am not sure about best approach here with regards to name - I have here reused participants from transportation, but would it make more sense to have something like "numberOfMeals" instead? 🤔
I'm unsure if it's too weird that participants is multiplying emissions here, but dividing emissions in the transportation model.

I think numberOfMeals (mealCount?) is a better name. Participants is ambiguous, e.g. multiple people could share one meal.

Thanks, I think that makes good sense to - then "participants" stays transportation-specific :)


ui-super-heroes application failing "Crash-loop-back-off"

Hi @juliaaano,
I'm using your application in openshift cluster. But node pod is failing and  getting following errors:
><EMAIL_ADDRESS>start
> node serving/server.js
[2023-06-21T17:53:55.142Z] express server listening on 8080
npm ERR! code EACCES
npm ERR! syscall open
npm ERR! path /opt/app-root/src/.npm/_cacache/tmp/0d1d142a
npm ERR! errno -13
npm ERR!
npm ERR! Your cache folder contains root-owned files, due to a bug in
npm ERR! previous versions of npm which has since been addressed.
npm ERR!
npm ERR! To permanently fix this problem, please run:
npm ERR! sudo chown -R<PHONE_NUMBER>:0 "/opt/app-root/src/.npm"
npm ERR! Log files were not written due to an error writing to the directory: /opt/app-root/src/.npm/_logs
npm ERR! You can rerun the command with `--loglevel=verbose` to see the logs in your terminal

Can you please know the solution or can you pls fix from your end.  It seems like permission issue in pod

@nageshredhat can I ask you to try deploying this through the demo platform here: https://demo.redhat.com/catalog?item=babylon-catalog-prod/enterprise.ocp4-acc-new-app-dev.prod
If not, an alternative is to go to the upstream project here: https://github.com/quarkusio/quarkus-super-heroes
I know about this issue, but unfortunately, I haven't been able to determine and fix the root cause. It comes and goes after a while.
Let me know how it goes.

Yes i'm deploying through RHPDS only

still pending

It should be fixed now, so please try again.


[6.0] UnsignedBigInt implementation

This PR contains implementation of new numeric type, UnsignedBigInt, 256 bits unsigned big integers.

@kushti the target branch seems to be not correct. I wonder if the changeset is so big because of that?

@aslesarenko comments addressed, please make another pass!


Implementation status added

Implementation status added
Name and Description field updated.

I fixed it.
Thank you.

Than you for fixed!


imagemagick: include configure.xml (#353169)

magick -list configure relies on the configuration file being in a known location.  Copy configure.xml to share/ImageMagick-<version>/, minus paths which may be in other outputs.
This is a resubmission of #353197  @dotlambda @rhendric @bloxx12.
Fixes https://github.com/NixOS/nixpkgs/issues/82749

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@bloxx12 wrote:

I think it'd be a good idea to comment this part of the code briefly though.

I've added some comments and updated the PR.

It is hard-coded into several files in the source and hasn't changed in several years.

The hardcoded paths in the source are generated from the configure file.
We could parameterise the derivation to accept the depth and HDRI support, pass them on to configure, and then determine the path appropriately, however I think that should be a separate PR.

If someone is waiting for me to do something, I don't know what it is. :-)

Thanks, @FliegendeWurst !


Make polka ultra light weight

When polka package is published to npm, it includes the readme file which weights around 22 kB.
https://github.com/lukeed/polka/blob/master/packages/polka/readme.md
Moving this documentation to GitHub Wiki or some other place would reduce the unpacked size from 25.5 kB to 4.31 kB.

Update readme to include minimal details & add external references to the much more detailed documentation.

Thanks for this awesome package.

does npm still pull the readme from the linked repo if one is not in the package? i personally find it convenient to read the docs directly on npm when browsing/evaluating libs - saves a lot of clicks.

Hey there,
Thanks for the suggestion and kind words. I've definitely wanted to do this in the past to help highlight how small it truly is, but I'm also like @leeoniya and look at readmes thru npm very often.
My game plan is to finish up a docs site for Polka 1.0 and link to that within the readme. That way it's a better set of docs (instead of the current massive wall of text) and it's only one click to get there. A readme would still exist but it'd be very little.
What do you think?

This would also be the case for Polkadot

That would be great!


Link to ASP.NET Core authentication-handler broken on OIDC Web authentication page

Description
The link in this sentence is not rendering:
https://github.com/dotnet/AspNetCore.Docs/blob/b1e1428d5899fda009f65e2c4e41dac6a60df7b6/aspnetcore/security/authentication/configure-oidc-web-authentication.md?plain=1#L55
Page URL
https://learn.microsoft.com/en-us/aspnet/core/security/authentication/configure-oidc-web-authentication?view=aspnetcore-9.0
Content source URL
https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/security/authentication/configure-oidc-web-authentication.md
Document ID
5d97b8bb-6505-9268-efbc-33fc2c02f4d8
Article author
@damienbod
Related Issues

Thanks for the report @@apicht
@damienbod ... I'll fix this on my open PR tomorrow morning.

All good! It's on the PR, and I think that PR will merge tomorrow.
Thanks again for the report, @apicht.


Condition to go to prod for autumn experimentation 🍂

Conditions to fulfill to go to prod only for the first exeperimentation.
Not relevant for the final production.
checklist :

[ ] configure URL
[ ] HDS hosting ⚠
[ ] update GHA workflow with relevant vars
[ ] User Registration script : mail + password + display name ? #130
[ ] Deletion of keycloak #129
[ ] Discovery room : onboarding process #126
[ ] Configuration of display name
[ ] Test with mobile app to be sure that everything is ok
[ ] Plug synapse on a  production SMTP service
[ ] Disable auto register #131

Enrollment :

Users are created with a script
We tell the users with a common e-mail to re-initialize their password (forgotten password)

Please add your planning poker estimate with Zenhub @ad2ien

Each issue estimated separately give a final estimate of 16
BUT there is a big warning on HDS hosting that can be wether easy and smal or complex and long

Teams bridge, PSC login and email sender parameters added and set on prod, preprod, develop environment.
Preprod PR : https://github.com/eimis-ans/eimis-synapse/pull/154


Cleaned up parser file and made module

@RigatoniRex -- nice refactor! Def split it up in many and it's cleaner. Thank you!


Merge PR/push CI workflows

PR Checklist

[x] A description of the changes is added to the description of this PR.
[ ] If there is a related issue, make sure it is linked to this PR.
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated

Description of changes
Reduce duplication by merging on-pull-request and on-release-main together, since they do the exact same thing.
Also update actions/checkout to v3 (changelog).

Thanks, good idea. I will close issue #28 with this!


ReLU negative slope ignored?

I've been investigating some divergence between a converted keras model and the original model.
The first layerwise difference I find is at a ReLU layer. My differences (checked with numpy.testing.assert_allclose) look like
checking output dense  ... OK!
checking output dense_1  ... OK!
checking output re_lu  ...
AssertionError:
Not equal to tolerance rtol=0.001, atol=1e-07

Mismatched elements: 583 / 1024 (56.9%)
Max absolute difference: 0.01077522
Max relative difference: 1.7480605e-05
 x: array([[ 0.015924, -0.00205 , -0.007421, ..., -0.00298 ,  0.032283,
         0.026983]], dtype=float32)
 y: array([[0.015924, 0.      , 0.      , ..., 0.      , 0.032283, 0.026983]],

The x arg to numpy.testing.assert_allclose is the keras output, the y arg is the onnx output, as computed by onnxruntime.
The layer has parameters
# node properties
  type: ReLU
  name: re_lu
# Attributes
  dtype: float32
  negative_slope: 0.1
  threshold: 0
  trainable: true
# inputs
  input name: dense_1
# outputs
  output: name: re_lu

Given the zeros in the onnx output, my guess is either the converter is ignoring the negative slope or the onnxruntime is. I suspect the issue is with the converter because this layer maps to a Clip. Using a different inference framework, TensorRT, I also find the zeros.

Can you provide a simple script for us to debug? thanks!

@jiafatom thanks for the response. I'll try to whip something up. Shouldn't be too hard.

I think this should run without triggering an assert, but it doesn't for me. Note that it does pass if there's no negative slope on the ReLU.
from keras.layers import ReLU, Input
from keras.models import Sequential

import keras2onnx
import onnxruntime

import numpy as np
import numpy.testing

model_input = np.array([-2, -1, -0.1, -0.5, 0, 1, 2],
                       dtype=np.float32)
negative_slope = 0.1

keras_model = Sequential()
keras_model.add(Input(shape=model_input.shape))
keras_model.add(ReLU(negative_slope=negative_slope))

keras_result = keras_model.predict(model_input).ravel()

onnx_model = keras2onnx.convert_keras(keras_model)

content = onnx_model.SerializeToString()
sess = onnxruntime.InferenceSession(content)
feed = {'input_1': model_input.reshape(1, -1)}
onnx_result = np.array(sess.run(None, feed)).ravel()

numpy.testing.assert_allclose(keras_result, onnx_result)

In case it matters, here are some version numbers I'm working with:
keras2onnx==1.7.0
keras==2.4.3
tensorflow==2.3.0
onnxruntime==1.4.0

FYI, in my original example, not the small repro shared above, I manually edited your generated onnx model to hold LeakyRelu instead of Clip and it seems to do the right thing now (but the converter got me 95% of the way there 😄).

Made a fix and checked in here, please pull keras2onnx master and retry.

Pulled master and it works great! This is by far the fastest turnaround I've ever experienced on a bug report, open source or otherwise. Thank you for your efforts! 👍


Support read only mode

Currently the plugin requires that a user code pin is set, for changing the arm state. Ideally users could configure the plugin as a read-only mode not requiring the pin code. (though still requiring the C4 key) This would allow sensors to be used for triggers in automations, and viewing the state from a HomeKit screen w/o adding any potential security concerns for those that don't need the ability to change arm states from HomeKit.
Technically the ability to arm stay/away shouldn't require the PIN, so that might be nice to support - though there is probably still a good case to make those optional. Especially in cases where security is monitored.

Hi,
I totally understand what you would like to acheive.
The only "problem" is that I haven't found a way to put the Homekit Security System accessory in a read only mode.

Technically the ability to arm stay/away shouldn't require the PIN, so that might be nice to support
If the Secure Arm option on your panel in disable, the plugin will not send the pin code to arm stay or arm away.

For the moment, you can enable Secure Arm option on your panel and set an erroneous pin code in Homebridge (0000). Arming state will be available. You won't be able to change the Arming state with the accessory.
I see 2 possible solutions for a Read Only mode:
1- If the state of the Homekit Security accessory is change while Read Only mode is enabled, revert accessory back to actual panel arming state without sending any command to panel. I don't know if that would trigger any automations linked to the Security System acccessory arming state ...
2- I'll try to dig further in the Security System accessory documentation to see if it can be put in read only mode.

I was able to create a read only Security System in Homebridge by removing the Paired_Write Perm.
Unfortunatly, the custom accessory doesn't show up in Home App for the moment ...
const ValidPerms = [
this.platform.api.hap.Characteristic.Perms.EVENTS,
this.platform.api.hap.Characteristic.Perms.PAIRED_READ,
// this.platform.api.hap.Characteristic.Perms.PAIRED_WRITE,
];
this.service.getCharacteristic(this.platform.api.hap.Characteristic.SecuritySystemTargetState)
.setProps({ perms: ValidPerms });

A couple of added thoughts. One option may be to have a config option allow completely turning off the Security System Accessory (Arm state) and just allow reporting of sensors state.
The other would be to just not allow Disarm as a valid state to set. I haven't dove into the HomeKit docs for that accessory type, but it seems a little weird that they wouldn't have accounted for the fact that Disarm probably isn't command you want to work via Siri, so that it can be a reported state, but not a state to set to or if it is a state that can be flagged to not work with Siri.
That is my main concern with setting up a PIN code - while having support for arming is nice - and maybe some automated disarm cases, but I don't want "Hey Siri Disarm" to work.  Maybe I'm incorrect in my assumption that the way this is setup know would allow that?

Hi,
You can uncheck ´Show Security Panel' option in config to prevent the Security System accessory from showing up in Home App.
Siri will only be able to change a Security System accessory arming state if your device is unlocked. People use dummy switch automations to bypassed that security feature.
Will dig further in Security System accessory characteristics as soon as I can.

Siri will only be able to change a Security System accessory arming state if your device is unlocked. People use dummy switch automations to bypassed that security feature.

Does that mean that HomePods can't ever change a Security System accessory arming state by default?

Siri will only be able to change a Security System accessory arming state if your device is unlocked. People use dummy switch automations to bypassed that security feature.

Does that mean that HomePods can't ever change a Security System accessory arming state by default?

Found the following in Homepod Siri documentation:
Check the status of a security accessory: You can use HomePod to lock or check the status of door locks and other smart home security accessories. Say something like “Hey Siri, is the front door locked?” To unlock or open security accessories, you must complete your request on your iOS or iPadOS device because unlocking them requires authentication using Face ID, Touch ID, or a passcode.
Siri through Homepod can't Disarm your security system.

I think what I was really looking for then was just to make it so that rather than requiring a PIN code to be set (even a dummy one) to run the plugin, that it would be allowed to run with no PIN configured but then ´Show Security Panel' option would be forced to unchecked. But I'm good to close this based on the added information around the Siri behavior etc.


Correction for raw affiliation CIRAD, UPR AIDA, Turrialba 30501, Costa Rica.

Correction needed for raw affiliation CIRAD, UPR AIDA, Turrialba 30501, Costa Rica.
raw_affiliation_name: CIRAD, UPR AIDA, Turrialba 30501, Costa Rica.
new_rors: 05tkvpg69;01hv86c27
previous_rors: 05tkvpg69
works_examples: W4368367292
contact: 8e6f582163afc6afcfef60defae536f2:ad853c4e236bac1d1674f2c9799f @ cirad.fr

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


Please, add support to Net461

Hi, could you compile a new version adding a net461?

"frameworks": {
"net461": {}
}
Thanks

Hi @eduardoluizm -
From the source code, have you tried this fix? I see that IS4 references the "frameworks" element different than this repo. Maybe this is how the EF project should reference it as well although I would prefer to use latest netstandard and net461. SEE: IS4 project.json

Hi @eduardoluizm -
I just published to nuget using IS4 "frameworks". FYI - A good resource: https://gist.github.com/davidfowl/8939f305567e1755412d6dc0b8baf1b7


Bad cmake executable "". with last vscode update

Brief Issue Summary
With the last update (1.75.0), cmake executable is not found. Reloading the windows does not seem to work, and cmake is in my path :
❯ which cmake
/opt/homebrew/bin/cmake

I could set it in my settings, but since it is in my path and it worked before, I guess it should work out of the box.
CMake Tools Diagnostics
{
  "os": "darwin",
  "vscodeVersion": "1.75.0",
  "cmtVersion": "1.13.45",
  "configurations": [
    {
      "folder": "/***/htool_dev",
      "cmakeVersion": "unknown",
      "configured": false,
      "generator": "unknown",
      "usesPresets": false,
      "compilers": {}
    }
  ],
  "cpptoolsIntegration": {
    "isReady": true,
    "hasCodeModel": false,
    "activeBuildType": "",
    "buildTypesSeen": [],
    "requests": [
      "file:///***/block_tree.hpp",
      "file:///***/hmatrix.hpp"
    ],
    "responses": [],
    "partialMatches": [],
    "targetCount": 0,
    "executablesCount": 0,
    "librariesCount": 0,
    "targets": []
  },
  "settings": [
    {
      "communicationMode": "automatic",
      "useCMakePresets": "auto",
      "configureOnOpen": null
    }
  ]
}

Debug Log
No response
Additional Information
No response

I think we're missing some information.  If you have not set the cmake.cmakePath setting and you are not using a configurePreset that sets cmakeExecutable, then we do which cmake exactly as you would have done.  Can you confirm that you have not overwritten the setting (User or Workspace settings) or the property in your CMake presets file?

I had no cmake preset and I had not set cmake.cmakePath, but after a few reload of my computer, it now works as before. I would not know how to reproduce so I will close the issue.


Upgrade lifecycle to 0.7.4 (builder.toml only)

Also, remove redundant versions defined in builder.toml

TIL that version is optional.
Is it a problem that the functions builder and normal builder use different lifecycles?


How to use generate() with inputs_embeds

I hope this is the right place to ask this question. Let me know if I need to move to another repo.
Currently I'm using NeuronModelForCausalLM.
I have a use case where I need to be able to do the following:

Generate embedding tokens
Modify embedding tokens
Run inference from modified embedding tokens

I am able to do steps 1 & 2 currently using the following:
from optimum.neuron import NeuronModelForCausalLM

llama_model = NeuronModelForCausalLM.from_pretrained('aws-neuron/Llama-2-7b-chat-hf-seqlen-2048-bs-1')

embedded_tokens = llama_model.model.chkpt_model.model.embed_tokens(token_ids)

### Code to modify embedded_tokens

However, as far as I can tell, generation with these modified tokens is not possible with llama_model.generate()
When I use the 'input_embeds' keyword argument, and set input_ids=None, I get the following:
ValueError: The following `model_kwargs` are not used by the model: ['inputs_embeds']

If this is not possible with the NeuronModelForCausalLM.generate() currently, is there a way to work around this manually? If so, could you provide an example?
Thanks very much for your help!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

Any plan to support inputs_embeds besides of inputs_ids? Like https://github.com/aws-neuron/transformers-neuronx/pull/86?

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!


Facebook backfeed for likes on a photo using wrong FB URL

@dissolve reported via IRC that his post is not receiving backfeed likes https://ben.thatmustbe.me/photo/2015/7/17/1/
Bridgy sees the likes and tries to send them https://www.brid.gy/facebook/14305603

but it seems to be using the wrong Facebook post ID ... https://www.facebook.com/14305603/posts/10101541550801774 ... which is the "Ben Roberts added 2 new photos to the album: Brid.gy Photos." activitystreams-style activity post, and not the photo itself.
as a result the source URLs bridgy sends to Ben 404 https://brid-gy.appspot.com/like/facebook/14305603/10101541550801774/727349030638052

aughhh no not fb photo URLs again :sob: :gun: :gun: :gun:

(but thank you for filing so comprehensively @kylewm!)

related to #388 and #346. FB ids are no end of fun/headache.

the tentative fix is to fetch both forms of the id and merge the results.

seems to work. https://brid-gy.appspot.com/like/facebook/14305603/10101541550801774/727349030638052 now 200s.

great job!


Development configuration build fails

With what library do you have an issue?
native-federation
Reproduction of the bug/regression with instructions
In your  Stackblitz template try to build any project with development configuration eg. "ng build host --configuration development"
It will fail with the following error:
An unhandled exception occurred: Cannot read properties of undefined (reading 'split')
Expected behavior
The development configuration build should run successfully and when hosted, the browser should be able to map the source code.
Versions of Native/Module Federation, Angular, Node, Browser, and operating system
Angular: 18.2.0
Native/Module Federation:  18.2.2
Other information
No response
I would be willing to submit a PR to fix this issue

[ ] Yes
[X] No

Hi, @rainerhahnekamp Is there any workaround as I cannot debug my code runtime? Rest everything works fine for me.

A short way to unblock you is to configure several targets in your angular.json and to run then with ng run. In the next months, @rainerhahnekamp plans to provide a config flag as mentioned about.
I guess, it needs to be a flag like --targetConfig because it influences the config of the builder NF is delegating to.


Fix/improper use of error formatting

changed the formatting in e2e directory

donde

@alonsofabila-dev thanks for the update. If you don't mind I'll fix the commit message myself.

@alonsofabila-dev I push another version with some minor changes:

Fix the another instance that you change %s to %q but did not remove the fmt.Sprintf

diff --git a/e2e/dractions/retry.go b/e2e/dractions/retry.go
index dddcd38e..cb4a285f 100644
--- a/e2e/dractions/retry.go
+++ b/e2e/dractions/retry.go
@@ -206,7 +206,7 @@ func waitDRPCDeleted(client client.Client, namespace string, name string) error
                }

                if time.Since(startTime) > time.Second*time.Duration(util.Timeout) {
-                       return fmt.Errorf(fmt.Sprintf("drpc %q is not deleted yet before timeout, fail", name))
+                       return fmt.Errorf("drpc %q is not deleted yet before timeout, fail", name)
                }

                time.Sleep(time.Second * time.Duration(util.TimeInterval))

Fix the commit message to be in the standard format
Fix the PR message by copying the commit message

@alonsofabila-dev git grep show other instances that you did not fix:
% git grep 'fmt.Errorf(fmt.Sprintf'
deployers/retry.go:                     return fmt.Errorf(fmt.Sprintf("subscription %s status is not %s yet before timeout", name, phase))
deployers/retry.go:                     return fmt.Errorf(fmt.Sprintf("workload %s is not ready yet before timeout of %v",
dractions/retry.go:                     return fmt.Errorf(fmt.Sprintf(
dractions/retry.go:                     return fmt.Errorf(fmt.Sprintf("drpc %s progression is not %s yet before timeout of %v",

done

@alonsofabila-dev please rebase on main, some of the changes already fixed by another pr merged just now.

@alonsofabila-dev I asked to rebase on main, but you merged it - this is not the same. We want to have clean linear history in git without merge commits. The way to update your PR is to use:
git checkout main
git pull upstream main
git checkout your-pr-branch
git rebase main
(fix possible conflicts)
git push -f

This should be done each time you push changes, to make sure your change is tested on top of latest version.

sorry for my mistake, I have now done as you mentioned.

@alonsofabila-dev You rebased, but you had to "pick" only your commit. I clean up and resolved the conflicts.

thanks


Allow users to Deactivate

This pull request addresses #965. It allows users to deactivate their accounts.
In addition, a new "Your account is deactivated" page is present if they try to log in with their account again. This is useful in the case of us deactivating a user for unwanted access.

Is this going to be squashed?

yes, all PRs are squashed into a single commit now

I should say, it's the default merge behavior :)

@rbbeeston can you take a look at updating the template for profile.html? We probably need some frontend "are you sure?" validation there too (ref: https://github.com/boostorg/website-v2/pull/1170/files#diff-40f7faefd30d053f0caedcda1146bde4b07f6b64e61036f3635505b99872c036)

it's the default merge behavior :)

Are you using the web interface to merge PRs? Is the merge behavior configured in the repo settings?


Instructions missing "npm start" step

I've followed the instructions in the README, but when running react-native run-android, the app starts with an error because the development server isn't running. Running npm start fixes it, but to avoid new users having to google this it (sh|c)ould be mentioned in the README.

closed via #422


Allow generation for only Release.TriggeringArtifact.Alias

Azure DevOps Extension you are using
Generate Release Notes for Pipeline Build or Releases (Powershell)
(I know there's a newer version but my organisation doesn't support it atm..)
Where are you running it?

Azure DevOps Service (VSTS) - vs2017-win2016

Version of Extension/Task
3.*
Expected behaviour and actual behaviour
We have a single pipeline that is linked to several build artifacts, to be triggered when any one of them are build. In our pipeline we then use $(Release.TriggeringArtifact.Alias) to determine which if the builds is the one currently needing to be used in the release.
Expected:
For the generation of release notes we would therefore like only the triggering build to be included.
Just another checkmark like "Generate for only primary artifact" would be ideal.
Actual:
Now all the other builds that are also linked to this release but are not relevant are also included in release notes.
Steps to reproduce the problem
Link multiple build artifacts to one release and build one of them to trigger the release. You can set for example the release name using $(Release.TriggeringArtifact.Alias) to verify which build is the trigger. Then create release notes and you will also see the irrelevant builds included.

Oh,  really had wanted to make no more changes to this task, but that does sound a reasonable request.
I need to check that I can detect that flag to see how easy it is

OK have a look a 3.7.6.
This was harder than you might expect. There seems to be no easy way to work out what the trigger event was for a release.
You might expect if you get the release details using a REST call in the form
https://vsrm.dev.azure.com/richardfennell/GitHub/_apis/release/releases/1966

In the returned JSON you might expect the trigger would be the $currentRelease.triggeringArtifactAlias, but in my tests this is value is always null.
So I have have to resorted to string matching in the form
($currentRelease.description -eq "Triggered by $($artifact.definitionReference.definition.name) $($artifact.definitionReference.version.id).")

I don't like this solution, it feels 'brittle' and I fear it will fail if the user language is not English.
But lets see how it goes,  @Olgsie let me know you results

As per my standard practice I am closing this issue as I have heard nothing for a while. If this issue remains a problem please do not hesitate to re-open it

Hi, I've tried with your solution and it didn't work, notes now showed no build at all. Also tried to overwrite the value for Primary release artifact with the Trigger alias and use that check to generate for the correct build, also didn't work.. Starting to think we may need to create separate pipelines for each artifact after all

Separate pipelines is often the best solution. I would also consider, given the current state of Azure DevOps and the roadmap, moving everything into multistage YAML pipelines, one per package. I am starting to do this for my extensions, here are my notes
Do you want me to re-open this issue and look any further, or is this idea worked to its logical endpoint?


shane: lot err msg if omni after typo -and- omni failed if reissue it

PR for #440

for/to reset cache after err happened, actually i am not very sure or randomly some may failed still.
but looks less than it was not going to reset it.
fyi.

Thank you.


Add a login screen

I can add login can you describe more what we actually need

@rajvaya  actually I worked on this issue, but there are other issues on the repo you can work on.


Failed: Update autorest version to prerelease 3.0.0-alpha.20240920.3

Generated by Autorest Regen Preview build 20240920.3Triggered from pull request: https://github.com/Azure/autorest.csharp/pull/5080

API change check
API changes are not detected in this pull request.


Migrate the Google Group to this repository

Transferred from https://github.com/phetsims/community/issues/5
@samreid and I met to begin the transfer process. We restricted posting access. We changed the description and welcome post to reflect the redirect.
We decided we should verify that phetsims/community would be moving to scenerystack/community. @emily-phet, @samreid, and @brettfiedler  agreed we should make the switch.
@brettfiedler is copying over issues and information from phetsims/community so we can reuse phetsims/community for future simulation focused community discussion.
Next steps:

[ ] Update scenerystack.org to redirect to this repository
[x] Copy over files
[x] Copy over relevant issues
[x] Create Discussions Board
[x] Copy Welcome post and Breaking changes post to new Discussions board
[x] Update links in Google Group post to scenerystack.org
[x] Make Google Group post

@samreid and @brettfiedler closed down posting permissions to the Google group and made a final post.  https://groups.google.com/g/developing-interactive-simulations-in-html5/c/CyJPJoXnNv0
We also added a message to the Breaking Changes thread. https://groups.google.com/g/developing-interactive-simulations-in-html5/c/1Zm4l3sye20
Before closing, I'd like to see the Scenerystack.org redirect changed.

Redirect completed last week!


Add a link with the roadmap document

Add this link to the roadmap document in the readme and docs, with instructions to use the password lsa-program to open a view the file.
https://www.lucidchart.com/documents/view/452744dc-5078-16b8-bd79-3a840af15730

Lets use this link instead:
https://www.lucidchart.com/invitations/accept/61d72a6b-d843-42b5-b54a-22c7f85e84d3


conda install -c conda-forge bioviz fails in Python3.10  with error ResolvePackageNotFound:   - python=3.1

Maybe the Python version is being treated as an int somewhere so it reads 3.10 as 3.1?
Seems to work ok in python 3.9

sorry, I meant to post this to bioviz!


When will MRDL basic controls be merged into MRTK?

My team was trying to use the Holographic-Shell-like MRDL App Bar and BoundingBox controls in our MRTK app, and found that MRDL baseline functionality has been successfully merged hours ago. So I wonder when will the MRDL basic controls be merged, and will it land in v1.2017.2.0 or v1.2017.3.0?

We're still working on it. There's currently an active PR #1197 open for some basic stuff already.

@DreaminginCodeZH PR #1197 includes basic Holographic Button in the InteractableObjectExamples scene. App Bar and BoundingBox control is on phase 2 list - we are updating it to support motion controller's pointer input too.

Thanks for the quick response! I wonder when will the phase 2 controls be merged, and will it land in v1.2017.2.0 or v1.2017.3.0?

ASAP

Just one more question, is it possible for the AppBar and BoundingBox to be merged within two weeks? If not, our team will have to roll our own solution due to time constraint.

@Railboy could you please share rough timeline for your App Bar + Bounding Box updates?


Removed Flask-Common. Fixed #442.

Fixed #442.

Pipfile.lock was updated via pipenv lock. According to https://github.com/pypa/pipenv/issues/753 (re)generation of host-environment-markers is intended and ongoing.
Is there some switch for pipenv to avoid regeneration, or should pipenv be avoided, or the entries removed by hand, or https://github.com/pypa/pipenv/issues/753 re-raised?

@sigmavirus24, unless it’s been added in the last month or so, I don’t believe there’s any way to disable those.
@javabrett, you’ll want to leave it for now I think. The Pipfile.lock shouldn’t be modified by hand. We’ve typically had a maintainer generate the lockfile to keep some level of consistency. I don’t see a huge reason that’s necessary though, outside of someone else’s system info being stored.

I could just revert the Pipfile.lock and let a maintainer lock, or feel free to edit my commit for that, then a maintainer can lock.
I am fairly new to pipenv and have been noticing a fair bit of diff churn noise when locking e.g. order of elements.

I since discovered https://github.com/pypa/pipenv/commit/ecf78424c1740bae3511c731c032a3768154072c , and that my pipenv was as-shipped with my CPython and hopelessly out-of-date, so upgraded:
$ which pipenv
/Library/Frameworks/Python.framework/Versions/3.6/bin/pipenv

$ pipenv --version
pipenv, version 8.3.2

$ pip install -U pipenv

$ pipenv --version
pipenv, version 11.10.1

... and pipenv lock no-longer adds that host env.
@sigmavirus24 @nateprewitt please re-review.


Card.prototype.handleInitialPlaceholders not works

I think there is two bugs in Card.prototype.handleInitialPlaceholders

following el might be NodeList
el = this["$" + name];

following el in setTimeout always uses last value in for loop

	        results.push(setTimeout(function() {
	          return QJ.trigger(el, 'keyup');
	        }));

I just fixed this in my product, but I'm sorry that I'm not good at coffee :(
https://github.com/letsspeak/card/commit/d3cf0abfffd9dd4722ef10f3a531498a43df8c50

Fixed in 2.5.1


Piers not showing up in vector export

Fixed with https://github.com/datadesk/web-map-maker/commit/c7577c882ebdc2c4c9d6808f3ce0fc544391d69d


Publish 8.3-20230816232259+0000

Publish 8.3-20230816232259+0000

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


New package: LZ2HV.MSHV version 2.74

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] This resolves #157583

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

This package seems installed, but the shortcuts can't find their targets. Is this expected?

@stephengillie - Issue reproduced on my Windows Sandbox instance.
Instead of installing to $env:APPDATA, $env:LOCALAPPDATA or C:\Program Files\, the package default installation path is D:\MSHV\. Windows Sandbox only provide a 40GiB C:\ volume, so the package can't be successfully installed.

The VM have to provide a D:\ volume for the package.

Yes, this issue should be reported to developers of LZ2HV.MSHV. But I failed to get their contact information.
This pull request should be closed without being merged, since there's  a https://github.com/microsoft/winget-pkgs/labels/Hardware problem.


CREATE EXTENSION IF NOT EXISTS "ltree"

Will query support complement ltree and lquery queries
{
"hint": null,
"details": null,
"code": "42704",
"message": "type "ltree" does not exist"
}

We have support for some ltree operations: https://github.com/PostgREST/postgrest/issues/2064
Can you share the curl snippet of the request you're making?

I made a request through a stored procedure
CREATE  OR REPLACE FUNCTION uop2.removenode(id text )  RETURNS void
AS $$ BEGIN
PERFORM obj.idobjectworld::text  FROM uop2.objectworld as obj WHERE obj.path::ltree ~ '*{1}' ;
END $$ LANGUAGE plpgsql;

POST http://uop01:850894Bo@1ppmop01.dev.aorti.tech:88/mpmop/api/rpc/removenode
Content-Type: application/json
Content-Profile: uop2
{
"id": 29
}
The answer always came one
Content-Type: application/json; charset=utf-8
{
"hint": null,
"details": null,
"code": "42704",
"message": "type "ltree" does not exist"
}

Maybe the public schema needs to be added in the db-extra-search-path configuration. If ltree was installed in another schema, you may need to add that one to the configuration instead (or specify it in the function e.g. obj.path::other_schema.ltree) . You can see the schema with this query:
select typnamespace::regnamespace from pg_type where typname like 'ltree';

Thanks everything worked


libopenmpt: 0.7.4 -> 0.7.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for libopenmpt is: Cross-platform C++ and C library to decode tracked music files into a raw PCM audio stream
meta.homepage for libopenmpt is: https://lib.openmpt.org/libopenmpt/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.7.5 with grep in /nix/store/wi42mlqi23619chf0gkwbn92m1r9nz49-libopenmpt-0.7.5
found 0.7.5 in filename of file in /nix/store/wi42mlqi23619chf0gkwbn92m1r9nz49-libopenmpt-0.7.5

Rebuild report (if merged into master) (click to expand)

1737 total rebuild path(s)

1737 package rebuild(s)

First fifty rebuilds by attrpath
CHOWTapeModel
ChowKick
MIDIVisualizer
Sylk
abracadabra
activitywatch
adapta-gtk-theme
adriconf
adwsteamgtk
aegisub
ags
ajour
akkoma
alfaview
alfis
almanah
alsa-scarlett-gui
altair
alvr
am2rlauncher
amberol
amule
amule-daemon
amule-gui
amule-web
anilibria-winmaclinux
anki
anytype
apache-directory-studio
apostrophe
appimage-run
appimage-run-tests
apx-gui
aravis
archi
archivebox
arduino-ide
asc
ashpd-demo
asn1editor
astroid
audacious
audacious-plugins
audaciousQt5
audacity
audio-recorder
audio-sharing
audiobookshelf
authenticator
authy

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/wi42mlqi23619chf0gkwbn92m1r9nz49-libopenmpt-0.7.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libopenmpt https://github.com/r-ryantm/nixpkgs/archive/2208326bea984d87d36bee76e93a21bb2d23b976.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2208326bea984d87d36bee76e93a21bb2d23b976#libopenmpt

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/wi42mlqi23619chf0gkwbn92m1r9nz49-libopenmpt-0.7.5
ls -la /nix/store/wi42mlqi23619chf0gkwbn92m1r9nz49-libopenmpt-0.7.5/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @OPNA2608 for testing.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for libopenmpt is: Cross-platform C++ and C library to decode tracked music files into a raw PCM audio stream
meta.homepage for libopenmpt is: https://lib.openmpt.org/libopenmpt/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.7.6 with grep in /nix/store/hmyabsm5f11as2gvwy7n98f0p5gar4a4-libopenmpt-0.7.6
found 0.7.6 in filename of file in /nix/store/hmyabsm5f11as2gvwy7n98f0p5gar4a4-libopenmpt-0.7.6

Rebuild report (if merged into master) (click to expand)

1751 total rebuild path(s)

1751 package rebuild(s)

First fifty rebuilds by attrpath
CHOWTapeModel
ChowKick
MIDIVisualizer
Sylk
abracadabra
activitywatch
adapta-gtk-theme
adriconf
adwsteamgtk
aegisub
affine
ags
ajour
akkoma
alfaview
alfis
almanah
alsa-scarlett-gui
altair
alvr
am2rlauncher
amberol
amule
amule-daemon
amule-gui
amule-web
anilibria-winmaclinux
anki
anytype
apache-directory-studio
apostrophe
appimage-run
appimage-run-tests
apx-gui
aravis
archi
archivebox
arduino-ide
asc
ashpd-demo
asn1editor
astroid
audacious
audacious-plugins
audaciousQt5
audacity
audio-recorder
audio-sharing
audiobookshelf
authenticator

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/hmyabsm5f11as2gvwy7n98f0p5gar4a4-libopenmpt-0.7.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libopenmpt https://github.com/r-ryantm/nixpkgs/archive/fdd354f1974b713046c02b8f0ec739e9fd4708f0.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/fdd354f1974b713046c02b8f0ec739e9fd4708f0#libopenmpt

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/hmyabsm5f11as2gvwy7n98f0p5gar4a4-libopenmpt-0.7.6
ls -la /nix/store/hmyabsm5f11as2gvwy7n98f0p5gar4a4-libopenmpt-0.7.6/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @OPNA2608 for testing.

(heavily scope-reduced review)
Result of nixpkgs-review pr 298295 run on x86_64-linux 1

4 packages built:

audacious
libopenmpt
libopenmpt.bin (libopenmpt.bin.bin ,libopenmpt.bin.dev)
libopenmpt.dev (libopenmpt.dev.bin ,libopenmpt.dev.dev)

Works fine. Darwin also builds, after fixing https://github.com/NixOS/nixpkgs/pull/299321#issuecomment-2033740630 .


Feature / Adopt externally accepted sockets into uWebSockets.

Description
This allows for sockets that were obtained from an external accept(2) to be adopted into uWebSockets.
Such sockets may come from another library, another external event-loop, or from a forked-server pattern, like inetd, systemd-socket-activate etc.
This PR is based on https://github.com/uNetworking/uSockets/pull/214 for uSockets.
Note: I'm unsure how Github handles PRs with submodules, hope I've done it right.
Justification
A forked process serving a single websocket session can increase safety, as each user is isolated in a separate process. In addition it can do impersonation via setuid(2) to restrict access on the host to that of an authenticated user. The design can also interface legacy "single-user" back-end software. It can increase robustness, limiting the effects of crashes to one session.
This is similar to what libwebsockets does in its "socket adoption helpers":
https://libwebsockets.org/lws-api-doc-main/html/group__sock-adopt.html
Instructions for use
The following is simplified code (no error checking) to show the forking pattern:
   // somewhere in a parent process, we listen and accept
   listener = socket(PF_INET, SOCK_STREAM, 0);

    bzero(&srv_addr, sizeof(srv_addr));
    srv_addr.sin_family = AF_INET;
    srv_addr.sin_port = htons(port);
    srv_addr.sin_addr.s_addr = htonl(INADDR_ANY);

    bind(listener,
              (const struct sockaddr *)&srv_addr,
              sizeof(srv_addr));

    listen(listener, 10);

    for (;;) {
      int websocket = accept4(listener, NULL, NULL, SOCK_CLOEXEC | SOCK_NONBLOCK);
      // needs to be non-blocking for sure
      fcntl(websocket, F_SETFL, fcntl(websocket, F_GETFL, 0) | O_NONBLOCK);

      switch (fork()) {
      case -1:                        // Error
            close(websocket);
            break;

      case 0:                         // Child
            close(listener);         //  does not need the listener

            startApp(websocket);

            _exit(EXIT_SUCCESS);

      default:                       // Parent
            close(websocket);   // does not need the websocket
            break
      }
    }

then startApp() would look something like this:

void startApp(int fd) {
  uWS::SSLApp({
       .cert_file_name = "cert.pem",
       .key_file_name = "key.pem"

  }).ws<UserData>("/*", {

        .message = [](auto *ws, std::string_view message, uWS::OpCode opCode) {
            ws->send(message, opCode);
        }
        .close = [&](auto *ws, int code, std::string_view message) {
             // this will be the last of it
             uWS::Loop::get()->defer([&](){
                 app.close();
              });
        },
  }).adoptSocket(fd)
  // run this one websocket session to the end
  .run();
}

The adoptSocket() can be combined with the usual listen(), so this would just be the first socket that launches the server process, such as in a inetd, systemd-socket-activate pattern.

Not an expert, but another advantage of this model is increased concurrency, it seems to me.
uWebSockets is single-threaded by design, and some servers (like my own) must interface with
slow resources (like Databases) that limit concurrent processing for other web sockets of the server.
With an opt-in forking model on accepting a connection, both safety and concurrency are increased.
So while I didn't look at the PRs' code, I strongly support the concept and feature, FWIW.

uWebSockets is single-threaded by design, and some servers (like my own) must interface with
slow resources (like Databases) that limit concurrent processing for other web sockets of the server.

You need to go find a DB connector that was written after 1983, not before. A slow DB query that takes 2 minutes to complete does not, in any way, hinder a single-threaded application from progressing otherwise. If it does, then you haven't written a proper single-threaded application. Strongly recommend looking into how Node.js works.

You need to go find a DB connector that was written after 1983, not before.

I take your point Alex.  And the time is not necessarily waiting on IO either, it can be compute-bound too. Thus the barb on not using async-io is not entirely called for :)
But this is kinda OT, and I hope I didn't detract from this PR, which has merit IMHO, if only security wise, beside my point on concurrency across processes, via the fork-mode this PR enables (if I understood correctly).

even 100ms is an eternity for a server to be blocked serving a single request/message

You aren't supposed to be blocked. That's the whole point of 1983's non-blocking sockets. That's the whole point of Node.js and similar (uws) projects that use non-blocking IO.

it can be compute-bound too

If you are compute bound, you aren't going to magically summon new computing resources just by spawning a few processes. Spawning processes will take away CPU-time from your constant budget, not add. You are adding more overhead to be processed by finite hardware, reducing available CPU-time for your actual problem.

If you have 4 CPU-cores you spawn 4 instances of uWS; 4 event-loops on 4 threads running on the 4 CPU-cores. This is how you make things perform optimally, and this is how posted benchmarks have reached top results.
As an objective scientist, I welcome any solution that can beat the results on specified hardware.

If you have 4 CPU-cores you spawn 4 instances of uWS; 4 event-loops on 4 threads running on the 4 CPU-cores.

And you bind all of them to the same port with SO_REUSE? (isn't that Linux only?)
And the OS magically spreads the connections across the different instances (each running on its own core)?
But once a client socket is bound to an instance thus core, it can't leverage the other cores.
So at worse, if most of the active (WebSocket) connections are bound to the same core, aren't the other 3 under-utilized?
I'm not being snarky or anything like that. Genuinely curious.

Can we agree that this discussion is at least somewhat OT? :smile:
I did mention interfacing "legacy" and "single user" applications. These might in-deed run single threaded and synchronously when handling the requests/messages as the "back-end" function. But how to deal with that problem, is an entirely different question!
Can we agree that this different question has nothing per se to do with adopting sockets, or the usefulness of this PR?
@ddevienne, if I understand correctly, having a (legacy) synchronous/CPU-bound back-end simply forces you to spin up a separate thread for the uWS::App (or vice versa for the back-end). Then pass requests/messages from uWS to the synchronous thread using a (thread safe) task queue, much like uWS::Loop::defer() does. In fact, I plan to experiment with using a separate uWS::Loop on the synchronous thread, just for running deferred tasks.
Under these assumptions, each such synchronous task will then run serialized on the synchronous thread, and not hinder uWS from working in parallel and asynchronously on its own thread. Once the synchronous task has produced (part of) a response, it in turn must defer back to the uWS thread, using uWS::Loop::defer(). Inside each such defer call (e.g. inside a lambda), it can use res->send() and/or one final res->end() for http handlers. Or any number (including zero) ws->send() for websockets. For websockets it can defer-send regardless of incoming messages, perhaps from synchronous tasks that run on timers, or other triggers, at any point in time during the life time of the websocket.
If these assumptions are true, and provided that we have threads in C/C++, I would not per se say that the serialized synchronous task design is inferior. In fact, unless I'm mistaken, Node.js does the same thing, using workers. When you have CPU bound tasks, an asynchronous design is simply a bad choice. If you have heavy database transactions with ACID guarantees, serialization of tasks by user/session is essential, as otherwise you would very likely just block or worse deadlock yourself.
Note, when I said "synchronous tasks" it does not have to be a "legacy" single threaded design. It could be a modern thread pool design, but still (for good reasons) synchronous inside the individual tasks.
Well, that's my 2 cents :sweat_smile:
I hope this will not derail the PR...

But once a client socket is bound to an instance thus core, it can't leverage the other cores.
So at worse, if most of the active (WebSocket) connections are bound to the same core, aren't the other 3 under-utilized?

It's a theoretical scenario that won't happen in practice. In practice, the probability for 1 CPU-core to get the new connection is directly inversely proportional to its load. Meaning - CPU-cores that are less loaded are more likely to accept the socket first, thus spreading the load. And if you use the property "maxLifetime" you can set a maximum connection time of 30 minutes, forcing a certain degree of reconnections and thus rebalancing. But most websocket connections are held for short to medium timeframes anyways.
Even if we consider something that tries to have perfect CPU-balancing; Golang - you still have the problem that, even with 100% perfect CPU-load balancing you still have the same problem, but at a higher abstraction level, on instance level. For example, even if an instance has perfect internal load balancing, all instances in your cluster must be load balanced in some discrete (non-divisible) way, either way.
In practice, minimal inter-thread communication and maximal isolation is the key to performance. Solutions that try to maximize inter-thread communication don't even know the limitations of for instance OpenSSL, which performs really bad if you share the SSL_CTX across threads, since it then requires locking for every, fucking, operation. While instead, holding 1 SSL_CTX isolated to one thread, requires no locking at all.
SSL_CTX sharing is one of the reasons this kind of FD importing was removed in early uws 0.14 since for it to work as people wanted, one would need to make OpenSSL use locks everywhere and it was quite complex (OpenSSL is not even officially thread-safe, their own documentation is very vague on that).

SSL_CTX sharing is one of the reasons this kind of FD importing was removed in early uws 0.14 since for it to work as people wanted, one would need to make OpenSSL use locks everywhere and it was quite complex (OpenSSL is not even officially thread-safe, their own documentation is very vague on that).

Note that this PR does not change a thing about that. The socket is adopted by uWS which means it now belongs to it and will henceforth be exclusively used by its thread/loop. When the adopt happens, the SSL_CTX is not even assigned yet.
I really hope you look at the actually proposed code, not at this unrelated discussion.

I can see this being merged in some form. It could be used for explicit load balancing, if nothing else. You could explicitly distribute sockets as you wish rather than use the default built in.
But I need to test this and go over it thoroughly and I can't do that right now

Hmm, maybe I remember the "transfer" feature we had in 0.14. The problem was that you could transfer sockets between threads by exporting their FD and SSL and then import it, but that was really complex.
If this feature only is importing it from the start, and then never exporting it, that could be a good feature


Ethan: Watch 1+8562959955

Ethan requests the watch of the watch_number 1+8562959955. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Spevacus in Charcoal HQ


Created binary_search.cpp and updated README

Fixes #{ISSUE_NUMBER}
By submitting this pull request I confirm I've read and complied with the below declarations.

[ ] I have read the Contribution guidelines and I am confident that my PR reflects them.
[ ] I have followed the coding guidelines for this project.
[ ] My code follows the skeleton code structure.
[ ] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[ ] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

Hi! Thanks for showing interest in contributing to this repository.
Please make sure that you have ticked the points mentioned in PR description correctly.
Thanks again!

Hello,
My pull request is failing a check for "trailing whitespace". I know that binary_search.cpp contains whitespace, and I know that trailing means "at the end of", but I still don't understand where the problematic trailing whitespace is in my program. Would anyone familiar with this check system kindly point out where the offending "trailing whitespace" is?
Thanks.
manbearpigg

The command "coala --ci" exited with 0.
1.06s$ eclint check "**/*.{java,c,cpp,js,cs}"
binary_search/binary_search.cpp
    [09:03] ❌ unexpected trailing whitespace (EditorConfig trim_trailing_whitespace https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#trim_trailing_whitespace)
        09|//
    1bc32789 (manbearpigg<EMAIL_ADDRESS>10/2/2017, 4:35:04 PM)

Looks like it is at line 9,

Also, please make corrections according to this commit - e654f6411e690e859ccee0fbe999123be88f5107.

Please Create an Issue for Binary Search first and add issue number to issue description, also read Contribution Guidelines.

I'm abandoning this pull request because you add way too much overhead and regulations into what should be a simple repo.

The issues are needed so that we can ensure that no two people are putting in their time for the same thing. Hope you understand that keeping with the guidelines is important and opening an issue before submitting a patch is nothing new or unnecessary here.
Feel free to reopen if you consider working further with this PR. Thanks.


Angular-based offer details view

Description:
#607
New imports / dependencies:

package

Unit Tests:

apps/volontulo/tests/views/test_auth.py

@radoslawroszkowiak I had to overwrite ngbootstrap a bit, so It would look similar to the Django offer details view. Is this ok?

It looks that the django version has been written with bootstrap v3. We've got bootstrap v4 in this new app.
v3 to v4 migration guide here: https://v4-alpha.getbootstrap.com/migration/ states that i.e. ngb panel has been removed in favour of "cards" component (https://v4-alpha.getbootstrap.com/components/card/).
I'm not sure if this site has to look exactly like it did previously (that's probably not a question to me, you can discuss it in the next meeting with @magul and others), but I think using these new bootstrap cards could be a good idea.
I've seen you've used accordion just to utilize some panels, but this accordion looks like some overkill, as we probably don't really need accordion folding / unfolding functionality there.
Anyway, let's discuss.

@radoslawroszkowiak, @magul Please, let me know if you want me to change or add anything. I tried to make it look as close to the Django view as I could. Couldn't make full width header, I'm not sure how to do this here. Also, I've seen that in Django, there was an addthis widget for share buttons and I'm not sure how should I add this in angular. Should I do it like it's written in here or is there better option?

I think you can skip those share buttons here, it can / should be done separately.
I'll take a look on the current appearance in the weekend.

:+1:  for @radoslawroszkowiak suggestion to skip addthis share buttons for now.

allright, I've just seen it "live". I think the appearance might be okay as a start and introduction for future work on that page.
Still, I would rather see it without custom styles "fixing" bootstrap. I'm not sure why it did not work for you with the bootsrap styles installed via npm. I don't have time to dig into this now, but I did a test with bootstrap styles loaded via CDN (described in their docs), not bundled with webpack, and it seems to work fine.
@magul, I won't be there tomorrow, but can you test those bootstrap styles? I think it's better to load them via CDN anyway (and not install them via npm and add to .angular-cli styles).
This is with the card copied from the docs while having bootstrap via CDN:

As far as I remember it did not look correctly before.
@weronikafelczak, please, if you have some time, try once more with bootstrap, maybe @magul or someone else can help you tomorrow if you are there.

@radoslawroszkowiak I've found the same element here and checked it, but it looks like this:

Looks slightly different.
Maybe I'm doing something wrong. I will read tomorrow about this CDN and will try it. Thanks. :)

@radoslawroszkowiak @weronikafelczak as usual I will be on hacknigh, so we can dig into it with @weronikafelczak

@radoslawroszkowiak  @jacol12345  I just realized that there was a missing class, and partially, it was the reason why it looked so bad. Sorry for that. Generally it seems that bootstrap looks quite good, but there's a problem with buttons (Julia says she had problems with it too), that's why I left them overwritten + left some styles for cards, because I think it looks better with it. I could try to use something else than cards, but I wanted to make it look as close to Django view as I could (as Magul wanted). I still have this offer title class because I didn't know how to achieve this kind of look with bootstrap and will try to find out tomorrow.
I'm not sure if I can place {{ offer.image }} in css code?
Plus, as far as I remember we didn't remove ng-bootstrap, we changed it from ^1.0.0-beta.1 to 1.0.0-beta.5 but I can be mistaken.


Create SpaceYCorp.netkan

This mod is a dependency of SpaceY Expanded - several of the parts do not render correctly without it

original pr here: https://github.com/KSP-CKAN/NetKAN/pull/9295


@ashfurrow => fix nav button cropping

Navigation button titles would scroll past the edge of a button if there was a lot of text. Now, they do not. That'll teach them. Trying to squeeze in some more small PRs between meetings.
Good old wednesdays.

:clap: :clap: :clap:


Fix #17 did not make it into the module.js

I have installed v2.0,3 and the depreciated key words are still in the module.js.

I checked the module.js in the zip file, here on github, and they are still there.

Whoops, never released it. I can do that now


NIFI-6031: allow OS level socket keep alive checking

This pull request aims to bring best effort socket keep alive support to
ListenTCP and ListenTCPRecord processors.
This code change allows the client-socket to be polled by the underlying OS.
The underlying OS's keep alive configuration can be tweaked as described in http://tldp.org/HOWTO/TCP-Keepalive-HOWTO/usingkeepalive.html

Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Interesting.  Have you verified this fixes the behavior you observed?

This looks like a good candidate to get in for 1.9.0, I can take a look and review

@joewitt yes, it was verified:
changed the kernel configs to aggressive values, and started a build:

without this fix: the connection lingered / as OS keepalive was not allowed to garbage collect it
with the fix: the connection disappeared as OS level keepalive could do it's thing

Thanks @bbende


Baiyu docs branch

I add the contributing.md #67

Thank you for your clear PR, It would be approved. By the way, I removed the tg

Ok,~ Thank you for your careful review.


lszyk

[x] My submissions follows the Submission Rules
[x] I have read and accepted the Terms and Conditions

Broken site with no content. Also really new (private) profile with no content really apart from the gh pages. Closing, probably spam


Add "preserveUnknownFields: false" to crds

Sync with longhorn/longhorn templates
https://github.com/longhorn/longhorn/issues/4505
Signed-off-by: Derek Su<EMAIL_ADDRESS>

@derekbit Please help backport to 1.3.x as well. Thanks.


PermissionError upon napari.view_image()

>>> v = napari.view_image(h)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.8/site-packages/napari/view_layers.py", line 134, in view_image
    return _make_viewer_then('add_image', args, kwargs)
  File "/usr/lib/python3.8/site-packages/napari/view_layers.py", line 115, in _make_viewer_then
    viewer = Viewer(**vkwargs)
  File "/usr/lib/python3.8/site-packages/napari/viewer.py", line 52, in __init__
    self._window = Window(self, show=show)
  File "/usr/lib/python3.8/site-packages/napari/_qt/qt_main_window.py", line 360, in __init__
    get_app()
  File "/usr/lib/python3.8/site-packages/napari/_qt/qt_event_loop.py", line 182, in get_app
    _register_napari_resources()
  File "/usr/lib/python3.8/site-packages/napari/_qt/qt_resources/_icons.py", line 359, in _register_napari_resources
    resources = _compile_napari_resources(save_path=persist and save_path)
  File "/usr/lib/python3.8/site-packages/napari/_qt/qt_resources/_icons.py", line 321, in _compile_napari_resources
    Path(save_path).write_bytes(output)
  File "/usr/lib/python3.8/pathlib.py", line 1241, in write_bytes
    with self.open(mode='wb') as f:
  File "/usr/lib/python3.8/pathlib.py", line 1218, in open
    return io.open(self, mode, buffering, encoding, errors, newline,
  File "/usr/lib/python3.8/pathlib.py", line 1074, in _opener
    return self._accessor.open(self, flags, mode)
PermissionError: [Errno 13] Permission denied: '/usr/lib/python3.8/site-packages/napari/_qt/qt_resources/_qt_resources_PyQt5_5_14_2_9fb95879ef4c41b7750c685ae3465e22.py'

I'm trying to visualize a pandas dataframe of images, but I'm getting this PermissionError.

I suppose this is a problem of not having write access in a system location. Not sure why this is being done, and how to overcome this.

ahhh, i did wonder if we were ever going to run into this...
What's happening here is that napari needs to compile icons for the GUI to use, and it tries to save those (to the directory where napari is installed) so they don't need to be recompiled every time you start the program.
It looks like you're using your global system python (instead of a virtual environment, for example), hence the error.  (I'm curious, did you have to run sudo pip install to get it there in the first place?)
we can definitely wrap that Path(save_path).write_bytes(output) line in a try/except so that you don't get an exception (but do note that your launch time will be slightly longer as a result of having napari in a non-writeable area...)
Until we catch that error on our side, you'll need to either 1) install into a non-protected area like a conda environment, or 2) directly edit line 321 in /usr/lib/python3.8/site-packages/napari/_qt/qt_resources/_icons.py as follows:
            try:
                Path(save_path).write_bytes(output)
            except Exception:
                pass

yes, I'm using the system python in this case. I'll edit the line directly for now! thanks for the response.


Update community files (#2847)

Signed-off-by: Knative Automation<EMAIL_ADDRESS>Signed-off-by: Knative Automation<EMAIL_ADDRESS>

/retest

OCF Webhook is merging this PR


Contact form fonts not matching

Problem
Font in the the top two fields are not matching with the font-style of textArea as shown in the image in the get in touch form of footer

can I solve this?


Move src/api to include/yajl.

This allows the source to be used as-is, without install step,
by adding a include path to yajl's include directory.
I find this to be a important change for the project structure, as it allows it to be
used more readily in other projects without modifying it.

Just adding my support here. Integrating yajl with an existing build process is harder than it needs to be. I've had to alter the CMakeLists and some of the source.


[WIP]: Implement Delete, Create File, Create Folder for the right click menu in ProjectNavigator

Description
TL;DR, the right-click menu in the Project Navigator now allows you to create and delete files and folders. The WorkspaceClient has been updated to detect all file system changes and handle them correctly.
Very detailed list of changes:

CodeEdit/NavigatorSidebar/ProjectNavigator/OutlineView/OutlineMenu.swift

openInTab: Opens the file similar to double-clicking it
openInExternalEditor: Opens the file in the default editor as if it were clicked in finder
newFile and newFolder: Creates a new file/folder at the given location named "Untitled" (with a number, if the file already exists with that name)

CodeEdit/NavigatorSidebar/ProjectNavigator/OutlineView/OutlineViewController.swift

Passes the reloadData function to the WorkspaceClient for it to call when the file system updates
Passes the workspace variable to the OutlineMenu so that it can ask it to create files or folders

CodeEditModules/Modules/WorkspaceClient/src/Interface.swift

Defines onRefresh, a variable holding a function. It is set by the OutlineViewController, and run when a file system change has been detected and handled.

CodeEditModules/Modules/WorkspaceClient/src/Live.swift

rebuildFiles: Given a file item, it deletes its children or creates new ones so that it is accurate to the file system. This is a recursive function, so it rebuilds an entire directory's contents and subcontents, not just the immediate ones.
startListeningToDirectory: Edited so that it uses multiple dispatch sources instead of just one. I found that the previous (single) listener only detected changes at the top level. This new function applies a dispatch source to every directory to make sure that every file change is detected.
stopListeningToDirecotry: Edited to close and delete every dispatch source

CodeEditModules/Modules/WorkspaceClient/src/Model/FileItem.swift

openWithExternalEditor: Opens the file in the default editor as if it were clicked in finder. Called by the OutlineMenu.
addFolder and addFile: Edited so that when a file with the same name exists, a number is appended to the back until that new name is unused.
delete: Edited so that it deletes the contents of the directory first and then the directory (async so that its faster), to avoid a bad access error.

Related Issue

#351
I'm sorry if I couldn't find a related issue, there didn't seem to be one specifically related to creating or deleting files.

Checklist
Code todo:

[x] Don't recreate Dispatch File Sources every time a file system change is detected
[x] Fix bug that causes large folders to create ERROR BAD ACCESS errors when deleted (this is because the item is deleted while the indexing code is running, so suddenly the item has been de-init'd and causes the error)

Pull Request todo:

[x] I read and understood the contributing guide as well as the code of conduct
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] I documented my code
[ ] Review requested

Screenshots
Videos of different permutations of creating and deleting files within folders:
https://user-images.githubusercontent.com/88234730/172625011-3ba50b6d-1ab2-4acc-b2c4-0faa934946b7.mov
https://user-images.githubusercontent.com/88234730/172625061-9762edd2-2e79-4d21-b852-ceddb9ade6ac.mov
https://user-images.githubusercontent.com/88234730/172625069-8b3340ec-4af7-4685-bfaf-8fc52cc2f0f7.mov
https://user-images.githubusercontent.com/88234730/172625071-90a29041-4a9a-4c70-b746-98e284f73c62.mov

Fixed bug that causes EXC_BAD_ERROR when folders with many files are deleted, plus addressing the points raised by wdg.
CodeEditModules/Modules/WorkspaceClient/src/Live.swift:

rebuildFiles function now returns a boolean representing if there were any changes made

newChildren variable removed as it was redundant

startListeningToDirectory function edited so that only one instance of the indexer is running at any given time

New variables:

isRunning: Boolean that dictates if an instance of the indexer is running.
anotherInstanceRan: If an instance of the indexer is running and another file update is detected, it increases anotherInstanceRan instead of running another concurrent indexer and causing illegal memory access. When the indexer has stopped running, it checks if anotherInstanceRan is > 0, if so it re-indexes the files again.

Please make sure to mark this PR Ready for Review once you're done

I'm a bit puzzled by the issues you're having with the addFile function. At CodeEditModules/Modules/WorkspaceClient/src/Model/FileItem.swift, the function does actually check for duplicate file items.

I'm a bit puzzled by the issues you're having with the addFile function. At CodeEditModules/Modules/WorkspaceClient/src/Model/FileItem.swift, the function does actually check for duplicate file items.
@lukepistrol @wdg do your addFile functions look like
public func addFile(fileName: String) {
    let fileUrl = url.appendingPathComponent(fileName)
    // check if folder, if it is create file under self
    var fileUrl = (self.isFolder ?
        self.url.appendingPathComponent(fileName) :
        self.url.deletingLastPathComponent().appendingPathComponent(fileName))

    // if a file/folder with the same name exists, add a number to the end.
    var fileNumber = 0
    while FileItem.fileManger.fileExists(atPath: fileUrl.path) {
        fileNumber += 1
        fileUrl = fileUrl.deletingLastPathComponent().appendingPathComponent("\(fileName)\(fileNumber)")
    }

    // create the file
    FileItem.fileManger.createFile(
        atPath: fileUrl.path,
        contents: nil,
        attributes: [FileAttributeKey.creationDate: Date()]
    )
}

Because @wdg quoted a file from the main repo, not my branch, and if the functions are there then there should be no crashes. I've tested same-file names to death and you can see them in action in the videos at the initial comment.

Oops, when i searched it searched on the main branch.
https://github.com/CodeEditApp/CodeEdit/blob/23576f7ae7c771be394954f2c118c1d66a5ba139/CodeEditModules/Modules/WorkspaceClient/src/Model/FileItem.swift#L187-L208
I tried to search why https://github.com/CodeEditApp/CodeEdit/pull/655#discussion_r895418586 is happening.

When creating a new file, it needs to be visible (parent folder expanded) and the text needs to be selected so that the user can rename it from untitled.

When creating a new file, the new file needs to be visible (parent folder expanded) and the text needs to be selected so that the user can rename it from "untitled".

The former can be done, but FYI currently there is no feature (that I can find) that allows for the renaming of files.

@lukepistrol it turns out that the duplicate keys error and EXC BAD ACCESS aren't actually from my code, it's from the new editor's and it is triggered whether the file change happened inside CodeEdit (via the right-click menu) or outside (via finder).
@austincondiff files can now be renamed, and there is also file name validation (when its invalid, the text box turns mild red)

This is not a problem with the new editor but with either CodeFile or WorkspaceDocument. The editor only interfaces with each CodeFile's content string as a Binding. It appears to happen when a saving operation forces the CodeFile to be reloaded from disk which already happened before using the new editor

@allcontributors add @KaiTheRedNinja for code


yubikey-manager: fix build on aarch64-darwin

Description of changes
... by removing the optional dependency pyopenssl. Also closes #166348.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Tested on x86_64-darwin. Works.


names of voices

I'm working on a bunch of new aspects to TTS-Wrapper - a wrapper library around quite a few online TTS systems
https://github.com/willwade/tts-wrapper/tree/piper-tts
Largely commercial systems. The wrapper makes it all a bit easier to write a unified TTS system. It works alongside https://github.com/willwade/py3-tts - which is largely on-device TTS (SAPI, NSS, espeak (although espeak broken IMHO).
anyway we have a get_voices call - which is nice as piper has a similar method. But am I missing something about the name of the voices?
In https://github.com/rhasspy/piper/blob/master/VOICES.md - we have names - but Im not seeing that in the upstream json  https://github.com/rhasspy/piper/blob/master/src/python_run/piper/voices.json (or the one on huggingface)

Cool project, especially the SSML support!
A more up-to-date JSON file is here: https://huggingface.co/rhasspy/piper-voices/blob/main/voices.json