Checking client readiness

Wondering how to check client readiness for a client.
See that there is an attribute
is_ready                    --  returns boolean value specifying whether services on the
client are running or not, and whether the CommServ is able to communicate with the client
Invoking this for a dummy client created returns true. But the client doesnt exist in reality.
What I need is check readiness to see if there are no network issues while communicating with the client.
I am obtaining the object for the client as follows:
clTest = commcell.clients.get("abc")
Regards
Ashutosh

Found out how to get readiness for the client. You may close this issue.


Updated package.json dependencies

Hello,
I updated the Webpact, React, and a few other dependencies in the package.json file. Would this be a useful contribution to the project? I'm not sure how to add it or if it's helpful. Sorry if I'm commenting in the wrong place.
The new package is here: https://github.com/WillTheSun/InventorySite/blob/master/package.json
Best,
William

OK, good luck! I'd love to contribute and help out.


Next release 2.0

Low level part of aiohttp is completely re-written. And with 2.0 we can drop a lot of deprecated code, like wsgi and .url_obj. And speed gain can encourage developers to migrate to 2.0
On other hand nothing has changed in high level api.

Yeah, I say go for it,

@kxepal @asvetlov

Do we strictly follow semver or any else versioning policy?
Otherwise, according all the changes, I think 2.0 is a good one to reflect all of them.
What's the schedule for a new release?

i am targeting first week of the march.
i still need to add tests for pipelining and exception handling in pipelining mode. also we need to think what to drop and what to just deprecate

Cool. I'll revisit multipart module then. It strongly need in a refresh.

We shouldn't drop deprecations too fast.
I tried to keep 1.5 year deprecation period.
1 year is shortest value from my point of view.
Otherwise support the code which is built on top of aiohttp is nightmare -- people don't like to be unable running half year old codebase with fresh aiohttp version.

With such strategy calendar versioning would be perfect. Things that are deprecated in 16.03 will be removed not before 17.03.

But sometimes we break own strategy for strong reasons, e.g. if bug fix cannot be done in backward compatible way.

@asvetlov I agree with that, but we have opportunity to make nicer api right now which we probably won't have for long time. I am talking about things like .url vs .url_obj and that's why I need your help

actually i'd just rename ClientResponse.url_obj -> ClientResponse.url, thats annoys me a lot :)
everything else seems good.

Because of personal matter, I've decided to stop support and contribute to aiohttp project within KeepSafe organization.
I reverted all my changes that I've made for 2.0 release.
Regarding my changes I developed for last couple weeks, I may push to separate repository later.

@fafhrd91
What happened? Is aiohttp get moved to aio-libs organization?

I am not with Keepsafe, I do not have any influence on this matter

I moved all my code to https://github.com/fafhrd91/aiohttp


Hi, this doesnt work fine on chrome :(

Hi, great component! congratulations and thanks, but it works fine in Edge but in chrome it doesnt show correctly ¿do you know why?
Thanks a lot again, I realy need this, but I am just starting with Polymer.

Thanks! Whats the error/problem?
Does the demo work in your browser? http://jaysunsyn.github.io/polymer-tinymce/components/polymer-tinymce/

Hi, the demo works fine :( , I am using polymer CLI,  I just add this code
<polymer-tinymce id="editor"                                      tinytoolbar="insertfile undo redo | styleselect | bold italic | alignleft aligncenter alignright alignjustify | bullist numlist outdent indent | link image"                                      tinyplugins='["advlist autolink lists link image charmap print preview anchor","searchreplace visualblocks code fullscreen","insertdatetime media table contextmenu paste"]'></polymer-tinymce>
and in Edge works fine but in crome doesnt, as you can see in the images :( but I have another big problem that I don't understand :( when I install the component with the command:  bower i polymer-tinymce -S after that the command polymer build doesnt finish building,

I dont know why :(

Does your javascript console show errors?
MarcosGalaviz<EMAIL_ADDRESS>schrieb am Do., 6. Okt. 2016 um
22:35:

Hi, the demo works fine :( , I am using polymer CLI, I just add this code

and in Edge works fine but in crome doesnt, as you can see in the images
:( but I have another big problem that I don't understand :( when I install
the component with the command: bower i polymer-tinymce -S after that the
command polymer build doesnt finish building,
[image: cmd]
https://cloud.githubusercontent.com/assets/14163318/19169517/7fb4b838-8bda-11e6-8091-ce1a96b4fcdd.gif
I dont know why :(
[image: edge]
https://cloud.githubusercontent.com/assets/14163318/19169076/6a24e7b0-8bd8-11e6-84c5-c97bed9c54fd.gif
[image: chrome]
https://cloud.githubusercontent.com/assets/14163318/19169078/6ca25860-8bd8-11e6-8b53-0625ce020a31.gif
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JaySunSyn/polymer-tinymce/issues/3#issuecomment-252080682,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFmbMKp_O4U87XQ5_mztbLEg2NULIuzIks5qxVuagaJpZM4KQMtJ
.

No any error there jeje , is the devil :d

Do u load webcomponents.js conditionally in your index.html file? Force it
to load, does it solve the issue?
MarcosGalaviz<EMAIL_ADDRESS>schrieb am Do., 6. Okt. 2016 um
23:01:

No any error there jeje , is the devil :d
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/JaySunSyn/polymer-tinymce/issues/3#issuecomment-252087395,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFmbMOVynu6-kc-zfKeFTR_1qmutnAz1ks5qxWGegaJpZM4KQMtJ
.

Thanks again for your answer, I hope not being disturbing you :(, I added this line, I guess with that line the webcomponents.js is loaded, but doesnt work :(

I made some small changes but don't know if it will fix your issue.
Please run bower update and let me know if it works.

Thanks for your support, I executed bower update, but still the same problem :(, even I install a new proyect with: polymer init  just to test and I only add your component but I have the same Issue :(.
It shuld be something with polymer cli I think :(.

try now, I've only updated the bower and it seems to work with cli. Does it?

Feel free to re-open this issue if you still have problems.

Hi thanks a lot, I realy don't understand but still not working in chrome :( I did this:
Installed with: polymer init : app-drawer-template
just install the component and try to use it, in edge works but not in chrome :(

Same problem here: works fine on IE, but not on chrome. No error...nothing.

Problem solved: you need to swith from shadow to shady
=> https://www.polymer-project.org/1.0/docs/devguide/settings

@jpicus thanks, added a hint Readme.md


I am pretty sure this is incorrect.

"When SQL Server logins are used, SQL Server login names and passwords are passed across the network, which makes them less secure."  You are not doing anyone any favors with comments like this.  Passwords are supposedly hashed and not sent in clear text.  If this is not true, please let me know.  If it is true, please be more specific.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8534d363-5147-4022-82d0-a4a3346040b2
Version Independent ID: 81d6e039-1ad5-90d1-3707-fb7a5c7a0e16
Content: Authentication in SQL Server
Content Source: docs/framework/data/adonet/sql/authentication-in-sql-server.md
Service: unspecified
Product: dotnet-framework
GitHub Login: @douglaslMS
Microsoft Alias: douglasl

#in-progress

@BillMcNabb You're right that the quoted statement could leave a reader with questions. We will clarify to say that ENCRYPTED passwords are passed across the network." However, since encryption can be broken, I believe the statement that passing passwords (SQL auth) as opposed to NOT passing passwords (Windows auth) is less secure, is a valid cautionary statement. How else would you improve this language?

Hello Douglas,
Yes that would be fine.  The problem I have is there is so much misinformation on the internet.  And, I am dealing with an auditor that is claiming SQL Server Auth passwords are sent in clear text.  This document was the newest I could find, but it did not make it clear that passwords are not sent in clear text.
Thank you,
Bill
From: Douglas Laudenschlager<EMAIL_ADDRESS>Sent: Monday, May 21, 2018 3:48 PM
To: dotnet/docs<EMAIL_ADDRESS>Cc: BillMcNabb<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [dotnet/docs] I am pretty sure this is incorrect. (#5534)
@BillMcNabb https://github.com/BillMcNabb  You're right that the quoted statement could leave a reader with questions. We will clarify to say that ENCRYPTED passwords are passed across the network." However, since encryption can be broken, I believe the statement that passing passwords (SQL auth) as opposed to NOT passing passwords (Windows auth) is less secure, is a valid cautionary statement. How else would you improve this language?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/dotnet/docs/issues/5534#issuecomment-390805704 , or mute the thread https://github.com/notifications/unsubscribe-auth/AlrEV4ran9RFuhH8IYh53QT-iKIuck62ks5t00QVgaJpZM4UHrJo .  https://github.com/notifications/beacon/AlrEV2eDDnFH_ugRpwurdCSlV3xC2gPMks5t00QVgaJpZM4UHrJo.gif

@BillMcNabb First, I empathize with your situation. Second, I agree that the results of a web search are ... inconsistent. The confusion's made worse by the fact that two-thirds of the results are about saving an encrypted password locally or in app settings, rather than about sending an encryypted password. When you talk about sending SQL logins, is the sender SSMS, or a client app probably written using ADO.NET, or a web app? It seems to me that the answer could theoretically dependent on the sending app and its settings.

@BillMcNabb This issue has been closed because I resolve the ambiguity in the article that was the doc issue you raised. However if you want to answer any of my previous questions I can double-check a little further. The article mentioned in this issue describes ADO.NET and therefore the SqlClient provider sending logins. That might not be your scenario.


Read-only Data Cache (__ldg) / Performance suite

Currenlty __ldg is used in a few places such as brute force messaging, but not spatially partitioned messaging as it shows varying improvements/regressions to performance in different cases.
This suggests we need a broader peformance suite / process to evaluate which optimisations we should make (potentially applying them to different architectures).
For instance, on Pascal ( GTX1080) for boids brute force with 32k agents ldg for message data improves performance by ~ 1%. while on volta it leads to a 1.5% drop in performance. This may be occupancy related.
In order to make good decisions, we should automate the process of checking performance across a suite of models, at various scales and on various GPUs in order to tune FLAMEGPU. We may even want to make these optimisations user-configurable, or even automatic.
Things the performance suite / eval should cover:

Occupancy via agent population
Message Partitioning specific parameters, such as density or bin count.
GPU architecture (Pascal, Volta, Turing, Ampere?), maybe even GPU size (although we should probably target larger GPUs by default).

This should be an automated process, so we can simply build and then run the performance suite, generating a (csv?) of performance and/or profile reports to analyse. This would then make it easy to decide if an optimisation should be implemented or not.

Somewhat related to #275


Glob implementation doesn't match LSP spec

System.FilePath.Glob doesn't support {x,y} for alternatives, which the LSP spec says are allowed in glob patterns.
*Language.Haskell.LSP.Test System.FilePath.Glob> match (compile "{a,b}") "a"
False

Indeed, I was being lazy but eventually we should implement a globber which implements the spec exactly. Should probably implement it in https://github.com/alanz/lsp


[#32] Improve built-in /metrics endpoints to use both counter and gauge

@jesperpedersen This is the implementation of what I had in my mind for #32. I still haven't added an install instruction for internal.yml file to have the path /etc/pgexporter/internal.yml, but using the following command before running the binary should do it.
sudo cp ./contrib/yaml/internal.yml /etc/pgexporter/internal.yml

I am not much familiar with writing CMake files or Spec files for RPM, so I'll look into those for this when this idea gets a green signal.
PS: This is just a bare-bones working change to the repo to demonstrate my idea. This needs work here and there, which I'll be glad to do.

Ok, I get where you are coming from.
However, internal.yml def lives in src/yaml instead, and you can't assume it should loaded from /etc/pgexporter as the configuration can be overwritten by -c.
Start by investigation if it can be embedded into the shared library, and loaded from there. Or do it as an internal.h with the text string.
Latter is likely more acceptable...
As is, no

Much happier with that - go ahead

@jesperpedersen PTAL

I have yet to identify the metrics that are better represented by counter than a gauge and I'll start looking into it.

Sounds good - I gave the patch a quick scan...

@jesperpedersen I've made the requested changes, and I'll give a PTAL after finishing looking into which metrics need to be collectors

Merged.
Thanks for your contribution !

@jesperpedersen Thank you for the review and thank you for the (very long) discussion around it! I hope this solves the problem that the issue aimed to point out.


feat: unify settings into single EditSettings page

Summary
This PR merges Settings and EditSettings into single page.
It also adds reusable ModalTransactionProgress modal that you can use to track actions (can be also used for Voting progress).
Closes: https://github.com/snapshot-labs/workflow/issues/165
Designs on Figma
How to test

Go to space you are controller of (onchain only).
You see Settings tab and you can open it.
You can see different settings (strategies, voting, executions, controller).
You can modify those settings and changes are detected (there is some delay because metadata needs to be created async).
You can reset changes.
You can modify settings and go through new ModalTransactionProgress flow (you can reject in the middle of it, wait for confirmation etc.
You can modify controller and go through new ModalTransactionProgress flow.

Screenshots
https://github.com/user-attachments/assets/5aac8fd8-aeb6-43a7-a925-443b86b685d2

Logo is missing on "create" page

@bonustrack can you take a look into if UI text is what we want in this? There are some placeholder texts as well as there were few on designs as well.

@Sekhmet Yes it's good
Here are the description for controller:
The controller is the account able to change the space settings and cancel pending proposals.

Here is for voting:
Set the proposal delay, minimum duration, which is the shortest time needed to execute a proposal if quorum passes, and maximum duration for voting.

Here is for execution:
Execution strategies determine if a proposal passes and how it is executed. This section is currently read-only.

Also "Proposal threshold" should not appear in "Voting" section

There is some kind of memory leak issue that freeze the UI on the Nimbora space:
https://snapshot.box/#/sn:0x05ea5ef0c54c84dc7382629684c6e536c0b06246b3b0981c426b42372e3ef263

This was caused by Whitelist strategy, because it's merkle tree generating it proof is taking some time (and it's synchronous) and this is what final param for strategy is, added few changes that will now prevent computing params for MerkleWhitelist strategies and instead compare metadata only (which are equivalent because it contains whitelist itself).
I also had to refactor how we detect changes in validation strategy,

Also the active strategy items are not vertically aligned.

Can we update it on Figma? Current alignment is result of line heights of the rows we have so if I change it it will affect space between those.
Also you were checking paddings on top and bottom text, but there is also icon that affects alignment. Not sure if we should have equal padding relative to text or icon.

The transaction loading icon is not dark theme friendly, need to reverse the color

Instead of this SVG can we use our default loading icon animation and just resize it?

Instead of this SVG can we use our default loading icon animation and just resize it?

Updated but I don't think it looks too good.

I think it's fine, I'm only bothered by the speed of the animation that seem a bit too fast, if you can increase it to 1sec that should work.

I only tester the transaction modal so far, but should be good, since the other tAcked it.
I know the edit page is only accessible by a hidden direct link for now, but maybe should handle the case where someone open this page on an offchain space.

Another little issue, in the voting delay tab

Edit the voting delay: change the value by something else, then accept the change
The new value is reflected in the display
Click on the "Reset" button
In the display, the voting delay should be back to old value
Open the voting delay form, still pre-filled with edited new value

And in the VOTING tab, all form should exit the edit mode on reset

On narrow screen, the intercom button is overlapping the save button

On some small screen, the bottom toolbar layout is messed up.

Maybe add a breakpoint, and have the message on one line, and the buttons on a second line

When saving a space settings without proposal validation, it return

In the old edit-settings page, the "Save" button is disabled if the form is invalid (but still not showing any validation error)

Addresses all comments except for

On narrow screen, the intercom button is overlapping the save button

Not sure what to do with it, to me it's just super annoying in all cases and will always interrupt with our UI.

The Figma been updated with proper horizontal alignment for cards

Do you think your scroller horizontal can be merged with #648 ?

@wa0x6e I think it should be possible to merge those two. We will need to add some props like enableButtons to add interactions via buttons and showOnlyWheenNeeded to handle this usecase (here gradient is only visible if you are not scrolled enough.
I guess we can merge your PR first and then I will see how to adapt it for our usecase.


[release/1.6 ] Add ArgsEscaped support for CRI

This PR cherry picks commit for argsEscaped support in CRI from containerd/main to release/1.6 branch + updates image-spec version to include the changes for ArgsEscaped support in OCI + git mod tidy/vendor
This commit adds supports for the ArgsEscaped
value for the image got from the dockerfile.
It is used to evaluate and process the image
entrypoint/cmd and container entrypoint/cmd
options got from the podspec.
(cherry picked from commit 8137e41c481abcad865746280ec20d0232a5bb2e)

Should we just cherry-pick these over to 1.6 as well?

Should we just cherry-pick these over to 1.6 as well?

Sure I can send out separate PRs for these two commits

@mikebrow could you please take a look at the changes if you have some time? :)

/ok-to-test

apologies for code review against the cherry pick... maybe open issue on main and back port.. then cherry both to 1.6?

I'm guessing this PR should be closed? The cherry-pick from the already merged change in main is #8306 and is ready to merge for release/1.6 and does not have the test changes you commented on.

/ok-to-test

I'm guessing this PR should be closed? The cherry-pick from the already merged change in main is #8306 and is ready to merge for release/1.6 and does not have the test changes you commented on.

thx was just plowing through review requests and missed the replace change

I think the status here is that this change solves this ArgsEscaped problem for CRI, whereas Justin had made some changes to fix this for containerd (containerd client options, and in the OCI image spec) that would be nice to get in as well. I almost forgot how this played out.
One of two of Justin's changes has been backported already: https://github.com/containerd/containerd/pull/8273.
And @kiashok has an open change for the second (removes a workaround Justin had before he got this field into the image spec itself): https://github.com/containerd/containerd/pull/8306

apologies for code review against the cherry pick... maybe open issue on main and back port.. then cherry both to 1.6?

@mikebrow I submitted a PR against main branch to address the review comments -https://github.com/containerd/containerd/pull/8359 . Could you please take a look?

apologies for code review against the cherry pick... maybe open issue on main and back port.. then cherry both to 1.6?

Hi @mikebrow , changes were checked into main with commit https://github.com/containerd/containerd/commit/e0b817ec1535b73cb4915fa8abacb0454c7f8862 . Cherry-picked the same and updated this PR. Could you please take a look?

@mikebrow @dcantah @dmcgowan  could you please take a look if you have some time?

@estesp the test failure seen here is unrelated to the change being made -https://github.com/containerd/containerd/actions/runs/4726994245/jobs/8387174524?pr=8247 . Could you please restart the failing test?


chore(footer & filing home):  additional resources - clicking opens new tabs

Note: Recreates https://github.com/cfpb/design-system-react/issues/375 merged in first
closes #795
Changes

enhancement: Footer & Filing Home - additional resources - clicking opens new tabs

How to test this PR

Click Footer and Additional Resource Links

Screenshots

Heyo @shindigira! Did you want to take another crack at this one with the comment we discussed earlier from above?


Correct percentage with Future

Hi, I need to generate 4 thumbs and send to S3. It's working but the percentage of the upload goes to 100% when it finishes upload  of the first image. It is possible to measure the percentage of the thumbs and S3 process?
And when the process ends,  how do I return another object or value instead of the collection?
For example pick Future Return (And/insteadOf) FileObj on the event: "upload.on ('end', function (err, fileObj)";
resFuture.return ({
             files: {
               original: originalS3,
               xsmall: xsmallS3,
               small: smallS3,
               medium: mediumS3,
               large: largeS3
             }
           });

Code

// Functions

var generateThumbs = function(path, size, version){
  let resFuture = new Future();
  const arrayPath = path.split('/'),
    imageName = arrayPath[arrayPath.length - 1],
    newPath = path.replace(imageName, version + '/'+imageName);

  gm(path).autoOrient().resize(size).gravity('Center')
    .write(newPath, function (err) {
      if(!err) resFuture.return(newPath);
      else resFuture.throw(err);
    });
  return resFuture.wait();
};

var uploadS3 = function(path, version = false){
  let resFuture = new Future(), newPath;
  const pathCleared = path.replace(appRootPath, ''),
    arrayPath = pathCleared.split('/'),
    fileName = arrayPath[arrayPath.length - 1];

  newPath = version ? pathCleared.replace(fileName, version + '/'+fileName) : pathCleared;
  client.putFile(path, newPath, function(err, res) {
    bound(function() {
      if(!err) resFuture.return(res.req.url);
      else resFuture.throw(err);
    });
  });

  return resFuture.wait();
};

// Collection

HistoriesFiles = new FilesCollection({
  debug: Meteor.settings.public.debug,
  collectionName: 'historiesFiles',
  storagePath: appRootPath + '/uploads/histories',
  downloadRoute: '/images/histories',
  allowClientCode: false,
  public: true,
  onAfterUpload: function (fileRef) {
    let resFuture = new Future();

    let original = fileRef.path,
      xsmall = generateThumbs(fileRef.path, 256, 'xsmall'),
      small = generateThumbs(fileRef.path, 282, 'small'),
      medium = generateThumbs(fileRef.path, 595, 'medium'),
      large = generateThumbs(fileRef.path, 1600, 'large');

    let originalS3 = uploadS3(original, 'original'),
      xsmallS3 = uploadS3(xsmall),
      smallS3 = uploadS3(small),
      mediumS3 = uploadS3(medium),
      largeS3 = uploadS3(large);

    if(originalS3 && xsmallS3 && smallS3 && mediumS3 && largeS3){
      resFuture.return({
        files: {
          original: originalS3,
          xsmall: xsmallS3,
          small: smallS3,
          medium: mediumS3,
          large: largeS3
        }
      });
    }
    return resFuture.wait();
  }
});

Thanks,

Hi @livimonte ,
Currently it is not possible, even blocking code (like Fiber/Future) won't work as onAfterUpload callback is totally asynchronous and detached from MainThread.
You need to really on Mongo record, please see this thread we discussed similar behaviour with @owenhoskins
Let me know if it works for you

Thanks @dr-dimitru, works =)
I updated the issue description with collection update. Maybe help someone.
Congratulations for the good work and it's true @owenhoskins:

I feel like I have control of my uploads with Meteor for the first time :)

@livimonte marked as [In case of the fire - Read This]
Thank you for the choice of this package, and your contribution.
Please, support this project by:

Star on GitHub
Star on Atmosphere
Share on Facebook and Twitter


Disable auto reload of ~/.hyperterm.js

I'm writing tests for hpm and I need to – at least temporarily – disable the auto reload of ~/.hyperterm.js. There is any way to do this?

@matheuss Is this still a valid question?

@matheuss I think it is still relevant. How do you imagine this? param in config?

Especially that it close any running sessions... quite dangerous function

https://github.com/zeit/hyper/pull/1509 doesn't fix this, but anyone who wants to work on this should look at it.

hyper CLI tool works without this because Hyper is waiting some time before reading config after a change event.


Cannot access camelCase relationship as a property

I am unable to access a relationship as a property if the method name has multiple words camelCased. E.g., the following does not work:
// Project
public function superTalents()
{
    return $this->belongsToMany('My\Domain\Talent', 'project_talents', 'project_id', 'talent_id');
}

// in Tinker or via web app
$project = \My\Domain\Project::find(1);
$project->superTalents->toArray();

Doing the above produces the following fatal:
PHP Fatal error:  Call to a member function toArray() on a non-object in /Users/thril/Projects/Whatev/vendor/psy/psysh/src/Psy/ExecutionLoop/Loop.php(76) : eval()'d code on line 1

And if I access the above as a method call, I get the following:
>>> $project->superTalents();
=> <Illuminate\Database\Eloquent\Relations\BelongsToMany #000000004b7de3e5000000005cd99e3d> {}

However, the following method names do work:
// Project
public function super_talents() {...}
// or
public function talents() {...}

// in Tinker or via web app
$project = \My\Domain\Project::find(1);
$project->super_talents->toArray(); // good to go
// or
$project->talents->toArray(); // good to go

I'm on laravel 5.0.23. This appears to be a bug. Please let me know if I'm missing something.

You need to access it as ->superTalents, not ->superTalents().

The property access actually is the result of the query, rather than a relationship object.

@GrahamCampbell, I don't believe you actually read the problem. As indicated in my description, I got a fatal error when doing...
$project->superTalents->toArray()

because superTalents is not a proper collection like super_talents or just talents would be. The issue still stands. By just changing the relationship name to use camelCasing, it fails. That sounds like a bug to me. Please reopen this issue.


change default pid location from /var/run/gitea.pid to /run/gitea.pid

The former one is only kept for backwards compat according to
https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s13.html, and is a
symlink to /run/ on modern distributions.

unfortunately breaking because it will need to be noted on the release notes even if /var/run is just a symlink.

Can you give an example of such other variables that can be set at link time? I'm not really sure I understand what's proposed.
On the other hand, I'm not sure if it's much of an issue in general - What OSes still don't have /run at all currently, but run latest gitea?
We could add something to the release notes, and worst case gitea would fail to start, until either the packager of that distribution, or the admin (who manually upgrades gitea anyhow) would need to change the command line to pass a custom pidfile argument…
IMHO the gitea upstream default should not be the deprecated /var/run, but /run (if creating a pidfile at all is necessary), and whatever extra configuration is required to support super-old distros only working with very legacy locations handled downstream.

@flokli The version variable for example is set at link time: https://github.com/go-gitea/gitea/blob/master/Makefile#L88

@fkokli also see: https://docs.gitea.io/en-us/install-from-source/#changing-the-default-custompath-customconf-and-appworkpath

per @zeripath's suggestion, if LDFLAGS="-X \"code.gitea.io/gitea/modules/setting.CustomPID=/run/gitea.pid\"" is exported as an environment variable (and the make file is used to build), and the line that @zeripath commented on is removed, then the variable is able to be set during build time for the modern distros.

@flokli Thanks for the idea to fix this!

Thanks for taking over! I really couldn't find the time to do this.
However, I still think /run/... should be the default in giteas codebase, and old distributions should set it to /var/run/..., not gitea sticking with the old /var/run/... IMHO.

Centos 7 is the problem.

Yeah, but then CentOS 7 should set this variable accordingly in their packaging script. Gitea shouldn't carry legacy paths...


Provision freedesktop-sdk performance benchmarking

See original issue on GitLab
In GitLab by [Gitlab user @traveltissues] on Oct 2, 2019, 21:15
Now that we've seen some performance regression in the case of bst show in the freedesktop-sdk project I think there's value in analysing that and identifying the sources of stress. There is probably a case for adding this case to regular performance benchmarking on some interval of commits.

In GitLab by [Gitlab user @traveltissues] on Nov 21, 2019, 13:20
marked this issue as related to BuildStream/benchmarking/bst-benchmarking-bot#15

In GitLab by [Gitlab user @traveltissues] on Nov 21, 2019, 13:22
marked this issue as related to #1143


Getting system_time on wasm32 target

Currently the system_time is obtained through this function.
https://github.com/automerge/automerge-rs/blob/c103b0638e24076e6cd755f102f3c75926c25d51/automerge-frontend/src/lib.rs#L417-L426
To be able to use this in a web project (using seed) I'm working on I've had to change this to use chrono:
https://github.com/jeffa5/automerge-rs/blob/b290f9117aced3e3ed1535ed0ccde3a819d88232/automerge-frontend/src/lib.rs#L420-L427
As there was already a comment I wonder whether you'd had ideas about how best to solve the issue and if chrono is a possible option for this project?

Interesting, what leads you to use the Rust frontend in a web environment? I would have assumed the JS frontend would be a better fit?
That aside I'm not sure about bringing in chrono. I love the library but I'm hesitant to add a dependency on it to Automerge for the sake of a single timestamp. I would be more inclined to make the way we obtain the timestamp pluggable so that application developers in no_std environments can use something other than time::SystemTime.

I'm building the entire frontend in Rust so trying not to use js. Basically for the type safety and other nice things in Rust. Also nice to be able to use similar shared logic for frontend and backend.
Yep, adding a dependency on it may be a bit much but would be good to have a way to do custom time in no_std.
If you had any draft ideas I wouldn't mind having a go at a PR :)

These are the things I think such a PR should achieve

Just Work™ if compiling on a platform with time::SystemTime support. i.e the current situation
If compiling for no_std then require an additional argument when creating the frontend which is a function that can supply timestamps
Provide a way to customize the timestamp supplier even when not compiling for no_std

I think that once WASI is a bit more mature we shouldn't need this for browser targets as time::SystemTime has a WASI implementation.
The work then is this:

Add a constructor to the frontend (in automerge-frontend/src/lib.rs) which accepts a timestamp supplier, add this supplier as a field on the frontend and feed it through to the places where time::SystemTime::now is currently called.
Modify the current constructor so that it is only available when compiling via no_std and it passes the default time::SystemTime::now through to the new constructor


Mechanical Bearings performance issues on dedicated server

Describe the Bug
Mechanical Bearings (possibly only in unloaded chunks? I tried to test but it wasn't conclusive) cause heavy server lag (ie TPS slowdowns) when the chunk they're in tries to unload. If one player keeps the mechanical bearing tile entities loaded this issue doesn't show up, but as soon as they're unloaded it starts to lag. Windmill bearings (possibly other create tile entities as well) may cause this issue, I haven't tested everything. I am unsure whether this to single player worlds, I noticed this on a dedicated server.
Reproduction Steps

Have a Mechanical Bearing in a chunk, preferably connected to a stress network.
Unload the chunk. I find this shows up the most when I change dimensions
TPS should slow down a ton

Expected Result
The server shouldn't die.
Screenshots and Videos
No response
Crash Report or Log
Spark Profiler: https://spark.lucko.me/v0YxhXkZPN
Operating System
Fedora Linux (amd64)
Mod Version
0.4.0d
Minecraft Version
1.18.1
Other Mods
https://pastebin.com/DwxdDZZc
Additional Context
No response

you have a very outdated build installed, this should have already been fixed. reopen if it persists.

Issue persists on build 444 (I can't test on the latest build [448] as the refmap changes prevent the game from loading). I'd reopen the issue, but I can't if a collaborator closed it.

please test with the latest build.

I can't reproduce this, reopen if it still happens.


Can i use this plugin in Vue?

<template></template>
<script></script>
<style scoped>
    use it here.....
</style>

I really want to use this plugin when i use Vue.

@Yhspehy will have a look into this for you Vue uses a .vue extension for its files right?

@ashhitch yeah！

+1 for this. It will great to support .vue file

Thanks for the feedback, will add this into the next release!

Sorry about the delay in getting this added the latest version should now work with vue files, let me know if you have any issues!


Insert queries take an enormous amount of time with replicas

tursoClient.js
import { createClient } from "@libsql/client"

const tursoClient = createClient({
  url: process.env.TURSO_DATABASE_URL,
  authToken: process.env.TURSO_AUTH_TOKEN,
})

export default tursoClient

app.js
import tursoClient from './lib/tursoClient.js'

async function testDB() {
    const iterations = 1000 // Number of iterations for stress testing

    // Variables to store performance metrics
    let totalQueryTime = 0
    let totalWriteTime = 0

    // Read operation
    for (let i = 0; i < iterations; i++) {
        const startQueryTime = Date.now()
        const employees = await tursoClient.execute("SELECT * FROM Employees")
        const endQueryTime = Date.now()
        totalQueryTime += endQueryTime - startQueryTime
    }

    // Write operation (inserting a new employee)
    for (let i = 0; i < iterations; i++) {
        const startWriteTime = Date.now()
        // Generate random data for the new employee
        const newEmployeeFirstName = await getRandomString()
        const newEmployeeLastName = await getRandomString()
        const newEmployeeDepartmentID = 1
        // Execute the INSERT query
        await tursoClient.execute({
            sql: "INSERT INTO Employees (FirstName, LastName, DepartmentID) VALUES (?, ?, ?)",
            args: [newEmployeeFirstName, newEmployeeLastName, newEmployeeDepartmentID]
        })
        const endWriteTime = Date.now()
        totalWriteTime += endWriteTime - startWriteTime
    }

    // Print performance reports
    const averageQueryTime = totalQueryTime / iterations
    console.log(`Average query time for SELECT operation: ${averageQueryTime} ms`)

    const averageWriteTime = totalWriteTime / iterations
    console.log(`Average time taken for INSERT operation: ${averageWriteTime} ms`)
}

async function getRandomString() {
  const characters = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz'
  let randomString = ''
  for (let i = 0; i < 5; i++) {
    randomString += characters.charAt(Math.floor(Math.random() * characters.length))
  }
  return randomString
}

await testDB()

Results:
Primary only:
root@ubuntu-s-4vcpu-16gb-amd-ams3-01:~/pastebin# node --env-file=.env app.js
Average query time for SELECT operation: 20.641 ms
Average time taken for INSERT operation: 19.172 ms

Primary + 2 replicas:
root@ubuntu-s-4vcpu-16gb-amd-ams3-01:~/pastebin# node --env-file=.env app.js
Average query time for SELECT operation: 13.753 ms
Average time taken for INSERT operation: 132.646 ms

Is this acceptable? Is there a way to disable replication acknowledgment for insert operations, similar to MongoDB?

Replication is async so it shouldn't impact the performance. This is something we will have to debug to understand why replication has such a big impact on performance.


bot spamming: dotnet-help command triggers multiple comments

In downstream repos' PRs, the help command is getting triggered multiple times for a single request. Sometimes bot posts a comment with help text when we issue subsequent command:

and other times, the bot does that consecutively twice, then again after the subsequent command:

The comments are actually coming from different servers.  They have no way to aggregate.


Glitchy stream even after the movie was fully loaded.

Good night,
I'm running in a Debian Jessie, having installed peerflix using this method. For my first try, I selected the most ranked torrent available for the movie "Inception". The stream's image was both laggy and glitched, and I waited to see if the problem would eventually be resolved by having more parts of the video loaded. Eventually the file was fully downloaded and could even be watched fully and without any problems using the video file available in the tmp folder, but the stream continued with no improvements on quality.
How could I repair this?

Please don't link/discuss copyrighted material here.

I'm sorry, I didn't consider the copyright matter for what I intended to be just a test. It was just the first movie that popped into my mind, but I see your point. I'm going to edit the original post and use an example already in the public domain, could you kindly reopen the issue then?
Thank you.

This is a VLC issue (two VLC issues actually, but one in particular causes the other too), not a peerflix issue. I know of it and have debugged it in the past.
An easy way to reproduce this bug is by seeking forward then backward on a stream. VLC will start buffering constantly with very small pauses between the buffering phases. (even if the video is 100% downloaded)
The reason for this is that VLC keeps requesting the same stream parts over and over frantically, thus flooding the peerflix server with requests.


Cleanup changes

Handling failures in the server.js and exiting in case of failures
Removing lib.bootstrap call from server.js and also removing it from broker/lib/index.js
Instead, moving the docker bootstraping call in the start of the docker operator.
Moving loadCatalogFromAPIServer from broker/lib/index.js to utils
Removing load of BOSHDirectorClient and Bosh cache in Plan, Changing the get stemcell method

Pull Request Test Coverage Report for Build 2704

16 of 16 (100.0%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.05%) to 90.004%

Files with Coverage Reduction
New Missed Lines
%

data-access-layer/cf/TokenIssuer.js
1
98.57%

Totals

Change from base Build 2703:
0.05%

Covered Lines:
8755

Relevant Lines:
9406

💛  - Coveralls


EditBox.cs variable descriptions

_canBeEdit and _isMouseWithinScope have the same comment description.  Shouldn't former be 'enters' not 'over' ?

Can you submit a PR to fix the issue?    Thanks!

Please see here
https://github.com/microsoft/WPF-Samples/pull/103

thanks for the PR @nick2893!


Integrate mdox to CI

Since there are markdown files in this repository, it would be better to add mdox to the repository's CI.

Since this repository only contains two markdown files, installation.md and introduction.md(other files being pulled from the prometheus-operator and kube-prometheus repository), rather than integrating mdox to this repository making the process more complex, it would be much better to move these two files to the prometheus-operator repository to format these files.
I will close this issue and open a PR to move these two files to the main repository.


SIL: IWYU cl edition

Include llvm/Support/CommandLine.h when using llvm::cl.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test and merge


Zoom to issue

Liking the new features :)
One thing I came across though - I moused over a railway line and noticed it had an issue highlighted. It said " crosses Foot Path".
However, the piece of railway line was 2km long so I had to pan the map as I couldn't see any footpath nearby, until I eventually found the problem.
Would it be possible to add a "zoom to issue" feature? I know there is a "Zoom to this" below the preset, but that's not very useful when it's a big object as it zooms right out!

Hi @boothym! You can click the icon/message part of the issue to zoom to the crossing point if it's not on screen. Though this isn't obvious so perhaps we should consider adding a button?

Thanks, that works. :) However I didn't notice it, because there was no hand cursor over the yellow box - except for on the "connect the features" option. Probably should be changed - not sure it's a good idea to be encouraging people to click on the yellow box as they may click the connect option and create a level crossing.
I think even just a text link "Zoom to issue" below/beside the three options (connect, bridge, reposition) would be fine. Maybe in the bottom right below the issue, like the "Zoom to this" is below the preset?

There's no hand cursor because people would rightly assume that clicking it would close the fixes, which it doesn't, and it only zooms to it if it's not onscreen, so sometimes clicking it does nothing!


Enter one-line summary

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 15 Mar 2016 at 1:48

<EMAIL_ADDRESS>


Provide roadmap for actual Material Styles support or rename the plugin

Describe the bug

A material 3 website refers to "Figma Kit" and on Figma Plugin page it says with that it supports "inspect elements and apply semantic color roles." While Material 3 tokens include shape, fonts and others.
There are issues reported when someone tries to do anything more than building colour themes, it fails.

Expected behavior

If there's not going to be a full Theme support, Material Theme Builder should be renamed "Material Colour Builder"

or
Or if there is a plan to make it a full Theme Builder there should be a roadmap/checklist of progress:

[x] Colour themes
[ ] Shape
[ ] Typography

Maybe someone would have built a plugin for M3 Shape and Typography plugins and  it's not happening because this plugin is blocking it with uncertainty.

Hi, we are very limited on what we are able to announce. But you can expect typography theming in the future.


Display temperature data consistently on survey details page

At the moment, satellite temp data is not showing consistently on the survey details page, which should be fixed.
In addition, we would like to display spotter temp data as well, when available.
Here is a good site to take as an example https://aqualink.org/sites/2943 and a survey with no temp value: https://aqualink.org/sites/2943/survey_details/401

@ericboucher Will work on this

Thanks @ak090498 for proposing your help. Please go ahead. Let me know if you have questions.

Unfortunately I am a bit busy and cannot work on this as of now , really sorry


where i can set rectOfInterest property of AVCaptureMetadataOutput

hey i have to scan qrcode in specific frame and that frame is the dashed line layer that you have added, now what can i do?

Hey,
the AVCaptureMetadataOutput is not visible yet but I'll make it available from the QRCodeReader object to allow you to improve the configurability.
Thanks

I just pushed a new version with the metadataOuput property visible so you can update its own properties. :)

Thank you so much for this update @yannickl


Is there any way to apply augmentation to only the bounding box area?

I took a look at writing custom augmenters.
It seems both _augment_images() and _augment_keypoints have access to images and keypoints separately.
So I can't read a keypoint(bounding box) and perform augmentation on the image(let's just say I want to assign gray pixels to the entire bounding box area).
Is there any recommended way to approach this problem?

This is currently a shortcoming of the library. Augmentations where one type of input data (images, heatmaps, segmentation maps, keypoints, bounding boxes, polygons, line strings) requires information of another type are not possible. It is planned to be changed at some point by giving more control to augment(), but right now such augmentations have to be handled outside of the library.

Thanks for the quick response!


Handshake timeout error on SGE cluster

from dask_jobqueue import SGECluster
from dask.distributed import Client, as_completed
import blm_setup, blm_batch, blm_concat, blm_cleanup # my own functions which don't employ dask

# Given a dask distributed client run BLM.
def main(cluster, client):

    # Some generic inputs
    inputs= ... # Function inputs

    # Ask for a node for setup
    cluster.scale(1)

    # Setup does some computation to work out how many jobs to submit
    future_0 = client.submit(blm_setup, inputs, pure=False)
    nb = future_0.result()

    # Ask for 100 workers for next stage of computation
    cluster.scale(100)

    # Empty futures list
    futures = []

    # Run jobs
    for b in (np.arange(nb)+1):

        # Individual job
        future_b = client.submit(blm_batch, b, inputs, pure=False)

        # Append to list
        futures.append(future_b)

    # Completed jobs
    completed = as_completed(futures)

    # Wait for results
    for future_b in completed:
        future_b.result()

    # Ask for 1 node for final stage
    cluster.scale(1)

    # Concatenation job
    future_concat = client.submit(blm_concat, inputs, pure=False)

    # Run concatenation job
    future_concat.result()

    # Run cleanup job
    future_cleanup = client.submit(blm_cleanup, inputs_yml, pure=False)

    # Run cleanup job
    future_cleanup.result()

# If running this function
if __name__ == "__main__":

    # Specify cluster setup
    cluster = SGECluster(cores=1,
                         memory="100GB",
                         queue='short.qc',
                         walltime='00:30:00',
                         extra=['--no-dashboard'],
                         interface="ib0",
                         local_directory='FILEPATH') # I have removed the filepath from the original code here.

    # Connect to cluster
    client = Client(cluster)

    # Run code
    main(cluster, client)

    # Close the client
    client.close()

(Source: https://github.com/TomMaullin/BLM/tree/dask_update)
What happened: I ran the above code (with the FILEPATH replaced appropriately) on the head node of an SGE cluster using python blm_cluster.py & (where blm_cluster contains the above code). First, it gave me 1 worker and the setup computation seemed to run correctly, then it gave me 100 workers and they seemed to run correctly. Finally it went back down to 1 worker. However, at this stage this error appeared in the log for the one remaining worker:
distributed.nanny - INFO -         Start Nanny at: 'tcp://<IP_ADDRESS>:38442'
distributed.worker - INFO -	  Start worker at:   tcp://<IP_ADDRESS>:34295
distributed.worker - INFO -          Listening to:   tcp://<IP_ADDRESS>:34295
distributed.worker - INFO -          dashboard at:         <IP_ADDRESS>:38150
distributed.worker - INFO - Waiting to connect to:   tcp://<IP_ADDRESS>:34386
distributed.worker - INFO - -------------------------------------------------
distributed.worker - INFO -               Threads:                          1
distributed.worker - INFO -                Memory:                  93.13 GiB
distributed.worker - INFO -	  Local Directory: /well/nichols/users/inf852/BLMdask/dask-worker-space/worker-b_q5vip7
distributed.worker - INFO - -------------------------------------------------
distributed.worker - INFO -         Registered to:   tcp://<IP_ADDRESS>:34386
distributed.worker - INFO - -------------------------------------------------
distributed.core - INFO - Starting established connection
tornado.application - ERROR - Exception in callback functools.partial(<bound method IOLoop._discard_future_result of <tornado.platform.asyncio.AsyncIOLoop object at 0x2b87ac5f4450>>, <Task finished coro=$
Traceback (most recent call last):
  File "/users/nichols/inf852/miniconda3/envs/BLM/lib/python3.7/site-packages/distributed/comm/core.py", line 326, in connect
    handshake = await asyncio.wait_for(comm.read(), time_left())
  File "/users/nichols/inf852/miniconda3/envs/BLM/lib/python3.7/asyncio/tasks.py", line 449, in wait_for
    raise futures.TimeoutError()
concurrent.futures._base.TimeoutError

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/users/nichols/inf852/miniconda3/envs/BLM/lib/python3.7/site-packages/tornado/ioloop.py", line 741, in _run_callback
    ret = callback()
  File "/users/nichols/inf852/miniconda3/envs/BLM/lib/python3.7/site-packages/tornado/ioloop.py", line 765, in _discard_future_result
    future.result()
  File "/users/nichols/inf852/miniconda3/envs/BLM/lib/python3.7/site-packages/distributed/worker.py", line 1370, in heartbeat
    raise e
  File "/users/nichols/inf852/miniconda3/envs/BLM/lib/python3.7/site-packages/distributed/worker.py", line 1336, in heartbeat
    for key in self.active_keys
  File "/users/nichols/inf852/miniconda3/envs/BLM/lib/python3.7/site-packages/distributed/utils_comm.py", line 390, in retry_operation
    operation=operation,
  File "/users/nichols/inf852/miniconda3/envs/BLM/lib/python3.7/site-packages/distributed/utils_comm.py", line 370, in retry
    return await coro()
  File "/users/nichols/inf852/miniconda3/envs/BLM/lib/python3.7/site-packages/distributed/core.py", line 902, in send_recv_from_rpc
    comm = await self.pool.connect(self.addr)
  File "/users/nichols/inf852/miniconda3/envs/BLM/lib/python3.7/site-packages/distributed/core.py", line 1072, in connect
    comm = await fut
  File "/users/nichols/inf852/miniconda3/envs/BLM/lib/python3.7/site-packages/distributed/comm/core.py", line 333, in connect
    ) from exc
OSError: Timed out during handshake while connecting to tcp://<IP_ADDRESS>:34386 after 30 s

From this point onwards the final worker doesn't seem to terminate or be doing anything. It says it is running when I do qstat but it doesn't seem to be doing anything.
What you expected to happen: I expected the first worker to run my blm_setup code. Then 100 workers to run my blm_batch code. Then finally one worker should run my blm_concat code which combines files created by the blm_batch code.
Minimal Complete Verifiable Example: I'm not sure how to reduce the above any further.
Environment:

Dask version: dask==2022.2.0, dask-jobqueue==0.7.3
Python version:  3.7.11
Operating System: CentOS Linux 7
Install method (conda, pip, source): pip inside a conda environement

OK, first with @TomMaullin problem:
It is a bit weird that everything is OK with one hundred workers, and it fails when falling back to only one. Are you sure the error is appearing only after the scale down is called? If yes, this might be a problem of future objects still on distributed memory (and rebalancing)? Or maybe the last function call is trying to get some big data to or from the Scheduler, you should try to follow with the Dashboard.
Some other considerations/suggestions:

Do you really need to scale up and down? The pre and post processing functions are long enough for this?
You could also execute these functions on the same process as the Client? And just run with Dask when it's distributed?
Else, I would have use delayed in order to generate this workflow with Dask, but you won't be able to scale manually between steps then.
I'm not sure what you're doing with your future_b.result() ?
local_directory='FILEPATH': this is weird. local_directory should be a temp directory for dask storing things. You should ideally give a compute node local directory (/tmp, or '$TMPDIR').

@desh2608:
Your problem seems much more general: if I understand correctly, on your cluster, Dask workers fail with half of the nodes?
If so, this is either a networking problem, either a Scheduler overloaded problem (how many Dask workers are you launching at the same time? Did you try to increase timeouts?). Do manually submitting a job launching a Dask worker which connects to your Scheduler work on these nodes? Are those always the same nodes that causes issues?

@desh2608:

First, on the workers that are failing, do you see the same error message as @TomMaullin?
On the Scheduler logs, what are you seeing?
This might mean that your workers are slow to start, two points to look at:

On which file system is you Python environment installed? Is it fast?
Do you use the local-directory kwarg to put Workers' local working dir to a local storage like /tmp?

@desh2608 @TomMaullin do you still face your issues? Without more inputs from you in the following weeks, I'm going to close this issue.

Sorry, I switched to using qsub instead since I had deadlines to meet. As far as I can recall, I was seeing the same error as reported by @TomMaullin.

I'm closing the issue since there is no answer from @TomMaullin. Feel free to reopen if you have new experiments to add.

Apologies, I must have missed this response; I am no longer facing this issue as our system changed from SGE to SLURM.


feat(object_lanelet_filter): add configurable margin for object lanel…

object_lanelet_filter
Description
Added configurable margin to object lanelet filter which extends area of non filtered objects.
With margin 3m:

Related links
Parent Issue:
None.

Link

How was this PR tested?
Notes for reviewers
None.
Interface changes
None.

Effects on system behavior
None.

@badai-nguyen @technolojin Could you check this PR? (especially calculation cost)

@sebekx Hi, thank you for your PR!
I timed the processing time by the TimeKeeper.

impl.
larger map
debug
lanelet_extra_margin
avg. processing time

current impl.
-
N/A
N/A
~6.0 ms

this PR
-
false
0.0
~3.8 ms

this PR
-
false
0.1
~12.6 ms

this PR
-
false
0.5
~11.4ms

this PR
-
false
1.0
~10.3 ms

this PR
-
false
3.0
~8.5 ms

this PR
-
true
0.0
~4.4 ms

current impl.
✓
N/A
N/A
~6.5 ms

this PR
✓
false
0.0
~4.0 ms

this PR
✓
false
0.1
~13.6 ms

this PR
✓
false
3.0
~9.2 ms

this PR
-
false
-1.0
~3.9 ms

"larger map" in the table indicates that the same rosbag with a larger map, so the size of the map is the only difference.
debug, lanelet_extra_margin is the parameter in the config file.
The implementation of this PR is faster than the current one when the lanelet_extra_margin is set 0.0 (disable).
(It should be coming from the reduction of the method call)
@sebekx since I am not familiar with the bg::strategy::buffer, do you know what kind of behavior is expected for distance_strategy(<negative value>)? Checking the lanelets with debug=true option in this PR, it seems it does not create the margin for the lanelets.

Also, it would be nice if you create the update PR for the config file in the autoware_launch too!

@sebekx also, could you fix the error in the cppcheck result ?

@sebekx since I am not familiar with the bg::strategy::buffer, do you know what kind of behavior is expected for distance_strategy(<negative value>)? Checking the lanelets with debug=true option in this PR, it seems it does not create the margin for the lanelets.

@a-maumau Hi, thanks for review. Normally it will make polygon smaller but in this implementation there is a condition to only expand polygons in whether there is positive value of extra margin.

Also, it would be nice if you create the update PR for the config file in the autoware_launch too!

there is pr

@sebekx also, could you fix the error in the cppcheck result ?

fixed

Hi, thanks for review. Normally it will make polygon smaller but in this implementation there is a condition to only expand polygons whether there is positive value of extra margin.

Ah, I simply forgot that part, thank you.
I first thought shrinking might have some needs in some cases, but it would make some gaps between the lanelet connections, so this is reasonable.

Also, it would be nice if you create the update PR for the config file in the autoware_launch too!

there is pr

Can you kindly add this link and description to this PR description?

I am going to test its performance.

I measured processing time in 3 different situation
A. Before
B. After with lanelet_extra_margin of 3.0
C. After withlanelet_extra_margin of zero

A: 5ms in low, 10ms of high load
B. 8ms in low, 19ms of high load
C. 3ms in low, 2ms of high load
In conclusion, the performance of the same usage is improved. If the extra margin is added, it causes computational cost (as expected).

@YoshiRi can you confirm this PR?

@sebekx Thank you for your contribution!


ExecuteBatchAsync(TableBatchOperation, CancellationToken) is missing

I'm using WindowsAzure.Storage Nuget package version 9.1.1 https://www.nuget.org/packages/WindowsAzure.Storage/
I can't find the ExecuteBatchAsync(TableBatchOperation, CancellationToken) method there.
Is it removed now?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72f39539-0da7-7b1c-caab-3e3b484f0410
Version Independent ID: 7f9c1154-1bfe-b8e5-c2bb-d5842200f4d8
Content: CloudTable.ExecuteBatchAsync Method (Microsoft.WindowsAzure.Storage.Table)
Content Source: xml/Microsoft.WindowsAzure.Storage.Table/CloudTable.xml
Service: storage
GitHub Login: @erickson-doug
Microsoft Alias: douge

As far as I can tell, the method signature is still valid.
@tamram Do you happen to know if there's been a change there?

This specific overload is not available in the netstandard version of the package. Please use the overload with request options and operation context instead, or target .NET Framework.

Yep sorry, it's a .net core and netstandart. May I use the default constructed objects for request options and operation context or should I specify some values? Are you going to add this note to the doc?

You can pass null for these parameters. We're going to release netstandard 2.0 support soon, which will bring parity with .NET Framework (and the docs).


Code completion failing

I've created a new project with node.d.ts and lib.es6.d.ts using the noLib: true flag in the tsconfig file. I'm using the latest Atom v0.200.0
I import the file like so:
import * as chalk from 'chalk'

If I reload Atom using CTRL+ALT+R completions work only once, then subsequent completions produce odd results as demonstrated below:
After Atom reload

Try second completion

I should note that this is not isolated to Chalk. After the first completion, all subsequent completions will not work for any libraries that I have d.ts files for.

I've had similar issues happen recently. Didn't investigate much. Will do that today :rose:

Sorry that this keeps happening. I thought there was a bug in atom, then found one in my code instead and assumed atom was okay (based on testing), and now found one in atom again. Fixed with v4.5.0. Thanks for your patience :heart:

No problem :smile:
I'm just glad you're able to quickly resolve these.


Alpha dash validation

I trying to make a custom validation to only allow alpha and dashed values, i can't find in way doing that. Any help??

:-1:

Thanks for opening your question on SO.

Sorry, I was so angry because i was king of on a hurry
window.Parsley.addValidator('alphadash', {
	validateString: function(value) {
		return true == (/^[a-z-_]+$/.test(value));
	},
	messages: {
		en: 'Only alphabetic letters, dashes and underscores allowed.'
	}
});

I meant it. Questions on StackOverflow, thanks.


[5th Edition OGL by Roll20] encumbrance doesn't apply modifiers

The character sheet calculates encumbrance if the variant rules are selected. However it doesn't do anything with that information other than show a message. It would be much better if the encumbrance penalties were automatically applied – to speed, ability checks, attack rolls and saving throws that use Dex, Str or Con – as per PHB 176.
Am I just missing something or does this functionality not exist?
Also what could I do to add this functionality in?

I found this thread: https://app.roll20.net/forum/post/6706436/encumbrance-5e-ogl#newtopic
So apparently it doesn't apply the modifications. Why not though? I played PathFinder on Roll20 and the PathFinder character sheet does do this, so obviously it's possible.
How can we make it happen?

So I submitted a PR to fix this: https://github.com/Roll20/roll20-character-sheets/pull/5239

Has this been fixed in some later update? If so, this issue could be closed.

Nope. My PR was denied. Apparently this feature isn't desirable. Really not sure why but there you are.

Closing as this sheet is no longer present in this repository.  If this is still an issue, I would advise raising it in the pertinent forum thread.

What? What's going on? How can D&D 5th edition no longer be in this repository?

All of the 'by Roll20' sheets are hosted in a separate, private repo. Nothing to be alarmed over 🙂


Missing image upload button

Hi,
We really like this widget as it really looks good. We only miss the ability to upload an image via an upload button and browse. See screenshot below. This option is not included. As for now drag & drop will work in FireFox but does not Chrome. In chrome a user is not able to add an image.
If you have any questions feel free to contact me!
Regards,
Michael

Hi @michaelgerritsen, thanks for raising this. The image uploader and a few other features where not included in the current version of this widget, but we shall add it to the backlog for a future release.
Will let you know once it's included.
Kind regards,
Edwin

Any update on when or if image support will be included?

It is not planned at the moment

Hi Andries,
Any change to road map to include image upload?