Add tutorial on integration testing

This PR adds a tutorial on integration testing with launch_testing and complements the two existing tutorials on unit testing. This topic was first discussed in https://github.com/ros2/ros2_documentation/issues/4827 and thereafter on ROS discourse. This is my first PR for the ROS 2 project, all feedback welcome!
Resolves https://github.com/ros2/ros2_documentation/issues/4827 and closes https://github.com/ros2/launch/issues/812.

Is there any reason you chose the unittest framework over the pytest framework?

While I agree with you that it would be nice to also have documentation on the launch_pytest framework, at least the core still heavily uses the unittest framework.  Thus, I'm fine with taking this documentation and then expanding it later to include the pytest one.

@clalancette
Greatly appreciated that you took your time to review thoroughly. One question related to style, I see that a few of your suggestions (for example this one) remove linebreaks and don't change the content, could you briefly elaborate on the reason behind this?
As-is, I wrapped the lines to 80 characters allowing for clean git diffs. This style guide suggest wrapping, but doesn't mention a desired line length for documentation. Is a 100-character limit preferred for documentation?
@Ryanf55

How do you deal with the DDS matching of topics taking longer than expected and causing test failures?

Such things can happen, though I don't immediately see how this relates specifically to testing. The DDS taking too long to match topics can also arise when deployed, in which case it's a bug, and therefore it's desirable that the integration tests point out that part of our system is failing?
@kscottz
Concerning the section on visualizing test output (https://github.com/ros2/ros2_documentation/pull/4881#discussion_r1866471220), shall we make it part of the existing tutorial Running Tests in ROS 2 from the command line? Or do you prefer a short but separate tutorial?

As-is, I wrapped the lines to 80 characters allowing for clean git diffs. This style guide suggest wrapping, but doesn't mention a desired line length for documentation. Is a 100-character limit preferred for documentation?

Good question.  Our style is generally one-sentence-per-line; that allows future diffs to be easier to read.  However, we do allow breaking a single sentence into multiple lines if necessary.  We don't have an exact number for line-length here, but I think 80 characters is too short.  Generally, my feeling is that if a particular sentence is too long to comfortably fit on one line, then usually the sentence is too long (there are exceptions to this, including when we are embedding URLs into the sentence, in which case the written sentence can get very long and we break it up).
I think the best thing to do is look at some of the other tutorials for reference.  While they aren't 100% consistent, that should give you a feeling about what we typically do.

Thanks everyone for their efforts it getting this completed and merged, especially @clalancette! I'm glad I could contribute to the ROS documentation.


Add newline at end of Sonar property file

Sonar scans are failing for no obvious reason; fixing this to see if it helps.

Had a merge issue and resolving it in GH removed the newline. Ugh.


Error when trying to use IPersistedGrantProvider

Question
I created a netcoreapp3.1. I'm trying to implement a custom PersistedGrantStore. I have a readonly property that uses IPersistedGrantProvider interface.
private readonly IPersistedGrantProvider _persistedgrantprovider;
private readonly ILogger<ClientStore> _logger;

public PersistedGrantStore(IPersistedGrantProvider persistedGrantProvider, ILogger<ClientStore> logger)
{
	_persistedgrantprovider = persistedGrantProvider ?? throw new ArgumentNullException(nameof(persistedGrantProvider));
	_logger = logger;
}

public Task<IEnumerable<PersistedGrant>> GetAllAsync(PersistedGrantFilter filter)
{
	var results = _persistedgrantprovider.GetAll(filter.SubjectId);
	_logger.LogDebug("{persistedGrantCount} persisted grants found for {subjectId}", results.Count(), filter.SubjectId);

	return Task.FromResult(results);
}

I'm getting an error whenever I try to call any method from _persistedgrantprovider
The type 'PersistedGrant' is defined in an assembly that is not referenced. You must add a reference to assembly 'IdentityServer4.Storage, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=93d4430489de4ef4'.

I cannot see a type called IPersistedGrantProvider in our code base.

@leastprivilege sorry! I was trying to use an external Nuget package that is linked to an old Identity Server version. Thank you for the response!


Build or no Build

Hello,
The option --no-build seems confusing to me. If I don't use it the command dotnet pack gives me error NU5026 because the project hasn't built yet. So it doesn't seem to build it automatically. And when I use --no-build it explicitly doesn't build the Project...
So I have to build it myself anyway?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7e805a3-f2ec-b05a-d5c8-29f7a8c16a5f
Version Independent ID: 4257ec12-df6f-ec52-aad3-012e5fce8133
Content: dotnet pack command - .NET CLI
Content Source: docs/core/tools/dotnet-pack.md
Product: dotnet-fundamentals
Technology: dotnet-cli
GitHub Login: @tdykstra
Microsoft Alias: tdykstra

@unitrix0 The behavior referred to in https://github.com/nuget/home/issues/6118 is documented in the article after the text that mentions the automatic build:
> [!NOTE]
> In some cases, the implicit build cannot be performed. This can occur when `GeneratePackageOnBuild` is set, to avoid a cyclic dependency between build and pack targets. The build can also fail if there is a locked file or other issue.

@unitrix0 The behavior referred to in https://github.com/nuget/home/issues/6118 is documented in the article after the text that mentions the automatic build:
> [!NOTE]
> In some cases, the implicit build cannot be performed. This can occur when `GeneratePackageOnBuild` is set, to avoid a cyclic dependency between build and pack targets. The build can also fail if there is a locked file or other issue.

Thanks for contacting us. We believe that the question you've raised has been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.

Thanks for contacting us. We believe that the question you've raised has been answered. If you still feel a need to continue the discussion, feel free to reopen it and add your comments.

If you're going to enhance documentation, please also consider enhancing documentation for the DotNetCliTask in Azure Devops (https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-pack). The build pipeline is probably where people start running into this issue.


Add a 'rolling_buffer' scheduling primitive

This pr add a rolling buffer scheduling primitive.
The pr is based on @mbaret pr, and it differs in that the InjectRollingBuffer pass has been rewritten in C++, (originally it was written in Python).
Also since the original pr was written, the TIR changed a bit, and as a consequence, some code has been moved between the visitors' methods.

This is based on #7925 but in C++.
cc : @junrushao1994 @jcf94 @Hzfengsy it would be great if we great if you guys can have another look. TIA

I fixed the CI issues.

@mbaret -- Would you be able to have a look and see if its matching the original implementation we could get this in ? Possibly follow up if and when concerns arises later ?


Can it support misaligned memory access when PBMT=NC?

The Svpbmt mentions misaligned memory access when PBMT=IO.

Implementations may override additional PMAs not explicitly listed in Table 27. For example, to be consistent with the characteristics of a typical I/O region, a misaligned memory access to a page with PBMT=IO might raise an exception, even if the underlying region were main memory and the same access would have succeeded for PBMT=PMA.

But when PBMT = NC, can it support misaligned memory access with PMA=main_mem or PMA=IO?

PBMT= NC or IO is only guaranteed to override the attributes specified in table 27. The following sentence then says "Implementations may override additional PMAs not explicitly listed in Table 27". Note "may".
In the case of PBMT=NC on top of PMA=main memory, one typically would not override the misaligned behavior for main memory since "NC" is intended to represent noncacheable main memory, and hence misaligned accesses would be supported. In the case of PBMT=NC on top of PMA=IO, and similar to the example in the spec, one typically would override the misaligned behavior to be consistent with the characteristics of main memory.

Thank you for your reply. I still have doubts: It is acceptable to report an exception(PBMT=IO) where there is no exception(PMA=main_mem), but if there is no exception(PBMT=NC) in the place where the exception should be reported(PMA=IO), will this affect the correctness?

I wouldn't view it that way.  In each case the PBMT memory type is overriding the memory type implied by the PMAs and is generally intended to be the effective memory type.  So then, from the perspective of the effective memory type, one can then talk about whether misaligned accesses should cause an exception or not (i.e. yes for PBMT=IO and no for PBMT=NC).

I got. Thank you again!


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210803153321448 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210803153321448 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.002%) to 41.536%

Totals

Change from base Build<PHONE_NUMBER>:
-0.002%

Covered Lines:
26115

Relevant Lines:
56987

💛  - Coveralls


Reproject DataTiles

Fixes #13197
Allows reprojection of multiband and raw values GeoTIFF and DataTile sources by reprojecting 3 bytes per pixel in sequence via  raster reprojection until all bytes per pixel have been reprojected, then combining the result in a new DataTile.  A ReprojDataTile class avoids the need for intermediate sources.
https://deploy-preview-13654--ol-site.netlify.app/en/latest/examples/geotiff-reprojection.html
To handle non-parallel projections data for areas outside the source tile grid but inside reprojected tiles with partial coverage of the source grid is returned as zeros, so sources should be configured to include alpha.  Tiles in the reprojection tile grid which are entirely outside the source tile grid have an EMPTY state which is handled by the renderer.
Sources are expected to have the same band count and data type at each zoom level.
A second (and more realistic use case scenario) example is added - displaying two adjacent Sentinel COGs which are in different projections due to being in different UTM zones.
https://deploy-preview-13654--ol-site.netlify.app/en/latest/examples/multiple-cogs.html
Added a static method to determine browser accuracy:
https://deploy-preview-13654--ol-site.netlify.app/en/latest/apidoc/module-ol_source_datatile#.getReprojectCapability
Gecko browsers which might interpolate a reprojection canvas even if imageSmoothingEnabled is false currently account for around 3.2% of browser use https://gs.statcounter.com/browser-market-share#monthly-201708-202208

@tschaub @ahocevar This has now been fully reworked from the original experimental implementation to be a DataTile equivalent of a ReprojTile.  Would anyone like to review it?


[FEATURE] Allow configuring FilePicker source for Image Folders

Is your feature request related to a problem? Please describe.
The "data" source is hardcoded when reading the content of Image Folders.

This makes it difficult to import image folders when your preferred store is in another FilePicker sources, like "s3" or "forgevtt".
Describe the solution you'd like
I'd like to request an additional dropdown field in the module's configuration, to allow you to select between "data", "s3", and "forgevtt", so that the module can then use that source when doing FilePicker operations like the browse or upload.

Describe alternatives you've considered
A text input for a source argument could also work, though the average user may find it more difficult to use. If it is possible to list the sources the FilePicker is configured with, that would be helpful for populating a dropdown.
Additional context
I'm a mod on the Forge Discord and Forge users have an Assets Library which behaves similarly to S3 and uses the "forgevtt" FilePicker source. Users of this module on The Forge may run into issues since file uploads will go to the Assets Library, but the module always looks for the upload in the "data" source.
Other possible alternatives
Forge redirects browse requests to the "forgevtt" source when the browsed path doesn't exist in "data", but this module includes the default upload directory with the zip file, though they only seem to contain a PURPOSE file.
If these directories are not necessary and could instead be created dynamically at import time if they don't already exist (ie. do a browse first, then a create if necessary), then the redirect to the "forgevtt" source can happen successfully without other changes in the module.
Another possibility is to change the default upload paths for these images to use the Persistent Storage folder which Foundry allows modules to use for updates into the module's own user data, which was first included with https://foundryvtt.com/releases/11.292, which will not only mean that subsequent updates of this module for users won't need a re-import, but Forge can also handle the persistent storage folder's contents with special logic to circumvent the issue.

Persistent Storage. Packages may now declare "persistentStorage": true in manifest JSON files, which will treat any data stored within a "storage" subfolder in the package folder as protected. Any data stored in that folder will not be deleted when the package updates. It is important to note here: uninstalling a module with persistentStorage will still remove that persistent data. This mechanism exists solely to persist data through updates.

Thanks for this complete feedback...
I dont know wich solution I ll implement yet.
I have ForgeVtt account so I can test my module on it but I have to create a S3 store to able to test this part.
I which u a Merry Christmas and an Happy New year 🎆🎉

Thanks for this complete feedback... I dont know wich solution I ll implement yet. I have ForgeVtt account so I can test my module on it but I have to create a S3 store to able to test this part. I which u a Merry Christmas and an Happy New year 🎆🎉

Thanks! Merry Christmas and Happy New Year to you too!


Provide information on how to update bonobo

I am currently using 3.4.3 and would like to update to 3.6.
Unfortunately there does not seem to be any directions on how to update.
I'm afraid i might overwrite some existing configuration files.

When you installed 3.4.3 did you install with the basic authentication, or the default forms authentication?
I stopped IIS, did a backup of my Bonbo.Git.Server folder and then just copied the new files over and it upgraded okay.  If you made any changes to the config when you started you will need to make the same changes or run a diff on the configuration file to see if there are any changes.

@jakubgarfield  I think this can be closed now as you have added the information. https://bonobogitserver.com/update/


[TECH DEBT] Break out Mirador into a separate module

Overview of feature request
Mirador functionality is currently bundled in a submodule of Defaults. But there is no reason the code shouldn't be a standalone viewer module like OpenSeadragon.
The only thing that would have to be moved are the configs under config/install that are not setting default values for the options provided for this module itself (contexts, entity view displays, etc) which can go in the Starter Site.
What kind of user is the feature intended for?
Anyone running an islandora site who wants to be able to use Mirador (which can, in theory, do text overlay)
Anyone who wants to be able to run Mirador in Drupal outside of islandora
What existing behavior do you want changed?
Not behaviour but code task - the location of the mirador module .
Any brand new behavior do you want to add to Islandora?
in relation to this, it would be cool to provide instructions to upgrade in case you've already installed Mirador.
Any related open or closed issues to this feature request?

I've added LICENSE and README files to https://github.com/alxp/islandora_mirador. It should be good to move to Islandora organization.
@inikolaidis is there any updated boilerplate I should also add?

@alxp Small changes made to the README in this PR: https://github.com/alxp/islandora_mirador/pull/1

@inikolaidis Thanks! Merged in to my islandora_mirador instance.

Our LSAP (currently being reworked and I dont know of a public facing document - ping @islandora-community), to be accepted by the Foundation as a module, it should have tests and a Github Workflows integration that runs them (as well as code sniffer and codecov).
I also would like to strip out the Feature module that contains configuration specific to islandora, and include it in the Islandora Starter Site. The starter site is now 'launched' though has no versions yet.

Tests are a good idea but since the code itself is already in the Islandora project, just under islandora_defaults, I don't think the LSAP applies in this case so perhaps it's not necessarily a blocker. I will look in to making a test regardless.

Making this available for everyone to improve sounds like the best plan. The repo has been transferred and is at
https://github.com/Islandora/islandora_mirador
Do not close until documentation repo is updated.

Repo needs to be registered with Packagist.
Need to roll a release of Islandora Defaults that doesn't include Mirador.

PR for islandora_defaults without Mirador:
https://github.com/Islandora/islandora_defaults/pull/75

Do not close until documentation repo is updated.

Oops. 😳


Awesome Icons ?

Can Font Awesome be used as icons ?

Currently not, unless you can add them via an img src attribute. I'll look into this as a feature though.

Added in upcoming build


Will the goctl RPC proto command be deprecated in future versions of the goctl tool?

Will the goctl RPC proto command be deprecated in future versions of the goctl tool?
官方确定goctl工具未来版本要废弃goctl rpc proto命令吗?

Yes. Use protoc for later versions.


Can I get the full parameters of robot using bijective mapping m from base parameters.

I can get base parameters by PC_DIDIM method, when I calculate the full parameters of robot using bijective mapping  from base parameters, but it also has , so is there some method to solve this problem? thank you!

Hi MuziYT,
you might be interested in equation (11), page 10 of https://mediatum.ub.tum.de/doc/1638193/document.pdf
Please let me know if this answers your question.

Hi, Quentin Leboutet
Thanks you a lot, I know that full dynamic parameters can be obtained through SDP and a bijective mapping(equation 11), but I would like to ask if your program can directly output full dynamic parameters. If not, I will try to modify it. Thanks you agian.

So far the code only outputs estimates of the base parameter vector Beta. However, all the quantities you need to recompute the standard parameter vector from this estimate should be available. In fact, the standard parameters are used to build the LMI of PC identification routines. Check the buildLMI() function: this might be what you are looking for (line 18).
If you want to know where these different quantities are computed, check the computeIdentificationModel() routine. There, in the baseParametersNumericalSimplification() function you can see that all the quantities of equation 11 involved in the mapping, in particular the permutation matrix P (denoted as Perm), the product of R terms (denoted as K_d) and the vector of unidentifiable parameters (denoted as X_d) are exported as Matlab functions named Regressor_Perm<robot_name>.mat_, Regressor_K_d<robot_name>.mat_ and Regressor_Xhi_d<robot_name>.m_ respectively.

Hi, Quentin Leboutet
Thank you a lot,I will carefully read the code and find the way to obtain the standard parameter vector.


Update linter style package

Updated to 2.1.0 which addresses current trademark guidelines for FoundriesFactory.
QA: Synced Vale and ran against README.md, which worked as intended.
This commit applies to FFTK-3429
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness

[x] Merge (pending reviews)
[ ] Merge after date or event
[ ] Draft

Overview
Why merge this PR? What does it solve?
Checklist

[x] follow best practices for commits.

[x] Descriptive title written in the imperative.
[x] Include brief overview of QA steps taken.
[x] Mention any related issues numbers.
[x] End message with sign off/DCO line (-s, --signoff).
[x] Sign commit with your gpg key (-S, --gpg-sign).
[x] Squash commits if needed.
[ ]

Comments
Maintenance task, does not effect content.

Docs for 819051a9419803de0b97ab1e5dd111d078850d57 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2731/docs/artifacts/html/index.html


TwoArmHandover dataset issue

It seems that the hammer object is missing from the xml file of the dataset. Also, it seems that there are no cubes present in the TwoArmHandover environment from robosuite repo. Is the environment up-to-date? Here are the terminal output when trying to do reset_from_xml_string:
    env.reset_from_xml_string(xml)
  File "/home/yifengz/workspace/robosuite-master/robosuite/environments/base.py", line 504, in reset_from_xml_string
    self.reset()
  File "/home/yifengz/workspace/robosuite-master/robosuite/environments/base.py", line 243, in reset
    self._reset_internal()
  File "/home/yifengz/workspace/robosuite-master/robosuite/environments/manipulation/two_arm_handover.py", line 439, in _reset_internal
    super()._reset_internal()
  File "/home/yifengz/workspace/robosuite-master/robosuite/environments/robot_env.py", line 390, in _reset_internal
    super()._reset_internal()
  File "/home/yifengz/workspace/robosuite-master/robosuite/environments/base.py", line 286, in _reset_internal
    self._setup_references()
  File "/home/yifengz/workspace/robosuite-master/robosuite/environments/manipulation/two_arm_handover.py", line 373, in _setup_references
    self.hammer_body_id = self.sim.model.body_name2id(self.hammer.root_body)
  File "wrappers.pxi", line 1019, in mujoco_py.cymj.PyMjModel.body_name2id
ValueError: No "body" with name hammer_root exists. Available "body" names = ('world', 'table0', 'table1', 'robot0_base', 'robot0_link0', 'robot0_link1', 'robot0_link2', 'robot0_link3', 'robot0_link4', 'robot0_link5', 'robot0_link6', 'robot0_link7', 'robot0_right_hand', 'gripper0_right_gripper', 'gripper0_leftfinger', 'gripper0_finger_joint1_tip', 'gripper0_rightfinger', 'gripper0_finger_joint2_tip', 'mount0_base', 'mount0_controller_box', 'mount0_pedestal_feet', 'mount0_torso', 'mount0_pedestal', 'robot1_base', 'robot1_link0', 'robot1_link1', 'robot1_link2', 'robot1_link3', 'robot1_link4', 'robot1_link5', 'robot1_link6', 'robot1_link7', 'robot1_right_hand', 'gripper1_right_gripper', 'gripper1_leftfinger', 'gripper1_finger_joint1_tip', 'gripper1_rightfinger', 'gripper1_finger_joint2_tip', 'mount1_base', 'mount1_controller_box', 'mount1_pedestal_feet', 'mount1_torso', 'mount1_pedestal', 'payload_root', 'trash_main', 'transport_start_bin_root', 'transport_target_bin_root', 'transport_trash_bin_root', 'transport_start_bin_lid_root').```

Are you on the offline_study branch? To work with the demonstration datasets, you should use that branch as mentioned in the docs.


[MOBS] Add drops when killing mobs

Add drops item when killing mobs

this will happen when it happens.

But I hit it a lot and it didn't drop any items


Have comma interpreted as AND on command parser

Can you please implement the commandParser so that it can accept multiple keywords to use as AND condition?
Example:   "get long,sword" would get the items that have both 'long' and 'sword'.
"kill fire,mage" in a room that has "ice mage, fire mage, fire monster" would get the NPC named "fire mage", and so on.

As part of this issue, can you please also fix it so that it doesn't look for any part of the argument in the name?
Example: Right now look ood will find the "Wooden Chest". Even look t will find the Wooden Chest.
Can we make it so that it only returns if the keywords STARTS with the args?
Examples related to "Wooden Chest"
look o -> Will not find it
look w -> will find it
look wo -> will find it
look c -> will find it
look est -> will not find it

These are both cool fixes/improvements, good call.


add the deserialize of publickey

We need serialize and deserialize to add a publickey in the block structure to be added.

Feel free to merge when it passes the test-suite.

I think the fromBinary method should probably be removed? I don't see it used anywhere, and it looks like it should have been called deserialize.

I think the fromBinary method should probably be removed?

Actually, it's something I wanted to experiment more with. Because deserialize is really problematic: some types make no sense default-initialized (Point), some types could be in an invalid state (invariant failing), etc... So initializing a type straight from binary, be it via a ctor or a specially-named method, is IMO a better road.
I went with a specially-named method because that's where you put the validation (as opposed to constructors).


chore(renovate): remove website configuration

Summary
removes old renovate config for the website

Test Plan

superseded by #2617


Is it possible to develop video label detection?

100%. https://docs.aws.amazon.com/rekognition/latest/dg/labels-detecting-labels-video.html
I'll roadmap this for after I get done with the Azure client. If anyone would like to write a PR for this, I'd be open to it.


Possible to prevent 0 as the first character?

First off, great library! 👌🏼
I am wondering if it is possible to prevent a user from entering 0 as the first number using this library.
I can see in the docs I can make it numeralPositiveOnly like as follows, however this still allows a user to enter 0 as the first character? I have tried adding stripLeadingZeroes: true but this didn't work for me.
new Cleave('.my-input', {
    numeral: true,
    numeralPositiveOnly: true,
    stripLeadingZeroes: true,
    numeralDecimalScale: 0
});

did you find a solution?


Feature: Improve calculator plugin

I was planning to add a couple of improvements to the calculator plugin.

New setting to set the output decimal separator to either dot or comma. Currently, it is fixed to a dot. The current locale can be used as "default" here.
Enable calculation with dot and comma. Currently, only dots are allowed as input value.
Add new settings to set max calculation precision.
Solve rounding errors in a couple of circumstances. (Wox-launcher#2349)

This should also close issue Wox-launcher#2106

@SysC0mp hey buddy, out of curiosity only, have you made any progress with this into a PR?

would be interested too

Hey! 👋 I started implementing it, but i had no time yet to finish it up and test everything. Sorry for the long wait... :)
I'll try to finish that the next couple of days and create a PR for it.

👋 That'll be great. Thx 😄


cargo-nextest: 0.9.14 -> 0.9.16

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Great, thank you! Also, I should probably add some automated package tests, but that'll be for later I guess :)


Improve the date and time input pickers (#68047)

Description
This PR addresses several issues, linked below. It doesn't fully address them all, but its a good start IMO.
I need this functionality in my app, that's why I opened those issues, but since I couldn't wait for the fixes to arrive, I made my own version that suits my needs. I decided to share my code here so those fixes could arrive sooner.
There are some very few things that are opinionated changes, like the inclusion of an IconButton for opening pickers. While I think that should be optional and even exposed through a trailing widget, I decided to include it here so you guys can evaluate if this is worthy or not.
This code is not complete, there are some TODOs spread around the code, pointing out things that aren't fully functioning because flutter still doesn't provide them (in my code I use external libraries like Intl for that).
Related Issues
Fixes #68057
Fixes #68042
#68047
#68048
There are other issues realted to this same subject, but they aren't fixed or partially addressed here, so I didn't include them.
Tests
I added the following tests:
No tests were included as I couldn't find any previous tests for these classes.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

@feinstein Thanks so much for the detailed PR! This gives us a lot of great info on future improvements we can make to the pickers. Sorry it took a while to respond (I did look at this when you filed it, just didn't get a chance to respond until now).
Unfortunately, I restructured the layout of the date picker code to fit more in line with the rest of the flutter tree in #70708. So this specific PR will have problems landing due to merge conflicts.
That said, let me address some of the changes here:

Allowing the InputDatePicker to have no date selected is great and something we should also address in the CalendarDatePicker as well as the showDatePickerDialog (see #638).

Adding the button that brings up the dialog is interesting. It would definitely need to be optional, as the showDatePickerDialog's input date picker dialog uses these fields so having these also bring up a dialog would not be good 😄.

The InputTimePickerFormField looks like a nice addition. We don't really have a Material design for this kind of field (the new Time Picker design has text input, but uses multiple custom fields for this), so I am not sure we would take this directly. It might be a good candidate for a package. Either way, it would be better to have this in its own PR to continue the discussion if you are still interested.

So given all this, I will close this PR as we can't merge it as is. We will however use this as helpful input when addressing the bugs and issues you have raised. Thanks again.

@feinstein Thanks so much for the detailed PR! This gives us a lot of great info on future improvements we can make to the pickers. Sorry it took a while to respond (I did look at this when you filed it, just didn't get a chance to respond until now).
Unfortunately, I restructured the layout of the date picker code to fit more in line with the rest of the flutter tree in #70708. So this specific PR will have problems landing due to merge conflicts.
That said, let me address some of the changes here:

Allowing the InputDatePicker to have no date selected is great and something we should also address in the CalendarDatePicker as well as the showDatePickerDialog (see #638).

Adding the button that brings up the dialog is interesting. It would definitely need to be optional, as the showDatePickerDialog's input date picker dialog uses these fields so having these also bring up a dialog would not be good 😄.

The InputTimePickerFormField looks like a nice addition. We don't really have a Material design for this kind of field (the new Time Picker design has text input, but uses multiple custom fields for this), so I am not sure we would take this directly. It might be a good candidate for a package. Either way, it would be better to have this in its own PR to continue the discussion if you are still interested.

So given all this, I will close this PR as we can't merge it as is. We will however use this as helpful input when addressing the bugs and issues you have raised. Thanks again.

My pleasure @darrenaustin.


Schedule page

Nextjs: Add Schedule, Zoom Class, and Class Price sections' components.

Media query
add style with Grid

Sanity: Add Zoom Class Schema.

 Schedule Page: Add Schedule Page


Added base class for TestDataBuilders

As promised in my Stackexchange question I hereby (ask to) contribute a new Pattern called TestDataBuilder. I think it could be of high use to many library users that have complex data structures that they need to run Apex Integration tests on. I have submitted a pull request to fflib-apex-common includung a TestDataBuilder base class and another pull request to fflib-apex-common-samplecode with sample code showing how to use it.
There is awesome support in the library for Apex unit test. They should be fast and isolated. With ApexMocks both is achieved. But complex code also needs integration tests where code is execute on more complex test data. In the world of Enterprise software outside of Salesforce.com there are experts that have created patterns for flexible and readable (fluent, concise) test data generation.
Among them the most notable is Nat Pryce who wrote a great book about testing and somewhat invented the TestDataBuilder pattern.
Up2Go as a Salesforce.com ISV has products with huge amount of Integration test where each of them needs to build up huge "trees" of related records. Over the year we suffered from our complex and mostly redundant TestHelpers classes where each created the same object slightly different. Whenever we changed the datamodel we had to sync all the Helpers or otherwise tests would magically fail.

By incorporating a single short Builder class for each test-relevant Domain SObject we could centralize all the creation knowledge and eliminating redundancy.
By internally leveraging the 'fflib_SObjectUnitOfWork' for the DML all test run dramatically faster.
The Fluent API style of the Builder pattern combined with having all the database wiring encapsulated in the Unit of work made each test much more understandable.

@up2go-rsoesemann really sorry for not getting to this great work sooner! DF prep is taking its usual toll this time of year on work and personal time. Anyway enough with excuses....
This is a really nice and light helper class and feels like a good addition. I've got some comments on the helper classes it requires but will add those to the other PR. For now this is looking good, please can i ask though that you add some more comments to the top of the class (something like your bullets and a bit of background, links etc to the pattern) and to public methods. Maybe also a short inlined class example in the class comments block?

Also is it possible to add @IsTest for this class?

Playing devil's advocate here -- Why is this pattern only useful in test contexts? We've experimented with various O/R mapping techniques to try to accomplish the same thing in our production code. That is, adding some encapsulation of bare metal SObject manipulation behind a POJO (or POAO in this case). What this pull request provides is more elegant (mostly because of the fluent pattern) than what we had and could be useful for simplifying code in Service methods
The major downside is the immense amount of Apex code that needs to be generated in order to use this with a large schema. Agreed with Andy's comment on the https://github.com/financialforcedev/fflib-apex-common-samplecode/pull/3 about wrapping the implementation classe into an outer class so your project isn't littered with dozens or hundreds of top level unit test helper classes
Lastly, is it intended that initUnitOfWork() gets modified by hand in each org/package? Why not make it virtual and protected so that a local subclass of DomainObjectBuilder can implement its own list of SObjects relevant to that org/package?

@afawcett

I will add a comment to this class pointing to the sample class in the sample repository. Would that be sufficient? I think thats better and more detailed than code comment examples. Ok?! Do I need to generate another pull request or how does this work?

When you add @isTest to this class you also have to add it to all the implementing classes. As they are already perfectly covered (they just exist to make tests run) I see no big use in doing that. Especially as I then am NOT able to use them outside of tests as @daveespo mentions in his comment.

@daveespo

Indeed this could be used outside of tests as a kind of internal API to the packages domain objects. We indeed thought about this ourselves. Even in the for of global interfaces to allow the creation of test data of base package objects in the tests of an extension package.

I love and will incorporate your idea to ask the implementor for a specific UnitOfWork implementation instead of modifiying the existing one. How can I modify and improve an existing Github pull request without loosing our discussion here?

If you commit code to your branch and reference this pull request ("#77") in your commit message, it will automatically get updated

@daveespo while trying to improve the UnitOfWork usage I come to the understanding that users of fflib always adapt the library's own UnitOfWork class. So why should they not do the same when using my (Test)databuilders?
Currently users use my pattern not by implementing a single but many classes that inherit from the abstract class. So which of them should define the UnitOfWork. Switching to what you recommentd would mean to make it more complicated to the user as besides n TestBuilder implementations he would need to provide an extra config-like class.
I'm not sure if that would add any benefit. Especially as users will have to adjust the UnitOfWork class anyway. @afawcett what's your opinion on that?

@up2go-rsoesemann  Hmm, I'm not entirely following what you mean by 'users of fflib adapt the library's own UnitOfWork class'?
We have created subclasses of the fflib_SObjectSelector and fflib_SObjectDomain that contain some common methods that most of our Selectors and Domain classes need -- but we haven't touched the core fflib_XX classes. We don't want to have to tediously merge in upstream changes; instead, we can just deploy the latest version of the fflib classes without modification into our source tree.
As for what I'm envisioning for your test classes:
public virtual class fflib_DomainObjectBuilder {
 ....
  //virtual .. or perhaps abstract?
  virtual fflib_SObjectUnitOfWork initUnitOfWork(){
    throw SomeException("You must implement initUnitOfWork() in your subclass")
  }
}

//Then a local subclass that's relevant to the scope of SObjects that you're going to be implementing in your org
public virtual class MyObjectBuilder extends fflib_DomainObjectBuilder {
  fflib_SObjectUnitOfWork initUnitOfWork(){
    return new fflib_SObjectUnitOfWork(new List<SObjectType> {Opportunity.SObjectType, Contact.SObjectType, OpportunityContactRole.SObjectType});
  }
}

//Then each implementation subclasses from MyObjectBuilder
public class Opportunity_t extends MyObjectBuilder{
  ...
}

I realize that initUnitOfWork is currently declared as static .. but is there a good reason for that? And it doesn't seem like there's a need to instantiate it as part of the static initializer for fflib_DomainObjectBuilder. You could just construct it within the build() method as a local variable that you let get disposed when the method exits.
I'm having a little trouble wrapping my mind around the build() method .. it doesn't feel like it belongs in fflib_DomainObjectBuilder since an instance of fflib_DomainObjectBuilder is representing a single record, yet build() operates on all records of all types. fflib_DomainObjectBuilder is acting as both a collection and a single instance.  But perhaps I'm overthinking that one ..

@daveespo I understand your confusion when looking at the build method. Let me try to explain why it is as it is.
build() does more than inserting on a single domain object. It will bulk-insert (to save DML and care about relationships under the hood) on every DomainObject which is not yet inserted in that (=execution context). Therefore it indeed behaves like a static singleton method.
To make the code more readable and not introduce a hard to understand class method I gave it the object method look it has.

@daveespo I understand your confusion when looking at the build method. Let me try to explain why it is as it is.
build() does more than inserting on a single domain object. It will bulk-insert (to save DML and care about relationships under the hood) on every DomainObject which is not yet inserted in that (=execution context). Therefore it indeed behaves like a static singleton method.
To make the code more readable and not introduce a hard to understand class method I gave it the object method look it has.
To come back to the original question..there is no single point of entry where a test developer could pass in a UnitOfWork. He eighter has to do it in each test (BAD!) or one time per org, by adapting the UnitOfWork class itself.

My point of the "MyObjectBuilder" example above is that by making initUnitOfWork virtual in fflib_DomainObjectBuilder, you don't have to modify fflib_DomainObjectBuilder.cls in every source tree to add the list of SObjects you manipulate. It remains pristine and can track upstream without any messy merges. Are we talking past each other on that point?
As for build() -- I get it -- it's just that it's not really OO to provide an instance method that operates on way more than an instance. I don't think I want to belabor that point though .. the convenience seems to outweigh the religion in this case

Great discussion everyone!  Having something in the base fflib for builder pattern makes a ton of sense.  A few thoughts:

The current implementation builds SObjects with DML.  When it comes to unit tests and mocking, often times the desire is to avoid DML.  Adding in a mechanism to build with or without DML would make the class significantly more valueable.

Agree with @daveespo regarding moving the call to "initUnitOfWork" to the build method itself and to make it virtual.  Similar to what he has done, we have derived classes on the core fflib classes (e.g. Domain) which the "real" classes then derive from.  This avoids having to change core fflib code.  When it comes to the builder class, we would have a intermediate class that overrides initUnitOfWork and then all of our SObject specific builders would derive from our intermediate class.

Regarding the build method itself, the builder pattern is typically patterned against an single instance and building anything necessary for that instance so having build be instance level seems appropriate to me.  With that said, in order to reduce DML as much as possible, possibly build is instance level and persist is static.  This helps with providing a way to create SObjects using DML (lots of stuff via persist) and not using DML (single SObject and its dependencies via build).

I'm currently working on implementing the pattern with the modifications described above.  I'll share to @up2go-rsoesemann repo once I have something consumable.

@jondavis9898 glad that you see a need for (Test)Builder support in this library. I am more than happy to see you improve some of the glitches in the current implementation. I am looking forward to hear and see more.

@up2go-rsoesemann  I submitted PR #100 with my suggestions on enhancements/extensions.  Thank you again for getting the ball rolling on this, look forward to yours (and others) thoughts!

@up2go-rsoesemann Just wanted to drop in and say that i've not forgotten about this, and am pleased to see others chipping in on including this.

@jondavis9898 great work on the PR https://github.com/financialforcedev/fflib-apex-common/pull/100. @up2go-rsoesemann what do you think?
I'm keen to get this live actually, it seems folks see a need for it and although i still share concerns over the amount of code it generates. At the end of the day that is up to the developer and if they see the value then the over head is worth it. And maybe one day we can get Salesforce to generate somethign like this, the way they have now provided support in the platform that avoids the need for generating Apex Mocks mock classes! 👍
So next steps....

@jondavis9898 and @up2go-rsoesemann to agree Jon's PR is good
Given the motivations and discussions here https://github.com/financialforcedev/fflib-apex-common/issues/36 i think its worth creating a plug-in / extension repo that can be layered on optionally to this core library. Something fflib-apex-common-builder ? Would this be ok with everyone? If so, i'll create the repo and Jon you could generate a PR on that.

How this work for everyone?

Thanks @afawcett for giving this a second chance. We regard our internal Builder architecture as a huge success. Our tests are way more readable, faster and nearly no redundancy in test setups.
What Jon has added is HUGE. Thanks for you awesome work. I will need some time to dig into his changes. jondavis9898 is there a TL:DR fast lane to sample code that shows how the builder is used? Maybe a test class that shows all the great new features in action?

Excellent, thanks @up2go-rsoesemann. @jondavis9898 your thoughts?

@jondavis9898 I could answer all of my questions by re-reading all the PRs and comments. Maybe I have a simplicity/readability fetish, but I still think we should do some minor tweaks to the API:

Object Mother pattern is a great idea. But I also want to use a simple constructor:
new Opportunity_t().name('...') instead of Opportunity_t. anOpportunity().name('...')
Having the line fflib_DomainObjectBuilder.persistRegistered(Application.UnitOfWork.newInstance()); in all my test methods is ugly. Can't we instead have a fflib_DomainObjectBuilder.persist() and define the UnitOfWork somewhere else? Maybe in a static block using fflib_DomainObjectBuilder.use(UnitOfWork...)?!
Please keep the library independent from all the fflib interfaces required for ApexMocks. I saw you using the Application class. We don't use them and many other (those that ask for a lighter fflib) don't eighter.

Hello guys - Glad to see this re-surfacing!
Agreed that this should be a separate repo.
@up2go-rsoesemann Addressing your 3 questions/comments:

PR #100 requires that you use "new" to create an instance.  It does not require nor prohibit the use of Object Mother.  Using the Object Mother pattern in a derived builder class is optional.

2 part a) The reasoning behind naming persistRegistered is explained in more detail in the comments to PR #100 (here and  here).  In short, derived builders can expose persist() so that they can return a concrete SObject.  If the base class offered persist(), then derived builders would need another name for "persisting" an instance (and it's related builders).  The base class provides complete flexibility on usage but the most common use case within an actual test is to call the instance level persist() (which persists everything that has been registered).  You can still use persistRegistered static from the base if you choose of course.  Given this flexibility, my goal was to have the names be as similar as possible - hence, persistRegistered(UnitOfWork)/persistBuilder(UnitOfWork)/persist(UnitOfWork, Set) on the base class allowing the derived class to offer persist().  See here for an example.
2 part b) Given the discussion with @daveespo above, my thinking was to move to more instance level methods than statics to provide flexibility, specifically around being able to create builder instances with or without DML (to your question earlier, this is one of the primary differences from your original PR #77 which only provided DML based option).  Additionally, the approach allows for flexibility around which UnitOfWork to use as well as providing default UOWs within a derived builder class instead of having the test itself have to create one.  Having a "use" to me is ambiguous because when is it "used"?  Keeping with the "persist" and "build", the intent/purpose is clearer I believe.

PR #100 has no dependency on ApexMocks or using the Application class concept from fflib.  Please let me know where you see this dependency, possibly I'm overlooking it?

Not sure if you saw but I did submit a PR to MavensMate templates.  If you MM, creating builders is extremely simple.  If you don't use MM, its still rather simple by following the structure outlined in the template or fflib sample repo tests.
Look forward to your thoughts/feedback!

@jondavis9898 Sounds more than ok to me. Thanks for detailing this again.
@afawcett Please go on with making this public as fflib-apex-common-builder.

👍

Done! https://github.com/financialforcedev/fflib-apex-common-builder

Cool.
@jondavis9898 would you mind writing a short Readme.md with a few use cases?
@afawcett will you add the code to the repo? And how should we contribute to it? Via forking or can you make @jondavis9898 and me a collaborator (please also add my collegue @up2go-sschwarz)?

@up2go-rsoesemann Please feel free to produce a PR to start to populate the repo.

Hey guys - Awesome seeing this getting so close!  I'll submit a PR with the code as soon as I can.
@up2go-rsoesemann This was your idea initially so I'll defer to you on the readme, use cases, etc.  Happy to collaborate once you get the initial version going!

@jondavis9898 would you mind getting your code in first so I can play around with it to add a few first code examples done?

Yep, was thinking you'd want the code first, just been swamped and haven't had time to get it uploaded yet.  Will do as soon as I can, sorry for the delay!

Ok @jondavis9898 I created a PR with my old classes so we have a history. I will also add an initial README soon.

@up2go-rsoesemann  @afawcett  Sorry for the delay on getting the PR submitted on this!  I just submitted https://github.com/financialforcedev/fflib-apex-common-builder/pull/2 to the new repo.
@up2go-rsoesemann I updated the README that @afawcett added with some pointers to the sample code and MM templates.  As you update the readme, please be sure to include references to those.  Thanks!

Thanks @jondavis9898


Scroll language switch for Text Extractor

Description of the new feature / enhancement
When the Text Extractor is activated, instead of the user having to click and select the language they want to OCR from the dropdown, just scrolling up or down instantly shows the dropdown and selects the next or previous language that is in the list.
Scenario when this would be used?
For multilingual users that use screen OCR all the time, one default language isn't handy. They need to constantly switch languages from the dropdown which is a bit time consuming, especially on large monitors. A mouse scroll is a very fast solution.
Supporting information
No response

@an-ko-7
Interesting idea.
Feel free to open a PR. Your contribution is welcome. Thank you for your work on this. If you have any further questions you can ask us.


New icon in Big Sur style

Obviously this is not a issue. But it wouldn't hurt to have the Big Sur-style app icon

@mcorbelli is this something you would like to tackle? We have some asset files that I can provide

@mcorbelli is this something you would like to tackle? We have some asset files that I can provide

Sure, I can take a look at it

Let me know if there is still a need

@mcorbelli Yes!

Sorry for the delay.
https://www.dropbox.com/t/iW3F1C7kzMahHNQW
There is a 3D icon that might be a great start.

Sorry for the delay.
https://www.dropbox.com/t/iW3F1C7kzMahHNQW
There is a 3D icon that might be a great start.

ok, I start looking at it in the next few days

@mcorbelli we are getting ready for a 1.0 release. Please let me know if this is still something you might get to it, so we can add it to 1.0


So excited to try this out

I just read through the readme and docs files and I just wanted to say that I'm so excited to try this tool out for personal projects. I've thought for a while that Make has needed a rewrite to soften some of its rough edges, and this project seems to keep the best parts of Make while simplifying and standardizing the parts that have always bothered me.
Thanks for making (or should I say "knitting"?!? 😂 ) this!

Awesome! I hope it's useful for you and let me know if you run into problems!


Implement write barriers in non-portable runtime for Linux

/src/Native/Runtime/amd64/WriteBarriers.s is stubbed out because I really didn't feel like translating WriteBarriers.asm to AT&T assembler.

Implemented in #410


Add Nushell support for data loader

Nushell has good support for CSV, YAML:  https://www.nushell.sh/book/loading_data.html
Is it possible to add .nu - Nushell script (nu) support?
.js - JavaScript (node)
.ts - TypeScript (tsx)
.py - Python (python3)
.R - R (Rscript)
.rs - Rust (rust-script)
.go - Go (go run)
.java — Java (java; requires Java 11+ and [single-file programs](https://openjdk.org/jeps/330))
.jl - Julia (julia)
.php - PHP (php)
.sh - shell script (sh)
.exe - arbitrary executable

You can add any interpreter you like using the interpreters config option.


Add note to README on responsible CI usage.

This is in the hopes of easing folks hitting #763 in getting
to a proper use of CI.

@sjdweb would something like this in the docs have helped you?

Is CI broken?  I'm a little surprised that a readme change broke CI...

Would have helped yes, probably in my case including dep instructions (and go modules I assume when it's production ready).

@srenatus Thanks for the typo checks.  I'm not super strongly opinionated about where this goes... but I suspect a lot of folks are about to have this issue due to recent changes in master which cause things to break if you are being cavalier about your CI.
Do you have other suggestions about how to get the word out?


Accuracy at first few Step

Hi,
The accuracy at the first 300 step is 0.1000 or 0.0500. Is this normal or is there something wrong?
Thank you

have you solved the problem？i got a result just like your‘s.it's normal?

@Tream733 nope, did you leave it to train for a few more iter. Loading the pretrained model seems to work. But I dont understand the logic. It should improve gradually.

@ducminhnguyen i have finished all the 5000 step.but it's result not very good.i will send  the tensorboard picture to your email。i will try to use  some different parameter in my follow work 。will you continue do this work？if you continue，can i talk more to you about this work in the following time？

@Tream733 Yeah, I will continue working on C3D for a while. Thanks in advance for the tensorboard pics. I   think the init function of the training process have problem. With the right param (pretrained) this works very well, but if we train from scratch it does not work?

@ducminhnguyen have you ever solved the problem?I met the same problem,and do you know how to use the pre-trained model?

yeah, I left t over night and the result come out good the next day.

@ducminhnguyen did you train the model from the scratch or by using the pre-trained model provided by hx173149?

I trained from scratch

@geroge-gao your result is 1.000,Why do you think he is not very good，

@FENGShuanglang because the validation accuracy is only 0.023231257

@FENGShuanglang  I have changed it, the model in predict_c3d_ucf101.py is what I trained myself. but it doesn't work.

@geroge-gao mybe you should try reducing the num of training iterations

@FENGShuanglang Actually I train the C3D from scratch，but the accuracy is always 1.0000 .you can see #59

you should trian it use pre-trained model ,it is very hard and no-rubustness if you train the C3D from scratch .why do you train it from scratch?by the way ,i have to go to chifan! see you later

@FENGShuanglang so how do you use the pre-trained model? as I know ,the tensorflow model contains four files:  .meta  , .index , .data and the checkpoint files. The author only provided the .model file. i guess it's Correspondied to the .data file. so I use the .model file to cover the .data file simply. But it still doesn't work.

@FENGShuanglang so how do you use the pre-trained model? as I know ,the tensorflow model contains four files: .meta  .index  .data and the checkpoint files. The author only provided the .model file. i guess it corresponds to the .data file. so I use the .model file to cover the .data file simply. But it still doesn't work.

I did as what you said,but there occurred an error
 ValueError: The specified path: conv3d_deepnetA_sport1m_iter_1900000_TF.model is a file. Please specify only the path prefix to the checkpoint files.
`
you can see #10 ,
as for "use the .model file to cover the .data file simply", actually I first train the C3D from the scratch, when there will be four files in the models foder. then I replace the .data-00000-of-00001 with .model file.

I did as what you said,but there occurred an error
ValueError: The specified path: conv3d_deepnetA_sport1m_iter_1900000_TF.model is a file. Please specify only the path prefix to the checkpoint files.
you can see #10 ,
as for "use the .model file to cover the .data file simply", actually I first train the C3D from the scratch, when there will be four files in the models foder. then I replace the .data-00000-of-00001 with .model file.

You can try to change a pre-training network，for example “sports1m_finetuning_ucf101.model”

I have tried all the three .model files ,but it's still the same, no any change.

I don't know why ,but you can reference https://zhuanlan.zhihu.com/p/35388036 and Ask the blogger about your question,he is my classmate

It seems a normal issue on windows, it you train it on Linux, it won't happen. hope it will help you.


Cannot generateDevice with custom seed

Bug Report
Form
Put an [x] if you meet the condition, else leave [ ].
Requirements

[x] I've searched the Issues
[x] I've read the basic concepts
[x] I'm using the latest version
[x] I've debugged my code using the DEBUG variable.

Platform

I'm using Node.js version v14.15.1
I'm using instagram-private-api version v1.43.3

Description
If I use generateDevice with the username as a seed, I can login successfully. But if use another seed I get IgLoginBadPasswordError. I know it doesn't make any sense 😞, but I tried to simplify my code the most and it keeps happening. I even tried running the session.example.ts code directly, only changing the generateDevice's seed.
Code
This is the only code I have aside from defining username and password variables.
const ig = new IgApiClient();
try {
  ig.state.generateDevice('test');
  await ig.account.login(username, password);
  console.log('login with test seed successful');
} catch (e) {
  console.log('error with test seed:', e);
}
try {
  ig.state.generateDevice(username);
  await ig.account.login(username, password);
  console.log('login with username seed successful');
} catch (e) {
  console.log('error with username seed:', e);
}

Error and Output
With the code above, I first get:
error with test seed: IgLoginBadPasswordError: POST /api/v1/accounts/login/ - 400 Bad Request; The password you entered is incorrect. Please try again.
    at /home/andres/workspace/salesHack/services/ig_chatbot/node_modules/instagram-private-api/dist/repositories/account.repository.js:40:27
    at tryCatcher (/home/andres/workspace/salesHack/services/ig_chatbot/node_modules/bluebird/js/release/util.js:16:23)
    at /home/andres/workspace/salesHack/services/ig_chatbot/node_modules/bluebird/js/release/catch_filter.js:17:41
    at bound (domain.js:430:14)
    at runBound (domain.js:443:12)
    at tryCatcher (/home/andres/workspace/salesHack/services/ig_chatbot/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/andres/workspace/salesHack/services/ig_chatbot/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/home/andres/workspace/salesHack/services/ig_chatbot/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/home/andres/workspace/salesHack/services/ig_chatbot/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/home/andres/workspace/salesHack/services/ig_chatbot/node_modules/bluebird/js/release/promise.js:725:18)
    at _drainQueueStep (/home/andres/workspace/salesHack/services/ig_chatbot/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/home/andres/workspace/salesHack/services/ig_chatbot/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/home/andres/workspace/salesHack/services/ig_chatbot/node_modules/bluebird/js/release/async.js:102:5)
    at Immediate.Async.drainQueues [as _onImmediate] (/home/andres/workspace/salesHack/services/ig_chatbot/node_modules/bluebird/js/release/async.js:15:14)
    at processImmediate (internal/timers.js:461:21)
    at process.topLevelDomainCallback (domain.js:138:15)
    at process.callbackTrampoline (internal/async_hooks.js:127:14)

Then I get:
login with username seed successful

I wouldn't use the seed 'test'. I had issues with a similar "easy" seed.


Running with openvpn

Hey great plugin. Works as it should.
Only problem i am running into: I have an vpn connection to an external vpn with my raspberry pi running. when the vpn connection is enabled then homebridge does not discover any sonos players. when i disable it then it discovers the players and it still works when i reconnect to the vpn server. i tried binding homebridge-zp to the local iop but it did not help. i also added ip routes but still not working. binding and passing the port through iptables did also not help.
any ideas?!

Just so I understand correctly, the Raspberry and the Sonos players are on the same side of the VPN, the Raspberry just acts as VPN server for remote clients (or is a VPN client to a remote VPN server)?  This means that when the VPN is active, the Raspberry has two different IP addresses.
On startup, homebridge-zp retrieves the IP address of the local machine.  When subscribing to the Sonos players to receive state change notifications, homebridge-zp specifies its own IP address in the callback URL.
With help of Murphy, it (or rather the network core of NodeJS) homebridge-zp probably picks the wrong one when the VPN is active.  You can verify that running homebridge -D, see https://github.com/ebaauw/homebridge-zp#troubleshooting.  Because of this, it wouldn't receive any notifications from any Sonos player.  You can force the right IP address in config.json, using the host key, see https://github.com/ebaauw/homebridge-zp#configuration.
Not sure if that's actually the issue you're facing.  Before setting up the subscriptions, homebridge-zp need to discover the Sonos players.  This is done through UPnP.  I haven't seen any issues with this on multi-homed hosts, but I'm not sure there aren't any.  I still use the sonos library for discovery.  If specifying host in config.json doesn't help, could you please run homebridge -D (when the VPN is active) and attach (not: cut/paste) the debug out here, see https://github.com/ebaauw/homebridge-hue#debug-log-file.


Meaningful unit test coverage

We currently have some Jest unit tests, but not every unit testable file has them. If we can get more coverage on our unit tests, especially for components that are interaction heavy. The Quiz component is a good example of a component that could use unit tests (to guard against changing its intended behavior accidentally.)
See this directory for all files that should have unit tests.

The following tests will be removed here
src/components/Course/Course.test.js
src/components/Course/Tags/Tags.test.js
src/components/Courses/Courses.test.js
src/components/Header/Header.test.js
src/components/Header/Menu/Menu.test.js
src/components/Icon/Icon.test.js
src/components/Layout/Layout.test.js
src/components/Page/Page.test.js
src/components/Pagination/Pagination.test.js
src/components/SectionTitle.test.js
src/components/Text/Text.test.js
src/templates/categories-list-template.test.js
src/templates/category-template.test.js
src/templates/course-template.test.js
src/templates/index-template.test.js
src/templates/not-found-template.test.js
src/templates/page-template.test.js
src/templates/quiz-template.test.js
src/templates/tag-template.test.js
src/templates/tags-list-template.test.js

Im going to close this in favor of the more specific issues we now have on the board


Fail to execute select and report incorrect error message

Describe the bug
**dev=> select * from business_custom_mv limit 10;
ERROR:  QueryError: internal error: Storage error: Hummock error: Barrier read is unavailable for now. Likely the cluster is recovering.
But cluster status is healthy.
(base) ➜  sql git:(main) ✗ docker compose ps -a
NAME                IMAGE                                                COMMAND                   SERVICE             CREATED             STATUS                 PORTS
compactor-0         ghcr.io/risingwavelabs/risingwave:nightly-20230828   "/risingwave/bin/ris…"    compactor-0         2 hours ago         Up 2 hours (healthy)   1260/tcp, 6660/tcp
compute-node-0      ghcr.io/risingwavelabs/risingwave:nightly-20230828   "/risingwave/bin/ris…"    compute-node-0      2 hours ago         Up 2 hours (healthy)   1222/tcp, 5688/tcp
connector-node      ghcr.io/risingwavelabs/risingwave:nightly-20230828   "/risingwave/bin/con…"    connector-node      2 hours ago         Up 2 hours             <IP_ADDRESS>:62727->50051/tcp, <IP_ADDRESS>:62728->50052/tcp
etcd-0              quay.io/coreos/etcd:v3.5.7                           "/usr/local/bin/etcd…"    etcd-0              2 hours ago         Up 2 hours (healthy)   2379-2380/tcp, <IP_ADDRESS>:2388-2389->2388-2389/tcp
frontend-node-0     ghcr.io/risingwavelabs/risingwave:nightly-20230828   "/risingwave/bin/ris…"    frontend-node-0     2 hours ago         Up 2 hours (healthy)   <IP_ADDRESS>:4566->4566/tcp
grafana-0           grafana/grafana-oss:latest                           "/run.sh"                 grafana-0           2 hours ago         Up 2 hours (healthy)   3000/tcp, <IP_ADDRESS>:3001->3001/tcp
message_queue       docker.vectorized.io/vectorized/redpanda:latest      "/entrypoint.sh redp…"    message_queue       2 hours ago         Up 2 hours (healthy)   <IP_ADDRESS>:8081->8081/tcp, <IP_ADDRESS>:9092->9092/tcp, <IP_ADDRESS>:9644->9644/tcp, <IP_ADDRESS>:29092->29092/tcp, 8082/tcp
meta-node-0         ghcr.io/risingwavelabs/risingwave:nightly-20230828   "/risingwave/bin/ris…"    meta-node-0         2 hours ago         Up 2 hours (healthy)   1250/tcp, <IP_ADDRESS>:5690-5691->5690-5691/tcp
minio-0             quay.io/minio/minio:latest                           "/bin/sh -c '\nset -e…"   minio-0             2 hours ago         Up 2 hours (healthy)   <IP_ADDRESS>:9301->9301/tcp, 9000/tcp, <IP_ADDRESS>:9400->9400/tcp
prometheus-0        prom/prometheus:latest                               "/bin/prometheus --c…"    prometheus-0        2 hours ago         Up 2 hours (healthy)   9090/tcp, <IP_ADDRESS>:9500->9500/tcp

Error message/log
No response
To Reproduce
Can't reproduce
Expected behavior
No response
How did you deploy RisingWave?
No response
The version of RisingWave
No response
Additional context
No response

ERROR: QueryError: internal error: Storage error: Hummock error: Barrier read is unavailable for now. Likely the cluster is recovering.

This error implies the cluster is under recovery. Some unexpected things (including network jitter, source/sink temporary unavailable, S3 storage issue, etc.) interrupted the streaming and RisingWave is trying to recover from last checkpoint.
If that happens occasionally, you may ignore it. Otherwise, please check the logs from all nodes to find any suspicious events.

Some errors from meta logs(unable to attach full logs since it's too large), seems like caused by network error:

2023-09-04T13:45:16.54064689Z  WARN risingwave_meta::barrier: Failed to complete epoch<PHONE_NUMBER>370688: Rpc error: gRPC error (Internal error): Actor 2028 exit unexpectedly: Executor error: Channel closed: exchange from actor 2029 to actor 2028 closed unexpectedly
backtrace of StreamExecutorError:
0: <risingwave_stream::executor::error::Inner as core::convert::From<risingwave_stream::executor::error::ErrorKind>>::from
at ./risingwave/src/stream/src/executor/error.rs:40:10
1: <T as core::convert::Into>::into
at ./rustc/f0411ffcebcd7f75ac02ed45feb53ffd07b75398/library/core/src/convert/mod.rs:717:9
2: <risingwave_stream::executor::error::StreamExecutorError as core::convert::From<risingwave_stream::executor::error::ErrorKind>>::from
at ./risingwave/src/stream/src/executor/error.rs:143:34
3: <T as core::convert::Into>::into
at ./rustc/f0411ffcebcd7f75ac02ed45feb53ffd07b75398/library/core/src/convert/mod.rs:717:9
4: risingwave_stream::executor::error::StreamExecutorError::channel_closed
at ./risingwave/src/stream/src/executor/error.rs:101:47
5: <risingwave_stream::executor::merge::SelectReceivers as futures_core::stream::Stream>::poll_next
at ./risingwave/src/stream/src/executor/merge.rs:332:49
6: <core::pin::Pin as futures_core::stream::Stream>::poll_next
at ./root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-core-0.3.28/src/stream.rs:120:9
7: futures_util::stream::stream::StreamExt::poll_next_unpin
at ./root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.28/src/stream/stream/mod.rs:1632:9
8: <futures_util::stream::stream::next::Next as core::future::future::Future>::poll
at ./root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.28/src/stream/stream/next.rs:32:21
9: risingwave_stream::executor::merge::MergeExecutor::execute_inner::{{closure}}
at ./risingwave/src/stream/src/executor/merge.rs:122:49
10: <futures_async_stream::try_stream::GenTryStream as futures_core::stream::Stream>::poll_next
at ./root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-async-stream-0.2.7/src/lib.rs:493:33
11: <core::pin::Pin as futures_core::stream::Stream>::poll_next
at ./root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-core-0.3.28/src/stream.rs:120:9
12: <core::pin::Pin as futures_core::stream::Stream>::poll_next
at ./root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-core-0.3.28/src/stream.rs:120:9
13: futures_util::stream::stream::StreamExt::poll_next_unpin
at ./root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-util-0.3.28/src/stream/stream/mod.rs:1632:9
14: <futures_util::stream::stream::next::Next as core::future::future::Future>::poll


build(bytetrack): add missing dependencies

Description

Added Boost and Eigen dependencies to package.xml so that package can be built in isolation.
Tests performed

Building this package in isolation fails unless these dependencies are added.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@manato thanks for the quick review :slightly_smiling_face:


refactor!: create single subnet delegation

Figure out if multiple subnet delegations are actually supported. If not, a breaking change should be implemented to only allow a single delegation instead of a list of delegations.
https://github.com/equinor/terraform-azurerm-network/blob/f59214f99d33a3c46c938d69aad4fe05d414d4a6/variables.tf#L47-L51

When exporting a subnet to JSON, the value of delegations is a list. So seems like it does indeed accept a list. Thus this issue might prove irrelevant.

should we close this issue then ?

I'd prefer to have tested if this assumption is true or not before closing 🙂


Remove "ΟΛΟΓΙΑ" step1 exception

@astathopoulos What do you think about this change?
Initial purpose is to solve #8
cc @greenonion

+1. It seems valid. I haven't touch step1.
Maybe we should check Ntais' paper about this exception. Probably, it was an edge case which ruined his results.


Creating a new multistream target doesn't get reflected in the dashboard

Creating a new multistream target doesn't get reflected in the dashboard, just looks like this:

A couple questions:

Was the problem that the dashboard didn't update automatically when you created the target, or that even after refreshing the page it still did not show up?
If the latter, how exactly did you create a multistream target? Did you PATCH a stream with a new target or did you just POST a new /multistream/target and then PATCH the stream (if you did PATCH it eventually)?

Was the problem that the dashboard didn't update automatically when you created the target, or that even after refreshing the page it still did not show up?

Good question. If it was the latter, it was probably replication lag. Don't remember, sorry — filed this one quickly while I was screen sharing.

I think this issue was fixed since I already added the function that can't add multistream targets while a stream is active
@iameli


Trigger for first or last business day of month

I would like to be able to set a monthly trigger for the first business day or last business day of a month. So, not a trigger that runs on any Saturday or Sunday. I played with monthly triggers for first day of month, but they do run sometimes in the weekend.
I dont' think this is possible with current functionality, correct?

I can't think of a way to do that other than calculate it externally and then create a specific TimeTrigger for each month.

Thank you for your prompt reply!
For now I work around this by running on the first or last day of the month and set the option "run task as soon as possible after a scheduled start is missed" (TaskDefinition.Settings.StartWhenAvailable = True).


Add --interval flag to podman wait

Waiting uses a lot of CPU, so drop back to checking once/second
and allow user to pass in the interval.
Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

need to update the varlink side of things too

@rhatdan Looks like lint errors?

@baude I think I updated the Varlink stuff.

bot, retest this please

@rh-atomic-bot r+

@rh-atomic-bot retry

@rh-atomic-bot retry

Rootless and single-registry search flaking
@rh-atomic-bot retry

@rh-atomic-bot retry

Another exit 1 after tests finished successfully
Alright, I'm done waiting, hitting it manually


Whoops.... my bad

Coverage remained the same at 100.0% when pulling 87fd42da61567756b4859e5d1887f299489a86c0 on mattjmorrison:strict into 2f819e0573fd0ca95cd92b0a26ee47a7a32cd401 on JarrodCTaylor:master.


Auto match columns

Discussed in https://github.com/konnco/filament-import/discussions/36

Originally posted by Frameck October  5, 2022
It would be nice to add the ability to choose whether the import should automatically match the columns to the values, because if you have a lot of columns it takes a long time to manually associate them each time.
So if Auto match columns is true the form with selects doesn't appear and it matches automatically based on the name of the columns.
Something like this:

That would be ideal

Hi @Frameck @tonypartridge, the feature has been added on 1.2.6. thanks for your feedback guys :)

Amazing!

Hi @frankyso, first of all thank you for this feature, much appreciated.
I've tried the import on the users table with the file below but it doesn't prepopulate the name column
Test import.xlsx

Have you update the package?

yes i ran composer update Upgrading konnco/filament-import (1.2.4 => 1.2.6)

for the header name, the column must match the intended database field.
Or please share the ListPage code let me check the package again

this is the code i have on the ListPage
ImportAction::make()
    ->fields([
        ImportField::make('name'),
        ImportField::make('email'),
        ImportField::make('password'),
    ])
    ->mutateBeforeCreate(function ($row) {
        $row['password'] = Hash::make($row['password']);

        return $row;
    }),

is this 'auto match' feature already completed? using version v1.6.0 now and I don't see the option to select 'auto match' in the matching screen.

It would be nice if this feature was a method that was supposed to return the map of columns so you could configure it.


Component is waiting for optional inputs (if there are more than 3)

Getting stuck when I declared three optional inputs in the prompt template. The weird thing: The same script worked when only supplying two inputs in the prompt (= leaving out the error_message )
Error message:
DEBUG:canals.pipeline.pipeline:> Queue at step 1: {'prompt_builder': ['query']}
DEBUG:canals.pipeline.pipeline:Component 'prompt_builder' is waiting. Missing inputs: {'error_message'}
Traceback (most recent call last):
  File "/home/mp/deepset/dev/haystack/debug/loops_v2.py", line 81, in <module>
    result = pipeline.run({
             ^^^^^^^^^^^^^^
  File "/home/mp/deepset/dev/haystack/venv/lib/python3.11/site-packages/canals/pipeline/pipeline.py", line 459, in run
    raise PipelineRuntimeError(
canals.errors.PipelineRuntimeError: 'prompt_builder' is stuck waiting for input, but there are no other components to run. This is likely a Canals bug. Open an issue at https://github.com/deepset-ai/canals.

Script to reproduce:
import json
import os

from haystack.preview import Pipeline, Document
from haystack.preview.document_stores import MemoryDocumentStore
from haystack.preview.components.retrievers import MemoryBM25Retriever
from haystack.preview.components.generators.openai.gpt35 import GPT35Generator
from haystack.preview.components.builders.answer_builder import AnswerBuilder
from haystack.preview.components.builders.prompt_builder import PromptBuilder
import random
from haystack.preview import component
from typing import Optional, List

import logging

logging.basicConfig()
logging.getLogger().setLevel(logging.DEBUG)

@component
class OutputParser():

    @component.output_types(valid=List[str], invalid=Optional[List[str]], error_message=Optional[str])
    def run(
            self,
            replies: List[str]):
        # create a corrupt json with 50% probability (for demo purposes)
        if random.randint(0, 100) < 50:
            replies[0] = "Corrupt Key" + replies[0]
        try:
            json.loads(replies[0])
            print(f"Valid LLM output: {replies[0]}")
            return {"valid": replies, "invalid": None, "error_message": None}
        except ValueError as e:
            print(f"Invalid LLM output: {replies[0]}, error: {e}")
            return {"valid": None, "invalid": replies, "error_message": str(e)}

#TODO let's eventually get rid of this component
@component
class FinalResult():

    @component.output_types(replies=List[str])
    def run(
            self,
            replies: List[str]):
        return {"replies": replies}

query  = ("Create a json file of the 3 biggest cities in the wolrld with the following fields: name, country, and population. "
          "None of the fields must be empty.")

prompt_template = """
 {{query}}
  {% if replies %}
    We already got the following output: {{replies}}
    However, this doesn't comply with the format requirements from above.
    Correct the output and try again. Just return the corrected output wihtout any extra explanations.
  {% endif %}
  {% if error_message %}
     Error message: {{error_message}}
  {% endif %}
"""

pipeline = Pipeline(max_loops_allowed=5)
pipeline.add_component(instance=PromptBuilder(template=prompt_template), name="prompt_builder")
pipeline.add_component(instance=GPT35Generator(api_key=os.environ.get("OPENAI_API_KEY")), name="llm")

pipeline.add_component(instance=OutputParser(), name="output_parser")
pipeline.add_component(instance=FinalResult(), name="final_result")

pipeline.connect("prompt_builder", "llm")
pipeline.connect("llm", "output_parser")
pipeline.connect("output_parser.invalid", "prompt_builder.replies")
pipeline.connect("output_parser.error_message", "prompt_builder.error_message")

pipeline.connect("output_parser.valid", "final_result.replies")

## Run the Pipeline
query = (
    "Create a json file of the 3 biggest cities in the world with the following fields: name, country, and population. None of the fields must be empty.")
result = pipeline.run({
    "prompt_builder": {"query": query}
})

print(result)

Note: Does work with the canals FSM

Tested and working on https://github.com/deepset-ai/canals/pull/148.
This code's graph:

test/pipeline/integration/test_looping_pipeline::test_pipeline_direct_io_loop:

This pipeline runs as expected on https://github.com/deepset-ai/canals/pull/148
Graph:


Update debug-modern-pages.md

Category

[x] Content fix

What's in this Pull Request?
Updated "Debug SharePoint Framework solutions on modern SharePoint pages" article with few small fixes.

Docs Build status updates of commit a464ce6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/debug-modern-pages.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 810a1e6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/debug-modern-pages.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


RFC: Provide a string for the 'statusline' similar to ale or fugitive

The plugins ale and fugitive provide following functions which return a string suitable for the 'statusline' of vim

fugitive: %{fugitive#statusline()}
ale %{ALEGetStatusLine()}

Would you consider adding a similar function to dein.vim?
IMHO it should return the number of outdated plugins and the total number of plugins managed by dein.vim. Most importantly it should not trigger anything since the statusline is updated quite often. It should only return internal variables of dein which should be defined by dein#check_install() dein#check_update(). A user has to call it manually or add it to startup or an event (possibly triggered after certain periods of time).

I don't want to add the feature.
To implement it is not no cost.

I am not sure what you mean by

To implement it is not no cost.

Are you refering to your personal development time or that this might have an impact on the redraw of the status line.
You've already implemented the function dein#check_update(). I was expecting that this has the purpose to report if updates are availabe
							*dein#check_update()*
dein#check_update([{plugins}])
		Check the plugins update.
		{plugins} is the plugins name list to check.
		If you omit it, dein will check all plugins update.
		Note: If you are using neovim or Vim 8.0+, it runs
		asynchronously.

So counting the number of plugins which could be updated does not sound too complicated and costly. This could easily be saved in a global variable.
I would add this myself but I do not understand your code in this respect. I have searched autoload/install.vim for the term 'check_update' to see where I could count outdated plugins.
Apparently, you invoke a 'get_fetch_remote_command' instead of a sync. Most promising looks like adding this counter to s:check_output(context, process):
    call s:log(s:get_plugin_message(plugin, num, max, 'Updated'))
    let g:dein_outdated += 1

If you send the PR, I will check the implementation.
But I don't want to add the API.


Kicad

Motivation for this change
Modifies the kicad update script to use gitlab and updates kicad-unstable.
Things done
kicad-unstable now requires gtk3 as a build input to compile. I've also reformatted the files to have one parameter per line and one build input per line.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

There's a trailing space in update.sh. Other eval error has nothing to do with you.

@doronbehar trailing whitespace should now be fixed.

@GrahamcOfBorg eval

@ofborg eval

@ofborg eval


Add helper methods to StackFrame

SpongeAPI | SpongeCommon

Is this to simplify code?

Yes. See https://github.com/SpongePowered/SpongeCommon/pull/1531 for example usages.


Update delegate.md

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: https://harness.atlassian.net/browse/CDS-100509
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://66d0116e84e3b9a07366b71d--harness-developer.netlify.app


functional condense() method

Right now condense() relies on a server's state indirectly as a global. Could there instead be a method for a tern server to dump its current state and context would take that as an argument, so that it would be possible to implement something like condense() (like #470) without being within the tern package?

I think you are confusing the 'dynamic' variable infer.cx() with a global. You can run condense in the context of any server using infer.withContext. It would even be possible to create a plugin that defines a new query type to dump the server's current definitions for a given set of origins.


Fix tscn not listed as Resource extension

Fixes #7278
Other resource loaders use similar code.
I don't know why PackedScene is literally the only resource type that doesn't accept .tres, but I left it as it was.
EDIT:
But .res is available. Something is weird here.

Thanks!

Cherry-picked for 3.5.


How do you specify "<C-v>" as a key in Lua?

Hi there,
Apologies for the question that is not quite lightline.vim-specific. I can't seem to figure out the syntax for specifying a mode_map in Lua for the \<C-v> key.
I've tried "<C-v>", "\<C-v>" (an invalid Lua string), "\\<C-v>", and "\22" (which is what you get from vim.api.nvim_replace_termcodes("<C-v>", true, true, true)). None of them work; I can't override the default V-BLOCK string.
Has anyone else run into this? Thanks.

"\22" works for me.

Sorry for necro-bumping, but I've encountered this issue too. @mitchellwrosen, or anybody else, you need to put the string in square brackets like this:
mode_map = {
    ["\22"] = "V-BLOCK"
}


Tabs webdriver tests timeout

Issue Description
Tabs seems to be frequently timeout out during wdio tests. Need to look into this and figure out a fix for the timeout issue.

Is there any consistencies on where they are timing out?

No consistencies, but talking with you and @JakeLaCombe, it sounds like we've found the LOC causing the issue.
Need to update Terra.should.matchScreenshot({ viewports }); to Terra.should.matchScreenshot();
Jake has this fix in his react 16 PR.


Bump ordered-float to v1.1.1 in v0.0.x due to potential UB

As per RUSTSEC-2020-0082, version 1.1.1 of the ordered-float dependency fixes a potential cause of UB.
This doesn't appear to affect the master branch, but it does affect v0.0.x versions.

CI fails seem to be related to the version of rust (1.36) not having support for some features, and not due to the change?

Yeah, I think that either MSRV for v0.0.x branch is set improperly or one of the dependencies just bumped MSRV causing this issue; it needs to be investigated additionally.
Do you have any plans to switch to heim = "0.1" eventually? Current beta is pretty much stable already and next one beta will be promoted to stable release soon.
Upgrading will effectively solve your issue here :)

In addition: I just checked and heim is not doing any calculations with NotNan (this one file is the only place where it is used), so I seriously doubt we can hit UB here.

We're on v0.1.0-beta.3 and still seeing the issue.
error[A001]: ordered_float:NotNan may contain NaN after panic in assignment operators
    ┌─ /home/james/src/vector/Cargo.lock:346:1
    │
346 │ ordered-float 1.0.2 registry+https://github.com/rust-lang/crates.io-index
    │ ------------------------------------------------------------------------- security vulnerability detected
    │
    = ID: RUSTSEC-2020-0082
    = Advisory: https://rustsec.org/advisories/RUSTSEC-2020-0082
    = After using an assignment operators such as `NotNan::add_assign`, `NotNan::mul_assign`, etc., it was possible for the resulting `NotNan` value to contain a `NaN`.  This could cause undefined behavior in safe code, because the safe `NotNan::cmp` method contains internal unsafe code that assumes the value is never `NaN`.  (It could also cause undefined behavior in third-party unsafe code that makes the same assumption, as well as logic errors in safe code.)

      This was mitigated starting in version 0.4.0, by panicking if the assigned value is NaN.  However, in affected versions from 0.4.0 onward, code that uses the `NotNan` value during unwinding, or that continues after catching the panic, could still observe the invalid value and trigger undefined behavior.

      The flaw is fully corrected in versions 1.1.1 and 2.0.1, by ensuring that the assignment operators panic without modifying the operand, if the result would be `NaN`.
    = Announcement: https://github.com/reem/rust-ordered-float/pull/71
    = Solution: Upgrade to >=1.1.1, <2.0.0 OR >=2.0.1
    = ordered-float v1.0.2
      └── heim-process v0.1.1-beta.3
          └── heim v0.1.0-beta.3
              └── vector v0.12.0

@jamtur01 yes, ordered-float crate for v0.1.x were already updated in 8240de547049424f015d249b0ecf04182fc31bb4 and will be published together with #289 soon, so it should'nt be a problem for you and other users of newer versions.
My main question if it is worth to backport this change to older versions, it might be easier for @ClementTsang to upgrade?

@svartalf Didn't realize the current beta was pretty much stable; if that's the case I'll probably just give upgrading a try instead.
I'll close the PR then.


Form validation in flask-login auth example?

In flask-login auth example, when is validate_login used? Shouldn't it be validate?

Ok, got it: it is validate_.


Remove the use of username+password when using GitHub API

Description
The GitHub API have deprecated the authentication through Username+Password, as such it would make sense to only allow the use of a Token.
Reference: https://developer.github.com/v3/auth/#via-username-and-password
Expected Behavior
Using the password argument no longer work.
Actual Behavior
Allows the use of passwords as authentication, with a warning.
Possible Fix
Remove the password argument.
With the removal of password login, this will be a breaking change.

We should maybe start considering to implement this now.
GitHub will drop support for username+password on 2020-11-13, so we should probably have the ability removed before then:
https://github.blog/2020-07-30-token-authentication-requirements-for-api-and-git-operations/


Ability to create data snapshots

Description:
As a EuroPDX member, I would like to have a PDX Finder snapshot to see what data is in the database.
Jira ticket PDXI-844
Acceptance criteria:

[x] snapshot with original diagnosis created
[x] snapshot with harmonised diagnosis created

This ticket was completed with #182


request: deterministic key generation in --develop mode

I love the automatic key generation for testing, so I don't have to think about it.
but it would be nice if they were repeatable, so my agents have the same address every time I run an experiment.
I already have a MNEMONIC= in my .env which could be a nice way to let a user determine their own random (but repeatable) sequence of keys, with the option of being different across experiments or users. and maybe in its absence, a random mnemonic could be generated, from which to sample?

I like this example:
https://github.com/ethereum/eth-account/blob/6a7faa22c1c433422186bf792f870e4c04d59a08/eth_account/account.py#L117

generating multiple public keys from 1 mnemonic!
https://github.com/ethereum/eth-account/blob/6a7faa22c1c433422186bf792f870e4c04d59a08/eth_account/account.py#L300C1-L310C45

Coupled with #816

The new agent0 flow supports assigning private keys, so you can deterministically generate them in your runner script. We also don't have --develop mode anymore.


AWS doesn't support Appium with Serenity BDD & Gradle configuration?

Hi,
I have seen AWS is supporting the below
Test Type Configuration

Appium JUnit
Appium TestNG
Built-in: Explorer
Built-in: Fuzz
Calabash

but I'm not sure exactly supporting below

Appium- Junit With Serenity BDD & Gradle

If it does support under which type I should use the configuration from the list above.
Let me know, please?
Thanks
Vamc

Hi
Thanks for reaching out. Here is a blog post on how u can run Appium Junit BDD with Device farm
https://aws.amazon.com/blogs/mobile/testing-mobile-apps-with-cucumber-and-appium-through-testng-on-aws-device-farm/

Hi Anurag,
Thanks for replying... We are using serenity BDD with gradle, not with TestNG and TestNG uses pom.xml where gradle uses build.gradle so I can't use the link above I'm afraid.
Thanks
Vamc

https://stackoverflow.com/a/52398377/8016330


"First sample not idr frame" error when decoding VP9-encoded mp4 files in Chrome

Hello,
I've encountered an issue when using WebAV to decode and display an MP4 file encoded with VP9. The console logs the following error:
First sample not idr frame

This issue occurs both in my project and in the official demo found at this link: WebAV Video Decode Demo.
Steps to Reproduce:

Navigate to the WebAV video decoding demo.
Select the bear.mp4 file.
Attempt to play the file.
Observe the console error in Chrome.

Environment:

Chrome Version: 129.0.6668.103
File format: MP4 encoded with VP9

Expected Behavior:
The file should decode and play without errors.
Actual Behavior:
The file does not play correctly, and the console logs the error: First sample not idr frame.
I noticed there might be a related pull request (#301), but after manually building from that branch and testing it, I encountered the same error.
Has anyone been able to get VP9 video working successfully? Any guidance would be greatly appreciated!
Thank you!

I must have made a mistake building PR #301. When I copied the library into my project imported directly from the unbuilt ./src/av-cliper/src/clips/mp4-clip.ts it now works as expected.

Fixed in v0.16.4