Web - Reimbursements - There is no offline indicator message on 'Reimbursements' page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.57-2
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal team
Action Performed:

Create a workspace
Appy offline mode
Navigate to 'Reimbursements' page of the workspace

Expected Result:
'You appear to be offline.' should be displayed at the bottom of the page
Actual Result:
'You appear to be offline.' is not displayed at the bottom of the page
Workaround:
n/a
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/4248c3f1-c0fb-4fb6-935e-d1545a300b2c
View all open jobs on GitHub

Proposal
Please re-state the problem that we are trying to solve in this issue.
Offline indicator is not visible on widescreen Reimbursements page when offline,
What is the root cause of that problem?
A defaultModalContainer style is not being passed to ScreenWrapper.
https://github.com/Expensify/App/blob/69a2849f163640021e3248eda536d2db112cb153/src/pages/workspace/WorkspacePageWithSections.tsx#L157-L163
What changes do you think we should make in order to solve the problem?

Passing defaultModalContainer style to ScreenWrapper like in here:
https://github.com/Expensify/App/blob/69a2849f163640021e3248eda536d2db112cb153/src/pages/workspace/WorkspaceMembersPage.tsx#L543-L548
What alternative solutions did you explore? (Optional)

cc @ruben-rebelo as you worked on that PR

IMO we don't need to block the deploy on this though.

@danieldoglas I think @Ollyws needs to review the regression fix PR. I can review in case they are not available.

This one is done, closing it.


Add a sort command

Add a sort command that can list the persons in alphabetical order.

hi @ericsssan, do follow the instructions to submit your pull requests.

@ericsssan please create a pull request indicating for the corresponding tutorial activity.
it is nice to see you getting used to the work flow creating a bug before implementing a feature! but at this moment it is unnecessary.
closing the issue


Publish-PSResource flatten folder and file structure

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.

Steps to reproduce
Publish-PSResource -Credential $Cred -Repository $Repo -Path $Path
$Path contains file tree but publish flatten it in nupkg
The problem triangled in #704
https://github.com/PowerShell/PowerShellGet/commit/270d57e7d86bb49735f35ee172b33050ad193e8b#diff-56bf43952db65da3734ae9fabbe720248ec3a4d18d87ee94ec8ce2b91bce4af1
line  354-359 vs 400-402
- var fileName = fileNamePath.Substring(_path.Length).Trim(_PathSeparators);
- var newFilePath = System.IO.Path.Combine(outputDir, fileName);
+ FileInfo fileInfo = new FileInfo(fileNamePath);
+ var newFilePath = System.IO.Path.Combine(outputDir, fileInfo.Name);

new one does not respect relative file path, only file name
Expected behavior
folder/file structure preserved
module.psd1
file1.ps1
public/
  file2.ps1
private/
  file3.ps1

Actual behavior
public/
private/
module.psd1
file1.ps1
file2.ps1
file3.ps1

Error details
No response
Environment data
Version    Name
-------    ----
3.0.17     PowerShellGet

Name                           Value
----                           -----
PSVersion                      7.2.6
PSEdition                      Core
GitCommitId                    7.2.6
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

btw, v2 by default skip hidden files/folder such as .git , v3 is not

@MVKozlov thanks for opening this issue!  We'll try to get this fix in for our next release.

@alerickson, I hope skipping hidden files will be done too

I also see this behavior.  It breaks publishing PowerShellGet because our own module expects binaries to be in a subdirectory (netstandard2.0), so after publishing then installation, the PowerShellGet module does not work.

@alerickson
To skip hidden directories and files I would use a strategy like this

Check attributes and don't create hidden directories
When adding files, check for the existence of the destination directory (and file attributes, of course, too)

@MVKozlov I'm going to close this issue because the original issue (in title) is resolved.  Feel free to open a new issue regarding skipping hidden directories and we can continue that conversation.  Thanks!


code cleanup: Simplify virtctl VM command files

What this PR does / why we need it:
As a follow up to #9183, simplified the nested if/else logic in the Stop and Restart command. Also moved the  code block for setting the dryRunOption to a common helper function and made dryRunOption a global variable as it used in multiple different commands.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/sig code-quality

@EdDev I checked and there were indeed cases in that block of code that weren't being covered by unit tests. I've added some in.

/cc @acardace

@EdDev @acardace I've made a small update to this PR, would you be able to take a look? Thanks in advance.

@prnaraya , it looks like you changes something but also rebased in the same push.
This makes it very hard to identify what you changed and requires a full re-review.
If you have a diff link showing what you changed from the last lgtm, please share it.
It will help the reviewers if you do not rebase and change in a single push, but do these in separate steps (e.g. change push, rebase push).

Seems that this is the change: https://github.com/kubevirt/kubevirt/compare/ed2546cd6b975b734a8c9a0863c5a952dd7b2d4a..e9d1a3c12b9c447c4889ecaa8101f2e7c9b1e832#diff-e284c5fce546e3ad989c61af6278fbd8a619993d966d8d1925c3ac0fac12f37c
I hope I did not miss anything else.
/lgtm


tables won't work security

Reported by AHaumer on 7 Feb 2008 16:48 UTC
model Test
  annotation (uses(Modelica(version="3.0")));
  Modelica.Blocks.Sources.CombiTimeTable combiTimeTable(table=[0,0; 1,1],
    extrapolation=Modelica.Blocks.Types.Extrapolation.Periodic)
    annotation (Placement(transformation(extent={{-20,0},{0,20}})));
end Test;

Dymola's reply:
dsmodel.obj : error LNK2019: unresolved external symbol _ModelicaTables_CombiTimeTable_init referenced in function _Modelica_Blocks_Sources_CombiTimeTable_tableTimeInit_M
dsmodel.obj : error LNK2019: unresolved external symbol _ModelicaTables_CombiTimeTable_interpolate referenced in function _Modelica_Blocks_Sources_CombiTimeTable_tableTimeIpo_M
dsmodel.obj : error LNK2019: unresolved external symbol _ModelicaTables_CombiTimeTable_maximumTime referenced in function _Modelica_Blocks_Sources_CombiTimeTable_tableTimeTmax_M
dsmodel.obj : error LNK2019: unresolved external symbol _ModelicaTables_CombiTimeTable_minimumTime referenced in function _Modelica_Blocks_Sources_CombiTimeTable_tableTimeTmin_M
dymosim.exe : fatal error LNK1120: 4 unresolved externals
Error generating Dymosim.

Migrated-From: https://trac.modelica.org/Modelica/ticket/46

Comment by otter on 7 Feb 2008 19:00 UTC
See my email to Modelica_Design from Jan. 27, 12:31 where this problem is described and a temporary work-around given.

Modified by otter on 16 Mar 2008 16:13 UTC

Modified by ahaumer on 20 Dec 2016 16:46 UTC

Changelog removed by ahaumer on 20 Dec 2016 16:46 UTC


Map Atlases Incompatibility

According to your testing, does the issue occur with ONLY Immersive Portals mod installed?
No
Forge Version
43.2.0
ImmersivePortals Version
2.3.1-SNAPSHOT-2-mc1.19.2
Latest Log
https://gist.github.com/PotionSeeker/8dd39da070614afc6cfdb5e0c973e2ef
Crash Report (if applicable)
https://gist.github.com/PotionSeeker/eccfa4ad8abb946d668319caaf2f9a0d
Steps to Reproduce

Start a new world
Either create an Atlas or spawn one in via creative mode
Place the atlas in the hotbar

What You Expected
Having a map atlas on the hotbar should open up a minimap in the top left corner and right clicking should open up a larger map.
This is what it should look like:

What Happened Instead
When an atlas is placed on the hotbar, the game crashes.
Additional Details
No response
Please Read and Confirm The Following

[X] I have confirmed this bug can be replicated without the use of Optifine.
[X] I have confirmed the details provided in this report are concise as possible and does not contained vague information (ie. Versions are properly recorded, answers to questions are clear).
[ ] I have confirmed this does not happen on the fabric version (If it does please report to here instead).
[X] I have confirmed I'm not using a hybrid server (Magma, Cauldron) or a different (non official) Forge Server release.
[X] I have confirmed this issue is unique and has not been reported already.

ImmPtl has a mechanism of wrapping packet as redirected packet (in MixinServerGamePacketListenerImpl_E). This issue may be related to that.

So for the time being it's more like a fundamental incompatibility than a bug. That's a shame.

https://github.com/iPortalTeam/ImmersivePortalsMod/issues/1140


Estimation for 4247 (Helm Chart)

This is a placeholder, please breakdown and re-estimate.

I have fully working helm charts that I'm working with the upstream helm community with.
https://github.com/kubernetes/charts/pull/3383

[ ]  use external postgres database chart for clair
[ ]   use external percona / percona-xtradb-cluster chart for database
[ ]   build a image for just the .sql and migration scripts for database that can be used to set up external database as a kubernetes job.

Track Notary support in https://github.com/vmware/harbor/issues/4394

Use external postgres database chart for Clair https://github.com/vmware/harbor/pull/4389/ is merged.


[Amplify Gen2] please add a custom sender lambda trigger as a defineAuth's attribute

Environment information
System:
  OS: Windows 11 10.0.22631
  CPU: (22) x64 Intel(R) Core(TM) Ultra 7 155H
  Memory: 11.66 GB / 31.53 GB
Binaries:
  Node: 20.11.0 - C:\Program Files\nodejs\node.EXE
  Yarn: 1.22.21 - ~\AppData\Roaming\npm\yarn.CMD
  npm: 10.8.0 - ~\WebstormProjects\amplify-next-pages-template\node_modules\.bin\npm.CMD
  pnpm: undefined - undefined
NPM Packages:
  @aws-amplify/backend: 1.0.2
  @aws-amplify/backend-cli: 1.0.3
  aws-amplify: 6.2.0
  aws-cdk: 2.140.0
  aws-cdk-lib: 2.140.0
  typescript: 5.4.5
AWS environment variables:
  AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
  AWS_SDK_LOAD_CONFIG = 1
  AWS_STS_REGIONAL_ENDPOINTS = regional
No CDK environment variables

Description
these values are the defineAuth method's option attributes.
triggers?: Partial<Record<'createAuthChallenge' | 'customMessage' | 'defineAuthChallenge' | 'postAuthentication' | 'postConfirmation' | 'preAuthentication' | 'preSignUp' | 'preTokenGeneration' | 'userMigration' | 'verifyAuthChallengeResponse', ConstructFactory<...>>> | undefined

there is no custom sender lambda value.
To reach that requirement, i had to custom the userPool on a phase of amplify backend cdk.
The sample code is here.
// backend.ts
const backend = defineBackend({
  sendVerificationCodeFunction,
  auth,
  data,
  storage
})

const { cfnUserPool } = backend.auth.resources.cfnResources
const existedSendVerificationCodeFunction = backend.sendVerificationCodeFunction.resources.lambda
existedSendVerificationCodeFunction.grantInvoke(
  new aws_iam.ServicePrincipal('cognito-idp.amazonaws.com')
)
const key = aws_kms.Key.fromKeyArn(
  cfnUserPool,
  `${KeyId}`,
  `${KeyArn}`
)
key.grantDecrypt(existedSendVerificationCodeFunction)

cfnUserPool.addPropertyOverride('LambdaConfig', {
  CustomSMSSender: {
    LambdaArn: existedSendVerificationCodeFunction.functionArn,
    LambdaVersion: 'V1_0'
  },
  KMSKeyID: key.keyArn
})

and this is the function's handler code
// handler.ts
export const handler = async (event: CustomSMSSenderTriggerEvent) => {
  try {
    const { decrypt } = buildClient(CommitmentPolicy.REQUIRE_ENCRYPT_ALLOW_DECRYPT)
    const generatorKeyId: string = `${KeyAlias}`
    const keyIds: string[] = [`${KeyArn}`]

    const keyringInput: KmsKeyringNodeInput = { generatorKeyId, keyIds }
    const keyring = new KmsKeyringNode(keyringInput)

    const request = parseEvent(event)
    console.log('Request:', JSON.stringify(request, null, 2))

    let plainTextCode: string | undefined
    if (request.code) {
      const { plaintext, messageHeader } = await decrypt(keyring, b64.toByteArray(request.code))
      plainTextCode = plaintext.toString('utf-8')
    }

    // do something with that plainTextCode

    return {
      statusCode: 200,
      headers: {
        'Access-Control-Allow-Origin': '*',
        'Access-Control-Allow-Headers': '*'
      },
      body: JSON.stringify({ success: true })
    }
  } catch (error) {
    console.error('Error sending message:', error)
    return {
      statusCode: 500,
      headers: {
        'Access-Control-Allow-Origin': '*',
        'Access-Control-Allow-Headers': '*'
      },
      body: JSON.stringify({ success: false })
    }
  }
}

I hope the amplify backend supply this feature officially

I was looking into contributing this feature into the repo and I saw #2087 merged yesterday, so I would like to figure some things out before diving deeper if that's okay.
The feature introduced this new type:
export type CustomEmailSender = {
     handler: IFunction;
     kmsKeyArn?: string;
 };

If I want to implement CustomSmsSender using the same strategy as CustomEmailSender, it would have the same fields(a handler and a KMS key) but CloudFormation expects the KMS key to be inside the LambdaConfig, not a specific sender.
My question is, should we have two KMS keys or the current structure needs to be refactored in order to also have CustomSmsSender trigger?
Thanks for any information

I also find it a bit confusing that CustomEmailSender is to be defined in senders:{} instead of triggers:{} since this and CustomSmsSender are lambda triggers and defined as such in all the documentation in AWS

@jamilsaadeh97
Thank you for raising this point! After reviewing the current structure and CloudFormation's requirements, I believe refactoring the KMS key configuration to reside at the LambdaConfig level would be a more scalable and maintainable solution. Here's my reasoning:
Why refactor to a shared kmsKeyArn in LambdaConfig?

Alignment with CloudFormation:

CloudFormation already expects the kmsKeyArn to be part of the LambdaConfig, not specific to each sender. By following this convention, we can avoid potential misconfigurations and ensure compatibility with CloudFormation's structure.

Simplified Configuration:

A shared KMS key in LambdaConfig reduces redundancy and makes it easier to manage configurations. This is especially beneficial if the key is meant to serve both CustomEmailSender and CustomSmsSender use cases.

Flexibility for Future Extensions:

By placing the kmsKeyArn in LambdaConfig, we create a centralized configuration point. If new senders or triggers are added in the future, they can reuse the same structure without additional changes.

Proposed Changes:

Refactor the current structure so that the kmsKeyArn is moved from CustomEmailSender to LambdaConfig.
Update CustomSmsSender to follow the same pattern, utilizing the shared kmsKeyArn from LambdaConfig.

Example:
Here’s an example of how the updated types might look:
export type LambdaConfig = {
    handler: IFunction;
    kmsKeyArn?: string; // Shared KMS key for all senders
};

export type CustomEmailSender = {
    handler: IFunction;
};

export type CustomSmsSender = {
    handler: IFunction;
};

@ggj0418 , thank you for the detailed proposal. I agree that it's an ideal way to handle both custom sms and email.
However, the challenge is that it will be a braking change and we can't do this refactor until we are ready to ship a Major version of the library. Until then I see us supporting this feature with
export type CustomEmailSender = {
    handler: IFunction;
    kmsKeyArn?: string;
};

export type CustomSmsSender = {
    handler: IFunction;
    kmsKeyArn?: string;
};

And validate and fail if the kmsKeyArn provided in both custom senders are different, nudging customers to use the same key. @josefaidt thoughts?


camera error

In front and back camera show this
L730

I have the Same problem :c

Same error here on lumia 640 XL

Same here on my lumia 830

Me to in lumia 1020


Add option parsing to ronin-install.sh

We'll probably need real option parsing for additional configuration options.

Implemented in fc9edc4eb12c0173b50cd4da2cda1202ae4d4233.


MI100 produces incorrect results in Stable Diffusion inference

It is quite straightforward to get inference for stable diffusion running on the MI100 (just like any other AMD GPU I suppose).
Using the rocm/pytorch container with ROCM 5.2 installed on the host machine and replacing the conda dependencies in the SD environment.yaml with the official pytorch build (torch torchvision from --extra-index-url https://download.pytorch.org/whl/rocm5.1.1) is enough to get it it running.
However, during inference a warning is thrown:
MIOpen(HIP): Warning [SQLiteBase] Missing system database file: gfx90878.kdb Performance may degrade. Please follow instructions to install: https://github.com/ROCmSoftwarePlatform/MIOpen#installing-miopen-kernels-package
Which, I believe, is to be expected as described here, but not yet fixed:

https://github.com/ROCmSoftwarePlatform/MIOpen/issues/1391
https://github.com/ROCmSoftwarePlatform/MIOpen/issues/1709
https://github.com/ROCmSoftwarePlatform/MIOpen/issues/1606

However, what I found concerning is that not the performance in terms of speed, but accuracy. The example code from the SD repository ( python scripts/txt2img.py --prompt "a photograph of an astronaut riding a horse" --plms ) should always output the same image. When running with our MI100 however, we receive an incorrect display of the image (see attachment)
.
According to my understanding, the worse perforamance due to missing .kdb should however, only affect accuracy(?).
So most importantly: What other things could cause this problem of receiving low quality (incorrect) outputs? How can I fix this behavior and make the MI100 display 'correct' images?
Edit: I have added a log of a run creating the image with MIOPEN_LOG_LEVEL=6.
stable-diffusion-inference.log

I am closing this, as I realized during further testing that the reason for this seems to be that PyTorch uses too low precision when using autocast. If one specifies --precision full images of the same quality can be obtained. Maybe this helps some people as it bseems to be somewhat of a trap (since non-AMD GPUs produce high quality images without setting preicion manually).


CLI: Output resource usage and measured execution cost

@graydon pointed out that with https://github.com/stellar/rs-stellar-contract-env/pull/164 we can use this fn to get the resources used and output them after an invocation:
host.modify_budget(|budget| ... read fields from budget ...)

and
budget.cpu_insns.get_count()
budget.mem_bytes.get_count()

You can now use host.get_budget(|budget| ...) and there's a new function budget.get_input(CostType) that lets you get the input values to the cost-model functions. For example budget.get_input(CostType::WasmInsnExec) will return the number of WASM instructions executed, which is not the input to the cost-model function for WASM instructions that bumps the cpu_insns count. You probably want to report both, along with a microseconds-of-real-time number, to users.


Update CONTRIBUTING.md to highlight python syntax

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.72%. Comparing base (1de846f) to head (46709ae).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   59.33%   58.72%   -0.61%
==========================================
  Files          83       89       +6
  Lines        2850     2973     +123
==========================================
+ Hits         1691     1746      +55
- Misses       1159     1227      +68

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

thanks @danielmlow , i guess this got solved by some previous PRs. still, appreciated your contribution


Assertion Error happens eventually and crashes the server

Hi.
Thanks for the module, it helped me a lot in a feature that I'm developing in my product.
A thing that've noticing is that sometimes when the response.statusCode isn't 200 the nodeJS crashes at an exception:
assert.js:93
throw new assert.AssertionError({
    ^

AssertionError: true == false
at IncomingMessage. (http.js:1341:9)
at IncomingMessage.emit (events.js:61:17)
at HTTPParser.onMessageComplete (http.js:133:23)
at Socket.ondata (http.js:1231:22)
at Socket._onReadable (net.js:683:27)
at IOWatcher.onReadable [as callback] (net.js:177:10)
Does anyone knows why this happens? Is there a way to catch that exception avoiding the server to crash?
Thanks a lot
Thiago

Is this a duplicate of #38?


Add missing 'range' support for @ApiParam's allowableValues

Range is documented as follows:
   *
To set a range of values, start the value with "range", and surrounding by square
   * brackets include the minimum and maximum values. For example: {@code range[1, 5]}.

   *
To set a minimum/maximum value, use the same format for range but use "infinity"
   * or "-infinity" as the second value. For example, {@code range[1, infinity]} means the
   * minimum allowable value of this parameter is 1.

The range[10, -infinity] definition looks to be confusing.
I would suggest to allow "-infinity" as a first agrument.
The code contains a test mock for range definition:
@ApiParam(value = "sample param data", required = true, allowableValues = "range[0,10]")
@DefaultValue("5")
@PathParam("id") String id

Internal class for string parameters defines holders for minimum and maximum length. Do we have to convert range values into length constraints?

That may be a mistake in the documentation. What I'd suggest you do is try to check out one of the older tags, (1.3.0 for example, or even earlier) and check in the tests and samples if there's any usage of -infinity and how it is used. We don't want to change the behavior, so we need to see how it used to work in the past. There may be an example of it in the current samples/tests that you can check. If you find the documentation is wrong, you can fix that as well.
The range will not affect the length validation of a string, but the value. That specific test may not make sense. Try to check the range in the samples and how it is applied there.

The parameter object has minimum and maximum fields
(from the spec: https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md#parameterObject)
It seems doesn't support in current implementation. Example from the PathParameter class:
@JsonPropertyOrder({ "name", "in", "description", "required", "type", "items", "collectionFormat", "default"})
public class PathParameter extends AbstractParameter implements SerializableParameter {;
  protected String type;
  protected String format;
  protected String collectionFormat;
  protected Property items;
  protected List<String> _enum;

  @JsonProperty("default")
  protected String defaultValue;

And if a parameter type is "array" then parameter object has "items" with minimum and maximum fields
(from the spec: https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md#itemsObject)
So, if a parameter type is a scalar, then we use minimum/maximum fields in parameter object.
And if a parameter type is an array, then we use minimum/maximum fields in "items" field.
It's correct?

Looks right, though you may want to take into account the other validation constraints that can be applied to parameters as well (exclusiveMinimum/Maximum, min/maxLength and so on). If you look at the Property objects, you'll see that they have some sort of structure that supports it. You may want to look into a fuller solution.

Fixed in develop_2.0.


e2e tests are flaky

Hit this a few times over the past few weeks. Finally got around to opening an issue for it after hitting it again. A couple examples:

https://github.com/neondatabase/autoscaling/actions/runs/9372090123/job/25802975106#step:13:858
https://github.com/neondatabase/autoscaling/actions/runs/9373078189/job/25807554041#step:13:866

Seems like in general the issue is that the VM has Phase=Running and RestartCount=0 after the pod has been killed.
At first I thought it might be a race between when the controller updates the VM after restarting and when kuttl checks... but it seems like the issue is actually that it's still that way 30 seconds later?

@sharnoff @Omrigan Please have a look if this is still an issue.

Spotted a restart-counted failure here, unfortunately: https://github.com/neondatabase/autoscaling/actions/runs/12561721477/job/35021173344?pr=1163#step:15:1088


Clean up and discuss how each node drawn looks like and see if changes need to be made in the future

I would say this clean up and discussion in discord lasted about an hour as well. The discussion centered around not being able to access the force data and we figured out we were using the wrong geometry file and that's why the node numbers weren't matching up. Now that we figured this out, we should be able to fix it relatively easy.


make build error

What did you do?
make build prometheus error!
What did you expect to see?
No response
What did you see instead? Under which circumstances?
success
System information
centos7
Prometheus version
go 1.18.8
prometheus v2.40.5

Prometheus configuration file
No response
Alertmanager version
No response
Alertmanager configuration file
No response
Logs
up to date in 46s

233 packages are looking for funding
  run `npm fund` for details
cd web/ui && CI="" npm run build

> build
> bash build_ui.sh --all

build lezer-promql

><EMAIL_ADDRESS>build
> bash ./build.sh

+ npx lezer-generator src/promql.grammar -o src/parser
Wrote src/parser.js and src/parser.terms.js
+ cat src/parser.terms.js
+ bash ./generate-types.sh
+ mkdir -p ./dist
+ indexFile=./dist/index.d.ts
+ [[ -f ./dist/index.d.ts ]]
+ rm ./dist/index.d.ts
+ cat
++ sed -E 's/ = [0-9]+/: number/' src/parser.terms.js
+ rollup -c

./src/parser.js → ./dist/index.cjs, ./dist/index.es.js...
created ./dist/index.cjs, ./dist/index.es.js in 43ms
build codemirror-promql

><EMAIL_ADDRESS>build
> npm run build:lib

><EMAIL_ADDRESS>build:lib
> bash ./build.sh

+ tsc --module esnext --target es2018 --outDir dist/esm
+ tsc --module commonjs --target es5 --outDir dist/cjs --downlevelIteration
build react-app

><EMAIL_ADDRESS>build
> react-scripts build

Creating an optimized production build...
Failed to compile.

Module not found: Error: Can't resolve './tokens.js' in 'D:\gopro\gopath\src\prometheus\web\ui\module\lezer-promql\dist'

npm ERR! Lifecycle script `build` failed with error:
npm ERR! Error: command failed
npm ERR!   in workspace<EMAIL_ADDRESS>npm ERR!   at location: D:\gopro\gopath\src\prometheus\web\ui\react-app
Makefile:54: recipe for target 'ui-build' failed
make: *** [ui-build] Error 1

Could you try building within WSL?


log file errors

undefined2019-09-22 10:27:26.544 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:26.544 - error: discovergy.0 Send this information to developer : manufacturerId : ESY
2019-09-22 10:27:26.544 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:26.544 - error: discovergy.0 Send this information to developer : fullSerialNumber :
2019-09-22 10:27:26.545 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:26.545 - error: discovergy.0 Send this information to developer : loadProfileType : SLP
2019-09-22 10:27:29.577 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:29.578 - error: discovergy.0 Send this information to developer : manufacturerId : ESY
2019-09-22 10:27:29.578 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:29.578 - error: discovergy.0 Send this information to developer : fullSerialNumber :
2019-09-22 10:27:29.578 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:29.578 - error: discovergy.0 Send this information to developer : loadProfileType : SLP
2019-09-22 10:27:32.548 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:32.548 - error: discovergy.0 Send this information to developer : manufacturerId : ESY
2019-09-22 10:27:32.548 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:32.548 - error: discovergy.0 Send this information to developer : fullSerialNumber :
2019-09-22 10:27:32.548 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:32.548 - error: discovergy.0 Send this information to developer : loadProfileType : SLP
2019-09-22 10:27:35.584 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:35.584 - error: discovergy.0 Send this information to developer : manufacturerId : ESY
2019-09-22 10:27:35.584 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:35.585 - error: discovergy.0 Send this information to developer : fullSerialNumber :
2019-09-22 10:27:35.585 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:35.585 - error: discovergy.0 Send this information to developer : loadProfileType : SLP
2019-09-22 10:27:37.551 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:37.552 - error: discovergy.0 Send this information to developer : manufacturerId : ESY
2019-09-22 10:27:37.552 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:37.552 - error: discovergy.0 Send this information to developer : fullSerialNumber :
2019-09-22 10:27:37.552 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:37.552 - error: discovergy.0 Send this information to developer : loadProfileType : SLP
2019-09-22 10:27:38.587 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:38.588 - error: discovergy.0 Send this information to developer : manufacturerId : ESY
2019-09-22 10:27:38.588 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:38.588 - error: discovergy.0 Send this information to developer : fullSerialNumber :
2019-09-22 10:27:38.588 - error: discovergy.0 Information received from Discovergy which is not yet part of this adapter
2019-09-22 10:27:38.589 - error: discovergy.0 Send this information to developer : loadProfileType : SLP

Habe auch diese Fehlermdungen...

discovergy.0
2019-09-23 23:38:26.533
error
Send this information to developer : loadProfileType : SLP

discovergy.0
2019-09-23 23:38:26.532
error
Information received from Discovergy which is not yet part of this adapter

discovergy.0
2019-09-23 23:38:26.532
error
Send this information to developer : fullSerialNumber : 1ESY1161229817

discovergy.0
2019-09-23 23:38:26.532
error
Information received from Discovergy which is not yet part of this adapter

discovergy.0
2019-09-23 23:38:26.532
error
Send this information to developer : manufacturerId : ESY

discovergy.0
2019-09-23 23:38:26.531
error
Information received from Discovergy which is not yet part of this adapter

discovergy.0
2019-09-23 23:37:56.527
error
Send this information to developer : loadProfileType : SLP

discovergy.0
2019-09-23 23:37:56.527
error
Information received from Discovergy which is not yet part of this adapter

discovergy.0
2019-09-23 23:37:56.527
error
Send this information to developer : fullSerialNumber : 1ESY1161229817

discovergy.0
2019-09-23 23:37:56.527
error
Information received from Discovergy which is not yet part of this adapter

discovergy.0
2019-09-23 23:37:56.527
error
Send this information to developer : manufacturerId : ESY

discovergy.0
2019-09-23 23:37:56.526
error
Information received from Discovergy which is not yet part of this adapter

alpha of new version release, beta will be available soon for everyone https://github.com/iobroker-community-adapters/ioBroker.discovergy/commit/3b6aaf01c39b520a9470a99b3de60f30069bf9df


Fixed insert error detection and passing

mongodb-core doesn't pass an error object in certain cases, such as on duplicate key errors.  This change checks the result's writeErrors property and, if it's populated, passes the first error back.
This should fix #235 and #197.

:+1:


Fix link for bun

The linked issue was closed as a duplicate of https://github.com/oven-sh/bun/issues/1678 so i updated the link
i also moved the dot after the link because in (at least my terminal, using konsole and zsh) clicking on the link would take one to .../issues/696. instead of .../issues/696 which didn't work

Thank you!


Reimagine routing

While writing test for routing, I faced with some fundamental blockers.
We should rethink principles and syntax for torn's routing.

version 1:
route = Routing()

route.add('/', Controller)
route.add('/users/{userId}', Controller).args({ 'userId': '[0-9]+' })

and to handle methods, one needs to define corresponding methods in their controller
class Controller(torn.api.Controller):
    def get(self):
        self.return('hello world')

and if requested method is not defined, the app will throw TornMethodNotAllowed

While writing test for routing, I faced with some fundamental blockers.

I remember facing the same. Let's see if can come up with something new. Any new ideas? 🎊

I am trying to come up with an implementation for above mentioned version, will create draft in a while
@invinciblycool your inputs are appreciated


cannot customize templates/model/model.stub

Getting a very odd error when I try to customize model.stub
I have been successful in making customizations to many other stubs by publishing the templates and then deleting the ones I don't need to customize and only keeping the stubs that have customizations. All of this works fine. Except it doesn't work for the model.stub
To give you an idea... just the existence of the ORIGINAL UNMODIFIED model.stub file will cause
php artisan infyom:model MyModel -n --fromTable --tableName=myTable
to horribly fail. It produces a MyModel.php like this:
<?php

namespace App\Models;

use Eloquent as Model;
use Illuminate\Database\Eloquent\SoftDeletes;

<?php

namespace App\Models;

use Eloquent as Model;
$SOFT_DELETE_IMPORT$
$DOCS$
class MyModel extends Model
{
$SOFT_DELETE$
    public $table = 'myTable';

    const CREATED_AT = 'created_at';
    const UPDATED_AT = 'updated_at';

$SOFT_DELETE_DATES$

    public $fillable = [
        'description'
    ];

    /**
     * The attributes that should be casted to native types.
     *
     * @var array
     */
    protected $casts = [
        'id' => 'integer',
        'description' => 'string'
    ];

    /**
     * Validation rules
     *
     * @var array
     */
    public static $rules = [

    ];

}

class MyModel extends Model
{
    use SoftDeletes;

    public $table = 'myTable';

    const CREATED_AT = 'created_at';
    const UPDATED_AT = 'updated_at';

    protected $dates = ['deleted_at'];

    public $fillable = [
        'description',
    ];

    /**
     * The attributes that should be casted to native types.
     *
     * @var array
     */
    protected $casts = [
        'id' => 'integer',
        'description' => 'string'
    ];

    /**
     * Validation rules
     *
     * @var array
     */
    public static $rules = [

    ];

}

If I made a modification to the model.stub inside the vendor folder however all is fine.
So why is this happening? Why does the presence of the unmodified original model.stub file inside my published templates folder cause this to happen? Maybe because I am obliged to include other stubs in the published templates folder even though they are unmodified?
I thought this might be the case so I performed this test with a completely unaltered published templates folder (no modifications whatsoever after infyom.publish:templates
And the same error occurs if I try to generate a new model

It would seem that $DOCS$ on the model is calling it's self, removing this is a simple solution, just use you doc block in the file instead.

I tested it with the latest code and it works fine.


[Feature-Request] Unlock items from visited shops

I'd love a feature where when I opened an NPC shop it would unlock the items in that shop for purchase on the GE. That appears to have been a feature (or possibly bug) in Sethrem's original Bronzeman plugin, one which seems to no longer exist in this version.

Hey there! Yes, I believe that was the case in Sethrem's version, but I either thought it was a bug, or didn't like it myself.
I would be more than happy to make it a toggle-able feature though!
This does a raise a few questions though:
First up, I don't think I can detect whether an item is 'default stock', or whether some other player sold a bunch of that item to the store.
Secondly, would you expect only the items to be unlocked that are in stock, or should the items that are at 0 available be unlocked too? Again, I don't think I can detect whether this item never has stock, or whether a player recently cleared the store out.

Hey, sorry, just saw that you responded! Thanks!
First, I think it'd be fine to just unlock whatever is in the shop. While this would be an easy feature to abuse, frankly, if someone wanted to bypass the plugin they could just turn it off.
Second, I can't bring to mind any shops that have an item in them at zero stock. Is there anything like that?
I'd be happy with it just unlocking anything that was visible in the shop. The main thing that prompted this for me was gaining the ability to purchase the dragon longsword, but wanting to purchase it at the GE price of 40k rather than the shop price of 100k. Of course, I just solved that by toggling the plugin off for a moment, but there are plenty of other times this would come in useful.

Hello again! Don't apologize for a 'late' response! Because mine is even later :P
Regarding your answer, I think that might be do-able, but I'll have to look into it. If I find it either way, you will hear so!


Trying to make shiny app and fixed a data typo

Found a small typo in site_code for a couple sites, fixed and re ran code to get cleaned file up to date and corrected.
Have new dataset from Tim and will re release corrected dataset when that data are ready.
Shiny app development starting. Make a basic app where you can select sites, dates and parameter you want to plot. You can also download the dataset you select (Need to make a function where you can download the whole dataset from Zenodo rather than this)
Runs just fine on my local computer but I get the following error when I try to deploy it to shiny: https://sam-struthers001.shinyapps.io/CPF_study_data_tester/
An error has occurred
The application failed to start.
exit status 1

Hey @SamStruthers, can I help at all with review here? Looks like you fixed the deployment issue. Let me know if I can help get this merged to main.

Updated data from new push from RMRS lab (20230925). Updated filenames and paths in readme/ 01_clean script so cleaned file is up to date. Finalized demo.R, which now works and shows how to download the folder from zenodo directly in R.
Fixed the shiny app so it runs now. @steeleb, should this shiny app be moved to another repo so that it doesn't mess with zenodo pub?

Heya @SamStruthers - the app looks GREAT! Can I request that the y axis adds the units for the parameters?
And yes, I think the original idea was that this repo was only for raw data, data processing, and QAQC'd data. It wouldn't necessarily mess up the pub, but it could complicate it. If it would make sense to bundle the Shiny app with these data (i.e., that app will only ever have these data in it), I think there is merit to keeping it here. It's functional, so I don't see a reason to not include it now if it will be included later.

Oh, you should also add issue #2 in the 'Development' area on the RHS of this PR so that it will close with the close of this PR!

Tried to solve the y axis issue but ended up breaking the multiple plot part of the app. I removed the shiny app code from the repo (will work on separate branch for a bit trying to fix it). I also fixed the filepath for the demo script.
Just a quick review of the readme would be helpful to make sure that everything still makes sense :)
Then I'll merge this PR and release to Zenodo


how to sign multi output tx

Hello,my mother language is not English,so i don`t know many English.
I am a beginner of bitcoin/blockchain,and this is my code to sign a tx with multi output(there are many tx data in $txs),but it always return fail when run to OP_EQUALVERIFY.what`s the wrong?
        foreach ($txs as $tx) {
            $privateKey = $this->getUserPrivateKey($tx['user']['id']);
            foreach ($tx['input'] as $input) {
                $satoshi = $input['satoshis'];
                $txOut = new TransactionOutput($satoshi, ScriptFactory::scriptPubKey()->payToPubKeyHash($privateKey->getPubKeyHash()));
                // $input = $signer->input($index, $txOut);
                // $signer->sign($index, $privateKey, $txOut);
                $signer->input($index, $txOut, $signd)->sign($privateKey);
                $index++;
            }
        }

sorry I just get privateKey not compressed in getUserPrivateKey


Support for Circuit Breaker to prevent OOM error

@trustin  @normanmaurer
Hi, I am a user of Elasticsearch which uses Netty in the network layer. Currently, if we are sending high volumes of messages to Netty in elasticsearch in a very short time, faster than it can process, heap memory would be filled with Netty buffer and causes an OOM error before messages reach Elasticsearch.
Elasticsearch provides a Circuit Breaker that specifies the total amount of memory that can be used. It greatly reduces the risk of OOM by stopping memory allocation when its memory usage reaches up to 95%. But it can't stop Netty from accepting incoming message and running out of memory in the network layer.
Does Netty have a plan to support Circuit Breaker to prevent operations from causing an OutOfMemoryError?

Limit the amount of messages read can easily be archived by stop reading. This cane be done by toggle AUTO_READ to false until the application is ready to accept messages again. There is nothing special here needed by netty.

Thanks for your comment, @normanmaurer. Is there any way to limit the amount of Chunk?

@boicehuang if toggling AUTO_READ was done too late then you must toggle it earlier. There is not much more that we can do here... Either you need to stop writing if the Channel is not writable and continue writing once it becomes writable again or you need to stop reading if you accept data faster then you can process it. Most of the times you want to do a mix of both.

maybe use AUTO_READ  to  limit used memory by READ
use WriteBufferWaterMark to limit used memory by WRITE

Let me close this one for now

Thanks, @normanmaurer.  I understood and still had a question.
By toggling AUTO_READ, we can put a limit on bulk data requests to prevent used memory from growing up.  But is it possible or any way to not restrict cluster coordination requests, such as vote/join requests, to keep nodes always connected and cluster intact while rejecting bulk data requests at the same time?

@boicehuang you need to ask on the elastic search project for this. Netty is just the framework used for networking and how they use it and how they implement safe-guards is up to them.


Update dependencies and replace try_from by std builtin

This updates the dependencies of bson and replaces try_from by a builtin std feature.

Also once this is merged, I'd love to have a new release. Thank you!

I will release it tonight.


python_package pyopenssl does not actually install the package

Code
Chef recipe
include_recipe 'poise-python'

python_package 'pyopenssl' do
  action :install
end

Expected Behaviour
pyopenssl package is installed and is shown when pip list is run
Actual behaviour
When  I run Kitchen tests, the Chef logs shows that the resource is installed
         * python_package[pyOpenSSL] action install
           - install version 16.2.0 of package pyOpenSSL

However, my serverspec tests failed
       Command "pip list | grep -i pyOpenSSL"
         exit_status
           should eq 0 (FAILED - 1)

       Failures:

         1) Command "pip list | grep -i pyOpenSSL" exit_status should eq 0
            Failure/Error: its(:exit_status) { should eq 0 }

              expected: 0
                   got: 1

              (compared using ==)
              /bin/sh -c pip\ list\ \|\ grep\ -i\ pyOpenSSL

And I confirmed this when logging in to the test server and manually checked in the command line, pyopenssl does not exist:
<EMAIL_ADDRESS>centos]# pip list | grep -i pyopenssl
<EMAIL_ADDRESS>centos]#

I tried adding the version in the Chef resource or changing the package name to PyOpenSSL, but it doesn't resolve the issue.

On CentOS it defaults to using the SCL (Software Collections) packages for Python. This gives you much newer versions of Python but unfortunately means that things can be confusing. /usr/bin/python and /usr/bin/pip are both from the system package, which is probably an older version (specifics depend on if this is CentOS 6 or 7). If you run the command scl enable python27 'python -m pip list you'll likely see the expected output.
If you want to force it to use the system package version of Python instead, there are instructions in the README.

Thank you for the tip! I don't need to use the system package so your command works for my serverspec test.
Thanks again!

This is great example of why you shouldn't be writing tests like that, they are super-fragile and not how Chef tests should work :-) Check out https://coderanger.net/overtesting/ for more info, but going to close this out as it sounds like you're unblocked.


Enable autosave

This PR enables PROJECT_QUESTIONS_AUTOSAVE by default, automatically saves also on the back button, and removes the skip button when PROJECT_QUESTIONS_AUTOSAVE is on.

yes think so too! @ubbo you mean with 2 buttons right? The 4 buttons are there when autosave is off
with PROJECT_QUESTIONS_AUTOSAVE = True   :


Simplify OSL test setup

Use the OSL cmake exports to configure the variables needed to enable OSL testing.
Also remove the need for specifying the standard OSL include path, an oslc install will already know where these are.

This is ready to go - pending someone who works on Windows validating that this still allows OSL to be used with windows.

This proposal looks very promising to me, and I should have a chance to test it soon with Windows OSL (which uses a less standardized build approach and folder structure).

@ld-kerley In my local test, I get an error message from CMake before I have a chance to select any build options, so this seems to occur even if the user doesn't choose to build with OSL support:
CMake Warning at CMakeLists.txt:185 (find_package):
  By not providing "FindOSL.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "OSL", but
  CMake did not find one.

  Could not find a package configuration file provided by "OSL" with any of
  the following names:

    OSLConfig.cmake
    osl-config.cmake

  Add the installation prefix of "OSL" to CMAKE_PREFIX_PATH or set "OSL_DIR"
  to a directory containing one of the above files.  If "OSL" provides a
  separate development package or SDK, be sure it has been installed.

@jstone-lucasfilm - was this an error message in CMake, or just a warning and things continued?  I would expect things to have just continued, albeit with an annoyingly loud warning.
I just pushed a PR where I'm quietening the warning, and also guarding the check to only when we need it (testing OSL).

@ld-kerley I believe you're correct that this was just a warning, though CMake makes it look as if the warning is fatal through the use of red text.  Let me try the latest build and see how things are looking now.


Feature Request: Date Selection, Preselection

Hi using adaptive cards on my chatbot ui, i have a Adaptive card of "type": "Input.Date".When the user opens up the date panel, i need to high light few dates based on custom logic. I have a specific scenario where input.date selection should be used to pre-filter input.time as part of the same card.
Request if this is something that we can add as a feature.

Looks like it's a feature request on Adaptive Cards repo.


Using on Mac OS X

Hi!
When I use this on Mac OS, I get the following error with mbsync
Error performing SASL authentication step: SASL(-1): generic failure: Unable to find a callback: 18948
I know this is probably an issue with mbsync, but perhaps there's a way to avoid it without changing isync code?
Thanks!

Hi,
I expect this has to do with OS X SASL setup. I am currently trying to figure it out myself. As far as I understand one needs to install https://www.cyrusimap.org/sasl/ (can be done via brew). This is where I am stuck currently, as using pluginviewer the only plugin I am shown is EXTERNAL. I think ideally, one would see all plugins coming with cyrus sasl. My assumption is, if that works, one would need to install this xoauth2 plugin into a place where cyrus sasl finds it as well. Then one should be good to go.
As pointed out, I am not there myself. So the description is only based on assumption and what I have read so far ( mostly: https://www.reddit.com/r/commandline/comments/muhnqb/request_for_help_with_mbsync_and_xoauth2_for/ and the documentation of both cyrus sasl and xoauth2 itself).
Maybe it points you in the correct direction... Any help would be highly appreciated

I have reached more or less the same state where I am shown EXTERNAL and now other plugins.
That's as far as I got.

Did anyone discover a solution for this? @guibor @pejaab ?

I haven't. Perhaps @moriyoshi might have an idea?

Sorry for leaving this behind too long. The answer depends on the setup, for example where the accompanying SASL library comes from, either the system provided or the one installed on your own, through homebrew, MacPorts, or by building it yourself.  Anyways, the number appeared in the error message Unable to find a callback: 18948 indicates the constant number called "callback ID" that is designated by the header file as SASL_CB_* and instructs the SASL library what operation it should delegate to the underlying implementation.  18948 corresponds to 0x4a04, and what drews my attention the most is there is no such designation in the original Cyrus-SASL, but there is, in the Apple's implementation where you can find SASL_CB_OAUTH2_BEARER_TOKEN for that value.
So all I can assume at the moment is that you are most likely using the system SASL library and I need to know more context about why this callback ID is propagated.

Thanks @moriyoshi - what about the context would be helpful? It does seem that the system library is called but I am unsure how to make mbsync call the right library

Did you compile mbsync --with-sasl=/path/to/cyrus? It compiles and no longer calls the Apple provided implementation, but I wasn't able to get it to work. Running pluginviewer only shows EXTERNAL.
It wasn't immediately clear to me why this was the only plugin listed, so I ended up patching mbsync. By adding the above mentioned callback, I was able to get mbsync working with the Apple provided implementation. Certainly not ideal, but at least it works until I can figure something else out.

Hi @ldavison this sounds promising, do you have more details on the patch? What exactly did you change in mbsync's source?

Hi @ldavison this sounds promising, do you have more details on the patch? What exactly did you change in mbsync's source?

Specifically, the area of code is in drv_imap.c and seems to be
static sasl_callback_t sasl_callbacks[] = {
	{ SASL_CB_USER,     NULL, NULL },
	{ SASL_CB_AUTHNAME, NULL, NULL },
	{ SASL_CB_PASS,     NULL, NULL },
	{ SASL_CB_LIST_END, NULL, NULL }
};

static int
process_sasl_interact( sasl_interact_t *interact, imap_server_conf_t *srvc )
{
	const char *val;

	for (;; ++interact) {
		switch (interact->id) {
		case SASL_CB_LIST_END:
			return 0;
		case SASL_CB_USER:  // aka authorization id - who to act as
		case SASL_CB_AUTHNAME:  // who is really logging in
			val = ensure_user( srvc );
			break;
		case SASL_CB_PASS:
			val = ensure_password( srvc );
			break;
		default:
			error( "Error: Unknown SASL interaction ID\n" );
			return -1;
		}
		if (!val)
			return -1;
		interact->result = val;
		interact->len = strlen( val );
	}
}

what changes did you make to this area before compiling --with-sasl=/path/to/cyrus?

@guibor - The following diff will apply against the mbsync tag for v1.4.4, which will get mbsync working with Apple's implementation:
diff --git a/src/drv_imap.c b/src/drv_imap.c
index c5a7aed..b8ac65a 100644
--- a/src/drv_imap.c
+++ b/src/drv_imap.c
@@ -2195,6 +2195,9 @@ static sasl_callback_t sasl_callbacks[] = {
        { SASL_CB_USER,     NULL, NULL },
        { SASL_CB_AUTHNAME, NULL, NULL },
        { SASL_CB_PASS,     NULL, NULL },
+#ifdef __APPLE__
+       { SASL_CB_OAUTH2_BEARER_TOKEN, NULL, NULL },
+#endif
        { SASL_CB_LIST_END, NULL, NULL }
 };

@@ -2212,6 +2215,9 @@ process_sasl_interact( sasl_interact_t *interact, imap_server_conf_t *srvc )
                        val = ensure_user( srvc );
                        break;
                case SASL_CB_PASS:
+#ifdef __APPLE__
+               case SASL_CB_OAUTH2_BEARER_TOKEN:
+#endif
                        val = ensure_password( srvc );
                        break;
                default:

This is most of the patch from this thread: https://sourceforge.net/p/isync/mailman/isync-devel/thread/20210308170245.kq4ubg24jcxezyhf%40bsd-mbp.dhcp.thefacebook.com/#msg37235467; I removed is the suppression of the warning.
I did not have to change my AuthMechs to OAUTHBEARER though, I used XOAUTH2 and it worked fine on macOS 11.6 (Big Sur). The patch will not work when compiling with cyrus-sasl-xoauth2 as SASL_CB_OAUTH2_BEARER_TOKEN is not defined.

Thanks a lot.  So this worked!
What I did was:

Made the suggested changes to the source code.
Compile with SSL: ./configure<EMAIL_ADDRESS>This is critical because without this imap.gmail.com is not reachable and using different versions/packages for SSL fails for some reason.

I also managed to make it work using the code patch (which I made avaiable at https://github.com/xukai92/isync.git).
I simply modified the formula of isync in my Homebrew (i.e. removing url,sha256 and change the Git address in head to the one above with brew edit isync) and reinstall with brew reinstall isync --build.
I didn't find it necessary to do the SSL thing as above.
For anyone just started looking into how to set up mbsync with OAUTH2, I closely followed https://cvanelteren.github.io/post/mu4e/, which lead me to the last step of failing to authenticate with mbsync using the obtained code (due to SASL issue), and then came to this issue which the solution above on how to fix that.

OK, I'm clearly missing something here.

cyrus-sasl installed w/ brew
cyrus-sasl-xoauth2 compiled and installed in cyrus (shows in pluginviewer)
isync compiled --with-sasl and --with-ssl
mbsync -h reports +HAVE_LIBSASL and +HAVE_LIBSSL
AuthMechs XOAUTH2

mbsync is still trying SASL PLAIN:
Connection is now encrypted
Logging in...
Authenticating with SASL mechanism PLAIN...
IMAP command 'AUTHENTICATE PLAIN <authdata>' returned an error: NO AUTHENTICATE failed.
C: 1/1  B: 0/0  F: +0/0 *0/0 #0/0  N: +0/0 *0/0 #0/0

Successfully got this to work using the above code patch. I needed to use ./configure<EMAIL_ADDRESS>Of note: When I run mbsync, I get the following warning on the oauth2 accounts: Warning: SASL wants more steps despite successful IMAP authentication. Ignoring... Anyone else? I'm guessing that this is due to some peculiarity in Apple's SASL.

Did you compile mbsync --with-sasl=/path/to/cyrus? It compiles and no longer calls the Apple provided implementation, but I wasn't able to get it to work. Running pluginviewer only shows EXTERNAL.
It wasn't immediately clear to me why this was the only plugin listed, so I ended up patching mbsync. By adding the above mentioned callback, I was able to get mbsync working with the Apple provided implementation. Certainly not ideal, but at least it works until I can figure something else out.

I can't speak for you (much less the you of a year ago), but I think the issue is that the ./configure invocation for this package misses something crucial on macos which can cause it to fail in a way that is very easy to overlook. Specifically, on macos trying to install cyrus-sasl-xoauth2 as described into the docs will attempt to install the plugin to the system implementation of sasl, which will fail, even if cyrus-sasl is properly installed.
The solution to this is to direct it to the correct target: ./configure --with-cyrus-sasl=/path/to/cyrus-sasl. Then, make install will actually install the plugin for cyrus-sasl, after which everything should start working properly. (Given all the other givens, like mbsync being compiled to use cyrus-sasl, etc.) Rather than having to hack mbsync to get it to play nicely with the system sasl implementation, this seems to solve the problem using cyrus-sasl and cyrus-sasl-xoauth2, which is what we're nominally here for.
This might be worth noting in the readme for macos users, given the number of us bumbling around here in the issues. :)

Rather than having to hack mbsync to get it to play nicely with the system sasl implementation, this seems to solve the problem using cyrus-sasl and cyrus-sasl-xoauth2, which is what we're nominally here for.

I can confirm this works without the aforementioned code hack. To summarize:
./configure --with-sasl=/usr/local/opt/cyrus-sasl<EMAIL_ADDRESS>The above assumes you've installed the homebrew cyrus-sasl package and then compiled this repo (cyrus-sasl-xoauth2) plugin to go along with the homebrew (not macOS) sasl version.
I could not get mbsync to work with the isync homebrew formula edited and built with the same configuration options as above and using the same version.

The following worked for me:
$ sudo port install cyrus-sasl-xoauth2 #install from macports
$ # git clone isync & cd into it
$ # Run export commands specified in `brew info berkeley-db@4`
$ ./configure --with-sasl=/opt/local<EMAIL_ADDRESS>
Hope it helps someone who is also looking to get this working.

I used @bmclean2's comment to build mbsync from source. The paths to cyrus-sasl and openssl matched on my system.
I also used this stackoverflow post to build cyrus-sasl-xoauth2 from source
Editing the Makefile to use the correct CYRUS_SASL_PREFIX was the important part. The SO post uses sed, I just manually edited the Makefile that results from the ./configure step.
On my system the correct CYRUS_SASL_PREFIX turned out to be /usr/local/opt/cyrus-sasl/. I'm on MacOS, and I installed cyrus-sasl using brew.
After successful install,
saslpluginviewer shows an entry like:
Plugin "xoauth2" [loaded], 	API version: 4
	SASL mechanism: XOAUTH2, best SSF: 0
	security flags: NO_ANONYMOUS|PASS_CREDENTIALS
	features: WANT_CLIENT_FIRST|PROXY_AUTHENTICATION

i got this to work with brew. Here's roughly what i did
Install cyrus sasl for mbsync to link against
brew install cyrus-sasl libtool

Build this xoauth2 plugin against cyrus-sasl
git clone https://github.com/moriyoshi/cyrus-sasl-xoauth2.git
cd cyrus-sasl-xoauth2
vi autogen.sh

Change libtoolize to glibtoolize, otherwise you'll get a libtoolize not found error. I'm unsure if this warrants a patch.
./autogen.sh \
  && ./configure --with-cyrus-sasl=/opt/homebrew/opt/cyrus-sasl \
  && make \
  && make install

You should now have sasl with xoauth support. If this command returns nothing something went wrong.
/opt/homebrew/opt/cyrus-sasl/sbin/pluginviewer  | grep XOAUTH

Update brew formula to use cyrus-sasl instead of apple's
brew edit isync

Add , "--with-sasl=/opt/homebrew/opt/cyrus-sasl" to the ./configure line in the def install section.
I also added a depends_on "cyrus-sasl" below depends_on "openssl@3" but I'm unsure if this is required since it was manually installed.

Build isync with your local formula
HOMEBREW_NO_INSTALL_FROM_API=1 brew install -s isync

mbsync should now work with XOAUTH2 and an access token as the password.
Note: Homebrew doesn't use the local files when building from source. This might be the missing piece @bmclean2 and others needed (https://github.com/orgs/Homebrew/discussions/4286)

I followed the instructions by @com4 exactly, but mbsync still gives the error:
Error performing SASL authentication step: SASL(-1): generic failure: Unable to find a callback: 18948

Did anyone have the same issue?

i got this to work with brew. Here's roughly what i did
Install cyrus sasl for mbsync to link against
brew install cyrus-sasl libtool

Build this xoauth2 plugin against cyrus-sasl
git clone https://github.com/moriyoshi/cyrus-sasl-xoauth2.git
cd cyrus-sasl-xoauth2
vi autogen.sh

Change libtoolize to glibtoolize, otherwise you'll get a libtoolize not found error. I'm unsure if this warrants a patch.
./autogen.sh \
  && ./configure --with-cyrus-sasl=/opt/homebrew/opt/cyrus-sasl \
  && make \
  && make install

You should now have sasl with xoauth support. If this command returns nothing something went wrong.
/opt/homebrew/opt/cyrus-sasl/sbin/pluginviewer  | grep XOAUTH

Update brew formula to use cyrus-sasl instead of apple's
brew edit isync

Add , "--with-sasl=/opt/homebrew/opt/cyrus-sasl" to the ./configure line in the def install section.
I also added a depends_on "cyrus-sasl" below depends_on "openssl@3" but I'm unsure if this is required since it was manually installed.

Build isync with your local formula
HOMEBREW_NO_INSTALL_FROM_API=1 brew install -s isync

(You can also brew install --HEAD isync which should build from source and has the added benefit (as of 2024-07-16) of including a fix for error:0A000126:SSL routines::unexpected eof while reading when using mbsync with Gmail. https://sourceforge.net/p/isync/isync/ci/b6c36624f04cd388873785c0631df3f2f9ac4bf0/)
mbsync should now work with XOAUTH2 and an access token as the password.
Note: Homebrew doesn't use the local files when building from source. This might be the missing piece @bmclean2 and others needed (https://github.com/orgs/Homebrew/discussions/4286)

This worked flawlessly for me. The key part is in the last note.

@jorgerojas26 Could you list the steps you did for the last note (make changes to the isync formula and build it)? I followed the steps in the link in the last note: uninstall isync (mbsync no longer exists), extract the modified formula to my own tap (link), untap homebrew-core, then install/build from source from the modified formula in my own tap. The build log shows ./configure --disable-silent-rules --with-sasl=/opt/homebrew/opt/cyrus-sasl which seems correct. However, I still have the same error message when running the newly built mbsync: Error performing SASL authentication step: SASL(-1): generic failure: Unable to find a callback: 18948.

I'm on fedora and get a slightly different error:
Authenticating with SASL mechanism XOAUTH2...
Error performing SASL authentication step: SASL(-1): generic failure: Unable to find a callback: 32775

Does anybody knows what 32775 means?


Feature request: rename thread/processes names

It would be great to have the threads and/or processes renamed with something like puma does :
root@xxx:/etc/telegraf# ps faux | grep puma
root     12595  0.0  0.0  13084  1024 pts/4    S+   Sep29   0:00  |                       \_ grep puma
mastodo+ 23771  0.0  0.6<PHONE_NUMBER>64 ?       Ssl  Sep20   0:44 puma 3.11.4 (tcp://<IP_ADDRESS>:3100) [live]
mastodo+ 23968  0.0  1.8 1173088 314728 ?      Sl   Sep20   7:11  \_ puma: cluster worker 0: 23771 [live]
mastodo+ 23983  0.0  1.4<PHONE_NUMBER>00 ?       Sl   Sep20   6:49  \_ puma: cluster worker 1: 23771 [live]

Having that kind of thing with falcon would help monitoring/graphing individual processes.

I've implemented basic support for this in Falcon v0.19.1 - it's not really good yet - it turns out on macOS setproctitle doesn't work very well. In any case, the basic issue here is implemented and I hope over time I can improve it.


Bio-Formats 6: public images

Separate the formats using a standard layout with a public subfolder from the non-standard formats/images for clarity

I like it a lot :+1:


Infinite $digest loop on auth with OAuth redirect

Disclaimer: I’m a Firebase newbie and might do things wrong.
I’ve setup this simple Ionic app with 2 states (settings bound to /settings, game bound to /game, nothing fancy). I want my users to be able to authenticate using a “Log in with Facebook” button from my settings state, but they are allowed to get to the game state without doing so; I want them to be able test the waters before signing in.
Here are my states definitions:
$stateProvider.state('game', {
  url: '/game',
  template: '...'
});

$stateProvider.state('settings', {
  url: '/settings',
  template: '...',
  controller: SettingsController,
  controllerAs: 'settings',
  resolve: {
    currentUser: function (Auth) { return Auth.$waitForAuth(); }
  }
});

$urlRouterProvider.otherwise('/game');

The Auth service is the idiomatic return $firebaseAuth(new Firebase(FIREBASE_ENDPOINT));.
Now for the SettingsController part:
function SettingsController ($log, Auth) {
  this.login = function () {
    Auth
      .$authWithOAuthRedirect('facebook')

      // This never gets called in the current environment (Chrome), putting it up here for consistency
      .catch(function (err) {
        return err.code === 'TRANSPORT_UNAVAILABLE' ? Auth.$authWithOAuthPopup('facebook') : $log.error(err);
      });
  };
}

When I click the “Log in with Facebook” button, triggering the settings.login() function from my template, I’m redirected as intended to the Facebook login page (which I don’t see anymore since I’ve already accepted the permission dialog), then back to my app with a __firebase_request_key=... parameter in my hash (http://localhost:8100/#/settings?__firebase_request_key=...).

I don’t know what causes this to happen, but the $stateChangeStart event is fired repeatedly (from the abstract root empty-string-named state to the settings state), causing the resolve.currentUser to be called multiple time as well but also wreacking havoc on my app with this infamous Angular exception:
Error: [$rootScope:infdig] 10 $digest() iterations reached. Aborting!
Watchers fired in the last 5 iterations: []

Moreover, the __firebase_request_key=... part stays in the URL (I guess it should not?) and no other ui-router related event gets fired — neither $stateChangeSuccess nor $stateChangeCancel nor $stateChangeError.
Alas I’m logged in! — but this exception is getting on my nerves and I can’t find a proper solution no matter how much I try.

Here’s a few avenues I’ve explored to no avail:

Rename states to prefix them with app. (e.g. app.game, app.settings) and creating an abstract app state bound to an empty URL (or simple /) and a <ui-view/> template.
Replace the $urlRouterProvider.otherwise part to use $state.go.

// As suggested by https://github.com/angular-ui/ui-router/issues/600#issuecomment-47228922
$urlRouterProvider.otherwise(function (injector) {
  injector.get('$state').go('game');
});

I created this project during the week and am therefore using recent versions of these libraries, using npm and Browserify:

Library
Version

angular
1.4.8

angular-animate
1.4.8

angular-sanitize
1.4.8

angular-ui-router
0.2.15

angularfire
1.1.3

firebase
2.3.2

ionic-sdk
1.2.1

Thank you for taking the time to read this wall of text! I hope we can work out a solution.

I'm not sure I have any ideas off the top of my head. A JSFiddle or Plunker would be super useful here and usually making a minimum repro helps find bugs on the developer end. One thing to note is that you should make sure to not navigate the page away when doing the authentication. If your login button is in a <form> element then it will navigate the page upon clicking, which will cause the authentication to not work and can cause unexpected errors. So that is one thing to look into. Without a repro though, I'm not sure I can be of much help.

Closing due to lack of a repro. If you have one, please provide it and re-open this issue.


screen reader friendly functionality

Hi,
Is there any better way to code the input field with angucomplete so it is more screen reader friendly?
I tried adding aria-autocomplete="list" role="combobox" to a autocomplete input field, and it seems not working as expected. When running a screen reader against this input field, it only reads "Search user combo box, change users using arrow keys". But I was expecting something like "10 result is available, use up and down arrow keys to navigate", which can be implemented with JQuery ui-autocomplete-input easily. ui-autocomplete-input can dynamically add/remove/modify a ui-helper-hidden-accessible div with a dynamic message, which shows the result number in the list. Is there any better way to do the same thing with angucomplete?
Thanks a lot

Further information: I also added ui-autocomplete-input into input field's class list and was expecting below line automatically added with number of the result in pull down list. But this is not happening. Is there something in angularJs blocking it from working as expected?

We have specific requirement from client that we need to make sure screen reader can reads the number of the available results in autocomplete pull down list. Just adding JQuery ui-autocomplete-input class seems not working. Below line was not dynamically added/updated.
10 results are available, use up and down arrow keys to navigate.
But there seem to be a bug with AngularJs angu-autocomplete directive and it is not working with JQuery well. From what I see, the JQuery built in with Angular Js doesn't contains necessary classes. To make it work, I had to customize the angucomplete plugin code (angucomplete-alt.min.js) by adding following div after the input field. This custom fix works well.
results.length results are available, use up and down arrow keys to navigate.
Is it possible that angucomplete-alt project can take above issue into consideration list and possibly add the fix into next version?

Is any data binding available to access the results object from outside the angucomplete directive? I was trying to get results through localData or selectedObject bindings without success.  If I can access the results object directly myself I can write screenreader accessibility code myself without having to rely on it being implemented in angucomplete.  Thanks


wrong lineheight

i use mac
FontSize: 12
FontFamily: Monaco
Editor Theme: Material Theme

I'll take a look.  What version vs code and jumpy2?

I'll take a look. What version vs code and jumpy2?

vs code version: 1.90.0
jumpy2: v1.5.2

Hey, sorry for the delay on this.
Had to work on some broken build stuff.
Looks like you made some progress, but to be clear you're talking about this right:
https://marketplace.visualstudio.com/items?itemName=Equinusocio.vsc-material-theme
And then you followed:
{
// Controls the line height. Use 0 to compute the lineHeight from the fontSize.
"editor.lineHeight": 28,
// Enables font ligatures
"editor.fontLigatures": "'ss01','ss05','dlig'",
// Controls if file decorations should use badges.
"explorer.decorations.badges": false
}
Right?  I have been thinking more about lineHeights in general lately, So I might want this to work as well.
I was able to reproduce some quirkiness yeah.  I'll take a look.

Hi, Fix is in #main I will probably release it this weekend.

Released.


请问，1.0.0 会发布正式版吗？想在 ng5 下使用 zorro 0.7

Bug Report or Feature Request (mark with an x)

[ ] Bug report -> please search issues before submitting
[ ] Feature request
[ ] Documentation issue or request

Reproduction link

Steps to reproduce

What is expected?

What is actually happening?

Environment

ng-alain version: X.Y.Z
Angular version: X.Y.Z
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX

已经 1.0


TypeScript plugin for Buddy 6

I basically copied what you did into the new format. Please add your copyright/author info


[5.1] Don't let relations override user-defined keys

I think this Behat scenario expresses it clearest:
Given that App\Customer has a relationship method `fields`
And that I manually set $customer->fields on an instance
When I call $customer->toJson
Then I expect to see the fields I added

What actually happens now is that because the model does return array_merge($attributes, $this->relationsToArray());, the arrayed relations will override any keys set manually by the user.
To clarify
$fields = [];

$customer->fields = $fields

$this->assertEquals($fields, $customer->fields);
$this->assertEquals($fields, $customer->toArray['fields']);

In the above, given there's a relationship method fields(), the first assert would succeed, but the second would fail, so there's an inconsistency in the returned result.

This is a major breaking change?

@GrahamCampbell sometimes I don't think far enough... So target 5.3 instead? Would you agree with the change tho?

D'no, upto Taylor.

@GrahamCampbell see the updated main post, just clarifying that this is about fixing an inconsistency in the API (that said, it is breaking, you're perfectly right with that)

@taylorotwell would you agree with the idea of this PR, although it should be with 5.3?

To set a relation you should use $customer->setRelation('fields', $fields);

@taylorotwell: in the developer's mind, aren't you just setting an
attribute tho? Isn't the inconsistency a bit odd? I'd expect
$object->fields to give me the same output as
$output->toArray()['fields']
On Fri, 22 Jul 2016 at 15:03, Taylor Otwell<EMAIL_ADDRESS>wrote:

Closed #14417 https://github.com/laravel/framework/pull/14417.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/laravel/framework/pull/14417#event-731718489, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AG65g-JKjLSCEXxUVWxv7OxGdVxvzIxRks5qYL-NgaJpZM4JSEWk
.


Hide Bitcoin Contracts from balances on testnet unless non-zero

As they're hidden from balances on mainnet until the user has engaged with a contract

The solution for this request has been included in this merged PR. I'll close this issue now.
https://github.com/leather-wallet/extension/pull/4460


Remove gRPC host-port from being added to the CR (agent)

Fixes #1271.
Previously, the upgrade routine for 1.18 was adding the gRPC host-port option to the CR. In fact, the host-port is already being added by the sidecar/daemonset if this options isn't set. The CR should only be set by users, in which case we wouldn't touch it again (not for sidecar/daemonset, not for upgrades).
Signed-off-by: Juraci Paixão Kröhling<EMAIL_ADDRESS>

@jkandasa are you able to test this PR? This is the image I published with it: quay.io/jpkroehling/jaeger-operator:pr1272

@rubenvp8510, could you review this one?

codecov is freaking out because less lines are being covered. Apparently, it can't  understand that those lines were actually removed.


NCS functions

This PR aims to add NCS-functions so that mos-connection can be used by an NCS, not just a mos-device.
work-in-progress

We are currently experimenting with this connector and the NCS feature is something we would like to use, test and expand on. I noticed that the roListAll isn't currently implemented. Are there any specific issues we can work on? Or is this PR obsolete?

The work on this PR was paused a while ago due to other focuses in the team.
I did find a few uncommitted things locally however now when I dusted it off. I'll see if I can push them tonight and I'll be able to give you a better reply tomorrow on forward directions.
Contributions are always welcome and I can provide guidance and do code reviews during implementations.

Great, sounds good. We are testing out the connection library to connect our Newsroom system to MOS devices, so you can expect some new features and/or bug fixes in the near future.

Most (all?) of the NCS functions for profiles 0,1,2,3 & 4 have been implemented (although some tests are lacking still).
I've found a few issues (unrelated to this PR) here and there in the backend side of things, but that'll have to be addressed later, I think.
This PR has gone on long enough by now, so I'm going ahead to merge it.


Part of the source code is missing when adding the SDK via cocoapods

I am trying to add TMTumblrSDK into my project using cocoapods. This is what I have in my pod file:
platform :ios, '7.0'

target 'PhotoPostExample' do

pod 'TMTumblrSDK', '~> 4.0.4'

end

I set the SDK version to 4.0.4 based on the info here
https://github.com/tumblr/TMTumblrSDK/blob/master/TMTumblrSDK.podspec.json
But the TMAPIClient.h looks very different, the following secion is missing:
#ifdef __ENVIRONMENT_IPHONE_OS_VERSION_MIN_REQUIRED__

/**
 Authenticate via three-legged OAuth using a given UIWebView

 Your `TMAPIClient` instance's `handleOpenURL:` method must also be called from your `UIApplicationDelegate`'s
 `application:openURL:sourceApplication:annotation:` method in order to receive the tokens.

 This method proxies to an underlying `TMTumblrAuthenticator` which will authenticate using the given the web view.
 That class can be used on its own but you do not need to invoke it directly if you are including the whole API client in your project.

 @param URLScheme a URL scheme that your application can handle requests to.

 @param fromViewController a UIViewController to present the authentication view controller from.
 */
- (void)authenticate:(NSString *)URLScheme fromViewController:(UIViewController *)fromViewController callback:(void(^)(NSError *))error;

#endif

Any idea what I can do to fix this? Thanks!

These will be available after we push a new version to cocoapods trunk!
Thank you for your interest in TMTumblrSDK - we will update this thread once we do so

I see, thanks for the reply!
Meanwhile, is there a way for me to integrate the SDK (without too much pain)? Or I should simply wait for the update?

If you need to integrate it right now, you can depend on the most recent commit in the repo. However, I would recommend updating your Podfile to a stable version once a published version of the SDK meets your needs, because we will inevitably push backwards-incompatible API changes to this repo.
pod 'TMTumblrSDK', :head


update readme screenshots

the readme screenshots are old; the walls are all white and the fisheye effect is no longer present.

Fixed in 2c2111698a8246ee7f57b4274b8cab11c7100a51


When any of the functional screens is opened, there is a single background load

Description
I'm not sure if it's a bug or architecturally designed that way.
When any of the functional screens is opened, there is a single background load in the text boxes. I've stopped Smart detection, but it doesn't have any effect.
Steps To Reproduce

Go to Text Comparer, XML Validator, XML Formatter, SQL, JSON...
The text boxes show some loading

Expected behavior
Functionality to be initialized immediately.
DevToys Version
Version <IP_ADDRESS> | X64 | RELEASE | 8bcfa60 | 8bcfa60
Relevant Assets/Logs
https://user-images.githubusercontent.com/70388317/187275759-b3e52780-cbc1-4362-bed1-782e22a2336e.mp4

Hello,
The current behavior is correct. The technical reason for this is that tools like SQL Formatter use the Monaco text editor, which enables line numbers and syntax highlighting. It is the same text editor than Visual Studio Code. We decided to use this one because it's commonly known by developers along with being one of the rare components giving us all these features for free (in the meaning that it was cheaper to do than creating our own code editor).
The drawback of this choice is that the editor lives in a web view. The reason why it takes some time to load the text editor is simply because it takes some time to load the page.
In the long term, we'd prefer using a more native text editor that doesn't require us to use a web view in the app. But we're not there yet. 😅


AddRecaptcha method should be inside Microsoft.Extensions.DependencyInjection

In this way, users don't need to import reCAPTCHA.AspNetCore namespace. When they referenced reCAPTCHA.AspNetCore in their project AddRecaptcha will show up in the auto-completion automatically. Other Microsoft projects also use this way (ref).

Because of RecaptchaSettings you have to import reCAPTCHA.AspNetCore namespace unless you move RecaptchaSettings to Microsoft.Extensions.DependencyInjection namespace and I think there is nothing special in moving AddRecaptcha  namespace.

Not really. You don't need to reference RecaptchaSettings due to you can use type inference on the lambda. MvcOptions also not inside Microsoft.Extensions.DependencyInjection.

@ultimaweapon i would recommend creating a pull request with this change so it can be tested / approved if you still wish to see this. Thank you for your contributions.

@TimothyMeadows okay will do when I have time.


Create a Travis build

Travis should deploy to gh-pages on each build.

Here is a procedure on how to do this:
http://stackoverflow.com/a/33125422/1734119

The auto-deployment will be moved to a separate issue.


Use headers set using elastic.SetHeaders() in health check

Which version of Elastic are you using?
[x] elastic.v7 (for Elasticsearch 7.x)
[ ] elastic.v6 (for Elasticsearch 6.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v2 (for Elasticsearch 1.x)
Please describe the expected behavior
The headers set using elastic.SetHeaders() should be used in health checks.
Please describe the actual behavior
The headers set using elastic.SetHeaders() are not being used in health checks and thus 401 is returned when the server requires authentication. This happens when the client is not using basic auth but an API key instead.
Any steps to reproduce the behavior?
Use ES 7 client configured to use an API key. I am getting the following error
panic: health check timeout: no Elasticsearch node available

This was recently added. Could you make sure you use 7.0.18? If the issue still persists, comment again and I'll reopen.


feat: allow to remove org

Forgot auth :)

@allcontributors please add @SofianD for review, design


updated the springboot version to 3.3.5

This PR implements the following changes:

I have changed the springboot starter parent version to 3.3.5 in pom.xml

Thanks so much for working and learning with me @dev-m03  !

It was awesome to learn a lot from you @thadguidry sir !


Make spec backward compatible

Pull Request Test Coverage Report for Build 1027

1 of 3 (33.33%)  changed or added relevant lines in 2 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 79.172%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/brod_consumer.erl
0
2
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/brod_kafka_apis.erl
1
75.0%

src/brod_consumer.erl
3
74.77%

Totals

Change from base Build 1023:
-0.2%

Covered Lines:
2007

Relevant Lines:
2535

💛  - Coveralls


DateIntervalParameter not ISO8601 interval?

Hello,
according to the docs DateIntervalParameter uses ISO 8601 Time Interval notation.
However, there are four ways to express a time interval (according to wikipedia):

Start and end, such as 2007-03-01T13:00:00Z/2008-05-11T15:30:00Z
Start and duration, such as 2007-03-01T13:00:00Z/P1Y2M10DT2H30M
Duration and end, such as P1Y2M10DT2H30M/2008-05-11T15:30:00Z
Duration only, such as P1Y2M10DT2H30M, with additional context information

Looking at the tests for date_interval it seems this is not what is implemented:

2015-01-01-2015-01-30 is considered a valid time interval
this should probably be 2015-01-01/2015-01-30

Yeah it's not entirely true. We should fix the docs

The four classes Date, Week, Month, and Year all implement ISO 8601 notation. Note that they do not implement time interval notation, just date notation, but then these are considered intervals (i.e. the year 2015 is considered the interval [2015-01-01, 2016-01-01)
There is no ISO 8601 standard for date intervals afaik, just time intervals. So there's no obvious thing to do
I chose the representation YYYY-MM-DD-YYYY-MM-DD for the Custom class, with a dash rather than a slash since dashes are unlikely to mess up directory structures. There's actually a comment for it in the constructor: https://github.com/spotify/luigi/blob/master/luigi/date_interval.py

I suggest we change the docs so it doesn't say that we use ISO 8601 time interval notation. The docs should say we support ISO 8601 date notation for date intervals

Nice! closing issue


Table: Issue in column order in table.

Describe the bug (current behavior)
When we use the same table component across multiple tabs, passing different data, including different column orders, the table consistently retains the order from the previous table.
Video of issue:

Expected Behavior
The table column order should update across all instances in multiple tabs, reflecting the latest data we provide based on any changes in the column order
Link to minimal repro
https://codesandbox.io/p/sandbox/xf476l
Steps To Reproduce

Create tabs that use the same table component, but with different column order configurations passed to each tab.
Reorder the columns in the table within one tab.
Switch to another tab: You'll notice that the column order in this other tab remains the same as in the first tab, even though different column order configurations are passed to each tab.

Package Version

[ ] I'm using the latest version of iTwinUI.

Anything else?
No response

This is not a bug. By default, React uses the position in the component tree to decide whether it's a unique component. You need to pass a key when you want to render a new Table.
The key can be the same as the ones used in your tabs.
<TableComponent
  key="apple" // or "orange"
  // …
/>

@mayank99 Thanks, It solved the problem


Format and validate pyproject.toml

With the new sphinx-autobuild 2024.4.13, I'm getting ModuleNotFoundError: No module named 'watchfiles' with https://github.com/python/peps/:
❯ make clean venv htmllive
rm -rf .venv
rm -rf build topic
Creating venv in .venv
Requirement already satisfied: pip in ./.venv/lib/python3.12/site-packages (24.0)
Collecting wheel
  Using cached wheel-0.43.0-py3-none-any.whl.metadata (2.2 kB)
Using cached wheel-0.43.0-py3-none-any.whl (65 kB)
Installing collected packages: wheel
Successfully installed wheel-0.43.0
Collecting Pygments>=2.9.0 (from -r requirements.txt (line 2))
  Using cached pygments-2.17.2-py3-none-any.whl.metadata (2.6 kB)
Collecting Sphinx!=6.1.0,!=6.1.1,>=5.1.1 (from -r requirements.txt (line 5))
  Using cached sphinx-7.2.6-py3-none-any.whl.metadata (5.9 kB)
Collecting docutils>=0.19.0 (from -r requirements.txt (line 6))
  Using cached docutils-0.21.1-py3-none-any.whl.metadata (2.7 kB)
Collecting sphinx-autobuild (from -r requirements.txt (line 8))
  Using cached sphinx_autobuild-2024.4.13-py3-none-any.whl.metadata (7.7 kB)
Collecting pytest (from -r requirements.txt (line 11))
  Using cached pytest-8.1.1-py3-none-any.whl.metadata (7.6 kB)
Collecting pytest-cov (from -r requirements.txt (line 12))
  Using cached pytest_cov-5.0.0-py3-none-any.whl.metadata (27 kB)
Collecting sphinxcontrib-applehelp (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached sphinxcontrib_applehelp-1.0.8-py3-none-any.whl.metadata (2.3 kB)
Collecting sphinxcontrib-devhelp (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached sphinxcontrib_devhelp-1.0.6-py3-none-any.whl.metadata (2.3 kB)
Collecting sphinxcontrib-jsmath (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached sphinxcontrib_jsmath-1.0.1-py2.py3-none-any.whl.metadata (1.4 kB)
Collecting sphinxcontrib-htmlhelp>=2.0.0 (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached sphinxcontrib_htmlhelp-2.0.5-py3-none-any.whl.metadata (2.3 kB)
Collecting sphinxcontrib-serializinghtml>=1.1.9 (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached sphinxcontrib_serializinghtml-1.1.10-py3-none-any.whl.metadata (2.4 kB)
Collecting sphinxcontrib-qthelp (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached sphinxcontrib_qthelp-1.0.7-py3-none-any.whl.metadata (2.2 kB)
Collecting Jinja2>=3.0 (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached Jinja2-3.1.3-py3-none-any.whl.metadata (3.3 kB)
Collecting docutils>=0.19.0 (from -r requirements.txt (line 6))
  Using cached docutils-0.20.1-py3-none-any.whl.metadata (2.8 kB)
Collecting snowballstemmer>=2.0 (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached snowballstemmer-2.2.0-py2.py3-none-any.whl.metadata (6.5 kB)
Collecting babel>=2.9 (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached Babel-2.14.0-py3-none-any.whl.metadata (1.6 kB)
Collecting alabaster<0.8,>=0.7 (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached alabaster-0.7.16-py3-none-any.whl.metadata (2.9 kB)
Collecting imagesize>=1.3 (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached imagesize-1.4.1-py2.py3-none-any.whl.metadata (1.5 kB)
Collecting requests>=2.25.0 (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached requests-2.31.0-py3-none-any.whl.metadata (4.6 kB)
Collecting packaging>=21.0 (from Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached packaging-24.0-py3-none-any.whl.metadata (3.2 kB)
Collecting starlette>=0.35 (from sphinx-autobuild->-r requirements.txt (line 8))
  Using cached starlette-0.37.2-py3-none-any.whl.metadata (5.9 kB)
Collecting uvicorn>=0.25 (from sphinx-autobuild->-r requirements.txt (line 8))
  Using cached uvicorn-0.29.0-py3-none-any.whl.metadata (6.3 kB)
Collecting websockets>=11.0 (from sphinx-autobuild->-r requirements.txt (line 8))
  Using cached websockets-12.0-cp312-cp312-macosx_11_0_arm64.whl.metadata (6.6 kB)
Collecting colorama (from sphinx-autobuild->-r requirements.txt (line 8))
  Using cached colorama-0.4.6-py2.py3-none-any.whl.metadata (17 kB)
Collecting iniconfig (from pytest->-r requirements.txt (line 11))
  Using cached iniconfig-2.0.0-py3-none-any.whl.metadata (2.6 kB)
Collecting pluggy<2.0,>=1.4 (from pytest->-r requirements.txt (line 11))
  Using cached pluggy-1.4.0-py3-none-any.whl.metadata (4.3 kB)
Collecting coverage>=5.2.1 (from coverage[toml]>=5.2.1->pytest-cov->-r requirements.txt (line 12))
  Using cached coverage-7.4.4-cp312-cp312-macosx_11_0_arm64.whl.metadata (8.2 kB)
Collecting MarkupSafe>=2.0 (from Jinja2>=3.0->Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached MarkupSafe-2.1.5-cp312-cp312-macosx_10_9_universal2.whl.metadata (3.0 kB)
Collecting charset-normalizer<4,>=2 (from requests>=2.25.0->Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached charset_normalizer-3.3.2-cp312-cp312-macosx_11_0_arm64.whl.metadata (33 kB)
Collecting idna<4,>=2.5 (from requests>=2.25.0->Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached idna-3.7-py3-none-any.whl.metadata (9.9 kB)
Collecting urllib3<3,>=1.21.1 (from requests>=2.25.0->Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached urllib3-2.2.1-py3-none-any.whl.metadata (6.4 kB)
Collecting certifi>=2017.4.17 (from requests>=2.25.0->Sphinx!=6.1.0,!=6.1.1,>=5.1.1->-r requirements.txt (line 5))
  Using cached certifi-2024.2.2-py3-none-any.whl.metadata (2.2 kB)
Collecting anyio<5,>=3.4.0 (from starlette>=0.35->sphinx-autobuild->-r requirements.txt (line 8))
  Using cached anyio-4.3.0-py3-none-any.whl.metadata (4.6 kB)
Collecting click>=7.0 (from uvicorn>=0.25->sphinx-autobuild->-r requirements.txt (line 8))
  Using cached click-8.1.7-py3-none-any.whl.metadata (3.0 kB)
Collecting h11>=0.8 (from uvicorn>=0.25->sphinx-autobuild->-r requirements.txt (line 8))
  Using cached h11-0.14.0-py3-none-any.whl.metadata (8.2 kB)
Collecting sniffio>=1.1 (from anyio<5,>=3.4.0->starlette>=0.35->sphinx-autobuild->-r requirements.txt (line 8))
  Using cached sniffio-1.3.1-py3-none-any.whl.metadata (3.9 kB)
Using cached pygments-2.17.2-py3-none-any.whl (1.2 MB)
Using cached sphinx-7.2.6-py3-none-any.whl (3.2 MB)
Using cached docutils-0.20.1-py3-none-any.whl (572 kB)
Using cached sphinx_autobuild-2024.4.13-py3-none-any.whl (11 kB)
Using cached pytest-8.1.1-py3-none-any.whl (337 kB)
Using cached pytest_cov-5.0.0-py3-none-any.whl (21 kB)
Using cached alabaster-0.7.16-py3-none-any.whl (13 kB)
Using cached Babel-2.14.0-py3-none-any.whl (11.0 MB)
Using cached coverage-7.4.4-cp312-cp312-macosx_11_0_arm64.whl (206 kB)
Using cached imagesize-1.4.1-py2.py3-none-any.whl (8.8 kB)
Using cached Jinja2-3.1.3-py3-none-any.whl (133 kB)
Using cached packaging-24.0-py3-none-any.whl (53 kB)
Using cached pluggy-1.4.0-py3-none-any.whl (20 kB)
Using cached requests-2.31.0-py3-none-any.whl (62 kB)
Using cached snowballstemmer-2.2.0-py2.py3-none-any.whl (93 kB)
Using cached sphinxcontrib_htmlhelp-2.0.5-py3-none-any.whl (99 kB)
Using cached sphinxcontrib_serializinghtml-1.1.10-py3-none-any.whl (92 kB)
Using cached starlette-0.37.2-py3-none-any.whl (71 kB)
Using cached uvicorn-0.29.0-py3-none-any.whl (60 kB)
Using cached websockets-12.0-cp312-cp312-macosx_11_0_arm64.whl (121 kB)
Using cached colorama-0.4.6-py2.py3-none-any.whl (25 kB)
Using cached iniconfig-2.0.0-py3-none-any.whl (5.9 kB)
Using cached sphinxcontrib_applehelp-1.0.8-py3-none-any.whl (120 kB)
Using cached sphinxcontrib_devhelp-1.0.6-py3-none-any.whl (83 kB)
Using cached sphinxcontrib_jsmath-1.0.1-py2.py3-none-any.whl (5.1 kB)
Using cached sphinxcontrib_qthelp-1.0.7-py3-none-any.whl (89 kB)
Using cached anyio-4.3.0-py3-none-any.whl (85 kB)
Using cached certifi-2024.2.2-py3-none-any.whl (163 kB)
Using cached charset_normalizer-3.3.2-cp312-cp312-macosx_11_0_arm64.whl (119 kB)
Using cached click-8.1.7-py3-none-any.whl (97 kB)
Using cached h11-0.14.0-py3-none-any.whl (58 kB)
Using cached idna-3.7-py3-none-any.whl (66 kB)
Using cached MarkupSafe-2.1.5-cp312-cp312-macosx_10_9_universal2.whl (18 kB)
Using cached urllib3-2.2.1-py3-none-any.whl (121 kB)
Using cached sniffio-1.3.1-py3-none-any.whl (10 kB)
Installing collected packages: snowballstemmer, websockets, urllib3, sphinxcontrib-serializinghtml, sphinxcontrib-qthelp, sphinxcontrib-jsmath, sphinxcontrib-htmlhelp, sphinxcontrib-devhelp, sphinxcontrib-applehelp, sniffio, Pygments, pluggy, packaging, MarkupSafe, iniconfig, imagesize, idna, h11, docutils, coverage, colorama, click, charset-normalizer, certifi, babel, alabaster, uvicorn, requests, pytest, Jinja2, anyio, starlette, Sphinx, pytest-cov, sphinx-autobuild
Successfully installed Jinja2-3.1.3 MarkupSafe-2.1.5 Pygments-2.17.2 Sphinx-7.2.6 alabaster-0.7.16 anyio-4.3.0 babel-2.14.0 certifi-2024.2.2 charset-normalizer-3.3.2 click-8.1.7 colorama-0.4.6 coverage-7.4.4 docutils-0.20.1 h11-0.14.0 idna-3.7 imagesize-1.4.1 iniconfig-2.0.0 packaging-24.0 pluggy-1.4.0 pytest-8.1.1 pytest-cov-5.0.0 requests-2.31.0 sniffio-1.3.1 snowballstemmer-2.2.0 sphinx-autobuild-2024.4.13 sphinxcontrib-applehelp-1.0.8 sphinxcontrib-devhelp-1.0.6 sphinxcontrib-htmlhelp-2.0.5 sphinxcontrib-jsmath-1.0.1 sphinxcontrib-qthelp-1.0.7 sphinxcontrib-serializinghtml-1.1.10 starlette-0.37.2 urllib3-2.2.1 uvicorn-0.29.0 websockets-12.0
The venv has been created in the .venv directory
.venv/bin/sphinx-autobuild -b html -j auto  --re-ignore="/\.idea/|/venv/|/pep-0000.rst|/topic/" --open-browser --delay 0 peps build
Traceback (most recent call last):
  File "/Users/hugo/github/peps/.venv/bin/sphinx-autobuild", line 5, in <module>
    from sphinx_autobuild.__main__ import main
  File "/Users/hugo/github/peps/.venv/lib/python3.12/site-packages/sphinx_autobuild/__main__.py", line 22, in <module>
    from sphinx_autobuild.server import RebuildServer
  File "/Users/hugo/github/peps/.venv/lib/python3.12/site-packages/sphinx_autobuild/server.py", line 8, in <module>
    import watchfiles
ModuleNotFoundError: No module named 'watchfiles'
make: *** [html] Error 1

Oops, duplicate of https://github.com/sphinx-doc/sphinx-autobuild/pull/152, but this sorts the dependencies :)  Feel free to close this one.

Hmm... @AA-Turner I am no longer authorized to merge PRs on this repository, is that intentional?

As far as I can tell you should have permissions - I am on mobile currently sorry.
A

No worries! The buttons are available now -- thanks for checking and clicking whichever ones you've clicked!

https://github.com/sphinx-doc/sphinx-autobuild/pull/152 has been merged, so let's switch this to format and validate pyproject.toml instead.

Thanks for this PR @hugovk!
You'll likely want to also fix the state of the main branch on your fork, since you'd filed this PR from the force and this PR was squash-merged.

You're welcome and thanks for the warning!
(I made the PR from main because the CI prohibits testing from feature branches, and I like to test my changes on my fork before opening a PR. I recommend removing such restrictions.)
https://github.com/sphinx-doc/sphinx-autobuild/blob/b58c074eddda05a669d60755385a49a6e0717146/.github/workflows/ci.yml#L3-L6