Data Period Varies With History and Download Functions

Describe bug
When using .history or .download on specific tickers, the resulting OHLC data will be of inconsistent size with the incorrect current date. The issue is inconsistent and will flip from correct to incorrect within seconds. For example, today is 7/17/2024. Running the below loop code with a start date of 1/2/2023 will result in a dataframe from 1/2/2023 -> 7/17/2024 OR 1/2/2023 -> 7/16/2024. I have noticed this issue with only specific tickers including ^DJI and ^GSPC, Dow Jones Index and S&P500 Index, respectively. I have not seen this issue on company-specific tickers (e.g. AAPL, NVDA), or other index-like tickers (e.g. ^TNX (10-year treasury yield), ^VIX (volatility)). However, because of the problem's infrequent occurrence inconsistent results could have missed with other tickers.
To mitigate this issue to ensure correct downloads through to the current date, I wrote a separate application which simply queries the data frame's end-date, and if it does not match the current date will re-download via YFinance after waiting 20 seconds. It is a bandaid for the underlying issue.
I am uncertain if this issue is similar to 1982. That issue appears more with data inconsistency across the data frame, whereas this is how YF is calculating (or pulling) the end-date.
from datetime import datetime
import time
import yfinance as yf
import pytz

newYorkTz = pytz.timezone("America/New_York")

def check_for_yf_date_mismatch(df):
    # For unknown reasons, wrong dates can be pulled from Yfinance.
    # It appears to go away after a few seconds, so this programs ensures the correct
    # date is pulled, otherwise it will throw an error.
    last_period = df.iloc[[-1]].index.strftime('%Y-%m-%d')[0]
    now = datetime.now(newYorkTz).strftime('%Y-%m-%d')
    if last_period != now:
        return True
    else:
        return False

def yf_download_period(ticker, interval, data_period):
    data = yf.Ticker(ticker).history(interval=interval, period=data_period)
    for x in range(10):
        if check_for_yf_date_mismatch(data) == True:
            print('The incorrect date was found in YFinance data pull for: '+ticker+'. Attempting to re-download and correct.')
            time.sleep(20)
            data = yf.Ticker(ticker).history(interval=interval, period=data_period)
        else:
            break
    if check_for_yf_date_mismatch(data) == True: raise Exception('YF failed to pull the correct latest date. Multiple attempts were made to correct the dataset, with no success.')
    return data

Simple code that reproduces your problem
import yfinance as yf
import time

yf.enable_debug_mode()

for x in range (10):
    data = yf.Ticker('^DJI').history(interval='1d', start='2023-01-02')
    print(data.tail(1))
    time.sleep(5)

for x in range (10):
    data = yf.download('^DJI', interval='1d', start='2023-01-02')
    print(data.tail(1))
    time.sleep(5)

Debug log
DEBUG    Entering download()
DEBUG     Disabling multithreading because DEBUG logging enabled
DEBUG     Entering history()
DEBUG      Entering history()
DEBUG       ^DJI: Yahoo GET parameters: {'period1': '2023-01-02 00:00:00-05:00', 'period2': '2024-07-17 12:26:49-04:00', 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG       Entering get()
DEBUG        url=https://query2.finance.yahoo.com/v8/finance/chart/^DJI
DEBUG        params={'period1':<PHONE_NUMBER>, 'period2':<PHONE_NUMBER>, 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG        Entering _get_cookie_and_crumb()
DEBUG         cookie_mode = 'basic'
DEBUG         Entering _get_cookie_and_crumb_basic()
DEBUG          loaded persistent cookie
DEBUG          reusing cookie
DEBUG          crumb = 'ELQMuCjlz1x'
DEBUG         Exiting _get_cookie_and_crumb_basic()
DEBUG        Exiting _get_cookie_and_crumb()
DEBUG        response code=200
DEBUG       Exiting get()
DEBUG       ^DJI: yfinance received OHLC data: 2023-01-03 14:30:00 -> 2024-07-16 13:30:00
DEBUG       ^DJI: OHLC after cleaning: 2023-01-03 09:30:00-05:00 -> 2024-07-16 09:30:00-04:00
DEBUG       ^DJI: OHLC after combining events: 2023-01-03 00:00:00-05:00 -> 2024-07-16 00:00:00-04:00
DEBUG       ^DJI: yfinance returning OHLC: 2023-01-03 00:00:00-05:00 -> 2024-07-16 00:00:00-04:00
DEBUG      Exiting history()
DEBUG     Exiting history()
DEBUG    Exiting download()
                   Open          High          Low         Close     Adj Close     Volume
Date
2024-07-16  40263.78125  40988.808594  40263.78125  40954.480469  40954.480469  306390000
DEBUG    Entering download()
DEBUG     Disabling multithreading because DEBUG logging enabled
DEBUG     Entering history()
DEBUG      Entering history()
DEBUG       ^DJI: Yahoo GET parameters: {'period1': '2023-01-02 00:00:00-05:00', 'period2': '2024-07-17 12:26:54-04:00', 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG       Entering get()
DEBUG        url=https://query2.finance.yahoo.com/v8/finance/chart/^DJI
DEBUG        params={'period1':<PHONE_NUMBER>, 'period2':<PHONE_NUMBER>, 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG        Entering _get_cookie_and_crumb()
DEBUG         cookie_mode = 'basic'
DEBUG         Entering _get_cookie_and_crumb_basic()
DEBUG          reusing cookie
DEBUG          reusing crumb
DEBUG         Exiting _get_cookie_and_crumb_basic()
DEBUG        Exiting _get_cookie_and_crumb()
DEBUG        response code=200
DEBUG       Exiting get()
DEBUG       ^DJI: yfinance received OHLC data: 2023-01-03 14:30:00 -> 2024-07-16 13:30:00
DEBUG       ^DJI: OHLC after cleaning: 2023-01-03 09:30:00-05:00 -> 2024-07-16 09:30:00-04:00
DEBUG       ^DJI: OHLC after combining events: 2023-01-03 00:00:00-05:00 -> 2024-07-16 00:00:00-04:00
DEBUG       ^DJI: yfinance returning OHLC: 2023-01-03 00:00:00-05:00 -> 2024-07-16 00:00:00-04:00
DEBUG      Exiting history()
DEBUG     Exiting history()
DEBUG    Exiting download()
                   Open          High          Low         Close     Adj Close     Volume
Date
2024-07-16  40263.78125  40988.808594  40263.78125  40954.480469  40954.480469  306390000
DEBUG    Entering download()
DEBUG     Disabling multithreading because DEBUG logging enabled
DEBUG     Entering history()
DEBUG      Entering history()
DEBUG       ^DJI: Yahoo GET parameters: {'period1': '2023-01-02 00:00:00-05:00', 'period2': '2024-07-17 12:27:00-04:00', 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG       Entering get()
DEBUG        url=https://query2.finance.yahoo.com/v8/finance/chart/^DJI
DEBUG        params={'period1':<PHONE_NUMBER>, 'period2':<PHONE_NUMBER>, 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG        Entering _get_cookie_and_crumb()
DEBUG         cookie_mode = 'basic'
DEBUG         Entering _get_cookie_and_crumb_basic()
DEBUG          reusing cookie
DEBUG          reusing crumb
DEBUG         Exiting _get_cookie_and_crumb_basic()
DEBUG        Exiting _get_cookie_and_crumb()
DEBUG        response code=200
DEBUG       Exiting get()
DEBUG       ^DJI: yfinance received OHLC data: 2023-01-03 14:30:00 -> 2024-07-17 16:26:59
DEBUG       ^DJI: OHLC after cleaning: 2023-01-03 09:30:00-05:00 -> 2024-07-17 12:26:59-04:00
DEBUG       ^DJI: OHLC after combining events: 2023-01-03 00:00:00-05:00 -> 2024-07-17 00:00:00-04:00
DEBUG       ^DJI: yfinance returning OHLC: 2023-01-03 00:00:00-05:00 -> 2024-07-17 00:00:00-04:00
DEBUG      Exiting history()
DEBUG     Exiting history()
DEBUG    Exiting download()
                    Open          High           Low        Close    Adj Close     Volume
Date
2024-07-17  40862.601562  41190.089844  40849.710938  41178.46875  41178.46875  200886637
DEBUG    Entering download()
DEBUG     Disabling multithreading because DEBUG logging enabled
DEBUG     Entering history()
DEBUG      Entering history()
DEBUG       ^DJI: Yahoo GET parameters: {'period1': '2023-01-02 00:00:00-05:00', 'period2': '2024-07-17 12:27:05-04:00', 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG       Entering get()
DEBUG        url=https://query2.finance.yahoo.com/v8/finance/chart/^DJI
DEBUG        params={'period1':<PHONE_NUMBER>, 'period2':<PHONE_NUMBER>, 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG        Entering _get_cookie_and_crumb()
DEBUG         cookie_mode = 'basic'
DEBUG         Entering _get_cookie_and_crumb_basic()
DEBUG          reusing cookie
DEBUG          reusing crumb
DEBUG         Exiting _get_cookie_and_crumb_basic()
DEBUG        Exiting _get_cookie_and_crumb()
DEBUG        response code=200
DEBUG       Exiting get()
DEBUG       ^DJI: yfinance received OHLC data: 2023-01-03 14:30:00 -> 2024-07-17 16:27:04
DEBUG       ^DJI: OHLC after cleaning: 2023-01-03 09:30:00-05:00 -> 2024-07-17 12:27:04-04:00
DEBUG       ^DJI: OHLC after combining events: 2023-01-03 00:00:00-05:00 -> 2024-07-17 00:00:00-04:00
DEBUG       ^DJI: yfinance returning OHLC: 2023-01-03 00:00:00-05:00 -> 2024-07-17 00:00:00-04:00
DEBUG      Exiting history()
DEBUG     Exiting history()
DEBUG    Exiting download()
                    Open          High           Low         Close     Adj Close     Volume
Date
2024-07-17  40862.601562  41190.089844  40849.710938  41174.230469  41174.230469  200936832
DEBUG    Entering download()
DEBUG     Disabling multithreading because DEBUG logging enabled
DEBUG     Entering history()
DEBUG      Entering history()
DEBUG       ^DJI: Yahoo GET parameters: {'period1': '2023-01-02 00:00:00-05:00', 'period2': '2024-07-17 12:27:10-04:00', 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG       Entering get()
DEBUG        url=https://query2.finance.yahoo.com/v8/finance/chart/^DJI
DEBUG        params={'period1':<PHONE_NUMBER>, 'period2':<PHONE_NUMBER>, 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG        Entering _get_cookie_and_crumb()
DEBUG         cookie_mode = 'basic'
DEBUG         Entering _get_cookie_and_crumb_basic()
DEBUG          reusing cookie
DEBUG          reusing crumb
DEBUG         Exiting _get_cookie_and_crumb_basic()
DEBUG        Exiting _get_cookie_and_crumb()
DEBUG        response code=200
DEBUG       Exiting get()
DEBUG       ^DJI: yfinance received OHLC data: 2023-01-03 14:30:00 -> 2024-07-17 16:27:09
DEBUG       ^DJI: OHLC after cleaning: 2023-01-03 09:30:00-05:00 -> 2024-07-17 12:27:09-04:00
DEBUG       ^DJI: OHLC after combining events: 2023-01-03 00:00:00-05:00 -> 2024-07-17 00:00:00-04:00
DEBUG       ^DJI: yfinance returning OHLC: 2023-01-03 00:00:00-05:00 -> 2024-07-17 00:00:00-04:00
DEBUG      Exiting history()
DEBUG     Exiting history()
DEBUG    Exiting download()
                    Open          High           Low    Close  Adj Close     Volume
Date
2024-07-17  40862.601562  41190.089844  40849.710938  41172.0    41172.0  200971412
DEBUG    Entering download()
DEBUG     Disabling multithreading because DEBUG logging enabled
DEBUG     Entering history()
DEBUG      Entering history()
DEBUG       ^DJI: Yahoo GET parameters: {'period1': '2023-01-02 00:00:00-05:00', 'period2': '2024-07-17 12:27:15-04:00', 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG       Entering get()
DEBUG        url=https://query2.finance.yahoo.com/v8/finance/chart/^DJI
DEBUG        params={'period1':<PHONE_NUMBER>, 'period2':<PHONE_NUMBER>, 'interval': '1d', 'includePrePost': False, 'events': 'div,splits,capitalGains'}
DEBUG        Entering _get_cookie_and_crumb()
DEBUG         cookie_mode = 'basic'
DEBUG         Entering _get_cookie_and_crumb_basic()
DEBUG          reusing cookie
DEBUG          reusing crumb
DEBUG         Exiting _get_cookie_and_crumb_basic()
DEBUG        Exiting _get_cookie_and_crumb()
DEBUG        response code=200
DEBUG       Exiting get()
DEBUG       ^DJI: yfinance received OHLC data: 2023-01-03 14:30:00 -> 2024-07-16 13:30:00
DEBUG       ^DJI: OHLC after cleaning: 2023-01-03 09:30:00-05:00 -> 2024-07-16 09:30:00-04:00
DEBUG       ^DJI: OHLC after combining events: 2023-01-03 00:00:00-05:00 -> 2024-07-16 00:00:00-04:00
DEBUG       ^DJI: yfinance returning OHLC: 2023-01-03 00:00:00-05:00 -> 2024-07-16 00:00:00-04:00
DEBUG      Exiting history()
DEBUG     Exiting history()
DEBUG    Exiting download()
                   Open          High          Low         Close     Adj Close     Volume
Date
2024-07-16  40263.78125  40988.808594  40263.78125  40954.480469  40954.480469  306390000

Bad data proof
Open          High           Low         Close     Volume  Dividends  Stock Splits
Date
2024-07-17 00:00:00-04:00  40862.601562  41190.089844  40849.710938  41165.628906  197533095        0.0           0.0
                                  Open          High          Low         Close     Volume  Dividends  Stock Splits
Date
2024-07-16 00:00:00-04:00  40263.78125  40988.808594  40263.78125  40954.480469  306390000        0.0           0.0
                                   Open          High           Low         Close     Volume  Dividends  Stock Splits
Date
2024-07-17 00:00:00-04:00  40862.601562  41190.089844  40849.710938  41169.261719  197622476        0.0           0.0
                                  Open          High          Low         Close     Volume  Dividends  Stock Splits
Date
2024-07-16 00:00:00-04:00  40263.78125  40988.808594  40263.78125  40954.480469  306390000        0.0           0.0
                                   Open          High           Low         Close     Volume  Dividends  Stock Splits
Date
2024-07-17 00:00:00-04:00  40862.601562  41190.089844  40849.710938  41170.808594  197722027        0.0           0.0
                                   Open          High           Low         Close     Volume  Dividends  Stock Splits
Date
2024-07-17 00:00:00-04:00  40862.601562  41190.089844  40849.710938  41167.789062  197758748        0.0           0.0
                                   Open          High           Low         Close     Volume  Dividends  Stock Splits
Date
2024-07-17 00:00:00-04:00  40862.601562  41190.089844  40849.710938  41161.671875  197817592        0.0           0.0
                                  Open          High          Low         Close     Volume  Dividends  Stock Splits
Date
2024-07-16 00:00:00-04:00  40263.78125  40988.808594  40263.78125  40954.480469  306390000        0.0           0.0
                                   Open          High           Low         Close     Volume  Dividends  Stock Splits
Date
2024-07-17 00:00:00-04:00  40862.601562  41190.089844  40849.710938  41164.621094  197897898        0.0           0.0
                                  Open          High          Low         Close     Volume  Dividends  Stock Splits
Date
2024-07-16 00:00:00-04:00  40263.78125  40988.808594  40263.78125  40954.480469  306390000        0.0           0.0

yfinance version
0.2.40
Python version
3.9
Operating system
No response

Try setting end to tomorrow.

This successfully fixed the issue. I would argue the underlying bug still exists as it is odd the program will flip back and forth between the end date, however the solution is simple enough where a further dive into the issue is not warranted. Here is example code I used to overcome the issue when repeatedly pulling data through today's current date.
newYorkTz = pytz.timezone("America/New_York")
tomorrow = (datetime.now(newYorkTz) + timedelta(days=1)).strftime('%Y-%m-%d')
data = yf.Ticker('^DJI').history(interval='1d', start='2023-01-02', end=tomorrow)```

You could change default to tomorrow #1084


ARM wheels for macosx and manylinux

As a follow-up to #66 and #73, we still need to add ARM support to our automated CI for building wheels via cibuildwheel. Specifically, I would like suitesparse-graphblas to have wheels for every 64-bit platform that the latest NumPy has wheels for. Right now, this means adding the following wheels:
cp38-cp38-macosx_11_0_arm64.whl
cp38-cp38-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
cp39-cp39-macosx_11_0_arm64.whl
cp39-cp39-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
cp310-cp310-macosx_11_0_arm64.whl
cp310-cp310-manylinux_2_17_aarch64.manylinux2014_aarch64.whl
cp311-cp311-macosx_11_0_arm64.whl
cp311-cp311-manylinux_2_17_aarch64.manylinux2014_aarch64.whl

CC @alugowski and @jim22k who added wheel building via cibuildwheel and may want to follow this issue.

I created a PR for macos ARM wheels.
That approach creates universal2 versions of libomp and libgraphblas so they can be linked against both x86 and arm code. cibuildwheel has proper cross-compilation support for everything else (cython, extensions, etc).
It's a bit hacky, but once GitHub Actions has M1 runners, promised Q4 2023 https://github.com/github/roadmap/issues/528 , then the hack can go away.

For Linux aarch64, cibuildwheel has simple instructions on how to do it with emulation. See https://cibuildwheel.readthedocs.io/en/stable/faq/#emulation if someone wants to take a stab at it.

Build time. The aarch64 wheel job failed the first time and I had to retry. Building SuiteSparse:GraphBLAS took about 5.5 hours, and this didn't leave enough time to compile and build the Python package. The retried job finished in 5 hours and 14 minutes. Let's keep an eye on how often we need to retry and to see if we can speed it up somehow (or break it into multiple jobs, or do a step in parallel).

Ouch, I hoped 45 minutes is enough margin. I'd suggest taking out one more optimized type for aarch64. Out of the 4 left optimized I'd take out INT8. Do it for your own sanity, you don't want to be stuck with an unreliable workflow. I tried the same types as x86 (reached 70%), just one type (about 2.5 hours-ish, IIRC) and the four types you see in the PR. Three should be reliable. I know I'm a broken record on this, but build times do matter and at some point optimizing everything isn't practical. Given how long that build takes, each iteration is basically a day.
QEMU emulates one virtual core, so there is no parallelism to be had.
You probably can do a regular cross-compile. That would make the build take the same amount of time as the native one.  It's not trivial like it is on macOS, but should be doable. Install a cross-compiling GCC with https://packages.ubuntu.com/jammy/g++-aarch64-linux-gnu and then make a CMake toolchain file.  You'd have to run that before cibw, only on aarch64. It'll be a lot of fiddling that I don't have the stomach for given the build time, hence why I abandoned this approach. But it is an option.

MacOS wheel sizes. I think the way we currently build SuiteSparse:GraphBLAS on osx for arm64 and x86_64 at the same time makes both wheels twice the size they need to be. I think this uses about 400MB extra for each release, which is non-trivial. @alugowski how difficult would it be to split up builds for osx arm64 and x86_64?
https://pypi.org/project/suitesparse-graphblas/<IP_ADDRESS>a0/#files

Is it a problem, though?
It is temporary, as moving to a native ARM runner when they're available will make this easy to fix. PyPI accepts the files, the build runtimes are the same, so does the extra size impact something? It does use a bit more space for the end user, but I don't think it's a show stopper for anyone. And if it is, they can link against their own. Note that when I followed the SuiteSparse instructions on how to build SuiteSparse:GraphBLAS it ended up using 1 GB. So I'm not too bothered about wasting ~120 MB, which is the uncompressed single architecture libgraphblas.dylib size.
We could take the aarch64 approach and build only one architecture on each. That way the build sizes will not get inflated. The benefit is that the workflow will be nearly the same as if ARM runners were available, so that move will be even easier later. The downside is that it's impossible to automatically test ARM wheels on GitHub, and the more this workflow diverges from x86 the more likely you'll ship broken wheels at some point.

All these issues go away with GraphBLAS 8's JIT.
One FYI on that, from Tim's email it seems like it's using the system compiler. We took a similar JIT approach with KDT about a decade ago, and the problem was that some systems didn't have a compiler. Even in HPC world, the compilers would live only on the head node and the JIT would get triggered on the compute nodes. AFAIK neither Windows nor macOS have compilers by default, and many Linux docker images don't include one either. It's a one-line install on macOS and Linux, but that's something that needs to be documented.

Don't drop FP32. pygraphblas examples use it so anyone who learns from those tutorials or uses them as the basis for their own code will use it too. Hot take: bool is mostly used by people who don't know iso matrices exist.
If parallel builds were low hanging fruit then cibuildwheel would be doing it. GitHub has massive monetary incentive to help them, too. I believe cibw throws everything for one architecture into a container (or QEMU VM) then loops python versions in the container. So even if you added parallelism to that loop you'd still have one QEMU core. I can't think of a way to do it besides using more runners.
Linux runners have 2 cores (macos has 3), and you'd be parallelizing only the fast part, so there is little potential upside anyway.

I disagree about BOOL. We use BOOL regularly in graphblas-algorithms for, you know, doing boolean logic.
I suppose some benchmarks may prefer to use FP32 (benchmarks may also want to use smaller int types too).
Replaced INT8 with BOOL in #86.

We (i.e. @jim22k) can (probably) manually test macos arm wheels if necessary.

I wrote up what I think split macos runners would like: https://github.com/alugowski/python-suitesparse-graphblas/tree/splitarm
We can test the artifact when the build finishes: https://github.com/alugowski/python-suitesparse-graphblas/actions/runs/4886558542/jobs/8722055829

Ran another job with only the arm64 build: https://github.com/alugowski/python-suitesparse-graphblas/actions/runs/4887294770
It works on my machine so I made a PR.

I guess our disagreement is that my suspicion is that the intersection of "absolutely can't install a compiler" and "fallback is too slow" is effectively non-existent. Sounds like you may know of important users in that intersection, and that's fine.

I worry the big benefits of the JIT will be missed from taking easy half measures.

Like what? By planning to continue to pre-compiled operations as is done today? I don't want to hobble the current experience by expecting everyone to use a JIT. This isn't either/or--we can support both.

(Assuming, of course, that the JIT offers a comparable experience to today.)
Just pointing out that there are costs of supporting both. Tests have to verify both. There's a 6-hour build step. Very large codebase size. Though that's largely not my problem (if I can pull myself away from trying to solve these build issues :P) so I'll keep my advocacy at a minimum.
My worry is that with two available paths parts of the ecosystem will only support the easier one (pre-compiled) even if they could support the JIT too. (That includes us, figuring out available compilers may be tricky)
That would make the JIT an option with a chicken-and-egg problem. If you write library code you now can't assume JIT performance or features. That means potentially more complex code that only uses the supplied types/semirings, or you have to write the same operation twice.
Example: Aydin and I had a lot of generic graph traversal code use what we called a "select 2nd" "semiring". Not a true mathematical semiring, but it meant we could do BFS and other algorithms that only cared about the existence of edges and worked on any datatype, numeric or UDT. It also optimized well because it didn't read one of the arguments. If I wrote that in graphblas today the code would need the JIT. Users without the JIT would think I'm lying about my performance claims.

Python is very diverse

Oh god how true that is :)

Everything looks great as far as we can tell. Closing 🚀

Wow that's a big difference with BOOL :)
Gotta say, this feels very luxurious:
(venv) notchie ~/temp (:|✔) % pip install suitesparse-graphblas==<IP_ADDRESS>a1
Collecting suitesparse-graphblas==<IP_ADDRESS>a1
  Using cached suitesparse_graphblas-<IP_ADDRESS>a1-cp311-cp311-macosx_11_0_arm64.whl (45.2 MB)
Collecting cffi>=1.11 (from suitesparse-graphblas==<IP_ADDRESS>a1)
  Using cached cffi-1.15.1-cp311-cp311-macosx_11_0_arm64.whl (174 kB)
Collecting numpy>=1.19 (from suitesparse-graphblas==<IP_ADDRESS>a1)
  Using cached numpy-1.24.3-cp311-cp311-macosx_11_0_arm64.whl (13.8 MB)
Collecting pycparser (from cffi>=1.11->suitesparse-graphblas==<IP_ADDRESS>a1)
  Using cached pycparser-2.21-py2.py3-none-any.whl (118 kB)
Installing collected packages: pycparser, numpy, cffi, suitesparse-graphblas
Successfully installed cffi-1.15.1 numpy-1.24.3 pycparser-2.21 suitesparse-graphblas-<IP_ADDRESS>a1


windows: avoids GetLastError as goroutine != thread

per advice from @wdvxdr1123
Fixes #377

future improvements welcome also! merging now as tests are breaking


Use the same version of Gradle wrapper for smoke-tests

We need to have a Gradle wrapper for running smoke tests and have it the same version as in the main build. Otherwise, we're going to face interesting bugs sooner or later.
So, we need to update gradle/wrapper and tools/smoke-tests/gradle/wrapper and corresponding shell scripts together.
Options are:

Special shell script in the root directory, which would do

./gradlew wrapper --gradle-version 4.10.1
./tools/smoke-tests/gradlew wrapper --gradle-version 4.10.1

Updating the wrapper for smoke-tests from within the build.
Something else?

@dmdashenkov, isn't it already fixed by the recently introduced buildSrc arrangement?

It seems like smoke-tests still have their own Gradle wrapper.

No longer relevant.


About the running time

During the detection phase, 50 training batches were set up by running the run_training.sh file, and the program was stuck in the following interface.
I want to ask, what is this program used for, because I only use two gpus, is the program itself needs time, or is the program stuck here?

You can check the GPU, CPU, memory use of the process. Maybe it is because the model is not well trained and the number of proposals is too big. I have two suggestions: 1 check which line is the code stuck 2 use 150 epochs to get a good model.

I want to ask, what is the function of the following code, can I remove it? My program will be stuck here when it runs.

It is test for the saved models.

If you do not want to test and just want to get the trained model, you can definitely comment them.


Simplify container usage

Pimple exceptions are now PSR-11 compliant.  This means that we don't need to wrap its exceptions in our own, to ensure we throw exceptions which implement this relevant interfaces.  This PR removes code which did that, while bumping the Pimple version.

Coverage decreased (-0.1%) to 92.924% when pulling cdad3ffc72be5878038992e783ee6ac9ba7b5c44 on Sam-Burns:simplify-container-usage into ee32eb61a2c4aa4c6b1594ba1cc3e9d7aaf0bd3f on slimphp:4.x.

Sorry, but this becomes moot with https://github.com/slimphp/Slim/pull/2290…


Azure__SignalR__StickyServerMode

Hi.
Should Azure__SignalR__StickyServerMode be turned on or off when using the SignalR service - https://docs.microsoft.com/en-us/aspnet/core/signalr/scale?view=aspnetcore-3.1#sticky-sessions says no, but the auto-generated app service keys have set "Azure__SignalR__StickyServerMode" to "Required".
If it is not required - what is the value to enter into "Azure__SignalR__StickyServerMode", is it "NotRequired" or what is it?
Thanks.

For blazor apps it is Required, for other SignalR scenarios, it is not suggested.

For blazor apps it is Required, for other SignalR scenarios, it is not suggested.

Thanks for the answer. So what is the value to enter into Azure__SignalR__StickyServerMode? Only "Required" is documented, but not its inverse. And I'd rather leave the key there to be explicit.
Thanks.

Please check it here https://github.com/Azure/azure-signalr/blob/dev/docs/use-signalr-service.md#serverstickymode

Please check it here https://github.com/Azure/azure-signalr/blob/dev/docs/use-signalr-service.md#serverstickymode

Thank you. There's lots of documents mentioning "Required" but I hadn't seen that one. It might make sense to combine the documents into one place at some point as the docs are extremely spread out atm.
One more question - the document you linked to says this of "Preferred": "This one can be useful when your scenario is send to connection". What does 'send to connection' mean? If I predominantly send to Groups, does it count as 'send to connection', which case the option "Preferred" would probably yield best performance?
Thanks again.

I don't know what the document means with send to connection as it's not mentioned anywhere else so it's not an established term. All messages go via a connection, or does it mean sending to a connection id (as opposed to a group for example)? In that case why would "Preferred" be better for that but not for groups? I'm so confused by the documentation.
But yeah, ultimately I just want to know if I mainly send messages to groups, where a group in my context is a single account (with all active devices in the same group), is "Preferred" or "Disabled" better?
Thanks.

send to connection

Yes, it is sending to a connection id specifically

if I mainly send messages to groups, where a group in my context is a single account (with all active devices for an account in the same group), is "Preferred" or "Disabled" better?

There is no difference for it, you actually don't need to set it, leave it as its default value is enough.
Just curious, how you find out Azure__SignalR__StickyServerMode this variable since you are not using Blazor App?

Please feel free to reopen it if you still have any concerns about it.


ImportError: No module named 'train_util'

I'm getting this import error when I try to train the privileged agent, and I couldn't find the implementation of this module anywhere in the code. Is this from some library that I'm not aware of? Thanks!

And I also meet the error, the solution is below:
open train_birdview.py and modify the code line
from utils.train_utils import one_hot


Html report

How to do html report over tests.

I think you should have a look at the phpunit parameters,
https://phpunit.de/manual/current/en/textui.html


Refactor User_AddBillingCard in App

Details

Updates the form component to use isLoading and error since we are standardizing on those keys
Add new addPaymentCard method

cc @thienlnam will you please review?
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/216148
Tests

Login
Navigate to Settings > Payments > Add payment method > Debit card
Fill the form with any details, but use 4242 4242 4242 4242 for the card number
Verify that you are able to successfully add the card and are navigated back to the Payments screen
Tap Add payment method > Debit card again, but this time use 2222 4200 0000 1113 for card number
Verify that you get an error
Turn your internet connection off
Verify that the submit button is disabled and on mobile you should see You appear to be offline below the submit button

[x] Verify that no errors appear in the JS console

PR Review Checklist
Contributor (PR Author) Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] iOS / native
[x] Android / native
[x] iOS / Safari
[x] Android / Chrome
[x] MacOS / Chrome
[x] MacOS / Desktop

[x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[x] I verified any copy / text shown in the product was added in all src/languages/* files
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] Any functional components have the displayName property
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose and it is

[x] If a new CSS style is added I verified that:

[x] A similar style doesn’t already exist
[x] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

PR Reviewer Checklist

[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] iOS / native
[ ] Android / native
[ ] iOS / Safari
[ ] Android / Chrome
[ ] MacOS / Chrome
[ ] MacOS / Desktop

[ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
[ ] I verified any copy / text shown in the product was added in all src/languages/* files
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] Any functional components have the displayName property
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn’t already exist
[ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps
Same as test steps

[ ] Verify that no errors appear in the JS console

Screenshots

Web
https://user-images.githubusercontent.com/22219519/183999891-bedd9756-54d6-4b16-9767-283f8af380ef.mov
Mobile Web
https://user-images.githubusercontent.com/22219519/184005990-ac423a74-0197-4058-8d58-7855de4b055a.mov
Desktop
https://user-images.githubusercontent.com/22219519/183999981-e10535d3-d7f5-4299-844a-ac083098b421.mov
iOS
https://user-images.githubusercontent.com/22219519/184006011-979aaa9d-368f-46a3-86c5-b97692f54ddc.mov
Android
https://user-images.githubusercontent.com/22219519/184006039-3d1c83f3-425c-4365-a172-f24c83014758.mov

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

AH I should have put a hold on this one! The Web-E PR is still not merged/in prod, so we needed to wait to merge this one. Sorry, my bad!

Oof, sorry!! 😬 Do we need to revert, or is it okay to let it ride?

I just merged the Web-E PR, this isn't deployed to staging yet and there isn't a web deploy today due to earnings call
I think we can let it sit and if needed we can just CP the Web-E PR tommorow

I agree. We can CP the Web-E PR to prod when the App PR hits staging (since staging uses the prod API).


Open source contributor's guide: update or pare down

Problem description

Open source contributor's guide in docs is out-of-date. We should bring these docs up to date or remove them.

Problem location
https://docs.docker.com/opensource/
https://docs.docker.com/opensource/code/
Related issues
https://github.com/docker/docker.github.io/issues/205
https://github.com/docker/docker.github.io/issues/218
FYI, collaborators
@mstanleyjones @johndmulhausen

Hi, I am working on the Moby Project transition - see https://github.com/moby/moby/issues/35115 - and cleaning up our docs and in particular clearing up the relation between Docker and Moby.
My view is that we should remove all of this section except a short link and explanation of the Moby Project, and we should move the relevant pieces into the moby/moby repo, ie the details of how to work with the repo.

I am half way through updating the contributing guide, see https://github.com/moby/moby/pull/35168 which needs to clear this up....


Unskip test_exchange_fees.

Fixes #1189  .
Changes proposed in this PR:

updated attributes, removed timeouts.
test new ganache from of barge (see https://github.com/oceanprotocol/barge/pull/342)

Thanks for the update.

I wanted to have the changes already here and wait for barge issue to be merged.

I will review this issue after the following happens. Perhaps you can make it happen?

review the barge PR
help see it get merged into main
re-test here on barge main

I ran these tests locally with the new barge branch from https://github.com/oceanprotocol/barge/pull/345 and they passed all right. Hopefully this is fixed now, I am fairly certain it is. However, with these kinds of byzantine errors, there is never a 100% guarantee. Let's reopen if needed.


Ask for PointGroup results

Dear authors,
Thanks for your great job! I now want to do some tiny modification which relies on the PointGroup segmentation results. However, the attributes files only contain the bbox results. Therefore, i wonder if you can provide the segmentation results with the semantic classification of the raw 607 types.

You can download the segmentation results provided by InstanceRefer (Data preparation - Step 4) as we did.

Great! Thanks for your prompt!


SwiftMailer Error

When creating users, the BlogifyMailer service class attempts to send email but throws a Swift_TransportException, Cannot send message without a sender address

Mail
Blogify will send mails at important moments so make sure to configure the settings for your mail driver in the ".env" file of your project.
For more information please check out the official Laravel documentation.
http://www.blogify.io/docs/configuration


fix cmake windows py27 import fail

fix cmake windows py27 import fail

Nagging Assignee @protoget: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 45 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @protoget: It has been 60 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

update to 1.9.0, please review.

Nagging Assignee @protoget: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.


Picker.Item missing testID

Note: transferred from https://github.com/facebook/react-native/issues/22084
Environment
React Native Environment Info:
System:
  OS: macOS High Sierra 10.13.6
  CPU: x64 Intel(R) Core(TM) i7-4750HQ CPU @ 2.00GHz
  Memory: 82.27 MB / 8.00 GB
  Shell: 3.2.57 - /bin/bash
Binaries:
  Node: 8.11.3 - /usr/local/bin/node
  npm: 5.6.0 - /usr/local/bin/npm
SDKs:
  iOS SDK:
    Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
IDEs:
  Xcode: 10.0/10A255 - /usr/bin/xcodebuild
npmPackages:
  react: 16.6.0-alpha.8af6728 => 16.6.0-alpha.8af6728
  react-native: 0.57.4 => 0.57.4
npmGlobalPackages:
  react-native-cli: 2.0.1
  react-native-git-upgrade: 0.2.7

Description
As you can see PickerIOS.Item does not have a testID, even though Picker.Item does.
Picker
type PickerItemProps = $ReadOnly<{|
  /**
   * Text to display for this item.
   */
  label: string,

  /**
   * The value to be passed to picker's `onValueChange` callback when
   * this item is selected. Can be a string or an integer.
   */
  value?: any,

  /**
   * Color of this item's text.
   * @platform android
   */
  color?: ColorValue,

  /**
   * Used to locate the item in end-to-end tests.
   */
  testID?: string,
|}>;

PickerIOS
type ItemProps = $ReadOnly<{|
  label: ?Label,
  value?: ?any,
  color?: ?ColorValue,
|}>;

So I can't find the Items using Detox

@thymikee did you managed to work around this issue?

:tada: This issue has been resolved in version 1.9.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Python package 'future' required to run rosprolog_commandline.py in ROS melodic (python 2.7)

Description
When trying to use rosprolog_commandline.py, I get the following error:
$ rosrun rosprolog rosprolog_commandline.py
Traceback (most recent call last):
  File "/home/parallels/harsh_knowrob_ws/src/rosprolog/scripts/rosprolog_commandline.py", line 6, in <module>
    from builtins import input
ImportError: No module named builtins

Your environment

ROS distro: melodic
OS version: Ubuntu 18.04
Python 2.7

Steps to reproduce

Install knowrob according to README
start knowrob with roslaunch knowrob knowrob.launch
In a new terminal, run rosrun rosprolog rosprolog_commandline.py

Suggested approach
Include python package future in the installation requirements

Hello Carlos,
thanks for the report!
I added "python-future" to package.xml#run_depend of rosprolog.
That should fix the problem, I think.
Best,
Daniel

Hello Carlos,
thanks for the report!
I added "python-future" to package.xml#run_depend of rosprolog.
That should fix the problem, I think.
Best,
Daniel


Widget not sizing itself to parent element size

I'm rendering a typeform in a flex container and I want the typeform widget to expand to fill that container which is the behavior I expected after reading this issue.
But that isn't happening. I've tried styling with style: {} and that's not working either
See screenshots below for example
The parent container (pink) when highlighted in chrome dev tools. You can see the form (black) is only taking up the minimum height).

The DOM for more details. The parent element is the  one that wraps the widget

What's the right way to get the widget to fill the height of the container?
Using the latest version of the package in a next.js project. Not passing in any props besides id, hidden, and onReady to the widget component

I ended up just using a popupbutton which would let me set size=100
Still feels strange that the default widget won't let you set width and height to 100%. it seems like it expects absolutes sizes only which is inconvenient if you're trying to fill the container.
The only way to get that is to measure the parent div sizes in client side after the initial render.  Doing that causes jank because the form won't be there at first and it would appear later
Again, my issue is solved because it seemed more appropriate for me to just use popupbutton which does this easily.
Let me know if you'd like to me keep this issue open and I'll reopen it

The widget will automatically takes size of its parent element. Or you can specify CSS manually to size it as you wish. The parent element is the
 that you use to define your widget.
You just add CSS like this for custom size:

Or for a full screen widget like this:

See CodeSandbox example here: https://codesandbox.io/s/xenodochial-framework-uh2roo?file=/index.html


Finalize production deployment capabilities

Feature description:
Finalize capabilities to deploy an Opyrator to a cloud platform.
Rolling out your Opyrators for production usage might require additional features such as SSL, authentication, API tokens, unlimited scalability, load balancing, and monitoring. Therefore, we provide capabilities to easily  deploy your Opyrators directly on scalable and secure cloud platforms without any major overhead.
The deployment can be executed via command line:
opyrator deploy my_opyrator:hello_world <deployment-provider> <deployment-provider-options>

In the absence of this feature, is there a way to deploy this to Azure?

How and where we can deploy this?
Is it possible to deploy on streamlit?
What are the  in below command-
opyrator deploy my_opyrator:hello_world <deployment-provider> <deployment-provider-options>
Except cloud platform like azure etc. Is there any other platform like streamlit to deploy Opyrator UI and API apps?


Change default to skip activation of packages that will be removed after next login

After recent Steam change, certain free licenses (e.g. demos) are now automatically removed upon each login. Therefore it makes little sense to activate them, I think it'd make sense to skip them from activation, or if somebody really has some pointless urge (since they'll be removed anyway), then maybe make it configurable behind some boolean property.

Demos are now filtered out unless the user has a filter which explicitly applies to Demos.
A few demos weren't removed from my account, these seem to be mostly demos for unreleased games and I imagine they'll be removed eventually.  Though I have found some exceptions:

Attack on Titan 2 - A.O.T.2 - Demo, A demo which doesn't have an app type of "Demo".  Technically these are games and not demos, so these won't be filtered out by default.
Tom Clancy’s Rainbow Six Extraction Demo, A demo which is packaged with free DLC.  As the package has multiple apps in it, and as some of these aren't Demos, this won't be filtered out by default.
Hidden Motives: The Diamond Rush Collector's Edition Demo, A demo which was released this month, but for a game released back in 2021.  There's more of this kind for a bunch of other games by the same developer, some of which have been removed.  These will be filtered out as they seem special for no discernible reason.

It might also be worth pointing out that when you attempt to re-activate a removed demo, it appears temporarily on the "Licenses and product key activations" page with the activation date it originally had.  This is the same sort of behaviour that has always existed with respect to deactivated demos.
If anyone wants to continue adding demos to their account, it probably makes the most sense to only add newly released demos, which you can do using a filter like this:
"FreePackagesFilters": [{
    "Types": ["Demo"],
    "MinDaysOld": 7
}],

In my case, there are 5 demos which have not been removed from my account, and they are all part of sub/0.


rename libhostspriv.so to libuserhosts.so

I'd like to package hosts/libhostspriv.so for Nix. I ran into this project due to https://discourse.nixos.org/t/change-etc-hosts-using-shell-nix/9335/13 and I think it can help out quite a bit for Nix users.
However, the naming is a bit confusing. I'm not sure I can introduce a package called hosts. In addition, libhostspriv.so is named differently, which can be confusing.
That's why I'd like to suggest renaming the project from hosts/libhostspriv.so to userhosts/libuserhosts.so. I can totally understand if this is unwanted. But I thought I'd suggest it before creating the actual package. Let me know what you think.
I also added support to do make install so that packaging will likely be straightforward.

I'm fine with the change.

Thanks for merging! 😄👍 Could you create a version tag so that I can use that version for the package of userhosts?

Done, it's v1.0.0.

Created a PR to add it to nixpkgs: https://github.com/NixOS/nixpkgs/pull/130045


No longer allowing deletion of kit items -- only deactivation

Resolves #4817
I am now only allowing Items that represent kits to be deactivated rather than deleted, test cases have also been added to verify this change.
None
Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
created a new kit item and ensured it couldn't be deleted from items and inventory, and kits.
Screenshots

(testing is the kit item i created to test)

@MichaScant looks good, but can you fix the lint errors?


[Test][Framework] add enableCacheData option for test framework

Proposed changes
Issue Number: close none
In some big load case,  disk too small to cache stream load data, so add option conf to disable cache data
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Update go-get-tool in Makefile

Signed-off-by: Carlos Eduardo Arango Gutierrez<EMAIL_ADDRESS>
What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
From GO 1.18 release notes:

go get
go get no longer builds or installs packages in module-aware mode. go get is now dedicated to adjusting dependencies in go.mod. Effectively, the -d flag is always enabled. To install the latest version of an executable outside the context of the current module, use go install example.com/cmd@latest. Any version query may be used instead of latest. This form of go install was added in Go 1.16, so projects supporting older versions may need to provide install instructions for both go install and go get. go get now reports an error when used outside a module, since there is no go.mod file to update. In GOPATH mode (with GO111MODULE=off), go get still builds and installs packages, as before.

Meaning go-get-tool Makefile helper will stop functioning moving forward as it is right now.

/retest

/retest

Test started today at 7:07 AM failed after 15m0s. ([more info](https://prow.k8s.io/spyglass/lens/metadata/iframe?req=%7B%22artifacts%22%3A%5B%22finished.json%22%2C%22podinfo.json%22%2C%22prowjob.json%22%2C%22started.json%22%5D%2C%22index%22%3A0%2C%22src%22%3A%22gs%2Fkubernetes-jenkins%2Fpr-logs%2Fpull%2Fkubernetes-sigs_kueue%2F124%2Fpull-kueue-verify-main%2F1504414125126586368%22%7D&topURL=https%3A//prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_kueue/124/pull-kueue-verify-main/1504414125126586368&lensIndex=0#))

Init container clonerefs not ready: (state: waiting, reason: "PodInitializing", message: "") Init container initupload not ready: (state: waiting, reason: "PodInitializing", message: "") Init container place-entrypoint not ready: (state: waiting, reason: "PodInitializing", message: "")

It seems ok now. 😄

/lgtm
/approve


Does this support v3 api?

Hi, and thank you very much for all of this really appreciate it.
I recently started working on googlemaps and I am using your module for couple of days now.
I however noticed my map doesn't look like the one you posted as the demo, it looks like this(aside from the development warning message everywhere, there is no map/satellite toggle):

and I am using an api-key. so I was searching as to why this is happening and I noticed since may 26th 2021, google has retired its v2 api and all should be using v3.
So here I am asking whether gmplot is using v3 or not and whether my issue is caused by simply this or something else I entirely have missed here.
Thanks a lot in advance

gmplot should already be on v3 of the API; I also get your screenshot when I don't use an API key, so perhaps that's the issue here? An invalid key?

Thanks you are right. all is fine now.


add thumbnail image property to metadata

Marked as draft until we look why the check is failing.

@kulla maybe you haven't seen the question in the ticket:
All the images have German text on them, including the default serlo.png.
What should we return for other languages? With the current code they would also get the according German thumbnail picture.

That's fine for now


Compression doesn't seem to work using docker-compose

I'm using this in my docker-compose.yml:
 logrotate:
    image: "blacklabelops/logrotate"
    volumes:
      - /var/lib/docker/containers:/var/lib/docker/containers
    environment:
      - LOGS_DIRECTORIES=/var/lib/docker/containers
      - LOGROTATE_INTERVAL=hourly
      - LOGROTATE_COPIES=7
      - LOGROTATE_SIZE=10M
      - LOGROTATE_COMPRESSION=compress

I don't see any compression when it rotates.
The logs were also much bigger when I first ran it and it didn't split it up in files of max 10M size, it just moved the old file to .1

Did you setup LOGROTATE_INTERVAL or LOGROTATE_CRONSCHEDULE. By default logrotate will only do compgres, copy, ... **ONCE at middle night.  If you want logrotate act more frequently, please set up LOGROTATE_INTERVAL=hourly (every hour) or LOGROTATE_CRONSCHEDULE=0 */30 * * * * (every 30mins)


Adding args disables prettier pre-commit hook

Adding an argument this way:
-   repo: git://github.com/awebdeveloper/pre-commit-prettier
    sha: v0.0.1
    hooks:
    -   id: prettier
        additional_dependencies<EMAIL_ADDRESS>        args: ['--single-quote']

the prettier hook passes but the committed files doesn't change

I'm actually seeing that same behaviour without specifying any args. The hook passes whether or not my staged files conform to prettier formatting.

what i did is forked the repo and added the args i needed here https://github.com/awebdeveloper/pre-commit-prettier/blob/master/.pre-commit-hooks.yaml#L6
then referenced my repo in the pre-commit file with the appropriate commit sha

I made a test case to show the problem more clearly:
https://github.com/amonks/pre-commit-prettier-test-case
As you can see, there's a poorly-formatted javascript file, and the pre-commit-config passes args.
 Remove the args array and it works fine.

@amonks you didn't add the '--write' argument at the end this is why the test file doesn't change
with it it seems to work fine

You're right!
I assumed it would come in from the .pre-commit-hooks file in this repo or something.

I've fixed this in prettier's metadata: https://github.com/prettier/prettier/blob/19cd7d32278e0bc6ddab92e8c23bb8f682fa691f/.pre-commit-hooks.yaml#L3
Now specifying args: [...] will continue to have --write

It looks like this issue has been addressed. Can relevant parties please close?


LCFS- BUG in line 6, 7, 8 and 9 of the compliance reporting summary when deleted

Describe the Bug
In the Compliance Reporting Summary, lines 7 and 9 are exhibiting incorrect behavior when a user deletes the input in these fields:

If a user deletes the input in these fields, they receive an error message (#422).
When the page is refreshed, the previous input reappears instead of saving as zero.
However, if a user manually inputs "0", it will save correctly as zero.

The expected behavior is that deleting the input in these fields should automatically save as zero, and the user should not encounter an error.
Expected Behaviour

A user should be able to delete the input in line 7 or line 9, navigate away from the report summary, and have the fields automatically save as zero.
No error messages (e.g., #422) should occur during this process.
The fields should retain the zero value after the user navigates back to the report summary.

Actual Behaviour

Deleting the input in line 7 or line 9 causes a #422 error message.
Refreshing the page reverts the fields to the previous input instead of saving them as zero.
Manually entering "0" saves the value correctly.

Implications

Users are unable to effectively clear inputs in line 7 and line 9, leading to frustration and potential reporting errors.
The error and reversion behavior disrupts the expected workflow, creating inconsistencies in the compliance reporting process.

Steps To Reproduce
Steps to reproduce the behaviour:
User/Role: BCeID

Navigate to the Compliance Reporting Summary.
Delete the input in line 7 or line 9.
Observe the #422 error message.
Refresh the page and observe that the previous input reappears.
Enter a "0" value in these fields and observe that it saves correctly.

I believe the deleting bug also applies to 6 and 8, so 6, 7, 8, and 9.

I still don't think this is working correctly. I entered these values in line 6, refreshed and they saved, deleted both of them and refreshed again and they reverted back to this (the volumes I had deleted):

@dhaselhan You are correct, that resolved it. I'll think of how to deal with this for the user


Make holidays non-editable by default.

This fixes #163.

Codecov Report

Merging #165 (50e9f22) into master (93b2770) will decrease coverage by 0.08%.
The diff coverage is 47.36%.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   69.57%   69.49%   -0.09%
==========================================
  Files          80       80
  Lines        6351     6363      +12
==========================================
+ Hits         4419     4422       +3
- Misses       1932     1941       +9

Impacted Files
Coverage Δ

...ib/pages/timetable/model/events/all_day_event.dart
100.00% <ø> (ø)

lib/pages/timetable/model/events/class_event.dart
100.00% <ø> (ø)

.../pages/timetable/model/events/recurring_event.dart
87.50% <ø> (ø)

lib/pages/timetable/model/events/uni_event.dart
47.82% <ø> (ø)

...ib/pages/timetable/service/uni_event_provider.dart
0.00% <0.00%> (ø)

lib/generated/l10n.dart
63.89% <40.00%> (-0.22%)
:arrow_down:

lib/widgets/scaffold.dart
76.78% <60.00%> (-2.85%)
:arrow_down:

lib/pages/timetable/view/events/event_view.dart
96.15% <66.66%> (-0.88%)
:arrow_down:

lib/generated/intl/messages_en.dart
96.44% <100.00%> (+0.01%)
:arrow_up:

lib/generated/intl/messages_ro.dart
95.25% <100.00%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93b2770...50e9f22. Read the comment docs.


Fix article index not being hidden by default on home page

When I rewrote part of the JavaScript and Haml views I broke the logic that was hiding the index list on the home page and only displaying it when the search field was focused.
/cc @johndjameson

Fixed with 4330bc472d7cccd2796520d28ea34a93c9516e52


kubeadm: update the docs for tasks for 1.15

placeholder for 1.15
should contain updates for "upgrades" under /tasks/administer-cluster/kubeadm...
"cert renewal" is a separate PR.
xref https://github.com/kubernetes/kubeadm/issues/1577
@kubernetes/sig-cluster-lifecycle-pr-reviews
/cc @fabriziopandini
/sig cluster-lifecycle
/milestone v1.15

/milestone 1.15

this PR is ready for review.

/assign @makoscafee

@fabriziopandini thanks, updated.

@neolit123 Thanks!
/lgtm

/assign @jaredbhatti

Preview: https://5cf8290dbb95ef00095675f9--kubernetes-io-vnext-staging.netlify.com/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade-1-15/

/hold

/hold cancel
updated.

https://deploy-preview-14595--kubernetes-io-vnext-staging.netlify.com/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade-1-15/

either of you can take a look again? @jimangel or @cody-clark

/lgtm
/approved

/approved

@jimangel you meant to say approve right?

/approve


RM3100 Mag Driver - WIP

This is in a real hack job state. But after taking a brief pass it's building on master and reading some data form the sensor (single measurement only and far from working correctly but those better than me can probably shed some light). Anyway, this could be a promising mag replacement. Those I've spoken to that are using is have said its results have exceeded their expectations but no driver is available for px4 so here we start..
Datasheet/Manual: https://www.pnicorp.com/download/rm3100-user-manual/?wpdmdl=5678&ind=xr8oWECu6CPvLwLRp1LeLmWWCGnDLVNUCeQaWuH6h1A38i-f3XII6pzTdV_eamnboSAHCgi8cEHej-AyfacydQ
Sorry for the attachment below, not at computer for a bit. Anyone, want to add anything would be great.
rm3100.cpp.zip
@dagar

Let's get this in a pull request and start iterating.

ok - added see #9818


Documentation shows Python template but current version of VS 2019 contains no Python template

The documentation indicates that one should be able to create a Python based Azure Cloud Service using a template, but the current version of VS 2019 contains no Python template. Even when choosing other templates, and selecting the same .NET version as shown in the documentation, the subsequent Wizard page does not show Python as a language option:

I have confirmed that my installation includes the Azure Cloud Services core tools option for the Python workload.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11ccaf7e-7a52-ddb2-77a1-5e3d166ef33c
Version Independent ID: 3ffac548-280d-5c64-a46e-cd010fb2b5ec
Content: Azure cloud service project template for Python - Visual Studio
Content Source: docs/python/python-azure-cloud-service-project-template.md
Product: visual-studio-windows
Technology: vs-python
GitHub Login: @JoshuaPartlow
Microsoft Alias: joshuapa

@Robertj1983 -- thank you for your feedback.  Please consider these resources:

Visual Studio on Q&A
Visual Studio MSDN Forum
Stack Overflow
Reddit

@JoshuaPartlow -- please look into this issue.

Hi @Robertj1983 - Thanks for calling this to our attention. The template you referenced was removed from Visual Studio 2019. I'll be updating the docs to reflect that.


Array of possible values for a key.

Is it possible to pass an Array of values for a given key? I'm wondering if this should be something within the scope of strong params or if it belongs outside of this.
Something like
params.require(:user).permit(:name, role: ["editor", "reader"], :bio)

Did this ever get resolved in rails 4? Looking to filter role values on signup with devise and this looked like the only solution.

@gotjosh found this because I was following a similar approach. If you're going to use those params to create a user it seems like doing the validation in the model is the way to go:
http://stackoverflow.com/questions/16818117/rails-where-to-add-validation-code-controller-or-model


[zh-cn] sync sidecar-containers

content/zh-cn/docs/concepts/workloads/pods/sidecar-containers.md

/lgtm cancel


Crash when implementing notification

Platform:       Android 6.0.1
build setting: minSdkVersion 19
compile 'com.google.android.gms:play-services-base:8.3.0'
compile 'com.google.android.gms:play-services-gcm:8.3.0'
compile "com.mixpanel.android:mixpanel-android:4.+"

I used the following to initialize pushing notification:
mMixpanel = MixpanelAPI.getInstance(this,MIXPANEL_TOKEN );
mMixpanel.getPeople().identify(id);
mMixpanel.getPeople().set("ID", id);
mMixpanel.getPeople().initPushHandling("my google project id");
But I have error:
FATAL EXCEPTION: com.mixpanel.android.AnalyticsWorker
 Process: ueye.com.fragmenttest, PID: 31876
java.lang.IncompatibleClassChangeError: The method 'java.io.File android.support.v4.content.ContextCompat.getNoBackupFilesDir(android.content.Context)' was expected to be of type virtual but instead was found to be of type direct (declaration of 'com.google.android.gms.iid.zzd' appears in /data/data/ueye.com.fragmenttest/files/instant-run/dex/slice-com.google.android.gms-play-services-gcm-8.3.0_d397001c904b476dcb0f394a3cc5afb8c87c645f-classes.dex)
 at com.google.android.gms.iid.zzd.zzdL(Unknown Source)
 at com.google.android.gms.iid.zzd.<init>(Unknown Source)
 at com.google.android.gms.iid.zzd.<init>(Unknown Source)
 at com.google.android.gms.iid.InstanceID.zza(Unknown Source)
 at com.google.android.gms.iid.InstanceID.getInstance(Unknown Source)
 at com.mixpanel.android.mpmetrics.AnalyticsMessages$Worker$AnalyticsMessageHandler.runGCMRegistration(AnalyticsMessages.java:358)
 at com.mixpanel.android.mpmetrics.AnalyticsMessages$Worker$AnalyticsMessageHandler.handleMessage(AnalyticsMessages.java:282)
 at android.os.Handler.dispatchMessage(Handler.java:102)
 at android.os.Looper.loop(Looper.java:148)
 at android.os.HandlerThread.run(HandlerThread.java:61)

Hello @ywj7931! Thanks for writing.
Could you paste your entire dependencies? It seems that you may be using an incompatible appcompact version with Google Play Services. Also, I believe that issue was solved on the latest google play services (v9.0.1). Have you tried updating your google play services dependency?

@patedit Thanks for replying, Im still sticking on 8.3, because when I moved to higher version, it told me some are replying on 8.3,
dependencies {
    compile fileTree(include: ['*.jar'], dir: 'libs')
    testCompile 'junit:junit:4.12'
    compile 'com.android.support:appcompat-v7:24.1.1'
    compile 'com.google.android.gms:play-services-base:8.3.0'
    compile 'com.google.android.gms:play-services-gcm:8.3.0'
    compile 'com.google.android.gms:play-services-maps:8.3.0'
    compile 'com.google.android.gms:play-services-location:8.3.0'
    compile 'com.facebook.android:facebook-android-sdk:[4,5)'
    compile 'com.github.florent37:materialtextfield:1.0.5'
    compile 'com.google.code.gson:gson:2.7'
    compile 'com.github.recruit-lifestyle:WaveSwipeRefreshLayout:1.6'
    compile 'com.google.maps.android:android-maps-utils:0.4'
    compile 'com.github.jd-alexander:LikeButton:0.2.0'
    compile 'com.android.support:recyclerview-v7:24.1.1'
    compile 'com.android.support:cardview-v7:24.1.1'
    compile 'com.mcxiaoke.volley:library-aar:1.0.0'
    compile 'com.android.support:design:24.1.1'
    compile 'com.aurelhubert:ahbottomnavigation:1.3.3'
    compile 'de.hdodenhof:circleimageview:2.1.0'
    compile 'info.hoang8f:android-segmented:1.0.6'
    compile 'com.kyleduo.switchbutton:library:1.4.4'
    compile 'com.longtailvideo.jwplayer:jwplayer-android-sdk:+'
    compile('com.twitter.sdk.android:twitter:2.0.0@aar') {
        transitive = true;
    }
    compile "com.mixpanel.android:mixpanel-android:4.+"

    compile 'org.apache.commons:commons-io:1.3.2'
    compile files('libs/ShareSDK-Twitter-2.7.7.jar')
    compile files('libs/ShareSDK-Core-2.7.7.jar')
    compile files('libs/MobTools-2016.0830.1940.jar')
    compile files('libs/MobCommons-2016.0830.1940.jar')
    compile files('libs/ShareSDK-FacebookMessenger-2.7.7.jar')
    compile files('libs/ShareSDK-Email-2.7.7.jar')
    compile files('libs/ShareSDK-Facebook-2.7.7.jar')
    compile files('libs/ShareSDK-ShortMessage-2.7.7.jar')
}

That
 compile 'com.longtailvideo.jwplayer:jwplayer-android-sdk:+'
is requiring me using google 8.3 service, is there other solution I can solve the crash without using other version's google service?

It seems that this dependency is not compatible with that version of google play services:
compile 'com.android.support:appcompat-v7:24.1.1'
Can you use a lower version?
compile 'com.android.support:appcompat-v7:23.4.0'
Let me know if it worked!

 I am also wondering, if my app has a setting to disable notification. how do I prevent that user from receiving the notification?

Great it is solved. Seems that another library was using a newer version of design support-v4 or appcompat-v7.
Regarding your question: You can target users when sending push notifications from mixpanel.com. I'd set a super property for that person with a boolean that specifies whether this person disabled or not notifications from your app settings. You can read more about super properties here: https://mixpanel.com/help/reference/android#superproperties
After that, you can only send push notifications to users that have that super property set to true :)

@patedit Thank you! Can I ask another question about the notification? When I push the notification, my phones didnt show any popup message or sound or show up in screen when screen is off, I have to slide to see the message, I have turned on the notification in my phones.

Our SDK does not turn the screen ON when a notification is received since it could be very annoying for the user. You could, however, implement this functionality on your by using PowerManager. Can you confirm that when you turn the screen on manually you can access your push notification? Thanks!

The notification shows only when I slide down the bar, but it just quietly appeared there.


Progressbar is visible after going back from an external link

Click on an external link
Wait for the page to load
Go back to the previous page
The progress bar is showing, and never completes.

I just noticed this, if you want, feel free to make a pull request

This will be fixed in the next update.


Replace IValueReader with ValueBuffer struct

This change reflects the fact that currently query requires a buffer and that buffer is always an object array. Also, that buffer is guaranteed to have objects of the correct type (because that is the contract with the data store) and will also not have nulls. This means that IValueReader is acting as a buffer for boxed values. This change makes that explicit and also allows a struct to be used.
Note that we are considering making this buffer use actual materialized entities instead of an object array, but that work isn't scheduled yet.

:shipit:


Server Error for Hydration failed ... and Text content does not match ...

We are starting to get multiple errors on production due to the recent upgrade to React 18.
Severity:

mild
the website doesn't seem to break but it's complaining with errors on the console
works fine with javascript disabled

Common Errors:

There was an error while hydrating. Because the error happened outside of a Suspense boundary, the entire root will switch to client rendering.
Hydration failed because the initial UI does not match what was rendered on the server.
Text content does not match server-rendered HTML.

Cause:
https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#other-breaking-changes

Stricter hydration errors: Hydration mismatches due to missing or extra text content are now treated like errors instead of warnings. React will no longer attempt to “patch up” individual nodes by inserting or deleting a node on the client in an attempt to match the server markup, and will revert to client rendering up to the closest  boundary in the tree. This ensures the hydrated tree is consistent and avoids potential privacy and security holes that can be caused by hydration mismatches.

Gatsby Discussion:

https://github.com/gatsbyjs/gatsby/discussions/31943
https://github.com/vercel/next.js/discussions/35773( similar discussion ongoing on Next.js)

Possible Approach:

Find what content is causing the error( DEV_SSR seemed to be a solution but it's WIP: https://github.com/gatsbyjs/gatsby/pull/35685)

Resources:

https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#other-breaking-changes
https://lihautan.com/hydrating-text-content

Sites:

[x] dvc.org
[ ] cml.dev
[ ] mlem.ai

dvc.org pages that are showing these console errors

any of the doc pages
home page
the community page

I've managed to pin this down to our Download button's "change depending on OS" functionality! That would explain why I was only able to replicate the error on the home and docs pages.
@julieg18 I couldn't replicate on the community page at all, maybe there was another error that looked like this one? Also, I was able to get a local replication via yarn build && yarn serve, as yarn develop doesn't have any hydration and behaves like a traditional React app.
I'm working on a fix.

You can try out DEV_SSR with gatsby@next now again.

Reopening this issue, as we starting to get similar errors for cml.dev and mlem.ai. It must be due to recent upgrades on packages including react to version 18.  I hope, this must be relatively easier to debug with DEV_SSR available.

Sentry's reporting issues on cml.dev home, mlem.ai home, https://mlem.ai/doc/contributing/core. I can only recreate in prod on the contributing/core page and not the homepage.

Seems like the ones on contributing/core are at least partially related to the redirect pre-replacement being run on our docs links. There's another error as well after taking care of that related to aria-current="page". I'll edit in a log in a little bit.

In /doc/api-reference I get
Warning: Prop `className` did not match. Server: "styles-module--sectionLink--kYxQr styles-module--active--22Q07 link-with-focus" Client: "styles-module--sectionLink--kYxQr styles-module--active--22Q07 docSearch-lvl0 link-with-focus"

It seems like we have more of this kind of error, for example, if we scroll so that the alert bar is hidden we get a similar className mismatch error. I think it's quite a common approach to remove/add the classname for interaction. If it started catching them, I think there will be a lot more of such kinds of errors.
I have created a draft PR: https://github.com/iterative/mlem.ai/pull/148 to get started with fixing. It's okay if you pick up from there or we can close it if you are already working on a branch.

I can only replicate the header mismatch error in the dev server with DEV_SSR, both prod and serve && build don't have the issue for me. I believe this is because they don't attempt to persist the page's scroll position on refresh, which seems like an issue with how our site's configured because gatsbyjs.com persists the scroll point in prod just fine, even with a header banner like ours!
https://user-images.githubusercontent.com/9111807/182651256-9476cc7f-84c5-4e2f-bd45-b1d204d77a43.mp4
Still, https://github.com/iterative/gatsby-theme-iterative/pull/33 is currently reworking that logic so I'll use the DEV_SSR flag there to see if I can make something solid enough that even this won't trip it up. Thanks for the tip @LekoArts!


tags list is loading slow

Hi,
It takes more than 5 minutes to fully load a tags file with about 16000 lines. (tags.zip)
files, grep_porject can handle more than that within few seconds.
Could you look into this issue?

That's actually "by design" (read: bad design), the reason being is that before I had the builtin neovim previewer I had to provide line/column for the pattern so that the fzf previewer (bat/cat/etc) will be able to find the right offset inside the file, to do that fzf-lua runs rg for each tag to get the correct line/column and adds it to fzf.
It was a hack but since not many people use tags (LSP symbols are better IMO) and no one complained, I left it as is with the intention of fixing it one day as per the below:
Since the implementaiton of the builtin previewer (which is a neovim buffer) I can now feed the tag file as is into fzf and then search for the tag pattern inside the preview buffer.
I am now working on a major performance enhancement to make the files/grep providers icon/git indicator parsing run in an external process to make is as close as possible to running with { git_icons=false, file_icons=false } (try it if you haven't and see how fast it is), once I'm done with that I'll fix the tags for you.

Cool! That makes total sense.

@ibhagwan i have this in my config
require('fzf-lua').setup({
  files = {
    git_icons = false,
    file_icons = false,
  },
  tags = {
    git_icons = false,
    file_icons = false,
  },
})

The first part, the tags file is still loading. The second one is from fzf.vim.
Are you still refactoring the tags part?

I would want to use LSP symbols but I still need to open a file before an lsp server is loaded. Compared to fzf wherein I can load the tags file even without opening anything yet

@yujinyuz, the tags fix wasn’t implemented yet, probably tomorrow or the day after and it will be as fast as fzf.vim.

@yujinyuz, the tags fix wasn’t implemented yet, same explanation as my earlier comment applies, will apply the fix tomorrow or the day after and it will be as fast as fzf.vim.

Thanks @ibhagwan
Looking forward to it as I am switching from Telescope to Snap to fzf-lua

Decided to do this before I finish the other task, update to the latest commit: https://github.com/ibhagwan/fzf-lua/commit/46c9e2bcd22b40203d3881d37be4d238b8c01530
This commit also overrides the default previewer for tags and btags so it ignores winopts.previewer.default (can be overridden if you wish) and adds a new highlight under winopts.hl.search (default Search') which determines how to highlight the ctag matched pattern, see below
I just discoverd one outstanding issue, opening the match doesn't bring the cursor to the correct line, will fix that in a few minutes.
Try it out and lmk?

https://github.com/ibhagwan/fzf-lua/commit/e7c49701461c7032651b853710f26a1752bbf053 - this makes sure to jump to the correct pattern when opening the buffer.
Lmk if this works well for you?

I am switching from Telescope to Snap to fzf-lua

@yujinyuz, out of curiousity, why did you decide to switch?

@ibhagwan I'll try that.
I'm switching because telescope has a bug with folds.
See: https://github.com/nvim-telescope/telescope.nvim/issues/699
I switched to snap which was quite fast but I was occasionally having ENOENT problems
See: https://github.com/camspiers/snap/issues/49
And I was about to just go back to fzf.vim but I found your plugin so I'll be using this for now and see if I have problems

It takes about 2-3 seconds to load the tags file, while it is instantaneous using fzf.vim.
Further improvement would be welcome.
Also the cursor rarely jump to the incorrect line. The behavior is quite unpredictable now.

It takes about 2-3 seconds to load the tags file, while it is instantaneous using fzf.vim. Further improvement would be welcome.

There's def room for improvement in the parsing code, I'll take a look after I'm done with the bigger perf improvements I'm working on, 2-3 seconds sounds managable.

Also the cursor rarely jump to the incorrect line. The behavior is quite unpredictable now.

The cursor jump uses search(<pattern>) to go to the correct line, it also uses the same search to find the correct line in the preview, can you tell if the line appears correctly in the preview or is it wrong there as well?

The cursor jump uses search(<pattern>) to go to the correct line, it also uses the same search to find the correct line in the preview, can you tell if the line appears correctly in the preview or is it wrong there as well?

The highlighted line in the preview window is always correct.

The cursor jump uses search(<pattern>) to go to the correct line, it also uses the same search to find the correct line in the preview, can you tell if the line appears correctly in the preview or is it wrong there as well?

The highlighted line in the preview window is always correct.

Can you find if there's something in the fzf line consistent with this behavior? things to look for:

patterns with :?
patterns with /?
patterns with uri's (<x>://)?

I looked into the core a little bit. It seems like adding vim.cmd("norm! gg") after the following line solves the issue.
https://github.com/ibhagwan/fzf-lua/blob/72fe3222d30799828fdde321e2735ec644fbf30e/lua/fzf-lua/actions.lua#L95
I configured vim to return to the last cursor position when opening a file :-)

I looked into the core a little bit. It seems like adding vim.cmd("norm! gg") after the following line solves the issue.
https://github.com/ibhagwan/fzf-lua/blob/72fe3222d30799828fdde321e2735ec644fbf30e/lua/fzf-lua/actions.lua#L95
I configured vim to return to the last cursor position when opening a file :-)

You're right! I didn't rewind the cursor back to line 1 as I did with the previewer, I forgot the action doesn't switch buffer unless it has to:
https://github.com/ibhagwan/fzf-lua/blob/72fe3222d30799828fdde321e2735ec644fbf30e/lua/fzf-lua/previewer/builtin.lua#L618
https://github.com/ibhagwan/fzf-lua/commit/fd4e94e7a4c139122dbe11f6caee6241c4ab8c00: Latest commit adds the same behavior as norm! gg using vim.api.nvim_win_set_cursor (I prefer to use lua if possible).
Ty for the debugging effort!


Allow Enums to be Nullable

Got this one filed on UserVoice and discussed it again at PS Summit NA 2017. It seems like a small thing, but it's blocking usage of class-based resources to the point that they have to install WMF 5 Production Preview on their build servers in order to compile their MOFs. They have no problem using PowerShell 6 on their build servers to do the same if we make the fix here.
Steps to reproduce
Create a new DSC Resource module called EnumTest. Create your module manifest and set the .psm1 file content to:
enum MyEnum {
    Test
    Setting
}

[DscResource()]
Class MyTestResource {
    [DscProperty(Key)]
    [String] $MyKey

    [DscProperty()]
    [nullable[MyEnum]] $MyEnum

    [Void] Set() {
        $null
    }

    [Boolean] Test() {
        return $true
    }

    [MyTestResource] Get() {
        Return [MyTestResource]
    }
}

Following, try to create a Configuration with the following code and the 'Import-DscResource' keyword will be underlined with an error.
Configuration MyEnumTest {
    Param (
    [Parameter(Mandatory=$true)]
    [string]$ComputerName
    )

    Import-DscResource -ModuleName EnumTest

    Node $ComputerName {
        EnumTest Test {
            MyKey = 'Blah'
            MyEnum = 'Setting'
        }
    }
}

$null = MyEnumTest -ComputerName $env:COMPUTERNAME

Expected behavior
The configuration should compile into a MOF document.
Actual behavior
The Import-DscResource -ModuleName EnumTest is underlined in red and the configuration does not compile.
Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSRemotingProtocolVersion      2.3
GitCommitId                    v6.0.0-alpha.17
CLRVersion
PSEdition                      Core
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0
PSVersion                      6.0.0-alpha
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   <IP_ADDRESS>

I see this hasn't been touched in 3 years. Is there any other way to work around this? I'm using 5.1 since it's what comes with Windows Server 2019 and this is really breaking things.

@Soolkiki I doubt you'll see any traction on this.  Yes, it sucks, because it feels like every desired state configuration tool (Chef, Puppet, SaltStack) has some ugly usability issues tied to the programming environment (e.g., for years Chef used a version of Ruby that did not ship with any easy way to output logs to standard out...).  As much has been said about DevOps, little gets done, especially on Windows, which is why Hashicorp TerraForm became so popular, because it actually works, unlike stuff Microsoft started and then abandoned.

That is frustrating...I suppose I'll just add a None first value to my enums to get around it.
Thank you

While we customers pay M$ so many billions of US$ that no human can count it, M$$ fails to hire developers so that meaningful suggestions from customers don't take 1/2 decade?
Just FYI:
The shame is not minor when a robot closes such feedback just because not so many customers study and vote for Issues all the time.
It would be great if M$ actually shows interest in having satisfied customers.
Guess what: just pretending to be interested is also a shame.


Add 13.3 release

Check for python39/python311 issues for 14.0 but not seeing anything
This relates to https://github.com/depenguin-me/depenguin-run/issues/84

can test so long
wget https://depenguin.me/qa.sh
chmod +x qa.sh
./qa.sh <key-url>

run.sh test works to load and give access

Thank you :pray:

test image available at https://depenguin.me/files/mfsbsd-13.3-RELEASE-rc2-amd64.iso
and qa.sh is updated to use this automatically
wget https://depenguin.me/qa.sh
chmod +x qa.sh
./qa.sh <key-url>


Report doesn't open automatically on some corporate machines

The report doesn't open automatically, and the generate_allure_report.bat file opens and closes without doing anything.

Workaround was identified to edit the batch file manually and override the JAVA_HOME variable with the one that SHAFT generates.
old:

new:

Hi @mahmoudYosrey the fix was released a few minutes ago. Please just update to the latest engine version and get back to me to confirm if it's working for you now.


Stack should allow default values to be reset

In a kontena.yml file, if you update the value of a default field in a variable, the new value will not be used when executing kontena stack upgrade.
It would be nice if there was a --clear-defaults command line arguments to kontena stack upgrade that would force the default values to be read from the stack file again.
Use case:
stack: danb/my-service
version: 0.1.1
variables:
  other_service_url:
    type: string
    default: https://some-service.other-stack.${GRID}.kontena.local
    from:
      env: OTHER_SERVICE_URL
services:
  api:
    environment:
      - OTHER_SERVICE_URL=${other_service_url}

Imagine I decide later that default: https://some-service.other-stack.${GRID}.kontena.local should actually be default: http://some-service.other-stack.${GRID}.kontena.local:9876.  I can't just update the stack file and run a stack upgrade.  I need to remove the stack altogether and redeploy, or inject the variable in some other way.

This happens because the kontena stack install POSTs all the variables to the server, and then GET's those for the kontena stack upgrade. It should still prompt for each of those values, though, allowing you to update it manually?
The --clear-defaults would need to compare those values stored on the server to somehow figure out which of them are defaults and need to be reset.
A different option would be for kontena stack install to only send the non-default values, allowing kontena stack upgrade to always pick up new defaults.

For me I'm not really picky about the implementation, if anything I would prefer it to always just use the new defaults but I felt like that might break people's existing deploys compared to the flag option.


JavaClass macro: stop generating javaThis and javaEnvironment members

Provide these properties via an extension to AnyJavaObject, accessing the holder values, rather than splatting that same code into every @JavaClass.

lgtm


Nearby list bottom sheet UI issues

Summary:
1- It should display a message when no place is found, instead of empty white sheet.
2- The height should be smaller if number of items in the list is smaller than N.

@neslihanturan Is this what you are observing (2 screenshots provided below:)?
No results map screenshot:

No results map screenshot with list displaying:

Are you specifically talking about this blank white sheet being displayed when you select list?
Steps to reproduce for the blank white sheet issue (#1):

Make sure the app does not have the location permission
While logged in, select the "Nearby" tab of the "Home" screen
Deny the access to location
Select "No" to the permission request dialog
Select the "Nearby" tab again
Tap away from the dialog to make it disappear
Observe that there are no results

Make sure the app does not have the location permission

While logged in, select the "Nearby" tab of the "Home" screen

Deny the access to location

Select "No" to the permission request dialog

Select the "Nearby" tab again

Tap away from the dialog to make it disappear

Observe that there are no results

Seems like you discovered another bug, ideally we expect user is sent to contributions tab instead of displaying an empty nearby. What about creating a new issue for this one?
But yes, the white bottom sheet that I mentioned is the one you displayed with your screen shoots. There should be a message and progressbar there, indicating states.

@neslihanturan Okay, I will create a new issue for the new issue discovered above. I am curious though as to how you reproduced this initially? I'm assuming this was performed by using mock data so that there were only a few results or none at all? Either way, I agree that the currently observed behavior is wrong and should be changed to handle these situations like you listed above.

@neslihanturan @nathanmeade Hello, I'm new here and I've been working in software for just over a year, I'm currently unemployed so would like to contribute :) . Could I work on this as my first issue?
I have replicated the white sheet by deselecting the "All" checkbox in "Place type" without selecting any of the specific options.

and then clicking on the list.
Is the proposed solution to display a ghost text on the empty list, something like "No results found", or to actually pop up a dialog with a message?

Hi @CloeARiva , welcome to the team :). Considering @nathanmeade seems like interested with the issue too, I would like to ask him if he is working on the issue or not. If he is already working, you can pick another beginner friendly issue. Otherwise, you are welcome to work on this one :).

If issue #3732 is valid (given that I have understood the issue properly and that my proposed solution is valid) then I will be working on that issue instead (preventing the user from accessing the "Nearby" tab if the location permission has been denied). @neslihanturan Would you agree that I have understood issue #3732 properly? If so, @CloeARiva this issue (#3727) would be a great issue to tackle while I tackle the other. Also, welcome - I am very new here as well.

Seems like you shared issues as this one is for @CloeARiva and #3732 is for @nathanmeade . Both of you are welcome, looking forward for your updates:)

@neslihanturan @nathanmeade thank you both for replying so quickly, I'll start working on this issue now :)

Sounds good, no problem!

@neslihanturan @nathanmeade Hi both, I believe I have found another bug while testing my changes.
Steps to reproduce:

on the Nearby tab click on the "Place type:" field
deselect the "All" checkbox (this is basically searching for places of no place type so will return no results)

Click on the list button on the top right, you will see no results
Click the button again to minimise the list
scroll to a new area of the map until the "search this area" button appears at the top
Click "search this area"
Check in your "Place type: " field that the "All" check box is not selected, as before
Click the list button in the top right
Results are returned as if you were searching for all placetypes (i.e. as if "All" was checked)

Ticking and unticking "All" again fixes this so I believe that we are not refiltering properly when we first move to a new location.
Do you agree? Should I create a new issue for this?


Replace PAT usage with GitHub App Tokens

Verification

[X] This issue's title and/or description do not reference a single formula e.g. brew install wget. If they do, open an issue at https://github.com/Homebrew/homebrew-core/issues/new/choose instead.

Provide a detailed description of the proposed feature
We should replace usage of PATs (e.g. HOMEBREW_GITHUB_PUBLIC_REPO_TOKEN) with GitHub App tokens. We can use this action to simplify its usage: https://github.com/actions/create-github-app-token
What is the motivation for the feature?
GitHub App tokens are ephemeral, which limits the blast radius when they get leaked.
How will the feature be relevant to at least 90% of Homebrew users?
This will make our CI more secure, which is relevant to 100% of Homebrew users.
What alternatives to the feature have been considered?
Continuing to use PATs.

Here is an incomplete list of workflows that currently use PATs. It is not complete because I don't have all official repositories tapped. The list is relative to HOMEBREW_REPOSITORY.
❯ rg -uu -l -g'**/.github/workflows/*.yml' 'secrets\.HOMEBREW_([A-Z]*_)*TOKEN'
Library/Taps/homebrew/homebrew-cask-fonts/.github/workflows/google-fonts.yml
Library/Taps/homebrew/homebrew-cask-fonts/.github/workflows/automerge.yml
Library/Taps/homebrew/homebrew-cask-fonts/.github/workflows/autobump.yml
Library/Taps/homebrew/homebrew-cask-fonts/.github/workflows/rebase.yml
Library/Taps/homebrew/homebrew-cask-fonts/.github/workflows/dispatch-command.yml
Library/Taps/homebrew/homebrew-cask-fonts/.github/workflows/triage.yml
Library/Taps/homebrew/homebrew-cask-fonts/.github/workflows/rerun-workflow.yml
.github/workflows/docker.yml
.github/workflows/tests.yml
.github/workflows/sponsors-maintainers-man-completions.yml
.github/workflows/spdx.yml
.github/workflows/sorbet.yml
Library/Taps/homebrew/homebrew-cask/.github/workflows/sync-templates-and-ci-config.yml
Library/Taps/homebrew/homebrew-cask/.github/workflows/automerge.yml
Library/Taps/homebrew/homebrew-cask/.github/workflows/autobump.yml
Library/Taps/homebrew/homebrew-cask/.github/workflows/sync-labels.yml
Library/Taps/homebrew/homebrew-cask/.github/workflows/rebase.yml
Library/Taps/homebrew/homebrew-cask/.github/workflows/dispatch-command.yml
Library/Taps/homebrew/homebrew-cask/.github/workflows/bump-unversioned-casks.yml
Library/Taps/homebrew/homebrew-cask/.github/workflows/triage.yml
Library/Taps/homebrew/homebrew-cask/.github/workflows/rerun-workflow.yml
Library/Taps/homebrew/homebrew-core/.github/workflows/autobump.yml
Library/Taps/homebrew/homebrew-core/.github/workflows/dispatch-build-bottle.yml
Library/Taps/homebrew/homebrew-core/.github/workflows/publish-commit-bottles.yml
Library/Taps/homebrew/homebrew-core/.github/workflows/dispatch-rebottle.yml
Library/Taps/homebrew/homebrew-core/.github/workflows/create-replacement-pr.yml
Library/Taps/homebrew/homebrew-core/.github/workflows/recreate-linux-runners.yml
Library/Taps/homebrew/homebrew-core/.github/workflows/remove-disabled-formulae.yml