[Bug] Can't be installed with npm

Describe the bug
Can't be installed with npm if already used sass-loader@13
Steps to reproduce the behavior

npm i sass-loader
npm i @storybook/addon-styling

Expected behavior
should work
Screenshots and/or logs
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/sass-loader
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@storybook/addon-styling
npm ERR!   @storybook/addon-styling@"*" from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/sass-loader
npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@storybook/addon-styling
npm ERR!     @storybook/addon-styling@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Environment

Node.js version: v18.12.0
NPM version: 8.19.2

@dartess that's annoying! Sorry about that.
I've added this to my list of things to patch this week. In the meantime, you should be able to resolve this by installing the peerDep version of sass-loader like so:
npm install -D<EMAIL_ADDRESS>

Hi @Integrayshaun ! Do you know by any chance if that fix might resolve this one we're getting trying to set up storybook 7 on a brand new project? We're trying to add tailwind support to storybook, but a dependency conflict is blocking this.
npm install --D @storybook/addon-styling
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@storybook/addons
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@storybook/builder-webpack5
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@storybook/react-webpack5
npm ERR!       dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev @storybook/addon-styling@"*" from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@storybook/addons
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@storybook/addon-styling
npm ERR!     dev @storybook/addon-styling@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Thank you!

Is the patch for making it compatible with storybook 7 on the radar as well? Please let me know if I can help you with that :)

@sgarcia-dev & @PascalvdHoek
I'm aiming to have a full release that works for Storybook 7 tomorrow.
In the mean time, install the prerelease by running:
npm install -D @storybook/addon-styling@next

+1 for staying updated on this issue. Thanks for all your work @Integrayshaun!

@Integrayshaun Yes, the installation was successful! In a hurry, I was able to launch and configure support for scss, but so far I have not been able to just take and enable cssModules: true, so far I'm getting an error
ValidationError: Invalid options object. CSS Loader has been initialized using an options object that does not match the API schema.
  - options.modules should be one of these:
...

with next config:
{
  name: "@storybook/addon-styling",
  options: {
    sass: {
      includePaths: [path.resolve('./src/shared/view/styles/')],
    },
    cssModules: true,
  },
},

But probably I have not figured out the documentation yet.

@Integrayshaun yeah, it just work for me

@dartess Perfect! version 1.0.0 is officially out for you to upgrade to


Issue 416: Refactor pager code of edit categories screen

Description:

Partial solution for https://github.com/willowtreeapps/vocable-android/issues/416
VocableFragementStateAdapter:

Fix return value of getItemCount()
Replace notifyDataSetChanged() with notifyItemInserted() and notifyItemRemoved()

EditCategoriesFragment:

Use post {} for setting categoryPageNumber (wasn't always getting set correctly before)
Move setting of adapter so that it's called once instead of every time data changes
Remove broken setting of current page to "middle" (now defaults to first page)

Make LegacyFragmentStateAdapter for use in other subclasses that haven't been changed yet
EditCategoriesViewModel: replace liveOrderCategoryList and liveAddRemoveCategoryList in favor of a single categoryList that uses categories() flow from categoriesUseCase
EditCategoriesListFragment: fix crash when removing an element caused pager to go down a page

Screenshots:
n/a

[ ] Acceptance Criteria satisfied
[ ] Regression Testing

Seeing something funky going on here. If you go to the categories page and keep trying to move the bottom most category on a page down, the moving doesn't happy as expected and if you do it enough it'll crash
vocable_crash.webm

@mattttvaughn I fixed the crash you raised up. Please take a look! 🙏


cc-wrapper hardeningFlags tests: fix expected behaviour in corner cases

Description of changes
A few fixups for the recently merged #217390, straightening out the expected behaviour of one test to match current reality and changing a few tests to use a _FORTIFY_SOURCE=1-protectable example program so that it can be more useful for testing clang's behaviour too.
Note there are two tests here that will (still) be failing on tests.hardeningFlags-clang until I can get the fix for that merged (#253194, but is headed for staging):  fortify3EnabledEnvEnablesFortify1 and fortify3EnabledEnvEnablesFortify1ExecTest.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2705

Have pushed some further fixes and added some tests for the recently added stackclashprotection flag.
Would love to get this merged and have a little more green around https://hydra.nixos.org/eval/1807613?filter=hardeningflags&compare=1807605&full=

@ofborg build tests.hardeningFlags-gcc tests.hardeningFlags-clang

I successfully ran nom build --impure --expr 'let pkgs = (builtins.getFlake "github:NixOS/nixpkgs/pull/253186/merge").legacyPackages.${builtins.currentSystem}; in pkgs.lib.filterAttrs (k: v: (builtins.tryEval v).success && v ? drvPath && (builtins.tryEval v.drvPath).success) pkgs.tests.hardeningFlags-gcc' on x86_64-linux. -clang yields the following error:
test-pieExplicitDisabled> /nix/store/cjahfl54j3931zm56rvpcim3d4hyxpg9-test-bin/bin/test-bin:
test-pieExplicitDisabled>  Position Independent Executable: yes
test-pieExplicitDisabled>  Stack protected: yes
test-pieExplicitDisabled>  Fortify Source functions: yes
test-pieExplicitDisabled>  Read-only relocations: yes
test-pieExplicitDisabled>  Immediate binding: yes
test-pieExplicitDisabled>  Stack clash protection: unknown, no -fstack-clash-protection instructions found
test-pieExplicitDisabled>  Control flow integrity: no, not found! (ignored)
test-pieExplicitDisabled> ERROR: Expected hardening-check to fail, but it passed!

I just wanted to check if this is expected or not, as it’s not in your list of known failing tests.

I assume this is pkgs.tests.hardeningFlags-clang.pieExplicitDisabled failing, which fails for me too. I just haven't marked it as broken because ... I'm not really happy with it being broken ;)
Is it that it's not possible to disable pie on clang/linux? Are we just not supplying the right flags at the right point? Don't know - it's something we need to investigate at some point.


Workaround python-coveralls issue with pytest-cov version

Supersedes #18.

+1

Dammit, I merged to the wrong branch. Fixing this locally.


IOS: example not work as expected

when i start your example an IOS , i get this error ;
Frame Processor Error: Regular javascript function '' cannot be shared. Try decorating the function with the 'worklet' keyword to allow the javascript function to be used as a worklet., js engine: VisionCamera
any help?

for sure
this mu babel.config.js
module.exports = {
  presets: ['module:metro-react-native-babel-preset'],
  plugins: [
    ['react-native-worklets-core/plugin'],
    [
      'react-native-reanimated/plugin',
    ],
  ],
};

demo code
import {
  StyleSheet,
  Text,
  View
} from 'react-native'
import {
  useEffect,
  useState
} from 'react'
import {
  Camera,
  useCameraDevice,
  useFrameProcessor,
runAsync
} from 'react-native-vision-camera'
import {
  detectFaces,
  DetectionResult
} from 'react-native-vision-camera-face-detector'
import { Worklets } from 'react-native-worklets-core'

export default function App() {
  const device = useCameraDevice('front')

  useEffect(() => {
    (async () => {
      const status = await Camera.requestCameraPermission()
      console.log({ status })
    })()
  }, [device])

  const handleDetectionWorklet = Worklets.createRunInJsFn( (
    result: DetectionResult
  ) => {
    console.log( 'detection result', result )
  })
  const frameProcessor = useFrameProcessor((frame) => {
    'worklet'
    runAsync(frame, () => {
      'worklet'
      detectFaces(
        frame,
        handleDetectionWorklet, {
          // detection settings
        }
      )
    })
  }, [handleDetectionWorklet])

  return (
    <View style={{ flex: 1 }}>
      {!!device? <Camera
        style={StyleSheet.absoluteFill}
        device={device}
        frameProcessor={frameProcessor}
      /> : <Text>
        No Device
      </Text>}
    </View>
  )
}

The problem is you're missing processNestedWorklets in babel.
Thake a look here.

thanks,
this is my new babel config

module.exports = {
  presets: ['module:metro-react-native-babel-preset'],
  plugins: [
    ['react-native-worklets-core/plugin'],
    [
      'react-native-reanimated/plugin',
      {
        processNestedWorklets: true
      }
    ],
  ],
};

but i still have the same issue
Env:

"react-native-reanimated": "^3.4.2",
"react-native-vision-camera": "^3.9.0",
"react-native-vision-camera-face-detector": "^1.2.3",
"react-native": "0.72.3",

any other suggestions ?

i was need a --reset-cache, :)
thank 4 your help

one last question please,
i wanna plot a green faceRect on the detected face ;
  const onFacesDetected = (result: DetectionResult) => {
    if ( Object.keys(result.faces).length === 0) {
      setFaceDetected(false);
      return;
    }
    setFaceDetected(true);
    drawFaceRect(result.faces['0'].bounds.centerX, result.frame);
  };
  const deviceWidth = Dimensions.get('screen').width;
  const deviceHeight = Dimensions.get('screen').height;

  const drawFaceRect = (face: any, frame:any) => {
    rect.current?.setNativeProps({
      width: face.bounds.width * (deviceWidth/frame.width),
      height: face.bounds.height * (deviceHeight/frame.height),
      top: face.bounds.top * (deviceHeight/frame.height),
      left: face.bounds.left * (deviceWidth/frame.width),
    });
  };

is this code is correct

In my local tests (and knowing that vision camera still have an orientation issue) I had to add some platform specific code, here's my current code:
type FacePosType = {
  faceW: number
  faceH: number
  faceX: number
  faceY: number
}
function calcFacePosition(
    bounds: Bounds,
    frame: FrameData
  ): FacePosType {
    const orientation = ( () => {
      switch ( frame.orientation ) {
        case 'portrait': return 0
        case 'landscape-left': return 90
        case 'portrait-upside-down': return 180
        case 'landscape-right': return 270
      }
    } )()
    const degrees = ( orientation - 90 + 360 ) % 360
    let scaleX = 0
    let scaleY = 0

    if ( !isIos && (
      degrees === 90 ||
      degrees === 270
    ) ) {
      // scale is inverted because of vison camera orientation issue
      scaleX = windowWidth / frame.height
      scaleY = windowHeight / frame.width
    } else {
      scaleX = windowWidth / frame.width
      scaleY = windowHeight / frame.height
    }

    const faceW = ( bounds.right - bounds.left ) * scaleX
    const faceH = ( bounds.bottom - bounds.top ) * scaleY
    const faceX = ( () => {
      const xPos = bounds.left * scaleX
      if ( isIos ) return xPos
      // invert x pos on android
      return windowWidth - ( xPos + faceW )
    } )()

    return {
      faceW,
      faceH,
      // horizonally face center
      faceX: faceX + ( faceW / 2 ),
      // vertically face center
      faceY: bounds.top * scaleY
    }
  }

Closing issue as original problem is solved.


Add notes for newly versioned .so files

This adds a missing set of release notes describing changes to our .so libraries.

@rajatmonga Could you double-check these new notes before they're merged, please?

@gunan or @martinwicke could confirm too.


Add statement params to dataframe as a property

Please answer these questions before submitting your pull requests. Thanks!

What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN

Fill out the following pre-review checklist:

[ ] I am adding a new automated test(s) to verify correctness of my new code
[ ] I am adding new logging messages
[ ] I am adding a new telemetry message
[ ] I am adding new credentials
[ ] I am adding a new dependency

Please describe how your code solves the related issue.
Use dataframe's statement params at query execution if no statement params are specified (eg in collect). We need this to track credit consumption from dataframes with snowml contributions. cc: @sfc-gh-pdorairaj

I don't think it makes sense to keep statement parameters as a property of DataFrame. Why not just specify statement_params at query execution?

I don't think it makes sense to keep statement parameters as a property of DataFrame. Why not just specify statement_params at query execution?

For snowml use cases, we create/modify dataframes and therefore should take credit for part of the consumption. However the DFs may not be executed via our APIs, meaning we are unable to specify statement_params, resulting in underestimated credit consumption.

I don't think it makes sense to keep statement parameters as a property of DataFrame. Why not just specify statement_params at query execution?

For snowml use cases, our APIs may return created/modified dataframes and therefore should take credit for part of the consumption. However the DFs may not be executed via snowml APIs, so we are unable to specify statement_params, resulting in underestimated credit consumption.

What about using query tags?

I don't think it makes sense to keep statement parameters as a property of DataFrame. Why not just specify statement_params at query execution?

For snowml use cases, our APIs may return created/modified dataframes and therefore should take credit for part of the consumption. However the DFs may not be executed via snowml APIs, so we are unable to specify statement_params, resulting in underestimated credit consumption.

What about using query tags?

query_tag is a session property and part of statement_params so I think it doesn't work here? Also @sfc-gh-yixie should have the context of this change.

If we are trying to track credit usage, I wonder if we could change the application name by checking certain setup (e.g. if snowml is in the modules, like what streamlit does): https://github.com/snowflakedb/snowpark-python/blob/69a60e8d1f8cf539ed849eed6b4b591440e3c4d3/src/snowflake/snowpark/_internal/server_connection.py#L144

If we are trying to track credit usage, I wonder if we could change the application name by checking certain setup (e.g. if snowml is in the modules, like what streamlit does):
https://github.com/snowflakedb/snowpark-python/blob/69a60e8d1f8cf539ed849eed6b4b591440e3c4d3/src/snowflake/snowpark/_internal/server_connection.py#L144

If we are trying to track credit usage, I wonder if we could change the application name by checking certain setup (e.g. if snowml is in the modules, like what streamlit does):
https://github.com/snowflakedb/snowpark-python/blob/69a60e8d1f8cf539ed849eed6b4b591440e3c4d3/src/snowflake/snowpark/_internal/server_connection.py#L144

What if multiple applications claim contributions to credit usage? Later we need to provide universal telemetry for snowpark use cases and having application overwritten by the latest source may not be ideal. Where is "application" tracked in job_etl_v?

What parameters will be used to calculate the credits? If possible can we add some tests?

BTW I'm not opposed to this change cuz it is useful in general. But I want to see if this is right way to solve your problem.

What if multiple applications claim contributions to credit usage?

Do we have a way to track multiple applications today? Before we have a proper way to do this, I would find it awkward to use a statement level parameter. For snowml/streamlit, I feel the contribution should be attribute to the top level application, not snowpark and we could write query to include snowml/streamlit if we want to count them towards snowpark. For example, today snowpark's usage goes to snowpark and is not counted as python connector, though we could tweak the query to do that.

Where is "application" tracked in job_etl_v?

I'm not sure about job_etl_v, but you should be able to find it in session_etl_v.client_app_id.

What parameters will be used to calculate the credits? If possible can we add some tests?

Added unit test test_statement_params.
Using "source" (eg statement_params["source"]="SnowML") to tag jobs for credit usage tracking.

BTW I'm not opposed to this change cuz it is useful in general. But I want to see if this is right way to solve your problem.

What if multiple applications claim contributions to credit usage?

Do we have a way to track multiple applications today? Before we have a proper way to do this, I would find it awkward to use a statement level parameter. For snowml/streamlit, I feel the contribution should be attribute to the top level application, not snowpark and we could write query to include snowml/streamlit if we want to count them towards snowpark. For example, today snowpark's usage goes to snowpark and is not counted as python connector, though we could tweak the query to do that.

Where is "application" tracked in job_etl_v?

I'm not sure about job_etl_v, but you should be able to find it in session_etl_v.client_app_id.

Thanks Shixuan. Right we can't track multiple applications today. Regarding the sys.modules approach used by streamlit, how to determine the top level application when there are more than one module?
We use statement params as our telemetry is based on job_etl_v. Switching to application name will require lots of rework. Also users mix snowml and other APIs (eg snowpark) in a session. If we change the application to snowml then it will take all credits from the session.

Sounds good. I think it would be useful to have a framework for easier application tracking, given that our ecosystem is growing :)

Sounds good. I think it would be useful to have a framework for easier application tracking, given that our ecosystem is growing :)

Yes that'd be great as an increasing number of projects are dependent on snowpark

I have read the CLA Document and I hereby sign the CLA


parallel algorithm called inside annotated function throws exception

The following code is broken by

commit a238b890d3bd0b4bde1bb49eb8b5bc84472d644c
Merge: 5da331d 6c9af5e
Author: Hartmut Kaiser<EMAIL_ADDRESS>Date:   Sun Apr 16 09:08:13 2017 -0500
Merge pull request #2581 from STEllAR-GROUP/annotate_parallel_algorithms

Enable annotated function for parallel algorithms

Code:

#include <hpx/hpx.hpp>
#include <hpx/hpx_init.hpp>
#include <hpx/include/iostreams.hpp>
#include <hpx/parallel/algorithms/minmax.hpp>
#include <hpx/parallel/executor_parameters.hpp>
#include <vector>

double compute_minmax(const std::vector<double> v){

    hpx::parallel::static_chunk_size param;
    hpx::parallel::execution::parallel_task_policy par_policy;
    auto policy = par_policy.with(param);

    hpx::cout << "in compute_minmax: about to launch minmax element search." << std::endl;

    auto minmaxX_ = hpx::parallel::minmax_element(policy, v.begin(), v.end());
    auto minmaxX= minmaxX_.get();
    return *minmaxX.second - *minmaxX.first;
}

int hpx_main()
{
    std::vector<double> vec = {1.2, 3.4, 2.3, 77.8};
    double extent;

    hpx::async(hpx::launch::sync,
               hpx::util::annotated_function([&]() {
                   extent = compute_minmax(vec);
               }, "compute_minmax")

    );
    hpx::cout << "extent = " << extent << "\n";

    return hpx::finalize();
}

int main(int argc, char* argv[])
{
    return hpx::init(argc, argv);  // pass along command line arguments
}

Error message:

{version}: V1.0.0-trunk (AGAS: V3.0), Git: 521967cdba
{boost}: V1.63.0
{build-type}: release
{date}: Apr  5 2017 14:01:22
{platform}: linux
{compiler}: GNU C++ version 5.4.0 20160609
{stdlib}: GNU libstdc++ version 20160609
{what}: data has already been set for this future: HPX(promise_already_satisfied)
terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injectorhpx::exception >'
what():  data has already been set for this future: HPX(promise_already_satisfied)
Process finished with exit code 134 (interrupted by signal 6: SIGABRT)

@shoshijak I'm not able to reproduce this problem. Could you provide more information about how you built HPX (cmake log, build log) and how you executed the test?

I'm sorry, I cannot reproduce anymore either ...
It could be that I was building the test in a different build type than I had built HPX or something like that.


Github Action workflow base

Hello,
this is a skeleton CI workflow that allows to check if main is broken or not and ensure a minimal check coverage of 80 per cent. It's better of having nothing. As incremental we might add cppcheck and its custom rules for our use case both Misra/Autosar/cpp-core-guidelines to having better linted code,

Ok. asap I've capacity I fix and help it out. Btw who is leading the rust effort?

Daniel and Kai (from Etas & Bosch)
On Wed, Jan 10, 2024 at 5:21 PM Giorgio Zoppi @.***>
wrote:

Ok. asap I've capacity I fix and help it out. Btw who is leading the rust
effort?
—
Reply to this email directly, view it on GitHub
https://github.com/eclipse-uprotocol/uprotocol-cpp/pull/35#issuecomment-1885835167,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACDANOT3QBMAZJCRW2CMVB3YN4H5ZAVCNFSM6AAAAABBLW27CKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVHAZTKMJWG4
.
You are receiving this because you commented.Message ID:
@.***>

close this. reopening during with a consistent account.


Add Chelia Theme

@artemsheludko  Thanks for another great Jekyll theme. Keep it up. Cheers. Prost.


Script to backfill the accounts that aren't linked to SecurityHub

Describe the issue
A previous Landing Zone update misconfigured a config setting and the accounts that were made during the time period this LZ version was in affect didn't link properly to SecurityHub.  We need to fix that.
A bug in the SEA upgrade to 1.3.1 caused all accounts added since to have security hub disabled. We dont want to stay in this state but want it to be enabled.
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context

Issue is only present in LZ2. LZ1 was deployed after this was fixed in the ASEA code.
The field that was missing from config.json is "security-hub": true
When the field is present the state machine fails
Discussed with Ryan J, suggested that the solution is to write a script to manually subscribe all missing accounts to security hub. Once that is done we can add the field back to config.json and run the state machine.
Ryan J suggested writing a script to remediate.
Shea suggested toggling on and off again (test this in LZ1).

Definition of done

Write a script
Apply to LZ2
Pick someone from the team and show them that all the accounts have been fixed (can be a manual demo, just want show coverage).
All accounts have security hub enabled and subscribed to the master security hub in the security core account
"security-hub": true added to config.json after the above is done

Ryan J confirmed that bugs in the ASEA will prevent this from working correctly. Waiting for bug fixes in ASEA release.

Waiting for 1.5, verify that it has been solved

1.5 deployed to lz2. Verified that all accounts are now subscribed to securityhub


Finetuning on QM9, some tasks' loss suddenly become 'nan'

Hi, thanks for your great work, I want to reproduce the finetuning result of qm9, but i find some subtasks' loss suddenly change to 'nan' when finetuning;
such as Task dipole_moment:

and Task gap:

I use the same config (ET-QM9-FT.yaml) to all subtasks of QM9,  i am wandering whether it is proper to apply same hyperameters on all subtasks.
Look forward to your favourable reply， thanks！

Thanks for your reply,  i also find the 'nan' comes with the infinite intermidiate result of network, and add the normalization layer helps!  And I just notice that the QM9 results with denoising pretraining  from paper is based on the GNS-TAT architecture,  is that part of code avalible in this repo?

Great -- feel free to send PRs if you have any suggestions! The code for GNS-TAT is not yet open source. Unfortunately, I'm not sure if/when that will be made open source, but I'll let you know if there are any updates on this!

Thanks for your help again, i am clear now and close this issue


scadSimplifyLib

evaluate a form to simplify basic primitives for SCAD

1st version is OK. any future update need to be done in separate repository

future updates in https://github.com/ayaromenok/p3dLib/issues/1


Add mariadb plugin #1388

@lioolli please review this pr.

There're some issues with your tests.

move MariaDBTest to pinpoint-agent module. PinpointPluginTestSuite must be run after agent is built. Maybe init.sql file should go to pinpoint-agent too, then please put it under 'mariadb' directory not 'sql' to seperate plugin test resources per plugin.

add following annotations to MariaDBTest.

@JvmVersion(7)
@Repository("http://jcenter.bintray.com")

If you don't specify @JvmVersion, it runs test with Java 6, which cannot load mariadb classes complied by JVM 7. Because mariaDB4j is not in maven central repository, you have to specify @Repository too.

change database name in init.sql to 'test' not 'TEST'
When I run the test, it failed with ERROR 1049 (42000) at line 1: Unknown database 'TEST'

I will apply your suggestions later. Or I can remove this test totally. This test was useful only during debugging. What do you think?

I'm working on plugin pr check list now. One of the requirements is At least one plugin test. Even if nobody changes the plugin code, we need this test because agent(common, bootstrap, bootstrap-core, profiler module)  modification can cause plugin failure.

Merged with #1503


[REVIEW] FayasNoushad

Portfolio link
https://fayasnoushad.github.io

Portfolio Review
TLDR;
Your portfolio looks awesome! See the full details with my suggestions below.

Full details
Your portfolio looks awesome! Here some suggestions from my side:

Take a look at the repsonsivness of your website.
Also I ran lighthouse scores on your website

you cold take a look at these results

Otherwise really solid potfolio

The profile looks good,


Remove the opcodes::all module

The all module adds no value, we can remove it without loss of meaning or clarity, doing so makes the code less verbose.
Idea stolen from: https://github.com/rust-bitcoin/rust-bitcoin/pull/525 (patch 7)

I think we should also drop the OP_ prefix. Thoughts?

Perhaps rename module to op and drop the OP_ then common usage becomes, for example,op::VERIFY.

Yeah, I like that.

Drats, we can't do it because of things like OP_2DROP. We can do the module rename though.

 There are only a few of these opcodes and they are practically never used.
@Kixunil what would you think about this? It would be similar to renaming crate to krate elsewhere in the ecosystem.

_ at the beginning means "don't warn if this is unused" so I'd prefer to not do that. Raw identifiers can't begin with numbers either. If renaming 2DROP to DROP2 is no-go then we probably need to keep the OP_ prefix.

We should probably add a commit that adds a deprecated module opcodes and opcodes::all and just re-export everything from both.

By "deprecated" you mean just deprecated to use Rust Bitcoin devs, right? Remembering that I don't currently know of a way to deprecated modules.

Remembering that I don't currently know of a way to deprecated modules

Ah, damn, I forgot this.

know of a way to deprecated modules

That's good English, right there.

Friendly bump, is this one good to go in? Needs a second ACK if so please.

@Kixunil I tend to agree "let's not change this just to change it again". But I remain unconvinced that we can find a much better API than the current messy one.
Maybe if our only goal is to distinguish opcodes which are followed by other non-opcode data, from opcodes which are "zero sized", that would work since this is an unambiguous partition of all the opcodes. But "push vs non-push", "numeric vs non-numeric", cannot be so clearly separated.
This also maybe mixes in with #1324 because we may want some opcodes CHECKMULTISIG/CHECKSIGADD to only be available in certain contexts. I'm not sure if that'd affect this API.
It all seems like a big difficult problem.

Is your idea to just merge it nd iterate on that? That's not too bad for something you doubt can be done (I think it can).

But "push vs non-push", "numeric vs non-numeric", cannot be so clearly separated.

My design idea has no problem with that. The intention is mainly to verify an opcode is usable in certain context.

This also maybe mixes in with https://github.com/rust-bitcoin/rust-bitcoin/issues/1324

Yes, it does and my idea should work with it too. It'll be a bit more fiddly but not a huge issue, I think.

Is your idea to just merge it nd iterate on that? That's not too bad for something you doubt can be done (I think it can).

Yes, that's my vote -- though I expect that whatever we release in 0.30 won't be the final form, and that we'll have more breakage in 0.31.
If you want to avoid repeated breakage like that, we should hold off on merging this until we've come up with a more comprehensive design. I'd rather just move forward and iterate, though I don't feel super strongly.

OK, no problem with merging and I will try to find some time to sketch up alternative before 0.30 is released. But even then I don't expect 0.30 to become stable. The whole stabilization project is an insane monstrosity and will take time.

The whole stabilization project is an insane monstrosity and will take time.

Lolz, the same thought had occurred to me of late.

Mentioned in PR description but double posting, now includes importing with wildcard and removing the opcodes:: path from any type starting with OP_.

Ok, weak concept ACK on this design. I agree it's annoying to write op::OP_WHATEVER but I also really dislike wildcard imports because it mean that when you see OP_WHATEVER you can't tell where it came from by searching the current file.
But for opcodes maybe it's okay to make an exception because there's so many of them and they're all easily identifiable.

But for opcodes maybe it's okay to make an exception because there's so many of them and they're all easily identifiable.

hmmm, if you have any apprehension over wildcard imports then perhaps this PR is not good because it allows use of naked All, I maintained usage of opcodes::All even in a file with wildcard import but this is not enforced by the compiler. I'm ambivalent, both op::OP_FOO and wildcard with OP_FOO seem ok to me. Perhaps we should add re-name of opcodes module to op back into this PR then users have the choice of doing either? (And for our code we can just use the module prefix by convention for any type that does not have OP_ prefix.)

Oh, yes, accidental import of All is annoying. But maybe if it was named AnyOpcode instead it wouldn't be that bad.
One thing about wildcard imports: if you have only one it's easy to conclude "there's one wildcard import so the item must coms from it". It's still harder than not having it but the tradeoff seems in favor of using it here.

Huh, hilariously the wildcard usage is currently supported in a super clean way because we have the all submodule, instead of removing it, just use it as is currently possible.
Excuse the noise, this was a very roundabout way to find a pretty basic improvement, amusingly no one else saw it either :)

Do we want to keep the name all?

Yeah I rekon this usage by users of the lib reads nicely
use bitcoin::opcodes::all::*
use bitcoin::opcodes;


Page load problem in version 4.0.0

i am looking at version 4.0.0, looks great but I would like to point out a problem.
when I try to go to some pages via the menu on the left, the page becomes unresponsive for a moment, but this does not always happen. and then,  when I try a second time it usually goes that page. even stranger, sometimes after page unresponsiveness, the screen refreshes itself. seems to be a problem with installing dependencies on demand on vite

Seems to be vite related, added;
    optimizeDeps: {
        noDiscovery: true
    },


Enable globalnet in e2e and CI

Ready for review

@vthapar There seems to be an error in CI. Does not appear to be related to this PR. Any idea why its failing?
https://travis-ci.com/github/submariner-io/submariner-operator/jobs/298969902#L2256
Error deploying multi cluster service discovery: error federating MulticlusterService CRD: exit status 255
F0317 15:25:16.941977    1972 enable.go:110] Error: Error listing api resources: unable to retrieve the complete list of server APIs: types.kubefed.k8s.io/v1beta1: the server could not find the requested resource

@vthapar There seems to be an error in CI. Does not appear to be related to this PR. Any idea why its failing?
https://travis-ci.com/github/submariner-io/submariner-operator/jobs/298969902#L2256
Error deploying multi cluster service discovery: error federating MulticlusterService CRD: exit status 255
F0317 15:25:16.941977 1972 enable.go:110] Error: Error listing api resources: unable to retrieve the complete list of server APIs: types.kubefed.k8s.io/v1beta1: the server could not find the requested resource

This looks like kubefed didn't come up quickly enough.


Test new Github apps with minor updates to template

Proposed changes
This is a pull request to test out two new apps that have been added to the DEA Notebooks repository:

ReviewNB: https://www.reviewnb.com/

This will allow us to finally view detailed diffs for notebook changes, which should make reviewing notebooks easier

Pep 8 Speaks: https://pep8speaks.com/

This will give us immediate feedback on PEP8 compliance for code pushed to the repo

Hopefully these two apps will show up in the comments once it is posted!

Hello @robbibt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file Scripts/dea_datahandling.py:

Line 673:5: E128 continuation line under-indented for visual indent
Line 673:25: W292 no newline at end of file


404 response when editing IESG state of a doc that has no started_iesg_process state

Describe the issue
If a doc does not yet have a DocEvent with the started_iesg_process type, clicking the "Edit" button for the IESG state returns a 404.
If editing is not an option, the button should be hidden or disabled.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

attachments/files/17357984/plano.de.Teoloyucan22.pdf)
[czds-users-2023-01.csv])

czds-users-2023-01.csv


Could not find gem 'rails-assets-readmore (>= 0) ruby' in rubygems repository https://rails-assets.org/.

I'm getting an error that previously did not exist when running rails s on a project.
Gemfile
gem 'rails-assets-leaflet-iiif', '~> 0.0.3', source: 'https://rails-assets.org'
gem 'rails-assets-readmore', source: 'https://rails-assets.org'

Running bundle install seems to work fine, it just seems to error when running rails commands

Is it still happening? I cannot reproduce.
If it still happens, you create repository reproducing this issue?

Yes it is. I think we may be having the issue in that we are using rails-assets in an Rails engine. With the changes that happened (security issue) and not using a source block we seem to be having some strange things happen revolving around bundler and rails-assets. Removed rails-assets here: https://github.com/geoblacklight/geoblacklight/pull/282/files and will probably just hold off using unless we can specify source in a gemspec dependency.

Well, I woudn't recommend using rails-assets for gems anyway.
Rails Assets seems good fit only for applications.
On Fri, Feb 13, 2015 at 5:11 PM, Jack Reed<EMAIL_ADDRESS>wrote:

Yes it is. I think we may be having the issue in that we are using
rails-assets in an Rails engine. With the changes that happened (security
issue) and not using a source block we seem to be having some strange
things happen revolving around bundler and rails-assets. Removed
rails-assets here:
https://github.com/geoblacklight/geoblacklight/pull/282/files and will
probably just hold off using unless we can specify source in a gemspec
dependency.
—
Reply to this email directly or view it on GitHub
https://github.com/rails-assets/rails-assets/issues/225#issuecomment-74353857
.

:+1: gotcha thanks!

I was running up against this in an app, with rails-assets-angular. With an empty Gemfile, it worked just fine- as it turned out, it was a bundler issue I ran into only when configuring Bundler to use local gems. After upgrading Bundler from 1.8.2 to 1.8.4, it worked (I'm guessing because of bundler/bundler#3450). So if anybody else runs in to this, try upgrading Bundler.

Upgrading bundler did the trick for me as well.  Was running on 1.8.3 previously.


Case insensitive config paths

With this PR, config paths will be case insensitive.
Signed-off-by: Ricardo Marques<EMAIL_ADDRESS>

To implement this feature we are forced to override a private method from configshell.
Since we cannot guarantee this method will not be removed or changed in the future, and this is not a mandatory feature, I prefer to close this PR for now.
Ideally, the support for case-insensitive paths should be implemented in configshell itself.


derivative commands

I like \der, but the fact that partial derivatives are \D is a bit odd (from a semantic naming point of view).
Maybe we should change to \pder? Other ideas welcome.

Honestly looking through a bit more, that whole block of shortcuts needs some work. e.g. for some reason \hes doesn't allow numerator inputs

Feel free to make PR with better names. I'm not super attached and forgot some of these existed.
You could do \Der instead of \D.


Update global-shortcut.md

Make it clear that the global-shortcut module should not be used until the ready event of app module gets emitted.

@hokein Sample code updated.

Sample code indention problem fixed.

:+1:


Multivariate factorization Singular -> Nemo

Nemo has now multivariate factorization, so there is no need to do conversion to Singular for this purpose anymore in fast_factor.

Closed by https://github.com/SciML/StructuralIdentifiability.jl/pull/53


feat: btc on chain

very much a hacky WIP

relevant PR in the nuts repo: https://github.com/cashubtc/nuts/pull/107


Feature: Add initial functionality of drag and drop, add controls, add select box

fantastic work here @oliwierost, chatgpt and github copilot are a blessing also:DD


Collateral Damage (CDMG): Add auto generation features

Changes / Comments

Added randomization feature that will allow players to more easily generate a character from the sheet.
Updated sheet to work with CSE
Updated styling to make intractable objects more clear

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[x] Does this add functional enhancements (new features or extending existing features) ?
[x] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

Does this add functional enhancements (new features or extending existing features)? I've updated the sheet to include content that will allow us to randomize the fields based on content from the source material.
Does this add or change functional aesthetics (such as layout or color scheme)? I've updated the styling to be clearer for intractable objects and added new buttons for the new features.


Labels keybindings

Description
This PR addresses issue #2800, which suggested using numeric keybindings for labels tools. I have taken a similar approach to that outlined by @haesleinhuepf, but have used numbers 1-5 on the left side of the keypad. The numbers correspond to the left-to-right order of the tool icons in the interface.
The new keybindings are as follows:

"1" - erase
"2" - fill
"3" - paint
"4" - pick
"5" - pan zoom
"-" - decrement selected label number (minus sign)
"=" - increment selected label number (plus sign)

The graphics aren't quite up to scratch when compared to #2800 😄
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References
Issue #2800
How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Hi @AbigailMcGovern thanks for giving this a go - I know it was requested by @haesleinhuepf.
We've actually moved away from the explicit bind_key syntax. Instead we now register actions that then get shortcuts here https://github.com/napari/napari/blob/524491430cb48b629d9d3d20f2b56a8b2f3de57c/napari/utils/shortcuts.py.
I'm not sure if we now support multiple shortcuts for each action, but I might be more inclined to just leave this up to the user rather than add these in too. We could change our defaults, but I'm not sure. Maybe @jni can weigh in too.

We should use the new architecture by all means @AbigailMcGovern but @sofroniewn I do think we should make this the new default, for the reasons outlined by @haesleinhuepf in the original issue. @AbigailMcGovern and I have proofread volumes using both built-in and modified shortcuts, and it's night and day — having the shortcuts mapped to adjacent keys is game-changing for the ergonomics.

I just wanted to say: Thanks so much @AbigailMcGovern! I ❤ this PR 🙂

Ok, we can change the defaults. But then I think we should move to numerical defaults across all layers. It's strange if pan-zoom on points is a letter, but an unrelated number of labels. I think this will confuse a lot of folks otherwise.
Can we maybe get rid of these at the same time too https://github.com/napari/napari/blob/3bd58bde6858eb4d9f916fe32df262a4ebe1a24f/napari/layers/labels/_labels_key_bindings.py#L87-L124
I really don't like that pressing a modifier key changes the mode even if temporarily.

@sofroniewn

I really don't like that pressing a modifier key changes the mode even if temporarily.

Um, didn't you implement "hold space to pan/zoom"? 😂
At any rate, I'm not deathly opposed to doing that, but preserve labels in particular came from a user request and I'd like to discuss it as a separate issue/PR rather than bundle its removal here...
Sorry @AbigailMcGovern, hold please as we sort ourselves out... 😂

I actually like where this PR is right now and am fine with merging as is 🚀

Oh once, tests a fixed :-) As noted above https://github.com/napari/napari/pull/3072#pullrequestreview-710803157 the number of expected keybindings has now changed and the tests need to be updated. Should be a quick fix.
This all good with you then @jni?

@AbigailMcGovern, @sofroniewn and I had a long chat about this. He is concerned about two things:
(1) if we are going to tie shortcuts to the order of icons on the screen, then we should make sure the ordering makes sense. Right now things are basically where they landed when we first implemented the layer. 😂 Specifically: (a) it makes sense for paint and fill to be next to each other. (b) it makes sense for erase and paint to be next to each other. So this argues that the ordering should be erase-paint-fill-pick-panzoom.
(2) additionally, we probably want to then make sure that the buttons and shortcuts match up across layers. For example, selection should match up across points and shapes. Buttons that are not mode switches should not be part of the same part of the UI (for example, points deletion).
With the modifiers, I misunderstood his concern: the problem is that modifiers are used in other shortcuts, so we don't want modifier keys to temporarily switch modes, because e.g. typing Ctrl-C would see the mode flicker on and off when the user had no intention to deal with the mode. Instead the modifiers could either be read by the mouse event directly and the layer behaviour would be modified, or, we could use different hold keys.
I think point (2) should be done in different PRs to keep them all focused. So for this one, still to be done:

swap around the order of the paint and fill buttons
fix the failing tests

Personally, I would move the hold-modifier removal to its own separate PR, so that it's easy for users to find the change in release notes.

Thanks @AbigailMcGovern! Since @sofroniewn already approved this I'm going to merge, and make a follow-up issue to bring the remaining layers in line with these changes.


Updated theme

In this way we loose all the history from upstream. Shouldn't we pull from there?

Upstream seems deprecated. Pulling changes from that repo we've a lot of merge conflicts.


snow.asi error

I have FusionFix 1.96 installed on GTA 4 Patch <IP_ADDRESS>. Both the fusion overloader and vanilla option give a snow.asi not loaded error 126 prompt

it only works on 1080


Handle TimeSteps in GdalSource

This PR requires https://github.com/geo-engine/geoengine/pull/116

 TimeInterval von Queries in GdalSource berücksichtigen und testen

 TimeInterval von Queries in GdalSource berücksichtigen und testen

Please resolve the conflicts, then we can merge the PR.

Please resolve the conflicts, then we can merge the PR.


Support customized text for all aria-labels

The following represents the aria-labels used as of master 61b5322:

List / Slider: The aria-label can be customized with the option regionLabel; however, if you do not set a regionLabel then a hard coded "carousel" is used.
Item / Slide: The aria-label cannot customized. The aria-label is always set to "slide [number of slide]", example "slide 2".

Issues

List / Slider: The markup could have a aria-label or aria-labelledby that provides more details or is translated by a backend CMS (example Drupal).
Item / Slide: The hard coded value is not translatable and cannot be customized to provide a more specific label (example: "Image 1 of 5").

Desired Changes to support customizing the aria-labels

List / Slider:

If the slider element already has an aria-label or aria-labelledby then the slick library should not override it with the hard coded "carousel" or the options.regionLabel.

Item / Slide:

Add a customItemLabel function similar to customPaging that is passed the slider and the slide index. This would allow the caller to pass in a custom label function or use the default that would return "slide [number of slide]".
If the slide element already has an aria-label or aria-labelledby then the slick library should not override it with the customItemLabel.

Generic Example:
customItemLabel: function (slider, i) {
    return 'Image ' + (i + 1) + ' of ' + slider.$slides.length;
}

Example with Drupal:
customItemLabel: function (slider, i) {
    return Drupal.t('Image @index of @total', {
      '@index': i + 1,
      '@total':  slider.$slides.length
    });
}

The opened PR #87 makes the following changes:
List / Slider:

If the slider element already has an aria-label or aria-labelledby then the aria-label is not set with the hard coded "carousel" or the options.regionLabel.

Item / Slide:

Added a options.customItemLabel function similar to options.customPaging that is passed the slider and the slide index. This allows the caller to pass in a custom label function or use the default that would return "slide [number of slide]".
If the slide element already has an aria-label or aria-labelledby then the aria-label is not set with the customItemLabel.

@recrit : when will it be released to fix the problem

@achemkhi The PR #88 is opened for the accessible-slick maintainers to review, so it is up to them when it is released.


Install node-red-dashboard 2.0 fails via Manage Palette

Can't install this npm package
https://dashboard.flowfuse.com/getting-started.html

I tried installing via command line for npm and although it installs it does not appear after restarting Node-Red-Desktop:


Fix cmssw

Fix up the scram emulator to let a few unit tests succeed.

Beginning pylint and unit tests.
See https://cmssdt.cern.ch/jenkins/job/DMWM-PR-test/527/ for details

No pylint warnings for pull request 6223:

Unit test changes for pull request 6223:

WMCore_t.WMSpec_t.Steps_t.Executors_t.CMSSW_t.CMSSW_t:testA_Execute changed from failure to success
WMCore_t.WMSpec_t.Steps_t.Executors_t.CMSSW_t.CMSSW_t:testC_ExecuteSegfault changed from failure to success
WMCore_t.WMSpec_t.Steps_t.Executors_t.CMSSW_t.CMSSW_t:testD_ExecuteNoOutput changed from failure to success

@ticoann please merge this


Update ipv6-overview.md

Added Azure Firewall under limitations, as Azure Firewall currently does not support IPv6. We were challenged by this is a past project, and the Azure Firewall documentation also clearly mentions this.  https://docs.microsoft.com/en-us/azure/firewall/overview

Learn Build status updates of commit e6029d5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/virtual-network/ip-services/ipv6-overview.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@asudbring,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

Learn Build status updates of commit 966e69e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/container-registry/scan-images-defender.md
:warning:Warning

Details

articles/virtual-network/ip-services/ipv6-overview.md
:white_check_mark:Succeeded

articles/container-registry/scan-images-defender.md

Line 14, Column 20: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/defender-for-cloud/defender-for-containers-va-acr' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 15, Column 20: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/defender-for-cloud/defender-for-containers-introduction' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 19, Column 179: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/defender-for-cloud/defender-for-containers-va-acr#view-and-remediate-findings' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 23, Column 18: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/azure/defender-for-cloud/defender-for-containers-va-acr' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 14, Column 20: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/defender-for-cloud/defender-for-containers-va-acr' will be broken in isolated environments. Replace with a relative link.
Line 15, Column 20: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/defender-for-cloud/defender-for-containers-introduction' will be broken in isolated environments. Replace with a relative link.
Line 19, Column 179: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/defender-for-cloud/defender-for-containers-va-acr#view-and-remediate-findings' will be broken in isolated environments. Replace with a relative link.
Line 23, Column 18: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/azure/defender-for-cloud/defender-for-containers-va-acr' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Issue/#55

@rultor merge please

@rultor merge please

@gilraenburland OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge please

@gilraenburland Done! FYI, the full log is here (took me 5min)


Add entrypoint URL prefix configuration to new web bootstrapping

Similar to entrypointUrl in the previous API to configure the directory that main.dart.js (and now other files) will be found in. This should be separate from the page's base href value.

Added a entrypointBaseUrl option in https://github.com/flutter/engine/pull/53231


Remove gap boilerplate

PR to respond to https://github.com/embassy-rs/trouble/issues/142
This is intended to remove additional boilerplate and make setting up a BLE server more accessible for beginners.
As the Generic Access Profile (GAP) service is required, this reduces the user error chance of

not creating it
not understanding what it means
creating it multiple times

but currently still allows the existing API let server = server::new(stack, &mut table); if this is preferred for a reason I'm not aware of.
I've also added some example Appearance UUIDs and a helper function to generate more, as this was something I found confusing to understand.  These UUIDs and others from the spec might be best pulling out into a separate crate in future?
The GATT related modules might also benefit from being reorganized into a module tree in future instead of the current flat hierarchy?

/test

/test

It might make sense to put the UUIDs in the bt-hci crate, along with the other Bluetooth assigned numbers.
We'll also want to create a GATT service along with the GAP service. It defines characteristics like Service Changed, Client Supported Features, Server Supported Features, and DatabaseHash.

/test

/test

Ok, I think it should work now, I had to add you as a collaborator. Please rebase first.

/test


age 2+ in table 18

In Table tables-timeseries.r
I think we just need to change
tot.bm <-
ts$Bio_all[ts$Yr %in% yrs]
to
tot.bm <-
ts$Bio_smry[ts$Yr %in% yrs]
in

Also need to change load-models to make extra.mcmc$timeseries$Bio_smry reflect the median, not the MLE.
Also will need to change the caption and header in the table.
I'll work on this now.

Not fully following, but aren't we adding a column rather than replacing one?
Seems a bit dangerous to redefine something like tot.bm, as it may get used elsewhere.

Good points. I will make it adding a column, rather than renaming.
And regardless will use a different variable name for age-2+ rather than changing tot.bm.

Commit b2b2d93 adds Age-2+ column to Tables 18 and 19 (snipped below).
This requires getting extra values from the timeseries tables in the extra-mcmc report files, everyone needs to delete \models\2018.40_base_model\2018.40_base_model.RData
and re-run build()
Here is the checklist once you've rebuilt your RData file:

[ ] Ian
[ ] Aaron
[ ] Andy
[ ] Chris

I was last to do this which [presumably] my lack of speed gives my the opportunity to close.... doing now

Change somehow got lost in Table 18, added back in d0466cc.

Closing, presuming that people will delete knitr-cache at some point (I just did, and presumably I'd submit the final version).

Somehow the edits to Table 18 in commit b2b2d93f794ea87d06f4645096704e113e2c8bf6 were lost.
I can't figure out how they disappeared to have just manually restored them them in commit a48ebe0.

I have them okay. Something funny happened earlier with one of my edits also.  Presume you deleted knitr-cache.


Add favicon for website

Summary
Add favicon-96x96 icon for website.

Hello @WillemJiang Dear Teacher Jiang, could you help review this, thanks!


[review] PDF Figure Sizes

Describe the bug
It looks like we may need to figure out a way to harmonise figure/image sizes between html and pdf outputs.
The following pdf file for https://python-programming.quantecon.org/intro.html using jupyterbook-latex for comparisons.
These figures from the website are very small in the pdf file with corresponding myst:
```{figure} /_static/lecture_specific/about_py/python_vs_matlab.png
```

and tex is:
\begin{figure}[htbp]
\centering

\noindent\sphinxincludegraphics{{python_vs_matlab}.png}
\end{figure}

I am surprised by the big difference given there are no scale parameters being used.

I think we need to look at either:

an automatic scaling factor between html and latex (if possible, to reduce the need for metadata)
enable some metadata for scaling images specifically in latex context.


Antidepressants / Mood boosters

To be taken daily.  Can have side effects if no longer being taken after X amount of time

Works perfectly. Might need balancing and requires texture.

Cool idea!  I'd say some of the most popular antidepressants are SSRI (selective serotonin reuptake inhibitors), e.g. sertraline (Zoloft) and fluoxetine (Prozac).  Typically you have to wait a few weeks until they're effective.
More information:
https://en.wikipedia.org/wiki/Selective_serotonin_reuptake_inhibitor#List_of_SSRIs
Taking too many SSRIs can result in serotonin syndrome


[WIP] stream_sort: Live toggle inactive class for pins.

#8201
Testing Plan:
GIFs or Screenshots:

@YashRE42 I notice this is still tagged WIP -- what's it's status?

@timabbott, This has PR has the latest changes pushed here. I just need to figure out exactly where we're losing test coverage and fix that so CI doesn't fail.

@YashRE42 hmm, that's interesting.  Definitely worth investigating ; it's not obvious why this change would impact that...

@timabbott I managed to fix this.
Apparently, trying to have my own (create_mars_sidebar_row()) method was causing the problem...
We were losing coverage because row === undefined prevented anything from hitting line 82.
        if (row === undefined) {
            return;
        }
        row.highlight();       <--- line 82

Wish there had been a less roundabout way to realize what was wrong.

Hey Tim, it's been about two weeks, please have a look at this when you have time @timabbott

@YashRE42 sorry, I missed this because GMail incorrectly had your last email threaded with "WIP" in the subject line.  I guess for future reference, don't spell WIP as [WIP] -- that makes email thread confusingly.
This is great, merged as 1ab4eaf819717e068df54d03e5dbb6d5210bfafb, after writing a proper commit message for it that auto-closes the original issue and explains the background behind this change for posterity.  Thanks @YashRE42!

Oh, okay, sorry about that, I presume (WIP) is okay though?

Yep, or what I usually write is WIP: Description of the PR


Update workspaceRP swagger with automation result

ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[x] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[x] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

The LintDiff Error seems wrong, I don't see any difference between the PUT body and 200 response schema.

@ZhidaLiu Please reach out to Azure Breaking Changes Reviewers<EMAIL_ADDRESS>to get a breaking changes approval and ARM can review the changes afterwards. Once you have the approval, please remove the "ARMChangesRequested" label from the PR to make the PR visible to the ARM reviewers.

@ms-zhenhua I got the breaking change approve, please help review again, thanks~

    "operationId": "outboundNetworkDependenciesEndpoints",

should be "outboundNetworkDependenciesEndpoints_ListByWorkspaceName

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:952 in b75c10e. [](commit_id = b75c10eb9fa1d12d00774292de60ae6d941c2c24, deletion_comment = False)

        "type": "boolean",

recommend use "enum" instead of "boolean"

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:184 in b75c10e. [](commit_id = b75c10eb9fa1d12d00774292de60ae6d941c2c24, deletion_comment = False)

        "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter"

please consider alway use the latest common type version, current latest is "v5". Please also replace other places

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:279 in b75c10e. [](commit_id = b75c10eb9fa1d12d00774292de60ae6d941c2c24, deletion_comment = False)

        "type": "boolean",

recommend use "enum" instead of "boolean"
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:184 in b75c10e. [](commit_id = b75c10e, deletion_comment = False)

May I ask why? this is a boolean flag is used to indicate if this delete request wants to purge the resource or soft-delete it, any reason why we want to change to enum?

        "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter"

please consider always use the latest common type version, current latest is "v5". Please also replace other places
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:279 in b75c10e. [](commit_id = b75c10e, deletion_comment = False)

I need to check the change between v3 and v5, I will make this change in a separate PR and also update the swagger generation tool we use to point to v5.

        "type": "boolean",

recommend use "enum" instead of "boolean"
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:184 in b75c10e. [](commit_id = b75c10e, deletion_comment = False)

May I ask why? this is a boolean flag is used to indicate if this delete request wants to purge the resource or soft-delete it, any reason why we want to change to enum?

It explains. However, it's not required.
https://github.com/Azure/azure-openapi-validator/blob/main/docs/enum-instead-of-boolean.md#why-the-rule-is-important

},

please expand it to a model:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/properties-type-object-no-definition.md

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:1742 in 08e9740. [](commit_id = 08e974077ff4d3b0017b0de936feb7a3c5656e03, deletion_comment = False)

      "additionalProperties": {

additionalProperties is not allowed, please use array:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/avoid-additional-properties.md

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:3017 in 08e9740. [](commit_id = 08e974077ff4d3b0017b0de936feb7a3c5656e03, deletion_comment = False)

    "description": "Lists all of the available Azure Machine Learning Services REST API operations.",

please add "description" back

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:42 in 08e9740. [](commit_id = 08e974077ff4d3b0017b0de936feb7a3c5656e03, deletion_comment = True)

      "final-state-via": "location"

LRO put should use 201 and "azure-async-operation", any reason to use "location" here?:
https://armwiki.azurewebsites.net/api_contracts/guidelines/rpaas.html#rpaas001-rpaas-supports-201--provisioning-state--azure-asyncoperation-pattern-only-for-put-long-running-operations

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:384 in 08e9740. [](commit_id = 08e974077ff4d3b0017b0de936feb7a3c5656e03, deletion_comment = False)

@ZhidaLiu It seems you change the original paths order and operations order. Though I do not know why you did this, but it causes a huge diff. This diff generates many unnecessary lint error and warning and make review much harder. Could you revert the order to make the process easier?

@ZhidaLiu It seems you change the original paths order and operations order. Though I do not know why you did this, but it causes a huge diff. This diff generates many unnecessary lint error and warning and make review much harder. Could you revert the order to make the process easier?

The order change is because the previous swagger file is manually maintained and people put path and definition in random order, this time  the swagger is generated based on our server-side code automatically and this will prevent human errors in the future, so we would like to keep this new alphabet order.

      "final-state-via": "location"

LRO put should use 201 and "azure-async-operation", any reason to use "location" here?: https://armwiki.azurewebsites.net/api_contracts/guidelines/rpaas.html#rpaas001-rpaas-supports-201--provisioning-state--azure-asyncoperation-pattern-only-for-put-long-running-operations
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:384 in 08e9740. [](commit_id = 08e9740, deletion_comment = False)

This is a existing API behavior, I can create a work item on reflect this in the future.

All the comments are reflected, now the lint issue introduced is about boolean->enum, we will consider later which will require a server-side change.
@ms-zhenhua please help review again, sorry about the problem caused by reorder the path and definition, but this is needed as we are move to auto-gen swagger and things are in alphabetical order, this will prevent us many time and efforts also reduce human error.

@ms-zhenhua  I added a commit with only re-order the path and definitions of the previous workspaceRP.json file, hope this will help your review process, we really need to reorder this file to leverage the automation tool, sorry for the inconvenience for your review process.
Now you can check my change compared to the previous workspaceRP.json based on this commit:https://github.com/Azure/azure-rest-api-specs/pull/24333/commits/029efe4af92e0d703ee6ea47ef8db82cae1085b2

  "put": {

why remove DELETE? DELETE is required with PUT:
Inconsistent or incomplete CRUD in https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html#common-issues-found-in-review

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:1099 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

      "additionalProperties": {

additionalProperties is not allowed, please use array instead:
https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi032-only-use-additionalproperties-when-the-object-properties-are-dynamic-unknown-or-user-defined

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:1766 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

    "cosmosDbResourceId": {

define "x-ms-secret" if it's a secret value:
https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-secret

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:2000 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

    "searchAccountResourceId": {

define "x-ms-secret" if it's a secret value:
https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-secret

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:2012 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

    "storageAccountResourceId": {

define "x-ms-secret" if it's a secret value:
https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-secret

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:2019 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

    "keyIdentifier": {

define "x-ms-secret" if it's a secret value:
https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-secret

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:2178 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

    "isPrivateLinkEnabled": {

consider using enum:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/enum-instead-of-boolean.md#why-the-rule-is-important

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:2427 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

    "provider": {

is it enumerated?

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:2452 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

    "resource": {

is it enumerated?

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:2456 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

    "id": {

consider using  arm-id: http://azure.github.io/autorest/extensions/#x-ms-arm-id-details

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:3207 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

    "subnetArmId": {

consider using  arm-id: http://azure.github.io/autorest/extensions/#x-ms-arm-id-details

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:3215 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

      "type": "boolean"

consider using enum:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/enum-instead-of-boolean.md

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:3262 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

    "v1LegacyMode": {

consider using enum:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/enum-instead-of-boolean.md

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:3417 in 1fad5a0. [](commit_id = 1fad5a0285ba1cbdb39d3187d450902bb25d3ea8, deletion_comment = False)

      "type": "object"

provide the schema or define it as string: https://github.com/Azure/azure-openapi-validator/blob/main/docs/properties-type-object-no-definition.md#propertiestypeobjectnodefinition
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:3090 in 1fad5a0. [](commit_id = 1fad5a0, deletion_comment = False)

This is a user-defined object we provide for partner service to store meta-data of this connection, we defined it as a Dictionary<string, IValue> where IValue can be string or another layer of Dictionary<string, IValue>, so in this case I guess it should be defined as an object without schema?

  "put": {

why remove DELETE? DELETE is required with PUT: Inconsistent or incomplete CRUD in https://armwiki.azurewebsites.net/rp_onboarding/process/api_review_best_practices.html#common-issues-found-in-review
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:1099 in 1fad5a0. [](commit_id = 1fad5a0, deletion_comment = False)

Good catch, this is caused by a code bug making the generation tool ignore this API, already fixed and added back

"additionalProperties"

      "additionalProperties": {

additionalProperties is not allowed, please use array instead: https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi032-only-use-additionalproperties-when-the-object-properties-are-dynamic-unknown-or-user-defined
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:1766 in 1fad5a0. [](commit_id = 1fad5a0, deletion_comment = False)

@ms-zhenhua What should be the correct schema for Dictionary<string,string>? according to this document this additionalProperties is used correctly: https://swagger.io/docs/specification/data-models/dictionaries/

@ZhidaLiu Could you define it as a model of array? The model may look like:
"CustomKey": {
"type": "object",
"properties": {
"keyName": {
"type": "string",
...
},
"keyValue": {
"type": "string",
...
},
},
}

      "202": {

202 must have a location header:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/lro-location-header.md
If it inherits from the previous version, it may be caused by the order change. Please follow this guidance to suppress it:
https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:682 in 1b66d93. [](commit_id = 1b66d934fd01e7eb9edc5aa905eb65d15c2c1619, deletion_comment = False)

        "$ref": "./examples/ManagedNetwork/deleteRule.json"

This file is not found. Please check.

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:697 in 1b66d93. [](commit_id = 1b66d934fd01e7eb9edc5aa905eb65d15c2c1619, deletion_comment = False)

      "type": "object"

provide the schema or define it as string: https://github.com/Azure/azure-openapi-validator/blob/main/docs/properties-type-object-no-definition.md#propertiestypeobjectnodefinition
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:3090 in 1fad5a0. [](commit_id = 1fad5a0, deletion_comment = False)

This is a user-defined object we provide for partner service to store meta-data of this connection, we defined it as a Dictionary<string, IValue> where IValue can be string or another layer of Dictionary<string, IValue>, so in this case I guess it should be defined as an object without schema?

If the IValue has a schema, you can define it as a model of array. The model can contain the key and the flattened IValue.

"additionalProperties"

      "additionalProperties": {

additionalProperties is not allowed, please use array instead: https://armwiki.azurewebsites.net/api_contracts/guidelines/openapi.html#oapi032-only-use-additionalproperties-when-the-object-properties-are-dynamic-unknown-or-user-defined
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:1766 in 1fad5a0. [](commit_id = 1fad5a0, deletion_comment = False)

@ms-zhenhua What should be the correct schema for Dictionary<string,string>? according to this document this additionalProperties is used correctly: https://swagger.io/docs/specification/data-models/dictionaries/

@ZhidaLiu Could you define it as a model of array? The model may look like: "CustomKey": { "type": "object", "properties": { "keyName": { "type": "string", ... }, "keyValue": { "type": "string", ... }, }, }

If it is defined as what you suggest then it's not a dictionary and it will remove the relation between keyName and keyValue right? I can see places in swagger using additionalProperties to define a Dictionary like here , why do we want to prevent this?

      "type": "object"

provide the schema or define it as string: https://github.com/Azure/azure-openapi-validator/blob/main/docs/properties-type-object-no-definition.md#propertiestypeobjectnodefinition
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:3090 in 1fad5a0. [](commit_id = 1fad5a0, deletion_comment = False)

This is a user-defined object we provide for partner service to store meta-data of this connection, we defined it as a Dictionary<string, IValue> where IValue can be string or another layer of Dictionary<string, IValue>, so in this case I guess it should be defined as an object without schema?

If the IValue has a schema, you can define it as a model of array. The model can contain the key and the flattened IValue.

The IValue don't have a schema and that's the point of letting it become a user-defined schema, so basically they can put as many layer as they want like this:
"metadata" : {
        "object1" : "value1",

        "object2" : {

            "nestObject1" : "value1",

            "nestObject2" : "value2"

        }

    }

      "202": {

202 must have a location header: https://github.com/Azure/azure-openapi-validator/blob/main/docs/lro-location-header.md
If it inherits from the previous version, it may be caused by the order change. Please follow this guidance to suppress it: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:682 in 1b66d93. [](commit_id = 1b66d93, deletion_comment = False)

Update the suppression, thanks

@ms-zhenhua I updated the swagger with your comment considered, but for the additionalProperties and the metadata schema, I think they are by design and reflect what we expected in our service-side code, unless you can provide a way to describe those types without changing our service-side design. Please help take a look and approve if it was fine.

  "delete": {

Is this added in this new API version only? You should fix the location header for 202. Also do you have a plan/workitem for fixing the bad pattern from existing API?

Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:1053 in dea1aae. [](commit_id = dea1aae605caec154653c04349cda6c09a3d85be, deletion_comment = False)

  "delete": {

Is this added in this new API version only? You should fix the location header for 202. Also do you have a plan/workitem for fixing the bad pattern from existing API?
Refers to: specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2023-06-01-preview/workspaceRP.json:1053 in dea1aae. [](commit_id = dea1aae, deletion_comment = False)

Nope this is already exist in the older API version, I will create a work item to update server side

Remove suppression review tag as suppression is removed

@ms-zhenhua I updated the swagger with your comment considered, but for the additionalProperties and the metadata schema, I think they are by design and reflect what we expected in our service-side code, unless you can provide a way to describe those types without changing our service-side design. Please help take a look and approve if it was fine.

Please have a work item for future plan to make the change in future version, you should make back-comp update on service side and take the suggested changes for your API in next version.

@ms-zhenhua I updated the swagger with your comment considered, but for the additionalProperties and the metadata schema, I think they are by design and reflect what we expected in our service-side code, unless you can provide a way to describe those types without changing our service-side design. Please help take a look and approve if it was fine.

Please have a work item for future plan to make the change in future version, you should make back-comp update on service side and take the suggested changes for your API in next version.

Task 2470537: Update Metadata and new connection credential to avoid additional properties
thanks, here is the work item to track on the additional property change on the server side


Core: Add constexpr to if (true) error macros

By converting if (true) to if constexpr (true) in error macros, the binary size shrinks a fair amount (release template: ~8KiB, dev editor: ~27KiB) & additional compile-time checks are enabled (if extra warnings are enabled) by detecting if a returning macro causes inaccessible code.

Did some more testing and it seems this can be even more optimized. By wrapping every error macro (excluding one-liners) with if constexpr (true), it shrunk by another KiB! But, I'll be honest, I'm not entirely sure why that worked; and because I'm uncertain, I decided that's outside the PR's original scope. I'll try to look more into it and, if it's consistent, maybe I'll look into it as part of a broader error_macros.h refactor/cleanup.

I'm curious: does this have any effect on release builds?
My expectation is that every compiler in existence would have a good enough optimizer to handle an if (true) - what optimization can it do with if constexpr (true) that is somehow not possible with if (true)?
Sorry if this sounds like an obvious question, but I haven't actually been able to find an answer to this question using a search ("if constexpr true" actually has very few google results) so I figured I'd ask here.
Is some c++ feature like exception handling preventing the optimization of if true?

Stripped binary sizes for Linux x86_64 optimize=speed lto=full:
Editor:
master:  113,745,696 bytes
This PR: 113,745,696 bytes

Release export template:
Master:  64,399,656 bytes
This PR: 64,395,560 bytes

Why not use something like this?
#define ERR_FAIL()                                                                     \
	{                                                                        \
		_err_print_error(FUNCTION_STR, __FILE__, __LINE__, "Method/function failed."); \
		return;                                                                        \
	}

Why not use something like this?
#define ERR_FAIL()                                                                     \
	{                                                                        \
		_err_print_error(FUNCTION_STR, __FILE__, __LINE__, "Method/function failed."); \
		return;                                                                        \
	}

See the comment before all these macro definitions:
 * The `((void)0)` no-op statement is used as a trick to force us to put a semicolon after
 * those macros, making them look like proper statements.
 * The if wrappers are used to ensure that the macro replacement does not trigger unexpected
 * issues when expanded e.g. after an `if (cond) ERR_FAIL();` without braces.

If more recent C++ has a better trick to achieve that, we can use it of course. But last we checked this kind of if (cond) else ((void)0) hack was still needed.

So maybe it's better to use this where there is if (true)
#define ERR_FAIL()                                                                     \
{                                                                                \
	_err_print_error(FUNCTION_STR, __FILE__, __LINE__, "Method/function failed."); \
	return;                                                                        \
}                                                                                \
((void)0)

It behaves the same way and we need to use ;.

True, but see the second part of the comment I quoted. This would allow doing
if (cond) ERR_FAIL();

Or even
void SomeClass::some_func() ERR_FAIL()

Which, while unlikely, would be pretty cursed. I don't recall if there were more realistic scenarios when we decided to use this wrapper.

Yep, but without if it's also posible to
if (cond) ERR_FAIL();

Ultimately decided to broaden the scope of this PR to give the if constexpr (true) treatment to all of them. Because this technique is actually much more broadly applicable than just the error macros (several other files use similar if-wrappers), I've added new macros to core/typedefs.h so subsequent PRs can take advantage of them.
The only other minor changes were forward-declaring ObjectID instead of including it in the header & ensuring DEV_ASSERT/DEV_CHECK_ONCE require trailing semicolons even when DEV_ENABLED isn't defined.


rustup

Cc https://github.com/rust-lang/rust/issues/86723

@bors r+

:pushpin: Commit e33bf695db921a08e89bf8efb7572a51a0c86917 has been approved by RalfJung

:hourglass: Testing commit e33bf695db921a08e89bf8efb7572a51a0c86917 with merge 61605ebde25f920b18cc2f7e1b92838cd7b6fa67...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 61605ebde25f920b18cc2f7e1b92838cd7b6fa67 to master...


Add support for Preserve to boost timers

We'd need to nail down what the threshold for the effect kicking in is. This reddit thread has some accurate-looking information about the stat-drain stuff in general:
before, every 1 minute your stats drop. logging out refreshes this timer

now every 12 seconds your stats get marked and after 5 marks,
or 6 with preserve, your stats drop. logging out resets the 12 second timer
but not the marks, so if you log out every 12 seconds your stats will never drop,
but if you wait 50 seconds, after which youll have 4 marks,
when you relog in youll still have those 4 marks so 12 seconds later your stats will drop

Discussion in discord has made it sound like it's something like "if you've had preserve on for the last 15 seconds, and a normal stat boost drain would have happened this tick, delay that stat boost drain by 30 seconds". Given the 12 second threshold for preserving a boost by logging out, the preserve threshold may be 12 seconds, rather than 15.

How does the current boosts plugin work? If it doesn't take the reworked system with "marking" each boost every 12 seconds into account, it'd be nice to get this even without the preserve prayer.

Fixed in #3530


Expand Admin Panel Capabilities - change board name and logo

Create an Admin Settings tab in the Admin Panel that lets admin users change the name and logo (via image URL) of their board.
Pretty significant structural changes to frontend code, might need some extensive review
Add a "settings" singleton model to the DB, which will also be used for more admin (or non-admin) settings in the future.
Add various TODOs for fixing issues in the project (for example, a key security vulnerability in the backend that I will create an issue for)
Add some important startup information (about local mongodb) to the README.md
Various spelling/grammar fixes

Please let me know what you guys think, and I apologize if this is too much stuff for one PR, but since the project is a POC anyway, hopefully it shouldn't be a big deal. Feel free to pull the branch and test out the feature locally.

NOTE: There is a race condition I'm working on fixing real quickly in the Settings actions

Code style looks solid, have not yet tested the functionality. Can we make an issue to fix the admin security issue?

Yup, I'll create that issue right now

Looks good. One more change. Can you show ability to go to the admin panel on the home page if you are an admin?

Oh yeah good call. Willdo!

Added a link to the Admin Panel in the UserMenu @PimDeWitte


support ESP32-S2-DevKitM-1

Is it possible to use ESP32-S2-DevKitM-1 for ioter ?
https://docs.espressif.com/projects/esp-idf/en/latest/esp32s2/hw-reference/esp32s2/user-guide-devkitm-1-v1.html

I checked ESP devkit support thread rcp & ioter. Thanks.


Work universally (server-side, in builder, in browser)

These changes preserve how it worked in the builder and in the browser, but adds support for using it server-side for universal apps. I was getting 'window is not defined' errors previously.

I will review and merge so long as nothing comes up. Will be tomorrow i imafine. Many thanks for the PR.

Looking at the code i remembered having a window check in before and in my PR to the registry, Guy suggested i use this.builder == true here
Your change makes sense, i would say though and i'm happy to use window again. I've not been using the plugin server-side so its an interesting and useful for me.

I'm going to merge this and fix my Travis build too. A bit annoying that its not working... will update the dependencies too, see if i can't get this back to a green light too.

Released now with some other tweaks too - v0.2.7


Build a simple pub-sub API (streams?) for communicating with the platform

A pub-sub pattern is currently possible to implement via a combination of MethodChannel & EventChannel as demonstrated in the platform_channel example, but the API results in a bit of a messy code base - both in the platform and in the Flutter code - you create multiple objects in both platforms and catch events in anonymous classes living in different scopes.
Would it be possible to implement, for example, a 2-way stream-based API for communicating with the platform?
Streams/event buses are well understood and provenly result in elegant manageable code, there are also multiple libs to lean on both in the platform world and in the Flutter space to make this experience really nice (RxJava, RxDart, RxSwift, ...) - it'd literally allow the same patterns to be used on both sides of the fence making matters very easy to compare & understand.
Feature request inspired by investigation following my SO question on the subject

We're not going to do this. Instead we're investing in ffi/jni as the future of platform interop, removing the need for async messages


[SQA] [TC-OO-2.3] - Step 10e doesn't return expected outcome

[TC-OO-2.3]
In the above mentioned test-case in step 10e we are facing issue as explained below
Expected outcome - on-off value should be true
Actual Outcome -  on-off value  should be false
Steps to reproduce - ./chip-tool onoff read on-off 949 1
Attached Logs:
tc-oo-2.3 error log.txt

@jmartinez-silabs could you take a look?

Testing it on my end. Work correctly for me.
First parameter of the command is set to 1, which means :
The AcceptOnlyWhenOn sub-field is 1 bit in length and specifies whether the OnWithTimedOff command is to be processed unconditionally or only when the OnOff attribute is equal to TRUE. If this sub-field is set to 1, the OnWithTimedOff command SHALL only be accepted if the OnOff attribute is equal to TRUE. If this sub-field is set to 0, the OnWithTimedOff command SHALL be processed unconditionally.
I don't see in your log if the onoff attribute was on (TRUE) before starting the test but you need it else all commands are ignored in this case.
I will let you test it out again before closing the ticket

I see it works fine with the latest commit id 2982c0ca0623773327def4cc7180d07f6b959c42