Improve nodes

I implemented a few features for nodes.

@AlexKiryanov had the idea to implement the ping-pong operation (it's a saw-tooh function) for the math node. I also implemented it for the brush math node and will open a pull request when I'm at home again.
Normal map node: It works a bit like Blender's node but is compatible with ArmorPaint and has fewer features. To be precise it takes a normal map texture, changes the strength and returns a normal map texture again. This differs from Blender as Blender takes a normal map texture and produces a normal map.
Invert color option for the image node. It gives the user the option to invert colors (after converting to a color space). I think this is useful for masks as well as for importing smoothness textures.

Thanks a lot!

Wow that was quick. Thank you very much!

Thank you both guys) The good gets even better) That's what I'm thinking now)
Florian, I honestly haven't tested ping pong yet, I'll compile a new version and compare it with a blender. But the formula that I sent you must be correct)


[ROCm] improve concurrency between compute and nccl streams

The NcclManager records and waits on an Event as each Participant is added,
rather than synchronizing with the compute stream only after all Participants
have been added. Otherwise, most compute kernels are added to the compute
stream prior to the NCCL sync Event, delaying the start of the collective.

I can reliably reproduce a training failure (network produces NaNs after 5~20min of training) with this PR and the failure does not appear when using the commit before this PR.
My training setup is quite complicated so before working with someone to reproduce it, I'm looking for some ideas on why this PR may affect my training and how I may do some debugging myself.
The way my training use nccl is:

I'm on a DGX with 8 V100s
NcclAllReduce is the only nccl op I'm using (and I do it with the python API nccl_ops.all_sum. This is different from the other op "CollectiveReduce" which also ends up using nccl.
If I rewrite nccl_ops.all_sum in my code by using collective_ops.all_reduce, the failure seems to disappear (I'll run more tests to verify)


Unable to show img on the page

I have put an image under "myProject/assets/img/download.png".
And then I put the following code on this project
src="/img/download.png"
After refreshing, the image file does not show up on the page.

The project is set up according to the 'getting started' guide.
Environment:

Python Version: 3.7.4
Pynecone Version: 0.1.18
OS: Windows Server 2019
Browser (Optional): Chrome

Hey @johnvonneumann36 you should update your pynecone version to v0.1.20

Hi, @ElijahAhianyo I have tried to update my pynecone version to v0.1.20, but it seems not to support pandas dataframe anymore.

Hi, @ElijahAhianyo I have tried to update my pynecone version to v0.1.20, but it seems not to support pandas dataframe anymore.

Pandas dataframes are still supported. Could you describe what issue you face with 0.1.20 and with code example if possible?

from pcconfig import config
import pandas as pd
import pynecone as pc

docs_url = "https://pynecone.io/docs/getting-started/introduction"
filename = f"{config.app_name}/{config.app_name}.py"

class State(pc.State):
    _backend: pd.DataFrame = pd.DataFrame()

    @pc.var
    def get_df_result(self):
        return self._backend

    def submit_click(self):
        d = pd.DataFrame(data={'col1':[1,2], 'col2':[1,2]})
        self._backend = d

def index():
    return pc.box(
        pc.hstack(
            pc.button("Submit", on_click=State.submit_click),
            pc.data_table(
                data=State.get_df_result,
                overflow_x="scroll",
                width="100%",
                pagination=True,
                search=True,
                sort=True,
                font_size="1em",
                resizable=True,
                display='none',
            ),
            spacing="1.5em",
            font_size="1em",
        ),
        width="100%",
        padding_top="5%",
    )

# Add state and page to the app.
app = pc.App(state=State)
app.add_page(index)
app.compile()

Compared with v 0.1.18, running the same code with v 0.1.20 will throw an AttributeError.
Traceback (most recent call last):
  File "C:\Program Files\Python37\lib\multiprocessing\process.py", line 297, in _bootstrap
    self.run()
  File "C:\Program Files\Python37\lib\multiprocessing\process.py", line 99, in run
    self._target(*self._args, **self._kwargs)
  File "d:\jobs\myapptest\lib\site-packages\uvicorn\_subprocess.py", line 76, in subprocess_started
    target(sockets=sockets)
  File "d:\jobs\myapptest\lib\site-packages\uvicorn\server.py", line 60, in run
    return asyncio.run(self.serve(sockets=sockets))
  File "C:\Program Files\Python37\lib\asyncio\runners.py", line 43, in run
    return loop.run_until_complete(main)
  File "C:\Program Files\Python37\lib\asyncio\base_events.py", line 579, in run_until_complete
    return future.result()
  File "d:\jobs\myapptest\lib\site-packages\uvicorn\server.py", line 67, in serve
    config.load()
  File "d:\jobs\myapptest\lib\site-packages\uvicorn\config.py", line 477, in load
    self.loaded_app = import_from_string(self.app)
  File "d:\jobs\myapptest\lib\site-packages\uvicorn\importer.py", line 21, in import_from_string
    module = importlib.import_module(module_str)
  File "C:\Program Files\Python37\lib\importlib\__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "D:\Jobs\MyAppTest\MyAppTest\MyAppTest.py", line 48, in <module>
    app.add_page(index)
  File "d:\jobs\myapptest\lib\site-packages\pynecone\app.py", line 243, in add_page
    component = component if isinstance(component, Component) else component()
  File "D:\Jobs\MyAppTest\MyAppTest\MyAppTest.py", line 37, in index
    display='none',
  File "d:\jobs\myapptest\lib\site-packages\pynecone\components\datadisplay\datatable.py", line 68, in create
    or (isinstance(data, Var) and utils.is_dataframe(data.type_))
  File "d:\jobs\myapptest\lib\site-packages\pynecone\utils.py", line 1274, in is_dataframe
    return value.__name__ == "DataFrame"
AttributeError: '_SpecialForm' object has no attribute '__name__'

It seems when a dataframe is passed to create a datatable, and the problem occurred. I suppose this is caused by the version of pandas which pandas dataframe has no attribute 'name'. My pandas version is 1.3.4. But it works fine with pynecone v 0.1.18.

I just compared two versions when datatable is created.
In v 0.1.18, the condition is utils.is_dataframe(type(props.get("data")))
But in v 0.1.20, the condition is changed to utils.is_dataframe(type(data)) or (isinstance(data, Var) and utils.is_dataframe(data.type_))

After further study, I found this is caused by variables with single leading underscore. Private variables cannot be determined whether is a dataframe type.

variables with leading underscores are backend vars. However, this seems to be a bug with data tables not working properly when Dataframes are used as computed vars. I could raise an issue for this.  A workaround would be to use base state vars instead:
...

class State(pc.State):
    backend: pd.DataFrame = pd.DataFrame()

    ...

def index():
    return pc.box(
        pc.hstack(
            pc.button("Submit", on_click=State.submit_click),
            pc.data_table(
                data=State.backend,
                overflow_x="scroll",
                width="100%",
                pagination=True,
                search=True,
                sort=True,
                font_size="1em",
                resizable=True,
                display='none',
            ),
            spacing="1.5em",
            font_size="1em",
        ),
        width="100%",
        padding_top="5%",
    )
...

Yes, I have amended this problem. Thank you for your support.


vscode: 1.23.1 -> 1.24.0

Motivation for this change
https://code.visualstudio.com/updates/v1_24
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

I wonder why we list the license as unfree. Is vscode not opensource? Or are binaries different from a source build? https://en.wikipedia.org/wiki/Visual_Studio_Code

@Mic92 The binaries are under a different license:


Please make it clear that a special patched version of Torchvision is required

For DIGITS, please make it clear that a special patched version of Torchvision is required. It looks like it is the normal 0.3.0 version but it is not and it would be really helpful if you made it clear on this page:
https://github.com/dusty-nv/jetson-inference/blob/master/docs/building-repo.md

Hi @gituuu - thanks for your feedback, I will do that.  Note the forked version is automatically installed by the script during cmake configuration, and if you are on the latest JetPack 4.4 the forked torchvision is no longer required and the upstream version of torchvision is installed.

Great. I am waiting for 4.4 to be "stable" before I move to it. I think it is only "developer preview" at the moment.


Improve documentation of V2 kubernetes manifest artifact binding

https://www.spinnaker.io/guides/user/kubernetes-v2/deploy-manifest/#override-artifacts
There's some confusion around how artifacts are bound into Kubernetes manifests.  In particular, I've seen a few users include an image + tag in the manifest, which does not get replaced by the bound artifact and either causes the stage to fail or deploys the wrong image.  It would be good to explicitly call out in the documentation not to include a tag.

As someone who is trying to understand this with helm charts, does this mean that in my helm chart, I should not specify an image with a tag, and instead let spinnaker inject the image?
I have a docker image trigger to artifactory which i am using Spel to override the image tag currently in my chart. However, I do not know how to handle the case where I want to trigger by just changing my values.yaml and there is no new image. Currently I am using find artifacts from resource, and parsing out the tag from an existing deployment. Since I believe both of these methods produce artifacts, would i be able to just make the bake stage of my pipeline expect a docker image and it will automagically put the version in for me?

In my case, I was trying to deploy a manifest triggered by a docker which was built with tag regex setup on the trigger prod.*. I couldn't see anywhere in the docs the solution until I've found it here. It turns out I had to use a placeholder for the tag:
- image: "docker.io/armory/demoapp:${trigger['tag']}"


Docker optimizations and Go update

Update Docker build to use Go 1.10 and optimize for cache utilization.

Coverage remained the same at 34.631% when pulling 27ea6c2b33902445488dac9ec823200594fd8309 on TS_docker into 3184ae02d0902ccd9c5528c77009f07b87b28c23 on master.


Automatic ambient leds on core1

Reactive backlight for free by using core1!
I called it ambient LEDs, but we should settle on a consistent name.  I don't really like backlight because that normally means the display backlight.

I've cherry-picked these onto #8 and will rename the backlight feature

Awesome!  I realise that despite complaining here I have used the term backlight in a bunch of the code I wrote too...


Subpages Authorization

Currently one can only hide the entire Settings or hide on a per field basis.
Hiding every field in a subpage still renders the navigation link, the page, and the save button.
It would be an awesome feature if we could also authorise entire subpages.
So when a user is not allowed to see Subpage1 but Subpage2 the sidebar doesn't show Subpage1, we cannot update Subpage1 fields via API et cetera.

You can conditionally not add the settings fields in that case.
Ie
if (user()->isAdmin()) {
  NovaSettings::addSettingsFields([ ... ]);
}


Add Assumed Role ARN as a config option

Currently, the only implemented options for cross account AWS access are using an IAM User w access key and secret id. We want to avoid that for security reasons. We should be able to specify a role ARN in the connector config that the DynamoDb connector will use.
Proposed changes:
Create an optional field in the config that is a role ARN to pass to getCredentials. If that condition is met, return an STS assume role credentials provider instead of the default credentials provider.

Currently, the only implemented options for cross account AWS access are using an IAM User w access key and secret id. We want to avoid that for security reasons. We should be able to specify a role ARN in the connector config that the DynamoDb connector will use.
Proposed changes: Create an optional field in the config that is a role ARN to pass to getCredentials. If that condition is met, return an STS assume role credentials provider instead of the default credentials provider.

I am in a similar situation and would love to see this change added. We are currently using this source connector and the Confluent sink connector. The sink connector allows roles to be used, or the AWS credentials can be assumed using environment variables - https://docs.confluent.io/kafka-connect-aws-dynamodb/current/overview.html#using-trusted-account-credentials. This would be much more useful for us for security reasons and would really appreciate some movement on this PR. Cheers 👍

Any progress on the pull request? I am in a similar situation and would love to see this change added.

What is the current state of this PR, is there any plan to merge this?


StoryMenu broken with new event system

Describe the bug.
In develop, StoryMenu is broken.
I tracked it down to
251: jQuery(document).on(':uiupdate${EVENT_NS}', () => {

This installs an event handler for:

Not quite what was intended, as ${EVENT_NS} should be expanded to .ui-bar.
Replacing the ' with backticks fixes that, but exposes a second issue:

The new code adds an extra <ul>:

A possible fix is:
#menu ul ul {
  display: contents;
}

But naturally, getting rid of the extra <ul>s would be the cleaner approach.

Thanks.


Pylon: Fix rewrite of WebHDFS redirection

Coverage increased (+13.004%) to 64.844% when pulling 99bcd795cc1e13e89bb85fb9288de704eb983cbc on qixcheng/pylon/fix-webhdfs-307 into 85686d9effdb78c920b2294c0ba28d6d607afdf2 on pai-0.7.y.


Test Python 3.10

Need quotes around "3.10" otherwise YAML thinks it's 3.1: https://dev.to/hugovk/the-python-3-1-problem-85g

Aha, the Python 3.10 failure is because nose is long unmaintained and doesn't support 3.10:
https://github.com/nose-devs/nose/issues/1099 says 3.9, but they moved it to 3.10.
I suggest moving to nose2 or preferably pytest.

Aha, the Python 3.10 failure is because nose is long unmaintained and doesn't support 3.10:

Yeah. I have a set of changes being made to https://github.com/octodns/octodns-template atm to switch it over to pytest similar to https://github.com/octodns/octodns-azure/pull/3, though I've since learned that pytest has built in coverage requirements support so I'll be switching to that as well, e.g. https://github.com/octodns/octodns-constellix/pull/5/files#diff-b0ddc24027292e24c495fb6a8df798ce6f62bd9b2a89e23b97d56e041e29b5a1R43. Once the template bits have been updated I plan to go through and apply the changes to all the existing repos.
Anyway. If you want once the template changes are up to reference you can mimic them here. Otherwise I'll pick it up once I'm there.
Thanks.

Sounds like a plan! Feel free to add this whenever you like, and you can close this PR in the meantime if you like 👍

https://github.com/octodns/octodns-route53/pull/9 replaces this and pulls in other similar template updates/fixes. Thanks


Improve the test for mergeability

Gitea version (or commit ref): cd8cdbd
Can you reproduce the bug at https://try.gitea.io:
https://try.gitea.io/conflicttest/conflict/pulls/1

Description
In our workflow we have two branches with continuous deployment: master and qa (production and quality assurance).
Because both deploy on new pushes, they're both branch protected and require a PR with a review.
We always branch off new features from master and the first target after development is qa for acceptance testing.
We often seem to have conflicts when targeting a feature to qa, because the qa has more features that are currently in testing and are not released into master yet.
What we do then is manually resolve the issues so that git is able to merge it locally.
Merging qa into the feature is no option, because then the feature is dependent on other features that might not be ready for production.
Now to the Gitea part :-)
Have a look at this PR which emulates a conflict that is shown in Gitea but can be merged locally.
Gitea isn't able to merge it and just says it is conflicted.
However, you can do the following:
git clone https://try.gitea.io/conflicttest/noconflict
cd noconflict
git checkout qs
git merge --no-ff feature

Git is happy to merge it.
I've also tested what Github would show, here is the result: https://github.com/MarkusAmshove/Conflict/pull/1
The problem seems to be that Gitea "just" tries to apply the branch as a patch with, which can be reproduced locally:
[10:29] markus@suse-markus ~/scm/conflicttest (qs|✔) $ git format-patch feature --stdout | git apply --check --cached
error: Anwendung des Patches fehlgeschlagen: B:3
error: B: Patch konnte nicht angewendet werden

So, what could Gitea do better in that regard?
I think that instead of doing the patch approach, Gitea should try the different merge strategies it supports (which can be configured at the repositoy settings page) and see if the PR is actually mergeable.
We only have --no-ff enabled as a possibility and the exit code would be an indicator:
[10:39] markus@suse-markus ~/scm/conflicttest (qs|✔) $ git merge feature --no-ff --no-edit
Merge made by the 'recursive' strategy.
[10:39] markus@suse-markus ~/scm/conflicttest (qs↑ 3|✔) $ echo $status
0

In another repository where there are indeed conflicts:
[10:40] markus@suse-markus ~/scm/conflict (qa|✔) $ git merge feature2 --no-ff --no-edit
automatischer Merge von README.md
KONFLIKT (Inhalt): Merge-Konflikt in README.md
Automatischer Merge fehlgeschlagen; beheben Sie die Konflikte und committen Sie dann das Ergebnis.
[10:40] markus@suse-markus ~/scm/conflict (qa|MERGING|✖1⚡1) $ echo $status
1

Proposal
When testing for mergeability of a PR, try the different merge strategies configured in Gitea (for the repository) to see if the PR can be merged.
Bonus points if, when there are multiple strategies configured, Gitea "grays out" strategies that aren't possible.

Please note that this is a constructed example to show the limitations of the current check.
Having the same contents also results in Gitea showing 404 on the files tab:
https://try.gitea.io/conflicttest/conflict/pulls/1/files
While Github still shows the changes:
https://github.com/MarkusAmshove/Conflict/pull/1/files
I haven't investigated what Github could do different for the file diffs.

Did you mean to post https://try.gitea.io/conflicttest/noconflict/pulls/1? Your other links 404

You're right, I messed up the repository names  :-)
I'll update the issue


Clarify use of Ibex "simple-system"

Task Description
As reported in #263, this repository has an examples/simple_system directory.  Typically CORE-V core repositories do not include such examples as our members tend to have their own in-house, proprietary systems.  We need to make a conscious decision about what to do about all of the "examples" in the directory of the same name.
Description of Done
One of the following:

Delete cve2/examples altogether and remove any references to it in all READMEs and the User Manual.
Update the examples to work in the CVE2 context.

Associated PRs
No response

Flo, Davide, Duncan and Mario agreed to option 1. @MikeOpenHWGroup do you agree?

Yes, I do agree.  I'll take this one.  Expect a PR in the coming days...

As #272 is merged in, this task is Complete.


reference Fixes #1355

Check List:

Fixes #1355
Unit tests : YES
Javadoc with a code example (on API only) : NO, but could add later
PR meets the contributing guidelines

Following the contributing guidelines will make it easier for us to review and accept your PR.

Hi bro, I have tried my best to understand ur requirements and finished my codes following the example of CauseInstance. Please let me know if there is something I need to improve. thanks

@weiyilei can rebase your branch on main? thanks

@weiyilei can rebase your branch on main? thanks

sorry to bother u again but I am really unaware of the meaning of rebase(using merge before), as I fork the repository to my computer and just did it in the main branch of my repo

@weiyilei please get familiar with git rebase operations.
Although we are happy to support contributors, a preliminary understanding of common git operations is expected.


Installing TypeScript 1.3 for Visual Studio 2013 Community on Windows 8.1 failure

I'm trying to install TypeScript 1.3 (TypeScript_Dev12.exe) for Visual Studio 2013 Community Edition.  The installation doesn't display/throw any exceptions.  When I enter Visual Studio there is no evidence that it has been installed (no templates, no syntax highlighting etc).  I found an error in the event log that suggests the install failed but I don't know how to interpret the error messages.  I've uploaded the error log files to DropBox here: https://dl.dropboxusercontent.com/u/77349605/tsinstallerror.zip .  I'm running a pretty clean install of Windows 8.1 however I did previously have VS2013 Express for Windows/Windows Desktop/Web installed but uninstalled them when Community edition was released so I don't know if that could have caused some issues.

I've had the same issue for quite some time now: the last couple of versions of TypeScript that I've installed via Tools --> Extensions do not install. Everything will go fine during the install process, but when I re-open VS, the TypeScript extension isn't installed, and still shows in the "Online" category as something I can install. Currently, I'm having this issue with "TypeScript 1.4 for Visual Studio 2013" (https://visualstudiogallery.msdn.microsoft.com/2d42d8dc-e085-45eb-a30b-3f7d50d55304?SRC=VSIDE)
I'm using VS 2013 Professional, with a DreamSpark license. More specifically:
VS version 12.0.31101.00 Update 4
Windows 8.1 64-bit (version 6.3.9600 Build 9600)
.NET 4.5.51650 (perhaps irrelevant – I don't know if VS is a .NET app)
Intel Core i5-3337U
Intel VT is enabled in the UEFI – likely irrelevant, but bugs can be strange things, and it's one of the most distinctive system configs in place on my system, compared to baseline (changed the setting in the UEFI so I could run Virtual Box)

Could you try some of Paul's suggestions from earlier in the thread?

I tried the repair in Programs. That didn't work. I don't have a 1.1 folder.

Hi,
I have the same problem. Had Visual Studio for Web 2013 installed with TypeScript Support, uninstalled both, installed Visual Studio 2013 CE (Update 4) and have no TypeScript Support at all.
Strangely, when I run the TypeScript 1.4 Installer from the Visual Studio Gallery, the installations runs successfully, but the ProjectTemplates and ItemTemplates für TypeScript Files are still missing. The TypeScript VS Extension doesn't show up in the VS Extensions neither.

same here. vs2013 u4 premium from msdn bizspark and latest (1.4) typescript from visual studio gallery, pc formatted yesterday just windows and vs2013.
no error on installation but addin seems not installed: no new item and on extensions menu it appears as missing.

@Lukino2000 did you try the repair option on the TypeScript install in add/remove programs? Do you have a 1.4 folder in program files\Microsoft SDKS?

i tried several times... i also tried install version 1.3 and nothing change. Yes, i have the folder 1.4 folder in SDKs (for ver 1.4) and, when i tried 1.3 TS version, the folder 1.1. I noticed that in %PATH% the version 1.0 come first. When I tried changing the 1.0 folder name, TSC.exe works correctly but VS still doesn't work.

Exactly the same for me here. I have the folders and tsc.exe but no Item or Project Templates.

I tried again to get this working and it's still broken.  I installed, reinstalled, repaired 1.4 with no luck.  Then I uninstalled everything, Visual Studio included, deleted all VSCommon/VStudio folders in Program Files and Program Files (x86), deleted all VS related registry keys.  As far as I could tell there were no remnants of any version of VS left.  Then re-installed VS and then TypeScript 1.4 and it still says it's successful but appears to do absolutely nothing (and then tried repair for just to be sure and nothing).

Good luck @paulvanbrenk

I tried the method described by @csuzw and it worked! I am able to use TypeScript in VS2013 on my machine again.

Reinstall VS2013 Community Edition with the latest updates
Reinstall TypeScript 1.4
Extract the .msi file out of the installer with dark.exe (Wix binaries):
dark.exe -x myOutputFolder/ TypeScript_1.4_VS2013.exe
Extract the contents of the .msi from myOutputFolder\AttachedContainer\packages\TypeScript_VS\TypeScript_VS.msi with LessMSI
Copy the contents of SourceDir\Microsoft Visual Studio 12.0 into your local Visual Studio 12.0 folder
Repair TypeScript 1.4

Thank you @csuzw !
I couldn't find an error log created by the installer, I would like to know why the installation itself failed in the first place. The installer didn't copy the contents of TypeScript_VS at all.

We think this is fixed for TypeScript 1.5. If people continue to see issues there please do open a new issue and we can continue investigating there.

Hi, I had the same issue trying to install  TypeScript 1.4 but I had access to another computer that had typescript install, so I simply copied the TypeScript 1.4 folder to my computer C:\Program Files (x86)\Microsoft SDKs\TypeScript and then repaired the installation of typescript.

Hi,
Any one tell, how to run typescript with protractor in eclipse.
Thanks in advanced

@jagadeeshpa You should probably create a new issue, since what you're trying to do doesn't seem related to this issue.


Alt+[ / Alt+] don't do anything

Testing #207637
The a11y help says I can use Alt+[ / Alt+] to show the next/previous item, but these keybindings don't seem to do anything. It's also unclear to me whether these are for navigating items within a response or for navigating between requests/responses in the chat history

these are for navigating between chat responses, if any. there's an issue open already to disable these unless there are multiple chat responses.

Oh, I just realized this command requires the accessible view to already be open. If I have the accessible view open, then I can use alt+[ and alt+] to navigate between chat responses.


Ban appeal

Proposal:
Proposal written by Monkeyyy11
What is the title of your proposal?: Ban appeal
Is it a suggestion for the website or for the bot?: Website
Explain your proposal more accurately (It's best to give as much information as possible, so that we can implement the proposal better): You can create a ban appeal on the website if you‘re banned from lenoxbot or your discord server is banned from lenoxbot (just available if you‘re logged in with discord)
Why should we add this feature?: It‘s better than google forms what we currently use
ReportID: 126

➤ LenoxBot commented:
Approve:
good proposal
Denarioyt#3352

➤ LenoxBot commented:
Approve:
agree with Denario
🎃CrEePeR28 || Furkan🎃#3532

➤ LenoxBot commented:
Approve:
agree with Denario and Furkan
Profxy#5396


[Accessibility]  Repeated colours in legend + charts

Hey @adamivisonnhs, @craig-shenton,
Seems that some of the colours in the chart are repeating  - with two orgs having the same colour pallet, which could be problem from an accessibility perspective. Is this something that we can change?

@maryamanuelnhsx its definitely fixable...
The range of px.colors.qualitative plotly colour palettes can be found here:

Currently we are using the default (top row) which contains 10 colours - we have 17 Orgs at the moment so this is why there is a repetition. We can combine palettes from ^^ or create our own custom palettes by defining the individual CSS colours.
Not sure which would look best from an accessibility perspective?

Thank you @adamivisonnhs!
I just had a chat with @craig-shenton - As an interim fix, we will use Dark24. Once we find more accessible colours - we will import that as our own custom palettes by defining the individual CSS colours as you say.
I will update the colours this week and send over pull request.
Mary


RFE: Post results as comment back to GitHub Pullrequest

Hi,
The run task looks promising in understanding specific changes better.
I had a quick look at https://developer.hashicorp.com/terraform/cloud-docs/integrations/run-tasks#integration-details and saw that the payload for the run task would also include VCS information like commit and PR URLs.
If it's a speculative plan, it would be great to also send the results back as a comment to the originating PR.
What do you think?
Best regards,
Johannes

that is a good suggestion, thank you @jgrumboe
we have a few potential way to do it:

Since we know the workspace id, we could push comment on the Workspace run, or
As you suggested, bubble up the finding as pull request on the originating PR

Thinking of our dev teams, the PR is the "source of truth" 🙂

if you are using the tfc-workflow-tooling , we might able to bubble up the RunTasks plan output as part of it (which today is not yet available).
Ref: https://github.com/hashicorp/tfc-workflows-tooling/blob/main/docs/USAGE.md#available-commands
cc @gautambaghel

We're not using the tf-workflow-tooling; our workspaces are "normal" VCS connected.

Hey @jgrumboe I opened a new PR #13  to address this, would this satisfy your requirement? The additional piece would be that you need to supply the GitHub token.
It needs to be a Fine-grained personal access tokens
with access to

Read access to metadata
Read and Write access to pull requests

@gautambaghel
Thanks, and sorry for coming back here so late.
I will give it a try in the next weeks.


Insert the Pro Variant from Mennekes

For I could not login and I do not find the needed PIN in the Pro Wallbox from Mennekes I have opened a request in the iobroker forum. Could you please add the funktion for the professional box as well?
Thanks in advance

@goudi76  could you check already which version you need?


meta: move goreleaser-cross back to v1.21.5

Turns out, these are different releases for goreleaser-cross vs goreleaser, and v1.21.5 is the latest for -cross variant.

Ok, so in summary, the last build that worked was with 1.21.5. I think there are a few things that are worth investigating:

there is no goreleaser-cross tag for 1.21.6. From what I'm deriving, this version is the same as the go version. So it might be an oversight in their repo to not have a tag exist for 1.21.6 while it's published to docker registries.
The 1.21.6 tag also brings goreleaser 1.30.0, whereas 1.21.5 tag brings 1.22.1. I suspect more the issue is with the goreleaser bump. afaik there's not a goreleaser-cross:v1.21.6-v1.22.1 that keeps the older goreleaser to test with.

Given that the last successful publish was on the v1.21.5 tag, I'm inclined to try this.


auto-cpufreq: 1.9.9 > 2.1.0

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

@Technical27 if you want to help on this PR ?

Note, there is a PR from 1.9.9 -> 2.0.0 (#258684)

are there any plans to actually merge this?

No hash update. This is probably useless.


fix: community link

Changing Slack -> Discord.

Thanks @s-scheele-simonsen 🙌 There's two failed checks so It doesn't seem like I can merge this?

All good, now! Thanks @danserif! 🥳


Policy for regulating native asset transfers

I am not sure this has been discussed before, but please consider either adding a new transfer policy script or generalising the forging policy to allow regulating transfer of native assets as well.
There are many use cases where the issuer might want to restrict the transfer of an asset based on some specific conditions (e.g. you may only start transferring the asset from a certain epoch, the asset must be transferred in conjunction with another asset, the asset must be transferred in exchange for another asset, etc.).

Such restrictions will be possible when we introduce Plutus scripts at the next planned hard fork.

Ok so the Plutus script will not just run for forging/burning transactions?

indeed, Plutus scripts will be usable in transaction outputs, delegation certificates, reward withdrawals, and minting policies. moreover, they have access to some of the context surrounding the transaction, and can use thing to restrict how the token is used.


Add restart note

Adds a note about having Firezone come back up after system restart.

Pull Request Test Coverage Report for Build 07e021e927c5c93a2373be3f56e9bcc7d803c784-PR-1085

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.977%

Totals

Change from base Build 85359bdb11a180b43a1eec3f7487787ed40239d6:
0.0%

Covered Lines:
1148

Relevant Lines:
1740

💛  - Coveralls


Last one, yay! Wes McDorman

You deleted the first line that contains the bash script identifier and failed to write your own name in it.


Add an event to detect the screen changes

Is your feature request related to a problem? Please describe.
Supposed that we are developing such an app:

It has a floating icon on the desktop/screen
The icon will reposition and rescale itself when the screen resolution or scaling is changed

Avalonia 11.1.0 now only provide an event of Window.ScalingChanged that will be raised when the screen scaling is changed. But if the screen resolution is changed, it provide nothing. So our desktop icon doesn't know when to reposition it.
For example, the desktop icon is position at the top-right corner of the screen displaying in 3840x2160 and now the user changes the resolution to 1920x1080, the icon will be out of the screen. (Note: If the window is an override redirect window, the desktop window manager will not reposition it.)
Describe the solution you'd like

Add an event Changed to Avalonia.Controls.Screens class
The event should be raised when the screen resolution, scaling, orientation, layout, count, etc. are changed

Describe alternatives you've considered

Add a native callback into the X11Properties class, which is the same as what in the Win32Properties class.

Additional context

Thank you. This feature is exactly what I need and look forward to adding it.

Before we get the framework support, we can use this work-around:
using var display = XDisplay.Open(0);
var window = XDefaultRootWindow(display);

XSelectInput(display, window, (nint)(ExposureMask | StructureNotifyMask));

while (_isRunning)
{
    XNextEvent(display, out var e);

    if (e.type is XEventName.ConfigureNotify)
    {
        var configureEvent = e.ConfigureEvent;
        var bounds = new PixelRect(configureEvent.x, configureEvent.y, configureEvent.width, configureEvent.height);
        if (bounds != _lastScreenBounds)
        {
            _lastScreenBounds = bounds;
            RaiseScreenChanged(bounds);
        }
    }
}

We'are trying to know the changes of the root window and we assume that the position and the size of it equals to the screen position and size.
Just run this code above on a long-running task and we'll get the screen resolution changed event.

Completed in 11.2 nightly. Mobile support is coming later. Linux support needs some help from community.

Opened this issue to track remaining platforms including Linux https://github.com/AvaloniaUI/Avalonia/issues/16572


Track spring ephemerals

Add a field indicating whether a plant is a spring ephemeral, i.e., it blooms in the spring and then dies off by summer.

Field added to schema but it will take some time to fill in plant info

Field added to schema but it will take some time to fill in plant info


(RTSLORD) - T-LoRD Issues

Selecting Converse with patrons from the Inn locks up but does not crash MBBSEmu. After this occurs MBBSEmu still accepts connections but does not negotiate IAC or do anything other than log "HostProcess.MbbsHost.AddSession Session x.x.x.x:yyyyy added to incoming queue" until it is restarted.

There is no way to exit live chat (Jabber with the locals) or view the help menu. Chat doesn't work and randomly a new chat message clears the screen:

Write mail command cannot find any user specified.

List warriors has odd characters in the Mastered column:

Random characters such as shown in the list warriors screen shot are output during play sometimes they are accompanied by a screen clear.

Fighting, healing, buying/selling, bank deposit/withdraw, buying a room, flirting with violet/hearing seth all work. Longer play will be required but it seems close to being 100%.

Additionally, (O)ther places from main menu doesn't respond to any keypresses other than to return, in spite of the fact that I have an IGM installed and listed there. Whether or not I installed the IGM correctly is another story. :)

I believe these should now be fixed in an upcoming pull request.

Caused by strcpy() not copying \0 to destination when the source was null. This caused an infinite loop in the routine that generated the initial BAR.TXT when it needed to be created on first run.
This now also appears fixed

Please verify 3,4,5 are fixed as well on boards with more characters.


Add Instancing documentation

reminder to self or anyone who has time:
minimal: copy info from here: https://github.com/stride3d/stride/pull/741#issuecomment-642190435
ideally: add more context and explantations

@tebjan I will add this to the intermediate tutorials, once I have the base set recorded and available. I will get back to you on this.


Dcpfixity - create sha1 manifest

Figure out how to get regular sha1s out of the base64/binary hashes and store as traditional sha1sum manifest.

Good idea - you should do this.


Fix index out of range for operand

closes #146
Signed-off-by: acmenezes<EMAIL_ADDRESS>

/lgtm


llvmpackages: patch shebangs for python subpackages

Description of changes
Notably, "git-clang-format" fails with:
/usr/bin/env: ‘python’: No such file or directory

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

This is better in staging, right?

I have changed the base.


Blocking Teams app in browser block access to all App policies pages in Teams admin portal

Hi! Please add notification that people who manage apps, app permissions policies and app setup policies need to be able to have access Teams in browser. Having a defined conditional policy in AAD that blocks Teams in browser will block also access to these 3 pages. Since there is no supported PS cmdlet to manage app permissions policies then such policy will disable ability to manage the policies.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b51eda6c-168c-7d99-7cc1-992b3d8feef2
Version Independent ID: 118a1b8f-f4b7-a778-70b1-d3161fc548ab
Content: Manage app permission policies in Microsoft Teams - Microsoft Teams
Content Source: Teams/teams-app-permission-policies.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

@Larryngolog thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

Hello. This is an efect of opened service ticket - we noticed the issue, opened the ticket and got information from support that the issue was result of blocking access to Teams from browser with conditional access. And the outcome is what I mentioned in my original post - please call out in the docs that admins who want to manage these settings need to have browser access to Teams enabled in conditional access.


Accept a list of status instead of single value in requests

For example for posts
status:
Limit result set to posts assigned one or more statuses.
Default: publish

I can use more than 1 using this:
        queryParameters: <String, dynamic>{
          'status': 'publish,draft,future,pending,private',
        },

Thanks

@MiniSuperDev i think this is a bug. i will work on this the earliest and let you know!

@MiniSuperDev This has been fixed. please check!
wordpress_client: ^8.4.5

Thanks
It works perfect


Feature/change color of image annotate

LGTM.
Overview:
add company styling;
add self-hosted workspace package;
change v5 icons to v4 to avoid build errors.


Mention docker images in docs

Fixes #675.

Codecov Report

Merging #686 (d2d02ce) into main (58bde5e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   93.55%   93.55%
=======================================
  Files          85       85
  Lines        8021     8021
=======================================
  Hits         7504     7504
  Misses        396      396
  Partials      121      121


Update documentation for latest versions

I'm the main maintainer on the OpenXML SDK and would like to get the docs updated to reflect the current state of things. This issue will be a (potentially growing) list of the items that we would like to update:

[x] The documentation refers to specific versions - this is unnecessary as the version is not static nor is the content dependent on it (https://github.com/OfficeDev/open-xml-docs/pull/158)
[ ] APIs have not been updated since 2.8.1 - should add APIs for at least v2.2.0 and v3.0.0 (it'll be released next month) (#156)
[ ] New samples are available at https://github.com/dotnet/Open-XML-SDK/tree/main/samples and should be migrated here

[ ] AnimatedModel3DExample
[ ] DocumentTaskExample
[ ] IsolatedStorageExceptionWorkaround
[ ] Linq
[ ] NamedSheetView
[ ] PowerPointModernCommentSample
[ ] RichData
[ ] SunburstChartExample
[ ] SVGExample
[ ] ThreadedCommentExample

[ ] Samples use VB and CS but are all inline and should be moved to actual test projects, be runnable, and shown in docfx tabs

[x] how-to-accept-all-revisions-in-a-word-processing-document.md #163
[x] how-to-add-a-comment-to-a-slide-in-a-presentation.md #163
[ ] how-to-add-a-new-document-part-that-receives-a-relationship-id-to-a-package.md
[ ] how-to-add-a-new-document-part-to-a-package.md
[ ] how-to-apply-a-theme-to-a-presentation.md
[ ] how-to-calculate-the-sum-of-a-range-of-cells-in-a-spreadsheet-document.md
[ ] how-to-change-text-in-a-table-in-a-word-processing-document.md
[ ] how-to-change-the-fill-color-of-a-shape-in-a-presentation.md
[ ] how-to-copy-the-contents-of-an-open-xml-package-part-to-a-document-part-in-a-dif.md
[ ] how-to-create-a-package.md
[ ] how-to-delete-all-the-comments-by-an-author-from-all-the-slides-in-a-presentatio.md
[ ] how-to-delete-text-from-a-cell-in-a-spreadsheet.md
[ ] how-to-get-a-column-heading-in-a-spreadsheet.md
[ ] how-to-get-all-the-external-hyperlinks-in-a-presentation.md
[ ] how-to-get-all-the-text-in-a-slide-in-a-presentation.md
[ ] how-to-get-all-the-text-in-all-slides-in-a-presentation.md
[ ] how-to-get-the-contents-of-a-document-part-from-a-package.md
[ ] how-to-get-the-titles-of-all-the-slides-in-a-presentation.md
[ ] how-to-get-worksheet-information-from-a-package.md
[ ] how-to-insert-a-chart-into-a-spreadsheet.md
[ ] how-to-insert-a-comment-into-a-word-processing-document.md
[ ] how-to-insert-a-new-slide-into-a-presentation.md
[ ] how-to-insert-a-new-worksheet-into-a-spreadsheet.md
[ ] how-to-insert-a-picture-into-a-word-processing-document.md
[ ] how-to-insert-a-table-into-a-word-processing-document.md
[ ] how-to-insert-text-into-a-cell-in-a-spreadsheet.md
[ ] how-to-merge-two-adjacent-cells-in-a-spreadsheet.md
[ ] how-to-move-a-paragraph-from-one-presentation-to-another.md
[ ] how-to-move-a-slide-to-a-new-position-in-a-presentation.md
[ ] how-to-open-a-presentation-document-for-read-only-access.md
[ ] how-to-open-a-word-processing-document-from-a-stream.md
[ ] how-to-remove-a-document-part-from-a-package.md
[ ] how-to-replace-the-theme-part-in-a-word-processing-document.md
[ ] how-to-retrieve-comments-from-a-word-processing-document.md
[ ] how-to-search-and-replace-text-in-a-document-part.md
[ ] how-to-set-the-font-for-a-text-run.md
[ ] how-to-validate-a-word-processing-document.md

[ ] Updated/new topics:

[ ] IFeatureCollection usage
[ ] LINQ support
[ ] Migration to v3

[ ] Update getting started related steps (no longer need to "install" SDK - update to account for NuGet packages and dotnet CLI)
[ ] Reorganize doc file structure so that they match the toc

@davidchesnut Previously you enabled 2.8.1 packages to have their APIs show up in the docs. How can we get later versions added? we tend to release every quarter or so, and would like to get a process to get updates pushed out in the docs

[ ] references to ISO/IEC 29500:2008 should be updated to 2016
[ ] there are references and procedures for Visual Studio 2008
[ ] remove references to the SDK 1.0
[ ] completely revamp the What's New in the Open XML SDK topic

@AlfredHellstern feel free to modify the original issue to have one list of things to track. Appreciate your keen eye here for wording :)

@twsouthwick done

@mikeebowen can you update the check list here for the work you have done?

@twsouthwick I don't have permission

can you update your comment then with any updates and I'll update the main list?


api/v1/repos/stephenc/repo/tags endpoint not returning lightweight tags correctly

Gitea version (or commit ref): 1.9.0+dev-358-ga200ca155
Git version: N/A
Operating system: Docker
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes (provide example URL) https://try.gitea.io/api/v1/repos/stephenc/repo/tags
[ ] No
[ ] Not relevant

Log gist:

Description
The api/v1/repos/stephenc/repo/tags endpoint is not returning the lightweight tags correctly. See https://github.com/go-gitea/gitea/commit/8de0b0a3f06fe7879fb014d2624209e0e48455a0#commitcomment-33968832
I have pushed the git repo and tags to try.gitea.io.
Here is the lightweight tag which resolves to a commit directly:
$ git show lightweight
commit 05958747e4a781e67f1ebd3248ddfba9d1846b40 (HEAD -> master, tag: lightweight, tag: annotated, origin/master, origin/HEAD)
Author: Stephen Connolly<EMAIL_ADDRESS>Date:   Thu Aug 31 19:24:47 2017 +0000

    Add 'Jenkinsfile'

diff --git a/Jenkinsfile b/Jenkinsfile
new file mode 100644
index 0000000..5495493
--- /dev/null
+++ b/Jenkinsfile
@@ -0,0 +1 @@
+// something
\ No newline at end of file

Here is the annotated tag which resolves to a tag object
$ git show annotated
tag annotated
Tagger: Stephen Connolly<EMAIL_ADDRESS>Date:   Mon Jun 17 19:49:42 2019 +0100

annotated
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQEzBAABCgAdFiEEGap4SSwuDnWSnyiCgms2VIViMTgFAl0H4MYACgkQgms2VIVi
MTjYcAf/QdZ4QChhRjcnT5V5PgXD6gWBwvCnqgPcJm7QxK+IYRoBMili1oMUWGiL
J1Y5hvRopQLvScyyU544paYtM12/UYe5ovm9jUZlih+ijujmZ844xhC9WqCR6sDn
WcMm7EiRxEzyaUWwGC0zMoewW5yOk3dPBSKGXjWr3aZAkkyYW07ucItufR1Ufz3p
KYgmqaE9PqW1kn+FDb2o1/s1ZWOUqAP2t2oa76OYeTNm5fFHaRo3dcTXmgyzMIl1
DRpIxERB5QjKbvWoqj1lqEeawpv9gMfhxeKVTQYZqjM/08riKLiBLQuI37qvEWG/
r+H/0uWTdUUO0R3oL/hnpkRx++VY7g==
=ZZ+8
-----END PGP SIGNATURE-----

commit 05958747e4a781e67f1ebd3248ddfba9d1846b40 (HEAD -> master, tag: lightweight, tag: annotated, origin/master, origin/HEAD)
Author: Stephen Connolly<EMAIL_ADDRESS>Date:   Thu Aug 31 19:24:47 2017 +0000

    Add 'Jenkinsfile'

diff --git a/Jenkinsfile b/Jenkinsfile
new file mode 100644
index 0000000..5495493
--- /dev/null
+++ b/Jenkinsfile
@@ -0,0 +1 @@
+// something
\ No newline at end of file

Here is the current result at https://try.gitea.io/api/v1/repos/stephenc/repo/tags:
[{
    "name": "annotated",
    "id": "9a4ac36d615d3e4a56635e31bb60b75bdebd5d6d",
    "commit": {
        "url": "https://try.gitea.io/api/v1/repos/stephenc/repo/git/commits/9a4ac36d615d3e4a56635e31bb60b75bdebd5d6d",
        "sha": "9a4ac36d615d3e4a56635e31bb60b75bdebd5d6d"
    },
    "zipball_url": "https://try.gitea.io/stephenc/repo/archive/annotated.zip",
    "tarball_url": "https://try.gitea.io/stephenc/repo/archive/annotated.tar.gz"
}, {
    "name": "lightweight",
    "id": "9a4ac36d615d3e4a56635e31bb60b75bdebd5d6d",
    "commit": {
        "url": "https://try.gitea.io/api/v1/repos/stephenc/repo/git/commits/9a4ac36d615d3e4a56635e31bb60b75bdebd5d6d",
        "sha": "9a4ac36d615d3e4a56635e31bb60b75bdebd5d6d"
    },
    "zipball_url": "https://try.gitea.io/stephenc/repo/archive/lightweight.zip",
    "tarball_url": "https://try.gitea.io/stephenc/repo/archive/lightweight.tar.gz"
}]

Expected result:
[{
    "name": "annotated",
    "id": "9a4ac36d615d3e4a56635e31bb60b75bdebd5d6d",
    "commit": {
        "url": "https://try.gitea.io/api/v1/repos/stephenc/repo/git/commits/9a4ac36d615d3e4a56635e31bb60b75bdebd5d6d",
        "sha": "9a4ac36d615d3e4a56635e31bb60b75bdebd5d6d"
    },
    "zipball_url": "https://try.gitea.io/stephenc/repo/archive/annotated.zip",
    "tarball_url": "https://try.gitea.io/stephenc/repo/archive/annotated.tar.gz"
}, {
    "name": "lightweight",
    "id": "05958747e4a781e67f1ebd3248ddfba9d1846b40",
    "commit": {
        "url": "https://try.gitea.io/api/v1/repos/stephenc/repo/git/commits/05958747e4a781e67f1ebd3248ddfba9d1846b40",
        "sha": "05958747e4a781e67f1ebd3248ddfba9d1846b40"
    },
    "zipball_url": "https://try.gitea.io/stephenc/repo/archive/lightweight.zip",
    "tarball_url": "https://try.gitea.io/stephenc/repo/archive/lightweight.tar.gz"
}]

Screenshots

@richmahn could you have time to take a look at this issue?

@lunny Just saw the notification for it. Yes, will look.

@stephenc Looking into this. Shouldn't the SHA of the commit of the annotated tag be "05958747e4a781e67f1ebd3248ddfba9d1846b40" like both SHAs of the lightweight? That is, the commit SHA should be different than the tag SHA. I thought I had that working, but appears not. Thanks for finding that.

Yes the sha should be the same, The id perhaps not

@stephenc Ok, made a PR. You can see my JSON output in the PR description: https://github.com/go-gitea/gitea/pull/7321


Register notification

Hi,
What should happen if I register a notification? In my opinion, it should only trigger the callback method if the device triggers the notification. But in current flutter_blue I get a callback if I still register my notification.
With following code:
Future<StreamSubscription> _registerNotify(String serviceUUID, String characteristicUUID, void onData(List<int> data), {bool read = false, String debugText}) async {
    StreamSubscription retVal;
    if(debugText == null || debugText.isEmpty) debugText = "($serviceUUID | $characteristicUUID)";

     for (var service in _currentServices) {
      if (service.uuid != Guid(serviceUUID)) {
        continue;
      }
      for (var c in service.characteristics) {
        if (c.uuid == Guid(characteristicUUID)) {
          debugPrint(_debugPrefix + "$debugText found");

          if(read) {
             await c.read();
             debugPrint(_debugPrefix + "$debugText read");
          }

          debugPrint(_debugPrefix + "$debugText register notify");
          await c.setNotifyValue(true);
          retVal = c.value.listen(onData);

          if(read) {
             onData(val);
          }
        }
      }
    }

    return retVal;
  }

I thought if I call this method with read=false I will only get the onData if my device sends a notification. And if I use read=true I trigger my onData with the current value (not with the notification).
But onData is called every time. With read=false I get null (or last read) value and with read=true its called twice.
I hope someone can help me to understand my fault.

If I change
bluetooth_characteristic.dart

  BehaviorSubject<List<int>> _value;
  Stream<List<int>> get value => Observable.merge([
        _value.stream,
        _onValueChangedStream,
      ]);

to
  BehaviorSubject<List<int>> _value;
  Stream<List<int>> get value => Observable.merge([
        _onValueChangedStream,
      ]);

I get my expected behavior.
The question is how can I avoid triggering the callback with the current value. I only need it if something changes (I don't want to filter this in my application with flags).

I suppose that this issue is connected with this one: https://github.com/pauldemarco/flutter_blue/issues/311
I made a pull request to fix that but sadly, it seems that the creator of this repo does not merge any updates.


Error while creating new user

Hey there,
While creating a new user with flask I am facing this error   -
(venv) C:\Users\admin\Desktop\mini-key-server-master>flask create-user username password
Traceback (most recent call last):
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\engine\base.py", line 2262, in _wrap_pool_connect
return fn()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 363, in connect
return _ConnectionFairy._checkout(self)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 760, in _checkout
fairy = _ConnectionRecord.checkout(pool)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 492, in checkout
rec = pool._do_get()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\impl.py", line 139, in _do_get
self._dec_overflow()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\util\langhelpers.py", line 68, in exit
compat.reraise(exc_type, exc_value, exc_tb)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\util\compat.py", line 154, in reraise
raise value
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\impl.py", line 136, in _do_get
return self._create_connection()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 308, in _create_connection
return _ConnectionRecord(self)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 437, in init
self.__connect(first_connect_check=True)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 639, in __connect
connection = pool.invoke_creator(self)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\engine\strategies.py", line 114, in connect
return dialect.connect(*cargs, **cparams)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\engine\default.py", line 451, in connect
return self.dbapi.connect(*cargs, **cparams)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\psycopg2_init.py", line 126, in connect
conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
psycopg2.OperationalError: fe_sendauth: no password supplied
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "C:\Users\admin\Anaconda3\Lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "C:\Users\admin\Anaconda3\Lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\Users\admin\Desktop\mini-key-server-master\venv\Scripts\flask.exe_main.py", line 7, in
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\flask\cli.py", line 966, in main
cli.main(prog_name="python -m flask" if as_module else None)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\flask\cli.py", line 586, in main
return super(FlaskGroup, self).main(*args, **kwargs)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\click\core.py", line 717, in main
rv = self.invoke(ctx)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\click\core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\click\core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\click\core.py", line 555, in invoke
return callback(*args, **kwargs)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\click\decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\flask\cli.py", line 426, in decorator
return _ctx.invoke(f, *args, **kwargs)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\click\core.py", line 555, in invoke
return callback(*args, **kwargs)
File "C:\Users\admin\Desktop\mini-key-server-master\keyserv_init.py", line 71, in create_user_command
add_user(username, password.encode())
File "C:\Users\admin\Desktop\mini-key-server-master\keyserv\auth.py", line 37, in add_user
db.session.commit()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\scoping.py", line 162, in do
return getattr(self.registry(), name)(*args, **kwargs)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\session.py", line 1027, in commit
self.transaction.commit()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\session.py", line 494, in commit
self._prepare_impl()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\session.py", line 473, in _prepare_impl
self.session.flush()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\session.py", line 2459, in flush
self._flush(objects)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\session.py", line 2597, in _flush
transaction.rollback(_capture_exception=True)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\util\langhelpers.py", line 68, in exit
compat.reraise(exc_type, exc_value, exc_tb)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\util\compat.py", line 154, in reraise
raise value
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\session.py", line 2557, in _flush
flush_context.execute()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\unitofwork.py", line 422, in execute
rec.execute(self)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\unitofwork.py", line 589, in execute
uow,
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\persistence.py", line 213, in save_obj
) in _organize_states_for_save(base_mapper, states, uowtransaction):
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\persistence.py", line 374, in _organize_states_for_save
base_mapper, uowtransaction, states
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\persistence.py", line 1605, in _connections_for_states
connection = uowtransaction.transaction.connection(base_mapper)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\session.py", line 313, in connection
return self._connection_for_bind(bind, execution_options)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\session.py", line 419, in _connection_for_bind
conn = self._parent._connection_for_bind(bind, execution_options)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\orm\session.py", line 431, in _connection_for_bind
conn = bind._contextual_connect()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\engine\base.py", line 2226, in _contextual_connect
self._wrap_pool_connect(self.pool.connect, None),
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\engine\base.py", line 2266, in _wrap_pool_connect
e, dialect, self
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\engine\base.py", line 1536, in _handle_dbapi_exception_noconnection
util.raise_from_cause(sqlalchemy_exception, exc_info)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\util\compat.py", line 399, in raise_from_cause
reraise(type(exception), exception, tb=exc_tb, cause=cause)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\util\compat.py", line 153, in reraise
raise value.with_traceback(tb)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\engine\base.py", line 2262, in _wrap_pool_connect
return fn()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 363, in connect
return _ConnectionFairy._checkout(self)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 760, in _checkout
fairy = _ConnectionRecord.checkout(pool)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 492, in checkout
rec = pool._do_get()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\impl.py", line 139, in _do_get
self._dec_overflow()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\util\langhelpers.py", line 68, in exit
compat.reraise(exc_type, exc_value, exc_tb)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\util\compat.py", line 154, in reraise
raise value
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\impl.py", line 136, in _do_get
return self._create_connection()
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 308, in _create_connection
return _ConnectionRecord(self)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 437, in init
self.__connect(first_connect_check=True)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\pool\base.py", line 639, in __connect
connection = pool.invoke_creator(self)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\engine\strategies.py", line 114, in connect
return dialect.connect(*cargs, **cparams)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\sqlalchemy\engine\default.py", line 451, in connect
return self.dbapi.connect(*cargs, **cparams)
File "c:\users\admin\desktop\mini-key-server-master\venv\lib\site-packages\psycopg2_init.py", line 126, in connect
conn = _connect(dsn, connection_factory=connection_factory, **kwasync)
sqlalchemy.exc.OperationalError: (psycopg2.OperationalError) fe_sendauth: no password supplied
(Background on this error at: http://sqlalche.me/e/e3q8)
How do I fix this?

How i fixed was,
Either give proper endpoint in config.py with database endpoint or create a user keyserver

Are you still having an issue with this?

No, it's resolved. Thank You.

Hello, I'm having the same issue and creating a user "keyserver" and trying several URIs doesn't solve it, could you help me?
To create a user I've tried "flask create-user username password" and "flask create-user keyserver password"
In the config.py I've tried SQLALCHEMY_DATABASE_URI = "postgres://localhost/keyserver", SQLALCHEMY_DATABASE_URI = "postgres://keyserver@localhost", SQLALCHEMY_DATABASE_URI = "postgres://username:password@localhost"


Bug: migration status for duckdb file is stored in postgres

First: great extension! I love having self-contained features, that can be dropped into a phoenix app with little configuration. Also, the way you integrated DuckDB is very good and it really wont cause any performance issues for small/medium apps.
Also, it goes into direction Feature -> own DB, which I think is an intriguing architecture pattern.
Now some concerns from my side:
I have tried to reset the analytics data by just deleting the DB, hoping it would be recreated automatically.
This was not the case, I had to re-run the migration (after deleting the according schema_migrations row) again.
Maybe it makes sense to let the migration information be kept in the DuckDB file, and run it automatically? That way the setup becomes simpler (not need to copy migrations to your phx app) and it becomes more robust overall.
Thoughts?
Best,
Roman

Hi @mindreframer ,
Thank you so much for kind words and considering to use my library.
When I was doing a lot of testing I had to do a lot what you described in this issue.
That's why I mentioned in README this:

[!TIP]
iex -S mix phx.server PhoenixAnalytics.Migration.up()

For current CREATE TABLE IF NOT EXISTS migration, you suggestion would work perfectly, I could just inject it to Repo.start_link and done.
But what if in the future we decide to extend/change duckdb schema and we would need to provide upgrade migration.
One way would be to create migrator functionality inside DuckDB, but I'm not sure yet if that's way to go.
The main reason I decided to store migrations in Postgres/Sqlite/Mysql/etc to keep DuckDB schema state and application state in one place.
I'm happy to compare pros/cons and based on it proceed with solution.


Fix some use-after-frees and memory leak in the wmf decoder

This says "some" cause the video part is intentionally using a use-after-free to expose the frame.
In any case, the primary reason for this PR is to fix the jumping leak from https://github.com/pyglet/pyglet/issues/926 stemming from the _source_reader not being released, now that the other one turned out to be a Python bug.

This causes audio to skip and crackle on my machine.

But even before, the audio data was copied via memmove, there's no reasonable way the playback mechanism could still have any kind of access to the IMFBuffer/Samples. Maybe i'm releasing the imf_sample too early, the MS docs don't mention anything explicitly, but maybe it deletes its buffers even if they still have references.

I updated to the latest with sample being freed last, and it seems to have fixed the crackling for me. (Windows 11, Xaudio2, ogg/mp3 testing)

Also, the video portion of WMF can probably just be removed in the future as it shouldn't be used anymore.

Shall we merge this for now, and then strip out the video parts in the development branch?

I don't really know what the status with the wmf decoder's video section is. I could not get it to play any video in the first place. The _debug at https://github.com/pyglet/pyglet/blob/45fc7d1b6cc0ff61a5090e52eed6659bb9233dcf/pyglet/media/codecs/wmf.py#L576 is triggered, but then this bit: https://github.com/pyglet/pyglet/blob/45fc7d1b6cc0ff61a5090e52eed6659bb9233dcf/pyglet/media/codecs/wmf.py#L590-L593 always fails and reports [WinError -1072875852] The data specified for the media type is invalid, inconsistent, or not supported by this object for a variety of videos in different formats i've thrown at it.
I was focusing this PR on fixing issues in the audio section only; i feel any changes regarding the video part are kinda out of scope for this PR

I'm still hesitant about tearing out the WMF video decoding. If we can get MP4 to work and establish a baseline for the video stream across Mac & Windows, we'd have a 0-pyglet video equivalent to MP3. That could be a significant decrease in download size.

always fails and reports [WinError -1072875852] The data specified for the media type is invalid, inconsistent, or not supported by this object for a variety of videos in different formats i've thrown at it.
I was focusing this PR on fixing issues in the audio section only; i feel any changes regarding the video part are kinda out of scope for this PR

The formats are somewhat limited I believe. Video stuff can be removed at a later date.

I'm still hesitant about tearing out the WMF video decoding. If we can get MP4 to work and establish a baseline for the video stream across Mac & Windows, we'd have a 0-pyglet video equivalent to MP3. That could be a significant decrease in download size.

Unfortunately with WMF it's not hardware accelerated without DirectX and I am not quite up to the task of creating a DirectX-OpenGL link just to make video work for whatever formats it supports when FFmpeg does it all better.
We can leave the video stuff for another PR later down the road.


Improve the usability of the editor

The current Matterwiki editor (in the refactor branch) uses draft-js as its core editor. While this is good, there are wiggles, focus issues and other small issues that all add up to making the experience of using it sub-par. We could switch to a new editor or make the editor we have better. Any thoughts and suggestions would be helpful!

I've been working with tinyMCE on another project - fairly usable but not
the most ideal!
On Sat, Aug 5, 2017 at 10:05 AM Krishna Gopinath<EMAIL_ADDRESS>wrote:

The current Matterwiki editor (in the refactor branch) uses draft-js as
its core editor. While this is good, there are wiggles, focus issues and
other small issues that all add up to making the experience of using it
sub-par. We could switch to a new editor or make the editor we have better.
Any thoughts and suggestions would be helpful!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Matterwiki/Matterwiki/issues/117, or mute the thread
https://github.com/notifications/unsubscribe-auth/ARj5GQoNFs1SahqrG3W8sYdqLQtGxca2ks5sU7_QgaJpZM4OuUew
.

I have seen tinyMCE too.

It's not React compatible in the way I'd like it to be (there was just a thin wrapper around the editor, iirc)
It feels like a closed source product (even though it IS open source) and all that.

I personally like draft-js, but if we cant get the UX we need out of it, we could consider http://slatejs.org/, which is similar to draft

Agreed on those fronts - slatejs looks like a solid alternative option.
On Sat, Aug 5, 2017 at 1:29 PM Krishna Gopinath<EMAIL_ADDRESS>wrote:

I have seen tinyMCE too.

It's not React compatible in the way I'd like it to be (there was
just a thin wrapper around the editor, iirc)
It feels like a closed source product (even though it IS open
source) and all that.

I personally like draft-js, but if we cant get the UX we need out of it,
we could consider http://slatejs.org/, which is similar to draft
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Matterwiki/Matterwiki/issues/117#issuecomment-320397687,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARj5GTBcYODf28PBvicbv1DxeIKphBqHks5sU-_AgaJpZM4OuUew
.

How about we check out Mobiledoc too? Not that elaborate as Slate. Slate still gets my vote. But a great piece of software http://bustle.github.io/mobiledoc-kit/demo/
Also, the guys at Ghost moved to a mobiledoc based editor in Ghost 1.0, but then again, their use case is just markdown.
What do you think @krishnagopinath and @spaceraccoon ?
I suggest, let's just make a list of all the editors and then do a pros-and-cons list. We have to ship a new editor (with image support) in the next version.

@nshntarora I think I'll start working on this next..

I'm leaning towards using slatejs on this one because

it seems to allow a little more customization through "plugins".. This is fantastic, because in the future, things could be easily made into its own package, if we started using lerna or yarn workspaces..

it just uses the DOM tree to represent the editor state, instead of its own structure (which fb/draft does), which is more intuitive and easy to reason about..


Consolidating Rotala/Alator split

Tasks:

Strategy should define the Broker it operates over rather than Broker pass up impl to Strategy (forcing use of exchange-dependent Strategy).
Move diff from Broker to Strategy

https://github.com/calumrussell/rotala/issues/66#issuecomment-2183981989
Can do this here.
Exchanges currently have their own clock and hold the price source. The prices are never modified by the exchange so this isn't really the logical place to hold this data, and this has led to complex exchange creation logic. The clock is modified by exchange on tick, we could store this state on the exchange but the clock is produced by the source so this has (again) led to complex creation logic.
The strategy also has a clock, this is completely wrong as well. Strategy should get clock info over http/from client.
Clock also has a Vec...I don't know why but this is horrible.

Refactor Penelope significantly to remove clock. Refactor exchange to remove clock and source. Created AppState to orchestrate between components, practically this has meant more code in http. Clock may need to be removed totally.
Impl for Penelope may have performance problems because we are using range scan on BTree in order to find next date (which is passed to AppState to manage).


Include deploy config documentation

Forgot to add the deploy-config.md to mkdocs in PR https://github.com/cloudfoundry/docs-bosh/pull/811


Some questions about inference on PSMnet

Because of the version problems, I haven't been able to run your code. I'm trying to read your code to get a better understanding of your work.
I'm a little confused when i try to understand the construction of PSMNet-AA. You use the PSMNetFeature to extract feartures to construct cost volumes. Although you make a volume list, it actually has only one cost volume. So when you use AdaptiveAggregation, default num_scales = 3, how could you use CSA In this case? I think there would be an error when running assert len(self.branches) == len(x), because len(self.branches) = num_scales = 3, but len(x) = 1.
So where did I get it wrong?  Looking forward to your reply and you pointing out my mistake.
Extremely grateful！

We have constructed an additional feature pyramid for PSMNet feature.


Preparation for moving ggshield.core.file_utils to ggshield.utils.files

refs #521

Codecov Report

Merging #719 (dce7e12) into main (441757a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #719      +/-   ##
==========================================
- Coverage   91.99%   91.98%   -0.01%
==========================================
  Files         138      138
  Lines        5908     5905       -3
==========================================
- Hits         5435     5432       -3
  Misses        473      473

Flag
Coverage Δ

unittests
91.98% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

ggshield/core/filter.py
97.29% <ø> (-0.11%)
:arrow_down:

ggshield/utils/_binary_extensions.py
100.00% <ø> (ø)

ggshield/cmd/iac/scan/diff.py
77.92% <100.00%> (-0.29%)
:arrow_down:

ggshield/cmd/iac/scan/iac_scan_utils.py
97.43% <100.00%> (ø)

ggshield/core/file_utils.py
97.14% <100.00%> (+0.08%)
:arrow_up:

ggshield/core/scan/commit.py
93.47% <100.00%> (ø)

ggshield/verticals/sca/file_selection.py
88.88% <100.00%> (ø)


spirv-fuzz: Replace OpCopyMemory with the pair OpLoad and OpStore instructions

If we have OpCopyMemory %target %source, we could load %source to %source_value and store %source_value to %target. The following is an example.
%source_value = OpLoad %type %source
OpStore %target %source_value

This transformation would receive a fresh id and an instruction descriptor.
The fuzzer pass would look for OpCopyMemory instructions and, randomly, apply the transformation.

@antkarp can we assign this to you? (We'll help prioritize the order.)

Sure, thanks


Check rate and value are not invalid

Link the Issue(s) this Pull Request is related to.
Each PR should link at least one issue, in the form:
Fixes #573
Use one line for each Issue. This allows auto-closing the related issue when the fix is merged.
Summarize your change.
To check that rate and value are not invalid.
Add a list of changes, and note any that might need special attention during review.
Reference associated tests.
If no new tests are introduced as part of this PR, note the tests that are providing coverage.

Codecov Report

Merging #867 (035d93e) into master (bcdd9a7) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
- Coverage   84.18%   84.11%   -0.08%
==========================================
  Files          74       74
  Lines        3061     3059       -2
==========================================
- Hits         2577     2573       -4
- Misses        484      486       +2

Flag
Coverage Δ

unittests
84.11% <0.00%> (-0.08%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/opentime/rationalTime.h
86.95% <0.00%> (-1.94%)
:arrow_down:

...ntimelineio/opentimelineio-bindings/otio_tests.cpp
71.92% <0.00%> (-1.76%)
:arrow_down:

...ntimelineio/opentimelineio-bindings/otio_utils.cpp
86.74% <0.00%> (-0.16%)
:arrow_down:

...elineio/opentimelineio-bindings/otio_anyVector.cpp
100.00% <0.00%> (ø)

...eio/opentimelineio-bindings/otio_anyDictionary.cpp
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcdd9a7...035d93e. Read the comment docs.

Codecov Report

Merging #867 (035d93e) into master (bcdd9a7) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #867      +/-   ##
==========================================
- Coverage   84.18%   84.11%   -0.08%
==========================================
  Files          74       74
  Lines        3061     3059       -2
==========================================
- Hits         2577     2573       -4
- Misses        484      486       +2

Flag
Coverage Δ

unittests
84.11% <0.00%> (-0.08%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/opentime/rationalTime.h
86.95% <0.00%> (-1.94%)
:arrow_down:

...ntimelineio/opentimelineio-bindings/otio_tests.cpp
71.92% <0.00%> (-1.76%)
:arrow_down:

...ntimelineio/opentimelineio-bindings/otio_utils.cpp
86.74% <0.00%> (-0.16%)
:arrow_down:

...elineio/opentimelineio-bindings/otio_anyVector.cpp
100.00% <0.00%> (ø)

...eio/opentimelineio-bindings/otio_anyDictionary.cpp
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcdd9a7...035d93e. Read the comment docs.


Add script to check for broken links in MDX files.

Summary

Added script brokenLink.js to check for broken links in MDX files. The script will run automatically when webpack is called.

Closes #328
Deployment Link

https://terra-dev-site-deployed-pr-#.herokuapp.com/
Testing

Tested it on terra-framework and terra-application
Additional Details

The script will only check for links and not the topic id's associated with the links.
It will not throw warnings for internal links until connected to VPN.

Thank you for contributing to Terra.
@cerner/terra

Unfortunately a lot of the assumptions made here will no longer be correct in next version of terra-dev-site. For instance the build directory will be going away.
https://github.com/cerner/terra-dev-site/tree/unlock-terra-application
Take a look at this branch, which represents the latest iteration of terra-dev-site.

Closing this PR as it is not compatible with terra-dev-site v7.
I have started working on the script to work with v7. Will open a new PR once it is finished.


Improve error from stdenv when srcs is used with colliding directories

Description of changes
Added a -T flag to cp in stdenv's _defaultUnpack, so that when the target directory exists, it will give an error stating that, rather than try to cp inside the directory, and typically fail due to permissions. See #166112.
Things done

[x] Built hello, to check that nothing's drastically wrong (on x86_64-linux).

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

[ ] Tested basic functionality of all binary files (usually in ./result/bin/)

23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I'm only now realizing this doesn't give the error output I was hoping in the problematic cases... :man_facepalming: I'm going to have to include an explicit check.

nix-repl> :b pkgs.stdenv.mkDerivation { name = "test"; srcs = [ (builtins.getFlake "nixpkgs") (builtins.getFlake "home-manager") ]; }
error: builder for '/nix/store/yq9dsbazpyhihrli91wbqln1ns0qfgg4-test.drv' failed with exit code 1;
       last 6 log lines:
       > unpacking sources
       > unpacking source archive /nix/store/sz97qg3wgd5kmlns36vzna4rb75b8jnf-source
       > unpacking source archive /nix/store/xg2ijnl5x1g64dv2hn23g39k6r5fn3sx-source
       > Cannot copy /nix/store/xg2ijnl5x1g64dv2hn23g39k6r5fn3sx-source to source: destination already exists!
       > Did you specify two "srcs" with the same "name"?
       > do not know how to unpack source archive /nix/store/xg2ijnl5x1g64dv2hn23g39k6r5fn3sx-source
       For full logs, run 'nix log /nix/store/yq9dsbazpyhihrli91wbqln1ns0qfgg4-test.drv'.

That's more like it. Any commentary on the exact error output?

Built stdenv, mc and a few other packages against staging. Not outright broken.

Pulled. Thank you!


Default values for ignore_classes don't suit background worker/rake contexts

Most of the errors that are ignored by default are specific to a webserver context, and should often not be ignored when raised from a background worker or a scheduled rake task. Especially ActiveRecord::RecordNotFound and Mongoid::Errors::DocumentNotFound can cause problems, as it is not uncommon for them to occur outside of a webserver context.
Currently one would have to resort to something like this:
Bugsnag.configure do |config|
  # Ignore fewer errors than default (which includes webserver specific entries such as AR:RecordNotFound):
  config.ignore_classes = ["SignalException", "SystemExit"] if background_worker? || rake_task?
end

The value for #background_worker? is not always easily determined. This could easily lead to unnecessary complex setup for anyone using a background worker or scheduling rake tasks. I think many Bugsnag users do, so lets make their lives a little easier!
One quick (but dirty) solution could be to have background worker and rake integrations use a separate setting, e.g. respectively config.background_worker_ignore_classes and config.rake_ignore_classes.
Cheers.

The ruby notifier actually has app_type detection already so you could do something like,
config.ignore_classes << lambda  do |ex|
  if Bugsnag.configuration.app_typ == "rails"
    ex.is_a? SignalException
  else
    false
  end
end

We could add some documentation around it. Its hard to detect all the different background_workers etc so this might be a good way of making it generic and allowing people to do what they want easily.
What do people think of just improving the docs in this area with an example?

Thanks @snmaynard. I like that approach better. It makes it less of a hassle to get around the issue. If I had seen this in the docs I would have probably solved it this way. So, yes, improving the docs would definitely be a step forward.

I can see what you wanted to achieve with these default ignore classes, but that is very surprising in a number of contexts and lets people miss important errors. Not sure if one should even reconsider these defaults, especially with ActiveRecord::NotFound. A documentation fix would be appreciated and needed either way though :)

My rake tasks was failing because of load error NameError (class called with wrong name). Bugsnag didn't report it unless I added require 'bugsnag/rake' into my Rakefile.
Expected it to work out-of-the-box. My app is Sintra app with plain ruby rake tasks.

We've moved the ignore classes into a middleware that gives them a severity of info rather than suppressing them.  The default behaviour is now to report all exceptions and errors.


[Backport 2.x] Prevent message collection from being updated after message count has been received (#2180)

Backports ba9d82ef6a2c6da137c19fcaaddce6dabcf7160f from #2180
Manual backport is required because of:

Conflicts between HTTP5 vs HTTP4  in the files in main vs 2.x.
Some code refactoring in TestAuditLogImpl file

Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Build is broken due to https://github.com/opensearch-project/OpenSearch/pull/8782

Ci should be fixed once #3036 is merged.

@DarshitChanpura FYI the assertion for the failing test was changed on main to only check for 1 message: https://github.com/opensearch-project/security/blob/main/src/test/java/org/opensearch/security/auditlog/integration/BasicAuditlogTest.java#L145C47-L145C47
The test can be updated in this backport with the same assertion.

@DarshitChanpura I see why the assertion on main was set to 1. On main the RestHelper has automatic retries disabled. See https://github.com/opensearch-project/security/pull/2367/files#diff-8a5f07d4e22f127c17298eeebe6ea7bb6b49dd7b2ebd14398b7298627d8ed6d7R401
I think we can disable automatic retries on 2.x and set the assertion in BasicAuditlogTests.testSSLPlainText to check for 1 message


Godot "Help" Menu does not match style of the other menus.

Tested versions

Reproducible in: v4.3.dev5
Not reproducible in: v4.2.1.stable

System information
Godot v4.3.dev5 - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce GTX 750 (NVIDIA; <IP_ADDRESS>33) - Intel(R) Pentium(R) CPU G4500 @ 3.50GHz (2 Threads)
Issue description
Video demonstration of bug being present in v4.3.dev5:
https://github.com/godotengine/godot/assets/46628714/fcd12bcb-90cc-4f14-8ad8-1e49c1c45918
Video demonstration of bug not being present in v4.2.1.stable:
https://github.com/godotengine/godot/assets/46628714/851aa8c5-ec23-4f03-8336-2f67d5e7b7b1
When hovering over "Help" menu, submenu's appear to look not like Godot's, but like default Windows'. After that, focus of Godot Engine window is lost.
Steps to reproduce
Hover over help menu.
Minimal reproduction project (MRP)
Works in a completely empty project.

Also for me, it always appears on the wrong screen.


RC Test: Friction 1.4.0-rc.2 for Keyboard Navigation

@emily-phet @terracoda @mbarlow12 @jessegreenberg  Friction 1.4.0-rc.2 is ready for RC testing. RC.1 was quickly updated to support accessibility features by default, without the need for a query flag.
Link to sim
Link to iFrame
Test Matrix
Issues to Verify
No issues to verify, but please hammer on keyboard navigation as this is only the 4th simulation that has been tested with it.
Please also verify

[x] stringTest=double (all strings doubled)
[x] stringTest=long (exceptionally long strings)
[x] stringTest=X (short strings)
[x] stringTest=rtl (right-to-left)
[x] stringTest=xss (test passes if sim does not redirect, OK if sim crashes or fails to fully start)
[x] showPointerAreas (touchArea=red, mouseArea=blue)
[x] Full screen test
[x] Screenshot test
[x] Does AR need to be notified for any LOL updates?

If any new issues are found, please note them in https://github.com/phetsims/friction/issues and reference this issue.
@ariel-phet please assign and prioritize

@jessegreenberg @zepumph, testing is done here.

Next rc up.


Add a 'filter' option

Hi,
It would be very useful if you could supply a 'filter' option to enable a filtered replication/dump. This way a selective subset of the data could be dumped.
Thanks!
Conor

filter is in now


Newest tabledemo for fixed base changes and EXOTica planning fix

This PR includes

mapping panel task panel for fixed base arms (hidden for humanoids)
tabledemo task panel for fixed base, tested on robot
fixed default parameter sync for tabledemo task panel
merged in @MarcoCar and @mauricefallon newest additions for the humanoids in tabledemo and changed them to the new parameter sync as well (tested)
expanded ImageBasedFitting to be able to turn off showing affordances - used in tabledemo from now on for example (to just show the camera feed/imageview)
expanded RobotiqHanddriver to send to commands to trigger engaging and disengaging motors. These will likely not be used for the Robotiq, but we are using the Robotiq hand driver more as a general hand driver and needed two custom messages - is it okay to have it here and mid-term have a templated hand driver that is adapted? Right now we are handling every command that comes from the Robotiq hand driver in a translator and adapt it to other hands
modified mappingpanel/mappingdemo a bit, now can load arbitrary file directly as "map" polydata element, rather than having to rename it after loading [important for continuing to run segmentation algorithms for example]
fixed planning timing issues when using external / EXOTica planning after fixing EXOTica - now uses the ikPlanner parrameter options to control joint speed

+1

Added new commits to:

plannerPublisher and affordanceManager: support attached collision objects besides rigid/global/stationary collision objects
tabledemo: also sync the affordance, not only the fitted object

+1 for the new commits.
by the way, how do you like using the affordance updater?  I think it works ok but it has some issues that make it sort of clunky.  Animating plans with attached affordances doesn't work well when there is a robot state stream. I can imagine some different designs that would make it work better and be more general.

Great, thanks.
Any other comments / Anything else to consider/amend/test before this is ready for merging?

Looks good, ready to merge?

@mauricefallon is this ready to merge?

I'm happy for it to be accepted.


Unable to connect .sql files to a sql db

Issue Type: Bug
opened existing .sql file with t-sql commands, connection then to SQL Sevrer fails. When opening a new query on the db it works fine, just for existing .sql files it fails connection. File is in a local git repo
Azure Data Studio version: azuredatastudio 1.27.0 (765c7064d46253d88393e0e1ff78874b6fe8fa64, 2021-03-16T21:24:59.168Z)
OS version: Windows_NT x64 10.0.19042
Extensions (15)

Extension
Author (truncated)
Version

firstresponderkit
dre
0.6.0

query-editor-boost
dre
0.4.1

gitlens
eam
10.2.1

vsc-material-theme
Equ
32.5.0

rainbow-csv
mec
1.7.0

admin-pack
Mic
0.0.2

admin-tool-ext-win
Mic
0.0.2

dacpac
Mic
1.8.0

import
Mic
1.3.0

powershell
ms-
2020.4.0

query-history
Mic
0.1.0

schema-compare
Mic
1.10.0

sql-database-projects
Mic
0.8.2

material-icon-theme
PKi
3.9.2

poor-sql-formatter
WSR
0.1.0

Does the path to the file contain a %20 in it? There's a known issue with those paths.
If this is the case could you try getting the latest insiders build and seeing if you still have the issue there? I just checked in a fix yesterday for that.

Hi Charles,
You nailed it on the head, there was a %20 in my Git Rep directory where the .sql files were stored.
Renamed the local folder to remove it and now all is working again.
I did not get a chance to try out the insiders build to see if the bug doesn't exist there, apologies.
Thank you for the assistance!
I will leave it up to you to close this Issue accordingly.

Thanks for the follow up, glad that fixed it! I'll close this issue as a duplicate then.


Any support for 6.2.0 LMOVE ?

https://redis.io/commands/lmove

zmscore is also of interest.
#724

Added in the latest version. Thanks for raising this!

Is this still available in ioredis?

@apexskier It's available. We don't remove methods unless it's removed from Redis. If you are using TypeScript and it reported an error, then it may be a typing issue that should report on @types/ioredis repo.

Ah, that might be the issue, thanks!


Provide require.js add-on in engine

Note
This issue is migrated from here. It was created at 2014/09/13 10:22:27 +0000
Description

Hi, is there any updates on this one?


update to cadence v0.42.7

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (123c06e) 62.30% compared to head (488ec30) 62.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##            v0.41     #550   +/-   ##
=======================================
  Coverage   62.30%   62.30%
=======================================
  Files          24       24
  Lines        2966     2966
=======================================
  Hits         1848     1848
  Misses        994      994
  Partials      124      124

Flag
Coverage Δ

unittests
62.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Display UI version in the footer

Resolves #2661
What is being addressed

Display the ui version in the footer info card
CI checks that the version has been updated when the ui folder changes

love this! might be worth getting #2846 through first, just in case there's a clash in the footer code, but this is cool.

/test-force-approve

love this! might be worth getting #2846 through first, just in case there's a clash in the footer code, but this is cool.

Yes, I'm waiting for it.

oh no.
I have already the test command from a few hours ago I didn't submit and that went it together with me agreeing to wait for #2846. Sorry @jjgriff93


remove build dependency on arm-none-eabi-gcc

by shipping pre-assembled object files. This is the same approach as the
one used in rust-embedded/cortex-m#95
r? @rust-embedded/cortex-m (anyone)

bors r+