Move fulcioroots, test and tuf packages from cosign

Summary
This moves packages from sigstore/cosign into sigstore/sigstore and marks GcsRemoteStore as Deprecated for future work.

pkg/fulcioroots comes from cosign's cmd/cosign/cli/fulcio/fulcioroots, and drops that package's behavior when the SIGSTORE_ROOT_FILE env var is set.
pkg/tuf comes from cosign's pkg/cosign/tuf and is otherwise unchanged.
test comes from parts of cosign's test package, which is used to create temp certs, and is otherwise unchanged.

Part of https://github.com/sigstore/cosign/issues/1865
Release Note
pkg/fulcioroots and pkg/tuf are moved from cosign repo

The lint check is failing due to un-doc-commented exported methods, but I think I'd rather just leave those as-is than balloon the changes in this PR. If folks feel strongly about having these commented I think we should do that in a separate PR.

@haydentherapper @asraa

Any more concerns here? If not I can merge and un-WIP https://github.com/sigstore/cosign/pull/1866 to start using this.

This is a large pr, I want to double check nothing has changed. I don’t have a lot of confidence that a break would be detected once this is used in cosign due to the lack of tests.
I’ll take a look later today or early Monday.

This LGTM - If you're able to wait a few days, it'd be nice to also get @asraa's LGTM since she's the author of the TUF changes.

Sounds good, I've converted to a draft for now. After the issue is resolved I can pick it back up.

After we do this: should probably consider https://github.com/sigstore/cosign/issues/1935

After we do this: should probably consider sigstore/cosign#1935

I'd be fine cleaning it up first then moving it, too. There's no real rush to move it, especially if it causes confusion during cleanups or bug fixes.

I'd like to pick this up again after the TUF changes that blocked us last time, and after https://github.com/sigstore/cosign/pull/1967 -- let me know if there's anything else I should wait for, otherwise I'll update this PR.

I'd like to pick this up again after the TUF changes that blocked us last time, and after https://github.com/sigstore/cosign/pull/1967 -- let me know if there's anything else I should wait for, otherwise I'll update this PR.

Thanks Jason! I think we're ready for updating this. I'll take a close review for this!

Can you move this in a way that preserves commit history? I’ve seen this done for other large moves like this.

Can you move this in a way that preserves commit history? I’ve seen this done for other large moves like this.

I probably can, but it'll be gross, and I don't really trust myself to do it cleanly. I know it's painful to track history through a move like this, I can add links in the PR description to the exact commit the directories were copied from.
If the concern is edits made during the move that don't show up in a nice diff, that's a reasonable concern too. GitHub won't let me attach diffs (weirdly) but I've put them in a Gist here: https://gist.github.com/imjasonh/3befe1aceca12c0d252623d731073658

It’s about tracking how files have changed over time. I think @vaikas is doing this now for the policy controller, do you have suggestions on how to do this?

I'm far from git expert, but i think what i was trying to do was a butt simpler because I was trying to preserve the entire history for the whole repo and not just a subset of files. I have no idea how to do this 😰

@imjasonh I followed a modified version of https://johno.com/move-directory-between-repos-with-git-history for #486 -
$ cd /tmp
$ git clone https://github.com/sigstore/cosign
$ git filter-branch --subdirectory-filter pkg/providers -- --all
$ cd $GOPATH/src/github.com/sigstore/sigstore
$ git remote add cosign-local /tmp/cosign
$ git checkout cosign-local/main
$ git rebase --signoff main

From here move the files to the right files, fix any build / lint issues, and push it up!

Thanks, that's helpful. Between gitsign popping up a browser for every commit and habitually forgetting --signoff (both my own fault) this is going slowly, but I think it'll work out. Stay tuned for this PR to become a 50-commit frankenstein! 👹

Works for me, but is there any way to disable the linter on this code for now so we don't break HEAD?

I've updated the lint action to only complain about findings in changed lines, that will at least let other PRs get merged while these are un-godoc'd.
We'll still need someone to force-merge this over the complaints of the linter in this change though. Or make the check not-required.

Can you exclude whole directories/specific files instead? IMO that makes more sense,  then we can remove that restriction in a follow-up PR and doesn't require any kind of override.

Ooo today, will take a look tomorrow!

Here we goooo!


Get independant cinemas data

Garden Cinema - https://www.thegardencinema.co.uk/
Ciné Lumière - https://www.institut-francais.org.uk/cinema/
Closeup film center - https://www.closeupfilmcentre.com/
All HTML based though appear to have single pages with all showings which can be retrieved in a single request.

Another one - http://www.cinemamuseum.org.uk/topics/events/page/2/


DROOLS-1270 - support fact handle operations for REST APIs on kie server

@mariofusco @etirelli could you please have a look

+1


add niptict domain

@rithyvuth7 First stage of verification passed, official domain is nict.go.jp as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://www.nict.go.jp/en/asean_ivo/lde9n2000000anwh-att/109-Presentation-NIPTICT-26-02-2015.pdf

@rithyvuth7 I am sorry, this domain seems to represent an umbrella institution, not a specific single university or a college. Please apply for free educational license with an official document which proves that you are a student. You can do it using "OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students.
I have to close the request without merging.
Thank you for your understanding!


[BEAM-12363] Don't compile with Java 8 if flag is set

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java 11 Examples on Dataflow Runner V2

R: @amaliujia

Run Java PreCommit


Improve/documentation custom remote keys

:heart_eyes: damn, you're amazing!
Do you mind providing a screenshot that shows more, so people know where to look at?
Like a screenshot of all your Xcode project with a box showing where the little box is.


Completed homework 1

completed homework 1

Nice work overall Olivia! Your code is clean and your discussion of results is clear.


tree efficiency

I think the knapsack 0/1 problem using search tree algorithm can be more efficient.
Right now, I think when using memoization the loop still make the algorithm too longer than usual

[x] put timer to measure real life run time
[x] modify search tree algorithm (recursive) to hand over less return in taken things
[x] modify the search tree to reduce loop after taking result from memo dict
[ ] pass all test after all modification is done

There are some BUG regarding continuous testing of the recursive and dynamic knapsack algorithm. The memoization is not reset if consecutive calls within test is performed even for completely different inputs.
THE FIX: is in the branch fix-memo which checked out prior to this branch.

[ ] Pick one FIX
[ ] Whatever you fix make sure to always merge the fix-memo onto or from 11-tree-efficiency
[ ] consider if memo is best hidden inside **kwargs or still visible as named params
[ ] pass all tests and merge to 11-tree-efficiency before merging to main


can we trigger mentioned list even with continued text (Without space before @)?

The component is working fine. But I want to get the mentioned list after typing<EMAIL_ADDRESS>I get mentioned list when I type Test @. The mentioned list is only getting triggered when I have space before @ symbol. Can we get the mentioned list without space also?

I disabled this ability because it causes unnecessary mention list appearing for emails. Is it critical for you?

@dabakovich Is this possible right now? I also want to get the mention list both cases. (with space and without space).


Propose a new Conda Technical Review Board

Proposal
I’m proposing to form a “Technical Review Board” subteam to improve the process of authoring, reviewing and voting on Conda Enhancement Proposals.
Team Charter
Following the governance policy, this is a static charter with the additional conditions that:

any member of the Conda Steering Council may join this team at any time
the number of non-steering TRB members is at most 3
the Conda Steering Council may change the number of non-steering TRB members via a simple majority vote
the non-steering TRB members are elected, and can also be removed, by the Conda Steering Council in a secret ballot similar to sensitive voting items listed in the Conda Governance Policy
the vote threshold for addition or removal of a non-steering TRB member is a simple majority
the elections happen annually after an application period of 2 weeks before the election date
the Conda Steering Council will call for applications
applications must contain a short statement by the candidate towards confirming their credentials and their ability to work as a technical reviewer
the Conda Steering Council retains the right to call votes on CEPs without the approval of the TRB

Work areas
The Technical Review Board is charged with the following:

follow the Conda Code of Conduct
act in the best interest of the conda community
provide their technical expertise to the conda governance process
facilitate the review, handling and shepherding of Conda Enhancement Proposals that are labelled as "technical"
enable the Conda Steering Council to vote on technical CEPs

Responsibilities

co-maintenance of the conda-incubator/ceps repository, especially of CEPs labelled "technical"
guide and mentor the CEP authors in scope of this team charter
provide quarterly reports to the Conda Steering Council about the current status of the technical CEPs
submit all technical CEPs that are deemed ready for vote by the CEP author(s) and TRB for vote to the Conda Steering Council
provide a recommendation to the Conda Steering Council (e.g., “Our vote recommendation: yes”)
to reduce the effort needed by the Conda Steering Council, the technical CEPs may be submitted as an omnibus proposal set (read: one vote for many technical CEPs)
if the vote by Conda Steering Council does not match the TRB’s recommendation, the technical CEPs must be reviewed again by the TRB and may be submitted in the future, after appropriate changes are made
communicate the voting results to the CEP authors and communications team

Scope
The “Technical Review Board” is working for the Conda Steering Council and follows the Conda Code of Conduct. The team provides guidance to new and existing authors of Conda Enhancement Proposals with the objective to submit the proposals for vote to the Conda Steering Council individually or optionally as part of a regular (quarterly) omnibus set.
The team in particular exists to enable the Conda Steering Council to conduct votes on matters that require deep technical understanding and to facilitate the participatory process.
Initial applications
As part of the adoption of this proposal, I suggest to:

[ ] vote on the proposal (see below)
[ ] if passed, call for applications for the founding Technical Review Board

@conda-incubator/steering
Vote
This proposal falls under the "Sub-team Formation" policy of the conda governance policy, please vote and/or comment on this proposal.
It needs 50% of the Steering Council to vote yes to pass.
To vote, please leave "Yes" or "No" below as comments.
If you would like to propose changes to the current proposal or have questions, please leave a comment below as well.
This vote will end on 2023-02-22.

Yes!

Yes

Yes!

Generally think this is a good idea. IIRC this follows off of a discussion we had last year to move in this direction of having a technical advisory group on CEPs.
One discussion in the meeting that raised was that "the number of non-steering TRB members is at most 3" is kind of limiting. Admittedly this falls out of our governance structure today. The thinking is that a subset of the steering council may not be the answer for moving technical proposals forward. We may need/want a different group of people. Maybe there is another vehicle we can use that doesn't have this limitation? Alternatively we can update governance, which @tnabtaf is looking into (please correct me if I misunderstood).
Another thread of discussion in the meeting, would suggest we somehow organize this by subtopic (installers, repodata, package format, recipe structure, plugins, etc.) and form subgroups (within? below? ??) the TRB to handle these more scoped topics. Suggest this in terms of expertise, interest, creating smaller/faster groups to make changes.
A final point was a concern IIUC about the SC and TRB handing down edicts. At least as I understand it the process we have been going through (particularly recently) is the opposite.  So the work of the TRB and the SC to some extent is helping developers convert these into readable specs so this knowledge is accessible.

Yes your final statement is goal here. It might be good to have a more cohesive approach to specs and standards. Having a standing body devoted with expertise devoted to this would be helpful.
I'll also add that even if your expertise is in one subdomain as opposed to the other, that doesn't necessarily disqualify you from looking over CEps.

Also, @jakirkham, there just are not that many of us active in the community as a whole, maybe 25-30? So having the TRB be divided up by topic, while it sounds nice, might end up with an excess of bureaucracy. A single body, of order 5-10 people give or take, would be sufficient for most things.

AIUI the overall goal here is to be nimble and move quickly. I'm imagining ~5 +/- (maybe even just 3) per topic. More than that is probably more than needed.

The TRB should organize this themselves. There's no reason to enshrine a fixed list of subjects in our docs or even that that has to exist. Instead we specify large scale responsibilities and let the folks with the responsibility do as they please.

Yeah not trying to micromanage people or overencumber governance docs
Instead my aim is to save all of TRB from being pulled into a bunch of different areas when finer areas of focus and delegation would result in a smoother experience and quicker resolution. If we were to encapsulate this in the docs perhaps it is by setting a very low number of required TRB members for any one discussion thread
Anyways maybe in practice these subgroups would behave similar to language subteams of conda-forge/staged-recipes. Allowing people to dedicate attention to core competencies/interests

Some thoughts.

I also think we should rethink the 3 person limit.
As discussed in today's call, I will work with @jezdez, and anyone else on this thread, to create a governance update proposal, including formal language.
@jakirkham and @beckermr That includes addressing, somehow (please keep discussing!), how to get decisions from board members with relevant experience for a topic, without overwhelming board members without relevant experience.  Since teams are self-governing, most of this might end up in the team's charter, rather than in the conda organization governance doc.

@jezdez Thanks bunches and bunches for starting this discussion.

Thank you all for the feedback!
FWIW, I’m not interested in changing the governance to help with the issue. I’ve contemplated it and decided against it given my experience the last two years. E.g., the last governance update was hand-wrung about even after it passed and so I learned to enable those that are wiling to act instead (e.g. create more subteams and project teams). My goal here is a low-bureaucracy standards and proposal process. IMO the “subteams” of the governance policy already provides enough structure for this, with an appropriate team charter.
I’m a sad to see little support  for this proposal which would give enough wiggle room to the TRB to self-govern other than that, e.g. hear expert witnesses to make an appropriate recommendation to the steering council.
In particular @wolfv’s words rung true about whether the TRB would be effective and need to be heard with the context of Mamba’s existence and the work in the larger conda ecosystem not coming from Anaconda Inc.
The number of people in the TRB proposal exists to reduce the overhead of communication and coordination and is balanced out by the time limitation serving on the TRB, to prevent power hoarding. It doesn’t have to be 3, but 5 or 7 also works. But the more seats, the harder it is to find enough people willing to do the work. Would no limit be preferable?
Whatever we do, if the TRB ends up being a “steering council light” we missed our chance to enable more voices to actively participate in conda development.
So IOW I’m leaning toward not supporting a governance change myself if it means that power/influence is kept only in the steering council’s hands. We have simply too few people in there that are doing the technical work of evolving conda, supporting proposal authors and enabling a vital community.

Closing given no additional feedback.


Require a new string view class with c_str()

##c_str()
std::string_view does not provide c_str() as a result of unfeasibility on determining whether the pointed buffer is null terminated without invoking undefined behaviour, namely, accessing array element beyond boundary.
##Workaround
Such determination can instead be done at the construction of a string view object. An internal flag is required to denote whether the string view object in interest is null terminated. Additionally, an internal dynamic buffer ( std::shared_ptr? ) is required to make a copy of the non null-terminated buffer when needed. c_str() can be implemented accordingly.

null terminated: return data()
otherwise: make copy of the buffer and return shared_ptr to it

the use of optional<const char*> makes user syntax too verbose
should switch back to initial dynamic buffer strategy

refer to new issue on
https://github.com/samyankc/MyCppInclude/issues/3#issue-1923479038https://github.com/samyankc/MyCppInclude/issues/3#issue-1923479038


Godot Engine 3.2 GLES2 does not support blendshapes

Godot version:

OS/device including version:

Issue description:
Importing shapeKeys from blender 2.82 in gltf 2.0 format or from blender 2.79 with godot DAE shapeKeys don't work.
If possible it would be good to fix it for the glTF 2.0 format in Blender 2.82
Steps to reproduce:
Create 1 cube in Blender 2.82 and add a shape key to deform the mesh
Importing shapeKeys from blender 2.82 in gltf 2.0 format or from blendert 2.79 with godot DAE shapeKeys don't work.
If possible it would be good to fix it for the glTF 2.0 format in Blender 2.82
Create 1 cube in Blender 2.82 and add a shape key to deform the mesh
Export the scene in gltf 2.0 format
check the mesh containing the shapeKey, you will see that it appears, but it does not work.
https://youtu.be/gNXgbOeqHr4
Minimal reproduction project:
cubo_shape_animation_2.82.blend.zip
cubo_shape_animation 2.79.blend.zip
prueba godot rigging.zip

I just verified in the Godot console that shapeKeys are not supported in GLES2 ..
And they work in GLSL3 I hope they will work in GLSL2 soon.

https://www.youtube.com/watch?v=zqVNiJSIUZA&feature=youtu.be

i'm just facing the same issue.
@pouleyKetchoupp @lawnjelly @clayjohn any possible solution for gles2?
here is my simple project for demonstrating it.
blend_shape_gles2.zip
in gles3

in gles2

it actually worked fine with godot 2.1.5 in gles2

@Calinou I think this is a feature request rather than bug unless it's not documented.

@fire Are blendshapes even technically possible using GLES2?

Since this is a part of Godot Engine 3.2 and there is nothing we can do except implement the GLES2 blendshape proposal, I'm not sure what can be done.
Also, I don't think any developers are working on this within the next 6 months.

in the same pc unity suport blendshapes and .blend files, sorry godot i go to unity

in the same pc unity suport blendshapes and .blend files, sorry godot i go to unity

Software blendshapes are being implemented for GLES2 as we speak :slightly_smiling_face:
https://github.com/godotengine/godot/pull/48480

It would be a good implementation, I should not criticize Godot much, that is, I did a course in systems technology and my project to finish was a video game for Android and I presented it in Godot, although I had already worked with the unit, but wanted to test it.


For CMS73v4, IPP count is expected as 2.0 instead of 1.0 error in Cat 1 file

A patient "5 N VTE" gets denominator inclusion failed for 2 visits as shown below

The CAT 1 generated has details for both the visits and the error should not persist.
Please find the screenshot of the error for cat1 and the output file attached of the patient

5_N VTE.txt

Any update on this ticket?

Hi
This is an episode of care measure.  Each episode that meets the population criteria is counted.
The attached patient has two diagnoses that start within two encounters
Diagnosis of Venous Thromboembolism during an encounter on April 1st, and a diagnosis of Obstetrics VTE during an encounter on May 17th.
-Dave Czulada


bugfix: use filename, if present, when pasting files

Summary
previously we constructed a name property everytime we uploaded a file (or raw image data) via pasting (CTRL/CMD + V). With this we now use the filename if it exists and only construct the name string Image pasted at xxx when there is no filename property in the event object.
Ticket Link
n/a
Related Pull Requests
n/a
Screenshots
n/a
Release Note
NONE

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/223984

Thanks @michelengelen - do we have a Jira ticket for this?
Tested, looks good to merge.
Verified file names when pasting files - as expected.
E2E report - no PR related failures.

No we don't have one, since it is just a small fix.

/cherry-pick release-7.2

Cherry pick is scheduled.


Lto changes for upstream

What's in this pull request?

This pull request contains some changes to enable full LTO on Darwin. The main differences are:

Instead of passing in -flto via cflags to LLVM, we use the LLVM provided flag -DLLVM_ENABLE_LTO. We also pass this into Swift now so that we can ensure that the compiler unittests (which use the gtest infrastructure from LLVM) also are compiled with -flto.

We ensure that the lipo we use is from the toolchain that the user specified for xcrun and we use xcrun to find it. This ensures that we use the lipo that is associated with the rest of our toolchain during compilation which ensures that the lipo tool can read all of the resultant binaries/etc.

We are using a more conservative formula for estimating the maximum number of LTO processes to use. I found that the estimates given to me previously were too optimistic. These numbers seem to prevent my test machines from swapping.

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@swift-ci Please smoke test and commit

@swift-ci Please smoke test


Check whether a market is active before trading

I ran into a situation today where BCH/USD was temporarily halted on an exchange and the bot wanted to trade it. It obviously couldn't, but kept trying and throwing exceptions for a few minutes. It would be nicer if it checked first and didn't treat it like an error.

This is made more complicated because I can't find any method in XChange to ask an Exchange whether a particular market is active or not. We may just have to rely on catching the exception and reversing the first trade if it succeeded. That's not a great solution because this situation pretty much only happens in times of very high volatility and even the few milliseconds between opening a trade, realizing it needs to be reversed and reversing it could result in losses.


Add logs mechanism

Use a stable library for logging (e.g. version >=1.0.0)
Add some useful logs in the code.

trace level to explain decision tree
debug level to explain operations

Implementation

Use RUST_LOG=level where level is either trace, debug, info, warn, info
Use LOG_DIR=path to directory to set the output directory.
The file will be output as qt_ts_tools.log.

Example:
RUST_LOG=debug LOG_DIR=. ./qt-ts-tools

tracing seems to be becoming the industry standard. However this is a sub 1.y.z version.
However there doesn't seem to be any lib that satisfies, so it's ok.

Fixed.


Revert "Revert "Don't strip strings on output""

This change is in support of the CA linefeed fix.  Reverts a reverted commit so whitespace are not automatically stripped on lists.
Issue:
https://github.com/rancher/rancher/issues/13831
This reverts commit 4bcc025ae37faa5f4a8a6614df4e8133530f84d2.

LGTM

LGTM


Chrome still prompts one to select the chrome profile even after providing full path

so I examined this line
		Run(CliEscape(ChromePath) ' --remote-debugging-port=' this.DebugPort ' --remote-allow-origins=*' 			(ProfilePath ? ' --user-data-dir=' CliEscape(ProfilePath) : '') 			(Flags ? ' ' Flags : '') URLString, , , &PID)
and personally had problems when providing the full profile path.
However, if I ran in windows Run the following, it works correctly
"C:\Program Files\Google\Chrome\Application\chrome.exe" --remote-debugging-port=9222 --remote-allow-origins=* --profile-directory="Profile 2"
hence I think the ' --user-data-dir=' could be replaced with '--profile-directory='
and the user has to specific the Default, Profile 1, or Profile 2 as the 4th param

This issue cannot be reproduced in edge.

Yes but try in chrome

Maybe Google Browsers broke the compatibility.
You can pass additional command-line parameters in the flags parameter.

cool will do that thanks


Rewrite CSV support as an internal extension

For consistency's sake and for the sake of having a builtin example.

Actually, this gets pretty weird because of import order issues. If the patching happens in init then other modules that import Table directly might not have the patched version, but the only other alternative is to put it at the bottom of table.py which is also confusing.
Not gonna do it.


send_audio_file returnes NoneType.

I tried your example of using audio files but I get the error:
TypeError: 'NoneType' object is not iterable
when I run the script.
Is this bug known? And if so, how can I fix it?

@Tagge thanks for the explanation
@Tubinex did you solve the problem?

ah yes audio can be hard if there is little documentation.
in case it helps, if it's webaudio good news is I've done that myself: https://github.com/richtier/voice-command-lifecycle/blob/master/command_lifecycle/helpers.py#L23
used that in related project https://github.com/richtier/alexa-browser-client/

@Tubinex I was able to get Discord's audio 48k sample rate 2 channels -> 16k PCM 1 channels. Its a stream transformer in Node.JS though, lmk if you want it.


Use builder generics as intended

Added a merge commit for fixing the conflicts with the base

Merge conflicts are resolved, but the list_folder command does not seem work on this branch yet.
(node:42639) UnhandledPromiseRejectionWarning: Error: Invalid folder state on both private and public commands
I'll dig around to find the cause.

(node:42639) UnhandledPromiseRejectionWarning: Error: Invalid folder state on both private and public commands

We needed to account for the root folder of a drive, which does not include the Parent-Folder-Id tag.
Fixed here: 3ccf613
The list-folder and folder-info commands are now functional here!


"guaranteed next round matchup" algorithm

It would be excellent if the system could tell you a guaranteed matchup for the next swiss round during the final game of the current round.

This might become irrelevant with the algorithm created with commit 76824c4a89
Pretty sure we can just auto-populate all the future matchups now.

This algorithm needs to take into account whether teams are currently playing in the last round of the current swiss round. Teams need at least a one game break between games.


chore(release): 27.0.0-next.5

Pull Request Test Coverage Report for Build 536646038

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.629%

Totals

Change from base Build 536326448:
0.0%

Covered Lines:
945

Relevant Lines:
975

💛  - Coveralls


Directions, help, clarification text within tool

Jocelyn will review tool and ID what our needs are

"how to use this page" text
info buttons (what does this language mean/specific functionality do)

and then talk with Ryan about how to implement.

include:

[ ] workaround for results map language (both over table and hamburger menu)
[ ] workaround for deselect all selected spatial filters
[ ] Explicitly call out 10-Run Maximum limit for ranged budget runs


+CATEGORY: Only show category

e.g. doing +M +C will show cache and memory features.

Don't know why I made this Issue. Grep/findstr at best.


Add POST method support

Modify to be able to handle POST method
@mdsol/team-10 please review

LGTM. I do not know if it is difficult to write a spec for this or the project in general lacks

Sorry, would you mind explaining why this is necessary? Why can't you just pass the body in using attributes and leave params empty on a POST? This looks like it makes it impossible to make a POST containing params, which is unusual but not unheard of.

I have added a TODO and specs
@jcarres-mdsol  @HonoreDB  please review

Thanks, looks good to me.


[miniz] Add new port

This solves #5449 by adding https://github.com/richgel999/miniz to vcpkg under miniz. I tried to follow best cmake practices as much as is possible, but I may have gotten something not quite right.
I did add a patch to give the miniz cmake a proper config file for easy integration. I chose to do it via a patch because the last release was in September, so even if I get something in master, it will be a very long time until another release.

I've fixed issues on windows and linux x86/x64, but those are the only systems I have access to. Anything else I'm going to need your guys' help as I can't see why the build is failing. :slightly_smiling_face:

Thank you for the new port, it looks great so far!  The failures are in the x64-uwp and arm-uwp triplets which you will be able to test on your windows machine.  If not then let me know and I can have someone else look into it for you.
install-x64-uwp-dbg-out.log

Totally forgot about uwp. Will try it out once I get home to my desktop. Thanks for the log!

All x86/x64 build on my machine uwp or normal. I can't get it to accept arm/arm64 as a valid target, but I probably don't have my toolchain fully setup in some way.


Incorrect transform for static private property

Describe the bug
Input code
class  Foo {
  static #_ = (() => { this.bar  ="3"; })();
}

Config
{"jsc": {"target": "es2015"}}

Actual behavior
class Foo {
}
var __ = {
    writable: true,
    value: (()=>{
        this.bar = "3";
    })()
};

Expected behavior
A clear and concise description of what you expected to happen.
Babel REPL
class Foo {}

var _ = {
  writable: true,
  value: (() => {
    Foo.bar = "3";
  })()
};

Version
The version of @swc/core:
Additional context
REPL
I found  this via working on #2474. Because of this bug, transform in saitc blocks does not work well.

I'll fix it soon


Emit socket error events

Totally up to you whether you want to accept this, but I needed to make some of these changes so I figured I would see if you wanted them.
Reasons for the changes:

Net socket errors were never emitted, so if the initial connection failed, an error would be asynchronously thrown with no good way to catch it.
The isConnected state variable and the 'connect' event were being triggered regardless of it a connection was actually established. I left the 'connect' event that way just in case it's supposed to mean it's starting to connect
Deleted isReady since it didn't appear to be used anywhere

Deleted isReady since it didn't appear to be used anywhere

isReady is used by Johnny-Five as part of the required IO-Plugin semantics.


Missing initial step re: registering tools

This tutorial is missing a step, callout or note that lets the reader know that with the default subscription that is created, adding a SQL server instance is not possible.
I am attempting step #4 of "Create a blank data warehouse in SQL pool", and am currently researching how to get around an error I see when trying to add a new server: "This location is not available for subscription".
For all of the detail that is included in the preceding steps, I'm shocked that this is not mentioned in any way in this tutorial.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d26e70c3-2769-5b47-2bda-8a4a7f0239d0
Version Independent ID: 558a36bd-e151-1e4c-4427-fc52eb2d91e3
Content: Tutorial: Load data using Azure portal & SSMS - Azure Synapse Analytics
Content Source: articles/synapse-analytics/sql-data-warehouse/load-data-wideworldimportersdw.md
Service: synapse-analytics
Sub-service: ****
GitHub Login: @kevinvngo
Microsoft Alias: kevin

I have finally been able to get around this, but I will again repeat that the first step (at least for me) was not possible until I signed up for a paid subscription - which is a callout sorely missing from this tutorial

@sasedlock  This is known issue with Azure.
To all our Azure SQL Data Warehouse customers,
Please read the following communication pertaining to this ongoing issue: Our commitment to customers and Microsoft cloud services continuity. .
If you are in a situation where you are in an immediate need to deploy services and are being blocked in doing so, please use the Azure Portal to raise your request.
Microsoft Azure is committed to helping our customers. We’ll continue to monitor the situation and will keep you updated. We appreciate your patience and apologize for any inconvenience caused.
Hope this helps.

@sasedlock  We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


does it Work with eve ?

Can i have status and temperature info of that :
https://www.elgato.com/fr/eve/eve-door-window
and insert it to openhab ?
Thanks

The bridge will only expose openHAB items to homekit, not the other way round. Homekit has no public API to access accessories from outside.


Project home page layout

The full design on the project page is not done, but we Have a layout example that can be implemented.
The header section should be simple to implement sins the only thing needed is to scale the image and have a propper placement of the view in One Equinor button.
If no image is present from STID then a default image will be required.
url example https://stiddata.equinor.com/public/OSA.jpg
This page should have its own error boundery.

@Noggling Did you not push latest change out on Friday?

@chriispychiicken tells me she has made some minor adjustments, so we need a follow up here.


Make log and run (lock, restart) path configurable

AC:

The log path of thin-edge should be configurable.
The run path of thin-edge should be configurable.
The current hardcoded paths should be the default.

agent restart path is defined here
lock file is defined here
and i think log path is defined here


Add a  -server flag to sblookup.

This PR adds a new -server flag to the sblookup utility to allow specifying the API server to use for lookups. This is convenient for testing against a non-standard (e.g. mocked) GSB server. If it isn't provided the value defaults to safebrowsing.DefaultServerURL, preserving the sblookup behaviour prior to 2d4b3e238ee3c2115d11de3773c49c19007cd75a.

\cc @colonelxc, the new maintainer of this repo (so I've been told).

Change LGTM. Up to @colonelxc to merge.

@dsnet @colonelxc Thank you both

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
If you signed the CLA as a corporation, please let us know the company's name

I signed it.
It was signed on behalf of "Let's Encrypt" as the corporation.


⚠ ClamAV has degraded performance

In 9815954, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 86 ms

Resolved: ClamAV performance has improved in bde1f69 after 5 minutes.


Write tests for network service

Will need to stub out https module to do so.

Tests are written.


Second Gmail Account

There is any way to add second account??

Yes, go through the process of downloading the client secret file for each account, say they are named client_secret1.json and client_secret2.json. Then when you make a Gmail object for each, you need to pass in distinct values for the name of the credentials file (named gmail_token.json by default):
from simplegmail import Gmail

gmail_acct1 = Gmail(client_secret_file="client_secret1.json", creds_file="gmail_token1.json")
gmail_acct2 = Gmail(client_secret_file="client_secret2.json", creds_file="gmail_token2.json")

Just make sure you always use the same file names for the same accounts the next time you run it (otherwise it will ask you to authenticate again if it can't find the creds_file specified).


Fix -Wformat issues in the tree introduced by LOG()

@tromey is trying to add -Wformat to the Gecko build, but there are a bunch of warnings produced by libcubeb.  See https://treeherder.mozilla.org/logviewer.html#?job_id=33131814&repo=try#L47515
I fixed the WASAPI ones in 7073670f1621a11cf999e833a2e2309f0b98e16d and b583da9ec1f90038e90981db55d3a32518d640b3, but we need to do a fix pass over the other backends.

-Wformat=error is being done in https://bugzilla.mozilla.org/show_bug.cgi?id=1060419.  I'll probably temporarily add -Wno-format there, and file a followup bug to remove this after the next libcubeb import.  If there's a bug for the next libcubeb import, feel free to CC me on it.

The OSStatus warnings only show up in 32-bit OS X builds.  64-bit builds are silent.  That's because we're trying to log via %d but OSStatus is a typedef of SInt32, which is a typedef of signed int on __LP64__ and signed long elsewhere.

4f0c5bd5c06dd14931ffeb1f9e11c5f5124d3231 fixes the cubeb_audiounit.c warnings.

I think that's all: 32- and 64-bit Linux are -Wformat clean, we're using a different logging mechanism on Android (__android_log_print) for now, and Windows/MSVC needs a different annotation (_Printf_format_string_) which hasn't been implemented for libcubeb's logging yet.
https://bugzilla.mozilla.org/show_bug.cgi?id=1324987 tracks updating Gecko's copy of libcubeb.


NodeJS SDK: query buider args as strings

To be more consistent with Go and Python SDKs, we should pass strings as arguments instead of object with the NodeJS query builder.
// BEFORE
const node = await client.container().from({ address: `node:${nodeVersion}` })

// AFTER
const node = await client.container().from(`node:${nodeVersion}`)

Since TS doesn't have named parameters, the same can be done as in Go for the optionals. I.e., make required parameters positional, and put optionals in an opts argument typed in an interface.
const node = await client.container().from(`node:${nodeVersion}`).exec({args: ["node", "--version"]})

TBD with @dolanor


Add a wait for yum to complete

Just prior to this section (https://docs.microsoft.com/en-us/azure/virtual-machines/linux/using-cloud-init#troubleshooting-cloud-init), I would strongly suggest you add a verification step.
I wasted hours and hours trying to troubleshoot my cloud-init, when instead I just needed to be patient and wait for the yum to complete. This is because my understanding of the cloud-init was that it would run the transaction as soon as the VM was built, so it would be not available until after the cloud-init was finished.  That's not the case.
Suggest adding a verification where the user runs:
# wait for the cloud-init yum to complete with the following command:
sudo yum check-update
# if you get a message that yum is locked, then just be patient

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 67fb132b-0dc3-d493-69bc-dc28b5bfd5e1
Version Independent ID: ba5cb476-3e32-911f-0395-0cc8087d1ff3
Content: Overview of cloud-init support for Linux VMs in Azure - Azure Virtual Machines
Content Source: articles/virtual-machines/linux/using-cloud-init.md
Service: virtual-machines-linux
Sub-service: extensions
GitHub Login: @danielsollondon
Microsoft Alias: danis

@andybouts
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

The article has been updated since this issue was created, so I think the section in question no longer exists? I'm going to close this issue for now, but feel free to as for it to be reopened if the issue wasn't addressed. Thank you!
#please-close

This is not correct, the doc was moved as a bullet of the original doc linked above and still needs a blurb added for users ... otherwise, users will get to "Run the package management tool and check for updates." and they will be frustrated like I was ...

@Karishma-Tiwari-MSFT Can you reopen this issue and reassign it to srijang? Thank you!
@srijang FYI

@andybouts Thanks for letting me know that the issue still exists. I'm having this reopened and assigned to the the new person managing cloud-init docs for Azure :)

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. If you are still experiencing a problem, you might want to move this question to Microsoft Q&A: https://learn.microsoft.com/en-us/answers/tags/94/azure-virtual-machines. #please-close


Added Related Video From Channel 9 For App Actions

Added video from channel9 of app actions as related video.

@manojkulkarni30 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Signing up for frontend

Description

Allow user to sign up a new account by filling in their personal informations, such as email, passward, user name etc. When signing up an account, user's informations should be verified before the account is successfully created. After signing up, user's informations should be stored in the database.
Acceptance Criteria

[x] User should be able to fill in their information and creat an account easily.
[x] User's information should be verified before submitting.
[x] User's information should be stored in the database.

Implementation details

After the initial frontend setup and UI design is done, the signing up page can be created. After that, the functions of the page can be added to enable input verifying and data transmission.
Testing notes

n/a

PR #204 completes this logic. However, as we are using google auth through firebase the user does not have to enter so much information, and currently all we store about them is their name.


PSTN Usage report should refer to the report in the Teams Admin Center

This section should be update to remove reference to Skype for Business Admin Center and instead reference the Teams Admin Center
"Organizations already using Skype for Business Online already as their service provider can get usage data by reviewing it in the Skype for Business admin center > Reports > PSTN usage details report.
When you are setting up Communications Credits, you will need to investigate call usage for your organization to determine the amounts you need. You can get call usage information by reviewing the PSTN usage details report. This report lets you export the call data records to Excel if you need to store the data or create custom reports. To learn how to see usage, read Skype for Business PSTN usage report."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 277cf140-5c6c-82c7-cc56-490ef2188754
Version Independent ID: 72e7de29-fd71-23bf-15a7-172634c2a5fd
Content: Set up Communications Credits for your organization - Microsoft Teams
Content Source: Teams/set-up-communications-credits-for-your-organization.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

@NickElniff  Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@NickElniff  Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Trx is broken if there are invalid symbols in output

It’s unable to parse trx as XML when it contains some invalid symbols. As example "&#x0" symbol in test output

done in 25cf46c


Add get_ai_message_id to PipelineBot

Description

The PipelineBot didn't have the get_ai_message_id parameter, and so chatting with one was failing. This was introduced here: https://github.com/dimagi/open-chat-studio/pull/702
I added a test that failed without this change.
User Impact

Users were unable to chat with Pipeline Bots. Now they can.

Codecov Report
Attention: Patch coverage is 82.05128% with 7 lines in your changes missing coverage. Please review.

Files with missing lines
Patch %
Lines

apps/chat/bots.py
33.33%
4 Missing :warning:

apps/experiments/views/experiment.py
0.00%
3 Missing :warning:

Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!


#185233328 Integrate Categories Section with Backend

What does this PR do?
This PR is used to integrate categories Section with backend
Description of Task to be completed?

[x] Filter and display all categories that are in all products
[x] Display that products related to category accordingly
[x] Test the functionality with jest

How should this be manually tested?

run GET: /

Any background context you want to provide?
What are the relevant pivotal tracker/Trello stories?
Story ID: #185233328
Screenshots (if appropriate)

Questions:

Please use Env variable and replace those hard coded backed links


groups: only show 'mark as read' if unreads exist

On the tin. Only shows the "Mark All as Read" button in groups/notifications if there are any actual unread notifications.

Haha, I think I probably could :)


Section upgrade Path error/incomplete/inconsistant

Section upgrade Path :

refers to upgrading to version 18 , should this be version 19?  ( a direct upgrade to version 18 (19) isn't always .... )

Upgrade Path table  from
Business Central 2020 release wave 2 (version 17)   states "Direct to version 19"
from other sources (https://docs.microsoft.com/en-us/dynamics365/business-central/dev-itpro/upgrade/upgrade-v14-v15-compatibility#version-17-compatibility) I understand this is only true as of version 17.5
For me this is unclear - what are proper steps from 17.4 to 19.x version full upgrade ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e6382910-e49d-0e74-e2a7-87f1d246dfce
Version Independent ID: f9de1ba9-4cde-46ab-2dc4-3b832534214e
Content: Upgrade to Business Central 2021 Wave 2 - Business Central
Content Source: dev-itpro/upgrade/upgrade-overview-v19.md
Service: dynamics365-business-central
GitHub Login: @jswymer
Microsoft Alias: jswymer

Hello, Thanks for the feedback!
Regarding your first bullet, we've changed "version 18" to "version 19".
From 17.4, you can go to 19.0 or 19.1, although we recommend 19.1. We'll be making changes to this article to make things clearer going forward.


Requirement for Markdown parser

I can see everyone talking about front-end tier but no one is talking about Markdown to HTML parser.
I understand there are tonnes of inbuilt libraries but it would not be very hard if we make our own.
I can do this with nodejs.
Also, i can design an express/GraphQL API for the same.

Hey, welcome to GSSoC ’23, this is an amazing idea. But half the things have already been done. There’s a Landing Page that’s half completed and there’s the App that’s been half completed too! I’m currently setting things up and also adding the videos for those who are completely new. Will be creating labels and assigning it. Can we please wait for a day max until I make the ReadMe and push the base code and base branches (one for the web and another for the app)? 🙏🏻
Thanks, it won’t be long. A new video will be coming up. Don’t close the issue, we’ll see how we can make it fit. 💪🏻

I guess that would be frontend, there is still 0 work on backend with the markdown parsing.
Using prebuilt libraries would be bad thing to use. I think we should do some hurry and push the code already so that we can work on backend.

@0x0is1 I totally understand, this is needed and you're doing it. Made a note! 💪🏻


Issue when there a multiple choice question type is selected and the dialog is LUIS enabled

I have enabled allow interruptions in multiple question  so that LUIS can be enabled so that if any unwanted string is detected it should go to unknown

intent but when I run the code the LUIS is called twice and it doesn't go to unknown intent. So how do i solve this issue

@likith3611 can you upload your bot assets to this ticket? You should not be seeing multiple LUIS trace events within a single turn of the conversation.

I am currently using older version of composer not the newer once hence assets cant be uploaded. But these are my settings as shown and the dialog is LUIS enabled

I can repro what you mentioned above. @luhan2017 for awareness

@likith3611 I think it is by-design the UnknownIntent will not be triggered in this scenario, otherwise, it will be almost always triggered by any input which doesn't make sense, I've tried to create an valid trigger, and verified it can be triggered if you input the trigger phrases in choice prompt.
For the luis trace shown twice issue, I am investigating more on that.

Closing this issue as this behavior is by design


Setup is not working for AGP (Android gradle plugin) version 4.2.0 or lower

I was exploring the SDK Runtime API's and found a couple of setups issues

While building the application with the provided setup steps,  is not available for the current compiled SDK version
Error : AndroidManifest.xml:18: AAPT: error: unexpected element  found in .
It does not let you install the app into the Tiramisu Android Privacy sandbox emulator by saying incompatible target SDK for the Android emulator.
Error:
The installation did not succeed.
The application could not be installed: INSTALL_FAILED_OLDER_SDK
The application's minSdkVersion is newer than the device API level

Note: Emulator : Pixel 4 with play service and image: TiramisuPrivacySandbox x86_64

Hi - Are you able to update to the latest stable Android Studio / Android Gradle Plug-in / build-tools? The manifest merger has been updated in recent versions to properly handle this.


Show this to MKBHD

This is a dare

@aadium Make a private donation to an artist. This is a dare.
A lot of artists work on “good faith” that those who like their work enough will “do the right thing” and make a charitable contribution. Apps like the one this project aims to combat exploit those artists for profit at the cost of the artist.


Bluetooth: SMP Don't return STK if it hasn't been generated yet

The SMP_FLAG_ENC_PENDING flag indicates that we've generated an STK
and are waiting for encryption to happen. In case the remote enables
encryption prematurely we should not try to encrypt with whatever is
stored in smp->tk, rather reject the pairing attempt.
Fixes #3222
Signed-off-by: Johan Hedberg<EMAIL_ADDRESS>

Note: completely experimental and not tested. We should probably run at least the PTS SMP tests before merging (ping @MariuszSkamra)

Codecov Report

Merging #9126 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9126   +/-   ##
=======================================
  Coverage   52.45%   52.45%
=======================================
  Files         200      200
  Lines       25121    25121
  Branches     5244     5244
=======================================
  Hits        13178    13178
  Misses       9822     9822
  Partials     2121     2121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 573f32b...d1895c8. Read the comment docs.

@sjanc FYI

SMP tests passes

Thanks @MariuszSkamra !


⚠ Bofrost.fr has degraded performance

In 8888808, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1300 ms

Resolved: Bofrost.fr performance has improved in cbbf0a5 after 9 minutes.


Failed building the project. Make sure the build command is correct and try again.

Describe the bug

npx shadcn-ui@latest init --yes && npx shadcn-ui@latest add table dialog button dropdown-menu
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-p2nuhd
Steps to reproduce
got to build
see the error
and see npx shadcn-ui@latest init --yes && npx shadcn-ui@latest add table dialog button dropdown-menu
Expected behavior
normal build process now in a loop somehow
npx shadcn-ui@latest init --yes && npx shadcn-ui@latest add table dialog button dropdown-menu
I guess this is going wrong
Screen Recording / Screenshot
npx shadcn-ui@latest init --yes && npx shadcn-ui@latest add table dialog button dropdown-menu
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 188500999,
  "usedJSHeapSize": 153107695,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = Cooldudeams
Chat ID = e15b344e7162

Additional context
Error:
Failed building the project. Make sure the build command is correct and try again.

Appreciate the feedback! We are aware of this issue and are tracking it here: #2019


Added russian translation

Mne nravits'ya! I'm afraid I'm not qualified to validate the translation for obvious reasons :)


Why is the AP low for 'faster_rcnn_r50_fpn_1x.py'

Hello author, I seem to have encountered an issue while running the file "faster_rcnn_r50_fpn_1x.py". I ran it for 12 epochs, but the accuracy has remained around 0. However, when I run "retinanet_r50_fpn_1x.py", everything works fine, and the final average precision (AP) is around 29. I haven't made any changes. This is the log file. Could you please help me identify where the problem might be?
20231104_104651.log

I've run both faster RNN and RetinaNet multiple times, and while the accuracy of faster RNN remains consistently low, RetinaNet runs smoothly. I noticed in issue 12 that the 'faster_rcnn_r50_fpn_1x.py' exhibits ap50 to ap95 values that are extremely low, less than 5%. Would you kindly spare a moment to provide an answer amidst your busy schedule?

two problems for your config:

featmap_strides should be [4, 8, 16, 32] instead of [8, 16, 32, 64] for roi head feature extractor;
lr=0.02 for batch size 8, it should be 0.01 for 4

The problem has been resolved. Thank you so much！


Tests don't output anything

I'm sure that very interesting things are happening when I run npm run test, but none of it is showing up in the terminal. All that I get (after the output from npm run compile) is the message "ECHO is on", but the first test should be failing and causing mocha to bail.
It may be worth noting that executing the commands separately, as listed in package.json (redirecting the output of mocha to a file because || isn't a valid separator in Win7 PowerShell), generates the same output for npm run compile and nothing at all for mocha.

Can you propose how these scripts should look like? I will make the script that will the right commands based on OS. I tested it out on my Win10 with cmd.exe and standard Node installation. I must admit I am not really aware how it should really work on PowerShell.

I just tried it with a cmd.exe shell inside my PowerShell session, as well as in a separate cmd shell, and the same thing happened as when running directly from PowerShell. I think npm automatically adapts the value of the properties in the "scripts" section of package.json for the OS; otherwise, running npm run test would give the same error as trying to use || as a separator directly, which it doesn't.
Can you provide a screenshot or copy-paste of what I should see in the screenshot when the first test fails?

Thanks. It looks there there used to be a bug in Mocha where piped output wouldn't be written, but it says it was closed in June 2015. I'm not sure why the same thing appears to be happening now; I'm running mocha v2.3.4, node v4.2.4, npm v2.14.12. Will try testing something else for comparison purposes.

I've tried basically everything I can think of at this point, to no avail. I'll just run this on my Win10 laptop, I guess. Let me know if there's anything I can add to help reproduce the problem.

I am locking this issue. If you have any idea how to point me to the right direction, please open it up again. :)


Reduce Rust panics

We are using Rust, let's make an effort to reduce these numbers
oxc/crates  main ❯ git grep panic | wc -l
      32
oxc/crates  main ❯ git grep unreachable | wc -l
      90

Is it possible to ban these for non-test non-example only without adding the clippy cfg everywhere?


Few improvements

[ ] issue #
[ ] follows contribution guide
[ ] code change includes tests
[ ] breaking change

@b-j-roberts  i will close my other PR , i had conflict issues i coudlnt solve easily and it was faster for me to do this way

@b-j-roberts  I also replaced alll assert! with assert() function in the codebase. While its nice in tests as you can easily print long strings, using the macro actually costs way more steps because of the ByteArray construct

@b-j-roberts I also replaced alll assert! with assert() function in the codebase. While its nice in tests as you can easily print long strings, using the macro actually costs way more steps because of the ByteArray construct

Nice catch, had slipped my mind.


FR: Restore full screen state when Vienna launches

I run Vienna full screen in its own Space. When I quit and relaunch Vienna (which happens on a restart or a version update), it would be nice if it reopened the main window into a Space, instead of opening on the desktop and requiring me to manually click the zoom button.

This behaviour is automatic for NSWindowController (which we currently don’t use). This requires some refactoring, as the main window is currently referenced 100+ times in AppController and elsewhere.

Ohh good to know - getting a proper NSWindowController is high on the list of priorities for me.

#930 should have solved this.


96 set qutip opts

Fixes #96

Pull Request Test Coverage Report for Build 129

12 of 13 (92.31%)  changed or added relevant lines in 4 files are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.2%) to 86.648%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

maxwellbloch/ob_solve.py
8
9
88.89%

Files with Coverage Reduction
New Missed Lines
%

maxwellbloch/ob_atom.py
1
94.87%

maxwellbloch/ob_solve.py
1
84.27%

Totals

Change from base Build 125:
-0.2%

Covered Lines:
1233

Relevant Lines:
1423

💛  - Coveralls


ACL are missing since the UI change

Describe the bug
Hi, we are experimenting with two issues since the new UI change in the ACL.
1.- You can't search for External Roles
2.- While the ACL from the existing events is selected, the ACL doesn't show the users, only the local roles.

To Reproduce
Enable ACL with LDAP
Expected behavior
It should show the users. and the role of external search should work.
Important info: We are using LDAP. The logging and roles work as intended, only the ACL panel in the admin UI.
I'm not very well versed with the front end. If someone can help me debug this issue, I can find and fix the problem's root. The dev tools from the browser show that roles exist and are retrieved.

I'm gonna cc @Arnei on this since this was his PR. :D

@Arnei I'm not sure if external roles is the right term. The typical LDAP connection does not import users in to opencast. They are retrieved from LDAP and then assigned roles within opencast for a session/login. The derived roles e.g. ROLE_USER_BBUNNY are then used in ACLs.
To answer your question: No those roles are not in the /admin-ng/acl/roles.json but in admin-ng/event/59b50b25-69e2-4886-8043-12e7717a382b/access.json
It seems the endpoint you are referring to just lists the users and groups that are in Openasts DB

On etc/custom.properties:
# Optional custom roles pattern (regular expression). Roles matching this pattern can be added to ACLs. org.opencastproject.security.custom.roles.pattern=^(ROLE_USER_[A-Z][A-Z0-9]*|LDAP_[A-Z][A-Z0-9]*_ADMIN|[0-9]+_(LEARNER|INSTRUCTOR))$

Then you need to create a new LDAP config file using the template etc/org.opencastproject.userdirectory.ldap.cfg.template

On org.opencastproject.organization-mh_default_org.cfg:

Set true the external role display:

# Set a flag to display External Roles on User modal
#
# Value: <boolean>
# Default: false
prop.adminui.user.external_role_display=true

Finally, enable LDAP in the security file (Normally security/mh_default_org.xml).

If I recall correctly those are all the steps you need to try LDAP. I will update shortly to give you a mini ldap server you can run with docker compose locally.

@Arnei I'm not sure if external roles is the right term. The typical LDAP connection does not import users in to opencast. They are retrieved from LDAP and then assigned roles within opencast for a session/login. The derived roles e.g. ROLE_USER_BBUNNY are then used in ACLs. To answer your question: No those roles are not in the /admin-ng/acl/roles.json but in admin-ng/event/59b50b25-69e2-4886-8043-12e7717a382b/access.json It seems the endpoint you are referring to just lists the users and groups that are in Openasts DB

Thanks for the clarification. The Admin UI also uses the endpoint you described (admin-ng/event/{event-ud}/access.json) to get the roles for the event. But if I understand Max correctly both endpoints should return derived roles, right? Since you want to be able to add derived rules not currently present in the event?

On etc/custom.properties:

# Optional custom roles pattern (regular expression). Roles matching this pattern can be added to ACLs.
org.opencastproject.security.custom.roles.pattern=^(ROLE_USER_[A-Z][A-Z0-9]*|LDAP_[A-Z][A-Z0-9]*_ADMIN|[0-9]+_(LEARNER|INSTRUCTOR))$

2. Then you need to create a new LDAP config file using the template `etc/org.opencastproject.userdirectory.ldap.cfg.template`

3. On `org.opencastproject.organization-mh_default_org.cfg`:

   * Set true the external role display:

# Set a flag to display External Roles on User modal
#
# Value: <boolean>
# Default: false
prop.adminui.user.external_role_display=true

4. Finally, enable LDAP in the security file (Normally `security/mh_default_org.xml`).

If I recall correctly those are all the steps you need to try LDAP. ~I will update shortly to give you a mini ldap server you can run with docker compose locally~. Here it is: https://github.com/rroemhild/docker-test-openldap

Thanks for the detailed explanation and the link to the docker-test-ldap. I'll try to test with that and see if I can find something obviously wrong.

both endpoints should return derived roles, right? Since you want to be able to add derived rules not currently present in the event?

As Christoph said, admin-ng/event/{{event_id}}/access.json give the roles list that is in the media package.
While /admin-ng/acl/roles.json gives you the list of roles saved in Opencast locally.
Users when they logged into opencast, they get the ROLE_USER_{user_id} as stated on acl.default.creat.properties

The docker container you suggested does not work. Any other way I can spin up a test ldap with custom roles?

I'm sorry to hear that the docker-compose didn't work.
Try this server https://www.forumsys.com/2022/05/10/online-ldap-test-server/. I used it in the past for troubleshooting. I just tested and it is working

Right, that server is very helpful for doing some basic ldap tests. But how does it help me test with custom roles? Can't make changes to the server there can I?

Why would you want to make changes on that server? It has all you need. A few users that you can search for from opencast.
This should be the settings you need for connecting to that ldap-server
in org.opencastproject.userdirectory.ldap-test.cfg
org.opencastproject.userdirectory.ldap.id=test

org.opencastproject.userdirectory.ldap.url=ldap.forumsys.com

org.opencastproject.userdirectory.ldap.searchbase=ou=mathematicians,dc=example,dc=com
org.opencastproject.userdirectory.ldap.searchfilter=(uid={0})

org.opencastproject.userdirectory.ldap.roleattributes=cn

org.opencastproject.userdirectory.ldap.userDn=cn=read-only-admin,dc=example,dc=com
org.opencastproject.userdirectory.ldap.password=password

org.opencastproject.userdirectory.ldap.userattributes.name=cn

and in security/mh_default_org.xml
  <!-- ################ -->
  <!-- # LDAP Support # -->
  <!-- ################ -->

  <bean id="contextSource"
    class="org.springframework.security.ldap.DefaultSpringSecurityContextSource">
    <!-- URL of the LDAP server -->
    <constructor-arg value="ldap://ldap.forumsys.com:389" />
    <!-- "Distinguished name" for the unprivileged user -->
    <!-- This user is merely to perform searches in the LDAP to find the users to login -->
    <property name="userDn" value="cn=read-only-admin,dc=example,dc=com" />
    <!-- Password of the user above -->
    <property name="password" value="password" />
  </bean>

    <bean id="userDetailsMapper" class="org.opencastproject.security.ldap.OpencastUserDetailsMapper">
      <constructor-arg ref="userDetailsService" />
    </bean>

  <bean id="ldapAuthProvider"
    class="org.springframework.security.ldap.authentication.LdapAuthenticationProvider">
    <constructor-arg>
      <bean
        class="org.springframework.security.ldap.authentication.BindAuthenticator">
        <constructor-arg ref="contextSource" />
        <property name="userDnPatterns">
          <list>
            <!-- Dn patterns to search for valid users. Multiple "<value>" tags are allowed -->
            <value>uid={0},ou=mathematicians,dc=example,dc=com/value>
          </list>
        </property>
        <!-- If your user IDs are not part of the user Dn's, you can use a search filter to find them -->
        <!-- This property can be used together with the "userDnPatterns" above -->
        <!--
        <property name="userSearch">
          <bean name="filterUserSearch" class="org.springframework.security.ldap.search.FilterBasedLdapUserSearch">
            <! - - Base Dn from where the users will be searched for - - >
            <constructor-arg index="0" value="ou=GroupName,dc=my-institution,dc=country" />
            <!- - Filter to located valid users. Use {0} as a placeholder for the login name  - - >
            <constructor-arg index="1" value="(uid={0})" />
            <constructor-arg ref="contextSource" />
          </bean>
        </property>
        -->
      </bean>
    </constructor-arg>
    <!-- Retrieve user and attributes from opencasts user details service -->
    <property name="userDetailsContextMapper" ref="userDetailsMapper"/>
    <!-- Defines how the user attributes are converted to authorities (roles) -->
    <!-- Output is ignored if used together with userDetailsMapper -->
    <!-- constructor-arg ref="authoritiesPopulator" /-->
  </bean>

and a bit further down in security/mh_default_org.xml
 <!-- Uncomment this as an alternative to the userDetailsMapper -->
  <!-- Make sure you provide the same instanceId you used in org.opencastproject.userdirectory.ldap-….cfg -->

  <osgi:reference id="authoritiesPopulator" cardinality="1..1"
                  interface="org.springframework.security.ldap.userdetails.LdapAuthoritiesPopulator"
                  filter="(instanceId=test)"/>

As stated in the comments above, you need to make sure that the .cfg file and that instanceId match.
I hope this helps. I have not tested this since I don't have a local opencast instance.

Workaround: Reverting #4487 (Going back to the old ACL UI). But this is for the UI of 13.x.   I haven't tested yet how behaves on 14.x this workaround.

Is there a workaround for this issue on OC 14.x? We used to be able to create ACLs for our Active Directory users (which are not persisted in the database) by using a custom role pattern for ROLE_USER_XXX. At the moment, we cannot do that anymore and have to manually sync all our Active Directory users to the Opencast database.
I really do appreciate the UI change in general, but unfortunately it broke some functionality for us.

Finally got around to taking another look at this, since Max provided my with his LDAP config (thanks again!).
I think I now have a better understanding of how the external role selection works. All this really boils down to is that a custom role pattern can be defined in etc/custom.properties like
# Optional custom roles pattern (regular expression). Roles matching this pattern can be added to ACLs.
org.opencastproject.security.custom.roles.pattern=^(ROLE_USER_[A-Z][A-Z0-9]*|LDAP_[A-Z][A-Z0-9]*_ADMIN|[0-9]+_(LEARNER|INSTRUCTOR))$

So when a string like ROLE_USER_GIBBERISH was searched for in the dropdowns in the access policy tab, that string would be matched against the custom role pattern. If successful, the string could then be added to the event/series as a role.

So the old process had nothing to do with looking up users or roles in LDAP in other external user-/role-providers. It simply allowed users to define whatever role they wanted as long as it matched the custom roles pattern defined in etc/custom.properties. This is still how it works for non-user roles. Or at least this is how I think it works, please correct me if I'm wrong.

So how should this work in the future? Mainly I'm wondering if people want to be able to add whatever users they want, or if we should actually check whether the user they are trying to enter is actually a valid user in Opencast or external user providers. So we could:

Make use of custom.role.patterns again. So when GIBBERISH is entered into a "user" dropdown in the access policy tab, Opencast would convert that to ROLE_USER_GIBBERISH and check if it matches the custom role pattern in etc/custom.properties. If true, the Admin UI would then allow it to be added to the event/series. This will still work if GIBBERISH is not a valid user, the ui will then simply display the user "gibberish" as non-existing.

Check if the entered string maps to a valid username via i.e. the admin-ng/{username}.json endpoint. So when GIBBERISH is entered into a "user" dropdown in the access policy tab, Opencast would check if GIBBERISH is a valid user anywhere (Opencast DB, LDAP, etc.). Only if Opencast gets confirmation that GIBBERISH is indeed valid would the Admin UI allow it to be added to the event/series.

I don't have a strong opinion on either approach, I'm more interested in hearing what our community members who use this in production think.

As discussed in the Dev meeting on 26. Sept. The first option (Make use of custom.role.patterns again) is the best course of action.

@Arnei There something that I completely forgot to mention to you.
If you have roles set in the previous UI and you update, those roles will appear in the new UI as blank fields in the users section of the new UI.


Basic shape support added

Summary
This PR adds basic shapes support.

Parse existing shapes in XLSX file
Methods in worksheet to list existing shapes and add new one
Save it in XLSX file.

Test plan
Adding a new shape in a Worksheet
      ws.addShape(
          {
            shape: Shape.DOWN_ARROW,
            rotation: 45,
            fill : {color: '4499FF', opacity: 0.6},
            stroke: {color: '88AAFF', opacity: 1, weight: 2}
          },
          {
            tl: {col: 19, row: 31},
            ext: {width: 120, height: 50}
          }
        )

will result to :

Below a list of tested shapes :
Shape.LINE = 'line';
Shape.RECTANGLE = 'rect';
Shape.ROUND_RECTANGLE = 'roundRect';
Shape.ELLIPSE = 'ellipse';
Shape.TRIANGLE = 'triangle';
Shape.RIGHT_ARROW = 'rightArrow';
Shape.DOWN_ARROW = 'downArrow';
Shape.LEFT_BRACE = 'leftBrace';
Shape.RIGHT_BRACE = 'rightBrace';

this project is still maintained ?

great work!
hope this can be merged

@DantSu Could you please move over here? I'd be happy to merge this feature.

I am one of those who wants this feature, so I created another PR with a few additional functionalities and no conflicts based on this.
https://github.com/exceljs/exceljs/pull/2601
I highly appreciate this PR, and hope that this feature would be realized (doesn't matter which PR would be merged).
Any suggestions are welcome :)

I'm sorry to say that, but you lost your time. ExcelJS is not maintained anymore. I have open this PR a year and a half ago.... nothing has happened since. Look the comment of @zurmokeeper, he have fork and maintain it. You can PR on this fork.

Thank you for the comment!

I have open this PR a year and a half ago.... nothing has happened since.

Yes, I feel sorry about that. Have you already moved to the fork, DantSu?
I'm not sure whether ExcelJS is no longer maintained, because recently I found a post saying @Siemienik would like to make the project active again and a new version 4.4.0 would have been released https://github.com/exceljs/exceljs/discussions/2351.
Maybe we can expect that the project would gain momentum.
Of course, it's a pity that this PR is not yet reviewed or merged...

I haven't see this post, this is a great news for this great library. I hope my PR wil be merged.
I haven't migrate to the fork, I haven't time for this, feel free to do this.

I agree with you and thank you for the permission!

So yes, this project is becoming active again after a long time. I apologize if this causes any inconvenience. I'm doing everything I can to keep it alive, even though it's primarily a volunteer activity for me. Please leave a thumbs-up 👍 on the PRs that are most important to you, as this is a key factor for me in deciding which ones to review next. Also, your activity in the pinned discussions is very helpful, especially if you would like to see something included in the next release.
#2573 #2574
I also encourage you to be active on our Discord:

@Siemienik Thank you for your answer, you don't have to apologize. Open source project in sleeping mode is very common, and nobody has to complain. I thought the project was abandoned, because in most open source project it is.


CloudShell is not opening

Describe the bug
CloudShell is not opening. It is showing Sign-in but can't move forward
What happened?
When I try to open CloudShell upper right corner of a code block. It shows a continuous Sign-in Loading page. I checked all possibilities like the internet but the issue was not solved. Therefore I launch Cloud Shell in a separate browser tab by going to https://shell.azure.com/.

What did you expect to happen?
It should launch CloudShell
How would you reproduce the bug?

Go to Create a single database - Azure SQL Database.

Go to PowerShell.

3.Go to Codeblock and click on PowerShell

Did this happen via Desktop and/or Smartphone?
Desktop
Operating System
Windows 11
What browsers are you seeing the problem on?
Chrome
Version
No response
Device
No response
What is your current role?
Student Ambassador
What technical topic is this bug related to?
Application Development, Other
Relevant log output
No response

@anupamishra333 thank you for this issue, do you experience this on any other module that has a sandbox environment?

No, I just tried on another module and works well on another module


added version clarification

Partially addresses concern in #589

LGTM.

:shipit:

:shipit:

@OAI/tdc I've updated the version to be 3.0.0.-rc0 per call.


Java code example missing

Please also add a code example for Java-clients. Something like
MongoCollection collection = mongoDB.getCollection("collectionName");
String index = collection.createIndex(Indexes.ascending("_ts"),
new IndexOptions().expireAfter(10L, TimeUnit.SECONDS));
would be sufficient. I was only able to find that out with the help of customer support.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0196349a-477b-281e-4143-9f5e51713327
Version Independent ID: a6abda68-9066-0199-1b2b-219a8a0ca0cb
Content: MongoDB per-document TTL feature in Azure Cosmos DB
Content Source: articles/cosmos-db/mongodb-time-to-live.md
Service: cosmos-db
Sub-service: cosmosdb-mongo
GitHub Login: @sivethe
Microsoft Alias: sivethe

@frochi42 Thank you for your query , our team will review it and get back to you at the earliest.

@frochi42 The PR for the fix has been created and it will be merged once approved by the author. Thanks again for pointing this out, I am closing the issue based on this update, please let us know if there is something else that we can help you with.


fix: add docker compose healthchecks, which somehow prevent grafana c…

…rashing on startup

Works as intended seems to not crash anymore


Use Cases (Roeland Luykx (RALY GmbH))

ch.fhir.ig.ch-rad-order#2.0.0-ballot /usecase-english.html
Link to profiles and partially examples are missing.
Roeland Luykx (RALY GmbH)

@JBleuer

A heading is not displayed correctly

For 2.3 Obtaining a second opinion and 2.4 Requesting previous results and please replace “Related” with “Associated ”.

Titel fixed, "Related Questionnaire* replaced with "Associated Q..."


update managed cluster unknown condition message

Signed-off-by: liuwei<EMAIL_ADDRESS>

/assign @qiujian16

refer to https://github.com/open-cluster-management/backlog/issues/7671


[TieredStorage] Store account address range

Problem
The TieredStorageFooter has the min_account_address and
max_account_address fields to describe the account address
range in its file.  But the current implementation hasn't updated
the fields yet.
Summary of Changes
This PR enables the TieredStorage to persist address range
information into its footer via min_account_address and
max_account_address.
Test Plan
Updated tiered-storage test to verify persisted account address range.

Codecov Report
Attention: Patch coverage is 94.82759% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.9%. Comparing base (184ba6c) to head (1919ce0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage    81.9%    81.9%
=======================================
  Files         837      837
  Lines      226898   226955   +57
=======================================
+ Hits       185871   185926   +55
- Misses      41027    41029    +2


Is tag of foreignkey  just add foreign key while not add constraint for the time being?

What version of Go are you using (go version)?
go version go1.10.2 windows/amd64
Which database and its version are you using?
PostgreSQL 10

type User struct {
	gorm.Model
	Name string
}

type Product struct {
	gorm.Model
	Code  string
	Price uint
	UserID uint
	User  User

as code up lists
as table created in db, the result:
user_id is created.
but the foreign key constraint of  is not created.
what I want to confirm are:
1、Is tag of foreignkey  just add foreign key while not add constraint for the time being?
2、Are Gorm relate and association functions just “soft association” between struct objs while not db entities？
Thanks for your answer.

Documentation is severely lacking in this regard.
Then there are 2 kinds of docs.
What is the definitive guide to GORM associations?
For instance 2 models:
type Community struct {
	Model
	OwnerID     uuid.UUID    `gorm:"type:uuid" json:"owner_id"`
	Name        string       `json:"name"`
	Description string       `json:"description"`
	Locale      string       `json:"locale,omitempty"`
	Containers  []*Container `gorm:"foreignkey:community_id;association_foreignkey:id" json:"containers"`
}

type Container struct {
	Model
	CommunityID uuid.UUID `gorm:"type:uuid" json:"community_id"`
	Title       string    `json:"title"`
	Forums      []*Forum  `gorm:"foreignkey:container_id;association_foreignkey:id" json:"forums"`
}

Those are the 2 top models.
According to documentation this should create the hard association in the database. http://gorm.io/docs/has_many.html well to be fair it doesn't state that. Documentation is lacking. Well the foreign keys are not created. When I create them manually, I have to create it on the reference_id side's table and it creates an index. So maybe gorm not doing this is a bug?
I usually don't use SQL anymore so this is my.. well 1st time I'm using it for an actual serious project. And the only reason I am is because manual association creation in mongodb/go is rather cumbersome.
@jinzhu can we have an answer?

#450 original issue


iframe attribute "height" specified in percentage is invalid in html 5

Hi,
While looking at the HAL browser here http://haltalk.herokuapp.com/explorer/browser.html I've noticed that after clicking the "docs" icon for the "ht:users" relation, the upper right "Inspector" box did not display correctly. Further investigation revealed that the issue was in the relative height of the ".documentation iframe" style definition.
.documentation iframe { width: 100%; height: 100%; }
For the reference, the Mozilla Developer Network specifies for the "height" attribute of the "iframe" element: "Indicates the height of the frame (HTML5) in CSS pixels, or (HTML 4.01) in pixels or as a percentage."
Also, as soon as I changed the value of "100%" to for example "400px", the "Inspector" box was immediately displayed correctly.
Regards,
Mladen.

I see the same issue, clicking on the "docs" section displays a very small window making it difficult to read its contents.


Alternative method to kill the dissolved

The dissolved being functionally immortal outside of the portable hole focus causes a lot of frustration for players not focusing on thaumcraft. Considering how this mod leans into the multiplayer aspect with a number of it's items, I think it would be fitting to give the dissolved an alternate method of death similar to the Quicksilver elemental. I purpose making it so a ender pearl can kill/remove the enemy when used on it. This would still make the dissolved a significant threat while also preventing others on a server from being severely punished for not focusing thaumcraft. I'd also suggest for this alternate method to not give void seeds.

Death by enderpearls makes sense, however dissolved can be killed without portable hole focus - he can be lured into his own hole, which will make him suffocate in blocks.


Default text track file

If a file as nested text track files, allow specifying a property to
store the id of a default text track file.

Coverage remained the same at 99.095% when pulling d90b9253697c2f4b954cfb344458f9da495e7705 on tf:default-text-track-file into 349014fc4d1a911fb1beccbb3c5cad84e1e4a379 on codevise:master.

Coverage remained the same at 99.095% when pulling d90b9253697c2f4b954cfb344458f9da495e7705 on tf:default-text-track-file into 349014fc4d1a911fb1beccbb3c5cad84e1e4a379 on codevise:master.

Coverage remained the same at 99.095% when pulling 4bce6634f3b1a4a8f5b520c39dd33bf0f7211a0c on tf:default-text-track-file into 953d72224ff44b572e577fffd29a2132d80d7aa4 on codevise:master.

Coverage remained the same at 99.095% when pulling 4bce6634f3b1a4a8f5b520c39dd33bf0f7211a0c on tf:default-text-track-file into 953d72224ff44b572e577fffd29a2132d80d7aa4 on codevise:master.

Coverage remained the same at 99.095% when pulling 340de2fc382a71144c65ee3d66952e3deb6c4e01 on tf:default-text-track-file into 953d72224ff44b572e577fffd29a2132d80d7aa4 on codevise:master.

Coverage remained the same at 99.095% when pulling 340de2fc382a71144c65ee3d66952e3deb6c4e01 on tf:default-text-track-file into 953d72224ff44b572e577fffd29a2132d80d7aa4 on codevise:master.

Coverage decreased (-5.08%) to 94.011% when pulling aed5ccda2e5091250969e2f4fd48a1de7ec9c615 on tf:default-text-track-file into 953d72224ff44b572e577fffd29a2132d80d7aa4 on codevise:master.

Coverage decreased (-5.08%) to 94.011% when pulling aed5ccda2e5091250969e2f4fd48a1de7ec9c615 on tf:default-text-track-file into 953d72224ff44b572e577fffd29a2132d80d7aa4 on codevise:master.

Coverage remained the same at 99.095% when pulling 1f0f4b77707e74639a791a1770029b7e765d8edb on tf:default-text-track-file into 953d72224ff44b572e577fffd29a2132d80d7aa4 on codevise:master.

Coverage remained the same at 99.095% when pulling 1f0f4b77707e74639a791a1770029b7e765d8edb on tf:default-text-track-file into 953d72224ff44b572e577fffd29a2132d80d7aa4 on codevise:master.


[SPARK-46355][SQL][TESTS][FOLLOWUP] Test to check number of open files

What changes were proposed in this pull request?
Added an unittest to ensure that the XML parser doesn't have unbounded number of open files.
Why are the changes needed?
To test the fix of too many open files.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unittest
Was this patch authored or co-authored using generative AI tooling?
No

Merged to master.


Refactor/optimize Player and Pipeline play, stop, and next logic

The Player Next logic, which stops, nulls, and plays the next queued video -- because of the multiple timer threads required to transition through these states -- has some potential reentrancy issues.
The Pipeline and Player Stop logic, in certain cases, is leading to the EOS event calling the client callback, which is calling stop a second time.

complete - merged into v0.24.alpha


[Enhancement]: Updating to 1.17.4?

What changes would you like?
Hi.
MakeMKV snapd 1.17.3 version doesn't work anymore :(
Can you update to 1.17.4 version?
Thanks in advance.
Any extra information?
No response

Looks like this is on the latest/edge channel sudo snap refresh --channel=latest/edge makemkv. @diddlesnaps, any chance of getting it released to latest/stable? Thanks :D!

the latest available since few days ago is 1.17.5


Feature request: Implement removeAboveValue, removeBelowValue and transformNull to filter/transform the data

I'm submitting a ...

[ ] Bug report
[x] Feature requestdd
[ ] Question / Support request

Implement removeAboveValue, removeBelowValue and transformNull functions like in Graphite ( http://graphite.readthedocs.io/en/latest/functions.html )
removeAboveValue - replace value with NULL if value > N
removeBelowValue - replace value with NULL if value < N;
transformNull  - replace null values with N
Example of removeAboveValue(N):

Input series (";" as separator): 0;1;2;3;4;5;6
Function definition: "removeAboveValue(3)"
Output series: 0;1;2;3;null;null;null

Example of removeBelowValue(N)

Input series (";" as separator): 0;1;2;3;4;5;6
Function definition: "removeBelowValue(3)"
Output series: null;null;null;3;4;5;6

Example of transformNull(N):

Input series (";" as separator): 0;null;2;null;4;null;6
Function definition: "transformNull(3)"
Output series: 0;3;2;3;4;3;6

Hi @alexanderzobnin , are you planning to tag a new release with these features any soon?

Yes, I'm going to release new version in next few days.


[WFLY-9781] created simple integration test for Forwarded handler.

Created integration tests for https://issues.jboss.org/browse/WFLY-9781.

@jstourac Adding the fixme label. Please ping me when done

@stuartwdouglas I have updated this to address your comments. Although, now two tests that I have added are failing - those are testRewriteGlobalSettingsServlet and testRewriteWithUndertowHandlersServlet. Both utilize servlet instead of handler. And problem is with  methods HttpServletRequest.getLocalAddr() and HttpServletRequest.getLocalPort(). These methods actually don't contain what is provided by Forwarded ~ by header. But have original local address and port (<IP_ADDRESS> and 8080 in my case).

You should get checking getRemoteAddr not getLocalAddr

Actually the test checks also getRemoteAddr values. The problem is that getLocalAddr and getLocalName returns different results.
Header value in request:
Forwarded=for=<IP_ADDRESS>:455;proto=https;by=<IP_ADDRESS>:777

What particular methods return in case of handle usage:
HttpServerExchange.getSourceAddress() = /<IP_ADDRESS>:455
HttpServerExchange.getRequestScheme() = https
HttpServerExchange.getDestinationAddress() = /<IP_ADDRESS>:777

Those are correct.
Servlet case:
HttpServletRequest.getRemoteAddr() = <IP_ADDRESS>
HttpServletRequest.getRemoteHost() = <IP_ADDRESS>
HttpServletRequest.getRemotePort() = 455
HttpServletRequest.getScheme() = https
HttpServletRequest.getLocalName() = <IP_ADDRESS>
HttpServletRequest.getLocalAddr() = <IP_ADDRESS>
HttpServletRequest.getLocalPort() = 8080

Values of getLocalName() and getLocalAddr() should be the same, IMHO.

https://issues.jboss.org/browse/UNDERTOW-1280 has fixed the issue with getLocalAddr() returned value. If https://issues.jboss.org/browse/UNDERTOW-1282 is accepted and merged, these tests start to pass.
@stuartwdouglas do you see something I should improve or rewrite in this MR anymore?

retest this please

Adding hold label as this needs an updated Undertow version

Retest this please

Retest this please

Well, tests failed with:

Cannot find commit 60c30982dc764cc2f51e0f8e6c8c5940c4b18c84 in the https://github.com/wildfly/wildfly.git repository, possible reason: refs/pull/10860/merge branch was updated and the commit selected for the build is not reachable anymore
Failed to perform checkout on agent: Cannot find commit 60c30982dc764cc2f51e0f8e6c8c5940c4b18c84 in the https://github.com/wildfly/wildfly.git repository, possible reason: refs/pull/10860/merge branch was updated and the commit selected for the build is not reachable anymore

Not sure I understand the root cause as I have not updated this for a while... Anyway, I tried to rebase. Let's see the results now...

Okay, the tests seem to pass after the rebase :)


fix handling of rune arrays

Codecov Report

Merging #138 (1b3cec0) into main (8e3dafd) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   92.12%   92.19%   +0.07%
==========================================
  Files          18       18
  Lines        5142     5126      -16
==========================================
- Hits         4737     4726      -11
+ Misses        353      349       -4
+ Partials       52       51       -1

Impacted Files
Coverage Δ

engine/lexer.go
87.87% <100.00%> (+0.53%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3dafd...1b3cec0. Read the comment docs.

Codecov Report

Merging #138 (1b3cec0) into main (8e3dafd) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   92.12%   92.19%   +0.07%
==========================================
  Files          18       18
  Lines        5142     5126      -16
==========================================
- Hits         4737     4726      -11
+ Misses        353      349       -4
+ Partials       52       51       -1

Impacted Files
Coverage Δ

engine/lexer.go
87.87% <100.00%> (+0.53%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3dafd...1b3cec0. Read the comment docs.


Fix xpu finetune image path

Description

Fix xpu finetune image build action

1. Why the change?

2. User API changes

3. Summary of the change

4. How to test?

[ ] N/A
[ ] Unit test
[ ] Application test
[ ] Document test
[ ] ...

5. New dependencies

[ ] New Python dependencies
- Dependency1
- Dependency2
- ...
[ ] New Java/Scala dependencies and their license
- Dependency1 and license1
- Dependency2 and license2
- ...

https://github.com/intel-analytics/ipex-llm/actions/runs/9105562158/job/25031341070


Fix Condition on _CanOutputAppBundle

https://github.com/xamarin/mirepoix/blob/66e35ba095de4f7846167306627fd124b25b78f3/src/Xamarin.Mac.Sdk/Sdk.targets#L5
Instead of Condition="$(_CanOutputAppBundle)" I think it should say Condition="$(_CanOutputAppBundle) != 'false'" or == 'true' depending on which way the default is.
I've seen MSBuild complain today that condition `` was expected to be true or false, but I can't remember where I saw it.

Found it:
C:\Users\Kirill\.nuget\packages\xamarin.mac.sdk\0.12.0\Sdk\Sdk.targets(5,18): error MSB4113: Specified condition "$(_CanOutputAppBundle)" evaluates to "" instead of a boolean. [C:\xmd\main\external\vs-e...ViewImpl.csproj]

Hmm, turns out the problem is when NuGet fails to restore because it was missing a package source then it starts complaining about every little thing like the above.
Once I added the missing package source the above stopped being a problem.
It would still feel cleaner to protect against '' in the condition, but this is no longer blocking anything as far as I can see.

Nope, sorry, it's still a problem.
It wasn't a problem because the package was cached from a successful run.
After I delete the package from the cache this starts being a problem again.


Adding maxdrib to readme as reviewer/maintainer

Issue #, if available:
Description of changes:
Testing performed:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Allow multiple FeatureGates in integration test config

Using a comma separated string containing multiple feature gates in a single string in SuiteSpec (integration test config).

@JoelSpeed PTAL

I think this looks ok generally, but, any idea why it thinks the controlplanemachineset without MachineAPIMigration file now has no CRD to match with?
And, do we have anything we can use to demonstrate that this achieves what we want? Allowing combinations of gates for tests?

I think this looks ok generally, but, any idea why it thinks the controlplanemachineset without MachineAPIMigration file now has no CRD to match with?
And, do we have anything we can use to demonstrate that this achieves what we want? Allowing combinations of gates for tests?

https://github.com/openshift/api/pull/2086/commits/77b2eb581ec428278e131914a6c2b32898cff158 can fix the issue and demonstrate that it works as expected.

/lgtm
/label acknowledge-critical-fixes-only
No effect on the payload for this PR
Thanks @swghosh