[ENHANCEMENT] Polish the dark mode; Overhaul submit form; Fix dark mode skeleton components;

Summary
Fix dark mode skeleton components; Polish the dark mode; Overhaul submit form;
Description

Dark Color Variant:

Introduced dark color variant in Tailwind CSS configuration for unambiguous color assignment.

Light Color Variant:

Added light variant in Tailwind CSS, expanding color choices for enhanced design flexibility.

Blog Form Overhaul:

Revamped blog creation form for accessibility, increased whitespace, refined placeholders, and improved width.

Unified Color Scheme:

Implemented *-slate-* universally, ensuring consistent and hierarchical text colors.

Background Color Adjustment:

Replaced light mode's white background with slate-50 for aesthetic alignment with UI practices.

Homepage Design Improvements:

Enhanced visual hierarchy across homepage sections for optimized user experience.

Text Formatting and Styling:

Converted title case text to sentence case, aligning with Google's writing practices.

Button Interactivity:

Added hover state to Create Post button for improved user feedback.

Skeleton Loading Enhancement:

Optimized post skeleton loading for smoother and visually appealing experience.

Font Configuration:

Integrated Poppins font directly into Tailwind CSS, eliminating arbitrary value classes.

Category Pill Component Updates:

Introduced <CategoryPill /> component, replacing util/category-props.tsx in line with React principles.
Added dark mode support with darker light colors for visibility.
Adjusted CategoryPill colors from bg-*-100 to bg-*-200 for enhanced prominence.
Set CategoryPill font to medium for coherence with Figma design.

Images

Headers
Before

After

Skeletons (Dark)
Before

After

Featured and latest posts (Dark)
Before

After

Featured and latest posts (Light)
Before

After

All blog posts cards (Dark)
Before

After

Create blog form (Dark)
Before

After

Create blog form (Light)
Before

After

Details page (Dark)
Before

After

Details Page (Light)
Before

After

Modal
Before

After

Issue(s) Addressed

Closes #64
Related to #62

Prerequisites

[x] I have followed all the CONTRIBUTING GUIDELINES

@chinmaykunkikar, thank you for this wonderful PR, Hats off to your patience. Now, please spare me some good amount of time to digest all the concepts which are proposed in this PR ;)

@krishnaacharyaa I'll update the description with screenshots and I'll mark this PR ready for review :)

@krishnaacharyaa whenever you're ready :)

@chinmaykunkikar  actually I am also tracking ur all commit.
and same as @krishnaacharyaa https://github.com/krishnaacharyaa/wanderlust/pull/67#issuecomment-1837039569
I am also trying to understand as ur approach as is new to me .

@chinmaykunkikar, I wouldn't hesitate to say it again, Thanks for your patience in writing such a beautiful PR description, I am just in love with that, Google docs which you shared did really help you ;) Looking forward to read the same very soon, and ofcourse all the details that are addressed, really crisp to the point, it just enhances the quality exponentially. Hands down for combining what could be ideally task of potentially 3 to 4 PRs.
Just couple of suggestions/opinions I would like to bring up:
1.

2.

For some reason, I'm not convinced with the alignment, Can we actually get the alignment to the heading as well? I understand people and may be google even suggests this, but I am not big fan of this style personally I feel something is misaligned, Can you kindly convince me in couple of sentences why this would be best for our project, and would there be any harm for us to use the aligned title and description, What's your thoughts on this? Haven't even you felt this? (at this point I am curious)

Can we actually get the alignment to the heading as well?

I didn't get you. Are you saying you don't like the center alignment? Or do you want it to be full screen width?

Can we actually get the alignment to the heading as well?

and would there be any harm for us to use the aligned title and description

@krishnaacharyaa I didn't get you. Are you saying you don't like the center alignment? Or do you want it to be full screen width?

Meaning, Title is forced to the left and the description is centre aligned, I am proposing can we keep it uniform to both, either stretched for both title and description or centre for both.

Updated: As it is not aligned pick img

Hey @SankalpHaritash21, Thank you for your valuable insight, Couple of points to add, @chinmaykunkikar we might have to even work on the padding in the mobile screen (We can go with 16px both the ends in mobile), and the responsive font size as well, similar to home page.

work on the padding in the mobile screen

Jussst changed that locally before this comment lol. I hated that one too.
It actually skipped my mind to test the form on mobile screens. I'm doing some changes in that regards right now.

Title is forced to the left and the description is centre aligned

I see.
2. For the form page, I wanted to keep the arrow to the top left corner and move the "Create blog" along with the form but I didn't touch it because I thought it's a part of the navigation. That one bugged me as well.
So, Do you want me to move the text, keeping the nav arrow in place?

Hmm. for 1, I'll tell you my thought behind shrinking the width, and moving the blog body (description) to the center of the screen.
Limited width - Since blogs are text heavy pages, having longtext lines are not really ideal for reading content. If you start reading a line from one end to the other end of your screen, you'll have to adjust your eyes to go to the next line, essentially breaking your reading flow. There are UX case studies behind it, and you'll also see most text-heavy sites with a limited width, that is (mostly) aligned to the center of the screen, with A LOT of whitespace to the either side of the text.

(Medium has cracked this code long ago)
Not aligning with the heading: It would've been okay to align the text to the start here, but it'd have felt odd seeing a huge whitespace to the right side of the user's screen (because of the shrinking). And I never thought about moving the title to the center with the rest of the text, because I always thought it was disconnected (in terms of style) from the body (description) because of the background image behind the title.
Do you want me to move the title to the center?

didn't touch it because I thought it's a part of the navigation

No its not.

So, Do you want me to move the text, keeping the nav arrow in place?

Yes please.

And I never thought about moving the title to the center with the rest of the text, because I always thought it was disconnected (in terms of style) from the body (description) because of the background image behind the title.

UX part I agree with that, and i have no problem, even i had the same intention initially building the project, because of some PR, it got slipped from me, so we are seeing it stretched. And the above makes sense to me, the disconnection part, I guess we will let it be the way you have done it now, I'm fine with this.

Yes please.

Done.

As it is not aligned pick img

Done.

Hi @chinmaykunkikar @krishnaacharyaa

Can we align  title with detail and @chinmaykunkikar as your choice.
@chinmaykunkikar  Now I came to know about professional pr. I thought u r making doc for wanderlust website. It look like. @chinmaykunkikar can u tell me from where you get such experience. Plz tell me too.

Create Blog post page looks good to me, in terms of responsiveness, the home page looks a bit missed up, if we are not getting engagements from contributors I'll take it up. No worries. Referring to #13

@krishnaacharyaa, I didn't bother much about the homepage responsiveness.
Tomorrow, I'll skim through some code and if I think I can do it without breaking a sweat, I'll push it in this PR itself. Otherwise, please take it up.

@chinmaykunkikar  your code look great and the approach used is good. I approved ur code.
hey @chinmaykunkikar  can u plz add some meta data in index file as It will help in better recognition in google.
updated:

Wanderlust

Perhaps a topic for another PR? :)

hey @chinmaykunkikar  can u plz add some meta data in index file as It will help in better recognition in google.
updated:
  <head>
    <meta charset="UTF-8" />
    <link rel="icon" type="image/svg+xml" href="/vite.svg" />
    <link
      href="https://fonts.googleapis.com/css2?family=Poppins:wght@300;400;500;600;700&display=swap"
      rel="stylesheet"
    />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>Wanderlust</title>
  </head>

Edit: add a code block.

P.S. Please learn to use code blocks when you want to show or refer some code.
For example, in this comment, if I hadn't quoted your reply, I wouldn't have known what you're trying to say.
Because this is what it looked like in your comment before editing:

We'll take this up seperately

Sure

And the title one even we'll do it seperately!

Yes, sure.

If you can just do the Map type of category, that would suffice for now. If you feel it needs some dedicated time we'll take it up later.

I'll do it in this PR itself.

p.s: this has some really nice enhancements, so I'm hurrying to merge this, hope you understand and don't mind 😊

I get you. But... relax, this is the only task that that's pending for this PR. You'll (probably) just have to click on the merge button once I push it.
Once this is kept on hold, it will take forever to get it fixed.

I'll do it tomorrow because I'm traveling today.
oops okay... Take your time.

@chinmaykunkikar just couple of things, pardon me for being very picky and specific.

The arrow has a little padding at the left, can you fix that
And here

Can we have the Title in the same alignment as Back button, that feels reasonable to me, so that it is heading and has some seperation from the form itself


DBZ-5485 Support wait/nowait clause in mariadb

https://issues.redhat.com/browse/DBZ-5485

Same test it failure:
https://github.com/debezium/debezium/pull/3778
2022-08-06T07:04:56.8466097Z [ERROR]   ReadOnlyIncrementalSnapshotIT.lambda$testStopSnapshotKafkaSignal$10:292 expected:<[fals]e> but was:<[tru]e>

Upstream pr: https://github.com/antlr/grammars-v4/pull/2742

Applied to main (=2.0).


H5FDhttp.c build errors with v4.9.1

This build issue is only reproducible with latest v4.9.1, not reproducible with v4.9.1-rc2.
Reproduced on ANL workstations (Ubuntu 20.04, gcc 9.4.0, mpich 3.3.2) with steps below.
[Build and install HDF5 1.14.0]
wget https://support.hdfgroup.org/ftp/HDF5/releases/hdf5-1.14/hdf5-1.14.0/src/hdf5-1.14.0.tar.gz
tar zxf hdf5-1.14.0.tar.gz
cd hdf5-1.14.0
CC=mpicc ./configure --prefix=/path/to/hdf5 --enable-parallel
make -j4
make install

[Build and install NetCDF-C 4.9.1]
wget https://github.com/Unidata/netcdf-c/archive/v4.9.1.tar.gz
tar zxf v4.9.1.tar.gz
cd netcdf-c-4.9.1
CC=mpicc CPPFLAGS="-I/path/to/hdf5/include" LDFLAGS="-L/path/to/hdf5/lib" ./configure --prefix=/path/to/netcdf
make -j4

Build errors:
H5FDhttp.c:166:5: error: initializer element is not computable at load time
...
H5FDhttp.c:172:5: error: incompatible types when initializing type 'enum H5F_close_degree_t' using type 'void *'
  172 |     NULL,                       /* sb_size      */
      |     ^~~~

We have not tested against HDF5 1.14 at all at this point; I recommend using hdf5 1.12.x. I tried building against hdf5 1.14 several weeks ago and ran into other, similar errors that we will take a look at during the next release cycle, after we get the next Fortran and C++ interface libraries released.

It seems like the structure changed between 1.12.2 and 1.14.0. I'm not sure why linux isn't seeing these problems.

1.12.2: https://github.com/HDFGroup/hdf5/blob/hdf5-1_12_2/src/H5FDpublic.h#L270
1.14.0: (develop) https://github.com/HDFGroup/hdf5/blame/develop/src/H5FDdevelop.h#L28

@WardF hdf5-1.14.0 has some really necessary and helpful HPC performance improvments and bug fixes. I strongly recommend that you start testing with it immediately, it's going to be a very popular release.
We are already using 1.14.0 at NOAA and it not only solves some mysterious and annoying MPI bugs, but it's significantly faster.

The workaround for this is to build with --disable-byterange.

The workaround for this is to build with --disable-byterange.

I'm not sure that this is true. The data structure looks very different between 1.12 and 1.14.
aren't the errors but the structure elements are of different data types?

When --disable-byterange is used, this section of code is not compiled, and the rest of netcdf-c will compile and pass tests. That's what I meant by workaround.
Of course, to get byterange working again will require some changes in the code. ;-)

From HDF5 web site (https://portal.hdfgroup.org/display/HDF5/Migrating+from+HDF5+1.12+to+HDF5+1.14):

For details, see the (soon to be released) 1.12 to 1.14. VFL Migration Guide.
For details, see the (soon to be released) 1.12 to 1.14. VOL Migration Guide.

We may have to wait until these documents are released.

What-all would I be giving up by using the --disable-byterange flag?
The description sounds like it's enabling rather then disabling a capability:
--disable-byterange     allow byte-range I/O


Please add support for Node v16.0.0

Currently unable to install the palette in Node-Red docker container, as it is built with Node v16.0.0

I'll test this later. This module might already work with node v16 I just haven't tested it.

Try now. Install version 1.0.5

it works now, thank you for the update!


Extract snapshotting

Move the code used to create snapshots and fingerprints of things (files for now) to its own subproject.

I would just like to make us remember that this build passed:
https://builds.gradle.org/viewLog.html?buildId=16371221

Ready for merge passed for 8af779b, merging now. Please continue review on master.


Map functions not working in Flutter release and profile on web, but are in debug

Steps to Reproduce

Run flutter build web --profile.
Run below function

  static bool isAuthorized(String output) {
    Map<String, dynamic> decoded = tryDecode(output);
    if (decoded.isEmpty) {
      return true;
    } else if (decoded.containsValue("Invalid token.")) {
      return false;
    } else if (decoded.containsKey("detail")) {
      return false;
    } else {
      return true;
    }
  }

(Web profile generated code that throws error)
    API_isAuthorized: function(output) {
      var decoded = E.API_tryDecode(output),
        t1 = J.getInterceptor$asx(decoded);
      if (t1.get$isEmpty(decoded))
        return true;
      if (t1.containsValue$1(decoded, "Invalid token."))
        return false;
      else if (t1.containsKey$1(decoded, "detail"))
        return false;
      else
        return true;
    },

Expected results:
No error
Actual results:
Uncaught TypeError: t1.containsValue$1 is not a function

Logs

Analyzing true_lake...
No issues found! (ran in 5.6s)

[✓] Flutter (Channel stable, 2.2.2, on macOS 11.4 20F71 darwin-x64, locale en-US)
    • Flutter version 2.2.2 at /Users/REDACTED/LocalFrameworks/flutter
    • Framework revision d79295af24 (2 weeks ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/REDACTED/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.23.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.4 20F71 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.114

• No issues found!

It seems to be something with the Map object not containing the functions during release builds, other than that I'm not sure as to what is wrong

Hi @Dall127
I cannot reproduce it in release, profile & debug modes,
The string I've provided doesn't detail hence the value false is working as expected, no error are throwns
Preview

minimal code sample
import 'dart:convert';

import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  static Map<String, dynamic> tryDecode(String text) {
    return jsonDecode(text);
  }

  static bool isAuthorized(String output) {
    Map<String, dynamic> decoded = tryDecode(output);
    if (decoded.isEmpty) {
      return true;
    } else if (decoded.containsValue("Invalid token.")) {
      return false;
    } else if (decoded.containsKey("detail")) {
      return false;
    } else {
      return true;
    }
  }

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      home: Scaffold(
        appBar: AppBar(
          title: Text('Material App Bar'),
        ),
        body: Center(
          child:ElevatedButton(onPressed: (){
            print(isAuthorized('{"detail": "test", "id": 1}'));
          }, child: Text('Decode')),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.2, on macOS 11.4 20F71 darwin-x64, locale en-US)
    • Flutter version 2.2.2 at /Users/tahatesser/Code/flutter_stable
    • Framework revision d79295af24 (3 weeks ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.5, Build version 12E262
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.23.0

[✓] Connected device (4 available)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E            • ios            •
      iOS 14.6
    • iPhone 12 Pro (mobile) • 4819C924-80DB-4DE5-9093-71A234590ABB • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-14-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64     •
      macOS 11.4 20F71 darwin-x64
    • Chrome (web)           • chrome                               • web-javascript •
      Google Chrome 91.0.4472.114

• No issues found!

Here is another part that I noticed in trying to recreate it this morning in the web console
Could not load content for org-dartlang-sdk:///lib/_internal/js_runtime/lib/js_helper.dart (HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME)

Minimal Code Sample
```
class API {
  static bool isAuthorized(String output) {
    Map decoded = tryDecode(output);
    if (decoded.isEmpty) {
      return true;
    } else if (decoded.containsValue("Invalid token.")) {
      return false;
    } else if (decoded.containsKey("detail")) {
      return false;
    } else {
      return true;
    }
  }
 // Example function using isAuthorized
  static Future getPreferences(User user) async {
    final Uri url = Uri.parse(baseUri.toString() + "/api/preferences/");
    if (user.token != null) {
      baseHeader.addAll({"AUTHORIZATION": "Token " + user.token!});
  if (await workingConneciton()) {
    var response = await http.get(url, headers: baseHeader);
    if (isAuthorized(response.body)) {
      Map<String, dynamic> decoded = tryDecode(response.body);
      if (decoded.isNotEmpty) {
        return Preferences.fromMap(decoded);
      }
    } else {
      logout();
    }
  }
}

return null;

}

Expected Results
No error is thrown and the function and returns a boolean
##Actual results
Error is thrown inside web console only on release and profile builds

Hi @Dall127
Since you is not complete (runnable) so I have created complete sample from you snippet, still no issue in any mode

minimal code sample
import 'dart:convert';
import 'package:http/http.dart' as http;
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(
          title: Text('Material App Bar'),
        ),
        body: Center(
          child: Container(
            child: Text('Hello World'),
          ),
        ),
        floatingActionButton: FloatingActionButton(
          child: Icon(Icons.add),
          onPressed: () async => print(
            await API.getTodo(),
          ),
        ));
  }
}

class API {
  static bool isAuthorized(String output) {
    Map<String, dynamic> decoded = tryDecode(output);
    if (decoded.isEmpty) {
      return true;
    } else if (decoded.containsValue("Invalid token.")) {
      return false;
    } else if (decoded.containsKey("completed")) {
      return true;
    } else {
      return true;
    }
  }

  static Map<String, dynamic> tryDecode(var toDecode) {
    try {
      return jsonDecode(toDecode);
    } catch (e) {
      return {};
    }
  }

  // Example function using isAuthorized
  static Future<String?> getTodo() async {
    final Uri url = Uri.parse('https://jsonplaceholder.typicode.com/todos/1');
    var response = await http.get(url);
    if (isAuthorized(response.body)) {
      Map<String, dynamic> decoded = tryDecode(response.body);
      if (decoded.isNotEmpty) {
        return Future.value(decoded.toString());
      }
    }

    return null;
  }
}

Preview

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.2, on Microsoft Windows [Version 10.0.19043.1081], locale en-US)
    • Flutter version 2.2.2 at C:\Users\Taha\Code\flutter_stable
    • Framework revision d79295af24 (3 weeks ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Taha\Code\SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_SDK_ROOT = C:\Users\Taha\Code\SDK
    • Java binary at: C:\Users\Taha\Code\android-studio\jre\bin\java.exe
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[✓] Visual Studio - develop for Windows (Visual Studio Community 2019 16.10.2)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.10.31410.357
    • Windows 10 SDK version 10.0.19041.0

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] IntelliJ IDEA Community Edition (version 2021.1)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2021.1.1
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] VS Code (version 1.57.1)
    • VS Code at C:\Users\Taha\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.23.0

[✓] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19043.1081]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 91.0.4472.114
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 91.0.864.59

! Doctor found issues in 1 category.

Please prvodie complete sample that reprpduces the isuee
Thank you

I was able to reproduce the issue with the minimal (and runnable) code sample below.
##Steps to reproduce:

Modify function to recreate output of a server (provided code for expected login output if helpful)
Run code in profile or release mode and observe

Note:
The expected response of login for recreation purposes: ```{expiry: 2021-07-07T02:59:51.066026Z, token: b765c31440bd4ac1d6bafa49ab21ee3e8bf53c6081a4af0537dfe497bd5dba50}

**Expected Results:**
No Error, successfully print out output of api endpoint

**Actual results:**
![image](https://user-images.githubusercontent.com/31700756/124640353-8679af80-de4a-11eb-923d-768733c595a6.png)

<details>
<summary>Minimal Code Sample</summary>

import 'dart:convert';
import 'package:http/http.dart' as http;
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Material App',
theme: ThemeData.dark(),
home: Home(),
);
}
}
class Home extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text('Material App Bar'),
),
body: Center(
child: Container(
child: Text('Hello World'),
),
),
floatingActionButton: FloatingActionButton(
child: Icon(Icons.add),
onPressed: () async => print(
await API.login("username", "password"),
),
));
}
}
class API {
static Map<String, String> baseHeader = {"content-type": "application/json"};
static Uri baseUri = Uri.parse("http://localhost");
static bool isAuthorized(String output) {
Map<String, dynamic> decoded = tryDecode(output);
if (decoded.isEmpty) {
return true;
} else if (decoded.containsValue("Invalid token.")) {
return false;
} else if (decoded.containsKey("completed")) {
return true;
} else {
return true;
}
}
static Map<String, dynamic> tryDecode(var toDecode) {
try {
return jsonDecode(toDecode);
} catch (e) {
return {};
}
}
static Future login(String username, String password) async {
final Uri url = Uri.parse(baseUri.toString() + "/api/login/");
var data = jsonEncode({"username": username, "password": password});
var response = await http.post(url, headers: baseHeader, body: data);
Map<String, dynamic> json = jsonDecode(response.body);
if (json.containsKey("token")) {
  return getBooks(json["token"]);
} else {
  return null;
}

}
static Future getBooks(String token) async {
final Uri url = Uri.parse(baseUri.toString() + "/api/books/");
baseHeader.addAll({"AUTHORIZATION": "Token " + token});
var response = await http.get(url, headers: baseHeader);
if (isAuthorized(response.body)) {
return Future.value(response.body);
} else {
return null;
}
}
}

</details>

Upon Further inspection:
when running in different modes, the runtime return type of jsonDecode varies when given different responses  varies. The isAuthorized function was only designed to handle Maps, not Lists and Maps, and thus was the main cause on my part.
However, I think that the consistency between debug and profile modes in terms of how they handle runtime types is a bug, or at least should be a heavily documented phenomena and something to be on the radar when developing for flutter web.
In debug, the type is:
IdentityMap<String, dynamic>
yet in release and profile, it is
JSArray<dynamic>
thus causing map functions to not be accessible in the later two compilation modes.

Hi @Dall127
Thanks for the details, for issues related to jsonDecodate, please file an issue on Dart's repository as dart:convert is not part of Flutter.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you


About Pretrained model

Thanks for your sharing.
I tried to train your code, but I found that there is no pretrained G

I have download your pretrained model in setup files, the contents are as follows

In your google drive, it has four files

But there is no stylegan_G_256x256_synthesis file.
I only used stylegan model in pytorch, I want to know if I made a mistake.

I found the same problem. Have you solved it and how?

same problem

Hi @xuedue
Could you please share the google drive link here that you are mentioning. I couldn't get these files at all as you metioned in this screenshot

The model stylegan_G_256x256_synthesis is loaded from those data files with the similar name.
From the screenshot of the pre-trained models you attached @xuedue, maybe you're missing one of the data files? I see only 1 out of 2.
If that doesn't help solve the issue - perhaps it is caused by version incompatability of some packges?
Are you working with our exact environment?


Update kubeone-e2e image to Go 1.15

What this PR does / why we need it:
Update the kubeone-e2e image to Go 1.15. Once the image is pushed, I'll update the remaining jobs to use it. This PR also updates the Kubernetes test binaries to the latest versions.
Does this PR introduce a user-facing change?:
NONE

/assign @kron4eg

/hold
/lgtm cancel
I forgot to bump the image version

@kron4eg PTAL again
/hold cancel

@kron4eg Tests fixed, PTAL

/cherry-pick release/v1.0


Create a POST route and save data to NFS

[x] Rename response_handler, since they will be responsible for more than responses
[x] Set up POST route
[x] Save the request data in file system
[x] Return json as success

[ ] More robust error handling for empty fields
[ ] Make sure the request has the right application type?


Add argument that enables large models to compile

What does this PR do?
If you try and load a very large model (in my case it was T5-XL), then you run into the following error from protobuf
onnx.ModelProto exceeded maximum protobuf size of 2GB

This PR adds an additional argument to optimum.graphcore.IPUConfig() that allows this error to be circumvented.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


triton sync

hi，I want to test the performance of the function developed using triton.
Do I need to add sync operation?
If necessary, how to add sync? Should we call the torch.cuda.synchronize() function?
like
test_kernel[grid](x, y, output, width, height)
torch.cuda.synchronize()?

Yes triton kernels run asynchronously on the cuda device and torch.cuda.synchronize() will work if you want to measure from the CPU. A gpu-specific profiler like nsight-sys would be better though.


Fix crash when k4a_device_open fails

When k4a_device_open fails, the _cameraFrames array was never initialized, so the Unity Editor crashes in the UpdateSRVs method. When an early-return is added there it just crashes in the destructor of AzureKinectCameraFrame where it is not as easy to add such an early-return.
Instead I moved the initialization of the array so it is always initialized, with this I could not reproduce this crash.

Thanks for this fix!


[Bug]: -r flag no longer required in install.sh, still referenced in README.md

Commit Hash
a80fdcd19ec8a09245108a8341d1bce684fde8ac
Steps to Reproduce?
sudo ./install.sh -p /home/asm-data/anaconda3/envs/asm_dep/bin/python -r /home/asm-data/anaconda3/envs/asm_dep/bin/runServer.py
Observed Behavior
(asm_dep) asm-data@e4e-brix:~/ASM-data-server$ sudo ./install.sh -p /home/asm-data/anaconda3/envs/asm_dep/bin/python -r /home/asm-data/anaconda3/envs/asm_dep/bin/runServer.py
[sudo] password for asm-data:
./install.sh usage:
    -d            Specify debug
    -p python     Specify python interpreter
    -r runServer  Specify runServer.py location
    -h            Display this message
WARNING: The directory '/home/asm-data/.cache/pip' or its parent directory is not owned or is not writable by the current user. The cache has been disabled. Check the permissions and owner of that directory. If executing pip with sudo, you may want sudo's -H flag.
Processing /home/asm-data/ASM-data-server
Requirement already satisfied: PyYAML in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from ASM-DataServer==<IP_ADDRESS>) (5.4.1)
Requirement already satisfied: asm_protocol in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from ASM-DataServer==<IP_ADDRESS>) (<IP_ADDRESS>)
Requirement already satisfied: appdirs in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from ASM-DataServer==<IP_ADDRESS>) (1.4.4)
Requirement already satisfied: pytest in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from ASM-DataServer==<IP_ADDRESS>) (6.2.5)
Requirement already satisfied: AsmCommon in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from ASM-DataServer==<IP_ADDRESS>) (<IP_ADDRESS>)
Requirement already satisfied: numpy in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from asm_protocol->ASM-DataServer==<IP_ADDRESS>) (1.21.2)
Requirement already satisfied: attrs>=19.2.0 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==<IP_ADDRESS>) (21.4.0)
Requirement already satisfied: importlib-metadata>=0.12 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==<IP_ADDRESS>) (4.8.1)
Requirement already satisfied: toml in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==<IP_ADDRESS>) (0.10.2)
Requirement already satisfied: pluggy<2.0,>=0.12 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==<IP_ADDRESS>) (1.0.0)
Requirement already satisfied: iniconfig in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==<IP_ADDRESS>) (1.1.1)
Requirement already satisfied: packaging in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==<IP_ADDRESS>) (21.3)
Requirement already satisfied: py>=1.8.2 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from pytest->ASM-DataServer==<IP_ADDRESS>) (1.11.0)
Requirement already satisfied: typing-extensions>=3.6.4 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from importlib-metadata>=0.12->pytest->ASM-DataServer==<IP_ADDRESS>) (<IP_ADDRESS>)
Requirement already satisfied: zipp>=0.5 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from importlib-metadata>=0.12->pytest->ASM-DataServer==<IP_ADDRESS>) (3.6.0)
Requirement already satisfied: pyparsing!=3.0.5,>=2.0.2 in /home/asm-data/anaconda3/envs/asm_dep/lib/python3.7/site-packages (from packaging->pytest->ASM-DataServer==<IP_ADDRESS>) (3.0.6)
Building wheels for collected packages: ASM-DataServer
  Building wheel for ASM-DataServer (setup.py) ... done
  Created wheel for ASM-DataServer: filename=ASM_DataServer-<IP_ADDRESS>-py3-none-any.whl size=9867 sha256=8d60bd223918f5c1d1be212ed855a1fa0379d74a3f1fe23ea21197b5725f50c1
  Stored in directory: /tmp/pip-ephem-wheel-cache-9w_h1mdq/wheels/0b/48/30/ba718ef2f33d9ad83982bcada1a3364b36b67f14796b4fd8c2
Successfully built ASM-DataServer
Installing collected packages: ASM-DataServer
  Attempting uninstall: ASM-DataServer
    Found existing installation: ASM-DataServer <IP_ADDRESS>
    Uninstalling ASM-DataServer-<IP_ADDRESS>:
      Successfully uninstalled ASM-DataServer-<IP_ADDRESS>
Successfully installed ASM-DataServer-<IP_ADDRESS>
cp: cannot create regular file '/usr/local/etc/ASMDataServer/asm_config.yaml': No such file or directory
Created symlink /etc/systemd/system/multi-user.target.wants/asm_server.service → /lib/systemd/system/asm_server.service.
(asm_dep) asm-data@e4e-brix:~/ASM-data-server$

Desired Behavior
No usage message, no cp failure
Component
Server
Relevant Sensor Node log output
No response
Relevant Sensor Node configuration
No response
Relevant Server log output
No response
Relevant Server configuration
No response

Note that this also failed to create /usr/local/etc/ASMDataServer

Recommend changing install procedure to use setup.py.


Crash after  starting SDK generation

The “SDK generation has started, do not close the game until prompted to do so!” window pops after injecting DLL, but crashes soon after pressing ok.
The only things that show up in the log file are:
Entry Point
GObjects
GNames
Game in question is Batman Arkham Asylum

Your classes are wrong


Add test for redirects without trailing slash being redirected in one go

The normalisation logic in RedirectMiddleware ensures that a redirect from /foo to /bar is picked up when the incoming URL is either /foo or /foo/. However, if CommonMiddleware's "add trailing slash" logic activates first, this will result in a double redirect, from /foo to /foo/ and then to /bar. Double redirects are undesirable as they cause the site to be penalised in Google search rankings.
This was the case prior to Django 4.2 - as CommonMiddleware performed the trailing slash test in the initial "process request" phase - and was fixed in https://github.com/django/django/commit/fbac2a4dd846b52c4f379eacb5bab654fe9540cc.
This PR adds a test to confirm that an incoming request without the trailing slash is handled in a single redirect, so that we'll be made aware if this regression returns.

@RealOrangeOne Good plan. Updated and merged in 5bc9731616efdd3452dd0749362ac085faa46419.


Return value of wtr_watcher_close in watcher-c

When I'm running the following code with watcher-c;
void * watcher = wtr_watcher_open(path, handle_event, (void *)data);
bool success = wtr_watcher_close(watcher);

success always is false when closing the watcher, even if the watcher started successfully.
From the the testfile I was under the impression that it should return true if stopping is successful.
Is thig a bug or is the behaviour expected?

   74 bool wtr_watcher_close(void* watcher)
   75 {
   76   if (! watcher) return false;
   77   if (! ((wtr::watcher::watch*)watcher)->close()) return false;
   78   delete (wtr::watcher::watch*)watcher;
   79   return true;
   80 }

Either the watcher is null or the underlying implementation couldn't close the OS's resources, which is problematic.
Do we have a minimally reproducible example?

I think https://github.com/e-dant/watcher/commit/343e6b5975036d43a3cadc2eaf813584c2b58f3c might fix this, but I'm not sure yet.
There might be some double-close logic (which that pending check was meant to guard against), but there might have also been a case where the semaphore skips right through the pending state into the released state, which that commit should also address.
LMK if this fixes the issue for you.

This didn't really seem to fix the issue. I'll try to create a minimal reproducer when I have time.
It's not that critical for us since we usually stop the whole process after stopping the watcher.

I think this is worth investigation.
If we're failing to close resources under any circumstances, that's a problem.
I think a minimal reproducer would be enlightening -- Particularly, I'm curious if there's a bad interaction in the Go<->cgo<->C language chain, or if this is a library bug.

I create a minimal reproducer here: https://github.com/AlliBalliBaba/watcher-debug
With docker you can just clone the repo and do something like:
docker build -t debug-watcher .
docker run debug-watcher

The code that opens and closes the watcher is in watcher-test.c

I created a minimal reproducer here: https://github.com/AlliBalliBaba/watcher-debug

The watcher here is being closed before it has a chance to finish opening all the resources it needs.
The thread running the watcher doesn't usually start in this example until control has reached the close() call.

We could probably handle this better, but we're not leaking anything here.

With some extra logging, we can trace what's happening:

close/1/1727620570393 closing watcher
close/1/1727620570393 releasing semaphore
close/1/1727620570393 waiting for watcher
open/1/1727620570393 watching /go/src/app
open/1/1727620570393 e/self/live@/go/src/app
event:
  path name: e/self/live@/go/src/app
  path type: 4
open/1/1727620570393 done watching /go/src/app
open/1/1727620570393 e/self/die@/go/src/app
event:
  path name: e/self/die@/go/src/app
  path type: 4
open/1/1727620570393 watcher closed, ok? no
failure

Format is routine/nth call to it/time of message (etc)
Note that the event handler here receives a "special" path and path type:

event:
  path name: e/self/live@/go/src/app
  path type: 4

The e/ prefix here means "error". (s/ would mean "success".)
This communication mechanism is detailed here in the The Library/readme

The watcher type is special.
Events with this type will include messages from the watcher. You may recieve error messages or important status updates, such as when it first becomes alive and when it dies.
The last event will always be a destroy event from the watcher.

However, I'm not sure this fully addresses the issue.
While, in this example, the issue could be solved by waiting for that self/live message (with the special "watcher" path type), I believe you were also seeing errors on close in a more long-running context.
I think we should explore that more.
Thoughts?

Ah yeah that makes sense. I was seeing the error sometimes in tests, probably because the tests would finish before the watcher could start.
I tested it again and with a bigger grace period before shutdown and it works properly 👍.
I guess I'm fine with the current behavior then. It could maybe be documented somewhere that wtr_watcher_close will return false (but still stop the watcher) if the watcher hasn't sent the e/self/live@ event yet

Re:

I guess I'm fine with the current behavior then. It could maybe be documented somewhere that wtr_watcher_close will return false (but still stop the watcher) if the watcher hasn't sent the e/self/live@ event yet

I added some more documentation in https://github.com/e-dant/watcher/commit/fb9c5254f54726160dbe5a408cd6f2fae2cb8b4f

Documentation is a journey, though, so I'd like your take on that commit (and the readme generally). Anything that should the clarified/reorganized/added/etc?

Yeah looks good, haven't noticed anything else that needs documenting so far 👍


Docs: container-environment.md should link to or include downward_api.md

container-environment.md should link to, or possibly be merged with downward_api.md. These are both applicable to someone getting started and or porting an app to kubernetes, who need to figure out what metadata is available from the environment.

cc @pmorie

#10130 (related to downward API)

cc @thockin, since he's working on #10130

@jeffmendoza Good suggestion -- apologies for the latency, it has been a crazy summer and I'm still digging out.

@jeffmendoza I made an initial mention of this in #12056, PTAL

Nice!

Looks like it's merged, closing


k8s: CEP GC runs in steps

On large clusters the CEP GC would fetch the entire list of CEPs. These
can grow to significant sizes (100kB in one instance) and this causes
extreme degradation in kube-apiserver. We now iterate 10 CEPs at a
time, thus lowering the load we put on the cluster.
I also return the cache.Store object from our k8s helper factories. No functionality has changed there.
I began by trying to watch for CEPs in the controller but the code became a little complex. This was partly because only the node that should do GC needs to watch for CEPs, but that meant creating a non-shared informer (shared informers cannot stop once they begin watching for a specific type). In the end, limiting the list to a small number seemed like a reasonable compromise, especially since the GC isn't a critical operation here.
Relates to: https://github.com/cilium/cilium/issues/5913

This change is

test-me-please

test-me-please

test-me-please

@raybejjani do you have any benchmarks from manual testing that you can post here to validate the fix?

@ianvernon I added 10k CEPs, all would be GCed. That took 12
The no-op GC took
Oct 25 13:54:30 k8s1 cilium-agent[29443]: level=info msg="Time taken 48.722672ms" controller="sync-to-k8s-ciliumendpoint-gc (k8s1)" subsys=endpoint

The real one took
Oct 25 14:14:14 k8s1 cilium-agent[32403]: level=info msg="Time taken 6m33.807662252s" controller="sync-to-k8s-ciliumendpoint-gc (k8s1)" endpointID=0 k8sPodName=default/xwing-2316 subsys=endpoint

I'll run this again with no fetch limit... I'll be a few minutes

Ok, maybe not... I stopped the agent and the count stopped dropping. I think another GC run had started... although that shouldn't have happened (the interval is 30 minutes)

Ok, I finally ran with different limit values. It doesn't seem to make a difference:

No-op reference. Time taken 1.043820863s, CEPs: 0
Limit 10. Time taken 4m4.20950814s, CEPs: 1000
Limit 25. Time taken 4m4.236100466s, CEPs: 1000
Limit 50. Time taken 4m4.291099082s, CEPs: 1000
No limit. Time taken 4m4.207404591s, CEPs: 1000

Coverage decreased (-0.01%) to 42.811% when pulling 7b9380a508f1cd81c0af5c7cfa8e1726e15c92fb on raybejjani:cep-smaller-gc into 33a43bea3c38da85eb4441662970b5772ff8393e on cilium:master.

test-me-please

if this patch merge to 1.2 version

@WingkaiHo I'm assuming you ran into scale issues with CEP. We recommend upgrading to 1.4 to use CEP at scale. Upgrading this commit only will not be sufficient to resolve all scale issues present in 1.2 and 1.3.


Hello, I would like to know how to query transactions through message hash, as I couldn't find it in the code.

Not sure that I got your question.
Can you explain your use case? are you trying to find a transaction in a block by msg hash?

"github.com/tonkeeper/tonapi-go"
GetBlockchainTransactionByMessageHash
This can get one hash.
then:
https://testnet.tonapi.io/v2/blockchain/messages/b0d50cba04aa176523d7314f14d61e89f2c42c74e19889743e9be31e66032a66/transaction
https://testnet.tonapi.io/v2/blockchain/transactions/8bbb1d9b8ebe77d57792d13e35f36a361d633735e948aa170e1fa804cbdbccb5
request result are same.

Ok. This is example how you can find transaction by message hash. And what is your question?

چگونه دست رسی به توکن های بلاک شده


http: processing of headers with underscores in names

add config option to either allow, drop header or reject request
applies to client request headers only

Risk Level: Low (default behavior unchanged)
Testing: Unit+Integration Tests
Docs Changes: Yes
Release Notes: Yes
Signed-off-by: Yan Avlasov<EMAIL_ADDRESS>

Oops compile error looks legit.
/wait

/azp run envoy-presubmit

clang-tidy error seems to be bogus. It looks like include search directories may be not set correctly.
https://dev.azure.com/cncf/envoy/_build/results?buildId=36689&view=logs&j=3bf5ec37-bb6f-5fb6-2cf1-5134dc6106d6&t=41d571fe-3811-578d-07de-68468f467dae&l=1570

@yanavlasov can you make sure that the bazel deps are correct for that target? Sometimes there are issues with that. Also can you merge master and open the follow up issue re: unification and QUIC? Thank you!
/wait

Will do. Header validation issue: #10646

I will go ahead and merge this as we need to do a full master pass over clang-tidy anyway. Thank you!

/backport

@mattklein123 @yanavlasov @lizan any thoughts on whether we should backport this to stable branches or not?

@PiotrSikora I would defer to you. Given that we ultimately agreed with your original assessment that it is a feature request, I think it makes sense either way.


riscv/riscv_addrenv.c: Allocate heap for default task stacksize

1 page might not be enough, if the task has a bigger stack. Best effort is to allocate the default amount, however this won't work will all tasks either.

In upstream already, closing


DropConnect Layer

This page claims that TOP accuracy on MNIST is achieved using DropConnect (the link to the paper is broken, original paper is here).
I was searching over stackoverflow and other sites, but didn't find the DropConnect implementation. Regarding other frameworks, there is some workaround for tensoflow here.
Would it be good to implement this?
Regards,
Emil

The tensorflow workaround you gave is to call dropout on the weight layer and then multiply by the probability for the dropout layer to undo the weight change. This should work in MXNet and other frameworks as well


Move pyasmjit to a separate project/repo

Hi,
Is it possible to move pyasmjit to a separate project/repo outside of the barf-project repo? I am interested in experimenting with pyasmjit as a stand-alone library (i.e. without the entire barf dependency) and extending its functionality. Having pyasmjist exist as a separate entity would greatly simplify this.
Many thanks.
Regards,
Adrian

Hi!
Yes, it is possible to make a separate repo for PyAsmJIT. I haven't done it so far because, currently, the only use I gave it was for BARF. However, I think it can be an interesting project on its own.
A couple of questions:

Just out of curiosity, what are you using it for?
What functionalities are you planning to implement? I love pull requests :)

Cheers!
Christian

Hi Christian,
Yes, I think it can be a very cool project on its own. And separating it out also allows it to be pip installable, etc.

I really just want to use it as a tool where I can extract fragments of code from an application and experiment with these fragments by varying the inputs and reasoning about the code
I'm currently looking at implementing a lot of the missing functionality that has already been flagged - support for 32-bit X86, allowing access to memory, etc.. You will probably start getting a large number of pull requests from me very soon :-)

Regards,
Adrian

Hi Adrian,
It would be great to have those functionalities implemented and, also, make it pip installable!
So, I will move it to its own repo. Most probably I will get it done by Monday. I let
you known when its done.
Cheers,
Christian

Well, I finally did it! You can clone it from: https://github.com/programa-stic/pyasmjit
I have to clean up the barf-project repo now but it shouldn't affect you.

Thanks Christian!


Convert to monorepo

Convert the repo to a monorepo like Babel and use the lerna tool to help manage publishing of each of the modules.

i might take this if @helfer agrees with me on #124.

@DxCx so the expectation with this enhancement is to create separate npm modules for core, express, hapi and koa.  As a result, I would expect issue #124 will no longer be an issue or am I missing something?

yes, as a result of that #124 is not needed because apollo-server will have flavors.
different won't mix the typings.

@DxCx: it's all yours!


No error  shown on Group Creation with Chronos

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click on FAB
Click "New Group"
Add Chronos as the member and click on Create Group
No feedback/error message

Expected Result:

Chronos shouldn't be visible in the Group list
Or show an error when the server sends this 401 Chronos is not permitted to participate in group chats

Actual Result:
https://user-images.githubusercontent.com/3069065/128581813-a9112bc9-3360-4ed7-af85-630944398a5e.mp4
Workaround:
Don't choose Chronos while creating a new Group
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork

Triggered auto assignment to @bfitzexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

Proposal
Don't show Chronos while adding to New Group

getNewChatOptions defined in OptionsListUtils.js is being used to get participants in New group. It has a flag to ignoreConceirgeEmails and we can extend it to ignore Chronos email too. Because concerige is allowed in the group chat the config param would look like

function getNewChatOptions( reports, personalDetails, searchValue = '', excludeConcierge, excludeChronos, betas) {

or

function getNewChatOptions( reports, personalDetails, searchValue = '', { excludeConcierge: false, excludeChronos:true }, betas) {

Accordingly update getOptions, where we can just add another flag, excludeChronos = false and add the following check
if (excludeChronos) {
loginOptionsToExclude.push({login: CONST.EMAIL.CHRONOS});
}

Update references so that Chronos is not visible in the partiicpant search list.

API Error message
In addition to handling on the frontend, I feel we should also handle and show API error on the frontend.
At present there's no catch block and hence API errors are not caught.
In libs/actions/Report.js
fetchOrCreateChatReport(participants, shouldNavigate = true)

	...

	return API.CreateChatReport({

	}).then(() => {
		// Existing function
	}).catch(err => {
	let errorMessage =
		switch(err.satatusCode) {
			mesage = .....
		}
		return throw new Error(translate(message))
	});
}

Then in NewGrouPage
	fetchOrCreateChatReport(...).then(...).catch(err => {
		Growl(err.message) // Error message to com here

	})

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

Thanks for the bug report @mananjadhav! @MitchExpensify or @deetergp any ideas on whether we should go with solution one or two? I think both proposals look good, let's just decide what we want to do in this case and then hire @mananjadhav

I've added option 2 for Split Money. I would suggest let's use that so that it is generic across.

Let's go with option 1, since it follows the precedent that excludeConcierge has already set.

@deetergp We'll have other email addresses too in this section such as<EMAIL_ADDRESS>Internally if you see the getOptions function it takes an object only with flags. What do you think?

Hmm, that's a fair point. We employ a number of service accounts like, receipts@, that could be problematic. I need to think on it a bit…

Agreed and hence we've gone ahead with
function getNewChatOptions(
    reports,
    personalDetails,
    searchValue = '',
    excludeOptions,
    betas,
)

where
excludeOptions = {
	excludeConcierge,
	excludeChronos,
	excludeReceipts
}

@AndrewGable, @MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

Still discussing solution.

Why would we ever need to pass excludeChronos: false? If we don't want to exclude something, we just shouldn't pass it.
How about this, rather than having a bunch of individual if (exclude…) {} checks, we pass an array of the logins we want to exclude
excludeLogins = [
	CONST.EMAIL.CONCIERGE,
	CONST.EMAIL.CHRONOS,
	etc…,
];

Then iterate over it in OptionsListUtils.js. Does that make sense?

I had proposed a similar solution for one of the issues earlier but it seemed we weren't sure if we would have multiple automated accounts.
Tell me one thing, are we going to have all automated accounts disabled at all places except New Chat? If yes then a single flag, say excludeAutomatedAccounts will suffice, and then in the common function OptionsListUtils we can iterate.
If we're going to have different use-cases then the above solution works aptly.

Tell me one thing, are we going to have all automated accounts disabled at all places except New Chat?

That is an interesting question! Concierge is currently a member of group chats in our old Expensify, in-app support tool, and I would assume that eventually it will be a part of group chats in NewDot. Conversely, Chronos has never been a group participant and there is nothing on the roadmap that would change that. Currently, there is no reason for anyone to chat with receipts@ in any context, but I could see allowing users to DM receipt attachments to it at some point.
The tl;dr is lets allow the ability to pass the individual accounts for now, rather than grouping all the automated accounts together.

Thanks for the detailed answer. Yeah, then it makes sense to send individual accounts.

@deetergp Are we good to take this ahead?

Ultimately, it's @AndrewGable's call, but I'm all for moving forward with the proposal that includes individual accounts.

Agreed! @MitchExpensify can you configure this via Upwork? Thanks.

Which issue should we run with for this? Here is the same https://github.com/Expensify/App/issues/4646#issuecomment-901500419

PR submitted for the issue linked above. Closing this

@MitchExpensify These two are separate issues. This one is about adding system users to groups and chats, whereas that was related to workspaces.

ah I see, thanks @mananjadhav! Creating the job in Upwork now

Upwork job

@AndrewGable Huh... This is 4 days overdue. Who can take care of this?

@mananjadhav - Did you want to work on this issue? Did you submit a proposal via Upwork?

@AndrewGable I think this is about to be fixed here.

Nice! Then go away @MelvinBot! We have someone on it!

@AndrewGable Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @deetergp in version: 1.0.95-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @roryabraham in version: 1.0.96-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@MitchExpensify is this payment as well on hold due to n6?

Payment is not on hold, thanks for the bump @mananjadhav. One clarification before I do, did you report the original issue?

That’s right. I had reported this issue.


fix: misuse of env KUSION_PATH

What type of PR is this?
/kind bug
What this PR does / why we need it:
Use the value of env KUSION_HOME instead of KUSION_PATH as the path to store kusion data, cause the former is $HOME/.kusion and the latter is $HOME/.kusion/bin. This change happens when changing the catalog of kusion package.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 74.655%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
7293

Relevant Lines:
9769

💛  - Coveralls


New copyright header - remaining changes

This updates the IntelliJ IDEA settings. New files will now have the current Vavr header.
We re-added the new-years copyright update script.

Codecov Report

Merging #2089 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2089   +/-   ##
=========================================
  Coverage     97.49%   97.49%
  Complexity     5188     5188
=========================================
  Files            92       92
  Lines         11928    11928
  Branches       1575     1575
=========================================
  Hits          11629    11629
  Misses          149      149
  Partials        150      150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d304e6...6af2e54. Read the comment docs.


Add npm replacement for $(document).ready

Non one-liner replacement for one-liner jquery is not such nice and isn't what people are actually looking for. I think giving examples using npm modules is more practical in that cases.

We prefer vanilla javascript for it's pure and standard

If you really are only needing the handler for the ready event, you could just do the addeventlistener part, which would still be a oneliner...


Update AMP mkl lists

Improves performance for many models by ~15-20%
Moving Mean from Deny to Infer list because the Mean functor does accumulation in FP32.
Also, adding Rsqrt, SquaredDifference and Mean will help fusion the LayerNorm sub-graph.
Adding ResizeBilinear to Clear list as it helps reduce the incoming Casts and improve performance

Thanks @penpornk
@nSircombe  @milpuz01 : can you please help me with which test fails in remapper_test_cpu?

@elfringham Thank you very much for checking! I'll pull this PR in then.

Thanks @elfringham  and @penpornk for checking.


Failed to minify the code from this file: ./node_modules/react-s3/lib/ReactS3.js:6

I use CRA and when trying to create a build file receive the next error:
Failed to minify the code from this file:
./node_modules/react-s3/lib/ReactS3.js:6
Read more here: http://bit.ly/2tRViJ9
According to the given link it's problem that the library is published not production ready.  How it can be fixed?
Thank you in advance for answer

Can you install the latest version v1.5.0 ?

It looks like 1.3.1 is the latest that has been pushed to npm.

@BrackCarmony use npm install --save aws-s3instead

+1 same issue, using aws-s3 v1.5

Same problem here. Does anyone know how to fix or bypass this?

@guizero You can clone his clone his repo, and copy over his source code into your own project.
I cloned his repo, copied contents of the src directory to my own components/aws-s3 folder, and referenced it like I would any other component:

create a 'aws-s3' folder wherever your components live

git clone https://github.com/Fausto95/aws-s3
mv aws-s3/src/* <PATH TO COMPONENTS FOLDER>/aws-s3

Then, in your code:
import S3Client from './components/aws-s3'
<now use library like normal>

Hey @gatesyp ! I'll try that. So basically what is outside node_modules won't be minified, right?

@guizero If I remember correctly, everything will be minified during the build process.
If the stuff inside node_modules was written with ES6, it will only get minified if they provide an ES5 configuration to transpile the code to ES5 first, and then the build process minifies it.
All stuff outside node_modules will be automatically transpiled to ES5 and minified.
The reason they don't do automatic conversion of ES6 libraries to ES5 is because it could lengthen the build process significantly in some cases, so for now they leave it up to the programmer.
SO, the error with this library is that it does not properly convert the code to ES5 (probably a misconfiguration). If we include the library as our own application code, then the build process will automatically convert + minify it.
Hope that makes sense! I spent a decent amount of time looking into the problem, and this is how I understood it

That makes total sense @gatesyp . Thanks for that. I give you a feedback whenever I try your solution =)

@guizero sounds good!

Hi guys, @matveychuk @BrackCarmony @Evert-jvv @gatesyp @guizero I just published a new version with bug fixes.
If you install the last version(1.5.5) everything should be working correctly :)
npm i aws-s3
Feel to give any feedback and thank you guys for filling the issue!

It worked @Fausto95 ! Thanks


Do not build binaries for test-unit

Speed up make test-unit by no longer building binaries.
Before:
→ time make test-unit
...
real    6m45.337s
user    0m0.559s
sys     0m0.864s

After:
→ time make test-unit
...
real    1m47.899s
user    0m0.257s
sys     0m0.318s

/ok-to-test

/lgtm
/approve


Invalid src and dst IPs when RTT is enabled for gRPC traffic

Here is an example of invalid IPs for gRPC traffic
ipv4: 13:59:40.537606 eth0 IP <IP_ADDRESS>:32888 > <IP_ADDRESS>:8525: dscp: 0x14 protocol:tcp type: 0 code: 0 dir:0 bytes:32 packets:1 flags:16 ends: 13:59:40.537606 dnsId: 0 dnsFlags: 0x0000 dnsLatency(ms): 0 rtt(ns) 9899000 DropPkts: 0 DropBytes: 0 DropCause 0 ipv4: 13:59:37.698857 eth1 IP <IP_ADDRESS>:54928 > <IP_ADDRESS>:8525: dscp: 0x14 protocol:tcp type: 0 code: 0 dir:0 bytes:32 packets:1 flags:16 ends: 13:59:37.698857 dnsId: 0 dnsFlags: 0x0000 dnsLatency(ms): 0 rtt(ns) 2717000 DropPkts: 0 DropBytes: 0 DropCause 0
you can see that the last 2 octets are the same. The IPs should be 10.9.x.x. Here is an example of non-gRPC traffic where IPs are correct
ipv4: 14:08:42.804832 eth1 IP <IP_ADDRESS>:3000 > <IP_ADDRESS>:39946: dscp: 0x0 protocol:tcp type: 0 code: 0 dir:0 bytes:66 packets:1 flags:16 ends: 14:08:42.804832 dnsId: 0 dnsFlags: 0x0000 dnsLatency(ms): 0 rtt(ns) 10000 DropPkts: 0 DropBytes: 0 DropCause 0 ipv4: 14:08:42.804849 eth1 IP <IP_ADDRESS>:3000 > <IP_ADDRESS>:37434: dscp: 0x0 protocol:tcp type: 0 code: 0 dir:0 bytes:66 packets:1 flags:16 ends: 14:08:42.804849 dnsId: 0 dnsFlags: 0x0000 dnsLatency(ms): 0 rtt(ns) 10000 DropPkts: 0 DropBytes: 0 DropCause 0
kernel version: 5.15.0-112-generic
tested version: build from main branch and 1.6.1-community
This happens only when ENABLE_RTT=true and only for gRPC traffic. IPs for other traffic look ok also if RTT is disabled IPs for gRPC traffic look ok.

Hi @matijavizintin
Thanks for opening this issue, I would like to have more details, u said u were testing with gPRC but I don't see port 443 anywhere in ur traces.
can tell me what is <IP_ADDRESS> ip address of and same for the good ips 10.9.x.x
if you can share a way to reproduce this I can look at it more
I assume u are running the agent locally in ur machince into in k8s cluster right ?

In this case we have 2 go apps talking to each other via gRPC on port 8525. Each app sits on it's own (well, hundreds of them) physical machine. So no k8s in this case.
In this example <IP_ADDRESS> is the machine with gRPC client and <IP_ADDRESS> is the machine with gRPC server.
<IP_ADDRESS> and <IP_ADDRESS> are invalid ips. They don't exist in our DC and the app doesn't communicate directly with the internet.
Here is what I'm running:
on the machine running a go app:
METRICS_ENABLE=true CACHE_ACTIVE_TIMEOUT=15s CACHE_MAX_FLOWS=200000 LOG_LEVEL=debug ENABLE_DNS_TRACKING=true ENABLE_RTT=true TARGET_HOST=<IP_ADDRESS> TARGET_PORT=9999 ./netobserv-ebpf-agent-main (this is built from main branch, also tried with version 1.6.1)
on another machine collecting the data:
./bin/flowlogs-dump-collector -listen_port=9999 2>&1 | grep 8525
and then send some gRPC traffic to that machine and that should be it.
For other "normal" http calls (see example on port 3000) it works well and also this happens only when RTT is enabled. It looks like the IPs get messed up somehow.

Hey,
While the purpose of #286 is not to fix this issue, I'm wondering if it would change anything, since it's changing how the headers are read for RTT extraction... Will be good to check


[BUG] Backing images stuck in 'unknown' state and volume not attaching to node

Describe the bug
Some of my BackingImages are stuck in an 'unknown' state. This seems to cause the existing volumes utilizing the same backing image to get stuck in trying to attach to node.
I noticed that this issue can be bypassed by creating a clone of the failing backing image (using the same url), which ends up in 'ready' state. After creating a new volume using it, longhorn is successfully able to attach the volume. Because of this workaround, I'm suspecting that the state of the BackingImage won't get updated from 'unknown' to 'ready' as the backing images already exist.
To Reproduce
These are the steps I did before the issue arise:

Shutdown single node Harvester server
Install new extra hard drive
Start the server
Add new extra disk through Harvester UI to the Harvester node
Notice that existing VMs are stuck in 'starting' state, even though their configuration hasn't changed.
Notice that the harvester's internal longhorn has volumes stuck in 'attaching' state
Notice logs posted above being repeated in longhorn-manager logs

Expected behavior
Longhorn volumes won't get stuck in attaching nor leave BackingImages in 'unknown' state.
Log or Support bundle
Longhorn manager logs that keep repeating:
time="2022-07-14T18:16:41Z" level=debug msg="Prepare to create instance pvc-88dfbca2-a40e-4d2d-b0c4-6720fdcfd64d-r-6177af1f"
time="2022-07-14T18:16:41Z" level=debug msg="Replica pvc-88dfbca2-a40e-4d2d-b0c4-6720fdcfd64d-r-6177af1f is waiting for backing image default-image-hp94c downloading file to node harvester-arsenikki disk a8c5c05d-b8aa-4316-83b0-25d871ab9da7, the current state is unknown" controller=longhorn-replica dataPath= node=harvester-arsenikki nodeID=harvester-arsenikki ownerID=harvester-arsenikki replica=pvc-88dfbca2-a40e-4d2d-b0c4-6720fdcfd64d-r-6177af1f
time="2022-07-14T18:16:41Z" level=info msg="Event(v1.ObjectReference{Kind:\"Replica\", Namespace:\"longhorn-system\", Name:\"pvc-88dfbca2-a40e-4d2d-b0c4-6720fdcfd64d-r-6177af1f\", UID:\"4e987f4f-b5ca-4088-8a5a-584af3475009\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"35889281\", FieldPath:\"\"}): type: 'Normal' reason: 'Start' Starts pvc-88dfbca2-a40e-4d2d-b0c4-6720fdcfd64d-r-6177af1f"

Environment

Longhorn version: 1.2.4
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): installed as part of Harvester 1.0.2
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: RKE2

Number of management node in the cluster: 1
Number of worker node in the cluster: 1

Node config

OS type and version: openSUSE Leap 15.3 (default for Harvester)
CPU per node: 40 cores
Memory per node: 64GB
Disk type(e.g. SSD/NVMe):

Disk with the failing backing image: SAS
New disk that was added: HDD

Network bandwidth between the nodes: 1GB

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): Baremetal
Number of Longhorn volumes in the cluster: 10

I was able to resolve the issue and get the BackingImage back to 'ready' state by removing the matching BackingImageDataSource. That seemed to force a redownload of the backing image.

Thanks @Arsenikki for reporting. We will investigate this issue.
In the mean time, if you see the problem again, can you send us a support bundle to<EMAIL_ADDRESS>

cc @shuo-wu


The Anitube extension has stopped working on Aniyomi. But the site is still up.

Source information
Anitube 14.18 Português (Brasil)
Source language
Português Brasil - PT-BR
Steps to reproduce

1- Open Aniyomi.
2- Open any anime from the Anitube Library.
3- Try starting an episode.
Expected behavior
Should open the episode
Actual behavior

Video keeps loading and gives error.
Aniyomi version
<IP_ADDRESS>
Android version
Android 14
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

@Rafilipes , anytube did a lot of updates, try this: open any video using the Chrome browser to unlock your IP, after that, try to open the aniyomi

@Rafilipes, anytube fez muitas atualizações, tente isto: abra qualquer vídeo usando o navegador Chrome para desbloquear seu IP, depois disso, tente abrir o aniyomi

It worked for some animes, but others are still leaving the video when I click on the episode

@Rafilipes, Estou tentando encontrar uma alternativa para animes antigos (<= 2017) que testei, mas eles perderam os animes antigos
I see that some old animes like the 2011 Hunter x Hunter no longer work, even on their website. But One Piece, which is older, has been running all episodes since 1

to fix your trouble check this fix, i see it in another issue,
https://github.com/Jostino/RimWorld-it/releases/tag/fix
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

@Rafilipes, Estou tentando encontrar uma alternativa para animes antigos (<= 2017) que testei, mas eles perderam os animes antigos

Thank you very much for your help and patience


Update Issue829Test (DrawPrimitiveTest)

Describe your changes
see #829
Issue ticket number and link
#829
Checklist before requesting a review

[x ] I have performed a self-review of my code
[ ] If it is a core feature, I have added thorough tests.

@halx99 ,
I will fix it tomorrow (No more time today).
Or can you fix it?


CTRL + L doesn't open legacy boot mode

Installed the script

But on reboot pressing CTRL + L shows tow options

but no other option  Legacy Boot Mode or SeaBIOS
Any suggestions

that is the expected result on newer Chromebooks. What's the problem?

Thanks for the quick response , should Reboot, press CTRL+L to boot in Legacy Boot Mode, then press ESC and select your USB from the boot menu... The usb don't get detected on rebooting or after choosing 2TianoCore it boots to chrome os.

If Tianocore doesn't boot, then the stock firmware is buggy and little I can do. There is no legacy boot mode in newer Chromebooks, it's related by the alternative bootloader menu. SeaBIOS does not work as an alt payload on these devices.

Aha... thank you!!!

to add I was able to disable the hardware WP ,update the firmware via option 2 and make it work.

to add I was able to disable the hardware WP ,update the firmware via option 2 and make it work.

depends on what you mean by "make it work." You'll gain UEFI booting, but lose the ability to run ChromeOS. You won't be able to run Windows, and Linux will have several functional deficiencies (like built-in audio)


not working via i2c mux tca9548a

Hello,
Is there any way to make it working with i2c mux tca9548a?
Regards

Hello,
I'm very sorry to have kept you waiting so long.
Do you still have this problem now?

Hello,
I'm going to close this issue, feel free to re-open it if you have any other questions.
[Autocommentary]


Icons rendered incorrectly

Reproduction link
--
Steps to reproduce
--
What is expected?
Icon rendered correctly
What is actually happening?
Icon is wrong or incorrectly rendered

Environment
Info

ng-zorro-antd
18.1.1

Browser
Chrome

Look at the medicinebox icon. Taken from ng-zorro docs.

If hovering icon, then it renders correctly.

Failed to reproduce


Unable to use technique in the 'Add Columns' section of this page

The 'Add Columns' section of this page claims I should see a 'Column Options' link in the 'Taskboard' view.  We have Azure DevOps Server 2019, and I do not see 'Column Options' in that view, for projects in two different Project Collections; one using  a 'process' and the other using a 'process template'.  Must I resort to 'witadmin' to change the columns in the Taskboard for the 'process template' based Project Collection? How should I proceed with the 'process' based Project Collection?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4d807b7f-4e44-1e86-7f41-1e67f9c0e1bd
Version Independent ID: 6798865e-0273-2991-9376-abe53725aaac
Content: Customize a Taskboard - Azure Boards
Content Source: docs/boards/sprints/customize-taskboard.md
Product: devops
Technology: devops-agile
GitHub Login: @KathrynEE
Microsoft Alias: kaelli

@GeoffCitron -- Geoff, here are a couple of options where you might consider asking your question:

Azure DevOps on Stack Overflow
Azure DevOps Support Bot

@KathrynEE -- Kathryn, please see if the documentation needs updating.

@GeoffCitron - Thank you for your inquiry.  If you select the Azure DevOps Server 2019 version for this article - https://docs.microsoft.com/en-us/azure/devops/boards/sprints/customize-taskboard?view=azure-devops-2019#feedback - you'll see that the Add Columns option isn't a supported feature for Azure DevOps Server 2019. It is a recently released feature for Azure DevOps Services.  To customize the columns for the Taskboard, you need to use witadmin.  I expect that it will be available on-prem in a future upgrade or release.


Modified the Check For Dependencies Section

After reading through the documentation for dependencies I found a portion of the documentation that could possibly be modified to enhance user understanding/prevent misunderstanding.
Proposed Changes: Check for Dependencies Section
Original Verbiage:
The README probably tells you about dependencies and Homebrew or macOS probably already has them.
Changed Verbiage:
The README likely contains information about dependencies, and Homebrew or macOS may already have them installed.
Reason For Changes: Improve user understanding
Link: https://docs.brew.sh/Formula-Cookbook#homebrew-terminology
Thank you in advance.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ]  Have you written new tests for your changes? Here's an example.
[ ]  Have you successfully run brew style with your changes locally?
[ ]  Have you successfully run brew typecheck with your changes locally?
[ ]  Have you successfully run brew tests with your changes locally?

Thanks for the PR! I don't think this makes things clearer so: passing on this, sorry.


add more win64 jobs to required

Issue Number

Overview

[ ] I have ...

Comments

bors try

This seems redundant with #1467 .... Any explanation on the PR would be nice actually.. Commit body is empty, PR body is empty.


test: fix coverage config

The coverage metrics were incorrect.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.9%) to 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.9%

Covered Lines:
112

Relevant Lines:
112

💛  - Coveralls


Disable Smooth Scrollbar on mobile

Hello,
I have a very basic set up of Smooth Scrollbar (+ Overscroll plugin). On desktop I'm happy with the results, however, on mobile it is too quick.
See:
https://gist.github.com/elliottmangham/c7d5a23e591f164abc0421607a976f95
Is it possible to do either of the following, if so, how?:

Adjust the settings for tablet, mobile (i.e. via media queries)?
Disable Smooth Scrollbar entirely on tablet and/or mobile (i.e. via media queries)?

Thanks in advance.
P.S. Great job!

I'd suggest you use a plugin to do this:
import Scrollbar, { ScrollbarPlugin } from 'smooth-scrollbar';

class MobilePlugin extends ScrollbarPlugin {
  static pluginName = 'mobile';
  static defaultOptions = {
    speed: 0.5,
  };

  transformDelta(delta, fromEvent) {
    if (fromEvent.type !== 'touchend') {
      return delta;
    }

    return {
      x: delta.x * this.options.speed,
      y: delta.y * this.options.speed,
    };
  }
}

// usage
Scrollbar.use(MobilePlugin);

Scrollbar.init(elem, {
  plugins: {
    mobile: { // this is optional
      speed: 0.5,
    },
  },
});

In case you are using es5, see https://github.com/idiotWu/smooth-scrollbar/issues/104#issuecomment-335286699

@idiotWu thanks for the speedy reply!
I'm trying to utilise this in it's simplest form, but maybe I don't understand properly - https://codepen.io/elliottmangham/pen/GGZYMw?editors=0110
Does it look like this is the right approach? I suppose somewhere I must also define the breakpoints.

@elliott-impression that is because some es-next features are not supported in your browser. You may need a transpiler (e.g. babel) or something like:
var Scrollbar = window.Scrollbar;

function MobilePlugin() {
  Scrollbar.ScrollbarPlugin.apply(this, arguments);
}

MobilePlugin.prototype = Object.create(Scrollbar.ScrollbarPlugin.prototype);

MobilePlugin.prototype.transformDelta = function(delta, fromEvent) {
  if (fromEvent.type !== 'touchend') {
    return delta;
  }

  return {
    x: delta.x * this.options.speed,
    y: delta.y * this.options.speed,
  };
};

MobilePlugin.pluginName = 'filterEvent';
MobilePlugin.defaultOptions = {
  speed: 0.5,
};

Demo: https://codepen.io/idiotWu/pen/OENBqK?editors=0010

Hi @idiotWu,
This seems to work, however, it completely strips the mobile browser (Chrome for Android, in my case) of it's native scrolling.
Is it possible to restore the standard mobile scrolling on mobile devices, but utilise the Smooth Scrollbar library desktop-only?
Kindest regards,

What about only initializing scrollbars on desktop browsers?

@idiotWu of course, yes... Long day... 😊🔫
Thanks a lot!

Hello,
I know this is an old thread, can somebody paste the code of how this can be done?
I am referring to initializing scrollbars only on desktop browsers.
Much appreciated!

Hello,
I know this is an old thread, can somebody paste the code of how this can be done?
I am referring to initializing scrollbars only on desktop browsers.
Much appreciated!

Hello, I have tried this and it's working for me :
if (window.matchMedia("(min-width: 1024px)").matches) {
let bodyScrollBar = Scrollbar.init()
} else {
// whatever
}

@elliott-impression that is because some es-next features are not supported in your browser. You may need a transpiler (e.g. babel) or something like:
var Scrollbar = window.Scrollbar;

function MobilePlugin() {
  Scrollbar.ScrollbarPlugin.apply(this, arguments);
}

MobilePlugin.prototype = Object.create(Scrollbar.ScrollbarPlugin.prototype);

MobilePlugin.prototype.transformDelta = function(delta, fromEvent) {
  if (fromEvent.type !== 'touchend') {
    return delta;
  }

  return {
    x: delta.x * this.options.speed,
    y: delta.y * this.options.speed
  };
};

MobilePlugin.pluginName = 'filterEvent';
MobilePlugin.defaultOptions = {
  speed: 0.5,
};

Demo: https://codepen.io/idiotWu/pen/OENBqK?editors=0010

Hi,
when I scroll on mobile the scroll is very slow how can I speed up??


JSON import of empty resource gets ignored

Hi,
Me again - our testers started testing :-)
If in source system in Admin UI for one resource you delete the value, then do a JSON export, and on target system do an import, the change is not picked up at all.
We have a few resources where the customer in the past decided not to display anything, so this can happen to us.
Another (similar, but a bit unlikely) case that in source system in Admin UI do the following changes for one resource:
-in English make same changes (Text1 -> Text2)
-in German delete the value (Text1 -> "")
Export, then import on target system. Only the change in German gets imported, empty text gets ignored again.
Using version 5.7.3.
Thanks!

Hi,
By "removing" - are you referring to "delete" of the translations or setting its value to empty string?

I mean setting the value of a resource of a specific language to empty in Admin UI, so that afterwards a red "Empty" will be displayed.

This is where deadline driven / spare time project leads you ;) Export/Import hasn't been main focus for the developer of the LocalizationProvider library..

I know I report a few issues, but my intention was only to increase the quality, that is why I reported this one as well, I hope you don't mind :-)

no problem, not all. it's perfect that somebody is kicking bugs out..

Hi Valdis,
I tried this with version 5.7.4 and the issue is still there.
Maybe there is some misunderstanding, let me try to formulate the issue more clearly.
I have a resource MyChangeResource, translations for German and English.
If I export JSON now, it will be the following:
{
"id": 887,
"resourceKey": "MyChangeResource",
"modificationDate": "2019-06-14T15:36:00Z",
"author": "migration-tool",
"fromCode": true,
"isModified": true,
"isHidden": false,
"translations": [
{
"id": 24044,
"resourceId": 887,
"language": "",
"value": "Ändern"
},
{
"id": 24044,
"resourceId": 887,
"language": "de",
"value": "Ändern"
},
{
"id": 11970,
"resourceId": 887,
"language": "en",
"value": "Change"
}
]
},
Then on source system I remove the translation for German (with the Trash Button), red "empty" will appear in AdminUI.
If I now do a JSON Export, it is not in the file:
{
"id": 887,
"resourceKey": "MyChangeResource",
"modificationDate": "2019-06-14T15:36:00Z",
"author": "migration-tool",
"fromCode": true,
"isModified": true,
"isHidden": false,
"translations": [
{
"id": 24044,
"resourceId": 887,
"language": "",
"value": "Ändern"
},
{
"id": 11970,
"resourceId": 887,
"language": "en",
"value": "Change"
}
]
},
If now I do an import on target system, this change will not be imported.

oh, now I got it ;) sorry for misunderstanding.. but anyways - I fix other bug that was on the same (similar) path.
about this - hmm, not quite sure how to solve it properly, as delete button really removes the translation and it's gone forever. Meaning that it will not appear in export file. At least - not for now. Workaround is to set value to empty translation..

Sorry for the late answer, github stopped to notify me about new posts and I completely forgot about this :-)
I did not expect that there is a difference between setting to empty vs. using delete button, but indeed, this workaround works!
Is it possible to hide the delete translation button somehow, then we are safer, in our case we never need that delete button.

If you would create new issue – I’ll make sure it lands in next minor version :)
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: nzsb<EMAIL_ADDRESS>Sent: Tuesday, October 8, 2019 12:28:16 PM
To: valdisiljuconoks/localization-provider-epi<EMAIL_ADDRESS>Cc: valdis iljuconoks<EMAIL_ADDRESS>State change<EMAIL_ADDRESS>Subject: Re: [valdisiljuconoks/localization-provider-epi] JSON import of empty resource gets ignored (#41)
Sorry for the late answer, github stopped to notify me about new posts and I completely forgot about this :-)
I did not expect that there is a difference between setting to empty vs. using delete button, but indeed, this workaround works!
Is it possible to hide the delete translation button somehow, then we are safer, in our case we never need that delete button.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvaldisiljuconoks%2Flocalization-provider-epi%2Fissues%2F41%3Femail_source%3Dnotifications%26email_token%3DAANPOC5HERGPMTSE57A4J5TQNRHDBA5CNFSM4IPPNXMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEATREAA%23issuecomment-539431424&data=02|01||5480c30d6a5d49d99da808d74bd1d9d0|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637061236976182543&sdata=hb%2FQhfE91RWW0IxmuJS9bAyRJ%2B1vs6jiLe%2B1QuCusJM%3D&reserved=0, or mute the threadhttps://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAANPOCZIUAFPPYIRFHNYX5DQNRHDBANCNFSM4IPPNXMA&data=02|01||5480c30d6a5d49d99da808d74bd1d9d0|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637061236976192547&sdata=NP0smwKrizZTqH1k1IurqzmMZTR3bAFQmdxad9%2Bin98%3D&reserved=0.

great, thanks!

Fix is working great (with not using the delete button), thanks!


[BISERVER-14546] - ProAuditDatabasejob locks MySQL8's pentaho_operations_mart.pro_audit_staging and pro_audit_tracker tables

@ssamora
@smmribeiro
@bcostahitachivantara

:white_check_mark: Build finished in 26m 30s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:ok_hand: All tests passed!
Tests run: 5073, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 25m 34s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:ok_hand: All tests passed!
Tests run: 5073, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message

:white_check_mark: Build finished in 28m 8s
Build command:
mvn clean verify -B -e -Daudit -amd -pl core

:ok_hand: All tests passed!
Tests run: 5073, Failures: 0, Skipped: 7    Test Results

:information_source:  This is an automatic message


Test_thresh default value should be 0.5 for bias_test_check

It looks like the default value for the test_thresh parameter for the bias_test_check function should be 0.5 rather than 50.

is there anywhere in the code that breaks because of the default 50? i don't currently see any issue with that default, being that the results vector can be in (0,1) or (1, 100) or anything really

I found that was inconsistent with the instructions/example. predict_proba should give results in (0,1). That seems like the most likely workflow—is there a reason to assume users would provide results in (0,100)?


ConsentStatus mapping is wrong for REQUIRED and NOT_REQUIRED states

On https://github.com/cengiz-pz/godot-ios-admob-plugin/blob/0039a4b3c5633394c4c803dd46fef82bc5d523c7/AdmobPlugin/admob_plugin_implementation.mm#L526 REQUIRED and NOT_REQUIRED need to be swapped to be compatible with gdscript implementation.

Looks like the gdscript part is wrong.
https://developers.google.com/admob/ios/privacy/api/reference/Enums/UMPConsentStatus#umpconsentstatusrequired
https://github.com/cengiz-pz/godot-admob-addon/blob/42b913ffab6698c1e49c4dad9285b177e373ee62/model/ConsentInformation.gd#L9


fix URL in CTA button

Changes
This is a very small, one-line fix to address an issue mentioned in #143. Currently, the ctaButton button always leads to root, regardless of the ctaButton.url setting.
This change correctly links the ctaButton's destination to the URL set in landing.yaml.

Dark mode

[X] This PR does not change the UI

Would be great to see this approved! Does this affect the rest of the page as well?

No other effects, it's just a one-line change to make the URL match what's specified in landing.yaml.


Twig Template Engine integration

Twig Template Engine should be integrated
Link: https://twig.symfony.com

Implemented


Reclaiming a Distribution causes an error

Steps to Reproduce

Find an existing Distribution
Click Reclaim
BOOM.
(see image below)

Criteria for Completion
Fix the bug, and write a test to prove it's fixed.
https://i.gyazo.com/2cf9cd802f62f63847a217185149534e.png

I just reclaimed 3 distributions -- I suspect this is an error with an item having been deleted.
Maybe we need to instead do a soft delete/hide.

When an item is deleted, it's only supposed to hide it (mark it "inactive") if the item has history (has any line item or storage item instances)

hrm. looks like you're right. I'll write a feature spec to replicate this and then investigate


Cross-platform stats updates

As of 6th December, all stats collected by the "modern" stats service will now be split into platform groups to allow cross-save and cross-progression.
To-do:

[x] Add PlatformGroup enum and ModernStatsRequest property
[x] Add seasons option to ModernStatsRequest
[ ] Add exceptions when setting two conflicting properties in a ModernStatsRequest

Setting a Start/End date and specifying a list of seasons
Setting a PlatformGroup and a Platform

As of 6th December, all stats collected by the "modern" stats service will now be split into platform groups to allow cross-save and cross-progression.
To-do:

[x]  Add PlatformGroup enum and ModernStatsRequest property

[x]  Add seasons option to ModernStatsRequest

[ ]  Add exceptions when setting two conflicting properties in a ModernStatsRequest

Setting a Start/End date and specifying a list of seasons
Setting a PlatformGroup and a Platform

Please weigh in here:
https://github.com/Seems2Legit/Rainbow-Six-Siege-Player-Stats-API/issues/91#issue-1485588198


Add syntax highlighting and imenu support for union

union is a contextual keyword, so highlight it in the correct
context. Otherwise, treat union similarly to struct.

Thanks for the patch.


Status frontend: refresh automatically

Most of the states the status frontend can be in involve some sort of 'X mins until Y' statement, which quickly becomes inaccurate. It would be better if those value were automatically updated to reflect the current time, and if the status frontend overall refreshed completely as new runs happen.

It looks like there is also a 'bug' in that a browser tab left alone for several days will re-run the JS at some point, I guess, but used a cached json file, leading to the output stating that notifier has not run since the output was cached. Refreshing the page fixes this but shouldn't be necessary.


Exact match takes precedence

@robertzk @peterhurford this is meant to address this issue: https://github.com/robertzk/stagerunner/issues/48
I tried your regex trick to get at the model stage with run('model$') or run('del$') to no avail because we have grepl(..., fixed = TRUE) here: https://github.com/robertzk/stagerunner/blob/master/R/normalize_stage_keys.R#L165
Here's a snippet I ran on both 0.5.0 and this branch:
sr <- stagerunner$new(new.env(), list(
    "model"       = force
  , "model_card"  = force
  , "card_ashian" = force
  ))

sr$run()

sr$run('model', verbose = TRUE)
sr$run('del$', verbose = TRUE)
sr$run('card', verbose = TRUE)
sr$run('^card', verbose = TRUE)
sr$run('model_card', verbose = TRUE)

The output on 0.5.0:
> sr$run('model', verbose = TRUE)
Error in normalize_stage_key.character(key = key, keys = rest_keys, stages = stages,  :
  Multiple stages with key 'model', found: model, model_card

> sr$run('del$', verbose = TRUE)
Error in normalize_stage_key.character(key = key, keys = rest_keys, stages = stages,  :
  No stage with key 'del$' found

> sr$run('card', verbose = TRUE)
Error in normalize_stage_key.character(key = key, keys = rest_keys, stages = stages,  :
  Multiple stages with key 'card', found: model_card, card_ashian

> sr$run('^card', verbose = TRUE)
Error in normalize_stage_key.character(key = key, keys = rest_keys, stages = stages,  :
  No stage with key '^card' found

> sr$run('model_card', verbose = TRUE)
Running 2. model_card...

The output on this branch:
> sr$run('model', verbose = TRUE)
Running 1. model...

> sr$run('del$', verbose = TRUE)
Running 1. model...

> sr$run('card', verbose = TRUE)
Error in normalize_stage_key.character(key = key, keys = rest_keys, stages = stages,  :
  Multiple stages with key 'card', found: model_card, card_ashian

> sr$run('^card', verbose = TRUE)
Running 3. card_ashian...

> sr$run('model_card', verbose = TRUE)
Running 2. model_card...

Nice! :+1:

Good call, thanks! Can you add a test?


Redirection to exercise after login broken

Related to #200.

Logout.
Go to an exercise
Login
Should go to exercise, but redirects to homepage.

This is not happening anymore on production. Closing it


Python: Update basic_planner.py

change the create_plan_async function to make notebook 05.using-the-planner works
Motivation and Context

Description

It's a very minor change, just the order of the variables.
Contribution Checklist

[ ] The code builds clean without any errors or warnings
[ ] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[ ] All unit tests pass, and I have added new tests where possible
[ ] I didn't break anyone :smile:

This didn't fix it for me. Plan does not appear to have these parameters?
This to me suggests basic_planner.py needs to be updated:
https://github.com/microsoft/semantic-kernel/pull/1907


Config details: Initial commit

RFE https://github.com/kiali/openshift-servicemesh-plugin/issues/52

I would create a new repo with the components that we are using in kiali and openshiftserviceMesh... this will be hard of maintain and align with kiali/kiali.

I agree with @aljesusg . Copying and pasting code does not seem the way to go.
Creating yet another repo with re-usable components is OK. Although, I have some faith that the front-end in kiali/kiali can receive some moderate refactorings to make it re-usable (avoiding a new repo).

In my experience it's pretty hard to build a good set of reusable components.  Although this may be a good idea, I think it's premature and I'd like to see us gain adoption for the the plugin, get feedback, and have a solid understanding of what we need to do to get it accpeted into console for real.  At that point we will be in a better position to decide on the steps necessary to maintain a solid code-base.


Add FQE docs to devsite

Self-explanatory from title.
cc @lamberta if you have time for a quick review. The goal is to include the FQE docs on https://quantumai.google/openfermion under a new "FQE" tab. I followed how this is done for ReCirq and Cirq - see https://github.com/quantumlib/OpenFermion-FQE/pull/81 for more details.

To pull docs from the OpenFermion-FQE repo you'll need to set up separate docs infra for that project. It is much easier to keep the source of those docs in this repo and use the existing nightly jobs.

To pull docs from the OpenFermion-FQE repo you'll need to set up separate docs infra for that project. It is much easier to keep the source of those docs in this repo and use the existing nightly jobs.

Ahah, thanks for this 🙏
@ncrubin would you prefer to

Migrate fqe/docs into this repo as suggested?
Set up separate docs infra for FQE?
Other?

(1) is easy and I can do this (today). (2) I don't know how to do at the moment.

Pulled in the FQE notebooks as we discussed, PTAL.
Note for posterity: I did not write 1800+ lines here, just moved the notebooks from https://github.com/quantumlib/openfermion-fqe.


Add tokenization and truncation funcionality to Tokenize() function.

Here, we use of tokenizer.encode_plus() directly because we don't want to modify tokenizer_group.encode_async and this function is part of upstream code/project. This implementation won't affect performance because  tokenizer_group.encode_async doesn't run Tokenizer.encode in a background thread.
Should we add a unittest for this implementation?

Closing this PR as I have created a more organized one: https://github.com/IBM/vllm/pull/47