New command: request

PnP Powershell has this nice wrapper function around the SharePoint api, Invoke-PnPSPRestMethod.
Would it be nice if we had that too in the CLI? For example for the SharePoint and Graph API's.
Why would a user use that?

It is useful if you have specific wishes around (for example) data retrieval. The user might be able to optimize scripts by just running one command instead of a few.
It is useful if there's some functionality not (yet) covered in the CLI.

Why would we add it?
Currently you would need to get a token using m365 util accesstoken get and construct the call using a tool like curl or Invoke-WebRequest. That works fine, but it would also be nice if we take away at least some of the plumbing for the user. This means less code to write for the user. An still a lot of flexibility.
We might also be able to add extra's like retrieving all items (aka fix paging for the user)
It's a more advanced scenario for more advanced users. But I believe it could add a lot of value.
Any ideas/opinions on this?
Specs below
request
Invoke a custom request at a Microsoft 365 API.
Usage
m365 request [options]

Options

Options
Description

-u, --url <url>
The request URL.

-m, --method [method]
The HTTP request method. Accepted values: get, post, put, patch, delete, head, options. The default value is get.

-r, --resource [resource]
The resource url for which the CLI should acquire a token from AAD in order to access the service. The token will be placed in the Authorization header. By default, the CLI can figure this out based on the --url argument.

-b, --body [body]
The request body. Use @example.json to load the body from a file.

-h, --headers [headers]
A JSON string containing optional header values. Use @example.json to load from a file.

-a, --accept [accept]
A convenience option to set the accept header of the request.

-c, --contentType [contentType]
A convenience option to set the Content-Type header of the request.

Remarks
This command will send a raw request to the targeted API. It will not make any assumptions on the type of content that's sent or returned.
Examples
Call the SharePoint Rest API using a GET request with a constructed URL containing expands, filters and selects.
m365 request --url "http://contoso.sharepoint.com/sites/project-x/_api/web/siteusers?$filter=IsShareByEmailGuestUser eq true&$expand=Groups&$select=Title,LoginName,Email,Groups/LoginName" --accept "application/json"

Call the Microsoft Graph beta endpoint using a GET request.
m365 request --url "https://graph.microsoft.com/beta/me"

Call the SharePoint API to retrieve a form digest.
m365 request --method post --url "http://contoso.sharepoint.com/sites/project-x/_api/contextinfo" --accept "application/json"

Call the SharePoint API to update a site title.
m365 request --method post --url "http://contoso.sharepoint.com/sites/project-x/_api/web" --headers '{"X-RequestDigest": "somedigest", "X-HTTP-Method": "PATCH"}' --body '{ "Title": "New title" }' --contentType "application/json"

I wonder whether it would be better to have a unified REST command though rather than separating into two commands, we could inspect the hostname in the URL and determine which resource to get an access token for.

Great idea @garrytrinder!

+1 to @garrytrinder's comment about having one command across all workloads. I'm not sure about the rest name though, as you can use it to call any URL, including CSOM, so perhaps something even more generic like call or request would it clearer.
Before we proceed with implementation, let's spec out the functionality some more. We should pay extra attention to headers: the format used by az cli (key=value pairs separated by spaces) might not work for us so let's double check that with the different scenarios.

+1 for m365 request

Good idea.. I'll create a better spec, and then you guys can respond to that again.
By the way: what do you think about having an option to force the command to get all items, e.g. that it follows odata next page links?

By the way: what do you think about having an option to force the command to get all items, e.g. that it follows odata next page links?

Good question. On one hand, it would be a nice convenience option. On the other, it's additional complexity and moving away from the raw-request purpose of this command. I'd say, let's leave it out at the start and perhaps revisit later after we had some usage and feedback.

Agree with @waldekmastykarz lets get the basic functionality covered in the command first, get it shipped and make folks aware and iterate based on feedback and real usage 🚀

OK, I've added specs. Very interested to hear your ideas! @pnp/cli-for-microsoft-365-maintainers and other contributors!

I love the idea. Also since it will provide more functionality/freedom than the PnP equivalent 😉
I was only wondering about the resource option if this could not be a free text but maybe give some possible options like: spo, graph, powerapps. etc. 🤔

Well, I think that would make it less flexible. The idea is that the CLI knows what the resource is, based on the URL. There are situations where the resource can not be easily guessed, in those cases you'll need to use the resource option. It's hard upfront to guess what these cases are, so you'll have the best freedom typing your own resource.

Well, I think that would make it less flexible. The idea is that the CLI knows what the resource is, based on the URL. There are situations where the resource can not be easily guessed, in those cases you'll need to use the resource option. It's hard upfront to guess what these cases are, so you'll have the best freedom typing your own resource.

That's true. Freedom is the biggest advetnage in this command 👍.
I only thought that maybe we could also help out the user somehow by giving options and setting the proper url for to use, but then we will loose the freedom of this command.
No other additional command then.
Great suggestion 🤩

...added some extra examples.

Anyone extra comments on this? @pnp/cli-for-microsoft-365-maintainers? Otherwise we can open this up for contribution.

Anyone extra comments on this? @pnp/cli-for-microsoft-365-maintainers? Otherwise we can open this up for contribution.

For me looks ok and ready to go

@garrytrinder or @waldekmastykarz also OK with this setup?

Ship. It. 🚀

Why does a resource need to be a separate option rather than something that we'd resolve using the existing logic?

Also, for headers, have we researched the ability to use key-value pairs instead of a JSON string (which would be pretty inconvenient to type)?

Why does a resource need to be a separate option rather than something that we'd resolve using the existing logic?

Hi Waldek,
We do resolve it using the existing logic.
We added the resource option as there are cases where the resource url differs from the api endpoint. We cover a few of those situations in the CLI (for example with the power platform urls and https://management.azure.com) but there might be cases that we have missed till now. The resource option offers a little extra flexibility in those cases, should anyone run into it.
Should I make the description clearer?

Also, for headers, have we researched the ability to use key-value pairs instead of a JSON string (which would be pretty inconvenient to type)?

Good point, I did not... (making a mental note)

We added the resource option as there are cases where the resource url differs from the api endpoint. We cover a few of those situations in the CLI (for example with the power platform urls and https://management.azure.com/) but there might be cases that we have missed till now. The resource option offers a little extra flexibility in those cases, should anyone run into it.

If we allow people to specify the resource, we'll need to find a way either to pass the retrieved access token into the request while suppressing the automatic token retrieval based on the detected resource. One way around it might be to pretend that the request is anonymous using the custom x-anonymous header that we strip before issuing the request but which skips the token retrieval part.
As for the headers, let's update the spec, so that later we know what the command is supposed to do and can properly validate the PR.

If we allow people to specify the resource, we'll need to find a way either to pass the retrieved access token into the request while suppressing the automatic token retrieval based on the detected resource.

Check my PR 😇 @waldekmastykarz.
I considered x-anonymous, but seeing the use cases I chose another route: injecting the accesstoken as a part of the AxiosRequestConfig. A minimal change, but OK as far as I can see.

I added my comments on the PR 👍

Hi @waldekmastykarz,
I'm playing with the idea to use unknown options for the headers.
This would greatly simplify writing them down.
m365 request --url "https://blimped.sharepoint.com/sites/learning/_api/web" --accept "application/json" --x-request-digest "some digest" -if-match "*"

Combined with allowUnknownOptions, I've tested it and this:
    const unknownOptions: any = this.getUnknownOptions(args.options);
    const unknownOptionsNames: string[] = Object.getOwnPropertyNames(unknownOptions);
    unknownOptionsNames.forEach(o => {
      logger.logToStderr("header: " + o + " / value: " + unknownOptions[o]);
    });

prints the following:
header: content-type / value: test
header: x-request-digest / value: some digest

What do you think about that? I think its better than string key value pairs.
The only question is what we do with the contentType option. Keep it on the convenience list (and write contentType) or follow up writing in with a dash.

I've updated the specs and fixed the PR.

Very nice! 👏


Visual artifacts

The bemoji window also flickers but that apparently isn't captured by OBS Studio:

That is very interesting. Are you running on X11 or on Wayland?
And does the issue happen when you open rofi (which I believe is your picker?) manually while displaying emojis? E.g.:
echo -e "😀 grinning face\n😃 grinning face with big eyes" | rofi -dmenu

I'm on Wayland.
I discovered like after I opened this issue that I could pipe the output to my favourite dmenu-like picker, which is fuzzel.
So right now I'm using
BEMOJI_PICKER_CMD="fuzzel --dmenu" bemoji -P -t

which works wonders.
The artifacts only happen when calling bemoji directly.

Uhm I actually had rofi installed. I uninstalled it and now bemoji doesn't start on itself.
So I guess it was a bug of rofi?

My guess would be then that it tried to start rofi by default - which had to be started under XWayland - and some geometry-setting didn't work out right under Wayland proper. Perhaps I could show a warning if rofi is (automatically) started under Wayland.
Also, fuzzel seems like an interesting dmenu-like, thanks for bringing it to my attention!

Oh, rofi is only for X11. That could explain it.


Restrict behavior of callable classes

In Dart 2.0, we would like to change to the behavior of callable classes (classes containing a .call method) so that they are no longer considered a subtype of the function type of their .call method.
Instead, to support almost all existing code, the call method will be implicitly torn off where statically detectable (but dynamic invocation of a class with a call method will still be allowed).
Rationale: This feature has never paid its way as far as complexity it adds to the type system and the implementations.  It has been (and probably still is) the source of various bugs.  It also complicates our calling conventions in generated code - we cannot assume a function is actually a function.  In general, we believe fixing google3 code will be faster than properly implementing and will probably result in better generated code.
Test cases for this change were added to the tests/language_2 subdirectory in f0a6330db005acbe6514d26931b5fcb9782321d2.
This is an overall tracking bug.  Individual implementations are tracked in their own sub-bugs:

[x] specification text #32153
[x] front end #32064
[x] VM #32154
[x] dart2js #32155
[x] analyzer #32156
[x] DDC #32157
[ ] Verify tests are passing
[ ] Documentation

I don't know that we're going to document callable classes more than they are. Should this be closed?

I don't know that we're going to document callable classes more than they are. Should this be closed?

I'm in favor of closing it


send_api_usage_telemetry decorator fails and hides public API errors

I'm following the Snowpark ML tutorial and one of the code examples throws an error. The error is handled by a telemetry collection code which throws an error itself. So I see only an error from the telemetry code and don't see the original error at all.
import snowflake.ml.modeling.preprocessing as snowml

<...>

snowml_oe = snowml.OrdinalEncoder(
    input_cols=["CUT", "CLARITY"],
    output_cols=["CUT_OE", "CLARITY_OE"],
    categories=categories,
)
ord_encoded_diamonds_df = snowml_oe.fit(normalized_diamonds_df).transform(
    normalized_diamonds_df
)

And the error is:
Traceback (most recent call last):
  File "/Users/juozas/projects/lt/spml/transformations.py", line 90, in <module>
    ord_encoded_diamonds_df = snowml_oe.fit(normalized_diamonds_df).transform(
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/site-packages/snowflake/ml/_internal/telemetry.py", line 302, in wrap
    res = func(*args, **kwargs)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/site-packages/snowflake/ml/_internal/telemetry.py", line 369, in wrap
    res = func(*args, **kwargs)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/site-packages/snowflake/ml/modeling/preprocessing/ordinal_encoder.py", line 419, in transform
    output_df = self._transform_snowpark(dataset)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/site-packages/snowflake/ml/modeling/preprocessing/ordinal_encoder.py", line 444, in _transform_snowpark
    if dataset._session._table_exists(self._vocab_table_name)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/site-packages/snowflake/snowpark/session.py", line 2101, in _table_exists
    raise SnowparkClientExceptionMessages.GENERAL_INVALID_OBJECT_NAME(
snowflake.snowpark.exceptions.SnowparkInvalidObjectNameException: (1500): The object name 's.n.o.w.m.l._.p.r.e.p.r.o.c.e.s.s.i.n.g._.o.r.d.i.n.a.l._.e.n.c.o.d.e.r._.t.e.m.p._.t.a.b.l.e._.c.4.9.9.c.5.f.6.c.<IP_ADDRESS>.e.a.4.9.d.e.e.<IP_ADDRESS>.5.b.1.5.8.a.9.5' is invalid.

After patching the decorator in snowflake/ml/_internal/telemetry.py
def send_api_usage_telemetry(...)
    def decorator(func: Callable[_Args, _ReturnValue]) -> Callable[_Args, _ReturnValue]:
        return func()

    return decorator

I can see the actual error:
Traceback (most recent call last):
  File "/Users/juozas/projects/lt/spml/transformations.py", line 42, in <module>
    import snowflake.ml.modeling.preprocessing as snowml
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/site-packages/snowflake/ml/modeling/preprocessing/__init__.py", line 7, in <module>
    exportable_classes = init_utils.fetch_classes_from_modules_in_pkg_dir(pkg_dir=pkg_dir, pkg_name=pkg_name)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/site-packages/snowflake/ml/_internal/init_utils.py", line 25, in fetch_classes_from_modules_in_pkg_dir
    module = importlib.import_module(f"{pkg_name}.{module_info.name}")
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/site-packages/snowflake/ml/modeling/preprocessing/binarizer.py", line 12, in <module>
    from snowflake.ml.modeling.framework import base
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/site-packages/snowflake/ml/modeling/framework/base.py", line 291, in <module>
    class BaseEstimator(Base):
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/site-packages/snowflake/ml/modeling/framework/base.py", line 373, in BaseEstimator
    def _compute(
  File "/opt/homebrew/Caskroom/miniconda/base/envs/snowpark/lib/python3.10/site-packages/snowflake/ml/_internal/telemetry.py", line 250, in decorator
    return func()
TypeError: BaseEstimator._compute() missing 4 required positional arguments: 'self', 'dataset', 'cols', and 'states'

I expect to see the errors from the public API code and the telemetry not to interfere with it.
Also, I would like to disable telemetry collection. The Snowpark Session option doesn't work, or at least setting it to False doesn't disable the failing code path.

Disabling telemetry is available from 1.0.7. We are working on a clear traceback.

This issue will be fixed in 1.1.2.


drivers: rtc: Add RV3028 RTC driver

This PR adds basic support for microcrystal RV3028 RTC connected to the I2C bus:

It supports getting/setting time and time alarm/update callbacks.
Backup switchover and trickle charger configuration using devicetree.
I also added an API extension for accessing the user RAM registers and EEPROM.

Accessing the user RAM and EEPROM will be handled using the retained_mem API in a separate PR

I didn't implement the device PM API because it wasn't clear to me how it should behave in terms of power switchover functionality.

I have tested the driver using the RTC API test suite. The Y2K test is skipped because this RTC only supports the final two digits of years.
Thanks

Oh, I just realized my PR overlaps with #73385. I didn't see it at the time of submission. This is my first zephyr contribution, so I'd still appreciate any suggestions for the next time 🙂

Wild timing, only 1 hour after #73385 was pushed :) It would be great if you help review #73385 since you probably have quite a bit of knowledge of that specific RTC :)

Hi @jakubtopic and @bjarki-trackunit,
I removed the RV-3028 stuff from my PR because the driver from @jakubtopic is more advanced than my driver. I will focus on RV-8263 because this RTC is more important to me. 👍

Hi @Kampi, I wouldn't say it is more advanced, but I appreciate your trust. I'll keep working on my driver then. Good luck with the other device!

I was actually running an older version of the Y2K test. It looks ok now
removed the rtc_rv3028.h header file  look into this later
replaced the dedicated thread with the system workqueue
added time validation
the backup registry value is determined directly in the device instance

@Kampi, do you want me to implement the RTC calibration?

I would suggest removing this test case dependency so we can test boards that have RTC connected externally but don't have it listed in the supported features.
https://github.com/zephyrproject-rtos/zephyr/blob/362588037efcbbb50557e5e3cb19d799165bf5c6/tests/drivers/rtc/rtc_api/testcase.yaml#L11

@Kampi, do you want me to implement the RTC calibration?

The RTC doesn´t have a calibration function so you have to add it (somehow) in the driver. Not sure if this would make sense.

By calibration I meant setting frequency offset correction using the rtc_set_calibration function. I noticed it in your driver for RV8263, so I wasn't sure if you needed it for RV3028 as well.

By calibration I meant setting frequency offset correction using the rtc_set_calibration function. I noticed it in your driver for RV8263, so I wasn't sure if you needed it for RV3028 as well.

I added it because the RTC contains a register for a calibration value so it's done in hardware. You can do a software calibration for the RV3028 too and use this interface.

I added it because the RTC contains a register for a calibration value so it's done in hardware. You can do a software calibration for the RV3028 too and use this interface.

I think both ICs support frequency offset compensations. It's not a feature I need, so I was wondering if you hadn't originally planned it for RV3028 as well 🙂

I added it because the RTC contains a register for a calibration value so it's done in hardware. You can do a software calibration for the RV3028 too and use this interface.

I think both ICs support frequency offset compensations. It's not a feature I need, so I was wondering if you hadn't originally planned it for RV3028 as well 🙂

No I haven´t planed it for RV3028 because I haven´t found a calibration register or function during a quick check. :)

Fixed formatting errors

@bjarki-trackunit, @decsny Kindly asking for re-review :)


Added tip to "Browser Support" in README

This "hidden" gem of chrome has been a killer-feature for me when using ttyd (I'm an emacs user). Thought it's worth mentioning. Unfortunately firefox does not allow one to disable keybindings to the same extent as chrome (I typically favor firefox).

Hi, I've moved the usage/tips part of the README to this Example Usage wiki page, you may want to edit the wiki yourself.


Update wallet Dapp notification (version compatibility)

Design is here https://zpl.io/aRReAee
Notification about unavailable should be shown on DAPP card and above DAPPs list.

I've changed strings:

This DAPP requires ....  In design  it is "The new  version of DAPP" but it is not always correct. It can be the same version as user used before but on old wallet.

Please change the line from "Please update" to "Please update your wallet"

Please fix this.
If 1 is not available it should be "DApp is not available" if more then 1 "DApps are not available"

checked


Step 1 - NPM

https://www.npmjs.com
vCDAT has a required package vcs-widgets. The auto build script will include the latest version of vcd-widgets. Step one of the vCDAT build will be building the newest version of vcd-widgets and pushing it to npm.
mkdir ~/projects/UV-CDAT/
cd  ~/projects/UV-CDAT/
git clone<EMAIL_ADDRESS>cd vcs-widgets.git
npm install    (you may be missing 4 packages)
npm link       (? still learning)
npm publish (need to grant access)

What is the correct way to build vcs-widgets? Where are the instructions for building them and then pushing it to npm repository?

Good Work 👍


Harden GADT constraint handling to survive illegal F-bounds

This currently fails BestEffortCompilationTests
The problem is that i20317a.scala contains illegal cyclic references. The cycles cause many different algorithms in the compiler to loop. We normally reject the program, and that's that. But under best-effort, we crash with Stackoverflows in the loops later. What to do? It's not feasible to avoid the looping behavior at acceptable cost. Can we disable best effort under certain conditions?

The fix is to put the file name into compiler/test/dotc/neg-best-effort-unpickling.blacklist. This will cause this specific test to not be executed and the CI to pass, as it does with other files test files related to cyclic reference errors. In the real world IDE scenario we let it crash with the message and handle that gracefully on an IDE side (I know this is far from a perfect solution, and there are a few other yet-unsolved cases like cyclic-reference-errors).
Usually in CI we should get a message asking to put the file in compiler/test/dotc/neg-best-effort-unpickling.blacklist. but I see it does not show there now (which in hindsight, makes sense), so this is definitely something I need to fix.
In general I would not want the compiler development to be throttled by the best-effort options in any way, so using the aforementioned exclusion list is very much expected. Again, the message with the exclusion list it was supposed to show, but it makes sense it wouldn't with the stack error.
I'll figure something out for cyclic-reference errors in the coming weeks for 3.5.1. I apologize for the inconvenience!


Client Allocation Request for: f01123232

Client Allocation Questions
Core Information

Name: f01123232
Website / Social Media: f01123232
Region: Greater China
DataCap Requested: 100TiB
Addresses to be Notarized: f01123232
Notary Requested: neogeweb3

@15012700225 Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Hey @15012700225, thanks for the request. I have some questions regarding your request. Please describe answers as much specificity as you can.

Can you introduce yourself? Where can I find you online? (Github, Twitter, Linkedin handle, Wechat, etc.)
If you represent an organization, what is the name, nature, registration country, time since inception, and named officers of your organization?
In which region(s) do you intend to use the DataCap?
What is your use case for the DataCap being requested?
Do you plan to specify advanced features when utilizing a DataCap in your storage deal? If so, please specify the feature.
How many miners do you plan on allocating the DataCap? If you have a specific miner(s) you would like to allocate a DataCap, please specify.
Do you agree on providing transparency of DataCap allocation decisions & execution details in public to prevent excessive/unfair (20% of DataCap allocation) self-dealing?

Moreover, I encourage you to take a look of my allocation strategy  and flow which shows how I utilize the assessment. Thanks.

Hey @15012700225, are you still interested in this allocation request?


[New Port Request] rdkit

Library name: rdkit
Library description: RDKit is a collection of cheminformatics and machine-learning software written in C++ and Python.
Source repository URL: https://github.com/rdkit/rdkit
Project homepage (if different from the source repository):  https://www.rdkit.org/docs/index.html
Anything else that is useful to know when adding (such as optional features the library may have that should be included):

requires Boost 1.58 and is not obviously overridable

It would be wxtremely useful

This would still be useful to have if possible.

👀

👀


Change UI form field from finality delay to block confirmations

Fixes #1277

LGTM, assuming you tested it manually?

I got a seemingly unrelated error when testing, so I assumed this is working okay. I got an error "Cert string has wrong number of fields".


[7935] Amended sign off period to be performance period for staging

Context
Sign off period
Changes proposed in this pull request
Setting sign off period to be performance period
Guidance to review
:ship:
Important business

[ ] Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
[ ] Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
[ ] Do we need to send any updates to DQT as part of the work in this PR?
[ ] Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

https://trello.com/c/VJRoVpeG/7935-turn-on-performance-profile-on-staging


Profile is remembered for non-folder mode

Testing #158809

code-insiders --profile test foo.txt

Observe: VS Code is opened in non-folder mode and uses the "test" profile

shutdown VS Code
code-insiders bar.txt

Observe: VS Code is opened in non-folder mode and still uses the "test" profile
I was surprised that a profile is not only remembered for workspace folders but for the "non-folder" mode as well.
I'm not sure whether this is a bug or a feature ;-)
BTW, --profile-transient is not remembered for "non-folder" mode

@weinand code-insiders --profile test foo.txt is opening the no folder workspace but not with test profile. May be you have associated the empty window with test profile already before?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Connect to Azure Storage using SAS url

Is it possible to use SAS url to connect to blob storage ? Logic app not allowing to create connection using SAS url.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bc1a51f6-730a-6077-6f9d-90afeaceed20
Version Independent ID: 6d012a9a-5fbd-fd18-9656-c42e88bac5d0
Content: Connect to Azure Blob Storage - Azure Logic Apps
Content Source: articles/connectors/connectors-create-api-azureblobstorage.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

Hi @kulpras Thanks for reaching out. We will review and update as appropriate.

@kevinlam1 Appreciate your inputs in this ?

I have moved teams. You can reach out to @Divya<EMAIL_ADDRESS>for connector questions.
Thanks,
Kevin
From: DixitArora-MSFT<EMAIL_ADDRESS>Sent: Monday, June 1, 2020 8:58 AM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Kevin Lam<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] Connect to Azure Storage using SAS url (#55840)
@kevinlam1https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkevinlam1&data=02|01|Kevin.Lam%40microsoft.com|ed4d2ab769654208f87d08d80644a067|72f988bf86f141af91ab2d7cd011db47|1|0|637266239105160392&sdata=bPT%2Bm1Mf6IhJU4yyoiFb7i5Ib7hwp9Bmy%2BD1Nhkmzvw%3D&reserved=0 Appreciate your inputs in this ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F55840%23issuecomment-636939383&data=02|01|Kevin.Lam%40microsoft.com|ed4d2ab769654208f87d08d80644a067|72f988bf86f141af91ab2d7cd011db47|1|0|637266239105170386&sdata=y9VigxITTlE02nf1gWdanJJZ5d%2BugWATZCYBBdneliY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAUUAMC7N3LGKGYU2APLPHDRUPF2JANCNFSM4NM2HV3Q&data=02|01|Kevin.Lam%40microsoft.com|ed4d2ab769654208f87d08d80644a067|72f988bf86f141af91ab2d7cd011db47|1|0|637266239105170386&sdata=Y0pyqJu12oEtEF4DT6sIXeGaEGmNHqA74gjoNy52Bog%3D&reserved=0.

@divyaswarnkar Appreciate your inputs in this ?

@kulpras what are you seeing ? Failure ?

No option to use sas token while creating blob connection in logic app.

@divyaswarnkar, did you have additional guidance?

Hi @divyaswarnkar, this issue is stale. Did you have any more input?

@kulpras, as we haven't heard from @divyaswarnkar, perhaps you could post feedback in the Logic Apps user feedback site for the Connectors section:
https://feedback.azure.com/forums/287593-logic-apps?category_id=145803
I'll close this thread for now. #please-close


One chuck record would be embedded 3 times and inserted 3 records in milvus db

Bug Description
Very simple flow, load data from file, and split with "\n" , and then insert into milvus db.
I found that, it call the embedding component 3 times, and there are 3 embedding records for every data chuck.
Reproduction

only 1 record in split result:

it called the embedding component 3 times with same data.

And there are 3 same records in milvus.

Expected behavior
should not call the embedding and milvus db 3 times.
Who can help?
No response
Operating System
Docker image v1.0.15
Langflow Version
v1.0.15
Python Version
None
Screenshot
No response
Flow File
No response

Build one time, called embedding 3 times, and inserted 3 records, it seems, it's not caused by the rebuilding.
folder.json
notice the timestamp and request length.


New yandex market feeds

Note: Description in associated PR to instamart

@dmitrybobylev, done.

fix naming;
for 'all' exports we supply really all products, that have taxons.


Quality of life and some place-able items

Description
Adding place able objects and smaller quality of life updates.
Place-able objects include fences and gates (attempts to tie animals into the game), chests (the game most likely needs storage) and sprinklers (increase game play mechanics and the ceiling of productivity). Some of the quality of life updates we intend to do is highlighting the tile the player will interact with on mouse click (might try to highlight animal if click would do that instead, very much a might though), also will try to better align where the player will interact with by adjusting the result of getPosition.
SubFeature/component
Fences - Block movement of all entities (Helps keep your animals in check). Can be a reward from taming animals;
Gates - So you can enter the animals pen to feed them and say hi. Can be a reward from taming animals;
Chests - So you can store your excess seeds and fertilizers without keeping them in your pocket. Can be a reward from a quest;
Sprinklers - Increases the ceiling of productivity. (useful if we decide to continue with original plans for allowing player to have an endless mode) Can be a reward for watering X amount of crops.
Player interaction - At the moment it is hard to tell where the player will interact, we hope to change this by highlighting what will be interacted with on a mouse click, will also try to make the tile that will be interacted with fit nicer.
Dependencies
Team 8 said they will do chest display for us if this gets approved <3
Milestones

[x] Goal 1 (Sep. 24) - Placeable framework completed,
[x] #303 (Sep. 30)
[ ] #313 (Sep. 30)
[x] #310 (Sep. 30)
[x] #311 (Sep. 30)

Completion Deadline: Oct. 4
Extras (optional)

[x] Tractor animations

Documentation
https://github.com/UQcsse3200/2023-studio-1/wiki/Placeables
Members
Shanon Lakshan Chandrasekara (@86LAK)
Jackson Trenerry (@JTrenerry)
Peter Lahanas (@p-lahanas)
Cohen Porteous (@cmp6)
Liam Anderson (@LiamAnd)

being continued in a different ticket


release a new from Commits on Nov 6, 2016

can you release a new version to npm ?

1.1.3 released


using pixi loader directly in html file

I just started with pixi, and I would like to load an animated json model as is shown here but instead doing it in .js i would like to do it directly in the html file.
So I tried to load json model as is shown here (and then somehow work out how to add animation) but in the example they dont add it to the stage.
I tried various ways to do it, but nothing seems to make an image show even if try using a .png instead of .json. Help?

https://github.com/pixijs/pixi.js/blob/dev/src/core/textures/Spritesheet.js#L11
You have to get baseTexture from loader or somehow else. Then use this class to parse your json and get the textures.

Okay, i know im completely butchering this, and im sorry, because this is what i manage to come up with (hint: it doesnt work and it  might hurt your eyes)
			loader.add('t','monster.json');
			loader.on('complete',function (loader,res) {
                                var texture= res.t.BaseTexture;
				var spritesh= new PIXI.Spritesheet( texture,t); //im not sure what data in this case is?
				stage.addChild(spritesh.parse(callback)); //i have no idea where im supposed to get callback
				text.text = "Everything is loaded! If it was too quick for you, use your network panel :)";
			});

			loader.load();

Sorry again, i know this isnt even close, but when i said "i just started with pixi" i do mean today...

Okay i realized i was going about it the wrong way, since didnt actually need to change anything from the first example to make it work in a html file.  Sorry for bothering you.


Serious performance hit on MASTER ( 0b615a5 )  version.

Creating a tree with a million elements takes 3secs on my PC with current qtree version while it only took 0.5sec to version v0.1.2.

Ok, it seems the "good" performance of version v0.1.2 is due to a bug.
Line 171 if( leaf )  should be if( leaf.leaf ).
Please ignore this. (and DON'T use v0.1.2)


[BUG] System.Exception: Login page failed after successful login.

Bug Report
EasyRepro Version

[ ] Microsoft Dynamics 365 Online Version 8.2 (8.2.x) (DB 8.2.x) online
[ ] Microsoft Dynamics 365 Online Version 9.0 (9.0.x) (DB 9.0.x) online
[ ] Microsoft Dynamics 365 Online Version 9.0.2 (9.0.2) (DB 9.0.2) online
[x] Microsoft Dynamics 365 Online Version 9.1 (9.1.x) (DB 9.1.x) online

UCI or Classic Web

[x] UCI (XrmApp)
[ ] Classic Web (XrmBrowser)

Online or On Premise

[x] Online
[ ] On Premise

Browser

[x] Chrome
[ ] Firefox
[ ] IE
[ ] Edge

Describe the bug
When running any test in Visual Studio I get an error:
Message: Test method Microsoft.Dynamics365.UIAutomation.Sample.Web.CreateContact.WEBTestCreateNewContact threw exception:
System.Exception: Login page failed.
This happens after a successful sign on.
Utilizing Chrome Driver - ChromeDriver 78.0.3904.70
I did some research and the closest issue that was created that is similar to my issue it this one - https://github.com/microsoft/EasyRepro/issues/576.
Expected behavior
After successful login, test should continue.

Hi,
I was having the same issue and that was because of Unified Interface Only experience.
Try to disable by going to https://admin.powerplatform.microsoft.com/support > 'environments' > select the desired CRM and click 'settings' > 'behaviour' > disable 'use only unified interface'.
Then try to run the tests again.
Hope that helps!

Hi,
I was having the same issue and that was because of Unified Interface Only experience.
Try to disable by going to https://admin.powerplatform.microsoft.com/support > 'environments' > select the desired CRM and click 'settings' > 'behaviour' > disable 'use only unified interface'.
Then try to run the tests again.
Hope that helps!

Hi DanicCo77,
I disabled this and reran the test again with the same results. What's surprising is that the credentials are accepted and logged in. It's then on the main (dashboard) screen for a minute, before closing the browser and throwing the error in Test Explorer.

Ok, at least you got logged in.
Now it looks like it doesn't recognize the fields. Is the CRM you're testing in english?
Can you please provide a print-screen of the file packages.config in Microsoft.Dynamics365.UIAutomation.Sample?

Just a pointer, I've even tried using the admin credentials, with the same results.

It looks OK.
Is the CRM you're testing in english language?

Yes it is in English.

DaniCos77,
You previous solution of changing the 'use only unified interface' to disable worked. It just took a while for the change to take effect. Thank you!
What i did notice though was the test was ran in the Legacy app mode not in the UI.

Glad to know :)

I had the same issue... I think it was because we were running the test: Microsoft.Dynamics365.UIAutomation.Sample.Web.CreateContact.WEBTestCreateNewContact (classic web) rather than the UCI test: Microsoft.Dynamics365.UIAutomation.Sample.UCI.CreateAccountUCI.UCITestCreateAccount.
When I ran the UCI test, the test proceeded after successful login, without having to change the 'use only unified interface' setting.

Hi @aeonnovagithub, I think you has solved the problem. Great! Can you close this Issue?


Ignoring sub-folders

Hi, beginner here and this is my first issue ever so I apologize if I'm doing this wrong.
I loved your tool, but I got a little confused on how to tell it to ignore sub-folders. Like, what if I want to ignore the node_modules in the server folder, but not the node_modules in the client module?
Just a minor issue. The script worked wonders, thank you!

Hi @Dian-New-Dev,
Thank you for bringing up this issue, and welcome to GitHub!
Initially, the script was designed to handle ignores at the main folder level, so sub-folder ignores like the one you mentioned weren't accounted for. Thanks to your feedback, I've updated the code to allow specifying both main and sub-folder directories in the folders_to_ignore variable.
To ignore specific sub-folders, such as server/node_modules, you can now pass the path from the main directory (e.g., "server/node_modules"). This update should provide more flexibility in managing folder ignores.
I've committed the changes here: Commit 5292207. Feel free to check it out, and let me know if you have any further questions!


Flutter / SDK Manager issues.

flutter doctor -v: C:\Users\busin>flutter doctor -v [√] Flutter (Channel stable, v1.12.13+hotfix.8, on Microsoft Windows [Version 10.0.18363.720], locale en-AU)
• Flutter version 1.12.13+hotfix.8 at C:\src\flutter
• Framework revision 0b8abb4724 (7 weeks ago), 2020-02-11 11:44:36 -0800
• Engine revision e1e6ced81d
• Dart version 2.7.0
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at C:\Users\busin\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
X Android license status unknown.
Try re-installing or updating your Android SDK Manager.
See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed      instructions.
[√] Android Studio (version 3.6)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 44.0.2
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b04)
[!] VS Code (version 1.43.2)
• VS Code at C:\Users\busin\AppData\Local\Programs\Microsoft VS Code
X Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[!] Connected device
! No devices available`
C:\Users\busin>flutter doctor --android-licenses A newer version of the Android SDK is required. To update, run: C:\Users\busin\AppData\Local\Android\sdk\tools\bin\sdkmanager --update
When I try to upgrade sdk it gives me: sdkmanager --update 'sdkmanager' is not recognized as an internal or external command, operable program or batch file.

Hi, so I think the problem is because you run the --update command in a directory other than the one where the sdkmanager batch file is present and you don't have the directory in PATH variable.
Try to cd into the directory where sdkmanager file is present and then run the command.

Duplicate of #51712
Please check out this solution

hi, when i try to do that it comes up with this: C:\Users\busin\AppData\Local\Android\Sdk\tools\bin>sdkmanager --update Exception in thread "main" java.lang.NoClassDefFoundError: javax/xml/bind/annotation/XmlSchema         at com.android.repository.api.SchemaModule$SchemaModuleVersion.<init>(SchemaModule.java:156)         at com.android.repository.api.SchemaModule.<init>(SchemaModule.java:75)         at com.android.sdklib.repository.AndroidSdkHandler.<clinit>(AndroidSdkHandler.java:81)         at com.android.sdklib.tool.sdkmanager.SdkManagerCli.main(SdkManagerCli.java:73)         at com.android.sdklib.tool.sdkmanager.SdkManagerCli.main(SdkManagerCli.java:48) Caused by: java.lang.ClassNotFoundException: javax.xml.bind.annotation.XmlSchema         at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)         at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)         at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)         ... 5 more

@esam22
Manually install sdk tools from Android studio
Please check out this solution


Add async experimentation

Hi, how are you? I'm using your code to test one library I've been working on. I did some experimentation using asynchronous calls to WebDreiver, and for company "ashbyhq" it was possible to reduce the execution time from 11.82 seconds to 8.55 sec. I used 5 instances of ChromeDriver. I'm sending this PR just to show you an example of the implementation using this library. Feel free to ignore/reject it :)
If you want to test the PR, you have to start chromedriver as a server and run crawler like this
$ ./chromedriver --port=9999

Starting ChromeDriver 113.0.5672.63 (0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}) on port 9999
Only local connections are allowed.
Please see https://chromedriver.chromium.org/security-considerations for suggestions on keeping ChromeDriver safe.
ChromeDriver was started successfully.

run the crawler
$ python crawler_async.py
ashbyhq] Scrap page: https://jobs.ashbyhq.com/kiln.fi
[ashbyhq] Scrap page: https://jobs.ashbyhq.com/dune
[ashbyhq] Scrap page: https://jobs.ashbyhq.com/Conduit
[ashbyhq] Scrap page: https://jobs.ashbyhq.com/paradigm
[ashbyhq] Scrap page: https://jobs.ashbyhq.com/syndica
[ashbyhq] Found 4 jobs on https://jobs.ashbyhq.com/Conduit
location Engineering • San Francisco, Remote • Full time
location Engineering • San Francisco, Remote • Full time
[ashbyhq] Found 11 jobs on https://jobs.ashbyhq.com/syndica
location Engineering • San Francisco, Remote • Full time
location Engineering • San Francisco, Remote • Full time
...

Time: 8.55 sec

Thank you!

Thanks. Let me know in case of any issue or suggestions, please!


Not a obfuscator`

This inst a obfuscator, it does not modify origin code it legit packs it

Same thing isn't it mate, after packing you can't see the origin code because there isn't a way to unpack

Same thing isn't it mate, after packing you can't see the origin code because there isn't a way to unpack

This can be uncompiled in seconds,
Obfuscation is modifying the origin code, not stacking it down and down.


Pre-flight OPTIONS only set on POST

#61 fixed this on only thePOST requests. Investigate if this is required on all VERBS..

Yep, this is required on all verbs..


verification: emit mesage as Verilog comment

Contributor Checklist

[x] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?
[x] Did you add text to be included in the Release Notes for this change?

Type of Improvement

backend comment generation

API Impact

no API impact

Backend Code Generation Impact

this adds the message included with a verification statement as a Verilog comment to the Verilog code

Desired Merge Strategy

squash

Release Notes

Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
[ ] Did you review?
[ ] Did you check whether all relevant Contributor checkboxes have been checked?
[ ] Did you mark as Please Merge?

There are cooler things we could try that would actually display the message once an assertion fails, but this simple change at least gives people a better idea of what the assertion is supposed to do if they look at the generated Verilog.

Two questions:

Any reason to not go with $display or $error output with this PR?
The comment mechanism is pretty close to a DocStringAnnotation. Can this be unified with that eventually?

I don't know much about SVA, but the Dolous website shows assert being written this way. It seems pretty straightforward to emit a else $error(Assertion with message '<message>' was false) or something. Usage of $display I think is wrong and would print everytime the assertion doesn't fail?
(2) is obviously blocked by a solution to target verification statements. I'm cool with getting a solution in before that, but it would be good to have some thought about if we want to unify this and a plan for how to unify it. Generally I'm in favor of a single mechanism to add comments.

1. Any reason to not go with `$display` or `$error` output with this PR?

This was supposed to be the quick & easy PR that improves things a bit with no generated code changes. As I mentioned in my first comment, there are better things we can do, but they needs more considerations and testing with different tools.

Also: I don't think $display and $error are going to work with the formal tool.

Good point. It's definitely way more informative than the current status.
We do have runway before 1.4.0. Do you think there's time to get something like https://github.com/freechipsproject/firrtl/pull/1725 in place for the SystemVerilogEmitter to provide some parity before then?

We do have runway before 1.4.0. Do you think there's time to get something like #1725 in place for the SystemVerilogEmitter to provide some parity before then?

I don't think that display will work for any formal tools and we will probably have to take some tool specific approaches:

for open source yosys I think putting the assertion message at least into a Verilog comment is as good as it gets
for commercial tools we can switch to emitting a named property and a print on assertion failure once we are able to name statements (which is blocked on https://github.com/freechipsproject/firrtl/issues/1679)

For simulation tools you can probably just run the pass from #1725 and it should work as expected.


Add "Preloader" to the website

Preloader is the animation that shows up before the website loads up.
For reference :  Click Here
Current Behaviour: There is no preloader for the website.
Expected Behaviour: Add a preloader to the website. There should be the logo of HealhUb at the preload.
Get the logo from here:
https://github.com/skpandey885/HealhUb/blob/main/assets/logo.png

I  want to work on this issue

I want to work on this issue under JWOC

I want to work on this issue under JWOC

I want to work on this issue

Go ahead.

Hey @ZaidMujahid @Kaggrov . We are following the First Come first serve basis. Visit the website and see what functionality you can improve and then create the issue.

@Ankit62042 What is the update?

I'm Working on it !! Just give me some time till 12:00

Hii, I shared a video on discord of pre-loader that I created

@Ankit62042 Where's the PR?

PR Sent

@Ankit62042 The preloader is not working.

@ZaidMujahid Are you interested in taking up this issue?

@skpandey885 Can I try?

@skpandey885 Can I try?

Go for it.


What does PE look like within OpenID Connect?

https://github.com/decentralized-identity/presentation-exchange/issues/96
@glcohen @pamelatech if you have OpenID interoperability examples, we would really appreciate them.

{   "response_type": "id_token",   "response_mode": "form_post",   "client_id": "https://myrp.net/request",   "redirect_uri": "https://myrp.net/verify",   "scope": "openid did_authn",   "state": "ao8kdI_WHrA5Qw",   "nonce": "sJQObHuzkjZ2FA",   "iss": "did:ion:EiD9lDdWcAGXJDaUbPSlW94feOUl7ipcbIg6maBjwg2lUg",   "registration": {     "client_name": "Decentralized Identity Team",     "client_purpose": "Give us this information please (with cherry on top)!",     "tos_uri": "https://myrp.net/tos.html",     "logo_uri": "https://myrp.net/images/did_logo.png"   },   "iat":<PHONE_NUMBER>,   "exp":<PHONE_NUMBER>,   "presentation_definition": {     "input_descriptors": [       {         "id": "IdentityCardCredential",         "schema": {           "uri": [             "IdentityCardCredential"           ],           "name": "Decentralized Identity Team",           "purpose": "Give us this information please (with cherry on top)!"         },         "issuance": [           {             "manifest": "https://portableidentitycards.azure-api.net/dev-v1.0/536279f6-15cc-45f2-be2d-61e352b51eef/portableIdentities/contracts/IdentityCard"           }         ]       }     ],     "name": "Decentralized Identity Team",     "purpose": "Give us this information please (with cherry on top)!"   } }

to discuss 10/7: is this different from #92 ?
FYI @csuwildcat @brentzundel

dupe of #92


Add get_blob_properties method to Blob

This PR adds the get_blob_properties method to Blob.
It also changes the test_e2e feature to require other features (since otherwise the adls2_gen2 feature was missing and e2e tests would not compile).
I wasn't completely sure whether the request builder JSON was autogenerated or required for something - is there some documentation about those files somewhere?
Closes #72.

I wasn't completely sure whether the request builder JSON was autogenerated or required for something - is there some documentation about those files somewhere?

It's used to scaffold its relative rs file (the scaffolding tool is bpb but that's about to change). It's not mandatory but it's nice to have for further enhancements.


Create Review VM from the Airlock UI screen

Description
As a TRE Airlock Manager
I want to have a button next to the Airlock Request to spin up the Review VM
So that I don't have to remember which workspace and workspace service to create it in and I don't have to copy SAS URL
Implementation proposal
Configuration
We propose to add an additional nested block to Research Workspace (=base workspace) properties for configuring the Airlock Review VMs.
This could look like this:
{
    "id": "<id>",
    "templateName": "tre-workspace-base",
    "templateVersion": "0.3.28",
    "properties": {
        "enable_airlock": true,
        "airlock_review_config": {
            "import": {
                "workspace_id": "<guid>",  // ID for the already deployed Import Review Workspace to use for reviews
                "workspace_service_id": "<guid>",  // ID for the already deployed Workspace Service to deploy review VMs to
                "user_resource_template_name": "guacamole-azure-import-reviewvm"  // the user resource template to create
            },
            "export": {
                "workspace_serivce_id": "<guid>",  // ID for the already deployed Workspace Service to deploy review VMs to
                "user_resource_template_name": "guacamole-azure-import-reviewvm"  // the user resource template to create
            },
        },
    // other properties as normal
    },

The export section does not have workspace_id because for export it will always be the Research Workspace the data is exported from.
The corresponding resources need to already be deployed before this configuration can be set, which is why we should recommend users to issue an update on an existing resource if they wish to configure Airlock Review.
UI screens
We then propose to add a button / screen on the UI next to the Airlock Review requests (@jjgriff93 to update this section once the designs are ready):

The button will be greyed out if the above configuration is not set for the workspace, with a message for the user to ask their TRE admin to configure this for them.
If there already is a review VM created for the request by this user, it could show a link to that created review VM.
If the review VM was created by another user, it could show a message saying that another user is currently reviewing this request. For this, the review_user_resources field in Airlock Request object is used (see below).
API endpoint
Add a corresponding API endpoint that will create a review User Resource
/api/workspaces/{workspace_id}/requests/{airlock_request_id}/create-review-user-resource
This will accept the Research Workspace ID and Request ID as parameters, from the properties outlined above will determine in which Workspace and Workspace Service to create them in, will create the user resource and return the Operation to watch, which will be tracked in the usual way on the UI.
The API endpoint will also update the Request object with the information on this VM:
{
    "id": "45e1d9d8-f669-47bf-b0eb-a11bb34aa456",
    "workspaceId": "26f41c2a-2bed-4f78-a745-c41ca8f326fe",
    "requestType": "export",
    "files": [
        {
            "name": "research_result.txt",
            "size": 7
        }
    ],
    "review_user_resources": [
        {
            "id": "<guid>",
            "workspace_id": "<guid>",
            "workspace_service_id": "<guid>"
        }
    ],
    // other properties as normal
}

Acceptance criteria

[ ] #2736
[ ] #2737
[ ] #2738

Feels like a nice idea.
Question on how this displays in the create/update workspace UI? Are these fields required? Only if airlock is enabled? I won't know the workspace service ID when creating the workspace. Can we have a think through the user flow for configuration?

Question on how this displays in the create/update workspace UI? Are these fields required? Only if airlock is enabled? I won't know the workspace service ID when creating the workspace. Can we have a think through the user flow for configuration?

The idea was that the workspace is created without these fields, and they are not required: as you said, we can't provide the IDs yet when creating the workspace.
The flow would be this:

TRE Admin deploys a Research Workspace with Airlock enabled, and a Guacamole inside that workspace
TRE Admin deploys a separate Import Review workspace, and a Guacamole inside that workspace
When they have all that, they issue a PATCH request to the Research Workspace with this information:

{
  "properties": {
    "airlock_review_config": {
      "import": {
        "workspace_id": "1c79...23f71",
        "workspace_service_id": "0e4...745",
        "user_resource_template_name": "guacamole-azure-import-reviewvm"
      },
      "export": {
        "workspace_service_id": "ca8...d64",
        "user_resource_template_name": "guacamole-azure-export-reviewvm"
      }
    }
  }
}

(We will document all this, of course!)

I think this won't be available on the create / update workspace UI, as these will be in property bag, but we could think to add it there? @jjgriff93 @damoodamoo

Could they be hidden on create and visible on update/patch?
If they aren't set then the create review vm would not be visible?
Need to make sure they are validated on patch to be valid Ids.

Could they be hidden on create and visible on update/patch?

Potentially? May need to add a new field type for that though (similar to updateable that we already have)

If they aren't set then the create review vm would not be visible?

Yes, that's the idea.

Need to make sure they are validated on patch to be valid Ids.

Hmm yeah I think that's doable, we can add that logic either in API or even on the UI, when the user inputs these fields

I would imagine that they'll be present in the UI - we currently don't have a way to hide things for create but show only for update. We could do that down the line - but in the near term we would just add some description on the fields to let the user know they're optional and can be updated later.
Would be reticent to add special code to validate that the IDs are correct - I think we could add a regex in the template to make sure it's a guid, but not that it relates to a valid resource. That's up to the TRE admin to get right, and if it's not right then the error coming back from a review VM creation would tell them about it.

Added proposed UI designs


custom templateUrl appears behind custom windowTemplateUrl in $modal

I've made a plunker here: http://plnkr.co/edit/xv0LuJ1kqJ1t0BBsP3Ue?p=preview
In my application this is happening as well. Although it appears to work fine in version 0.12.0. For some reason it seems as though the presence of the custom windowTemplateUrl causes the the templateUrl to be hidden.
I could have easily missed something in my implementation. I tried to make the plnkr as simple as possible. Let me know what you think.
-Steven

This looks like because you didn't include the other necessary components for your custom template - here is a working version of your Plunker.
If you are going to override the window template, check out the original template https://github.com/angular-ui/bootstrap/blob/master/template/modal/window.html .


CI is broken on Node 12

Describe the bug
On main, CI is broken because we use rimraf which uses a conditional chaning operator. This is only available in Node >= 14: https://node.green/#ES2020-features-optional-chaining-operator-----
I think our options here are either:

Drop support for Node 12. It is now end of life and not maintained, so I think this would be reasonable: https://endoflife.date/nodejs
Downcompile the rimraf library to remove the optional chaining operator
Replace the rimraf library with something else that doesn't use optional chaining

https://github.com/dotansimha/graphql-code-generator-community/actions/runs/4474891183/jobs/7863820721
Expected behavior
As a contributor, I expected the CI on the main branch to be passing

We already dropped support for Node.js 12 in graphql-code-generator. We should also drop it here and do a new major release. Any help is welcome! https://github.com/dotansimha/graphql-code-generator/releases/tag/release-1675419690826

dropped support for node 12 in new release https://github.com/dotansimha/graphql-code-generator-community/releases/tag/release-1695677511578


Include Ingress annotations for HTTPS backend

Out of the box calls to the Elastic client ingress can fail with the following error: received plaintext http traffic on an https channel, closing connection
See for example: https://discuss.elastic.co/t/elasticsearch-with-ingress-received-plaintext-http-traffic-on-an-https-channel/246549
To prevent this, an annotation is necessary that depends on the Ingress Controller used (nginx-ingress or ingress-nginx)
Issue #, if available:
Description of changes:
Test Results:
Note: If this PR is related to Helm, please also update the README for related documentation changes. Thanks.
https://github.com/opendistro-for-elasticsearch/opendistro-build/blob/master/helm/README.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Hi @Purneau,
Thanks for submitting the PR. We will review and post our comments.
Thanks.

Hi @Purneau,
Thanks for submitting the PR. We will review and post our comments.
Thanks.

Thanks @Purneau the PR is merged for now.

Thanks @Purneau the PR is merged for now.


Background text in Address box suggests port 9882

Current Behavior
If you clear the Hostd > Configuration > Address box some background text in the box then shows, saying my.host.com:9882. This has lead a couple of users to announce mainnet sia on port 9882 rather than 9982.
Expected Behavior
At a minimum, the mainnet binaries should display port 9982 to remove the confusion. If you want to be cute, it should display whatever the rhp2.address port is configured as (although this would be incorrect if there is port forwarding with port switching).
Steps to Reproduce
No response
Version
v1.0.0 amd mainnet
What operating system did the problem occur on (e.g. Ubuntu 22.04, macOS 12.0, Windows 11)?
ClearOS 7.9
Anything else?
No response

Thank you for the report, we noticed the increased number of users and the wrong port and figured this was the reason 😅. The fix is already in https://github.com/SiaFoundation/hostd/pull/281 and will be in the next release!


⚠ Turnos 24x7 has degraded performance

In 13a92a7, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 825 ms

Resolved: Turnos 24x7 performance has improved in 9f0140d.


peer: Synchronous registration of gossip queries

This commit moves the gossip sync dispatch
such that it is more tightly coupled to the
life cycle of the peer. In testing, I noticed
that the gossip syncer needs to be dispatched
before the first gossip messages come across
the wire.
The prior spawn location in the server happens
after starting all of the peer's goroutines,
which could permit an ordering where the
gossip syncer has not yet been registered.
The new location registers the gossip syncer
within the read handler such that the call
blocks before any messages are read.

The gossiper already handles this case here: https://github.com/lightningnetwork/lnd/blob/master/discovery/gossiper.go#L903
When it gets a new gossip sync message, it tries to find the existing syncer. If it's able to find it, then it'll use that directly, otherwise, it'll make a new one.

Hmm, then why have InitSyncState at all?

The fallback in fetchGossipSyncer doesn't properly honor cfg.NoChanUpdates.

@Roasbeef added a commit to remove the fallback since it is no longer required, PTAL


🐞 - TuiRating min property not work correctly

Playground Link
https://taiga-ui.dev/components/rating/API
Description
On the official site in the rating component. The property min does not block the choice in any way, by setting the value of 2, you can choose 1 star. This option works with the keyboard, but it does not update immediately, but only when the unfocused
https://github.com/Tinkoff/taiga-ui/assets/34657605/12e8d22d-e34a-4879-91c5-fab881936c13
Angular version
12.2.17
Taiga UI version
3.31.0
Which browsers have you used?

[X] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[X] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

I think min was added by mistake, because rating is basically styled input type='range' and it has min. What is the use case of enforcing minimal value on rating UI?

On the other hand, we can enable it pretty easily. We just need to disable pointer events for all icons with index < min. Would you be interested in contributing a PR?

The pointer events none does not work correctly - due to disabling the star hover effect


Dreambooth Error: path_in_repo=f"concept{concept_num + 1}/{file.name}", AttributeError: 'str' object has no attribute 'name'

The string path to the uploaded images doesn't have an attribute "name" on the instance of the str class. Please see the problematic line of code here:
https://github.com/huggingface/autotrain-advanced/blob/main/src/autotrain/preprocessor/dreambooth.py#LL43C63-L43C66
You can see the image paths are passed in as an array of strings. As far as I know, str doesn't have a 'name' attribute.
Happy to PR a fix if this is indeed an error, as opposed to a config setup. I'm running this in HuggingFace, and it appears as though I've filled out all fields.
Thanks.

any updates on this?

seems go be fixed


Inferring of tab separated resources breaks when using array

Overview
Dialect inferring should do better, in particular the file extension and first line should be very good indications of the dialect, however datapackage gets confused when using arrays in tsv (presumably because of the quotes/commas).
Minimum "broken" example
pkg.json
{
  "profile": "tabular-data-package",
  "name": "datapackage",
  "title": "An example datapackage",
  "resources": [
    {
        "profile": "tabular-data-resource",
        "name": "table",
        "title": "table",
        "path": "table.tsv",
        "description": "A table",
        "schema": {
          "fields": [
              {
                "name": "id",
                "description": "An identifier representing this file, unique within this id_namespace [part 2 of 2-component composite primary key]",
                "type": "string",
                "constraints": {
                    "required": true
                }
              },
              {
                "name": "array",
                "description": "A random array",
                "type": "array"
              }
          ]
        }
    }
  ]
}

table.tsv
id	array
1	["hello", "world", "!"]

test.py
from datapackage import Package
pkg = Package('pkg.json')
table = pkg.get_resource('table')
table.read()

Traceback
CastError                                 Traceback (most recent call last)
<ipython-input-71-3b457c671ba4> in <module>
      1 from tableschema import Table
      2 table = Table('table.tsv', schema='table.json')
----> 3 table.read()

~/.local/lib/python3.9/site-packages/tableschema/table.py in read(self, keyed, extended, cast, limit, integrity, relations, foreign_keys_values, exc_handler)
    351             relations=relations, foreign_keys_values=foreign_keys_values,
    352             exc_handler=exc_handler)
--> 353         for count, row in enumerate(rows, start=1):
    354             result.append(row)
    355             if count == limit:

~/.local/lib/python3.9/site-packages/tableschema/table.py in iter(self, keyed, extended, cast, integrity, relations, foreign_keys_values, exc_handler)
    213             iterator = self.__apply_processors(
    214                 iterator, cast=cast, exc_handler=exc_handler)
--> 215             for row_number, headers, row in iterator:
    216
    217                 # Get headers

~/.local/lib/python3.9/site-packages/tableschema/table.py in builtin_processor(extended_rows)
    506             for row_number, headers, row in extended_rows:
    507                 if self.__schema and cast:
--> 508                     row = self.__schema.cast_row(
    509                         row, row_number=row_number, exc_handler=exc_handler)
    510                 yield (row_number, headers, row)

~/.local/lib/python3.9/site-packages/tableschema/schema.py in cast_row(self, row, fail_fast, row_number, exc_handler)
    273                      value)
    274                     for (i, value) in enumerate(row))
--> 275             exc_handler(exc, row_number=row_number, row_data=keyed_row,
    276                         error_data=keyed_row)
    277

~/.local/lib/python3.9/site-packages/tableschema/helpers.py in default_exc_handler(exc, *args, **kwargs)
     88     """Default exception handler function: raise exc, ignore other arguments.
     89     """
---> 90     raise exc
     91
     92

CastError: Row length 2 doesn't match fields count 0 for row "2"

Note that this can be corrected by adding a dialect to the resource (#/resources/0):
{
        "dialect": {
          "delimiter": "\t"
        }
}

But since we're using .tsv and don't have commas in the header, it really seems like this should be inferred. Instead it seems like a "csv" is assumed and you get errors. The error reported makes this very hard to debug in code that worked perfectly fine before trying to use the array type.

Please preserve this line to notify @pwalsh (lead of this repository)

Hi @u8sand
If no format is explicitly passed, then, there is no inferring - the file is parsed as csv:

https://github.com/frictionlessdata/datapackage-py/blob/52416bd5be2e146490ee91f51b80d9b2178e0070/datapackage/resource.py#L673

Tabulator, the underlying stream processing library, would need to be passed format as None in order to infer:

https://github.com/frictionlessdata/tabulator-py/blob/main/tabulator/stream.py#L329

So the bug is not that inference should be better, but that all files are parsed as CSV unless explicitly declared otherwise. You should be able to run a quick test to see that is what is happening, by setting format to None and see if Tabulator correctly detects TSV.

@pwalsh Ah I see, so format was missing all along. Thank you for this; sorry for the invalid issue.

The reason that CSV is the default is because CSV is the required data format for a tabular data package according to the spec. Passing a format gives you a loophole around this.


nix develop crashes in the VS Code Terminal on NixOS-WSL

Reproduction Steps

Create a NixOS-WSL distribution according to https://github.com/nix-community/NixOS-WSL
Open Remote Explorer in VS Code
Select WSL Targets
Connect the NixOS target
Open a terminal in VS Code
git clone https://github.com/Atry/nix-develop-on-nixos-on-wsl.git
cd nix-develop-on-nixos-on-wsl
nix develop

Then you will see the output:
Segmentation fault (core dumped)

Note that nix develop would not fail in a standalone terminal outside of VS Code:
PS C:\Users\atry> wsl

[nixos@nixos:/mnt/c/Users/atry]$ cd ~/nix-develop-on-nixos-on-wsl/

[nixos@nixos:~/nix-develop-on-nixos-on-wsl]$ nix develop

[nixos@nixos:~/nix-develop-on-nixos-on-wsl]$

Also note that nix-shell in the terminal in the VS Code would not result in core dump.

@Atry Now that FHS is no longer enabled by default, could you see whether this seg fault is now resolved?

nix develop works if FHS is disabled


Add basic setup.py

Make package installable

Hey @ebuehrle should we merge still or can it be deleted? seems stale


feat(model/clone): derive Clone for Box<dyn Model>

This builds on top of the work @louisgv did in #263.
This commit addresses the following scenario: for a service that is supposed to start multiple inference sessions based on the same model, the performance of loading the model on every request is (at least based on empirical evidence) not consistent.
This commit makes it possible to clone a model and create a new inferencing session without paying the cost of loading the model on every request.
The implementation ultimately implements Clone for Tensor by calling the share function.
The initial attempt does this because it reduces the Clone implementations for each model to deriving it, rather than having an explicit impl — the alternative would mean manually calling share for every layer and every tensor for the implemented models — happy to take this approach is it makes more sense.

Hmmm... I'm not sure about this. I think this will not generally do what users expect - it won't create an entirely new instance of the model, but will instead create another handle to the same resource.
My plan for Model was to make Clone a deep clone, so that you would have an entirely independent model (where a sufficiently-configured system could do parallel inferencing without accessing the same memory).
Would Arc::from_box work for your application? A quick test shows that
    let model: Box<dyn llm::Model> = args.model_load.load(args.generate.use_gpu)?;
    let model: Arc<dyn llm::Model> = Arc::from(model);
    let model2: Arc<dyn llm::Model> = model.clone();

seems to work as expected, and should mirror the semantics here.

The problem i see with this is that if the source model disposes it's context all "clones" you created will panic if you want to infer with them. Which could be very confusing for a user 🤔

Yeah, I think you both make a good argument against this.
The solution @philpax suggests should solve this scenario. Closing this, but creating a deep clone for a tensor would still be helpful in the future.
Thanks, both!


Filters/sort not working on any tables

None of the filter/sort functionality is working on any tables. Search does work however.

possibly related to the changes introduced in #1692 (Refactor queries to remove string interpolation)

addressed by @Bodacious in PR #1706


Script file directive to select scope during import.

Summary of the new feature / enhancement
A script can be loaded into the current scope (dot sourced) or into a new script scope (not dot sourced).  The script might not be designed to work correctly with both load methods. There should be a means in script to either use the desired scope or to raise an error if loaded into the incorrect scope (e.g., global or script).
In addition, sometimes a set of scripts need to share a scope that's not the global scope.  A module provides a single "script" scope for the module that's shared even if the module spans multiple files. Non-module scripts do not have such a shared, non-global scope.  Loading a script into such a scope would be a third choice besides using the global scope or dot sourcing into a script scope.
Proposed technical implementation details (optional)
Add an optional "#RequiresScope" directive to control the scope into which a file loads or can load. A SCOPE parameter will, if required, override the scope that would be selected by the method of the load (dot sourced or not dot sourced). A FORCE directive parameter could control if the desired scope is always selected automatically or if an error is raised if the default scope does not match that required.
#RequiresScope Default - uses the either the current or script scope as if the directive was not present
#RequiresScope Global Force - uses the global scope when loaded
#RequiresScope Current Force - uses the current scope when loaded (always behaves as if dot sourced)
#RequiresScope Script Force - uses a new scope when loaded (always behaves as if not dot source)
#RequiresScope Scripts Force - uses a non-global named scope 'scripts' to be the parent one or more script scopes.
The "Scripts" scope would have global as a parent. All scripts added using the "Scripts" directive would be added to this one scope. Basically, it's a special place to dot source scripts other than to global or into another script file's scope. It's sort of like treating one or more non-module scripts as being in a "non-module" module under global.

VSCode would not need an option to load into script source if there was a directive to control such a feature in PS.
https://github.com/PowerShell/vscode-powershell/issues/4327
As a work around for a module not "honoring" preferences, the global scope could be used to control module preferences while a single "Scripts" scope could be used to control user script preferences.  Often a user only wants their messages, not noisy messages from modules.  For some modules, it can be hard to control messaging without use of global.  The result is wrapping a module call with code to set and unset the desired module preferences.  This would not be required is all scripts has a scope for just non-module scripts.  (I suppose an extra non-global scope for all modules would work also work.  It would be a place to define preferences for all modules that can override the global preferences used by non-module scripts.)
https://github.com/PowerShell/PowerShell/issues/4568

If there is concern about controlling messaging in modules, that is already possible using global preferences.  An extra scope between global and all modules does feel like the best way to allow module preferences to be separate from non-module scripts.  If so, a new "all modules" scope could be a separate feature isolated from a directive that can force scripts to be correctly loaded into a global, script, or current scope.

I'm not a PowerShell expert.  If a module is imported into the global scope, can it still have an extra "all modules" scope between global and the module?  The scripts will still be able to access the modules cmdlets?

The script might not be designed to work correctly with both load methods.

Caveat emptor!
Scripts should do one thing and do one thing well and check for errors, but not try to predict or anticipate all the scenarios that it might be used or misused.
The sourcing mechanism is an important way of extending existing scripts, often in ways that are completely valid to the new implementor but not considered by the original script writer. It is the role of the caller to ensure each script is executed in the correct environment with correct arguments.
If you are formally distributing software to third parties, then I recommend it is always packaged as a named and versioned module so you can have the scoping controls that you describe.

In addition to what @rhubarb-geek-nz  has just said.
The problem comes when someone whose coding is poor (or malicious) demands their script isn't run in it's own scope and pollutes the parent.
As illustration I've met people who put "cls" as the first line of their scripts (part of the problem of "the job of all programs is to print stuff on the console" thinking), they delete the information which I have been keeping in my back-scroll buffer which is not theirs to mess with.
Similarly as "owner" of a scope, I'm the one who decides whether a script gets to mess with it. There are ways to see how a script is invoked and if your script contains a function, and the job of the .PS1 file is to load it is possible to see if you have been dot sourced.  A script should run in whatever scope it finds itself in. Grant some things like scripts to add functions will run perfectly, but uselessly if NOT dot sourced, but that's best tested by raising a warning based on $myInvocation when run without a dot.
Not designed to run in its own scope means something makes assignments assuming they will apply to the parent (but not necessarily the global) scope - because what's in the parent is normally readable. That's bad coding.
There are cases where we deliberately access the parent scope (e.g. I have a logging function which checks $MyInvocation from its caller so it knows which script asked for something to be logged)  if dot sourced such things won't work properly, but that is down to me to call it the right way.

Referring to my comment regarding it is the role of the caller to determine the scope, a common pattern I use in shell scripting is....
for d in $( . /etc/os-release ; echo $ID $ID_LIKE )
{
      echo do something $d
}

So my script is sourcing an operating system script to get it to execute and use its variables, but runs this in a new child process scope so it does not affect the variables in the main process. So my script remains in control, it determines the scope, and /etc/os-releases remains a simple script.
So in PowerShell a caller could source any script in a new job to get it to run in a new scope, for example.


Add Spring Doc

Add spring doc, and enabled it on management endpoint. I will update the readme for it.


EAS undefined __apply_Xcode_12_5_M1_post_install_workaround

Build/Submit details page URL
No response
Summary
Using EAS and the latest version of ReactNative will break iOS build. This is because react-native 0.73 removed the call __apply_Xcode_12_5_M1_post_install_workaround.
Managed or bare?

Fix with: npx expo install --fix
Found outdated dependencies
Error output
No response
Reproducible demo or steps to reproduce from a blank project
Update to the latest react native version "react-native": "0.73.1", and you will reproduce the error. If I try npx expo prebuild with the same cocoapod version we get from EAS then I can reproduce the error.
[!] An error occurred while processing the post-install hook of the Podfile.

undefined method `__apply_Xcode_12_5_M1_post_install_workaround' for #<Pod::Podfile:0x00000001086417d0 @defined_in_file=#<Pathname:

I tried with an update version of CocoaPod and I'm getting the same error. On internet I found we can just remove the following call

__apply_Xcode_12_5_M1_post_install_workaround(installer)

from Expo Podfile

Can you send me the URL of your build?

Hi @szdziedzic... any way I can share this with you in private?

Yeah, of course, you can for example DM me on Twitter https://twitter.com/szdziedzic. If it doesn't work for you please DM me using Discord, my username is also szdziedzic.

I am having the same error, locally using Expo 49.0.21 with RN 0.73.2.
Running eas build --profile development --platform ios and seeing Runtime version exposdk:49.0.0 on the eas build.

Do you have not gitignored Podfile in your project?

I do not even have a .gitignore in my project.

I have same issue and here is my build link
I don't have a Mac and I cannot test locally (I don't have a Podfile).
@szdziedzic Could you please check? 🙏🏻

I opened another issue here

https://github.com/expo/eas-cli/issues/2194#issuecomment-1904315915


0 Valid | 0 Invalid ???

everything run perfect but it shows me ERRORS and 0 valid | 0 invalid ???

Did you follow the instruktions in the readme file?

Did you follow the instruktions in the readme file?

I did these steps from requirements and its work.
pip install colored
pip install discord_webhook


Adding image to Twitter meta data

Fix for #12958. Twitter is not currently pulling in an image.

/lgtm
/approve


fix: fix dartls semantic token out of range error (#395)

fix #395

This will lead to more issues(see #395), thus I will close this pr.


Bleeding happens for longer, but the amount of damage it does is significantly reduced.

About the PR

The MaxBleedAmount has been reduced to 18.5, and the BleedReductionAmount has been reduced to 0.4. This makes the theoretical max time you will bleed (after you have stopped getting attacked) about 231.25 seconds, increased from the previous 200 seconds, in return however the amount of damage a player will take from bleeding has been reduced from 1, to 0.75, per update. In addition the BloodLossThreshold has been reduced from 0.9 to 0.85.
In theory this should make it so you have far more time to get medical attention, while taking less damage. This should also make it less likely that you will bleed when you get into a fight. (Assuming you win relatively cleanly).
So in total if I have numbers correct, you have about 30 more seconds to seek medical attention, while taking about 12% less damage in total. Please feel free to correct me on that, I am not entirely sure it is correct.
Media

[ X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

tweak: Bleed reduction amount changed from 0.5 to 0.4.
tweak: Max bleed amount changed  from 20 to 18.5
tweak: Blood loss threshold changed from 90% to 85%
tweak: Player blood loss damage for silicon changed from 1 to 0.75

Bleed chance needs to be dropped significantly but I need to try it ingame myself.

Specifically:

Simplemobs pretty much can't get medical aid and so are guaranteed to just die after any fight.
Forcing everyone to carry gauze + blood packs on them 24/7 is a bad meta.

Will do.

pretty sure you are all forgetting about the "critical chance", you know that small % weapons have to straight up remove X% of their damage as blood. there is nothing as bleed chance, all weapon increase bleedrate depending on their damage type (slash damage being the higher at 20% of their damage as bleedrate)

You seem to only have changed the bloodloss damage of silicons unless I missed something. You'll want to do this via the base mob

also as painful as this sounds, some species have the value defined in their YML as well, which will override the base mob. You can (if I remember correctly) remove those lines so they just inherit from the base mob... I think the slime for example has the bloodloss damage defined as 1 for some reason

NPCs/pets.yml:        Bloodloss:
NPCs/silicon.yml:        Bloodloss:
NPCs/simplemob.yml:        Bloodloss:
NPCs/slimes.yml:        Bloodloss:
Player/silicon.yml:        Bloodloss:
Species/base.yml:        Bloodloss:
This is every single one I will look through and change. If you have any specific requests just put them here... I guess? Honestley not that bad. Though I'm thinking slime could have a different blood loss value cos slime blood maybe depletes faster? Idk.
The ones grepped with a Bloodloss value not on this list are skeleton and NPCs/Player as that looked different.

Superceded by https://github.com/space-wizards/space-station-14/pull/17528 which in hindsight should've been frozen.


ufunc 'subtract' cannot use operands with types dtype('int64') and dtype('<M8[D]')

您好，我用自己的时序数据， 一列17000行的数据（人数随时间的变化预测），处理数据采用以下代码。
出现了错误：ufunc 'subtract' cannot use operands with types dtype('int64') and dtype('<M8[D]')
请问可能是什么问题，谢谢！
python scripts/data_preparation/mydata/generate_training_data.py
raw time series shape: (17000, 1, 1)
number of training samples:11895
number of validation samples:1699
number of test samples:3399
mean (training data): [[[124.47152696]]]
std (training data): [[[140.87926682]]]
Traceback (most recent call last):
File "/home/x/BasicTS-master/scripts/data_preparation/mydata/generate_training_data.py", line 169, in
generate_data(args)
File "/home/x/BasicTS-master/scripts/data_preparation/mydata/generate_training_data.py", line 73, in generate_data
df.index.values - df.index.values.astype("datetime64[D]")) / np.timedelta64(1, "D")
numpy.core._exceptions._UFuncBinaryResolutionError: ufunc 'subtract' cannot use operands with types dtype('int64') and dtype('<M8[D]')

When generating the time in day and day in week features, you need to write code according to the format of your own dataset. It appears that your dataset does not follow the same format as METR-LA/PEMS-BAY. Maybe you can refer to the script of PEMS04.


cmd/go: tool pprof gives no samples

Title says it all. Here is evidence.  Thanks!
What version of Go are you using (go version)?
go version devel +baf3eb1625 Tue Mar 6 01:11:26 2018 +0000 darwin/amd64
Does this issue reproduce with the latest release?
Not tested.
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/r/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/r"
GORACE=""
GOROOT="/Users/r/go"
GOTMPDIR=""
GOTOOLDIR="/Users/r/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/bf/qmf6xmzn7vs1gzv6g7mq_wfr0004fc/T/go-build412122499=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?
See above.

The samples are there, but the inuse_space default for the memprofile is... unfortunate. It can be changed using the sample_index command.
$ go tool pprof fmt.test mem.profile
File: fmt.test
Type: inuse_space
Time: Mar 19, 2018 at 9:51am (CET)
Entering interactive mode (type "help" for commands, "o" for options)

(pprof) top5
Showing nodes accounting for 0, 0% of 0 total
      flat  flat%   sum%        cum   cum%

(pprof) sample_index = alloc_space

(pprof) top5
Showing nodes accounting for 11051.10MB, 94.73% of 11666.12MB total
Dropped 22 nodes (cum <= 58.33MB)
Showing top 5 nodes out of 33
      flat  flat%   sum%        cum   cum%
 9026.02MB 77.37% 77.37%  9838.06MB 84.33%  fmt.Sprintf
  676.52MB  5.80% 83.17%  2286.14MB 19.60%  fmt_test.BenchmarkSprintfHexBytes.func1
  655.52MB  5.62% 88.79%   655.52MB  5.62%  fmt_test.BenchmarkFprintfBytes
  359.03MB  3.08% 91.87%   359.03MB  3.08%  reflect.mapiterinit
  334.01MB  2.86% 94.73%  1009.05MB  8.65%  fmt_test.BenchmarkSprintfBytes.func1

I tend to do go tool pprof -alloc_space (but apparently those flags are legacy?)

/cc @adg

Related: https://github.com/google/pprof/issues/182
Could we make pprof require a flag for memory profiles indicating which kind is wanted instead of defaulting to inuse_space (which is almost never what I want)? The default seems to be a source of significant, persistent confusion.

For live server profiling inuse_space is more meaningful than the alloc_space.
Moreover, memory profiling libraries for other languages (e.g. C++) often choose to report only inuse_* equivalent metrics.

What about falling back to alloc when inuse is empty? This almost always
happen when profiling microbenchmarks.
On Mon, 19 Mar 2018, 21:07 Hyang-Ah Hana Kim<EMAIL_ADDRESS>wrote:

For live server profiling inuse_space is more meaningful than the
alloc_space.
Moreover, memory profiling libraries for other languages (e.g. C++) often
choose to report only inuse_* equivalent metrics.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/24443#issuecomment-374353502, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADa683jwhNLoPwgjmHOHr4LQMvURIzTZks5tgA_3gaJpZM4Svk1h
.

For live server profiling inuse_space is more meaningful than the alloc_space.

@hyangah this doesn't match my experience. I run memory profiles on live servers with alloc_space more often than with inuse_space. The most common reason that I run a memory profile is as part of performance optimizations and reducing allocations is a really common optimization. inuse_space is useful for debugging leaks (and, rarely, surprisingly-large-but-not-growing heaps), which I do less often.
This might be different from C++ where it's easier to write memory leaks.

@cespare not only memory leak. inuse_space is one of the first places to look into when optimizing the memory usage in stable state or comparing multiple different instances with different configuration.  alloc_space is of course useful for allocation optimization.
For benchmark or test or short running programs, this doesn't make much - why do we care about the inuse_space from the last GC after the end of the program, right?  @rauls5382 and @aalexand, is there any way to tell pprof to choose alloc_space over inuse_space for such profile data? For example, what do you think about recording preferred value sample index in the profile, or just dropping inuse_space samples from benchmark or test generated profile out?

I'd settle for a print statement conditioned by no output that suggests trying another index and a way to find out what they are.

@hyangah default_sample_type field in the profile can be used to specify the metric to display by default. See https://github.com/google/pprof/blob/e8d30eee164b66e3e349506f2bd220395cd2c9d1/proto/profile.proto#L82.

To echo the other discussions here, I think inuse_space is more useful for long-running servers than alloc_space, so if the default metric is going to change for anything other than the local "go tool" runs, please let users know in advance. I'd opt against that since alloc_space is currently cumulative since program start which makes it difficult to aggregate across different replicas of a server or over time unless some custom normalization is applied.

Thanks @aalexand
I looked into a way to set the default_sample_type differently for memory profiles produced during test but it is trickier than I hoped. What I can think of are either 1) change runtime/pprof.WriteHeapProfile to accept  an option, or 2) use a magical environment variable so if it's set mark alloc_space as the default_sample_type. None of them seems like a minor change to me.
My PR to add a print statement in case of zero sample was merged to upstream. I will try to update the vendored version of pprof as well.
The change 101677 is to additionally embed comments in the generated profile output - they explain what those different measurement types are.

One thing we could do is introduce a new named profile that means "heap allocations for all time" and make it the same as the regular heap profile but with a different default. Then -memprofile can write that new profile out instead of the old one.
Go runtime/pprof.WriteMemProfile is equivalent to runtime/pprof.Lookup("heap").WriteTo, so we'd just have a new name "allocs" or something like that, which is almost exactly the same output, with a different default. Then you can ask for it from running servers too.

/cc @hyangah see what you think of previous comment

SGTM


Precompile and reuse regular expressions

This pull request proposes a small performance improvement. Compilation of a regular expression pattern is a relatively "heavy" process. Since we use the same pattern in the loop it's possible to just compile it once and then re-use it. The other notable change is the upgrade of the JUnit to the latest version from 4.x branch. Since the functionality was not changed, the pull request doesn't have any changes to the tests.

@cdimascio could you please have a look? Thank you!

@all-contributors add @c00ler for code


Incompatible with Fresh Animations Resource pack

Version: 1.19.2
This mod causes the Sodium setup of Fresh Animations to not work. All mob 3d models have default textures and animations, as well as white eyes instead of animated eyes.
Mods used:
CEM S8 0.7.1
Animatica 0.5
Mod Menu 4.1.2
Complete Config 2.1.0
Cloth Config 8.2.88
Entity Texture Features 4.3.1
Resource packs used:
Fresh Animations S8 1.7
Fresh Animations Addon S8 1.7

(Since this mod was just a fun mod created for a ModFest I understand if you don't want to put time into fixing this)

Thats just a problem with fresh animations not this mod....


Use a single venv path across deployment script.

Use this path in setup_dependencies too for simplicity and consistency.

r+wc

@akatsoulas PR updated

r+


Time zone improvement 1: Simple guess local time zone

What have you changed? (mandatory)
There is an issue in chrono that chrono::Local can be very slow.
According to my own benchmarks, the best effort based on glibc's localtime_r is still 1x slower than using chrono::FixedOffset or chrono_tz::Tz. So the best approach is to bypass and totally not calling glibc's localtime_r. This PR is one of these solutions, which is, guessing the name of current time zone and use it (mostly it should success) to construct a chrono_tz::Tz.
I tried very hard, spent whole day trying to work on a solution that based on parsing /etc/localtime instead of guessing time zone name, but failed to write a code passing rustc compiler that meets the following both:

does not duplicate existing chrono_tz code logic.
does not introduce more overhead compared to current one when using chrono_tz::Tz
does not eliminate current chrono_tz functionality.

The difficulties are:

A &'static str is used in timezone rules by hardcoding in chrono_tz, but for dynamically loaded timezone rules, it cannot be &'static str.
A &'static [...] is used to contain all timezone rules in chrono_tz, but for dynamically loaded timezone rules, it cannot.
Some rustc bugs when trying to make a generic trait over lifetimes, etc.

Maybe @BusyJay can help work it out.
Drawback:

The "local" time zone will not be changed any more after starting TiKV even if user changes it, unless TiKV is restarted.

There might be some case that time zone name cannot be successfully guessed, for example, /etc/localtime is copied instead of linked. In this case, time zone name cannot be guessed.

This is time zone improvement 1, because I would like to further work on a fix to improve chrono::Local's performance to be not so bad. As said previously, the best effort can be just 1x slower.
What are the type of the changes? (mandatory)

Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)
Not yet.
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)

/run-integration-tests

/run-integration-tests

Since we are going to infer IANA time zone name, we decided to implement it at TiDB side to be more sound. Closing.


[Aqara] Aqara Smart Dimmer Controller T1 Pro

Aqara Smart Dimmer Controller T1 Pro

Is it correct to write the code by creating a new file in "/drivers/SmartThings/zigbee-switch/src/preferences.lua" path?

Yes. I think that would work.

Yes. I think that would work.

OK, I updated. Please review my code.


Fixed test cases for windows.

https://jira.d2iq.com/browse/D2IQ-65487

@asekretenko please review

@greggomann or @bmahler have you permissions to land this?


[WIP] Cook CLI and python client

First pass on Cook CLI and python client. Looking for high level feedback; more documentation to follow.

Please create job and instance classes in the cook scheduler api that will re-pull data when needed (i.e. a call to get status will need to re-query, a request for cpus wouldn't).The goal is to make the api a little more user friendly. You can leave the more functional version of the api for users that need finer grained control of when requests are sent.

Are there features in click that you specifically needed to build the api or are you just most comfortable in it?
I should have mentioned before, we generally choose to use argparse. If there is no specific feature that the api relies on, please switch to use argparse for the sake of conformity.

is this PR still in progress? can we prioritize getting a first pass merged then pushing to another Cook dev to complete style & docs comments from DP.

I'm working on getting this functioning and merged

Please ignore the "approved these changes" - wrong PR

Moved these changes into PR #357 and others to come