Add variables in custom annotations and labels

Add for custom annotations and labels variables, as in this example email:
http://docs.graylog.org/en/2.5/pages/streams/alerts.html#email-alert-notification
Now this don't work.
https://i.imgur.com/9BslOJn.png
https://i.imgur.com/IjzCELz.png

I've added some code for the first draft inside a feature branch. It works as expected. You can use variables inside custom annotations and labels like this: "mystreamtitle=${stream.title};myresultdesc=${check_result.resultDescription};mytriggeredat=${check_result.triggeredAt};mystreamid=${stream.id};mystreamdescription=${stream.description};myalertconditiontitle=${alertCondition.title};myalertconditiondesc=${alertCondition.description};mytriggeredcondition=${check_result.triggeredCondition};".
I'll add some more tests tomorrow to ensure that using the template engine will not cause side effects.

Can we also get ${message.message} on which the alert was triggered as variable?

Can we also get ${message.message} on which the alert was triggered as variable?

Well, this should be possible as in the E-Mail-Callback.
When you use this as value:
${foreach backlog message}${message} ${end}
it should append all messages matching your condition to a maximum you have defined.
So when you only have one matching message there should only be one written to your annotation.

Thanks!

@StefanHufschmidt
Hey. Is this functionality not yet added to any release?

@jidckii sorry for the delay, I think @jlnshr will take a look at it now and it should be released within the next hours.

Merged into master, released with version 1.2


Edit hdinsight-connect-excel-power-query.md

Edit complete.
Please make sure that the information in the last two screen shots is approved for public release.

Hi @ShawnJackson, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (v-shawja). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


App crashes when using onClick handlers in release mode

When passing an onClick handler to elements like AppBarButton and Button, the app will crash when attempting to render a screen containing react-native-xaml components for a second time. This only occurs in release mode builds. It doesn't occur in Debug builds with web debugging enabled or with web debugging disabled. This also occurs whether the app uses Chakra or Hermes. However, this does not occur if you only ever click the "Go back (Pressable)" button, leading me to believe there's something funky going on with how react-native-xaml handles JS callbacks.
Reproduction steps:

npx react-native init AppName --template react-native-template-typescript
cd AppName
npx react-native-windows-init --overwrite --useHermes or npx react-native-windows init --overwrite --language cs
yarn add react-native-safe-area-context react-native-screens @react-navigation/native @react-navigation/stack
Launch release build from Visual Studio
Click "Add" button
Click "Go back (XAML Button)"
Click "Add" button

Expected Result:
App renders AddScreen containing two buttons.
Actual Result:
App crashes with an unhandled exception.

App.tsx
import React, {useCallback} from 'react';
import {SafeAreaView, Text, View, Pressable} from 'react-native';
import {Button} from 'react-native-xaml';
import {NavigationContainer, DefaultTheme} from '@react-navigation/native';
import {
  createStackNavigator,
  StackNavigationProp,
} from '@react-navigation/stack';

type RootStackParamList = {
  Home: undefined;
  Add: undefined;
};

const Stack = createStackNavigator<RootStackParamList>();

type HomeScreenNavigationProp = StackNavigationProp<RootStackParamList, 'Home'>;

const HomeScreen: React.FC<{navigation: HomeScreenNavigationProp}> = ({
  navigation,
}) => {
  return (
    <View style={{marginTop: 96}}>
      <Pressable
        onPress={() => {
          navigation.navigate('Add');
        }}>
        <Text>Add</Text>
      </Pressable>
    </View>
  );
};

type AddScreenNavigationProp = StackNavigationProp<RootStackParamList, 'Add'>;

const AddScreen: React.FC<{navigation: AddScreenNavigationProp}> = ({
  navigation,
}) => {
  const goBack = useCallback(() => {
    navigation.goBack();
  }, []);

  return (
    <SafeAreaView>
      <View>
        <Pressable onPress={goBack}>
          <View style={{paddingVertical: 8, paddingHorizontal: 32}}>
            <Text>Go back (Pressable)</Text>
          </View>
        </Pressable>
        <Button content="Go back (XAML Button)" onClick={goBack} />
      </View>
    </SafeAreaView>
  );
};

const App = () => {
  return (
    <NavigationContainer
      theme={{
        ...DefaultTheme,
        colors: {...DefaultTheme.colors, background: 'transparent'},
      }}>
      <Stack.Navigator headerMode="none" detachInactiveScreens={true}>
        <Stack.Screen name="Home" component={HomeScreen} />
        <Stack.Screen name="Add" component={AddScreen} />
      </Stack.Navigator>
    </NavigationContainer>
  );
};

export default App;

Dependency versions
{
  "@react-navigation/native": "^5.9.4",
  "@react-navigation/stack": "^5.14.5",
  "react": "17.0.1",
  "react-native": "0.64.1",
  "react-native-safe-area-context": "^3.2.0",
  "react-native-screens": "^3.4.0",
  "react-native-windows": "^0.64.0-0",
  "react-native-xaml": "^0.0.29"
}

Notes:
When rendering the AddScreen, you may still see the Add button from HomeScreen. This is a bug in react-navigation.
I tried to create a repro that works without react-navigation, but the following code didn't trigger the issue. I think this might mean that the issue is related to React Context, which this example does not use, but both react-navigation and react-router do use.
Example that does not trigger the issue
const App = () => {
  const [show, setShow] = useState(true);
  const toggle = useCallback(() => {
    setShow(s => !s);
  }, []);

  return (
    <View>
      <Pressable onPress={toggle}>
        <Text>Toggle Native XAML Button</Text>
      </Pressable>
      {show && <Button onClick={toggle} content="Hide Native XAML Button" />}
    </View>
  );
};

Fixed in RNW: microsoft/react-native-windows#8220 and its ports


Logging

Please describe the change you are making
This PR adds logging to the image upload process via the go-ovirt-client-log library. It is based on #5 .

Thanks @Gal-Zaidman the issues should now be resolved.

Thanks @Gal-Zaidman the issues should now be resolved.

I still see that everything is the same


accept server instance as an option, so it may intergrate with other app...

with this pr, you can use it with express like :
var express = require('express'),
  app = express(),
  http = require("http"),
  server = http.createServer(app)

flo(PATH_TO_DIR,{
    server:server,
    glob:[
      '**/*.css',
      '**/*.html',
      '**/*.jade'
    ]},function( filepath, callback){

      callback({
        resourceURL : resourceURL,
        contents : fs.readFileSync(path.join(root,filepath)),
        update : function( _window,_resourceURL){
        }
      })
    }
  })

@sskyy I don't believe the package.json should be pointing to your fork of it, plus this no wseems like it would need a rebase. Could you update?

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.


Potential bug in ConvFCBBoxHead's init cfg.

https://github.com/open-mmlab/mmdetection/blob/c88509cb9a73d6bd1edcba64eb924d3cf3cfe85d/mmdet/models/roi_heads/bbox_heads/convfc_bbox_head.py#L103
This line will override initializers for fc_cls and fc_reg because they are also nn.Linear.
Or is it what's intended? But I see the old way to initialize fc_cls and fc_reg is using Normal.

Can anyone tell me if it is an error or it is supposed to be like this? I really want to know, as tests on small dataset (voc07) shows a big difference.

I will check it

https://github.com/open-mmlab/mmdetection/blob/c88509cb9a73d6bd1edcba64eb924d3cf3cfe85d/mmdet/models/roi_heads/bbox_heads/convfc_bbox_head.py#L103
This line will override initializers for fc_cls and fc_reg because they are also nn.Linear. Or is it what's intended? But I see the old way to initialize fc_cls and fc_reg is using Normal.

Sorry for the late respondence,
you are right, we will fix asap


-[CTInboxController deleteMessagesWithId:] + 108

Fatal Exception: NSInvalidArgumentException
*** -[__NSArrayM insertObject:atIndex:]: object cannot be nil
Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x9e38 __exceptionPreprocess
1  libobjc.A.dylib                0x178d8 objc_exception_throw
2  CoreFoundation                 0x1af078 -[__NSCFString characterAtIndex:].cold.1
3  CoreFoundation                 0x1abaa0 -[__NSArrayM insertObject:atIndex:].cold.2
4  CoreFoundation                 0x13f40 -[__NSArrayM insertObject:atIndex:]
5  CleverTapSDK                   0x453a8 -[CTInboxController deleteMessagesWithId:] + 108 (CTInboxController.m:108)
6  CleverTapSDK                   0x1bfc0 -[CleverTap deleteInboxMessagesForIDs:] + 4347 (CleverTap.m:4347)
7  eWallet-iOS                    0x16d983c __59+[TNGCleverTapHandle deleteInboxMessageWithIds:completion:]_block_invoke
8  libdispatch.dylib              0x2460 _dispatch_call_block_and_release
9  libdispatch.dylib              0x3f88 _dispatch_client_callout
10 libdispatch.dylib              0xb720 _dispatch_lane_serial_drain
11 libdispatch.dylib              0xc18c _dispatch_lane_invoke
12 libdispatch.dylib              0x16e10 _dispatch_workloop_worker_thread
13 libsystem_pthread.dylib        0xdf8 _pthread_wqthread
14 libsystem_pthread.dylib        0xb98 start_wqthread

The error is obvious. Please help fix it. object cannot be nil

Hi @litongde,
In which CleverTap iOS SDK version you are facing this exception? This was known issue and has been fixed in our latest version v4.2.1. Refer changelog: https://github.com/CleverTap/clevertap-ios-sdk/blob/master/CHANGELOG.md#version-421-march-22-2023
Do update to our latest version v4.2.1 and let us know if this is fixed or not.
Thanks.

The SDK version I am currently using is v4.2.0. I will update my SDK version to v4.2.1 and try again. Thank you very much for your answer.


Update sbt-scalafix to 0.10.1

Needed to update sbt-scoverage too, since org.scoverage:scalac-scoverage-plugin_2.12.16:1.4.11 does not exist
Needed to remove Scala 2.11 support, since scalac-scoverage-plugin is not released anymore for Scala 2.11

@liancheng

@liancheng it would be great if we can release a new version of this plugin so we can all get rid of this old gem:
[info] Loading external rule(s) built against an old version of Scalafix (0.9.31).
[info] This might not be a problem, but in case you run into unexpected behavior, you
[info] should try a more recent version of the rules(s) if available. If that does
[info] not help, request the rule(s) maintainer to build against Scalafix 0.10.1
[info] or later, and downgrade Scalafix to 0.9.x (x>=31) for the time being.

Thanks!


[5.4] add ability to pretty print response

it is very difficult to view the failure response, since everything is
printed inline.  this allows the options to ‘pretty print’ the JSON
output, just like is done in the ‘additional info’.

i'm having trouble fixing the test on this one. if anyone could provide some help it would be appreciated.

Personally I don't see any point in testing the message itself. It just breaks everytime we tweak it which is silly to me from a testing perspective.

I'm still learning on a lot of this testing stuff, so I'll defer to you on that.
i was having trouble figuring out where it actually tested that message, but I just found it in the annotations.  still not a fan of annotations, but that's an argument for another place.
i have removed that annotation assertion.


chore(build): sync node version

.nvmrc and circleci node version should match

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #62   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files          20     20
  Lines         184    184
  Branches       24     24
=====================================
  Hits          184    184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c098188...bfbccaf. Read the comment docs.


Gain access to Codecov for the RecordLinker repo

What type of help do you need?

[ ] Question
[ ] New Repo
[ ] Delete Repo
[ ] User Membership (please make sure new members are familiar with the CDC open practices and set up their profile with name and org info to help people collaborate with them)
[x] Other

Please describe how you'd like us to help.
Hello there! I was told to request for a Codecov access token here. Our repo is https://github.com/CDCgov/RecordLinker. We would like to add this to our unit testing github action. Please let me know what needs to be done for this. Thank you!

I approved the Github App earlier, but wasn't sure what Codecov access token includes.
Are there any instructions on how to get that, or do you have everything you need?

Thank you for the approval! I submitted that shortly after creating this issue think that might work and it seemed to work for my personal account but I believe Codecov in the CDC org needs to be configured by the account owner? I'm def new to configuring this but when I try from with the repo settings I get this:

Also I was reading this doc earlier and shows theres an access token needed to use with github actions https://docs.codecov.com/docs/quick-start

Have you tried logging into codecov via https://app.codecov.io/login, via your Github sign on, and see if you can generate a token?
Because I don't think I've generate any tokens for anybody for this app, and I suspect they're able to do it just fine.
Also, if it's a little more involved, can you setup 15-20 mins with me<EMAIL_ADDRESS>and we can just screenshare and get it completed?

That definitely seems correct that I should be able to generate a token on my end from the Codecov UI the more I look into this. I think the issue is, Currently I can only configure my personal repos but not the RecordLinker repo because I'm an admin and not the repo owner. I agree on meeting up! That might help clarify some things. I will send you an invite thanks again!

Ah, got it. You're an outside collaborator to https://github.com/cdcgov/RecordLinker.
I just sent you an invitation to be a full member on cdcgov. That might fix the problem.

That seemed like a good try! unfortunately when I go into the repo settings to configure the app i still get the banner that I need to be a organization owner :(

I think we're meeting some time this upcoming week on this - so let's solve this then.

We updated the member list to include Derek on codecov (but no luck on access, may need a followup). I gave Derek a codecov secret to add to RecordLinker to connect them as a remediation step.

Closing ticket as completed.


Fixed the JSON Format of Generated Sub-Question (double curly brackets)

This PR changes the default template for the question_gen LLM so that generated sub-questions are in correct JSON format.
Description
I am using the default template and default parser with an open-source LLM to generate sub-questions. Here is an example of the generated sub-questions in json format:
LLMQuestionGenerator.generate(), prediction =
{{
"items": [
{{
"sub_question": "What is the summary of the article about Paul Graham?",
"tool_name": "summary"
}},
{{
"sub_question": "What are some specific facts about Paul Graham mentioned in the article?",
"tool_name": "vector_search"
}}
]
}}
As you can see above, "{{" and "}}" is in the json and causing the default json parser to fail. I noticed the default prompt below is instructing the LLM to replace "{" with "{{" and "}" with "}}": https://github.com/run-llama/llama_index/blob/369973f4e8c1d6928149f0904b25473faeadb116/llama-index-core/llama_index/core/question_gen/prompts.py#L68C1-L72C2
I tried removing the "replace" lines above and the sub-questions generated are in correct json format.
In a Discord conversation with @logan-markewich, Logan mentioned:
"Previously double brackets were needed to escape the python string formatter Changes in other parts of the library made that not needed anymore, so indeed, a PR removing that replace would be the correct thing to do"
Fixes # (issue)
New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[ ] Yes
[x] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[ ] Yes
[x] No

Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

[ ] I added new unit tests to cover this change
[x] I believe this change is already covered by existing unit tests

Suggested Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

unrelated tests are failing


Update-Module does not really update the module

Update-Module only installs a newer version. It does not remove the previous version. This is no different that using Install-Module except that it checks the current installed version an searches for a newer version. That search functionality would be better implemented as a -Update parameter for Install-Module.
Expected Behavior
Update-Module should replace the current version with a new version. Not install the new version side-by-side with the old version.
Possible Solutions

Deprecate Update-Module and move the search for update functionality into Install-Module.
Change Update-Module to remove the old version. This needs to be smart enough to remove all old versions of nested modules without breaking dependencies in other installed modules.

Context
Using the verb Update is confusing to customers. They expect the cmdlet to update what they have not install side-by-side. Also, the cmdlet reference does not explain this behavior.
We see this a lot with Azure PowerShell. They release a new version every month. After a few months you can have several versions installed taking up a lot of space.
Your Environment
PS C:\Git>  $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.15063.296
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.15063.296
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

PS C:\Git>  Get-Module

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     0.0        chocolateyProfile                   {TabExpansion, Update-SessionEnvironment, refreshenv}
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Management     {Add-Computer, Add-Content, Checkpoint-Computer, Clear-Cont...
Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Utility        {Add-Member, Add-Type, Clear-Variable, Compare-Object...}
Script     0.7.0      posh-git                            {Add-PoshGitToProfile, Add-SshKey, Enable-GitColors, Get-Al...
Script     1.2        PSReadline                          {Get-PSReadlineKeyHandler, Get-PSReadlineOption, Remove-PSR...
Script     <IP_ADDRESS>    PSYaml                              {Convert-YAMLtoJSON, ConvertFrom-YAML, ConvertFrom-YAMLDocu...
Script     1.0        sdwheeler.utilities                 {close-SQLite, ConvertFrom-Base64, convertfrom-htmlencoding...

PS C:\Git>  Get-Module -ListAvailable PowerShellGet,PackageManagement

    Directory: C:\Program Files\WindowsPowerShell\Modules

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     <IP_ADDRESS>    PackageManagement                   {Find-Package, Get-Package, Get-PackageProvider, Get-Packag...
Binary     <IP_ADDRESS>    PackageManagement                   {Find-Package, Get-Package, Get-PackageProvider, Get-Packag...
Script     <IP_ADDRESS>    PowerShellGet                       {Install-Module, Find-Module, Save-Module, Update-Module...}
Script     <IP_ADDRESS>    PowerShellGet                       {Install-Module, Find-Module, Save-Module, Update-Module...}

PS C:\Git>  Get-PackageProvider

Name                     Version          DynamicOptions
----                     -------          --------------
msi                      <IP_ADDRESS>          AdditionalArguments
msu                      <IP_ADDRESS>
NuGet                    <IP_ADDRESS>        Destination, ExcludeVersion, Scope, SkipDependencies, Headers, FilterOnTag,...
PowerShellGet            <IP_ADDRESS>          PackageManagementProvider, Type, Scope, AllowClobber, SkipPublisherCheck, I...
Programs                 <IP_ADDRESS>          IncludeWindowsInstaller, IncludeSystemComponent

PS C:\Git>  Get-PackageProvider -ListAvailable

Name                     Version          DynamicOptions
----                     -------          --------------
msi                      <IP_ADDRESS>          AdditionalArguments
msu                      <IP_ADDRESS>
NuGet                    <IP_ADDRESS>        Destination, ExcludeVersion, Scope, SkipDependencies, Headers, FilterOnTag,...
PowerShellGet            <IP_ADDRESS>          PackageManagementProvider, Type, Scope, AllowClobber, SkipPublisherCheck, I...
PowerShellGet            <IP_ADDRESS>
Programs                 <IP_ADDRESS>          IncludeWindowsInstaller, IncludeSystemComponent

@SydneyhSmith / @SteveL-MSFT  if this issue is not completed before PSGet 3.0 GA will it be a breaking change?

@ThomasNieto for 3.0 we are maintaining the behavior of Update, to install the latest version, and not delete older versions... since this has always been the behavior of PowerShellGet this will not be a change...in the future we may address this feature request by adding a parameter to the Update cmdlet that specifies older versions of the module should be uninstalled

| Assert-Duplicate -Near -Fuzzy $_ #581

@ThomasNieto for 3.0 we are maintaining the behavior of Update, to install the latest version, and not delete older versions... since this has always been the behavior of PowerShellGet this will not be a change...in the future we may address this feature request by adding a parameter to the Update cmdlet that specifies older versions of the module should be uninstalled

Would it be possible to change this so that Update-Module does update by default, and install side-by-side when a parameter is added?
I'd argue that the expected behaviour of any update mechanism is to replace the old version with the new one, so this should also be the default for PSGet 3

@danielniccoli have you read the discussion of that over in #581?


Fix broken Markdown links in README.md

Commit f03468fe13b5bca56ea7abaf83f000033760ef94 appears to have accidentally broken them.

Oops! and Thanks 👍


delete added cue point

hi,
can you please provide the documentation to remove added cue points.
thanks

Hello @RushabhJoshi,
As you've probably noticed, the whole project needs a review in terms of documentation. Pull requests will be totally welcome.
In the meantime, to destroy all cuepoints added, you can use player.destroyCuepoints().
Regards.

After adding cue points you can remove them using the players removeCue prototype function
var tracks = player.textTracks();             for (var i = 0; i < tracks.length; i++) {                 var track = tracks[i];                 if (track.id === track_id ) {                     tracks[i].removeCue(track.cues_[cue_id]);                 }             }

videojs-cuepoints plugin does not use TextTrack API yet. Next major version will use videojs' text track support.


Long-press+select not working with Termux on FP2 (Open source Android 5.1)

With French keyboard on Fairphone2, I cannot use alternate characters of keys using the long-press because the small letters that pop-up do not respond, when using Termux. The small-letters-pop-up _is_shown until I remove my finger, but wherever I “click” (last finger position), the display does not show any sign that it detected my finger, and the pop-up simply disappear without sending a character to Termux.
By the way, this is with latest Hacker’s Keyboard release from F-Droid (v. 1.39.3).

This must have been solved at some time: I no longer have this problem.
I currently use HK 1.39.3 (no change) with Termux 0.52, on the new Android6-based Fairphone2 OS (formerly Android5).


Enabling "Preset Security Policy" (Either Strict or Standard) creates a new Policy in each of the 3 sections that can not be deleted.  Why?

Why is it non-reversible?  You can disable it.  But, why can't you delete it?  If you make the mistake of "Enabling" one of these options, should you be forever committed to having it listed in each of the policy sections forever, even if you don't want it?
Or is something wrong with the "Delete" button on these 3 new "Strict" policies?  I try to delete them, and it lets me try in some cases, but nothing happens.  Other cases the "Delete" button is greyed out and not available.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4f6f1cf3-a121-3c6e-9380-79440f4c6671
Version Independent ID: 9b1bc5d1-8ecc-d0f9-092e-325c6acff4fe
Content: Preset security policies - Office 365
Content Source: microsoft-365/security/office-365-security/preset-security-policies.md
Product: m365-security
Technology: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

@toddalbers, this is already being discussed in #4804. Let's continue the discussion there. Feel free to jump in and comment on the steps I outlined there.
Thanks,
Closing


./check/doctest should also execute code after "Example:" in docstrings

Currently it only executes code after ">>> " and checks the output with the following line.

We're not consistent enough about the example being code in a particular format in order to do this. I think I would prefer to require that examples follow the >>> convention.

Pycharm has good support for >>>

A quick grep shows we have very little use of Example: that has code after it.  Going to close as I think we don't have enough usage of this.  I believe one can always use >>> after example as a workaround as is done for example in https://github.com/quantumlib/Cirq/blob/33194ad3a2f4c28c48417876ff7dd1a6732d3e41/cirq/sim/density_matrix_simulator.py


Fundamental rendering problem

Description
There seems to be a very fundamental rendering problem, although the corresponding LaTeX is quite straightforward.
(Optional:) Please add any files, screenshots, or other information here.
No response
(Required) What is this issue most closely related to? Select one.
Other
Internal issue ID
52ea8847-3d4c-48f4-88ee-d6a35e6ae9b7
Paper URL
https://arxiv.org/html/2408.01712v1
Browser
Firefox/115.0
Device Type
Desktop

This article needs support for scrartcl.cls, cross-referencing the latexml issue:
https://github.com/brucemiller/LaTeXML/issues/1670


support for keyboard media controls

Now that D-Bus support is added, how about adding support for the hardware keys to start/paus/next/previous ? If it's added, it's not working in the 64bit version ( https://github.com/Quacky2200/Spotify-Web-Player-for-Linux/releases/tag/0.9.5-1 )

I thought that Ubuntu's sound menu would do that but never the less I can implement it. For now, you can implement the play/pause next and previous buttons as a custom dbus-send command - I know this isn't what you had in mind but it's one way to do it until it's sorted

@Mondane with the code introduced here #7 the keyboard shortcuts are working the play/pause/next/previous. In using Linux Mint, which is based on Ubuntu, so I think that should work for you.

Fixed properly in https://github.com/Quacky2200/Spotify-Web-Player-for-Linux/releases/tag/1.0.0

Unfortunately on Xubuntu 16.04 LTS, the media keys only work if the Spotify window is in focus. Not entirely sure if this bug is to do with my OS or your application.
Otherwise I am greatly appreciating the changes in the latest version and recommending it to my Linux using friends!
(Apologies if this is the wrong place to report such an issue, I am fairly new to github!)

@Plasmodium1 I'm using Linux Mint with Cinnamon which is based on Ubuntu 16.04 LTS and the shortcuts are working no matter which application has the focus.
Instead of creating a custom shortcut, could you try to add a new one to the actual shortcuts:

If I push Alt+Super+p the music stops and if I push it again it continues.

I have not created any custom shortcuts (at least, not pertaining to media keys) - this is simply with me pressing the dedicated play/previous/skip buttons on my keyboard (so if this thread is specifically about custom shortcuts, then perhaps I have posted in the wrong thread? My apologies if so). These media keys control playback on Rhythmbox just as would be expected (ie, no matter what window has focus).
Unfortunately, Xfce's keyboard shortcut menu is not so comprehensive as Cinnamon's and does not include media keys, nor multiple shortcuts per command. However, if I add the commands listed above (in the second post) as shortcuts, it does work for Spotify, but hijacks the keys so that they no longer work in Rhythmbox.

When v1.0.0 was released I implemented D-Bus media key support and they work fine on Ubuntu. I have a feeling it could perhaps be a wrong string set in the dconf setting org.gnome.settings-daemon.plugins.media-keys. The string for Play, Pause, Next, etc should include the prefix XF86.
To set the right key for raising the volume for example:
gsettings get org.gnome.settings-daemon.plugins.media-keys volume-up 'XF86AudioRaiseVolume'
The media keys and their assigned media key binding code
keycode 162 = XF86AudioPlay
keycode 164 = XF86AudioStop
keycode 144 = XF86AudioPrev
keycode 153 = XF86AudioNext

I did remove global shortcuts that electron used at the time as I forgot to include them when I reformatted the controller script

As far as I can see (through dconf editor), there is no "org.gnome.settings-daemon.plugins.media-keys" setting on my system. If I run gsettings get org.gnome.settings-daemon.plugins.media-keys volume-up (which as I understand should show me the current function of that shortcut), gsettings says no such schema
Is it possible Xfce handles this differently? Or will running the command you gave above with set create the schema therefor fixing the issue?

I also run Xubuntu 16.04 and have V1.0.0 installed. I can confirm that only the media keys work when the Spotify Web Player is in focus.
Executing the same commands as @Plasmodium1 give the same result on my system. However the following commands do work, even when SWP is in the system tray or on an other workspace (I have 4).
dbus-send --print-reply --reply-timeout=2500 --session --dest=org.mpris.MediaPlayer2.spotifywebplayer /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.PlayPause

After few seconds (most likely the timeout) I get the following error:
Error org.freedesktop.DBus.Error.NoReply: Did not receive a reply. Possible causes include: the remote
application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.

But the music do pause and play. Same goes for next and previous. I reduced the timeout to 100ms and it works like a charm now.
Volume on my system goes via the global Volume Control (PulseAudio).

@toaomatis @Plasmodium1 That's because dbus-send has the option for functions to send back a value which they never do because they call methods (methods do not send back values, they simply execute code) - I looked in the man pages to see if I could remove the message since it's a pain seeing it when there's no need for an error to occur. I have realised that you can remove --print-reply --reply-timeout=2500 with  --type=method_call.
Here's an example:
dbus-send --type=method_call --session --dest=org.mpris.MediaPlayer2.spotifywebplayer /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.PlayPause

Thanks for your reply. I applied your suggestion to all three Media Key shortcuts and they work like a charm.
No noticeable delay and without errors / exceptions :+1:


Adding support for building a rails image with the app directory mounted as a shared mount

As it stands the container will include the source code ver when the onbuild image was built. Not when the container was run.
By simply adding an entrypoint script, and moving the bundle install to entrypoint, along with the ability to run db migrate db setup, the container is able to be run with the usr/src/app mounted as a volume. This allows the container to be rerun with the latest changes to your app included.
i.e. docker run --rm -v "$PWD":/usr/src/app -w /usr/src/app your_onbuild_image will just work™

As nice as this could be for some setups, this could really slow down other developers since every restart of the container will cause a new bundle install since they are not already there.  I think there is a case for having both a bundle install in the Dockerfile and one in an entrypoint script so that slight dependency changes can be tested quickly without a full image build, but that is not the general case.  For production or QA, a user would want the deps in the image, not installed to the container at startup.
Perhaps we just need extra documentation to show how to do a more advanced setup with a script and apt installs instead of just using FROM rails:onbuild.
Any thought @tianon or @Moghedrin?

Yeah, I agree; +1 for adding more documentation for making this kind of stuff easier / more obvious.

@yosifkit that makes sense, in hind sight there is no reason why I made the location of the bundle install mutually exclusive. We could leave it as it was, but add the option to also run bundle install in the entrypoint. that way the docker image will be preloaded with some gems, but any new gems that you need if you were to mount a newer app dir will get installed at run.

I'm generally a fan of the pattern of bundle install in the Dockerfile and then bundle install and rake tasks in the entrypoint (and find that it works well), but I still think it's way too specific to actually build an entrypoint into the image by default.  Even rake db:setup, while common, isn't 100% standard, and I've found that most projects inevitably need "more stuff" in their entrypoint too, so I'd much rather we document a good pattern for doing this.

Given that the recommended usage for Rails itself is to add it to your project's Gemfile and use bundle to install it, the rails official image has been deprecated as of Jul 5 in favor of using the ruby image directly (see https://github.com/docker-library/docs/pull/503 for more details).
Sorry for the inconvenience!  Since the image will not be receiving anything besides minor maintenance updates (version bumps for example), we're closing out old issues accordingly.  Thanks!


Running toflow on consecutive frames

I would like to run your system inference on consecutive frames coming directly from the network, rather than on a stored video file on the disk. Is it possible? How would you suggest to do it?

The algorithm is processing videos frame-by-frame so it's definitely possible. You may want to modify the program so that:
frame i comes from the network -> store frame i on the disk -> run forward-pass to generate improved frame i-3 (or the frame between i and i-1 for interpolation) from frame i-6, frame frame i-5, frame i-4, frame i-3, frame i-2, frame i-1, frame i (or frame i-1, frame i for interpolation)


feat: minimum distance to drag to dismiss

Added an optional minimum distance to drag to dismiss the popup to provide better customisation for that gesture.

Hey @claytog, good idea, thank you so much for your contribution, have a wonderful day!


Tooltip in multiple windows

Thank you for this useful and functional library.
I have noticed that when making use of multiple calls to zui.window the tooltips do not show.  I tracked this down to the line
tooltipText = "";
in the .window method.  I think this would be better performed in the begin() method, so that it is only called once per frame, not once per window.
Even with this fix, tooltips are only showing in the first window called.
Also, I was having issues with the window being blacked out which I tracked down to the globalG.color being switched within the drawTooltip() method. My overridden method simply stores the incoming globalG.color at the beginning of the method and restores it at the end.
Finally, if I could request that tooltips background and type colors be read from the Theme.
override function drawTooltip() {
//do not call super
var saveColor = globalG.color;  //jake
globalG.color = 0xfffeff9c;//postit yellow. was  0xffefefef;
var lines = tooltipText.split("\n");
var tooltipW:Float = 0;
for (line in lines) {
var lineTooltipW = ops.font.width(fontSize, line);
if (lineTooltipW > tooltipW) tooltipW = lineTooltipW;
}
tooltipX = Math.min(tooltipX, kha.System.windowWidth() - tooltipW - 20);
globalG.fillRect(tooltipX, tooltipY, tooltipW + 20, ELEMENT_H() * lines.length * 0.6);
globalG.font = ops.font;
globalG.fontSize = fontSize;
globalG.color = 0xff111111;
for (i in 0...lines.length) {
globalG.drawString(lines[i], tooltipX + 5, tooltipY + i * fontSize);
}
globalG.color = saveColor;  //jake
}

Also, zui.text does not call the getHover() method, this was causing issues whereby the hovering over the previously called zui item would show the text item's tool tip.
I fixed it in my extended class with:
override public function text(text: String, align:Align = Left, bg = 0x00000000) {
super.text(text, align, bg);
getHover();
}

Also,   drawCheck needs to use drawScaledImage in order to render the 'check' at the correct scale, for scaling of other than 1.0.
`function drawCheck(selected: Bool, hover: Bool) {
var x = _x + checkOffsetX;
var y = _y + checkOffsetY;
	g.color = hover ? t.ACCENT_HOVER_COL : t.ACCENT_COL;
	drawRect(g, t.FILL_ACCENT_BG, x, y, CHECK_SIZE(), CHECK_SIZE()); // Bg

	if (selected) { // Check
		g.color = kha.Color.White;
		//g.drawImage(checkSelectImage, x + checkSelectOffsetX, y + checkSelectOffsetY);
		g.drawScaledImage(checkSelectImage, x + checkSelectOffsetX, y + checkSelectOffsetY, checkSelectImage.width * SCALE, checkSelectImage.height * SCALE);

	}
}`

Seems to work for multiple windows now. Tooltip color is fetched from theme TEXT_COL and ACCENT_COL values. Other issues should be resolved as well.


Unwanted Style/ExtraSpacing and Style/SpaceInsideBrackets warnings for aligned nested array

With the following file:
> cat foo.rb

matrix = [
  [12,  1],
  [ 9, 10]
]

Expected behavior
No warnings about unnecessary spacing, since I'm using them to align the numbers in the matrix.
Actual behavior
Inspecting 1 file
C

Offenses:

foo.rb:2:7: C: Unnecessary spacing detected.
  [12,  1],
      ^
foo.rb:3:4: C: Space inside square brackets detected.
  [ 9, 10]
   ^

1 file inspected, 2 offenses detected

I presume Style/ExtraSpacing complains because I'm right aligning 1 and 10, not left aligning (to be clear I am doing this on purpose!).
To be honest I'm not sure this is easy/possible to solve, but I thought I should at least report it and see what others think.
RuboCop version
$ rubocop -V
0.43.0 (using Parser <IP_ADDRESS>, running on ruby 2.2.3 x86_64-linux)

It such peculiar cases I'd simply turn off the checks for the relevant code. I don't think it's worth trying to support this.

Yeah, I agree @bbatsov - thanks for the response, I'll close this issue to remove 1 from the list 😄


ENG-3764 A11y - OSF Home/Landing Page

Ticket: ENG-3764
Feature flag: n/a

Purpose
Fix a11y issue for carousel by removing nested interactive controls
Summary of Changes

Replaced 'li' elements with 'div' for carousel navigation
Adjusted CSS to apply styles to the new 'div' structure
Updated TypeScript logic to manage active state

Screenshot(s)
QA Notes

@brianjgeiger Fixed the failing test to match the updated div-based navigation. Carousel should be all set now.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

8 of 8 (100.0%)  changed or added relevant lines in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.03%) to 68.147%

Files with Coverage Reduction
New Missed Lines
%

lib/osf-components/addon/components/carousel/x-item/component.ts
1
72.22%

Totals

Change from base Build<PHONE_NUMBER>:
-0.03%

Covered Lines:
6139

Relevant Lines:
8760

💛  - Coveralls


docs: add minimal example

This was suggested by Fredrik Jansson so users who visit the docs.rs
site can see a minimal example.

Codecov Report

Merging #28 (a487485) into main (134b893) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   81.59%   81.59%
=======================================
  Files          22       22
  Lines        8508     8508
=======================================
  Hits         6942     6942
  Misses       1566     1566

Impacted Files
Coverage Δ

fdb/src/lib.rs
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134b893...a487485. Read the comment docs.


no collection of new deployed pod on VM based env?

Describe the bug
A clear and concise description of what the bug is.
I had following k8s , the nginx n1/n2 namespace pods are deployed after kepler daemonset start running
# kubectl get pods -A
NAMESPACE     NAME                                       READY   STATUS    RESTARTS      AGE
....
kepler        kepler-exporter-66zfj                      1/1     Running   0             47m
kube-system   calico-kube-controllers-54c85446d4-pb549   1/1     Running   2 (46h ago)   8d
....
logging       fluentd-es-hlt4c                           1/1     Running   1 (46h ago)   2d12h
logging       kibana-568dfb5bf-bgrt9                     1/1     Running   1 (46h ago)   2d13h
monitoring    alertmanager-main-0                        2/2     Running   2 (46h ago)   8d
monitoring    alertmanager-main-1                        2/2     Running   2 (46h ago)   8d
monitoring    alertmanager-main-2                        2/2     Running   2 (46h ago)   8d
monitoring    blackbox-exporter-6d897d5f66-dtspw         3/3     Running   3 (46h ago)   8d
monitoring    grafana-59664d747b-tj274                   1/1     Running   1 (46h ago)   6d17h
monitoring    kube-state-metrics-776dd9bc5d-rx4bq        3/3     Running   3 (46h ago)   8d
monitoring    node-exporter-thrwp                        2/2     Running   2 (46h ago)   8d
monitoring    prometheus-adapter-867598997b-dphc9        1/1     Running   1 (46h ago)   8d
monitoring    prometheus-adapter-867598997b-kstng        1/1     Running   1 (46h ago)   8d
monitoring    prometheus-k8s-0                           2/2     Running   2 (46h ago)   8d
monitoring    prometheus-k8s-1                           2/2     Running   2 (46h ago)   8d
monitoring    prometheus-operator-65cdf86899-bd4rl       2/2     Running   2 (46h ago)   8d
n1            nginx-deployment-7fb96c846b-8tpmd          1/1     Running   0             13m
n1            nginx-deployment-7fb96c846b-g67pz          1/1     Running   0             13m
n2            nginx-deployment-7fb96c846b-74ctr          1/1     Running   0             13m
n2            nginx-deployment-7fb96c846b-q7hsl          1/1     Running   0             13m

note n1 and n2 are nginx I want to do other test.. but I can't see nginx repoted at all
# curl localhost:9102/metrics |grep millijoule  | grep nginx
...
#

I even killed the pod and restart it
kepler        kepler-exporter-lxwmh                      1/1     Running   0             4m14s

but I still get same result
I can see etcd
root@jitest40:~# curl localhost:9102/metrics |grep millijoule  | grep etcd
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 75532    0 75532    0     0  1pod_curr_dynamic_energy_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 0
8.0Mpod_curr_energy_in_core_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 1
      0 --:--:-- --:--:-- --pod_curr_energy_in_dram_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 28
:--:pod_curr_energy_in_gpu_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 0
-- 1pod_curr_energy_in_other_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 0
8.pod_curr_energy_in_pkg_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 1
0M
pod_curr_energy_in_uncore_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 0
pod_curr_energy_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 1
pod_total_dynamic_energy_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 0
pod_total_energy_in_core_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 105
pod_total_energy_in_dram_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 2581
pod_total_energy_in_gpu_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 0
pod_total_energy_in_other_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 0
pod_total_energy_in_pkg_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 105
pod_total_energy_in_uncore_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 0
pod_total_energy_millijoule{command="etcd",pod_name="etcd-jitest40",pod_namespace="kube-system"} 105

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@sunya-ch can you take a look? I think the stats are reset for some reason, it doesn't show all the time.

Cloud you please tell more details of the environment?

BM -> VM -> Kind?

no, VM only , no kind ...
# export KUBECONFIG=/etc/kubernetes/admin.conf
root@jitest40:~/m# cat /etc/kubernetes/admin.conf | grep 10.43
    server: https://<IP_ADDRESS>:6443
root@jitest40:~/m# ip a | grep 10.43
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global dynamic ens3

this happens to my setup too, baremetal. Even nginx finally showed up, the command was wrong
[root@clever src]# curl localhost:9102/metrics 2>&1 | grep nginx-798cf574f5-r6d5g
[root@clever src]# curl localhost:9102/metrics 2>&1 | grep nginx-798cf574f5-r6d5g
[root@clever src]# curl localhost:9102/metrics 2>&1 | grep nginx-798cf574f5-r6d5g
[root@clever src]# curl localhost:9102/metrics 2>&1 | grep nginx-798cf574f5-r6d5g
[root@clever src]# curl localhost:9102/metrics 2>&1 | grep nginx-798cf574f5-r6d5g
[root@clever src]# curl localhost:9102/metrics 2>&1 | grep nginx-798cf574f5-r6d5g
pod_cpu_instructions{pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 644670
pod_curr_dynamic_energy_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 0
pod_curr_energy_in_core_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 0
pod_curr_energy_in_dram_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 1
pod_curr_energy_in_gpu_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 0
pod_curr_energy_in_other_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 0
pod_curr_energy_in_pkg_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 51
pod_curr_energy_in_uncore_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 0
pod_curr_energy_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 51
pod_energy_stat{avg_cpu_frequency="1925920.645833",block_devices_used="1",command="conmon",curr_bytes_read="0",curr_bytes_writes="0",curr_cache_miss="2133",curr_container_cpu_usage_seconds_total="0",curr_container_memory_working_set_bytes="0",curr_cpu_cycles="3238378",curr_cpu_instr="644670",curr_cpu_time="0",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1",total_bytes_read="0",total_bytes_writes="19177472",total_cache_miss="2133",total_container_cpu_usage_seconds_total="0",total_container_memory_working_set_bytes="70713344",total_cpu_cycles="3238378",total_cpu_instr="644670",total_cpu_time="0"} 51
pod_total_dynamic_energy_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 0
pod_total_energy_in_core_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 0
pod_total_energy_in_dram_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 1
pod_total_energy_in_gpu_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 0
pod_total_energy_in_other_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 0
pod_total_energy_in_pkg_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 51
pod_total_energy_in_uncore_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 0
pod_total_energy_millijoule{command="conmon",pod_name="nginx-798cf574f5-r6d5g",pod_namespace="test-1"} 51

there could be two possible causes:

the pid/cgroup -> pod resolution is wrong (so the wrong conmon was picked up)
the stats were reset (the pod_total_energy_millijoule should stay on regardless of current energy)

there could be two possible causes:

the pid/cgroup -> pod resolution is wrong (so the wrong command was picked up)
the stats were reset (the pod_total_energy_millijoule should stay on regardless of current energy)

I think the podEnergy is reset as there is no context_switch of that pod detected by BPF here https://github.com/sustainable-computing-io/kepler/blob/fc425e939332b659a376c933160afe52d1fb03ad/pkg/collector/reader.go#L201-L205.
It is in the to-fix list that we should double-check whether the pod is deleted or just no activity.
For the command shown up, it is the latest command called by that pod which might be not the main one.
https://github.com/sustainable-computing-io/kepler/blob/fc425e939332b659a376c933160afe52d1fb03ad/pkg/collector/reader.go#L137
We may instead get the other meaningful information from the kubelet instead of the command from BPF.

I had a similar issue because the pod information was being deleted and then I commented out the part that deletes the pod information. during my experiments... However, the memory usage may grow and never be freed even if the pod has been deleted....
So instead of removing pod information from podEnergy when there is no HC update, we could introduce a timeout
For example, if we don't see any updates on the pod's usage for at least 5 minutes, we can assume the pod is no longer active and delete it from podEnergy

@marceloamaral how about introduce a garbage collector to remove metrics from inactive pods when the metrics map size (to be configured) is too large?

I assume this has been tested already with the PR ?if so we can close this

@jichenjc can you test if the issue was solved?

ok, then it's not newly created pod, it's inactive pod ..
anyway ,seems deploy a new deployment with nginx pods I can see them from output,so close this


loading model

hi i was able to train a model running your code,but when i try to predict the caption using your predict.py file,it downloads your pretrained model,how to use the model i trained in the predict.py file,i am very new to this,i would really appreciate if you could help me out.Thanks in advance

In the predict.py file, the following line is fetching pretrained model from this repository
model = torch.hub.load("saahiluppal/catr", "v3", pretrained=True)

Just modify this file to load your own model
weights = torch.load('/path/to/weights')
model = torch.load_state_dict(weights)

In the predict.py file, the following line is fetching pretrained model from this repository
model = torch.hub.load("saahiluppal/catr", "v3", pretrained=True)

Just modify this file to load your own model
weights = torch.load('/path/to/weights')
model = torch.load_state_dict(weights)

thanks ,will try this

this may come as a very noob question,when i run the code i get a .pth file as saved file,do you mean i ve to send that checkpoint.pth file in torch.load

Yes,
weights = torch.load('/path/to/checkpoint.pth')
model = torch.load_state_dict(weights)


Authentication - Redirect users to Sign in screen on API's 401

Background:
Today when we are calling APIs that requires Authentication or Authorization, we have to repeat the code below in for every API:
...
API:
  myProfile:
    url: https://myserver.com/profile
    onResponse: ...
    onError:
      if (response.statusCode == 401) {
        ensemble.navigateScreen('Login');
      }

Instead there should be an option for example on the API that says this is an Authenticated request. The framework then can automatically redirect the user to Login screen (this also has to be known) automatically.

yes - I think the way to do is to specify at the app level what to do when API returns a specific header or content. The HTTP header for unauthorized access is 401 but some apps send errors in the body with a 200 error. Let the server return it instead of proactively checking.


Feature/signal configuration

Changes to the signal configuration file.
Added update endpoint.
Added a logging json file to keep track of the last time the sig files were checked.
Fixed logic to check compile time before re-downloading sig file.

Codecov Report

Merging #5 into master will increase coverage by -5.64%.

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
- Coverage   16.29%   10.66%   -5.64%
==========================================
  Files           3        4       +1
  Lines         227      347     +120
==========================================
  Hits           37       37
- Misses        189      309     +120
  Partials        1        1

Impacted Files
Coverage Δ

sigfile/sigfile-helpers.go
0% <ø> (ø)

sigfile/sigfile.go
9.54% <0.82%> (-5.9%)
:x:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f53c5d...a8de10f. Read the comment docs.


Fixed #31556 -- Remove useless list comprehension

The join string method accepts an iterator.

Hi. This has come up before and was rejected… A list comprehension is preferable here as str.join() converts to list internally anyway. It is better performance to provide a list up front.


Improve unit test utilities

@troydai did you have anything specific in mind for this?  Otherwise I suggest we close it.


Why was lib removed from webpack resolved modules in SPFx 1.10?

Category

[x] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Question
I've just updated one of our solutions to SPFx 1.10, which caused our webpack build to fail.
Took me a while to figure it out, but apparently the lib folder was removed from webpack's resolve modules.
The current webpack config is:
{
  ...
  resolve: {
    alias: {},
    modules: ["node_modules"]
  },
  ...
}

Whereas in previous versions this was
{
  ...
  resolve: {
    alias: {},
    modules: [
      "node_modules",
      "lib"
    ]
  },
  ...
}

Is there a particular reason this has been changed? If so, this might be worthwhile mentioning in the release notes as well.
Tnx.
PS: We fixed this for our solution using the following in gulpfile.js
build.configureWebpack.mergeConfig({
  additionalConfiguration: generatedConfiguration => {
    generatedConfiguration.resolve.modules.push("lib");

    return generatedConfiguration;
  }
});

Not sure.  Let me dig in.  Thanks for the heads up.

I think we can safely revert this change. It was done to reduce the scope of our webpack module resolution strategy.
@NickSevens  Can you clarify how it broke your webpack build? Does your code contain imports depending on webpack to resolve the lib folder? Or is there something in SPFx itself that is breaking?

@halfnibble we have an appSettings.json file in the src/ folder, which is used to easily configure our environment variables during runtime, and change it easily in our release pipeline.
Something like:
{
  "appInsightsKey": "...",
  "azureADAppId": "...",
  "webApiUrl": "..."
}

This is declared as a module with an appSettings.d.ts file as such:
declare interface IAppSettings {
  appInsightsKey: string;
  azureADAppId: string;
  webApiUrl: string;
}

declare module "appSettings" {
  const appSettings: IAppSettings;
  export = appSettings;
}

Which in turn makes it importable in our source files with
import * as appSettings from "appSettings";

This means however that webpack should load the module from the tsc compiled lib folder, and not from node_modules, which now seems to be the only one configured in the resolve config.

@NickSevens are you setting "typings": "lib/index.d.ts", in your package.json file?
Can you provide a minimal repro that showcases the problem (before the gulpfile workaround).

Sure, @halfnibble
https://github.com/NickSevens/spfx-demo-missing-lib-resolve
Run gulp bundle to see the issue.

Thank you so much @NickSevens!
Based on your repro repo, I recommend adding "resolveJsonModule": true to your tsconfig.json file.
In addition, you'll need to import from the actual path, e.g.
import * as appSettings from "../../../appSettings.json";

Ideally, there'd be a way to set a webpack alias so you don't have to type the path, but I don't believe our config settings support that currently.
Having lib/ automatically resolve is convenient, but we've found it can also create difficult to debug issues, such as having a root level .ts file with the same name as a node_module package.
We should definitely mention this change in the docs somewhere because it does change how things work.

Okay thanks.
Not that developer friendly unfortunately, but I get the reasoning. :)
Ps: would be nice if spfx would support .env files or something alike for global app configs :)

@NickSevens @halfnibble
I also have similar requirement to update web api urls based on dev vs production.
Can you suggest any recommended way?
https://spblog.net/post/2018/06/24/Read-and-manipulate-SPFx-configuration-values-in-your-code-like-a-boss
Is this a correct approach?

@spoman007 I actually wrote a blog post about an alternative way recently:
https://digitalworkplace365.wordpress.com/2020/03/05/using-env-files-in-sharepoint-framework-development


.NET Core 3.1 is not supported by ML.NET cli.

Problem encountered on https://dotnet.microsoft.com/learn/ml-dotnet/get-started-tutorial/train
Operating System: macos
.NET Core 3.1 is not supported by ML.NET cli. I run the cmd from the MS tutorial but get error.
shenyang@myMacBook-Pro myMLApp001 % mlnet auto-train --task binary-classification --dataset "wikipedia-detox-250-line-data.tsv" --label-column-name "Sentiment" --max-exploration-time 10
It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '2.1.0' was not found.

The following frameworks were found:
3.1.1 at [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]

You can resolve the problem by installing the specified framework and/or SDK.
The specified framework can be found at:

https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=2.1.0&arch=x64&rid=osx.10.15-x64

Thanks for reporting! @LittleLittleCloud can you check that the upcoming release works with just 3.1.1 on the machine?

@biztudio you can download the needed run time from here:
https://dotnet.microsoft.com/download/dotnet-core/2.1

Dup of #256


Move to the Eclipse Foundation

Dear contributors to the vertx-auth module,
We would like to officially move the project to the Eclipse Foundation under the https://github.com/eclipse-vertx umbrella.
For legal reasons, we need the consent from all code committers. Could you please let us know if you consent?

Clarification: We are not changing the license. We are transfering the IP ownership to the Eclipse Foundation, so that the foundation can enforce and protect the IP in the future as described by the licenses we choose at the beginning of the project.

We'd like you to complete the following steps:

Ensure that you have signed the Eclipse ECA https://www.eclipse.org/legal/ECA.php
Reply to this issue with your decision (consent/not consent) including your Eclipse contributor URL, e.g.: https://www.eclipse.org/user/palopes

Thank you very much for your feedback.

[x] @afloarea
[x] @agilob
[x] @alexlehm
[x] @AlliageSphere
[ ] @dependabot
[ ] @BrunoVernay
[x] @cescoffier
[x] @davidafsilva
[x] @DieterDePaepe
[x] @drakkan
[x] @francoisprunier
[x] @gaol
[ ] @gofabian
[ ] @humb1t
[x] @jakefeasel
[ ] @jdiazcano
[x] @jhult
[ ] @jmoscato
[x] @jo5ef
[x] @johnoliver
[x] @jponge
[ ] @KidNox
[x] @lukehutch
[x] @lusoalex
[x] @Mart-Bogdan
[x] @MartinNowak
[x] @mguillet
[x] @nevenr
[x] @oschina
[x] @otricadziziusz
[x] @paulbakker
[x] @paulgallagher75
[x] @pendula95
[x] @pigbayspy
[x] @pmlopes
[x] @potatop
[x] @purplefox
[ ] @rcoelho
[ ] @remi128
[x] @re-thc
[x] @rgmz
[x] @ronreiter
[x] @runtarinn
[x] @sczyh30
[x] @sfitts
[x] @SgrAlpha
[x] @skfh82
[x] @slinkydeveloper
[x] @sophokles73
[x] @stefanosbou
[x] @stephanebastian
[x] @thced
[x] @tipok
[x] @tsegismont
[x] @vietj
[ ] @vinscom
[x] @wowselim
[x] @yeikel
[x] @zenios
[x] @zyclonite

I consent
https://www.eclipse.org/user/palopes

I consent
https://accounts.eclipse.org/users/nmurino

I consent
https://projects.eclipse.org/user/13134

I consent
https://accounts.eclipse.org/users/khudalla/

I consent
https://accounts.eclipse.org/users/mmisingnamec8l

I consent
https://accounts.eclipse.org/users/runtarinn
On Mon, May 30, 2022 at 12:47 PM Lazar Bulić @.***>
wrote:

I consent
https://accounts.eclipse.org/users/lbulic
—
Reply to this email directly, view it on GitHub
https://github.com/vert-x3/vertx-auth/issues/562#issuecomment-1141118093,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACXCVUDXNADLPCVSGHA5CA3VMS2GBANCNFSM5XKMPYOA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I consent
https://accounts.eclipse.org/users/lgaosmt

I consent
I do not have an eclipse account. Is that a problem? The commit was done many years ago and it is a typo lol

I consent
https://accounts.eclipse.org/users/dnovikovr0j

I do not have an eclipse account. Is that a problem? The commit was done many years ago and it is a typo lol

@jdiazcano if you don't mind spending a few minutes, it would be easier for us if you could sign the ECA (which automatically will require the creation of the account)

@jdiazcano if you don't mind spending a few minutes, it would be easier for us if you could sign the ECA (which automatically will require the creation of the account)

I just don't understand why it needs to be signed as this is happening post-commit (and not just a few days). I would like to avoid the creation of the account if possible.

I consent
https://accounts.eclipse.org/users/bmart

I consent
https://accounts.eclipse.org/users/lhutchison

I consent
https://accounts.eclipse.org/users/sfitts

I consent

I consent
https://accounts.eclipse.org/users/afloarea

I consent

I consent
https://www.eclipse.org/user/tsegismont
Le lun. 30 mai 2022 à 21:13, stefanos @.***> a écrit :

I consent
—
Reply to this email directly, view it on GitHub
https://github.com/vert-x3/vertx-auth/issues/562#issuecomment-1141424918,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AALOLNROK5WEXK65CPWCYYDVMUHOJANCNFSM5XKMPYOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I consent. This whole thing is a hassle though, and I doubt it’s really necessary. “Legal reasons”? You want to release the code under a different license? Couldn’t you just say that?
https://accounts.eclipse.org/users/jfeasel

This whole thing is a hassle though, and I doubt it’s really necessary. “Legal reasons”? You want to release the code under a different license? Couldn’t you just say that?

@jakefeasel no, we are not changing any license. What is happening is that we are finally being added to the eclipse foundation. In order for the foundation to protect the code, it requires that all contributors consent that their contributions/IP to be donated to the foundation. This way the foundation can enforce the licenses we choose long ago for the project.
I understand it is bureaucracy work, but a small action to allow that the code is indeed open source and not owned by any third party.

I consent
https://accounts.eclipse.org/users/adumasddv

I consent
https://accounts.eclipse.org/users/rethc

I consent
https://accounts.eclipse.org/users/yhangfou

I consent
https://accounts.eclipse.org/users/michelguillet

I consent
https://accounts.eclipse.org/users/sdincer

I consent
https://accounts.eclipse.org/users/fprunier

I consent
https://www.eclipse.org/user/afaria67g

I consent!

I consent: https://accounts.eclipse.org/users/pbakker88a
On Mon, May 30, 2022 at 5:17 AM Paulo Lopes @.***>
wrote:

Dear contributors to the vertx-auth module,
We would like to officially move the project to the Eclipse Foundation
under the https://github.com/eclipse-vertx umbrella.
For legal reasons, we need the consent from all code committers. Could you
please let us know if you consent?
We'd like you to complete the following steps:

Ensure that you have signed the Eclipse ECA
https://www.eclipse.org/legal/ECA.php
Reply to this issue with your decision (consent/not consent)
including your Eclipse contributor URL, e.g.:
https://www.eclipse.org/user/palopes

Thank you very much for your feedback.
[] @afloarea https://github.com/afloarea
[] @agilob https://github.com/agilob
[] @alexlehm https://github.com/alexlehm
[] @AlliageSphere https://github.com/AlliageSphere
[] @dependabot https://github.com/dependabot
[] @BrunoVernay https://github.com/BrunoVernay
[] @cescoffier https://github.com/cescoffier
[] @davidafsilva https://github.com/davidafsilva
[] @DieterDePaepe https://github.com/DieterDePaepe
[] @drakkan https://github.com/drakkan
[] @francoisprunier https://github.com/francoisprunier
[] @gaol https://github.com/gaol
[] @gofabian https://github.com/gofabian
[] @humb1t https://github.com/humb1t
[] @jakefeasel https://github.com/jakefeasel
[] @jdiazcano https://github.com/jdiazcano
[] @jhult https://github.com/jhult
[] @jmoscato https://github.com/jmoscato
[] @jo5ef https://github.com/jo5ef
[] @johnoliver https://github.com/johnoliver
[] @jponge https://github.com/jponge
[] @KidNox https://github.com/KidNox
[] @lukehutch https://github.com/lukehutch
[] @lusoalex https://github.com/lusoalex
[] @Mart-Bogdan https://github.com/Mart-Bogdan
[] @MartinNowak https://github.com/MartinNowak
[] @mguillet https://github.com/mguillet
[] @nevenr https://github.com/nevenr
[] @oschina https://github.com/oschina
[] @otricadziziusz https://github.com/otricadziziusz
[] @paulbakker https://github.com/paulbakker
[] @paulgallagher75 https://github.com/paulgallagher75
[] @pendula95 https://github.com/pendula95
[] @pigbayspy https://github.com/pigbayspy
[] @pmlopes https://github.com/pmlopes
[] @potatop https://github.com/potatop
[] @purplefox https://github.com/purplefox
[] @rcoelho https://github.com/rcoelho
[] @remi128 https://github.com/remi128
[] @re-thc https://github.com/re-thc
[] @rgmz https://github.com/rgmz
[] @ronreiter https://github.com/ronreiter
[] @runtarinn https://github.com/runtarinn
[] @sczyh30 https://github.com/sczyh30
[] @sfitts https://github.com/sfitts
[] @SgrAlpha https://github.com/SgrAlpha
[] @skfh82 https://github.com/skfh82
[] @slinkydeveloper https://github.com/slinkydeveloper
[] @sophokles73 https://github.com/sophokles73
[] @stefanosbou https://github.com/stefanosbou
[] @stephanebastian
[] @thced
[] @tipok
[] @tsegismont
[] @vietj
[] @vinscom
[] @wowselim
[] @yeikel
[] @zenios
[] @zyclonite
—
Reply to this email directly, view it on GitHub
https://github.com/vert-x3/vertx-auth/issues/562, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA2XLGXOV3BRXDDZLCF3NDVMSWXFANCNFSM5XKMPYOA
.
You are receiving this because you were mentioned.Message ID:
@.***>

I consent. https://www.eclipse.org/user/sgralpha
Paul Bakker @.***> 于2022年6月2日周四 03:56写道：

I consent: https://accounts.eclipse.org/users/pbakker88a
On Mon, May 30, 2022 at 5:17 AM Paulo Lopes @.***>
wrote:

Dear contributors to the vertx-auth module,
We would like to officially move the project to the Eclipse Foundation
under the https://github.com/eclipse-vertx umbrella.
For legal reasons, we need the consent from all code committers. Could
you
please let us know if you consent?
We'd like you to complete the following steps:

Ensure that you have signed the Eclipse ECA
https://www.eclipse.org/legal/ECA.php
Reply to this issue with your decision (consent/not consent)
including your Eclipse contributor URL, e.g.:
https://www.eclipse.org/user/palopes

Thank you very much for your feedback.
[] @afloarea https://github.com/afloarea
[] @agilob https://github.com/agilob
[] @alexlehm https://github.com/alexlehm
[] @AlliageSphere https://github.com/AlliageSphere
[] @dependabot https://github.com/dependabot
[] @BrunoVernay https://github.com/BrunoVernay
[] @cescoffier https://github.com/cescoffier
[] @davidafsilva https://github.com/davidafsilva
[] @DieterDePaepe https://github.com/DieterDePaepe
[] @drakkan https://github.com/drakkan
[] @francoisprunier https://github.com/francoisprunier
[] @gaol https://github.com/gaol
[] @gofabian https://github.com/gofabian
[] @humb1t https://github.com/humb1t
[] @jakefeasel https://github.com/jakefeasel
[] @jdiazcano https://github.com/jdiazcano
[] @jhult https://github.com/jhult
[] @jmoscato https://github.com/jmoscato
[] @jo5ef https://github.com/jo5ef
[] @johnoliver https://github.com/johnoliver
[] @jponge https://github.com/jponge
[] @KidNox https://github.com/KidNox
[] @lukehutch https://github.com/lukehutch
[] @lusoalex https://github.com/lusoalex
[] @Mart-Bogdan https://github.com/Mart-Bogdan
[] @MartinNowak https://github.com/MartinNowak
[] @mguillet https://github.com/mguillet
[] @nevenr https://github.com/nevenr
[] @oschina https://github.com/oschina
[] @otricadziziusz https://github.com/otricadziziusz
[] @paulbakker https://github.com/paulbakker
[] @paulgallagher75 https://github.com/paulgallagher75
[] @pendula95 https://github.com/pendula95
[] @pigbayspy https://github.com/pigbayspy
[] @pmlopes https://github.com/pmlopes
[] @potatop https://github.com/potatop
[] @purplefox https://github.com/purplefox
[] @rcoelho https://github.com/rcoelho
[] @remi128 https://github.com/remi128
[] @re-thc https://github.com/re-thc
[] @rgmz https://github.com/rgmz
[] @ronreiter https://github.com/ronreiter
[] @runtarinn https://github.com/runtarinn
[] @sczyh30 https://github.com/sczyh30
[] @sfitts https://github.com/sfitts
[] @SgrAlpha https://github.com/SgrAlpha
[] @skfh82 https://github.com/skfh82
[] @slinkydeveloper https://github.com/slinkydeveloper
[] @sophokles73 https://github.com/sophokles73
[] @stefanosbou https://github.com/stefanosbou
[] @stephanebastian
[] @thced
[] @tipok
[] @tsegismont
[] @vietj
[] @vinscom
[] @wowselim
[] @yeikel
[] @zenios
[] @zyclonite
—
Reply to this email directly, view it on GitHub
https://github.com/vert-x3/vertx-auth/issues/562, or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAA2XLGXOV3BRXDDZLCF3NDVMSWXFANCNFSM5XKMPYOA
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/vert-x3/vertx-auth/issues/562#issuecomment-1144072202,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACLCJ6JHEO7MUZ6CKFIPFDVM656ZANCNFSM5XKMPYOA
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Admin of sgr.io

I consent.
https://accounts.eclipse.org/users/jhult

I consent.
https://www.eclipse.org/user/tcederholmtpp

I consent
https://accounts.eclipse.org/users/pgallagherv60

I consent.
https://accounts.eclipse.org/users/rgomezt60

All my contributions were made while I was employed by Red Hat, and as per the terms of my employment contract, the IP is owned by Red Hat, presumably Red Hat already signed a corporate CLA with Eclipse foundation so my contributions should be covered by that.

I consent
https://accounts.eclipse.org/users/amarker

I consent
https://accounts.eclipse.org/users/Yeikel

I consent
https://accounts.eclipse.org/users/dzenios

I consent
https://accounts.eclipse.org/users/skfh82

I consent
https://accounts.eclipse.org/users/oschina

I consent
https://accounts.eclipse.org/users/ezhaodwu

I consent
https://accounts.eclipse.org/users/agilob

Thank you, everyone! We've made it!


Line representation including waters/metals (and pickable?)

Apologies this is a bit of a "splurge thoughts into a text box" - I'm wondering what the best way to do this is:
I'd like to display a protein in line representation with waters and metals shown (metal-organic bonds might not always be defined - at the moment metals without bonds don't appear at all in line mode). The way pymol and others do this is to draw a cross (pymol draws 3 lines, parallel with the axes, intersecting at the point, AstexViewer draws a 2d cross in plane with the screen).
The Point representation with useTexture and sizeAttenuation true is nearly right, but its size is specified in screen units not Angstroms so the size is fixed as you zoom in and out, which isn't quite what I'm after.
I'd also like to be able to pick atoms from a line representation, which doesn't seem possible at the moment?
Maybe some kind of line+point representation, using a cross as the texture for isolated atoms with size specified in scene units? If the bonded atoms were also shown as 1-pixel point circular representations (in screen units) you'd be able to pick atoms too, which would be a bit of a bonus.
Alternatively, I might be massively over-complicating this and there's already a way to do this...

So I played around with it a bit more, and here's a handy workaround in case anyone else wants to display a line representation but also keep atoms pickable: You can add a point representation with the following params:
{sizeAttenusation: false,
 opacity: 0.0,
 pointSize: 15}

Then hovering/picking atoms works as it detects the (transparent) point representation.
Doesn't solve the displaying waters/metals in line representation, but that probably needs its own new representation type.

After a few weeks otherwise engaged I made a cross representation:
http://fredludlow.com/ngldev/examples/webapp.html?script=representation/cross
https://github.com/fredludlow/ngl/tree/cross-representation
This methods draws crosses a bit like pymol - aesthetically this isn't quite as nice as doing them in plane, but I think that would require a custom shader? (One that takes 4 vertices positioned at each atom and nudges them up/down/left/right in the screen plane?).
What I'm aiming for is a "line XOR cross" representation, i.e. every atom is depicted, if possible as the end of a line/bond, if not forming a bond to another displayed atom then as a cross. Actually, what I'm really aiming for is a "pickable line/cross" representation (possibly using a transparent point representation as outlined above?). I'm not sure how best to structure this, so here's what I've come up with, feedback on structure, naming and whether to include at all very welcome!

Add CrossRepresentation CrossBuffer more or less as in my branch/demo
Create a LineAndCrossRepresentation type

Owns a LineBuffer, CrossBuffer and possibly a PointBuffer
It takes as parameters:

crossAll - Display crosses on bonded atoms too, defaults to false
crossSize - Offset in Angstroms
pickable - Create a transparent PointBuffer to enable picking

So I've made a 'line+cross' representation roughly as outlined above, which has most of the behaviour I'm after, but looking at it now there's a lot of scope for improvement in how it achieves that!
Demo is here:
http://fredludlow.com/ngldev/examples/webapp.html?script=representation/line-and-cross
If you load the demo and then type ".CA" or "sidechain" as the selection you can see how every atom is depicted (either with a line to it when there's a visible bond or a cross at it's location)
Code is in the same branch as before
https://github.com/fredludlow/ngl/tree/cross-representation
The issues with this are mostly around [ab]using the PointBuffer to fudge pickable lines:

There's one immediate practical problem: if you change the opacity of a representation to something non-zero the point buffer becomes visible, this is fixable, but..
Using PointBuffer like this at all doesn't feel right - maybe a PickingBuffer, or is there a much cleaner way to solve this? (I admit I don't quite understand the ins and outs of picking - BondPicker and related classes etc)
You can only pick atoms (not bonds)

Anyway - to summarise, it sort of does what I want, but probably not in the way it ought to and I'm not quite sure what to do with it... Comments much appreciated!

Nice, the demo looks good! Sorry for being so slow to answer.
I made a WideLineBuffer to be able to render wide pixel lines again as this is a feature that was/is dropped from browsers. I suggest to change the CrossRepresentation so it uses the WideLineBuffer, i.e. calculate the lines to form the crosses and pass to the WideLineBuffer. An extra CrossBuffer seems overkill. Same for the combined for the Line+Cross Representation. I think the CrossRepresentation can be part of the LineRepresentation with a flag to toggle it.
Also, the WideLineBuffer supports picking :)

Excellent - WideLineBuffer looks like a much better solution, and I'd been hoping that triangle/quad based lines would make an appearance (user-base here is Windows so linewidth with DirectX/Angle has never worked AFAIK) - so many thanks for that!
Agree separate representations/buffers for everything is overkill. With two parameters you could get all permuations of the behaviour within the single LineRepresentation type:

line - true/false
cross - 3 states: "none", "isolated", "all"
Does that sound reasonable? (I have no strong opinions so whatever you prefer)

How about just cross - true/false. You can get the rest by using selections, I think, unless, see below...
With isolated would you show crosses for atoms that are generally unbounded or for atoms that have no bonds in the current selection?

With isolated would you show crosses for atoms that are generally unbounded or for atoms that have > no bonds in the current selection?

The latter; my concern was to not miss out any atoms. A contrived example is line representation with 'sidechain' selection - Alanine sidechains don't appear because there are no intra-sidechain bonds. I used 'isolated' rather than 'nonbonded' so as to distinguish it from the selection language term, though I'm not sure it really makes it clearer...
The following branch does all the cross creation etc in the LineRepresentation class:
https://github.com/fredludlow/ngl/tree/line-cross-repr
Updated example here (you can type "sidechain" into the selection box and see how it behaves)
http://fredludlow.com/ngldev/examples/webapp.html?script=representation/line-and-cross
It still uses two buffers (I couldn't work out a better way to handle both atom and bond picking)
A couple of other issues:

That branch has crosses on by default, which would change behaviour for existing code, I guess they probably want to be off by default?
I build a copy of the AtomPicker with each array value repeated three times (to cope with the fact that there are three rendered lines per atom) - maybe this would be more elegantly done with some kind of scale factor in the AtomPicker? (i.e. array[pid] becomes array[ 0 | (pid/scale)] ?

Ok, I see the use case.

It still uses two buffers (I couldn't work out a better way to handle both atom and bond picking)

having multiple buffers is fine

That branch has crosses on by default, which would change behaviour for existing code, I guess they probably want to be off by default?

I think having crosses on for isolated atoms is a good default! The term isolated is fine I guess, got me on the right track :) Maybe lone?

I build a copy of the AtomPicker with each array value repeated three times (to cope with the fact that there are three rendered lines per atom) - maybe this would be more elegantly done with some kind of scale factor in the AtomPicker? (i.e. array[pid] becomes array[ 0 | (pid/scale)] ?

copying pickingArray values is fine

I think having crosses on for isolated atoms is a good default! The term isolated is fine I guess, got me on the right track :) Maybe lone?

lone works for me and is less typing! I'll make a PR...

Closing - thanks again for getting me from vague idea of what I want to something that works!


issue-651 added default value for classValuePrefix in icon picker

Issue:
https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/651
Changes Made:

Added default value for classValuePrefix is js plugin.

Ready for review..

@justinedelson : I created this branch over 6.2 compatibility branch... is that right or should it be over master and 6.2 will be rebased over master in case this one works as expected?
Thanks!!

PRs that apply to both master and 6.2 compat should be branched from and made against master. Once merged into master, we pull master into 6.2 compat.  6.2 only features/fixes can go straight into 6.2 compat branch and not master.

that said, since this is a trivial change, I'll just fix it manually.

manually merged. thanks!


Add new grid-based product: Sligrid

Signed-off-by: kfei<EMAIL_ADDRESS>

I am sorry but it is not JavaScript Grid(Table) product.
It is some kind of cloud MindMap/Todo product.
It does not have any attitude to list issue.


feat(behavior_path): use multi thread

Signed-off-by: tomoya.kimura<EMAIL_ADDRESS>Description
To solve https://github.com/autowarefoundation/autoware.universe/issues/275 in behavior path planner, multi thread is used for callbacks by passing a different callback group, whose type is MutuallyExclusive, to each calback.

Related links
https://github.com/autowarefoundation/autoware.universe/issues/275
https://github.com/autowarefoundation/autoware.universe/pull/260

Tests performed

Notes for reviewers
Run simple psim, and see if each callback of subscribes is called in a steady cycle.

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

I've resolved the conflict with main, so please re-approve


Fix GC hole in string marshaling

Fixes #768
Fix GC hole where the whole MarshalString object gets moved and makes the HSTRING reference invalid
Fix memory leak and possible memory corruption in exception handling in GetActivationFactory
The implementation of WindowsCreateStringReference takes the header buffer, fills it and then the returned handle is a pointer to the header buffer. It is thus absolutely essential that the header buffer is not moved while the HSTRING instance is alive. This is explicitly called out in the documentation:

The caller must ensure that sourceString and the contents of hstringHeader remain unchanged during the lifetime of the attached HSTRING.

The code was storing the header buffer in unpinned GC memory so the GC was free to move it and it occasionally did so which caused accesses from native code into invalid memory.
Now the solution in the PR is not the most optimal one but it's one that is least disruptive and easy to review. From performance point of view it would make sense to use ref struct and rely on the stack being unmovable.

Verified with our customer that the fix helped.

@angelazhangmsft Please give this issue/PR appropriate attention. It's serious enough that it makes CsWinRT totally unusable for us due to random crashes. I am not pushing for accepting my fix verbatim but it's likely affecting all CsWinRT users to certain extent.

@filipnavara - really appreciate this fix.  yes, GC moves had not been considered.


Migrate language server operations to operate on top of the new project API

Description:
$title
Related Issues:
#25418

Task has been completed in SLP8. Hence closing the issue

Task has been completed in SLP8. Hence closing the issue


Fix #750 by reusing ExternalRefProcessor

Use ExternalRefProcessor for RefUtils#buildUrl to avoid ArrayOutOfBoundsException
Fix #750

This PR supersedes https://github.com/swagger-api/swagger-parser/pull/751

Thanks!