Create and Seed DB

make sure the mysql seeds and schema work
create al relation between tables

User and coin tables working and sending.
creating portfolio  table and association

completed


chore: upgrade glob to 7.1.1

Upgrade glob to an up to date version to avoid regression

This should sufficiently fix #2325.

LGTM

Cool thank you :octocat:


I couldn't download stocks

root@bad:~# YahooTickerDownloader.py stocks
Checking if we can resume a old download session
Downloader found on disk, resuming
Downloading stocks

req https://finance.yahoo.com/_finance_doubledown/api/resource/finance.yfinlist.symbol_lookup;p=1;s=a;b=0;m=all;t=S?device=console&returnMeta=true
Retry attempt: 1. Sleep period: 5 seconds.
req https://finance.yahoo.com/_finance_doubledown/api/resource/finance.yfinlist.symbol_lookup;p=1;s=a;b=0;m=all;t=S?device=console&returnMeta=true
Retry attempt: 2. Sleep period: 25 seconds.
req https://finance.yahoo.com/_finance_doubledown/api/resource/finance.yfinlist.symbol_lookup;p=1;s=a;b=0;m=all;t=S?device=console&returnMeta=true
Retry attempt: 3. Sleep period: 125 seconds.
I think that url does not work.
That response is below.
{"output":{"message":"Not Found"},"meta":{}}
Thank you

Yes! You are right. The API might have changed.

I looked a bit around on google finance and could not find a GUI to list symbols using a search string. It could be they (re)moved it. If it is removed this utility can't do it's job and is rendered useless. If anyone known of a api to find a list of stocks please say so.

So basically the unofficial Yahoo API broke, and I'm not yet sure if there is a replacement.

@Benny-
This seems to work to some extent:
https://finance.yahoo.com/_finance_doubledown/api/resource/searchassist;searchTerm=aa?bkt=fin-guce-ga&device=desktop&feature=canvassOffnet,ccOnMute,enableTradeit,newContentAttribution,relatedVideoFeature,videoNativePlaylist,enableCrypto,enableESG,enablePrivacyUpdate,enableGuceJs,enableGuceJsOverlay,enableCMP,livecoverage,enableSingleRail,enableChartiqFeedback,enableSKTVLrec&intl=us&lang=en-US&partner=none&prid=cddtv01desr5j®ion=US&site=finance&tz=America/New_York&ver=0.102.1312&returnMeta=true
In fact it can be pared down to simply:
https://finance.yahoo.com/_finance_doubledown/api/resource/searchassist;searchTerm=aa
...and it will still work.  However, this only returns the first 10 results.  I'm not clear on whether there are parameters to increase the page size or even choose a page other than 1.  Any ideas?

This is great! Do you know where this api is used, @jharker ? If it supports pagination this will be a suitable replacement.

Hi, @Benny- Yup, the API is used by the "Symbol Lookup" tool on this page:
https://finance.yahoo.com/lookup/
But unfortunately, from what I can tell it doesn't support pagination.  Still, it seems like it should be possible to use this to pull symbols in groups of ten or less using a few modifications to the search algorithm you're already using.  I'll see if I have time to give it a shot in the next week or so.

Hi, @Benny- I created a pull request that implements the new Yahoo API.  You may want to modify this to be more seamlessly integrated into the old code -- I didn't want to rip too much out of the existing code so I created some parallel functionality instead.
I've tested this over the past few days and it works pretty well.  I wish there was a way to make it more efficient in terms of the number of API calls, but with the API results set apparently limited to 10 and not paginated, I can't figure out a way to do it more efficiently than this.
https://github.com/Benny-/Yahoo-ticker-symbol-downloader/pull/44

I ran it and I'm am quite impressed with the results so far. It got 84464 unique results so far.
Exporting still works and considering the other API did not work anymore I've published this right now as 3.0.0. This new version gives a lot of random 404 error from Yahoo, this is logged as #45.


Failed assertion in Describe()

Prerequisites

[X] Checked that your issue isn't already filed by cross referencing issues with the common mistake label
[X] Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
[X] 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
[X] Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with:
node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend avoiding the use of globally installed Mocha.

Description
Is there any way to have Mocha not throw a stack-trace when an assertion fails in a describe() block?  (as opposed to within it())
We are looking into change behaviour on a product, but we simply get a stack trace, rather than a list of broken tests.   This is because several thousand of our test cases have expect(s) within a describe rather than within an it() // presumably done by peple in error.
Others, are using them in context() and setting up a context, and making assertions that the context is valid, before moving on to it() test cases.
Either way, there's no way to determine the full extent of how much will break, because it simply dumps out a single stack trace, rather than being captured and sent to a reporter.
Steps to Reproduce
describe('a', () => {
expect(false).equal(true);
});
Expected behavior: [What you expect to happen]
Not throw a stack trace.
Reporter: "Test Case a failed. " (where "a" here is the tree of describes/contexts that we are in)
Nice to Have, but probably not possible:
If an assertion is called outside of an it(), to display it in the test results as well.  As it stands, we have no idea how many test cases across our GHE are in this state, all that we know is that they currently pass.
Actual behavior: [What actually happens]
Stack trace.
Reproduces how often: [What percentage of the time does it reproduce?]
Always

Failing assertions outside of tests are unlikely to be "properly" reportable since at that point the reporter hasn't even been initialized (in general the reporter can't be initialized yet, some of them have to know how many tests there are at the report start). And (just in my opinion), given that those are doubly in error (not only is the assertion failing but it shouldn't be made in describe to begin with), I'm not sure it's a bad thing that they end up with much more focused "reporting" in the form of a crash rather than formatted test results. Plus, even if they pass they won't be listed as passed tests (Mocha doesn't really have any way to tell apart describes with passing assertions from describes that are being used properly), so something more really needs to be fixed...
Trying to think of the easiest way to correct the issue. Say, a linting rule that would detect these (maybe even fix them by changing describe to it), whether based on describe without any it/describe/etc inside it or based on describe containing your chosen assertion library (or both)... Or a similar code-mod to just make the fix.
Unfortunately I haven't got around to learning how to write either of those (most of my en-masse code updates have been done with grep and sed, which won't do for finding something like "code block that might have other code blocks nested in it"). If anybody does know how (or knows of an existing one), I'd appreciate any assistance we can get here.

don't put an assertion in a describe block, that's not what it's for.


gradlew build install error on mac os yosemite

Trying to follow through the "getting started" guide on juniversal.org, running ./gradlew build install.
System setup: Latest Mac OS X, Latest JDK

Thanks for the feedback.  That should be fixed now.   The intention is that (now) the signing only happens if the uploadArchives Gradle target is invoked, normally just done on the build machine, which has the signing key configured in the gradle.properties file.
Please holler when you run across other issues.


Unable to load integration - Missing tinytuya

When I try to setup tuya-local, it does not start the config-flow but gives the following error in the logs:
Error occurred loading configuration flow for integration tuya_local: No module named 'tinytuya'
I installed tuya-local by adding it as a custom repository to HACS.
Is there a way to get tinytuya to load? Using the linuxserver/homeassistant container.
Thanks!

Sorry, I cannot offer support for exotic installation methods.  On HA OS, they have a wheels repository that takes care of dependencies, and since this dependency is declared in the manifest I'd expect that to work.  But I don't know how the various other alternate HA installation methods work with regards to dependency handling.

Thank you for your explanation, I'll inquire with the linuxserver-team.

I'll also put the solution here for future reference. Adding the following two lines to the environment variables in the docker-compose fixes it:
- DOCKER_MODS=linuxserver/mods:universal-package-install
- INSTALL_PIP_PACKAGES=tinytuya

Thanks @Joery . I'm using the official HA image and had the same issue. With your answer it became obvious that "all" I had to do was to run pip install tinytuya at container startup (that can be done by overriding CMD, ENTRYPOINT or ARGS, or in my case using Kube's postStart).
For anyone else in the business of using extreme exotic installation methods, here is how it can be done on Kube:
        image: ghcr.io/home-assistant/home-assistant:latest
        imagePullPolicy: Always
        lifecycle:
          postStart:
            exec:
              command:
              - /usr/local/bin/pip
              - install
              - tinytuya


Grading resources

Where do we describe resources for grading?
@yuvipanda wrote in an email
I am also in contact with the wonderful folks who build and maintain the ok server (which data8 now uses for grading, tests, and other course support) about writing an OK authenticator. This would make it easy for other connectors to use the same tools that John uses for his courses, and also to limit access based on rosters. Thoughts welcome on https://github.com/Cal-CS-61A-Staff/ok/issues/1039

I know that @sumukh talked about the grading http://okpy.org/ offers, and that's what data8 uses. I've not personally used it myself, however.

the connectortools module does some of this. I was thinking of building out the grading stuf more, but wasn't sure whether there would be a commitment to OKpy or not.
Once we have an idea for a possible grading workflow, we should write up the kind of page that @clcarson describes in the top comment. I just haven't put anything in writing because I'm not sure that we've established a "best practice" yet

The student infrastructure team (Steve Wu) has elements to add in here (grading infrastructure, bCourses). I've asked @anthonysuen and @gunjanbaid to guide them in producing a draft, testing the tools, and getting leadership buy-in before putting on the wiki.

sounds great - we can leave this issue open until it's time to integrate that info into the wiki. Until then, I'll keep my little grading functions in there in the hopes that they'll be useful to some connectors.

I added a quick auto-running function and example here:
https://github.com/data-8/connector-instructors/blob/master/examples/grade_student_notebooks.ipynb
LMK if that'd be useful or if you have thoughts. This isn't a grading solution by a long shot, but should make it more convenient for people to run student notebooks in batches.

hey all - so is there anything actionable in this thread at this point? Do we want to continue having a grading infrastructure conversation here? Or shall we post-pone that and close this issue if it's happening elsewhere?


remove securitymanager

We haven't reached a point yet whereby we have an LTS release of Java where the security manager is disabled so at the moment all currently supported LTS versions of Java still support the activation of the security manager.
Additionally we still have a number of years until the last LTS release which supports the security manager goes out of support.
Looking at the root pom I believe this project is still trying to retain compatibility with Java 11, there are many enterprise installations out there on the older LTS releases and many still making use of the security manager - projects removing their security manager related code are inadvertently going to be creating regressions in these environments.


As user I want to use Python 3.5 to do "jupyter pixiedust install"

Expected behavior
jupyter pixiedust install
Step 1: PIXIEDUST_HOME: /root/pixiedust
Keep y/n [y]? n
Please enter a PIXIEDUST_HOME location: /data/local/pixiedust
Step 2: SPARK_HOME: /data/local/pixiedust/bin/spark
Keep y/n [y]? n
Step 2: Please enter a SPARK_HOME location: /usr/lib/spark
downloaded spark cloudant jar: /data/local/pixiedust/bin/cloudant-spark-v2.0.0-185.jar
Step 3: SCALA_HOME: /data/local/pixiedust/bin/scala
Keep y/n [y]? n
Step 3: Please enter a SCALA_HOME location: /usr/share/scala
String is Scala code runner version 2.11.8 -- Copyright 2002-2016, LAMP/EPFL
Step 4: Kernel Name: Python with Pixiedust (Spark 2.1)
Keep y/n [y]? n
Please enter a Kernel Name: Python with Pixiedust (Spark 2.1)
self.kernelInternalName pythonwithpixiedustspark21
[PixiedustInstall] Installed kernelspec pythonwithpixiedustspark21 in /root/.local/share/jupyter/kernels/pythonwithpixiedustspark21
Downloading intro notebooks into /data/local/pixiedust/notebooks
...https://github.com/ibm-watson-data-lab/pixiedust/raw/master/notebook/PixieDust 1 - Easy Visualizations.ipynb : done
...https://github.com/ibm-watson-data-lab/pixiedust/raw/master/notebook/PixieDust 2 - Working with External Data.ipynb : done
...https://github.com/ibm-watson-data-lab/pixiedust/raw/master/notebook/PixieDust 3 - Scala and Python.ipynb : done
...https://github.com/ibm-watson-data-lab/pixiedust/raw/master/notebook/PixieDust 4 - Add External Spark Packages.ipynb : done
...https://github.com/ibm-watson-data-lab/pixiedust/raw/master/notebook/PixieDust 5 - Stash to Cloudant.ipynb : done
...https://github.com/ibm-watson-data-lab/pixiedust/raw/master/notebook/PixieDust Contribute.ipynb : done
/####################################################################################################
/#       Congratulations: Kernel Python with Pixiedust (Spark 2.1) was successfully created in /root/.local/share/jupyter/kernels/pythonwithpixiedustspark21
/#       You can start the Notebook server with the following command:
/#               jupyter notebook /data/local/pixiedust/notebooks
/####################################################################################################
Actual behavior
jupyter pixiedust install
Step 1: PIXIEDUST_HOME: /root/pixiedust
Keep y/n [y]? n
Please enter a PIXIEDUST_HOME location: /data/local/pixiedust
Step 2: SPARK_HOME: /data/local/pixiedust/bin/spark
Keep y/n [y]? n
Step 2: Please enter a SPARK_HOME location: /usr/lib/spark-2.1.1-bin-without-hadoop
downloaded spark cloudant jar: /data/local/pixiedust/bin/cloudant-spark-v2.0.0-185.jar
Step 3: SCALA_HOME: /data/local/pixiedust/bin/scala
Keep y/n [y]? n
Step 3: Please enter a SCALA_HOME location: /usr/lib/scala
Directory /usr/lib/scala does not exist
Create y/n [y]? n
Step 3: SCALA_HOME: /data/local/pixiedust/bin/scala
Keep y/n [y]? n
Step 3: Please enter a SCALA_HOME location: /usr/share/scala
Traceback (most recent call last):
File "/usr/local/bin/jupyter-pixiedust", line 11, in
sys.exit(main())
File "/usr/local/lib/python3.5/dist-packages/install/pixiedustapp.py", line 42, in main
PixiedustJupyterApp.launch_instance()
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 657, in launch_instance
app.initialize(argv)
File "", line 2, in initialize
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 296, in initialize
self.parse_command_line(argv)
File "", line 2, in parse_command_line
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 514, in parse_command_line
return self.initialize_subcommand(subc, subargv)
File "", line 2, in initialize_subcommand
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 452, in initialize_subcommand
self.subapp.initialize(argv)
File "", line 2, in initialize
File "/usr/local/lib/python3.5/dist-packages/traitlets/config/application.py", line 87, in catch_config_error
return method(app, *args, **kwargs)
File "/usr/local/lib/python3.5/dist-packages/jupyter_core/application.py", line 239, in initialize
self.parse_command_line(argv)
File "/usr/local/lib/python3.5/dist-packages/install/createKernel.py", line 248, in parse_command_line
installed_scala_version = self.get_scala_version()
File "/usr/local/lib/python3.5/dist-packages/install/createKernel.py", line 429, in get_scala_version
return get_scala_version_from_dir(self.scala_home)
NameError: name 'get_scala_version_from_dir' is not defined
Steps to reproduce the behavior
jupyter pixiedust install
Step 1: PIXIEDUST_HOME: /root/pixiedust
Keep y/n [y]? n
Please enter a PIXIEDUST_HOME location: /data/local/pixiedust
Step 2: SPARK_HOME: /data/local/pixiedust/bin/spark
Keep y/n [y]? n
Step 2: Please enter a SPARK_HOME location: /usr/lib/spark-2.1.1-bin-without-hadoop
downloaded spark cloudant jar: /data/local/pixiedust/bin/cloudant-spark-v2.0.0-185.jar
Step 3: SCALA_HOME: /data/local/pixiedust/bin/scala
Keep y/n [y]? n
Step 3: Please enter a SCALA_HOME location: /usr/lib/scala
Directory /usr/lib/scala does not exist
Create y/n [y]? n
Step 3: SCALA_HOME: /data/local/pixiedust/bin/scala
Keep y/n [y]? n
Step 3: Please enter a SCALA_HOME location: /usr/share/scala
Reason:
https://github.com/ibm-watson-data-lab/pixiedust/blob/master/install/createKernel.py#L428
Instead of:
def get_scala_version(self):
return get_scala_version_from_dir(self.scala_home)
Should not it be:
def get_scala_version(self):
return self.get_scala_version_from_dir(self.scala_home)

@markwatsonatx can you take a look?


Adding property binaryCalendarRep with values "binarySeconds" and "bi…

…naryMilliseconds"
DAFFODIL-99

+1 with recent changes


Text Generator App Using GPT-4.0

A multi-platform text generator app using GPT-4.0 and Flutter, providing various text generation features.

Add the github repo link.

https://github.com/saba99/Text-Generator-App-Using-GPT-4.0

@ashitaprasad
i have added the link
kindly assign me with this issue

Copied project.


Restructure APP

Get APP version from init.py
Update Makefile
Update docker-compose.yml, Dockerfile

Hello @awaisdar001! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file django-trips/__init__.py:

Line 7:91: W292 no newline at end of file

In the file setup.py:

Line 43:13: E126 continuation line over-indented for hanging indent


Enhancement: Add smart sapling planting

Description
This PR adds new features requested by players, this new feature replants the seedlings of trees that are cut down, in an intelligent way without compromising those who want to keep the plantations, and those who do not want to keep them.
Related Issue
Close #3 (Self planting of tree saplings)
How to use

To use the new function, simply cut the trees.
Cut above the first block of wood, and the sapling will be replanted.
Cut at the first block of wood, and the sapling will not be replanted.

Going through tests...


Added support for simple query in find

Added the ability to make simple queries based on value like
todos.find({complete : true})

Thanks! I will add some tests and put it into a new release.


Upgrade to bless ~4.0.0

4 isn't out yet. Need to do this on a branch.

We just pushed v4.0.0-alpha.0 to npm today! Please let us know how it works for you so we can be confident about getting the actual release out. Also, the Bless project has a new home at https://github.com/BlessCSS/bless. Since it is now in a github organization we'd also like to extend the invitation to transfer this repo there and add you as a member of the organization. The goal being to consolidate and document bless and it's usage with different build tools. Our main focus will be towards Gulp, Grunt, Webpack, and possibly Browserify. If you have any questions feel free to reach out in our issue log or hit us up on gitter at https://gitter.im/BlessCSS/bless

It looks like bless v4.0.0 was released/pushed to npm today: https://github.com/BlessCSS/bless/issues/89
Is it possible to update gulp-bless to use it?
Thanks

@BrandonNoad will take a look

This might resolve BlessCSS/Bless#92

Ok, I think it's ready. It would be good if you two could test #21 please;
npm install adam-lynch/gulp-bless#bless4

When I try to build my css assets, I'm getting this when using adam-lynch/gulp-bless#bless4:
events.js:154
      throw er; // Unhandled 'error' event
      ^
TypeError: Cannot read property 'reduce' of undefined
    at countRules (/Users/brandon/code/bonfire/app/node_modules/bless/lib/count.js:26:17)
    at count (/Users/brandon/code/bonfire/app/node_modules/bless/lib/count.js:44:14)
    at chunks$ (/Users/brandon/code/bonfire/app/node_modules/bless/lib/chunk.js:52:46)
    at tryCatch (/Users/brandon/code/bonfire/app/node_modules/babel-runtime/regenerator/runtime.js:72:40)
    at GeneratorFunctionPrototype.invoke [as _invoke] (/Users/brandon/code/bonfire/app/node_modules/babel-runtime/regenerator/runtime.js:334:22)
    at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (/Users/brandon/code/bonfire/app/node_modules/babel-runtime/regenerator/runtime.js:105:21)
    at chunk (/Users/brandon/code/bonfire/app/node_modules/bless/lib/chunk.js:98:113)
    at Object.chunk (/Users/brandon/code/bonfire/app/node_modules/bless/lib/index.js:34:33)
    at Transform._transform (/Users/brandon/code/bonfire/app/node_modules/gulp-bless/index.js:33:36)
    at Transform._read (/Users/brandon/code/bonfire/app/node_modules/gulp-bless/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    at Transform._write (/Users/brandon/code/bonfire/app/node_modules/gulp-bless/node_modules/readable-stream/lib/_stream_transform.js:172:12)
    at doWrite (/Users/brandon/code/bonfire/app/node_modules/gulp-bless/node_modules/readable-stream/lib/_stream_writable.js:237:10)
    at writeOrBuffer (/Users/brandon/code/bonfire/app/node_modules/gulp-bless/node_modules/readable-stream/lib/_stream_writable.js:227:5)
    at Transform.Writable.write (/Users/brandon/code/bonfire/app/node_modules/gulp-bless/node_modules/readable-stream/lib/_stream_writable.js:194:11)
    at DestroyableTransform.ondata (/Users/brandon/code/bonfire/app/node_modules/readable-stream/lib/_stream_readable.js:583:20)
    at emitOne (events.js:90:13)
Segmentation fault: 11

@BrandonNoad hmm :/. I'm not sure why that is. It looks like a problem with bless itself. @mtscout6 @paulyoung any ideas?
Disclaimer: I'm completely guessing here. Bless (or a dependency) parses your CSS (AST) so maybe some invalid CSS could cause an issue. I know the stack trace shows the problem is in node_modules/bless/lib/counts.js but maybe that's just a symptom shown at a later stage. Plus you know, I'm completely guessing :smile:.

Ya, I noticed the error was in the bless module. I'm using gulp-sass to compile sass to css, and it's not throwing any errors, so I'm assuming the css is valid. Maybe the errors aren't being logged properly though...I'll have to double-check that. I'll do a bit of digging to see if I can find the root cause of the problem.

If you can provide a simple CSS input that would cause this error it would really help us dig into what the problem is exactly.

I've narrowed it down to 2 files in the foundation-sites (v5.5.3) library (the type and offcanvas components). I'll try to find the exact cause tomorrow.

The following css rule when run through bless seems to cause the error:
@page {
  margin: 0.34in;
}

https://www.w3.org/TR/css3-page/#page-box-page-rule

OK I see there's a bless core issue. I'll close this and publish


UI styling

Annyeong-haseyo
I've created a new theme based on your great work. The main difference is that mine is also styling UI elements, since that's now supported. I first wanted to create a pull request, but the differences were too big (XML => JSON). But if you don't mind these changes, we could still merge?
https://github.com/kraftwer1/vscode-theme-darcula-extra

I can see a lot of broken rules with your configurations, so it's hard to merge your work now.
If you only add ui-stylings attributes without changing any existing rules, I can accept your work in this extension.
And it will be added as different theme entry like the screenshot since it's not written in tmTheme format.
Anyway, thanks for your interest :)

Maybe I can write a theme generator for both vscode & tmTheme later.

With "broken rules" you mean selectors like "punctuation.meta.something"? How do you check these?

Am 15.05.2017 um 04:09 schrieb Youngrok Kim<EMAIL_ADDRESS>Maybe I can write a theme generator for both vscode & tmTheme later.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Use vscode's tmScope inspector ( open palette and search Developer: Inspect TM Scopes )

Thanks, and in what way are they broken?

Some UI styling has been updated in v1.1.0, closed


abaplint.app: Skipping abaplint checks for a commit

GH actions can be skipped by appending "[skip ci]" to the commit text. It would be nice if this could be used to skip abaplint runs as well.

it would just run on the next commit right?
just delaying the information/issues found
If some issues are not relevant, suggest disabling the rule, or change the severity.
Also, the user controls in repository configuration, which checks are mandatory for merging a PR

Delaying is the point. one example is changing the rules (commit 1) and fixing objects (commit 2). Or fixing something in multiple commits. If I already know that the lint issues won't be fixed, running the check is just a waste of resources.

personally, I'd always like the visibility of showing the results, eg without "real CI" results for "commit 1" there is no visibility for what is exactly to be fixed in "commit 2"
Continuous Integration runs in parallel, results for a second commit should not be delayed due to commit 1. abaplint.app currently has a limited number of workers, but most of the time resources are idle.
Saving resources, yea, but how often? Perhaps saving 1 out of 1000+ commits?

no worry. just an idea to go along with GH standard (https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/).

there has also been some discussion on github, for how to disable the feature, because some don't want it 😄
I think the feature might be relevant to deploying, eg if code is automatically deployed at push, some might want to skip. But abaplint is just static analysis...


WFLY-13469 Decouple distributed SFSB cache from client mappings registry

https://issues.redhat.com/browse/WFLY-13469
Pre-requisite of WFLY-13132

@rachmatowicz Please review.


localhost:8010 is a logo?

All I get from
http://localhost:8010/  OR  http://localhost:8010/rest is the logo.
Is this suppose to happen?

Sounds like maybe you didn't start the backend server?  You'll have two gulp dev tasks running; one for the backend REST API server with mock data, one for the UI hot deployment server.

yup, port 8010 is for the REST API and there is no UI on that one.
If you run gulp dev inside grommet-ferret a browser window should open automatically at localhost:8001.
If you want to see how grommet-ferret would behave in real production server you need to run gulp dist and then node server/server.js to start a production server at localhost:8010.

I did. Had both running. It required both to run or neither would display anything. I'm starting to think it may be a dependency issue. I'm looking into it now.

@DonRichards were you able to get this working?

Closing for now.  Let us know if you still need assistance.


Test Framework talks with zookeeper

Chun,
I made the change so that the test framework talks with zookeeper instead of a single drillbit. I got a clean functional run today and hanifi got 4 consecutive functional runs in the past. Let me know your thoughts

Rahul

Chun,
I will add the new parameter to the drillTestProperties template file.
Regarding backward compatibility, I think the default should always be "connecting via zookeeper". I will not commit this change until tomorrow. So that gives time for others to comment. What do you think?
Rahul


Can I use FilterableDropdown only for auto-completion but not for choice validation?

Hi,
I want to help the user to fill out a text entry with the auto-completion of the historical inputs. The history is stored in a csv file, and being read at the beginning of the program. If the user input is not existing in the history it should still be regarded as a valid input. However, if I utilize the choices argument in the parser, it will fail if the user's response is out of the choices. How can I provide the input suggestion and bypass the choice validation?
YW

I would be also be very interested in this feature


[IMPROVEMENT] v2 volume supports UBLK frontend

Is your improvement request related to a feature? Please describe (👍 if you like this request)

According to preliminary results in https://github.com/longhorn/longhorn/issues/5159, replacing the iSCSI frontend with UBLK has shown significant performance gains. Currently, v2 uses nvmf-tcp as its frontend protocol, but SPDK also supports UBLK (see UBLK documentation). The purpose of this ticket is to further compare nvme-tcp with UBLK to determine if UBLK could replace nvme-tcp, and to explore the associated error handling strategies.
Describe the solution you'd like

Compare the performance of nvme-tcp and UBLK in various scenarios, focusing on data transfer rates, latency, and resource utilization.
If UBLK is identified as a potential candidate, investigate the feasibility of replacing nvme-tcp with UBLK as the frontend protocol.
Develop error handling procedures to ensure stability and reliability when using UBLK.

Describe alternatives you've considered
Retaining the current nvmf-tcp protocol and optimizing its performance.
Additional context

https://spdk.io/doc/ublk.html

Assigned to @PhanLe1010, who has a strong interest in UBLK. Mark it as P1; if we have enough bandwidth, we can include it in v1.8.0 or defer it to v1.9.0 later.
cc @innobead

cc @shuo-wu @DamiaSan


Convert Dom.eventTarget to Dom.element

I've been investigating how to convert a Dom.eventTarget to Dom.element for the target element to be useful. I've found nothing from webapi's sources, but a blog post suggested using
external asDomElement : 'a => Dom.element = "%identity";

Although it works, I'd like to know if this is the best way to achieve it.
Example where such conversion is needed:
let onDocumentClick = ({ReasonReact.state}, event) =>
  Webapi.Dom.(
    switch (state.menuRef^) {
    | Some(menu) =>
      let target = event->MouseEvent.target;
      Js.log(menu |> Element.contains(target)); /* target's type causes error */
    | None => ()
    }
  );

Error output:
This has type:
  Dom.eventTarget (defined as Dom.eventTarget_like(Dom._baseClass))
But somewhere wanted:
  Dom.node_like('a) (defined as Dom.eventTarget_like(Dom._node('a)))

The incompatible parts:
  Dom._baseClass
    vs
  Dom._node('a)

I found an SO answer that gives enough context about this problem.
For the record:
Short answer:

external eventTargetToNode : Dom.eventTarget => Dom.node = "%identity";

An eventTarget can be almost anything, and there's unfortunately no good way of figuring
out what it is. In JavaScript it's simply inferred by the user based on context (It might be
possible to carry that context around in a type parameter, but that's off in the future
somewhere).

So for the moment you'll have to make an unsafe cast to get what you need.

There's also EventTarget.unsafeAsElement. still unsafe but you don't have to write your own.
let target = event->MouseEvent.target;
Js.log(menu |> Element.contains(EventTarget.unsafeAsElement(target)));


Pods not starting due to 'too many open files' error

Description
When deploying PLGD it seems if the number of pods being deployed is high enough then some will not run. For example if 20 coap gw (replicas) pods are configured to be deployed then 7 will never reach running state.
How can it be reproduced?

deploy using command:
microk8s.helm3 install am-1 -f withMock.yaml plgd/plgd-hub --create-namespace --namespace=am-1
withMock.yaml content:

global:
  domain: "host.domain.com"
  hubId: "d03a1bb4-0a77-428c-b78c-1c46efe6a38e"
mockoauthserver:
  enabled: true
resourcedirectory:
  log:
    debug: true
resourceaggregate:
  log:
    debug: true
httpgateway:
  log:
    debug: true
grpcgateway:
  log:
    debug: true
coapgateway:
  log:
    debug: true
  replicas: 20
  port: 5683
  service:
    type: NodePort
    nodePort: 5683
  apis:
    coap:
      tls:
        enabled: false

Logs, error output, etc.
Log from a coap gw pod that does not reach running state (continuously restarting):
2022-01-19T16:34:13.332Z        FATAL   log/log.go:129  cannot create service: cannot create identity-store client: cannot create connection to identity-store: cannot create cert manager: too many open files
github.com/plgd-dev/hub/v2/pkg/log.Fatalf
        /go/src/github.com/plgd-dev/hub/pkg/log/log.go:129
main.main
        /go/src/github.com/plgd-dev/hub/coap-gateway/cmd/service/main.go:25
runtime.main
        /usr/local/go/src/runtime/proc.go:255

The pods that fail to reach running state are not always coap gw pods. Sometimes there are other pods, which fail in a similar fashion and give the same error message. What seems constant is the number of pods that do not run after PLGD installation.
The OS Kernel open file settings used are the following:
#ulimit -Hn
262144
#ulimit -Sn  (increased this one from 1024 to 250K but did not made any difference)
250000
#cat /proc/sys/fs/file-max
1613280

I also see that the number of entries in lsof command jumps about 60K with PLGD deployed (far more than everything else in the OS)
Environment

microk8s v1.22.4 (snap) running on CentOS Linux release 8.5.2111
microk8s helm3 v3.5.0
plgd hub tag: 2.2.3
IoTivity version: none (issue is reproducible with no IOT devices connected to PLGD)
Deployment option: ( helm )

@itestoss sorry for the late reply, we had other high-prio topics to resolve first.
Issue occurs because the maximum instances of inotify per user was reached. Default value of fs.inotify.max_user_instances is set to 128, what is a pretty low number for your usecases.


TBI - (fiori-elements-writer): Remove dependency on 'sap.fe.templates' for V4

Description (include screenshots)
Feedback from our V4 Fiori elements colleagues about changes to the V4 generated projects (regardless of UI5 version):

The UI5 dependencies should depend on sap.fe.core and not sap.fe.templates in the manifest.json
Remove the manifest.json dependency on sap.ushell, it shouldn't be needed.
The generated flpSandbox.htmlshould reference sap.fe.core and not sap.fe.templates

Value
Align with best practice recommendations from V4 Fiori elements.
Architecture Elaboration
Does it requires architecture elaboration?
Notes
Tasks

[ ] Task 1

FYI @tobiasqueck.  Might be some middleware updates required as part of this for the flpSandbox.html update.

@nlunets could you please check this one. I am aware that you are the source for this but I don't think the requirements above are correct, I think it should be more like

sap.fe.templates should still be used for LROP
sap.fe.core should be used instead of sap.fe.templates if a custom page project is generated
ushell should not be in the manifest (that is correct)
the test/flp.html should contain templates (and core) to have the best preview expierence - keep in mind the flp.html is only used for local preview, not productively

Yes @tobiasqueck you are correct

@tobiasqueck @nlunets @ianquigley-sap a few additions:

propose to keep any changes to the preview html files out-of-scope here as their generation is soon be obsolete as we can create them on the fly in the preview middleware, and changes will be done there instead
this BLI has a dependency to an FPM writer enhancement to also maintain the lib section when adding pages, e.g. adding sap.fe.templates when creating a floorplan page like the list report, and adding sap.fe.core for FPM custom pages.

Would this be something you can take together with the BLI as both have to be delivered in sync or shall I create a separate BLI for it?


pull request for e2e test at 01/20/2017 23:56:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


How to training with LAE-Gen model

Thank you for your outstanding work, may i ask when will the LAE-Gen Code and training guidance be released?

Sorry for late reply. Considering the copyright issue of training data of LAR-Gen, we won’t be able to open-source the standard training configuration file for reproduction. However, we will soon provide a demo version of the training configuration.

Thanks for your reply. Actually I want to train the model with our own dataset.


[Feature Request] Add Preset Menu to Kernel > Emulate section

SInce certain configurations require Fake a CPU ID, a preset Menu for selecting which CPU should be emulatad would be great . The selected preset will then add the required data to Cpuid1Data and Cpuid1Mask fields.
 I see how to implement it.

Features have been added, feel free to provide any upgrade clues.

Thanks for adding this feature!
Addendum: a list of supported CPUIDs for macOS can be found in the "Intel CPU Support Chart" of the Dortania's OpenCore Install Guide
But the CPU IDs have to be converted into Little Endian and filled up with zeros so the mask becomes 16 bit (32 digits)
For example: Coffee Lake, CPUID (HEX): 0x0906EA
Conversion:

Drop "0x"
Create pairs of 2 of the rest: 09 06 EA
Reorder the pairs from last to first: EA 06 09
Add zeros until you have 32 digits in total: EA 06 09 00 00 00 00 00 00 00 00 00 00 00 00 00
Cpuid1Mask always addresses the first 4 bits: FF FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00

I'm sure the users will be very grateful that you have compiled and made this information available.
Please feel free to let me know if any of these are updated and I will update them in OCAT.

a typo in Comet lake Preset

Coffee Lake is spelled wrong as well. It's spelled with Double "e". My bad.

The typos are gone now, but the data for Coffee Lake is missing:

@ic005k
is it possible to add Emulate Cascade Lake:
Cpuid1Data: 57 06 05 00 00 00 00 00 00 00 00 00 00 00 00 00
Cpuid1Mask: FF FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00
thank you

Why would you want to emulate a CPU which is not supported by macOS? The whole idea is emulating a newer CPU unsupported by macOS by using a mask of a supported CPU.

It is useful when you use a VM system with Proxmox or Unraid.

 "
Intel Xeon W-3275
New macPro


Update input.vue

Summary
change to misskey settings page to give more spacing for save button content above
https://github.com/syuilo/misskey/issues/6740
here's video of the change

@syuilo I added video to show the change

Removing the style will cause problems in a number of other areas. example:
Before

After

I solved the problem by modifying the style of the settings page.

It is generally best to avoid changing the style of commonly used components such as ui/input.
Thanks anyway🙏


Expand “Containers versus values” trap

See this discussion: https://irclog.perlgeek.de/perl6/2017-02-24#i_14160027
We already have something here: https://docs.perl6.org/language/traps#Containers_versus_values_in_a_Capture
But let's add @a.push: ($a, $b) there as well, because on the first sight it looks very innocent indeed.
Also, the section talks about Captures, but I'm not sure what this is about. ($a, ++$a) itself is a List, so where's a capture in the given example?

Can be useful to mention this on https://docs.perl6.org/language/containers instead/too.

@AlexDaniel if it's a List, it's been created through calling its initialization routine, so it becomes a capture somewhere, right?


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #795 (029994f) into main (c770333) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##             main     #795   +/-   ##
=======================================
  Coverage   95.69%   95.69%
=======================================
  Files           1        1
  Lines         395      395
  Branches       53       53
=======================================
  Hits          378      378
  Misses         17       17


Would be nice to have...

would be nice to have the emote( /emote) output here if possible: https://imgur.com/CcviKpR

Hi, thank you for suggesting that.
It have been added in the 1.0.2 release.


Fix a bug in the room database

Code Coverage

File
Coverage [0.00%]
:x:

app/src/main/java/com/example/myapplication/recipes/data/datasource/RecipeDatabase.kt
0.00%
:x:

Total Project Coverage
14.74%
:white_check_mark:


Scrolling down the mod list shows invisible items

The list seems to be empty after 2nd page but the items are still clickable. Have about 50 mods installed now. After searching with pattern scrolling not works anymore.

it seems to only show about 20 mods for me, how about you Knito?

@Hellzbellz123  Same for me. Thanks for seconding me. I really thought that only happens to me.

yeah it seems to be a bug, if you happen to remember mod names you can filter the list to show ones past the 20 limiut

Exactly.


MINOR: Log lastCaughtUpTime on ISR shrinkage

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
This is for better observability of URPs for troubleshooting.
When troubleshooting a URP issue, while the log already contains the out-of-sync replica's LogEndOffset, it would be helpful to also have the lastCaughtUpTime of the replica, which is also used for determining if it's in-sync.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
No behavior changes other than the log message body.  CI should be sufficient.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@clolov for visibility


Add ability to clear Recent History

This is Issue 39 moved from a Google Code project.
Added by 2011-07-06T23:03:23.000Z by<EMAIL_ADDRESS>Please review that bug for more context and additional comments, but update this bug.
Original labels: Type-Enhancement, Priority-Medium
Original description
What steps will reproduce the problem?
1. File -> Recent History
2.
3.

What is the expected output? What do you see instead?
There should be a way to delete individual entries, say check boxes, and there should be a delete all as well.

What version of the product are you using? On what operating system?

Please provide any additional information below.

Support for clear recent history is added in https://github.com/zufuliu/notepad2/commit/91e571d290d17593ece8f0633ce9f1ee937d6a52.


Documentation

Hi! Are there any plans to write documentation with some basic examples of usage?

Hi !
This tool is based on Swagger, you can find tools here: http://swagger.io
Here are swagger specifications: https://github.com/swagger-api/swagger-spec/blob/master/versions/2.0.md


DataTables Bower package

Hi,
I'm getting in touch as I'm the author of the DataTables library and I was wondering if you might be willing to transfer the ownership of the bower datatables-bootstrap package name to myself?
I'm currently in the process of updating my packaging for DataTables to ensure that the various packages are all consistent in their availability on bower and npm and it would be great if the packages could all have consistent names. This appears to be the only one that is currently taken in bower and I would be very greatful if you could let me take over it so I can publish and support the package as part of the DataTables core software.
If you are willing to do this, bower has an unregister command that could be used.
Happy to answer any questions you might have of my packaging plans for DataTables!
Regards,
Allan

I'm going to give it a different name - you can ignore this request :-)


[5.8] add strict param to Str::contains method

Migrate containsAll() to contains() by just adding $strict param

If containsAll is already contained in a tagged release, then we can't remove it now.


[SPARK-7308][WIP] prevent concurrent attempts for one stage

Reproduction of multiple concurrent stage attempts, and a fix.  This actually doesn't completely solve the problem, but it is a vast improvement.  I wanted to put this up so others could take a look at the test case, since the DAGScheduler is tricky (the purpose of the PR at this point is mostly just the failure reproduction).
I'd recommend reviewers check out a branch with just has the failure reproduction, without the fix here: https://github.com/squito/spark/tree/SPARK-7308_failure_reproduction.  Run this test -- even just watch the logs with tail -f core/targer/unit-tests.log | grep DAGScheduler and you will see some really weird behavior: Stage 2 has multiple concurrent attempts, which appear to stomp all over each other; Stage 3 get submitted before Stage 2 ever finishes, and then it will rapidly fire off a bunch of attempts which all quickly die (I've seen > 50 attempts); and lots of executors continue to get lost, though the test case only simulates one executor getting lost.
Even with the fix here atm, we still see concurrent attempts for stage 3, and the first several die from corrupted streams.  However, these failures are recovered from consistently -- the job completes successfully.  But, that could be just b/c the test case isn't complicated enough, so that definitely needs to be fixed as well.  I have a vague idea of how its happening and think I can fix it.

Merged build triggered.

Merged build started.

Test build #32073 has started for   PR 5964 at commit 7fbcefb.

Test build #32073 has finished for   PR 5964 at commit 7fbcefb.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32073/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32076 has started for   PR 5964 at commit 2eebbf2.

Test build #32076 has finished for   PR 5964 at commit 2eebbf2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32076/
Test PASSed.

Build triggered.

Build started.

Test build #32558 has started for   PR 5964 at commit 05c72fd.

Test build #32558 has finished for   PR 5964 at commit 05c72fd.

This patch fails Scala style tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
class SparkIllegalStateException(message: String, cause: Throwable)
class IndexShuffleBlockManager(conf: SparkConf) extends ShuffleBlockResolver with Logging

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32558/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32564 has started for   PR 5964 at commit 31c21fa.

Test build #32564 has finished for   PR 5964 at commit 31c21fa.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32564/
Test FAILed.

Merged build finished. Test FAILed.

Merged build triggered.

Merged build started.

Test build #32628 has started for   PR 5964 at commit 93592b1.

Test build #32628 has finished for   PR 5964 at commit 93592b1.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SparkIllegalStateException(message: String, cause: Throwable)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32628/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #32630 has started for   PR 5964 at commit ea2d972.

Test build #32630 has finished for   PR 5964 at commit ea2d972.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SparkIllegalStateException(message: String, cause: Throwable)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/32630/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #33278 has started for   PR 5964 at commit 6654c53.

Test build #33278 has finished for   PR 5964 at commit 6654c53.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SparkIllegalStateException(message: String, cause: Throwable)
        s" but class priors vector pi had $
        s" but class conditionals array theta had $
class KernelDensity extends Serializable

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33278/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #33291 has started for   PR 5964 at commit dd2839d.

Test build #33291 has finished for   PR 5964 at commit dd2839d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SparkIllegalStateException(message: String, cause: Throwable)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/33291/
Test PASSed.

Would love to get some feedback from the scheduler maintainers: @mateiz @markhamstra @kayousterhout @pwendell

I haven't yet looked at this closely, but is it possible to split this change into different pull requests, one for each issue?

@kayousterhout I debated doing that, but I kept them together b/c my test case produces all four.  So I wouldn't have passing tests unless I addressed them all.  (Though I could actually relax the criteria in the test so 3 & 4 were unnecessary.)
To put it another way: I'm happy to restructure this for merging.  But, I feel that reviewers should consider all of the issues together to properly grasp what is going wrong in the existing implementation.  Again, I'd like to stress running the reproduction and seeing what is wrong (ideally adding a loop and running it many times) , that is far more important than the diff for reviewing this IMO.
Though maybe this also leads to another question for reviewers -- how do you feel about that test?  Its unlike our other unit tests, in that it doesn't try to very narrowly recreate one issue.  instead it simulates a workload, with some randomization.  The downside of that test is, its slow and you can't easily tease apart the different issues into separate tests.  But the upside is that you actually get better coverage -- eg., I wouldn't have discovered issue (2) without this.

all that said, I do see the value in separating them out as well, so I'll do that in addition.  But I'd still like reviewers to consider this holistically :)

Mostly I care about separating (1), since it seems like its handling is totally separate from the other issues; can you put the fix to that in its own pull request (or move the other changes into their own pull request)?  For that issue, it seems possible to write a narrow unit test to test the specific issue (I wrote two such tests here that you should be able to mostly re-use, if you like: https://github.com/kayousterhout/spark-1/commit/2b7d23299251a858f13e600d58bb616bf38d7c73; the first test passes but the second one fails with the current code).  I find that preferable to the end-to-end test that you wrote, since it makes it easier to debug the issue when the test fails, and the test also runs much more quickly.
I'm also a little confused about how this fixes (1), as I commented on in the code.

closing, since I've broken this into separate prs -- thanks for the comments everyone, would appreciate reviews of https://github.com/apache/spark/pull/6648 and https://github.com/apache/spark/pull/6750


Ensure successful storage of cryto materials in vault by Corda Enterprise helm charts

Description
As a developer I want to check and ensure that the store certs are successfully storing the cryto materials in vault.
Acceptance Criteria

Checks to ensure cryto successfully stored
Retry logic based on the above check
Add retry logic for reading from vault

I will work on this issue

@surabhi-dudhediya is it ok to take this issue?

@surabhi-dudhediya is it ok to take this issue?

@TonyRowntree yes you can work on this issue


More informative notifcations

Notifications would be more helpful if details about the trade were also sent such exactly how much ends up being traded.
This is possible if the trader module is running before the notifying modules such as mailer.
Is it? If so, is it worth exploring how the trader module could log the exact details of the trade to be retrieved a few moments later by the notifying modules?

Yes! Exactly this is being worked in in #737. How it works is that the "roundtrips" visible in the UI (right now for backtesting and paper trading only) will hold information regarding the execution price.
Note that this requires quite a few changes (per exchange as well as through the codebase).

I am closing this as it's functionality that is coming soon.


feat(dh): calculations subscriptions in graphql

Since I'm on parental leave and won't be back until Feb. 19, this PR will remain unfinished for the time being. Feel free to close it if you wish to, I can always dig up the work later.

Codecov Report

Merging #1982 (be1e0a4) into main (4e67843) will increase coverage by 10.61%.
Report is 50 commits behind head on main.
The diff coverage is 5.88%.

@@             Coverage Diff             @@
##             main    #1982       +/-   ##
===========================================
+ Coverage   16.89%   27.51%   +10.61%
===========================================
  Files          73       89       +16
  Lines        1663     1999      +336
  Branches      150        0      -150
===========================================
+ Hits          281      550      +269
- Misses       1372     1434       +62
- Partials       10       15        +5

Files Changed
Coverage Δ

...urce/DataHub.WebApi/Clients/EDI/ArchivedMessage.cs
0.00% <0.00%> (ø)

...e/DataHub.WebApi/Clients/EDI/ArchivedMessageDto.cs
0.00% <0.00%> (ø)

...taHub.WebApi/Clients/EDI/ArchivedMessagesSearch.cs
0.00% <0.00%> (ø)

...i-dh/source/DataHub.WebApi/GraphQL/GraphQLQuery.cs
0.00% <0.00%> (ø)

...-dh/source/DataHub.WebApi/GraphQL/GraphQLSchema.cs
0.00% <0.00%> (ø)

...urce/DataHub.WebApi/GraphQL/GraphQLSubscription.cs
0.00% <0.00%> (ø)

...pi-dh/source/DataHub.WebApi/GraphQL/Types/Actor.cs
0.00% <0.00%> (ø)

...ource/DataHub.WebApi/GraphQL/Types/ActorDtoType.cs
0.00% <0.00%> (ø)

...ataHub.WebApi/JwtWebSocketAuthenticationService.cs
0.00% <0.00%> (ø)

apps/dh/api-dh/source/DataHub.WebApi/Startup.cs
92.64% <100.00%> (+0.05%)
:arrow_up:

... and 19 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Closed in favor of https://github.com/Energinet-DataHub/greenforce-frontend/pull/2758


matcher helper for mutiple http route entry matching

Title: matcher helper for mutiple http route entry matching
Description:
If we have mutiple routes with query match, regex path match, prefix path match, etc, we may call removeQueryAndFragment, parseQueryString, etc repeatedly. When I have a large number of routes, this may introduces some non-negligible overhead.
May be we can create a simple matcher helper which will lazily create query parameter map, path without query, etc, only once for all routes.
Just something like following.
class MatchHelper {
public:
  explicit MatchHelper(const Http::RequestHeaderMap& headers)
      : headers_(headers), path_(headers_.getPathValue()),
        path_without_query_(Http::PathUtil::removeQueryAndFragment(path_)) {}

  const Http::RequestHeaderMap& requestHeaders() const { return headers_; }
  absl::string_view path() const { return path_; }
  absl::string_view pathWithoutQuery() const { return path_without_query_; }
  const Http::Utility::QueryParams& queryParams() const {
    if (query_parameters_.has_value()) {
      return query_parameters_.value();
    }
    query_parameters_->emplace(Http::Utility::parseQueryString(path_));
    return query_parameters_.value();
  }

private:
  const Http::RequestHeaderMap& headers_;
  absl::string_view path_;
  absl::string_view path_without_query_;
  mutable absl::optional<Http::Utility::QueryParams> query_parameters_;
};

/cc @zhxie

Yes, I agree that we need to remove these overheads. Since the issue is marked as beginner, I may leave to someone new to the community to have a try.

This may need updates all the match method of route entry and related tests. I am not sure it's easy enough for beginner.

I prefer a simple helper to do this, which avoids modifying the RequestHeaderMap API. That's a bigger impact. 🤔

I have evaluated the code path. removeQueryAndFragment and parseQueryString are majorly called by router which takes the RequestHeaderMap for routing and headers modification. Since the router can be used by multiple requests, I think it is impossible to store path and queryParams in the router itself if we do not want to modify the RequestHeaderMap.

For each request, only once path rewrite is triggered. But if we have mutiple routes, the matching will be triggered repeatly. So I am still inclined to solve the problem in the matching process. In this way, our modifications to the core code will be relatively small, and we can obtain good benefits.


How to work around AppDynamics sign in prompt

AppDynamics SSO is not a truly automated experience, and it will require end user interaction when signing in to the site, mainly for adding the Compay Name in AppDynamics in the Account Name field. I have found that there is no prompt for such value, and only a sign in approval is required, if the Sign in URL is built as: https://<companyname>.saas.appdynamics.com?accountName=<companyname>.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6226b8c4-ea1a-dc04-835a-23d87d040789
Version Independent ID: 5405006e-cc40-93f3-711a-d41bb97a6ab7
Content: Tutorial: Azure Active Directory integration with AppDynamics
Content Source: articles/active-directory/saas-apps/appdynamics-tutorial.md
Service: active-directory
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@ermacia91 Thanks for reporting this. We have tested this suggestion on the sign on URL and it is working as expected.
@chetansriv Can we please make this change in the doc as per the suggestion here?

@v-viinde For your action.

Tutorial updated as requested.
#please-close

@ermacia91 We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


All SDK diff tests are failing today

https://dev.azure.com/dnceng/internal/_build/results?buildId=2433380&view=artifacts&pathAsName=false&type=publishedArtifacts
MsftToSbSdkFiles.diff.txt
UpdatedMsftToSbSdkFiles.diff.txt
It seems that ./sdk/x.y.z/<lang>/Microsoft.Build.NuGetSdkResolver.resources.dll is missing for all languages.

Closing since all related PRs have been closed.


Match entire word from list of items when using livesearch

Hi,
I'm using bootstrap-select with livesearch, and I was wondering if there's a way to match the exact word. I've tried using "startsWith" and "contains", but because I am using a .json file to show a list of items - also using ajax-bootstrap-select for this - it tends to show the entire list of items, not matter what option I use. So, my question is: what should I do to match an entire word, and not just the characters it starts with or contains?
Thanks!

Duplicate of https://github.com/snapappointments/bootstrap-select/issues/1482


Documentation Overhaul

Problem
There are two current sources of documentation: the README and  the Github Pages site. The GitHub pages site is out-of-date and visually hard to read. Currently, it should not be used or referenced at all. The README is up-to-date but very long and hard to quickly grok. The current GitHub pages site has the exact same structure and content as the README.
Proposal
Keeping all documentation in the README isn't sustainable or user-friendly. Moving content to the built-in wiki isn't a great idea because the collaborative features are lacking. Instead, let's redo the GitHub pages site and make it the authoritative documentation source. The README will simply contain headings and links to the most important pages in the documentation.
Questions:

What tooling do we want to use to create/maintain the site? Jekyll? Or something else?

Fancy Possible Features:

Generate documentation of rules automatically from metadata contained in each rule (#674).

related: #531

It would be helpful to have an explanation and example of some of the rules and how they affect quality as I'm not sure how too much or too little white space affects code quality. Some of these rules may be more about style and writing error-free code, but a guide outlining the differences between style and quality would be helpful. The following rules were especially confusing to me as I couldn't figure out how important they are to overall quality: align, member-ordering, whitespace.

Also related, this comment

Website updated so it's at least readable and reflects the content of the current README. More changes coming in the future

Reference for a good way to set things up so that you can generate documentation for source code easily onto the gh-pages branch.

The new documentation site is progressing slowly: http://palantir.github.io/tslint/
It's (very obviously) a WIP, so if anyone is interested in contributing their design or Jekyll skills, let me know!


Improve FileNotFoundException ctor definitions

I initially started on this as the FileNotFoundException(String, String, Exception) summary was missing a mention of the fact it took a file name parameter.
I also then standardised the descriptions, including:

the HRESULT values was specified in 3/6 ctor definitions. In my opinion, this is fine being specified in the remarks of the class, rather than the ctor definition.
The message parameter was referred to in different ways for different ctor's, when behaviour is the same. I used the phrase specified error message - which seemed consistent with other docs pages.

Here's the current page: https://docs.microsoft.com/en-us/dotnet/api/system.io.filenotfoundexception?view=netframework-4.7.1#Constructors
(Hooray for section links!)

@rpetrusha Sorry - I was unclear!
The HRESULT is currently specified in the Remarks section for the Class. This seemed a better place than the constructors to me - as presumably it's the same however the class is constructed - and there's less duplication of information that way. Do you agree? I add it to the ctor remarks as well if you think it should be there - but it's not currently in the ctor remarks for any of the constructors.

I hadn't noticed the HRESULT in the class topic, @ChrisMaddock. Ordinarily, my preference would be to include the HRESULT information, but our page view data for constructors suggests that it just isn't that important.  So I agree with you. We'll merge your PR, and your changes should appear live on docs.microsoft.com in the next day or two. Thanks for fixing these constructor descriptions; it's a small but substantial improvement to the documentation.

Great, thanks @rpetrusha


API: Allow file uploads from the UI

User Story
As a user, I want to be able to choose a file, or drag and drop a file to use as my own community template.
Background
The drag and drop component we use internally makes use of the FileReader API, specifically these methods dealing with the contents of file uploads.
Acceptance Criteria

[ ] Using a local file version of a yaml file from github has the same effect as uploading it from github

Spoke with Johnny about this. The API allows for posting file contents like this in a payload.


CI

Does this still work on Python 3.7/3.8/etc?
Needs CI.

Hi,
It's been quite a while since I worked on this. I don't see why it wouldn't
support Python 3.x. If you could state your use case, I'd love to help.
On Thu, 31 Oct, 2019, 6:24 AM John Vandenberg<EMAIL_ADDRESS>wrote:

Does this still work on Python 3.7/3.8/etc?
Needs CI.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apratheek/PyReactive/issues/1?email_source=notifications&email_token=AB74FEVAGXIFDE7C4VHHUJLQRIUD5A5CNFSM4JHCNAJ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HVTON5Q,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB74FEXYSGBZ7PZBR2N4METQRIUD5ANCNFSM4JHCNAJQ
.

I can't make it work with Python 3.6.7
from pyreactive import *
a = Observe(5.0, name='a')
b = Observe(8.0, name='b')
# sum = Subscribe(vars=(a,b), op=('+',))
sum = Subscribe('a+b')

It raise an error:
ValueError: could not convert string to float:


Document storage requirements of IBM Cloud OCP's internal Docker registry

docker push into an internal Docker registry of OCP on IKS sometimes fails with received unexpected HTTP status: 504 Gateway Time-out. This is due to the low IOPS of the backing storage of the registry's PV.
To get around this problem, users can change IOPS of the existing backing storage device of the PV. See Changing the size and IOPS of your existing storage device for how to increase the IOPS.
After I upgraded the storage config to the gold tier with higher IOPS, I didn't see the issue: ibmcloud sl file volume-modify <volume_ID> --new-tier 10
Since this could be a common issue for users, this should be documented in the common problems doc.
Note that the default config of the registry's PV is the Bronze tier storage class and 20Gi. Given how big tWAS image sizes, it might be good to also document that users can increase the size of the backing storage while switching storage tier.

@bschrammIBM We need to add this guideline to the documentation for running Kabanero in an IKS-managed OCP instance.

Link to PR for review; couldn't add @navidsh or @stevemar as reviewers.
https://github.com/kabanero-io/docs/pull/169

@aadeshpa could you also please see if our storage & troubleshooting docs in Kabanero should also to reflect this.

Just so you know, in response to the usabilla issue that was opened for the Red Hat OpenShift on IBM Cloud docs, we added a troubleshooting topic for this: https://cloud.ibm.com/docs/openshift?topic=openshift-openshift_troubleshoot#roks_timeout_docker

@aadeshpa could you also please see if our storage & troubleshooting docs in Kabanero should also to reflect this.

@kvijai82  Added the troubleshooting steps in our troubleshooting guide.
Pull request: https://github.com/kabanero-io/kabanero-pipelines/pull/122

@navidsh can this issue be closed now?

Doc changes are delivered. Closing this one.


Small fixes and Agreement Modal

Should fix #120.
I refactored the agreement modal and made it so it only handles 'being a modal' (changing settings is done in main now). After the settings load, the plugin prompts for the modal if they haven't agreed yet. If they agree it will continue with the rest of the onLoad as usual. This should fix the issue since before if they hadn't agreed, it wouldn't toggle the features on.
I also updated the lang for the modal as well.

Awesome, looks great! Thank you!


Steps to reproduce:

Try to import project

Minimal reproduction project:
RRR.zip

Confirmed on a737bce. It doesn't happen on ddc42be1d, so given the backtrace I assume it's caused by #31845.

Figured it out, when rendering probes we need to exit early.
GLES3 code
https://github.com/godotengine/godot/blob/f9e9cc94cdfcf1bc1dd43e9d61e1394908835099/drivers/gles3/rasterizer_scene_gles3.cpp#L4266-L4294
https://github.com/godotengine/godot/blob/f9e9cc94cdfcf1bc1dd43e9d61e1394908835099/drivers/gles3/rasterizer_scene_gles3.cpp#L4622-L4625
GLES2 code that needs to be updated to match above
https://github.com/godotengine/godot/blob/f9e9cc94cdfcf1bc1dd43e9d61e1394908835099/drivers/gles2/rasterizer_scene_gles2.cpp#L3210-L3227
Exit early before post_process
https://github.com/godotengine/godot/blob/f9e9cc94cdfcf1bc1dd43e9d61e1394908835099/drivers/gles2/rasterizer_scene_gles2.cpp#L3510-L3513


Find command only works with prefixes

Perhaps we could make it work without prefixes as well? Since users might not know whether their keywords are in description or tags, and some words could be repeated for description, name, and you might want to search for all projects with this keyword in any of the fields.
EX) find all projects with keyword 'hello' in any field
current command: find match/any n/hello t/hello d/hello
possible command after update: find hello (assumes match/any)
I think this might come in handy for users who are more 'lazy' and just want a simple command to filter out projects. It will also be useful when users don't recall which field the keyword goes under. What do the rest think?

So no prefix will mean match any be default?

Yup I think that will be good

Feature will not be implemented.


Crash possible in VBox.median method if lengthOfLongest is negative

It's not been easy to reproduce reliably but I see a crash happening in the VBox.median method on this line
var slicesSums = [Int](repeating: 0, count: lengthOfLongest + 1)
I believe the only thing that can trip this up is if somehow  lengthOfLongest is negative. The only way this is possible is if somehow the minPixel values are larger than the maxPixel values.
Any idea how to best guard against this?

Did you come up with a solution?
My workaround was to make length(along: dimension) always positive.


Setup script should abort in case of any single error

Now since openbank uses edge-launchpad, I think its better to create a issue or feature request in Edge-launchpad for this.
Currently Edge-launchpad doesn't provide any option to abort deployment in case of error.


The link of [list of available themes] in this page is wrong.

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Description
The link of [list of available themes] in this page is wrong.
The link should be https://github.com/FormidableLabs/prism-react-renderer/tree/master/packages/prism-react-renderer/src/themes.
Self-service

[ ] I'd be willing to address this documentation request myself.

The link is https://github.com/FormidableLabs/prism-react-renderer/tree/master/src/themes now.


Support for MoveCall and Contract-Upgrade via Multi-Signature

Description
We are currently using Multi-Signature account to upgrade our contract and manage it as an admin. However, we have encountered an issue with sui tools as they do not yet support MoveCall and Package-upgrade. We are in urgent need of this feature and would like to request that it be added to the sui tools.
MoveCall and Package-upgrade are critical functionalities that would enable us to efficiently manage our contract and upgrade it as needed. We believe that the inclusion of these features in sui tools would greatly enhance our experience and make it easier for us to manage our contract.
Furthermore, this functionality will be also needed for other teams when mainnet launch. It will increase the overall security of all protocols deployed to sui network.
We would appreciate it if the sui tools team could prioritize the addition of MoveCall and Package-upgrade support in Multi-Signature account. We are looking forward to hearing from you soon.

And why dest sui tools not support import/export private key?

Would you mind sharing more detail about which tools do not support multi-sig? In the CLI, you should be able to do an upgrade with a multi-sig account like this:
sui client upgrade <my_package> -- serialize-output # will dump base64 tx
sui keytool sign --data <base64_tx> --address <my_multi_sig_address>

Would you mind sharing more detail about which tools do not support multi-sig? In the CLI, you should be able to do an upgrade with a multi-sig account like this:
...

I ran sui client upgrade --upgrade-capability <UPGRADE_CAPABILITY> --gas-budget 500000000 <my_package> --serialize-output, but got error:
error: Found argument '--serialize-output' which wasn't expected, or isn't valid in this context

        If you tried to supply `--serialize-output` as a value rather than a flag, use `-- --serialize-output`

USAGE:
    sui client upgrade --upgrade-capability <UPGRADE_CAPABILITY> --gas-budget <GAS_BUDGET> --skip-fetch-latest-git-deps <package_path>

Is this feature new? I'm using the version from a week ago.

My mistake--I thought --serialize-output was a global option, but I see that it was specific to publish and was indeed not supported by upgrade.
I put up https://github.com/MystenLabs/sui/pull/11233 to make all tx construction commands support --serialize-output.


set dependencies to purge cache when updated appveyor.yml.

Same as https://github.com/mizzy/serverspec/pull/539 .

Thanks!

Released as v2.44.0.


[Windows 10] Iguana crashes after adding 9 coins in Basilisk Mode

Yassin tried multiple times, always crashed with 9 coins.

need steps to replicate.

confirmed
max active coin limit is going to be set to 6
so only 6 coins per sessions


AVX-512BW functions

https://software.intel.com/sites/landingpage/IntrinsicsGuide/#avx512techs=AVX512BW
For progress, see https://github.com/simd-everywhere/implementation-status/blob/main/x86.md#avx512bw

Hello, I would like to contribute to this project by implementing functions. Would this issue be a good place to start? I noticed that there are several active contributors so I want to make sure I don't end up working on same functions as another contributor.
Thanks,
-kg

Welcome @karangovil ! I don't think anyone is targeting 512BW, except as it overlaps with other parts. Feel free to grab any of the un-checked boxes.

Welcome @karangovil, thanks for your interest in contributing!
I agree with Michael, I just wanted to add that I think the _mm512_min_* and _mm512_max_ functions would probably be the easiest place to start if you want a gentle introduction to the project.  There is an Implementing a New Function document in the wiki that might be helpful if you haven't already seen it.
If you have any questions please don't hesitate to ask either here, in the chat room, on the mailing list, or I'm available via e-mail.

Thanks @mr-c and @nemequ for your supportive comments and suggestions. I will start with the _mm512_min_* and_mm512_max_. Looking forward to contributing!

Hi, is this still open? Would like to take a crack at this!

Hello @rahulgo , you would be very welcome to contribute implementations of any of the unchecked functions, yep!

@mr-c Thanks! I am not a very experienced programmer, can you suggest a relatively easy function to implement as a starting point?

Hi @rahulgo, thanks for your interest in contributing!
Unfortunately it looks like most of the most straightforward functions are already implemented, but there are a few good first functions left, such as _mm512_sllv_epi16, _mm512_srlv_epi16, and _mm512_srav_epi16.
Once the main function has been implemented, adding the mask and maskz variants is quite easy, too; if you take a look at a few you'll notice they all follow the same basic pattern, so just copying, pasting, and changing a function name should be enough for the implementation, then you just need to generate a test vector.
If you run into trouble you might want to stop by our chat room and hopefully someone can give you a hand.
Do you have access to AVX-512BW hardware to test on?  You can use the Intel SDE, but it's a bit slow.  If you have to go that route, please not that you can specify which function you want to test as an argument to the run-tests executable. For example: path/to/sde64 -- ./run-tests /x86/avx512bw/mm512_sllv_epi16.

Hello ! Is this still open ? I wanted to contribute to the project, was thinking maybe I can try implementing some of the functions. From what I understand unchecked ones are missing. Are there any that you would suggest someone to start with ? Thanks!

Hello ! Is this still open ? I wanted to contribute to the project, was thinking maybe I can try implementing some of the functions. From what I understand unchecked ones are missing. Are there any that you would suggest someone to start with ? Thanks!

Hi, thanks for your interested in contributing :)  Yes, this issue is still open.
Instead of one file per ISA extension (e.g., avx512bw.h, avx512f.h, avx512cd.h, etc.) we now have one one file per function family.  For example, all the AVX-512 add functions are in simde/x86/avx512/add.h, including the ones from AVX-512F, AVX-512BW, and AVX-512VL.  That should make it a bit easier to see how things fit together.
I think the div functions would probably be a good place to start; they should be pretty straightforward, and only the floating point ones are currently done so there are plently more.
If you have any questions please let me know, I'm happy to help :)

Hey guys. I'm actually really happy to have found you. I'd like to make use simd for our https://github.com/contour-terminal/libunicode 's implementation for text scanning. There I'd need AVX512BW. Currently we only support basic SSE2 and std::simd doesn't seem to support runtime detection, so I need to look over the fence a bit and then found you :)

Hello @christianparpart ! Do you have a list of functions?
For AVX512BW, SIMDe has portable implementations for 337 of 790 (42.66%) as of version 0.8.0
https://github.com/simd-everywhere/implementation-status/blob/main/x86.md#avx512bw


Export package.json

Fixes #907 (see the issue for context)

Member of the Node.js modules team here. It is likely a very good idea to land this change. package.json needs to be explicitly exported.

@jimmywarting Are you able to release a new beta containing this update?

@wheresrhys See #912

Thank you

@wheresrhys Released v3.0.0-beta.8.


[BACKLOG-20802] Implement fix for Text and Hadoop File Output step to…

@rmansoor

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/Const.java
  engine/src/main/java/org/pentaho/di/trans/steps/concatfields/ConcatFields.java
  engine/src/main/java/org/pentaho/di/trans/steps/textfileoutput/TextFileOutput.java
  engine/src/main/java/org/pentaho/di/trans/steps/textfileoutput/TextFileOutputData.java
  engine/src/test/java/org/pentaho/di/trans/steps/textfileoutput/TextFileOutputTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.trans.steps.salesforceupsert.SalesforceUpsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on core/src/main/java/org/pentaho/di/core/Const.java. Found 2017. Was expecting 2018

:heavy_exclamation_mark: Copyright year is not the current year on engine/src/main/java/org/pentaho/di/trans/steps/concatfields/ConcatFields.java. Found 2017. Was expecting 2018

:heavy_exclamation_mark: Copyright year is not the current year on engine/src/main/java/org/pentaho/di/trans/steps/textfileoutput/TextFileOutput.java. Found 2017. Was expecting 2018

:heavy_exclamation_mark: Copyright year is not the current year on engine/src/main/java/org/pentaho/di/trans/steps/textfileoutput/TextFileOutputData.java. Found 2017. Was expecting 2018

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'engine,core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/core/Const.java
  engine/src/main/java/org/pentaho/di/trans/steps/concatfields/ConcatFields.java
  engine/src/main/java/org/pentaho/di/trans/steps/textfileoutput/TextFileOutput.java
  engine/src/main/java/org/pentaho/di/trans/steps/textfileoutput/TextFileOutputData.java
  engine/src/test/java/org/pentaho/di/trans/steps/textfileoutput/TextFileOutputTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: <0.1% (click to expand)
org.pentaho.di.job.entries.evaluatetablecontent.JobEntryEvalTableContent

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.step.StepMeta

Branch Change: -0.7% :small_red_triangle_down:
Complexity Change: -0.6% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.concatfields.ConcatFields

Branch Change: -1.8% :small_red_triangle_down:
Complexity Change: -0.9% :small_red_triangle_down:
Instruction Change: -3.1% :small_red_triangle_down:
Line Change: -5.4% :small_red_triangle_down:
Method Change: -3.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.csvinput.CsvInputMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.datagrid.DataGridMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -1.7% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

org.pentaho.di.trans.steps.insertupdate.InsertUpdateMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.singlethreader.SingleThreaderMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.synchronizeaftermerge.SynchronizeAfterMergeMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.textfileoutput.TextFileOutput

Branch Change: -1.8% :small_red_triangle_down:
Instruction Change: -3.7% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:
Method Change: -10.1% :small_red_triangle_down:

:new: org.pentaho.di.trans.steps.textfileoutput.TextFileOutputData.FileStreamsKey

Complexity Coverage: 42.9% :exclamation:
Instruction Coverage: 58.5% :exclamation:
Line Coverage: 53.8% :exclamation:
Method Coverage: 42.9% :exclamation:

:new: org.pentaho.di.trans.steps.textfileoutput.TextFileOutputData.FileStreamsMap

Branch Coverage: 50% :exclamation:
Complexity Coverage: 60% :exclamation:
Instruction Coverage: 65.4% :exclamation:
Line Coverage: 75% :exclamation:
Method Coverage: 75% :exclamation:

:new: org.pentaho.di.trans.steps.textfileoutput.TextFileOutputData.FileStreamsValue

Branch Coverage: 50% :exclamation:

org.pentaho.di.www.TransformationMap

Branch Change: -9.1% :small_red_triangle_down:
Complexity Change: -6.2% :small_red_triangle_down:
Instruction Change: -10% :small_red_triangle_down:
Line Change: -10% :small_red_triangle_down:

org.pentaho.di.trans.steps.gpload.GPLoadMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:

Note: The list of offending coverage changes extends beyond the presented results and was truncated to prevent reaching the comment size limit.


Updated the Json Library version in the dependency list.

I found this library after a bit of a search, and wanted to use it in an Open-Source Android app called Mastalab, when including your version Android Studio moans about the version of Json conflicting with that shipped in Android.
I've updated the dependency, and now Android Studio no longer moans.
Thought you might want the update.

Coverage remained the same at 93.125% when pulling 14ceb5414579ed06488b73eb0c5c802ea2c78fa5 on PhotonQyv:UpdatedJsonLibraryDependency into 163553ba96f36d39ef0597ce120d461bd5a613e2 on vdurmont:master.

Coverage remained the same at 93.125% when pulling 40ea146529b9ec46d637c3d8715042a50277026b on PhotonQyv:UpdatedJsonLibraryDependency into 07d8df2326b2cb112ae7e0526da98a8eee97c530 on vdurmont:master.

Coverage remained the same at 93.125% when pulling 4e1c8eb13443d0f8fd68bc0dda8d6726a095efdc on PhotonQyv:UpdatedJsonLibraryDependency into 07d8df2326b2cb112ae7e0526da98a8eee97c530 on vdurmont:master.


[Puppeteer Helper] checkOption wrong(?) behaviour and missing uncheckOption

What are you trying to achieve?
I was just testing out the checkOption command under Puppeteer helper. Ideally:

we would also have the uncheckOption command which is currently missing from this helper
if I call checkOption two times on the same element it should only check it the first time i.e not attempt to check it again and thus mistakenly uncheck it

What do you get instead?

uncheckOption is not implemented for Puppeteer helper
checkOption behaviour is broken I think

if I do
Scenario('my scenario', I => {
    I.checkOption('#elm');
    I.checkOption('#elm');
});

it will check it both times at the moment
I looked at the code and the function looks like this:
  async checkOption(field, context = null) {
    const els = await findCheckable.call(this, field, context);
    assertElementExists(els[0], field, 'Checkbox or radio');
    if (await els[0].getProperty('checked') === true) return;
    await els[0].click();
    return this._waitForAction();
  }

so there is a check in place but I think it's wrong, if I replace line if (await els[0].getProperty('checked') === true) return; with something like if (await els[0].getProperty('checked').then(el => el.jsonValue()) === true) return; it then works as expected.
So basically you have to extract the json value from that call before checking the boolean.
Then implementing uncheckOption is simple enough I think, you copy most of the checkOption functionality but instead of checking for === true you check for === false so you don't uncheck something that is already unchecked.
I tested both my fix and the addition of uncheckOption and they work locally for me. I am happy to make a PR for both if you decide that'd be useful.
Thanks
Details

CodeceptJS version: I am testing with up-to-date master branch code
NodeJS Version: v8.11.0
Operating System: macOS

Just push your PR, I think it's always more than welcome!


Support panic and trap for jvm target

Purpose
Support panic statement in bir and initial implementation of jvm codegen.
Panic example
ex.
type AccountNotFoundError error<string, string>;
function getAccountBalance(int accountID) returns int {

        string errorReason = "Account Not Found";
        AccountNotFoundError accountNotFoundError =
                                            error(errorReason,"3");
        if(accountID == 0){
            panic accountNotFoundError;
        }
        return accountID;

}

public function main() returns int {
    var result = getAccountBalance(0);
	return result;
}

this will result in
Exception in thread "main" Account Not Found 3
at hello.getAccountBalance(Unknown Source)
at hello.main(Unknown Source)
at hello.main(Unknown Source)
Trap sample
public function main() returns error? {
   var x =   trap foo(0);
   if ( x is error) {
       return x;
   }
}

public function foo(int x) returns error|int  {
     if(x == 0){
        panic error("reason", {"message":"detail"});
    } else {
        return x;
    }
}

this will result in
reason {"message":"detail"}
Todos
We use java stacktrace directly when printing. This required to be formatted to comply with bal stacktrace.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@ec2e05e). Click here to learn what that means.
The diff coverage is 14.06%.

@@            Coverage Diff            @@
##             master   #14485   +/-   ##
=========================================
  Coverage          ?   63.61%
  Complexity        ?      516
=========================================
  Files             ?     2221
  Lines             ?    98389
  Branches          ?    13058
=========================================
  Hits              ?    62589
  Misses            ?    30869
  Partials          ?     4931

Impacted Files
Coverage Δ
Complexity Δ

.../org/ballerinalang/packerina/cmd/BuildCommand.java
20.28% <ø> (ø)
0 <0> (?)

...erinalang/compiler/bir/model/BIRNonTerminator.java
66.66% <0%> (ø)
0 <0> (?)

...rg/wso2/ballerinalang/compiler/bir/BIREmitter.java
0% <0%> (ø)
0 <0> (?)

...java/org/ballerinalang/packerina/BuilderUtils.java
69.35% <0%> (ø)
0 <0> (?)

...va/org/wso2/ballerinalang/compiler/bir/BIRGen.java
60.42% <0%> (ø)
0 <0> (?)

...2/ballerinalang/compiler/bir/model/BIRVisitor.java
4.16% <0%> (ø)
0 <0> (?)

...erinalang/compiler/bir/writer/BIRBinaryWriter.java
89.39% <100%> (ø)
0 <0> (?)

...lerinalang/compiler/bir/model/InstructionKind.java
100% <100%> (ø)
0 <0> (?)

...wso2/ballerinalang/compiler/bir/model/BIRNode.java
63.63% <11.11%> (ø)
0 <0> (?)

...tiveimpl/jvm/methodvisitor/VisitTryCatchBlock.java
12.5% <12.5%> (ø)
0 <0> (?)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec2e05e...d674201. Read the comment docs.


test: fix gcc 8 warnings for tests

In test-ipc.c, remove unnecessarily casting uv_stream_s to
uv_pipe_s that makes gcc complain about stric-aliasing
(-Wstrict-aliasing)
In test-queue-foreach-delete.c, using C99 variadic macros
to fix a gcc 8 warning (-Wcast-function-type)
Fixes #2337

@bnoordhuis Does it look OK to you now?

CI was apparently down. One more time: https://ci.nodejs.org/job/libuv-test-commit/1448/

CI was apparently down. One more time: https://ci.nodejs.org/job/libuv-test-commit/1448/

Oh sorry! I will sync the branch with upstream. The failure was addressed by a recent PR
https://github.com/libuv/libuv/pull/2355
not ok 282 - tcp_try_write_error
# exit code 134
# Output from process `tcp_try_write_error`:
# uv_try_write error: -54 connection reset by peer
# Assertion failed in test/test-tcp-try-write-error.c on line 51: r == UV_EPIPE || r == UV_ECONNABORTED

Certainly. :-) New CI: https://ci.nodejs.org/job/libuv-test-commit/1451/

@bnoordhuis
I believe the leading space in user field caused the failures. There should not be a gap in the middle of the URL here.

git fetch --tags --force --progress https://github.com/ ktrongnhan/libuv.git +refs/heads/:refs/remotes/origin/ # timeout=10

Fresh CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1488/

Landed in https://github.com/libuv/libuv/commit/faa800605e4008e94743dd98195ac085c7a54507. Thanks!


[AkitaNgFormsManager] form array in a form group

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

I don't know if its a missing feature or a bug so I checked both.
Current behavior

The state is properly stored. The issue is when propagating the values from state to FormGroup which has a FormArray.
A console.log on the FormGroup is fine after an upsert. But the field with a FormArray on it is empty.
Expected behavior

The values from state should propagate as well to a FormArray within a FormGroup.
Minimal reproduction of the problem with instructions
A simple form created like this:
buildForm() {
  this.form = this.formBuilder.group({
      name: [],
      traits: new FormArray([])
    });
  this.formsManager.upsert(this.form);
  console.log(this.form) // name is propagated
  console.log(this.form.controls.traits) // empty array even with redux dev tools report having multiple values
}

What is the motivation / use case for changing the behavior?
Only fields in a FormGroup have their values propagated, it would be nice to have it support (fix?) FormArray as well.
Environment

Angular version: 8.1.0

Browser:
- [x] Chrome (desktop) version 60

For Tooling issues:
- Node version: v11.14.0
- Platform:  Windows

You must provide the array control factory.
https://netbasal.gitbook.io/akita/angular-plugins/angular-forms-manager

Hey,
This isn't the relevant repo for this issue. Please use the official repo.
As @danzrou said, you need to provide the array control factory. Also, based on your code, the traits initial value is an empty array.
If you still need help, you can check the official playground, Akita's Gitter channel, or the open an issue in the official repo.


Release '9-2020-q2' is not usable

For some reason it does not seem to exist, but it should.
With release key 9-2020-q2 (https://github.com/rleh/modm/runs/1074306584):
##[error]gcc version 9-2020-q2 is not supported

WIth release key 9-2020-q2-update (https://github.com/rleh/modm/runs/1074311049):
##[error]invalid version 9-2020-q2-update. Available: 9-2019-q4,8-2019-q3,8-2018-q4,7-2018-q2,7-2017-q4,6-2017-q2,6-2017-q1,6-2016-q4,5-2016-q3,5-2016-q2,5-2016-q1,5-2015-q4,4.9-2015-q3,4.9-2015-q2,4.9-2015-q1,4.9-2014-q4,4.8-2014-q3,4.8-2014-q2,4.8-2014-q1,4.7-2014-q2,4.8-2013-q4,4.7-2013-q3,4.7-2013-q2,4.7-2013-q1,4.7-2012-q4

Any ideas?

@rleh I've recently fixed this by creating a v1 branch. I was expecting GH actions to interpret @v1 as a semantic version and automatically pulling tags like v1.0.x, but that's not the case.
I've just setup a test repo with an action using the 9-2020-q2 SDK and it correctly installs it.

Thanks!


node v20

Please add support for node v20 as that is LTS and also preferred by current strapi 4 releases
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package<EMAIL_ADDRESS>npm WARN EBADENGINE   required: { node: '>=14.19.1 <=18.x.x', npm: '>=6.0.0' },
npm WARN EBADENGINE   current: { node: 'v20.11.0', npm: '10.2.4' }
npm WARN EBADENGINE }

Hi there! Indeed, node 20 should be supported without any problem, feel free to open a PR

Hi @ChristopheCVB , I noticed that latest master includes requested updates, please, can you bring update to be available also from npm? There is still 0.9.5 with node <18 version support

@petross3530mx Not sure what I did wrong but I published a new version anyway with latest changes


fix Explorer Eval to use data from all sources

Example:
rn1qkb1r/pQpbpppp/5n2/8/P3p3/2N5/1PPP1PPP/R1B1KBNR b KQkq - 0 6
Because the Bc6 move, which is the most common, doesn't exist in the computer evaluation, it doesn't calculate diff and so it doesn't show the warning.

But at the same time, that would mean loading more data than actually needed. Closing.