[SPARK-30276][SQL] Support Filter expression allows simultaneous use of DISTINCT

What changes were proposed in this pull request?
This PR is related to https://github.com/apache/spark/pull/26656.
https://github.com/apache/spark/pull/26656 only support use FILTER clause on aggregate expression without DISTINCT.
This PR will enhance this feature when one or more DISTINCT aggregate expressions which allows the use of the FILTER clause.
 This is good because we can evaluate filter in first aggregate locally.
If we use AggregationIterator too, the filter conditions of DISTINCT aggregate expr will be treated in second or thrid aggregate.
In order to reduce cost, we treat the filter conditions of DISTINCT aggregate expr in first aggregate or local is better.
So, this PR uses Expand to ensure the evaluation at local.
Why are the changes needed?
Spark SQL only support use FILTER clause on aggregate expression without DISTINCT.
This PR support Filter expression allows simultaneous use of DISTINCT
Does this PR introduce any user-facing change?
No
How was this patch tested?
Exists and new UT

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22479/
Test PASSed.

@maropu @cloud-fan I'm sorry for open a new PR. Because I made some mistake operator.

Test build #117718 has started for PR 27428 at commit 6a32d83.

Test build #117718 has finished for PR 27428 at commit 6a32d83.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117718/
Test PASSed.

Test build #117724 has started for PR 27428 at commit 5c38bbe.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22485/
Test PASSed.

Test build #117724 has finished for PR 27428 at commit 5c38bbe.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117724/
Test PASSed.

Test build #117737 has started for PR 27428 at commit a6498f9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22498/
Test PASSed.

Test build #117737 has finished for PR 27428 at commit a6498f9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117737/
Test PASSed.

cc @cloud-fan

Test build #118021 has started for PR 27428 at commit c6caf73.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22786/
Test PASSed.

Test build #118021 has finished for PR 27428 at commit c6caf73.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AliasIdentifier(name: String, qualifier: Seq[String])
class LegacyDateFormatter(pattern: String, locale: Locale) extends DateFormatter
class LegacyTimestampFormatter(
case class PlanAdaptiveSubqueries(subqueryMap: Map[Long, SubqueryExec]) extends Rule[SparkPlan]

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118021/
Test FAILed.

retest this please

Test build #118027 has started for PR 27428 at commit c6caf73.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22792/
Test PASSed.

Test build #118027 has finished for PR 27428 at commit c6caf73.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class AliasIdentifier(name: String, qualifier: Seq[String])
class LegacyDateFormatter(pattern: String, locale: Locale) extends DateFormatter
class LegacyTimestampFormatter(
case class PlanAdaptiveSubqueries(subqueryMap: Map[Long, SubqueryExec]) extends Rule[SparkPlan]

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118027/
Test FAILed.

Test build #118033 has started for PR 27428 at commit cd00f91.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22798/
Test PASSed.

Test build #118033 has finished for PR 27428 at commit cd00f91.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118033/
Test PASSed.

cc @hvanhovell

retest this please

Test build #121200 has started for PR 27428 at commit cd00f91.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25889/
Test PASSed.

Test build #121200 has finished for PR 27428 at commit cd00f91.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121200/
Test FAILed.

retest this please

Test build #121216 has started for PR 27428 at commit cd00f91.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25904/
Test PASSed.

Test build #121216 has finished for PR 27428 at commit cd00f91.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121216/
Test PASSed.

cc @cloud-fan

retest this please

Test build #124955 has started for PR 27428 at commit 73dc600.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29561/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/124955/
Test FAILed.

retest this please.

Test build #125032 has started for PR 27428 at commit 73dc600.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29639/
Test PASSed.

Test build #125032 has finished for PR 27428 at commit 73dc600.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125032/
Test FAILed.

retest this please

Test build #125057 has started for PR 27428 at commit 73dc600.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29664/
Test PASSed.

Test build #125057 has finished for PR 27428 at commit 73dc600.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125057/
Test FAILed.

Test build #125165 has started for PR 27428 at commit 5a4ca02.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29774/
Test PASSed.

Test build #125165 has finished for PR 27428 at commit 5a4ca02.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125165/
Test FAILed.

retest this please

Test build #125197 has started for PR 27428 at commit 5a4ca02.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29808/
Test PASSed.

Test build #125197 has finished for PR 27428 at commit 5a4ca02.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125197/
Test PASSed.

Test build #125311 has started for PR 27428 at commit 70ff08e.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29922/
Test PASSed.

Test build #125312 has started for PR 27428 at commit 16d8c1d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29924/
Test PASSed.

Test build #125312 has finished for PR 27428 at commit 16d8c1d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #125311 has finished for PR 27428 at commit 70ff08e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125311/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125312/
Test FAILed.

retest this please

Test build #125319 has started for PR 27428 at commit 16d8c1d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/29931/
Test PASSed.

Test build #125319 has finished for PR 27428 at commit 16d8c1d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125319/
Test FAILed.

retest this please

Test build #125433 has started for PR 27428 at commit 16d8c1d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30045/
Test PASSed.

Test build #125433 has finished for PR 27428 at commit 16d8c1d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125433/
Test FAILed.

retest this please

Test build #125439 has started for PR 27428 at commit 16d8c1d.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30051/
Test PASSed.

Test build #125439 has finished for PR 27428 at commit 16d8c1d.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125439/
Test FAILed.

Test build #125450 has started for PR 27428 at commit 3c49156.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30062/
Test PASSed.

Test build #125462 has started for PR 27428 at commit 762e839.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30075/
Test PASSed.

Test build #125450 has finished for PR 27428 at commit 3c49156.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125450/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125462/
Test FAILed.

retest this please

Test build #125539 has started for PR 27428 at commit 762e839.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30154/
Test PASSed.

Test build #125539 has finished for PR 27428 at commit 762e839.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125539/
Test FAILed.

retest this please

Test build #125564 has started for PR 27428 at commit 762e839.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30179/
Test PASSed.

Test build #125564 has finished for PR 27428 at commit 762e839.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125564/
Test FAILed.

retest this please

Test build #125576 has started for PR 27428 at commit 762e839.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30192/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125576/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30238/
Test PASSed.

Test build #125626 has started for PR 27428 at commit 762e839.

Test build #125626 has finished for PR 27428 at commit 762e839.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125626/
Test PASSed.

Test build #125756 has started for PR 27428 at commit d531864.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30367/
Test PASSed.

Test build #125761 has started for PR 27428 at commit 5bbbfd7.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30372/
Test PASSed.

Test build #125756 has finished for PR 27428 at commit d531864.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125756/
Test FAILed.

Test build #125761 has finished for PR 27428 at commit 5bbbfd7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125761/
Test FAILed.

Test build #125800 has started for PR 27428 at commit 20ad143.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/30411/
Test PASSed.

Test build #125800 has finished for PR 27428 at commit 20ad143.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/125800/
Test FAILed.


local-volume template

Signed-off-by: Neeraj K Kashyap<EMAIL_ADDRESS>

GHE Issue: https://github.com/IBM/ibm-satellite-storage/issues/17

GHE Issue: https://github.com/IBM/ibm-satellite-storage/issues/17


package.json should automatically inherit description from manifest.json

First mentioned here: https://sketchplugins.com/d/991-issues-while-publishing

should be fixed in 1.1.7


Using project's version of eslint & prettier

I noticed that @effective/prettier ignores project's prettier & eslint and uses it's own versions which can cause problems if versions differ. For example, create-react-app still uses eslint 6 and this can't be changed easily, but @effective/prettier is using eslint 7.
As a possible fix, prettier-eslint's approach can be adopted: it uses prettier & eslint from nearest node_modules dir relative to source file being formatted. Can a similar logic be introduced with fallback to effective-prettier's tools if project doesn't have it's own linters installed?

Thanks for the report. Actually this is meant by design. APIs between different eslint/prettier versions might differ so it felt easier to just go with our own versions. You can though, use different versions of this tool as it is meant to be installed in the local project folder as well.


Which log v level is best for production environment?

v default is 0, but v=0 print too few logs.
I think one file uploaded , at least one line log should be printed.

We should try to follow some standard on the log level and details. How about this?
0: server starts up, failures
1: file level operations: add/update file
2: network level operations: replication to other nodes, etc.
3: cluster level information, volume server join the cluster, master join the cluster, heartbeats, etc.
4: internal debug info

That's ok. Paste them into wiki would be better.

Hello guys, does the log level option still exist ? I can't get it to work in any of my startup commands.

Yes.
weed -v=xxx master

Awesome, thanks. I didn't put the flag at the right place.
Btw I think it could be awesome to write something in the wiki about this.


Reset Database / Edit Users?

Any ideas as to how to re-set the database and or delete / edit users? Is there an "Admin" page for this?

No there isn't, I have a CLI app to handle administrative tasks.

OK. Ummm..... So how would I remove / edit a user?

If you want to reset the whole database just use FLUSHDB. Removing a user is more complex as you have to remove all user related data including sessions.
If you don't care about sessions you can remove a user by running the following commands:
SREM emails <user_email>
DEL email:<username>
ZREM users <username>
DEL user:<username>

I'm getting this error....
Command 'srem' not found, did you mean:
command 'rem' from snap rem (0.12.1)
command 'srm' from deb secure-delete
command 'sem' from deb parallel
command 'rem' from deb remind
command 'smem' from deb smem
So I'm thinking there's some Database utils that are missing from redis?

Those are Redis commands, you can run them using redis-cli.

And today I got a little smarter. Thank you! I think I have got this one sorted now.

Closing then.


:kr: Korean Translation

Hello!
We are Pseudo-Lab a non-profit community for deep learning and data science.
Almost 6 months ago, I made an Initiative project group for translating and studying "nn.labml.ai page" in Korean.
Our process is almost done(90%), and in this week we will do pull request!
So before PR, I'd like to make an issue and try to notice our translation project.
Thanks for sharing wonderful annotated research paper Pytorch implementation.

Whats the progress on this?
Currently translations are taken from https://github.com/labmlai/annotated_deep_learning_paper_implementations/tree/master/translate_cache to render the HTML
So we will need to update that with improved translation.

Closing due to inactivity


Investigate AccDC for accessibility

@terracoda provided a resource (http://whatsock.com/) that describes the AccDC API for accessibility.  This is an open source project by Bryan Garaventa and supported by the Royal Society of Arts: https://github.com/accdc/accdc

AccDC is a scalable, cross-browser and cross-platform compatible Dynamic Content Management System that automates the rendering of dynamic content to ensure accessibility for screen reader and keyboard only users.

This should be investigate as a potential resource for PhET accessibility.

A full report of technical information about the API can be found here:
http://whatsock.com/tsg/
This is the document I am going through.

After going through the document, here are the most important points:

AccDC is a JavaScript based Application Programming Interface (API) that can be used with other libraries and frameworks, or by itself, to create new or enhance pre-existing web technologies with accessible features.

The primary purpose of the AccDC API, is to recursively process AccDC Objects, which are rendered as encapsulated dynamic content components.

The majority of AccDC API properties and methods are prototyped within every AccDC Object, making every AccDC Object fully autonomous and programmatically configurable using JavaScript.

This is how AccDC Objects can dynamically control the behaviors of other AccDC Objects at runtime.

An AccDC Object is literally an instantiated JavaScript Object, which stores all relevant data and AccDC API properties and methods within it.

Here is an example the AccDC API to dynamically set accessible content on an object:

var myObjArray = [
{
  id: 'uniqueObjectId',
  role: 'Object Role Name',
  source: 'Hello World',
  isStatic: 'body',
  prepend: true,
  className: 'banner',
  runAfter: function(dc){
  // Do something after the content finishes loading
  },
  runAfterClose: function(dc){
  // Do something after the content finishes closing
  },
  // Render the object immediately
  autoStart: true,
  // Automatically announce the rendered textual content for screen reader users
  announce: true
} ];

// Then register the object array
$A(myObjArray);

CSS selectors are used to find the nodes.

This API is for convenience in rendering accessible HTML.  It shines in dynamic applications. This API generates accessible content by applying various attributes to an element.  It does not add any additional functionality for accessibility outside of what is available with accessible HTML and ARIA.  Since Scenery already has an API for adding accessible content to a node, it seems best to keep our current method.
However, http://whatsock.com/tsg/ has many excellent examples of accessible HTML and ARIA.  It also has examples of really bad usages of ARIA for complex elements, with descriptions of why they would perform poorly.  This will be a fantastic resource as we go forward.
It is a great tool for accessibility, but not one we should use in this context.
Closing.

@jessegreenberg, thanks for the summary!


Regression in flutter_gallery_ios32__transition_perf benchmarks

90th_percentile_frame_build_time_millis, 90th_percentile_frame_rasterizer_time_millis, 99th_percentile_frame_rasterizer_time_millis. Very clear signal:

Looks like this engine roll: https://github.com/flutter/flutter/pull/53403

None of the commits in that engine roll look suspicious. Most of them are about tests or analyzer. Since this only seem to affect the iOS version of the benchmark: Is there maybe a pop-up showing on the device or something like that?

Sadly yes, there's a "No SIM Card Installed" pop-up on the iPhone 4s. I guess we have to access the lab to turn it off. /cc @godofredoc

@digiter : now the benchmarks seem to be missing data

The agent is killed due to "ERROR: Could not connect to lockdownd, error code -19". I think we have to physically access the device to fix it.

-19 is LOCKDOWN_E_PAIRING_DIALOG_RESPONSE_PENDING so yeah, probably need to touch the device.
https://github.com/libimobiledevice/libimobiledevice/blob/7dbc17f2c763a7b18bc1a867f39918c26bb5e9e5/include/libimobiledevice/lockdown.h#L59
Also see my updated comment about device supervision.

Removing TODAY label since its an issue with the device in the lab.

System dialog got dismissed, couple of metrics went back to green but two of them are still red.

The 99th percentile and worst frame rasterization time has previously regressed in https://github.com/flutter/flutter/issues/48248 due to some mysterious reasons. @christopherfujino and @flar has spent a lot of time on investigation. The fix for https://github.com/flutter/flutter/issues/48248 was to remove the libzip dependency.
@christopherfujino : do you know if the libzip dependency was added back recently?

@liyuqian I can confirm it has not.

@liyuqian What's the next steps for this one? I keep half an eye on it week to week --- if this is a lab issue, I suppose we should keep it open until we regain easy access to the lab. If it's something else we want to deal with, we should do so, otherwise maybe deprecate the benchmark and close it?

I'll do some testing locally this week. If I can't reproduce it locally with the iPhone 4s, I think it's likely an infra issue like "No SIM Card Installed", and we'll have to wait until we can physically get back to the device lab.

This looks like it's regressed again, although it may be returning to pre-regression numbers after the most recent commit. See for example 99th_percentile_frame_rasterizer_time_millis and worst_frame_rasterizer_time_millis.

If it's not a lab issue, it looks like it started with #57252.

@kf6gpe : can you please file a new issue for the regression started with #57252? That way, @iskakaushik 's fix would close the new issue instead of this issue.

@liyuqian Done.  Issue is https://github.com/flutter/flutter/issues/57333.

I did some experiments for the original regression around #53403 with commit

6442611 (#53403),
57b0ddb (the commit before #53403 that does not have metrics in our dashboard),
be3a4b3 (the 2nd commit before #53403)

Since 90th_percentile_frame_build_time_millis and 90th_percentile_frame_rasterizer_time_millis have already turned green in our dashboard, I'll focus on 99th_percentile_frame_rasterizer_time_millis, and worst_frame_rasterizer_time_millis.

99th_percentile_frame_rasterizer_time_millis
worst_frame_rasterizer_time_millis

6442611
68.401
287.789

57b0ddb
71.378
290.812

be3a4b3
32.862
66.522

So the regression is real (it's not an infra issue), and it actually happened from 57b0ddb where the devicelab missed its metrics. Reassign this to @jmagman as the author of 57b0ddb.
@kf6gpe : if @jmagman needs an iPhone 4s to reproduce the regression locally, can you please help mail that to her?

@liyuqian , you've got the iPhone 4S I bought, and I don't have others --- when you're done with it, can you ship it to her?
Thanks!

It seems that iPhone 4S is quite useful for reproducing many issues. @cbracken @zoeyfan : can we buy more iPhone 4S so more of us can simultaneously work with it and save some mailing costs?

@liyuqian @cbracken @zoeyfan Shouldn't be a problem. Let me work some magic on my side and I'll report back once I'm done.

This has gotten dramatically worse as of https://github.com/flutter/flutter/pull/59222.

The handset for @jmagman should finally be going out today --- I had to order some of the old iPhone cables as well.

Should this still be P3?

@kf6gpe let's file a new issue for the new regression? Maybe we should include the commit hash of the regression in the issue title so it's clear that we'll file a separate issue for each regression.
The new regression might be related with https://github.com/flutter/flutter/issues/59286. Let's wait https://github.com/flutter/engine/commit/2651beba0613bc2e8079d1048ebb5501f6e8f0f8 to be rolled into the framework and see how things change.
Additionally, Ethan from the Skia team said that his commit https://skia.googlesource.com/skia.git/+/fb5ede576d0f6644d2ee0b1a166fc4cc09b904bb may be causing much more frequent shader compilation than intended. It will be fixed very soon.

The Skia commit has been reverted in https://github.com/flutter/engine/pull/19009

This has returned to acceptable levels. Closing.


Failed validation: #/definitions/InsightsResult

Bug Report
Using v2.4.6, I get the following validation errors from Insights:

Ticker: HIDV
The following result did not validate with schema: #/definitions/InsightsResult
[
{
instancePath: '/instrumentInfo/keyTechnicals',
schemaPath: '#/properties/keyTechnicals/required',
keyword: 'required',
params: { missingProperty: 'stopLoss' },
message: "must have required property 'stopLoss'",
data: { provider: 'Trading Central' }
}
]

Ticker: MPAY
The following result did not validate with schema: #/definitions/InsightsResult
[
{
instancePath: '/companySnapshot',
schemaPath: '#/definitions/InsightsCompanySnapshot/required',
keyword: 'required',
params: { missingProperty: 'sectorInfo' },
message: "must have required property 'sectorInfo'",
data: {
company: { insiderSentiments: 0.6469, earningsReports: 0.6367 },
sector: {
innovativeness: 0.5,
hiring: 0.5,
sustainability: 0.5,
insiderSentiments: 0.5,
earningsReports: 0.5,
dividends: 0.5
}
}
}
]

Ticker: RUSHA
The following result did not validate with schema: #/definitions/InsightsResult
[
{
instancePath: '/reports/1/targetPriceStatus',
schemaPath: '#/definitions/InsightsReport/properties/targetPriceStatus/enum',
keyword: 'enum',
params: { allowedValues: [ 'Increased', 'Maintained', 'Decreased' ] },
message: 'must be equal to one of the allowed values',
data: '-'
},
{
instancePath: '/upsellSearchDD/researchReports',
schemaPath: '#/definitions/InsightsResearchReport/required',
keyword: 'required',
params: { missingProperty: 'investmentRating' },
message: "must have required property 'investmentRating'",
data: {
reportId: 'MS_0P000004QQ_AnalystReport_1603736082000',
provider: 'Morningstar',
title: 'Dropping Coverage of Rush Enterprises',
reportDate: 2020-10-26T18:14:42.000Z,
summary: 'Rush Enterprises is the only publicly traded, standalone commercial truck dealer in North America. With 120 locations, it sells 5.6% of new class 8 trucks as the largest truck dealer on the continent. Vehicle sales include class 4-8 new trucks as well as range of used commercial vehicles. Aftermarket parts and service are key drivers of profitability as they generate approximately 30% of revenue and 65% of gross profit. Rush’s class 8 customers include large fleets (32%), mid-size fleets (16%), vocational customers (40%), and owner-operators (12%). In 2019, Rush generated $5.8 billion in revenue.'
}
}
]

:tada: This issue has been resolved in version 2.4.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

Reported and fixed with contributions from @z3nful; thanks! :pray:


[2pt]  Display joined missions in My profile - Filters

Render a list of all joined missions (use filter()) on the "My profile" page.

Reminder to deploy the live application on Netlify

Reminder to Perform Testing using Jest & React Testing Library


KAFKA-4633: Always using regex pattern subscription in StreamThread

In StreamThread, always use subscribe(Pattern, ..) function in order to avoid sending MetadataRequest with specific topic names and cause brokers to possibly auto-create subscribed topics; the pattern is generated as "topic-1|topic-2..|topic-n".

Minor cleanup: changed String[] to List to avoid overloaded functions.

Minor cleanup: enforced strong typing in SinkNodeFactory and removed unnecessary unchecked tags.

Minor cleanup: augmented unit test error message and fixed a potential transient failure in KafkaStreamTest.

Also by doing this PR now I see more failures that is being worked on with https://github.com/apache/kafka/pull/2371. This is because now Streams rebalance gets shorter and the race condition is then more likely to happen.

retest this please.

retest this please

retest this please

@hachikuji I have addressed your comments, also turned on auto creation in EmbeddedKafkaCluster which is used in all Streams integration test, and have also modified KStreamRepartitionJoinTest to have 2 partitions for input topics and verified that without this fix, this test will always fail.

@hachikuji comments addressed and unit tests added.

retest this please

@hachikuji Found an issue with ConsumerCoordinatorTest while working on it, that subscription is updated on the leader and hence addedTopics will be empty; thus we need to use joinedSubscription to determine the added topics and use that to add to both subscriptions.
Could you please take another look?

@hachikuji Addressed, thanks.

@hachikuji addressed.


static linked openssl (1.1.1i) causes Segmentation fault before main()

#include <stdio.h>
#include <openssl/evp.h>
//#include <openssl/chacha.h>

#define KEY_SIZE 32

unsigned char pt[40] = {0};
unsigned char cp[40] = {0};

void handleErrors(void)
{
    ERR_print_errors_fp(stderr);
    abort();
}

int main(int argc, char** argv) {
    unsigned char key_buf[KEY_SIZE] = {0};
    unsigned char iv[8] = {0};

    if (argc < 2) {
        fprintf(stderr, "No inputfile\n");
    }

    FILE* pf = NULL;
    pf = fopen(argv[1], "r");
    if (!pf) {
        fprintf(stderr, "Cannot open inputfile\n");
        return 0;
    }

    fread(key_buf, 1, KEY_SIZE, pf);
    fclose(pf);

    int out_len;
    EVP_CIPHER_CTX *ctx;
    ctx = EVP_CIPHER_CTX_new();
    if (!ctx)
        handleErrors();

    int rr = EVP_EncryptInit_ex(ctx, EVP_chacha20(), NULL, key_buf, iv);
    if (rr != 1)
        handleErrors();
    rr = EVP_EncryptUpdate(ctx, cp, &out_len, pt, 32);

    if (rr != 1)
        handleErrors();

    cp[0] = cp[1] + cp[2];

    return 0;
}

gcc test.c -g -o test -lssl -lcrypto -lpthread -ldl -static -L ~/bench/openssl -~/openssl/include/

Run and get an error:
Program received signal SIGSEGV, Segmentation fault.
0x0000000000000000 in ?? ()
(gdb) bt
#0  0x0000000000000000 in ?? ()
#1  0x000000000059a5d6 in __register_frame_info.part.4 ()
#2  0x000000000040160d in frame_dummy ()
#3  0x000000000059b847 in __libc_csu_init ()
#4  0x000000000059acfe in generic_start_main ()
#5  0x000000000059b345 in __libc_start_main ()
#6  0x0000000000401539 in _start ()

``

I ran into this and dug into it probably more than is good for me.
If you disassemble frame 1 in your backtrace above, you probably get something like this:
...
   0x00000000005dabcd <+77>:    je     0x5dabdb <__register_frame_info+91>
   0x00000000005dabcf <+79>:    lea    0x1cc50a(%rip),%rdi        # 0x7a70e0 <object_mutex>
   0x00000000005dabd6 <+86>:    call   0x0
=> 0x00000000005dabdb <+91>:    mov    0x1cc536(%rip),%rax        # 0x7a7118 <unseen_objects>
   0x00000000005dabe2 <+98>:    mov    %rbx,0x1cc52f(%rip)        # 0x7a7118 <unseen_objects>
   0x00000000005dabe9 <+105>:   mov    %rax,0x28(%rbx)
   0x00000000005dabed <+109>:   mov    0x1cc515(%rip),%eax        # 0x7a7108 <any_objects_registered>
   0x00000000005dabf3 <+115>:   test   %eax,%eax
...

Obviously calling 0x0 is going to segfault, but why is the compiler putting that in there? That question lead me to this SO answer: https://stackoverflow.com/questions/46350290/what-is-the-sense-of-this-asm-code which indicated that it was probably the result of the weak pthread symbols not being linked in, and so they get set to zero.
I figured out I needed to compile my program with something like this, then it works fine.
gcc testprogram.c -o testprogram -static -lssl -lcrypto -ldl -Wl,--whole-archive -lpthread -Wl,--no-whole-archive

Just using -lpthread was NOT enough - my reading of this SO answer(https://stackoverflow.com/questions/13089166/how-to-make-gcc-link-strong-symbol-in-static-library-to-overwrite-weak-symbol) is that the static linker won't bother linking in the real pthread functions if there's already a definition of them in an earlier object. But using --whole-archive for pthread will force it to overwrite the weak symbols.
TL;DR: Add -Wl,--whole-archive -lpthread -Wl,--no-whole-archive to your compile command.

Marking as inactive, to be closed at the end of the 3.4 dev cycle barring further input


Add domain ksa.hs.kr

School's homepage: https://www.ksa.hs.kr/

@programmer3481 Pull request merged. Thank you!


Created success and error pages, moved logo header to own component

These are the pages we'll want to redirect to once the auth and playlist saving process is complete on the backend.
If the process is successful, let's redirect to /success?venue_id=venue_id. I think I can infer the playlist URI from the ID, so that will be simplest. If for some reason I can't infer the URI from the venue ID alone we'll need to pass it instead.
If the process is unsuccessful, redirect to /error.
Let me know if you have any questions about how to do this in the code on your end!

Okay, sounds good. I'll implement this into the final endpoint.  And I think you meant /success?playlist_id=playlist_id, not venue_id, right?

Okay, sounds good. I'll implement this into the final endpoint. And I think you meant /success?playlist_id=playlist_id, not venue_id, right?

Whoops, I sure did! Will update that and merge this once I've confirmed that I only need playlist_id to generate a URI.

Ok! This should be good to go, so I'm going to merge to keep everything up to date.
The UI is super basic as you can see, so feel free to suggest updates. I was going for speed over complex design to get it working, but I'm totally open to ideas on how to make these pages even better.
As discussed above, once everything else works, you can have the flask app redirect to /success?playlist_id=playlist_id on success and /error if something goes wrong.


[discovery] Upgrade @tanstack/react-table to latest version

Improvements
https://www.npmjs.com/package/@tanstack/react-table
DataTable uses an older verison of react-table. We should look into upgrading to the latest version and updating documentation.
Related issue (short term fix): https://github.com/openedx/paragon/issues/2934

This transition may not be easy. We have a jump to version 1 of the @tanstack/react-table package, but the library API has changed dramatically in this new version.


feat: Add springboot example

Signed-off-by: Ashok Pon Kumar<EMAIL_ADDRESS>

@seshapad Lets enhance the containerizers, and once they are merged, this can be merged.


Can't click on Add Service button for stacks created by catalog

Version: master 5/17
Steps to Reproduce:

Add a stack from a catalog (so you will have the "up to date" text in the stack
Change the size of the browser so mobile version comes up
Try to click on Add Service

Results: You can't click on the Add Service because it's not in the main stack section but in the first service area.

Expected:  Add Service should be up above.

https://github.com/rancher/ui/pull/669

version - master 5/24
Not fixed
Now with the mobile size, the Add service button doesn't show up at all

resolved in https://github.com/rancher/ui/pull/695

Version - master 6/9
Verified fixed


Wrong operation source amount in account page for path payment

In this account page: https://stellar.expert/explorer/public/account/GD646NWXHXIAVE4DMDDGUH63MVGZ7ZJVASFZOR6FOQ3YS2SHSJEQOCBN
Operation<PHONE_NUMBER>04547841 is shown to have source amount of 420.
However, source_amount is actually 400. The number shown is source_max (see on horizon)

Fixed in v0.10.4


Traces don't appear in Stackdriver Traces

Hey guys,
I'm trying to instrument a set of micro-services running in Kubernetes on GCP with OpenCensus.
I've added code to create spans to some of my methods and deployed to GCP, but the Stackdriver Traces page stays empty.
I'm sure the code that creates the spans is running: I added a standard log line just before the span.End() and I see it in my pods' logs.
I'm also pretty sure the exporter is running: the first time I deployed, it was writing many errors to stderr because I didn't have a Stackdriver account associated with the GCP project. I created the Stackdriver account and those errors disappeared.
At that point I don't know how I can troubleshoot this, I don't have anything in my process' output and no obvious errors on the cloud console...
Are there some tips & tricks to figure out what could have gone wrong?
Thanks!
EDIT: I didn't see the recent change that made trace.SetDefaultSampler obsolete. The issue is that now we need to use trace.ApplyConfig. I think the Stackdriver exporter's GoDoc should be updated to reflect that :). Once that's changed I see my spans trying to get out (I have an error because of "insufficient authentication scopes" so it's not all good yet, but now I have a lead on what to investigate).

I think the Stackdriver exporter's GoDoc should be updated to reflect that

Which godoc are you referring to? https://godoc.org/go.opencensus.io/exporter/stackdriver doesn't mention sampling.

I thought I saw in the example a call to set the sampler but I'm not seeing it now so I was probably wrong :)
Everything works properly now, you can close the issue. Thanks!

From: JBD<EMAIL_ADDRESS>Sent: Friday, March 30, 2018 5:57:51 PM
To: census-instrumentation/opencensus-go
Cc: Bastien Teinturier; Author
Subject: Re: [census-instrumentation/opencensus-go] Traces don't appear in Stackdriver Traces (#662)
I think the Stackdriver exporter's GoDoc should be updated to reflect that
Which godoc are you referring to? https://godoc.org/go.opencensus.io/exporter/stackdriver doesn't mention sampling.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/census-instrumentation/opencensus-go/issues/662#issuecomment-377556401, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ad1RWVgUlg9DerwkeDu0YllCHUv9k0M-ks5tjlX-gaJpZM4TByWS.


typo add udf notice

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


istioctl manages webhook configurations of Galley and Sidecar Injector

Add post-install command for commands related to post-install.
Run "istioctl experimental post-install webhook enable --validation" to apply the webhook configuration after detecting that the Galley webhook server is running.
Run "istioctl experimental post-install webhook enable --injection" to apply the webhook configuration after detecting that the Sidecar Injector webhook server is running.
The CA bundle in the webhook configuration is from the k8s CA certificate and is dynamically fetched from the k8s cluster when installing Istio.
The command will look like: istioctl x post-install webhook enable [--validation] [--injection] [--validation-secret= [--injection-secret=] --config-path [--ca-bundle-file=""] [--namespace=].
If validation and injection webhook secrets are in different namespaces, the user calls two CLI commands, each with different --namespace.

This PR is for the issue: https://github.com/istio/istio/issues/17061
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[X ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
03b46344b244c16a6c30c304783e7c31476fea26
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
e8b3d312d79cdd5b6317e5ae1bc6e58420e45fc0
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
7ac4cef5d7a9f2c3712e73c93f34430713edd1cf
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
7ac4cef5d7a9f2c3712e73c93f34430713edd1cf
link
/test lintmodern

lint_istio
7ac4cef5d7a9f2c3712e73c93f34430713edd1cf
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks @lei-tang - this is a good start. You might consider generalizing this for the injector webhook as well, e.g. istioctl x webhook enable validation|injector.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
f40c6574e1800891dac613050d75035d4126a0ec
link
/test pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

I like the idea of being able to control the webhook settings via istioctl.
@sdake Isn't this in the domain of the install operator?  Should the implementation do the work directly or invoke operator and/or helm code?
@lei-tang If this command is about the webhook can we give it a name like webhook?  It seems very close to istioctl validate and istioctl x analyze.
@lei-tang Do we want a validation enable command without validation disable and validation status commands?

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
f40c6574e1800891dac613050d75035d4126a0ec
link
/test pilot-multicluster-e2e

lintmodern_istio
b7013297a075acd2e18dd13b21c9326ab3c8f8db
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
f40c6574e1800891dac613050d75035d4126a0ec
link
/test pilot-multicluster-e2e

lintmodern_istio
b7013297a075acd2e18dd13b21c9326ab3c8f8db
link
/test lintmodern

lint_istio
b7013297a075acd2e18dd13b21c9326ab3c8f8db
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
f40c6574e1800891dac613050d75035d4126a0ec
link
/test pilot-multicluster-e2e

lint_istio
b7013297a075acd2e18dd13b21c9326ab3c8f8db
link
/test lint

lintmodern_istio
68fdde08a92cea2e4b3684f372109f9dbf8144bd
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
f40c6574e1800891dac613050d75035d4126a0ec
link
/test pilot-multicluster-e2e

lintmodern_istio
68fdde08a92cea2e4b3684f372109f9dbf8144bd
link
/test lintmodern

lint_istio
68fdde08a92cea2e4b3684f372109f9dbf8144bd
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj Thanks for your comments! I have changed the command to be "istioctl x webhook enable --validation"

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test lintmodern

lint_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test lintmodern

lint_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test lint

unit-tests_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test lintmodern

lint_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test lint

unit-tests_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test unit-tests

racetest_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test lintmodern

lint_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test lint

unit-tests_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test unit-tests

racetest_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test racetest

codecov_istio
6ef30f74aca4a460f8a7dba64550ce9e6e2a8fb0
link
/test codecov

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible I have changed the command to be "istioctl x webhook enable --validation". I will add the "istioctl x webhook disable --validation" and "istioctl x webhook status --validation" commands.

/test lintmodern

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
85a025db03915fd7820e1ac22ce0e6ab8fe75e97
link
/test lintmodern

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
85a025db03915fd7820e1ac22ce0e6ab8fe75e97
link
/test lintmodern

integ-istioctl-k8s-tests_istio
85a025db03915fd7820e1ac22ce0e6ab8fe75e97
link
/test integ-istioctl-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
85a025db03915fd7820e1ac22ce0e6ab8fe75e97
link
/test lintmodern

integ-istioctl-k8s-tests_istio
85a025db03915fd7820e1ac22ce0e6ab8fe75e97
link
/test integ-istioctl-k8s-tests

integ-mixer-k8s-tests_istio
85a025db03915fd7820e1ac22ce0e6ab8fe75e97
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lintmodern_istio
85a025db03915fd7820e1ac22ce0e6ab8fe75e97
link
/test lintmodern

integ-istioctl-k8s-tests_istio
85a025db03915fd7820e1ac22ce0e6ab8fe75e97
link
/test integ-istioctl-k8s-tests

integ-mixer-k8s-tests_istio
85a025db03915fd7820e1ac22ce0e6ab8fe75e97
link
/test integ-mixer-k8s-tests

e2e-simpleTestsMinProfile_istio
85a025db03915fd7820e1ac22ce0e6ab8fe75e97
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible The "disable" and "status" commands have been added.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
025d9244dea29bd5aba791178181163b61167fab
link
/test pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
025d9244dea29bd5aba791178181163b61167fab
link
/test pilot-e2e-envoyv2-v1alpha3

integ-mixer-k8s-tests_istio
02b867770954a819fe3aa32af3082f13538d32ba
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
02b867770954a819fe3aa32af3082f13538d32ba
link
/test integ-mixer-k8s-tests

pilot-e2e-envoyv2-v1alpha3_istio
02b867770954a819fe3aa32af3082f13538d32ba
link
/test pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
02b867770954a819fe3aa32af3082f13538d32ba
link
/test integ-mixer-k8s-tests

pilot-e2e-envoyv2-v1alpha3_istio
02b867770954a819fe3aa32af3082f13538d32ba
link
/test pilot-e2e-envoyv2-v1alpha3

e2e-simpleTestsMinProfile_istio
da8bd22d7435c5bbd424dff0f3e2cb716dd6c594
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
02b867770954a819fe3aa32af3082f13538d32ba
link
/test integ-mixer-k8s-tests

pilot-e2e-envoyv2-v1alpha3_istio
02b867770954a819fe3aa32af3082f13538d32ba
link
/test pilot-e2e-envoyv2-v1alpha3

e2e-simpleTestsMinProfile_istio
da8bd22d7435c5bbd424dff0f3e2cb716dd6c594
link
/test e2e-simpleTestsMinProfile

racetest_istio
da8bd22d7435c5bbd424dff0f3e2cb716dd6c594
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-istioctl-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-istioctl-k8s-tests

integ-mixer-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-istioctl-k8s-tests

integ-mixer-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-istioctl-k8s-tests

integ-mixer-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-new-install-k8s-tests

integ-telemetry-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-telemetry-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-istioctl-k8s-tests

integ-mixer-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-new-install-k8s-tests

integ-telemetry-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-telemetry-k8s-tests

e2e-simpleTestsMinProfile_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-istioctl-k8s-tests

integ-mixer-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-new-install-k8s-tests

integ-telemetry-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-telemetry-k8s-tests

e2e-simpleTestsMinProfile_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test e2e-simpleTestsMinProfile

integ-security-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-security-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-istioctl-k8s-tests

integ-mixer-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-new-install-k8s-tests

integ-telemetry-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-telemetry-k8s-tests

e2e-simpleTestsMinProfile_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test e2e-simpleTestsMinProfile

integ-security-k8s-tests_istio
8586b83698fb5624c60119198cfa4d9c76e3dbe0
link
/test integ-security-k8s-tests

lint_istio
3131d3a45d7981106f6d808531cdd5dabd9bd322
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
f74badc369dba5a8b077d568e7b3ba61fd554829
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
f74badc369dba5a8b077d568e7b3ba61fd554829
link
/test lint

integ-mixer-k8s-tests_istio
f74badc369dba5a8b077d568e7b3ba61fd554829
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
f74badc369dba5a8b077d568e7b3ba61fd554829
link
/test lint

integ-mixer-k8s-tests_istio
f74badc369dba5a8b077d568e7b3ba61fd554829
link
/test integ-mixer-k8s-tests

pilot-multicluster-e2e_istio
f74badc369dba5a8b077d568e7b3ba61fd554829
link
/test pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
f74badc369dba5a8b077d568e7b3ba61fd554829
link
/test integ-mixer-k8s-tests

pilot-multicluster-e2e_istio
f74badc369dba5a8b077d568e7b3ba61fd554829
link
/test pilot-multicluster-e2e

lint_istio
e0e476314de80a6df1c19a7921e825f1c7894b10
link
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
f74badc369dba5a8b077d568e7b3ba61fd554829
link
/test pilot-multicluster-e2e

lint_istio
e0e476314de80a6df1c19a7921e825f1c7894b10
link
/test lint

integ-mixer-k8s-tests_istio
e0e476314de80a6df1c19a7921e825f1c7894b10
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
e0e476314de80a6df1c19a7921e825f1c7894b10
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
27ea04216e2b8a1353ce4c24d94747106ce7969d
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
27ea04216e2b8a1353ce4c24d94747106ce7969d
link
/test integ-new-install-k8s-tests_istio

lint_istio
c31665935a57e4f0a7ded3851c0a9cf7d62ba2d9
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
c31665935a57e4f0a7ded3851c0a9cf7d62ba2d9
link
/test lint_istio

integ-new-install-k8s-tests_istio
c31665935a57e4f0a7ded3851c0a9cf7d62ba2d9
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
c31665935a57e4f0a7ded3851c0a9cf7d62ba2d9
link
/test integ-new-install-k8s-tests_istio

lint_istio
c6cad2ef70071102bb6411d98ca3c7740470b2dd
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
c31665935a57e4f0a7ded3851c0a9cf7d62ba2d9
link
/test integ-new-install-k8s-tests_istio

lint_istio
c6cad2ef70071102bb6411d98ca3c7740470b2dd
link
/test lint_istio

racetest_istio
c6cad2ef70071102bb6411d98ca3c7740470b2dd
link
/test racetest_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
c6cad2ef70071102bb6411d98ca3c7740470b2dd
link
/test racetest_istio

lint_istio
ae48e227f3d8c8c538e14cc656317198dbbf537b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
c6cad2ef70071102bb6411d98ca3c7740470b2dd
link
/test racetest_istio

lint_istio
ae48e227f3d8c8c538e14cc656317198dbbf537b
link
/test lint_istio

unit-tests_istio
ae48e227f3d8c8c538e14cc656317198dbbf537b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
c6cad2ef70071102bb6411d98ca3c7740470b2dd
link
/test racetest_istio

lint_istio
ae48e227f3d8c8c538e14cc656317198dbbf537b
link
/test lint_istio

unit-tests_istio
ae48e227f3d8c8c538e14cc656317198dbbf537b
link
/test unit-tests_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
e7db65fd411cd3807a1ce8daae5e926c7d460dee
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio
e7db65fd411cd3807a1ce8daae5e926c7d460dee
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-pilot-k8s-tests_istio
e7db65fd411cd3807a1ce8daae5e926c7d460dee
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
3d1eb33ce69cbd859eda297c94d070f2bb64e268
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
3d1eb33ce69cbd859eda297c94d070f2bb64e268
link
/test integ-new-install-k8s-tests_istio

lint_istio
ba23953e4bafcf545c56cfbe2e887893587d36c9
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
3d1eb33ce69cbd859eda297c94d070f2bb64e268
link
/test integ-new-install-k8s-tests_istio

lint_istio
ba23953e4bafcf545c56cfbe2e887893587d36c9
link
/test lint_istio

racetest_istio
ba23953e4bafcf545c56cfbe2e887893587d36c9
link
/test racetest_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
ba23953e4bafcf545c56cfbe2e887893587d36c9
link
/test racetest_istio

lint_istio
20d3185e1a01f9256335a56458fffad52b1aa804
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
31c63d7e2375a76b9e8f7610ae4fc31551a06928
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
c3c92b7473aa8c349920dde319e6a73cae4c04e0
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@esnible @ayj I have addressed all review comments and added tests. Can you take another look?

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
c3c92b7473aa8c349920dde319e6a73cae4c04e0
link
/test integ-mixer-k8s-tests_istio

integ-new-install-k8s-tests_istio
7dacdbd2599e2f2753489dc6e23f411d3f1cbf63
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
ff22bab16af40ee607485affe7d67fb8b3eb5046
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
ff22bab16af40ee607485affe7d67fb8b3eb5046
link
/test integ-new-install-k8s-tests_istio

integ-mixer-k8s-tests_istio
ff22bab16af40ee607485affe7d67fb8b3eb5046
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
ff22bab16af40ee607485affe7d67fb8b3eb5046
link
/test integ-new-install-k8s-tests_istio

integ-mixer-k8s-tests_istio
ff22bab16af40ee607485affe7d67fb8b3eb5046
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
8da0fce4929d80acda5a2d12b829f04f0747b138
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
ff22bab16af40ee607485affe7d67fb8b3eb5046
link
/test integ-new-install-k8s-tests_istio

integ-mixer-k8s-tests_istio
ff22bab16af40ee607485affe7d67fb8b3eb5046
link
/test integ-mixer-k8s-tests_istio

unit-tests_istio
8da0fce4929d80acda5a2d12b829f04f0747b138
link
/test unit-tests_istio

racetest_istio
8da0fce4929d80acda5a2d12b829f04f0747b138
link
/test racetest_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
8da0fce4929d80acda5a2d12b829f04f0747b138
link
/test unit-tests_istio

racetest_istio
8da0fce4929d80acda5a2d12b829f04f0747b138
link
/test racetest_istio

integ-security-k8s-tests_istio
8da0fce4929d80acda5a2d12b829f04f0747b138
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

test racetest_istio

/test racetest_istio

/test integ-security-k8s-tests_istio

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
058eb7ca2b51e7f08c0b093c0a8babee48a67c1f
link
/test integ-istioctl-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
058eb7ca2b51e7f08c0b093c0a8babee48a67c1f
link
/test integ-istioctl-k8s-tests_istio

integ-telemetry-k8s-tests_istio
058eb7ca2b51e7f08c0b093c0a8babee48a67c1f
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@esnible You placed a request for change label on the PR. All comments have been addressed. Can you take a look? Thanks!

istioctl x post-install webhook enable reports Error: must specify a valid --validation-path.  I don't know what a valid path looks like.  The message should be more detailed.
I supplied a file path: istioctl x post-install webhook enable --validation-path /tmp --webhook-secret /tmp --injection-path /tmp.  It got error messages that did not stop:
err reading secret //tmp: invalid resource name "/tmp": [may not contain '/']
err reading secret //tmp: invalid resource name "/tmp": [may not contain '/']
err reading secret //tmp: invalid resource name "/tmp": [may not contain '/']
err reading secret //tmp: invalid resource name "/tmp": [may not contain '/']
err reading secret //tmp: invalid resource name "/tmp": [may not contain '/']

It would be better if the message was something like could not read --validation-path secret "/tmp": /tmp: invalid resource name "/tmp": [may not contain '/']"
istioctl x post-install webhook status gives a large dump of YAML.  I would have expected to see that if I did webhook status -o yaml.  I expected a human-readable summary instead of the YAML.
I did istioctl x post-install webhook disable and then did status again.  After the disable, I see some YAML but then
Error: error when displaying injection webhook configuration: error getting MutatingWebhookConfiguration istio-sidecar-injector: mutatingwebhookconfigurations.admissionregistration.k8s.io "istio-sidecar-injector" not found

and the value of $? is 1.  I would prefer if the command succeeded but included istio-sidecar-injector: none (or similar) in the output.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
42a72be765e53821d8f79abd68a55b70007681dc
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
5a8748ef7767e4d8514891b789992bf4c7c77a42
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lei-tang: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gencheck_istio
5a8748ef7767e4d8514891b789992bf4c7c77a42
link
/test gencheck_istio

integ-framework-k8s-tests_istio
5a8748ef7767e4d8514891b789992bf4c7c77a42
link
/test integ-framework-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test gencheck_istio

@lei-tang: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
5a8748ef7767e4d8514891b789992bf4c7c77a42
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-k8s-tests_istio


Upgrade webpack to ^5.76.0

Also add to yarn "resolutions" because otherwise the console dynamic SDK causes v5.74 to also be used.

/lgtm


pull-stream based API does not work with go-ipfs

Not sure if this is a known issue, but I was unable to use ipfs.files.getPullStream against a go-ipfs node, but the same code works against a js-ipfs node.  Meanwhile ipfs.files.get works against both nodes.

This is with go-ipfs 0.4.16 and js-ipfs 0.30.1.

@derekchiang do you have an error message you can post or some example code we can run to verify the issue?

ping @derekchiang

closing due to inactivity


Gatsby default script doesn't work with Azure Static Sites, extra step needed

The default Gatsby configuration has changed, and it now requires a minimum of NodeJS 18. You need to add a step to modify 'package.json' to include:
"engines": {
"node": ">=18.0.0"
},
V18 is in public preview I believe?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 21b95b84-4ede-5d11-cb9f-ad4b84326318
Version Independent ID: 1529992f-c0e7-a8a4-cd88-9d8665ea90c4
Content: Tutorial: Publish a Gatsby site to Azure Static Web Apps
Content Source: articles/static-web-apps/publish-gatsby.md
Service: static-web-apps
GitHub Login: @aaronpowell
Microsoft Alias: aapowell

@shane-m1
Thanks for your feedback! We will investigate and update as appropriate.

@shane-m1 Thank you for the heads up. We have added a note to the doc for those who might be using newer versions of Gatsby. The changes should be available in the next day or two.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Add extension method for Localizations

I personally think that calling AppLocalizations.of(context)! (29 chars vs 12) every time is a bit unnecessarily long, the only downside with using extensions is that they must be manually imported..

sure why not, I'll refactor the remaining ones later this week


Fixes for log4cats-1.5

The build was creating headers, but not checking headers.  This resulted in a diff, which bumped the version past the tag and resulted in a resolution failure on MiMa.  Cool.
I took a conservative approach and did not port to sbt-typelevel.

No, I would have assumed CI took care of it.  This is why I'm excited for sbt-typelevel and reducing all these exceptional builds.


Utilize lngPathCorrector within Link component

Ref this comment in #149.

Why are you using i18n.languages[0] instead of props.lng?

I didn't think that there was a difference.  Apologies if I misunderstood.  I can change it back, if you'd like.

In general I'd prefer PRs to have as little changes as possible to achieve the desired effect. Using props.lng is much safer as that is coming through the withNamespaces HOC.

A few things I noticed while creating this PR:

In Link, we should probably be spreading href in NextLink's href prop, rather than just using pathname.   In other words, instead of doing this:

      return (
        <NextLink
          href={{ pathname, query: correctedQuery }}  // using just pathname
          as={correctedAs}
          {...removeWithNamespacesProps(props)}
        >
          {children}
        </NextLink>
      )

we should do this:
      return (
        <NextLink
          href={{ ...href, query: correctedQuery }}  // spread href
          as={correctedAs}
          {...removeWithNamespacesProps(props)}
        >
          {children}
        </NextLink>
      )

For example, this would help us preserve things like href.hash.

We should probably change the function signature of lngPathCorrector to remove i18n entirely and enforce that a language is passed in.

Let me know if you would like me to submit PRs for these and I will.

Requested corrections made.

On second thought, instead of 1 and 2 above, what if we changed the lngPathCorrector to:
lngPathCorrector(config: object, { href: object | string, as: string }, language: string): [string, object]

That is, take in a config object, an object with an href string or object and as string, and a language string and return correctedAs as a string and correctedHref as an object.

This PR looks good to go. Let's discuss your comments about lng-path-corrector can be in a new issue, please.


only set laststatus when airline is not on top

When airline is configured to show on top (let g:airline_statusline_ontop = 1) and vim's laststatus option is configured to be hidden (set laststatus=0) then there is no need to override its setting and airline should honor the user configuration.

My pleasure!


invitations: Limit realms to 100 invites per day.

Hopefully the db query is not too expensive. Possibly we should add an index on (realm, confirmation_type) or even (realm, confirmation_type, date_sent).

Updated. Is travis down?

This fails tests due to missing test coverage on registration.py, but otherwise looks great.  I merged this, after adding 6e8f4ffc77a49a0fc20a7dc208f843af9c9bb808 to fill that gap.


Setting All bank option to CTRL is messing with chat.

When I enable Custom Menu Swap -> Bank -> All and set it to CTRL, it makes it so when I CTRL click on a players chat message, the first option is Report.  making it so when I ctrl click to walk in PVM and accidentily click a message, I dont move and it brings up the report screen.

yes, it looks like I made a mistake in the last update. I'll fix it.

Should be fixed now!


Update samples to work with TypeScript strict mode (part 2)

@kainino0x
I set strict:true and made sure the npm run build went through
This PR makes all the remaining examples work in TypeScript strict mode. Could you please take a look when you have a moment? Thank you in advance.
Ref: #278

Thank you for the review & I apologize for the late response. I will incorporate your feedback.

Thanks, no rush, thank you for the contribution!


[FALSE-POSITIVE]

Domains or links
trustmary.com
More Information
We found out when our customers had firewalls filtering out domains from this database. We are a review management Saas Startup from Finland and we had a couple user generated surveys with email and password as textfields. We have removed those surveys and implemented phishing detection.
Have you requested removal from other sources?
We are in process on removing our domain from following sources:
https://threatcenter.crdf.fr/
https://seclookup.com/
Additional context
We created pr to add our domain as falsepositive https://github.com/mitchellkrogza/phishing/pull/272
:exclamation:
We understand being listed on a Phishing Database like this can be frustrating and embarrassing for many web site owners. The first step is to remain calm. The second step is to rest assured one of our maintainers will address your issue as soon as possible. Please make sure you have provided as much information as possible to help speed up the process.
Send a Pull Request for faster removal
Users who understand github and creating Pull Requests can assist us with faster removals by sending a PR to mitchellkrogza/phishing repository, on the falsepositive.list file

https://github.com/mitchellkrogza/phishing/blob/main/falsepositive.list
Please include the same above information to help speed up the whitelisting process.

We have been removed from following databases:

https://threatcenter.crdf.fr/
https://seclookup.com/

How can we go forward with this?


[FLINK-27334] Support auto generate the doc for the KubernetesOperatorConfigOptions

The document of the KubernetesOperatorConfigOptions should be automatically generated.
The brief change log

Adds the flink-kubernetes-docs module and introduces the ConfigOptionsDocGenerator to generate the document of the KubernetesOperatorConfigOptions.

@wangyang0918, thanks for your review. I have addressed above comments and verified the configuration html manually. PTAL.
cc @gyfora .

@SteNicholas Just to be sure, do you have verified that the CI will fail when the docs are not generated properly?

@SteNicholas Just to be sure, do you have verified that the CI will fail when the docs are not generated properly?

@wangyang0918 , I'm sure that the CI will fail when the docs are not generated properly in updates of the pull request.


ICMP Destination unreachable (port unreachable) won't close connection

Hi.
I am using Lidgren Network with Unity and having two clients communicate with each other.
If I use the task manager to kill the server, the client doesn't recognize the disconnect.
There is no status change. Using wireshark I can see that the keep alive/heartbeat packets are still send but for every try there is an ICMP Destination unreachable (Port unreachable).
In the Lidgren Networking source code I found this (NetPeer.Internal.cs):
                        // connection reset by peer, aka connection forcibly closed aka "ICMP port unreachable"                         // we should shut down the connection; but m_senderRemote seemingly cannot be trusted, so which connection should we shut down?!                         // So, what to do?
Does it have something todo with this? In the code it will just return without further action. Why can m_senderRemote not be trusted and what should I do now?

It was a mistake on my part with setting the timeout value very high for testing purpose.


Could you kindly add support for the baseUrl parameter for the OpenAI compatible API?

I apologize for the repetition; I have found that this issue has already been addressed, so I am closing this ticket. Thank you for your understanding.


build: gitingore .env and .envrc files

What this PR does / why we need it:
I use https://direnv.net/ for Go version management, having a local .envrc file makes it easier to add the correct exports and have it be automatically loaded.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
How Has This Been Tested?:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:

/lgtm
/approve

@dkoshkin For local values, it is better to add something like dotenv_if_exists .envrc-local or similar so that values in envrc can be specified or overridden locally, while still allowing for project wide envrc, as used by tooling like devbox.


T2WML Tool name and acronym

Maybe I am nitpicking a little, but T2WML stands for Table to Wikidata Mapping Language. However this repository describes a tool that uses T2WML, not the language. Therefore, shouldn't this repository be renamed to:

T2WMT: Table to Wikidata Mapping Tool or
T2WMLT: Table to Wikidata Mapping Language Tool

I think it's important to have the 2 separated as different entities.

@szeke ?


chore(docker): add :3000 to allowed_return_urls

:tada: This PR is included in version 0.5.0 :tada:
The release is available on:

GitHub release
v0.5.0

Your semantic-release bot :package::rocket: