Missing the end tag

Document parse = Jsoup.parse("<img th:src="" width="50" height="50" alt="fail" />");
String result = parse.html();
I need <img th:src="" width="50" height="50" alt="fail" />
but I get <img th:src="" width="50" height="50" alt="fail" >
where did the '/' go? and how can I get '/'?

jsoup defaults to HTML5, where self-closing tags aren't a thing. If you want XML, you can use the XML parser. See e.g. https://try.jsoup.org/~Qgdx_A13CctCvLA1C4WZRNhpJ-c
Also, best to use StackOverflow for Q&A; we use GitHub Issues for issue tracking.

jsoup defaults to HTML5, where self-closing tags aren't a thing. If you want XML, you can use the XML parser. See e.g. https://try.jsoup.org/~Qgdx_A13CctCvLA1C4WZRNhpJ-c
Also, best to use StackOverflow for Q&A; we use GitHub Issues for issue tracking.

sorry about that,I can’t open StackOverflow,because google is forbidden for me,and I can‘t find a anwser from the other search engines.
fortunately,I found a solution
org.jsoup.nodes.Document document = Jsoup.parse(originalHtmlTemplate);
document.outputSettings().syntax(org.jsoup.nodes.Document.OutputSettings.Syntax.xml);
document.outputSettings().escapeMode(Entities.EscapeMode.xhtml);

thanks a lot

@WayneLee5991 sorry, I hadn't considered that Google or StackOverflow may be blocked or partially accessible. Glad you found the fix. I'll have a think about copying the common StackOverflow jsoup FAQs over to the jsoup.org documentation site. Do you think that would be useful?

@WayneLee5991 sorry, I hadn't considered that Google or StackOverflow may be blocked or partially accessible. Glad you found the fix. I'll have a think about copying the common StackOverflow jsoup FAQs over to the jsoup.org documentation site. Do you think that would be useful?
It could‘t be better,you also can put some FAQs in the README.


Update about-our-data.md

Have reviewed and made a few edits to the "Sample Variant Validation and Filtering" section as recently updated by Michael Rusch.

@adthrasher I like your two suggested edits. I think this is ready to be merged. I think that would finish the whole VCF section, correct?

@adthrasher I like your two suggested edits. I think this is ready to be merged. I think that would finish the whole VCF section, correct?

@a-frantz - I've merged Alex and my changes. I think the somatic VCF section should now be complete.

@a-frantz - I've merged Alex and my changes. I think the somatic VCF section should now be complete.


sending raw files in HTTP

Hi.
I started to implement in the code the possibility to optionally send RAW html files, I mean something like
HTTP/1.1 302 Found
Cache-Control: private
Content-Type: text/html; charset=UTF-8
Referrer-Policy: no-referrer
Location: http://www.google.it/?gfe_rd=cr&dcr=0&ei=-hMOWpvLOuzBXtDhiegJ
Content-Length: 266
Date: Thu, 16 Nov 2017 22:40:58 GMT

<HTML><HEAD><meta http-equiv="content-type" content="text/html;charset=utf-8">
<TITLE>302 Moved</TITLE></HEAD><BODY>

In this way you can have more control on the replies and sending specific codes or formats.
For the time being I started to do it in a very naive way:
for example if I do a GET /myfile
I search in the "defaultFiles" for a file named "myfile.RAW". If it exists, it send it without additional headers or config (assuming that they are in the file).
Do you have any suggestion on a better approach on this? Then, as soon as I'll have this cleaned up, I'll share it if you are interested.
Thanks,

I worked a bit on this. I did the following in httplistener.py

when processing GET/POST  the process looks also for a .RAW file
if it does not exists, it works as usual
if exists, it sends back it
For example, with the following, named "success.txt.RAW"

HTTP/1.1 200 OK
Content-Type: text/plain
Content-Length: 8
Last-Modified: Mon, 15 May 2017 18:04:40 GMT
ETag: "ae780585f49b94ce1444eb7d28906123"
Accept-Ranges: bytes
Server: AmazonS3
X-Amz-Cf-Id: DOMFBGDxBc9xK7seJjwbgRcfGUMjatIzbXRAY4nKJan2KJgKx6nM9g==
Cache-Control: no-cache, no-store, must-revalidate
Date: <RAW-DATE>
Connection: close

success

I can emulate the Firefox connection portal.
As you can see I also implemented some "variables" replaced at runtime. In this case ("<RAW-DATE>") is the current time. May be I can add more.

Thank you for your suggestion! A FLARE analyst has a similar request involving not URIs but instead HTTP Host headers. I think what we'll do is implement a feature that uses optional extended configuration specific to the HTTPListener to direct it to behave differently in certain scenarios. Watch this space for updates ;-)

Here is what I've hacked together for a related use case. Please read the CustomResponse.MD file from this commit: https://github.com/evil-e/flare-fakenet-ng/commit/ea54fa6aee55b7cd1d5dd7cd50ccb1e671bfc163

sounds great! thanks!

Merged https://github.com/fireeye/flare-fakenet-ng/pull/120 resulting in FakeNet-NG version 1.4.9 which supports this feature. See docs/CustomResponse.md for details.


Add mmap dictionary class

I added a small Makefile and a pipeline, as I found myself linting and testing regularly
This new mmap.py module would enable the multiprocess mode using files
Some other minor fixes to flake8 and mypy

Performance results compared to other naive approaches like using json or pickle are interesting:
x 100 faster writes, which is the most important thing, as we write metrics constantly
x 4 slower reads, which might not be as problematic as you only need to read every scrape time
Still want to make this a bit more performant to match the current client, which gets similar write numbers, but better read ones.

Closing for now


ENH: Add option in read_csv to infer compression type from filename

Ideally, I would love for this to be the default, but that wouldn't be backwards-compatible in the case where the filename ends in '.gz' or '.bz2' and you want to treat it as uncompressed. That seems like it would be very rare, though.

I think it would even be fine even to change the default here. We are not that strict about backwards compatibility in pandas -- any users who relied on the previous behavior were basically relying on a bug.

I agree with @shoyer here, let's just have it infer these filename endings as compression (move the release note to the API section).

I've totally borked this branch with an accidental force push. I'll fix it tonight.

Should be fixed.

couple of minor comments, pls rebase, and ping when green

Docs are fixed, rebased/squashed, and tests are green.

lgtm
@shoyer @jorisvandenbossche

Looks great to me!

@evanpw thanks!

Thank you!


Add Integration Tests to Java SDK Validation Action

Description

Add Integration Tests to Java SDK Validation Action
Move all Java SDK generation related artifacts under /javasdk
Update gitignore to prevent accidental commit of generated Java SDK code

Motivation

Add additional validation for generated Java SDK

Testing Done

Ran all tests locally using mvn test
Dryrun updated GitHub action using draft PR

Backwards Compatibility Criteria (if any)

No dependency yet

POM details and README can be updated at a later date


az network not working with default resource-group

Describe the bug
It seems subcommands from az network can't read default resource group. Commands worked fine with version 2.38. With az config get defaults I can see default group was set correctly. Also, other commands are using default resource group without problem.
Command Name
az network vnet show
Errors:
InvalidArgumentValue: Missing required field: --resource-group

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

az config set defaults.group={}
az network vnet show --name {}

Expected Behavior
command should use default resource-group and show specific vnet
Environment Summary
Windows-10-10.0.19044-SP0
Python 3.10.5
Installer: MSI

azure-cli 2.41.0

Extensions:
authV2 0.1.1
cosmosdb-preview 0.20.0
monitor-control-service 0.3.0

Dependencies:
msal 1.20.0b1
azure-mgmt-resource 21.1.0b1

Additional Context

@necusjz for awareness

It's a breaking change involved in Azure CLI 2.41.0, which related to [BREAKING CHANGE] az network vnet: Deprecate parameter --defer (see details in Release Notes).
Please use the entire command instead.

Please do not close it. It has nothing to do with --defer parameter.
Release notes doesn't tell --resource-group became required. If it is, then documentation is outdated.
https://learn.microsoft.com/en-us/cli/azure/network/vnet?view=azure-cli-latest#az-network-vnet-show

Optional Parameters
--resource-group -g
Name of resource group. You can configure the default group using az configure --defaults group=<name>.

$ az network vnet subnet show --help
...
Resource Id Arguments
    --resource-group -g : Name of resource group. You can configure the default group using `az
                          configure --defaults group=<name>`.

Same is for az network public-ip show and az network public-ip show. Resource group is optional according to documentation but seems to be required

@gallium-arsenide Sorry, I didn't catch your point well before and I'll re-open it then.

It'll be fixed by https://github.com/Azure/azure-cli/pull/24411 with Azure CLI 2.42.0 in 11/01.


Add pullrequest icon

Where is this supposed to show up?

Ping

Hi
i am trying to make bitbucket pull request handling,  you can check it in
my git repo
https://github.com/nomean42/strider-bitbucket/tree/feature/add-pullrequest-handling
On Sat, Jan 30, 2016 at 7:17 AM, Ilya Radchenko<EMAIL_ADDRESS>wrote:

Ping
—
Reply to this email directly or view it on GitHub
https://github.com/Strider-CD/strider/pull/905#issuecomment-177038957.

--
С уважением, Горяйнов Игорь.

Feel free to open the bitbucket PR and just keep commiting there so we can see your progress.


Add 'quote_nullable' function to PostgresModule

Add support for function quote_nullable described in the PostgreSQL docs.

Add function to PostgresFunctionDef in PostgresModule
Add test in FunctionDefSpec

I'll pick this one

I have trouble figuring out the types that should be used to cope with this function, as in case of NULL input, it should produce NULL output.
The first thing I came up with is
    def QuoteNullable[A: TypeTag.NotNull] = FunctionDef[Option[A], Option[String]](FunctionName("quote_nullable"))

However if I try to use it in test
    val q: Option[Double] = None
    val query = select(QuoteNullable(q)) from customers

it doesn't compile
[error] /Users/pierangelo.cecchetto/Documents/projects/myprojects/zio-sql/postgres/src/test/scala/zio/sql/postgresql/FunctionDefSpec.scala:55:40: type mismatch;
[error]  found   : Option[Double]
[error]  required: zio.sql.postgresql.FunctionDefSpec.TypeTag.NotNull[?]
[error]       val query = select(QuoteNullable(q)) from customers
[error]                                        ^

WIP is here https://github.com/pierangeloc/zio-sql/tree/276-add-quote_nullable
This is the first time I look at this library, but it seems to me that zio.sql.postgresql.PostgresModule#renderRead is not dealing with Optional parameters, or am I missing something?

This doesn't seem like a useful function from the library perspective.


CSS: Link as buttons have text in blue

It's a problem with specificity on button selectors when it sets the text color.

Duplicated with #1204


Using Floats in add_node for Trees

Currently, nodes are added to trees with an add path, which is a string of values corresponding to values in the tree. The node will be added as a child of the last node in the add path. Each level in the add_path is denoted by a dot . (see below for an example):
set tree = "root" => [
    "a",
    "b" => [
        "b1",
        "b2"
    ]
]

add_node(tree, "b3", "b")  # add "b3" to the children of "b"
add_node(tree, "b2a", "b.b2")  # add "b2a" to the children of "b2". Note the dot in the last parameter (add_path)

However, this causes issues for floating point numbers and any values that might have a dot in their value. We could try:

putting parenthesis around values with dots and only split on dots not in parenthesis: https://stackoverflow.com/a/26634150
use a different character in the add path

Trees have been removed as part of language redesign.


Add dependabot and security checks

We should add dependabot checks and security update checks to keep our dependencies up to date

Good idea! I guess the major problem will be to avoid version conflicts with the library versions that are used as dependencies of Solr and ES (= we can't get rid of all alerts)


Create symlinks for the xdg dirs

This branch attempts to make symlinks to xdg-user-dirs, like Documents, Downloads, Pictures, etc

Thanks, looks fine to me. The translations are still not working but that's due to https://forum.snapcraft.io/t/translations-in-snap-using-the-gnome-platform/4293

As I said at the sprint, I think this is not safe to go for now, unless https://bugs.launchpad.net/snappy/+bug/1752916 is fixed.
Otherwise, in localized setups or where these folders have been set to something else, we'd end up creating multiple dirs in the user directory.
I think linking should happen only when such directories are found, otherwise we keep them in the ~/snap folder.

We need to get that bug triaged
On Wed, Mar 14, 2018 at 9:07 PM, Marco Trevisan<EMAIL_ADDRESS>wrote:

As I said at the sprint, I think this is not safe to go for now, unless
https://bugs.launchpad.net/snappy/+bug/1752916 is fixed.
Otherwise, in localized setups or where these folders have been set to
something else, we'd end up creating multiple dirs in the user directory.
I think linking should happen only when such directories are found,
otherwise we keep them in the ~/snap folder.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/Ubuntu/snapcraft-desktop-helpers/pull/99#issuecomment-373226382,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWBcqSBHieFIrgv4JeiMnJA5zP0aPHks5teb7QgaJpZM4SVZg9
.

--
Ubuntu - "I am what I am because of who we all are"

Yeah, anyway actually the sym-links aren't generated if folders aren't there, not sure why it happened in my snap.
But indeed.


WRO-478: POC for item reordering in VirtualList

Checklist

[x] I have read and understand the contribution guide
[ ] A CHANGELOG entry is included
[ ] At least one test case is included for this feature or bug fix
[ ] Documentation was added or is not needed
[ ] This is an API breaking change

Issue Resolved / Feature Added
POC for item reordering in VirtualList
Resolution
The former POC implementation of #1189 is totally refined.

Changed to wait for press-and-hold input to edit items' order
Changed to get a single object-typed editable prop rather than several individual props
Added a selected effect for a sample

Additional Considerations
There are so many bugs and missing behaviors.

Touch input is not supported yet.
UI could be broken when page up/down key is pressed during reordering.
UI could be broken or ugly when boundaries are changed.
It is unstable when various input devices are used simultaneously.
I cannot guarantee that it works great even with a single input device.
Performance optimization is required.

Links
WRO-478 (companion enactjs/enact#3076)
WRN-17866 (#1189)
Comments
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek<EMAIL_ADDRESS>

@0x64 Would you check the Travis error?

@0x64 Would you check the Travis error?

@seunghoh,
Travis fails since the companion enact branch is not matched. I did not update travis.yml as I thought this branch would be simply a reference for a new feature that is not officially taken in yet.
For maintainers, I will update travis.yml. :)


Usability issue with retrieving passwords and proposed fix.

Hi again. I've started using and relying on passgo recently, I really like it, and I'd like to contribute to try to make it even better.
When I first tried it, I had to learn the CLI and how to use it, and I ran into a pretty glaring IMO usability issue. I will explain it here, and also propose a fix.
Usability Issue
passgo has quite a few commands:
https://github.com/ejcx/passgo#commands
And it's described as:

stores, retrieves, generates, and synchronizes passwords securely and is written in Go!

So it's pretty clear and storing and retrieving passwords is the core functionality.
Yet when I tried to read about the commands it has in https://github.com/ejcx/passgo#commands, I was only able to find a command to store a password:
https://github.com/ejcx/passgo#passgo-insert-grouppass-name
passgo insert group/pass-name

I looked really really hard and literally spent 10 minutes trying to figure out how to retrieve a password, but it was not documented anywhere at all. I thought it was really surprising given how it's such basic functionality.
After 10 mins of reading the README, trying stuff and looking at the source code, I was eventually able to figure it out, to retrieve the password, there is no command, you just need to type:
passgo group/pass-name

But this is literally not documented anywhere!
Proposed Fix
A very basic fix is to document how to retrieve the password and add it to the README, together with all the other commands that are already documented there.
However, I'd like to propose a slightly different solution.
I think it's a bad idea to not have an explicit command name for something as fundamental as retrieving the password. It's unintuitive, inconsistent, asymmetrical, and makes it hard to document the command. It also has the danger of overlapping with an existing command name (see #16). You can accidentally try to fetch a password for a site called "push" and inadvertently perform an unwanted action.
I think a really good solution would be to add an explicit command for retrieving passwords. That resolves all the issues above with not having a proper command.
What do you think?

Hey @shurcooL, I'm super glad you're using passgo and I would love to help you get the use out of it that you want.
Do you have a specific subcommand name to recommend? This "no command" was copied from https://www.passwordstore.org/ ?
I could live with show, since it already lives in the show package.

I was considering get, but show works too.

Just merged. Going to close. Thanks @shurcooL

Thank you!


Add signet pools

Adds json files for the different signet miners, and updates generate-json-pool-list.py to allow specifying both the output file name and also the entities directory.

Thanks! I've updated your branch with a few commits making sure the signet pool data is also checked with qa/check-data.py and both the signet-pool-list.json and the signet-pools.json are automatically generated by GitHub: 202302-signet-pools-updated. Feel free to push these commits here (or I can push them if you check allow edits from maintainers).

Changes look good to me, clicked the button

Thanks!
https://github.com/bitcoin-data/mining-pools/blob/generated/signet-pools.json


GetListing() returns a NullReferenceException: Object reference not set to an instance of an object.

FTP OS: Unix
FTP Server: Unknown
Computer OS: Windows 10, Version 2004 19041, .NET Core 3.1.5
FluentFTP Version: 32.4.3
GetListing() returns NullReferenceException that probably hides a TLS-issue since the problem disappearswith DataConnectionEncryption = false.
Same issue as #589 that is closed with the conclusion that using FtpListOption.UseStat will solve the problem. STAT will not open a data channel so you will run into the issue later when you try to download a file for example.
var client = new FtpClient(host, port, username, password);
client.EncryptionMode = FtpEncryptionMode.Explicit;
//client.DataConnectionEncryption = false;
client.Connect();
var list = client.GetListing();

Expected: Should return an array with items
Actual: GetListing() throws a NullReferenceException unless DataConnectionEncryption = false;
The NullReferenceException is thrown in GetListingInternal() L589 in an error handler because the CompletionCode is null.
catch (FtpCommandException ftpEx) {
// Some FTP servers throw 550 for empty folders. Absorb these.
	if (!ftpEx.CompletionCode.StartsWith("550")) {
		throw ftpEx;
	}
}

The inner exception is thrown in CloseDataStream L988 when the data stream is closed because it did not return any data and all fields of the reply object are null.
It appears the data stream returns nothing when DataConnectionEncryption is true which is probably the root of the problem.
Question: How can I dig deeper to understand why the data connection encryption can not be enabled when using FluentFTP but works fine with FileZilla?
Enhancement: Error handlers should probably be improved to be null safe and give an better error when the data stream returns no data.
Other findings :

Using FileZila to connect to the same server does open an encrypted data connection using TLS 1.2 without any problem.
Trying with different TLS versions gives the same result.
Trying with different passive DataConnectionTypes does not make any difference
SslBuffering = FtpsBuffering.Off does not make any difference
SocketPollInterval = 0 does not make any difference

Logs :
# Connect()
Status:   Connecting to ***:21443
Response: 220-****************************************
Response: 220-* Please do not connect to this server *
Response: 220-*   if you are not entitled to do so   *
Response: 220-****************************************
Response: 220 This is a private system - No anonymous login
Command:  AUTH TLS
Response: 234 AUTH TLS OK.
Status:   FTPS Authentication Successful
Status:   Time to activate encryption: 0h 0m 0s.  Total Seconds: 0,2285364.
Command:  USER ***
Response: 331 User *** OK. Password required
Command:  PASS ***
Response: 230 OK. Current directory is /
Command:  PBSZ 0
Response: 200 PBSZ=0
Command:  PROT P
Response: 200 Data protection level set to "private"
Command:  FEAT
Response: 211-Extensions supported:
Response: EPRT
Response: IDLE
Response: MDTM
Response: SIZE
Response: MFMT
Response: REST STREAM
Response: MLST type*;size*;sizd*;modify*;UNIX.mode*;UNIX.uid*;UNIX.gid*;unique*;
Response: MLSD
Response: AUTH TLS
Response: PBSZ
Response: PROT
Response: UTF8
Response: ESTA
Response: PASV
Response: EPSV
Response: SPSV
Response: 211 End.
Status:   Text encoding: System.Text.UTF8Encoding+UTF8EncodingSealed
Command:  OPTS UTF8 ON
Response: 200 OK, UTF-8 enabled
Command:  SYST
Response: 215 UNIX Type: L8

# GetListing(null, Auto)

# GetWorkingDirectory()
Command:  PWD
Response: 257 "/" is your current location
Command:  TYPE I
Response: 200 TYPE is now 8-bit binary

# OpenPassiveDataStream(AutoPassive, "MLSD /", 0)
Command:  EPSV
Response: 229 Extended Passive mode OK (|||50780|)
Status:   Connecting to ***:50780
Command:  MLSD /
Response: 150 Accepted data connection
Status:   FTPS Authentication Successful
Status:   Time to activate encryption: 0h 0m 0s.  Total Seconds: 0,0682148.
+---------------------------------------+
-----------------------------------------
Status:   Disposing FtpSocketStream...

# CloseDataStream()
Exception thrown: 'FluentFTP.FtpCommandException' in FluentFTP.dll
Status:   Disposing FtpSocketStream...
FluentFTP.FtpCommandException.CompletionCode.**get** returned null.

Wow, thanks for this great debugging.

We are using FluentFTP extensively and are seeing the exact same issue (and many similar issues). So far we have seen:

NullReferenceException because CompletionCode is nulll
FtpCommandException because replies to a command are null
0 byte files (when using readToEnd and reading to a stream) / Unexpected EOF (when using a file size)
The final part of a big file timing out when reading from the socket (Fixed by disabling SSL buffering)
Failing to parse the EPSV port because the result of the previous command is used (file size) instead of the correct port (as seen in the server logs).

After a lot of debugging all of them seem to be related to lower level NetworkStream/SllStream/socket issues. We started seeing an increase after switching to .NET core (3.1), so it might actually have to do with differences in the implementations between full framework and core.
I'd be happy to help out with any debugging efforts.

.net 6 and i get this when downloading...

@fredrikhaglund @christiaanderidder @Seabizkit There has been some improvement to the inner logic of GetListing() for the cases where authentication fails for the data channel to get the listing data. Also there has been significant improvement on the verbose error logging and the internal automatic reconnect logic. If this issue is still of concern to any of you, would you please reexamine the topics you raised and indicate your results here?


translatable chart titles

hi @ariandora there's a couple of issues with the charts after these changes and i think zak is going to send a message to you on slack with details

@ewansheldon can you check it now?

looks all good to me. thanks 😊

great :)


[PhoneNumber Verification] Display only valid numbers in user search.

Details

With this PR, we are adding the ability to only show valid phone number users in the search page when a user enters a number.
Fixed Issues

$ https://github.com/Expensify/App/issues/17461
PROPOSAL: https://github.com/Expensify/App/issues/17461#issuecomment-1509030609
Tests

Login to ND
Click on the Search icon
Type an invalid phone number e.g. +444
Verify the Please enter a valid phone number... message is shown below the input
Verify no results are returned
Type a valid phone number e.g. +1<PHONE_NUMBER>
Verify no message is shown below the input
Verify the phone number / user is found

Verify the test steps above for these pages:

Search Page

New group page

New chat page

Send Money

Request Money

Split Bill

Workspace - Invite Members

[x] Verify that no errors appear in the JS console

Offline tests

Ensure that phone number validation works even when offline.
QA Steps

Same as above.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/54077356/232798288-5efdd1c6-94ba-4342-86f5-1d65344cc43c.mp4

Mobile Web - Chrome
https://user-images.githubusercontent.com/54077356/232798314-6d623490-be86-44c0-a15c-b806011f1e2d.mp4

Mobile Web - Safari
https://user-images.githubusercontent.com/54077356/232798382-da1a758b-f910-47ac-a8d8-079e13ea026e.mp4

Desktop
https://user-images.githubusercontent.com/54077356/232798359-8f785e60-d778-43ff-bc28-49e7fa37c1bd.mp4

iOS
https://user-images.githubusercontent.com/54077356/232798335-3094ebc8-e7b6-4469-9e01-486d69c74849.mp4

Android
https://user-images.githubusercontent.com/54077356/232798411-723ec476-8b02-4be3-979a-90a5761d96aa.mp4

I have some concerns about this since I feel that in some places, it is more to verify that the input is indeed of the number format and perform operations based on that.

I would think that we do want to replace all uses of isValidPhone, but I don't quite follow what this means? Mind giving an example?

@Prince-Mendiratta We can't keep using Str.isValidPhone because it creates inconsistency, if we validate input as a valid number at stage 1 (that uses Str.isValidPhone) then say the number is not correct at stage 2 (using the lib) we will create a confusion.

@Prince-Mendiratta I noticed the same bug previously, it should be fixed with the suggested change here https://github.com/Expensify/App/issues/17255#issuecomment-1510015764 Or this didn't do it?

@Prince-Mendiratta I'm still unable to reproduce the bug, can you please double check?

Still can't reproduce, can you add a console.log to getHeaderMessage before the not found message, and confirm you get the message logged in the console.

@Prince-Mendiratta I really can't reproduce that. Sorry if I'm being repetitive but are you sure you are applying the changes exactly as they are in the PR? git checkout then git apply https://github.com/Expensify/App/pull/17578.diff

Ah okay, I was trying on the New Chat page. I confirm the bug is reproducible on the Search page. Let's fix that

I think this is actually a regression from https://github.com/Expensify/App/pull/3669 and it's being handled on https://github.com/Expensify/App/issues/17200 so we can ignore that.

@Prince-Mendiratta Please fix he lint issues

I'd have to test this some more. I have noticed that on staging you can login with phone:<PHONE_NUMBER> but after this change you will be asked to add the country code as +1<PHONE_NUMBER>

For consistency with staging, let's just appendCountryCode to user input. Initially it will always be +1.

@Prince-Mendiratta Thank you. I think we are almost done. Please allow me some hours to test and report back.

@Prince-Mendiratta Sorry for the delay. I think we have a bug that we need to fix. I think this bug existed for long due to a poor design but it may be even buggier with the addition of country code to user input.
The bug is on NewContactMethodPage. In this page the input that we validate here and the input that we end up using here are different. Example: If a UK user enters 7911 123456 we will add +44 so the final input is +44 7911 123456 which is valid. But on submitting the form we submit 7911 123456 which will yield an error and it's confusing. We need to fix that, the input that we end up using should be the same one that we validated.
I like the way this is handled on LoginForm.

@Prince-Mendiratta

Do we also want to show an error if the input is not valid?

No, I don't see a reason to do this, unless this PR is responsible for a change is in that area. Is it the case?

Tests good so far but we need to fix https://github.com/Expensify/App/issues/16760 as well.
The phone number here https://github.com/Expensify/App/blob/4947508bedc2e901082d805c84498f5f394ef655/src/pages/EnablePayments/AdditionalDetailsStep.js#L176 and here https://github.com/Expensify/App/blob/4947508bedc2e901082d805c84498f5f394ef655/src/pages/ReimbursementAccount/CompanyStep.js#L151 should be the one that we validated.
To do that, instead of using getPhoneNumberWithoutUSCountryCodeAndSpecialChars we should use parsePhoneNumber(phoneNumber, {regionCode: 'US'}).number.significant.
Then remove the getPhoneNumberWithoutUSCountryCodeAndSpecialChars as it won't be needed.

Reviewer Checklist

[X] I have verified the author checklist is complete (all boxes are checked off).
[X] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[X] I verified the steps for local testing are in the Tests section
[X] I verified the steps for Staging and/or Production testing are in the QA steps section
[X] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[X] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[X] I checked that screenshots or videos are included for tests on all platforms
[X] I included screenshots or videos for tests on all platforms
[X] I verified tests pass on all platforms & I tested again on:

[X] Android / native
[X] Android / Chrome
[X] iOS / native
[X] iOS / Safari
[X] MacOS / Chrome / Safari
[X] MacOS / Desktop

[X] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[X] I verified proper code patterns were followed (see Reviewing the code)

[X] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[X] I verified that comments were added to code that is not self explanatory
[X] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[X] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[X] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[X] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[X] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[X] I verified the JSDocs style guidelines (in STYLE.md) were followed

[X] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[X] I verified that this PR follows the guidelines as stated in the Review Guidelines
[X] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[X] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[X] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[X] If a new component is created I verified that:

[X] A similar component doesn't exist in the codebase
[X] All props are defined accurately and each prop has a /** comment above it */
[X] The file is named correctly
[X] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[X] The only data being stored in the state is data necessary for rendering and nothing else
[X] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[X] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[X] All JSX used for rendering exists in the render method
[X] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[X] If any new file was added I verified that:

[X] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[X] If a new CSS style is added I verified that:

[X] A similar style doesn't already exist
[X] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[X] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[X] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[X] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[X] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[X] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[X] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@Prince-Mendiratta Can you please update the test steps to something more straightforward like:

Login to ND
Click on the Search icon
Type an invalid number e.g. +444
Verify the Please enter a valid phone number... message is shown below the input
Verify no results are returned
Type a valid number e.g. +1<PHONE_NUMBER>
Verify no message is shown below the input
Verify the phone number / user is found

@Prince-Mendiratta I think the tests cases are redundant (country code and format does not produce any diff), just use the tests as provided XD.

Thanks again @Prince-Mendiratta

Conflicts in package.json FYI @Prince-Mendiratta

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Hey @Prince-Mendiratta Sorry to bother you but the last commit of resolving conflicts undid the fix for the highlighted bug here  https://github.com/Expensify/App/pull/17578#issuecomment-1516988970
@puneetlath Should we follow this by another PR?

Let's revert since we still have the ability. And we can add the fix to an updated PR.
@Prince-Mendiratta please go ahead and open a separate PR with these changes and the fix.

That works

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.8-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.8-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@fedirjh Hmm is this the offending PR? I don't think we changed that behaviour, previously we weren't taking the sms domain in consideration either.
    const isPhoneNumber = CONST.REGEX.PHONE_WITH_SPECIAL_CHARS.test(searchInputValue);
    const searchValue = isPhoneNumber ? searchInputValue.replace(CONST.REGEX.NON_NUMERIC_WITH_PLUS, '') : searchInputValue;


Copy Task: How to map to sink's Timestamp column if sink is Azure Table?

When sink is an Azure Table and if using explicit mapping I get a Timestamp column. I tried to exclude it from mapping, but then execution of copy task fails, because number of source and sink columns is not equal. Since Timestamp column is handled by server it should not show in the mapping at all. Can you tell me how to map the Timestamp column or how to avoid the exception.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 75402f01-c53e-25e0-6f1c-bc94d797dda1
Version Independent ID: a3dfb190-a12d-37cf-2dfe-034becd60e39
Content: Schema mapping in copy activity
Content Source: articles/data-factory/copy-activity-schema-and-type-mapping.md
Service: data-factory
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@h28669 Thanks for the feedback! We are currently investigating and will update you shortly.

Hi @h28669
Are you still facing this issue?  If that is the case please read the below threads they should help
https://stackoverflow.com/questions/45304371/copying-7-column-table-to-6-column-table
https://stackoverflow.com/questions/52060606/copy-data-how-to-skip-identity-columns
If this doesn't work would you please share more detail on your scenario and what you have tried so far?
Thank you,
Alberto Vega

Hi
My current workaround is to create a pseudo DateTime column in source and map it to Timestamp column in sink. The value from source is then ignored, since timestamp is created/updated on server-side. However, this is an ugly workaround, for something that MS should fix: simply do not show the Timestamp column in sink, if sink is an Azure table and do not count it when comparing number of columns.
BR, Gianni


Added examples/data-channels-flow-control

Resolves #811

Codecov Report

Merging #812 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #812      +/-   ##
========================================
- Coverage   76.04%    76%   -0.05%
========================================
  Files          59     59
  Lines        4250   4250
========================================
- Hits         3232   3230       -2
- Misses        747    750       +3
+ Partials      271    270       -1

Impacted Files
Coverage Δ

dtlstransport.go
66.86% <0%> (-2.33%)
:arrow_down:

sctptransport.go
76.87% <0%> (+1.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f27f9e...b476a38. Read the comment docs.

@hugoArregui I can try whatever that makes this example easier to understand. Which part did you think it was confusing? What do you mean by "removing endpoint"?
I actually tried to localize signaling exchange in the main() (so that you wouldn't see it in the logic above). Also, avoid having separate implementation for each endpoint by having Endpoint, otherwise, it would have redundant lines in the code to have shorter code. (I am just trying to find the best approach..)

@hugoArregui I can try whatever that makes this example easier to understand. Which part did you think it was confusing? What do you mean by "removing endpoint"?
I actually tried to localize signaling exchange in the main() (so that you wouldn't see it in the logic above). Also, avoid having separate implementation for each endpoint by having Endpoint, otherwise, it would have redundant lines in the code, more lines in the code. (I am just trying to find the best approach..)

Maybe is not possible to avoid it, for me it was distracting to read about the Endpoint struct, I was trying to understand what and endpoint was. But I'm not saying the code is not clear, I like the implementation a lot, I just think in this particullar case it may be worth to have a objectively worse code but focus on the control flow.
How much code are you reusing though, since you are not starting the second endpoint it seems to me there is not a lot in common. I can give it a shot myself later tonight

@hugoArregui Let me flatten the code to see if it looks better then...

@enobufs perhaps something like this: https://gist.github.com/hugoArregui/fcfba97fb5f4dc06a2497d9370c413c8
Which is objectively worst than yours btw!, I just think is more straight to the point, feel free to disagree and merge as it is thought, this is very subjective.

@hugoArregui I am ok with it. Can you push the code and I can approve it. Thanks!

There you go!

Oh that was fast!  It looks much better! Approved back at you! ;)

Oh.. I have to update the README to align with the new code.
An unrelated test is failing also.


cleaner tab broken when there is bad failed job

When click on Cleaner tab it shows:

NoMethodError at /cleaner
undefined method `[]' for nil:NilClass

job variable at line https://github.com/ono/resque-cleaner/blob/master/lib/resque_cleaner.rb#L56 has value {"failed_at"=>"2011/10/13 04:35:36", "payload"=>nil, "exception"=>"Resque::DirtyExit", "queue"=>nil, "worker"=>"rems3-1.dcjp02.reallyenglish.com:61035:high,low,seibido,n2r", "error"=>"Resque::DirtyExit", "backtrace"=>[]} which is not expected hash structure so it fails.

Thanks for reporting the issue. This explains https://github.com/ono/resque-cleaner/pull/8 as well.
I will look into it and work out for the solution.


Flow 0.20.1 and Facebook flux / fbjs libraries

flow check throws errors if you are using Facebook flux and fbjs libraries.
node_modules/fbjs/flow/include/PromiseMap.js:19
 19: import type * as Promise from 'Promise';
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ import type * as Promise. This is invalid syntax. Maybe you meant: `import type Promise from "Promise"`?

node_modules/flux/flow/include/FluxMixinLegacy.js:15
 15: import type * as FluxStore from 'FluxStore';
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ import type * as FluxStore. This is invalid syntax. Maybe you meant: `import type FluxStore from "FluxStore"`?

Is it Flow or Flux / fbjs issue?

This issue was discussed in #1215 so just Flux and fbjs need to be updated.

I’m going to close this as it sounds like the issue has been fixed. If you still have problems let me know 👍


Using INF as float breaks scene

Godot version:
v3.2.2.stable.mono.official
OS/device including version:

OS: Windows 10
Issue description:
After using a tool script to set a Raycast2D node's cast_to to positive y on infinity, I attempted to run the scene but the game simply crashes. After reopening the editor fails to parse the scene. Included in the log is the following:
 Invalid color code: #.
 scene/resources/resource_format_text.cpp:278 - res://Test.tscn:36 - Parse Error: Expected ',' or ')' in constructor
 Failed to load resource 'res://Test.tscn'.
 Failed loading resource: res://Test.tscn.
 editor/editor_data.cpp:567 - Index p_idx = 1 is out of bounds (edited_scene.size() = 1).

Steps to reproduce:

Set RayCast2D "Cast To" to INF
Run scene or close scene and reopen.

Minimal reproduction project:

INFbug.zip

See also previous occurrences of the same issue: https://github.com/godotengine/godot/issues/35388, https://github.com/godotengine/godot/issues/28883.

I've tested on Windows (latest 3.2 branch), and it looks like it's fixed for float variables but still occurs with Vector2.
Here's the script I'm using to set the values:
tool
extends Node

export(float) var test_float
export(Vector2) var test_vec2

func _ready():
	test_float = INF
	test_vec2 = Vector2(INF, INF)

As a note, entering INF in the editor itself will set it to 1.#INF and displayed as 1.#IO

1.#INF and displayed as 1.#IO

This is non-standard format specific to pre-Visual Studio 2015 C runtime, all other CRTs should print it as inf.

Should the editor even allow entering INF in the inspector?

The only reason why I had to do that was for an Infinite raycast. I'm not aware of any other reason to do so.

This is a quite consistent 'problem'.
For example setting the far property of a camera to inf (by script or in editor) causes the camera to stop working.
I guess it is quite a task to make everything 'inf proof'. However godot is not the only software that doesn't like inf. So I always avoid it and just use very large numbers instead. I guess the point of inf is more to have it as output when something overflows, just like NaN. Maybe inf can be removed from gd script? (what is the use case that can't be solved by replacing it with a large value?)

@redoxCode We can prevent using INF in the inspector without removing the constant from GDScript. The inspector accepts expressions written in a ad-hoc language (see the Expression class), not GDScript.

I know. Still you would have a ton of code to make inf prove (since it can still be set to inf from script). On a second thought removing inf from gs script is really overkill. Maybe we just have to accept that some stuff breaks when set to inf (for now). Making everything inf prove is quite a task and maybe not worth it in some cases if the checks required decrease performance or bloat the code.

I had the same problem in 3.2.3. I did not input INF anywhere but as a result of setting some properties to particular values I ended up with an INF in the scene file and it made the scene impossible to load. While the appearance of INF should be prevented as much as possible, I think it should not break scenes like that, it's not friendly at all.


[BUG]: Audit Log Sync Error "Not Found (404)"

In the instruction guide (CoE Starter Kit - Documentation and Setup Instructions.pdf)
We are doing step 6 - setup audit log sync.
We can import the Json, we used an Security Reader admin account, without MFA.
When testing the connection, we receive the error as can be seen in the attachment.

We have tried to change the starting link from the Json file to protection.office.com, this gives the same error.
Thanks for looking into this.

When configuring, the custom connector can take a few minutes to be provisioned.
At the top it says "this resource is being provisioned, please try again in a few minutes" - have you given it 10-15 mins and then tested again, and is it still failing now?

When configuring, the custom connector can take a few minutes to be provisioned.
At the top it says "this resource is being provisioned, please try again in a few minutes" - have you given it 10-15 mins and then tested again, and is it still failing now?

It is still failing, even after 2 days of waiting.

@manuelap-msft Any other ideas?

We've actually had this issue earlier this week too.

If you edit the custom connector and go to the General tab, can you confirm the host is set to outlook.office365.com

If this is the case, but it still fails, I would recommend downloading the connector again and re-creating it.

Hi @manuelap-msft
We did change that, as I saw that was wrong indeed.
Already tried to re-download it as well. It keeps giving the same error.

Are you able to access the Audit Log from the Office 365 Admin Center and see the Launch details there?

Hi there. I'm checking in to see if this issue was resolved for you.
Thanks,
Jenefer

Closing out old issues without existing action. Please let us know if you have issues in the future!


junit output for out tests

What would you like to be added:
Lots of tools and CI tools are used to work with junit xml output. Would be cool if our tests could produce that as well.
Why is this needed:

I think @zmalik requested this feature as well

thanks @alenkacz! yeah, that's right. This feature will be a lot of help running kudo test and gaining a lot more visibility of what's going on with tests in a build.

We can very easily add these to CI (e.g., https://github.com/jstemmer/go-junit-report). Do we also need them locally?

Aha, looks like Go test can output as json - we can collect that output, present it nicely to the user, and also generate junit reports from that.
https://golang.org/cmd/go/#hdr-Test_packages

I've used https://github.com/jstemmer/go-junit-report for this purpose before. Worked great for reporting test results in a Jenkins pipeline.
I'll take a look on how this can be integrated into kubectl kudo test.

To support something like kubectl kudo test -junit, the current testing implementation will have to be refactored to not give up all control to go test in https://github.com/kudobuilder/kudo/blob/master/pkg/test/utils/testing.go#L33. Test output needs to be captured then transformed with https://github.com/jstemmer/go-junit-report/blob/master/formatter/formatter.go#L63.
As a simple workaround running
kubectl kudo test 2>&1 | go-junit-report > report.xml

should work right now.

@nfnt nice! I am fine with that - if we adjust the circle CI to do that as well and collect the output, that is good enough solution for me. Thanks for investigating! I would actually love this feature so we can collect some stats around our builds


Update to embedded-hal 1.0

Are there any plans to update to the new stable release of embedded-hal 1.0? It might be a little tricky since a couple big changes have been made since 0.2:

all blocking I2C operations are grouped together under a single trait: embedded_hal::i2c::I2c
the I2C trait now supports both 7bit and 10bit addresses using a generic address parameter

Thankfully, the actual write and write_read methods don't seem to have changed at all, aside from the address size.

Upgrading to embedded-hal 1.0 should be very simple here. Just changing the imports and grouping the write and write_read operations.
However, I wanted to give some time to @nils-van-zuijlen who is busy working on async support.

I am currently waiting on an answer in https://github.com/nvksv/maybe-async-cfg/issues/2, and upgrading to have only a single I2C trait may make it easier to toggle between them.

@nils-van-zuijlen Last week @andresv used maybe-async-cfg to add async support to the tcs3472 driver in this PR. Maybe that is helpful to you.


"google-chrome": executable file not found in $PATH

Is it compatible with Microsoft Edge, with the addition that I am testing on MacOS?

You should be able to use it with Edge and MacOS.
I suppose you want to run it with ai: chatgpt.
You can run Edge in debug mode with something like this (I haven't tested it because I don't own a macos):
"/Applications/Microsoft Edge.app/Contents/MacOS/Microsoft Edge" --remote-debugging-port=9222 --user-data-dir=~/EdgeDebug

And then using chatgpt-remote: https://localhost:9222 in your config file.

It suffices, thank you.


Add back plotting function back

Here's what I get locally

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.04%. Comparing base (75c15a4) to head (f4f849a).
Report is 15 commits behind head on yammbs-models.

Additional details and impacted files


Earthquake doesn't refresh automatically

I'm using ruby-1.9.2-p290 and latest earthquake.gem
When I start it, it logs in successfully - I can get recent tweets with :recent command and post updates.
Unfortunately the app doesn't refresh automatically (as it can be seen here )
I tried to debug it myself, but I couldn't find any obvious reasons as to why it wouldn't work

Thank you for interest in earchquake.gem :)
Maybe you need to recompile ruby to use readline.
If you are using rvm, please see the "Install" in the README to do it: https://github.com/jugyo/earthquake
Best regards

It looks like a readline problem. Here's what I did:

removed ruby-1.9.2 and installed it as per readme (somehow I missed that before :-( )
just in case reinstalled all the gems
starting earthquake, problem persists

then I noticed something - when I press tab key, I get an error notification (it's too big to be shown in growl). So I've added log-to-file method to get some info.
After some digging around I've isolated the code which causes problems - it's the readline autocompletion stuff. The error being thrown is:
invalid byte sequence in UTF

Wrapping that part around begin..rescue..end fixes earthquake.
I'll see whether I can create a patch which fixes this.

Sorry, the problem of autocompletion is maybe my bug.

Right... If you want I can keep poking around and see if I can fix it.
For now disabling autocompletion will make earthquake usable (I'm not sure how many users this affects - it might be just OSX thing).

Is there a way to disable autocompletion easily in order to make earthquake refresh on OSX?

@dakrone - I found a (possible) solution to the problem:
check if you have any ncurses or readline related libraries installed via macports and/or homebrew. I've been cleaning up my environment and I found that removing ncursesw package fixed my readline problems - which cause Earthquake to misbehave.

:-/ I have ncursesw through homebrew, however I need it for other programs to work. Guess I will have to wait until it's fixed in Earthquake.

@dakrone - try it anyway - you can always reinstall it later.
Before uninstalling ncursesw I couldn't make mcabber to work (or compile - it was pretty random). Once I removed it it started working.

I attempted to uninstall ncursesw, but earthquake still didn't stream updates.

I am also having this issue with OSX, installed according to the README.

Same, here I removed 1.9.2 and installed it the way as suggested in the README.

I'm feeling that readline functionality should be ok as a prerequisite for using Earthquake.
Almost users must depend on not only completion, line editing, history (including incremental search) and so on,
but also buffer refreshing and/or to get cursor point internally.
To conclude, I guess we had better apply #105 :).
FYI, readline.so before r34391 (yes, it's 2.0.0dev world) does not respect the encoding of completion candidates.
The error mentioned above by @lukaszkorecki may be fixed in trunk of ruby.
http://bugs.ruby-lang.org/issues/5941
Thanks,


Adding HoleM63

Hello all,
This Pull Request introduce a new Hole,
HoleM63
Top_flat :

Normal :

This Hole has the particularity to have two schematics with possibility to change beetween normal and top flat.
Best regards,
Clément

Thank you for your contribution !


Handling missing historical info

There are some stocks that were lightly traded in previous years, and on some days, they had zero volume, zero trades.
ex: DRIP -- June 2, 2015.
or YINN for many days in 2015.
Yahoo finance historical prices shows these days as entries with all zeros.
It seems that this library just omits these days, and its difficult to determine in code if missing days are a result of yahoo finance having bad data, or if its valid no trading for the day.
What do you think about replicating the zero entries for those dates in this library? I could do this in my own code, but others might have this issue as well, so might make more sense to fix it here.

@IvanBohannon thank you for the feedback. Actually, there's a similar question asked in #3, and the solution at that time is to ignore all the invalid entries.
But I think what you are telling is probably a better approach on handling the nulls, it seems we could make it the default behaviour but an optional parameter for ignoring all invalids, and marked it as a breaking change.
In addition, it might be more appropriate to change the value type from decimals to nullable decimals, and mark it null instead of zero, as others may misuse the zeros for calculation which is a fatal error when doing analysis. What do you think?

Nullable instead of zeros makes sense, and would let us still have entries for those days - which from a test perspective is useful.  Yahoo chose to returning zeros for those days with no recorded trades, which is confusing.
We might be able to avoid a breaking change if we add a field to indicate if data was invalid, instead of returning zeros or nullables.
I'm fine either way, but leaning towards less breaking 😄

In fact, the invalid data in csv are empty strings 😃  , so there is error when converting it to decimal, hence the skipping logic.
I agree that it should be less breaking but I think adding a field is too much for each candle. Perhaps we could add an optional flag "leaveZeroIfInvalidRow" in GetHistoricalMethods & default it to false.
In this way, there is no breaking for current user who favors the skip logic, and it also favor users like you who wants the leave zero logic.
If it's ok for you, I will start the implementation 😃


Removed erroneous apostrophes from test line 3 - create-a-controlled-input

Removed quotes from test 3

[x ] I have read freeCodeCamp's contribution guidelines.
[x ] My pull request has a descriptive title (not a vague title like Update index.md)
[x ] My pull request targets the master branch of freeCodeCamp.
[x ] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x ] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

@JoshuaBurleson Not sure why you thought the single quotation marks you removed were apostrophes or why you thought they were not supposed to be there.  By removing them, you now have caused the build to fail.  They must be there to allow the use of colons in the yaml section.
In the future, you should test your changes locally by setting up the repo locally and running npm run test:curriculum.  If all the tests pass, then you can create a PR.
I am closing this PR as not needed and invalid.

Ah! Missed the yaml tag ::facepalm:: should have set up the repo locally to being with. Thanks Randell.


Improved query DSL

Currently we're using Sequel DSL to build queries (aka relation views), it's good-enough for now but I don't consider it to be the final solution and would be great to come up with a simpler DSL for 1.0.0.
Using rom relations means leveraging features of your database, we want to focus on building optimized queries that return results that match exactly what we want to have from the application domain point of view. This means using joins and projecting data in all kinds of ways is a typical usage of rom-sql, using mappers to further transform data should be a rare use-case.
This comes with a couple of challenges:

Renaming columns
Qualifying columns
Extending header (aka columns)
Selecting columns automatically based on the view definition
Extracting values from a loaded relation that is passed into curried-for-combine-views

Here's a typical scenario that uses sequel naming conventions to qualify/rename columns and join relations:
class Tasks < ROM::Relation[:sql]
  # we define the header explicitly
  view(:for_users, [:id, :title, :user_id]) do |users|
    select(
      # even though we have the header defined, we still need to manually select
      # the columns, it's tricky because you can select columns and rename them using
      # various approaches
      :tasks__id, :tasks__title, :tasks__user_id
    ).inner_join(
      # qualifying column names is a good habit, it's easy to use wrong column name
      # accidentally and in some scenarios it will go unnoticed (and obviously cause major bugs)
      # the issue here is that underscore-based approach from sequel is ugly when names are long
      :users, users__id: :tasks__user_id
    ).where(
      # writing that `.map` on input relation is a super-common thing to do, this is a loaded relation
      # so we could introduce a plugin that extracts specific information from it
      #
      # ie we could have `users.foreign_keys` or `users.primary_keys`
      tasks__user_id: users.map { |u| u[:id] }
    )
  end
end

Ideas for an improved DSL
????? TBD

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/28534400-improved-query-dsl?utm_campaign=plugin&utm_content=tracker%2F8353094&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F8353094&utm_medium=issues&utm_source=github).

So at a minimum it makes sense to support nested hashes for specifying keys.
class Tasks < ROM::Relation[:sql]
  # we define the header explicitly
  view(:for_users, [:id, :title, :user_id]) do |users|
    select(tasks: [:id, :title, :user_id])
      .inner_join(:users, {users: :id, tasks: :user_id})
      .where(tasks: {user_id: users.map { |u| u[:id] }})
  end
end

@solnic could you elaborate on/rephrase "Extracting values from a loaded relation that is passed into curried-for-combine-views"?

@endash sure, sorry for not being specific there. It's a very common pattern that a relation view receives a loaded relation to generate a query for relation composition. ie in rom-repo you can do users.combine_children(many: tasks.for_users) which results in materializing users and passing them to tasks.for_users. Them, typically, you do where(users__id: users.map { |u| u[:id] }). Since passed in users is Relation::Loaded rather than a plain array, we are free to introduce new interfaces to simplify this process.


Put cursor on line with current file opened in buffer

Hello,
very nice plugin! Really COOL!
When I open Triptych from a buffer that has some existing file opened, I would like cursor in Triptych to be placed on the file in the list of files.

Hi @tex This should actually be the existing functionality. Can you confirm that you're on the latest version, up to date with main, and then provide me your Triptych config, and either steps to reproduce or a repo where the problem is occurring?

Hi @simonmclean. I am a litle bit embarrased. I tried it again today and it indeed works as expected. I really do not know what I did differently.

Oh, I found where it doesn't work. I have 2 setups using same neovim config, on Linux and on Windows/WSL2. It does not work on Windows/WSL2.

It gets path correctly, but it doesn't place cursor on correct file. Always on first one.

@tex Mind updating and trying now?

@simonmclean Thank you! This fixed the issue.


Solution for tsne doesn't work on Python3.5

I tried to use it in Python3.5. When I run this command "from tsne import bh_sne" to test I saw error:
from bh_sne import BH_SNE
File "tsne/bh_sne.pyx", line 2, in init tsne.bh_sne (tsne/bh_sne.cpp:4209)
SystemError: Parent module '' not loaded, cannot perform relative import
I digged a liitle into into it and found that it can be fixed by commenting out line 2 in file tsne/bh_sne.pyx, rebuild and install.
---------------------  tsne/bh_sne.pyx  --------------------
import numpy as np    <--- This is the line I commented out to make it work in Python3.5
cimport numpy as np
cimport cython
I don't know why this fixes the issue but just want leave some reference information for those will encounter the same problem as I did.

Same encounter the same error, but commenting the line does not fix the problem. If I comment the line and recompile, it imports fine. But when running bh_sne, it complains about 'np' not being defined...:

----> tsne.bh_sne(np.random.normal(0,1,(40,20)))
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-5-2cbae1ab71c4> in <module>()
----> 1 tsne.bh_sne(np.random.normal(0,1,(40,20)))

/home/maxz/Documents/tsne/tsne/__init__.py in bh_sne(data, pca_d, d, perplexity, theta, random_state, copy_data)
     57
     58     tsne = BH_SNE()
---> 59     Y = tsne.run(X, N, X.shape[1], d, perplexity, theta, seed)
     60     return Y
     61

/home/maxz/Documents/tsne/tsne/bh_sne.pyx in tsne.bh_sne.BH_SNE.run (tsne/bh_sne.cpp:1571)()

NameError: name 'np' is not defined
> /home/maxz/Documents/tsne/bh_sne.pyx(24)tsne.bh_sne.BH_SNE.run (tsne/bh_sne.cpp:1571)()

Same Problem for me. I was not able to run this on 3.5

I was able to work around this by doing the following:

in setup.py change the Extension name to be fully qualified, e.g. name=tsne.bh_sne
in tsne/init.py fully qualify the bh_sne(_3d) imports, e.g. from tsne.bh_sne import BH_SNE

@rappdw +1
To add:
After installation use the below line to import:
import tsne.bh_sne as bh_sne

File "tsne/bh_sne.pyx", line 12, in init tsne.bh_sne
AttributeError: type object 'tsne.bh_sne.BH_SNE' has no attribute 'reduce_cython'

@mohitkaushikj133 #29


[RESOLVED] High ICMP ping loss

Problem started at 16:26:14 on 2023.04.27
Problem name: High ICMP ping loss
Host: MF-FG
Severity: Warning
Operational data: Loss: 33.33 %
Original problem ID: 20101
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23131&eventid=20101

Problem has been resolved in 2m 0s at 16:28:14 on 2023.04.27
Problem name: High ICMP ping loss
Host: MF-FG
Severity: Warning
Original problem ID: 20101


Added replica pinging during key load callback + relevant configs

Ping replicas during key load to prevent timeouts from the master. Also added 2 new config settings: loading-process-events-interval-bytes and loading-process-events-interval-keys, which determine how often to run the rdb load callback using bytes processed and keys loaded respectively.

Merged.

Merged.


Fix: Fix flick sound

This PR fixes the sound of flick.
I noticed that single flick and slide flick will be play with one sound.

Sorry for the late reply!
LGTM, ty!


Allow configuring the root of the Rust project

The action currently assumes that the Rust project is directly in the root of the repository. This is not always the case, but Action cannot be configured with a working directory. Instead, a separate input is necessary. This was also requested as PROJECT_PATH for the audit-check action. https://github.com/actions-rs/audit-check/issues/116

Thank you @mbergkvist for adding this feature. Would it be possible to cut a release? I would love to use the file field in a CI job where we have multiple Rust workspaces in a single git repository, and would like to audit all of them.

@jonasbb If you plan to make a new release, have a look at #56 and see if that can be included in the release too.

I released a new version and included #56 in it.

Thank you for a very swift response and release! :rocket: This works really well for us!


Make fields configurable

This PR adds the ability to enable/disable fields per store view in the admin interface.
Resolves #18

Strange positioning ... I think it should be before or after shipping method

@amenk Maybe this is because of some custom xml? I'm not sure if the positioning is a consequence of my pr. Did you test with the base module?

Good catch ! The dev-master has the same problem. I will debug

@sbodak Would you mind reviewing?

@kolaente Please read my explanation here
https://github.com/sbodak/magento2-checkout-custom-form/issues/18#issuecomment-473014488


cherry-pick-for: warn against using it when symbolic links are changed

The patches GitHub generates don't work well for updating symbolic
links.
Warn against using this script then and make clear that we don't really
need it anymore for change tracking. Also handle submodules to get a
clean state.
How to use
Testing done
Used for cherry-picking a scripts PR

The script also accepts a list of commits, maybe we could try to see if the PR's patches are reachable as commit IDs, or dig deeper into where the symlink problem comes from. I've also noticed that the patch footer is missing on GitHub but it still seems to work:
--
2.26.2


Delete comment while network reply is open will delete reply

User 1: create comment 1
User 2: start a reply to comment 1 (reply 1) but don't click save and leave the comment open
User 1 delete comment 1
User 2: the reply being edited will close along with the original comment

Won't fix. #100
This would have required establishing locking a whole comment thread.


as it mentioned that now ACFloating Textfield can show the error at bottom but its not working

how can i show the error message at bottom of the line

you can not show the error at bottom currently however you can integrate
your own logic to show error at bottom of field Thanks
On Fri, 6 Apr 2018 at 4:22 PM, iosDevJd<EMAIL_ADDRESS>wrote:

how can i show the error message at bottom of the line
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ErAbhishekChandani/ACFloatingTextfield/issues/58, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ANMZ1634lPk6pFwLzpkjW255S8iDXtdzks5tl0j6gaJpZM4TJ3V3
.

--
Thanks & Regards
Er. Abhishek Chandani

if you are using ACFloatingTextfield.so u can also change bottom line colour
i.e in ACFloatingTextfield
=>/// Change Bottom Line Color.
@IBInspectable open var lineColor : UIColor = UIColor.white

Error is shown on top but you can change the color of line in case of error by errorLineColor


Unable to build v1.4.0 with carthage

$ carthage update
*** Checking out TrustKit at "3a9d1ada34b0d48bbf7e190582ca44de80e9b03f"
*** xcodebuild output can be found in /var/folders/5k/mvb95qrx6mvdjyx66kxvlqpr0000gp/T/carthage-xcodebuild.dJefcO.log
*** Building scheme "TrustKit OS X" in TrustKit.xcodeproj
2016-10-04 11:50:53.437 xcodebuild[3439:239621] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/ZLXCodeLine.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:53.438 xcodebuild[3439:239621] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/XCoverage.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:53.439 xcodebuild[3439:239621] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/RealmBrowser.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:53.441 xcodebuild[3439:239621] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/FuzzyAutocomplete.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:53.442 xcodebuild[3439:239621] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/ColorSenseRainbow.xcplugin' not present in DVTPlugInCompatibilityUUIDs
*** Building scheme "TrustKit tvOS" in TrustKit.xcodeproj
2016-10-04 11:50:56.504 xcodebuild[3517:239809] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/ZLXCodeLine.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:56.505 xcodebuild[3517:239809] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/XCoverage.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:56.506 xcodebuild[3517:239809] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/RealmBrowser.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:56.507 xcodebuild[3517:239809] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/FuzzyAutocomplete.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:56.509 xcodebuild[3517:239809] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/ColorSenseRainbow.xcplugin' not present in DVTPlugInCompatibilityUUIDs
** BUILD FAILED **

The following build commands failed:
	CompileC /Users/adodatko/Library/Developer/Xcode/DerivedData/TrustKit-ezecneeiogldkbgkmmakfxdvekrb/Build/Intermediates/TrustKit.build/Release-appletvos/TrustKit\ tvOS.build/Objects-normal/arm64/public_key_utils.o TrustKit/Pinning/public_key_utils.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
/tmp/1/Carthage/Checkouts/TrustKit/TrustKit/Dependencies/domain_registry/private/trie_search.c:67:24: warning: no previous prototype for function 'FindNodeInRange' [-Wmissing-prototypes]
/tmp/1/Carthage/Checkouts/TrustKit/TrustKit/Dependencies/domain_registry/private/trie_search.c:100:13: warning: no previous prototype for function 'FindLeafNodeInRange' [-Wmissing-prototypes]
/tmp/1/Carthage/Checkouts/TrustKit/TrustKit/Dependencies/domain_registry/private/registry_search.c:47:12: warning: implicit conversion changes signedness: 'long' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
/tmp/1/Carthage/Checkouts/TrustKit/TrustKit/Dependencies/domain_registry/private/registry_search.c:53:41: warning: implicit conversion changes signedness: 'const char' to 'unsigned char' [-Wsign-conversion]
/tmp/1/Carthage/Checkouts/TrustKit/TrustKit/Dependencies/domain_registry/private/registry_search.c:256:25: warning: implicit conversion changes signedness: 'long' to 'size_t' (aka 'unsigned long') [-Wsign-conversion]
/tmp/1/Carthage/Checkouts/TrustKit/TrustKit/Dependencies/domain_registry/private/assert.c:23:6: warning: no previous prototype for function 'DefaultAssertHandler' [-Wmissing-prototypes]
ld: warning: directory not found for option '-L/tmp/1/Carthage/Checkouts/TrustKit/TrustKit/Dependencies/domain_registry/osx'
/tmp/1/Carthage/Checkouts/TrustKit/TrustKit/Dependencies/domain_registry/private/trie_search.c:67:24: warning: no previous prototype for function 'FindNodeInRange' [-Wmissing-prototypes]
/tmp/1/Carthage/Checkouts/TrustKit/TrustKit/Dependencies/domain_registry/private/trie_search.c:100:13: warning: no previous prototype for function 'FindLeafNodeInRange' [-Wmissing-prototypes]
/tmp/1/Carthage/Checkouts/TrustKit/TrustKit/Pinning/public_key_utils.m:73:31: error: implicit declaration of function 'SecKeyCopyExternalRepresentation' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
/tmp/1/Carthage/Checkouts/TrustKit/TrustKit/Pinning/public_key_utils.m:73:15: warning: incompatible integer to pointer conversion initializing 'CFDataRef' (aka 'const struct __CFData *') with an expression of type 'int' [-Wint-conversion]
A shell task failed with exit code 65:
2016-10-04 11:50:56.504 xcodebuild[3517:239809] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/ZLXCodeLine.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:56.505 xcodebuild[3517:239809] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/XCoverage.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:56.506 xcodebuild[3517:239809] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/RealmBrowser.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:56.507 xcodebuild[3517:239809] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/FuzzyAutocomplete.xcplugin' not present in DVTPlugInCompatibilityUUIDs
2016-10-04 11:50:56.509 xcodebuild[3517:239809] [MT] PluginLoading: Required plug-in compatibility UUID ACA8656B-FEA8-4B6D-8E4A-93F4C95C362C for plug-in at path '~/Library/Application Support/Developer/Shared/Xcode/Plug-ins/ColorSenseRainbow.xcplugin' not present in DVTPlugInCompatibilityUUIDs
** BUILD FAILED **

The following build commands failed:
	CompileC /Users/adodatko/Library/Developer/Xcode/DerivedData/TrustKit-ezecneeiogldkbgkmmakfxdvekrb/Build/Intermediates/TrustKit.build/Release-appletvos/TrustKit\ tvOS.build/Objects-normal/arm64/public_key_utils.o TrustKit/Pinning/public_key_utils.m normal arm64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

My Cartfile
$ cat Cartfile
github "datatheorem/TrustKit" "master"

Found a workaround by building only iOS platform.
carthage build --platform iOS

However, in my opinion, carthage update should work out of box as long as you claim carthage compatible


round corners

I use the lib to convert my images, I would like to know if I can round the corners of the image with it. I didn't see anything in the documentation about this? Thanks

We don't support it with this library at this moment.


Configurable ITheatreLogger

A logger with three separate audiences:

internal: Logs for developers maintaining Theatre.js
dev: Logs for developers using Theatre.js
public: Logs for everyone

This logger supports:

multiple logging levels (error, warn, debug, trace),
multiple audience levels (internal, dev, public),
multiple categories (general, todo, troubleshooting)
named and keyed loggers (e.g. rootLogger.named("Project", project.id))
console styling with deterministic coloring
console devtool maintains accurate sourcemap link to logging origin (e.g. coreExports.ts:71 as opposed to logger.ts:45 or whatever)
swappable logger
customizable filtering
Accepts lazy args: args: () => object via logger.lazy.<level>("message", () => <expensive computation>) (e.g. logger.lazy.debugDev("Loaded project state", () => ({ save: bigProject.exportToSaveable() })))

I've fixed the remaining extraneous log in a fixup. This should be good to go. If there are any concerns with how this affects bundle size of core, we can definitely apply some optimizations for how it gets bundled to remove internal logging statements via esbuild plugins.


Light version (Feature request)

I like ClassicPowerMenu, but dont like how accesibility service works (on oneui). Is it possible to compile a "lite" version, with menu access by tapping icon, and settings by long click?
Thanks

You can already do this with app shortcuts, just use the shortcut from the long press menu of the app's icon - it opens the menu immediately.


Refactor documentation

Our documentation - hosted in https://robocop.readthedocs.io/en/latest/ - require refactors:

'rules' section contain only Rule class definition, where rules are actually listed under 'checkers' - remove checkers page and move it's content to 'rules'
Fix duplicated modules "Defined in robocop.checkers.robocop.checkers.documentation.MissingDocumentationChecker"
Fix printing type of configurable ('set' instead of <class ‘set’>)
Add default value of configurable
Add metavars
Fix empty space between rows in tables:

Escape strings read from the robocop:


Use Ember

Changes Introduced
A short description of the changes that were introduced
Applicable linked issues
Checklist (check all that apply)

[ ] This change maintains backwards compatibility
[ ] I have introduced tests for all new features and changes
[ ] I have added documentation covering all new features and changes
[ ] This pull-request is ready for review

Codecov Report

Merging #137 (db496a5) into main (98e826d) will increase coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   88.64%   89.03%   +0.39%
==========================================
  Files          87       86       -1
  Lines        2492     2481      -11
  Branches       56       69      +13
==========================================
  Hits         2209     2209
+ Misses        283      272      -11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98e826d...db496a5. Read the comment docs.


fix(mutation): clarify error behaviour

closes the report that I opened in the swr repo https://github.com/vercel/swr/issues/1214

Thanks!


Clerk Expo errors/not working on all platforms and versions.

[ ] Review the documentation: https://docs.clerk.dev/
[ ] Search for existing issues: https://github.com/clerkinc/javascript/issues
[ ] Go through package changelog files.
[ ] Provide the Frontend API key from your application dashboard.

Package + Version

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/localizations
[ X ] @clerk/clerk-expo
[ ] @clerk/backend
[ ] @clerk/clerk-sdk-node
[ ] @clerk/shared
[ ] @clerk/fastify
[ ] gatsby-plugin-clerk
[ ] build/tooling/chore
[ ] other:

Version:
0.12.5

Browser/OS
All
Description
App.js (1247:889)
Can't find variable: EventTarget
(Device)
  Evaluating<EMAIL_ADDRESS>  Evaluating module://App.js.js

This error happens on all platforms, on my local computer, with all package versions, etc. Not sure I am doing something wrong but I have attached an extremely basic sandbox.
https://snack.expo.dev/@eliotjackson/mature-popcorn
The clerk-expo-starter repo has the same problem. I've gone through all the clerk-expo versions back to .0.8.
Also tried what was suggested here
We have reproduced it locally and are working on a fix.

⚠ Meanwhile, you can try using<EMAIL_ADDRESS>which is the latest working version. ⚠

The problematic 0.12.5 version has been unpublished.

Update:
It seems like it only happens on the first load. So if I comment out all entry points to anything Clerk at the root of my app, reload it (r) and then uncomment and let it fast refresh, everything works as it should.

The clerk-expo-starter repo has the same problem. I've gone through all the clerk-expo versions back to .0.8.

Also tried what was suggested here
We have reproduced it locally and are working on a fix.

⚠ Meanwhile, you can try using<EMAIL_ADDRESS>which is the latest working version. ⚠

The problematic 0.12.5 version has been unpublished.

@Motoxpro This must be due to an Expo cached build. Version 0.12.4 should work as expected. I am gonna close this and the updates about the fix will be posted on https://github.com/clerkinc/javascript/issues/870.

Thanks. Were you able to get it to work in the snack? I have tried it on multiple computers, snacks, etc. and I wasn't able to get 0.12.4 working either.

I used https://github.com/clerkinc/clerk-expo-starter in a local IOS simulator.

@SokratisVidros I'm sorry to be a bother, but could you check the snack? Only added 2 lines of code from the basic starter. This is the smallest reproducible sample I can make (literally just adding ClerkProvider).

@SokratisVidros I'm getting 0.12.4 working, but only with the shim you suggested on the other issue
import { Event, EventTarget } from 'event-target-shim';

if (!global.EventTarget) {
    global.EventTarget = EventTarget;
}

if (!global.Event) {
    global.Event = Event;
}

it doesn't work otherwise

The Snack is broken for me with a react-native error.

The above polyfill doesn't work. That's why I removed it from the comment.

hmm. I get the EventTarget error without it, but it the error clears and the project builds with it

Can you please clone https://github.com/clerkinc/clerk-expo-starter locally and try again?

Can you run npm why @clerk/clerk-expo in the repo? What's the output?

Thanks, this is helpful. I see what's happening. Can you please try adding "@clerk/clerk-js: "4.27.2" to your package.json, remove the polyfill and try again?

ok, tried adding this and the EventTarget error is back :(

That's why the error is back. The error occurs in ClerkJS 4.28.X. You can use yarn resolutions to ping @clerk/clerk-js to 4.27.2 version.

aha, ok! added a resolution to "@clerk/clerk-js": "4.27.2" in my root package.json and the error is gone without the polyfill 😄 thanks much

Glad it's working now and apologies for the hassle. We will ship the proper fix ASAP.


Fix Spine directory name

Fix the .spine directory generation name. Because of an error, it was generated as ..spine (with 2 dot symbols instead of 1).
Also, in this PR we change the logging level in the Extension getters and setters from trace to debug, since trace is not visible from the command line.

@armiol, PTAL.


Upgrade UI - Implement Withdraw feature for the "All accounts" mode

Describe the task
Implement Withdraw feature for the "All accounts" mode
Expect: When user standing on "All accounts" mode, click on "Withdraw" button -> Redirect user to the Withdraw screen with Select account field (refer claim reward)

Version test: https://file.cdmteck.com/s/4oimk9zDJ8R5Aai/download?path=%2F&files=./upgrade-ui-build-1.0.2-1-1681181326431.zip
Validation passed.


Update AppDefinition PATCH to match RFC 6902

Currently, PATCHing an AppDefinition takes a JSON blob that looks like a partial AppDefinition:
PATCH /v2/apps/appOfMyEye '{"instances": 5}'

However, that is not the correct way to implement PATCH as described in RFC 6902. PATCH bodies should be lists of modifications to a resource:
PATCH /v2/apps/appOfMyEye '[{"op": "replace", "path": "/instances", "value": 5}]'

We will not change the behavior of the /v2/apps API. We will address PUTting and PATCHing in the /v3/ API.


Missing parameter cfg.loss.zoom in trainval_sgaligner.py

Hello,
I encountered an issue while running the trainval_sgaligner.py script with the following command:
python trainers/trainval_sgaligner.py --config ../configs/scan3r/scan3r_ground_truth.yaml
At line 28 of the trainval_sgaligner.py file, the code raises an error: AttributeError: loss. It seems that the self.zoom attribute is not properly set due to the absence of the cfg.loss.zoom parameter.

Hi, thanks for pointing it out. I have updated the config files now.


Backport #1273 for v1.2.x: ignore all osx ci failures

This backports #1273.

@technoweenie good to go?

:+1:


Unable to use the library

I'm trying to use this library using an application with Node.js, Express and AngularJS. I've installed it with NPM, but now I can't use it.
The library is, of course, in node_modules. In my index template Jade page I have all my includes, but it seems that script(src="node_modules/ng-file-upload/dist/ng-file-upload.js") doesn't work, as I create a button in another page with ng-file-select and it doesn't display the exploring window. What could I do? Thanks in advance.

It is 'ngf-select`


⚠ Digital Ocean - https://status.digitalocean.com/ has degraded performance

In 465e26c, Digital Ocean - https://status.digitalocean.com/ (https://status.digitalocean.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 189 ms

Resolved: Digital Ocean - https://status.digitalocean.com/ performance has improved in 1bb6767.


Dolphin models problem (modelLoadError)

They just doesn't seems to work, so far tested phi 2 dolphin and mistral 7b dolphin and it don't work. Maybe I'm just dumb, if that's the case can someone give me a step by step guide on how to use phi 2 dolphin ? (I'm using TestFlight version and iPhone XR)

Btw sorry for my bad English, I'm French

I was able to run phi2 on iphone 15 pro but not able to run the same model on iphone XR

Still the same problem

I was able to run phi2 on iphone 15 pro but not able to run the same model on iphone XR

Iphone XR only has 3GB RAM, so try using q3_k_s quantization, might be able to get it to run.


Typographic details

Improves some typographic details like smart quotes, ellipses and dashes.

🙌 Thank you, this is great!


Der Konfigurationsfluss konnte nicht geladen werden: 500 Internal Server Error Server got itself in trouble

by adding miner integration

Version of the custom_component

Configuration
Add your logs here.

Describe the bug
A clear and concise description of what the bug is.
Debug log

Add your logs here.

Please actually fill out the form, if you provided logs I could actually look into this if it's not what I think it is...
In any case, AFAIU this is the same issue as #393, please read https://github.com/Schnitzel/hass-miner/issues/393#issuecomment-2438171292


Pull out check for fork

Currently the check for repo fork is done in AuthorOwnerCheck and needs to be pulled out and performed after both repo name check and gh-pages branch check.

originated fron #42

done


Scrutinizer Auto-Fixes

@Niko9911 requested this pull request.
It consists of patches automatically generated for this project on Scrutinizer:
https://scrutinizer-ci.com/g/Niko9911/ngfw-php-framework/

Merged via Gitlab.


Improved README

Associated Issue: #
Please get familiar with the contributing guide before submitting a PR.
Summary of Changes
Improvements on README

Pull Request Test Coverage Report for Build 124

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.0%

Totals

Change from base Build 116:
0.0%

Covered Lines:
88

Relevant Lines:
99

💛  - Coveralls

@akashjoffl Thanks for the effort but this was already fixed in #54 and #55


[helm/prometheus] Use contains on prometheus.fullname template

Before this change a release name of "kube-prometheus" will have a prometheus pod called "prometheus-kube-prometheus-prometheus".
With this change the same release will have a pod name "prometheus-kube-prometheus"

ping @gianrubio

@richeve can you rebase it after #1394 get merged?

@richerve FYI I just merged #1394.

Thanks @mxinden, rebased @gianrubio

thanks @richerve