Invalid hook call on login page

Describe the bug
I'm getting the following error:
(node:18527) UnhandledPromiseRejectionWarning: Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://fb.me/react-invalid-hook-call for tips about how to debug and fix this problem.
    at resolveDispatcher (/Users/david/workspace/dongwon-api/node_modules/react/cjs/react.development.js:1465:13)
    at Object.useState (/Users/david/workspace/dongwon-api/node_modules/react/cjs/react.development.js:1496:20)
    at ae (/Users/david/workspace/dongwon-api/node_modules/styled-components/dist/styled-components.cjs.js:1:13232)
    at processChild (/Users/david/workspace/dongwon-api/node_modules/admin-bro/node_modules/react-dom/cjs/react-dom-server.node.development.js:3043:14)
    at resolve (/Users/david/workspace/dongwon-api/node_modules/admin-bro/node_modules/react-dom/cjs/react-dom-server.node.development.js:2960:5)
    at ReactDOMServerRenderer.render (/Users/david/workspace/dongwon-api/node_modules/admin-bro/node_modules/react-dom/cjs/react-dom-server.node.development.js:3435:22)
    at ReactDOMServerRenderer.read (/Users/david/workspace/dongwon-api/node_modules/admin-bro/node_modules/react-dom/cjs/react-dom-server.node.development.js:3373:29)
    at renderToString (/Users/david/workspace/dongwon-api/node_modules/admin-bro/node_modules/react-dom/cjs/react-dom-server.node.development.js:3988:27)
    at html (/Users/david/workspace/dongwon-api/node_modules/admin-bro/lib/frontend/login-template.js:73:53)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at async /Users/david/workspace/dongwon-api/node_modules/@admin-bro/express/lib/authentication/login.handler.js:19:23

Installed libraries and their versions

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
To Reproduce
Steps to reproduce the behavior:

Use buildAuthenticatedRouter to create AdminBro router.
Run the app & visit /admin

Additional context
There's a closed issue about this matter, but I was not able to resolve this problem after removing node_modules or by adding react & react-dom as dependencies.

Just confirming, are you using admin-bro-expressjs or @admin-bro/express?

@dziraf My mistake, I'm using @admin-bro/express^3.1.0, and @admin-bro/design-system version is 1.7.0.

I will try to reproduce this error tomorrow. I DID get this error before, but only when developing admin-bro packages by yarn link-ing them though.
Two extra questions:

Is it an existing project and this is a new error or you've only just setup admin bro?
Could you check what's the package version of React in:
/node_modules/react/package.json
and
<EMAIL_ADDRESS>/node_modules/admin-bro/node_modules/react/package.json
It should be at the top.

First off, thanks for looking into this issue.
To answer your questions,

I started using admin-bro recently but just recently set up buildAuthenticatedRouter and encountered this error.
react version in /node_modules/react' is 16.13.1, node_modules/@admin-bro/design-systemis 16.13.1, and finally innode_modules/admin-bro` is also 16.13.1.

To provide a bit more context, I'm using a custom dashboard but I don't think it's related to this as the hook errors show up even when I'm using the vanilla dashboard.

I tried to reproduce on a clean project but I'm not experiencing this problem there.
Are you able to set up a simple repository where this error occurs for you so that I can clone it?
Also, we've released<EMAIL_ADDRESS>- I doubt updating will help in this case but is worth trying

I ended up fixing this problem. These are the steps I took:

Removed node_modules completely again
Deleted react & react-dom from dependencies in my package.json
Ran npm install again
On install, npm was complaining about missing peer dependencies for admin-bro like before (react, react-dom, etc).
Used install-peerdeps on admin-bro packages.
Works like a charm

After trying everything that has been mentioned about this error, it continues to persist... I don't know what to do...

This error disappears when I use<EMAIL_ADDRESS>

Happened to me on buildAuthenticatedRouter:
"@admin-bro/design-system": "^1.7.3",
"@admin-bro/express": "^3.1.0",
"@admin-bro/mongoose": "^1.1.0",
"@admin-bro/passwords": "^1.0.3",
"admin-bro": "^4.0.1",
"express-formidable": "^1.2.0",
"express-session": "^1.17.1",
"react": "^17.0.2",
"react-dom": "^17.0.2"
Using yarn as package manager.

Fixed by using same react/react-dom versions as in admin-bro dependencies:
"react": "=16.13.1",
"react-dom": "=16.13.1"

@yarikpwnzer Well I tried with the exact same version but it doesn't work either. It only works if I use<EMAIL_ADDRESS>

What is the difference between admin-bro-expressjs an @admin-bro/express ??

I was just playing with the packages (deleting and re-downloading them and changing their versions) and it just started working. Weird...
sorry for all of the comments

@kodesak I opened yarn.lock and checked versions of react/react-dom and what I noticed that there were two entries: one was added by me (17.0.2) and another was dependency of admin-bro (16.13.1). For it worked also without adding it to my dependencies, but since I'm using eslint I got errors in the code.

I am getting the same error. It works totally fine with local server but when I try to run in the Testing or Staging server it throws this error. I have referred all the solutions regarding this from https://reactjs.org/warnings/invalid-hook-call-warning.html. I think I have multiple react as shown in attached image but I am not able to figure out how can I correct the tree or solve it. Thanks in advance!

At this point, I am probably going to abandon this package because of this error that is stopping me every time...

I get this issue when i have React version ^17.0.2 in my dependencies. If i change it to adminjs version 16.13.1 the issue disappears. But then my Next.JS SSR stops working (monorepo). I need it to work with my main React dependency being of version ^17.0.2 somehow.
@dziraf Could you suggest a solution please?

Coming from the error message:
(node:20508) UnhandledPromiseRejectionWarning: Error: Invalid hook call. Hooks can only be called inside of the body of a function component. This could happen for one of the following reasons:
1. You might have mismatching versions of React and the renderer (such as React DOM)
2. You might be breaking the Rules of Hooks
3. You might have more than one copy of React in the same app
See https://reactjs.org/link/invalid-hook-call for tips about how to debug and fix this problem.
    at resolveDispatcher (C:\Users\maxim\WebstormProjects\portfolio\node_modules\react\cjs\react.development.js:1476:13)
    at Object.useState (C:\Users\maxim\WebstormProjects\portfolio\node_modules\react\cjs\react.development.js:1507:20)
    at ae (C:\Users\maxim\WebstormProjects\portfolio\node_modules\styled-components\src\utils\isStaticRules.js:6:54)
    at processChild (C:\Users\maxim\WebstormProjects\portfolio\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-server.node.development.js:3043:14)
    at resolve (C:\Users\maxim\WebstormProjects\portfolio\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-server.node.development.js:2960:5)
    at ReactDOMServerRenderer.render (C:\Users\maxim\WebstormProjects\portfolio\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-server.node.development.js:3435:22)
    at ReactDOMServerRenderer.read (C:\Users\maxim\WebstormProjects\portfolio\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-server.node.development.js:3373:29)
    at renderToString (C:\Users\maxim\WebstormProjects\portfolio\node_modules\adminjs\node_modules\react-dom\cjs\react-dom-server.node.development.js:3988:27)
    at html (C:\Users\maxim\WebstormProjects\portfolio\node_modules\adminjs\lib\frontend\login-template.js:73:53)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at C:\Users\maxim\WebstormProjects\portfolio\node_modules\@adminjs\express\src\authentication\login.handler.ts:27:19
    ```

    I think the first probable reason `1. You might have mismatching versions of React and the renderer (such as React DOM)` might be the case. Because from the stacktrace above, we see that `react-dom` is used from `node_modules\adminjs\node_modules\react-dom` directory (older version), but then `react` is used from `node_modules\react` directory (newer version, which is specified in package.json).
    That being said, it makes sense why lowering the `react` version in package.json fixes the issue. Yet i currently don't know why this behaviour appears and how to make it work like the rest of the app does. (Everything in adminjs works fine except the login page)

Ok so i just wrote "styled-components": "=4.4.1" in my package.json and it started working 😂.
From the third line of stacktrace at ae (C:\Users\maxim\WebstormProjects\portfolio\node_modules\styled-components\src\utils\isStaticRules.js:6:54) i saw that it also uses my newest styled-components package, then it goes to my latest react package. I use Yarn. I assume that it saw that my styled-components version and the one in adminjs are compatible (though not the same, i checked) so it linked it to share for adminjs. That somehowe caused the usage of another React version i described above.
Thats how i understand it, though it's kinda a bit crazy. I would be glad if someone can clear this up more.

To fix this issue, I switched to yarn and added this in my package.json.
"resolutions": {
    "adminjs/react": "17.0.2",
    "adminjs/react-dom": "17.0.2"
  },

I'm stucked in this issue. I'm working on a project on two pc. On the first it always have been worked and on my new pc i have this issue even if i have same package.json file with same versions on both pc, i don't understand why...

Fixed by using same react/react-dom versions as in admin-bro dependencies: "react": "=16.13.1", "react-dom": "=16.13.1"

This worked for me, after a whole day of trying to figure out the issue. Thanks a bunch

i ran into this issue again. was working fine until the latest update. however once i updated latest versions of adminjs @adminjs/express @adminjs/mongoose this error started coming. i resolved it by installing react and react-dom into my backend.

i ran into this issue again. was working fine until the latest update. however once i updated latest versions of adminjs @adminjs/express @adminjs/mongoose this error started coming. i resolved it by installing react and react-dom into my backend.

This worked for me just fine after many tries as it auto-updates all dependencies !

Issue is not fixed. After latest update, react needs to be manually installed so that adminjs can run.


Radial Line of Sight - Multiple Positions has no output parameter

Radial Line of Sight - Multiple Positions has no output parameter

Fixed.


Make CLI Commands more independent

Note: this PR is to the cli-refactor branch, not master.
What Changed

The commands in cli/ are more independent and self-actualizing

They export their own usage string
They parse their own command line options

cli.js is cleaned up

it only parses the options that it cares about
handles printing usage info for every command
exports the current version

I Need Help
I'm not sure how to implement the run command. This PR adds it as an unimplemented() piece of code.
We could merge this into the cli-refactor branch then fix the run command in there, or we can update this PR if someone can assist in implementing it.

Test it out here:
deno run --unstable -A https://raw.githubusercontent.com/JordanShurmer/lume/1872c101bd57a943908a5666daa6339da410cdb1/cli.js --help

deno run --unstable -A https://raw.githubusercontent.com/JordanShurmer/lume/1872c101bd57a943908a5666daa6339da410cdb1/cli.js build --help

# etc.

Test it out here:
deno run --unstable -A https://raw.githubusercontent.com/JordanShurmer/lume/1872c101bd57a943908a5666daa6339da410cdb1/cli.js --help

deno run --unstable -A https://raw.githubusercontent.com/JordanShurmer/lume/1872c101bd57a943908a5666daa6339da410cdb1/cli.js build --help

# etc.

Hi, thanks for your work here.
Both build and run need an instance of site. This is why in my implementation I've created the site before executing these two commands (See here).
Maybe cli.js can export a createSite(options) function that can be imported and used by those two commands (like you did with version).
Then, run only need to execute site.run() with the name of the script. For example: lume run deploy should execute site.run("deploy").
Another thing: can you run deno fmt on finish this pull request? I want to use the same code format of Deno (the only exception is CHANGELOG.md) that should be ignored.
Thanks!

Hi, thanks for your work here.
Both build and run need an instance of site. This is why in my implementation I've created the site before executing these two commands (See here).
Maybe cli.js can export a createSite(options) function that can be imported and used by those two commands (like you did with version).
Then, run only need to execute site.run() with the name of the script. For example: lume run deploy should execute site.run("deploy").
Another thing: can you run deno fmt on finish this pull request? I want to use the same code format of Deno (the only exception is CHANGELOG.md) that should be ignored.
Thanks!

Thanks. all, for reviewing.
Made various changes to address the feedback:

Implemented the run command

pulled the site building logic into a shared function in cliUtils.js

Refactored the way cli.js pulls in the commands to avoid doing dynamic import
Tried to clean up cli.js even more, let me know what you think
deno fmt

Thanks. all, for reviewing.
Made various changes to address the feedback:

Implemented the run command

pulled the site building logic into a shared function in cliUtils.js

Refactored the way cli.js pulls in the commands to avoid doing dynamic import
Tried to clean up cli.js even more, let me know what you think
deno fmt

Test out the latest here: https://raw.githubusercontent.com/JordanShurmer/lume/1336e460d3220489fcfa50060290612795652d9a/cli.js
deno run --unstable -A https://raw.githubusercontent.com/JordanShurmer/lume/1336e460d3220489fcfa50060290612795652d9a/cli.js --help

Test out the latest here: https://raw.githubusercontent.com/JordanShurmer/lume/1336e460d3220489fcfa50060290612795652d9a/cli.js
deno run --unstable -A https://raw.githubusercontent.com/JordanShurmer/lume/1336e460d3220489fcfa50060290612795652d9a/cli.js --help

Great job. Thank you @JordanShurmer

Great job. Thank you @JordanShurmer


Add Leagues to Hiscores and World Hopper

Closes: #10266

Also makes screenshots save to their own League folder

Why was this closed?

Why was this closed?

adam commited his version into master


Anyone testing on Android?

I've now spent so much time trying to make the android tests to pass and I'm still failing.
It turned out that if I run the emulator like in the orb:
/usr/local/share/android-sdk/emulator/emulator @<<parameters.device_name>> -skin 470x860 -cores 1 -gpu auto -accel on -memory 1024 -no-audio -no-snapshot -no-boot-anim -no-window -logcat *:W | grep -i 'ReactNative\|<<parameters.logcat_grep>>'

my test were not starting at all.
I had to change it to this:
/usr/local/share/android-sdk/emulator/emulator @<<parameters.device_name>> -gpu auto -accel on -no-audio -no-snapshot -no-boot-anim -no-window -logcat *:W | grep -i 'ReactNative\|<<parameters.logcat_grep>>'

I'm running detox in verbose mode and I can see that installing the app on the device takes ages. So I increased the default timeout of 120s to 360s and now tests are starting, but they always fail and not always at the same test.
On the other hand when I run the tests locally I have no issues whatsoever. They always pass.
Anyone got any experience to share with this?
The iOS emualtor runs the tests fine - they always pass.

Ok, after some time spent with this our tests seem to be running relatively fine.
The main reason for the problems is that circleCI is slow and that caused issues with our app. There is nothing inherently wrong with circleCI - if we run the tests on a slow machine we were getting the same results.
We had to disable/mock some activityIndicators in the app and increase the espresso setMasterPolicyTimeout and setIdlingResourceTimeout.


Translate "Type" is incorrect in Keyboard manager module

ℹ Computer information

PowerToys version: v0.25

📝 Provide detailed reproduction steps (if any)

Open settings
Choose Keyboard manager
Go to key define window

✔ Expected result
Button "define key/type" must be "Определить" (Define) instead "Type", because "Type" != "Тип"
❌ Actual result
Have a "Тип" (type as typeof) instead "Определить" (Define key by keyboard)
📷 Screenshots

@Aaron-Junker How did you send this issue to internal localization team?

@alannt777 the description of the label says it is for issues which want a change on localisation. I think it will be sent to the team.
/Cc help Crutkas

The label added after it has been sent to the team

@Aaron-Junker yes, that is a tag to let us know we did the follow up.

https://ceapex.visualstudio.com/CEINTL/_workitems/edit/334292

Great news!  This was resolved in the newly released 0.33 version of PowerToys!  Head to https://aka.ms/installpowertoys to grab latest.

This issue is back. Exactly the same translation problem, PowerToys version is 0.57.2

Lets please create a new issue versus open this issue. A regression happened and is a new issue.  Lets figure out why

@khalis  please use https://github.com/microsoft/PowerToys/issues/new?assignees=&labels=Issue-Bug%2CArea-Localization%2CIssue-Translation%2CNeeds-Triage&template=translation_issue.yml

@crutkas, here you are
https://github.com/microsoft/PowerToys/issues/17799


Unable to run test suite: "Error: Failed to launch chrome"

I've been working on submitting some PRs, but have been unable to run the test suite locally / been relying on PR CI builds. Any chance I could get a few pointers?
Running "connect:test" (connect) task
Started connect web server on http://<IP_ADDRESS>:9999

Running "mocha" task
Testing: http://localhost:9999/test/test.main1.html

Error: Failed to launch chrome! spawn /Users/lincoln/projects/maritlabs/libraries/localForage/node_modules/puppeteer/.local-chromium/linux-686378/chrome-linux/chrome ENOENT

TROUBLESHOOTING: https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md

I'm looking at redoing the test runners to use karma so we can run the tests in real browsers (my work in in #906), so it might be best to wait until then. Not a great answer, I know, but the test infrastructure is pretty old and unloved right now, so debugging it is tough 😓 . Really sorry about that.
I'll leave this open in case anyone can help, but this should be closed by #906.


Update Composer dependencies (2022-04-30-00-04)

Visual regression test passed!
View the visual regression test report


STYLE: No longer specify Fixed/Moving ImageDimension parameters in GTest

It appears unnecessary to specify "FixedImageDimension" and "MovingImageDimension" to itkElastixRegistrationMethodand ElastixFilter. As was mentioned during the internal weekly Elastix project sprint.

@mstaring @stefanklein FYI!


NavBarHasShadow default is wrong

The "Enable navigation bar shadow" section states that the default value of the NavBarHasShadow property is false. But this is wrong, the default is true.
When I don't set this property my pages have a drop shadow on the nav bar. When I set it to false they don't have that shadow.
Xamarin Forms v<IP_ADDRESS>6

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c9d653fd-51ed-ed03-db65-a9efb684dc12
Version Independent ID: 06470094-10f9-b28e-4ece-4da457a4a609
Content: Xamarin.Forms Shell Page Configuration - Xamarin
Content Source: docs/xamarin-forms/app-fundamentals/shell/configuration.md
Product: xamarin
Technology: xamarin-forms
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @irongut
The NavBarHasShadow bindable property has a default value of false:
		public static readonly BindableProperty NavBarHasShadowProperty =
			BindableProperty.CreateAttached("NavBarHasShadow", typeof(bool), typeof(Shell), default(bool),

However, something else might be going on here. I'll speak to one of the engineers.

If it helps you can see the app I was working on here:  irongut/XF40Demo
The page in question is: StandingsPage.xaml
This page has a nav bar shadow unless I set: Shell.NavBarHasShadow="False"

Hi @irongut
It turns out that by default the property is false on iOS, but true on Android. I've updated the doc in a PR that will go live soon.


[Benchmarks][Upstream PyTorch 2.5] Triton and XeTLA softmax performance degrades in comparison with  torch 2.1 / ipex 2.1 test proxies

Ratio of Triton/ XeTLA keep same except for attention caused by XeTLA attention absolute number degraded
Both Triton and XeTLA softmax cases degraded, so Triton/ XeTLA not changed.

details: https://github.com/intel/intel-xpu-backend-for-triton/pull/1905#issuecomment-2320701513

@ESI-SYD what is the root cause for this issue? can you pin point it to a particular torch operation?
To proceed further with analysis / triaging please create a minimal reproducer for the Triton kernel path.

@ESI-SYD what is the root cause for this issue? can you pin point it to a particular torch operation?

There are two main differences in benchmark time method change after applying the Draft

No sync submitting.  https://github.com/intel/intel-xpu-backend-for-triton/blob/llvm-target/python/triton/testing.py#L214

Use the time stamp between two barriers which is not accurate. Previous detailed explanation by chengjun.

https://github.com/intel/intel-xpu-backend-for-triton/pull/2149#issuecomment-2337632244

Ratio of Triton/ XeTLA keep same except for attention caused by XeTLA attention absolute number degraded

At the moment, the degradation of absolute numbers has been fixed. The geometric mean difference is ~2% (between #1 and #2), which can be considered within the margin of error, I believe.


Resuming a looped Sound after it has been paused no longer loops

A bug in the API:
Phaser v2.8.3

When I play a sound and set it to loop, it plays and loops just fine. But then when I call pause() on it and then resume(), the sound pauses and resumes as expected. However the sound no longer loops.

For me, the sound doesn't loop at all unless I set looped before calling play (or use loopFull instead): https://codepen.io/samme/pen/ZJeNbd
But once it's looping, it keeps looping correctly through pause/resume.

@NeoHoffa Could you maybe provide an example and/or tell us which browser this happened in for you? Samme's example worked for me in current Chrome, Firefox and IE11.

Is this in IE? Sound doesn't loop in Internet Explorer


Resource manager tab & Collaboratory embedding

also see https://wiki.ebrains.eu/bin/view/Apps/Neuromorphic Computing Job Manager

Just few comments as a reminder (not directly related to this pull request) that may be the subject of new issues for future versions of the app:

It will be necessary to think about handling the case where the user does not select a collab (either in the event of forgetting, or in the event of filtering jobs coming from several collabs).
now, because the choice of the collab is managed on the first page (Job List), if for any reason the user refresh the page directly on his browser, he will have the error message 404 Not Found. We could think of a solution to avoid any disappointment of the user.
perhaps a more explicit button for the creation of job as in collab1 in addition to the 'plus' symbol.

@msenoville please can you create separate issues for these? Otherwise they will get lost/forgotten. The first two points are linked, I suggest we handle collab selection in the App menu bar, so the collab can be changed on any page. A more explicit job creation button is a good idea, please create a separate ticket for it.


Anchor element's ID remain disappeared in rare cases.

We found a bug in asynchronous processing.
That bug causes anchor element's ID remain disappeared in rare cases.
function DOMLoaded(){
  new SmoothScroll("a");
  document.getElementById("fooLink").click();
  document.getElementById("barLink").click();
}

  goto foo

  goto bar

fooArea

barArea

Looks good. Will test soon and merge. Thanks!

v14.x, currently in testing and awaiting deployment, fixes this issue.


Feature: Expose heap dump api internally on port other than 80 / 443 and remove authentication for orchestrator

🔖 Feature description
Expose heap dump api internally on port other than 80 / 443 and remove authentication for the same for orchestrator
🎤 Pitch / Usecases
As of now heap dump api requires super admin token, the use-case is to be able to take heap dump without generating super admin token.
current api to take heap dump :
curl -H 'token: <apiToken>' https://<orchestrator_service_url.devtroncd>/orchestrator/debug/pprof/heap
requirement is something like below :
curl https://<orchestrator_service_url.devtroncd>:<some_port>/orchestrator/debug/pprof/heap
🔄 Alternative
NA
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#8360

We won't be removing authentication from endpoint (Please discuss before picking)
Different port is required or not is purely tech call

Not critical anymore as per discussion with @tayalrishabh96 @nishant-d

We can take heap dumps for microservices other than orchestrator using proxy but authentication is not removed yet.
No plans for the same.


Added angular resource to the README file

Added angular resource
Here is the link

Thank you for your PR.


Hook up CWL auto-generated classes to client

Initially, this is used to understand CWL to produce run json parameter files.
This relies on cwltool to convert CWL to pseudo-Avro json and then uses gson to convert to Avro's auto-generated Java objects (since using Avro directly is problematic due to some problems with CWL conventions having to do with Avro namespaces and union(?) types).
Later, this can be used for any code that needs to understand CWL.

Going to reformat maven modules


Regression for "register_extra_tool_type"

Looks like #2 introduced a new bug:
2020-08-07 06:17:06: ACTION[Main]: Server: Shutting down
2020-08-07 06:17:06: ERROR[Main]: ModError: Failed to load and run script from /var/lib/minetest/.minetest/worlds/world/worldmods/multitools/init.lua:
2020-08-07 06:17:06: ERROR[Main]: ....minetest/worlds/world/worldmods/multitools/init.lua:7: attempt to call field 'register_extra_tool_type' (a nil value)
2020-08-07 06:17:06: ERROR[Main]: stack traceback:
2020-08-07 06:17:06: ERROR[Main]: 	....minetest/worlds/world/worldmods/multitools/init.lua:7: in main chunk

@louisroyer (sorry to bother you :smile: )
Downstream: https://github.com/pandorabox-io/pandorabox-mods/pull/927

The PR on the multitools repo which would add this function was closed: https://github.com/lisacvuk/minetest-toolranks/pull/11.
@BuckarooBanzay workaround for now:
 multitools = {}

-if use_toolranks then
+if false and use_toolranks then
     toolranks.register_extra_tool_type("multitool", S("multitool"))
 end

i guess this will end up in a fork-hell... yay

I don't want to maintain a fork. I guess, I will add a feature to my toolranks-extras mod witch extends toolranks capabilities instead. For the moment, you can use rusty-snake's workaround (this will prints Tool level x instead of Multitool level x, but this is better than a crash) , and I will do an other PR when my API is ready.

this isn't fixed on contentdb, can you please update this mod there?

Boy it's been a few years, let me know if I messed it up haha

lgtm


Weex code in same branch as main vue code

What problem does this feature solve?
Weex related code should be added over into the core repo. This would allow better readability
What does the proposed API look like?
vue/weex-vuejs
vue/vuejs

It already is, in src/platforms/weex.

Other files have some references to weex. Also is there a high level diagram i can read to understand the framework. Interested to contribute

From: Evan You<EMAIL_ADDRESS>Sent: Friday, August 25, 2017 1:44:17 AM
To: vuejs/vue
Cc: Sharma, Rahul; Author
Subject: Re: [vuejs/vue] Weex code in same branch as main vue code (#6445)
Closed #6445https://github.com/vuejs/vue/issues/6445.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/vuejs/vue/issues/6445#event-1220420859, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATntFIA31fG46JClIgaJqlHBTvLCaVCNks5sbdmZgaJpZM4PBt82.

See https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#project-structure


Run evaluation in a separate process when using HTTP API

Fixes #1733
Proposed changes:

Check if the router has any idle processes, if so run rasa_nlu.test in that thread using the model path and return the results

Status (please check what you already did):

[x] made PR ready for code review
[x] added some tests for the functionality
- [ ] updated the documentation
[x] updated the changelog

Agreed that it's a better term


fix: Use valid package name in package.json and prevent publishing

In 3.16 we started generating package.json independently of output
location. Turns out some users pnpm/yarn glob patterns match those
location, so generated client becomes a part of their workspace and
then package manager will complain about invalid package name.
Even though proper fix for users would've been excluding generated
folder from their workspaces, there is no real harm in it: client has no
dependencies, so having it as a part of workspace should not affect
anything. So, we can just use valid package name for generated
package.json and silence the error.
Additionally, we add "private": "true" to the package.json in custom
location to prevent publishing of the generated client in case users use
something like publish -r in their workflows. We can't set it for
default location since some users might want to publish package from
there. We did not generate package.json in custom location before, so
private: true won't be breaking there.
Fix #13893

Should we also check that we are not overwriting the package.json of @prisma/client to avoid problems like this?

Closing this for now as the problem is more complicated. Just the valid package name will mask the issue, but cause bunch of other more subtle problems if generated package is a part of workspace.


ios 10.2.1 no notification callback at all

Entitlement fixed
build checked /fixed in xcode (development / production on debug / release switch would be nice)
app certificate has notification entitlement
token id is not null, added retries code just in case it ever is null
GoogleService-Info.plist correctly in build
server push returns a sent message ID for the device.
IOS notification permission granted in settings and app section, also added background push just to be safe.
tried multiple ways to fix this

I never receive onNotificationOpen on iOS (foreground or background), works fine on android
it does connect and return a seemingly valid token
NSLog(@"Connected to FCM.");
debugging shows a debug call that after the page / iframe is loaded all plugins are reset
if the app goes to the background it NSLog(@"Disconnected from FCM");
both apn p12 files were uploaded to the firebase backend, both development as well as production seem to be non-functional.
I am at a loss as how to further debug / diagnose / fix this issue.
Any help would be greatly appreciated.

(function () {
    "use strict";

    var gotoUrl = "https://login page of site";

    document.addEventListener('deviceready', onDeviceReady.bind(this), false);

    var interval;

    //called when app is started (once, while app is in memory)
    function onDeviceReady() {
        //console.log("screen on");
        //window.LaunchScreen.hide();

        // Create the resume as soon as the device is ready.
        //document.addEventListener("resume", onResume, false);
        checkPermission();

        var tries = 10;
        interval = setInterval(function () {
            console.log("attempts left: " + tries);
            if (--tries < 0) {
                console.log("failed to get token");
                loadPage(null);
                clearInterval(interval);
            }
            getToken();
        }, 500);

        tokenRefresh();

        getNotification();
    };

    function onResume() {
        console.log("on Resume");
        //Called when resumed from background
        // or after notification is tapped (needed for Android)
        getNotification();
    }

    function checkPermission() {
        console.log("check permission");
        if (device.platform == 'iOS') {
            window.FirebasePlugin.hasPermission(function (data) {
                if (!data.isEnabled) {
                    window.FirebasePlugin.grantPermission();
                }
            }, function (error) {
                console.log("could not check notification permission, " + error);
            });
        }
    }

    function getNotification() {
        console.log("check notification");
        try {
            window.FirebasePlugin.onNotificationOpen(
                function (notification) {
                    var str = JSON.stringify(notification);
                    console.log("Notification:\n" + str);
                },
                function (error) {
                    console.error(error);
                }
            );
        }
        catch (e) {
            alert(e);
        }
    }

    function getToken() {
        console.log("get token");
        try {
            window.FirebasePlugin.getToken(function (token) {
                if (token !== null && token !== '') {
                    // save this server-side and use it to push notifications to this device
                    console.log(token);
                    loadPage(token);
                    //
                    clearInterval(interval);
                }
            }, function (error) {
                console.error(error);
            });
        }
        catch (e) {
            alert(e);
        }
    }

    function tokenRefresh() {
        console.log("register for token refresh");
        window.FirebasePlugin.onTokenRefresh(
            function (token) {
                if (token !== null && token !== '') {
                    clearInterval(interval);
                }
                // save this server-side and use it to push notifications to this device
                console.log("refresh: " + token);
                loadPage(token);
            },
            function (error) {
                console.error(error);
            }
        );
    }

    var knownToken = 'empty';

    function loadPage(id) {
        //skip already sent token
        if (id === knownToken)
            return;
        //skip remembering empty token
        if(id !== null && id !== '')
            knownToken = id;

        $.ajax({
            url: "https://proshare.audio",
            context: document.body,
            success: function (data) {
                var iframe = document.getElementById('main_iframe');
                var iframeDoc = iframe.contentDocument || (iframe.contentWindow ? iframe.contentWindow.document : null);
                var submitMe = iframeDoc.createElement("form");
                submitMe.action = gotoUrl;
                submitMe.method = "post";
                submitMe.enctype = "multipart/form-data";
                submitMe.innerHTML = '<input type="hidden" name="platform" value="' + device.platform + '" />';
                if (id != null)
                    submitMe.innerHTML += '<input type="hidden" name="token" value="' + id + '" />';

                iframeDoc.body.appendChild(submitMe);
                //hack to wipe offline.html from history
                iframe.contentWindow.history.replaceState({}, null, gotoUrl);

                submitMe.submit();

                setTimeout(function () { console.log('page loaded'); getToken(); }, 5000);
            },
            error: function (jqXHR, exception) {
                //callback getMyJson here in 5 seconds
                setTimeout(function () {
                    loadPage(id);
                }, 5000);
            }
        });
    };
})();

solved, appearantly it takes a while for the p12 files uploaded to become active, because an older version suddenly started working.
No major code changes were added, so I guess this was just a console issue.
Suggested fix: upload p12 files, wait 24 hours, debug using the cordova console. When that works switch over to server implementation.


Decoding errors

What appears to be escaped hexadecimals and other types (e.g. \xAA, \xa0, \x,, \700 etc.) contained in the description of vulnerability objects results in those vulnerabilities not being decoded successfully by utils.decompress_str.  At present, this results in a fatal exception querying vdb directly while in depscan, there is no indication that this has occurred at all.
This issue is present on both Linux and Windows. @prabhu I believe this is could be the cause of somebody reporting missing OS results in depscan.
I experimented with the builtin python codec error handlers and had success with fixing the escaped hexadecimals. \x had to just be replaced before converting to bytes. There will likely be some other replacements required - for example, one entry included a \700 and I have no idea what that is since octal escapes don't go up that high.
I am unsure how extensive the issue is in terms of number of vulnerability objects affected. Regardless, it makes most sense to address these problem characters up front when the database is being built or synced rather than cleaning them up after the fact every time the db is queried (although it makes sense to do some error handling on that end too). This could potentially improve the db size as well.
Some examples of packages this affects - py-evm, httplib2, tensorflow, cryptography, oniguruma, xfree86, detect-character-encoding,

@cerrussell Great finding! Yes, the description field is known to be problematic. In the past, methods such as fix_text were added to clean up.
https://github.com/AppThreat/vulnerability-db/blob/master/vdb/lib/utils.py#L897


Users whiteload structure fix

add a default value to the users upload whitelist table and fix the out of sync structure.sql file. Not sure we need to have the NOT NULL clause anymore since it won't affect the code but happy to add another  migration PR if needed.
Need to rerun the rake task after this is deployed.

I say we add the NOT NULL back. I took it and the default out so we could deploy without locking the table for too long. I'll double check that I ran that rake task on production, will merge this afterwards.

I already ran that rake task yesterday afternoon, hence i added the where clause into the rake task.

i'll add the not null constraint back in after this goes out with new users getting a default and re-rerun the rake task for the gap from yesterday...sound ok?


cookiecutter: move python 3.7 and 3.8 to beta

Coverage remained the same at 0.0% when pulling fb8a1676fa2d3fda0d8145f5879ae3025d2f21d6 on ppanero:fix into 1e5ecfb16489cf34a1cf4b65089c286c2eba2f7c on inveniosoftware:master.


Please send the associated .miz file, the system works well on my end.

Operation Iron Curtain.zip


Login does not redirect - docker

Describe the bug
Once logged in using the latest version available on docker, the user is not redirected to the package list. The same happens when the user  tries to logout. Both approaches require a page refresh (F5) for the redirection to work.
To Reproduce

Steps to reproduce the behavior:

Make sure to have docker installed, I used the macos version.
pull the image with the command (docker pull verdaccio/verdaccio)
start a new container:

V_PATH=/path/for/verdaccio; docker run -it --rm --name verdaccio \
  -p 4873:4873 \
  -v $V_PATH/conf:/verdaccio/conf \
  -v $V_PATH/storage:/verdaccio/storage \
  -v $V_PATH/plugins:/verdaccio/plugins \
  verdaccio/verdaccio

Add a new user through the command npm adduser --registry http://<IP_ADDRESS>:4873 - and fill in the required fields
Open a new tab on your browser and access the web app - http://<IP_ADDRESS>:4873
Use the credentials from the step 4 to login in the web app

Expected behavior
The user should be redirected to the package list, once the login has been made.
Docker || Kubernetes (please complete the following information):

Docker verdaccio tag: none
Docker commands:

docker pull verdaccio/verdaccio) &&
V_PATH=/path/for/verdaccio; docker run -it --rm --name verdaccio \
  -p 4873:4873 \
  -v $V_PATH/conf:/verdaccio/conf \
  -v $V_PATH/storage:/verdaccio/storage \
  -v $V_PATH/plugins:/verdaccio/plugins \
  verdaccio/verdaccio

Docker Version: <IP_ADDRESS> (41561) edge - Engine: 19.03.5

Configuration File (cat ~/.config/verdaccio/config.yaml)
storage: ../storage
max_users: -1
auth:
  htpasswd:
    file: ./htpasswd
uplinks:
  npmjs:
    url: https://registry.npmjs.org/
packages:
  '@*/*':
    access: $authenticated
    publish: $authenticated
    proxy: npmjs
  '**':
    access: $authenticated
    publish: $authenticated
    proxy: npmjs
logs:
  - {type: stdout, format: pretty, level: http}
web:
  enable: true
  title: Verdaccio
  primary_color: "#4b5e40"
  scope: "*"
  sort_packages: asc | desc

Environment information
Docker command executed: docker exec -it verdaccio bin/verdaccio --info
Environment Info:

  System:
    OS: Linux 4.19 Alpine Linux
    CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
  Binaries:
    Node: 12.13.1 - /usr/local/bin/node
    Yarn: 1.19.1 - /usr/local/bin/yarn
    npm: 6.12.1 - /usr/local/bin/npm

The user should be redirected to the package list, once the login has been made.

Sorry, I cannot reproduce this, you don't indicate whether there is any package already publish. Anyway, I did some publish and then packages are refreshed correctly with the latest tag.


Enable windows build

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

you can start from here @edisongustavo

@edisongustavo I applied your changes here, and I updated the bld.bat to build bindings too.

Nice.

@edisongustavo could you test my branch ?

@edisongustavo could you test my branch ?

Sure.

CGAL only
Compiling the branch I got these errors:
W:\Miniconda\conda-bld\recipe_1481627996245\work\CGAL-4.9\include\CGAL/GMP/Gmpzf_type.h(403): error C2664: 'double __gmpz_get_d_2exp(mpir_si *,mpz_srcptr)': cannot convert argument 1 from 'CGAL::Gmpzf::Exponent *' to 'mpir_si *'
W:\Miniconda\conda-bld\recipe_1481627996245\work\CGAL-4.9\include\CGAL/GMP/Gmpzf_type.h(403): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
W:\Miniconda\conda-bld\recipe_1481627996245\work\CGAL-4.9\include\CGAL/GMP/Gmpzf_type.h(414): error C2664: 'double __gmpz_get_d_2exp(mpir_si *,mpz_srcptr)': cannot convert argument 1 from 'CGAL::Gmpzf::Exponent *' to 'mpir_si *'
W:\Miniconda\conda-bld\recipe_1481627996245\work\CGAL-4.9\include\CGAL/GMP/Gmpzf_type.h(414): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast
W:\Miniconda\conda-bld\recipe_1481627996245\work\CGAL-4.9\include\CGAL/GMP/Gmpzf_type.h(425): error C2664: 'double __gmpz_get_d_2exp(mpir_si *,mpz_srcptr)': cannot convert argument 1 from 'CGAL::Gmpzf::Exponent *' to 'mpir_si *'
W:\Miniconda\conda-bld\recipe_1481627996245\work\CGAL-4.9\include\CGAL/GMP/Gmpzf_type.h(425): note: Types pointed to are unrelated; conversion requires reinterpret_cast, C-style cast or function-style cast

This is due to the typedef mp_exp_t Exponent.
So I believe I got confused with my first patch. The typedef should read like:
typedef mp_si Exponent
cgal-swig-bindings
bld.bat
After fixing that locally I tried to recompile. The build then stopped with:
(W:\Miniconda\conda-bld\recipe_1481628871708\_b_env) W:\Miniconda\conda-bld\recipe_1481628871708\work\CGAL-4.9\build\cgal-swig-bindings>cmake --build . --config "Release" --target INSTALL
Error: could not load cache

So to fix it I added a cd .. just after the cgal compilation, before the bindings.
My guess is that on windows, cmake does not support having inner directories with other cmake files. I believe I saw something like that in the past.
I also created a build directory inside the cgal-swig-bindings:
mkdir build
cd build

compilation
First I got this linking error:
[ 32%] Linking CXX shared module ..\..\build-python\CGAL\_CGAL_Kernel.pyd
LINK : fatal error LNK1104: cannot open file 'python27_d.lib'

Whis is bizarre, why would it want to link against pyhon in debug?
I tried to solve it by passing CMAKE_BUILD_TYPE=%CMAKE_CONFIG% at the cmake command line but I wasn't successful.
I also noticed that it said "Installing configuration Debug", so I think that nmake is getting confused somehow.
As an alternative, I used the ninja package, which works quite well. We (at my company) use it internally and it is great. I know that Google uses it to build chromium too.
However, I ran into these compilation problems:
CGAL_Advancing_front_surface_reconstructionPYTHON_wrap.cxx
W:\Miniconda\conda-bld\recipe_1481630561811\work\CGAL-4.9\cgal-swig-bindings\build\build-python\CGAL\CGAL_Advancing_front_surface_reconstructionPYTHON_wrap.cxx : fatal error C1083: Cannot open compiler generated file: '': Invalid argument

I found this link regarding this error and tried compiling with ninja -j1. It took forever and didn't solve the problem.
CGAL_Box_intersection_dPYTHON_wrap.cxx
build-python\CGAL\CGAL_Box_intersection_dPYTHON_wrap.cxx(3755): error C2976: 'std::vector': too few template arguments

Here you can see (at line 3755) that there is an usage of std::vector before the proper #include.

do you have logs ? for example the cmake output of the first issue

do you have logs ? for example the cmake output of the first issue

You mean the "Error: could not load cache" right?
I removed your cd .. commit and this is what happens: https://gist.github.com/edisongustavo/f6c90ca65007771b5ef29c0c3d454216

thanks, I see it builds in debug mode, I added CMAKE_BUILD_TYPE=Release.

Hi, this is the current log of the build after your last commits (cd build): https://gist.github.com/edisongustavo/082a24f2c2b273968be773eda3983977

ok see https://github.com/CGAL/cgal-swig-bindings/pull/80

@edisongustavo could you retry with my latest commit ?

Hi, I tried with the latest commit and still got the W:\Miniconda\conda-bld\recipe_1481630561811\work\CGAL-4.9\cgal-swig-bindings\build\build-python\CGAL\CGAL_Advancing_front_surface_reconstructionPYTHON_wrap.cxx : fatal error C1083: Cannot open compiler generated file: '': Invalid argument error.
See: https://gist.github.com/edisongustavo/690e1874d563f7a7f3952c9216b38f08

could you try to build bindings in-source (without a build directory) ?

could you try to build bindings in-source (without a build directory) ?

Done just that and the same error happens again:
W:\Miniconda\conda-bld\._1481651417353\work\CGAL-4.9\cgal-swig-bindings\build-python\CGAL\CGAL_Advancing_front_surface_reconstructionPYTHON_wrap.cxx : fatal error C1083: Cannot open compiler generated file: '': Invalid argument
NMAKE : fatal error U1077: 'C:\PROGRA~2\MICROS~3.0\VC\bin\amd64\cl.exe' : return code '0x1'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.

I'm compiling now using the Visual Studio generator

nice catch. maybe clone in the parent dir and with a shorter clone dir name: ie "git clone url dir"

So I did a small "hack" so that this path limitation can be avoided. See this gist

what's that some kind of symlink ?

what's that some kind of symlink ?

Close...It's a "virtual drive". It's one of the strategies that I use to avoid this path limitation when compiling libraries. We use that all the time in our CIs.

maybe we could also try to clone the bindings in SRC_DIR and with a shorter name

and then, do the ctest pass ?

Not yet...there is something wrong with the compilation. I have to check.
W:\workspace\guga-etk-compile-sci20-py3\cgal-feedstock\recipe>W:\Miniconda\conda-bld\._1481656501206\_b_env\python.exe
Python 3.5.2 |Continuum Analytics, Inc.| (default, Jul  5 2016, 11:41:13) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import CGAL
>>> from CGAL.CGAL_Kernel import Point_2
Traceback (most recent call last):
  File "W:\Miniconda\conda-bld\._1481656501206\_b_env\lib\site-packages\CGAL\CGAL_Kernel.py", line 18, in swig_import_helper
    return importlib.import_module(mname)
  File "W:\Miniconda\conda-bld\._1481656501206\_b_env\lib\importlib\__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 986, in _gcd_import
  File "<frozen importlib._bootstrap>", line 969, in _find_and_load
  File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 666, in _load_unlocked
  File "<frozen importlib._bootstrap>", line 577, in module_from_spec
  File "<frozen importlib._bootstrap_external>", line 906, in create_module
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
ImportError: Module use of python27.dll conflicts with this version of Python.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "W:\Miniconda\conda-bld\._1481656501206\_b_env\lib\site-packages\CGAL\CGAL_Kernel.py", line 21, in <module>
    _CGAL_Kernel = swig_import_helper()
  File "W:\Miniconda\conda-bld\._1481656501206\_b_env\lib\site-packages\CGAL\CGAL_Kernel.py", line 20, in swig_import_helper
    return importlib.import_module('_CGAL_Kernel')
  File "W:\Miniconda\conda-bld\._1481656501206\_b_env\lib\importlib\__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
ImportError: No module named '_CGAL_Kernel'

yes, you have a python 3.5 interpreter, if the module is linked with python27.dll this is bad, at the cmake stage with one is detected ?

Yes, you are correct. The problem happened because I have a Miniconda 2 installation, but I'm building a Python 3 build.
This shouldn't be a problem, however, there is a small problem in the CMakeLists.txt of cgal-swig-bindings: https://github.com/CGAL/cgal-swig-bindings/blob/master/CMakeLists.txt#L67
The calls should be switched, you should always call find_package(PythonInterp) before find_package(PythonLibs), docs of cmake saying this.
So I switched those lines and it linked correctly.

ok, https://github.com/CGAL/cgal-swig-bindings/pull/82

So I finally could compile it correctly. This is the output of ctest:
Test project Z:/cgal-swig-bindings/build
      Start  1: pythontest_AABB_polyhedron_facet_intersection_example
 1/28 Test  #1: pythontest_AABB_polyhedron_facet_intersection_example ...   Passed    1.03 sec
      Start  2: pythontest_AABB_triangle_3_example
 2/28 Test  #2: pythontest_AABB_triangle_3_example ......................   Passed    0.07 sec
      Start  3: pythontest_Point_set_processing_3_test
 3/28 Test  #3: pythontest_Point_set_processing_3_test ..................   Passed    0.37 sec
      Start  4: pythontest_Polyhedron_incremental_builder
 4/28 Test  #4: pythontest_Polyhedron_incremental_builder ...............   Passed    0.06 sec
      Start  5: pythontest_advancing_front_reconstruction
 5/28 Test  #5: pythontest_advancing_front_reconstruction ...............   Passed    0.07 sec
      Start  6: pythontest_conforming
 6/28 Test  #6: pythontest_conforming ...................................   Passed    0.15 sec
      Start  7: pythontest_hds_incremental_builder
 7/28 Test  #7: pythontest_hds_incremental_builder ......................   Passed    0.07 sec
      Start  8: pythontest_hds_prog_halfedge_iterator
 8/28 Test  #8: pythontest_hds_prog_halfedge_iterator ...................   Passed    0.06 sec
      Start  9: pythontest_mesh_global
 9/28 Test  #9: pythontest_mesh_global ..................................   Passed    0.08 sec
      Start 10: pythontest_mesh_polyhedral_domain
10/28 Test #10: pythontest_mesh_polyhedral_domain .......................   Passed   16.19 sec
      Start 11: pythontest_polyhedron_modifier_example
11/28 Test #11: pythontest_polyhedron_modifier_example ..................   Passed    0.06 sec
      Start 12: pythontest_polyhedron_prog_cube
12/28 Test #12: pythontest_polyhedron_prog_cube .........................   Passed    0.06 sec
      Start 13: pythontest_regular_3
13/28 Test #13: pythontest_regular_3 ....................................   Passed    0.13 sec
      Start 14: pythontest_remove_outliers_example
14/28 Test #14: pythontest_remove_outliers_example ......................   Passed    0.08 sec
      Start 15: pythontest_simple_triangulation_3
15/28 Test #15: pythontest_simple_triangulation_3 .......................   Passed    0.07 sec
      Start 16: pythontest_test
16/28 Test #16: pythontest_test .........................................   Passed    0.07 sec
      Start 17: pythontest_test_aabb
17/28 Test #17: pythontest_test_aabb ....................................   Passed    0.07 sec
      Start 18: pythontest_test_as2
18/28 Test #18: pythontest_test_as2 .....................................   Passed    0.09 sec
      Start 19: pythontest_test_box_intersection_d
19/28 Test #19: pythontest_test_box_intersection_d ......................   Passed    0.07 sec
      Start 20: pythontest_test_convex_hull_2
20/28 Test #20: pythontest_test_convex_hull_2 ...........................   Passed    0.07 sec
      Start 21: pythontest_test_operators
21/28 Test #21: pythontest_test_operators ...............................   Passed    0.06 sec
      Start 22: pythontest_test_pmp
22/28 Test #22: pythontest_test_pmp .....................................   Passed    0.13 sec
      Start 23: pythontest_test_polyline_simplification_2
23/28 Test #23: pythontest_test_polyline_simplification_2 ...............***Failed    0.09 sec
TypeError: 'PS2_Constrained_Delaunay_triangulation_plus_2' object is not iterable

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "Z:/cgal-swig-bindings/examples/python/test_polyline_simplification_2.py", line 53, in <module>
    CGAL_Polyline_simplification_2.simplify(cdt, cid1, Squared_distance_cost(), Stop_below_count_ratio_threshold(0.5)) #simplify only
SystemError: <built-in function simplify> returned a result with an error set

      Start 24: pythontest_test_rt2
24/28 Test #24: pythontest_test_rt2 .....................................   Passed    0.25 sec
      Start 25: pythontest_test_sp
25/28 Test #25: pythontest_test_sp ......................................   Passed    0.08 sec
      Start 26: pythontest_test_t2
26/28 Test #26: pythontest_test_t2 ......................................   Passed    0.07 sec
      Start 27: pythontest_triangulation_prog1
27/28 Test #27: pythontest_triangulation_prog1 ..........................   Passed    0.07 sec
      Start 28: pythontest_vd_2_point_location
28/28 Test #28: pythontest_vd_2_point_location ..........................   Passed    0.09 sec

this is expected, this test also fails on the linux side, see https://github.com/CGAL/cgal-swig-bindings/issues/77

@conda-forge/core appveyor seems stuck, could you cancel the jobs queue ?

I am looking into this now. It seems that only staged-recipes is building :unamused:

@edisongustavo appveyor builds are ok on my fork now: I used a shorter path rather than your hack, and I disabled py27 builds

@xantares Great, I'm looking forward to it!

I disabled py27 builds

Is python 2 not supported by cgal-swig-bindings ?

more precisely building with visual studio 9 is not supported

see https://ci.appveyor.com/project/xantares/cgal-feedstock/build/1.0.1/job/x2iwji05dgmd7p25


Additional improvements to documentation for Storefront Api Clients troubleshooting section

WHY are these changes introduced?
Because https://github.com/Shopify/shopify-app-js/pull/1651 got merged early

WHAT is this pull request doing?
variable renaming + added documentation

Type of change

[ ] Patch: Bug (non-breaking change which fixes an issue)
[ ] Minor: New feature (non-breaking change which adds functionality)
[ ] Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

[ ] I have used pnpm changeset to create a draft changelog entry (do NOT update the CHANGELOG.md files manually)
[ ] I have added/updated tests for this change
[ ] I have documented new APIs/updated the documentation for modified APIs (for public APIs)

Skip Changelog -> it's only a documentation change
Skip Markdown Link Check -> due to test flakyness from external issues


Paper/Explanation of algorithm used

I'd like to integrate segmentation into an app I wrote. As far as I know, it's not possible to run Lisp on Android.
Is there some kind of documentation that explains how the segmentation works? Even if it takes more time, I'd like to port it over to Kotlin.

There's a blog post about the segmentation algorithm, but the secret sauce is really the scoring algorithm, which was built in an ad-hoc manner over the years to split sentences as well as possible. The reference implementation (which is Ichiran) is perhaps the only possible way to describe it.

Yes, this is the suite, it's not particularly thorough, I was mostly including corner cases for the segmentations I wanted to fix.
https://github.com/tshatrov/ichiran/blob/master/tests.lisp

I'm actually surprised no one has explored these pure-dictionary segmenters more, since they seem much simpler to implement, have 0 training cost, much higher quality output, and more predictable behavior than the CRF trained ones.

I guess the drawback is that you have to manually add a lot of scoring costs for edge cases or exceptions in grammar or otherwise. I do agree that I get more quality output from ichiran than any other system I have tried!

Would a hybrid approach work? Maybe create a NER model who's only task is to derive entities. And use that as some form of input hint to ichiran.


web.config for nodejs app on app service

Hello docs-team,
while trying to setup nodejs on azure appservice I got the error mentioned in the docs: "You do not have permission to view this directory or page."
There is note to inspect the logs and this did not help.
Adding a web.config did.
Please add a section so that others find what to do. Also please provide a link to a description to what this file is about and what the contents should be.
Thank you,
Daniel

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 298b87f4-b6eb-5642-7ab5-cd6df709390d
Version Independent ID: 0518cce4-7677-6d63-979d-e0a9e532efc0
Content: Quickstart: Create a Node.js web app - Azure App Service
Content Source: articles/app-service/quickstart-nodejs.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@daniel-seitz, I went through the tutorial and couldn't reproduce your issue. In fact, upon deploying the app from Visual Studio Code, WEBSITE_NODE_DEFAULT_VERSION was already there and I did not need to add it. I created a Windows plan.
I'm going close this issue as I couldn't reproduce it; however, I have pasted what version my app service was deployed to. Feel free to reopen and tag me if your version is different. I think your issue is related to something else.


Charging voltage change from absorption voltage to rest voltage

Hello everyone,
I have the following environment:
Raspi4 with VenusOS Verion v3.30
2x Seplos battery packs --> BMS Seplos BMS V16 (10E) Software version: 16.6
venus-os_dbus-serialbattery installed by mr-manuel Version: 1.2.20240409dev
BatteryAggregator installed via Setup Helper Version: v3.0.50
The BatteryAggregator aggregates the two batteries well so far.
Settings of venus-os_dbus-serialbattery:
In the config.ini of venus-os_dbus-serialbattery "Charge Voltage limitation (affecting CVL)" is enabled:
CVCM_ENABLE = True
This causes the battery to charge up to MAX_CELL_VOLTAGE (can seen as absorption voltage).
Then under certain circumstances the charging voltage changes to FLOAT_CELL_VOLTAGE (can be seen as resting voltage).
The problem:
If the first battery changes to FLOAT_CELL_VOLTAGE, but the second battery is still at MAX_CELL_VOLTAGE (because it still wants to do balancing), the BatteryAggregator sets the charging voltage equal to FLOAT_CELL_VOLTAGE.
The second battery cannot then complete the balancing.
It would be better if the BatteryAggregator only switches to FLOAT_CELL_VOLTAGE when both batteries switch to FLOAT_CELL_VOLTAGE.
Is this setting possible with the BatteryAggregator?

The current behaviour is:
If the aggregated /Balancing is 1, the max of the voltages is used, else the min.
The aggregated /Balancing is the max of the individual /Balancing.
Can you verify the behaviour of the individual battery /Balancing?
On the aggregator, you can also set /LogLevel to INFO to see what is happening in practice (please attach any log).

I noticed the following:
one of the two batteries was balancing the cells. The other one doesn't.
In VenusOS I see that the battery that is being balanced has "Allow to balance" set to none.

Is this "Allow to balance" value the trigger for the BatteryAggregator to switch between the absorption voltage and the resting voltage?

No, /Io/AllowToBalance is different from /Balancing. To confirm, are you saying it is 'no' when it is balancing or 'no' when it is not balancing? You should use dbus-spy to check /Balancing.

I'm not sure I understand how the logic works exactly, but if any battery is still balancing and a different one switches to float early, the best solution is to increase the pre set MAX_VOLTAGE_TIME_SEC = 900 (15 minutes) to allow all the batteries to balance for longer.
Otherwise MAX_CELL_VOLTAGE cannot be adjusted (limited lower) by the CVL functions which are arguably more important for cell protection, and a really useful function of sbattery: https://github.com/pulquero/BatteryAggregator/issues/45#issue-2251852273

That increases the parameter MAX_VOLTAGE_TIME_SEC is a good idea and I've tried it now.
Unfortunately, after reaching MAX_CELL_VOLTAGE (sbattery charge mode LINEAR_LIMITATION_ENABLE = True) it switches to float immediately and not after the time set in MAX_VOLTAGE_TIME_SEC. So that's not a solution either.

This is probably a Serial Battery settings issue. Maybe this thread is useful to read and change to suggested settings to make it work:
https://github.com/Louisvdw/dbus-serialbattery/discussions/1036#discussion-6510569

Now it's working.
I adjusted the following settings in sbatterie config.ini:
; --------- Charge mode ---------
LINEAR_LIMITATION_ENABLE = True
; --------- Charge Voltage limitation (affecting CVL) ---------
CVCM_ENABLE = True
; -- CVL reset based on cell voltage diff (linear mode)
MAX_VOLTAGE_TIME_SEC = 3600
; --------- Voltage drop ---------
VOLTAGE_DROP = 0.050
Thank you very much for the help/support.


Missing validations

Description
Certain validations were either misconfigured, or were not correctly validating.
For example, OBJECT_ARRAY and Array of specific type objects
Fixes #6280
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Jest tests added for missing scenarios
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

/ok-to-test sha=22d9d99

/ok-to-test sha=22d9d99

Merged despite one test failing. The failing test has been reported here: https://github.com/appsmithorg/appsmith/issues/6321


reenable map_ops_test to test on CI

testing map_ops_test on CI

repeated the experiment just to be certain it is not a hardware problem that is causing this.


perf: timings for groups

compressing groups takes 4 seconds at gen 1700, group creation takes 6. optimze this

todo: check new timing


feat: add upgrade functionality for light account to msca

Pull Request Checklist

[ ] Did you add new tests and confirm existing tests pass? (yarn test)
[ ] Did you update relevant docs? (docs are found in the site folder, and guidelines for updating/adding docs can be found in the contribution guide)
[ ] Do your commits follow the Conventional Commits standard?
[ ] Does your PR title also follow the Conventional Commits standard?
[ ] If you have a breaking change, is it correctly reflected in your commit message? (e.g. feat!: breaking change)
[ ] Did you run lint (yarn lint:check) and fix any issues? (yarn lint:fix)
[ ] Is the base branch you're merging into development and not main?
[ ] Did you follow the contribution guidelines?

PR-Codex overview
Focus of this PR:
Update dependencies and add new methods for upgrading smart contracts.
Detailed summary:

Update @alchemy/aa-core dependency to version 1.2.4.
Update @alchemy/aa-accounts dependency to version 1.2.4.
Add new method encodeUpgradeToAndCall to SmartAccountProvider and LightSmartContractAccount classes.
Add new method upgradeAccount to SmartAccountProvider class.
Add new utility function getMSCAUpgradeToData for retrieving upgrade data for MultiOwner MSCA.

The following files were skipped due to too many changes: packages/accounts/src/msca/utils.ts, packages/accounts/src/msca/abis/UpgradeableModularAccount.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}


HUD Display Current Filename for Image Sequences

In version 1 the HUD would display the full file path for the current frame. With version 2 when I open an image sequence the individual file is not shown, but instead the frame range is. So in v 1 I would get
\\some\path\frame_0100.jpg
now I get
frame_0001-2000.jpg
There is a 'Frame' display at the bottom, but it displays the timecode, not the frame.
I ask for this because sometimes I really need to know exactly what frame I'm looking at.

Hi, sorry for the delay; if you set the "time units" in the settings to frames it will show the current frame in the HUD instead of the timecode.

Superb, thank you.


React-native-swipe-list-view can support pull-up to load more data and pull-down to refresh the page

Can react-native-swipe-list-view support pull-ups to load more data and drop-down refresh pages, or how should I implement it, taking 10 data at a time

Hey @suwu150 the <SwipeListView> component is just a <FlatList> (or a <ListView>) under the hood so you can follow any of the guides on how to implement pull to refresh for those components and it will work here, thanks!
Here's a guide e.g. https://dev-blog.apollodata.com/loading-data-into-react-natives-flatlist-9646fa9a199b


Specatord Should Parse Monotonic Counters as uint64

Right now, all protocol lines are parsed into doubles, which could overflow if we accept uint64.
https://github.com/Netflix-Skunkworks/spectatord/blob/main/server/spectatord.cc#L252-L257
We should split the parsing based upon the type.

Proposed Solution

Since we will now be storing either a double or a uint64 as a measurement value, and we do not want to introduce additional storage overhead, create a valueT union which is then referenced by the measurement struct. The access pattern for the value then becomes m->value.v or m->value.u, and this pattern needs to be percolated across the codebase, but it will incur no additional memory storage overhead, because it will only allocate what is needed for the type being used.

union valueT {
  double v;
  uint64_t u;
};

struct measurement {
  spectator::Id id;
  valueT value;
};

Fixed with https://github.com/Netflix-Skunkworks/spectatord/pull/90


Removing overfitting plots-checkpoint.ipynb

The "overfitting plots-checkpoint.ipynb" file (aka add super messy notebook on overfitting to have it tracked and move i…") can now safely be removed, right!? :)

yeah totally.
Should we go on gitter for discussions?
Btw what did you mean by

Unsupervised learning: Non-linear regression analysis ?

If you have time, i think it would be nice if we could submit our
proposal in the next hour.
On 03/20/2016 10:03 AM, Sebastian Raschka wrote:

The "overfitting plots-checkpoint.ipynb" file (aka add super messy
notebook on overfitting to have it tracked and move i…") can now
safely be removed, right!? :)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/amueller/scipy-2016-sklearn/issues/2

Okay np, In this case, just disregard the email I just send you ;) Let's go to gitter then and discuss it further

Closing this since it's been addressed in #3


Test UX: High noise to signal ratio in test output for large workspaces.

rust workspaces are getting bigger and if I run a named test I get this kind of thing:
<snip>
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 3 filtered out; finished in 0.00s

     Running unittests (target/debug/deps/sc_consensus_pow-ebde30e7fc601f52)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests (target/debug/deps/sc_consensus_slots-8c4f89b5b5023e60)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 12 filtered out; finished in 0.00s

     Running unittests (target/debug/deps/sc_consensus_uncles-ccf4803c4c0275c7)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests (target/debug/deps/sc_executor-f162d5c03810b699)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 81 filtered out; finished in 0.00s

     Running unittests (target/debug/deps/sc_executor_common-b31f7a1b0538b32d)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests (target/debug/deps/sc_executor_wasmi-26dded16175b1765)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests (target/debug/deps/sc_executor_wasmtime-aafc61ecf1051687)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 3 filtered out; finished in 0.00s

     Running unittests (target/debug/deps/sc_finality_grandpa-5e29a0a4b6779109)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 78 filtered out; finished in 0.00s

     Running unittests (target/debug/deps/sc_finality_grandpa_rpc-0cf104be186ce752)

running 0 tests
<snip>

There's screen fulls of this.
Somewhere in the pages of output is my test that was run....
The feature request: Can we have a better UX please?
E.g. could we have a --condenced flag we could use to see more consolidated results because we like tests, lots of tests are good, but the UX could be improved.
Requests like this are what success looks like - it's a good thing :-)

I'd love to see experimentation with this in a third party sub command. When there is a format that is widely used, we can bring it into Cargo.

Yea, I agree it would be nice to have a cleaner summary and output.  I'm going to close this as a duplicate of #4324 and #2832.


Unit test for include_routers function + mocked App class

Description
Unit test for include_routers function + mocked App class
Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[x] Unit tests

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Testing

make test-unit

/close
see discussion in https://github.com/openshift/lightspeed-service/pull/379#discussion_r1484616470


Send out all dates in ISO 8601 format

Because this is easier to work with natively in Python and it's just n i c e r.

Cross reference le717/vss365today#91 and le717/vss365today-finder#6 that depend on this PR


Fixed failed tests links' help prompt

Updated the failed tests links' help prompt to be accurate and 1:1 usable.

Is anything happening in this PR?

Yes, I'm on a last (late) summer pto this week, but I will continue next week with it :)

The custom links on report page can now go to any tool. There is a combobox with presets, but also a field for custom endpoint

rebased changes from master - the scan passes now

I tested it on my machine and the filled fields should remain after the update - the only thing that will need to be set is the "Preset tools" combobox


Question: Why do some results (maybe) look inconsistent?

Hi Patrik
First of all, thanks for posting this code! It really has some interesting features.
I am posting this message here, not because of an issue. But rather because I was wondering whether you could provide some more information on the software you provide.
I ran a few tests:
test 1:
while this input: http://imgur.com/a/ijPfn
generates this output: http://imgur.com/a/romwv
with this generated 3d model: http://imgur.com/a/kjmrf
test 2:
This input: http://imgur.com/a/duQRs
generates this output: http://imgur.com/a/RMLoX
generated 3d model: http://imgur.com/a/DD0Q3 (looks incorrect to me....)
Could you explain why the second test returns -what looks like- incorrect results (to me)? Is it because of the used .bin file? If yes, could you please elaborate?
Thanks

Posting my answer from reddit here:
Hi!
A few points:

The .bin files are MorphableModel's, serialised using the cereal library. Opening them using a .bin file reader is not really useful. It's just the MorphableModel class serialised to a binary file. You can inspect the MorphableModel class to see what's in there, it is in my opinion very well documented.

There should be enough information about it in general on the Repo's pages, in the code documentation, and in our paper. If not, we're happy to add if something specific is missing.

It seems to me you're trying to use fit-model-simple to fit faces with strong expressions. Please have a look at what this app is actually doing in the documentation. As the name says, it is a (very) simple example app. It does not fit facial expressions (it doesn't take facial expression shapes as input!).  It is a very simple demo app for people to get started. Maybe it creates too much confusion and I should remove it actually...

What you probably want is to look at the fit-model app, which fits expression blendshapes and contour landmarks.
If you want to learn more I would strongly urge you to read some of the library documentation and a couple of introductory papers about 3DMM's (maybe the original 1999 paper from Blanz & Vetter, and our VISAPP paper, as a start).


Create reaction_listener.go.tmpl

The reaction listener for the Connect4 game.
Please describe the changes this PR makes and why it should be merged:
Status

[x] Code changes have been tested on an instance of YAGPDB, or there are no code changes
[x] I have read and followed the contribution guide

See the comment in #210.


Workspace build error with PHP7.1

Hi,
Tried to build with PHP7.1 version and received the following error:

Step 1/59 : FROM laradock/workspace:1.3 # placeholder. Need change after new image would be built.
ERROR: Service 'workspace' failed to build: Error parsing reference: "laradock/workspace:1.3 # placeholder. Need change after new image would be built." is not a valid repository/tag: invalid reference format

I set the PHP version to 7.0 and the error disappeared, the build was successful.

The error lies in the Dockerfile-71 Line 13 in the workspace directory, the line has a wrong comment which stops docker from building. You could manually remove the comment and retry. The problem will be solved.

@garlian Thanks. Actually, I'm fine with 7.0, just thought it would be worth reporting this, as it breaks the build process.

deleted the comments... naw it gives error
Step 1/57 : ARG PUID=1000 ERROR: Service 'workspace' failed to build: Please provide a source image with from prior to commit

@kp77 I had the same error earlier today, but was able to cure it by cloning a fresh copy of the laradock repo.   I just saved my .env file along with the webserver configuration and reinstalled docker-compose up -d mysql nginx

thanks @kp77 . did not work for me. still getting the same error.

There's a separate issue open for the PHP version within the workspace: #776. Linking everything together so we can find all the related issues when the solution is available.

@mahmoudz so, since you have closed this issue, am I to assume selecting PHP71 in .ENV file should actually work?  If so, spread the secret.

Yep, this is working. Laradock is now using PHP version 7.1 by default, which can be changed in the dotenv file. All workspace arg options in the dotenv can be enabled safely, except these ones:

WORKSPACE_INSTALL_AEROSPIKE_EXTENSION -> Issue #855
WORKSPACE_INSTALL_INSTALL_V8JS_EXTENSION -> Issue #792

If you experience any issues, feel free to let us know!


refactor with rubocop

Coverage increased (+0.005%) to 81.411% when pulling 8546c0733dc2131b70b9c5420005eb1dbf242d45 on sunny4381:refactor-with-rubocop into f78b49f942f20e4a810e8750d85040708aada695 on shirasagi:master.


⚠ ClamAV has degraded performance

In 7535ef9, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 562 ms

Resolved: ClamAV performance has improved in 0d6d6c1.


Edit - No Match Found - Text

Love the project..
I was wondering if it will be possible to edit the No Results Found text and allow for callback if selected?

There is "No Match Found" for http call.
https://github.com/ng2-ui/ng2-auto-complete/blob/66776e7f340bd2302de521902e6ef17d77e1c334/src/ng2-auto-complete.component.ts#L38
And the design for 'No Match Found' is only for informational, and not clickable. You can select a blank item though.

so hard coded No Result Found causes an issue with localization and translations. Also blank item is not available when no results found... can we make it available?  and can we submit a string to change the text value of No Result Found?

You need to specify "blank-option-text" to see blank item.
blank-option-text, string, guide text to allow empty value to be selected as in empty value of option tag.

@ndcunningham can you change this "No Match Found" to be configurable like 'blank-option-text'?

Yessir... I understand how blank-option-text works... however it is not an available option when No Result Found is displayed, as far as I can tell.

So, what you need is to have mousedown available for No Match Found?
Before:

No Match Found

{{blankOptionText}}

After:

{{noMatchFoundText}}

{{blankOptionText}}

is this a new feat?

yessir.. thank you sir

@ndcunningham that's a suggested new feature. Not implemented yet.

This feature has been implemented closing


Add query tag back to incremental models

Problem
We inadvertently removed query tags on incremental models when implementing Iceberg support.
Solution

Add query tags back to incremental models
Fix the query tag test that should have caught this, but didn't

I'm skipping the changelog on this since this is a pre-regression that we caught prior to final release.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

CI is failing due to the pending update for py38 retirement and the related change in branch protection rules. This should be resolved once the py38 retirement PR is merged, which contain the expected workflows.


fix: ERC725X and ERC725Y inherit Ownable first

This solves a solc compile error TypeError: Linearization of inheritance graph impossible by inheriting the "most base-like" contracts first to prevent errors from inheriting contract.
See a similar fix here https://github.com/OpenZeppelin/openzeppelin-contracts/pull/1128

I came across this issue with a contract that has a token implementation from OpenZeppelin and ERC725Y as part of its inheritance graph.

@frozeman just tried it out, and its the same error since the refactoring did not change the ordering of inheritance.
updated this PR to make the changes on the latest master

FWIW after a refactoring that removed inheriting Ownable directly this is no longer an issue, as only ERC725Y pulls it into the inheritance graph (and so the ordering issue is gone).
Still think this is a good change to land, following the reason given in the first comment, as this can be a confusing error to receive from solc.


App is crashing! What i should to do?

Hello. I used google auth a long time and few days ago its just crashing when i launch application! There is all of my money! i used android 2.3.6. i dont do anything with my phone and now cant open app.

Dup of https://github.com/google/google-authenticator-android/issues/70


Bloated native-base-theme folder

node, npm, react-native, react and native-base version

node v8.9.4
npm v5.7.1
react-native v0.53.0
native-base v2.5.1

Expected behaviour
Theme folder ideally should contain the overrides for components being used and should be updated if need arise
Actual behaviour
Contains overrides for every component, which in turn bloats the project
Steps to reproduce should include code snippet and screenshot
node node_modules/native-base/ejectTheme.js mentioned in http://docs.nativebase.io/Customize.html#theaming-nb-headref creates a new folder native-base-theme at the root of the project.
Is the bug present in both iOS and Android or in any one of them?
Cross-platform
Any other additional info which would help us debug the issue quicker.
Ideally ejectTheme.js should additionally/optionally account for a list of component for which the theme files are actually needed and generate them accordingly, instead of randomly dumping all the files, which might never be used, simply increasing the size and decreasing the maintainability of the project.

Ideally ejectTheme.js should additionally/optionally account for a list of component for which the theme files are actually needed and generate them accordingly,

Can you brief on this

Say my use case is limited to the usage of Header, BottomTabBar and Radio. In such a case what I would ideally want is to run something like node node_modules/native-base/ejectTheme.js --components [Header, BottomTabBar, Radio] and the resulting folder will contain just these components under native-base-theme\components

No, this is something not good use case
https://github.com/GeekyAnts/NativeBase/issues/830#issuecomment-394171422 this use case is suggested instead

Thanks for providing the additional info. That was helpful. As for my situation, I moved variables/platform.js to a separate directory and deleted the native-base-theme folder. Next, as mentioned in https://github.com/GeekyAnts/NativeBase/issues/830#issuecomment-302386493, I imported getTheme from native-base/dist/src/theme/components and all my custom theming which was limited to color and size worked as expected.

@samratshekhar Thats documented
You can read it from https://docs.nativebase.io/Customize.html#customize-button-headref

@samratshekhar Any other help needed here?


Webhook Test - Title Change

Description
Please describe the issue you are facing or a feature you would like to be added to the SDK.

Repro Steps
Please list the steps used to reproduce your issue.

Details

Which SDK version are you using?

e.g. 1.5.0

Which OS version did you experience the issue on?

e.g. Android 8.1.0, iOS 11

What version of Cordova, Cordova platforms, Cocoapods, and Ruby are you using?

e.g. Cordova version 8.0.0

What device version did you see this error on?  Were you using a simulator or a physical device?

e.g. Google Pixel 2 emulator, Samsung Galaxy S8 physical device

What third party plugins are you using?

e.g. run "cordova plugins list" command and share your output

a comment

another comment

one more test

.

comment test


Do not allow saving a malformed native secret

Fixes #1484
RELEASE_NOTES=[BUGFIX] Do not allow malformed secrets
Signed-off-by: Dominik Schulz<EMAIL_ADDRESS>

Codecov Report

Merging #1490 into master will decrease coverage by 0.05%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1490      +/-   ##
==========================================
- Coverage   61.09%   61.04%   -0.05%
==========================================
  Files         219      219
  Lines       12193    12205      +12
==========================================
+ Hits         7449     7450       +1
- Misses       3924     3933       +9
- Partials      820      822       +2

Impacted Files
Coverage Δ

pkg/gopass/secret/mime.go
71.01% <0.00%> (-2.12%)
:arrow_down:

pkg/gopass/secret/secparse/parse.go
91.30% <0.00%> (-8.70%)
:arrow_down:

internal/action/edit.go
53.45% <46.67%> (-6.55%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25757ab...5899920. Read the comment docs.


Building a Recent Activities page  in Vue 3

Topic Suggestion
Enter topic suggestion here...
Proposal Submission
Proposed title of the article
Building a Recent Activities page  in Vue 3
Proposed article introduction
In this tutorial, I will teach the reader the basic concepts of logging activities in Vue 3. The concept here is to keep track of all the user activities on every single route on the page and log them accordingly.
The aim of the tutorial is to help the system admin in managing the system and ensuring that every activity on the system is done without involving the backend.
Key takeaways

A quick introduction to Vue.js route modules
Working with Vue store.
Listening for route actions.

Article quality
This is a very unique article that covers the concepts of user tracking and activities. These actions are then stored in the database for future reference. Additionally, we use the latest version of Vue (3) to implement the logging.
References
Please list links to any published content/research that you intend to use to support/guide this article.
Conclusion
Finally, remove the Pre-Submission advice section and all our blockquote notes as you fill in the form before you submit.
We look forward to reviewing your topic suggestion.
Templates to use as guides

How To Guide Template
Software Review Template
Tutorial Template

Nice topic @TheresaAtieno Approved. Let's ensure that it adds value to the community. Thanks

@TheresaAtieno
Closing due to inactivity - if you'd like to continue working on the topic. Please let us know.


fix: Exclude vm address from assumeNoPrecompiles

Excludes the vm address 0x7109709ECfa91a80626fF3989D68f67F5b1DD12D from the assumeNoPrecompiles cheat code.
Resolves #405
Note that address(vm) is used instead of address(0x7109709ECfa91a80626fF3989D68f67F5b1DD12D) (such as in  testAssumePayable) so that it fits squarely into the current implementation of the cheat code and respective test with minimal confusion. Open to changing this though.

That for loop is valid Solidity? Don't think there's a built-in way to get the length of an enum and it doesn't seem to work in either my forge test or chisel.

Hm it should work, see the solidity docs:

Using type(NameOfEnum).min and type(NameOfEnum).max you can get the smallest and respectively largest value of the given enum.

Payable and NonPayable are mutually exclusive right, so we wouldn't need to iterate through the whole enum but instead n - 1?

Ah good point. So maybe we put payable/nonpayable as indexes 0 and 1 in the enum, then we have:

main test that iterates through indicies 2-n for the non-mutually-exclusive cases
second test for payable
third test for nonpayable

Wdyt of that? This way new values added to the end of the enum are automatically tested

You still have to provide the address itself as an argument to assumeAddressIsNot right? That's the way assumeNoBlacklisted, assumeNoPrecompiles, and  assumePayable are.

Oops yes, sorry forgot to include that 😅

Looks great overall, thank you! Lots of small comments around details / some nits

Cool. I like all of these suggestions. It's a big PR to be fair.

Let me know what you make of these adjustments.

This looks great, thanks a lot @Sabnock01! I pushed one commit with a few small tweaks, lmk if you have any feedback/objections there, and afterwards I'll merge

This looks great, thanks a lot @Sabnock01! I pushed one commit with a few small tweaks, lmk if you have any feedback/objections there, and afterwards I'll merge

These are good. Should have caught more of them honestly but was a pleasure working with you on this one.

Likewise, thanks for the quality PR! '🙌
I'll be putting out a new forge-std release with this shortly


Update New-CMPackageDeployment.md

Add another Example of a Required Deployment vs the Available ones there currently.

@gwblok : Thanks for your contribution! The author(s) have been notified to review your proposed change.


playing/adding a single song broken

This is a strange one:
Since Ive updated to kodi17/Librelec, playing a single song from Music -> song triggers the party mode instead of actually playing this track.
Adding  a song returns 'invalid params" .
Kore 2.2.0 / Kodi 17.0 on Librelec RPi2.

See #362


RFC: Records

Rendered link

Thinking through syntactic options more it occurred to me that the new operator isn't backwards compatible syntactically. It uses the "two identifiers in a row" rule that we've used successfully in statement context, but it doesn't actually work in expression context as this code is valid today, with or without the newline:
local X = new
Y { a = 42 }

The Point { x = x, y = y } syntax without the new operator isn't too difficult to make efficient either. The codegen today is something like
NEWTABLE
SETTABLEKS
SETTABLEKS
GETLOCAL
CALL

To allow for records, the codegen would be something like
NEWRECORD
SETTABLEKS
SETTABLEKS
FINRECORD
CALL

NEWRECORD will create the record if the source local is a record shape, and create a table otherwise; FINRECORD will skip the next call instruction if the object is a record, and do nothing otherwise. This should preserve the DSL like syntax dynamically, I think.
The variant with unnamed arguments is still easier to codegen / make efficient, it requires no new opcodes and is just a small tweak in the CALL dispatch which should be almost entirely free as we already have a path for checking if the called object is a table (which handles __call).
I'm going to edit the RFC to remove two of the four variants and more explicitly outline the tradeoffs between those.

I've added lots of edits with better examples and cleaned up syntax and wording in a few places, as well as specifying two options for record subtyping (that roughly boil down to, do we treat records as TableTypeVar or ClassTypeVar on type level?). I've also resolved all comment chains to clean up the discussion threads as it was getting difficult to manage.

Posting this here so it doesn't get lost. Consider whether we want to support keys that aren't normally valid identifiers, e.g. record MyRec = { ["$$typeof"]: "MyRec" }.

Why the name record?
Why not struct or tuple?

Why the name record?
Why not struct or tuple?

It doesn't make sense to name it tuple since tuples are just immutable lists in practice.
As for struct, I don't know. I guess they really wanted to go with the record syntax.

It doesn't make sense to name it tuple since tuples are just immutable lists in practice.

Usually != always. :)
How to use tuples with named fields in C# by example
Namedtuple in Python

Tuple usually refers to a fixed length collection of values that doesn't carry names.
Struct can carry the connotation that would imply the object has value type semantics, which is not the case here.
Hence we chose the name record as the one that's least likely to give people the wrong idea about the new construct behavior.

This PR is closed as part of RFC migration; please see https://github.com/luau-lang/luau/issues/1074#issuecomment-1785578157 for context.
Additional notes: I still think this represents a significant need, but since this RFC has been submitted there were new developments that require somehow revising this RFC and I'm not sure how to do that quite yet. Specifically,

We would need to equalize this design with new design for shared self (which hasn't been merged or finalized, but we know we want to do that). It might mean that we should find a better way to split type handling so that records and tables with shared self are more similar
My initial designs for record implementation required dynamic bytecode patching so that records can be addressed as tables with no performance penalty. This still works, but it predates native codegen; in native codegen we currently don't have a great way to implement records unless we know, at codegen time, that a given variable is a record. This knowledge requires cross-module type analysis to be general, so we need to figure out if we can somehow change our native codegen approach. It would be bad if records are somehow slower than tables in native codegen because of extra conditional checks and fallbacks.


set breadcrumb type and timestamp from event

Codecov Report
Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 50.00%. Comparing base (a5e7c6e) to head (2ea945a).

Files
Patch %
Lines

writer.go
0.00%
12 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   51.80%   50.00%   -1.81%
==========================================
  Files           1        1
  Lines         222      230       +8
==========================================
  Hits          115      115
- Misses         98      106       +8
  Partials        9        9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.