Fallback codecs

Add a wrapper function to initialize codec and try next fallback codec if one fails.
Reference issue
Fixes #107

I feel like we need to redesign the codec package. This change definitely works. But, it feels that there's a disconnection between the library and the users.

We suddenly require them to register the codecs manually when they want to have a fallback

codec.Register(webrtc.VP8, codec.VideoEncoderFallbacks(
		// Use if hardware acceleration is available.
		codec.NamedVideoCodec{
			Name:  "vaapi",
			Codec: codec.VideoEncoderBuilder(vaapi.NewVP8Encoder),
		},
		// Software implementation should always available.
		codec.NamedVideoCodec{
			Name:  "vpx",
			Codec: codec.VideoEncoderBuilder(vpx.NewVP8Encoder),
		},
	))

Then, when they want to set the codec specific params, we require them to use the names from 1 (this also feels redundant).

		c.CodecParams = map[string]interface{}{
				"vaapi": vpxParam,
				"vpx":   vpxParam,
			}

Also, it's been really weird to me that when they import one of the codec packages, it suddenly registers with one or more payload types:

const (
	PCMU = "PCMU"
	PCMA = "PCMA"
	G722 = "G722"
	Opus = "OPUS"
	VP8  = "VP8"
	VP9  = "VP9"
	H264 = "H264"
)

I think we should instead let the users build the codecs by themselves, and we'll simply take them in GetUserMedia. What do you think?

I think we should instead let the users build the codecs by themselves, and we'll simply take them in GetUserMedia.

I'm not very sure what you suggested.
Do you mean removing codec.Register() from init() of each codec package and register required codecs by the user code?

Sorry, it was definitely very vague. But, yes, you're right. I was thinking that we should remove codec.Register() from init and let the user to explicitly specify the codec in the GetUserMedia.
I think it's really hard to get my idea across with just plain English ^^. So, I've created an experiment here, https://github.com/pion/mediadevices/commit/f6905fe81aba0f266b8170fadcd0cd8e954b86e4. It's definitely not a working example since I didn't implement everything, but I made changes that I think it's enough to express my idea.
Following are the main changes:

We no longer require the user to specify the Codec Name, pass specific codec params, and import the codec to implicitly register the codec separately anymore. But, we rather have everything in <specific codec>.Params, e.g. x264.Params.
Specifying specific codec params becomes really easy and more straightforward since you just need to call x264.NewParams() and that's the only way you can specify the codec in GetUserMedia, so it's less error-prone. Also, we can avoid an empty interface (which is pretty awesome!)
Since now you're passing the builders, we can have it as an array and multiple builders with the same codec name will be fine. Essentially, we'll get a fallback method automatically.

OK. https://github.com/pion/mediadevices/commit/f6905fe81aba0f266b8170fadcd0cd8e954b86e4 definitely makes sense to me.


add image_notification to notification policy

This adds the new image_notification to notification policy

looks this has already landed in v5 too via #3979

Fantastic! Thanks for the heads up Jacob!

we can still add it here as well for v4. i was just pointing out we have this automatically in v5 🙂


Parser can now throw an exception so invalid son doesn't not crash application

If my api gave me a 200 response code but the json is invalid it is was crashing the app

rest of the code looks good to me.

this is done by another PR


Some proposed changes to Livepeer Explorer landing

Removed the video tutorial, edit some copy, changed some routing.

What does this pull request do? Explain your changes. (required)
It makes some changes to explorer.livepeer.org landing page, to help new explorers in Livepeer to begin to engage with the protocol more easily.
Specifically, it promotes the section where a user can enter any Ethereum address (including their own), to begin to explore livepeer's protocol.
It also rewords some copy, to make it more accessible to a wider audience - the 2.6 million who have no idea about bonding and inflationary reward yet - but they will soon, maybe!
Specific updates (required)

Remove the video (for now, pending a new video to be put in it's place to help new entrants joined the community)

Rebrand "Explorer Protocol Activity" to "Explore Your Account"

Adapt the copy to make it friendlier, and easier to engage with. Also, to seek to personalise it somewhat, and make the user feel at the centre of this.

Rebrand "Play the Delegation Game" to "BOND your LPT to a Node"

Someone should totally gamify this, but not us. At least, not yet.
For now, I propose to lead them down the garden path, to the specific call-to-action that we want them to take. To BOND.
GET TOKEN is finished now. Remove from everywhere, let's tidy this up :)

How did you test each of these updates (required)
I tested them in my mind's eye, tweaked some text about, fit @jozanza's pattern. It'll be fine. Can we push them to staging first and then have a look?
Does this pull request close any open issues?
No.
Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.

Thanks @chrishobcroft for contributing this.


Removed reference to non-public library called json-fields

Please check if the PR https://github.com/zalando/restful-api-guidelines/pull/493 introduces changes which are relevant to the Zally project.

Irrelevant for Zally project


RuntimeError: fail to allocate CUDA resources

I've followed the tutorial in the README with regards to YOLOv3. Here is a list of the package versions:

pycuda 2019.1.2
onnx 1.4.1
tensorrt <IP_ADDRESS>

I converted custom trained yolov3 models using the code in the yolo folder. I then try to load the model to use for inference as follows:
model1_trt = TrtYOLO(model1, (model1Height, model1Width), model1_category_num)
This is the output from my code:
[TensorRT] INFO: [MemUsageChange] Init CUDA: CPU +346, GPU +0, now: CPU 383, GPU 11577 (MiB)
[TensorRT] INFO: Loaded engine size: 122 MB
[TensorRT] INFO: [MemUsageSnapshot] deserializeCudaEngine begin: CPU 506 MiB, GPU 11700 MiB
[TensorRT] WARNING: Using an engine plan file across different models of devices is not recommended and is likely to affect performance or even cause errors.

[TensorRT] ERROR: 4: [runtime.cpp::deserializeCudaEngine::76] Error Code 4: Internal Error (Engine deserialization failed.)
None
Traceback (most recent call last):
  File "/media/nvidia/XAVIER-1TB-SSD/0-PROD_CODE/utils/yolo_with_plugins.py", line 255, in __init__
    self.context = self.engine.create_execution_context()
AttributeError: 'NoneType' object has no attribute 'create_execution_context'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "trt_get_all_detections.py", line 81, in <module>
    car_trt = TrtYOLO(car_model, (carHeight, carWidth), car_category_num)
  File "/media/nvidia/XAVIER-1TB-SSD/0-PROD_CODE/utils/yolo_with_plugins.py", line 259, in __init__
    raise RuntimeError('fail to allocate CUDA resources') from e
RuntimeError: fail to allocate CUDA resources
Exception ignored in: <bound method TrtYOLO.__del__ of <utils.yolo_with_plugins.TrtYOLO object at 0x7f911acba8>>
Traceback (most recent call last):
  File "/media/nvidia/XAVIER-1TB-SSD/0-PROD_CODE/utils/yolo_with_plugins.py", line 266, in __del__
    del self.outputs
AttributeError: outputs

model1_trt = TrtYOLO(model1, (model1Height, model1Width), model1_category_num)

In my latest code, you don't need to specify "height" and "width" of input to the model.  Those would be automatically determined by the code.  Please pull the latest code from this repo and modify your code accordingly.
Source code for reference:
https://github.com/jkjung-avt/tensorrt_demos/blob/67c4eb0f5e8a46656eb65073e5685dc7654498d8/utils/yolo_with_plugins.py#L275

Thanks for pointing it out! It seems I was using the latest version of everything else except the inference code. I can confirm that it works after modifying the code to make trt_yolo.py.
Thanks again

I get the following error when trying to evaluate the ssd model
---------------------------------------------------------------------------
LogicError                                Traceback (most recent call last)
/workspace/tensorrt_demos/utils/ssd.py in __init__(self, model, input_shape, cuda_ctx)
     89             self.context = self.engine.create_execution_context()
---> 90             self.stream = cuda.Stream()
     91             self.host_inputs, self.host_outputs, self.cuda_inputs, self.cuda_outputs, self.bindings = self._allocate_buffers()

LogicError: explicit_context_dependent failed: invalid device context - no currently active context?

The above exception was the direct cause of the following exception:

RuntimeError                              Traceback (most recent call last)
<ipython-input-7-89ca1e68b23d> in <module>
      1 INPUT_HW = (300, 300)
      2 model_path = "ssd/TRT_ssd_mobilenet_v2_coco.trt"
----> 3 ssd = TrtSSD(model_path, INPUT_HW)

/workspace/tensorrt_demos/utils/ssd.py in __init__(self, model, input_shape, cuda_ctx)
     91             self.host_inputs, self.host_outputs, self.cuda_inputs, self.cuda_outputs, self.bindings = self._allocate_buffers()
     92         except Exception as e:
---> 93             raise RuntimeError('fail to allocate CUDA resources') from e
     94         finally:
     95             if self.cuda_ctx:

RuntimeError: fail to allocate CUDA resources


URL randomization is broken

Broken by refactor in https://github.com/palantir/http-remoting/pull/656/files#diff-6f96ec3f89ee93b2cecdf4dd49d4f564L130 : CurrentUrlInterceptor is no longer wired up.
Affects versions 3.13.0+

Expected behavior: JaxRs/Retrofit/OkHttp clients use a random URL
Actual behavior: JaxRs/Retrofit/OkHttp clients use the first URL

@pnepywoda @gauravtiwari89


Remove sign Identity from framework project

Hi,
please remove signing identity by updating project to Xcode 8 recommended settings

Yes, please update the framework project. The current status will break Carthage builds.
Sincerely,
Kaweh

Small correction: latest Carthage doesn't have problems with the project. I was using an out-of-date version of Carthage. Sorry for the confusion.

I don't use Carthage, I added manually
Tnx


Resolve markdown-link-check forbidden with renovate app link

This PR resolves a new issue that npm run check:markdown fails on GitHub when checking the link https://renovateapp.com/ in the README file. The error is HTTP 403 forbidden.
When run locally there is no failure and https://renovateapp.com/ redirects to https://renovatebot.com/ and then to https://www.mend.io/free-developer-tools/renovate/.
I have replaced the link
https://renovateapp.com/
by
https://github.com/renovatebot
and this passes the npm run check:markdown check on GitHub.
Problem analysis
CloudFront is blocking access to https://www.mend.io/free-developer-tools/renovate/ from GitHub by responding with 403 forbidden. A cy.visit('https://www.mend.io/free-developer-tools/renovate/) run on GitHub also fails.
curl -v https://www.mend.io/free-developer-tools/renovate/ -o /dev/null run on GitHub shows:
< HTTP/2 403
< server: CloudFront
< content-type: text/html
< x-cache: Error from cloudfront

This is a high priority item since it will block the release of any new version through main.yml until it is merged.

@jaffrepaul
Please merge this PR as the markdown issue is blocking all other PRs from successful testing.


[Suggestion] Enable Nouveau for integrated or hybrid mode?

Hi,
and first of all a big thanks for envycontrol, it's just awesome!
On my laptop, power management works with Nouveau, but of course the performance is sad. It is however much better than with only my integrated GPU. So, would it somehow be possible to have:

integrated + nouveau (this achieves, with no load, the same power draw than with only integrated, but better performance)
Nvidia for when performance is really required

Or do you have any tips how this could be modified? The big plus here would be to have a "low performance" dGPU with working power management for every day use (Nouveau, which is still better than only iGPU), and a "high performance" dGPU when needed (Nvidia, but with no power management).

A hybrid-nouveau mode could be created, right now I'm a bit busy but feel
free to implement it in the meanwhile and open a PR ;)
On Tue, Mar 7, 2023, 01:55 ws-volans @.***> wrote:

Hi,
and first of all a big thanks for envycontrol, it's just awesome!
On my laptop, power management works with Nouveau, but of course the
performance is sad. It is however much better than with only my integrated
GPU. So, would it somehow be possible to have:

integrated + nouveau (this achieves, with no load, the same power
draw than with only integrated, but better performance)
Nvidia for when performance is really required

Or do you have any tips how this could be modified? The big plus here
would be to have a "low performance" dGPU with working power management for
every day use (Nouveau, which is still better than only iGPU), and a "high
performance" dGPU when needed (Nvidia, but with no power management).
—
Reply to this email directly, view it on GitHub
https://github.com/bayasdev/envycontrol/issues/87, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALY7IYNCRXCCE27DONMAOCDW23LURANCNFSM6AAAAAAVSCH4GU
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Not feasible since most distros blacklist nouveau once the propietary drivers are installed and I don't want to mantain distro specific quirks.


Removing search control from campaign page

Marked div tag to remove, ok to remove this or do we just want to hide for later use? Issue #422

:shipit:


[SuperEditor] - Spike: Check Scribble viability

This ticket is a brief spike to determine what it would likely take for SuperEditor to support Scribble on iOS.
For this ticket, attempt to integrate Scribble in the most directly way possible, making note of any issues, blockers, frustrations, etc. along the way. Then, report back as to whether it was possible, or not, and why. If it is possible, report back with what it would likely to take to fully implement Scribble in a production-level way.

CC @Jethro87
I've done an investigation into iPad Scribble within Super Editor. Here are some findings.
First, what is Scribble? Here's the Apple video: https://developer.apple.com/videos/play/wwdc2020/10106/
Some UX expectations are:

A user should be able to scribble without first giving any focus to a particular field or editor. The scribbled text is sent to whichever text input view sits under the scribbled area.
The user should be able to highlight text by drawing a straight line.
The user should be able to delete text by scribbling through it.
Any field or editor with a hint should hide the hint when scribbling begins.
Any field that's too short, or too close to the top/bottom of the screen, should become taller to fit scribbling.

Flutter is presented through a non-standard UIView and therefore the iOS API that's relevant to Flutter is UIIndirectScribbleInteraction. Flutter has at least partial integration, if not full integration of this API. Flutter apps need to register a ScribbleClient to interact with the underlying iOS API.
I've quickly hacked a prototype in Super Editor and I'm able to convert scribble text into inserted text.
However, I'm unable to select text by drawing a line. I'm also unable to delete text by scribbling it out.
This prototype reports hard coded bounds for the scribble region. For a real implementation, we probably need to register scribble elements for every text component so that the user's scribble text appears in whichever paragraph is beneath it.
We'll also need to revisit the connection between editor focus and an IME connection. The IME connection is what receives the text insertion events. So I think we need to have an open IME connection for scribble to work, even when there's no selection in the editor, or even focus.
I didn't look into adding text placeholders. My guess is that we should figure out how to implement scribble text insertion without adding extra space, before investing the time in figuring out how to add extra space for scribbling.
https://github.com/superlistapp/super_editor/assets/7259036/8c8d3324-9635-4fc6-b486-43f2710dbcba

@Jethro87 I wanted to make sure you saw the result of the Scribble analysis.

@Jethro87 can you let us know where you stand on this?

@matthew-carroll We'd very much like to have Scribble in super_editor. In our email conversation you estimated ~40 hours for this feature. We'd be happy to split the development with one or two other funders, but we're unable to fund the entire thing at this time.


Run agent interactively with root permissions

Hi,
i'm wondering why can't you run the agent interactively with root permissions?
I'm trying to build a agent which runs in a docker container, everything works fine, except i can't start the agent with root permissions. So in my builds i can't install for example packages or global node modules.
What is the point of disallowing to run as root?
For the config.sh a flag has been added (https://github.com/Microsoft/azure-pipelines-agent/commit/1c0cfdb125ed87fec56ebdf833a4be38205dc751), wouldn't this also be possible for run.sh?
For reference this is my Dockerfile, maybe you have some suggestion to workaround this problem.

@TingluoHuang i've raised an PR. Thanks i didn't thought about this workaround, to easy i guess 😅

i am going to close this issue since the PR has been merged, thanks for your contribution!


Support bash on Windows 10

shell: 'C:\\Windows\\System32\\bash.exe' in settings
When I open a new tab I got the exception:
Uncaught Exception:
Error: Unable to start terminal process: CreateProcess failed
    at new WindowsPtyAgent (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\node_modules\node-pty\lib\windowsPtyAgent.js:25:24)
    at new WindowsTerminal (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\node_modules\node-pty\lib\windowsTerminal.js:45:24)
    at spawn (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\node_modules\node-pty\lib\index.js:27:12)
    at Session (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\session.js:53:18)
    at initSession (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\ui\window.js:102:24)
    at Server.Window.rpc.on.options (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\ui\window.js:105:7)
    at emitOne (events.js:115:13)
    at Server.emit (events.js:210:7)
    at Server.ipcListener (C:\Users\n0xff\AppData\Local\hyper\app-2.1.0-canary1\resources\app.asar\rpc.js:33:11)
    at emitTwo (events.js:125:13)

In bash action.data return:
"]0;virtual@MAIN-PC: /mnt/cvirtual@MAIN-PC:/mnt/c/Users/n0xff$"

After parsing this data the cwd variable value is C: /mnt/c. So Hyper can't start a new session with wrong cwd.
If we want open bash.exe with our folder we need use cmd arguments bash.exe -c "cd /mnt/" or change current folder before opening bash.exe (and he open bash in current folder). I don't know can we send additional arguments to Hyper or not, but we can change current folder in right way.
I extend regexp and add transform from Linux path in Windows. So above data now will return correct folder path C:/Users/n0xff.
Was tested in default cmd.exe and bash.exe shell.

Should completely fix https://github.com/hharnisc/hypercwd/issues/32

Oh, I found another problem.
I can't open new tab when rails server is running because action.data is:
"Read fragment views/application/_footer:82b6729ab2e01c94a01e63c6949ca9d9/ru/footer (0.2ms)
  CACHE Category Load (0.0ms)  SELECT  "categories".* FROM "categories" WHERE "categories"."id" = $1 ORDER BY "categories"."position" ASC LIMIT $2  [["id", 2], ["LIMIT", 1]]
  ↳ app/routes/friendly_items_route.rb:46
  CACHE Category Load (0.0ms)  SELECT  "categories".* FROM "categories" WHERE "categories"."id" = $1 ORDER BY "categories"."position" ASC LIMIT $2  [["id", 2], ["LIMIT", 1]]
  ↳ app/routes/friendly_items_route.rb:46
"

And default or my regexp parse it in cwd: 'r:82b6729ab2e01c94a01e63c6949ca9d9/ru/footer (0.2ms)'

Any update on when this will be merged?


Add group policy to disable the settings button if user doesn't run in admin

What's the Problem?
I would like to use files for my server account that is restricted and as it can be used now I would like stopping users accessing the settings.
Solution/Idea
Add a toggle in settings to only show the button if it's ran in administrator. The button wont show at all or give a "Settings has been disabled by administrator"
Alternatives
Add a group policy item called "Hide settings" allowing enabled or disabled. Default disabled.
Priorities
No response
Files Version
No response
Windows Version
No response
Comments
No response

@Josh-65 users will still be able to change some settings from the layout flyout but we can add additional policies for those.

Is hiding the settings icon really enough, or should we also reset the json file if modified externally?


Improved performance.

I think it still works (running the tests says it passed, so I'm gonna take that as a yes).
Here's the results I got:
Ecc:
	Dataset: 500 payloads of 100 bytes of random data.
	Results:
		Encrypt & Sign took 5465.16ms in total with a 10.93ms avg.
		Decrypt & Verify took 8538.27ms in total with a 17.08ms avg.

FastEcc:
	Dataset: 500 payloads of 100 bytes of random data.
	Results:
		Encrypt & Sign took 1912.72ms in total with a 3.83ms avg.
		Decrypt & Verify took 4156.13ms in total with a 8.31ms avg.

Benchmarker.zip

and yes the tests were ran with the exact same data

Thats a fantastic perf increase, ty!


Possible semantic breakage in 0.2.11

broccoli-funnel 0.2.11 breaks ember's build, because this conditional is failing to match:
https://github.com/emberjs/emberjs-build/blob/06d8c86fdd41d03c345ed7c1f166313d3c7b6fd9/lib/get-es6-package.js#L86
Funnel is passing us ember/main.js instead of main.js.

fixed in emberjs-build, which worked around this bug.

@stefanpenner - I don't see that the new behavior is a bugfix. I agree with the initial report of this issue, it is a breaking change...
The change in funnel causes the destdir to be processed before getDestinationPath is called.  The prior ordering was intentional (that the getDestionationPath was called with the non-moved input path)...

0.2.12 uses path.join(this.destDir, relativePath) as the argument to lookupDestinationPath (see here), whereas in 0.2.7 the path provided was relativePath (see here.  This will cause an issue for anyone using getDestinationPath along with destDir.

@rwjblue ya that sounds like bug.

@rwjblue if you can provide a failing test that illustrates your specific scenario that would be handy.


Prep for release: version and changelog update

Codecov Report

Merging #14533 into release-2020.10 will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           release-2020.10   #14533   +/-   ##
================================================
  Coverage            59.19%   59.19%
================================================
  Files                  721      721
  Lines                40230    40230
  Branches              5828     5828
================================================
  Hits                 23813    23813
  Misses               15155    15155
  Partials              1262     1262

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3479a...d7fe6b2. Read the comment docs.


Cannot request permission in RN 0.45.1. Can anybody confirm this ?

I am trying to obtain location permission in react native version 0.45. It was fine when on version 0.38. It's not working after upgrade.
I always get 'undetermined' while requesting for location permission.

my bad. After upgrading, it changed the Manifest file so that there was no location permission.


Thanks, I will look into how repo renaming works on github.


Adding French language

Hello, I'd just like to know if everything is OK with French for you, or if you might need help with anything?
If I can help! ^^'
Thanks

Hello, come to the vrcx discord, and contact me.


Run flake8 on Python 3, not Python 2

Flake8 will find several syntax errors (like print statement) and undefined names (like reload) when run on Python 3 that it will not find when run on Python 2.
Make sure you have checked all steps below.
JIRA

[ ] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a JIRA issue.

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[ ] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Codecov Report

Merging #3291 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3291   +/-   ##
=======================================
  Coverage   75.89%   75.89%
=======================================
  Files         197      197
  Lines       14706    14706
=======================================
  Hits        11161    11161
  Misses       3545     3545

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96d00da...494c55f. Read the comment docs.


WIP: Re-enable microscope

Still WIP, waiting for DNS/service flake

This change is

test-me-please

test-me-please

It works: https://jenkins.cilium.io/job/Cilium-PR-Ginkgo-Tests-Validated/3916/

@eloycoto the reason it was reverted was due to the microscope processes not actually being killed on the nodes, which caused the kernel to have to forcibly terminate processes, which caused test failures. Work will have to be done to forcibly terminate the microscope processes launched in each test, as well as testing to ensure that the processes are actually killed, as this was not done when microscope was re-enabled last time.

@ianvernon I wanted to have a fail with the Kube-dns, that it's not a PR to merge.

@eloycoto makes sense. However, the issue I outlined above may impact your desire to get a build with the microscope output.

test-me-please

test-me-please

test-me-please

@ianvernon if you can review this, it'll be great.
Regards

Close due https://github.com/cilium/cilium/pull/4452


fix docker stack omit external volume's "nocopy" parameter

- What I did
Fix docker stack omit volume's "nocopy" parameter.
- How I did it
Process external volume mount's "nocopy" parameter when create stack's services.
- How to verify it
create a volume:
docker volume create nfs

deploy stack file link as follow:
version: "3"
services:
  test:
    image: 'busybox'
    command: sh -c "sleep 1000"
    volumes:
      - nfs:/data:nocopy
volumes:
  nfs:
    external: true

Then Inspect the test service's  task container, should got the "Mount" Mode has "nocopy" option.
- Description for the changelog
Process external volume mount's "nocopy" parameter when create stack's services.

- A picture of a cute animal (not mandatory but encouraged)

LGTM


ERROR in Cannot determine the module for class when I try to upgrade from beta24 to beta31

OS?

El Capitan

Versions.

Please run ng --version. If there's nothing outputted, please run in a Terminal: node --version and paste the result here:

                         _                           _  _

__ _  _ __    __ _  _   _ | |  __ _  _ __         ___ | |()
/  || '_ \  / _ || | | || | / ` || '|_  / __|| || |
| (| || | | || (| || || || || (| || |  |___|| ( | || |
_,||| || _, | _,||| _,|||          _|||||
|_/
@angular/cli: 1.0.0-beta.31
node: 6.9.2
os: darwin x64
@angular/common: 2.4.7
@angular/compiler: 2.4.7
@angular/core: 2.4.7
@angular/forms: 2.4.7
@angular/http: 2.4.7
@angular/platform-browser: 2.4.7
@angular/platform-browser-dynamic: 2.4.7
@angular/router: 3.4.7
@angular/cli: 1.0.0-beta.31
@angular/compiler-cli: 2.4.7
Repro steps.
npm uninstall -g angular-cli @angular/cli // from 1.0.0.beta-24
npm cache clean
npm install -g @angular/cli@latest
npm install -g<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>@ngtools/webpack
npm install -g<EMAIL_ADDRESS><EMAIL_ADDRESS>npm install -g rxjs
ng serve // work fine
ng build // work fine
ng build --prod // broken
The log given by the failure.
ERROR in Cannot determine the module for class ShippingAddComponent in /Users/ARM/Desktop/kibito_web/src/app/shipping/shipping-add/shipping-add.component.ts!
Cannot determine the module for class ShippingEditComponent in /Users/ARM/Desktop/kibito_web/src/app/shipping/shipping-edit/shipping-edit.component.ts!
Cannot determine the module for class ShippingListComponent in /Users/ARM/Desktop/kibito_web/src/app/shipping/shipping-list/shipping-list.component.ts!
Cannot determine the module for class ShippingComponent in /Users/ARM/Desktop/kibito_web/src/app/shipping/shipping.component.ts!
ERROR in ./src/main.ts
Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory' in '/Users/ARM/Desktop/kibito_web/src'
@ ./src/main.ts 5:0-74
@ multi ./src/main.ts
Mention any other details that might be useful.
I try to upgrade angular-cli from beta24 to beta31
everything work fine until I use "ng build --prod" then error appear
"dependencies": {
"@angular/common": "^2.3.1",
"@angular/compiler": "^2.3.1",
"@angular/core": "^2.3.1",
"@angular/forms": "^2.3.1",
"@angular/http": "^2.3.1",
"@angular/platform-browser": "^2.3.1",
"@angular/platform-browser-dynamic": "^2.3.1",
"@angular/router": "^3.3.1",
"bcryptjs": "^2.4.0",
"body-parser": "^1.16.0",
"cookie-parser": "~1.4.3",
"core-js": "^2.4.1",
"cors": "^2.8.1",
"encoding-japanese": "^1.0.25",
"express": "^4.14.0",
"jsonwebtoken": "^7.2.1",
"morgan": "^1.7.0",
"mssql": "^3.3.0",
"multer": "^1.3.0",
"mydatepicker": "^1.1.15",
"ng2-bootstrap": "^1.3.2",
"ng2-file-upload": "^1.2.0",
"ngx-uploader": "^2.1.2",
"rxjs": "^5.0.1",
"ts-helpers": "^1.1.1",
"underscore": "^1.8.3",
"zone.js": "^0.7.2"
},
"devDependencies": {
"@angular/cli": "^1.0.0-beta.31",
"@angular/compiler-cli": "^2.3.1",
"@types/jasmine": "2.5.38",
"@types/node": "^6.0.42",
"@types/underscore": "^1.7.36",
"codelyzer": "~2.0.0-beta.1",
"jasmine-core": "2.5.2",
"jasmine-spec-reporter": "2.5.0",
"karma": "1.2.0",
"karma-chrome-launcher": "^2.0.0",
"karma-cli": "^1.0.1",
"karma-jasmine": "^1.0.2",
"karma-remap-istanbul": "^0.2.1",
"nodemon": "^1.11.0",
"protractor": "~4.0.13",
"ts-node": "1.2.1",
"tslint": "^4.0.2",
"typescript": "~2.0.3"
}

Are these components in the declarations field of any @NgModule?

@Meligy  yes , they are
now I can fix it
because when I move folder shipping to subfolder
I duplicate it instead of move it
so I just delete folder shipping
error is gone 👍
but I still confuse why I can use ng build and ng serve without error

@rainstormza
I am having this issue also - what did you do to solve it?

@johnjameshopley
that was my mistake that I duplicate folder.
when you use ng build -prod
AOT will compile all file in your project that mean if you have component or folder that you did'n't use it or duplicate those files AOT will compile it anyway.
you have to remove those file from your project

@rainstormza  .... I had a component that contains some errors. so I decided to make a new one ... but I wrote it with the same name so on production .... I have some problems with one of them so I decided to remove the wrong one and let the working component as it is in the project ... but still have the same error. it can not determine the module class of the component ... any help ??

@bisho012
Try importing all the angular dependencies first in NgModule and then import the components.
 // First import dependency modules import { BrowserModule } from '@angular/platform-browser';  import { CommonModule } from "@angular/common"; import { NgModule } from '@angular/core'; import { RouterModule, Routes } from '@angular/router'; import { HttpModule } from '@angular/http'; import { ReactiveFormsModule } from '@angular/forms'; import { BrowserAnimationsModule } from '@angular/platform-browser/animations'; import { ApplyFormPostService } from './Services/apply-form-post.service'; import { NavBarColorService } from './Services/nav-bar-color.service'; // After import component modules import { AppComponent } from './app.component'; import { HeaderComponent } from './components/header/header.component'; import { CareerComponent } from './components/career/career.component'; import { HomeComponent } from './Components/home/home.component';
Somehow this solved the  AOT compilation error throwing Cannot determine the module for class --- in production mode

Check file name,  like here "Email.component" to "email.component"
import { EmailComponent } from './Email.component';
TO
import { EmailComponent } from './email.component';
Done!


Circular dependency warning when using @sveltejs/adapter-node

[x] Before posting an issue, read the FAQ and search the previous issues.

Description
When using SvelteKit, vite build gives Circular dependency warning:

The build finishes and is working though.
Would be great to find a way to get rid of it 🙌
sveltekit-superforms - 2.3.0
@sveltejs/adapter-node - 4.0.1
@sveltejs/kit - 2.5.0
svelte - 4.2.11

Try to reproduce it without Superforms, as it seems related to zod-to-json-schema.

I'm also wondering why I even have this error, I don't use zod with superforms or anywhere in the app 🤔

All packages are installed, but only the ones used will be bundled. What happens if you uninstall zod-to-json-schema?

Gives an error since I don't use the package directly

I don't get the warning when building, so if you have a repo that reproduces it, I'll take a look.

@ciscoheat sure, I've added a reproduction with screenshot: https://github.com/vladshcherbin/svelte-superforms

As mentioned in the other issue, it doesn't happen when using pnpm. Haven't used yarn, so maybe it can be configured to handle it.

So when using pnpm this issue still appears for me, likewise the vinejs issue (in #351) with @dns/promises.
The build time is greatly increased here too (without super forms, 46sec for this project and with, 1min 52sec) as it does appear to be bundling them in the first stage, even if they were removed in the second.
I'm probably being very stupid, but I too don't see a way to remove these "optional" dependencies, they're in the pnpm-lock with the tag of optional: true, but is very much still installed and there. Using ppm install --no-optional seems to break the build entirely and shouldn't be required:
#10 17.89<EMAIL_ADDRESS>postinstall$ node install.js
#10 18.25<EMAIL_ADDRESS>postinstall: [esbuild] Failed to find package "@esbuild/linux-x64" on the file system
#10 18.25<EMAIL_ADDRESS>postinstall: This can happen if you use the "--no-optional" flag. The "optionalDependencies"
#10 18.25<EMAIL_ADDRESS>postinstall: package.json feature is used by esbuild to install the correct binary executable
#10 18.25<EMAIL_ADDRESS>postinstall: for your current platform. This install script will now attempt to work around
#10 18.25<EMAIL_ADDRESS>postinstall: this. If that fails, you need to remove the "--no-optional" flag to use esbuild.
#10 18.25<EMAIL_ADDRESS>postinstall: [esbuild] Trying to install package "@esbuild/linux-x64" using npm

Isn't just having them as a peerDependency enough so that they're not installed by default? I note that for example @vinejs/vine is both optional and peer.

One minute extra for bundling (and removing) 5-6 extra libraries seems quite strange. The packaging system is complicated, bordering on complex, so removing them from optional causes other issues, resulting in having to add the "middleman" packages such as the JSON Schema generator (specific for each validation library) also as a peerDependency.
The most convenient has been to keep them in both, and I haven't heard of any build problems until now, so if you can check further what's going on, and be quite certain that it doesn't have to do with anything else in the build, that would help me figure things out.

problem will happen when we use @sveltejs/adapter-node

yeah, me too.

+1
Any update/patch for this issue?
Happens with valibot & adapter-node

I hope splitting the adapters into separate packages will improve things in v3. But again, the build/package system is complicated so the problem may lie elsewhere.

This issue is likely causing our builds to break with vite.

We also have this issue, and it is causing build issues.  If I manualy pin the zod-to-json-schema version in package.json to "3.23.3" - then I do not get the circular dependency any more.
Removing the optional dependency resulted in other build errors, unfortunately.

any update on this issue?


Fix run-tests.py typos

What changes were proposed in this pull request?
The PR fixes typos in an error message in dev/run-tests.py.

Can one of the admins verify this patch?

"Can't" isn't a typo; the other one is. This is pretty trivial, but hey.

Jenkins test this please

Ok, I know, my other intention was to unify it with the rest of the messages (other messages use "cannot" instead of "can't").

Test build #52315 has started for PR 11467 at commit d163068.

Test build #52315 has finished for PR 11467 at commit d163068.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52315/
Test PASSed.

Merged to master


couldn't read from device

[*] I have read the FAQ.
[*] I have searched in existing issues.

Environment

OS: Ubuntu 21.04
scrcpy version: 1.17
installation method: apt
device model: SM-N910U
Android version: 6.0.1

Describe the bug
On errors, please provide the output of the console (and adb logcat if relevant).
$ scrcpy
INFO: scrcpy 1.17 <https://github.com/Genymobile/scrcpy>
adb: error: failed to copy '/usr/share/scrcpy/scrcpy-server' to '/data/local/tmp/scrcpy-server.jar': couldn't read from device
/usr/share/scrcpy/scrcpy-server: 0 f...ed. 0.0 MB/s (34012 bytes in 5.013s)
ERROR: "adb push" returned with value 1

$ adb devices
List of devices attached
4100f705c834a135	device

It looks like a problem on your device, that you can reproduce manually with a simple adb push ... (without scrcpy).


feat!: remove the organizationEndpoints configuration option

https://coveord.atlassian.net/browse/KIT-2381
Don't Despair
This PR touches quite a lot of files, but in many cases, these are one-line or very simple changes (e.g., removing a reference to an option that was removed, removing a now useless method...).
Context
The reasoning behind this changeset is that in most cases, the various default Coveo organization endpoints and API base URLs can be trivially resolved from the organizationId, so we typically don't need any more information than that.
For instance, given the following minimal search engine configuration:
const engine = buildSearchEngine({
  accessToken: 'my access token',
  organizationId: 'myorgid',
})

We can resolve the default Coveo organization endpoints / API base URLs to:

https://myorgid.org.coveo.com (platform org endpoint)
https://myorgid.analytics.org.coveo.com (analytics org endpoint)
https://myorgid.admin.org.coveo.com (admin org endpoint)
https://myorgid.org.coveo.com/rest/search/v2 (Search API base URL)
https://myorgid.analytics.org.coveo.com/rest/organizations/myorgid/events/v1 (next Analytics API base URL)
https://myorgid.org.coveo.com/rest/organizations/myorgid/commerce/v2 (Commerce API base URL)

However, we also support cases where the specified organization is not hosted in the default (production) environment. This is why this PR is introducing a new environment engine configuration option that defaults to prod.
For instance, given the following search engine configuration:
const engine = buildSearchEngine({
  accessToken: 'my access token',
  organizationId: 'myorgid',
  environment: 'hipaa',
})

We would resolve the default organization endpoints / API base URLs to:

https://myorgid.analytics.orghipaa.coveo.com
https://myorgid.orghipaa.coveo.com/rest/search/v2
etc.

Finally, we need to support advanced use cases where the implementer needs to proxy certain types of requests to their own server. This PR introduces the search.proxyBaseUrl, analytics.proxyBaseUrl, and commerce.proxyBaseUrl engine configuration options for that purpose.
For instance, if we receive the following search engine configuration:
const engine = buildSearchEngine({
  accessToken: 'my access token',
  organizationId: 'myorgid',
  search: {
    proxyBaseUrl: 'https://search-proxy.example.com/rest/v2',
  }
})

We would use the specified proxyBaseUrl instead of the default Search API endpoint.
The other organization endpoints and API base URLs would not be affected, i.e., they would be resolved to their respective default values.

Note that following this change in the configuration state, the ~platformUrl will always point to the default Coveo organization platform endpoint resolved for the provided organizationId and environment. The same thing goes for the admin endpoint. The~ only endpoints that can be overridden through proxyBaseUrl options are the search, analytics, and commerce endpoints. The insight, case assist, and admin endpoint cannot currently be overridden, meaning that these requests cannot be proxied. We can add the possibility to do so at a later time.
This approach has the benefit of simplifying the configuration for typical use cases and making it less error-prone, while still allowing for the same amount of flexibility for advanced use cases.
Summary of changes

Added the environment engine configuration option.

Removed the deprecated platformUrl engine configuration option (breaking).

Removed the platformUrl from the configuration state (breaking, but not for commerce).
We will now automatically resolve the correct organization endpoints at request time from the organizationId and environment in the configuration state.

Added the proxyBaseUrl configuration option on the commerce engine

Added the search.proxyBaseUrl and analytics.proxyBaseUrl engine configuration options.

Removed the organizationEndpoints engine configuration option (breaking).
The only case where one would need to manually override the default organization endpoints is if they need to proxy requests to their own server. The way to do this from now on would be to set a proxyBaseUrl "à la carte". For instance, if you only want to proxy analytics requests and use the default endpoints for the rest, now you can.

~Removed the getOrganizationEndpoints helper function from Headless, and from all packages that imported it (breaking)~

Replace the getOrganizationEndpoints helper function with the getOrganizationEndpoint parametric helper function
~This helper is no longer useful, since Headless will now resolve the default endpoints automatically under the hood.~
The new helper function serves the same purpose as the old one, but it only returns the requested organization endpoint (admin, analytics, or platform [default]). Note that it will rarely be useful, though, since we're now automatically resolving the organization endpoints under the hood.

Revisited the configuration options interface on the commerce engine to only expose relevant options (technically breaking).

Revisited the configuration getter on the commerce engine to only return relevant state properties (technically breaking).
A bit out of scope, but we were exposing options / properties for the legacy protocol on the commerce engine, which made no sense since the commerce engine only supports the new analytics protocol. We were due for a clean up. The commerce engine now has its own configuration state / slice (this is not breaking, since the state is private in the commerce engine).

~- Adjusted the way the platformUrl and various apiBaseUrl are set/updated in the configuration slice (breaking).~

@jpmarceau , @erocheleau made the following comment:

I think we should refer to a documentation page instead of having the huge comments blocks on the proxyUrls.

Do you agree?
The main pro I see to having it in the reference docs is that it's going to be more natural to keep up-to-date. E.g., if we add support for an additional endpoint, say in commerce, we'll be more likely to remember to update the related proxyUrl JS doc than to remember to update an external article on that subject.
The obvious con is that it's a bit unwieldy 😅

@jpmarceau , @erocheleau made the following comment:

I think we should refer to a documentation page instead of having the huge comments blocks on the proxyUrls.

Do you agree?
The main pro I see to having it in the reference docs is that it's going to be more natural to keep up-to-date. E.g., if we add support for an additional endpoint, say in commerce, we'll be more likely to remember to update the related proxyUrl JS doc than to remember to update an external article on that subject.
The obvious con is that it's a bit unwieldy 😅

You're right that it's unwieldy. The main thing I liked about keeping this info in the reference is that this way, it doesn't get as much visibility as if it was a full-blown documentation page. After all, we don't want to encourage users to do this. Maybe the best option would be to create a page that's not in the TOC and isn't indexable, so that we can only refer to it by link? Say, https://docs.coveo.com/en/headless/latest/usage/proxy

@jpmarceau , @erocheleau made the following comment:

I think we should refer to a documentation page instead of having the huge comments blocks on the proxyUrls.

Do you agree?
The main pro I see to having it in the reference docs is that it's going to be more natural to keep up-to-date. E.g., if we add support for an additional endpoint, say in commerce, we'll be more likely to remember to update the related proxyUrl JS doc than to remember to update an external article on that subject.
The obvious con is that it's a bit unwieldy 😅

You're right that it's unwieldy. The main thing I liked about keeping this info in the reference is that this way, it doesn't get as much visibility as if it was a full-blown documentation page. After all, we don't want to encourage users to do this. Maybe the best option would be to create a page that's not in the TOC and isn't indexable, so that we can only refer to it by link? Say, https://docs.coveo.com/en/headless/latest/usage/proxy

That would be good yea

@jpmarceau
I made a few more changes (updated the PR description accordingly), namely:

I removed the platformUrl property from the configuration state. We don't need to keep this in the state, this can be resolved from the info we already have (organizationId, environment).
I exported the getOrganizationEndpoint (singular, parametric) util function. This replaces the exported getOrganizationEndpoints (plural) function.

@jpmarceau , @erocheleau made the following comment:

I think we should refer to a documentation page instead of having the huge comments blocks on the proxyUrls.

Do you agree?
The main pro I see to having it in the reference docs is that it's going to be more natural to keep up-to-date. E.g., if we add support for an additional endpoint, say in commerce, we'll be more likely to remember to update the related proxyUrl JS doc than to remember to update an external article on that subject.
The obvious con is that it's a bit unwieldy 😅

You're right that it's unwieldy. The main thing I liked about keeping this info in the reference is that this way, it doesn't get as much visibility as if it was a full-blown documentation page. After all, we don't want to encourage users to do this. Maybe the best option would be to create a page that's not in the TOC and isn't indexable, so that we can only refer to it by link? Say, https://docs.coveo.com/en/headless/latest/usage/proxy

That would be good yea

Nice 👌
If we agree, then maybe Fred's PR can stay like this for now, and when I've created my docs page I can update the comments in ui-kit to link to my page rather than provide detailed instructions?


Touch Button C16, C17 are not working

Hi Michael,
I am using your touch extension with Calliope mini. Touch button P1, P2 are working well, however, I am not able to get C16, C17 running. Not sure what I am doing wrong. can you help me? I assume you tested all four buttons.
Thanks
Pascal

Danke für den Hinweis, da muss ich mal schauen was ich da ändern muss.

Should be fixed now (I hope)


soulseekqt: does not take keyboard input

Issue description
The program SoulseekQt does not take keyboard input.
Steps to reproduce
Open soulseekqt from the soulseekqt package. Mouse input, clicking at things, works properly. However, typing anything in a box or even trying to navigate (scrolling etc) or any other of keyboard interaction does not work -- i.e. the program seems to not receive the input at all.
Technical details
Please run nix-shell -p nix-info --run "nix-info -m" and paste the
results.
 - system: `"x86_64-linux"`
 - host os: `Linux 4.14.59, NixOS, 18.03.133029.d0c868ec17c (Impala)`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.0.4`
 - channels(root): `"nixos-18.03, nixos-unstable-18.09pre147850.2428f5dda13"`
 - channels(raskolnikov): `"nixos-18.03.133029.d0c868ec17c, nixos-unstable, nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos/nixpkgs`

Duplicate of #44419.

Ooops, I swear I did use the sear before :) Thanks @dotlambda!


Proxy Authentication Required error on login

when setting sync using my github or Microsoft accout, this error is occured
[Info  - 15:16:55.21] Logging in...
[Info  - 15:17:03.563] Exchanging code for token...
[Error  - 15:17:03.678] Proxy Authentication Required

VSCode Version: 1.51.1
OS Version: windows10 20H2/ubuntu 20.04

Steps to Reproduce:

open sync setting
select github or Microsoft

Does this issue occur when all extensions are disabled?: Yes

is there any progroess? I have the same question.

Ah, I'm using node fetch. The request is done here: https://github.com/microsoft/vscode/blob/c5a8e59db78ece97e6878e34c036347ae3b110bb/extensions/microsoft-authentication/src/AADHelper.ts#L571

That uses http/s from Node and our proxy support added to that currently does not support authentication. Except: If it's basic auth, you could try setting the HTTP Proxy user setting to a http://username:password@proxyhost value.

@chrmarti could we switch to the network stack that does honor the vscode http proxies?

Extension don't have direct access to the Chromium network stack. There is the '_workbench.downloadResource' command to allow for simple GET requests, but no command yet for POST requests.
Ideally we would implement support for proxy auth in our existing proxy support for the Node.js API, but I don't have a timeline for that at the moment. (That would also benefit all other extensions.)

@fromthewoods Have you tried setting the HTTP Proxy user setting to a http://username:password@proxyhost value?

@chrmarti yes that works, but I'd rather not have to expose my password in env variables.

All vscode extensions, including the Microsoft and GitHub Authentication extensions, still suffer from a lack of solution - is there a path forward to making extensions use Chromium's Fetch, which is aware of OS level proxy settings, instead of Node's fetch, which doesn't really honor settings.json proxy settings?
Perhaps @TylerLeonhardt, you in a place to push the team on this, as I guess you might be closest to the telemetry on failed attempts, especially due to proxy problems?

@fromthewoods just to be clear, @chrmarti was recommending setting http.proxy the VS Code setting. Not an environment variable. I don't think that should influence running Chocolatey commands. Unless I'm misunderstanding what you're saying?

@MH-ABE Maybe join https://github.com/microsoft/vscode/issues/177139 as that is about certificates.

https://marketplace.visualstudio.com/items?itemName=ukoloff.win-ca

https://marketplace.visualstudio.com/items?itemName=ukoloff.win-ca

/duplicate https://github.com/microsoft/vscode/issues/12588

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!


build-server: fix Erlang download link

Signed-off-by: Matteo Cafasso<EMAIL_ADDRESS>

@noxdafox somehow live in your fork was over 2K commits behind. Consider pulling before you create your topic branch. Thank you :)

This effectively cannot be rebased (in a few minutes), I will apply it manually.

When I pulled, I had some conflict which I did not notice. Hence I assumed noxdafox/live was up-to-date.
My apologies for that.


istioctl create does not validate input parsed correctly

For example, if it is passed
name: ratings-delay
spec:
  destination: ratings.default.svc.cluster.local
  tags:
    version: v1
  http_fault:
    headers:
      Cookie:
        regex: "^(.*?;)?(user=jason)(;.*)?$"
    delay:
      fixed_delay:
        percent: 100
        fixed_delay_seconds: 7.0

it does not complain but creates a destination-policy will empty delay and Cookie.  If the YAML doesn't go into the protobuf the CLI should reject it with a message such as "cannot parse proto message: unknown field ..."

I noticed that match does not work properly either:
Problem 1)
create:
type: route-rule
name: reviews-test-v2
spec:
  destination: reviews.default.svc.cluster.local
  precedence: 2
  match:
    httpHeaders:
      Cookie:
        regex: "^(.*?;)?(user=jason)(;.*)?$"
  route:
  - tags:
      version: v2

list:
kind: route-rule
name: reviews-test-v2
namespace: default
spec:
  destination: reviews.default.svc.cluster.local
  match: {}
  precedence: 2
  route:
  - tags:
      version: v2

Problem 2)
create:
type: route-rule
name: reviews-test-v2
spec:
  destination: reviews.default.svc.cluster.local
  precedence: 2
  match:
    http_headers:
      Cookie:
        regex: "^(.*?;)?(user=jason)(;.*)?$"
  route:
  - tags:
      version: v2

list:
kind: route-rule
name: reviews-test-v2
namespace: default
spec:
  destination: reviews.default.svc.cluster.local
  match:
    httpHeaders:
      Cookie: {}
  precedence: 2
  route:
  - tags:
      version: v2

Maybe my examples, above, are a different issue. Note that they are VALID, just not being parsed correctly. Maybe they should be moved to a separate, higher priority, issue?

@frankbu Your issues are resolved by the fix.  I did not push three binaries to git, but if you go to src/istio.io/manager/cmd/istioctl and do go build you should get an istioctl binary for your OS that supports the examples you gave here.

@esnible I confirmed it's working now.


ConnectionError: other side closed - Local: <IP_ADDRESS>:45384, Remote: <IP_ADDRESS>:32847 with Elasticsearch module

Expected Behaviour
Specify a custom 8.X image and have it work
Actual Behaviour
Image is pulled but I'm greeted with the error in the title
Testcontainer Logs
ConnectionError: other side closed - Local: <IP_ADDRESS>:45384, Remote: <IP_ADDRESS>:32847

Amazing! Thanks for your response! Solved my issue


Remove empty else branch

By the way, I found this with Clippy — it was the only thing it found, so the code should now be Clippy warning free 🙂


Question about external dependencies in workflows defined with hera

Hello, I am attempting to write a workflow that requires external dependencies. For example, if I have a simple step like this that imports pandas as a dependency,
def hello():
    import pandas as pd

    print("Hello")

service = WorkflowService(
    host=host, token=auth_token, namespace="argo-production"
)
with Workflow(
    "hello-hera",
    service=service,
) as w:
    Task("t", hello)

w.create()

how would tell I hera that this is a dependency required by my workflow? Is this possible at all? Or do I need to use a docker image with a python environment already loaded into it?
Metaflow tries to solve this, but it's still not ideal as the only supported environment is conda.

@dbragdon1 we have been using external dependencies by specifying a custom docker image in the image parameter for the task, since even for a python function, it just uses a default python docker image

The user has to supply or refer to an image with the environment. For pandas, there are readily available public images with this package included.
But even if this would be a feature, would you really want your argo-jobs to have to install the environment every time you triggered a job? This would be a waste of compute and time.

@dbragdon1, did the above discussion help with the understanding of why the scenario you describe needs a custom container? Is there anything in Hera that could have made this clearer, perhaps?

@dbragdon1, did the above discussion help with the understanding of why the scenario you describe needs a custom container? Is there anything in Hera that could have made this clearer, perhaps?

Thanks for checking in on this issue. Like I said, the type of local dependency loading that I'm looking for might be out of the scope of what hera workflows is trying to accomplish. Using an external image seems like the correct way to go as of now. Thanks again.

The user has to supply or refer to an image with the environment. For pandas, there are readily available public images with this package included.
But even if this would be a feature, would you really want your argo-jobs to have to install the environment every time you triggered a job? This would be a waste of compute and time.

Right, installing all of the packages again at every step would be a waste of time. I was more referring to a method of persisting the packages in their installed form inside of a cloud service such as s3. This could mean copying the virtual environment, in the case of package managers like poetry or venv, or simply copying the contents of the __pypackages__ directory to s3. These packages are then mounted into the relevant container as a volume during a given step, which I believe would be much faster than reinstalling them every time. If hera workflows could support this and automatically cache a project's dependencies in s3, then it would allow for a user to create a workflow with external dependencies without needing to create a separate docker image.

I would not endorse a dev-ops system that's based on caching virtual environments with mapping to python base images (not all venvs would be compatible with all images). If you're planning on deploying something to production at some point, I'd -heavily- recommend having your own container registry.
I understand the appeal for the system you're proposing if you're just testing if hera/argo would be the right tool for the job, and you've not yet setup any cloud environment. But if you're already at a point in which you have access to write to a cloud bucket, I'd imagine you're not very far away from creating a container registry either.

Going to close this issue as it is not something that will be supported in the near future (next ~6 months). However, it will be kept in the ideas stash as a potential extension of Hera! If this ends up being supported by Hera we will reference back to this original issue


Document search limit of 200 should be per group

Describe the issue
When you go to the https://datatracker.ietf.org/ search and fill in "draft" as search item, you get 1 active internet-draft and 199 RFCs.
My guess is that the RFC limit is set to less than 200, returning 199, and then next search is for drafts, and fills in the last spot with the one active draft.
I think the limit (200 in this case) should be per group (and the limit could be bit lower, like 100) for each group separately, so it would return 100 rfcs, 100 active drafts, 100 expired drafts etc.
Then there should be a way that if you have only one group visible (i.e, select only RFCs) you should be able to see all of the items, either by loading them on the fly, or with next page button (if we are going to show 10000 drafts we do not want to put them in one huge page). I will make separate ticket for this issue, so this ticket should only concentrate fixing the current code so its limit is per group.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

These limits are not just about making big page results. They are also about not making massive database queries. There is a single query right now, with a limit passed to the database. To follow this proposal, that would have to be broken into multiple queries and the results merged.

Robert Sparks writes:

These limits are not just about making big page results. They are
also about not making massive database queries. There is a single
query right now, with a limit passed to the database. To follow this
proposal, that would have to be broken into multiple queries and the
results merged.

Or do sorting in the database query, and use limit and offset in the
query. Not sure how that is done in django though, in raw sql, I have
used SELECT ... ORDER BY ... LIMIT 200 OFFSET 400; etc.
@.***


More complete format-specific test data fields

This PR adds values for all format-specific fields for each specialist document format. The values are taken from (or inspired by) real documents. This ought to give us greater confidence that fields will be specified correctly (in the schema, for instance).

Checked that all the format specific fields are represented 👍


ssh-agent plugin: identities not loaded

I have the following in my zsh config (other than the below I have very little config; only some aliases and theme settings that I don't think is relevant)
plugins=(git ssh-agent)

zstyle :omz:plugins:ssh-agent agent-forwarding on
zstyle :omz:plugins:ssh-agent identities id_rsa
zstyle :omz:plugins:ssh-agent lifetime 4h

source $ZSH/oh-my-zsh.sh

It used to work fine, prompting me for the ssh key passphrase when necessary. But recently just stopped to working and I don't get any error messages add all.
The ssh-agent seems to work fine. Because if I manually run ssh-add once it adds the identity and keeps it throughout the terminal session.
Any ideas on how to fix this? Or just search further for the error...?
Thanks in advance!

Worked like a charm! Thanks!


Can't convert 'dict' object to str implicitly

Full error
SublimeLinter: ERROR: could not launch ['/Users/Dane/node_modules/.bin/eslint', '--format', 'compact', '--stdin', '--stdin-filename', '/Users/Dane/Documents/server/server.js', {'indent': 2}]
SublimeLinter: reason: Can't convert 'dict' object to str implicitly
SublimeLinter: PATH: /Users/Dane/node_modules/.bin/eslint:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/git/bin:/usr/texbin

Not seeing anything in the issues, deprecated issues, or elsewhere online!

Sorry you are having issues. What does your SublimeLInter.sublime-settings file look like? Could you post that please?


DOC : Installation 3.3 Behave Tests - 'make images' is referenced but not defined in this doc

Description
Testing the revised installation document here: https://github.com/hyperledger/fabric/blob/master/docs/dev-setup/install.md
In step 3.3 Behave Tests,  it says:
Note, in order to run behave directly, you must run 'make images' first to build the necessary peer and member services docker images.
However, no instructions are given to run 'make images'.  If it is simply the command 'make images', why not put it here:
cd $GOPATH/src/github.com/hyperledger/fabric
make images
make behave
You'll have to ask development if that is a valid command sequence.
The page used to say run the unit tests in section 3.1 first.  I had a chat with Greg Haskins about it, and he may be appropriate to resolve this issue:
jjjjibm [5:28 PM]
I hear tell you wrote the makefile for the behave test cases as documented here: https://github.com/hyperledger/fabric/blob/master/docs/dev-setup/install.md ?
GitHub
hyperledger/fabric
fabric - Fabric is a blockchain project in Incubation proposed to the community and documented at https://goo.gl/RYQZ5N. Information on what Incubation entails can be found in the Hyperledger Proj...
Gregory Haskins [5:29 PM]
that would be a bit of an overstatement, heh, but yes
[5:29]
the makefile just launches the behave test with a one-liner
[5:29]
the real work is done outside of make
[5:30]
seeing a problem?
jjjjibm [5:30 PM]
yes.  Here is the documenation for 'behave' ...
[5:30]
3.3 Behave Tests
Behave tests will setup networks of peers with different security and consensus configurations and verify that transactions run properly. To run these tests
cd $GOPATH/src/github.com/hyperledger/fabric
make behave
Some of the Behave tests run inside Docker containers. If a test fails and you want to have the logs from the Docker containers, run the tests with this option
behave -D logs=Y
Note, in order to run behave directly, you must run 'make images' first to build the necessary peer and member services docker images.
[5:31]
Notice it says to run 'make images' first, a step which is not described on the page
[5:31]
I reckoned it meant to say run 'make unit-test' as described here:
[5:31]
3.1 Go Unit Tests
Use the following sequence to run all unit tests
cd $GOPATH/src/github.com/hyperledger/fabric
make unit-test
Gregory Haskins [5:31 PM]
well, i think it does say what I meant, but it might need to be reworded
[5:32]
“images” is a pre-requisite of “make behave”, so if you followed the first steps its done for you
jjjjibm [5:32 PM]
I got this error twice:
[5:32]
com/hyperledger/fabric$ make behave
cd peer; CGO_CFLAGS=" " CGO_LDFLAGS="-lrocksdb -lstdc++ -lm -lz -lbz2 -lsnappy" go build
go install github.com/hyperledger/fabric/peer: open peer: text file busy
make: *** [peer] Error 1
vagrant@hyperledger-devenv:v0.0.9-5cd67fd:/opt/gopath/src/github.com/hyperledger/fabric$
Gregory Haskins [5:32 PM]
what i was trying to say was “if you want to run behave on your own, thats cool, but make sure you build the pre-requisites yourself with ‘make images'
jjjjibm [5:32 PM]
Right before trying make behave, I ran make unit-test which seems to run ok
[5:33]
except for one timeout
Gregory Haskins [5:33 PM]
ive not seen that error before, but from the report it seems like perhaps you have a peer still running?
jjjjibm [5:33 PM]
I do ... it's never made a difference before.  Should I cancel the peer and try again?
Gregory Haskins [5:33 PM]
it seems that way
[5:34]
i suspect its because make it trying to satisify the prereq and you ahve it running
[5:34]
prior, there was no make file so no rebuild would have been attempted
[5:34]
now, whether the rebuild is the right thing to do is another matter, heh
jjjjibm [5:34 PM]
AFter cancelling peer:
[5:34]
com/hyperledger/fabric$ make behave
cd peer; CGO_CFLAGS=" " CGO_LDFLAGS="-lrocksdb -lstdc++ -lm -lz -lbz2 -lsnappy" go build
Running behave tests
Feature: lanching 3 peers # peer_basic.feature:11
As a HyperLedger developer
I want to be able to launch 3 peers
Scenario: Peers list test, single peer issue #827                            # peer_basic.feature:16
Given we compose "docker-compose-1.yml"                                    # steps/peer_basic_impl.py:121
Gregory Haskins [5:35 PM]
right now, its overly conservative and assumes we should always rebuild the peer
[5:35]
ill see if I can make it smarter
jjjjibm [5:35 PM]
So, what words need to go into my issue against the doc?  That 'make images' appearing out of nowhere?  Could I have simply typed 'make images' before typing 'make behave'?
Gregory Haskins [5:35 PM]
for the time being, workaround is dont leave a peer running
jjjjibm [5:35 PM]
yeah, I have a problem with that.  The doc doesn't remind you to cancel the peer
Gregory Haskins [5:36 PM]
yes, you could have done “make images behave”, it just would be redundant
[5:36]
make behave is a superset with images
jjjjibm [5:36 PM]
I was thinking 'make images'   'make behave'
Gregory Haskins [5:36 PM]
note that its always been a prerequisite to stop the peer before running behave though, make didnt change that
[5:37]
there is no functional difference between the two (make images; make behave == make images behave)
jjjjibm [5:37 PM]
Now I'm confused.  The web page says to run 'make images' first?
Gregory Haskins [5:37 PM]
in fact, you could add “make behave” to that tuple since images is implied
[5:37]
oh, let me look
jjjjibm [5:37 PM]
Ok
Gregory Haskins [5:38 PM]
im not seeing that
[5:38]
theres three occurances of “images” and they are all in the note about running behave by hand
[5:39]
am i missing some?
jjjjibm [5:39 PM]
Look for this on the page:
[5:39]
Note, in order to run behave directly, you must run 'make images' first to build the necessary peer and member services docker images.
Gregory Haskins [5:39 PM]
yep, those are the three I see
jjjjibm [5:39 PM]
As far as I can tell, that's the first reference to 'make images'
[5:40]
YOu just said (I think) I DON'T need to type 'make images' but the page says type 'make images'
Gregory Haskins [5:40 PM]
ok, theres two things going on here
[5:40]

full automated mode, aka “make behave”….for this mode, no, you dont need to run make images

[5:41]
2) manual mode, where you launch behave yourself…for this mode, you need to ensure that you run “make images” prior to running behave yourself
jjjjibm [5:41 PM]
Ah, I thought 'run behave directly' meant run it first thing :slightly_smiling_face: not run outside of make
[5:42]
first thing as oppposed to running unit-tests first
Gregory Haskins [5:42 PM]
right, and if that isnt clear we should fix the doc
jjjjibm [5:42 PM]
Is running make unit-test now optional/not required?
Gregory Haskins [5:42 PM]
yeah, if you run unit-tests, that also builds the images
[5:43]
correct, to run behave, you can run the “make images”, or “make unit-tests” which also runs “make images” for you
jjjjibm [5:43 PM]
Ok.  I  am going to gut issue 1511 and paste this chat into it!
Gregory Haskins [5:43 PM]
ok
jjjjibm [5:43 PM]
Because it brings up more nuances of the problem.
[5:43]
Thanks!
Gregory Haskins [5:44 PM]
ok, apologies for any grief this caused…it was a find/replace edit of the old instructions so maybe some nuance was lost in translation
jjjjibm [5:44 PM]
That's why we test :slightly_smiling_face:

I 'make images behave',got errors:
make: Nothing to be done for images'.
cd peer; CGO_CFLAGS=" " CGO_LDFLAGS="-lrocksdb -lstdc++ -lm -lz -lbz2 -lsnappy"
go build
Running behave tests
/bin/sh: 1: behave: not found
make: *** [behave] Error 127`

@cophey It seems now 'make behave' will build images automatic in my local, could you try 'make behave' directly?

@GrapeBaBa There is some worng with my environment.There is no pip and behave command.I install manually,and then i try again.thanks anyway.


Fixed few typos and grammar

Proposed changes
I fixed a short list of typos and grammatical errors in README file.
Checklist

[x] I have read the CONTRIBUTING doc

Coverage remained the same at 95.395% when pulling 31c9212bc0c265dbf81893a7e76364654b3a849a on begueradj:fix/readme into a8a75ce92a480dd97cf3df025aa79135e06ea059 on adonisjs:develop.

Thanks! 💜


fix(build): temporarily remove drag support in customize cols

Contributes to https://github.com/carbon-design-system/ibm-products/issues/3446
Because of the known issues discovered from the latest version of react-dnd not supporting commonjs support, we need to remove react-dnd from our library. This PR removes react-dnd and the dragging functionality of the customize columns Datagrid extension, until we find a solution that has both ESM/commonjs.
What did you change?
.yarn/cache/hoist-non-react-statics-npm-3.3.2-e7b709e6c1-b153827042.zip
packages/ibm-products/package.json
packages/ibm-products/src/components/Datagrid/Datagrid/DraggableElement.js
packages/ibm-products/src/components/Datagrid/Datagrid/addons/CustomizeColumns/Columns.js
packages/ibm-products/src/components/Datagrid/Datagrid/addons/CustomizeColumns/DraggableItemsList.js
yarn.lock

How did you test and verify your work?
Verified customize columns story still loads but does not include dragging behavior and tested that yarn build successfully runs

Add this to both of the customize columns stories.


build of OpenBLAS-0.3.28 fails conditional on BUILD_LAPACK_DEPRECATED = 0

Building OpenBLAS 0.3.28 on Linux (x86_64) using gcc 14.2.1, I run into an error at the linker_test stage if BUILD_LAPACK_DEPRECATED is set to 0 (I have no use for deprecated Lapack functions). The message is that the symbols for various deprecated functions are undefined. Setting BUILD_LAPACK_DEPRECATED=1 solves the problem, but it seems like a bug in the build process.

This is probably related to Reference-LAPACK deprecating a few functions some months ago, which may not have been accurately reflected in our linktest at the time (i.e. probably broken since about 0.3.25)

OK, not a big deal.


Seis-prov hash IDs

We're starting to use ASDF and seis-prov for some strong motion data processing code we're writing. In the seis-prov documentation (see here: http://seismicdata.github.io/SEIS-PROV/_generated_details.html#seis-prov-ids)
it states that the third element of a seis-prov id is:
"A 7 to 12 letter lowercase alphanumeric hash to ensure uniqueness of ids."
What is the intended use of this hash, and what is the domain where the uniqueness is being considered? Is it just within the document, or across a span of them?

What is the intended use of this hash, and what is the domain where the uniqueness is being considered? Is it just within the document, or across a span of them?

The hash is really just needed to be able to generate unique ids for every piece of the provenance information. In an ideal scenario it should of course be globally unique with a central registry but that will not happen any time soon so for now this id should be unique at least per W3C PROV document and also per ASDF file (each ASDF file can contain multiple provenance documents). If you have a way to ensure uniqueness across your whole system, that would be even better.
If you see any issue with type of id please let me know!


Add the ability to persist the library as a document

Fix #16
TODO before release: backward compatibility with old library persisting logic

One thing: the library doesn't reflect the latest changes if other excalidraw files were open at the time:

open a.excalidraw and b.excalidraw
change library in a.excalidraw
switch to b.excalidraw
open the library → it doesn't reflect latest state

I'm working on it :)
This is related to #17

@dwelle this should be fixed now !


RubyMotion version

Hi !
This is not an issue. I didn't know where else to contact you to tell you that I've translated SKTUtils and the demo to RubyMotion. Let me know if you're interested in adding a RM branch. SKTUtils are awesome, thanks a lot.
Best,
Bruno.

Thanks and sorry for not having a look at this earlier, we haven't got much RubyMotion materials at raywenderlich.com as we focus primarily on Swift for our iOS tutorials. Thanks for bringing the lib to the RubyMotion community


Please support PSA required settings from value

Please add support for setting securityContext and containerSecurityContext on this chart, required by PSA restricted or baseline in  kubernetes 1.25+

All for this change. If you send me a PR I will approve.

Closing due to inactivity. Feel free to reopen once a PR is created.


[FEA] Benchmark additional file formats beyond Parquet (e.g. Avro, ORC, HDF5)

A gist with some older experiments can be found here. It probably makes sense to rerun the experiments with the latest version of cudf.


Release v0.4.1

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   14.29%   14.29%
=======================================
  Files          22       22
  Lines        2652     2652
  Branches     1318     1318
=======================================
  Hits          379      379
  Misses       1737     1737
  Partials      536      536

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 090c476...a3d93c8. Read the comment docs.


Invalid argument when handling Service Worker registration Future

I am using Dart SDK 1.17.1.
This code
import 'dart:async';
import 'dart:html';

void main() {
  Future serviceWorkerRegistration =
      window.navigator.serviceWorker.register('sw.js');

  serviceWorkerRegistration.then(
    () { print('ermagerd registered'); }
  );
}

running in Dartium results in

Exception: Invalid argument(s): Attempt to pass Function 'Closure: () => dynamic' to JavaScript via without calling allowInterop or allowInteropCaptureThis

I don't see any documentation or indication that I should be using dart:js in anyway, so I'm a little perplexed, and thinking this may be a bug.

Please re-open if this is still the case with the latest 2.0.0-dev SDK. Dartium is not supported.


chore: add .DS_Store to .gitignore

Someone, I kept adding .DS_Store files throughout the repo on mvn clean install.

You can also add this in ~/.gitignore to apply to all repos on your machine.


Prune #Bottom states when branching

Fix for change introduced by #3637, wherein branching could contain bottom states which were not being pruned. (see https://github.com/runtimeverification/pyk/pull/634#issuecomment-1707957228)

Re-ran the integration test in CI 🤞

That did not work, though... kore-exec gets killed (error 137) in a search command
krun --haskell-backend-command kore-exec --definition ./test-kompiled --search-final 2.test \
    --output-file 2.test.out --output /tmp/nix-shell.NiDd7o/.krun-2023-09-06-23-59-15-7rLPGoxTwy/result.kore  \
    --searchType FINAL --search

@goodlyrottenapple @geo2a  I've also addressed this issue by pruning the #Bottom branches in pyk right now.


shader's break animations.

Is there any kind of workaround for this, or is shaders just incompatible with any mod using geckolib? Most mobs using this, tend to just become frozen when using shaders.

This is an issue with Iris/Optifine on how they are messing with the game time which is required for the ticks we use for transitions.

I am not aware of how Iris messes with the game time at all? Could you please provide more detail?

The only thing that I can think of that would be related would be the fact that Iris has to render things like entities twice if the shader pack has shadows... but if GeckoLib breaks with that, the issue would have to be fixed in GeckoLib.

That feeling when you find a related issue and it's closed, but not fixed... sadly shaderpacks are more important than new creatures, and Naturalist is the only reason my modpack has GeckoLib.

That feeling when you find a related issue and it's closed, but not fixed... sadly shaderpacks are more important than new creatures, and Naturalist is the only reason my modpack has GeckoLib.

What?

That feeling when you find a related issue and it's closed, but not fixed... sadly shaderpacks are more important than new creatures, and Naturalist is the only reason my modpack has GeckoLib.

it's fixed on 1.19.4 gecholib.

Well, I'm on 1.19.2 and it works when I disable shaders in Iris, and breaks again when enabled again.
Can't really move to .4, I hope there will be an update for the .2 version eventually

Well, I'm on 1.19.2 and it works when I disable shaders in Iris, and breaks again when enabled again. Can't really move to .4, I hope there will be an update for the .2 version eventually

most mods don't backport, especially api's, it's probably only fixed to .4 onwards


Updated AriesOpenAPIDemo.md

Added screenshots from @sklump
Signed-off-by: shaktishenoy<EMAIL_ADDRESS>

Codecov Report

Merging #382 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   89.12%   89.12%
=======================================
  Files         236      236
  Lines       11279    11279
=======================================
  Hits        10052    10052
  Misses       1227     1227

This is cool!  Thanks.  Will go through this shortly.
I don't know if you would be interested in doing this, but I'd like to get this OpenAPI demo so that instead of using the /send endpoint for issuing, it uses the full offer/request/response protocol.
We'll be updating it shortly to use the --events and --no-auto parameters so that the developer learns about what the webhook messages look like and how data can be pulled from those to populate the requests sent to the endpoints.

This is cool! Thanks. Will go through this shortly.
I don't know if you would be interested in doing this, but I'd like to get this OpenAPI demo so that instead of using the /send endpoint for issuing, it uses the full offer/request/response protocol.
We'll be updating it shortly to use the --events and --no-auto parameters so that the developer learns about what the webhook messages look like and how data can be pulled from those to populate the requests sent to the endpoints.

Sure! Let me know when the changes are done.


Add shape-based lazy init to LinenToNNX (prev LinenWrapper)

Renamed wrappers to LinenToNNX and NNXToLinen to minimize confusion.
Moved state initialization of LinenToNNX to __call__ to realize lazy init. This allows it to be a submodule of an NNX module, which doesn't have input args during initialization.

User can use nnx.shaped_init to do a dry run of __call__ and initialize the whole state & full graphdef.

Made state initialization of LinenToNNX nested & closer to NNX, aka. each VariableState is created for every jax Array, not every collection.

Codecov Report
Attention: Patch coverage is 0% with 31 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (31adb00) to head (2c8963d).
Report is 91 commits behind head on main.

Files
Patch %
Lines

flax/nnx/nnx/bridge/wrappers.py
0.00%
28 Missing :warning:

flax/nnx/nnx/bridge/__init__.py
0.00%
3 Missing :warning:

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4081    +/-   ##
======================================
  Coverage   0.00%   0.00%
======================================
  Files        106     108     +2
  Lines      13582   13948   +366
======================================
- Misses     13582   13948   +366

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Issues with database backend if IPv6 address provided

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
When setting the "DB_HOST" database migration fails due to the IPv6 Address being interpreted incorrectly.
Ignore that mysql binaries are missing the important part is that the migrate commands does not work due to the IPv6 address being read as a IPV4 with the : as the divider.
Exact BookStack Version
v22.10
Log Content
root@b0e397e9c977:/app/www# export DB_HOST="XXXX:NNA:ZZZZ:::abc"
root@b0e397e9c977:/app/www# php artisan db
sh: exec: line 1: mysql: not found
Symfony\Component\Process\Exception\ProcessFailedException
The command "'mysql' '--host=XXXX' '--port=NN' '--user=' '--password=' '--default-character-set=utf8mb4' 'bookstack'" failed.
Exit Code: 127(Command not found)
Working directory: /app/www
Output:
Error Output:
at vendor/symfony/process/Process.php:272
268▕      */
269▕     public function mustRun(callable $callback = null, array $env = []): self
270▕     {
271▕         if (0 !== $this->run($callback, $env)) {
➜ 272▕             throw new ProcessFailedException($this);
273▕         }
274▕
275▕         return $this;
276▕     }
  +14 vendor frames

15  artisan:37
Illuminate\Foundation\Console\Kernel::handle()
PHP Version
No response
Hosting Environment
Podman 3.0
Rockylinux 8.6
Linuxserverio container

Hi @i-cannot-decide-on-a-username,
Yeah, I don't think our database host handling is IPv6 friendly right now, and never had this previously arise or be requested.
I have not tested this, but if really needed right now you might be able to use this unsupported/undocumented workaround via instead using:
DATABASE_URL="mysql://user:password@XXXX:NNA:ZZZZ:::abc"

Did try parts of that without the username and password. Our workaround became to use the IPv4 addressing instead. So I am closing this and will after-the-fact inform when we test the workaround.


Change the name of the main.nf file to clarify how to run the pipeline

Description of feature
It's not a good practice to have two main.nf scripts. It is better to name the main workflow as phaseinput.nf

I'm not sure about that.
The recent change in the template aim for modularity even at the pipeline level.
Therefore from what I understood, pipeline as well as subworkflows need to be organised the same ways as modules inside a folder corresponding to their name and in a main.nf

Unfortunately for the moment there isn't a lot of pipeline who did the move to the new template.

Thanks for your answer, I was not fully aware of the new template, I'll definitely review it.


Retrieve funding rates for FTX

The perpetual swap contracts prevent dislocation with the spot price by charging a small amount known as the funding rate, when spot price> swap price, the funding rate is negative, so that short swap holders pay long swap holders, incentivising the short swap holder to buy, and bring the swap price inline with the spot price.  When the  spot price< swap price, the funding rate is positive, so that long swap holders pay short swap holders, incentivising the long swap holder to sell, and bring the swap price inline with the spot price.
FTX calculates the predictive funding rate and is available via their API, https://docs.ftx.com/#get-funding-rates, this information is very useful for certain trades such as basis trades where you are buying the spot, selling the swap when the funding rate is positive or selling the spot, buying the swap when the funding rate is negative.
Unless there are any objections I would like to create a new set of predictive funding rate DTO objects in xchange-core and have FTX adapter pull them in to make them available for consumption via the xchange library. Any exchange that trades the swap contracts (binance, okex, bybit etc etc)  will also publish the funding rates i.e. binanace (https://binance-docs.github.io/apidocs/futures/en/#get-funding-rate-history). Think for exchanges like bitmex we have custom dto for the adapter, but given so many exchanges, think it makes more sense to pull these into the core project.

before doing any bigger implementation feel free to post some pseudocode showing the structure of those DTOs in this issues thread so we can discuss them


Update to needs of KA-AAS-Bridge

(feat) generate UUID from given seed
(chor) update to admin-shell-io serializer & model 1.2.0
(bug) fix duplicate function naming getDefinition()

(feat) add mvn pom to release artifacts instead or raw jar


Running some Spin commands from project subdirectories

It would be nice to be able to run commands like spin build and spin up from project sub-directories similar to how git works.

To be explicit, this would search for ./spin.toml, ../spin.toml, ../../spin.toml, etc. by default (when no --from is given).
Seems pretty reasonable to me. Probably worth printing a message like Using spin manifest from ../../spin.toml when this applies.


Update missing required field error severity

The default error severity for most missing required fields was too severe.

Use a severity level as the value for a :required key in a column definition instead of simply true
Update the column definitions to be mostly :critical for missing values
Keep missing fields in sources and elections at :fatal

Pivotal story: 103449132

LGTM


Seems the module doesn't work out of the box?

I have just followed the instruction from readme but getting the following error:

Warning: Failed prop type: Invalid prop `source` supplied to `Image`.
    in Image (created by ImageViewer)
    in ImageViewer (created by Transmit)
    in Transmit (created by myproject)
    in RCTView (created by View)
    in View (created by AppContainer)
    in RCTView (created by View)
    in View (created by AppContainer)
    in AppContainer (created by Modal)
    in RCTView (created by View)
    in View (created by Modal)
    in RCTModalHostView (created by Modal)
    in Modal (created by myproject)
    in myproject
    in RCTView (created by View)
    in View (created by AppContainer)
    in RCTView (created by View)
    in View (created by AppContainer)
    in AppContainer

RCTJSONStringify() encountered the following error: Invalid type in JSON write (NSURL)

Is that because my react version is too new? I have tried with 0.39 and 0.41, both failing. Thanks in advance

Invalid prop `source` supplied to `Image` seems like you set error source.
I saw the latest version of the image component, source field has not been modified, it seems like you set wrong url field.

i just use the same as those in the example...

i just copy the same source from the example

i have error same of you

+1
has anyone fix it?

i have error same of you, i just copy the same source from the example

That's true. I'm looking for reasons.

Well, don't worry, because the link address protocol in demo is blocked. There's no problem with a new address:
const images = [{
    url: 'https://avatars2.githubusercontent.com/u/7970947?v=3&s=460'
}, {
    url: 'https://avatars2.githubusercontent.com/u/7970947?v=3&s=460'
}, {
    url: 'https://avatars2.githubusercontent.com/u/7970947?v=3&s=460'
}]

It was solved? I tried a Base64 with RN 0.42 and still not work. Direct on the ImageView it works :/

@fdjiangwu Try to preset width and height? https://github.com/ascoders/react-native-image-viewer/blob/master/image-viewer/image-viewer.component.tsx#L136
const images = [{
    url: 'data:image/png;base64,.....',
    width: 200,
    height: 200
}]


Operator causing control plane outage

Hello Operator-SDK community
I'm looking for operator-sdk experts to advise me on the following problem:
We can cause a control plane outage with our custom tenant-operator (golang, operator-sdk based) [3]. The tenant-operator sets up resources for application teams (or tenants) who want to use our OpenShift platform, i.e. creates namespaces, clusterresourcequotas, limits and various other secrets and configs. After I create multiple tenants at once (e.g. 60), the control plane stops responding after a few minutes and oftentimes doesn't recover at all. Before that happens, control plane gets progressively slower, at some point causing the tenant-operator to restart because it times out when trying to renew the lease. This makes things only worse, as the tenant-operator will reconcile all it's resources again after restart, further contributing to control plane load. I have experimented by disabling various components of the tenant-operator and learned that there is no single activity the operator does that causes the control plane to flip. It is the sum of benign operations.
I have reached out to OpenShift support for help. Here is the advise I got:

Please check if you're closing those api call connections properly.
A solution would be to implement an intermediary queue between requests, it is the easiest way to throttle the requests as they hit the API server

However, I don't quite understand the recommendation, as the framework is managing connections and request queues under the hood. At least that's my understanding.
I also experimented with the API Priority and Fairness framework, but it does not seem to make any difference in the operator's ability to bring the control plane down.
Using operator-sdk v1.4.2 and OpenShift 4.8.
Thank you for any assistance or input you may have.

Looking now at rate limiting explained in https://danielmangum.com/posts/controller-runtime-client-go-rate-limiting/

HI paterczm,
It seems a problem of performance. It shows that your Operator is reached the limits of resources and has been terminated.  So, I'd like to first all suggest you check the configuration in the config/manager/manager.yml to know your limits. Also, see https://kubernetes.io/docs/concepts/configuration/manage-resources-containers
By latest see that the consumption is proportional the logic implemented as the number of kinds, namespaced watched and etc. I'd recommend you also check the design of your solution and see if it cannot be optimized.
However, it seems more a design/performance issue in the Operator itself instead of the libs used. But if you still needing help with could you provide more info such as:

Are you monitor the memory/resources usage with metrics? Was the pod terminated when it reach out the limit?
What are the limits adopted by your project?
What is the language of your project? Is that go or ansible or helm?

Hi @paterczm,

This is not a problem with the operator pod itself, but a problem with the control plane, induced by that operator. The operator pod does not terminate because it runs out of resources.

So, the pods created by your Operator(manager) when reconciling the CRs have been terminating because of reaching the limit. Am I right?
Then, you need to check its consumption to determine if the values are not good enough or if you ought to do some optimizations. You can use metrics for example.
You might need to indeed check the operand and see if this project could not be improved.
PS.: I am not sure if I can follow up you here Do not analyze load related issues in CodeReady Containers environment, as it is resource constrained and will exhibit issues even under small load. It seems very specific to your implementation and context.
However, that is very specific about the operand( images used by you ) and your project. It does not seem to have a relation with SDK or its default scaffolds. In this way, I am closing this one. However, feel free to raise new issues if you need.


subsys: shell: backends: fix for shell backend async api selection

This patch modifies the way SHELL_BACKEND_SERIAL_API_ASYNC is selected.
The current logic causes conflicts (no console output in case of issue #67184) when the user tries to use one of the UARTs in async mode, by setting CONFIG_SHELL_ASYNC_API, while using Shell with a different UART (typically the Console's one).

Hi @jakub-uC, could you please take a look? thanks.


[Question] - Font isn't rendered entirely (line chopped off at top)

Windows Terminal version
No response
Windows build number
No response
Other Software
No response
Steps to reproduce
Originally reported here.
Regardless of the font used, @romanlarrosa is always seeing the font chopped off a bit at the top. Can someone give him some pointers on how to resolve this?

Expected Behavior
A fully rendered font
Actual Behavior
A non-fully visible font (line height is lower than the font height)

@romanlarrosa can you provide some more details when asked?

This is a font problem or rather characters [char[]] (57524,57526). Try other nerd fonts.

Using "Cascadia Code PL" fixes the problem. Thank you!


536 enhancement confirmation modal for uploading docs

This PR:
Resolves #536
1.    Extends/Refactors ConfirmationModal component to accommodate more parameters for improved re-use across the app. Adds default parameters for props.
2. Refactors UploadDocumentModal to use the updated ConfirmationModal component. This replaces the use of window.confirm() in the component, as requested in #536.
3. Updates other components throughout the app that use ConfirmationModal to accommodate new params.
4. Updates/Extends tests for these updated components (ConfirmationModal.test.jsx and UploadDocumentModal.test.jsx).
Screenshots (if applicable)
Demo
https://github.com/codeforpdx/PASS/assets/55720928/871093ff-a523-4025-9541-4a9e4c0f5172
Upload Document Flow

Additional Context (optional):

The original issue that this PR addresses (#536) didn't ask for a refactor of the ConfirmationModal component, but as I started working on it, the changes seemed necessary...
The flow involves displaying the ConfirmationModal when an error is caught while attempting to add a new document. Currently, the only error that opens the confirmationModal is triggered when an existing file in the pod has the same name as the one being uploaded ("File already exists"), however, this can be extended to handle other errors as well if needed.

Future Steps/PRs Needed to Finish This Work (optional):

More tests for the UploadDocumentModal component would be great. There are some basic tests, but they don't cover any user behaviors involving uploading documents... I'm not ready to tackle this at the moment, but could make an issue if needed. The diagram I included above could be useful for this.

Love the chart! Definitely breaks down the flow of what we're aiming to do with the UploadDocumentModal. Will have a look over the code shortly.