Dotgit2

@bparees fixes for bugs that lead to the recent revert of the git clone spec validation / modification changes, as well as the addition of tests for the failing scenarios.
WRT the git mechanics behind this PR, I did a git reset HEAD~1 to undo the revert, then applied my fixes which were mods to the original changes reverted.
Please let me know if those git mechanics were wrong (and perhaps I just nuke this branch and try again with whatever git calls are proscribed.
Otherwise, PTAL

needs a rebase

the content in commit 892ee875418b7994315f0375b526049cc899879d does not look like a proper reversion of my revert.  Did you use "git revert 0cae25aa59f9b99a213a4cb9b63c4ab9974505fd" to undo my revert?
It seems like the un-revert is mixed between your two commits.

Weird - the PR comments were not embedded in line like they usually are - perhaps cause it needs a rebase.  I'll answer things here, then work on the rebase.

as I mentioned in the opening text, I was worried I did the revert wrong ... was unaware of the git revert and did a git rebase ... the results were not optimal;  I'll see if I can recover, but I may just blow away this PR/branch and retry with git revert
for base -R, see http://www.gnu.org/software/bash/manual/bashref.html#Bash-Conditional-Expressions: True if the shell variable varname is set and is a name reference.
usage/downloader:  the path was https://github.com/openshift/source-to-image/blob/master/pkg/build/strategies/sti/usage.go#L23-L24 and then https://github.com/openshift/source-to-image/blob/master/pkg/build/strategies/sti/sti.go#L105-L110 ... with the new validation, an empty string  (since there is no source url with a s2i usage) was passed into DownloaderForSource and with the more strict validation logic, an error was getting returned
I think I can map the other suggestions to their intended locations (again, the commenting on this PR is showing up in an atypical fashion for me), but I'll sort out the rebase/revert stuff first.

Weird - the PR comments were not embedded in line like they usually are - perhaps cause it needs a rebase

that's because i commented directly on your commits, not on the PR files.  I was looking at the commits individually to try to differentiate the un-reversion from your new fixes.

I see - as i am sure you saw - i nuked the pr/branch and am redoing it with
git revert - looking cleaner
On Thursday, November 5, 2015, Ben Parees<EMAIL_ADDRESS>wrote:

Weird - the PR comments were not embedded in line like they usually are -
perhaps cause it needs a rebase
that's because i commented directly on your commits, not on the PR files.
I was looking at the commits individually to try to differentiate the
un-reversion from your new fixes.
—
Reply to this email directly or view it on GitHub
https://github.com/openshift/source-to-image/pull/330#issuecomment-154277093
.

and yeah, sorry, I should have read your intro more carefully instead of jumping into the review.

No worries
On Thursday, November 5, 2015, Ben Parees<EMAIL_ADDRESS>wrote:

and yeah, sorry, I should have read your intro more carefully instead of
jumping into the review.
—
Reply to this email directly or view it on GitHub
https://github.com/openshift/source-to-image/pull/330#issuecomment-154277536
.

usage/downloader: the path was https://github.com/openshift/source-to-image/blob/master/pkg/build/strategies/sti/usage.go#L23-L24 and then https://github.com/openshift/source-to-image/blob/master/pkg/build/strategies/sti/sti.go#L105-L110 ... with the new validation, an empty string (since there is no source url with a s2i usage) was passed into DownloaderForSource and with the more strict validation logic, an error was getting returned

I'm thinking it would be better for New() to be more intelligent and know when it's being invoked for Usage and that way it could skip the downloader initialization entirely (and maybe other stuff).  Getting that complexity out of the usage path would make it less likely to get broken in the future.

for base -R, see http://www.gnu.org/software/bash/manual/bashref.html#Bash-Conditional-Expressions: True if the shell variable varname is set and is a name reference.

i'm not entirely clear on what a "name reference" is in bash (my best guess is it's checking if the value of the variable is the name of another variable) but i don't think it's what you want here"-n" should be right, or possibly -v.  At least in my quick test i couldn't get -R to return true.

(ok I got -R to return true for a variable of value "" and a completely undefined variable name, neither of which sounds like what the doc is describing the behavior to be, but either way -n is the more typical approach to check for a non-zero length value)

Ok (new) - i was originally on that path but saw the override and it looked
like an existing customizer intended for cases like this (and i would be
told toleverage it ;-) ).  I can switch gears.
On the bash options, i could not get -v or - n to do what i needed.  Will
circle back and revisit after the other comments. Thx
On Thursday, November 5, 2015, Ben Parees<EMAIL_ADDRESS>wrote:

usage/downloader: the path was
https://github.com/openshift/source-to-image/blob/master/pkg/build/strategies/sti/usage.go#L23-L24
and then
https://github.com/openshift/source-to-image/blob/master/pkg/build/strategies/sti/sti.go#L105-L110
... with the new validation, an empty string (since there is no source url
with a s2i usage) was passed into DownloaderForSource and with the more
strict validation logic, an error was getting returned
I'm thinking it would be better for New() to be more intelligent and know
when it's being invoked for Usage and that way it could skip the downloader
initialization entirely (and maybe other stuff). Getting that complexity
out of the usage path would make it less likely to get broken in the future.
for base -R, see
http://www.gnu.org/software/bash/manual/bashref.html#Bash-Conditional-Expressions:
True if the shell variable varname is set and is a name reference.
i'm not entirely clear on what a "name reference" is in bash (my best
guess is it's checking if the value of the variable is the name of another
variable) but i don't think it's what you want here"-n" should be right, or
possibly -v. At least in my quick test i couldn't get -R to return true.
—
Reply to this email directly or view it on GitHub
https://github.com/openshift/source-to-image/pull/330#issuecomment-154278826
.

Sanity check:  looking into Usage, with its calls to Cleanup, Prepare and Execute, while it does not need the downloader, it seems it would need the other artifacts set up in New (including the Ignorer and Layered, since those are called by Prepare/Execute).
Thoughts/corrections?

I think Usage is way overly complicated right now.  It looks like it has the ability to pull down remote scripts using the "-s" argument, then layer that usage script into the image via a layered build (in case that image does not have tar), then execute the resulting image.
We should just strip this down to exec'ing the image they specified with a usage command.  It seems ridiculous to run "s2i usage someimage -s remotescripts" just to get the usage information... you might as well go look at the usage script at "remotescripts" at that point.
@soltysh @mfojtik agree?

:+1:


Transfer ownsership via json api

Hi,
There's not an option to transfer ownership of a repo using the json API.
I'd like to move project to an "archive" organisation when the project is done.

Here's a workaround:
import requests
from lxml import html

LOGIN_URL = "https://git.mydomain.com/user/login"
REPO_SETTINGS_URL = "https://git.mydomain.com/{org}/{repo}/settings"
USERNAME = "admin"
PASSWORD = "password"

def get_csrf(resp):
    # Get the csrf token from the html
    doc = html.fromstring(resp.content)
    return doc.find('*//input[@name="_csrf"]').value

def transfer_ownsership(reponame, source_org, target_org):
    session = requests.Session()

    # Authenticate
    resp = session.get(LOGIN_URL)
    session.post(
        LOGIN_URL,
        data={
            "_csrf": get_csrf(resp),
            "user_name": USERNAME,
            "password": PASSWORD,
        },
    )

    # Transfer to other org
    repo_settings_url = REPO_SETTINGS_URL.format(org=source_org, repo=reponame)
    resp = session.get(repo_settings_url)
    session.post(
        repo_settings_url,
        data={
            "_csrf": get_csrf(resp),
            "action": "transfer",
            "repo_name": reponame,
            "new_owner_name": target_org,
        },
    )

# Transfer myproject from SOURCE_ORG to TARGET_ORG
transfer_ownsership('myproject', 'projects', 'archived_projects')

Will this be supported in the future?
Usecase:

developer starts a project under his username
project grows and must be added to an organisation
other devs are added to the team

Are there any other ways to cover my usecase?
Forks maybe? Hm...

This was implemented in https://github.com/go-gitea/gitea/pull/9947

Wow. Nice. :+1:


Cluster snapshot

Create snapshots of the entire cluster state before every operation (update, delete). Initially snapshots will be saved in the database as JSON.

The original use case (preserve status changes) is solved by tracking cluster status changes only.


Streamline running internal datasource parsers

Currently the internal evidence data source parsers are a set of independent python scripts in the evidence_datasource_parsers repo that need to be run manually and whose input files need to be downloaded and placed in specific directories. This makes it rather time consuming to update the data sources when multiple parsers have to be run. This tickets will cover a number of improvements:

[ ] Improve configuration of parsers: At the moment most of the parsers read input and output files from another Python module.
[ ] Build a workflow to run the desired parsers. A makefile will be created to control what parsers are run

Adding a comment in #1275 and closing this, as this is part of a bigger task

Adding a comment in #1275 and closing this, as this is part of a bigger task

Is this not a subtask of that epic?

Is this not a subtask of that epic?


Feature Request: Whitelisting instead of Blacklisting

Hey, I absolutely love this. Thank you so much for your hard work on graphql-shield. One thing that I feel would be super useful is a whitelisting in place of blacklisting feature. Locking everything down and then explicitly exposing access would go a long way to help people develop better habits, be more involved with this part of the process and I think create all around more secure systems.

Hey @gentle-noah  👋
I am so happy to hear that you love graphql-shield. I couldn't agree with you more! The first version was already whitelisting instead of blacklisting, but there were some major issues with permissions tree creation and I postponed the whole thing so that I could get users' feedback faster.
I have found the solution to previous problems and will be adding whitelisting back to the workflow as soon as possible.
Thank you so much for your feedback! 🙂

I'm pretty convinced that blacklisting is still the better default but I agree, that there should be an option to make graphql-shield whitelist-based.

@schickling - totally agree here. I think most people will find the blacklisting more helpful and easier to implement by default. There are a few industries that will find the whitelisting option more useful, which is why it would be great to have it as an option. I'm mostly thinking about any health tech that needs to be HIPPA compliant in the US and most fintech applications. Having the option makes this awesome tech much more accessible to companies in those space.

We have introduced this feature with #119. In light of it, I'll close the issue.


OnePlus 5t (dumpling) Volume/Power keys don't work in UEFI

Prerequisites

[x] Have you read the wiki?
[x] Is your device in the supported list?
[x] Does the device have a Snapdragon SOC which is supported in this repo?

Description
Volume/Power keys on OnePlus 5t (dumpling) don't work in the UEFI boot menu, which prevents navigating the menu.
(No messages/errors show upon pressing, there's just no response. The device automatically boots into the EFI shell after the timeout)
Tried release 2301.1 as well as compiling 880e0104bc35a182b88c7ad81c2b0f843aa5d202 from source, no dice.
The volume/power keys do still work in Android, and the power button works to go past the "This boot loader is unlocked" screen before booting, just not in the edk2-msm UEFI.
Wiki says UEFI buttons should be supported, so not sure if I've done something wrong, or there's an issue.
Happy to test/provide any other info that's needed, as I'd love to get this running on my old phone.

We need to fix buttondxe for it, which can be referenced using Op5

We need to fix buttondxe for it

I went straight to Cheeseburger's ButtonsDxe and the buttons worked fine.

We need to fix buttondxe for it

I used Cheeseburger's ButtonsDxe and the buttons worked fine.

Could you tell me how to do it please

Could you tell me how to do it please

I'm sorry, because the time is too far in the past. I'm not sure if I'll forget some details.
As far as I remember, all you need to do is copy the content from
https://github.com/edk2-porting/edk2-msm/blob/81e670bf6a92a8f7044b393012423f2e72ad8c43/Platform/Oneplus/msm8998/cheeseburger.fdf.inc#L2-L6
to
https://github.com/edk2-porting/edk2-msm/blob/81e670bf6a92a8f7044b393012423f2e72ad8c43/Platform/Oneplus/msm8998/dumpling.fdf.inc

Could you tell me how to do it please

I'm sorry, because the time is too far in the past. I'm not sure if I'll forget some details.
As far as I remember, all you need to do is copy the content from
https://github.com/edk2-porting/edk2-msm/blob/81e670bf6a92a8f7044b393012423f2e72ad8c43/Platform/Oneplus/msm8998/cheeseburger.fdf.inc#L2-L6
to
https://github.com/edk2-porting/edk2-msm/blob/81e670bf6a92a8f7044b393012423f2e72ad8c43/Platform/Oneplus/msm8998/dumpling.fdf.inc

And what should i do after that. I have to get the .img file somehow

have you tried edk2-msm8998


Change cloud key name helptext

Version: Master 2.2 (3/15/19) 21d45c0f8e83
What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Add a new node template or cloud key. Notice %newSecret.name.placeholder% mentions "e.g. api-key"

Result:
This is confusing to end-users. Some have reported they though they plug an api key in here.
Recommend changing to something else like "e.g. Amazon" or something.

Version: Master 2.2 (3/15/19) 21d45c0f8e83
Confirmed issue. In the UI the helptext for "Name" for the cloud credential now says "e.g. production-credentials" rather than "api-key" so users should not be confused any longer.


Board Review: Azure Communication Services (SPOOL) Navigation Bar - UI Library [iOS, Android]

Title composition:
[Team] - ACS Mobile UI Android
[Release Type] - Public Preview
[Feature to be reviewed] - NavigationBarViewData
[DevEx Internal / ARB] - DevEx
Service name:
Key contact for this review:
Link to previous API version:
-Androidazure-communication-ui-calling (version 1.1.0) - apiview.dev
-iOS https://apiview.dev/Assemblies/Review/1ce5513aaca54e5c8e86f9c982ca3f78?diffRevisionId=9ff82842d8b24a8fb14bebc34160dabb&doc=False&diffOnly=False&revisionId=997b226003c84fa0979d6adb00730799
Description of the material to be reviewed/changed: Call Title and Sub Title to be configured
Champion scenarios that briefly explain how developers will use your API:
Contoso developer is able to set Call Title and Sub Title using public API
Languages for this review: Java
Artifacts per language.
JAVA: azure-communication-ui-calling (version 1.1.0-beta.1) - apiview.dev.
We encourage you to add the meeting notes over the story discussion to track visibility and status of the review. Please keep updated the story.

#scheduled

Scheduled for 9/15 2p-4p

this is latest api view for iOS: https://apiview.dev/Assemblies/Review/1ce5513aaca54e5c8e86f9c982ca3f78?revisionId=28ead49ea4464398bbd86b23e0035c74&doc=False

Recording (MS INTERNAL ONLY)


@fix/doc 1.9 change

Changes in this PR:

Inclusion of third party provider (ie Spheron)
Info about dApps Boilerplate
Validator page changes
Added feedback widget
Minor Changes overall the pages


[SPARK-39566][CORE][YARN] Improve YARN cluster mode to support IPv6

What changes were proposed in this pull request?
This PR aims to improve YARN cluster mode to support IPv6.
After this PR, all YARN unit tests pass.
Why are the changes needed?
BEFORE
$ SBT_OPTS='-Djava.net.preferIPv6Addresses=true' SPARK_LOCAL_HOSTNAME=::1 build/sbt "yarn/testOnly *.YarnClusterSuite" -Pyarn
[info] YarnClusterSuite:
[info] - run Spark in yarn-client mode (10 seconds, 204 milliseconds)
[info] - run Spark in yarn-cluster mode *** FAILED *** (2 seconds, 88 milliseconds)
[info]   FAILED did not equal FINISHED (stdout/stderr was not captured) (BaseYarnClusterSuite.scala:240)
...

AFTER
$ SBT_OPTS='-Djava.net.preferIPv6Addresses=true' SPARK_LOCAL_HOSTNAME=::1 build/sbt "yarn/testOnly *.YarnClusterSuite" -Pyarn
[info] YarnClusterSuite:
[info] - run Spark in yarn-client mode (10 seconds, 204 milliseconds)
[info] - run Spark in yarn-cluster mode (10 seconds, 118 milliseconds)
[info] - run Spark in yarn-client mode with unmanaged am (7 seconds, 99 milliseconds)
[info] - run Spark in yarn-client mode with different configurations, ensuring redaction (8 seconds, 92 milliseconds)
[info] - run Spark in yarn-cluster mode with different configurations, ensuring redaction (10 seconds, 117 milliseconds)
[info] - yarn-cluster should respect conf overrides in SparkHadoopUtil (SPARK-16414, SPARK-23630) (9 seconds, 113 milliseconds)
[info] - SPARK-35672: run Spark in yarn-client mode with additional jar using URI scheme 'local' (8 seconds, 113 milliseconds)
[info] - SPARK-35672: run Spark in yarn-cluster mode with additional jar using URI scheme 'local' (9 seconds, 119 milliseconds)
[info] - SPARK-35672: run Spark in yarn-client mode with additional jar using URI scheme 'local' and gateway-replacement path (8 seconds, 97 milliseconds)
[info] - SPARK-35672: run Spark in yarn-cluster mode with additional jar using URI scheme 'local' and gateway-replacement path (10 seconds, 108 milliseconds)
[info] - SPARK-35672: run Spark in yarn-cluster mode with additional jar using URI scheme 'local' and gateway-replacement path containing an environment variable (9 seconds, 111 milliseconds)
[info] - SPARK-35672: run Spark in yarn-client mode with additional jar using URI scheme 'file' (8 seconds, 103 milliseconds)
[info] - SPARK-35672: run Spark in yarn-cluster mode with additional jar using URI scheme 'file' (9 seconds, 108 milliseconds)
[info] - run Spark in yarn-cluster mode unsuccessfully (7 seconds, 126 milliseconds)
[info] - run Spark in yarn-cluster mode failure after sc initialized (15 seconds, 121 milliseconds)
[info] - run Python application in yarn-client mode (10 seconds, 113 milliseconds)
[info] - run Python application in yarn-cluster mode (11 seconds, 116 milliseconds)
[info] - run Python application in yarn-cluster mode using spark.yarn.appMasterEnv to override local envvar (11 seconds, 122 milliseconds)
[info] - user class path first in client mode (8 seconds, 103 milliseconds)
[info] - user class path first in cluster mode (9 seconds, 110 milliseconds)
[info] - monitor app using launcher library (4 seconds, 15 milliseconds)
[info] - running Spark in yarn-cluster mode displays driver log links (12 seconds, 125 milliseconds)
[info] - timeout to get SparkContext in cluster mode triggers failure (11 seconds, 112 milliseconds)
[info] - executor env overwrite AM env in client mode (7 seconds, 101 milliseconds)
[info] - executor env overwrite AM env in cluster mode (10 seconds, 108 milliseconds)
[info] - SPARK-34472: ivySettings file with no scheme or file:// scheme should be localized on driver in cluster mode (17 seconds, 202 milliseconds)
[info] - SPARK-34472: ivySettings file with no scheme or file:// scheme should retain user provided path in client mode (14 seconds, 190 milliseconds)
[info] - SPARK-34472: ivySettings file with non-file:// schemes should throw an error (1 second, 917 milliseconds)
[info] Run completed in 4 minutes, 51 seconds.
[info] Total number of tests run: 28
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 28, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 352 s (05:52), completed Jun 23, 2022, 2:40:50 AM

Does this PR introduce any user-facing change?
No, there is no change to IPv4 users.
How was this patch tested?
Pass the CIs and do the manual testing with the above command.

Thank you, @wangyum ! Merged to master.


Introduce a dedicated unconfined AA policy

By using the 'unconfined' policy for privileged
containers, we have inherited the host's apparmor
policies, which really make no sense in the
context of the container's filesystem.
For instance, policies written against
the paths of binaries such as '/usr/sbin/tcpdump'
can be easily circumvented by moving the binary
within the container filesystem.
Fixes #5490 #14550
Signed-off-by: Eric Windisch<EMAIL_ADDRESS>

I've done testing to make sure this doesn't break docker-in-docker, but some more through testing by users would be great. Users may invoke the old behavior using '--privileged --security-opt apparmor:unconfined'

Fixes https://github.com/docker/docker/issues/14550 and https://github.com/docker/docker/issues/5490

/cc @duglin @stefanberger @salmanbaset

@tianon This PR will "stop profiles like mysqld from bleeding into containers and applying to processes that they shouldn't".
See #14864 for a policy for the docker binary, hardening against attacks against the engine itself (whether via vulnerabilities in image pulls / extraction, or some other vectors)

:metal: :heart: LGTM

LGTM


chore: make Screener great again

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Perf comparision

Scenario
Fluent TPI
Fabric TPI
Ratio
Iterations
Ticks

Button.Fluent
1.33
0.13
10.23:1
5000
6643

Checkbox.Fluent
1.42
0.26
5.46:1
5000
7093

Icon.Fluent
0.26
0.03
8.67:1
5000
1283

Slider.Fluent
1.82
0.28
6.5:1
5000
9119

  Generated by :no_entry_sign: dangerJS

Closing as it will never happen


MINOR: Follow up for KAFKA-6761 graph should add stores for consistency

While working on 4th PR, I noticed that I had missed adding stores via the graph vs. directly via the InternalStreamsBuilder.  Probably ok to do so, but we should be consistent.
For testing, I ran the existing tests in streams.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ping @guozhangwang @mjsax for reviews

I tried to kick-off system tests, but can't for now, I will run system tests when available.

A meta question: although these two functions are part of InternalStreamsBuilder.java, they are actually used for adding stores directly to the topology, hence not really part of the DSL. Hence do we really want to add them to the logical graph?

I had the same thoughts, but I wasn't sure, so I erred on the side of consistency.
I'm not married to this proposal, so if we decide that we don't want to add them to the logical graph, I can close this PR.

Personally I think we do not need to add it into the logical graph, but we do need to make sure they are book-kept somewhere so that in the final physical topology building process they are added.

I've updated the StateStoreNode to have the same behavior as the InternalTopologyBuilder.addStateStore method.
I'm still on the fence with adding this to the graph, but thought that pushes me towards including them in the graph is to have our logic for building a topology in one place.

retest this please

Retest this please

LGTM.

Could we discuss about this PR a bit more? Currently I still feel it is not necessary to add logical nodes for state stores as they are specifically added by users and hence would not be optimized at all.

Sure.
I see one potential usage, that we can check if all stores are used by at least one processor -- if not, throw an exception and die, to warn the user about a bad topology, ie, dangling store.

Sure.
I see one potential usage, that we can check if all stores are used by at least one processor -- if not, throw an exception and die, to warn the user about a bad topology, ie, dangling store.

I agree it is still straight-forward logically, and if people feel the additional classes are worth to add, I'm happy as well :)

updated this to override toString()

updated this

Just realized, that this PR also unlocks https://issues.apache.org/jira/browse/KAFKA-6998 -- was good to merge it :)


hmset() : redisClient.hmset is not a function

Description
redisClient.hmset is not a function, Has the hmset function been removed?

Yep! According to the official Redis docs, as of Redis 4.0.0 HMSET is deprecated and was removed from this project, as explained in #1746 and a few other issues. Thankfully it seems HSET supports setting multiple values, so the functionality remains.


bara, etymologize

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 5
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[b,e]

/trunk merge


x/vgo: go list should avoid downloads when possible

What version of Go are you using (go version)?
go version devel +104445e Wed Feb 7 19:22:09 2018 +0000 linux/amd64 vgo:2018-02-20.1
What did you do?
vgo list ./...

What did you expect to see?
I expected it to list the packages under the current path.
I would expect this to happen without any need to update or resolve dependencies.
What did you see instead?
It started to resolve imports by fetching dependencies.
% vgo list ./...
vgo: finding gopkg.in/tomb.v2 v0.0.0-20161208151619-d5d1b5820637
vgo: finding gopkg.in/retry.v1 v0.0.0-20180116153415-2d7c7c65cc71
... etc

This is somewhat related to https://github.com/golang/go/issues/24749 (just updated that issue with a standalone example) - although I think there's another issue at play there on top of the behaviour being discussed in this issue.
Having had a go at an implementation for https://github.com/golang/go/issues/24661, my gut feeling is that vgo list should not download by default. Not because of anything per se in https://github.com/golang/go/issues/24661 (although that command, if implemented, should never download), but just a gut feel. Therefore vgo list and whatever is done for https://github.com/golang/go/issues/24661 will need to indicate that their output is incomplete; with DepsErrors as appropriate.
That said, I think vgo list should gain a -download-esque flag that will ensure all dependencies listed in go.mod files encountered are present, even binary dependencies.

Having used this for a while, I think list downloading is the right default, both for list and for all the other go commands. That said, if you want to turn off downloading in the list command (or any other command that takes build flags), use -getmode=local.


refactor!: extract RPC definitions into here

Add the rpc types and handler to docs, from iroh.
Really, this does add the rpc types and handler to docs, from iroh! Two lines to make check-cc happy.
Breaking changes:
spawn now takes 7 parameters instead of 6
Note:
I reverted the author_default() thing. Not that there was anything wrong with this, but I think breaking less code is good.

some small things, otherwise LGTM


Remove query string number from font URLs

I'm using the HTML5 application cache manifest and it's annoying to change it every time the Fontello font is updated.
Here's a similar bug in the Font Awesome project: https://github.com/FortAwesome/Font-Awesome/issues/3286

Just use css file with codes only and write your own font definition.

This way, if fontello.css gets improved I don't get the update. I have to manually keep my copy in sync. Btw, what is the rationale for the query string numbers?

The probability if such improvment is about zero :) . Timestamping (after ?) was requested by people who update regular websites.
It's impossible to include all files for all use cases. But i tried to provide build blocks to simplify customizations. Also, you can write scripts to use fontello via API and automate such things (removing & from CSS and so on).


xExchDatabaseAvailabilityGroup: Rename improper function names and add comment based help

Details of the issue
The following functions in xExchDatabaseAvailabilityGroup need to be renamed to proper Verb-Noun format. When applicable, functions should also be updated to include comment based help per: https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md
GetDatabaseAvailabilityGroup

Note that a function with name GetDatabaseAvailabilityGroup exists in the following modules. We should investigate whether these can be consolidated into a helper function in xExchangeHelper.
xExchDatabaseAvailabilityGroup
xExchMaintenanceMode
xExchWaitForDAG


Tab context menu shows entries which are not available "grayed out"

Describe the bug
Entries in the context menu are grayed out and not accessible.
Expected behavior
I think it would be better to hide inaccessible entries.
Screenshots

System Information
Edition	Windows 10 Pro
Version	20H2
Installed on	6/19/2020
OS build	19042.867
Experience	Windows Feature Experience Pack 120.2212.551.0
App: <IP_ADDRESS>

@R3voA3 we show the items grayed out to improve discoverability and to indicate that such an option exists.


System.Net.WebClient.Proxy.GetProxy fails after bad/relative URI

Steps to reproduce
(new-object System.Net.WebClient).Proxy.GetProxy("http://www.msn.com").Host
(new-object System.Net.WebClient).Proxy.GetProxy("www.msn.com").Host
(new-object System.Net.WebClient).Proxy.GetProxy("http://www.msn.com").Host
Expected behavior

Output of Proxy Server Hostname
Error: "This operation is not supported for a relative URI."
Output of Proxy Server Hostname

Actual behavior

Output of Proxy Server Hostname
Error: "This operation is not supported for a relative URI."
"www.msn.com"

This output of the URI continues until I close/reopen PowerShell
Environment data
$PSVersionTable:
Name                           Value

PSVersion                      5.0.10586.117
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.10586.117
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
$StackTrace:
PS H:> $StackTrace
at System.Uri.get_IsLoopback()
at System.Net.WebProxy.IsBypassedManual(Uri host)
at System.Net.WebProxy.GetProxy(Uri destination)
at CallSite.Target(Closure , CallSite , Object , String )

I did a little more digging, this issue only happens when I am using a PAC file from an automatic configuration script. If I manually assign a proxy server, the command behaves as expected, but with an automatic configuration script being used it behaves as posted.

Isn't this an issue with the WebClient class and not PowerShell?  Do you get expected behavior with just C#?

Here is why I think this is a PowerShell issue:
I'm using New-Object to instance a new System.Net.WebClient each time I run the command, the failure of the second command should have no impact on a New-Object
Second, the following code works:
$Source = @'
using System;
using System.Net;
public class ProxyTest
{
public static void Main()
{
using (WebClient client = new WebClient())
{
Uri myUri = new Uri("http://www.google.com");
var proxy = client.Proxy.GetProxy(myUri);
Console.WriteLine(proxy.ToString());
try
{
myUri = new Uri("www.google.com");
proxy = client.Proxy.GetProxy(myUri);
Console.WriteLine(proxy.ToString());
}
catch
{
Console.WriteLine("Expected Failure");
}
myUri = new Uri("http://www.google.com");
proxy = client.Proxy.GetProxy(myUri);
Console.WriteLine(proxy.ToString());
}
}
}
'@
Add-Type -TypeDefinition $Source -Language CSharp
[ProxyTest]::Main()
CORRECT PROXY
Expected Failure
CORRECT PROXY

It is seems the key here is using (WebClient client = new WebClient())

@iSazonov forgive me if I don't fully understand, I'm certainly not an expert nor a professional programmer...
I don't understand why using what seems to me as a fully disposable command has any impact on additional usage of that command?
(New-Object System.Net.WebClient).Proxy.GetProxy()
I'm not storing it as a variable or making any calls back to it and each time it's run I'm specifically creating a New-Object am I not?
I simply do not know enough to reproduce the issue in C# accurately / exactly the same as the supplied PowerShell would generate.

I am not an expert too.
I only suggested an experiment with replacing using (WebClient client = new WebClient()) in WebClient client = new WebClient()

Works as expected
$Source = @'
using System;
using System.Net;

public class ProxyTest
{
   public static void Main()
   {
        WebClient client = new WebClient();
        Uri myUri = new Uri("http://www.google.com");
        var proxy = client.Proxy.GetProxy(myUri);
        Console.WriteLine(proxy.ToString());
        try
        {
           myUri = new Uri("www.google.com");
           proxy = client.Proxy.GetProxy(myUri);
           Console.WriteLine(proxy.ToString());
        }
        catch
        {
            Console.WriteLine("Expected Failure");
        }
        myUri = new Uri("http://www.google.com");
        proxy = client.Proxy.GetProxy(myUri);
        Console.WriteLine(proxy.ToString());
   }
}
'@

Also works as expected:
$Source = @'
using System;
using System.Net;

public class ProxyTest
{
   public static void Main()
   {
        WebClient client1 = new WebClient();
        Uri myUri = new Uri("http://www.google.com");
        var proxy = client1.Proxy.GetProxy(myUri);
        Console.WriteLine(proxy.ToString());
        try
        {
           WebClient client2 = new WebClient();
           myUri = new Uri("www.google.com");
           proxy = client2.Proxy.GetProxy(myUri);
           Console.WriteLine(proxy.ToString());
        }
        catch
        {
            Console.WriteLine("Expected Failure");
        }
        WebClient client3 = new WebClient();
        myUri = new Uri("http://www.google.com");
        proxy = client3.Proxy.GetProxy(myUri);
        Console.WriteLine(proxy.ToString());
   }
}
'@

I think maybe that last one is a little more "what I think should be happening" based on my understanding of my use of New-Object

Adding a Try {} Catch {} to the second command does not change the PowerShell behavior either, it still just prints "www.msn.com":
Try { (new-object System.Net.WebClient).Proxy.GetProxy("www.msn.com").Host } Catch {}

I'm not able to repro the original issue making it difficult to investigate further.  I created a simple pac file:
function FindProxyForURL(url, host) {

if ( url == "www.google.com" ) {
         return "PROXY <IP_ADDRESS>";
}
else {
        return  "DIRECT";
}

}

Chrome, Edge, and IE all observe the Internet Options settings when I set that pac as the auto configure file and behaves as I expect: failing on www.google.com, working for everything else.
When using the WebClient class, it doesn't appear to use my pac at all.

@SteveL-MSFT I recreated your issue, I think...I'm not sure how you configured your stuff but here's what I found:
#1. I altered your "url ==" to "host =="
if ( host == "www.google.com" ) {
#2. When I used a local file as in file://c:\temp\test.pac both IE and WebClient ignored it. Apparently that's depreciated but Chrome still accepted it. I had to actually host it on an http:// site. Once I did both of those things the WebClient started using it...not sure how you setup your pac file...

Are there any guides out there for how one might debug an issue like this?

The original test recreate WebClient object. Then the problem is not in it. The object has Proxy property to be initialized by static method WebRequest.DefaultWebProxy This may be the place where the problem is. Next hop is here Next hop is here
Perhaps the exception in the second test, somehow "destroys" this static property or "overlaps" it.
@daxian-dbw Could you comment on this issue and  specify the right direction to fix?

This is, in fact, a CoreCLR issue (not sure if it's by design, though).
The key factor in play is how String is converted to Uri in powershell. powershell uses Uri(<uri-string>, UriKind.RelativeOrAbsolute), which is the same as used in System.UriTypeConverter.ConvertFromString(String).
Therefore, the pure C# equivalent should be like this:
void Main()
{
	System.Net.WebClient client = new System.Net.WebClient();
	Uri uri_absolute = new Uri("http://www.msn.com", System.UriKind.RelativeOrAbsolute);
	Uri uri_relative = new Uri("www.msn.com", System.UriKind.RelativeOrAbsolute);

	Console.WriteLine(client.Proxy.GetProxy(uri_absolute).Host);

	try { client.Proxy.GetProxy(uri_relative); }
	catch { Console.WriteLine("Exception"); }

	Console.WriteLine(client.Proxy.GetProxy(uri_absolute).Host);
}

And the output is:
<IP_ADDRESS>
Exception
www.msn.com

@daxian-dbw Many thanks for C# reproduction!
@MysticRyuujin  Could you open Issue in CoreCLR?

@MysticRyuujin I'm afraid this is not a CoreCLR/.NET Core bug as the type System.Net.WebClient is not even available in .NET Core. But please do try them to see if they can redirect you to the right channel to report this issue.
I'm closing this issue as Resolution-external.


HDDS-7642. EC: Add debug logging to the Replication Manager check handlers

What changes were proposed in this pull request?
Added some debug logs across the new RM check handlers to make it easier to debug issues which come up.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7642
How was this patch tested?
Only log messages added. No functionality change.

@sodonnel Thanks for adding logs. Merging to master.


[Snyk] Upgrade sass from 1.51.0 to 1.69.4

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade sass from 1.51.0 to 1.69.4.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 54 versions ahead of your current version.
The recommended version was released a month ago, on 2023-10-17.

Release notes

Package name: sass

1.69.4 - 2023-10-17To install Sass 1.69.4, download one of the packages below and add it to your PATH, or see the Sass website for full installation instructions.
Changes

No user-visible changes.

See the full changelog for changes in earlier releases.

1.69.3 - 2023-10-12To install Sass 1.69.3, download one of the packages below and add it to your PATH, or see the Sass website for full installation instructions.
Changes
Embedded Sass

Fix TypeScript type locations in package.json.

See the full changelog for changes in earlier releases.

1.69.2 - 2023-10-10To install Sass 1.69.2, download one of the packages below and add it to your PATH, or see the Sass website for full installation instructions.
Changes
JS API

Fix a bug where Sass crashed when running in the browser if there was a global variable named process.

See the full changelog for changes in earlier releases.

1.69.1 - 2023-10-09To install Sass 1.69.1, download one of the packages below and add it to your PATH, or see the Sass website for full installation instructions.
Changes

No user-visible changes.

See the full changelog for changes in earlier releases.

1.69.0 - 2023-10-05

1.68.0 - 2023-09-21

1.67.0 - 2023-09-14

1.66.1 - 2023-08-18

1.66.0 - 2023-08-17

1.65.1 - 2023-08-09

1.65.0 - 2023-08-09

1.64.2 - 2023-07-31

1.64.1 - 2023-07-22

1.64.0 - 2023-07-20

1.63.6 - 2023-06-21

1.63.5 - 2023-06-21

1.63.4 - 2023-06-14

1.63.3 - 2023-06-09

1.63.2 - 2023-06-08

1.63.1 - 2023-06-08

1.63.0 - 2023-06-07

1.62.1 - 2023-04-25

1.62.0 - 2023-04-11

1.61.0 - 2023-04-06

1.60.0 - 2023-03-23

1.59.3 - 2023-03-14

1.59.2 - 2023-03-11

1.59.1 - 2023-03-10

1.59.0 - 2023-03-10

1.58.3 - 2023-02-18

1.58.2 - 2023-02-17

1.58.1 - 2023-02-14

1.58.0 - 2023-02-01

1.57.1 - 2022-12-19

1.57.0 - 2022-12-17

1.56.2 - 2022-12-08

1.56.1 - 2022-11-09

1.56.0 - 2022-11-04

1.55.0 - 2022-09-21

1.54.9 - 2022-09-07

1.54.8 - 2022-08-31

1.54.7 - 2022-08-31

1.54.6 - 2022-08-29

1.54.5 - 2022-08-19

1.54.4 - 2022-08-10

1.54.3 - 2022-08-04

1.54.2 - 2022-08-03

1.54.1 - 2022-08-02

1.54.0 - 2022-07-22

1.53.0 - 2022-06-22

1.52.3 - 2022-06-08

1.52.2 - 2022-06-03

1.52.1 - 2022-05-20

1.52.0 - 2022-05-20

1.51.0 - 2022-04-26

    from sass GitHub release notes

Commit messages

Package name: sass

f40c1fc Cut a release (#2120)
44dceea Update pubspec and changelog for sass/embedded-host-node#257 (#2116)
c62fe6a Fix crash in browser when running alongside NextJS (#2114)
887c511 Cut another release (#2111)
8e6a26c Cut a release (#2107)
ce545c2 Implement first class mixins (#2073)
310904e Fix a race condition preventing embedded compiler to shutdown after a protocol error (#2106)
16b8512 Switch to the GitHub-hosted MacOS ARM64 runner (#2103)
4255930 Update the version of Sass used by the website on release (#2102)
507e439 Bump actions/checkout from 3 to 4 (#2088)
f66cb47 Bump docker/setup-qemu-action from 2 to 3 (#2089)
ff56fc5 Implement support for the relative color syntax of CSS Color 5 (#2098)
00823e0 Rephrase errors for numbers that must be unitless or % (#2101)
23f0143 Forbid LLM contributions (#2100)
9177f14 Update protocol-version during embedded-host-node release (#2097)
0b6a103 Deprecate Deprecation.calcInterp (#2096)
81c0be6 Avoid useless allocations for interpolations without maps (#2095)
de618fa Fix an error during embedded compiler shutdown (#2092)
873e91e Cut a release (#2090)
13c9fb3 Expose the containing URL to importers under some circumstances (#2083)
69f1847 CI: Configure dependabot to update GitHub Actions, too (#2087)
c22c84d Update changelog for sass/embedded-host-node#248 (#2086)
37e0ed5 Fix source span for calculation deprecation warnings (#2084)
7370d6a Fix changelog for 1.67.0 (#2085)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

This issue was fixed in https://github.com/City-of-Helsinki/drupal-hdbt-admin/pull/248/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R58


[!] Invalid Podfile file: The target Pods-projectName already has a platform set..

When I install the nativescript-mapbox plugin then run (tns run ios) my project I get this error:
[!] Invalid Podfile file: The target Pods-projectName already has a platform set..

Have you tried running rm -rf platforms and building it again?

update the Podfile in platforms/ios folder. then pod install from that dir.
# Begin Podfile - /Volumes/Promise/Work/SugarDaddy/projectName/dateapp/node_modules/nativescript-mapbox/platforms/ios/Podfile
 pod 'Mapbox-iOS-SDK', '~> 4.4.1'

 # End Podfile

or go into the node_modules folder and remove the platform :ios, '9.0' line in Podfile of the mapbox plugin.

fixed.

You might have the same things twice on your podfile.
For example:
**
platform :ios, '9.0'
target :'ScreenColorChange' do
use_frameworks!
pod 'AWSCore', '~> 2.9.0'

end
platform :ios, '9.0'
target :'YOUR-APP-NAME' do
use_frameworks!
pod 'AWSAppSync', '~> 2.10.0'

end
**
Solution: Remove the duplicate code:
platform :ios, '9.0'
target :'YOUR-APP-NAME' do
use_frameworks!
and just add the last line to the previous code
pod 'AWSAppSync', '~> 2.10.0'
So it should look like this:
**platform :ios, '9.0'
target :'ScreenColorChange' do
use_frameworks!
pod 'AWSCore', '~> 2.9.0'
pod 'AWSAppSync', '~> 2.10.0'

other pods
end
end**

I have the same issue. I tried what @sputn1k said but it doesn't work. Any other solution?

You might have the same things twice on your podfile.

For example:
platform :ios, '9.0'
target :'ScreenColorChange' do
use_frameworks!
pod 'AWSCore', '~> 2.9.0'
end
platform :ios, '9.0'
target :'YOUR-APP-NAME' do
use_frameworks!
pod 'AWSAppSync', '~> 2.10.0'
end
Solution: Remove the duplicate code:
platform :ios, '9.0'
target :'YOUR-APP-NAME' do
use_frameworks!
and just add the last line to the previous code
pod 'AWSAppSync', '~> 2.10.0'
So it should look like this:
platform :ios, '9.0'
target :'YOUR-APP-NAME' do
use_frameworks!
pod 'AWSCore', '~> 2.9.0'
pod 'AWSAppSync', '~> 2.10.0'
end
end


[Backport] harvester support multi nic (#7899)

Summary
This is a backport pr:   https://github.com/rancher/dashboard/pull/7899
Fixes #

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Hi, @mantis-toboggan-md   PTAL,  thanks
Note: This pr needs to wait for the backend pr merge before it can be merged .


Feature Request - Keyboard Shortcut for Delete Message

I think the VIM-reminiscent, single-key shortcuts of Zulip are awesome. I use them all the time!
It would be great to have a keyboard shortcut too for delete message. =) Pressing "d" opens the drafts messages. Perhaps that shortcut could be remapped to Ctrl-D, and then assign "d" for delete message?
Thanks a lot! =)

I don't think we want to change an established shortcut but we could make the Delete key delete messages.

@zulipbot add "feedback wanted"

My preference is "d", as it's the VIM keystroke for delete, but I do understand if that would confuse users who are already used to the shortcut for drafts. I'll settle with "Delete" if that's the case =)

Yeah, agreed, delete feels like the right key for this, should we have a shortcut.
@eyahlin can you talk a bit about your use case for wanting this to be a single key rather than ?  I'm not aware of use cases where folks delete messages super often, and am a bit worried that such a keyboard shortcut might be primarily triggered by folks who are accidentally not in a text box context and thus might end up being a new negative addition.

Hey @timabbott ! So I'm just speaking from my use case, but I use Zulip a lot when I'm communicating with my team. Because Zulip supports single-key keyboard shortcuts, I use my mouse/trackpad very sparingly -- I can navigate, search and even reply to messages with my fingers on the home row keys =). The only time when I actually have to use my mouse is when I'm deleting a message, because there is no keyboard shortcut for it. I delete messages quite often, usually when I want to hide a message that is private or no longer relevant to the conversation, and sometimes when I do make a mistake in sending. So for those purposes I have to use my mouse, and that disrupts my keyboard-centric workflow.
I understand your concern about folks accidentally triggering a delete. Some thoughts :

Make the keyboard shortcut difficult to trigger -- how about Control/Cmd-D?
There is already a confirmation popup, right? So the users have to answer "OK" to that anyway before they delete a message
Perhaps there could be an option to turn off single-key shortcuts (which is enabled by default) so that the less keyboard-focused users could opt not to use the keyboard shortcuts. This also equally applies to the other keyboard shortcuts like move message and the like

You can delete a message via a sequence involving i, Down, Down, Down, Enter; though we have a bug right now in the night theme where you can't see the keyboard cursor that makes that a bad experience.

Yes, that's exactly what I'm doing now which I find is less than ideal, which is why I would rather use the mouse. This was also why I suggested a single key shortcut.

Taking this issue :)

Taking this issue :)

Thank you for this! Can we see this feature being implemented in Zulip Cloud? :)


Revert "stage 3"

Reverts tc39/proposal-json-modules#12

It shouldn’t be reverted. It’s stage 3.

Yep, unless I missed a memo this proposal should remain at Stage 3.


[util] Hide amd for GTA The Definitive Edition trilogy

Crashes because of static ags on amd systems which report HDR support.

Btw an alternative to this would be to just extend the UE4 exe check to include these.
https://github.com/doitsujin/dxvk/blob/8dc1fe1262f1108841c72834d83714bf87dac163/src/dxgi/dxgi_options.cpp#L73


Test data for longread_coverage please!

@nadolina: https://github.com/fubar2/treeval_gal/tree/main/longread_coverage needs an assembly and corresponding pacbio data - are you able to provide some small but realistic (e.g. single contig?) test data for a workflow please? A PR with the samples in that directory would be handy! Then I can start an analysis history for a workflow. Same data needed for kmer too.

Closing this as there are plenty of huge assemblies and raw data files on genomeark!


Feature Request: Automatic externals between prebundled packages

For example,
If there're two deps defined in prebundle.config.mjs: package a and package b.
If resolving "b" in package a results in the same position of package b, we could add { b: '../b/index.js' } into a's externals.
If resolving "a" in package b results in the same position of package a, we could add { a: '../a/index.js' } into b's externals.
Todo

We cannot do this at this time because:

Package a’s dependency c might require a different version of package b than what a does.

Therefore, we need to manage externals using "resource path" instead of "request," but unfortunately, ncc does not support this.

Close for it hard to do it correctly with ncc


add tests to verify that checkboxes & radio button inputs are properly populated on edit

closing in favor of https://github.com/SexualHealthInnovations/django-wizard-builder/issues/129


app.use() requires a generator function

Something seems to be quite right
$ node -v
v4.2.1

Dependencies:
"dependencies": {
  "koa": "1.1.2",
  "koa-morgan": "1.0.0"
}

Code:
var koa = require('koa');
var morgan = require('koa-morgan');
var app = koa();
app.use(morgan('dev'));

Error:
AssertionError: app.use() requires a generator function

See https://github.com/koa-modules/morgan#usage.
If you want to use koa-morgan with koa-v1, do not use 1.0.0' version, must use 0.x' version.

Then the usage is confusing and should be
koa-v2 -> koa-morgan 1.x
koa-v1 -> koa-morgan 0.x

@fundon Maybe you need to set 0.x as latest.

@tcurdt Your're right.
I updated the readme.
@coderhaoxin Added.
$ npm dist-tags ls
latest: 0.4.0
next: 1.0.0

Same problem with "koa-morgan": "0.4.0"

@OKNoah  Which version is koa?

@fundon "version": "1.1.2"

Oops, I was initializing it the 1.x.x way.

var app = require('koa')(),
	router = require('koa-router');

api = router();

api.get('/',function* (next){
	this.body = 'hello index';
});

app
	.use(api.routes())
	.use(api.allowedMethods());

router version is changed~!


Using embedded images

Can we keep image files in template folder and refer them in template and send as embedded images in email?

@iamchathu yes - I recommend you use https://github.com/crocodilejs/nodemailer-base64-to-s3 after embedding the images as base64.  You can embed them as base64 by passing an option to juice...
juiceOptions: {
  webResources: {
    relativeTo: path.join(__dirname, '..', '..', 'build') // path to folder where your images are
  }
}

however you seem like you're really getting into things here, so I might recommend you actually take a look at how I send emails with CrocodileJS (which doesn't use email-templates, it just uses juice strictly by itself and nodemailer).  https://github.com/crocodilejs/crocodile-node-mvc-framework/blob/development/src/jobs/index.js

I tried adding relativeTo: but it didn't worked 😢

@niftylettuce  Can we embed images without uploading to s3?

@iamchathu not really, that's the whole reason why I made those packages


Failed to loading DLLs!

compiled with new offset for latest patch but when I tried to run I get:
Diablo II Legacy v1.13c: Failed to loading DLLs!
Side note: Maybe fix verbage to "Failed to load DLLs!"

check d2path in D2RMH.ini, or put exe in d2 1.13c folder with unmodified ini

ini path not working but does work in the 1.13c folder

fixed in v0.5


Fastboot error in last command

Love from Bangladesh please fix this issue last command
problem fastboot ADB install but ADB fastboot error please
Fix

Delete the old token.bin file and generate it again from server

tanks for response my phone is unlocked love for Bangladesh

🥰🥰🥰

if your phone rebooted before unlock or failed to unlock then you need to generate token again

Which token mi-fastboot oem get_token
Or server token?

Both


SMS messages can be sent instead of email

In many situations, email is not easy to deliver, but SMS messages will reach the recipients. (Think recovery zones).
We need a way for a user to configure any message that can be sent via email to be sent via SMS.
If you want this issue, message one of the coordinators. We have arrangements with Twilio to use there service for this feature.

Note that if an SMS message is chosen, the app should limit the length of the message.

I can work on this enhancement.


Extra tap is required when TextInput is focused and keyboard is up

I have a TextInput in the navigation header bar (via React Navigation headerTitle). After getting focus it activates an auto-suggestion component that is placed in the main screen:
---------------------
| SEARCH BOX |                   <- REACT NAVIGATION (headerTitle)
---------------------
SUGGESTION 1                    <- APP SCREEN
---------------------
SUGGESTION 2
---------------------
SUGGESTION 3
---------------------
SUGGESTION 4
---------------------
SUGGESTION 5
---------------------
|
| SYSTEM KEYBOARD          <- KEYBOARD OVERLAY (SYSTEM)
|
---------------------

The problem is that tapping on suggestion the first time doesn't make it handle a tap but rather hides the keyboard and blurs the TextInput. Then user has to tap once again which make UX rather annoying.
Problem has been discussed couple of times and the recommended solution is to use keyboardShouldPersistTaps property of the ScrollView. However this receipe doesn't work in here due to the TextInput is located outside the ScrollView.
Please advise how to fix the need for extra tap in this scenario.

Got it. The problem was that the ScrollView had a nested FlatList responsible for actually rendering the suggestions.
The solution is to set keyboardShouldPersistTaps property on the nested list:
<ScrollView>
  <FlatList keyboardShouldPersistTaps='always'
    .../>
</ScrollView>

It works even if TextInput and the target list/view don't share the same ancestor.
Read more at:

keyboardShouldPersistTaps (official docs)
Needs to tap twice to fire onPress function when keyboard is open
Today’s React Native Tip: Keyboard issues in ScrollView
React Native two taps required for onPress to work


Expanded Linux Install Instructions

These expanded Linux install instructions are based on two successful flashes using a Pi 5. One using a TSV with 8.1 already installed and functions, the other using a fresh device, right out of the box booted into EDL the very first time it was powered on.

Excellent - thanks for your work on this - the guide is looking good :) I added you into the credits too. Probably needs a tidy up overall as it grows more.


Train LLAMA 2 tokenizer from scratch

Hello,
I'm trying to train the same tokenizer (BPE with SentencePiece) and apply the same strategy as you did in your approach.
I wonder if there is code that does that already available somewhere in this repository.
I've been searching but could not find anything. It seems that most of the notebooks assume we load the llma2 model.
Thank you in advance
Luca

@lfoppiano thans Luca, unfortunately we dont have any code for training tokenizer in this repo. This HF post may help.

That HF post says nothing about the tokenizer.model. Can you explain about how to generate the model file?

@cyberiumchain In principle if you use SentencePiece and the BPE encoder you should obtain the same result... but it's hard to know without any code...

I am curious too! Is there really no code for creating a Llama tokenizer?


[main] Update community files

Cron -knative-prow-robot
/cc knative-sandbox/client-writers
/assign knative-sandbox/client-writers
Produced by: knative-sandbox/knobots/actions/update-community
Details:

/verify-owners

/approve
/lgtm

/approve
/lgtm


Wrong restart message and release notes not up-to-date

After updating to Atom v1.2.0:

Moved from https://github.com/atom/atom/issues/9590

same issue here

+1
Windows 7, 64Bit

+1 on OSX, Atom 1.2.1

+! on OSX, Atom v1.2.1

+1 on OS X 10.11.1, Atom 1.2.1

As others already said I can also confirm it with v1.2.1 of Atom (Win7 x64).

Just installed Atom update v1.2.2. Release notes plugin still broken.

+1 here, just updated to 1.2.2 on OS X 10.10.5 and still broken

Reference duplicate issue: https://github.com/atom/atom/issues/3757

+1

Still happening with 1.2.3 on OS X 10.11.1

Win7 fresh install of Atom 1.2.3
http://i.imgur.com/Bc55FJX.png

Having the same problem on 1.2.3 OS X.

+1, can confirm.

From https://github.com/atom/atom/issues/3757#issuecomment-158147465 by @benogle

We're really sorry about this issue. The plan is to remove the release notes package and have all the update logic in the about page similar to chrome. See https://github.com/atom/atom/issues/9164 for more details.

+1, OS X 10.11.2(15C50), Atom 1.3.1

+1, Windows 10, Atom 1.3.1

+1, Win7, Atom 1.3.2

I think I managed to fix my release notes view by clearing the localStorage cache of the release notes data. I can't reproduce this anymore, so I can't really verify. It may just become stuck at the current state, though.
You may be able to replicate a fix by running localStorage.removeItem('release-notes:releaseNotes'); in the Javascript console in atom's developer tools, then restart atom.

@petey That did not work for me. (Latest OS X, latest Atom)
The temporary workaround localStorage.setItem('release-notes:version', "1.3.2") works though, so I guess I'll stick to that until this is resolved.

@hugokrantz You are right, as I can set version back to 1.1.0 and see this behavior again. So I wonder if there is an issue with this: https://github.com/atom/release-notes/blob/df0de51cdf0719a46873919390c8f70de99ae834/lib/main.coffee#L22 that it does not set version properly anymore.

I actually deleted that property from the developer tools' local storage, and it had literally zero impact. Then I tried deleting the cached release notes to see if that had any effect.
Nope, nada. :(

This problem has been addressed already by Github staff. See the last message on the following issue posted to Atom:
Reference issue: https://github.com/atom/atom/issues/3757
"We're really sorry about this issue. The plan is to remove the release notes package and have all the update logic in the about page similar to chrome. See #9164 for more details."
That issue number referenced in the quote is on Atom.

I totally understand the intended behavior, but until that is actually released, it looks REALLY bad on atom that this is broken. This package has been broken for a little over a month, and looking back at the referenced issue, has regressed from earlier problems.

I totally agree with you @petey.

There is a specific issue with 1.1.0 and beyond. The release notes stuck of every reporter in this thread, including me, got stuck at 1.1.0. Only localStorage.setItem('release-notes:version', "1.3.2") helps.

All repositories in the atom-archive organization are unmaintained and deprecated. Because of this, we are archiving this repository and closing all issues and pull requests. Thanks very much for your support and contributions!


[BUG] If default order type is not available at a location, checkout fails.

Expected behavior:
If a location only offers Pickup, but the default order type is Delivery, the menu page should automatically fall back to select Pickup in the order type to avoid confusion.
Actual behavior:
If a location only offers Pickup, but the default order type is Delivery, when a customer goes to checkout they are redirected away from the menu page and never get to the checkout page.
Reproduce steps:
Set up a location with only pickup.
Set the theme options to have delivery as default.
Go to the menu and add items to the cart.
Press Checkout
Version:
3.0.4-beta.26
Additional Information:
(Additional information, if any)

This fix creates an unintentional side-effect that I can't change between delivery types once applied.
This does fix the error when I go to a location that doesn't support the default order type, but it doesn't automatically select the other order type so the user has to click "Delivery" for example if Pickup is default but not available at this location.
I have had to back out this fix since it caused that side effect.  My current updateCurrentOrderType() is as follows:
    protected function updateCurrentOrderType()
    {
        if (!$locationCurrent = $this->location->current())
            return;

        $locationOrderTypes = $locationCurrent->availableOrderTypes();
        $defaultOrderType = $this->property('defaultOrderType', Locations_model::DELIVERY);
        if (!in_array($defaultOrderType, $locationOrderTypes)) {
            if (!count($locationOrderTypes))
                return;

            $defaultOrderType = $locationOrderTypes[0];
        }

        if (!$sessionOrder = $this->location->getSession('orderType') OR !in_array($sessionOrder, $locationOrderTypes))
            $this->location->updateOrderType($defaultOrderType);
    }

This fix creates an unintentional side-effect that I can't change between delivery types once applied.
This does fix the error when I go to a location that doesn't support the default order type, but it doesn't automatically select the other order type so the user has to click "Delivery" for example if Pickup is default but not available at this location.
I have had to back out this fix since it caused that side effect.  My current updateCurrentOrderType() is as follows:
    protected function updateCurrentOrderType()
    {
        if (!$locationCurrent = $this->location->current())
            return;

        $locationOrderTypes = $locationCurrent->availableOrderTypes();
        $defaultOrderType = $this->property('defaultOrderType', Locations_model::DELIVERY);
        if (!in_array($defaultOrderType, $locationOrderTypes)) {
            if (!count($locationOrderTypes))
                return;

            $defaultOrderType = $locationOrderTypes[0];
        }

        if (!$sessionOrder = $this->location->getSession('orderType') OR !in_array($sessionOrder, $locationOrderTypes))
            $this->location->updateOrderType($defaultOrderType);
    }

Did you see the updated PR here:
https://github.com/tastyigniter/ti-ext-local/pull/41

Did you see the updated PR here:
https://github.com/tastyigniter/ti-ext-local/pull/41

Nope - when I put that one in I am able to change locations no problem, but still getting an error if a location doesn't accept the default order type:

(1/1) ErrorExceptionUndefined offset: 0
--
in LocalBox.php line 250
at HandleExceptions->handleError(8, 'Undefined offset: 0', '/home/dineniag/public_html/extensions/igniter/local/components/LocalBox.php', 250, array('locationCurrent' => object(Locations_model), 'locationOrderTypes' => array('delivery'), 'defaultOrderType' => 'collection'))in LocalBox.php line 250
at LocalBox->updateCurrentOrderType()in LocalBox.php line 105
at LocalBox->onRun()in HasComponents.php line 102
at Model->runComponents()in MainController.php line 297

Nope - when I put that one in I am able to change locations no problem, but still getting an error if a location doesn't accept the default order type:

(1/1) ErrorExceptionUndefined offset: 0
--
in LocalBox.php line 250
at HandleExceptions->handleError(8, 'Undefined offset: 0', '/home/dineniag/public_html/extensions/igniter/local/components/LocalBox.php', 250, array('locationCurrent' => object(Locations_model), 'locationOrderTypes' => array('delivery'), 'defaultOrderType' => 'collection'))in LocalBox.php line 250
at LocalBox->updateCurrentOrderType()in LocalBox.php line 105
at LocalBox->onRun()in HasComponents.php line 102
at Model->runComponents()in MainController.php line 297

For clarity I have Pickup set as the default order type, and it is a location with Delivery only that is failing.

For clarity I have Pickup set as the default order type, and it is a location with Delivery only that is failing.

Try changing it to head($locationHasOrderTypes) instead of $locationHasOrderTypes[0]
Let me know if that works.

Try changing it to head($locationHasOrderTypes) instead of $locationHasOrderTypes[0]
Let me know if that works.

Sorry head($locationOrderTypes) ... on my
Phone so misread the variable name

Sorry head($locationOrderTypes) ... on my
Phone so misread the variable name

Bingo on the second one... works perfectly with that there.
I will submit a PR to include this.

Bingo on the second one... works perfectly with that there.
I will submit a PR to include this.


Problems with the delete key when using the orca screen reader

CC: @isidorn
Issue Type: Bug

Launch orca.
Launch VScode insiders and open a file to edit.
Type something and try to delete what was typed using the delete key.

Orca should announce the character that was to the right of the removed character but instead it is muted.
According to @joanmarie this issue is:
https://bugs.chromium.org/p/chromium/issues/detail?id=1065534
and the fix is:
https://chromium.googlesource.com/chromium/src/+/2469d759e3
Any chance of cherry-pick this fix?
VS Code version: Code - Insiders 1.48.0-insider (8c426f9f3b6b18935cc6c2ec8aa6d45ccd88021e, 2020-07-23T05:32:52.579Z)
OS version: Linux x64 5.7.10-arch1-1

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-3210M CPU @ 2.50GHz (4 x 2719)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: unavailable_offvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 1, 1

Memory (System)
9.60GB (0.15GB free)

Process Argv
--no-sandbox --crash-reporter-id 8d5a3738-d241-4b34-b208-057882a7b877

Screen Reader
yes

VM
0%

DESKTOP_SESSION
gnome-xorg

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome-xorg

XDG_SESSION_TYPE
x11

We have written the needed data into your clipboard because it was too large to send. Please paste.

@jvesouza thanks for filling this along with the link to the upstream issue and the fix.
@deepak1556 is it possible to cherry-pick the fix, does this make sense to you?

yup its possible, the linked fix went into chromium  84.0.4109.1 , I will backport it to Electron 9 which is our current insiders based on chromium 83.

Problem fixed, I believe we can close this bug. Thank you all.

@jvesouza thanks for letting us know. We plan to close this once we definetly decide to ship Electron 9 as part of stable. Thus we have assigned the fixed-in-electron-9 label.
We hope the Electron 9 will happen this milestone.

Seems like we will shipt with Electron 9, thus closing this optimistically.


Mutation class isn't exposed from @tanstack/query-core

Describe the bug
I am attempting to create a small wrapper class around TanStack Query's Mutation API and I keep running into the following issue
WARNING in <redacted> 75:27-35
export 'Mutation' (imported as 'Mutation') was not found in '@tanstack/query-core' (possible exports: CancelledError, InfiniteQueryObserver, MutationCache, MutationObserver, QueriesObserver, Query, QueryCache, QueryClient, QueryObserver, defaultShouldDehydrateMutation, defaultShouldDehydrateQuery, dehydrate, focusManager, hashKey, hydrate, isCancelledError, isServer, keepPreviousData, matchMutation, matchQuery, notifyManager, onlineManager, replaceEqualDeep, skipToken)

The way I have imported it is as follows
import { Mutation } from "@tanstack/query-core"

export class MutationBuilder<TData = unknown> {
	mutation: Mutation;
	subscription: {
		unsubscribe: ReturnType<MutationObserver<TData>['subscribe']>;
	};

	constructor(
		private queryClient: QueryClient
	) { }

	build<T>(options: ConstructorParameters<typeof Mutation<T>>[0]["options"]): MutationBuilder<T> {
		const mutation = new Mutation({
			mutationCache: this.queryClient.getMutationCache(),
			mutationId: 1,
			options
		});

		options.mutationFn

		this.mutation = mutation;

		return this as any;
	}

	subscribe(subscribeFn: Parameters<MutationObserver["subscribe"]>[0], options?: MutationObserverOptions<TData>) {
		const mutationObserver = new MutationObserver<TData>(this.queryClient, options);
		this.mutation.addObserver(mutationObserver);

		this.subscription.unsubscribe = mutationObserver.subscribe(subscribeFn)

		return mutationObserver as Omit<MutationObserver<TData>, "subscribe" | "getCurrentResult">;
	}
}

I checked the source file at https://github.com/TanStack/query/blob/main/packages/query-core/src/mutation.ts but it seems to be exported correctly there.
Your minimal, reproducible example
https://codesandbox.io/s/elated-firefly-vznnq4?file=/src/App.js
Steps to reproduce
Run it in the browser, the problem will show up in the console stating TypeError: _queryCore.Mutation is not a constructor
Expected behavior
I expected Mutation to be usable in order to setup Mutation queries alongside QueryClient
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
OS: MacOS
Browser: Arc (v 1.52.0), Chromium Engine Version 126.0.6478.183
Tanstack Query adapter
vanilla
TanStack Query version
5.49.1
TypeScript version
4.9.4
Additional context
No response

Will do

@TkDodo do you think adding an example project for using the query-core package directly via a vanilla project might be useful in the project ? Thinking if I should add one to the examples directory ?

Fixed in v5.51.15


"Salsa" intellisense not working in nested files (under html) in VS 2017

Platform: VS 2017 (RTM), using ".js" files with auto type acquisition (without a tsconfig file).
External packages (like angular type definitions from bower) are not being included in intellisense in nested files. Everything works fine in normal files, but when the file is nested (under an html file for example), intellisense won't include external packages:

Looks like adding an empty "jsconfig.json" (containing only "{}") fixed this. But I'm kinda seeing inconsistent behavior across VS Code and VS 2017.

@mrahhal :  thanks for raising this issue.  I'm also able to repro

@mrahhal : thanks for raising this issue. I'm also able to repro when using nested files without a tsconfig.json. Nested JS files are being placed in a separate (intellisense) project context which isn't ideal.  I've reopened this issue as we should be able to do better here.

This bug was on the Visual Studio 2017 side. The fix is checked in and it will be included in the next update (unfortunately it just missed "update 3" which went out this week).

Should be fixed in 15.3.

See prior comment. This didn't make 15.3. It'll be in 15.4.


Support Skript programming language

Sorry but KekOS development is based in Ukraine and here using Skript is considered a war crime.


Support shorthand for column suffix matching referenced column

Would there be a good shorthand syntax for foreign keys or more general situations where the column being populated has a suffix that matches the name of the column being referenced?
public
  person
    leela
      name 'Turanga Leela'

  pet
    _
      name 'Nibbler'
      -- Expands to `person_id<EMAIL_ADDRESS>      [person.id] @leela

Or maybe..
public
  person
    leela
      name 'Turanga Leela'

  pet
    _
      name 'Nibbler'
      -- Expands to `person_id person#leela.id`
      person[id] @leela

Questions:

Is that really any better than just person_id @leela.id?
If so, is it better enough to justify any more thought or effort?
Is this blocked on https://github.com/kevlarr/hldr/issues/33 ?

Requirements:

[ ] Not annoying to type or to read
[ ] Supports explicit cross-schema references

Note that this would not support cross-schema references, so a better proposal is required.

This is probably blocked on https://github.com/kevlarr/hldr/issues/33

Closing this because I just don't think there's enough value for the complexity, and it is too closely tying language features to database structure that might not even be relevant for a lot of people.


chore(deps): upgrade runtime dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-runtime-dependencies-k8s-27-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 3348

Questions ?
Please refer to the Backport tool documentation


Language changing isn't work

I just install this template (DotNetCore version) with VSIX installer, all done but culture isn't work like demo! Page just refreshing without changes.
Any Idea?

I did not fully understand your problem. Language changes are made in part.

Check cookies are enabled


Indentation of entries in sidebar in generated HTML is incorrect after sub-sections

Given this nbook:
import nimibook

var book = initBookWithToc:
  entry("Should Be 1.", "book/bla.nim")
  section("Should be 2", "book/internals.nim"):
    section("Should be 2.1", "internals/adders.nim"):
      entry("Should be 2.1.1", "adders/one_adder.nim")

  entry("Should be 3.", "CONTRIBUTING.md")
nimibookCli(book)

Running these commands:
nimble install -y nimib@#head nimibook@#head
nim c -d:release --mm:refc nbook.nim
./nbook init
./nbook build

Generates this Sidebar:

The numbering is correct, but the indentation isn't.
The indentation implies that "Should be 3" is a sub-entry of the section "Should be 3" instead of a sibling entry.
I assume the logic that generates HTML only goes back one indentation level instead of determining the correct indentation level.

Thanks a lot for reporting and for the reproducible example. Definitely a bug, will look into it and let you know!

Btw this is the code that needs to be looked at: https://github.com/pietroppeter/nimibook/blob/main/src/nimibook/renders.nim

Note to self when fixing:

add test
rename tocs -> toc_dsl and renders -> toc_render
update src/readme

reproducing the bug using doc render, will keep debugging later:
import nimibook / [tocs, renders]

let myToc = initToc:
  entry("Should Be 1.", "book/bla.nim")
  section("Should be 2", "book/internals.nim"):
    section("Should be 2.1", "internals/adders.nim"):
      entry("Should be 2.1.1", "adders/one_adder.nim")

  entry("Should be 3.", "CONTRIBUTING.md")

echo myToc.render
#[

    1. Should Be 1.

    2. Should be 2

        2.1. Should be 2.1

            2.1.1. Should be 2.1.1

        3. Should be 3.

these two are missing from the output:

]#

Yeah looks like it doesn't check at the end of a section block of it's about to end multiple section blocks at once and instead interprets the ending of two blocks ( the one for "Should be 2" and "Should be 2.1")  as one block ending.
I played around with the setup a bit and if I write it like this for example it works (I didn't write this exact command, I wrote one for the owlkettle docs as that was faster to play around with, but this should do as well):
import nimibook

var book = initBookWithToc:
  entry("Should Be 1.", "book/bla.nim")
  section("Should be 2", "book/internals.nim"):
    section("Should be 2.1", "internals/adders.nim"):
      entry("Should be 2.1.1", "adders/one_adder.nim")
    entry("Should be 2.2 and fix things", "book/bla2.nim")
  entry("Should be 3.", "CONTRIBUTING.md")
nimibookCli(book)

indeed inside this else section I think we should iterate over level differences to close the correct number of sections: https://github.com/pietroppeter/nimibook/blob/main/src/nimibook/renders.nim#LL57
will test a fix


Some of the MT scaling relation errors are incorrect

Go to the code and see the TODO

This isn't very clear - some of the relations from literature I have implemented with known bad uncertainties on one of the parameters


Teach upstream proxy (-U) mode to be able to ignore certain hosts or host/address-patterns

This is analogous to standard no-proxy functionality for a direct HTTP client - it should be possible to be able to specify hosts, host-patterns or even IP address ranges which mitmproxy will then proxy "directly" rather than forwarding via the configured upstream proxy.  There is often no option to this if you are a) forced to work with an upstream proxy in order to access internet-hosts and b) also working with hosts e.g. localhost that are not known-to, or accessible from the upstream proxy.
Steps to reproduce the problem:

Work with an upstream proxy that you want to proxy requests to most, but not all hosts.
Receive some redirect to http://localhost
The upstream proxy can't serve that request.  Host "localhost" needs to be excluded from upstream proxying, and should instead be forwarded "direct", in this case, to localhost.

Any other comments? What have you tried so far?
I looked at filter-expressions but I don't think those fit.
System information
mitmproxy 1.0.2

Thanks for the write-up. On the roadmap, but that's nothing that can be easily added with our current setup.
refs #1821
refs #1775

Thanks, this could probably be merged-with, or closed duplicate of #1821.  I'll add a comment over there.  Using env to help configure this might be helpful and conventional.

Ok, I'll close this here then if you don't mind. :)

This is analogous to standard no-proxy functionality for a direct HTTP client - it should be possible to be able to specify hosts, host-patterns or even IP address ranges which mitmproxy will then proxy "directly" rather than forwarding via the configured upstream proxy. There is often no option to this if you are a) forced to work with an upstream proxy in order to access internet-hosts and b) also working with hosts e.g. localhost that are not known-to, or accessible from the upstream proxy.
Steps to reproduce the problem:

Work with an upstream proxy that you want to proxy requests to most, but not all hosts.
Receive some redirect to http://localhost
The upstream proxy can't serve that request.  Host "localhost" needs to be excluded from upstream proxying, and should instead be forwarded "direct", in this case, to localhost.

Any other comments? What have you tried so far?
I looked at filter-expressions but I don't think those fit.
System information
mitmproxy 1.0.2

Hello, this question is from long time ago, but now I am facing the same situation, and it seems mitmproxy haven't changed about this approach. Did you  find a way to do it? I have to the same, upstream to another proxy but ignore requests to localhost, tks.


Align query for nightly_regressions_unassigned_p_high

Hi,
I think the query for the nightly_regressions_unassigned_p_high issues in the template is not aligned to the agenda template. The github query filters out all teams, the template doesn't so the results are not aligned if I click on the link or run the agenda generator using the cli tool.
I think the Github query is the right one so I fixed the agenda template: we want all P-high regressions on nightly that are not yet assigned to a team, right?
r? @Mark-Simulacrum
cc: @spastorino

ok I think we're done here. I've compared (more or less thoroughly) all the queries against the compiler agenda template

r? @Mark-Simulacrum

replaced by #1175


How to recognize mathematical expressions?

Would it be possible to recognize mathematical expressions like fractions (5/7 or 4/9) with this repo?

@thrfdth  i suppose you'll have to add your special characters and train on adequate data (i.e. data containing mathematical expressions).

hello . how am l doing you say? @AriouatI . (For licence plate)


fix(header)!: use tmjson encoding for Commit field as well

Fixes #3918
Please note: this PR is BREAKING as header encoding has changed.
I don't see a reason we weren't doing this to begin with as we tmjson encode the other "tendermint" fields.

Codecov Report
Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 45.10%. Comparing base (2469e7a) to head (5ebb191).
Report is 378 commits behind head on main.

Files with missing lines
Patch %
Lines

header/header.go
50.00%
4 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3925      +/-   ##
==========================================
+ Coverage   44.83%   45.10%   +0.27%
==========================================
  Files         265      307      +42
  Lines       14620    21846    +7226
==========================================
+ Hits         6555     9854    +3299
- Misses       7313    10912    +3599
- Partials      752     1080     +328

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Implementation of margin-based ranking loss

What's the best way to implement a margin-based ranking loss like the one described in [1] in keras? So far, I have used either the dot operation of the Merge layer or the siamese architecture described in #242 to calculate the similarity between two inputs. I am unsure how to extend these (or use another approach) to take into consider a corrupted pair of inputs. Any help is greatly appreciated.
[1] Bordes, A., Usunier, N., Weston, J., & Yakhnenko, O. (2013). Translating Embeddings for Modeling Multi-Relational Data. Advances in NIPS, 26, 2787–2795.

Hi @sebastianruder  There are no diagrams in that paper and I hate reading raw text. Could you please elaborate about the required model? Like whats your input and output? What do you mean by corrupted pair?

My inputs are basically two pairs of documents (in the paper, these are two pairs of triples). One is a pair of similar documents a and b, the other one is a pair of dissimilar documents a and c. I want to minimize the dissimilarity between a and b while maximizing the dissimilarity between a and c with a margin (see equation 1 on page 3  of the paper). Is there a way to have a loss function that can take these pairs (or their similarity/dissimilarity scores as input), rather than just the predicted and gold labels?

In other words, what's the best way to minimize any kind of ranking criterion using keras (e.g. in [1], 4.2)?
[1] Collobert, R., Weston, J., Bottou, L., Karlen, M., Kavukcuoglu, K., & Kuksa, P. (2011). Natural Language Processing (almost) from Scratch. Journal of Machine Learning Research, 12(Aug), 2493–2537. Retrieved from http://arxiv.org/abs/1103.0398

The simplest way to build a reranker in keras is basically to classify as 1 the positive examples and as 0 the corrupted. In practice you train a classifier and you use its prediction to rerank. It is not the best option at all but in many case it works really well ;) You can try from there, i thought  to an implementation of a pairwise reranker but i not reached any solution without disrupting keras.

Thanks for the tip! Yes, that's basically what I've been doing as well. Thought that there was a way to more closely replicate the objective given in the paper. I guess I'll stick with my current objective then.

Is there any progress or any sample code to realize the ranking loss now?
I find it's very common in Multi-NLP tasks. Many papers use the loss to optimize the results. But I can't practice with keras.
Thanks.

I've been attempting to accomplish this a custom loss function.  Essentially, after a
Merge( [doc_input_a, doc_input_b], mode='dot, dot_axis=-1)
I then compile with something like
        model.compile( loss=rank_svm_objective,    optimizer='adam', class_mode='binary' )
where rank_svm_objective is defined as
def rank_svm_objective( y_true, y_pred, margin=1.0):
    # y_pred are the dot product similarities, in interleaved form (positive example, negative example, ...)
    # y_true is simply +1, -1, +1, -1
    signed = y_pred * y_true # we do this, just so that y_true is part of the computational graph
    pos = signed[0::2]
    neg = signed[1::2]
    # negative samples are multiplied by -1, so that the sign in the rankSVM objective is flipped below
    rank_hinge_loss = K.mean( K.relu( margin - pos - neg ), axis=-1)
    return rank_hinge_loss

where y_pred is the output of the Merged dot product, and I've fed the data in the minibatch in an interleaved ordering of positive, negative, etc., examples. Furthermore, y_true, is just +1, -1, etc.
Unfortunately, this doesn't seem to work.  There's maybe something simple that I'm missing here, but I've gotten similar tricks (defining the objective over interleaved elements of the minibatch) to work with tensorflow.

@sebastianruder I think the code from https://github.com/maciejkula/triplet_recommendations_keras is really a good example.

The problem is the code I posted above is that the objective is expecting a loss vector with the same number of entries as items in the minibatch.  So, with a little craftiness in the way that data composed in the minibatch, you can make your rank svm objective like this:
def rank_svm_objective( y_true, y_pred, margin=1.0): # change to 1.0?  makes more sense for normalized cosine distance [-1,1]
    ''' This only works when y_true and y_pred are stacked in a way so that
    the positive examples take up the first n/2 rows, and the corresponding negative samples
    take up the last n/2 rows.

    y_true corresponds to scores (e.g., inner products)
    y_pred corresponds is a vector of ones or zeros (denoting positive or negative sample)
    '''
    n = y_true.shape[0]//2
    signed = y_pred * y_true # make y_true part of the computational graph
    pos = signed[:n]
    neg = signed[n:]
    # negative samples are multiplied by -1, so that the sign in the rankSVM objective is flipped
    hinge_loss = K.relu( margin - pos - neg )
    loss_vec = K.concatenate([hinge_loss, hinge_loss], axis=0)
    return loss_vec

I think keras function API( http://keras.io/models/model/) can solve the rank loss perfectly. keras 0.3.2 has not the wonderful function api. 1.0++ later has.

I re-implemented the ranking loss using Keras Graph class.
See https://github.com/Kyung-Min/triplet_recommendations_keras
I hope the codes works for you

Some of the suggestions in this thread are not applicable with the latest keras. I found a good solution combining stackoverflow and triplet loss.
Essentially, we have to use the lambda method as described in the stackoverflow post, with the triplet loss defined by @maciejkula.

Is this thread connected to the WARP loss?


contracts.OutofGas: The executed contract exhausted its gas limit

when buying using "Buy Now" function on the collection Tornado#1
the error show is
contracts.OutofGas: The executed contract exhausted its gas lomit
There is some error with your request

Error contracts.OutofGas: is fixed at commit  e98f356d8387178d326ad3badbc7c7b23c9798ba.


Fixes

Coverage decreased (-0.07%) to 75.706% when pulling 11e69e395ce8e99442aebc2abda56dc84f15a31f on lukasmacko:fixes into fa7207cc07c7904d83852ebd15ce2cb220421294 on contiv:master.