Suggestion: Group commands without having to invoke with group name

Shortly put, allow something like command grouping in discord.py
For a group X with Commands Y and Z
help shows X
help X shows Y and Z
and Y and Z can be invoked prefix-Y / prefix-Z, instead of prefix-X Y and prefix-X Z
Hope it makes sense.
(Some people are challenged with with having every command in a group, but it's necessary to prevent the help list from becoming an utter mess, especially with "larger" bots.)

That's completely missing the point of command groups though.

It could be optional as part of the Group attribute
~I  don't really want to do all the reflection stuff necessary to bodge it together myself~

I'm not a fan of that idea. Right now you can create a command that uses sudo to achieve your goal, and that's the preferred way to be honest.
What I can offer is changes to sudo interface to enable doing that more easily.

I can vaguely (but not fully) imagine how that would work out, would appreciate it!

sudo implement this feature

Note for future me:

Allow easier command invocation via sudo:

By qualified name
By command object

Allow passing arguments to sudo as raw strings or converted objects.

Isnt it bit more logical to use commands in that way tho? As prefix X-Y, unless stated otherwise?

@armaa department of redundancy department

@armaa not sure what you mean. Currently if you have a command group called group and command named command, you have to invoke it as group command. This is about allowing invoking it as command in addition to that.
I don't want to make the system work like this, however it can be achieved by using CNext's sudo functionality. The only problem is that at the moment it's crude.
The way this would work is you have a group called group and a command called command. On top of that you have an ungroupped command called command, which invokes group command via sudo.

@armaa yes it is more logical to do prefix-X Y
But did you even read the issue?
People may want to group commands to avoid cluttering, but find it a hassle to always have to type group names (even when you can alias them down to 1 or 2 letters)
I often forget to type group name altogether, and wonder why I'm getting a commandnotfoundexception

@Emzi0767 I meant exactly that as you said it, doing group command.
@moonPtr I did read it and i get what you mean, im just stating my view on it, i suppose

Another way to implement this would be to have
All commands ungrouped, and [Hidden]
Then the command groups, not hidden (so they show in help)
And then have group command call command
However that might lead to some spaghetti code due to how you would have to go about letting group command access command

Which is why I'm suggesting the sudo solution, as it takes care of all the binding and conversions, and would also permit you to use dynamically-defined commands, should we ever implement that.

This is now implemented as part of e8ac9eef00b451d0c485998073bb7601eda53753.

Hey Guys, I know I'm kind of late to this thread, but I'm new to this project and just wanted to confirm: By using the master branch / nightly builds, would this work out-of-the-box or is changing a setting, writing a custom handler or anything similar needed?

Sudo changes are. The original suggestion from this issue was rejected.


[Feat]: Centralised commmand registration

Description
Added 3 new functionalities:

Created a centralised utility file to create and register commands.
Added telemetry for commands.
Added shortcut "cmd+alt+o" to toggle chat.
Made focus auto-enabled for chat input whenever the chat's webview is visible.

Screen Recording

@doitwithdk issues resolved.


Fix .from_xdr encoding param to accept symbols

Update .from_xdr(string, encoding) to accept Ruby symbols for encoding param as well as string. Using symbols for enum-like arguments is a common idiom in Ruby, and also corresponding #to_xdr method does accept symbols, which makes the error in .from_xdr especially confusing.
/cc @abuiles

I don't have permissions to release this gem, unfortunately. We'd actually be happy to take over the maintenance of this gem, if that's an option. It would greatly simplify Stellar SDK maintenance for us, and I guess will save some precious time for you.

@abuiles if you're fine with this change, could you please merge and release a new version? I can definitely work around this on SDK side, but I'd prefer to avoid introducing more monkey-patching (especially since it's been giving me the hard time with mysterious errors in JRuby) and also not a fan of rolling back to the string-only usage, since it's definitely not the best developer experience, I've been running into this myself pretty much every time I used Ruby for Stellar. Thank you in advance


data cache problems

when i use a json api datasource , i found a data cache problem.
i tried to update my json api , but the result on grafana not changed .
when i use curl command , it could show latest result , but grafana cannot.

What have you set the Cache time to? By default it caches the response for 5 minutes. If you want to disable caching, you can set it to 0 seconds.

well , i have already tried it, it not always worked .
let me take an example ,
i change the datasource url, and set the cache time to zero, what showed in query inspector is still the old datasource

Good point. We should probably invalidate the cache if the data source configuration has changed, which I don't believe we do today.


Update README.md

lol top priority fix?

For those ACM members confused by the random pull request from a 2 year old project,
Dude's going through seemingly random repos, making spelling changes or hitting format and submitting pull requests. If I had to go out on a limb, he probably has a job interview coming up and wants to boost his count.
I'd recommend doing more helpful things for the open source community. Here's a pretty good starting point: http://opensource.com/life/14/1/get-involved-open-source-2014

uhh anyway the pull could be removed? I was experimenting with "Propose file change." did realize it would start a pull request.
Sorry about that man.


Maxwords and shape as parameters, specific colors for abstracts and titles

add max. words and shape as parameter (approving)
Potential need to change script formatting later (e.g. to ensure that lines <80 char in length

The <80 char rule is not a hard rule; I usually use < 100 instead (we had that discussion a couple of dev meetings ago). If it makes no sense to make the row shorter, you can also tell pylint to ignore by adding the comment # pylint disable=line-too-long at the end of the line.


Which underlying libraries of AutoGluon uses GPU for training?

I have AutoGluon (both CPU and GPU version) installed and tried to train models on Tabular data. There doesn't seems to be much difference in terms of training time between the CPU and GPU version. I monitored the GPU usage when I trained models using the GPU version of AutoGluon and there was no GPU usage almost all the time. I'm curious which underlying libraries of AutoGluon train models using GPU?

GPU training is only enabled for image / text applications, but not for tabular yet.

@zhanghang1989 Thank you! Is there any plan to enable GPU for tabular data?

@jwmueller @Innixma

Yes we have plans to add GPU usage for Tabular. We are currently focused on optimizing CPU and ensuring stability. I expect GPU support to be added in the next 2-3 months, but potentially sooner if enough users express a desire for this feature in Tabular.

I have created a master issue for this: #263

@Innixma Thank you very much!


Request: setup Doxygen to generate gh-pages documentation

Easy guide to follow:
https://github.com/satu0king/Github-Documentation-With-Doxygen
Note that the one change from that documentation you'll need to make is enabling the following variables in the Doxyfile, in order to generate docs for functions:
EXTRACT_ALL = YES
EXTRACT_PRIVATE = YES
EXTRACT_STATIC = YES
EXTRACT_LOCAL_METHODS = YES

Hi @DeflateAwning thanks for creating an issue.
Agree this would be good to do. Will be adding it to the list of TODO items related to documentation/website.


"Allow user pinning" shows up in GCC but does not actually work

While the "Allow user pinning" setting shows up in the admin center UI, it does not actually work in GCC yet. Please include a callout on this page for the features that do not work in all clouds. This would save lots of support time and customer aggravation. Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f91604a-35b0-dfbb-55b2-b601cb0841b0
Version Independent ID: 84bcd0d7-b4ed-f13e-c84b-2ec6a7661ae9
Content: Manage app setup policies in Microsoft Teams - Microsoft Teams
Content Source: Teams/teams-app-setup-policies.md
Service: msteams
GitHub Login: @LanaChin
Microsoft Alias: v-lanac

The whole platform section could use some attention for accuracy with the different clouds. GCC does not have the same admin experience for Teams Apps as commercial.

@npherson Thank you for submitting feedback and contributing to the docs. We are currently investigating this.


Dispose WebView after closing

Hello!
I noticed that WebView in Android is not being destroyed after it's closed. As far as I can see in the plugin code (I'm not an Android developer), there is no explicit call to the webView.destroy() method anywhere.
Is this the correct behavior? Should it be fixed, even though it might break backward compatibility in some cases?
I recorded my observation on video.

screen recording
https://github.com/Cap-go/capacitor-inappbrowser/assets/3511312/7c96f625-119a-4f0a-aefa-2712f427ff7a

Can you open a Pr with your change?

i added it already after you report and forgot to tell you thanks for the report

i added it already after you report and forgot to tell you thanks for the report

Awesome! Thank you so much 🤝


Separate the buffer and the syncronizer functions in prim_mubi*_sync and prim_lc_sync cells

In order to eliminate lint issue and reduce complexity, it is suggested to remove the parameter AsyncON and add na new cells
prim_mubi*_buf and prim_lc_buf.
This will enable to bypass the enum error issue in Spyglass and the issue with Xecilum.
The current implementation when AsyncOn=0  only a buffer is generated and when the parameter is set to '1' a syncronizer
will be added.  These might create an issue with scanmode if 'no_scan' is not part of the instant name.
Adding the prim_mubi*_buf and prim_lc_buf can be done without the need to change the code.
In order to eliminate the parameter and fix the enum error, the code of the prim_mubi*_sync and prim_lc_sync needs to change
and also the code that uses thou cells. For buffer function it is simple use of the new cells. for syncronizers removing the
parameter is advisable.
@arnonsha

Thanks @Jacob-Levy. We've discussed this in the weekly Nuvoton meeting today.
For the Xcelium warning:
We ran into these as well and think it would be best to just promote the warning to an error.
This would have the least impact on the code base, since only the violating instances would have to be fixed (and we fixed already most of them). The fix is straightforward: either make sure the port type matches, or use curly braces around the output assignment .out_port_o({out_sig}) (CC @sriyerg).
For the concerns related to scan mode:
We would like to avoid changes that touch many modules in the design, since several modules (like lc_ctrl, otp_ctrl etc) that would be affected are already at D3. Since there is currently no issue with scan, the recommendation is to review the parameterization of the prim modules related to scan closely. We can still tag this as a future cleanup so that we can come back to it after ES.


Is it ok to use master branch in production env? MessageSend.StickerIDs seems missing in newest release(v0.27.1)

Is it ok to use master branch in product env?
MessageSend.StickerIDs seems missing in newest release(v0.27.1), but can be found in master.
https://discord.com/developers/docs/resources/channel#create-message

While it's not recommended to use master for production, it should be pretty stable.

While it's not recommended to use master for production, it should be pretty stable.

Any plan to publish a new release? It has been 9 months after last release.

Planning to do it sometime before Christmas!

@FedorLap2006 any updates on release plan? :)


Credit Commons

This is my tracker for notes while reading https://groups.google.com/g/network-money/c/iJ8p7dJZ4GA
We already talked about Federated LETS with Esteve / Komunitin last year, and I think it's definitely an important direction for Federated Bookkeeping.
I should also update https://michielbdejong.com/blog/21.html to mention it, especially since in historical perspective, https://creditcommons.net/assets/credit-commons.pdf was developed 2008-2016 so it predates LedgerLoops and Interledger in some important ways.
I love the statement about capitalism seeing "money as merchandise" in https://creditcommons.net/assets/credit-commons.pdf (page 5) and the distinction between "exchange rate" and "conversion rate" for currencies, emphasising that credit should not be treated as merchandise.

Credit Tree vs Credit Mesh is an important topic.
Interledger and Credit Commons take a tree approach.
LedgerLoops and Komunitin take a mesh approach.

Mentioning Credit Commons in my Network Ledger Technology blogpost: https://github.com/michielbdejong/michielbdejong.com/commit/72e6dd069d50e858f230af32a88c518beaaed7b7

https://www.youtube.com/watch?v=1koUpspA1jw&t=1265s "it's clear that nobody actually wants to own credit as an end in itself"


Support indicating impacted sub-areas and key objectives for SBA relationships

Relationships will be between applications and SBAs, but users will be allowed to also select which sub-areas (and key objectives?) are impacted by that relationship.

Yes, sub-areas and key objectives.

Thanks! Question mark has been removed.


soc: intel_adsp: cavs: fix dts memory address format

Fix the following compilation warning:
Warning (unit_address_format): /memory@0xb0000000: \
    unit name should not have leading "0x"

I also get this warning sometimes:
/home/ycsin/zephyrproject/build/zephyr/zephyr.dts:116.16-119.5: Warning (simple_bus_reg): /soc/timer: missing or empty reg/ranges property


Percentage grid structure

Hello,
Do you have a structure like I want?
When I write "four" I want a format that can be "4 * 4 = 16" instead of "100/4 = 25%".
I made a picture to explain it better.

I wrote it the way I wanted.
I share with your.
https://drive.google.com/drive/folders/0ByGRCqOwP1AWX0dseFVSMUExWFE?usp=sharing

Hi @oguzhansari, it actually exists:

Same works for .row containers.


Mode 120 sometimes misses

Sometimes the star is missed by a minute or so

This was due to an indexing error in the possible possibles loop in Mode120 timeline generator


Parameterized k8s volume mount in session config

Fixes #47

Codecov Report

Merging #100 (5aa8a26) into main (1d2a541) will decrease coverage by 12.42%.
The diff coverage is 22.22%.

@@             Coverage Diff             @@
##             main     #100       +/-   ##
===========================================
- Coverage   78.05%   65.62%   -12.43%
===========================================
  Files          50       49        -1
  Lines        4511     4349      -162
===========================================
- Hits         3521     2854      -667
- Misses        990     1495      +505

Impacted Files
Coverage Δ

python/graphscope/client/session.py
63.56% <ø> (-9.52%)
:arrow_down:

python/graphscope/deploy/kubernetes/cluster.py
22.82% <0.00%> (-49.38%)
:arrow_down:

...n/graphscope/deploy/kubernetes/resource_builder.py
28.85% <21.21%> (-32.85%)
:arrow_down:

python/graphscope/config.py
100.00% <100.00%> (ø)

python/graphscope/interactive/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

python/graphscope/interactive/query.py
0.00% <0.00%> (-94.65%)
:arrow_down:

python/graphscope/deploy/kubernetes/utils.py
12.69% <0.00%> (-61.43%)
:arrow_down:

python/graphscope/analytical/app/triangles.py
80.00% <0.00%> (-20.00%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2a541...5aa8a26. Read the comment docs.

Codecov Report

Merging #100 (5aa8a26) into main (1d2a541) will decrease coverage by 12.42%.
The diff coverage is 22.22%.

@@             Coverage Diff             @@
##             main     #100       +/-   ##
===========================================
- Coverage   78.05%   65.62%   -12.43%
===========================================
  Files          50       49        -1
  Lines        4511     4349      -162
===========================================
- Hits         3521     2854      -667
- Misses        990     1495      +505

Impacted Files
Coverage Δ

python/graphscope/client/session.py
63.56% <ø> (-9.52%)
:arrow_down:

python/graphscope/deploy/kubernetes/cluster.py
22.82% <0.00%> (-49.38%)
:arrow_down:

...n/graphscope/deploy/kubernetes/resource_builder.py
28.85% <21.21%> (-32.85%)
:arrow_down:

python/graphscope/config.py
100.00% <100.00%> (ø)

python/graphscope/interactive/__init__.py
0.00% <0.00%> (-100.00%)
:arrow_down:

python/graphscope/interactive/query.py
0.00% <0.00%> (-94.65%)
:arrow_down:

python/graphscope/deploy/kubernetes/utils.py
12.69% <0.00%> (-61.43%)
:arrow_down:

python/graphscope/analytical/app/triangles.py
80.00% <0.00%> (-20.00%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2a541...5aa8a26. Read the comment docs.


EBS volume attachments for unattached volume is not null

Describe the bug
I'm querying for unattached EBS volumes daily.
select volume_id, size, attachments from aws_all.aws_ebs_volume as v where state = 'available' and attachments is null
I've copied it from the examples in the steampipe.io site.
It used to work until last update
Now attachments is no longer null it is empty array instead, so I modified the script to be:
select volume_id, size, attachments from aws_all.aws_ebs_volume as v where state = 'available' and attachments = '[]'
The example still on site https://hub.steampipe.io/mods/turbot/aws_thrifty/queries/unattached_ebs_volumes
Steampipe version (steampipe -v)
steampipe version 0.16.4
Plugin version (steampipe plugin list)
+--------------------------------------------------+---------+----------------------------+
| Name                                             | Version | Connections                |
+--------------------------------------------------+---------+----------------------------+
| hub.steampipe.io/plugins/turbot/aws@latest       | 0.80.0  | aws_dev,aws_sanity,aws_all |
| hub.steampipe.io/plugins/turbot/steampipe@latest | 0.6.0   | steampipe                  |
+--------------------------------------------------+---------+----------------------------+
To reproduce
select volume_id, size, attachments from aws_all.aws_ebs_volume as v where state = 'available' and attachments is null
Expected behavior
It should list the unattached volumes and instead I'm getting an empty result
Additional context
Add any other context about the problem here.

Hello @eyalliss, while digging into this bug, we figured out that the SDK(AWS Go SDK V2) changed the API response from null to [] in the event of EBS volumes not having any attachments, hence the attachments column changed the response from null to [].
It might become cumbersome to change the code each time an API response changes, keeping that in mind we decided to update all the instances of aws_ebs_volume queries where the attachments column is being queried.
Updates made across different mods:
https://github.com/turbot/steampipe-mod-aws-insights/pull/206
https://github.com/turbot/steampipe-mod-aws-thrifty/pull/102
Update made to the aws_ebs_volume table doc:
https://github.com/turbot/steampipe-plugin-aws/pull/1368
Once again, thank you for catching the bug, which had slipped from our radar 👍 .


Feature request - Implement interface to be able to mock the api client

I would like to test a service, which uses the API client by unit tests. Unfortunately, this is only possible to a limited extent, since there are no interfaces for the ApiClient and the individual [...]EndPoint classes. My only possibility is to wrap the complete client and the required endpoints.
Here is an example.
[Fact]
public void ShouldThrowExceptionIfOrdersCantBeFetched()
{
    // Arrange
    var orderEndPointMock = new Mock<OrderEndPoint>();

    orderEndPointMock
        .Setup(s => s.GetOrderList(
            It.IsAny<DateTime>(),
            default,
            default,
            1,
            default,
            default,
            It.IsAny<List<string>>(),
            default,
            default,
            default,
            default))
        .Throws<Exception>();

    _billbeeApiClientMock
        .Setup(s => s.Orders)
        .Returns(orderEndPointMock.Object);

    // ...
}

This test fails with the Exception:
Non-overridable members (here: OrderEndPoint.GetOrderList) may not be used in setup / verification expressions.

And I can't override the OrderEndPoint and just add an interface, because the constructor is internal ...


Do not trim whitespace when part of strings or regexes

Fixes https://github.com/microsoft/vscode/issues/195010. If the token to be removed is part of a string or a regex, then we do not want to remove the character, as it is very likely semantically important.
Before I mark this as ready to review, I need some help with how to approach testing this. Presumably, tests need to go in trimTrailingWhitespaceCommand.test.ts, but I'm going to need a language in the unit test suite with standard token types. Is there an example of this that isn't creating an entire language provider just for the test? Every example of testTextModel.createTextModel that I can see that has a language makes an entire custom one just for the test; if this is the only approach, I could use someone to point out what things I'll need to mock to test this. I would also like to add some integration tests, particularly around whitespace after the end a string, to ensure that it works with real tokenization as well.
The other open question I have is whether this behavior should be on by default, or if we need to update the trim whitespace option to have a "trim except in strings and regexes" option, as this behavior may not be desired by some?

@hediet, since you're the assignee on #195010, would you be able to comment on my questions above?

Not sure how viable this is, but I actually prefer trailing whitespace in multiline strings to be trimmed most of the time (in JS), but in some cases it's not desirable (specifically for tests). Perhaps there is a way to alter this behavior just for test files?

@hediet or @alexdima, thoughts on my questions? Given the comment from @coreyward on just this draft PR, I'm definitely leaning towards "needs an option switch". Personally, I do not want whitespace trimming in a multiline string, ever, in any file, regardless of whether it's a test file or not. It could be a regex component, or part of a piece of markdown where trailing   matters.

I think this should be behind an opt-in flag.
Also, I think when this flag is enabled, trimming whitespace should wait on the tokenization to complete.

@hediet I think I've plumbed through a setting for this correctly, but I could still use some pointers on how to test this appropriately.

Talked with @hediet offline. With the end of year coming up there isn't a lot of bandwidth to look at a change like this at the moment, given the potential costs of tokenization for the file. I'll ping again in January.

For testing, please see existing unit tests for tokenization. Basically you should create a fake language with a static tokenizer where you set tokens manually. Then look for tests that test TrimTrailingWhitespaceCommand (or other commands) and try to run the command on the text model with the fake language.

@alexdima thanks for picking this up! Really appreciate it, I've been very busy with other things and was unlikely to get back to this for another few months.


[Request] Blinking Power LED when in sleep mode

If it is possible, it would be nice if the Power LED would flash in sleep mode. Or best of all, if the LED slowly darkens and then slowly brightens again. Just like many power LEDs of laptops in sleep mode do. So you can see immediately that the device is in standby and not crashed or something like that.

It is not possible as it's a hardware limitation.  While on or asleep, the led can only be set to solid green, solid red, or solid yellow.  No other options are available at this time.


Datagen compatibility for timestamps and Neo4j timestamps

The converter class claims that:
https://github.com/ldbc/ldbc_snb_implementations/blob/43d47b96bc407bf29970c75e48256827c25c6437/common/src/main/java/com/ldbc/impls/workloads/ldbc/snb/converter/Converter.java#L41-L42
This is no longer true as Datagen now produces RFC 3339-compliant timestamps which represent GMT+0 as 00:00. We need to revise this.
cc @jackwaudby

Also, the Neo4j timestamps are not implemented properly:
https://github.com/ldbc/ldbc_snb_implementations/blob/43d47b96bc407bf29970c75e48256827c25c6437/cypher/src/main/java/com/ldbc/impls/workloads/ldbc/snb/cypher/converter/CypherConverter.java#L15

Resolved by 3baaf76a5386df356436398bb5a45dca828053e7


PS> <IP_ADDRESS>
PS> # NOT RETURN ANYTHGING

PS> perl6 -e 'say 1_000_000_000'
1000000000

PS> @'
>> fn main() {
>>  let s = 1_000_000_000;
>>  println!("{}",s);
>> }
>> '@ > ./num.rs

PS> rustc .\num.rs

PS> ./num.exe
1000000000

in this example i compared between rust, raku and PS....like you see rust and raku use "_" underscore to separate betwwen number and its much clean...but in PS with "." dot it not return anything.

PowerShell doesn't have a number separator like that. I have previously proposed to add an underscore numeral separator, but it was vetoed during review of the PR a year or two back, I think.
When you do 1.000 PowerShell sees that as a floating point number with the value 1.000. If you then attempt to use another dot, PowerShell assumes you want to access a property, but 1.000 as a numeric value has no property named .000 and so it will return $null, and further property access from that point will continue to return $null.
<IP_ADDRESS> tells PowerShell:

make a number, 1.000 (floating point, double)
access the property of that number called 000 (null)
access the property of that value called 000 (null again)

its crazy thing:
PS C:\> [string]::IsNullOrWhiteSpace(<IP_ADDRESS>)
True
PS C:\>

but this is considered a bug

its crazy

PS C:\> [string]::IsNullOrWhiteSpace(<IP_ADDRESS>)
True
PS C:\>

the code its writtin to human not to machine...the parser is not intelligent

@p0W3RH311, no that's just a consequence of the behavior that @vexx32 explained: your command is in effect equivalent to:
[string]::IsNullOrWhiteSpace($null)

Clearly, . is unsuitable as a culture-invariant thousands-grouping separator, given that . is the culture-invariant decimal mark.
By contrast, _ as the thousands-grouping separator in number literals indeed would make sense - but has apparently been rejected.

For reference: https://github.com/PowerShell/PowerShell/pull/7993#issuecomment-442651543
You might still find the implementation code in the older commits there, if there is interest in revisiting it.

@mklement0 Indeed, I forgot about the context here, and my comment was harsh - and uncalled for; please accept my apologies.


[HUDI-5081] Tests clean up in hudi-utilities

Change Logs
Some minor changes for some tests to make sure that resources are cleaned up properly.
Impact
Only impact is more consistent test execution.
Risk level
None
Documentation Update
None
Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

CI failure due to unrelated flakiness. this change is only for utilities tests, which have passed.


Adding COM apartment variable support (wil/com_apartment_variable.h)

Apartment variables are stored in the current COM apartment, every apartment has unique storage. When the apartment runs down the variables are released. This avoids the problems of using COM objects in global variables and enables caching of information relative to the apartment. These variables are produced by a function that is used as the key for the storage.

auto fn() { return 42; };

void example_use()
{
    auto v = wil::get_for_current_com_apartment(fn);

    wil::reset_for_current_com_apartment(fn, 43);

    wil::reset_for_current_com_apartment(fn);

Edit (6/19): based on Raymon's feedback I committed to the strict version of reset_for_current_com_apartment with newValue and the non-strict version with no param.
if you have more feedback please leave it.

Yet another option would be to declare a specific type like wil::apartment_variable<T> which you declare and then use like:
wil::apartment_variable<std::wstring> loggerName;
std::wstring GetNewLoggerName() { /* ... */ }
void LogThings() {
   auto name = loggerName.get_or_default(&GetNewLoggerName);
}
void UseLogIfPresent() {
    std::optional<std::wstring> ifSet = loggerName.get();
    if (ifSet) {
        /* .. */
    }
}
void Update() {
    loggerName.set(L"c:\\kittens.txt");
}

Where internally, apartment_variable<> keeps a `static std::atomic<unsigned long>` that it pulls from a module-wide `std::atomic<unsigned long>` which is the variable high-water mark.

Minimally, there's a lot of code in the template method that can't be comdat-folded but doesn't depend on the `T` template parameter. Could it be hoisted into a non-templatized helper to reduce code duplication?

I like @jonwis's wil::apartment_variable<T>. The apartment variable's address becomes the key to the map: std::unordered_map<wil::details::apartment_variable_base*, std::any>.
Expanding on Jon's suggestion:
template<typename T>
struct wil::apartment_variable
{
    apartment_variable() = default;
    ~apartment_variable(); // clears all objects across all apartments

    // non-copyable, non-assignable
    apartment_variable(apartment_variable const&) = delete;
    void operator=(apartment_variable const&) = delete;

    // get current value or throw if no value has been set
    T& get_existing();

    // get current value or default-construct one on demand
    T& get_or_create();

    // get current value or custom-construct one on demand
    T& get_or_create(T (*creator)());

    // get pointer to current value or nullptr if no value has been set
    T* get_if();

    // replace or create the current value
    void set(T value);

    // remove any current value
    void clear();
};

The get and get_if methods return a reference/pointer to the actual value, so it can be modified in place.
Usage patterns:
wil::apartment_variable<std::wstring> loggerName;

std::wstring GetNewLoggerName() { /* ... */ }

void LogThings() {
    auto& name = loggerName.get_or_create(&GetNewLoggerName);
    log_to_file(name);
    if (log_file_getting_big())
    {
        name = GetNewLoggerName(); // roll over to new log file
    }
}

void UseLogIfPresent() {
   auto name = loggerName.get_if();
   if (name) log_to_file(*name);
}

void StartNewLogger() {
     loggerName.set(GetNewLoggerName());
};

wil::apartment_variable<int> widgetCount;

void UpdateWidgetCounter()
{
    ++widgetCount.get_or_create();
}

As for comdat folding: Pretty much everything can be hoisted into this base class:
struct wil::apartment_variable_base
{
    apartment_variable_base() = default;
    ~apartment_variable_base();

    // non-copyable, non-assignable
    apartment_variable_base(apartment_variable_base const&) = delete;
    void operator=(apartment_variable_base const&) = delete;

    // get current value or throw if no value has been set
    std::any& get_existing();

    // get current value or default-construct one on demand
    std::any& get_or_create();

    // get current value or custom-construct one on demand
    std::any& get_or_create(std::any (*creator)());

    // get pointer to current value or nullptr if no value has been set
    std::any* get_if();

    // replace or create the current value
    void set(std::any value);

    // remove any current value
    void clear();
};

Specialized version would perform last-second conversion to/from std::any.
template<typename T>
struct wil::apartment_variable : apartment_variable_base
{
    using base = apartment_variable_base;

    // get current value or throw if no value has been set
    T& get_existing() { return std::any_cast<T>(base.get_existing()); }

    // get current value or default-construct one on demand
    T& get_or_create() { return std::any_cast<T>(base.get_or_create()); }

    // get current value or custom-construct one on demand
    T& get_or_create(T (*creator)())
    { return std::any_cast<T>(base.get_or_create([creator]() { return std::any(creator()))); }

    // get pointer to current value or nullptr if no value has been set
    T* get_if() { return std::any_cast<T>(base.get_if()); }

    // replace or create the current value
    void set(T value) { return base.set(value); }

    // remove any current value
    using base::clear;
}

I like @jonwis's wil::apartment_variable too and I really appreciate you filling in the implementation details. I'm going to take a run at that version.

Now documented here


update of ng-recaptcha for angular 6

ng-recaptcha need to be updated to use in angular 6
meanwhile rxjs-compat is going to be used

Add reference to the external issue please

Also found this. https://github.com/DethAriel/ng-recaptcha/issues/107

@Israel-94 you can continue with this issue please.


Bump rancher-desktop-agent to 0.1.2 for iptables fix

I've created rancher-desktop-agent-v0.1.2 in https://github.com/rancher-sandbox/rancher-desktop-agent/pull/2


TLS configurability

Would you accept a contribution to allow a caller to supply the private key and certificate instead of always using the embedded pfx file?

Hi @bimargulies-google
Sorry for the late reply! I first had to do some research on how to best accept contributions for an open-source project under Apache License 2.0 while minimizing the "bureaucracy".

Would you accept a contribution to allow a caller to supply the private key and certificate [...]

Yes, such a contribution would be very welcome.
Please have a quick look at https://github.com/smarkwal/vtestmail/blob/main/CONTRIBUTING.md.
Best,
Ste

Hello Stephan. OK, I'll send you a PR in the next day or so.
On Mon, Aug 28, 2023 at 6:04 AM Stephan Markwalder @.***>
wrote:

Hi @bimargulies-google https://github.com/bimargulies-google
Sorry for the late reply! I first had to do some research on how to best
accept contributions for an open-source project under Apache License 2.0
while minimizing the "bureaucracy".
Would you accept a contribution to allow a caller to supply the private
key and certificate [...]
Yes, such a contribution would be very welcome.
Please have a quick look at
https://github.com/smarkwal/vtestmail/blob/main/CONTRIBUTING.md.
Best,
Ste
—
Reply to this email directly, view it on GitHub
https://github.com/smarkwal/vtestmail/issues/43#issuecomment-1695665544,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AF7SDZPCV3VPUB4CX3IGJYDXXSJO3ANCNFSM6AAAAAA3S4H7Y4
.
You are receiving this because you were mentioned.Message ID:
@.***>


LLM provider traces (e.g. OpenAI) don't handle images in the messages array

Description
You can include images for vision with certain LLM provider APIs like OpenAI. The structure is slightly different and as a result it's not showing up in the UI. This also means that content sent in this structure won't show up even if it's just text.
Here is an example of the code that I would like to render images but instead only shows the raw json:
messages = [
    {"role": "user", "content": [{"type": "text", "text": "Recommend a book"}]
    {"role": "user", "content": [{"type": "image_url", {"url": "https://..."}}]
]

Neither of the above show up pretty in the UI like I would like. Taking a look at the code, it seems like this is because the UI only handles the non-list str messages array structure e.g. {"role": "user", "content": "Recommend a book"}
Python, Logfire & OS Versions, related packages (not required)
No response

I have a similar issue when using the assistants and thread api's.
Log:Unable to instrument OpenAI API call: Expected options.json_data to be a dictionary

@PauloFavero I think that is a separate issue from the one @willbakst is mentioning in this issue, which is a pure frontend problem. If you could provide some additional context about how to reproduce the issue we can look into it.
@willbakst I believe I have a fix for this for the "default" panel, but I'd like to coordinate with you (or Brendan or anyone else from Mirascope) how to modify the Mirascope version of that panel to achieve the same thing. I know I still owe you guys a way to submit updates via a public repository; I am hoping to have a significant chuck of time to invest in custom panels infrastructure early next week.

@dmontagu I appreciate that. Let me know how you want us to work with you here to update our panels.

@dmontagu I also want to see this issue being resolved. Do you know whether this issue is already in progress?


bug: ion-radio in an ion-list prevents ion-option-butto

Type: bug
Ionic Version: 1.x
Platform: all
https://github.com/driftyco/ionic/issues/2714
But my issue is with radio-list.. I need to make a radio-list with ion-option-button, but when you try to combine this components, the ion-option-button don't work in the radio area..

Its simples to reproduce.. Try to combine ion-radio with ion-option-button..

@mlynch can you help?

someone? bump!!

Hi @danielptn and others,
The Ionic team is looking at this issue and we are trying to understand the use cases for swipeable toggles/checkboxes/etc. Can you elaborate on that please so we can better understand it?
As it stands now, I don't think we'll support this functionality in Ionic 1.x
Please let us know your thoughts on the topic and if viable alternatives exist. Please at mention @jgw96 in your response so he can stay on top of it.
Thanks,
Dan


Improved handling of non-ASCII characters in transcript printing and JSON output from yt command

What this PR does
Improved handling of non-ASCII characters in transcript printing and JSON output from yt command

Updated print(transcript) to handle non-ASCII characters correctly.
Modified print statements to use ensure_ascii=False in json.dumps for correct display of non-ASCII characters.
Implemented exception handling to manage potential UnicodeEncodeErrors, ensuring fallback encoding to avoid garbled text.

This change enhances the readability of outputs containing non-ASCII characters and addresses potential encoding issues across different environments.
Related issues and Screenshots
See this issue: https://github.com/JFK/fabric/issues/1

We're getting ready to migrate to Golang; please resubmit then if this hasn't been addressed. Thank you!


Build refactor to tleap

I'm currently leaving build.py in place until we're sure tleap.py can take its place.

Turns the build/solvate routines into a tleap.System class
Allows building an in vacuo prmtop
Restores two logic gates in adjust_buffer_value which got left out during last refactoring. The new logic significantly decreases the number of adjustment cycles necessary to complete solvation.  It required the addition of a cyc_since_last_exp_change variable.  @slochower probably won't like it (ha) but I'm fine with reformulating as long as we keep all the logic.
Allows an option to not write out prmtop/inpcrd during run().  This speeds up the time for each buffer_value adjustment cycle. For example,  cb6-but solvation with 2922 water decreases from 10 seconds to 6 seconds (~11 cycles total).
adds test_tleap.py with all the same tests that we had in test_build.py.
Adds documentation to all class variables.
Do we check change in volume often enough?
Biggest concern: it looks like I've completely blown away the attribution history for the code. This was not intentional and most of the refactoring was completed by @slochower in https://github.com/slochower/pAPRika/pull/46.  Not sure if there is a good way to recover ...

wow, this is crazy.  test_build crashed in my pull request ... I'm pretty sure it died due to a problem the adjust_buffer_value in build.py that I've fixed in tleap.py.  Fortuitous that we caught it here, but it also highlights the unusual nature of our tests due to picking random waters.  I like doing that because over many tests we can actually explore lots of combinations of convergence, but any given test is not a predictable test of a specific sequence of code.

Ah, so it was a good idea to pick random number of waters. Nice. What was the bug? I haven’t looked at the PR yet.
Sent from my iPhone

On Mar 30, 2018, at 20:19, Niel Henriksen<EMAIL_ADDRESS>wrote:
wow, this is crazy. test_build crashed in my pull request ... I'm pretty sure it died due to a problem the adjust_buffer_value in build.py that I've fixed in tleap.py. Fortuitous that we caught it here, but it also highlights the unusual nature of our tests due to picking random waters. I like doing that because over many tests we can actually explore lots of combinations of convergence, but any given test is not a predictable test of a specific sequence of code.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.

Generally looks good to me and I feel like I understand it well now, but fix the little tidbits mentioned above, and then we can merge and replace the existing solvate code.

Do you understand the difference between continuous-integration/travis-ci/push and continuous-integration/travis-ci/pr here? The former passes but the latter doesn't. Does that somehow mean your latest push to the branch builds successfully but your PR overall doesn't?

My understanding is that it ran a Travis test for my last push to my build-refactor-to-tleap and a test for what the master code would look like after my pull request.  And I'm pretty sure the reason one failed and the other didn't is just a chance event where test_build picked a random water number that the existing build.py couldn't solve within 50 rounds.  So I think it's just a random event.  I've found that test_build fails like 25% of the time if you just repeat it over and over ... not sure if you noticed that.

Since you plan to deal with the tests in another PR, I guess it's fine to merge this now. But let's not lose track of some of things above. Can you make a brief list and dump that somewhere? Issues?

The new changes in #966d925 look like stuff in test/. Do you want me to review this?

I'm a little confused ... I made a bunch of changes to tleap.py as well ...

I see only 5 changed files for that single commit.

I got to that link by clicking here.

Codecov Report

Merging #50 into master will increase coverage by 1.11%.
The diff coverage is 90.03%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   82.88%   83.99%   +1.11%
==========================================
  Files          10       11       +1
  Lines        1326     1587     +261
==========================================
+ Hits         1099     1333     +234
- Misses        227      254      +27

Impacted Files
Coverage Δ

paprika/utils.py
77.77% <ø> (ø)
:arrow_up:

paprika/tleap.py
90.03% <90.03%> (ø)

paprika/build.py
88.7% <0%> (-0.42%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c720b5b...595bcdb. Read the comment docs.

Okay, great! Looks good!

  Still working on removing buffer_target and making sure we don't execute run() too much.

Also, fyi, the changes in files in the test/cb6-but folder was due to me accidentally deleting some files that other tests required which I didn't realize.


Fix abort functionality on Right Click when performing transformations

Ensures Abort and Redraw events are added to the responses when an Abort event occurs.

!build


Video: disable open-on-hover for Quality and Speed Selector

Every time I try to seek towards the end with the mouse, these popups appear because the mouse went past their buttons.
They should probably only appear after clicked.

I'll add this here, since it's also about hover stuff on the player: The volume hover seems to not load properly until clicked:
https://user-images.githubusercontent.com/44294954/158994790-52b7ecb4-c86b-4640-bba9-065170a503a7.mp4


Handle BigQuery 503 error

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:
https://issues.apache.org/jira/browse/AIRFLOW-667
We have encountered this issue few times in our production environment. I added this fix based on google's documentation.
https://cloud.google.com/bigquery/troubleshooting-errors
"This error returns when there is a temporary server failure such as a network connection problem or a server overload. In general, wait a few seconds and try again."
Testing Done:
Tests are done connecting to BQ tables using the PR code.
Subject - Handle BigQuery 503 error
added retry feature if BigQuery error is 500 or 503
set the retry time for 5 seconds

Current coverage is 66.56% (diff: 100%)

Merging #1938 into master will increase coverage by <.01%

@@             master      #1938   diff @@
==========================================
  Files           135        135
  Lines         10181      10181
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           6776       6777     +1
+ Misses         3405       3404     -1
  Partials          0          0

Powered by Codecov. Last update 2306892...70f46dd

When testing, did you actually experience a 500 error, and the code worked properly?

Thanks!


Phase_ramp + line_filter

Dear Alex,
I created two functions: phase_ramp and line_filter_function. No test files so far.
I didn't finish line_filter_function. I got stuck with the rotated rectangle. Don't know how to assign the chosen area to the image. Maybe there should be some smart way. You may have some good ideas.
Contributor Checklist:

[ ] I have added or updated my entry in the creators.json file
[ ] I have added a changelog entry for my contribution
[ ] I have added/updated documentation for all user-facing changes
[ ] I have added/updated test cases
[ ] I have included the rebuilt production build of the client (only if
changes were made to the GUI)

Please remove this section
Starting by submitting an incomplete pull request (PR) or draft PR is OK. You
can work on the checklist step by step by pushing additional commits into the
PR. Please indicate if you think some items may not be applicable.
You can have a look at our contributing
docs for more
information on contributing to LiberTEM. Please feel free to ask for
clarification and help, for example in your PR description, with comments or in
our Gitter channel.
Thank you for your contribution!

Hi, and thanks for the contribution!

I created two functions: phase_ramp and line_filter_function. No test files so far.

I think we can work on the tests when the functionality is there. Then, as a first step, the test failures need to be fixed - this should be possible without adding a new test. All test environments, except for mypy, should have a green check-mark.

I didn't finish line_filter_function. I got stuck with the rotated rectangle. Don't know how to assign the chosen area to the image. Maybe there should be some smart way. You may have some good ideas.

Without reinventing the wheel, maybe you can use skimage.draw.polygon, and rotate by transforming the vertices?
As a general idea, maybe finding and correcting the phase ramp could be decoupled into two separate functions - this would make it possible to perform aggressive filtering (for example, low-pass) before looking at the minimum/maximum, and then remove the ramp from the unfiltered hologram. What do you think?

Hi, and thanks for the contribution!

I created two functions: phase_ramp and line_filter_function. No test files so far.

I think we can work on the tests when the functionality is there. Then, as a first step, the test failures need to be fixed - this should be possible without adding a new test. All test environments, except for mypy, should have a green check-mark.

I didn't finish line_filter_function. I got stuck with the rotated rectangle. Don't know how to assign the chosen area to the image. Maybe there should be some smart way. You may have some good ideas.

Without reinventing the wheel, maybe you can use skimage.draw.polygon, and rotate by transforming the vertices?
As a general idea, maybe finding and correcting the phase ramp could be decoupled into two separate functions - this would make it possible to perform aggressive filtering (for example, low-pass) before looking at the minimum/maximum, and then remove the ramp from the unfiltered hologram. What do you think?

Hi, and thanks for the contribution!

I created two functions: phase_ramp and line_filter_function. No test files so far.

I think we can work on the tests when the functionality is there. Then, as a first step, the test failures need to be fixed - this should be possible without adding a new test. All test environments, except for mypy, should have a green check-mark.

I didn't finish line_filter_function. I got stuck with the rotated rectangle. Don't know how to assign the chosen area to the image. Maybe there should be some smart way. You may have some good ideas.

Without reinventing the wheel, maybe you can use skimage.draw.polygon, and rotate by transforming the vertices?
As a general idea, maybe finding and correcting the phase ramp could be decoupled into two separate functions - this would make it possible to perform aggressive filtering (for example, low-pass) before looking at the minimum/maximum, and then remove the ramp from the unfiltered hologram. What do you think?

I update line filter following your suggestion. Please have a check.
I think it is a good idea to separate finding and correcting phase_ramp. Now this function is very basic. Still a lot needs to improve.

@FENGSHAN95 if you run the tests locally before pushing, you can get a faster turn-around. See https://libertem.github.io/LiberTEM/contributing.html#running-the-tests for instructions!

@FENGSHAN95 if you run the tests locally before pushing, you can get a faster turn-around. See https://libertem.github.io/LiberTEM/contributing.html#running-the-tests for instructions!

I will have a look. Sorry that I am not that familiar with coding.

@FENGSHAN95 do you have a local example to test your changes? Some test data and a test notebook?

@FENGSHAN95 do you have a local example to test your changes? Some test data and a test notebook?

Yes. I have.

@FENGSHAN95 Your change causes a syntax error in CI: https://travis-ci.com/github/LiberTEM/LiberTEM/jobs/389291762#L279. Why doesn't it happen if you run the same code locally using your test data and a test notebook? Can you make sure that your changed code is actually executed by your test notebook, for example with a print() statement?

@FENGSHAN95 Your change causes a syntax error in CI: https://travis-ci.com/github/LiberTEM/LiberTEM/jobs/389291762#L279. Why doesn't it happen if you run the same code locally using your test data and a test notebook? Can you make sure that your changed code is actually executed by your test notebook, for example with a print() statement?

Thank Alex. Now most of the errors should be fixed.

I'm going to close this as it was moved to https://github.com/LiberTEM/LiberTEM-holo


merge output includes UTF-8 byte-order-marks

After upgrading cyclonedx-cli from v0.16.0 to v0.19.0, it was observed that XML BOMs produced by the merge command started being rejected when uploaded to Dependency Track v4.3.6.
The issue is that cyclonedx-cli merge now produces XML BOM files with UTF-8 byte-order-marks, unlike the earlier version, and Dependency Track rejects such files as invalid. Arguably, that's a DT bug, reported separately (https://github.com/DependencyTrack/dependency-track/issues/1214)
Steps to reproduce
Merge two XML BOM files using cyclonedx-cli v0.19.0 and 0.16.0, respectively, and compare the outputs. The two files are identical, except for the UTF-8 byte-order-mark present in the later version.
The attached ZIP file includes sample input (bom1.xml and bom2.xml) and output files: merge-sample-with-byte-order-mark.zip
> cyclonedx-win-x64 --version
0.16.0
> cyclonedx-win-x64 merge --input-files bom1.xml bom2.xml --output-file output-0.16.xml

The output-0.16.xml file has no UTF-8 byte-order-mark:

When uploaded to DT, it is processed as expected:

INFO [BomUploadProcessingTask] Processing CycloneDX BOM uploaded to project: dcb2d96d-2387-4f39-9c8d-33d195040d90

Repeat these steps with the latest version, and note that now a UTF-8 byte-order-mark is present:
> cyclonedx-win-x64 --version
0.19.0
> cyclonedx-win-x64 merge --input-files bom1.xml bom2.xml --output-file output-0.19.xml

When uploading this output-0.19.xml file to DT, it is rejected:

WARN [BomUploadProcessingTask] The BOM uploaded is not in a supported format. Supported formats include CycloneDX XML and JSON

The only difference between the accepted and rejected BOM files is the presence or absence of the UTF-8 byte-order-mark.

Just ran into this when trying to use cyclonedx-cli via the Docker image. When trying to read the file within Maven, BomParserFactory.createParser throws an exception on line 55 as byte 0 is not one of the expected values (123 or 60). This seems to relate to the byte-order mark set on the file.
In BASH is it possible to remove this with sed -i $'1s/^\uFEFF//' your-bom.xml
Not ideal, but at least it is possible to workaround.

I also just encountered this, but this only occurs with how you execute the CLI tool.  If run from powershell that has not fixed this BOM issue (Ours is old because our Azure DevOps server also runs an older powershell), once you write out the file, you'll need to do a fix like above, or cheat by doing something like this, due to Set-Content correctly setting data without the BOM.
$jsonFile = Get-Content jsonmerge.json
$jsonFile | Set-Content -Path jsonmerge2.json


Add specific dependencies versions in bower.json

I'm working with Foundation framework and I have got recently a problem with the library. The problem is that Modernizr library has been updated to version 3.0 and this version has some major changes that are not compatible with Foundation. With the dependency set as >= 2.7.2 in the bower.json file, with a bower installit retrieves the most updated version of the library (3.0, incompatible) instead of an actually working version of Modernizr (between 2.7.2 to 2.8.3 have been working in my project).
Can it be fixed? Is better practice to set relative version dependencies insted of specific ones?
Thanks.

Just come across this on our sites after deploying new code when bower update runs because the dependency is set to >= it goes and grabs 3.0.0 of modernizr and breaking our sites by modernizr.js no longer existing

Same problem right here! This broke a lot of projects from us this week. Please set fix versions or make foundation compatible to modernizr 3-

Yes - modernizr 3.0 comes with breaking changes. Until everything is tested for 3.0, we've locked in modernizr on the latest tested version.
"modernizr": "2.7.2",

We'll push it up to 2.8.3 since it was tested good on that version.


Name in poor taste?

Just throwing it out there. I'm sure it's not intentional, but — especially given current state of affairs in the world — another name might not be a bad idea.

Closing because of #14


Ignore generated files in diffs

See https://help.github.com/en/github/administering-a-repository/customizing-how-changed-files-appear-on-github

Great idea!


chore: update pride logo

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[x] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[x] Tested Locally
[x] Optional Screen Shoot.

LGTM. Can merge in when we want to make the switch.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

OK, merging in


Node-Ffi runs perfectly for first time and then gives segmentation fault 11 or garbage value

My index.js file is as follows:
var ffi = require('ffi')
var libREmake_web = ffi.Library('/Users/Documents/rematch/src/src/libtest_web', {
    'UploadSingleRule': ['string',['string','string']],
    'UploadFile': ['string',['string','string']]
})

var output = libREmake_web.UploadFile("input.json","targetfile.json")
console.log(output)

My C++ file is as follows:
#if defined(WIN32) || defined(_WIN32)
#define EXPORT __declspec(dllexport)
#else
#define EXPORT
#endif

extern "C" {

/// Prototypes
static std::string
ConvertToJson(const size_t &num,
const std::vector &result,
const std::string &error);

EXPORT const char *remake::UploadSingleRule(const std::string &rule,
const std::string &targetFile) {
//code
const char *jsonReply = json.c_str();
return jsonReply;
}

EXPORT const char *remake::UploadFile(const std::string &filename,
const std::string &targetFile) {
//code
const char *jsonReply = json.c_str();
return jsonReply;
}

C++ header file:
#ifndef REMAKE_WEB_H
#define REMAKE_WEB_H

extern "C" {
namespace remake {

const char *UploadSingleRule(const std::string &rule,
const std::string &targetFile);
const char *UploadFile(const std::string &filename,
const std::string &targetFile);
}
}

#endif

Output:
$ node index.js
{
"Number": "1",
"Error": "",
"Regex": ""
}

$ node index.js
Segmentation fault: 11
$ node index.js
@<�

Kindly let me know where I am going wrong as it gives me correct output for the first time I run it and then it keeps giving segmentation fault:11 or some garbage value.

Well in general ffi isn't designed to work with C++ binaries... And a std::string is not the same thing as a C char * string, so that's probably along the lines of where you're getting hung up. Try changing the parameter types to char * instead of std::string.

Changed the parameters to char *, still facing the same issue.

So if I add a dummy function which takes string as an input and returns the same back like so:
EXPORT const char *remake::trialupload(const char *name) { return name; }
and call it before I call my actual function, it seems to work smoothly. If I don't and just call my desired function, it gives segmentation fault: 11.
index.js:
var output = libREmake_web.trialupload("Hello")
var json = libREmake_web.UploadSingleRule("abcd/srdf","targetfile.json")
console.log(son)
So any pointers on what might be happening and how to address this issue?

Honestly I'd try making a C lib instead of a C++ one.

Okay. Thank you for taking out time and looking at it.

@aamte did making a C library work, or did you give up?


grocy: 3.3.0 -> 4.0.0

Description of changes
https://github.com/grocy/grocy/releases/tag/v4.0.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Running just fine for me as well, thanks for the PR!

4.0.1 with PHP 8.2 support released yesterday

Removing my review request. Sorry, I should've probaly done this earlier, but I wasn't sure if I'd change my mind. Anyways: I stopped using Grocy a while ago and I don't plan to go back. While you're touching this, feel free to remove my maintainership, otherwise I'll do it soonish(tm).
The changes are looking good btw, but I haven't close testing.

@SuperSandro2000 could you please review this PR, I'm not sure if you're the right one to tag but the actual maintainer that was needed to make the review, has resigned. also, a previous review has already been made, but I'm not sure if this PR can thus be merged or not.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1061

Removing my review request. Sorry, I should've probaly done this earlier, but I wasn't sure if I'd change my mind. Anyways: I stopped using Grocy a while ago and I don't plan to go back. While you're touching this, feel free to remove my maintainership, otherwise I'll do it soonish(tm).
The changes are looking good btw, but I haven't close testing.

I can offer to overtake maintainership of this package and module


USS-2561: Document USS-2025 workaround for USS 1.2

Commit Change:

Add note to modify munge uid and gid for version cray/munge-munge:1.6.0

Description

Checklist

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

I can use some help to resolve this Check Licenses failure.


ci: use semi-automated release & post-release actions

Changes

The draft-release action is run on manual dispatch or on pushes to the release-draft branch. It detects the next version, updates the changelog, citation, and version files, and creates a draft release. You can then view the proposed tag, make any edits, and manually publish the release.
The post-release action runs automatically after you publish a release. It updates the changelog and version files for the development version and opens a pull request with these changes.

Requirements

The files CHANGELOG.md, VERSION, and CITATION.cff must exist in the top level of the repo.
CHANGELOG.md must contain a header containing the string 'development version', and this should be the first header in the file. It's crucial to update the changelog with every PR that contains user-facing changes as these become the release notes for the next version.

Issues
NA
PR Checklist
(~Strikethrough~ any points that are not applicable.)

[x] This comment contains a description of changes with justifications, with any relevant issues linked.
~[ ] Update docs if there are any API changes.~
~[ ] Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/~ [these changes are not user-facing]

We'll pilot this in a few release cycles of RENEE. If all goes well we can turn this into a reusable action and add it to our other repos too.


React to hosting changes

Fixes build
@ryanbrandenburg  @rynowak

:shipit: (actually don't wait for my squirrel; just fix the broken build)


Research RFE: investigate migration completion time for 1.4.0

Is your feature request related to a problem? Please describe.
WIth the amount of features going into 1.4.0, it felt the migrations were slower than usual. I compared a QE test case ocp-24787-redis.yml to compare the time of entire migration. For konveyor master it was about 10 mins and for 1.3.0 it was about 6min20 seconds. Both the installations were in the destination cluster. First I tried the master then I uninstalled MTC latest to install 1.3.0 and tried the 1.3.0, if the order if important for reproducing this.
A screenshot of time spent in each step of the pipeline for more debugging.

Describe the solution you'd like
We should probably bring down the time spent for the entire migration for closer to 1.3.0. If it is not possible we should have a reason why this time is justified. For example, we spend a lot of time cleaning up, hence it is important and will improve the overall migration at scale with small prices to pay upfront.

There are a few new phases in mig-controller using a 3 second requeue where they should use the default FastReQ for transitioning to the next phase. These are quick fixes. I'll post a PR for this soon.


FutureManager hangs indefinitely in the case of a bad file.

In the process of trying to do a TransferManager download, I found a bug with the FutureTransfer.listenFor code.  In the simple example of
FutureTransfer.listenFor {
  transferManager.download("bucket", "location", new File("foobar")
}

where "foobar" is a file with permissions of 400, instead of throwing a FileNotFoundException with bad permissions, it just hangs indefinitely.  No amount of mapping, or making use of waitForCompletion() seemed to help, leading to the conclusion that the Future is never finishing.  I looked a little into the source code and found that in the listenFor function, there are cases where the 'progressEvent' will never fire. In this case, since the progress hadn't changed because the File failed before the, and the transfer wasn't done, it just hung.

Hi @marcinx27, could you try running your example with logging at debug level for com.github.dwhjames.awswrap.s3.FutureTransfer and see if anything useful is logged?

And I assume if you call
http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/transfer/Transfer.html#waitForCompletion()
directly on the download object, you get the expected exception?
I’m guessing the download does not fail immediately, as listenFor checks for
http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/transfer/Transfer.html#isDone()
after attaching the progress listener. (Only fails once a write is attempted to the file?)
And here I’m assuming that isDone() will eventually return true.

@dwhjames yeah.  If I called it directly and it threw the exception.  But, if I do it like
FutureTransfer.listenFor {
  transferManager.download("bucket", "key", new File("foobar")
} map ( result => result.waitForCompletion())

and then later do an Await.result on that future, it times out.

Also, I'm working on figuring out how to get debug level logging working for com.github.dwhjames.awswrap.s3.FutureTransfer , so when I get that finished, I'll post the debug messages.

With regards to logging, take a look at the logback config in the scratch project:
https://github.com/dwhjames/aws-wrap/blob/master/scratch/src/main/resources/logback.xml

If you capture the exception with
http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/transfer/Transfer.html#waitForException()
is it a FileNotFoundException directly? Or wrapped in an AWS exception type?
And after that blocking call completes, .isDone() returns true? And .getState() returns …?

It's wrapped by com.amazonaws.AmazonClientException: Unable to store object contents to disk .
And that block never finishes.  The future returned by FutureTransfer.listenFor is never complete, so it can never hit the map to run anything on the object the future is wrapping.

val d = transferManager.download("bucket", "key", new File("foobar"))
val e = d.waitForException()
val b = d.isDone()
val s = d.getState()

What are the values of b and s?

b is true
s is Failed

I think we are somewhat at the mercy of what the Java SDK chooses to publish to the progress listener. Have a look up the call stack from that exception:

https://github.com/aws/aws-sdk-java/blob/3baab096839f6848eed40940fb7b6f519a8e0580/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/internal/ServiceUtils.java#L297-L300
https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/transfer/DownloadCallable.java#L162-L168
https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/transfer/DownloadCallable.java#L84-L99
https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/transfer/internal/DownloadImpl.java#L113-L119

Interestingly, there also seems to be a difference between uploads and download in how events are handled. I have a suspicion that the failure event might actually get fired when uploading from a non-existent file… in contrast to downloading to a non-existent file.

Oh.  So, if I understand the Amazon code correctly, the IOException is getting caught and immediately throwing an AmazonClientException.  But this causes the Download state to be Failed, and thus it doesn't fire a progress event.
If I'm understanding that correctly, then in s3.scala in the listenFor function, should there also be a
if(transfer.getState == TransferState.Failed)

and then handle the failed state (a p failure could work, but you've got documentation stating that the Future will always succeed, so I don't know if you want to change that or not)?

listenFor already tests that condition by calling .isDone().
See
https://github.com/aws/aws-sdk-java/blob/cf8174ab5fdd9e5f012b1657835fc30456622598/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/transfer/internal/AbstractTransfer.java#L74-L78
There is an intentional race in listenFor.

it attaches a listener to the transfer
it tests isDone()

Crucially, 2. is performed after 1. so that if the progress listener was attached after the transfer already finished (and thus the listener doesn’t receive any events) then the final status will still be caught with .isDone().
If .isDone() is not true at this point, then the listener has already been attached, so will receive all events from this point forward.
In the execution that you are encountering, the transfer state is not in a done state at the point immediately after attaching the progress listener. But as it appears that the SDK fails to signal the failure progress event, the future will never complete.
Note that the catch block that sets the failure state is in call of a Callable, so
https://github.com/aws/aws-sdk-java/blob/cf8174ab5fdd9e5f012b1657835fc30456622598/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/transfer/DownloadCallable.java#L80-L105
is running in another thread. Hence the race, and hence why despite the download failing ‘immediately’, it is not ‘immediately enough’, so .isDone() is still false at the point after attaching the progress listener.
So, I’m somewhat at a loss about how to fix this on the side of aws-wrap. I think it might be worth filing a bug on the SDK, as it seems bad that failure events are not being propagated.

@dwhjames right, right.  That makes sense.  I forgot that isDone() only gets called once as a way to stop the race condition of the process being finished before a listener gets attached.  This seems like an AWS bug to me.  Thanks for the help, though.
Since I need to be able to do the operation of getting an object to a file, not an array of bytes, it seems like the only work around I have now is to just extend the AWS-Wrap to include getObject(GetObjectRequest, File)

Ah, I haven’t published since your PR #29. I can do that today, if you’d like?
I think TransferManager is definitely the way to go in terms of efficiency. IIRC you will get progress events on errors on the AWS side, so I suppose you can work around the client-side issue by defensively checking file system status?
Also, if you just use the direct wrapping of getObject, depending on what executor you are passing in (or just using the default https://github.com/dwhjames/aws-wrap/blob/47ccd302edd4458cf3a65848cc4b962b64217d56/src/main/scala/s3/s3.scala#L96) you are going to tie up a thread per transfer.
I think TransferManager is pretty efficient with its thread usage (despite blocking I/O). You could copy its pattern of dedicating a timer thread to poll. You can see this in

https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/transfer/TransferManager.java#L1479-L1482
https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-s3/src/main/java/com/amazonaws/services/s3/transfer/internal/CopyMonitor.java

So an alternative implementation of listenFor could have a single thread scheduled to poll for N transfers and complete Scala promises on transfer state changes.

Um.  Give me a few hours before you publish.  I noticed that I didn't implement the getObject with a file, and I would like to have that in there just in case I get too frustrated with hacking around the TransferManager and want to use the standard implementation.  I'll work on it now and push by like 2:30 EST.

No rush, I won’t have access to a machine I can publish from until late today.

I’m not sure if this crosses the icky line, but one solution for this problem is to cast the com.amazonaws.services.s3.transfer.Transfer to com.amazonaws.services.s3.transfer.internal.AbstractTransfer and attach a TransferStateChangeListener rather than a progress listener…

That might be a workable thing.  I'll probably look into going that way in a little bit.  For right now, I think I'm going to go with just straight AmazonS3ScalaClient stuff, and then try and transition the things that I can over to the TransferManager when everything's stable.

This approach seems to work. See https://github.com/dwhjames/aws-wrap/compare/087cbdf...4615ada

@dwhjames that seems pretty reasonable.  I dig it.  I'm going to flesh out what I've got going on now with the S3Client first, but I'm absolutely going to look into the new TransferManager stuff that you're working on when I'm at least at a point where everything works.

@marcinx27 did you submit an issue to https://github.com/aws/aws-sdk-java/ ? I couldn’t see anything.
I’m going to refine the listenFor stuff a little further—try to consolidate the two approaches. I’ll open a PR and ping you when I’ve polish it.

@dwhjames I didn't.  I was going to, got side tracked, and then kind of forgot about doing it. And definitely let me know when you've got that new listenFor code down.  I'm stoked to see what you do with it.

Let me know when you do. I’d like to track it.

@marcinx27, I just closed this from #35

@marcinx27, I released #35 as part of v0.7.2

@dwhjames Cool, man.  That's awesome.  When I find a free second I want to go over the new release and check it out.  I'm sure it's great.


Search does not work correctlly on custom basePath

To Reproduce
Hi, searh api does not work as expected if I update custoom basePath of application in next.config
It still trying to search on default api path  http://localhost:3000/api/search?query=text
const config = {
  basePath:  "/help",
  reactStrictMode: true,
  output: "standalone",
};
export default withMDX(config);

Current vs. Expected behavior
Able to get search result if I try to request this url manually.
http://localhost:3000/help/api/search?query=text
Provide environment information
Operation System
   Platform: windows
Packages
  "fumadocs-core": "13.4.10",
  "fumadocs-mdx": "10.0.2",
  "fumadocs-ui": "13.4.10",
  "next": "^14.2.8",
  "react": "^18.3.1",

Which area(s) are affected? (Select all that apply)
Core
Additional context
No response

You have to update the search route from root provider, see docs for more info.


Validate exported nexus file.

essnmx should save reduced data as a nexus file for other analysis software.
This feature is done by #21 but it does not check if the nexus file is valid or not.
It should have a test or an option to check if the result file is valid or not.
Maybe chexus can be used here.
It has relatively simple structure, so it shouldn't be so difficult to implement.

Note that Chexus is not really checking for validity but for interpretability. It is also mainly targeted at raw data. So I am not sure it would be of much use. Maybe trying to load the file with relevant software would be a more suitable check?

Yeah, Justin was doing it manually.
The next step is done by dials and it's not distributed on common channels,
like pip or conda as far as I understood.
And the software is >300 MB to download, so I thought it's not suitable for CI test...


Fix worker cannot report worker cluster aggregated metrics issue

What changes are proposed in this pull request?
Worker cannot report worker related cluster aggregated metrics
Why are the changes needed?
With this fix, worker can report both client and worker related cluster aggregated metrics to master side.
Does this PR introduce any user facing changes?
No

@yuzhu baolong saw a case that
in the worker process

the client reportMetrics first and can the  initShouldReportMetrics(Client) and set the sReported=true

  private static synchronized List<alluxio.grpc.Metric> reportMetrics(InstanceType instanceType) {
    if (!sReported) {
      initShouldReportMetrics(instanceType);
      sReported = true;
    }

then the worker itself reportMetrics, but sReported==false so worker metrics is not reported.

As a quick workaround, we can init both, but it doesn't sound a clean way of fixing the metricsSystem
@yuzhu what's your opinion

@LuQQiu Addressed your comment, thanks for pointing it out.

@yuzhu Maybe a make reported as a set can involve a middle state, worker could report to master the metrics not include the worker or client related metric in a short time while one of the reported set is true and another is false.

Let's do what @yuzhu suggested,
replicated reported from a boolean to a normal set check that whether that instance type is inited.
Since it's inside synchronized method, it's safe

Error: 6.299 [ERROR] Errors:
Error: 6.299 [ERROR] alluxio.client.hadoop.FileSystemUriIntegrationTest.multiMasterUriTest
Error: 6.300 [ERROR]   Run 1: FileSystemUriIntegrationTest.multiMasterUriTest:76->testConnection:90 » Timeout
Error: 6.301 [ERROR]   Run 2: FileSystemUriIntegrationTest.multiMasterUriTest:76->testConnection:90 » Timeout
03:56:26.302 [INFO]
Warning: 302 [WARNING] Flakes:
Warning: 302 [WARNING] alluxio.client.rest.S3ClientRestApiTest.listAllMyBuckets
Error: 6.302 [ERROR]   Run 1: S3ClientRestApiTest.listAllMyBuckets:147 s3/ expected:<...e>2021-11-02T03:56:0[7]<Name...> but was:<...e>2021-11-02T03:56:0[6]<Name...>
03:56:26.302 [INFO]   Run 2: PASS
Error: 9.177 [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 82.368 s <<< FAILURE! - in alluxio.client.fs.concurrent.ConcurrentFileInStreamIntegrationTest
Error: 9.196 [ERROR] alluxio.client.fs.concurrent.ConcurrentFileInStreamIntegrationTest.FileInStreamConcurrency  Time elapsed: 37.554 s  <<< FAILURE!
java.lang.AssertionError: Failed with exception(s) [java.lang.RuntimeException: java.io.IOException: Failed to connect to remote block worker:
Error: 2.211 [ERROR] Tests run: 8, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 34.09 s <<< FAILURE! - in alluxio.client.fs.FileSystemMasterRestartIntegrationTest
Error: 2.233 [ERROR] alluxio.client.fs.FileSystemMasterRestartIntegrationTest.unavailableUfsRecursiveCreate  Time elapsed: 4.106 s  <<< ERROR!
alluxio.exception.AccessControlException: The client user is not authorized so as to be null in server
at alluxio.security.authentication.AuthenticatedClientUser.getClientUser(AuthenticatedClientUser.java:123)
at alluxio.master.file.DefaultPermissionChecker.checkPermission(DefaultPermissionChecker.java:101)
at alluxio.master.file.DefaultFileSystemMaster.listStatus(DefaultFileSystemMaster.java:1044)
at alluxio.master.file.DefaultFileSystemMaster.listStatus(DefaultFileSystemMaster.java:1109)
at alluxio.client.fs.FileSystemMasterRestartIntegrationTest.unavailableUfsRecursiveCreate(FileSystemMasterRestartIntegrationTest.java:304)

The most important error is FileSystemMasterRestartIntegrationTest, the other looks flaky
this test all failed in another PR
https://github.com/Alluxio/alluxio/runs/4075815657?check_suite_focus=true

alluxio-bot, merge this please

@Xenorith Please cherry-pick to branch-2.7, thanks!

alluxio-bot, cherry-pick this to branch-2.7 please


.NET7.0 rc2 threads disable  WASM Blazor

URL of sample
 sample
Note that this sample was derived as a  .NET 7.0 rc2 from a sample named "javascript-interaction-blazor-wasm-dotnet6-master" found on github one year ago
Describe the bug
Enabling threads disable Blazor interface startup
To Reproduce
Steps to reproduce the behavior:

open and run sample blazor interface appears
on blazor interface click on CallC# button then calllocalstaticmethod continue after brakepoints then check that  "localstaticmethodcalled" message appears
stop project then enable thread property  on .csproj and run the project for a second time then check that no blazor interface appears

Expected behavior
The blazor interface should appear as for the first run.
Note that another research on "blazor addin" (see #544) shows a similar behaviour :  DotNet.invokeMethodAsync is disabled by thread enabling
Environment

Platform [PC desktop]: PC desktop
Visual basic 2022
Operating System: windows 11 with .Net7.0 rc2

Additional context
This issue could be merged with #544

@RaoulRSV If I follow your steps, I indeed see the same issue.
If I however read the blogpost here (and the comments below) it has not been applied for Blazor Web Assembly. The sample project in the blogpost was working, but that is in plain javascript ... not in Blazor. Also, the comments below indicate that for async Task handling threading is not needed.
We need to wait to get this into the code for Blazor Web Assembly for threading support.

@aafvstam You're right. Now I get it. Multithreading is not available for blazor yet be it with .net 7.0 rc2 or .NET 8.0 preview. I did misinterpret the blogpost you mention. It is about webworkers in plain javascript as you mentionned and seems to still have its own difficulties see here.
Thank you for your help
I close this issue


ISBN link is broken because openisbn.com domain has not been renewed

From @franzcalvo on July 27, 2018 18:21
on the page for:
coreceptor-mediated virion attachment to host cell
http://amigo.geneontology.org/amigo/term/GO:0046814
the link: Source: ISBN:0879694971
is broken because the openisbn.com domain has not been renewed
Copied from original issue: geneontology/helpdesk#149

This seems to work:
https://catalog.loc.gov/vwebv/search?searchArg=0781702534&searchCode=CMD&searchType=1&limitTo=none&fromYear=&toYear=&limitTo=LOCA%3Dall&limitTo=PLAC%3Dall&limitTo=TYPE%3Dall&limitTo=LANG%3Dall&recCount=25

This issue was moved to geneontology/go-site#713


Please allow me to turn several POOL

Describe the feature request
Please allow me to spin several pools at the same time.
I want to spin more, but I can only spin one thing.
It allows you to turn several grasses.
It's not about expanding the area of the stable.
ETH - HORSE
ETH - BULL
We need a way to turn it around at the same time.
HORSE - ETH
HORSE - BULL
Right now, if we do one thing
The other one shuts down.
Describe alternatives you've considered
I think you can allow it.
Additional context

i am going to close this issue because we will re-deploy swap for alpha-3. also, i don't fully understand the issue. if you still face the problem in alpha-3, please open another issue. thanks for the feedback


How to launch the plugin?

import * as GooglePlayGames from 'cordova-plugin-google-play-games';
let { id } = await GooglePlayGames.login(); // userId returned

Regarding the above code, this doesn't seem compatible with JavaScript. Or am I missing something to get the plugin to initiate?

Apparently, JavaScript is okay with writing the above as simply "GooglePlayGames.login();". To test if it's successful or not, sandwich it in a try-catch function.


README: Fix a typo in "multi"

Coverage remained the same at 95.077% when pulling 5c1647f845cc6473088d43493b00fe8ba433f781 on sschuberth:patch-2 into 8eecc31e8bafb4107da547c2315530e0fb5d5ec8 on kt3k:master.

Thanks! 👍


[context_watch] Removes the rxdart dependency

I ran into conflicts with the rxdart dependency across multiple projects. It's very common. Usually, I avoid any package depending on rxdart because of so many breaking changes in the past.
This PR entirely removes the rxdart dependency and while making it compatible with even more versions:
compatability before: rxdart: ">=0.27.7 <0.28.0
compatability now: rxdart: ">=0.26.0 <0.29.0"

The only thing I had to replace was the usage of ValueStream. It was fairly easy using dynamic checks. Similar to tryDispose in context_ref.
rxdart: 0.26.0 is old, but it was easy to add support. Hence I added it right away.

This is awesome! Thanks for your contribution! I'll release this during the week.


SSH agent authentication no longer works in Windows with Pageant.

System information:

Windows 10 21H2
DBeaver Version <IP_ADDRESS>109281101

Connection specification:

mariadb 10.5
Driver name: MariaDB
SSH tunnel

Describe the problem you're observing:
After update from Windows Store today DBeaver fails to connect to database over ssh tunnel with an error:
Unable to initialize SSH agent
Can't initialize tunnel
Unable to initialize SSH agent
Pageant is running.
Include any warning/errors/backtraces from the logs
eclipse.buildId=unknown
java.version=11.0.12
java.vendor=Eclipse Foundation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en
Command-line arguments:  -os win32 -ws win32 -arch x86_64
org.jkiss.dbeaver.model
Error
Thu Dec 09 14:45:57 EET 2021
Unable to initialize SSH agent
eclipse.buildId=unknown
java.version=11.0.12
java.vendor=Eclipse Foundation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en
Command-line arguments:  -os win32 -ws win32 -arch x86_64
org.jkiss.dbeaver.model
Error
Thu Dec 09 14:45:57 EET 2021
Unable to initialize SSH agent
org.jkiss.dbeaver.DBException: Unable to initialize SSH agent
at org.jkiss.dbeaver.model.net.ssh.SSHImplementationAbstract.initTunnel(SSHImplementationAbstract.java:127)
at org.jkiss.dbeaver.model.net.ssh.SSHTunnelImpl.initializeHandler(SSHTunnelImpl.java:75)
at org.jkiss.dbeaver.ui.net.ssh.SSHTunnelConfiguratorUI.lambda$0(SSHTunnelConfiguratorUI.java:219)
at org.jkiss.dbeaver.ui.UIUtils.lambda$16(UIUtils.java:1698)
at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)
There are also messages about failing to read windows registry, but agent errors are before those in timeline.
eclipse.buildId=unknown
java.version=11.0.12
java.vendor=Eclipse Foundation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en
Command-line arguments:  -os win32 -ws win32 -arch x86_64
org.jkiss.dbeaver.model
Warning
Thu Dec 09 14:53:49 EET 2021
Error reading Windows registry
eclipse.buildId=unknown
java.version=11.0.12
java.vendor=Eclipse Foundation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en
Command-line arguments:  -os win32 -ws win32 -arch x86_64
org.jkiss.dbeaver.model
Warning
Thu Dec 09 14:53:49 EET 2021
Could not initialize class com.sun.jna.Native
java.lang.NoClassDefFoundError: Could not initialize class com.sun.jna.Native
at com.sun.jna.platform.win32.WinReg$HKEYByReference.(WinReg.java:52)
at com.sun.jna.platform.win32.WinReg$HKEYByReference.(WinReg.java:48)
at com.sun.jna.platform.win32.Advapi32Util.registryKeyExists(Advapi32Util.java:623)
at com.sun.jna.platform.win32.Advapi32Util.registryKeyExists(Advapi32Util.java:607)
at org.jkiss.dbeaver.ext.mysql.MySQLDataSourceProvider.findLocalClients(MySQLDataSourceProvider.java:190)
at org.jkiss.dbeaver.ext.mysql.MySQLDataSourceProvider.findLocalClientLocations(MySQLDataSourceProvider.java:136)
at org.jkiss.dbeaver.ui.dialogs.connection.ClientHomesSelector$2.run(ClientHomesSelector.java:136)
at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:105)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

Hello @virgoparna,
I'm a bit confused by the provided log.
Can you please clear the debug log file first, reproduce the issue, and then send the newly filled debug log?

dbeaver.log
Added.

Something strange: inside DBeaver it shows version number 21.2.2 (in title bar). But when i right-clicked on shortcut and selected more, app settings then Windows shows Version: <IP_ADDRESS>. Something strange with Store install?

dbeaver-debug.log
That was not debug log, that should be correct.

Thanks, that's a much clearer log. We'll also investigate the version issue you've mentioned.

I think I stumbled upon this issue, too.
Cannot initialize any ssh tunnel using agent.
Using windows store install
OS Windows 11

As turned out, the Windows Store version is outdated. We're working on it.

Seems to be caused by the same problem as #14882

Verified on standalone version. Needs to be tested again after publishing in MS store

@Matvey16 @serge-rider it seems like somehow this issue still persists in the Windows Store version of DBeaver. If I download a standalone DBeaver versions the SSH tunnel with Pageant works just fine, but my Windows Store installed version keeps giving the error "Unable to initialize SSH agent" even after upgrading to 21.3.3.

Still reproducible:
eclipse.buildId=unknown
java.version=11.0.12
java.vendor=Eclipse Foundation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en
Command-line arguments:  -os win32 -ws win32 -arch x86_64

org.jkiss.dbeaver.model
Error
Mon Jan 24 11:36:39 MSK 2022
Unable to initialize SSH agent

org.jkiss.dbeaver.DBException: Unable to initialize SSH agent
	at org.jkiss.dbeaver.model.net.ssh.SSHImplementationAbstract.initTunnel(SSHImplementationAbstract.java:127)
	at org.jkiss.dbeaver.model.net.ssh.SSHTunnelImpl.initializeHandler(SSHTunnelImpl.java:76)
	at org.jkiss.dbeaver.ui.net.ssh.SSHTunnelConfiguratorUI$7.execute(SSHTunnelConfiguratorUI.java:241)
	at org.jkiss.dbeaver.ui.net.ssh.SSHTunnelConfiguratorUI$TunnelConnectionTestJob.run(SSHTunnelConfiguratorUI.java:580)
	at org.jkiss.dbeaver.model.runtime.AbstractJob.run(AbstractJob.java:105)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

fixed in 21.3.4

Can confirm, just upgraded to 21.3.4 via the Microsoft Store and I can connect again using an SSH tunnel that negotiates the key via my (Pageant-compatible) GPG agent 🎉

Works again.

I confirm aswell, works with agent and keepass


AzDO - support for identity federation

https://learn.microsoft.com/en-us/azure/devops/pipelines/library/connect-to-azure?view=azure-devops#create-an-azure-resource-manager-service-connection-using-workload-identity-federation

this would be a good opportunity to drop the keyvault entirely, in my opinion.  Other remaining variables are not sensitive and could be sourced from the json file.
having a central keyvault managing secrets for multiple workloads is not aligned to the well architected framework (I understand, this is just for the foundational artifacts, but still.. if it can be done securely without a KV, then win-win 😊).


TrackPlayer skip to next songs without starting the first

Configuration
System:
OS: macOS 10.14.6
CPU: (8) x64 Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz
Memory: 302.25 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.16.3 - ~/.nvm/versions/node/v10.16.3/bin/node
npm: 6.9.0 - ~/.nvm/versions/node/v10.16.3/bin/npm
Watchman: 4.7.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.4, macOS 10.14, tvOS 12.4, watchOS 5.3
Android SDK:
API Levels: 19, 23, 25, 26, 27, 28
Build Tools: 23.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.1, 27.0.3, 28.0.3, 29.0.2
System Images: android-19 | Intel x86 Atom, android-22 | Google APIs Intel x86 Atom, android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64, android-26 | Google APIs Intel x86 Atom, android-26 | Google Play Intel x86 Atom, android-27 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.5 AI-191.8<IP_ADDRESS>91312
Xcode: 10.3/10G8 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.5 => 0.60.5
Issue
Can't play a remote file if the file is sent in chunk with 206 http responses (because of the weight of the file) and not in one single call with 200 http response.
Code
setupPlayer = (chapters, callback) => {
        try {
            TrackPlayer.setupPlayer().then(() => {
                TrackPlayer.updateOptions({
                    stopWithApp: true,
                    capabilities: [
                        TrackPlayer.CAPABILITY_PLAY,
                        TrackPlayer.CAPABILITY_PAUSE,
                        TrackPlayer.CAPABILITY_STOP,
                        TrackPlayer.CAPABILITY_SKIP_TO_NEXT,
                        TrackPlayer.CAPABILITY_SKIP_TO_PREVIOUS
                    ],
                    compactCapabilities: [
                        TrackPlayer.CAPABILITY_PLAY,
                        TrackPlayer.CAPABILITY_PAUSE
                    ],
                });
                if (callback) {
                    callback(chapters);
                }
            });
        } catch (error) {
            console.log("error audio service");
            console.log(error);
        }
    }

    setupTracks = async (chapters) => {

        this.setupPlayer(chapters, async (chapters) => {

            var headerValue = await getCheckHeaderValue();
            var token = await retrieveToken();

            var tracks = chapters.map( chapter => {

                return {
                    id: `id_${chapter.id}`,
                    url: `${chapter.audioUrl}`,
                    title: `${chapter.title}`,
                    artist: `${chapter.character}`,
                    album: `${chapter.collection}`,
                    artwork: `${chapter.image}`,
                    type: "smoothstreaming",
                    headers: {
                        "Auth-X": headerValue,
                        "Authorization": `Bearer ${token}`
                    }
                }
            });

            if (tracks.length == chapters.length) {
                TrackPlayer.add(tracks).then( async (data) => {
                    console.log(data);
                    console.log("tracks added");
                }).catch( error => {
                    console.log(error);
                });
            } else {
                console.log("Error loading tracks!");
            }
        });
    }

The server responds with

When I press play the player stops immediately and if there are other songs, it skips to the next one.
This is the log, read it like:
player state
trackId duration currentPosition

If out notice the player immediately stops after the playing status.
Looking at the swift code it emits the event itemDidPlayToEndTime but the current position is very far from the end...
What can be the problem?
Thanks!

I found that the problem was the file that is encoded layer2 and not layer3.
Converting the file fixes the problem!


Info button on item card doesn't add to chat

Submitted By<EMAIL_ADDRESS>Feedback Type: Bug
Core: 0.8.8
System: dnd5e v1.4.1
Module Version: bug-reporter v1.3.2
Description:
Foundry 8.8, D&D 5e 1.4.1

Clicking on the info button on an item within a character sheet no longer sends the item with the info into chat.

Module Settings

Active Modules
bug-reporter--v1.3.2;
lib-wrapper--v<IP_ADDRESS>;
midi-qol--v0.8.38;
socketlib--v1.0.8;
tidy-ui_game-settings--v0.1.23;

Additional Details
undefined

This looks like it was meant for the D&D 5e system, not bug reporter. Closing.


About the pt dataset

hello! I download the pt dataset.
I read the contents of the transgpt-pt.txt. I found three problems:
i) A large number of sentences are forcibly broken into multiple sentences, and it seems that the length is not fixed.
ii) Some special symbols (such as mathematical formulas) appear in the text with a confusing format and without special treatment.
iii) Some meaningless pure numbers appear as separate text.
I'd like to consult you that whether these low-quality data affect training model.
Thank you!

Hello! These low-quality data indeed may potentially affect the training model. The broken sentences and confusing format of special symbols may cause the model to learn incorrect patterns and generate inaccurate sentences.
We are working on another cleaning and preprocessing process before training the model to ensure better quality results. Thank you for your valuable suggestions✨ We welcome your contributions to the clean data construction project.

您好，我是宋迎杰，您的信件我已收到，如有需要，我将尽快予以回复，谢谢。

Thank you!
Previously, I thought these low-quality data were added deliberately to enhance the robustness of the model.


validation failure message

For fixing #94
Before:
$./bin/calicoctl apply -f testprof.yaml
Error processing input file: error with field code = '100'
Error executing command: error with field code = '100'

After:
$ ./bin/calicoctl apply -f ./test/testprof.yaml
Error processing input file: error with field (!icmp Code without Type) code = '113'
Error executing command: error with field (!icmp Code without Type) code = '113'

Validation of ICMP fields has been handled - we still need to handle errors from struct validations but that would be a different bit of work.  Closing  this PR


Refactor JSON parsing in WashingtonPostDocument

Refactor JSON parsing using Jackson

@Peilin-Yang @Kytabyte can you both take a look? Thanks!

@Peilin-Yang you're happy otherwise?


Allow rev for GIT_INSTAFIX_UPSTREAM

I just tried providing a tag. Seems like a branch is expected. Would it make sense to allow it to be a rev?

yeah there's no reason not to.
If you didn't mind sharing why you wanted to update something since a tag out might help me think of other things that should also work.

Thank you. I was in a branch in which history might diverge from the tracked branch. It was the only branch in the clone and the tracked was the only branch in the remote.

Ah that makes sense, thanks. I have had repos that behaved like that, just not in awhile.
Feel free to re-open this issue if the released fix doesn't... fix it.


Removing duplicate mTabIds.add() call

Each id is getting added twice, once in addAllTabs and again in addTab

Thanks for the fix.