Prevent default browser behaviour compliant with specs.

As specified in the DOM 2 Events specification.
I also find this more transparent and understandable.
It's a minor thing, and the downside is a few more characters.
Feel free to close RR if you disagree.
Thanks for your work on HyperApp. 🥇

LGTM.

Good question. I think it’s enough, since the goal is to just prevent the default browser behaviour, that's what you want in most situations.
I can’t think of a reason to stop propagation, it's default event behaviour, so I assume it's safe to ignore e.stopPropagation.

Thank you @terkelg!

NP, it's a super interesting project. Keep up the good work!


[GoogleMaps] Update podspec to use GoogleMaps 3.0.3

Bumps Google Maps pod SDK to the latest version.
Update example app

Replaces https://github.com/react-native-community/react-native-maps/pull/2753
Closes: https://github.com/react-native-community/react-native-maps/pull/2748

496426c9d47640b9f76bfc2075c7e49975dada15

@christopherdro When do you plan to release this version?


Fix table formatting in MultiFrameImageStreamCompleter doc.

Dart doc currently don't support table markdown - https://github.com/dart-lang/dartdoc/issues/1453
For now, just show the table as pre-formatted text.

It may be four spaces that you need to trigger <pre> mode.
Either way, LGTM, check out what it looks like, and come back to tune it later :-)


[BUG] Lobby shows "1 of 2 players ready"

Describe the bug
At least one players appears to be not ready after everyone presses the ready button
To Reproduce
Steps to reproduce the behavior:

Start your Beat Saber  and go to "Modded Online"
Select the same server of the person you'd like to play with
Find yourself in a lobby with that person
Choose a song, press ready.
Then, wait for the countdown to finish.
After countdown, it says "1 of 2 players ready".
We also tried with non-custom song.. same problem

Expected behavior
Playing together :p
Screenshots
Can do if really needed, but don't think it is?
Quest (please complete the following information):

Device: Quest 2
Game Version: [e.g. 1.25.1]
Mod Version: [e.g. 1.3.1]

Additional context
We really appreciate your efforts! Thanks a lot for this mod, you are a hero
We filled out google forms, but you only request crashes there, so we thought might as well open an issue here
<3

Interesting, normally if it gets stuck like that it would mean that the other players download got stuck, but since you said it also happened with base game songs, I'm quite confused about the cause here.
It would help if I could get the other players game logs and possibly a description on what they saw, if they saw the same 1 of 2 players ready or something different.
Another possible cause could be a server side issue.

We are only using base game songs for now.
We did a few combinations to see what happens,

Either of us creating the server,
Choosing the same map, or different maps, or one doesn't choose a map at all
All lead to the same issue.

If either of us (host or other player) leaves the room while '1 of 2 players ready', the player still in the server room gets his screen turned black, the player sees the info 'waiting for other player' and than the song starts.
Now, what we observed.

If Host presses ready, the countdown starts even when the other player has not pressed ready.
At the end of the countdown the info '1 of 2 players ready' appears, as before.
Now, 'not-ready'-player presses ready button -> info: '1 of 2 [...]' remains
but the arrow in the partylist indicates that the player is now ready

Any idea how we can help you to fix it?

The info saying who's ready at the end actually indicates the amount of players that have the map downloaded, not the ones that pressed ready, likewise the host pressing start will initiate the countdown, the other players pressing ready will just reduce the time on the countdown
To help me out on what's going on, can you reproduce the issue and then open sidequest and get the global log file from both you and the other player for me that could help
You'll find it within the files on quest under /sdcard/Android/data/com.beatgames.beatsaber/files/logs/GlobalLog_3_14_0.log
That might help me see what is happening there
Also do you get that issue with all custom maps, or just some?

Are you able to play anything when there is only one player in the mp lobby?

Yes, we can both start a song with only ourselves in the lobby

We just reproduced the isee again and give you the full files
GlobalLog_3_14_01.log
GlobalLog_3_14_0.log
_0.log was host

I might have found a possible cause, I'll just need a few minutes to confirm it

MultiplayerCore1.3.2-Dev.1 (Please Unzip QMOD Inside).zip
Can you and the other player give this build a try, had to zip the qmod since github doesn't allow uploading .qmod files directly

Well done Michael! Nice!
We have checked for a non-custom map real quick and it works now.
(note: Host can now start song without confirming ready-check from players)

Great, everything works as intended then
I'll close the issue once I released the fixed version
If you see that issue again in some way let me know

Got some time today, fix is released, I'll close this issue now


Prepping for Release v1.0.7

@BDisp did you actually test the latest NStack (1.0.6/1.0.7) on the latest Terminal.Gui develop branch?
After publishing v1.0.7, and updating Terminal.Gui to use it, the unit tests are failing.
I'm going to unpublish v1.0.7 for now.

Yes I tried now and it's failing because of this:
public uint HotKeyTagMask { get; set; } = 0x100000;
Since the range from 0x10000...0x10FFFF is marked as wide characters, spaces are added after the hot keys. It's better waiting for a fix for this first.

Please explain more thoroughly. Why did your testing when you approved this PR not fail?

I think the better way to fix this is by removing the HotKeyTagMask property and deal directly with the HotKey property. What do you think?

Since we need to remove the hotkey if it's other than uppercase for text handling, maybe change the uint HotKeyTagMask property to int HotKeyPos property to save the hotkey position when the text is been handling for wrap, alignment or whatever and using the position to draw the hotkey properly. Well I think this will be the better option.

I already fixed it. I'll submit a PR.

@tig I already submitted the PR https://github.com/gui-cs/Terminal.Gui/issues/2247 with the fix. Can you republish the nuget package again, please. Without that the fix won't work.


Preparation or improvement of the guide for the meeting (issue #11 related)

Code fix & development, uncommented & functional rotarian (https://cocalc.com/projects/cdcf3856-3e8b-4d1c-bcb2-5c42ba749d83/files/Marek Skwarka/Shared files/modules/dgeometry/cases/prisms.py)


refactor: Remove flags from the build script, use tsconfig.json

The flags are not needed if we just use the tsconfig.json

Closing in favour of https://github.com/yearn/web-lib/pull/321


popover width keeps shrinking

Hi,
I've migrated from 1.0.3 to 1.3.2 and popover has now a strange behaviour when it is visible: its width keeps shrinking each second (approximatively).
This occurs in $uibTooltip provider and especially here :
`var positionTooltip = function() {
          // check if tooltip exists and is not empty
          if (!tooltip || !tooltip.html()) { return; }

          if (!positionTimeout) {
            positionTimeout = $timeout(function() {
              var ttPosition = $position.positionElements(element, tooltip, ttScope.placement, appendToBody);
              tooltip.css({ top: ttPosition.top + 'px', left: ttPosition.left + 'px' });

              if (!tooltip.hasClass(ttPosition.placement.split('-')[0])) {
                tooltip.removeClass(lastPlacement.split('-')[0]);
                tooltip.addClass(ttPosition.placement.split('-')[0]);
              }

              if (!tooltip.hasClass(options.placementClassPrefix + ttPosition.placement)) {
                tooltip.removeClass(options.placementClassPrefix + lastPlacement);
                tooltip.addClass(options.placementClassPrefix + ttPosition.placement);
              }

              // first time through tt element will have the
              // uib-position-measure class or if the placement
              // has changed we need to position the arrow.
              if (tooltip.hasClass('uib-position-measure')) {
                $position.positionArrow(tooltip, ttPosition.placement);
                tooltip.removeClass('uib-position-measure');
              } else if (lastPlacement !== ttPosition.placement) {
                $position.positionArrow(tooltip, ttPosition.placement);
              }
              lastPlacement = ttPosition.placement;

              positionTimeout = null;
            }, 0, false);
          }
        };`

The code that changes the width is this one
tooltip.css({ top: ttPosition.top + 'px', left: ttPosition.left + 'px' });
ttPosition.left keeps increasing and therefore the width is shrinling.
I have seen that this method keeps being called by this code
observers.push(                   tooltipLinkedScope.$watch(function() {                      if (!repositionScheduled) {                        repositionScheduled = true;                        tooltipLinkedScope.$$postDigest(function() {                          repositionScheduled = false;                          if (ttScope && ttScope.isOpen) {                            positionTooltip();                          }                        });                      }                    })                  );
Thanks for your help.
[EDIT]
Actually I found the source of the bug: it is because I'm settinf a max-width css rule on .popover class. How to properly fiw the width of a popover ?

@vincentcialdella, the issues forum is not for support requests.  if you think you've found a bug, you need to adhere to the template so that we may more quickly help you.  We simply do not have the time to create reproducible plunkers from pasted code.  I'm going to close this until you can show that this is a bug in our library.  Thanks.
We are overriding the max width in our project and I don't see any issues.  We are still on 1.1.2, however.


dci-merge | Fix extraction of test commands

Test-Hints: no-check
TLDR: if PR description has multiple lines and not including Test[X] entries, they're taken as input for CMD argument, then the merge job fails, as it's happening with https://github.com/redhatci/ansible-collection-redhatci-ocp/pull/333. See this DCI merge action:
++ curl -s '-HAccept: application/vnd.github.v3+json' '-HAuthorization: token ***' https://api.github.com/repos/redhatci/ansible-collection-redhatci-ocp/pulls/333
++ jq -r .body
+ DESC='TestBos2: virt

Some of them was bug some of them change to be more ansible format and some of them changed to modules'
...
+ dci-queue schedule vpool -- env GITHUB_TOKEN=*** STATUSES_URL=https://api.github.com/repos/redhatci/ansible-collection-redhatci-ocp/statuses/c4309070e854b8f3db3a9e5c4672cf684d1a9d82 DCI_QUEUE_RESOURCE=@RESOURCE /usr/share/dci-pipeline/test-runner /var/lib/dci-openshift-agent/github/ansible-collection-redhatci-ocp-mq-c4309070e854b8f3db3a9e5c4672cf684d1a9d82 $'virt\r' $'\r' Some of them was bug some of them change to be more ansible format and some of them changed to modules

CMD should only retrieve the command after Test[X] and nothing more.

Tested locally, the idea is just to retrieve the line where Test[X] is defined, then extract the commands:
$ echo "$DESC"
TestBos2: virt

Some of them was bug some of them change to be more ansible format and some of them changed to modules

$ echo "$DESC" | grep -E "^\s*TestBos2:\s*" | sed -e 's/^\s*TestBos2:\s*//'
virt


node-spdy's HTTP/2 (https) support

Thanks for the awesome package!
It works on http, but currently does not log anything when using HTTP/2 by node-spdy.

SPDY is not supported.

Thanks for confirming @mcollina !
It would be great to have support, but definitely low priorty : )
Because when I switched from winston and Cabin to pino. I am using node-spdy to simulate HTTPS (I am using node-spdy for HTTP/2 instead of SPDY) on localhost.
When I switched to pino, I spent a while to figure out why it is not logged.

On second thought, I have switched to http instead of https for local dev. Instead, I am using NGINX or similar solutions as gate. This way is more close to production.
Close as I feel not needed. Thanks!


Limit HTML escaping to album description

This fixes a regression introduced in #325, where the whole subtitle is escaped, not just the case when it's a user-supplied description. In particular, if the album_subtitle_style config is set to takedate, the subtitle is a <span>, which on current master results in eyesores like this:

In my opinion the issue being fixed is a release-blocker so this PR should be merged before 4.6.1 is released.

Nicely, spotted. I warned you about lurking regressions like this one in #325. I played around with the changes I made in #325 but I totally forgot that the photo overlay is configurable.
I am generally fine with this PR and given the fact that I intend to rewrite the views as well (not only the dialogs) this fix will do.
Otherwise I would have insisted on renaming the variable subtitle into htmlSubtitle to reflect the circumstance that this variable is already supposed to contain proper HTML and does not need a double-dollar operator. In that case we should also have wrapped htmlSubtitle = formattedMinTs (and other things) into escapeHtml just for safety.
But as I said: As an interim solution I am fine with it.


[Bug]: pandas cast not working

Describe the bug
import polars as pl
import pandas as pd
df_polars = pl.DataFrame({'a': [1]})
nw.from_native(df_polars).select(nw.col("a").cast(nw.String) + "hi")
df_pandas = pd.DataFrame({'a': [1]})
nw.from_native(df_pandas).select(nw.col("a").cast(nw.String) + "hi")
polars succeeds, pandas fails with TypeError: unsupported operand type(s) for +: 'int' and 'str'
Steps or code to reproduce the bug
see description
Expected results
it works as polars works
Actual results
TypeError: unsupported operand type(s) for +: 'int' and 'str'
Versions
narwhals==0.9.1
pandas==1.5.3
polars==0.20.26

Relevant log output
No response

thanks @GRcharles for the report!

This should be fixed in version 0.9.2, thanks again for your excellent bug report 🙏


Keyboard input is not read by VoiceOver in editor or terminal

I'm a legally blind developer . I use voiceover on Mac OS 10.13.6 . I face some problems in dealing with terminal and text editor in Visual studio code .
In the terminal, I can't get any feedback from the screen reader . I can't hear what I type ,which is the same problem in text editor. And don't hear the output of my commands read aloud . I can't also access them using arrow keys in either modes of quick nav.
Please add more support for Voiceover on Mac for visual studio code.
Thank you so much.

I can't hear what I type ,which is the same problem in text editor

The text editor is accessible, make sure you enable accessibility mode using alt+f1 on mac. Also we're don't fully support voice over just yet but are working towards it in other issues https://github.com/Microsoft/vscode/labels/accessibility

Ok, I used it and it works properly on the text editor. :)
Thank you so  much , :)
Sincerely,
Mohamed E. Fayed
On Sep 17, 2018, at 6:43 PM, Daniel Imms <notifications<EMAIL_ADDRESS>wrote:
I can't hear what I type ,which is the same problem in text editor
The text editor is accessible, make sure you enable accessibility mode using alt+f1 on mac. Also we're don't fully support voice over just yet but are working towards it in other issues https://github.com/Microsoft/vscode/labels/accessibility
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/vscode/issues/56468#issuecomment-422086318, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AmLzlyR6YIAxnZsFbwTfPKkHz6q63oaFks5ub9EXgaJpZM4V-CgP.

@alexandrudima good to know, thanks.

Typing anywhere in vscode latest the VoiceOver nicely echoes
However when typing in terminal the letters are not echoed.
I have verified this is not an electron issue. Removing electron.
@Tyriar could you investiagate if you are doing somethign differently than the editor. And if you can fix this in the terminal? (Do you have a hidden text input like the editor so everything gets read out by a screen reader?)

https://github.com/xtermjs/xterm.js/pull/2329

Not sure if I made anything wrong, but it still doesn't echo what's being typed.


v3 Error on inserting: Can only unbox from an object or interface type to a value type.

Hi,
i'm trying out the new v3 in a Xamarin.Forms project.
When i try to insert a new object into a new collection i get this error message:

Unhandled Exception:
System.ArgumentException: Can only unbox from an object or interface type to a value type.
at System.Linq.Expressions.Expression.Unbox (System.Linq.Expressions.Expression expression, System.Type type) [0x00051] in /Users/builder/data/lanes/3511/77cb8568/source/mono/mcs/class/dlr/Runtime/Microsoft.Scripting.Core/Ast/UnaryExpression.cs:678
at LiteDB.Reflection.CreateGenericSetter (System.Type type, System.Reflection.MemberInfo memberInfo) [0x00086] in <69119786c28e4052b478158c5831f742>:0
at LiteDB.BsonMapper.BuildEntityMapper (System.Type type) [0x0010e] in <69119786c28e4052b478158c5831f742>:0
at LiteDB.BsonMapper.GetEntityMapper (System.Type type) [0x00031] in <69119786c28e4052b478158c5831f742>:0
at LiteDB.BsonMapper.SetAutoId (System.Object entity, LiteDB.LiteCollection1[T] col) [0x0003e] in <69119786c28e4052b478158c5831f742>:0  at LiteDB.LiteCollection1[T].Insert (T document) [0x0003c] in <69119786c28e4052b478158c5831f742>:0

It doesn't matter if i only insert one object or a list of objects.

Ok, I know where is it.
https://github.com/mbdavid/LiteDB/blob/master/LiteDB/Mapper/Reflection/Reflection.cs#L86
I change to support structs but not working as expected. Just remove this line (use var castTarget = Expression.Convert(target, type);)
I will fix later.

Works for me now.

Can you update nuget package with this patch, please?

yes @vkocjancic, will be "beta-2", but only this weekend because i'm out of office this week.

Ok, it's now published


different results between ONNX model and pt model

hi , according to onnx/convert_onnx.py , creat the onnx model, test the same img, the results are a little different from the sparse_inst_r50_giam_ceaffc.pth,  Is this normal?

Hi @zoey9628, I'm sorry for the late reply. Could you provide more details about the convention and the difference?

Hi @zoey9628, I'm sorry for the late reply. Could you provide more details about the convention and the difference?

I have the same problem, the pred_scores and pred_masks visualized by ONNX model and pt model are not the same


"onClick" attribute for Actor Label only runs the first time.

I don't know if this is expected behavior, but I've set an onclick in some Labels but the linked LmlAction only runs the first time I click.
Changing the Label to a TextButton works as aspected.
The reason I'm using labels is because I'm populating a Tree and don't want the background that buttons have. Maybe I'm missing a better alternative?
I noticed you used a Table and toggle buttons on gdx-lml-tests and like the look, but wouldn't allow me to achieve the tree child collapsing and expanding behavior.
I'm trying to achieve this look as seen on VisEditor:

This is the click listener attachment code:
        actor.addListener(new ClickListener() {
            @Override
            public void clicked(final InputEvent event, final float x, final float y) {
                action.consume(actor);
            }
        });

Nothing special about this, really, it should fire each time. Try the following in gdx-lml-vis-tests: Hello!.
    @LmlAction("print")
    void print(final Label label) {
        System.out.println(label.getText());
    }

As expected listener fires each time:
Hello!
Hello!
Hello!

Maybe the tree does something to its children, but I doubt it.

By the way, the VisEditor seems to be using a TabbedPane.

Hahah, I know what's going on. You have to click directly on the label. The tree highlights the whole area that it fills, but the listener fires only when you click directly on the text. I guess this is what happened, and you thought that the listener was somehow removed. Try the following (with the print method from previous comments):
<tree>
H
E
L
L
O
</tree>

When you click on the letter, it will be printed. If you click on the highlighted area to the right/left, nothing will happen. Can you confirm that you're having this issue?
My suggestion to resolve this is using a onChange attribute on the tree widget rather than separate listeners for each child.

Ah silly me. Went completely over my head! Sorry for the useless post.
For future visitors, the following works nicely:
<tree id="tree" onchange="handleSelection">

</tree>

And looks great:

I think node="true" is only necessary if you want the actor to be an "openable" tree node. If it's a child-only label (has no tree children), you can try omitting the attribute.


gonum/graph/path/shortest.go: AllBetween return path for Node which nonexistent in graph

What are you trying to do?
Trying to find routes for nonexistent point.
What did you do?
package main

import (
	"fmt"
	"math"

	"gonum.org/v1/gonum/graph"
	"gonum.org/v1/gonum/graph/path"
	"gonum.org/v1/gonum/graph/simple"
)

func main() {
	g := simple.NewWeightedDirectedGraph(0, math.Inf(1))
	g.SetWeightedEdge(g.NewWeightedEdge(simple.Node(1), simple.Node(2), 1))
	g.SetWeightedEdge(g.NewWeightedEdge(simple.Node(2), simple.Node(3), 1))
	allShortest := path.DijkstraAllPaths(g)

	var (
		paths  [][]graph.Node
		weight float64
	)

	// OK
	paths, weight = allShortest.AllBetween(1, 3)
	fmt.Printf("paths: %v, weight: %v \n", paths, weight)

	// OK
	paths, weight = allShortest.AllBetween(1, 1)
	fmt.Printf("paths: %v, weight: %v \n", paths, weight)

	// INVALID
	paths, weight = allShortest.AllBetween(7, 7)
	fmt.Printf("paths: %v, weight: %v \n", paths, weight)
}

What did you expect to happen?
paths: [], weight: +Inf
What actually happened?
paths: [[1]], weight: 0
What version of Go and Gonum are you using?
gonum: v0.6.1
go: go version go1.13 darwin/amd64
Does this issue reproduce with the current master?
yes

You have a problem here:
// AllBetween returns all shortest paths from u to v and the weight of the paths. Paths
// containing zero-weight cycles are not returned. If a negative cycle exists between
// u and v, paths is returned nil and weight is returned as -Inf.
func (p AllShortest) AllBetween(uid, vid int64) (paths [][]graph.Node, weight float64) {
	from, fromOK := p.indexOf[uid]
	to, toOK := p.indexOf[vid]
	if !fromOK || !toOK || len(p.at(from, to)) == 0 {
		if uid == vid {
			return [][]graph.Node{{p.nodes[from]}}, 0
		}
		return nil, math.Inf(1)
	}

	weight = p.dist.At(from, to)
	if math.Float64bits(weight) == defacedBits {
		return nil, math.Inf(-1)
	}

	var n graph.Node
	if p.forward {
		n = p.nodes[from]
	} else {
		n = p.nodes[to]
	}
	seen := make([]bool, len(p.nodes))
	paths = p.allBetween(from, to, seen, []graph.Node{n}, nil)

	return paths, weight
}

Maybe replace:
	if !fromOK || !toOK || len(p.at(from, to)) == 0 {
		if uid == vid {

with:
	if !fromOK || !toOK || len(p.at(from, to)) == 0 {
		if uid == vid && fromOK {

This is working as intended, The distance from any node n to itself (irrespective of where it is in the universe) is 0.

@kortschak And what about returned path? You return random node.

Ahh, yes. That's wrong. I'll send PR in a sec.

I am wondering though why you are querying a node that's not in the graph.


Starting VSCode with multiple windows opened

Issue Type
Bug
Description
When I have opened more than one window, after the next start of the VSCode app only the last selected window will opens, instead of all used windows.
VS Code Info
VS Code version: Code - Insiders 1.21.0-insider (d28f096018e2673a8437c788e3eed781ddb505ce, 2018-02-09T06:08:42.088Z)
OS version: Darwin x64 17.4.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3615QM CPU @ 2.30GHz (8 x 2300)

Load (avg)
2, 2, 2

Memory (System)
8.00GB (0.50GB free)

Process Argv
/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron

Screen Reader
no

VM
0%

Extensions (13)

Extension
Author (truncated)
Version

include-autocomplete
ajs
0.0.4

file-templates
brp
1.2.0

doxdocgen
csc
0.0.7

gitlens
eam
8.0.0

CppSnippets
har
0.0.13

cortex-debug
mar
0.1.13

vscode-todo-parser
min
1.9.1

cpptools
ms-
0.14.6

vscode-code-outline
pat
0.0.12

platformio-ide
pla
0.12.1

vscode-icons
rob
7.19.0

vscode-todo-highlight
way
0.5.11

debug
web
0.21.2

(1 theme extensions excluded)

Reproduces only with extensions

"window.restoreWindows": "all"

Thank you, maybe it should a standard behavior.


Add Pantheon Quicksilver support

Add Composer Installer support for Pantheon Quicksilver scripts:

https://pantheon.io/docs/quicksilver
https://github.com/pantheon-systems/drupal-project/blob/default/composer.json#L33

@niksamokhvalov Since I saw you commenting on another PR, is there anything else I can do here? I'm primarily copying the Drupal and WordPress standard, which I didn't see any tests for. Thank you for your help!

Thanks


Repository documents

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0ce37c0) 100.00% compared to head (6beb414) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##              master        #5   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity       176       176
===========================================
  Files              7         7
  Lines            443       443
===========================================
  Hits             443       443

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


More detailed Hardware Requirements.

In the installation instructions it is shown what hardware requirements are needed for a small, medium, large cluster. We would be interested in a more dynamic requirements calculation. It is not clear how the requirements change for other Setups. Like Operating 5 Clusters with 500 nodes or 50 Clusters with 50 Nodes.

Also interesting is whether hardware requirements for the following setups

50 Imported Clusters
50 RKE Clusters
50 Cloud Hosted Clusters (Hosted by e.g. AWS EKS)

Closing as duplicate of https://github.com/rancher/rancher-docs/issues/103.


GDScript 2.0: Inheritance is not working for return type for method overriding

Godot version
v4.0.beta16.official [518b9e580]
System information
Linux
Issue description
The following code supposed to work as BReturn extends AReturn. But I get error that ClassB.foo's function signature doesn't match with the parent and expects only AReturn as return type.
class AReturn:
	pass

class BReturn extends AReturn:
	pass

class ClassA:
	func foo() -> AReturn:
		return AReturn.new()

class ClassB extends ClassA:
	func foo() -> BReturn:
		return BReturn.new()

Steps to reproduce
Try out the above code
Minimal reproduction project
N/A

I've also noticed this, but wasn't sure "covariant return types" like this are intended to be supported in GDscript (if not it's more of a feature request). It's not universally supported in object oriented languages.

Yeah, IIRC the method's signatures must match for methods with the same name :)


Fix: Issue 9063 - CUDA atomics tests failing with CUDA 12.2

CUDA 12.2 uses the red instruction instead of the atom instruction, because this saves a register (the original value is not required to be stored in a register for the test code). This updates the test accordingly.
Since we only have CUDA 11.x for CI, I have tested this manually.
I noticed during testing (using the NUMBA_FORCE_CUDA_CC environment variable) that declare_atomic_add_float64() assumes it can choose which implementation to use based on the device in the current context - this is not the case, and will have been a long-standing issue (e.g. it could cause issues with compile_ptx()). It should use the CC stored in the flags instead.


issue with the gemspec

acts-as-taggable-on at /home/mha/.rvm/gems/ruby-1.9.2-head/bundler/gems/acts-as-taggable-on-3d707c2 did not have a valid gemspec.
This prevents bundler from installing bins or native extensions, but that may not affect its functionality.
The validation message from Rubygems was:
["lib/acts_as_taggable_on/compatibility/postgresql.rb", "spec/database.yml"] are not files

Does anyone still have problems with this?


Minor updates to tutorial

Summary
Some links in the tutorials may also be broken, need to check what the correct urls are
Details and comments

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.9%) to 38.242%

Totals

Change from base Build<PHONE_NUMBER>:
-2.9%

Covered Lines:
2623

Relevant Lines:
6859

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 41.152%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2814

Relevant Lines:
6838

💛  - Coveralls


Editing Mode - Resizing

Hello,
Resizing is currently broken for images. Instead of follow the mouse cursor to adjust size, the size of the image just consistently gets smaller until it disappears.
The cause is the border added to the image during edit mode. For a quick fix, I added this code to line 3230:
            nonborderSize[0] = nonborderSize[0] + 4;
            nonborderSize[1] = nonborderSize[1] + 4;

I'm adding 4 to both the width and the height to adjust for the border that was added when edit mode was turned on. This seems to fix the issue.

Could you tell me which browser and version# that you are using for testing?  I'm not seeing the bug you mentioned in Firefox 38.0.1.  And when I add the lines you show above, then I get strange resizing behavior.

Unfortunately my application is internal so I can't share any links, sorry.
I'm using v1.42 of your library and have tested in Chrome 42.0.2311.152, IE 11, and Firefox 36.0.4.
One possibility I can think of is the fact that my map canvas for editing is not set to be the full width of the web page. Could that impact the resize behavior? From my testing, if I removed the 'Fuchsia' border from the editing pane (changed from 2px to 0px) then the problem went away, that's why I added 4 to the nonborderSize to compensate.

Hum ... still strange.  I just tested using a 1/2 width map canvas.  The code works properly for me as-is.  I also just tested using a rotated image, and that is working properly for me with the code as-is.  And just tested with both a 2px and a 0px border during editing which worked fine with the code as-is..
Also strange is that if you changed line 3403 to 0px, that you need to add 4 at all in the mousemove event handler.  That would imply that somewhere in the code there is a hardcoded border size which I thought I totally avoided.  Only lines 3405 & 3406 have a hardcoded one-time border adjustment due to browser style set-then-get issues; otherwise I always use the browser's .clientLeft and .clientTop to get the active border size, which are only necessary when setting the object's position, not size.
Also, the browser's .getClientWidth and .getClientHeight do not include the border size in the first place [which is what .getBoundsSize_() in line 3228 uses].  So again it is strange that you are having to adjust the nonborderSize ... effectively you are making the variable into "borderedSize" but you set the border to zero-size, which makes no sense at all :)
I do think I will make a code change to allow the application developer to more easily choose the editing border size (including no-border) and color to ensure it is consistently handled throughout the library (the border works differently for a LatLngQuad-mode image).
Did you make any other changes to the GroundOverlayEX code before doing the "0px" and "add 4" changes?  Would you feel comfortable providing me with a test copy of your application and the copy of GroundOverlayEX file you are using (with any changes you made) such that I can try debugging it on my computer?

Late, but it's caused by Bootstrap's -webkit-box-resizing css.
This might fix.
-webkit-box-sizing:unset!important;


Kia Niro EV 2019: add missing FW versions

@DerGue69 Merging so you can use master/other branches while we debug this, your car seems to be engaging despite the warning


Problem with 2.0 install and System.Net.Http, Version=<IP_ADDRESS>,

Hello,
I'm hoping someone has run into the same issue and has some feedback/ideas as I am running out of ideas.
We're on .net 4.6.1
Decided to update to version 2.0 and when doing the NUGet Install, this is the prompt we got.

But then when calling the basic AuthFlow method, we keep getting:
Could not load file or assembly 'System.Net.Http, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.
We've tried a bunch of things, including downgrading to <IP_ADDRESS> for System.Net.Http --> But when we do this it prompts us to downgrade the Tweetinvi version.
or adding the always fun:

In the  config...to no success what so ever!
We'll keep on trying but if you have some suggestions on what to look into, it'd be most welcome!
Thank you!

Add a reference to the latest version of Newtonsoft.Json (10.0.3 at the time of this writing) first and it cleared everything up for me.
@karelz has been promising a writeup on this issue for almost six months.   I already had the latest Newtonsoft so now I am down to tracking dll by dll where the root of the problem may be.
Painful...

@smartnotify try using Paket , i had the same kind of issue with System.Runtime.Serialization.Primitives, Paket showed it was a the Azure Functions package that had a specific version of Newtonsoft 9.0.1

Thanks @jeromechrist . Paket looks really useful. Trying to resolve why Microsoft.Bcl.Build  is creating so many problems but at least I'm making some progress in getting closer to the problem child!
Thank you.

Did you fix the issue? I have the same framework version and I'm getting the same error.

Unfortunately not yet.  We are hoping an older DLL is the culprit but it is one that cannot be easily replaced just yet.
We've put that on our todo list for the coming weeks.  Hopefully it does it.  Will post an update if we make some progress but it's been a really vexing issue so far that has only been triggered in the tweetinvi case so far.

Well, I did fix the issue yesterday :)
What I did was to look for older versions of System.Net.Http.dll and try 1 by 1. Eventually I found 1 that worked (I don't remember which version it was, sorry). But then, the same error popped out but this time for another dll, System.Runtime.Serialization.Primitives.dll and I did the same thing. Now everything is working properly.

Hello,
Did you look at https://github.com/linvi/tweetinvi/releases/tag/2.0 section ASP.NET (.NET Framework) considerations?
Cheers,
Linvi

Closing as previous comment will probably solve it.
Feel free to reopen if needed.

Please reopen.  I have all kinds of problems with System.Runtime, System.IO, System.Net.Http version conflicts on 4.6.1 and 4.7.1.  This library is unusable in its current form.

I've resolved this issue System.NetHttp Version...by reinstalling these versions:
TweetinviAPI=<IP_ADDRESS>
System.Net.Http=2.0.20505


Investigate Asami for MOP Bootstrapping environment

https://github.com/quoll/asami
I used XTDB when bootstrapping because I needed a datalog database without a schema so I could prepare one for Datomic based on the RDF models required by the user. XTDB also supports full-text search with Lucene which has proven useful for exploring datasets. However, Asami supports the open world assumption by default and supports transitive queries out of the box. Furthermore it supports CLJS. I think there is significant potential for being a superior bootstrapping environment than XTDB for RDF data in Clojure.
I think having the ability to choose a bootstrapping database for users would also be a good enhancement in general.

I need to use Clojure sets in the RDF/EDN serialization for Asami unless the property is actually an RDF list.

My investigation revealed that Asami is awesome!


Document how to test code coverage endpoint-by-endpoint

I'm having some problems to track the coverage specs about the endpoints (request tests)
What's the best way to do that? Anyone is tracking this? and I think if yes it should be documented on README.

Can you talk about the problems you're having?

So, if you are using some gem to track the test coverage (ex: https://github.com/colszowka/simplecov)
It's hard to track if an endpoint is covered with tests.
I tried to force add the files and everything... but it's not working.

@pragmaticivan Are you setting up SimpleCov prior to loading your environment?
For example, if you are using RSpec
# spec/spec_helper.rb
ENV['RACK_ENV'] ||= 'test'

require 'simplecov'
SimpleCov.start do
  add_filter 'spec'
end

require 'rack/test'

# Load your environment, i.e. the following with config/environment convention
require File.expand_path('../../config/environment', __FILE__)

Ensuring that you have Simplecov set up prior to loading your environment is probably what you need to do. Otherwise, could you show us how you're setting up your test suite?

Yes @michaelherold the problem is not withe the entire environment... is jut the covarage of grape files. I'm already using for models.

I guess I'm confused as to what your precise problem is.
Are you wonder how to write a test to test the functionality? I do that with Rack::Test following roughly the guidelines in the README. Are you using Rack::Test, or are you trying some other method of making the actual calls to your API?
If you have those tests that make calls to your API and SimpleCov isn't showing any test coverage for your API, then the only hypothesis I can come up with is that your Grape environment is being loaded before SimpleCov.
Can you give a pared down example that illustrates your problem?

The problem was that I was invoking SimpleCov on rails_spec instead  spec_helper.
Sorry.


docs: add more precise macos input source selection

I struggled a bit on MacOS to actually get automatic unicode input to work. I looked for a general setting on turning on Unicode input on for the US Standard language I normally use. However, I was actually supposed to select Unicode Hex Input instead. As such I added a bit of an addendum to your docs.
Feel free to close/deny the pr if it is too benign ;D

That's great, thanks!


[logging] Handle trailers-only responses

Will be used in the internal logging sink.

This broke tests https://fusion2.corp.google.com/ci/kokoro/prod:grpc-gcp%2Ftools%2Fobservability%2Fmaster%2Fcontinuous_cpp/activity/8c408662-43bd-4377-a6b9-9a89490cea83/tests


Add resume menu to allow changing slot settings

Resolves #124
Will break old saves.

@Ijwu - you got really close! Thanks for your work on this.


Move the highlight group definition and the table to highlight.c

Codecov Report

Merging #4675 into master will increase coverage by 0.02%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master    #4675      +/-   ##
==========================================
+ Coverage   81.35%   81.37%   +0.02%
==========================================
  Files         114      114
  Lines      145122   145128       +6
==========================================
+ Hits       118069   118103      +34
+ Misses      27053    27025      -28

Impacted Files
Coverage Δ

src/highlight.c
78.21% <100%> (-0.3%)
:arrow_down:

src/syntax.c
82.61% <80%> (ø)
:arrow_up:

src/screen.c
82.33% <0%> (-0.11%)
:arrow_down:

src/ex_cmds.c
82.18% <0%> (-0.1%)
:arrow_down:

src/window.c
87.36% <0%> (ø)
:arrow_up:

src/os_unix.c
63.35% <0%> (+0.04%)
:arrow_up:

src/message.c
76.99% <0%> (+0.04%)
:arrow_up:

src/channel.c
83.98% <0%> (+0.07%)
:arrow_up:

src/gui_gtk_x11.c
58.01% <0%> (+0.14%)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41a8260...dfe6849. Read the comment docs.


Hide backdrop for popover

Certain sites might color their popover backdrop, overriding to keep it visible.
https://ng-matero.github.io/ng-matero

oh yes, good call, visbug popovers will inherit any backdrop styles. we def don't want that!
thanks for the site where we can test 👍🏻
curious your thoughts here:
your PR just blanket removes sets any backdrop to transparent, but what about including in each of the web component shadow roots a style that prevents inheriting an opaque backdrop? the web components already have a bunch of defensive styles, and now they're popovers, they could include popover defensive styles.
I verified the bug is fixed with the following styles. What i like about this is that it's not changing the host page, it's changing visbug.
vis-bug::backdrop,
visbug-handles::backdrop,
visbug-hover::backdrop,
visbug-distance::backdrop {
  background: none;
}

if we like this route better, i believe we just add the following to each elements shadow root that is a popover.
::backdrop {
  background: none;
}

the PR would touch more files (like this one) but i think the solution is less leaky or side effecty? thoughts? do you think it would surprise someone if they launched visbug and all their backdrops disappeared?

just uploaded a new build, sorry it took so long! I have excused, but listing them wouldn't make anything better.

No worries, thanks for the maintenance!


Make Hashing Algorithm Faster (but dumber)

Hi just wanted to contribute with the first of a few optimizations I have made.
Please let me know if you actually want this kind of contribution before I raise more of these, namely I will be focusing on more runtime optimizations and parallelism than on the pure math's question of how to sort out the cube rotations.
as such this isn't a pure math optimization, in fact it technically creates more data, but it does more of the work in numpy in C and so is much quicker.
instead of hashing with your RLE, we convert the bits straight into unsigned ints with np.packbits, then we concatenate these ints into a single python int object for the hash.
finally, we add the dimensions of the array to the lowest part of the integer so we don't lose that information.
benchmark attached for n=10 (absolute time is irrelevant as hardware dependent but their is a 2x speedup from the old code)
PS C:\Users\georg\orig_cubes> python.exe .\cubes.py --no-cache 10
Generating polycubes n=3: 100%
Generating polycubes n=4: 100%
Generating polycubes n=5: 100%
Generating polycubes n=6: 100%
Generating polycubes n=7: 100%
Generating polycubes n=8: 100%
Generating polycubes n=9: 100%
Generating polycubes n=10: 100%
Found 346543 unique polycubes
Elapsed time: 450.932s
PS C:\Users\georg\orig_cubes> python.exe .\improved_hash.py --no-cache 10
Generating polycubes n=3: 100%
Generating polycubes n=4: 100%
Generating polycubes n=5: 100%
Generating polycubes n=6: 100%
Generating polycubes n=7: 100%
Generating polycubes n=8: 100%
Generating polycubes n=9: 100%
Generating polycubes n=10: 100%
Found 346543 unique polycubes
Elapsed time: 230.274s
unfortunately since this is speeding up hashing itself not the searches, it will only be a linear speed up so will only push us slightly higher on maximum N.

implemented parallelism and threw more cores at the problem, each parallel thread is much slower, but more cores are more cores n=10 benchmark for the parallelism run:
PS C:\Users\georg\orig_cubes> python.exe .\paralel.py --no-cache 10
Generating polycubes n=3: 100%
Generating polycubes n=4: 100%
Generating polycubes n=5: 100%
Generating polycubes n=6: 100%
Generating polycubes n=7: 100%
Generating polycubes n=8: 100%
Generating polycubes n=9: 100%
Generating polycubes n=10: 100%
Found 346543 unique polycubes
Elapsed time: 64.173s

Very nice :) I'm fairly happy with these kinds of optimisations, with only a few caveats right now:

I clearly didn't think through what would happen when I post code on a video and get spammed with pull requests :) Realistically I can keep an eye on this for a few days, but probably not long term
I'd like to keep an original copy of the file either in a branch or alongside any changes for people watching the video for the first time
Any merges are likely to interfere with all the other pull requests and comments, again I've not thought this through really!

that's fair, depending on how things go (I suspect this should calm down eventually once the obvious ideas have been had and implemented) it might be worth spinning up another repo for people to colab in which is separate to this one linked in the video, appointing some maintainers, and muting it, then you can let the community drive it and we can stop spamming you :)
for now i'm going to keep working on this in my own repo, but wont be posting anything else here except for the npy files to hopefully give you a bit of peace.

This is a great idea! I may do this tomorrow if I have time :)

that's fair, depending on how things go (I suspect this should calm down eventually once the obvious ideas have been had and implemented) it might be worth spinning up another repo for people to colab in which is separate to this one linked in the video, appointing some maintainers, and muting it, then you can let the community drive it and we can stop spamming you :)
for now i'm going to keep working on this in my own repo, but wont be posting anything else here except for the npy files to hopefully give you a bit of peace.

I've created a new repo here: https://github.com/mikepound/opencubes
Are you interested in helping maintain this? Github seems to have adapted their UI again - I don't use it much. I think I invite people as collaborators first, then promote to maintainer?

that's fair, depending on how things go (I suspect this should calm down eventually once the obvious ideas have been had and implemented) it might be worth spinning up another repo for people to colab in which is separate to this one linked in the video, appointing some maintainers, and muting it, then you can let the community drive it and we can stop spamming you :)
for now i'm going to keep working on this in my own repo, but wont be posting anything else here except for the npy files to hopefully give you a bit of peace.

I've created a new repo here: https://github.com/mikepound/opencubes
Are you interested in helping maintain this? Github seems to have adapted their UI again - I don't use it much. I think I invite people as collaborators first, then promote to maintainer?

happy to maintain this, though I fear my usefulness is coming to an end, the scaling memory costs are already becoming a hinderance to my changes at n=14.

also yes once you have invited someone as a collaborator you should be able to set their permissions, though i'm used to private repos on github business and am not sure if their is some arbitrary limits on open projects.

Oddly it doesn't seem to have any permissions at all, could simply be free vs paid features. I think you have access, so maybe worth pushing something and seeing if it works!

I can confirm I can push, the real question will come when a pull request or issue comes up, I will see what my options are there.
Thanks.

returning the array + dimensions in byte format (as opposed to shifting bits) makes this about 15% or so faster
    return polycube.tobytes() + polycube.shape[0].to_bytes(1) + polycube.shape[1].to_bytes(1) + polycube.shape[2].to_bytes(1) # add volume dimensions to lower bits of hash

returning the array + dimensions in byte format (as opposed to shifting bits) makes this about 15% or so faster
 return polycube.tobytes() + polycube.shape[0].to_bytes(1) + polycube.shape[1].to_bytes(1) + polycube.shape[2].to_bytes(1) # add volume dimensions to lower bits of hash

development of this is now continuing over at https://github.com/mikepound/opencubes
but yes your way is about 15% faster (as in in terms of impact on the total runtime which means its a lot faster on its own) and more concise and I will be trying to merge it when the rest of my changes go in.


Problems parsing config file

Running Icingaweb2 RC1 on Ubuntu 12.04.5
Icingaweb2 is having problems parsing the config file.
I copied the default text that comes up when click on the Modules->Configuration->Graphite-Configuration pane into /etc/icingaweb2/modules/graphite, but reloading the configuration pane throws a syntax error, unexpected '=' in /etc/icingaweb2/modules/graphite/config.ini on line 4, and the plugin doesn't function (no graphs displayed in host/service views)
#0 [internal function]: Icinga\Application\{closure}(2, 'syntax error, u...', '/usr/share/php/...', 316, Array)
#1 /usr/share/php/Icinga/Application/Config.php(316): parse_ini_file('/etc/icingaweb2...', true)
#2 /usr/share/php/Icinga/Application/Config.php(419): Icinga\Application\Config::fromIni('/etc/icingaweb2...')
#3 /usr/share/php/Icinga/Web/Controller/ModuleActionController.php(50): Icinga\Application\Config::module('graphite')
#4 /usr/share/icingaweb2/modules/graphite/application/controllers/ConfigController.php(21): Icinga\Web\Controller\ModuleActionController->Config()
#5 /usr/share/icingaweb2/library/vendor/Zend/Controller/Action.php(507): Graphite_ConfigController->indexAction()
#6 /usr/share/icingaweb2/library/vendor/Zend/Controller/Dispatcher/Standard.php(303): Zend_Controller_Action->dispatch('indexAction')
#7 /usr/share/icingaweb2/library/vendor/Zend/Controller/Front.php(937): Zend_Controller_Dispatcher_Standard->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
#8 /usr/share/php/Icinga/Application/Web.php(154): Zend_Controller_Front->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
#9 /usr/share/php/Icinga/Application/webrouter.php(111): Icinga\Application\Web->dispatch()
#10 /usr/share/icingaweb2/public/index.php(4): require_once('/usr/share/php/...')
#11 {main}

It looks like it can't parse service_name_template unless it's followed by a blank line or comment.
Same appears to apply to host_name_template.
Ensuring there's a comment or blank line after each of these two parameters allows the plugin to function correctly.
i.e.:
This fails to parse:
service_name_template = env1.$HOSTNAME$.$SERVICEDESC$
host_name_template = env1.$HOSTNAME$
graphite_args_template = ...

This works:
service_name_template = env1.$HOSTNAME$.$SERVICEDESC$

host_name_template = env1.$HOSTNAME$
;comment or blank line here as well
graphite_args_template = ...

I was able to solve this issue by enclosing the value of the service_name_template and host_name_template in quotes.
eg:
service_name_template = "env1.$HOSTNAME$.$SERVICEDESC$"
host_name_template = "env1.$HOSTNAME$"
graphite_args_template = ...

Altered configuration hint to be in line with @Bigluu's suggestion e517a8886c552c08ce8073b67bc9d93328be3711


scroll-searcher in highlight-selected

Hey there,
Can we have this in combinaton to highlight-selected package?
The idea is to have the markers in scroll bar when you highlight a word, not by searching it in find-replace.
Cheers.

hey
Sorry for the late reply :)
I think it's a very good idea.
Actually months ago I had planned to extend scroll searcher to include 'bookmarks', i.e., we can bookmark parts of document on scrollbar, but something went wrong and it never happened.
Thanks @jimogios for your feedback. I'll consider your point.


fix(comment) comments via email notification

Github sends emails to users who are subscribed to
notifications. The Gitalk comment behavior should match that of
Github.
The previous behavior does not hide extended email replys.
Often times the email response contains the complete email
chain. The visible email chain confuses the user with
unformatted html strings.
Incorrect comment formatting for email replies. #224
Before submitting a pull request, please make sure the following is done:

Fork the repository and create your branch from master.
If you've added code that should be tested, add tests!
If you've changed APIs, update the documentation.
Ensure the test suite passes (npm test).
Make sure your code lints (npm run lint).
Commit your changes (git commit) Commit Message Format Reference.

If you take a look at this issue, I opened a case with Github support about the json that appears in the html string. I'll let you know what they say.

@garrettbryan Good job. Please don't commit the dist directory.

@booxood sorry for the delay. I've been focused on another project. Sorry about committing the dist directory. I'll clean it up and try again.

If you take a look at this issue, I opened a case with Github support about the json that appears in the html string. I'll let you know what they say. It might be that this work is unnecessary, if Github comes back and admits the json shouldn't be included in the html string.

@booxood I heard from GitHub support, they confirmed that comments via email should contain the extra json data, hidden by the button.

@booxood one other question, How concerned are you with the tests? I haven't fully implemented the test cases.

I'm sorry about muddying up this pull request! lol.
I'm going to work out the tests and try again.

@garrettbryan Merged and little modified test case. :relieved:

I’ve not had time to fix the comments on my merge request.
Sent from my iPhone

On Jan 31, 2020, at 4:53 AM, Draven<EMAIL_ADDRESS>wrote:

Hi @garrettbryan, thanks for the great work. Do we have any progress on this issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.


Sublime text 4 support

I've installed sublime text 4 and it seems that it doesn't support buildview. Moreover buildview menu item in Preferences -> Package settings disappeared. I know there is an alternative of using terminus instead. But I found it not so convenient.  Do you have any plans on updating the package?

I would also like to see support for sublime text 4. This is a great little feature.

You can get this project working for sublime text 4 by replacing
if sublime.version().startswith('3'): with if sublime.version().startswith(('3', '4')):
in files pipe_views.py and commands.py
Also adding "show_panel_on_build": false, into Preferences -> Setting if you want to hide default build panel

Thanks everyone, let me sort out some Package Control stuff and a new release for Sublime Text 4 should be coming soon.

The new changes seem to open new build panel on every build vs using the previous one.
could you change:
import re
import sublime, sublime_plugin

if re.match('3|4', sublime.version()):

with:
import sublime
import sublime_plugin
from distutils.version import LooseVersion

if LooseVersion(sublime.version()) >= '3':

for both pipe_views.py and commands.py files.
LooseVersion is proper way to handle version comparison.
Thanks @rctay

Hi @YoSTEALTH, I just tried this using the plugin as published right now, and I couldn't reproduce what you said (new output build panels for every new build).
My setup:

Sublime Text 4107
install buildview from Package Control (ensured latest, ie. ran Package Control -> Upgrade Packages from Command Palette, no updates)
Steps:
Quit Sublime Text 4107
Start Sublime Text 4107
Open file with code (this is the dummy code I usually use):

import datetime
import time
for i in range(15):
print(datetime.datetime.now())
print("foo %d" % i)
time.sleep(0.1)
- Press Ctrl-B
- Saw new tab, "Build output" created with lines starting "2021-05-29 08:45:03..."
- Upon build completed, Press Ctrl-B
- Saw output streamed in the previously created "Build output" tab with lines starting "2021-05-29 08:47:22..."

Could you copy/replace the steps above with the steps you used to run into the problem? That would be helpful in reproducing the problem.

Thanks for replies.
I also have the same issue with new version.

The new changes seem to open new build panel on every build vs using the previous one.

and for me
there is no build output in a build tab at all.
I don't insist there is a problem in buildview. Most likely it is in my setup.
Also I discovered there are 2 similar packages in package control now. One of them is buildview, and second one is sublime-text-buildview. Tried both.  Both gave same results.
Actually I more or less set up terminus + origami pair that day when the issue was opened.  But anyway using 2 packages for solving one problem looks like weird workaround.

@rctay So I reinstalled the BuildView package and the issue with new tab started happening, But once I closed the sublimetext and reopened it the problem went away. So a manual restart of sublimetext is required.


Cody Gray: Watch findallblogs.com

Cody Gray requests the watch of the watch_keyword findallblogs\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

findallblogs\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Missing argument to Internal.solve

Reported by sjoelund.se on 29 Oct 2012 10:23 UTC
In Modelica.Media.Air.MoistAir.PsychrometricData.Medium.saturationTemperature.Internal.solve there is an undefined input:
diff -u -x .svn -r libraries/Modelica 3.2.1/Media/Air.mo build/lib/omlibrary/Modelica 3.2.1/Media/Air.mo
--- libraries/Modelica 3.2.1/Media/Air.mo	2012-10-12 14:33:01.720035052 +0200
+++ build/lib/omlibrary/Modelica 3.2.1/Media/Air.mo	2012-10-29 11:04:35.259722248 +0100
@@ -474,7 +474,7 @@
      end solve;
     end Internal;
     algorithm
-      T:=Internal.solve(p, T_min, T_max);
+      T:=Internal.solve(p, T_min, T_max, f_nonlinear_data = Internal.f_nonlinear_Data());
       annotation (Documentation(info="
  Computes saturation temperature from (partial) pressure via numerical inversion of the function saturationPressure. Therefore additional inputs are required (or the defaults are used) for upper and lower temperature bounds.
 "));

An alternative patch would be to use:
redeclare function extends f_nonlinear(f_nonlinear_data = f_nonlinear_Data())

This does not work in OpenModelica, and I did not test it in any other tool. It is an internal use in only 1 place anyway, so the initial patch should cover it.
The root cause seems to be that Dymola allows an empty record as default input to a function because it considers empty records as constants...
function f
  input R r;
  output Real o;
algorithm
  o := 1.0;
end f;

Dymola flat:
function M.f
  constant input M.R r := M.R() = M.R();
  output Real o;
algorithm
  o := 1.0;
end M.f;

Migrated-From: https://trac.modelica.org/Modelica/ticket/890

Comment by sjoelund.se on 3 Dec 2012 22:16 UTC
Fixed in 219a8fdcf548ae7db3a9a36aa2c683a375f25b30


Support for EdgeChromium

When will driver support be added for EdgeChromium? This is a big miss since EdgeChromium is on almost a billion devices.

Closed by #912


Missing JSON files

Looks like missing JSON files:
PBIToken (JS Object File) file which stores Aad access token for the connections to work.
PBIReport (JS Object File) file which stores report parameters including report url, filter parameters.
could you double check

Apologies this was synced with a GitIgnore on my local copy. issue is now resolved


Allow responses with no content

Empty API responses are allowed by the OpenAPI spec but currently cause an error when parsing a schema which uses them:
https://github.com/triaxtec/openapi-python-client/blob/master/openapi_python_client/openapi_parser/responses.py#L82-L83
Instead, they should be supported, probably returning None as the response.

Thanks @acgray , will release this in 0.4.2 shortly.


i opened a video with the open.lbry.io link and after, whenever i refresh the app it loads the same link instead of the home page

The Issue
i opened a video with the open.lbry.io link and after, whenever i refresh the app it loads the same link instead of the home page
Steps to Reproduce

Expected Behavior
App should show explore page after refresh
Actual Behavior
App goes to the link open.lbry.io link video after refresh
Suggested Solutions
Tell us your suggested solutions if you have any.
System Configuration

LBRY Daemon version: 0.34.0
LBRY App version: 0.31.1
LBRY Installation ID:
Operating system:

Anything Else
clearing cache did not help

Screenshots
https://gyazo.com/07a04da1f318886eb695330434c3a910

Thanks for filing this. I was able to reproduce on the current version (opened https://lbry.com/jiggytom without the app running). Will recheck it on master after the urls are fixed there.

Tested that it is working correctly with https://github.com/lbryio/lbry-desktop/pull/2437


Konnected Inverse Sensors not Inverted

Home Assistant release with the issue:

90.1
Last working Home Assistant release (if known):
84.6 (or later)
Operating environment (Hass.io/Docker/Windows/etc.):

Hassio
Component/platform:

Konnected - binary sensor inverse function
Description of problem:
HA starts up with inverted state, but the first state change is ignored and then the sensor functions as a regular (not inverse) sensor.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
(see garage sensor with "inverse: true" near the bottom)
#Konnected Zone and Device Configuration
konnected:
  access_token: !secret konnected_token
  devices:
    - id: !secret mac_id_k1
      host: <IP_ADDRESS>
      port: 11308
      binary_sensors:
        - zone: 1
          type: door
          name: 'Front Door'
        - zone: 2
          type: door
          name: 'Swinging Back Door'
        - zone: 3
          type: window
          name: 'Great Room Windows'
        - zone: 4
          type: window
          name: 'Master Bedroom Window'
        - zone: 5
          type: window
          name: 'Office Bedroom Window'
        - zone: 6
          type: window
          name: 'Middle Bedroom Window'
      switches:
        - zone: out
          name: 'siren chirp'
          momentary: 65
          pause: 55
          repeat: 4
        - zone: out
          name: 'siren'
    - id: !secret mac_id_k2
      host: <IP_ADDRESS>
      port: 22085
      binary_sensors:
        - zone: 1
          type: window
          name: 'Street Bedroom'
        - zone: 2
          type: window
          name: 'Living Room Windows'
        - zone: 3
          type: door
          name: 'House to Garage Door'
        - zone: 4
          type: door
          name: 'Sliding Back Door'
        - zone: 6
          type: door
          name: 'Exterior Garage Door'
      switches:
        - zone: 5
          name: 'Beep Beep'
          momentary: 65
          pause: 55
          repeat: 4
#        - zone: 5
#          name: 'Warning'
#          momentary: 65
#          pause: 55
#          repeat: -1
    - id: !secret mac_id_k3
      host: <IP_ADDRESS>
      port: 9540
      binary_sensors:
        - zone: 2
          type: garage_door
          name: 'Garage Door'
          inverse: true
      switches:
        - zone: 1
          name: 'Garage Switch'
          momentary: 400
    - id: !secret mac_id_k4
      host: <IP_ADDRESS>
      port: 21011
      switches:
        - zone: 1
          name: 'Bedroom Bell'
          momentary: 5250

Traceback (if applicable):

Additional information:

@heythisisnate - here's the inverse sensor issue.

Thank you. I will look into this shortly.


Simplify the lookup flow to avoid races

This removes the tightly-bound interplay of waitgroups and channel closes that go test -race was showing as a potential race.

Add race flag to testing
Simpler signature, no need to manage a waitgroup in multiple places
Generally, only channel producers should be responsible for channel closing
should be functionally identical:

the only difference I can see is that it's now impossible to get an error response that also has (partial) answers in. @tarnfeld do you see that as a problem?

The use of -race testing was introduced on another branch; this PR brings it to master too so I could focus on the race problem alone. I'll deal with merge issues on other branches.

So aside from the little style comment above, i'm down with the approach. There is however a bug which results in a response never being sent for a DNS query.
Because a response is only sent with chanGather sees all the channels closed, if you sent a query for a record type we don't currently support (should just return NXDOMAIN) it'll hang. This is because the check in AnswerQuestion#274 would fail and we never close the channels. A simple else should do the trick.

Oh, good catch. I'll add the extra else and chan-closes

:+1: :shipit:
LGTM!


Unable to create an account.

description
I've tried numerous times to create a new account, but every time I fill my information out, accept the terms and tick the captcha, it prompts me to fill out my osu! ID and my email address even though both are perfectly valid. I'm not sure of whether or not it's the website's fault, or if i'm just missing something.
replication
Here is a video of me replicating the bug:
https://streamable.com/8jnnl
expected behavior
given that my osu! ID is valid and linked to my account, and that my email address is active and working I saw no reason initially as to why account creation wouldn't have worked. I expected the account creation to go smoothly.
desktop
Windows 7 64bit Home Premium
Waterfox, latest version.
(i've also tried with the latest version of firefox, with no luck)
additional info
the boxes for 'accept terms' 'osu! id' and 'email address' were all red even after visiting the register page for the first time without ever entering any information, which leads me to believe its a problem on the site's end and not mine.
if this could be fixed, it would be greatly appreciated

Should be fixed, thx for the report and sorry :/


Update to 0.97.8

There are several changes:

[x] modals are refactored completely
[ ] tabs have different modes
[ ] chips can be reinitialized (refreshed) - so we can remove this addition from the bridge and use Materialize's implementation
[ ] FABs can transform into a toolbar
[ ] dropdown options bug is fixed (#224)
[x] test if AMD conversion still works (very likely)

And some more which I may have missed for now.

Installation according to the instructions https://aurelia-ui-toolkits.gitbooks.io/materialize-bridge-docs/content/installation/aurelia-cli.html fails because of the modal refactoring in materialize-css.

Thanks for trying out.. 👍
They removed leanModal. I'm thinking of a way not to break existing installations.

No worries, might pay to update the installation instructions to reflect the version requirements until you have a more permanent solution though.

I guess I could just offer an alternative file for v0.97.7 - not sure if I can pass cmd arguments and I'd like to keep it simple.
But I need to redo the modals anyway. It's not initialized on the modal trigger anymore.

@hashtonmartyn Files are updated and tested. Simply replaced leanModal with modal. 😃
I've kept the older versions in a subdirectory and updated the docs.

Nice! That was a fast turn around.

I didn't remove the tab event as I'm unhappy with the implementation.
Materialize onShow function has a parameter which points to the current tab element while the bridge event only has the element's id value.
While I think passing the element is better, implementing this introduces a breaking change for current users.
I've implemented a call handler instead:

  ...

Hi,
Is there any update to the modal functionality changes?
I'm having trouble getting this to work.  I've switched over to the Aurelia CLI installation on a new project, but I'm unable to successfully run:
$(this.myModal).modal( );
or
$(this.myModal).openModal( );
here is what the modal looks like in the html template:

Some modal content

I have a button that when clicked, runs:
$(this.myModal).modal( );
but nothing at all happens.  If I use
$(this.myModal).openModal( );
I get that openModal() is not a function.
I followed the installation instructions for the CLI step by step and everything is building ok and everything else seems to be working so far. I have tried installing different versions of jquery, but that hasn't worked.
I read somewhere about jquery needing to run before the aurelia bootstrapper starts... is there a step I should be adding that's not in the installation docs?
Thanks,
Robert

Hi Robert,
I tried to create a gist to check/demonstrate but I noticed my gist bundles are broken and still use an older version.. I'll create a separate issue to not forget updating them. Unfortunately we have to be kind of "blind" now.. :smiley:
Are there any errors logged to the console?
As for jQuery versions, anything below jQuery 3 should do.
And if $(this.myModal).modal( ); doesn't throw any error then jQuery and Materialize seem to be loaded.
I didn't have any problems here: http://aurelia-ui-toolkits.github.io/demo-materialize/#/samples/modals
What I see immediately from your post is that you didn't use the md-modal attribute. It initializes the modal. Also the ref should actually reference that attribute, so md-modal.ref="myModal" would be correct. The openModal() function is in there.
The sample linked above used this in the same way. :smiley:
Regards,
Daniel

Thanks for your help Daniel.  I got it working now.
openModal() is still not a function though... maybe I'm still doing something wrong.
What is working for me now is:

 ....
and in VM:
this.logoutModal.open();

frankly though, I seemingly looked everywhere but the modal docs... looks like they've been updated since last time I used this plugin... Awesome work man

Well, openModal is completely gone from Materialize.
They changed their modal api and introduced a breaking change with that. It's now just modal on the element itself while openModal was used on the trigger.
IMO that's better but there's a lot on confusion about this change (which is completely understandable).

i'm also getting these non-fatal errors on my page load:
GET http://localhost:9000/materialize-css/fonts/roboto/Roboto-Thin.ttf
GET http://localhost:9000/materialize-css/fonts/roboto/Roboto-Thin.woff
GET http://localhost:9000/materialize-css/fonts/roboto/Roboto-Thin.woff2

I'm using the Aurelia CLI.  Any ideas what this might be?

Yep. Have a look here for details: https://github.com/aurelia-ui-toolkits/aurelia-materialize-bridge/issues/284
Basically, as the fonts' path is set in materialize.css, after bundling fonts are not where the css expects them (that would be relative to the bundle). A solution is to copy the fonts to the location where they are expected.
Another approach is to copy the css to a location where the fonts are relative to the css file and not load the bundle.
Fonts are not(yet) bundled in an Aurelia CLI bundle.


Change the specification of universe managment

We confused specification and implementation for universes ...

It is ready to merge!
Lot of noise for not so much changes.
I changed the way the "patch" is applied in PCUIC. I hope it won't break anything ...

Does anyone want to have a closer look or can I merge?

It looks good to me.


Add "Semnatura" field at the end of the form

Add a simple Canvas element at the bottom to also sign the document. This "declaratie" can now be shown from a mobile device if needed

It should be done in https://github.com/vtemian/declaratie/pull/15


call function sgx_calc_quote_size() return ret=1 when setup chaincode on peer.

Describe the bug
I try to run fpc in HW mod, when setup chiancode on peer it occured an error:
t.enclave.GetRemoteAttestationReport failed: C.sgxcc_get_quote_size failed. Reason: 1

logs
install\approve\commit hello_world on peer0.org1
2021-04-12 03:08:32.249 UTC [cli.lifecycle.chaincode] submitInstallProposal -> INFO 001 Installed remotely: response:<status:200 payload:"\nLhello_world:e4025d4f2549862ee6ea916b7d8e258351d18ac89bf442d6a55fff78108feef9\022\013hello_world" >
2021-04-12 03:08:32.249 UTC [cli.lifecycle.chaincode] submitInstallProposal -> INFO 002 Chaincode code package identifier: hello_world:e4025d4f2549862ee6ea916b7d8e258351d18ac89bf442d6a55fff78108feef9
2021-04-12 03:08:34.433 UTC [chaincodeCmd] ClientWait -> INFO 001 txid [eedc1d29be38ca0a77bb8dd33e1fb14581759bdf0f8f5a314215c07adfa0381c] committed with status (VALID) at localhost:7051
2021-04-12 03:08:36.660 UTC [chaincodeCmd] ClientWait -> INFO 001 txid [54b7f9e39ef528e16b9ee9942bd1200c4c7630ff914ef69b15b09e3a2c969101] committed with status (VALID) at localhost:9051
2021-04-12 03:08:38.895 UTC [chaincodeCmd] ClientWait -> INFO 002 txid [33b14ad422e0d9664bc5bd9e5b4fc4c5f51dcf22ffd1265ebe150106731f0692] committed with status (VALID) at localhost:9051
2021-04-12 03:08:38.895 UTC [chaincodeCmd] ClientWait -> INFO 001 txid [33b14ad422e0d9664bc5bd9e5b4fc4c5f51dcf22ffd1265ebe150106731f0692] committed with status (VALID) at localhost:7051
setup hello_world on peer0.org1
Error: endorsement failure during invoke. response: status:500 message:"t.enclave.GetRemoteAttestationReport failed: C.sgxcc_get_quote_size failed. Reason: 1"
install ercc and hello_world on peer0.org2
2021-04-12 03:08:39.573 UTC [cli.lifecycle.chaincode] submitInstallProposal -> INFO 001 Installed remotely: response:<status:200 payload:"\nIercc_1.0:3c095cb93489bfc1d05651047303189ca84371dc9cfa815ae80eba4f470e1eb1\022\010ercc_1.0" >
2021-04-12 03:08:39.573 UTC [cli.lifecycle.chaincode] submitInstallProposal -> INFO 002 Chaincode code package identifier: ercc_1.0:3c095cb93489bfc1d05651047303189ca84371dc9cfa815ae80eba4f470e1eb1
2021-04-12 03:08:39.768 UTC [cli.lifecycle.chaincode] submitInstallProposal -> INFO 001 Installed remotely: response:<status:200 payload:"\nLhello_world:e4025d4f2549862ee6ea916b7d8e258351d18ac89bf442d6a55fff78108feef9\022\013hello_world" >
2021-04-12 03:08:39.768 UTC [cli.lifecycle.chaincode] submitInstallProposal -> INFO 002 Chaincode code package identifier: hello_world:e4025d4f2549862ee6ea916b7d8e258351d18ac89bf442d6a55fff78108feef9
setup hello_world on perr0.org2
Error: endorsement failure during invoke. response: status:500 message:"t.enclave.GetRemoteAttestationReport failed: C.sgxcc_get_quote_size failed. Reason: 1"
generate key for hello_world on peer0.org2 and peer0.org1 by peer0.org
2021-04-12 03:08:42.069 UTC [chaincodeCmd] ClientWait -> INFO 001 txid [7bf85aa8b7f59e2083806a653226fcad261120d09ece3cf1838e9f0b9430e133] committed with status (VALID) at localhost:7051
2021-04-12 03:08:42.069 UTC [chaincodeCmd] chaincodeInvokeOrQuery -> INFO 002 Chaincode invoke successful. result: status:200

Additional context
I have built peer images in HW mod successfully.
The test network and channel are all right.
Any setting or operations did I missing?

Thanks for reporting this.
Could you please provide some more details on your setup and a description how you run in this error, so I can try to reproduce it.
What FPC release are you using?


cjsx-Support

As jsx and coffee are already supported, I hope cjsx is possible without too much work:
https://github.com/jsdf/coffee-react
Would be awesome! Thanks for your great work.

It is more challenging than you think.  The syntax of JSX expects the following:
JavaScript that contains XML syntax where the XML syntax may have one of the following JavaScript syntaxes embedded directly:

block comment
line comment
JavaScript logic wrapped in curly braces

Those three items are logically represented in the XML as tag attributes where the embedded JavaScript logic may or may not be associated with a proper attribute name.  Then this logic might be JavaScript that contains further XML, such as JSX embedded directly in a JSX tag attribute.
These things sound confusing, but its not so bad as long you have a JavaScript parser that can correctly identify when to switch to an XML parser and for that XML parser to know that it is receiving JSX syntax which may require switching back to the prior JavaScript parser at the appropriate points.  Having the appropriate parsers talking together in the appropriate ways extensively is the hard part.  You could probably use the same markup parser that is used for JSX here, but you would need to extend a coffeescript parser to push to the markup parser correctly.

@prettydiff thanks for the explanation - I see now how it is more compilcated than I thought. Unfortunately I have 0 experience in writing/extending parsers - but the issue is not that pressing anyways. Thanks again.

The CJSX project is deprecated in favor of using CoffeeScript2.  Closing issue.


Multi-language support for RSSLink?

Hi,
I found that the RSS button at the bottom of the page always links to the feed of default language.
Is this the expected behavior?
For me, it seems better to link to the language-specific feed.

Looks like this is a bug from hugo gohugoio/hugo/issues/4615

It seems that RSSLink will be deprecated and eventually removed. so this issue still need to be fixed.


Is there a way to configure windows to open a file with ElasticNotepad?

For a simple solution, what can I put in my "SendTo" folder so that I can send a file to ElasticNotepad and have the editor start with that file open?

You can't at the moment I'm afraid, since the program doesn't take any parameters yet. It's a bit of a glaring omission, so I'll fix it and get back to you here.

Hi Daniel, I've just released a new version (1.5.0) which adds a filename command-line argument. Please give it a try and see how you get on.


[Question] What is this expense

The smallest expense chunk in this pie diagram is called "Expenses by category: 15", I don't have any expense of 15€. What is it? It is also marked as being in November of the current year

on top of the bar charts are check boxes, if you uncheck them one by one you will know which category of expense it falls under.

@TheBinaryLoop Are you using a European locale? I believe I have pinpointed the problem and have released a fix for it. Bug stems from the fact that JS only accepts "." as decimal separator and so if you have European locale e.g.: 38,99 it will treat them as separate numbers.
This is fixed as of the latest docker image.

Yes, I have a european locale (German). It fixed it. Now it gets displayed correctly

Thank you!


Testflight (IOS) expired

The referenced Testflight version (for IOS) is expired

@tclaus I can't log into the appstore connect thingy due to second factor going to your phone. It fails to upload because of pending legal blabla: https://github.com/jhass/insporation/actions/runs/3296886225/jobs/5437062107#step:4:1121
Can you check?

I will check. Can you also check the mail I privately sent to your account?Am 21.10.2022 um 13:50 schrieb Jonne Haß @.***>:
@tclaus I can't log into the appstore connect thingy due to second factor going to your phone. It fails to upload because of pending legal blabla: https://github.com/jhass/insporation/actions/runs/3296886225/jobs/5437062107#step:4:1121
Can you check?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

I have updated the contracts and restarted a build.
But this will not automagically enable TestFlight (immediately)

Technical issue should be fixed with #65

@Masek0815
iOS upload works again, beta app is available in TestFlight again and even available in AppStore :-)

Thankl you!


perf(balancer) optimize for less table resize

Trying to get rid of tab_resize and perhaps the new_key too:

flamegraphs.zip

Relevant piece of flamegraph:


return nil when no node or service to avoid additional api call

- What I did

return nil when no node to avoid API /info call
return nil when no service to avoid TaskList and NodeList api call
fix some typo in command confirmation

- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: allencloud<EMAIL_ADDRESS>

LGTM

ping @vdemeester @thaJeztah
Any update? 🐳


Additional file exports for visualizer no longer necessary?

When I use Mustang 2.12 CLI to convert an EN 16931 invoice to HTML, it also exports xrechnung-viewer.css and xrechnung-viewer.js, but the generated HTML contains no references to these files and works fine without them. I assume these files were necessary in earlier versions, but no longer are. If that is correct, you can probably just remove lines 854-862 from Main.java.

I'm using the ZUGFeRDVisualizer class inside of my app, not via CLI. But that's the same kind of use.
The content of those two files, xrechnung-viewer.css and xrechnung-viewer.js, are embedded in the resulting html file and therefore not necessary as separate files to view the result.

ups, sorry, used to be differently


Add ability to set record to weighted routing policy

I added option attributes weight and set_identifier so that you can set it up to do DNS round robin.

This feature is rather important for a library that claims to support route53.
It's not like route53 has that many features.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

@ubiquitousthey Thanks for making this happen. Sorry it didn't get merged earlier


EditorInspector signal "resource_selected" never gets emitted

Godot version
3.5.1.stable
System information
Windows 10
Issue description
The EditorInspector control is described as having a resource_selected signal that is supposed to be emitted whenever a resource gets selected in the inspector, but this signal seems to never get emitted.
As a comparison, the property_selected signal works as expected and gets emitted with the expected parameters anytime a property gets selected in the inspector.
Steps to reproduce

Create a new plugin,
In the plugin script that extends from EditorPlugin connect the signal using: get_editor_interface().get_inspector().connect("resource_selected", self, "_on_resource_selected") (for ex. in _enter_tree()),
Try to print something in the response method
Click around various different resources, nothing ever gets printed/the signal doesn't get emitted

Minimal reproduction project
N/A

Issue occurs in master branch too.

The signal seems to work fine for regular inspector, but not when using sub-inspector. These steps work for me:

Create TextureRect
Load a texture into it
Right-click the "texture" property and select "Inspect" in the menu

Not sure if it is expected to fire when selecting a resource in sub-inspectors though.

This still seems to be an issue in Godot 4.2.
property_selected seems to emit just fine, but when connecting to resource_selected it doesn't seem to ever be emitted.


CR003: finish implementing search functionalities

check that everything works in the following places:

[x] main search

[x] search inside a text

[x] in sheet list (in user profile)

[x] in collection list (in user profile)

[x] in notes (in user profile)

when clicking either on "Versions" or on "Sheets", blank page opens.
And searching for བྱང་ which is should yield results, gives no result at all

add "no results" in sheet tab


[+] Feature Request: -j | --json Output

Hi, thanks for this awesome cli/lib.
It would be nice if some of the cli (that produce output) had a option to output in json.
-p,--preview exsists, but a native -j,--json would be very handy as I currently have to use bash magic to parse the output.
I implemented a somewhat basic -j | --json output for ec2-ls at : https://github.com/Azathothas/libaws-cli/blob/master/cmd/ec2/ls.go
[
  {
    "name": "test",
    "type": "t2.micro",
    "state": "running",
    "id": "i-02f6dc5jk89cbdf23",
    "image": "ami-0cf2b4e026cdb7210",
    "kind": "ondemand",
    "security-group": "launch-wizard-2",
    "tags": ""
  },
  {
    "name": "ivn_ec2_arm_t4g",
    "type": "t4g.small",
    "state": "running",
    "id": "i-033f1321fff312130",
    "image": "ami-07564a09643c45542",
    "kind": "ondemand",
    "security-group": "launch-wizard-1",
    "tags": ""
  }
]

your cli is very cool!
typically i am either awking at the cmdline, or using libaws as a go sdk.
some things output json, but not all. might be nice to standardize output at some point, but not sure it's worth the effort. there are 153 cli entrypoints.
the cli is just a gateway to using the lib as a go sdk. for more serious use, always use the sdk directly.
infra-ls outputs yaml in a very standardized way. you can use it to list instances and everything else in your account. pipe it to yq.


Creating USB

Hi, I follow the instructions perfectly, yet at the Install Media HP Laptop OC Boot Creator, the Create Media Installer correctly creates the USB, but when I exit the Disk Utility, I do not get the opportunity to select the USB for install (I assume of the OC components). At this stage, I am only shown other mounted partitions.
I am using a MacBook Pro mid 2012 to create the Installer. The MacBook Pro itself has OpenCore, allowing Sonoma as the OS. I do not know if this is playing into the problem. I haven't disabled SIP because the MacBook Pro doesn't have SIP. I do not have another OpenCore program on the Desktop, or in Downloads, only the one that is generated from Option C of the Packager.
I have followed the instructions to the letter, including disabling gatekeeper, wiping the USB first (with the same choices, GPT, Mac OS Extended Journaled filesystem), and previously running options A, B (and now C) of the Packager.
Can anyone please help?

Hi, Chris, thanks for the reply.
I can reach and execute that stage without problem. It is the next stage that is not finding the USB. So, I have created the USB, and the next stage is as shown on the screenshot.
I should be able to select the volume 'Install macOS Monteray', as created in the screenshot you showed. At the next stage, the 'OpenCore USB.pkg' executes the (I assume) injection of the OpenCore components onto the Install USB that has just been created. But instead of that, I do not get the volume as an available volume to inject the OpenCore components on. Just other volumes, which are definitely not to be written to.
I have a GPT/Journalled Install USB, formatted and then written to in the way described. I have only started the pkg independently as I don't want to accidentally write over other volumes. I have now many times run the 'Install OpenCore USB' as a continuous process, as this is the way described. But either way, I get to the same point. (So incidentally, does the VolumePackage.pkg).

I really dont understand the issue here
You have to follow then execte the steps correctly to make this thing work perfectly

The USB create install Media cannot execute correctly without you choosing the USB volume at the first step mentioned on your issue

I have! I have gone through every step exactly as described. I have used your great video and followed it exactly.
The USB is first created (following the erase, and then the selection as per your screenshot). In the video, the next stage is where the USB that has just been created is then selected, as per my screenshot (and your video). But instead of the created Install USB being selectable, only other volumes can be selected. Therefore, I cannot proceed with the next stage (as in my screenshot), which is immediately before moving the HP-Probook-Elitebook pkg onto the USB, and then using that to install the (very good) OC USB onto the Windows PC.
As to your last message. I see I need to run the process as a single flow - but as I have said I have done that many times. As per your comment, I can select the 'Untitled' freshly-erased USB volume, I do wait for it to complete, and then the next stage (as shown in my screenshot) comes up automatically (i.e., not requiring me to unpack the 'Install Media HP Laptop OC'). I have only done that (and I will no longer unpack it, and run the contents independently anymore) only because the full run through has failed (now many times).

some thing wrong with your MacBook and OCLP because I have done this step so many time on Real Mac and Hackintosh whit out any issue so I can not really help here because to may Graphical patch provided by OCLP and maybe issue is come from this?

OK, I will try it on another Hackintosh when I can et my hands on one. Thanks.

Hi, Chris,
FYI, in case someone else runs into this problem, booting into Safe Mode
enabled me to create the full installer. As you say, it must be a problem
for computers already running a variant of OpenCore. Thanks for your help,
as this was the starting point for me using Safe Mode.
Regards,
Stuart
From: chris1111 @.>
Sent: Friday, January 26, 2024 5:04 PM
To: chris1111/HP-Probook-EliteBook-Package-Creator-OC
@.>
Cc: jonesslj @.>; Mention @.>
Subject: Re: [chris1111/HP-Probook-EliteBook-Package-Creator-OC] Creating
USB (Issue #202)
Reopened #202
<https://github.com/chris1111/HP-Probook-EliteBook-Package-Creator-OC/issues
/202> .

Reply to this email directly, view it on GitHub
<https://github.com/chris1111/HP-Probook-EliteBook-Package-Creator-OC/issues
/202#event-11611083646> , or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFTGFMXMM2SDFZNZJ7AE77LYQ
POUJAVCNFSM6AAAAABCKNQ3CWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC
5DJN5XDWMJRGYYTCMBYGM3DINQ> .
You are receiving this because you were mentioned.
<https://github.com/notifications/beacon/BFTGFMSOROQGMPTXBXNTFYDYQPOUJA5CNFS
M6AAAAABCKNQ3CWWGG33NNVSW45C7OR4XAZNWJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XKUY3
PNVWWK3TUL5UWJTYAAAAAFNATCN7A.gif> Message ID:
<chris1111/HP-Probook-EliteBook-Package-Creator-OC/issue/202/issue_event/116
@.***
<mailto:chris1111/HP-Probook-EliteBook-Package-Creator-OC/issue/202/issue_ev
@.***> >

Hi, Chris, FYI, in case someone else runs into this problem, booting into Safe Mode enabled me to create the full installer. As you say, it must be a problem for computers already running a variant of OpenCore. Thanks for your help, as this was the starting point for me using Safe Mode. Regards, Stuart

Thanks to share your fix!


symbolic name for registry

It would be nice if I can give the Registry a name instead of showing "localhost:5000" or something else which is technically the hostname of the registry, it does not tell me much which repo I am looking at.

Actually, that's a name. Below, you see repositories and by combining hostname + repo name you get an image reference (URL) as a standard, e.g. <IP_ADDRESS>:5000/myrepo:tag
Not sure why do you need to specify <IP_ADDRESS>:5000 if your actual registry hostname is something else.

I am accessing it via a tunnel. But I have many repos. Knowing which repo I am actually looking at without investigating my VPN tunnel setup would be helpful.

So you want to have let's say all references in UI to hostname, e.g. <IP_ADDRESS>:500, to be shown with a custom alias name, e.g. registryX and registryX/foobar:1.2.3 references? Everywhere in UI on each page or only breadcrumb?

Everywhere I think.  Anywhere where I would see "<IP_ADDRESS>:5000" I'd rather see the symbol "registryX".


Add the option to change the tracked container

I made some changes that I need because I did not wanted the window to be tracked, but another container.

I signed it!

Thanks for the PR @Aykelith! Let me think for a bit on this, as I'm hesitant to add too many non-VRDisplay functions to one of the implementing classes and something that could be done outside of the polyfill. I wonder if there's another solution that makes this customizable by the consumer, like bind the event handlers to the MouseKeyboardVRDisplay like you have (so that they may be unbound later):
this.onKeyDown_ = this.onKeyDown_.bind(this);
this.onMouseDown_ = this.onMouseDown_.bind(this);
this.onMouseMove_ = this.onMouseMove_.bind(this);
this.onMouseUp_ = this.onMouseUp_.bind(this);

And then in consumer code:
window.removeEventListener('mouseup', vrDisplay.onMouseUp_);
// Remove other handlers on window
container.addEventListener('mouseup', vrDisplay.onMouseUp_);
// Add other handlers on container

Would something like that also solve the issue you're facing?

Yes, I changed the code and kept just the bindings.

Thank you, @Aykelith!


Ferdi crashes after start

When starting ferdi it closes immediately. I get the following error on the console:
[23124:0928/092209.110952:FATAL:gpu_data_manager_impl_private.cc(415)] GPU process isn't usable. Goodbye.
OS: Ubuntu 20.04

Maybe try to turn off enableGPUAcceleration in settings.json?

Also ran into this today after upgrading from Fedora 34 to 35. Current workaround is to disable GPU acceleration...
$ grep GPU ~/.config/Ferdi/config/settings.json
  "enableGPUAcceleration": "false",

Also ran into this today after upgrading from Fedora 34 to 35. Current workaround is to disable GPU acceleration...
$ grep GPU ~/.config/Ferdi/config/settings.json
  "enableGPUAcceleration": "false",

Doesn't work for me. I am also on Fedora 35 with Nvidia graphics card.

I got this same error after an upgrade to Fedora 35. Workaround for me is to run it with --no-sandbox

@vraravam I have insight into this issue.
Chromium broke on glibc 2.34 due to using clone3() syscall. They patched Chromium in October or September to no longer use clone3() which stopped the crashing.
Electron imported the patch and also backported it to a bunch of older Electron versions. All this happened in September/October too.
The solution to fix Ferdi is to update to a newer version of Electron.
The workaround in the meantime is to start Electron with --disable-gpu-sandbox.

By the way, the official Discord client has the same issue of using an old version of Electron and therefore crashing. I alerted their developers to it via 2 methods, about a month ago, and they still haven't updated to a fixed version of Electron. Sad times.

I see that your nightly 5.6.4 pre-release has updated to Electron 15.3.2, which I think has the Electron bugfix (it seems new enough to have the fix).

I decided to try Ferdi again. Latest flatpak version 5.6.5. I won't try the native package again.
But the flatpak seems to work well now.

5.6.5 fixed this issue for me too.


build self relation domain parent is null fail

I have a domain Module like this:
class Module {
    String code
    Module parent
}

then I build a module and the parent is null.
Module.build(parent:null)

but I got the error, java.lang.NullPointerException: Cannot invoke method buildCascadingSave() on null object.
I used the version is 2.1.2.

This is a fairly basic function that is part of the test suite. Would need more information to figure out this specific scenario. Closing.


Delete heading to make consistent with other enums

Also, begin the description with "Specifies..."

Docs Build status updates of commit 2d3eea0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

api/Word.wdpagecolor.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Consider typed keys for cookie-store

https://github.com/nmdias/DefaultsKit

val typedKey = Key<String>("someKey")
ctx.cookieStore(someKey, "String value")

A bit too complex for something that's used as little as I'm assuming the cookie-store is used.


Test a fresh Gatsby starter

Upgrading to Gatsby v5 worked fine locally, develop and build, but not when pushed to Gatsby Cloud.
This branch started as a Gatsby 5 Hello World starter with the existing files imported. This works fine both locally and on Gatsby Cloud.


Resolve GITIGNORE and Initial Commit Issue.

Resolve issues #7 and #8  and Plan for other Issues. Add Tasks/Comments Below.

[x] Optimize GITIGNORE addition #7
[x] Remove/Optimize Initial Commit #8
[x] Release patch - v0.1.x
[x] Test on windows
[x] Test on  macOS
[x] Test on Linux
[x] Release Major Build - v0.2.1 [Milestone Release v0.2.1-Beta]

#7 Optimized  GITIGNORE addition using CURL Fetch from @github/gitignore

[ ] Tested on windows
[ ] Tested on Linux
[ ] Tested on macOS

Ready for Review and Merge.

#8 Removed Initial Commit while adding Git.
Tested on

[ ] Windows
[ ] macOS
[ ] Linux

Ready for review and merge! 👍🏽

🥇 Released Minor (no fix) version 0.2.1 of Flinit!


Screen Cast fails on UAC

Fix:

Run gpedit.msc
Under Computer Configuration\Windows Settings\Security Settings\Local Policies\SecurityOptions:

Change “User Account Control: Switch to the secure desktop when prompting for elevation” to disabled
Undo this change after the screenshot, because it makes the system less secure!