Support per-client-application configurations

It would be nice to support per-client-application configurations on the server if desired. This would allow the backend to "lookup" the desired config for each client individually, supporting applications with varied policies.
Comments via email pasted below:

(shreyas) What i meant by multiple configuration is imagine there are 2 client applications connecting to single appsensor server. I would like each to have separate detection points(i.e IE1 for one client has a threshold of 10 seconds whereas the second client has 25 seconds).Is this already present or something that needs to be added?

(jtmelton) Oh ok, I think I understand now. No, that is not in place exactly. You could cheat by giving each its' own detection point name (ie1-client1, ie1-client2), but that would not be helpful when doing data analysis later. Currently, the policy is set across all client applications at once.
We could do something similar to localization in Java, where you have the default configuration, and then can provide a custom version for a given client if you wish. For instance if the client name is "MySpecialApp", you could have a file called "appsensor-server-MySpecialApp.xml that contains overrides for the configuration for that specific client. What do you think? Would that work for your needs or did you have another idea in mind?

(shreyas) That would work perfectly. OK is there code to support this?

(jtmelton) No, there's nothing there right now. You'll essentially want to look at the code here: https://github.com/jtmelton/appsensor/tree/master/configuration-modes/appsensor-configuration-stax/src/main/java/org/owasp/appsensor/configuration/stax/server. There are a couple ways I can think of doing it, but I think the simplest would be to update the ServerConfiguration class so that every get/find method takes a client application name as a parameter. Then, you'll have to update the code everywhere that uses those and supply that information. Then the StaxServerConfiguration object can read in all the configuration files that are available at startup and store them as a map keyed by the client application name. If a getter is called for a client application where a key exists (ie. a custom file exists), then lookup that configuration and use it. Otherwise, you'll lookup the default file (stored in key "DEFAULT" or something). What do you think? If this sounds like something you want to tackle, we can make up a ticket to track the work.

(shreyas) Yes that is something that i can tackle.

This work was performed by https://github.com/shreyasdn and was done in PR https://github.com/jtmelton/appsensor/pull/35


Refactor tabular number activation into their own mixin

Splits the code that activates tabular numbers out of the govuk-font mixin into its own standalone mixin. Resolves #3778.

[!WARNING]
This PR is for future v5.x work. It should not be merged until after v5.0 has been released.

Changes

Creates a new mixin, govuk-font-variant-tabular, to contain the existing CSS rules.

This name of the mixin is intended to be 'self explanatory', insomuch as it closely matches the CSS properties and values it's setting, similar to my suggestion for the font-weight mixins in this comment.

Simplifies the CSS rules for enabling tabular numbers.

Removes the use of font-feature-settings to define tabular numbers. This was only still needed for IE 11 support, and as it's only a stylistic flag, IE having proportional figures seems an acceptable fallback.
I'm not sure exactly why we were setting font-feature-settings: normal in the @supports query. This will override any customisations that a user may have made (see the thoughts below), and resetting the value doesn't do anything for our use case here. I think we can remove both it and the @supports query without causing any issues.

Changes govuk-font to call the new mixin instead.
Updates all instances where govuk-font was being called solely to activate tabular numbers to call the new mixin instead.

Thoughts

I've opted to keep and not deprecate govuk-font's $tabular parameter. I think it's Mostly Harmless and am inclined to leave it be unless a compelling reason to deprecate it is presented.
I've made this new mixin accept a parameter that sets !important to be consistent with the others and to potentially facilitiate a future utility or override class, which could help resolve https://github.com/alphagov/govuk-design-system/issues/1233.
I'm not a fan offont-feature-settings. It's a very 'broad' property that is prone to overreach and the way we were using it would override or will be overridden by any other use of font-feature-settings that a user may set. As we now only had font-feature-settings for IE 11 support, it's not functionally critical in any way, and as we don't make any guarantee that IE will render identically, I've removed the property entirely.

@36degrees As per Owen's comment and [https://github.com/alphagov/govuk-frontend/issues/4243](the naming issue), I think we're kinda leaning towards typography-related mixins being namespaced under govuk-font- to match how most of the CSS properties they're setting begin with font-.
I don't much mind if it's something like govuk-font-tabular-numbers though!

@owenatgov Added a changelog entry. I wasn't totally sure how to describe the change or why people should use it over govuk-font. I opted to describe it as a new feature that can be used to slightly optimise CSS file sizes, but there might be a better take on it.


Include checking of external links from Android and iOS repos in app_to_web Cypress test

I have improved the existing test by checking the external links stored in the cwa-android and cwa-ios repositories.
For the checks, apart from external links to CWA, redirects from /faq/ to /faq/results/ and hashed URLs (for FAQ links as well as for other internal CWA links) are taken into account.
Currently, it does not detect any errors, just sometimes gets a timeout to visit a specific Apple URL.

It seems that the test always fails, as in the screenshot in https://github.com/corona-warn-app/cwa-website/pull/2968#issue-1276774637.
Method: GET
URL: http://apps.apple.com/de/app/corona-warn-app/id1512595757?mt=8

No response was received within the timeout.

It is checking an http URL although the link specified by the app is https.
See https://github.com/corona-warn-app/cwa-app-ios/blob/eac52ea2bcdb11faad382b53f0275f9bfcfb009c/src/xcode/ENA/ENA/Resources/Localization/bg.lproj/Localizable.links.strings#L63
"TicketValidation_CoronaWarnAppLink" = "https://apps.apple.com/de/app/corona-warn-app/id1512595757?mt=8";

I am not really familiar with how the branches of the https://github.com/corona-warn-app/cwa-app-ios are managed, but when I looked at https://github.com/corona-warn-app/cwa-app-ios/tree/main I saw that this branch has not been updated for 2 months and therefore it does not contain the current released code, which would be in https://github.com/corona-warn-app/cwa-app-ios/tree/release/2.23.x.

@brifemu
I'm happy you agree about my comments! Your new code is a good addition to the test suite and it is complementary to the existing test.
When you move the code to a new test I will take another look and see if I can make some other suggestions.
I used the name hybrid to mean a mixture of internal and external link checking. Since the external link checking is often a problem, that is why I wanted to separate the tests. Many sites try to protect themselves from Denial-of-Service attacks, which can cause Cypress probes from cwa fail, although if you access the same URL manually there is no problem.

One other point from the point of view of testing philosophy:
I don't believe it should be the responsibility of the cwa-website testing process to test whether a link from the CWA app (iOS or Android) to an external domain like apps.apple.com works or not. This is the responsibility of the CWA app testing process, not the responsibility of the website testing process cwa-website/.../cypress. The cwa-website is not involved if an app user clicks on a link in the app to apple for instance, so if the website isn't involved then the website test should also not be involved.
The principal behind the app_to_web.js test was to ensure that all the links on https://coronawarn.app which are expected and used by the CWA apps are actually available and working. This can reasonably be considered as the responsibility of the website testing process. That is why the test app_to_web.js did not cover the external links from the apps such as:

https://reopen.europa.eu
https://play.google.com
https://www.bundesregierung.de
https://www.rki.de
https://apps.apple.com

It's different if there is a page on https://coronawarn.app which is trying to connect to an external site, in which case it should be tested, but not on the basis of testing which links the apps use. Then the test should be done in the check_links.js test, not in app_to_web.js.

Based on my previous comment, I don't think that this PR should be implemented.

@brifemu

I guess we can modify this test to check only the links from the cwa-apps that redirect to cwa-website, to avoid dead links like when we implemented the new FAQ.

If you exclude external links, then your new test will test essentially the same links that the original app_to_web.js tested. So the test would be more or less a duplicate. There are however quite a few differences in the test method, so the results might not be identical.

In that case, I think we can include it in "app_to_web.js". If you agree, I will start with the modification.

No I don't think this would be good. If you think it is necessary to use also your test methodology to duplicate the original test then I ask you to put your code in a separate *.js file and we can discuss further. There are advantages and disadvantages of the two different test methods, but I really wonder if both are necessary.

As previously noted, this PR breaks the workflow cypress-test-prod.yml:
      - name: Cypress run
        uses: cypress-io/github-action@v3
        with:
          browser: chrome
          headless: true
          config: baseUrl=https://coronawarn.app
          # Only run tests in top level of integration directory
          spec: cypress/integration/*.js

The above is equivalent to:
npx cypress run -s 'cypress/integration/*.js' -c baseUrl=https://coronawarn.app --headless --browser chrome
The failing test can also be demonstrated with the simpler command:
npx cypress run -s 'cypress/integration/app_to_web.js' -c baseUrl=https://coronawarn.app --headed
where it times out in each of the new tests after waiting 100000ms each time and therefore causes the complete test to fail after a delay of 400000ms.
When I tested the workflow cypress-test-prod.yml with this PR it failed after 18 minutes. Normally the workflow completes successfully in 8 minutes.

This PR should not be merged. It will cause failure.
It should be considered whether these changes in general are needed. If they are needed then I suggest closing this PR and creating a new PR with only the code from the new test.

@brifemu
Are you going to do any more work on this PR? It seems like the best way forward would be a new PR with a new separate Cypress test.

I suggest to close this PR. @brifemu has not given any further feedback in the last three weeks.
It contains multiple problems including the showstopper issue that it breaks the workflow  cypress-test-prod.yml. Executenpx cypress run -s 'cypress/integration/app_to_web.js' -c baseUrl=https://coronawarn.app --headedto demonstrate the showstopper issue.

@MikeMcC399 We will check how we will proceed with this.

@dsarkar

We will check how we will proceed with this.

Thank you!
The showstopper (breaking the workflow) could be fixed by code changes. If that is done, then the question comes up whether this test should fail if the app includes a non-working link to a website which is not https://www.coronawarn.app e.g. some other Federal German or EU website. I don't think this situation should cause this website test to fail, so checks for other websites like https://reopen.europa.eu/ should be excluded.
Now if checks for other websites are excluded, the new code just duplicates the existing test except that it pulls the link data directly from the iOS and Android app repositories. So effectively it would just check the correctness of the cypress/fixtures/appToWebLinks.json file which drives the URLs to be tested. This test file was created by hand in order to be able to test the different types of links better and more selectively.
I suggest that if any further work is done in this area then there should be a clear functional specification which says what the goal of additional code is to be.

Let me explain the background of this PR:
The app developers are unhappy with our current (live) tests since the tests are missing links that simply are not included in our static link list.
They wanted our cypress tests to read their link configuration files from the iOS and Android repository:

iOS: https://github.com/corona-warn-app/cwa-app-ios/blob/main/src/xcode/ENA/ENA/Resources/Localization/en.lproj/Localizable.links.strings
Android: https://github.com/corona-warn-app/cwa-app-android/blob/main/Corona-Warn-App/src/main/res/values/links.xml

Of course, only checking links that point to our website, not checking any external links like https://www.bundesregierung.de/...

@svengabr
Thanks for explaining the background and motivation!

The app developers are unhappy with our current (live) tests since the tests are missing links that simply are not included in our static link list.

The production version of cypress/integration/app_to_web.js already checks all links to https://www.coronawarn.app which the iOS and Android apps have defined in their links tables. The Cypress test uses the following data table and checks each of the links in the two different language variations /en and /de. Please let me know if specific links are missing from this table. I will double-check from my side as well.
I am also looking at how to automate the check to make sure no links have been missed out. That involves extracting links from the app files, filtering out links which are not https://www.coronawarn.app, consolidating, de-duplicating and sorting them.
https://github.com/corona-warn-app/cwa-website/blob/0ecf5ed9dc20e3c9f6b7f1af69d0e980301cc1fe/cypress/fixtures/appToWebLinks.json#L1-L47

Of course, only checking links that point to our website, not checking any external links like https://www.bundesregierung.de/...

Thanks for clarifying that point!

@svengabr

I checked whether the test cypress/integration/app_to_web.js is covering all cases, and I found two gaps:

The test was not covering the default FAQ landing page https://www.coronawarn.app/en/faq/
Android and iOS are using two different variants to access the blog page https://www.coronawarn.app/en/blog/2021-08-05-statistictiles/, one is with a trailing forward slash character (/) and the other is without the slash character. Only the variant without the slash was being explicitly tested.

I documented the findings on https://github.com/corona-warn-app/cwa-website/issues/3028 and submitted a solution in PR https://github.com/corona-warn-app/cwa-website/pull/3029 for the above two issues.

@svengabr

Since PR #3029 is now merged, I don't see any other gaps in the testing. Please let me know if you think differently.

@svengabr / @brifemu
I saw some movement again in this PR from last week. Do you still want to go ahead with it?
I have also been looking at the task of dynamically taking the links files from the apps and checking them, so I have a few ideas. Unfortunately I have very little JavaScript experience, so I have a steep learning curve and I'm quite slow.
If you do go ahead, then I ask you to put the new test in a new script (if you need the old code then take a copy of it), leaving the existing app_to_web.js as it is. It seems the old code is being used to work around the redirects, but really if the test is to use live data, then it should also use the live redirect file https://github.com/corona-warn-app/cwa-website/blob/master/src/data/faq_redirects.json as well.

@MikeMcC399 we tried around a little but but finally decided to close this PR.
I think https://github.com/corona-warn-app/cwa-website/pull/3029 is good and additional changes are not needed.

@svengabr
I think that closing this PR was the right decision. The app links are all being checked by the existing test.
Even so, if the link data is taken dynamically from the app repositories it would take away the manual maintenance of the fixtures file. I will carry on looking at this and I will let you know if I get a separate working solution. It would only be worth putting into production if the CWA app has a longer lifetime with several more releases and the links from the app into the website are changing a lot, or if the existing links get different redirections implemented.


i/o timeout from apiserver when connecting to webhook on k3s

Bugs should be filed for issues encountered whilst operating cert-manager.
You should first attempt to resolve your issues through the community support
channels, e.g. Slack, in order to rule out individual configuration errors.
Please provide as much detail as possible.

Describe the bug:
I was following along the steps at here: https://cert-manager.io/docs/installation/kubernetes/
Expected behaviour:
I got an issue when trying to test the installation
Error from server (InternalError): error when creating "test-resources.yaml": Internal error occurred: failed calling webhook "webhook.cert-manager.io": Post https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=30s: dial tcp 10.43.18.
211:443: i/o timeout

Steps to reproduce the bug:
Steps to reproduce the bug should be clear and easily reproducible to help people
gain an understanding of the problem.
Following the steps in the link above and got the issue when testing the installation
Anything else we need to know?:
The installation step is successfully, as I verified as follow
kubectl get pods --namespace cert-manager                                                                                Thu Apr 16 18:33:31 2020

NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager-cainjector-79f4496665-7gptd   1/1     Running   0          11m
cert-manager-57cdd66b-7xvj2                1/1     Running   0          11m
cert-manager-webhook-6d57dbf4f-28zjc       1/1     Running   0          11m

I'm using VMs from Google.
Environment details::

Kubernetes version (e.g. v1.10.2): v1.17.4
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): k3s
cert-manager version (e.g. v0.4.0): v0.14.0
Install method (e.g. helm or static manifests): Helm

/kind bug

I have the same this scenario, installed the last version of cert-manager (0.15 alpha.1
we trying to create issuer and certificate by the test-resources.yaml i am getting the following error, the status of every thing is up and running but still i am facing this error:

Error from server (InternalError): error when creating "test-resources.yaml": Internal error occurred: failed calling webhook "webhook.cert-manager.io": Post https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=30s: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
Error from server (InternalError): error when creating "test-resources.yaml": Internal error occurred: failed calling webhook "webhook.cert-manager.io": Post https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=30s: context deadline exceeded

Hey @sangnguyen7
How have you deployed k3s/what environment is it deployed into? This error indicates that your apiserver is unable to route traffic to the cert-manager webhook pod, which is a required component.
This is something that is required to be working in order for Kubernetes conformance tests to pass as far as I'm aware, so this indicates that somewhere along the line your cluster is not configured correctly.
Are you able to run Sonobuoy to check and ensure your cluster is set up properly? This will hopefully help you to pinpoint what's going on 😄
/triage support
/area deploy
/remove-kind bug

Thanks @munnerz. No, I have not tried the tool yet. I will double check with.

I had the same issue. I resolved it by switching from flannel to calico.

Same issue here using k3s. Resolved it using the flag --flannel-backend host-gw during the k3s setup. So it looks like something is wrong in the default flannel setup, but I didn't investigate further

Are there any related issues in the k3s repository that this could be linked to?

@munnerz, it seems the issue is related to the network setup and not related to cert-manager, if there is nobody else having other issues, you can close this issue. Thanks!

Maybe related to https://github.com/coreos/flannel/issues/1243

@alecunsolo, same issue in k3s and i change flannel backend from vxlan to host-gw, but it doesn't work.

method to change flannel  backend.

vim /etc/systemd/system/k3s.service

what I modified.

ExecStart=/usr/local/bin/k3s server --flannel-backend host-gw

check my k3s net-conf

[root@bowser1704 ~]# cat /var/lib/rancher/k3s/agent/etc/flannel/net-conf.json
{
	"Network": "<IP_ADDRESS>/16",
	"Backend": {
	"Type": "host-gw"
}
}

But it still doesn't work.
[root@bowser1704 ~]# kubectl apply -f cert-manager/cluster-issuer.yaml
Error from server (InternalError): error when creating "cert-manager/cluster-issuer.yaml": Internal error occurred: failed calling webhook "webhook.cert-manager.io": Post https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=30s: context deadline exceeded

Do you have any suggestions?
thanks.

It tooks a few days to fix this problem.
it maybe related to coreos/flannel#1268. or vxlan bugs.

Super slow access to service IP from host, maybe 60s delay
Can't access pods by service cluster ip except you access from the node where pod in

So, one method to reslove this issue is to dispatch cert-manager-webook to the node where you are by using spec.nodeSelector.
another method is changing the flannel backend from vxlan to host-gw. P.S. but it seems doesn't work for me.

maybe related to rancher/k3s#1638
I fix by this command.
ethtool -K flannel.1 tx-checksum-ip-generic off

Partly comment, partly question:
We're running k3s (v1.17.7+k3s1, flannel, AWS AMI2) but the master is separated from the cluster (by firewall - allowing port 6443 from workers towards master). Until now we've been using the "no-webhook" version of cert manager (until 0.13) without problems but after upgrade yesterday getting the same error when we try and list certs using kubectl on the master:
# /usr/local/bin/kubectl get cert --all-namespaces
Error from server: conversion webhook for cert-manager.io/v1alpha2, Kind=Certificate failed: Post https://cert-manager-webhook.cert-manager.svc:443/convert?timeout=30s: context deadline exceeded

From a pod running on the cluster I can retrieve the certs (I tested the pod on different nodes, it always works):
curl -s --cacert /var/run/secrets/kubernetes.io/serviceaccount/ca.crt \
  -H "Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" \
  https://kubernetes.default.svc/apis/cert-manager.io/v1alpha2/certificates

Any idea why this would happen?

Partly comment, partly question:
We're running k3s (v1.17.7+k3s1, flannel, AWS AMI2) but the master is separated from the cluster (by firewall - allowing port 6443 from workers towards master EDIT: master runs no pods, not part of the cluster workload). Until now we've been using the "no-webhook" version of cert manager (until 0.13) without problems but after upgrade yesterday getting the same error when we try and list certs using kubectl on the master:
# /usr/local/bin/kubectl get cert --all-namespaces
Error from server: conversion webhook for cert-manager.io/v1alpha2, Kind=Certificate failed: Post https://cert-manager-webhook.cert-manager.svc:443/convert?timeout=30s: context deadline exceeded

From a pod running on the cluster I can retrieve the certs (I tested the pod on different nodes, it always works):
curl -s --cacert /var/run/secrets/kubernetes.io/serviceaccount/ca.crt \
  -H "Authorization: Bearer $(cat /var/run/secrets/kubernetes.io/serviceaccount/token)" \
  https://kubernetes.default.svc/apis/cert-manager.io/v1alpha2/certificates

Any idea why this would happen?

UPDATE: I moved my master server into the same security group and started k3s agent on the master node and it started working. So for anyone Googling this : if the master node is separated from the cluster and not running k3s agent, it doesn't appear that it will be able to contact the webhook server.

Having the same issue with our EKS cluster. Wondering if there is a fix to stop the pod from restarting on the time out and gracefully just adding an error to the logs ?

Error from server (InternalError): error when creating "clusterIssuer.yaml": Internal error occurred: failed calling webhook "webhook.cert-manager.io": Post https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=30s: context deadline exceeded
Getting above error.

这个问题可能是cni导致的，我修改了calico的mtu后这个问题解决了(This problem may be caused by cni. After I modified the mtu of calico, the problem was solved.)
"mtu": 1440-> "mtu": 1420,
{
  "name": "k8s-pod-network",
  "cniVersion": "0.3.1",
  "plugins": [
    {
      "type": "calico",
      "log_level": "info",
      "log_file_path": "/var/log/calico/cni/cni.log",
      "datastore_type": "kubernetes",
      "nodename": "k3s-operator-1",
      "mtu": 1420,
      "ipam": {
          "type": "calico-ipam"
      },
      "policy": {
          "type": "k8s"
      },
      "kubernetes": {
          "kubeconfig": "/etc/cni/net.d/calico-kubeconfig"
      }
    },
    {
      "type": "portmap",
      "snat": true,
      "capabilities": {"portMappings": true}
    },
    {
      "type": "bandwidth",
      "capabilities": {"bandwidth": true}
    }
  ]
}


Misspelled word in a comment from a code example

Misspelled word "createing" instead of "creating", I really didn't expect to make a change but this is my first pull request ever and i'm doing it for the sake of it, greetings from Ecuador.

Checklist

Please note that in case of below checklist not updated accordingly, the maintainers have the right to immediately close your pull request.

[x] You created a branch from dev branch.
[x] You PR is raised on dev branch and not onmaster.
[x] Blog follows Blog Guidelines.
[x] You have read the Contribution Guidelines before creating this PR.
[x] Checked for any duplicate blog entry.
[x] Checked for all grammatical errors in the blog.
[x] You have not published the blog content anywhere else on the internet on platforms like medium, dev.to etc.
[x] The content is not copy-pasted from anywhere else on the Internet.

Description of change

Damn i was confused about the dev branch and the master branch where to pull request, i see that is on master branch besides is an misspelled word.


Using deterministic algorithms

Fixes #515
Proposed Changes

Possibility of running training in a deterministic way

Checklist

[x] I have read the CONTRIBUTING guide
[x] My PR is based from the current GaNDLF master
[x] Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change
[ ] Function/class source code documentation added/updated
[x] Code has been blacked for style consistency
[ ] If applicable, version information has been updated in GANDLF/version.py
[ ] If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
[ ] Usage documentation has been updated, if appropriate
[ ] History has been updated, if appropriate
[x] Tests added or modified to cover the changes; if coverage is reduced, please give explanation
[ ] If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

recheck


[spi host] Test plan - 2.5.2 Remaining items

Description
Description
This issue details what needs to be tested for the next deadline, and complements the previous test plan.

[ ] Features:

[ ] Byte-count.
[ ] 32 bit big or little endian. --> lower priority as this is set by the system configuration
[ ] Max speed of 30 Mhz. --> Unable to test in FPGA
[ ] Polarity phases (CPOL, CPHA) --> lower priority as there's only one mode used in practice.

[ ] CPOL = 1
[ ] CPHA = 1

[ ] Chip select automatic control.

[ ] CSNLEAD, CSNTRAIL and CSNIDLE. (expect this to be covered in DV)
[ ] Mix transactions with two different devices with different clocks.
[ ] Different number of CSBs --> Not tested in DV. Not covered until we get the integration board.

@engdoreis did we make any progress on this or the status still accurate?

Yes, the status is accurate. Unfortunately, I haven't spent time on this, so no progress.

@engdoreis: Do you think you'll be able to complete this for M4? If not, which items do you think are critical to get tested for Earlgrey-PROD?

It's not prioritized for SiVal, so unless @moidx changes the priority, it won't be completed before M4.

Discussed in triage: okay to move to M5

@johngt  to follow up with the software team to update estimates and implementation plan.

@luismarques - as discussed - believe we should see if any of the integration tests are failing on the BoBs, particularly around features that have changed in Spi_host. If they are all ok, suggest closing off this issue.
@a-will has suggested that we should have a task in the future to see if we can test either in FPGA or on a modified board to see if we can test multi-controller mode and the other features he worked on.

@a-will has suggested that we should have a task in the future to see if we can test either in FPGA or on a modified board to see if we can test multi-controller mode and the other features he worked on.

A little mix-up here--This note is for i2c, not spi_host.

@engdoreis can you look through this issue and see whether there is anything you particularly want to focus on testing for M5. If there are items that are long-tail and nice-to-haves those can be split off. Only important items that need testing should remain here

Update:
32 bit big or little endian
It only make sense to be tested in DV as it is a RTL parameter.
Max speed of 30 Mhz.
Working in progress.
Polarity phases (CPOL, CPHA)
Working in progress.
Mix transactions with two different devices with different clocks
The spi_host only supports one csb.
Different number of CSBs
The spi_host only supports one csb.

Due to environment constraints, I can test the chip beyond 16MHz.

Working on Polarity phases (CPOL, CPHA), which should be finished by Friday, July 12th.


Optimizing imports and renaming variables

Removing a lot of useless imports and renaming variables of type Activity named context

Right. I fixed the formatting issue. But what is the problem with imports?

Readme_edit


Define nearby workflow better

Summary:
I think current nearby implementation needs some discussion in terms of expected behaviors. Since it is developed incrementally, it has a fragile structure. We have several states, and we need to define our expectations from the map under these different states:
1- Initial/base condition:

2- Moving around to find a place to use "search this area" button:

3- Another area is searched:

4- List view is expanded:

Note: Please feel free to edit my comment with your additional states.
For each defined state, we need to decide:

Do we want from the map camera to follow the location of the user?
Do we want to track the location of user with blue dot for this state?
Do we ever want to auto zoom in/ out?

Below how this discussion started under another issue:

IMO solving this issue can be very tricky. Because we have some different cases such as

do x when list is expanded, do y when list is collapsed.
do x when user is searching around, do y when user is walking and requesting track.

I think the main problem is new nearby UI is developed incrementally with feedbacks. And search this area feature added after the initial implementation. Work flow should have been defined better.
I can suggest picking an easier task. But if you feel confident, you can take also this one @shabrikaruna

Originally posted by @neslihanturan in https://github.com/commons-app/apps-android-commons/issues/2352#issuecomment-473866785

I would say:

map camera follow the location of the user? : 1: YES, others: NO (if complicated, NO for all is fine too)
track the location of user with blue dot? YES for all states
auto zoom in/ out? Only at 1 when loading the first set of points


support this library for desktop?

Hi
Is it possible to support this library for Desktop?
Like Windows

Hi,
For now it just support Android,iOS and Web, but i will add Desktop support later.

Thank you, I hope it will be done for the desktop as soon as possible
في الجمعة، ٥ يناير ٢٠٢٤, ٢:٢٥ م MohammadReza Davari <
@.***> كتب:

Hi,
For now it just support Android,iOS and Web, but i will add Desktop
support later.
—
Reply to this email directly, view it on GitHub
https://github.com/m-r-davari/flutter_3d_controller/issues/1#issuecomment-1878518463,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACS7GPXBRUXQK4TE4AAJ5SLYM7PMHAVCNFSM6AAAAABBLBDIQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZYGUYTQNBWGM
.
You are receiving this because you authored the thread.Message ID:
@.***>


df.sort: * not working

Instaed of the given example...
say ~df.sort: { df[$++]<C> };   # sort by col C
Ideally would like to use examples such as:
say ~df.sort: *<C>;
say ~df.sort: {.<C>};
say ~df.sort: {$_<C>};

Which has been discussed over at Discord
https://discord.com/channels/538407879980482560/768511641758466088/1072494854325674075
p6steve: just to circle back on this - I have now had the time to review the implementation of role DataSlice in the Dan module and to check whether there is a simple fix to my code to get . or $_ working .... without going into the details, the status is (i) I agree that the current, working example for sort is a (bit of a) hack, (ii) DataSlice employs delegation and overloads so that it can mix Positional and Associative as "cascading accessors", this has about 80% coverage of the use cases, (iii) the issue arises because sort seems to coerce a DataSlice to an Array  [which I guess is necessary to Iterate it] and this Array will not take , (iv) it is beyond my skill to identify a quick fix to dehack sort, (v) as the use cases for Dan (and it's brethren) solidifies, I would like to circle back and refactor this area (likely employing something like Hash::Agnostic / Array::Agnostic) to get the non-hacky sort syntax working, (vi) but since the hack will continue to work alongside a future "non-hackified" example I think that it's good enough for now because (vii) I am focusing my time to get Dan::Polars to MLP per the TODO lists(s) over there --- I have made an issue for this over at GH Dan and, as ever, will be happy to adapt my priorities according to comments/issues from users of Dan over on GH ...

https://rakujourney.wordpress.com/2023/06/05/cascading-accessors/


✨ Improved images background color to match the Raycast theme

Description

✨ Improved images background color to match the Raycast theme

Screencast

Checklist

[x] I read the extension guidelines
[x] I read the documentation about publishing
[x] I ran npm run build and tested this distribution build in Raycast
[x] I checked that files in the assets folder are used by the extension itself
[x] I checked that assets used by the README are placed outside of the metadata folder

bad PR


chore: update k8s hotfixes for 1.18 1.19 and 1.20

Update base image of Windows server 2019 to the latest
Cache k8s hotfixes
Cache signed related to containerd

Cache sign script signedscripts-v0.0.12.zip
Update collect-windows-logs.ps1 to collect containerd containers and images
We don't add other changes mentioned in https://github.com/Azure/aks-engine/pull/4219 because this needs more tests and vendor agentbaker. Accordingly, signedscripts-v0.0.12 will be enabled in AKS until the other changes are ready.
reference: https://github.com/Azure/aks-engine/pull/4219

https://github.com/Azure/AgentBaker/raw/qinhao/update-k8s-hotfixes/vhdbuilder/scripts/windows/collect-windows-logs.ps1 will be replaced with https://github.com/Azure/AgentBaker/raw/master/vhdbuilder/scripts/windows/collect-windows-logs.ps1 after VHD cache test is green.


Support For Mojave Dark Mode

Changed table view to use system colors to provide support for Mojave Dark Mode.

It's a good point. I had tested gridColor but it was very dark and wasn't being correctly color mixed with the Desktop picture - this now seems to be the case with unemphasizedSelectedTextBackgroundColor which does't get mixed in Dark Mode. Changes in 10.14.2 perhaps?
I have switched to gridColor for the grid lines and kept the unused table sections as alternatingContentBackgroundColor as it does the right thing in Dark Mode and adapts to the Desktop Picture.

Any plans to merge it?

I'd love to have dark mode on my Table Tool app. Any plans on updating the app to support dark mode?


Extended management of API certs and credentials in cli config

Fixes #468

Local execution of the acceptance tests fails only in a single place, unrelated to the work done by this PR.
This happens even for FLAKE_ATTEMPTS=6, so looks to be a genuine issue.
It looks to be an issue which came in with the recent AppCRD merge to main.
This PR was rebased to include these changes.
Relevant message from the tests:
[6] [Fail] Apps API Application Endpoints Staging when staging a new app [It] returns a success
[6] /home/work/SUSE/dev/epinio/acceptance/api_v1_applications_test.go:405

I believe that this PR can be merged.


positioning bug when cursor over parent container

Hi RubaXa,
When the cursor drag an element over its container (but not over a draggable element), Sortable always moves the dragEl at the bottom of the container. This works fine if you drag over another container.
For some mysterious reason this bug is really visible only in fallback mode (set the supportDraggable to false line 57 to see it)
see http://jsbin.com/yohewi/5/edit?html,css,output
this is related to _onDragOver() in Sortable.js#L552
                if ((el.children.length === 0) || (el.children[0] === ghostEl) ||
                    (el === evt.target) // <--------- if cursor over container (ex: between 2 elements with margins)
                    && (target = _ghostInBottom(el, evt))
                ) {

                   // ...

                    if (_onMove(rootEl, el, dragEl, dragRect, target, targetRect) !== false) {
                        el.appendChild(dragEl); // <------ put dragEl at bottom
                        // ...
                    }
                }

I tried to fix it but unfortunately I did not succeed, any idea ?

I had a similar problem as you describe, as well having problems moving items between different containers when the items did not have a vertical layout.
There seem to be a bug in _ghostInBottom().
When using touch or when native drag and drop is not supported. In these cases a ghost item is appended to the container.
The problem is that the _ghostInBottom assumes that the lastElementChild is the last draggable item, but it will actually check against the ghost item. Changing the _ghostInBottom to this fixed the problem while still allowing the item to be dragged into another container:
function _ghostInBottom(el, evt) {
		var lastEl = el.lastElementChild,
			rect = lastEl.getBoundingClientRect();

		if (lastEl === ghostEl) {
			return false;
		}

		return (evt.clientY - (rect.top + rect.height) > 5) && lastEl; // min delta
	}

This method has other problems as well which will manifest when trying to do something else than vertical lists when the container is bigger than its contained items.
If the layout is horizontal or like in my example, grid (4xN), the
return (evt.clientY - (rect.top + rect.height) > 5) && lastEl;

will fail to detect that I am actually hovering the container. It's not an easy to write one that will fit all use-cases. The one that fixed it for me was:
function _ghostInBottom(el, evt) {
                var parentMargin = 16, rect = el.getBoundingClientRect();

                if (evt.clientY > rect.top + parentMargin &&
                        evt.clientX > rect.left + parentMargin &&
                        evt.clientY < rect.bottom - parentMargin &&
                        evt.clientX < rect.right - parentMargin)
                return el.lastElementChild;
	}

This one will have the in-between items margin problem though (which is not an issue in my use case)
Anyways, just wanted to flag for this and propose to expose this method to be configurable :)

Thank you Addeventure, you're right, there is something with the _ghostInBottom related to this bug. Unfortunately, no time to investigate this for the moment

based on your idea, I suggest this fix.
If the last element is the ghostEl (fallback mode), it takes the previous element sibling or keep it if no other elements
    function _ghostInBottom(el, evt) {
        var lastEl = el.lastElementChild;
        if (lastEl===ghostEl) {
            lastEl = lastEl.previousElementSibling || ghostEl;
        }
        var rect = lastEl.getBoundingClientRect();
        return (evt.clientY - (rect.top + rect.height) > 5) && lastEl; // min delta
    }


Issue Fixed #7080

Issue Reference

#7080
Description

AddOption Button Moved Down
How To Test This?

Go to Admin -> Create a Bundle Product -> Add Options.
After adding First option, now create another option.
Here we need to scroll up and then we select the add option button.
Documentation

[ ] My pull request requires an update on the documentation repository.

@JunaidJaved248
Please add the border for the add option button, please take a reference from Here

@Sanjaybhattwebkul I think, there is no need of border here,
Border that You are referring, its accordian border,   And AddOption button is in under accordian,
In attached ss, you can see that when addoption button accordian closed, It seems Fine

@JunaidJaved248
Can you please add a message if there is no product added to a bundle, please take a reference from Here, Actually there is mismatching between bundle products and the add options button?

@JunaidJaved248
This is working fine, Please find the screenshot Here

@JunaidJaved248
Thanks for your contribution.

Closing the pull request, as I am not seeing any activity on this. Feel free to open a new one when the mentioned changes have been done.


Update requirements.md

Office 365 operated by 21Vianet is not supported

#2934

Sign in to Microsoft Teams Rooms (Skype for Business Mode only) using the 21Vianet Office365 resource account to indicate that username password verification has failed, but the same account can be logged in on Client.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@nenonix @ JohanFreelancer9此PR需要进行复制编辑。谢谢。

Hi，scanum
Skype for business online used in all of MTR's descriptions without listing China 21Vianet accounts are not supported，So too much update is required in the Docs MTR section

复制审核 - 请重新插入支架。

复制审核 - 请重新插入支架。

@JohanFreelancer9 Sorry, this is the first time I've modified MS Docs on github. If possible, please tell me what else to do.

@scnbwy Thank you the copy is fine now.

@scnbwy谢谢你的副本现在好了。

So, just wait for the Docs update to be described?

@LanaChin PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@sohailta please review this and advise.  Not aware of this China 21Vianet account limitation.

I have create a support ticket #:16065906
Confirmed China 21Vianet does not support

@sohailta Hi Sohail, any update on this PR? Thanks!

We don't recommend adding a specific provider here. We may be ok to add a statement/ note that "Microsoft Teams Rooms do not yet support Gallatin, GCC or GCC-High environments."

Good

@sohailta Could you please review changes? thanks!

given the conflicts that exist for this PR, I am closing this PR and implementing in a separate PR

the fix was implemented in https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/pull/3185


Multiple Instructions should be supported as per specification

Describe the bug
Currently, with Questionnaire Header, only the first instruction is displayed. But as per FHIR specifications, it should support multiple instructions.
Component
SDC library
To Reproduce
Steps to reproduce the behavior:

Go to HeaderView.kt
Observe the integration of the hint view. It only supports single instruction.
Same for GroupHeaderView.kt and other places

Expected behavior
As per FHIR specifications, Instructions can be 0..*, so multiple hints should be supported.
Reference for issue - #Smart-emcare issue
Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.
@santosh-pingle

I will take a look, thanks!

@khyativyasargus
Can you please attach the questionnaire.json for the reference?


follow up with picocli migration

This is a follow up of #7665
This PR completely removed args4j dependency and migrate all CLI utilities to use picocli. This should close: #7673
Afterwards #7710 outlines all the remaining TODOs that can be address later.

Codecov Report

Merging #7705 (2140fa8) into master (7d61528) will decrease coverage by 0.75%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7705      +/-   ##
============================================
- Coverage     71.48%   70.72%   -0.76%
- Complexity     4029     4033       +4
============================================
  Files          1581     1581
  Lines         80402    80402
  Branches      11944    11944
============================================
- Hits          57474    56864     -610
- Misses        19045    19650     +605
- Partials       3883     3888       +5

Flag
Coverage Δ

integration1
29.27% <ø> (+0.24%)
:arrow_up:

integration2
?

unittests1
68.59% <ø> (+<0.01%)
:arrow_up:

unittests2
14.54% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d61528...2140fa8. Read the comment docs.

@xiangfu0 @jackjlli can you help take a look? This is a follow up of #7665 . Would really want to get rid of this dependency before 0.9 release cut


Revert "generate template json for localized lang"

Reverts microsoft/Application-Insights-Workbooks#444
Need to implement multi-checkout

already have fixed out, closing out this PR


Gadget server and cookie support

Is your feature request related to a problem? Please describe.

When login Kancolle with conning_tower , there will be 403 forbidden (or 200 ok but is white screen) at game page

Describe the solution you'd like

Add cookie support and import KCWiki's gadget server (https://kcwiki.github.io/cache) to bypass regional blocks

Describe alternatives you've considered

There are other way to fix this issue (such as OOI or acgpower) but I think this solution is simple

I have checked poi-plugin-let-me-in,  use 3rd party cache should redirect url on iOS  that need a VPN service as I know.
ConningTower is a browser app and should not provide VPN services, as this would conflict with the VPN services already run on iOS and Android. The service may still be offered as part of this project in the future.
Quantumult X and similar applications can implement URL redirects via rules. While unproven, it is suggested to use these popular web tools.
If there is a way to implement this feature using the JavaScript console or by editing cookies, please let me know. It should be easy to implement.

P.S.
By the way not related to this open source project, it may needs to be stated here that the AppStore channel will never use NEVPNManager API ,  App Store Review Guidelines request only organization developer use that.

Apps offering VPN services must utilize the NEVPNManager API and may only be offered by developers enrolled as an organization.

These Javascript codes are used to edit cookies when there is no Kancolle browser on iOS(Use Safari):
javascript:document.cookie='ckcy=1;expires=Sun, 04 Feb 2029 09:00:09 GMT;domain=osapi.dmm.com;path=/';
javascript:document.cookie='ckcy=1;expires=Sun, 04 Feb 2029 09:00:09 GMT;domain=<IP_ADDRESS>;path=/';
javascript:document.cookie='ckcy=1;expires=Sun, 04 Feb 2029 09:00:09 GMT;domain=www.dmm.com;path=/netgame/';
javascript:document.cookie='ckcy=1;expires=Sun, 04 Feb 2029 09:00:09 GMT;domain=log-netgame.dmm.com;path=/';
Still works now for me, hope it useful

I have add a "Modify Cookie" button on web info page in 1.12.1+2 release. It looks not work well.


[BUG] Response compression not enabled on new CDN endpoint

Steps to Reproduce
Requesting the application insights bundle from the legacy endpoint returns a compressed response:
https://az416426.vo.msecnd.net/scripts/b/ai.2.min.js
content-encoding  gzip
content-length    37648
Requesting the bundle from the new endpoint does not return a compressed response:
https://js.monitor.azure.com/scripts/b/ai.2.min.js
content-length   126996
Expected behavior
The js.monitor.azure.com endpoint should support response compression.

Hi @harvey-k, I've tracked down the issue to a problem with one of our CDN endpoints (which was the primary), I've just switched the provider used for this endpoint (as manual testing should that it was working). It may take up to 5 minutes (depending on your DNS cache and provider) before the change is reflected.

Hi @harvey-k, I've tracked down the issue to a problem with one of our CDN endpoints (which was the primary), I've just switched the provider used for this endpoint (as manual testing should that it was working). It may take up to 5 minutes (depending on your DNS cache and provider) before the change is reflected.

So js.monitor.azure.com should be serving the compressed version shortly, additionally we also just release v2.5.11 to the CDN (not related to this issue -- just timing)

So js.monitor.azure.com should be serving the compressed version shortly, additionally we also just release v2.5.11 to the CDN (not related to this issue -- just timing)

@MSNev Wonderful, thank you for your help!

@MSNev Wonderful, thank you for your help!


fix: image-show missing can-delete/can-update fields

这个 PR 实现什么功能/修复什么问题:
修正：image-show缺少can_delete/can_update字段
是否需要 backport 到之前的 release 分支:

release/2.10.0

Codecov Report

Merging #1111 into master will increase coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1111      +/-   ##
=========================================
+ Coverage    7.85%   7.87%   +0.01%
=========================================
  Files         356     356
  Lines       56592   56592
=========================================
+ Hits         4445    4455      +10
+ Misses      51749   51740       -9
+ Partials      398     397       -1

Flag
Coverage Δ

#aFlag
7.87% <0%> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/cloudcommon/db/db_dispatcher.go
0% <ø> (ø)
:arrow_up:

pkg/cloudcommon/db/modelbase.go
2.46% <0%> (-0.04%)
:arrow_down:

pkg/util/rbacutils/rbac.go
75.23% <0%> (+2.53%)
:arrow_up:

pkg/appsrv/response.go
69.23% <0%> (+3.07%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6bfdb...b685ef1. Read the comment docs.

/approve
/lgtm


Nav Mesh only works with Y axis = 0 starting position

Seems like Nav Mesh stops working if you change the starting position of a user to anything other than 0.  Example in: https://arena-dev1.conix.io/build/?scene=public%2Farena-meeting
public/arena-meeting
change y-axis of "startPosition1" to anything but 0 and it seems to break.  Nav mesh works with y=0.

Oops, I guess this is a feature not a bug.  Your camera starts at y+1.6 now and you need to be on the nav mesh at the start to use it. Will add to docs!


Port to python 3

Deliberately unsquashed at this point as I thought it might be helpful to leave the individual commits.
Not very familiar with travis build stages so not sure if the config is the best way to achieve this.
Large change to doctests format is due to the ordering of the email.as_string() method not being consistent going from p2 -> p3. In doing this, I noticed that the previous examples were missing the X-Log-Level header due to the doctests ellipsis matching too much. The previous method of testing with printing to screen meant that the tests of emails that aren't sent did something meaningful. With my new implementation, not so much, but I wasn't sure it was particularly worth the effort of adding an explicit check for this in the doctests as I don't think it adds to the clarity of the documentation.
Also tested manually locally with utf-8 encoded log messages and it all appears to work correctly.
Obviously happy to discuss / revisit / revise.

Coverage remained the same at 100.0% when pulling 77d9632b78417b9ca1d229dad15ec9a846fbf9a4 on mjms3:master into 7a62cea21f31f7902582d5e2d7d639ea66b6f540 on Simplistix:master.

what's driving check_sent_message_matches? I'd ideally prefer to keep the assertions as they were, so I'm trying to understand the reason for the change? edit: Is this the email.as_string() ordering thing?
** Yes, this is because of the the email.as_string() ordering thing + the fact that the tests as they were were quite brittle (and actually were passing incorrectly due to over enthusiastic matching by the doctest ellipsis). However, I'm really, really, really not keen on the way they made the documentation look. I was thinking about this and think that the best way to achieve the same documentation look as before but to have more ability to compare the actual to the expected ie to implement the check_sent_messages style check (or possibly something a bit neater and less bleurgh) would be to wrap the expected results in a block with a custom Parser and still print to screen-- i'm not that familiar with all the tooling that you've used, but I think that shouldn't be too hard to achieve. Thoughts?

Would it be simpler to just make a 5.x that was Python 3 only? The code changes so infrequently that I reckon maintaining a 4.x for Python 2 and having 5.x be Python 3 only.
** It's your project, so I'll leave you to make that call but I'd personally prefer to have code that is compatible with python 2 and 3... the reason I originally did the port is that I wanted to submit a PR for some different functionality and I'd want that on both python 2 and python 3.
Thanks for the quick response and questions

Follow up.
As a side note, Sybil is awesome!!
Anyhow, I think that the cleanest thing to do with respect to the tests is to create a custom OutputChecker that can be passed to the DocTestRunner. Thoughts?
This will either mean creating a new DocTestParser specific to the MailingLogger, or modifying the one in sybil (along with the Sybil DocTestRunner) to allow the checker option to be passed through.
Sound reasonable?

Glad you like Sybil, @benji-york is the genius behind it with Manuel, I just slimmed Manuel down so it would fit in my brain.
So, I think a new sybil parser is the way to go here. We need to find a ReStructuredText rendering of the mail messages that both looks nice and is easily parseable.
I'm not a fan of wiring in any more through the DocTestParser, doctests are convoluted and unmaintained in their implementation and Sybil gives us a nicer way to go.
Good luck, happy to help where I can but I'm seriously limited on time.
Also curious: what was the different functionality you're looking to implement? (maybe stick it in another issue for discussion...)

Hey @mjms3 :-) Any joy with this? I'm likely to need it myself soon so wanted to see how things were going...

Hey @cjw296. Afraid I haven't had a chance to look at it much since embarrassed face.
I'll close this PR now the other one is ready...


Fixes undefined vars becoming null and erroring in conditions

When running the following
><EMAIL_ADDRESS>start
> ts-node --log-error src/index.ts --cwd ../some-dir --list-json

The following error occurs
Error attempting to evaluate the following rules:
  rules:
    - if: '"main" && null =~ /\bdependency_scanning\b/ && null == "true"'
as
```javascript
"main" && null.match(/\bdependency_scanning\b/)  != null&& null == "true"

TypeError: Cannot read properties of null (reading 'match')
    at eval (eval at evaluateRuleIf (gitlab-ci-local/src/utils.ts:258:19), <anonymous>:1:20)
    at Function.evaluateRuleIf (gitlab-ci-local/src/utils.ts:258:19)
    at Function.getRulesResult (gitlab-ci-local/src/utils.ts:181:24)
    at new Job (gitlab-ci-local/src/job.ts:217:38)
    at gitlab-ci-local/src/parser.ts:179:29
    at Function.forEachRealJob (gitlab-ci-local/src/utils.ts:54:13)
    at Parser.init (gitlab-ci-local/src/parser.ts:165:15)
    at async Function.create (gitlab-ci-local/src/parser.ts:60:9)
    at async handler (gitlab-ci-local/src/handler.ts:63:18)
    at async Object.handler (gitlab-ci-local/src/index.ts:37:21)

I suspect this happens on a yml that contains
include:
  - template: Security/SAST.gitlab-ci.yml
  - template: Jobs/Dependency-Scanning.gitlab-ci.yml

which expands to the following:
gemnasium-maven-dependency_scanning:
  stage: test
  script:
    - /analyzer run
  artifacts:
    access: developer
    reports:
      dependency_scanning: gl-dependency-scanning-report.json
      cyclonedx: '**/gl-sbom-*.cdx.json'
    paths:
      - '**/gl-sbom-*.cdx.json'
  dependencies: []
  rules:
    - if: $DEPENDENCY_SCANNING_DISABLED == 'true' || $DEPENDENCY_SCANNING_DISABLED == '1'
      when: never
    - if: $DS_EXCLUDED_ANALYZERS =~ /gemnasium-maven/
      when: never
    - if: $CI_COMMIT_BRANCH && $GITLAB_FEATURES =~ /\bdependency_scanning\b/ && $CI_GITLAB_FIPS_MODE == "true"
      exists:
        - '**/{build.gradle,build.gradle.kts,build.sbt,pom.xml}'
      variables:
        DS_IMAGE_SUFFIX: '-fips'
    - if: $CI_COMMIT_BRANCH && $GITLAB_FEATURES =~ /\bdependency_scanning\b/
      exists:
        - '**/{build.gradle,build.gradle.kts,build.sbt,pom.xml}'
  allow_failure: true
  variables:
    DS_ANALYZER_IMAGE: $SECURE_ANALYZERS_PREFIX/$DS_ANALYZER_NAME:$DS_MAJOR_VERSION
    DS_ANALYZER_NAME: gemnasium-maven
  image:
    name: $DS_ANALYZER_IMAGE$DS_IMAGE_SUFFIX
  cache:
    - *ref_0
  before_script:
    - >-
      if command -v git && [ $OPS_CONSOLE_SHA ]; then (cd services/opsConsole; git fetch --depth 1 origin $OPS_CONSOLE_SHA; git switch --detach
      $OPS_CONSOLE_SHA); fi
    - >-
      if [ $(npm --version) ] && [ "$CI_JOB_NAME" = "${CI_JOB_NAME#gemnasium}" ]; then npm ci --cache .npm --prefer-offline; else echo "container does not use
      NPM"; fi

With the problematic line being
- if: $CI_COMMIT_BRANCH && $GITLAB_FEATURES =~ /\bdependency_scanning\b/ && $CI_GITLAB_FIPS_MODE == "true"

This can be avoided by defining the variable to be empty, however the proposed solution is likely more future proof.

can help to update the test cases so that we can have regression test
https://github.com/firecow/gitlab-ci-local/blob/master/tests/rules-regex.test.ts#L74

btw i pushed directly into your branch, hope you're ok with it

since your changes had failed the regression test.
and our implementation can be a little convoluted....
i hijacked your mr and pushed directly into your branch, hope you're ok with it

I don't mind at all thank you!
Something with my docker setup is causing a lot of tests to fail that I still need to investigate :/


Molecules tests

@rosskarchner @kave @kurtw  - Just adds some more tests for molecules.

Refresh db
Run gulp test:acceptance:wagtail --specs=molecules.js

Each one failed for me :( Are there any other things I must do?

I would make sure you've reset the database. Ideally we would just have that as part of the test script; not sure why we don't :\

I got 2/8 --
When you say "refresh DB", do you mean run initial-test-data.sh, or load a recent snapshot of the 'refresh' server?

it worked! 👍


Update the list of required options for Channel.createMessage()

sticker_ids and components were missing in Channel.createMessage() (and Webhook.executeWebhook() for the latter).
I've also removed the check for editMessage() because "All parameters to this endpoint are optional and nullable." as per the doc (for example, you may want to update only the flags).

Thank you for the continued contributions ♥


Add SourceLair to projects with built-in support for Tern

SourceLair provides built-in support for Tern in it's JavaScript auto-complete feature.
It would be great if it was featured in the editors supporting Tern.

Thanks. Merged.


15 Critical vulnerabilities found

The application has 15 critical and 4 high vulnerabilities:
55 vulnerabilities found - Packages audited: 2796
Severity: 8 Low | 28 Moderate | 4 High | 15 Critical

Consider using dependabot.

Interesting, can you ensure that the vulnerabilities found (especially those with a high and critical level of severity) can be exploited, or are you just throwing this source code into the scanner and not understanding the results displayed?

Have checked each, and none of those are exploitable.
Am using Snyk (similar to Dependabot)


Suppression for libarcher.sa

Suppression for libomp.so and libarcher.so is made by the function  in "__tsan_default_suppressions" or through a file declared using the TSAN_OPTION. In branch manage_clock the suppression.txt has been updated but we need to update also the function redefined automatically by clang-archer at compile time. Also the suppression.txt suppress ompt_tsan.so, however the new name should be libarcher.so.

@dongahn Why this issue wasn't closed automatically? I put Resolve #21 in pull request body message (#19).

I reallized, that this suppression was the cause for additional memory overhead. So, I reverted this change.

Hmmm. I dont understand this one. The keywords are documented at help.github.com/articles/closing-issues-via-commit-messages
And yours seem right.

@jprotze So you basically don't need to suppress libarcher.so?

Perhals automatic closing just works when the changes makes into the default branch (master...)

@simoatze suppression for libarcher is not needed.

@jprotze So can I also modify the archer Pass and remove the redefinition of the tsan suppression function? Or do we still need the suppression?

You can remove the suppression also from the archer pass


Send users there activation email again

It would if a user lost his password to be able to resend his activation email.

Fixes #51

@brambokdam Just checking this out, I like the checkbox that appears when you sent the invite again :D

Thanks :+1:


Rust analyzer yells when including an Option type in a custom enum type

What version are you using?
0.9.1

What did you do?

#[contracttype]
#[derive(Clone, Debug, Eq, PartialEq)]
pub enum Test {
    Poof(Option<Address>, Address, i128)
}

What did you expect to see?
A happy clappy code editor
What did you see instead?

the trait bound `core::option::Option<soroban_sdk::Address>: SorobanArbitrary` is not satisfied
the following other types implement trait `SorobanArbitrary`:
  ()
  ContractContext
  CreateContractHostFnContext
  Glyph
  GlyphType
  HashType
  InvokerContractAuthEntry
  OfferType
and 23 others

Note I can still run soroban contract build so it's not an actual error

Doesn't seem like this happens anymore (which is expected given that 1 year has passed).

I'm still seeing this issue with 21.4.0

This issue is pretty hard to reproduce consistently and it seems like it doesn't occur with p22 SDK, at least I haven't been able to trigger it (at the same time I was able to trigger it with p21 SDK again). I won't close this yet, but will double-check after v22 SDK release.

It looks like this was the fix. When I cherry pick that fix onto 21.7.4, cargo test, works just fine.

https://github.com/stellar/rs-soroban-sdk/pull/1338

I've opened a backport release 21.7.5 that contains the fix, as the fix is easily cherry-picked onto the sdk.

https://github.com/stellar/rs-soroban-sdk/pull/1370

@dmkozh Could you review the release PR, and I'll do a release once approved.

Fixed in release v21.7.5:

https://github.com/stellar/rs-soroban-sdk/pull/1370


We face an issue with S2 Level 0 products. validity stop date t1 is missing !

Hi Bogdana,
Names of S2 L0 products contains only the validity start date t0, and the creation date,
So without the validity stop date  we won't be able to apply the selection rules , especially the
LatestValCover rule needed for many S2 auxiliary data files.
Regards,
Naceur MESKINI.

The chosen and implemented solution is t1 = t0


Upstream nvim at 23fe6dba1 breaks tab completion

My testing minimal init.vim
The part of the mapping that is relevant:
require('astronauta.keymap')
vim.keymap.inoremap{'<Tab>',   require("completion").smart_tab,   buffer=true, silent=true}
vim.keymap.inoremap{'<S-Tab>', require("completion").smart_s_tab, buffer=true, silent=true}

How to reproduce
Compile the upstream at this commit. Use tab completion.
Expected behaviour
Completion popup to show up, but it doesn't.
I can confirm that completion works at this commit.

The handler function's signature in source/lsp.lua needs to be updated, possibly adding a backwards-compatible wrapper for neovim versions prior to this commit. As an intermediate hack, this should help:
-  vim.lsp.buf_request(params.bufnr, 'textDocument/completion', position_param, function(err, _, result)
+  vim.lsp.buf_request(params.bufnr, 'textDocument/completion', position_param, function(err, result)

@stormc thanks for the workaround, looking forward to the fix 😄

@mrkz You're welcome, #400 does also proper-fix hover and signature for which you would have to apply this workaround's gist as well, so I suggest to use that instead of this workaround until it's been merged.


add scaled lr to consine lr decay

for shitu learning rate x8 exps

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zengshao0622 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[Achievements] - add tooltip on achievement card, when the achievement title is not fully displayed

Achievements

Done


[Extensions] to add a draw feature over the Meshery canvas

Current Behavior

Desired Behavior

Implementation

Acceptance Tests

Mockups

Contributor Guides and Handbook

📚 Meshery Build and Release Strategy
🎨 UI Design For Meshery Extensions Figma in Figma (open invite)
📚 Meshery Extensibility Providers
⌨ Meshery API Docs
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

// @aabidsofi19

can i work on this?

This issue has been open for some time with no recent activity, unassigning to open it up for new contributors to give it a go.


Getting all Image references from a chart convenience function

Sometimes you need to ship all images referenced in a helm chart to your private docker registry. You do a helm template|grep image: and pull/tag/push each one of them.
For example
`
helm-to-image-ref() {
HELM_CHART_REF=$1
helm template $HELM_CHART_REF|grep image|grep image:|xargs|sed --expression 's/image://g' - |xargs
}
helm-to-image-ref jetstack/cert-manager

Would return all image references from the above chart. This could be combine with a tool like skopeo copy.
Is this feature something that could be considered as a helper function in helm ?
Some flag in helm template or other ?

The most reliable way is to first try to deploy your chars into k8s and then fetch image references from kubernetes

Have a look at https://github.com/helm/community/pull/281


Closing game while threads are running crashes it

Godot version: v3.2.alpha3.official
OS/device including version: Windows 8.1
Issue description:
In 3.2 my game now crashes upon closing it. The issue does not occur in 3.1
When the thread's running and the game is closed it crashes about half the time. You can either call get_tree().quit() via a keypress outside the thread, or click the X button to close the window to cause the crash.
Calling get_tree().quit() INSIDE the thread crashes on both 3.1 and 3.2, I think this is probably to be expected since I read something about accessing the scene tree inside threads being a bad idea.
3.2 might now be acting as if get_tree().quit() is always being called from inside the thread even when executing it outside the thread. Just guessing. I would assume Godot treats closing the game window with the mouse the same as writing that line of code but I dunno.
Minimal reproduction project: Isolate crash upon Escape.zip

Backtrace
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x46470) [0x7f9a5146b470] (??:0)
[2] GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) (/mnt/KubuntuWolne/godot/modules/gdscript/gdscript_function.cpp:1564 (discriminator 1))
[3] GDScriptInstance::call(StringName const&, Variant const**, int, Variant::CallError&) (/mnt/KubuntuWolne/godot/modules/gdscript/gdscript.cpp:1164)
[4] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/mnt/KubuntuWolne/godot/core/object.cpp:900 (discriminator 1))
[5] _Thread::_start_func(void*) (/mnt/KubuntuWolne/godot/core/bind/core_bind.cpp:2631 (discriminator 1))
[6] ThreadPosix::thread_callback(void*) (/mnt/KubuntuWolne/godot/drivers/unix/thread_posix.cpp:76)
[7] /lib/x86_64-linux-gnu/libpthread.so.0(+0x9669) [0x7f9a5197e669] (??:0)
[8] /lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7f9a51547323] (??:0)

Sometimes Godot doesn't crash and show leak
WARNING: cleanup: ObjectDB Instances still exist!
   At: core/object.cpp:2069.
Leaked instance: _Thread:1181
Orphan StringName: _thread_function
Orphan StringName: _Thread
StringName: 2 unclaimed string names at exit.

or error
ERROR: ~_Thread: Reference to a Thread object object was lost while the thread is still running...
   At: core/bind/core_bind.cpp:2738.

Here's another minimal-reproduction project that will crash reliably.
Threaded for loop crash.zip
extends Node
var thread = Thread.new()

func _ready():
	thread.start(self, "_thread_function")

func _thread_function(userdata):
	var counter = 0;
	for i in 100000000:
		counter += 1
	print('To produce crash, close the game before this message is printed')

It can crash on numbers far lower than 100000000, I'm just using this number for the sake of reproducing the crash every time.

FYI, there are many places in GDScriptFunction::call that accesses the GDScriptLanguage singleton without null check. For example, I always crash at line 1589 here:
https://github.com/godotengine/godot/blob/16fc023d4487c2a3f26b5bdd3827628de2cd0ba2/modules/gdscript/gdscript_function.cpp#L1589-L1596
During Main::cleanup, gdscript types are unregistered. The singleton is also deleted and set to NULL.
https://github.com/godotengine/godot/blob/16fc023d4487c2a3f26b5bdd3827628de2cd0ba2/modules/gdscript/register_types.cpp#L173-L185
If the singleton is not deleted (commenting out the if part above), the reproduction project does not crash. But I don't think it's a right fix.
Should the assumption "Singletons are always available" be true?

Testing on 3.2.2.stable on linux mint 18.3

Can reproduce "~_Thread: Reference to a Thread object was lost while the thread is still running..." with "Isolate Crash upon Escape.zip" project. Happens maybe every 1 in 2 runs.
Can't reproduce crash with the "Threaded for loop crash.zip" project (performed about 20 runs). No crash, errors, leaks in terminal or other apparent issues.

I don't have a crash now but have this errors:
SCRIPT ERROR: : Unable to iterate on object of type 'Nil'.
   At: res://Main.gd:21.
ERROR: ~_Thread: Reference to a Thread object was lost while the thread is still running...
   At: core/bind/core_bind.cpp:2835.

sometimes leak:
Direct leak of 112 byte(s) in 1 object(s) allocated from:
    #0 0x7fe07c401517 in malloc (/lib/x86_64-linux-gnu/libasan.so.6+0xb0517)
    #1 0xec92db3 in Memory::alloc_static(unsigned long, bool) core/os/memory.cpp:82
    #2 0xec92cb2 in operator new(unsigned long, char const*) core/os/memory.cpp:42
    #3 0x50c3433 in ThreadPosix::create_func_posix(void (*)(void*), void*, Thread::Settings const&) drivers/unix/thread_posix.cpp:83
    #4 0xeca98df in Thread::create(void (*)(void*), void*, Thread::Settings const&) core/os/thread.cpp:51
    #5 0xf2b2173 in _Thread::start(Object*, StringName const&, Variant const&, _Thread::Priority) core/bind/core_bind.cpp:2774
    #6 0xf387edb in MethodBind4R<Error, Object*, StringName const&, Variant const&, _Thread::Priority>::call(Object*, Variant const**, int, Variant::CallError&) core/method_bind.gen.inc:3325
    #7 0xe762ee7 in Object::call(StringName const&, Variant const**, int, Variant::CallError&) core/object.cpp:922
    #8 0xe9d9875 in Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) core/variant_call.cpp:1127
    #9 0x1a76c4f in GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) modules/gdscript/gdscript_function.cpp:1088
    #10 0x18aa23f in GDScriptInstance::call(StringName const&, Variant const**, int, Variant::CallError&) modules/gdscript/gdscript.cpp:1237
    #11 0xe762a57 in Object::call(StringName const&, Variant const**, int, Variant::CallError&) core/object.cpp:901
    #12 0xe9d9875 in Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) core/variant_call.cpp:1127
    #13 0x1a76c4f in GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) modules/gdscript/gdscript_function.cpp:1088
    #14 0x18aa23f in GDScriptInstance::call(StringName const&, Variant const**, int, Variant::CallError&) modules/gdscript/gdscript.cpp:1237
    #15 0xe762a57 in Object::call(StringName const&, Variant const**, int, Variant::CallError&) core/object.cpp:901
    #16 0xe7337a4 in MessageQueue::_call_function(Object*, StringName const&, Variant const*, int, bool) core/message_queue.cpp:250
    #17 0xe7344fd in MessageQueue::flush() core/message_queue.cpp:297
    #18 0x962cf94 in SceneTree::iteration(float) scene/main/scene_tree.cpp:483
    #19 0x15c4da4 in Main::iteration() main/main.cpp:2082
    #20 0x14bf6ab in OS_X11::run() platform/x11/os_x11.cpp:3233
    #21 0x143a4e5 in main platform/x11/godot_x11.cpp:56
    #22 0x7fe07af550b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

and sometimes invalid read/write
==13112==ERROR: AddressSanitizer: heap-use-after-free on address 0x6160000b2f84 at pc 0x000001a832b2 bp 0x7f5ae154a370 sp 0x7f5ae154a360
READ of size 4 at 0x6160000b2f84 thread T6
    #0 0x1a832b1 in GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) modules/gdscript/gdscript_function.cpp:1470
    #1 0x18aa23f in GDScriptInstance::call(StringName const&, Variant const**, int, Variant::CallError&) modules/gdscript/gdscript.cpp:1237
    #2 0xe762a57 in Object::call(StringName const&, Variant const**, int, Variant::CallError&) core/object.cpp:901
    #3 0xf2b0712 in _Thread::_start_func(void*) core/bind/core_bind.cpp:2728
    #4 0x50c33f3 in ThreadPosix::thread_callback(void*) drivers/unix/thread_posix.cpp:74
    #5 0x7f5afcab0608 in start_thread /build/glibc-YYA7BZ/glibc-2.31/nptl/pthread_create.c:477
    #6 0x7f5afbd17102 in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x122102)

0x6160000b2f84 is located 260 bytes inside of 528-byte region [0x6160000b2e80,0x6160000b3090)
freed by thread T0 here:
    #0 0x7f5afd0c81b7 in __interceptor_free (/lib/x86_64-linux-gnu/libasan.so.6+0xb01b7)
    #1 0xec93ca4 in Memory::free_static(void*, bool) core/os/memory.cpp:178
    #2 0x143b1de in CowData<int>::_unref(void*) core/cowdata.h:213
    #3 0x143af94 in CowData<int>::~CowData() core/cowdata.h:377
    #4 0x143aaf8 in Vector<int>::~Vector() core/vector.h:126
    #5 0x1a91cd3 in GDScriptFunction::~GDScriptFunction() modules/gdscript/gdscript_function.cpp:1796
    #6 0x18f848f in void memdelete<GDScriptFunction>(GDScriptFunction*) core/os/memory.h:117
    #7 0x18a277f in GDScript::~GDScript() modules/gdscript/gdscript.cpp:986
    #8 0x14e80b4 in void memdelete<Reference>(Reference*) core/os/memory.h:117
    #9 0x14da5e4 in Ref<Reference>::unref() core/reference.h:279
    #10 0x14cf514 in Ref<Reference>::~Ref() core/reference.h:295
    #11 0xe826b66 in RefPtr::~RefPtr() core/ref_ptr.cpp:102
    #12 0xe78a419 in Object::~Object() core/object.cpp:1993
    #13 0x958829c in Node::~Node() scene/main/node.cpp:2977
    #14 0xad5ac98 in Spatial::~Spatial() scene/3d/spatial.cpp:847
    #15 0x1e3dd07 in void memdelete<Node>(Node*) core/os/memory.h:117
    #16 0x9519e8f in Node::_notification(int) scene/main/node.cpp:175
    #17 0x175fa99 in Node::_notificationv(int, bool) scene/main/node.h:46
    #18 0x97acc4e in Viewport::_notificationv(int, bool) scene/main/viewport.h:91
    #19 0xe763377 in Object::notification(int, bool) core/object.cpp:932
    #20 0xe752337 in Object::_predelete() core/object.cpp:387
    #21 0xe78a836 in predelete_handler(Object*) core/object.cpp:2053
    #22 0x9687915 in void memdelete<Viewport>(Viewport*) core/os/memory.h:114
    #23 0x9633cad in SceneTree::finish() scene/main/scene_tree.cpp:621
    #24 0x14bfbb8 in OS_X11::run() platform/x11/os_x11.cpp:3237
    #25 0x143a4e5 in main platform/x11/godot_x11.cpp:56
    #26 0x7f5afbc1c0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

previously allocated by thread T0 here:
    #0 0x7f5afd0c88d0 in __interceptor_realloc (/lib/x86_64-linux-gnu/libasan.so.6+0xb08d0)
    #1 0xec93830 in Memory::realloc_static(void*, unsigned long, bool) core/os/memory.cpp:137
    #2 0x14d8bed in CowData<int>::resize(int) core/cowdata.h:287
    #3 0x14cf114 in Vector<int>::resize(int) core/vector.h:84
    #4 0x14cfc37 in Vector<int>::push_back(int) core/vector.h:152
    #5 0x1984c63 in GDScriptCompiler::_parse_block(GDScriptCompiler::CodeGen&, GDScriptParser::BlockNode const*, int, int, int) modules/gdscript/gdscript_compiler.cpp:1438
    #6 0x1984df6 in GDScriptCompiler::_parse_block(GDScriptCompiler::CodeGen&, GDScriptParser::BlockNode const*, int, int, int) modules/gdscript/gdscript_compiler.cpp:1440
    #7 0x1984df6 in GDScriptCompiler::_parse_block(GDScriptCompiler::CodeGen&, GDScriptParser::BlockNode const*, int, int, int) modules/gdscript/gdscript_compiler.cpp:1440
    #8 0x1988b9f in GDScriptCompiler::_parse_function(GDScript*, GDScriptParser::ClassNode const*, GDScriptParser::FunctionNode const*, bool) modules/gdscript/gdscript_compiler.cpp:1659
    #9 0x19961b1 in GDScriptCompiler::_parse_class_blocks(GDScript*, GDScriptParser::ClassNode const*, bool) modules/gdscript/gdscript_compiler.cpp:2023
    #10 0x199a4a0 in GDScriptCompiler::compile(GDScriptParser const*, GDScript*, bool) modules/gdscript/gdscript_compiler.cpp:2175
    #11 0x1893f3a in GDScript::reload(bool) modules/gdscript/gdscript.cpp:605
    #12 0x18d10e7 in ResourceFormatLoaderGDScript::load(String const&, String const&, Error*) modules/gdscript/gdscript.cpp:2293
    #13 0xf148691 in ResourceLoader::_load(String const&, String const&, String const&, bool, Error*) core/io/resource_loader.cpp:270
    #14 0xf14b313 in ResourceLoader::load(String const&, String const&, bool, Error*) core/io/resource_loader.cpp:401
    #15 0xc384e61 in ResourceInteractiveLoaderText::poll() scene/resources/resource_format_text.cpp:433
    #16 0xf1429aa in ResourceFormatLoader::load(String const&, String const&, Error*) core/io/resource_loader.cpp:197
    #17 0xf148691 in ResourceLoader::_load(String const&, String const&, String const&, bool, Error*) core/io/resource_loader.cpp:270
    #18 0xf14b313 in ResourceLoader::load(String const&, String const&, bool, Error*) core/io/resource_loader.cpp:401
    #19 0x15beba5 in Main::start() main/main.cpp:1938
    #20 0x143a418 in main platform/x11/godot_x11.cpp:55
    #21 0x7f5afbc1c0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Thread T6 created by T0 here:
    #0 0x7f5afd06fa95 in __interceptor_pthread_create (/lib/x86_64-linux-gnu/libasan.so.6+0x57a95)
    #1 0x50c38e8 in ThreadPosix::create_func_posix(void (*)(void*), void*, Thread::Settings const&) drivers/unix/thread_posix.cpp:90
    #2 0xeca98df in Thread::create(void (*)(void*), void*, Thread::Settings const&) core/os/thread.cpp:51
    #3 0xf2b2173 in _Thread::start(Object*, StringName const&, Variant const&, _Thread::Priority) core/bind/core_bind.cpp:2774
    #4 0xf387edb in MethodBind4R<Error, Object*, StringName const&, Variant const&, _Thread::Priority>::call(Object*, Variant const**, int, Variant::CallError&) core/method_bind.gen.inc:3325
    #5 0xe762ee7 in Object::call(StringName const&, Variant const**, int, Variant::CallError&) core/object.cpp:922
    #6 0xe9d9875 in Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) core/variant_call.cpp:1127
    #7 0x1a76c4f in GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) modules/gdscript/gdscript_function.cpp:1088
    #8 0x18aa23f in GDScriptInstance::call(StringName const&, Variant const**, int, Variant::CallError&) modules/gdscript/gdscript.cpp:1237
    #9 0xe762a57 in Object::call(StringName const&, Variant const**, int, Variant::CallError&) core/object.cpp:901
    #10 0xe9d9875 in Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) core/variant_call.cpp:1127
    #11 0x1a76c4f in GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) modules/gdscript/gdscript_function.cpp:1088
    #12 0x18aa23f in GDScriptInstance::call(StringName const&, Variant const**, int, Variant::CallError&) modules/gdscript/gdscript.cpp:1237
    #13 0xe762a57 in Object::call(StringName const&, Variant const**, int, Variant::CallError&) core/object.cpp:901
    #14 0xe7337a4 in MessageQueue::_call_function(Object*, StringName const&, Variant const*, int, bool) core/message_queue.cpp:250
    #15 0xe7344fd in MessageQueue::flush() core/message_queue.cpp:297
    #16 0x962cf94 in SceneTree::iteration(float) scene/main/scene_tree.cpp:483
    #17 0x15c4da4 in Main::iteration() main/main.cpp:2082
    #18 0x14bf6ab in OS_X11::run() platform/x11/os_x11.cpp:3233
    #19 0x143a4e5 in main platform/x11/godot_x11.cpp:56
    #20 0x7f5afbc1c0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

To make matters even more confusing I tested on my other machine and I got some different results.

v3.2.2-stable_win64 Windows 8.1 64bit 4790k CPU

"Threaded for loop crash" still crashing 100% of the time and the first project "Isolate crash upon Escape" crashes about 90% of the time.

v3.2.2-stable_win64 Windows 10 64bit e8400 CPU (11 year old PC)
No crashing at all. I was surprised, I thought this was a Windows vs Linux issue.

To be clear, here's what the "crash" looks like, upon closing the game.

Does this still occur in the master branch or the latest 4.0 release candidate? The above comments are only describing the issue happening in Godot 3.2.x.

The crashes appear to all be fixed, the get_tree().quit() crash, the closing the window with the mouse crash, and Threaded for loop crash.zip.
Thanks!


Vibrant Capacitor Bank dupe energy.

If you take Vibrant Capacitor Bank and put it in your inventory it will start charging itself. Fix this pls
EnderIO-1.7.10-<IP_ADDRESS>7

i was trying to figure out how they were charging before i put them back down

I give VCB from creative and it will start charging itself

Do you have a wireless charger? It will charge them before you place it.

tgstyle. inventory clear

Not in your inventory. Have you placed this block http://wiki.enderio.com/Wireless_Charger anywhere in the vicinity?

tgstyle: no

this bug does not apply to mod Ender IO. But what could it be? Even if the cell from ThermalExpansion charged.

It means there must be a wireless charger nearby. Things don't magically charge themselves.

wireless charger was not placed in the world

tier 5 jet pack from simply jet pack mod also charges the capacitor
also what forge version are you using ? you might want to update to the latest or create a new world and see if the capacitor is charging or not

6210classick, if generate a new world will not be a problem

Then it is obvious you have some sort of charging system set up in the area. As one of the mod devs has stated "It means there must be a wireless charger nearby. Things don't magically charge themselves." I suggest this be closed as user error.


Persistent colors on detected objects when using TFLite demo app

I would like persisent colors on detected objects when using the TFLite demo app on Android
System information

TensorFlow version (you are using): 1.13.1

Are you willing to contribute it (Yes/No): No

Describe the feature and the current behavior/state.
Detected objects in the TFLite demo app show rectangles around them with a confidence number. These rectangles change color and make a certain use case I have rather difficult. I'd like the colors to be persisent, let's say I have 3 labels:
Label A - GREEN
Label B - RED
Label C - BLUE
and so on.
Will this change the current api? How?
I don't want to change the current API but I would appreciate a suggestion on how to change this.
Who will benefit with this feature?
I will.
Any Other info.
No.

@Symphonized
Warning: As this doesn't appear to be a bug with Tensorflow, the better to may ask on StackOverflow since it is not a bug or feature request. There is also a larger community that reads questions there.
This can be achieved on following code changes,

Classifier.java

    public Recognition(
        final String id, final String title, final Float confidence, final RectF location, final int lablePos) {
      this.id = id;
      this.labelPos = lablePos;
      this.title = title;
      this.confidence = confidence;
      this.location = location;
    }

    private final int labelPos;
    public int getLablePosition() {
      return labelPos;
    }

TFLiteObjectDetectionAPIModel.java

      recognitions.add(
          new Recognition(
              "" + i,
              labels.get((int) outputClasses[0][i] + labelOffset),
              outputScores[0][i],
              detection,
                  (int) outputClasses[0][i] + labelOffset));

MultiBoxTracker.java

      if (potential.second.getLablePosition()  == 87) {//scissors [0 base index]
        trackedRecognition.color = Color.parseColor("#0D0068"); // CYAN for scissors
      } else if (potential.second.getLablePosition()  == 33) {//suitcase
        trackedRecognition.color = Color.parseColor("#AA33AA"); // MAGENTA for suitcase
      } else {
        trackedRecognition.color = COLORS[trackedObjects.size()];
      }

Thanks!

@Symphonized : Will it be possible to put some light on the feature you are proposing as in APIs that would get affected and the users who will be benefited with this change. Meanwhile you can also have a look on @Dayananda-V's suggestion. Thanks!

Thank you @Dayananda-V. Yes I realized this question might not suit the intended goal here. Thanks anyway for helping me find a solution even though it might have seemed trivial to you.
All the good.
Thanks.

@Symphonized : Will it be possible to put some light on the feature you are proposing as in APIs that would get affected and the users who will be benefited with this change. Meanwhile you can also have a look on @Dayananda-V's suggestion. Thanks!


difference as a composite mark

this allows to use all the smarts in areaY and lineY (e.g. default tip orientation, variable fill color).
Also adds:

a test for the curve+tension.
channels for the default tip, reflecting top value, bottom value and difference.

(I'd still want to remove the custom area generator but I'm not sure how.)
TODO:

[ ] make sure to only pass the relevant options to the area (for instance, we don't want to pass stroke through); maybe only curve+tension?

Note that a difference in the snapshot tests is a 0.5px realignment of the main line—which I think is correct in this branch.

This technique computes the channels multiple times, which isn’t quite right (e.g., if you have a nondeterministic channel specification that uses Math.random). I’ll think some more but I think we want to stick with a single mark while improving the tip behavior and supporting variable fill/stroke. I didn’t consider the latter a priority and hence punted on it, but I can work on it if you think it’s a blocker.

I wanted to explore a composite mark, because this looked like the perfect candidate for one, an solved "for free" the pending questions (variable fill) and the small alignment issue.
These can certainly be addressed differently, but composability is a great feature of Plot and if we can't use it in this case, it's a good indication that we need to make it work better. It would be great if a composite mark could share sub-mark channels, and it would also benefit the box mark.
I don't think this is blocking, it was just my way of reviewing your PR and going off on a tangent :)

I agree we often have this wrinkle with composite marks. And we do have the context.getMarkState method, so it should already be possible to share the channel definitions across marks using an initializer. It would also be possible to implement it as a channel transform, I suspect. Perhaps that is worth investigating.

I'm now using context.getMarkState to compute the channels once.


Package request: screen-pipe

Project description
Library to build personalized AI powered by what you've seen, said, or heard. Works with Ollama. Alternative to Rewind.ai. Open. Secure. You own your data. Rust. Has both CLI and desktop app.
Metadata

homepage URL: https://screenpi.pe
source URL: https://github.com/louis030195/screen-pipe
license: mit
platforms: unix, linux, darwin, windows

I am somewhat interested in this package and started a PR but I am super busy these days to thoroughly test the package. If anyone can do that, that would be awesome.


Add more favicons to db

Add these 5 favicon values associated with a product name to db.json (in alphabetical order)
Remove the entries from the scripts/favicon-to-add.txt file

The favicons:

1992142317: https://shodan.io/search?query=http.favicon.hash%3A1992142317
-1995251161: https://shodan.io/search?query=http.favicon.hash%3A-1995251161
-1996576874: https://shodan.io/search?query=http.favicon.hash%3A-1996576874
199682422: https://shodan.io/search?query=http.favicon.hash%3A199682422
-1998633262: https://shodan.io/search?query=http.favicon.hash%3A-1998633262

Remember to use the devel branch for the PR

@edoardottt I meant to ask what is the best and fastest way to do this thing?

@edoardottt I meant to ask what is the best and fastest way to do this thing?

In my opinion the best way to do this is to search these favicons using search engines (e.g. shodan) so that you can obtain the publicly exposed websites with that favicon icon and understand which service is linked to that favicon hash.
I thought shodan.io was the best, but I have a pro account... that's why some searches are limited. There could be other search engines that allow to search filtering by favicon, look at https://github.com/edoardottt/awesome-hacker-search-engines
Let me know if you have doubts or want to suggest a better method :)

@edoardottt I meant to ask what is the best and fastest way to do this thing?

In my opinion the best way to do this is to search these favicons using search engines (e.g. shodan) so that you can obtain the publicly exposed websites with that favicon icon and understand which service is linked to that favicon hash.
I thought shodan.io was the best, but I have a pro account... that's why some searches are limited. There could be other search engines that allow to search filtering by favicon, look at https://github.com/edoardottt/awesome-hacker-search-engines
Let me know if you have doubts or want to suggest a better method :)

Understood, thanks for your help! I'll try to look for other search engines too. Also, could you assign this issue to me again?

Done @Harsh1s

Completed! Thanks @Harsh1s


Use Fully-Qualified Type Paths in Macros

I ran into an error because I didn't use the requried types before calling the macro. This makes sure that you don't have to use anything and the macro should work regardless.
Also updated an out-of-date code sample in one of the doc readmes.

This was rolled up into https://github.com/aclysma/rafx/commit/4de391a69babf8de1db5e815010e17eadf732b4c


TypeScript type definitions

I’ve used juice in a recent project, since the project is written in TypeScript, I had to write type definitions for most of juice’s APIs. I'm wondering if there is interest in having type definitions as part of the juice project?
To do this properly for<EMAIL_ADDRESS>this would require:

juice.d.ts file
test-juice.ts file with tests which has to compile with correct type definitions taken from juice.d.ts file
types entry in package.json which points to juice.d.ts
extra devDependency on typescript

I’m happy to write types for the whole API and make a PR. If there is no interest in that, please close this issue.

I know I would definitely would be interested in this. If this is not accepted here (which would be preferable), you could otherwise try to submit them to typings or DefinitelyTyped

My main concern with this is maintaining it. Do projects usually add something to their tests to check the definitions or is it just a manual process if the API changes? Sorry, I'm not really familiar with typescript so bear with me.

@jrit: Thanks for the reply and your time. That is a valid concern of course, I've outlined the trade-offs below.
tldr;

type definitions testing can be an automatic process; when API changes the juice.d.ts would have to be updated manually to reflect API changes

The test-juice.ts file would be the test file for type definitions. The way it works is as follows:

We import the juice library into test-juice.ts
We call each API with correct type annotations and some mock data as per documentation
No compiler errors mean that API type definitions are compliant with current API
We call tsc test-juice.ts as part of the test suite (tsc is a typescript compiler, has to be included as a devDependency)

Few notes on the API changes:

The juice.d.ts file should be only updated when public facing API changes (the API described in the definition file)
If there are some new APIs, they have to be added to the juice.d.ts file manually, there is no way to do that automatically
If existing API changes, that change also have to be reflected in juice.d.ts file manually
juice.d.ts is source of truth about the API to the compiler, the compiler doesn't test the actual code from the library but uses the data from that file

Next steps
@jrit If you're OK with the trade-offs listed above, I'm happy to proceed with a PR. I am also happy to maintain the definition file when it would need updating.
Links

Example of a type definition test file: ramda-tests.ts, the test-juice.ts would be much simpler of course 😉

Sounds good to me. Thanks for explaining it all. There is a CONTRIBUTING.md - can you add a note about the TypeScript requirements in there as well when you prepare the PR?


Better unit test cleanup between tests

Current coverage is 73.91%

Merging #1214 into master will decrease coverage by -0.13% as of 9de66c5

@@            master   #1214   diff @@
======================================
  Files          265     265
  Stmts        15299   15303     +4
  Branches      1681    1683     +2
  Methods          0       0
======================================
- Hit          11328   11311    -17
- Partial        418     420     +2
- Missed        3553    3572    +19

Review entire Coverage Diff as of 9de66c5

Uncovered Suggestions

+0.08% via ...argets/FileTarget.cs#1722...1734
+0.08% via ...gingConfiguration.cs#282...293
+0.08% via ...gingConfiguration.cs#244...255
See 7 more...

Powered by Codecov. Updated on successful CI builds.


cocomac: Watch topindianholidays.com

cocomac requests the watch of the watch_keyword topindianholidays\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

topindianholidays\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


Only include extra-specific requirements for extra packages

Summary
Unclear if this is a good idea. Also unclear how it will intersect with universal locking, so leaving as a draft for now.

This got done in a separate PR.


Remove linking to tag on ploeh blog

Even non-tagged things could be related to F# somehow and even if it would be changed in the future, people can figure out how to filter by tag. This chapter is not about posts, it's about blogs.

Thank you!


Add samplerExpr to samplers in the descriptor map

The value is a quoted string containing the sampler literal
initializer expression (with whitespace removed).  The string
expression lists the components in sorted order, for easier
machine processing.
Adding this explicit expression makes it easier to use the descriptor
map since you no longer have to decode the integer value for the sampler.
Instead, it closely matches the expression in the specified samplermap
input file.

Passed private review.


Subdocs

Is there any plan to support yjs’s sub docs feature? It’a useful to develop a notes app (like the official example, use folder as root document).
https://docs.yjs.dev/api/subdocuments

hey @ImSingee, supports for subdocuments is planned, but probably towards the end of the year. We haven't started on this yet, so feel free to help if you can :-)

👍  let me know if you wanna discuss on Discord, I have some idea already (not sure if it would work though). There is also an idea here (not for hocuspocus, but it kinda shows the idea): https://discuss.yjs.dev/t/multiple-room-sync-subdocument/403/4

Hi any updates on this?

Hi @janthurau are there any updates on this 🙋

I'm also interested, what's the state? I currently have to deciding on whether or not to use this package.. for my application I have to work with subdocuments (or a similar connect, because of granular permission) and as far as I understand it it's not supported right now, or is it?