Initial attempt at words

Pls excuse me I think the words are still wrong, but wanted to get this up for discussion

There should probably be examples of what the versions look like for snapshot and RC


Question: replacement for ingress controller or rather complementing it?

So I was thinking (based on how you use it internally) if the instances from the operator may be used as ingress controller(s).
Due to the fact that Backend crd does not have properties that bind it to k8s Services directly, would you still use it as ingress controller and set domains svc.namespace.cluster.domain or the use-case is that the haproxy instances here act as "regular" cluster services?

hi @mike-code
it can and is used as ingress controller and was designed with this puprose in mind. the backend server can by any host, regardless of whether it's an internal service or and external one.
cheers, andy


shadowroot has been depricated need to update with shadowrootmode in template element

In Declarative shadow dom (DSD) shadowroot has been depricated need to update with shadowrootmode.
Reference :- https://chromestatus.com/feature/6239658726391808

MR for fix :- https://github.com/Wildhoney/ReactShadow/pull/156
@Wildhoney  Please Review and Merge this.

Fix has been merged in master. closing this.


Non-ascii chars in "-e", and a project that uses youtube-dl

Hello youtube-dl people,
I've been using youtube-dl heavily in this project:
http://angg.twu.net/youtube-db/README.html
http://angg.twu.net/linkdasruas2.html
It uses very few features of youtube-dl, but calls it on thousands of videos.
Right now the only bug that I have to report - that has been around for months without disappearing with "youtube-dl -U" - is that I see no way to get the full titles of videos when they have latin-1 chars in
them. Doing this, for example,
youtube-dl -e "http://www.youtube.com/watch?v=n72B3zCOLU0"
outputs the first line below, instead of the second:
Tribunais secretos, prises, agresses, ameaas, crcere privado: Um Brasil sem direitos
Tribunais secretos, prisões, agressões, ameaças, cárcere privado: Um Brasil sem direitos
The non-ascii chars are dropped, in a way that seems to be somehow similar to what this does:
youtube-dl -t -f 18 --restrict-filenames 'http://www.youtube.com/watch?v=n72B3zCOLU0'
I do have some wishlist items for youtube-dl, though... Most of them would be easier to tell by chat, because I know very little Python and very little about Windows, so I would have to try to translate my
knowledge of other languages and *NIX into something viable, and that would be easier to do in real-time dialog than by bug reports and e-mails... Do any of the developers drop by the #youtube-dl channel at Freenode? When? That would be a great place to chat - but if not I can try to post my ideas here or elsewhere, too. What do you recommend?
Cheers and thanks =),
Eduardo Ochs
<EMAIL_ADDRESS>http://angg.twu.net/

@edrx has not responded regarding whether the problem was associated with his terminal, as @juancri suggested. Plus, it's been more than four years. So, this issue seems like it can be closed.


Agile chart endlessly expanding

Hello,
We have Agile PRO plugin v1.4.8 and PurpleMine2 v2.0.1 installed and getting endlessly expanding Agile chart if we open it from Agile board.
Chart is opening fine in other themes.

Details:
Environment:
  Redmine version                4.0.0.stable
  Ruby version                   2.3.3-p222 (2016-11-21) [x86_64-linux-gnu]
  Rails version                  5.2.2
  Environment                    production
  Database adapter               Mysql2
  Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
  Mailer delivery                smtp
SCM:
  Git                            2.11.0
  Filesystem
Redmine plugins:
  additionals                    2.0.20
  clipboard_image_paste          1.13
  redmine_agile                  1.4.8
  redmine_checklists             3.1.14
  redmine_favorite_projects      2.0.3
  redmine_percent_done           1.1.0
  redmine_theme_changer          0.4.0
  redmineup_tags                 2.0.4

I'm trying to replicate this but I can't, the chart has fixed height of 400px. Any idea if this is only possible in the pro version? I don't know why would it be expanding.
Also, I noticed the footer ends up being on the right side but this is because the markup is different on the chart page.

I pushed some improvements to master, see if that changes anything?
If not, can you also try building the theme with $css-grid-layout: true?

It looks like I found the root cause.
The issue is caused by Additionals plugin with Add "Go to top" link option enabled.
Once I disable it everything starts working as expected.
PS. Thanks for the great theme!

What a weird bug!
So there's a number of issues and potential "fixes here". I decided to go with the simplest one, which is to hide the "Go to top" link.
I also replicated the issue with the default theme, but it doesn't expand by itself, only when you resize the window.
The real issue here is the broken markup which causes the link to be injected in the wrong place. The reason why the endless expanding occurs with PurpleMine is that #main has position: relative required for the sidebar toggle button, and that affects Chart.js' hidden iframe's dimensions, and that is used to calculate the size of the chart. Another fix I came up with was to apply .chartjs-hidden-iframe { height: 100vh !important; } which basically restores the desired behaviour of this element from the default theme and stops the chart from expanding on its own but the issue remains when resizing the window.
Please see issue-93-agile-chart-endlessly-expanding if you're happy with the fix.

Confirmed working, thanks a lot!


Request: Enforce main domain for environment

I would love a way to enforce a main domain for an environment where you have multiple domains connected, eg. domain.com and www.domain.com.
Before, I handled this in .htaccess, but I feel that this requires a unnecessary performance hit, however small.
Do you think this would be something that fits within the realm of Patrol?
I'm currently using Hearty to handle environments.

I've considered that and I think it does fall within the scope of what could be handled via Patrol.
You mentioned a performance hit and I think that if you can handle it at the server level or even .htaccess, you should. However, Patrol was created out of necessity and for convenience, either because on a shared host you don't have as much freedom or because it makes it easier to enforce  rules during development. So, I think I'd like to explore your feature request and try add it when I get the chance;)

@sjelfull What UI/options do you think this feature should include?
Should it just allow you to select www or Naked Domain enforcement?

I guess this is as much out of convenience as out of care for the performance.
I think you should be able to define what your main domain is, if that's what you you mean by Naked Domain.
The use case I have in mind at the moment is a site where we used a temp. subdomain provided by the host while we were preparing to launch.
After launch, the site is still available from the subdomain, and some of the staff of the client is still using domain. That leads to some instances where it leaks into search results and cache.
I would like a easy way to enforce it, so that it doesn't matter if not all do as instructed.

@sjelfull So, let me see if I understand this right. Please correct me if I'm wrong.
You might have a local domain like local.dev and a temporary domain during development as your staging domain, something like temp.domain.com for example.
Your production will be domain.com when you go live but temp.domain.com will remain available for people/admins/bots to access. So, what you want is to be able to force everyone to domain.com instead of temp.domain.com.
I've decided to make this a feature, so if you can just add clarification on your use case, that will be really helpful.

Thanks, that's exactly what i'm after.

@sjelfull Here is what I'm thinking...
To add a new setting called primaryDomain that can only be set through config/general.php.
If primaryDomain is set to a non-empty string (like local.dev or temp.domain.com) and the current domain does not match, we redirect to that domain.
That would mean that if you have a multi-environment config set up, you could:
return [
  // all
   '*' => [
    'patrol' => [
      'primaryDomain' => 'domain.com'
    ],
  ],
  // local
  '.dev' => [
    'patrol' => [
      'primaryDomain' => '' // or local.dev
    ],
  ],
];

This would work independently from SSL of course. Thoughts?

@sjelfull I've gone ahead and implemented this feature. Would you be able to test things out and provide some feedback? I'd like to clean up or fix any small bugs (if any) before cutting an official release.
All you have to do is updated your config file with something like this:
return [
  // all
   '*' => [
    'patrol' => [
      'primaryDomain' => 'domain.com'
    ],
  ],
  // local
  '.dev' => [
    'patrol' => [
      'primaryDomain' => '*'
    ],
  ],
];

Looks great. I'm on holidays currently, so probably won't be able to test it out before the 25th.

@sjelfull Ok, release https://github.com/selvinortiz/craft.patrol/releases/tag/v1.4.1 should do what you want:)


Feature Request: Additional ControlNet functionality

Describe the feature you'd like to see:

multi-controlnet
ability to specify mask

Additional information
No response

This is (mostly) a duplicate of #103. With the addition of the potential for masking.


Parallelization of page rendering and file copying

This MR makes page rendering as well as file copying concurrent.
Here are before and after benchmark results:
$ go test -bench=Benchmark ./generator/
goos: linux
goarch: amd64
pkg: github.com/klingtnet/static-site-generator/generator
cpu: AMD Ryzen 7 3700X 8-Core Processor
BenchmarkGenerator-16                     5     236295289 ns/op
BenchmarkCopyStaticFiles-16               1<PHONE_NUMBER> ns/op
PASS
ok      github.com/klingtnet/static-site-generator/generator    4.275s
$ git switch master
Switched to branch 'master'
Your branch is up to date with 'origin/master'.
$ go test -bench=Benchmark ./generator/
goos: linux
goarch: amd64
pkg: github.com/klingtnet/static-site-generator/generator
cpu: AMD Ryzen 7 3700X 8-Core Processor
BenchmarkGenerator-16                     1<PHONE_NUMBER> ns/op
BenchmarkCopyStaticFiles-16               1<PHONE_NUMBER> ns/op
PASS
ok      github.com/klingtnet/static-site-generator/generator    2.663s

Note that the BenchmarkCopyStaticFiles has not seen any speedup.  The benchmark itself may be the problem since it only uses in-memory storage, e.g. fstest.MapFS and the DiscardStorage.

Here are the latest benchmark results:
$ go test -bench=Bench -cpuprofile /tmp/cpu.prof ./generator/...
goos: linux
goarch: amd64
pkg: github.com/klingtnet/static-site-generator/generator
cpu: AMD Ryzen 7 3700X 8-Core Processor
BenchmarkGenerator/concurrency-1-16                    1<PHONE_NUMBER> ns/op
BenchmarkGenerator/concurrency-16-16                   5         213301941 ns/op
BenchmarkGenerator/concurrency-32-16                   5         206370845 ns/op
BenchmarkCopyStaticFiles/concurrency-1-16             20          54926660 ns/op
BenchmarkCopyStaticFiles/concurrency-16-16            31          37498046 ns/op
BenchmarkCopyStaticFiles/concurrency-32-16            31          37487949 ns/op
PASS
ok      github.com/klingtnet/static-site-generator/generator    11.203s
$ go tool pprof -png /tmp/cpu.prof
Generating report in profile001.png

I think it's fine to merge now and the CPU profile only has two hot paths, one for fstest (which is benchmark setup related) and the other one for template which we cannot do much about.


GA respecification of cm:bulk-publish:entry-edits command

@sachinkalecs Please resolve the conflicts

@sachinkalecs Please resolve the conflicts


[ENH] Rework _HeterogenousMetaEstimator and composable estimators

This is a bit big and messy, but a lot of these composable estimators are intertwined with the mixin which is to be expected really. Just went for a tidy of the whole lot.

renames _HeterogenousMetaEstimator to _ComposableEstimatorMixin
reworks the class, removing a lot of the methods and functions. Centres input validation around two methods, _check_estimators and _convert_estimators
the methods for getting and setting params/attributes should work as intended like the base class now
remade ClassifierChannelEnsemble to work with the changed mixin.
removes the deprecated WeightedEnsembleClassifier class
Adds tests to verify that expected results arrays are actually being used

part of #1518

have you checked coverage on the related classes? It was previously low

cant check currently


RSpec 2 plans

Hello,
Are there any plans to move DM from RSpec 1.x to RSpec 2.x?

RSpec 2.x doesn't yet support heckle, which is a mutation testing tool we use internally to verify the integrity of the code. IMHO the benefits of using it far outweigh any benefit we get from moving to RSpec2.
There is work to write a mutation tester in rubinius called mutant, and once that's ready we'll switch to using it instead of heckle, and then upgrade to RSpec 2 at the same time.

Thank you for the exhaustive answer. Looking forward to that.

One other thing, we may consider doing something like this if there's a demand: https://github.com/solnic/virtus/commit/1962fa0a36b36a4da6365b2e1896ecce77fefbee
Most of the syntax in RSpec 1 is forward compatible with RSpec 2, so it should be possible have one foot in each world.
While RSpec 2 is much faster than 1, we just haven't done this because when you factor in IO (which is where the bulk of the time is spent in DM's specs) those speed differences will probably have no measurable effect on the total time the specs take to run.
I suppose as we get closer to a full RSpec 2 switch we'll do this, and test it out for a few weeks before going all the way.

I tried to run the test suite with RSpec 2 by similar tweaks. Typically, it is not big deal to switch between RSpec 1 and 2, however, if you are using shared example, it complicates that matter, since shared examples is the biggest syntax change between RSpec 1 and 2 IMO.

The old shared spec syntax from RSpec 1 works in RSpec 2 (we use it a lot in virtus). However, the new syntax in RSpec 2 isn't supported.. I had to change a bunch of specs and shared specs to work with the lowest common denominator before that commit was made above.


Conditions cannot be added for minor amendment determinations -

@calebissharp  I think this was a previous miss on my part.  Not sure how much effort is involved here but it is lower priority.
DM should not be able to add comments in the review minor amendment status (not sure which number that is but it is where they select either stands, wrongly made or WMWE)

@LisaMoore1 Not too bad if it's just the one status that DM can't add conditions in.

Just the one I think. After staff have identified it as requiring review (the status from which the DM can select Stands, WM or WMWE)


Steam-powered platforms (platformer game)

http://scratch.mit.edu/projects/76528386/
http://phosphorus.github.io/#76528386
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36

this isn't just for this game, I was just using this game to test, but, there's no sound whatsoever in phosphorus games which makes it not such a good idea to use for games. It would be really good for me if you could include the sound. thanks
ollie

Phosphorus only plays sound in certain browsers, as some (like chrome) cannot decode the sound files.

oh. Thankyou for clearing this up. It would be useful if you could somehow
enable sound compatibility for chrome, as it is the most widely used
browser.
On Thu, Dec 22, 2016 at 1:34 PM, PortPixel<EMAIL_ADDRESS>wrote:

Phosphorus only plays sound in certain browsers, as some (like chrome)
cannot decode the sound files.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nathan/phosphorus/issues/733#issuecomment-268800340,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXkmEu1BLyXxlUVTrDlZA9yFrAGt4K7aks5rKnxVgaJpZM4LT-QX
.

It is not as easy as simply 'enabling' it, see #736

Sorry yeah I know that it's not that simple. I used the wrong word. I meant
to fix this issue by using a different way to play the sounds through the
browser. Also, It doesn't seem to work in IE either (at least win 7 IE) so
I thought that might be useful for you to know as you only before mentioned
chrome and firefox.
On Wed, Jan 11, 2017 at 8:20 PM, PortPixel<EMAIL_ADDRESS>wrote:

It is not as easy as simply 'enabling' it, see #736
https://github.com/nathan/phosphorus/issues/736
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nathan/phosphorus/issues/733#issuecomment-271982408,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXkmEi81Y-hATh-zgwWrf--tBpIFyZTjks5rRTl_gaJpZM4LT-QX
.


vcfToArchive.py needs a slight tweak

I have a PR coming for the reheadering which will fix the vcf reheadering. I am however getting this error:
[varscan.snp.genome.wustl.edu.TCGA-W5-AA33.vcf] VCF header validation error: SAMPLE header value '<"--min-coverage 8 --min-coverage-normal 8 --min-coverage-tumor 6 --min-var-freq 0.1 --min-freq-for-hom 0.75 --normal-purity 1.0 --tumor-purity 1.0 --p-value 0.99 --somatic-p-value 0.05">' for key 'softwareParam' contains whitespace and must be enclosed in double quotes	[archive ucsc.edu_BRCA.Multicenter_mutation_calling_MC3.Level_<IP_ADDRESS>]

I believe the reason this is complaining is because the validator is expecting this format (as quoted from the TCGA format guide:
"If multiple software parameters are defined, comma-separated list of paramName=paramValue pairs should be used."
This becomes incompatible with line 124 in vcfToArchive.py:
params = dict(item.split("=") for item in sampleLine.split(","))

Writing the software params as --param paramValue does not bother vcfProcessLog, but is more picky for the softwareParam portion.

Can you give me an example of the actual input line you're trying to parse?
Or, even better, email a complete VCF header so I can test?
Thanks!

More details (from email thread):
TCGA would like softwareParams in this format:
##vcfProcessLog=<InputVCF=</home/jac/galaxy/galaxy_og/database/files/000/dataset_309.dat>, InputVCFSource=,InputVCFVer=<4.1>, InputVCFParam=<"min-coverage=8,min-coverage-normal=8,min-coverage-tumor=6,min-var-freq=0.1,min-freq-for-hom=0.75,normal-purity=1.0,tumor-purity=1.0,p-value=0.99,somatic-p-value=0.05">>
##SAMPLE=<ID=PRIMARY,Description="Primary Tumor",SampleUUID=f23b3d0d-26a5-4adf-8aec-4994d094465b,SampleTCGABarcode=TCGA-W5-AA33-01A-11D-A417-09,AnalysisUUID=cd5d8895-6b13-450f-993b-bff9943dc0d9,File="9a6ebf433eb4bcb93be593f74ffa1d3b.bam",Platform="Illumina",Source="dbGAP",Accession="dbGaP",softwareName=,softwareVer=<2.4.0>,softwareParam=<"min-coverage=8,min-coverage-normal=8,min-coverage-tumor=6,min-var-freq=0.1,min-freq-for-hom=0.75,normal-purity=1.0,tumor-purity=1.0,p-value=0.99,somatic-p-value=0.05">>
##SAMPLE=<ID=NORMAL,Description="Normal sample",SampleUUID=02e2d8b9-8b5a-4bae-8615-76c46d68f44c,SampleTCGABarcode=TCGA-W5-AA33-10A-01D-A41A-09,AnalysisUUID=3118c963-8446-4d4a-8146-6d46f1465780,File="741377430d1d6a7a567f5425abc41ac2.bam",Platform="Illumina",Source="dbGAP",Accession="dbGaP",softwareName=,softwareVer=<2.4.0>,softwareParam=<"min-coverage=8,min-coverage-normal=8,min-coverage-tumor=6,min-var-freq=0.1,min-freq-for-hom=0.75,normal-purity=1.0,tumor-purity=1.0,p-value=0.99,somatic-p-value=0.05">>
If you run the runArchiveCreateScript.sh it produces this error:
Traceback (most recent call last):
File "/home/jac/mc3/scripts/vcfToArchive.py", line 423, in
main()
File "/home/jac/mc3/scripts/vcfToArchive.py", line 388, in main
sdrfObjectList = sdrfFromVcf(os.path.join(patient, vcfFile), outData)
File "/home/jac/mc3/scripts/vcfToArchive.py", line 207, in sdrfFromVcf
mySDRF = SDRF(line)	# create SDRF object
File "/home/jac/mc3/scripts/vcfToArchive.py", line 96, in init
self.sampleSDRF(fromSample)
File "/home/jac/mc3/scripts/vcfToArchive.py", line 124, in sampleSDRF
params = dict(item.split("=") for item in sampleLine.split(","))
ValueError: dictionary update sequence element #11 has length 3; 2 is required


embed the video on the 'doc' page itself

Stumbling upon this page https://dvc.org/doc/understanding-dvc/resources.

The links look like a static image. And, also upon clicking on the image, we are redirecting to YouTube page.
We can embed the video on the DVC page itself, rather than opening a new target.
It will impact user browsing experience.

@ryokugyu sounds good! I would also improve the formatting a little bit - use table for videos? or move titles above videos to improve readability.

I will suggest:

Position the video in the middle of the page. Something like,

- If we embed the video from YouTube itself, no need to add titles. Still, if anyone wants to add title, it must be in .
- And most importantly, if any links from outside the website, please set _target=blank.


Add in 2nd param for filters slider

Adding another 'bump' in the filter from the top side to narrow the filtering between the two numbers. This will allow more refinement.

@micksabox assigning to your ser

yes! this is exactly what I was thinking
min - max should always be selected to begin with then the user adjusts

These should exist on all sliders so you can narrow the range

Moving to Review / QA


[v2.5] Correctly scope token generated by DatastoreService to the user which ran the action

This pull request fixes a bug reported in #3823.
The code incorrectly scoped the auth token which is available inside action service to Python runner actions to action_service user instead of to the user which ran the action.
This regression has been there for a quite a while since datastore service was refactored so it can also be used by sensors.
This change is only meant for v2.5.1 in case we decide to release it. It has been supersede by https://github.com/StackStorm/st2/pull/3803 for master / 2.6.0.
#3803 has a proper fix which is to use a temporary auth token which is generated by the action runner container for the duration of the action life-time and is correctly scoped to the user who ran the action (or stanley for actions kicked by the rules, etc.). That is in fact what we already did in the past at some point, but it got overwritten with some other changes in the past.
The temporary auth token has been designed especially for that purpose and has many benefits. One of the benefits is that this token is only active / valid for the duration of the action life-time. The token which is / was generated inside DatastoreService is valid until it expires (by default TTL is 24 hours) which is obviously not great.
TODO

[ ] Changelog entry

Merged directly into #3840 - closing.


How do we add proxy to embedded-redis test container?

I would like to understand how can we add http/https proxy to embedded-redis test container. I do not see any provision in bootstrap.yml. I am using version 1.82

what do you mean under http/https proxy, please specify your use case.

The use case is how can we run test containers behind company proxy.  As an example is there a possibility to add environment variables as  HTTP_PROXY/HTTPS_PROXY in embedded redis test container? As far as I have seen in the code it does not allow. So is this a viable option to allow these two properties to be added or is there any other option that we can utilize. Thank you for your help.
GenericContainer container = new GenericContainer("..."))
.withEnv("HTTP_PROXY", "http://<IP_ADDRESS>:3001")
.withEnv("HTTPS_PROXY", "http://<IP_ADDRESS>:3001");

every embedded container should support setting env variable via spring properties

please try to set it for redis container, hopefully it will help.


[0.71] Hermes version is rc.2 when it should be rc.3 on iOS

Description
Hermes version is reported to be 0.71-rc.2 while react-native version is 0.71-rc.3. Note that this only happens on iOS. The version on Android seems correct.

iOS
Android

Version
0.71-rc.3
Output of npx react-native info
System:
    OS: macOS 12.6.1
    CPU: (10) arm64 Apple M1 Max
    Memory: 2.06 GB / 64.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.18.1 - ~/.local/bin/node
    Yarn: 3.1.1 - /opt/homebrew/bin/yarn
    npm: 8.11.0 - ~/Source/react-native-test-app/node_modules/.bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.11.3 - /Users/tido/.gem/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 21.4, iOS 16.0, macOS 12.3, tvOS 16.0, watchOS 9.0
    Android SDK:
      API Levels: 31, 33
      Build Tools: 30.0.3, 31.0.0, 33.0.0
      System Images: android-33 | Google APIs ARM 64 v8a
      Android NDK: Not Found
  IDEs:
    Android Studio: 2021.2 AI-212.5712.43.2112.8815526
    Xcode: 14.0.1/14A400 - /usr/bin/xcodebuild
  Languages:
    Java: <IP_ADDRESS> - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: 10.0.0-alpha.5 => 10.0.0-alpha.5
    react: 18.2.0 => 18.2.0
    react-native: 0.71.0-rc.3 => 0.71.0-rc.3
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce
Clone the repo and checkout the branch below. Then run the following:
npm run set-react-version 0.71
yarn
cd example
sed -i '' 's/:hermes_enabled => false/:hermes_enabled => true/' ios/Podfile
pod install --project-directory=ios
yarn ios

Snack, code example, screenshot, or link to a repository
https://github.com/microsoft/react-native-test-app/pull/1199

Closing this as it seems to be fixed in rc.5


(Inability to resolve) instability due to partition by high-cardinality field

Java 1.7.0_60
Crate 0.45.7
We're proving out some use-cases for potentially deploying Crate in production, and could use some guidance for properly configuring the cluster to prevent or contain problematic queries. Below is an example of us getting into some trouble, and not really knowing how to get out of it without interrupting the service.

crash: create partitioned table called tmessages_part – partitioned by a high-cardinality field
crash: insert into the partitioned table by selecting data from another large table
Thousands of partitions created seemingly endlessly, cluster responses intermittently lagging as a result (UI timing out regularly, then returning to warning state due to unallocated partitions for new indices)
“Ctrl-c” within crash in an attempt to kill the insert statement
Background process(es) still continuing to create partitions/indices
crash: drop table tmessages_part;
Partitions continue to be created, though now without aliases as viewed through the Head plugin. Table and partition data now missing in information_schema.
crash: delete from tmessages_part – didn’t do anything
Let it run for a while (20-30 minutes) with a drop index loop against ES directly for cleanup, to see if it would "finish"
Shut down the cluster
On startup, lots of [io.crate.metadata.shard.ShardReferenceResolver] Orphaned partition '[.partitioned.tmessages_part.0466it31ekn66rrd5ph74]' with missing table 'tmessages_part' found
Cluster status yellow and replicating, and number of shards/indices constant

hi @devoncrouse
we're sorry to hear about your problem!
the problem you are describing is due to the fact that you cannot abort a long running job yet once it has been dispatched, something that could also happen when you perform a large COPY FROM.
Using Ctrl-C in the crash does only interrupt the HTTP request, but does not cancel the job.
Unfortunately, right now, restarting the cluster - with all its problems - is the only way to cancel such a task. We've a feature in our backlog to tackle this problem!
however, I am a bit confused why you would use a table partitioned by a high-cardinality field. the opposite (low-cardinality) really is how you wanna use partitions.
I guess, what you want is to use the user column for routing: CLUSTERED BY (user) to improve performance of lookups by user. see: https://crate.io/docs/en/latest/sql/ddl.html#routing
hope I could help!

I agree that the statement is misguided, but it's easy enough to do by accident; with the scale of data we're trying to index/store, we need to be able to contain something like that (in the same way we can kill MapReduce jobs through the JobTracker, for example), rather than forcing us to interrupt service and risk corrupting things. Hope to see some job control (or at least ACLs) in the future. Thanks!


Edit Multiple Flags Not Working

MacBook Pro (Retina, 13-inch, Late 2013)
macOS 10.14.06
Firefox v81.0.2 (64-bit)
Selecting 2 transactions in active ledger with today's date at 10:15pm MDT, clicking Edit, the pulldown menu does not show Add Flags or Remove Flags. Toolkit is active and settings saved.  I've used this Feature a number of times, but not in the past few days.

I came here to report the same.
Windows 10 Pro 64-bit
Firefox 81.0.2 (64-bit)

Likewise here, current versions of Chrome on both Windows 7 and 10.  Guessing another YNAB update break (they seemed to have redesigned the menus)

Same issue here!

Thank you, @joshmadewell, for all your great (and kind) work on this! I am just one of I imagine many who are thankful for what the Toolkit allows us to do in YNAB, so with all of these "Issues" we/I just want to also say, "Thank you so much!" 😊 👏🏻

Hey @Y-NWG the fix for this should be in our current release! If you notice the issue still exists and you're definitely running the newest version of the toolkit, please reopen! Thanks!
Please note, all browser can take up to an hour to provide updates to all users. You can force an update if it's available for you by going to chrome://extensions and clicking the "Update" button. Firefox users can go to about:addons, click the setting cog, and click "Check for updates...".

@calebweeks Thanks for the kind words :D


fix typo

Slash Commands was being spelt as Slach Commands, so fixed that up, then regenerated the PDF and the PNGs (now as individual pngs).

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Remove input files argument to target

Description
These are not really useful and mostly clutters up the API. Was only used by linux and windows copy rules, that was replaced with the artifact source.

Accidentally merged this (rolled back), don't talk and type!


Failing upon require

<EMAIL_ADDRESS>The package fails out of the box - dist/index.js is not a part of the package:

oh, btw - same error for import

Hi @osher this is indeed a problem, we need to adjust the package.json to use the Client.js as default s.
  "main": "dist/Client.js",
  "types": "dist/Client.d.ts",

in previous version we had an index.js file but this is gone since we have changed our tsconfig.


Add $project and $unset to aggregation stages section

Added $project and $unset commands to the Aggregation Stages list and gave them a description.
Closes #3428.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Akhaled19 please click CLA button in this comment

Hi, I resolved all the comments. Is it ready to be merged?


ng-show sometimes does not remove ng-hide class after expression becames truthy

I've noticed that in my application ng-show sometimes leaves ng-hide class even after ng-show expression evaluates to true.
This behavior is not consistent across browsers: In places where I see issues  on Chrome it looks fine on FF, while in other place the situation is opposite.
Even if I retry the same scenario on a single browser, the defect does not occur every time, so this must be some non-deterministic timing issue.
Scenario & recreation
I've tried to isolate the problem and stripped my app to this simple plunker:
http://plnkr.co/edit/pNUXB6A0gCyfdej8k5Xu?p=preview
I am able to recreate the issue there with my FF ESR 38.4.0, but not every time.
I'm clicking the button and if the modal appears with both lines of text I need to click Stop/Run in Plunker and try again, for several times. My teammate who is using exactly the same FF version cannot recreate it at all.
Some more observations:

Manually changing scope.loadedData (the watched expression there) to a falsy value and then back to the original value causes the div to show up.
Calling scope.$digest() manually does not help
replacing ng-show with additional condition in ngClass ('ng-hide': !loadedData) does not help either
using ng-if instead of ng-show works fine
debugging reveals that ng-show directive's watch is triggered properly. It calls $animate to remove ng-hide class, but it doesn't take effect.
ng-show alone works fine, the issue occurs on the element which has both ng-show and ng-class directives

Affected versions
This is a regression introduced in Angular 1.4.0 (recreated this defect on 1.4.0, 1.4.7, 1.4.8 and 1.5.0-beta.2, but It did not occur on 1.3.20)

I observe the same, especially: ng-show alone works fine, the issue occurs on the element which has both ng-show and ng-class directives
A by-pass could then be to let ng-show alone on a div containing the div with ng-class.

Interesting bug. It ultimately seems to be caused by an interplay of the modal directive and the way ngAnimate handles consecutive animations on the same element. In my tests, the problem will only occur the first time you open the modal. The request for the modal template (details.html) seems to cause a timing issue in some cases, but not always, which causes ngAnimate to join the addClass and removeClass animations, because the addClass animation is still cached on the object.
As a workaround, you can try to put your modal templates into the $templateCache when your application runs. There are grunt plugins for that for example: https://github.com/karlgoldstein/grunt-html2js

I confirm that I was able to recreate in plunker only on the first time. Further attempts of opening modal always work as expected.
On the other hand, in my application where I first noticed this issue it works differently. I can open one of my modals multiple times (without reloading the page) and the issue still occurs.
Maybe I have removed something relevant to the case when isolating the problem into plunker.
Thanks for suggesting grunt-html2js, I'll give it a try.
I don't expect it to fix the issue in my original case (as noted above, it is not only a matter of first modal appearance), but it looks like a reasonable performance improvement anyway.

It would still be interesting if you could create a repro where it fails every time, since we have to create a test for this problem, and it's difficult if there's no 100% repro.
Do you make a network request for the template every time the modal opens or just the first time? Maybe there's more going on in your application at the moment the modal opens?

I don't do anything explicitly in my app to fetch the template every time, so the default angular behavior works there - template is fetched only on the first time and cached afterwards. I've just double checked that in Firebug console.
I do however fetch some additional data via $http request to my REST service in the beginning of my modal controller. The fetched data is then assigned to scope variables which are used in modal template. One of those variables is used in ng-show condition, which is supposed display part of the modal only after data has been fetched.
In the provided plunker I tried to simulate that $http request with a $timeout which assigns value to $scope.loadedData.

I made a small update to the plunker: changed delay in $timeout from 50 ms to 0ms. Now it is 100% recreatable:
http://plnkr.co/edit/vWqR5G1AHE38s4D1rI7Z?p=preview
This time the first appearance of modal works fine (scope variables is updated before template gets fetched) but every further attempt is affected by the defect.

I have patched angular-animate.js locally with commit  5713231 and it also fixes the issue in my application. :+1:

Good stuff! We'll have to double-check if that isn't breaking other stuff. I totally read over the fact that this is mainly a FF issue. Seems to be an implementation issue with how a requestAnimationFrame is triggered.

It's not only a FF issue. It seems to be very tricky with browsers.
The original issue found in my app was observable in Chrome only. Then I tried to isolate a test case and created the plunker example.. and to my surprise I was able to recreate the issue with plunker on FF only.
So it seems that the issue affects different browsers, depending on case. However the root cause seems to be the same, because your fix also fixes the issue I observed in my app on Chrome.

I think I experienced exactly this bug using the following setup:
ionic 1.2.1-nightly-1867 (ionic 1.2.1)
angular 1.4.3
angular-animate 1.4.3
it's 100% reproducible in Chrome/Android and Chrome/Windows in a a timeout-scenario but not reproducible at all without timeout.
Using ng-if instead seems to solve the bug.

@jakub-g This should be fixed in latest 1.4 (1.4.9). You are using an outdated version. If the problem persists in the new version, please open a new issue.


Dynasm all the vregs

This merges the LuaJIT updates from https://github.com/eugeneia/snabbswitch/commits/esp into next.  The PR is based on master. Cc @eugeneia.

Unfortunately I am still not able to use ymm(n) for n >= 8 on this branch.  Perhaps @corsix knows what commits I'm missing.  I did the merge with --strategy=subtree.
The error:
dasm error: variable register out of range. :40

I think you ran into the same issue as I did: You merged the LuaJIT patches but left the Snabb-DynASM-bridge (snabbswitch/src/dasm_*) untouched. @capr is in the process of updating the latter. See https://github.com/eugeneia/snabbswitch/pull/8#issuecomment-169983464

OK :) I'll follow @capr's work and close this branch if it's eventually unneeded.

FWIW manually examined the DynASM changes and copied them into the Lua DynASM.  This branch seems to work for me.

Cc @capr -- should I submit a patch to your DynASM repo?

Pretty sure the failing build is a failure of the bot (stale checkout).  I think this one is good to go.  Been using it in https://github.com/Igalia/snabbswitch/pull/204.

Re: failing build. I agree but I can't really tell why it happens (repeatedl)y for this PR.

The compile error is due to luajit/luajit#126. The workaround is to make clean (or git clean with suitable args). Just have to accept this. (Perhaps our Makefile could somehow suggest a make clean if the build of a dependency fails.)
Looks like @eugeneia already did the git subtree pull and I needn't have bothered with #715.

@eugeneia next step is you merge this onto max-next?


SSH Permission issue

After following the steps outlined, I am having issues with the permissions for ssh. I've done everything else that works with git but it seems to have an issue with beta.aptible.com
Is there a way to resolve this? Thank you

Please see the git Push Permission Denied troubleshooting documentation for help with this issue. If you need additional assistance or have any other questions regarding the usage of the Aptible platform I recommend posting in the Aptible Community or contacting Aptible Support as these channels are more appropriate for such questions and are monitored more closely than GitHub issues.


The viewid is missing

The code at https://github.com/apitable/widget-airtable-import/blob/main/src/apis/get-records.ts#L15 does not consider the view id.
Hower the help guide mentions about it and it might be the reason why importing from Airtable is broken.

Building from the latest develop branch actually solves.
The bug seems to have been resolved in some recent commit :+1:


It should be possible to choose the file name while saving on the desktop app.

When saving the file it is possible to choose the target directory but it is not possible to choose the file name. The result of the save action is always the creation of the files manifest.xml and manuscript.xml.
I'm using the version 1.0.0-preview.1 (1.0.0-preview.1) on MacOS High Sierra.

We store .dar files now.


fix(Dropdown): pass custom window to Downshift

https://github.com/downshift-js/downshift/pull/755
Can be merged without the Downshift fix.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


Revert "http: adding content length validation (#1121)"

This reverts commit b643ac8d5c4cbb9f8996701cecb5512596de68d0.

@alyssawilk we need to revert this. I think the change is not compliant for HTTP/1.1:
https://tools.ietf.org/html/rfc7230#section-3.3.2
"For example, a Content-Length header
field is normally sent in a POST request even when the value is 0
(indicating an empty payload body)"
The change rejects POST/PUT even if content-length: 0 is sent AFAICT. I'm just reverting the entire change and you can re-apply after looking at it.


Feature request: helm init --wait

It's now possible in 2.2.x to use the --wait flag to wait for deploys to be ready which is a great addition especially for various CI/CD scenarios.
How feasible would it be to add the same to helm init with reference specifically to Tiller and it being ready to serve? Same premise as waiting for Charts to be ready but with Tiller itself to be installed/upgraded.

Seems like a good idea to me.

+1. This will likely help us with writing e2e tests and automation as well.

+1. In the meantime, here's a workaround:
$ helm init; kubectl rollout status -w deployment/tiller-deploy --namespace=kube-system;
$HELM_HOME has been configured at /home/petko/.helm.

Tiller (the helm server side component) has been installed into your Kubernetes Cluster.
Happy Helming!
Waiting for rollout to finish: 0 of 1 updated replicas are available...
deployment "tiller-deploy" successfully rolled out

@technosophos I would like to work on this.


Support for const ("side-effect free") methods

It would be great if there was a way to assert const-ness (in the C++ sense) on methods. Right now type guards can require local variables because repeated calls to the same functions aren't assumed to have the same return value. Example:
class Foo {
    #num: number|null;

    constructor(n: number|null) {
        this.#num = n;
    }

    /* const */ getNum(): number|null {
        return this.#num;
    }

    /* non-const */ setNum(n: number|null): void {
        this.#num = n;
    }
}

const f = new Foo(null);
const n = f.getNum(); // have to create temporary variable
const s = n !== null ? n : 'str';

I'd like to be able to write the following with the type of s still inferred as string | number:
class Foo {
    #num: number|null;

    constructor(n: number|null) {
        this.#num = n;
    }

    /* const */ getNum(): number|null {
        return this.#num;
    }

    /* non-const */ setNum(n: number|null): void {
        this.#num = n;
    }
}

const f = new Foo(null);
const s = f.getNum() !== null ? f.getNum() : 'str';

Hmm. It's a hard feature. But we will think about the solution for the feature request.
Thank you for contribution ^_^

If it's a constant, why not just use a readonly class property/getter?
class Foo {
  constructor(private readonly num: number | null) {}
  get num2() {
    return this.num
  }
  readonly num3 = this.num
}

@raveclassic The getter is const ("pure"). I don't think this should be constraint to read-only data structures, that's a separate (but also worthwhile) target.

I still don't get the point of a "pure" method without arguments. If it's really pure, has no implicit dependencies, has no side-effects, then its return value is always a const. Then it may be replaced by a constant (class-property).
getNum() in your example is not pure because it references a mutable value outside of its scope, it's a side-effect:
const foo = new Foo(1);
foo.getNum(); // 1
foo.setNum(2);
foo.getNum(); // 2 - wtf, if it's pure, it should be 1

The above example is the very reason why TS/flow require to check result of each method invocation. That's why we have to store the result in a variable, because future calls may return different result.
We can't mark such method as const (pure) but we can however replace it with a readonly class property, which guarantees its value to be constant. (Even more my example with a getter is also not pure.).
OTOH if we'd really need a function (you have computation producing some value) and wanted it to be pure, we'd need to remove all implicit dependencies such as references to this. This would make it possible either to make such method static or (which is even better IMO) to move it to the module level in a form of a free top-level function.
I may be missing something, if so please feel free to correct me.

I still don't get the point of a "pure" method without arguments.

I'm not sure I follow. My example doesn't have any functions without arguments. Maybe what's confusing you is that in JavaScript, functions take an implicit this argument that's not part of the parenthesis. So your code example would be:
const foo = new Foo(1);
foo.getNum.call(foo);
foo.setNum.call(foo, 2);
foo.getNum.call(foo);

I don't quite understand why you'd want to remove this. You'd end up with the exact same problem, just that it's now necessary to track effects on arguments ("mutates arguments in general"):
let foo = { num: 1 };
function getNum(context) { return context.n; }
function setNum(context, value) { context.num = value; }
getNum(foo);
setNum(foo, 2);
getNum(foo);

These are play examples of course. The assumption is that the code has good reasons to use a class.
The other misconception is that you took const with a deliberate pure in quotes and read it as pure. In the very first sentence of this issue I tried to scope this to a very specific subset of "effect": const in the C++ sense. I don't think a language that tries to look like JS can use "pure" in a meaningful way since it has way too much baggage.
Generally speaking, this isn't really a novel proposal. Analyzing effects, ordering operations, checkpoints, etc. are fairly common problems. And determining what effects if any a function has is absolutely possible and done for JavaScript in multiple tools. This case is one of the simpler ones because it's self-contained (only effects on this involved, no effects at all in the const method). Tools like closure compiler (disclosure: I'm working on a sibling team to them) also have annotated versions of platform and language APIs (via https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#nosideeffects-modifies-thisarguments) that could be leveraged in that analysis. That it's even possible to do this determination when calling into built-ins like this.myMap.has('foo') (code).

@jkrems Ooookaaay.... Thanks for the explanation. I've read a bit about C++ const functions. As far as I understood const on a class method should disallow any mutation of the instance of that class inside that method, right? What about free top-level const functions, should any kind of mutation in the outer scope be disallowed?
If so, it could be a good addition to static checking.

Effects beyond arguments and/or this start to become more and more tricky to model and track. So I’d personally ignore anything that’s not lexical at the beginning. E.g. my example above uses private fields because they are known to only be exposed to that exact lexical scope.


Contributing file

Is there anything we should edit with this file?

Feel free to reopen this issue if you think that there is something missing.


Python 3 this repo...

I thought I had done this, but apparently not. Get this into Python 3 asap!

Closed with https://github.com/exponential-decay/skeleton-test-suite-generator/pull/16


Add RunVirtctlCommand function

Signed-off-by: Guohua Ouyang<EMAIL_ADDRESS>What this PR does / why we need it:
Add RunVirtctlCommand function, so it can be used to add tests like start/stop VM via this function.
Release note:
NONE

Add RunVirtctlCommand function, so it can be used to add tests like start/stop VM via this function.

As far as I know we already have tests for that. If something is missing, it should be possible to just add more. For instance have a look at https://github.com/kubevirt/kubevirt/blob/master/tests/vm_test.go#L435.

Some more thoughts is both RunVirtctlCommand  and NewRepeatableVirtctlCommand can start/stop vm, but the former is calling the real virtctl binary, which looks like a more e2e test.

Hello contributor, thanks for submitting a PR for this project!
I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.
In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

Type ci test please on this PR to trigger automated tests for it.
Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically.
If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

M tests/utils.go The command "if [[ -n "$(git status --porcelain)" ]] ; then echo "It seems like you need to runmake generate. Please run it and commit the changes"; git status --porcelain; false; fi" exited with 1.
Please run make and commit again.

@gouyang https://github.com/kubevirt/kubevirt/pull/1408 does some generalization on command run, will it satisfy you?

#1408 does some generalization on command run, will it satisfy you?

I'm okay with that change, so I can close this one.


update condition for latest code availability

current_version is 40 and latest channel version is 39 so it's showing this udpate workbench message on top so condition is altered from not equal to to greater than

The logic here was correct, but the tag hadn't been created on GitHub, so the new version wasn't being recognized.


update: docusaurus config and upgrade version from 3.0.1 to 3.1

The search problem is fixed through algolia index configuration, by adding docusaurus_tag in attributesForFaceting. This PR is not needed anymore.


Support Greater than ~2GB file entries in GNU ar files

We already support ar files which are greater than 2GB but each entry/subfile must be less than 2GB.
Doing this requires rewriting the parser to create a multidimensional array of bytes because individual dimensions are limited to 2 billion. https://docs.microsoft.com/en-us/dotnet/api/system.array.length?view=netcore-3.1

It looks like MemoryStream is also limited to Int32 meaning that we will need to change FileEntry as well to make this happen. Renaming this to reflect that likely we can't handle any 2GB file.
https://docs.microsoft.com/en-us/dotnet/api/system.io.memorystream?view=netcore-3.1


Fix random

Moving #18 here.

Codecov Report

Merging #20 into fix-random will decrease coverage by -4.11%.
The diff coverage is 40%.

@@              Coverage Diff               @@
##           fix-random      #20      +/-   ##
==============================================
- Coverage        66.5%   62.39%   -4.11%
==============================================
  Files              17       18       +1
  Lines            1027     1117      +90
==============================================
+ Hits              683      697      +14
- Misses            344      420      +76

Impacted Files
Coverage Δ

Sources/Random/Random+Deprecated.swift
0% <0%> (ø)

Tests/RandomTests/RandomTests.swift
100% <100%> (ø)
:white_check_mark:

Tests/HMACTests/HMACTests.swift
100% <100%> (ø)
:white_check_mark:

Tests/BCryptTests/BCryptTests.swift
65.51% <100%> (ø)
:white_check_mark:

Tests/CipherTests/CipherTests.swift
100% <100%> (ø)
:white_check_mark:

Sources/Hash/Random.swift
100% <100%> (ø)
:white_check_mark:

Tests/HashTests/HashTests.swift
100% <100%> (ø)
:white_check_mark:

Sources/Random/CryptoRandom.swift
23.52% <13.33%> (-26.48%)
:x:

Sources/Random/Random.swift
42.85% <41.5%> (-1.59%)
:x:

Sources/Random/URandom.swift
66.66% <57.14%> (-33.34%)
:x:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aaa68b...c1b1edb. Read the comment docs.


HI, I want to delete some row but I can't

HI !
I want to delete the selected row ,  what should I do ,    Can I find some methods in API?
Many thanks

and this. delete select items , what should i do, only items

I always rely on deleting the data manually.  To actually delete data you just remove it from the grid.data.  E.g.: grid.data.splice(0, 1); will remove row index 0.  Since the grid can't tell that you've manipulated the data object it may be necessary to call grid.draw(); to update the drawing on the canvas.  For the second question, I imagine you want to delete the data in the cells you've selected when the user presses a key.  So bind an event listener to the key event grid.addEventListener('keyup', function (e) { ... });
In here you'll check what key was pressed by looking at e.keycode.  Check MDN for a more thorough explanation on listening for keystrokes (google "MDN keyup").
Once you detect the key you want to listen for (probably delete?) then you can remove the data from the selected matrix of data.  You can see the matrix by looking at grid.selections and iterate though the data removing the data from the cells you want empty.
grid.addEventListener('keyup', function (e) {
    if (e.keycode === 53) {
        grid.selections.forEach(function (selectedCells, rowIndex) {
            selectedCells.forEach(function (cellData, cellIndex){
                grid.data[rowIndex][cellIndex] = '';
            });
        })
    }
});

I did not test this, I don't know if it will work, but it will be something like this.  I don't know what keycode 53 is, you'll have to look up the keycode for the key you want to use.
You can also use the context menu built into the grid to add a delete option:
https://tonygermaneri.github.io/canvas-datagrid/docs/#canvasDatagrid#event:contextmenu
Same code, just without the keycode handler stuff.

If you have more questions on how to implement the grid you can join the slack channel by sending me your email.

many thaks


Support for query objects

Coming from NestJS, you have the ability to use serialized objects in query strings (described in Swagger as deepObjects), such as
/api/users?where[firstname]=john&where[lastname]=doe

// @Query('where') then contains
where: {
  firstname: "john",
  lastname: "doe"
}

/api/users?where[date][gte]=2022-05-17&where[date][lte]=2022-05-18

// @Query('where') then contains
where: {
  date: {
    gte: "2022-05-17",
    lte: "2022-05-18"
  }
}

Describe the solution you'd like
Currently, @Query decorator only supports simple strings, deep objects return undefined
/api/users?where[date][gte]=2022-05-17

// @Query('where') then contains
undefined

Seems to be a NextJS issue itself? Would be nice to have a more powerfurl @Query decorator to handle such use cases, any idea?

Indeed, Next.js doesn't have it built-in. However, Express.js (also NestJS, if you're using Express.js with it) makes use of the qs package for this functionality.
If you're using qs anyway, you can have it as a middleware to parse the query. Here is a middleware:
@UseMiddleware((req: NextApiRequest, _: NextApiResponse, next: NextFunction) => {
  req.query = parse(req.query as Record<string, any>) as typeof req.query;
  return next();
})

Types don't match but seems to work just fine.


Update termios.rs

B100000 does not exist in libc. Unfortunately there's no way to support that speed with the current limitations.


Fear the Repo Dead

16 open pulls, 45 open bugs, the last commit was on 2 Jun.
Is this repo still alive?

As this repo is declared unmaintained with dc326b9b9234ce964861eb35b416a6be1ca7d7cf what are the alternatives?

The alternative is, somebody takes it officially up. To avoid getting multiple splitted copies of this repo.

If someone else would join to create an "official" fork, I might help out, just don't want to do it myself.

What does "official" mean to you, @Remo?
This is my Fork. Let's merge these PRs to it.
I will start with mine #24.

@XmlmXmlmX  official in the sense that there's a link in this repo to the new repo where "everyone" is sending their pull requests.

What about the license. I'm an expert to this. Is Apache 2.0 still the best? Should/Could we change the license? Do we still need the hint Copyright 2014 Google Inc. All rights reserved.?

Unlike you I'm not an expert in that field, personally I'd suggest to go with MIT, but we'd have to ask the google guys first.

That's right @Remo. I will contact them.

Thanks!

Email send at 13:10 (MEZ) to @brendankenny and Luke Mahé.

Some additional info about license:

https://www.quora.com/Whats-the-different-between-Apache-v2-0-and-MIT-license
https://www.quora.com/Is-the-MIT-license-compatible-with-the-Apache-License-Version-2-APLv2
http://www.whitesourcesoftware.com/whitesource-blog/top-10-apache-license-questions-answered/?utm_source=quora&utm_medium=social&utm_term=blog-top-10-apache-license-questions-answered&utm_content=Is-the-MIT-license-compatible-with-the-Apache

News, I've got an answer from Google.

Q: Can/must/should we change the current license (Apache 2.0)? Our suggestion is MIT.

A: According to the Apache 2 license, it's required that you retain it for any code that was originally licensed under it. If you have your heart set on a different license, you might be able to license any new changes under it, but the existing code must retain existing license notices. My opinion is that the easiest thing to do would be to continue using the Apache license (it would also show a sign of good faith).

Q: Do we still need the Copyright disclaimer?

A: See the above.

Q: Can we drop the Contributor License Agreement?

A: Yes

Q: Would you link our new Repository and close the issues section after a migration?

A: We can't do this unfortunately, but you're free to leave a comment in the thread you mentioned pointing to it.

Q: Are there any comments from Google on this subject?

A: Thanks for your help with this!

No problem with the license, but it's a shame they can't link to the fork.
How do you suggest we proceed? Create a new repo using the organization js-marker-clusterer? Want to keep it under your own username?

That's true @Remo. I think there is no other way than to comment each of these issues to create this issue again in our new repository. The same for all open pull-requests.
Does this sounds realistic?
To create a new organisation like js-marker-clusterer is a good idea. We should do that. Would you create one?

It's a shame, but if we start pulling some of the fixes into the repository we should hopefully get enough traction to make it the inoffically official fork.
Invitation sent

Ok, may we should start with the PRs. We could create a Issue in the new repo for this topic and collect there all relevant PRs in a checklist.

This seems like pretty important functionality for Google Maps. Is there any sense as to why Google is abandoning this codebase? I.e. are they working on a replacement for it? Or is their a competing solution that is more popular?


remove upgrade logic from distributive role

[ ] Installs cleanly on a fresh build of most recent master branch
[ ] Upgrades cleanly from the most recent release
[ ] Updates documentation relevant to the changes

should make our builds faster!
untested, waiting on ci build

One green CI build, one impacted by #1625, one quota error


Postgres numeric type should resolve to float

In Postgres,the numeric type is equivalent to decimal. I feel this should result in float and not mixed.

Agree thanks for the suggestion 👍


Add github action for qe-tests

Adding QE runners into our CI.  Starting with the lifecycle suite of tests first.

How does Github know it should be run in VM and not in Container? And why the action is in this repo and not in QE?

Github knows where to schedule the work based on: runs-on: qe-runner.
And yup we'll add it to both repos eventually so changes going into the QE repo get instant feedback as well.

And what is qe-runner? How do you define it?

The qe-runner label is a label I've given to our fleet of self-hosted runner VMs.  Any runner using that label is eligible to pick up one of those jobs and start running.


The property value of one ADLS Gen2 blob container URL is empty

Storage Explorer Version: 1.10.1
Build: 20191023.8
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 19.04/macOS High Sierra
Architecture: ia32/x64
Regression From: Previous release (1.10.1)
Steps to reproduce:

Expand one ADLS Gen2 storage account -> Blob Containers.
Create a new blob container -> Refresh the Blob Containers node.
Check the new blob contianer URL on Properties panel.

Expect Experience:
Display a correct URL.

Actual Experience:
The property value of URL is empty.

The code is checked in, but looks like the most recent package version was based on an out-of-date branch (didn't rebase). Working on a new package version.


fix: typescript app template does not compile on Windows

cdk8s-team/cdk8s-cli#362 made the compile and watch scripts of the
typescript-app template use a relative path to the tsc compiler,
however such a form does not work as intended on Windows...
Instead of doing this, explicitly declare a devDependency on the
typescript compiler and return to using just tsc. Also, pass the
--build argument, which speeds up incremental builds considerably.

@Mergifyio refresh

💚 All backports created successfully

Status
Branch
Result

✅
1.x

Questions ?
Please refer to the Backport tool documentation


Please provide some custom COM server and COM client example,thx.

Suggestion
It's difficulty to code the custom COM server and COM client due to destructive updates.

It's WinRT but it's basically the same thing, just with slightly different exports and IDL syntax:
https://github.com/microsoft/windows-rs/tree/master/crates/tests/component
https://github.com/microsoft/windows-rs/tree/master/crates/tests/component_client
I've been meaning to add COM-specific examples though.

Hi, can I get some help?
I can't figure out how to generate bindings for a COM dll or an idl, seems the commands for generating the win32meta file in component build.rs don't work here.
I successed with winapi-tlb-bindgen, which depends on winapi.

Hi, can I get some help? I can't figure out how to generate bindings for a COM dll or an idl, seems the commands for generating the win32meta file in component build.rs don't work here. I succeeded with winapi-tlb-bindgen, which depends on winapi.

I made it with Microsoft.Windows.WinmdGenerator, for anyone that concerns, there is a good example: https://github.com/Traverse-Research/amd-ext-d3d-rs/tree/main/.metadata


v3.5.1

pickable-inventory support

I will close this as I pushed an update modularizing the Sandbox Spawn Menu Spawn function: https://github.com/nanos-world/nanos-world-sandbox/commit/f02afd51eb3ed515ca316a318bfb0ae82cfdac7f
You can now load your package and override the SpawnItem function with your own and do your logic:
local original_spawn_item = SpawnMenu.SpawnItem
SpawnMenu.SpawnItem = function(...)
  -- do your logic here

  -- call original if you want
  original_spawn_item()
end

This way sandbox gets more modular and with no external specific logic like what you PRed and you can implement everything in your separated package which can be loaded as an "addon"


Fix NavComponent for Navigation Drawer

Possible solution: use the game list as a parent and set navigate() calls when a selected item is clicked

Fixed. The above possible solution will not work correctly.


READMEtranslation

The French version of the README file for H4ckT0b3rF3st-2k21

In the translation challenge you must put your readme in the challenge folder, not replace the english readme in root.

how can I do this please


API to get full list of miners sorted by rank

Seems like a useful one for a witness voting ui for example. Maybe will need to add a pagination system if the list ever becomes too big


Polymer elements throw errors when async flag is added

Description
Errors thrown when async flag is used
Live Demo
http://rawgit.com/bahrus/xtal/master/tests/polymer-async.html
Sample Markup:

<!DOCTYPE HTML>
<html>
    <head>

    </head>
    <body>
        [Imagine a shell from another framework goes here]
        <link async rel="import" href="../bower_components/polymer/polymer.html">
        <link async rel="import" href="../bower_components/iron-list/iron-list.html">
        <link async rel="import" href="../bower_components/iron-resizable-behavior/iron-resizable-behavior.html">
        <iron-list></iron-list>
    </body>

</html>

Expected Results
Elements can load as they arrive, using some approach to instantiate only after the depending elements are loaded
Actual Results
Uncaught ReferenceError: Polymer is not defined
at iron-resizable-behavior.html:32
Browsers Affected

[x ] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari 9
[ ] Safari 8
[ ] IE 11

Versions

Polymer: v2.0.0
webcomponents: v1.0.0

Note
I raised something related in a previous issue that was closed almost immediately.  I wonder if I'm missing something big, which would explain why there is so little interest in this issue?
I'm using Polymer as a component library, rather than as a framework.  The framework that provides the shell is Preact.  I want to be able to let Preact render html content with zero blocking caused by waiting for the polymer elements to load, for less critical content.  If I don't set async, I see blocking.  I get similar errors with defer.  Rob Dodson once (at least) suggested using async as a way to guarantee progressive enhancement and avoid blocking.  So unless I missed a memo, I thought this approach was supported?
I tried setting the async flag on a Vaadin grid reference, and encountered similar issues as above.

Just import the iron-list, no need to import polymer at this file. Iron-list will import the polymer file, and it's(same as all the polymer elements) element definition needs the finish of polymer importing.

Yes, I observed that as well, which is why I hesitated to log this.  However, are you saying we can't define a polymer element within the opening page, if we use async?  Where is this documented?

Example 2:
http://rawgit.com/bahrus/xtal/master/tests/polymer-async2.html
The contents of that file are:
<!DOCTYPE html>
<html>
    <head>
        <title></title>
    </head>
    <body>
        <link async rel="import" href="asyncRefs.html">
    </body>
</html>

asyncRefs.html:
<link async rel="import" href="../bower_components/iron-a11y-keys-behavior/iron-a11y-keys-behavior.html">
<link async rel="import" href="../bower_components/iron-list/iron-list.html">
<link async rel="import" href="../bower_components/iron-resizable-behavior/iron-resizable-behavior.html">
<link async rel="import" href="../bower_components/iron-scroll-target-behavior/iron-scroll-target-behavior.html">

Results:
iron-scroll-target-behavior.html:26 Uncaught ReferenceError: Polymer is not defined
at iron-scroll-target-behavior.html:26
(anonymous) @ iron-scroll-target-behavior.html:26
2class.html:129 behavior is null, check for missing or 404 import
flattenBehaviors @ class.html:129
mixinBehaviors @ class.html:57
Polymer.Class @ class.html:323
window.Polymer._polymerFn @ polymer-fn.html:40
window.Polymer @ boot.html:29
(anonymous) @ iron-list.html:298
(anonymous) @ iron-list.html:1907

I believe you're hitting a known issue in Chrome's native implementation of HTML Imports (I think the repro in the 2nd comment in this Chromium bug roughly covers the behavior you're seeing).  Importing the same file, e.g. polymer.html, both async (as done in index.html) and sync (as done in e.g. iron-resisable-behavior.html) seems to result in the file being loaded async in all cases, which is definitely unexpected.
Given that bug, I'd recommend in your Example 2 to remove the async flag from the all the imports in asyncRefs.html (but keep async on the import of asyncRefs.html itself) and I believe you should avoid the bug and meet your goal of having the dependencies used in the shell loaded asynchronously.  Totally acknowledge it's annoying, but we're working around a platform bug for now.
I'm going to go ahead and close the issue since there's not much in Polymer we can do to address the Chrome bug and there's already a tracking issue there.


This postcondition holds and A postcondition might not hold on the same postcondition

Example input:
predicate f(x: int) {
  x > 0
}

predicate T(x: int, y: bool) {
  f(x) && y
}

method M()
  ensures T(-2, true)
{
}

This will be fixed by https://github.com/dafny-lang/dafny/pull/3282
See the result here:


[hotfix][doc] Clarify kinesis docs and fix debugging classloading docs

This change only clarifies the documentation

Mention AggregationEnabled setting in kinesis docs

Fix the default settings of class loading order in the docs

Will only merge the Kinesis doc fix, as the classloading docs already has a substantial fix meanwhile in master.


Add Gemfile deprecation warnings

See https://github.com/bundler/bundler/pull/3530.

Probably shouldn't use a class variable in a module that's meant to be included?

Waittttt did we already merge the Gemfile deprecation as part of the Bundler.ui.deprecation pull request? I meant to merge them separately :open_mouth:

Closing this, since the correct implementation is already merged. :ship:


htl-11 - bugfix - fix duplicated violations

htl-11 - fix duplicated violations when htl-11 is not applicable

Coverage remained the same at 95.41% when pulling ddcb75a638a05e357cbdab1bdd062322a45f7cef on bug-duplicated-htl-11 into ab7f6622c375815e59e0684d9f960bf0c73f76e1 on master.


Weird HTML tags not removing properly

https://github.com/stevengharris/MarkupEditor/assets/4402214/01a2589b-bde5-4d2b-8290-046710fbebe6
Hi @stevengharris,
Not sure if this was mentioned previously or it is a regression.
There are "" and duplication of the tags being added to an empty inner html.
Is this the expected html behavior for adding styles to the text?

Hmm, no, that doesn't seem quite right. There are in fact empty styled elements added when the caret is outside of a word. This is to support the case of "I want to bold what I'm typing next". I am mostly using hot-keys for it, so I'm doing something like "type normal text -> CTRL+B -> type bolded text -> CTRL+B -> type normal text". To make this happen, I have to create a styled element like <b></b>, but it has to contain a non-printing character to be able to select inside it. You can see this in markup.js occasionally as const emptyTextNode = document.createTextNode('\u200B');. I then select that text, which you cannot see on the screen, and when you type it's replaced. It does have a kind of weird side effect that if you never type into it, as you navigate using arrow keys, the cursor stops at the empty  element, but I think this is actually okay and probably the correct behavior. All of these empty elements are stripped when you getHTML, because I think of them as transient editing artifacts.
All that is a long explanation that is probably only tangentially related to what you showed in the video. I will check it out, thanks.


Add chart plugin

My submission for the snapshot plugin bounty. There's a Youtube video to demo this plugin: https://youtu.be/Ax_68hQMs6U
I'm also submitting another pull request to the other repository with the UI.

@Zerquix18 Can you remove change on package-lock.json?

Hi @bonustrack . Should be solved now.

@Zerquix18 I still see change on package-lock.json, also can you add an image for the plugin like this https://github.com/snapshot-labs/snapshot.js/blob/master/src/plugins/aragon/logo.png

Added a logo & placed the current package-lock.json from master.


improve the event handling performance

Codecov Report
Patch coverage: 97.97% and project coverage change: -0.45 :warning:

Comparison is base (d0b6d21) 98.88% compared to head (3a96420) 98.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   98.88%   98.43%   -0.45%
==========================================
  Files          74       74
  Lines        1430     1532     +102
  Branches      226      253      +27
==========================================
+ Hits         1414     1508      +94
- Misses         16       24       +8

Impacted Files
Coverage Δ

src/layer/RLayerRaster.tsx
100.00% <ø> (ø)

src/RPopup.tsx
86.66% <80.76%> (-13.34%)
:arrow_down:

src/RFeature.tsx
98.30% <97.43%> (-0.58%)
:arrow_down:

src/REvent.tsx
100.00% <100.00%> (ø)

src/RGeolocation.tsx
100.00% <100.00%> (ø)

src/RMap.tsx
100.00% <100.00%> (ø)

src/ROverlay.tsx
100.00% <100.00%> (ø)

src/context.ts
100.00% <100.00%> (ø)

src/control/RAttribution.tsx
100.00% <100.00%> (ø)

src/control/RControlBase.tsx
100.00% <100.00%> (ø)

... and 59 more

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


multi-nicd with the CrashLoopBackOff state

[ ] checked https://foundation-model-stack.github.io/multi-nic-cni/user_guide/troubleshooting/.
[ ] titled with the bug issue (if applicable).
[ ] provided corresponding information regarding the troubleshooting guidelines (CR list/detail, multi-nic cni controller and/or daemon status/log).

Describe the bug
A clear and concise description of what the bug is.
root@controller:~/cyclinder/multi-nic-cni/deploy# kubectl get po -n multi-nic-cni-operator
NAME                                                         READY   STATUS             RESTARTS      AGE
multi-nic-cni-operator-controller-manager-64cd6b55b5-fnmcw   2/2     Running            0             15m
multi-nicd-q5njr                                             0/1     CrashLoopBackOff   1 (13s ago)   18s
root@controller:~/cyclinder/multi-nic-cni/deploy# kubectl logs -f -n multi-nic-cni-operator multi-nicd-q5njr
2024/05/20 09:52:07 Config
W0520 09:52:07.813697      10 client_config.go:617] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.
2024/05/20 09:52:07 hostName=controller
2024/05/20 09:52:07 ListIPPool with selector: hostname=controller
2024/05/20 09:52:07 ListIPPool elapsed: 13792 us
2024/05/20 09:52:07 Listening @<IP_ADDRESS>:11000
2024/05/20 09:52:08 cannot get PCI info: Get "https://pci-ids.ucw.cz/v2.2/pci.ids.gz": dial tcp: lookup pci-ids.ucw.cz on [::1]:53: read udp [::1]:57298->[::1]:53: read: connection refused
2024/05/20 09:52:08 http: panic serving <IP_ADDRESS>:39214: runtime error: invalid memory address or nil pointer dereference
goroutine 41 [running]:
net/http.(*conn).serve.func1()
	/usr/local/go/src/net/http/server.go:1801 +0xb9
panic({0x12f08a0, 0x20761e0})
	/usr/local/go/src/runtime/panic.go:1047 +0x266
github.com/jaypipes/ghw/pkg/pci.(*Info).ListDevices(0x0)
	/root/go/pkg/mod/github.com/jaypipes/ghw@v0.8.0/pkg/pci/pci_linux.go:356 +0x2e
github.com/foundation-model-stack/multi-nic-cni/daemon/iface.GetTargetNetworks()
	/usr/local/app/src/iface/pci.go:166 +0x9a
github.com/foundation-model-stack/multi-nic-cni/daemon/iface.GetInterfaces()
	/usr/local/app/src/iface/iface.go:100 +0x3b
main.GetInterface({0x163d148, 0xc000228a80}, 0xc0004355f0)
	/usr/local/app/src/main.go:144 +0x3b
net/http.HandlerFunc.ServeHTTP(0xc0002ddf00, {0x163d148, 0xc000228a80}, 0xc0000729f8)
	/usr/local/go/src/net/http/server.go:2046 +0x2f
github.com/gorilla/mux.(*Router).ServeHTTP(0xc00017b140, {0x163d148, 0xc000228a80}, 0xc0002dde00)
	/root/go/pkg/mod/github.com/gorilla/mux@v1.8.0/mux.go:210 +0x1cf
net/http.serverHandler.ServeHTTP({0xc000435440}, {0x163d148, 0xc000228a80}, 0xc0002dde00)
	/usr/local/go/src/net/http/server.go:2878 +0x43b
net/http.(*conn).serve(0xc000423cc0, {0x1640cf0, 0xc000435350})
	/usr/local/go/src/net/http/server.go:1929 +0xb08
created by net/http.(*Server).Serve
	/usr/local/go/src/net/http/server.go:3033 +0x4e8

To Reproduce
I'm not sure what happened with it, Need for more investigations
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.

manager container of controller and multi-nicd DS status:
multinicnetwork CR:
hostinterface list/CR:
cidr CR (multiNICIPAM: true):
ippools CR (multiNICIPAM: true):
log of manager container:
log of failed multi-nicd pod:

Environment (please complete the following information):

platform: [e.g. self-managed k8s, self-managed OpenShift, EKS, IKS, AKS]
node profile:
operator version :
cluster scale (number of nodes, pods, interfaces):

Additional context
Add any other context about the problem here.

It is a reported issue of dependent ghw module (https://github.com/portainer/agent/issues/34).
Need an upgrade.


KAFKA-16087: Remove more leaky NamedTopologyIntegrationTest tests

These tests leak resources intermittently, so I didn't catch them in #15185:
shouldWaitForMissingInputTopicsToBeCreated:
at org.apache.kafka.streams.processor.internals.namedtopology.KafkaStreamsNamedTopologyWrapper.<init>(KafkaStreamsNamedTopologyWrapper.java:84)
at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.setupSecondKafkaStreams(NamedTopologyIntegrationTest.java:239)
at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldWaitForMissingInputTopicsToBeCreated(NamedTopologyIntegrationTest.java:721)

shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing:
at org.apache.kafka.streams.processor.internals.namedtopology.KafkaStreamsNamedTopologyWrapper.<init>(KafkaStreamsNamedTopologyWrapper.java:84)
at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.setup(NamedTopologyIntegrationTest.java:224)

shouldBackOffTaskAndEmitDataWithinSameTopology:
at org.apache.kafka.streams.processor.internals.namedtopology.KafkaStreamsNamedTopologyWrapper.<init>(KafkaStreamsNamedTopologyWrapper.java:80)
at org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldBackOffTaskAndEmitDataWithinSameTopology(NamedTopologyIntegrationTest.java:785)

I haven't observed the other tests in this suite fail, but that doesn't mean they don't have leaks.
The leaks do all seem to follow the same pattern: the close(Duration) calls time out, leaving behind resources. You can see these failures in #14783.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Hey @ableegoldman I missed some of the tests in this suite, so I had to open a follow-up. Thanks!

Test failures appear unrelated.


Ignoring files don't work

I'm running this:
xo --space --global jQuery --ignore *min.js

Also try this:
xo --space --global jQuery --ignore "*min.js"

but it keep processing file js/jquery.mousewheel-min.js, how can I disable that file or any minified file?
I'm using GNU/Linux node 4.2.6.

--ignore "*min.js" only matches files in the current directory. You want to match in a subdirectory, so should be --ignore "**/*min.js". I would also rather do --ignore "**/*-min.js" to ensure you want match files likejasmin.js.
More about glob patterns: https://github.com/isaacs/node-glob#glob-primer

If you intend to use this persistently in a project, I would recommend putting those options in the package.json config instead.

Another thing to note: without the quotes, your shell will most likely try to expand the glob to nothing for you. If it's one file, that might actually work - but if the glob matches more, then XO is going to receive --ignore, foomin.js, barmin.js, etc., changing how XO reacts to parameters (and probably trying to lint barmin.js and beyond).


Protect against undefined path in new getPropertyByPath

This PR fixes #188.
In version 5.2.0 (#177 specifically), the Lodash _.get method was replaced by a local function. This local function differed in that _.get(obj, undefined) would return undefined, but this function would just crash (trying to access undefined.reduce).
This protects against that possibility. Also added tests.

As proposed by @davidtheclark in https://github.com/davidtheclark/cosmiconfig/issues/188#issuecomment-498716046, we will fix the undocumented behavior by adding type assertions to the moduleName parameter. As such I'm closing this PR. Thank you!


upstream_openjdk_tests Jenkinsfile is no longer used

OpenJDK Project Builds have since been retired
and upstream_openjdk_tests Jenkins file was used
to facilitate testing (via aqa-tests) of those builds.
The Job using this file is here (it needs to get removed):
https://ci.adoptopenjdk.net/view/Test_upstream/job/UpstreamAutotest

After this, the entire view Test_upstream can be removed:
https://ci.adoptopenjdk.net/view/Test_upstream/

I have additionally removed the related jobs and Jenkins tab/view.

Thank you!


feat: convert vals to strings

resolves #1001
Problem
There is a bug currently that requires runtime_config properties values to be strings. As a result, integer values need quotes around them in the yml files, which is awkward.
With this PR, values are cast as strings, so that the properties can be set in a more expected way.
ADAP-1007
Solution
In _configure_batch(), I added a check for runtime_config.properties. If they exist, I iterate through the dictionary to cast the values as strings. Changing this part of the code was suggested as an option in #1001.
Checklist

[x] I have read the contributing guide and understand what's expected of me
[x] I have run this code in development and it appears to resolve the stated issue
[x] This PR includes tests, or tests are not required/relevant for this PR
[x] This PR has no interface changes

@dbeatty10 @McKnight-42 Anything I can do to help move this PR forward?

@jimmyshah this is queued up for a member of our engineering team to give it an initial review and provide any relevant feedback. We don't have a set timeline for when they will be able to get to it though.

@dbeatty10 Got it! I didn't know there was a review queue, so that's helpful context. Thank you for the update!


show_administration: true in config.neon

We added password protection to MT-ComparEval and therefore set show_administration: true on the server. Now the server config differs from the config on GitHub which says show_administration: false.
Can we update the default config to show_administration: true so I dont have to manually change the configuration upon each update? This manual task upon each update asks for problems.

Yes, you can do it.

done


Standalone asset & chain registry [new repo]

It's quite common to create an independent registry (see cosmos example) which can be used by a number of external contributors.
At the moment, it's somewhat buried in our constants package. We also want to expand this to a chain registry for IBC actions.
Todo:

Create new registry repo
Migrate asset registry
Make placeholder for chain registry
Setup npm publishing pipeline
Add new dependency to web monorepo and remove old registry

@hdevalence realizing we should be using the public https://github.com/cosmos/chain-registry instead and not create our own repo

We need our own repo because we need to transport the token metadata along IBC channels.

This would involve a script that pulls the cosmos chain registry and a set of channel configurations as a source and then builds a set of Penumbra metadata objects with the denom prefixed by the channel name, the penumbra asset IDs included, etc

I believe this was discussed in a different issue but I'm not sure where offhand.


🐛 [Bug] UnicodeDecodeError running setup.py

Bug Description
Trying to run "python setup.py install" fails with a unicode error when reading README.md.
To Reproduce
Steps to reproduce the behavior:

docker run --gpus=all -it nvcr.io/nvidia/tensorrt:20.03-py3 /bin/bash
(cd /usr/bin && wget -O bazel https://github.com/bazelbuild/bazelisk/releases/download/v1.7.3/bazelisk-linux-amd64 && chmod +x bazel)
git clone https://github.com/NVIDIA/TRTorch.git
cd TRTorch/py
pip install -r requirements.txt
python setup.py install

The error follows:

root@320583666d0c:/workspace/TRTorch/py# python setup.py install
Traceback (most recent call last):
File "setup.py", line 194, in
long_description = fh.read()
File "/usr/lib/python3.6/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 7349: ordinal not in range(128)

Expected behavior
No unicode error
Environment

PyTorch Version (e.g., 1.0): 1.6.0
CPU Architecture: x86
OS (e.g., Linux): Linux
How you installed PyTorch (conda, pip, libtorch, source): pip
Build command you used (if compiling from source): python setup.py install
Are you using local sources or building from archives: local sources (git clone)
Python version: 3.6.9
CUDA version: 10.2.89
GPU models and configuration: gtx 970

Additional context
The following appears to resolve the issue:
diff --git a/py/setup.py b/py/setup.py
index 53f85da..8344c0a 100644
--- a/py/setup.py
+++ b/py/setup.py
@@ -190,7 +190,7 @@ ext_modules = [
                             )
 ]

-with open("README.md", "r") as fh:
+with open("README.md", "r", encoding="utf-8") as fh:
     long_description = fh.read()

 setup(

Thanks for catching this!


[Docs] Improvements

The goal here is to ease the navigation between @nuxt/ui and @nuxt/ui-pro components.

[ ] Group all links under Components instead of Elements, Forms, etc.
[ ] Remove Examples page
[ ] Templates page

@KealanAU What is the issue with the Discord link? It's working for me 🤔

When attempting to join a specific Discord channel using the provided link (https://discord.com/channels/473401852243869706/1153996761426300948), the page only loads and then reroutes to (https://discord.com/channels/473401852243869706) but just shows no text channels and nothing indicating you're on the Nuxt page. This behaviour occurs when the user has not already joined the server hosting the channel.
It might be more effective to provide a direct invite link to the specific channel, ensuring it works for users who haven't joined the server. I've created this one for the UI nuxt channel - https://discord.gg/AncwrBuTCe
The invite link I generated never expires, has unlimited users and also gives them temp permissions to see things till they quit the server, another
Can provide a video if you want, checked on firefox and safari.


Install latest version of aws-cli

I'm opening this issue to follow up on a discussion on slack and to bring visibility to this potential enhancement.
I found that the bundled version of aws-cli is a bit outdated. Currently, Amazon Linux 2017.3 uses aws-cli 1.11.29, tagged December 14th, 2016. I encountered an incompatibility with the retagging in the ECR API.
In order to minimize API incompatibility, I believe it makes sense to simply install the latest version of aws-cli in the image instead of relying on the bundled version.

Check out #278!


Possibly wrong type hints for ConnectionStrategy.make_connection()

Currently, ConnectionStrategy.make_connection() is defined as
    @abstractmethod
    async def make_connection(self) -> Awaitable[Conn]:
        ...

If an implementation does something like this:
class MyStrategy(ConnectionStrategy[MyConnection]):
    async def make_connection(self) -> Awaitable[MyConnection]:
        conn: MyConnection = await my_connect()
        return conn

then MyPy complains with: return-value: Incompatible return value type (got "MyConnection", expected "Awaitable[MyConnection]")
I thus think that the return type should changed from Awaitable[Conn] to Conn:
    @abstractmethod
    async def make_connection(self) -> Conn:
        ...

With the current implementation, the user Code would have to do something like this, which is imho not idiomatic:
class MyStrategy(ConnectionStrategy[MyConnection]):
    async def make_connection(self) -> Awaitable[MyConnection]:
        return my_connect()  # no "await my_connect()" here!!

The Redis contrib also uses return await connect() but since it is not type hinted, the issue is not raised there.


Use case in recyclerview

How does it work inside an adapter class??
Use case: I already have a dataset in my listview/recyclerview and I make a swipetorefresh list..
how do I notify the viewholder to start the loading animation while awaiting data from the network ?

Is it not be possible to call the View.resetLoader(); method from your activity?

Is it not possible to use the View.resetLoader(); method inside the adapter class?

@kobusLink noted that very well. Thanks.
@ClaudeHangui, when you swipe to refresh, if there's no data, you shouldn't be displaying the recyclerview list of empty data. Ideally from a design point of view, an empty state view should be shown. Hope this helps.
I'm closing this issue unless there's further inquiries. Thanks.


runaway processes

Hey there! I've tried to use kak-lsp a couple of times and have had a consistent problem: if I use it for a little bit, it starts spawning a ton of processes, which blocks any other process from starting in the shell while it's happening (presumably because of ulimit stuff?) This makes it hard to actually gauge what's going on!
This most recent time I've tried kak-lsp by starting it in the foreground in a shell in verbose mode. Unfortunately, I didn't see anything unusual happening, but maybe I don't know what to actually look for either. I can make and attach a log if it'd be helpful—but I'm not sure if it would be helpful so I'm not going to by default.
Do you have any idea what could be happening here, and how I could fix it? I've searched the issues and looked over the README and wiki and didn't see anything immediately relevant.
This has happened with both language servers I've tried (rust-analyzer and elm-language-server) and I'm on the v10.0.0 release tag of kak-lsp and Kakoune v2020.09.01.

I use it for a little bit

How long does that usually take? If it takes a while, that'll make it harder
to get to the bottom of this :(
(When using rust-analyzer, on startup a few rust-analyzer processes will
index the project for a bit. But your issue sounds different.)

it starts spawning a ton of processes which blocks any other process
from starting in the shell while it's happening (presumably because of
ulimit stuff?)

I assume those are kak-lsp processes? So not language servers?
Are they maxing out your CPU, or just idling? Any zombies?

This makes it hard to actually gauge what's going on!

We should find a way to detect when it goes bad, and automatically kill
kak-lsp when that happens. Not sure what's the best way to do that?
Set ulimit to something really low? Start kak-lsp with timeout -s9 by
adding that as prefix to %opt{lsp_cmd}?
Once we have that, it should be easier to find a minimal config to reproduce.
Either way please try it with no config:
HOME=$(mktemp -d) kak -e '
	eval %sh{kak-lsp --kakoune -s $kak_session}
	set global lsp_cmd "kak-lsp -s %val{session} -vvvv --log /tmp/kak-lsp.log"
	lsp-enable
'

This most recent time I've tried kak-lsp by starting it in the foreground

Did the issue also happen here?

Unfortunately, I didn't see anything unusual happening

When I run with -vvvv in my %opt{lsp_cmd}, I get lots of log messages,
but only whenever I switch buffer, edit a buffer, or do something lsp-related, like gd.
When you are idling or just moving around a single buffer, there should be nothing
added to the logs.
Does it also happen on a minimal Rust project (cargo init tmp-project)?

How long does that usually take?

Shortly after startup. I haven't found a behavior that reliably triggers it yet, but it's pretty quick regardless.

I assume those are kak-lsp processes? So not language servers?
Are they maxing out your CPU, or just idling? Any zombies?

It's a mix of kak-lsp and kak processes. I've been in recovery mode when it's happened before, so I haven't noted CPU usage or zombie-ness. I'll note that when I'm trying to reproduce.

As to the rest of your message, I'll use those as reproduction instructions and try to reproduce it this week sometime! Thank you!

What a coincidence: today when I upgraded kak-lsp to an incompatible version I noticed that I had 2700(!) kak-lsp --request processes sitting around doing nothing. My guess is that in my case the old server was still alive, so new requests would go hit a dead end. I can recreate that but it's probably unrelated. Still, we might be able to improve error messages.

It's a mix of kak-lsp and kak processes

kak-lsp shouldn't spawn any kak processes, so their number should be small.
A log might be helpful because it can tell us if there are requests that never finish.

Just to follow up: I finally got around to trying to reproduce this with a minimal project and I can't. 😞  I'm going to keep trying periodically. If it'd be helpful for you to close this issue, feel free!

OK, after messing around with it a bit more I think I figured out what was going on: I had a hook that ran rustfmt before saving each time. I think that might have been looping forever with something in kak-lsp because once I removed it the problem went away.
Here's the diff that fixed it: https://git.bytes.zone/brian/dotfiles.nix/commit/f4d147ebbc2646bb064041ab582649edabefe3d5
Buuuut, I admit that I'm guessing here! With you knowledge of how the system actually works, does it seem like a reasonable explanation or am I just getting lucky here?

Hmm that shouldn't be a problem. I use a similar BufWritePre hook with clang-format and gofmt, I'll try with rustfmt now too.
Did you also use a hook with elm-language-server?

I think that might have been looping forever with something in kak-lsp

That's strange. If I tail -f the log, I just get textDocument/didSave + textDocument/didChange on save. The latter is only sent when the file was actually changed.

As a matter of fact, it happened again, but I haven't had a chance to get back to the issue to report that back! Meetings today!
I used a similar hook with elm-language-server and elm-format, yes.
The next thing I've tried was disabling inlay hints and semantic tokens. I also disabled the InsertIdle completion command since I don't care enough about completions to pay the price of rust-analyzer running clippy and compiling on (what seemed like) every keystroke. 😵 That seems to have gotten me into a stabler place.

I also disabled the InsertIdle completion command since I don't care enough about completions to pay the price of rust-analyzer running clippy and compiling on (what seemed like) every keystroke. dizzy_face

Right, the default idle timeout is 50ms, which will basically trigger on every keystroke. I personally haven't really noticed problems with that but #394 tracks how we can improve the idle timeout in a nice way short of just disabling them with
define-command -override lsp-completion %{}
I'd love to find a solution that is on by default (not another config option)

mmhmm, I saw that one, so I didn't open another issue. (I did subscribe, though!)
For now, my solution is to just opt out of completions. That's working pretty well for me, so far!


Union types with subtypes define in other modules cause flow to error

Here is an example of code that type checks fine:
/* @flow */

export type B =
  | { tag: "B1" }

export type A =
  | { tag: "A1" }

export type C =
  | { tag: "B", source: B }
  | { tag: "A", source: A }

const tagA =
  (action:A):C =>
  ( { tag: 'A'
    , source: action
    }
  );

Now let's say we factored out B into separate module:
B.js
/* @flow */

export type B =
  | { tag: "B1" }

C.js
B.js:4
  4:   | { tag: "B1" }
                ^^^^ string literal `B1`. Expected string literal `A1`, got `B1` instead
  6:   | { tag: "A1" }
                ^^^^ string literal `A1`. See: scratch.js:6

C.js:6
  6:   | { tag: "A1" }
                ^^^^ string literal `A1`. Expected string literal `B1`, got `A1` instead
  4:   | { tag: "B1" }
                ^^^^ string literal `B1`. See: B.js:4

That code no longer type checks and produces following errors:
B.js:4
  4:   | { tag: "B1" }
                ^^^^ string literal `B1`. Expected string literal `A1`, got `B1` instead
  6:   | { tag: "A1" }
                ^^^^ string literal `A1`. See: scratch.js:6

C.js:3
  3: import {B} from "./B"
             ^ Named import from module `./B`. `B` is a type, but not a value. In order to import it, please use `import type`.

C.js:6
  6:   | { tag: "A1" }
                ^^^^ string literal `A1`. Expected string literal `B1`, got `A1` instead
  4:   | { tag: "B1" }
                ^^^^ string literal `B1`. See: B.js:4

Another interesting observation is that record field name has an impact on behavior, for example using unique names in unions seems to avoid the issue:
C.js
/* @flow */

import type {B} from "./B"

export type A =
  | { tag: "A1" }

export type C =
  | { tag: "B", b: B }
  | { tag: "A", a: A }

const tagA =
  (action:A):C =>
  ( { tag: 'A'
    , a: action
    }
  );

This pretty much what we have being doing to avoid this bug in our code base, but every new contributor eventually hits this bug and spends countless hours trying to make sense out of it.
What's even worse is that sometimes order of types in union or different combination seems to avoid the issue. So there are cases where 5 tagged types are combined in the union and then adding or removing one more tagged type introduces this issue, which makes it even harder to trace to this specific misbehavior of flow.

Following, I'm seeing the same issue. I'm working around it by having a single file for all of the type definitions in the union, which is pretty painful.


JS - commented out code is indented one extra time

I've run into a small issue with this extension regarding commented-out code. Say I have a block of code like this:
const a
const b
// const c
const d
const e

Upon running Beautify, it is formatted to look like this:
const a
const b
  // const c
const d
const e

I don't want the commented code to be indented, I want it to remain in line with the code surrounding it. Is there any way to prevent this behavior?

Single line comments are considered a part of the current statement. Multi line statements have all additional (not the first) lines indented.  Adding a ; to close your const declarations (specifically the one before the comment) would un-indent the comment again.