Remote reader locking fix

Fixes #1353
Ensures that RemoteReader() instance which initiated requests is the one which is reading them back

[Current coverage][cc-pull] is 47.46%

Merging [#1564][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.08%

@@             master      #1564   diff @@
==========================================
  Files            52         52
  Lines          5796       5800     +4
  Methods           0          0
  Messages          0          0
  Branches       1120       1121     +1
==========================================
- Hits           2756       2753     -3
- Misses         2833       2838     +5
- Partials        207        209     +2

Powered by Codecov. Last updated by [bd2bd0f...03b7f0d][cc-compare]
[cc-base-branch]: https://codecov.io/gh/graphite-project/graphite-web/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/graphite-project/graphite-web/compare/bd2bd0fc59dbefad8963b641ddc9b7aa6ab37727...03b7f0d91992e5a6aba715b6c0182328dff133e6
[cc-pull]: https://codecov.io/gh/graphite-project/graphite-web/pull/1564?src=pr

Looks good at first sight, but I do not running master in PROD.
Anyone else want to check @graphite-project/committers ?

I'll check it out.

This looks good to me.

This is a total mess. Single threaded graphite keeps calling wait_for_result on passive readers first, which obviously never going to succeed, for whole that RemoteReader thing to work, order of calls to RemoteReader.fetch must match order of calls to wait_for_result, at least first call in both sequences must be the first one, if it isn't it all deadlocks for FETCH_TIMEOUT.
I have a suspicion active call might never be called at all in some cases.
Needs to be reworked ,so that it doesn't depend on order of calls


Is it possible to change the highlight of separators of the status line of the popup window?

I would like to change the highlight of the separator (i.e., the powerline symbol at the bottom of the screenshot) individually without changing Lf_hl_popup_normalMode, Lf_hl_popup_inputMode, Lf_hl_popup_category, etc., however I cannot find a highlight group for that.

Lf_hl_popup_{category}sep0
Lf_hl_popup{category}_sep0

Is there a convenient way to set the separator highlight for all categories?

Maybe the Lf_hl_popup_{category}_sep0 should be able to have different colors in input mode and normal mode.

Any update on this issue?

I find it is not easy to implement.

Thanks for reply. I'll be patient.


Deprecation warnings for the wrong version of React in the new 7.0.0

I'm getting the following deprecation warning, which is just fine:
warning  React.PropTypes is deprecated since React 15.5.0, use the npm module prop-types instead  react/no-deprecated

But, since I'm still using React v15.4.2 (and not 15.5.0+ as the message is pointing out), it doesn't seem to be the correct behavior. Am I right?
Thanks!

Are you sure? Only React 15.5 prints that out. What does npm ls say?

Yes, I'm sure.
$ npm ls react

<EMAIL_ADDRESS>/Users/almirfilho/Realgeeks/ukulele
└──<EMAIL_ADDRESS>
It just began to show this warning after the upgrade of eslint-plugin-react v7.0.0.
I'm going migrate to the new proptypes anyway, it's just that I thought this could be a bug in the plugin.

try npm ls | grep react?

npm ls | grep react

├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>├─┬<EMAIL_ADDRESS>

ahhh right, sorry. yes, that message is coming from this plugin.
I originally expected the deprecation warning would only print out on React 15.5 (per the version you specify in your config), but it seems it applies with all v15 versions.
@yannickcr, what do you think about restricting this check to 15.5+ only?

eslint-plugin-react can not detect which React version you are using, so it warns for every deprecated methods by default.
You can specify your React version in the shared settings. This should solve your issue.

@yannickcr right, but if I specify in settings that your version is "15.0" or "15.4" - as opposed to "15.5" - then i'd expect not to get this warning.

@ljharb Yes, and according to these tests it should work correctly. Were you able to reproduce the issue with the React version specified ?

Ah, thanks for clarifying.
@almirfilho have you specified v15.4 in your settings?

@ljharb No, I haven't. I've just migrated to the new prop-types.
But thanks anyway!


Feature request: add uv script to manage global scripts

I often write small standalone python scripts and I'll use them anywhere.
If using uv run /path/to/script.py is a bit cumbersome for me (mostly typing the path)
So I want a uv script command to globally install these scripts
Maybe something like uv tool, but uv script manages scripts, uv tool manages tools.
Related: https://github.com/pypa/pipx/issues/1388 (although pipx doesn't implement it too)

Is this related to 5903? Or do you specifically want uv to install scripts globally?

It's not quite the same, 5903 is a project-level command alias, something like npm run xxx
Whereas what I want is to make a single-file script available globally, like uv tool does for packages

I'm also looking forward to this feature.
In the meantime, I created a template that generates the minimum required files for uv tool install as a temporary solution:
https://github.com/kj-9/uv-tool-min-copier


chore: 🤖 update @babel/preset-env

:tada: This PR is included in version 1.4.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


refactor: Convert custom form template to bootstrap

Fixes #6411

What the form shows can be controlled now by https://github.com/ietf-tools/datatracker/pull/6763/files#diff-a2a76783d6a823963a5dfad1b48beba6e254c40a3d2d8f6a3944a50bfeb0fd81R364
@cindymorgan - do you care about the order? Do you want us to let bcc/reply-to show up, or suppress them as the current form does?


feat: Update pre-commit mirror script

Summary

pre-commit-mirror-maker is not suitable for generating multiple hooks in single .pre-commit-hooks.yaml file.
So replaced the script and github workflows.

Test Plan

Update pyproject.toml's ruff==0.0.290 into ruff==0.0.289, and run the script.

$ python3 mirror.py
...

Nice, thank you so much! We'd just discussed doing this internally, you read our minds... I will defer to @zanieb for review. (Zanie's out on vacation so will probably get to this next week.)


Add names to input types in spec functions

What
Add names to input types in spec functions.
Why
When defining an interface it is helpful to give names to the arguments of the functions so a user of the interface knows what to put in the arguments. This is especially helpful when multiple arguments have the same type, since a name is the only thing that distinguishes them.
Close stellar/rs-soroban-sdk#434

This change causes the output of the generated code to include argument names, e.g.:
❯ soroban-cli gen --wasm target/wasm32-unknown-unknown/release/example_add_i32.wasm --output rust
pub const WASM: &[u8] = ::soroban_sdk::contractfile!(
    file = "target/wasm32-unknown-unknown/release/example_add_i32.wasm", sha256 =
    "082f8d7a70e88996451d2fa53844a95f8c6da4e9179f9ce133bd40489194b3ae"
);
#[::soroban_sdk::contractclient(name = "Client")]
pub trait Contract {
    fn add(env: ::soroban_sdk::Env, a: i32, b: i32) -> i32;
}

And the output of contract functions in other places to also include names:
❯ soroban-cli inspect --wasm target/wasm32-unknown-unknown/release/example_import_contract.wasm
File: target/wasm32-unknown-unknown/release/example_import_contract.wasm
Functions:
 • add_with (val, val) -> (res)
 • _ () -> ()
Env Meta: AAAAAAAAAAAAAAAE
 • Interface Version: 4
Contract Spec: AAAAAAAAAAhhZGRfd2l0aAAAAAIAAAABeAAAAAAAAAIAAAABeQAAAAAAAAIAAAABAAAAAg==
 • Function: add_with ([ScSpecFunctionInputV0 { name: VecM([120]), type_: I32 }, ScSpecFunctionInputV0 { name: VecM([121]), type_: I32 }]) -> ([I32])


[WIP] coibase wallet sdk v4

PR-Codex overview
This PR updates the @coinbase/wallet-sdk dependency to version 4.0.0-rc.1 and adds support for Coinbase Smart Wallet.
Detailed summary

Updated @coinbase/wallet-sdk to 4.0.0-rc.1
Added support for Coinbase Smart Wallet
Modified wallet connection options in CoinbaseSDKWalletConnectionOptions
Updated functions related to wallet connection and initialization

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

/release-pr


Automatically increase bundleDelay on Mac OS X

This ensures Mac OS users do not run into the usual bundling twice errors.
@bendrucker Is this a good idea?

I'm pretty torn on what to do about this. At some point you get into a situation where people are upset about poor perf for smaller projects. It's hard to say which outcome is worse: some people who observe a bug, or some people with general frustration. Both cases are fixed by docs, but it's not a smooth experience.
As costly as managing file lookups outside of Karma will be, I think that's the path to go down. Would make the code base a lot more readable as well since the average user isn't thinking about the insanity of needing to debounce updates with a delay.

Yes, with all the bug reports we are seeing I feel like it should better (usability wise) to have a slight automatically applied bundling penalty rather than endless re-bundling.
The issue with manual configuration is: You are penalizing other platforms too that would work fine without any adjustments. I see this as a huge issue in mixed platform development teams (which are common, especially in OSS).
Any idea what a good bundleDelay on Mac OSX is?

I just updated the version of watchify to the latest version. It updates some of file watching utilities, too and allows the customization of watchifys very own bundleDelay`.
Let's see if this already fixes some of the issues.

Will update keep my eye out for double bundling. The problem with assigning any particular delay is that it seems to be affected by a lot of factors, including disk speed. I'm guessing that I see it less often since I'm exclusively on SSDs.


[Question] Brownout flag, Is there register address to read brownout flag after reboot?

Hi,
Is there register bit which is set (non-volatile) by the ESP32 if brownout occurs? And can be read after next reboot?
Regards,
Dion

https://github.com/espressif/esp-idf/blob/c4edb2a4398aef32822b1f917157e402cc246e64/components/esp32/include/rom/rtc.h#L95

@negativekelvin : CMIIW. So I can call rtc_get_reset_reason() from application?
Is this flag overwritten by esp_restart_noos() ? Because, the standard rtc_brownout_isr_handler() calls esp_restart_noos().

Anyone can answer my question @FayeY or @negativekelvin  ? What is brownout workaround? Is there newer chip revision already?

The brownout "workaround" as I called it IS the rtc_brownout_isr_handler calling esp_restart_noos instead of returning

@negativekelvin :
Do you know whether it is safe to do nvs_write_* inside this isr handler?
Do you also know if there's newer chip revision for PICO-D4?

No, and writing to flash in general is probably not a good idea since flash may not operate properly during brownout.
Rev 1 is newest afaik

Is there update regarding this issue?
Is it now possible to get brownout reset cause when brownout occurs?


Control-flow simplification in Frame.CreateResponseHeader() (#1168).

Thanks @cmckinsey for suggesting this change (#1168).
There's no noticeable change in benchmarks, but the code reads a lot better this way.
cc @halter73

:shipit:


shell content error, no dingding message send

Enviornment (please complete the following information):

OS: linux
EaseProbe Version
latest version

Describe the bug
配置shell脚本，脚本内容出错，钉钉消息未发送通知，日志也未打印发送钉钉通知消息
Configure shell script, script error, but messages are not sent to DingDing notifications, and there is no notifcaiton logs  as well.

To Reproduce
Expected behavior
期望脚本报错发送钉钉消息，如果是钉钉配置出错，希望把日志打印出来

what's the config.yaml? how to reproduce this problem?
BTW, next time, please paste the log as text instead of a picture.

By the way, the EaseProbe is edge-trigger, which means only the status change (up -> down, or down -> up) would send the notification.
if the "Flink Monitor" script had been run failed already,  which means the status just from down to down, this won't trigger the notification.
you can enable the debug information to check
settings:
   log:
       level: debug

刚那个问题是脚本内容出错，状态是 down=>down no state change 所以没有通知，已解决，感谢。不过想知道，对于钉钉消息的内容展示，是否用户可以自定义内容。可以有提供个消息模版参数，可由用户自己进行定制

can you can give proposal what the template looks like? And feel free to
contribute what you want.
studyhuang1996 @.***>于2022年7月8日 周五15:07写道：

刚那个问题是脚本内容出错，状态是 down=>down no state change
所以没有通知，已解决，感谢。不过想知道，对于钉钉消息的内容展示，是否用户可以自定义内容。可以有提供个消息模版参数，可由用户自己进行定制
—
Reply to this email directly, view it on GitHub
https://github.com/megaease/easeprobe/issues/165#issuecomment-1178634084,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHXWHQYOSOKWZEHCIBXZKTVS7HU7ANCNFSM527SYHWA
.
You are receiving this because you commented.Message ID:
@.***>

可否 每个任务下脚本下可自定义自己的message，然后钉钉消息，从message中获取, 还有个问题，请问下yaml 只有响应检查只有 not_contain 和  contain 吗？ 可否有个 或者 。比如我请求一个接口，解析接口中返回值获取某个字段值，比如这个字段有
[a,b,c,d,e] 多种状态，那么我此时想判断 文本中 存在 b或者 c 就算失败，单单包含貌似满足不了需求

You can do any check in your script, and output any message you like. EaseProbe would send that message to notification.

@studyhuang1996 do you have any further questions?

日志展示：10点43分的时候 推送钉钉消息
ERRO[2022-07-12T10:43:26+08:00] [shell / 93-Flink Job监控] - the output does not contain [成功]
INFO[2022-07-12T10:43:26+08:00] [channel / EaseProbe_Channel]: 93-Flink Job监控 (/home/soft/easeprobe/script/flink-monitor.sh http://<IP_ADDRESS>:19960/jobs/overview) - Status changed [up] ==> [down]
INFO[2022-07-12T10:43:26+08:00] [dingtalk / dingtalk alert service] - 93-Flink Job监控 Failure ❌
/home/soft/easeprobe/script/flink-monitor.sh http://<IP_ADDRESS>:8081/jobs/overview - ⏱ 12ms
Error (shell): Error: the output does not contain [成功]
但是实际没有发送钉钉消息，钉钉消息只有 10点41分的时候，运行发送一次

消息提醒日期，可以自定义展示 UTC+8 东八区吗？

any error message for DingTalk notification?  if not,  can you enable the debug logging to see what's happening?   you can set the following configuration to enable it.

settings:
    log:
        level: debug

the time zone you can configure that, but you need to use the latest source code to build because I just supported that yesterday in PR #166

BTW, please paste the code, log, and configuration with markdown format instead of a picture!!!!

日志没有钉钉相关错误消息
`job执行失败!
ERRO[2022-07-12T11:21:38+08:00] [shell / 93-Flink Job监控] - the output does not contain [成功]
DEBU[2022-07-12T11:21:38+08:00] [shell / 93-Flink Job监控] - Error: the output does not contain [成功]
DEBU[2022-07-12T11:21:38+08:00] shell: {"name":"93-Flink Job监控","endpoint":"/home/soft/easeprobe/script/flink-monitor.sh http://<IP_ADDRESS>:8081/jobs/overview","time":"2022-07-12T03:21:38.643645189Z","timestamp":1657596098643,"rtt":10581020,"status":"down","prestatus":"up","message":"Error (shell): Error: the output does not contain [成功]","latestdowntime":"2022-07-12T03:21:38.654243334Z","recoverytime":1500051839778,"stat":{"since":"2022-07-11T08:32:02.254268601Z","total":208,"status":{"1":183,"2":25},"uptime":54900000000000,"downtime":7500000000000},"timeformat":"2006-01-02 15:04:05 UTC"}
INFO[2022-07-12T11:21:38+08:00] [channel / EaseProbe_Channel]: 93-Flink Job监控 (/home/soft/easeprobe/script/flink-monitor.sh http://<IP_ADDRESS>:8081/jobs/overview) - Status changed [up] ==> [down]
INFO[2022-07-12T11:21:38+08:00] [dingtalk / dingtalk alert service] - 93-Flink Job监控 Failure ❌
/home/soft/easeprobe/script/flink-monitor.sh http://<IP_ADDRESS>:8081/jobs/overview - ⏱ 11ms
Error (shell): Error: the output does not contain [成功]

EaseProbe v1.6.0 @ localhost.localdomain at 2022-07-12 03:21:38 UTC

2022/07/12 11:22:38 "GET http://<IP_ADDRESS>:8181/ HTTP/1.1" from <IP_ADDRESS>:56490 - 200 2092B in 78.417µs
2022/07/12 11:22:39 "GET http://<IP_ADDRESS>:8181/favicon.ico HTTP/1.1" from <IP_ADDRESS>:56490 - 200 2092B in 63.413µs`

it should have a log state successfully sent! or failed to send!,
and if there have some connection problem with the DingTalk server, it should have a Warning log for retry...
can you find those logs?

By the way, it looks you enable the dry run mode for DingTalk, could you please show your config.yaml?

By the way, it looks you enable the dry run mode for DingTalk, could you please show your config.yaml?
配置如下:

#Shell Probe Configuration
shell:
  # A proxy curl shell script
  - name: 93-Flink Job监控
    cmd: "/home/soft/easeprobe/script/flink-monitor.sh"
    args:
      - "http://<IP_ADDRESS>:8081/jobs/overview"
    contain: "成功"
# Native Client Probe
client:
  - name: 125-MySQL从库监控
    driver: "mysql"
    host: "<IP_ADDRESS>:3306"
    username: "root"
    password: "***"

settings:
  log:
    level: debug
  sla:
    schedule : "daily"
    time: "23:00"
  probe:
    interval: 5m
  http:
    ip: <IP_ADDRESS>
    port: 8181

notify:
  dingtalk:
    - name: "dingtalk alert service"
      webhook: "https://oapi.dingtalk.com/robot/send?access_token=****"

the configuration looks fine,  and did you add -d options for command line?

启动的时候有加
./bin/easeprobe  -f  config/flink-monitor.yaml -d

-d means dry run,  EaseProbe just only logs the message that needs to send, but it actually not sent. Please remove the -d option.

failed to send!
只有钉钉正常的启动日志，目前现象初次发了，后面都没发，日志打印没找到相关关键词

INFO[2022-07-12T11:16:38+08:00] Notification [dingtalk] - [dingtalk alert service] is running on Live mode!
INFO[2022-07-12T11:16:38+08:00] Notification [dingtalk] - [dingtalk alert service] is configured!
DEBU[2022-07-12T11:16:38+08:00] Notification [dingtalk] - [dingtalk alert service] configuration: &{DefaultNotify:{NotifyKind:dingtalk NotifyFormat:markdown NotifySendFunc:0x917f80 NotifyName:dingtalk alert service NotifyChannels:[__EaseProbe_Channel__] Dry:false Timeout:30s Retry:{Times:3 Interval:5s}} WebhookURL:https://oapi.dingtalk.com/robot/send?access_token=****}
INFO[2022-07-12T11:16:38+08:00] Successfully setup the notify channel: dingtalk

-d means dry run, EaseProbe just only logs the message that needs to send, but it actually not sent. Please remove the -d option.

好的，理解错了，我以为 -d 是保持后台运行。那如果想让其后台运行，有参数可配吗，还是直接运行脚本即可？

EaseProbe is in edge trigger mode, which means it sends the notification only when the status changes -  [up => down] or [down => up], if the service is keeping a down status, EaseProbe won't send the notification.

if you want to EaseProbe running in the background, just simply add an ampersand (&) after the command. and if you need the EaseProbe to output the log to a file rather than StdOut/StdErr, just config the log file in settings.

EaseProbe is in edge trigger mode, which means it sends the notification only when the status changes -  [up => down] or [down => up], if the service is keeping a down status, EaseProbe won't send the notification.
if you want to EaseProbe running in the background, just simply add an ampersand (&) after the command. and if you need the EaseProbe to output the log to a file rather than StdOut/StdErr, just configure the log file in settings.

OK ，Thank you very much


Lumen compatibility?

Is there any plan to support Lumen? Is there any specific reason to start from ^8.x?

There's already support for PHP7.4 added - not yet released.
As the router is one of the biggest differences between Laravel and Lumen it could get a tough task. 🤔

Agreed.
As Taylor Otwell stated this


@inheritdoc also for classes?

currently as far as I can tell, if you have an interface and a class implementing it, and if you want not to have to copy-paste the apidoc between both, you can put the apidoc on the interface, then put:
/**
 * @inheritdoc
 */

on each relevant method in the class.
that's useful, but it seems to work only for interfaces, not for abstract classes for instance. I think that would be useful also in these other contexts.

I have successfully changed the tslint.json to accept
/**
 * @inheritdoc
 */

as a valid way of completing the docs for a method.
See https://palantir.github.io/tslint/rules/completed-docs/ - but use existence instead of exists (the docs have been fixed but not published yet). This is a part of my tslint.json:
        "completed-docs": [
            true,
            {
                "classes": { "visibilities": ["exported"] },
                "enums": { "visibilities": ["exported"] },
                "enum-members": { "visibilities": ["exported"] },
                "functions": { "visibilities": ["exported"] },
                "interfaces": { "visibilities": ["exported"] },
                "properties": { "privacies": ["public", "protected"] },
                "methods": { "privacies": ["public", "protected"], "tags": { "content": {}, "existence": ["inheritdoc"] } },
                "types": { "visibilities": ["exported"] },
                "variables": { "visibilities": ["exported"] }
            }
        ]

In TypeDoc 0.21.1 (and likely for a while, haven't touched this code in a good bit), if you do not specify a comment, TypeDoc will automatically inherit doc comments if you add no comment to the class. I think this meets the need in this issue:
export interface Foo {
    /** docs for prop */
    prop: string;
}

export class FooImpl implements Foo {
    prop = 'prop' // docs from the interface will show up here too
}


WEBP support

I’m still going to improve this, but its working already.

Thanks! I'll take a look at this over the next couple days.

@mgartner I've updated the PR and now from my point of view it looks good to be merged. Could you please review it and share your opinion?

Reference: https://developers.google.com/speed/webp/docs/riff_container
Lossy: http://tools.ietf.org/html/rfc6386
Lossless: https://chromium.googlesource.com/webm/libwebp/+/master/doc/webp-lossless-bitstream-spec.txt

Looks really good! Thanks for contributing! Do you mind switching back the yodas and squashing your commits into 1?

@mgartner done.

Thanks again!


 I was trying to quote comment it was about the description thing for new contributors.

@Pradumnasaraf  hey you deleted my comment ?it s ohk but can you tell me reason  so i can improve my comments

Ah so sorry for that, I hit the wrong keyboard shortcuts. I was trying to quote comment it was about the description thing for new contributors.

yes no problem:) i think it s good to point out to write description from a first PR but it will be repeated for this repo so now i will not point it out

@Pradumnasaraf  hey you deleted my comment ?it s ohk but can you tell me reason  so i can improve my comments

Ah so sorry for that, I hit the wrong keyboard shortcuts. I was trying to quote comment it was about the description thing for new contributors.

yes no problem:) i think it s good to point out to write description from a first PR but it will be repeated for this repo so now i will not point it out

Yes, I totally agree. PR should be well descriptive for contribution and maintainers' view. But for new contributors, we try not to point that out in this repo are try not to create any bottlenecks :)
Thank you for the suggestions and for reviewing the PR.

Yes, I totally agree. PR should be well descriptive for contribution and maintainers' view. But for new contributors, we try not to point that out in this repo are try not to create any bottlenecks :)
Thank you for the suggestions and for reviewing the PR.
__
  Summary: :hammer_and_wrench: This code needs a fix

Yes, I totally agree. PR should be well descriptive for contribution and maintainers' view. But for new contributors, we try not to point that out in this repo are try not to create any bottlenecks :)
Thank you for the suggestions and for reviewing the PR.

👍


Logging and tracing correlation

Add support for logging a trace id through Helidon MDC. This can be a separate module, or just update to existing tracing implementation, where we would add the top level span traceId to Helidon Logging MDC. Then users could use one of our logging integration modules to log the trace id with every single log statement.
This feature is important for correlation of traces and log statements (such as when using Verrazzano)

Please consider reviewing https://github.com/helidon-io/helidon/issues/4256 and https://github.com/helidon-io/helidon/issues/4016, these too may likely be added to MDC as well.


Errors outside of the fork-ts-checker-webpack-plugin cause it to error

Current behavior
Error in fork-ts-checker-webpack-plugin after an error occurs outside of fork-ts-checker-webpack-plugin. I had a legitimate error in my postcss config file, which was causing the build to bail early. When this happens, I get the following error.
/Users/jonathan/my-app/node_modules/fork-ts-checker-webpack-plugin/lib/index.js:459
            return this.serviceRpc.dispatch(message);
                                   ^
TypeError: Cannot read property 'dispatch' of undefined
    at ChildProcess.service.on.message (/Users/jonathan/my-app/node_modules/fork-ts-checker-webpack-plugin/lib/index.js:459:36)
    at ChildProcess.emit (events.js:189:13)
    at emit (internal/child_process.js:820:12)
    at process._tickCallback (internal/process/next_tick.js:63:19)

I'm not familiar with fork-ts-checker-webpack-plugin, but it appears a spawned service is receiving a message after shutting down.
Expected behavior
Don't fail when a message is received after the service is killed.
Steps to reproduce the issue
Forcing an error in postcss.config.js reproduces the error for me, but I imagine forcing an error in any other loader may also reproduce the error.
Note
The fix likely entails adding a null check to the this.serviceRpc!.dispatch call, since the RPC provider dispatches in promise.resolve callbacks and doesn't appear to have a way to tear itself down.
Environment

fork-ts-checker-webpack-plugin: 3.1.0
typescript: 3.6.4
tslint: 5.16.0
webpack: 4.30.0
os: macOS 10.15.1

any updates?

Running into this as well.

note that this is merely indicative of another unrelated problem to this plugin, it just means a real error occurred in your project, elsewhere during webpack compilation.

I will take a look today, sorry guys for the inconvenience

:tada: This issue has been resolved in version 4.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


TextFormField losing value when changing focus.

Steps to Reproduce
The problem is reproducible in a StatefulWidget with the following code:
  @override
  Widget build(BuildContext context) {
    return new Scaffold(
        body: new Center(
          child: new Form(
            key: _formKey,
            child: new ListView(
              shrinkWrap: true,
              padding: EdgeInsets.only(left: 24.0, right: 24.0),
              children: <Widget>[
                new TextFormField(
                  decoration: new InputDecoration(
                      labelText: "TextFormField with TextEditingController",
                      suffixIcon: new Icon(Icons.bug_report)),
                  controller: new TextEditingController(),
                ),
                new TextFormField(
                    obscureText: true,
                    decoration:
                        new InputDecoration(labelText: "obscureText: true"))
              ],
            ),
          ),
        ));
}

If we remove the TextEditingController from the first TextFormField the issue does not occur.
Flutter Doctor
[✓] Flutter (Channel beta, v0.2.8, on Linux, locale en_US.UTF-8)
    • Flutter version 0.2.8 at /home/knuppe/flutter
    • Framework revision b397406561 (7 days ago), 2018-04-02 13:53:20 -0700
    • Engine revision c903c217a1
    • Dart version 2.0.0-dev.43.0.flutter-52afcba357

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /home/knuppe/Android/Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • ANDROID_HOME = /home/knuppe/Android/Sdk
    • Java binary at: /home/knuppe/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)
    • All Android licenses accepted.

[✓] Android Studio (version 3.0)
    • Android Studio at /home/knuppe/android-studio
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-915-b01)

[✓] VS Code (version 1.21.1)
    • VS Code at /usr/share/code
    • Dart Code extension version 2.11.2

[✓] Connected devices (1 available)
    • Android SDK built for x86 64 • emulator-5554 • android-x64 • Android 6.0 (API 23) (emulator)

• No issues found!

I just tried your code and can't reproduce.
Is this issue still relevant?

I had the same problem, and found a solution for that, just define a controller variable outside the build method.
Should look something like this:
var _myController = TextEditingController();

@override
  Widget build(BuildContext context) {
    return new Scaffold(
        body: new Center(
          child: new Form(
            key: _formKey,
            child: new ListView(
              shrinkWrap: true,
              padding: EdgeInsets.only(left: 24.0, right: 24.0),
              children: <Widget>[
                new TextFormField(
                  decoration: new InputDecoration(
                      labelText: "TextFormField with TextEditingController",
                      suffixIcon: new Icon(Icons.bug_report)),
                  controller: _myController,
                ),
                new TextFormField(
                    obscureText: true,
                    decoration:
                        new InputDecoration(labelText: "obscureText: true"))
              ],
            ),
          ),
        ));
}

The problem above is that if you create a new TextEditingController() on every build, then anything which causes your tree to rebuild will reset your form.  The proper way to use this is to create a StatefulWidget which holds your controller. Placing a text editing controller inside of a StatelessWidget is only going to cause further subtle bugs.
class MyForm extends StatefulWidget {
  @override
  State createState() => new MyFormState();
}

class MyFormState extends State<MyForm> {
  final _controller = new TextEditingController();

  @override
  Widget build(BuildContext context) { ... }
}

Solved by using StatefulWidget instead of StatelessWidget. Thank you @jonahwilliams.

Solved by defining the controller outside the build method

The solution mentioned  didn't work for me:

The problem above is that if you create a new TextEditingController() on every build, then anything which causes your tree to rebuild will reset your form. The proper way to use this is to create a StatefulWidget which holds your controller. Placing a text editing controller inside of a StatelessWidget is only going to cause further subtle bugs.
class MyForm extends StatefulWidget {
  @override
  State createState() => new MyFormState();
}

class MyFormState extends State<MyForm> {
  final _controller = new TextEditingController();

  @override
  Widget build(BuildContext context) { ... }
}

Here is an issue I created a short time ago on flutter_hooks repository thinking that the problem was because of hook widget, but I tried with  StatefulWidget and still same result (result is that TextField is losing its contents when I go to recent apps while I am typing in it, more description and a video in the last comment are available in the link above)
so is there a fix for this?

Use initState

Use initState


Update manifest: Rainmeter.Rainmeter version <IP_ADDRESS>53

Details

Add ARP entries of this package.
This may prevent infinite upgrade loops.

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
Resolve #167361
Resolve rainmeter/rainmeter#381

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

✅ False positive report submitted.


add forecast layers; COUNTRY=mozambique

Description
Add forecast layers to Mozambique.
Checklist - did you ...

Test your changes with

[x] REACT_APP_COUNTRY=rbd yarn start
[x] REACT_APP_COUNTRY=cambodia yarn start
[x] REACT_APP_COUNTRY=mozambique yarn start
[x] Add / update necessary tests?
[x] Add / update outdated documentation?

Screenshot/video of feature:

@wadhwamatic not sure it makes too much sense to have a validity period if it's just one day but it's up to you


Differentiate between env-hook dependencies and all-the-time dependencies

Update the dependency hook checking to differentiate between binaries that are always needed, and binaries that are needed just when running env hooks, to make life easier for concourse deployments + task docker images

Can we just do the checks in the env hooks that need them?


fix: make invalid link in apis.md pass markdown-link-check

docs: auto generate Dragonfly cli/api docs via code
Signed-off-by: Allen Sun<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

We found that when we added some invalid links in swagger.yml, the generated markdown documents will contain the invalid link, then the markdown-link-check tool will not pass the CI to show the failure:
FILE: ./docs/apis.md
[✖] http://a.b.com/fileA?user=xxx&auth=yyy
[✖] http://a.b.com/fileA

ERROR: dead links found!

This pr tries to fix the invalid link checking to use a link trimming the prefix of http(s)://.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no need.
Ⅳ. Describe how to verify it
none
Ⅴ. Special notes for reviews
none

https://github.com/tcort/markdown-link-check/blob/09952686ad865d379383b8f34e4638f977edb951/README.md#config-file-format
Maybe you don't have to change all the links, we can ignore the link check with pattern "http://a.b.com/".

If we need to ignore the link check with the pattern, do we have to provide a config json file for it? @Starnop
If the answer is yes, I think it is not a good way to add a config json file in this repo. Because it is only for CI.


could not compile

Failed to execute goal on project scoreboardstats: Could not resolve dependencies for project com.github.games647:scoreboardstats:jar:0.9.2: Failed to collect dependencies for [org.bukkit:bukkit:jar:1.7.9-R0.2 (provided), com.comphenix.protocol:ProtocolLib:jar:3.6.2-SNAPSHOT (compile?), net.milkbowl.vault:VaultAPI:jar:1.5 (compile?), net.sacredlabyrinth.phaed.simpleclans:SimpleClans:jar:2.5.3 (compile?), org.black_ixx:PlayerPoints:jar:2.1.3 (compile), com.herocraftonline.heroes:Heroes:jar:<IP_ADDRESS>-SNAPSHOT (compile?), com.gmail.nossr50.mcMMO:mcMMO:jar:1.5.01-SNAPSHOT (compile?), de.blablubbabc:insigns:jar:2.0 (system?), me.sirfaizdat.prison:Prison:jar:2.1.1 (system?), uSkyBlock:uSkyBlock:jar:2.1.0-SNAPSHOT (system?), com.massivecraft:Factions:jar:<IP_ADDRESS>-U0.1.15-SNAPSHOT (system?), com.massivecraft:factions-2.7:jar:2.7.1 (system?), com.massivecraft:mcore:jar:2.7.1 (system?), org.powermock:powermock-module-junit4:jar:1.6.2 (test), org.powermock:powermock-api-mockito:jar:1.6.2 (test)]: Failed to read artifact descriptor for com.herocraftonline.heroes:Heroes:jar:<IP_ADDRESS>-SNAPSHOT: Could not transfer artifact com.herocraftonline.heroes:Heroes:pom:<IP_ADDRESS>-SNAPSHOT from/to simpleclans-repo (http://repo.sacredlabyrinth.net/artifactory/plugins-release-local): Failed to transfer file: http://repo.sacredlabyrinth.net/artifactory/plugins-release-local/com/herocraftonline/heroes/Heroes/<IP_ADDRESS>-SNAPSHOT/Heroes-<IP_ADDRESS>-SNAPSHOT.pom. Return code is: 409 , ReasonPhrase:Conflict. -> [Help 1]

Which IDE do you have?

netbeans, using clean and build. Also check the bukkit dev page I just need a working version basically

Try to restart it. It looks like Netbeans couldn't get the the local artifacts too. It had this issue too.

doesn't change anything

Try to run it from the console

i have not slept all night can I just get a jar

I posted the link above

oh thanks ill try from command line ater

yeah same error from command line

If you have time then, could you send me the complete log.

I hope that fixes it. I have tested a lot and got the same issue after clearing my cache. It works now for me.

just heads up the nixium build is failing now

That's just a dns error. I hope it works after the next build

Its been 20 minutes on the ci, does it normally take that long? I cant compile it on my computer either Failed to execute goal on project scoreboardstats: Could not resolve dependencies for project com.github.games647:scoreboardstats:jar:0.9.2: Could not transfer artifact com.comphenix.protocol:ProtocolLib:jar:3.6.2-20141129.134032-20 from/to shadowvolt-repo (http://ci.shadowvolt.com/plugin/repository/everything/): Connection to http://ci.shadowvolt.com refused: Connection timed out: connect -> [Help 1]

No one of the repos timed out.

I'll replace it temporarily


TSC frequencies: add 250PPM tolerance

What this PR does / why we need it:
It is possible to migrate VMs to nodes that have a TSC frequency within 250PPM of theirs.
This adds support for it by tagging nodes with VMI frequencies within the tolerance range.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

TSC-enabled VMs can now migrate to a node with a non-identical (but close-enough) frequency

Draft only for now, needs tests.
/test all
@rmohr is this anything like what you had in mind? Thanks!

Did not thoroughly review it yet, but from the principle I think this is it
👍
Jed Lejosne @.***> schrieb am Do., 20. Apr. 2023, 22:53:

Draft only for now, needs tests.
/test all
@rmohr https://github.com/rmohr is this anything like what you had in
mind? Thanks!
—
Reply to this email directly, view it on GitHub
https://github.com/kubevirt/kubevirt/pull/9640#issuecomment-1516933370,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCTCXNHIINB2XKRUM6U7U3XCGO4JANCNFSM6AAAAAAXGAS3RU
.
You are receiving this because you were mentioned.Message ID:
@.***>

/cc

/lgtm
/unhold


Investigate rewriting/ditching goamz

Rationale:

we use a very small subset of the library
it's an absolutely critical component for us

Maybe we can be happier by rewriting the small subset of things that we need, and enjoy better control over our destiny.

We should just experiment with the newer and officially support go AWS SDK.  AWS has too many oddities to even own a small subset of its functionality.
https://github.com/awslabs/aws-sdk-go

Related #122

@dmcgowan Just took a look through github.com/awslabs/aws-sdk-go. Seems to cover a lot of the issues with goamz.

FYI i threw together a PR that leverages S3gof3r for part of the s3 storage drive (IMHO the most complicated part). For performance reasons, i'm only using it for streamed reading/writing.
The remaining parts should be easily replaced with the aws-sdk-go library. Not sure where else goamz is used.
https://github.com/docker/distribution/pull/693

Closing in favor of #122


fix: Add thumbprints for change in the intermediate certificate authority

Description
Add thumbprints for change in the intermediate certificate authority.
https://github.blog/changelog/2022-01-13-github-actions-update-on-oidc-based-deployments-to-aws/
Motivation and Context

Without this, configure-aws-credentials step fails.
Run aws-actions/configure-aws-credentials@v1
  with:
    role-to-assume: arn:aws:iam::9[2](https://github.com/speee/dx-platform/actions/runs/123456789012/jobs/123456789012#step:7:2)123456789012:role/terraform-github-actions
    role-session-name: gh-actions
    aws-region: ap-northeast-1
    audience: sts.amazonaws.com
Error: OpenIDConnect provider's HTTPS certificate doesn't match configured thumbprint

Breaking Changes

Nothing.
How Has This Been Tested?

[ ] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[ ] I have tested and validated these changes using one or more of the provided examples/* projects

I checked current iam-github-oidc-provider was broken.
vim .terraform/modules/iam_github_oidc_provider/modules/iam-github-oidc-provider/main.tf and fix line 18.
terraform apply and Run aws-actions/configure-aws-credentials@v1 in GitHub Actions succeeded.

[ ] I have executed pre-commit run -a on my pull request

Additional test
module "iam_github_oidc_provider" {
  # source  = "terraform-aws-modules/iam/aws//modules/iam-github-oidc-provider"
  # version = "v5.13.0"
  source = "github.com/bigwheel/terraform-aws-iam//modules/iam-github-oidc-provider?ref=patch-1"
}

I testd this patched module works well through github actions execution.

Sorry, Ignore this PR.
This problem must be caused by our office PC environment (Palo Alto certificate replacement).
I execute terraform plan in GitHub Actions and "6938fd4d98bab03faadb97b34396831e3780aea1" added twice.


[OFFICIAL/TV]* —Portugal vs USA Rugby LiVe 𝐒𝐭𝐫𝐞𝐚𝐦𝐬 FrEe BrOaDcAsT oN TV Guide & 𝐒𝐭𝐫𝐞𝐚𝐦𝐢𝐧𝐠 09 November 2024 #485 #558

**USA Rugby faces Portugal in international rugby action at 11.am. ET on Nov. 9, as the Eagles try to build their 2027 Rugby World Cup case.
Veteran names return to the squad in Flyhalf AJ MacGinty, while three selected players will look ahead to their USA Eagles debuts. USA vs Portugal kicks off on Saturday, November 9 at 11:00am ET, live on.
Three Major League Rugby rising stars earn their first international roster selection, in Shilo Klein (San Diego Legion), Tomas Casares (Miami Sharks) and 2024 first overall draft pick Erich Storti (Anthem Rugby Carolina) looking to secure USA Eagle numbers. Klein will start in the Hooker position, while Casares and Storti are named to the reserves. Casares was a late addition to the traveling roster in place of Jamason Fa’anana-Schultz. Michael Grandy of Anthem was also called into camp in place of Thomas Tu’avao.
This is the third time in as many years that the USA has competed against Portugal, the last two editions resulting in a tie and loss for the Eagles. 10 of the 23 rostered last summer will play this Saturday in the rematch, with the same balance expected from Portugal.
Head Coach and General Manager, Scott Lawrence said on the opening match, “Our goal this tour remains the same from the Pacific Nations Cup, to compete and get better each week. This Saturday is our first opportunity to do that. What we’ll take into consideration is who we’re playing and what they’re going to bring, but as always focus on our own performance objectives. Portugal is coming off an extensive Rugby World Cup campaign, so we’ll face a cohesive team that will be a good test of our focus as a young team, looking to stay switched on for all 80 minutes.”
Portugal are perhaps best remembered for being the side that won the RWC 2023 Repechage qualifier, but on that occasion the match against the USA was a draw… it wasn’t until last year in Algarve that Os Lobos recorded their first-ever win over the Eagles
this year’s Rugby Europe Championship began with calamity for Portugal as they lost 10-6 to Belgium in Mons… the Lobos recovered to finish 2nd, losing out in the final to Georgia
it’s been largely a year of transition for the Lobos as ex-Pumas coach Daniel Hourcade stepped in for the REC as a placeholder before former All Blacks flyhalf Simon Mannix formally took over the Head Coach job from Patrice Lagisquet, who stepped down after the World Cup
Portugal’s lineup is one of mixed strength… the first choice midfield is present, including long-time captain Tomás Appleton, along with star flankers José Madeira and Nicolas Martins… but among the unavailable this week are hooker Lucas Da Silva, scrumhalf Samuel Marques, and winger Lucas Martins
the Eagles are also in transition as Scott Lawrence continues to phase in some of the younger talents that are emerging in Major League Rugby… this week will see former New Zealand u20 hooker Shilo Klein making his test debut… versatile outside back Erich Storti and Miami Sharks back row Tomás Casares are uncapped inclusions on the bench… the latter is a late call-up to the squad… born and raised in Argentina, Casares qualifies through his US-born father
Bristol Bears star AJ MacGinty lines up at No10, but the USA are without Toulouse prop David Ainu’u, injured Brive lock Renger an Eerten, and Biarritz lock or back row Nafi Ma’afu among others
Eagles skipper Greg Peterson is the only specialist second row in the match day 23… Jason Damm, Vili Helu, and Casares can fill in but all typically play in the back row for their clubs
Ideal conditions look to be on the forecast which should allow for some exciting rugby. The speed of the Lobos attack was too much for the Eagles last year and could be a problem again. Set piece accuracy will be critical for the Eagles, who are lacking a top-class game-breaker out wide to match Raffaele Storti. It should be a competitive contest but Portugal are favorites at home.

desgdgvfvg


Draft: Content rating

See #114
I worked on this during GUADEC, and I am not sure if I will be able to continue working on this any further. Unfortunately I did not get it to a usable state, but I will try to note down all interesting details so someone else can pick this up and finish the remaining bits and pieces.
gnome-software worked on this a while ago and upstreamed its logic into libappstream (see https://github.com/ximion/appstream/commit/18c8b18d5a131669fa25a01d283a06f896ca438c). There are some details to this that we should consider:

In libappstream, there is a difference between an empty and a missing content rating: empty means none, missing means unknown.
They mapped each content rating item to a minimum age, then used the maximum of those. Then they used a locale-dependent rating system (e.g. ESRB for the US or FSK for Germany) to convert that minimum age to a string.
In our case, the rating system will probably depend on the Accept-Language header, which is probably fine, but not a perfect match.
Note that the mapping of content rating to a minimum age is not locale-dependent. So different cultural  ideas about things like nudity are not accounted for.
Most controversial is probably the mapping of sexual orientation. See https://gitlab.gnome.org/GNOME/gnome-software/-/blob/5f65a4a09d0892bb3b6e86ce2d02de880b8e52f5/src/gs-age-rating-context-dialog.c#L343.
libappstream also provides localized descriptions of all content ratings. I was not sure how to integrate this with flathub's approach to i18n. We could either try to hook into that. Or we could duplicate the code.
It would be nice to be able to color-code the minimum age. Unfortunately, the locale-dependent rating systems have different numbers of levels. I do not have a good idea about that yet.
For the UI, I planned to have something that is similar to what we do for content safety. My idea was to map every content rating attribute to an icon and every level to a color.
It turns out that most icon libraries do not have representations for stuff like violence-bloodshed readily available. It is probably a good idea to look into what gnome-software does.
I did not yet have time to add https://schema.org/contentRating annotations

Looks promising, work should focus on the backend part for now

kind seems to be wrong and should be type

Pushed something that has started to work, more problems are:

description doesn't get translated, do we need to do that on our end?
we set a locale which is for e.g. de, but that's not mapping clearly to a rating system so we could assume de_DE, but it might be wrong


Homekit Pin: How to find it?

Home Assistant release with the issue:

0.66
Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):

Hassbian
Component/platform:

Homekit
Description of problem:
While testing the new homekit implementation I deleted my hub from my device. Since we are only exposed to the generated pin once for the setup I can't add hass as a bridge. It will not show to add on iOS. Maybe would be a good idea to add this info to the component page.
Keep the good work!!
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
homekit:
  filter:
    include_domains: [sensor ,light]
    exclude_domains: [climate]
    exclude_entities: [sensor.my_ecobee_humidity, sensor.bedroom_temperature, sensor.My_ecobee_temperature]

Traceback (if applicable):

Additional information:

There is a persistent notification in the web UI which shows the PIN. If it doesn't show and you can't pair, you could try removing the .homekit.state file in the config folder

not find file  .homekit.state in config folder.

its a hidden file, try ls -la in the cmd

I was unable to view the persistent notification on my web-interface.
I forced a pin code for HomeKit by adding the following in configuration.yaml:
homekit:
  pincode: 123-45-678

By forcing the pin code, I was able to add the bridge to HomeKit successfully.

@NadeHouse The persistent notification was only added in 0.66.0. The pincode option is no longer supported.
If for some reason the notification didn't appear, please try restarting Home Assistant. It should be at the top. If it still doesn't show, you can try the log. Therefore please add the following to your config file:
logger:
  default: info

Than search for notification_id=4663548. The pincode should be in the same statement.

Removed the .homekit.state in the config folder and worked!
Thanks 👍


Added support for private repositories

This PR allows to set two new environment variables to enable support for private repos:

GH_TOKEN - GitHub personal access token needed to access the private repo.
PRIVATE_BASE_URL - Base URL of the update server (e.g. update.example.com).

Both are required to make hazel work with private repos.
The proxyPrivateDownload helper found in routes.js uses node-fetch to proxy the private file through hazel. This obviously leads to higher server load and increased bandwidth usage, but should be okay for this specific use case 😸

Just updated the PR 👨🔧

Thank you so much! 😍

Nice! Thank you for merging 😃

Thanks, @dominiklessel!

@leo This was unfortunately broken with this commit For private repos, browser_download_url is not used. The url from the asset object is also needed. Would you accept a PR which doesn't break #26 but also supports this?

@karanjthakkar Yep. That would be wonderful!

@dominiklessel @leo  Can you share working example for Github private repo?


Add draft title in beginning of review email message

Description
Review email messages usually begin with lines like
Reviewer: [...]
Review result: [...]

Additionally, the draft identifier is mentioned in subject, but it is often difficult to recall the correct draft immediately. For example, the list linked above recently had reviews with subjects

Dnsdir telechat review of draft-ietf-dnsop-rfc8109bis-06
Dnsdir telechat review of draft-ietf-dnsop-rfc7958bis-04

... which is not very telling.
Request: Please add another line at the beginning of the message, quoting the actual draft title.
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

First, I think it's a great idea. There is a lot of these reviews and personally I read only handful, and identifying the relevant bits takes more time than reading the parts I'm interested in.
Personally I would go even further append title to the end of Subject line because more often than not I will not even open the body - assuming I can identify the document is not relevant for me.
I.e. it would turn a Subject we have today:
Dnsdir telechat review of draft-ietf-dnsop-rfc7958bis-04

into
Dnsdir telechat review of draft-ietf-dnsop-rfc7958bis-04: DNSSEC Trust Anchor Publication for the Root Zone

Obviously the subject can become very long. I don't think it's a problem in 2024, but if it was a problem some middle ground could be found by cutting it at an arbitrary length. Say 80 chars:
Dnsdir telechat review of draft-ietf-dnsop-rfc7958bis-04: DNSSEC Trust Anchor...

Do the labels mean that a PR would be accepted for one of these approaches?

Do the labels mean that a PR would be accepted for one of these approaches?

PRs are always welcome, but the labels (particularly the "accepted" label) are a clue that they're likely to be merged rather than met with a "won't fix" for some reason.

there have been multiple threads about the subject content with the review teams, and the current compromise is the result. Putting the title in the subject (in various places) was discussed, and arguments against were made, showing how it would break or at least impair several reviewer's workflows.

Heh, I was about to submit PR which adds the title to Subject only. What about adding the title to the body text? Would that break workflow for someone? (Insert appropriate XKCD reference here :-))

Because people can mutate the form of that body text (and it varies so much between teams), the chance of automation being built that would break on that change is very low.


Issue getting heapster running within Minikube

Has anyone been able to get heapster successfully running within minikube (specifically using influxdb)?  I seem to be having some issues:
https://github.com/kubernetes/minikube/issues/743#issuecomment-259035140
Any help would be appreciated, thanks!

Got it working, closing

Could you please describe your problem and the solution? Thanks!

The problem was that I was using type: NodePort for the influxdb and heapster services (as those can be exposed via Minikube) which did not seem to work when attempting to use the services with grafana.   Changing those back to ClusterIP and exposing only grafana via NodePort did the trick.  The link in my original comment shows the logs/configuration I was using.


Update docs for TripResponse

#209  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on  Graphite

Merge activity

Oct 18, 9:06 PM EDT: A user merged this pull request with Graphite.


New static methods for creating Bezier curves

fit to polyline

fits a bezier curve of order N that passes through N dominant points on polyline and minimizes RMSD (root mean square dstance) and length difference (compared to given polyline)

join curves

fits a bezier curve through concatinated polyline representations of given curves

curve offset

fits a bezier curve through points computed as polyline representation offseted by some distance in direction of normal vector

close #37 #43
Some work done towards #41

@kturkovic you don't have to check fromPolyline method in detail, because it is refactored already on the other branch to be more efficient and stable, but that branch depends on some new functionalities that break current library interface


Fix network metadata.

Use discovered MTU in metadata as well as DHCP.
Use configured DNS server at all.
Increment interface index when there is more than one interface.

Fixes #767.

CI is expected to fail because I haven't finished setting it up yet.


remove redis.properties from the classpath

The stuff in there is really a deployment detail that not everyone would do

Closed by pr #2


Add your details in the team section.

all the contributors you can add your details in the team section.

Anubhav Singh

Github link - https://github.com/anubhavsingh16
Linkdin- https://www.linkedin.com/in/anubhav-singh-27512a167/

Aryaman Puri

Github link - https://github.com/aryamanpuri
Linkdin- https://www.linkedin.com/in/aryamanpuri/

Aashim Garg

Github link - https://github.com/aashimgarg
Linkdin- https://www.linkedin.com/in/aashim-garg-370104198/

@anubhavsingh16 can you add your photo in the assets file. :)

@Amankumar29 have a look at PR #73


Special Handling for Workflowy: Part 3

Please see Other Workflowy Related Issues
Description of Problem
In Workflowy's editor for notes it wraps links, bold, italics and underline.

Links - Links are like this [SITE]... those links then get converted to text in Atomic Chrome. They then return and get wrapped again... and so on and so on.
Formatting - Bold is like this , while italics use contentItalics and underline uses contentUnderlineMultiple formats are delimited with spaces in the class attribute, e.g., class="contentItalic contentUnderline" (as you would expect from CSS)

Solutions
All of these tags should be removed on extraction to Atom.
I'm not sure this is specific for Workflowy. Any app that loads the contentEditable with HTML should have it expunged when it's moved to Atom, I think.

Note from the author: there is this class for special Workflowy handling, in case someone wanted to fork:
https://github.com/tuvistavie/atomic-chrome/blob/master/src/content-script-tools/custom-events/workflowy.js

@drosenstark Hi, sorry this took so long!
I removed the tags when the text is extracted from Workflowy to Atom.
I tried it and it seems to work fine with link, as the links are readded after,
but the bold and italic formatting will I think be lost.
Could you give the master branch a try and tell me how it goes please?
Thank you :smile:

Testing using instructions here

Hey Daniel, thanks so much for doing this. Results:

Links are perfect
Bold/Italics are getting replaced with new-lines, which changes the content

Thanks!
Dan

On the other hand, #2 is not a showstopper, so I'd say to go ahead and push master if it's not easy to fix #2. This is already way better and resolves all the HUGE problems with recursion.
Thank you!

I see it now... it's a peculiarity of Workflowy that it puts a \n before and after any formatting. I'd say that we're good to go and publish these changes... they're very helpful and remove all of the true risks. Great work and thanks for your kind attention!


WatchOS 2: CocoaPods

When updating my project to include Parse Framework for WatchOS 2. I get the following message:
 warning:  The file reference for "Bolts.framework" is a member of multiple groups ("Products" and "Products"); this indicates a malformed project.  Only the membership in one of the groups will be preserved (but membership in targets will be unaffected).  If you want a reference to the same file in more than one group, please add another reference to the same path.
My Podfile looks like this:
use_frameworks!

target 'Design Hunt' do
	platform :ios, '9.0'
	pod 'HanekeSwift'
	pod 'Fabric'
	pod 'Crashlytics'
	pod 'Parse'
	pod 'ParseTwitterUtils'
	pod 'OneSignal'
end

target 'Design Hunt: News Extension' do
	platform :watchos
  	pod 'Parse'
end

Additionally here is the warning:
[!] [Xcodeproj] Generated duplicate UUIDs:
PBXFileReference -- /mainGroup/children/children:displayName:Bolts.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Bolts.framework,path:Bolts.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Bolts.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Bolts.framework,path:Bolts.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Haneke.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Haneke.framework,path:Haneke.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Parse.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Parse.framework,path:Parse.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Parse.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Parse.framework,path:Parse.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:ParseTwitterUtils.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:ParseTwitterUtils.framework,path:ParseTwitterUtils.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Pods_Design_Hunt.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Pods_Design_Hunt.framework,path:Pods_Design_Hunt.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Pods_Design_Hunt__News_Extension.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Pods_Design_Hunt__News_Extension.framework,path:Pods_Design_Hunt__News_Extension.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Products,isa:PBXGroup,name:Products,sourceTree:<group>,/Products/children/displayName:Bolts.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Bolts.framework,path:Bolts.framework,sourceTree:BUILT_PRODUCTS_DIR,/Products/Bolts.framework
PBXFileReference -- /mainGroup/children/children:displayName:Bolts.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Bolts.framework,path:Bolts.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Bolts.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Bolts.framework,path:Bolts.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Haneke.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Haneke.framework,path:Haneke.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Parse.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Parse.framework,path:Parse.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Parse.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Parse.framework,path:Parse.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:ParseTwitterUtils.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:ParseTwitterUtils.framework,path:ParseTwitterUtils.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Pods_Design_Hunt.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Pods_Design_Hunt.framework,path:Pods_Design_Hunt.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Pods_Design_Hunt__News_Extension.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Pods_Design_Hunt__News_Extension.framework,path:Pods_Design_Hunt__News_Extension.framework,sourceTree:BUILT_PRODUCTS_DIR,,displayName:Products,isa:PBXGroup,name:Products,sourceTree:<group>,/Products/children/displayName:Parse.framework,explicitFileType:wrapper.framework,includeInIndex:0,isa:PBXFileReference,name:Parse.framework,path:Parse.framework,sourceTree:BUILT_PRODUCTS_DIR,/Products/Parse.framework

After this building project doesn't work anymore.

Looks like the issue is not only with our framework, but exists on CocoaPods in general:
https://github.com/CocoaPods/CocoaPods/issues/4326
I would suggest trying few things:

Add Bolts as a pod dependency explciitly to both targets
Copy use_frameworks! into both groups and remove the unifying one

Let me know how it goes... Also using latest latest CocoaPods (1.0 beta) might help with the issue.


third-party lib ZIP (different in LCP client)

ReadiumSDK:
https://github.com/readium/readium-sdk/tree/develop/ePub3/ThirdParty/libzip
versus
LCP:
https://github.com/readium/readium-lcp-client/tree/android/src/third-parties/ziplib
Problem: what about the pending 64bits large ZIP file PR?
https://github.com/readium/readium-sdk/pull/106
https://github.com/readium/readium-sdk/pull/191

CC @clebeaupin

What is the provenance of the LCP ziplib?  There is no documentation there, nor a license or any indication where it came from.

https://bitbucket.org/wbenny/ziplib

...and it's actually a stream wrapper for several compression algorithms / libs, for example zlib:
https://github.com/readium/readium-lcp-client/tree/android/src/third-parties/ziplib/Source/ZipLib/extlibs/zlib


Feature/add marker with label

Description
Full credit goes to #657
Screenshots

Released v9.0.0


Issue with Semi Automatic Classification Plugin in QGIS - Python error

Help! I'm having a problem creating ROIs for a training input in QGIS. I'm using the SCP plugin but Python crashes every time I try ti create a training area ROI by drawing a polygon. I think it's a problem with the source code of the plugin, but I'm not sure.
The error message is:
WARNING: Traceback (most recent call last):
File "/Users/elenabalmaceda/Library/Application Support/QGIS/QGIS3/profiles/default/python/plugins/SemiAutomaticClassificationPlugin/dock/scpdock.py", line 1736, in pointerClickROI
self.createROI(cfg.pntROI)
File "/Users/elenabalmaceda/Library/Application Support/QGIS/QGIS3/profiles/default/python/plugins/SemiAutomaticClassificationPlugin/dock/scpdock.py", line 2848, in createROI
if cfg.np.count_nonzero(r) > 0:
UnboundLocalError: local variable 'r' referenced before assignment

**OS: MacOs
**QGIS version: 3

Italian Marble Suppliers in Delhi
Indian Marble Suppliers
Granite Slab Suppliers
Tiles Suppliers in Delhi
Kota Marble Suppliers


Add testing RC git action job

This PR adds convenience to test Provider RC releases with SDK by adding a GitHub job which raises PR from the GitHub issue.

@utkarsharma2 does this PR still require, we added a workflow in PR https://github.com/astronomer/astro-sdk/pull/1995 and @Lee-W is working on https://github.com/astronomer/astro-sdk/pull/2009 to clean up and resue the provider workflow


Improve README.md

Suggest improving README.md as a jumping in point and lite documentation for the context
Things that may be included

[ ] Badges
[ ] Introduction
[ ] Status of work
[ ] Vocabs used
[ ] Terms used in each vocab
[ ] Links to spec, community group and mailing list etc.

Add links to the following existing works:

W3C Verifiable Credentials: https://www.w3.org/TR/vc-data-model/#json-ld

W3C Web Annotations:
https://www.w3.org/TR/annotation-model/#serialization-of-the-model

W3C Activity Streams 2.0:
https://www.w3.org/TR/activitystreams-core/#jsonld

AS context: https://github.com/jasnell/activitystreams-context/blob/master/context.json


Bug fix: Make examples more compatible with Mac

Description
Fixing some issues in the notebooks that caused failures on MacOS and in Nox sessions.
Changes:

Changed %pip install pybamm[plot,cite] -q to %pip install "pybamm[plot,cite]" -q in the notebooks. This prevents failures on MacOS.
Fixed the temporary file name in the quick plot function create_gif() function. Running nox -s examples had failures due to "file not found" errors. The function would use the same file names on different threads creating a race condition.

Type of change
Minor bug fixes in the notebooks.

[x] Bug fix (non-breaking change which fixes an issue)

Key checklist:

[x] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[x] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[x] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).
Further checks:

[x] Code is commented, particularly in hard-to-understand areas
[x] Tests added that prove fix is effective or that feature works

This will likely cause conflicts with #3372, but I will fix them if that happens.

It looks like keras moved the callbacks.py script. The link no longer works and was detected by Lychee. I can push a fix for that too if it helps this pass.

Broken link fixed. Can this be re-triggered for CI?

@Saransh-cpp done

@kratman could you please also edit the relevant tests to ensure this does not happen in the future? Setting output_filename in the tests should be good!
https://github.com/pybamm-team/PyBaMM/blob/fc570af4999274e90cc9ce356be58476be16f779/tests/unit/test_plotting/test_quick_plot.py#L292-L296

@kratman could you please also edit the relevant tests to ensure this does not happen in the future? Setting output_filename in the tests should be good!
https://github.com/pybamm-team/PyBaMM/blob/fc570af4999274e90cc9ce356be58476be16f779/tests/unit/test_plotting/test_quick_plot.py#L292-L296

I will make that change as well. I think the tests should write to temporary directories though. I notice that the tests leave a lot of files behind when I run them.

That sounds great, thanks again, @kratman! 🙂


SQLPackage?

Would be nice to have a link to SQLPackage, in particular how to get it/install it

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cd85890a-ccba-8697-b406-b662aabeb27f
Version Independent ID: a1d371df-c0a0-1cd6-37f8-4b60913a2e97
Content: Azure SQL database deployment - Azure Pipelines & TFS
Content Source: docs/pipelines/targets/azure-sqldb.md
Product: devops
GitHub Login: @alexhomer1
Microsoft Alias: ahomer

Thank you for your feedback. I will update the topic to include your recommendations.


Extract Lint Rules into Standalone Package

The lint rules included in CRA are helpful for helping find potential bugs. It does so while not governing over code style.
I recommend these rules to be extracted and implemented in their own package to allow for use outside of CRA and to allow for community development of these rules.

Yea, totally. Will do that after we land monorepo configuration PR.

Implemented in #689.


11.02 FUTURE SUPPORT.

When will that exploit support 11.02 when that firmware is my PS4’s?

When will that exploit support 11.02 when that firmware is my PS4’s?

Never, gotta wait for a new one


Add a README file

Create a README.md file to give a overview about this repo

TODO

Create private website in GitHub
Upload more project

TreeHouse Projects
Private Projects


[Documentation]capitalized first letter of sentence

What kind of change does this PR introduce?
In general, we should capitalize the first word, all nouns, all verbs (even short ones, like is), all adjectives, and all proper nouns. That means you should lowercase articles, conjunctions, and prepositions.

Did you add tests for your changes?

Does this PR introduce a breaking change?

What needs to be documented once your changes are merged?

@snitin315 (sorry to pin you)
I am new to open source, and I am willing to learn new technologies,
Is webpack community have any malling list or discord server,
where can join and ask my doubt and communicate with contributors ?

Thanks

@sokra (sorry for pin), i wanted to ask is there any communication channel/server for webpack contributors like discord or slack ?


ARCHIVE FAILED: initializer element is not a compile-time constant

Hey there, I receive this error when trying to archive on our CI:
 ✗ node_modules/bugsnag-react-native/cocoa/vendor/bugsnag-cocoa/Source/BugsnagNotifier.m:[50,42] initializer element is not a compile-time constant
6395
    » NSString *const BSAttributeBreadcrumbs = BSGKeyBreadcrumbs;
6396
    »                                          ^~~~~~~~~~~~~~~~~
6397
    ** ARCHIVE FAILED **
6398
    The following build commands failed:
6399
        CompileC /tmp/sandbox/5857df94fd675501000961e3/bbbuild/Build/Intermediates/ArchiveIntermediates/AcuityApp/IntermediateBuildFilesPath/Bugsnag.build/Release-iphoneos/BugsnagStatic.build/Objects-normal/armv7/BugsnagNotifier.o node_modules/bugsnag-react-native/cocoa/vendor/bugsnag-cocoa/Source/BugsnagNotifier.m normal armv7 objective-c com.apple.compilers.llvm.clang.1_0.compiler

I'm using bugsnag-react-native:"2.5.3"
Thank you.

Consolidating into https://github.com/bugsnag/bugsnag-react-native/issues/176


rewrite reified generic

so basically:

generic aliases werent able to be subtyped properly without the reified generic being lost, so i instead made ReifiedGeneric.__class_getitem__ create a copy of the class with the reified generics added to it
i renamed __parameters__ to __type_vars__ for 2 reasons

the Generic class overwrites the __parameters__ property with an empty tuple when copying the class for some reason, which makes it a huge pain to work with
__type_vars__ is much more descriptive of what the property actually is - un-reified instances of TypeVar

while i was at it i renamed __args__ to __reified_generics__ for the same reason

this implementation makes NoParametersError and NotReifiedParameterError even more ambiguous than it already was, such that in some circumstances you can't really tell whether a generic can't be reified because its type parameters weren't provided at all, or if they were all TypeVars. for this reason i merged the two errors into a single class (NotReifiedError)

closes #18

@DetachHead Want to review my latest commit, if you're happy then merge it 😁

lgtm moment


Files are not properly saved when using different file name

I used a different naming convention. When working with the default f"./AoT {chapter.num}.pdf", download works. However, when I change it to f"./AoT {chapter.title}.pdf", I get a blank file called "AoT Vol.1 Chapter 1" without any extension.
My guess is that since the chapter.title is
'Vol.1 Chapter 1: To You, 2,000 Years From Now'
and the blank file name is
'AoT Vol.1 Chapter 1',
the downloadchapter.py script somehow doesn't work well with : in the filename.
My script for reference (used only to save the first chapter)
from manganelo import SearchManga,  MangaInfo, DownloadChapter
import os

search = SearchManga("Attack on Titan", threaded=False)
results = search.results
best_result = results[0]
manga_info = MangaInfo(best_result.url, threaded=False)
manga_page = manga_info.results

file = f"./AoT {manga_page.chapters[0].title}.pdf"
dl = DownloadChapter(manga_page.chapters[0].url, file)
results = dl.results
if results.saved_ok:
    print(results.path, results.percent_saved)

Hi, nice catch. This was because Windows does not allow a small subset of characters to be in file names. I have added a quick string replace to remove them if they exist. I will update the PyPi version to 1.16.1 shortly.


Descriptions are terrible as it is just mashing markdown text together

We should remove the descriptions or make short descriptions for pages as the current behavior is horrible of mashing markdown text together.

I think this can also be closed right? Adding summary metadata overrides the default mashing.
https://github.com/dwsmith1983/recommend-resources/blob/f66732ed78e19426406574421fad633864e9a437/content/posts/recommendations.md?plain=1#L5


[KYUUBI #2419] Destroy the ProcBuilder process and call killApplication during closing session

Why are the changes needed?

close #2419
We need to clean up the ProcBuilder process and engine application when the session is closed.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #2482 (4fe3c2f) into master (7b70a6a) will increase coverage by 0.09%.
The diff coverage is 71.42%.

:exclamation: Current head 4fe3c2f differs from pull request most recent head ae8be05. Consider uploading reports for the commit ae8be05 to get more accurate results

@@             Coverage Diff              @@
##             master    #2482      +/-   ##
============================================
+ Coverage     63.46%   63.55%   +0.09%
  Complexity       69       69
============================================
  Files           371      371
  Lines         17582    17592      +10
  Branches       2345     2346       +1
============================================
+ Hits          11158    11181      +23
+ Misses         5392     5374      -18
- Partials       1032     1037       +5

Impacted Files
Coverage Δ

.../org/apache/kyuubi/session/KyuubiSessionImpl.scala
75.34% <0.00%> (-1.05%)
:arrow_down:

...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala
82.71% <50.00%> (+1.46%)
:arrow_up:

...ain/scala/org/apache/kyuubi/engine/EngineRef.scala
76.92% <83.33%> (+0.15%)
:arrow_up:

...g/apache/kyuubi/operation/BatchJobSubmission.scala
72.60% <100.00%> (+0.77%)
:arrow_up:

...rg/apache/kyuubi/engine/trino/TrinoSqlEngine.scala
59.64% <0.00%> (+7.01%)
:arrow_up:

...pache/kyuubi/engine/KyuubiApplicationManager.scala
86.36% <0.00%> (+20.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b70a6a...ae8be05. Read the comment docs.

@wForget thank you for the contribution, I think the title should be refine to:
Release engine during closing kyuubi server session if share level is connection ?

thanks, merging to master


📝 Highlight lines correction

Fix code highlight in https://sqlmodel.tiangolo.com/tutorial/indexes/

Hi @shenxiangzhuang,
Thank you for being so interested in contributing to SQLModel! Indeed, there was a mistake, the full preview shouldn't have highlights. :sweat_smile:
This has been addressed in #1100. Thanks!


HDDS-6391. ClientVersions and DatanodeVersions class to define an enum with version and description

What changes were proposed in this pull request?
As discussed in the proposal for HDDS-6390, this PR is to change int constants defined in ClientVersions and DatanodeVersions class to enums, providing the same functionality with an int version number, and a description field.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6391
How was this patch tested?
Same tests via CI should cover the changes. No new tests were added.

Good points @errose28.

I also wanted to suggest using the enum type as parameter instead of int, but we have to consider the "newer than any versions this component is aware of (i.e. has enum constants for)" case.  Do we create a FUTURE_VERSIONS(Integer.MAX_VALUE) enum constant for that case?  At least we should have an overloaded version.

I have already found a case where the wrong version is being passed unintentionally (HDDS-6418).

Regarding {Shared,External,Advertised,Broadcasted}DatanodeVersion: I'm not sure why plain DatanodeVersion would imply that it is internal.

ComponentVersion might be a good name for the common interface.

The discussion we had about CURRENT_VERSION is mostly implementation-specific.  The point is that we should have a constant rather than a (very slightly expensive) method.

Having to pass ClientVersion.CURRENT_VERSION when constructing protos on the server side is a bit confusing, but it looks like an unfortunate consequence of using the same protos for internal processing and client communication.

It might also indicate a case where client version is ignored (and could result in compatibility problem).

Thanks for the reply @adoroszlai

but we have to consider the "newer than any versions this component is aware of (i.e. has enum constants for)" case. Do we create a FUTURE_VERSIONS(Integer.MAX_VALUE) enum constant for that case?

Yeah this is tricky. At least by providing a FUTURE_VERSION enum value, we are acknowledging the existence of future versions. There's nothing with the int that suggests to people using it they may see a value larger than CURRENT_VERSION. I think adding this enum constant would be a good idea, along with maybe a helper in the enum to go from the int version to the enum value. This would return the FUTURE_VERSION enum member when an int larger than CURRENT_VERSION is given.

Regarding {Shared,External,Advertised,Broadcasted}DatanodeVersion: I'm not sure why plain DatanodeVersion would imply that it is internal.
ComponentVersion might be a good name for the common interface.

I was mostly just looking to add some sort of descriptor to distinguish this version from layout versions. As you suggested, "component version" may be a good name. I think something like DatanodeComponentVersion implements ComponentVersion would serve this purpose. This gives us unique terminology to use in explanations, for example "Layout version is used to track the format of on disk data. Component version is used to determine compatibility between components"

Thank you for the reviews, I went down deeper into the code that is touched by this PR, and I found a couple of issues that we have to address, and I think I have kind of a plan.
So, currently we have the problem listed by Attila in HDDS-6418.
Besides that I have found that the container operation client uses the client version, but in that case the Ozone Manager is the client, so that has to be changed if we have committed the OzoneManagerVersion class.
There is the Balancer, there is the ReplicationManager which are also using the ClientVersion now, and I am 99% sure that they should not.
There is PipelineManager which also provides the ClientVersion.CURRENT_VERSION to a toProto method, which is certainly not right similarly as it is not right in HDDS-6418.
On the other hand, you are right, the problem when a new client is connecting is real, and a FUTURE_VERSION or something has to be added. I think the version number of the FUTURE_VERSION constant should be -1, and that should be the 0th ordinal in the enum, so that does not leads extra code during latest version calculation.
The version difference check is a bit tricky this way though, but it can be done for example this way:
(clientversion & Integer.MAX_VALUE) > serverversion -> newer client
I am adding utility methods to compare the versions into the base class that is proposed for the enums, and refresh the PR shortly.
Because of the problems with the usage of ClientVersion and DatanodeVersion, I would like to suggest to go and commit this PR first, and in the meantime I will file follow up JIRAs to review the usage of these, and then while we are unblocked to continue with FSO and EC and start to use these changes, while we also can aim to switch to enum usage wherever it is appropriate in the current code where we need to fix things anyway. What do you think?

@fapifta compile fails because recently merged HDDS-6379 added more usage of ClientVersions.CURRENT_VERSION in TestPipelinePlacementPolicy.

License header is also missing from ComponentVersion.

I hope I have fixed all the issues, will be back to check in an hour, thanks for checking @adoroszlai

Hi @errose28,
thank you for the review and for the suggestions, I think the suggested design is way better than we had initially, so I have implemented the suggested changes, and fixed the comparisons I could find.
Also thank you @adoroszlai for the discussions before, and the reviews.
I think the reasonable next step is to switch to use the enum wherever we can, and just translate it to int over the wire in a separate JIRA, though before doing so, I would like to take a quick experiment with an idea to reduce the number of times we need to pass on the version because of DatanodeDetails#toProto. Based on the experiment results, I will create the follow up JIRAs tomorrow.
After that and when this PR goes in you can expect an update on the OzoneManagerVersion related PR, and then I will also post the PR that introduces the usage of the OzoneManagerVersion.


12 proposed words

Here are some words I tried to use in the game Shingo!, but were not deemed valid words:
𐑐𐑬𐑑𐑦	pouty
𐑑𐑿𐑚𐑛	tubed
𐑴𐑤𐑛𐑦	oldie
𐑥𐑧𐑛𐑟	meds
𐑛𐑲𐑯𐑴𐑟	dinos
𐑛𐑧𐑓𐑴𐑟	defos
𐑛𐑰𐑝𐑩𐑟	divas
𐑛𐑰𐑐𐑴𐑟	depots
𐑥𐑿𐑟𐑦𐑙𐑟	musings
𐑓𐑱𐑝𐑦𐑙	faving
𐑱𐑕𐑦𐑙	acing
𐑥𐑵𐑛𐑚𐑹𐑛	moodboard

The ReadLex revision is from 2023-05-21 10:15:03.
Thank you for your time!

'Defos'?

Slang term for “definitely”, a variation of “deffo” or “defo”

I've added these words except 'defos'. I'm holding off adding any more fairly obscure slang until I decide how to record it. Not sure if I need to add an 'informal' marker or the like, and whether to link it to the 'proper' headword in some way.
Also, 'depot' was already in the ReadLex. It would be worth checking the Latin before suggesting words. In this case, I didn't have the GenAm pronunciation in Shavian which I added because it is widespread in General American English, but I'm not keen to spend too much time adding different pronunciations in general.


Visuals show "No data"

I have the following setup

CUR report exported to management account s3 bucket
CUR report is replicated to monitoring account s3 bucket
QuickSight Enterprise is setup in monitoring account
Followed the automatic setup scrips for cudos dashboards and made sure all prerequisites are done (standard prerequisite, not the multi-payer)

After this, the dashboards should be ready.
However, when opening up the dashboard for the first time, a LOT of the visuals showed "No data".
So I figured I should leave it for a few days.
However, after 6 days, the visuals still show "No data"
For a lot of the visuals  guess this is normal (all visuals for previous months).
However, for other visuals, e.g.

data transfer
Top 10 spending accounts by total cost. (multiple of these)
All the Cost by purchase option

the dashboard still shows "No data"
It is not easy to debug this, but I have

queried athena to verify I get data
open up the QuickSight datasets for verify I get data

Also, I cannot find the dashboard template (arn:aws:quicksight:us-east-1:223485597511:template/cudos_dashboard_v3), which (maybe?) could have helped me figure out how the visuals are configured.
Maybe related
Yesterday I noticed 100+ ThrottlingException/RateExceeded for the Athena GetQueryExecution api call.
After each reload of the dashboard this number increased with approx 5-10

if the CUR is new that is expected as the data is mostly visualised for the previous 30 days/couple of month. You might get a CUR backfill if you file a request via support center


Compatibility issue with fancyBox3

If the textarea is located inside of a fancyBox pop-up, it makes the textbox un-usable. You need to right click on it for it put the cursor into the textarea or click the emoji button. Backspace is unusable within the textarea and just closes the fancyBox pop-up.
I edited your fiddle to show this issue:
https://jsfiddle.net/1v03Lqnu/
The other thing is that I am wondering if it is possible to limit the number of emojis they can insert. For example, I only want one emoji to be inserted?
Thanks!

The other thing is that I am wondering if it is possible to limit the number of emojis they can insert. For example, I only want one emoji to be inserted?

No, currently where is no such functionality.

If the textarea is located inside of a fancyBox pop-up, it makes the textbox un-usable. You need to right click on it for it put the cursor into the textarea or click the emoji button. Backspace is unusable within the textarea and just closes the fancyBox pop-up.

Backspace used in fancyBox, you need to disable it in fancyBox, maybe also some stylesheets of fancyBox make effect on emojioneArea.
I don't see this issue on https://jsfiddle.net/1v03Lqnu/, seems like it still mine version

My apologies.
Here is my fiddle: https://jsfiddle.net/o24gyeba/
If I use a normal textarea in fancyBox3, I am able to backspace normally.

I fixed your issue with non usable emojionearea, add this lines to your stylesheet:
#posting-form {
    overflow: initial;
}
.emojionearea + button.fancybox-close-small {
  display: none;
}

Example: https://jsfiddle.net/o24gyeba/1/

Oh thank you! Sorry for my late response, didn't check since I closed it!


Fix translate to portuguese bash guide.

Remove whitespaces and fix indentation also on part from english version.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


simpler definition of custom charge

in BaseCharge.__init__, set self.charge_types to [type(self)] if charge_types=None is passed.
This eliminates the neccessity for the user to write their own init in derived classes

let's actually wait with this. I wan't test it a bit more

Oh no missed your comment. That's ok, feel free to add more testing in the next PR

np  :)


[bug] Generated code from ML.Net ModelBuilder doesn't work (throws OperationCanceledException)

System information

OS version/distro: Microsoft Windows Server 2016 Datacenter 10.0.14393 Build 14393
.NET Version (eg., dotnet --info): 3.1.301

Using AWS Workspace.
Issue

What did you do? I used the ML.Net ModelBuilder (https://docs.microsoft.com/en-us/dotnet/machine-learning/automate-training-with-model-builder). I chose a scenario, selected my features/label, trained the model and generated the code with the new model trained.
What did you expect? I was able to load the model saved and create new predictions with it. However, when I tried to retrain the model, using the ConsoleApp project generated by ML.Net Builder, it throws OperationCanceledException in the process. More specifically, I call the method "CreateModel()" from the class ModelBuilder in the ConsoleApp project (that is generated automatically by ML.Net Model Builder when you want to generate the code), then it trains the model but there's always a OperationCanceledException that is thrown. It seems to happen in the method SaveModel, but the path used for the model is correct, so I don't think it's a path issue..

Source code / logs
Logs when I use ML.Net ModelBuilder tool (which worked fine)

Image of what happens when I try to run the console app project generated by ML.Net ModelBuilder tool

Hi @Jonathan-CG This bug appears to be about code generated from Model Builder. So I am transferring this to the model builder repo.

Yes you are right. As for the issue I'll have to create a blank new project with new data because the one we're using is confidential. But to reproduce the issue you just need to use the Model Builder, use the Generate Code button and try to run the code generated from ModelBuilder by doing ModelBuilder.CreateModel() and it should crash.
I'll try to make a blank new project by EOW.

@Jonathan-CG
Sorry for the late reply, let me know when your blank project is ready. Thanks

Close this because we shouldn't have this bug any more since we move to the new code gen


Update INSTALL.md

This is a very minor change, but it'll definitly help the New-Commers like me.
Sorry, client-go does not accept changes via pull requests at this time. Please
submit your pull request to the main repository:
https://github.com/kubernetes/kubernetes.  See the guidance here:
https://github.com/kubernetes/client-go#contributing-code.

This change is

I have signed the CLA.

/lgtm


Undefined symbols for architecture arm64

I already add '-lc++' to the other linker flag but still got the following errors. Can someone help take a look please :)
Undefined symbols for architecture arm64:
"cv::Exception::Exception(int, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, int)", referenced from:
best_line_for_sample(_IplImage*, unsigned char) in libCardIOSDK.a(dmz_all.o)
llcv_equalize_hist(_IplImage const*, _IplImage*) in libCardIOSDK.a(dmz_all.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

share iOS version , Xcode Version , and iOS SDK detail.

I am getting this error with iOS 11.2, Xcode 9.2, with the iOS 11 SDK.


[FEATURE] make releases with the plugins

Describe the feature / change you'd like.
The plugins have no releases or no recent functioning releases. That's ALL of them, this is why i report this here.
Additional context:
A release signals witch version users should be using.

Yeah sorry about that. I assume you're using releases for packaging. I'm usually late with releases but soon I'll update them and keep them up to date.
@r3tr0ananas also when you release a pypi release for plugins remember to also do a GitHub one.
You can leave the mov-cli GitHub releases to me.

@r3tr0ananas also when you release a pypi release for plugins remember to also do a GitHub one.

A github release has been pushed everything. I don't know how the debian packages work. Typically on arch, python packages are packaged in a way it just grabs the source files from the github releases page.
So as long as that is updated, releases will pull in. Idk what is the case with the debian packages as we aren't the one's packaging them.

I mean, i'm not part of the official distro, i'm just a user making packages for the equivalent of a AUR for debian.

So you are making the packages on the mpr, as I understand correctly?

This is a big cultural difference with windows. I'm assuming you are windows guys.
a Linux distro has basically an official "app store" called repository, with open source software packaged by the maintainers of the distro it self. This doesn't exist in windows. The equivalent would be for microsoft it self to package a bunch of software for windows. From python, gcc and the kernel to chromium and firefox.... And all that is managed by a package manager keeping track of what's installed, the dependencies and keep stuff compatible, that too doesn't exist in windows. In linux you can upgrade everything with one command, from the kernel to soduku. Instead of every software having it's own way to upgrade it self. It's a disgrace that microsoft didn't copied this system.
Additional to the official "appstore" there are also user generated packages/repositories by random people on the internet. I'm just a random person on the internet that packaged mov-cli.
Long story short, package management in linux is extremely good, and linux users are totally addicted to it. And this is why i rather package mov-cli rather then use pip.


[docker] Should we start the daemon as part of the install?

Probably?
Currently, testing the version blows up:
+ docker version
Client: Docker Engine - Community
 Version:           20.10.17
 API version:       1.41
 Go version:        go1.17.11
 Git commit:        100c701
 Built:             Mon Jun  6 23:02:46 2022
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

https://dev.to/bowmanjd/install-docker-on-windows-wsl-without-docker-desktop-34m9

sudo usermod -aG docker $USER

Need to do magic to find correct $USER


Filtering terms results examples listed following tendency

I think examples in json should be like:
"examples": [
    ["individual", "biosample", "analysis", "run", "genomicVariation"],
    ["biosample"]
]

Perfect. Thank you @redmitry. Can you accept your changes?


Reposition Thumbnail Preview in Metadata Editor

This moves the thumbnail preview to be alongside both the Description and Thumbnail URL inputs.  Currently, alongside the tags, it can obscure the tag badges if enough of them are added.
In this PR the thumbnail also shifts down below the URL input if the width is reduced to a certain point.
If this PR sits for too long unmerged, I may also take another stab at making the labels shift above the fields at a certain breakpoint.

Is this ready for review?

Yeah... this is acceptable. I'll merge it. :100:


Make the command prefix a variable

And even better, something admins can only change

Looks like this is imposible as it's server-wide

im gay


#1870 fix

Q
A

Bug fix?
[X]

Related issues?
fixes #1870

What's in this Pull Request?
PR fixes an issue with filtering when using calculated column as columnInternalName in ListItemPicker.

@wilecoyotegenius Thank you for the fix

🎉✨ Woohoo! ✨🎉
Thank you @wilecoyotegenius for your awesome contribution to the community with this merged PR! 🚀 You've earned a Credly badge through the Microsoft 365 & Power Platform Recognition Program. 🏅 To receive your badge, please take a moment to opt in to the program. You can learn more and sign up here: https://aka.ms/community/recognition.
Can't wait to see you in the program! 🎊
Cheers,
David Warner 🧡💜
cc: @joaojmendes

Dear @PopWarner, thank you for the recognition. Much appreciated.
I have just opted in to the program.
Looking forward to that Credly badge :)


Empty post when results get a post the logged account can't access (loli, shota, etc)

I'm not entirely sure what you mean, can you provide an example of a booru + tag(s) that cause this?

doing booru.search("a", { limit: 1000, random: true }), there will be an empt post which has a loli tag and then the library fails in post.js constructor

That shouldn't be returning anything at all, it should be throwing errors
"a" isn't a valid site, so you'd get BooruError: Site not supported
The second parameter should be tags, not search settings, so you'd get BooruError: `tags` should be an array or string
Trying out that snippet gives me those two errors and no empty post

(Using a valid site)

My bad, i was using an old version, now i updated the library and everything is working fine, except i have to delete the export default booruForSite; line in index.d.ts so my TypeScript code will compile and run well, i already made a PR #50
Thx Anyways

That's odd, index.d.ts is auto-generated so I'll have to dig into that later to fix the root cause. Glad to see it works now though.


Jacqueline Binya GSOD-2020 Application

Signed-off-by: JackieBinya<EMAIL_ADDRESS>

Hi @JackieBinya
Can you please resolve the merge conflicts if possible?
Let me know if you need any help. :slightly_smiling_face:

@vchrombie
May you please review my commit, I am not sure if I was able to do what you requested.
Thanks.

Thanks @JackieBinya
It looks perfect. :slightly_smiling_face:

Thanks @JackieBinya  and @vchrombie


Resolve issues with multiple versions of GCC installed on Mac OS X

Build triggered. sha1 is merged.

Build finished. No test results found.

Refer to this link for build results (access rights to CI server needed):
/job/libnd4j_PR/145/