Mac mini Mid 2010: GPU not recognized (MCP89)

On Mac mini Mid 2010 (Macmini4,1) the NVIDIA GeForce 320M GPU is not recognized correctly by initgfx on the helloSystem 0.7.0 Live ISO.
10de:08a4:106b:00c0

MCP89 [GeForce 320M]

Possibly GeForce 320M needs to be added to nvidia_340_ids.

Possibly GeForce 320M needs to be added to nvidia_340_ids.

https://bsd-hardware.info/?id=pci:10de-08a4-106b-00c0 says "You need to install the following additional drivers for the device to work properly: nvidia (from 295.75 to 340.108)"

https://bsd-hardware.info/?id=pci:10de-08a4-106b-00c0 says "You need to install the following additional drivers for the device to work properly: nvidia (from 295.75 to 340.108)"

https://github.com/nomadbsd/NomadBSD/commit/102978820e45b50205759b3bb76b82a1e802774b says:

Ignore GeForce 320M. Trying the NVIDIA drivers on it lead to a system crash on a MacBook Air.

https://github.com/nomadbsd/NomadBSD/commit/102978820e45b50205759b3bb76b82a1e802774b says:

Ignore GeForce 320M. Trying the NVIDIA drivers on it lead to a system crash on a MacBook Air.

https://forums.developer.nvidia.com/t/crash-on-freebsd-11-2-with-nvidia-driver-340-107-on-geforce-320m/63750 says:

Here are the interesting bits from the kernel dump (let me know if you want to see all of it)

https://forums.developer.nvidia.com/t/crash-on-freebsd-11-2-with-nvidia-driver-340-107-on-geforce-320m/63750 says:

Here are the interesting bits from the kernel dump (let me know if you want to see all of it)

Adding GeForce 320M to nvidia_304_ids does not lead to the crash. nvidia.ko gets loaded but Xorg is still using scfb.

Adding GeForce 320M to nvidia_304_ids does not lead to the crash. nvidia.ko gets loaded but Xorg is still using scfb.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233069

Please try with the latest update to 430.50 in ports r516138.

@danfe in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233069

Yes, SUB_FILES were not adjusted in the update to 410.104.  Please try with the latest update to 430.50 in ports r516138.

I wonder whether @tehpeh ever got it to work...

When I add GeForce 320M to nvidia_latest_ids here, then I get:
Jan  2 15:55:30 Macmini4,1 kernel: initgfx: Creating new configuration ...
Jan  2 15:55:30 Macmini4,1 kernel: initgfx: Auto-detecting graphics driver ...
Jan  2 15:55:30 Macmini4,1 kernel: MCP89 [GeForce 320M] ~ GeForce 320M
Jan  2 15:55:30 Macmini4,1 kernel: tar: could not chdir to '/usr/local/nvidia/latest/usr/local/lib/xorg/modules/extensions/.nvidia'
Jan  2 15:55:30 Macmini4,1 kernel:
Jan  2 15:55:30 Macmini4,1 kernel: initgfx_kmods:  -> /usr/local/nvidia/latest/boot/modules/nvidia.ko /usr/local/nvidia/latest/boot/modules/nvidia-modeset.ko
Jan  2 15:55:30 Macmini4,1 kernel: initgfx: Testing Xorg configuration ...
Jan  2 15:55:30 Macmini4,1 kernel:
Jan  2 15:55:30 Macmini4,1 syslogd: last message repeated 1 times
Jan  2 15:55:30 Macmini4,1 kernel: X.Org X Server 1.20.11
Jan  2 15:55:30 Macmini4,1 kernel: X Protocol Version 11, Revision 0
Jan  2 15:55:30 Macmini4,1 kernel: Build Operating System: FreeBSD 13.0-RELEASE-p5 amd64
Jan  2 15:55:30 Macmini4,1 kernel: Current Operating System: FreeBSD Macmini4,1 13.0-RELEASE FreeBSD 13.0-RELEASE #0 releng/13.0-n244733-ea31abc261f: Fri Apr  9 04:24:09 UTC 2021     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64
Jan  2 15:55:30 Macmini4,1 kernel: Build Date: 13 November 2021  07:49:12AM
Jan  2 15:55:30 Macmini4,1 kernel:
Jan  2 15:55:30 Macmini4,1 kernel: Current version of pixman: 0.40.0
Jan  2 15:55:30 Macmini4,1 kernel: 	Before reporting problems, check http://wiki.x.org
Jan  2 15:55:30 Macmini4,1 kernel: 	to make sure that you have the latest version.
Jan  2 15:55:30 Macmini4,1 kernel: Markers: (--) probed, (**) from config file, (==) default setting,
Jan  2 15:55:30 Macmini4,1 kernel: 	(++) from command line, (!!) notice, (II) informational,
Jan  2 15:55:30 Macmini4,1 kernel: 	(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
Jan  2 15:55:30 Macmini4,1 kernel: (==) Log file: "/var/log/Xorg.0.log", Time: Sun Jan  2 14:54:20 2022
Jan  2 15:55:30 Macmini4,1 kernel: (++) Using config directory: "/tmp/initgfx.360"
Jan  2 15:55:30 Macmini4,1 kernel: (==) Using system config directory "/usr/local/share/X11/xorg.conf.d"
Jan  2 15:55:30 Macmini4,1 kernel: (EE)
Jan  2 15:55:30 Macmini4,1 kernel: Fatal server error:
Jan  2 15:55:30 Macmini4,1 kernel: (EE) no screens found(EE)
Jan  2 15:55:30 Macmini4,1 kernel: (EE)
Jan  2 15:55:30 Macmini4,1 kernel: Please consult the The X.Org Foundation support
Jan  2 15:55:30 Macmini4,1 kernel: 	 at http://wiki.x.org
Jan  2 15:55:30 Macmini4,1 kernel:  for help.
Jan  2 15:55:30 Macmini4,1 kernel: (EE) Please also check the log file at "/var/log/Xorg.0.log" for additional information.
Jan  2 15:55:30 Macmini4,1 kernel: (EE)
Jan  2 15:55:30 Macmini4,1 kernel: (EE) Server terminated with error (1). Closing log file.
Jan  2 15:55:30 Macmini4,1 kernel: /usr/local/bin/xinit: giving up
Jan  2 15:55:30 Macmini4,1 kernel: /usr/local/bin/xinit: unable to connect to X server: Network is unreachable
Jan  2 15:55:30 Macmini4,1 kernel: /usr/local/bin/xinit: server error
Jan  2 15:55:30 Macmini4,1 kernel: initgfx: Failed to use nvidia driver. Trying nv ...
Jan  2 15:55:30 Macmini4,1 kernel: eval: nv_xorg_cfg: not found
Jan  2 15:55:30 Macmini4,1 kernel: initgfx: Testing Xorg configuration ...
Jan  2 15:55:30 Macmini4,1 kernel:
Jan  2 15:55:30 Macmini4,1 syslogd: last message repeated 1 times
Jan  2 15:55:30 Macmini4,1 kernel: X.Org X Server 1.20.11
Jan  2 15:55:30 Macmini4,1 kernel: X Protocol Version 11, Revision 0
Jan  2 15:55:30 Macmini4,1 kernel: Build Operating System: FreeBSD 13.0-RELEASE-p5 amd64
Jan  2 15:55:30 Macmini4,1 kernel: Current Operating System: FreeBSD Macmini4,1 13.0-RELEASE FreeBSD 13.0-RELEASE #0 releng/13.0-n244733-ea31abc261f: Fri Apr  9 04:24:09 UTC 2021     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64
Jan  2 15:55:30 Macmini4,1 kernel: Build Date: 13 November 2021  07:49:12AM
Jan  2 15:55:30 Macmini4,1 kernel:
Jan  2 15:55:30 Macmini4,1 kernel: Current version of pixman: 0.40.0
Jan  2 15:55:30 Macmini4,1 kernel: 	Before reporting problems, check http://wiki.x.org
Jan  2 15:55:30 Macmini4,1 kernel: 	to make sure that you have the latest version.
Jan  2 15:55:30 Macmini4,1 kernel: Markers: (--) probed, (**) from config file, (==) default setting,
Jan  2 15:55:30 Macmini4,1 kernel: 	(++) from command line, (!!) notice, (II) informational,
Jan  2 15:55:30 Macmini4,1 kernel: 	(WW) warning, (EE) error, (NI) not implemented, (??) unknown.
Jan  2 15:55:30 Macmini4,1 kernel: (==) Log file: "/var/log/Xorg.0.log", Time: Sun Jan  2 14:54:35 2022
Jan  2 15:55:30 Macmini4,1 kernel: (++) Using config directory: "/tmp/initgfx.360"
Jan  2 15:55:30 Macmini4,1 kernel: (==) Using system config directory "/usr/local/share/X11/xorg.conf.d"
Jan  2 15:55:30 Macmini4,1 kernel: scfb trace: probe start
Jan  2 15:55:30 Macmini4,1 kernel: scfb trace: probe done
Jan  2 15:55:30 Macmini4,1 kernel: (EE)
Jan  2 15:55:30 Macmini4,1 kernel: Fatal server error:
Jan  2 15:55:30 Macmini4,1 kernel: (EE) Cannot run in framebuffer mode. Please specify busIDs        for all framebuffer devices
Jan  2 15:55:30 Macmini4,1 kernel: (EE)
Jan  2 15:55:30 Macmini4,1 syslogd: last message repeated 1 times
Jan  2 15:55:30 Macmini4,1 kernel: Please consult the The X.Org Foundation support
Jan  2 15:55:30 Macmini4,1 kernel: 	 at http://wiki.x.org
Jan  2 15:55:30 Macmini4,1 kernel:  for help.
Jan  2 15:55:30 Macmini4,1 kernel: (EE) Please also check the log file at "/var/log/Xorg.0.log" for additional information.
Jan  2 15:55:30 Macmini4,1 kernel: (EE)
Jan  2 15:55:30 Macmini4,1 kernel: (EE) Server terminated with error (1). Closing log file.
Jan  2 15:55:30 Macmini4,1 kernel: /usr/local/bin/xinit: giving up
Jan  2 15:55:30 Macmini4,1 kernel: /usr/local/bin/xinit: unable to connect to X server: Network is unreachable
Jan  2 15:55:30 Macmini4,1 kernel: /usr/local/bin/xinit: server error
Jan  2 15:55:30 Macmini4,1 kernel: initgfx: No suitable graphics driver found. Using scfb instead ...

@probonopd I never did get it to work. I have since given up on Apple hardware; too many proprietary things inside like Broadcom chips etc. Also they've become completely user non-serviceable. The Mac Mini in question now runs ESXi.

The 320M was a bit of a rare unit, it didn't have its own memory and instead shared from the system. I suspect it will never work unfortunately.

I have a GT 320M in a HP laptop and last time I tried (probably last year) it was recognised properly and supported by nvidia-340.

The Mac mini Mid 2010 (Macmini4,1) does boot hello-0.9.0_0I37-FreeBSD-13.2-amd64.iso, but it is not loading any Nvidia driver. Next step: Try to get nvidia-340 loaded.

Also affects MacBookPro7,1 (A1278) as per https://github.com/helloSystem/ISO/issues/550.

You need to put back the GeForce 320M that was removed here because that's the GT320M that's here and it's not the same as the 320M.
https://github.com/helloSystem/ISO/commit/4337c79a54b80a546ff7b703850c7cb6e9810005#diff-b2fd43810a72a47891ee755ad2915dc3a9b0274e57dcc531071292c65638ba78L753

Nomadbsd on A1278
https://bsd-hardware.info/?probe=714516a696

I tested it on ghostBSD, but it failed to enter the desktop successfully. I had to modify it to scfb to use it, but vesa did not work.

I think this might work.
https://forums.freebsd.org/threads/correct-guide-to-install-nvidia-driver.69338/


Error: mermaid: with groups, all characters should be matched in consecutive groups in rule: (unknown)

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: "@monaco-editor/react": "^4.5.1",

OS Version:
Windows >=10
55%
Mac OS X >=10.15.7
38%
Chrome OS 14816.131.0
2%
Mac OS X 10.15
1%
Other
1%

Steps to Reproduce:
I am not sure, I am seeing this error in sentry logs. This is the error:
Error: mermaid: with groups, all characters should be matched in consecutive groups in rule: (unknown)

Error: mermaid: with groups, all characters should be matched in consecutive groups in rule: (unknown)
    at Object.g [as createError] (https://cdn.jsde...

Which tracks to this line of code. I am just after some more information on what might be causing this. I am using the monoco-mermaid package to init the editor.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.81.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

The issues still remains as I am using monoco.


Add RecordingFileFactory with default implementation

By default this returns a file in the given vlc recording directory named <RESULT>-<TestClassName>-<testMethodName>-<YYYYMMdd-HHmmss>.flv, where RESULT is either PASSED or FAILED.
A custom factory can be provided to BrowserWebDriverContainer#withRecordingFileFactory.
The factory is only applicable if the BrowserWebDriverContainer#recordingMode enables the retention of recordings.
Fixes #500.

I just restarted the CI build, failing was unrelated.


Add wp i18n make-mo command.

This adds new i18n command make-mo to generate MO files from PO file(s). Examples:
// Reads from a single .po file
$ wp i18n make-mo ./wp-content/languages/slug.po
Success: Created 1 file.

// Reads from a directory—for multiple .po files.
$ wp i18n make-mo ./wp-content/languages/
Success: Created 5 files.

No unit tests added—relies on Gettext\Translations::toMoFile() that may cover the po-to-mo conversion tests.
Resolves #141.

Looks nice at first glance! Thanks for your contribution 🚀
Would you be able to provide some Behat tests for this new command to test the behavior?
Let me know if you need help with that.

Would you be able to provide some Behat tests for this new command to test the behavior?

I added a basic test in https://github.com/wp-cli/i18n-command/pull/214/commits/0f954da824a1d8ae61acbeeb57b0de59ff1d2a60.

Great work, @gedex , thanks for the PR!


Adding or removing grid-items

After I add or remove itemGrids, the itemGrid is not responsive, so the width of the grid doesn't update when I resize the main Window.
Also in your app when you add an item the item cannot be move.
Thanks

Sorry, but you need to supply a code sample or a better description of your problem


RT-349: Fix homepage summary

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@662476b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage        ?   97.67%
=======================================
  Files           ?       63
  Lines           ?     4349
  Branches        ?        0
=======================================
  Hits            ?     4248
  Misses          ?      101
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662476b...be5c961. Read the comment docs.


[admin] Publish

Docs Build status updates of commit 6ce3dbb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/excel/custom-functions-data-types-concepts.md
:white_check_mark:Succeeded
View

docs/excel/custom-functions-data-types-overview.md
:white_check_mark:Succeeded
View

docs/excel/custom-functions-json.md
:white_check_mark:Succeeded
View

docs/excel/excel-data-types-concepts.md
:white_check_mark:Succeeded
View

docs/excel/excel-data-types-overview.md
:white_check_mark:Succeeded
View

docs/images/custom-function-already-exists-error.png
:white_check_mark:Succeeded
View

docs/quickstarts/excel-custom-functions-quickstart.md
:white_check_mark:Succeeded
View

docs/toc.yml
:white_check_mark:Succeeded
View

docs/tutorials/excel-tutorial-create-custom-functions.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[BUG] Streaming video fails

Issue Description:
When we place a video URL the video fails to load
https://customer-bxw75qmnd3o01zk5.cloudflarestream.com/439f2a96e5ace4bc1edac10eb4394232/manifest/video.m3u8
preview:
https://postimg.cc/xJM2TJb0

[x] SDK7

Tool:

[x] Editor
[ ] CLI

CLI Version:
Node Version:
Steps to reproduce:

Expected behaviour:

Current behaviour:

Reproduction rate:

Code Snippets:

Platforms:

[x] Windows
[x] Mac
[ ] Not platform specific

Browser:

[x] Google Chrome
[ ] Microsoft Edge
[ ] Firefox
[ ] Desktop
[ ] Brave
[ ] Safari
[ ] Not Browser Specific

Environment:

[x] production - web client
[ ] production - desktop client
[x] local preview
[ ] web editor
[ ] desktop editor

Evidence:

https://postimg.cc/xJM2TJb0
Additional Notes:

If I paste that video URL on the video-streaming example scene from Goerli Plaza, it works well

Were you maybe trying to run this in the preview window as a tab inside of VS Studio Code?  There's a known issue where some video formats are not supported by VS Studio's "browser". If so, please try to run your scene preview in Chrome or Firefox, it should work well in that case.


FBI 2.4.7 hangs on splash screen when using a custom TID

First, the splash screen looks really nice when launched from home menu!
But unfortunately, it breaks launching 2.4.7 for me since I've manually set the TID to be 0x00000 so it's listed directly as the second item in DevMenu (first being the CTR card).
I've tried launching it from both home menu and DevMenu with both hanging on the splash screen (home menu) or black screen (DevMenu).
Version 2.4.6 worked fine for me with the TID, so could it be that the splash screen uses a hardcoded TID and therefore fails to launch?
I don't know anything about the splash screen format used by the 3DS so it might sound farfetched.

You shouldn't be using 0x00000 since that's NATIVE_FIRM's unique ID, but I'll look into it.

According to 3dbrew the NATIVE_FIRM's unique ID is 0x01002 with 00040130 being the high ID.
So NATIVE_FIRM shouldn't be affected any way, unless I'm misunderstanding something.

NATIVE_FIRM's low title ID is 00000002, which is a unique ID component of 0x00000 and a variation component of 0x02.

To confirm, have you made sure that building it manually without the title ID change works fine?

Yeah, if I don't change the ID I can run it just fine.
I've also just did some tests, which may or may not help.

Compile 2.4.6 again with only the UNIQUE_ID constant changed -> launched
Compile 2.4.7 with no custom splash but changed UNIQUE_ID -> didn't launch
Copy the 2.4.7 meta folder and Makefile into 2.4.6 (with UNIQUE_ID changed) and compiled -> launched

Two things:

When you tested 2.4.6 with 2.4.7's meta and Make file, did you also pull the latest buildtools submodule into 2.4.6?
Have you tried a unique ID other than 00000 just in case? Something close to what it was originally or otherwise known to be a reasonable choice.

Closing this due to age and the fact that changing the unique ID seems to work fine for me.


CommonHeadersOnly is not working as expected.

We rarely get all the headers when we run lots of DICOM files through png-extraction. In contrast, if we run just a couple of files, we get more attributes. Let me give an example:
The fields we got when we ran it against June 28th 2021 all MR data:
AccessionNumber,Private Creator,InstanceNumber,InstitutionName,IssuerOfPatientID,Manufacturer,ManufacturerModelName,Modality,PatientBirthDate,PatientID,PatientName,PatientSex,Private tag data,[Unknown],ReferringPhysicianName,SOPClassUID,SOPInstanceUID,SeriesDate,SeriesDescription,SeriesInstanceUID,SeriesNumber,SeriesTime,SpecificCharacterSet,StationName,StudyDate,StudyDescription,StudyID,StudyInstanceUID,StudyTime,[Reject Image Flag],[Significant Flag],[Confidential Flag],[Assigning Authority For Patient ID],file,has_pix_array,category,BitsAllocated,BitsStored,Columns,HighBit,ImageOrientationPatient,ImagePositionPatient,ImageType,PatientPosition,PhotometricInterpretation,PixelRepresentation,PixelSpacing,Rows,SamplesPerPixel,SliceThickness
The fields we got when we ran against just 2 DICOM images from the above set:
AccessionNumber,AcquisitionDate,AcquisitionMatrix,AcquisitionNumber,AcquisitionTime,AngioFlag,BitsAllocated,BitsStored,BodyPartExamined,Columns,ContentDate,ContentTime,DeviceSerialNumber,EchoNumbers,EchoTime,EchoTrainLength,EthnicGroup,FillerOrderNumberImagingServiceRequest,FlipAngle,FrameOfReferenceUID,HighBit,ImageOrientationPatient,ImagePositionPatient,ImageType,ImagedNucleus,ImagingFrequency,InPlanePhaseEncodingDirection,InstanceCreationDate,InstanceCreationTime,InstanceNumber,InstitutionAddress,InstitutionName,InstitutionalDepartmentName,IssuerOfPatientID,LargestImagePixelValue,Laterality,MRAcquisitionType,MagneticFieldStrength,Manufacturer,ManufacturerModelName,Modality,NumberOfAverages,NumberOfPhaseEncodingSteps,OtherPatientIDs,PatientAddress,PatientAge,PatientBirthDate,PatientID,PatientName,PatientPosition,PatientSex,PatientSize,PatientWeight,PercentPhaseFieldOfView,PercentSampling,PerformedProcedureStepDescription,PerformedProcedureStepID,PerformedProcedureStepStartDate,PerformedProcedureStepStartTime,PhotometricInterpretation,PhysiciansOfRecord,PixelBandwidth,PixelRepresentation,PixelSpacing,PregnancyStatus,0_ProcedureCodeSequence_CodeMeaning,0_ProcedureCodeSequence_CodeValue,0_ProcedureCodeSequence_CodingSchemeDesignator,0_ProcedureCodeSequence_CodingSchemeVersion,ProtocolName,0_ReferencedImageSequence_ReferencedSOPClassUID,0_ReferencedImageSequence_ReferencedSOPInstanceUID,1_ReferencedImageSequence_ReferencedSOPClassUID,1_ReferencedImageSequence_ReferencedSOPInstanceUID,2_ReferencedImageSequence_ReferencedSOPClassUID,2_ReferencedImageSequence_ReferencedSOPInstanceUID,0_ReferencedPatientSequence_ReferencedSOPClassUID,0_ReferencedPatientSequence_ReferencedSOPInstanceUID,0_ReferencedStudySequence_ReferencedSOPClassUID,0_ReferencedStudySequence_ReferencedSOPInstanceUID,ReferringPhysicianName,RepetitionTime,0_RequestAttributesSequence_RequestedProcedureID,0_RequestedProcedureCodeSequence_CodeMeaning,0_RequestedProcedureCodeSequence_CodeValue,0_RequestedProcedureCodeSequence_CodingSchemeDesignator,RequestedProcedureDescription,RequestingPhysician,Rows,SAR,SOPClassUID,SOPInstanceUID,SamplesPerPixel,ScanOptions,ScanningSequence,SequenceName,SequenceVariant,SeriesDate,SeriesDescription,SeriesInstanceUID,SeriesNumber,SeriesTime,SliceLocation,SliceThickness,SmallestImagePixelValue,SoftwareVersions,SpacingBetweenSlices,SpecificCharacterSet,StationName,StudyDate,StudyDescription,StudyID,StudyInstanceUID,StudyPriorityID,StudyStatusID,StudyTime,TransmitCoilName,VariableFlipAngleFlag,WindowCenter,WindowCenterWidthExplanation,WindowWidth,dBdt,Private Creator,Private tag data,[Unknown],[CSA Image Header Type],[CSA Image Header Version ??],[SliceMeasurementDuration],[GradientMode],[FlowCompensation],[TablePositionOrigin],[ImaAbsTablePosition],[ImaRelTablePosition],[SlicePosition_PCS],[TimeAfterStart],[SliceResolution],[RealDwellTime],[CSA Image Header Version],[CSA Image Header Info],[CSA Series Header Type],[CSA Series Header Version],[CSA Series Header Info],[Series Workflow Status],[AcquisitionMatrixText],[CoilString],[PATModeText],[PositivePCSDirections],[Reject Image Flag],[Significant Flag],[Confidential Flag],[Assigning Authority For Patient ID],file,has_pix_array,category,AdmissionID,0_AnatomicRegionSequence_CodeMeaning,0_AnatomicRegionSequence_CodeValue,0_AnatomicRegionSequence_CodingSchemeDesignator,BeatRejectionFlag,CardiacNumberOfImages,HeartRate,ImagesInAcquisition,InStackPositionNumber,InversionTime,PerformedLocation,PerformedStationName,ReceiveCoilName,ReconstructionDiameter,0_ReferencedPerformedProcedureStepSequence_ReferencedSOPClassUID,0_ReferencedPerformedProcedureStepSequence_ReferencedSOPInstanceUID,StackID,TriggerWindow,[Suite id],[Product id],[Image actual date],[Service id],[Mobile location number],[Equipment UID],[Actual series data time stamp],[Horiz. Frame of ref.],[Series contrast],[Last pseq],[Series plane],[First scan ras],[First scan location],[Last scan ras],[Last scan loc],[Display field of view],[Acquisition Duration],[Second echo],[Number of echoes],[Table delta],[Contiguous],[Peak SAR],[Cardiac repetition time],[Images per cardiac cycle],[Actual receive gain analog],[Actual receive gain digital],[Delay after trigger],[Swappf],[Pause Interval],[Pause Time],[Slice offset on freq axis],[Auto Prescan Center Frequency],[Auto Prescan Transmit Gain],[Auto Prescan Analog receiver gain],[Auto Prescan Digital receiver gain],[Bitmap defining CVs],[Pulse Sequence Mode],[Pulse Sequence Name],[Pulse Sequence Date],[Internal Pulse Sequence Name],[Transmitting Coil Type],[Surface Coil Type],[Extremity Coil flag],[Raw data run number],[Calibrated Field strength],[SAT fat/water/bone],[User data 0],[User data 1],[User data 2],[User data 3],[User data 4],[User data 5],[User data 6],[User data 7],[User data 8],[User data 9],[User data 10],[User data 11],[User data 12],[User data 13],[User data 14],[User data 15],[User data 16],[User data 17],[User data 18],[User data 19],[User data 20],[User data 21],[User data 22],[Projection angle],[Saturation planes],[SAT location R],[SAT location L],[SAT location A],[SAT location P],[SAT location H],[SAT location F],[SAT thickness R/L],[SAT thickness A/P],[SAT thickness H/F],[Phase Contrast flow axis],[Velocity encoding],[Thickness disclaimer],[Prescan type],[Prescan status],[Projection Algorithm],[Fractional echo],[Cardiac phase number],[Variable echoflag],"[Concatenated SAT {# DTI Diffusion Dir., release 9.0 & below}]","[User data 23 {# DTI Diffusion Dir., release 9.0 & below}]","[User data 24 {# DTI Diffusion Dir., release 10.0 & above}]",[Velocity Encode Scale],[Fast phases],[Transmit gain],[Series from which prescribed],[Image from which prescribed],[Screen Format],[Locations in acquisition],[Graphically prescribed],[Rotation from source x rot],[Rotation from source y rot],[Rotation from source z rot],[Num 3D slabs],[Locs per 3D slab],[Overlaps],[Image Filtering 0.5/0.2T],[Diffusion direction],[Tagging Flip Angle],[Tagging Orientation],[Tag Spacing],[RTIA_timer],[Fps],[Auto window/level alpha],[Auto window/level beta],[Auto window/level window],[Auto window/level level],[Start time(secs) in first axial],[No. of updates to header],[Indicates study has complete info (DICOM/genesis)],[Last pulse sequence used],[Images in Series],[Landmark Counter],[Number of Acquisitions],[Indicates no. of updates to header],[Series Complete Flag],[Number of images archived],[Last image number used],[Primary Receiver Suite and Host],[Protocol Data Block (compressed)],[Image archive flag],[Scout Type],[Imaging Mode],[Pulse Sequence],[Imaging Options],[Plane Type],[RAS letter of image location],[Image location],[Image dimension - X],[Image dimension - Y],[Number of Excitations],[Lower range of Pixels1],[Upper range of Pixels1],[Lower range of Pixels2],[Upper range of Pixels2],[Version of the hdr struct],[Advantage comp. Overflow],[Advantage comp. Underflow],[Bitmap of prescan options],[Gradient offset in X],[Gradient offset in Y],[Gradient offset in Z],[Number of EPI shots],[Views per segment],"[Respiratory rate, bpm]",[Respiratory trigger point],[Type of receiver used],[DB/dt Peak rate of change of gradient field],[dB/dt Limits in units of percent],[PSD estimated limit],[PSD estimated limit in tesla per second],[Window value],[GE image integrity],[Level value],[Unique image iden],[Histogram tables],[User defined data],[Effective echo spacing],[Filter Mode (String slop field 1 in legacy GE MR],"[Image Type (real, imaginary, phase, magnitude)]",[Vas collapse flag],[Vas flags],[Neg_scanspacing],[Offset Frequency],[User_usage_tag],[User_fill_map_MSW],[User_fill_map_LSW],[User data 25...User data 48 {User48=Effective Resolution for spiral}],[Slop_int_6... slop_int_9],[Slop_int_10...slop_int_17],[Scanner Study Entity UID],[Scanner Study ID],[Scanner Table Entry (single gradient coil systems only)/Scanner Table Entry + Gradient Coil Selected],[Recon mode flag word],[Coil ID Data],[GE Coil Name],[System Configuration Information],[Asset R Factors],[Additional Asset Data],"[Governing Body, dB/dt, and SAR definition]",[Private In-Plane Phase Encoding Direction],[SAR Definition],[SAR value],[Prescan Reuse String],[Content Qualification],[Image Filtering Parameters],[Rx Stack Identification]
In both cases, we set as below:
{
"DICOMHome": "/opt/localdrive/Niffler/modules/cold-extraction/june28",
"OutputDirectory": "June28_2021",
"Depth": 3,
"SplitIntoChunks": 1000,
"PrintImages": false,
"CommonHeadersOnly": false,
"PublicHeadersOnly": false,
"SpecificHeadersOnly": false,
"UseProcesses": 0,
"FlattenedToLevel": "patient",
"is16Bit":true,
"SendEmail": true,
"YourEmail"<EMAIL_ADDRESS>}
{
"DICOMHome": "/Users/pradeeban/Downloads/onedrive",
"OutputDirectory": "/Users/pradeeban/Downloads/onedrive/meta1",
"Depth": 0,
"SplitIntoChunks": 1,
"PrintImages": false,
"CommonHeadersOnly": false,
"PublicHeadersOnly": false,
"SpecificHeadersOnly": false,
"UseProcesses": 0,
"FlattenedToLevel": "patient",
"is16Bit":true,
"SendEmail": true,
"YourEmail"<EMAIL_ADDRESS>}

Comment from Ramon:
TL:DR: We need an if statement in line 482
Explanation:
Lines 467 onwards.  We iterate through each metadata file.  We check which column names there are and if there are nans. We create two lists one that has the number of times a tag appears in our metadata and another that counts the number of nans. Line 482 will then filter based on this. The problem is that this filtering occurs regardless of the  print_only_common headers.
Why does this problem occur?
The potential reasoning is that given how heterogenous the Dicom metadata is, batches can have some tag variability. Therefore to ensure we can load all the metadata files into one giant file, we check which tags/columns are present in all the files.  A preferred fix would be to fill out the missing columns as NAS.  But this will go against the nan thresholding. This may also see tags be added that shouldn’t be reported. For example:  if US and CXR images are present in the same extraction.  Simply adding nan columns will result in a US sound study having nan CXR  tags.  This will be a point of confusion in the future.
Suggestion:
For now, we can add proper if statements to line 482 to change the metadata filtering. This may break the step that creates the one giant metadata file.  The challenge is that CSV expects a consistent data schema, which is impossible with DICOM data from multiple modalities.

"SplitIntoChunks": 1,
might be a work-around. Testing right now.

chunks = 1 did not create the metadata file. I guess it is too much data for the code to handle without chunking.
So, "chunks=1" was not a proper workaround.

Ramon says:
The immediate fix should be making sure CommonHeadersOnly (true, false) is verified for lines 435 and  442.

A merging problem exists too:
AccessionNumber,Private Creator,InstanceNumber,InstitutionName,IssuerOfPatientID,Manufacturer,ManufacturerModelName,Modality,PatientBirthDate,PatientID,PatientName,PatientSex,Private tag data,[Unknown],ReferringPhysicianName,SOPClassUID,SOPInstanceUID,SeriesDate,SeriesDescription,SeriesInstanceUID,SeriesNumber,SeriesTime,SpecificCharacterSet,StationName,StudyDate,StudyDescription,StudyID,StudyInstanceUID,StudyTime,[Reject Image Flag],[Significant Flag],[Confidential Flag],[Assigning Authority For Patient ID],file,has_pix_array,category,BitsAllocated,BitsStored,Columns,HighBit,ImageOrientationPatient,ImagePositionPatient,ImageType,PatientPosition,PhotometricInterpretation,PixelRepresentation,PixelSpacing,Rows,SamplesPerPixel,SliceThickness
The above headers were produced by merging 1000 intermediate files with different headers in png-extraction.
AccessionNumber,AcquisitionDate,AcquisitionMatrix,AcquisitionNumber,AcquisitionTime,AngioFlag,BitsAllocated,BitsStored,BodyPartExamined,Columns,CommentsOnThePerformedProcedureStep,ContentDate,ContentTime,DeviceSerialNumber,EchoNumbers,EchoTime,EchoTrainLength,EthnicGroup,FillerOrderNumberImagingServiceRequest,FlipAngle,FrameOfReferenceUID,HighBit,ImageOrientationPatient,ImagePositionPatient,ImageType,ImagedNucleus,ImagingFrequency,InPlanePhaseEncodingDirection,InstanceCreationDate,InstanceCreationTime,InstanceNumber,InstitutionAddress,InstitutionName,InstitutionalDepartmentName,IssuerOfPatientID,LargestImagePixelValue,MRAcquisitionType,MagneticFieldStrength,Manufacturer,ManufacturerModelName,Modality,NumberOfAverages,NumberOfPhaseEncodingSteps,OtherPatientIDs,PatientAddress,PatientAge,PatientBirthDate,PatientID,PatientName,PatientPosition,PatientSex,PatientSize,PatientWeight,PercentPhaseFieldOfView,PercentSampling,PerformedProcedureStepDescription,PerformedProcedureStepID,PerformedProcedureStepStartDate,PerformedProcedureStepStartTime,PerformingPhysicianName,PhotometricInterpretation,PhysiciansOfRecord,PixelBandwidth,PixelRepresentation,PixelSpacing,PositionReferenceIndicator,PregnancyStatus,0_ProcedureCodeSequence_CodeMeaning,0_ProcedureCodeSequence_CodeValue,0_ProcedureCodeSequence_CodingSchemeDesignator,0_ProcedureCodeSequence_CodingSchemeVersion,ProtocolName,0_ReferencedImageSequence_ReferencedSOPClassUID,0_ReferencedImageSequence_ReferencedSOPInstanceUID,1_ReferencedImageSequence_ReferencedSOPClassUID,1_ReferencedImageSequence_ReferencedSOPInstanceUID,2_ReferencedImageSequence_ReferencedSOPClassUID,2_ReferencedImageSequence_ReferencedSOPInstanceUID,0_ReferencedPatientSequence_ReferencedSOPClassUID,0_ReferencedPatientSequence_ReferencedSOPInstanceUID,0_ReferencedStudySequence_ReferencedSOPClassUID,0_ReferencedStudySequence_ReferencedSOPInstanceUID,ReferringPhysicianName,RepetitionTime,0_RequestAttributesSequence_RequestedProcedureID,0_RequestedProcedureCodeSequence_CodeMeaning,0_RequestedProcedureCodeSequence_CodeValue,0_RequestedProcedureCodeSequence_CodingSchemeDesignator,RequestedProcedureDescription,RequestingPhysician,Rows,SAR,SOPClassUID,SOPInstanceUID,SamplesPerPixel,ScanOptions,ScanningSequence,SequenceName,SequenceVariant,SeriesDate,SeriesDescription,SeriesInstanceUID,SeriesNumber,SeriesTime,SliceLocation,SliceThickness,SmallestImagePixelValue,SoftwareVersions,SpacingBetweenSlices,SpecificCharacterSet,StationName,StudyDate,StudyDescription,StudyID,StudyInstanceUID,StudyPriorityID,StudyStatusID,StudyTime,TransmitCoilName,VariableFlipAngleFlag,WindowCenter,WindowCenterWidthExplanation,WindowWidth,Private Creator,Private tag data,[Unknown],[CSA Image Header Type],[CSA Image Header Version ??],[SliceMeasurementDuration],[GradientMode],[FlowCompensation],[TablePositionOrigin],[ImaAbsTablePosition],[ImaRelTablePosition],[SlicePosition_PCS],[SliceResolution],[RealDwellTime],[CSA Image Header Version],[CSA Image Header Info],[CSA Series Header Type],[CSA Series Header Version],[CSA Series Header Info],[AcquisitionMatrixText],[CoilString],[PATModeText],[PositivePCSDirections],[Reject Image Flag],[Significant Flag],[Confidential Flag],[Assigning Authority For Patient ID],file,has_pix_array,category,DerivationDescription,ImageComments,LossyImageCompression,OperatorsName,[MedCom OOG Type],[MedCom OOG Version],[MedCom OOG Info],Laterality,dBdt,[TimeAfterStart],[Series Workflow Status]
^ metadata_9.csv
AND
AccessionNumber,AcquisitionDate,AcquisitionDuration,AcquisitionMatrix,AcquisitionNumber,AcquisitionTime,AdditionalPatientHistory,AdmittingDiagnosesDescription,Allergies,B1rms,BitsAllocated,BitsStored,BodyPartExamined,CodeMeaning,CodeValue,CodingSchemeDesignator,Columns,CommentsOnThePerformedProcedureStep,ContentDate,ContentTime,ConversionType,DeviceSerialNumber,DiffusionBValue,DiffusionGradientOrientation,DigitalImageFormatAcquired,EchoNumbers,EchoTime,EchoTrainLength,EthnicGroup,FillerOrderNumberImagingServiceRequest,FlipAngle,FrameOfReferenceUID,HeartRate,HighBit,HighRRValue,ImageOrientationPatient,ImagePositionPatient,ImageType,ImagedNucleus,ImagingFrequency,ImagingServiceRequestComments,InPlanePhaseEncodingDirection,InstanceCreationDate,InstanceCreationTime,InstanceCreatorUID,InstanceNumber,InstitutionAddress,InstitutionName,InstitutionalDepartmentName,IntervalsAcquired,IntervalsRejected,IssueDateOfImagingServiceRequest,IssueTimeOfImagingServiceRequest,IssuerOfPatientID,Laterality,LowRRValue,MRAcquisitionType,MagneticFieldStrength,Manufacturer,ManufacturerModelName,MedicalAlerts,Modality,NumberOfAverages,NumberOfPhaseEncodingSteps,NumberOfTemporalPositions,Occupation,OperatorsName,OrderCallbackPhoneNumber,OrderEntererLocation,OtherPatientIDs,PatientAddress,PatientAge,PatientBirthDate,PatientComments,PatientID,PatientName,PatientPosition,PatientSex,PatientState,PatientTransportArrangements,PatientWeight,PercentPhaseFieldOfView,PercentSampling,PerformedLocation,PerformedProcedureStepDescription,PerformedProcedureStepEndDate,PerformedProcedureStepEndTime,PerformedProcedureStepID,PerformedProcedureStepStartDate,PerformedProcedureStepStartTime,PerformedProcedureStepStatus,PerformedProcedureTypeDescription,0_PerformedProtocolCodeSequence_CodeMeaning,0_PerformedProtocolCodeSequence_CodeValue,0_PerformedProtocolCodeSequence_CodingSchemeDesignator,0_PerformedProtocolCodeSequence_ContextGroupExtensionFlag,PerformedStationAETitle,PerformedStationName,PerformingPhysicianName,PhotometricInterpretation,PixelBandwidth,PixelRepresentation,PixelSpacing,PositionReferenceIndicator,PregnancyStatus,PresentationLUTShape,0_ProcedureCodeSequence_CodeMeaning,0_ProcedureCodeSequence_CodeValue,0_ProcedureCodeSequence_CodingSchemeDesignator,0_ProcedureCodeSequence_CodingSchemeVersion,ProtocolName,0_RealWorldValueMappingSequence_LUTExplanation,0_RealWorldValueMappingSequence_LUTLabel,0_RealWorldValueMappingSequence__0_MeasurementUnitsCodeSequence_CodeMeaning,0_RealWorldValueMappingSequence__0_MeasurementUnitsCodeSequence_CodeValue,0_RealWorldValueMappingSequence__0_MeasurementUnitsCodeSequence_CodingSchemeDesignator,0_RealWorldValueMappingSequence__0_MeasurementUnitsCodeSequence_ContextUID,0_RealWorldValueMappingSequence_RealWorldValueFirstValueMapped,0_RealWorldValueMappingSequence_RealWorldValueIntercept,0_RealWorldValueMappingSequence_RealWorldValueLastValueMapped,0_RealWorldValueMappingSequence_RealWorldValueSlope,Private Creator,[Nested Object Type Name],ReasonForTheImagingServiceRequest,ReasonForTheRequestedProcedure,ReceiveCoilName,ReconstructionDiameter,0_ReferencedImageSequence_ReferencedSOPClassUID,0_ReferencedImageSequence_ReferencedSOPInstanceUID,1_ReferencedImageSequence_ReferencedSOPClassUID,1_ReferencedImageSequence_ReferencedSOPInstanceUID,2_ReferencedImageSequence_ReferencedSOPClassUID,2_ReferencedImageSequence_ReferencedSOPInstanceUID,0_ReferencedPerformedProcedureStepSequence_InstanceCreationDate,0_ReferencedPerformedProcedureStepSequence_InstanceCreationTime,0_ReferencedPerformedProcedureStepSequence_InstanceCreatorUID,0_ReferencedPerformedProcedureStepSequence_InstanceNumber,0_ReferencedPerformedProcedureStepSequence_ReferencedSOPClassUID,0_ReferencedPerformedProcedureStepSequence_ReferencedSOPInstanceUID,Private tag data,[Unknown],0_ReferencedStudySequence_ReferencedSOPClassUID,0_ReferencedStudySequence_ReferencedSOPInstanceUID,ReferringPhysicianName,RepetitionTime,0_RequestAttributesSequence_RequestedProcedureID,RequestedContrastAgent,RequestedProcedureComments,RequestedProcedureDescription,RequestedProcedureLocation,RequestedProcedurePriority,RequestingPhysician,RequestingService,Rows,SAR,SOPClassUID,SOPInstanceUID,SamplesPerPixel,ScanOptions,ScanningSequence,ScheduledPerformingPhysicianName,SecondaryCaptureDeviceID,SecondaryCaptureDeviceManufacturer,SecondaryCaptureDeviceManufacturerModelName,SecondaryCaptureDeviceSoftwareVersions,SequenceVariant,SeriesDate,SeriesDescription,SeriesInstanceUID,SeriesNumber,SeriesTime,SliceLocation,SliceThickness,SoftwareVersions,SpacingBetweenSlices,SpecialNeeds,SpecificCharacterSet,StationName,StudyComments,StudyDate,StudyDescription,StudyID,StudyInstanceUID,StudyTime,TemporalPositionIdentifier,TriggerTime,TriggerWindow,VideoImageFormatAcquired,WindowCenter,WindowWidth,dBdt,[Reject Image Flag],[Significant Flag],[Confidential Flag],[Assigning Authority For Patient ID],[Chemical Shift],[Chemical Shift Number MR],[Diffusion B-Factor],[Diffusion Direction],[Image Enhanced],[Image Type ED ES],[Phase Number],[Slice Number MR],[Slice Orientation],[Cardiac Sync],[Diffusion Echo Time],[Dynamic Series],[EPI Factor],[Number of Echoes],[Number of Locations],[Number of PC Directions],[Number of Phases MR],[Number of Slices MR],[Partial Matrix Scanned],[PC Velocity],[Prepulse Delay],[Prepulse Type],[Reconstruction Number MR],[Respiration Sync],[Scanning Technique Description MR],[SPIR],[Water Fat Shift],[Flip Angle Philips],[Interactive],[Echo Time Display MR],[Stack Sequence],[Number of Stacks],[Examination Source],[GL TrafoType],[Acquisition Number],[Number of Dynamic Scans],[Echo Train Length],[Imaging Frequency],[Inversion Time],[Magnetic Field Strength],[Imaged Nucleus],[Number of Averages],[Phase FOV Percent],[Sampling Percent],[Prospective Motion Correction],[Retrospective Motion Correction],[Window Center],[Window Width],[Number of Chemical Shift],[Repetition Time],[Acquisition Duration],[Syncra Scan Type],[Diffusion Direction RL],[Diffusion Direction AP],[Diffusion Direction FH],file,has_pix_array,category

Fixed in #341.


Events and related notifications

Hi,
I have recently tried creating my first own event on Howlr.
I have noticed two possible bugs related to this process in version 39.0.0:

My account was listed twice on the participants' list
When someone else joined the event, I have received a notification stating that it was me who just joined it.

Hello!
It may be a backend bug, I'll look into it before we release it by the end of the month.
Thanks for your report!

It should be fixed when we release the server-code, thank you very much for your bug report!


User 'app' requires password to connect to DEV.APP.SVRCONN with default settings

From my understanding, the documentation of the default developer config implies that you don't need a password for connecting to the DEV.APP.SVRCONN channel with the 'app' user. Relevant parts:

"User app for messaging (in a group called mqclient). No password by default."
"Users in mqclient group have been given access connect to all queues and topics starting with DEV.** and have put, get, pub, sub, browse and inq permissions."
"DEV.APP.SVRCONN - does not allow administrative users to connect. Password is optional unless you choose a password for app users."

However, I'm getting the following errors...
Exception in Java client (based on this tutorial)
MQ call failed with compcode '2' ('MQCC_FAILED') reason '2035' ('MQRC_NOT_AUTHORIZED').
Container log:
AMQ5534E: User ID 'app' authentication failed
AMQ5542I: The failed authentication check was caused by the queue manager CONNAUTH CHCKCLNT(REQDADM) configuration.

The container is started with
docker run --env LICENSE=accept --env MQ_QMGR_NAME=QM1  --publish 1414:1414 --publish 9443:9443 --detach --rm ibmcom/mq
As soon as I define a password (--env MQ_APP_PASSWORD=...), the connection is successful.
Is this behavior intended? If yes, how can I disable it?

Looking at the tutorial i suspect the issue is that even though the container is started in a way to not require a password to connect to the DEV.APP.SVRCONN channel your application is still sending a password for the app user. When MQ gets a connection with a userid and password supplied it will always check them to make sure they are valid and because you haven't set --env MQ_APP_PASSWORD=.... the passwords are unlikely to match. (Also why it works when you do set it)
Try commenting out the following lines in your program, recompiling and trying again:
cf.setBooleanProperty(WMQConstants.USER_AUTHENTICATION_MQCSP, true);
cf.setStringProperty(WMQConstants.USERID, APP_USER);
cf.setStringProperty(WMQConstants.PASSWORD, APP_PASSWORD);

Of course. Thank you.


Use 1.1 of Asynchronous Search plugin for Release 1.1.0

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Please update the PR description. Thanks!

The 1.1 branch doesn't include CI fixes or removal of integtest.sh.

https://github.com/opensearch-project/asynchronous-search/pull/44

Still do not see the --signoff commits. @eirsep Can you please take care of that?
More details
Thanks!


Switch to using pipx

Due to PEP 668 all modern python installations via apt and brew set the externally-managed-environment and recommend switching to pipx.
This changes our usage of pip3 to pipx along with updated install parameters.

pre-release cut from this branch https://github.com/outsideopen/oo-bin-py/releases/tag/1.0.10-rc1


nipapd fails to install database when db name is not "nipap"

Hi there,
we've got the following problem:
 takt@fuckup ~ % docker run -e "DB_HOST=FOOBAR" -e "DB_NAME=nipap_dev" -e "DB_USERNAME=nipap_dev" -e "DB_PASSWORD=XXXXX" -e "NIPAP_USERNAME=nipap" -e "NIPAP_PASSWORD=password" nipap/nipapd:master Creating user 'nipap' Added user nipap to database /etc/nipap/local_auth.db 2017-06-07 16:03:51,240: backend    ERROR    Unable to execute query: must be owner of database nipap ...[repeated]... 2017-06-07 16:03:53,079: backend    ERROR    pgsql: FATAL:  remaining connection slots are reserved for non-replication superuser and rds_superuser connections
On the same DB server we have a database "nipap" with user "nipap" which works perfectly fine.

Database nipap is owner by user nipap.
Database nipap_dev is owner by nipap_dev.
Thanks
takt

The issue seems to be in nipap/nipap/db_schema.py:
COMMENT ON DATABASE nipap IS 'NIPAP database - schema version: 6'; etc.

Fixed by #1160, so closing.


Add examples and tests to DeltaSparkSessionExtension

Update DeltaSparkSessionExtension's doc to add examples. Also add tests to make sure the examples work.

LGTM.

This has been resolved by https://github.com/delta-io/delta/commit/db81af1f897abcc2e34312b0b9e217e618cc04f7


TEAMNADO-1991 Render Blank State for Manifest page

Changes

Page renders with explanatory text component per wireframe, when no manifests found and org_admin status is true
Page renders with no permissions component, when no manifests found and org_admin status is false
Authentication wrapper component added.
Light refactor of <Processing /> component to facilitate reuse.
Extracted authenticateUser method from useSatelliteManifests hooks into utilities/platformServices.ts to facilitate reuse.

Note: because this story affected the loading status, as well as the "empty state" of the Satellite Manifest Panel, the loading logic was removed from the SatelliteManifestPanel itself, to avoid a UI scenario where a user sees the Manifest Panel table only to a) see the Create Manifest blank state, or b) see the No Permissions blank state.

Codecov Report

Merging #5 (ac7a066) into main (aac0ec8) will increase coverage by 4.31%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   47.94%   52.25%   +4.31%
==========================================
  Files          18       22       +4
  Lines         146      155       +9
  Branches       25       28       +3
==========================================
+ Hits           70       81      +11
+ Misses         69       65       -4
- Partials        7        9       +2

Impacted Files
Coverage Δ

src/Routes.tsx
0.00% <0.00%> (ø)

src/pages/NoPermissionsPage/NoPermissionsPage.js
0.00% <ø> (ø)

src/hooks/useSatelliteManifests.ts
21.05% <33.33%> (+1.05%)
:arrow_up:

...es/SatelliteManifestPage/SatelliteManifestPage.tsx
88.88% <83.33%> (-11.12%)
:arrow_down:

src/components/Authentication/Authentication.tsx
84.61% <84.61%> (ø)

src/components/Authentication/UserContext.tsx
100.00% <100.00%> (ø)

.../SatelliteManifestPanel/SatelliteManifestPanel.tsx
60.00% <100.00%> (-4.52%)
:arrow_down:

src/components/emptyState/NoResults.tsx
100.00% <100.00%> (ø)

src/components/emptyState/NoSatelliteManifests.tsx
100.00% <100.00%> (ø)

src/components/emptyState/Processing.tsx
100.00% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac0ec8...ac7a066. Read the comment docs.


feat(client): make client by  option instead of conf

make client by  option instead of conf  for  more friendly using

Codecov Report

Merging #8 (5af802f) into main (8da8ca5) will decrease coverage by 1.10%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##              main       #8      +/-   ##
===========================================
- Coverage   100.00%   98.89%   -1.11%
===========================================
  Files            5        5
  Lines          698      722      +24
===========================================
+ Hits           698      714      +16
- Misses           0        8       +8

Impacted Files
Coverage Δ

featureprobe.go
95.93% <77.77%> (-4.07%)
:arrow_down:


Split dataset by node: index error when sharding iterable dataset

Describe the bug
Context: we're splitting an iterable dataset by node and then passing it to a torch data loader with multiple workers
When we iterate over it for 5 steps, we don't get an error
When we instead iterate over it for 7 steps, we get an IndexError when fetching the data
Steps to reproduce the bug
Here, we have 2 JAX processes (jax.process_count() = 2) which we split the dataset over. The dataset loading script can be found here: https://huggingface.co/datasets/distil-whisper/librispeech_asr/blob/c6a1e805cbfeed5057400ac5937327d7e30281b8/librispeech_asr.py#L310

 Code to reproduce
from datasets import load_dataset
import jax
from datasets.distributed import split_dataset_by_node
from torch.utils.data import DataLoader
from tqdm import tqdm

# load an example dataset (https://huggingface.co/datasets/distil-whisper/librispeech_asr)
dataset = load_dataset("distil-whisper/librispeech_asr", "all", split="train.clean.100", streaming=True)
# just keep the text column -> no need to define a collator
dataset_text = dataset.remove_columns(set(dataset.features.keys()) - {"text"})

# define some constants
batch_size = 256
num_examples = 7
num_workers = dataset_text.n_shards

# try with multiple workers
dataloader = DataLoader(dataset_text, batch_size=batch_size, num_workers=num_workers, drop_last=True)

for i, batch in tqdm(enumerate(dataloader), total=num_examples, desc="Multiple workers"):
    if i == num_examples:
        break

# try splitting by node (we can't do this with `dataset_text` since `split_dataset_by_node` expects the Audio column for an ASR dataset)
dataset = split_dataset_by_node(dataset, rank=jax.process_index(), world_size=jax.process_count())
# remove the text column again
dataset_text = dataset.remove_columns(set(dataset.features.keys()) - {"text"})
dataloader = DataLoader(dataset_text, batch_size=16, num_workers=num_workers // 2, drop_last=True)

for i, batch in tqdm(enumerate(dataloader), total=num_examples, desc="Split by node"):
    if i == num_examples:
        break

# too many workers
dataloader = DataLoader(dataset_text, batch_size=256, num_workers=num_workers, drop_last=True)
for i, batch in tqdm(enumerate(dataloader), total=num_examples, desc="Too many workers"):
    if i == num_examples:
        break

 With 5 examples:
Multiple workers: 100%|███████████████████████████████████████████████████████████████████| 5/5 [00:16<00:00,  3.33s/it]
Assigning 7 shards (or data sources) of the dataset to each node.
Split by node: 100%|██████████████████████████████████████████████████████████████████████| 5/5 [00:13<00:00,  2.76s/it]
Assigning 7 shards (or data sources) of the dataset to each node.
Too many dataloader workers: 14 (max is dataset.n_shards=7). Stopping 7 dataloader workers.
To parallelize data loading, we give each process some shards (or data sources) to process. Therefore it's unnecessary t
o have a number of workers greater than dataset.n_shards=7. To enable more parallelism, please split the dataset in more
 files than 7.
Too many workers: 100%|███████████████████████████████████████████████████████████████████| 5/5 [00:15<00:00,  3.03s/it]

 With 7 examples:
Multiple workers: 100%|███████████████████████████████████████████████████████████████████| 7/7 [00:32<00:00,  4.60s/it]
Assigning 7 shards (or data sources) of the dataset to each node.
Split by node: 100%|██████████████████████████████████████████████████████████████████████| 7/7 [00:13<00:00,  1.89s/it]
Assigning 7 shards (or data sources) of the dataset to each node.
Too many dataloader workers: 14 (max is dataset.n_shards=7). Stopping 7 dataloader workers.
To parallelize data loading, we give each process some shards (or data sources) to process. Therefore it's unnecessary t
o have a number of workers greater than dataset.n_shards=7. To enable more parallelism, please split the dataset in more
 files than 7.
Too many workers: 100%|███████████████████████████████████████████████████████████████████| 7/7 [00:15<00:00,  2.22s/it]
Traceback (most recent call last):
  File "distil-whisper/test_librispeech.py", line 36, in <module>
    for i, batch in tqdm(enumerate(dataloader), total=num_examples, desc="Too many workers"):
  File "/home/sanchitgandhi/hf/lib/python3.8/site-packages/tqdm/std.py", line 1178, in __iter__
    for obj in iterable:
  File "/home/sanchitgandhi/hf/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 633, in __next__
    data = self._next_data()
  File "/home/sanchitgandhi/hf/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1325, in _next_data
    return self._process_data(data)
  File "/home/sanchitgandhi/hf/lib/python3.8/site-packages/torch/utils/data/dataloader.py", line 1371, in _process_data
    data.reraise()
  File "/home/sanchitgandhi/hf/lib/python3.8/site-packages/torch/_utils.py", line 644, in reraise
    raise exception
IndexError: Caught IndexError in DataLoader worker process 7.
Original Traceback (most recent call last):
  File "/home/sanchitgandhi/hf/lib/python3.8/site-packages/torch/utils/data/_utils/worker.py", line 308, in _worker_loop
    data = fetcher.fetch(index)
  File "/home/sanchitgandhi/hf/lib/python3.8/site-packages/torch/utils/data/_utils/fetch.py", line 32, in fetch
    data.append(next(self.dataset_iter))
  File "/home/sanchitgandhi/datasets/src/datasets/iterable_dataset.py", line 986, in __iter__
    yield from self._iter_pytorch(ex_iterable)
  File "/home/sanchitgandhi/datasets/src/datasets/iterable_dataset.py", line 920, in _iter_pytorch
    for key, example in ex_iterable.shard_data_sources(worker_info.id, worker_info.num_workers):
  File "/home/sanchitgandhi/datasets/src/datasets/iterable_dataset.py", line 540, in shard_data_sources
    self.ex_iterable.shard_data_sources(worker_id, num_workers),
  File "/home/sanchitgandhi/datasets/src/datasets/iterable_dataset.py", line 796, in shard_data_sources
    self.ex_iterable.shard_data_sources(worker_id, num_workers),
  File "/home/sanchitgandhi/datasets/src/datasets/iterable_dataset.py", line 126, in shard_data_sources
    requested_gen_kwargs = _merge_gen_kwargs([gen_kwargs_list[i] for i in shard_indices])
  File "/home/sanchitgandhi/datasets/src/datasets/utils/sharding.py", line 76, in _merge_gen_kwargs
    for key in gen_kwargs_list[0]
IndexError: list index out of range

Expected behavior
Should pass for both 5 and 7 examples
Environment info

datasets version: 2.12.1.dev0
Platform: Linux-5.13.0-1023-gcp-x86_64-with-glibc2.29
Python version: 3.8.10
Huggingface_hub version: 0.14.1
PyArrow version: 12.0.0
Pandas version: 2.0.1

cc @lhoestq in case you have any ideas here!

I am also facing the same problem. Could you let me know if you found a solution for this?

I couldn't reproduce with the latest version of datasets 2.16.1, can you update datasets and try again ?


Need to let users manually install runners

The WebGL runner should be the default runner bundled with the engine but others should be user installed into core workspace folder.
This will help lower the installer size and let users create their own custom installers.

All of the runners have been removed from the main system folder in the Game Creator.


When using HEX value for color, it accepts it but can't recognise that the brace is correctly closed

Challenge Waypoint: Use CSS Selectors to Style Elements has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.86 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.

Looks like test search for the word blue (see this line) but actually one can specify #0000FF or even rgb(0, 0, 255). The result will be as expected but this test won't pass. We can replace blue with .* (which means any character).

Please review the Guidelines for Contributing, thank you!.


SSR hydration error with redirect: true

How to reproduce :

Clone this minimal project https://github.com/aureldussauge/gatsby-error-i18n
Run npm start
Configure your browser to have french as default language
Go to localhost:8000/

The redirection is causing a hydration error

Same issue.
After switching the language from the main language (for example, thewebsite.com), it will now redirect me to thewebsite.com/es/ for example. Now when the second language is remembered as a choice, when If I try to access the website directly typing its URL (thewebsite.com) without language path, it gives 2 errors Error #418 and Error #423:
react-dom.production.min.js:132 Uncaught Error: Minified React error #418; visit https://reactjs.org/docs/error-decoder.html?invariant=418 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at fa (react-dom.production.min.js:132:198)
    at qu (react-dom.production.min.js:226:193)
    at ks (react-dom.production.min.js:281:85)
    at bs (react-dom.production.min.js:280:450)
    at vs (react-dom.production.min.js:280:320)
    at gs (react-dom.production.min.js:280:180)
    at ls (react-dom.production.min.js:268:209)
    at S (scheduler.production.min.js:13:203)
    at MessagePort.T (scheduler.production.min.js:14:128)
fa @ react-dom.production.min.js:132
qu @ react-dom.production.min.js:226
ks @ react-dom.production.min.js:281
bs @ react-dom.production.min.js:280
vs @ react-dom.production.min.js:280
gs @ react-dom.production.min.js:280
ls @ react-dom.production.min.js:268
S @ scheduler.production.min.js:13
T @ scheduler.production.min.js:14
react-dom.production.min.js:293 Uncaught Error: Minified React error #423; visit https://reactjs.org/docs/error-decoder.html?invariant=423 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
    at xi (react-dom.production.min.js:293:39)
    at bs (react-dom.production.min.js:280:389)
    at vs (react-dom.production.min.js:280:320)
    at gs (react-dom.production.min.js:280:180)
    at as (react-dom.production.min.js:271:88)
    at ls (react-dom.production.min.js:268:429)
    at S (scheduler.production.min.js:13:203)
    at MessagePort.T (scheduler.production.min.js:14:128)

I'm also experience this.

I’m still having the same issue.


Android compatible

Because libc lacks the Android platform api, it cannot be used on Android. Modify the compilation condition to be compatible with Android platform.

Merged. Thanks!


Use staff subdomain for prison urls

We want staff emails to use a subdomain so that requests can be routed to the
pvb2, without this they'd be routed to the public app once deployed.

This is the best approach I can think off, don't like that one must remember to use the shared email config method, if you know of a better way let me know!

Only to be merged once the subdomain has been set up


Modifying XLS file saves it to XLSX format

Hello,
I have an XLS file - I read it:
var workbook = XLSX.readFile('./template/amendments.xls');

I don't even modify it - and write it back out:
XLSX.writeFile(workbook, './template/amendments-2.xls');

The resulting file cannot be previewed/opened - if I save it with the .xslx extension it works.
Have you dropped support for the xls format? Documentation suggests it is supported: https://docs.sheetjs.com/#supported-output-formats
I've added the bookType with biff8 but still unviewable. I don't think the file I'm using is relevant.
Thank you

Can you share that amendments.xls file?  GH doesn't support XLS attachments so please send an email to support [at] sheetjs [dot] com and attach the file

Hello - I've forwarded over. Let me know if you need any more information

Any updates? I'm facing the same issue on Numbers

@clicktravel-antonrand @guojiaqi1027 finally had a moment to dig further, this is a funny issue with a fortunately easy fix.  If you'd like to submit this as a PR we'd accept:
+++ b/bits/78_writebiff.js
@@ -191,7 +191,7 @@ function write_ws_biff8(idx/*:number*/, opts, wb/*:Workbook*/) {
        write_biff_rec(ba, "HCenter", writebool(false));
        write_biff_rec(ba, "VCenter", writebool(false));
        /* ... */
-       write_biff_rec(ba, "Dimensions", write_Dimensions(range, opts));
+       write_biff_rec(ba, 0x200, write_Dimensions(range, opts));
        /* ... */

        if(b8) ws['!links'] = [];

Explanation: BIFF8 XLS, like other BIFF formats, ultimately stores the data and metadata as a stream of records.  There are two officially recognized record types for the Dimensions record (which stores the worksheet dimensions):

0x200 = 512 (record enumeration table at https://msdn.microsoft.com/en-us/library/dd945945.aspx)
0x000 = 0 (used in old Excel versions like Excel 3.0, see page 14 of http://www.idea2ic.com/File_Formats/excel_biff.pdf)

For some reason, Numbers only accepts the first type but Excel accepts both.  Version 0.12.1 added support for the 0-type Dimensions record, which changed the export record type.  The included change forces the 512 record type


example of zoom to fit for a group of meshes with react three fiber

does anyone have an example of how to call a zoom to fit function with this library?

You could compute bounds in the scene and put your camera at the right place, or render your content according to the viewport. The following will create a plane that fits exactly the screen, and if you resize the window, it will re-render accordingly.
const { viewport } = useThree()

return (
  <mesh>
    <planeBufferGeometry attach="geometry" args={[viewport.width, viewport.height ]} />
    <meshBasicMaterial attach="material" color="hotpink" />
  </mesh>
)

@drcmda i am looking for an example where i have a group of meshes that are made up of shape geometry. Once the scene has updated i can call a function like below where object is the group of meshes.
const fitCameraToObject = function(camera, object, offset, controls) {
	offset = offset || 1.25;

	const boundingBox = new THREE.Box3();

	// get bounding box of object - this will be used to setup controls and camera
	boundingBox.setFromObject(object);

	const center = boundingBox.getCenter();

	const size = boundingBox.getSize();

	// get the max side of the bounding box (fits to width OR height as needed )
	const maxDim = Math.max(size.x, size.y, size.z);
	const fov = camera.fov * (Math.PI / 180);
	let cameraZ = Math.abs(maxDim / 4 * Math.tan(fov * 2));

	cameraZ *= offset; // zoom out a little so that objects don't fill the screen

	camera.position.z = cameraZ;

	const minZ = boundingBox.min.z;
	const cameraToFarEdge = minZ < 0 ? -minZ + cameraZ : cameraZ - minZ;

	camera.far = cameraToFarEdge * 3;
	camera.updateProjectionMatrix();

	if (controls) {
		// set camera to rotate around center of loaded object
		controls.target = center;

		// prevent camera from zooming out far enough to create far plane cutoff
		controls.maxDistance = cameraToFarEdge * 2;

		controls.saveState();
	} else {
		camera.lookAt(center);
	}
};

You can do that. UseThree gives you access to the scene and the camera.

Here's an example of how I'm adjusting the camera to a desired size. You could probably combine it with the code above for your needs.
const Camera = () => {
  const camera = useRef()
  const { aspect, size, setDefaultCamera } = useThree()
  const pixelToThreeUnitRatio = 1
  const planeDistance = 0
  const cameraDistance = 500
  const distance = cameraDistance - planeDistance
  const height = size.height / pixelToThreeUnitRatio
  const halfFovRadians = Math.atan((height / 2) / distance)
  const fov = 2 * halfFovRadians * (180/Math.PI)
  useEffect(() => void setDefaultCamera(camera.current), [])
  return <perspectiveCamera
    ref={camera}
    aspect={aspect}
    fov={fov}
    position={[0, 0, cameraDistance]}
    onUpdate={self => self.updateProjectionMatrix()}
  />
}

const App = () => {
 return (
    <Canvas >
      <Camera />
      <Content />
    </Canvas>
  );
}

thanks @drcmda @ryanking1809
const Content = ({ url }) => {
	let group = useRef();
	let axis = useRef();
	let controls = useRef();
	const [ data, loading ] = useFetch(url);
	const { camera } = useThree();
	camera.up.set(0, 0, 1);
	camera.position.z = 4;

	if (!loading) {
		const json = parser.parse(data, options);
		const surfaceJson = json.gbXML.Campus.Surface;
		const surfaceMeshes = getSurfaceMeshes(surfaceJson);
		if (group.current) {
			const bbox = new THREE.Box3().setFromObject(group.current);

			const sphere = bbox.getBoundingSphere(new THREE.Sphere());
			const { center, radius } = sphere;

			controls.current.reset();
			controls.current.target.copy(center);
			controls.current.maxDistance = 5 * radius;

			camera.position.copy(center.clone().add(new THREE.Vector3(1.0 * radius, -1.0 * radius, 1.0 * radius)));
			camera.far = 10 * radius;
			camera.updateProjectionMatrix();
			if (axis.current) {
				axis.current.scale.set(radius, radius, radius);
				axis.current.position.copy(center);
			}
		}

		//console.log(scene, controls, camera);

		return (
			<Fragment>
				<ambientLight color="#444444" />
				<pointLight color="white" intensity={0.5} position={[ 0, 0, 1 ]} />
				<directionalLight castShadows />
				<axesHelper ref={axis} />
				<orbitControls ref={controls} args={[ camera ]} />
				<group ref={group} name="meshes">
					{surfaceMeshes.map((mesh, index) => (
						<primitive
							key={index}
							onClick={({ object: { userData: data } }) => console.log(data)}
							object={mesh}
						/>
					))}
				</group>
			</Fragment>
		);
	}
	return <group />;
};

@drcmda love the library, tying this in with graphql and redux is gonna be so sweet.

Just to help others out, I got the desired effect working with an orthographic camera by setting the zoom.
const { camera, size: { width, height } } = useThree();

const aabb = new THREE.Box3().setFromObject(someObject3D);

camera.zoom = Math.min(
  width / (aabb.max.x - aabb.min.x),
  height / (aabb.max.y - aabb.min.y)
);
camera.updateProjectionMatrix();

Sorry for the Noob qestion @partynikko.
Where do I put this code inside a React.Component? I have an array of meshes I get asynchronously and render , and I want to adjust the camera once I'm done..

better not a react class component, this lib's targeted for function components and hooks. there's only one rule: your function shouldn't have any side-effects in it, do not create or mutate objects smack in it.
function Meshes({ url }) {
  const { camera } = useThree()
  const [meshes, setMeshes] = useState([])
  useEffect(() => {
    fetchMeshes(url).then(setMeshes).then(() => camera.position.set(0,0,0))
  }, [url])
return meshes.map(data => (
  <mesh>
    ...

Sorry for the Noob qestion @partynikko.
Where do I put this code inside a React.Component? I have an array of meshes I get asynchronously and render , and I want to adjust the camera once I'm done..

Hi there, no issues!
I agree what drcmda wrote. However, if you post the code you are working with it will be easier to suggest an approach for you :)


Add lmh-224213's file

created a branch, created a file and made a commit, and opened a pull request

created a branch, created a file and made a commit, and opened a pull request


str(request.headers) is empty

Greetings from changedetection.io, thanks for your work!
Our tests started failing, turns out related (somehow) to Werkzeug 3.1.0
We have a test endpoint that is looking at the headers that were sent with a request
https://github.com/dgtlmoon/changedetection.io/blob/7029d10f8bd22ac2379fcfe70bf57b67ebee69fc/changedetectionio/tests/util.py#L231
for example
    # Where we POST to as a notification
    @live_server.app.route('/test_notification_endpoint', methods=['POST', 'GET'])
    def test_notification_endpoint():
        p = request.headers

but request.headers is always empty (by empty i mean contains \r\n), downgrading to 3.0.6 fixed it (from 3.1.0)
Tried python 3.10, 3.11, and 3.12
pytest                       7.4.4
pytest-flask                 1.3.0
Werkzeug                     3.0.6 (this version is OK)

Strangely, all other variables in request look perfectly OK, tcpdump shows the headers are being sent without problem, HTTP_ type vars in the request look OK too
thanks!

for anyone passing by: this also messes up reqparse of flask_restful

I can't reproduce this issue with the information provided. The following echoes back all headers sent by the browser:
from flask import Flask, request

app = Flask(__name__)

@app.route("/")
def echo():
    return request.headers.to_wsgi_list()

Header code was refactored a bit when moving the type annotations in, but all tests continue to pass in both Werkzeug and Flask. If you can create a minimal reproducible example, I do want to trace what's happening.

Hmm as a stand alone flask application I can also not reproduce it, but I can reproduce it in my pytest endpoint

I think I might have a reproducible example, if I return str(request.headers), Headers.__str__ seems to be returning an empty string, so something happened. I might know what happened, I'll step through with a debugger for a bit.

Aha, I was too clever. Headers stores a list of headers internally, and I thought I'd save some function calls/iterator setup by iterating over that list directly in __str__. EnvironHeaders (what request.headers is) subclasses Headers but ignores the internal list and uses the environ dict instead. So my refactor accidentally made it always look at the empty internal list instead of calling __iter__. I'll fix that and have 3.1.1 soon.

Calls with app.test_client() always gives status 401 for us with 4.1.0. Works fine with 4.0.6.
Using flask_restx. Tests running in RHEL 8 and Windows 10. Same thing on both platforms.

@magnus-lycka It doesn't sound like that's related to this. Can you please report a separate bug with a minimal reproducible example?

@magnus-lycka It doesn't sound like that's related to this. Can you please report a separate bug with a minimal reproducible example?

I think it's the same issue. If headers are gone, I assume our auth won't work. This is a pretty big old monolith, and I'm definitely not able to create something reproducible this week. It's 16:46 Friday... I just noticed that 93 unit tests suddenly failed, with assertion for all sorts of values of status suddenly all being 401. Not sure how that works. Pinning to 3.0.6. for now, and will let you know if a fix for this missing headers problem fixes my problem or not.

@magnus-lycka I understand now, yeah if you're sending custom auth headers maybe this is related. I'm about to release 3.1.1 then, open a new issue if it persists after that. I tried to play around with test_client() really quick, but Flask and Werkzeug's tests with it all still pass before this fix.

thank you so much!

Turns out my optimism was unfounded. My issue remains with 3.1.1. Sigh... I'll try to distill my issue and file a new issue.


In shared data mode, when the Partitioned Prefix feature is enabled, the S3 storage path of the table is displayed incorrectly

Steps to reproduce the behavior (Required)

CREATE STORAGE VOLUME s3_volume
TYPE = S3
LOCATIONS = ("s3://xxxx")
PROPERTIES
(
"aws.s3.region" = "us-east-1",
"aws.s3.endpoint" = "https://s3.us-east-1.amazonaws.com",
"aws.s3.use_aws_sdk_default_behavior" = "false",
"aws.s3.use_instance_profile" = "false",
"aws.s3.access_key" = "xxxxxxxxx",
"aws.s3.secret_key" = "xxxxxxxxx",
"aws.s3.enable_partitioned_prefix" = "true",
"aws.s3.num_partitioned_prefix" = "1024"
);

Insert Data

show proc  "/dbs/tpcds100";
Expected behavior (Required)

TableId
TableName
StoragePath

16942
partition_name
s3://starrocks-volume/133/9d829e5c-3a3f-44a1-8be8-f2719941138c/db16172/16942

16435
date_dim
s3://starrocks-volume/23/9d829e5c-3a3f-44a1-8be8-f2719941138c/db16172/16435

16431
inventory
s3://starrocks-volume/24/9d829e5c-3a3f-44a1-8be8-f2719941138c/db16172/16431

16947
web_site
s3://starrocks-volume/232/9d829e5c-3a3f-44a1-8be8-f2719941138c/db16172/16947

Real behavior (Required)

TableId
TableName
StoragePath

16942
partition_name
s3://starrocks-volume/19d829e5c-3a3f-44a1-8be8-f2719941138c/db16172/16942

16435
date_dim
s3://starrocks-volume/9d829e5c-3a3f-44a1-8be8-f2719941138c/db16172/16435

16431
inventory
s3://starrocks-volume/9d829e5c-3a3f-44a1-8be8-f2719941138c/db16172/16431

16947
web_site
s3://starrocks-volume/9d829e5c-3a3f-44a1-8be8-f2719941138c/db16172/16947

StarRocks version (Required)

3.2.9

For a certain table, its data can be spread to several prefixes, the prefix is determined down to partition level. It makes no way to have a determined prefix for a table.
Will add the path prefix info down to partition level, so the storagePath info can be shown correctly for the partition.

Actually the information ca be retrieved from information_schema.partitions_meta, try following sql
SELECT * FROM information_schema.partitions_meta WHERE table_name = 'partition_name'

There is a column named STORAGE_PATH, it will provide you the actual storage path used in a partitioned_prefix enabled storage volume scenario.


User Provided Prompts

GIVEN a command-line application that accepts user input
WHEN I am prompted for information about my application repository
THEN a high-quality, professional README.md is generated with the title of my project and sections entitled Description, Table of Contents, Installation, Usage, License, Contributing, Tests, and Questions

I've been able to add user-input prompts via the 'user-questions' tree.
Working on adding functionality for the user-inputted data so it corresponds with the README.md file

I've now been able to take the users inputted data and insert it into a readme.md file.
Working on getting the user data properly displayed and formatted within the readme.md file.

The repository is now able to generate a user inputted title for the README file.
Working on the code to take the rest of the users responses and properly format it for the user generated README file.

README Generator is now able to pass in a users email and create a link to the users GitHub page by providing their GitHub username!

Repository can now display categories properly onto the README file with the users inputted data!
Currently working on adjusting flavor text for each category and implementing Licensing section.


Removed Accompanist System UI Controller because of its deprication

Removed Accompanist System UI Controller because of its deprication

Hey @AdityaKumdale  can you please fix the ktlint check.
Just run ./gradlew ktlintCheck --continue in your terminal and check which lines are showing the error.


Errors in 'Getting Started' documentation

Do you want to request a feature or report a bug?
Documentation error

What is the current behavior?
The browser fails to load the compiled .js as the resource can not be found
If the current behavior is a bug, please provide the steps to reproduce.
Follow the Getting Started guide

What is the expected behavior?
The compiled .js should be loaded by the browser
If this is a feature request, what is motivation or use case for changing the behavior?
Please mention other relevant information such as the browser version, Node.js version, webpack version, and Operating System.
Under the Creating a Bundle section, it states the output from running npx webpack should be:
Entrypoint main = bundle.js
But it is in fact
Entrypoint main = main.js
Consequently, the browser fails to load the .js from the location the example states:
<script src="dist/bundle.js"></script>
Also, as the guide instructs the reader to move index.html in to dist/, the path in the example is incorrect and should actually be:
<script src="main.js"></script>

@webpack-bot move to webpack/webpack.js.org


[Improvement] API specification

Currently PwnDoc-ng offers a very useful api at /api, however no specification or documentation for this is available. As mentioned in the Pwndoc repository issue #183, could it be possible to implement this for PwnDoc-NG?
There are solutions available that should be able to automatically generate and offer a swagger interface for testing it, though I'm not sure about how viable these solutions/libraries are.

I've submitted PR #30 to generate basic swagger docs and expose the UI on /api-docs.


A RenderFlex overflowed by 72 pixels on the bottom.

he following assertion was thrown during layout:
I/flutter ( 6530): A RenderFlex overflowed by 72 pixels on the bottom.
I/flutter ( 6530):
I/flutter ( 6530): Widget creation tracking is currently disabled. Enabling it enables improved error messages. It can
I/flutter ( 6530): be enabled by passing --track-widget-creation to flutter run or flutter test.
PS: I added resizeToAvoidBottomPadding: false, but its showing issue in emulator

It all worked out with
Scaffold(
resizeToAvoidBottomInset: false, // set it to false
body: SingleChildScrollView(child: YourBody()),
)


Support to delete a credential which in a folder

Codecov Report
Base: 71.91% // Head: 71.99% // Increases project coverage by +0.08% :tada:

Coverage data is based on head (977680d) compared to base (52f6648).
Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 977680d differs from pull request most recent head 6ed2145. Consider uploading reports for the commit 6ed2145 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   71.91%   71.99%   +0.08%
==========================================
  Files          36       36
  Lines        2065     2071       +6
==========================================
+ Hits         1485     1491       +6
  Misses        513      513
  Partials       67       67

Flag
Coverage Δ

unittests
71.99% <100.00%> (+0.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/credential/credentials.go
100.00% <100.00%> (ø)

pkg/credential/credentials_test_common.go
96.00% <100.00%> (+0.25%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


removed the duplicate create_bag_files call in download view func

Pull Request Checklist:

[ ] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

[Enter positive test case here]

METRIC
VALUE

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4026


[instancer] Fix output filename decision-making

All limits are tuples now when not None. The old logic was broken and for the following command:
$ fonttools varLib.instancer  AdobeVFPrototype.otf CNTR=50:80 wght=900
it was saving the output with the name suffix -instance, whereas it's clearly a partial instantiation. This fixes that.

Sorry I don't have tests for this.

LGTM. Tested locally with wght="drop", wght=900 or wght=900:900 and all work


added pacget

A fully foss, lightweight fuzzysearching TUI frontend for pacstall using fzf

@erikLundstedt When using removescript, there needs to be a variable removescript="yes" to actually execute the code when the pacscript is getting uninstalled.

You don't need Ubuntu and Debian variables in the script. Also wrap the version in quotes

I do that so it's easier for the user when reading the pacscript
And it's not like it's hurting anything

Also don't use variables besides the ones pacstall uses. Use paths instead

I can do this, but is there a good reason for it
The way I did it now makes script reuse a lot easier

To be blunt, I won't merge it unless you use paths instead of variables. It may be easier for you, but for the majority of people, it's going to be difficult

To be blunt, I won't merge it unless you use paths instead of variables. It may be easier for you, but for the majority of people, it's going to be difficult

Okay

Also why /tmp/pacget? /tmp lives in memory so it gets wiped on reboot or shutdown?

Also why /tmp/pacget? /tmp lives in memory so it gets wiped on reboot or shutdown?

thats the point
the file in/tmp/pacget gets uppdated each run to keep upp to date
only if you implemented my update function into the main program (maybe on -U it also refreshes the packagelist
)would i be able to change that
(feel free to use non-essential parts of my code, like the update function)
the reason its in the pacscript is to make first run a little bit smoother

Can't you just get pacget to make a directory if it doesn't exist with mkdir -p /tmp/pacget? Also pacstall -U updates the scripts, not the packagelist. If you think about the AUR, if helpers downloaded a manifest of every package available, it would be gigantic


[Feature] Customise Ray head service in RayCluster CR

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
I would like to be able to customise the Ray head service that's created as part of the RayCluster CR. See the use case below for more details.
Use case
I'm using KubeRay to deploy a Ray cluster to Kubernetes. To enable TLS between pods I'm using Open Service Mesh (OSM), and to make Ray work I need to add a field appProtocol to the ports in the head service (see YAML below). I can do this by patching the service after it has been created, but it would be good to have a way to customise the service in the RayCluster CR.

ports:
  - appProtocol: tcp
    name: client
    port: 10001
    protocol: TCP
    targetPort: 10001
  - appProtocol: tcp
    name: dashboard
    port: 8265
    protocol: TCP
    targetPort: 8265
  - appProtocol: tcp
    name: redis
    port: 6379
    protocol: TCP
    targetPort: 6379
  - appProtocol: tcp
    name: metrics
    port: 8080
    protocol: TCP
    targetPort: 8080

Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Thanks for posting this. We need to think about how best to expose this configuration in the RayCluster CR.
I don't have immediate thoughts on this, but commenting anyway, to make sure I'm subscribed to the discussion thread!

Being able to modify aspects of the head service other than the service type is a natural ask! I wonder if we can take config inspiration from similar operators in the K8s ecosystem.

See also this following request for head service configurability:
https://discuss.ray.io/t/exposing-kuberay-prometheus-metrics-configuration-on-head-service-annotations/7806/

Solved in
https://github.com/ray-project/kuberay/pull/668


displayName contains nonstandard characters

Hi,
On my computer, with a french version of VS, the locator (tagged: "Visual Studio Locator version 2.1.3 [query version <IP_ADDRESS>697]") returns the following string for displayName :
displayName: Visual Studio Community�2017

(the ? being a 0xFF)
Since the VSCode CMake extension relies on this, it breaks pretty much everything on my builds with VS2017 right now.

It's likely an encoding issue. Please see https://github.com/Microsoft/vswhere/wiki/Encoding. Your system encoding should correspond to your UI language, or you need to make sure your shell environment corresponds at least.

I can also confirm that the display strings for several editions do use something other than a space, though I can't reproduce it causing a problem using the fr-FR locale even with console code page 437 (default for en-US as well). What code page is your console set to? (You can use chcp to display it.)

For what it's worth, the source character is actually extended ASCII character 0xC2 (194), which with an 850 OEM code page is ending up as 0xFF (255). The UTF-8 and Windows-1252 code pages do convert this to a supported space character.
I've filed a bug internally to fix this (if possible) in the product definitions (i.e. not a vswhere bug), but hopefully changing your code page helps.


Rename reserved node id 'must_join_elected_master' to 'must_join_elected_cluster_manager' that used by in DetachClusterCommand

Description
To support inclusive language, replace "master" with "cluster manager".

Replace public field MUST_JOIN_ELECTED_MASTER with MUST_JOIN_ELECTED_CLUSTER_MANAGER in VotingConfiguration class
Rename the preserved node id _must_join_elected_master_ to _must_join_elected_cluster_manager_

The original _must_join_elected_master_ is only used as a preserved node id for "Detach Cluster Command" (https://github.com/opensearch-project/OpenSearch/blob/1.3.1/server/src/main/java/org/opensearch/cluster/coordination/DetachClusterCommand.java#L89).
"Detach Cluster Command" ./bin/opensearch-node detach-cluster can detach a node from its cluster by resetting its cluster UUID. The node can then join another cluster with a different UUID. _must_join_elected_master_ is set as a node id and used as an identifier for the node processed by "Detach Cluster Command".
Reference: https://www.elastic.co/guide/en/elasticsearch/reference/7.10/node-tool.html#node-tool-detach-cluster
Issues Resolved
A part of #1548 , #1684
Check List

[ ] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Created backport PR https://github.com/opensearch-project/OpenSearch/pull/3138 to deprecate VotingConfiguration.MUST_JOIN_ELECTED_MASTER in 2.x version


How can I get params.npz file?

I tried to run python the following code in README.md: (benchmarking)
python scripts/splatam.py configs/replica/splatam.py
But I cannot find params.npz anywhere.
However if I change this config
save_checkpoints=True, # Save Checkpoints
I get a set of params.ply in experiments/Replica/room0_0, but I still cannot get final result.
Where can I obtain the final result?

I don't know what the reason is, but after changing to a different scene, I successfully generated the target file.


Upgrade rails

Summary
Upgrade to catch latest rails point release with security patches.
/domain @Betterment/test_track_core
/no-platform

<<domainlgtm


Make condition collection a first class citizen

This PR builds on top of https://github.com/aspnet/BasicMiddleware/pull/169 and cleans up the conditions model. It adds a dedicated ConditionsCollection.

Hi @davidpeden3, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@Tratcher i've branched this work off of the global rules branch. if you like this, i'd prefer to roll it in to my global rules branch asap so that i'm not maintaining a branch of a branch.

@Tratcher
Sure, sorry. I had been heads-down in the code for a bit did not explain the context I had in my head. Of course this PR needs more clarity.
This branch off of the globalrules branch does two things:
First, it addresses the Condition abstraction issues I've gotten to know while working in the codebase.
Conditions are passed around as an IList and expose an OrNext property. The only reason this property exists on Condition is to support ConditionHelper.Evaluate. In the absence of a proper collection which should contain this property (as well as TrackAllCaptures), the condition itself maintains state. This PR creates a dedicated collection for Conditions and also houses the grouping and trackAllCaptures at the appropriate level which cleans up a lot of the related classes.
e.g.,:
Each individual Condition should not expose the behavior of the collection. With this implementation, it's possible to define different values per Condition which is invalid via file-based configuration:
https://github.com/aspnet/BasicMiddleware/pull/198/commits/347d7bd455e9b536422f48006553e2714f894f02#diff-b9bceaec9393b4ce7c2e1a9057e1ad9fL22
It doesn't make any sense to have to pass trackAllCaptures to a method that parses a Condition:
https://github.com/aspnet/BasicMiddleware/pull/198/files#diff-4e6cd3225a4ad73df916578745fa9724L121
Second, when I originally set out to implement global rules, I was literally translating the observed behavior we had configured in IIS to this middleware. For global rules, that turned out to be that the full URI was evaluated for matches, not just the path. I built that without much consideration to the rest of the codebase (I simply wasn't as familiar with it as I am today).
But it turns out that there is demand for greater flexibility than that and that it would be great for local (non-global) rules to also be able to benefit from full URI comparison:
https://github.com/aspnet/BasicMiddleware/issues/174
and
https://github.com/aspnet/BasicMiddleware/issues/196
So, it made more sense to me to adjust the code to reflect matching URIs on a path/full basis explicitly rather than implicitly from global rules.


can't find the module 'rekognition_online_action_detection'

Hi! Why i can't find the module 'rekognition_online_action_detection'?

Thank you! I have solved this problem!

@Chenhongchang How did you resolve it?

@Chenhongchang How did you resolve it?

Hi! you can add you path in the four line of code, which is sys.path.append(“/path/to/src”).


Updated Example Plugin to the new API being used by lights, servo, etc

Tested in mock mode. Testing on a BBB next.

Tested on BBB/2x hardware. Good to go.


high resolution

Quite a few things are happening here. We'll probably have to clean up the code a lot because I wrote it on the train and while walking in the main station, but the concepts are simple.

Instead of using .repeat_interleave() and .expand(), this PR uses only .expand() greatly reducing memory usage (this change alone allows 3072x3072 on one 3090)
A simple "size" argument for the generator
Warmup / Cooldown for guidance factor instead of a pure constant factor
CFG only when using FABRIC (perfect when using it only on the first half of the steps, which reduces runtime cost from (2+K)F to (2+K)F/2 + F while improving image quality noticeably)
fused forward pass of positive samples and batch, removing the entire "hidden state caching" and CPU offload business, shaving off another 5% - 10% of runtime while halving memory usage in my one test

Finally, this PR  removes negative images. As they are an intended feature, adding them back into the code might be required. (Not difficult, just tedious.)

(3) and (4) together allow the creating of 1024x1024 images as below

compared to the unguided baseline

and default fabric

Very cool, thank you! Already looking great, love the optimizations and high-res images.
As far as what's required to merge: Yes, indeed, negative feedback is kind of an integral feature so we should try and add back support for that. Also, if possible, we should avoid requiring the xformers dependency, especially when nowadays PyTorch 2.0 is pretty much the norm and most people have access to F.scaled_dot_product_attention.


Fix GH-22 (TypeError with Streamlit 0.84)

In Streamlit 0.84, component_value is a str with JSON-encoded data, rather than a dict as with previous Streamlit versions.
Added a check for str and if it's a str, we decode the JSON into a dict.
Fixes: GH-22

This is a crucial fix for the latest streamlit 0.84. @PablocFonseca

@PablocFonseca For me this PR is also critical in order to use streamlit-aggrid with the latest Streamlit Version 0.84.
Which implements session states: https://blog.streamlit.io/session-state-for-streamlit/
For now, will fork the repo only to include this Pull Request :)
Thanks


Remove leading './'

Rspec reports failed examples as
./path/to/file.rb

When double clicking on the path in order to copy it, ./ gets copied too, which is why I would like to have it filtered out in the fuzzy finder.
TODOs:

[ ] Currently, './file will find file.rb, even without the path. Should this only find complete paths?
[ ] I added a spec that didn't pass before, but passes now, so I'm assuming that's okay. However, in other specs there are more expectations, so I'm not sure if I should check if the correct file is opened etc.

@as-cii is there reason why we can't do it? I saw few issues and found this MR, but no responses in them if there are something preventing us from having this feature.

I believe this change could be reasonable and I cannot think of any possible drawbacks.
Before reviewing this, though, I think it would be good to rebase it on top of master (or even create a new branch, considering this repository has changed a lot since this pull request was opened).
@atom/maintainers: what do you think? 💭

What problem is this trying to solve? Are some files not being found until the ./ is removed?

@lee-dohm yes, it's valid unix path, when you get this path from 3rd party app/output and try to put in fuzzy finder you need to remove ./

@lee-dohm Yes, some tools report paths with a leading ./. When copy-and-pasting the path into the fuzzy finder, those files will not be found without removing it first.
Do you want me to rebase this on master?

This also annoys me, if I fix the conflicts would the PR be accepted?

Thanks for the pings on this.
In our weekly triage meeting yesterday, the maintainers decided that this violates the Principle of Least Surprise. While this may be a very obvious and useful change for you, there are a couple million other Atom users for whom this may not be obvious or benign. Because of this, we have decided to not accept this change.
Thank you all very much for your feedback and the work invested in this pull request.


Create custom field page scaffolding

Description
In order to make PR diffs easier to read it will be helpful to have the initial page creation be done in a dedicated PR that only includes a very minimal interface. This will be merged in a feature branch so the incomplete pages are not merged into main.
Acceptance Criteria

Add new custom fields table page to management tab /management/custom-field

Rendering a list of each custom field will suffice for new

instead of a feature branch, would it work to use our feature flags with the userCannotModify flag set to true? I'm thinking that'll make merge conflicts easier to handle (especially if we'll be refactoring the tables which touch both custom fields and privacy notices)

Sure, I can do that if that's what you prefer. The feature branch was supposed to make things easier but if it makes things worse then lets utilize the flags instead. It makes sense when factoring in the table refactor as well.


Fix #295

Also update Forge and add Baubles because Thaumcraft needed it

Why not just do if (offY <= 0) return false;?


Show cacheable parameter in the doc of DataNodeConfig and wrong type of **properties

cacheable parameter is not shown in the parameters of the DataNodeConfig. It is hidden by **properties. It should be documented somewhere.
Moreover, **properties seems to have the wrong type (taipy.core.Scope) on this page.

@FlorianJacta
A quick update for you regarding this ticket :D We (me and JR) have decided to move the cacheable parameter out of the **properties. This should help improve user experience through code-suggestion and make documentation a lot easier and cleaner as well :D

Very good idea. I think we should do the same for any important parameters that are in the **properties if any


Replace ru_name with display_adderss

What is the context of this PR?
https://trello.com/c/iugfWgRR/2392-add-address-fields-to-lms-schema
Just like the lms_1 survey, lms_2 needs a display address so that people can confirm their address.
How to review
display_address should appear as a metadata field when you open it in launcher.  The the address questions should contain that display_address that was passed through.
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

Added don't merge label while I make sure that this is the correct solution

Got the requirements, this needs to be changed a bit so closing the PR


minio: set version to a valid datetime string

Motivation for this change
Minio verifies on each RPC call that the server version returned by the API is a valid datetime string (https://github.com/minio/minio/blob/3a0e7347cad25c60b2e51ff3194588b34d9e424c/browser/app/js/web.js#L51-L53).
When returning the version as "2021-04-22T15-44-28Z" the this check fails and the login (and all other RPC calls) in the minio browser are not possible:

Is there a cleaner way to replace just the last two dashes in "2021-04-22T15-44-28Z" with colons so that the version attribute can be left as-is and only the part in the patchPhase will be adjusted?
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

{ lib, buildGoModule, fetchFromGitHub, nixosTests }:

let
  modifyTimestamp = version:
    let
      splitTS = builtins.elemAt (builtins.split "(.*)(T.*)" version) 1;
    in
    builtins.concatStringsSep "" [ (builtins.elemAt splitTS 0) (builtins.replaceStrings [ "-" ] [ ":" ] (builtins.elemAt splitTS 1)) ];
in
buildGoModule rec {
  pname = "minio";
  version = "2021-04-22T15-44-28Z";

  src = fetchFromGitHub {
    owner = "minio";
    repo = "minio";
    rev = "RELEASE.${version}";
    sha256 = "147a4vgf2hdpbndska443axzvxx56bmc0011m3cq4ca1vm783k8q";
  };

  vendorSha256 = "0qj1zab97q8s5gy7a304wqi832y8m083cnk8hllz8lz9yjcw6q92";

  doCheck = false;

  subPackages = [ "." ];

  patchPhase = ''
    sed -i "s/Version.*/Version = \"${modifyTimestamp version}\"/g" cmd/build-constants.go
    grep "Version." cmd/build-constants.go
    sed -i "s/ReleaseTag.*/ReleaseTag = \"RELEASE.${version}\"/g" cmd/build-constants.go
    sed -i "s/CommitID.*/CommitID = \"${src.rev}\"/g" cmd/build-constants.go
  '';

  # ...
}

I came up with this function but it's a bit ugly lol

Result of nixpkgs-review pr 121786 at 8d9165ed run on aarch64-linux 1

1 package built successfully:

minio

1 suggestion:

warning: patch-phase
patchPhase should not be overridden, use postPatch instead.
Near pkgs/servers/minio/default.nix:25:3:
   |
25 |   patchPhase = ''
   |   ^


Add asterisk () after labels of required fields, f.ex. “Display Name ()”

Vuetify v.1.1.0

The required prop no longer explicitly adds an asterisk to the label. All of its functionality to validation was removed for v1.0.

:cry: