Release wheels for alpine linux support

It takes about 20 minutes to build grpcio and grpcio-tools for alpine distributions. Would be great if linux_x86_64 wheels could make the cut for distribution since alpine is popular for docker services.

Steps for reproduction(Ubuntu 18.04):
docker run -it alpine:3.13.0 /bin/sh
apk update && apk add build-base libffi-dev musl-dev python3=3.8.10-r0 python3-dev=3.8.10-r0
python3 -m venv /grpcio_wheel_builder
source /grpcio_wheel_builder/bin/activate
python3 -m pip install --upgrade pip
python3 -m pip install wheel
source /grpcio_wheel_builder/bin/activate
python3 -m pip wheel --no-deps grpcio==1.38.1 grpcio-tools==1.38.1

Collection Output:
14:51:32   Collecting grpcio-tools==1.38.1
14:51:32     Downloading grpcio-tools-1.38.1.tar.gz (2.1 MB)
14:51:35   Requirement already satisfied: pycparser in /material_orchestration/lib/python3.8/site-packages (from cffi>=1.12->cryptography>=2.8->pyOpenSSL~=19.0->material-orchestration==1.0.0) (2.20)
14:51:39   Collecting grpcio>=1.38.1
14:51:39     Downloading grpcio-1.39.0.tar.gz (21.3 MB)

Build Output:
14:51:54     Building wheel for grpcio-tools (setup.py): started
14:52:56     Building wheel for grpcio-tools (setup.py): still running...
14:53:58     Building wheel for grpcio-tools (setup.py): still running...
14:54:59     Building wheel for grpcio-tools (setup.py): still running...
14:55:59     Building wheel for grpcio-tools (setup.py): still running...
14:57:00     Building wheel for grpcio-tools (setup.py): still running...
14:58:12     Building wheel for grpcio-tools (setup.py): still running...
14:58:35     Building wheel for grpcio-tools (setup.py): finished with status 'done'
14:58:36     Created wheel for grpcio-tools: filename=grpcio_tools-1.38.1-cp38-cp38-linux_x86_64.whl size=39160645 sha256=b8ec0a99d65299871ba452386a10b11820eeae5e89270f1cdbc4c3178174195f
14:58:36     Stored in directory: /root/.cache/pip/wheels/35/c5/64/294cb5eb70d0da9cd6a9fdbcdc337f78871ed007d883ef2c96
14:58:36     Building wheel for grpcio (setup.py): started
14:59:36     Building wheel for grpcio (setup.py): still running...
15:00:38     Building wheel for grpcio (setup.py): still running...
15:01:42     Building wheel for grpcio (setup.py): still running...
15:02:42     Building wheel for grpcio (setup.py): still running...
15:03:42     Building wheel for grpcio (setup.py): still running...
15:04:42     Building wheel for grpcio (setup.py): still running...
15:05:43     Building wheel for grpcio (setup.py): still running...
15:06:43     Building wheel for grpcio (setup.py): still running...
15:07:43     Building wheel for grpcio (setup.py): still running...
15:08:44     Building wheel for grpcio (setup.py): still running...
15:10:45     Building wheel for grpcio (setup.py): finished with status 'done'
15:10:46     Created wheel for grpcio: filename=grpcio-1.39.0-cp38-cp38-linux_x86_64.whl size=51231567 sha256=943472c8ab80eb65cb09e9ef8f854e3a5fe797d1f0d69cfe431717b629cfa23c

The available wheels on the download page don't support alpine in this case since manylinux isn't supported on alpine(I believe).

Also you're correct. I mistakenly posted this here. I intended to post this on grpcio. Thanks for the quick response though!

Sounds like an issue for grpcio
Though one thing I'm realizing is that mypy-protobuf itself doesn't actually depend on grpcio - it's only needed to run on the generated code.
Looking to see if I can refactor to remove the direct dependency on grpcio

Filed #270

Wow you seem to have solved my problem in an even better way!


Reports not properly generated with a single dataframe column

MRE:
from numpy.random import Generator, PCG64
from skimpy import skim

seed = 34729
rng = Generator(PCG64(seed))
len_df = 1000
df = pd.DataFrame()
df["length"] = rng.beta(0.5, 0.5, size=len_df)
skim(df)

Not clear where the change came, but this now works!


Removes unused canned scripts and tar.gz publication

We shouldn't be storing things not used, or complicating publication
with duplicate artifacts.
The scripts stored in zipkin's repo are not used at Twitter, not used by
the dist routine, not used by our bin directory, and not used in docker.
At the moment, the tar.gz dist isn't used by anything either. When our
artifact publication works, there's nothing in the tar.gz we can do that
we can't do with the fat jar. Once we have versioned fat jars, we should
change docker to use them.. we don't need a tar.gz IOTW.

cc @rtyler @eirslett @kristofa @jamescway

:+1:

Having the versioned and published fat jars will be great!
:+1:

+1

Thanks for the quick look, folks!


fixed typo in the code

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues

Merged. Thanks!


ux(title bar) - disappearing sign-in button, projects page navigation

Problem:
The Title Bar has a couple of usability issues:

The sign-in button in the title bar "disappears" on hover
You can't navigate back to the /projects page

Fix:

Use the right invocation chant to prohibit the sign-in button returning to its ethereal, translucent form
Make the avatar a link to /projects and hope our saved-state detection is good enough. Maybe this should just open in a new tab tho?

opening it in a new tab is a good idea, I'd add that if it's super easy

@bkrmendy 👍 : updated with target="_blank"


💥 [DevOps] Document Server Infrastructure

💥 DevOps ticket

Document Server Infrastructure

What Servers do we have?

Provider
CPU
RAM
Other metrics

What is running on it?

Do we have monitoring for it?

Security?
Performance?

Backups?

Do we have them?
Of what Servers?
What exactly is backuped?
Where is it backuped to?

Do we need or want to migrate to a different infrastructure?

How could such a infrastructure look like?

What are our expenses for given infrastructure?

I will write it down but not here in the open.
I consider this information security relevant so I will only send it through save channels like keybase.
But not all team members are currently with us in keybase.

Just send me and @clauspeterhuebner a pdf via discord and we will figure out what parts need to be kept private and which can be part of the official documentation <3

I consider discord as unsafe even the PM channel.

I have it uploaded in nextcloud
https://wolke.gradido.net/apps/files/?dir=/Gradido Konzept&fileid=359

Many thanks for this! Do we know anything about the processor/disk/network usage of those servers?
It seems that we might be able to remove the support Server if we combine it with the main server?

CPU is currently not much used,
Main: ~ 500 MB Memory free, disk: > 10 GB free
Support: ~ 300 MB Memory free, disk > 800 GB free
Zammad cannot run on Main, it's need at least 8 GB Ram or 4 GB and an additional server for elastic search with 4 GB:
https://docs.zammad.org/en/latest/prerequisites/hardware.html
We don't use wekan (Kanban-Board) anymore, isn't it? When I remove this, then Gradido should actually run on the support server if it doesn't consume much more resources than wekan.

If someone likes to hack a gradido server direct he needs as much information as possible.
With this documents published in the open half of his work is already done!
We can publish the specs of the server on which gradido is able to run, but why publish all the servers from Gradido-Academy and my private Servers I use for testing?
What is the benefit there?
I don't like my servers configuration out in the open for everyone to read.


ECC support for Key Vault SDK

Description

Added Elliptic Curve Cryptography fields and types to JsonWebKey classes.
Added support to ECDSA algorithms to Key Vault core. The following curves are supported: P-256, P-384, P-521 and SECP256K1.
Miscellaneous cleanups and enhancements.

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] I have read the contribution guidelines.
[x] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. Awaiting PR on swagger spec.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. Awaiting PR on swagger spec.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@msfcolombo,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@msfcolombo
This PR is good to go once someone approves from key vault team (e.g. Harvey/Rick Randal)

@msfcolombo need signoff from your team (Rich or Hervey)

@msfcolombo this PR will be closed by EOW. You can always reopen again.
This PR needs an approval from a KeyVault team members I have mentioned above.

Closing for now. Will reopen again after I get internal sign-off.


Fix goroutine leaks in cmd/query/app

Which problem is this PR solving?

Solves part of https://github.com/jaegertracing/jaeger/issues/5006

Description of the changes

There were a number of causes of goroutine leaks, so I took the approach of addressing these in the initial commits, and then introducing the actual testutils.VerifyGoLeaks call in the final commit
See the individual commit messages for more details on each change
Note that this change involved making some changes to the public function signatures of packages under cmd, which would technically be a breaking change if there are any external packages importing this as a library (raised in https://github.com/jaegertracing/jaeger/issues/5006#issuecomment-2016490940).

How was this change tested?

make test

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[ ] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

Thanks for the thorough review! I'll address your comments, but before I do that, I've just force pushed identical commits to what you reviewed but now correctly signed off. Hopefully this should make my addressing of your comments easier to review.

Definitely agree with you more broadly about the clunkiness of the current API and a callback approach would probably be nicer and more flexible. However I also think it would be nice to leave any more substantial refactor for future work to avoid scope creep in this PR.

Would you consider that refactoring (channel to callback) as a separate PR that we can merge first and then come back to this one, which should become a bit simpler?

Yes I can have a go at this. I created an issue to track it here: https://github.com/jaegertracing/jaeger/issues/5307

I've just realised that we probably do still want to re-introduce the waitgroup on the server goroutines and block on this in the Close method. Currently goleak isn't flagging an leaked goroutines but I think this is probably just because we're getting lucky that the main goroutine is returning after the server goroutines.

I wasn't able to produce this scenario with go test -count 100 ./cmd/query/app, but I've pushed a commit to guard against it anyway. Interested to hear your thoughts.


it will flash when recode screen

Describe the bug
when you open a sublime and type some words then stop recording
watch the recorded video and you'll see flash badly when you type
To Reproduce
Steps to reproduce the behavior:

Go to 'recode full screen'
Click on 'sublime or putty'
See error

Expected behavior
flash
Screenshots
I delete it
Desktop (please complete the following information):

OS: [windows 2016 lstc]
RAM: [32GB]
CPU: [i7 2.6Ghz]
Graphic Card:2060
Captura Version: [v9.0.0 beta4]

Additional context
none
come on guys!

you can contact me for more details
my english is sXck
<EMAIL_ADDRESS>

then I reinstall v8.0.0
v8.0.0 is no problem and can record 30fps


README: add Alyssa Ross to maintainers list

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[ ] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew tests with your changes locally?

Closes #461.

@alyssais Feel free to merge this PR whenever you like with the GitHub Squash and merge button.

brew man --fail-if-changed is failing. Does updating the README.md cause this test to fail?
brew pull https://github.com/Linuxbrew/brew/pull/463
linuxbrew man --fail-if-changed
echo $?
1

Yes, yes it does.
@alyssais Please run linuxbrew man and commit the changes to docs/Manpage.md and manpages/brew.1 to this PR.

Good timing! This'll make it into the release of Linuxbrew 1.3.0 planned for Monday.


⚠ gorzdrav.org has degraded performance

In 786b1d1, gorzdrav.org (https://gorzdrav.org) experienced degraded performance:

HTTP code: 200
Response time: 8915 ms

Resolved: gorzdrav.org performance has improved in f8e6083.


[CP] Reland wait vsync on UI thread and update viewport inset to avoid jitter

Issue Link
https://github.com/flutter/flutter/issues/130028
Commit Hash
cf67f83
Target
beta
PR Link
https://github.com/flutter/engine/pull/43522
Changelog Description
Fixes a crash when the engine is is being destroyed and the keyboard animation display link fires at the same time.
Impacted Users
Flutter developers
Impact Description
Random crash.
Workaround
No
Risk
low
Test Coverage
yes
Validation Steps
It is hard to reproduce the crash manually. The testKeyboardAnimationWillNotCrashWhenEngineDestroyed unit test is the most reliable way to reproduce the test and validate the fix:
https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/FlutterViewControllerTest.mm#L443

@dnfield can you review this CP request? If it looks good to you, add the "cp: approved" label.

lgtm


expand Account#IsLogin to reflect if we can make a NIST

this allows the secretsyncer to work with a NIST too. It was previously insiting on an old-school session.

cc @zapu and @songgao who were affected by this bug

I've just tried this branch, fixed the issue for me :+1:

Thanks for fixing! A bit weird that IsLoggedIn() could be false when I was logged in though. Could this cause issues elsewhere?

Yeah, this is due to churn in changing the login system.  It might be contributing to bugs elsewhere.  So I've been watching issues, etc, to make sure we have no more lingering issues.


(maint) Change spec test to pass on ruby 2.2

Prior to this change, this spec test failed on ruby 2.2.0-rc1 with:
 Failure/Error: Time.stubs(:now).returns(Time.parse("2011-01-06 12:00:00 UTC"))
 NoMethodError:
   undefined method `utc_offset' for nil:NilClass

I didn't track down the root cause of this failure, but just
normalized this stub to use Time.utc, which (along with Time.local)
is the more common way of stubbing Time objects in the codebase.

I verified the important thing is that Time.parse works:

$ ruby --version
ruby 2.2.0p0 (2014-12-25 revision 49005) [x86_64-darwin12.0]
$ ruby -rtime -e 'puts Time.parse("2011-01-06 12:00:00 UTC")'
2011-01-06 12:00:00 UTC

just not in tests for some reason...


Mandate that manifest entry 0 is reserved

In the current design, handles are an index into the manifest, so the
first handle has a value of 0. This is undesirable, since it allows
among other things an unitialized value to be a valid handle.
In order to not use the value 0 as a handle, we mandate that the first
manifest entry (with an index of 0) is reserved and must always be
present. This is done by introducing an entry type of MFT_RESERVED_ZERO,
which is implicitly added to the manifest by mfttool and deliberately
not present in the user-visible JSON definition.
@cfcs, @ricarkol any comments / objections to this approach? For extra paranoia/bounds checking in the manifest validation, is it worth also making the last manifest entry mandatory in a similar way, with a different reserved value?

No objections. Looks good. Importantly, all the users of the manifest API (like the bindings) stay the same, which I checked partially with PR #377.

For extra paranoia/bounds checking in the manifest validation, is it worth also making the last manifest entry mandatory in a similar way, with a different reserved value?

Not sure. There are already lots of checks against mft->entries and MFT_MAX_ENTRIES.

Not sure. There are already lots of checks against mft->entries and MFT_MAX_ENTRIES.

Those would stay as they are, with no more checks added. All I was thinking of was adding a MFT_RESERVED_LAST as a terminator, and checking in mft_validate() only that:

mft->entries is at least 2.
mft->e[mft->entries].type contains MFT_RESERVED_LAST.

This would provide extra assurance that we did indeed load the entire manifest correctly.

This would provide extra assurance that we did indeed load the entire manifest correctly.

Yes, that makes sense. Plus, 62 devices vs. 63 is not a bit deal.

Ok, done, rebased and force-pushed. I also re-ordered the enum to place the reserved values at a high starting point.

I think it makes sense with a dummy entry at the beginning.
I'm not a fan of having both a terminator entry AND a entries count since it increases the number of "representable illegal states" (trailing stuff after the terminator now has to be checked). It seems to me that entries can be derived from mft_size which is passed as an argument to the validation function regardless, but that complicates the size calculation elsewhere.
I wonder if we can fit some kind of useful information into the entry rather than having it be a dummy placeholder. The Solo5 ABI version, perhaps?
The names MFT_RESERVED_ZERO and MFT_RESERVED_LAST seem a bit weird to me, I would have expected FIRST/LAST.

@cfcs:

I'm not a fan of having both a terminator entry AND a entries count since it increases the number of "representable illegal states" (trailing stuff after the terminator now has to be checked).

I don't follow why we would need to check any trailing data after the terminator, or what we would check for?

It seems to me that entries can be derived from mft_size which is passed as an argument to the validation function regardless, but that complicates the size calculation elsewhere.

I'd prefer not to depend on/interpret mft_size too much as it represents the structure size including packing, and as such is dependent on various whims of the toolchain.
If we want to choose between having mft->entries OR a terminator, which is better? Implementation-wise, the majority of the code needs to iterate over the entire manifest. With a mft->entries, this is generally done by:
for (unsigned i = 0; i != mft->entries; i++)
    /* do something with mft->e[i], and/or use i as an (index to) a handle */

With a terminator, this would become:
for (unsigned i = 0; mft->e[i].type != MFT_RESERVED_LAST; i++)
    /* do something with mft->e[i], and/or use i as an (index to) a handle */

The former is simpler, so that is in favour of keeping mft->entries and not having a terminator.
WDYT?

I wonder if we can fit some kind of useful information into the entry rather than having it be a dummy placeholder. The Solo5 ABI version, perhaps?

Good point, let's discuss this in #372 as it concerns the manifest design in general.

The names MFT_RESERVED_ZERO and MFT_RESERVED_LAST seem a bit weird to me, I would have expected FIRST/LAST.

I can change those, once we decide what goes where. I'll also change the device types to be MFT_DEV_<something>.

Ok, after some more discussion the consensus is to not have a MFT_RESERVED_LAST as a termination, mft->entries is enough. I've rebased this atop latest master, and in an additional commit have also namespaced the manifest device types as MFT_DEV_XXX.
Will merge shortly.


[Release-1.30] - Kine emulated etcd version is not set correctly

Backport fix for Kine emulated etcd version is not set correctly

#11220

Validated on branch release-1.30 with commit 48a3b84 / version v1.30.6
Environment Details

Infrastructure

[X] Cloud
[ ] Hosted

Node(s) CPU architecture, OS, and Version:

Linux ip-172-31-29-51 6.8.0-1016-aws #17-Ubuntu SMP Mon Sep  2 13:48:07 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
PRETTY_NAME="Ubuntu 24.04.1 LTS"
NAME="Ubuntu"
VERSION_ID="24.04"
VERSION="24.04.1 LTS (Noble Numbat)"
VERSION_CODENAME=noble
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=noble
LOGO=ubuntu-logo

Cluster Configuration:

1 server

Config.yaml:

config.yaml 1:

write-kubeconfig-mode: 644

config.yaml 2:

write-kubeconfig-mode: 644
cluster-init: true

Additional files

N/A

Testing Steps

Copy config.yaml

$ sudo mkdir -p /etc/rancher/k3s && sudo cp config.yaml /etc/rancher/k3s

Install k3s with kine
Check etcd logs journalctl -u k3s | grep feature_support_checker and (cluster-init: true) journalctl -u k3s | grep etcd-version

Replication Results:
See: https://github.com/k3s-io/k3s/issues/11220#issuecomment-2463896554
Validation Results:

k3s version used for validation:

k3s -v
k3s version v1.30.6+k3s-48a3b849 (48a3b849)
go version go1.22.8

$ sudo journalctl -u k3s.service | grep feature_support_checker
ubuntu@ip-<IP_ADDRESS>:~$

Additional context / logs:
With config.yaml containing cluster-init: true
$ sudo journalctl -u k3s.service | grep etcd-version
"msg":"starting an etcd server","etcd-version":"3.5.16","git-sha":"HEAD"


Add support for Huawei wearables

We'll need to use Huawei-s Wear Engine, more info here: https://developer.huawei.com/consumer/en/hms/huawei-wearengine/

Docs are here: https://developer.huawei.com/consumer/en/doc/development/connectivity-Guides/integrating-phone-sdk-0000001073008983


Could not find a configuration file for package "Qt5" that exactly matches   requested version "5.15.2"

Following instruction on page https://google-cartographer-ros.readthedocs.io/en/latest/compilation.html#building-installation
With fresh Ubuntu 22.04
Linux ub 5.15.0-43-generic #46-Ubuntu SMP Tue Jul 12 10:30:17 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Before was installed ros-destop  with apt
> apt show ros-desktop-full
ackage: ros-desktop-full
Version: 1.16
Priority: extra
Section: universe/metapackages
Source: ros-metapackages
Origin: Ubuntu
Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Original-Maintainer: Debian Science Maintainers<EMAIL_ADDRESS>Bugs: https://bugs.launchpad.net/ubuntu/+filebug
Installed-Size: 9 216 B
Depends: ros-desktop, ros-perception, ros-simulators
Download-Size: 1 672 B
APT-Manual-Installed: yes
APT-Sources: http://ru.archive.ubuntu.com/ubuntu jammy/universe amd64 Packages
Description: Robot OS desktop-full metapackage
 This package is part of Robot OS (ROS). It is a metapackage which
 provides the ROS desktop-full system.

The next command terminates with error
catkin_make_isolated --install --use-ninja

The error message
-- Using Qt5 based on the rviz_QT_VERSION: 5.15.2
CMake Error at CMakeLists.txt:56 (find_package):
  Could not find a configuration file for package "Qt5" that exactly matches
  requested version "5.15.2".

  The following configuration files were considered but not accepted:

    /usr/lib/x86_64-linux-gnu/cmake/Qt5/Qt5Config.cmake, version: 5.15.3
    /lib/x86_64-linux-gnu/cmake/Qt5/Qt5Config.cmake, version: 5.15.3

-- Configuring incomplete, errors occurred!
See also "/home/valery/catkin_ws/build_isolated/cartographer_rviz/CMakeFiles/CMakeOutput.log".
<== Failed to process package 'cartographer_rviz':
  Command '['/home/valery/catkin_ws/install_isolated/env.sh', 'cmake', '/home/valery/catkin_ws/src/cartographer_ros/cartographer_rviz', '-DCATKIN_DEVEL_PREFIX=/home/valery/catkin_ws/devel_isolated/cartographer_rviz', '-DCMAKE_INSTALL_PREFIX=/home/valery/catkin_ws/install_isolated', '-G', 'Ninja']' returned non-zero exit status 1.

Reproduce this error by running:
==> cd /home/valery/catkin_ws/build_isolated/cartographer_rviz && /home/valery/catkin_ws/install_isolated/env.sh cmake /home/valery/catkin_ws/src/cartographer_ros/cartographer_rviz -DCATKIN_DEVEL_PREFIX=/home/valery/catkin_ws/devel_isolated/cartographer_rviz -DCMAKE_INSTALL_PREFIX=/home/valery/catkin_ws/install_isolated -G Ninja

Command failed, exiting.

Workaround, but not fully tested yet
if(rviz_QT_VERSION VERSION_LESS "5")
  message(STATUS "Using Qt4 based on the rviz_QT_VERSION: ${rviz_QT_VERSION}")
  find_package(Qt4 ${rviz_QT_VERSION} EXACT REQUIRED QtCore QtGui)
  include(${QT_USE_FILE})
else()
  set(rviz_QT_VERSION "5.15.3")
  message(STATUS "Using Qt5 based on the rviz_QT_VERSION: ${rviz_QT_VERSION}")
  find_package(Qt5 ${rviz_QT_VERSION} EXACT REQUIRED Core Widgets)
  set(QT_LIBRARIES Qt5::Core Qt5::Widgets)
  include_directories(${Qt5Widgets_INCLUDE_DIRS})
endif()
add_definitions(-DQT_NO_KEY

With this hack the rviz works, but better solution needed for config files


KnativeServing reconciler should use +genreconciler

+genreconciler was added to pkg (https://github.com/knative/pkg/issues/1098) and is now used in knative/serving reconcilers. https://github.com/knative/serving-operator/blob/master/pkg/reconciler/knativeserving/knativeserving_controller.go should use the generated knativeserving reconciler.

/assign trshafer


Allow developer to indicate an expected error in more ways than we do currently

I think this will be a useful future step.
In Python testing, the tests always throw errors. If they are expected, the user can say something like:
def test_passes():
    with pytest.raises(Exception) as e_info:
        x = 1 / 0

If the user doesn't realize an error will happen, then the test will fail.
def test_fails():
    x = 1 / 0

We could try something analogous.
BUT that seems like a nice-to-have feature, not a must-have feature right now (at least to me).
Originally posted by @niharikasingh in https://github.com/plocket/docassemble-cucumber/pull/168#discussion_r593939646

We currently have some functionality like that, such as 'the user should get an invalid input message' or something like that. We lack that for the story table, though. We might want to discuss what that would look like in the story table.
We may also want it for some other places that we just haven't yet articulated. Generally, I think we should definitely look into this further.


Feature/notify watcher

Adds the notify watcher, a low effort way to present notices to your users.

Can we put some default styles on them?


B-19036

Agility ticket
INT PR
Summary
This gives Services Counselors the ability to create moves. To bridge the gap betwen SCs creating a profile, and then creating a move for that profile, we will need to refactor:

SC search component to display users as well as moves
Refactor the CreateMoveCustomerInfo and ServicesCounselingAddOrders components to not use the BASE_COUNSELING_MOVE_PATH
MoveDetails to include the ability to upload orders files

Because of this, I left some component testing lean.
Move goes directly into "NEEDS_SERVICES_COUNSELING" status at the request of the PO
How to test

Login as a services counselor and click Search

Search for an existing customer

Click "Create New Move" and get directed to the Customer info screen
src/components/Table/SearchResultsTable.jsx (button)
src/pages/Office/CreateMoveCustomerInfo/CreateMoveCustomerInfo.jsx (Customer info screen)

Update customer info and take note of updates and save

Find yourself at the new Add Orders page. Fill out orders information, take note of it and click next
src/pages/Office/ServicesCounselingAddOrders/ServicesCounselingAddOrders.jsx (add orders screen)
src/components/Office/AddOrdersForm/AddOrdersForm.jsx (add orders screen)
src/services/ghcApi.js clicking next fires counselingCreateOrder
pkg/handlers/ghcapi/orders.go to create orders/move/entitlement
pkg/models/move.go to set status to passed in status (this allows SC created moves to go directly to a status where SCs can edit/add shipments)

Find yourself at the move details view of the new move. Scroll down and confirm the orders information and customer information you entered is correct

Warnings

:warning:
This PR does not include changes to storybook, even though it affects component code.

  Generated by :no_entry_sign: dangerJS against ec282322eb1a87fd4733b838569fd4cecba692e7


Generate sources jar and javadoc using gradle

it looks like the fine folks and maven-android are tied up with the google repo changes. Since then, we've added gradle fury which helps a lot with publishing artifacts to nexus. The only thing missing is javadocs and source jars

https://github.com/kercheval/GradleCMPlugin/wiki/Create-Javadoc-with-Class-Diagrams-using-UMLGraph-with-Gradle
http://stackoverflow.com/questions/11474729/how-to-build-sources-jar-with-gradle
potential solutions

turns out all that's needed is the following
./gradlew install -Pprofile=javadoc,sources
thanks to https://github.com/chrisdoyle/gradle-fury @chrisdoyle


Responsive sometimes prints out .. to chat

Little Sera: yeah sounds like the setting to customize it was added, with an empty default
Little Sera: so your default is then ".."

Fixed in #10


Add 'IntSet'

Currently there's only IntMap data structure. But it would be good to have IntSet as well.
This can be implemented easily by creating simple wrapper around IntMap like it's done here for AVL tree:
https://github.com/jfdm/idris-containers/blob/master/Data/AVL/Set.idr
All functions for IntMap should be duplicated:

[ ] size
[ ] member
[ ] insert
[ ] delete

If some functions from #5 will be implemented earlier than IntSet then those functions should be duplicated as well if possible.

Hi! I would like to work on this.
However, I am not sure how should I do on Functor and Foldable parts. Also, it seems that values function cannot be implemented directly as a wrapper, since there is no function returning the keys of a map. Does I need to add another function such like keys for IntMap?

Hello, @arbuztw ! Please, take my apologies for not answering fast. I really happy that you're interested in contributing to this project :)

However, I am not sure how should I do on Functor and Foldable parts

Haskell version of IntSet doesn't have Functor and Foldable instances. And you can't implement these instances for IntSet so just don't do it :)

Does I need to add another function such like keys for IntMap?

As you correctly said, there's no keys functions for IntMap because it's not so trivial to implement. Thus you also shouldn't implement this function for IntSet.


Re-Enable mandatory fastboot tests

They were previously disabled due to repeated failures (caused by infrastructure, not actually broken code).
closes #1719

doesn't work for now :disappointed:


boot: fix order of arguments for hasPrefix

Motivation for this change
hasPrefix was used with arguments flipped, so it didn't work.

Merged and cherry-picked at 11c84a902ef9933fe0b4a65ca237dbded245a72e :)


Add install scripts

Signed-off-by: Poor12<EMAIL_ADDRESS>What type of PR is this?
/kind documentation
What this PR does / why we need it:
Add install scripts.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
None

/cc @RainbowMango

/assign

/cc @RainbowMango


Comparisons with the logical or operator

Challenge Comparisons with the Logical Or Operator has an issue.
User Agent is: Mozilla/5.0 (Windows NT 6.2; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.102 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
Screenshot
Hi, i found typo mistake. In the explanation only if num is between 5 and 10 (5 and 10 included) but the sample is num > 10 || num < 5 (num = 11, 12, 13, ... OR num = 4, 3, 2 ...).
I think it should be num >= 5 || num <= 10

@fybwid thanks for the issue. There does seem to be a typo. I think when it is said the function

...will return "Yes" only if num is between 5 and 10 (5 and 10 included).

the "included" is supposed to be "excluded" so it should read:

...will return "Yes" only if num is between 5 and 10 (5 and 10 excluded).

This line needs to be changed.

Hi! What do I have to do to solve this issue (I know the solution to the problem, I mean more formal steps like synchronization, making a branch etc)? I've never participated in an open source project before.

@erictleung Thanks for the explanation.

@erictleung I don't think there's a typo. The examples return "No" if num is greater than 10 or less than 5 (not 5, 10, or any number in between). If those conditions aren't met, then "Yes" is returned as the explanation suggests:

...will return "Yes" only if num is between 5 and 10 (5 and 10 included)

@alistermada That's correct, thanks. @erictleung Thank you, it's my fault. I should read more carefully.


setting up compute workers

Hello,
We tried to connect a worker to a customized queue (deconbench_queue) using the broker URL generated with the queue.
We used the following docker command lines (an image was successfully created on the compute worker):
docker run \
 -v /var/run/docker.sock:/var/run/docker.sock \
 --env BROKER_URL=pyamqp://6026cf27-3874-481b-bfea-f872113bafc7:0871bef4-38ed-480d-9418-2838dc54e213@<IP_ADDRESS>:9001/7637c652-f390-48e1-b68a-95efd99bff96\
-d \
--restart unless-stopped \
--log-opt max-size=1m \
--log-opt max-file=3 \
codalab/competitions-v2-compute-worker
We set up the queue on the online form of the competition 181 (see below).

We tried to make submissions, but nothing append (i.e. no ingestion).
Our worry is that our VM machine (located on the deNBI cloud) is not directly accessible from outside.
Do you have an idea how we could check the connection between the queue and the worker?

What are the logs from that docker container? You can do something like..
$ docker ps
# grab the container ID from the above command's output

$ docker logs -f <container ID>

@ckcollab the logs from the docker container shows the following error message recurringly -
`Trying to reconnect...
[2020-11-16 23:22:58,328: ERROR/MainProcess] consumer: Cannot connect to amqp://6026cf27-3874-481b-bfea-f872113bafc7:**@<IP_ADDRESS>:9001/7637c652-f390-48e1-b68a-95efd99bff96-d: Connection.open: (530) NOT_ALLOWED - access to vhost '7637c652-f390-48e1-b68a-95efd99bff96-d' refused for user '6026cf27-3874-481b-bfea-f872113bafc7'.
Trying to reconnect...
[2020-11-16 23:22:58,458: ERROR/MainProcess] consumer: Cannot connect to amqp://6026cf27-3874-481b-bfea-f872113bafc7:**@<IP_ADDRESS>:9001/7637c652-f390-48e1-b68a-95efd99bff96-d: Connection.open: (530) NOT_ALLOWED - access to vhost '7637c652-f390-48e1-b68a-95efd99bff96-d' refused for user '6026cf27-3874-481b-bfea-f872113bafc7'.
Trying to reconnect...
[2020-11-16 23:22:58,591: ERROR/MainProcess] consumer: Cannot connect to amqp://6026cf27-3874-481b-bfea-f872113bafc7:**@<IP_ADDRESS>:9001/7637c652-f390-48e1-b68a-95efd99bff96-d: Connection.open: (530) NOT_ALLOWED - access to vhost '7637c652-f390-48e1-b68a-95efd99bff96-d' refused for user '6026cf27-3874-481b-bfea-f872113bafc7'.
Trying to reconnect...
[2020-11-16 23:22:58,720: ERROR/MainProcess] consumer: Cannot connect to amqp://6026cf27-3874-481b-bfea-f872113bafc7:**@<IP_ADDRESS>:9001/7637c652-f390-48e1-b68a-95efd99bff96-d: Connection.open: (530) NOT_ALLOWED - access to vhost '7637c652-f390-48e1-b68a-95efd99bff96-d' refused for user '6026cf27-3874-481b-bfea-f872113bafc7'.
Trying to reconnect...
[2020-11-16 23:22:58,721: CRITICAL/MainProcess] Frequent restarts detected: RestartFreqExceeded('5 in 1s')
Traceback (most recent call last):
File "/usr/local/lib/python3.8/site-packages/celery/worker/consumer/consumer.py", line 312, in start
self._restart_state.step()
File "/usr/local/lib/python3.8/site-packages/billiard/common.py", line 165, in step
raise self.RestartFreqExceeded("%r in %rs" % (R, self.maxT))
billiard.exceptions.RestartFreqExceeded: 5 in 1s
`

Ah, from the new RabbitMQ server we don't have the old credentials. I purged existing queues, could you remake the queue and try again with the new queue url? Tested this process again from scratch and it worked, so it should be working now.


python packages in pyproject.toml

I got some parts of the conda build working again in conda-forge/physics-tenpy-feedstock#29 working again by updating the build dependencies :)
However, I noticed that the build logs have a lot of warnings like the following, for each of the modules in tenpy:
          ********************************************************************************
          ############################
          # Package would be ignored #
          ############################
          Python recognizes 'tenpy.models' as an importable package[^1],
          but it is absent from setuptools' `packages` configuration.

          This leads to an ambiguous overall configuration. If you want to distribute this
          package, please make sure that 'tenpy.models' is explicitly added
          to the `packages` configuration field.

          Alternatively, you can also rely on setuptools' discovery methods
          (for example by using `find_namespace_packages(...)`/`find_namespace:`
          instead of `find_packages(...)`/`find:`).

          You can read more about "package discovery" on setuptools documentation page:

          - https://setuptools.pypa.io/en/latest/userguide/package_discovery.html

          If you don't want 'tenpy.models' to be distributed and are
          already explicitly excluding 'tenpy.models' via
          `find_namespace_packages(...)/find_namespace` or `find_packages(...)/find`,
          you can try to use `exclude_package_data`, or `include-package-data=False` in
          combination with a more fine grained `package-data` configuration.

          You can read more about "package data files" on setuptools documentation page:

          - https://setuptools.pypa.io/en/latest/userguide/datafiles.html

          [^1]: For Python, any directory (with suitable naming) can be imported,
                even if it does not contain any `.py` files.
                On the other hand, currently there is no concept of package data
                directory, all directories are treated like packages.
          ********************************************************************************

I believe we need to update the pyproject.toml;
according to the official quickstart and  (this more detailed section](https://setuptools.pypa.io/en/latest/userguide/package_discovery.html) I think it should be enough to replace our section
[tool.setuptools]
packages = ["tenpy"]

with
[tool.setuptools.packages]
find = {}  # Scan the project directory with the default parameters

or maybe, if we want to be explicit what we want,
[tool.setuptools.packages.find]
include = ["tenpy*"]

On it =)
Should we also worry about the warnings from cython in the build logs?
See eg https://github.com/tenpy/tenpy/actions/runs/8246267539/job/22551942313

#361 seems to fix this;
at least the warnings are gone in the logs;
https://github.com/tenpy/tenpy/actions/runs/8262128817/job/22600834600?pr=361


changing baud rate of UART0

Is it possible to set the baud rate of UART0? I am using a NodeMCU ESP8266EX and trying to send debug print statements back to my computer (read with the ArduinIDO Serial Monitor), but they are just showing up as invalid characters. I feel like this might be a baud rate issue but I tried every baud rate available in the serial monitor (including the likely suspects of 9600 and 115200).
If it's helpful here is my  current program mostly copied from the blinky example. Thanks!
#![no_std]
#![no_main]

use xtensa_lx106_rt::entry;

use core::panic::PanicInfo;
use esp8266_hal::prelude::*;
use esp8266_hal::target::Peripherals;

#[entry]
fn main() -> ! {
    let dp = unsafe { Peripherals::steal() };
    let pins = dp.GPIO.split();
    let (mut timer1, _) = dp.TIMER.timers();

    let mut gpio1_uart = pins.gpio1.into_uart();
    let mut gpio3_uart = pins.gpio3.into_uart();
    let mut gpio2_uart = pins.gpio2.into_uart();

    use esp8266_hal::prelude::_embedded_hal_serial_Write;
    use embedded_hal::blocking::serial::write::Default;
    use esp8266_hal::uart::UART0Ext;
    use esp8266_hal::uart::UART1Ext;
    use core::fmt::Write;

    let mut serial = dp.UART0.serial(gpio1_uart, gpio3_uart);
    //let mut serial = dp.UART1.serial(gpio2_uart);

    loop {
        timer1.delay_ms(500);
        //led.toggle().unwrap();
        serial.write_str("hello_world\n").unwrap();
        // serial.flush();
    }
}

/// Basic panic handler - just loops
#[panic_handler]
fn panic(_info: &PanicInfo) -> ! {
    loop {}
}

for reference, I was able to change the baud rate manually using:
let dp = Peripherals::take().unwrap();
dp.UART0.uart_clkdiv.write(|w| unsafe { w.uart_clkdiv().bits(80e6 as u32 / 115_200) });

I'm using the esp12s here, I think it has a 26Mhz cristal and boot up with 80 Mhz if you dont change anything during startup. (blinking with timer1 was also working with the correct frequency)


Sagemaker: support serverless inference

Currently, Sagemaker controller doesn't expose a way to configure serverless inference.
Please add it :)

Hi @AlmogBaku, we are working on it and the feature has been merged - https://github.com/aws-controllers-k8s/sagemaker-controller/pull/193. We will update the issue once we cut a release
Thanks for the patience

Do let us know if you have any timelines on when you would like to use this feature

Hi @AlmogBaku we have released this feature as part of v0.6.0 of the Sagemaker Controller.


add support to attribute name

lets add support to attribute name, e.g.
<form name="formName" id="formID>
  <mn-input name="username" />
</form>

So, in the form, we need assign a getter, example
// following codes need return the value of mn-input, a empty string, or typed string
formName.username.value
formID.username.value

@alencar13 lets do it first? you can start the specs before implementation

Yes, I'm implementing this attribute first.

nice, when you finish some specs, put the branch where you working here pls


feat: improve ColumnTypes

Closes #113.
Summary of Changes

Rename subclasses:

old
new

IntColumnType
Integer

BooleanColumnType
Boolean

FloatColumnType
RealNumber

StringColumnType
String

Add new subclass Anything for columns that contain any values
Add parameter is_nullable to all types to indicate that null values are allowed
Add tests

🦙 MegaLinter status: ❌ ERROR

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

✅ PYTHON
black
21
6
0
0.98s

✅ PYTHON
flake8
21

0
0.49s

✅ PYTHON
isort
21
14
0
0.22s

❌ PYTHON
mypy
21

4
1.87s

❌ PYTHON
pylint
21

4
2.26s

✅ REPOSITORY
git_diff
yes

no
0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
MegaLinter is graciously provided by

:tada: This PR is included in version 0.8.0 :tada:
The release is available on:

v0.8.0
GitHub release

Your semantic-release bot :package::rocket:


Fixed nav does not have z-index

Description
The materialize navbar contains code to handle a fixed navigation bar, but the z-index property for this navbar is on the class .navbar-fixed instead of on the actual .navbar-fixed nav element itself.
Repro Steps
1: create a  element.
2: add class="navbar-fixed" to the parent element ().
3: scroll down to see elements on top of the fixed navbar instead of underneath it.
Screenshots / Codepen
https://codepen.io/anon/pen/vZmWEy

Corrected
https://codepen.io/anon/pen/Kqmypx

PR https://github.com/Dogfalo/materialize/pull/4854/commits/d635420993672bab698698784b849074211e2574

@Snewk did you try to add a wrapper div around the nav and give it the navbar-fixed class? Because this creates a separate block for the nav and sets the position for it.
https://codepen.io/anon/pen/xrdjbq
Generally your PR is good and moving the class to the body to toggle it easily is a good idea and an actual use case.
https://codepen.io/anon/pen/eRWrNZ
Can you update the docs (in the jade/page_contents directory) and change the paragraph in navbar.html, remove the wrapper div and update the wording to point at body.
Thanks for the PR. This should make the component more flexible.
I'll check the js component if there are any breaking changes.

@DanielRuf When testing, I tried adding a wrapper div and giving it the class navbar-fixed. This correctly created a fixed navbar using a separate block for the nav (as you explained).
The only problem is the z-index gets applied to the wrapper div instead of the nav element itself. Since the nav doesn't get a z-index assigned to it, other elements on the page will appear on top of the navbar.
This PR will make the code for the navbar-fixed class work correctly as it is currently documented, so no changes to documentation should be required.
The navbar-fixed property will still need to be applied using a wrapper div, but now the z-index will be applied to the nav element instead of the wrapper.

@Snewk your PR makes sense for special use cases. Maybe I can identify and fix the issue in the js component to prevent issues and decouple it a bit more for a more modular approach in the future.
@tomscholz should we enforce our rules or give developers more freedom over this?

Also, in this case, is no way to offset the page content to a custom value. In fact, trying to adjust the height will increase the height of the body from the bottom instead of the top.

@Snewk Do you mean the $navbar-mobile-height variable or how did you do this?

Also, in this case, is no way to offset the page content to a custom value. In fact, trying to adjust the height will increase the height of the body from the bottom instead of the top.

@DanielRuf Yes, i meant by changing the height directly or by changing $navbar-height-mobile. Take a look at the following structure:

        <div class="navbar-fixed"

Here, the div gets z-index: 997; as well as height: $navbar-height-mobile;. This div holds the navbar over the page content, and it pushes the page down by $navbar-height-mobile. Everything works.
BUT, if we use the following:

The z-index and height cannot be assigned to the body in the same way. There is no element underneath the navbar to hold it above the content at z-index: 997; or to offset the page by $navbar-height-mobile.
If we want to allow developers the freedom to use , we should incorporate my PR. Unfortunately, this will still leave the issue of page content being hidden underneath the navbar.
I would be happy to update the documentation to reflect this limitation if you decide to implement my change.

After some more tinkering, I may have come up with a solution.
https://codepen.io/anon/pen/Kqmypx

instead of giving the navbar-fixed wrapper a height: $navbar-height-mobile, we can use top: $navbar-height-mobile  instead and then add top: 0px to the nav element.

@Snewk ah right. I should tried the different offsetting solutions for fixed elements.
Cool. There is always a solution ;-)
Please also make the changes in the branch of your PR.

glad to help. here is the PR
https://github.com/Dogfalo/materialize/pull/4859/commits/f3b3888099d78317eed31a97f9d0cfaabc989697

Looks much better.
@acburst @tomscholz your opinions?

@DanielRuf @tomscholz
Found an issue with my PR so I closed it. Fixed it in a new PR. Here is the commit :
https://github.com/Dogfalo/materialize/pull/4915/commits/2bef95f2313aaecf59261da2b7ab9b2a5b4b86b5

@Snewk you could push new commits to your (old) branch to update your PR.

my bad. i am still pretty new to contributing to projects i use. will make sure to do that in the future.

@DanielRuf i agree that we need to test this change to ensure things continue working as expected.
I noticed the file test/html/fixed_navbar.html is this currently in use anywhere? reading the docs and code, it looks like jasmine only uses the tests/ directory and not the test/ dir.
let me know if i can help testing or with writing a test for this component.

Then in the version 0.100, unfortunately navbar-fixed still suffered a bug.

Then in the version 0.100, unfortunately navbar-fixed still suffered a bug.

Which bug? Please be more precise, create a new issue and provide a new codepen.

Check my issue: https://github.com/Dogfalo/materialize/issues/4986, @DanielRuf.

@Snewk your description of the problem "the navbar ends up covering the top of the page content" is exactly what I'm seeing (see codepen https://codepen.io/pvanheus/pen/GORrJX adapted from the one you posted). Is 15b5ff4 meant to solve this problem?

Move the sidenav ul out of the navbar as described in #3844


Docker: sometimes get duplicated admin/role accounts when using docker

I believe this is a timing issue, we attempt to detect if user and roles exist on startup and if not we add them.  Detection is based on name only. Adding an id to the create statement should prevent duplicates.

fixed and tested via pull request


refine' ignores introduced variables

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

Description
When refine' sees a lambda with a hole in the body, it creates a goal for the entire function, rather than introducing the named variables and creating a goal just for the body.
When body is a ?_ metavariable refine' has the correct behaviour.
Steps to Reproduce
example : Nat → Nat := by
  refine' (fun x => _)
  -- goal is still `Nat → Nat`
  sorry

example : Nat → Nat := by
  refine' (fun x => ?_)
  -- goal is now `x : Nat ⊢ Nat`, as expected.
  sorry

Expected behavior:
Both versions should leave the goal state as x : Nat ⊢ Nat, as in Lean3.
Versions
version 4.0.0-nightly-2022-09-30, commit 955a251bfc35

I don't want to clutter up this issue, but even when refine' apparently behaving as expected when using ?_, something is still not right:
import Lean

open Lean Elab Parser Tactic

syntax (name := logHyp) "log_hyp " (ppSpace location) : tactic

@[tactic logHyp] elab_rules : tactic | `(tactic| log_hyp $loc) => do
  withLocation (expandLocation loc)
    (atLocal := fun h => do logInfo (← h.getDecl).type)
    (atTarget := done)
    (failed := fun _ => throwError "failed")

example (h : 1 = 1) : True := by
  log_hyp at h -- prints `1 = 1`
  trivial

example (h : 1 = 1) : True := by
  revert h
  refine' (fun h => ?_)
  -- Goal view shows `h: 1 = 1`, but
  log_hyp at h -- prints `?m.33410`
  trivial


Create commands.txt

Sorry, that's not how I'm planning to do documentation.
In any case, trying to create documentation now is a lost cause since so many things are going to be changed. :P


Question: Defining a struct where one of its fields is a bitfield

How one can define and generate a struct where one of its fields needs to be a bitfield? Take  VMCS as an example, the RevisionId is defined as a pure integer while it should have been defined as two two bit fields, that is,
typedef struct
{
  UINT32 RevisionId;
/*
It should have been like this:
  UINT32 RevisionId : 31;
  UINT32 ShadowVmcsIndicator : 1;
*/
  UINT32 AbortIndicator;
  UINT8 Data[4088];
} VMCS;

Can you tell me one can define a structure like this, or even better, can you update the yaml file so I can learn from a sample :)?

Currently, you can't. The best you can do now is to make nested bitfield inside of a struct, like this:
- name: VMCS
  type: struct
  fields:
    - name: DUMMY
      type: bitfield
      size: 32
      fields:
        - bit: 0-30
          name: REVISION_ID

        - bit: 31
          name: SHADOW_VMCS_INDICATOR

    - size: 32
      name: ABORT_INDICATOR

    - size: 32704  # 4088
      name: DATA

What do you think about nested unnamed bitfield structs? Say,
typedef struct
{
  struct
  {
    UINT32 RevisionId : 31;
    UINT32 ShadowVmcsIndicator : 1;
  }
  UINT32 AbortIndicator;
  UINT8 Data[4088];
} VMCS;

If that suffices, I will implement a mechanism that supports it.

Fair enough. That unnamed struct approach looks good to me. Thank you for working on the tooling change.

Funny, I see that support for unnamed bitfield structs is there since ever. It's just that I force (short|long)_?name to be required for every node.
Please, try out the patch. Just ommit the name for the bitfield type and it should work.

Thank you for the quick update. It is working as expected. I pushed another PR using this change.
Again, thanks a lot for maintaining the awesome project.


Baseline Attribution Reporting API Tab in Privacy Sandbox Analysis DevTools panel

Feature Request
Description:
Today, ad conversion measurement often relies on third-party cookies. The Attribution Reporting API (ARA) enables to collect such measurements in a privacy-preserving way; that is, without third-party cookies. Specifically, this API enables advertisers and ad tech providers to measure conversions in the following cases:

Ad clicks and views.
Ads in a third-party iframe, such as ads on a publisher site that uses a third-party ad tech provider.
Ads in a first-party context, such as ads on a social network or a search engine results page, or a publisher serving their own ads.

Motivation:
The goal of this feature is to include an Attribution Reporting API tab in the DevTools PS Analysis panel, initially surfacing information from chrome://attribution-internals, and progress from there to enable users of the extension to learn about
the API in an user-friendly way, and debug its use cases.
The ARA tab can also capture information and insights provided in prior demos such as this and this.
Acceptance Criteria:

[ ] Attribution Reporting API tab
[ ] Add API Info Card
[ ] Show information from chrome://attribution-internals/
[ ] Show information from Demo (if applicable)
[ ] Allow to modify the topics (check if this would be possible)

Additional Information:

Attribution Reporting
Why Chrome plans to ship the Attribution Reporting API
Private Attribution
Interoperable Private Attribution

I am thinking how we would get data from chrome://attribution-internals/.
I did a quick attempt by injecting a script into that page through the service worker, but it seems to function properly on all tabs except for this one.
chrome.tabs.onUpdated.addListener((tabId, changeInfo, tab) => {
  if (
    changeInfo.status === 'complete' &&
    tab.url === 'chrome://attribution-internals/'
  ) {
    chrome.scripting
      .executeScript({
        target: { tabId: tabId },
        func: () => {
          // Do window operations here.
        },
      })
      .then((result) => {
        // work with the result.
      });
  }
});

throws the following error
Uncaught (in promise) Error: Cannot access a chrome:// URL

Looks like accessing internal pages like chrome://attribution-internals/ have limitations due to the security restrictions imposed by Chrome extensions.

I am thinking how we would get data from chrome://attribution-internals/.

I am actively working on exposing Attribution Reporting data and events in the DevTools protocol, e.g. source-registration events.


Add parameter to allow synchronously created stack.

Came to the situation where I needed to create the stack synchronously and didn't found an option. Here is what I came up with.

Hi @sunshinejr thanks for your suggested contribution.
Unfortunately the decision to make stack creation asynchronous, when using a SQLite backed store, is deliberate. Introducing an option to circumvent that would encourage a bad programming practice.
Please see #31


filename is too long (>100 characters)

my export stops because the filename is too long
file name 'evol/mails/%21%7E%21UENERkVCMDkAAQACAAAAAAAAAAAAAAAAABgAAA
AAAAAA4ujoTBv1WUKt4ty4OdM4jMKAAAAQAAAAThSSMI1xBEanP5qvKo4CLQEAAAAA%40orange.fr/_source' is too long ( > 100 bytes)
If elasticsearch accept it, why elasticsearch-knapsack
does not ?

Thanks for the report.
The issue is fixed in new releases:
2.0.0-beta2.1
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>

thanks. It works great


[bug] Request Connect Wallet

Is there an existing issue for this?

[X] I have searched the existing issues

RainbowKit Version
2.1.4
wagmi Version
2.5.16
Current Behavior
I use IOS devices,
bowser Brave on mobile
Step 1: Open Brave
Step 2: open my website with using rainbowKit
Step 3: Connect Wallet and select metamask
Step 4: it request Brave wallet not open metamask
Expected Behavior
I use IOS devices,
bowser Brave on mobile
Step 1: Open Brave
Step 2: open my website with using rainbowKit
Step 3: Connect Wallet and select metamask
Step 4: Open request connect Metamask
Steps To Reproduce
It just code base,
still happen when connect on your website
https://www.rainbowkit.com/
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
No response

This is unfortunately a Brave Browser design choice. You'll need to go to Settings > Web3 > Ethereum and disable the "Sites can request access to your Ethereum wallet" toggle and change Default Ethereum Wallet to None.


Is  FlushConsumeQueueService necessary？

version 4.9.1
From the ReputMessageService code, we can finally locate the following code。 “this.fileChannel.write(ByteBuffer.wrap(data));” is already possible to write data to disk, why do we need FlushConsumeQueueService?
————————————————————————————————————————————
public boolean appendMessage(final byte[] data) {
int currentPos = this.wrotePosition.get();
if ((currentPos + data.length) <= this.fileSize) {
    try {
        this.fileChannel.position(currentPos);
        this.fileChannel.write(ByteBuffer.wrap(data));
    } catch (Throwable e) {
        log.error("Error occurred when append message to mappedFile.", e);
    }
    this.wrotePosition.addAndGet(data.length);
    return true;
}

return false;

}
——————————————————————————————————————

fileChannel.write does not directly write ByteBuffer data to disk

yes，I know that data is written to the system cache first, but eventually it is written to disk.And FlushConsumeQueueService is also executed asynchronously。
If it's to ensure data is written to disk, why not use filechannel.force.
Or write to mappedbytebuffer like commitlog.
------------------ 原始邮件 ------------------
发件人:                                                                                "apache/rocketmq"                                                                                @.>;
发送时间: 2022年4月13日(星期三) 中午1:50
@.>;
<EMAIL_ADDRESS>主题: Re: [apache/rocketmq] Is  FlushConsumeQueueService necessary？ (Issue #4159)
fileChannel.write does not directly write ByteBuffer data to disk
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Every time the data is written, it will be forced, and the disk io pressure will be relatively large, so it needs to be changed to this asynchronous。
and 5.0 has been modified to mappedbytebuffer

对于索引来说每次写入的数据量小但是更新频繁，用 mmap 确实会更好，还有 commitlog 应该用 filechannel。

个人认为这里主要是避免 os 积累太多的脏页导致 io 抖动


Full MSVC support and bug fixes.

Why
Closes #18
Made this repo available to MSVC.
What is changing
Added:

util/magic_names.hpp
util/meta_string.hpp
A uniform MSVC/GCC/Clang implementation of reflecting qualified function names.
A meta_string class for template programming as non-type parameter when enabling C++20.

Added:

util/benchmark
util/examples
util/tests
Some static asserts for ensuring correctness of newly added code.

Modified/Fixed:

coro_rpc: CMakeLists.txt
coro_rpc/remote.hpp
util/function_name.h
Fixed fatal issues when compiling with MSVC.
Replaced -pthread with the Threads::Threads CMake package to eliminate MSVC warnings.
Fixed incorrect function names when using MSVC.

All unit tests have passed on MSVC 19.3x/GCC11.x/12.x/Clang 15+.
Core logics have passed on GoldBolt.
Example
Please view src/util/tests

Thank you very much!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.refvalue seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

good job

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
@refvalue

The CI is added by https://github.com/alibaba/yalantinglibs/pull/33. However, only struct_pack enabled on MSVC.
Please change the yaLanTingLibs_ENABLE_PROJECTS=all to enable all projects on MSVC and verify your code.
https://github.com/alibaba/yalantinglibs/blob/657718f346c66e1c4dcb1165531b2e4c6c3b75af/.github/workflows/windows.yml#L42
note: Windows Server 2022 is used in CI.

Thanks for your work. Please rebase to the latest main branch, and pass the CI.

OK. I will create a new PR later.

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. @refvalue

Thanks! I has forked a new repo with a new PR, for the previous fork had an incorrect email. Now everything goes well.

Thank you very much!

Thank you!


watch only fired once

I have the following scenario:
<template v-for="field in fields">
    <input type="text" v-model="values[field.key]" />
</template>

with the following code:
var vue = new Vue({
    el: "#vue",
    data: {
        fields: [{key:"a"},{key:"b"}],
        values: {}
    },
    watch: {
        values: function (val, old) {
            alert("change!");
        }
    }
});

The problem is that the alert only occures the first time each input field is modified. As far as I can tell this only seems to occur when the two-way binding target uses a variable.
By inspecting the vue data I can see that the values keep updating even though the watch function isn't invoked.
I'm using the method proposed by @yyx990803 in issue #1056.

you can already do that with v-model="form[field.name]".

You need a deep watcher.

I have exactly the same scenario with the same problem, and still not working with deep: true:
var vue = new Vue({
    el: "#vue",
    data: {
        fields: [{key:"a"},{key:"b"}],
        values: {}
    },
    watch: {
        values: function (val, old) {
            alert("change!");
        },
        deep: true
    }
});

Have you solved the problem @pqvst?

@maximelebreton Your usage of deep is incorrect
watch: {
  values: {
    handler: function (val, old) { ... },
    deep: true
  }
}

https://vuejs.org/v2/api/#watch

oups, sorry,
I wanted to make quick, and my example is wrong...
I've made a jsfiddle to be more effective: https://jsfiddle.net/dq90hkb8/
but I ultimately realize that the problem is different from your...
Sorry for my mistake, I'll open a new issue.

@maximelebreton I'm having this exact issue. Did you figure out what the problem was?

The issue is the way the array is being mutated. See https://vuejs.org/v2/guide/list.html#Array-Change-Detection


[CU-8686c9y60] Improves image generation panel

Made it possible to browse the site while the generation panel is open
Included image selection right in the Queue tab
Displayed the FeedActions in all gen panel tabs
Fixed images loading issue when creating new requests
Adjusted mobile styles
Small UI improvements

Task linked: CU-8686c9y60 Make it possible to browse with the Generation Drawer open


cln-grpc value error in raspiblitz.conf

The error dissapers when the variable in the craspiblitz config gets renamed form cln-grpc to clngrpc.
@openoms I will make a quick commit by changing the variable name all over the code base.

@openoms while looking thru the code I see a
/home/admin/config.scripts/blitz.conf.sh set ${netprefix}clngrpc "off"
but never a place where its set to on is that correct?

@openoms I also hamonized the naming of the tor service to ${netprefix}clnGRPCport ... putting it all to this PR  #3128 for you to review befre merge - see if I broke anything.

Looks good now - closing issue.


Add quality supervisor group

They are gonna be managing reassignment of items. And they are gonna receive reports about relevant items statuses,

Rework the reports for normal inspectors and their supervisors.


Local time ambiguity

The following time zones fail the timezone_gmt_time.c unit test:
America/Glace_Bay
America/Goose_Bay
America/Halifax
America/Havana
America/Moncton
America/St_Johns
America/Thule
Atlantic/Bermuda
Discovered when merging #3

After manipulating the test more, it appears the issue is related to the ambiguity that @huelsenfruchtzwerg references in #3.

I'm inclined to write a function that determines if a local time is an "ambiguous" time--a time that could occur twice because of Daylight Savings Time.  Such a function could be used in the unit tests but may also be useful as a general function.

That's not a bad idea. signature might be somethink like
`/*!

\brief determines if the given local time observes DST

\param[in] timezone_name
\param[in] localtime

\return 1 if the given timestamp observes dst, 0 if it doesn't,

    -1 if it is not defined due to daylight-time -> standard-time

    transition, -2 if the timezone was not found in the database or

    the given timestamp is outside of the database range.

\note this function considers any time-period, that has a bigger offset

  than the one immediately before to be DST, even if the "historic"

  reason for this was something different.

*/
int timezone_is_dst(const char *timezone_name, time_t localtime);`

https://nodatime.org/unstable/api/NodaTime.DateTimeZone.html#NodaTime_DateTimeZone_AtLeniently_NodaTime_LocalDateTime_
https://nodatime.org/unstable/api/NodaTime.DateTimeZone.html#NodaTime_DateTimeZone_AtStrictly_NodaTime_LocalDateTime_
Just checked how NodaTime handles these cases, as a reference for how it's handled elsewhere.


[*] TEST: Try to trigger GitHub Actions

Checklist
General

[ ] I locally pass all tests or calculated manually the correct solutions on paper.
[ ] I chose a title conforming to the naming conventions for pull requests.
[ ] The newly added tests do not reveal the solutions dynamically calculating the solutions as expected in the exercise.

Description

Review Progress

Review

[ ] Review 1
[ ] Optional Review 2

GitHub Actions are now triggered when creating a new PR :)


Eos bootstrap tests

Coverage increased (+14.7%) to 53.482% when pulling 30b3787380ac4b6c3a1cbe32c3edd83a32957267 on eos_bootstrap_tests into be14e0f89da36ebb40417fa57c807421ed525f67 on master.

Coverage increased (+14.7%) to 53.482% when pulling 30b3787380ac4b6c3a1cbe32c3edd83a32957267 on eos_bootstrap_tests into be14e0f89da36ebb40417fa57c807421ed525f67 on master.


chore: fix zustand 'subscribeWithSelector' warning

Describe the changes you have made in this PR
Used subscribeWithSelector middleware
Link this PR to an issue
Closes #895
Type of change (Remove other not matching type)

chore

Screenshots of the changes (If any)
Add screenshots to help explain your problem
How has this been tested?
Ran all tests without the warning
Checklist

[x] My code follows the style guidelines of this project and performed a self-review of my own code
[x] New and existing tests pass locally with my changes
[x] I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

Haha, thanks! I was so close yet so far. I kinda got stuck thinking we used createState for a special reason.

Kinda curious how you came up with that. I'm still confused about createState vs create. I believe I read something about "if within a certain react context use createState" but not sure.

I just went with what's there in their README file: https://github.com/pmndrs/zustand/blob/main/readme.md?plain=1#L190
The 2nd point in this: https://github.com/getAlby/lightning-browser-extension/issues/895#issuecomment-1161355629 felt right so I kinda wondered why we are using createState when it isn't mentioned anywhere in zustand docs.

I'm still confused about createState vs create.  I believe I read something about "if within a certain react context use createState" but not sure.

It works fine with that too btw, ig it's just a naming convention? As we are anyway importing the default create export:

Thanks for the explanation! Yes, it's just the default export. And now I don't even know why I had typing issues anymore. Sometimes I need to reload vscode to fix type issues. Not sure what caused my issue. Thanks for giving this another try!

The warning during the tests is gone but `subscribe` is still deprecated. We should keep an eye on it. I assume latest with zustand v4 we need to update this.

I think it's again one of those VS Code issues, the popup says it is deprecated and we'll have to use the middleware, just like those console warnings. But VS Code must be failing to recognize that we have used the middleware on top!

Awesome, thanks!


csi-node going to Evicted state

One of the csi-node is keep on going to Evicted state.
Below is the describe output after the pod is recreated,
[vagrant@kube1 ~]$ kubectl -n gcs describe pods csi-nodeplugin-glusterfsplugin-zc9qm
Name:               csi-nodeplugin-glusterfsplugin-zc9qm
Namespace:          gcs
Priority:           0
PriorityClassName:
Node:               kube3/
Start Time:         Mon, 21 Jan 2019 07:44:47 +0000
Labels:             app.kubernetes.io/component=csi-driver
app.kubernetes.io/name=csi-nodeplugin
app.kubernetes.io/part-of=gcs
controller-revision-hash=89ffb78f5
pod-template-generation=1
Annotations:
Status:             Failed
Reason:             Evicted
Message:            The node was low on resource: ephemeral-storage. Container gluster-nodeplugin was using 32Ki, which exceeds its request of 0. Container csi-node-driver-registrar was using 32Ki, which exceeds its request of 0.
IP:
Controlled By:      DaemonSet/csi-nodeplugin-glusterfsplugin
Containers:
csi-node-driver-registrar:
Image:      quay.io/k8scsi/csi-node-driver-registrar:v1.0.1
Port:
Host Port:
Args:
--v=5
--csi-address=$(ADDRESS)
--kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)
Environment:
ADDRESS:               /plugin/csi.sock
DRIVER_REG_SOCK_PATH:  /var/lib/kubelet/plugins_registry/org.gluster.glusterfs/csi.sock
KUBE_NODE_NAME:         (v1:spec.nodeName)
Mounts:
/plugin from plugin-dir (rw)
/registration from registration-dir (rw)
/var/run/secrets/kubernetes.io/serviceaccount from csi-nodeplugin-token-k6k85 (ro)
gluster-nodeplugin:
Image:      docker.io/gluster/gluster-csi-driver:latest
Port:
Host Port:
Args:
--nodeid=$(NODE_ID)
--v=5
--endpoint=$(CSI_ENDPOINT)
--resturl=$(REST_URL)
--resttimeout=120
Environment:
NODE_ID:        (v1:spec.nodeName)
CSI_ENDPOINT:  unix://plugin/csi.sock
REST_URL:      http://glusterd2-client.gcs:24007
Mounts:
/plugin from plugin-dir (rw)
/var/lib/kubelet/pods from pods-mount-dir (rw)
/var/run/secrets/kubernetes.io/serviceaccount from csi-nodeplugin-token-k6k85 (ro)
Volumes:
plugin-dir:
Type:          HostPath (bare host directory volume)
Path:          /var/lib/kubelet/plugins_registry/org.gluster.glusterfs
HostPathType:  DirectoryOrCreate
pods-mount-dir:
Type:          HostPath (bare host directory volume)
Path:          /var/lib/kubelet/pods
HostPathType:  Directory
registration-dir:
Type:          HostPath (bare host directory volume)
Path:          /var/lib/kubelet/plugins_registry/
HostPathType:  Directory
csi-nodeplugin-token-k6k85:
Type:        Secret (a volume populated by a Secret)
SecretName:  csi-nodeplugin-token-k6k85
Optional:    false
QoS Class:       BestEffort
Node-Selectors:
Tolerations:     node.kubernetes.io/disk-pressure:NoSchedule
node.kubernetes.io/memory-pressure:NoSchedule
node.kubernetes.io/not-ready:NoExecute
node.kubernetes.io/unreachable:NoExecute
node.kubernetes.io/unschedulable:NoSchedule
Events:
Type     Reason     Age    From               Message

Normal   Scheduled  14m    default-scheduler  Successfully assigned gcs/csi-nodeplugin-glusterfsplugin-zc9qm to kube3
Normal   Pulling    14m    kubelet, kube3     pulling image "quay.io/k8scsi/csi-node-driver-registrar:v1.0.1"
Normal   Pulled     14m    kubelet, kube3     Successfully pulled image "quay.io/k8scsi/csi-node-driver-registrar:v1.0.1"
Normal   Created    14m    kubelet, kube3     Created container
Normal   Started    14m    kubelet, kube3     Started container
Normal   Pulling    14m    kubelet, kube3     pulling image "docker.io/gluster/gluster-csi-driver:latest"
Normal   Pulled     13m    kubelet, kube3     Successfully pulled image "docker.io/gluster/gluster-csi-driver:latest"
Normal   Created    13m    kubelet, kube3     Created container
Normal   Started    13m    kubelet, kube3     Started container
Warning  Evicted    7m41s  kubelet, kube3     The node was low on resource: ephemeral-storage. Container gluster-nodeplugin was using 32Ki, which exceeds its request of 0. Container csi-node-driver-registrar was using 32Ki, which exceeds its request of 0.
Normal   Killing    7m41s  kubelet, kube3     Killing container with id docker://gluster-nodeplugin:Need to kill Pod
Normal   Killing    7m41s  kubelet, kube3     Killing container with id docker://csi-node-driver-registrar:Need to kill Pod
The message says that the node has low resources but I see some space left on the root of kube's and some memory.
[vagrant@kube1 ~]$ free -h
total        used        free      shared  buff/cache   available
Mem:            31G         25G        707M         27M        4.9G        4.3G
Swap:            0B          0B          0B
[vagrant@kube1 ~]$ df -h
Filesystem                 Size  Used Avail Use% Mounted on
/dev/mapper/atomicos-root   27G   20G  7.6G  72% /
[vagrant@kube2 ~]$ free -h
total        used        free      shared  buff/cache   available
Mem:            31G         11G        3.4G         26M         16G         18G
Swap:            0B          0B          0B
[vagrant@kube2 ~]$ df -h
Filesystem                 Size  Used Avail Use% Mounted on
/dev/mapper/atomicos-root   27G   22G  5.2G  81% /
[vagrant@kube3 ~]$ free -h
total        used        free      shared  buff/cache   available
Mem:            31G        1.3G         21G         23M        8.6G         28G
Swap:            0B          0B          0B
[vagrant@kube3 ~]$ df -h
Filesystem                 Size  Used Avail Use% Mounted on
/dev/mapper/atomicos-root   27G   23G  4.2G  85% /

I am also seeing csi-node evictions due to ephemeral storage, and I suspect it is causing pod evictions of other pods on the same node that are using the same shared storage.

If I understand correctly, this happens because something is trying to write to /var/log/
I'm not using gluster atm, but happened to come across this issue while searching for solutions for my very similiar problem.
So request some epehemeral storage, or get rid of whatever is trying to log to /var/log/.


replace old route with symfony route on customer link

fixes this issue:
https://github.com/PrestaShop/PrestaShop/issues/16460

Thanks @matthieu-rolland


Support disabling LB automatic back-end health checks to prevent NotReady nodes from being removed from backend

Similar to this issue, I think we should consider adding support for disabling the default health check port (10256 on kube-proxy) on the LB to avoid letting a connection between the master and worker nodes take otherwise healthy application services offline unnecessarily.
Consider the scenario that happened to us recently:

A network connection issue occurred that affected only the master(s) and node(s) ability to communicate with each other, but not the reachability or health of any application services running inside the cluster
The worker nodes in the cluster began failing to update their status to master(s), and transitioned to the NotReady state
The default health check on 10256 for in the load balancer begins failing (cluster-wide) for all nodes in the NotReady state
The load balancer takes each worker nodes out of its backends
All application services front-ended by this load balancer are now unavailable even though they were all reachable and healthy

Hi @jlamillan,
I believe you can implement a scheme thats supports this failure case via setting your Service type=LoadBalancer's .spec.externalTrafficPolicy to Local (see: here).
This allows you to run a health check endpoint specific to your Service type=LoadBalancer on a subset (or all) the nodes in your cluster.
If you choose a subset of the nodes in your cluster (via a label selector / (anti)affinity on your health check Deployment) any nodes on which the health check isn't scheduled will be added to the LB as backends but in a failing state (because the health check is failing) and thus they won't receive traffic.
Feel free to re-open the ticket if the above doesn't solve your problem and we can explore adding an annotation/configuration option for this.


Add allowedInstallationIds list to each github app

Hey, I just made a Pull Request!
This allows a single instance of backstage to optionally limit the set of
github app installations that may be used by backstage.
Previously, if you had github app installations for tenant1 and tenant2
there was nothing stopping the first from accessing resources of the
second.
The default behaviour of the GithubCredentialsProvider remains the same.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[x] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

This feature might be useful for a team who are deploying a test and a production instance of backstage. They might have a github app installed in an organization for testing and an organization for production.
In this case they would include the allowedInstallationIds to limit the github app installations for each backstage deployment.

Could another option be to limit by the org name instead?

@jhaals I can see the confusion alright, and I could of course be straying outside of a standard backstage use case here. We are hosting a SaaS version of backstage. Bear with me while I explain.
A single "github app" can have multiple installations on different organizations. The contents of each github organization's data is private to the member of that organization. This feature allows a single backstage instance to be limited to a sub set of the installations so that data of each organization's data are not leaked to other users.
Here are some cases for this:

For testing purposes, you make two github app installations, one installation is on your production github organization and the second is on a github organization (or your personal account) you create for testing. With this feature you can run more than one backstage, and have each of them use different github app installations.
For production use, you might have github organizations for different depts within an development organization. You might choose to have different backstages for each organization.
For the SaaS use case, we have one github app for all of our customers. We must ensure each customer backstage instance has no ability to use another installations credentials. This feature allows us to configure this.

@Rugvip yes, I believe you could use the org name - actually I think you would need to use the org "login" field, but that's pedantic. I am not sure if the org name is unique.

@punkle So the use-case is clear and it's pretty much just down to implementation. It's a bit unfortunate that the GitHub credentials provider is itself not provided so you could create a custom one, but that's where we are.
I'd say a refactor to have it done by org name should be enough, since installation ID is awkward because of the chicken and egg problem and I don't think you want that either. And yeah they call the org name login in the API. Definitely don't filter by the display name :grin:

@Rugvip I changed it to filter on the installation owner rather than the id. Hope that works for you.

The test failures seem unrelated. Perhaps I need to update the pull request source branch?

@punkle I believe it was fixed by https://github.com/backstage/backstage/pull/6740, so try bringing in the latest master

Done thanks @Rugvip


ENH: Add itk.Point wrapping for dimension 6

Needed for RANSAC where two corresponding 3D points will be passed
as one entry (concatenation) to ITK Ransac.

PR Checklist

[ ] No API changes were made (or the changes have been approved)
[ ] No major design changes were made (or the changes have been approved)
[ ] Added test (or behavior not changed)
[ ] Updated API documentation (or API not changed)
[ ] Added license to new files (if any)
[ ] Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
[ ] Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

error: downloading 'https://data.kitware.com/api/v1/file/hashsum/sha512/dc78771884ce27837b408f339cc7bb7c5152552f88ebf30ffbc2069ae0407bb27ab2b37679adeff10ed26739571bf4c455dad309891c1c7f0fdc990fea474db1/download' failed
          status_code: 18
          status_string: "Transferred a partial file"

Rerunning the checks.

/azp run ITK.Linux.Python

Do: check


chore: remove unused argument

Which problem is this PR solving?
Noticed while working on #3625.
Fixes # n/a
Short description of the changes
Just removing an unused argument
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
n/a
Checklist:

[x] Followed the style guidelines of this project
[ ] Unit tests have been added
[ ] Documentation has been updated

I'm having the same test failures in my PR/on main in my fork. I created an issue to track this #3628 :slightly_smiling_face:


[BUG] PUT _plugins/_transform/<transform_id> hangs indefinitely

Describe the bug
PUT _plugins/_transform/<transform_id> call with correct body hangs indefinitely after pulling OpenSearch 2.12
Exact same request works fine in 2.11
Related component
Plugins
To Reproduce

Hit /_plugins/_transform/test with the following body:

{
    "transform": {
        "enabled": true,
        "continuous": true,
        "description": "",
        "groups": [
            {
                "date_histogram": {
                    "calendar_interval": "1h",
                    "source_field": "datetime",
                    "target_field": "datetime",
                    "timezone": "UTC"
                }
            }
        ],
        "page_size": 1,
        "roles": [],
        "schedule": {
            "interval": {
                "unit": "Hours",
                "period": "1"
            }
        },
        "source_index": "test-source",
        "target_index": "test-target"
    }
}

Observe the operation hanging indefinitely

Expected behavior
Operation should return a 201 Created response.
Additional Details
Validation seems to work. For example:

{"transform": {"enabled": trueeeeeee}} correctly returns a 400 with json_parse_exception
Nonexistent source_index correctly returns a 404 with "No specified source index exist in the cluster"

this appears to have the same root cause as: https://github.com/opensearch-project/index-management/issues/1161 but for transforms you unfortunately don't get the nice error msg explaining that the start_time field is missing.

Does anyone want to PR a fix?
Catch All Triage - 1 2 3 4 5


add file to project / remove file from project

There's an active PR for this in omnisharp-roslyn: https://github.com/OmniSharp/omnisharp-roslyn/pull/295


Sound.setCategory('Playback') not working

Is this line of code Sound.setCategory('Playback') supposed to make the sound be played even when in the device is in silent mode?
I am testing on my android and it does not work in silent mode

@leonardo-weber Did you find the solution?


Remove fields with leading underscore from metadata

before indexing in portal

Nils wants the fix to be in entiy-api


Categorization improvement2

Updated interface to use X and O instead of numbers
It no longer maintain list of positions other than SomethingElse category
Now it handles positions at somethingElse category better.
Comment out logging of list

ok, looks good


Perl: highlight breaks with constants

VSCode Version: 1.38.1
OS Version: Windows_NT x64 10.0.17763

Steps to Reproduce:

Create a perl module like this:

use v5.10;
use strict;
use warning;

use constant FOO => 42;

my $x = 33;
$x = $x << FOO;

say($x);

Notice that after utilization of FOO, color highlight breaks:

Does this issue occur when all extensions are disabled?: Yes
The problem seems to be that this regular expression https://github.com/textmate/perl.tmbundle/blob/master/Syntaxes/Perl.plist#L2080 breaks rules of Perl syntax:

The terminating string may be either an identifier (a word), or some quoted text. An unquoted identifier works like double quotes. There may not be a space between the << and the identifier, unless the identifier is explicitly quoted. The terminating string must appear by itself (unquoted and with no surrounding white-space) on the terminating line.

https://perldoc.perl.org/perlop.html#Quote-and-Quote-like-Operators
As it consumes a white-spaces successfully.
I don't know who's to blame here, so I make the issue here and you can if necessary duplicate it to TextMate project.
On huge projects, it is really annoying to break syntax of a large file by simple usage of a constant.

Moved to owning repo: https://github.com/textmate/perl.tmbundle/issues/new


Result set data table should be tighter

Things to consider:

Each column header takes up a lot of room due to the "data type" icon and the "pin column" icon. It leads to a lot of whitespace when the column's data is less wide than the column header.
Font size in the data cells could possibly go down 1 size
Less padding

If the compressed design feels way off when there's not much data, then consider a "comfy" and "compact" view toggle.

I very much agree with this. I think it resonates with the principal we've tried to articulate about how information density is very important for data tools, especially for tools that people are using for professional work. I'm not sure about changing the font size in particular, there might be a tradeoff there with legibility if it's too small but certainly something to experiment with. However I agree very much with the overall sentiment that it would be worth trying to get a little more information on the page for people who are trying to look through their data

I'm not sure I 100% agree with most of this but we can definitely give it a shot after #739 lands and see how it feels


PHP gone from Ubuntu 18.04 image?

PHP pipelines on 2 separate repo's failed today during a cron run. Several errors are triggered but the most apparent is one generated by composer that reads in part:
... the requested PHP extension xml is missing from your system.

Looking through https://github.com/actions/virtual-environments/commit/8c049cd8222a0e55c44b3f2f3a585a06a71df0ed specifically line 200 - PHP references were removed. PHP is obviously still available on the images otherwise composer wouldn't be functional. But I don't think the default PHP extensions are being built correctly in version 20200531.1. Yesterdays CI run built on version 20200525.2 didn't experience any problems..
Virtual environments affected

[ ] macOS 10.15
[ ] Ubuntu 16.04 LTS
[x] Ubuntu 18.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Hi @jrushlow!
We aware of this issue, and currently reverting Ubuntu images to fix this. We will keep you posted.

As a note for anyone trying to work around this while the problem is repaired... I was able to add an install to my github deploy.yml
this forced the install of PHP and php-curl (which we required for our deployment).
Not a code fix, but though it may help someone trying to work past the code issue.
run: |
sudo apt-get install php-curl

Same issue here
Tried with all available ubuntu versions (18.04, 16.04 and even 20.04)
The pipeline YML has PHP 7.2 explicitly set, but when pipeline runs it fails to get 7.2 and apparently enforces 7.4
update-alternatives: error: alternative /usr/bin/phar7.2 for phar not registered; not setting
update-alternatives: error: alternative /usr/bin/phpdbg7.2 for phpdbg not registered; not setting
update-alternatives: error: no alternatives for php-cgi
update-alternatives: error: alternative /usr/bin/phar.phar7.2 for phar.phar not registered; not setting
PHP 7.4.6 (cli) (built: May 14 2020 10:02:44) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.6, Copyright (c), by Zend Technologies
    with Xdebug v2.9.5, Copyright (c) 2002-2020, by Derick Rethans

@jrushlow @Abncoffee we've finished the rollback a few minutes ago, could you check one more time, please?

@jrushlow @Abncoffee we've finished the rollback a few minutes ago(except Ubuntu20, because it was the very first image), could you check one more time, please?

Now it's working again!
update-alternatives: using /usr/bin/phar7.2 to provide /usr/bin/phar (phar) in manual mode
update-alternatives: using /usr/bin/phpdbg7.2 to provide /usr/bin/phpdbg (phpdbg) in manual mode
update-alternatives: using /usr/bin/php-cgi7.2 to provide /usr/bin/php-cgi (php-cgi) in manual mode
update-alternatives: using /usr/bin/phar.phar7.2 to provide /usr/bin/phar.phar (phar.phar) in manual mode
PHP 7.2.31-1+ubuntu18.04.1+deb.sury.org+1 (cli) (built: May 14 2020 08:27:35) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.2.31-1+ubuntu18.04.1+deb.sury.org+1, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.9.5, Copyright (c) 2002-2020, by Derick Rethans

Finishing: Use PHP version 7.2

Thank you very much, guys!

@miketimofeev sorry for the delay, I'm showing v 20200525.2 on the cron job runs for last night w/ green checks. Things are happy happy happy again on my end.

@jrushlow I'm going to close the issue, feel free to contact us if you have any concerns.
Thank you!

can confirm this is now working correctly.  Thanks go out to all the devs that worked on this !

@leerlemoniii based on the repo's that I'm managing - the Ubuntu 18.04 images are as they were 3 days ago (v20200525.2) and running without issue


Ensure ToggleVisibility interacts with bleed correctly

Release
Renderer status
Tasks status

Backlog
🔄 .NET (#2816)🔄 Android (#2817)🔄 iOS (#2818)✔ TS (#2819)🔄 UWP (#2820)
🔄 Shared (#2814)✔ Designer (#2815)

Splitting the bleed issue out from #2600 (which now tracks issues of separators only)
Does setting the framework element's visibility trigger a re-layout of the card to make sure that bleeding elements bleed correctly? For instance, take the following payload:
{
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "type": "AdaptiveCard",
    "version": "1.0",
    "body": [
        {
            "type": "TextBlock",
            "id": "title",
            "text": "This is a TextBlock at the top of the card",
            "wrap": true
        },
        {
            "type": "Container",
            "style": "emphasis",
            "bleed": true,
            "items": [
                {
                    "type": "TextBlock",
                    "text": "This is a bleeding container",
                    "size": "extraLarge"
                },
                {
                    "type": "ActionSet",
                    "actions": [
                        {
                            "type": "Action.ToggleVisibility",
                            "title": "Click me",
                            "targetElements": [
                                "title"
                            ]
                        }
                    ]
                }
            ]
        }
    ]
}

Initially it renders like this:

Once the button is clicked, it should look like this:

Auto-generated task status

[ ] Shared
[x] Designer
[ ] .NET
[ ] Android
[ ] iOS
[x] TS
[ ] UWP

Due to a constraint in the current design (#2678), this isn't going to make it into 1.2. Moving to the backlog.

Not currently under consideration, but will reactivate should we decide to pursue.


Fix dependency override removal warning logic being inverted

Inverts the logic for when a dependency override removal logs a warning, as it currently logs when it did find a dependency to remove, rather than when it did not. I moved the warning code out of the block so this is easier to read, overall.
I've also removed two unused imports as my editor was screaming at me for being unable to find the first one, and it doesn't seem like it was added intentionally.

Thanks!


Add breaking change in FieldInfo.SetValue

Fixes #17060
Internal preview link
Related to https://github.com/dotnet/dotnet-api-docs/issues/3851 and https://github.com/dotnet/runtime/issues/11571.

LGTM otherwise. Thank you!

Thanks for the reviews!


django-celery

Good people can you please explain where is the mistake?
Unhandled exception in thread started by <function check_errors..wrapper at 0x03F88660>
Traceback (most recent call last):
File "C:\Users\Admin\myvenv\lib\site-packages\django\utils\autoreload.py", line 226, in wrapper
fn(args, **kwargs)
File "C:\Users\Admin\myvenv\lib\site-packages\django\core\management\commands\runserver.py", line 113, in inner_run
autoreload.raise_last_exception()
File "C:\Users\Admin\myvenv\lib\site-packages\django\utils\autoreload.py", line 249, in raise_last_exception
six.reraise(exception)
File "C:\Users\Admin\myvenv\lib\site-packages\django\utils\six.py", line 685, in reraise
raise value.with_traceback(tb)
File "C:\Users\Admin\myvenv\lib\site-packages\django\utils\autoreload.py", line 226, in wrapper
fn(*args, **kwargs)
File "C:\Users\Admin\myvenv\lib\site-packages\django_init.py", line 27, in setup
apps.populate(settings.INSTALLED_APPS)
File "C:\Users\Admin\myvenv\lib\site-packages\django\apps\registry.py", line 108, in populate
app_config.import_models(all_models)
File "C:\Users\Admin\myvenv\lib\site-packages\django\apps\config.py", line 199, in import_models
self.models_module = import_module(models_module_name)
File "C:\Program Files (x86)\Python35-32\lib\importlib_init_.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 986, in _gcd_import
File "", line 969, in _find_and_load
File "", line 958, in _find_and_load_unlocked
File "", line 673, in _load_unlocked
File "", line 665, in exec_module
File "", line 222, in _call_with_frames_removed
File "C:\Users\Admin\myvenv\lib\site-packages\djcelery\models.py", line 15, in
from celery.utils.timeutils import timedelta_seconds
ImportError: No module named 'celery.utils.timeutils'

its not working with celery 4.0+

I don't believe there are plans to make django-celery work with celery 4.
There are two new packages that replace some of the extra features of django celery that will work with celery 4:
django-celery-beat and django-celery-results
They are described here:
http://docs.celeryproject.org/en/latest/django/first-steps-with-django.html

I just dropped django-celery from my current Django project based on the official guides and it works it took some time change configuration name.
So here is the end result

Create a file called celery_app.py with the following contents

# -*- coding: utf-8 -*-
from __future__ import absolute_import

import os

from celery import Celery
from django.conf import settings  # noqa

app = Celery('MyApp')

app.config_from_object('celeryconfig')
app.autodiscover_tasks(settings.INSTALLED_APPS)

Create a file called celeryconfig.py and move you configurations, also update them to support the latest changes

In your Django applications root_folder/__init__.py add the following code (it will be at the same module level as the file celery_app.py, though you can put it anywhere and just import)

from __future__ import absolute_import, unicode_literals

# This will make sure the app is always imported when
# Django starts so that shared_task will use this app.
from .celery_app import app

__all__ = ['app']


License file

Hello, is this repo intended to have an MIT license?

@nsjames I believe the license will be MIT, since that's the license for the main Astro project, but I am checking on this!

@nsjames Yes, MIT! I'll add the license to the docs today.  Thanks for pointing it out!


Added the missing es:ListDomainNames to the minimal iam policy example

Pull Request Test Coverage Report for Build 107

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 97:
0.0%

Covered Lines:
372

Relevant Lines:
372

💛  - Coveralls

Pull Request Test Coverage Report for Build 107

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 97:
0.0%

Covered Lines:
372

Relevant Lines:
372

💛  - Coveralls

Any update on this?

Sorry on the delay and thanks for this PR!