Prompts for non-required slots

Just as a contrived example I may want my bot to ask how someone is doing. I could do this with a keyword/modifiers that classify how they are into bad, okay, good. And then have an action that prompts for that slot 'How are you doing today', but I would be okay if they ignore that and don't answer since it's just small talk.

Here's what I am trying to prevent:

We might also be able to accomplish this with a slot prompt lifespan. when set to 1 we will only prompt once. If no response is received on the very next action that action is considered fulfilled. If the lifespan is >1 we will prompt that many times.

What if theres conditional slot.. if the user fulfill the closure/end slot, you dont need to ask for the open/first slot.

Or at least some way to cancel the query

Addressed with prompt limit


Is optional<shared_ptr> necessary?

I get the intention behind specifying an optional<T> in the interface definition, stating that the passed in object reference may be nil/null in Obj-C or Java and this intention is clearly shown in the C++ side using optional<shared_ptr<T>> as argument or return type.
My problem with this is twofold:

shared_ptr already has a well defined empty state. Wrapping the whole thing inside optional seems redundant.
There is no indication in the Obj-C/Java interface telling a user where passing nil or null is OK or not, contrary to the C++ signature. The difference only manifests itself in the form of a runtime error if used incorrectly. Therefore whether a function accepts empty object references must be documented somewhere as one cannot infer it form the argument/return types.

My conclusion is getting rid of optional<shared_ptr<T>> and instead transform nil/null to/from empty shared_ptr<T> for interface types, regardless of whether they are defined as T or optional<T> in the Djinni file. However for plain T the generated code could handle nil/null/nullptr as errors and throw an appropriate exceptions to the offending code with an explanatory error message along the lines of "argument xxx may not be null", "return value must not be null" and so on.
Does that sound like a sensible thing to do?

I think it'd be totally reasonable to make optional emit an un-std::optional<>'d shared_ptr in C++ code. I already read "shared_ptr" to mean "optional value that could be null." What if we only used optional<> for non-pointer types?

New status on this is all interfaces are now nullable and transform nil/null <-> nullptr, so the C++ code has to assume the shared_ptr arguments may be empty. Djinni still accepts optional<T> where T is an interface, but there's no reason to use that anymore.

Totally agreed that we should never emit optional<shared_ptr<T>>. I'm starting to like the idea of having optional on interfaces correlate to annotations. Here's my understanding of the situation across languages - let me know if I'm missing something:

Java has a few different annotations used for nullability checking, so we'd probably want to make the choice configurable (there's JSR 305, which is 'abandoned' but apparently still used, JSR 308, and Android has its own set).
ObjC very recently got nullability specifiers (https://developer.apple.com/swift/blog/?id=25). We already emit these as of 137c2ea8fd12635ca29e98af6bffd3018e822451. They've come in handy for records, but at the moment interfaces are always tagged as nullable.
C++ has shared_ptr and there is no standard idiom for a non-nullable shared_ptr. Internally we've actually built non-nullable unique_ptr and shared_ptr types, and we're planning to release them soon - so one option would be to add command-line options for "this is the type you should use for non-nullable pointers in C++".

For C++ there are some proposals for defensive programming, that might be useful in the future.
Are there any static analyzers that use C++11 [[attributes]]?
Using it only for annotations is interesting. If the C++ classes were implemented as NVI assert() could be inserted by Djinni in the base implementation, but that would break existing code left and right.

Closing this since I think we're in a good shape with the new nn stuff, and haven't generated optional<shared_ptr> in a long time.

Can you guys update the docs on this?  They don't mention a difference in code generation between optional and optional... but I can see it's there in the results.  Little speed bump for me. Thanks!

@jefftrull Pull requests welcome!
Less flippantly, yes, better docs would be great, for this, and lots of other things.  I may not get time to look at that before the holidays, though, and I want everyone in the community to feel empowered to make things incrementally better as they discover what's needed.


[ENHANCEMENT] Set default video mode

would be neat if we could set the default Video resolution and if it should be stretched. with custom UVs it's pain tto every time the stream starts set it to stretched.

default fit just got checked in.  Depending on your use case, it may also be appropriate to copy the TXL video material and set the screen fit on that, then delete the fit property from the property map paired with it to prevent it from being overridden.  The new default setting will be simpler though if you know you're always dealing with the same source res.
Will also look at default for the res.


openjph: 0.17.0 -> 0.18.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for openjph is: Open-source implementation of JPEG2000 Part-15 (or JPH or HTJ2K)
meta.homepage for openjph is: https://openjph.org/
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.18.1 with grep in /nix/store/dy5afz7lyb2sqvsd3h8047flknzq0a9q-openjph-0.18.1
found 0.18.1 in filename of file in /nix/store/dy5afz7lyb2sqvsd3h8047flknzq0a9q-openjph-0.18.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

openjph

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dy5afz7lyb2sqvsd3h8047flknzq0a9q-openjph-0.18.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A openjph https://github.com/r-ryantm/nixpkgs/archive/29313f73725ee1263ca0debb4643d44bf13045b3.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/29313f73725ee1263ca0debb4643d44bf13045b3#openjph

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dy5afz7lyb2sqvsd3h8047flknzq0a9q-openjph-0.18.1
ls -la /nix/store/dy5afz7lyb2sqvsd3h8047flknzq0a9q-openjph-0.18.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 2 packages built:

openjph
openjph.dev

Maintainer pings
cc @abustany for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


PHOENIX-6261 Reorganise project structure to make mvn versions:set work

Change-Id: I95f5174add05fbf47b1a4f6aa066e5c640b4bcc6

@stoty @chrajeshbabu  @joshelser
Could some of you take a look at it, please?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
8m 26s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
10m 40s
master passed

+1 :green_heart:
compile
2m 21s
master passed

+1 :green_heart:
javadoc
2m 59s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 19s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
10m 20s
the patch passed

+1 :green_heart:
compile
2m 17s
the patch passed

+1 :green_heart:
javac
2m 17s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m 15s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
3m  5s
the patch passed

_ Other Tests _

-1 :x:
unit
48m 17s
root in the patch failed.

-1 :x:
asflicense
1m 27s
The patch generated 1 ASF License warnings.

92m 10s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/44

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux ad2ddc6abac6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / 38bcd9a

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/1/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/1/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
1760 (vs. ulimit of 30000)

modules
C: phoenix-connectors-phoenix4-compat phoenix-connectors-phoenix5-compat phoenix-connectors-base phoenix-hive-base phoenix-flume-base phoenix-pig-base phoenix-kafka-base phoenix-spark-base phoenix4-connectors-assembly phoenix5-connectors-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/1/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I'm fine with this, but let's wait a bit for more feedback.

Anything that isn't in  or  can be moved to the new top level project.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

 Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
16m 41s
the patch passed

+1 :green_heart:
compile
2m 28s
the patch passed

+1 :green_heart:
javac
2m 28s
the patch passed

+1 :green_heart:
scalac
2m 28s
the patch passed

-1 :x:
checkstyle
3m 57s
root: The patch generated 4400 new + 4356 unchanged - 22 fixed = 8756 total (was 4378)

+1 :green_heart:
markdownlint
0m  2s
There were no new markdownlint issues.

-1 :x:
whitespace
0m  1s
The patch has 370 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
whitespace
0m  1s
The patch 1025 line(s) with tabs.

-1 :x:
xml
0m 41s
The patch has 3 ill-formed XML file(s).

-1 :x:
javadoc
0m 50s
phoenix-connectors-base generated 20 new + 0 unchanged - 0 fixed = 20 total (was 0)

-1 :x:
javadoc
0m 21s
phoenix-connectors-base_phoenix-hive-base generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)

-1 :x:
javadoc
0m 15s
phoenix-connectors-base_phoenix-hive-base_phoenix4-hive generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

-1 :x:
javadoc
0m 16s
phoenix-connectors-base_phoenix-hive-base_phoenix5-hive generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

-1 :x:
javadoc
0m 15s
phoenix-connectors-base_phoenix-pig-base generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

-1 :x:
javadoc
0m 12s
phoenix-connectors-base_phoenix-pig-base_phoenix4-pig generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

-1 :x:
javadoc
0m 12s
phoenix-connectors-base_phoenix-pig-base_phoenix5-pig generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

-1 :x:
javadoc
0m 19s
phoenix-connectors-base_phoenix-spark-base generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-1 :x:
javadoc
0m 13s
phoenix-connectors-base_phoenix-spark-base_phoenix4-spark generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

-1 :x:
javadoc
0m 14s
phoenix-connectors-base_phoenix-spark-base_phoenix5-spark generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

-1 :x:
javadoc
0m 52s
root generated 20 new + 0 unchanged - 20 fixed = 20 total (was 20)

-1 :x:
scaladoc
0m  8s
phoenix-connectors-phoenix4-compat in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix-connectors-phoenix5-compat in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-connectors-base in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-hive-base in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix4-hive in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix5-hive in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix-flume-base in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix4-flume in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix5-flume in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix-pig-base in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix4-pig in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix5-pig in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-kafka-base in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix4-kafka in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix5-kafka in the patch failed.

-1 :x:
scaladoc
0m 54s
phoenix-connectors-base_phoenix-spark-base generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

-1 :x:
scaladoc
0m  7s
phoenix4-connectors-assembly in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix5-connectors-assembly in the patch failed.

-1 :x:
scaladoc
0m  8s
root in the patch failed.

+1 :green_heart:
spotbugs
18m 21s
the patch passed

_ Other Tests _

-1 :x:
unit
14m  7s
root in the patch failed.

-1 :x:
asflicense
2m 48s
The patch generated 1 ASF License warnings.

129m  4s

Reason
Tests

XML
Parsing Error(s):

phoenix-connectors-base/phoenix-spark-base/src/it/resources/log4j.xml

phoenix-connectors-base/phoenix-spark-base/src/main/resources/log4j.xml

phoenix-connectors-base/phoenix-spark-base/src/test/resources/log4j.xml

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/44

Optional Tests
dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle markdownlint scalac scaladoc

uname
Linux 4a22e0554484 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / 22fe0ce

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-connectors-phoenix4-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-connectors-phoenix5-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-hive-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-flume-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-pig-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-pig-base_phoenix4-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-pig-base_phoenix5-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-kafka-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-root.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix4-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-flume-base_phoenix4-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-flume-base_phoenix5-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-hive-base_phoenix4-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-hive-base_phoenix5-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-kafka-base_phoenix4-kafka.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/branch-scaladoc-phoenix-kafka-base_phoenix5-kafka.txt

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/whitespace-eol.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/whitespace-tabs.txt

xml
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/xml.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-hive-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-hive-base_phoenix4-hive.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-hive-base_phoenix5-hive.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-pig-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-pig-base_phoenix4-pig.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-pig-base_phoenix5-pig.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-spark-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-spark-base_phoenix4-spark.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-spark-base_phoenix5-spark.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-phoenix4-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-phoenix5-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-hive-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-hive-base_phoenix4-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-hive-base_phoenix5-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-flume-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-flume-base_phoenix4-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-flume-base_phoenix5-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-pig-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-pig-base_phoenix4-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-pig-base_phoenix5-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-kafka-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-kafka-base_phoenix4-kafka.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-kafka-base_phoenix5-kafka.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/diff-scaladoc-scaladoc-phoenix-connectors-base_phoenix-spark-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix4-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix5-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-scaladoc-root.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
1707 (vs. ulimit of 30000)

modules
C: phoenix-connectors-phoenix4-compat phoenix-connectors-phoenix5-compat phoenix-connectors-base phoenix-connectors-base/phoenix-hive-base phoenix-connectors-base/phoenix-hive-base/phoenix4-hive phoenix-connectors-base/phoenix-hive-base/phoenix5-hive phoenix-connectors-base/phoenix-flume-base phoenix-connectors-base/phoenix-flume-base/phoenix4-flume phoenix-connectors-base/phoenix-flume-base/phoenix5-flume phoenix-connectors-base/phoenix-pig-base phoenix-connectors-base/phoenix-pig-base/phoenix4-pig phoenix-connectors-base/phoenix-pig-base/phoenix5-pig phoenix-connectors-base/phoenix-kafka-base phoenix-connectors-base/phoenix-kafka-base/phoenix4-kafka phoenix-connectors-base/phoenix-kafka-base/phoenix5-kafka phoenix-connectors-base/phoenix-spark-base phoenix-connectors-base/phoenix-spark-base/phoenix4-spark phoenix-connectors-base/phoenix-spark-base/phoenix5-spark phoenix-connectors-base/phoenix4-connectors-assembly phoenix-connectors-base/phoenix5-connectors-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/4/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 markdownlint=0.22.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
20m  0s
the patch passed

+1 :green_heart:
compile
2m 55s
the patch passed

+1 :green_heart:
javac
2m 55s
the patch passed

+1 :green_heart:
scalac
2m 55s
the patch passed

-1 :x:
checkstyle
3m 45s
root: The patch generated 4404 new + 4352 unchanged - 26 fixed = 8756 total (was 4378)

+1 :green_heart:
markdownlint
0m  2s
There were no new markdownlint issues.

-1 :x:
whitespace
0m  0s
The patch has 370 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
whitespace
0m  0s
The patch 1025 line(s) with tabs.

-1 :x:
xml
0m 47s
The patch has 3 ill-formed XML file(s).

-1 :x:
javadoc
0m 55s
phoenix-connectors-base generated 20 new + 0 unchanged - 0 fixed = 20 total (was 0)

-1 :x:
javadoc
0m 24s
phoenix-connectors-base_phoenix-hive-base generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)

-1 :x:
javadoc
0m 17s
phoenix-connectors-base_phoenix-hive-base_phoenix4-hive generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

-1 :x:
javadoc
0m 17s
phoenix-connectors-base_phoenix-hive-base_phoenix5-hive generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

-1 :x:
javadoc
0m 18s
phoenix-connectors-base_phoenix-pig-base generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

-1 :x:
javadoc
0m 13s
phoenix-connectors-base_phoenix-pig-base_phoenix4-pig generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

-1 :x:
javadoc
0m 14s
phoenix-connectors-base_phoenix-pig-base_phoenix5-pig generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

-1 :x:
javadoc
0m 20s
phoenix-connectors-base_phoenix-spark-base generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-1 :x:
javadoc
0m 15s
phoenix-connectors-base_phoenix-spark-base_phoenix4-spark generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

-1 :x:
javadoc
0m 15s
phoenix-connectors-base_phoenix-spark-base_phoenix5-spark generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

-1 :x:
javadoc
1m  0s
root generated 20 new + 0 unchanged - 20 fixed = 20 total (was 20)

-1 :x:
scaladoc
0m  8s
phoenix-connectors-phoenix4-compat in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-connectors-phoenix5-compat in the patch failed.

-1 :x:
scaladoc
0m 10s
phoenix-connectors-base in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-hive-base in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix4-hive in the patch failed.

-1 :x:
scaladoc
0m  9s
phoenix5-hive in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-flume-base in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix4-flume in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix5-flume in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-pig-base in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix4-pig in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix5-pig in the patch failed.

-1 :x:
scaladoc
0m  9s
phoenix-kafka-base in the patch failed.

-1 :x:
scaladoc
0m  9s
phoenix4-kafka in the patch failed.

-1 :x:
scaladoc
0m  9s
phoenix5-kafka in the patch failed.

-1 :x:
scaladoc
1m  7s
phoenix-connectors-base_phoenix-spark-base generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

-1 :x:
scaladoc
0m  8s
phoenix4-connectors-assembly in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix5-connectors-assembly in the patch failed.

-1 :x:
scaladoc
0m  9s
root in the patch failed.

+1 :green_heart:
spotbugs
21m 48s
the patch passed

_ Other Tests _

-1 :x:
unit
14m 57s
root in the patch failed.

-1 :x:
asflicense
2m 41s
The patch generated 1 ASF License warnings.

137m  7s

Reason
Tests

XML
Parsing Error(s):

phoenix-connectors-base/phoenix-spark-base/src/it/resources/log4j.xml

phoenix-connectors-base/phoenix-spark-base/src/main/resources/log4j.xml

phoenix-connectors-base/phoenix-spark-base/src/test/resources/log4j.xml

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/44

Optional Tests
dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle markdownlint scalac scaladoc

uname
Linux c02d1e5e97a2 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / 22fe0ce

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-connectors-phoenix4-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-connectors-phoenix5-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-hive-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-flume-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-pig-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-pig-base_phoenix4-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-pig-base_phoenix5-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-kafka-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-root.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix4-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-flume-base_phoenix4-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-flume-base_phoenix5-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-hive-base_phoenix4-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-hive-base_phoenix5-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-kafka-base_phoenix4-kafka.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/branch-scaladoc-phoenix-kafka-base_phoenix5-kafka.txt

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/whitespace-eol.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/whitespace-tabs.txt

xml
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/xml.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-hive-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-hive-base_phoenix4-hive.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-hive-base_phoenix5-hive.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-pig-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-pig-base_phoenix4-pig.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-pig-base_phoenix5-pig.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-spark-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-spark-base_phoenix4-spark.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-spark-base_phoenix5-spark.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-phoenix4-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-phoenix5-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-hive-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-hive-base_phoenix4-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-hive-base_phoenix5-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-flume-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-flume-base_phoenix4-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-flume-base_phoenix5-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-pig-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-pig-base_phoenix4-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-pig-base_phoenix5-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-kafka-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-kafka-base_phoenix4-kafka.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-kafka-base_phoenix5-kafka.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/diff-scaladoc-scaladoc-phoenix-connectors-base_phoenix-spark-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix4-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix5-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-scaladoc-root.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/testReport/

asflicense
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/artifact/yetus-general-check/output/patch-asflicense-problems.txt

Max. process+thread count
1707 (vs. ulimit of 30000)

modules
C: phoenix-connectors-phoenix4-compat phoenix-connectors-phoenix5-compat phoenix-connectors-base phoenix-connectors-base/phoenix-hive-base phoenix-connectors-base/phoenix-hive-base/phoenix4-hive phoenix-connectors-base/phoenix-hive-base/phoenix5-hive phoenix-connectors-base/phoenix-flume-base phoenix-connectors-base/phoenix-flume-base/phoenix4-flume phoenix-connectors-base/phoenix-flume-base/phoenix5-flume phoenix-connectors-base/phoenix-pig-base phoenix-connectors-base/phoenix-pig-base/phoenix4-pig phoenix-connectors-base/phoenix-pig-base/phoenix5-pig phoenix-connectors-base/phoenix-kafka-base phoenix-connectors-base/phoenix-kafka-base/phoenix4-kafka phoenix-connectors-base/phoenix-kafka-base/phoenix5-kafka phoenix-connectors-base/phoenix-spark-base phoenix-connectors-base/phoenix-spark-base/phoenix4-spark phoenix-connectors-base/phoenix-spark-base/phoenix5-spark phoenix-connectors-base/phoenix4-connectors-assembly phoenix-connectors-base/phoenix5-connectors-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/5/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 markdownlint=0.22.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

I've just checked, and there is no need for phoenix-base.
Simply reparenting the compatibility modules to phoenix-connectors works just fine.

As @stoty pointed out, we don't need to create a common ancestor module here, everything should work fine if we just change the parents of the phoenix-connectors-compat modules. This way the change size can be a reduced by a significant amount.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
16m 23s
the patch passed

+1 :green_heart:
compile
2m 17s
the patch passed

+1 :green_heart:
javac
2m 17s
the patch passed

+1 :green_heart:
scalac
2m 17s
the patch passed

-1 :x:
checkstyle
4m 35s
root: The patch generated 4404 new + 4352 unchanged - 26 fixed = 8756 total (was 4378)

+1 :green_heart:
markdownlint
0m  3s
There were no new markdownlint issues.

-1 :x:
whitespace
0m  1s
The patch has 370 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
whitespace
0m  1s
The patch 1025 line(s) with tabs.

-1 :x:
xml
0m 42s
The patch has 3 ill-formed XML file(s).

-1 :x:
javadoc
0m 48s
phoenix-connectors-base generated 20 new + 0 unchanged - 0 fixed = 20 total (was 0)

-1 :x:
javadoc
0m 21s
phoenix-connectors-base_phoenix-hive-base generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)

-1 :x:
javadoc
0m 14s
phoenix-connectors-base_phoenix-hive-base_phoenix4-hive generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

-1 :x:
javadoc
0m 15s
phoenix-connectors-base_phoenix-hive-base_phoenix5-hive generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

-1 :x:
javadoc
0m 16s
phoenix-connectors-base_phoenix-pig-base generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)

-1 :x:
javadoc
0m 11s
phoenix-connectors-base_phoenix-pig-base_phoenix4-pig generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

-1 :x:
javadoc
0m 12s
phoenix-connectors-base_phoenix-pig-base_phoenix5-pig generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

-1 :x:
javadoc
0m 18s
phoenix-connectors-base_phoenix-spark-base generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)

-1 :x:
javadoc
0m 13s
phoenix-connectors-base_phoenix-spark-base_phoenix4-spark generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

-1 :x:
javadoc
0m 13s
phoenix-connectors-base_phoenix-spark-base_phoenix5-spark generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

-1 :x:
javadoc
0m 52s
root generated 20 new + 0 unchanged - 20 fixed = 20 total (was 20)

-1 :x:
scaladoc
0m  8s
phoenix-connectors-phoenix4-compat in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-connectors-phoenix5-compat in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-connectors-base in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-hive-base in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix4-hive in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix5-hive in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-flume-base in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix4-flume in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix5-flume in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-pig-base in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix4-pig in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix5-pig in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix-kafka-base in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix4-kafka in the patch failed.

-1 :x:
scaladoc
0m  8s
phoenix5-kafka in the patch failed.

-1 :x:
scaladoc
0m 53s
phoenix-connectors-base_phoenix-spark-base generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)

-1 :x:
scaladoc
0m  7s
phoenix4-connectors-assembly in the patch failed.

-1 :x:
scaladoc
0m  7s
phoenix5-connectors-assembly in the patch failed.

-1 :x:
scaladoc
0m  9s
root in the patch failed.

+1 :green_heart:
spotbugs
18m 10s
the patch passed

_ Other Tests _

-1 :x:
unit
14m 25s
root in the patch failed.

+1 :green_heart:
asflicense
2m 45s
The patch does not generate ASF License warnings.

128m  0s

Reason
Tests

XML
Parsing Error(s):

phoenix-connectors-base/phoenix-spark-base/src/it/resources/log4j.xml

phoenix-connectors-base/phoenix-spark-base/src/main/resources/log4j.xml

phoenix-connectors-base/phoenix-spark-base/src/test/resources/log4j.xml

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/44

Optional Tests
dupname asflicense javac javadoc unit xml compile spotbugs hbaseanti checkstyle markdownlint scalac scaladoc

uname
Linux 633907aae80b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / 22fe0ce

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-connectors-phoenix4-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-connectors-phoenix5-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-hive-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-flume-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-pig-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-pig-base_phoenix4-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-pig-base_phoenix5-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-kafka-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-root.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix4-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix5-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-flume-base_phoenix4-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-flume-base_phoenix5-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-hive-base_phoenix4-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-hive-base_phoenix5-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-kafka-base_phoenix4-kafka.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/branch-scaladoc-phoenix-kafka-base_phoenix5-kafka.txt

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-checkstyle-root.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/whitespace-eol.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/whitespace-tabs.txt

xml
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/xml.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-hive-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-hive-base_phoenix4-hive.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-hive-base_phoenix5-hive.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-pig-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-pig-base_phoenix4-pig.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-pig-base_phoenix5-pig.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-spark-base.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-spark-base_phoenix4-spark.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-connectors-base_phoenix-spark-base_phoenix5-spark.txt

javadoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-phoenix4-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-phoenix5-compat.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-hive-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-hive-base_phoenix4-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-hive-base_phoenix5-hive.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-flume-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-flume-base_phoenix4-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-flume-base_phoenix5-flume.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-pig-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-pig-base_phoenix4-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-pig-base_phoenix5-pig.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-kafka-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-kafka-base_phoenix4-kafka.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix-kafka-base_phoenix5-kafka.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/diff-scaladoc-scaladoc-phoenix-connectors-base_phoenix-spark-base.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix4-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-phoenix-connectors-base_phoenix5-connectors-assembly.txt

scaladoc
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-scaladoc-root.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/artifact/yetus-general-check/output/patch-unit-root.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/testReport/

Max. process+thread count
1712 (vs. ulimit of 30000)

modules
C: phoenix-connectors-phoenix4-compat phoenix-connectors-phoenix5-compat phoenix-connectors-base phoenix-connectors-base/phoenix-hive-base phoenix-connectors-base/phoenix-hive-base/phoenix4-hive phoenix-connectors-base/phoenix-hive-base/phoenix5-hive phoenix-connectors-base/phoenix-flume-base phoenix-connectors-base/phoenix-flume-base/phoenix4-flume phoenix-connectors-base/phoenix-flume-base/phoenix5-flume phoenix-connectors-base/phoenix-pig-base phoenix-connectors-base/phoenix-pig-base/phoenix4-pig phoenix-connectors-base/phoenix-pig-base/phoenix5-pig phoenix-connectors-base/phoenix-kafka-base phoenix-connectors-base/phoenix-kafka-base/phoenix4-kafka phoenix-connectors-base/phoenix-kafka-base/phoenix5-kafka phoenix-connectors-base/phoenix-spark-base phoenix-connectors-base/phoenix-spark-base/phoenix4-spark phoenix-connectors-base/phoenix-spark-base/phoenix5-spark phoenix-connectors-base/phoenix4-connectors-assembly phoenix-connectors-base/phoenix5-connectors-assembly . U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/6/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.4 markdownlint=0.22.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Nice cleanup, one question: hbase-common is not required for phoenix-connectors-phoenix4-compat?

Nice cleanup, one question: hbase-common is not required as provided dependency for phoenix-connectors-phoenix4-compat?

No, it is not. hbase-common is requireed only for the phoenix5 as we import org.apache.hadoop.hbase.TableName; there but in phoenix 4 it is not imported.
maven-dependency-plugin:analyze-only marked it as an unused dependency in some of the earlier iterations.
I think it did not run earlier on that module so we did not notice it.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
3m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+0 :ok:
mvndep
8m  1s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m  3s
master passed

+1 :green_heart:
compile
0m 33s
master passed

+1 :green_heart:
javadoc
0m 21s
master passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 20s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
20m 13s
the patch passed

+1 :green_heart:
compile
0m 36s
the patch passed

+1 :green_heart:
javac
0m 36s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
0m 22s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 23s
phoenix-connectors-phoenix4-compat in the patch passed.

+1 :green_heart:
unit
0m 27s
phoenix-connectors-phoenix5-compat in the patch passed.

+1 :green_heart:
asflicense
0m 17s
The patch does not generate ASF License warnings.

57m 38s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/7/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix-connectors/pull/44

Optional Tests
dupname asflicense javac javadoc unit xml compile

uname
Linux 144d83357e9d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-connectors-personality.sh

git revision
master / 22fe0ce

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/7/testReport/

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: phoenix-connectors-phoenix4-compat phoenix-connectors-phoenix5-compat U: .

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-44/7/console

versions
git=2.7.4 maven=3.3.9

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Directives not working in query fields

I'm trying to create new directives to be used in query fields similar to @include and @skip. However, the resolver never executes. If I change it to be applied in the schema, the resolver executes fine.
Here's a launchpad example showing both
https://launchpad.graphql.com/lk9vwjrmwq

I have been running into the same problem. The PR for the custom directives feature indicates that directives on queries are not supported yet.
The work around suggested in that thread is graphql-directive, which is the same project @jbaxleyiii linked you to in Slack.

Closing the issue!

Have same issue here. Using graphql-directive doesn't work either. Anyone solved this?


Add Octree class

Copy the octree class into the client and work through any cross plat issues

You can assign this one to me if you want.

Sure :).

Also for this I think we discussed that it would be useful when, when copying the code from the server to the unity project, we leave out the XNA pieces and use Unity types instead.

The Unity types are more or less drop-ins for the XNA classes, most issues are casing and order of cctor stuff.

This has been completed.


fix: update chair list

Fixes issue #516
Remove Alex Flom (thanks Alex)
Add Andrew Block (thanks Andrew)

This has been approved by TAG chairs in #516 already so we will merge now.


GUI: placeholder: research questions

What does the CSKG know about a concept?
How relevant are the relations compared to what a human would expect?
What information should be shown/prioritized?
What are the paths between two concepts?
Do these make sense to a human?
Can a human find reasoning paths in the graph from a question to an answer, “simulating” automatic reasoning?

This has moved into a Google Doc. GitHub should be for concrete issues. Closing.


ENH: Add infrastructure for building the python package using GitHub Actions

The scripts were copied from ClinicalGraphics/VTKU3DExporter@669fe64bc (originally adapted from Kitware/LookingGlassVTKModule@78cc2cec9 and Slicer/vtkAddon@38c95af85)
Add CLEAVER external project for statically building the Cleaver library.

Closing. This pull request is superseded by one based on a branch directly pushed onto the upstream project. This was required to trigger & setup the GitHub Actions workflow.

https://github.com/SCIInstitute/VTKCleaver/pull/7


Fix the theme for latest rofi

The current version of rofi [Version: 1.7.0] breaks the theme. Fix the problem and add new instructions to activate the Dracula theme for rofi
Before fixing

After fixing

Is all of this really necessary? i could fix this changing @background reference to @background-color, just like this, without having root permissions to install a theme:
background-color: @background-color;
could be 2 alternatives to install a theme for user or system-wide installation with theses modifications


Why is there no chapter 5

Hi @PhysicalElective2 the Chapter5 does not have a code. thats why theres no Chapter5

Hello,
I concur with Saurabh.
As you can read, there is very little commands/queries and they are rather short.
So I choose not to give them as code as I believe muscle memory must be trained too.
Good reading
Jérôme Bâton (author)


feat: Import component

Contributes to #30
implements the import modal
currently a work in progress.

you can test the import file functionality with this image api https://picsum.photos/

@lee-chase it does because it wasn't a clear requirement for me. I can include that though if that is a requirement.

I will rework this to include multiple files, but just for transparency I wanted to give my thoughts on why I think that there is conflicting design surrounding this.
yes, there is some wording in the designs that indicate that multiple files could be added, but there's a lot of ux that indicates that that's not the case. if you look at the design (https://www.carbondesignsystem.com/community/patterns/import-pattern/) and image with the text underneath that reads "Example of a loaded file in the import modal" the drag and drop field as well as the text input and add file button are all in a disabled state once a file has been uploaded. it's the same thing with the "Example of a file imported by URL" image. it's also strangely enough the same thing in "Example of files loaded in the import dialog". even though there are multiple files being uploaded the inputs are still disabled. The only time you don't see this interaction is under "Import from a URL (full page or side-panel)". With that all being said i guess i'll just reach out to the designers to discuss what exactly is the intended ux for this component because based on what i'm seeing i don't think it's clear what's supposed to be intended behavior.

component has been updated to support multiple files. please review new changes.

Added an additional commit to fix the failing tests. it involves commenting out some code in the setupFilesAfterEnv.js config. i talked to Josh Black and there is a known issue in the latest version of carbon components that's causing tests with certain carbon components to fail. his suggestion was just to stub the offending console.log function. i assume we'll be able to revert that change once Josh has solved the issue on carbons end.


java.lang.UnsupportedOperationException: This feature requires ASM8_EXPERIMENTAL

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
recently i use skywalking in my application ，which is based on  jdk 14（and i use it's new feature, "record"）.however ,when i try to use skywalking-agent with this application and my application was visited，the skywalking-agent logs will print “java.lang.UnsupportedOperationException: This feature requires ASM8_EXPERIMENTAL”。

can somebody give me some advice which can slove this problem ?

It seems requiring a byte buddy upgrade for jdk14.

@raphw Is this a known issue?

@ZhangDi-d  Do you want to instrument this class(record)? How do you trigger this? Or just have this kind of class, then this log output as an warning?

It has been fixed by #5338
And, #5352 will add a test case in the plugin tests.

Sorry to reply so late. yes i just want to instrument this class(record)，the error log will be printed （
The picture is shown below）. Since  you are repairing it, I will wait for the latest version. Thanks u very much

Try the master branch, it has been fixed


[W6.4f][W11-B1]WANG ZI

@alexawangzi
Accepting this PR with just a minimal review because

nothing much to take note of here, or
another of your PRs for this tutorial was reviewed in detail


fix(android): add Referer header for url redirect load

Summary
For redirected url loading, current behehavior is we always return true to prevent it being loaded in shouldOverrideUrlLoading, with TopShouldStartLoadWithRequestEvent being sent to RN and then call webview.loadUrl() if such redirect loading was approved on RN.
However, the Referer header would be different between webview.loadUrl and return false in shouldOverrideUrlLoading. It might cause redirect issues ( #1073 ) if Referer matters at the server side.
The code change inside this PR is to save a refererUrl when sending TopShouldStartLoadWithRequestEvent to RN and use it to construct a request with Referer header later.

Test Plan

What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
test loading https://s.click.taobao.com/fj2tptv (url from #1073 )
Compatibility

OS
Implemented

Android
✅

Checklist

[x] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[ ] I mentioned this change in CHANGELOG.md
[ ] I updated the typed files (TS and Flow)
[ ] I added a sample use of the API in the example project (example/App.js)

+1

Can you fix conflicts @rocwind ? THanks!

Can you fix conflicts @rocwind ? THanks!

Sure. It's updated. Could you please help to review it? @jamonholmgren
I noticed that there were some discussions about to deal with custom headers in #460 and thought it might be able to be addressed by expose the target referer header in event for client - if client decided to handle the request on its own. However, I am not quite sure about this solution and would be glad to revert it from this PR if it doesn't look good to you.

I created this issue several days ago:
https://github.com/react-native-community/react-native-webview/issues/1434
Could it be it is related to? https://github.com/react-native-community/react-native-webview/pull/1200

I created this issue several days ago:
#1434
Could it be it is related to? #1200
@timboektoe
I think it's possible - given it is related to the redirect case on Android. Would you mind to give this PR a try to see if it addresses your problem?

Actually, we are currently using some sort of workaround at RN JS land to live without this native side code fix. It's basiclly the idea comes from https://github.com/react-native-community/react-native-webview/blob/master/docs/Guide.md#setting-custom-headers - intercepts the redirect load on Android and load it with referer header all by props:
const { uri } = props;
const refererRef = useRef(uri);
const [source, setSource] = useState({
    uri
});
const onShouldStartLoadWithRequest = useCallback((request) => {
    const { url: newURL } = request;
    setSource({
        uri: newURL,
        headers: {
            Referer: refererRef.current,
        },
    });
    refererRef.current = newURL;
    return false;
}, []);

const onShouldStartLoadWithRequestProps = Platform.OS === 'android' ? { onShouldStartLoadWithRequest } : {}

return (
    <WebView
        source={source}
        {...onShouldStartLoadWithRequestProps}
    />);

I created this issue several days ago:
#1434
Could it be it is related to? #1200
@timboektoe
I think it's possible - given it is related to the redirect case on Android. Would you mind to give this PR a try to see if it addresses your problem?

Actually, we are currently using some sort of workaround at RN JS land to live without this native side code fix. It's basiclly the idea comes from https://github.com/react-native-community/react-native-webview/blob/master/docs/Guide.md#setting-custom-headers - intercepts the redirect load on Android and load it with referer header all by props:
const { uri } = props;
const refererRef = useRef(uri);
const [source, setSource] = useState({
    uri
});
const onShouldStartLoadWithRequest = useCallback((request) => {
    const { url: newURL } = request;
    setSource({
        uri: newURL,
        headers: {
            Referer: refererRef.current,
        },
    });
    refererRef.current = newURL;
    return false;
}, []);

const onShouldStartLoadWithRequestProps = Platform.OS === 'android' ? { onShouldStartLoadWithRequest } : {}

return (
    <WebView
        source={source}
        {...onShouldStartLoadWithRequestProps}
    />);

Hi I will try out this PR to see if it fixes my problem. Unfortunately the site that exposes the problem is down due to a technical problem. Hopefully I can check it later this week.

Sorry to bother, but I checked out this PR to see if it can solve my problem, but I get stuck while testing within react-native-webview following these instructions: https://github.com/react-native-community/react-native-webview/blob/master/docs/Contributing.md
The error I get is: error ENOENT: no such file or directory, open 'undefined/src/main/AndroidManifest.xml'. (after running command yarn start:android)

We have now tested this PR in combination with issue https://github.com/react-native-community/react-native-webview/issues/1434 . Unfortunately this PR does not fix the problem. We further investigated on this and we think that the reason is that the proposed solution does not work for situations where there are multiple consecutive redirects, which is the case in issue 1434:
This is what we see when we monitor the network in the desktop browser.

request: https://mijn.uwv.nl/iam/digid, refererer: https://www.uwv.nl/particulieren/mijnuwv/index.aspx, response 302, location: https://uwvnederland.queue-it.net/
request: https://uwvnederland.queue-it.net/, refererer: https://www.uwv.nl/particulieren/mijnuwv/index.aspx, response 302, location: https://mijn.uwv.nl/iam/digid
request: https://mijn.uwv.nl/iam/digid, refererer: https://www.uwv.nl/particulieren/mijnuwv/index.aspx, response 302, location: /iam/login
request: https://mijn.uwv.nl/iam/login, refererer: https://www.uwv.nl/particulieren/mijnuwv/index.aspx, response 200,

In other words when a request is redirected multiple times, the refererer keeps the same. The implemented solution in the PR seems to always copy the current request URL in the referer header which is incorrect in case of a 302. We have tested this assumption using the javascript workaround with 'onShouldStartLoadWithRequestProps' and it works correctly in our scenario, thereby handling our redirect issue on android in a not so elegant way.

We have now tested this PR in combination with issue #1434 . Unfortunately this PR does not fix the problem. We further investigated on this and we think that the reason is that the proposed solution does not work for situations where there are multiple consecutive redirects, which is the case in issue 1434:
This is what we see when we monitor the network in the desktop browser.

request: https://mijn.uwv.nl/iam/digid, refererer: https://www.uwv.nl/particulieren/mijnuwv/index.aspx, response 302, location: https://uwvnederland.queue-it.net/
request: https://uwvnederland.queue-it.net/, refererer: https://www.uwv.nl/particulieren/mijnuwv/index.aspx, response 302, location: https://mijn.uwv.nl/iam/digid
request: https://mijn.uwv.nl/iam/digid, refererer: https://www.uwv.nl/particulieren/mijnuwv/index.aspx, response 302, location: /iam/login
request: https://mijn.uwv.nl/iam/login, refererer: https://www.uwv.nl/particulieren/mijnuwv/index.aspx, response 200,

In other words when a request is redirected multiple times, the refererer keeps the same. The implemented solution in the PR seems to always copy the current request URL in the referer header which is incorrect in case of a 302. We have tested this assumption using the javascript workaround with 'onShouldStartLoadWithRequestProps' and it works correctly in our scenario, thereby handling our redirect issue on android in a not so elegant way.

@timboektoe thank you for the testing and feedback, I didn't realize the refererer should keep the same during consecutive redirects. I guess I need to mark this PR as WIP and see if we can figure out a proper solution to this case...

It looks like I can't update this PR anymore since it's already closed.
I think I found a solution to the multiple consecutive redirects case (although it only works for Android N[7.0] or above due to the API it depends on) and opened #1525 with it.


Update dependencies for tokio 1.0

This PR updates sqelf to the stable release of tokio.

I've had to make a few tweaks to our usage of tokio-util for the current version of tokio. I suspect the UDP was always incorrect here since we did the right thing in the TCP side, but the integration tests still passed on the previous unstable version of tokio.


Initial position of VRM preview camera

Preview immediately after uploading the file.

Click to change.

Probably because the initial position of the camera has not been set.

I’m sorry...
I made a mistake in the link.
I was a beginner and was impatient. I will be careful. sorry.


Display all status options on kanban board with filters active

What would you like to be added?
On the status view, it would be nice to be able to see all the available status options (for the status type you have selected) if you filter for specific metadata.
Ex.
You can see all the status columns here with no filter - I can freely drag and drop to different areas of the kanban:

Now I filtered for a specific set of notes in the projects, all of which are in "preprod", and since none of them have a different tag, only "preprod" is shown on the kanban. If all the other status' were available, I could drag and drop to the others quickly VS changing it manually, which is what you are able to do without the feature.

Why is this needed?
Quality of life improvement more than anything. Def not high priority as if you just remove the filter, you can then drag and drop to other status columns.

This is something I also realized. Ideally I would like to create my flow on the board and see the columns even if there is no note with the status of a specific column.


Camera Module V2.1

Has anyone used this camera model for their pisight project?
I am going to start mine and I'm wondering if there is any major difference between this one and the one reported in the README

i have the 2.1 but not the noir version #16


New version noty

http://ned.im/noty/
tried to upgrade(oa theme available) but resulted in a not starting model and js errors :(
can you try it?

anyone? :)


Project name makes me sad

My mind keeps reading HTTPie as HTTP-Internet-Explorer, and this makes me feel sad.

Yeah. The original name was HTTPet (HTTP + pet), but after a couple of days I renamed it to HTTPie because I thought it was smart and didn't realize the possible confusion with something that has to do with IE.
The etymology behind the name HTTPie is the following:
a) HTTP as easy as 🍰
b) HTTP 🐍 –powered
I guess we could start calling it HTT🍰  or HTT🐍 to prevent that confusion 😉


[Refactor] Change agg intermedaite state type to varbinary

What type of PR is this：

[ ] BugFix
[ ] Feature
[ ] Enhancement
[x] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #https://github.com/StarRocks/starrocks/issues/13880

Change agg intermedaite state type to varbinary which later will be deduced as StreamMV IMTStateTable's table schema.

Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_fe_unittest

[FE PR Coverage Check]
:heart_eyes: pass : 149 / 149 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/FunctionSet.java
138
138
100.00%
[]

:large_blue_circle:
com/starrocks/catalog/Type.java
11
11
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test


Hint: user_properties branch broken

While updating gems I realised the user_properties branch is broken (the api/set_values.rb base class is missing) and I saw that the branch is merged into master. You should either fix or better delete the branch to force users onto master again.
Thanks!

Thanks for the hint. I have deleted the branch as suggested.


Cannot use LanguageTool's SRX file

I've tried on a file with bin/segment -s ~/Documents/languagetoolorg-srx.srx -i ~/Documents/example.txt -o ~/Documents/example.out.txt the output file is still what it is

thank you so much. that works


Fix possible IP comparison error

A net.IP may be represented by both by a 4 as well as a 16 byte long byte slice. Because of this, it is not safe to compare IP addresses using bytes.Equal as the same IP address using a different internal representation will produce mismatches.
Note, this PR was not initiated by my use of this package and noticing a bug, rather by creating an extension proposal for go vet and that signalling the possible misuse in this library.
Cheers :)

Thanks :)


Update index.yml

Removing the period from the Title

While it's not a complete sentence, the summary does follow the convention of ending with a period that other index.yml pages follow, so we'll close this PR as correct as is.
Thanks for contributing!


Add Affinity Group support

This creates several types to define Affinity Groups (AF).
It modifies the Topology and Machine Profile types to add AF.
It adds an affinitygroup.go file for create and delete of AF.
This modifies vm.go to set the AF on VM creation.

Note that if no AF are defined in the profile the VM creation will work.
You can pass multiple AF in the profile.
The example exo.go has also been modified to start the VM in a default egoscale AF. Which is created if it does not exist.

LGTM. Thanks!


Indexing too many document fails in one commit fails.

Context: I am adding rucene to https://github.com/tantivy-search/search-benchmark-game.
It is a search benchmarking comparing Lucene, Tantivy, Bleve and now Rucene.
Indexing works but I have to periodically commit to avoid getting a panic.
See the following two lines of code and comment.
https://github.com/tantivy-search/search-benchmark-game/blob/master/engines/rucene-0.1/src/bin/build_index.rs#L103-L104
(I suspect a u32 overflow)

FYI Here is the backtrace.
doc 2420000
doc 2430000
doc 2440000
doc 2450000
doc 2460000
doc 2470000
doc 2480000
doc 2490000
doc 2500000
doc 2510000
doc 2520000
doc 2530000
thread 'main' panicked at 'index out of bounds: the len is 65537 but the index is<PHONE_NUMBER>55776', /rustc/c8ea4ace9213ae045123fdfeb59d1ac887656d31/src/libcore/slice/mod.rs:2806:10
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/libunwind.rs:88
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:84
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:61
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1025
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1426
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:65
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:50
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:193
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:210
  10: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:471
  11: rust_begin_unwind
             at src/libstd/panicking.rs:375
  12: core::panicking::panic_fmt
             at src/libcore/panicking.rs:84
  13: core::panicking::panic_bounds_check
             at src/libcore/panicking.rs:62
  14: rucene::core::codec::postings::terms_hash_per_field::TermsHashPerFieldBase<T>::write_byte
  15: rucene::core::codec::postings::terms_hash_per_field::TermsHashPerField::add
  16: rucene::core::index::writer::doc_consumer::DocConsumer<D,C,MS,MP>::process_document
  17: rucene::core::index::writer::doc_writer::DocumentsWriter<D,C,MS,MP>::update_document
  18: build_index::main
  19: std::rt::lang_start::{{closure}}
  20: main
  21: __libc_start_main
  22: _start
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

Can you reproduce the panic with RUST_BACKTRACE=full enabled? There are multiple array accesses in TermsHashPerFieldBase::write_byte. Line number would make it easier to find out the place caused overflow. Thanks

I don't have time for this but you can reproduce on your own by running
ENGINES=rucene-0.1 make index

Sure, let me try it out

@fulmicoton, It is a  a 2GB limit with using i32.  We will fix it soon.


mm/heap: hold heap lock before access mm_nregions

Summary
to remove the race condition and rename IDX to idx
Impact
No.
Testing
CI build pass.

[Experimental Bot, please feedback here]
This Pull Request does not meet the NuttX requirements.
Here's why and how to improve it:

Summary is Insufficient:

Missing "Why":  You haven't explained why the race condition exists or why renaming IDX is necessary. What problems did these issues cause?
Missing "What" and "How": Be specific about which part of the code had the race condition and how you fixed it. Similarly, detail where IDX was used and why "idx" is a better name.
Link Issues/PRs: If applicable, provide links to related issues or pull requests in the NuttX or NuttX Apps repositories.

Impact is Too Brief: Even if there is no impact in most categories, you need to justify it. For example:

No User Impact:  "This change is internal and does not affect user-facing functionality."
No Build Impact:  "The build process remains unchanged."
Consider All Categories: Briefly address all impact categories, even if the answer is "NO."

Testing Lacks Detail:

Insufficient Host/Target Info:  Provide specific details about your build host (OS version, compiler version) and the target(s) you tested on (architecture, board, configuration).
No Test Logs:  Include relevant snippets from your testing logs before and after the change. Demonstrate that the race condition is resolved and the code functions correctly with the renamed variable.

Example of an Improved Summary:
"This PR addresses a race condition in [affected module/file] that occurred when [describe the scenario causing the race condition]. The variable IDX has been renamed to idx for consistency with NuttX coding style guidelines.  The race condition is resolved by [briefly describe your fix, e.g., using a mutex, atomic operation, etc.]. "


Optimization for V8 because we should avoid hidden classes.

Look commit below for clear understanding.
https://github.com/feross/bittorrent-swarm/commit/0981e65e151146f68b41f9c3c08177e0dc879414

Looks good to me!

2.1.2


datree: 0.15.16 -> 0.15.22

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/datreeio/datree/releases.
meta.description for datree is: "CLI tool to ensure K8s manifests and Helm charts follow best practices as well as your organization’s policies"
meta.homepage for datree is: "https://datree.io/"
meta.changelog for datree is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
Warning: no invocation of /nix/store/bfljylws4pk7wscfidngi6pf41gav1gv-datree-0.15.19/bin/datree had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 0.15.19 with grep in /nix/store/bfljylws4pk7wscfidngi6pf41gav1gv-datree-0.15.19
found 0.15.19 in filename of file in /nix/store/bfljylws4pk7wscfidngi6pf41gav1gv-datree-0.15.19

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
datree

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bfljylws4pk7wscfidngi6pf41gav1gv-datree-0.15.19 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A datree https://github.com/r-ryantm/nixpkgs/archive/cda2ab7a91f3b57b55536d41de6ba9e57637cec5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bfljylws4pk7wscfidngi6pf41gav1gv-datree-0.15.19
ls -la /nix/store/bfljylws4pk7wscfidngi6pf41gav1gv-datree-0.15.19/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

datree

Maintainer pings
cc @jceb @kalbasit for testing.

@ofborg eval


Crossmatch: all_fields option, require all fields to match

Motivation for changes:
I want it
Detailed changes:

Added all_fields option that enforces all fields to match between two entries

Looks good to me


🐛 Bug Report: Incorrect File Size Display in "Share Informations" Section

👟 Reproduction steps
1) Log in to the site (self-hosted Pingvin Share, Docker).
2) Upload a file (any file or jpg).
3) Go to the "My Shares" section.

When I view the details of the recently uploaded file in the "Share informations" section, the share appears as follows: Size: NaN undefined / 1.0 GB (NaN%)
However, the "Administration Share management" shows the correct information.
👍 Expected behavior
The file size should be displayed correctly.
👎 Actual Behavior
In the "Share informations" section, the size is displayed as: Size: NaN undefined / 1.0 GB (NaN%)
🌐 Browser
Firefox 126.0

Thanks for your report :) This is fixed and will be released in the next release.


Update VertexShader.glsl to have the correct type for material_shininess

The parameter materialShininess from Lab7 is of type unsigned int (as the shininess coefficient is normally a positive value), so the corresponding variable in VertexShader.glsl should have the same type to avoid confusion (and possibly visual glitches) when transmitting the value to the vertex shader.

@Alexander1752 Thank you for the contribution! I might be wrong, but I do have a feeling you didn't test the code before submitting the PR. There is no unsigned specifier in GLSL. The specification does have uint, but I'm not willing to change it for now - if you send a shininess value larger than $2^{31}-1$, you have far bigger issues in your code.

Actually, I tested it, then, 2 days after this PR, I re-tested it (didn't work anymore) and found out about uint and afterwards tried again with unsigned and again it worked, I'm not sure what I did wrong when loading the shader. Nevertheless, your rationale makes a lot of sense, leaving it unchanged seems the better option.


[W6.1d][T09-B2]Nelson Quek Yee Jiel

Added a boolean method isMutating() to the Command class and each relevant command class. Updated JUnit test and LogicTest to save only mutated files.

@nelsonqyj Some comments added. Please close the PR after reading comments.


Support devices with SetAddress handled in hardware (Nordic nRF52)

Nordic chips handle address setting entirely in hardware so this has to be skipped.
See https://github.com/nrf-rs/nrf-hal/pull/144 for context.

See also: https://github.com/mvirkkunen/usb-device/issues/4

See also: https://github.com/mvirkkunen/usb-device/issues/4

I implemented this function in the driver itself: https://github.com/nrf-rs/nrf-hal/pull/295/commits/1b3e38b19e035eedd05ed668ad9cb7b2833656c8.
Also I figured out that without this function USB driver works without any problems!


Allow for configureable # of messages size in SQS listener

Would be nice if there was a way to set the maximum number of messages to pull from SQS. Currently it seems like only one message can be pulled off the queue.

Hello @karthikguda you can specify the maxNumberOfMessages attribute on the container. An example in XML is <aws-messaging:annotation-driven-queue-listener max-number-of-messages="8"/>
You can provide a number between 1 and 10 (this is the maximum of SQS). If you are using Java, then have a look at https://github.com/spring-cloud/spring-cloud-aws/blob/3bede576cfd242f556c8b5f9127377fc9f63d6c7/spring-cloud-aws-integration-test/src/test/java/org/springframework/cloud/aws/messaging/JavaMessageListenerContainerAwsTest.java you can set the maximum number of messages in the SimpleMessageListenerContainerFactory class