App hangs on first request if both SSL in Kestrel and IISIntegration are enabled

If I enable both SSL in Kestrel and IISIntegration the app hangs on the first request when I run it in VS using IIS Express:
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.Logging;

using Microsoft.AspNetCore.Server.Kestrel;
using Microsoft.AspNetCore.Server.Kestrel.Core;
using Microsoft.AspNetCore.Server.Kestrel.Https;
using System.Security.Cryptography.X509Certificates;
using System.Net;

namespace mvc_individual
{
    public class Program
    {
        public static void Main(string[] args)
        {
            var host = new WebHostBuilder()
                .UseKestrel(options =>
                {
                    options.Listen(IPAddress.Loopback, 44316, listenOptions =>
                    {
                        listenOptions.UseHttps("danroth27.com", StoreName.My, StoreLocation.CurrentUser);
                    });
                })
                .UseContentRoot(Directory.GetCurrentDirectory())
                .UseIISIntegration()
                .ConfigureAppConfiguration((context, configBuilder) => {
                    configBuilder
                        .AddJsonFile("appsettings.json", optional: false, reloadOnChange: true)
                        .AddJsonFile($"appsettings.{context.HostingEnvironment.EnvironmentName}.json", optional: true);

                    if (context.HostingEnvironment.IsDevelopment())
                    {
                        // For more details on using the user secret store see https://go.microsoft.com/fwlink/?LinkID=532709
                        configBuilder.AddUserSecrets<Startup>();
                    }

                    configBuilder.AddEnvironmentVariables();
                })
                .ConfigureLogging(loggerFactory => loggerFactory
                    .AddConsole()
                    .AddDebug())
                .UseStartup<Startup>()
                .Build();

            host.Run();
        }
    }

    public static class KestrelServerOptionsHttpsX509StoreExtensions
    {
        public static ListenOptions UseHttps(
            this ListenOptions options,
            string subjectName,
            StoreName storeName,
            StoreLocation storeLocation)
        {
            var certStore = new X509Store(storeName, storeLocation);
            certStore.Open(OpenFlags.ReadOnly);
            var certificates = certStore.Certificates
                .Find(X509FindType.FindBySubjectName, subjectName, validOnly: false);

            var certificate = certificates.OfType<X509Certificate2>().First();

            return options.UseHttps(certificate);
        }
    }
}

@Tratcher

@halter73 @JunTaoLuo @natemcmaster From a quick debugging on Dan's machine, it looks like PreferHostingUrls isn't working as expected.

We have a test for it right?

https://github.com/aspnet/KestrelHttpServer/blob/566a587126a1a091f05dba2804d5baf6ecea4118/test/Microsoft.AspNetCore.Server.Kestrel.FunctionalTests/AddressRegistrationTests.cs#L258-L285

The ordering in Hosting is wrong. UseIISIntegration sets the option in ConfigureServices (or HostingStartupAssemblies), but WebHost reads the option before that. The fix is to read the option directly from config rather than via options, like we do for the urls.

@JunTaoLuo Can you file a new bug in Hosting, and add an integration test in this repo?

Closing as this was done in preview1.


Game enhancements - UI and responsiveness

What does this PR do?
Fixes #66
Screenshots(optional)
Implemented these modals on game over - both win and lose. Please check @AbhinavThukral97, the circle in behind animates.

There is inconsistency in ball size across diff plant size

making game mobile view responsive

does the pr also resolve this issue?

Modal for when the user loses the game.
I think the "You Lose" modal needs to be different. Sharing a design for reference.

does the pr also resolve this issue?

Yes @bhaskarSingh


[BUG] Error in the benchmark notebook

Description

The Benchmark notebook is not working properly
In which platform does it happen?

How do we replicate the issue?

Expected behavior (i.e. solution)

Other Comments

ALS working, however it is flacky

LightGCN error:
Size of Movielens 100k: (100000, 4)

Computing lightgcn algorithm on Movielens 100k
Already create adjacency matrix.
Already normalize adjacency matrix.
Using xavier initialization.
Epoch 1 (train)1.0s: train loss = 0.47360 = (mf)0.47336 + (embed)0.00024
Epoch 2 (train)0.8s: train loss = 0.29019 = (mf)0.28956 + (embed)0.00063
Epoch 3 (train)0.8s: train loss = 0.25493 = (mf)0.25413 + (embed)0.00079
Epoch 4 (train)0.9s: train loss = 0.23511 = (mf)0.23413 + (embed)0.00098
---------------------------------------------------------------------------
InternalError                             Traceback (most recent call last)
/anaconda/envs/reco/lib/python3.7/site-packages/tensorflow/python/client/session.py in _do_call(self, fn, *args)
   1379     try:
-> 1380       return fn(*args)
   1381     except errors.OpError as e:

/anaconda/envs/reco/lib/python3.7/site-packages/tensorflow/python/client/session.py in _run_fn(feed_dict, fetch_list, target_list, options, run_metadata)
   1363       return self._call_tf_sessionrun(options, feed_dict, fetch_list,
-> 1364                                       target_list, run_metadata)
   1365

/anaconda/envs/reco/lib/python3.7/site-packages/tensorflow/python/client/session.py in _call_tf_sessionrun(self, options, feed_dict, fetch_list, target_list, run_metadata)
   1457                                             fetch_list, target_list,
-> 1458                                             run_metadata)
   1459

InternalError: 2 root error(s) found.
  (0) INTERNAL: Failed initializing math mode
	 [[{{node MatMul}}]]
	 [[MatMul/_49]]
  (1) INTERNAL: Failed initializing math mode
	 [[{{node MatMul}}]]
0 successful operations.
0 derived errors ignored.

During handling of the above exception, another exception occurred:

InternalError                             Traceback (most recent call last)
<timed exec> in <module>

/tmp/ipykernel_24736/1119464800.py in <lambda>(params, data)
      7     "bpr": lambda params, data: train_bpr(params, data),
      8     "bivae": lambda params, data: train_bivae(params, data),
----> 9     "lightgcn": lambda params, data: train_lightgcn(params, data),
     10 }

~/notebooks/repos/recommenders/examples/06_benchmarks/benchmark_utils.py in train_lightgcn(params, data)
    347     model = LightGCN(hparams, data)
    348     with Timer() as t:
--> 349         model.fit()
    350     return model, t
    351

~/notebooks/repos/recommenders/recommenders/models/deeprec/models/graphrec/lightgcn.py in fit(self)
    251             else:
    252                 eval_start = time.time()
--> 253                 ret = self.run_eval()
    254                 eval_end = time.time()
    255                 eval_time = eval_end - eval_start

~/notebooks/repos/recommenders/recommenders/models/deeprec/models/graphrec/lightgcn.py in run_eval(self)
    295         """
    296         topk_scores = self.recommend_k_items(
--> 297             self.data.test, top_k=self.top_k, use_id=True
    298         )
    299         ret = []

~/notebooks/repos/recommenders/recommenders/models/deeprec/models/graphrec/lightgcn.py in recommend_k_items(self, test, top_k, sort_top_k, remove_seen, use_id)
    378             user_ids = np.array(test[data.col_user].unique())
    379
--> 380         test_scores = self.score(user_ids, remove_seen=remove_seen)
    381
    382         top_items, top_scores = get_top_k_scored_items(

~/notebooks/repos/recommenders/recommenders/models/deeprec/models/graphrec/lightgcn.py in score(self, user_ids, remove_seen)
    349             item_batch = range(self.data.n_items)
    350             rate_batch = self.sess.run(
--> 351                 self.batch_ratings, {self.users: user_batch, self.pos_items: item_batch}
    352             )
    353             test_scores.append(np.array(rate_batch))

/anaconda/envs/reco/lib/python3.7/site-packages/tensorflow/python/client/session.py in run(self, fetches, feed_dict, options, run_metadata)
    969     try:
    970       result = self._run(None, fetches, feed_dict, options_ptr,
--> 971                          run_metadata_ptr)
    972       if run_metadata:
    973         proto_data = tf_session.TF_GetBuffer(run_metadata_ptr)

/anaconda/envs/reco/lib/python3.7/site-packages/tensorflow/python/client/session.py in _run(self, handle, fetches, feed_dict, options, run_metadata)
   1192     if final_fetches or final_targets or (handle and feed_dict_tensor):
   1193       results = self._do_run(handle, final_targets, final_fetches,
-> 1194                              feed_dict_tensor, options, run_metadata)
   1195     else:
   1196       results = []

/anaconda/envs/reco/lib/python3.7/site-packages/tensorflow/python/client/session.py in _do_run(self, handle, target_list, fetch_list, feed_dict, options, run_metadata)
   1372     if handle is None:
   1373       return self._do_call(_run_fn, feeds, fetches, targets, options,
-> 1374                            run_metadata)
   1375     else:
   1376       return self._do_call(_prun_fn, handle, feeds, fetches)

/anaconda/envs/reco/lib/python3.7/site-packages/tensorflow/python/client/session.py in _do_call(self, fn, *args)
   1397                     '\nsession_config.graph_options.rewrite_options.'
   1398                     'disable_meta_optimizer = True')
-> 1399       raise type(e)(node_def, op, message)  # pylint: disable=no-value-for-parameter
   1400
   1401   def _extend_graph(self):

InternalError: 2 root error(s) found.
  (0) INTERNAL: Failed initializing math mode
	 [[node MatMul
 (defined at /home/hoaphumanoid/notebooks/repos/recommenders/recommenders/models/deeprec/models/graphrec/lightgcn.py:102)
]]
	 [[MatMul/_49]]
  (1) INTERNAL: Failed initializing math mode
	 [[node MatMul
 (defined at /home/hoaphumanoid/notebooks/repos/recommenders/recommenders/models/deeprec/models/graphrec/lightgcn.py:102)
]]
0 successful operations.
0 derived errors ignored.

Errors may have originated from an input operation.
Input Source operations connected to node MatMul:
In[0] embedding_lookup/Identity (defined at /home/hoaphumanoid/notebooks/repos/recommenders/recommenders/models/deeprec/models/graphrec/lightgcn.py:80)
In[1] embedding_lookup_1/Identity (defined at /home/hoaphumanoid/notebooks/repos/recommenders/recommenders/models/deeprec/models/graphrec/lightgcn.py:83)

The error comes because we are importing torch and that somehow conflicts with TF o_o
This is interesting


[web]: TextField unable to write text

Flutter_web,I'm trying to write some text in TextField but unable to write

I'm facing the same issue.

Please include the output of flutter doctor -v.

@jonahwilliams please check the attachment

This issue has already been fixed, but It looks like you're using the forked flutter_web. This library is no longer being updated as we've completed the unfork into upstream flutter.
For more information see https://flutter.dev/web


NavBar Icons

Resolve the following;

Fix the spacing between the NavBar Icons (LinkedIn, Github, and Email)
Added Dockerhub to NavBar


Add config file infra for CLI and testing

This PR adds a super basic toml-based config file API for use in the CLI and tests.

FYI I tested this only on tests/test_models.py.
Once all the code has been refactored and duplicate/dead code removed, we need to open another PR to actually address #11.

@abuishgair There was a mistake in the README. Please let me know if you can build the project now.


MobileAnalytics file name error on pausing session in UWP

I am trying to use the Mobile Analytics SDK on Windows 10 Universal App
I am using  AWSSDK.MobileAnaytics sdk version <IP_ADDRESS>
When I call analyticsManager.PauseSession() it throws the following error.
The filename, directory name, or volume label syntax is incorrect. (Exception from HRESULT: 0x8007007B)
I haven't set any specific path and I would have expected the library to resolve the path on its own. Has anyone else faced this issue? Is there any workaround for this?

After trying to debug the source code locally, I was able to find that when the _sessionStorageFileFullPath field is set in the constructor of Amazon.MobileAnalytics.MobileAnalyticsManager.Internal.Session, the full system path was being included. This path is then used in the SaveSessionStorage method. The method FileSystem.Current.LocalStorage.CreateFileAsync takes file name as parameter but the full file path was being set, which led to the above exception.
So changing the below line in the Session constructor fixed the error for UWP.
Original line:
_sessionStorageFileFullPath = System.IO.Path.Combine(PCLStorage.FileSystem.Current.LocalStorage.Path, appID + _sessionStorageFileName);
Modified line:
_sessionStorageFileFullPath = appID + _sessionStorageFileName;
Kindly release a nugget update with the necessary changes.

We have noticed that the SDK does not populate correct values for:
device_model
device_make
device_platform_name
device_platform_version
device_locale_language
device_locale_country
on Windows 10. The APIs changed between 8.1 and 10, and this may be the reason why incorrect values are populated here. This implementation seems to be a part of AWS SDK which we cannot change. Can this also be looked into as part of the above bug resolution.
Thanks.

@ferdinraphael  I think your proposal makes sense.   We'll have the change out soon.
@VineetALT, could you create a separate issue for this?  Also, I do not follow what you mean SDK does not populate those values on windows 10.  Are you talking about redshift schema?  Could you be more specific about what you mean by "correct values" and "implementation" mentioned in your comment?

@sstevenkang All of those are global attributes which are populated as part of client_context in the Mobile Analytics SDK. Windows 10 introduced new APIs for accessing these values on devices. When we integrate the current SDK, the values are reported as "Unknown" or not reported at all.

Hi, sorry for the radio silence.  From what I can recall, the proposed fix raises a runtime error in Xamarin.iOS.  This is because of the downstream dependency we have on PCLStorage where the behavior of the API changes based on the platform.  We are still looking into other options to address this problem.
Regarding the device properties, we never populated those properties for Windows platform.  We'll add this work to our backlog.

Closing due to inactivity.  Please do respond to this issue again if you have a working repro.


No equivalent to autocomplete.auto_show in reworked config

Make sure you have done the following

[X] I have updated to the latest version of blink.cmp
[X] I have read the README

Bug Description
With the reworked config it is no longer possible to disable automatically triggering the completion. I only want to trigger the completion with the key mapping on demand, not having it constantly pop up.
Before the rework, this was achieved by setting autcomplete.auto_show = false, but I have not found anything that could do the same in the new config.
Relevant configuration
-- Config prior to rework
windows = {
  autocomplete = {
    auto_show = false,
  },
}

neovim version
NVIM v0.10.2
blink.cmp version: branch, tag, or commit
main

Setting both show_on_keyword = false and show_on_trigger_character = false should effectively be equivalent to auto_show. The only caveat is completions will no longer be prefetched so there will be a delay on opening

Thanks, that works great.
Prefetching would certainly be nice to have as well. I'd personally want the ghost_text to be tied to the menu, meaning that the prefetching should be completely in the background without having activated anything. But I guess you mean that both menu and ghost_text support the auto_show configuration independently.
I'm sure you will find an appropriate solution, just to give you my use case, as that seems to be the minority: I want everything to be hidden while prefetching happens in the background, then press the key map to show everything (menu + ghost_text + documentation).
This is exactly what I have got with the current config (without having the prefetching, as you mentioned).
That being said, I definitely see the appeal to have ghost_text alone, which would allow you to accept the first suggestion without opening the menu or open the menu to select another candidate. Now that I have written this out, I actually think that I might be using this, if it were implemented.

I just realised that with these new settings it is impossible to narrow down the results once the completion is triggered, as it immediately closes the menu when typing any character.
Expected Behaviour

Trigger completion with key mapping
Type to fuzzy match completion results (keeps menu open)
Accept / Cancel / Hide to finish completion, which hides the menu

Essentially, from the time of triggering the completion with the key mapping it should temporarily behave as show_on_keyword = true until the menu is closed by one of the actions, or the keyword has been finished (e.g. when opening a parenthesis).
That is also how it functioned previously.


[FIX] find_outlier_trials()

There is a bug find_outlier_trials compatible when a list of thresholds is passed.

thanks @croyen


Controllable graph physics

Users should be able to define how they'd like their graph to look (changing the graph's physical properties). Here's an example

The UI fails to meet our Accessibility policy. It is unmaintainable and will be removed shortly.


command line authorize

Is it possible to authorize this in command line only no (gui browser) as i am using it on server which has no gui installed.

Hey @hjyoung1 yes you can do.
Use drive login --remote this will give another link which you can open on other device so the login procedure and give the authorization pin back to the server.

My bad i was using pip version which didn't have -- remote option
Now using development build it's working now thanks.


Fix start of osrm-contract

osrm-contract expect the file prefix when starting. I don't know how the previous command worked

Really? Here's the output of osrm-contract --help:
$ osrm-contract --help
Usage: osrm-contract <input.osrm> [options]:
[...]
$ osrm-contract --version
v5.27.1

Yep, that's wrong

What's wrong? the osrm-contract help? If so, since when? Was there a recent change? Would this fix fail on some versions?
It works here because the file is called ${mode}.osrm after extract, so by setting [mode] for <input.osrm> it looks for <mode>.osrm?

So I don't have a file $mode.osrm anymore here. Might be a new version thing.
I guess we should test with older version of osrm.
I based this on the output of osrm-extract which said:
"To prepare the data for routing, run: ./osrm-contract "/app/examples/runtime/osrm/walking/walking""
Need to go check the code histoire in osrm

So checking the behavior of the osrm code:
It takes the parameter and first strip out any known extention before using it as a base path
So basically,   mode.osrm is the same as mode or mode.osm
It does not check that the specific file actually exist, but the rebuild the path to require file base in this base path.
We can still investigate why we do not have an "mode".osrm file generated anymore.
Otherwise, we can keep the diff as is, or we can make it so the cmd is with "$mode.osrm" instead of just "$mode".

commit 21888334dd1e0fbbd25cc62c725eb33bb7968147
Author: Siarhei Fedartsou<EMAIL_ADDRESS>Date:   Fri Sep 30 14:29:10 2022 +0200
Do not generate intermediate .osrm file in osrm-extract. (#6354)

https://github.com/Project-OSRM/osrm-backend/pull/6354

it's super confusing and documentation is not well updated yet.
So I'll change this PR to be mode.osrm

With version 5.25, both the current and preceding version work. With 5.27, the contraction works, but the runtime doesn't. Don't you need to update also the osrm-routed path in the OSRMProcessManager.ts file?

hum, probably yes

updated, @tahini if you have the chance to test on your side, let me know

I've made sure to erase the old .osrm in my latest test round.

Fixed my yarn format command, so should be good


why the last chunk might be larger than descriptor.size?

i don't know why the last chunk might be larger than descriptor.size.
I saw the annotation saying "It is for reading old files".So there is no problem with the new file，isn't there?
by the way ,How to distinguish old and new files.

Reporter: Zhenglin luo
Note: This issue was originally created as PARQUET-1836. Please see the migration documentation for further details.

Xinli Shang / @shangxinli:
I just searched the change history and see the fix comes from this change https://github.com/apache/parquet-mr/commit/b297c73c1082728ad9626d17ce0f7abe6abaa36b which is in parquet-1.8.0rc1. That means the files written by version 1.7 and below could be considered as 'old files'.

Zhenglin luo:
Oh, I see, thank you very much


Multiple storageproviders

Is your feature request related to a problem? Please describe.
Different situations require different storages. We should have a simple way to add storage and machines.
Describe the solution you'd like
As discussed in #138 we need to make it easy to add machines and storages. We actually do not really care about the machines right now as we only know them through the configs in the storages. So let us see how we can add storages before we make it easy to bring your own machine. The storage requires:

[ ] To make it possible to register several storages.
[ ] There is a possibility for people to add their own storage.
[ ] That they cannot access other storages.
[x] #152

Describe alternatives you've considered

We could have also decided to work with a single storage provider. However, this is unlikely to work out too nicely and be flexible enough.

The system starts to work quite reasonably. However, a few major problems remain for later:

Right now the storage gets added through the admin interface. This is clumsy and will need better tooltips.
Adding a storageprovider should be possible for anyone that is a registered user.
More important is however, that we are currently not saving the login as hashed field. We should have a look how this can be done...

We further have to fix the devices view in the frontend as it is not working right now.


Resolve Footer and card is overlapping problem and card responsive ness

Fixes #139

https://github.com/ShwetKhatri2001/AR-Webstore/assets/103810119/50c95428-a6aa-4f14-8cf7-ce3576f70edf
Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[x] All new and existing tests passed.

LGTM 🙌
Although there is a scope for improvement. You can see the top part of the page is getting cut when you go from a larger viewport to a smaller viewport device. But it's improved and better than I expected.
This PR can get Level-2 now.
Congrats on your first PR getting merged on AR-Webstore @Prajwal0225 🚀 Keep Contributing 👍


Remove cell table batching functionality

What is the purpose of this PR?
Addresses stage 1 of #720, removing batching of generate_cell_table.
How did you implement your changes
The batch loop inside generate_cell_table has been changed to a per-FOV iteration.
The call in 1_Segment_Image_Data.ipynb needed to be updated accordingly.
Remaining issues
In particular, changes were made to the way fovs and filenames were being handled in generate_cell_table. MIBItiff support requires us to retrieve filenames, however for non-MIBItiffs the loop needs to be more fully guarded against filenames being set to None (which happens when you call list_files on a folder structure).
We will not have to worry about this once MIBItiff support gets phased out.

@benoberlton this PR should address the error caused by variable image sizes you were getting during generate_cell_table. Let me know if any issues pop up.

@ngreenwald realized I needed to update the documentation for create_marker_count_matrices to indicate that the FOV dimensions should support just a single FOV, however seems I can't push the change until you review the rest of the changes (even if I remove the review request). If all looks good I'll push that change separately.

Looks good, just need to add back in the code that was removed. Seems like this has happened a bunch of times on your PRs, I think you said your editor does it automatically?

@ngreenwald yeah, looks like I'll need to officially need to retire my merge tool lol, Sublime Merge hasn't been the easiest to interface with.

@ngreenwald this should resolve generate_cell_table with main.


CI/CD talk at DevFest Mumbai 2022

Date: 5th Dec 2022
Event: DevFest
City: Mumbai
Name: Darshit Suratwala
LinkedIn: https://linkedin.com/in/dsdatsme
Topic: Infrastructure CI/CD using Open Source Tools
Description: Automate infrastructure provisioning using GitHub & Terraform
Presentation: https://docs.google.com/presentation/d/1dABxd4OGN97OPF3ITXKi4Q7QBtHNvbOA/edit?usp=sharing&ouid=112251394912774954952&rtpof=true&sd=true
Blog: https://medium.com/@dsdatsme/terraform-gitops-ci-cd-with-approval-notifications-6f0807299fc4
Repo: https://github.com/DSdatsme/gh-terraform

Thank you.


WFLY-18066 ByteBufferMarshalledValue generates duplicate buffers during a single marshalling operation

https://issues.redhat.com/browse/WFLY-18066

Added hold label while I finish the unit test.

Thanks @pferraro


Speed of :GSO

:GSO feels a little slow to me, I would like to be faster. This is probably something that I could spend forever improving, but there is probably a couple of tricks I can do to halve the time of a command call.
Here are the times (using timeit) for different commands. I write time units because these look too large to be seconds.

import gso: 0.4 time units
load_up_questions: 3.2 time units
load_up_answers: 6.2 time units

The SE API wrapper looks to be doing some caching on second calls.
The sub-function called by load_up_questions:

search_google: 2.7 time units

So it looks like the Google search is doing an okay job, but the answer-loading is slow.

Downloading the html of an SO answer with a simple urllib2 call takes about 4.7 time units.

Also note that the load_up_answers command only loads a single answer for that call above.

Yep, the SE API and python wrapper (or my usage of) is slow. 33 time units for requesting all the answers. It's probably faster to scrape the HTML and parse with lxml.
I'll probably post an issue on the API page, but go to basic scraping for now.
The Google API seems fast. I will leave that for now.

The SE API itself (not the wrapper) should be faster, because I should be able to just give it a list of question IDs, and it can give me all the answers, using this: https://api.stackexchange.com/docs/answers-on-questions. It can even pre-sort for me.
I suppose I can just look at the functionality in the py-stackexchange API, and try to change up the filters to give me this.

So on here: https://github.com/MilesCranmer/Py-StackExchange, I can try to hard-code the filter

Actually, GSO is wayyyyy faster than I realized. It's this Australian internet connection I was running off of. Switched to an AWS node in North Virginia and it feels pretty quick now.

Closing for now...


[RFC][TVMScript] New namespace for tvmscript

It's a rfc for changing TVMScript namespace to enable auto-completion support and pass pylint checks.

I support this change. One suggestion is that we keep a canonical namespace that will always be parsed correctly to the TIR namespace (e.g. tir.block will always work), and in particular use this identifier during printing. Mentioning this here since I noticed the PR apache/tvm#9115 is printing using the T alias, which seems problematic unless we print an import statement at the top.

Great discussions. If we are encouraging a common idiom(e.g. use T for tir).
We might actually want to encourage print in T as prefix to be consistent on what users might write(and further edit with auto-completion), assuming we always encourage user write from tvm.script import tir as T. As long as we agree to that convention. Having a prefix option indeed makes the choice flexible.

Thanks guys for the discussion! If the comments and concerns are all addressed, let's move on and merge this PR after 24h

Thanks guys for the discussion! The RFC is merged :-)


Is it possible to use other transports?

Hi friends,
For now OpenSplice supports UDP/TCP, is it possible to modify the source to support other transports? Are there any suggestions about how to do it?
Thanks

Dear Aoh Wang,
Thank you for your queries.
Our Vortex Opensplice DDS is compliant with OMG DDS specification and our implementation is  based on that only (with some extra features on top of specification).   Regarding your query about modification of the source to support other transports, I don't think we have any plan for this.
You can try our Eclipse Cyclon DDS. In Future, Some more transport protocols may be supported in it.
We are keen to understand which transport protocol you are interested in to help studying the feasibility.
With best regards,
Vivek Pandey
Solution Architect
ADLINK Technology

Hi vivekpandey02, thanks for your advices and I am sorry for the late reply. We are interested in making OpenSplice DDS to work with transports like RapidIO.


add example for persistence to DB

LangGraph has persistence. It persists state across all nodes and edges throughout the workflow. However, it has another subtle aspect that can persist it on disk / in DB so that when the application restarts (say after a crash or regular shutdown/maintenance) it can pick up where it left off. We will look at how it works in this example.

Did a YouTube video detailing this: https://youtu.be/GqKUmrd5FEk

Hi @sameermahajan - thanks for making the video and opening the PR! Excited to hear you trying LangGraph out.
As far as I can tell, it seems like the provided notebook re-articulates ideas already well represented in our documentation, so I don't think we'll land this PR (since we would then become responsible for maintaining it) - you can feel free to put it in a separate repo, however!


Release 0.8.10

Coverage remained the same at 79.986% when pulling 9a7647f26884fc250bfb116c97ab7b102b57fa07 on Thib17:master into be8c951bdd2bc5280df8ebcef67cd7881e595096 on criteo:master.


URLs beginning with "public" can 404 in sites rewriting to public/

Reporting an issue someone on Slack uncovered
Affected Version
4.5.x
Steps to Reproduce

Document root must be set to site-root/, not site-root/public/, so the root .htaccess is executed
SS_BASE_URL must not be set in .env

Create a page in the site root with a URL segment beginning public (e.g. publications). Visiting the page will 404, but visiting mysite.com/public/publications/ will work.
Cause
Something in this code, as setting SS_BASE_URL fixes the problem: https://github.com/silverstripe/silverstripe-framework/blob/3ad4b93daacf3dc3d76a3da6c0287827604a631a/src/includes/constants.php#L120-L159
Solutions
Best -> worst:

Set the document root to site-root/public/
Define an SS_BASE_URL in .env
We fix the bug (which is why I created this ticket) :D

Did some local testing and can confirm this issue.
When a top-level page with slug publications exists, the 404 is returned because the URL is rewritten to public/ations. If a page ations also exists, that one is served instead.

Fixed in #9460.


refactor: Adds request types as Classes

I made a few changes to hopefully eliminate some boilerplate / potential spots for errors in authoring:
import { Request, Response } from "express";
import { Post } from "firebase-backend";

export default new Post((req: Request, res: Response) => {
...
});

Now when authoring a restful endpoint:

You can just use Post, 'Get, etc... instead of Endpoint([name],RequestType[TYPE],...)`
You don't need to specify the name - that comes from the filename itself

I also did a little cleanup in the logs and function structure.

Btw, this is kind of a proposal - feel free to reject if it isn't the way you intended this to be used.

Oh, and also I forgot - now in the Reactive Functions, you can just export the default function like so:
import * as functions from "firebase-functions";

export default functions.firestore
  .document("users/{userId}")
  .onCreate((usersSnapshot, context) => {...});

Thanks everyone! I really appreciate all the interaction and involvement. I'll review and merge this in soon. Will get back to open source work soon.
I really appreciate the help with the PR's!

@Runner-dev , yeah I removed the express middleware that is now deprecated, yep.

@adamschnaare Did you test this locally? I'm struggling to get it working using npm run link and doing a link in the boxtout project.
Can you see without changing anything if it'll work in this project. You can clone and test the latest code on the project in src/backend/functions

I want to confirm this works as well as push proper readme with the update. I'll start with the readme now. You've already done a lot @adamschnaare , if you can confirm boxtout project runs fine with this update then I'll push this out.

@FilledStacks I did test it locally. I also had issues using npm link. Typescript was not able to compile. I think it may be a conflicting .tsconfig setting or something. I got it to work by cloning the repo right into the functions/node_modules directory. Kinda hacky, but we shouldn't need to mess with this module too often.
I tested the code in the boxtout example and it is working as is and if using the newer abstractions of Post, Get, etc...

great @adamschnaare I will complete the readme and then push that up probably tomorrow. Work is a bit hectic the past few days.


PDF with Unicode Chars

When PDF is exported, Unicode chars are not displaying properly.

You should search wkhtmltopdf issues about it.


add KeyCharacterMap.UnavailableException

add KeyCharacterMap.UnavailableException in charMap

Hi,
Thank you for your contribution.
However, could you explain what problem it solves, please? Do you have a device where there is no VIRTUAL_KEYBOARD KeyCharacterMap?
If that's the case, it will still fails on every call to injectChars(), won't it?

problem in Android Q  pixel

problem in Android Q pixel

But then, every injectChars() will fail, right?

problem in Android Q pixel

But then, every injectChars() will fail, right?

problem in Android Q pixel

But then, every injectChars() will fail, right?

all exception  ~

In seems everything works fine on Android Q for injecting characters.


Question about radiusType parameter in dot representation

This question relates with typescript conversion
https://github.com/arose/ngl/blob/2d84a993507fd59bf1d3041c851e8bd93b5db99b/src/representation/dot-representation.js#L297
radiusType is supposed to be a string amongst value, abs-value, value-min, deviation, size
In the linked lines of code, if radiusType is not 'radius' (which is not one of the aforementioned values) then radius which is an integer should take radiusType value?!
What is the desired behaviour here?

Not a very clear type but radius can be either one of the string values of a number. It is eventually used here https://github.com/arose/ngl/blob/master/src/surface/volume.js#L381.


Uc gate

Summary
This PR fixes the UCGate global phase and replaces PR #6226

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 25 (84.0%)  changed or added relevant lines in 2 files are covered.
10 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.01%) to 83.938%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

qiskit/extensions/quantum_initializer/isometry.py
18
22
81.82%

Files with Coverage Reduction
New Missed Lines
%

qiskit/quantum_info/synthesis/one_qubit_decompose.py
2
97.61%

qiskit/extensions/quantum_initializer/squ.py
8
80.9%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
55748

Relevant Lines:
66416

💛  - Coveralls


Pinterest is not getting count

Even on your demos

Looks like the demo was out of sync. Make sure line https://github.com/cshold/social-sharing-buttons/blob/master/social-buttons.js#L54 says data.count rather than pinShares.

Thanks- already got mine working- an see the demo does now as well
Appreciate your work!

On Feb 25, 2015, at 3:37 PM, Carson Shold<EMAIL_ADDRESS>wrote:
Looks like the demo was out of sync. Make sure line https://github.com/cshold/social-sharing-buttons/blob/master/social-buttons.js#L54 https://github.com/cshold/social-sharing-buttons/blob/master/social-buttons.js#L54 says data.count rather than pinShares.
—
Reply to this email directly or view it on GitHub https://github.com/cshold/social-sharing-buttons/issues/6#issuecomment-76050882.


[AutoPR web/resource-manager] Adding Detector Endpoints for Web Apps and App Service Environments

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/2764

This PR has been merged into https://github.com/Azure/azure-sdk-for-go/pull/1624


#483 add section for feature switches

Added Feature Switches Section in Admin panel
Added Feature Switches Section in the Admin panel with functionality to delete edit state of switch and add new switches.
resolves #483

Page bugs showing this

Page bugs showing this

I will look into it

Error messages do not alert the user of what the actual cause of failure is besides mentioning improper payload (and that's if one knows what 400 status code means)
Feature switches are always capitalized which might confuse developers when setting up new ones and referencing them in their components


"The byref-typed variable 't' is used in an invalid way" when accessing a field from a closure inside of a member

Noticed this when I was messing around, and it appears to be the same in 2013 as 2015, but I figured this is an odd edge case in the spirit of the new mutable work and so should report it:
type [<Struct>] Matrix =
    val array : float [,]
    new (arr: float [,]) = { array = arr }
    member t.ToVector () =
        if Array2D.length1 t.array = 1 then Array.init (Array2D.length2 t.array) (fun j -> t.array.[0,j])
        elif Array2D.length2 t.array = 1 then Array.init (Array2D.length1 t.array) (fun i -> t.array.[i,0])
        else failwith "Cannot convert a multidimensional matrix to a Vector"

simple workaround seems to be to add a let t = t at the top of the function, but that seems kind of ugly.
type [<Struct>] Matrix =
    val array : float [,]
    new (arr: float [,]) = { array = arr }
    member t.ToVector () =
        let t = t
        if Array2D.length1 t.array = 1 then Array.init (Array2D.length2 t.array) (fun j -> t.array.[0,j])
        elif Array2D.length2 t.array = 1 then Array.init (Array2D.length1 t.array) (fun i -> t.array.[i,0])
        else failwith "Cannot convert a multidimensional matrix to a Vector"

Hi @Rickasaurus - Could you put this on http://fslang.uservoice.com please?  It's a valuable suggestion we may want to action in a future language version.
(Right now the behaviour is as expected - inside the closure "t" can't be mutated in the way that would be expected if it was a fully valid byref value)

(Closing this as it's been redirected to http://fslang.uservoice.com)


Posterior function return types

The second method of the model posterior function should have the signature
post(X::AbstractMatrix{<:Real}) -> ::Tuple{<:AbstractMatrix{<:Real}, <:AbstractArray{<:Real, 3}}

However, given a matrix containing a single column (single evaluation point), the posterior of the GP model returns ::Tuple{<:AbstractMatrix{<:Real}, <:AbstractMatrix{<:Real}}, as the reduction is never called.
In my opinion, this correct add/fix the reduce_first method for AbstractArray{Any, 3}, so that the behavior would be consistent with reduction over vectors and matrices. (Where the reduction returns the same type even for a single-element reduction.)
So maybe create an issue for julia?

Resolved by https://github.com/soldasim/BOSS.jl/commit/1ba7714ba8a1f8b9ada1c43fcba93f39dcdc1b13


[v1.1.0-rc.0] Japanese documents cannot be searched properly with Kanji-only documents

Describe the bug
I was testing the search by adding Japanese documents, but when I added a Kanji-only document, past Japanese documents were no longer caught in the search.
To Reproduce
summary

add documents [{id: 1, name: "東京スカパラダイスオーケストラ"}] -> search with 東京 : expected
add documents [{id: 2, name: "東京バナナ"}, {id:3, name: "東京 ポテチ"}] -> search with 東京 : expected
add documents [{id: 4, name: "東京特許許可局"}] -> search with 東京 : not expected

launch
docker run --rm -p 7700:7700 -e MEILI_MASTER_KEY=foobar getmeili/meilisearch:v1.1.0-rc.0

processing
# create an index
curl -H "Authorization: Bearer foobar" -H "Content-Type: application/json" -X POST localhost:7700/indexes -d '{"uid":"hogehoge","primaryKey":"id"}'

# add a Japanese document
curl -H "Authorization: Bearer foobar" -H "Content-Type: application/json" -X POST localhost:7700/indexes/hogehoge/documents -d '{"id":1,"name":"東京スカパラダイスオーケストラ"}'

# search and hit 1 document ( correct )
curl -H "Authorization: Bearer foobar" -H "Content-Type: application/json" -X POST localhost:7700/indexes/hogehoge/search -d '{"q":"東京"}'

{"hits":[{"id":1,"name":"東京スカパラダイスオーケストラ"}],"query":"東京","processingTimeMs":0,"limit":20,"offset":0,"estimatedTotalHits":1}

# add more documents
curl -H "Authorization: Bearer foobar" -H "Content-Type: application/json" -X POST localhost:7700/indexes/hogehoge/documents -d '{"id":2,"name":"東京バナナ"}'
curl -H "Authorization: Bearer foobar" -H "Content-Type: application/json" -X POST localhost:7700/indexes/hogehoge/documents -d '{"id":3,"name":"東京 ポテチ"}'

# search and hit 3 documents ( correct )
curl -H "Authorization: Bearer foobar" -H "Content-Type: application/json" -X POST localhost:7700/indexes/hogehoge/search -d '{"q":"東京"}'

{"hits":[{"id":1,"name":"東京スカパラダイスオーケストラ"},{"id":2,"name":"東京バナナ"},{"id":3,"name":"東京 ポテチ"}],"query":"東京","processingTimeMs":0,"limit":20,"offset":0,"estimatedTotalHits":3}

# add a Kanji only document
curl -H "Authorization: Bearer foobar" -H "Content-Type: application/json" -X POST localhost:7700/indexes/hogehoge/documents -d '{"id":4,"name":"東京特許許可局"}'

# search and hit only last document ( not expected )
curl -H "Authorization: Bearer foobar" -H "Content-Type: application/json" -X POST localhost:7700/indexes/hogehoge/search -d '{"q":"東京"}'

{"hits":[{"id":4,"name":"東京特許許可局"}],"query":"東京","processingTimeMs":0,"limit":20,"offset":0,"estimatedTotalHits":1}

# add a document again
curl -H "Authorization: Bearer foobar" -H "Content-Type: application/json" -X POST localhost:7700/indexes/hogehoge/documents -d '{"id":5,"name":"東京スカイツリー"}'

# search but hit only 1 document ( not expected )
curl -H "Authorization: Bearer foobar" -H "Content-Type: application/json" -X POST localhost:7700/indexes/hogehoge/search -d '{"q":"東京"}'

{"hits":[{"id":4,"name":"東京特許許可局"}],"query":"東京","processingTimeMs":0,"limit":20,"offset":0,"estimatedTotalHits":1}

Expected behavior
I expected all documents could searched by  東京
Meilisearch version: v1.1.0-rc.0
Additional context
Ref #2403 #3347

Hello @miiton, thank you for having tried this release candidate.
Your case is a hard one, I have a fix in mind but it's a partial one:
the documents that were searchable will continue being searchable, however, I have an issue to make '{"id":4,"name":"東京特許許可局"}'  searchable 😬
I will investigate!

Hello @miiton,
I've tried to enhance the Language detection for Japanese support, I released a prototype on Docker that you can already try:
https://hub.docker.com/layers/getmeili/meilisearch/prototype-better-language-detection-0/images/sha256-a12847de00e21a71ab797879fd09777dadcb0881f65b5f810e7d1ed434d116ef?context=explore
However, this prototype partially fixes the issue, see below the PR explaining the limits of this enhancement:
https://hub.docker.com/layers/getmeili/meilisearch/prototype-better-language-detection-0/images/sha256-a12847de00e21a71ab797879fd09777dadcb0881f65b5f810e7d1ed434d116ef?context=explore
Please share and try this prototype and make me some feedback!
Thanks!

You're so fast!
As you wrote in your PR, adding "Japanese sentences(= includes Hiragana or Katakana)" to the desc gave me the results I was expecting. So I understood that one of the key points of DB creation is that creating a DB with only words will not give the expected results.

BEFORE
AFTER

Fixed by https://github.com/meilisearch/meilisearch/pull/3569
Will be released in rc1 today

I tried to test a bit more.
It seems that the search function works well if there are many "amounts of text" in the document due to the changes merged into v1.1.0-rc1, but it doesn't work well when there are few.
When searching for 東京 after importing data_with_shortdesc.csv , only "Kanji-only words" are hit.
When searching for 東京 after importing data_with_longdesc.csv , I get roughly the desired results (I don't understand why only テレビ東京 doesn't hit).
Import command:
curl -X POST localhost:7700/indexes/:index_uid/documents --data-binary @data_with_shortdesc.csv
curl -X POST localhost:7700/indexes/:index_uid/documents --data-binary @data_with_longdesc.csv

At any rate, if I want to search in Japanese for sure, I need to put a long dummy Japanese string in each document, like data_with_longdesc.csv, otherwise it will not work well and I waste DB space in that case.
I think it would be easier to solve this problem if we could enhance the test cases in Japanese. Is there anything I can do to help?
data_with_shortdesc.csv
data_with_longdesc.csv


Do not state the obvious

Description

FIXES:
Type of change
What is it?

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update
[ ] Refactor

I'm testing Konflux on this xD I was thinking hard what change to introduce xD

/retest

/retest


Fixed merge conflict creating duplicated scan result

Description
Fixed merge conflict creating duplicated scan result
Related Issue

Type of Change

[x] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[ ] 🥂 Improvement (non-breaking change which improves an existing feature)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

This is not preventing from having two LLM scan page in the search results


tex-fmt: 0.4.7 -> 0.5.1

This PR adds support for man pages and shell completion, as well as a package version update.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Now that tex-fmt 0.5.1 is out, I am updating this PR accordingly.


getlist should be wantlist in documentation

Your documentation has wantlist in once place and getlist another. wantlist works and getlist does not.
I think that
words = p.number_to_words(1234, getlist=True)

should be
words = p.number_to_words(1234, wantlist=True)

Thanks, please see PR https://github.com/jazzband/inflect/pull/84.


Append

btw @mfeingold may I ask you why you always submit a PR that you accept yourself ? isn't it a bit overwork ?

Because I am paranoid :). This is my way to double ensure that nothing half baked makes it through to the master. And sometimes I do risk checking it in directly to the master - i.e with doc edits.


Rescue from html responses to prevent parse errors

From time to time I get this error in production:
JSON::ParserError: 784: unexpected token at 'Http/1.1 Service Unavailable '
Apparently sometimes apple response for receipt verification is not json which causes this error. It would be great if we could handle such error somehow even if it's quite rare.

@SumLare Thank you!


Wrong data

The data in confirmed and active column are same, please fix it. In column confirmed its should be sum of active+recovered+Deceased. Refer the screenshot.

Being addressed in this PR. #140

Fixed! Thanks!


[UX] Fix navigation menu icon

Fixes #835

Before
After

@gino-m  PTAL?

Great idea! Checks seem to be failing, otherwise LGTM.

I wish there were a way to auto-trigger code checks on git push ✨

The gradle crashed while building the apk. Re-running the remote build.

Failed again, trying one more time.

PTAL


Nuget install isn't working

Hi,
I am trying to both upgrade and clean install these packages via Nuget and it is not working:
Severity	Code	Description	Project	File	Line	Suppression State
Error		Exception 'System.AggregateException' thrown when trying to add source 'https://www.myget.org/F/aspnet-contrib/api/v3/index.json'. Please verify all your online package sources are available.
One or more errors occurred.
Unable to load the service index for source https://www.myget.org/F/aspnet-contrib/api/v3/index.json.
An error occurred while sending the request.
Unable to connect to the remote server
A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond <IP_ADDRESS>:443
I am having no issues with other packages over the same route
Thanks
Mark

Hi @MCFHTAGENTS, our nightlies are available on https://www.myget.org/F/azureadwebstacknightly/api/v3/index.json and our release packages are available on Nuget.

Hi this was a nugget outage over the weekend now resolved
Please close
Thanks
Mark


Pogostick option

I think a really useful tool to have under the utilities section would be PogoStick, I use it pretty often, & can PXE boot it locally, but am unsure if it can be made to work with netboot.xyz
When unpacked, the Pogostick ISO takes up about 16 MB

have tested & managed to get my normal PXE server to boot a local copy of the ISO with memdisk!
Now to try opening the iso over t'internet...
The main problem is that it's stored on the website as a ZIP, do you know if that can be unpacked on the fly?

I gave it a try and it appears that MEMDISK decompressed the zip on the fly (learned something new) so it got to the initial menu, but then promptly kernel crashed in Fusion.  It did fully load in Virtual Box though and got to the menu.  I'll mock up an option and you can give it a try via the test branch.

Great, thanks! :) Also CC'd you in on an intro email to the project owner, in the interest of keeping everyone in the loop

https://github.com/antonym/netboot.xyz/pull/34

successfully tested on a ~3 yr Alienware, will test more thoroughly tomorrow if needed :)

https://github.com/antonym/netboot.xyz/pull/34


chore (api)!: remove capabilities from channel handshakes

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[ ] Targeted PR against the correct branch (see CONTRIBUTING.md).
[ ] Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
[ ] Code follows the module structure standards and Go style guide.
[ ] Wrote unit and integration tests.
[ ] Updated relevant documentation (docs/).
[ ] Added relevant godoc comments.
[ ] Provide a conventional commit message to follow the repository standards.
[ ] Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
[ ] Re-reviewed Files changed in the GitHub PR explorer.
[ ] Review SonarCloud Report in the comment section below once CI passes.

Note: I haven't run E2E tests yet, and I need to open the PR for review for that. If anything fails, I'll mark the PR as not ready :)


WASM: Release handles

Handles were not released that were aquired prior. This PR deletes the handles in the corresponding functions and adds two new functions to release the handle manually.
Rationale for "the manual way"
Why release manually? mapGet and dataArrayGet has a lifetime that can't be deduced by function calls. One option would be to automatically release all handles that were newly aquired after an event callback, but that would miss the ones that were added in init.
Furthermore the use case for dataArrayGet is to iterate over all elements in an array. If that array is larger than the max handle count, the above solution (automatically release handles after calback) wouldn't work.
New tests
I added a new test file which is in the same package. Needed to inspect the internal handleMap of wasmOperatorInstance

What about using runtime.SetFinalizer() and relying on the GC of Go?

What about using runtime.SetFinalizer() and relying on the GC of Go?

Do you mean using the GC of Go in the WASM host or in the WASM guest?

If you mean the WASM host, how would the Go runtime in the WASM host know whether the WASM guest still has a reference?
If you mean the WASM guest, note that "SetFinalizer call [...] is a noop in TinyGo" (according to this comment)

If you mean the WASM guest, note that "SetFinalizer call [...] is a noop in TinyGo" (according to this comment)

Yeah, I meant the guest. Whenever we receive a handle in one of the functions we could (well, if it was supported... bummer...) set the finalizer that would then actually free the handle on the host when GC'd. Found this custom GC option where you could provide your own - unsure if it's feasible, though: https://github.com/tinygo-org/tinygo/blob/release/src/runtime/gc_custom.go

Either its a noop as @alban has said or the GC is not running fast enough for these smaller data packets.
I get no invocation of the Finalizer when sending a data event array of length 10 a hundred times after each other.
Would have been the best solution for user experience though

Introduced a releaseHandle function instead of separate ones


ACharecter_StoryGraph

thanks for sharing. which version do you use??when I compile the code using 4.11 and 4.12, 4.11 can compile, but when I open the project, it will stop when in 60%.

I comile code on 4.14. Can  you show error window?

Quests and dialogs edits in storygraph asset(right click in content browswer StoryGraph).
You also need create objects witch write here https://github.com/Deema35/StoryGraph/wiki/How-to-install%3F .
I think, I have understand why your project crush. Unreal engine does not allow use assets create in later version of engine. And if you use UE 14.11 you can'nt get assets from my project. I would advise to go in UE 14.14.


official icon for the app ?

Hello,
That would be like a cherry on the cake if Scrcpy had an official icon so we could use it to create shortcut on our desktop.
And thank you for this very useful app !

+1, @rom1v ?

@rom1v Noticed #1987 and if you need additional file formats, I'm happy to provide if needed.


OAuth Support

Thanks for what you're doing with this project.
In the README it is stated:

Currently, this library supports only the "internal integration" authorization mode.

I'm not too familiar with OAuth, but from the Notion docs it seemed as though once the OAuth flow has succeeded you are simply given a token which can be used in essentially the same way as a personal token.
Are there differences in how you interact with the API when using OAuth (such that changes would be needed in this package in order to support it)?

There are no differences if you use the token obtain from the OAuth flow.

Great, thanks for clarifying.
Maybe the quoted text from the README could be updated to make that clearer.


Add deploy_directory resource.

This is a simple solution to #4362.  It works just the same as the current deploy resource, but skips the SCM bits.  Instead of copying to the cached-copy directory, the code is copied directly from repo to the current release path.  I'd be happy to provide documentation once this has been reviewed and 👍 .

What is the use case for this? I'm not super clear how you would actually use it.

Sure, I'd be happy to explain.  I'm at a fairly large company that runs thousands of hosts.    We don't have support for deleting old builds, and have a lot of this type of code across many recipes, which isn't ideal.
With this update, we can have the deploy resource manage everything after the code is extracted.
We don't use the deploy resource as-is because it's not scalable; we can't have hundreds or thousands of hosts doing a git clone concurrently, and then running the builds locally.  We instead have Jenkins do that once per build, push an artifact to S3, and have the hosts pull that down.
I hope that clarifies things a bit; let me know if you need more details.

I'm a little confused why you want/need the deploy resource logic in here at all. Just do what you are doing now without the symlinks. The symlink structure of Capistrano (which deploy copied) makes sense for interacting with humans, but not really for fully automated deployments. You could probably simplify this down to one aws_s3_file resource notifying a poise_archive resource and leave it at that. I would also really recommend looking at switch to fpm and debs/RPMs instead of tarballs since that handles permissions, cleanup, repo formatting, etc.

The Capistrano influence is very apparent, so I do symlink_before_migrate({}) and a few other things to turn off some of those "freebies" that conflict with my flow.
The symlinks are there for two reasons: atomicity and the ability to rollback.  Granted, rolling back doesn't work with deploy_directory, but it can be supported fairly easily down the road.
poise_archive seems similar to ark, which I do use fairly often.  If these instances were fully-immutable, your suggestion would work fine, but they are long-lived and updated often.

I understand the use case, but the deploy resource is a hot mess of old code with architectural bugs that are likely to never get fixed short of a complete rewrite.  I don't really like the idea of building on top of a bad foundation.

Yeah I'm leaning strongly towards anything like this that builds on the existing deploy resource should go into a cookbook, I don't think we would want to accept the responsibility of maintaining more stuff on top of the existing deploy resource in core.

Are there any plans to give the deploy resource any love in the near future?  I figured an update like this would be great for those folks who don't deploy from SCM and want to use an easy, stable core resource, but I do understand your concerns.
I can split this up into its own cookbook; I haven't looked into extending core resources before, but is it as straightforward as I'd expect?

@ameir I gave it a bunch of love by providing examples on how to not ever use it again :) The atomicity argument is real, but most systems read the code into memory so the real atomicity of upgrades is on when you restart the service. This doesn't apply to some tools though, notably PHP. Deploying from static archives is cool and should be well supported by the ecosystem, but I don't think we need to keep doing the symlink dance in the general case. If you need it specifically, it's super easy to implement unpacking each rev of the artifact to its own folder and use a single link resource to manage things :) That avoids the whole mess of the deploy resource and keeps things mostly in convergent territory.

Noah has his complete reimagining of what the deploy resource does.  I've been noodling around with a half-written prototype.  But yeah in its simplest case, what @coderanger just ninja posted there while i was typing this -- unpack to versioned directories and use a link resource and avoid all the buggy framework that gets dragged along with the deploy resource.  Half of what the deploy resource does is buggy code that attempts to implement capestrano and if you're not deploying a rails app its not doing you any good.  The other half of the code is interfacing with the git scm provider in a horribly buggy fashion.   If you don't need to deploy a rails app and aren't deploying from git there's just not a lot left in the deploy resource that you're buying other than a dumptruck load of bugs around a symlink resource...

Thanks, guys.  Looks like I'll just write a little wrapper around what I need to get done, and avoid all the overhead inherited from deploy.
Thinking out loud: it sounds like deploy itself should be generic, and the Capistrano clone should be called rails_deploy or cap_deploy or something of the sort.  That's a BC break, of course, but it definitely seems more logical :) .

Also just for the record: Amazon does hosted Git repos as a service so you could use those. It will be waaaay more efficient than tarballs as far as transfer times :) I still prefer artifact-based deploys in most cases for the simplicity of it, but it's another option.

@ameir A more generic vision of an app deploy resource is exactly what the application resource does :)

I looked at https://github.com/poise/application before, but it looked like the source had to be cloned from git.  I am familiar with AWS CodeCommit, but the build process after cloning the repo is what takes a lot of time (grunt/gulp tasks, npm installs, composer, etc.), which is why I went the artifact route.  I'll gladly take another look if I'm missing something.  Great cookbook marketing, btw ;) .

Unless you mean that I do all of the building and then push that to a separate repo that I deploy from, which is an interesting idea.

@ameir The git you see in all those examples is a normal resource. You could replace that with your existing s3 file + unpack logic to the same end and still use all the same application plugins. This might not be super useful depending on how all-encompassing your artifact is.

Oh, that's pretty neat.  I'll start giving that a whirl now; thanks!


changing the node engine to >=8.6.0

Updating the docs and the package.json to so the minimum node version is displayed to potential users of the module.
Ran into some issues:
node_modules/kafkajs/src/index.js:57
          retry: { ...cluster.retry, ...retry },
                   ^^^

    SyntaxError: Unexpected token ...

      at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/script_transformer.js:403:17)
      at Object.<anonymous> (node_modules/kafkajs/index.js:1:42)

Because the index.js uses object spread syntax without transpiling, users will get this error. Object spread was added to node without a flag in v8.6.0.
https://node.green/#ES2018-features-object-rest-spread-properties

@tulios Sorry for the late reply, I just realized you asked a question!
To answer your question, we are going through the slow process of bumping to node 10, but I would hesitate to release this module locking to >= node 10 so quickly. It restricts the reach of this module. This is why tools like babel exist to allow you to take advantage of the newer features of ES but still support legacy versions of node/browsers etc.
Of course this is just my opinion and you have your reasons for not using babel as of yet. I think it's more receptive to support the current two versions of node at least. That gives people time to update their services that might use this module. As an example we have 20 services that use this module now, with varying versions of dependencies. Some of those dependencies don't allow use to move to node 10 without updating them. Some of the apis of those dependencies changed so that requires a lot of dev/qa effort to move up, even though it's scheduled for the year.
Just some food for thought :)

This is great input for #251. My current thinking is that we'll keep supporting 8.x.x until the end of the year (basically when the support period from node itself ends), but we haven't committed to anything yet.

Hi @blackdynamo, thanks for the information, this helps us shape the future. We praise stability and don't have any concrete plans to deprecate node 8. We want to remove all dependencies and node 10 should facilitate that, but we are working on a strategy for that.
Thanks again.


feat: Support defining prefixes to shield routes

about issue19

Thanks for the PR! I wasn't still sure about the feature. I think it might be redundant with the exclude option.

Thanks for this. In the end, I decided to just use the exclude option for this


add backup logic to main script

a suggestion to save existing configuration files for cases where you have already configured something on the system and want to use it in the future

ps. - Never used PR system on GitHub before. I would be glad to hear any of your feedback or comments


Window minimization does not trigger updates in WorkspaceHUD

This is because we do not track _NET_WM_STATE_HIDDEN events from pager.

Turns out  1a5e584 does not fix this completely

1a5e584 did fix the updates issue, but I thought it didnt because a window would still show as active if it was the last window to be minimized in a workspace because active took precedence over minimized. This was fixed in 80d9f32b0ff558ac8db507227885d435532f23ca


Add support for two digit versions - vX.Y

The version parsing library already supports them, but it normalizes
all version strings to have three components. This fix properly handles
versions that have been normalized in that way.
Fixes #24

@brikis98 I've addressed your comment and added some test cases. I've just amended my previous commit as this change is quite small, PTAL.

Test added, back to you.

I'll merge now and let the tests run. Once they pass, I'll issue a new release.

https://github.com/gruntwork-io/fetch/releases/tag/v0.3.1. Thx @tomdee!


Handle malformed streams better.

When parsing the #~ stream it will require references to the #US and #Blob
streams, so we need to make sure those are not NULL before attempting to parse
the stream. It is possible to only do these checks in the place we need them but
I'd rather declare the whole thing as malformed once and early.
Fixes part of #650.

@flandr - Let me know if this is roughly what you had in mind. I decided to do the check once, early in the process, instead of sprinkling it around at all the places inside the function which handles that stream, which seems more sane to me. We should bail early if we can...

LGTM


update to workspace version 4.0.27

Found a bug in latest workspace version, sending followup PR: https://github.com/petershin/liferay-portal/pull/1860


EXIF metadata Dumped

I just try trimage, and was really exited by its potential.
Unfortunatly, I cannot use it beacuse it drops most of the EXIFS metadata (see it with exiftool).
Its probabliy due to the way jpegoptim works.
Buts sincce youre wrapping around it, maybe you can also use exiftool to also copy metadata into the new optimized file ?
Regards,
Julien

Trimage is made to optimize images for websites/online usage, where EXIF isn't needed. If you want to compress images but keep the exif data, please use another tool

Thanks for your answer. It make sense. But, at least, you may warms users (dumb like me) that are tempted to use it to gain disk space.

OK, thanks. I should have read that If I spent more time to read the description. Sorry for the inconvienance.

FWIW, we're considering adding a big warning on first startup


Complex differentiation

Thanks for the cool package.  When trying to differentiate a complex function I got a weird result.  For example
julia> using SymPy
Warning: imported binding for transpose overwritten in module __anon__

julia> x=sym"x"
x

julia> diff(exp(im*x), x)
        true*I⋅x
true*I⋅ℯ

Why is a true in the resulting equation?  Is there something I am doing wrong?
Thanks for you help,
Lucas

Hmm, wasn't expecting that. Multiplying by true is just like multiplying by 1, but still...  I likely can workaround this, but for now your best bet is to use IM, and not im. The IM variable is aliased to sympy's imaginary unit, not julia's. Unfortunately, I forgot to export IM. So you'll need to update to master or prefix as follows:
julia> diff(exp(SymPy.IM*x), x)
   ⅈ⋅x
ⅈ⋅ℯ

I'll leave this issue open as a reminder to see if I can do something so that using im works. I just checked in some changes that make working with math constants more julian.

Thanks for checking it out.  That is an easy workaround for now.

I just pushed a change so that it works with the call you had (sans IM). I aim to tag a new version pretty soon.

Oh, and thanks for taking the time to report the issue.

Thanks!


Test PR to see how forks affect github actions

DO NOT MERGE

Looks like the CircleCI check is still showing up :frowning_face:

Looks like the CircleCI check is still showing up

I went into the repo settings and "suspended" the CircleCI integration (but didn't uninstall it, though we can do that too). That was after I saw it show up here, so the trick will be to launch another PR and see if it's included there too. Stand by.


Tests not run if not existed while installing a Chart

I am surprised with one particular behavior and am asking if it is intentional.
My Chart does not use any dependencies. When I run helm test and there is a test:

that existed while running helm upgrade --install, that test will be run
that did not exist while running helm upgrade --install, that test will not be run

I expected helm test to run all the tests locally declared (all the files with "helm.sh/hook" annotation), not only the ones which existed while running helm upgrade --install.
I understand that current behavior may be well-grounded, it just seems counterintuitive to me and thus, I wanted to check that.

@xmik You are correct that the behavior is per install or upgrade. The reason being is that you want the tests to be run for that specific revision of the release and if you run them out of band (e.g. from your local dev environment), they are not actually part of the release revision you are testing. Does that make any more sense?

Yes, it makes sense. Additionally, I see that this way we can run tests without the need for a chart source code. But I wonder: when is this useful? I think potential use cases are:

to invoke tests regularly (and automatically) and treat their result as a health check (it is easier to do without the need for a chart source code)
to check once and manually that the deployed release revision works (it is easier to do without the need for a chart source code)
just to ensure the tests are part of the release revision we are testing (a safety measure)

Actually I think you only intended the last use case (a safety measure). Do I understand this correctly?

@xmik I believe those use cases you are describing are part of adding validation to an install/upgrade. I have an open issue tracking that idea

Ok, thanks for the answers and the link. I will close this issue, because @thomastaylor312 you have answered my questions.


Power supply updates for PCB rev.B

12V supply for blower, stepper motors has some instabilities (see #1187) that don't cause functional problems, but would be good to eliminate.  Some of these aren't proven to be problems, but are just potential weaknesses for outside interference, etc.

[ ] Add more bulk capacitance on the blower output: the large duty cycle variations from #1187, which propagate back to even the +VLink supply, show that much of the 5-7 kHz current pulses from the blower are being supplied directly from the DC input power and not the blower bulk caps.  Starting point would be doubling these values and using lower-ESR aluminum-polymer caps; 66uF is 0.34Ω @ 7 kHz, which is comparable to the combined ESR of ~0.36Ω (@ 1 kHz) between the two caps.
[ ] Re-arrange LM5141 PCB layout, with AGND tied directly to the GND plane but arranged so that all the quiet return paths from COMP etc. to AGND don't intersect any of the noisy return paths for gate drive etc.  This removes potential parasitics/pickup on AGND from making it a separate trace, and puts the quiet pickup loops further from the noise-generating loops.
[ ] Add a series 50-ohm resistor on the CS pin, in series between R211 and C147.  This matches the evaluation circuit, and sets a very reasonable 1% settling time of 25 ns, as opposed to right now where C147 isn't doing much, with a settling time of <<1 ns considering resistance, and the only filtering it provides is interaction between C147 and the trace inductance.
[ ] Route the VOUT and CS pin current-sense traces closer together (as close as DRC/min. spacing allows) to provide better differential noise rejection.
[ ] Increase the 12V supply's bootstrap cap (C146) from 100nF to 1uF or so.  Currently, the MOSFETs (BSZ019N03LS) have 22-29 nC @ 4.5V Vgs, which means that each MOSFET turn-on makes the bootstrap cap sag by up to ~0.3V.  The fully-charged bootstrap cap voltage is already on the low side: 4.75-5.25V LM5141's Vcc, minus the BAT54J Vf - compare against max. 2V threshold for MOSFET or 2.5V UVLO for LM5141's bootstrap pin.  A couple max-on-time switching cycles caused by some transient condition, without a long-enough off-time to recharge the boostrap cap, could potentially make the voltage fall too low.

[ ] Disable diode emulation mode by swapping R203 and R204: this gets rid of the stuck-in-DCM problem detailed in #1187


sw-6862 changed order of filters for sql

Codecov Report
All modified lines are covered by tests :white_check_mark:

Files
Coverage Δ

internal/sirius/get_client_list.go
70.90% <100.00%> (ø)

:loudspeaker: Thoughts on this report? Let us know!.


including a search query to boost the exact match (if present) for elasticsearch

In regular elasticsearch queries, an occurrence of a perfect match (for a multi-term search query) is not assigned a higher relevance than any other match.
In this PR I changed the query for the elasticsearch backend so that exact matches are boosted by 1.5, thus appearing higher than regular results.
This helps in places where eg. people pages are indexed and searching for the full name brings up less interesting results than searching for the last name only. You can see this on http://www.rca.ac.uk/
when searching for "Teasley" vs. "Sarah Teasley".

Thanks for the PR Johannes! But it looks like this is an RCA issue.
https://github.com/torchbox/verdant-rca/blob/49a91b91143c46962e66506f491056c2bb18faf9/django-verdant/rca/models.py#L3931-L3932
The student's names are being boosted 50 times, but Sarah Teasley is a staff member so any student called Sarah gets ranked higher. This code was probably written before we changed Wagtail's'default title boost to 2 (down from 100).
I think reducing these boosts to something sensible like 1.5 would solve the issue.

Hi Karl,
of course, you probably know a lot more about the search in Wagtail than I
do. But is it not a good idea to boost full-phrase matches vs. partial
matches in almost any case? I don't think I can think of an example where a
partial match should be rated higher than a full match. Since this PR
shouldn't change anything else about the search mechanics I still think it
would be worthwhile to look at a way to implement it.
Thanks for the pointer on the RCA boosts, I'll look into them some more
today.
Cheers,
Johannes
On 20 April 2016 at 11:53, Karl Hobley<EMAIL_ADDRESS>wrote:

Closed #2497 https://github.com/torchbox/wagtail/pull/2497.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/torchbox/wagtail/pull/2497#event-634283081


Smoke test paused requests

Failing test (timing out on my machine) for a reported issue with deploying successfully, then failing to deploy because request is paused, then trying to deploy again after request unpaused.

Danger has errored
[!] Invalid Dangerfile file: Failed to open TCP connection to lgtm.in:80 (getaddrinfo: Name or service not known). Updating the Danger gem might fix the issue. Your Danger version: 5.5.3, latest Danger version: 5.5.12
 #  from Dangerfile:45
 #  -------------------------------------------
 #
 >  lgtm.check_lgtm
 #
 #  -------------------------------------------

  Generated by :no_entry_sign: Danger


Bump to cloudevents-sdk 0.5.0

Waiting for authority to publish to crates.io. Once published, should
just be a matter of removing the entry in top-level Cargo.toml

/test


Luck stat

Hi again! This is not an issue but more of a question since I dont know how to contact you directly except through github. Does luck make you have better loot with everything? (including your other mod RelicEx)

Hi there,
The vanilla Luck attribute remains unchanged, and its effects can be viewed here. The Luckiness attribute added by PlayerEx actually does nothing by itself; but increasing its value also increases the value of attributes that do have an effect, such as the vanilla Luck attribute.
Tl;dr:

Adds 1 × level to attribute generic.luck, making loot table entries with a high quality score more likely, and entries with negative quality less likely. It also increases the chances of bonus_rolls occurring. Currently, only fishing uses quality. The new weight of each entry is floor(base_weight + quality * generic.luck). Negative levels decrease luck.

Using a fishing rod enchanted with Luck of the Sea increases a player's generic.luck attribute, but doesn't actually grant the Luck status effect.

Regarding RelicEx, the vanilla Luck attribute also makes it more likely for mobs to drop a relic item.
Hope that helps,
Thanks.

Thank you so much! Then... The Luckiness stat is almost a dump stat cause... The crit chance is ok but not game-changing unless you have some dex up and a LOT of points into Luckiness so you can use it for fishing and more relics... Ok nvm its not a dump stat. Int is (?

I would currently agree that Intelligence is a dump stat.


Add DELTA_TESTING=1 environment variable when running Python tests

Which Delta project/connector is this regarding?

[ ] Spark
[ ] Standalone
[ ] Flink
[ ] Kernel
[x] Other (fill in here)

Description

In Python tests, we want to test features that are only for testing. But DELTA_TESTING=1 is missing for Python tests. So this PR adds it to the environment variable when running Python tests.
How was this patch tested?

Not applicable.
Does this PR introduce any user-facing changes?

No.

6 tests have failed in master. are they related? if so, can you fix them?

6 tests have failed in master. are they related? if so, can you fix them?

test failures are fixed in https://github.com/delta-io/delta/pull/3442

The error in spark master test is not related to the change as it fails in other PRs as well.
[error] /home/runner/work/delta/delta/spark-connect/server/src/test/scala-spark-master/io/delta/connect/DeltaConnectPlannerSuite.scala:60:58: value forTesting is not a member of object org.apache.spark.sql.connect.service.SessionHolder
[error]       val result = new SparkConnectPlanner(SessionHolder.forTesting(spark)).transformRelation(input)
[error]                                                          ^
[error] /home/runner/work/delta/delta/spark-connect/server/src/test/scala-spark-master/io/delta/connect/DeltaConnectPlannerSuite.scala:86:58: value forTesting is not a member of object org.apache.spark.sql.connect.service.SessionHolder
[error]       val result = new SparkConnectPlanner(SessionHolder.forTesting(spark)).transformRelation(input)
[error]                                                          ^
[warn] /home/runner/work/delta/delta/spark-connect/server/src/test/scala-spark-master/io/delta/connect/DeltaConnectPlannerSuite.scala:27:68: Unused import
[warn] import org.apache.spark.sql.connect.delta.ImplicitProtoConversions._
[warn]


marshal all resource fields returned by geneva action

don't use the MarshalJSON provided by the Azure go library because it drops fields

lgtm


[Sidebar] [Missing Docs] - Direction is not documented

Steps to Reproduce

Try to create a sidebar from some direction using docs
Try to find the data- settings in https://semantic-ui.com/modules/sidebar.html#/settings
You're alone

Expected
https://semantic-ui.com/modules/sidebar.html#/settings should have the direction settings documented

Hi @italomaia, can you please elaborate? I didn’t understand what’s missing.


speccing NSProxy subclasses

I am having trouble writing specs for an NSProxy subclass in my project.
Calling something like:
[proxy shouldNotBeNil];

Throws:
NSInvalidArgumentException "*** -[NSProxy doesNotRecognizeSelector：attachToVerifier：] called!"
Is this a bug? If not, can you show me how to solve this problem?

https://github.com/allending/Kiwi/wiki/Guide:-Up-and-Running-with-Kiwi  - section 6

Thanks for the response. I double checked my setup and -all_load was already set.

Minimal sample project showing issue would help.

I found the issue. Not sure I fully understand why this solves the problem though.
Since I am writing my specs first, I hadn't fully implemented -methodSignatureForSelector or -forwardInvocation. Returning the NSMethodSignature from my target object, and invoking the NSInvocation on my proxies target, returned a valid instance of my proxy which caused my spec to pass.
If you want the demo project, I can still send it to you.

No need ;)

I assume this is due to NSProxy not actually inheriting from NSObject; it's good that you reported this even though I don't think it's a bug because as Allen mentioned, it's good to document these issues.


Modify the placeholder in email-admin-config.xml file.

Is your suggestion related to an experience ? Please describe.
Currently uses {{}} as the placeholder for claims in email templates. This conflicts with the helm configurations. Better to use a different type of placeholders.

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Scroll wheel zoom goes through the earth

Reported on the forum: https://groups.google.com/forum/#!topic/cesium-dev/xeRAg8lObUg

If you go to this sandcastle:
http://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=Geometry and Appearances.html&label=Showcases
Make the camera perpendicular to the earth then zoom in quickly as far/fast as you can using the mouse wheel with the mouse over a 3D shape, you'll zoom through the earth about 10-20% of the time.
NOTE: It doesn't seem to happen nearly as often if the camera is on an angle, or if the mouse isn't over a shape.
It only seems to happen for me on Mac OS X and Ubuntu. It does not happen on Windows. I am able to reliably re-create the issue using OS X Sierra and Chrome 55

I've noticed that the viewer.scene.screenSpaceCameraController.minimumZoomDistance keeps being set to 0, regardless of what I set it to.
From a quick search of the Cesium source it seems that controller.minimumZoomDistance is being set in multiple places around the application every frame. How can I stop this being set to 0?

CC #2968 and #3037

Closing as duplicate of #4855


Missing serial number arithmetic

In AMQP 1.0, a delivery-number is a 32-bit RFC-1982 serial number.
The DISPOSITION frame includes fields first and last.
first is the lower bound of delivery-ids to be (n)acked.
last is the upper bound of delivery-ids to be (n)acked.
To provide an example:
Serial number arithmetic defines sequence number 1 to be greater than sequence number<PHONE_NUMBER> (= 2^32-2) .
Therefore my understanding is that a DISPOSITION frame with first =<PHONE_NUMBER> and last = 1 is allowed and refers to delivery-numbers<PHONE_NUMBER>,<PHONE_NUMBER>, 0, and 1.
Is my understanding correct?
If yes, aren't  https://github.com/Azure/go-amqp/blob/1c1e489960c8b4cb448bd8a0a3d11adaa13ff77f/session.go#L418
and
https://github.com/Azure/go-amqp/blob/1c1e489960c8b4cb448bd8a0a3d11adaa13ff77f/session.go#L708
flawed? These lines need to perform serial number arithmetic instead of integer arithmetic?

In other words, there are bugs when acking / nacking messages with this client when the delivery ID wraps around.
The .NET client does the right thing in https://github.com/Azure/amqpnetlite/blob/772d0d3b6bbc43cf64e0ccd25911317f011927d7/src/Session.cs#L650 because they overwrite the comparison operators in https://github.com/Azure/amqpnetlite/blob/772d0d3b6bbc43cf64e0ccd25911317f011927d7/src/SequenceNumber.cs#L94-L98 to perform serial number arithmetic.


Added AspNet.Metrics

Code Analysis and Metrics/AspNet.Metrics - AspNet.Metrics
PROJECT_DESCRIPTION

http://www.dnnsoftware.com/community/download is timing out?


Can't watch for file creation inside of non-yet-existing directory

Describe the bug
Watching ./foo/bar.txt when ./foo/ does not yet exists won't trigger any event when ./foo/bar.txt is finally created.
Having ./foo/ existing when calling chokidar.watch or watching ./*/bar.txt works correctly, though.
Versions (please complete the following information):

Chokidar version: 3.0.2
Node version: v12.6.0
OS version: Ubuntu 18.04.2 LTS

To Reproduce
const chokidar = require('chokidar');
const fs = require('fs');

// Make sure no ./foo directory currently exists

chokidar.watch('foo/test*', {}).on('all', () => {
  console.log('This will never be called');
});
chokidar.watch('*/test*', {}).on('all', () => {
  console.log('This will be called');
});

fs.mkdirSync('foo');
fs.writeFileSync('foo/test.txt', 'testing 1');
// Both events should fire, but only the second watcher is triggered

From reading the tests it seems to be expected behavior (the tests explicitly create directories before watching files), but I can't find any documentation on the subject nor any way to bypass it.
Expected behavior
I would expect events to be fired when files are created inside of non-yet-existing directories, no matter how I define my pattern (with a glob, or a static string).
Additional context
I'm currently using a hack to force chokidar to treat my static string as a glob by using (foo|$*)/test* instead of foo/test*. $* will never match anything so both foo and (foo|$*) should match the same things, but it seems to somehow trigger chokidar into the right behavior.

Have you tried my pull request?
https://github.com/pixelastic

This isn't a problem in filespy, an alternative to chokidar.


Memory leak during catching distributed zookeeper lock

There is an ability to catch the distributed zookeeper lock in the curator library in two ways:

Acquire the mutex - blocking until it's available;
Acquire the mutex - blocking until it's available or the given time expires.

However, the procedure of getting such lock doesn't work correctly. It works fine only when some component can catch the lock immediately. In any other cases it leads to memory leak in goroutines.
More information:
There is the main functionality for catching the distributed lock: https://github.com/EMCECS/curator/blob/master/recipes/locks.go#L261
func (l *lockInternals) internalLockLoop(startTime time.Time, waitTime time.Duration, path string) (haveTheLock bool, err error) {
	var doDelete bool

	for l.client.State() == curator.STARTED && !haveTheLock {
		if children, err := l.getSortedChildren(); err != nil {
			break
		} else {
			sequenceNodeName := path[len(l.basePath)+1:]

			if results, err := l.driver.GetsTheLock(l.client, children, sequenceNodeName, l.maxLeases); err != nil {
				break
			} else if results.GetsTheLock {
				haveTheLock = true

				break
			} else {
				previousSequencePath := curator.JoinPath(l.basePath, results.PathToWatch)

				c := make(chan error)

				t := time.NewTimer(waitTime - time.Now().Sub(startTime))

				l.client.GetData().UsingWatcher(curator.NewWatcher(func(event *zk.Event) {
					c <- event.Err
				})).ForPath(previousSequencePath)

				select {
				case err := <-c:
					if err != nil && err != zk.ErrNoNode {
						break
					}
				case <-t.C:
				}
			}
		}
	}

	if err != nil || doDelete {
		l.deleteOurPath(path)
	}

	return haveTheLock, err
}

For instance, lock on the specified path has been already catched by some component and the other component is waiting when the lock will be available.
Let's consider two situations:
Catch the distributed lock without timeout (blocks until it's available):
In this case waitTime time.Duration will be set to -1. Thus, it means that the current fragment of code will be executed immediately without any waiting, because timer will be started with the negative value:
c := make(chan error)

t := time.NewTimer(waitTime - time.Now().Sub(startTime))

l.client.GetData().UsingWatcher(curator.NewWatcher(func(event *zk.Event) {
	c <- event.Err
})).ForPath(previousSequencePath)

select {
	case err := <-c:
		if err != nil && err != zk.ErrNoNode {
			break
		}
	case <-t.C:
}

Then the next iteration of the loop for getting distributed lock will be executed and the same code will be executed again and again. As a result, on each loop iteration new watcher instance will be created for waiting any incoming events from zookeeper.
l.client.GetData().UsingWatcher(curator.NewWatcher(func(event *zk.Event) {
    c <- event.Err
})).ForPath(previousSequencePath)

The code for waiting such events will be executed in the separate goroutine and will be blocked until events will be available. Such behaviour causes the goroutine to hang, because no events will be read (lock has been already catched).
Thus, it means that the code above will produce a lot of hanging goroutines.
Catch the distributed lock with timeout (blocks until it's available or the given timeout has been reached)
In this case timer will work fine, the code won't be executed immediately, but if timeout has been already reached error won't be returned. The next iteration of the loop for getting distributed lock will be executed again and again until lock will be available.
Proposal fix
This approach is implemented in the original apache curator library: https://github.com/apache/curator/blob/master/curator-recipes/src/main/java/org/apache/curator/framework/recipes/locks/LockInternals.java#L271

Acquire the lock - blocking until it's available
Block the code execution until any events will be read from zookeeper.
After that, move to the next iteration of the loop for getting cluster lock if necessary.
Thus, only one goroutine will be hanged on waiting for incoming zookeeper events.
Acquire the lock - blocking until it's available or the given time has been reached
Return an error if the timeout has been already and the distributed lock won't be catched successfully.

@gusakk I guess we can close this PR :)


CI for testing behaviors of Annotators

There are test classes for some annotators (https://github.com/mynlp/jigg/tree/master/src/test/scala/jigg/pipeline), but they are only limited, or very superficial.
One particular problem is that we cannot test the behavior of annotators that rely on external model files, including CoreNLP annotator, since Jigg does not have the models of them internally. This is also the case for annotators for non-maven softwares, including mecab, KNP, etc.
Currently, for example, when I update the version of CoreNLP in build.sbt, I don't carefully check how the behaviors of annotators change; I just see that Jigg's wrapper does not output errors when executing. This is bad.
We need more systematic test mechanism for these external softwares, perhaps with some CI tool?

Memo
Triggers of Travis CI:

push or pull requests
Cron Jobs (at regural scheduled interval)

interval : daily, weekly, monthly

When a programing language is scala:

If there is build.sbt file in the root repository, uses sbt to build it.
To get the latest version of extarnal software, write latest.integration in build.sbt

For example,libraryDependencies += "edu.stanford.nlp" % "stanford-corenlp" % "latest.integration"

Now(2018/05/23), get the version 3.9.1.
If you get the model (English) file of Stanford-CoreNLP,libraryDependencies += "edu.stanford.nlp" % "stanford-corenlp" % "latest.integration" classifire "models"

Other writing: 3.8.+ or [3.8, )
By default, get the latest version software in the Mave Central Repository.

Now the tests are working (https://travis-ci.org/mynlp/jigg).
We want to add several other tests for performance as well as corner cases. For example, maybe some parser does not accept a very long sentence and possibly throw an error. But I think Jigg does not implement special mechanism to handle such errors.
We should first check the behaviors of the original parsers (corenlp[parse], berkeleyparser, depccg, etc.), and then create tests by defining the desirable Jigg's input and output pairs, which would absorb the errors of the original parsers.


fix Issue-404 replicationFactor and Message Maximum Byte added

Describe your changes :

fix #404
Added the support for replicationFactor and maximumMessageSize as asked in the above issue.

Type of change :

[x] Bug fix

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have performed a self-review of my own.
[x] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

@harshach

@ayush-shah LGTM. Can you add one more property "Log Cleanup Policy" The values can be "compact, delete" . It can be both or one of them


Remove NewPossibleNonCounterInfo and minimise creating empty annotations

Follow up to https://github.com/prometheus/prometheus/pull/12959 as a quick fix to temporarily remove NewPossibleNonCounterInfo and avoid creating empty annotations unnecessarily.
Followed up with https://github.com/prometheus/prometheus/pull/13022 to put NewPossibleNonCounterInfo back without running it every step, and apply a similar treatment for other warnings which don't look at the data like NewInvalidQuantileWarning.
According to benchmarks, this should restore most of the efficiency:
Before is run on a branch on main that reverts the commits that added and modified annotations, and after is run on a branch on main with this commit applied.
goos: linux
goarch: amd64
pkg: github.com/prometheus/prometheus/promql
cpu: 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz
                                                  │ BenchmarkRangeQuery_before.txt │   BenchmarkRangeQuery_after.txt    │
                                                  │             sec/op             │   sec/op     vs base               │
RangeQuery/expr=rate(a_hundred[1m]),steps=1000-16                      9.176m ± 4%   9.645m ± 1%  +5.11% (p=0.002 n=10)

                                                  │ BenchmarkRangeQuery_before.txt │ BenchmarkRangeQuery_after.txt  │
                                                  │              B/op              │     B/op      vs base          │
RangeQuery/expr=rate(a_hundred[1m]),steps=1000-16                     367.6Ki ± 0%   367.6Ki ± 0%  ~ (p=0.353 n=10)

                                                  │ BenchmarkRangeQuery_before.txt │   BenchmarkRangeQuery_after.txt    │
                                                  │           allocs/op            │  allocs/op   vs base               │
RangeQuery/expr=rate(a_hundred[1m]),steps=1000-16                      5.256k ± 0%   5.257k ± 0%  +0.02% (p=0.000 n=10)

Test error seems transient.


test: separate

Codecov Report

Merging #33 (bd8f4bc) into main (fcf68d5) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head bd8f4bc differs from pull request most recent head 40df057. Consider uploading reports for the commit 40df057 to get more accurate results

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   94.74%   94.74%
=======================================
  Files          48       48
  Lines        6931     6931
  Branches      450      450
=======================================
  Hits         6567     6567
  Misses        364      364

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


source code for examples

When I run exponent on iphone it allows me to run examples like
@ide/first-experience
@ide/pagescroller
Are these project open sourced ? If yes, where can I find the sources ?
Thanks

Hi @agdolla -
The first-experience project is the template of what gets setup when you do a new project in xde. So just click new and you'll have the code as a starting point to work with.
The page scroller was written by @lelandrichardson and I think you can find it in this repository. https://github.com/lelandrichardson/react_native_animation_examples . @ide just adapted it into an Exponent demo.
Jump in our Slack if you need any help with anything!

thanks