Fix #1170 by removing invocationId from non-blocking calls

When talking about #1170 we were talking about how it's going to be a performance problem that we serialize Invocations once for each connection involved in a broadcast. However, if we serialize once, we have to update Invocation IDs as they are supposed to be local to the connection. That means that to serialize once we have to use globally-unique IDs (GUIDs).
However, the messages sent from Server to Client are always non-blocking. In a non-blocking message, the sender never expects to receive a response. This means that there's no reason for an invocation ID at all. So this PR changes how non-blocking messages are rendered. Instead of using a boolean flag, the presence of invocationId will indicate if a message is "blocking" and expects a response. This is similar to how JSON-RPC notifications work.
In JSON this is represented by simply omitting the invocationId parameter. In MsgPack, the invocationId value is written as a MsgPack nil value. Only the Invocation message is affected as StreamInvocations are always blocking by design.
Spec update is coming shortly in a commit to this PR.

Lets also get rid of the blocking/non-blocking nomenclature in the spec, it's extremely confusing to talk about in the same breath as async (which all of the methods are). We might consider using something related to ACKs (ACKed invocations) or something similar.

Lets also get rid of the blocking/non-blocking nomenclature in the spec

Got distracted but I do plan to update the spec in this PR before final approval/merging.

Updated the spec. I also removed the ProtoBuf stuff rather than updating it because there is no plan to have an official ProtoBuf encoding in v1. We can easily bring it back from history (and it wasn't exactly complex)

Unfortunately, JSON.NET gets grumpy when you deserialize objects with read-only properties and more than one constructor. Adding an overloaded ctor to InvocationMessage that doesn't take an invocationId caused this problem in the Redis lifetime manager. So we have to do one of:

Mark the ctor that contains invocationId with the [JsonConstructor] attribute (downside: couples to JSON.NET attributes)
Remove the extra ctor (downside: lots of invocationId: null when you want to create non-blocking Invocation Message objects)
Make the properties read-write (downside: the type really doesn't need to be mutable; and I think we'd also have to add a default ctor to allow JSON.NET to do it's thing)
Use a different serialization technique in redis (surrogate types, JsonWriter, etc.)

Decided to take the last option above. We didn't really need to be serializing full HubMessage objects anyway.


Material localizations should be sentence case for Material 3

In the Material 3 spec, the dialogs and other components have button and label text that is in "Sentence case" instead of "ALL CAPS" as it was on Material 2.
We need to identify all of the strings where this is the case, and then either submit new localizations for Material 3, or just change the existing localizations to be sentence case and then call String.toUpperCase() on the default values if Theme.of(context).useMaterial3 is false.
If we do the latter, then we can avoid the bloat from having two copies of each string in different cases.

We should be careful not to change the case of "OK", "AM", "PM", etc. as the spec shows.

We should also make sure that all languages are properly cased.  From the docs of toUpperCase: "This function uses the language independent Unicode mapping and thus only works in some languages."

Preferred solution is to change all of the existing localizations to sentence case and re-localize them, and then uppercase them in the code since that has less of a compiled size cost.


feat: support modular imports

Current dependencies on/for this PR:

main

PR #106   👈

This comment was auto-generated by Graphite.


Corruption Bugs / Visual Errors

When loading the game, corruptions display as 0/0 throughout instead of the proper level setup
https://discordapp.com/channels/677271830838640680/730669616870981674/803061866418012221
https://discordapp.com/channels/677271830838640680/730669616870981674/804731057215373362
Second link has video

Visual Errors on "Market Deflation" 6+. Effect seems to show 0 for all of them when this is not true.
https://discordapp.com/channels/677271830838640680/730669616870981674/806906414747353108

#1 is fixed with 1852113dd2a8df3bd95b772acaa3771b83566832

#2 is fixed with eb780c4
Closing for now, until new corruption bugs are discovered.


Warped Left eye duplicated on Right (Beat Saber)

Description

The left eye is duplicated onto the right eye and warped

General Troubleshooting

[ Y] I carefully followed the instructions in the README and successfully completed the setup wizard
[ Y] I read the ALVR GitHub Wiki

Environment
Hardware
Note: for Linux, an upload to the hw-probe database is preferred: hw-probe -all -upload
https://linux-hardware.org/?probe=5ab0ffc9aa
Installation
ALVR Version:
2.8.1,2.9.1,nightly
ALVR Settings File:
SteamVR Version:
Previous branch, None, Beta Branch
Install Type:

[ ] Source (ALVR-Launcher)

OS Name and Version (winver on Windows or grep PRETTY_NAME /etc/os-release on most Linux distributions):
Arch Linux

This is a Proton/SteamVR issue, not an alvr one. See https://github.com/ValveSoftware/Proton/issues/6638


cis-trans configuration ignored by pyAvalonTools.Generate2DCoords

For example, if a molecule is created from CCC/C=C\CCC the configuration of the double bond is ignored by a later call to pyAvalonTools.Generate2DCoords.
It was suggested that this may be due to RDKit passing a mol block as input to the AvalonTools code, and that it could/should instead pass an isomeric smiles.
The change doesn't look complex to implement, and I would be happy to contribute a small patch, but I was wondering if it could have any known side effects on other functions that depend on molToReaccs.

Is this an interaction between rdkit<->avalon in this specific regards?  Or is it that avalon ignores stereo info for cis-trans from mol blocks?
I wonder if this will affect Avalon's struchk which would be my larger concern.  I don't know the interface between them.

As far as I understood, the Avalon tools do not take the cix/trans configuration of double bonds into account when generating a 2D layout from a mol block where no chiral centers are at the same time specified. I presume it's not necessarily related to struchk, but we can ask.

Are there any news on this issue?
I always use PyAvalon for 2D coordinate generation because in my opinion it gives "nicer" structures and just realized this issue with an example today.
PyAvalon_E_Z.pdf
Kind regards,
Axel


Character Recognition

Similar to #8. We can use an AI to train multiple models of anime characters we know and love. There are 4 different ways, for example, to draw Mash Kyrielight from Fate, from four different artists. We should be able to compensate for that. Once we know where the character came from, we can also output the franchise/series that they came from.

Firstly, AI is not all-powerful since there will always be errors.
Secondly, are you only classifying or are you doing Semantic Segmentation too?

We're going for classification only, the primary aim here is to have grouping by character in the near future - ala-Pixiv


Neovim multicursor issue

Hello.
I am interested in your Neovim/Lazyvim configuration for the mg979/vim-visual-multi plugin, however it doesn't seem to be working in my setup.
As a VsCode convert I was just trying to select various instances of the word under the cursor, which if I read the config correctly is mapped to <M-b> or ALT-b, am I right?
I just copied that config file and put it in the plugins/ dir of a fresh LazyVim installation. Is the plugin working correctly for you?
Thanks.

Yeah, mine is working~

You may mapping to another key to just test if it's just the keymapping's issue

Thanks for letting me know.


[Remote State] Send remote state location in node join flow

Is your feature request related to a problem? Please describe
The cluster state publication flow has been modified for remote state to send the remote state location to the follower nodes. The follower nodes download the cluster state directly from remote store rather than getting it from the active cluster manager over transport layer. But in the node join flow, the active cluster manager still sends the full cluster state to the joining nodes.
Describe the solution you'd like
Modify the validate join flow to send the remote cluster state location and then download the cluster state from remote on the follower node
Related component
Cluster Manager
Describe alternatives you've considered
No response
Additional context
No response

[Triage - attendees 1 2 3] - @soosinha  - please feel free to raise a pull request


Is "corosensei" a quote came from "assassination classroom"?

Hi!
just a question related to the name of this library.
Is "corosensei" a quote came from "assassination classroom"?
Thanks! 😄

thanks. closing this PR 😄


stages: add org.osbuild.pki.update-ca-trust

In order to perform Satellite registration of images during initial boot, a CA must be enrolled into OS CA bundle. This could be done in the firstboot script just before Satellite registration, but we believe this would be a nice feature of its own.
The goal of this feature is to add support of adding one or more CA certificate files in concatenated PEM text format to be provided when new image is being build. During the build phase, the files would be copied to /etc/pki/ca-trust/source/anchors/ and the command update-ca-trust executed to refresh the OS CA cert bundle.
Expected outcome: A curl command in an instance booted up from such image can reach out to servers with CA provided during image mode without --insecure flag.
https://issues.redhat.com/browse/HMS-4598
Warning: I do not know what I am doing here, the code is untested, I do not have any development setup whatsoever this is just a random trial and error.

I would propose to make this stage extremely dummy and basically just call update-ca-trust. We already have ways to place cert files into the image filesystem - inline sources and copying them with the copy stage in the correct place. Not requiring the cert to be specified in the stage options would give us much more flexibility, e.g. when the certs would be created by any other tool / stage.

Ok simplified as requested. Unsure what the schema should look like at this point.
Also shooting in the dark in terms of subprocess error handling. Not sure what is the best practice here.

Btw is the directory actually writable? I remember there was a place in the osbuild project somewhere with an allowlist of directories which were writeable. Things like /etc or /var/local.

Fixed missing import, liter should be happy now. What is the next step?

Fixed missing import, liter should be happy now. What is the next step?

Can you please add a test case for the stage?
Please have a look at https://github.com/osbuild/osbuild/tree/main/test/data/stages
Most of the tests basically build two trees where the tested stage is used only for one of them. And then the trees are compared and the diff is checked.
If diffing the trees is not reasonable for testing, you may add a special test case in https://github.com/osbuild/osbuild/blob/main/test/run/test_stages.py as there are for some stages.

I amended the test, thanks all for help with writing it! Please re-review.

Amended the change with proper diff.

I'm personally not a big fan of the way we're doing this with a separate copy stage but if others feel that's OK then it's OK.

I understand that you can see it this way, but I think that this a feature:

It makes the custom embedded source explicit by listing it in sources.
The actual cert can come from any other source or pipeline.

IMO, the manifest does not need to be efficient in this situation (meaning that we would "save" a stage), mainly because we already have building blocks that can create files in the tree.

I understand that you can see it this way, but I think that this a feature:

It makes the custom embedded source explicit by listing it in sources.
The actual cert can come from any other source or pipeline.

+1.  Just wanted to add to this: The new stage just runs a command in a tree.  It reads some files and produces output, but the files themselves need to be part of the tree (in the general use case when the command is run).  Having the source of the files be separate from the stage itself makes it possible to get those files in multiple ways.  It can come from an inline source like in the test, but it could also be from an rpm, a curl source, generated from a separate pipeline and copied into the OS.

I am getting AssertionError: length of differences different cannot figure out what is wrong from the output.
However the diff that is fails it with is:
{
  "added_files": [
    "/etc/pki/ca-trust/extracted/pem/directory-hash/7cf11c08.0",
    "/etc/pki/ca-trust/extracted/pem/directory-hash/Test_CA_for_osbuild.pem",
    "/etc/pki/ca-trust/extracted/pem/directory-hash/a521c9ed.0",
    "/etc/pki/ca-trust/source/anchors/sha256:4c4e8c734e4ee3a117ca8f9363ba7b706d02bfc8f297c00b02ce02babddef51c"
  ],
  "deleted_files": [],
  "differences": {
    "/etc/pki/ca-trust/extracted/edk2/cacerts.bin": {
      "content": [
        "sha256:1fc7201640e13d1261decb498479b6fa748ebf8a72121c3f59464c493aea72a9",
        "sha256:13fe6d3e78cfa0c9b31d9c7836a09c45ae1c9c8b847fb69a43b95555de9cf535"
      ]
    },
    "/etc/pki/ca-trust/extracted/java/cacerts": {
      "content": [
        null,
        null
      ]
    },
    "/etc/pki/ca-trust/extracted/openssl/ca-bundle.trust.crt": {
      "content": [
        "sha256:830ae1c02ea63c5fa2198b50fb33d55011a391b0c7ace14a29f8d83daf30128f",
        "sha256:306cf348061be12d41ce03f0c861bd64568f2416149ac51928a60b02ddeb3317"
      ]
    },
    "/etc/pki/ca-trust/extracted/pem/email-ca-bundle.pem": {
      "content": [
        "sha256:fbf592932627ddb0c244dd2441f6a56231cfacb892c1163d4f372d1b949b5807",
        "sha256:077b9d7020b4303a72ef8530481faa461fc926608094a17475474b8c9dcef5fa"
      ]
    },
    "/etc/pki/ca-trust/extracted/pem/objsign-ca-bundle.pem": {
      "content": [
        "sha256:67ea06a3b7d7d39345b36161d947a15c378fb5faab80db372fa1bc4c4e346e14",
        "sha256:4a11fade0941e6b6c483b7522296629e454e676851baf9e1b60e486a35c26209"
      ]
    },
    "/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem": {
      "content": [
        "sha256:a0a9885edfce047620854ee7bb4214dfc2a19d666b7fc2c9def6f439c69e7739",
        "sha256:ea196b22fd7609a20c51fd091c51b268a64579dd1dab29b16163262ba861db0f"
      ]
    },
    "/usr/lib/sysimage/rpm/rpmdb.sqlite": {
      "content": [
        null,
        null
      ]
    }
  }
}

I beleve the contents of these files is dependent on the contents from ca-certificates RPM package which will vary quite a lot (it is getting updated very often). Do you think it is worth just simply ignoring the contents sha sums? The fact they changed is a proof that the tool did the job. So I am amending a change where I use null for contents of all files.

Aaah figured it out, rpmdb.sqlite must be removed from the diff it is skipped by the tool.

Aaah figured it out, rpmdb.sqlite must be removed from the diff it is skipped by the tool.

Heh, sorry, I was about to add
0001-stages-add-org.osbuild.pki.update-ca-trust.patch.txt as a comment :) Good to go I think once the tests are green, I looked a bit and the update-ca-trust should be reproducible, so this should be fairly stable. But the exact diffs are not improtant here I think so having the null in there is fine (and probably actually better)

Ah of course! Sharp eyes.

Split into two commits
Handling the return value correctly now

Finally all green, rebasing because out of date.


combinator

allow "string" directly in seq, instead of having to include str
allow string directly in alt
automatically add seq to opt? if multiple input

probably a bad idea, as an extra parameter is needed to bind to leaves in syntax tree

skip for now


Docker image not pushed?

Is there an issue with the Docker image?
$ singularity build fmriprep-20.2.1.simg docker://poldracklab/fmriprep:20.2.1
INFO:    Starting build...
FATAL:   While performing build: conveyor failed to get: Error reading manifest 20.2.1 in docker.io/poldracklab/fmriprep: manifest unknown: manifest unknown

we've since shifted over to the nipreps organization, you should be able to access the image via:
docker://nipreps/fmriprep:20.2.1

D'oh. Of course.


only define max msg len if not defined yet

Allows this setting to be redefined without modifying the pubsubclient.h file.

Hi, thanks for this.
I remember when I first wrote the library I couldn't get this to work in a meaningful way -  how a user would structure their sketch to define this value without having to edit the library. It isn't a topic I've revisited since then.
Can you describe a bit about how you'd see this being used in practise?
There are a few other #defines in there that we'd want to expose this way.

I just use a #define in my main file before including PubSubClient.h, so
that when PubSubClient hits its code, its already defined, and therefore
does not change it.
Eric
On Sep 28, 2015 5:13 PM, "knolleary"<EMAIL_ADDRESS>wrote:

Hi, thanks for this.
I remember when I first wrote the library I couldn't get this to work in a
meaningful way - how a user would structure their sketch to define this
value without having to edit the library. It isn't a topic I've revisited
since then.
Can you describe a bit about how you'd see this being used in practise?
There are a few other #defines in there that we'd want to expose this way.
—
Reply to this email directly or view it on GitHub
https://github.com/knolleary/pubsubclient/pull/80#issuecomment-143875985
.

Have you verified that actually works? I tried exactly that at the time, but due to the way the ide pulled out #includes in its preprocessor, you couldn't have a define before an include in your sketch.
If that works for you, then clearly the preprocessor has changed and life gets easier for users who want to modify these defines.

Hmm, yes it does work for me, I'm not using arduino, but esp8266. Same IDE
though. I'll double check again tomorrow and let you know if its working.
Eric
On Sep 28, 2015 6:08 PM, "knolleary"<EMAIL_ADDRESS>wrote:

Have you verified that actually works? I tried exactly that at the time,
but due to the way the ide pulled out #includes in its preprocessor, you
couldn't have a define before an include in your sketch.
If that works for you, then clearly the preprocessor has changed and life
gets easier for users who want to modify these defines.
—
Reply to this email directly or view it on GitHub
https://github.com/knolleary/pubsubclient/pull/80#issuecomment-143887616
.

You know, I thought it was working but I think you're right. It seems the
preprocessor is not picking up the define in the right order.
Eric
On Mon, Sep 28, 2015 at 6:18 PM, Eric de la Chevrotiere <
<EMAIL_ADDRESS>wrote:

Hmm, yes it does work for me, I'm not using arduino, but esp8266. Same IDE
though. I'll double check again tomorrow and let you know if its working.
Eric
On Sep 28, 2015 6:08 PM, "knolleary"<EMAIL_ADDRESS>wrote:

Have you verified that actually works? I tried exactly that at the time,
but due to the way the ide pulled out #includes in its preprocessor, you
couldn't have a define before an include in your sketch.
If that works for you, then clearly the preprocessor has changed and life
gets easier for users who want to modify these defines.
—
Reply to this email directly or view it on GitHub
https://github.com/knolleary/pubsubclient/pull/80#issuecomment-143887616
.


Update documentation for UserActivation endpoint

After a lot of wrangling - I needed to uuid, token and username to make a successful request and receive the 204 response. Please update the documentation to include the uuid.
Many thanks.

Make a PR?

You are welcome to start a "Cookbook" document and include your example there. Would be a great addition.

@michealjroberts I need more info to better understand your problem. It would also be awesome if you shared your solution.

Documentation here: https://djoser.readthedocs.io/en/latest/base_endpoints.html#user-activate is not explicit enough. I can't update the documentation without sufficient knowledge of all the parameters needed. My above experimentation is just that, an experiment with parameters which made it work.

He is saying that the docs for  "User Activate" endpoint is missing the "Method", "Request", and "Response" table that the other endpoints docs have.
It looks like they got accidentally deleted after version 1.6.0


ODS Importer causes Updating Preview spinner forever

ODS Importer causes Updating Preview spinner forever
To Reproduce
Steps to reproduce the behavior:

Extract test file so that it created the "Port of Entry in Texas.ods" file
Create Project with .ods test file
Then click Next

Current Results
Updating Preview spinner shows in middle of screen forever.
Console shows no errors.
Expected Behavior
Some error on the screen if the parser cannot understand the file format or the file contents are not readable.
Screenshots

Versions

Operating System: Windows 10
Browser Version: Firefox latest
JRE or JDK Version: JDK8
OpenRefine: OpenRefine  3.4 Beta SNAPSHOT

Datasets
Port of Entry in Texas.zip
Additional context
Curiously, the count of rows is 1048576 shown in Worksheets to import at the bottom is definitely wrong as there are only 32 rows in the file.  OpenRefine did get the filename correct however :-)

I don't actually think it's "forever." I suspect it's "just" a serious performance regression, perhaps introduced by the update to odftoolkit 0.9 5dcc03cf6211a2bccb1a99f35fb9a41e6ec73daa

Exporter seems to face the same issue. Should I open a new issue @tfmorris ?

Please do, thank you!

Importer is facing the same issue in 3.5.2 [e3efd4e], ignoring the preview and trying to import it nonetheless ignoring empty rows causes openrefine to peg 3 cores at 100%. I'm unsure if 3 cores is the maximum openrefine is capable of allocating or if I need a configuration change to use all my cores.

This could be due to bugs in the odftoolkit library we use, such as this one: https://github.com/tdf/odftoolkit/issues/25

@wetneb that's interesting, because I use LibreOffice to create the odf file (although, it was originally an excel file). If I create a small file with LO the issue is adverted. So it seems that the problem is excel and LO doesn't clean the ods.


Support toasts?

it is look good

Toasts are not part of Bootstrap 4, so we won't be adding those to this package.


403 when trying to download BUILD_DOCKER_URL during build

RancherOS Version: (ros os version)
1.3.0
Where are you running RancherOS? (docker-machine, AWS, GCE, baremetal, etc.)
VirtualBox VM
When cloning the repo (release branch 1.3.0) and running make we get an error when the build is trying to download the docker binary from https://download.docker.com/builds/Linux/x86_64/docker-1.10.3.
Step 48/52 : RUN curl -fL ${!BUILD_DOCKER_URL} > /usr/bin/docker &&     chmod +x /usr/bin/docker
 ---> Running in 5ad4716b4ac0
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 403 Forbidden
> :pThe command '/bin/sh -c curl -fL ${!BUILD_DOCKER_URL} > /usr/bin/docker &&     chmod +x /usr/bin/docker' returned a non-zero code: 22
time="2018-06-13T15:46:37+02:00" level=fatal msg="exit status 22"
Makefile:11: recipe for target 'default' failed
make: *** [default] Error 1

I've tested it with the 1.4.0 release too, with the same result (tries to fetch the same binary).

Upstream issue: https://github.com/docker/for-linux/issues/338
Fixed around half an hour ago.


update library & change the category key across the whole adapter

Description
This PR changes category" : "abc"  to "category" : {"name" : "abc" ,"metadata":null}
Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

@leecalcote @Revolyssup Could you please merge this pr if it's good to go.

The Category is correct. The Metadata looks a bit off, though.


Add mod file

Go modules is becoming the standard way of tracking dependencies, and this project could use one. For one, it seems the import cloud.google.com/go/trace is dead and needs to be tidied up/replaced with cloud.google.com/go/trace.

Abandoned in favour of using https://github.com/luna-duclos/instrumentedsql/


Fix source-build ProdCon auto-update for 2.1-rtm

The executor build has been failing: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/index?buildId=1658438
The "UpdateToRemoteDependencies" task failed unexpectedly.
System.ArgumentException: For 'E:\A\_work\450\s\src/roslyn/', expected 1 build matching 'roslyn', but found 0: ''

Fixed, there's a new update here: https://github.com/dotnet/source-build/pull/495.


REPO UNMAINTAINED (FORKED)

Please open issues up in Fork.  I will start maintaining it there as the author has disappeared.
https://github.com/hammadzz/NavBarDropdownMenu

I will be back next week with Swift 4.2 supported. Stay tuned.

I have just added support for Xcode 10 and Swift 4.2.

@PhamBaTho awesome thanks!


Latency reducer not working despite updated Opcodes

Despite the fact that I've updated my Opcodes, the Latency Mitigation mode doesn't seem to be working- I'm still clipping oGCD's that would've gone through fine in previous versions of XIVAlexander.
My current options are default save for Synchronize Processing to Cooldowns and Animation Locks being turned on (though it behaved the same while turned off) and my Opcodes are, for sake of double checking, as follows:
{
"C2S_ActionRequest": "0x00b8",
"C2S_ActionRequestGroundTargeted": "0x0328",
"S2C_ActionEffect01": "0x021b",
"S2C_ActionEffect08": "0x030e",
"S2C_ActionEffect16": "0x0153",
"S2C_ActionEffect24": "0x00e1",
"S2C_ActionEffect32": "0x0356",
"S2C_ActorCast": "0x006f",
"S2C_ActorControl": "0x02e7",
"S2C_ActorControlSelf": "0x028f",
"S2C_EffectResult5": "0x93db",
"S2C_EffectResult6": "0x93db",
"S2C_EffectResult6Basic": "0x02e7",
"Server_IpRange": "<IP_ADDRESS>/24, <IP_ADDRESS>/24, <IP_ADDRESS>/24, <IP_ADDRESS>/24",
"Server_PortRange": "1025-65535"
}

It's happening the same for me, and I tried really hard to not clip them. Before the 6.1 update was fine though D:

Same here. If it helps, one of the particularly troublesome skills from what I've seen is GNB's Sonic Break. It clips very often now.

Please download the latest release and try again.


Remove embed buttons via CSS

by styling them as invisible.

Closing in favor of https://github.com/stamen/maps.stamen.com/pull/181#


Fix AndroidConfig's TTL not allowing null

Fixes #719
:octocat:

@Cannonb4ll @Glennmen Don't mind the failing integration tests, I have one too brittle test inside, and regular Firebase Service Glitches when testing APNS configs.

If the changes look okay to you, I would merge it and create a new release. If you'd prefer to test the branch first, let me know, then I'll wait 🙏

:sigh: I'm rushing it too much, I need to collect myself a little and then fix it for real

No worries, take your time! As I said, we already covered it by going through each notification and explicitly defining the TTL.

It's not my fault, you were throwing money at me 😂
Jokes aside, the fix is now out with https://github.com/kreait/firebase-php/releases/tag/6.6.1 - let me know if something else doesn't work! 💪
And thank you!

😂 I didn't mean it to speed you up, you were very nice and understanding (and quick). You don't see that often in open-source. 🤝


CLOUDSTACK-8433: Remove awsapi

Following actions from discussions on dev ML regarding removing awsapi and preferring ec2stack. Reference from last PR: https://github.com/apache/cloudstack/pull/44 Opening a new one as master has changed since then and rebasing caused several conflicts so this PR consists of 3 patches (to make rebasing easier).
- Removes awsapi and awsapi-setup
- Removes awsapi packaging rules for debian, centos63, centos7, fedora 20/21
- Removes catalina port 7080 service configs
- Fixes build replace properties for AWSAPILOG
- Removes maven profile for building awsapi and deploying db in developer profile
- Removes awsapi db properties usage across codebase
- Removes references from spring xmls, test cases and TransactionLegacy
- Adds sql command to drop database cloudbridge in schema-451to460-cleanup.sql

CentOS 7, CentOS 6.3, Debian repository: http://packages.bhaisaab.org/cloudstack/nukeawsapi
TravisCI: https://travis-ci.org/apache/cloudstack/builds/60704658

@runseb -  Sure. I was testing 4.5 today and the awsapi service did not work for me, after wasting almost 2 hours to make it work, I tried ec2stack which worked out of the box. I thought it would be a good idea to get rid of it and promote ec2stack :)
I’ve split the changes in 3 commits to make it easier to rebase/merge. I’ll keep this open and hope to merge it next week but am interested in merge it now to avoid rebasing efforts again. If ec2stack will get its own git repo like docs repos or cloudmonkey - does it matter if we merge this now or next week and will this block 4.6 release management?

-Sebastien

On 30 Apr 2015, at 18:12, Rohit Yadav<EMAIL_ADDRESS>wrote:
@runseb - Sure. I was testing 4.5 today and the awsapi service did not work for me, after wasting almost 2 hours to make it work, I tried ec2stack which worked out of the box. I thought it would be a good idea to get rid of it and promote ec2stack :)
I’ve split the changes in 3 commits to make it easier to rebase/merge. I’ll keep this open and hope to merge it next week but am interested in merge it now to avoid rebasing efforts again. If ec2stack will get its own git repo like docs repos or cloudmonkey - does it matter if we merge this now or next week and will this block 4.6 release management?

Nothing technical, just a better process in my view. To be sure we dont have a period with no official ec2 interface.
Lets talk it over a bit and decide mud next week . That should not causr too much rebase headache.
Ok ?

—
Reply to this email directly or view it on GitHub.

Copy that.

@runseb is this good to go now that ec2stack is an apache cloudstack sub-project? I'll rebase and do some tests again if it's okay merge this PR.

let's go for it, there has been enough warning. So if you can rebase, make Travis happy….and squash everything that would be good.

Maybe do it after Daan merges 4.5.1….?

merging 4.5.1 looks like will cause a lot of conflicts; I'm merging it after rebasing and pushing to master and if travis and packaging works

All green, merging now.


Nested Data display

This task is part of Functional Requirement 2 and pertains to story 7

Story 7:
As a user,
I want my data to be outlined under headings,
So that I can find the specific input I'm looking for under more a general heading


Fixed missing title

I've left some other feedback for this topic on the previous PR. I'd include all the changes needed before merging.


Use criterion in curve benchmarks

Builds on https://github.com/AleoHQ/snarkOS/pull/481, only the second commit is new.
Changes the benchmarking setup in curves::benches from bencher to criterion, which is already widely used in benchmarks and provides superior functionalities.
Rationale: there is room for improvement in terms of memory handling across the codebase, and having good benchmarks will aid future changes in that field.

LGTM, amazing updates to benchmarks, thanks @ljedrz !


Brainstorm features

List of features for consideration.

detect and abort jobs running in the background
detect home path environment variable
set default download location
have a production release as opposed to working repo


Update dependency version

Addresses dependabot alerts

@cheenamalhotra  Given that .NET 6 support will be removed, I think it should version 8.0.1

Discarding with dropping of .NET 6


Squiz/ObjectInstantiation: move parse error test to its own file

Description

Suggested changelog entry

N/A
Related issues/external references
See #143
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

[ ] This change is only breaking for integrators, not for external standards or end-users.

[ ] Documentation improvement

PR checklist

[x] I have checked there is no other PR open for the same change.
[x] I have read the Contribution Guidelines.
[x] I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
[ ] I have added tests to cover my changes.
[x] I have verified that the code complies with the projects coding standards.
[ ] [Required for new sniffs] I have added XML documentation for the sniff.

Well spotted @jrfnl, on closer inspection I agree that this test was not intended to check for parse errors / live coding.
It looks like it was intended to check for new when used as a name rather than a keyword (though it may have failed to cover that given the line finishes early causing a parse error). This test for keyword context does indeed seem to be covered by squizlabs/PHP_CodeSniffer#3484 and squizlabs/PHP_CodeSniffer#3608, which added some tests for function names.
I can't see any way that this sniff would need a live coding test case, all the needed context comes before the new keyword so it would not create a false positive.
I'm happy to close this PR and submit another to remove this test from the test case file without the file rename.

I can't see any way that this sniff would need a live coding test case, all the needed context comes before the new keyword so it would not create a false positive.

Just checked the sniff code and I agree with that conclusion.

I'm happy to close this PR and submit another to remove this test from the test case file without the file rename.

Sounds like a good plan!


Error Synchronising Verge qt wallet.

Mac user here.
Installed 3.0 Verge-qt around new years.
I have updated last Verge-Qt wallet two months ago.
Every other update worked great.
Yesterday I have downloaded the latest blockchain from https://verge-blockchain.com/
server1_QT-Wallet_v4.x_Verge-Blockchain_2018-April-10.zip.
Before updating the files, I have backed up the wallet.
What is obvious, there are now two blockchain files in the folder- blk0001 and blk0002.
It took several attempts (was crashing 5 times), and an hour to load the blockchain.
It's been on for hours and still not synchronised.
Wonder what is going on?
Would appreciate any help, because I cannot receive or transfer any XVG at the moment.

Your screenshot says you are on version 2.  You aren’t on the latest version .. 4.0.2

On Apr 11, 2018, at 5:58 AM, kentaur1<EMAIL_ADDRESS>wrote:
Mac user here.
Installed 3.0 Verge-qt around new years.
I have updated last Verge-Qt wallet two months ago.
Every other update worked great.
Yesterday I have downloaded the latest blockchain from https://verge-blockchain.com/
server1_QT-Wallet_v4.x_Verge-Blockchain_2018-April-10.zip.
Before updating the files, I have backed up the wallet.
What is obvious, there are now two blockchain files in the folder- blk0001 and blk0002.
It took several attempts (was crashing 5 times), and an hour to load the blockchain.
It's been on for hours and still not synchronised.
Wonder what is going on?
Would appreciate any help, because I cannot receive or transfer any XVG at the moment.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Thank you @jrsikors.
I updated to version 4, still out of sync.

Should I maintain both blk0001 and blk0002 files?

You need both blk files.  Are you in a country that blocks TOR?  Or an app or ISP?
I would close down QT, delete peers.dat, re-open.. and give it a good 30 mins to try to find connections

On Apr 11, 2018, at 8:11 AM, kentaur1<EMAIL_ADDRESS>wrote:
Thank you @jrsikors.
I updated to version 4, still out of sync.
Should I maintain both blk0001 and blk0002 files?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thank you Jeff. I am in the UK, so far it worked fine.
I'll follow your advice.

I have the same issue. I went onto Telegram XVG-Wallet-Support and had communication with XVGMonk over the last couple of days. We could not work out why it was happening. I followed his instructions at https://medium.com/@xvgmonk/how-to-install-the-latest-verge-qt-wallet-mac-high-sierra-5b5b1f9f46c8 and still did't work. It keeps crashing when I open the app.
My Mac is

Will try your suggestion.

This issue was also raised at https://github.com/vergecurrency/VERGE/issues/704

This is the crash report people seem to be getting on their Mac (this is from mine)

I'm confused -- are you having problems synchronizing or crashing?  If you are having problems with crashing, then please post under #704
@kentaur1 doesn't seem to have issues with crashing.  He's just getting 0 connections... completely different issue i think ?

I see now he did initially mention it crashed a few times, but that could be because he was trying to use an older version.
@noobihodl  , please post your latest screenshot on the #704  since you are specifically having issues with Mac OS crashing.
Let's keep this separate as a "syncing issue" for now
Not all Mac users are having problems.

Ok thanks. Will do.

@kentaur1  let us know how it's going over there, if you ever got any connections.  I know it's late in the UK, so whenever !

will close for now -- feel free to hollar and re-open if you still have problems @kentaur1  .. but i will see all comments on this issue if you post

Hi Jeff, just wanted to update you and check whether this is normal.
I managed to get 16 connections, however I have been uploading the blockchain from scratch for the past two days and only have reached early 2017. The last time I've updated the wallet was two months ago, wasn't expecting I would have to reload blockchain from the beginning.

And apologies for not replying before :)

You mentioned in your initial post you downloaded
Yesterday I have downloaded the latest blockchain from https://verge-blockchain.com/
server1_QT-Wallet_v4.x_Verge-Blockchain_2018-April-10.zip.
that would work fine ... just close down verge-qt , unzip it into your data directory (Application Support/Verge)  , dont overwrite peers.dat , and re-open verge-qt

check out:
https://verge-blockchain.com/howto
(but my special instructions .. dont overwrite your existing peers.dat)

Thanks a lot!
I'll give it a shot.
:)

@kentaur1  just curious -- but how did you end up getting connections?
Did you just leave the wallet open for hours?
Did you just do as i suggested, deleted the peers.dat , and it magically worked?

Hi Jeff, it worked perfectly in the end!! :))
Replaced all the files but peers as you suggested, reopened, left it for an hour to get up to the speed on the blockchain and finally managed to get full sync!
Thanks a lot for your help, I really appreciate it mate!!


Feature/71/offers filtering

Changed offer routes and offer controllers in order to have filtration by categories, subjects and author search by typing his first or last name

removed unnecessary routes, changed aggregate options


e2e torchtune tutorial example

It would be positive to get something a bit more hands on than the current end to end tutorial.
It's not that the end to end "workflow" is incomplete, but personally, it gave me a good intuition about how your framework works but it didn't really feel like after that I could go ahead and play alone, without maybe waiting for people to build end to end projects on top of this.
basic programming steps (not only shell commands, something in the middle of functional programming and OOP) like:

load the base model;
load the dataset we want to fine tune upon, maybe showing how it would be if we wanted to do our own? meaning what the workflow would be starting from a regular pandas dataframe and not necessarily calling a 1 line script;
train/finetune the base model;
save the LoRA adapter;
reload the base model at x precision;
merge the LoRA weights with the base model (this is probably automatically done in the training phase, so ignore if thats the case);
Save the merged model and push to Hugging face Hub (this tbh is already enough what you have on your pages).

personally, i've used different tools for different projects and I think a finetune example mini project that's not shell commands on a-priori assembled files could help users. for example the concept of recipe is very nice and important, it could also enter the end of this possible future tutorial where we save it and maybe even load it into another total different model to try it, if thats even possible?
it doesn't have to have these exact steps, it's just a general idea :)

Thanks @seyeint for creating the issue! This is very valuable feedback. I agree that our current tutorials are a little bit too restricted to CLI commands. We are looking to build out our documentation with meatier examples and I think your suggestion makes a lot of sense.
A couple comments on specific points you raised:

Re saving LoRA adapters and weight merging, we actually do handle both of these already. So when you run a fine-tune, we do the weight merge before saving the checkpoint. That way you get out a fine-tuned checkpoint in the exact same format you started with and you can immediately use it for inference or whatever else. We also separately save just the adapter weights. But as I read through our docs I think this is not super clear and we should definitely emphasize it more.
Re custom datasets, I think this is a really good point. We have a datasets tutorial (and are currently making updates to it to better emphasize preparation of a custom dataset), but I agree it'd be useful for us to actually demonstrate this as part of the end-to-end flow since it's something most people will have to deal with.
Re reloading the model at a different precision, we do give an example of quantizing the fine-tuned model towards the end of the tutorial. Do you feel this is unclear or could use more detail? Or is there something else entirely you have in mind here? Would love to hear your thoughts on how we can make this part clearer.

I have some other thoughts here but will leave it there for now. Let me know if this makes sense or you disagree with any of the points, thanks!

so I would say that regarding the capabilities of your framework, I'm already predicting you have everything we need, but the first Re point you made is good to hear. Every one of my points was more focused on the ideas for the tutorial and not so much me asking if your amazing framework was capable of reaching it.
regarding your last point, you're right and I would also say that I was communicating more about what could be on that tutorial (which obviously would have a lot of overlap with your end to end workflow that is already in place, but you really nailed it in the first phrase when you said "restricted to CLI commands". I think it makes total sense for the docs to start this way and evolve to more meatier as they evolve and eventually I'm not really imagining anything else needed.
To me, and obviously this goes from person to person, there's an asymmetry between profiles who are really into the practical level of fine tuning through other frameworks that maybe don't even have that great of documentation, but just the fact that because they were the go-to earlier than torch.tune, it's really easy for me to just navigate implementations of individuals and even mediums end to end pipelines that really do justice to the simplicity that is in fine tuning.
My "fitness" evaluation for your docs would be:
if anyone with decent field experience (who maybe worked with DL but not so much the fine tuning of LLMs), whether more theoretical or practical is able to open their IDE and create a small project that involves tuning a network with a dataframe of their choice, evaluate (if possible in their case), messing with some mechanics of the LoRA class they applied, save the recipe and feel prepared to use that same recipe for other future models... then it means that the docs are immaculate.

Yeah, I'd love to see that aswell, I'm a little stumped now looking at the E2E example and having to somehow dockerize it and have this run in a CI pipeline.

@AsymptoticBrain thanks for the feedback here. Admittedly we do not have anything on docker in our docs and this is something we're hoping to improve upon. Personally I think your suggestion would merit its own standalone documentation, as it is kind of disjoint from the E2E tutorial, which is more focused on the library's functionality rather than the engineering work needed to integrate this into a production workflow.
In the meantime, @tcapelle had put together a Docker and shared it here, this may be useful as a starting point.
(Obviously pointing to a comment on an issue is not addressing the lack of proper documentation, but at least some stopgap to hopefully help you out in the short-term.) Regarding CI pipelines, can you give a bit more detail here? What sort of documentation would you find useful?

Oh no that's really helpful regardless 😊 when it comes to CI/CD pipelines yeah it's more of how we have our MLops setup, I think many are in a position where we are behind firewalls and use sensitive data so we need to have all that data and models local. I'll play around a little with it some if I can get the docker working and come back to you.

@SalmanMohammadi will the custom recipe tutorial in #1196 address this?


Add missing translations for Edit RKE2 tabs

This adds some missing translations for the tabs in the RKE2 edit component. Tabs that were missing translations were Add Ons and Advanced.

I was just in this section of the app and noticed that we were missing quite a few translations. I didn't do a review of the entire component, as it's quite large. I thought that it was best to correct the problem while I was looking at it.

@catherineluse I came to merge my changes and realized that I had some conflicts with other changes made to the translations file. Can you spot check this change one more time before I move forward with the merge?


Argument count variable for exec command context

There should be a variable %argc available in the context of an executed script via the exec command in order to check how many arguments are provided to the script.

Resolved here: 5ed4101


Fix documentation build

Documentation build is failing (https://github.com/DeltaRCM/pyDeltaRCM/actions/runs/4298769386/jobs/7493268323).
Looks like this is due to a link that is perceived as "broken": https://github.com/DeltaRCM/pyDeltaRCM/actions/runs/4298769386/jobs/7493268323#step:6:255
This is the link: https://doi.org/10.1086/626637 which appears to redirect to https://www.journals.uchicago.edu/doi/10.1086/626637
Suggestion is to just do a bit of investigation and testing locally, but simplest solution may be to edit the conf.py file and have it "ignore" that URL: https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-linkcheck_ignore

Closed by #268


Refactor Account Attributes code

Definition of Ready

[ ] Does this meet the INVEST criteria?
[ ] Does this have a clearly defined user?
[ ] Does this have an estimate?
[ ] Does this have acceptance criteria?
[ ] Does this have sufficient context for the specific functionality being developed (design, business rules, etc.)
[ ] Does this have a dev link been provided in the design?
[ ] Is this traceable to a feature, epic, or PI?

User Story
As a
I want
So that
Acceptance Criteria
Given
When
Then
Development Notes
Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)
refactor code for Account Attributes, Allowance Holdings, and Facility Unit Attributes to use getManyAndCount() instead of getMany() and getCount(). This will help increase performance of those endpoints. We've made the changes in other endpoints but noticed it wasn't done for these (edited)
Testing
Test Case:
Tester:
Definition of Done

[ ] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[ ] Has the code been unit tested and peer reviewed?
[ ] Have the functional tests been executed?
[ ] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Is the user story ready to be deployed to the test/staging environments?

Team needs more clarification from @jwhitehead77.  Justin will reach out to Jason for more information

Pull Request
Account Attributes, Allowance Holdings: - https://github.com/US-EPA-CAMD/easey-account-api/pull/141
Facility Unit Attributes : - https://github.com/US-EPA-CAMD/easey-facilities-api/pull/149


Add expire capability for SET calls to Redis

Currently, there is no capability to configure an expiration for records pushed to Redis by this connector. It will be nice to have a config to set the expire time for the records.
In other words, instead of SET key value, it should call SET key value  [EX seconds|PX milliseconds] where the time duration is configurable with the json file passed to the connector.

@uzunbaz What are you thinking? Just a configuration setting with the number of milliseconds until an expiration and then applying that to all SET calls?

Yes, something like that. I checked the source code briefly and looks like MSET async command is used for setting the keys. However, Redis MSET command does not take any expiration ttl as a parameter (there are tickets/discussions that requires this, e.g. : https://github.com/antirez/redis/issues/5867)
So, we can either use SET EX instead of MSET or have another call for expiration after MSET, lettuce api has a function for expire: AbstractRedisAsyncCommands.expire(...) (link to lettuce source).

Hi, are there any news about this enhancement?
It would be really helpfull to have a way to set the expire time on the keys.

Hi,
Is this enhancement implemented or planned? It would be very helpful to have this for cache maintenance.

Bumping this up, having this functionality would enable our use-case for caching. Much needed please!

Would also love to have this implemented. Perhaps even with the possibility to set it dynamically with a kafka-header? Which could be added to the sink-configuration?

Ignoring the fact that we need to use SET instead of MSET how would we want to calculate the the value for EX? As a static config setting? So something like EX 60 with 60 being pulled from config. Another alternative would be EXAT 19871341 calculated based on the timestamp?

Hi, was this enhancement implemented?


Update plan-and-design.qmd

Link to new topic 'data management section' instead of old text about data management paragraph.

Thanks @Jolien-S! Did you already migrate the "Data management paragraph" into a separate topic page somewhere?
I am also happy to do it on this branch 👍

Oh I now see the topic is introduced in #132. I will update this pull request after I go through that one.

Tracking an issue in #146 before I can work on this. Considering this blocked until that is fixed.


x/tools/gopls: loading workspace hangs on v0.8.1, works on v0.8.0

gopls version
golang.org/x/tools/gopls v0.8.1
go env
go1.18
What did you do? What did you expect to see? What did you see instead?
gopls hangs on "loading workspace loading packages" with high cpu usage indefinitely on opening project
Editor and settings
VSCode
Logs

please fill out the issue template properly, there are instructions on commands to run to capture important debugging information.

Hi. I closed hoping this would resolve in the next few releases but v0.8.3 still has the same issue.
I work in a large monorepo (this could very well be an issue with our configuration) and was hesitant to report debugging info but I will report back

gopls -v version
golang.org/x/tools/gopls v0.8.3
<EMAIL_ADDRESS>h1:Mxm94ix8oSARQ6svioO6SxKEYWT/VCP54/448LOHzrk=
<EMAIL_ADDRESS>h1:dtDWrepsVPfW9H/4y7dDgFc2MBUSeJhlaDtK13CxFlU=
<EMAIL_ADDRESS>h1:81/ik6ipDQS2aGcBfIN5dHDB36BwrStyeAQquSYCV4o=
<EMAIL_ADDRESS>h1:we8PVUC3FE2uYfodKH/nBHMSetSfHDR6scGdBi+erh0=
<EMAIL_ADDRESS>h1:qyrTQ++p1afMkO4DPEeLGq/3oTsdlvdH4vqZUBWzUKM=
<EMAIL_ADDRESS>h1:kQgndtyPBW/JIYERgdxfwMYh3AVStj88WQTlNDi2a+o=
<EMAIL_ADDRESS>h1:5KslGYwFpkhGh+Q16bwMP3cOontH8FOep7tGV86Y7SQ=
<EMAIL_ADDRESS>h1:rm+CHSpPEEW2IsXUib1ThaHIjuBVZjxNgSKmBLFfD4c=
<EMAIL_ADDRESS>h1:olpwvP2KacW1ZWvsR7uQhoyTYvKAupfQrRGBFM352Gk=
<EMAIL_ADDRESS>h1:rYiuK/jn6TCxjAq1hQ6MR6pgOeP3A5gIHDxgrQ8Vbys=
<EMAIL_ADDRESS>h1:9dMzk88fnONra7zrEalqkRMGa9jMGf9B5mdzhYVyI28=
<EMAIL_ADDRESS>h1:go1bK/D/BFZV2I8cIQd1NKEZ+0owSTG1fDTci4IqFcE=
<EMAIL_ADDRESS>h1:2LdYUZ7CIxnYgskbUZfY7FPggmqnh6shBqfWa8Tn3XU=
<EMAIL_ADDRESS>h1:kTojdZo9AcEYbQYhGuLf/zszYthRdhDNDUi2JKTxas4=
<EMAIL_ADDRESS>h1:tzxjVAj+wSBmDcF6zBB7/myTy3gX9xvi8Tyr28AuQgc=
go: go1.18

go env
USER@USER-XXX % go env
GO111MODULE="off"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/USER/Library/Caches/go-build"
GOENV="/Users/USER/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/USER/REPONAME/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/USER/REPONAME"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/private/var/tmp/_bazel_USER/39f85239c7a58bb315210c358a75a4cd/external/go_sdk"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/private/var/tmp/_bazel_USER/39f85239c7a58bb315210c358a75a4cd/external/go_sdk/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.18"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/1v/19_n0_c57fgbpbd2rzzf4zt80000gn/T/go-build1587897350=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

open monorepo in vscode
vscode hangs on "Setting up workspace: Loading packages..." with go and gopls processes continually running

vscode settings.json
{
    "files.watcherExclude": {
        "bazel-*": true,
        "pkg*": true,
    },
    "files.exclude": {
        "bazel-*": true,
        "pkg*": true,
    },
    "go.inferGopath": false,
    "go.gopath": "/${env:HOME}/REPONAME",
    "go.goroot": "~/REPONAME/bazel-REPONAME/external/go_sdk",
    "go.toolsEnvVars": {
        "GO111MODULE": "off"
    },
    "go.buildOnSave": "workspace",
    "go.vetOnSave": "workspace",
    "go.buildFlags": [],
    "go.lintFlags": [],
    "go.vetFlags": [],
    "go.coverOnSave": false,
    "go.useCodeSnippetsOnFunctionSuggest": false,
    "go.formatTool": "goimports",
    "go.autocompleteUnimportedPackages": true,
    "go.useLanguageServer": true,
    "go.languageServerFlags": [
        "-logfile", "/tmp/gopls.log",
        "-rpc.trace"
    ],
    "launch": {
        "version": "0.2.0",
        "configurations": [
        {
            "name": "Go: Connect to server",
            "type": "go",
            "request": "attach",
            "debugAdapter": "dlv-dap",
            "mode": "remote",
            "port": 2345,
            "host": "<IP_ADDRESS>",
            "trace": "info",
            "substitutePath": [
                {
                    "from": "${workspaceFolder}/src",
                    "to": "src"
                },
                {
                    "from": "${workspaceFolder}/bazel-REPONAME/external/",
                    "to": "external/"
                },
                {
                     "from": "${workspaceFolder}/bazel-out/",
                     "to": "bazel-out/"
                },
                {
                    "from": "${workspaceFolder}/bazel-REPONAME/external/go_sdk",
                    "to": "GOROOT/"
                }
            ]
        }
        ]
    }
}

Hi, sorry we missed this after it was reopened.
Looking at the commits between<EMAIL_ADDRESS>and<EMAIL_ADDRESS>I'd love to know which caused the regression you observed; there are not a lot of likely candidates.
Would you be willing to bisect this problem? If so, it seems likely that we could fix it.
A few follow-up questions:

Can you try building<EMAIL_ADDRESS>with go 1.17? (you can use https://pkg.go.dev/golang.org/dl and then go1.17.10 install<EMAIL_ADDRESS>Are you using bazel?
Are you using go.work files?
Approximately how many files do you have in your workspace?

Thanks!

@findleyr  I traced the breaking change to commit b59c441bdb9d7533db2a3e22af2306a7e733e80b line 886
Checking out this commit and reverting the strings.TrimRight addition (see screenshot) and gopls successfully loads

Interestingly, checking out latest as of right now 654a14b5274602698564a5e9710c0778be664c7a still hangs, but is resolved by apply the above change. However, the applying this change to v0.8.4 tag release does not fix the issue.

we are using bazel but have an internal tool to setup the gopath correctly for each project directory (vanilla go tools generally work)

again, this may be an issue with my specific configuration. But I have yet to find a solution

Thanks for following up (and sorry for the slow response, I've recently returned from vacation).
Do you have any go.work or go.mod file in a parent directory of your workspace?

@geitir can you please double check if there is any go.work or go.mod file around even though you are using bazel?
And if not, is it possible to share your gopls trace? https://github.com/golang/vscode-go/wiki/troubleshooting#collect-gopls-information
Without repro examples or trace, I am not sure if it makes sense to keep this issue open.

Closing as unactionable. Please try the latest gopls and open a new issue if you are still experiencing this problem.


Issue with case

Hi,
I'm having an issue when formatting a case.
This code

is transformed to

It throws an error,

I don't know if I'm doing something wrong or if it is a bug,
Thanks!

I'll look into it, thank you for notifying me 👍


Codeunit 6500 new event on procedure InsertReservEntryForSalesLine

Hi,
We need a new event on Codeunit 6500 procedure InsertReservEntryForSalesLine :
 if QtyBase = 0 then
            exit;

        with ReservEntry do begin
            // >New event
            OnBeforeInitReservEntry(ItemLedgEntryBuf, SalesLine);
            // < New event
            InitReservEntry(ReservEntry, ItemLedgEntryBuf, QtyBase, SalesLine."Shipment Date", EntriesExist);
            SetSource(
              DATABASE::"Sales Line", SalesLine."Document Type".AsInteger(), SalesLine."Document No.", SalesLine."Line No.", '', 0);
            if SalesLine."Document Type" in [SalesLine."Document Type"::Order, SalesLine."Document Type"::"Return Order"] then
                "Reservation Status" := "Reservation Status"::Surplus
            else

.....
[IntegrationEvent(false, false)]
    local procedure OnBeforeInitReservEntry(ItemLedgEntryBuf: Record "Item Ledger Entry"; SalesLine: Record "Sales Line");
    begin
    end;
....

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Synthia -> Cityscapes pre-trained model

Hi, can you share the SYNTHIA to Cityscapes pre-trained model to replicate the results of the paper? Thank you for the great work!

Thanks @VitorGuizilini-TRI
I have include the SYNTHIA-to-Cityscpaes in the link.
You may download from https://drive.google.com/u/2/uc?id=1smh1sbOutJwhrfK8dk-tNvonc0HLaSsw&export=download
If any questions, please do not hesitate to ask me.

Note that the evaluation code I provided for SYNTHIA-to-Cityscapes is still average the IoU by divide 19.
Actually, you need to re-calculate the value by divide 16. There are only 16 shared classes for SYNTHIA-to-Cityscapes.

Can you give detailed description for the pretrained model and provide a readable name? 😕
I'm so confused with SY_1280x640_restore_ft_GN_batchsize5_512x256_pp_ms_me0_classbalance7_kl0.1_lr1_drop0.1_seg0.5_fp16_BN_255_Noaug and SY_SE_GN_batchsize1_1024x512_pp_ms_me0_classbalance7_kl0.1_lr1_drop0.1_seg0, and which is for GTAV --> Cityscapes and SYNTHIA --> Cityscapes separately?


Grafana to Node-Red in docker

Hi there I've for a Docker stack with Grafana and Node-Red containers, is this still a live project as I would very much like to use if it is.
I've got it installed in Grafana v10.2.0 and I've tried various combinations of the settings and I can't get it to output to Node-Red, I've proven the input to Node-Red with Postman.

we've resolved this using the new canvas panel and enabling CORS in node-red


ci/automatic building

This automatically builds the FluCoMa externals on a macos runner with github actions on each commit to main. This will help to automatically alleviate any issues where relatively canon build processes with cmake are broken by rogue commits or edits to the cmake configuration. Could potentially just run on tagged commits or to check PR's.

Further to this, we can also use this action to eventually build and publish nightly releases as well as stable releases with tagged commits.

Nice. What's a sensible way to test this?
Longer term, it would indeed be nice to be able produce releases this way, although there's still a certain amount of human tidying up that has to be done (test-only externals have to be removed, for instance).

To test that the automatic building works? Not sure. I can send proof of it working on my fork? I'm not sure how to run an action on a PR branch...
Right now I flew a bit closer to the sun and broke it by trying to run max patches headlessly as part of the build process. I'll dial it back to the state in which it compiled the package successfully.

You can see on my fork the action running.
https://github.com/jamesb93/flucoma-max/runs/3609550172?check_suite_focus=true
We could tune it to be more selective, doing certain things on tagged commits or perhaps only running on PRs. Anyway, there is no urgency in closing this off and I intended to leave it here dangling so we can come back around to this when there are less workshop-y things pressing :)

This now builds but I haven't tested building with -DDOCS=ON. That's the next stage.

At the moment this works but does not work if I compile with -DDOCS=ON for various reasons (I think python environments and such are making cmake sad). My strategy around this is to add another build component that will make the max references on Linux and then compile the results at the output.

This is now finished.
https://github.com/jamesb93/flucoma-max/releases
At the moment its using an ad-hoc branch to pull down core where BLAS is not used in Eigen (which is a problem across all CCE's actually). This should be solved in a coming PR for core which I will then reflect in the CI to use the tip of dev rather than my branch (fix/blas-compilation-settings)

Question: what is patchers/write-test.maxpat for? Should it actually be in version control?
That notwithstanding, we should merge asap after the BLAS PR is in.

Oops. I was a bad boy, testing out if we could launch patchers headlessly for some kind of egregious Max-based testing. I'll git rm this.

Question: what is patchers/write-test.maxpat for? Should it actually be in version control?
That notwithstanding, we should merge asap after the BLAS PR is in.

I've removed it from vc, so once https://github.com/flucoma/flucoma-core/pull/67 is in we're good to go.


Easier Admin Request Decisions

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
I would like a couple things added to the Requests admin page:

movie/show posters
clickable links to open up the Petio movie/show page to read more about the item being requested
After clicking edit, the default profile/location should be pre-selected for Radarr/Sonarr
one-click approve button (next to Edit) that will always use the default profile/location
one-click deny button (next to Edit)

Describe alternatives you've considered
Ombi (what I use now)

I agree with the link to movie data, and the default profile being used, the one click approve deny isn't something I want to include at this time.

Partially addressed in upcoming patch
Movie / show posters (only on dashboard not on request table)
Links from table item name and dashboard request card now link to media
Default profile / filter now applied as default on request edit
One clicks, not included, I can see the benefit but for now they're not included. May revisit this later, just adds some complexity for a quick shortcut


Added Mickey B Fresh Flare address.

Added Mickey B Fresh Flare address.

Already updated everything in PR 224.


How to implement a one-time purchase that expires e.g. "No ads for 3 months"?

I am about to do my first in-app purchase, and I would like it to be a one-time purchase that expires after a few months.
I am trying to understand the differences between iOS/Android to do this as smoothly as possible.
Based on what I've read, Android does not have the idea of a "Non-renewable subscription" like iOS https://www.raywenderlich.com/147629/in-app-purchases-non-renewing-subscriptions-tutorial, and Android subscriptions only auto-renew. Android does however, have the idea of purchases that can be consumed via method InAppBilling.consumePurchase(productId), whereas I think iOS consumables get consumed immediately after purchasing?
Does this mean that I should implement this using a one-time purchase, then in my React Native code, compare the purchaseDate of the transaction using InAppBilling.getPurchaseTransactionDetails(productId)  to the current date to see if 3 months have passed? If so, THEN consume the purchase?
Also, during testing, I realized InAppBilling.getPurchaseTransactionDetails(productId) gives me a blank purchaseTime. Does this only show up with real purchases? What is the format of purchaseTime?
I'd just like some advice and confirmation if I'm on the right track or not.

Hi @booboothefool.
I haven't worked any with consuming purchases, so I mostly rely on others testing here. But that does seem like the way to do it. Although it isn't a very secure measure, since consumption is controlled from the app. So it might also be a good idea to check a server-side API for whatever resource the person is purchasing.
As far as purchaseTime, it is just taken from the PurchaseData object. I am unsure if it should be blank or not, I have never used it. I would recommend testing with a real product here.


feat: Create default shadcn configuration inside packages/ui

Describe the feature you'd like to request
When i'm running pnpm run add (some component) inside packages/ui folder, shadcn gives me this error:

Configuration is missing. Please run init to create a components.json file.

And then im running pnpm dlx shadcn-ui init it creates another one tailwind.config.js that isn't normal.
Describe the solution you'd like to see
Maybe you need to provide default shadcn configuration inside packages/ui
Additional information
No response

#956

Hey i have a working version here: https://github.com/t3-oss/create-t3-turbo/pull/957 @juliusmarminge, please take a look @trevorpfiz
no path modification in the app for the component, i only modified the one for the lib

Hey i have a working version here: #957 @juliusmarminge, please take a look @trevorpfiz
no path modification in the app for the components, i only modified the path for the lib

@kwiss I am getting errors with the paths. I am pretty sure you have to modify the tsconfig.json as mentioned here https://github.com/dan5py/turborepo-shadcn-ui/issues/20.

Oh my bad i didn't changed the import for the lib everywhere in the app, but i should work without any other modification, i use it like that in another repository, i'll fix my pull request soon

Cool workaround with the self-referencing!

Is the problem solved or not? Because I still have the same error.


Add evaluation tutorial for Haystack 2.0

closes https://github.com/deepset-ai/haystack/issues/6789

Thank you for opening the PR @julian-risch. It's a great tutorial that makes everything super easy for beginners. I left some minor comments 🙌

Can we please change the number of this to 35 since 34 is already assigned to the extractive qa article? https://www.notion.so/deepsetai/2-0-Tutorials-2b25ff372616414c9ba157b37d57113e

Change number from 34 to 35

Done 👍


remote-config- added support for 'validate_only'

to be able to validate the new config before publishing it
visual studio code screwed up formatting, not sure if that's important or not.

@inteist thanks for the PR, I'll apply it in a follow up PR if you are not able to complete this one.

@inteist I'll close this PR since it is in conflict with master. Feel free to rebase and submit a subsequent PR.


Proxy support

How webtorrent work if the browser use HTTP/SOCKS proxy that only serve TCP connection?
DHT requires UDP.

In the browser, WebTorrent uses WebRTC, which is different than TCP or UDP. You can learn more here: https://webtorrent.io/faq


Refactored ASN.1 codecs

Encoder can operate on pure-Python values
Codecs take **options influencing their operation
BitString decoder optimized for better performance

Codecov Report

Merging #83 into master will decrease coverage by 1.13%.
The diff coverage is 80.63%.

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   86.53%   85.39%   -1.14%
==========================================
  Files          28       29       +1
  Lines        3803     3986     +183
==========================================
+ Hits         3291     3404     +113
- Misses        512      582      +70

Impacted Files
Coverage Δ

pyasn1/type/base.py
86.25% <ø> (+0.83%)
:arrow_up:

pyasn1/debug.py
93.5% <ø> (ø)
:arrow_up:

pyasn1/codec/cer/decoder.py
93.75% <100%> (ø)
:arrow_up:

pyasn1/type/useful.py
82.97% <100%> (ø)
:arrow_up:

pyasn1/__init__.py
75% <100%> (ø)
:arrow_up:

pyasn1/codec/der/encoder.py
80.76% <64.28%> (-19.24%)
:arrow_down:

pyasn1/type/opentype.py
71.42% <71.42%> (ø)

pyasn1/codec/ber/decoder.py
86.91% <74.46%> (-2.16%)
:arrow_down:

pyasn1/codec/cer/encoder.py
83.46% <77.14%> (-12.84%)
:arrow_down:

pyasn1/type/namedtype.py
85.25% <84.61%> (-0.26%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 136f9e7...e8a116c. Read the comment docs.


#29 making all the table/column names lowercase

I'll look at this and try it out this afternoon. This is a good improvement though!

Looks good, we'll have to drop the database to load this up. Maybe we'll have the dev database tomorrow and can start fresh on both of those?


Add a chapter on performance and productivity improvement

Signed-off-by: Hartanto Ario Widjaya<EMAIL_ADDRESS>This PR adds a chapter on performance and productivity improvement in terms of optimal coding style, efficient data types usage, efficient table-handling, and the use of copybooks.
Contents are adapted from the Programming Guide.
Currently there are no labs for the chapter.

Very nice @tanto259. After reviewing the chapter, my opinion is that it should be moved to the Advanced Course. Copybooks in terms of code reuse can be part of the introductory course but the details around performance and optimization seem like an advanced topic. I also believe we need to add a lab around copybooks.

Okay, I'll move the chapter to Course 2, and I'll find a way to put the copybooks in Course 1. Meanwhile, I'll set this PR as a draft pending other topics (e.g. compiler and language environment) which can supplement this chapter further.

The chapter has been moved to Course 2, and a short section on compiler options is added.


Duplicate releases

Latest release script seems to add a new release entry & commit every time the CI Job runs - even if the release already exists:

Dang I saw this with 8.9.0 and thought it was fixed but 8.9.1 was going to be the test, and it is/was. Not fixed. On it


sfsu status --ignore-held still displays held packages

Version
v1.11.0
Additional context
I really appreciate your extremely fast implementation of the requested feature.
A screenshot of the issue:

Please let me know if you need further information.
Thank you.

Should be fixed in #713


Uglify2 vs uib-datepicker-popup

There seems to be a problem with uib-datepicker-popup vs uglify2.
Affected seems to be version 0.14.2 and file ui-bootstrap.tpls.js. If I use ui-bootstrap.tpls.min.js and run my project and this file via uglify process, everything works as expected.
 When I change it to false, again everything works as expected.
Does anybody encountered the same problem or has some more additional info about this ?
Work around
1.) in your uglify2 config set sequences: false
2.) use ui-bootstrap.tpls.min.js insted as ui-bootstrap.tpls.js

Could you please give more information? What kind of error you get? Does it uglify? or it fails upon usage?

Yes it uglifys with no problems
Yes it fails upon usage with no errros

Currently I have no more info, I had to solve the problem in our app in no time and used workaround 2.) I guess I will have more info during the week.

What type of error is it? Where is the error? This is the basic information we need before we can even investigate this.

It seems like datepicker is not propagated to ng-model correctly. When I click on the dates in picker,  picker stays opened and nothing seems to happen (ng-model is not changed).
Anyway I created plnkr: http://plnkr.co/edit/0Lh5kErDJ90KxUUxCEJJ?p=preview
I isolated minified angular-bootstrap from my distribution build and used the minified code in plnkr; everything seems to be working fine here so the problem is more elusive that I originally thought.
I suspected the reason to be new angular-bootstrap 0.14.x, because everything works fine when downgraded to 0.13.x or when using ui-bootstrap.tpls.min.js.
It seems problem may be in my compile process - when building ui-boostrap (not minified version) with number of other 3rd party libraries. I am using grunt-contrib-uglify=0.9.2

Sorry, got lost. The plunker seems to be working right?
and I don't think that an uglifier can modify a library behavior without giving errors.
Seems like the issue is in your end.

Sorry, got lost. The plunker seems to be working right?
Yes it does

Seems like the issue is in your end.
Seems like it. I will investigate further

Closing as it seems like a user problem & not a library issue.


Should we introduce an Option-term into the AST?

Version: (e.g. 2.3.3)
Module: (e.g. quill-core)
Database: (e.g. all)
Opening up an issue so that we can discuss whether as a result of introducing flatMap, flatten, and getOrElse terms into the AST in #1044, it makes sense to introduce an Optional(...) kind of term into the AST as a 1st class citizen. Should scala.None be parsed to a AST-specific None-type e.g. NoneOption as @fwbrasil suggested? If so, should we introduce an AST-specific Some-type called Optional(ast) or SomeOption(ast)?
Also closely related is #1053 in which I suggest that we introduce null checks for Option.map and Option.flatMap because this is the only way to ensure that CASE WHEN ... statements in nullable SQL fields (i.e. one defined as a Quill case class(nullableField:Some[T]) work properly.
Would appreciate any discussion and feedback. Thanks.
@getquill/maintainers

Closed via #1302


add testnet mode

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
#1139
✅ Checklist

[x] I have tested all my changes.

🕵♂ Notes for Code Reviewer
This way we can test onboarding flows etc
🙈 Screenshots

👯♀ Paired with

This will probably conflict with Gery's changes to the settings storage.

I need this now so need to merge it, to debug the onboarding bug


Toggle map overlays with global vars

Implement convenience methods in the SDK to toggle map labels (none, some, more) and overlays (i.e. transit) using stylesheet global variables.

Toggle only the overlays for this ticket.
Toggling labels currently requires switching scene files (which in most cases are spread across several repos). When support for themes is added, we can use this to toggle label variants. Relevant ticket for this work: https://github.com/mapzen/android/issues/372


[DOC] Add comparison with power iteration in eigenvalue example

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
56 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-3.7%) to 88.808%

Files with Coverage Reduction
New Missed Lines
%

curvlinops/examples/utils.py
10
31.25%

curvlinops/fisher.py
46
26.47%

Totals

Change from base Build<PHONE_NUMBER>3:
-3.7%

Covered Lines:
1349

Relevant Lines:
1519

💛  - Coveralls


instanbul and mocha mocha.opts

I do use mocha.opts file not in a test (default) directory mocha expect it to see. But with --opts path/to/mocha.opts flag for mocha testing.
Istanbul does not work with mocha in this case.

What is the exact command you are using to run istanbul?

Here is a full stack:
./node_modules/.bin/istanbul cover ./node_modules/.bin/_mocha --opts www/js/test-utils/mocha.opts www/js/test/ -- -R spec
No coverage information was collected, exit without writing coverage information
/usr/share/nginx/yii-version/www/js/test-utils/mocha.opts:1
(function (exports, require, module, __filename, __dirname) { --require www/js/test-utils/init.js
                                                                        ^^^

SyntaxError: Unexpected identifier
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Module.replacementCompile (/usr/share/nginx/yii-version/node_modules/append-transform/index.js:63:13)
    at Module._extensions..js (module.js:422:10)
    at Object.<anonymous> (/usr/share/nginx/yii-version/node_modules/append-transform/index.js:67:4)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:16:19)
    at /usr/share/nginx/yii-version/node_modules/mocha/lib/mocha.js:219:27
    at Array.forEach (native)
    at Mocha.loadFiles (/usr/share/nginx/yii-version/node_modules/mocha/lib/mocha.js:216:14)
    at Mocha.run (/usr/share/nginx/yii-version/node_modules/mocha/lib/mocha.js:468:10)
    at Object.<anonymous> (/usr/share/nginx/yii-version/node_modules/mocha/bin/_mocha:403:18)
    at Module._compile (module.js:413:34)
    at Module.replacementCompile (/usr/share/nginx/yii-version/node_modules/append-transform/index.js:63:13)
    at Module._extensions..js (module.js:422:10)
    at Object.<anonymous> (/usr/share/nginx/yii-version/node_modules/append-transform/index.js:67:4)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Function.Module.runMain (module.js:447:10)
    at runFn (/usr/share/nginx/yii-version/node_modules/istanbul/lib/command/cover.js:126:16)
    at /usr/share/nginx/yii-version/node_modules/istanbul/lib/command/cover.js:146:9
    at /usr/share/nginx/yii-version/node_modules/istanbul-api/lib/run-cover.js:187:16
    at /usr/share/nginx/yii-version/node_modules/istanbul-api/lib/file-matcher.js:69:16
    at /usr/share/nginx/yii-version/node_modules/istanbul-api/node_modules/async/lib/async.js:52:16
    at /usr/share/nginx/yii-version/node_modules/istanbul-api/node_modules/async/lib/async.js:361:13
    at /usr/share/nginx/yii-version/node_modules/istanbul-api/node_modules/async/lib/async.js:52:16
    at done (/usr/share/nginx/yii-version/node_modules/istanbul-api/node_modules/async/lib/async.js:246:17)
    at /usr/share/nginx/yii-version/node_modules/istanbul-api/node_modules/async/lib/async.js:44:16
    at /usr/share/nginx/yii-version/node_modules/istanbul-api/node_modules/async/lib/async.js:358:17
    at LOOP (fs.js:1609:14)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

My mocha.opts
--require www/js/test-utils/init.js
--compilers js:babel-core/register
--recursive

Nice, thanks!  :+1:
You have --opts before --, so I'm pretty sure Istanbul is trying to interpret that flag and Mocha isn't seeing it (or the path to the test files) at all.
Try this:
./node_modules/.bin/istanbul cover ./node_modules/.bin/_mocha -- --opts www/js/test-utils/mocha.opts www/js/test/ -R spec

yes thank you very much. Could you explain what -- means here ?

Great! You're welcome :grin:
-- is mentioned in the readme. It is also demonstrated by help:
> istanbul help cover

Usage: istanbul cover [<options>] <executable-js-file-or-command> [-- <arguments-to-jsfile>]

-- is used to split up the CLI flags that are for istanbul and the flags that are for whatever application is running the tests (in this case, _mocha).

I'm on windows 7 home working through a Lynda.com course called Node.JS Essentials. When running:
istanbul cover _mocha
yields:

C:\Lynda\Alex Banks - Nodejs Essential Training\Ex_Files_Nodejs_EssT\Exercise Files\Ch10\10_07\start

istanbul cover _mocha
No coverage information was collected, exit without writing coverage information
C:\Users\Suleman\AppData\Roaming\nvm\v7.4.0_mocha.CMD:1
(function (exports, require, module, __filename, __dirname) { @IF EXIST "%~dp0\node.exe" (
^
SyntaxError: Invalid or unexpected token
at Object.exports.runInThisContext (vm.js:78:16)
at Module._compile (module.js:543:28)
at Object.Module._extensions..js (module.js:580:10)
at Object.Module._extensions.(anonymous function) [as .js] (C:\Users\Suleman\AppData\Roaming\nvm
\v7.4.0\node_modules\istanbul\lib\hook.js:109:37)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3)
at Function.Module.runMain (module.js:605:10)
at runFn (C:\Users\Suleman\AppData\Roaming\nvm\v7.4.0\node_modules\istanbul\lib\command\common\r
un-with-cover.js:122:16)
at C:\Users\Suleman\AppData\Roaming\nvm\v7.4.0\node_modules\istanbul\lib\command\common\run-with
-cover.js:251:17

I've looked online and they advise using<EMAIL_ADDRESS>and did that. Another advice was to --save-dev. Did that as well; But to no avail.
here's my package json:
{   "name": "mocha-testing",   "version": "1.0.0",   "description": "Learn to write Unit Tests with Mocha Chai",   "author": "Alex Banks",   "license": "MIT",   "keywords": [     "Unit",     "Testing",     "Mocha",     "Chai",     "Rewire",     "Sinon",     "Supertest",     "Cheerio"   ],   "devDependencies": {     "chai": "^3.4.0",     "istanbul": "^0.4.4",     "nock": "^2.17.0",     "rewire": "^2.3.4",     "sinon": "^1.17.2"   },   "dependencies": {} }
Any advice?
Thanks in advance
Suleman


Support for comparing nalla

Description
Currently comparing nalla like nalla == nalla gives error NallaPointerException: Nalla operand ni jamta "==" ke sath, not sure if this is intended since even in  Typescript and JS null == null evaluates to true, so here nalla == nalla should evaluate to sahi.
I can take up this issue just need some help on how to get started.
Domain
Bhai Lang
Type of Contribution
Enhancement
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of bhai-lang.

fixed : https://github.com/DulLabs/bhai-lang/pull/219


Beta 6 fixes

ty ;) Could you delete terminator: "\n" ? print by default appends a new line

Done :)

Thanks ;)


msgpack 0.5.2 is not backward compatible, and is installed when doing a fresh install of neovim

As of today, doing pip3 install neovim on a fresh Ubuntu 16.04.3 installs version 0.5.2 of msgpack-python. This leads to a python exception when trying to :UpdateRemotePlugins.
Doing pip3 install msgpack-python==0.5.1 fixes the issue.
Minimal config is a fresh install of neovim with deoplete installed, let me know if you need any more info.

Same here:
function provider#python3#Call[9]..remote#host#Require[10]..provider#pythonx#Require, line 15
Vim(if):ch 1 was closed by the client
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/andrewr/Library/Python/3.6/lib/python/site-packages/neovim/__init__.py", line 70, in start_host
    session = stdio_session()
  File "/Users/andrewr/Library/Python/3.6/lib/python/site-packages/neovim/msgpack_rpc/__init__.py", line 37, in stdio_session
    return session('stdio')
  File "/Users/andrewr/Library/Python/3.6/lib/python/site-packages/neovim/msgpack_rpc/__init__.py", line 19, in session
    msgpack_stream = MsgpackStream(loop)
  File "/Users/andrewr/Library/Python/3.6/lib/python/site-packages/neovim/msgpack_rpc/msgpack_stream.py", line 23, in __init__
    self._packer = Packer(unicode_errors=unicode_errors_default)
  File "msgpack/_packer.pyx", line 136, in msgpack._packer.Packer.__init__
TypeError: expected bytes, str found
Failed to load python3 host. You can try to see what happened by starting nvim with $NVIM_PYTHON_LOG_FILE set and opening the generated log file. Also, the host stderr is available in messages.
Press ENTER or type command to continue

OS: macOS 10.12.6
Python: 3.6.4
NeoVim: 0.2.2
python-client: 0.2.0

We can pin the version for now.

Hmm, so msgpack-python included backwards incompatible stuff in a patch level release. I wonder if that was a mistake, we should perhaps open an issue at https://github.com/msgpack/msgpack-python
More generally, we need to figure out the Right Thing for their 1.0.0 plans. Currently we have been using "surrogateescape" to mostly-transparently support roundtripping of invalid UTF-8, we might need to move this logic into our layers.

The issue is that the default for encoding changed, we need to explicitly specify utf-8.

Eventually we might be better off migrating to libmpack.

I'm sorry for inconvenience.
I'm not familiar with neovim, but I recommend not using surrogateescape.
msgpack is cross-language serialization format like JSON.
And invalid UTF-8 is very bad for cross-language.
surrogateescape is Python only hack, not cross language.
If neovim should handle invalid UTF-8, bin type (which is for arbitrary byte sequence) is better type.

@methane No one is exactly happy about invalid UTF-8, the point is treating it the least bad way. Nvim is mainly used to edit valid unicode text. Therefore most python3 plugins would want to represent edited file contents as the python3 str type (but they can opt-out to bytes if they want to). But nvim buffers are not guaranteed to contain valid UTF-8, and nvim will treat such a buffer as a mixture of unicode chars and invalid byte markers (which is logically consistent, as UTF-8 is self-synchronizing). We don't want python3 plugins to unconditionally crash in this situation. "surrogatespace" might be python specific "hack", but it is a python  representation of the cross-language ground truth "potentially invalid UTF-8" which python is far from the only language to deal with in a meaningful way.
If python-msgpack removes support for this, we need to either move encoding/decoding into our own wrapping layer, or switch to other library.

I still dislike packing invalid UTF-8 as str data, but I admit "receive invalid UTF-8 and send it back"
scenario is pragmatic.
I'm considering reverting the deprecation for unicode_errors.  I'll remove only encoding option.


Add McUtils

Self explanatory, it's mcutils, the best extension ever.

What in the world is this.

What in the world is this.

I dont know but i'm not exactly lovin' it

I just realized it's called McUtils because it means McDonald's utils. Truly one of the extensions of all time.

I'm now in fact lovin' it

10/10 would use again

Now I'm truly lovin' it

i will laugh if this gets added

bruh i can't order ice cream

too realistic,,,,

bro now not 4.1
but i like it , just add it!

Laughs


Missing dependency? cannot load such file -- raix/message_adapters/base (LoadError)

In a non-rails script calling bundle exec ruby script.rb on a script.rb file containing just require 'raix' throws the error:
cannot load such file -- raix/message_adapters/base (LoadError)
From the README, it appears this shouldn't be a sufficient set of libraries to run without activesupport. However the simple script call is failing on require 'raix' and require 'activesupport' doesn't affect the error thrown.

Investigating now, thanks for reporting.

Should be resolved in 0.4.1... apologies for the inconvenience.

Awesome. Thanks. The error has been resolved for me by upgrading to 0.4.1. I did need to add gem "openai" to my Gemfile but that was something I could resolve at the project level.


Support generating pre-signed url on S3

Is your feature request related to a problem? Please describe.
I would need the pre-signed url feature to control some files on S3 to be access under control of my server side swift application. I saw the other versions of AWS SDK (Java, .Net) support this feature. But I didn't find it on SotoS3.
Describe the solution you'd like
Support generate pre-signed url request on S3 object

Sorry, just found the answer:#73


Azure Static Web Apps Jekyll tutorial errors on "Set up Ruby" step

The ruby tutorial asks to add the ruby/setup-ruby@ec106b438a1ff6ff109590de34ddc62c540232e0 action, which no longer works.
Per setup-ruby, this probably wants to be ruby/setup-ruby@v1:

It is highly recommended to use ruby/setup-ruby@v1 for the version of this action. This will provide the best experience by automatically getting bug fixes, new Ruby versions and new features.

I ran into a few problems with ruby/setup-ruby@ec106b438a1ff6ff109590de34ddc62c540232e0:

initially got some warnings:

The set-env command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

beginning on 2020-12-05, those warnings escalated to errors:

Unable to process command '::set-env name=PATH::/home/runner/.rubies/ruby-2.7.1/bin:/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/opt/pipx_bin:/usr/share/rust/.cargo/bin:/home/runner/.config/composer/vendor/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin' successfully.
The set-env command is disabled. Please upgrade to using Environment Files or opt into unsecure command execution by setting the ACTIONS_ALLOW_UNSECURE_COMMANDS environment variable to true. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

I fixed it by using ruby/setup-ruby@v1 in my "Set up Ruby" step.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d1532547-d8ef-bdea-4164-4f617a249eb5
Version Independent ID: f8a21eb1-662f-13f3-dd9d-9ed2962e740d
Content: Tutorial: Publish a Jekyll site to Azure Static Web Apps
Content Source: articles/static-web-apps/publish-jekyll.md
Service: static-web-apps
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

@ryepup, We have raised a PR based on your feedback for the author to review and push the changes. We will close this thread for now, once the PR is merged the changes will be published in the doc. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion.
Thanks again for your valuable feedback and contribution to Azure doc improvements.


Feature UI

Update all occurences of AddressBook to UninurseBook
Update package name from seedu.address to seedu.uninurse
Update test cases to include command type in command results

there are still some CommandResult instances in the test folder that have not been resolved yet, according to the gradle check. How should we deal with those?

I am working on it currently so can review this PR after I am done.

Codecov Report

:exclamation: No coverage uploaded for pull request base (feature-ui@c7f9bb7). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             feature-ui     #175   +/-   ##
=============================================
  Coverage              ?   68.63%
  Complexity            ?      494
=============================================
  Files                 ?       95
  Lines                 ?     1677
  Branches              ?      185
=============================================
  Hits                  ?     1151
  Misses                ?      476
  Partials              ?       50

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[zh] Translate the the "en/docs/reference/kubernetes-api/service-resources/ingress-class-v1.md"

Hi,I am interested to translate the the "en/docs/reference/kubernetes-api/service-resources/endpoints-v1.md" into chinese
translate en/docs/reference/kubernetes-api/service-resources/ingress-class-v1.md
What would you like to be added:
zh/docs/reference/kubernetes-api/service-resources/ingress-class-v1.md
/language zh
/kind feature

/close


Improve client/protocol state machine

Only add the peer to the routing table after verifying that it is reachable.   Additionally, this changeset improves dialing such that it does not block with the peers lock held.  Instead, dialing is done asynchronously and when the link first becomes ready it is pinged.

After applying these changes we seem to get the following errors when reusing a listen address (in our case it's <IP_ADDRESS>:23456) upon attempting to dial a peer.
To reuse the listen address we had previously joined the network using this address, stopped the grpc server (and the process) then restarted it using the same port. The dial peer can be any in the network.
connection could not be identified: failed to ping peer: rpc error: code = Unavailable desc = transport is closing
and sometimes:
connection could not be identified: failed to ping peer: rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection closed
If we use a new listen port or don't attempt to dial any peers we don't encounter the issue.

Hi @creamwhip, we recently encountered that problem as well. We found source of it recently and now discussing solution, so it will be resolved shortly.
Thank you for reporting!