optional raw element bug fixed.

Fixes the bug with optional raw element.
Example:
>>> class Model(BaseXmlModel, tag='model', arbitrary_types_allowed=True):
...     element1: Optional[ElementT] = element(default=None)
...
>>> Model().to_xml()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.11/site-packages/pydantic_xml/model.py", line 399, in to_xml
    return etree.tostring(self.to_xml_tree(skip_empty=skip_empty), **kwargs)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pydantic_xml/model.py", line 380, in to_xml_tree
    self.__xml_serializer__.serialize(
  File "/usr/local/lib/python3.11/site-packages/pydantic_xml/serializers/factories/model.py", line 170, in serialize
    field_serializer.serialize(
  File "/usr/local/lib/python3.11/site-packages/pydantic_xml/serializers/factories/raw.py", line 38, in serialize
    sub_element = element.from_native(value)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pydantic_xml/element/native/lxml.py", line 22, in from_native
    tag=element.tag,
        ^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'tag'

Expected behavior:
>>> from pydantic_xml import BaseXmlModel, element
>>> from xml.etree.ElementTree import Element
>>> from typing import Optional
>>>
>>> class Model(BaseXmlModel, tag='model', arbitrary_types_allowed=True):
...     element1: Optional[Element] = element(default=None)
...
>>> print(Model().to_xml().decode())
<model/>

fixes the issue https://github.com/dapper91/pydantic-xml/issues/158

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (73228d7) 91.71% compared to head (c5e77d5) 91.77%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #160      +/-   ##
==========================================
+ Coverage   91.71%   91.77%   +0.06%
==========================================
  Files          26       26
  Lines        1508     1508
==========================================
+ Hits         1383     1384       +1
+ Misses        125      124       -1

Flag
Coverage Δ

unittests
91.77% <100.00%> (+0.06%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


node on azure

i have a node server installed on azure and when i make the xhr request to the uploadFile end point i get the response: 404 Not Found: /home/site/wwwroot/uploadFile
any ideas?

this is not related to recordrtc, please ask on appropriate site instead (e.g. stackoverflow?) (cc @muaz-khan)


Build errors on macos - unresolved simd imports

Hi, running the examples on macOS (Metal M1) produces a bunch of errors starting with:
cargo run --example ball --release +nightly

error[E0432]: unresolved import `std::simd::SimdFloat`
 --> src/point.rs:1:80
  |
1 | use std::{fmt::{Display, Formatter, Result},simd::{f32x4,mask32x4,simd_swizzle,SimdFloat},mem::transmute,ops::{Add,AddAssign,Sub,SubAssign,Mul,MulAssign,...
  |                                                                                ^^^^^^^^^
  |                                                                                |
  |                                                                                no `SimdFloat` in `simd`
  |                                                                                help: a similar name exists in the module: `StdFloat`
  |
  = help: consider importing one of these items instead:
          core::simd::prelude::SimdFloat
          std::simd::prelude::SimdFloat

Any idea what's causing this?

I don't know what version of this library or rust you are using, but the ball example has been uncommented for a long time. The SimdFloat is also been replaced with StdFloat for some time now.
This library should work as is, but the examples themselfs are broken.
Hope it helps

I cloned the repo just today.

the ball example has been uncommented for a long time.

Do you mean "commented"? Either way I don't understand.
Will the examples be fixed?

*commented out
No
On Wed, May 8, 2024 at 4:17 PM coolbluewater @.***>
wrote:

I cloned the repo just today.
the ball example has been uncommented for a long time.
Do you mean "commented"? Either way I don't understand.
Will the examples be fixed?
—
Reply to this email directly, view it on GitHub
https://github.com/wrnrlr/g3/issues/13#issuecomment-2100692054, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AF3OUQQYMPAUTLCQUDDGHCDZBIXV3AVCNFSM6AAAAABHLTPYFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBQGY4TEMBVGQ
.
You are receiving this because you commented.Message ID:
@.***>


Update MemoryFence definition logic

Both nvme and virtual_media driver invokes MemoryFence function,
implement inline function in corresponding header files as inline
function to avoid multi definition link issue.
Also provide MemoryFence symbol in libefiwrapper for kernelflinger
to link MemoryFence symbol which supposed to be implemented in EFI
componment.
Tracked-On: OAM-113553

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web  for more details

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web  for more details

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web  for more details.

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web  for more details

Android CI has completed Engineering Build for this issue, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web  for more details

Android CI has completed Engineering Build for this issue, build is SUCCESS.To merge the changes please click on APPROVE FOR MERGE button in Android CI WEB


[DO NOT REVIEW] verify signoff

No commits w/ signoff
failed as expected

Found signoff.

Commit sha:
96020e725cee39a5175c8d62f598e4960b115b17
Commit message:
sign it

Signed-off-by: Peixin Li<EMAIL_ADDRESS>
passed as expected


Pointer to temporary object

Hello,
I just start to familiarise with your code (due my own problems with miniaudio I try to see, how other people done this). Probably I found error in audioplayer.hpp.
https://github.com/alexmercerind/flutter_audio_desktop/blob/8f5f066acb47783074cc5c7ab569c7d898fd89f3/audioplayer/audioplayer.hpp#L123-L126
ma_device_id is an union. In function initDevice and in initDeviceWave is passed such union as parameter, so this is temporary object. So, stored in variable pDeviceID pointer to this parameter (selectedDeviceId) will be invalid, when we leave function.

Thanks for looking over the code, please feel free to make comments regarding code aesthetics or conventions as well. Ah yes, that does look a little odd, thanks for finding that. It should not cause any issues though, deviceConfig doesn't even necessarily need to be persistent either. After init is ran any changes to device config requires re-initialization. Feel free to submit a PR with a better approach, otherwise I will rework in upcoming updates.


Added components to 1.3.7 manifest

Description
Added components to 1.3.7 manifest
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2941 (326cd38) into main (0f3667e) will decrease coverage by 0.30%.
The diff coverage is n/a.

:exclamation: Current head 326cd38 differs from pull request most recent head e842e89. Consider uploading reports for the commit e842e89 to get more accurate results

@@            Coverage Diff             @@
##             main    #2941      +/-   ##
==========================================
- Coverage   93.00%   92.69%   -0.31%
==========================================
  Files         165      165
  Lines        4518     4518
==========================================
- Hits         4202     4188      -14
- Misses        316      330      +14

Impacted Files
Coverage Δ

src/system/temporary_directory.py
64.44% <0.00%> (-28.89%)
:arrow_down:

src/system/os.py
93.75% <0.00%> (-6.25%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Sandbox]: Publish storybook canary on Github Pages

User story

As a [user role below]:

I need to:

so that I can:

Additional information

Jenkins job that will build storybook then publish to Github Pages
Remove the old version before pushing up the new version
Uses ibmdotcom-bot for all git actions
On all pushes to main
Also one for latest tag
https://[ibm github host]/canary
https://[ibm github host]/latest

Acceptance criteria

[ ] New Jenkins job for publishing canary
[ ] New Jenkins job for publishing latest

Hey team! Please add your planning poker estimate with ZenHub @annawen1 @ariellalgilmore @emyarod @IgnacioBecerra @kennylam @proeung


I added app icon in branch

Hello. I added a app icon that has memes collage in background and "MEMES" text in foreground. I hope you like it.
Also put it in added-app-icon-memes branch.
I hope you merge it.

@ak523 I put it in another branch

@detherminal as this issue was already solved I have incorporated your changes in different branch.
Happy coding!🥳


Cannot preview Youtube urls

i don't know if it's just me or others have this issue, but I can't fetch info about any video on yt, youtube.com and other websites work, but video urls don't does anyone else have this issue?

i got a same problem.

@jaceshim  did not work i referenced your commit still the image is not being fetched.

Short links are not visible

You can use 'https://www.youtube.com/oembed?url=$link&format=json' to get metadata.

You can convert short links to full ones:
if (urlText.contains("youtu.be/")) {
        urlText = urlText.replaceAll(
                "youtu.be/",
                "youtube.com/watch?v=");
}


Add a Source modal does not close when you click finish

Describe the bug
Add a Source modal does not close when you click Confirm
To Reproduce
Steps to reproduce the behavior:

Go to Overview page
Click on 'Add a Source'
Fill out details correctly
Click Confirm
Source seems to get added but modal does not close.

Expected behavior
Source should be added and modal should be closed.
Screenshots

Desktop (please complete the following information):

OS: Fedora
Browser Chrome
Version 66

Additional context
I get the same issue regardless if I add AWS or OCP provider.

I don't know that we will make further changes to this particular modal? That is, considering we now have a new modal for OCP onboarding. When the AWS functionality is ready (during sprint 18), we will switch it on and completely replace this functionality.
@boaz0 Please ensure the new onboarding flow doesn't have a similar issue and close if applicable.


Avoid sending advertise cancel if not necessary

Sending advertise cancel command if a connection was accepted should not be necessary, but nrf silently accepts, whereas rpi pico w will fail.
Fixes #188

/test


Marvin's replying few times to the same comment.

Reddit has propably changed the way it adds comment to the tree, so the way of checking if the comment has been replied by Marvin doesn't work anymore.
As far as I noticed, there's now a slight lag between clicking 'SAVE' and the comment actually being added to the comment tree by reddit's api. It's long enough for human to notice, so it's propably long enough to screw up bot.
You might want to keep a list of last 1000 or so replied to comment id's in memory and check if comment.id in idlist instead of checking if Marvin's nick is in comment.replies.

Thanks for the useful info. Any chance you'd be willing to patch this?

Okay, I've had problems with running the source code, so I coppied what I could and wrote the rest. (Whole main is new) I've been working on it in python3, using my bot to test. As far as I can see it works.
I wasn't sure how the regex you had worked, so I wrote mine - feel free to throw it away as you wish.
Not entirely sure how to merge it with your source, so I put it in pastebin - https://pastebin.com/WLPijwu9
Make sure to put the proper praw.Reddit() (I was simply using my 'bot1' to debug it) and test if it works on your version of python ;D


Cross Req/Res timeout

Hi,
I encountered a very strange case.
There are two processes / programs on one host.
First have xrep socket on port 3001 (to revice msg and reply) and req (to send msg)
Second have xrep socket on port 3002 (to revice msg and reply) and req (to send msg)
So that the first can send a Req to the second and recv XRep.
And independently the second one can send a Req to the first.
If only the first sends and the second responds, then everything is fine.
If only the second sends and the first responds, then everything is fine.
But if the first send and receive a reply.
After which the second one wants to send something, he receives a timeout.
From this moment, the first pipe works correctly.
The second one connects, I see the PipeEventAttached on both sides and after timeout PipeEventDetached. However, no message passes.
If I change the order of sending and the second sends the message first, then the second pipe has the same problem.

I think I need example code to understand what exactly is happening here.  My guess is there is somehting wrong with how you are setting up your connections.

I rewritten the code with Context and the issue disappeared. I assume that I made a mistake in the code.


conda package

Could you please make it a conda package.

Fixed by https://github.com/conda-forge/staged-recipes/pull/18711

Great to see you here @timothycrosley! I will be able to close this once there is a PyPI release including #96.

Portray is now installable as a Conda package from Conda-Forge.
https://github.com/conda-forge/portray-feedstock
This issue should now be closed, but I don't have permissions to close it myself.


[fix][broker] Fix print cluster migration state response

PIP: https://github.com/apache/pulsar/issues/16551

Motivation
Currently, pulsar-admin cli is not printing cluster migration state response and this PR fixes the printing it on console.
Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.32%. Comparing base (bbc6224) to head (94b491a).
Report is 705 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23535      +/-   ##
============================================
+ Coverage     73.57%   74.32%   +0.74%
- Complexity    32624    34424    +1800
============================================
  Files          1877     1943      +66
  Lines        139502   147045    +7543
  Branches      15299    16205     +906
============================================
+ Hits         102638   109285    +6647
- Misses        28908    29322     +414
- Partials       7956     8438     +482

Flag
Coverage Δ

inttests
27.42% <0.00%> (+2.84%)
:arrow_up:

systests
24.37% <0.00%> (+0.04%)
:arrow_up:

unittests
73.71% <100.00%> (+0.86%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines
Coverage Δ

.../java/org/apache/pulsar/admin/cli/CmdClusters.java
71.91% <100.00%> (-2.94%)
:arrow_down:

... and 653 files with indirect coverage changes


chore: move test fixtures

Canonical location is tests, and having an additional test dir is unnecessary.
Use canonical name fixtures

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.64%. Comparing base (6759071) to head (2bf1e9f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   64.64%   64.64%
=======================================
  Files           5        5
  Lines          99       99
  Branches       99       99
=======================================
  Hits           64       64
  Misses         35       35

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Hoist thread IDs into a dedicated record

These changes reduce the size of our output file by around 18% (and the runtime of tracking by around 5%).

If you want it to not segfault, that costs extra.

If you want it to not segfault, that costs extra.

How much extra? I think I have some spare change... 💰

Ah, dumb bug - I was failing to initialize d_lastTid in the record writer, and so the test suite occasionally got "lucky" enough to construct a new RecordWriter in the same spot as the last one, and pick up the correct thread ID for d_lastTid accidentally. If that happened, it would incorrectly think it had already emitted a CONTEXT_SWITCH record and that it didn't need to.

The net effect of all of these changes is a reduction in capture file size of approximately 70%, depending on the test being measured.

Can you add a changelog entry?

I think I've addressed all the changes you've asked for except for this one - I'll just leave that for later cleanup.
https://github.com/bloomberg/memray/compare/4ad3a79b2f7597b33f7e839de3f17244bc2a498f..pull/67/head should be the delta between what you last reviewed and the latest version.


System.NullReferenceException on Android on page close

Hi!
Page consist of CollectionView with ContentView Items with ef.AddCommand.
On PopAsync (using FreshMvvm btw) app crashes. Android only, iOS - no problem.
    Process: com.company.mobile, PID: 2026     android.runtime.JavaProxyThrowable: System.NullReferenceException: Object reference not set to an instance of an object       at AiForms.Effects.Droid.AiEffectBase+<>c__DisplayClass22_0.<BindingContextChanged>b__1 () [0x0000b] in <82332298958c45b498e83340cd785caa>:0        at Java.Lang.Thread+RunnableImplementor.Run () [0x00008] in <e98afaf88af5496ea979d99b06e991b9>:0        at Java.Lang.IRunnableInvoker.n_Run (System.IntPtr jnienv, System.IntPtr native__this) [0x00009] in <e98afaf88af5496ea979d99b06e991b9>:0          at (wrapper dynamic-method) Android.Runtime.DynamicMethodNameCounter.43(intptr,intptr)

@alexpetin
Though I don't know FreshMvvm, It works fine using Prism.Forms or Navigation.PopAsync().
I think that it crashes at the following:
https://github.com/muak/AiForms.Effects/blob/bd948f9e06e615909c692288a33955fde94f7274/AiForms.Effects.Droid/AiEffectBase.cs#L149-L165
If you know where the error occurs above, could you please tell me?

Element is null here.

Also it looks like OnDetached is actually called in my case :)

The problem disappears if I change that line to:

Device.BeginInvokeOnMainThread(() => Element?.Effects.Remove(toRemove));
Element.Effects.Remove(toRemove);

Not sure what would be more correct. Btw why BeginInvokeOnMainThread was used here?

@alexpetin
Thank you for the information.
I will fix with the above.
Without BeginInvokeOnMainThread,  there was the pattern of occurring error.
But I forgot what the pattern is.
Anyway, Thanks!


PLAT-1679 roundtrip test with backend

should deliver-ghp and deliver-npmjs be dependent on backend-roundtrip?


Remove VR Photo Converter version 2.1

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Removed VR Photo Converter version 2.1 as latest version is 2.2
Microsoft Reviewers: Open in CodeFlow

URL: https://www.japplis.com/virtual-reality/vr-photo-converter/versions/VRPhotoConverter-2.1.exe
OK
(Automated message - build 882)


Fix GZIP support

GZIP creates a conflict of interest in our tapes where we want the tape to be editable, but also compressed. Really, we should just remove Content-Length from the persisted payload and just infer it based on the tape's payload. I thought I already did this, but it's still not working, so I'll have to fix it.

+! Thanks!

Moving this to Trello: https://trello.com/c/qlor2w70.


How to manage multiple callbacks for each user role?

I am working on project where we have 2 different types of users, "doctors" and "patient", I have setup doctor sign in with apple, but how I can add another redirect url for "patient" too. so when Patient will login they will go to there controller as same doctor is doing
Note: I have added both callback in apple account, only issue is remaining from website side, when I call from patient login it still go to doctor controller after callback.

HI @iamaz007, unfortunately that is not something that this package would be able to solve for you. You would need a way to differentiate between doctor and patient user records, and then redirect them in middleware to their appropriate location.

I tried with session storage and cookies too, doctor and patient have separate login, so when they click on login I save their sessions, I have tested with Facebook and LinkedIn in Socialite they are working fine, but when I do this with apple login, apple clears all the sessions and cookies, that is why I am facing difficulty in both user authentication.
Is there any parameter I can send with apple sign in, so on callback I can identify user

@iamaz007 I don't think that would work. I don't know that Apple would handle that.


SKD is using advertisingIdentifier

By using paymentSDK iTunes Connect validation discovers usage of ASIdentifierManager API
https://developer.apple.com/documentation/adsupport/asidentifiermanager.
Is there a version of an SDK that does not use this API behind a scenes?
Used version 2.17.0. Resubmitting with 2.17.3, but grep -r advertisingIdentifier . still indicates that paymentSDK framework contains references.
$ grep -r advertisingIdentifier .
Binary file ./Pods/paymentSDK/PaymentSDK.framework/PaymentSDK matches
./Pods/paymentSDK/PaymentSDK.framework/Headers/WDPayPalPayment.h:@property (strong, nonatomic, nullable) NSString *advertisingIdentifier;

Hi @lukewar ,
as you can see in WDPayPalPayment class the property type is NSString. It just uses name advertisingIdentifier.
In previous releases paymentSDK was using AdSupport framework directly.
Since release 2.17.2 it is only NSString and it is up to your app if AdSupport framework and ASIdentifierManager class is used.
It is not used directly from paymentSDK. Usage is optional and up to your decision.


Add Curvenote

Added this under a new heading as it doesn't quite fit in blogs, documentation or frameworks. Happy to revise that.

I think the new section is a good idea.


Reach 100% python coverage rate

*Issue number of the reported bug or feature request: #51 *
Describe your changes

More tests are introduced in this PR such that make pycoverage returns 100% coverage rate.
Coverage requirement is bumped from 97% to 100%.
Test files are no longer excluded from coverage report.

Testing performed
make check
Additional context

@yize415 Thanks, this looks awesome!  You can squash both of these into one commit at the same time, too.
From the state your PR is in now, you can run:
git reset --soft d2b425be1389bf151043c366212a12a3d437f27a

to revert your commits but leave your changes staged, and then you can run:
git commit -s -m "tests: Reach 100% Python code coverage"

to re-commit your changes as a single commit and with the DCO signoff added.

Thanks for instruction! I just force-pushed and let me know if further actions are needed

@yize415 Unfortunately some of the latest merges have created conflicts with this PR. Would you mind solving them so we can merge? If you have problems you can ping me (@pablogsal ) or ask @godlygeek for help!

Just solved merge conflicts and rebased!

Thanks so much for the contribution, @yize415!


Add instructions on distributed MXNet with Horovod on Kubernetes

Description
Add instructions on distributed MXNet with Horovod on Kubernetes.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Add instructions on distributed MXNet with Horovod on Kubernetes

Comments

Just documentation change.

@mxnet-bot run ci [all]

@mxnet-bot run ci [all]

@mxnet-bot run ci [unix-cpu, unix-gpu, website]

Test failure is unrelated as this is simple doc change + master is also failing.

@mxnet-bot run ci [unix-cpu, unix-gpu]

@mxnet-bot run ci [unix-gpu]

@mxnet-bot run ci [unix-gpu]


Feature: May you add my profile to the list, please? 🥺

Is your feature request related to a problem? Please describe.

Nope!
Describe the solution you'd like

I would like to add my profile to the list.
Describe alternatives you've considered

My profile was written in Portuguese language. If that's a problem, I can translate it.
Additional context

Watch this divine, resplendent and dazzling shower of fluffy kittens.

Make a pull request.

:/

@mdccg plz open a PR, we'll look into it.


Fixed broken table markdown

Now the actual table is shown instead of the markup code for the table comparing Durable Functions with Logic Apps

Verified the updates; merging.
@seekingtheoptimal Thank you for submitting this fix.


Send confirm email cannot be used properly

Package version (if known):  latest
Describe the bug
The "send-confirmation-email" API requires login, which prevents the most frequent use case which is to send confirm email again
Steps to Reproduce

Register with confirmation and either the email is expired (quite likely with the default 30mins) or lost
So user is unable to log in yet
Hence downstream app provides Resend confirmation button,
But cannot call API for said purpose since SendConfirmationEmailView is decorated with login_required

Expected behavior
Ideally, login_required decorator should be removed since the typical use case here is for resending email
Screenshots (if applicable)

I've attempted to override this decorator with a subclass to set decorators = (), but it doesn't seem to work.
Of course, a separate blueprint/url could be created to workaround issue, but would be far from optimal

So I'm might be wrong here, but I think it's correct that the view requires login. The view is for when a confirmation is NOT required to login. In which are the user can log in (if they remember their password) and ask to resend the confirmation email.
Instead a user should reset their password (which will also send an email) if the link expired. However, here might be a bug that it seems like the ForgotPasswordView requires an authenticated user.


Migrating to CodeClimate

For code coverage, and quality record keeping we are going to use CodeClimate from now on. Codecov.io is no longer permitted as per CISO

https://github.ibm.com/security-services/security-advisor-project-management/issues/11404

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Update docs in upsampling_2d according to new max_pooling_2d

Updated docs according to https://github.com/chainer/chainer/pull/4890 .

Jenkins, test this please.

LGTM! Test failure were not related to this PR.


Miss dependency implement

Hi @qute012
What is from speech_commands.input_data import AudioProcessor in Line import: https://github.com/qute012/Wav2Keyword/blob/main/downstream_kws.py#L83 ?
Please help me

Hi @qute012
What is from speech_commands.input_data import AudioProcessor in Line import: https://github.com/qute012/Wav2Keyword/blob/main/downstream_kws.py#L83 ?
Please help me

Make a copy of the speech_commands directory from TensorFlow examples: https://github.com/tensorflow/tensorflow/tree/master/tensorflow/examples/speech_commands


How to add your own branding?

I tried replacing /opt/stackstorm/static/webui/img/logo-stackstorm.svg with my own .svg file, but that didn't seem to change anything in the GUI.
Thanks,
john

Update:
I was able to swap out the logo-stackstorm.svg, and when sized properly it does display ok.  I thikn my browser cache wasn't clearing before for some reason.
That said, I think there's a doc update opportunity here.   Is there any guidance as to what other 'custom branding" stuff has already been wired in?  i see a big commit related to that.

@johnarnold looking through the history, that commit was part of this PR: https://github.com/StackStorm/st2web/pull/322
The goal of that PR was to re-brand the UI with Brocade images, fonts, colors, etc. We re-launched StackStorm Enterprise as Brocade Workflow Composer about that time. For users that have StackStorm, if they add BWC on top, it re-brands the st2web code as Brocade Workflow Composer.
I don't think it was explicitly intended to be an option that users would customize, hence the lack of documentation. That said, the way it has been done does seem to lend itself to some level of user-customization.
If you don't already have one, get a BWC trial license (brocade.com/bwc -> Free Trial), and install the bwc-ui package. You can see an example of the branding.less file in use there. (I would link direct to the repo, but it's private).

@LindsayHill    Thanks, I'll take a look.  I do think this has utilitiy, even on top of BWC.
FWIW I would like to have BWC for the ldap/RBAC and for the flow editor.  I have to prove some value with the opensource proof of concept first to get approval, so I'll keep hacking for now :)

I do think this has utilitiy

I think you're probably right. Hasn't been a big call for it, hence the lack of docs, and no promise of stability for those branding stylesheets. But it does seem do-able, and the pieces are there. Maybe we should have an open feature request issue for it?


Fix for #1666- Back button is not accessible via keyboard when navigating to the about page.

Fixes #1666
Back button is not accessible via keyboard when navigating to the about page.
Description of the changes:

Moves the BackButton from titlebar to Settings page.
Changes correlated code-behind

How changes were validated:

Build passed and tested manually

Remarks:
The static UI won't have any difference, but there is a little difference with the animation of BackButton.
Before the fix:

After the fix:

@tian-lt , suggest moving the xaml ui codes about Back button into local:Settings control, local:Settings control will be responsible for managing/displaying all the UI parts in settings page, Main page only controls the popup show/hide.

@tian-lt please take a look at https://github.com/microsoft/calculator/blob/f46f63f340e959090cc5d9ee79e6b7484ba7d6f3/src/Calculator/Views/MainPage.xaml.cs#L157 and https://github.com/microsoft/calculator/blob/f46f63f340e959090cc5d9ee79e6b7484ba7d6f3/src/Calculator/Views/MainPage.xaml.cs#L303 , the PopupContent.Height assignment should be changed to " = windowBounds.Height". Otherwise, the popup height will not be enough to cover the window.
Except this one, other changes look good to me.

Nice catch, @guominrui.
Fixed the popup content height in the last commit.


[type:Integration Test] Add  redis modle test for cache-plugin

The cache plugin has two modes, and this pr tests the two modes together by refactoring the code.

[x]  Local test passed

Codecov Report

Merging #3578 (ad47a4a) into master (d21f6ca) will decrease coverage by 0.40%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3578      +/-   ##
============================================
- Coverage     62.49%   62.08%   -0.41%
+ Complexity     5557     5534      -23
============================================
  Files           848      848
  Lines         23465    23483      +18
  Branches       2132     2136       +4
============================================
- Hits          14665    14580      -85
- Misses         7445     7542      +97
- Partials       1355     1361       +6

Impacted Files
Coverage Δ

...plugin/logging/rocketmq/LoggingRocketMQPlugin.java
22.72% <0.00%> (-72.73%)
:arrow_down:

...ogging/rocketmq/body/LoggingServerHttpRequest.java
0.00% <0.00%> (-20.00%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
46.52% <0.00%> (-19.45%)
:arrow_down:

...he/shenyu/common/timer/HierarchicalWheelTimer.java
68.00% <0.00%> (-18.00%)
:arrow_down:

...va/org/apache/shenyu/common/timer/TimingWheel.java
73.80% <0.00%> (-16.67%)
:arrow_down:

...yu/sync/data/http/refresh/AbstractDataRefresh.java
68.96% <0.00%> (-13.80%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
51.06% <0.00%> (-12.77%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

.../org/apache/shenyu/common/timer/TimerTaskList.java
74.72% <0.00%> (-8.80%)
:arrow_down:

...nyu/plugin/motan/cache/ApplicationConfigCache.java
52.00% <0.00%> (-5.00%)
:arrow_down:

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21f6ca...ad47a4a. Read the comment docs.

@JooKS-me  please review this pr，thanks～


Model stopped updating after 300-400 steps.

I am training with the following script:
export PYTORCH_CUDA_ALLOC_CONF='max_split_size_mb:1024'

accelerate launch \
--config_file  accelerate_configs/single_node.yaml \
train.py \
--batch-size 1 \
--gradient-accumulate-every 4 \
--output-dir ./output/7B_32K_bs_1M_rope_1M_step_1000_lr_2e-5 \
--wandb EasyContext \
--max-train-steps 2500  \
--learning-rate 2e-5  \
--dataset yaofu/slimpajama-per-source-length-upsample \
--model meta-llama/Llama-2-7b-hf  \
--seq-length 32768 \
--rope-theta 500000 \
--parallel_mode data_parallel

The difference between the above command and train_scripts/EasyContext-1M-Llama-2-7B.sh is that I changed the --max-train-steps and --rope-theta. Additionally, I modified the if block in Line 161-165 in train.py to enable model saving every 100 steps (I set  --save_interval=100):
if accelerator.sync_gradients:
    progress_bar.update(1)
    if loss_log is not None:
        progress_bar.set_postfix(loss_log)
    completed_steps += 1

    if completed_steps % args.save_interval == 0:
        ckpt_save_dir = f"{args.output_dir}/step{completed_steps}"
        os.makedirs(ckpt_save_dir, exist_ok=True)
        accelerator.wait_for_everyone()

        state_dict = accelerator.get_state_dict(model)

        accelerator.unwrap_model(model).save_pretrained(
            f"{ckpt_save_dir}",
            is_main_process=accelerator.is_main_process,
            save_function=accelerator.save,
            state_dict=state_dict,
        )

        accelerator.print(f"Saved model to {ckpt_save_dir}")

        accelerator.wait_for_everyone()

All saved models are evaluated on the latest version of lm_eval. I found that all models saved after step 400 (step 400 included) are identical. That is, when checked with cmp <model_at_step_400-0000X-of-0000X.safetensors> <model_at_step_T(T>400)-0000X-of-0000X.safetensors>, no errors are given. Besides, when evaluated on lm_eval, these models give identical results on all datasets tested (including MMLU, TQA, Hellaswag, Winogrande, etc.).
The models are all trained on 8 A800 GPUs (80G) and this issue can be reproduced on different model structures (YARN, which is LLaMA-2 with a different positional embedding). I wonder if you have any insights towards this issue. Thanks!

An update: I tried with --max-train-steps 1000, it seems that the model stops updating somewhere between step 100 and 200. Checkpoints saved after 200 (200 included) are identical when checked with the cmp command.

An update: It seems that it has something to do with the scheduler in accelerate_configs/zero3_offload.json. I set --max-train-steps 100 and print the learning rate value in each iteration. I get the following result:
rank7_input.log
As you can see, the learning rate decays to 0 ever since step 13. So nearly 90% of the training process is useless.

I suggest use a constant schedule following arXiv:2402.10171. Which is, set accelerate_configs/zero3_offload.json as the following:
{
  "scheduler": {
    "type": "WarmupLR",
    "params": {
      "warmup_min_lr": 2e-5,
      "warmup_max_lr": 2e-5,
      "warmup_num_steps": 0,
      "warmup_type": "linear"
    }
  },
  "optimizer": {
    "type": "AdamW",
    "params": {
      "lr": "auto",
      "betas": [0.9, 0.95],
      "eps": 1e-8,
      "weight_decay": 0.1
    }
  },
}

Thanks for spotting this out!!  This is really weird...
I mainly follow Yarn's training and deepspeed config.
I thought arXiv:2402.10171 also uses a WarmupDecayLR ? https://github.com/FranxYao/Long-Context-Data-Engineering/issues/8#issuecomment-2003917697

@Bostoncake I've updated the config based on your suggestions. Do you have any idea why this could happen?

@Bostoncake I've updated the config based on your suggestions. Do you have any idea why this could happen?

I think it might has something to do with "total_num_steps": "auto". Maybe you need to explicitly specify the number of total steps when initializing the scheduler. I haven't tried this, though.

@jzhang38 @Bostoncake It is because scheduler.step() is called num_gpu times for each minibatch. So when --max-train-steps 1000, lr decays to 0 at 125 steps with 8 GPUs.
For now the best solution IMHO is indeed to specify min_lr in zero3_offload.json instead of using auto.

@jzhang38 @Bostoncake It is because scheduler.step() is called num_gpu times for each step. So when --max-train-steps 1000, lr decays to 0 at 125 steps with 8 GPUs.
For now the best solution IMHO is indeed to specify min_lr in zero3_offload.json instead of using auto.

+1, when I use 2*A100, the model parameters are no longer updated starting from max_train_step/2.

This is because of the accelerator prepare, which causes the scheduler to step num_processes times for each optimizer step, check https://github.com/huggingface/accelerate/issues/2318 and https://github.com/huggingface/accelerate/issues/2142.
I would recommend this one:
lr_scheduler = get_scheduler(
name=args.lr_scheduler_type,
optimizer=optimizer,
num_warmup_steps=args.num_warmup_steps * accelerator.num_processes,
num_training_steps=args.max_train_steps * accelerator.num_processes,
)


Add path option to config file to specify additional search paths

It would be nice if the config file had a path option to add another location to the search path. Ideally a list of paths to search, but a single path suffices for my purposes. I've already patched our own local version with an ugly hack, but I figure other users could probably benefit from a properly-written patch. This seems like a more user-friendly option than modifying the PATH environment variable, too.

Could you please describe a bit in which situation do you need it?
Besides modifying PATH you can also use XXX_BIN environment variables, but I assume it will not be more helpful.

Because we are running an older Ubuntu version, I compiled a new libpng and new versions of every tool, to make sure we have the latest performance and fixes. Because I don't want to affect other software, it's all installed in /opt/image_optim/bin (so /opt/image_optim/bin/pngquant, /opt/image_optim/bin/pngcrush, etc.).
I see that image_optim looks in a lot of places (/usr/bin, /usr/local/bin, etc), but I feel like if someone needs to look in a separate location, like /opt/bin or ~/bin or something, they're going to have more than one binary there.
For us we can always change all of the XXX_BIN but that's a lot of environment variables. We can also change PATH but that can be problematic because we are calling image_optim from a few scripts and I don't want to change all of them to export PATH, but I also don't want to add it to the global PATH either.
I hope this makes sense. I did try to make the change myself, but ruby projects are very complicated for people who have never used ruby before.

Yes, sure, I've assumed something like this. Just to check would image_optim_pack be an option for you?

According to my developer:

That said image_optim_pack's pngquant is outdated, we want 2.x

Generally if I'm installing software I like to compile it myself, but if image_optim_pack can be updated then it would be an option for us in the future. Still, I prefer to do it myself when possible.

But it is 2.5.2 — https://github.com/toy/image_optim_pack/blob/v<IP_ADDRESS>51113/Makefile#L16
Also I understand the point of compiling yourself, so then yes it would be helpful to have an option to specify which bin paths to search through.

Well I don't know what to tell you then, I guess the developer was wrong.
I still think it would be a useful feature, but I guess I could have saved a few hours of compiling too.


Development setup of Android client

Error in the development Setup documentation of Android client : android folder to be selected to import after navigating to the root folder of the project (the folder named "open-event-android"), and then hit OK.

Hey @minervapanda
That is absolutely normal.
Basically the reason for that is, we have the scripts that are used in the server inside the repository too, so in order to compile the app you need to open the Android folder in order to Ru  and compile it.
Cheers.

Okay. The thing is missing that inorder to compile and run the app one has to move to android folder.

Yeah, you can send a PR that fixes this issue   👍

Fixed in #496


vlc: make vdpau and systemd optional

True by default - to not cause mass rebuilds :-)
Description of changes

Helps https://github.com/NixOS/nixpkgs/issues/299174 pero no mucho
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@Strum355 I have tested and it worked when VDPAU is disabled.

@Strum355 I have tested and it worked when VDPAU is disabled.

Nice! Do you know if its using software decoding if vdpau is disabled?

@Strum355 I have tested and it worked when VDPAU is disabled.

Nice! Do you know if its using software decoding if vdpau is disabled?

Dunno.  Here is a paste of log:
https://pastebin.pl/view/c1efee7b

Unfortunately doesn't seem to solve it for me :/
Built with nix build --impure --verbose --expr 'with builtins.getFlake "github:atorres1985-contrib/nixpkgs/vlc"; (legacyPackages.x86_64-linux.vlc.override { enableVdpau = false; })'

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3817

@alois31 PING


Add CPU support to OGA tooling

Note: the instructions in our readme match the official OGA instructions, which means they may not work until this issue is resolved: https://github.com/microsoft/onnxruntime-genai/issues/872
See the workaround mentioned in that issue if you have any trouble.

https://github.com/microsoft/onnxruntime-genai/issues/872, and the changes in this PR have been completed in another PR.


As a PM I want to welcome users with an email optimized for them, so they have a CTA to get started

This will largely be a textual change to the email, so that it's targeted towards ALL MDN users (not Contributors only as it is now).
@atopal will provide text for this.

Duplicate of #2425


Clean readme

Coverage remained the same at 100.0% when pulling 3d9bb92c404d51ac9203fd4f90187e08b9b60d99 on chore-clean-readme into 0bd2747734cc1fed8d34ca804c1c42120b96719c on master.


RN App: Messages from same user don't concatenate

In Android App, when a user post multiple messages, the messages don't concatenate, which means for each line the username is displayed in bold. Which means, after a couple lines, 50% of the screen is filled with the same information : the username, in bold.
This doesn't happen on the mattermost web app, slack android app, slack desktop, slack web, rocket chat android app, rocket chat web app.
Sorry in advance, i have the feeling it's not the right place to post this.

On android 7.1.2 and MM 1.7.1 build 92

I did implement that recently for myself, but reverted because it was causing some complications:

when posts are constant size like now, you can be sure that rendering say 10, 15 posts can fill the screen at once. when you enable merging, it becomes problematic because depending on the conversation these 15 posts can either fill the whole screen, or only half which would look ugly.
the channel render performance is still not good enough to render say 30 posts at once like discord does.
(even though I've put days and days worth of R&D to make it faster, I don't think we could render 30 posts in < 1 second, currently it's 10 initial posts with time of about 600-800ms)
there's no good place for a date timestamp of the last message that's being merged; that can be quite annoying. for example, in discord android you can't see it anywhere
makes it harder to "tap" the message when you want to go into thread view. I am not a thread user myself, but that's something to consider.
IIRC I discussed the idea with project owners and they didn't like it

interesting!
I am adding some images to illustrate what I am talking about.

i am not sure i get it
poor react native performance makes it hard to implement without sacrificing channel loading/switch times heavily :/

Subject: [PATCH] [xx] add experimental posts merge feature

---
 app/components/post/index.js          | 20 +++++++++++++++++++-
 app/components/post/post.js           | 20 +++++++++++++-------
 app/components/post_list/post_list.js |  2 +-
 3 files changed, 33 insertions(+), 9 deletions(-)

diff --git a/app/components/post/index.js b/app/components/post/index.js
index 5722c1f..333810c 100644
--- a/app/components/post/index.js
+++ b/app/components/post/index.js
@@ -9,8 +9,9 @@ import {getPost} from 'mattermost-redux/selectors/entities/posts';
 import {getCurrentUserId, getCurrentUserRoles} from 'mattermost-redux/selectors/entities/users';
 import {getMyPreferences, getTheme} from 'mattermost-redux/selectors/entities/preferences';
 import {getCurrentTeamUrl} from 'mattermost-redux/selectors/entities/teams';
-import {isPostFlagged} from 'mattermost-redux/utils/post_utils';
+import {Posts} from 'mattermost-redux/constants';

+import {isPostFlagged, isPostEphemeral, isSystemMessage, shouldFilterJoinLeavePost, comparePosts} from 'mattermost-redux/utils/post_utils';
 import {insertToDraft, setPostTooltipVisible} from 'app/actions/views/channel';
 import {addReaction} from 'app/actions/views/emoji';
 import {getDimensions} from 'app/selectors/device';
@@ -27,6 +28,22 @@ function mapStateToProps(state, ownProps) {
     let isFirstReply = true;
     let isLastReply = true;
     let commentedOnPost = null;
+
+    const previousPost = ownProps.previousPostId && getPost(state, ownProps.previousPostId);
+    let consecutivePostByUser = false;
+    if (previousPost) {
+        const postFromWebhook = Boolean(post.props && post.props.from_webhook);
+        const prevPostFromWebhook = Boolean(previousPost.props && previousPost.props.from_webhook);
+
+        if (previousPost && previousPost.user_id === post.user_id &&
+                post.create_at - previousPost.create_at <= Posts.POST_COLLAPSE_TIMEOUT &&
+                !postFromWebhook && !prevPostFromWebhook &&
+                !isSystemMessage(post) && !isSystemMessage(previousPost)) {
+            // The last post and this post were made by the same user within some time
+            consecutivePostByUser = true;
+        }
+    }
+
     if (ownProps.renderReplies && post && post.root_id) {
         if (ownProps.previousPostId) {
             const previousPost = getPost(state, ownProps.previousPostId);
@@ -61,6 +78,7 @@ function mapStateToProps(state, ownProps) {
         isLastReply,
         commentedOnPost,
         license,
+        consecutivePostByUser,
         roles,
         theme: getTheme(state),
         isFlagged: isPostFlagged(post.id, myPreferences),
diff --git a/app/components/post/post.js b/app/components/post/post.js
index b40be79..1d4607e 100644
--- a/app/components/post/post.js
+++ b/app/components/post/post.js
@@ -9,10 +9,12 @@ import {
     Platform,
     TouchableHighlight,
     View,
+    Text,
     ViewPropTypes,
 } from 'react-native';
 import {intlShape} from 'react-intl';
 import MaterialIcon from 'react-native-vector-icons/MaterialIcons';
+import {ViewTypes} from 'app/constants';

 import PostBody from 'app/components/post_body';
 import PostHeader from 'app/components/post_header';
@@ -52,6 +54,7 @@ export default class Post extends PureComponent {
         isFirstReply: PropTypes.bool,
         isLastReply: PropTypes.bool,
         isSearchResult: PropTypes.bool,
+        consecutivePostByUser: PropTypes.bool,
         commentedOnPost: PropTypes.object,
         license: PropTypes.object.isRequired,
         managedConfig: PropTypes.object.isRequired,
@@ -381,6 +384,7 @@ export default class Post extends PureComponent {
     render() {
         const {
             commentedOnPost,
+            consecutivePostByUser,
             highlight,
             isLastReply,
             isSearchResult,
@@ -397,7 +401,7 @@ export default class Post extends PureComponent {
         if (!post) {
             return null;
         }
-
+
         const style = getStyleSheet(theme);
         const selected = this.state && this.state.selected ? style.selected : null;
         const highlighted = highlight ? style.highlight : null;
@@ -409,8 +413,8 @@ export default class Post extends PureComponent {
         const postWidth = this.props.deviceWidth - 66;

         return (
-            <View style={[style.container, this.props.style, highlighted, selected]}>
-                <TouchableHighlight
+            <View style={[style.container ]}>
+                {!consecutivePostByUser && <TouchableHighlight
                     style={[style.profilePictureContainer, (isPostPendingOrFailed(post) && style.pendingPost)]}
                     onPress={this.handlePress}
                     onHideUnderlay={this.handleHideUnderlay}
@@ -422,11 +426,13 @@ export default class Post extends PureComponent {
                         onViewUserProfile={this.viewUserProfile}
                         postId={post.id}
                     />
-                </TouchableHighlight>
+                </TouchableHighlight>}
                 <View style={style.messageContainerWithReplyBar}>
                     {!commentedOnPost && this.renderReplyBar()}
-                    <View style={[style.rightColumn, (commentedOnPost && isLastReply && style.rightColumnPadding)]}>
-                        <PostHeader
+                    <View style={[style.rightColumn,
+                            (consecutivePostByUser && {marginLeft: 24 + ViewTypes.PROFILE_PICTURE_SIZE}),
+                            (commentedOnPost && isLastReply && style.rightColumnPadding)]}>
+                        {!consecutivePostByUser && <PostHeader
                             postId={post.id}
                             commentedOnUserId={commentedOnPost && commentedOnPost.user_id}
                             createAt={post.create_at}
@@ -438,7 +444,7 @@ export default class Post extends PureComponent {
                             renderReplies={renderReplies}
                             theme={theme}
                             isFlagged={isFlagged}
-                        />
+                        />}
                         <View style={{maxWidth: postWidth}}>
                             <PostBody
                                 ref={'postBody'}
diff --git a/app/components/post_list/post_list.js b/app/components/post_list/post_list.js
index 1ea7cc7..ed63574 100644
--- a/app/components/post_list/post_list.js
+++ b/app/components/post_list/post_list.js
@@ -22,7 +22,7 @@ import withLayout from './with_layout';

 const PostWithLayout = withLayout(Post);

-const INITIAL_BATCH_TO_RENDER = 15;
+const INITIAL_BATCH_TO_RENDER = 30;
 const NEW_MESSAGES_HEIGHT = 28;
 const DATE_HEADER_HEIGHT = 28;

--
libgit2 0.26.0

@gregoryperrin I can check with our UX team to see what they'd think about doing that. I can't remember if we made a conscious decision to not include that in the mobile app or if it was just left out to save time on an initial version.

Thanks guys, I created a ticket to be discussed in our next triage meeting. This is definitely something we'd like to implement.
https://mattermost.atlassian.net/browse/MM-10285

Thanks esethna, I'll close this issue off here for now and we can track via the above-linked ticket.


Avoid copying java arrays

For once I casted the pointer from (jlong*) to (GrB_Index*) -> avoid copying into a seperate C-array.
As a second step I potentially avoided copying the java array via using GetPrimitiveArrayCritical (in my test it worked, but might be jvm dependend?).
However using GetPrimitiveArrayCritical might be dangerous (see https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/functions.html#GetPrimitiveArrayCritical_ReleasePrimitiveArrayCritical or https://shipilev.net/jvm/anatomy-quarks/9-jni-critical-gclocker/).
Maybe it is an idea to have a global option, whether to use GetPrimitiveArrayCritical or GetLongArray.
On the plus side I could simplify the c-code.
.. also 2 minor things like adding missing status checks and fixing a wrong pointer cast (which I could also cherry pick to another PR)

Before every value in the jlong array was casted to GrB_Index and then assigned to a new GrB_Index array.

I've been considering if this has an impact, given this answer, my C knowledge is lacking at best
uint64_t should be 64bits but jlong is not guaranteed to be 64bits according to this?
https://stackoverflow.com/questions/44996205/is-it-safe-to-cast-jlong-to-long
Also if it is 64bits jlong could be cast into int64_t which is signed rather than uint64_t (unsigned)
The reason it should absolutely work is that GrB_Index in a GrB_Matrix can only go as high as 2^60 (I remember reading this in the user-guide) whereas jlong can hold 2^63 -1 as the highest value.
I would be curious to see if this holds on Mac and Windows, I'll raise an issue to get this compiling for Windows and MacOS

There are certain worrisome implications to this

Note that GetPrimitiveArrayCritical might still make a copy of the array if the VM internally represents arrays in a different format. Therefore we need to check its return value against NULL for possible out of memory situations.

As well as (maybe less important but worrisome)

a VM may temporarily disable garbage collection when the native code is holding a pointer to an array obtained via GetPrimitiveArrayCritical

to mitigate the 1st issue let's check for NULL and return the GrB code for out of memory if it happens
the 2nd issue makes me think if we have lots of pointers of being held in JNI and the GrB_* methods decide to take a long time or they are in blocking mode would we cause the JVM to OOM? (this is subject to heavy usage of the library so I'll let it pass)

Reading the stackoverflow link right, there they mean the C long.
So jlong has a fixed length of 64 bits and the previous cast to a simple long was risky, as long in C is defined with 32 bits (https://en.wikipedia.org/wiki/C_data_types). I think using long long would be the corresponding type for jlong.
In Suitesparse, GrB_Index is defined as an uint64_t.
I couldn't find anything in the UserGuide, but according to its GraphBLAS.h:
The largest valid dimension permitted in this implementation is 2^60.

Hence GraphBLAS should already thrown on larger values, e.g. making the sign bit unimportant (right?) and we can correctly cast the jlong to GrB_Index.
Adding tests to check the right behaviour would be valuable.
Regarding the GetPrimitiveArrayCritical:
As the behaviour also depends on the chosen GC, I think I would prefer having it as an option, whether to use GetLongArray or using the critical version, as a performance improvement. I just liked, that we can avoid copying the arrays this way.
Thanks for noticing, that I forgot to check for NULL These should be definitely added.

Maybe I should add as a caveat that this implementation only works on 64bit systems. Or add a runtime check

It should still work for 32bit systems, but they will need to machine registers to precess 64 bit numbers as far as I could read.

Basically what I'm saying is if you add the NULL check for OOM we can merge. I like not having to copy.
I'm considering adding the extract methods that do 0 copying on the GraphBLAS side GxB_Matrix_export_CSC and the rest.
This library is not used at any scale so far so I'm not worried about a hypothetical GC scenario, we can always add a flag

I added the NULL checks :)
These import/export functions look interesting :+1:
Due to Java's primitive array restriction, an additional runtime check is needed, that nvals is smaller than Integer.MAX_VALUE for the export function right?


Add AGS 6.0.1 support

The problem
Some applications adopt AMD GPU Services (AGS) library for AMD specific features. Gfxreconstruct should be able to capture and replay AMD d3d12 extension calls in AGS.
The solution
We have added the AGS interception DLL to capture AGS calls. This PR includes implementation for encoding and decoding sides (in similar mechanisms as for d3d12 calls, but without code generation). This PR also includes necessary updates to gfxrecon-optimize but not yet for gfxrecon-convert. This implementation supports AGS version 6.0.1 only.
Result
This implementation can be validated with Resident Evil Village (Steam, with DXR turned off) which uses AGS v6.0.1.

Author feimao-gfxr not on autobuild list. Waiting for curator authorization before starting CI build.

CI gfxreconstruct build queued with queue ID 6279.

CI gfxreconstruct build # 2807 passed.

CI gfxreconstruct-extended build queued with queue ID 8351.

CI gfxreconstruct-extended build # 201 running.

CI gfxreconstruct-extended build # 201 passed.

CI gfxreconstruct build queued with queue ID 10202.

CI gfxreconstruct build # 2820 running.

CI gfxreconstruct build # 2820 passed.

CI gfxreconstruct build queued with queue ID 10456.

CI gfxreconstruct build # 2827 running.

CI gfxreconstruct build # 2827 failed.

CI gfxreconstruct build queued with queue ID 10981.

CI gfxreconstruct build # 2833 running.

CI gfxreconstruct build # 2833 passed.


steampipe: init at 0.8.5

Motivation for this change
steampipe is great and I use it in my daily work.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

steampipe supports generating completions for bash, zsh and fish. I have not put any time and effort into getting that to work. I can try to get it to work but I don't think it's a high prio.

steampipe supports generating completions for bash, zsh and fish. I have not put any time and effort into getting that to work. I can try to get it to work but I don't think it's a high prio.

https://github.com/NixOS/nixpkgs/blob/5b5d681a0724cc351e84950e6ec92b22134c0e1a/pkgs/applications/misc/hugo/default.nix#L29

@SuperSandro2000 / @bobby285271 / @kalbasit Any of you familiar with the error above?


Wphu/make remap tsv

I made this script to create seqr remap files, after the Neurodev WES project had over 600 samples to remap, and there was no easy way to take the output from airtable, and format it into columns.
However this probably will be a pointless script once the automatic remapping happens as part of Avery's work.

As I said in a previous comment, I think this is still worth using for now. Alternatively if you are feeling you could get a jump on hitting airtable's API to build the remap using Avery's subset code as a template (https://github.com/broadinstitute/seqr-pipeline-airflow/blob/756fd1777b45b23548429be0bca22fb6964353d3/airflow/dags/seqr-vcf-to-es.py#L337)  and implement that in this script but that's some decent engineering time for sure.

This is no longer needed.


gnupg: make optional dependencies optional

Motivation for this change
gnupg currently pulls in all optional dependencies (which is significant), even if for instance someone only needs a small tool. This patch makes the dependencies configurable, and makes optional dependencies really optional.
I've left the defaults as is. Let me know if this is how this should be done, or if there is another best practise to follow.
Things done

[ ] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

All these extra function arguments seem redundant to me. If I want to disable use of adns, then I'll use gnupg.override { adns = null; } rather than gnupg.override { adnsSuppport = false; }.

Hi @peti, I agree. I've removed the function arguments.

As far as I've understood the discussion here we can close this, right? Feel free to reopen if not.


[1.11] Bump dcos-net

High-level description
Bump dcos-net
Corresponding DC/OS tickets (obligatory)
These DC/OS JIRA ticket(s) must be updated (ideally closed) in the moment this PR lands:

DCOS-52780 ipset protocol ignores a missing match flag on some kernel versions

Related tickets (optional)
Other tickets related to this change:
Checklist for all PRs

[x] Added a comprehensible changelog entry to CHANGES.md or explain why this is not a user-facing change:
[x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here: none
[x] Read the DC/OS contributing guidelines
[x] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[x] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[x] Test Results: [link to CI job test results for component]
[x] Code Coverage (if available): [link to code coverage report]

https://github.com/dcos/dcos-net/compare/c32f9a4b910d6375f68351153c2282e1b9251018...9a51d7dece816c59eea4410d12e2f1689da911e7
https://github.com/dcos/dcos-net/pull/149
https://circleci.com/gh/dcos/dcos-net/1126
https://codecov.io/github/dcos/dcos-net/commit/9a51d7dece816c59eea4410d12e2f1689da911e7

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and review process
What is the review process and when will my changes land?
All PRs require 2 approvals using GitHub's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

@mesosphere-mergebot label [Ready For Review]


IdentityMap may generate the same HashCode for different ids

In the IdentityMap (https://github.com/JasperFx/marten/blob/master/src/Marten/Services/IdentityMap.cs#L69) the generated HashCode is not always unique.
Really hard to provide a failing unit test as the generated hashcode differs from my lab project to a test in Marten.Testing. From MSDN:

However, there is not a unique hash code value for each unique string value. Different strings can return the same hash code.

and

...they should never be used as key fields in a collection...

It's now used as a key in the dictionary in the IdentityMap and may or may not throw exceptions when trying to store two completely different objects in the same session just because their ids generated the same hashcode.

Meh, okay.


doc: doxygen: upgrade to 1.12.0

Use latest version

@gmarull 1.12.0 has now been released :)

@gmarull something's wrong with https://docs.zephyrproject.org/latest/doxygen/html/modules.html - could you please have a look, I am off today/tomorrow

@gmarull something's wrong with https://docs.zephyrproject.org/latest/doxygen/html/modules.html - could you please have a look, I am off today/tomorrow

Apparently they're now called "topics" https://docs.zephyrproject.org/latest/doxygen/html/topics.html

@gmarull something's wrong with https://docs.zephyrproject.org/latest/doxygen/html/modules.html - could you please have a look, I am off today/tomorrow

Apparently they're now called "topics" https://docs.zephyrproject.org/latest/doxygen/html/topics.html

Ah, nevermind, I think the Zephyr Doxygen homepage was serving a cached version when I checked, so it still had the Modules link. You must have wondered why I bothered telling you something was "wrong" :)
All good then, and I actually like it that they moved away from "Modules"


Snapshots don't appear in lxc list

I think we should have the number of snapshots appear in lxc list and also make sure that "lxc list container" lists all the snapshots for "container".
Currently there's no way from the command line tool to see the snapshots.

Note that currently the following works:
Name: u1
Status: STOPPED
Snapshots:
u1/snap0
u1/snap1
However I'll update list to show the information.


Adding css link like the demo

I have looked all over but cannot see how to add a stylesheet link like you have for the demo linking into the foundation stylesheet.  I thought it might be an extension setting, but I just don't see one.  Can you document how to add stylesheet during the conversion process?

The stylesheet is not added to the document but rather to the editor itself.
You can inspect http://showdownjs.github.io/demo/ (by pressing F12 in your browser) to see how the demo was done.


test: Hacbs 1142/test specific timeouts

Description
Test specific timeouts. don't use 10 mins for everything
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
https://issues.redhat.com/browse/HACBS-1142
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("[test_id:01] DEVHAS-62 devfile source")
[ ] I have updated labels (if needed)

//CC @johnbieren


Add an option to manually paste your OTP code

In the event the login button/link in the email does not work, the user should be able to copy and paste a short 6 digit alpha-numeric code to login

Backend otp needs to handle shortcodes.

check #216 loop and handle it with copy/paste


Remove app-specific utils from this repo

If we want to have this repo reusable, it's better remove app-specific utility.

I agree. Not sure how many of them are app-specific though.

We can use this issue to gather though, something post post v1 XD


Remove vendored six with much smaller compat library

This replaces six with a much smaller compat library that only contains a small subset of six

@ruflin squashed :)

@ruflin IGFH (It's Green For Hours) ;p

@beniwohli SATWBM (sorry about that was blind, merged)


GPU RNN to use TempSpace resource for workspace.

Description
This PR eliminates the test flakiness described in https://github.com/apache/incubator-mxnet/issues/15034 (non-deterministic low-probability test_operator_gpu.py:test_rnntanh_bidirectional failures on P40)
The fix was to move the cudnn workspace from a per-op-instance permanent allocation to use the shared TempSpace resource.  Note that for temporary additional workspace, operators typically request space from the shared global TempSpace resource that is maintained for each gpu worker.  This was in fact the approach taken by cudnn_rnn-inl.h before it was combined with rnn-inl.h by  https://github.com/apache/incubator-mxnet/pull/14476.  So in a sense, this PR simply reverts the portion of the 14476 PR that correlates with the flakiness, a much better result than having to revert the entire PR.
Some minor code cleanup was performed around now-unused RNNOp data members dropout_states_ and dropout_bytes_.
@shza @lihaofd @ptrendx
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ X ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ X ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@mxnet-label-bot add [Operator, RNN, pr-awaiting-review]

After battling with the CI and a merge of master (or two), I feel this PR is ready for merging, with approvals from both NVIDIA and Intel. @szha @eric-haibin-lin @ptrendx?


Reproduce results on the SUN dataset

Hi,
I run your code but get unsatisfactory result. In your paper, the results on SUN dataset are 38.1, 89.9, 53.4, but in the process of running your code, the results are 8.5, 89.9, 15.6. Maybe I ignored some important information? Look forward to your reply.

The results on CUB dataset are lower than your results, but the seen result is exactly the same as your seen result. But I have not rewritten your code at all. So this is a bit strange.

Hello,  may I ask whitch dataset you did used? I have downloaded the dataset but there is no train_loc and val_loc in the proposed split, and then I extract them from trainval_loc according to trainclasses.txt and valclasses.txt. But the result is not so well at seen classes whitch is 0.26 on CUB dataset, while that of unseen is better, whitch is 0.34.

@Carey-cc could you provide an idea about how can I extract trainval_loc and val_loc?

@Carey-cc how can I prepare data for the cub dataset for training network?

@lerndeep

you can extract train_loc and val_loc accrording to the trainclasses.txt and valclasses.txt. python code:
`def load_data(att_path, res_path, val_size, trainval_split=1):
"""
:param val_size: if there is no train_loc and val_loc, even without trainclasses.txt and valclasses.txt,
random split train and val
:param trainval_split: if there is no train_loc and val_loc, this parameter decide use which txt file.
:return:
"""
att_feats_dat = sio.loadmat(str(att_path))
res_feats_dat = sio.loadmat(str(res_path))
features = res_feats_dat['features'].transpose()
features /= np.max(features, axis=0)
labels = res_feats_dat['labels'].squeeze().astype(int) - 1
allclasses_names = att_feats_dat['allclasses_names'].squeeze()
allclasses_names = np.array([i[0] for i in allclasses_names])
att_feats = att_feats_dat['att'].transpose()
try:
id_train = att_feats_dat['train_loc'+str(trainval_split)].squeeze() - 1
id_val = att_feats_dat['val_loc'+str(trainval_split)].squeeze() - 1
train_class = np.unique(labels[id_train])
val_class = np.unique(labels[id_val])
except KeyError:
# if there is only trainval_loc but no train_loc and val_oc
id_trainval = att_feats_dat['trainval_loc'].squeeze() - 1
labels_trainval = labels[id_trainval]
try:
# extract train_loc and val_loc according to trainclasses.txt and valclasses.txt
path = os.path.abspath(os.path.dirname(att_path))
trainclasses_names = np.loadtxt(path + '/trainclasses'+str(trainval_split)+'.txt', dtype=str)
valclasses_names = np.loadtxt(path + '/valclasses'+str(trainval_split)+'.txt', dtype=str)
train_class = np.where(pd.Index(trainclasses_names).get_indexer(allclasses_names) >= 0)[0]
val_class = np.where(pd.Index(valclasses_names).get_indexer(allclasses_names) >= 0)[0]
except OSError:
trainval_class = np.unique(labels_trainval)
train_class, val_class = train_test_split(trainval_class, test_size=val_size, random_state=7)
# extract train_loc and val_loc from trainval_loc
# change labels_trainval to labels if you want to extract train_loc and val_loc from whole dataset
id_train = id_trainval[np.where(pd.Index(pd.unique(train_class)).get_indexer(labels_trainval) >= 0)[0]]
id_val = id_trainval[np.where(pd.Index(pd.unique(val_class)).get_indexer(labels_trainval) >= 0)[0]]
print('train classes num: ', len(train_class))
print('val classes: \r\n', allclasses_names[val_class])
id_test_unseen = att_feats_dat['test_unseen_loc'].squeeze() - 1
try:
id_test_seen = att_feats_dat['test_seen_loc'].squeeze() - 1
except KeyError:
id_test_seen = None
num_class = att_feats.shape[0]
test_class = np.unique(labels[id_test_unseen])
if id_test_seen is not None:
test_class_s = np.unique(labels[id_test_seen])
else:
test_class_s = []
train_x = features[id_train]
train_y = labels[id_train]
train_data = list(zip(train_x, train_y))
val_x = features[id_val]
val_y = labels[id_val]
val_data = list(zip(val_x, val_y))
test_x = features[id_test_unseen]
test_y = labels[id_test_unseen]
test_data = list(zip(test_x, test_y))
if id_test_seen is not None:
test_s_x = features[id_test_seen]
test_s_y = labels[id_test_seen]
test_data_s = list(zip(test_s_x, test_s_y))
print("test seen", len(test_s_y), len(np.unique(test_s_y)))
else:
test_data_s = []
class_label = dict()
class_label['train'] = list(train_class)
class_label['val'] = list(val_class)
class_label['test'] = list(test_class)
class_label['test_s'] = list(test_class_s)
class_label['num_class'] = num_class
return att_feats, train_data, val_data, test_data, test_data_s, class_label, allclasses_names`

you can also do this by MATLAB.

you can just download the dataset from https://www.dropbox.com/sh/btoc495ytfbnbat/AAAaurkoKnnk0uV-swgF-gdSa?dl=0(provided by https://github.com/edgarschnfld/CADA-VAE-PyTorch). But this spilt is kind of strange. It extract train_loc and val_loc from the whole dataset.

Hello, when I reproduce the cub, why is the output result always 0, and the result of awa is not clear. Can you provide the model you have trained?


On the Mvtec dataset, the AUROC metric is significantly lower than the values reported in the paper.

use this  command line :python scripts/run_fade.py --dataset-name mvtec --dataset-source  data/mvtec --experiment-name mvtec/zeroshot/cm_both_sm_both_clip_gem_gem/img_size_0 --classification-mode both --segmentation-mode both --shots 0 --language-classification-feature clip --language-segmentation-feature gem --vision-feature gem --vision-segmentation-multiplier 80.0 --vision-segmentation-weight 0.5 --use-query-img-in-vision-memory-bank

@fpgboy same you

Hi @fpgboy and @abcilike, apologies for the late reply.
If you are still interested in trying it out, could you please share:

model weights you use to initialise CLIP
torch version and open_clip_torch version

I just gave it a spin with [vit_b_16_plus_240-laion400m_e31-8fb26589.pt](https://github.com/mlfoundations/open_clip/blob/main/src/open_clip/pretrained.py) and torch=2.2.0 and open_clip_torch=2.24.0 and obtained the same results as in the supplementary materials. I did spot one inconsistency in the code, fixed it now. But it should not impact results this much.

@fpgboy和你一样

same to you

Dear Author, Hello, I am also unable to achieve the results reported in the paper. Could you explain the specific reasons for this discrepancy? The dataset I used was downloaded directly from the provided link and placed directly into the code, so I assume it shouldn't be significantly related to the dataset itself, right? Is it about taking the largest value among all the items extracted? However, even the maximum values in some of my data do not reach those given in the paper.

@fpgboy和你一样

你也是

Hello, Have you successfully reproduced the results yet?

你也是

Hello,Have you successfully reproduced the results yet?

Hi all, could you please downgrade your packages to
torch=2.2.0
open_clip_torch=2.24.0
torchvision=0.17.0
and check it helps? Please make sure you use the right weights too.

The problem is new version of open_clip_torch (above 2.24.0) messing up GEM, and it leads to bad performance. Downgrading open_clip_torch to 2.24.0 resolved the problem.


chore: Add language to code manifest code fences

Minor, but was set on some and not others

@nschonni Nice, I have sent this to the author so they can merge it, since I'm not as familiar with this area. Looks like a nice catch though.

Thanks @nschonni :)


[libxcrypt] Build error on x64-linux

Package<EMAIL_ADDRESS>Host Environment

Host: x64-linux
Compiler: GNU 13.2.1
vcpkg-tool version: 2024-02-05-9c1e418fc6264dffcab6ca47746a648c35c379b9
vcpkg-scripts version: 66b4b34d9 2024-02-06 (7 hours ago)

To Reproduce
vcpkg install opencv
Failure logs
-- Using cached besser82-libxcrypt-v4.4.36.tar.gz.
-- Cleaning sources at /home/fuyang/Workspace/demo/c_cpp/vcpkg/buildtrees/libxcrypt/src/v4.4.36-645fb55159.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source /home/fuyang/Workspace/demo/c_cpp/vcpkg/downloads/besser82-libxcrypt-v4.4.36.tar.gz
-- Using source at /home/fuyang/Workspace/demo/c_cpp/vcpkg/buildtrees/libxcrypt/src/v4.4.36-645fb55159.clean
-- Getting CMake variables for x64-linux-dbg
-- Getting CMake variables for x64-linux-rel
-- Generating configure for x64-linux
-- Finished generating configure for x64-linux
-- Configuring x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /usr/bin/bash -c "V=1 ./../src/v4.4.36-645fb55159.clean/configure  \"--disable-silent-rules\" \"--verbose\" \"--disable-shared\" \"--enable-static\" \"--prefix=/home/fuyang/Workspace/demo/c_cpp/vcpkg/installed/x64-linux/debug\" \"--bindir=\\${prefix}/../tools/libxcrypt/debug/bin\" \"--sbindir=\\${prefix}/../tools/libxcrypt/debug/sbin\" \"--libdir=\\${prefix}/lib\" \"--includedir=\\${prefix}/../include\" \"--datarootdir=\\${prefix}/share/libxcrypt\""
    Working Directory: /home/fuyang/Workspace/demo/c_cpp/vcpkg/buildtrees/libxcrypt/x64-linux-dbg
    Error code: 1
    See logs for more information:
      /home/fuyang/Workspace/demo/c_cpp/vcpkg/buildtrees/libxcrypt/config-x64-linux-dbg-config.log
      /home/fuyang/Workspace/demo/c_cpp/vcpkg/buildtrees/libxcrypt/config-x64-linux-dbg-out.log
      /home/fuyang/Workspace/demo/c_cpp/vcpkg/buildtrees/libxcrypt/config-x64-linux-dbg-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_make.cmake:862 (vcpkg_execute_required_process)
  ports/libxcrypt/portfile.cmake:10 (vcpkg_configure_make)
  scripts/ports.cmake:170 (include)

/home/fuyang/Workspace/demo/c_cpp/vcpkg/buildtrees/libxcrypt/config-x64-linux-dbg-err.log
Can't locate open.pm in @INC (you may need to install the open module) (@INC entries checked: /usr/local/lib64/perl5/5.38 /usr/local/share/perl5/5.38 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at ./../src/v4.4.36-645fb55159.clean/build-aux/scripts/expand-selected-hashes line 20.
BEGIN failed--compilation aborted at ./../src/v4.4.36-645fb55159.clean/build-aux/scripts/expand-selected-hashes line 20.
configure: error: bad value 'all' for --enable-hashes

I can't reproduce this issue in my side:
xxx-linux:~/vcpkg$ ./vcpkg install libxcrypt:x64-linux --editable
Computing installation plan...
The following packages will be built and installed:
<EMAIL_ADDRESS>Installing 1/1<EMAIL_ADDRESS>Building<EMAIL_ADDRESS>-- Using cached besser82-libxcrypt-v4.4.36.tar.gz.
-- Using source at /home/mmm/vcpkg/buildtrees/libxcrypt/src/v4.4.36-645fb55159
-- Getting CMake variables for x64-linux-dbg
-- Getting CMake variables for x64-linux-rel
-- Generating configure for x64-linux
-- Finished generating configure for x64-linux
-- Configuring x64-linux-dbg
-- Configuring x64-linux-rel
-- Building x64-linux-dbg
-- Installing x64-linux-dbg
-- Building x64-linux-rel
-- Installing x64-linux-rel
-- Fixing pkgconfig file: /home/mmm/vcpkg/packages/libxcrypt_x64-linux/lib/pkgconfig/libcrypt.pc
-- Fixing pkgconfig file: /home/mmm/vcpkg/packages/libxcrypt_x64-linux/lib/pkgconfig/libxcrypt.pc
-- Fixing pkgconfig file: /home/mmm/vcpkg/packages/libxcrypt_x64-linux/debug/lib/pkgconfig/libcrypt.pc
-- Fixing pkgconfig file: /home/mmm/vcpkg/packages/libxcrypt_x64-linux/debug/lib/pkgconfig/libxcrypt.pc
-- Performing post-build validation
Elapsed time to handle libxcrypt:x64-linux: 18 s
Total install time: 18 s
libxcrypt provides pkg-config modules:

    # Extended crypt library for DES, MD5, Blowfish and others
    libcrypt

    # Extended crypt library for DES, MD5, Blowfish and others
    libxcrypt

xxx-linux:~/vcpkg$ ./vcpkg --version
vcpkg package management program version 2024-02-05-9c1e418fc6264dffcab6ca47746a648c35c379b9

See LICENSE.txt for license information.
xxx-linux:~/vcpkg$ gcc --version
gcc (Ubuntu 13.2.0-4ubuntu3) 13.2.0
Copyright (C) 2023 Free Software Foundation, Inc.

Can't locate open.pm in @INC (you may need to install the open module) (@INC entries checked: /usr/local/lib64/perl5/5.38 /usr/local/share/perl5/5.38 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at ./../src/v4.4.36-645fb55159.clean/build-aux/scripts/expand-selected-hashes line 20.
BEGIN failed--compilation aborted at ./../src/v4.4.36-645fb55159.clean/build-aux/scripts/expand-selected-hashes line 20.

Broken or incomplete installation of Perl.

I can reproduce this with:
docker run --rm dockcross/manylinux_2_28-x64 > dockcross-manylinux_2_28-x64
bash dockcross-manylinux_2_28-x64 -a '-it' bash

$ pkgconf --version
1.4.2
$ pkg-config --version
1.4.2
$ gcc --version
gcc (GCC) 12.1.1 20220628 (Red Hat 12.1.1-3)
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
$ perl --version

This is perl 5, version 26, subversion 3 (v5.26.3) built for x86_64-linux-thread-multi
(with 57 registered patches, see perl -V for more detail)

$ git clone --depth 1 https://github.com/microsoft/vcpkg.git
$ ./vcpkg/bootstrap-vcpkg.sh -disableMetrics
$ ./vcpkg/vcpkg --version
vcpkg package management program version 2024-02-07-8a83681f921b10d86ae626fd833c253f4f8c355b

See LICENSE.txt for license information.
$ ./vcpkg/vcpkg install libxcrypt

That is an older Perl (from 2017), yes, but definitely not broken.
For completeness, config-x64-linux-dbg-err.log:
./../src/v4.4.36-645fb55159.clean/configure: line 4699: PKG_PROG_PKG_CONFIG: command not found
./../src/v4.4.36-645fb55159.clean/configure: line 4701: PKG_INSTALLDIR: command not found
Can't locate open.pm in @INC (you may need to install the open module) (@INC contains: /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at ./../src/v4.4.36-645fb55159.clean/build-aux/scripts/expand-selected-hashes line 20.
BEGIN failed--compilation aborted at ./../src/v4.4.36-645fb55159.clean/build-aux/scripts/expand-selected-hashes line 20.
configure: error: bad value 'all' for --enable-hashes

You can see this Perl issue, and also a separate issue with pkg-config.
pkg-config: The "dockcross" system is using pkgconf.1.4.2 rather than pkg-config. The PKG complaints go away when installing https://pkgconfig.freedesktop.org/releases/pkg-config-0.29.tar.gz (which is a band-aid), but the perl complaints still remain.

There the fix was:
$ yum install perl-open

which is a direct line from the underlying problem:
Can't locate open.pm in @INC (you may need to install the open module) (@INC entries checked: /usr/local/lib64/perl5/5.38 /usr/local/share/perl5/5.38 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at ./../src/v4.4.36-645fb55159.clean/build-aux/scripts/expand-selected-hashes line 20.

(And the pkg-config thing does print errors when using only pkgconf.1.4.2 but successfully builds anyway).


More performant data subject resolving

Hi colleagues,
we can have entities with tens of unique data subject modifications. The current lookup awaits every single one. With the PR the requests are bundled and executed in parallel to reduce response times.
BR,
Marten

superseded by https://github.com/cap-js/audit-logging/pull/127


Session cookie expiration issues

Hi,
I have a problem with setting my cookie expiration. I'm attempting to set up a 'remember me' functionality and going from the documentation I implemented this:
const expirationTime = this.get('rememberMe') ? (14 * 24 * 60 * 60) : null;
this.set('session.store.cookieExpirationTime', expirationTime);

The problem is if I set 'remember me' with an expiration of 14 days later and log out/log in again without 'remember me', passing in null seems to leave the cookie at the original date of 14 days later instead of switching it to a session cookie. From reading through issue #395 it sounds like that is because the default when the window is reopened will be that original 14 days later.
I personally got passed this by just passing 'Session' into the expiration time (even though the documentation expresses that it expects an int or null) like so:
const expirationTime = this.get('rememberMe') ? (14 * 24 * 60 * 60) : 'Session';
this.set('session.store.cookieExpirationTime', expirationTime);

Whether this is intended or not, I don't know, but it is working perfectly so far. Is this a bug or is the documentation lacking? Or am I potentially doing something wrong?

I guess this might actually be a bug. Actually the cookie would have to be rewritten when any of the relevant attributes of the store change. Would be cool if you could submit a PR that fixes that.

This is fixed in 1.20.

I am still seeing the described issue of wiatrp on current master version.
this.set('session.store.cookieExpirationTime', 60 * 60 * 24 * 14);
…
this.set('session.store.cookieExpirationTime', null);

=> Cookies are expiring in 14d. (Cookies/Auth-State persist browser close)
=> Expected: Cookies should be rewritten as SessionCookie

I do not want to hurry you, but are you already looking into the issue respectively do you have any timeframe?

@ktrhn We are looking into it and should have a fix soon. Work is in progress in #1257

#1257 didn't seem to fix this. At least it is not working yet in 1.2.1

@stevenwu: seems like this line would cause it to break for an expiration time of null? Do we need the check at all actually? I don't remember why it was added…

There seems to be a problem in ember-cookies that returns undefined in places where we'd expect an empty string actually:
$E.write('test', null)
var a = $E.read('test')
a // undefined

That needs to be fixed. Then we can fix the line above and simply always update the expiration time property when the cookie exists, regardless of the value we get from the cookie.

Any update on this? It causes some issues with Fastboot logging out on IOS which doesnt occur on desktop.

I think what we should actually do is to check here whether the cookie exists at all and if so restore the value from it (if the value us null, restore that etc.).

my current solution:
const expirationTime = this.get('rememberMe') ? (14 * 24 * 60 * 60) : 90;
this.set('session.store.cookieExpirationTime', expirationTime);

cleaning up old issues


Templates: update React's component's State and Property type

The React templates used any and void as State and Property types for React.Component, even though it should be {}.

@stephtr,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Thanks @stephtr - this looks good!

@stephtr Why was void considered incorrect? Just curious. Thanks!

That question was best answered in TypeScript #15409: props is always an object, even without properties.


[stable/kubernetes-dashboard] with ALB ingress authentication error

Describe the bug
Error authenticating to dashboard when connecting through ALB ingress.
Version of Helm and Kubernetes:
Helm: 3
kubectl: 1.14
EKS:

kubernetes 1.14
eks.3

Which chart:
stable/kubernetes-dashboard
What happened:
I installed stable/kubernetes-dashboard using the following command:
helm install kubernetes-dashboard stable/kubernetes-dashboard \
    -f dashboard-values.yaml \
    --version 1.10.1 \
    -n kube-system

dashboard-values.yaml looks like this:
---
enableInsecureLogin: true
rbac:
  # FIX: DANGEROUS, remove once you learn more about authentication
  clusterAdminRole: true
service:
  type: NodePort
ingress:
  enabled: true
  annotations:
    kubernetes.io/ingress.class: alb
    alb.ingress.kubernetes.io/scheme: internal
  hosts:
    - dashboard.mydomain
  paths:
    - /
    - /*
...

If I use the port-forward way of connecting I can easily authenticate (regardless of admin permissions or not). If however I try to access via http://dashboard.mydomain/ I can't authenticate, It just stays on the login page. In the js console I see:
Possibly unhandled rejection: {"data":"MSG_LOGIN_UNAUTHORIZED_ERROR\n","status":401,"config":{"method":"GET","transformRequest":[null],"transformResponse":[null],"jsonpCallbackParam":"callback","url":"api/v1/rbac/status","headers":{"Accept":"application/json, text/plain, */*"}},"statusText":"Unauthorized","xhrStatus":"complete","resource":{}}

What you expected to happen:
I should be able to authenticate
How to reproduce it (as minimally and precisely as possible):
probably follow the steps above in an EKS environment configured for ALB and DNS (sample instructions for enabling ALB are here).
Anything else we need to know:
Note that this is internal ALB (if it matters in any way).

this is the same issue than https://github.com/helm/charts/issues/13390#issuecomment-582324517
just open https://dashboard.mydomain/


Keyboard layout ignored

Issue Type: Bug
I have a dual-keyboard layout set up where I use Dvorak at work and QWERTY at home; When VS Code starts up it always picks Dvorak despite QWERTY being the currently selected layout. This makes VS Code impossible to use as there is no feedback and it completely ruins the experience.
Additionally the documentation is not very useful, and is to be honest quite dense.
Oh well, at least I don't cut code that often; because that'd drive me mad.
VS Code version: Code - OSS 1.22.2 (3aeede733d9a3098f7b4bdc1f66b63b0f48c1ef9, 2018-04-13T19:17:59Z)
OS version: Linux x64 4.15.17-64.current

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-5600U CPU @ 2.60GHz (4 x 2646)

Load (avg)
2, 2, 1

Memory (System)
15.44GB (0.97GB free)

Process Argv
/usr/share/vscode/code-oss

Screen Reader
no

VM
0%

Extensions (2)

Extension
Author (truncated)
Version

vscode-rust
kal
0.4.2

atom-keybindings
ms-
3.0.4

Please see https://github.com/Microsoft/vscode/wiki/Keybinding-Issues#troubleshoot-linux-keybindings

Duplicate of #24166