Add concurrency settings for workflow

Fixes

Fixes #267 by @sarayourfriend
Description

This pull request Adds concurrency settings for workflow
Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Hi @alrz1999, this looks excellent. To close the parent issue #267 this will need to be implemented in a few other repositories:

https://github.com/WordPress/openverse-api
https://github.com/WordPress/openverse-catalog
https://github.com/WordPress/openverse-frontend

Would you be interested in making pull requests for those repositories as well?
I believe this PR looks good, though. Thank you for your contribution!

@alrz1999 Thanks for the contribution! Can you run the linter locally by running just lint in the root directory and then committing the automated changes? Once that is done we can merge this PR :rocket:

Also @alrz1999 apologies that I forgot to mention that some workflows are synced across repositories (see this comment for details):
https://github.com/WordPress/openverse-frontend/pull/1881#pullrequestreview-1130808296

Thanks @alrz1999, congrats on the merge :tada:


Remove "/pfs/prev"

In the past we needed "/pfs/prev" because it wasn't possible to read from "/pfs/out". Now that it is I don't think "/pfs/prev" is doing us much good and I think removing it would simplify things. It's probably best to do this sooner rather than later so people have less time to depend on its existence in their code.
Anyone have objections to getting rid of it?

Am I right in understanding that /pfs/out right now presents the exact same content as /pfs/prev before any writes?

Yes, I believe that's the case.

#1078 makes /pfs/out a real (i.e. non-FUSE) directory, thereby making /pfs/prev necessary again.  Closing.
P.S. we have discussed some designs that would remove /pfs/prev in favor of a better abstraction, such as #1057.


Add support for AWS Cognito Triggers

Description
Add support for configuring AWS Cognito triggers.
You can now map any of the triggerSources documented
http://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-identity-pools-working-with-aws-lambda-triggers.html to any function in your Zappa deployment.
This allows for extensive, simple customisation of the AWS Cognito authentication flow, so you can automatically approve users from defined domains.   If you need to check those domains against blacklists in your DB you have all the same access to DB records from the handler.
GitHub Issues

Coverage decreased (-0.7%) to 72.999% when pulling a44f56eea33b64ebe7c1ca41c9c2e231c035346e on millarm:master into 746cd5fa002cc57c3f2f28b07edaaab4f235a02f on Miserlou:master.

Coverage decreased (-0.2%) to 73.481% when pulling 2b937f74ada2f7d10e9e0f16363c9071459c2bba on millarm:master into 746cd5fa002cc57c3f2f28b07edaaab4f235a02f on Miserlou:master.

Coverage decreased (-20.4%) to 53.261% when pulling 8f2111e91b9551e317991f4dbbf76e4128bb746a on millarm:master into 746cd5fa002cc57c3f2f28b07edaaab4f235a02f on Miserlou:master.

Have I mentioned how much I love unit tests + travis?  :-)

Coverage increased (+0.2%) to 73.819% when pulling a56d0bb5b5c9f717dcbaf69ddace968a04731abb on millarm:master into 746cd5fa002cc57c3f2f28b07edaaab4f235a02f on Miserlou:master.

Coverage increased (+0.2%) to 73.819% when pulling a56d0bb5b5c9f717dcbaf69ddace968a04731abb on millarm:master into 746cd5fa002cc57c3f2f28b07edaaab4f235a02f on Miserlou:master.


Feature: Add BitBucket Server (not Cloud) as supported GitOps provider

🔖 Feature description
Would be nice to support BitBucket Server as well. The configuration shouldn't be very different, but as far as I know BitBucket doesn't have the concept of Workspace, which is a mandatory field when configuring BitBucket (Cloud) as a GitOps provider.
https://en.wikipedia.org/wiki/Bitbucket
https://support.atlassian.com/migration/docs/differences-administering-bitbucket-data-center-and-cloud/
🎤 Pitch / Usecases
For the ones who want to host their GitOps repos on-prem, right now the only possibility is GitLab
🔄 Alternative
The only alternative to have the GitOps on-prem is GitLab
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

AB#9134

Fixed with attached PRs


[New game]: Mosquito Whack: The Ultimate Bug-Busting Challenge!

🎮 Game Request
Basic Description:
"Mosquito Whack" is an engaging and fast-paced game designed to test your reflexes and precision. The objective of the game is to swat as many mosquitoes as possible within a 30-second timeframe. Each successful hit awards points, while missing three mosquitoes results in game over. The game is complemented by lively background music and satisfying sound effects upon each successful hit, enhancing the overall gaming experience.
Game Logic:
1 Game Start:
The game begins with a start screen where the player can start the game.
Background music starts playing as soon as the game begins.
2 Gameplay:
A 30-second timer starts counting down once the game begins.
Mosquitoes appear randomly on the screen at varying intervals and locations.
The player must click or tap on the mosquitoes to "whack" them.
3Scoring:
Each successful mosquito hit scores points for the player.
A sound effect is played with each successful hit to provide feedback.
4 Miss Count:
The player has three chances to miss hitting a mosquito.
Each time the player misses a mosquito, a miss counter increases.
If the miss counter reaches three, the game is over.
5 Timer:
The game runs on a 30-second timer.
When the timer reaches zero, the current game session ends.
If the game ends due to time running out, it automatically restarts for another session.
6 Game Over Conditions:
The game ends if the player misses three mosquitoes.
A game over screen is displayed, showing the player's score and an option to play again.
7Game Restart:
If the 30-second timer expires, the game restarts automatically for another round of mosquito whacking.
The player can also manually restart the game from the game over screen.
VIDEO
https://github.com/user-attachments/assets/86a08beb-7886-411f-bf52-8e684f5272ae
Point down the features
Features:
⦿ Background Music: Keeps the player engaged with an energetic soundtrack.
⦿ Sound Effects: Provides auditory feedback for each successful hit, adding to the game's excitement.
⦿ Score Display: Shows the player's current score during gameplay.
⦿ Miss Counter: Displays the number of misses, giving the player a visual cue of their remaining chances.
⦿ Timer Display: Keeps the player informed about the remaining time in the game session.
Select program in which you are contributing
IWOC2024, GSSoC24, hacktoberfest, Other
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @ankit071105 , You can't have another issue before completing the previous one 😀
you already have the following 1 open issues 👀 ! :
#4845

Hey @ankit071105 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇

Hey @ankit071105 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

assigned


404 page not found

Not sure if I did something wrong, once I cloned the repository and ran the installer (locally or the build command for Docker) I am ending up in getting a '404 page not found' error when connecting to localhost:8000.
Any advice?

You're going to want to view localhost:8000/webui/ for the web ui.

@little-joe999 since it seems like your issue is resolved I'm going to close this, but please reopen it if I'm mistaken.

Oh yeah, sorry forgot to reply. The link you've provided solved the issue. Thanks a lot.


helia.blockstore.get hangs when getting non-existent block but blockstore.get (correctly) errors

When retrieving a non-existent block by cid using helia.blockstore.get, the get function hangs indefinitely. However, when accessing blockstore.get directly, get function immediately throws an error (correct behaviour).
This issue occurs with default MemoryBlockstore only. I'm assuming helia.blockstore is some kind of wrapper around MemoryBlockstore and the error is maybe being caught by the wrapper but the wrapper doesn't exit properly on error?
To replicate:
import { createHelia } from 'helia'
import * as Block from 'multiformats/block'
import * as dagCbor from '@ipld/dag-cbor'
import { sha256 } from 'multiformats/hashes/sha2'

const codec = dagCbor
const hasher = sha256

const block = await Block.encode({ value: 'hello world', codec, hasher })
const ipfs = await createHelia()

// await ipfs.blockstore.put(block.cid, 'hello world')

try {
  console.log(await ipfs.blockstore.get(block.cid)) // <-- This never returns, it just hangs indefinitely.
} catch (error) {
  console.log('error') // <-- It never makes it here. But use MemoryBlockstore.get directly and it errors immediately.
} finally {
  await ipfs.stop()
}

Helia wraps the passed blockstore in a network-aware layer - so if you try to get a block without it being present in node.blockstore, it'll start searching the network to find it.  By default this means bitswap and HTTP gateways.
The current behaviour of bitswap is to wait until either it finds the block or an abort signal fires* so you should do something like:
try {
  await ipfs.blockstore.get(cid, {
    signal: AbortSignal.timeout(5000) // abort after 5s
  })
} catch (err) {
  //...
}

The underlying memory blockstore will throw immediately because it's very simple and doesn't have the network fetch capability.

* = this may change in a future release - the change would be to search for providers, if none are found then give up and throw

Thanks @achingbrain makes sense. Your above suggestion worked. Closing.


[core: 2.6.0-alpha.2] - [fix] - Autoselect  with disabled modals resolve

Description
This PR fixes an issue where the call to connectWallet would not resolve or reject if called with the autoSelect parameter for a wallet that is no longer available.
Fixes #1153
Checklist

[x] The version field in package.json is incremented following semantic versioning
[x] The box that allows repo maintainers to update this PR is checked
[x] I tested locally to make sure this feature/fix works
[x] I have run yarn type-check & yarn build to confirm there are not any associated errors
[x] This PR passes the Circle CI checks

这个问题解决了吗？我现在用 @web-onboard/core ^2.21.1 的版本。label 随便填写一个钱包，并不会报错，我没法 catch 到这个错误，以至于我的代码不知道是不是除了问题


[Feature] The filtering feature of events

Search before asking

[X] I had searched in the issues and found no similar issues.

Feature Request
I would like to contribute a filtering feature for events. Here is my rough design idea.
First, when creating a subscription, add a new json String field 'filter' to the SubscriptionItem to describe the specific filtering rules.for example
{
	"and": [{
		"field": "specversion",
		"operator": "EQ",
		"value": "1.0"
	}, {
		"or": [{
			"field": "id",
			"operator": "EQ",
			"value": "9aeb0fdf-c01e-0131-0922-9eb54906e209"
		}, {
			"field": "email",
			"operator": "CN",
			"value": "example"
		}]
	}, {
		"field": "data.contentType",
		"operator": "SW",
		"value": "image/png"
	}]
}

When a consumer consumes, check the 'filter' field and convert it into a 'FilterGroup'. Then, generate a combined predicate based on the rules and provide the filtering results.
The logical relationship between the rules is described by 'and' and 'or'. The 'field' field describes the field to be checked, the 'operator' describes the specific rule, and the 'value' describes the comparison data for the rule.
The value of the field field can be a nested field in the event, expressed as a hierarchical relationship using  '.'.
and This is the filtering process.
sequenceDiagram
    participant Consumer
    participant FilterGroup
    participant SubscriptionItem
    participant SubscriptionItem
    Consumer->>+FilterGroup: Transform event to JSON
    FilterGroup->>SubscriptionItem: Get filter rules JSON
    FilterGroup->>FilterGroup: Parse filter rules JSON
    FilterGroup->>FilterGroup: Generate combined predicate
    FilterGroup->>+FilterRule: Predicate rules
    Note over FilterRule: Loop for all rules
    FilterRule->>FilterRule: Rule 1 apply
    FilterRule->>FilterRule: Rule 2 apply
    FilterRule->>FilterRule: Rule 3 apply
    Note over FilterRule: End of loop
    FilterRule->>-FilterGroup: Allowed or denied
    alt FilterGroup allowed or denied
        FilterGroup->>-Consumer: Allowed or denied
    else FilterGroup throws exception
        FilterGroup->>Consumer: Apply default strategy
    end

And provide optional default policy to handle filtering exceptions for allowing or denying access.
I have initially designed the following specific types of rules:

operator
class

EQ
EqualFilterRule

NE
NotEqualFilterRule

GT
GreaterThanFilterRule

GE
GreaterThanOrEqualFilterRule

LT
LessThanFilterRule

LE
LessThanOrEqualFilterRule

BT
BetweenFilterRule

CN
ContainsFilterRule

NC
NotContainsFilterRule

SW
StartsWithFilterRule

EW
EndsWithFilterRule

RE
RegexFilterRule

IN
InFilterRule

NIN
NotInFilterRule

EX
ExistsFilterRule

NEX
NotExistsFilterRule

NOT
NotFilterRule

NL
NullFilterRule

NN
NotNullFilterRule

EQT
EpochTimeFilterRule

GTT
GreaterThanTimeFilterRule

LTT
LessThanTimeFilterRule

BT
BetweenTimeFilterRule

I have started working on the implementation of this code. Please consider my approach, which can also be applied to similar transformation features.
The bolded rules have been implemented. Rules can be continuously extended by implementing the interface.
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

@epiao55 Hi,
first of all, thank you for your design of the Event Filter scheme. You can refer to the code of eventmesh-filters branch. Your scheme seems to apply the event filter rule configuration and processing filtering from the consumer sdk side when subscribing. We hope to be able to use it from the EventMesh API Layer design and implement filter and transformer capabilities in EventMesh runtime. We can arrange a meeting to discuss the design plan and talk about the specific design ideas.

@epiao55 Hi, first of all, thank you for your design of the Event Filter scheme. You can refer to the code of eventmesh-filters branch. Your scheme seems to apply the event filter rule configuration and processing filtering from the consumer sdk side when subscribing. We hope to be able to use it from the EventMesh API Layer design and implement filter and transformer capabilities in EventMesh runtime. We can arrange a meeting to discuss the design plan and talk about the specific design ideas.
@xwm1992 Thank you for your reply, I will first understand the existing design of this part. And How can I contact you

@epiao55 Hi, first of all, thank you for your design of the Event Filter scheme. You can refer to the code of eventmesh-filters branch. Your scheme seems to apply the event filter rule configuration and processing filtering from the consumer sdk side when subscribing. We hope to be able to use it from the EventMesh API Layer design and implement filter and transformer capabilities in EventMesh runtime. We can arrange a meeting to discuss the design plan and talk about the specific design ideas.
@xwm1992 Thank you for your reply, I will first understand the existing design of this part. And How can I contact you

you can contact with the eventmesh wechat helper, and this design is similar to the design of zuul 2.0. If you have a better design reference, you can also put it forward.

@epiao55 good idea!


Where can I download the pretrained weights?

Thank you for the awesome work! Can you kindly let me know where can I get the pretrained weights?

Hey, I no longer have any pretrained weights. But let me know if you need help in training on the data yourself!

Also, where can I get the triplet dataset?


flake8's (W503 and) W504

flake8 has two rules W503 and W504 that don't seem to be in ruff==0.0.263.

https://github.com/PyCQA/flake8/issues/494 mentions that W503 shouldn't exist
https://stackoverflow.com/questions/73568036/flake8-line-break-before-binary-operator-how-to-fix-it discusses W503 and W504

Any thoughts on ruff implementing W504 with autofix?

I think we're unlikely to implement W503 and W504, since we're likely not going to implement the pycodestyle rules that are ignored-by-default (due to being non-unanimously accepted, and non-violations of PEP8, per the pycodestyle docs).
W503 is a little more problematic, since it conflicts with Black. W504 might not conflict with Black, but I'm still hesitant to support it given that it's disabled-by-default in pycodestyle and Flake8.

(As always, totally open to further discussion -- I just tend to close issues by-default when answering a question, to try and manage the issue queue responsibly.)

Oh sure, this conclusion is fine with me, thanks!  I realize I have been making a lot of issues here, but it's okay to close them.
For me to remove flake8, I want to make sure the rule coverage is the same.  With W504 dispatched (per this issue), the last outstanding items are:

doctests = True: https://github.com/charliermarsh/ruff/issues/3542
flake8-requirements: https://github.com/charliermarsh/ruff/issues/4100

@charliermarsh I'd like to propose this be re-opened. Black does take the stance of W504 against line breaks after binary operators, which also aligns with the PEP-8 recommendation.
To keep my code in check with PEP-8, I have to use ruff with flake8 --select=W504, it would certainly be nice to have this in ruff.

FWIW, this would also bring Ruff autofixes closer to parity with autopep8, even if ignored/disabled by default https://github.com/astral-sh/ruff/discussions/9057#discussioncomment-7850584


Sometimes  not work

Randomly it save file of 0 kb, what can i check?

Hi @negrival thanks for the issue. We will need you to provide your code and steps taken to produce the error in order to help.

Closing for now, but feel free to re-open with more details, like Pi model, camera model, and steps taken.


Bug fix for #373

Description
Fixed bug where multiple new notes could be created. With this change if one "New note" exists, no new ones are created.
Added Cypress test specifically for this issue. Fixed two other failing e2e tests that were relying on the ability to create multiple new notes.
Fixes #373
Browser Checklist
This PR has been tested in the following browsers:

[x] Chrome
[ ] Firefox
[ ] Safari

Hi! This puts the application in a weird state where if you create a new note, then go to trash or favorites and try to create a new note, nothing will happen. This would be very confusing for a user. It would be better to delete the note when navigating to a new section, or something like that.

Hey @taniarascia I am curious of your thoughts on these changes:

New notes are removed upon switching to new folder or category
Context menu options removed for new notes until the note has actually been given some content by the user
Content option added for only new notes; instructs user to add content before having access to normal context options
New notes are no longer draggable until given content
Adjusted tests that were relying on being able to move new notes through dragging and content options
Changed beforeEach in note.test.ts and category.test.ts to use a unique note instead of a new note; majority are test case changes on the assertion of note list length

Looks great, thanks for all this! The changes are very good. My only comments are about some code style things:
For example, anything that looks like this:
      {clickedNote.text === '' ? (

          <AlertTriangle size="16" />
          {LabelText.ADD_CONTENT_NOTE}

      ) : null}

Can be written as:
     {clickedNote.text !== '' && (

          <AlertTriangle size="16" />
          {LabelText.ADD_CONTENT_NOTE}

      )}

No need for a ternary or null. You have  {clickedNote.text === '' ? null : then later clickedNote.text === '' again in the same file, it would be best to deal with them once.
My other comment is since note === '' is used a lot, making a helper function like:
function isDraftNote(note) {
   return note === ''
}

And using it throughout the code will make it more clear.

@taniarascia good evening, I have made the changes & thanks for the feedback!

Awesome, thank you!


UTF-8 byte reading error

A small bug in char_at and length_of_char_at found their way and up until now did not pose any problem, however on some borderline cases (such as the 0x10FFFF example below) the char was misread as 0xFFFD.
The standard specifies the first byte of a 4 byte sequence to start with a 0b1111_0xxx form, that the masks used in these methods did not check properly.

+1

:shipit:

+1


While the balance is confirming - I can't see the privacy-level

@Edicksonjga found this:
If the balance is confirming, if you try to send again, then the Privacy Level of the Confirmation screen is empty. I need to check this out.

The problem here is not the Privacy Level itself... which it is correctly calculated. The problem is: meanwhile the funds are confirming and you don't have any funds in orchard and/or sapling... You cannot send anything...


Wrong placement of plot in Jupyterlab

Currently (holoviews 1.11.3, jupyter 4.4.0) the Bokeh plots of Holoviews in Jupyterlab appear at incorrect positions. At the same time plain Bokeh plots work just fine (jupyterlab_bokeh extension installed but same effect without it).
If you plot with Holoviews in Jupyterlab the plots become just floating canvas above your notebook which never disappear. Not even when you close the notebook.
If you do a plain Bokeh plot before plotting with Holoviews, then Holoviews plots get appended to the Bokeh cell's output, even though it is a completely different cell.

I'm pretty sure this was reported before, but I can't seem to locate the issue now.  At that time I believe the issue was either not ever having run jupyter labextension install @pyviz/jupyterlab_pyviz or else not running hv.extension('bokeh') in your session. Both are needed in any case, so if you haven't done one of those, try it!

This is definitely down to old versions of HoloViews and the lack of the jupyterlab_pyviz extension being installed.


Review READMEs for all example projects

Some projects in the examples folder lack a README explaining what they do, while others may be a bit outdated.
Add a README for all the example projects that are missing it, and check the existing ones to ensure they are up-to-date.

I have recently analyzed the example of creating-instances-from-solidity so I decided to prepare a simple readme file for it. I hope it might be helpful for you.

Closing as implemented. Thanks @paulinablaszk for your work!


Server media pipeline capabilities cts

Summary: Rialto Server MediaPipelineCaps CTs
Type: Feature
Test Plan: Component Tests
Jira: RIALTO-464

https://jenkins.code.rdkcentral.com/job/github-triggered/48010/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13442/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/19824/ started.

Sanity tests for ['BCM Reference Refapp2'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/38477/

https://jenkins.code.rdkcentral.com/job/github-triggered/48101/ started

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/203/

https://jenkins.code.rdkcentral.com/job/github-triggered/48104/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13504/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/19901/ started.

https://jenkins.code.rdkcentral.com/job/github-triggered/48110/ started

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/674da3f2d29dffb4315b0c740e491167

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/github-triggered/13508/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/48111/ started

https://jenkinsrdkm.cmf.code.rdkcentral.com/job/build-component-platform/19906/ started.

build-brcm-refboard2 Console Log uploaded to Gist URL: https://gist.github.com/rdkcmf-jenkins/fbc590f0e94199dea0d5e015766e3cbb

Job for AI/job/AI_BUILDS/job/AI-Trigger-PullRequests started: https://pv-jen015.uk2.scp.bskyb.com/job/AI/job/AI_BUILDS/job/AI-Trigger-PullRequests/205/


Split RPCTest into two and speed up test cases

As previous PR https://github.com/grpc/grpc/pull/24119 indicates, the RPCTest might took too long to finish on slow machines. This PR splits the RPCTest into two halves (so they can run concurrently) and reduces the amount of timeout before expiration. Hopefully, this could further reduce the chance of timeout of RPCTest on macOS.
The original time to execute RPCTest on Python 2.7 on my laptop was 36 seconds, and this PR brings it down to 12 seconds.

Known failure: https://github.com/grpc/grpc/issues/24269


Add CSS styling for Osano dialog drawer

PR which contains CSS styles to resolve an accessibility issue, with the colour of text used in new our cookie consent tool Osano.

@TamimiGitHub - Can you please review this and ensure it's good to go? 🙏🏻


Move NetworkIdentity.UNetStaticUpdate to NetworkManager.Update. There is no reason why it should be in NetworkIdentity.

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Temperature Offset for hue motion sensor

Both of my hue motion sensor are reading around 2c lower than any other temp sensor I compare with is there a way you can add a temp offset and the I can run them throw this Homebridge plug in instead of native

I implemented an offset in deCONZ, which is exposed by Homebridge Hue.  I cannot do the same for the Hue bridge, as it cannot store the offset between Homebridge restarts, see #492.
I find the the temperature sensor in the Hue motion sensor is not very accurate, and adding an offset only helps a little.  Even after calibrating the sensor with an offset, so that it would correctly read 21°C, it would still be off at 15°C.
I think there’s a reason Signify don’t mention the temperature sensing feature in their marketing.  I was actually surprised when the device turned out to include this.  I think the device doesn’t actually contain a separate temperature sensor, but simply re-uses the infrared sensor for motion detection.

Ok thanks for getting back to me. so there no way for the plugin to read the temp that is send to it and then add a number to that temp from the plugins config file then re report it ? or how would I go about configuring the deCONZ offset ? cant see any pages in the wiki relating to thats

The offset in deCONZ is exposed as config.offset on the ZHATemperature /sensors resource.  Homebridge Hue exposes it through a custom Offset characteristic on the Temperature Sensor service.  Apple's Home app doesn't support custom characteristics, but you can set this from any decent HomeKit app.


how to apply my own wind data to inflow wind module?

Dear Developer,
I would like to ask the question about "how to apply my own wind data to inflow wind module?" For example, I have a series of wind speed and direction data over time, and I want to apply it to inflow wind module. I tried to set the wind type to 2, and defined a file ended with .dat, which follows the file "inflowwind_uniform_example.dat" that I downloaded from your website. Then I changed the parameters setting (Filename_Uni) to the file name I defined before in the section of inflow wind module "Parameters for Uniform wind file   [used only for WindType = 2]". However, it does NOT work, because in the output file, the wind speed is same as nothing to change.
Kind Regards

Dear @1Naruto1,
It sounds like you are following the correct process.  Did you save all of the files you changed before executing the OpenFAST simulation?  Have you enabled Echo in InflowWind to identify issues in the input file processing?
Best regards,

Dear @jjonkman,
Thanks for your reply! I do save all the files that I changed before running OpenFAST. Then I followed your suggestion to enable Echo.

I found the inflowwind input file is turbulent winds, although I set the wind type to 2. I am wondering that if I need set the inflow file to "inflowwind_uniform_example.dat" that I defined by my own data in the file that end with .fst directly?

Looking forward to your comments :)
Kind Regards,

Solved! Thanks!


Add test_modin_s3_read_parquet_many_files

Feature or Bugfix

Testing

Detail

Add test_modin_s3_read_parquet_many_files as a pure-Ray comparison baseline for test_s3_read_parquet_many_files

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 9db8f187520dd1e0742a3207c9cbd76fe7c9dc49
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
Commit ID: 9db8f187520dd1e0742a3207c9cbd76fe7c9dc49
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubLoadTests5656BB24-ATYtnXPE7MOa
Commit ID: 9db8f187520dd1e0742a3207c9cbd76fe7c9dc49
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubLoadTests5656BB24-ATYtnXPE7MOa
Commit ID: 9db8f187520dd1e0742a3207c9cbd76fe7c9dc49
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


5 digit years not covered in timout or tpictr

Not sure if this is a spice or a spiceypy issue, but years earlier than 9999 B.C and later than 9999A.D are not functional in functions timout or tpictr. SPICE de431 begin_date = 13201 B.C. 05-06 00:00' and ends at
'17191 A.D. 03-15 00:00' so I would tend to think that their functions would cover those dates....Looks like it is just an issue with the year format, as the month/day/time is correct as seen below.
Example:
input date: 12018 B.C. 07/11 12:19:27
et of input date = -4.42317281992e+11
output picture of date using tpictr:     'YYYY ERA MM/DD HR:MN:SC'
string from timout using date and picture:   **** B.C. 07/11 12:19:27

Hi Cliff,
it is an SPICE limitation. A workaround, depending on the time
system you want to use for the output string is the following:

UTC time system: use et2utc, with 'C' as format. With the input time
you have provided in your email, you should be getting the following
time string: 12018 B.C. JUL 11 12:19:26.815

TDB/ET time system: use etcal. With your input time, the output string
should be:   12018 B.C. JUL 11 12:20:08.000

Hope this helps.
Regards,
Jorge
Jorge Diaz del Rio
ODC Space
www.odcspace.com

On Jul 15, 2018, at 7:45 PM, Cliff<EMAIL_ADDRESS>wrote:
Not sure if this is a spice or a spiceypy issue, but years earlier than 9999 B.C and later than 9999A.D are not functional in functions timout or tpictr. SPICE de431 begin_date = 13201 B.C. 05-06 00:00' and ends at
'17191 A.D. 03-15 00:00' so I would tend to think that their functions would cover those dates....Looks like it is just an issue with the year format, as the month/day/time is correct as seen below.
Example:
input date: 12018 B.C. 07/11 12:19:27
et of input date = -4.42317281992e+11
output picture of date using tpictr: 'YYYY ERA MM/DD HR:MN:SC'
string from timout using date and picture: **** B.C. 07/11 12:19:27
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

I think this solves the issue, so I will close this in a few days if @CAReeser doesn't confirm.

I tested et2utc and it works perfectly with 5 digit years. Thanks for your help. Pls close this issue.
Cliff

On Jul 16, 2018, at 11:42 PM, Andrew Annex<EMAIL_ADDRESS>wrote:
I think this solves the issue, so I will close this in a few days if @CAReeser doesn't confirm.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


FLyway does not scan Java migrations if there are pending SQL migrations.

Which version and edition of Flyway are you using?
5.2.3
If this is not the latest version, can you reproduce the issue with the latest one as well?
Tried with 6.2.0, fails there too.
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Java API
Which database are you using (type & version)?
PostgreSQL(9.6.1) and Microsoft SQL Server(12.00.2000)
Which operating system are you using?
MacOS
What did you do?
There are 3 migrations (2 sql based and 1 java based) at their corresponding locations (locationForSql and locationForJava). Details are below:
Sql: V1.0.1.sql & V1.0.3.sql
Java: V1_0_2__Migration.java
Sharing the spring flyway configuration below:
    final String locationForSql = "classpath:db/updates";
    final String locationForJava = "classpath:com/myproject/db/updates";
    FluentConfiguration config = Flyway.configure().
                    .ignoreFutureMigrations(true).outOfOrder(true).validateOnMigrate(
                                    false).table("schema_version").locations(locationForJava, locationForSql);
    return config;

What did you expect to see?
The order of migration should be:

V1.0.1
V1.0.2
V1.0.3

What did you see instead?
On first application run, only Sql based migrations are scanned and run and Java based migration does not run at all.
On second application run, Java based migration ran.
I tried a few more scenarios and I observed that if there exists even a single sql based migration, java based pending migration wont run.

Upon further investigation, I found this piece in AbstractJavaMigrationResolver.class
@Override
public List resolveMigrations(Context context) {
List migrations = new ArrayList<>();
    for (Class<?> clazz : classProvider.getClasses(getImplementedInterface())) {
        M migration = ClassUtils.instantiate(clazz.getName(), configuration.getClassLoader());
        ConfigUtils.injectFlywayConfiguration(migration, configuration);

        ResolvedMigrationImpl migrationInfo = extractMigrationInfo(migration);
        migrationInfo.setPhysicalLocation(ClassUtils.getLocationOnDisk(clazz));
        migrationInfo.setExecutor(createExecutor(migration));

        migrations.add(migrationInfo);
    }

    Collections.sort(migrations, new ResolvedMigrationComparator());
    return migrations;
}

The classProvider instance, on being inspected, contains resources but not classes and hence Java based migrations are not getting resolved.

I think maybe the problem with my issue was classloader not being able to find the java based migrations as they are part of the spring boot application. Once I added an explicit scan for such classes before flyway begins migration, it starts picking those files up.
The issue can be closed if no concerns at your end.


Fixing [names-dataset made breaking chnages]

A breaking change happened in the 3.X version of names-dataset. So I'm forcing the version to 2.1, the latest one compatible.

Fixed the issue, please check and let me know if the issue persists. Thanks.


learn npm commands

commands to use in terminal from vs code:
npm install

(run this into local terminal first if you downloaded from github)
(good if you dont have all dependencies installed)

npm run start

(starts the developement server of the project into a local host)
(you can always shut down the server with ctr-C)

for a local json database server, use:
npx json-server --watch data/db.json --port 8000


Unexpected behaviour with clickhouse datasource  (v2.3.1) and single stat panel

Hello Guys. I'm trying to create a Grafana 7.5.5 Dashboard with single stat panel like in others dashboarsd we have already working fine, but with  unexpected behaviour  with clickhouse datasource.
Data visualization with flux/influxdb
With other datasources (flux/influxdb) we have created a singlestat that we can feed with a table like that  (from chronograf)
with 2 entries.

with this singlestat result

or this other with 1 entry

And this result.

Data visualization with clickhouse
when result for the query is that ( assuming that we should add a fake time column)
┌─t─┬─cat─┬─errors─┐
│ 1 │   3 │     24 │
│ 1 │   4 │     84 │
└───┴─────┴────────┘

visualization is ok

when result for the query is this other.
┌─t─┬─cat─┬─errors─┐
│ 1 │   4 │     84 │
└───┴─────┴────────┘

the category column information /(tag in influxdb) disappeared.
There is any way to fix this behaviour difference with other datasources?

Could you try a different approach?
┌─t─┬─cat─┬─errors─┐
│ 1 │   Category 4 │     84 │
└───┴─────┴────────┘

I mean select cat field as string which not contain only numbers

Hello @Slach  I've replaced my original .
SELECT
    1 AS t, /* fake timestamp value */
    cat,
    count(idx) as errors
FROM
(
....( another big subselect)
)
WHERE
GROUP BY t,cat

by
SELECT
    1 AS t, /* fake timestamp value */
    concat('Category ',toString(cat)) as cat,
    count(idx) as errors
FROM
(
....( another big subselect)
)
WHERE
GROUP BY t,cat

now Grafana is getting strings en cat column
┌─t─┬─cat────────┬─errors─┐
│ 1 │ Category 3 │     24 │
│ 1 │ Category 4 │     84 │
└───┴────────────┴────────┘

┌─t─┬─cat────────┬─errors─┐
│ 1 │ Category 3 │     24 │
└───┴────────────┴────────┘

And still not working when only one row.

Could you try to replace your clickhouse query format from time series to table? (look drop-down menu on bottom)
or try to replace your query and apply $columns macro
$columns(
    concat('Category ',toString(cat)) as cat,
    count(idx) as errors
) FROM
(
....( another big subselect)
)
GROUP BY t,cat

Hello again @Slach .
I've tested both solutions
1) With timeseries format
Option A
I've tested 2 options, and neither of them are valid because main information "Category" has disappeared
SELECT
    1 AS t, /* fake timestamp value */
    concat('Category ',toString(cat)) as cat,
    count(idx) as errors
FROM
(
    ....( another big subselect)
)
GROUP BY t,cat

this table
┌─t─┬─cat────────┬─errors─┐
│ 1 │ Category 3 │     24 │
│ 1 │ Category 4 │     84 │
└───┴────────────┴────────┘

will become  in

Option B ( without t)
SELECT
    concat('Category ',toString(cat)) as cat,
    count(idx) as errors
FROM
(
    ....( another big subselect)
)
GROUP BY cat

this table
┌─cat────────┬─errors─┐
│ Category 3 │     24 │
│ Category 4 │     84 │
└────────────┴────────┘

will become in

2.- with $columns macro
this query
$columns(
    concat('Category ',toString(cat)) as cat,
    count(idx) as errors
) FROM
(
....( another big subselect)
)
GROUP BY t,cat

will transform to this other.
SELECT t, groupArray((cat, errors)) AS groupArr FROM ( SELECT (intDiv(toUInt32(time), 2) * 2) * 1000 AS t, concat('Category ', toString(cat)) as cat, count(idx) as errors FROM
(
....( another big subselect)
)
GROUP BY t,cat GROUP BY t, cat ORDER BY t, cat) GROUP BY t ORDER BY t

I'm not sure what is supposed to do this macro but it is failing with this error
Code: 62. DB::Exception: Syntax error: failed at position 685 ('GROUP') (line 20, col 16): GROUP BY t, cat ORDER BY t, cat) GROUP BY t ORDER BY t FORMAT JSON . Expected one of: token, Comma, Arrow, Dot, UUID, DoubleColon, MOD, DIV, NOT, BETWEEN, LIKE, ILIKE, NOT LIKE, NOT ILIKE, IN, NOT IN, GLOBAL IN, GLOBAL NOT IN, IS, AND, OR, QuestionMark, alias, AS, WITH, HAVING, WINDOW, ORDER BY, LIMIT, OFFSET, SETTINGS, UNION, EXCEPT, INTERSECT. (SYNTAX_ERROR) (version <IP_ADDRESS> (official build))

any other suggestion ?

Let's try remove intDIv and double group by
something like that
SELECT t, groupArray((cat, errors)) AS groupArr FROM (

  SELECT
     1 AS t,
     concat('Category ', toString(cat)) as cat,
     count(idx) as errors
  FROM (

....( another big subselect)

  )
  GROUP BY t, cat ORDER BY t, cat
)
GROUP BY t

Did you try to replace your clickhouse query format from time series to table? (look drop-down menu on bottom)

Yes @Slach  while this  query.
 SELECT
     1 AS t,
     concat('Category ', toString(cat)) as cat,
     count(idx) as errors
  FROM (

....( another big subselect)

  )
  GROUP BY t, cat ORDER BY t, cat

I'm getting this table.
┌─t─┬─cat────────┬─error─┐
│ 1 │ Category 3 │    24 │
│ 1 │ Category 4 │    84 │
└───┴────────────┴───────┘

with this result ( Formatted as Table)

When adding the groupArray  extension
SELECT t, groupArray((cat, error)) AS groupArr FROM (

  SELECT
     1 AS t,
     concat('Category ', toString(cat)) as cat,
     count(idx) as error
FROM
(
....( another big subselect)

  )
  GROUP BY t, cat ORDER BY t, cat
)
GROUP BY t

I got this table
┌─t─┬─groupArr──────────────────────────────┐
│ 1 │ [('Category 3',24),('Category 4',84)] │
└───┴───────────────────────────────────────┘

And This as single stat.
Configuring Numeric Fields

Configuring All fields.

And configuring only GroupArr field

Expected

All previous queries and configurations never got expected result.
Maybe we won't be able to configure single stats as expected if no way to get data as dataframes , see related issue (https://github.com/Vertamedia/clickhouse-grafana/issues/404)

I ask third time!!! Did you try to replace your clickhouse query format from time series to table? (look drop-down menu on bottom)?

ok ;) clear, thanks a lot for reporting, i will try to figure wrong behavior ASAP

Thank you very much for your time @Slach .
As I said in my first entry in this issue, we have currently working with single stats panel, and I think all this behaviour could be fixed by only getting data in grafana dataframe format ( needed for Grafana 7.0+ ). Thank you very much again for your work.

@lunaticusgreen need to figure out how works result set with category with single stat visualization in Grafana 10

@toni-moreno sorry for late reply
is issue still relevant for you?

@lunaticusgreen let's add ./docker/grafana/dashboards/singlestat.json which will reproduce (or not) behavior in https://github.com/Altinity/clickhouse-grafana/issues/403#issuecomment-1008998631


fix Issue 16315 and optimise arithmetic operations for Slice

https://issues.dlang.org/show_bug.cgi?id=16315

LGTM

wow yet another sweet PR :+1:
I like it!

@9il could you rebase this as well please -maybe the increased coverage can help to convince other reviewers ;-)

Current coverage is 88.69% (diff: 96.36%)

Merging #4647 into master will increase coverage by <.01%

@@             master      #4647   diff @@
==========================================
  Files           121        121
  Lines         73855      73917    +62
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          65500      65558    +58
- Misses         8355       8359     +4
  Partials          0          0

Powered by Codecov. Last update 69c00bc...ffedcd7

@wilzbach does the 100 coverave is required ?if there is no public annonce please do not spam prs

@wilzbach does the 100 coverave is required ?if there is no public annonce please do not spam prs

No it's not a requirement yet, but the idea of introducing coverage to Phobos was (1) that new PRs shouldn't unnecessary introduce new misses (and we can slowly cover untested bits) and (2) reviewers can feel a bit safer when all new code is tested.
I just asked because I hoped it might help to speed up the review.

@wilzbach does the 100 coverave is required ?if there is no public annonce please do not spam prs
No it's not a requirement yet, but the idea of introducing coverage to Phobos was (1) that new PRs shouldn't unnecessary introduce new misses (and we can slowly cover untested bits) and (2) reviewers can feel a bit safer when all new code is tested.
I just asked because I hoped it might help to speed up the review.

Anyway, everyone can see what lines are not covered

Thanks!

Current coverage is 88.70% (diff: 100%)

Merging #4647 into master will increase coverage by 0.01%

@@             master      #4647   diff @@
==========================================
  Files           121        121
  Lines         73855      73916    +61
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          65500      65565    +65
+ Misses         8355       8351     -4
  Partials          0          0

Powered by Codecov. Last update 69c00bc...3e0a933


Add shortcut to session.js hook and ShortcutsComponent

Addresses #1277

Jupyter and Deepnote let us execute the current cell and advance to the next cell using Shift + Enter.
Could this also be supported in Livebook?
When reading through the documentation, sometimes you just want to run the current cell, see the result and move on to the next step.
Currently, you can hit Ctrl + Enter then k (a vim thing?) but I find the single button more comfortable given the convention in other notebooks.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Better error handling.

Closes #152,  #141
Readable panics, fixing connection issues with Twitch.

Able to reproduce the problem somewhat consistently by connecting to new channels.

Ditching this in favor of rewriting to websockets.


unable to iterate through MultipartForm multiple times

I'm building a simple web app that receives a form with an attached file. I'm also using a logger middleware to store a log of each request, thus I want to log the content of the file as well. However, it seems the MultipartForm object gets consumed on the on_post() method and when the logger middleware tries to access it, it breaks.
Things I've tried:

use copy.deepcopy() to clone the MultipartForm object so it gets not destroyed -> it breaks with TypeError: no default __reduce__ due to non-trivial __cinit__

The behavior can be easily reproduced iterating twice:
def on_post(self, req, resp):
        form = req.get_media()

        if type(form) == falcon.media.multipart.MultipartForm:
            for part in form:
                print(part, part.name)

            for part in form:
                print(part, part.name)

It only prints results for the first loop:
<falcon.media.multipart.BodyPart object at 0x7f43861b12d0> respuesta_ej1
<falcon.media.multipart.BodyPart object at 0x7f43861b1300> myfile

Thanks in advance for any help you can provide. I really like falcon :)

Hi @introprog-dc!
This is by design -- in the same way as you cannot read from a stream twice (unless it is seekable).
Iterating over a multipart form consumes the request stream, and no, you cannot iterate twice.
Maybe you could be redesign your application, and handle the form on-the-fly, or at least its file parts? Other small fields you can buffer in a dict.

Hi @vytas7! Thanks for your quick reply. I will try to implement a different approach then.


fix: Fixes to NvidiaRanker

Related Issues

fixes #issue-number

Proposed Changes:

Fixes the sede of the NvidiaRanker. Previously broken and not tested.
Adds license headers to files
Adds __init__.py files. I realize not strictly needed, but doesn't hurt.
Reenables some tests (forgotent test_ prefix) and adds some new ones

How did you test it?

added tests

Notes for the reviewer

Checklist

I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

@davidsbatista could you handle the release process for a new version of this after this is merged?

Yes, I can do it.


observe contacts

It would be nice to have the ability to be notified on contact change, or have a stream of contact instead of a future.

Would this be possible? AFAIK getting the contacts is a costly operation, and the systems don't provide any obervers.
You could create you own stream with a singleton that saves the state of the contacts, and periodically fetch and compare the new contacts and notifies the stream.


Hook up color picker and settings

Implement and hook up color picker for primary and secondary colors
Hook up settings to API
Make colors dynamic in CMS
Colors not yet dynamic on use welcome, survey pages

This change is

Meant to open this in the Throneless repo -- closing!


Fix blockImportCompleted

When we revisited the block publishing WRT BroadcastValidationLevel we started returning a Future<BlockImportAndBroadcastValidationResults> from blockImport, so we started logging blockImportCompleted at the wrong moment.
Documentation

[ ] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[ ] I thought about adding a changelog entry, and added one if I deemed necessary.

We need an entry in the changelog about this fix. I'll add one before merging this PR.


Refactor Milestone related

as title
moved from #10148 to have a smaler diff for it

Codecov Report

Merging #11225 into master will decrease coverage by 0.07%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##           master   #11225      +/-   ##
==========================================
- Coverage   43.25%   43.18%   -0.08%
==========================================
  Files         601      604       +3
  Lines       85544    86042     +498
==========================================
+ Hits        37004    37155     +151
- Misses      43966    44296     +330
- Partials     4574     4591      +17

Impacted Files
Coverage Δ

modules/indexer/code/indexer.go
38.02% <0.00%> (ø)

modules/indexer/issues/indexer.go
55.94% <0.00%> (-0.25%)
:arrow_down:

modules/markup/html.go
77.38% <0.00%> (-2.22%)
:arrow_down:

modules/markup/markdown/ast.go
0.00% <0.00%> (ø)

modules/markup/markdown/renderconfig.go
0.00% <0.00%> (ø)

modules/markup/markdown/toc.go
0.00% <0.00%> (ø)

modules/migrations/base/pullrequest.go
0.00% <ø> (ø)

modules/migrations/gitlab.go
1.67% <0.00%> (-0.09%)
:arrow_down:

modules/migrations/migrate.go
20.00% <0.00%> (-0.96%)
:arrow_down:

modules/queue/queue_wrapped.go
6.14% <0.00%> (-0.15%)
:arrow_down:

... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0849ab...612f180. Read the comment docs.

ping lgtm - it now need only 1 lgtm

make lg-tm work

@6543 please update to latest master, or check allow edits from maintainers.

Make lg-tm work


Adds law checks for some non-abstract typeclass methods

I am sure there are more. But these are all I could find with a quick look.

:+1: once Travis passes.

Thanks!


Remove .VolumeIcons.icns

A folder with something, top left corner

just a note for a possible fix, JetBrains/Gogland uses sneaky default window sizing (where the window is originally sized to be just as big as the background image)


Make tree node bold when hovering over

Hi,
I want to add the following functionality to my jstree:
When I hover over a node, the node text should be shown in bold.
I have searched a lot but couldn't find a proper solution for my case.
Any input will be appreciated, thanks in advance.

have you tried using simple CSS for this and was not working? e.g. something like:
li.jstree-node > a.jstree-anchor:hover {
  font-weight: bold;
}

http://jsfiddle.net/2kwkh2uL/4551/

No, I haven't. I just tried it and it worked. Thanks for your help. Sorry for asking such a simple question.


Optimize for parallel I/O

v3 spec non indexed FlatGeobuf aren't suitable for massively parallel I/O. I think what is needed to do this are one of:

Mandatory feature index (offsets, in spec v3 this is only available when FlatGeobuf is indexed)
Chunked data

I'm leaning on feature index. Possibly as post data section to allow streaming write.

To clarify, when you say "I/O" do you mean both reading and writing in parallel?
Or are you strictly talking about reading?

I did think mostly about reading. Writing in parallel would require chunks, I think? Seems to be that would require some radical different approach since features can vary alot in size.

I agree, just making sure I understood!

Thinking about this again the current format does support concurrency. Most efficiently when non indexed form where order does not matter but even when indexed assuming the order has been determined features could be written in buckets to be assembled in the right order in the end.
Reading non indexed form is still problematic to make concurrent but doesn't really need a full feature offset index, it really only needs a set of offsets (up to max concurrency) and that could be a new optional and backwards compatible array in the header. I'll think on it for a while and perhaps introduce that. 🙂


Migrate GoogleCloudPlatform/metacontroller to metacontroller/metacontroller

Pull request to apply a full dump of GoogleCloudPlatform/metacontroller to address the first part of issue #6.

I have strong objection against this method as we lost all information about commits and auhtors

it can be done like described in https://gist.github.com/niksumeiko/8972566 - I can test it. Especially I think that :

git history must be kept
all tags (releases) should also be moved
I can test the approach on my fork and let you know it it worked

I have tried this on https://github.com/grzesuav/metacontroller-moved , the number of commits, branches, releases and contributors are matching original one

Steps I did are : (as in https://gist.github.com/niksumeiko/8972566#gistcomment-1639106)

git clone --mirror git@github.com:GoogleCloudPlatform/metacontroller.git
cd metacontroller.git
git remote add new-origin git@github.com:grzesuav/metacontroller-moved.git
(change this to metacontroller/metacontroller)
git push new-origin --mirror

there were a banch of error related to pushing some hidden refs, related to closed PR or so, but except log messages there is no charm

Thanks @gresuav! I agree. I’ll run through your instructions and update the PR.

Thanks @grzesuav it's my fault. I was always under the impression that author of source repo need to grant a GitHub permission to let this migration happen.

@grzesuav thanks for pointing me in the right direction. This is now complete. The project has been mirrored and pushed to master with the full commit history. I merged a few pending dependabot PRs and opened a subsequent PR to update the README.md


Implement a find by criteria for OpenNebula resources

Author Name: OpenNebula Systems Support Team (OpenNebula Systems Support Team)
Original Redmine Issue: 5462, https://dev.opennebula.org/issues/5462
Original Date: 2017-10-17

For instance, find a VM with a particular tag, or a particular NIC.

What is the status of this issue?
I was writing a new issue and I found this.
FYI, I paste the content of the issue I was writing:
It may be useful to have an additional filter abilty when retrieving entity instance (VM, image ...)
Here is how we filter on instances for now:
We fetch all the instances (as VM), then we loop on list of instances with some tests to filter and keep what we needs.
To do this, we call the XML-RPC method "one.XXXpool.info", which retrieve a shortened versions of informations per instance.
But, it does not return our custom tags, so we have to iterate on all ID and call one.XXX.info methods to retrieve all informations and filter.
It seems a bit heavy and may be improved with little efforts ?
For instance it could be as simple as allowing a kind of instance tagging, in allowing to fetch instances based on a TEMPLATE defined key (just checking the key presence)
For the XML-RPC interface of this feature, it could be an additional "key string" parameter to "one.XXXpool.info" XML-RPC methods.
It should reduce the overall RPC traffic and simplify the user side code when filtering instances.
By the way, we see that the "document" entity has already a "type" field, which allow a more basic way to filter.
So an other idea could be to use the "Document" entity to have a kind of entities index, but it does not seen the proper way to do this.
To keep track of intances, it leads to store some comma separated values like VM_IDS = "1,15,..."

This filter is implemented for VMs (#2671). You can find more info here http://docs.opennebula.org/5.8/operation/vm_management/vm_instances.html?highlight=search#searching-vm-instances in the docs. It is not implemented for other pools because the size of them use to be smaller, but we can consider that.

Thank you, I didn't aware of this issue.
However, it does not seems documented in the XML-RPC API documentation of the vmpool.info method ?
Does it replace the "state" filtering parameters in a more global way ?
I'm looking at this commit

Using this feature give us the following error:

Full text search is not supported by the SQL backend

Looking in the code, regarding our DB, I found this function:
`bool MySqlDB::fts_available()
{
unsigned long version;
version = mysql_get_server_version(db_escape_connect);

if (version >= 50600)
{
    return true;
}
else
{
    return false;
}

}`
It's due to the database version but the documentation doesn't seems to recommend any database version.
It should be documented.

Ok, thank you, I was looking in the deployment section of the front servers to have more informations on databases versions. :)
Maybe a short warning to redirect the users could be useful ?

Sure, it makes sense.
I've open an issue in docs repo for adding this information (https://github.com/OpenNebula/docs/issues/594)

It is not implemented for other pools because the size of them use to be smaller, but we can consider that.

To me it's not only a performance problem, it's also for the convenience.
It may be interesting to add this feature at least for some resources commonly used with VMs like images, template, or even virtual network.
This filter feature could be used to regroup and then quickly filter some resources for a given "project" or user defined entity (like a catalog).
For instance, if we have some catalogs of images with various linux distros and versions, or a catalog of templates.
From the XML-RPC point of view, it require to make a request for each entity and then filter in a loop right ? (pool.info methods never returns user defined template tags ?)
With this feature, it's done in only one XML-RPC call, without a loop and a bunch of tests.
From the GOCA point of view, filter with key-value to filter the code is really easy to update and it simplify the user code.
It would be nice to have this feature on all pool info methods but I can understand that may represent a lot of works and may seems useless.

What is the exact requirements for the SQL backend for this to work with vmpool?
The Docs say this:
This feature is only available for MySQL backend with a version higher or equal than 5.6

I have used both MariaDB10 and now MYSQL-community Server 8 after hitting this problem on MariaDB 5.5 and both of them still produce the same error:
Currently on Mysql 8:
[root@u90c04p08-sunstone ~]# mysql -V
mysql  Ver 8.0.16 for Linux on x86_64 (MySQL Community Server - GPL)
And still seeing this:
[root@u90c04p08-sunstone ~]# onevm list --search NAME=1
[one.vmpool.info] Full text search is not supported by the SQL backend

As said in the documentation, the only requirement is MySQL backend with a version higher or equal than 5.6
Are you sure you have correctly configured OpenNebula for working with MySQL instead of SQLite? If you have a new installation the default value for DB backend is SQLite.

Yes is certainly helps to not have 2 DB statements in the oned.conf >.< doh.
After commenting out the first one which happened to be the one poitning to SQLite this works a expected on MariaDB 10.3
thanks Christian

you are welcome!


fluent/logger

Why is fluent/logger both a required and suggested dependency? It doesn't look like it should be required. It was added as a required dependency in the rollbar/rollbar 1.2 release.
The Packagist page for fluent/logger references a GitHub repository that appears to no longer exist. This is causing any new installations of rollbar/rollbar to fail.
- Installing fluent/logger (v1.0.1): Downloading    Failed to download fluent/logger from dist: The "https://api.github.com/repos/fluent/fluent-logger-php/zipball/c5a19ba8eb5e15f9ade72afeffba6b6e7eb51155" file could not be downloaded (HTTP/1.1 404 Not Found)
    Now trying to download from source
  - Installing fluent/logger (v1.0.1): Cloning c5a19ba8eb

  [RuntimeException]
  Failed to clone https://github.com/fluent/fluent-logger-php.git via https, ssh protocols, aborting.
  - https://github.com/fluent/fluent-logger-php.git
    Cloning into '/src/vendor/fluent/logger'...
    remote: Invalid username or password.
    fatal: Authentication failed for 'https://github.com/fluent/fluent-logger-php.git/'
  - git@github.com:fluent/fluent-logger-php.git
    Cloning into '/src/vendor/fluent/logger'...
    ERROR: Repository not found.
    fatal: Could not read from remote repository.

    Please make sure you have the correct access rights
    and the repository exists.

I am also having issues due to this problem :(

Aha yes it should not be required, it was moved to only suggested, but in a bad revert made it's way back in to required. I'll fix this.

@rokob Can we expect a 1.3.3 release shortly?

@rokob There it is. Thank you for the quick turn-around! ❤

👍

Is there any reason to leave it in the suggested list? The repo doesn't seem to exist anymore.

That is weird, I don't know what happened to it. Let us figure out if it is a thing anymore, and if not then we can remove all of the fluent code too.


no service numbers

reply from TNS

closes https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/8525
@SerdarSoysal

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@scanum can you help me merge this?

Closing as it was informed to me that there are numbers available now.


gate initialization with traits behind option

https://segment.atlassian.net/browse/INT-592
This puts the feature introduced in #20 behind an option. This means that people would need to opt in in order to initialize facebook pixel with existing traits that's been .identify()ed already.

[ ] docs
[ ] mongo script to set initWithExistingTraits to true for all existing user

@thehydroimpulse @wcjohnson11

lgtm


Add ViewPointController API for easy binding of viewpoints in XAML

Something along the lines of this to support MVVM and setting extents, while keeping your view model and view decoupled:
https://github.com/Esri/arcgis-runtime-demos-dotnet/blob/master/src/TurnByTurn/RoutingSample.Shared/CommandBinder.cs#L26

We also have something very similar here:
https://github.com/Esri/maps-app-dotnet/blob/b3470775c9bc14a96c3c254da750a9e6966da9de/src/MapsApp.Shared/Binding Support/ViewpointController.cs#L35
and:
https://github.com/Esri/maps-app-dotnet/blob/272cac8923d1f743ac0fbeb084f74c725fe9cb6a/src/MapsApp.Shared/Binding Support/GeoViewExtensions.cs#L39
Which together allow hooking into multiple view-models to update the viewpoint on a given GeoView:
<esri:MapView Map="{Binding Map, Source={StaticResource MapViewModel}}" >
  <utils:GeoViewExtensions.ViewpointControllers>
    <utils:ViewpointControllerCollection>
      <utils:ViewpointController Viewpoint="{Binding AreaOfInterest, Source={StaticResource MapViewModel}}"/>
      <utils:ViewpointController Viewpoint="{Binding AreaOfInterest, Source={StaticResource GeocodeViewModel}}"/>
      <utils:ViewpointController Viewpoint="{Binding AreaOfInterest, Source={StaticResource RouteViewModel}}"/>
    </utils:ViewpointControllerCollection>
  </utils:GeoViewExtensions.ViewpointControllers>
</esri:MapView>

The nice thing here is that it allows for the area of interest updates to come from multiple sources.
Not to get too off-topic, but there seem to be lots of other cases where these sort of binding helpers are desirable as well.  From the same app, here's a HoldingLocationController that allows listening to the GeoView's holding location from a view-model.  Or we recently had a user ask about handling identify operations on GeoNet (here), and I was able to adapt and share IdentifyController class from an Example App that's currently under development.  Seems like there's potential for a whole little area of Toolkit development here.


UI Cleanups Tracking Issue

[x] Time since pool action seems off https://mainnet.aux.exchange/pool?coinx=0xcc8a89c8dce9693d354449f1f73e60e14e347417854f029db5bc8e7454008abb%3A%3Acoin%3A%3AT&coiny=0x5e156f1207d0ebfa19a9eeff00d62a282278fb8719f4fab3a586a0a2c0fffbea%3A%3Acoin%3A%3AT
[ ] Pagination of TradingView
[ ] Swap should not be allowed if insufficient liquidity in pool
[x] Distinguish USDC-eth vs USDC-sol
[ ] Display swap events in pools
[x] Validator of decimals/lot/ticks in the price and amount fields of CLOB
[ ] More intuitive onboarding for AUX account creation and funding. Maybe prompt on loading the UI if no account exists for that user?
[x] Allow adding decimals in a new pool
[x] Account struct creation for first-time users
[ ] Detect whether wallet is installed and give hint if not
[ ] Grey out create AUX account when it's already created
[x] More responsive UI refresh after deposit or withdraw
[x] Scroll down order book asks side
[x] Swap fractional
[x] Swap should register coin if not registered
[ ] Add graphql endpoint for whether user has an AUX account, use to grey out create AUX account
[x] Script trading view configuration
[ ] Swap UI should display anticipated quantity with slippage

Nice to have:

[ ] Add tx hashes and times to swap events in pool view
[ ] Click the orderbook level to fill in the price in the order dialog
[x] Order type tool tips

[x] Fix Logo
[ ] Profile page workflow
[ ] time.time console error market trades
[ ] Orderbook data not updating when switching markets
[ ] TV Error on refresh from team chat (tvColorPallete localStorage variable)
[ ] Add search to pools page

For Mojito:

[ ] Highlight market (MOJO/APT in this case) in the pools list
[ ] Swap button when clicking into a pool in the pools view next to add/remove
[ ] Remove the "Earn AUX" part of the pools page description
[ ] change the green background? Either the background in the Figma or a even plain colour (similar to header colour)
[ ] Add text besides logo similar to their main website
[ ] Per-project customization of top navigation. For Mojito, disable or "Coming Soon" the Trade/Portfolio view

New pool page:

[ ] Back button from specific pool
[ ] Wording of pool bps on create


Update snippets.py

Make it clear that repeatable PipelineOptions like dataflow_service_options or experiments need to be specified as a list if set programmatically, so users do not inadvertently specify it as a string, to mirror the way they are set via the command line, e.g.
beam_options = PipelineOptions(
    ...
    dataflow_service_options='enable_prime')  # This will not work

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@aaltay

R: @aaltay

Thank you @dlu1000.
I am not sure if this is the best place to add this explanation. pipeline_options.py might be a better place, as part of the pydocs.

@aaltay I think the explanation belongs here because this section is used as the official example code for setting pipeline options programmatically. You are right that pipeline_options.py should probably have an explanation as well.
Since the underlying bug has been assigned to Andy Ye, I will go ahead and close this PR. Andy may choose to treat dataflow_service_options='option' as a single-element list and include a different explanation.


mission

This looks good to me, I vote :shipit: Others w/ comments?

Saying it should be compatible with all projects doesn't make sense imo. the projects that should be compatible with S4. reading this I'd expect S4 would work with Zewo without any modifications. I think would be better "... unbiased and easy to adopt".

Good point @paulofaria. I changed the wording.


Remove copy all .log files to /log

This was a terrible idea. Remove as soon as possible. Find a better way. Intermediate workaround is to just take in ffmpeg logs but even that is pretty bad.

resolved - still potentially annoying/destructive if ffmpeg logs are in there already :[ https://github.com/kieranjol/IFIscripts/commit/03cd2a2f7cf9d687471a751452983d7637290498


Problems with phantomjs 1.9.8 and reactjs

Hi,
The application I am trying to automate has reactjs. The test case work fine with phantomjs 2.0 but fail to find link or click link with v 1.9.8. Is phantomjs 1.9.8 not supported with reactjs?

I do not know for certain, but it is quite plausible that the version of Webkit bundled with 1.9.8 is too old for reactjs.  In particular I recall something about that version not supporting newer DOM Events APIs.
1.9.x is no longer being developed. We understand that there are several third-party tools and environments that don't work with 2.0 yet and that it is difficult to get a working binary on some platforms; we are actively working on those problems to the extent they are under our control.


filename for stlink source zip has changed, causing vagrant provisioning to fail

The filename for stlink source zip in texane github has changed, causing vagrant provisioning to fail.
Modifying 0_install-toolchain.sh and adding a "v" in front of the filename fixes it.
The two lines which need to be changed are in the #install stlink section
wget -nv https://github.com/texane/stlink/archive/v1.1.0.tar.gz
tar xfz v1.1.0.tar.gz
I have manually modified the file and reprovisioned and verified that the stlink source downloads and installs correctly.

Thanks, it's now fixed!


CI Setup

Continuous Integration
Setup travis-ci to check your code-style and eventually testing and other stuff.

travis-ci checkt code climate mit eslint


test: tabs.spec.ts

@devhus
Your tests are at a good start, but need some work. So I'm going to use this to clear some misconceptions I think you may have in your tests.

You are correct in that you are testing for the existence of a component. Your use of .exists() is correct. However, when you have already checked for the existence of a component, you should instead use .get() to get the component, rather than .find()..... .get() will throw an error when it does not exist, whereas a .find() will have a failing test. Basically, use .find() only when checking the existence, and .get() after you have tested the existence.
In your first test, you had started testing the inner workings of the BTableContainer.vue file. You were checking that it's tag is table by default, tag is div when prop responsive. This is not up to the BTable.spec.ts test, it is it's own component test. Instead of testing that it is the correct tag, in BTable.spec.ts, you only need to test that you are passing in the correct values to the component props, it should be on it's own test to handle how the props are used.
You have used expect($table.classes().includes('border-danger')).toBe(true). This works, but there's a simpler alternative to do. expect($table.classes()).toContain('border-danger'). They essentially do the same thing, but it's nicer to use the testing utilities.

Overall it's a good start. The basis of a component test is to test that things are being rendered correctly. That html elements and components are where they're supposed to be, that classes exist on those elements, that attributes exist. The internal implementations do not matter, if they did, they would be moved to a utility or a composable and would receive further testing. Also, events need to be tested, that they are being emitted when actions happen, etc. I can continue to try to write some tests for the table, but the biggest issue is ensuring that the asynchronous changes properly cause things to render correctly, that filter props render correctly, etc.

@VividLemon Thanks for all the tips, i am glad by your since these are my first test ive ever write.

@VividLemon Thanks for all the tips, i am glad by your review since these are my first test ive ever write.

It can be difficult to start writing tests, it can be confusing. But once you comprehend how they're  working, it's an immense help to all your applications. They are a huge help when making updates especially, cause then you'll in now if one of your small changes has broken everything

To clarify point number 2, the reason why this is an issue is that it causes brittle tests. If the nested component makes a change that's necessary, both the parent and child need to fix their tests. Ultimately, it's not the parents job to test a child's code, and when it breaks, it breaks both tests. It's only the parents job to give the child the correct tools


FALCON-1944 Ability to provide additional DistCP options for mirroring extensions and feed replication

+1.

+1 for the improvement. This was tested end2end as well.


yii\rest\Serializer serialize ArrayDataProvider error

What steps will reproduce the problem?
Creating a Controller
First, create a controller class app\controllers\UserController as follows,
namespace app\controllers;

use yii\data\ArrayDataProvider;
use yii\rest\Controller;

class UserController extends Controller
{
    public function actionIndex()
    {
        $users = [
            ['id' => 1, 'nickname' => 'Bob'],
            ['id' => 2, 'nickname' => 'Tom'],
        ];

        return new ArrayDataProvider([
            'allModels' => $users,
            'pagination' => [
                'pageSize' => 1,
            ]
        ]);
    }
}

Configuring URL Rules
'urlManager' => [
    'enablePrettyUrl' => true,
    'enableStrictParsing' => true,
    'showScriptName' => false,
    'rules' => [
        ['class' => 'yii\rest\UrlRule', 'controller' => 'user'],
    ],
]

Serve
$ php yii serve
in the other terminal:
$ curl http://localhost:8080/users?page=2
What is the expected result?
[{"id":2,"nickname":"Tom"}]

What do you get instead?
{"1":{"id":2,"nickname":"Tom"}}

Additional info

Q
A

Yii version
2.0.10

PHP version
5.5.34

Operating system
Mac OS X

This is expected behavior.

And what do you want to do with this?

Nothing: you are requesting the list of models via REST (second page to be precise):

$ curl http://localhost:8080/users?page=2

So you get the list of models in return (second page to be precise).
Everything is correct.

The question is why "1:" is inserted when the ?page=2 parameter is added.
And why does the response-format differ:
?page=1: [{"id":1,"nickname":"Bob"}]
?page=2: {"1":{"id":2,"nickname":"Tom"}}

I see now.
It is caused by ArrayDataProvider pagination mechanism, which splits original array preserving its keys.

➜  ~ cat a.php
<?php

	$arr = [ ['id' => 1, 'nickname' => 'Bob'] ];

	echo json_encode($arr), PHP_EOL;
	$arr = [ 1 => ['id' => 2, 'nickname' => 'Tom'] ];

	echo json_encode($arr), PHP_EOL;

➜  ~ php a.php
[{"id":1,"nickname":"Bob"}]
{"1":{"id":2,"nickname":"Tom"}}

interesting, maybe this is more of a fix for ther serializer?

Resolved by commit cd8c01f555e425d4654775002ae5f44152e0c4b1


Texture transparency (v. 1.5.0)

Hi,
I'm trying to apply a texture PNG-8 bit (or 16-bit), with transparency and alpha channel.
In SceneKit and other 3d env., when the texture has transparency, it's able to see through the model. Why I can't do this, even with the build-in Box geometry?
Sample code (kotlin).
        val box = Box(1f, 1f, 0.01f);

        val boxNode = Node();
        boxNode.setPosition(Vector(0.0f, 0.0f, 0.0f));
        boxNode.geometry = box;

        val boxMaterial = Material()
//        boxMaterial.diffuseColor = Color.BLUE // This works.
        boxMaterial.diffuseTexture = backgroundTexture; // see below code
        boxMaterial.transparencyMode = Material.TransparencyMode.A_ONE; // the RGB_ZERO doesn't works.
        boxMaterial.lightingModel = LightingModel.PHONG; // with this or default, the same happens

//        boxMaterial.diffuseColor = Color.TRANSPARENT; // made a test without texture, doesn't works

        box.setMaterials(Arrays.asList(boxMaterial));
        scene.rootNode.addChildNode(boxNode);

The code for reading the image
        val bitmap = bitmapFromAsset("textures/transparent.png");
        val backgroundTexture = Texture(bitmap, Texture.Format.RGBA8, false, false) // BitmapFactory.decodeStream

Any idea?
Thanks!

I could get sometimes the transparency/alpha woks, but not as should be.
There are some weird errors.
Probably is the fragment shader that is not ignoring the alpha values?
Look the screenshot in real Android device (Nougat 7.0.1)
This is how the app is currently is:

The red lines is the edge of the transparency.

You can see thart the cube (45 degree, Y rotation) is rendering very strange!
It's like there are no fragment shader and the geometry of cube is being rendered with a lot of problems.
The code for the inside cube is:
        val ib = Box(0.03f, 0.03f, 0.01f);
        val ibn = Node();
        ibn.geometry = ib;
        ibn.setRotation(Vector(0.0, Math.toRadians(45.0), 0.0));

This is how the scene should like.

Any idead?
Thanks!

Hi @rgipd, thanks for reaching out and your helpful screenshots. To better diagnose the issue, could you provide:

The full kotlin code where you construct the tree of scene objects demonstrated in the above screen shot (especially where the objects are placed, and the assets and materials they use).
The background textures/transparent.png asset.

Also, to clear up which parts of the screen shot represent what components (sorry it's not very clear), please confirm:

if the textures/transparent.png is represented by the greyish/black part of the image, where the yellow parts are effectively the transparent part of it?
And that beyond the textures/transparent.png, you have a yellow background and a cube with different colored sides (please provide that in the code above too if so)?

My initial guess is that this may be a depth ordering issue, but will need the requested items to further diagnose and confirm.

Hello @dthian . A little info about the textures/transparent.png. The transparent/alpha part is the one that appears yellow in the back.
I tried to make tests using culling back/front/nome. The yellow is the inside back face for the cube/box.
I have another small cube inside that make this error ( I tried with other vrx files too, same error ).
I think it's a fragment shader issue. If it is the depth problem, I think you should enable Alpha Masking in OpenGL (and some flag to turn it on) to avoid this problem. I can send a wiki information that I already saw in another githhub project about this issue. (Back in OpenGL ES 2.0 days, I had this issue as well).
The code:

// Texture loading
        val bitmap = bitmapFromAsset("textures/transparent.png");
        val backgroundTexture = Texture(bitmap, Texture.Format.RGBA8, true, false);

// Camera
        val cameraNode = Node();
        cameraNode.setPosition(Vector(0f, 0f, 20f));
        cameraNode.setRotation(Vector(0f, 0f, 0f));

        val camera = Camera();
        camera.fieldOfView = 0.5f;
        cameraNode.camera = camera;
        this.cameraNode = cameraNode;

        scene.rootNode.addChildNode(cameraNode);
        viroView.setPointOfView(cameraNode);

// The outside box
        val box = Box(1f, 1f, 0.01f);

        val boxNode = Node();
        boxNode.setPosition(Vector(0.0f, 0.0f, 0.0f));
        boxNode.geometry = box;

// Just to test.
        boxNode.setRotation(Vector(Math.toRadians(25.0), Math.toRadians(25.0), 0.0));

// Outside box main face texture (lot of comments for testing all alternatives)
        val boxMaterial = Material()
//        boxMaterial.diffuseColor = Color.BLUE
        boxMaterial.diffuseTexture = backgroundTexture;
        boxMaterial.transparencyMode = Material.TransparencyMode.A_ONE;
        boxMaterial.lightingModel = LightingModel.PHONG;
        boxMaterial.blendMode = Material.BlendMode.ALPHA;
        boxMaterial.cullMode = Material.CullMode.NONE;
//        boxMaterial.shadowMode = Material.ShadowMode.TRANSPARENT;

//        boxMaterial.diffuseColor = Color.TRANSPARENT;

//        boxMaterial.lightingModel = LightingModel.PHONG

// The materials for the outside box
        val mat1 = Material()
        mat1.diffuseColor = Color.BLUE;
        mat1.cullMode = Material.CullMode.NONE;

        val mat2 = Material()
        mat2.diffuseColor = Color.YELLOW;
        mat2.cullMode = Material.CullMode.NONE;

        val mat3 = Material()
        mat3.diffuseColor = Color.MAGENTA;
        mat3.cullMode = Material.CullMode.FRONT;

        val mat4 = Material()
        mat4.diffuseColor = Color.RED;
        mat4.cullMode = Material.CullMode.NONE;

        val mat5 = Material()
        mat5.diffuseColor = Color.GREEN;
        mat5.cullMode = Material.CullMode.NONE;

        box.setMaterials(Arrays.asList(boxMaterial, mat1, mat2, mat3, mat4, mat5));

        scene.rootNode.addChildNode(boxNode);

// The inside box (that render incorrect).
        val ib = Box(0.03f, 0.03f, 0.01f);
        val ibn = Node();
        ibn.geometry = ib;
        ibn.setRotation(Vector(0.0, Math.toRadians(45.0), 0.0));

        scene.rootNode.addChildNode(ibn);

        val mat0 = Material()
        mat0.diffuseColor = Color.CYAN;
        mat0.cullMode = Material.CullMode.NONE;

        val mat3a = Material()
        mat3a.diffuseColor = Color.MAGENTA;
        mat3a.cullMode = Material.CullMode.NONE;

        ib.setMaterials(Arrays.asList(mat0, mat1, mat2, mat3a, mat4, mat5));

// I think this below does not affect anything, but it's the light.
        // Lights.
        // Configure and add the direct lights to the scene
        val lightPositions = ArrayList<Vector>()
        lightPositions.add(Vector(-10f, 10f, 1f))
        lightPositions.add(Vector(10f, 10f, 1f))
        lightPositions.add(Vector(-10f, -10f, 1f))
        lightPositions.add(Vector(10f, -10f, 1f))

        val intensity = 300f
        val lightColors = ArrayList<Int>()
        lightColors.add(Color.WHITE)
        lightColors.add(Color.WHITE)
        lightColors.add(Color.WHITE)
        lightColors.add(Color.WHITE)

        for (i in 0..0) {
            val light = OmniLight()
            light.color = lightColors[i].toLong()
            light.position = lightPositions[i]
            light.attenuationStartDistance = 20f
            light.attenuationEndDistance = 30f
            light.intensity = intensity
            scene.rootNode.addLight(light)
        }

The image transparent.png is this one:

Thanks!

Thanks @rgipd. I've managed to somewhat reproduce the issue where our renderer isn't handling the transparency situation properly. I've tried shifting the internal box back and got a better result (i've made the internal box tall for debugging purposes):

However, depending on how your boxes are positioned or rotated, you may get different visual artifacts. I've filed an bug on our back log to work on resolving this issue.
As soon as the fix for this has been pushed to release, I'll update this issue. Are you currently working on a project that ship-blocked by this issue?

Yes, totally! (blocked by this issue)
I would love to have this fix if you can, send me the armv7 library just for working here and testing it?
I have lot of complexy geometry to test for you as well. :)
Thanks.

Hi @rgipd, this issue may have been fixed in the latest release (ViroCore 1.6) - could you try upgrading and re-verifying the bug? Thanks!

Hello, @dthian .
I could make a quick test right now, the same happens.
The photo (taken by another phone) to show in Device (not screenshot).

It's like the fragment shader. Don't know for sure.

@dthian. For now it seens the problem is fixed. :)


⚠ Bofrost.at has degraded performance

In f1c52bd, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1532 ms

Resolved: Bofrost.at performance has improved in 92bd794.


NodeCommandTest.ExecuteAndWaitFor returns same event

NodeCommandTest.ExecuteAndWaitFor returns same event from different commands, read test:
Given_aggregate_When_raising_several_future_events_with_bad_waiting
https://github.com/andreyleskov/GridDomain/blob/Future_events_refactoring/GridDomain.Domain.Tests/FutureEvents/Given_aggregate_When_raising_several_future_events_with_bad_waiting.cs

Issue is cased by missing specification for message wait. We use only type, without providing id. Method is intentionally designed for such behavior.


Boost lexing exception

The input:
///#include "test.txt"
//foo

causes a boost::wave::lexing_exception.

Adding a newline before or after the //foo fixes it.
Only happens with #include, not others like #define
Happens regardless of using <> or ""

Line continuation might also be broken

This looks like it happens even without the input adjustment

Fixed by recent commit. Will build after looking at #8


Will DataTables as a Service make it back to 7.0?

Summary of problem or feature request
I want to use DataTables as a Service with Laraval 5.4 and laravel-datatables 7.0, but the Service is not available anymore.
System details

Operating System: OSX
PHP Version: 7.0
Laravel Version: 5.4
Laravel-Datatables Version: 7.0

There was a breaking change on 7.0
See upgrade guide.

Thank you @alfa6661 for pointing me to the right direction.


Help with automatically giving rank

I need help on how to get it to automatically give someone a rank when they join so they will have simple commands such as set home. Can you help please? Thanks.
-Maggie

You can give those permissions to the one group on the server which has the options: setting of default: true.
To automatically promote users, you'll need to find a different, additional plugin to run alongside PermissionsEx (such as AutoRank) as PEX itself has no form of automation or chat management included.


Revamp 1_shard-data-chains.md

PR dependencies:

Flat containers https://github.com/ethereum/eth2.0-specs/pull/1392
int64 (signed 64-bit integers)
compute_proposer_index from https://github.com/ethereum/eth2.0-specs/pull/1371

Renamings:

persistent committee -> shard committee
phase 1 fork -> shard genesis
block data -> block body
attester bitfield -> aggregation bits
basefee -> block body price
total bytes -> block size sum
earlier committee -> older committee
later committee -> newer committee
most recent block core -> latest block header
target persistent committee size -> max period committee size

Substantive changes:

Use FlatContainer for shard blocks and state
Use Vectors instead of Lists in shard state to be friendly to flattening
Make shard attestations sign ShardCheckpoints (as opposed to parent_roots)
Make block bodies be multiples of SHARD_HEADER_SIZE (simpler and partially cachable Merkleisation)
Shuffle indices in get_shard_proposer_index (also make it consistent with phase 0—see #1371)
Remove receipt_root (instead use older_committee_rewards and compute indices on the beacon chain)
Reorder container fields into semantic groups
Make fee and rewards logic use Gwei everywhere (and reuse get_base_reward from phase 0)
Unify fees and rewards under _deltas
Make body of type List[byte, SHARD_BLOCK_SIZE_LIMIT - SHARD_HEADER_SIZE] (as opposed to Bytes[SHARD_BLOCK_SIZE_LIMIT - SHARD_HEADER_SIZE])
Added missing 2 * in range(len(persistent_committee), 2 * MAX_PERSISTENT_COMMITTEE_SIZE)
Do not needlessly deduplicate shard committees (by construction there are no duplicates) do not sort validator indices in get_shard_committee
Make MAX_BLOCK_SIZE_PRICE less conservative (32 ETH as opposed to 1 ETH)—fees are split across the shard committee anyway
Added shard check in process_shard_block_header
Added beacon_chain_root check in process_shard_block_header
Change len(data.body) to len(data.body) + SHARD_HEADER_SIZE in process_shard_block (as for block_size_sum)
Fix bug in process_shard_block_size_fee when computing MAX_BLOCK_SIZE_PRICE (should have been // SLOTS_PER_EPOCH as opposed to * SLOTS_PER_EPOCH)
Do not allow block.parent_root == Bytes32() to bypass parent root check
Possibly fixed a few bugs not listed above; most certainly added a few bugs of my own

Misc cosmetic changes:

Flesh out table of contents
Order containers topologically
Add various code comments
Remove "Beacon attestations" section and associated helpers (to go in 1_beacon-chain-misc.md—see #1323)
Add MIN_BLOCK_SIZE_PRICE parameter
Remove PHASE_1_FORK_SLOT, CROSSLINK_LOOKBACK, PLACEHOLDER parameters
Remove SHARD_SLOTS_PER_BEACON_SLOT in favour of SHARD_SLOTS_PER_EPOCH
Avoid raise Exception which is not used in phase 0
Split monolithic shard_block_transition into three functions (header, attestations, block size fee)
Make function signatures consistent (e.g. BeaconState parameter, then ShardState, then Shard)
Make function parameter names consistent (e.g. use state everywhere for BeaconState, and shard_state for ShardState)
Remove unused compute_slot_of_shard_slot

With a flat container, you no longer have this nice property that an object with an entire subtree substituted with its root necessarily has the same hash tree root as the original object, so you can't have shard blocks and shard block headers in the same way. Not sure how to get around this within the FlatContainer model.

Was just about to question if we indeed get this property anymore. The embedded looks like a reasonable approach


Settings and support for old API

Settings are not translated into English

On older androids, the application may not work correctly


Data attribute?

This is a really nice looking chart, great job. I just can't seem to figure out whether it's possible to feed it some data, or is it just cosmetic?
I understand it's possible to set the deg and startAngle which will draw a line from point A to point B, although I'm not sure what the point of that would be? Is it possible to assign a percentage based value?

Oh, thanks for that suggestion, I will add this feature later.
You can only give the value in degrees or radians, but you could convert the percentages until then for yourself as a hotfix. However when you set redraw to false, you can feed new data to an existing chart, if you didn't knew that.
function updateChart(percentages) {
    $(".circleChart").circleChart({
        deg: percentages*3.6, //percentages*360/100
        redraw: false
    });
}

Implemented in v1.0 with 5cf12cf433d6c64bc25cabf2beaa5516359bd5e8


Look into FPS stutter

From Reddit post:
https://www.reddit.com/r/wow/s/EQttjfqHlY

Yes, I also found that after enabling the addon will cause the game to jam, currently disabled

@byezero the game completely freezes? On version v1.7.6?

No, it will cause fps to decrease, especially when flying.

Thanks, I'll try to figure out what's going on

There were no problems before the update, and you can see if the latest update monitored too many events or something.

@byezero so v1.7.5 you had no issues, v1.7.6 you have this lag? I just want to make sure I'm comparing the correct versions. Thanks!

I'm not sure, but it basically updates every few days, and the date that it appears is 24/10/05

Ok, no worries. Many had issues between version v1.6.2 and v1.7.0 so I was just trying to figure out which two versions needed to be compared. I'll do some tests and see if I experience FPS drops on my own PC. I'll figure out the root cause, thank you!

emmm, I read the previous issues, I also used DialogueUI, and during the National Day holiday in China, I used a computer with poor hardware performance.

I'll be able to take more of a look at this the rest of this week. I've been a bit busy beginning a transition to my new job but I should have some free time the next few days.

Congratulations on getting a new offer. Work and life are the most important things. I have returned 1.6.0 and it works very well.

@byezero see if this build helps with the FPS stutter (https://github.com/Mctalian/RPGLootFeed/actions/runs/11335264324/artifacts/2055182826)
It's an alpha build, so you may see more chat messages than usual, but hopefully FPS stabilizes.

I think I solved this in v1.7.7 - let me know if you see improvements 🤞🏼


Supplementary docs on how to configure sysctl for containers and hosts

The Type of Document Issue
Wrong
What's wrong with this document?
Shouldn't be put here.
https://github.com/spidernet-io/spiderpool/blob/main/docs/reference/spiderpool-agent.md

fix https://github.com/spidernet-io/spiderpool/pull/3898


Number format exception for input string "Message"

Please search to check for an existing issue (including closed issues, for which the fix may not have yet been released) before opening a new issue: https://github.com/k9mail/k-9/issues?q=is%3Aissue
Expected behavior
Mail should get sent
Actual behavior
Error appears and mail goes back to drafts folder
Steps to reproduce

Send a mail with several jpg attachments

Environment
K-9 Mail version: Latest
Android version: 9
Account type (IMAP, POP3, WebDAV/Exchange): POP3
Please take some time to retrieve logs and attach them here:. No PC available to retrieve the logs.  I did create them, though.

Version 5.600
How can I get the log without a PC?

How can I get the log without a PC?

That's currently not supported. However, if you have root on your device you might be able to use one of the Android apps available. The search term to use for that is "logcat".

Guess I'll just figure out something else.