[ENH] Add a shortcut for pushing Lua Global Table to ILua interface

Description
Pushing Lua Global table to the stack requires a lot of boilerplate code like lua.PushSpecial(SPECIAL_TABLES.SPECIAL_GLOB). Since working with Global table is the most common operation in GmodDotNet modules, and use cases for other special Lua tables are rare, we should introduce a shortcut for pushing Global table for better developer experience and code readability.
Possible solution
Add ILua.PushGlobalTable() to GmodNET.API.

What if it will be GmodNET.API.Extras namespace ILua extension?
Just to keep ILua clean

I think it is not an extra, but rather a very important part of GmodDotNet experience.

Possible code implementation:
[MethodImpl(MethodImplOptions.AggressiveInlining)]
public void PushGlobalTable() => this.PushSpecial(SPECIAL_TABLES.SPECIAL_GLOB);

but i think about something like:
GlobalTable _G = new(lua);
Console.WriteLine(_G["SERVER"] as bool);
_G["print"]("message");
_G["PrintTable"](new []{1,2,3});

but i think about something like:
GlobalTable _G = new(lua);
Console.WriteLine(_G["SERVER"] as bool);
_G["print"]("message");
_G["PrintTable"](new []{1,2,3});

Using IDictionary to work with Lua tables is interesting, but naive implementation will only work for primitive types, like number and string.

but i think about something like:
GlobalTable _G = new(lua);
Console.WriteLine(_G["SERVER"] as bool);
_G["print"]("message");
_G["PrintTable"](new []{1,2,3});

Using IDictionary to work with Lua tables is interesting, but naive implementation will only work for primitive types, like number and string.

casting:
GlobalTable _G = new(lua);
GluaDelegates.print print = (GluaDelegates.print)_G["print"];
print("msg");

templates:
GlobalTable _G = new(lua);
GluaDelegates.print print = _G.Get<GluaDelegates.print>("print");
print("msg");

also templates:
GlobalTable _G = new(lua);
GluaDelegates.print print = _G.Get<GluaDelegates.print>(); // use Type.Name;
print("msg");

or make a class what binds whole lua api to use like:
GlobalTable _G = new(lua);
_G.print("msg");
string osname = _G.jit.os;
_G.print($"os is {osname}");

ILua class extension with ._G field:
// ILua lua
lua._G.print("message");
lua._G.MsgC(new Color(0, 255, 0, 255), "message");


Limit polymorphic intrinsic elements

Feature request
Overview
The idea behind this is to only be able to pass a limited number of elements as the as prop. For instance, a polymorphic input that can be either an input, a textarea, or another specific custom component (as opposed to anything that the user wants.)
Examples in other libraries
❌
Who does this impact? Who is this for?
Polymorphic components usually are not really meant to be used with every intrinsic element out there or any component in a given component library of a project, but the option to be explicit about what can be used and what can not offer better documentation and type safety.
Additional context
I would imagine the the union could be passed as a third argument for the ForwardRefComponent generic:
ForwardRefComponent<"input", {}, "input" | "textarea" | ThirdPartyInputComponent>

Closing this issue because polymorphism has been removed in favour of the asChild prop.


Dupe with GUI's not closing when player leaves area.

Issue description:
When players open a GUI for any Mekanism machine and then leave sthe area so that the chunk the machine unloads, they can remove the items and the machine will still have the item when reloaded.
Steps to reproduce:

Open any Mekanism machine GUI and put in any item.
Leave area either with Minecart or something else.
Remove item, and reload the machines.


Have a common minimum set of mauve tests for all plats and sdk versions

Have a single minimum set of mauve tests that works on all platforms and sdk versions
Resolves https://github.com/AdoptOpenJDK/openjdk-systemtest/issues/331
Signed-off-by<EMAIL_ADDRESS><EMAIL_ADDRESS>

Test mauve multithreaded load test special with osx openj9 jdk 8 : Test_grinder/job/Grinder/6318/console

Grinder running the mauve multithreaded load test on hotspot jdk8 : Test_grinder/job/Grinder/6343/console


FAISS.add_embeddings is typed to take iterables but does not.

System Info
MacOS
Langchain Version 0.0.181
Python Version 3.11.3
Who can help?
@eyurtsev I wasn't sure who to reach out to. The following is the signature for adding embeddings to FAISS:
FAISS.add_embeddings(
    self,
    text_embeddings: 'Iterable[Tuple[str, List[float]]]',
    metadatas: 'Optional[List[dict]]' = None,
    **kwargs: 'Any',
) -> 'List[str]'

Notice that text_embeddings takes an iterable. However, when I do this I get a failure with my iterable, but when wrapped in a list function then it is successful.
Information

[ ] The official example notebooks/scripts
[ ] My own modified scripts

Related Components

[ ] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[X] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
from langchain.vectorstores import FAISS
from langchain.embeddings import OpenAIEmbeddings

vs = FAISS.from_texts(['a'], embedding=OpenAIEmbeddings())
vector = OpenAIEmbeddings().embed_query('b')

# error happens with this next line, see "Expected behavior" below.
vs.add_embeddings(iter([('b', vector)]))

# no error happens when wrapped in a list
vs.add_embeddings(list(iter([('b', vector)])))

Expected behavior
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
...
File ~/.pyenv/versions/3.11.3/envs/myenv/lib/python3.11/site-packages/faiss/class_wrappers.py:227, in handle_Index.<locals>.replacement_add(self, x)
    214 def replacement_add(self, x):
    215     """Adds vectors to the index.
    216     The index must be trained before vectors can be added to it.
    217     The vectors are implicitly numbered in sequence. When `n` vectors are
   (...)
    224         `dtype` must be float32.
    225     """
--> 227     n, d = x.shape
    228     assert d == self.d
    229     x = np.ascontiguousarray(x, dtype='float32')

ValueError: not enough values to unpack (expected 2, got 1)

This is fixed in the linked PR (#5367)
thanks for the reproducing case! 🙇

Hello,  I have a question
I have created embedding for a csv file using open ai embeeding model
loader = CSVLoader('test1.csv', encoding="utf-8",csv_args={'delimiter': ','})
pages = loader.load_and_split()
len(pages)
embeddings = OpenAIEmbeddings(model=OPENAI_EMBEDDING_DEPLOYMENT_NAME,chunk_size=1)
db = FAISS.from_documents(documents=pages, embedding=embeddings)
db.save_local("./csvdata")
all good till here,
what i do not know is how can I embed another file say  test2.csv  and then  append the embedding to same vector store,
and save in same folder. any help will be greatly appreciated


I can not install application

Hi.
I've downloaded tha application "Customers", but when I try install using the file customers.zip, I see the following error:
Gateway Timeout
The proxy server did not receive a timely response from the upstream server.
Reference #1.872c0ec8.1620992195.1727880b
I am using the Oracle Apex free hosting at apex.oracle.com.
What's I doing wrong?
Regards,
Jairo

Hello. I'm also having the same exact issue. I feel like I've tried everything to resolve this with no success.

There are currently some issues around importing .zip exports on apex.oracle.com
Importing the standard .sql file is the workaround for now.


Unable to set passport user on Microsoft Edge

This code was tested on Firefox and was able to run as expected, although that was not the case with Microsoft Edge... Server Log shows the following error:
prisma:query SELECT `skedmill-db`.`Session`.`id`, `skedmill-db`.`Session`.`sid`, `skedmill-db`.`Session`.`data`, `skedmill-db`.`Session`.`expiresAt` FROM `skedmill-db`.`Session` WHERE `skedmill-db`.`Session`.`id` = ? LIMIT ? OFFSET ?
prisma:query COMMIT
{"level":30,"time":1667331147320,"pid":11324,"hostname":"GFBatista-PC","reqId":"req-7","res":{"statusCode":302},"responseTime":604.0961999893188,"msg":"request completed"}
prisma:query INSERT INTO `skedmill-db`.`Session` (`id`,`sid`,`data`,`expiresAt`) VALUES
(?,?,?,?)
prisma:query ROLLBACK
set(): Error:
Invalid `this.prisma[this.sessionModelName].create()` invocation in
C:\Users\gfbat\Projects\skedmill-project\node_modules\@quixo3\prisma-session-store\dist\lib\prisma-session-store.js:531:85

  528 case 4:
  529     _a.sent();
  530     return [3 /*break*/, 7];
→ 531 case 5: return [4 /*yield*/, this.prisma[this.sessionModelName].create(
Unique constraint failed on the constraint:
`Session_sid_key`
{"level":50,"time":1667331147854,"pid":11324,"hostname":"GFBatista-PC","reqId":"req-7","req":{"method":"GET","url":"/api/auth/callback/google?code=4%2F0ARtbsJpFn3xOPQjnClJXTmjasy3fQnnEgzgYpwlYPXWdUyflqoCCrMpKFcqq3Vhyiq2UIQ&scope=email+profile+openid+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.email+https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fuserinfo.profile&authuser=0&prompt=none","hostname":"localhost:4000","remoteAddress":"::1","remotePort":65378},"res":{"statusCode":500},"err":{"type":"PrismaClientKnownRequestError","message":"\nInvalid `this.prisma[this.sessionModelName].create()` invocation in\nC:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\@quixo3\\prisma-session-store\\dist\\lib\\prisma-session-store.js:531:85\n\n  528 case 4:\n  529     _a.sent();\n  530
    return [3 /*break*/, 7];\nÔåÆ 531 case 5: return [4 /*yield*/, this.prisma[this.sessionModelName].create(\nUnique constraint failed on the constraint: `Session_sid_key`","stack":"Error: \nInvalid `this.prisma[this.sessionModelName].create()` invocation in\nC:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\@quixo3\\prisma-session-store\\dist\\lib\\prisma-session-store.js:531:85\n\n  528 case 4:\n  529     _a.sent();\n  530
    return [3 /*break*/, 7];\nÔåÆ 531 case 5: return [4 /*yield*/, this.prisma[this.sessionModelName].create(\nUnique constraint failed on the constraint: `Session_sid_key`\n
  at RequestHandler.handleRequestError (C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\@prisma\\client\\runtime\\index.js:30873:13)\n    at RequestHandler.request
(C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\@prisma\\client\\runtime\\index.js:30856:12)\n    at PrismaClient._request (C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\@prisma\\client\\runtime\\index.js:31836:16)","code":"P2002","clientVersion":"4.5.0","meta":{"target":"Session_sid_key"}},"msg":"\nInvalid `this.prisma[this.sessionModelName].create()` invocation in\nC:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\@quixo3\\prisma-session-store\\dist\\lib\\prisma-session-store.js:531:85\n\n  528 case 4:\n  529     _a.sent();\n
530     return [3 /*break*/, 7];\nÔåÆ 531 case 5: return [4 /*yield*/, this.prisma[this.sessionModelName].create(\nUnique constraint failed on the constraint: `Session_sid_key`"}
{"level":40,"time":1667331147899,"pid":11324,"hostname":"GFBatista-PC","reqId":"req-7","err":{"type":"FastifyError","message":"Reply was already sent.","stack":"FastifyError: Reply was already sent.\n    at _Reply.Reply.send (C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\fastify\\lib\\reply.js:127:26)\n    at defaultErrorHandler (C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\fastify\\lib\\error-handler.js:91:9)\n    at handleError (C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\fastify\\lib\\error-handler.js:64:18)\n    at onErrorHook (C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\fastify\\lib\\reply.js:699:5)\n    at wrapOnSendEnd (C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\fastify\\lib\\reply.js:535:5)\n    at next (C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\fastify\\lib\\hooks.js:204:7)\n    at C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\@fastify\\session\\lib\\fastifySession.js:181:11\n
at C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\@fastify\\session\\lib\\session.js:171:9\n    at Immediate._onImmediate (C:\\Users\\gfbat\\Projects\\skedmill-project\\node_modules\\@quixo3\\prisma-session-store\\dist\\lib\\utils\\defer.js:16:18)\n
  at processImmediate (node:internal/timers:466:21)","name":"FastifyError","code":"FST_ERR_REP_ALREADY_SENT","statusCode":500},"msg":"Reply already sent"}
{"level":30,"time":1667331148320,"pid":11324,"hostname":"GFBatista-PC","reqId":"req-8","req":{"method":"OPTIONS","url":"/graphql","hostname":"localhost:4000","remoteAddress":"::1","remotePort":65395},"msg":"incoming request"}
check 2022-11-02T19:32:28.329Z
{"level":30,"time":1667331148325,"pid":11324,"hostname":"GFBatista-PC","reqId":"req-8","res":{"statusCode":204},"responseTime":4.168399810791016,"msg":"request completed"}
{"level":30,"time":1667331148328,"pid":11324,"hostname":"GFBatista-PC","reqId":"req-9","req":{"method":"POST","url":"/graphql","hostname":"localhost:4000","remoteAddress":"::1","remotePort":65378},"msg":"incoming request"}
{"level":30,"time":1667331148342,"pid":11324,"hostname":"GFBatista-PC","reqId":"req-9","res":{"statusCode":200},"responseTime":13.917999982833862,"msg":"request completed"}
{"level":30,"time":1667331148358,"pid":11324,"hostname":"GFBatista-PC","reqId":"req-a","req":{"method":"POST","url":"/graphql","hostname":"localhost:4000","remoteAddress":"::1","remotePort":65378},"msg":"incoming request"}
prisma:query SELECT `skedmill-db`.`Profile`.`id`, `skedmill-db`.`Profile`.`createdAt`, `skedmill-db`.`Profile`.`updatedAt`, `skedmill-db`.`Profile`.`biography`, `skedmill-db`.`Profile`.`pseudonym`, `skedmill-db`.`Profile`.`mood`, `skedmill-db`.`Profile`.`userId` FROM `skedmill-db`.`Profile` WHERE `skedmill-db`.`Profile`.`pseudonym` = ? LIMIT ? OFFSET ?
prisma:query SELECT `skedmill-db`.`User`.`id`, `skedmill-db`.`User`.`name`, `skedmill-db`.`User`.`email`, `skedmill-db`.`User`.`emailVerified`, `skedmill-db`.`User`.`image`, `skedmill-db`.`User`.`createdAt` FROM `skedmill-db`.`User` WHERE (`skedmill-db`.`User`.`id` = ? AND 1=1) LIMIT ? OFFSET ?
{ user: null, expires: 2022-11-02T19:32:28.359Z }
prisma:query SELECT `skedmill-db`.`User`.`id`, `skedmill-db`.`User`.`name`, `skedmill-db`.`User`.`email`, `skedmill-db`.`User`.`emailVerified`, `skedmill-db`.`User`.`image`, `skedmill-db`.`User`.`createdAt` FROM `skedmill-db`.`User` WHERE (`skedmill-db`.`User`.`id` = ? AND 1=1) LIMIT ? OFFSET ?
prisma:query SELECT `skedmill-db`.`Profile`.`id`, `skedmill-db`.`Profile`.`createdAt`, `skedmill-db`.`Profile`.`updatedAt`, `skedmill-db`.`Profile`.`biography`, `skedmill-db`.`Profile`.`pseudonym`, `skedmill-db`.`Profile`.`mood`, `skedmill-db`.`Profile`.`userId` FROM `skedmill-db`.`Profile` WHERE `skedmill-db`.`Profile`.`userId` IN (?)
{"level":30,"time":1667331148470,"pid":11324,"hostname":"GFBatista-PC","reqId":"req-a","res":{"statusCode":200},"responseTime":111.06369996070862,"msg":"request completed"}

Prisma schema:
model Session {
    id        String   @id @default(cuid())
    sid       String   @unique
    data      String   @db.Text
    //userId       String
    expiresAt DateTime
    //user         User     @relation(fields: [userId], references: [id], onDelete: Cascade)
}

For this project I've used fastify with @fastify/session plugin
app.register(fastifySession, {
            cookieName: 'user-session',
            secret: 'mysecretmysecretmysecretmysecret',//fs.readFileSync(path.join(__dirname, './../secret-key')),
            resave: false,
            saveUninitialized: false,
            cookie: {
                secure: false,
                //httpOnly: false,
                //path: '/',
                maxAge: 1000 * 60 * 60 * 24 * 1,
                sameSite: 'None'
            },
            store: new PrismaSessionStore(
                prisma,
                {
                    checkPeriod: 2 * 60 * 1000,
                    dbRecordIdIsSessionId: true,
                    //dispose: ,
                    dbRecordIdFunction: undefined
                }
            )
        })

I have checked db with prisma studio and session rows are being created on session table, although passport user is set to null on req.user.
Packages versions:
"prisma": "^4.5.0",
"@prisma/client": "^4.5.0",
"fastify": "^4.9.2",
"@fastify/session": "^10.0.2",
"@fastify/cookie": "^8.3.0",
"@fastify/passport": "^2.2.0",
"@quixo3/prisma-session-store": "^3.1.10"

@Elsoberanold - Thanks for reporting this. Haven't used Edge or Fastify, so not immediately sure what's going on here...
If the problem persists perhaps you could post a minimal reproduction?
I'm a bit short on time over the near term, but hopefully others can jump in, given an example to test from.

@Elsoberanold - Thanks for reporting this. Haven't used Edge or Fastify, so not immediately sure what's going on here...
If the problem persists perhaps you could post a minimal reproduction?
I'm a bit short on time over the near term, but hopefully others can jump in, given an example to test from.

This weekend I will try to post a small example to reproduce this error!

@kleydon
I have made an example app that reproduces this error.
https://github.com/Elsoberanold/fastify-passport-session-example

Thanks @Elsoberanold.
Any prisma-session-store users out there using fastify + passport session, who might have a quick insight on this?

mongodb + prisma + passport + nodejs + express
 '  540 case 4:\n' +
    '  541     _a.sent();\n' +
    '  542     return [3 /*break*/, 7];\n' +
    '→ 543 case 5: return [4 /*yield*/, this.prisma[this.sessionModelName].create(\n' +
    `Inconsistent column data: Malformed ObjectID: invalid character 'k' was found at index 0 in the provided hex string: "kUvJl1mpDqEYFkN9X67aCp5mwT-X3TSn" for the field 'id'.`,

I encountered the same error, but I managed to resolve it by modifying the session model.
model Session {
  id        String   @id @map("_id")
  sid       String   @unique
  data      String
  expiresAt DateTime
}

The issue was likely primarily caused by the definition of the id field. In my case, I used id String @id @default(auto()) @map("_id") @db.ObjectId, which resulted in the error. After changing it to the definition mentioned above, the error disappeared, and the session could be successfully stored in the database.

@Rabithua - Thanks for posting this fix.


Forward measurement type to c8y

When a measurement is received by the c8y mapper on a topic te/+/+/+/+/m/<measurement-type>, the suffix is to be used as the measurement type.

If the message provides a type, then this type is used instead of the type provided by the topic.
If the topic suffix is the empty string and the message doesn't provide a type, then "ThinEdgeMeasurement" is used as a default.

The setting of the measurement type should be set as per the following order of precedence (stopping at the first non-empty value).

From the .type property of the MQTT message payload
From the topic name
From the default value defined in the tedge.toml file (e.g. ThinEdgeMeasurement)

The reason behind supporting the value being set in the MQTT message body, as it allows users to provide a way to rename a type without breaking any devices which currently subscribe to that specific topic on the local MQTT bus. Typically this will only be done by advanced users, however it offers a powerful tool to potentially decouple the MQTT topic type to the topic type which is published to the cloud. Yes this could add a bit of "confusion", but it will only be for select use-cases.

@reubenmiller I have two questions:

What is the expected behaviour when user adds not nested type field (withiout dot) like {"type": "payload type"}? An error? Ignore it?
In entity store, the reserved keywords is marked with @. Do you want to use . for telemetry?

@reubenmiller I have two questions:

What is the expected behaviour when user adds not nested type field (withiout dot) like {"type": "payload type"}? An error? Ignore it?

No I meant that the property name is called type not (.type). Using .type is just common dot-notation nomenclature.

In entity store, the reserved keywords is marked with @. Do you want to use . for telemetry?
Not applicable, see first comment.

This has been implemented as described by https://github.com/thin-edge/thin-edge.io/pull/2219

QA has thoroughly checked the feature and here are the results:

[x] Test for ticket exists in the test suite.
tests/RobotFramework/tests/cumulocity/telemetry/child_device_telemetry.robot
tests/RobotFramework/tests/cumulocity/telemetry/thin-edge_device_telemetry.robot
[x] QA has tested the feature and it meets the required specifications.


ContentFilter for Operations

I have an application which relies heavily on JMX operations for ops reports and I'm needing the same kind of functionality that attributeFilter provides but for the operation return value.
For example I have several operations which queries with certain parameters and return a HTML string as a value, I would like to see this content served as HTML, not as plain text.

This is already available, at least on the master branch head.
Your MBean operation just has to return a HtmlContent object, as for attributes.
The next jminix release will surely include it.


Include a license & question about featuring your theme

Hi,
I am building a community-maintained theme gallery for Marp here on GitHub, and I'd like to feature your theme. Before that, however, I wanted to reach out to ask whether you could include a license in your repository. The original Rosé Pine repository contains an MIT License, for your information. Here's also a very good article from GitHub about licensing repositories.
To get a sense of how I would like to feature your theme, please, take a look at one of the currently hosted themes (e.g., border).
Many thanks.
Martin

Yes! yes and of course feel free to collect, use, and distribute! I just make mistake for a long time for forgot add a license!
Here the MIT ;)

Wonderful, thank you very much!
Closing the issue.


[Bugfix] fix star mgr get wrong db name

What type of PR is this：

[x] bugfix
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/journal/bdbje/BDBJEJournal.java
3
3
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test


make unique dask work

Fixes #170
Could use a test.
@mrocklin , thoughts no the conversation in the linked issue?

Ping this issue.

If I wanted to build unique I would probably use accumulate.  I don't have
a burning desire to do this though, so I suggest that we just leave it to
users for now.
On Wed, Aug 8, 2018 at 5:42 PM Christopher J. Wright <
<EMAIL_ADDRESS>wrote:

@CJ-Wright commented on this pull request.
In streamz/tests/test_dask.py
https://github.com/mrocklin/streamz/pull/170#discussion_r208745712:

@@ -178,3 +178,14 @@ def add(x, y, z=0):
yield source.emit((i, i))

 assert L == [10, 12, 14, 16, 18]

+@gen_cluster(client=True)
+def test_unique(c, s, a, b):

source = Stream(asynchronous=True)
L = source.scatter().unique(key=lambda x: x.key).gather().sink_to_list()

for i in range(5):

   yield source.emit(1)

assert L == [1]

Is that dependent on what the user wants? If they wanted to inspect the
actual value they could request it via the key syntax, right?
Is there a better way to run the inspection?
I guess unique is a special case of filter but then we are back at the
filter no-op problem again.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mrocklin/streamz/pull/170#discussion_r208745712, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszC8XBg93ETd-Lcuzx47fUTvBHyANks5uO1tSgaJpZM4TiHeV
.


How to cancel a request?

In Restangular 1.x, you can cancel a request by returning a rejected promise to the timeout of the httpConfig option in a FullRequestInterceptor. I would like to be able to do the same thing in ngx-restangular when I do not have an auth token, so I can send the user to the login screen. This doesn't seem to work, however. Do you have any ideas on how I might cancel a request in the FullRequestInterceptor? I don't have a subscription within the context of the interceptor, so I cannot dispose of the subscription at that point. I am looking for ideas.
Thanks and thanks for the great work on this project.

@stevebering, for now we don't have a solution for request cancellation. But errorInterceptor can help to solve this problem. Please follow this  link to find the description on how to update token after authorisation error, as well as how to make redirect to login page.
Thank you for your appreciation of our work.


vitepress dollar variables like $site not found

I get errors when using vitepress built in variables like $site, $themeConfig and others. Is there a way to tell volar that these variables are ok here?

Use ComponentCustomProperties, see https://github.com/vuejs/vue-next/blob/9ff70be2b357feff9b9b0157dd209a4730706eb6/packages/runtime-core/src/componentPublicInstance.ts#L53-L57.

@johnsoncodehk Thanks for the answer! I've found this declaration in the theme.d.ts in the default vitepress theme. So it's already there:
import * as vue from '@vue/runtime-core'

declare module '@vue/runtime-core' {
  export interface ComponentCustomProperties {
    $frontmatter: any
    $withBase: any
    $site: any
    $localePath: any
    $themeConfig: any
    $siteByRoute: any
  }
}

But I still get the variables red in the code...

@DeFUCC you may need add vitepress/theme to types option of tsconfig.json.

@johnsoncodehk Sorry for bothering you, but I still can't make it work...

You don't need types option, because theme.d.ts is under include option.
I tried your theme.d.ts and it's works, please provide a repro.


Remove migration console TG from cdk

Description
Remove migration console TG from cdk.

Category: Bug fix
Why these changes are required? Fixes error "Invalid request provided: CreateService error: The target group with targetGroupArn <> does not have an associated load balancer."
What is the old behavior before changes and new behavior after changes? Target group attempted to be deployed, now no target group

Issues Resolved
MIGRATIONS-1971
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Deployed on AWS account with No Migration Infrastructure in the region with MigrationConsoleAPI enabled.
Check List

[ ] ~New functionality includes testing~ Removing feature, no persisted testing

[x] All tests pass, including unit test, integration test and doctest

[x] New functionality has been documented
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Is there a kind of test that we could add that would have caught this error?

This was a deployment error instead of a synthesis one.
Aside from deploying to the cloud, I'm not aware of anything besides bespoke checks for this in unit tests. The closest thing to static correctness I've seen as CFN- Lint, which doesn't have a rule around this.
Once we have Jenkins in GitHub actions for PRs, this will be addressed


Question: tracing_subscriber::fmt() in examples

In One of the example files where the language server communicates with a client using stdin and stdout, the logging framework is initialised using tracing_subscriber::fmt().init(). Is this best practice? Doesn't this mean that the language server interferes with the logging framework?
One of my projects produces a warning since a client sends a message that is not implemented and consequently causing the server to malfunction. The following is an excerpt from the error log:
[coc.nvim] Connection to server dts is erroring, Header must provide a Content-Length property.
{"\u001b[2m2024-06-30t17":"26:58.978499Z\u001b[0m \u001b[33m WARN\u001b[0m \u001b[2mtower_lsp\u001b[0m\u001b[2m:\u001b[0m Got a workspace/didChangeConfiguration notification, but it is not implemented\nContent-Leng
[coc.nvim] Connection to server dts is erroring, Header must provide a Content-Length property.
{"{\"jsonrpc\"":"\"2.0\",\"method\":\"textDocument/publishDiagnostics\",\"params\":{\"diagnostics\":[{\"code\":\"expected\",\"message\":\"Expected one of /dts-v1/, /memreserve/, /include/, /delete-node/, /omit-if-n
o-ref/, '/', reference\",\"range\":{\"end\":{\"character\":1,\"line\":0},\"start\":{\"character\":0,\"line\":0}},\"severity\":1,\"source\":\"ginko_ls\"}],\"uri\":\"file:///Users/lukasscheller/.local/share/nvim/site
/pack/x.dts\"}}\u001b[2m2024-06-30T17:26:58.984067Z\u001b[0m \u001b[32m INFO\u001b[0m \u001b[2mtower_lsp::service::layers\u001b[0m\u001b[2m:\u001b[0m shutdown request received, shutting down\nContent-Length: 38"}.
Shutting down server.

Is there a reason why the tracing_subscriber::fmt().init() method is used (since it can interfere with the actual messages)? Is there a better methods?
Thanks for all replies!

@Schottkyc137
Yes, you should be using stderr for logging.
tracing_subscriber::fmt().with_writer(std::io::stderr).init();

If you want to get rid of the ANSI escape codes, which most editors don't handle in there log capture, you should disable them, too.
tracing_subscriber::fmt().with_writer(std::io::stderr).with_ansi(false).init();


[columns] saving col state has old 'agg' value in it for non value columns

http://www.ag-grid.com/forum/showthread.php?tid=3062

tracked by https://ag-grid.atlassian.net/browse/AG-84


feat: add zsh image for ncs-zephyr

Description

Closes #
Related #
Areas of interest for the reviewer

Checklist

[ ] My code follows the style guidelines as defined by IRNAS.
[ ] I have performed a self-review of my code.
[ ] My changes generate no new warnings.
[ ] I added/updated source code documentation for all newly added or changed functions.
[ ] I updated all customer-facing technical documentation.

Example strikeout: - [x] I updated all customer-facing technical documentation. - This PR
introduced only internal facing changes.
After-review steps

Reviewer can merge and delete the branch.
I will merge PR by myself.

#7  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MarkoSagadin and the rest of your teammates on  Graphite


Unable to sign in with code-insiders

Issue Type: Bug
When entering the code in aka.ms/devicelogin, I get authenticated on the browser and the "Waiting for Azure sign-in..." dissapears as expected, but instead of getting the list of storage accounts I have access to, I get back the "Sign in to Azure..." and "Create a Free Azure Account..." options.
Extension version: 0.4.1
VS Code version: Code - Insiders 1.27.0-insider (8727085fff33bf7d8f5e27483b10f72508d4167a, 2018-08-14T07:42:59.172Z)
OS version: Linux x64 4.4.0-17134-Microsoft

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)

GPU Status
2d_canvas: unavailable_softwarechecker_imaging: disabled_offflash_3d: unavailable_softwareflash_stage3d: unavailable_softwareflash_stage3d_baseline: unavailable_softwaregpu_compositing: unavailable_softwaremultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarewebgl: enabled_readbackwebgl2: unavailable_off

Load (avg)
1, 1, 1

Memory (System)
15.93GB (2.56GB free)

Process Argv
/usr/share/code-insiders/code-insiders

Screen Reader
no

VM
0%

@omartin2010 Is this consistent?  If you try again, or exit and restart vscode, do you see the subscriptions?  Thx.

I can repro from my end. Happy to share screen if you want to see (I`m internal MSFT).

Weird, haven't been able to repro.  I assume that it works if you restart vscode?

It doesn't work. I can't get it to work in this configuration, but that is on WSL. Not sure if that makes a difference or not but that's what I've been trying to get to run properly. Most other things work ok but not that one.

If I do that, I get “Not signed in, sign in first”…
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Stephen Weatherford (MSFT<EMAIL_ADDRESS>Sent: Friday, August 17, 2018 2:24:39 PM
To: Microsoft/vscode-azurestorage
Cc: Olivier Martin; Mention
Subject: Re: [Microsoft/vscode-azurestorage] Unable to sign in with code-insiders (#218)
I'm trying to figure out if this is a storage extension or an issue with the Azure Account extension. Can you do:

Command palette -> Azure: Sign In
Command palette -> Azure: Select Subscriptions

Do you see your subscriptions show up in the command palette? (I.e. is sign-in succeeding?)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvscode-azurestorage%2Fissues%2F218%23issuecomment-413950421&data=02|01||436a2f78a36a4951f8c208d6046eb22f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636701270806454653&sdata=5wF8odE1kv2sC%2FT5jrqUziU1TgNbOxkLmm512X1wkx8%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAK2FXlQURg2vZpBtMCCf8YPLrhwr3gwFks5uRwpngaJpZM4V9G5s&data=02|01||436a2f78a36a4951f8c208d6046eb22f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|636701270806454653&sdata=jheCdNkB%2FGGCLL6Zfk7UM8YqjR1ua8%2BRPfLIDpALX%2Bg%3D&reserved=0.

That makes it an Azure Account Extension issue.  Can you enter an issue there, hopefully they can help you.  Thanks.


'clear' should leverage tput reset on *nix

Summary of the new feature/enhancement
As as user, I want the same 'clear' experience in PowerShell on *nix, as I have in Windows. Currently, if I use 'clear' in Windows, this clears the buffer. Currently, in *nix, it appears to create a gap of blank lines and leaves the buffer mostly intact; so, I can scroll up to see the history.
I believe that this is because pwsh is leveraging terminal and when clear is input by the user, it is passed to the terminal. However, the behaviour one would expect should be the equivalent of 'tput reset' in the terminal window - as this would be the same experience seen in PowerShell in Windows.
Proposed technical implementation details (optional)
Instead of allowing 'clear' to pass to the terminal, translate the command to 'tput reset' and pass that to the terminal.

Interestingly, on macOS, tput reset doesn't clear the scrollback buffer.  However, if I follow it with "`e[3J" to explicitly clear the scrollback buffer, I believe the result is the desired behavior.  cc @mklement0 who is more of an expert on this

I wonder if the session manager for OSX is different. If so, you could use something like:
if($Env:SESSION_MANAGER.Contains("unix")){ tput reset}
And then case another if statement for OSX.
I haven't an OSX device, so I can't test what the environment variables would be, to help any further.

To get a consistent clear-screen-and-scrollback-buffer experience, I suggest using tput clear; $host.ui.Write("e[3J")`, as suggested in my review comments - this works with both iTerm2.app and Terminal.app on macOS and the standard terminal app on Ubuntu.
That said: While consistency across platform is nice, do note that macOS / Linux users may expect the scrollback buffer NOT to be cleared with clear, given that's what the native /usr/bin/clear utility does.
So I wonder whether we should simply defer to the native utility on Unix-like platforms (i.e., remove the alias on Unix-like platforms).
If we do that, users who want the Windows clear-screen-and-scrollback-buffer behavior on Unix must - as they currently do:

use tput reset on Ubuntu
use keyboard shortcut Command-K on macOS (both iTerm2.app and Terminal.app), because on macOS tput reset only clears the screen, without clearing the scrollback buffer.

Assuming that cls is also an alias for Clear-Host currently, we could use that selectively to implement the clear-screen-and-buffer logic on Unix, while making clear defer to the native utility

@mklement0 you make a good point that Unix users may expect the scroll back buffer not to be cleared since that is the default behavior of clear.  Removing the clear alias might be the right thing to do while having cls aliased to clear-host which clears the scrollback buffer to have consistency with Windows.


chore(main): release 0.3.4

:robot: I have created a release beep boop
0.3.4 (2024-04-07)
Reverts

don't depend on luarocks-build-rust-mlua (b8a29c5)
luarocks: add rockspec template (1641c33)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/vhyrro/toml-edit.lua/releases/tag/v0.3.4 :sunflower:


Use this but with a modular scale

Hi,
What would be the best way of using this to generate a set of font-sizes for H1 => H6 but using one type scale such as 1.125 for the minimum value and 1.250 for the maximum value.
I've had a go using Sass but the output doesn't appear to be correct.
Any suggestions?

@rctneil You should take a look at this  generator.
It will generate different sizes with a scale value. However, would be cool to have this feature in the project.


Move react dependencies to devDependencies (fixes #1830)

The previous PR trying to fix this issue failed tests, so I'm uploading my own.

Should be fixed now, thanks


Forward zone query distribution

I've got a question how queries are distributed to forward
resolvers.
In this example, I've defined that all queries, which can't be
answered from the cache, are forwarded to cloudflare and openDNS:
forward-zone:
name: "."
forward-tls-upstream: yes
Cloudflare DNS
forward-addr<EMAIL_ADDRESS>forward-addr<EMAIL_ADDRESS>OpenDNS Server
forward-addr<EMAIL_ADDRESS>forward-addr<EMAIL_ADDRESS>Looks like all my queries is going to cloudflare,  because it's the first one.
how can we achieve some sort of distribution (random /  roundrobin, etc ...)
thanks,
Nikesh

Unbound selects the upstream server at random.  If one of them if very slow, or unreachable, it is exempted from the random selection.
If you want to modify the selection, instead of random you can have the fastest with the options fast-server-permil and fast-server-num.  The option unknown-server-time-limit can be useful if you want to modify unknown server selection versus known server selection.


Major refactoring to support Puppeteer package

Replacing chromy with puppeteer as backend
Add functionality to chain differencify methods
Add resize functionality
Removed dependency to config files
Better logging
Bug fixes

@danrr : All resolved


global pose integration

Hi, you have get the camera orientation and location in world coordinate. Which are actrually relative orientation and location between frame t and frame t-1  .
So you have used
pos = pos + Rpos*tr';
Rpos = R * Rpos;
to get orientation and location in global relative to the original pos. But it dosn't show me a correct trajectory.
Can I use the R and tr as relative pos, which can be added to posegraph3D ?
Like hier
relativePose = [tr,rotm2quat(R)];
addRelativePose(posegraph3D ,relativePos, informationmatrix);
And then do some further loopclosure.
Are you familiar with the posegraph3D? Can i directly use the R and t to construct relative camera pose?
I also need to get poses in form of [x y z qw qx qy qz] to build an occupancy map. What should I do to the R and tr. I really get confused for a long time.
Could you please explain it to me? Thank you very much.

You have a few problems with this code:

one your code makes it seem that the location of a feature point is the same in each stereo pair this leads to Matlab thinking that no translation exists and so print an error message to the console reading that the "." operation is not valid for an empty object.

Three there's no tracking of results.

four there's no way to turn bucketing on and off easily


Fix misleading in the Main doc about async/Task

Summary

Modify the overview list to be more explicit
Replace "signature" by "declaration"
Replace "valid Main:" by "the most common Main", because the list isn't exhaustive
Replace "public accessor modifier. That's typical, but not required." by default accessor, because it sound most common
Rework the async/task part

Fixes #40972

Internal previews

📄 File
🔗 Preview link

docs/csharp/fundamentals/program-structure/main-command-line.md
Main() and command-line arguments

@stephentoub

This PR was more tricky that anticipated. I prefer to split it and do the asked modification about boilerplate code in another PR.
So I created the issue #41457 to follow up.


Add grouping to cloned query and use a sane rank profile when related…

…_to is the only query term
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

💯


lang_d: Fix symbols with underscore being treated as number

FontAtlas ui_font;
The _f was being colored as being a number
I copy pasted the number code from rust, both have similar rules

What do you think about
--- a/plugins/language_d.lua
+++ b/plugins/language_d.lua
@@ -12,14 +12,16 @@ syntax.add {
     { pattern = { '`', '`', '\\' },     type = "string"   },
     { pattern = { '"', '"', '\\' },     type = "string"   },
     { pattern = { "'", "'", '\\' },     type = "string"   },
+    { pattern = "0[oO_][0-7]+",         type = "number"   },
     { pattern = "-?0x[%x_]+",           type = "number"   },
-    { pattern = "-?[%d_]+[%d%.eE]*f?",  type = "number"   },
+    { pattern = "-?[%d]+[%d_%.eE]*f?",  type = "number"   },
     { pattern = "-?%.?%d+f?",           type = "number"   },
-    { pattern = "[%+%-=/%*%^%%<>!~|&%$]+", type = "operator" },
+    { pattern = "[%+%-=/%*%^%%<>!~|&%$]+",     type = "operator" },
     { pattern = "[%a_][%w_]*!?()[%(.]",        type = {"function", "normal"} }, -- highlight templates
     { pattern = "@safe",               type = "keyword"   },
     { pattern = "@trusted",            type = "keyword"   },
     { pattern = "@nogc",               type = "keyword"   },
+    { pattern = "[%a_][%w_]*",         type = "symbol"    },
   },
   symbols = {
     ["abstract"] = "keyword",

This basically makes it so numbers can't start with an underscore (would that be valid in D?) and "words" with underscores are marked as symbols (as they should have from the start; this pattern is in most languages).

I was testing more in project and it breaks here:

I'm too bad with regex unfortunately, so i can't do much

Did you try my proposal? It seems to work fine in that case:

That's probably "caused" by:
{ pattern = "[%a_][%w_]*!?()[%(.]",        type = {"function", "normal"} }, -- highlight templates

How do templates look like?

you can call functions without parenthesis if function has no arguments, so that complicates parsing

I think... I'll leave this to someone else :sweat_smile:.

What do you use to quickly test the regex used in lua?

In general I keep two instances of Lite XL open, one to write the language file and another to test it (restarting it with ctrl+alt+r).
Keep in mind that Lua patterns and regexes are different.
Luckily you can use both in language syntaxes; you use pattern = ... for Lua patterns and regex = ... for regexes (pcre2).
So if you're more familiar with regex you can use that, and live-test with websites like https://regex101.com/.


OPENTOK-28299. Update Android Sample Applications to support new Android Permission System, r=rpc

title says all

LGTM


Update rotate branch + Add improvements

Fixes #Hi,
In The last year, I have worked with that repository, with rotate branch. In the last week I decided to update my local version (based 1.3.2) to the latest leaflet release #268. In the last time, I didn't know how to work with pull requests concept, but now, I will be more than happy to contribute some improvements that I did.
Summary of the changes:

Rebase rotate onto master (fix small problems)
Fix Draggble and Marker.Drag
Fix Popup

The pull request is from my local branch to master, because I made a rebase

Hi @Keats,
I have seen that you tried to update rotate branch too. Do you have any suggestion to improve rotate-leaflet?

I ran into some weird edge cases when rotating that were not obvious to debug so I haven't really used my branch.

Hi @johnd0e,
What do you think about my pull request?

Those are just preliminary comments, as I haven't checked your PR main functionality.

fixes #268

Just to be clear, my goal is to update rotate branch , not master

Good to see that some people are still working on this branch. Thanks!

Hi, is it possible to also consider tilt change? vector tiles can be 3d. Take a look at https://www.google.com/search?q=leaflet+bearing+and+tilt&oq=leaflet+bearing+and+tilt&aqs=chrome..69i57.2970j0j7&sourceid=chrome&ie=UTF-8 also

@Azbesciak, I don't know how to consider tilt change because Leaflet map is a 2D map by definition.

I created leaflet-rotate-map package for those who want to use the latest leaflet version with rotation :)

@ronikar maybe this post at stackexchange can help, also world3d is based on leaflet. Sorry - I though I posted a direct link before

closed? so..its merged?. Thanks!

so..its merged?

No.

closed? so..its merged?. Thanks!
Unfortunately, no :(


Remove Unnecessary Description Popup

Issue
Closes #1945
Changes proposed

Mainly, I've removed the description popup. Just used the tooltip instead. Additionally, I've added a few missing descriptions and refactored the code.
Screenshots

The opacity is not appropriate:

We should make it 100% because background text would just be a distraction on this.
Indeed, you're correct, @Anmol-Baranwal. I would have made style updates if that was the focus of this pull request. These styles are from an older version, and I'm not particularly fond of the current tooltip styles. For the time being, I'll eliminate the opacity and introduce a shadow instead. We can consider further enhancements in the future.

Why bother changing the logic.

Previously, the code contained redundancies with unnecessary props ('results') being passed and half of it was repeated ('TopBar.tsx'). I've since streamlined the logic to simplify it.
cc @rupali-codes

Please make ONLY changes related to the issue, don't over-do it.

Sure thing @rupali-codes.

Why have you removed this file?

In fact, the title was "Tutorials," but the URL was "/os-tutorials," which prevented us from extracting the description correctly using the appropriate regex and resource name.
Please don't hesitate to inform me if there's anything you'd like me to undo. I'll follow your recommendations.
cc @Anmol-Baranwal

@Anmol-Baranwal, does it appear acceptable now?

@Anmol-Baranwal, does it appear acceptable now?

Yeah. It's perfect.

We all 3 maintainers will see your logic, and we will approve accordingly.

@Anmol-Baranwal, Please don't hesitate to inform me if you'd like a summary of these changes. It could help save you some time.

@rupali-codes
Please review this.

@rupali-codes, I would greatly appreciate your assistance in reviewing this PR. Your feedback will inspire and motivate me to continue working on closing other issues.
Summary of the PR Changes
components/Header/Header.tsx

Removed the 'result' prop that was previously passed to the TopBar component.

components/TopBar/CategoryDescriptions.ts

Added descriptions for a few items in this file.

components/TopBar/TopBar.tsx

Significant changes made in this component:

Replaced the usage of the 'result' prop with router.query to obtain the search value, a more straightforward approach.
Eliminated redundant code sections.
Introduced a function to validate whether the search resource name is a valid subcategory name. If valid, it displays the subcategory name in the header with an information icon for viewing the description.
Implemented a box shadow and removed transparency as per the suggestion by @Anmol-Baranwal.

components/TopBar/utils.ts

Imported sidebar data, ran a forEach function to extract all subcategory names into an array, and filtered to check if the searched value exists in the database and is valid. This determines whether the item is shown in the Topbar instead of displaying "No result found."

components/popup/popupCategoryDesc.tsx

Deleted this component since it's no longer in use, as the category information is now displayed upon hovering.

database/data.ts

Updated the URL from '/os-tutorials' to '/tutorials' to access descriptions and maintain consistency (removing the 'os' prefix as it wasn't used for other open-source resources).

database/open_source/os-tutorials.json

Renamed this file to 'database/open_source/tutorials.json' for data retrieval.

pages/[category]/[...subcategory].tsx and pages/search.tsx

Removed the 'result' prop from both of these files as it's no longer required.

cc @CBID2

There's a few merge conflicts @aftabrehan. Can you solve those?

There's a few merge conflicts @aftabrehan. Can you solve those?

@CBID2, I'll address them all at once once the PR is approved. Otherwise, I'll continuously encounter conflicts.

It only shows the description when the cursor is on the 'i' button; the moment I move it, the description disappears. This makes it hard to read, and for small devices, users won't be able to read it properly.

I don't think we use a cursor on small devices. For touch devices, the description won't disappear as the hover effect remains until users tap on other elements. So, it'll work as a click, and the user can easily read it.

Also, there are no click effects, like when a user clicks on the 'i' button, and even moves their cursor, it should remain visible until the user clicks somewhere else.

For desktop devices, we're currently displaying the description on hover. If you want to add a delay or prevent it from disappearing when hovering over the tooltip container, we'd need to consider using a different tooltip component.
I believe it's acceptable as is for now. @Anmol-Baranwal, could you please assist with testing and share your thoughts on this?
cc @rupali-codes

@Anmol-Baranwal, In reality, this is excessive because we plan to update this, considering it's not an ideal UI. However, the focus of this PR isn't on the UI. I'd like to request the removal of the description popup, using only the tooltip instead. If everything looks good, could you please approve this PR so I can address the conflicts and you can proceed with the merge?
cc @rupali-codes

@Anmol-Baranwal, the PR conflicts are resolved and ready to be merged.
cc @CBID2 @rupali-codes

@rupali-codes
Whenever we click on icon, it redirects to the home page. Can we neglect the hook for this.

@rupali-codes Whenever we click on icon, it redirects to the home page. Can we neglect the hook for this.

@Anmol-Baranwal, this issue isn't linked to the icon, TopBar, or even the header. It occurs when clicking on elements other than the cards. This matter isn't pertinent to the current PR; it's a separate issue. Can we proceed with the merge, please?

@aftabrehan @Anmol-Baranwal @CBID2 any updates guys? the PR seems so inactive

@aftabrehan @Anmol-Baranwal @CBID2 any updates guys? the PR seems so inactive

I've approved the changes.

Hey @aftabrehan, there are merge conflicts that need to be resolved

There's a few merge conflicts @aftabrehan. Can you solve those?

@CBID2, I'll address them all at once once the PR is approved. Otherwise, I'll continuously encounter conflicts.

@rupali-codes, here's your answer

Okay, I'll resolve these conflicts. But please, help it merge then.

@CBID2, @Anmol-Baranwal, @rupali-codes, The PR conflicts have been resolved. Please, have a look and get it merged. Thank you!

@Anmol-Baranwal & @rupali-codes, you're up! 😊


3D Object fails to load with active theme due to missing draco_wasm_wrapper.js and  draco_decoder.wasm

PHP Version: -   | Shopware Version: <IP_ADDRESS> and Cloud  | Affected area / extension: Platform(Default)

Actual behaviour:
With an active theme, the 3D object fails to load. The application tries to load the draco_wasm_wrapper.js file from the theme's asset directory (specified via window.themeAssetsPublicPath), but the file does not exist there. Fonts and other assets load correctly, indicating that the asset path itself is correctly configured.
Expected behaviour:
The 3D object should load successfully with an active theme, just as it does without the theme. All necessary files, including draco_wasm_wrapper.js, should be accessible from the theme's asset directory.
How to reproduce:

Load the application without a theme and verify that the 3D object renders correctly.
Activate a theme in the application.
Attempt to load the same 3D object.
Observe that the draco_wasm_wrapper.js file fails to load, and the 3D object does not render.

[public] Shopware automated response: This issue is linked to the internal issue: NEXT-39803
[created from NEXT-39803, comment 517231]

[public]

FixVersion Change: <IP_ADDRESS>

This issue will be / was solved in Shopware version <IP_ADDRESS>.
[created from NEXT-39803, comment 520003]


[AV2-640]/unassigned review msg to mentor

The graphql implementation as been merged to develop branch so that we can re-start this story now

It need some changes to the develop branch. While we unassigns a mentor and access the review the direct link, the page display as an empty submission rather than a review.


Add tests for Ellipsoids and Rectangles

Codecov Report

Merging #250 (6ff4733) into master (3d964b6) will increase coverage by 0.74%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   52.70%   53.45%   +0.74%
==========================================
  Files          63       63
  Lines        4838     4838
==========================================
+ Hits         2550     2586      +36
+ Misses       2288     2252      -36

see 8 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Caloris] Support downloading activity CSV via API

useful for some clients that want to automate updating a custom assistant that has access to a table of dust activity
touchy because it means "downgrading" permissions requirement of activity data to builder
should likely be behind a feature flag

is this reeeally Caloris?


refactor: simplify makefile and improve local development

Update project tooling and documentation:

Switch all docker builds to use goreleaser for consistency
Add project-specific Kind cluster name 'add-label-webhook'
Fix manifests deployment order to handle cert-manager dependencies
Update deployment image to use ghcr.io repository
Add comprehensive README with installation and development guides

The main improvements focus on:

Development workflow using Kind and cert-manager
Consistent build process via goreleaser
Clear documentation for setup and configuration

Summary by Sourcery
Update the project to use goreleaser for builds, improve the local development workflow with Kind, and add a comprehensive README.
Enhancements:

Use a project-specific Kind cluster name.
Fix manifest deployment order to handle cert-manager dependencies.
Update the deployment image to use the ghcr.io repository.

Build:

Switch to goreleaser for building Docker images.

Documentation:

Add a comprehensive README with installation and development guides.

@sourcery-ai review


About faiss native interface

Do you have plans for implementing JNI for faiss?
thanks.

Hi, I looked into it quickly, and integrating faiss to our build system seems to be a bit of work. We'd love to add support for it though. Feel free to contribute if you want ;)


Added pullserver deployement example verification tests

These are set of pester tests to verify pull server deployment.

Hi @BerheAbrha, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@BerheAbrha, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;


Create an interactive prototype

Use https://mockflow.com to create better looking mock-ups and make them interactive.

Home Screen

Search Results

Settings

Interactive Prototype Bundle
LocalCastWeatherHTMLPrototype.zip


x/pkgsite: package removal request for github.com/annybs/cassiel/v4

https://pkg.go.dev/github.com/annybs/cassiel/v4
I abandoned this project a long time ago and the repository no longer exists - I would appreciate if it could be taken down. Thank you!

Fixed.


Update the CRs to enable multiple instance nesting without naming conflicts

When combining the three releases as described above and in this diagram: https://github.com/kfox1111/spiffe.io/blob/helm-charts-hardened-nested/static/img/spire-helm-charts-hardened/singlehardened.png, there are naming conflicts between each instance as Release.Name is the same in each case. This PR makes them overridable for each child instance.


feat:[TEMPLATE REQUEST] - Go Fiber + Vue.js - Fullstack #129

Description
Fullstack template using Vue + Go Fiber
Fixes issue #129
Type of Change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
The code has been tested manually
Checklist

[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.

Additional Notes
Add any other context or information that may be helpful for the reviewers.

Summary by CodeRabbit

New Features

Introduced a comprehensive README file outlining the full-stack template with Vue.js and Go Fiber, detailing setup instructions and key features.
Added new Vue components for user authentication (Sign In, Sign Up, Account) and navigation (Header, Footer).
Implemented dynamic project cards display with hover effects.
Established a responsive layout using Tailwind CSS.
Integrated JWT for user authentication and session management.

Bug Fixes

Enhanced error handling and validation feedback in forms.

Documentation

Added a detailed guide for setting up the application, including environment variable configurations.

Chores

Introduced necessary configuration files for Vite and Tailwind CSS.

@Abhishek-Mallick, thanks for your feedback. I haven't encountered such issue before. This Network Error message looks to me, like the backend server isn't running. Anyway I'll check the CORS again to make sure, make the other changes and let you know.

Hi, @Abhishek-Mallick. I added new subpages and UI elements with some extra features, like syntax highlighting. Actually i extended this template to work as a CRUD app for code snippets. Screenshots added to README.
As for the CORS error, it should be fixed. I was only able to recreate it if there was a port mismatch in ALLOWED_ORIGINS (for example, if some app was running on :5173, so Vite used the next available port 5174). However, everything is configurable in .env.


addtwoints_server: correct node name

Happened to notice it.
Perhaps copy-paste from the client implementation?

...


Text too big for mobile devices and footer not responsive

I will convert text to mobile friendly text and fix footer. Please assign me this issue under GSSOC'23

Ok could you do mobile optimization then?? footer got fixed

Yes!! I would love to work on this. Can you please assign it to me under GSSOC'23.


Avoid unnecessary createImageReference in CRI image pull

What is the problem you're trying to solve
I found two problems about createImageReference which can be improved.

We save three references: imageID, repoTag and repoDigest.
https://github.com/containerd/containerd/blob/23573965ffcf8bdb282389b5705de5e3082be824/pkg/cri/server/images/image_pull.go#L200-L207

But during c.client.Pull, we already create an image reference. One reference of the above three may be duplicated.

Inside createImageReference, if there is an existing image, we try to see if the current image has the expected label.

https://github.com/containerd/containerd/blob/23573965ffcf8bdb282389b5705de5e3082be824/pkg/cri/server/images/image_pull.go#L302
But this is a dead branch because the ImageService().Create always returns an "empty" image object when there is an error (already exists error in this case).
Describe the solution you'd like

We may skip if it is equal to ref (image ref):

	for _, r := range []string{imageID, repoTag, repoDigest} {
		if r == ""  || r ==  ref {
			continue
		}

2 We may explicitly get image
oldImg, _ := c.client.ImageService().Get(ctx, name)
if oldImg.Target.Digest == img.Target.Digest && oldImg.Labels[crilabels.ImageLabelKey] == labels[crilabels.ImageLabelKey] {
	return nil
}

Additional context
No response

cc @samuelkarp @ruiwen-zhao

@qiutongs I am not sure I fully understand (1) - Even if reference was create in Pull(), the createImageReference() will not duplicate it since like you pointed out c.ImageService().Create() will return that it already exists with oldImg as empty. And the c.ImageService().Update() will only end up updating the entry if a bucket for it already exists  and if its not found it will return not found error.
I agree with (2) and that should be fixed.
cc @mikebrow @dmcgowan


Unprovision Type does not work on the new interface

Unprovision Type does not work on the new interface
To Reproduce

Delete a service using the UI
Delete a type using the UI

Expected behavior
The type is deleted
The only way to delete the type is to revert to the non Beta UI

Reporting the same issue.

also ran into this issue

reporting same issue, you can alternatively remove type using PowerShell cmdlet Unregister-ServiceFabricApplicationType

fixed with 9.0


Fix broken links

Some of the links to various API docs are broken, which means they might have been moved to a new domain or are simply not existing anymore.
I think it will be nice if we can update the broken links by researching and finding the correct ones.
Example: The CBN API link is broken. It must have been moved to a new domain

Thank you for mentioning this @DeveloperAspire! I'm assigning it to you now.


Basic deployment of a local WAR file does not work

application "myapp" do
  path "/var/builds/myapp"
  repository "/home/etucker/git/myapp/build/libs/myapp-1.0.0-SNAPSHOT.war"
  scm_provider Chef::Provider::File::Deploy

  java_webapp

  tomcat
end

This does not work, throwing the following error:
  * deploy_revision[myapp] action deploy
    - purge old staged files
    ================================================================================
    Error executing action `deploy` on resource 'deploy_revision[myapp]'
    ================================================================================

    NoMethodError
    -------------
    undefined method `new' for nil:NilClass

    Cookbook Trace:
    ---------------
    /home/etucker/.chef/local-mode-cache/cache/cookbooks/application_java/libraries/provider_file_deploy.rb:54:in `action_sync'
    /home/etucker/.chef/local-mode-cache/cache/cookbooks/application_java/libraries/provider_file_deploy.rb:45:in `target_revision'

    Resource Declaration:
    ---------------------
    # In /home/etucker/.chef/local-mode-cache/cache/cookbooks/application/providers/default.rb

    122:   @deploy_resource = send(new_resource.strategy.to_sym, new_resource.name) do
    123:     action force ? :force_deploy : :deploy
    124:     scm_provider new_resource.scm_provider
    125:     revision new_resource.revision
    126:     repository new_resource.repository
    127:     enable_submodules new_resource.enable_submodules
    128:     user new_resource.owner
    129:     group new_resource.group
    130:     deploy_to new_resource.path
    131:     ssh_wrapper "#{new_resource.path}/deploy-ssh-wrapper" if new_resource.deploy_key
    132:     shallow_clone new_resource.shallow_clone
    133:     rollback_on_error new_resource.rollback_on_error
    134:     all_environments = ([new_resource.environment]+new_resource.sub_resources.map{|res| res.environment}).inject({}){|acc, val| acc.merge(val)}
    135:     environment all_environments
    136:     migrate new_resource.migrate
    137:     all_migration_commands = ([new_resource.migration_command]+new_resource.sub_resources.map{|res| res.migration_command}).select{|cmd| cmd && !cmd.empty?}
    138:     migration_command all_migration_commands.join(' && ')
    139:     restart_command do
    140:       ([new_resource]+new_resource.sub_resources).each do |res|
    141:         cmd = res.restart_command
    142:         if cmd.is_a? Proc
    143:           version = Chef::Version.new(Chef::VERSION)
    144:           provider = if version.major > 10 || version.minor >= 14
    145:             Chef::Platform.provider_for_resource(res, :nothing)
    146:           else
    147:             Chef::Platform.provider_for_resource(res)
    148:           end
    149:           provider.load_current_resource
    150:           provider.instance_eval(&cmd)
    151:         elsif cmd && !cmd.empty?
    152:           execute cmd do
    153:             user new_resource.owner
    154:             group new_resource.group
    155:             environment all_environments
    156:           end
    157:         end
    158:       end
    159:     end

    Compiled Resource:
    ------------------
    # Declared in /home/etucker/.chef/local-mode-cache/cache/cookbooks/application/providers/default.rb:122:in `run_deploy'

    deploy_revision("myapp") do
      action [:deploy]
      retries 0
      retry_delay 2
      default_guard_interpreter :default
      deploy_to "/var/builds/myapp"
      repository_cache "cached-copy"
      revision "HEAD"
      rollback_on_error true
      remote "origin"
      shallow_clone true
      scm_provider Chef::Provider::File::Deploy
      keep_releases 5
      enable_checkout true
      checkout_branch "deploy"
      declared_type :deploy_revision
      cookbook_name "myapp"
      repo "/home/etucker/git/myapp/build/libs/myapp-1.0.0-SNAPSHOT.war"
      restart_command #<Proc:0x0000000cc3cb50@/home/etucker/.chef/local-mode-cache/cache/cookbooks/application/providers/default.rb:139>
      before_migrate #<Proc:0x0000000cc39e28@/home/etucker/.chef/local-mode-cache/cache/cookbooks/application/providers/default.rb:166>
      before_symlink #<Proc:0x0000000cc39ba8@/home/etucker/.chef/local-mode-cache/cache/cookbooks/application/providers/default.rb:169>
      before_restart #<Proc:0x0000000cc39900@/home/etucker/.chef/local-mode-cache/cache/cookbooks/application/providers/default.rb:172>
      after_restart #<Proc:0x0000000cc39630@/home/etucker/.chef/local-mode-cache/cache/cookbooks/application/providers/default.rb:175>
      shared_path "/var/builds/myapp/shared"
      destination "/var/builds/myapp/shared/cached-copy"
    end

  * service[tomcat] action restart
    - restart service service[tomcat]
  * execute[wait for tomcat] action run
    - execute sleep 5

Running handlers:
[2015-09-09T08:18:52-03:00] ERROR: Running exception handlers
Running handlers complete
[2015-09-09T08:18:52-03:00] ERROR: Exception handlers complete
Chef Client failed. 7 resources updated in 34.015680264 seconds
[2015-09-09T08:18:53-03:00] FATAL: Stacktrace dumped to /home/etucker/.chef/local-mode-cache/cache/chef-stacktrace.out
[2015-09-09T08:18:53-03:00] ERROR: deploy_revision[myapp] (/home/etucker/.chef/local-mode-cache/cache/cookbooks/application/providers/default.rb line 122) had an error: NoMethodError: undefined method `new' for nil:NilClass
[2015-09-09T08:18:53-03:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)

Any chance this cookbook can be updated to use application cookbook version 4.x?  I think this cookbook needs some TLC.

Application cookbook is pinned to ~>3.0. Issue seems to be with deploy which is part of chef.

So is there intent to fix this or is this cookbook not actively maintained?

@eric-tucker Intent is to fix it but I can't currently give a time estimate. I'm working on a new Java cookbook to base the revamped version on, but it's slow going.

any idea when the new java cookbook will be ready? There doesn't appear to be many cookbooks working deploying java web apps at all.

So I was able to get this working on a basic level. Work is here: https://github.com/howdoicomputer/application_java/commit/c310c09bf3a744a45ff3ded6edc1e2b2d7f3d2b7
I am pointing my application version to a specific fork...
cookbook 'application', git: 'https://github.com/kangguru/application.git'

...because it fixes the application cookbook to the point where it is compatible with Chef 12 while also being compatible with application_java.
I also had to pin tomcat to version 1.3.0 because version 2 onward doesn't expose an interface that application_java expects.
This was all so I could get a two year old Seyren cookbook working. I, uh, sort of got it working but it's a non-optimal and janky solution so I've come to the decision to just write a Seyren cookbook from scratch.
Buuuuut... if people want to use this cookbook at its current state for Chef 12 then maybe this comment will be helpful.


Adds error-handling to streams

As OS3

@FinnStutzenstein I reworked this branch. Please review again and give me a feedback.


nmp build error v.1.5.0

Is it a duplicate question?
No.
Info
Uptime Kuma Version: 1.5.0
Using Docker?: No
OS: Debian 10
Browser: Chrome
Command:
root@uptime:/opt/uptime-kuma# npm install --legacy-peer-deps
Error
npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!

><EMAIL_ADDRESS>install /opt/uptime-kuma/node_modules/@louislam/better-sqlite3-with-prebuilds
> prebuild-install || npm run build-release

prebuild-install WARN install /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by<EMAIL_ADDRESS>
><EMAIL_ADDRESS>build-release /opt/uptime-kuma/node_modules/@louislam/better-sqlite3-with-prebuilds
> node-gyp rebuild --release

gyp ERR! build error
gyp ERR! stack Error: not found: make
gyp ERR! stack     at getNotFoundError (/usr/lib/node_modules/npm/node_modules/which/which.js:13:12)
gyp ERR! stack     at F (/usr/lib/node_modules/npm/node_modules/which/which.js:68:19)
gyp ERR! stack     at E (/usr/lib/node_modules/npm/node_modules/which/which.js:80:29)
gyp ERR! stack     at /usr/lib/node_modules/npm/node_modules/which/which.js:89:16
gyp ERR! stack     at /usr/lib/node_modules/npm/node_modules/isexe/index.js:42:5
gyp ERR! stack     at /usr/lib/node_modules/npm/node_modules/isexe/mode.js:8:5
gyp ERR! stack     at FSReqCallback.oncomplete (fs.js:192:21)
gyp ERR! System Linux 5.11.22-3-pve
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--release"
gyp ERR! cwd /opt/uptime-kuma/node_modules/@louislam/better-sqlite3-with-prebuilds
gyp ERR! node -v v14.17.5
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build-release: `node-gyp rebuild --release`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build-release script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-08-31T19_32_58_252Z-debug.log
npm WARN<EMAIL_ADDRESS>requires a peer of chart.js@>= 2.8.0 < 3 but none is installed. You must install peer dependencies yourself.
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `prebuild-install || npm run build-release`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2021-08-31T19_32_58_479Z-debug.log

Hey, since it can't find the command make, i'll assume you need to install the build-essential.
You can use this command to install it apt-get install build-essential

Oops! Thanks!


[docs] fixed layouts/HeroContainer to fit renderRightWrapper componenent inside screen

Fixed in the mui homepage: Right component (renderRightWrapper) doesn't fit properly inside desktop screens.
Before:

After:

Hey there @Sagarjari01, thanks for opening this PR! Although I appreciate the change, I'll close it because I'm unsure about this design. One thing that bothers me is that the right-hand side column is not exactly in the middle of the container anymore... and the components sitting there, even though interactive, are mostly for illustration purposes, which means I don't think we should be super concerned in them being fully visible in different breakpoints.
For the next time, it's preferable to open an issue first so we can discuss the approach! Really appreciate it! 🤙

Hey @danilo-leal  thanks for guiding me. I am first time contributor. Can I open an issue for the same and let other dev fix that? Please let me know.

@Sagarjari01 if you go to the Issues tabs and filter for "good first issues" or "good to take" labels, you'll find issues that are nice to learn how to contribute! :) I'd also recommend reading the whole Contributing docs. Appreciate you for contributing!


feat(cli): implement --format checkstyle

closes #2355

#3044  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Boshen and the rest of your teammates on  Graphite


test_keepalive_ping_does_not_crash_when_connection_lost intermittent failure on openSUSE zSystems s390x

This is occurring against 8.1 release, and isnt occurring on other platforms.
[   48s] ======================================================================
[   48s] ERROR: test_keepalive_ping_does_not_crash_when_connection_lost (tests.test_protocol.ServerTests)
[   48s] ----------------------------------------------------------------------
[   48s] Traceback (most recent call last):
[   48s]   File "/home/abuild/rpmbuild/BUILDROOT/python-websockets-8.1-28.1.s390x/usr/lib64/python3.8/site-packages/websockets/protocol.py", line 838, in transfer_data
[   48s]     await asyncio.shield(self._put_message_waiter)
[   48s] asyncio.exceptions.CancelledError
[   48s]
[   48s] The above exception was the direct cause of the following exception:
[   48s]
[   48s] Traceback (most recent call last):
[   48s]   File "/home/abuild/rpmbuild/BUILD/websockets-8.1/tests/test_protocol.py", line 1199, in test_keepalive_ping_does_not_crash_when_connection_lost
[   48s]     self.loop.run_until_complete(self.protocol.recv())
[   48s]   File "/usr/lib64/python3.8/asyncio/base_events.py", line 616, in run_until_complete
[   48s]     return future.result()
[   48s]   File "/home/abuild/rpmbuild/BUILDROOT/python-websockets-8.1-28.1.s390x/usr/lib64/python3.8/site-packages/websockets/protocol.py", line 509, in recv
[   48s]     await self.ensure_open()
[   48s]   File "/home/abuild/rpmbuild/BUILDROOT/python-websockets-8.1-28.1.s390x/usr/lib64/python3.8/site-packages/websockets/protocol.py", line 803, in ensure_open
[   48s]     raise self.connection_closed_exc()
[   48s] websockets.exceptions.ConnectionClosedError: code = 1006 (connection closed abnormally [internal]), no reason

Is it still flaky when env variable WEBSOCKETS_TESTS_TIMEOUT_FACTOR is set to 10 or 25?

I set WEBSOCKETS_TESTS_TIMEOUT_FACTOR=10 and have done a few rebuilds, and not seen any failures.
But to be honest it was quite infrequent that I saw this failures.

Then I suggest you keep WEBSOCKETS_TESTS_TIMEOUT_FACTOR big enough to avoid issues.
To give you a bit of background of this...
Some tests in websockets are based on timings. This is bad. I don't know how to rewrite all these tests without depending in timings — and there's better use of my time spent maintaing this library.
I'm using fairly short timings because I'm try to keep the test suite fast. It used to run in less than 1s. Now it drifted to 2,5s. This is bad too.
So I ended up keeping very short timings by default, which usually work in local development, and multiplying all timings by a large factor in CI, which often runs on overloaded shared cloud servers and where flakiness is more annoying (vs. redoing a test run that takes less than 3s).
WEBSOCKETS_TESTS_TIMEOUT_FACTOR is the (undocumented) way to achieve this.

(heavy sigh)

No worries.  Thanks for the explanation.


Fixing UI alignment and sizing issues

Fixes to be implemented:

fixing misaligned text
proper sizing on input field
fixing text to background contrast ratio
many more small ui things

Hey , Can i work on this issue . Thanks

Hey @HridoyHazard , Please Assign this issue me.

hey , Assign this issue to me

I want to do this issue, please assign it to me under HacktoberFest


Add https to share option

If both --secure and --share option are given, the return link of the url image to share will be https, not http.

Share does not properly work with SSL.


Changelog 0.9.751 - 0.9.753

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[X] Documentation
[ ] Build system

Purpose

We love changelogs!

<3 🙇


az aks upgrade and az aks nodepool upgrade

It would appear that the doc states to run az aks nodepool upgrade which upgrades the vmss node pool but not the managed plane for the cluster.
you still need to run az aks upgrade to update the managed plane of the cluster.
the document doesn't state anything about this. Also if you try to upgrade the nodepool 1 major version past the managed control plane it errors out with an invalid naming convention error that takes you to a FAQ and MC_ naming conventions
for example AKS cluster resource/managed control plane version 1.12.8 and try to upgrade the nodepool to 1.13.5 you will get an error like below
Operation failed with status: 'Bad Request'. Details: The value of parameter orchestratorProfile.OrchestratorVersion is invalid. Please see https://aka.ms/aks-naming-rules for more details.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8c420b2c-e868-9a6a-49fb-913f2cd007ef
Version Independent ID: 5c543e08-7d75-21eb-9510-22e2cd56d16b
Content: Use multiple node pools in Azure Kubernetes Service (AKS)
Content Source: articles/aks/use-multiple-node-pools.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Hi @mlearned, @Karishma-Tiwari-MSFT, @MicahMcKittrick-MSFT and @xSilverboltx, looks like this feedback could now be closed? NodePool is now GA (Azure CLI version 2.0.76), the doc describes the difference between az aks upgrade and az aks nodepool upgrade + if you try to upgrade a nodepool to 1.14.7 by having the controlplane at 1.13.11 you will get the right message now: Agentpool Version 1.14.7 is incompatible to managed cluster version 1.13.11. Detail: Minor version of agentPool version 14 is bigger than managedCluster version 13. For more information, please check https://aka.ms/version-skew-policy. Cheers!


Edge 18.17672 adds Font Loading behind flag

Edge 18.17672 adds CSS Font Loading support behind a flag.

@Studio384 What is your source for this? @dstorey can you confirm perhaps?

This is not in Edge currently. There is a checkbox in about:flags but it isn't functional.


fix: replace all node_modules not only the first one

We areusing replace("node_modules", moduleName)   in  filename and import source. but only replace the first matches "node_modules".
nested node_modules is very common in today's nodejs

This should be available as v1.1.0 now


(MODULES-2398) Create Tests for "WindowsProcess" Resource

Add tests for the "WindowsProcess" DSC resource.

Good, would you mind using the words "acceptance test" somewhere in the commit messages next time? It guarantees appveyor is skipped for the PR check.


Middle toast not closing

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ x] 3.x
**I'm submitting a bug report
Current behavior:
ionic toast not closing automatically.
html code:
<ion-content padding>   <button ion-button block (click)="showToast('top')">Show Toast Top Position</button>   <button ion-button block (click)="showToast('middle')">Show Toast Middle Position</button>   <button ion-button block (click)="showToast('bottom')">Show Toast Bottom Position</button>   <button ion-button block (click)="showLongToast()">Show Long Toast</button>   <button ion-button block (click)="showToastWithCloseButton()">Show Toast W/ Close Button</button> </ion-content>
ts code
`import { Component } from '@angular/core';
import { ToastController } from 'ionic-angular';
@Component({
templateUrl: 'template.html'
})
export class BasicPage {
constructor(public toastCtrl: ToastController) { }
showToast(position: string) {
let toast = this.toastCtrl.create({
message: 'Mmmm, buttered toast',
duration: 2000,
position: position
});
toast.present(toast);

}
showToastWithCloseButton() {
const toast = this.toastCtrl.create({
message: 'Your files were successfully saved',
showCloseButton: true,
closeButtonText: 'Ok'
});
toast.present();
}
showLongToast() {
let toast = this.toastCtrl.create({
message: 'Lorem ipsum dolor sit amet, consectetur adipisicing elit. Ea voluptatibus quibusdam eum nihil optio, ullam accusamus magni, nobis suscipit reprehenderit, sequi quam amet impedit. Accusamus dolorem voluptates laborum dolor obcaecati.',
duration: 2000,
});
toast.present();
}
}
`
global packages:
@ionic/cli-utils : 1.4.0
Cordova CLI      : 7.0.1
Ionic CLI        : 3.4.0

local packages:
@ionic/app-scripts              : 1.3.12
@ionic/cli-plugin-cordova   : 1.4.0
@ionic/cli-plugin-ionic-angular : 1.3.1
Cordova Platforms               : android 6.2.3
Ionic Framework                 : ionic-angular 3.5.0

toast.present doesn't take arguments, but you passed in toast.present(toast). Also, pleasepleasepleaseplease format your code next time

Hello thanks for using Ionic! This was fixed in ionic-angular 3.5.1, would you mind updating to that version and giving this another try?

Same bug (@3.5.0).. Gonna check 3.5.1 👍

@jgw96 How can I update to 3.5.1 ?

Hello @yurik94 , you can update to the latest by following the changelog here https://github.com/ionic-team/ionic/blob/master/CHANGELOG.md#352-2017-07-13

Got it, thanks
Il 14 lug 2017 17:31, "Justin Willis"<EMAIL_ADDRESS>ha scritto:

Hello @yurik94 https://github.com/yurik94 , you can update to the
latest by following the changelog here https://github.com/ionic-team/
ionic/blob/master/CHANGELOG.md#352-2017-07-13
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ionic-team/ionic/issues/12293#issuecomment-315389805,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMlCDojHBFb22xxqlI9ECzGNSVEUVtT3ks5sN4msgaJpZM4ORu8u
.

@yurik94 , is this issue still happening?

issue not happening in 3.5.2 and above  version .
please add chip and spinner components in ionic documents (in component section )

Seems working perfectly on 3.5.3 😀
Il 17 lug 2017 18:24, "Justin Willis"<EMAIL_ADDRESS>ha scritto:

@yurik94 https://github.com/yurik94 , is this issue still happening?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ionic-team/ionic/issues/12293#issuecomment-315796576,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMlCDi3WBubB-L5doXVH2n3HuNHEFZ7dks5sO4mygaJpZM4ORu8u
.

Awesome, very glad to hear its fixed 😃 . @praveenandpraveen , site issues should be opened on the site repo. Thanks everyone!


fix wrong handle of commented section in configuration file.

commented section are read as regular section. for instance:
#[section_name]
is read as :
[section_name]
this patch fix this issu and also :

add few comments
improve readability

Best regards

+1

@jsorg71 if looks good please merge


Convert the IllegalArgumentException generated by PojoUtils.realize in GenericFilter to RpcException

What is the purpose of the change
Convert the IllegalArgumentException generated by PojoUtils.realize in GenericFilter to RpcException
see more detail from #7642
Brief changelog
Verifying this change

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #7643 (e4c759a) into master (f8e25ec) will decrease coverage by 0.15%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #7643      +/-   ##
============================================
- Coverage     59.11%   58.96%   -0.16%
  Complexity      528      528
============================================
  Files          1076     1076
  Lines         43443    43398      -45
  Branches       6346     6318      -28
============================================
- Hits          25681    25588      -93
- Misses        14917    14959      +42
- Partials       2845     2851       +6

Impacted Files
Coverage Δ
Complexity Δ

...ava/org/apache/dubbo/rpc/filter/GenericFilter.java
41.07% <77.77%> (+1.44%)
0.00 <0.00> (ø)

...rg/apache/dubbo/remoting/utils/PayloadDropper.java
76.92% <0.00%> (-15.39%)
0.00% <0.00%> (ø%)

...bo/config/event/listener/LoggingEventListener.java
50.00% <0.00%> (-12.50%)
0.00% <0.00%> (ø%)

...dubbo/common/status/support/LoadStatusChecker.java
50.00% <0.00%> (-11.54%)
0.00% <0.00%> (ø%)

...in/java/org/apache/dubbo/common/utils/JVMUtil.java
81.13% <0.00%> (-11.33%)
0.00% <0.00%> (ø%)

...che/dubbo/remoting/transport/mina/MinaChannel.java
35.52% <0.00%> (-10.53%)
14.00% <0.00%> (-1.00%)

...o/remoting/transport/ChannelHandlerDispatcher.java
60.00% <0.00%> (-10.00%)
0.00% <0.00%> (ø%)

...mmon/threadpool/support/fixed/FixedThreadPool.java
80.00% <0.00%> (-7.50%)
0.00% <0.00%> (ø%)

.../dubbo/remoting/transport/netty4/NettyChannel.java
54.45% <0.00%> (-6.94%)
0.00% <0.00%> (ø%)

...ng/transport/dispatcher/all/AllChannelHandler.java
82.75% <0.00%> (-6.90%)
0.00% <0.00%> (ø%)

... and 71 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e25ec...e4c759a. Read the comment docs.


fixed banana-in-a-box syntax in tab group selectIndexChange description

#3364

LGTM

Do I need to make this change somewhere else for it to show up in the docs?

It will be updated when we release a new version


Blog post on Kotosiro sharing server

@dennyglee @MrPowers @JHibbard
I have finished writing a blog post, would you mind if I ask some of you to review this PR?
Thanks.

Thanks for the review, @MrPowers !
I fixed them. Would you mind if I ask you review them again?

LGTM

LGTM! It seems like the preview generation process isn't working though? I reran the checks but it looks like it hangs after the lint check. @MrPowers, any idea why?

I kicked off the build but it looks like there are some errors - could you please review?  thanks!

I will check it out.

I think the errors were caused by invalid properties passed as JSX properties. I have removed all of them. If the errors still persist, I will replace the corresponding JSX with images. Can you please run the checks again? Thanks.

I have reviewed the preview and noticed that the table size and footer note appear to be incorrect.
I think I should fix these issues.

I have addressed all the issues that I noticed. Could you please review it again? Thank you.

@ognis1205 - your blog post is live now: https://delta.io/blog/2023-04-24-open-source-selfhosted-delta-sharing-server/
Thank you for making this valuable contribution to the community.

Thanks for your co-operation! @MrPowers @nkarpov @JHibbard @dennyglee


Spin button signals

WIP.
Example using https://developer.gnome.org/gtk3/stable/GtkSpinButton.html#GtkSpinButton-input after https://github.com/gtk-rs/gtk/pull/317
Seems returning  GTK_INPUT_ERROR still applied new_value (don't changing it equals new_value = 0.;), then not sure that we need it.
cc @gkoz
Edit: GTK_INPUT_ERROR working normal and it depends of update_policy.
This old code for future reference
            Ok(value) if value >= 99. => {
                println!("circular");
                *new_value = 10.;
                Err(()) //Not working
            }

Returning FALSE from trampoline not applied new_value

Seems update on error depends on update_policy which GTK_UPDATE_ALWAYS by default.

Seems closure return value need changing to something like Result<f64, bool>.
Where Err(true) mean GTK_INPUT_ERROR, Err(false) -> FALSE.
But I don't like how it looks.

It won't work with GTK_UPDATE_ALWAYS as we needed return f64 too :cry:

From gtk code gtk_entry_get_text don't need Option. @gkoz, what you think?

Updated to reflect https://github.com/gtk-rs/gtk/pull/318

@GuillaumeGomez, please, restart builds

@EPashkin: Restarted.

Updated

Can I update build script to show stats?

@EPashkin: I think it could be a good idea actually.

Asked in wrong PR :(
Added stats to gtk's make gir

Thanks!


Only create one native plan for a query on an executor

What is the problem the feature request solves?
Currently we create a native plan per task for a query. Even those tasks are on same executor, they still have separate native plans. For the approach, one problem is the additional cost for deserializing the same query plan multiple times and extra memory storing duplicate native plans.
Describe the potential solution
No response
Additional context
No response

One of the challenges related to this is that we start executing ScanExec during construction, as part of query planning. If we want to share one plan per executor (which I agree would be good), then we will need to postpone execution until the execute function is called.

Okay. I forgot this point. It should be the cause of many test failures in the draft PR #1203. I think it is a good direction to go, not just for performance but also for one possible feature I would like to achieve (the feature is only possible when only one native plan on an executor).

I will think if there is a possible way to work around the issue.

I've been considering proposing a change in DataFusion to relax the rules when creating record batches in an operator. Rather than requiring the same physical types for each batch, it would be better just to enforce the same logical type and then coerce the physical types when needed. For example, with a string column, we would then be able to use either Utf8 or Dictionary<_, Utf8>.
I'm not sure how large a change it would be, but I think that would solve our problem.

It seems a fundamental rule in DataFusion physical plan. In many places, physical schema of children operator are used. So once any difference is found between physical schema during planning and actual physical schema during execution, an error would be happened. In these places, some type coercions might be needed to add, maybe it also requires some array casting during execution.


add aria-expanded attribute to Collapse and UncontrolledCollapse #1627

adds aria-expanded attribute to <Collapse /> and <UncontrolledCollapse /> components for accessibility

[x] Bug fix
[ ] New feature
[ ] Chore
[ ] Breaking change
[x] There is an open issue which this change addresses
[x] I have read the CONTRIBUTING document.
[x] My commits follow the Git Commit Guidelines
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

closes #1627

@nylon22 You need to reset your master. Every new PR you create includes all of the other commits from the other PRs.
You should reset your master and start using new branches for each PR.


Added a zone search box to the library window.

After my suggestion here https://github.com/PunishedPineapple/WaymarkPresetPlugin/issues/3#issuecomment-1127007291 I saw that there was already search functionality to filter by zone name in the preset editor, so I reused that. The zone search box disappears (and its functionality is disabled) when filter on current zone is on or categorize presets by zone is off.

Thanks, this looks pretty good!  I'll probably merge it, but just want to think overnight about how it'll interact with drag and drop if that's something that people want as well.

Just one thing for future reference; it's probably good practice to append a non-localized label to the localized name for an ImGui widget (i.e., Loc.Localize( "Search Input Text: Search", "Search" ) + "###Zone Filter Text Box").  It's probably not an issue here since it's backed by a ref string and nothing else is being localized to have that same name, but I get nervous.  Anyway, I'll add that in since I'm working on that stuff rn anyway.  Thanks again!

Thank you, the convention makes sense and I'll keep it in mind.


Document Area3D wind properties only affecting SoftBody3D

See https://github.com/godotengine/godot-proposals/issues/2591#issuecomment-2041151431.

Thanks!