Fix building packages with bin targets

I have a cross-platform application that needs to build a bin target on Windows, macOS, and Linux (at minimum). cargo-apk attempts to build my bin target as a cdylib, and explodes after signing the first artifact:
thread 'main' panicked at /home/jay/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-subcommand-0.12.0/src/artifact.rs:51:23:
Bin is not compatible with Cdylib
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: cargo_subcommand::artifact::Artifact::file_name
   3: cargo_subcommand::subcommand::Subcommand::artifact
   4: cargo_apk::apk::ApkBuilder::build
   5: cargo_apk::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

This fixes the panic by filtering artifacts to only build libraries.
I couldn't find an open issue for this, but there is a related comment in https://github.com/rust-mobile/cargo-apk/issues/23#issuecomment-1720945135

I couldn't find an open issue for this, but there is a related comment in https://github.com/rust-mobile/cargo-apk/issues/23#issuecomment-1720945135

This should strictly be unrelated? That user/comment is trying to reuse the same target as multiple crate types, which is not valid. It sounds like you have multiple targets of differing types defined in the same crate instead?

How are you invoking cargo apk to cause this? If I had to guess, --lib was forgotten to disambiguate whether it should build just the library target and not any binary, which we're scraping up now via autobins support from https://github.com/rust-mobile/cargo-subcommand/pull/17.
A few more thoughts:

Despite cargo/rustc not providing a clean way to override this, we've been working on some ugly yet functional hacks to override the crate-type from a bin to a cdylib to support APK building without Cargo.toml changes;
How does your patch deal with library and binary types detected from i.e. [examples]? Was this tested?
Why is your patch only affecting cargo build, but not any of the other commands that deal with artifacts?

It sounds like you have multiple targets of differing types defined in the same crate instead?

Yes, this is what happens when you have both main.rs and lib.rs in the same package. Which is probably the most common setup for packages that build executables.

If I had to guess, --lib was forgotten

I wasn't aware of this argument. Can I ask the corollary question to understand the purpose of --bin for Android? My limited understanding is that binary artifactss can't work on Android at all. Which is why cdylib is needed in the first place. If the crate type is cdylib then it is explicitly not a bin. Both can be used together, but to my knowledge again, the bin doesn't mean anything for Android.
I cannot answer your remaining questions because of this confusion:

cdylib is required for Android builds.
cdylib and bin need to be built separately (this PR, fixing the error in OP).
bin is used for building the desktop apps targeting macOS, Windows, Linux.

The error makes it clear that passing the bin artifacts to cargo as CrateType::Cdylib is invalid. The latter is hardcoded here:
https://github.com/rust-mobile/cargo-apk/blob/caa806283dc26733ad8232dce1fa4896c566f7b8/cargo-apk/src/apk.rs#L223
Furthermore, only ApkBuilder::build() is affected, which the other subcommands do not call.
Given this, I cannot fathom how --bin would ever work at all.

--bin is implemented by the generic cargo-subcommand library, which intentionally is not limited to the library-only scope of cargo-apk. A generic solution involves adding a configuration to cargo-subcommand to limit its output to cdylib targets only, by skipping non-library autodetected targets and explicitly erroring on user-specified (on the cmdline) non-library targets.
That is however no longer an issue when (not if, because we've already proven this is possible) cargo-apk translates bin targets to cdylib, requiring minimal user/crate changes.

Furthermore, only ApkBuilder::build() is affected, which the other subcommands do not call.

Both Run and Gdb call ApkBuilder::build() internally. See also how the top-level command collects artifacts for those. And while at it, ApkBuilder::check() should have been adequately limited as well.

I think I see. You are arguing to move the filtering into cargo-subcommand. I am completely indifferent to how the bug is fixed, so long as it is fixed.
I still don’t know what it means to “translates bin targets to cdylib” but that sounds like something I want. It looks like ndk-examples are technically supposed to be bins, but they are cdylibs. Where can I find examples of real bins that build for Android?

I don't really care where the filtering happens - just explained why cargo-subcommand supports bin targets - as long as it is consistent for every cargo-apk subcommand. And with that, as long as we also error out appropriately (or find a way to disable this) when the user requests a --bin or a binary --example on the command line.

The reason examples are filtered is because artifact.r#type == ArtifactType::Example. That's a good thing to get fixed. The ndk-examples are not binary examples (they can't be due to the weird cdylib requirement for building native Android code). They build after refining the filter to artifact.r#type != ArtifactType::Bin.
Can you provide any existing code bases where --bin or "binary --example" needs to be passed to cargo-apk? I asked this in my last comment and it's crucial that I have a reproducible test case to address the concern for binary artifacts. At this time, I'm inclined to believe that binary artifacts are not supported at all in the entire ecosystem for Android native builds because every code sample I have found uses cdylib.


Says it's a dublicate mod

Emberforged 1.1.0 requires EmbersRekindled 1.19 and MineFantasy Reloaded 0.2.9. It won't work without them.
If I try to delete EmbersRekindled and put EmbersExtendedLife 1.23.5 to the folder, it says no EmbersRekindled.
If I put EmbersRekindled with EmbersExtendedLife to the folder, it says duplicate ID

So I can not use Embers Extended Life at all...
Latest: https://pastebin.com/vp5KfQ8t

v1.23.6 is uploaded to Curseforge. Now you should be able to run Emberforged with Embers Extended Life.

There is no need to use rekindled only use my fork and emberforged


Multi-thread DAG Build for Very Large Workflows?

I have a pipeline where part of the configuration is specifying the number of chunks to produce for a dataset. Because of one of the tools I’m using, I have to use many chunks and keep the chunk size relatively small. This means that the complete pipeline will execute tens of thousands of jobs, and the DAG takes a very long time to compile.
As a feature, is there any way the process of building the DAG could be multi-threaded to go faster?

I also do have issues with DAG build times for large workflows. I'm not sure how feasible multi threading the DAG computation is. The batch option does exist, however in its current implementation it's quite annoying to use since you have to execute each batch. I'm not super familiar with the codebase, but I'm curious if there could be a way to calculate batches in parallel. Regardless some kind of internal automation of batching would make the batch option much more useable.

I also would support a solution for long DAG building times, while I am waiting for a 500,000 jobs DAG creation. Wondering if this is feasible at all.

It would be nice if the user could provide some kind of hint that would avoid using toposort on trivial parts of the graph. Most very large workflow DAGs are large due to a trivial subgraph topology that can be sorted in linear time.
For example, for a scatter/gather pattern, instead of sorting n scatter edges and n gather edges (an all-vs-all operation), if a hint allows you to start with n pairs of scatter and gather edges, you don't have to do any sorting at all, and you can treat the whole subgraph as a single edge in the rest of the problem.


How I maintain one session for all gemini suits ?

Hi Team ,
I am facing issue while run multiple Gemini suits, I want same login session to be maintined for all Gemini Suits,
Eg :
1)Suits One (Login functionality)
-Login page  (set logging credentials )
2) Suits Two(Dashboard page )
Capture some header/ footer.
Result:
For every suit, A new browser session is open. so I am not able to test suit no two without log-in into the application although  I am able to log-in the application in suit one but Browser is closed after successful completion of Suit one. Here for every suits browser wants login.
Expected behaviour:
Gemini should maintain login session throughout all Suits and browser should not be close in between the Suits

All suites in gemini are expected to be independent because in general they are run in parallel.
You can obtain the behavior you've described by setting sessionsPerBrowser option to 1 and suitesPerSession to Infinity. But in fact even that will not guarantee that all suite will be run in one session in case of errors.
I'd suggest you to make login actions in before hook.

Can you show your config file and gemini output with DEBUG=gemini:* env variable?

``
module.exports = {
rootUrl: 'http://localhost',
gridUrl: 'http://localhost:4444/wd/hub',

screenshotsDir: 'frontend/gemini/references/components',

calibrate: false,
tolerance: 50,
httpTimeout: 30000,
sessionRequestTimeout: 30000,
compositeImage: true,
sessionsPerBrowser: 1,
suitesPerSession: 1,
retry: 2,
browsers: {
    'desktop-chrome': {
        //windowSize: '1025x1000',
        desiredCapabilities: {
            browserName: 'chrome'
        }
    },
    'desktop-firefox': {
        windowSize: '1024x1000',
        desiredCapabilities: {
            browserName: 'firefox'
        }
    },
    'desktop-ie': {
        windowSize: '1024x1000',
        desiredCapabilities: {
            browserName: 'internet explorer'

        }
    }
},

sets: {
    local: {
        files: [

        ],
        browsers: ['desktop-chrome']
    }
},

system: {
    parallelLimit: 1,
    plugins: {
        'html-reporter': {
            enabled: true,
            path: 'frontend/gemini/report'
        },

        'teamcity': {
            enabled: true,
            path: 'frontend/gemini/teamcity'
        },
        optipng: {
            level: 5
        }
    }
}

};
``

@j0tunn  Sorry for the late response
`
module.exports = {
rootUrl: 'http://localhost',
gridUrl: 'http://localhost:4444/wd/hub',

screenshotsDir: 'frontend/gemini/references/components',

calibrate: false,
tolerance: 50,
httpTimeout: 30000,
sessionRequestTimeout: 30000,
compositeImage: true,
sessionsPerBrowser: 1,
suitesPerSession: 1,
retry: 2,

browsers: {
    'desktop-chrome': {
        //windowSize: '1025x1000',
        desiredCapabilities: {
            browserName: 'chrome'
        }
    },
    'desktop-firefox': {
        windowSize: '1024x1000',
        desiredCapabilities: {
            browserName: 'firefox'
        }
    },
    'desktop-ie': {
        windowSize: '1024x1000',
        desiredCapabilities: {
            browserName: 'internet explorer'

        }
    }
},

sets: {
    local: {
        files: [
          //  'frontend/gemini/specs/components/marlboro-login/index.js',
           'frontend/gemini/specs/components/mhqapp/mhq.js'
        ],
        browsers: ['desktop-chrome']
    }
},

system: {
    parallelLimit: 1,
    plugins: {
        'html-reporter': {
            enabled: true,
            path: 'frontend/gemini/report'
        },

        'teamcity': {
            enabled: true,
            path: 'frontend/gemini/teamcity'
        },

        optipng: {
            level: 5
        }
    }
}

};
`

As I've said before you should set:
suitesPerSession: Infinity

Or just remove this option from config, because this is the default value. Take a look at config documentation for more details


-bash: ./run.exe: cannot execute binary file: Exec format error

Hi,I complied with FLOW=sw_emu and it can be complied successfully.But when I executed command like this:
#./run.exe conv.aocx
-bash: ./run.exe: cannot execute binary file: Exec format error
Anyone got a idea?
Thanks very much.

Hi, I am getting the same error while running conv.aocx. How did you fix it?Moreover I already have executed sw_steup_emu.sh provided.

Also if i run the command like below it gives error.

Did you figure it out?

you should first set emulation env


[Incremental DNM] Very rough first cut of ModuleDependencyGraph & other hooks

Unit tests pass.
I'll clean it up a bit before asking for review.

@swift-ci please test

@swift-ci please test


Replace the "checkOnSave" and "checkWith" parameters with a new "actionOnSave" parameter

Remove the "checkOnSave", "checkWith" configuration properties.
Add a new property "actionOnSave" with the following available values:

"build" - on save it will build.
"check" - on save it will check.
"clippy" - on save it will check with clippy.
"run" - on save it will run.
"test" - on save it will test.
null - on save it will do nothing.

I am working on it.


Docs - add mfa instructions

also reorganizes SSO docs

Pull Request Test Coverage Report for Build 322670df71ab232a766c67bf1d460477cba91f98-PR-904

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.479%

Totals

Change from base Build 80c182941a25d1005fdfc1f8828d88c0fe9f0ef2:
0.0%

Covered Lines:
1052

Relevant Lines:
1559

💛  - Coveralls


Add nostr support?

Nostr can be used to signaling for free. See: https://github.com/nbd-wtf/nostr-tools

Yes, I have a Nostr implementation in progress at the moment! I'll update this issue when it lands.

Also MQTT looks interesting :) There are alot of MQTT Broker out there that can be used for free.

@freehuntx could you post links regarding open MQTT brokers?

https://www.hivemq.com/mqtt/public-mqtt-broker/
wss://broker.hivemq.com:8884
https://www.emqx.com/en/mqtt/public-mqtt5-broker
wss://broker.emqx.io:8084
https://test.mosquitto.org/
wss://test.mosquitto.org:8080
Client:
https://github.com/mqttjs/MQTT.js

@freehuntx I just published 0.17.0 which includes an MQTT strategy. Thanks for suggesting it!

Nice! I will check it out 👍

@freehuntx 0.18.0 features a new Nostr strategy

Awesome :D Nice work man!


Add documentation about dataset viewer feature

Add to the docs more details about the dataset viewer feature in the Hub.
CC: @julien-c

In particular, include this somewhere in the docs: https://huggingface.co/docs/hub/datasets-viewer#access-the-parquet-files


Create placeholder 'inject-file-fragments' NPM package

This PR was included in release version 1.5.0 :tada:


[#409] Update docs based on feedback - Make KeyVault creation optional

Addresses # 409
Description
This PR updates the 01-Create Shared Resources pipeline making the creation of the KeyVault and the AppRegistrations optional.
The KeyVaultObjectId variable is now optional and when it's set, the steps to create the keyVault and the AppRegistrations will be executed. If it's not set, or its value is blank, these steps will be skipped.
Detailed Changes

Merged the Create_Key_Vault and Create_App_Registrations stages into one stage.
Added a job to evaluate the value of the KeyVaultObjectId variable.
Added a condition to the Deploy_Key_Vault job to run only if the KeyVaultObjectId is set.

Testing
These images show the pipeline running with and without the KeyVaultObjectId variable.

Promoted to MS in PR# 446


[Suggestion] Discord Chat

Hi there.
I wanted to make a suggestion more or less for the project as a whole.
Discord is becoming more popular and generally easier to access as you aren't required to create a account to access the server (depending on server security). As the program currently has Discord rich presences integration, and the widely growing popularity of it, I though that possibly having an alternative support/chat space on Discord might be appropriate. I still do agree that keeping the Gitter might be appropriate due to being linked with your GitHub account and being a quick access to a chat,
Additionally the program can be put under the Discord open source scheme which would allow for a Vanity Link such as discord.gg/GPMDP with a custom background. This can allow for it to be displayed on the page and possible grow some more people using and developing the program.

I went ahead and made a new server, nothing special, but if discord is your thing: https://discord.gg/n2RDdVt

Closing out as the chat was created


Floating point precision issue with sinus^-1

When I calculate sin^-1 0.5 i end up with
30.000000000000004
but it should be just exact
30
I guess this is down to floating point precision?

Using the javascript console in chrome, I see that :

Math.asin(0.5) * 180/Math.PI
30.000000000000004

Also :
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math

Note that the trigonometric functions (sin(), cos(), tan(), asin(), acos(), atan(), atan2()) expect or return angles in radians. To convert radians to degrees, divide by (Math.PI / 180), and multiply by this to convert the other way.
Note a lot of the math functions have a precision that's implementation-dependent. This means that different browsers can give a different result, and even the same JS engine on a different OS or architecture can give different results.

So, I'm not sure what can be done about this apart from adding a set of special cases with known and precise answers.

I'm going to close this - please re-open if you have a suggestion (prefer a PR, but hey).


Do you have any intention of porting this mod to 1.16.4?

Not in the near future. Feel free to port it yourself!

Not in the near future. Feel free to port it yourself!


fix: let 'set' command fail on key not found

Whenever a key is not found within a 'set' command. The command should error out instead of trying to continue execution and assign the value to a partially parsed key.
Example:
toml set --toml-path pyproject.toml tool.ruffs.target-version py39
The table tool.ruffs does not exist but the current implementation captures this exception and continues along, actually executing tool.target-version = "py39".
I believe a better implementation is to not capture the exception at all and error out, this way no unintended modifications to the TOML file are performed.
Another option is to continue capturing the exception but error out using exit(1).
What do you think?

Thanx, I do prefer the exit(1) variant, because the user don't need the Python traceback.

I have updated to use exit(1) and added more information on the error message, now it prints:
error: non-existent key 'tool.ruffs.target-version' can not be set to value 'py39'


window.restoreWindow isn't honored

Issue Type: Bug
When using VSCode with remote WSL2 projects, the "window.restoreWindows" settings I have of "none" is ignored and editors for the previous session are restored.
This also applies when code is started with the -n option. It is ignored and the previous session is restored.
This behavior is not seen when not using the Remote - WSL extension.
Extension version: 0.38.10
VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:59:35.033Z)
OS version: Windows_NT x64 10.0.18941
Remote OS version: Linux x64 4.19.43-microsoft-standard

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2112)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: enabledrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.93GB (2.48GB free)

Process Argv
--folder-uri=vscode-remote://wsl+Ubuntu-18.04/home/sean/code/ponylang/pony-stable --remote=wsl+Ubuntu-18.04

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu-18.04

OS
Linux x64 4.19.43-microsoft-standard

CPUs
Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz (8 x 2111)

Memory (System)
14.58GB (14.37GB free)

VM
0%

The current design is to only restore local windows. Opening a remote window can involve a download and building up a connection, so we thought to only do this if the user really wants it.
Are you suggesting that we remote local windows when the open comes from the remote itself (e.g. code from a WSL shell?

When running version 1.43 freshly installed, setting window.restoreWindow to off doesn't work at all, it still restores previous windows.
Proof: https://www.youtube.com/watch?v=oi7vU5lUiZM&feature=youtu.be

@Rynhho The window with the 4 folders is an unsaved, untitled workspace.
These are always restored as it would be a loss of data as they can't be restored in any other way.
Would you mind filing a new issue?

@SeanTAllen When restoreWindows: none is set, we still restore all unsaved and untitled workspaces as well as all empty windows with unsaved editors in them.
Is that what you are seeing?
As explained, the rational for that is that if they weren't restored there's no way to get them back again.

@Rynhho The window with the 4 folders is an unsaved, untitled workspace.
These are always restored as it would be a loss of data as they can't be restored in any other way.
Would you mind filing a new issue?

Oh okay I didn't knew that. Do I still fill a new issue? This seems like good behaviour actually.

No need to file an issue if you are fine with that behavior :smile:

No need to file an issue if you are fine with that behavior 😄
What we could look into is to add an entry to the recent history as an alternative way to restore the workspace @bpasero

And display a message of recovery otherwise the user might forgot about that workspace :)
Thank you for your time.

Looks like bug filed by Sean is not fixed. Window is restored when I open same workspace in remote-WSL.

@openingnow Can you please give precice steps? What do you mean by 'open same workspace in remote-WSL` ?

From my testing, "window.restoreWindows": "none" now properly works (with the rule as explained here: https://github.com/microsoft/vscode/issues/77924#issuecomment-607477725)
If you still see issues, please give add steps to reproduce.

I mean 'restoring state when reopening workspace '. Found it also happens without WSL environment. Maybe it is a desired behavior, right?

@openingnow Do you mean using the Reopen in WSL command? The window.restoreWindow is for something different.
If you want the  Reopen in WSL command to be improved. please file an issue against https://github.com/microsoft/vscode-remote-release an describe how.

Closing as already fixed. Please file a new issue with steps if you still have trouble.


refactor(docker): bake && image fixup

add docker-bake config so buildx can be used natively

Motivation

Solution

Yes, also would you want to add additional CPUs like ARM?
[data:image/gif;base64,R0lGODlhAQABAIAAAP///wAAACwAAAAAAQABAAACAkQBADs=3D]
On Wed, Oct 5, 2022 at 2:23 AM Matthias Seitz @.***> wrote:

@mattsse commented on this pull request.
TIL https://docs.docker.com/engine/reference/commandline/buildx_bake/
[https://docs.docker.com/engine/reference/commandline/buildx_bake/]
I've never used it before, is it worth including a note in the readme section?
https://github.com/foundry-rs/foundry#installing-via-docker
[https://github.com/foundry-rs/foundry#installing-via-docker]
—
Reply to this email directly, view it on GitHub
[https://github.com/foundry-rs/foundry/pull/3455#pullrequestreview-1131136061],
or unsubscribe
[https://github.com/notifications/unsubscribe-auth/AH2D4LETW3SMQKWMAR2LFKTWBVCIVANCNFSM6AAAAAAQ5D25P4].
You are receiving this because you authored the
thread.[https://ci3.googleusercontent.com/proxy/7x6HDtjpcjS5k3zpXFj3HboAO8C-Kvy3EdGd3wFtSzcBrId6clLpKNQW71BQzy0-BZU2-YVEVGP8u0l9dOVNBRiar13JFDDRsuQ4NvW_Fw7A7gBZUJBRpIjAClmYW6Cjp5j2MjHnVuFYBVSY_X-6I7jd3eeIYLrVg8afVtFAdOfVHLn4I2BMQeiEztnbgFs0BZQoqsgoWkN56uHQSp9Vq_bhbg9z406kloM37TX7nbiiHbTfZuSBpmC8_5oB=s0-d-e1-ft#https://github.com/notifications/beacon/AH2D4LDS5UTCJ7V4XJVQGSTWBVCIVA5CNFSM6AAAAAAQ5D25P6WGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTSDNPCD2.gif]Message
ID: @.***>

that should be possible, and would make sense I think

I think let's not package extra Docker utils

I think let's not package extra Docker utils

This is not extra docker utils, this enables docker's new buildx system that enables cross compilation to different archs. It also speeds up docker build times


Feature/276 participations

Changes
Add support for context/participations including AQL.
Related issue
Fixes https://github.com/ehrbase/project_management/issues/276
Additional information and checks

[ ] Pull request linked in changelog

NB. For testing (AQL formatting in particular), this branch relies on changes done in PR https://github.com/ehrbase/ehrbase/pull/248 (now merged into develop).


[wip] convert ingress into v1alpha3 gateway+virt service

No merging with other gateways for the moment.
I have added the conversion function. Would appreciate some help in plumbing
this into the config system in pilot/pkg/kube/. I can add the gateway code.
cc @ijsnellf @GregHanson @ZackButcher
Signed-off-by: Shriram Rajagopalan<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andraxylia
Assign the PR to them by writing /assign @andraxylia in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
577579c27abcf42685dd32529db9d2af469ad740
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
577579c27abcf42685dd32529db9d2af469ad740
link
/test istio-unit-tests

prow/istio-presubmit.sh
577579c27abcf42685dd32529db9d2af469ad740
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Tests using golden files? It would be great to verify and understand thru examples what this is attempting to do.

@rshriram: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
616e0fedcadcf41990c1de86275b48e559102fec
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
616e0fedcadcf41990c1de86275b48e559102fec
link
/test istio-pilot-e2e-v1alpha3

prow/istio-pilot-e2e.sh
616e0fedcadcf41990c1de86275b48e559102fec
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

closng.. moved to a separate branch envoyv2-ingress for dev.


Problem using pnpm

When using NPM I have no issues, npm prisma generate runs and generates the desired ERP daigram.
my code in schema.prisma is:
generator erd {
  provider = "prisma-erd-generator"
  output   = "../static//ERD.svg"
}

I reinstall everyting using pnpm and run pnpx prima generate, I get the following error:
Error: Generator at prisma-erd-generator could not start:

/bin/sh: prisma-erd-generator: command not found

 ERROR  Command failed with exit code 1: prisma generate

pnpm: Command failed with exit code 1: prisma generate
    at makeError (/Users/ben/.cache/node/corepack/pnpm/7.30.0/dist/pnpm.cjs:24159:17)
    at handlePromise (/Users/ben/.cache/node/corepack/pnpm/7.30.0/dist/pnpm.cjs:24730:33)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Object.handler [as dlx] (/Users/ben/.cache/node/corepack/pnpm/7.30.0/dist/pnpm.cjs:220504:7)
    at async /Users/ben/.cache/node/corepack/pnpm/7.30.0/dist/pnpm.cjs:228244:21
    at async main (/Users/ben/.cache/node/corepack/pnpm/7.30.0/dist/pnpm.cjs:228211:34)
    at async runPnpm (/Users/ben/.cache/node/corepack/pnpm/7.30.0/dist/pnpm.cjs:228466:5)
    at async /Users/ben/.cache/node/corepack/pnpm/7.30.0/dist/pnpm.cjs:228458:7

pnpx prisma generate gives us the same error, but pnpm prisma generate works.

That makes sense. Because pnpx isn’t going to fetch all your generator dependencies as well. So it may be running from a different folder than the pnpm install which means that .bin/mmdc program might not exist where it is looking.

I'm currently trying to generate my erd in an actions pipeline. On my machine it works fine with pnpm but in the action I get the following error:
Command failed: /home/runner/work/ProTrack-2023/ProTrack-2023/node_modules/.bin/mmdc -i /tmp/prisma-erd-n2bzkt/prisma.mmd -o /home/runner/work/ProTrack-2023/ProTrack-2023/prisma/erd/erd.svg -t forest -c /tmp/prisma-erd-n2bzkt/config.json

my generator config looks like this
generator erd {
  provider                  = "prisma-erd-generator"
  output                    = "./erd/erd.svg"
  theme                     = "forest"
  includeRelationFromFields = true
  mmdcPath                  = "node_modules/.bin"
}

Everything looks good to me. Does generating a markdown work? If so, its related to where github actions or gitlab is putting those .bin files

Yes that works. I will look up where github is putting the .bin

pnpx prisma generate gives us the same error, but pnpm prisma generate works.

This was the solution, closing the issue.


Scroll to object

hello, I found your solution, I liked the implementation, but there is a problem when the view is too high - it does not scroll to the desired object, tell me how it could be better done? for example, you highlight 1 cell, but what if you make 15 of them and display the highlighting at the last one
ThatSection() -> ForEach(1 ..< 15) -> last.cell.spotlightElement

Hey @zarag13, thanks for taking the time to review the code and provide your feedback. I’m aware of this issue with the spotlight system, and it’s something I had considered during the initial implementation. The reason it wasn’t tackled at the time is that SwiftUI didn’t provide a way to programmatically reference and control ScrollView components. Without that capability, the spotlight system wasn’t able to manage the scroll views in the app.
When I first wrote the spotlight system, I hadn’t yet come across the ScrollViewProxy component. This proxy seems like a potential solution, allowing us to programmatically scroll to specific components. However, we’d need to explore exactly how the proxy works and figure out the best way to integrate it into the spotlight system.
One possible approach could be adding an optional ScrollViewProxy parameter to the spotlightElement(_:,_:) modifier. This way, users can provide the scroll view proxy for elements that might need to be scrolled into view. The SpotlightViewModifier or SpotlightViewModel could then reference that proxy and scroll elements into frame when needed.
I’d be happy to create an enhancement for this functionality. Let me know what you think!

Got it. If you don't mind, would you be willing to share how you handled the scrolling? Did you utilize ScrollViewProxy?
No, there is currently no support for multiple elements at once. Although, we can adjust that by making the Spotlight.elements array a 2D array, the SpotlightViewModel.target an array, and FocusOverlay.init take in an array of focus rects.


Question: How do I make the seed work for 2^32 or 2^64 numbers?

How do I make the seed work for 2^32 or 2^64 numbers?

Sorry, I'm not sure I understand what you're trying to do.
On Friday, 26 February 2016, Andrew Mast<EMAIL_ADDRESS>wrote:

How do I make the seed work for 2^32 or 2^64 numbers?
—
Reply to this email directly or view it on GitHub
https://github.com/josephg/noisejs/issues/15.

How do I change this function to work for 2^32 or 2^64 numbers?
  module.seed = function(seed) {
    if(seed > 0 && seed < 1) {
      // Scale the seed out
      seed *= 65536;
    }

    seed = Math.floor(seed);
    if(seed < 256) {
      seed |= seed << 8;
    }

    for(var i = 0; i < 256; i++) {
      var v;
      if (i & 1) {
        v = p[i] ^ (seed & 255);
      } else {
        v = p[i] ^ ((seed>>8) & 255);
      }

      perm[i] = perm[i + 256] = v;
      gradP[i] = gradP[i + 256] = grad3[v % 12];
    }
  };

Why do you want that? Do you simply want more variety in the output?

I want to be able use this:
String.prototype.hashCode = function() {
  var hash = 0, i, chr, len;
  if (this.length === 0) return hash;
  for (i = 0, len = this.length; i < len; i++) {
    chr   = this.charCodeAt(i);
    hash  = ((hash << 5) - hash) + chr;
    hash |= 0; // Convert to 32bit integer
  }
  return hash;
};

So basically I want to know what to do with the module.seed to make it work with 2^32 numbers (So I can use noise.seed("seed".hashCode());

You can take your 2^32 number and divide it by 2^32 then use that.

With this?
String.prototype.hashCode = function() {
  var hash = 0, i, chr, len;
  if (this.length === 0) return hash;
  for (i = 0, len = this.length; i < len; i++) {
    chr   = this.charCodeAt(i);
    hash  = ((hash << 5) - hash) + chr;
    hash |= 0; // Convert to 32bit integer
  }
  return hash / Math.pow(2, 32);
};

This should works yes.


Update Vulkan-Headers to 1.3.204

Vulkan 1.3 is out, with many extensions stabilized.  This'll have to remain draft until the next spec version (hopefully next week) where (again, hopefully) https://github.com/KhronosGroup/Vulkan-Docs/pull/1746 is incorporated - otherwise we'll have to work around in our generator :(

Can't update to 1.3.205 either, vk.xml got broken there as well: https://github.com/KhronosGroup/Vulkan-Headers/pull/258#discussion_r799449490

Seems to have been fixed in https://github.com/KhronosGroup/Vulkan-Docs/issues/1764.

Should have probably left out the unsafe part, since being able to use this trait bound in a safe wrapper is already well enough of a possibility to risk an API break.
I don't want to go figure out how to add a bunch of type aliases for these either, at least :)

Yeah, I don't think that's worth the trouble; this only comes up on Vulkan minor version bumps anyway.


Brutal crash on Nexus4 with Android 5.1.1

Thanks for this project.
I have tried it out with Wowza Streaming CLoud but I have a brutal crash where my device gets killed and restarts. Unfortunately LogCat does not show any logs.
I tested the CustomRTSP example and only changing the resolution to 640 x 480 otherwise everything left as default. Wowza sees the connection and streaming starts but after 30 seconds the device reboots..
Any idea?

I never see a reboot. Maybe your encoder crash.
If you try with low fps and low videobitrate the mobile reboot too?
If you delete the code in methods in the builder:
@Override
  public void inputYv12Data(byte[] buffer, int width, int height) {
    videoEncoder.inputYv12Data(buffer, width, height);
  }

  @Override
  public void inputNv21Data(byte[] buffer, int width, int height) {
    videoEncoder.inputNv21Data(buffer, width, height);
}

You will do a only audio stream (you never send video data to encoder). If the problem is solved then maybe your device has a problem with videoencoder.
In this case:
You can try with other video colorformat. Go to preparevideo() in the builder and test with camera in YV12 and FormatVideoEncoder in all YUV420 (YUV420PLANAR, YUV420SEMIPLANAR, YUV420PACKEDPLANAR, YUV420PACKEDSEMIPLANAR).
FormatVideoEncoder.YUV420Dynamical automatically select the first compatible color format for your encoder and maybe that color is bug in your device.
Other way is try select other h264 video encoder if your device have more than one. For this go to VideoEncoder class in encoder module and hardcode the other encoder name in:
videoEncoder = MediaCodec.createByCodecName(encoder.getName());
Use this method for know all h264 encoders in your device (mime = "video/avc"):
private void chooseVideoEncoder(String mime) {
    int count = MediaCodecList.getCodecCount();
    for (int i = 0; i < count; i++) {
      MediaCodecInfo mci = MediaCodecList.getCodecInfoAt(i);
      if (!mci.isEncoder()) {
        continue;
      }
      String[] types = mci.getSupportedTypes();
      for (String type : types) {
        if (type.equalsIgnoreCase(mime)) {
          Log.i(TAG, String.format("videoEncoder %s type supported: %s", mci.getName(), type));
        }
      }
    }
  }

I think the phone should be OK - works fine with for example the libstreaming-project. I am really interested in RTMP support so I hope to get your project working.
Many thanks for your informative reply. I will try out your suggestions and report back.

Well, I have tried your suggestions.
With RTSP, the only configuration I can get working is using 320x240, BR 1500, FPS 21, audio BR 64, 44100 and Mono. I have now tried all possible configurations but generally lowering quite a bit the values, things gets better although sometimes the device reboots.
I tried to disable video as suggested but if I do then there is no connection with Wowza. Maybe I am doing it wrong.
I also tried changing the FormatVideoEncoder as suggested, some worked, some not but would still lead to a reboot unless I lowered the configuration values. I also tried to hardcode the encoder but I noted it was the same which your code already detected. So no change.
Then I tried using RTMP and got similar problems although the device would rarely reboot. It seems, at least in RTMP, the problem is due to OutOfMemoryErrors. I tried to increase the heap-size in the manifest (android:largeHeap="true) but no change. The logs are:
04-08 18:36:02.870 9049-9067/com.pedro.rtmpstreamer E/art: Throwing OutOfMemoryError "Failed to allocate a 576012 byte allocation with 509056 free bytes and 497KB until OOM" 04-08 18:36:02.870 9049-9067/com.pedro.rtmpstreamer E/Camera-JNI: Couldn't allocate byte array for JPEG data 04-08 18:36:02.875 9049-10911/com.pedro.rtmpstreamer E/AndroidRuntime: FATAL EXCEPTION: Thread-741                                                                        Process: com.pedro.rtmpstreamer, PID: 9049                                                                        java.lang.NullPointerException: Attempt to get length of null array                                                                            at com.pedro.encoder.utils.YUVUtil.NV21toYUV420SemiPlanar(YUVUtil.java:192)                                                                            at com.pedro.encoder.utils.YUVUtil.NV21toYUV420byColor(YUVUtil.java:157)                                                                            at com.pedro.encoder.video.VideoEncoder$2.run(VideoEncoder.java:228)                                                                            at java.lang.Thread.run(Thread.java:818) 04-08 18:36:02.880 9049-9049/com.pedro.rtmpstreamer I/SrsFlvMuxer: SrsFlvMuxer closed 04-08 18:36:02.897 9049-10913/com.pedro.rtmpstreamer D/RtmpConnection: closeStream(): setting current stream ID to 0 04-08 18:36:02.898 9049-10913/com.pedro.rtmpstreamer D/RtmpConnection: wrote packet: RTMP Command (command: closeStream, transaction ID: 0), size: 24 04-08 18:36:02.902 9049-10457/com.pedro.rtmpstreamer I/SrsFlvMuxer: flv: h264 sps/pps sent, sps=13B, pps=4B 04-08 18:36:02.926 9049-10913/com.pedro.rtmpstreamer D/RtmpConnection: socket closed 04-08 18:36:02.929 9049-10913/com.pedro.rtmpstreamer I/SrsFlvMuxer: worker: disconnect ok. 04-08 18:36:03.057 9049-9049/com.pedro.rtmpstreamer I/MicrophoneManager: Microphone stopped 04-08 18:36:03.075 9049-10457/com.pedro.rtmpstreamer I/Process: Sending signal. PID: 9049 SIG: 9
I really don't know what to make out of it...

Well, today I tested with a Samsung S3 neo running 4.2.2 and it behaved MUCH better. Still had to fiddle with the configuration to find the perfect stream (for phone and server) but the result was good. I actually changed the streaming server and used SRS (Simple-RTMP-Server) which is very nice and easy to set up.
I don't know how to resolve the problems with my Nexus4 which is a pity because you get doubts if I implement your great library in an app and will it work most devices. I need to get hold of more phones. Are you able to tell me on which which devices you have tested it on?

Hi. Thanks for report the result of your test.
At the moment I only could test in nexus 5x, nexus 6P, samsung j5 and bq e5 (working all).
I will try test in more device and reproduce the crash but it could be really difficult to solve

I did a update for outofmemory rtmp crash. I think that it could be caused because your device work so slow and then generate so much buffer in memory and then crash. If it is solved with the update, maybe the reboot in rtsp could be for that reason. Let me know if it work and i will do other update for rtsp

Hi, just saw your msg and update now. Thanks.
I will check this evening when I am back home from work and then let you know.

Managed to do some tests now using RTMP. The Nexus4 is now behaving much better, even with higher values,  although I still get that occasional reboot but more rarely. It might be something with the phone.
I have two questions:

Occasionally I would like to broadcast only audio (no video). In this moment, you have a VideoEnabled-option but if I set it to true, the library will send a black screen and I guess this will still occupy some bandwidth in upload. Is it possible to "switch off" the videoencoder somehow so only audio is sent?
If I use your CustomRTMP app, the orientation will be correct when the phone is in landscape when I watch the stream with VLC on my PC. However, if the phone is in portrait, the video is shown in landscape on VLC. This happens both on my Samsung S3 Neo and my Nexus4. I tried to change the orientation in the sample-app but it has no effect.

I like this library very much and it is very nice clear code - my compliments to your coding!

I tried to add video disable feature stopping encode video but sometimes stream freeze so I send a black screen but with so low bitrate for bandwidth preserve (bitrate change on fly only work for api 19+ so you will send same birate on api 19- with camera disable). Audio disable work similar.

Actually orientation only change stream result (encoder change orientation frame) not preview camera. Remember change orientation before start stream.
Anyway if the problem persist you can set camera to nv21 color format and rotate with YUVUtil class (actually I dont use this method because it could cause a drop frame).

Your DisableVideo (in the TRMPBuilder) resulting in a black screen works just fine to braodcast only Audio. Thank you.
However, I still have not been able to sort out the orientation-problem. I tried what you suggested which I believe is done here:
` @Override
public void onPreviewFrame(byte[] data, Camera camera) {
if (fpsController.fpsIsValid()) {
if (imageFormat == ImageFormat.YV12) {
getCameraData.inputYv12Data(data, width, height);
} else if (imageFormat == ImageFormat.NV21) {
getCameraData.inputNv21Data(data, width, height);
YUVUtil.rotateNV21(data,width,height,90);
}
}
}
but it does not work....
So you are saying that on your devices the orientation is OK? I am wondering if this could be a problem with the SRS-server. I haven't checked with Wowza.`

You are not doing rotation properly with YUVUtil. You should do it:
@Override
public void onPreviewFrame(byte[] data, Camera camera) {
if (fpsController.fpsIsValid()) {
if (imageFormat == ImageFormat.YV12) {
getCameraData.inputYv12Data(data, width, height);
} else if (imageFormat == ImageFormat.NV21) {
getCameraData.inputNv21Data(YUVUtil.rotateNV21(data,width,height,90), width, height);
}
}
}


[SPARK-27486][Core][Test]Enable History server storage information test in the HistoryServerSuite

What changes were proposed in this pull request?
We have disabled a test related to storage in the History server suite after SPARK-13845. But, after SPARK-22050, we can store the information about block updated events to eventLog, if we enable "spark.eventLog.logBlockUpdates.enabled=true".
So, we can enable the test, by adding an eventlog corresponding to the application, which has enabled the configuration, "spark.eventLog.logBlockUpdates.enabled=true"
How was this patch tested?
Existing UTs

Jenkins, test this please

Can one of the admins verify this patch?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9966/
Test PASSed.

Test build #104644 has started for PR 24390 at commit e2e2ac2.

Test build #104644 has finished for PR 24390 at commit e2e2ac2.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
``

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104644/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9967/
Test PASSed.

Test build #104645 has started for PR 24390 at commit e2e2ac2.

Test build #104645 has finished for PR 24390 at commit e2e2ac2.

This patch fails RAT tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
``

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104645/
Test FAILed.

cc @srowen @vanzin Kindly review.
Could you please tell me why is it failing in the RAT test? Does eventLogs require Apache license headers
Could not find Apache license headers in the following files:
 !????? /home/jenkins/workspace/SparkPullRequestBuilder@3/core/src/test/resources/spark-events/local-1555466577611
[error] running /home/jenkins/workspace/SparkPullRequestBuilder@3/dev/check-license ; received return code 1

Jenkins, retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9976/
Test PASSed.

Test build #104655 has started for PR 24390 at commit 872fb11.

Test build #104655 has finished for PR 24390 at commit 872fb11.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104655/
Test FAILed.

Test build #104660 has started for PR 24390 at commit 26fd670.

Jenkins, retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9981/
Test PASSed.

Test build #104661 has started for PR 24390 at commit 5e6c0c8.

Test build #104661 has finished for PR 24390 at commit 5e6c0c8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #104660 has finished for PR 24390 at commit 26fd670.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104661/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104660/
Test PASSed.

cc @srowen @vanzin This PR is just enabling a test case which disabled long back. Kindly request to review

Thanks @srowen

Merged to master

Thanks @srowen @felixcheung


Textures on meshes aren't animated

If a mesh is consumed by the mesh consumer inside emitBlockQuads, any textures that are normally animated will be locked on their first frame. Toggling Sodium's "Animate Only Visible Textures" option doesn't do anything either. This behavior can be observed through mods like ConnectedTexturesMod For Fabric (CTMF) and JSON Model Extensions (JMX).

This is the same issue as #64, but I'll leave both open as this issue explains the problem better. It might be quite tricky to fix, since I don't think the FRAPI pipeline preserves Sprite metadata (might need to do some kind of reverse lookup?).

Aha, SpriteFinder already has what I'm looking for. Might impact chunk building performance a bit, and I think I'll have to cache the Sprite reference in the vertex format for meshes.

Also see https://github.com/CaffeineMC/sodium-fabric/issues/839 for why this still doesn't work (on 1.17) when Animate Only Visible Textures is disabled.

Note that the aforementioned PR has now been merged - so you can work around this issue in Sodium 0.3.2 by disabling Animate Only Visible Textures. Since Sodium 0.4 is investigating direct FRAPI support, I'm probably not going to implement this in Indium.

A few months later and this is still an issue with no sodium with FRAPI support. 0.4 did not come with it.

Unfortunately I have very little time to work on this project, and fixing this issue properly would likely be a significant undertaking, and would be obsoleted when Sodium implements FRAPI/FREX. I'll happily accept a PR fixing the issue, but I don't consider it worth my time to work on myself.


Update readme file for Message Reactions

@Peter-Maguire There's a couple of small changes we made to the READMEs earlier today. Take a look here:
https://github.com/ably-labs/atomic-examples/blob/bdbc95151ddf6bef8938c047c56e0d9f4807fa6a/src/components/AvatarStack/README.md

Looks good, but can we rename the files/folders/components to say "Emoji Reactions" instead of "Message Reactions"? I thought Peter had done that already, but maybe it's not pushed yet. https://ably-real-time.slack.com/archives/C03P7344H1P/p1660060176722079

Yes. The change is on another branch which is currently in review

Can you point me to the branch/PR, please @mohyour ?
I can't find it. Sorry! 🙈

Can you point me to the branch/PR, please @mohyour ? I can't find it. Sorry! 🙈

https://github.com/ably-labs/atomic-examples/pull/18

oh of course! Sorry, I got misled by the title of the PR.


Pagination is not working as expected

Pagination is not working
Tried with below URL.
http://localhost:8080/products?_page=2&_per_page=10
I have set _per_page as 10
By doing this,
_page=1 is working as expected as it returns 10 data from index  1 to 1
likewise, _page=2 should have also returned 10 data but instead returns 90 data from index 11 to 100
_page=3 returns 80 data from index 21 to 100.
_page=4 returns 70 data from index 31 to 100.
Expected Outcome: Every _page=value should return 10 data as _per_page is set to 10.
Thanks
Prem

Are you using the latest version? There was a fix related to pagination

Yeah, the issue has been fixed. Thanks

I'm facing same issue. Can anyone suggest the way to resolve it?

@Bandhan564 update to the latest version!


docker : Unable to find required 'zipinfo' binary in the path. Command "/bin/tar" detected as tar type None. GNU tar required

Using docker like this this give me an error.
docker run --rm -it -v $(pwd):/ansible \
  -v ~/.ssh/id_rsa:/root/.ssh/id_rsa \
  -v $(pwd)/.ansible:/usr/share/ansible \
  willhallonline/ansible:latest \
  sh

I get this error
TASK [prometheus.prometheus.blackbox_exporter : Unpack blackbox_exporter binary] ***********
task path: /usr/share/ansible/collections/ansible_collections/prometheus/prometheus/roles/blackbox_exporter/tasks/install.yml:38
<localhost> ESTABLISH LOCAL CONNECTION FOR USER: root
<localhost> EXEC /bin/sh -c 'echo ~root && sleep 0'
<localhost> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /root/.ansible/tmp `"&& mkdir "` echo /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240 `" && echo ansible-tmp-1716916954.4502718-281-25942118550240="` echo /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240 `" ) && sleep 0'
<localhost> EXEC /bin/sh -c 'test -e /tmp/blackbox_exporter-0.25.0.linux-amd64/blackbox_exporter && sleep 0'
Using module file /usr/lib/python3.11/site-packages/ansible/modules/stat.py
<localhost> PUT /root/.ansible/tmp/ansible-local-205v0s51yqs/tmpnsu9u01i TO /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/AnsiballZ_stat.py
<localhost> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/ /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/AnsiballZ_stat.py && sleep 0'
<localhost> EXEC /bin/sh -c '/usr/bin/python3 /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/AnsiballZ_stat.py && sleep 0'
<localhost> PUT /tmp/blackbox_exporter-0.25.0.linux-amd64.tar.gz TO /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/source
<localhost> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/ /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/source && sleep 0'
Using module file /usr/lib/python3.11/site-packages/ansible/modules/unarchive.py
<localhost> PUT /root/.ansible/tmp/ansible-local-205v0s51yqs/tmp54ci5zep TO /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/AnsiballZ_unarchive.py
<localhost> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/ /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/AnsiballZ_unarchive.py && sleep 0'
<localhost> EXEC /bin/sh -c '/usr/bin/python3 /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/AnsiballZ_unarchive.py && sleep 0'
<localhost> EXEC /bin/sh -c 'rm -f -r /root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/ > /dev/null 2>&1 && sleep 0'
fatal: [nora-staging -> localhost]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "attributes": null,
            "copy": true,
            "creates": "/tmp/blackbox_exporter-0.25.0.linux-amd64/blackbox_exporter",
            "decrypt": true,
            "dest": "/tmp",
            "exclude": [],
            "extra_opts": [],
            "group": null,
            "include": [],
            "io_buffer_size": 65536,
            "keep_newer": false,
            "list_files": false,
            "mode": null,
            "owner": null,
            "remote_src": false,
            "selevel": null,
            "serole": null,
            "setype": null,
            "seuser": null,
            "src": "/root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/source",
            "unsafe_writes": false,
            "validate_certs": true
        }
    },
    "msg": "Failed to find handler for \"/root/.ansible/tmp/ansible-tmp-1716916954.4502718-281-25942118550240/source\". Make sure the required command to extract the file is installed.\nCommand \"/usr/bin/unzip\" could not handle archive: unzip: short read\n\nUnable to find required 'zipinfo' binary in the path.\nCommand \"/bin/tar\" detected as tar type None. GNU tar required."
}

I am not sure that I need to make sure should be present to make it work.  if I do zip -v or tar -v ...it's all present

Hello.
You need to install unzip
Look at the docs for the unarchive module for further info: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/unarchive_module.html#notes

I think it's important to note that those tools also have to be present on the host running Ansible, because the unarchive tasks get delegated to the localhost https://github.com/prometheus-community/ansible/blob/dc94de011ffdb079fbd6d64da0e63d2155dfb284/roles/process_exporter/tasks/install.yml#L40

Hello, ran into this as well with a self baked ansible image derived from alpine.
This doesn't have to do with the lack of unzip and zipinfo - this has to do with the version of tar in the image. It's a busybox variant because your image (willhallonline/ansible:latest) is derived from alpine linux.
You can check the module for unarchive ; it bails out if not GNU tar. You can "apk add tar" as a build step and it should work after then as it will replace the busybox variant default.


Add README and license

Since this is kernel related I've stuck to the same license as the kernel

This project is deprecated, and not maintained. And I don't want to use GPL here.
If I may ask, what are you doing with omapdrm-tests?

I have added MIT License
For stuff related to DRM, I recommend checking out my kmsxx project.


Update compile_from_source.md to mention cuda12x target

Add cuda12x to the list of targets

Same thing. I believe it''s more of a pytorch issue that a bnb issue though. Probably need to wait for pytorch to support cuda12.

+1

Thank you!


When run under MacOS 10.11.3

➜  emulator-modbus node emulator.js
open error: Error: ENOENT: no such file or directory, open '/dev/ttyUSB0'
Modbus() error: Error: ENOENT: no such file or directory, open '/dev/ttyUSB0'
Emulator constructor error: Error: ENOENT: no such file or directory, open '/dev/ttyUSB0'
➜  emulator-modbus

Any suggestions?

I tested the project only in GNU/Linux environment, this written in the readme.md file. Are you sure that the device /dev/ttyUSB0 you have available and this is a serial interface? ENOENT error is "No such file or directory"


does not handle multiple mirrors

I normally use a regular cygwin mirror as well as a cygports mirror. apt-cyg just looks at the first mirror listed as the last mirror, when my configuration in fact has two. This can cause a failure to find packages that are in whatever happens to not be the first mirror.
Please add support for multiple "last mirror"s

+1 because it completely breaks support for cygports, thus rendering it nigh-useless when used with cygports (or local mirrors that may have gone offline).

What status of multiply sources support?
I alter between with:
$ apt-cyg mirror ftp://ftp.cygwinports.org/pub/cygwinports
$ apt-cyg update
$ apt-cyg install php

and:
$ apt-cyg mirror http://mirrors.kernel.org/sources.redhat.com/cygwin/
$ apt-cyg install gcc

It possible to add shell aliases for apt-cyg mirror but it somewhat inconvenient.

@gavenkoa this repo is abandoned:
http://github.com/transcode-open/apt-cyg/blob/master/status.md
If you want to post here I will fix it:
http://github.com/svnpenn/sage

https://github.com/svnpenn/sage/issues/19


Allow array for line opts in dataset

resolves #10176

I tested this out and I'm kind of surprised that it works, though the array only applies to the point colours

Yeah, not sure if we might want to change it for V4 that you only can do it with the pointBackgroundColor etc.
But for V3 it needs to be typed correctly, edited it now so the current opts stay as is, because otherwise some would become invalid. And added the common element ops and hover opts which are the ones that support array format as seperate enties

Thanks guys for the quick turnaround. I was using this feature since I have so many points the line segments are not visible anyway. However what I would really need is to be able to set the line segments colors. I came across #9692 and was wondering if this is what I was looking for. I have yet to try it though.


Query parameters: updating just the query string

If one keeps most of one’s state in the query string (vs. the path), one usually wants to update just the query string, without touching the path. This is how I did it – does that look OK?
// In my custom onClick handler:
this.context.history.pushState({}, document.location.pathname, { someKey: someValue });

// Via a <Link>
<Link to={document.location.pathname} query={{selected: ''}}>Clear selected</Link>

Suggestion – mention here: https://github.com/rackt/history/blob/master/docs/QuerySupport.md

That's more of a React Router question. You'd really want to use context.location over document.location or window.location.
https://github.com/rackt/history/pull/141 will provide a better API, eventually.

It is indeed. My bad, sorry!

Thanks for the tip, wasn’t aware of PropTypes.location!


Fix Panama calendar independence from Spain

refs #

For information, read and make sure you're okay with the CONTRIBUTING document.

[ ] Tests with a significant number of years to be tested for your calendar.
[ ] Docstrings for the Calendar class and specific methods.
[ ] Use the workalendar.registry.iso_register decorator to register your new calendar using ISO codes (optional).
[ ] Calendar country / label added to the README.rst file,
[ ] Changelog amended with a mention like: "Added <country> by @pseudo (#)"

[ ] Tests with a significant number of years to be tested for your calendar.
[ ] Changelog amended with a mention describing your changes.

Thanks a lot for your contribution! A few points, though:

could you please make sure that this date change is/was permanent? was it always at this date, or did it change at a given year (for example: "as of 2018, we're celebrating this holiday at this specific date"); Adding a link or a reference document in the pull-request definition would be great, also.
could you please add a Changelog entry?

The Independence day is always Novembre 28th.
Source: https://www.officeholidays.com/holidays/panama/panama-independence-day

Wikipedia agrees: https://en.wikipedia.org/wiki/Public_holidays_in_Panama (of course, it can be wrong).
Maybe we could find some official document? (I can't read Spanish unfortunately)

http://www.panama-offshore-services.com/blog/fiestas_patrias_panama_celebrates_its_history_all_through_november.htm ?

Hi
This one is from us embassy in Panama the ones with the Panama flag
official holidays in Panama.
https://pa.usembassy.gov/holiday-calendar/
On Tue, Jun 4, 2019, 10:41 AM Rémy HUBSCHER<EMAIL_ADDRESS>wrote:

http://www.panama-offshore-services.com/blog/fiestas_patrias_panama_celebrates_its_history_all_through_november.htm
?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/peopledoc/workalendar/pull/361?email_source=notifications&email_token=AC2GGVK6RLJQW2PT7PCHYN3PY2EL3A5CNFSM4HS5O5SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW47R6Q#issuecomment-498727162,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC2GGVLKXYVAXQXQ63K2BT3PY2EL3ANCNFSM4HS5O5SA
.

This is the official one, but I'm Spanish since it's the official language
:-).
http://gacetas.procuraduria-admon.gob.pa/27772-A_2015.pdf
On Tue, Jun 4, 2019, 11:10 AM Francisco Castañeda<EMAIL_ADDRESS>wrote:

Hi
This one is from us embassy in Panama the ones with the Panama flag
official holidays in Panama.
https://pa.usembassy.gov/holiday-calendar/
On Tue, Jun 4, 2019, 10:41 AM Rémy HUBSCHER<EMAIL_ADDRESS>wrote:

http://www.panama-offshore-services.com/blog/fiestas_patrias_panama_celebrates_its_history_all_through_november.htm
?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/peopledoc/workalendar/pull/361?email_source=notifications&email_token=AC2GGVK6RLJQW2PT7PCHYN3PY2EL3A5CNFSM4HS5O5SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW47R6Q#issuecomment-498727162,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC2GGVLKXYVAXQXQ63K2BT3PY2EL3ANCNFSM4HS5O5SA
.

Ok will do.
On Wed, Jun 5, 2019, 11:40 AM Bruno Bord<EMAIL_ADDRESS>wrote:

@brunobord requested changes on this pull request.
In Changelog.md
https://github.com/peopledoc/workalendar/pull/361#discussion_r290832203:

@@ -4,6 +4,11 @@

Nothing here yet.
+## v5.0.3 (2019-06-05)
please, do not increase the version number yourself. It's the duty of the
maintainer.
You can replace the "Nothing here yet." line by your changelog entry.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/peopledoc/workalendar/pull/361?email_source=notifications&email_token=AC2GGVNABQ5VXFL6NDOTS2LPY7UALA5CNFSM4HS5O5SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2VZORA#pullrequestreview-246126404,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC2GGVPMTZM3W27Q64EOHXDPY7UALANCNFSM4HS5O5SA
.

Done
On Wed, Jun 5, 2019 at 11:40 AM Bruno Bord<EMAIL_ADDRESS>wrote:

@brunobord requested changes on this pull request.
In Changelog.md
https://github.com/peopledoc/workalendar/pull/361#discussion_r290832203:

@@ -4,6 +4,11 @@

Nothing here yet.
+## v5.0.3 (2019-06-05)
please, do not increase the version number yourself. It's the duty of the
maintainer.
You can replace the "Nothing here yet." line by your changelog entry.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/peopledoc/workalendar/pull/361?email_source=notifications&email_token=AC2GGVNABQ5VXFL6NDOTS2LPY7UALA5CNFSM4HS5O5SKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2VZORA#pullrequestreview-246126404,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC2GGVPMTZM3W27Q64EOHXDPY7UALANCNFSM4HS5O5SA
.

--
Eng. Francisco Castañeda
Manager
Montuoso Software Engineering Inc.
<EMAIL_ADDRESS>www.montuoso.com

released and available on PyPI: https://pypi.org/project/workalendar/5.0.3/ ; upgrade away!
thank you very much for your kind contribution, I'm very happy to welcome new contributors.

Thanks to you bruno for all your patience, and allowing me to be part of
this project at least in one line.
On Fri, Jun 7, 2019, 3:20 AM Bruno Bord<EMAIL_ADDRESS>wrote:

released and available on PyPI:
https://pypi.org/project/workalendar/5.0.3/ ; upgrade away!
thank you very much for your kind contribution, I'm very happy to welcome
new contributors.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/peopledoc/workalendar/pull/361?email_source=notifications&email_token=AC2GGVI7PGDKDRDGYBORCJDPZIK4JA5CNFSM4HS5O5SKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXFFQBA#issuecomment-499800068,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC2GGVP3MD273GGKMMW35IDPZIK4JANCNFSM4HS5O5SA
.

A journey of a thousand miles begins with a single step


[Feature] transient dynamic tables

Is this your first time submitting a feature request?

[X] I have read the expectations for open source contributors
[X] I have searched the existing issues, and I could not find an existing issue for this feature
[X] I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature
Could we implement the "transient" table config to dynamic tables? Follows same pattern as for tables.
https://docs.snowflake.com/en/sql-reference/sql/create-dynamic-table
Describe alternatives you've considered
None.
Who will this benefit?
For cases of dynamic tables as output from a data warehouse, it could decrease cost.
Are you interested in contributing this feature?
Possibly
Anything else?
No response

I just realized that transient dynamic tables will make a huge difference in our failsafe storage.

I just realized that transient dynamic tables will make a huge difference in our failsafe storage.

I have noticed the same. This would make a huge difference and is in line with Snowflake's recommendation for dynamic tables with high refresh throughput.

working on this https://github.com/dbt-labs/dbt-snowflake/pull/1210

waiting for approval but https://github.com/dbt-labs/dbt-snowflake/pull/1210 is good to merge

@dataders can I get an approval on https://github.com/dbt-labs/dbt-snowflake/pull/1210

@colin-rogers-dbt please can you approve https://github.com/dbt-labs/dbt-snowflake/pull/1210


Export malloc and free functions in Emscripten builds

This should fix some downstream projects like chiptune2.js.

I'm not sure if this is the way to go. "Some downstream projects" will also require completely different emscripten helper functions such as string conversion functions. Other projects on the other won't need them, so adding all possibly required functions to the exports would bloat the distribution for everyone else who doesn't need the functionality. Generally I woulds recommend every project to compile their own version that includes the functions they need.

Of course, keeping things slim should be a priority here. However, there are a couple of vital functions that I can't see being called from JS safely without some form of malloc, such as openmpt_module_create_from_memory2 (which requires a pointer to the module data inside the Emscripten heap). Nearly every implementation I can find that uses libopenmpt in WASM/JS form relies on a malloc implementation, which is missing in pure JS and the default Emscripten build config, hence this PR existing.

I agree with @sagamusix in that it is not our business to export any random subset of standard C functions that client code might find useful. It is really unclear where to draw the line there.
In this specific case, Emscripten used to default to exporting malloc and free though until version 3.1.31 (see https://github.com/emscripten-core/emscripten/blob/main/ChangeLog.md#3131---012623 and https://github.com/emscripten-core/emscripten/blob/f51ae7f00792bcb9d4af7c8fcb73d305f899ba7a/src/preamble.js#L90.
I really do not know what kind of usage model emscripten envisions here at all. https://emscripten.org/docs/porting/connecting_cpp_and_javascript/Interacting-with-code.html#interacting-with-code-ccall-cwrap appears to suggest that we should export anything that needs to get called from JavaScript, but as the authors of libopenmpt, we have no way of knowing which other standard C (or C++) functions someone might need to call. So, in the end, this maybe boils down to not providing any Emscripten compiled library at all (as this is just not possible as a generic solution), and expect users to build it themselves.
Or, given https://stackoverflow.com/a/33208675, we may look at LINKABLE (see https://github.com/emscripten-core/emscripten/blob/f51ae7f00792bcb9d4af7c8fcb73d305f899ba7a/src/settings.js#L1092) and/or maybe EXPORT_ALL (see https://github.com/emscripten-core/emscripten/blob/f51ae7f00792bcb9d4af7c8fcb73d305f899ba7a/src/settings.js#L993).
I have not yet checked what LINKABLE does in practice. What we would want it to do is export all symbols with __attribute__((visibility("default"))), and not symbols with __attribute__((visibility("hidden"))). If it does that, and Emscripten builds its own musl C library with appropriate symbol visibility  settings (again, I have not checked that yet), this would arguably be a somewhat semantically sane thing to do (it will likely increase the compiled libopenmpt size significantly, though).

So, it looks like LINKABLE causes all kinds of symbols to appear in libopenmpt.js, in particular I have seen OpenAL and OpenGL symbols there which we do not even touch at all. For a WASM build. the resulting libopenmpt.js grows from ~170kB to ~3.5MB, and libopenmpt.wasm from ~1.2MB to ~3.1MB (likely due to missing dead code elimination as documented by Emscripten). So this is not an option.
EXPORT_ALL does not appear to do much at all.
Using MAIN_MODULE has the same/similar effect to LINKABLE because it implies it.
Using SIDE_MODULE (the Emscripten equivalent of a somewhat true shared library) requires client code to build its own MAIN_MODULE, which as far as I can tell requires the same compiler version to work reliably. I do not see that as an option either.

I think for now for 0.7, we should merge this.
But for 0.8 and later, I really think we should completely stop distributing Emscripten binaries. Shared-library-like things are not really distributable for Emscripten. This does not appear to be a use case that Emscripten thinks about.


Menu item "Help->Homepage" goes to wrong address.

See line below.
https://github.com/oslabs-beta/nautilus/blob/aa02238da0c6200191d5f8c0faf49f32bb7c8b84/src/main/menu.ts#L90

Thanks for pointing this out haha. Quick fix on the way.


Corrected the sed -i command in script/package shell script [#554]

Overview
In the training-kit README, a workflow is presented to create a local copy of the files to be served by a web-server. The first step of that workflow is to run script/package, but that step fails ...
This PR fixes two errors in the sed command inside script/package [ see comment by bazzaar in issue #554 ]
I subsequently ran through the corrected workflow on my local version of training-kit, and the web-served files are built and packaged successfully, and then display correctly in Firefox browser using the simple python web server.
Questions
As the sed regex didn't match the text in the _config.yml, perhaps some change had been made to the _config.yml file previously, ... maybe the keywords are no longer as expected in that file? Just a thought ...
hope this helps
bazzaar

Whilst I remember, and following on from the above PR, I think the creation of the kit subdirectory, in step 2 of the aforesaid workflow, isn't needed. Therefore in step 3, it's sufficient to un-tar the archive into test_site. Then the step 4 is to cd to test_site, and run the web server from that directory in step 5.
As it is currently documented, I found that, contrary to the instruction in step 5, I had to cd into test_site/kit, in order for the files to be found by the links in the web browser. See what you think, perhaps I'm mistaken.
hope this helps
bazzaar

@brntbeer I seem to remember you creating the packaging script - would you have time to review this PR? 👀

@bazzaar first off, welcome! thank you for this contribution.
Sorry for the delay in looking into this, I'll take a look now ! 🎉

Brent,
Hi, thanks for reviewing the PR.
Firstly, in the regex :
\s* means zero or more spaces, you could replace it with ‘ *’ if your shell doesn’t recognise \s.
I preferred to anchor the regex on the literal ‘:’ character because it occurs after the keyword on every line in the config file. And just deleted everything after it.
But your change works equally well.
Did you see my comment in the PR about the possible redundant kit subdir?
Regards,
Barry

On 2 Apr 2019, at 09:22, Brent Beer<EMAIL_ADDRESS>wrote:
@brntbeer commented on this pull request.
In script/package:

@@ -4,7 +4,7 @@ set -e

version=$(git rev-parse --short HEAD)
-sed -i '' -e"s/google_tracking_id:./google_tracking_id:/" _config.yml
+sed -i'' -e"s/tracking_id\s:.*/tracking_id:/" _config.yml
You lead me on quite a regex journey @bazzaar! thank you, was so fun to do. you're right that there was a problem with the script
Besides the fact that google_tracking_id doesn't exist here, the change in the sed command was slightly off. i think the \s was throwing it off?
⬇ Suggested change
-sed -i'' -e"s/tracking_id\s*:./tracking_id:/" _config.yml
+sed -i'' -e "s/tracking_id./tracking_id:/" _config.yml
This seems to work for me, give it a try. It now takes everything after tracking_id (which is captured by the .*) and replace that whole match (tracking_id+ everything else) to be just tracking_id:.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Did you see my comment in the PR about the possible redundant kit subdir?

Yep, you're right. I'm taking a look at that but would prefer to address that after this PR is merged if you dont mind. that way we can have these two changes be atomic

🎉 @bazzaar thank you much for this!


[Suggestion] Make a server-side-only version

I'm making a Fabric server and i wanted this mod to be server-side-only so my friends can connect and play on vanilla
Maybe Polymer will be useful for you

I'm not interested in implementing this one, to be quite frankly honest with you. This is my hobby, not a paid job, therefore I'm doing things I see a good reason for. And this one is just not the case - most mods that add new blocks are both client- and server-side, so if somebody tries to make a nice modpack, there will be a lot of mods that players should install on their end too. So I don't really see why Nether Chest should be different. Moving on, I wouldn't even accept a PR that does all the work for me, because I don't wanna see this mod being heavily dependent on some third party "core library"


Fix #17805 Submit button with formaction outside of form tag

Q
A

Is bugfix?
✔

New feature?
❌

Breaks BC?
❌

Tests pass?

Fixed issues
#17805

This does not work correctly, at least the gii generator is broken with this patch.
Still fixing it, but no eta.


ENHO: Unsupported ENHO type WDYCONF

When serializing ENHO object error "Unsupported ENHO type WDYCONF" occurs, as currently WDYCONF is not supported in abapGit

look in database table ENHTOOLS, class CL_WDR_CFG_ENHANCEMENT should be used for handing this type

started this yesterday, see branch: https://github.com/larshp/abapGit/tree/issue542


[OTHER] Wrong link to the license in the readme

What would you like to share?
The README.md file is linking to the license link which is now invalid and leads to a 404 page.
This should be fixed immediately, even if there's a license file separated, it should be properly mentioned.
Steps to contribute

Fork the repository here.
Create a new branch named fix_license_link.
Open the README.md file.
Go to the bottom of the file, and change the license link to LICENSE without anything else.
Commit and push your changes.
Create a pull request to compare your changes.

If you need any help, let us know about it. 🙂
Additional information
This is a good first issue. Please leave it open to first-time contributors and beginners.

Hi.
Fixed with bf43d9b
Thanks for your contribution.


onDidRemovePage is called when deleting a page below.

Steps to reproduce

Clone the RubigoNavigator repository.
Start the example app.
Navigate from S100 to S200 by pressing the button with label "Push S200".
Navigate from S200 to S300 by pressing the button with label "Push S300".
Note the following lines in the debug console:

flutter: Screen stack: s100
flutter: push(s200) called
flutter: Screen stack: s100 => s200
flutter: push(s300) called
flutter: Screen stack: s100 => s200 => s300

Delete S200 from the screen stack by pressing the button with label "Remove S200"
Note the following lines in the debug console:

flutter: remove(s200) called
flutter: Screen stack: s100 => s300
flutter: onDidRemovePage(s300) called by Flutter framework
flutter: and redirected to pop().
flutter: pop() called
flutter: Screen stack: s100
flutter: onDidRemovePage(s300) called by Flutter framework
flutter: but ignored by us.

Expected results
onDidRemovePage should only be called when the top most page is removed by the Flutter Framework, for example when the stack changes because the user presses or uses:

Android BackButton
Android predictive back gesture
iOS swipe back gesture
.....?

onDidRemovePage should not be called when our code removes pages. Why should we be informed, when we remove the page ourselves in code?
Actual results
It looks like that every page that is not in the new set of pages is reported back to the router delegate by calling onDidRemovePage. You might also want to try to navigate from S300 directly to S100 by pressing "PopTo S100".
This will be in the console output.
flutter: Screen stack: s100 => s200 => s300
flutter: popTo(s100) called
flutter: Screen stack: s100
flutter: onDidRemovePage(s300) called by Flutter framework
flutter: but ignored by us.
flutter: onDidRemovePage(s200) called by Flutter framework
flutter: but ignored by us.

Code sample
See steps to reproduce, for a complete sample.
Screenshots or Video

Screenshots / Video demonstration
https://github.com/user-attachments/assets/46d00704-83c6-4030-8d93-8ad0d9bf9167

Logs
Logs
Syncing files to device macOS...
flutter: Screen stack: s100
flutter: push(s200) called
flutter: push(s200) called
flutter: Screen stack: s100 => s200 => s200
flutter: push(s300) called
flutter: Screen stack: s100 => s200 => s200 => s300
flutter: remove(s200) called
flutter: Screen stack: s100 => s200 => s300
flutter: onDidRemovePage(s300) called by Flutter framework
flutter: and redirected to pop().
flutter: pop() called
flutter: Screen stack: s100 => s200
flutter: onDidRemovePage(s300) called by Flutter framework
flutter: but ignored by us.

Flutter Doctor output
Doctor output
➜  rubigo_navigator git:(main) fvm flutter doctor -v
[✓] Flutter (Channel stable, 3.27.1, on macOS 15.1.1 24B91 darwin-x64, locale en-NL)
    • Flutter version 3.27.1 on channel stable at /Users/johannesroest/fvm/versions/3.27.1
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 17025dd882 (26 hours ago), 2024-12-17 03:23:09 +0900
    • Engine revision cb4b5fff73
    • Dart version 3.6.0
    • DevTools version 2.40.2

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/johannesroest/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 16.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 16C5032a
    • CocoaPods version 1.16.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] VS Code (version 1.95.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • iPhone van Sander (mobile) • 00008120-001635020E43A01E • ios            • iOS 18.1.1 22B91
    • macOS (desktop)            • macos                     • darwin-x64     • macOS 15.1.1 24B91 darwin-x64
    • Chrome (web)               • chrome                    • web-javascript • Google Chrome 131.0.6778.140

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Refactors page API #137792

Thanks for the report @jsroest
Per documentation of the said method, it says that:
Called when the [Route](https://api.flutter.dev/flutter/widgets/Route-class.html) associated with the given [Page](https://api.flutter.dev/flutter/widgets/Page-class.html) has been removed from the Navigator.
Does that help in your case ?

Thanks for the report @jsroest Per documentation of the said method, it says that:
Called when the [Route](https://api.flutter.dev/flutter/widgets/Route-class.html) associated with the given [Page](https://api.flutter.dev/flutter/widgets/Page-class.html) has been removed from the Navigator.
Does that help in your case ?

Hi,
No it does not help, unfortunately. It may have been described that way, but that does not work for us.
First of all, the now deprecated onPopPage fired only on a user action, like hardware backbutton on Android, back button in the AppBar, or swipe back gesture on iOS.
The new onDidRemovePage fires on all pages that are removed from the stack, also the ones that are programmatically removed in code. So now I'm not able to tell the difference between a user initiated change or an app initiated change, which complicates things greatly if I have to synchronise the page stack accordingly.
To make things worse, if I remove a page in between, the topmost page is reported in the 'onDidRemovePage' event as removed.
According to me the 'onDidRemovePage' should only fire when the user pops a page, and therefore may and can only contain the top most page that was popped. This is how the old onPopPage works.

Thanks for the update. I do see the same behavior as reported using latest sdk versions.
stable : 3.7.1
master : 3.28.0-1.0.pre.87

Hi @darshankawar This issue is also important for me as I described in the Flutter Forum:
According to this breaking change, the onDidRemovePage property has replaced onPopPage.
Here’s what they do:
onPopPage: Previously, this callback was used to call [Route.didPop] and return whether the pop was successful. It was invoked only for imperative pop actions.
onDidRemovePage: This callback is triggered when the [Route] associated with a [Page] is removed from the Navigator. It handles both imperative (e.g., Navigator.pop) and declarative removals (e.g., state changes).
The breaking change has caused issues for my implementation because I need to differentiate imperative pops from declarative ones to update the internal page state that I manage.

cc @chunhtai


drivers: can: stm32 dual-port support

Concurrent dual-port support.

I was wondering if the support of more than 2 CAN instances is planned to be added anytime soon. If not, why not target only dual-can support to be merged first. It's already better than the current single can support and a large number of supported STM32 boards only have 2 CANs anyway.

@alexanderwachter I have not had much time to deal with this, it seems to work for me. And now I noticed the merge window for 2.6 closes tomorrow. Do you think we can still manage to get this in 2.6 ?

@alexanderwachter can we "resurrect" this , it would be rellay nice to have this upstream and not having to patch my zephyr tree every time.

Oh, sorry. Sure. I somehow forgot about this PR 😅.

Oh, sorry. Sure. I somehow forgot about this PR 😅.

I have been running it on a 2.4 based system for since you made it, so in general it seems to function. It needs a update to build with master (small stuff) and you wanted some improvements. But I have to agree with @rxdu , currently there is no support for dual or triple CAN on any STM controller, with this patch there is just no tripple CAN on some newer controller, that is a big improvement in my eyes. Don't let the perfect be the enemy of the good :-)


fix(bundle): remove inline @github deps

This PR updates the rollup config to not inline @github dependencies in CommonJS. This is due to two problems when packaging:

The node_modules folder when lib is ignored when publishing
The require() statement within _FormattingTools.tsx is not being rewritten to the inlined dependency when enabled

To unblock 35.11, this PR reverts this change back to the existing behavior until we can resolve the two points above.

Following up on this, it seems like it may be due to the workflow publishing using yarn which is not including files in files 🤔
The canary publishes that use changeset work as-intended so the update here may need to be to update the RC workflow to mirror the canary one

This looks good to me!


Hello command

Summary
Added .hello command to bot
Dependencies

[ ] gTTS was used. (Install using pip install gTTS)
[ ] ffmpeg needs to be installed.

pls add the required imports in the requirements.txt


Update ConvTranpose and Dynamic Shape Support

Renames deconvolution -> conv_transpose to be more consistent with the literature

pytorch, tensorflow, and ONNX use this nomenclature
Note: this is not the cross-correlation operator (which is the adjoint of convolution). This is technically a standard convolution operator combined with an upsampling operator rather than a downsampling operator.

Adds unit tests for the padding, strides, dilations, and other op attributes.
Throws on auto_pad attribute since it has not been implemented

Previously it read the attribute and set it but then did nothing with it

Extended for dynamic shapes

Does not support using asymmetric padding (padding_L != padding_R) and output_shape with dynamic shapes.

Some improvement suggestions as TODOs

Testing  Case 1 :
Offload copy was set while generating MXR  but --enable-offload-copy is not passed to the driver while running.
root@9a80dbd7d20d:~/repo/AMDMIGraphX/build(driver_offload)# ./bin/driver compile --model resnet50 --enable-offload-copy --binary --output resnet.mxr
Compiling ...
root@9a80dbd7d20d:~/repo/AMDMIGraphX/build(driver_offload)# ./bin/driver run resnet.mxr
Compiling ...
Reading: resnet.mxr
Compiled MIGraphX program likely has offload_copy set, Try passing `--enable-offload-copy` if program run fails.
Allocating params ...
terminate called after throwing an instance of 'migraphx::version_1::exception'
  what():  /home/umayadav/repo/AMDMIGraphX/src/targets/gpu/hip.cpp:137: register_on_gpu: Gpu register failed: invalid argument
Aborted (core dumped)

Test case 2 :
Offload copy wasn't set while generating MXR but was passed to driver while running
root@9a80dbd7d20d:~/repo/AMDMIGraphX/build(driver_offload)# ./bin/driver compile --model resnet50 --binary --output resnet.mxr
Compiling ...
root@9a80dbd7d20d:~/repo/AMDMIGraphX/build(driver_offload)# ./bin/driver run resnet.mxr --enable-offload-copy
Compiling ...
Reading: resnet.mxr
Compiled MIGraphX program likely compiled without offload_copy set, Try removing `--enable-offload-copy` flag if passed to driver, if program run fails.
Allocating params ...
Memory access fault by GPU node-2 (Agent handle: 0x55abb80) on address 0x2729000. Reason: Page not present or supervisor privilege.
Aborted (core dumped)

Renames deconvolution -> conv_transpose to be more consistent with the literature

OneDNN and TensorRT use deconvolution. I would prefer that term as convolution_transpose is confusing. It seems to imply that weights are flipped(or not flipped depending on how you define convolution).

Note: this is not the cross-correlation operator (which is the adjoint of convolution). This is technically a standard convolution operator combined with an upsampling operator rather than a downsampling operator.

I am confused here. The current convolution operator we have is a cross-correlation, and I thought that so called ConvTranspose is standard convolution(where the weights are flipped).
These terms seems very confusing. If we stick with the math terms, then we should rename the operators as:

convolution -> cross_correlate
deconvolution -> convolution_upsample(which in addition to standard convolution it does upsampling from what you just said).

Also deconvolution is the same as convolution backwards(except the input and output parameters are flipped). MIOpen uses the same kernels, it just flips the direction and parameters:
https://github.com/ROCmSoftwarePlatform/MIOpen/blob/68524a8223a6550115589e2bd671d378d92fe470/src/problem.cpp#L164
https://github.com/ROCmSoftwarePlatform/MIOpen/blob/68524a8223a6550115589e2bd671d378d92fe470/src/solution.cpp#L163
I think a better name would be convolution_backwards or cross_correlation_backwards.

I think a better name would be convolution_backwards or cross_correlation_backwards(if we rename convolution to cross_correlation).

I'm good with the name convolution_backwards or cross_correlation_backwards. Convolution and cross-correlation are equivalent for a learning context so the literature has settled with calling it convolution. To explain the reason why they've called it transposed convolution: if you represent the op as a matrix multiplication vs. the original convolution(+downsampling) op, it looks like a transposed linear operator.

I'm good with the name convolution_backwards or cross_correlation_backwards

convolution_backwards sounds good for now. Renaming convolution to cross_correlation can be done in a different PR.

Convolution and cross-correlation are equivalent for a learning context so the literature has settled with calling it convolution.

But its not the same operation. Ideally a cross(cross(x, a), b) becomes conv(x, cross(a, b)), which is a useful optimization we can do when we want to fuse multiple linear operations together(ie reduce_mean, average_pooling and cross_correlate). But you cant do cross(x, cross(a, b)) because its not the same. Its unfortunate that a real convolution doesn't exist for us to do such transformations.

The reason I dislike deconvolution is that there's already another definition for that: the inverse of a convolution, which is very different from what this op is doing.

Yea that makes sense.

Will separate changes to convolution_backwards's handling of asymmetrical padding to another PR.

Created issue #1868 to track later enhancements

Can you check if MIOpen supports Asym padding for this ?

MIOpen does not look to support asymmetrical padding. Only has one padding value for each dimension.


[Enum Request] "Entry Type" in Tables

Please replace option field "Entry Type" with an extensible enum in the following tables:
Table 379 "Detailed Cust. Ledg. Entry"
Table 380 "Detailed Vendor Ledg. Entry"
Table 383 "Detailed CV Ledg. Entry Buffer"

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


How to use the "FileCopy" in my YAML file for Azure Pipelines?

Azure DevOps Extension you are using
File Utilities Build Tasks
Where are you running it?

Azure DevOps Service (VSTS) - Only YAML editor available

Version of Extension/Task
3.2.2
Expected behaviour and actual behaviour
Extension works as described on  YAML documentation https://github.com/rfennell/AzurePipelines/wiki/File-Copier-Tasks-YAML
But now i'm not able to use it, YAML editor just say String does not match the pattern of "^AzureVmssDeployment@0$" . I guess it is related to : https://github.com/rfennell/AzurePipelines/issues/390
and
https://github.com/BMuuN/vsts-assemblyinfo-task/issues/78
i really don't know if it related to a new DevOps configuration or a specific case of task.json definition.
Steps to reproduce the problem
Just add step to an Azure Pipeline YAML Configuration File

I will need to have a look at this, not sure how fast before I will have time, but it is on the backlog to investigate

Can you give me an example of your YAML.
I would expect the block to be something like
steps:
- task: richardfennellBM.BM-VSTS-FileCopier-Tasks.FileCopyTask.FileCopy@3
  displayName: FileCopy
  inputs:
    sourceFolder: '$(Build.SourcesDirectory)'
    targetFolder: '$(SYSTEM.ARTIFACTSDIRECTORY)'

So a few points

What is your YAML?
If you set a build variable syste.debug=true what logging to do you get?

Perfect! It works!


Issues with auto-scroll on low-width devices

Was developing the tour(MdMenu version) for devices with low screen width (<800px). The tour pop-ups at times go beyond the viewport and the auto-scroll doesn't happen. This kind of breaks the experience. Is there a fix to this?

It should autoscroll to the tourAnchor element and then open the tour step based on the space available in the viewport.  Is the autoscroll not happening at all?  Or is the tour step opening outside of the viewport?
What browser/device is not working for you?


Resolves HELIO-3334

Don't merge yet, checking something....

The PR is fine, it was a data issue.


Mismatched type errors preventing build

I don't know whether this is the appropriate place but I'm having issues when trying to build it as I was following along the Zero to Production book.
It says there are 2 mismatched type errors in the notify (lib)?
expected winapi::ctypes::c_void, found libc::c_void in line 276 of windows.rs
expected winapi::ctypes::c_void, found libc::c_void in line 282 of windows.rs
I uploaded screenshots, maybe it can help.

Use --locked