Finalizers can be called prematurely

Sometimes Go will notice that a gotk3 wrapper object is unreachable and run the finalizer, unrefing the underlying object,  while a call into C is made. I made a demo that can stress this here: https://github.com/hitchfred/gotk3-pixbufloader
I think the answer is to add calls to runtime.KeepAlive() in key spots in gotk3 to make sure that objects aren't unrefed while C functions are called. Uncommenting the runtime.KeepAlive() call in the demo fixes the issue: https://github.com/hitchfred/gotk3-pixbufloader/blob/master/main.go#L45
I've run into this issue on go1.8.3 windows/amd64 and go1.9 linux/amd64
See also: https://golang.org/pkg/runtime/#KeepAlive

I'm investigating this.

@hitchfred, can you explain how to reproduce this?
I'm running you example with 1, 10, 100, 1000, 10000 iterations on a single image and I get no 0 failures.

I'm still getting Gtk assertion errors and occasional nil pixbufs on Windows and FreeBSD with Go 1.8 and 1.9, respectfully:
$ gotk3-pixbufloader.exe -iterations 3000 pix/*
What version of Go are you using? runtime.KeepAlive was added in Go 1.7 I think. The way Go does garbage collection might've changed in newer versions.
This thread might be of interest:
https://groups.google.com/forum/#!topic/golang-nuts/LIWj6Gl--es

It used to be.  Before Go 1.7, we used to keep all arguments alive throughout the function.  It was kind of a hack, mostly to work around the lack of something like runtime.KeepAlive.  Keeping arguments live throughout the function often lead to objects being retained longer than necessary (the opposite problem from what you are observing).
We didn't see a way to solve this problem automatically.  We decided to use the minimal live ranges and provide runtime.KeepAlive so you can extend the live range.  I think the other direction (keeping the longer live ranges and providing a runtime.AssertThisIsDead) wouldn't work.

Thanks. I have been testing on Linux, golang 1.9.1. Also I have been testing loading a single image.
I am testing with the code with runtime.KeepAlive() commented out.
I noticed you are testing with more than one image. Does it change your result (with the KeepAlive commented out)?

I'm curious not only about the number of images but also their size.

I think I understand what happens: loadPixbuf is called on a goroutine which may block during the invocation of loader.GetPixbuf. As 'loader' in unreachable its finalizer is invoked if this makes the GC to run.

I originally bumped into this issue downloading groups of thumbnails. the images aren't that large at all, a few kbytes each at most. But I was loading them in batches of 20-50 at a time in goroutines. I do think loading in batches like that stresses things a bit.  I dont trigger the failure either when I supply just one image to the test program.
the test images:
https://github.com/hitchfred/gotk3-pixbufloader/tree/master/pix

I noticed the gdk package was missing automatic memory management. Could you try to reproduce the issue against 8137f9007e8c1164020fefc272287994b62e86c2?

Ran the test again with your patch and there are no more pixbufloader failures! But I do get high memory usage (6 gigs resident) after some iterations, and it starts to swap.. It didn't climb as high before.

Yes, this is expected. You must release objects by calling 'Unref()' when you don't need them anymore, as you would do when using pure gtk+ APIS. This cant be done automatically because golang does not have a feature like destructors.

Thanks. With the Unref() it's working fine.

Will close since it seems to be fixed


[Web] 'flutter devices' does not list chrome as a device when Flutter is in STABLE channel.

Flutter on the web just support from the master or dev channel

Is there any timeline available for using it in STABLE and BETA channels as well ?

Unfortunately, I don't know, I am also waiting for a release in stable and beta

yeah, wondering why?

I've run into this as well. As the docs say:

As of the 1.9 release, the web version of Flutter is available as a technical preview on the master channel.

...which I missed while reading those docs the first time 😿 maybe that should be written in red.

Thank you @chenfei-io ! @yuvi1947 Please report if that solved your issue.

So I guess we have to just wait for it to be available in stable and beta channels.
I'll use either master or Dev channels for time being.

how to run in firefox and safari with the command line ?


Tonomy network mainnet: research resource model

Acceptance criteria

[ ] Research how the resource model is implemented on antelope change. check differences in the REX, Powerup and staking models and how they were implemented
[ ] Design a resource model and how it could be implanted (with pseudocode) to allow for each account created will have equal access to resources on the network

https://docs.eosnetwork.com/docs/latest/core-concepts/resources
Reference: https://github.com/AntelopeIO/reference-contracts/tree/main/contracts
EOS: https://github.com/eosnetworkfoundation/eos-system-contracts/tree/main/contracts/eosio.system
Telos:
WAX:
https://eos.io/news/eos-powerup-model-explained/
https://medium.com/eosys/eos-inside-the-ultimate-guide-to-eosrex-b9b6d479a8eb
https://topstaking.com/stake-eos/

https://docs.google.com/document/d/1mO33PVx_SwBX9OqXoVEQij_Tr3ypUBVrYnE8QksP8ZA

RAM using Bancor: https://docs.eosnetwork.com/docs/latest/core-concepts/resources/

last sprint: 2
next sprint: 3


documentation / help for running idempodent configs - checksum question

Hi,
is there any help or documentation if I want to achieve idempodent configuration provision of the cli tool?
For example, it detects that my realms are existing and no actions are done,
but it always says it updates my realm clients, roles and users I present in the JSONs.
What is the checksum used for?
For example, the cli tool logs:
2020-03-04 07:40:48.273 DEBUG 178 --- [           main] d.a.k.config.service.RealmImportService  : No need to update realm 'master', import checksum same: '324a31eb1912f70114550e958134e667391266facd618769646d799372bc3e58931d93f020d88e60aed9fd28be65490fb5800d43ae7aee6d0ff993a19b765a61'
Question:
Does the script names have any semantics or processing order?
Would it be possible that script names could have semantics, for example like in flyway (except that you don't store the state anywhere)
So that you could define

Repeatable scripts
Policy (Create if not exists, Update, Create once)
Processing order with number

I am using docker image adorsys/keycloak-config-cli:v0.8.0-7.0.0

Hi!

What is the checksum used for?

The checksum is an hash of the provided json. The config-cli should compare the file hash with the hash run by the last run. If the hash is the same, the realm is not touched as you expect it.
On a quick test I it worked like you expected. I used this config: https://github.com/adorsys/keycloak-config-cli/blob/develop/example-config/moped.json .
If I re-run the config-cli twice I can't see any changes. (no create or changes seen in audit log)

Does the script names have any semantics or processing order?

Yes. See:
https://github.com/adorsys/keycloak-config-cli/blob/667f31dcc7e6ca3370d4b66d195f287dda5fbee1/config-cli/src/main/java/de/adorsys/keycloak/config/service/RealmImportService.java#L143-L159
The order should be the same. But i'm unware of the process order of the keycloak-admin-cli used by this project.

Policy (Create if not exists, Update, Create once)

Yes, if its possible. In some rare condition (like flows) its required to delete and recreate the flow, since this is limited by keycloak.
Example for user:
https://github.com/adorsys/keycloak-config-cli/blob/8ec8f7be3cff44cda8c8a2dacc9baab1aa2e4170/config-cli/src/main/java/de/adorsys/keycloak/config/service/UserImportService.java#L54-L64
Create user if not exists, then update the roles based on the difference between config json and keycloak.
Can you provide a full json to reproduce this issue?

The checksum is an hash of the provided json. The config-cli should compare the file hash with the hash run by the last run. If the hash is the same, the realm is not touched as you expect it.

Where is this hash state stored? I am always running the configurator in a container that is disposed after run in my deployment, from where would I expect it to get the last checksum?
I am sorry if I've misunderstood something or if I am using the tool wrong, but haven't found explicit documentation.
My use case is following:
I am running every now and then (either on purpose, or together with keycloak deployment in docker, or the configurator container is triggered to run for example CI/CD) keycloak-config-cli as part of docker-compose or aws fargate deployment. I am not expecting changes when I run the tool. It's not a problem that it updates some of the items - anyways nothing is changed so it's idempodent in the sense.
Is keycloak-config-cli persisting something that it expects to exist on next run to function correctly?
If keycloak-config-cli is dependant on persisted hash, I wonder if there could be stateless non-persisted hash, for example calculate a hash based on the given JSON fields comparing to the exact same fields retrieved from keycloak.
Unfortunately i can't provide the config because of disclosure reasons. Based on my assumption I am afraid that the problem arises in my usecase, not my JSONs. 🤔

Where is this hash state stored? I am always running the configurator in a container that is disposed after run in my deployment, from where would I expect it to get the last checksum?

This was the reason to write this utility.
The hash is stored in a custom attribute of the realm. The information is stored inside keycloak.

but haven't found explicit documentation.

This project hasn't a good documentation since this project is create in the free time of us. Sorry. :-)
So did you see any logs after

2020-03-04 07:40:48.273 DEBUG 178 --- [ main] d.a.k.config.service.RealmImportService : No need to update realm 'master', import checksum same: '324a31eb1912f70114550e958134e667391266facd618769646d799372bc3e58931d93f020d88e60aed9fd28be65490fb5800d43ae7aee6d0ff993a19b765a61'

If not, your realm isn't touched by this tool.

Where is this hash state stored? I am always running the configurator in a container that is disposed after run in my deployment, from where would I expect it to get the last checksum?

This was the reason to write this utility.

The hash is stored in a custom attribute of the realm. The information is stored inside keycloak.

Okay, I found it when I looked inside keycloak db, realm_attribute table with a composite key per realm.
So It seems my problem is that because I've split the configuration files to multiple JSONs, all realm checksums are updated after each file run, but finally the same checksum of last run is stored in the realm attributes. So all users, clients, realms, roles are updated each run.
Also master realm is updated on every run, even if master realm related data only exists in one JSON, but it receives the same checksum every run:
d.a.k.config.service.RealmImportService  : Updating realm 'master'...
d.a.k.c.service.ClientImportService      : Update client 'security-admin-console' in realm 'master'
d.a.k.config.service.RealmImportService  : Updated import checksum of realm 'master' to '6f7f3ebee3ccb0f0b29c54548250c60296b50e3bffa95efa8f93a0f50d5682747d634aaf5360ee38369daa93c638ba5549015bc9873a13e6bb48621ab624fbaf'

Here's the master_realm.json contents local dev env example (obfuscated)
{
  "id": "master",
  "realm": "master",
  "displayName": "Master",
  "enabled": true,
  "sslRequired": "none",
  "accountTheme": "keycloak",
  "adminTheme": "keycloak",
  "emailTheme": "keycloak",
  "clients": [
    {
      "clientId": "security-admin-console",
      "webOrigins": [
        "*"
      ],
      "redirectUris": [
        "http://localhost/*",
        "http://<IP_ADDRESS>/*",
      ],
      "rootUrl" : "https://something.com",
      "baseUrl" : "https://something.com"
    }
  ]
}

What do you think, would it be possible that realm_attributes could store states per file? This could give similair semantics like flyway / liquibase for doing migrations.
Or, do you suggest that best practice is to have one migration file? I think there was a mention to keep files as small as possible.
By the way, should maybe be on other issue, but I tried to import an IDP configuration, is this supported? The Admin API supports importing of IDP configuration.
example json for IDP I'm trying to use:
{
  "realm": "my-realm",
  "identityProviders": [
    {
      "alias": "myidp",
      "displayName": "My IDP",
...

What do you think, would it be possible that realm_attributes could store states per file? This could give similair semantics like flyway / liquibase for doing migrations.

Would something like
java -jar ./keycloak-config-cli.jar --keycloak.migrationKey="users"

help? Something like file name in combination with import.path would be to complex but feel free to open an own pr...

Or, do you suggest that best practice is to have one migration file? I think there was a mention to keep files as small as possible.

In my project I use one file per realm.

By the way, should maybe be on other issue, but I tried to import an IDP configuration, is this supported?

No restrictions from keycloak-config-cli. But the import REST API lacks sometimes. Some settings needs custom handing.
If there a problem, create a new issue please.

Here's the master_realm.json contents local dev env example (obfuscated)

Still, it works locally using your provided config even will other json files containers other realms...

2020-03-09 00:05:19.227 DEBUG 31 --- [           main] d.a.k.config.service.RealmImportService  : No need to update realm 'master', import checksum same: 'a66c076f63e22399ad8c0f608ccb82ed3f0f352f074a1d05c4a13b82cb0ff5c33c92053f4bb73cdef202a2fcc3d1d14edeaacbc256eb26f20099f083923938c3'

No restrictions from keycloak-config-cli. But the import REST API lacks sometimes. Some settings needs custom handing

Looks like there is no update mechansim.

Looks like there is no update mechansim.

@erkkikeranen Can you try this version? It should include a handling for identity providers.
https://github.com/adorsys/keycloak-config-cli/actions/runs/52260883

That was fast 😊 , will experiment latest on wednesday.

Hi, I can confirm the change is able to update my identity provider config. Thanks!


Add test case for ThreadFactoryBuilder

Code classes that need to develop unit tests:

cn.hippo4j.common.design.builder.ThreadFactoryBuilder

Please refer to the manual for the first contribution: guide
Unit test development refers to the following two examples:

cn.hippo4j.core.executor.DynamicThreadPoolExecutorTest
cn.hippo4j.core.executor.ExtensibleThreadPoolExecutorTest

@magestacks Welcome

sorry,I removed our assignment so careless


Update kubeadm troubleshooting guide

Backport of https://github.com/kubernetes/website/pull/9028 to release-1.11 branch

Closing, since docs release process will update the content from master.


Fix fetching of limit and usage.

It looks like limit and usage are no longer loaded by default on the
home page.
Just let's get them from the usage page instead.

I believe this should address #7

Thanks !


Framerate detection isn't working for 15fps

The video is not synchronized with audio at all.
With default settings video stops at around half the original and sound keeps going. The file size increases and video is simply unusable(in terms of human perception)

Have you tried manually specifying video framerate?

Have you tried manually specifying video framerate?

I just tried manually entering the 29.97 fps of the original and it didn't affect anything

There is no FPS detection RN, but there are some good pull requests regarding this issue.

I made one that has framerate detection.  See:
https://github.com/petermg/jumpcutter/tree/patch-2
Also you can download a Windows executable I complied, along with a drag and drop bat file and ffmpeg:
https://1drv.ms/u/s!AjpZw3nbsfwNgY4jBZTi9G17idUl6Q?e=he72ae


Add plot for SingleR delta median score to the cell type report

The third section of the cell type QC report should summarize the metrics reported for cell type annotation. For SingleR, we will calculate the delta median score - or the difference between each cell's top and median scores. Then, we want to create a plot that summarizes that information with delta score on the y-axis and cell type on the x-axis.
See #276 for any additional notes about layout.

Closed by #432


Improve test suite: remove global tests, increase net safety

So dev is crashing with:
CRASH: Error: bind EADDRINUSE
    at errnoException (net.js:904:11)
    at net.js:1084:30
    at Object.1:1 (cluster.js:594:5)
    at handleResponse (cluster.js:171:41)
    at respond (cluster.js:192:5)
    at handleMessage (cluster.js:202:5)
    at process.emit (events.js:117:20)
    at handleMessage (child_process.js:322:10)
    at child_process.js:396:7
    at process.handleConversion.net.Native.got (child_process.js:91:7)

CRASH: TypeError: Cannot read property 'port' of null
    at Server.<anonymous> (cluster.js:577:30)
    at Server.g (events.js:180:16)
    at Server.emit (events.js:92:17)
    at net.js:1055:10
    at process._tickCallback (node.js:419:13)

CRASH: AssertionError: false == true
    at ChildProcess.<anonymous> (child_process.js:372:7)
    at ChildProcess.emit (events.js:117:20)
    at handleMessage (child_process.js:322:10)
    at Pipe.channel.onread (child_process.js:349:11)

Do you know what's going on here?

Also Travis CI is still pending for what seems to be all pullreqs since this one was accepted, which makes me nervous.

https://github.com/Zarel/Pokemon-Showdown/compare/a379ff5fc485~8...a379ff5fc485
This is very worrisome.

Fixed by https://github.com/Zarel/Pokemon-Showdown/commit/83ffa44e512af89f2fcbb44b1e5761f1905446a4
Regarding Travis CI pending builds, I no longer see that issue.


URL repeated at end of long message

This is fairly prevalent in recent spam, and recently one instance was missed.

I'm concerned about how accurate this would be. It seems like a lot of posts would have the same link twice in 300 characters.

Sorry about the silly errors, PR updated, tests passing.

Merged so that metasmoke etc can collect the stats to tell us how accurate this is. It can always be removed later if it's not doing what we want it to.


Fixed typo: added missing 'to' before verb

you have override  --> you have to override
The typo was under the category 'Known Issues' in Accordions docs

LGTM


Sea v0.21

Critical Changes
Changes

Reverted inputField Visualforce elements to inputText to maintain external template availability.
Fixed bug in JavaScript causing the relationship to institution question from retaining values on previous button click.
Fixed applicant type value so it is retained on previous button click.
Adjusted registrant permission set to allow access to calendar links.
Updated package version.

Issues Closed

Updating to make last package.


MSS problem with PPPoE and IPv6

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I have searched the existing issues and I'm convinced that mine is new.
Describe the bug
I have a WAN connection via PPPoE. IPv4 was working all the time without any problems and I could connect in and out through my server. But with IPv6 I had strange problems. I was able to connect from my server ping6 ipv6.google.com without any problems, but connections to some hosts (e.g. curl -6 https://packages.gitlab.com/install/repositories/gitlab/gitlab-ce/script.deb.sh or ping6 packages.gitlab.com) did not work and went into a timeout. Also in the other direction via ssh to the server I had problems.
I found the following article (Telekom VDSL MTU and MSS Clamping for IPv4 and IPv6 - there is also an English version below) and based on it I set the MSS of my PPPoE interface to 1472 (1432 + 40 , the "40" are automatically subtracted).
So my IPv6 is now working without problems.
Is it possible that the MSS is set correctly to -40 for IPv4, but also to -40 instead of -60 for IPv6 (as mentioned in the article on the website)?
Expected behavior
Automatically set MSS for IPv6 with -60 instead of -40 and maybe an extra MSS field for Ipv6?
Screenshots

Environment
OPNsense 20.7.5 (amd64, OpenSSL).
APU4D4 4 i211AT LAN / AMD GX-412TC CPU
Network Intel® I210-AT

@alex1702 it does seem reasonable to adjust the mss for ipv6 indeed. https://github.com/opnsense/core/commit/d70a1aae03a716508aca9439a7db0f1abbe34957 should fix this.

Isn’t 60 only valid if PPPoE IPv4 connectivity is used? IPv4 + additional IPv6 header on top?

@fichtner let's reopen this and see if we can validate the correct number. The way I interpreted the value was 20 bytes for the IP header(https://en.wikipedia.org/wiki/IPv4#Packet_structure) combined with 20 bytes for the TCP header (https://en.wikipedia.org/wiki/Transmission_Control_Protocol#:~:text=Specifies the size of the,of options in the header.)
Since IPv4 header is of variable size and IPv6's header is fixed 40 (https://en.wikipedia.org/wiki/IPv6_packet), I assumed the 60 bytes was indeed the correct one for IPv6.

@fichtner let's reopen this and see if we can validate the correct number. The way I interpreted the value was 20 bytes for the IP header(https://en.wikipedia.org/wiki/IPv4#Packet_structure) combined with 20 bytes for the TCP header (https://en.wikipedia.org/wiki/Transmission_Control_Protocol#:~:text=Specifies the size of the,of options in the header.)
Since IPv4 header is of variable size and IPv6's header is fixed 40 (https://en.wikipedia.org/wiki/IPv6_packet), I assumed the 60 bytes was indeed the correct one for IPv6.

Exactly, I also read that a little later. But unfortunately I am not that deep into the TCP/IP stack.

@alex1702 Can you share your advanced DHCPv6 settings to be sure?

Is it ok in German or rather in English?

German works for me. 😊 Ok so this means 60 is correct when we force IPv6 over PPPoE link (only) same as how IPv4 works over PPPoE. If we don’t the MSS may be too small, but that’s only a soft issue.

I hade the exact same problem as @alex1702 and setting the MSS to 1472 resolved it.
VDSL via PPPoE and  Use IPv4 connectivity for IPv6 enabled.
Stale IPv6 connections happen when the remote server is blocking ICMPv6.
For me it is not clear if setting the MSS manually should still be required in this scenario or if this was fixed already and tis a regression now. Can someone please clarify?

For me it is not clear if setting the MSS manually should still be required in this scenario or if this was fixed already and this is a regression now. Can someone please clarify?

I have the current OPNsense version 21.1.7 and was able to remove the manual MSS value again.

That's strange, I'm on the same version and it didn't worked automatically.
Can I somehow get the value when it is set automatically?

Presumable with the 22.7.4 release this issue popped up again. Set the MSS to 1472 for now.

The German provider “Telekom” is experiencing a problem in connection with the “Magenta-TV” web client. If 1472 is entered in MSS on the WAN interface (PPPoE), the TV web client works. If the field is left blank, access to the web client (https://web.magentatv.de/) is not possible. Can this behavior be related to the issue described here? opnsense version 23.7.3, IPv6 enabled.

@c-vo yes, see https://telekomhilft.telekom.de/t5/TV/Magenta-TV-Web-funktioniert-an-IPv6-Anschluss-nicht/m-p/5235310#M472246

@NKnusperer okay, of course that explains a lot. Thank you very much!


docs：polished the readme docs

Describe what this PR does / why we need it
Parts of https://github.com/alibaba/spring-cloud-alibaba/issues/2485 works.
Does this pull request fix one issue?
Some examples of spring cloud alibaba sidecar.
Describe how you did it
Describe how to verify it
Special notes for reviews

Please create a same PR to 2.2.x, thanks!

Please create a same PR to 2.2.x, thanks!

Okay, I'll do it.


Following your supabase auth nextjs guide

Hi, I found your guide on your blog but couldn't find a good way to get in touch with you -- https://noahflk.com/blog/supabase-auth-nextjs
I was wondering if you had updated instructions on how to approach this? I followed exactly what you did but my user is always returning null in this section:

I've tried using:  createPagesServerClient and createBrowserClient as well but to no avail. Any suggestions here? Thanks again for such a well written blog post!

I will take some time to update the blog post soon. Did you find a solution in the meantime?
Maybe looking at the updated auth source code in this repository helps: https://github.com/noahflk/railtrack


[ETL-301] Support new schema for GradualOnsetV1 assessment

Added GradualOnsetV1 table to table_columns.yaml
Updated schema_mapping.yaml and crawler_assignments.yaml
Upgraded to archive-map.json v4.5.2 in S3 to JSON job
Update S3 to JSON job to support new archive-map.json format.

Feel free to put some time on my calendar to walk through this PR if you'd like.


Added support for spot lights

Description

Added support in the shaders for spot lights, and added a utility function to add a spot light to the scene graph.
Removed dynamic branching, shaders should now see a speed up in performance
Added pre-compilation of shaders. You can now use #includes to include common code inside your shaders.

Code example:
auto &spot_light = vkb::add_spot_light(*scene, camera_node.get_transform().get_translation(), camera_node.get_transform().get_rotation());
spot_light.set_properties({
	{0.0f, 0.0f, -1.0f},                     // Direction
	{1.0f, 0.95f, 0.7f},                    // Color (yellowish white)
	1.0f,                                        // intensity
	5.0f,                                        // range
	glm::cos(glm::radians(12.5f)), // inner cone angle (required for spot lights)
	glm::cos(glm::radians(15.5f))  // outer cone angle (required for spot lights)
});

General Checklist:
Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
[x] I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
[x] I have used existing framework/helper functions where possible
[x] My changes build and run on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

This has a very noticeable performance degradation on things like the render_passes sample for me (~30% lower fps).
Dynamic switching like this in shaders costly on some architectures, especially when the code won't actually be used most of the time. Some architectures will be using predication rather than branching for example.
Could we not control whether the specific lighting blocks are needed with a specialization constant for example? Wouldn't that be a better 'best practice' in general?
I'm also seeing a compilation error when running render_subpasses:
[error] [framework/core/shader_module.cpp:50] Shader compilation failed for shader "deferred/lighting.frag"
[error] [framework/core/shader_module.cpp:51] ERROR: :69: 'light' : no such field in structure
ERROR: :69: '-' :  wrong operand types: no operation '-' exists that takes a left-hand operand of type ' in highp 3-component vector of float' and a right operand of type 'layout( set=0 binding=4 column_major std140) uniform block{layout( column_major std140) uniform highp uint count, layout( column_major std140) uniform 100-element array of structure{ global highp 4-component vector of float position,  global highp 4-component vector of float color,  global highp 4-component vector of float direction,  global highp 2-component vector of float info} lights}' (or there is no acceptable conversion)
ERROR: :69: '' : compilation terminated
ERROR: 3 compilation errors.  No code generated.

So, the problem in command_buffer_usage is now fixed, thanks.
However, pipeline_barriers, layout_transitions and specialization_constants all fail to run with the following error:
terminate called after throwing an instance of 'fmt::v5::format_error'
  what():  invalid format string
Aborted

Now I get this on specialization_constants:
[error] [framework/core/shader_module.cpp:106] Shader compilation failed for shader "specialization_constants/specialization_constants.frag"
[error] [framework/core/shader_module.cpp:107] ERROR: :50: 'MAX_FORWARD_LIGHT_COUNT' : undeclared identifier

Specialization constants is now fixed, thanks.
However, I'm seeing some serious issues with command_buffer_usage:
I turn on multi-threading and then choose 4 or more secondary command buffers. I start to see some of the objects flickering in and out of existence (or just rendering badly - I'm not sure).  When I keep increasing the secondary buffer count I eventually see a GPU lockup. None of this happens on the master branch.

However, I'm seeing some serious issues with command_buffer_usage:
I turn on multi-threading and then choose 4 or more secondary command buffers. I start to see some of the objects flickering in and out of existence (or just rendering badly - I'm not sure). When I keep increasing the secondary buffer count I eventually see a GPU lockup. None of this happens on the master branch.

I am not seeing these issues myself on Windows, however I believe I have fixed the issue. The lights were being allocated per secondary command buffer - so I've moved the allocation to be done per draw and then they are bound (like we've done before). But the specialization constants that you requested are now fed in per bind.


feat(sdk): Improved authorization request error handling

Codecov Report
Patch coverage: 60.29% and project coverage change: -2.58% :warning:

Comparison is base (78e3801) 89.78% compared to head (80c5b00) 87.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   89.78%   87.20%   -2.58%
==========================================
  Files          93       93
  Lines        3690     3690
==========================================
- Hits         3313     3218      -95
- Misses        247      346      +99
+ Partials      130      126       -4

Files Changed
Coverage Δ

cmd/wallet-sdk-gomobile/openid4vp/interaction.go
15.00% <16.66%> (-65.25%)
:arrow_down:

pkg/openid4vp/openid4vp.go
89.94% <76.00%> (-3.54%)
:arrow_down:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: deprecate python 3.7 #2

previous deprecation of 3.7 did not have actual check (https://github.com/replicate/cog/pull/1550)
now the model python minimum version is checked in cog build only
this new approach is compatible with existing already built and/or uploaded models
fixed integration test

to stop people from pushing 3.7 models using old cogs

I do not think it is good idea to do it now. better to leave old cog fallback for now in case user is stuck with 3.7 and need time to port.

Replicate injects newer cog versions into old images by calling pip install cog==0.9.4. Since we no longer test new cog releases on 3.7, we should stop doing this for python3.7 images (or they will stop working).
@technillogue Should we create a 0.9.x branch that we can make releases out of if we ever want do to cog updates that apply to already existing py3.7 images?

we should just keep the 3.7 tests then


dom.getAttributes return value

Hello
I've just come across this project and it's been very helpful thus far.  Just a question regarding the getAttributes(String nodeId) method on the dom though - is there a specific reason it returns a list of strings, which are, alternately, attribute names and then their values?

I ask because there are two ways to access attributes that would help using the API:

Map<String, String> getAttributes(String nodeId);
String getAttribute(String nodeId, String attributeName);

oh i see
it comes from chrome devtools itself like that:
https://chromedevtools.github.io/devtools-protocol/tot/DOM
i guess i will close this.


Module 1 Exercise 2 [NARTEY ERIC]

Please "drag & drop" exercise 2 file below.

Please UPDATE THE TITLE of this "Issue" in the title bar above with your name.
Exercise.docx

Nice observations on the graphs!


chore(changelog): Add changelog entries for 3.2.4 and 2.12.6

What this PR does / why we need it:

Add change log entries for 3.2.4 and 2.12.6.
Which issue this PR fixes:

Special notes for your reviewer:

PR Readiness Checklist:
Complete these before marking the PR as ready to review:

[x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Let's make sure we update these versions in the docs:

https://github.com/Kong/docs.konghq.com/blob/224265b60f7f733132ae64fe19d8282c70c1767b/app/_data/kong_versions.yml#L305-L308
https://github.com/Kong/docs.konghq.com/blob/224265b60f7f733132ae64fe19d8282c70c1767b/app/_data/kong_versions.yml#L295-L298

These seems a bit outdated.


Update magic numbers for  5.0.0

Reference: https://github.com/ocaml/ocaml/commit/293014ba1b6eeda76b3016f499815d25c8f6bfca

Thank you for getting merlin and ocaml-lsp working on 5.0.0! It has made local dev experience really pleasant. I noticed that the ocaml trunk has changed the magic versions and that caused merlin (and ocaml-lsp) to fail with an error about compiler versions. I tested the diff in this PR and merlin and ocaml-lsp seem to work well on a 5.0.0 switch again.

Ah, didn't see this. Thanks @anuragsoni !


Array methods splice / push do not work in watch method of subcomponent

Version
3.2.31
Reproduction link
sfc.vuejs.org/
Steps to reproduce
click the four buttons to test.
CDN version:
let vContent = {
name: "v-content",
template:
{{cnt}}
,
props: ["list"],
data() {
return {
cnt: -1,
};
},
watch: {
list(val) {
if (Array.isArray(val)) {
this.cnt = this.list.length;
}
},
},
};
window.app = Vue.createApp({
components: {
"v-content": vContent,
},
template:
<v-content :list="list"></v-content>
 <button @click="clear1">clear1</button><button @click="clear2">clear2</button><button @click="push">push</button><button @click="change">change</button>,
data() {
return {
list: [],
};
},
methods: {
clear1() {
this.list.splice(0); // not work
},
clear2() {
this.list = []; // work
},
push() {
this.list.push(1); // not work
},
change() {
this.list = [1, 2]; // work
},
},
}).mount("#app");
What is expected?
The value of cnt should reflect the changes of the four buttons
What is actually happening?
Only clear2 and change worked.

you should add deep: true.


Update poetry.lock

@mark-at-pieces

I think we should ignore the poetry.lock (add it to the gitignore)
and we add the the command poetry lock in the release.yml

mark that bool used to check whether we create a pickle(pkl) file (the models.pkl which I store the currently using model) or not
we won't create a pickle file if

models_file.is_file() means if the models.pkl is a file (exists)
if the file exists but the uuid of the model is invalid

 try: # Checks if the current model is valid
                get_current_model_name()
                create_pickle = False
except:
                pass

this right here means if you did not catch any errors while getting the name of the mode l(which uses the uuid that stored in the pkl file) don't create a pickle file

mark that bool used to check whether we create a pickle(pkl) file (the models.pkl which I store the currently using model) or not we won't create a pickle file if

models_file.is_file() means if the models.pkl is a file (exists)
if the file exists but the uuid of the model is invalid

 try: # Checks if the current model is valid
      get_current_model_name()
      create_pickle = False
except:
      pass

this right here means if you did not catch any errors while getting the name of the model (which uses the uuid that stored in the pkl file) set the create_pickle to false (don't create a pickle file) @mark-at-pieces

Thanks for the explanation here this is really useful! Lets still rename this boolean to be a bit more readable.


Titlebar will revert to black on Youtube even though I set a custom Color for Youtube

So, I set a custom Color for YouTube and Fallback in Settings, but when I'm using a YouTube Ambilight extension, the title bar reverts to black, i.e. It still tries to theme the site even though I set a custom color for YouTube

@Pizzateik Thanks for reporting the bug! The “specify a colour” function not working is now a known issue, and the whole settings page will receive a revamp in the next version. I’m sorry for the inconvenience!

Oh, no worries, and thanks for addressing it so fast :)

Hi, @Pizzateik! A new update (v2.2) is awaiting review from Mozilla, and will be out in a few days. With the update, this issue should have been addressed. If the issue persists, feel free to reopen the issue!


Creative Thinking requires other regex

In the roster, the creative thinking round header is of a different format and thus requires a different regex. Just putting this here so I remember what I did.

@thewindsofwinter can I close this?

Go ahead, I just put it here to remind me in case I do something dumb. I'm closing.


Wrong latest post in blog section

I found an issue in the blog section regarding latest post. Apparently it shows the first post written as the latest post.
I guess the problem is in layouts/blog/list.html layout:
{{ range first 1 (where .Data.Pages.ByPublishDate .Reverse "Section" "blog") }}
should be instead of
{{ range first 1 (where .Data.Pages.ByPublishDate "Section" "blog") }}

There seems to be a change between Hugo versions 0.25 and 0.31. I was not able to reproduce this issue in Hugo v0.25 (the latest post shown was correct). I was able to reproduce it in v0.31 (the latest post was the oldest post).
Since I've updated the theme to support v0.30 as the minimum Hugo version, I'll implement this change.


New commandNeeds options

The new options'll be: SpecificAuthor, SpecificGuild, SpecificChannel and not confirmed SpecificRole.
Not-Confirmed Documentation

Option Name
SpecificAuthor
SpecificGuild
SpecificChannel
SpecificRole

Value must be
String or Array[String]
String or Array[String]
String or Array[String]
String or Array[String]

Default Value
false
false
false
false

Expected String(en_us)
"Only (a user / Users) with (this / those) ID can use that command: ( / )"
"That command can only be used in (a Guild / in Guilds) with (the follow ID / those IDs): ( / )"
"That command can only be used in (a Channel / in Channels) with (the follow ID / those IDs): ( / )"
"That command can only by users with (the follow role ID/ those roles IDs): ()

System is done, here's the status:
Confirmed Documentation

Options Name
specificAuthor
specificGuild
specificChannel
specificRole

Value must be
String"ID" or Array[String"ID"]
String"ID" or Array[String"ID"]
String"ID" or Array[String"ID"]
String"ID" or String"RoleName"

Default value
false
false
false
false

Here's the returned Strings(en_us):
			"specificNeeds": {
				"specificAuthor": {
					"pluralReturn": "Only users with those IDs can use that command:",
					"defaultReturn": "Only a user with the follow id can use that command:"
				},
				"specificGuild": {
					"pluralReturn": "You can execute this command only in one of Guilds of those IDs:",
					"defaultReturn": "You can execute this command only on the Guild with the follow ID:"
				},
				"specificChannel": {
					"pluralReturn": "You can only execute this command on channels with those IDs:",
					"defaultReturn": "You can only execute this command in a channel with the follow ID:"
				},
				"specificRole": {
					"defaultReturn": "Only a member with a role with the follow ID can use this command:",
					"nameReturn": "You need a role with the follow name to use that command:"
				}
			}

Example of usage:
local_storage/command_needs.json
{
	"help": {
		"options": {
			"specificRole": "564476489979002931",
			"specificAuthor": "134292889177030657",
			"specificRole": "zero",
			"specificChannel": "490329576300609538",
			"specificGuild": "490329576300609536"
		}
	}
}

System will be launched and closes as soon as #10 gets confirmed.

~Actually, the default value is undefined~


Update ingress manifest in control-plane chart to use networking.k8s.io/v1 version

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

Ingress manifest in the control-plane chart has been migrated to `networking.k8s.io/v1` API version

👍
/lgtm

👍
/approve


Test generator, step 1

This is the first step towards #631

[x] Integrate POC test generator into new directory contribution/generator, so it is not installed in CI
[x] Add a parameter to choose the exercise by slug
[x] Use local configlet cached problem specification repository as information source
[x] Write to already created /exercises/practice/${slug}/{PascalCaseSlug}.php
[x] Have test class skeleton
[x] Have testdox with description
[x] Have UUID in DocBlock
[x] Have all tests marked incomplete
[x] Adjust track README to show usage

There are still many TODOs marked in the code, especially making things more failsafe. But it can currently be used with most missing practice exercise, as far as have looked into.

Note that for a CLI Application it is not necessary to boot a full symfony framework: https://symfony.com/doc/current/components/console/single_command_tool.html
php-representer is a single command application: https://github.com/exercism/php-representer/blob/main/main.php and https://github.com/exercism/php-representer/blob/main/src/Application.php

Note that for a CLI Application it is not necessary to boot a full symfony framework: https://symfony.com/doc/current/components/console/single_command_tool.html
php-representer is a single command application: https://github.com/exercism/php-representer/blob/main/main.php and https://github.com/exercism/php-representer/blob/main/src/Application.php

Thanks for mentioning that. I am currently not sure if I want to make it a single command app or add some "update" command to ease syncing against problem specs. So I left it as is. I currently focus on functionality, to get experience with the approach.

I think this is a good start. I do not really know the goal of this Pull Request.
Is it to provide a fully working implementation for some existing exercises ? Is it to just provide the basis for the generator and iterate on it later ?

The goal is to have a next stept from POC to MVP. So we can discuss on direction and possible alternatives. And also to have something to experiment with and help with adding further exercises.


[REQ] auto detect runtime for an inference container

What kind of request is this?
Improvement of existing experience
What is your request or suggestion?
https://github.com/mudler/LocalAI/issues/1888
Are you willing to submit PRs to contribute to this feature request?

[ ] Yes, I am willing to implement it.

docker already has this functionality built-in with platforms (such as linux/amd64/v2, linux/amd64/v3, etc)

fixed with #225


Language Selection on Registration Form

I found out that i cant select any language when im in the registration form page. There wasnt any kind of input selection on that section of the page when i start the code on chrome using visual studio code.

@LimJinEn I did not find this issue on the website.
Maybe somethings wrong when we open it on the local host.
Try to fix it if you can.

when i hover near it , the mouse icon change, showing it that it can be click, but nothing appear when i click it.
I dont know how to fix it

Fine thanks for notifying I will look into this.
If you want to work on this project you can take any Up-For-Grab issues.


Bad state call when navigating to 'Terms' screen

Description of problem
There is a bad state call in the Terms screen that causes a warning log to pop up
I
Expected behavior
There should be no warning log
Steps to reproduce
Navigate to the settings menu and then select 'Terms of use' for the first time
Screenshots and/or log output

Environment

[x] Occurs on Android
[x] Occurs on iOS

Build #: 972
Android Device Model: Pixel 4
iOS Device Model: iPhone 13
Workaround
N/A
Severity

[ ] High
[ ] Medium
[x] Low

Confirmed fixed in latest main.


Odd wording in Sentence case section in Stripe Review Requirements

Your Problem
There is odd wording in the last sentence in the Do column of the "Sentence case" section of the review guidelines.
Here is the sentence:
Example: Add bank account For example: “Create subscription”
I think it would be much easier to read if it were changed to this:
For example: “Add bank account ”
Existing Documentation URLs (If applicable)
https://stripe.com/docs/stripe-apps/review-requirements

I agree this doesn't make much sense to me either. Let's see if @katb-stripe can come up with something a bit clearer.


Support providedRuntime dependencies for jetty-env.xml

Currently dependencies to be used in a jetty-env.xml file have to be defined specifically as dependencies for the gretty configuration.
providedRuntime should also be supported for these dependencies. This would be consistent with user expectations from other plugins and for anyone migrating from maven.

Can you provide a simple example project, demonstrating concretely, what is the problem?
Best of all with README, describing expected and actual behavior.


Add new ERC20 Tokens

[ ] Holo (HOT)
contract address: 0x6c6EE5e31d828De241282B9606C8e98Ea48526E2

[ ] Cypto.com chain (CRO)
contract address: 0xA0b73E1Ff0B80914AB6fe0444E65848C4C34450b

[ ] IOST
contract address: 0xFA1a856Cfa3409CFa145Fa4e20Eb270dF3EB21ab

[ ] Loopring (LRC)
contract address: 0xEF68e7C694F40c8202821eDF525dE3782458639f

[ ] aelf (ELF)
contract address: 0xbf2179859fc6D5BEE9Bf9158632Dc51678a4100e

[ ] orbs (ORBS)
contract address: 0xff56Cc6b1E6dEd347aA0B7676C85AB0B3D08B0FA

[x] @TalgatNurdinov please attach icon for this coin

erc20icons.andr.26.04.zip


Parameter ignoreMissingMigrations not recognized

What version of Flyway are you using?
4.0.3
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Command line
What database are you using (type & version)?
(Oracle 11.2)
What operating system are you using?
Windows 7
What did you do?
(Please include the content causing the issue, any relevant configuration settings, and the command you ran)
Ran command
$ flyway validate -ignoreMissingMigrations=false

What did you expect to see?
Expected not to see the
WARNING: Unknown configuration property: flyway.ignoreMissingMigrations
line
What did you see instead?
Flyway 4.0.3 by Boxfuse

WARNING: Unknown configuration property: flyway.ignoreMissingMigrations
Database: jdbc:oracle:thin:@(DESCRIPTION =(ADDRESS = (PROTOCOL = TCP)(HOST = 10.xxx.xxx.xxx)(PORT = 1521))(CONNECT_DATA =(SERVICE_NAME = XXX))) (Oracle 11.2)
ERROR: Validate failed: Detected resolved migration not applied to database: <IP_ADDRESS>.02

Not sure where to put this note: I don't have this issue with -ignoreMissingMigrations.

You need Flyway 4.1.0 for this. Upgrade and everything should work as expected.

That was it. I didn't notice the new version. Thanks.


Debian vmcontext script

Author Name: Rolandas Naujikas (Rolandas Naujikas)
Original Redmine Issue: 2335, https://dev.opennebula.org/issues/2335
Original Date: 2013-09-25
Original Assignee: Javi Fontan

Debian one-context package of version 4.2.1 couse many problems.
It starts too late, because of "Required-Start: $all".
On shutdown it is reexecuted because of "Default-Stop: 0 1 6" and "update-rc.d vmcontext defaults 9 99".
The previous version (4.0.1) was without such problems at least (with other problems also).

Original Redmine Comment
Author Name: Javi Fontan (Javi Fontan)
Original Date: 2013-11-19T14:17:40Z

The scripts are changed so they are only run when it's called with "start". There's still the problem of when the scripts are called.
When these packages were firstly created I thought that it was better to let all the services start and then do the changes but I am probably incorrect. Do you have an idea where it should be started? I want the packages to behave as close as possible in all the distros.
We are going to move these packages to an external repo in a near future so it's easier to contribute to them.

Original Redmine Comment
Author Name: Rolandas Naujikas (Rolandas Naujikas)
Original Date: 2013-11-21T06:37:26Z

My working setup is:
http://grid5.mif.vu.lt/mif/debian6/debootstrap.sh
http://grid5.mif.vu.lt/mif/debian7/debootstrap.sh
http://grid5.mif.vu.lt/mif/ubuntu1204/debootstrap.sh
http://grid5.mif.vu.lt/mif/centos5/bootstrap.sh
http://grid5.mif.vu.lt/mif/centos6/bootstrap.sh
Main idea is to let run vmcontext as early as possible before networking.
That allows to reuse the same image for different VM without temporary IP conflicts.

Original Redmine Comment
Author Name: Rolandas Naujikas (Rolandas Naujikas)
Original Date: 2013-11-22T10:45:08Z

My experience is that on different Linux distributions networking is started in different ways. For e.g. Debian/Ubuntu starts it in single user mode, when CentOS - in multi user mode.
At least my config works for Debian by using "# X-Start-Before: networking" and "# Default-Start: S". For Ubuntu I use upstart task http://grid5.mif.vu.lt/mif/ubuntu1204/vmcontext.conf - not ideal, but working for the moment - I didn't find reliable way to create upstart task with condition to start before network devices are configured (we can look into cloud-init for that).
Additionally I implement EC2_USER_DATA - I put it into /etc/rc.local or configure to run from /etc/rc.local, but even here we have to be careful - because network could not be yet up really.

Original Redmine Comment
Author Name: Javi Fontan (Javi Fontan)
Original Date: 2013-11-22T10:18:09Z

One of the things that the context packages do is to delete the network configuration so in the next boot it does not get configured. With this there should be no problem with a VM getting a temporary IP before being configured by context.
Do you have a list of services that should be up before vmcontext?

Fixed by OpenNebula/addon-contex-linux


IHD_get_crate_name log statement is worthless and only outputs [object object]

Yes this is an easy fix no I don't have the code opened up rn

Fixed in 0.7.1


Azure AD SAML Auth & MFA Support

Looks great, the one limiting factor I'm seeing across all OpenVPN servers is SAML / Azure AD Auth with MFA at both an administration level and a VPN level.
Otherwise, this looks really good and promising.

If I'm understanding correctly, these were released in 0.4.0.
Feel free to reopen this discussion if not. Thanks!


Support for Enum-Encoding as in H2o

Hello,
the H2o ML Framework supports an enum-encoding scheme. It would be nice to have this for sklearn as well. As far as I know there are no contributions made to add this for sklearn models.
Anyone has thoughts about this?

Do you know of a paper or reference from enum encoding? A quick read of H2O docs has me thinking it may be the same as either one-hot encoding or baseN encoding with base 1.

Hi,
I don't know any suitable reference/paper for this. But LightGBM has implemented this as well and there is a gitHub Issue where they talk about finding the optimal split for this kind of categorical encoding. Linkg

I guess this feature is already implemented in ordinal encoding.
Below is from H2O:
Enum is for a categorical column whose values have no ordinal mean. For example you could have a column like eye color: brown, green, blue. You would use enum encoding here because brown eyes are not necessarily greater than green eyes, they are just different.
Label encoding assumes some sort of ordinal nature in your categorical columns. For example you might have a column like credit: good, bad, terrible. Here there is an inherent order (i.e. good is better than bad) so you would want to encode this categorical with label encoding so that the encoding considers some sense of order.

I think @Chandrak1907 is right. Nevertheless, H2O has at least two potentially nice optional parameters:

enum_limited or EnumLimited: Automatically reduce categorical levels to the most prevalent ones during Aggregator training and only keep the T most frequent levels.

sort_by_response or SortByResponse: Reorders the levels by the mean response (for example, the level with lowest response -> 0, the level with second-lowest response -> 1, etc.). This is useful in GBM/DRF, for example, when you have more levels than nbins_cats, and where the top level splits now have a chance at separating the data with a split. Note that this requires a specified response column.

Both of them can be relatively easily added into OrdinalEncoder. If someone wants to write a PR, please, go ahead.


Delete an unused rush sub-command

Why
Every subcommand listed by rush --help adds cognitive load.
rush install:stable is neither used by scripts, nor necessary for devs. Devs always use rush switch-flavor:stable instead.

I use this sometimes, but I am good to remove it
I usually open 2 codespaces, one for beta, one for stable, and I never do those switch(at lease not much), so everytime when I pull something, I run 'rush install:stable'

It is preferred to run rush update (and rush update:stable) locally. rush install is best used in CI, where we explicitly don't want to update the lock file.

Welcome back @JamesBurnside


How to install Watchman on windows!

I have installed the plugin, reload the application and then headed over to my schema.graphql
So this is what thus plugin should do!

syntax highlighting (type, query, mutation, interface, union, enum, scalar, fragments)
autocomplete suggestions
validation against schema
snippets (interface, type, input, enum, union)
hover support
go to definition support (input, enum, type)

It does none of those things for me
I'm also getting this error

Question how do I install Watchman on my windows machine, I looked at facebook guide and it's little bit advanced.

I think you mixed up GraphQL extensions. I think you are trying to use this one. AFAIK vscode-graphql by Prisma does not require watchman 😃
(Btw. To install watchman - just download the zip, extract it somewhere - i.e to C:\Users\USERNAME\AppData\Local\ & add to your PATH)

Installing watchman C:\Users\USERNAME\AppData\Local\ & add to your PATH)
What do mean add to your PATH? I actually navigated to that PATH put the watchman.exe file their and it still didn't work.

@guledali  I'm really sorry for late reply.

What do mean add to your PATH?

I just meant that you need make sure watchman localisation is on PATH environmental variable for your system/ user
Straight from watchman docs:

Extract the zip file and make sure that watchman.exe is located in a directory that is in your PATH.

Quick instructions for imo the quickest way to do it:

So you put watchman directory in C:\Users\USERNAME\AppData\Local\ (so watchman.exe is in C:\Users\USERNAME\AppData\Local\watchman\watchman.exe)
Open PowerShell as Administrator
Add directory to PATH env variable by using setx path "%path%;C:\Users\USERNAME\AppData\Local\watchman"
You can check that it was added: $ENV:PATH
And that watchman is found: watchman -v

Voilà!

Quick instructions for imo the quickest way to do it:
1. So you put watchman directory in `C:\Users\USERNAME\AppData\Local\` (so `watchman.exe` is in `C:\Users\USERNAME\AppData\Local\watchman\watchman.exe`)

2. Open PowerShell as Administrator

3. Add directory to PATH env variable by using `setx path "%path%;C:\Users\USERNAME\AppData\Local\watchman"`

4. You can check that it was added: `$ENV:PATH`

5. And that watchman is found: `watchman -v`

Voilà!

@vadistic Your instructions worked, but also replaced all the custom directories that were in the User Path variable with the system Path directories. As a result, I started to have issues while installing or reinstalling node modules with npm (like when installing a module, it would finish successfully, but node couldn't find it later).
I needed to restore my computer to a point before I did everything you said in order to fix the issue.
I'm pretty sure it wasn't your intention, but be more careful with what you suggest to people. There's always going to be people that follow instructions or tutorials without first verifying what it truly does (as me, in this case).

watchman is no longer required for the language server, and thus for this extension!
enjoy windows users! if you have any other issues with paths/etc, please open a new ticket!


COFF (.obj) support

If we support Linux object files (.o) along with ELF, we should also support Windows object files (.obj) along with PE.

I would be thrilled to see this be supported.

I would be thrilled to see this be supported.

We're in the process of open sourcing our lifters. If you're interested in potentially filing a PR to add support (I haven't looked into how much work it is, but it might not be much), I can prioritize that process higher.

We're in the process of open sourcing our lifters. If you're interested in potentially filing a PR to add support (I haven't looked into how much work it is, but it might not be much), I can prioritize that process higher.

Yeah I would be interested in doing so in the near future, could you please send me the contributor agreement?

Yeah I would be interested in doing so in the near future, could you please send me the contributor agreement?

It's the same one if you've ever pushed to this repo: You can see it here: https://gist.github.com/psifertex/a207c2e070f4e342554dc011e920b341
Once you submit a PR to the repo, the bot will ask you to sign it if you haven't already, but I think it even tracks if you've already signed it on a sister-repo and will remember it though I might be mis-remembering.

It's the same one if you've ever pushed to this repo: You can see it here: https://gist.github.com/psifertex/a207c2e070f4e342554dc011e920b341
Once you submit a PR to the repo, the bot will ask you to sign it if you haven't already, but I think it even tracks if you've already signed it on a sister-repo and will remember it though I might be mis-remembering.

since .lib files are archives of .obj files, going to track them over on #2085

MVP complete -- still needs to parse symbol and debug information sections to get type signatures for functions, but that's a separate enhancement


Refactor/Scheduler Framework

close #56
Major change.

@L-M-Sherlock @ishiko732
Before I start reviewing this PR, I have an important question: Are we okay with introducing major breaking changes this often?
V2 was released in April and V3 was released three weeks ago and now we're already discussing a V4. On top of that, the last couple of weeks, I've been working on a list of changes/improvements I'd like to potentially implement into this library which could result in more breaking changes in the future (V5, V6, V7, etc).
Granted, we likely don't have many users who are currently relying on this library and this is evidenced in part by how infrequently we see new issues being created by other people. So introducing frequent breaking changes won't negatively impact that many people.
I see two possibilities going forward:

We continue to regularly introduce major changes.
We spend some time now planning the future development of this project so that we won't have to introduce as many breaking major changes.

Pros for 1:

We iterate faster
More flexibility
Learn faster

Cons for 1:

Library is significanly harder for our users
Project is harder to maintain

--
Pros for 2:

Library is easier for our users
Project is easier to maintain

Cons for 2:

We iterate slower
This ultimately won't immunize us from more breaking changes in the future, but it would hopefully reduce their number

If we decide on 1, I can start reviewing the PR this weekend.
And if we decide on 2, I can start working on a draft detailing what we might want our API to look like in the future and some of the other changes we'd like to see for this project going forward (including the changes here).
As for my opinion on what we should do... normally, if we were building an application (rather than I library), I'd recommend we do 1, but because we're building a library that other developers build on, I think I'm gonna vote for 2.
Let me know what y'al think

Major breaking changes are common when the lib in its early stage. So it's OK, especially the breaking changes have been implemented in ts-fsrs and go-fsrs.
Planning is great. I support to plan the development and create something like roadmap. I have added TODO in the issue before I work on this PR.

@L-M-Sherlock
Alrighty, I'll start taking a look at this PR then. I'll probably also send you a rough outline in the next couple of weeks of some of the changes I'd like to make to this library in the future.

@L-M-Sherlock
Alright I went and spent the last couple hours reviewing this PR and, unfortunately, I don't agree with this refactoring.
If I had to summarize, I'd say: While I support bringing py-fsrs to feature parity with ts-fsrs, I don't support turning py-fsrs into ts-fsrs. I'm sure ts-fsrs is just fine, but I don't think making py-fsrs equal to ts-fsrs in its implementation should be a goal.
I'll illustrate just a couple of my concerns below:

Parameters
Previously, you could initialize the FSRS scheduler by providing the weights, request retention and maximum interval to it directly. Now if you'd like to initialize a custom scheduler, you must first initialize a Parameters object. I can't see any good reason to implement it this way other than that's how ts-fsrs does it. I believe this adds unecessary encapsulation and complexity to something that was otherwise straightforward. If we look at other popular python libraries, e.g., sklearn's RandomForestClassifier, we find that, regardless of there being many possible parameters to intialize an object with, there's no need to encapsulate them e.g. 'class RandomForestParameters'.
review_card -> next
Similar to the above, I don't understand what the motivation was to make a change here other than because that's what ts-fsrs does. 'review_card' as a name is much more semantic and clear than 'next'.
Furthermore, I don't see what was wrong wrong with review_card returning a tuple rather than a SchedulingInfo object other than that's because how ts-fsrs does it. If we look again at something like sklearn's RandomForestClassifier predict_proba method, we see that it just returns a numpy array or a list of numpy arrays. There's no need to encapsulate the output with something like 'class Probabilities'.
preview
I spent some time trying to figure out what the preview method in the AbstractSheduler was meant for, other than replicating ts-fsrs, but it looks like it's trying to replace the SchedulingCard's schedule method. Despite this, SchedulingCards has not yet been removed in this refactoring. Additionally, while I'm sure having something like repeat/preview makes sense for code that is directly integrated into anki like fsrs-rs, I don't think it's needed in this implementation as, if a developer wants to provide preview cards, they can simply call review/next on a card with various ratings themselves.
Overuse of encapsulation
In case this point was lost above, I'll reiterate: I believe there is too much unecessary encapsulation in this refactoring. I get that that's how ts-fsrs does it, but I don't believe it's necessary the way it is. I worry that such encapsulation will make this repo both harder to maintain and to develop on top of.

I look forward to your response, but as it currently stands, I don't agree with this refactoring.

Sorry about the confusion. I agree that py-fsrs can have its own unique design while achieving feature parity. However, I want to clarify a few things:

In ts-fsrs, it’s not mandatory to initialize an FSRS instance with a Parameter object. The generatorParameters method is provided to allow developers to have a complete set of FSRS parameters when initializing the User/Deck entities, but in reality, you can create an FSRS instance by passing only some of the parameters.

The next method in ts-fsrs allows for passing the (Card, Date, Grade) parameters. The idea behind it is to express the next state of the card. Prior to version 4.0.0, ts-fsrs did not have a review_card method, while py-fsrs had it in earlier versions. Therefore, I believe this refactoring can keep review_card in place. @L-M-Sherlock @joshdavham

AbstractScheduler is meant to replace SchedulingCard. In ts-fsrs, SchedulingCard has already been deprecated and removed, so this PR should remove SchedulingCard as well. @L-M-Sherlock

The encapsulation in ts-fsrs is aimed at decoupling short-term and long-term scheduling and decoupling the Scheduler itself to avoid conditionally executing actions based on parameters. ts-fsrs will soon export AbstractScheduler, BasicScheduler, and LongTermScheduler to allow developers to customize scheduling.

For example, for new->learning transitions, one might use BasicScheduler, and when a card in the State.review stage receives an Again rating, LongTermScheduler would be called, etc. I don’t want to rely on the enable_short_term parameter to determine whether a specific method should be executed or to modify the card’s state accordingly.

OK. I agree it's unnecessary to keep py-fsrs consistent with ts-fsrs completely. But I hope py-fsrs could support #56 and #60, whatever the way it implements. And as @ishiko732 mentioned, ts-fsrs's design has some advantages, but my PR drops some of them because I don't know how to do the same thing in Python.

I don't know how to do the same thing in Python.

maybe try https://typing.readthedocs.io/en/latest/spec/protocol.html#protocol-members

notice the warning :)
from typing import Protocol

class Methods(Protocol):
    def A(self): ...
    def B(self): ...
    def C(self): ...

def doit(d: Methods):
    d.A()
    d.B()
    d.C()

class Runner(Methods): ...

r = Runner()
doit(r)

@L-M-Sherlock @ishiko732
Thanks you guys for your input
As for next steps, I suggest two alternatives:

We try to salvage this PR by refactoring this refactoring
We plan a rough roadmap now and get back to #56 and #60 later

Both 1. and 2. are doable, but I worry that if we do 1., we'll hit another stalemate. If we decide on 2., I can put something simple together and get your guys's feedback on it. I'm thinking we list out some of the changes we'd like to see going forward, agree on an API for this library and then decide roughly in which order we'd like to implement these changes.
Let me know what y'all think

OK. Let's do 2.


Adding additional roots when creating the bundled APK

Issue Description
Adding additional roots when creating the bundled APK
Steps to Reproduce / Code Snippets
Our project is currently organized like this:
/
./App/
./common/
./www/

We run our react native app by first starting up the packager with the additional ./common root
./App/node_modules/react-native/packager/packager.sh --root ./common
and then
cd App react-native run-android
Now, my question is how to include the additional ./common directory when generating an APK, following the steps here: https://facebook.github.io/react-native/docs/signed-apk-android.html Otherwise, the program fails to find anything inside our ./common/ folder, as expected.
It seems neither cd android && ./gradlew assembleRelease nor react-native bundle talk to the packager. We also tried modifying the build.gradle file with extraPackagerArgs: ["--root", "../../../common"], but that didn't seem to help.
We were able to implement a workaround by cp -R ./common ./App/node_modules before bundling, but we're not sure if that's the right approach.

React Native version: 0.31.0
Platform(s) (iOS, Android, or both?): Android, would appreciate instructions for iOS as well
Operating System (macOS, Linux, or Windows?): macOS

@facebook-github-bot label Icebox

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/adding-additional-roots-when-creating-the-bundled-apk
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

@facebook-github-bot close


A very basic rectangle drawing function

Updates:
Adding a rectangle function for drawing a rectangle on any image by manipulating pixel by pixel, and with the ability to choose to fill or not to fill the rectangle.
for drawing a rectangle you need to pass these values as parameters:

[x] image - the image that you need to draw on.
[x] x1 - the x axis of the first point
[x] y1 - the y axis of the first point
[x] x2 - the x axis of the second point
[x] y2 - the y axis of the second point
[x] height - the height of the rectangle
[x] fill - a Boolean variable which is to fill or not

What things will this affect:
This function won't affect any of the other features or functions of the library, but it will just be an independent function which allows you to draw a rectangle .. also I will be working on other drawing features like drawing a line or a circle or a rectangle.
features will be added soon:

[x] Line drawing function.
[ ] Circle drawing function.
[ ] Triangle drawing function.
[ ] The ability to choose the color and the width of the rectangle's border.
[ ] Other things will be soon.

rectangle.txt

Thank you for the fresh code! Is it a plugin or a bundled feature?

I think it could be a bundled feature, but I will be working on it all the time, also I will make functions for line, circle, point and all of these also I will improve it to take less parameters and make the same job, also I will be working on all the drawing features to make the library better, that's because I see that it is so useful and an excllent library that will save lots of time of people writing code.

@BestDr Hows the progress on this?

I was so busy this peroid, so I couldn't make more things, but I will be working on it these few days.

What do you think? Is it better to enhance the rectangle function or to continue making more shapes and forms?

@BestDr Hows the progress on this?

Hi! ~40%. Close in TODO, depends on time again. Will write here when something is ready.

By the way, guys, press the like button here, if interested, - I'll try to make it faster C:

@houd1ni I can't close anything in todo, I don't know why, if you know the reason please tell me.

@houd1ni I will continue working on it after 3 or 4 days, because after 3 / 4 days I will have nothing to do, and I will finish everything, then I will have a lot of time for working on Jimp.
Sorry for this long delay, but I will make it as good as I can after I finish everything.

Was looking for a quickie on drawing rectangles, stumbled on this.  Top-left/bottom-right co-ords would suffice -- the others can be deduced from that, no?

@leegee  Looks, like you're right, moreover, I think it's better to comply the html5 canvas spec where possible.

@leegee I will make another function that requires one point, width and height soon.
If you agree or if you see that this function will be useful please add a reaction on this comment.
By the way, also I can remove the height parameter here, I don't even know why I thought of adding it, I could simply subtract the y axis of the two points.
But anyways, I c made this before a long time, and I was busy, but I will continue working on it again if possible.
Thank you for your suggestion.

I think follow the HTML5 canvas spec if possible, as
https://github.com/oliver-moran/jimp/pull/699#issuecomment-535844848
On Fri, Oct 25, 2019, 18:09 Majd Haj Yehia - BestDr <
<EMAIL_ADDRESS>wrote:

@leegee https://github.com/leegee I will make another function that
requires one point, width and height soon.
If you agree or if you see that this function will be useful please add a
reaction on this comment.
By the way, also I can remove the height parameter here, I don't even know
why I thought of adding it, I could simply subtract the y axis of the two
points.
But anyways, I c made this before a long time, and I was busy, but I will
continue working on it again if possible.
Thank you for your suggestion.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/oliver-moran/jimp/pull/699?email_source=notifications&email_token=AAD5GMFATZLWAV6S5CR5Z7DQQMR3FA5CNFSM4GTKUG52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECI7AQY#issuecomment-546435139,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5GMAGQAAZBO7UPH3F6YTQQMR3FANCNFSM4GTKUG5Q
.

@leegee @houd1ni what do you mean by the HTML5 canvas specs? Because I only made this function with the features that Jimp originally offers.

As in use the same API
On Sat, 26 Oct 2019, 19:06 Majd Haj Yehia - BestDr, <
<EMAIL_ADDRESS>wrote:

@leegee https://github.com/leegee @houd1ni https://github.com/houd1ni
what do you mean by the HTML5 canvas specs? Because I only made this
function with the features that Jimp originally offers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/oliver-moran/jimp/pull/699?email_source=notifications&email_token=AAD5GMG3XPTHWBDG6MX4HGTQQSBKLA5CNFSM4GTKUG52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECKNVDQ#issuecomment-546626190,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5GMAMGC654SBBXUXPVYLQQSBKLANCNFSM4GTKUG5Q
.

@leegee Can you give me an example from this repository of a function or a features that uses the HTML5 Canvas specs?

@leegee Removed the height parameter.
Do you prefer that I remove the whole function and make it with less parameters or that I make another function that has a different number of parameters?

I'm no-one but a passer-by, but I liked the other guy's comment about
keeping inline with the canvas methods, as they are streamlined and
probably familiar tomost users.

Ok, then I will try to make based on the HTML5 Canvas, the problem that I personally didn't use the HTML5 features a lot before.
But I will do my best to do that.
Thank you for giving me some useful suggestions, even if you are a passer-by you gave me some points that are so important.

What's the current progress on this? I'm interested.
One could also try porting the drawing elements from another pkg called pureimage

What's the current progress on this? I'm interested.
One could also try porting the drawing elements from another pkg called pureimage

I haven't pushed any commits since 8 months ago, but if you're interested I will finish this during the next week.
But, I wanna get some advices if you have any.
And the number of parameters will be reduced if I continued working on it, the height parameter useless here because I already have two points, and the fill / background-color parameters will be made optional too.

What's the current progress on this? I'm interested.
One could also try porting the drawing elements from another pkg called pureimage

I haven't pushed any commits since 8 months ago, but if you're interested I will finish this during the next week.
But, I wanna get some advices if you have any.
And the number of parameters will be reduced if I continued working on it, the height parameter useless here because I already have two points, and the fill / background-color parameters will be made optional too.

I read the reply chain and saw you were looking for someone's implementation that mimicks the HTML5 Canvas spec
Lucky you, the package I mentioned that could be ported from (called pureimage) is actually based in the Canvas spec but it's not as powerful as JIMP in its current state (which is why I suggested porting over) so you can take inspiration from her

What do you think? Is it better to enhance the rectangle function or to continue making more shapes and forms?

I believe JIMP would be an even better choice for those that prefer no native dependencies for imaging if more shapes were to be included...
Rectangle, Circle/Ellipse and Path (connected points) are a few that come to mind that would be very useful

I don't suppose this is still being worked on. I'm looking at making triangles, but the math for that will be difficult.

I don't suppose this is still being worked on. I'm looking at making triangles, but the math for that will be difficult.

Honestly just making a path drawing function similar to HTML5 Canvas can solve all polygon related functionalities
After all to draw triangles in many base libraries you DO have to define 3 points and how those 3 points will be displayed (in case of 2d, fill and stroke, in case of 3d, color per vertex or stuff along those lines)

@Frustrated-Programmer @GlitchyPSIX
For now I am working on something full-time and it's really hard to work on both two things, but I might have a little bit of time to work on completing all the features I listed in my main commend (including ellipse, triangle and all kinds of shapes if possible), and I will tell you all here when about the progress once I find the time :) .

@houd1ni I have finished the line function with an optimization algorithm, where do I have to push the changes? because I can't upload files or open pull requests and branches

@BestDr  Hi! Why don't you? Open the PR to oliver-moran/jimp pointing to this issue.

@houd1ni I uploaded it in #908 , ignore the test.js file, I uploaded it by accident.

The code for this really isn't mergable and doesn't follow the patterns in the repo. I'm happy to merge a path drawing plugin to jimp. This just isn't quite it yet


Fixed incorrect typing

Codecov Report

Merging #19 (536ffe9) into main (d341a91) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines          174       174
  Branches        20        20
=========================================
  Hits           174       174

Flag
Coverage Δ

unittests
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d341a91...536ffe9. Read the comment docs.


how to create a big amount of accounts? (that dont get banned when you run the program)

uuummm when i finnaly able to run the program it says that the accounts from that web are getting banned from r/place...
the web that im using to create accounts that get banned: https://redditthrowaway.xyz/
do you have any alternatives?

join some random subs and verify the email

can you be more specific?

For each of your bot accounts, try to make it look like they’re genuine and not bots:

Login
Verify their email addresses
Join different subreddits

where do i get for each bot email?

temp-mail.org

It is required when you create a Reddit account.

Do you have reddit account creator that do that?

Do you have reddit account creator that do that?

No and you will probably not find one here, it is outside of the scope of this project.

Do you have reddit account creator that do that?

No and you will probably not find one here, it is outside of the scope of this project.

Do you have one outside of this project? Like the link i added

Do you have reddit account creator that do that?

No and you will probably not find one here, it is outside of the scope of this project.

Do you have one outside of this project? Like the link i added

I recommend using Gmail.
If your mail is<EMAIL_ADDRESS>you can change it by writing e.xample<EMAIL_ADDRESS>and it will all send the accounts to the same inbox.

Do you have reddit account creator that do that?
No and you will probably not find one here, it is outside of the scope of this project.>Do you have one outside of this project? Like the link i added

You are probably not going to find one for free online.
It's not difficult to make such a "generator" yourself, but as others have said, it's out of the scope of this project.


gitRepo: 2.29.1 -> 2.29.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for gitRepo is: "Android's repo management tool"
meta.homepage for gitRepo is: "https://android.googlesource.com/tools/repo"
meta.changelog for gitRepo is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.29.2 with grep in /nix/store/8h6vhk6sgzxx0qlnjsvcsvzgagmf4aql-git-repo-2.29.2
found 2.29.2 in filename of file in /nix/store/8h6vhk6sgzxx0qlnjsvcsvzgagmf4aql-git-repo-2.29.2

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
gitRepo

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/8h6vhk6sgzxx0qlnjsvcsvzgagmf4aql-git-repo-2.29.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A gitRepo https://github.com/r-ryantm/nixpkgs/archive/b1075c25001f83c53f8fbae4d3ef0ce1c5311a48.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/8h6vhk6sgzxx0qlnjsvcsvzgagmf4aql-git-repo-2.29.2
ls -la /nix/store/8h6vhk6sgzxx0qlnjsvcsvzgagmf4aql-git-repo-2.29.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

gitRepo

Maintainer pings
cc @otavio for testing.

Result of nixpkgs-review pr 190666 run on x86_64-linux 1

1 package built:

gitRepo


Regenerate Container client

This PR was generated using Autosynth. :rainbow:
Here's the log from Synthtool:
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Cloning https://github.com/googleapis/elixir-google-api.git.
synthtool > Running: docker run --rm -v/home/kbuilder/.cache/synthtool/elixir-google-api:/workspace -v/var/run/docker.sock:/var/run/docker.sock -w /workspace gcr.io/cloud-devrel-public-resources/elixir16 scripts/generate_client.sh Container
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/tmpfs/src/git/autosynth/env/lib/python3.6/site-packages/synthtool/metadata.py", line 63, in write
    with open(outfile, "w") as fh:
FileNotFoundError: [Errno 2] No such file or directory: 'clients/Container/synth.metadata'

This was due to the change that container made to their parent resource. It ends up being backward incompatible here. Closing and seeing if rerunning generate will do better with a later update.


fix: detect lightning param in bip 21 QR codes

This PR addresses this issue, where we do not recognize the lightning param in BIP 21 QR codes.
In completing this work, I refactored the validPayment method, which was getting a little long. The existing logic seemed to initially determine the paymentType, and then create the payment response based on this type. I attempted to reflect this approach through some new functions.
To detect the lightning param, I leveraged the query-string node module which was already present in the project as a dependency.
All existing test cases pass, and I added a case for this specific piece of functionality, as well as a couple other cases we were missing.

Hi @allenwhite.  Thanks for raising the PR.  I tried to scan the example QR code on the linked issue but received the following error.

Good call @bodymindarts - I didn't see any guidelines the the contributing readme, but now that I know, I will clean up the commits.
@daviroo I got that as well, but when I debugged it, it seemed the root cause was because the invoice was expired. Running locally also gave me that error due to the network being testnet. I commented out those checks in getLightningPayResponse and saw the expected behavior. I also included the QR in the tests I added to confirm it was working there (since we override moment.now()). Let me know if you are seeing something different tho.

@daviroo I got that as well, but when I debugged it, it seemed the root cause was because the invoice was expired. Running locally also gave me that error due to the network being testnet. I commented out those checks in getLightningPayResponse and saw the expected behavior. I also included the QR in the tests I added to confirm it was working there (since we override moment.now()). Let me know if you are seeing something different tho.

I think in the case that the lightning invoice has expired we should instead pay to the onchain address.  Can you incorporate this into your change?  Also the commits still don't seem right, did you use rebase?

Closing in favor of galoy-client/pull/42


qwen returns empty string

I noticed something interesting where this tiny model returns an empty string whenever I query it:
https://huggingface.co/Qwen/Qwen1.5-0.5B-Chat-GGUF/resolve/main/qwen1_5-0_5b-chat-q4_0.gguf

Hey, @flatsiedatsie, could it be related to the prompt you're using?
I tried it and got a good response.
Here's the prompt I used:
<|im_start|>user
Explain quantum computing like I'm five<|im_end|>
<|im_start|>assistant

Could you try again with this one?

Console info, for reference:

@felladrin Thank you for having a look. I didn't have time to look into details, but seems like Qwen models are quite sensitive to chat templates (due to their small size - there is no room for errors)
Please let me know if that works for you @flatsiedatsie

Thanks for testing on your end.
I managed to get output once, but only once.
I'm using the tokenizer from Transformers.js to generate the prompts. There was an issue with that, but it was fixed a while ago as far as I can tell. This process uses Jinja2 templates which are stored on HuggingFace.

It's working now. I'm not even sure why :-D


bump github/branch-deploy to v10 and update branch-deploy settings

This pull request updates branch-deploy to the latest version. It also removes the skip_reviews and skip_ci settings as this is an open source project, making those options somewhat unsafe.

.deploy

.deploy


Created class-with-static-methods.js

Thank you for your PR!
Unfortunately your PR doesn't feature a solution to the actual FizzBuzz problem itself.
The goal is to find creative/abstract new solutions to FizzBuzz.
See The top 5 samples here.
Thanks anyway! :)


The options --no-pictures and or --no-videos downloads images randomly.

Describe the bug
If you set --no-pictures and or --no-videos, instaloader will still download photos at random.
To Reproduce
Use --no-pictures and or --no-videos on a good sized profile.

If you use --no-pictures AND --no-videos, Instaloader only downloads the profile pic (suppressible with --no-profile-pic), the metadata files (suppressible with--no-metadata-json) and the caption text files (suppressible with --no-captions).
See "What to download" for further information.

Ok, so lets say I only wanted to download videos, here are the options I would use. But instaloader still download's images from the profile randomly along with all the videos.
Perhaps I missed something?
--no-pictures --no-captions --no-metadata-json --no-video-thumbnails  --stories --highlights --tagged

I admit this can be a bit confusing. --no-pictures has no effect on stories or highlights. If you only want to download stories and highlights that are videos you can use --storyitem-filter="is_video".

I appreciate the reply, I think I understand. When I'm just trying to download metadata I have the same issue using the options below.
--no-pictures --no-videos --no-video-thumbnails --no-profile-pic --no-captions --no-compress-json --stories --highlights --tagged
Using --post-filter or --storyitem-filter, how would the expression go if you wanted to exclude videos and pictures "not is_video and not is_picture" or something like that?

I appreciate the reply, I think I understand. If I try to only download metadata I end up having the same issue with the options below. My goal is to download metadata from every possible post on the profile and nothing else.
--no-pictures --no-videos --no-video-thumbnails --no-profile-pic --no-captions --no-compress-json --stories --highlights --tagged
"--no-pictures has no effect on stories or highlights" - So how could I still get the metadata from the stories and highlights and not download the photos?
Or am I not thinking about it in the right way?

I appreciate the reply, I think I understand. If I try to only download metadata I end up having the same issue with the options below. My goal is to download metadata from every possible post on the profile and nothing else.
--no-pictures --no-videos --no-video-thumbnails --no-profile-pic --no-captions --no-compress-json --stories --highlights --tagged
"--no-pictures has no effect on stories or highlights" - So what could I do to still get the metadata from the video or photo stories and highlight posts and not download the photos?
Or am thinking about it in the wrong way?


Patch to support more file extensions to MIME types

This is preparatory to FTP support, where only the extension tells you what the MIME type is.
more-extensions.diff.txt

Nice. Recognizing more extensions should be helpful in general.
I'll only need to check if mediaTypeFromFileExtension_String is being called often anywhere, which would have an implication on performance. In that case, using a binary search into an alphabetically sorted array might be preferable to a linear for loop.


⚠ Bofrost.de has degraded performance

In b136041, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1564 ms

Resolved: Bofrost.de performance has improved in b7648b7.


Update JMESPath arithmetic functions' docs

Closes #392
Signed-off-by: Kumar Mallikarjuna<EMAIL_ADDRESS>

Can you address any in-line comments and mark as resolved if done, please?

@ojhaarjun1 ☝

Also, conflicts to resolve.

See inline comment. Can we add this to help users?

A note seemed more appropriate.


Drop debug postfix

Users that wish to continue building with the debug postfix enabled can pass -DCMAKE_DEBUG_POSTFIX="-d" when building hipSOLVER.

I understand that DCMAKE_DEBUG_POSTFIX only changes the name of non-executable targets, while all that I see is the PR touching code that set the name of executables.

I didn't notice that. Thanks for pointing it out! I suspect that the CMake reasoning is that setting the debug postfix on executable targets is weird and unusual, which is why this mechanism only sets it on library targets. Although, I think you could use CMAKE_EXECUTABLE_SUFFIX for that if you really wanted to.
For what it's worth, hipFFT removed it ten months ago.

I'll update the description and add a changelog entry.


Compatibility with Current FFMpeg and OpenJPEG

In order to have oiio successfully built, I've got to disable USE_FFMPEG and USE_OPENJPEG
Any suggestions ?
Cheers
Pei

It would certainly help if you told us exactly in what way the build was unsuccessful. What error messages specifically did you see?
For that matter, you don't tell us what version of OIIO you were trying to build, or what versions of ffmpeg and OpenJPEG you were trying to use.

Looks like somebody has a patch pending (#1503) to update our use of ffmpeg for its latest API. Are you able to try that patch on your end and see if it helps your problem?

I'm going to assume this is fixed and close. I know that both at work and at home, my OIIO builds are able to use ffmpeg and openjpeg with no problem.


Sysprep fails if Microsoft Terminal ist installed.

Regardless if Preview or stable is installed: Syspreping a Machine with Microsoft.Terminal fails.
Setupact.log says The App is installed for a User but not provisioned for all users. Onle Uninstall the App can Fix this.

If you want to provision the application as part of a system image, you will need to use the preinstallation kit.
More information here, excerpted from the release page:

A preinstallation kit is available for system integrators and OEMs interested in prepackaging Windows Terminal with a Windows image. More information is available in the DISM documentation on preinstallation. Users who do not intend to preinstall Windows Terminal should continue using the msixbundle distribution.


stripmap2vrt: adjust to geom_reference

This PR fix/add the following a few minor items:

stripmap2vrt: adjust to the new isce-2 convention of "geom_reference"

tops2vrt: fix np.int() deprecation warning

unwrap_fringe: add "used time" info

Thanks for the review @scottstanie.


Add support for multi-action write transactions

This PR provides support for multi-action write requests (as detailed in the Dynamo spec here)
Currently the Scanamo API allows only write requests of the same type (Put, Update, Delete) to be grouped together in a single transaction (i.e. transactPutAll, transactUpdateAll, transactDeleteAll).
This change introduces transactionWrite which accepts multiple TransactionWriteActions. These actions could be a mix of Put, Update, Delete or ConditionCheck types and can span multiple tables.

Summoning @rtyley to see if you have some time to take a quick look.


Allow Trailing Slashes within HTMLTest

We enforced trailing slashes within our docs to reduce redirects. This was no issue as long as we structured our documentation with <documentName>/_index.md. But it causes problems with the more accessible and more straightforward way of naming them simply <documentName>.md without an own folder.
Detailed Description
To visualize this; we take a look at this structure
doc1/
├─ _index.md
doc2.md
root.md

If we link from root.md to doc1/_index.md, we can use this syntax [link](doc1\) with a trailing slash, signalizing that this is a folder and that there will be no redirect. (works with HTMLtest and markdown-link-check).
If we link from root.md to doc2.md, it gets complicated, we can use this syntax:

[link](doc2), this is correct each IDE will detect it - but it will be a redirected link within Hugo, hence that HTMLtest will complain about the missing trailing slash
[link](doc2/), with a trailing slash, signalizing that this is a folder and that there will be no redirect. This will work with HTMLtest, and will work with the rendered page, but it won't work within IDEs and markdown-link-check.

Proposal
As I do think both ways of naming and creating documentation are valid, and the one without a folder provides a nicer experience. I suggest removing the trailing slash check within HTMLtest

@StackScribe, i think we should remove the trailing slash check

I am happy with that solution but I could also live with having to do the /index.md structure as well.  Frankly, the quality of our markdown code seems like a much lower priority than being able to quickly improve the content and organization so favor solutions that don't impede that work.


Don't want to click save and/or choose instrument

We have only one instrument. Moreover, saving should be triggered upon "Next" button click.

Starting from v1.1 polygon instrument is selected by default.
Starting from commit 8f90225ebec0403619170f452bda5bd6f9543a9c clicking "Save" button is not mandatory, all markup data is being saved before user presses "Next" button.
Since currently there is no user notifications about status of the markup (whether it was saved or not), the "Save" button is still visible & operational. Users can click on it if they worry about the markup status and their markup results will be recorder as an answer to the job in Yandex.Toloka (or, simplier, re-saved).

Ok, I'll test it.

Is it in develop-toloka branch or everything is in master branch now?
Isn't latest commit supposed to be inside release too?

Thank you.

It is in develop-toloka branch at the moment.
We'll make a new release as soon as we document polygons deletion and undoing latest markup points on the wiki, since those features are planned for the same release.
Currently, no. As I mentioned in the previous comment this is the reason why "save" button is still visible & operational, so that the users won't be worried whether their markup is saved.
I am thinking about implementing Google docs-like notifications about the saving of the latest markup changes in the future, but it needs more consideration.

Ok, thanks, I'll give it a try. :)