Update plugin for SBOM generation to 2.7.10

Description of PR
Update the CycloneDX Maven plugin for SBOM generation to 2.7.10
How was this patch tested?
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 11s

trunk passed

+1 :green_heart:
compile
17m 57s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
16m 28s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
mvnsite
20m 21s

trunk passed

+1 :green_heart:
javadoc
10m 23s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
9m  8s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

-1 :x:
shadedclient
157m 52s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 46s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
0m 25s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javac
0m 25s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
compile
0m 21s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
javac
0m 21s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-1 :x:
mvnsite
2m 42s
/patch-mvnsite-root.txt
root in the patch failed.

-1 :x:
javadoc
0m 25s
/patch-javadoc-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javadoc
0m 26s
/patch-javadoc-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
shadedclient
6m  8s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 25s
/patch-unit-root.txt
root in the patch failed.

+0 :ok:
asflicense
0m 25s

ASF License check generated no output?

183m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6235/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6235

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint

uname
Linux ca20f4116f4a 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bb592db46450246d7b63d3954f7e41d95816284a

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6235/1/testReport/

Max. process+thread count
260 (vs. ulimit of 5500)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6235/1/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
xmllint
0m  0s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1 :x:
mvninstall
1m  3s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
2m 14s
/branch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
compile
4m 20s
/branch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in trunk failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
mvnsite
0m 25s
/branch-mvnsite-root.txt
root in trunk failed.

-1 :x:
javadoc
0m 24s
/branch-javadoc-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javadoc
0m 24s
/branch-javadoc-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in trunk failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
shadedclient
9m 58s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 24s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
0m 24s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javac
0m 23s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
compile
0m 24s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
javac
0m 24s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-1 :x:
mvnsite
0m 24s
/patch-mvnsite-root.txt
root in the patch failed.

-1 :x:
javadoc
0m 23s
/patch-javadoc-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javadoc
0m 24s
/patch-javadoc-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
shadedclient
3m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 24s
/patch-unit-root.txt
root in the patch failed.

+0 :ok:
asflicense
0m 24s

ASF License check generated no output?

21m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6235/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6235

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint

uname
Linux 98493de09711 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bb592db46450246d7b63d3954f7e41d95816284a

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6235/2/testReport/

Max. process+thread count
64 (vs. ulimit of 5500)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6235/2/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

have triggered the build again. @VinodAnandan can you create a HADOOP ticket & prefix the jira id on this PR

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
12m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
xmllint
0m  1s

xmllint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m 53s

trunk passed

+1 :green_heart:
compile
17m 11s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
16m 11s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
mvnsite
20m 19s

trunk passed

+1 :green_heart:
javadoc
8m 38s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 30s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
shadedclient
149m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
30m 26s

the patch passed

+1 :green_heart:
compile
17m 34s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
17m 34s

the patch passed

+1 :green_heart:
compile
15m 48s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
15m 48s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
mvnsite
14m  9s

the patch passed

+1 :green_heart:
javadoc
8m 57s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
7m 33s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
shadedclient
67m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
752m  3s
/patch-unit-root.txt
root in the patch passed.

+1 :green_heart:
asflicense
1m 47s

The patch does not generate ASF License warnings.

1051m 41s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestDFSUtil

hadoop.fs.http.client.TestHttpFSFWithWebhdfsFileSystem

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6235/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6235

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint

uname
Linux 3e0f0be35d16 4.15.0-213-generic #224-Ubuntu SMP Mon Jun 19 13:30:12 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bb592db46450246d7b63d3954f7e41d95816284a

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6235/3/testReport/

Max. process+thread count
3078 (vs. ulimit of 5500)

modules
C: . U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6235/3/console

versions
git=2.25.1 maven=3.6.3

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

have triggered the build again. @VinodAnandan can you create a HADOOP ticket & prefix the jira id on this PR

Done.


Feature/best buy

Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines in the contributing guide.
[x] Your changes are made in the README file, not the auto-generated JSON.
[x] Your additions are ordered alphabetically.
[x] Your submission has a useful description.
[x] Each table column should be padded with one space on either side.
[x] You have searched the repository for any relevant issues or PRs.
[ ] Any category you are creating has the minimum requirement of 3 items.

Hi @shakyink , thanks for the PR! Is there documentation somewhere that talks about pricing/tiers?

Hi @davemachado, say pricing/tiers are referring to the pricing of the products sold by Best Buy or pricing for API usage?
The PR only reflects the API for general consumer information. From what I have read on their documentation there is no cost to using their API in terms of tiers. However for commercial info you have to request an API Key specific for their commerce api

Thanks @shakyink !


Add content management system

Add the ability for members to add, edit, and change the website without coding via a content management system.

done


composer: add tls config

@Gundersanne @ondrejbudai I've had to re-add some tls config when creating the composer`client. I've tried to make the changes as noninvasive as possible. The reason for this is that in the dev stack the backend is unable to communicate with the composer instance because of self-signed certs (https://github.com/osbuild/image-builder/issues/291)
I'm not sure if we want to include this "fix", so I've marked it as draft for now and happy to hear your thoughts.

Can't composer just ignore a bad certificate?

Can't composer just ignore a bad certificate?
That sounds like a much simpler solution. What would I need to do in composer to change that?

Chm, I might be confused. Does the local dev stack support OAuth, or is it currently limited to mTLS?

Chm, I might be confused. Does the local dev stack support OAuth, or is it currently limited to mTLS?

I've got this draft PR to add oauth support (So it's using jwt and not mTLS):
https://github.com/RedHatInsights/image-builder-frontend/pull/428
The oauth server is using http though, because of the certs.

Right, thanks for your patience with me. :D I don't think that you actually need to provide a key and a cert here, right? I think that supplying just the CA should be fine (we are not using mTLS anymore, so image-builder doesn't actually need to send any certs, it just needs to trust the authority that signed the composer's cert). I would also rename the variable to COMPOSER_CA_PATH.
This feels slightly cleaner, just disabling the CA check should be the last resort I think.

No not at all! Oh yeah of course, let me try it without the key and cert! Agreed about disabling the CA check as the last resort.

@ondrejbudai yeah it works with just the CA

Ah, GoSec complains, you need to put back the line that set minTLS to 1.2.

Ah, GoSec complains, you need to put back the line that set minTLS to 1.2.

Just saw that. Should be good now.

you can just turn of tls as well
      enable_tls = false
      enable_mtls = false

the idea was that in that case you had to enable jwt but since I wrote it the check for that isn't ever executed https://github.com/osbuild/osbuild-composer/blob/main/cmd/osbuild-composer/composer.go#L122 :penguin:

Yeah enable_tls=false is also another option, but we'd need to make the protocol for the workers configurable, since they're hard-coded to https. I don't think we would need to enable .KeysInsecure(bool) for that solution either.


Fix metadata inconsisteny workflow check

Description
This commit fixes the failure that arises during the metadata inconsistency check during major version upgrades. Handling of multiline strings in github seems to be inconsistent.
This issue was introduced by #2554
Issues Resolved
BABEL-4139
Test Scenarios Covered

Use case based -

Boundary conditions -

Arbitrary inputs -

Negative test cases -

Minor version upgrade tests -

Major version upgrade tests -

Performance tests -

Tooling impact -

Client tests -

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 73.133%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
41626

Relevant Lines:
56918

💛  - Coveralls


Test for enabling exception filters

Per Don's request in Microsoft/visualfsharp#66, I'm submitting this PR to test the patch on Mono+Linux via AppVeyor.
Please do not commit this! If the tests pass, we'll merge the PR into the Microsoft/visualfsharp repo which will propagate here.

Thanks!!!!

It looks good that this passes on x86 Linux

Closing as this was a test run only


Handle HTTP errors in rusoto_credential::InstanceMetadataProvider

Returns the body of the HTTP response in a Err when the response status is not 200 instead of ignoring the error and just returning the body.
Note: this has been tested in production code and helped us narrow down the issue we're having.

@benesch sorry to ping you like this, but I believe this is quite an important bug fix that would make sense to review/merge, thanks!

@benesch sorry to ping you like this, but I believe this is quite an important bug fix that would make sense to review/merge, thanks!

Does this still apply to the new version?


Adding CRA/Jest transformIgnorePatterns info

I just spent couple of hours trying to figure out why one of my pages wasn't working with Jest, and blowing up on jsdom render via react-testing-library.
Turns out that all node_modules by default do ignored for transpiling, and therefore the import statement in react-virtualized blows up.
An option would be to pre-compile the library before publishing to npm.
But for now added a note to README in case someone else gets stuck on this for a while, as there wasn't anything obvious anywhere for someone new like me!
I am fairly new to JavaScript / React eco-system.
Apologies if this is the wrong section/area to add it to, let me know if there is a better place to put this, or better/more descriptive info as to what the underlying problem is.
Thanks for contributing to react-virtualized!
Before submitting a pull request, please complete the following checklist:

[ ] The existing test suites (npm test) all pass
[ ] For any new features or bug fixes, both positive and negative test cases have been added
[ ] For any new features, documentation has been added
[ ] For any documentation changes, the text has been proofread and is clear to both experienced users and beginners.
[ ] Format your code with prettier (npm run prettier).
[ ] Run the Flow typechecks (npm run typecheck).

Here is a short checklist of additional things to keep in mind before submitting:

Please make sure your pull request description makes it very clear what you're trying to accomplish. If it's a bug fix, please also provide a failing test case (if possible). In either case, please add additional unit test coverage for your changes. :)
Be sure you have notifications setup so that you'll see my code review responses. (I may ask you to make some adjustments before merging.)

Codecov Report

Merging #1412 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1412   +/-   ##
======================================
  Coverage    90.4%   90.4%
======================================
  Files          59      59
  Lines        1740    1740
======================================
  Hits         1573    1573
  Misses        167     167

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 710fc67...99432c8. Read the comment docs.


Added simple CoC completion source.

I didn't see any obvious way to hook up Omnisharp completions to coc.nvim without either using the not fully featured lsp mode or the omnifunc source, which isn't recommended.  So, I thought I'd put together a very simple completion source to see if I was on the right track for what I should do.
Does this seem right, and should it work for everyone else, too?

I haven't used coc.nvim but is there some vimrc config needed for this? Or does CoC just source **/coc/source*.vim scripts or something? @JulioJu, you were interested in coc.nvim, do you want to test this out?
I'm away for a few days and can't test anything just now sorry.

The coc docs say within the autoload directory: https://github.com/neoclide/coc.nvim/wiki/Create-custom-source

Ah I see, thanks @DianeOfTheMoon. And it's working well for you, I assume?

Yep, so far.  I'll keep using it and will update the PR if anything comes up.

Thanks for the contribution @DianeOfTheMoon!


Move Druid release artifacts to Sonatype

Switch to using Druid parent POM
Add required fields for Sonatype
Common plugin versions and settings have been moved to the parent pom
Cleanup artifacts and POMs for consistent formatting

+1! Travis is also failing @_@

Looks like I need to make org.hyperic.sigar optional and give instructions as to how to include it, since it's not in maven central.

I thought we had made it optional to include as a metrics monitor. we should consider making sigar an extension?

Need to update server-metrics first

It is already an "extension", in the sense that you can choose which monitors to include at runtime.
No need to move it into a separate module.

Need to remove dependency on kafka-7 which does't have a maven central artifact. Anyone have any objections?


Problem with javascript proxies and Java interop

Hi,
I'm trying to use javascript proxy to make it easier to interact with scala, but I ran into the following issue. If I try to create a proxy over a Java type, the javascript proxy is not a function anymore. I understand that this is an edge case and it might not be supported, but in that case it would be nice to get a clearer error message.
~$ node --jvm
> const ArrayList = Java.type("java.util.ArrayList")
> const ProxiedArrayList = new Proxy(ArrayList, {})
> new ProxiedArrayList()
TypeError: JavaClass[java.util.ArrayList] is not a function
> typeof ProxiedArrayList
'function'

Additionally, trying to log the proxied value to console, results in
> ProxiedArrayList
TypeError: value.toString is not a function
    at formatPrimitive (util.js:626:1)
    at formatValue (util.js:392:1)
    at Object.inspect (util.js:290:1)
    at REPLServer.writer (repl.js:366:19)
    at finish (repl.js:470:5)
    at REPLServer.defaultEval (repl.js:168:3)
    at bound (domain.js:297:1)
    at REPLServer.runBound (domain.js:317:3)
    at REPLServer.onLine (repl.js:423:19)
    at emitOne (events.js:114:1)

Hi Laurynas,
thanks for your report. We have fixed the problem about constructing a Java object via Proxies. This is working now in tip of the master branch and will be part of the binary release RC8.
> const ArrayList = Java.type("java.util.ArrayList"); const ProxiedArrayList = new Proxy(ArrayList, {}); var a = new ProxiedArrayList();
> a
JavaObject[java.util.ArrayList]
> a.add("test")
true
> a.size()
1
> a.get(0)
test

For the second part of your report: You are runing on the node executable, thus in Node.js mode. Note the output was correct (even with RC6 or RC7) if you ran with js --jvm. In Node.js mode, the actual printing on the console is done by Node.jsown code, which we do not modify. Thus, node does not have special knowledge of Java (or other non-JS) objects. It should still work in this case, though. I am currently investigating whynode` cannot handle the ProxiedArrayList. Will get back to you on that.
Best,
Christian

Hi Laurynas,
I have just pushed an additional fix. In tip of the graaljs repo (and the next release) this issue should be fixed.
Christian

Thanks you very much!


staging-next 2022-05-28 - the first missing 22.05 release

workflow docs: nixos.org/manual/nixpkgs/unstable/#submitting-changes-commit-policy
important job(s): hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
jobset: hydra.nixos.org/jobset/nixpkgs/staging-next
nix-review reports: https://malob.github.io/nix-review-tools-reports/
previous staging-next: https://github.com/NixOS/nixpkgs/pull/173605

Failure diff:

aarch64-darwin: https://hydra.nixos.org/eval/1764921?compare=1764861
others: https://hydra.nixos.org/eval/1764921?compare=1764884

Oh, I noticed geary regression before merging, but I didn't realize that it's important (channel blocker): https://github.com/NixOS/nixpkgs/issues/175953


Update crowdsource.routes.js

please commit all the changes(xiaoran.html,home.html and your profile pic) and then only create a pull request

Thanks for your kind reply.

no problem ! feel free to ask for help if needed!

also could you accept the license? Thank you.

Thanks for reminding me to accept the license!

duplicates #196.


Create a "test connectivity" through customers function apps

Leveraging pre-made sample functions that test connectivity would improve the initial issues that customers may face when testing out their functions.
Creating a sample / and working on integration to their function app would be a good start.

Could we just have users create a basic input/output binding using the templates?


Adding hns functionality

Exposing HNS functionality. This implementation directly maps to our implementation in hcsshim for docker.
Signed-off-by: msabansal<EMAIL_ADDRESS>

@msabansal - You will need to rebase these on the dotnet cli changes. Please ping me if you need any help.

@jterry75 Fixed. Thanks.

We can't merge this until the exception thing is fixed.

That is, what's there right now won't build since HNSCall now returns void.

I messed up :(. I did a rebase and didn't commit properly. Fixing

Fixed.

LGTM


add maxScore

When we map reads to a ref,we need each read maxScore;Moreover ,a read maybe have many seed and each seed need extension,we need max score of eac extension in seed ,then we can take the high score in each max score in extension and decide the read mapping location in ref.
I add the maxScores function and lazy val maxScore

Can one of the admins verify this patch?

Closing as we've made the changed interfaces package private to ADAM.


Misc documentation errors

All in http://graphsjl-docs.readthedocs.org/en/latest/interface.html#basic-interface
I'll try to fix these up later but if someone wants a go at them in the meantime, feel free :)

http://graphsjl-docs.readthedocs.org/en/latest/interface.html#edge_index should refer to edges, not vertices.

in_edges and out_edges don't return the number of edges, they return iterators of edges.

source() and target() are defined twice

I think the repetition of source() and target() is okay because they're part of two different interfaces.


fix: award guild

only accept awards from the default guild

I mean... it doesn't break anything and it looks cool......

It does result in unresolved emojis in notification messages and looks weird on messages if they have awards from multiple guilds


[LRCLib] API docs don't seem to be accurate for publishing

Hi, I maintain lrcup, a CLI for uploading to LRCLib but also acting as a general API wrapper.
According to the LRCLib documentation, /api/publish takes:

All of which I provide:

Trying to upload a track with both unsynced and synced, LRCLib returns a 201 however when searching every song I've uploaded was marked as instrumental:

This affects the API as well, /api/get returns null for both syncedLyrics and plainLyrics despite the fact that I uploaded them.
I've also tried swapping syncedLyrics with synced_lyrics as the source code in this repository does, and it still gets marked as instrumental.
Additionally, around 2 weeks ago I was able to successfully upload without issues. My code has not changed and is available here.
Any help would be appreciated.
Awesome project by the way.

I see, I recently deployed a new backend implemented in Rust (instead of Node) to lrclib.net. It is very new, and I admit I rushed the release a bit in order to address performance issues with lrclib, so there might be a bug in publish API.
I'm looking into this right now.
Also, the newer source code used by lrclib is available here: https://github.com/tranxuanthang/lrclib. In the future, if there are any problems related to lrclib, you can now open new issue at lrclib repo for easier tracking!

I think the problem lies in these two files:

https://github.com/tranxuanthang/lrclib/blob/21db7271b49bb5c5dbcdc982d7277f43e207714b/server/src/routes/publish_lyrics.rs#L83
https://github.com/iiPythonx/lrcup/blob/3fdef0daaa406cf8ccc56dff36f35017836d9f1a/lrcup/__main__.py#L46

When submitting new synced lyrics, my new API implementation expects both plain lyrics and synced lyrics to be included in the request. For instance, if you submit syncedLyrics but leave plainLyrics empty, it will be treated as if the song is instrumental.
However, I did say this in the API documentation:
If BOTH plain lyrics and synchronized lyrics are left empty, the track will be marked as instrumental.

It is actually correct in LRCLIB's old backend, but also not very good. Because in both old and new backend, there is no timestamp stripping logic to turn synced lyrics into plain lyrics. In LRCGET it is only done at client side:
https://github.com/tranxuanthang/lrcget/blob/b0ec8fb746c31d327dc127f979dc97b184f22d98/src/components/library/edit-lyrics/PublishLyrics.vue#L93
I'll try to fix this and also add timestamp stripping logic to API side to keep compatibility, but I'm afraid some of the submitted lyrics (that have synced lyrics but not plain lyrics) using lrcup have been lost during my recent database cleanup and schema migration (when the new Rust backend was deployed). I was not aware that there were submissions containing synced lyrics without plain lyrics.

This is hopefully fixed in this commit and is deployed:
https://github.com/tranxuanthang/lrclib/commit/728e540ed4402a6d7934124206fa30758860bc24
Could you test it again?

I was not aware that there were submissions containing synced lyrics without plain lyrics.
I was about to update lrcup to automatically convert synced lyrics into plain lyrics and submit both.

Could you test it again?
Will do in a moment.

Yep, that commit did indeed fix the issue (along with me sending plain lyrics along with the synced ones, not sure why I didn't already have that implemented). Thanks for looking into this.


An error about annotations in future annotations

First Check

[x] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
# test_fastapi.py
from __future__ import annotations

from typing import Optional

import uvicorn
from fastapi import FastAPI
from pydantic import BaseModel

from jwt_tools import login_required

app = FastAPI()

class Item(BaseModel):
    name: str
    description: Optional[str] = None
    price: float
    tax: Optional[float] = None

@app.post("/items/", summary='asdfsa')
@login_required
def create_item(item: Item):
    return item

if __name__ == '__main__':
    uvicorn.run(app="test_fastapi:app", host="<IP_ADDRESS>", port=8000, debug=True, reload=True)

Description
i'm using __future__ annotations and i got an error about annotations.
# jwt_tools.py
from functools import wraps

def login_required(func):

    @wraps(func)
    def wrapper(*args, **kwargs):
        print('login')
        return func(*args, **kwargs)

    return wrapper

error ouput:
"C:\Program Files\Python38\python.exe" D:/workspace/test/test_fastapi.py
Traceback (most recent call last):
  File "D:/workspace/test/test_fastapi.py", line 26, in <module>
    def create_item(item: Item):
  File "C:\Program Files\Python38\lib\site-packages\fastapi\routing.py", line 582, in decorator
    self.add_api_route(
  File "C:\Program Files\Python38\lib\site-packages\fastapi\routing.py", line 525, in add_api_route
    route = route_class(
  File "C:\Program Files\Python38\lib\site-packages\fastapi\routing.py", line 407, in __init__
    self.dependant = get_dependant(path=self.path_format, call=self.endpoint)
  File "C:\Program Files\Python38\lib\site-packages\fastapi\dependencies\utils.py", line 278, in get_dependant
    endpoint_signature = get_typed_signature(call)
  File "C:\Program Files\Python38\lib\site-packages\fastapi\dependencies\utils.py", line 248, in get_typed_signature
    typed_params = [
  File "C:\Program Files\Python38\lib\site-packages\fastapi\dependencies\utils.py", line 253, in <listcomp>
    annotation=get_typed_annotation(param, globalns),
  File "C:\Program Files\Python38\lib\site-packages\fastapi\dependencies\utils.py", line 265, in get_typed_annotation
    annotation = evaluate_forwardref(annotation, globalns, globalns)
  File "C:\Users\llc\AppData\Roaming\Python\Python38\site-packages\pydantic\typing.py", line 54, in evaluate_forwardref
    return type_._evaluate(globalns, localns)
  File "C:\Program Files\Python38\lib\typing.py", line 518, in _evaluate
    eval(self.__forward_code__, globalns, localns),
  File "<string>", line 1, in <module>
NameError: name 'Item' is not defined

and i read the souce code https://github.com/tiangolo/fastapi/blob/0.70.0/fastapi/dependencies/utils.py#L247 :
...
def get_typed_signature(call: Callable[..., Any]) -> inspect.Signature:
    signature = inspect.signature(call)
    globalns = getattr(call, "__globals__", {})
    typed_params = [
        inspect.Parameter(
            name=param.name,
            kind=param.kind,
            default=param.default,
            annotation=get_typed_annotation(param, globalns),
        )
        for param in signature.parameters.values()
    ]
    typed_signature = inspect.Signature(typed_params)
    return typed_signature
...

def get_typed_annotation(param: inspect.Parameter, globalns: Dict[str, Any]) -> Any:
    annotation = param.annotation
    if isinstance(annotation, str):
        annotation = ForwardRef(annotation)
        annotation = evaluate_forwardref(annotation, globalns, globalns)
    return annotation

...

@login_required is decorated by @app, as a result globalns = getattr(call, "__globals__", {}) not included Item and annotation is str in __future__ annotations environment.
So what should I do？
Operating System
Windows
Operating System Details
windows 10
FastAPI Version
0.70.0
Python Version
3.8.5
Additional Context
No response

This doesn't directly solve your problem, but instead of using a decorator, you could add a dependency to check the logged in user:
def get_logged_in_user(req: Request) -> User:
    """Get the logged in user info, otherwise raise 401 unauthorized"""
    # get session from cookie, or Bearer Token
    # maybe even the built-in http auth basic stuff, https://fastapi.tiangolo.com/tutorial/security/simple-oauth2/
    user: Optional[User] = get_user(req)
    if not user:
        raise HTTPException(401)
    return user

@app.post("...")  # could also put Depends in dependencies=[] here if you don't need the user object
def create_item(item: Item, user: User = Depends(get_logged_in_user)):
    ...

I think this probably the preferred way to do it, even

Thanks. I added to my project __extra_globals__ attribute. It's not a good idea, but it works.
...

func_globals = getattr(call, "__globals__", {})
func_globals.update(**getattr(func, '__extra_globals__', {}))

...

# jwt_tools.py
from functools import wraps

def login_required(func):

    @wraps(func)
    def wrapper(*args, **kwargs):
        print('login')
        return func(*args, **kwargs)

    # copy __globals__
    wrapper.__extra_globals__ = getattr(func, '__globals__', {})
    wrapper.__extra_globals__.update(**getattr(func, "__extra_globals__", {}))

    return wrapper


[Feature Request] Wikia Search

Hello! I'd like to request something similar to #263 but for searching a specific Wikia instead.
Sample usage:
~wikia wikia-target some-query
The above would search for "some-query" on http://wikia-target.wikia.com, and return the first result.
I think one possible way of doing this would be using regex or substitution and having the bot spit out:
http://wikia-target.wikia.com/wiki/Special:Search?search=some-query
Thank you!

#745
Added a wikia command like
~wikia target query
Hopefully Kwoth approves :3

Yea this has been implemented by @fkndean - thx


Upgrade to evdev 0.12.0

Upgrade evdev crate

Strange issue: this upgrade seems to cause rfkill to soft-block all wifi and bluetooth devices when swhkd runs. This is so strange, since it didn't do that in the last version. Should I report this upstream, or is this an issue with how swhkd interfaces with evdev that's causing this?
Since both PathBuf and Device types are now passed as part of evdev::enumerate() perhaps dropping one of those arguments causes something strange to happen? Like I said, I'm not totally sure what the issue is here, I'm just giving my (probably uninformed) two cents.

Thanks for your contribution!
This looks good to me, I will check a bit more thoroughly later.
Regarding the rfkill issue, I have two ideas for the cause:

Changes from evdev 0.11.4 to 0.12 (there are quite a few changes if you take a look at the code)
Changes on our side, maybe from #163?

Could you try your changes before #163 was merged (checkout commit fdf5e10) and check if you still have the rfkill issue?

Good call! Coming up!


[ANCHOR-804] Make the fields of the SEP31 /info endpoint optional

The fields object of the SEP-31 /info response is optional. However, the stellar-anchor-tests requires it.
Modify the stellar-anchor-tests to optionally check the fields of the SEP-31 /info response.

Preview is available here:http://stellar-anchor-tests-pr154.previews.kube001.services.stellar-ops.com/


Replace actix-web with axum

Closely mirrors https://github.com/kube-rs/version-rs/pull/7 in approach - pending feedback on that PR, I will propagate any required changes here prior to taking this one out of draft.

Ah, this PR is somehow smaller! This is great, and I appreciate the work here a lot, but I wonder if it's worth keeping one of these repos on actix-web for now. A large part of the rust community knows actix better than axum, it has tons of extensions, and is battle tested in production (with a book on it also). So thinking it's probably worth sticking to the beaten path on this larger example repo :thinking:

That makes sense to me!


hci_usb device recognition fails on the nucleo_wb55rg board.

Is your feature request related to a problem? Please describe.
Route: zephyr/samples/bluetooth/hci_usb
Board: nucleo_wb55rg
I built this sample program and flashed it to the board.
The device is recognized normally but is marked as unavailable.

This device cannot be started. (Code 10)
This is an unsupported request.

Describe the solution you'd like
I want to use it as a bluetooth dongle and test it.
Additional context

Is this nucleo_wb55rg board not supported?

This is expected behaviour on windows as it does not support devices bluetooth LE only radios and requires classic to be at least supported.

This is expected behaviour on windows as it does not support devices bluetooth LE only radios and requires classic to be at least supported.

Are you saying that this function is not available for Windows?
Or does the board itself not support USB dongle function?

A windows issue, try the device on linux. @jfischer-no can't seem to find the issue where this was discovered with bluetooth LE only devices not working on windows, do you remember where it was?

A windows issue, try the device on linux. @jfischer-no can't seem to find the issue where this was discovered with bluetooth LE only devices not working on windows, do you remember where it was?

I don't know about that.
Windows seems to have a lot of bad issues.
Any solution to this problem?
Is it only available on Linux?

Here it is: #23866

Thank you for answer.
It was a great help in understanding the problem.

Would suggest using bluetoothctl from the command line instead to see if it works

bluetoothctl작동하는지 확인하기 위해 대신 명령줄에서 사용하는 것이 좋습니다.

I used 'bluetoothctl'.
The action seems to be working normally.


References in Nuxt setup

Resolves #94
@illright
The cause of the issue was not exactly in the Nuxt setup. The problem was that compilerOption.paths specified in config extensions ("extends": "./.nuxt/tsconfig.json") were not resolved and thus path aliases like @/, ~/ didn't work.
So such paths from extensions were applied to the FSD root.
 {
     "~": [
        ".."
      ],
      "~/*": [
        "../*"
      ],
      "@": [
        ".."
      ],
      "@/*": [
        "../*"
      ],
}

I made changes to transform such paths from ../* to /* and then apply them to the root.
Nuxt setup extends a default config from the .nuxt folder it helped us to uncover this issue.
Sorry for the delay!

Got it, yes, let me resolve the conflicts first. Then I'll fix the function and also now I see some other flaws of my solution

@illright
I fixed the first issue that we discussed in the morning by always transforming compilerOptions.paths to absolute, so now we're not afraid of losing context what Steiger is launched from the folder other than the one where the initial tsconfig is put.
Regarding the 2nd problem
https://stackblitz.com/edit/nuxt-starter-ap1c4y?file=README.md
How to reproduce
When /src/features/session/logout/index has .js extension. It reports this diagnostic, from which we can see that the file is noticed by the tool.

When /src/features/session/logout/index has .vue extension. It reports the following diagnostic, from which we can see that the tool does not see that the file is imported in other files.

Don't forget to wrap/unwrap the code inside /src/features/session/logout/index with <script></script> when changing extensions
You can temporarily change fileExists, directoryExists parameters from these:

to these

(I made that change locally for insignificant-slice)
Then you'll be able to see how it goes through different possible options (like .../logout.ts, .../logout.js, .../logout/index.ts, .../logout/index.js, etc) and then fails when runs out of further options

resolveDependency from .../steiger-plugin-fsd/src/_lib/resolve-dependency.ts uses resolveImport from @feature-sliced/filesystem. It looks like we need to add some wrapper in resolveImport to add .vue extension case. Also, maybe we need to create space to gracefully add more custom extensions, but I'm not sure it's inside the score of the task, we can create a quick fix and an issue to design and implement a module responsible for custom extensions


What version is the latest stable?

On Installing the package with either the console or package manager results in version 0.5 being installed. But with that version installed ( at least in VS 2022 RC1) the attribute [GenerateBuilder] is NOT recognized.
I went back to 1.5 and decorated three classes in my Domain project with the [GenerateBuilder] attribute (which is recognized with that version installed) but on Build, nothing is generated

BTW... Great course and presentation on automated testing on Pluralsight. You should do another.

Well, so much for notifications working. Sorry I didn't see this earlier. I would love to do another course, specifically one on source generators. We'll see what they say. Let me look into your other question. I sort of stopped working on this while I waited for the tooling to stabilize a little more, but I should be able to get back to it soon. It does appear that NuGet.org is still serving v0.5. Let me see if I can get v1.1 up there for you.

I just pushed v1.1.0 to NuGet. I think what happened here is a simple version numbering problem. My publish script was still using v0.5.0. The contents may have been correct though. When I last worked on this, I was trying to get GitHub actions in place to do the publishing for me, and I think that's where it all went wrong. Anyway, I manually pushed v1.1.0 just now, so you should be all caught up. I'm about to dive back into this as my primary side project away from work in order to see whether Visual Studio's support has gotten any better in the last few months. That was the major stumbling block at the time.

I’ll try it later when I’m home thank you for doing it
Get Outlook for iOShttps://aka.ms/o0ukef

From: Mel Grubb @.>
Sent: Sunday, October 31, 2021 11:18:21 AM
To: MelGrubb/BuilderGenerator @.>
Cc: Tom Donino @.>; Author @.>
Subject: Re: [MelGrubb/BuilderGenerator] What version is the latest stable? (#6)
I just pushed v1.1.0 to NuGet. I think what happened here is a simple version numbering problem. My publish script was still using v0.5.0. The contents may have been correct though. When I last worked on this, I was trying to get GitHub actions in place to do the publishing for me, and I think that's where it all went wrong. Anyway, I manually pushed v1.1.0 just now, so you should be all caught up. I'm about to dive back into this as my primary side project away from work in order to see whether Visual Studio's support has gotten any better in the last few months. That was the major stumbling block at the time.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMelGrubb%2FBuilderGenerator%2Fissues%2F6%23issuecomment-955718903&data=04|01||939162d1a301402638e308d99c81ad1a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637712903027071625|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=tuxY0yMJtR1JY0dKjLYKhKb1vO8mPS4X%2FQ4U%2BYkyFDw%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABKTG53UCYPMYHWSRFOYCILUJVM33ANCNFSM5ETQTUSA&data=04|01||939162d1a301402638e308d99c81ad1a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637712903027071625|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=LK4P%2F2x15oYPhPQ9d%2BtL643FqBVHfCp5BGOU8vLUiA4%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||939162d1a301402638e308d99c81ad1a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637712903027081574|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=oXBfEBpZLmkBSOkz%2BmsBslNGskkexzOAVenrcuyiR7o%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||939162d1a301402638e308d99c81ad1a|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637712903027081574|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=oglPL8LurY6NoKwIDP7u0Hu%2FZ25%2Fd6Jf5mMJDiUFJtc%3D&reserved=0.

I could only get it to work locally, but the version coming from NuGet.org was giving me errors. I've de-listed it and re-opened this issue until I can work out what's happened and get a stable version up that I'm happy with. For now, consider 0.5.0 to be the latest stable version. It works, without some of the flexibility I was planning. I just need to figure out what I broke in the last set of updates and get it all back on straight, then I'll be back to getting it in line with where the roadmap said it should be.

Okay, got it. I burned a couple numbers in the process, so I'm having to call it v1.2.0 now. NuGet won't let you reuse numbers... ever, and I made some actual changes along the way, so we'll call it 1.2 and just change the roadmap to move some things to v1.5. Tests are passing again, so I'm re-closing the issue.


After restarting Influxdb Data present on disk but Not queryable

From @singhankur on July 18, 2018 13:5
Influxdb version 1.5.1
index-version = "tsi1"

Influxdb is restarted because of
fatal error: runtime: out of memory, this is caused by some lvl=warn msg="Detected slow query:
after this influxdb service is down, then after restarting the influx via command
sudo service influxdb start
Data for all databases is present in data directory
but for few databases the data is not queryable,
while accessing via query. No result is returned
when the restart happens, for the problematic databases data is only present from the beginning of the day when the influxdb got restarted
Copied from original issue: influxdata/docs.influxdata.com#1723

Duplicate of #10100


feat: Credential Preview screen

This is the initial cut will refine more in the upcoming prs
#86  Background color and logo need to be taken into consideration separately as colors data which we are expecting flutter is color widget are not rendering those values

Signed-off-by: Talwinder kaur<EMAIL_ADDRESS>

Codecov Report
Base: 90.82% // Head: 90.82% // No change to project coverage :thumbsup:

Coverage data is based on head (a0558e4) compared to base (6eb60e9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   90.82%   90.82%
=======================================
  Files          30       30
  Lines         959      959
=======================================
  Hits          871      871
  Misses         52       52
  Partials       36       36

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Change default Parquet writer settings to match arrow-rs (except for compression & statistics)

Which issue does this PR close?
Part of #11367
Rationale for this change
Depending on how we construct our parquet writer settings, we are using a different set of default configurations as outlined here. This PR is the first step in reducing this misalignment.
What changes are included in this PR?
In order of commits:

define a set of datafusion constants based upon parquet (arrow-rs) defaults.
use the constants which are the same in each (a.k.a. no test changes)
use the constants which do change the datafusion defaults, and update tests to match
show the remaining defaults which datafusion is not yet using (a.k.a. what still doesn't match)

Are these changes tested?
Yes.
Are there any user-facing changes?
No, except if anyone is relying upon this configuration misalignment in their code.

cc @devinjdangelo -- I don't recall any reason the defaults for the parquet writer in datafusion were meant to be different than the defaults in parquet-rs. Do you?

cc @devinjdangelo -- I don't recall any reason the defaults for the parquet writer in datafusion were meant to be different than the defaults in parquet-rs. Do you?

The only default we changed intentionally after discussion was compression. I believe all others were intended to inherit the arrow-rs default.

The only default we changed intentionally after discussion was compression. I believe all others were intended to inherit the arrow-rs default.

@wiedld  could you make sure this rationale is documented somewhere (comments and the option's description?)

I restarted the failed pyarrow check as it seemed to be an infrastructure problem

I'll plan to merge this tomorrow unless there are any other comments

Thanks again @wiedld  and @devinjdangelo


P1-add proper instructions in readme

interested

@AndreSlavescu thank you for your interest.
We can work on this together. As a first draft we should aim for including snippets from demo, but step by step. #retrieve in its own section and #rerank in its own, then we can add response analysis, eval, writing results, etc.

@AndreSlavescu I think if you could add a short paragraph on package installation, and running one of the demos, we can mark this as complete:
something like:
try it out:
install
pip..
run demo:
python ...


What is the expected behavior for --ignore-errors=true

I'm getting an error during set phase with below details:
message = "socket hang up"```

Is that dataset won't be transferred because of that error during set phase?
I've huge data, is there any way to configure so it won't throw that error?

Thanks!

--ignore-errors only ignores errors in parsing or retrieval.  This kind of error, as you point out, happens at the initial connection... so I'm pretty sure the whole application will exit.

--ignore-errors only ignores errors in parsing or retrieval.  This kind of error, as you point out, happens at the initial connection... so I'm pretty sure the whole application will exit.


feat(test): move wait_sshd() func to RemoteClient

Move wait_sshd() func to RemoteClient to avoid defining
this function multiple times in different platforms
Removed obsolete test_config.yaml

How to categorize this PR?

/kind test
/area os
/os garden-linux
What this PR does / why we need it:
Move the multiple used wait_sshd() func in different test platforms to RemoteClient.
Which issue(s) this PR fixes:
Fixes #715
Special notes for your reviewer:
Successfully retested chroot and kvm after change.
Release note:

NONE

Also added counter logic (more in https://github.com/gardenlinux/gardenlinux/issues/715#issuecomment-1078772345).
r4r


GUI enhancements

<link rel="import" href="../static/bower_components/iron-ajax/iron-ajax.html"> should be kept. It is used by some of the Ajax requests (which are in Polymer style).


Unable to play Overcooked 2 online with Pcap2socks

I'm testing Pcap2Socks and Surge Mac Router mode with the same socks5 proxy, the result is that Pcaps2socks failed to get inside the online game while Surge Mac doesn't. It just stucks at the room loading screen.
I've pasted the log with -vv argument, and I also pasted the game's connection urls captured Surge, please check out the attachments below.
Helping me solving this problem is much appreciated.
pcap2socks.log
surge.csv

I found that maybe some connections were closed abnormally due to the reason of time out like <IP_ADDRESS>. It seems there is a bug in the TCP stack which will queue received data from proxy instead of sending back to the source. I will try to take a look at it, but I am a little short of time, I may not be able to fix the issue in time.

Issue confirmed. I have tested Overcooked 2 in Nintendo Switch and found that the error may occurred in an online room.

I presume that the problem is on L9067. The TCP stack used by pcap2socks is immature, duplicates in a short time will not trigger retransmission. And at the same time, pcap2socks believes that the TCP receiving window of the source is 0, so it will not continue to send any packets (even retransmission) to the source. And finally, the connection get reset in L11708 due to time out.

Great! Will you be able to test it in a few days?
By the way, do you have donation option for your project.
I’d like to donate since pcap2socks is running well I want to support it.

在 2021年11月17日，下午9:54，Xie Zhihao @.***> 写道：

Issue confirmed. I have tested Overcooked 2 in Nintendo Switch and found that the error may occurred in an online room.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Yes, I need some time to review codes.
No, pcap2socks does not accpet any forms of sponsorship or donation.
Also, pcap2socks is under MIT license. Any use, modification, distribution of the code is permitted but the author or copyright holders will never take liability or warranty.

Would you like to try to run this build with -vv argument attached again? I may need some extra information to debug.
By the way, which arch of Mac are you using, an Intel (x86) on or an Apple Silicon (aarch64) one?

Still no luck with the new build.
I have both x86 and ARM Mac, the attachment is logged by a x86 one.
pcap2socks.log

Any luck on fixing the bug?

I suppose it is a bug in UDP, since there is no response packets back from the proxy. But I am short of time last weekend, I have not captured the packets and gone through the traffic yet.

Any progress?

No, I have not maintained the code for a long time, and exactly I cannot find the cause of the bug. The issue is marked as help wanted, and someone may fix it.
I am not sure if Ikago works.


Add print image function and connection file to define usb and networ…

…k printers

Hi, thank you for your interest in this project.
I think all those things are out of the project's scope. Providing external objects is the responsibility of the caller. Thus, establishing network connections or decoding images should be done outside of this library.


Intercepting non streaming responses

I tried to make a test case for this using the supertest module, but I was unable to make it show properly. Using the below server implementation I was able to show the problem using curl.
require('express')()
    .use(function (req, res, next) {
        console.log(new Date(), req.originalUrl);
        next();
    })
    .use(require('./index')(function (req, res) {
        return {
            isInterceptable: function () {
                var bool = /intercept$/.test(req.originalUrl);
                console.log(bool);
                return bool;
            },
            intercept: function (body, send) {
                send('intercepting yo!');
            }
        };
    }))
    .use(function (req, res, next) {
        return res.status(200).end('not intercepted!');
    })
    .listen(8888, function () {
        console.log('listening on port 8888');
    });

Expected result:
$ curl http://localhost:8888/
not intercepted!
$ curl http://localhost:8888/intercept
intercepted yo!

Actual result:
$ curl http://localhost:8888/
$ curl http://localhost:8888/intercept
intercepted yo!

Turns out that the non streaming responses is swallowed in the current implementation. The following change to the server fixes it:
require('express')()
    .use(function (req, res, next) {
        console.log(new Date(), req.originalUrl);
        next();
    })
    .use(require('./index')(function (req, res) {
        return {
            isInterceptable: function () {
                var bool = /intercept$/.test(req.originalUrl);
                console.log(bool);
                return bool;
            },
            intercept: function (body, send) {
                send('intercepting yo!');
            }
        };
    }))
    .use(function (req, res, next) {
        res.status(200);
        res.write('not ');
        res.write('intercepted!');
        res.end();
    })
    .listen(8888, function () {
        console.log('listening on port 8888');
    });

I had a lot of trouble working with the test suite. I'd like to send a pull request rewriting it to use https://www.npmjs.com/package/unexpected-express if you would like to see the difference between the current test suite with supertest and unexpected-express. Just let me know and I'll shoot a PR - no strings attached :-)

Hi @gustavnikolaj, absolutely if you have it in hand please PR it over so @p1nox and I can check it as soon as we clear sometime!
As a little background we've been working intensively at Sesame CMS that we'll be publishing soon and Raul also has been developing Eilhard which is pretty cool and is coming even sooner.

Awesome @gustavnikolaj! Indeed, we will check it out as soon as we have some time to spear, you are welcome to submit a PR :+1:.

Pull request is sent, and referenced above. Besides the rewrite, it also fixes this problem.

I can make a fix for this using your current test suite, now that I've been able to diagnose the problem.
Your current test suite can actually show the problem quite easily. Just replace all occurrences of res.text with res.body and you have some failing tests because of this.
The problem is that you throw away the chunk passed to res.end, here: https://github.com/axiomzen/express-interceptor/blob/master/index.js#L62
res.text is a buffered version of res.body that the http request library superagent introduces (https://github.com/visionmedia/superagent/blob/master/lib/node/parsers/text.js). supertest  uses superagent internally to do the requesting. This ends up masking the problem in your current test suite. res.text is fine as a convenience method in a http client library, but it is dangerous in an assertion library, at least in libraries like this one where you are having to play tricks on express and the response object.
Unexpected Express works better in this case, as it is not mangling the response object at all. It serializes the response object, and then goes on to parse it the stuff that would have been transmitted out over the network. That turns out to be more trustworthy and fitting for this use case. And I'd argue that it is a better fit.

Thank you @gustavnikolaj for the insights, reading it makes sense, i'll review your PR and go deeper on the logic over the weekend.

Sorry still didn't have the time, my girlfriend left this week, it was busier than i thought, by latest this weekend now.

Take your time :-) This issue is not blocking me for working on anything at the moment.
If you would like to, we can find a time where we can talk about the PR. Or even review it together if you prefer that. I'm out on the country side this weekend, and I'm in Denmark, and you're in Canada. So it might take a little coordination. I'm usually on gitter.im/unexpectedjs/unexpected - and you're welcome to reach out on mail too<EMAIL_ADDRESS>Let me know if I can be of any assistance.

Thanks for the understanding Gustav, you are a utopic collaborator. Yesterday was my last day on the job (taking a break now), and on top of that, we hosted a hackaton the whole weekend. Now I'm winding down on commitments and will have it reviewed soon.

Hi @flockonus. Do you have any update on the situation? :-)

Hi @gustavnikolaj not yet my friend! After changing countries and entering a code-free vacation, i'll be reviewing your PR this week and evaluating how the important changes will influence streaming (which sounds pretty exciting and doable). Then i'll submit a PR for you and @p1nox to review.

Thanks @flockonus, that would be awesome :feelsgood: :+1:

@flockonus I thought that this was #24 actually - I was mistaken about the context. I only just noticed now, so I thought I'd mention it.
I would be glad if you would review #24 first. I know how to fix both this and #25. The unexpected-express testing tools are way more effective at testing these kinds of things than supertest. If you like what you see in #24 I'll be more than happy to contribute PR's for a fix for this problem as well as #25, and any other things you might struggle with.
I'll take a look at the PR tonight, to see if there's anything that needs an update - it's been laying around for a while :-) But it will be insignificant nitpicks if anything.

Oh, I forgot that I landed the fix for this issue in #24. Sorry about that! It's been a while, so I forgot :-)

Fixed when https://github.com/axiomzen/express-interceptor/commit/1a8716269733037a3645e9a5a743c1716ac0a946 was merged today

Awesome, thanks @gustavnikolaj!

:+1:


Can't completely hide the label on success

If an element is valid, I want its label to be hidden, so that it doesn't take up space. Currently, this seems to be impossible.
My first attempt was to use the success option to set a CSS class with display: none;. My second was, within the success callback, to explicitly call hide().
Both of those fail because the success callback is called in the middle of defaultShowErrors, which ends by doing this: this.addWrapper( this.toShow ).show();. So in all cases, the label is shown.
My final attempt was to use the showErrors callback to do something like this:
  showErrors: function(errorMap, errorList) {
    this.defaultShowErrors();
    // after the label is shown, hide it again

But this won't work, because if the element is valid, neither errorMap nor errorList contains a reference to find the element and the label again.
As a workaround, I modified the plugin myself as follows: at the end of defaultShowErrors, I checked a custom setting and re-hid the error.
      var error = this.addWrapper( this.toShow ).show();
      if( !this.errorList.length && this.settings.hideLabelOnSuccess) {
        error.hide();
      }

Is there a better way to do this? If not, is this a sensible modification to contribute back? It doesn't seem ideal to add another setting, but this is the best solution I have so far.
(The "shouldn't take up space requirement is my input is inside a table cell as part of a grid of calculations, and I'm putting the error message directly underneat the input inside the cell.)

Just wanted to point out 6 years later and now I am also trying to solve this problem.

i think this will help for you.
success: function (element) {             $(element).closest('.form-group').removeClass('has-error');             element.remove();             }

Just wanted to point out 6 years later and now I am also trying to solve this problem.

and 2 years after your comment i'm looking for solutions too :'D


Edit ListEntityPlugin such that it extracts patterns from cls_feature instead of alternatives

Is your feature request related to a problem? Please describe.
Yes.
I want to write a custom plugin to apply some transformations to the ASR transcriptions. It is much easier for me to work with the clf_feature (as it is a simple list of strings) rather than alternatives( can be List[List[Dict[str, Any]]], List[Dict[str, Any]], List[str] or str). However, ListEntityPlugin takes the alternatives as input. So the entities will be extracted from the original input instead of the transformed input.
Describe the solution you'd like
Edit ListEntityPlugin such that it extracts patterns from cls_feature instead of alternatives. This will help writing transcription transformations easier.
Describe alternatives you've considered
Currently, I'm editing the alternatives themselves
Additional context
No.

We would hope to have better LM tuning tools so that ASR transcript tweaks become an afterthought :)


Write a complete test suite

This is quite a high priority one since the code base is untested at the moment (I'm manually testing things in a workbench application).
Here's everything the test suite should cover:

Adding Orbital to a model.
Changing the primary key on a model.
Changing the driver for a model.
Changing the name of a model's content directory.
Creating new models and writing files to disk.
Updating existing models and updating files on disk.
Deleting models and removing files from disk.
Soft deleting models and updating deleted_at.
Check that all events are dispatched correctly.
Write tests for the Git suite (?)

Closed by #12.


How to get start?

@sthalles Hi, thanks for your blog and codes.
I have some questions since I am a green hand. I followed the README.md and finished downloading the datasets. But I don't know how to go on with next work. Could you please tell me the next steps? I don't understand the steps in README.md very much.
Thank you!

I have the same trouble with you！Don't know how to start the project.


Sometimes (usually at night ), the bot doesn't work

I don't know exactly when or under what circumstances, but sometimes usually at night, the bot doesn't work at all (neither retweet nor like)!

Hey!
That's what I'm also very curious about! I have to review logs on the server to see why this happens. I think the bot misses tweets. It may be caused by:

Broken connection
Process Manager (pm2) fault
Twitter stream doesn't send all tweets to my client

I just noticed something weird that may be related to this bug. Twitter didn't suggest me hashtag "برنامه_نویسی" when I was writing a tweet.


Typo "Postgres Hyperscale"→"PostgreSQL Hyperscale"

https://docs.microsoft.com/en-us/azure/azure-arc/data/create-postgresql-hyperscale-server-group
https://github.com/MicrosoftDocs/azure-docs/blob/main/articles/azure-arc/data/create-postgresql-hyperscale-server-group.md
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off


Update Build Settings

Make Overture available in app extensions
Disable testability in Release configuration

Nice catch! Looks good to me!


Bug 2186443: remove storageClassClaim and add new storageClassRequest CR

see individual commits

@iamniting @Madhu-1 @nb-ohad @rewantsoni ^^

golangci lint errors are not coming from my changes so not making part of this pr since it is already a big pr. Thanks

/bugzilla refresh

@subhamkrai Can you look at the failures?

@subhamkrai can you please check @iamniting comment?

/bugzilla refresh

@iamniting ptal


s.th. wrong with the toolbar

hi,
I just tried to use react-quill, but something is not quite right with the toolbar:

also I get this console warning:
Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of Quill Toolbar. See https://fb.me/react-warning-keys for more information.

here's how I use it:
<ReactQuill
	name='bio'
	value={this.state.form.bio}
	onChange={ function(value) { that.handleChangeRichtext('bio', value) } }
/>

not sure what I'm doing wrong here...

Hi, let me ask you a few questions to be sure:
Are you using the distributable dist/react-quill.js or browserify/webpack?
Which version of React and React-quill are you including?
Can you compare your implementation with this one? http://zenoamaro.github.io/react-quill/

I'm using browserify.
<EMAIL_ADDRESS><EMAIL_ADDRESS>will have a look at the demo after lunch.

Is it possible that you aren't including Quill's stylesheet? I admit the documentation is not clear at all about this requirement.
<link rel="stylesheet" href="../node_modules/quill/dist/quill.snow.css">

About the key prop warning: yes, it's the toolbar separators, which I haven't found a good key for yet. It's a harmless warning though. It doesn't appear when building for production, and you can safely ignore that for now. I'll try to fix that somewhere in the next few days.

you're right, I hadn't included the original quill files. that and setting theme='snow' did it for me. — thanks!

Thanks, I'll add a note for that in the docs later!


Expose DefaultThreadFactory.threadGroup to sub-classes

Motivation:
DefaultThreadFactory allows to override the newThread(...) method and so should have access to all fields that are set via the constructor.
Modifications:
Change threadGroup from private to protected visibility.
Result:
Easier to extend DefaultThreadFactory.

lgtm

Cherry-picked into 4.1 (8ccc795) and 4.0 (35576de9a2fde0e454d53c926701f0689b77670e)


uv version command

Hi uv team,
I really don't know if an issue is the right place for what I have to say, but actually,
I did not find something more appropriate at the moment.
uv provides command uv --version (or -V) for short and also a uv version subcommand.
that uv version command is redundant and does not work as expected (to me).
Since I am trying to migrate one project from poetry to uv, and a poetry early adopter,
I may be biased.
I expect that uv version should be here to manage the pyproject.toml version, and,
I don't find any way to deal with my package version using uv.
I would like to have something like this:
$ uv version --help
Display the version of the project or increment it for release purposes.

Usage: uv version [OPTIONS] <increment>

Options:
      --short Display only the version number

Increments:
  major      Increment major version of the project (foobar 0.1.0 -> foobar 1.0.0)
  minor      Increment minor version of the project (foobar 0.1.0 -> foobar 0.2.0)
  patch      Increment patch version of the project (foobar 0.1.0 -> foobar 0.1.1)
  premajor   Increment major version and add a pre-release identifier (foobar 0.1.0 -> foobar 1.0.0a0)
  preminor   Increment minor version and add a pre-release identifier (foobar 0.1.0 -> foobar 0.2.0a0)
  prepatch   Increment patch version and add a pre-release identifier (foobar 0.1.0 -> foobar 0.1.1a0)

The version manipulation can be used at scripting, for example, coming from my personal projects,
I use a Jusfile with those simple rules:
release major_minor_patch: test gh-pages && changelog
    poetry version {{major_minor_patch}}
    poetry install

publish:
    git commit -am "Release $(poetry version -s)"
    poetry build
    poetry publish
    git push
    git tag "$(poetry version -s)"
    git push origin "$(poetry version -s)"

Are you looking for #6298? Might be the same.

Completly this !
I am confused.
It seems like I'm bad at searching in the issues.


VS2017RC - Icons missing in completion lists

VS2017 RC doesn't display icons next to items in completion lists
Appropriate Namespace/Type/Property/Method icons were shown since VS2005
Repro steps
Complete System.Collections..
Expected behavior
Icons such as {} for namespaces are shown next to completion items
Actual behavior
No icons are shown

Fix ready as part of https://github.com/Microsoft/visualfsharp/pull/1829

Fixed


Creates predict route

Takes json and returns a subreddit.

Looks good man. Nice. Nomenclature for home_routes is the only comment. Maybe predict route? Doesn't matter anyway we only need one. Solid work


⚠ Slack has degraded performance

In a8904e2, Slack (https://status.slack.com/api/v2.0.0/current) experienced degraded performance:

HTTP code: 200
Response time: 241 ms

Resolved: Slack performance has improved in b0f8376 after 10 minutes.


Viewport cull mask and canvas item visibility layer not working

Tested versions
4.2.stable
System information
Windows 10
Issue description
Canvas item with layer other than 1 cannot be seen unless "Canvas Cull Mask" value include layer 1.
Looks like setting any value without the layer 1 active on a viewport just hide everything.
Note :
My guess is that there is an issue with how the cull flag are handled, the value may be tested as a bool somewhere.
EDIT
After more test i found the issue, the layer visibility from parent taken into account, children are not tested if layer visiblity test fail in parents
Steps to reproduce
Change Visibility Layer of Canvas Item to something else than 1.
Try changing the value of Canvas Cull Mask of your viewport
Minimal reproduction project (MRP)
ViewportVisibilityLayers.zip

Can you please try with 4.2.2 to make sure this hasn't already been fixed in a supported version

@JonqsGames This is not a bug and the intended behavior. It's a bit monotonous, but there is no inherit-visibility-layer setting, so each canvas item and every one of its decedents needs to be set explicitly to the visibility layer it should show on. If you have a good proposal though for a better workflow, I'd love to take a look!

In this case, I think default value of Visibility Layer should be "all value ticked".

Made the proposal but maybe the real solution is to have two value like "modulate" and "self_modulate" or even have a similar behavior than for 3D (the case is different because all 2d item are CanvasItem but not all Node3D are VisualInstance3D)

You can enable top_level to make child nodes' layer independent.

Perhaps it'd be better to have an inherit-from-parent dropdown like some of our other settings that would disable or ignore the set visibility layers? You would probably have the same amount of setup as all the other ideas, but while we couldn't add it as default without breaking compatibility, you could set it on all your nodes generally without having to keep track of specific layers and be able to reparent it to another viewport without having to change anything.
I may be missing some context, but that sounds like a more reasonable and familiar workflow. If popular, we could make it the default eventually.

@markdibarry Mentionned that solution but i think it may be more complex to implement and i disagree on what the default behavior should be.
I understand that all CanvasItem are kind of visual (mainly due to possibility of Y sorting) but i think the behavior should be the same than for the vsual layer in 3D.
Here is an update of the reproduction project to show the difference between 2D and 3D:
ViewportVisibilityLayers (2).zip
My final point on this matter is that right now i'm not sure that anyone is using this, most people watch tutorial and online ressource that push to other solution (Have two separate worlds, using RemoteTransform2D ...). So i think the behavior should be change, i made the simplest proposal but any other solution that prevent me from checking the whole arborescence to check the right layer will be good for my usecase.

I may be underestimating (I usually am), but I don't think it'd be that complex to implement (I also might just be getting excited about a smoother workflow for parallax :laughing: ). Since visibility_layer is handled on one line in the culling, the harder part would just be making the dropdown option:

I think it'd be worth having an easier workflow for visibility, but you're right about 2D and 3D being just so crazy different in their whole workflow. From looking around the UI it feels like any attempt to align is gonna lead to a ton of more problems. For example, visibility is handled on a per-node basis (any canvas item) for 2D via "visibility layer", but it's handled specifically on the Camera3D node via "cull mask". I'd be interested to know what all would need to change to make the workflows look intuitively similar, but my guess is a lot. :melting_face:
I think it's worth exploring the inheritance method since it fits into our current concepts in other nodes, and for your scenario, you'd just need to change the value of one node. Then again, I could be totally missing something, but at least for split screens this would make the workflow pretty nice rather than having to go through all decedents and change them to the specific layer.

As mentionned in #93335 i think #93351 is not solving the issue but if the inheritance is the intended behavior, it would have helped me finding why my layer was not working.

Oh for sure. It's just a non-compatibility-breaking start we can put in place until we flesh out a long-term solution.

Can anybody explain the reasoning behind visibility layers depending on inheritance to begin with? I would have expected it to work like other bitmask settings, and just search the whole tree, rendering or not rendering nodes according to their individual settings, completely ignoring the hierarchy. Any other default behavior seems very counterintuitive.

Principle of rendering in 2D is a bit different, in 3D we have depth sorting but in 2D rendering order is done by exploring the node tree downward. There is option to mitigate that (See Ordering parameters of a CanvasItem) and option to handle things differently called Y-Sorting.
That's why the simplest solution was choosen for that: using inheritance. In the current implementation if VisibilityLayer test fail, the downward exploration stops (and the whole branch is ignored).
So to have the behavior you describe, a big change in the way node are rendered would be needed. That's why for now keeping inheritance maybe easier.

My main problem with this is when I want to make a minimap. Each entity has 2 children: the detailed representation, and the icon representation. I just left visibility layers as they are. However, now I want to make the minimap exclusively renders icons. In order to do that, I have to set icon child to another layer. But then, godot said this:

A Viewport will render a CanvasItem if it and all its parents share a layer with the Viewport's canvas cull mask.

Which means now I have to go back and track every node that is ancestor of every icon, add another tick to the new layer. That is not possible since my project grew large AFAIK, and it would be the equal of modify every scene.
If anyone has found a solution or a reasonable workaround, I would love to know.

Why does your minimap need a detailed representation if you only render icons?

The minimap only has icons, indeed. But the real world (which renders via main camera) has a detailed representation for characters, enemies, .etc.
By the way, I decided to manually turn on the other visibility layer for all ancestors of icon nodes. It was fast. But firstly, my project was small so I can't tell the same for other people. Secondly, it's still very error prone, for example I might forget to tick the minimap layer for the next entity I make.

@Ryu204 Why does your minimap reuse the main camera then?
I have a minimap in my own game. Two ways of doing a minimap in Godot are a 2nd camera that only renders certain visibility layers OR a 2d control with icons under it that you control yourself via code (can be a camera2d, can be just some transform magic and normal controls, depends on how many entities you want on the minimap)

Why does your minimap reuse the main camera then?
No, it does not. I use second camera for that. This is what I am doing:

Create a camera and put a SubViewportContainer > SubViewport as its parent
Modify the SubViewport's canvas cull mask so it contains 2 layers: Layer 1, and another layer for the minimap (layer 2)
Modify a lot of scenes to contain layer 2 in their visibility settings as I mentioned above

@Ryu204: Neat trick to automate the last bullet point is to put scenes that you want to show on minimap in a separate group. And then write a two-liner of GDSCript that says if in group minimap then set layer 2

Oh that's definitely helpful. Thank you :)


convert object  all keys to String

hm, what's the motivation behind this?

Closing due to inactivity.
Feel free to reopen this if needed.


Changes to SPOnline cmdlets to PnPOnline

Thanks for the PR
is there a specific version that changed the naming of the cmdlets ?
that might be a good thing to add in the description


StateHistory

Describe the feature in detail (code, mocks, or screenshots encouraged)
Hi, thank you so much for this great utility.
Whenever I use an object state with StateHistory I don’t get full history for deep properties.
You can try the buttons on the top of this page to test it as I initiated the StateHistory with the form schema
https://svelte-form-builder.pages.dev/
What type of pull request would this be?
None
Provide relevant links or additional information.
No response

I read your comment on another issue about using snapshot to follow and understand how Svelte 5 works.
I used $state.snapshot and it works as expected 👍🏻
Thank you.


Clash of scopes in JavaScript

Definitions in the context scope interfere with definitions in the submission scope
Example: submission

Also: drop the first line of the exception as it is also repeated as the header of the stack trace.

Also: cleanup the stack trace up the point where it leaves the submission by the student.


Cannot codesign Alamofire (exit code 1)

Hello, I'm trying to integrate Alamofire into my Swift4 app, but when building the app, Xcode shows the following error.
PhaseScriptExecution [CP]\ Embed\ Pods\ Frameworks /Users/nickgaens/Library/Developer/Xcode/DerivedData/Emprova_Swift-bbvmoytlhlbqpueyftstselvwhdj/Build/Intermediates.noindex/Emprova\ Swift.build/Debug-iphonesimulator/Emprova\ GPS\ Swift.build/Script-AB9553D032B10870946A74DA.sh
    cd "/Users/nickgaens/Documents/Emprova iOS Swift"
    /bin/sh -c \"/Users/nickgaens/Library/Developer/Xcode/DerivedData/Emprova_Swift-bbvmoytlhlbqpueyftstselvwhdj/Build/Intermediates.noindex/Emprova\ Swift.build/Debug-iphonesimulator/Emprova\ GPS\ Swift.build/Script-AB9553D032B10870946A74DA.sh\"

mkdir -p /Users/nickgaens/Library/Developer/Xcode/DerivedData/Emprova_Swift-bbvmoytlhlbqpueyftstselvwhdj/Build/Products/Debug-iphonesimulator/Emprova GPS Swift.app/Frameworks
rsync -av --filter "- CVS/" --filter "- .svn/" --filter "- .git/" --filter "- .hg/" --filter "- Headers" --filter "- PrivateHeaders" --filter "- Modules" "/Users/nickgaens/Library/Developer/Xcode/DerivedData/Emprova_Swift-bbvmoytlhlbqpueyftstselvwhdj/Build/Products/Debug-iphonesimulator/Alamofire.framework" "/Users/nickgaens/Library/Developer/Xcode/DerivedData/Emprova_Swift-bbvmoytlhlbqpueyftstselvwhdj/Build/Products/Debug-iphonesimulator/Emprova GPS Swift.app/Frameworks"
building file list ... done

sent 94 bytes  received 20 bytes  228.00 bytes/sec
total size is 0  speedup is 0.00
Code Signing /Users/nickgaens/Library/Developer/Xcode/DerivedData/Emprova_Swift-bbvmoytlhlbqpueyftstselvwhdj/Build/Products/Debug-iphonesimulator/Emprova GPS Swift.app/Frameworks/Alamofire.framework with Identity -
/usr/bin/codesign --force --sign -  --preserve-metadata=identifier,entitlements '/Users/nickgaens/Library/Developer/Xcode/DerivedData/Emprova_Swift-bbvmoytlhlbqpueyftstselvwhdj/Build/Products/Debug-iphonesimulator/Emprova GPS Swift.app/Frameworks/Alamofire.framework'
/Users/nickgaens/Library/Developer/Xcode/DerivedData/Emprova_Swift-bbvmoytlhlbqpueyftstselvwhdj/Build/Products/Debug-iphonesimulator/Emprova GPS Swift.app/Frameworks/Alamofire.framework: bundle format unrecognized, invalid, or unsuitable
Command /bin/sh failed with exit code 1

I'm using Xcode 9.0 beta 2 (9M137d) with the Swift 4-version tied to it, Cocoapods 1.2.1 with Podfile:
platform :ios, '10.0'

target 'Emprova GPS Demo Swift' do
  use_frameworks!

  pod 'Alamofire', '~> 4.5.0'
  pod 'AlamofireNetworkActivityIndicator', '~> 2.2.0'
  pod 'KeyClip'
  pod 'Localize-Swift', '~> 1.7.1'
  pod 'FMDB'

end

target 'Emprova GPS Swift' do
  use_frameworks!

  pod 'Alamofire', '~> 4.5.0'
  pod 'AlamofireNetworkActivityIndicator', '~> 2.2.0'
  pod 'KeyClip'
  pod 'Localize-Swift', '~> 1.7.1'
  pod 'FMDB'

end

I have not touched any pod, so they're all in a default state.

I have created a StackOverflow question in regard to this issue. "Xcode 9 fails to build Swift 4 project with Alamofire pod" on StackOverflow

This was all because of having opened my project using the .xcodeproj entry instead of the .xcworkspace entry. I've added this information to the linked StackOverflow question as well.


ES: fix aggregation query size on directory glob matching

Default size is 10: only the 10 "biggest" directories were returned.
Increase that limit to 10.000.

Coverage decreased (-0.08%) to 81.528% when pulling 18609acc99226a4035158a619d4e0ec098554f8b on adericbourg:es_fix_aggr_size into 1c780629b6980da4250e7ce78ac1c9296bd7d9f5 on criteo:master.


Config changes to reflect the default branch from master to main. Please merge to complete the default branch renaming job.

Auto branch renaming content.

Docs Build status updates of commit c6cf3f1:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch 71c51158-183f-48ed-8a28-1cb338d8f5b2 has been deleted or has been force pushed

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add 'yellow' as an alias of 'amber' for TrafficLights

Fixes #345
Not sure if this was the best way of doing this, but as the unit-test shows, it seems to work ;-)

[Current coverage][cc-pull] is 77.21%

Merging [#372][cc-pull] into [master][cc-base-branch] will increase coverage by 0.03%

@@             master       #372   diff @@
==========================================
  Files            28         28
  Lines          4951       4968    +17
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3821       3836    +15
- Misses         1130       1132     +2
  Partials          0          0

Powered by Codecov. Last updated by [a20e035...7a26e6a][cc-compare]
[cc-base-branch]: https://codecov.io/gh/RPi-Distro/python-gpiozero/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/RPi-Distro/python-gpiozero/compare/a20e03527c5d80d6a4abcd046b7bed6a9a47b39c...7a26e6a35665aa6a5a2642a3b7a99263377ae80b
[cc-pull]: https://codecov.io/gh/RPi-Distro/python-gpiozero/pull/372?src=pr

I noticed that TrafficLights.value (and repr) still said 'amber', even when constructed with a 'yellow' kwarg in __init__. The second commit fixes that too.

I'd like to test this out

Rebased...

Heh - I applaud the use of the OrderedDict. Beautiful way of building the device names for everything.
Not so sure I like the __getattr__ stuff - I tend to reserve that sort of thing for when I need to construct properties entirely on the fly (without knowing their names in advance). In this case, I'd prefer to construct the properties with fixed names. I'll see if I can grab your branch and tweak it a bit.

Hah! My own code which prevents CompositeDevice from stomping over pre-existing method / property names prevents manual construction of those properties (seeing as properties have to be class based, and can't just exist on an instance). All that means __getattr__ is pretty much the only way of implementing this.
TL;DR: I'm convinced - this is about the cleanest way this can be implemented.

Heh - I applaud the use of the OrderedDict. Beautiful way of building the device names for everything.

Yeah, I thought it was quite elegant too. Kinda makes you wish that Python's **kwargs could be interpreted as an OrderedDict instead of a dict ;-)  (which would obviate the need for _order)

Yeah - ordering generally implies a loss of performance because it imposes an access order to certain operations (this is a major reason relational databases assume no order to tables unless one is imposed - well that, and it fits with the relational algebra's definition of a relation as a set of tuples).
Interestingly, pypy's later releases (I forget which off the top of my head) use a dict implementation which is ordered anyway (in other words, under pypy, OrderedDict = dict). They even claimed it was faster than their previous implementation. I'm sure they're right but I'm nonetheless intrigued as to how they managed it (haven't had the time to dig into the details). My gut instinct is there must be some trade off somewhere (more memory usage?)


Script blocks on certain points

The script is blocking on certain points, i tried to use it for the story and sometimes it doesn't recognize the next icon on the quest, it doesn't skip the story and it blocks after the quest is completed at the rewards screen after it finishes the quest.
Are those things bugs or are those features not implemented yet?

Oh, the script doesn't recognize story screen, thus it won't proceed normally.
I ..somehow? encourage you to play the story on your own, it's more fun that way.

Oh, yes, i thought it was able to do the story too, my bad ahaha
I hoped that because i'm a NA player and restarting the same story is quite boring, but no problem!
But for the thing that it blocks at the rewards screen? Is it normal?

Well the script will detect pattern of certain location on the screen.
In this case, I guess something on the story screen "triggers" it into the wrong section of the code, so anything could happen.
There's no better way dealing with it, cause FGO's not a PC game, we cannot detect memory to determine which screen we're currently in.
Anyway it could be more interesting after story chapter 4.(I guess)


No lasers

:star: PR built and available in a preview environment carlossg-croc-hunter-jenkinsx-serverless-pr-48 here

/approve


Freesound download buttons link incorrectly

Description

Freesound download results do not work. We should fix this in the catalog, but also add a special exception in the frontend ASAP to link off the Freesound download buttons to the freesound page for the track itself.
Reproduction

Visit any Freesound result: https://wordpress.org/openverse/audio/9af3243a-e4d4-4254-95d9-a3d53a0158c3
Click the download button
Observe the result is the failed API credential page: https://freesound.org/apiv2/sounds/20015/download/

Screenshots

Environment

Device:
OS:
Browser:
Version:
Other info:

Additional context

Resolution

[ ] 🙋 I would be interested in resolving this bug.

We can forward port the solution from https://github.com/WordPress/openverse-catalog/issues/329 in the meantime until the catalog data is fixed.

I think my preference would be to link to the single result Freesound page and let users login or use the download button. It adds a step but I think it's clearer to users than landing directly on a login page.

@zackkrida should we just remove individual format downloads from the audio result page then and always link to the foreign landing url?

@WordPress/openverse How do people feel about temporarily switching all audio download links to just be a single link to the foreign landing URL altogether? Just until we've figured out the exact right way to manage downloadable files and all their metadata that we'd like to show for them.

I am completely fine with that. And also considering switching permanently to open-site only instead of downloading content.

I am new to interfacing with GitHub or, really, knowing anything about it.  But in 29 of the last 30 files I tried to download, I still go the original error.  I tried it on 4 different devices, including a laptop, and different connections--LAN, Wi-Fi, Hotspot, Mobile Data.  I don't know how to fix it on my end because I don't think I fully understand the other part of why it is occuring.

https://search.openverse.engineering/audio/f06095bd-d6d1-4b65-a141-3b3fe0013c85
Also, not sure if it's part of the same thing, related, or different, but almost nothing labeled mp3 is an actual mp3.  I don't know if it's maybe because it is trying to generate labels or something to do with it supposing to be an mp3 but then being in a different format.

Hi @imouse1, if you go to the url you provided now:
https://search.openverse.engineering/audio/f06095bd-d6d1-4b65-a141-3b3fe0013c85
is the behavior different? it should now link to the single result on Freesound where you can use their download button.

Zach,
Yes!  It even showed a button to login.  And after thar I was able to and download it.
Thank you so much!  Is there a formula for how I should change the URL?
Much appreciated!
Mouse
PS--I tried attaching a video to show you but IDK if it did.  Sorry if it shows up twice!

You're welcome. We pushed an update to Openverse today, so this should continue to work for any other Freesound audio files you visit. 😄 Thanks for reporting this bug and using Openverse!


raftstore: always update read delegate's region

Signed-off-by: Neil Shen<EMAIL_ADDRESS>What have you changed? (mandatory)
Always update read delegate's region to avoid stale region info in the localreader. So read delegates always have up to data region when their peer become leader.
What are the type of the changes? (mandatory)

Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)
Unit tests.
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
#2639

Please describe the bug you are trying to fix in the description.

What if the request arrives before region is updated?

It may be handled or rejected by lease, it depends to what kind of changes made to the region.
There are two categories of commands that changes region:

conf changes, they have no effect to read delegates as long as theirs peers are leaders.
split / merge

split: the request maybe handled, because peers of new region that in other store do not start election before theirs election timeout which is longer than the max leader lease
merge: we suspect lease right after prepare merge is committed, so the request is rejected.

PTAL, thanks!

LGTM.

/run-integration-tests


rename test_gpu_miopen

I would suggest rename it to ops.cpp since cmake will add prefix test_gpu_. With the current name, the test name is test_gpu_gpu_ops_test

fixed


python3 compatibility

completely untested, but just so you are aware.

This definitely needs more testing. Also, we should squash the commit.

All tests now pass on this branch, including one that does not pass in the master version