[Issue-2192] Improve attestation prioritization for block proposal

PR Description
Reprioritize attestations as on-chain attestations are processed.  Previously, we prioritized attestations based on total number of set attester bits.  With these changes, we now prioritize by number of attester bits that have not been seen on chain in another block.  This should make it easier to collect high value attestations for inclusion in proposed blocks.
Fixed Issue(s)
Part of #2192
Documentation

[x] I thought about documentation and added the documentation label to this PR if updates are required.

As I understand it, this is reprioritising the attestations within a matching data group - we already do our best to aggregate those so I'm not sure how many attestations with the same data wind up being included in a single block.  Probably the more useful place to prioritise based on new validators is one level up so we pick the MatchingDataAttestationGroup to include in the block based on the reward it would earn.  That would be a function of the number of new validators and the inclusion distance.  Currently we're prioritising most recent first only.

Probably the more useful place to prioritise based on new validators is one level up so we pick the MatchingDataAttestationGroup to include in the block based on the reward it would earn

Yeah, I agree.  I don't think this change ends up being very useful in and of itself and it does add additional processing.  I'm going to close this for now - we can look at a more comprehensive rework of the attestation prioritization when someone picks up #2192.


Update sbt-ci-release to 1.6.1

About this PR
📦 Updates com.github.sbt:sbt-ci-release from 1.5.12 to 1.6.1
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.sbt", artifactId = "sbt-ci-release" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.github.sbt", artifactId = "sbt-ci-release" }
}]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #169.


Correct pr

Metric
Value

alert_status
b:white_check_mark: OK/b

bugs
1

code_smells
48

reliability_rating
B (at least 1 Minor Bug)br/Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)br/Note: A being best, E being worst

vulnerabilities
0


Usage with Cloudflare Tunnels

Is your feature request related to a problem? Please describe.
I'm attempting to use this with Cloudflare Tunnels. The tunnel works fine with an undockerized NGINX reverse proxy and multiple domains. Cloudflared only provides a CNAME for the domain, so this may be the holdup. Encryption at the host isn't necessary as traffic to Cloudflare is still encrypted.
Describe the solution you'd like
Insight on how to forward correctly through the tunnel to the dockerized proxy
Describe alternatives you've considered

DNS verification via Let's Encrypt.
Nginx-proxy/nginx-proxy without Let's Encrypt
Commenting out LETSENCRYPT_HOST to disable SSL in application environments

Commenting out LETSENCRYPT_HOST, exposing only port 80, and ensuring the network matches the application network allows this to function behind Cloudflare Tunnels

Also check #238


[fix #11143] Fix RedundantCopDisableDirective when used with departments

This is a fix for #11143 and #11160, and the issue was introduced in this Opt-In PR: #10987.
It seems like the current implementation of RedundantCopDisableDirective is designed to ignore department-disable comments (based on specs).
The RedundantCopDisableDirective has 2 different reasons to mark a cop disable comment as redundant: it is already disabled, OR there is no reason to disable it since there are no offenses of this type
def each_redundant_disable(&block)
  cop_disabled_line_ranges.each do |cop, line_ranges|
    each_already_disabled(cop, line_ranges, &block)
    each_line_range(cop, line_ranges, &block)
  end
end

The error occurs due to unnecessary cops added in the each_already_disabled block. It only happens when we have 2 or more department-disable comments. If we have less than 2 comments, we never even enter the iteration here:
def each_already_disabled(cop, line_ranges)
  line_ranges.each_cons(2) do |previous_range, range|
    ...
  end
end

The reason people noticed it after #10987 is that this change injects an extra line_range when a cop is disabled via config, and we end up with line_ranges like { “Metrics/MethodLength"=>[-Infinity..1, 1..Infinity], ... } where -Infinity..1 comes from the config (see CommentConfig#inject_disabled_cops_directives), and 1..Infinity comes from an actual # rubocop:disable Metrics/MethodLength comment therefore, we now enter the each_already_disabled loop.
The each_already_disabled is simply not designed to handle departments being disabled, and it does not matter if they come from config or comments. For example, the following example causes errors as well:
# rubocop:disable Metrics
# rubocop:disable Metrics

Ideally, we would want to flag the example above as redundant, but I decided to keep it focused on the current problem. Should I open a separate issue for the simple snippet above?
Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Ideally, we would want to flag the example above as redundant, but I decided to keep it focused on the current problem. Should I open a separate issue for the simple snippet above?

Yes, please.


How to Modify and Deploy Custom ShinyProxy Resources in a Kubernetes Cluster

I have deployed ShinyProxy in my Kubernetes cluster using the official ShinyProxy Operator. I need to modify some of the ShinyProxy styles, such as the landing page and other resources. How can I copy these modifications into the ShinyProxy pod to make them effective?

Hi @flash0926 , there are multiple ways to achieve this:

create a custom Docker image containing your resources and templates. In practice we believe this is the easiest way to do it, especially if you use CI/CD pipelines to build the docker image and deploy a new version of ShinyProxy.
FROM openanalytics/shinyproxy:3.1.1
COPY templates /opt/shinyproxy/templates

store the templates on a network file system and mount the volume into the ShinyProxy pod. Make sure the volume can be accessible by multiple pods on multiple nodes (i.e. ReadWriteMany), otherwise your deployment will fail when changing the ShinyProxy configuration. You can use kubernetesPodTemplateSpecPatches to add the k8s code to mount the volume (https://github.com/openanalytics/shinyproxy-operator/tree/master/docs/deployment#modify-the-shinyproxy-pod).

store the templates in k8s configmaps or secrets and mount these in the container (again using kubernetesPodTemplateSpecPatches). In our experience this is quite cumbersome and often requires changes at multiple places when modifying the templates (e.g. the list of files to mount etc).

I tried mounting template files using a persistentVolumeClaim but when I do this the sp-shinyproxy* pod is never started and I'm not sure why.
Here is the change to the kubernetesPodTemplateSpecPatches
    - op: add
      path: /spec/containers/0/volumeMounts/-
      value:
        - name: shinyproxy-templates
          mountPath: /etc/shinyproxy/templates
          readOnly: true
    - op: add
      path: /spec/volumes/-
      value:
        - name: shinyproxy-templates
          persistentVolumeClaim:
            claimName: shinyproxy-pvc

I made sure to include the - at the end of the path. If I remove the /- then the sp container starts as expected but the default (demo) configuration of ShinyProxy is loaded instead of the custom template.


Add BType information into hover text

Purpose

Add BType information into hover text

Fixes #17452
Check List

[x] Read the Contributing Guide
[ ] Required Balo version update
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Codecov Report

Merging #17453 into master will decrease coverage by 59.16%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #17453       +/-   ##
===========================================
- Coverage   68.85%    9.68%   -59.17%
===========================================
  Files           5       46       +41
  Lines         122     1476     +1354
  Branches       21      239      +218
===========================================
+ Hits           84      143       +59
- Misses         38     1320     +1282
- Partials        0       13       +13

Impacted Files
Coverage Δ

composer/packages/tracing/src/ToolBar.tsx

composer/packages/tracing/src/TraceList.tsx

composer/packages/tracing/src/DetailView.tsx

composer/packages/tracing/src/TraceLogs.tsx

composer/packages/tracing/src/index.ts

tool-plugins/vscode/src/utils/logger.ts
52.63% <0%> (ø)

tool-plugins/vscode/src/core/index.ts
100% <0%> (ø)

tool-plugins/vscode/src/utils/rpc/handler.ts
5.88% <0%> (ø)

tool-plugins/vscode/src/debugger/index.ts
0% <0%> (ø)

tool-plugins/vscode/src/debugger/manager.ts
0% <0%> (ø)

... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd372d...305fd4a. Read the comment docs.


Use of outdated bootstrap library

During a routine security test it was found that Prometheus is using Bootstrap 3.3.1 which has a known XSS issue (https://github.com/twbs/bootstrap/issues/20184). Further to this Bootstrap 3 is no longer maintained.
Environment

Prometheus version: 1.7.2, but confirmed in master also (https://github.com/prometheus/prometheus/blob/master/web/ui/templates/_base.html#L8)

From a look at our code, we're not using this anywhere. All the places where we've untrusted data we're handling with Go templating's escaping.

Closed by https://github.com/prometheus/prometheus/pull/5226


Avatar Component (Issue #437)

-Creates an avatar component
jira ticket
github issue

You'll need to add the component to the index.ts of the repo, you can also test it out in the code sandbox in the other comment

Playing with it in the codesandbox, I think the default size is wayyyy too big. I would expect it to be 1 or 1.5. Here I added it to the h1.
I also wonder if we should make it inline-block by default... I'm really not sure either way, it would just make my specific example where I didn't use a flexbox better so it may not be necessary.

:tada: This PR is included in version 1.23.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


299 refactoring renaming property cluster 02

This pull request includes the renaming of ten object properties.

'isAnimalOwner' to 'hasOwner'
'isAnnotationBy' to 'hasAuthor'
'isApprovedBy' to 'hasApprover'
'isBrand' to 'hasBrand'
'isCharacter' to 'hasCharacter'.
'isCommissionedBy' to 'hasCommissioningContract'
'isEditorialFormatOf' to 'hasEditorialFormatOf'
'isEmbodiedBy' to 'hasEmbodyingArtefact'
'isFictitiousPerson' to 'hasFictitiousPerson'
'isIssuedBy' to 'hasIssuer'

Reviewers:

@JuergenGrupp
@aro-max

Hey @aro-max
Looking forward to your feedback.


Update eCloud SDK

Issue to track update of eCloud SDK for .Net.
All the .Net SDKs should be updated or created to ensure overall feature parity with the go-sdk.

@0x4c6565 Would you mind giving this a once over?
PR in https://github.com/ukfast/sdk-dotnet-ecloud/pull/12


Implement reconcile for AC and ACR in extender

Extender reads all ACs and ACRs on each filter request. It might produce huge load on k8s API on a big scale. Need to keep cache of ACs and ACRs state in extender. That cached should be updated as part of reconcile for AC and ACR.

Not relevant anymore


Reworded the CONTRIBUTING.md doc

Objective

An attempt at improving the wording surrounding the contributing link
Fixes #16609

Solution

I mostly took Alice's wording and wrote it how I would have said it. No idea if it's also "clunky", but something's better than nothing

Testing

Not relevant

Not fully sold on my proposed wording either, but we can definitely make this much shorter :)


fix(prettier): add ordered list configuration.

Whilst testing earlier today with pre-commit I was getting a conflict between prettier and markdownlint-cli2 when it came to ordered lists with multiple paragraphs.
Running either in isolation was fine, and would re-format the files to their own liking.  However when combined it started a bun fight over spacing.
Basically the same issue as described in #410 but for ordered rather than unordered lists, hence not opening a new issue before submitting this pull request.
To resolve I had to add ol_multi: 2 into the .markdownlint-cli2.yaml config.
As I'd already done the work to solve it I'm submitting this in-case you want to update the config suggested in Prettier.md.
Abbreviated files were:
.editorconfig
root = true

[*]
charset = utf-8
end_of_line = lf
indent_size = 4
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true

[*.md]
trim_trailing_whitespace = false

README.md
1.  Line 1
2.  Line 2

    ```json
    { }
    ```

3.  Line 3

.pre-commit-config.yaml
%YAML 1.2
# yaml-language-server: $schema=https://json.schemastore.org/pre-commit-config.json
---
default_install_hook_types:
    - pre-commit

default_stages:
    - commit

fail_fast: true

repos:
    - repo: https://github.com/DavidAnson/markdownlint-cli2/
      rev: v0.5.1
      hooks:
          - id: markdownlint-cli2
            additional_dependencies:
                - markdownlint-rule-titlecase
                - markdownlint-cli2-formatter-junit

    - repo: https://github.com/pre-commit/mirrors-prettier
      rev: v3.0.0-alpha.4
      hooks:
          - id: prettier
            additional_dependencies:
                -<EMAIL_ADDRESS>                - eslint-config-prettier
                - stylelint-config-prettier
                - prettier-plugin-java
                - prettier-plugin-sh
                - prettier-plugin-toml
                - "@prettier/plugin-xml"

.markdownlint-cli2.yaml
%YAML 1.2
---
config:
    default: true
    MD007:
        indent: 4
    MD013: false
    MD030:
        ul_single: 3
        ul_multi: 3
        ol_multi: 2

customRules:
    - "markdownlint-rule-titlecase"

fix: true

noInlineConfig: true

outputFormatters:
    - - markdownlint-cli2-formatter-default
    - - markdownlint-cli2-formatter-junit

Signed-off-by: Adam Moss<EMAIL_ADDRESS>

Thank you!!


Identity page no longer fetching identities on Basilisk

What happened?
Balances load fine, but not created identity

https://basilisk.subscan.io/tx/0x8edce8a1b55fa9ebd580e8639ec344357f5a4406edc22196804d99777aa2ea77

Seems like the identity feature only operates on KSM and DOT. I attempted to use it on https://canary.kodadot.xyz/identity, but couldn't switch to the BSX network. Can you give it another try on canary? Also, I observed that the UI of the identity feature is currently dissimilar to your screenshot.

Seems like the identity feature only operates on KSM and DOT. I attempted to use it on https://canary.kodadot.xyz/identity, but couldn't switch to the BSX network. Can you give it another try on canary? Also, I observed that the UI of the identity feature is currently dissimilar to your screenshot.

Yeah, a lot got changed in this two weeks, and i remember something about a unified identity that would only work on kusama, will check it properly in my morning, thanks for looking into that!

yup, not it seems unified, closing


Usually all setters must be protected with access control

Function DappnodeSmoothingPool.submit report(uint64,bytes32) (contracts/DappnodeSmoothingPool.sol#367-447) is a non-protected setter lastConsolidatedSlot is written.

this is not about our code


download stock info error

Traceback (most recent call last):
File "D:\Anaconda3\Scripts\YahooTickerDownloader.py", line 161, in
main()
File "D:\Anaconda3\Scripts\YahooTickerDownloader.py", line 111, in main
downloadEverything(downloader, tickerType, args.insecure, args.sleep, args.p
andantic)
File "D:\Anaconda3\Scripts\YahooTickerDownloader.py", line 50, in downloadEver
ything
symbols = downloader.nextRequest(insecure, pandantic)
File "D:\Anaconda3\lib\site-packages\ytd\SymbolDownloader.py", line 113, in ne
xtRequest
html = self._fetchHtml(insecure)
File "D:\Anaconda3\lib\site-packages\ytd\SymbolDownloader.py", line 56, in _fe
tchHtml
resp.raise_for_status()
File "D:\Anaconda3\lib\site-packages\requests\models.py", line 893, in raise_f
or_status
raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: https://fina
nce.yahoo.com/lookup/E?s=a&t=E&m=ALL&b=0&bypass=true

You are using a old version of the software. Can you update it?

Please let me know and close this issue if the latest version solves the problem you are having.

I also wonder where you got the old version from. Where did you find it? I will have to notify whoever it is distributing it to update to the latest version.

yes!! That's it! Sorry for not reply in time and Thanks~


Enable new Blob MessageFormat in PutMessageFormatInputStream

The new Blob formats introduced to support chunked blobs are currently disabled in code as we wanted to verify that the whole flow works and be open for any changes until all operations are implemented. Now that all the operations are implemented and merged, and the whole end to end flow for PutBlob, GetBlob, GetBlobInfo and DeleteBlob for simple, composite and legacy blobs have been tested and verified for correctness even for very large blobs (tested for up to 12G), the new format can be enabled.
This requires the following:

Changes to PutMessageFormatInputStream to use Blob_Format V2.
Making changes to associated tests.
Removing dummy code added within the tests that write the new version.

Sharing some test results on the router would be useful.
On Fri, May 27, 2016 at 11:33 PM, Priyesh Narayanan <
<EMAIL_ADDRESS>wrote:

The new Blob formats introduced to support chunked blobs are currently
disabled in code as we wanted to verify that the whole flow works and be
open for any changes until all operations are implemented. Now that all the
operations are implemented and merged, and the whole end to end flow for
PutBlob, GetBlob, GetBlobInfo and DeleteBlob for simple, composite and
legacy blobs have been tested and verified for correctness even for very
large blobs (tested for up to 12G), the new format can be enabled.
This requires the following:

Changes to PutMessageFormatInputStream to use Blob_Format V2.
Making changes to associated tests.
Removing dummy code added within the tests that write the new
version.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/linkedin/ambry/issues/339, or mute the thread
https://github.com/notifications/unsubscribe/AC1vWHT_EX7ChtnoFx36w_A4DyZTKJs_ks5qF-HVgaJpZM4IpApa
.

Sriram, current testing has been done only for basic correctness and to ensure there are no changes required to the core logic. This also gives us confidence to go ahead with the MessageFormat changes.
Here is the write-up on the observations for now: https://gist.github.com/pnarayanan/c9ca5c789f1d7d25af5957f8de840eb9

#341 fixes this.


buildGoModule: buildFlags is still required in some cases that are not ldflags or tags

When building Golang modules via buildGoModule, the buildFlags option is still required in some cases that are not ldflags or tags. Currently when it's used it results in a warning:
trace: warning: Use the `ldflags` and/or `tags` attributes instead of `buildFlags`/`buildFlagsArray`

My use case for the buildFlags option is to set -mod=readonly (e.g. see screenshot below)

This seems to be a regression introduced with the following commits:

https://github.com/NixOS/nixpkgs/commit/3360a376cb905ac40e77d5424089d4893e9cd157#diff-3bd7a4c69ac3233f905d7a35364e4337a30261c93ee025491538ca7236a2d2a1
https://github.com/NixOS/nixpkgs/commit/cb7d80dcaf926a38e80044c29a8210e69f27bb80#diff-3bd7a4c69ac3233f905d7a35364e4337a30261c93ee025491538ca7236a2d2a1

buildGoModule requires that vendoring is provided by buildGoModule, I don't see that readonly will do that.
Can you provide more context for what you're trying to do please? Providing the derivation you want to build would be preferable.

I'm building and packaging Temporalite (as described here).

I'm building and packaging Temporalite (as described here).

https://github.com/DataDog/temporalite doesn't have a vendor directory checked into the repo so it needs to be provided by setting the vendorSha256.
{ fetchFromGitHub
, lib
, buildGo117Module
}:

buildGo117Module rec {
  pname = "temporalite";
  version = "1.14.1";

  src = fetchFromGitHub {
    owner = "DataDog";
    repo = pname;
    rev = "583fa90e84e6730c85add1ad781b52ba5caf9342";
    sha256 = "sha256-JuaE+KCQV1Os7qk4ZyO8g45Qn7Q3BMtsAPTOVYAxVKQ=";
  };

  subPackages = [ "cmd/temporalite" ];

  vendorSha256 = "sha256-yR5Doasf41P86flsXCoY0kukC0YSXUFKFjkMJMoQ/i0=";

  doCheck = false;
}

https://github.com/DataDog/temporalite doesn't have a vendor directory checked into the repo so it needs to be provided by setting the vendorSha256.
{ fetchFromGitHub
, lib
, buildGo117Module
}:

buildGo117Module rec {
  pname = "temporalite";
  version = "1.14.1";

  src = fetchFromGitHub {
    owner = "DataDog";
    repo = pname;
    rev = "583fa90e84e6730c85add1ad781b52ba5caf9342";
    sha256 = "sha256-JuaE+KCQV1Os7qk4ZyO8g45Qn7Q3BMtsAPTOVYAxVKQ=";
  };

  subPackages = [ "cmd/temporalite" ];

  vendorSha256 = "sha256-yR5Doasf41P86flsXCoY0kukC0YSXUFKFjkMJMoQ/i0=";

  doCheck = false;
}

Thanks a lot!

Thanks a lot!


rest-level-0-mission-intro-paragraph.adoc fixes

This document is a little imprecise and implies that using REST automagically makes API creation a breeze but I guess it'll have to do. It also confuses RPC and REST but I guess we could go down the rabbit hole trying to explain these things more precisely.
However, there is a typo: principals => principles

fixed in #767


Enable Detox to work with enableSeparateBuildPerCPUArchitecture option is turned on

Is your feature request related to a problem? Please describe.
Detox cant detect and run tests in android while enableSeparateBuildPerCPUArchitecture option is turned on
from what I have seen right now after build detox makes sure the AOK is generated in binaryPath specified in the config file,
then when test it uses the AndroidTest path equivalent to APK name specified in the config file.
Describe the Problem
when enableSeparateBuildPerCPUArchitecture option is turned off the output file normaly is:
android/app/build/outputs/apk/debug/app-debug.apk
and the androidTest output is:
android/app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk
but when enableSeparateBuildPerCPUArchitecture option is turned on the output files will be the following"
android/app/build/outputs/apk/debug/app-arm64-v8a-debug.apk
android/app/build/outputs/apk/debug/app-armeabi-v7a-debug.apk
android/app/build/outputs/apk/debug/app-x86-debug.apk
android/app/build/outputs/apk/debug/app-x86_64-debug.apk

and the androidTest output will also be is:
android/app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk
which case errors when detox running test as it search for
android/app/build/outputs/apk/debug/app-arm64-v8a-debug-androidTest.apk
android/app/build/outputs/apk/debug/app-armeabi-v7a-debug-androidTest.apk
android/app/build/outputs/apk/debug/app-x86-debug-androidTest.apk
android/app/build/outputs/apk/debug/app-x86_64-debug-androidTest.apk

based on which file you specified in the config file.
Describe the solution you'd like
we can just tell Detox to use
android/app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk
as it's not changing.
Describe alternatives you've considered
do the following enable universalApk true  // If true, also generate a app-universal-debug.apk
and do also the following
// applicationVariants are e.g. debug, release
    applicationVariants.all { variant ->
        variant.outputs.each { output ->
            // For each separate APK per architecture, set a unique version code as described here:
            // https://developer.android.com/studio/build/configure-apk-splits.html
            // Example: versionCode 1 will generate 1001 for armeabi-v7a, 1002 for x86, etc.
            def versionCodes = ['armeabi-v7a': 1, 'x86': 2, 'arm64-v8a': 3, 'x86_64': 4]
            def abi = output.getFilter(OutputFile.ABI)
            if (abi != null) {  // null for the universal-debug, universal-release variants
                output.versionCodeOverride = defaultConfig.versionCode * 1000 + versionCodes.get(abi)
            } else {
                /**
                * change apk name in app-universal-(debug|release).apk variants to be app-(debug|release).apk
                * in order for detox apk locator to see the apk and run e2e tests.
                */
                output.outputFileName = output.outputFile.name.replace("app-universal", "app")
            }
        }
    }

in the else  scope which basically changes the universal app name to be  app-debug.apk in order for detox to work normally

This isn't mentioned in the set up guides, but it is described in the configuration guide: You can specify the test APK's path explicitly using testBinaryPath


Update to Scala 2.13

Resolves #66

You could consider adding this project to scala-steward to automically keep dependencies up to date

Seems tut has trouble with comments and Scala 2.13 https://github.com/tpolecat/tut/issues/246. A workaround is to only run tut for Scala 2.12.

Fixed the comments, let me know if everything is alright now

@Fristi I have just pushed the migration to akka-http for tests, as described here. We should now be able to do this without dropping support for Scala 2.11 :)
Would you mind rebasing or merging this on master again? If you don't have the time I can also do it for you. Thank you for waiting for this!

just to check if there are plans to continue this PR? I'm affected by it too (not a blocker yet.. as I have it published locally for now)

@Fristi have you had the chance to take a look at this?
I'll do the rebase myself in a few days if you don't have the availability to work on it now, in order to speed up a Scala 2.13 compatible version. Hope you don't mind :)

Did not look at this yet, but if you have the chance go a head :)

Closed by #69. Thank you, @Fristi!


Conditional lazy hydration

It would be cool if you could have a parameter to set if you want to "disable" lazy hydration. E.g.:
<LazyHydrate :enabled="false">

I work with dynamic user defined components, and sometimes I'd like to disable LazyHydrate if a certain condition is met (e.g. "disable_lazy_load").

Not exactly what you want but as a workaround you can use triggerHydration.
<LazyHydrate when-visible trigger-hydration="disable_lazy_load">
  <!-- ... -->
</LazyHydrate>

Can you elaborate a bit on this @maoberlehner? Would this allow me to manually trigger a hydration? E.g. I could use "on-interaction" and then also have a trigger-hydration that would trigger once the element is visible? Or some other condition.


TestDeletedPDJoinsPreviousCluster is unstable

Details:
[2019-12-27T09:00:04.311Z] ----------------------------------------------------------------------
[2019-12-27T09:00:04.311Z] FAIL: join_test.go:130: joinTestSuite.TestDeletedPDJoinsPreviousCluster
[2019-12-27T09:00:04.311Z]
[2019-12-27T09:00:04.311Z] join_test.go:136:
[2019-12-27T09:00:04.311Z]     c.Assert(err, IsNil)
[2019-12-27T09:00:04.311Z] ... value *errors.withStack = canceled when waiting embed etcd to be ready ("canceled when waiting embed etcd to be ready")

I also met it

etcd start too slow?


Support for async web3

As mentioned in https://github.com/lidofinance/web3py-multi-http-provider/issues/45, it would be great to support AsyncWeb3 via an AsyncMultiProvider.

Thanks a lot for the speedy review and release!


Unable to request JSON chat completion due to private field

ChatCompletionResponseFormat was introduced to support JSON output in the chat completions API, but I believe the r#type field should be public instead of private? Apologies if I'm missing something. Happen to open a PR if this is the case.

Oh dang, thats a bug. PR is most welcome!

Hello, fix for pub visibility is added in v0.16.1.
Thank you for reporting the issue!


Fix issue when app.use() is called with empty value

PR supersedes #590

d134fff9e82d050e81bf579a693ed2114e7946c6 landed

The point of keeping debug before the if is to know what is being passed. At the moment, an error is thrown, however there is no debug information telling what is being passed. My PR did solve that without losing any information.

it will just debug use - when passing null or undefined to app.use. Throw an error is enough.

Well, then, the line should be debug('use %s', fn && (fn._name || fn.name) || JSON.stringify(fn)); or something. The point of debugging is to debug, otherwise it would be called info() or notice(). Justifying throwing an error without actually know what value caused the error makes the debug call pointless in these cases.

because of https://github.com/koajs/koa/commit/d134fff9e82d050e81bf579a693ed2114e7946c6#diff-5372f626ee15242f1e2c6eb31655b4faL103 the debug call will always see a function only

Some middleware are dynamically generated functions. In some applications, this may result in undefined to be returned and passed to app.use. There is a debug call, but it is after checking fn. So, in case of error being thrown, debug will not specify what value is actually being passed. Unless the error message is modified with throw new TypeError('middleware must be a function,  + String(fn) + ' given!');` or something, some information is missing.


fix: amend password

Description
Amend "admin_pass" in the tests.
Also, update the description in variables for the admin_pass.
Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 2.6.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


organize colors, fix modal buttons

Time to review
Medium: mostly reorganization, pruning of unused variables, renaming, etc
Problem
A maintenance PR to organize colors modal button styles, and make some style fixes on modal buttons.
Preliminary work to some updates to CustomModal.
With the exception of modal buttons, these changes should not affect current styling anywhere else in the application.
To review:
Inspect the website for inadvertent changes, and inspect the three modals: share trajectory, version info, upload file (screenshots below).
Almost all changes are trivial except for colors.css.
In colors I have tried hard to confirm that all removed variables were unused, and no styles were unintentionally changed by reorganization/pruning. Missing something here and messing with other styles unintentionally is the primary concern in review
Theme and styling:

apply light theme at the custom-modal level, remove from implementing components
consistently use primary-button and secondary-button class names to match theme, remove antd button type to prevent adding and removing their styling.- use consistent naming scheme for light theme color variables
removed a large commented styling code block that was "just in case" storage, 3 years old, not current design.
button fixes, refer to: figma source of truth: darken hover color on secondary buttons, bring version modal button into scheme, make copy button on share trajectory modal primary, make share trajectory error modal secondary, make all modal footer buttons equal width
removed border and border radius styles in light theme that seem to be inherited correctly from antd defaults and swapped in new variable names, provide vars for color, bg, and border color across the board for consistency

General color maintenance:

looked for anywhere hexes were used directly in stylesheets and made variables
looked for any variables that were not currently used anywhere, removed them. All removed/renamed variables are listed below for confirmation
changed all instances of "grey" to "gray" not a huge deal but we did have both dark-blue-grey and dark-blue-gray defined and it also makes searching the repo more reliable if we are consistent
make hexes consistently lower case

removed unused css vars:
--dark-blue-grey
--viewer-btn-border-on
--border-gray
--background-dim-gray
--background-dark-gray
--light-theme-button-purple
--light-theme-button-light-gray
--light-theme-input-border-highlight
--dark-theme-btn-disabled-color
--dark-theme-btn-primary-text
--dark-theme-btn-disabled-bg
--dark-theme-slider-color

renamed/reused:
(using primary and secondary now to match UX usage)
--light-theme-btn-default-bg
--light-theme-btn-default-color
--light-theme-btn-default-border
--light-theme-btn-default-hover-bg
--light-theme-btn-default-hover-color
--light-theme-btn-default-hover-border
--light-theme-btn-default-disabled-bg
--light-theme-btn-default-disabled-color
--light-theme-btn-default-disabled-border

Screenshots (optional):
Old:

New:

Old:

New:

Old:

New:

Old:

New:

When I compared these to the design, the x in the modal looks farther away from the right edge in your build. I think this is probably the default antd positioning, but just FYI

When I compared these to the design, the x in the modal looks farther away from the right edge in your build. I think this is probably the default antd positioning, but just FYI

suggestion: add justify-content: center; to .style__modal--vTNFd .ant-modal-close-x

I think you made a note about this, but I see the select file button lose it's outline

When I compared these to the design, the x in the modal looks farther away from the right edge in your build. I think this is probably the default antd positioning, but just FYI

You're right, I have a fix for that lined up in my next set of changes.


[Website] Document programatic usage

Done in: https://github.com/dotansimha/graphql-code-generator/commit/6cf5bfb299a534fef3db7e0b5726eda3dbd88639


D_loss in WGAN(tensorflow)

I think the D_loss in WGAN(tensorflow) is lack of  negative sign

Sorry, I did not notice the D_solver.


Feature request: Distinguish between "goals accomplished" and "no goals"

At the moment, the Lean 4 VS Code extension reports "Goals accomplished 🎉" if the goal list is empty.  This is copied from the Lean 3 behaviour (https://github.com/leanprover/vscode-lean/pull/114).  However, far more often than in Lean 3, the phrase is an inappropriate descriptor of the situation.  For example:
example : True := by
  exact h

With the cursor after h, one has two messages displayed, "Goals accomplished" and "unknown identifier 'h'".  In Lean 3, there is no "Goals accomplished" message on this example, I guess because the parser is so confused by the unknown identifier 'h' that it does not output any goal list, empty or not.
This has been discussed in the mathlib porting meetings and several times on Zulip
https://leanprover.zulipchat.com/#narrow/stream/187764-Lean-for-teaching/topic/Marmite/near/302553129
https://leanprover.zulipchat.com/#narrow/stream/113489-new-members/topic/behaviour.20of.20.60exact.60.20in.20lean4
https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/premature.20.22goals.20accomplished.22
Several people have suggested that the "Goals accomplished" message be be limited to a smaller set of situations.  The remaining situations, when the goal list is empty but "Goals accomplished" is not appropriate, could display the message "no goals" or no message at all.
Ideally, the criterion for whether to display "Goals accomplished" would depend only on the current block, and not e.g. be affected by other errors outside that block.  For example, this could be done by (programmatically) looking for errors, i.e. red squiggles (a suggestion of Jon Eugster).
If the devs don't want to implement this feature, I'd like to propose that "no goals" be the standard wording in VS Code (and "Goals accomplished" could be turned on by an option). Likewise if the devs do want to implement this feature but expect that it will take some time (say more than a couple of weeks).

If the devs don't want to implement this feature, I'd like to propose that "no goals" be the standard wording in VS Code (and "Goals accomplished" could be turned on by an option). Likewise if the devs do want to implement this feature but expect that it will take some time (say more than a couple of weeks).

This has now been done in the VS Code extension, so the immediate confusion is resolved.  It would still be nice to have the more nuanced behaviour if/when the devs get time.

I'm closing this issue in favour of #4190, which is a more refined proposal addressing this issue.


MTCNN 转tflite时不成功

RuntimeError: TOCO failed see console for info.
2019-12-18 16:48:58.198777: I tensorflow/contrib/lite/toco/import_tensorflow.cc:1366] Converting unsupported operation: Abs
2019-12-18 16:48:58.198857: I tensorflow/contrib/lite/toco/import_tensorflow.cc:1366] Converting unsupported operation: Abs
2019-12-18 16:48:58.198952: I tensorflow/contrib/lite/toco/import_tensorflow.cc:1366] Converting unsupported operation: Abs
2019-12-18 16:48:58.199031: I tensorflow/contrib/lite/toco/import_tensorflow.cc:1366] Converting unsupported operation: Abs
2019-12-18 16:48:58.199599: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before Removing unused ops: 75 operators, 105 arrays (0 quantized)
提示没有abs这个op，这是安装版本问题吗？

Same error here. Anyone got the solution? Thanks!

Hi @wweihang ,
I try to modify the abs() in mtcnn_model.py prelu() function with
output = tf.nn.relu(inputs) + tf.multiply(alphas, -tf.nn.relu(-inputs))
and I am ok to convert to tflite.
for your reference.


Increase code coverage through more automated and stable tests

Ticket: https://mattermost.atlassian.net/browse/MM-14066


✨ Add dark mode

Hey thanks for this! I'm having a lot going on right now and couldn't keep up! Feel free do remove wherever I was assigned


Add submission of chat posts

I unfortunately don't have time at the moment to put together a pull request, but this should be fairly simple. Just pass a "discussion_type": "CHAT" in the submit call. There's an example here.
As far as I can tell, the only accepted arguments for discussion_type are "CHAT" or None, so this could probably be added as a True/False argument to the submission function.

See https://github.com/praw-dev/praw/pull/1367 :)


Bulk data files search-508 issue

Context
Testing complete for 2697, the code of the hidden label and actual search input matches that of the search in the popup menu. To remedy, change the for and id attributes of the new search label/input so they are different from the one in the menu. I would also suggest changing the hidden label to be different, perhaps 'Search Bulk Data Files Table'

Testing complete, issues have been addressed!


Remove unused locations

The locations of the topic input and expectations are not used. Instead the location of the records they contain is used.
So lets remove unused code...
Reviewer checklist

[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage increased (+0.1%) to 99.411% when pulling 9ffd83c85e3e2d20a8dac799b7961a71a0aecbd0 on drop_unused_loc into cc129d7a318bb6db78fae3c07d4a2c03bac37aee on main.


enabled option does not work as expected

https://github.com/connectrpc/connect-query-es/blob/94ee6e86abbb7fc497c88d5900de457cfc9eb688/packages/connect-query/src/use-query.ts#L61-L64
I think that's the problem.

Yeah we've typically used the symbol disableQuery to indicate a disabled query. The disableQuery symbol makes it easier to guarantee typesafety on the input combined with a valid query function. To make that more explicit, we should probably remove the enabled prop as a possible input since it's generated based on input.

On closer examination of this, I think it would be consistent to still support the enabled option along with the explicit disableQuery since it will lead to less ternaries all over the place. Opened #318 to add this in.


Add sort type

Fixes BlueBrain/nexus#940
Updated ResourceListOptions with the new option:
sort?: string | string[];

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7b02015). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #304   +/-   ##
=========================================
  Coverage          ?   84.45%
=========================================
  Files             ?       21
  Lines             ?      444
  Branches          ?       97
=========================================
  Hits              ?      375
  Misses            ?       67
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b02015...97b45fc. Read the comment docs.

Note, I've tested the API using both the unencoded @id and the encoded %40id, such as resources/test-org/test?sort=@id  and  resources/test-org/test?sort=%40id, and both work. For the sake of being consistent, the sdk will always encode query params as is the default behavior of the query-string library.


Flyout ShowAt cause WinRT transform error in C++ WinRT

Describe the bug
Calling MenuFlyout.ShowAt() at a newly constructed Window causes WinRT transform error when using C++/WinRT with WinUI3, but using the same code does not cause such exception in C#.
Steps to reproduce the bug

Make a C++/WinRT project with WinUI3.
Add this in MainWindow.xaml

    <StackPanel Orientation="Horizontal" HorizontalAlignment="Center" VerticalAlignment="Center">
        <Button x:Name="myButton" Click="myButton_Click">Click Me</Button>
    </StackPanel>

Use this C++ code
MainWIndow.xaml.h

    struct MainWindow : MainWindowT<MainWindow>
    {
        MainWindow();
        void myButton_Click(winrt::Windows::Foundation::IInspectable const& sender, winrt::Microsoft::UI::Xaml::RoutedEventArgs const& e);
        winrt::Microsoft::UI::Xaml::Window window{ nullptr };
    };

void winrt::winui3Cpp::implementation::MainWindow::myButton_Click(winrt::Windows::Foundation::IInspectable const& sender, winrt::Microsoft::UI::Xaml::RoutedEventArgs const& e)
{
    window = winrt::Microsoft::UI::Xaml::Window{};
    winrt::Microsoft::UI::Xaml::Controls::Frame frame;
    window.Content(frame);

    winrt::Microsoft::UI::Xaml::Controls::MenuFlyout flyout;

    frame.Loaded(
        [flyout, this](auto, auto)
        {
            winrt::Microsoft::UI::Xaml::Controls::Primitives::FlyoutShowOptions options;
            options.ShowMode(winrt::Microsoft::UI::Xaml::Controls::Primitives::FlyoutShowMode::Transient);
            flyout.ShowAt(window.Content(), options); //exception here
        }
    );
}

Click the button, the exception

I wonder why it calls CoreApplication::GetCurrentView(), because it's supposed to be null in WinUI3.
Use the same code but in C#
        public MainWindow()
        {
            this.InitializeComponent();
        }

        Window window = null;
        private void myButton_Click(object sender, RoutedEventArgs e)
        {
            window = new Window();
            Frame frame= new Frame();
            window.Content= frame;

            MenuFlyout flyout = new MenuFlyout();
            frame.Loaded += (_, _) =>
            {
                FlyoutShowOptions options = new FlyoutShowOptions
                {
                    ShowMode = FlyoutShowMode.Transient
                };
                flyout.ShowAt(window.Content, options);
            };
        }

The exception does not occur.
Expected behavior
No response
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.2 : 1.2.221116.1
Windows version
Windows 11 (22H2): Build 22621
Additional context
No response

@HO-COOH Like a C++ app, a C# app calls SharedHelpers::TryGetCurrentCoreApplicationView(), which you can see if you enable native debugging.  In both cases, the call is intentional.

Yep, after enabling native debugging, the same exception occcurs in C#.

Okay, this exception happens not only on the newly constructed window like OP, but also happens on flyout.ShowAt(myButton, ...);, please fix!

@anyone any update on this

@anyone any update on this

Update From My Site Got Working

Hi, I've verified this is fixed in the latest WinAppSDK 1.3 and 1.4 stable builds.  We do still have some outstanding places in the code where first-chance exceptions are still fired, but this specific one should be gone.  Please holler if you still see it.
Also note that if a first-chance exception like this is too noisy for you, you can turn them off in the "Exception Settings" window.  The noisy ones in a WinUI 3 app are usually "Win32 Exceptions" / "WinRT Originate Error".


108 needs z indexing for settings modal and icon container

will have to test in prod to confirm the bug is resolved :/


C# ArrowStreamReader fails on gRPC streamed ArrowTable serialized as .arrow IPC in-memory file (bytearray)

Describe the bug, including details regarding any error messages, version, and platform.
C# same failure detected for nuget package versions 2.0.0/10.0.0/11.0.0/12.0.0/13.0.0
Exception:
Unexpectedly reached the end of the stream before a full buffer was read.
The same ArrowTable (i.e. .arrow IPC in-memory byte array) can be successfully loaded using ArrowFileReader, after if had been saved from the streamed bytes using File.WriteAllBytes.
Component(s)
C#

I believe this is expected behavior.  Those are two different formats.  If you serialize a table with the file format then you need to read it with the file format.

Thx for your correct reply, Weston.
Some context:
My Python gRPC service was serializing the PyArrow.Table using pyarrow.ipc.new_file (instead of new_stream).
My C# .Net6 gRPC client was trying to deserialize it using ArrowStreamReader(MemoryStream().ReadNextRecordBatch(Async).


 Possibly the CPU jumped to an incorrect location in memory?

Also stepping in the debugger doesn't work, likely because x86 single-stepping mode is not implemented.

F2 0F 7C is HADDPS, an sse3 instruction which currently not implemented in v86 (and apparently not implemented in KolibirOS's debugger either).
I'd accept a PR (this is instruction should be fairly easy to implement).

Ah, thanks for pointing that out. I was able to add the instruction, and it looks like the demo now works. I'll make a PR.


Invalid domain used when ldap record doesn't have email field

Description
When syncing users from ldap, if user doesn't have email field, username@localhost is used https://github.com/go-gitea/gitea/blob/v1.17.2/services/auth/source/ldap/source_sync.go#L88
Later when trying to edit this user from admin page, I'm getting an error that email is invalid
Gitea Version
1.17.0
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Downloaded binary from release page, run with systemd
Database
No response

Maybe we should ignore this user with no email input?

@lunny I think it would be kinda unfair to ignore such users. In case some organizations may not have email set up, or it is a guest or automation user with no email within organization.
I remember investigating this a little bit more, and the root cause of this behavior was the go library that validates email addresses. When I last checked it required fqdn and, probably, just localhost is not a valid fqdn for this library, sorry for not mentioning this in the issue.
So, I believe faster approach would be to change localhost to localhost.local or localhost.localhost, but I am not sure if it could potentially lead to security or compatibility issues.

The Email field has an Email tag, so when we try to edit a user with the default email (username@localhost), the validation will fail.
https://github.com/go-gitea/gitea/blob/59d218987582ae3191a4cb97fbfc4f3aedcff1ad/services/forms/admin.go#L40

So, I believe faster approach would be to change localhost to localhost.local or localhost.localhost, but I am not sure if it could potentially lead to security or compatibility issues.

Since we shouldn't ignore the users with no email, I think changing the email suffix would be a solution.


Milestone 3 : Add initial state

In this milestone, I achieved the following...

I connect your app to the Redux store.
I generated a unique id for the inputs.
I added a functionality for "Check status".

Thanks for reviewing and approving my project, I appreciate it.


fix(Pose): remove config_file from class property

Summary by CodeRabbit

Refactor: Updated the handling of configuration files in aeon/io/reader.py. The config_file is no longer a class property and is now passed as a parameter to the methods get_class_names, get_bodyparts, and class_int2str. This change enhances the flexibility and maintainability of the code. Please note, this may impact the external interface or behavior of the code if these methods are used externally.

Actually this is good as is, so will merge like this


Accessibility issue in iOS mobile devices using keyboard arrow keys

Describe the bug
We spotted some strange behavior when trying to use the keyboard arrow keys in iOS devices to navigate through the credit card input fields.
It jumps from the card number field to a hidden input and then to the card holder name field and it’s not possible to focus the other fields (Expiry date and CVV) via the iOS arrows.
It jumps through these 3 fields where the middle one is hidden.
To Reproduce
Steps to reproduce the behavior:

Go to payment and choose Credit Card
Click on the Credit Card number field which should be the first input
Use the arrow keys in iOS devices, more specifically on iPhone, try to focus the next input
Type something, you will see nothing happens. It's typing in a hidden input field.
Click again the arrow key to focus the next input
You are now focusing the name field, which is the fourth field in the form.

Notes:

On iPad the arrow keys are disabled and cannot navigate through the Credit Card input fields
When you focus on Expiry Date or CVV fields, the arrows are disabled on both devices

Expected behavior
The user should be able to go through all of these fields with the iOS arrows one by one. Without focusing a hidden inputs or skipping Expiry date and CVV fields.
Screenshots
iPad:

iPhone:
Video:
https://user-images.githubusercontent.com/76946766/114847072-f6e1d900-9de5-11eb-905d-2ce225080d5a.MP4
Screenshot:

Tablet:

Device: iPad 8th
OS: iOS
Browser: Safari
Version: 14

Smartphone:

Device: iPhone 12
OS: iOS
Browser: Safari
Version: 14

Additional context
I believe this can be caused by the fact that these inputs sits into an iframes.
Could not be possible to find a workaround but it's worth investigating.

Hi @kdimitrovosf,
Thanks for reporting this issue and our apologies for the delay on coming back to you. We will take a look at this and update this issue once we have a fix ready.

This issue arises from changes Apple made in Safari 13:

“Changed the behavior for third party iframes to prevent them automatically navigating the page.”

In other words they prevent 3rd party (i.e. cross-origin) iframes from programmatically focusing before the user makes a direct interaction with the frame.
This restriction unfortunately also applies to the arrow keys on the "soft" iOS keyboard (a test shows that if the iframes are the same origin as the hosting site then the arrow keys behave as expected).
Since this issue is caused by changes made by Apple, after much investigation & experimentation, the only solution we could come up with & implement was that if we can't achieve keyboard navigation in iOS browsers then we shouldn't even appear to offer it i.e. we turnoff these arrow keys
This at least doesn't "mislead" the user into thinking they will work as expected
This change was added in release 5.15.0.


[bug-350]: Clarify role update error messages

Description

Updates error messages of karavictl role update to clarify that only the quota of a role can be updated
If a role is not found, the error message shows the RoleKey, the unique identifier for the role instead of just the role name
Adds unit test to role-service for non-quota update

GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

https://github.com/dell/csm/issues/530

Checklist:

[x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have not allowed coverage numbers to degenerate
[ ] I have maintained at least 90% code coverage
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Backward compatibility is not broken

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

run e2e test

run e2e test

run e2e test

e2e pass


Add a merge MTLX to glTF option

MTLX converted to glTF creates a standalone glTF file.
A merge of this to an existing glTF file is useful to replace existing materials.
Assignments could also be handled.

This is can be done via Python package.


No background updates?

Hi there,
Thanks for this library. subscribeToLocationUpdatesWithDesiredAccuracy you introduced recently is a long-awaited and great feature.
I'm subscribing to desired accuracy update in  didFinishLaunchingWithOptions app delegate. NSLocationAlwaysUsageDescription is set in the property list and  location updates is activated in background modes.
I opted in to receive location updates even in background. But, when the app goes to the background, I no longer receive updates, with no further log. As soon as it is in the foreground I get them back.
What did I miss? Does background mode only work with subscribeToSignificantLocationChangesWithBlock?
Thanks for your help.

Setting allowsBackgroundLocationUpdates to true on the location manager now seems mandatory when linking against iOS9, to enable background updates. Mentioned here.

Thanks for reporting this! This is definitely something that needs to be addressed, there is an attempt in #57 to do so.


#12 issue work

I have something here. Let's see whether it works or not.

From what I can see it should be working.

I should be able to test it in about four hours from now ;)
Thank you :)

Happy to help.


use location_mark instead of location_point for marker locations on the map

The location_mark is the position where the markers on a map shall be painted, not on location_point, which is the 'real' position. The marker is the location plus applied fuzziness to see several markers instead of one if there are severals in search results.
I see location_point at
https://github.com/loklak/loklak_webclient/blob/ebb233e3e57ee888d76c1648aa78097619563769/app/js/directives/mapLayout.js
https://github.com/loklak/loklak_webclient/blob/e299a3ea47a43f5cd81a5ec2d65f9071daedd53d/app/js/controllers/advanced-search.js
https://github.com/loklak/loklak_webclient/blob/21f679796d16bb71784e76e1a57317218a70e048/app/js/controllers/search.js
.. please change this to location_mark!

This is related to https://github.com/loklak/loklak_webclient/issues/232

@fuksi This is also related to the map search.

Fixed with #279

Assiging this to fuksi. Please check in howfar this is relevant to the map search.

@mariobehling I have changed it everywhere.At all places we are plotting maps as suggested by @Orbiter .So this is good to close.

Awesome!

I just tested this on the live map and it looks interesting! Did you try out the effect? However, it's working, great!


[youtube] maxresdefault doesn't exist sometimes

Originally posted by @Zirro here

I've received several 404's for maxresdefault URLs with this change, so unfortunately it doesn't seem to be true for every video. The best approach would probably be to initially request maxresdefault and look at the response code. If it's 404, try with hqdefault instead.
It could also be worth using a similar approach to check for the existence of a .webp-version of the thumbnail at the /vi_webp/-path before falling back to the .jpgˋ-version, though the difference in quality doesn't seem to be very significant here.

Here's one where there is no maxresdefault size at all: https://www.youtube.com/watch?v=pS4ca4GB-_c
https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.jpg (404)
https://i.ytimg.com/vi_webp/pS4ca4GB-_c/maxresdefault.webp (404)
Here's one where both JPEG and WebP-files are accessible at separate URLs: https://www.youtube.com/watch?v=goSEyGNfiPM
https://i.ytimg.com/vi/goSEyGNfiPM/maxresdefault.jpg (200)
https://i.ytimg.com/vi_webp/goSEyGNfiPM/maxresdefault.webp (200)
Here's one where only the JPEG-file is available: https://www.youtube.com/watch?v=xp-b4Ce4Mf4
https://i.ytimg.com/vi/xp-b4Ce4Mf4/maxresdefault.jpg (200)
https://i.ytimg.com/vi_webp/xp-b4Ce4Mf4/maxresdefault.webp (404)
I'm not sure if there are cases where only the WebP exists, though. Besides that it's mainly a question of whether checking for the .webp first should be done for the theoretical quality improvement, with the .jpg staying as fallback when there is no WebP available.

It's easy enough to check for 404s, but its also not really necessary. yt-dlp automatically downloads the next thumbnail if one isnt found
$ yt-dlp pS4ca4GB-_c --write-thumb --skip-down
[youtube] pS4ca4GB-_c: Downloading webpage
[info] pS4ca4GB-_c: Downloading 1 format(s): 248+251
[youtube] pS4ca4GB-_c: Downloading thumbnail  ...
WARNING: Unable to download thumbnail "https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.jpg": HTTP Error 404: Not Found
[youtube] pS4ca4GB-_c: Downloading thumbnail  ...
[youtube] pS4ca4GB-_c: Writing thumbnail to: Magnitude 9.1 Earthquake in Japan March 11, 2011 Compilation - Part 1 [pS4ca4GB-_c].jpg

but anyway, the second best thumbnail is actually https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.jpg (which yt-dlp doesn't find), not hqdefault :/
I'll probably look at hard-coding more thumbnail URLs

Just noting down the thumbnail URLs I know
https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.jpg
https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg
https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.jpg
https://i.ytimg.com/vi/pS4ca4GB-_c/mqdefault.jpg
https://i.ytimg.com/vi/pS4ca4GB-_c/default.jpg
https://i.ytimg.com/vi/pS4ca4GB-_c/0.jpg
https://i.ytimg.com/vi/pS4ca4GB-_c/1.jpg
https://i.ytimg.com/vi/pS4ca4GB-_c/2.jpg
https://i.ytimg.com/vi/pS4ca4GB-_c/3.jpg

All of these also have webp versions like https://i.ytimg.com/vi_webp/<id>/<name>.webp

It's easy enough to check for 404s, but its also not really necessary. yt-dlp automatically downloads the next thumbnail if one isnt found

Ah, I was receiving the following error messages instead:
WARNING: Unable to download thumbnail "https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.jpg": HTTP Error 404: Not Found
[...]
WARNING: Skipping embedding the thumbnail because the file is missing.

It looks like this issue happens specifically when the --write-all-thumbnails flag is provided.

but anyway, the second best thumbnail is actually https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.jpg

Interesting, I don't remember having seen sddefault.jpg before. If you don't mind me asking, how/where did you find it?

the thumbnail shown in embed is normally the highest resolution one. So I opened https://www.youtube.com/embed/pS4ca4GB-_c and checked the network requests

live videos
https://i.ytimg.com/vi//maxresdefault_live.jpg

The only way I've found to fully fix this is to hardcode the URLs. But I'm not sure I should fix it this way because of how many additional requests it takes to figure out which of the URLs are working
$ yt-dlp -v https://www.youtube.com/watch?v=pS4ca4GB-_c --list-thumb
[debug] Command-line config: ['-v', 'https://www.youtube.com/watch?v=pS4ca4GB-_c', '--list-thumb']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] yt-dlp version 2021.07.07 (source)
[debug] Plugin Extractors: ['SamplePlugin']
[debug] Git HEAD: f0ff9979c6
[debug] Python version 3.9.6 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: ffmpeg 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, ffprobe 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, phantomjs 2.1.1
[debug] Proxy map: {}
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=pS4ca4GB-_c
[youtube] pS4ca4GB-_c: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] [info] Testing thumbnail 21
[debug] [info] Unable to connect to thumbnail 21 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 20
[debug] [info] Testing thumbnail 19
[debug] [info] Unable to connect to thumbnail 19 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/mqdefault.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 18
[debug] [info] Testing thumbnail 17
[debug] [info] Unable to connect to thumbnail 17 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 16
[debug] [info] Unable to connect to thumbnail 16 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.jpg" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 15
[debug] [info] Unable to connect to thumbnail 15 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 14
[debug] [info] Unable to connect to thumbnail 14 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/default.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 13
[debug] [info] Testing thumbnail 12
[debug] [info] Unable to connect to thumbnail 12 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/3.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 11
[debug] [info] Testing thumbnail 10
[debug] [info] Unable to connect to thumbnail 10 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/2.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 9
[debug] [info] Testing thumbnail 8
[debug] [info] Unable to connect to thumbnail 8 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/1.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 7
[debug] [info] Testing thumbnail 6
[debug] [info] Unable to connect to thumbnail 6 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/0.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 5
[info] Thumbnails for pS4ca4GB-_c:
ID width   height  URL
0  168     94      https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEbCKgBEF5IVfKriqkDDggBFQAAiEIYAXABwAEG&rs=AOn4CLCBQ4_ln39dFCbgt268t8lMJUtfdA
1  196     110     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEbCMQBEG5IVfKriqkDDggBFQAAiEIYAXABwAEG&rs=AOn4CLACk7_pc2_UMDQ3R-p4Epk4q517Jw
2  246     138     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEcCPYBEIoBSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLCoeij_0sT78RWLVeAwZ_oQZhb8RQ
3  336     188     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEcCNACELwBSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLCC9H7tB1SUKxNjuEFpeLGHh4vZxQ
4  480     360     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg
5  unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/0.jpg
7  unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/1.jpg
9  unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/2.jpg
11 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/3.jpg
13 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/default.jpg
18 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/mqdefault.jpg
20 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.jpg

PS: Dont mind the ordering, it can be fixed
The testing can be implemented lazily. So if only one thumbnail URL is requested, not all has to be tested.
$ yt-dlp -v https://www.youtube.com/watch?v=pS4ca4GB-_c --print thumbnail
[debug] Command-line config: ['-v', 'https://www.youtube.com/watch?v=pS4ca4GB-_c', '--print', 'thumbnail']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] yt-dlp version 2021.07.07 (source)
[debug] Plugin Extractors: ['SamplePlugin']
[debug] Git HEAD: f0ff9979c6
[debug] Python version 3.9.6 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: ffmpeg 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, ffprobe 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, phantomjs 2.1.1
[debug] Proxy map: {}
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=pS4ca4GB-_c
[youtube] pS4ca4GB-_c: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] [info] Testing thumbnail 21
[debug] [info] Unable to connect to thumbnail 21 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 20
[debug] Default format spec: bestvideo*+bestaudio/best
[info] pS4ca4GB-_c: Downloading 1 format(s): 248+251
https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.jpg

But the issue is when writing infojson, all URLs must be resolved even if the user has no actual interest in the thumbnails
$ yt-dlp -v https://www.youtube.com/watch?v=pS4ca4GB-_c --write-info --skip-dow
[debug] Command-line config: ['-v', 'https://www.youtube.com/watch?v=pS4ca4GB-_c', '--write-info', '--skip-dow']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] yt-dlp version 2021.07.07 (source)
[debug] Plugin Extractors: ['SamplePlugin']
[debug] Git HEAD: f0ff9979c6
[debug] Python version 3.9.6 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: ffmpeg 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, ffprobe 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, phantomjs 2.1.1
[debug] Proxy map: {}
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=pS4ca4GB-_c
[youtube] pS4ca4GB-_c: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] [info] Testing thumbnail 21
[debug] [info] Unable to connect to thumbnail 21 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 20
[debug] Default format spec: bestvideo*+bestaudio/best
[info] pS4ca4GB-_c: Downloading 1 format(s): 248+251
[info] Writing video metadata as JSON to: Magnitude 9.1 Earthquake in Japan March 11, 2011 Compilation - Part 1 [pS4ca4GB-_c].info.json
[debug] [info] Testing thumbnail 19
[debug] [info] Unable to connect to thumbnail 19 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/mqdefault.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 18
[debug] [info] Testing thumbnail 17
[debug] [info] Unable to connect to thumbnail 17 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 16
[debug] [info] Unable to connect to thumbnail 16 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.jpg" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 15
[debug] [info] Unable to connect to thumbnail 15 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 14
[debug] [info] Unable to connect to thumbnail 14 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/default.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 13
[debug] [info] Testing thumbnail 12
[debug] [info] Unable to connect to thumbnail 12 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/3.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 11
[debug] [info] Testing thumbnail 10
[debug] [info] Unable to connect to thumbnail 10 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/2.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 9
[debug] [info] Testing thumbnail 8
[debug] [info] Unable to connect to thumbnail 8 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/1.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 7
[debug] [info] Testing thumbnail 6
[debug] [info] Unable to connect to thumbnail 6 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/0.webp" - HTTP Error 404: Not Found. Skipping...
[debug] [info] Testing thumbnail 5

Another way to handle this to test the URLs only if the user requests so with --check-formats:
$ yt-dlp -v https://www.youtube.com/watch?v=pS4ca4GB-_c --list-thumb
[debug] Command-line config: ['-v', 'https://www.youtube.com/watch?v=pS4ca4GB-_c', '--list-thumb']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] yt-dlp version 2021.07.07 (source)
[debug] Plugin Extractors: ['SamplePlugin']
[debug] Git HEAD: f0ff9979c6
[debug] Python version 3.9.6 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: ffmpeg 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, ffprobe 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, phantomjs 2.1.1
[debug] Proxy map: {}
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=pS4ca4GB-_c
[youtube] pS4ca4GB-_c: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] Thumbnails for pS4ca4GB-_c:
ID width   height  URL
0  168     94      https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEbCKgBEF5IVfKriqkDDggBFQAAiEIYAXABwAEG&rs=AOn4CLCBQ4_ln39dFCbgt268t8lMJUtfdA
1  196     110     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEbCMQBEG5IVfKriqkDDggBFQAAiEIYAXABwAEG&rs=AOn4CLACk7_pc2_UMDQ3R-p4Epk4q517Jw
2  246     138     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEcCPYBEIoBSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLCoeij_0sT78RWLVeAwZ_oQZhb8RQ
3  336     188     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEcCNACELwBSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLCC9H7tB1SUKxNjuEFpeLGHh4vZxQ
4  480     360     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg
5  unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/0.jpg
6  unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/0.webp
7  unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/1.jpg
8  unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/1.webp
9  unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/2.jpg
10 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/2.webp
11 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/3.jpg
12 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/3.webp
13 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/default.jpg
14 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/default.webp
15 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.webp
16 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.jpg
17 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.webp
18 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/mqdefault.jpg
19 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/mqdefault.webp
20 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.jpg
21 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.webp

$ yt-dlp -v https://www.youtube.com/watch?v=pS4ca4GB-_c --list-thumb --check-form
[debug] Command-line config: ['-v', 'https://www.youtube.com/watch?v=pS4ca4GB-_c', '--list-thumb', '--check-form']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] yt-dlp version 2021.07.07 (source)
[debug] Plugin Extractors: ['SamplePlugin']
[debug] Git HEAD: f0ff9979c6
[debug] Python version 3.9.6 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: ffmpeg 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, ffprobe 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, phantomjs 2.1.1
[debug] Proxy map: {}
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=pS4ca4GB-_c
[youtube] pS4ca4GB-_c: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] Testing thumbnail 21
[info] Unable to connect to thumbnail 21 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.webp" - HTTP Error 404: Not Found. Skipping...
[info] Testing thumbnail 20
[info] Testing thumbnail 19
[info] Unable to connect to thumbnail 19 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/mqdefault.webp" - HTTP Error 404: Not Found. Skipping...
[info] Testing thumbnail 18
[info] Testing thumbnail 17
[info] Unable to connect to thumbnail 17 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.webp" - HTTP Error 404: Not Found. Skipping...
[info] Testing thumbnail 16
[info] Unable to connect to thumbnail 16 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/maxresdefault.jpg" - HTTP Error 404: Not Found. Skipping...
[info] Testing thumbnail 15
[info] Unable to connect to thumbnail 15 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.webp" - HTTP Error 404: Not Found. Skipping...
[info] Testing thumbnail 14
[info] Unable to connect to thumbnail 14 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/default.webp" - HTTP Error 404: Not Found. Skipping...
[info] Testing thumbnail 13
[info] Testing thumbnail 12
[info] Unable to connect to thumbnail 12 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/3.webp" - HTTP Error 404: Not Found. Skipping...
[info] Testing thumbnail 11
[info] Testing thumbnail 10
[info] Unable to connect to thumbnail 10 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/2.webp" - HTTP Error 404: Not Found. Skipping...
[info] Testing thumbnail 9
[info] Testing thumbnail 8
[info] Unable to connect to thumbnail 8 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/1.webp" - HTTP Error 404: Not Found. Skipping...
[info] Testing thumbnail 7
[info] Testing thumbnail 6
[info] Unable to connect to thumbnail 6 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/0.webp" - HTTP Error 404: Not Found. Skipping...
[info] Testing thumbnail 5
[info] Testing thumbnail 4
[info] Testing thumbnail 3
[info] Testing thumbnail 2
[info] Testing thumbnail 1
[info] Testing thumbnail 0
[info] Thumbnails for pS4ca4GB-_c:
ID width   height  URL
0  168     94      https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEbCKgBEF5IVfKriqkDDggBFQAAiEIYAXABwAEG&rs=AOn4CLCBQ4_ln39dFCbgt268t8lMJUtfdA
1  196     110     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEbCMQBEG5IVfKriqkDDggBFQAAiEIYAXABwAEG&rs=AOn4CLACk7_pc2_UMDQ3R-p4Epk4q517Jw
2  246     138     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEcCPYBEIoBSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLCoeij_0sT78RWLVeAwZ_oQZhb8RQ
3  336     188     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg?sqp=-oaymwEcCNACELwBSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLCC9H7tB1SUKxNjuEFpeLGHh4vZxQ
4  480     360     https://i.ytimg.com/vi/pS4ca4GB-_c/hqdefault.jpg
5  unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/0.jpg
7  unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/1.jpg
9  unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/2.jpg
11 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/3.jpg
13 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/default.jpg
18 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/mqdefault.jpg
20 unknown unknown https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.jpg

This doesnt affect actual downloading of the thumbnail except for a warning:
$ yt-dlp -v https://www.youtube.com/watch?v=pS4ca4GB-_c --write-thumb --skip-down
[debug] Command-line config: ['-v', 'https://www.youtube.com/watch?v=pS4ca4GB-_c', '--write-thumb', '--skip-down']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] yt-dlp version 2021.07.07 (source)
[debug] Plugin Extractors: ['SamplePlugin']
[debug] Git HEAD: f0ff9979c6
[debug] Python version 3.9.6 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: ffmpeg 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, ffprobe 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, phantomjs 2.1.1
[debug] Proxy map: {}
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=pS4ca4GB-_c
[youtube] pS4ca4GB-_c: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] pS4ca4GB-_c: Downloading 1 format(s): 248+251
[youtube] pS4ca4GB-_c: Downloading thumbnail  ...
WARNING: Unable to download thumbnail "https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.webp": HTTP Error 404: Not Found
[youtube] pS4ca4GB-_c: Downloading thumbnail  ...
[youtube] pS4ca4GB-_c: Writing thumbnail to: Magnitude 9.1 Earthquake in Japan March 11, 2011 Compilation - Part 1 [pS4ca4GB-_c].jpg

The issue then becomes that the URLs in --print thumbnail, --list-thumbnail and even the infojson may be unreliable unless used with --check-formats (same as #402)
$ yt-dlp -v https://www.youtube.com/watch?v=pS4ca4GB-_c --print thumbnail
[debug] Command-line config: ['-v', 'https://www.youtube.com/watch?v=pS4ca4GB-_c', '--print', 'thumbnail']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] yt-dlp version 2021.07.07 (source)
[debug] Plugin Extractors: ['SamplePlugin']
[debug] Git HEAD: f0ff9979c6
[debug] Python version 3.9.6 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: ffmpeg 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, ffprobe 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, phantomjs 2.1.1
[debug] Proxy map: {}
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=pS4ca4GB-_c
[youtube] pS4ca4GB-_c: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] pS4ca4GB-_c: Downloading 1 format(s): 248+251
https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.webp

$ yt-dlp -v https://www.youtube.com/watch?v=pS4ca4GB-_c --print thumbnail --check-form
[debug] Command-line config: ['-v', 'https://www.youtube.com/watch?v=pS4ca4GB-_c', '--print', 'thumbnail', '--check-form']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] yt-dlp version 2021.07.07 (source)
[debug] Plugin Extractors: ['SamplePlugin']
[debug] Git HEAD: f0ff9979c6
[debug] Python version 3.9.6 (CPython 64bit) - Windows-10-10.0.19043-SP0
[debug] exe versions: ffmpeg 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, ffprobe 2021-04-11-git-309e3cc15c-full_build-www.gyan.dev, phantomjs 2.1.1
[debug] Proxy map: {}
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=pS4ca4GB-_c
[youtube] pS4ca4GB-_c: Downloading webpage
[debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, vcodec:vp9.2(10), acodec, filesize, fs_approx, tbr, vbr, abr, asr, proto, vext, aext, hasaud, source, id
[info] Testing thumbnail 21
[info] Unable to connect to thumbnail 21 URL "https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.webp" - HTTP Error 404: Not Found. Skipping...
[info] Testing thumbnail 20
[debug] Default format spec: bestvideo*+bestaudio/best
[info] Testing format 248
[download] Destination: D:\Programs\Source\yt-dlp\tmpd092ax9p.tmp
[download] 100% of 10.00KiB in 00:00
[info] Testing format 251
[download] Destination: D:\Programs\Source\yt-dlp\tmpnnmdfod4.tmp
[download] 100% of 10.00KiB in 00:00
[info] pS4ca4GB-_c: Downloading 1 format(s): 248+251
https://i.ytimg.com/vi/pS4ca4GB-_c/sddefault.jpg

I suspect that most users are interested only in finding the highest quality thumbnail, with the smaller sizes being less relevant. Perhaps it'd be okay to only include details on the best available thumbnail in the infojson by default, omitting the others completely unless additional flags are provided?
It's probably also fine to treat failed thumbnail requests as expected behaviour, by not printing errors/warnings about them (unless in verbose mode).


fix(app): updated demo app web docker image publishing logic

Signed-off-by: Anton Biriukov<EMAIL_ADDRESS>

Codecov Report
Patch and project coverage have no change.

Comparison is base (a66d961) 90.10% compared to head (c1b509e) 90.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   90.10%   90.10%
=======================================
  Files          98       98
  Lines        3849     3849
=======================================
  Hits         3468     3468
  Misses        253      253
  Partials      128      128

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


All selenium tests failing with :econnrefused

All my selenium tests are failing
148) test local storage is not shared between sessions (Wallaby.Integration.Browser.LocalStorageTest)
     integration_test/cases/browser/local_storage_test.exs:11
     ** (MatchError) no match of right hand side value: {:error, %HTTPoison.Error{id: nil, reason: :econnrefused}}
     stacktrace:
       integration_test/cases/browser/local_storage_test.exs:13: (test)

Do I need some additional setup ?

Do you also have geckodriver installed?

If that doesn't solve it @aaronrenner might have some more insight.

Someone mention "missing setup"?
Thank you @keathley. However, now I get {"error", "unknown command"}:
     integration_test/cases/browser/all_test.exs:11
     ** (FunctionClauseError) no function clause matching in Wallaby.Experimental.Selenium.WebdriverClient.cast_as_element/2
     stacktrace:
       (wallaby) lib/wallaby/experimental/selenium/webdriver_client.ex:383: Wallaby.Experimental.Selenium.WebdriverClient.cast_as_element(%Wallaby.Session{driver: Wallaby.Experimental.Selenium, id: nil, screenshots: [], server: :none, session_url: "http://localhost:4444/wd/hub/session/", url: "http://localhost:4444/wd/hub/session/"}, {"error", "unknown command"})
       (elixir) lib/enum.ex:1233: anonymous fn/3 in Enum.map/2
       (stdlib) lists.erl:1263: :lists.foldl/3
       (elixir) lib/enum.ex:1772: Enum.map/2
       (wallaby) lib/wallaby/experimental/selenium/webdriver_client.ex:34: Wallaby.Experimental.Selenium.WebdriverClient.find_elements/2
       (wallaby) lib/wallaby/browser.ex:1031: anonymous fn/3 in Wallaby.Browser.execute_query/2
       (wallaby) lib/wallaby/browser.ex:142: Wallaby.Browser.retry/2
       (wallaby) lib/wallaby/browser.ex:585: Wallaby.Browser.find/2
       integration_test/cases/browser/all_test.exs:13: (test)

I thought perhaps related to the version of GeckoDriver, but I am running the latest - 16.1.
Any thoughts, @aaronrenner?

If you're on a Mac, the easiest thing to do is install the latest firefox, then
brew install selenium-server-standalone geckodriver

then run selenium with the following command (no need to start geckodriver directly)
selenium-server

That should get you up and running with Selenium 3.4.0 and Geckodriver 0.16.1. Then you can run the wallaby integration tests against selenium in a separate terminal with
WALLABY_DRIVER=selenium mix test

If you're on linux, check out test/tools/start_webdriver.sh for what we do on TravisCI. The steps are different for getting selenium 2 and selenium 3 set up
@keathley, Do you want me to document this setup in the contributing section of the README? I was thinking since the selenium support is still experimental, I wasn't going to call attention to it.

@aaronrenner please most definitely! When new contributors wanna get on board I want them to have a clear path to a good and functioning test setup so they don't run into these errors when they execute mix test.all - I also just noticed that I don't know how to run a single integration test but that's for another issue I think :)

I'll work on documenting it. To run a single integration test, it works like the regular mix test command:
WALLABY_DRIVER=selenium mix test integration_test/cases/browser/visible_test.exs

or
WALLABY_DRIVER=selenium mix test integration_test/cases/browser/visible_test.exs:37

@aaronrenner thanks! We might wanna work on a better error message then though, as without the set driver it fails with a nasty compilation error:
mix test integration_test/cases/browser/visible_test.exs
Compiling 6 files (.ex)
Excluding tags: [pending: true]

** (CompileError) integration_test/cases/browser/visible_test.exs:2: module Wallaby.Integration.SessionCase is not loaded and could not be found
    (elixir) expanding macro: Kernel.use/2
    integration_test/cases/browser/visible_test.exs:2: Wallaby.Integration.Browser.VisibleTest (module)
    (elixir) lib/code.ex:370: Code.require_file/2

I've added more details to the README that explain how to setup the other drivers. Going to close this for now.


Issue with k8s.io/docs/home/

Hi @Suhrad . Can you please provide some details on what issue you are seeing on the home page?
/triage needs-information

/close


Panning map editor on Android

I know @nesbox is aware of this issue but it is currently impossible to pan the map editor viewport on Android. This means you cannot edit the top row at all. Any solution would be greatly appreciated at this point!

You can select edit area by dragging red rectangle

closing on .25


CLOUD-54477 fix lazy exception caused by missing transaction

@schfeca75 only

Jenkins build failed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2275/

Jenkins build finished, all tests passed.
Refer to this link for build results: http://ci.sequenceiq.com/job/cloudbreak-pull-request/2276/


start up bug(Segmentation fault)

I encountered a bug during startup. The log file is as follows
--------------------------------------------
   Hyprland Crash Report
--------------------------------------------
This was an accident, I swear!

Hyprland received signal 11 (Segmentation fault)

Version: c86f06caa0be207882266947da67125177bba5af

System info:
	System name: Linux
	Node name: moon
	Release: 6.2.11-arch1-1
	Version: #1 SMP PREEMPT_DYNAMIC Thu, 13 Apr 2023 16:59:24 +0000

GPU:
	00:02.0 VGA compatible controller [0300]: Intel Corporation CoffeeLake-H GT2 [UHD Graphics 630] [8086:3e9b] (prog-if 00 [VGA controller])
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP107M [GeForce GTX 1050 Ti Mobile] [10de:1c8c] (rev a1) (prog-if 00 [VGA controller])

os-release:
	NAME="Arch Linux"
	PRETTY_NAME="Arch Linux"
	ID=arch
	BUILD_ID=rolling
	ANSI_COLOR="38;2;23;147;209"
	HOME_URL="https://archlinux.org/"
	DOCUMENTATION_URL="https://wiki.archlinux.org/"
	SUPPORT_URL="https://bbs.archlinux.org/"
	BUG_REPORT_URL="https://bugs.archlinux.org/"
	PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
	LOGO=archlinux-logo

Backtrace:
	#0 | Hyprland(_ZN13CrashReporter18createAndSaveCrashEi+0x831) [0x55c9c5bd56b1]
		??
		??:0
	#1 | Hyprland(_Z25handleUnrecoverableSignali+0x3c) [0x55c9c5b7151c]
		??
		??:0
	#2 | /usr/lib/libc.so.6(+0x38f50) [0x7f5aeed69f50]
		??
		??:0
	#3 | /usr/lib/gbm/nvidia-drm_gbm.so(+0x1556b) [0x7f5ade41556b]
		??
		??:0
	#4 | /usr/lib/gbm/nvidia-drm_gbm.so(+0x15838) [0x7f5ade415838]
		??
		??:0
	#5 | /usr/lib/libgbm.so.1(+0x4e59) [0x7f5aef243e59]
		??
		??:0
	#6 | /usr/lib/libgbm.so.1(gbm_create_device+0x61) [0x7f5aef245ab1]
		??
		??:0
	#7 | /usr/lib/libwlroots.so.12032(wlr_gbm_allocator_create+0x7e) [0x7f5aef94480e]
		??
		??:0
	#8 | /usr/lib/libwlroots.so.12032(+0x4c72a) [0x7f5aef94372a]
		??
		??:0
	#9 | /usr/lib/libwlroots.so.12032(+0x56efe) [0x7f5aef94defe]
		??
		??:0
	#10 | /usr/lib/libwlroots.so.12032(wlr_drm_backend_create+0x21e) [0x7f5aef9483de]
		??
		??:0
	#11 | /usr/lib/libwlroots.so.12032(+0x4dac4) [0x7f5aef944ac4]
		??
		??:0
	#12 | /usr/lib/libwlroots.so.12032(wlr_backend_autocreate+0x6b1) [0x7f5aef9453b1]
		??
		??:0
	#13 | Hyprland(_ZN11CCompositor10initServerEv+0x111) [0x55c9c5b818c1]
		??
		??:0
	#14 | Hyprland(main+0x47f) [0x55c9c5b62a2f]
		??
		??:0
	#15 | /usr/lib/libc.so.6(+0x23790) [0x7f5aeed54790]
		??
		??:0
	#16 | /usr/lib/libc.so.6(__libc_start_main+0x8a) [0x7f5aeed5484a]
		??
		??:0
	#17 | Hyprland(_start+0x25) [0x55c9c5b713c5]
		??
		??:0

Log tail:
[LOG] Node name: moon
[LOG] Release: 6.2.11-arch1-1
[LOG] Version: #1 SMP PREEMPT_DYNAMIC Thu, 13 Apr 2023 16:59:24 +0000

[LOG] GPU information:
00:02.0 VGA compatible controller [0300]: Intel Corporation CoffeeLake-H GT2 [UHD Graphics 630] [8086:3e9b] (prog-if 00 [VGA controller])
01:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP107M [GeForce GTX 1050 Ti Mobile] [10de:1c8c] (rev a1) (prog-if 00 [VGA controller])

[WARN] Warning: you're using an NVIDIA GPU. Make sure you follow the instructions on the wiki if anything is amiss.

[LOG] os-release:
NAME="Arch Linux"
PRETTY_NAME="Arch Linux"
ID=arch
BUILD_ID=rolling
ANSI_COLOR="38;2;23;147;209"
HOME_URL="https://archlinux.org/"
DOCUMENTATION_URL="https://wiki.archlinux.org/"
SUPPORT_URL="https://bbs.archlinux.org/"
BUG_REPORT_URL="https://bugs.archlinux.org/"
PRIVACY_POLICY_URL="https://terms.archlinux.org/docs/privacy-policy/"
LOGO=archlinux-logo

[LOG] ========================

[INFO] If you are crashing, or encounter any bugs, please consult https://wiki.hyprland.org/Crashes-and-Bugs/

[LOG]
Current splash: "my win11 install runs hyprland that is true" - raf

[LOG] Creating the HookSystem!
[LOG] Creating the KeybindManager!
[LOG] Creating the AnimationManager!
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 648.47µs. Estimated average calc time: 0.00µs.
[LOG] Creating the ConfigManager!
[LOG] Creating the CHyprError!
[LOG]  [hookSystem] New hook event registered: focusedMon
[LOG]  [hookSystem] New hook event registered: preRender
[LOG] Creating the LayoutManager!
[LOG] Reloading the config!
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 11.03µs. Estimated average calc time: 0.00µs.
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 11.01µs. Estimated average calc time: 0.00µs.
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 10.92µs. Estimated average calc time: 0.00µs.
[LOG] Created a bezier curve, baked 255 points, mem usage: 4.08kB, time to bake: 10.90µs. Estimated average calc time: 0.00µs.

nvidia issue. If the nvidia tutorial doesn't help, out of luck


[TwitterBridge] URL's returned have a double slash

Steps to reproduce:

Access https://bridge.suumitsu.eu/?action=display&bridge=Twitter&u=twitter&format=Atom

Expected results:
URL's should begin with https://twitter.com/Twitter/status/, e.g. https://twitter.com/Twitter/status/874766476569399297.
Observed results:
URL's begin with https://twitter.com//Twitter/status/, e.g. https://twitter.com//Twitter/status/874766476569399297 (note the double slash after twitter.com).
This seems to be mostly harmless, since Twitter accepts either form without erroring, but it's still unexpected.

Thanks for reporting :+1:
I have pushed a fix, please check the latest master.


feat(docs): autogenerate readme with terraform docs

Signed-off-by: Bruce Becker<EMAIL_ADDRESS>

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add information about compression options

v2 can compress JavaScript files in three ways, and that has to be
added to the docs. :-)

Thanks for this! I like it, but think we can make it a little more, uhm, compact:
https://github.com/faucet-pipeline/faucet-pipeline.github.io/compare/doc_improvements_compact_js...compacting-docs
WDYT?

Thank you 👏 I think we need to clarify (in both versions) that you always need to provide the --compact flag when you want compaction. No matter which "level" of compaction you choose.

Good point, I've updated my branch (which is still just a rough suggestion, so could certainly be improved).

I like it 👍

Thanks 🙇


add Artery at32

Summary
Impact
Testing

@laoniaokkk look like at32 is very similar to stm32?

@laoniaokkk look like at32 is very similar to stm32?

@xiaoxiang781216  Yes, this is similar to STM32, but there are some differences, you can learn more from this website: https://www.arterytek.com/en/product/AT32F437.jsp

@laoniaokkk look like at32 is very similar to stm32?

@xiaoxiang781216 Yes, this is similar to STM32, but there are some differences, you can learn more from this website: https://www.arterytek.com/en/product/AT32F437.jsp

Ok, but why close this PR?

I'm sorry, I'm not very proficient in these features, I'm ready to submit PR again after fixing the bug from last PR. Is there any way to locally detect that the current code meets the nuttx spec? @xiaoxiang781216

I'm sorry, I'm not very proficient in these features, I'm ready to submit PR again after fixing the bug from last PR.

you don't need close pr, just update it like this:
1.Do whatever change you like, and git commit --amend to your original patch
2.run this below command:
git remote add apache git@github.com:apache/nuttx.git
git fetch apache
git rebase apache/master
git push -f origin

this first command just need run once.

Is there any way to locally detect that the current code meets the nuttx spec? @xiaoxiang781216

Yes, you can run this follow command to ensure the patch conform nuttx style:
./tools/checkpatch.sh -g HEAD~...HEAD

@laoniaokkk please squash your patch into one:
git rebase --interactive HEAD~5...HEAD
change pick to sqaush
correct the comment
gt push -f origin

@laoniaokkk not squash your change yet.

@laoniaokkk not squash your change yet.

I am trying to do it @xiaoxiang781216
git rebase --interactive HEAD~5...HEAD
fatal: Needed a single revision
无效的上游 'HEAD~5...HEAD'

how about:
git rebase --interactive 68b8006ee961b79d6bdb14173856fb3443a4d13e

BTW, please rebase to the last master version after sqaush:
git remote add apache git@github.com:apache/nuttx.git
git fetch apache
git rebase apache/master
git push -f origin

@laoniaokkk please squash the style change into the first patch too.

Build / Linux (risc-v) (pull_request) Failing after 150m
Build / macOS (sim-01) (pull_request) Failing after 70m
Build / macOS (sim-02) (pull_request) Cancelled after 70m
I didn't change these, but the compilation shows failure, what should I do about it? @xiaoxiang781216

these errors are fixed by: https://github.com/apache/nuttx/pull/10699 and https://github.com/apache/nuttx-apps/pull/2073.
So, please fetch and rebase to the last master and push again.