Deployment/PyPi publication considerations and workflow

Just starting a discussion about what preferences we would have regarding the publication workflow.
CI/CD
I'm assuming we would want some form of CI/CD setup, in the past @andylaw used Travis CI but in our chat a while back it was suggested we could switch to GitHub Actions. I'm happy with Actions if everyone else is.
Branches and deployment
The Travis CI setup deploys the staging branch to test.pypi.org and the main branch to the live pypi.org site, which seems like a good pattern. My initial PRs have been against main but in future I will PR against development
Hence:
development -> local testing
staging -> https://test.pypi.org/project/nhs-number/
main -> https://pypi.org/project/nhs-number/
Versioning
We should continue to use SemVer as per @andylaw's prior work. Some tools exist to auto-increment the version number, one is Bump2Version, and another is this neat mechanism using GitHub Actions and a workflow_dispatch trigger: https://www.seanh.cc/2022/05/21/publishing-python-packages-from-github-actions/#automatically-generating-the-next-version-number
Code coverage
Do we use coverage or CodeCov? I'm happy to use CodeCov if it is free for OSS projects (it seems to be) and adds additional features.

Update on this

Testing no occurs for all pushes to, and PRs against, any branch. Tests are performed across a matrix of 5 Python versions, 3.7 thorugh to 3.11.
Deployment is now achieved through GitHub Actions and is now working, for the staging -> test.pypi.org deploy. Once we are happy with this and confident about publication we and set up the same publication for live pypi.org.

What happens if I try to push a commit to a branch and there are failing tests? Does the push fail?

The push would succeed, but on GitHub the 'tests' Action would fail and you would get an email to say it had failed.
It means you would get an early warning that something wasn't right, and could avoid merging those commits further onwards, or avoid merging a PR with failing tests.

The only outstanding part of this issue is some form of test coverage metric. I have used coverage before but not codecov, which I understand is a web tool which would enable us to show the coverage in a badge on GH?
Any views on what we should use?

You mean the badge that's in the table at the top of the page at https://pypi.org/project/nhs-number/ under "Coverage"?

Yep, I saw this but do we need to do anything to that badge to make it work with the new repo name? GH automatically redirects but at present it's pointing to https://codecov.io/gh/andylaw/NhsNumberChecks/branch/main/graph/badge.svg which is the old repo name.
I had assumed the coverage metric there was from the old version, altough I would hope we have not regressed in terms of coverage in the new version.

You're right - it does !!
Edit the Readme.md file and see what happens

(and maybe break some tests or add some additional code to see if you can make the number changes)


Document how to an author can configure a filter that restricts their feed to only xamarin posts

namespace Firehose.Web.Authors
{
    public class AndrewHarcourt : IAmAReadifarian, IFilterMyBlogPosts
    {
        // TODO: Fill in all your details
        // TODO implement the Filter method any way you like :)
    }
}

@jfversluis your template was merged into https://github.com/ghuntley/planetxamarin earlier this morning. We still need some more information / examples how to filter categories then this issue can be closed.

Added the main idea of this with #32 and thus can be closed


Is there a way to set the ntp servers?

My cameras don't have internet access. Is there a way to specify a local NTP server instead of having the cameras try to access public ones?


Domain restriction

Description
Domain restriction is limited to two level, our adresse have four!
Screenshots

Additional information
No response

Thank you for the report! Domains are fun!


[test] CP2K checks on Eiger

I have re-defined self.executable = '--cpu-bind=cores cp2k.psmp' as suggested by @jjotero, since I could not find a simpler way to add the srun flag --cpu-bind=cores to the command line. The apparently weird setting of num_cpus_per_task=16 and OMP_NUM_THREADS=8 yields a better performance with respect to num_cpus_per_task=8 and 'OMP_NUM_THREADS': str(self.num_cpus_per_task) (see the related issue https://jira.cscs.ch/projects/SD/queues/custom/48/SD-51051).
In order to improve a bit more the performance of the test, I would also like to add the following Slurm directive:
#SBATCH --distribution=block:block

I found in the documentation the job_opts parameter, but the warning says that in version 3.0 you may not override this method directly unless you are in special test (https://reframe-hpc.readthedocs.io/en/stable/regression_test_api.html?highlight=job_opts#reframe.core.pipeline.RegressionTest.setup).
Are there other options to add custom Slurm directives to the check without creating a check using special=True?

Hello @lucamar, Thank you for submitting the Pull Request!

In the file cscs-checks/apps/cp2k/cp2k_check.py:

Line 19:1: W293 blank line contains whitespace
Line 74:18: W291 trailing whitespace
Line 91:18: W291 trailing whitespace

Do see the ReFrame Coding Style Guide

Codecov Report

Merging #1660 (23febda) into master (0227b31) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1660   +/-   ##
=======================================
  Coverage   87.55%   87.55%
=======================================
  Files          45       45
  Lines        7494     7494
=======================================
  Hits         6561     6561
  Misses        933      933

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0227b31...23febda. Read the comment docs.

@jenkins-cscs retry dom


chore(deps): update dependency semantic-release to v17.0.6

This PR contains the following updates:

Package
Type
Update
Change

semantic-release
devDependencies
patch
17.0.4 -> 17.0.6

Release Notes

semantic-release/semantic-release
v17.0.6
Compare Source
Bug Fixes

adapt for semver to version 7.3.2 (part II) (#1530) (431d571)

v17.0.5
Compare Source
Bug Fixes

adapt for semver to version 7.3.2 (0363790)

Renovate configuration
:date: Schedule: At any time (no schedule defined).
:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.
:recycle: Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".
:no_bell: Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

Available now for Enterprise: Renovate Pro with real-time webhook handling and priority job queue.

:tada: This PR is included in version 5.0.32 :tada:
The release is available on:

v5.0.32
GitHub release

Your semantic-release bot :package::rocket:


Soundbars as receiver?

Is your feature request related to a problem? Please describe:
Samsung soundbar only shown as switch
Describe the solution you'd like:
show Samsung soundbar as receiver so we can switch sources, volume and power! That would be so cool!
Thaaaanks

@neverwalkerwan , please follow the directions in the following link and send me the detailed logs when you start up homebridge.  I have to see what capabiliites the soundbar advertises.
Instructions for Producing a Detailed Log.pdf

Closing due to lack of response.


Automatic file closing and better file reading

The main added data structure is the heap. It is a big mmap that acts kinda like malloc's fast bins.
Each slot starts uninitialized. Upon initialization, we just use it as memory to store 1 specific type (always the same size).
Upon free, we instead use the slot to be part of a linked list of free slots.
Free slots are always reused first. Otherwise, we just grab the next slot in the mmap an allocate it.
In our case, we always store an reference count and some data that rust will free.
Upon roc freeing a slot, we tell rust to free the stored data.

It's really nice having files automatically close 👍

I think this should be fine to merge. It no longer has any mmap api exposed to roc. I think it would be good to get a double check over the heap code, but otherwise is mostly minor changes. @rtfeldman, I think you would be best for the heap review?

Sounds good! I'll take a look tonight 🤘


proxy

hi, the proxies doesn't work, can you compile the latest version to binaries ? thanks

Hi, I have noticed that authentication proxies (-ap) might not work correctly, I have to take a deeper look into this issue, however after extensive testing of the '-sp' parameter, using socks5 proxies (other types will not work) directly (host:port) and indirectly (using a file), I came to the conclusion that there is no issue.  Or you might try to connect to a server that blocks proxies. The binaries are by the way already updated.

I'm getting this error with any socks5 I'm trying:
Client disconnected: java.net.SocketException: Malformed reply from SOCKS server:


I need help troubleshooting with @auth/core

I want to debug with a local checked out https://github.com/nextauthjs/next-auth.git.
I tried:
cd ~/src/next-auth
pnpm install

cd ~/src/next-auth/packages/core
pnpm build

cd ~/src/next-auth
npm link

# in my project
npm uninstall @auth/core
npm link @auth/core

My project then seem to use the code from ~/src/next-auth, but I got some __vite_ssr_import_0__.renderToString is not a function errors.
Do you use something similar?

Nah, I didn't pull the local version of auth.js. I just used a browser built-in debugger and I modified files in node_modules to check things.

Thanks!


rate limit not appearing on following endpoint + rate limit logic

Hi,
I am trying to display the rate limit for the following endpoint using the debug=1 parameter. However, this is all that shows up, which is the same as the result without the debug endpoint:
Following: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00,  1.03it/s]
Also, is the request limit based on the number of users' queried or the number of paginations? And if it is the number of paginations, how many following need to be queried for each pagination to be hit? I am conducting a large scale scrap and need all the information before having the script run.
Thanks!

As a follow up, I tried querying a user's following list (12 following) 125 times before hitting the limit, so I'm a little confused about the discrepancy between that amount the 50 requests per 15 min as mentioned in the documentation.

Also, is the request limit based on the number of users' queried or the number of paginations?

for the Scraper class all method's rate limits relate to a single request made to a GraphQL endpoint.

As a follow up, I tried querying a user's following list (12 following) 125 times before hitting the limit, so I'm a little confused about the discrepancy between that amount the 50 requests per 15 min as mentioned in the documentation.

things could have changed over time, I will look into this and update the readme
for now, i've added a rate_limits property that you can use to see what the current limits for each method are.


Design and implement TX row for incomplete TC LP deposit

Overview
re: https://github.com/shapeshift/web/issues/6094
References and additional details
See TS screenshot
Acceptance Criteria

tx row mock and implementation create to show incomplete state

Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

Thorswap UI for an incomplete symmetrical position:

We will also want to ensure that this gives the option to withdraw if a user changed their mind and wishes to withdraw instead of completing their deposit

We now have an "Incomplete" tag on pool positions (https://github.com/shapeshift/web/pull/6481) - this ticket feels complete.
@kaladinlight @gomesalexandre let me know/re-open if there is still more work to be done here.

We now have an "Incomplete" tag on pool positions (#6481) - this ticket feels complete.
@kaladinlight @gomesalexandre let me know/re-open if there is still more work to be done here.

Feels like this issue has been completed. Another ticket can be written up if we wish to update/change the UI/UX for this flow at all with product mocks included. :+1:


When setting "python.pythonPath" to "python", resolve python interpreter in the same way as we resolve 'python' in terminal

Question
Why does setting "python.pythonPath" to "python" trigger automatic path detection instead of regular path resolution as in which python/where python?
The regular path resolution would be much more useful and less counter-intuitive when working with virtual environments or manually compiled python distributions that happens to be placed before the system python installation in the PATH environment variable.
IMO explicitly specifying a setting shouldn't be treated as not specifying it at all. At the very least it should be clear to the user that the path resolution is only done if the setting is not empty and not equal to "python"  (which is still bad but much more transparent to the user).
The line containing the relevant logic can be found here.

Hi @lucaslugao, We've marked this issue as needs decision to make a decision on whether we need this enhancement or not.
As you described, setting "python.pythonPath" to "python" is equivalent to not setting "python.pythonPath" at all.
Just for your info, these are our rules for auto-selecting an interpreter (automatic python path detection). Checking PATH environment variable comes 4th in the priority list right now.

First check user settings.json
If we have user settings, then always use that, do not proceed.
Check workspace virtual environments (pipenv, etc).
If we have some, then use those as preferred workspace environments.
Check list of cached interpreters (previously cachced from all the rules).
If we find a good one, use that as preferred global env.
Provided its better than what we have already cached as globally preffered interpreter (globallyPreferredInterpreter).
Check current path.
If we find a good one, use that as preferred global env.
Provided its better than what we have already cached as globally preffered interpreter (globallyPreferredInterpreter).
Check windows registry.
If we find a good one, use that as preferred global env.
Provided its better than what we have already cached as globally preffered interpreter (globallyPreferredInterpreter).
Check the entire system.
If we find a good one, use that as preferred global env.
Provided its better than what we have already cached as globally preffered interpreter (globallyPreferredInterpreter).

Currently, setting "python.pythonPath" to "python" is equivalent to not setting "python.pythonPath" at all. We possibly can change that behavior.

Unfortunately the requirement isn't been clear to me.
@karrtikr?

Currently, setting "python.pythonPath" to "python" is equivalent to not setting "python.pythonPath" at all. We currently auto-select interpreters in both cases.
The requirement is that when "python.pythonPath" is set to "python", instead of auto-selecting the interpreter, select the same interpreter that is referred to when typing "python xyz.py" in terminal. Hope that's clearer now.

Thanks for the suggestion 👍 but we decided not to move forward with this idea for now.


Expose coverage report to sonarcloud

This PR ...
If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.
Test Steps:

Include steps to test these changes

Changes

Include a comprehensive list of changes in this PR
(For web UI changes) Include screenshots/video of changes

Checklist
Testing

[ ] Tested locally?
[ ] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[ ] (For Changes to /frontend-react/...) Ran npm run lint:write?
[ ] Added tests?

Process

[ ] Are there licensing issues with any new dependencies introduced?
[ ] Includes a summary of what a code reviewer should test/verify?
[ ] Updated the release notes?
[ ] Database changes are submitted as a separate PR?
[ ] DevOps team has been notified if PR requires ops support?

Fixes

#issue - List GitHub issues this PR fixes

To Be Done
Create GitHub issues to track the work remaining, if any

#issue

Specific Security-related subjects a reviewer should pay specific attention to

Does this PR introduce new endpoints?

new endpoint A
new endpoint B

Does this PR include changes in authentication and/or authorization of existing endpoints?
Does this change introduce new dependencies that need vetting?
Does this change require changes to our infrastructure?
Does logging contain sensitive data?
Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated

Spoofing (faking authenticity)

Threat T, which could be achieved by A, is mitigated by M

Tampering (influence or sabotage the integrity of information, data, or system)
Repudiation (the ability to dispute the origin or originator of an action)
Information disclosure (data made available to entities who should not have it)
Denial of service (make a resource unavailable)
Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)

Have you ensured logging does not contain sensitive data?
Have you received any additional approvals needed for this change?

Pull reviewers stats
Stats for the last 30 days:

User
Total reviews
Time to review
Total comments

cwinters-usds
22
5h 23m
14

TomNUSDS
15
1h 18m
29

carlosfelix2
14
2h 17m
36

MauriceReeves-usds
11
19h 40m
7

jimduff-usds
9
44m
12

jbiskie
8
1h 27m
0

brick-green-agile6
8
18h 7m
2

sethdarragile6
8
40m
0

kevinhaube
7
12m
0

jeremy-page
7
5m
0

JosiahSiegel
6
4m
0

oslynn
6
20m
1

snesm
6
59m
3

ahay-agile6
5
13m
0

clediggins-usds
5
4h 2m
4

bgantick
4
16m
1

TurkeyFried
4
3d 1h 2m
1

jh765
4
1h 26m
4

RickHawesUSDS
3
3d 8h 47m
2

acoushawk
2
4m
0

jorg3lopez
2
4d 11h 2m
0

whytheplatypus
1
13m
2

rhood23699
1
15m
0

This whole PR is pending a switch over to CI-based analysis in SonarCloud (vs the current automatic analysis setup we have now) - see #5339

CI analysis seems to take this path.  Note that SonarCloud Automatic Analysis is currently On.


Changed Font, Added Margin

Ok I will try
On Fri, Nov 27, 2020 at 7:30 PM Rajas Paranjpe<EMAIL_ADDRESS>wrote:

@ChocolateLoverRaj commented on this pull request.
Can you please provide an example screenshot?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ChocolateLoverRaj/smart-photo-copier/pull/2#pullrequestreview-540218830,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMXCBS2VEORKL6LYLVVTVDTSSBHFDANCNFSM4UFFPS7A
.


added icons to dashboard/homepage and create file for friend group an…

…d add friend

Loving the icons! I just pushed 1 commit on your branch to fix a syntax compile error, so make sure to pull from the remote before continuing work @heejung-hong


Help me I have a problem

I'm testing AOS on this site: https://archetipo95.github.io/Material.Design.Site/
As you can see animations are not working and I don't know why.

Can you help me, sorry I'm new to web design maybe it's just my fault.

This is an other example: http://codepen.io/anon/pen/WowrJp
I can't animate even this.

<script>
  AOS.init({
    easing: 'ease-in-out-sine'
  });
</script>

Solved my problem

I had a similar issue but was able to resolve. If you're reading this and used the provided CDN's please read.
Crack open inspect element in your browser and do the following:

Check the DOM element where you added data-aos="blah" and scroll. If JS is loaded you'll see the class names change dynamically. If that works, your JS file is good but your css may be missing.

Select Sources to verify 'cdn.rawgit.com/michalsnik/aos/2.*(version you're on) is there and loads both aos.js and aos.css. My css didn't load even using the provided CDN so I manual placed the css file.

Hope this helps.


Code Sample confuses axisDefault and axisDefaultValue

The code samples on how to normalize the axis value into -1…0…+1 uses two variable names for hte same thing: axisDefault and axisDefaultValue, but should only use one of them.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06ab9f03-9923-3400-5ae2-b650dcf7fb83
Version Independent ID: 8b1c2a74-1f8e-cfc3-6472-36727c362e71
Content: avar — Axis variations table - Typography
Content Source: typographydocs/opentype/spec/avar.md
Product: typography
GitHub Login: @PeterCon
Microsoft Alias: PeterCon

Fixed for next version: two instances of "axisDefaultValue" have been changed to "axisDefault".


Making a dry run test.

Signed-off-by: zhangxin<EMAIL_ADDRESS>

Test succeeded; I'm assuming this was just for testing, so I'll close this PR


Asset: Add Settings to connect to the Schneider BMS

@LucasBrazi06 commented on Mon Dec 23 2019

@LucasBrazi06 commented on Thu May 14 2020
Implement now the backend part to save the settings.
Pay attention to the sensistive data.

Dups of LucasBrazi06/ev-dashboard#1004


CVarInt format is not de-serialised correctly

The core wallet serialises larger (?) integers into the CVarInt format which is not read correctly by pybit.py3.common.Common. Any time a CVarInt is parsed, it returns as a massive number that breaks everything downstream of it.
https://bitcoin.stackexchange.com/questions/51620/cvarint-serialization-format
    def read_var(self,
                 pr: bool=False) -> bytes:
        """
        Read next variable length input. These are described in specifiction:
        https://en.bitcoin.it/wiki/Protocol_documentation#Variable_length_integer
        Retuns output and number of steps taken by cursor
        """
        # For debugging
        start = self.cursor

        # Get the next byte
   # CVarInt needs to be detected here?
        by = self.read_next(1)
        o = ord(by)

        if pr:
            print(by)

        if o < 253:
            # Return as is
            # by is already int here
            out = by

        elif o == 253:  # 0xfd
            # Read next 2 bytes
            # Reverse endedness
            # Convert to int in base 16
            out = self.read_next(2)

        elif o == 254:  # 0xfe
            # Read next 4 bytes, convert as above
            out = self.read_next(4)

        elif o == 255:  # 0xff
            # Read next 8 bytes, convert as above
            out = self.read_next(8)

        if pr:
            print(int(codecs.encode(out[::-1], "hex"), 16))

        return out

Two things that may help:

There are two different int compression methods : CCompactSize and CVarInt.
I think what your want is the first one. CVarInt is not used in block dat files.

See Peter Wuille's answer here: https://bitcoin.stackexchange.com/questions/51620/cvarint-serialization-format
Saying : "Still wrong. He's asking about the CVarInt used in UTXOs internally in Bitcoin Core. Not the variable-length push in scripts, or the CCompactLen used in the P2P protocol."

I think the problem is that .dat files may be corrupted.

See Peter Wuille's answer here.
https://bitcoin.stackexchange.com/questions/86159/differences-to-ccompactsize-and-cvarint

"Blocks have well defined data only. But the files can contain garbage in addition to the blocks. There is an index database that stores which position each block is stored at."
I think the right solution would be to parse LevelDB files inside directory index/ to get exact location of blocks in .dat files.
You can get offset in file using thiese db :
https://bitcoin.stackexchange.com/questions/28168/what-are-the-keys-used-in-the-blockchain-leveldb-ie-what-are-the-keyvalue-pair
(be careful at the end of the thread though, it is misleading)

Hi @papipig, thank you very much for the info and links!


Vendor Email confirmation

I have an app that uses its services to sell products from within the app to users but every time a user tries to purchase a product, it says "vendor account doesnt have a verified email address paypal" any solution please?

Hi @MAtech1850,
Thank you for reposting this issue. You will need to add your email address to PayPal dev portal as merchant and fill out all the information needed there and verify your email. If you still see this issue please report it on this portal https://www.paypal-community.com/t5/Sandbox-Environment/vendor-account-does-not-have-a-confirmed-email-address/td-p/2804018
I don't believe this issue related to the android-checkout-sdk. It more related to how your account should be setup probably. Please let us know if you have any additional questions and I will be more than happy to help :)

Closing this issue as it's not relevant to android-checkout-sdk please feel free to reopen it if you need additional help :)


Initial 2D UNet Model Application for the HIPMRI Study

Initial 2D UNet Model Application for the HIPMRI Study
Submitted by Karan Vijay Shankar - 47101425
This pull request introduces the initial implementation of the 2D UNet model for medical image segmentation in the HIPMRI study. It includes key components and scripts required to train, test, and validate the model, along with utility functions for handling the dataset. The following files are included:

utils.py: Contains helper functions to_channels and load_data_2D, which preprocess NIFTI image data into arrays suitable for the model.
database.py: Defines a database class to organize and manage the image dataset, assigning images to their respective segmentation labels.
modules.py: Implements the UNet architecture using TensorFlow (Keras), following the standard UNet design for image segmentation tasks.
train.py: Trains the UNet model on the HIPMRI dataset using an SGD optimizer, Dice coefficient loss function, and a CosineDecay learning rate scheduler. The trained model is saved upon completion.
predict.py: Loads the saved model and applies it to the validation dataset, generating predictions for evaluation.
test_driver_script.py: An optional script that simplifies the process of running train.py and predict.py with custom image directories through command-line arguments.

As this is an initial commit, all of the code is functional. However, due to lack of training, the hyperparameters and model configurations are subject to refinement in future updates. Additionally, certain visual outputs, such as the sample image plots (actual vs. ground truth vs. predicted mask), may be adjusted. Extended queue times for model training and validation may limit the inclusion of ideal results at the time of submission.

<This is an initial inspection, no action is required at this point.>
File Organizing: Well-organized files.
Problem Solving:

The algorithm solves the problem appropriately.
Accuracy in testing dataset: 0.8883.

Model and functions:

It correctly uses Tensorflow to construct the 2D-UNet model and functions.
No data augmentation.
Using training/validation dataset to train and test UNet model. However, students are expected to use the training dataset to train the model and the validation dataset to observe the model performance in the training phase, then to use the test dataset to test the model performance on the unseen data.

Code design: Good.
Code comment and docstring:

Good code comments
Good function docstrings

Difficulty: Easy.
Additional Comments:

Meaningless commits, just some "update xxxx" commits and most of them were updating README file.
Conclusion and reference are expected to be in the report.

Marking

Good/OK/Fair Practice (Design/Commenting, TF/Torch Usage)
Good design and implementation.
Spacing and comments.
No Header blocks. -1
Recognition Problem
Good solution to problem.
Driver Script present.
File structure present.
Good Usage & Demo & Visualisation & Data usage.
Module present.
Commenting present.
No Data leakage found.
Difficulty : Easy. UNet2D (Easy Difficulty)-10
Commit Log
Some/Adequate Meaningful commit messages. -1
Some/Adequate Progressive commits. Commits lack purpose.-1
Documentation
Readme :Acceptable. -1
Model/technical explanation :Good.
Description and Comments :Acceptable. No referencing.-1
Markdown used and PDF submitted. PDF checked.
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch). Submitted on time.
No Feedback required.
Request Description is good.
TOTAL-15

Marked as per the due date and changes after which aren't necessarily allowed to contribute to grade for fairness.
Subject to approval from Shakes

Visualisations not clear if model training completed, output does not show quality segmentation. -2, does not use one hot encoding -2


NO-TICKET: Limit message size in chainspec

This ensures that nodes are in agreement about what the maximum message size is through the chainspec.

I don't think this should be a chainspec config after all. I think the networking should allow arbitrarily large messages and if there's a business/domain limit then that should be applied in a proper component rather than the networking layer.

I don't think this should be a chainspec config after all.

This is somewhat debateable, but the maximum size of anything sent across the network depends on values from the chainspec, so in theory we should be able to calculate it from the chainspec anyway. Right now, we just shortcut the otherwise somewhat complex estimate by putting in an explicit value.
It would be perfectly fine to have this value configurable by node operators, except that it would not gain us anything while at the same potentially breaking things. If nodes differ in their opinion on the maximum acceptable message size for network messages, we will run into issues.
To the best of my knowledge, the chainspec contains "values all nodes need to agree on" as a rule of thumb, so using that definition, I think it is a good place to keep it.

I think the networking should allow arbitrarily large messages

We can never allow arbitrarily large messages because we cannot afford to spend arbitrarily large amounts of memory before starting to validate contents. If large sizes (the current limit is an initial one, bound to come down soon) are required for contents, a chunking scheme will have to be implemented (which is in the works, just not for this release).

and if there's a business/domain limit then that should be applied in a proper component rather than the networking layer.

This is purely a layer in the defense against a resource exhaustion; the acceptable size for a deploy or other things is still not determined by the networking layer. There just has to be some bound for the network to function, otherwise nodes are trivially crashable.

bors r+


Add new page for Checkpointing Storage Account Troubleshooting

Dears. I am from Event Hub support Team.
We get many issues related to Storage Accounts used for checkpointing when using event hub processors. We have a set of things that storage accounts need to fulfill regardless of which SDk is used, it is valid for .Net/Java/Python and all.
I suggest either adding this list to one one of the SDKs pages here (like this .Net page), or adding them in a separate page and having links to them from all pages.
Maybe best place for this new page would be under troubleshooting. (maybe: Troubleshooting storage checkpoint issues). Issue can be related to delays in processing, or errors thrown by SDK related to storage, like failures to create checkpoints.
The list of recommendations we send to customer always are:

Need to use separate storage container for each processors group. Same storage account can be used, but use one container per each group.
Do not use the container for anything else, and do not use the storage account for anything else.
Storage account should be in same region as deployed application. If application is on premise, try to choose the closes region possible.
Ensure the storage account does not have soft delete enabled as this is not supported for the checkpoint store. Soft delete can cause serious delays.
Ensure the storage account does not have Versioning  enabled as this is not supported for the checkpoint store. Soft delete can cause serious delays.
Don't use a hierarchical storage (Azure Data Lake Storage Gen 2) as a checkpoint store.

Some of this information was requested by our customers to be mentioned officially in our documentation for their reference. Please reach out to me for any notes.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c4c6d63e-95f5-de2c-972b-4da5fe71a6a6
Version Independent ID: 338bbd1b-d86d-ff48-0b8a-1d48cb9547f2
Content: Quickstart: Send or receive events using .NET - Azure Event Hubs
Content Source: articles/event-hubs/event-hubs-dotnet-standard-getstarted-send.md
Service: event-hubs
GitHub Login: @spelluru
Microsoft Alias: spelluru

@akhudairymicrosoft
Thanks for your feedback! We will investigate and update as appropriate.

Hi @spelluru
Could you please review add comments on this, update as appropriate.

@akhudairymicrosoft
Thank you for bringing this to our attention. I've assigned this issue to the author who will investigate and update as appropriate.

@kasun04
@akhudairymicrosoft - Thank you for providing the feedback.  The quickstart is probably not the right article, but I will find the right place to add the suggested content. I will close this GitHub issue and work with you and Kasun (PM) to update the content. Thanks.

#please-close


KAFKA-5746: Add new metrics to support health checks (KIP-188)

Adds new metrics to support health checks:

Error rates for each request type, per-error code
Request size and temporary memory size
Message conversion rate and time
Successful and failed authentication rates
ZooKeeper latency and status
Client version

@ijuma Can you review, please? Thank you!

retest this please

Would it make sense to merge the SSL authentication PR first?

@ijuma Thank you for the review, I have addressed the comments. But yes, it will be better to merge the SSL authentication PR first.

@ijuma Thanks for the review. Added the missing code and unit tests for those cases.

@ijuma Added metrics for Errors.NONE

Preliminary performance test results, running producer performance on my laptop:
This does not show any noticeable difference beyond the variation in runs, but note that this doesn't reflect the overheads for fetch requests with small wait and large number of partitions where the difference may be more significant:
Maximum throughput (100 byte records, no throughput limit):
Trunk:
50000000 records sent,<PHONE_NUMBER>29 records/sec (93.25 MB/sec), 90.57 ms avg latency, 3187.00 ms max latency, 3 ms 50th, 213 ms 95th, 3032 ms 99th, 3158 ms 99.9th.
50000000 records sent, 1001021.041462 records/sec (95.46 MB/sec), 116.89 ms avg latency, 4319.00 ms max latency, 2 ms 50th, 183 ms 95th, 4123 ms 99th, 4293 ms 99.9th.
50000000 records sent, 1000500.250125 records/sec (95.42 MB/sec), 117.71 ms avg latency, 5012.00 ms max latency, 2 ms 50th, 186 ms 95th, 4167 ms 99th, 4972 ms 99.9th.
With this PR:
50000000 records sent,<PHONE_NUMBER>85 records/sec (95.18 MB/sec), 113.76 ms avg latency, 4705.00 ms max latency, 2 ms 50th, 194 ms 95th, 4009 ms 99th, 4640 ms 99.9th.
50000000 records sent, 1000640.409862 records/sec (95.43 MB/sec), 107.75 ms avg latency, 4016.00 ms max latency, 2 ms 50th, 189 ms 95th, 3896 ms 99th, 4001 ms 99.9th.
50000000 records sent,<PHONE_NUMBER>89 records/sec (95.32 MB/sec), 109.99 ms avg latency, 5029.00 ms max latency, 2 ms 50th, 157 ms 95th, 3912 ms 99th, 4996 ms 99.9th.

Latency with 950K records/second
Trunk:
50000000 records sent,<PHONE_NUMBER>58 records/sec (85.82 MB/sec), 2.25 ms avg latency, 111.00 ms max latency, 2 ms 50th, 3 ms 95th, 6 ms 99th, 81 ms 99.9th
50000000 records sent,<PHONE_NUMBER>09 records/sec (85.82 MB/sec), 2.46 ms avg latency, 153.00 ms max latency, 2 ms 50th, 5 ms 95th, 15 ms 99th, 61 ms 99.9th.
50000000 records sent,<PHONE_NUMBER>58 records/sec (85.82 MB/sec), 2.46 ms avg latency, 148.00 ms max latency, 2 ms 50th, 3 ms 95th, 9 ms 99th, 143 ms 99.9th.
With this PR
50000000 records sent,<PHONE_NUMBER>04 records/sec (85.81 MB/sec), 2.18 ms avg latency, 113.00 ms max latency, 2 ms 50th, 3 ms 95th, 6 ms 99th, 80 ms 99.9th.
50000000 records sent,<PHONE_NUMBER>90 records/sec (85.82 MB/sec), 2.21 ms avg latency, 107.00 ms max latency, 2 ms 50th, 3 ms 95th, 6 ms 99th, 80 ms 99.9th.
50000000 records sent,<PHONE_NUMBER>04 records/sec (85.81 MB/sec), 2.40 ms avg latency, 103.00 ms max latency, 2 ms 50th, 4 ms 95th, 9 ms 99th, 79 ms 99.9th.


Refactor watches to use native k8s api

Changes visible total counts for a user: now it shows total count for a given context namespaces
Refactors away custom watch api implementation: now uses native k8s api (each watch api is a separate request). Should help with debug etc because no requests are "hidden" behind main

Based on #2083
Closes #2083
Closes #2089

Blocker: browser fetch can only do limited number of concurrent requests.

Lens deployment scaling dialog shows 0 replicas (there are 4) and "Scale" button is grayed out

If I cancel then bring the dialog back up it shows 4 replicas but the "Scale" button remains grayed out, even when I move the slider

If I cancel then bring the dialog back up it shows 4 replicas but the "Scale" button remains grayed out, even when I move the slider

I assume you tested a version which did not have a workaround for browser connection limits? That caused request to block until watches were reseted (chromium allows only 6 connections per domain).

I'm quite sure integration tests will pass now 😎


Require Job/Configure to convert jobs and hide the sidebar link for unprivileged users

Should probably add a unit test checking that unprivileged users can't run the converter before merging.

@olamy Ok, I added a test, and cleaned up a bunch of minor stuff, let me know if you want me to move those things to a separate PR or anything!


[Minor] Pubsub system messages are grayed out wrong

Describe your issue

When having multiple pubsub system messages during startup they are greyed out wrong.
During debugging automod I stumbled across this. If this is too insignificant this can be closed.
Screenshots

(It would be better to showcase this with a video since the reconnected and other message are light grey color before a new system message comes)
OS and Chatterino Version

Arch Linux, Chatterino 2.3.1 (commit 2ea233a28)

I don't have screenshots handy to add, but I've also noticed this too where sometimes the message that should be greyed out is incorrect, almost as if it's out-of-sync or there's an off-by-one error somewhere. I don't think this is limited to system messages on start up. I'll try to capture some examples the next time I see it happening.

This has only to do with automod/pubsub messages it seems and not system messages in general (from what I can gather)

I believe this might have to do with empty timeoutUser / messageText / searchText in those messages


Upgrade base image to continuumio/miniconda3:4.7.12

The latest image uses Python 3.7: https://github.com/ContinuumIO/docker-images/tree/master/miniconda3

Yeah I think so. We probably want all models to test out this new base.

Should we cut a new release now?

@xuhdev sure

Could you help? No idea of the process

Done https://github.com/IBM/MAX-Base/releases/tag/v1.3.0

Like a flash


Rendering improvements

Fixes #1032
Fixes #1031
Fixes #1035
Fixes #1036
Fixes #1032
Fixes #1037

See individual commits for what was actually done. It turns out drawing the entire line like this is fairly fast, typically ranging from 0.5ms to 4ms on my macbook. The boost in stability/accuracy that this change brings is a must for now. It would be good to go back to intelligently diffing before drawing eventually (when we're certain the characters aren't overlapping).

Coverage decreased (-0.2%) to 69.823% when pulling 06b9f1db873068b940502e1a88b30f2baa76cbb7 on Tyriar:rendering_improvements into 22af08d86e8aec7af3c6d38656b0f51689255c61 on sourcelair:v3.


Patched?

I've been getting VAC issues the past two days, even my friend that is using this is getting tons of VAC errors etc. We've been using this for multiple months and are wondering if it's still viable.

Close this.


Change removespaces filter to remove all non alphanumeric

A name that has any non alphanumeric characters will show a 404 , e.g. O'Neal

Got rid of this in: https://github.com/mcdermott-scholars/mcdermott/commit/e72247f710992a8e75c80f8a33301870da4f436a


Bug: Pagination getFirstPageNumber() & getLastPageNumber() returns unexpected result.

PHP Version
8.2
CodeIgniter4 Version
4.4.3
CodeIgniter4 Installation Method
Composer (using codeigniter4/appstarter)
Which operating systems have you tested for this bug?
Windows
Which server did you use?
apache
Database
MariaDB 10.4.18
What happened?
Within the view file for pagination links, the getFirstPageNumber() & getLastPageNumber() methods don't seem to return the expected results. From the docs:

These methods return page numbers to the first and last pages in the result set.

Let's say your $pager->links() prints out the following:
1 | 2 | 3 | 4 | 5

calling the getFirstPageNumber() & getLastPageNumber() returns 1 and 5 respectively.
And when you navigate to the next page, with links as follows:
3 | 4 | 5 | 6 | 7

getFirstPageNumber() & getLastPageNumber() returns 3 and 7 respectively.
Steps to Reproduce
Follow the docs and create a simple pagination.
Expected Output
I expected the code to work differently, getFirstPageNumber() should return 1 & getLastPageNumber() should return the count of the total number of pages, irrespective of the page being viewed.  As seen in the source code: https://github.com/codeigniter4/CodeIgniter4/blob/14b4350b3685d33018ce7ba0c7d0a368f25962ce/system/Pager/PagerRenderer.php#L386-L389
https://github.com/codeigniter4/CodeIgniter4/blob/14b4350b3685d33018ce7ba0c7d0a368f25962ce/system/Pager/PagerRenderer.php#L402-L405
https://github.com/codeigniter4/CodeIgniter4/blob/14b4350b3685d33018ce7ba0c7d0a368f25962ce/system/Pager/PagerRenderer.php#L86-L89
Anything else?
No response

What does this issue mean?
Do you mean you want the current behavior to change?

Well, if the current behaviour is the intended, then I think it is misleading (IMO).
How do devs get the first page number and last page number irrespective of the result?

How do devs get the first page number and last page number irrespective of the result?

The first page number is always 1.
and use getPageCount().

Then is there an actual use case for the current behaviour of getFirstPageNumber() & getLastPageNumber()?

E.g., changing the decoration of the first and last page numbers?

How about this?
--- a/system/Pager/PagerRenderer.php
+++ b/system/Pager/PagerRenderer.php
@@ -25,14 +25,14 @@ use CodeIgniter\HTTP\URI;
 class PagerRenderer
 {
     /**
-     * First page number.
+     * First page number in the current page set being displayed.
      *
      * @var int
      */
     protected $first;

     /**
-     * Last page number.
+     * Last page number in the current page set being displayed.
      *
      * @var int
      */
@@ -85,8 +85,10 @@ class PagerRenderer
      */
     public function __construct(array $details)
     {
+        // `first` and `last` will be updated by `setSurroundCount()`.
         $this->first        = 1;
         $this->last         = $details['pageCount'];
+
         $this->current      = $details['currentPage'];
         $this->total        = $details['total'];
         $this->uri          = $details['uri'];

E.g., changing the decoration of the first and last page numbers?

Well, okay, but are those methods not supposed to be in sync with the getFirst() and getLast() methods?
For example, if the getFirst() always returns the url of the first result in the entire dataset, why does getFirstPageNumber() behave otherwise?

For example, if the getFirst() always returns the url of the first result in the entire dataset, why does getFirstPageNumber() behave otherwise?

I agree that it is difficult to understand, but it is probably because of historical reasons.

There are many different methods of Pagination, and they are indeed confusing, but if we change the method name, it is a breaking change. So it is not easy to change.

🤔
How about factoring it in v4.5 ?

Or, the docs could be updated for better understanding, including the suggested change in https://github.com/codeigniter4/CodeIgniter4/issues/8254#issuecomment-1826435461

If you can improve Pagination without breaking existing apps by adding new, easy-to-understand methods, please send PR to 4.5.
Otherwise, I don't see the value in going to the trouble of breaking existing apps to make the change.
In fact, I think the names are just confusing, but they work.
The documentation has room for improvement.

I sent PR #8256


Show changelog for new version in the Updates in Settings.

I often want to see the CHANGELOG for a package to see if I want to update to the latest version.
However, clicking the CHANGELOG button,

opens the CHANGELOG for the current version that I have installed of the given package, so we don't see any changes relating to the new version.
It'd be nice if it opened the updated CHANGELOG from GitHub, or similar.

Thanks again for sharing suggestions @trusktr - this belongs in https://github.com/atom/settings-view but it looks like there's an existing issue for the general idea at https://github.com/atom/settings-view/issues/282 so we'll close in favor of that issue.

Because we treat our issues list as the Atom team's backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn't an exact duplicate but is closely related.
For information on how to use GitHub's search feature to find out if something is a duplicate before filing, see the How Can I Contribute? section of the Atom CONTRIBUTING guide.


Starting initial draft commit for building for EL 9

this is mostly broken, just putting here some tips what we should update, etc...

/packit-build

/packit copr-build

@pirat89 You are missing packit refactor, please rebase against recent master

@fernflower I guess that PEBKAC. I rebased, but I have a feel throw out all changes from master. I will take a look tomorrow. Thanks for the checking.

/packit copr-build

/packit copr-build

/rerun

All changes seems good to me and last two unfinished tests are possibly broken - I haven't been able to pass them in last 20+ hours. Seems that all required changes have been delivered.


Add versioningit at host time

If you generate a conda package from your sdist (e.g., for a conda-forge feedstock), you will likely want to include versioningit as a host dependency in your conda meta.yaml file. This is needed for the package produced from your sdist to contain the correct version number in its dist-info.

https://versioningit.readthedocs.io/en/stable/notes.html

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@mattwthompson looks great! Thanks so much for putting this together, and sorry I missed this!


Issue# 6537 - Proposed fix for "Unable to rename" exceptions

My current Druid setup does batch ingestion of data, which uses "indexing-hadoop" tasks for ingestion. So I observe "Unable to rename ******" exception daily indexing tasks and frequency increases when I run data back-filling/correction tasks for some interval of say 1 month. So I came up with a fix by applying a logic that while creating a file on S3 for first time create it with expected name i.e. "index.zip" (in place of index.zip.0) and avoid rename(index.zip.0 -> index.zip) completely, because "create" part never fails but "rename" does intermittently. With this I did not came across "Unable to rename ******" exception so far (past 2 months - till date)
It is possible that this proposed fix is not very broad sighted, but looking at HDFS API only part I think we should be able to avoid this annoying issue of "Unable to rename", which may arise despite one having all correct EC2, S3 permissions etc.

The idea behind using the temporary name is that if writing fails halfway through, we don't create the final file name as a partial file.
What do you think about adding a retry to the rename instead? Do you know why it is failing?

Hi @quode, I'm going to close this for now - please reopen if you are interested in working on it some more, or if you have some thoughts on my comment: https://github.com/apache/incubator-druid/pull/6538#issuecomment-435224421

Yo this is a big problem it needs to be fixed.


interpolates in wgan-gp

I'm following Algorithm 1 in the paper with MNIST dataset.
x ̃ ← G θ ( z )
xˆ ← εx + (1 − ε)x ̃

However, in the code, it shows
differences = fake_data - real_data
interpolates = real_data + (alpha*differences)
             = read_data + alpha*(fake_data - real_data)
             = alpha * fake_data + (1-alpha) * real_data

why?

Well, set alpha = 1 - epsilon and I guess you get the result!
And as alpha is set to be sampled uniformly at random between 0 and 1, so is epsilon.


Network considerations

Due to the intermittency of the previously failed requests, I noticed that we need to do is reduce the timeout.
We need to see if this is possible using the loco dependency or if we should just fully replace it with a custom guzzle integration.

This was addressed with #21


remove unneeded rules

Coverage remained the same at 100.0% when pulling 89c91fc90544950117059a13bc33f28faa7bc27c on patch into ef7a744110c8faf172d11b5477d31dd490c0d064 on master.

Coverage remained the same at 100.0% when pulling 321e2b85f4ce07703578e3e0acd2e483d579a17d on patch into ef7a744110c8faf172d11b5477d31dd490c0d064 on master.


SQS long polling throws exceptions on shutdown

Type: Bug
Component: SQS
Describe the bug
My app receives SQS messages via long polling using default SqsTemplate using the receive() method.
The problem is that when I shut down the app, there are bunch of errors in the logs.
There 3 errors like this since it makes retries:
java.util.concurrent.CompletionException: io.awspring.cloud.sqs.operations.MessagingOperationFailedException: Message receive operation failed for endpoint https://sqs.eu-west-1.amazonaws.com/000000000000/foo-bar-queue
	at java.base/java.util.concurrent.CompletableFuture.encodeRelay(CompletableFuture.java:368) ~[na:na]
...
Caused by: io.awspring.cloud.sqs.operations.MessagingOperationFailedException: Message receive operation failed for endpoint https://sqs.eu-west-1.amazonaws.com/...
	at io.awspring.cloud.sqs.operations.AbstractMessagingTemplate.lambda$receiveManyAsync$5(AbstractMessagingTemplate.java:165) ~[spring-cloud-aws-sqs-3.0.1.jar:3.0.1]
...
Caused by: software.amazon.awssdk.core.exception.SdkClientException: Unable to execute HTTP request: executor not accepting a task
	at software.amazon.awssdk.core.exception.SdkClientException$BuilderImpl.build(SdkClientException.java:111) ~[sdk-core-2.20.63.jar:na]
...
Caused by: java.lang.IllegalStateException: executor not accepting a task
	at io.netty.resolver.AddressResolverGroup.getResolver(AddressResolverGroup.java:61) ~[netty-resolver-4.1.89.Final.jar:4.1.89.Final]

And one more at the end:
2023-10-11T10:45:34.763+02:00 ERROR 87176 --- [tyEventLoop-2-0] i.n.u.c.D.rejectedExecution              : Failed to submit a listener notification task. Event loop shut down?
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934) ~[netty-common-4.1.89.Final.jar:4.1.89.Final]
	...
	at io.netty.util.concurrent.DefaultPromise.tryFailure(DefaultPromise.java:118) ~[netty-common-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.channel.pool.SimpleChannelPool.notifyConnect(SimpleChannelPool.java:218) ~[netty-transport-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.channel.pool.SimpleChannelPool.access$000(SimpleChannelPool.java:43) ~[netty-transport-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.channel.pool.SimpleChannelPool$2.operationComplete(SimpleChannelPool.java:184) ~[netty-transport-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.channel.pool.SimpleChannelPool$2.operationComplete(SimpleChannelPool.java:181) ~[netty-transport-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.util.concurrent.DefaultPromise.notifyListener0(DefaultPromise.java:590) ~[netty-common-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.util.concurrent.DefaultPromise.notifyListenersNow(DefaultPromise.java:557) ~[netty-common-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.util.concurrent.DefaultPromise.notifyListeners(DefaultPromise.java:492) ~[netty-common-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.util.concurrent.DefaultPromise.setValue0(DefaultPromise.java:636) ~[netty-common-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.util.concurrent.DefaultPromise.setFailure0(DefaultPromise.java:629) ~[netty-common-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.util.concurrent.DefaultPromise.setFailure(DefaultPromise.java:110) ~[netty-common-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.channel.DefaultChannelPromise.setFailure(DefaultChannelPromise.java:89) ~[netty-transport-4.1.89.Final.jar:4.1.89.Final]
	at io.netty.bootstrap.Bootstrap.doResolveAndConnect0(Bootstrap.java:197) ~[netty-transport-4.1.89.Final.jar:4.1.89.Final]

How to handle these shutdown-related errors properly?
Spring Boot version: 3.0.4
AWS Spring version: 3.0.2
Sample
Here is the code that does the polling:
@Component
class SqsMessageReader(
    @Autowired private val sqsTemplate: SqsTemplate,
    @Value("\${custom.cloud.aws.sqs.queueUrl}") private val queue: String
) {

    fun read(): MyMessage? {
        return sqsTemplate.receive(queue, MyMessage::class.java).getOrNull()?.payload
    }
}

Hi @zmaks,
Since you're manually receiving messages using the SqsTemplate, it's up to you to make sure it's not stuck polling when you shutdown your application.
How to do that really depends on how you structure your app - for example, you can collect the CompletableFuture instances from polling async and join() them before allowing the app to complete shutdown.
Makes sense?

Hi @tomazfernandes,
Thank you for the answer. On the other hand, the library provides an API: sqsTemplate.receive(queue, type) method which is sync and doesn't return a CompletableFuture or Future, so I can't control how it makes the request for this specific method. It does just does long polling with 10 sec timeout which throws exceptions if the app is shutdown. Probably, it would be nice to have an ability to setup SqsTemplate and provide some exception handler for such cases.
But I like your suggestion, I'll switch to async version of this method. Thanks!

Probably, it would be nice to have an ability to setup SqsTemplate and provide some exception handler for such cases.

We could add a structure for that, but since we propagate the error up to the caller, I'm not sure what actual value this would bring to the user. If it's just about the logs, we might as well have a flag to disable it.
Otherwise the behavior is pretty much the same as the AWS clients - if you use the blocking method and polling fails due to shutdown or anything else, it'll throw an exception just the same.
If you have any ideas let me know.
Thanks.


@FeignClient bug using fallback;

spring boot 2.2
jdk 13
@FeignClient(contextId = "sp-producer-hystrix",name="SPRINGCLOUD-PRODUCER/producer",fallback= FeignHystrixFallback.class)
public interface CusFeignHystrix extends CustomFeignHystrix {
}
@RequestMapping("/feignHystrix")
public interface CustomFeignHystrix {
@GetMapping("/usl")
public List usl();
}
@component
public class FeignHystrixFallback implements CusFeignHystrix {
protected Logger logger = LoggerFactory.getLogger(getClass());
@override
public List usl() {
logger.error("defeat--------------------------");
User temp = new User();
temp.setName("defeat+++++++++++++++++");
return List.of(temp);
}
}
Error at startup
Ambiguous mapping. Cannot map 'com.ciel.springcloudfathernewconsumer0.service.CusFeignHystrix' method
com.ciel.springcloudfathernewconsumer0.service.CusFeignHystrix#usl()
to {GET /feignHystrix/usl}: There is already 'feignHystrixFallback' bean method
I had to remove @component from FeignHystrixFallback
But it happened
No fallback instance of type class com.ciel.springcloudfathernewconsumer0.fallback.FeignHystrixFallback found for feign client sp-producer-hystrix
I finally solved it like this ;
Overriding @GetMapping ("/usl") with @GetMapping ("/ gg")
@component
public class FeignHystrixFallback implements CusFeignHystrix {
protected Logger logger = LoggerFactory.getLogger(getClass());
@override
@GetMapping("/gg")
public List usl() {
logger.error("defeat--------------");
User temp = new User();
temp.setName("defeat+++++++++++++++++");
return List.of(temp);
}
}

Hello, @cielswift
Please learn how to properly format code and logs.
Please provide a minimal, complete, verifiable example that reproduces the issue (link to a sample project repo and steps to reproduce the issue).

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


Flutter inset Box Shadow

on container shape : BoxShape.circle, its not working fine please give any solution

Yes sorry, at the moment it is not implemented. I'll take care of it.
In the meantime, you can try to put a very high border-radius on your container:
Container(
    decoration: BoxDecoration(
        borderRadius: BorderRadius.circular(double.infinity),
    ),
    // ...
),

Actually I think I have implemented it, on my side it seems to work, can you give me an example that does not work please?
Thanks in advance.

I'm closing this issue for now because I can't reproduce it. Feel free to reopen it.


Added a clause for "indented-line" blocks for the Python style guide

There's a discussion going on in pydocstyle (Reference: https://github.com/PyCQA/pydocstyle/issues/449) about what whitespace options are allowed under google's style guide. In this issue submitted to this repository, it was mentioned that using indented lines is allowed by Google's current linters.
Would it be alright to add an explicit example?

@gpshead any progress on this?

@gpshead could you please update on this review? Or give details on how to advance this PR?

I just mailed an internal change that should address this.  I'll make sure the the external guide is synced after that goes in.

An update including my internal change addressing this has been pushed.


TL-40011: Adding in webkit-style transformation support

Pulling the webkit-style transformations basics into the library directly to make upgrades simplier in the future.

Note - I've not done style cleanup for the sourcemap customisation, which is why those checks fail


Display message with html format

Hi,
I'm using our connectycube-web-samples on that we want  to use chat messages as html format (like spacing, hyperlink, etc). Can you please help how to achieve that.
Thanks.

@ciamalaeaskan
Any description ?

@ciamalaeaskan
Any description ?

@ccvlad added

@ccvlad added

You are able to make html as string and insert to the DOM via the innerHTML method:
document.getElementById('#messagesList')
  .innerHTML(`<div class="message "id="${message.id}">${message.body}</div>`)

Or use some template builder such as handlebars

You are able to make html as string and insert to the DOM via the innerHTML method:
document.getElementById('#messagesList')
  .innerHTML(`<div class="message "id="${message.id}">${message.body}</div>`)

Or use some template builder such as handlebars


[bug]: high values for time_lock_delta can result in unexpected setting of 0

Hello,
updatechanpolicy's time_lock_delta can roll over when very high values are used, which might result in a setting of 0.
I noticed this in a happy accident, where I used the channel_id instead of the channel_point and also forgot to actually
set time_lock_delta. So my channel_id got parsed as --time_lock_delta.
lncli --network testnet updatechanpolicy --fee_rate 0 --base_fee_msat 0<PHONE_NUMBER>16848128
resulted in time_lock_delta getting set to 0 for all my channels...
This shouldn't even be possible, because normally it complains that the  minimum value is 18.
Your environment
tlv/v1.1.0-130-g143eba82e (0.15.99-beta current git master)
Linux lnd-test2 5.10.0-18-amd64 #1 SMP Debian 5.10.140-1 (2022-09-02) x86_64 GNU/Linux
bitcoin-core 23.0
Steps to reproduce
lncli --network testnet updatechanpolicy --fee_rate 0 --base_fee_msat 0<PHONE_NUMBER>16848128
Expected behaviour
Failure or time_lock_delta set to a high value
Actual behaviour
time_lock_delta got set to 0 for all my channels

$ lncli --network testnet getchaninfo<PHONE_NUMBER>201169921
{
[...]
"node1_policy": {
"time_lock_delta": 0,
"min_htlc": "1000",
"fee_base_msat": "0",
"fee_rate_milli_msat": "0",
"disabled": false,
"max_htlc_msat": "1458270000",
"last_update":<PHONE_NUMBER>,
"custom_records": {
}
},
[...]
$ lncli --network testnet getchaninfo<PHONE_NUMBER>108147712
{
[...]
"node1_policy": {
"time_lock_delta": 0,
"min_htlc": "1000",
"fee_base_msat": "0",
"fee_rate_milli_msat": "0",
"disabled": false,
"max_htlc_msat": "990000000",
"last_update":<PHONE_NUMBER>,
"custom_records": {
}
},
[...]

Additional Info
This might be caused by a 32bit roll over, as this still works as expected:
lncli --network testnet updatechanpolicy --fee_rate 0 --base_fee_msat 0 --time_lock_delta<PHONE_NUMBER>
results in time_lock_delta 65535
while this results in setting it to zero again:
lncli --network testnet updatechanpolicy --fee_rate 0 --base_fee_msat 0 --time_lock_delta<PHONE_NUMBER>

Nice catch! We should make sure we check for overflow directly.

@Roasbeef Hi Roasbeef, I found TimeLockDelta's type is inconsistent, it's uint16 in somewhere like:
https://github.com/lightningnetwork/lnd/blob/2cf6969dbc76fb770607b0f6e604d8a5c09d5b7b/lnwire/channel_update.go#L100
https://github.com/lightningnetwork/lnd/blob/1aa9626606bbd9802a85ab71c0395749a5396714/channeldb/graph.go#L3418
and it's uint32 in:
https://github.com/lightningnetwork/lnd/blob/3dd9e04b8b1fd60a699c104e6e31ef427e5942e7/lnrpc/lightning.proto#L4048
I think we should unify TimeLockDelta to uint16 and check for overflow up to max(uint16). What do you think?

I think we should unify TimeLockDelta to uint16 and check for overflow up to max(uint16). What do you think?

Agreed we should make the value consistent. For particular purposes, the uint16 should be enough. IIIRC, for the protos there isn't a uint16 type, so we need to use a uint32 there. Similarly, the database serialization in the other link assumes a uint16, so we can't change that as easily.

Is this one taken? If not i'll take it.

closed with: https://github.com/lightningnetwork/lnd/pull/7350


HasClusterID() and allow-untagged-cloud

Looking at the basic_main.go
	if !cloud.HasClusterID() {
		if config.ComponentConfig.KubeCloudShared.AllowUntaggedCloud {
			klog.Warning("detected a cluster without a ClusterID.  A ClusterID will be required in the future.  Please tag your cluster to avoid any future issues")
		} else {
			klog.Fatalf("no ClusterID found.  A ClusterID is required for the cloud provider to function properly.  This check can be bypassed by setting the allow-untagged-cloud option")
		}
	}

basic_main.go
But where is ClusterID actually used?
Afaik allow-untagged-cloud is deprecated, but afaik ClusterID does not get used.
The current state is confusing.
Please explain how a ccm should implement a ClusterID.

/remove-lifecycle rotten

we are discussing this issue today at the sig cloud provider meeting, it seems like this is a good research topic for understand how the ClusterID is being used.
one point of order @guettli , would you mind opening this issue against kubernetes/kubernetes so that we can link the work to any changes that might need to be made there. (this repo is sync from the staging)

@elmiko I am in hospital at the moment. Can you please create the other issue?

i have created https://github.com/kubernetes/kubernetes/issues/128320 , let's continue the discussion there. thanks for reporting this @guettli !

/close


The /functions/pipeline PUT method are using QueryString in the URL to get data.

We should change and pass this data in the PUT request body.

I will tackle this one!

Can I do this?


Utilizing the captured speech from Mics for other processing before sending out to cloud

Hi AVS team,
How do we obtain speech text after SpeechRecognizer, we hope to use it for other applications - posssibly also do some processing and then send the processed speech to Amazon server ?
If there is a method, can you pls shed some light into it?
I am using Alexa SDK with Raspbian stretch on RPi 3.

Hi @ullasbharadwaj,
A general overview of the architecture:
A SharedDataStream is written to by the microphone class (in this case the PortAudioMicrophoneWrapper). The SharedDataStream is then read by the various AudioProvider objects (Tap To Talk, Wakeword, Hold to Talk, etc), and streamed to AVS when a Recognize is initiated via the AudioInputProcess capability agent.
The initialization of these objects can be seen here and the recognize workflow documentation is here. Code snippets of interest in AudioInputProcessor can be found by following the m_reader variable.
Here are a few possible routes you can explore depending on your needs and application:

Create your own MicrophoneWrapper object and pre-process before sending the data to the SharedDataStream.
Modify the AudioInputProcessor Capability Agent to perform additional processing before streaming to AVS.

Hello Keith Huang,
Thank you so much for a detailed explanation. Will follow the mentioned guideline and get back if some support is needed.

No problem. I'm going to close this ticket, but feel free to re-open if you have any further questions.

How can I access audio output stream (raw audio samples) ? Cause I need the final output for AEC as refenrece signal.


CORE-2466 Rollback referencing a change set in another file cannot be parsed

CORE-2466 Rollback referencing a change set in another file cannot be parsed
Makes it possible to resolve the root change log from within a nested change log. Then the root change log can be used to resolve a change set referenced in a rollback node.
Maintains the original change set reference for rollback changes that are included by reference, so that paths relative to the referenced change log file can be resolved correctly.

The fix looks good, thanks. I was concerned the fix would be harder, glad it wasn't.


Update5

👷 Deploy Preview for crpp-ai-oncology processing.

Name
Link

🔨 Latest commit
cb3e0f8cf2b91c20f49a352909bfd9696fdd5584

🔍 Latest deploy log
https://app.netlify.com/sites/crpp-ai-oncology/deploys/638630da6b8a4d000898b532


Integration with Global context of browser

Expected Behavior
I would like to have access to global functions and variables
Actual Behavior
There is Runtime error at attempt to call global function
Steps to Reproduce the Problem
I used viewer-options.html from WEB at browser

I added code into  viewer-options.html

<script>
function globalF()
{
console.log("Global context");
 }
</script>

I added into JSCAD file into main function
globalF();

Looks like system tries to call globalF twice for one page loading.
It is ok for first time and it is runtime error VM4:108 Uncaught ReferenceError: globalF is not defined at second time

Specifications

Version: 1.10.0
Platform: Ubuntu 19.04 x64
Environment: Chrome 83.0.4103.61

There is an screenshot.

This is an screenshot

It’s one of the ‘features’ of the website. In order to allow the user to interact with the UI, the processing is performed in webworkers. Webworkers do not have access to global functions or data.

It is really very convoluted piece of browser functionality. So , I have to think a lot of time now :) Thank You


Feature Request: Add Templates placeholder for domain name

Hello everybody,
I'm wondering if the templates contain some keywords that they can be automatically changed when a new site is create.
I'm trying to achieve something like this:
Template:
www | CNAME | 300 | [DOMAIN]
After creating a domain this is automatically translated to:
www | CNAME | 300 | mydomain.ext
Kind regards,
Adrian

+1
would also be useful for MX entries: mail.[DOMAIN] -> mail.example.com

+1

Hello,
This request is stale for too long. Regarding our policy to cleanup this project, we are closing it. As this is a Feature Request, it will be listed in #1178
Regards
PowerDNS Admin Team
See #1153 for the policy


Profile-specific spring.cloud.config.label disregarded.

Hi. I found that in Cloud Dependencies 2021.0.2, I am unable to specify a spring.cloud.config.label in the profile-specific application.yml. Any value that is specified simply gets ignored. Shouldn't we be able to override the label based on certain profiles?

Did it work in a previous release?

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


When i install ITK with CMAKE

I set ITK_WRAP_PYTHON ON and ITK_LEGACY_SILENT ON .
then configure it,
CMake Error at CMakeLists.txt:397 (message):
  Wrapping requires to disable legacy code, please set ITK_LEGACY_SILENT=ON

how can i do?

sorry， i found my mistake. it's a silly mistake  ；）


NOT sure the calibration is done on D435i

I have a D435i. I am using ubuntu 18.04 kernal 4.15 python3.6
and I follow the doc to use py script to make a calibration. But each time have a "Aborted (core dumped)"
################################
[-0.00242537  0.00021328 -0.00037966]
[1000 1000 1000 1000 1000 1000]
using 6000 measurements.
[[ 1.01757452  0.00734909 -0.02611901]
[-0.00204555  1.01106642 -0.01299658]
[-0.00648539  0.02230738  1.02390467]
[-0.05875149 -0.23772782  0.19624085]]
residuals: [  7.44936788<PHONE_NUMBER>6  10.34672628]
rank: 4
singular: [438.0908363<PHONE_NUMBER>8<PHONE_NUMBER>4  77.33698261]
norm (raw data  ): 9.640803
norm (fixed data): 9.805059 A good calibration will be near 9.806650
Would you like to write the results to the camera's eeprom? (Y/N)y
Writing calibration to device.
Device PID:  0B3A
Device name:  Intel RealSense D435I
Serial number:  XXXXXXXX
Firmware version:  <IP_ADDRESS>
<IP_ADDRESS>
SUCCESS: saved calibration to camera.
Done.
FATAL: exception not rethrown
Aborted (core dumped)
and the raw data isnt change. So the calibration does not be written in D435i?
How to solve it?
thx

I compared your log against the IMU calibration white paper's description of what is supposed to happen after the camera is updated.

Like in the example, the log shows that you have reached the end-point where the calibration declares SUCCESS in saving the calibration and then DONE.  That makes me think that the save process has been completed and the application is crashing after that as it closes the process down.  As far as I know, this should not matter so long as the calibration changes have been successfully saved.
The saving process states the following line:
norm (fixed data): 9.805059 A good calibration will be near 9.806650
So if you wanted to verify if a calibration has been saved, you could run the calibration process again and see what value is given beside the norm (fixed data) line.  If the value has changed from what it was before and is near 9.806650 (the range of a good calibration, according to the program) then you could then select N to cancel out of the save.

I haven't looked into it but if i take too long during the calibration process I'll get the same error message.
You can check the camera calibration by commenting out these lines: https://github.com/IntelRealSense/librealsense/blob/master/tools/rs-imu-calibration/rs-imu-calibration.py#L236-L238
With those commented out, the SDK will use the previously calibrated correction values and at the end of the script you'll see how well the camera is calibrated in the raw value.
I recommend saving the values to a file but I do not recommend saving the result of the script after commenting those lines out to EEPROM.
I have an open issue with questions about applying calibration on top of already calibrated values here:
https://github.com/IntelRealSense/librealsense/issues/3239

Hi @cdb0y511,
You can install below tool to use "Intel.Realsense.CustomRW" to access the IMU calibration data to see if it's there. (command: intel.realsense.customRW -r -mm)
https://downloadcenter.intel.com/download/28517/Intel-RealSense-D400-Series-Calibration-Tools-and-API?product=128255

Thanks to everyone.

Thx to everyone!
I think it is there (hex at end). By the way, the script on linux is not so smooth and script on windows finished without any errors.
there is three things:
1.libpng12-dev is not available on ubuntu 18.04. the replacement libpng12.deb cant match the dependency of  libscalibrationapi. So I have to run it on windows, you may fix it for ubuntu18.04 only developers.
2.I dont think other calibration is necessary for a brand new D435i except the IMU. Is it right?
3.So far i got the best one is 9.805, the best calibration for IMU is the closest one to 9.806. Is it right? but why does the G normal  have different number when camera face different direction? the stand position is close to 9.8. but face down ,face up is close to 9 and 10. I want to get the accurate  Extrinsic Camera Parameters for 3D reconstruction. So the correct IMU data is really important to me. Do I need another sensor like T265 to obtain accurate Extrinsic Camera Parameters? I think T265 is for visual tracking and the IMU is close to D435i.

When the IMU intrinsic is available (device calibrated), you'll see an additional checkbox appearing in realsense-viewer.
Toggling this control will modify the gyro/accel values. If the calibration is done properly you'd hopefully see the accelerometer's norm converging over 9.806...

Hi @cdb0y511,
Still need any support for this topic?


Error when testing pipeline library file that has more than one parameters

Error when testing pipeline library file that has more than one parameters:
err:
groovy.lang.MissingMethodException: No signature of method: addPolicy.call() is applicable for argument types: (tests.library.runAddPolicySpec$__spock_feature_1_0_closure1) values: [tests.library.runAddPolicySpec$__spock_feature_1_0_closure1@17a6c499]
Possible solutions: wait(), any(), wait(long), call(java.lang.String, java.lang.String, java.lang.String, java.lang.String), main([Ljava.lang.String;), each(groovy.lang.Closure)
	at com.lesfurets.jenkins.unit.PipelineTestHelper$_closure4.doCall(PipelineTestHelper.groovy:182)
	at com.lesfurets.jenkins.unit.PipelineTestHelper$_closure3.doCall(PipelineTestHelper.groovy:143)
	at tests.library.runAddPolicySpec.test myshared library code(TestAddPolicy.groovy:25)

vars/addPolicy.groovy:
def call(String bucketName, String arnToAdd, String profile, String region) {
  ...
}

test:
class runAddPolicySpec extends PipelineSpockTestBase {

    def "test myshared library code"() {

        given:
        def paramsPassed = {
            bucketName= "..."
            arnToAdd= "..."
            profile="..."
            region="..."
        }
        callStackPath = 'src'

        when:
        def script = loadScript('vars/addPolicy.groovy')
        script.call(paramsPassed)

        then:
        printCallStack()
        assertJobStatusSuccess()
    }
}

...while the given example test with one parameter works:
exampleJob.jenkins with body def call(body) {
Is this a bug or i should do something differently?

Still don't work with:
def paramsPassed= new Binding('bucketName': "...", arnToAdd: "...", profile:"...", region:"...")
script.call(paramsPassed)

This is the only one that working:
script.call("...", "...", "...", "...")

Sorry it has taken me a while...day job got in the way. I added another example of a library step with multiple parameters. See 'pipelineLibrary/vars/stepWithParams.groovy' and 'pipelineTests/groovy/tests/library/stepWithParamsTestSpec.groovy'. I think in your first attempt you just need to pass each param in the call() method. Does this help? Please re-open the issue if it doesn't.


fix(scss): replace variable definitions with default values

Looks good, but there are some variables missing:

:tada: This PR is included in version 1.2.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


updates to grounded flow

Stress testing was done on the SDG pipeline

added grounded test script that can be used to test
updates to templates to get full pipeline working

The commit log could be much improved. The logical changes I see, with the explanations I'd expect:

Convert filter values to a float - does this fix a bug? details of how the bug manifested would help others learn
Combine question and context in the grounded skills flow at the end - why? what's the before and after behavior
template updates to get full pipeline working - these look like important, but subtle changes, what details can you provide to help a person in future understand what to look out for if they are making further changes?

here are some explanations for the changes:

Convert filter values to a float - does this fix a bug? details of how the bug manifested would help others learn

This is addressing an issue that we observed. In some of the cases where the model is being asked to provide a total score, it provides floating point sums like 1.5/2.5 and to accommodate those cases where we want to filter those values out it made sense to keep it float.

Combine question and context in the grounded skills flow at the end - why? what's the before and after behavior

That is a step towards converting it to the final format (messages) required for training.

template updates to get full pipeline working - these look like important, but subtle changes, what details can you provide to help a person in future understand what to look out for if they are making further changes?

The template changes stem from model behavior on the templates and stress testing across various leaf nodes. The changes were mainly made to make sure the responses from the model align best with the expected behavior

here are some explanations for the changes:

It would be great to get those explanations into the commit messages. See also "Information in commit messages" in https://www.berrange.com/tags/commit-message/

The commit message must contain all the information required to fully understand & review the patch for correctness. Less is not more. More is more.

here are some explanations for the changes:

It would be great to get those explanations into the commit messages. See also "Information in commit messages" in https://www.berrange.com/tags/commit-message/

The commit message must contain all the information required to fully understand & review the patch for correctness. Less is not more. More is more.

Thanks for the recommendation! We could start doing this here on, this PR needs to go in by today. We are on a very tight deadline

a few minor changes, otherwise lgtm

done, thank you!

@russellb squashed

@russellb squashed

Thanks. Can you also add your explanations of the changes that you gave here to the commit messages as suggested?

@russellb @markmc updated the commit messages as per your suggestion, ptal, thanks https://github.com/instructlab/sdg/pull/53

lgtm!

Oh for some reason it didn't get synced. Thanks for adding descriptive notes @aakankshaduggal


Add versioncontrol-utils to idr-docker-localstorage

Install git on docker servers

Anything further?

No, it's waiting on the corresponding mgmt config to be merged

About to merge mgmt_tools. Merging.


develop <- master

Merge PR to develop along with master branch push for article publication. Created by this action: https://github.com/falgon/roki-web-post/actions/runs/3580960639

Build log
Preview build with this PR (commit): https://output.circle-artifacts.com/output/job/42934b5e-5f34-437d-b37f-3e32e8aa116b/artifacts/0/index.html


fix for amalgamation build with MIN=1

Fixing the first issue listed in PR 7541.

All tests ok except that MKMKL-build failed in one test where it tries to find the best convolution algorithm and ran out of memory on the GPU. Should be unrelated to this change here.

@mli It feels like some workers have hanging jobs on them that's taking up GPU memory.

i guess we have set timeout on each jenkins job? before i manually stop hanging jobs, now i don't have the permission to do it anymore

I was in the process of switching the 21 uses of dot() over to linalg_gemm when I noticed this change.  If the preferred long-term interface is linalg_gemm, why don't I just modify linalg_impl.h to check MSHADOW_USE_CBLAS and invoke dot(), rather than have this ifdef sequence repeated in many places?

@DickJC123 Yeah I think that's reasonable. A better solution would be to copy the dot implementation into mxnet and use it when blas is not available.

I would prefer to limit the scope of the change I'm working on, so I'll go forward with my suggestion.  I'll leave it to another time/person to copy the dot implementation from mshadow, if that remains desirable.

Is the MIN=1 arg added back to Jenkins now?

Looks like this issue hasn't been fixed yet.
https://builds.apache.org/blue/organizations/jenkins/incubator-mxnet/detail/master/243/pipeline/50 Please check if something is missed.


mgmt, update codegen script, when fail when called as script, return exit code via error

skip revapi at compile (as this is not codegen issue).
this change to exit code only affect when call the script on command line. swagger automation is not affected (they depends on the output json).

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

/check-enforcer override

/check-enforcer override


Ops work

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9fa4beb). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master       #4   +/-   ##
=========================================
  Coverage          ?   90.68%
=========================================
  Files             ?        3
  Lines             ?      558
  Branches          ?        0
=========================================
  Hits              ?      506
  Misses            ?       52
  Partials          ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Go To keyword causes XHR error with Firefox

Originally submitted to Google Code by sajjadmalang on 17 Nov 2010

The 'go to' keyword causes XHR error after upgrading robotframework-selenium 2.5. This worked fine with robotframework-selenium 2.4.
When I do this.
go to	${url}
I get the following error
FAIL XHR ERROR: URL = www.myurls.com/index.html Response_Code = 500 Error_Message = Internal Server Error
This is strange because there is no problem with the URL. I did some googling and found that if I called the api directly with an extra paramenter true it works [https://code.google.com/p/selenium/issues/detail?id=408]. The one below works.
Call Selenium API    open    ${url}    ${true}
When I switched back to robotframework-selenium 2.4 it started working agian. If you need any log file do let me know the path where I can find them.
Windows XP/Firefox 3.6.10/Python2.7/Jython2.5.1

Originally submitted to Google Code by @yanne on 17 Nov 2010

Does this happen consistently?

Originally submitted to Google Code by sajjadmalang on 17 Nov 2010

Yes, it is consistent. I had other open commands in my testcase and all of them stopped working with RF-Sel 2.5.
Here is the script
Start
Open Browser	${same url}  # this works
do stuff
go to	${same url}          # fails with XHR error
go to	${other url}         # also fails with XHR error

Originally submitted to Google Code by @pekkaklarck on 17 Nov 2010

Are you using Firefox? Which version? We run all the acceptance tests with Fx 3.6 on XP, Win7, and Linux without problems.
Based on the description the problem is caused by us updating Selenium's Python API ( issue 131 ) and forgetting to incorporate all the custom fixes we had in the previous version. I probably fixed this in revision e7ac13716. Could you sajjadmalang do the same fix in your local installation (or checkout the latest source code) to verify does it fix your problem?

Originally submitted to Google Code by spielman... on 17 Nov 2010

it really is revision 5e7ac13716 :)

Originally submitted to Google Code by sajjadmalang on 18 Nov 2010

I only modified /src/SeleniumLibrary/init.py and ran it but got the error
TypeError: open() got an unexpected keyword argument 'ignoreResponseCode'
I think I have to download all the latest sources. But I cannot do this right now. I will get back asap.
Thanks.

Originally submitted to Google Code by @pekkaklarck on 18 Nov 2010

You should change line 341 that originally contains
self._selenium.open(url)

to
self._selenium.open(url, ignoreResponseCode=True)

If that really causes the above TypeError, then the actual problem may be caused by something else. Could it be that a wrong version of selenium.py module is imported? Could you add line
print 'Selenium location:', selenium.__file__

into the beginning of the init.py after line
from selenium import selenium

and tell what path gets printed?

Originally submitted to Google Code by sajjadmalang on 29 Nov 2010

Sorry for my very slow response but im very new to python but I had problems getting my changes compiled and into the python installation.
The fix still does not resolved the problem I reported.
I manged to make the changes and get it installed. I opened C:\Python27\Lib\site-packages\SeleniumLibrary_init_.py to confirm that the line with "ignoreResponseCode=True" is there. Then I ran my tests and got the same XHR error back.
My guess is that the fix is not sending the "true" flag to the open command. I know this because I can see in the "Command History" box in the browser that the open command is still being called as "open(http://myurl.com/indexPage.do, False)"
My setup is Windows XP sp3/Firefox 3.6.10/Python2.7/Jython2.5.1
I again appologise for the very very late reply.
Sorry Regards,
\Sajjad.

Originally submitted to Google Code by doc... on 29 Nov 2010

Have the same with Internet Explorer.

Originally submitted to Google Code by doc... on 29 Nov 2010

Forogot to add: For me it happens for certain sites, but earlier, when using "Open Browser"

Originally submitted to Google Code by sajjadmalang on 29 Nov 2010

I did some digging arround solved the problem.
I did the same fix as mentioned by Pekka in the file browser.py line #24 also. Now it works.
<<        self._selenium.open(url)
becomes
>>        self._selenium.open(url, ignoreResponseCode=True)
The resolution is that the patch must be done at two places.
ps: Thanks again for the wonderful tool and the support.
Warm Regards,
\Sajjad.

Originally submitted to Google Code by @pekkaklarck on 9 Dec 2010

I hadn't noticed that also Go To keyword itself uses self._selenium.open. Good catch Sajjad!
It's really weird this problem only happens in some cases. Needs to be fixed in the next release anyway.

Originally submitted to Google Code by @yanne on 3 Jan 2011

This issue was updated by revision e6866dc210.


Add italian translation

Translates remaining files. Is it necessary to translate this other than the files in "creator" folder?
Why are them duplicate?

@MatteoGheza Thank you for participation, at the moment, for italian language only work on src/dev-application/languages/creator/it.php by updating the current translation, if some strings are not translated properly.

Thank you for the feedback.
Have a nice day.


The 8-bit quantization problem of the target detection model (yolov3_ckpt_9.pth)

Hi@nzmora,
Excuse me, I have a question, I would like to ask, I want to quantize the target detection model in 8 bits, and its file format is yolov3_ckpt_9.pth, however, the distiller uses the .pth.tar file format and uses the cifar10 classification data set. Can I directly use distiller to perform 8-bit quantization on the target detection model?
Further, I tested the code and got an error. Excuse me, how can I convert my .pth file? thank you very much!
sincerely,
blueeagle

Hi @Blue-Eagle-10. The compress_classifier.py script you're running is for image classification models only. It will not work with an object detection model.
If you look in our README you can see a summary of what the samples we've implemented.
You'll see that we do have an object detection sample, but only for pruning. See here.
Also, note that that sample only supports torchvision models out of the box - and YOLO isn't part of torchvision. So if you want to use that, you'll need to modify the code to create your YOLO V3 model before loading the checkpoint.

@guyjacob  I have the same problem. Could you please make a detail example about how to modify the code for yolov3? Thanks a lot !

Hi @guyjacob,
Thank you for your reply! thank you very much!
sincerely,
buleeagle

@misslibra The following is not specific to yolov3, but to any "custom" model you want to use.
In the object detection sample, you'll see this snippet:
https://github.com/NervanaSystems/distiller/blob/2291fdcc2ea642a98d4e20629acb5a9e2e04b4e6/examples/object_detection_compression/compress_detector.py#L142-L144
This loads the model specified by args.model from the detection package, which is actually torchvision's detection models.
So you'll need to change that to load your model. Something like:
model = MyModel( ... )

Another thing you'll need to make sure is that your model implements the same API for the forward function as the torchvision detection models, because that's what this sample expects. When I say "the same API" I mean that your model should accept inputs and return an output in the same format as the torchvision models. You can see an example of what the torchvision models do here.
There might be other issues I haven't though of, but these are the two main ones.

Closing due to staleness. Please re-open if needed.


Support text-generation in InferenceClient

Original implementation taken from the text-generation-inference Python client (see client library and repo) from @OlivierDehaene . A vast majority of the code comes from there so kudos goes to him :pray: .
Changes compared to the original implementation:

use pydantic.dataclasses instead of BaseModel
default to Python's dataclasses if pydantic is not installed (meaning pydantic/arg validation is recommended but optional)

added default values for optional parameters (not needed in BaseModel but dataclasses yes)

integrated in huggingface_hub.InferenceClient
added stream: bool and details: bool in the text_generation method instead of having different methods for each use case
NO asyncio support yet => TODO in a next PR

If model is not served with TGI backend (example: "gpt2"-like models), some parameters are ignored. The client always consider that TGI is enable but default back to a normal call if that's not the case. A warning is triggered for the user + details=True is not possible.
Integration is now functional and locally tested.
Docs: text_generation and dataclasses descriptions.
.
TODO:

[x] handle models not served with text-generation-inference backend
[x] add unit tests
[x] add documentation / reference

Normal use (with details)
from huggingface_hub import InferenceClient

client = InferenceClient()
output = client.text_generation("\ndef hello_world(name: str)", model="bigcode/starcoder", stream=False, details=True)
print(output)

TextGenerationResponse(generated_text=' -> str:\n    return f"Hello {name}"\n\n\ndef test_hello_world():', details=Details(finish_reason=<FinishReason.Length: 'length'>, generated_tokens=20, seed=None, prefill=[], tokens=[Token(id=967, text=' ->', logprob=-0.0009317398, special=False), Token(id=596, text=' str', logprob=-0.25805664, special=False), Token(id=44, text=':', logprob=-0.0005950928, special=False), Token(id=284, text='\n   ', logprob=-0.07080078, special=False), Token(id=442, text=' return', logprob=-0.6455078, special=False), Token(id=296, text=' f', logprob=-0.40722656, special=False), Token(id=20, text='"', logprob=-0.37060547, special=False), Token(id=8279, text='Hello', logprob=-0.11077881, special=False), Token(id=301, text=' {', logprob=-0.67626953, special=False), Token(id=426, text='name', logprob=-0.006881714, special=False), Token(id=3845, text='}"', logprob=-0.72021484, special=False), Token(id=478, text='\n\n', logprob=-0.56689453, special=False), Token(id=203, text='\n', logprob=-0.009246826, special=False), Token(id=589, text='def', logprob=-1.2724609, special=False), Token(id=894, text=' test', logprob=-1.5761719, special=False), Token(id=81, text='_', logprob=-0.012329102, special=False), Token(id=7656, text='hello', logprob=-1.8945312, special=False), Token(id=81, text='_', logprob=-0.071777344, special=False), Token(id=5860, text='world', logprob=-0.10595703, special=False), Token(id=2262, text='():', logprob=-0.7866211, special=False)], best_of_sequences=None))

Streaming (no details)
for output in client.text_generation(
    "Number between 1 and 1000: 1, 2, ", max_new_tokens=100, model="bigcode/starcoder", stream=True, details=False
):
    print(output, sep="", end="", flush=True)

3, 4, 5, 6, 7, 8, 9, (...)

Thanks @LysandreJik for the review and suggesting some improvements in the docs! :heart: I've made the requested changes (mainly the return type + adding some examples). Check it out in the docs.

Impressive conditional type response decided by the values of details/stream! Is this so that pydantic behaves correctly?

About the return type with the @overload type annotation, the main goal is to help with IDE autocompletion / type checks in downstream libraries. It tells any tool what will be the returned object depending on the details and stream input values. In theory, Pydantic is quite good at validating things with Union[...] but I'm not using it here for this.

The cassettes could be offloaded to a dataset repo if you don't want to weigh down the repo, but no strong need to move it out as it's code only.

Yes that could be a possibility but for now I'd prefer not to, just for the sake of keeping it simple. The main advantage of having it directly in the repo is that updating the cassette is as simple as running pytest with --vcr-record=all. No need to re-upload the fixed cassettes which makes the process simpler. I might do it in a future PR if it become too heavy.


ClientID description/doc is incorrect

This is the documentation:
ClientId, AppId or ApplicationId
Specifies the ClientID assigned when you registered your application in Azure Active Directory or Active Directory Federation Services (AD FS).
This parameter is applicable only when the authentication type is specified as OAuth.
Client ID is also available for other AuthTypes, such as ClientSecret, like in this example provided: https://docs.microsoft.com/en-us/powerapps/developer/data-platform/xrm-tooling/use-connection-strings-xrm-tooling-connect#clientid-or-client-secret-based-authentication

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4430aad2-5ce8-bc18-e409-009df2ecdf55
Version Independent ID: 6c82245f-9faa-e4f8-d33e-4344c3bea1b4
Content: Use connection strings in XRM tooling to connect to Dynamics 365 Customer Engagement (on-premises) (Developer Guide for Dynamics 365 Customer Engagement)
Content Source: ce/customerengagement/on-premises/developer/xrm-tooling/use-connection-strings-xrm-tooling-connect.md
Product: dynamicscrm-2016
GitHub Login: @Nkrb
Microsoft Alias: nabuthuk

@NateKeefe Thanks for reaching us. We have updated the docs and published live. Closing the issue. If you need further help, please reopen or create a new issue.


Chore: update dependencies, use yarn exclusively

I'm not sure when it was decided that we were to use yarn but our CI/CD that Hyperledger helped set up continues to use it. So, rather than having both npm and yarn around, this change favors yarn.

I agree adoption of yarn is favorable. I have approved and merged.


Feature: added username in settings

fixed issue no #873 [show username/BBW address in settings]

@Ayush0054 the yarn.lock file should also not be part of the pull request.
doesn't really matter for this PR but for your information, using git rebase can help make the git commit history cleaner: https://about.gitlab.com/blog/2020/11/23/keep-git-history-clean-with-interactive-rebase/

@Ayush0054 yarn.lock should not be deleted. there should no changes to it

Ok i will fix this

i have deleted this repo and re forked it , since it was too messy to fix issue