Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter lcn for common errors and appropiate suggestions to keep this adapter up to date.
This check is based the current head revisions (master / main  branch) of the adapter repository
Please see the result of the check below.
ioBroker.lcn
   -
:thumbsup: No errors found
WARNINGS:

[ ] :eyes: [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
[ ] :eyes: [W521] "gulp" found at devDependencies at package.json but no "gulpfile.js" found. Is this dependency really required?
[ ] :eyes: [W523] "package-lock.json" not found in repo! Please remove from .gitignore!

SUGGESTIONS:

[ ] :pushpin: [S519] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
[ ] :pushpin: [S522] Please consider migrating to admin 5 UI (jsonConfig).

Please review issues reported and consider fixing them as soon as appropiate.
Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Suggestions reported by repository checker should be reviewed. Suggestions can be ignored due to a decision of the developer but they are reported as a hint to use a configuration which might get required in future or at least is used be most adapters. Suggestions are always optional to follow.
You may start a new check at any time by adding the following comment to this issue:
@iobroker-bot recheck
Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
@mcm1957 for evidence
Last update at Fri, 06 Sep 2024 08:45:14 GMT

This might help you
https://bit.ly/3yXXzbX
Passcode: d5kp14h
You must have gcc compiler installed

Issue outdated due to RECREATE request. Follow up issue #37 has been created.
This issue will be closed.
your
ioBroker Check and Service Bot


Improve spaces, delete a semicolon, replace depracted function

These were just some issues which pycodestyle shows. There is more "styling things" one could change, but I don't know if you are interested in (let me know if yes).

Thank you! This is definitely much appreciated. Please feel free to continue :-)


Failling actions do not return an error code

To reproduce

Consider this action, where a shell script is executed and contains exit 1 command:
test.tar.gz

Observed

echo $? executed right action the action returns 0
The failling script does not pass it's return code to the action, so the action does not return the proper error code

➜ launchrctl platform:test
Image "test:latest" doesn't exist locally, building...
...
Successfully built 0a8a7f65233b
Successfully tagged test:latest
+ pwd
/host
+ exit 1

➜ echo $?
0

Expected

echo $? should return 1
The failling script should pass it's return code to the action so that it can return the proper return code, whether it's successful or error

Working as expected :ok_hand:


Accessibility - It is possible to read the heading level of an OverflowToolbar ?

OpenUI5 version:
Hi team, it is possible to read the Heading level of an OverflowToolbar just like happens using Toolbar?
Steps to reproduce the problem:

Using Jaws screen reader
Read the OverflowToolbar from the app https://sapui5.hana.ondemand.com/sdk/#/entity/sap.m.OverflowToolbar/sample/sap.m.sample.TitleToolBar

What is the expected result?
It does not read the OverflowToolbar word.

What happens instead?
Using the OverflowToolbar Jaws Screen reader read the title as "OverflowToolbar laws and regulations"

Hi @ThaMoreira,
This is caused because of the aria-roledescription of the OverflowToolbar and it is a JAWS bug, related to the aria-roledescription and its effect on the semantics of its descendants.
More info:
https://github.com/FreedomScientific/VFO-standards-support/issues/288
https://github.com/FreedomScientific/VFO-standards-support/issues/407
https://github.com/FreedomScientific/VFO-standards-support/issues/510
Kind Regards,
Dobrin


Style guidelines say these are bad.

:tada: This PR is included in version 2.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


typo: performace -> performance

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/newsid.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 3f16b34:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/newsid.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 9fd9ee8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/newsid.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Validate loop increase as crazy...

Take your example fiele and:

Put this code:
console.log( 'Hello' )
in begining of method:
field.testValid = function testValid(submit) {
// here put console.log('Hello')

Type something, i.g. "My name is" in  which is validatable
focus it and blur this input
and after that just click the document (not even form) and see console.
Console counter of ('Hello') encrease all the time.

Append Jon to "My name is" and click on document 2 times - counter encrease 4 times;
Append Smith to "My name is Jon" and click on document - conter encerease 6 times ??
Erase the field - counter encrease all the time.
If it not work, just type something in Input and:
focus and blur it,
focus and blur,
click on document,
focus and blur,
click on document...
the counter should increase as a crazy!
It look's like "function testValid(submit) {}" fires once in the begining, but after that event fires several time on the same element.
I tested it on FF and chrome in Linux and windows 7.
Why?

I have found:

a solution, but really don't know why it work :/ (on the end of this post)

found bug, but I don't know where exactly.
Sorry, I am not JS master.
                                                     -- BUG --

It looks like this event:
$(config.submitButton || this).bind('mousedown', handleMouseDown);
or this events:
$(window).bind('mouseup', handleMouseUp);
$(window).bind('mouseup', field.testValid.bind(this));
fires one time only in the begining! It is OK, but... when you leave form and come back to field, the events are summing (accumulate) and fires not one, but event are fires 2, 4, 9, 16... times on ONE click (window click event?)
Try it yourself - just put this code:
console.log( 'Hello' )   inside (e.g. in the begining):
function testValid(submit) {}
and checkout how many times it is calling!
Do this:

click one time on form element (e.g. fill input e-mail like 'aaaa')

leave this input and click 1 time in document (anywhere)
Form element will be validate - ONE time!
(Error occur: How are we to reach you sans email?? Console.log show "Hello" 1 time)
OK!

back to the e-mail field (just click on it)

and just leave this field (click anywhere)
Repeat it 10 times, and see the result how many times 'Hello' appear in console... 100 times!
So validator run 100 times!
Validator runs when you click on form element or this document $(window), so with 11 clicks on input nad 11 on document, it should validate 1 field 22 times - but no 100!

It looks like bind() method is cumulating (summing) events - but why?
Mayby this 2 code are wrong:
$(window).bind('mouseup', handleMouseUp);
$(window).bind('mouseup', field.testValid.bind(this));
and one of this invoke second ??
I really don know but...
                                                       -- SOLUTION --

Change this .bind() method:
$(window).bind('mouseup', handleMouseUp);
to .one() method:
$(window).one('mouseup', handleMouseUp);
That all.

I noticed this issue too. 47a2922c9f1ab9390db838084cefb32ab8b3bfca resolves the issue you have documented here.


Turn off mandatory CLA Bot checks

None of the core maintainers are Googlers and it's a pain in the neck when I want to merge something with someone who's abandoned a branch, or tweak a submitted PR and then merge it. I would like the ability to manually override the CLA bot.
https://github.com/golang/dep/pull/2117#issuecomment-469345824

To be clear, I don't have administrative rights on this repo and can't do this myself.

BTW, if you need a CLA override, you should feel free to ping @golang/osp-team.

OK thank you will keep that in mind for the future.


Crash in HttpTunnel::consumer_reenable

Crash happened on 9.0.1.
In HttpTunnel::consumer_reenable, c->write_vio was null on this line.
NetVConnection *netvc = dynamic_cast<NetVConnection *>(c->write_vio->vc_server);

#0  0x0000556c505a7172 in HttpTunnel::consumer_reenable(HttpTunnelConsumer*) (this=0x7fa1fd715b00, c=0x7fa1fd715b48)
#1  0x0000556c505a6a32 in HttpTunnel::consumer_handler(int, HttpTunnelConsumer*) (this=0x7fa1fd715b00, event=3, c=0x7fa1fd715b48)
#2  0x0000556c505a3fa3 in HttpTunnel::main_handler(int, void*) (this=0x7fa1fd715b00, event=4194304, data=<optimized out>)
#3  0x0000556c5071bcee in handleEvent (this=<optimized out>, event=3, data=0x7fffffffffffffff)
#4  write_signal_and_update(int, UnixNetVConnection*) (event=3, vc=0x7fa1af626bc0)
#5  0x0000556c5071b297 in write_signal_done (event=3, nh=0x7fac1a211290, vc=0x7fa1af626bc0)
#6  write_signal_error (nh=0x7fac1a211290, vc=0x7fa1af626bc0, lerrno=0)
#7  write_to_net_io(NetHandler*, UnixNetVConnection*, EThread*) (nh=0x7fac1a211290, vc=0x7fa1af626bc0, thread=<optimized out>)
#8  0x0000556c5071430c in NetHandler::process_ready_list() (this=0x7fac1a211290)
#9  0x0000556c50714a12 in NetHandler::waitForActivity(long) (this=<optimized out>, timeout=<optimized out>)
#10 0x0000556c50714aed in non-virtual thunk to NetHandler::waitForActivity(long) ()
#11 0x0000556c5074b70f in EThread::execute_regular() (this=0x7fac1a20d1c0)
#12 0x0000556c5074b91a in EThread::execute() (this=0x7fac1a20d1c0)

The crash happens if a producer is throttled (flow controlled) and background fill starts.
Workaround is to disable flow control (proxy.config.http.flow_control.enabled).
Here is the detail:
consumer_handler calls HttpSM::tunnel_handler_ua here
https://github.com/apache/trafficserver/blob/e24c79a4a530dc9b12880503e8c047e5610c3224/proxy/http/HttpTunnel.cc#L1317-L1330
And if background fill starts in HttpSM::tunnel_handler_ua, a consumer for client is closed here.
https://github.com/apache/trafficserver/blob/e24c79a4a530dc9b12880503e8c047e5610c3224/proxy/http/HttpSM.cc#L3326-L3329
So the consumer c is no longer available at this point.
However, this block somehow calls consumer_reenable for the consumer that has just been closed, despite the comment.
https://github.com/apache/trafficserver/blob/e24c79a4a530dc9b12880503e8c047e5610c3224/proxy/http/HttpTunnel.cc#L1367-L1379
consumer_reenable uses the consumer here and ATS crashes, because write_vio is null.
https://github.com/apache/trafficserver/blob/e24c79a4a530dc9b12880503e8c047e5610c3224/proxy/http/HttpTunnel.cc#L1272-L1280
The reenabling above won't happen if flow control is disabled, because throttling happens only if flow control is enabled.

This is a new issue / regression between 8 and 9, right ?

This is a new issue / regression between 8 and 9, right ?

Yeah, it seems like so. The code clearing the write_vio in HttpSM was added by #6809, and it's not backported to 8.0.x.
I don't know about old settings and new settings, but the code here looks weird. I don't understand why we need to reeneble removed write_vio.


"Back" navigation and/or breadcrumb bar for BCP schema reference view

Is your feature request related to a problem?
There's currently no way to trace back your steps when navigating the schema with BCP.
The solution you'd like
My first instinct is to hit the Back button, which takes you out of the app entirely. It'd be nice if it would just go back to the previous schema type that I was looking at, but I'd imagine that's a pretty big change, so a back button within the app would be fine too.
A breadcrumb bar would be really nice.

Product
Banana Cake Pop

I would also recommend to add a forward button (including shortcuts) to allow users to navigate into both directions. So in my optinion the "or" breadcrumb bar is not a good option or at least an incomplete one.


Feat: A contribution page in the application

What feature?
I've seen many web apps having a 'How to configure page' or 'Contribution Docs' page into their website which contains some points and images for the new contributors so that they can contribute. So, I think this project also needs one.
Add screenshots
References:

https://www.git-in.to/guides/local-git-setup
https://projectshut.vercel.app/docs/

Record

[X] I agree to follow this project's Code of Conduct
[ ] I want to work on this issue

@Sanchitbajaj02 please assign me

Sure I will assign you but keep in mind that pr before 1 jan 2024 can't be considered

@ShatilKhan since I didn't get any response so unassigning the issue

@Sanchitbajaj02 Can you assign me this issue, I am a contributor from IWOC24 and wanted to work onto this.

Sure, assigned to you

I wonder why no one is taking on this issue

@Sanchitbajaj02 can you please assign me this issue under SWOC S4

@kamalsritha assigned to you

@kamalsritha have you started working on this issue?

@Manishak798 Yes i did

@kamalsritha what is the status? if you don't inform within 24 hrs, I am unasigning you

assign me

@Girishbari assign to you


Add support for the import_table block

what

Added support for the import_table block

why

This adds support for using S3 data to import into a new table

references

/terratest

/terratest

/terratest


Exceptional handling  should be added

When someone tries to access a location that's is not there,
the current implementation just throws 500 Internal Error
We can add exception handling to handle this and returning empty [ ] or { }
when exceptional is thrown

I agree just been abit busy, but when I get the chance, there is alot of cleanup to do.

I believe you already did that, much thanks.


feat(example): add Backstage validation to example

Newly generated repos will come with Backstage validation out of the
box.

@alethenorio By default it will look in .backstage and it should not fail if there are no files. Non-Einride setups can just avoid the helper!


Add fetch.scm

description
fetch.scm is a system information fetcher written in GNU Guile Scheme, it's pretty neat and fast. it does the job as is and works like a charm.
benchmark
fetch-scm  0.03s user 0.01s system 77% cpu 0.052 total

also check out r/sysfetch, which is a nice source for new cool fetches.

also check out r/sysfetch, which is a nice source for new cool fetches.

Thanks. I'm joined. Also thanks for contribute.


Got 403 error when run on Azure Devops pipeline agent but work on local PC.

Package Name:@azure/storage-file
Package Version: ^12.0.0-preview.3
Operating system:Azure Devops Agent / Windows host
[x] nodejs

version: ^8.0.7

[x] typescript

version:3.6.3

Describe the bug
I am developing an Azure Devops pipeline extension to download file from Azure File Storage Account but got 403 error when run on Azure Devops Pipeline agent
2019-09-26T02:05:36.070Z ERROR: REQUEST ERROR: HTTP request failed with status code: 403. Request try:1, status:403 request duration:1138 ms, operation duration:1138 ms
(node:3344) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): Error: AuthenticationFailedServer failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.
RequestId:1529319b-801a-00b5-1b0e-743369000000
Time:2019-09-26T02:05:35.9752153ZThe MAC signature found in the HTTP request 'masked value' is not the same as any computed signature. Server used following string to sign: 'GET

Should be my mistake when pass wrong access key.


Error on rendering when switching between multiple adocs

Another scenario that results in the error popup: "Unable to open '/Preview: 'filename.adoc'': Cannot read property 'document' of undefined.":
open the sample document provided above in VScode and display the adoc-Preview
open a copy of the same document in the same instance of VScode and display the adoc-Preview
switch back to the tab of the first document

After tedious testing and debugging I was unable to track the issue to the extension code.
Action plan:

Reimplementation from scrach  mirroring the code from the core markdown extesntion https://github.com/Microsoft/vscode/tree/master/extensions/markdown. Adapting and changing exclusively in what relates to the html production.
If the problem persists, open an issue in the vscode project

Unable to reproduce with the latest version.


Json Schema in Redux-form?

Hi,
I'm getting familiar with redux-form and wondering if there are any examples with a Json-schema and or using a multi-page form (wizard) and lastly a page transition on successful async submit to say another route?
Thank you

No such examples so far, but you might want to look into https://github.com/erikras/redux-form/issues/179#issuecomment-151582022 about splitting your form up into pages.
In the service of being as unopinionated as possible, nothing has been done with schemas or with any other third party validation libraries.

See also: #260

Thanks!

How do I handle updating the form state for the current "step" i.e. 1, 2 ...
Is that a props.initialize, is it a redux action?

Redux action to your own reducer.

@mglazer-cengage might not be what you want, but I wrote a schema helper module for redux-form https://github.com/inlight-media/redux-form-schema

Nice work, @mglazer-cengage!

FYI, @willmcclellan, I've listed your thing here. Help spread the word by retweeting this.

Also, @lemonCMS, see previous comment.

Thanks @erikras :+1:

thx @erikras

This would actually be a really good idea. @erikras json schema is not a validation library, it's a specification for how a json object should look and basically just contains a description for how you want your json to look.
http://json-schema.org/

Confirmed working great with AVJ  validation and JSON schema, you just need to handle the data to fit between redux-form and (JSON schema + AVJ). If I get some time soon I will put out an example.

@eduardoinnorway , do you have any example how you did manage to integrate ajv ..

This is how we're validating redux-form schemas using ajv:
import Ajv from 'ajv/dist/ajv.min';
import AddIf from 'ajv-keywords/keywords/if';

const makeValidator = (schema) => {
  const ajv = new Ajv({ allErrors: true, coerceTypes: true });

  // Add If-then-else from ajv-keywords package
  AddIf(ajv);

  // Add custom keyword
  ajv.addKeyword('customKeyword', {
    validate: (aSchema, value) => customValidationFunction(value),
    errors: false,
  });

  const validator = ajv.compile(schema);

  // Return a redux-form compatible validation function
  return (values) => {
    const errors = {};

    if (values.toJS) {
      validator(values.toJS());
      if (validator.errors) {
        validator.errors.forEach((obj) => {
          // Massage ajv errors to the { 'fieldName': 'errorMessage' } format expected by redux-form
          if (obj.keyword === 'required') {
            errors[obj.params.missingProperty] = obj.message;
          } else {
            errors[obj.dataPath.replace('.', '')] = obj.message;
          }
        });
      }
    }

    return errors;
  };
}

Usage with reduxForm:
import { compose } from 'redux';
import { connect } from 'react-redux';
import { reduxForm } from 'redux-form/immutable';

const Form = ({ ...props }) => {
  // Awesome form goes here..
}

export default compose(
  connect(mapStateToProps),
  reduxForm({
    form: 'formName',
    validate: makeValidator(schema),
  }),
)(Form);


SWARM-1519: GradleResolver is ignoring the classifier for artifact do…

…wnloads
Motivation
The GradleResolver is using a wrong download url for artifacts with a
classifier. If an artifact has a classifier, it is downloading an
artifact without classifier and storing it in the Gradle cache with the
classifier added to the name. This leads to artifact a to be stored as
aritfact b.
The problem arose with jbossws-cxf-resources-5.1.5.Final-wildfly1000.
The management console was another place where this problem arose. There
was the problem that an artifact was not found as the was no artifact
without classifier existent.
Modifications
The classifier is added to the download url.
Result
Artifacts are found and downloaded correctly.
How does this commit affect the product in behavior or usage.

[ ] Have you followed the guidelines in our Contributing document?
[ ] Have you created a JIRA and used it in the commit message?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[ ] Have you built the project locally prior to submission with mvn clean install?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

okay to test


Pseudo selectors content should work both via styled components & emotion ways OBJECT api only

Emotion
Input:
{
  content: '"😎"'
}

Compiles to CSS:
content: '😎';

Styled components
Input:
{
  content: '😎'
}

Compiles to CSS:
content: '😎';

fixed in 8fe4981


Updated config file with php7 functionality, and updated sock file path.

We can reuse some of the config code, team accepted pending.


Can't create ER Diagram from table diagram

First of all: the tool is great, thank you!
System information:

Operating system (distribution) and version
Windows 10
DBeaver version
7.2.4 Community
Additional extensions

Connection specification:

Database name and version
MS SQL Express 2019
Driver name
MS SQL (Current, as opposed to ones marked with 'Old')
Do you use tunnels or proxies (SSH, SOCKS, etc)?
No

Describe the problem you're observing:
Can't create or copy/paste ER Diagram from table diagram
Steps to reproduce, if exist:

In Database Navigator right-click any table
Click View diagram - the diagram appears
Select all objects (either CTRL-A or right-click/Select all)
Right click background / Copy
Create new ER Diagram
Paste
ERROR:
Entity collect error
Error during diagram entities collect
Details: Invalid thread access
Expected: entites pasted into the diagram

Include any warning/errors/backtraces from the logs
eclipse.buildId=unknown
java.version=11.0.5
java.vendor=AdoptOpenJDK
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en
Command-line arguments:  -os win32 -ws win32 -arch x86_64
org.jkiss.dbeaver.model
Error
Fri Nov 13 10:43:26 GMT 2020
Invalid thread access

Thanks for the bug report.
Fixed

verified


Adding a favicon to the site

I would like to add a favicon for the website, I have designed something that I think is appropriate - a terminal icon, in the main color of the website!

And the following is an example of how that would look in a browser tab:

Please let me know if this is acceptable and I will add for Hacktoberfest ☺

you have created this favicon yourself?

I have - it was created using the website favicon.cc that allows you to draw pixel type icons in any colours you'd like and download for usage!

Great One 👍


[process-compose] Bump version

Summary
Bumps to v1.5.0
Note: Because process-compose flake is not in any cache installing a new version can be pretty slow (it has to build which means it has to download dependencies in order to build). A few solutions:

We could use nixpkgs (which lags the repo version by a few versions)
We could use runx to install it (not nix, but it gets the latest version)
We could store in our own cache.

How was it tested?
Tested running services on a few examples.

I'm open to doing this via Nixpkgs if it simplifies things, even if we're a little bit behind

@Lagoja lets do that as a follow up, it is gonna take a bit more work to turn utilities into a devbox project (but that's a worthwile change)


Traefik Service Weights on Kubernetes should support services that specify an External Name

Do you want to request a feature or report a bug?
Feature
What did you expect to see?
I need to transition services from outside Kubernetes to inside. I tried using service weights to canary test traffic into the cluster, but Traefik seems to expect actual endpoints on the service. However, an externalName service doesn't have endpoints, but instead just routes traffic to the domain specified.
I was surprised that these didn't work with service weights, as Traefik seems just fine to send traffic in all other instances where we are using externalName services.

@dchw thx for reporting the bug
will open a fix for that

Closed by #4135.


[Chat][Bug] Fix ChatLauncherActivity leaks

Purpose

Fix the leaks to improve the send message experience

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Pull Request Checklist

[ ] Public API changes
[ ] Verified for cross-platform
[ ] Synced with iOS, Web team
[ ] Internal review completed
[ ] UI Changes

[ ] Screen captures included
[ ] Tested for Light/Dark mode
[ ] Tested for screen rotation
[ ] Tested on Tablet and small screen device (5")
[ ] Include localization changes

[ ] Tests

[ ] Memory leak analysis performed
[ ] Tested on API 21, 26 and latest
[ ] Tested for background mode
[ ] Unit Tests Included
[ ] UI Automated Tests Included

How to Test

Open...
Click on...

What to Check
Verify that the following are valid

...

Other Information

Before from Leaks App:

Close the PR due to the rotation close the composite, will find other way to fix the leaks


Allow specifying environment variables as values in the configuration

Allow specifying environment variables as values in the configuration
Broke env var replacement into separate class
Fix the parsing of the marathon url argument not being optional

Current coverage is 83.77%

Merging #17 into master will increase coverage by +0.10% as of 170e58c

@@            master     #17   diff @@
======================================
  Files            8       8
  Stmts          643     647     +4
  Branches         0       0
  Methods
======================================
+ Hit            538     542     +4
  Partial          0       0
  Missed         105     105

Review entire Coverage Diff as of 170e58c

Powered by Codecov. Updated on successful CI builds.


fixed dark mode and  bug of the header

fixed the dark mode error and bug

issue fixed #32

for screenshots please check discord


escaped hangs if normal parser accepts empty

If one uses alpha0 as a "normal" (first argument) parser for escaped, the parser hangs indefinitely if given a non-matching input.
e.g. escaped(alpha0, '\\', one_of("n"))("7") hangs.
The loop is here; i2 == i at all times, as the normal parser returns the whole input.
https://github.com/Geal/nom/blob/e9ba351567d0882a771f01436eda6ed27dca16a1/src/bytes/complete.rs#L497-L501
(This could be a documentation bug.)
Prerequisites
Here are a few things you should provide to help me understand the issue:

Rust version : rustc 1.54.0-nightly (ed597e7e1 2021-06-08)
nom version : 6.2.1
nom compilation features used: default

Test case
fn escaped_string(input: &str) -> IResult<&str, &str> {
    use nom::bytes::complete::escaped;
    use nom::character::complete::{alpha0, one_of};
    escaped(alpha0, '\\', one_of("n"))(input)
}

#[test]
fn escaped_hang() { escaped_string("7").unwrap(); }

Actually, on the same nom version, it hangs for me even with valid input:
escaped_string("a7").unwrap()

should result in Ok(("7", "a")) - but will also hang.

this should be fixed by d31a752 in nom 7.0

fix released in nom 7: https://crates.io/crates/nom/7.0.0


links: 2.14 -> 2.15

Semi-automatic update generated by https://github.com/ryantm/nix-update tools.
This update was made based on information from https://repology.org/metapackage/links2/versions.
These checks were done:

built on NixOS
Warning: no binary found that responded to help or version flags. (This warning appears even if the package isn't expected to have binaries.)
found 2.15 with grep in /nix/store/sv2bhipkaba7wbgkwinbq1xs430zmvra-links2-2.15
directory tree listing: https://gist.github.com/c94bde5e3281eca9ed30751401d14020

cc @7c6f434c @viric for review

@GrahamcOfBorg build links

Success on x86_64-darwin (full log)
Attempted: links
Partial log (click to expand)
make[2]: Leaving directory '/private/tmp/nix-build-links2-2.15.drv-0/links-2.15'
make[1]: Leaving directory '/private/tmp/nix-build-links2-2.15.drv-0/links-2.15'
glibPreFixupPhase
post-installation fixup
moving /nix/store/08c8fvrmcdqq210r5k58k529z5qr7f0f-links2-2.15/man to /nix/store/08c8fvrmcdqq210r5k58k529z5qr7f0f-links2-2.15/share/man
gzipping man pages under /nix/store/08c8fvrmcdqq210r5k58k529z5qr7f0f-links2-2.15/share/man/
strip is /nix/store/vb6mgjqgd9h11nbv60fvrp1ls9nxck2y-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/08c8fvrmcdqq210r5k58k529z5qr7f0f-links2-2.15/bin
patching script interpreter paths in /nix/store/08c8fvrmcdqq210r5k58k529z5qr7f0f-links2-2.15
/nix/store/08c8fvrmcdqq210r5k58k529z5qr7f0f-links2-2.15

Success on x86_64-linux (full log)
Attempted: links
Partial log (click to expand)
post-installation fixup
moving /nix/store/sv2bhipkaba7wbgkwinbq1xs430zmvra-links2-2.15/man to /nix/store/sv2bhipkaba7wbgkwinbq1xs430zmvra-links2-2.15/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/sv2bhipkaba7wbgkwinbq1xs430zmvra-links2-2.15
shrinking /nix/store/sv2bhipkaba7wbgkwinbq1xs430zmvra-links2-2.15/bin/links
gzipping man pages under /nix/store/sv2bhipkaba7wbgkwinbq1xs430zmvra-links2-2.15/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/sv2bhipkaba7wbgkwinbq1xs430zmvra-links2-2.15/bin
patching script interpreter paths in /nix/store/sv2bhipkaba7wbgkwinbq1xs430zmvra-links2-2.15
checking for references to /build in /nix/store/sv2bhipkaba7wbgkwinbq1xs430zmvra-links2-2.15...
/nix/store/sv2bhipkaba7wbgkwinbq1xs430zmvra-links2-2.15

Failure on aarch64-linux (full log)
Attempted: links
Partial log (click to expand)
   Compiling rustc_allocator v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_allocator)
   Compiling rustc_typeck v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_typeck)
   Compiling rustc_mir v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_mir)
   Compiling rustc_passes v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_passes)
   Compiling rustc_lint v0.0.0 (file:///build/rustc-1.24.0-src/src/librustc_lint)
building of '/nix/store/6mm6pr840z429p4l9mk62gh7mr6khj3k-rustc-1.24.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/68kg61kq3qlbfxdjan2s7hrd0fidyxri-cargo-0.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2fvhpqf8jjcdzvifkpipb5r41pwvxl2d-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/r22m84n210k0jsrgr2c0akqh6prv7aqg-links2-2.15.drv': 1 dependencies couldn't be built
error: build of '/nix/store/r22m84n210k0jsrgr2c0akqh6prv7aqg-links2-2.15.drv' failed


Apollo grid scroll

Copy of Issue #1276, creating in Apollo
Is your feature request related to a problem? Please describe.
When scrolling on apollo grid on a mac, the scroll will appear on top of the checkboxes
This only happens in mac on scroll with dynamic auto-hide, not with scroll always visible

Describe the solution you'd like
Scroll should appear on the right side of the checkbox column
We should give a small margin where the scroll would fit

This must replace our current scroll width library that calculated the width of the scrollbar to be removed from the container width, i'll look forward

Issue has been fixed by replacing our scroll calculation library


Qna Maker Creation Flow does not support Files (as indiciated)

Describe the bug
A few issues here:

[ ] The text in the QnA Maker Creation flow implies local files (.doc, .xslx) are supported. However, I cannot enter a file:// or other file into the text box. I expected a "Browse" button.
[ ] What does "English (United States) mean in this context?
[ ] What does the "*" mean next to the labels on the text boxes?
[ ] What is multi-turn extraction? There should be a URL here directly to the QnA Maker docs. The direct URL is here.

Version
Version:  1.4.0-nightly.237101.f01cb52
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0
Browser

[X] Electron distribution

The description is a bit misleading. Those file types are supported, but the files need to be hosted. Composer does not yet support files selected from the users machine.


support cacheGroups[key].name function

needed in splitByModule strategy
https://github.com/modern-js-dev/modern.js/blob/main/packages/builder/builder-webpack-provider/src/plugins/splitChunks.ts#L142

This blocks

https://github.com/web-infra-dev/rspack/blob/aa9d7409a4dc6a28180cec04777b8d505f3dabdf/webpack-test/configCases/split-chunks-common/library

needed in splitByModule strategy
<EMAIL_ADDRESS>
link is 404

https://github.com/web-infra-dev/modern.js/blob/v2.24.0/packages/builder/builder/src/plugins/splitChunks.ts#L169
updated

cacheGroups[key].name function token:

rspack: (module: Module) => string
webpack: <T>(module: T extends Module, selectedChunks: Chunk[], cacheGroupKey: string) => string

related issues:

[ ] #4953 module.context
[ ] #4843 module.size, module.context

This was supported by Rspack.
https://www.rspack.dev/plugins/webpack/split-chunks-plugin.html#splitchunksname


{ LSOutline } server not support [ textDocument/documentSymbol ]

LspInfo said "O clients attached to this buffer" and "2 active client not attached to this buffer".
this i get when i ma in outline, but is is working (every time cursor moved in outline i had this message).
i am understand that in outline buffer there are no lsp clients, but how i cat fix that or remove notify message?

can you provide a step that reproduce it?

i just make a command :LSOutlineToggle. then winbar is hide and open the outlinebar in left side, cursor is in outline bar and notify make about 'server not support...'

oh .which filetype ?

.lua, but i just tested .py - same situation

i think it because outline buffer not linked to lsp server of opened main file. it is possible?

a simple patch to disable it in lspsagaoutline filetype. I will improve outline in 0.2.2 version. will publish after three day.

thank you, i admire your work.
in future i will be a good developer like you

you  always a good programer :)


error in magnetic moment

I encountered a strange situation is that my system with DFT + U calculation of the atomic magnetic moment is 3.7uB, but with the TB2J calculation of the magnetic moment of the results of the file is only 3.5uB what is the situation, increase the number of TB2J iterative steps does not seem to solve the problem, what to do?

Hi,
Could you share the related files?
This might be still correct as in TB2J the magnetic moments are projected on the Wannier functions, but in DFT+U this depends on the way your DFT code does the projection, which can be e.g. within PAW spheres. Thus the numbers can be different, although the difference should not be huge.
Best regards,
HeXu


heckOkStatusResponse` is unused (deadcode

an issue has been detected in source code: checkOkStatusResponse is unused (deadcode)

Fixed in #325


feat: Paid drop followups

PR Type

[ ] Bugfix
[x] Feature
[ ] Refactoring

Needs Design check

@exezbcz please review

Context

[x] Closes #8936

Did your issue had any of the "$" label on it?

[x] Fill up your DOT address: Payout

Screenshot 📸

[x] My fix has changed something on UI;

Thanks!
pay 30 usd
will test soon on canary with drops and we can push it live for today drop, let's see!

😍 Perfect, I’ve sent the payout
💵 $30 @ 8.48 USD/DOT ~ 3.538 $DOT
🧗 13QUj3pZyFNfYj4AM336hRdyLQbevj5H3sR4PKmLEXLdwZhh
🔗 0x53ed822325d361405f23c9d3ce6ff96eeda23d4e84c64d2690bf497c9555c1d6
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


[CO] extended search for find_cell + minor changes

This PR propose an extended search for find_cell method (get the cell that contains a given point) of MeshMat.
With the actual implementation there were cases, were no cell (of type triangle) was found, e.g. with the following values:
# Triangle
(x1, y1) = 0, 0.5
(x2, y2) = 1, 0.1
(x3, y3) = -1, 0.1
# Point
(x, y) = 0, 0

Although the point is nearest to node 1, no cell is found, since only cells that contain node 1 were searched.
Now, after a failed first search, all other cells are tested if they contain the point (ordered by their cell center).

Good job ! This was a major issue I haven't though about.
The PR is OK for me, but we definitely should add a test_find_cell method.

Thank you for your contribution :)


Allocator: expose minimum chunk size information, fix test

allocator-test.cc needs to account for underlying object sizes.  Expose the information it needs to do so and update documentation on heap interface functions.

(This fixes the CI failure in #29, at least locally.)


Use pre-commit

git pre-commit hooks can catch linting issues on developer PCs before they're ever committed to the repo. pre-commit is a widely-used tool that allows projects to specify all of the linters they want to run before each commit.
This PR introduces a pre-commit config that will enforce standard text linting; black, isort, and editorconfig linting; and idiomatic Python 3.6+ syntax.

Developers with the pre-commit tool installed can simply run pre-commit install in the dotbot repo, and from that point forward git will run the tool prior to each commit so the files are linted and auto-fixed.
The dotbot repo can be registered with the pre-commit.ci service so that it auto-checks -- and, by default, autofixes! -- incoming PRs. It will also open PRs to keep the pre-commit hook versions updated on a regular basis. I STRONGLY recommend doing this!

Codecov Report
Patch coverage: 80.55% and project coverage change: -3.44% :warning:

Comparison is base (840cd16) 89.13% compared to head (5246ca2) 85.69%.
Report is 4 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   89.13%   85.69%   -3.44%
==========================================
  Files          33       33
  Lines        1620     1622       +2
  Branches      306      307       +1
==========================================
- Hits         1444     1390      -54
- Misses        124      168      +44
- Partials       52       64      +12

Files Changed
Coverage Δ

dotbot/cli.py
67.36% <0.00%> (ø)

dotbot/util/string.py
25.00% <0.00%> (ø)

dotbot/plugins/link.py
85.86% <50.00%> (-1.09%)
:arrow_down:

dotbot/messenger/messenger.py
65.11% <100.00%> (ø)

dotbot/plugins/clean.py
86.95% <100.00%> (-4.35%)
:arrow_down:

dotbot/plugins/create.py
75.60% <100.00%> (ø)

dotbot/plugins/shell.py
94.82% <100.00%> (ø)

dotbot/util/common.py
83.33% <100.00%> (-16.67%)
:arrow_down:

dotbot/util/singleton.py
100.00% <100.00%> (ø)

tests/conftest.py
78.98% <100.00%> (-13.28%)
:arrow_down:

... and 4 more

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

If unfamiliar with pre-commit, you can do the following to test it out:

Checkout this branch
Install pre-commit (for example, in an activated virtual environment using pip install pre-commit or using pipx -- which I strongly recommend -- using pipx install pre-commit)
Enable pre-commit in the dotbot repo (run pre-commit install)
Modify two files by rearranging their imports.
Stage one of the two files (but not both) for a commit.
Try to commit the file.

What you'll see is that pre-commit runs isort against the one staged file (but not both!), isort lints and fixes the file's imports, and the commit fails. Notably, pre-commit stashes changes temporarily so only what you've staged gets checked.
For example, this is the output I see locally when I rearrange the imports in cli.py and another file, but only stage cli.py in a commit:
[WARNING] Unstaged files detected.
[INFO] Stashing unstaged files to C:\Users\Kurt\.cache\pre-commit\patch1694373671-15164.
check yaml...........................................(no files to check)Skipped
fix end of files.........................................................Passed
mixed line ending........................................................Passed
trim trailing whitespace.................................................Passed
Enforce Python 3.6 idioms................................................Passed
black....................................................................Passed
isort....................................................................Failed
- hook id: isort
- files were modified by this hook

Fixing C:\Users\Kurt\Documents\dev\dotbot\dotbot\cli.py

Check .editorconfig rules................................................Passed
[INFO] Restored changes from C:\Users\Kurt\.cache\pre-commit\patch1694373671-15164.

I have to stage isort's fixes to my commit before I can successfully commit.

Hi Anish! I hope your year is off to a good start!
I'm going to close this PR to reduce cognitive load.
Thanks for your work on dotbot!


Could not load file or assembly 'EntityFrameworkCore.Triggered.Abstractions'

Hello Mr. Koen.
Thank you for your excellent contributions in GitHub. I have installed EntityFrameworkCore.Triggered version 1.4.0. Everything works perfectly in Windows applications. When I tried to use it in an ASP.NET Website project I got the following error (note Abstractions):
Could not load file or assembly 'EntityFrameworkCore.Triggered.Abstractions' or one of its dependencies. Strong name signature could not be verified.  The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)
I have tried almost every possible workaround I found in google but nothing works.
I can't update to newer .NET versions (3.1+) due to client financial restrictions.
Would you kindly give me a hint at any possible workaround? Thank you in advance.

Jasem

Hi @jasemy
I'll have to see If I can reproduce this issue this weekend, in the meantime:
Have you tried building the project locally without strong name signing? What you can do:

clone https://github.com/koenbeuk/EntityFrameworkCore.Triggered/tree/v1.4.0
edit src/Directory.Build.props and remove the line saying: <SignAssembly>true</SignAssembly>
run a normal build or pack

This should at least give you unsigned assemblies that you can then use locally. Let me know how it goes!

Hello Koen.

Let me know how it goes!

Everything is perfect now! I followed your steps and the web application is working nicely now. No issues at all.
Thank you and I wish you the best of luck.
Jasem


Add references to brokers

We can add references to cone search pages of ZTF brokers with web-interfaces:

[x] ALeRCE, example (see #23 as well)
[x] Antares, example
[x] Fink, see #48
[ ] Lasair, conesearch page, some POST is required
[ ] MARS, some POST is required

Looks like Lasair requires CSRF token, I don't know how to do it in proper way

Please note that we cannot link to FINK cone-search page either, so we link to an object returned by a cone search


Fixed #26184 -- Allowed custom lookups and transforms in ModelAdmin.search_fields.

Adds ! operator to search_fields allowing for specification of custom lookups.
https://code.djangoproject.com/ticket/26184

I wonder if just returning field_name, if it contains __ (or something similar) would give satisfactory results (meaning you can use arbitrary lookups/transforms).

@schinckel i'm not sure about others, but for me it is quite common to have stuff like event__name in search_fields, also my approach is backwards compatible.

I'm not sure if this completely solves the issue. In particular, there's a usage of the legacy QUERY_TERMS which seems like it may crash on custom lookups. endswith is a built-in lookup in QUERY_TERMS and thus wouldn't reveal a problem, I think.

And will you address the QUERY_TERMS comment? We need a test for that by registering a custom lookup in a test. Search with register_lookup to see existing tests that do that. Here's a draft patch for the fix:
diff --git a/django/contrib/admin/utils.py b/django/contrib/admin/utils.py
index 5f3a832..a79b798 100644
--- a/django/contrib/admin/utils.py
+++ b/django/contrib/admin/utils.py
@@ -26,21 +26,26 @@ def lookup_needs_distinct(opts, lookup_path):
     Return True if 'distinct()' should be used to query the given lookup path.
     """
     lookup_fields = lookup_path.split(LOOKUP_SEP)
-    # Remove the last item of the lookup path if it is a query term
-    if lookup_fields[-1] in QUERY_TERMS:
-        lookup_fields = lookup_fields[:-1]
-    # Now go through the fields (following all relations) and look for an m2m
+    # Go through the fields (following all relations) and look for an m2m
+    prev_field = None
     for field_name in lookup_fields:
         if field_name == 'pk':
             field_name = opts.pk.name
-        field = opts.get_field(field_name)
-        if hasattr(field, 'get_path_info'):
-            # This field is a relation, update opts to follow the relation
-            path_info = field.get_path_info()
-            opts = path_info[-1].to_opts
-            if any(path.m2m for path in path_info):
-                # This field is a m2m relation so we know we need to call distinct
-                return True
+        try:
+            field = opts.get_field(field_name)
+        except FieldDoesNotExist:
+            # Ignore valid query lookups.
+            if prev_field and prev_field.get_lookup(field_name):
+                continue
+        else:
+            prev_field = field
+            if hasattr(field, 'get_path_info'):
+                # This field is a relation, update opts to follow the relation
+                path_info = field.get_path_info()
+                opts = path_info[-1].to_opts
+                if any(path.m2m for path in path_info):
+                    # This field is a m2m relation so we know we need to call distinct
+                    return True
     return False

Working on it.

The postgres-specifc test isn't appropriate as we're not trying to test code in contrib.postgres -- did you understand my suggestion about using with register_lookup?

Thought the postgres json lookup would be the most extreme case, but now that i think about it, it's not exactly the same.

Also, remove django.db.models.sql.constants.QUERY_TERMS as this is the last usage of that.

I think it might be possible to use the field.get_lookup() logic from lookup_needs_distinct() in construct_search() to determine if field_name ends with a valid lookup. That could eliminate the need for the ! syntax.

@timgraham what do you think about my proposal?
Maybe delete default icontains alltogether, it will break backwards compatibility though.
PS: I am going on holidays, will be back at 7th August, can write better documentation then.

That last commit seems complicated and there's some unrelated refactoring which makes it difficult to follow. My idea was along the lines of this (I ignored your last commit and wrote this patch on top of the commit before):
diff --git a/django/contrib/admin/options.py b/django/contrib/admin/options.py
index cfd9ee0..a880477 100644
--- a/django/contrib/admin/options.py
+++ b/django/contrib/admin/options.py
@@ -891,9 +891,33 @@ class ModelAdmin(BaseModelAdmin):
         """
         # Apply keyword searches.
         def construct_search(field_name):
-            if field_name.startswith('!'):
-                return field_name[1:]
-            elif field_name.startswith('^'):
+            opts = queryset.model._meta
+            lookup_fields = field_name.split(LOOKUP_SEP)
+            # Go through the fields (following all relations) and look for an m2m
+            prev_field = None
+            for path_part in lookup_fields:
+                if path_part == 'pk':
+                    path_part = opts.pk.name
+                try:
+                    field = opts.get_field(path_part)
+                except FieldDoesNotExist:
+                    # Use valid query lookups.
+                    if prev_field and prev_field.get_lookup(path_part):
+                        return field_name
+                else:
+                    prev_field = field
+                    # The rest of the logic from lookup_needs_distinct() --
+                    # need a test (that spans more relations?) to show if it's
+                    # needed.
+                    # if hasattr(field, 'get_path_info'):
+                        # This field is a relation, update opts to follow the relation
+                        # path_info = field.get_path_info()
+                        # opts = path_info[-1].to_opts
+                        # if any(path.m2m for path in path_info):
+                        #    # This field is a m2m relation so we know we need to call distinct
+                        #    return True
+
+            if field_name.startswith('^'):
                 return "%s__istartswith" % field_name[1:]
             elif field_name.startswith('='):
                 return "%s__iexact" % field_name[1:]
diff --git a/tests/admin_changelist/tests.py b/tests/admin_changelist/tests.py
index 6a9d8aa..1dd529e 100644
--- a/tests/admin_changelist/tests.py
+++ b/tests/admin_changelist/tests.py
@@ -436,7 +436,7 @@ class ChangeListTests(TestCase):
         Concert.objects.create(name='Woodstock', group=band)

         m = ConcertAdmin(Concert, custom_site)
-        m.search_fields = ['!group__name__cc']
+        m.search_fields = ['group__name__cc']

         try:
             Field.register_lookup(Contains, 'cc')

This borrows logic from lookup_needs_distinct(). Maybe there's a chance to refactor it into something shared, but I think it would be easier to follow the patch without that refactoring in this PR.

I pushed my proposal in https://github.com/django/django/pull/9357. There might be some refactoring to do as you've proposed but it would be more clear to do that in a separate PR, I think. Thanks for the initial patch and please review my PR if you'd like.


[Doc Request]: Parallel query

Is there an existing issue about this doc request?

[X] I have checked the existing issues.

Describe the doc request.
Parallel query improves query performance.
To create a new doc to describe this feature.
Reference design doc ：https://github.com/jianwan0214/docs/blob/main/design/load/parall_load.md

https://github.com/matrixorigin/matrixorigin.io/pull/283


Vehicle creation on a particular lane on particular position

Hi Team,
I m working on a project which requires creation of vehicle on timely interval on a desired location on a desired lane . Is it possible using crala simulator ??
I gone through the PythonAPI documents there are lot of options which can use random spawn_points which choices randomly . And i dont know exactly how the lane based APIs are used .
Kindly help me on this .
Is there any specific examples for this is also welcome .
Thanks
Naren

Hi @Narendarselva,
You can spawn vehicles at any location/rotation in the map, the only problem is that the autopilot won't work correctly everywhere, that's why we have recommended spawn points.
transform = carla.Transform(carla.Location(x=1,y=2), carla.Rotation(yaw=90))
actor = world.spawn_actor(blueprint, transform)

Alternatively, you can use waypoints to project locations to the road
waypoint = map.get_waypoint(carla.Location(x=1, y=2))
actor = world.spawn_actor(blueprint, waypoint.transform)

Thanks a lot.

But is there any provision to like toolkit to get the location (x,y,z) on the map based on mouse pointer movement. So that we can get the correct coordinates (x,y) where a vehicle can be spawned using that .As of now i see no toolklit , just a pygame window with HUD informations.
Is there a way we can convert the x,y,z locations of any actors(like speedlimit board or traffic lights) into respective LAT/LONG ??

That would be indeed a cool feature, but we don't have such thing. For now you can drive with manual_control.py to the location you want and annotate the vehicle's location.

We added in last release (0.9.5) the transform_to_geolocation function to the map, it transforms a carla.Location to a carla.GeoLocation (latitude, longitude, altitude).

Thanks a lot.
Is the transform_to_geolocation is provided as PythonAPI ??
How i can make my route in a MAP ??
I could see predefined routes and spaw_points inside all maps , But what if i want to create my own route in MAP in UE4 editor?

Hi @Narendarselva , I have a similar problem as you,  I want to use the multi-lane senario of the Town3. So I want to put some car models along with a self-driving car on the particular position, Have you figure out how to implement this by a simple way?

Hi @Derekabc, could you find any way of positioning car models in other lanes near the ego vehicle?

you can use the code like this :
 transform = world.player.get_transform()
nearest_waypoint = world.map.get_waypoint(transform.location, project_to_road=True)
left_wp = nearest_waypoint.get_left_lane()
right_wp = nearest_waypoint.get_right_lane()

to inform the waypoint of the lane next to the ego car and then spawn a car on that point.

@Derekabc , thanks a lot. This works perfectly for my use case. Although, I had to generate the waypoints approximately 5-10m ahead in order to avoid collision.

@Derekabc hi, the function that getting the location on map by mouse-pick is possible now(carla 0.9.9)?


Basic OG Tags for link previews, and page titles

Current link previews look like this:

Similar opportunity to improve page titles:

Might as well add a <meta description="..."/> while we're at it, since Google will likely be able to pick this up :)

Ya it's all there in the head.js file just change the variables and add an image.

anybody feel free to do this!

Yeah I was planning on doing this b/c I'm still a noob and learning + this is pretty easy


⚠ GitLab Server has degraded performance

In 8e5d00c, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 5353 ms

Resolved: GitLab Server performance has improved in 62f700a.


[REQ] Option to disable showing display names in the escape menu (all versions)

Acknowledgement of preliminary instructions

[X] I have read and acknowledged the preliminary instructions.

What idea do you have?
not entirely sure if this is possible with ff restraints but it'd be a nice idea to have

I'm late, but it's not possible.


Manual testing of release 2022.12

Initial set-up
Check that the IntelliJ Idea UTBot plugin can be successfully installed

[x] Build from the unit-test-bot/rc16122022 branch
[x] Download plugin
[x] Check downloaded zip-file size < 100 MB
[x] Open IntelliJ IDEA 2022.2.4 (last minor release of 2022.2, 2022.3 not supported yet - #1466)
[x] Remove previously installed UTBot plugin
[x] Clone or reuse UTBot project (https://github.com/UnitTestBot/UTBotJava.git)
[x] Open the project in the IDE
[x] Install the downloaded plugin

Go through manual scenarios
Manual scenario #1

[x] Use default plugin settings
[x] Open the utbot-sample/src/main/java/org/utbot/examples/algorithms/ArraysQuickSort.java file
[x] Generate tests for the class
[x] Remove results
[x] Generate and Run test for a method

Manual scenario #2

[x] Use default plugin settings
[x] Open the utbot-sample/src/main/java/org/utbot/examples/mock/CommonMocksExample.java file
[x] Generate tests with different Mocking options combinations

Regression checks
Collect too complex reflection in tests
Add a class / package  - generate / generate and run tests for class / method / class - check tests

[ ] Installed on 2022.1.4  - Gradle project
[x] Installed on 2022.2.4  - Gradle project
[ ] Installed on 2022.1.4  - Maven project
[x] Installed on 2022.2.4  - Maven project
[ ] Installed on 2022.1.4  - IntelliJ project
[x] Installed on 2022.2.4  - IntelliJ project

Add a class / package  - generate tests for class / method / class

[x] Gradle  - existing test sources root - No mocks
[ ] Maven - existing test sources root - Mocks outside package
[ ] Maven - new test sources root - Mocks outside class
[ ] IntelliJ  - new test sources root  -  Mocks outside class - Mock static methods

Add a class / package  - generate tests for class / method / class

[x] JDK 8  - JUnit 5 - Parametrized
[ ] JDK 8 - JUnit 4 - Parametrized off
[x] JDK 8 - TestNG - Parametrized off
[x] JDK 11 - JUnit 5 - Parametrized
[ ] JDK 11 - JUnit 4 - Parametrized off
[x] JDK 11 - TestNG - Parametrized
[ ] JDK 17 - JUnit 5 - Parametrized
[ ] JDK 17 - JUnit 4 - Parametrized off
[ ] JDK 17 - TestNG - Parametrized off

UI checks - in a project with JDK 11

[ ] timeout changes - 1/10/60 sec - check with stopwatch
[ ] cancellation - check on different steps
[x] regions: Symbolic first, Fuzzing,
[ ] regions: error suite (NPE), explicitly thrown exceptions, caught exceptions (successful)
[ ] exceptions - check Problems tab
[x] context menu / shortcut
[x] call from method / class / package - check Members list
[ ] call for several classes - Generate and Run - check all test classes are run

Check Settings - in a project with JDK 17

[ ] Symbolic 100%
[ ] Symbolic 95%
[ ] Symbolic  5%
[ ] Fuzzing 100%
[ ] Summaries with custom tags - check all tags
[ ] Summaries with plain text - check for Fuzzing
[ ] Summaries turned off
[ ] Tests with exceptions: Fail
[ ] Tests with exceptions: Pass
[ ] Overflow : Ignore overflows
[ ] Overflow: Treat overflows as errors

Other features testing

[ ] Strings
[ ] Mocks
[ ] Collections
[x] IDEA Community 2022.2.4 smoke test

Bugs found:

#1588


Custom Button Background Not Loading (1.7.10)

I am trying to put together a mod pack, however, when loading the button background, it displays a missing texture...I can't provide a console log due to the launcher crashing, however, a screenshot of the code and folder hierarchy is below:

Image ingame:

I'm having the same problem but do you have resource loader?


RFC: Deprecate or fix old/broken DefaultDict constructors

Dict and OrderedDict constructors have changed, and
DefaultDict/DefaultOrderedDict haven't kept up.

The changes:
Dict(KeyType, ValType) => Dict{KeyType, ValType}()
Dict(ks, vs) is deprectated

This deprecates working versions of these from DefaultDict
and friends, and fixes broken calls which attempt to
use these old constructors.

Current coverage is 92.45% (diff: 66.66%)

Merging #233 into master will increase coverage by 0.23%

@@             master       #233   diff @@
==========================================
  Files            29         29
  Lines          2351       2346     -5
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           2168       2169     +1
+ Misses          183        177     -6
  Partials          0          0

Powered by Codecov. Last update af2c97e...7ad7b74

This PR should be ready for review.
The functional changes shouldn't be controversial (just updating the interfaces), but a quick review would still be welcome.
For the deprecated functions, I arbitrarily assigned a Julia version in which to remove the deprecations.  Any thoughts (👍  or 👎 ) would be welcome.

Everything passes.  Will merge tomorrow if there are no comments.

should mostly just be adding a yml file to enable appveyor, though may need to manually set the webhook if something goes wrong with enabling the repo from the appveyor ui.

LGTM

Thanks @rawls238


Cleaning proj review

Purpose/implementation Section
What changes are being implemented in this Pull Request?
Just small changes for project 3 for formatting and clarity.
What was your approach?
added some new lines so that the quote for the question wasn't overlapping the capital I at the beginning. Added the Kaggle link and simplified a few sentences. Also it used to say "this file" in the objectives... so I changed that.
What GitHub issue does your pull request address?
NA

appears to be some broken urls in other places

I have the URL fixes in #24


How to generate RSA EVP_PKEY using new APIs

I'm new to OpenSSL and we have a C++ project which uses OpenSSL 1.1.1. Below is the code to generate EVP_PKEY in OpenSSL 1.1.1. Most of these APIs are deprecated in OpenSSL 3.0.0. I would need help here on "How can I achieve similar functionality using new (non-deprecated) APIs?" A sample code would go long way here.
//Error handling (null check etc.) are missing

void CreatePKey(uint32_t bits) {
  EVP_PKEY *pkey = NULL;
  RSA *rsa = NULL;
  BIGNUM *f4 = NULL;

  // Allocate private key structure
  pkey = EVP_PKEY_new();

  // Allocate and intialize big number
  f4 = BN_new();

  BN_set_word(f4, RSA_F4);

   // alocate RSA struct
   rsa = RSA_new();

  RSA_generate_key_ex(rsa, static_cast<int>(bits), f4, NULL);

  EVP_PKEY_assign_RSA(pkey, rsa);
}

The simplest way is to use EVP_RSA_gen:
EVP_PKEY *pkey = EVP_RSA_gen(bits);

You can't specify the exponent through this route (you would need to use the EVP_PKEY_keygen API for that). But RSA_F4 is the default anyway.
https://www.openssl.org/docs/manmaster/man3/EVP_RSA_gen.html

Thanks. Closing the issue


List for list items and css fix for Chrome Canary

fixes #88 and #92

Hey @sillero,
2-in-1! Thank you so much, this looks great. Would you mind reverting your changes to the build/ directly so I can do a build and release separately?

done :)

Thanks again - much appreciated 🌟


Fehler im QR-Code bei einer Bestimmten Zeichenanzahl

Hallo,
ich glaube, das ich einen Bug gefunden habe. Ich versuche einen QR-Code für folgenden Text zu generieren:
[#P-BOF#]
XX
XXX
XXXXXXXXX
Test-Text
XXXXXXXXXXXXX
$XX=<IP_ADDRESS>
$XX=<IP_ADDRESS>
$XX=
$XX1=16
$XX2=16
$XX3=16
$XX4=16
$YY1=ON
$YY2=OFF
$YY3=ON
$YY4=OFF
$ZZ1=16
$ZZ2=16
$ZZ3=16
$ZZ4=16
$AA1=B
$AA2=B
$AA3=B
$AA4=B
$VID1=1
$VID2=1
$VID3=1
$VID4=1
$VID5=1
[#EOF#]
Generiert habe ich den QR-Code mit folgendem Code:
Encoding iso = Encoding.GetEncoding("ISO-8859-1");
Encoding utf8 = Encoding.UTF8;

QRCodeGenerator qrGenerator = new QRCodeGenerator();
QRCodeData qrCodeData = qrGenerator.CreateQrCode(iso.GetString(utf8.GetBytes(Text)), QRCodeGenerator.ECCLevel.L);
QRCode qrCode = new QRCode(qrCodeData);
Bitmap qrCodeImage = qrCode.GetGraphic(5);

Der so erzeugte QR-Code kann nicht gelesen werden (Versuch mit mehreren Apps und Betriebssystemen (IOS, Androdi). Wenn ich nur einen Buchstaben hinzufüge, oder entferne z.B. von meinem Test-Text, funktioniert der Barcode wieder sofort.
Ändere ich im Code den "PixelPerModule"-Wert von 5 auf z.B: 6 , bleibt der Fehler,
Ändere ich das ECCLevel von "L" auf "M" funktioniert der QR-Code auch, nur genau bei meinen Einstellungen tritt der Fehler auf.
Hoffe der Bug kann auch bei dir reproduziert werden.

Hi @Bratmaxe1981 ,
if it's ok for you, I'll switch over to english, because other users get the chance to take part on the discussion. If that's not ok for you, let me know, then I'll switch back to german.
At first, what are you trying to do by Encoding your string to Utf-8 and back to ISO-8859-1? Normally you don't have to do that, because the QrCoder has an automatic check for Encoding. If possible it will decode in ISO-8859-1 otherwise in UTF-8...
The "PixelPerModule"-value doesn't really has an impact on the decoding. It only says how big the blocks should be drawn, but it doesn't change how data is encoded. This value could only be to small for your camera, so that it can't recognize the blicks, but 5 px should be big enough for most readers/cameras.
Now let's come to your problem. I tried what you said and can see your problems partly.
When I encode your text with encoding level m everything works fine with every reader I tested.
When I encode it with encoding level L, I get problems, but only with some readers.

https://www.codetwo.de/freeware/qr-code-desktop-reader/  -->  can#t read the code
https://play.google.com/store/apps/details?id=com.google.zxing.client.android&hl=de --> can read the code
http://qrlogo.kaarposoft.dk/qrdecode.html --> can read the code and in addition, says that there are no errors. (Check the "debug log" checkbox.)

So it's hard to say if the error is in QrCoder library or maybe in the decoder engines of the other QrCode readers...

Hi codebude,
ok I'll try it in english.
I think it is a bug in the QrCoder because if I change the Qualitylevel I can read it with every reader.
I have always expected to get the same result with the same text input, even if I change the Quality Level.
Please try this one. I can't read it with the Android App above:
http://www.bilder-upload.eu/upload/cc4dd8-1491481977.png
Sometimes the App read the QR-Code, but the result is only a number (192586) not the text.
Thanks and greetings from Willich

Hi @Bratmaxe1981 ,
ok, the code you linked to in your last post seems to be defective. I can't decode it with any of my decoders. Could you please post:

the value/text you have encoded
the ECC Level you have used
any other parameters you have set

The I'll try to find some time to start a debugging session, because right now I have no idea what's going wrong.
Kind regards and greetings from Meerbusch ;-)

Hi,
this is the Text I tried to encode:
[#P-BOF#]\nXX\nXXX\nXXXXXXXXX\nTest-Text\nXXXXXXXXXXXXX\n$XX=<IP_ADDRESS>\n$XX=<IP_ADDRESS>\n$XX=\n$XX1=16\n$XX2=16\n$XX3=16\n$XX4=16\n$YY1=ON\n$YY2=OFF\n$YY3=ON\n$YY4=OFF\n$ZZ1=16\n$ZZ2=16\n$ZZ3=16\n$ZZ4=16\n$AA1=B\n$AA2=B\n$AA3=B\n$AA4=B\n$VID1=1\n$VID2=1\n$VID3=1\n$VID4=1\n$VID5=1\n[#EOF#]
But I also found a bug in my function, but it shouldn't have to do anything with this bug.
(I have programmed a function that should delete all spaces in the text, but in this function I also delete all "/r" in the text (after each value). Is there a character limit per line witch I exceeded?

I tried again. When I run the code you posted above, with your value, I get a QrCode which works without problems. But after having a closer look to the QR code image, it looks in most points similiar, but with slightly differences. So I'm confused. Why do I get another Qr Code image (compared to the one you posted above) than you, while running the same code...

Could it be when he reads this data in, the /n are omitted?

@Hydroque when "who" reads? QrCoder when parsing the payload or the respective QrCode reader apps? For QrCoder I can say that the \n will be read and parsed. I checked that by debugging as also by scanning the generated code in ECC level L. (Like I said, some readers can read the code and the QrCode debugger doesn't give any errors.)

For example, reading the data separated by \r\n, "read by line" when concatenating that string above, it could omit these.


 If you don't have state showing they appear identical to available entities.
I think the best visual indicator would be to have the entire card greyed out? Perhaps an "unavailable" icon option, and/or grey out the icons.

I guess on mobile is not clear enough, on desktop the cursor changes on hover.

Improvement for unavailable enttity:


Use pytest style in all tests

Nice, I like pytest and those bare asserts. self.AssertEqual etc is such overkill syntactically, when assert exists inherently for test-like purposes @hukkinj1 @jpwood

Agree. Pytest is a bit quirky in some ways, but the unittest stdlib is like writing Java :D


Update max width of email body to 600px to improve readability

I think the 400px max-width setting is a little bit too small. It looks great on mobile, but on full desktop experience, the reading area is tiny. This PR updates it to 600px.
Screenshot of what 400px looked like for me:

👍 :shipit:


Clue scroll plugin highlights every matching GameObject.

For example:

Only 1 bookcase should be highlighted, but it selects them all.
Not sure exactly what information is required to fix this.
I'm assuming it needs to be fixed per step? If so, I can try and help grab Clue scroll ID and Coordinates of the GameObjects when I get these clues.

Yeah, the plugin should be improved to know the position of the object that it should mark.
I think the reason for it not being like that already is the coordinates not being at the objects, but through community effort we can fix that.

@devLotto What would be the best way to help / what information is needed?
Would having clue IDs and object coords be required?

Clue text + object coordinates (from developer tools plugin)
Clue scroll item ID is only needed for map clues


Implemented the Mergesort algorithm and renamed the AllSortingAlgorithms.cpp file

Implemented the merge sort algorithm in CPP folder
Renamed the AllSortingAlgorithms.cpp file to AllSearchingAlgorithms.cpp file, because I think it is implementing all searching functions only

Fixes #67

https://user-images.githubusercontent.com/43691873/135965000-a3019b12-c089-4a61-bae3-81f915ec39a5.png
Pls read the readme file again. Your PR will be excluded by system. Pls submit genuine PR.

Can I submit a leetcode question? If not, then what can be counted as a genuine PR for a newbie like me?


chore(release): release readiness

When we are ready we can switch publish to true in the release-it config and merge this is - it should handle the rest from there!

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Reduce HTTP/2 allocations

Remove per request allocations on the thread pool by implementing IThreadPoolWorkItem on Http2Stream
Made generic version of Http2Stream to store the IHttpApplication instead of using a tuple

cc @benaadams
PS: I can't run much locally, so the CI will tell me if it doesn't work 😄

Metrics?

Less allocations 😬. Honestly though I don’t have a good way to build this locally. I’ll try again but this change is better generally. Even if throughout doesn’t change.

I’ll try running something.

Also dotMemory is broken with the latest .NET Core ci builds https://github.com/dotnet/coreclr/issues/21559

Gimme a sign off bros! I tried to use Perfview but I can’t read allocations in that thing
cc @sebastienros

Honestly though I don’t have a good way to build this locally

You should add that you are in a place where internet is limited and downloading the artifacts from the CI under VPN is slow.
I will run the benchmarks for you then. I have access to the CI.

If running these benchmarks works. I'd love to show before and after allocations as well but that can wait I guess.

If anyone has advice on how to best analyze allocations using perfview, I'm interested. I got the following using the "DotNetAlloc" flag.
Before

After

It shows the JIT_ClassInitDymamicClass and JIT_New events are now longer emitted during StartStream() which is a good sign. There's still a JIT_NewArray1 remaining. I loaded symbols after taking the screenshots to confirm this is from resizing the _streams Dictionary.
I don't really know what the Inc/Exc %/Ct columns mean in the context of the "GC Heap Net Mem Stacks" view.


Flutter Segment: Missing Icon replaced with literal string

As of now (10/24/2022), Nerd fonts never updates their list of fonts from a set of vendors. Currently, as per investigation of the nf-dev-* from their cheat sheet, only the dart icon exists (E798 or \uE798).
If the flutter icon exists, let me know (by tagging me on this issue through comments) and I will implement it right away, because I myself, am also annoyed by this bandaid solution.
For more information on how it is displayed as of now, look at the figures below. Suggestions are welcomed.
No version variant

Version detected variant

Moved to #2, closed.


Carthage issue building the first time

Wouldn't build on my machine, with unhelpful NSInternalInconsistencyException error when running carthage update --platform iOS step.
Tracked it down, and for some reason Carthage was pulling the wrong version of the Watson ios-sdk.  Changed Cartfile to this, and it fixed the build process:
# cartfile contents
github "watson-developer-cloud/ios-sdk" == 0.8.2

thanks, this should be up to date.


Parallel thread safety

https://github.com/pointfreeco/swift-prelude/blob/5d5005d0fc0c0292725054d005b6a4be9ad0ae0c/Sources/Prelude/Parallel.swift#L12-L22
The closure passed to self.compute which is responsible for writing to self.computed is called on an arbitrary queue, while reading from self.computed (accessing the cached value rather than recomputing) takes place on the private self.queue. Isn't this a threading issue?

Hi @klop! Thanks for the report. I think we haven't been sharing/executing the same Parallel, and we mainly deal with value types, so we just haven't encountered an issue. We'll be updating Parallel and IO with a barrier sometime soon.


az storage cors add returns no success status

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
az storage cors add command does not return json to indicate success, which is different to the majority of other az cli operations.
To Reproduce
az storage cors add ...
Expected behavior
Expect a json response to indicate success; ideally an object representing the added CORS rule.
Environment summary
Windows 10 2004 19041.329

azure-cli                          2.7.0

command-modules-nspkg              2.0.3
core                               2.7.0
nspkg                              3.0.4
telemetry                          1.0.4

Extensions:
application-insights               0.1.8
azure-devops                      0.18.0

Python location 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\python.exe'
Extensions directory 'C:\Users\tim\.azure\cliextensions'

Python (Windows) 3.6.6 (v3.6.6:4cf1f54eb7, Jun 27 2018, 02:47:15) [MSC v.1900 32 bit (Intel)

Additional context
Command is not idempotent - unsure whether duplicate CORS rules should be allowed?

add to S172

Hi @Tim-Hodge, thanks for your feedback. It is because there is no response in SDK design. In addtion, there is only SDK to get/list all cors in a storage account not specific cors properties.
Adding additional operations will increase the cost to maintain in CLI and it may cause breaking change for existing customers if we change the response.
Considering above concern and limited bandwidth, it is hard to add such support in current Azure CLI. To see if the add operation works, please use az storage cors list. In addition, it should mean success for each command when no error occurs.


Ability to try to delete all drivers (probably limit the selection to MS-signed only)

Could you add command-line option to silently remove drivers without asking "Y/N"

Will try to look into it this week, request itself is easy; I'd have to
restore .exe building scripts on my box, though.
Thanks,
Vasily
11 янв. 2016 г. 14:50 пользователь "dartraiden"<EMAIL_ADDRESS>написал:

Could you add command-line option to silently remove drivers without
asking "Y/N"
—
Reply to this email directly or view it on GitHub
https://github.com/JustAMan/pyWinClobber/issues/4#issuecomment-170518367
.


Update to Splunk 6.2.1.

Updated to Splunk 6.2.1
Update copyright email
Update test harness

:+1:


python310Packages.ssh-mitm: 2.0.1 -> 2.0.2

Description of changes
https://github.com/ssh-mitm/ssh-mitm/releases/tag/2.0.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 173931 run on x86_64-linux 1

2 packages built:

python310Packages.ssh-mitm
ssh-mitm (python39Packages.ssh-mitm)


Update svg-sprites.svg syntax

I feel like the svg-sprites.svg file could do with a syntax update.  Chris Coyier wrote a really good article about the syntax called SVG symbol a Good Choice for Icons.  In it he describes this pattern for the svg sprite file:
<svg xmlns="http://www.w3.org/2000/svg" style="display: none;">
  <symbol id="fa-glass" viewBox="0 0 1792 1792"><path d="..."></symbol>
  ...
  <symbol id="fa-medium" viewBox="0 0 1792 1792"><path d="..."></symbol>
</svg>

Reasons:
As Chris points out, there are some very good reasons for going with this markup style.

It could open the doors for some really great accessibility (with the <title> and <desc> tags)
The viewBox attribute should make consistent sizing very easy.
"This is probably what <symbol> was invented for anyway."

I get that this will increase the file size (because of repetition over 519 icons), but GZIP eats this kind of character repetition for breakfast, so the performance hit shouldn't be all that severe.

Alternatively, all the <paths> could be wrapped inside a <defs> tag, which should hide things properly, and the <svg> itself could just be set to display: none;.  Like so:
<svg xmlns="http://www.w3.org/2000/svg" style="display: none;">
  <defs>
    <path id="fa-glass" d="...">
    ...
    <path id="fa-medium" d="...">
  </defs>
</svg>

So I've implemented this in by forked branch if you want it. Great suggestion. The icons show up more consistently centered and sized
https://github.com/nikgavalas/Font-Awesome-SVG-PNG

@nikgavalas Nice work!  Would it affect #29 at all?

@nikgavalas Could you do a PR?

@nikgavalas @Rush Did this ever move?


Did something change when registering health checks in preview3?

In preview1, I could register health checks like this:
services.AddHealthChecks();
services.AddSingleton<IHealthCheck, MyHealthCheck>();

In preview3, my health check is no longer created and executed when requesting the health endpoint. Did something change?

Thanks for contacting us, @ThomasArdal.
@rynowak, all yours to answer.

Yes. We don't register the health checks directly in DI anymore. This turned out to be too limiting in a variety of ways.
Use services.AddHealthChecks().AddCheck<MyHealthCheck>("myname")  if you don't care about lifetimes
or if you do want to enforce a singleton lifetime:
services.AddHealthChecks().AddCheck<MyHealthCheck>("myname");
services.AddSingleton<MyHealthCheck>();


Can't drop files into webccord

Acknowledgements

[X] I have checked that there is no other issue describing the same or
similar problem that I currently have, regardless if it has been
closed or open.

[ ] This bug affects Discord website.

[X] This issue is confirmed to be reproducible when WebCord is packaged
on at least all three latest supported Electron major releases.

[ ] This issue is reproducible in Chrome, Chromium or any
Chromium-based browser, e.g Brave or Edge (please write in
Additional Context which browser you have used if it is neither
Chrome nor unmodified Chromium).

[X] There are no fixes done to master which resolves this issue.

[ ] My issue describes one of the unstable and/or not fully implemented
features.

[ ] I have found a workaround to mitigate or temporarily fix this issue
in affected releases (please write it in Additional context section
below).

Operating System / Platform
🐧 Linux
Operating system architecture
x64 (64-bit Intel/AMD)
Electron version
25.6.0
Application version
4.4.0
Bug description
I can't drop files into any chat
Additional context
No response

Most likely a duplicate of #371, #435, and #459, unless you have original CSP settings (i.e. everything toggled on).

I have all in default and i can upload media but i can't drag and drop anything

Can confirm that I also have this issue, some UI elements become unresponsive when I try to drag and drop files into a chat (cant switch channels, cant type in the chatbar). If switch server it resets and becomes responsive again.

Cannot reproduce it on my end though, at least on Electron 26…
What packaging method are you using @neondeex? Also @crabreader are you on the same major version of Electron (i.e. 25) or different?

I use the AUR version

@neondeex Also, are you on Wayland, XWayland or X11?

I use the AUR version

I've tested the build (webcord) from chaotic-aur, things are OK with that…
Also, did you double-checked that Google Storage isn't being disabled for sure in WebCord's settings?

I use electron from the arch extra repository, it seems to be version 25. When I tried to install electron 26 I was unable to make webcord run using that version, I don't know how to build webcord with a specific version of electron.
Also it might be of note that I am using wayland with a nvidia graphics card.

My issue appears to be related to xwayland, I managed to build webcord with electron26 but I didnt realize that it runs under xwayland. I get an error like this when I attempt to drag a file:
[82368:0912/175748.813949:ERROR:x11_drag_context.cc(150)] XConvertSelection failed for source-advertised target 540

My issue appears to be related to xwayland, (...)

@crabreader What about running app in Wayland (--ozone-platform-hint=auto or --ozone-platform=wayland)?

@SpacingBat3 Can confirm that it works when i run webcord with that flag, but I also need to use --disable-gpu for it to launch. I don't know if that can lead into other problems.

I can reproduce this on X11 using the Flatpak.
Using the + button and manually picking the file instead of drag&drop works fine.

I can reproduce this on X11 using the Flatpak.
Using the + button and manually picking the file instead of drag&drop works fine.

@dreamsyntax That one is actually a problem specific to Flatpaks (or Electron, if there's any app actually functional with drag&drop packaged as Flatpak?) since there's sandboxing going on and it is very likely that drag and drop doesn't work via portals like when adding a file via native dialogs.

I have been having this problem as well. However, I have this issue using Discord (Arch-packaged) Chromium as well. So it might be a Chromium bug. I'm not sure it is a problem with WebCord, as it happens in default Discord as well.
For reference, I am using a wlroots compositor, specifically Hyprland. It would be interesting to see if the issue is related to that.

(…) I'm not sure it is a problem with WebCord, as it happens in default Discord as well.

It definitely isn't. But I'll track it here. I doubt I can do anything to fix it, it sounds to be highly specific to Wayland and given I don't use a Wayland-based DE nor Chromium is supporting it as a stable, it is unlikely I'll came with some workaround. Possibly reporting this to upstream (i.e. to Chromium or Electron devs) is what should be done.

Oh, just confirmed that --ozone-platform=wayland works for me on both Discord and WebCord, along with Discord in Chromium. I thought I had already done it before, but actually hadn't done it properly: kill all Discord/Webcord/Electron instances before relaunching, otherwise it will run on Xwayland which seems to be the cause of the broken drag-and-drop. Make sure the window does not open as Xwayland and it should work fine.


Blunt damage should have a chance to deconvert revolutionaries

Gives the crew a way to still fight the revs if cargo has already fallen, it’s also pretty funny to repeatedly whack someone over the head with a toolbox to fix their brain.

It should have to be a lot of blunt at once, or only apply while incapacitated, just doesn't sound fun happening in the middle of a fight

it should need to be in crit thoughever

go to concussion jail

Aren't mind shield implants supposed to bring people out of hypnosis?  It will just be much more logical there than brute damage...

In addition, if you give a couple of implanters to the captain in the locker from the start of the round, then there will be fewer problems with turnover.  In addition, the price of the implant was reduced from 5k to 3k.

armory makes more sense

just have to map it


Unclear how to require that only authenticated users can edit

Examples who how to limit access only to a predefined set of users. But how could I allow everyone to see the content, but only authenticated users could edit documents?

I also need a more secure solution than the already implemented.
The main problem is, that the ShareJS model callbacks have no access to Meteor.userId() on the server, therefore this approach fails. Meteor.userId() is only available in Meteor methods. This makes it insecure, because one need to trust the client code.
So far I thought about a meteor method, which is called before an shareJS connection is generated.  This method should check the access rights of the user and returns a token, which is stored in a server site collection. I addition to the token the userId and the docId should be stored.
On the client side this token is send with each shareJS operation. Then this token is checked on the Server side if it is available in the collection and if it corresponds to the correct document. It is then also possible to get the user and make further validation checks.
I am willing to implement this kind of authorisation, if there is an general interest. However I am unsure how to add it to this package.
Especially the auth function, which is executed on the server. What would be the best approach to let users of the package implement their own auth functions?


Do you have the model?

Hello. If possible, please could I get a download for the model? It's not inside the file

Yep, use the step file in the root directory.

Thank you. I didn’t see that before.
From: Constantino<EMAIL_ADDRESS>Sent: 30 April 2020 18:18
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [ConstantinoSchillebeeckx/cherry-mx-switch] Do you have the model? (#1)
Yep, use the step filehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FConstantinoSchillebeeckx%2Fcherry-mx-switch%2Fblob%2Fmaster%2Fswitch.step&data=02|01||3e610915316e4866827508d7ed2a7d1f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637238639043782263&sdata=wykownlq8lciGSCIbjViRQ2MALlrEeAnqWXQv9wCZiU%3D&reserved=0 in the root directory.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FConstantinoSchillebeeckx%2Fcherry-mx-switch%2Fissues%2F1%23issuecomment-621989303&data=02|01||3e610915316e4866827508d7ed2a7d1f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637238639043792245&sdata=%2BbZcmIQ%2F6R2EjZ9KeL4HNszr75HjhVFXXOpcqkYLksw%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAO45D72YOMKTTWDJC3HT3WTRPGXF5ANCNFSM4MVX2HHA&data=02|01||3e610915316e4866827508d7ed2a7d1f|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637238639043802229&sdata=Zp%2FL1CU6dyoLJCfQRu1w1B%2FxfzxlaDnafNcsNKlmKMU%3D&reserved=0.


WIP: Fixes golangci-lint findings

Description
Fixes for the golangci-lint findings.
So far I've fixed most of the findings, but in some cases fixing the golangci-lint findings breaks the tests.
General remarks:

many functions started as goroutines have return a value - As the value cannot be checked I've added errcheck ignore
cmd/forwarder-agent/app/forwarder_agent_test.go:429 Error return value of grpcServer.Serve is not checked
G108: Profiling endpoint is automatically exposed on /debug/pprof (gosec) _ "net/http/pprof" - errcheck ignore
G402: TLS InsecureSkipVerify set true. (gosec) in some tests when creating tlsconfig - errcheck ignore as it is in the tests
I suppose, some test fail when adding error checks because of improper initialization or no proper mocking in some parts.

Specific remarks per file:

pkg/egress/v2/helheim_test.go - too many unused functions

pkg/egress/syslog/rfc5424.go - one unused function

pkg/egress/syslog/retry_writer_test.go:136:2: field binding is unused (unused)
binding       *syslog.URLBinding

pkg/egress/v1/message_aggregator.go:68:17: Error return value of io.WriteString is not checked (errcheck)
io.WriteString(vHash, element.v) - Should and empty string be returned  in case of an error?

pkg/egress/v1/message_aggregator.go:4:2: G505: Blocklisted import crypto/sha1: weak cryptographic primitive (gosec)
"crypto/sha1" - I've exchanged sha1 with sha256

 pkg/clientpool/v1/conn_manager_test.go:67 and pkg/clientpool/v2/conn_manager_test.go:96 - When adding the error check, the test fails. Write() returns an error

err := connManager.Write([]*loggregator_v2.Envelope{e})
Expect(err).To(Succeed())

cmd/forwarder-agent/app/forwarder_agent.go:168 return on first error or do best effort and return error if one write failed?

pkg/ingress/v2/receiver_test.go:425 checking the errors shows that the errors are not nil. I guess there is something wrong in the test initialization or the mocks?

I've open this PR to start a discussion on how to proceed in order to fix the rest of  golangci-lint finding and the broken tests.
For the time being the PR consists of multiple PRs which at the end will be possibly squashed to one single commit.
Fixes: #125
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Testing performed?

[x] Unit tests
[ ] Integration tests
[ ] Acceptance tests

Checklist:

[x] This PR is being made against the main branch, or relevant version branch
[ ] I have made corresponding changes to the documentation
[ ] I have added testing for my changes

Superseded by #106. Thanks @chombium !