Infinite loading when navigating to a chat without access

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Log in to NewDot
From another app, click on the URL with the conversation ID to any combination of 1-4 numbers. E.g https://staging.new.expensify.com/r/1234
Verify You see a You don't have access to this chat message in the conversation history
Repeat with non-valid conversation ID (e..g, staging.new.expensify.com/r/sometxt)

Expected Result:
User should be redirected to "Hmmm.. it's not here" page

Actual Result:
Infinite loading when navigating to a chat without access -  "Hmmm.. it's not here" page is never displayed
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[X] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[X] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.15-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: 2 test cases are failing because of this issue:

Navigate to Chat without access (Valid and non valid ID)
Web/mWeb - Navigate to IOU via link

Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/44479856/477bf7ea-35d9-4aa5-90b7-4c4cf5c7da5e
Expensify/Expensify Issue URL: N/A
Issue reported by: Applause - Internal team
Slack conversation: N/A
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Hmmm looks like it could be a backend issue, will investigate internally

Looks like it was caused by https://github.com/Expensify/App/pull/19056, reverting the PR

CPing a fix for this now, all good!

Retested on staging and this is fixed, closing


Parameter parsing problems during casts in postgres

Continuing from https://github.com/gk-brown/HTTP-RPC/issues/90
What if there is a use case to cast something
eg: SELECT '2019-01-01'::date

This is done.

Awesome. Thanks!
On Sat, 9 Mar 2019 at 6:14 PM, Greg Brown<EMAIL_ADDRESS>wrote:

This is done.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gk-brown/HTTP-RPC/issues/91#issuecomment-471173977,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA8Va_08br1D7voHb50XTpuWLqjpmlCIks5vU6zBgaJpZM4bh5Hc
.


Closes: #1 Fix a bug in validations.py

The Regex pattern was updated to detect a valid username. As a result, the condition checking for a username that shouldn't start with a number was removed.
Fixes #<1>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

I have filled out the CLA form and used my email and username in Git exactly as they appear on my GitHub account. However, the status shows as 'Failing'.
Could it be because I used Pascalcase for my username in Git (git config --global user. name "MrkTheCoder"), just like my GitHub ID?"
Also, I tried this link again: https://cla.developers.google.com/ and hit the I AGREE button. Now it shows me this message:

Your CLA signature could not be read; please reach out to your contact Googler.

What should I do!?


Force close with LSP

Steps to reproduce:

Initiate swap to lightning to LSP
Immediately force close app after the success screen
Wait 10 seconds
Reopen app
Channel should be force closed

Probably a CLN bug, just documenting here

The temp solution to this was to make the channel open flow wait one second before returning but a longer term fix is going to be by being reactive to the EventManager.
https://github.com/MutinyWallet/mutiny-node/issues/594


In night mode the text in the buttons aren't visible

When you use an example as shown in https://newcss.net/usage/elements/:
<a href="https://example.com">
  <button>Click me!</button>
</a>

The text in the buttons are the same color as background in night mode.

Hi, check here: https://github.com/xz/new.css/issues/52#issue-719381738


AppRemoting: DisconnectReason not getting reported

We are using the AppRemoting.StartConnectingToPlayer to connect Unity to Hololens but when there is an error the AppRemoting.Disconnecting always reports DisconnectReason.None.
I believe the issue is that AppRemotingSubsystem.OnSessionLossPending calls TryGetConnectionState and thus "consumes" the disconnect reason, so when later the AppRemotingSubsystem.ConnectRoutine calls TryGetConnectionState it doesn't get the reason.
I have verified this with a debugger. The AppRemotingSubsystem.OnSessionLossPending does get the correct disconnect reason.

Thanks for reporting.  I'm pinging back to the feature team to investigate this issue.

Hi @zenorbi,
Unfortunately, I am unable to repro this issue on the latest BasicSample in this repo. Can you provide more details on what kind of error you are referring to before disconnecting?
Also, I am not sure how using "TryGetConnectionState" twice will hinder getting disconnecting reason. Could you please share some Unity Player Log for us to debug further?

Hi @satyapoojasama,
Thank you for looking into this. I cloned this repo and opened the RemotingSample project in Unity 2020.3.43f1 as indicated by the ProjectVersion.txt. All I did is that I added Debug.Log($"DISCONNECT REASON: {disconnectReason}"); to this method: https://github.com/microsoft/OpenXR-Unity-MixedReality-Samples/blob/666f809b418b8c84fd17e5d00589708c014d76a6/SampleShared/Samples/AppRemoting/Scripts/AppRemotingSample.cs#L234
I then entered play mode and tried to connect to an unused IP address. The log I received was:
DISCONNECT REASON: None

Editor.log
I would expect a HandshakeUnreachable, the same as what the AppRemotingSubsystem receives.

Interestingly if I build this project, I never even receive an OnDisconnecting callback in the player.

Here is a video where I reproduce this issue on a fresh git clone:
https://github.com/microsoft/OpenXR-Unity-MixedReality-Samples/assets/313625/451c3d9a-07c6-443f-9175-9fa79d57bc1e

Hi @zenorbi , we fixed this issue and it will be available in the next release of our plugin. Thank you.

1.9 release is now out. Please update to get the fix for this bug.


Please describe the scenario about federation between MS Teams and pure on-prem Lync/SfB.

Currently, the federation connection is successful between MS Teams and pure on-prem SfB/Lync. MS Teams teant does not need hybrid configuration. Please update this article if it is officially supported.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59900927-5e5f-77a4-04be-e05a91330fca
Version Independent ID: 1e4d6b87-f57c-fa45-1630-3c32b821d93c
Content: Manage external access (federation) in Microsoft Teams
Content Source: Teams/manage-external-access.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@lyncjp Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

Hi,
My name is Lerato, I’m from South Africa. I seem to have a problem with my MS teams account, every time I try to make a call externally teams won’t allow me to. Video calling those on the same domain is not a problem only people outside my domain. The only method available for video calling external participants is to create an outlook teams meeting. External access is enabled... I would like to know if there is a way I can make (meet now) videos calls?
Your help would be highly appreciated.

@lyncjp Thank you for reaching out and helping improve MS Docs.  Everything that is not directly mentioned in this article is not supported, but please let me know if you have found an error/change where the article needs to be updated. Any help will be appreciated.

Does that mean federation between an organsiation that SFB on-premises and an organisation that is Teams only is not supported?  I can't see it listed on this page.

@lyncjp We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


Swift 1.2 compatibility

I'd like to bump the version number for Runes to 1.2 in order to be able
to offer pre-built binaries that work with Swift 1.2. There aren't any
source code changes, so this won't affect people building directly
(CocoaPods or Submodules), but it will make versioning easier in
libraries that want to use Carthage and work in Swift 1.2

To clarify:
Carthage uses xcodebuild under the covers, so in order to build for Swift 1.2 you need to make sure that you use xcode-select to change the version of Xcode that Carthage is using. This is kind of annoying, especially if you are jumping back and forth between projects that use Swift 1.2 and Swift 1.1. With a new 1.2 release, we could simply build our binaries with Swift 1.2 going forward and have a simple release to version projects off of.


Flasgger -> FastAPI

Flasgger, unfortunately, does not seem to be compatible with most recent versions of Python.
We could simply use FastAPI to set up our API, and keep Flask later as a back supporting our front version.

Use Pydantic to modelize response object and eventual body inputs.


Allow send key classes to use pk instead of bin

Added functionality to allow the record key to be stored in the database key field rather than requiring an explicit bin.

@tim-aero
Did the Java Object Mapper support key as a bin previously to this change?
PK (stored in the record's metadata) is definitely the way to go which btw aligns with our Spring Data Aerospike implementation.
Should we even keep the previous "key as bin" approach? is it done only for backward compatibility? if so we can maybe mark "key as bin" as deprecated with warning of use PK instead and remove this flag in later versions (In Spring Data Aerospike we had the same problem and we removed the "key as bin" without deprecation but it's not ideal from backward perspective)
Do we use this "key as bin" when reading a record? (to map to the POJO?) - we can try map it from the PK if exists and if not from the "key as bin" that way we can support reads for both approaches (in case we will change it to PK without supporting "key as bin" and still being able to read the old records).
WDYT?

Thanks Roi.
Prior to this change, the object mapper would always store the key in a column, irrespective of whether sendKey was true or not. There are multiple situations where the key is used like:

loading deferred objects
using getters and setters for the primary key (for example making a compound key from multiple fields)
loading subordinate referenced objects, both lazily and normal.

I think we should tread carefully where the key is used, but I like the idea that if sendKey is true then only the PK should be used as the key by default. The new flags should stay in case there are situations where behavior doesn’t work correctly unless the key is explicitly stored in a column. For example, if some data is populated into the set by another application without sendKey = true and SI scans are required.
I don’t think there’s anything to deprecate though. We still need @AerospikeKey and this flag didn’t exist before. Maybe we document it as currently defaulting to false, but with the intention that it will change to default to true in the future, but only if “sendKey” is true.
Thoughts?
On Jun 16, 2024, at 02:10, Roi Menashe @.***> wrote:

@tim-aerohttps://github.com/tim-aero
Did the Java Object Mapper support key as a bin previously to this change?
PK (stored in the record's metadata) is definitely the way to go which btw aligns with our Spring Data Aerospike implementation.
Should we even keep the previous "key as bin" approach? is it done only for backward compatibility? if so we can maybe mark "key as bin" as deprecated with warning of use PK instead and remove this flag in later versions (In Spring Data Aerospike we had the same problem and we removed the "key as bin" without deprecation but it's not ideal from backward perspective)
Do we use this "key as bin" when reading a record? (to map to the POJO?) - we can try map it from the PK if exists and if not from the "key as bin" that way we can support reads for both approaches (in case we will change it to PK without supporting "key as bin" and still being able to read the old records).
WDYT?
—
Reply to this email directly, view it on GitHubhttps://github.com/aerospike/java-object-mapper/pull/160#issuecomment-2171182486, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABB63E4IYW3QZPNLXGO6OFTZHVB7RAVCNFSM6AAAAABJLCVCE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZRGE4DENBYGY.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

@tim-aero
Few things:

Refactored and cleaned up a bit so make sure you are pulling before making any change

We consulted internally within our team regarding the style of the new flag and we have a small suggestion:

Instead of storeInPkOnly, let’s reverse that and change to storeAsBin which by default will be set to true (in order not to break compatibility)
Add validation, in case sendKey is false (which is the default) then we want to prevent the user from writing with storeAsBin = false since we won’t be able to read and map the record back due to not having the original key (the same issue could be encountered in the existing proposal as well).

Hi Roi,
Yes, I like the storeAsBin option over the storeInPkOnly and agree that storeAsBin should default to true to match the current situation. However, there seem to be 3 scenarios we should consider:

storeAsBin is false -- In this case we use the PK only if sendKey is true, and throw an exception if sendKey is false
storeAsBin is true -- current behaviour
storeAsBin is not specified -- in this case it should default to the same value as sendKey

So I'm wondering if we should create an Enum like storeKey with values IN_PK and IN_BIN, with null allowing it to default to IN_PK if sendKey is true.
There is currently a check to see if storeInPkOnly == true && sendKey == false which will throw an exception if true.

@tfaulkes
I agree with (1) - which adds the validation we talked about, (2) - current behavior in case sendKey is false, if sendKey is true we will store the key in both PK and "key as bin" but I don't see (3) the same way as you, I think if storeAsBin isn't specified it's default should be true for now to align with the same behavior as we have now and not set to the current sendKey value (which in my opinion should be 2 completely unrelated options unless both are not set and then we should throw an exception as you mentioned).
I don't like the enum idea because sendKey option already exists as part of @AerospikeRecord, if it wasn't the case we could argue about the design and maybe even always set sendKey to true behind the scenes as we do in Spring Data Aerospike and keep storeAsBin optional with true as default (just to avoid breaking the compatibility), but since it isn't the case I would go with:

storeAsBin is false -- In this case we use the PK only if sendKey is true, and throw an exception if sendKey is false (same as you said).
storeAsBin is true -- current behaviour (in case sendKey is also true we will store the key both in PK and as a bin).
storeAsBin isn't specified -- default should be true (regardless of sendKey value) to align with the current behavior that doesn't include storeAsBin option but always writes the key in a bin.


Compat with OTG

Can you make REID compat with OTG

Looking back at this right now. Was a fix for this not merged into OTG in 2021?

no it wasn't and it never went through due to it have minor issues that I don't remember

for further contact see me in discord at HauntedPasta1#8200

it is imerged on a unofficial branch btw

https://github.com/PG85/OpenTerrainGenerator/pull/996

can you review this and see why f3 is giving out the incorrect biome

mystic i added u on discord, im confused as to how to fix this issue. what exactly do i have to do to get reid to work with otg and dregora


Use picocli for main cli

Complete outstanding port from commons-cli to piccolo.
Collapse admin-cli into config cli.

Codecov Report

Merging #946 into master will increase coverage by 0.06%.
The diff coverage is 99.17%.

@@             Coverage Diff              @@
##             master     #946      +/-   ##
============================================
+ Coverage     99.32%   99.39%   +0.06%
+ Complexity     2078     2048      -30
============================================
  Files           311      316       +5
  Lines          5778     5601     -177
  Branches        326      309      -17
============================================
- Hits           5739     5567     -172
  Misses            5        5
+ Partials         34       29       -5

Impacted Files
Coverage Δ
Complexity Δ

...orum/tessera/config/cli/admin/AdminCliAdapter.java
100% <ø> (ø)
4 <0> (?)

...a/config/cli/admin/subcommands/AddPeerCommand.java
100% <ø> (ø)
11 <0> (?)

...om/quorum/tessera/config/cli/KeyUpdateCommand.java
100% <100%> (ø)
18 <18> (?)

.../main/java/com/quorum/tessera/cli/CliDelegate.java
100% <100%> (ø)
5 <1> (-12)
:arrow_down:

...um/tessera/config/cli/KeyUpdateCommandFactory.java
100% <100%> (ø)
3 <3> (?)

...om/quorum/tessera/cli/parsers/ConfigConverter.java
100% <100%> (ø)
3 <0> (ø)
:arrow_down:

.../tessera/config/cli/NoTesseraCmdArgsException.java
100% <100%> (ø)
1 <1> (?)

...va/com/quorum/tessera/config/cli/OverrideUtil.java
100% <100%> (ø)
58 <0> (ø)
:arrow_down:

...om/quorum/tessera/config/cli/EncryptorOptions.java
100% <100%> (ø)
8 <8> (?)

...orum/tessera/config/cli/ArgonOptionsConverter.java
100% <100%> (ø)
3 <3> (?)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d445165...4c7ff1a. Read the comment docs.


Bad Request

Despite following the POSTMAN guide to the letter I always get an error back. I have the same issue when using other WSSE authentication libraries with these endpoints
{
    "error": "Bad Request",
    "error_description": "Invalid created timestamp (''). Values should be in ISO-8601 format",
    "error_uri": null
}

I've inspected the header and the created timestamp is the same format as that used by the API Explorer.

What does the Created timestamp look like in your x-wsse header? Here is an example of what my x-wsse header looks like when I make a request that works (PasswordDigest and Nonce omitted):
x-wsse:"UsernameToken Username="michrich:OBU Eng SC", PasswordDigest="************", Nonce="*************", Created="2018-05-14T15:56:54.877Z", Algorithm="SHA256""

Using pywsse my X-WSSE header looks like the following:
'X-WSSE': 'Username="User:Company", PasswordDigest="************", Nonce="**********", Created="2018-05-14T16:18:07Z"'`

I can't get Postman to even send!

What error are you getting when you try to send the request? You can see the Postman Console by going to View -> Show Postman Console

I'm not on windows or mac machine (on Chromebook) so using the Chrome App - is the console available there? I don't get the impression that the pre-request script is running as it doesn't seem to be populating the header key

Ah - it was be being a complete Postman newb - I needed to create an environment for the project and add x-wsse as a environmental variable. Got a valid response now!

@ohnosee - I just realized the guide did not include instructions to setup an environment. I've updated the guide. Thanks!

@alv1234 - I added a step to the doc about selecting the environment. Thanks!


How can we go about templatizing features files?

godog client.feature.tmpl

The above command does not work because godog only expects files with a .feature extension. We need to templatize features files in order to enable running the same set of godog tests across environments (eg. we want to use different dns names depending on where the tests are actually running).
My idea was to always work on a template when we develop a feature, then generate the actual features file based on the env and use that to run the tests. I guess the hard part with the above proposal is that by allowing files with any name to be used as features, the generation of the golang filename is complicated?

Hi, I can make a change for such cases to imply that the given arguments which are files, would be expected to be feature files no matter the extension. but the directories would still be scanned for files with .feature extension. If you would have these files located in directories, you'd need to run `godog $(find some/dir -name '.tmpl') so that files would be passed as arguments. Does it make sense?

@l3pp4rd yes, that makes sense. This is the minimum change we need 👍


Enhancement for Authentication using LDAP

a good thing to do is to disable password and username for LDAP

There is active property for that. LDAP management is not Serenity business.

oh sorry i thnk i was not clear , i ment that in serenity , once a user logedin useing Active directory , he can still go to his profile and change usr name and  add a apassword

Change password ok but i don't remember letting users change their usernames

check the adminstration page its the admin who can change the username :)

Admin can change this is not a problem, what if ldap username changes

heheheh yep  good point , and answer is for me is its AD admin problem :)


Text & image overlays are badly placed when the odyssey chapter list is open

Instead of moving the overlays (which would cause more problems), I decided to fix this issue like this:

Instead of moving the overlays (which would cause more problems), I decided to fix this issue like this:

/cc @javisantana, @saleiva

:es:

Sorry guys, but this doesn't work.
the chapters bars should 'push' the map to the right. Zoom controls and most of the overlays (titles and texts) are being placed on the left side, so we cannot do the odyssey lateral bar like it is right now.

@saleiva we took that decision because resizing the map implies lot of extra work. We can test with that approach and see if it works.
Basically the problem here: resizing the map changes the map viewport and that changes the visualization (embeds and so on) and overlays position

Ok to leave as it is for the tests, but we will need this ready for production.


Opponents

Introduce extra snakes to the game.

The player should be able to select the number of snakes in the beginning.
Opponent snakes will be controlled by the program.
Opponent snakes should all have the same color which should be different from that of the player's snake.
When a snake hits another, the hitter should die (in case of head-to-head collisions both should die).
There should be exactly one food at any instant in the game and all snakes should seek for it.

An initial prototype is implemented, but issues 3 and 4 still need to be addressed.

Issues 3 and 4 are addressed except that head-to-head collisions cause only one of the snakes to die.


final touches

favicon title
error modal
typo in decrypt success modal
remove refresh icon from decrypt form
style icon in header
change h1 font title

Completed in #21


Importing modules in blazor needs specific path prefix

The section "Blazor JavaScript isolation and object references" on https://docs.microsoft.com/en-us/aspnet/core/blazor/call-javascript-from-dotnet?view=aspnetcore-5.0#blazor-javascript-isolation-and-object-references describes how to import modules. The documentation is correct in using "./_content/MyComponents/exampleJsInterop.js" as the path. I think it should be highlighted that the prefix ./ is crucial here, as just "_content/MyComponents/exampleJsInterop.js" would not work.
Please consider adding a warning note to this section, highlighting the importance of the correct path specification.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aada0049-99a8-2f91-5d60-6970474e2371
Version Independent ID: c29fb1a8-028f-6efd-f1bc-e889fb362311
Content: Call JavaScript functions from .NET methods in ASP.NET Core Blazor
Content Source: aspnetcore/blazor/call-javascript-from-dotnet.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @stefanloerwald ... This bit was a cut-'n-paste from the release blog post at ...
https://devblogs.microsoft.com/aspnet/asp-net-core-updates-in-net-5-release-candidate-1/#blazor-javascript-isolation-and-object-references
... and I didn't :eyes: notice the delta there.
@captainsafia ... We normally don't require the relative path/current directory segment (./) for static assets. This is the only spot in the Blazor docs where we call for it. Is this a special case requirement? If so, why?
The example above with the segment is ...
var module = await js.InvokeAsync<IJSObjectReference>(
    "import", "./_content/MyComponents/exampleJsInterop.js");

I'd correct the text to match that with a reason along the lines of ...

Specify the module using its stable static web asset path: `./_content/{LIBRARY NAME}/{PATH UNDER WWWROOT}`.  The relative path segment for the current directory (`./`) is required because ... {WE SAY WHY HERE}.

Hello @stefanloerwald ... This bit was a cut-'n-paste from the release blog post at ...
https://devblogs.microsoft.com/aspnet/asp-net-core-updates-in-net-5-release-candidate-1/#blazor-javascript-isolation-and-object-references
... and I didn't :eyes: notice the delta there.
@captainsafia ... We normally don't require the relative path/current directory segment (./) for static assets. This is the only spot in the Blazor docs where we call for it. Is this a special case requirement? If so, why?
The example above with the segment is ...
var module = await js.InvokeAsync<IJSObjectReference>(
    "import", "./_content/MyComponents/exampleJsInterop.js");

I'd correct the text to match that with a reason along the lines of ...

Specify the module using its stable static web asset path: `./_content/{LIBRARY NAME}/{PATH UNDER WWWROOT}`.  The relative path segment for the current directory (`./`) is required because ... {WE SAY WHY HERE}.


Fix: application might segfault at exit

There is two bugs that sometimes caused a segfault when application exits :

The foreach loops on deletionPool, when deleting a view, might inserts other views inside the deletionPool set by calling Box destructor, resulting in undefined behavior. To avoid this, the set is can be replaced by a queue. I added required checks in addToFreeQueue to avoid queuing the same view twice.
AppletFrameItem destructor isn't checking if hintView is ptr locked before deletion. At application exit it sometimes caused hintView to be deleted twice causing a Segfault.

@ThisALV Could you please provide a demo code about how to trigger this deletionPool bug?
@XITRIX do you have any thoughts on that?

It seems like a quite reasonable fix, but it’s almost 2am and I need to sleep. Tomorrow I’ll try to review it properly

Looks like a really nice PR, could you please change this small things and will look perfect to me?

Looks like a really nice PR, could you please change this small things and will look perfect to me?

Sure, I'm not near my computer rn but I'll push a commit in a few hours

@ThisALV Could you please provide a demo code about how to trigger this deletionPool bug?
@XITRIX do you have any thoughts on that?

To reproduce the bug  :
In pokemon_view.cpp line 55 was commented out, De-comment it, replace it by getAppletFrameItem()->setHintView(holder); and set global quit to true in the main function, then inside the app, open a pokemon view in the pokedex and press + to quit the app while the pokemon view is displayed, it should segfault.
It seems closing the app while a hintview is displayed was triggering the segfault before the fix, explaining why it was commented out in the demo app

Looks like a really nice PR, could you please change this small things and will look perfect to me?

Commit done


Finnish translation

Finnish translation to YakYak.

`MyLocaleLanguage' should be in Finnish as all other translations are.
If you wish to change it please submit another pull request. This one was already merged and should be included in the next version


refactor(api): remove access to API v1 + default to v2

Summary
We have already removed all API v1 endpoints but one, this PR is switching the auth access token
endpoint to be API v2 endpoint. Additionally, we set the API client version to v2 and remove
completely WithApiV2() option function.
BREAKING CHANGE: Anyone using WithApiV2() will have to remove the function since v2
is now the default.
How did you test this change?
Updated all tests, built and run CLI manually.
Issue
https://lacework.atlassian.net/browse/GROW-2277

If we keep WithApiV2() option as a no-op. The breaking change could be avoided.


Add Korean translation about new added materials

comment: there is no official translated text for Twilight Ceremonial Blade and Unforgettable Ashes yet.


Take over responsibility for cache server

Need to coordinate with Sean Stevens at UA

Review TERRAREF cache server handoff docs
Document these protocols
Add scripts to github repository

Progress: Found a workaround for the IP address whitelist issue. We have access to a small IP address range which JD will add to the whitelist. We can then use persistent or ephemeral 'secure jump hosts' or 'bastion hosts' and assign them IP addresses in that range.
Waiting to hear back from JD about when that happens.

Progress: Sean S says that the request to open the firewall rules have to come via Matt Rahr. He's offered to get in touch with Matt to kick off the process. He'll CC me.

Progress: Andy Monteverde is in the process of opening the firewall for the IP address range I gave Sean.

Progress: I have confirmed I have access to the gantry cache server from an IP address in the requested range.
:tada:

@dlebauer I think this should be an epic.

Changing into an Epic  @julianpistorius break out into separate tickets


Numbers alignment in .tag-pill displayed not in center

I'm currently switching from Bootstrap 3 to Bootstrap 4. In the previous version i use the .bagde class and i read that this is no longer supported and the peoples should use .tag-pill instead of .bagde.
After drop of .badge numbers displayed not in center of the .tag-pill

Tag will be renamed back to badge - #20939

This is more likely to do with cross-browser font rendering with our switch to system fonts than anything else. For the time being, I'm inclined to close as a won't fix because it's basically impossible to get this right for every browser and OS. Open to suggestions if folks have them though for improved rendering across all supported browsers!


Version 1.5.6 uses webview component gesture conflicts

When the webview component is used in the project, after clicking the web page, return to the list, pull-down refresh, the 1.5.6 version will conflict, the pull-down gesture is invalid. Version 1.1.6 works fine

Can you attach the example code how to work fine in 1.1.6?

I am very sorry about the problem of my project itself.


feat: checkbox based releases

based on @alexander-fenster's recommendation I've simplified the design significantly; to create a release you now just click on a checkbox:

One question - what happens when I don't have access to cut a release?

@JustinBeckwith, @alexander-fenster and my working theory was that you would need edit access to issues on the repo to check the box (which should mean it's appropriate for you to create a release).
I will confirm this as soon as we release.


feat: add a start command

Implemented user stories:
swa start
swa start app_artifacts
swa start http://localhost:4200
swa start app_artifacts --api api
swa start app_artifacts --api api --api-prefix functions

Closes #26

Will check that out asap. Should not be difficult to fix.

Will check that out asap. Should not be difficult to fix.

@anthonychu I just tested your use case and it worked for me without any fix:
swa start /Users/wassimchegham/oss/@manekinekko/mslearn-staticwebapp-api/angular-app/dist/angular-app

The static server was able to pick up the right location

By the way, the start command is expecting an appArtifactLocation or a folder that can be served (has an index.html). What's inside /Users/antchu/source/ms/swa-cli-js-sample/static ?

@anthonychu I just tested your use case and it worked for me without any fix:
swa start /Users/wassimchegham/oss/@manekinekko/mslearn-staticwebapp-api/angular-app/dist/angular-app

The static server was able to pick up the right location

By the way, the start command is expecting an appArtifactLocation or a folder that can be served (has an index.html). What's inside /Users/antchu/source/ms/swa-cli-js-sample/static ?

Super weird that I'm getting a different result.

I think the difference might be that I don't have a workflow file?

Super weird that I'm getting a different result.

I think the difference might be that I don't have a workflow file?

Okay. Will investigate the issue.

Okay. Will investigate the issue.

@anthonychu the issue should be fixed by now.

First pain point I've had with this is that if I'm running the API already, there's no way to proxy it.
A use case for this is when I'm working on a TypeScript Functions project, I'll run npm start which will start tsc --watch and the functions tooling, meaning that the Functions are already running.
Can we make it possible to provide a URL for the Functions as well? Or is there another way to tackle it with the start command?

Oh wait, I see if you were to pass --api-uri http://localhost:7071 it then uses that

Oh wait, I see if you were to pass --api-uri http://localhost:7071 it then uses that

Wonder if it should just be --api to mirror the app location which autodetects if it's a path or uri.
I also don't think we should allow changing the api-prefix right now because the service doesn't support this. Don't want to set the expectation that this is possible when it isn't (yet).

@anthonychu  I created an issue to track that #64
@aaronpowell do you think we need to simplify the list of options we pass to the CLI?

Yes, I think we need a simplified set of flags, but we should also think through the scenarios of how we expect someone to use it.
Do we expect that people want the cli to run everything for them? To use existing servers? Combination of both?

For the initial release, I think it will help with adoption if the CLI allows users to:

starts all necessary servers (the "it just works" scenario)
integrate with local dev servers (app and api)


Avoid direct text editing by soft keyboard

hello
How to prevent the keyboard from opening when touching text?(prevent change text by keyboard)

you want the ability to disable the edittext when you tap on it?

you want the ability to disable the edittext when you tap on it?

yes

@reza-dev20  so you can now call this method to enable of disable value inpu
 hQ.isReadOnly = true // Disable value input from keyboard. Default false


After the last element

The box must disappear after there are no more elements to choose.

Hi ozturkemre,
Thanks for using this. I have fixed this issue.


Updating axios

#19196

Did we test this?
I will add this package as github branch, and test it on staging first, then merge it if it works


Example of Identities_to_Identities64 integration with the codebase.

@reikdas I have shown an example as to how you could go about integrating functions into the codebase. @jpivarski This can be merged if you want. But if you'd like to merge this, can you give me an example for writing tests for Identities(I'd like to have a integration test in place although since it's just casting it should pass)

Is this PR intended as an example (from @trickarcher to @reikdas) or as something to be merged in? It's getting a little stale as src/libawkward/kernel.cpp has changed. If it's an example, let's convert it into a draft and eventually close it after Reik is done, so that I'm not asking myself whether I need to merge it over and over. If it's meant to be merged in, then it will need to be brought up to date and I'll review it.

(I hope I am not stepping on any toes) I guess we could either merge it in after @trickarcher finishes making the possible changes discussed inline, or we could convert this PR to a draft since I will be attempting to generate this in my PR anyway and then close it when my PR has been merged, like @jpivarski suggested.


Add files via upload

Added domain for dseu.ac.in

@abhi98zero3 First stage of verification passed, official domain for Delhi Skill And Entrepreneurship University is dseu.ac.in as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@abhi98zero3 Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


[BrokenLinksH2] Fixed the link path

Fixed the link path

Docs Build status updates of commit 7cd1b9f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-gp/installation/SecurityPlanning.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 38e66e6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-gp/installation/SecurityPlanning.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


New Function? Remove-DynatraceHostGroup

is that possible? if so, we should put it in there

It's not possible. don't worry ourselves about it


gnome-builder: fix test after gtk4 4.8.3 bump

Follow-up to https://github.com/NixOS/nixpkgs/pull/207322 and https://github.com/NixOS/nixpkgs/pull/207546
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[X] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 207658 run on x86_64-linux 1

2 packages built:

gnome-builder
vala-language-server


How to combine audio rtsp stream and video rtsp stream?

Is your feature request related to a problem? Please describe.
I have a video rtsp stream and a audio stream,I wonder how to comine them in js.
e.g.
video:rtsp://<IP_ADDRESS>/live/video
audio:rtsp://<IP_ADDRESS>/live/audio
Describe the solution you'd like
Just want to display the audio and related video and the same  time in Front-end

Can you tell me if playing a rtsp video is already possible?


Add gc report

closes part of #3127
Added reports at the end of gc run, reporting the deleted objects, relevant commits and the gc rules.
Missing commit timestamp in the commits summary.

@lynnro314 can you please add an example report to the pr description? It will make it easier to review

@lynnro314 can you please add an example report to the pr description? It will make it easier to review

Sure.

Parquet files describing all the deleted objects:

A list of all the commits participating in this GC job:

Basic information about the run, including: # of deleted objects, the GC rules used for this jobs:

The rules:


trying to understand the dataset folder structure.

Hi @AAnoosheh ,
Thanks for making this repo public. I'm working on converting the night images to day images. I would like to get clarified on the dataset folder structure.
is it something that should look like this? or are any changes required? if you find the below folder structure is wrong, could you please provide the right structure?
---dataset
      |----train0
      |         |---day_image1.jpg
      |         |---day_image2.jpg
      |----train1
      |         |---night_image1.jpg
      |         |---night_image1.jpg
      |----test0
      |         |---day_image1.jpg
      |         |---day_image2.jpg
      |----test1
      |         |---night_image1.jpg
      |         |---night_image1.jpg

is the command right for the above folder structure?
python train.py --name night_to_day1 --dataroot ./datasets/train --n_domains 1 --niter40

Hi the folder structure is okay. It will simply load both train and test in alphabetical order and assume the order matches for both.
(The only time it has to be Day first, Night second is when using my pretrained model, since that's the order I trained it with)
The only problem I spot is n_domains should be 2 (day & night are our domains)
Thanks!


CoNLL03 data issues

Hi there,
I'm having issues with trying to replicate the results on conll2003 dataset. I have downloaded the data from the official repo and placed it under conll03, so it looks like this:

However, when running I'm getting the following error:

Additionally, I tried obtaining the dataset from here: https://github.com/davidsbatista/NER-datasets/tree/master/CONLL2003 and renaming the files according to what your model expects, however I'm getting the same error.
Could you please provide a link for the specific dataset you've used or instructions on how to go about solving this? Thank you.

You can find it in https://drive.google.com/drive/folders/1ZxytgzPLTA7ge9sX-JgIoIZj7kUCdh9h?usp=sharing

Thank you for your swift reply.
I downloaded the dataset you provided, however I'm getting the same error as before ie. ValueError: num_samples should be a positive integer value, but got num_samples=0

It seems that the code fail to read the file.
The normal script likes:
12/07/2021 20:56:01 - INFO - __main__ -    entity_id = 10014 12/07/2021 20:56:01 - INFO - __main__ -    mask_id = 50264 pad: 50261 50262 219554it [00:00, 1164998.07it/s] 160it [00:01, 92.22it/s]
rather than
0it 0it
The code works in my computer. It  read the input file in
https://github.com/thunlp/PL-Marker/blob/caf67d8542aa14be57a6b6c0201367ec0f6c1aef/run_ner.py#L127-L129

Thank you for pointing me to the specific part of the code that opens the file. I managed to find what the issue was. I was downloading the data files the wrong way. Thanks for your help, closing this now.


feat(tray): Support macOS icon template

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Documentation
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes. Issue #___
[ ] No

The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
[x] A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

For the curious; this is the results;
https://user-images.githubusercontent.com/22237916/127491289-9d8e2e86-ab6b-4007-bf14-5fa61cec267b.mov


FatalErrorException in User.php line 42: Trait method can has not been applied, because there are collisions with other trait methods on App\User

I get error
FatalErrorException in User.php line 42: Trait method can has not been applied, because there are collisions with other trait methods on App\User
<?php

namespace App;

use Illuminate\Auth\Authenticatable;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Auth\Passwords\CanResetPassword;
use Illuminate\Foundation\Auth\Access\Authorizable;
use Illuminate\Contracts\Auth\Authenticatable as AuthenticatableContract;
use Illuminate\Contracts\Auth\Access\Authorizable as AuthorizableContract;
use Illuminate\Contracts\Auth\CanResetPassword as CanResetPasswordContract;
use Bican\Roles\Traits\HasRoleAndPermission;
use Bican\Roles\Contracts\HasRoleAndPermission as HasRoleAndPermissionContract;

class User extends Model implements AuthenticatableContract,
                                    AuthorizableContract,
                                    CanResetPasswordContract,
                                    HasRoleAndPermissionContract
{
    use Authenticatable, Authorizable, CanResetPassword,  HasRoleAndPermission;

    /**
     * The database table used by the model.
     *
     * @var string
     */
    protected $table = 'users';

    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = ['first_name', 'name', 'email', 'password','username'];

    /**
     * The attributes excluded from the model's JSON form.
     *
     * @var array
     */
    protected $hidden = ['password', 'remember_token'];
}

I have the same error. how i can solve it?

@montes2012 in my case I could solve this by removing 'Authorizable' class from User model in this line:
use Authenticatable, Authorizable, CanResetPassword,  HasRoleAndPermission;
now:
use Authenticatable, CanResetPassword,  HasRoleAndPermission;

There is a collisions between @romanbican roles and Authorizable.
Refer to @christopherburton PR for solutions.

Check: https://github.com/romanbican/roles/issues/133


multiple nested modules, default parsing rules bug?

What steps will reproduce the problem?
So we have 3 nested modules: admin -> parser -> deals.
Deals module has ProfileConstructorController (profile-constructor)
Controller has actionDeleteProfile (delete-profile).
and action parameter "id"=2
No routing rules, default parsing rules.
What is the expected result?
GET: http://domain/admin/parser/deals/profile-constructor/delete-profile/2
route found, RESPONSE: 200 OK.
What do you get instead?
GET: http://domain/admin/parser/deals/profile-constructor/delete-profile/2
route not found, response: 404, not found
Additional info
GET: http://domain/admin/parser/deals/profile-constructor/delete-profile
route found, 400 Bad request, missing param id.(expected behavior)
GET: http://domain/admin/parser/deals/profile-constructor/delete-profile?id=2
route found, 200 OK.
If i switch deals module to root module - all works.
GET: http://domain/deals/profile-constructor/delete-profile/2
route found, RESPONSE: 200 OK.

Q
A

Yii version
<IP_ADDRESS>

PHP version
7.2.3

Operating system
Ubuntu 16.04

added to rules:
'<module1:[\w\-]+>/<module2:[\w\-]+>/<module3:[\w\-]+>/<controller:[\w\-]+>/<action:[\w\-]+>/<id:\d+>' => '<module1>/<module2>/<module3>/<controller>/<action>',
all works, but i still think default parsing rules have bug with named parameters

No routing rules, default parsing rules.

What do you mean by this? Can you share your UrlManager config (which handles GET: http://domain/deals/profile-constructor/delete-profile/2 correctly)?

''urlManager'   => [
'baseUrl'         => $baseUrl,
'showScriptName'  => false,
'enablePrettyUrl' => true,
'rules'           => [], //default parsing rules, no custom rules
],
'

@ReDev1L By default UrlManager does not handle any named params in URLs - if http://domain/deals/profile-constructor/delete-profile/2 works for you, you probably has some custom rules (they can be inherited from common config if you merge configs). To support pretty URLs for <module1>/<module2>/<module3>/<controller>/<action>/<id> patters you must add rule for this in the same way as you did it for <module>/<controller>/<action>/<id>.
I'm not sure if we should support such URLs by default - framework should not force such convention for URLs. However this could be done as part of #14974 - default FallbackUrlRule will work same as now (handle only routes in path), but we could extend it and create FallbackUrlRuleWithIdInPath to support <module>/<controller>/<action>/<id> patterns with any level of nesting. Then you could add only one rule (or configure UrlManager::$fallbackRule) instead manually adding own rules for every level of nesting.

@rob006 Tested again, you are right, my bad. I had rule with named param. m1/c1/a1/:id.
This fallback rule enhancement is very good idea.


Branch.io Deep linking not working on iOS 13+. It does not show pop-up to open application

We have added deep-linking integration in our app and using capacitor-branch-deep-links. It is working till iOS 12.1 but in iOS 13+ it does not show a pop-up to open the application on a click of deep-link.
We have also tried forced uri redirect mode but none of these solutions are working.
https://help.branch.io/using-branch/docs/creating-a-deep-link#forced-redirections
Installed Dependencies:
Ionic 5.26.0
@capacitor/cli 2.4.5
@capacitor/core 2.4.5
@capacitor/ios 2.4.5
capacitor-branch-deep-links 3.0.0

After going through this link, I figured out that I was using the wrong Apple App Prefix and invalid Provisioning Profile Specifier. This correction fixed my issue. Though I am still not sure why it was working in iOS 12 with the wrong Apple App Prefix and Provision Profile.


Malformed hashes are silently loaded

When NSD loads a zone from disk, and the zone has records such as DS or ZONEMD, where the hash is malformed, NSD appears to silently load the zone, including the malformed hashes, and serve them. When I query such an NSD server with BIND's dig, dig warns of a malformed packet.
                              IN      ZONEMD

;; Query time: 1 msec
;; SERVER: ::1#53(::1)
;; WHEN: Mon Jan 24 13:48:37 UTC 2022
;; MSG SIZE  rcvd: 92

The nsd-checkzone utility also doesn't catch this syntax error. On the other hand, BIND's named-checkzone and Knot DNS's kzonecheck both catch these errors. In the example below, both the ZONEMD record and the DS record for aaa are malformed. They are each missing a byte.
# nsd-checkzone . /var/lib/nsd/.zone
zone . is ok

# named-checkzone . /var/lib/nsd/.zone
dns_rdata_fromtext: /var/lib/nsd/.zone:26: near eol: unexpected end of input
dns_rdata_fromtext: /var/lib/nsd/.zone:33: near eol: unexpected end of input
zone ./IN: loading from master file /var/lib/nsd/.zone failed: unexpected end of input
zone ./IN: not loaded due to errors.

# kzonecheck -o . /var/lib/nsd/.zone
[.] missing RRSIG (record type ZONEMD)
[.] incorrect type bitmap in NSEC
[aaa.] invalid digest length in DS (keytag 1657)
[aaa.] unverifiable signature (record type DS)

Error summary:
   1    missing RRSIG
   1    unverifiable signature
   1    incorrect type bitmap in NSEC
   1    invalid digest length in DS

NSD loads the data and does not inspect the data content for validity. It just serves the content to the clients. This means a lot of records, also like, DNSKEY records that could have malformed content. And the only way to know is to cast it into its verification type object, and interpret the content type. Or records loaded with unknown type syntax could have specified some different type of byte content. The nsd-checkzone utility reports if the zone can be loaded by NSD, which is okay.
If you want more zone checks, utilities like ldns-verifyzone, or the ones you use, may be able to catch more errors in the zone.
That said, for common, or useful, errors it could be possible to add checks where needed. But NSD just by design does not want to go into the records themselves, just send them to the client. So right now, for hashes in type DS or ZONEMD, it does not know anything about them, just loads them, unaltered.

Adding an extra check for data length is fairly straightforward and probably a good thing to make a semantic warning. I.e., it fails to load on primary with an error and only reports a warning on secondaries.

"Funny" the check_zonemd_rr actually has the following comment: // FIXME: RDATA contains digests, do extra checks? :slightly_smiling_face:


Initial release

Adds sane relative import behavior and test case. Updates docs to refer to stylus-relative-loader, and describes the purpose of our fork.
It strikes me now that another strategy could be taking stylus-loader as a dependency and attempting to monkeypatch listimports, instead of forking... I don't feel strongly either way.
/cc @ryan-roemer @ryanisinallofus

Whoops, this was supposed to be a PR against our fork.

I actually think what you're doing in relative-loader is great. I'd rather see that get merged in stylus-loader as a default. It just makes more sense in a webpack context. I wouldn't worry too much about people depending on the old behavior. We could put a note in the README.md and add it in a major tick release.

@JonDum Thanks, and I completely agree! Was thinking of opening a different PR against this repo where it could be switched on with an option (similar to the existing resolve url option), making it backwards compatible as well. Do you have privileges on here/npm to do releases?  Either way we're interested in fixing it upstream at some point.
One thing I'd hope to do (and need help with) is making the solution less of a hack, if possible. I tried to change this behavior in pathcache and resolver with no luck, and doing it in listimports was the easy way out.


The great merge

Let's push my work into the master branch so we have the final branch to push releases from. Once this is done I'll use tags to setup the first Cocoapod release.

Done!


verifying address on Ledger harder to do without it being displayed on screen

Steps to reproduce
when setting up a Ledger, one is taken to the screen below where one enters a password and network type.

Current behavior
at this point in time, I'm asked to verify my address on my ledger hardware device
Expected behavior
how do I know that the address I'm verifying on my ledger is the one being displayed in the wallet.
Basically, the problem is this, in basically most other hardware wallets for other chains, the address is displayed on the hardware device and the computer screen simultaneously. Then the user compares the hardware wallet address on the device to the one on the screen and clicks "verify".  What we are verifying is that the addresses are the same. but in this case, I can't actually see that address on the screen. I will be able to see it shortly thereafter when I log into my profile dashboard, but not just right there. So it isn't the end of the world but is untypical of industry best practices.
Affected Version
pre-launch version of Symbol Bolos and Symbol desktop wallet 0.14.0
Additional context
Like I said, this isn't the end of the world, but I was a little surprised Ledger didn't suggest it as it is the MO for their Ledger Live as well as Trezor wallets.
Basically, we are asking the user to go through a "blind verification" instead of a "verified verification"
Suggested Behavior
When I click "Next" there is a pop up with the address that shows the same address in popup as shown in my Ledger.

Hmm. It works exactly the same as for Trezor (NIS1) and Ledger (NIS1). When you are creating a profile (login) on the wallet screen is not presented address because first, you need to export it the first time. How would wallet know it?
Besides that, after you login into wallet, you have an account "Show on Ledger" button where you can compare.
Also, before each transaction address verification is also done.

Yes. We shouldn't use the NIS1 integration as the standard to follow, it too wasn't following best practices IMO.
The "show on Ledger" button is really good and solves the problem and as you point out is available for one to see later, so I'm really glad that was added. That also means this issue isn't critical at all.
I don't think it is a priority, but just saying, that usually whenever one is using a hardware wallet and there is a "verify" address function in the hardware wallet, the screen also usually displays the address so one can verify they are the same.

@TriPhan96 are you aware of another mode to export address? Where the device is presenting that you exporting it and don't ask to verify?

We can get public key and address from Ledger device automatically without user verification steps.
IMO now we can have 2 options for this flow issue

Keep current flow, but do not show Ledger user verification screen. Ledger device will return address without user approval to create profile on Symbol desktop wallet
First get address on Ledger device without user verification then show it on the desktop wallet. Then ask users to verify address on Ledger device, if yes Symbol wallet will be created, if no will not create profile

@jabo38 what you think? @TriPhan96 it requires changes in the BOLOS app or only wallet?

Either option 1 or 2 seems like an improvement to me. I’d be curious which one others liked. I guess my preference is 1. People will have the “verify address” button in the wallet. And will be verifying each tax they send.

Option 1 is my take as well. Address is randomly generated anyway?

@rg911 it's Ledger flow. For the same seed, you get each time same address ;)
For me also 1 is ok

For both options, just modify the code on Symbol wallet @cryptoBeliever

Should we use option 1 for child account creation flow for Ledger profile?

adding extra accounts is very time consuming, so I would say if we can make that easier, we should.

like for instance, let's say I have 8 accounts on Ledger as a power user. having to recreated them each time one by one and verify on the ledger one by one, takes a lot of time.
this could maybe be a separate issue where the "profile" remembers the accounts and address and keeps them in the profile so they don't have to be recreated each time,
But to answer the question above, yes, if I didn't have to verify on Ledger each time with a blind verification, it would speed up the process.

@TriPhan96 all good but can you remove this message when creating a profile and child account?

Hi @cryptoBeliever, the message ("Verify information in your device") has been removed. Please have a look at it. Thank you

Fixed.


feat: Miscellaneous defs and lemmas

Match https://github.com/leanprover-community/mathlib/pull/8289

<EMAIL_ADDRESS>

bors d+
Thanks! I've pushed the fixes that should make this pass CI

bors merge


Allow users to specify how frequent PRs can be created

Scala Steward currently creates pull requests as soon as it detects that a new version is available. This leads to a lot of PRs for projects that have many dependencies or dependecies that are very frequently updated. To reduce the noise this creates for maintainers of such projects, we should add the ability control how frequent Scala Steward is allowed to create PRs in a repo via an option in .scala-steward.conf. This option could be a simple enum with the cases asap | daily | weekly | monthly.
See https://twitter.com/olafurpg/status/1227392299904258048 for more context.

As Renato mentions (https://twitter.com/renatocaval/status/1227541373064286208) maybe it could bundle all the updates in a single PR too.  Of course, that also trades off with testing the individual upgrades in isolation.  But you also save on CI consumption.  Trade-offs, trade-offs...

I'm interested in knowing if/where we want to persist the state if a successful PR creation has completed for that time period (for daily/weekly/monthly)

Here are my thoughts about it ...
If we have a longer period, we won't reduce the number of notifications nor the pressure on CI. We will only post-pone it to a later date. Then, that day will be the day to watch CI finish n builds and merge n PRs, etc.
We will reduce the noise when a library is updated three times in the week. We will only get the last update. But that's not the most common case.
That's why I had this idea of accumulating everything in one PR. This has the drawback that different updates may break the build, but if we have one commit per update, we can run git bisect locally to try to find the offending library. That will be painful, but it's part of the trade-off.
Anyway, cool that we are discussing this. I think there is some room for improvements and we are moving in a good direction.

I understand the arguments for bundling updates into one PR but I'm not a fan of that. I summarised my arguments against that feature in https://github.com/fthomas/scala-steward/issues/413#issuecomment-585410159. They basically boil down to "this makes Scala Steward more complicated". But that doesn't mean this feature won't be added to Scala Steward, only that it is probably not me who adds it. :-)
However, I think we can decouple bundling updates and giving users control over the frequency of PR creation. I'm confident that the latter doesn't require a ton of changes and that it can be implemented so that it is independent of a future "bundle updates" feature.
I'd also like to mention that this feature without bundling updates might not reduce the overall number of notifications, but it does reduce the number of days when these notifications are created. I could imagine that Scala Steward is perceived less noisy when it only creates PRs once a week instead of everyday.
@kiranbayram I would store the date a PR was created in PullRequestRepository and then use the latest date there to decide if we are allowed to create new PRs.

I have two questions:

Would you use java.time.LocalDateTime in app context to compare dates?
How would you serialize the date? Some form of formatted string ("2007-12-03T10:15:30") or as an Instant (epoch seconds)?

I've been using DateTimeAlg.currentTimeMillis before to get the current milliseconds since epoch and serialized it as Long. For comparison I've been using FiniteDuration.
My current thinking about how this could implemented is that we could remove all DependencyOutdated states in PruningAlg.checkUpdateStates if the duration between the creation of the last PR and now is smaller than the duration specified in the .scala-steward.conf. And that's it. No new PRs will be created but existing ones would still be updated in case of merge conflicts.

One question that come to my mind. Do we want to have this time period per repo or per dependency ?
They have a different effect:

per repo: all update are coming on the same day once per week / once per month. All other days are without "noise"
per dependency: the same rhythm of updates as now. Only dependencies that are changing ver often are "throttled"

That's an interesting question! I've assumed per repo until now but per dependency sounds interesting too. One downside I see with per dependency is that if for example a library publishes a botched version 1.0 and shortly after that a fixed version 1.1, per repo will likely create a PR for version 1.1 only while per dependency will create a PR for 1.0 and only after the time period one for 1.1.

@renatocaval bundling upgrades into one PR sounds like a separate feature request to me. It's not something I'm personally interested in since if the CI fails you would need to manually track down which upgrade caused the failure.
@fthomas thank you for opening this ticket! I want to register my interest in using this feature ✋ My biggest gripe is getting PRs for version numbers that are short-lived because the library publishes frequently (many are my own libraries 😅).
Just one example, over the past week I have published four versions of olafurpg/metaconfig in roughly 1-2 intervals while working on a new feature in the scalameta/metals repository. Metaconfig is also used in my other projects (scalameta/scalafmt, scalacenter/scalafix, ...) so I also received four upgrade PRs in those repositories even if they don't need the new functionality in Metaconfig (at least not yet). If Scala Steward upgrade PRs only came ~monthly, then I would most likely only receive one upgrade PR for Metaconfig.
By running the upgrade PRs less frequently, we may be able to at least skip a few redundant PRs for upgrades to short-lived versions.
Just brainstorming here, it might be nice to have an option to say something like

only send an upgrade PR when the release is older than X number of days (I'm not sure if there is reliable data to implement this), with a maximum limit of Y days (so that we don't wait indefinitely to upgrade)
only send upgrade PRs on specific weekdays. For example, I would prefer not to get the upgrade PRs over the weekend.

To give one more example from yesterday, I got three Scala Steward PRs to upgrade the same library

https://github.com/scalameta/mdoc/pull/295 MUnit v0.5.0
https://github.com/scalameta/mdoc/pull/296 MUnit v0.5.1
https://github.com/scalameta/mdoc/pull/297 MUnit v0.5.2

The v0.5.1 release failed for Scala.js 0.6.x due to build mis-configuration but succeeded for all other modules. I use MUnit in four other Scalameta repositories so I ended up getting quite  a lot of PRs that are redundant.

only send an upgrade PR when the release is older than X number of days (I'm not sure if there is reliable data to implement this), with a maximum limit of Y days (so that we don't wait indefinitely to upgrade)

That's an interesting suggestion to reduce the overall noise. We don't have the data yet to implement this but we could certainly record when Scala Steward sees  a new version for the first time. But I also think that this is a separate feature that could be implemented independently.

only send upgrade PRs on specific weekdays. For example, I would prefer not to get the upgrade PRs over the weekend.

I like that too. Allowing cron expressions instead of or in addition to the asap | daily | weekly | monthly enum would make this possible.

FYI: I started working on this feature in #1336.


hrss reweighter

One thing that may help our issue with recovering hrss is a HrssReweighter transform that re-scales the hrss values according to some distribution before projecting the waveforms.
This will allow us to get a better sampling of hrss than the 75,000 or so individual samples allow

Been taken care of in https://github.com/ML4GW/ml4gw/tree/dev since intrinsic parameters can now be generated on the fly.


Codeforces API to fetch Contsests, Questions and User Detail

Project title
Codeforces API
Project Description
It is a website with full use of API provided by codeforces. It contains detail of future as well as past contests. It also has section to filter question on basis of tags, difficulty, question code. It is also able to find users detail based on their username.
Web stack

HTML, CSS
EJS
NODE and EXPRESS
Codeforces API
API call using AXIOS

Screenshot(mandatory)
CONTEST PAGE

QUESTION FILTER PAGE

QUESTION FILTER RESULT

USER SEARCH PAGE

Additional Context(mandatory)
It is full fledged website which can be made using the data from codeforces and can be used by any person using codeforces for all kind of work without even going to main site.
Are you contributing under any open-source program ?
CodePeak'23

@apu52 @ Can we submit full fledged website codes written in XML  language?

@apu52 Can we submit website codes written in XML language?

Yes you can


metric: "Store read/write rate bytes" in PD cannot reflect actual IO traffic

Bug Report

What version of TiKV are you using?

v7.5.4
What operating system and CPU are you using?

Steps to reproduce

What did you expect?
What did happened?

/remove-type bug
/type enhancement


examples? maybe on the wiki?

It would be great if people could populate the wiki with links to examples. I'm trying to learn both promhx and signal stuff all at the same time, so I'm easily confused. E.g. how to just do basic on click stuff using EventTools, I don't even know what the "callback" function arguments will be.

I agree, although I htink a wiki would only be a slight improvement over a readme.  I'd really like to do something with try.haxe.org, and show the code actually working.  The whole lib is due for an update, imho.  There's a lot of things in haxe 3.2 that will make things a bit easier.  Once I'm done with my other super secret haxe project I'll give promhx some more love.

Also, thanks for trying promhx!  And dealing with the warts!


Use single quotes for matrix generator command line arguments

The replace operator for matrix generation supports regex groupings, meaning you can pass something like Pool=(.*)-general/$1-storage to replace "Pool": "ubuntu-general" with "Pool": "ubuntu-storage". However, we currently generate these command line arguments as being wrapped with double quotes, meaning the powershell script will try to interpret them as variables. On top of this, the Azure Pipelines join operator does not support double quotes, but I've found that we can effectively escape a single quote join value with another single quote (e.g. the join value ',' must be declared as ''',''' as opposed to "','").

The following pipelines have been queued for testing:java - templatejava - template - testsjs - templatenet - templatenet - template - testspython - templatepython - template - tests You can sign off on the approval gate to test the release stage of each pipeline. See eng/common workflow


maximum recursion depth exceeded while calling a Python object

Hi I am trying to use goatools to find ancestors of a GO term by the following code:
from goatools.base import get_godag
godag = get_godag('go.obo', optional_attrs='relationship')

GO_ID = 'GO:0050807'

from goatools.gosubdag.gosubdag import GoSubDag

gosubdag_r0 = GoSubDag([GO_ID], godag, prt=None)
print('{GO} ancestors: {P}'.format(
    GO=GO_ID,
    P=gosubdag_r0.rcntobj.go2parents[GO_ID]))

But I got an RecursionError: maximum recursion depth exceeded while calling a Python object error. I think there might be wrong when parsing the go.obo file. Would you please help me fix this problem?

Thank you so much for your interest in GOATOOLS and thank you for taking your time to report a recursive error and thank you especially for extremely clear code showing how you came upon the issue.
I have implemented your code in a new test and am not seeing a recursion error in that test at this time. Can you upgrade your GOATOOLS version to the latest version and try it again?
Also, please note that the go2parents is deprecated and will be replaced by go2ancestors since parents refers to the immediate predecessors and ancestors refers to all predecessors.

Thanks for your updates, it answered my problem.


nexus_upload : crypted password

Hello,
It would be nice to be able to crypt password in the nexus_upload phase for ipa. The way I see it is the way Maven do in J2EE projects (https://maven.apache.org/guides/mini/guide-encryption.html): inside fastfile, user password is encrypted and inside a global file (e.g. in user's home directory, in a hidden folder), having a master password encrypted.

I see your point, but in this case you could just pass the password as FL_NEXUS_PASSWORD env variable. This is more flexible, since you don't depend on the build machine you are executing fastlane on.

Thanks for the answer. To create an env variable, I have to create a .env file in the repository/scm workspace. The problem is that I don't want users to know this password. For a better understanding, this is my UC: the only user who has the hability to upload file to nexus is my continuous integration user (e.g. jenkins). This forces developpers to have continuous integration and make some tasks (compilation, unit test, code quality...). What I understand in your answer is that the configuration will be visisble for developpers (which has access to jenkins and its workspace). Is there a way to use system global variable (e.g. in bash_profile)?

You can set that variable in Jenkins per job or globally. And no one will be able to see that password in config or build logs.
This provided by Jenkins EnvInject Plugin

Great! Thanks a lot. Exactly what I need.


Opyn vs. Hegic vs. Optino

great work, just curious have you done any analysis vs. other platforms e.g. optino or hegic?

Thanks! Not yet, but it's something we would want to do after correctly integrating with the Opyn V2 Gamma Protocol.
That way, we could offer more options but still maintain the focus of protecting liquidity providers.

Haven't done this work yet but would love to integrate as many options protocols as possible.  Would also add perp.fi to this list.

I would like to integrate it with opyn v2

I would like to integrate it with opyn v2

I would like to integrate it with opyn v2

PRs welcome!  We haven't had much time to work on this lately.

I would like to integrate it with opyn v2

PRs welcome!  We haven't had much time to work on this lately.


Fix issue #442

Fixes issue #442.

Coverage increased (+0.2%) to 85.956% when pulling a98be5e410ba451d855a1a401ae477a1e66005c1 on chrycheng:issue-#442-rebase into 275fbbe87fa0adab9181a1fd80ba313c88f32f3c on JSQLParser:master.

Coverage increased (+0.4%) to 86.093% when pulling 01de362f7719a332ed82a5251960b19dbf55971a on chrycheng:issue-#442-rebase into 275fbbe87fa0adab9181a1fd80ba313c88f32f3c on JSQLParser:master.

Fixed the only issue in the first Codacy check that could be fixed.  Remaining ones are the known PMD issues with Mockito.

Agreed to //nopmd.

Coverage increased (+0.4%) to 86.093% when pulling fc55e06ab958187873470b1929a96b37ce5008e4 on chrycheng:issue-#442-rebase into 275fbbe87fa0adab9181a1fd80ba313c88f32f3c on JSQLParser:master.

Coverage increased (+0.4%) to 86.093% when pulling 84acd501884dd3086058d79ea8875018afe7b162 on chrycheng:issue-#442-rebase into 275fbbe87fa0adab9181a1fd80ba313c88f32f3c on JSQLParser:master.

I chose to annotate instead in order to scope down the suppression to that particular rule only.


CMake install error

When testing #6, I encountered the following error:
CMake Error at cmake_install.cmake:47 (file):
  file INSTALL cannot copy file
  "/home/travis/build/EwoutH/lumahdrv/build/libluma_encoder.so" to
  "/usr/local/lib/libluma_encoder.so".
Makefile:95: recipe for target 'install' failed
make: *** [install] Error 1
The command "make install" exited with 2.

Full log: https://travis-ci.com/EwoutH/lumahdrv
Commands used:
 - mkdir build
 - cd build
 - cmake ../
 - make
 - make install
 - make test

Hi, and sorry for the late reply.
So it seems like the library compiles ok, but it cannot be copied to your local/lib? Does libluma_encoder.so exist in the build directory? If so you can try 'sudo make install' or manually copying the library to your local/lib.


Workspaces should have a means to check if software is already running / Maximum windows threshold

Description of the new feature / enhancement
I often have docker and onenote already running, but workspaces will want to open onenote window again, even though the one is minimized and the setting to launch is also minimized, then it will create a nth window.
Scenario when this would be used?
I have ADHD and I am planning to use workspaces with both my streamdeck to get myself set to optimal modes such as "programming focused" which will then let streamdeck close out teams/outlook while opening everything else right where I want it.
Supporting information
No response

/dup #34571


Add Visual SLAM module using ORB-SLAM

An implementation of Visual SLAM, this code is a combination of work from @danielginn (PhD) and @Brandonhop93 (FYP).

Needs work to bring it further into the code style of the repo.
Better utilisation of NUClear things

This PR does NOT integrate SLAM into localisation. Localisation integration to come

btw.. this is a PR for anyone to work on 😛 It's 100% not for me to work on


160 X 80 resolution led panel (sm16380sc chipset)

I'm trying to use 160 X 80 pixel led panel but it doesn't work at all. Arduino code uploaded without any error but the output video of led is just white color with some strange grain. Is there anyone who have the same issue of mine?

Please clarify - the size of panel is 160x80 mm or 160x80 pixels? Could you please show the photo of reverse size of it with ID and and other text clearly readable?

https://ko.aliexpress.com/item/1005004752444756.html?spm=a2g0o.order_list.order_list_main.5.3382140fJlKGbG&gatewayAdapt=glo2kor

This is the of the product and it's 160x80 pixels.

According to description it seems to me that the panel has s-PWM driver, incompatible with the library. Could you write models of the chips?

I'm using esp-wroom-32 chip for Arduino.

No, please indicate the models of chips in the matrix

oh, sorry. It says sm16380sc azbqysaa51 on the chip

Same issue as #416 it seems. Not supported chip as its a totally different way of operation.

thank you for helping me


Module can be used in its own definition [FUTURE BUG]

Issue
A module being used in its own definition could lead to infinite recursion.
Note that this is potentially not true for all configurations.
I has to be checked recursively for modules using modules that use the current module
(aka recursion where the loop is larger than 1 element)

Fixed by having an error reported to the user when recursion is detected


Training Stops at 200+ epochs . How to fix this?

I am using this code and it works. But I am having a error after 200+ epochs and I didn't understand why its because the code runs

Hi @cjrpascual
Please report the name of the file, and the error you get.


Issue when using scroll from child view controller

It is really cool component, great gob.
I am using it  on view controller which is using two collection views in scroll view added like a child view controllers, they are changing by swiping left or right.
I set up everything like after scroll page changed i am seting shymanagers scroll and controller :
self.shyNavBarManager.scrollView = self.collectionViewFromChild;
[self.shyNavBarManager setViewController:rightCollectionViewController];

the same for right.
its working fine on scrolling up, navigation bar hides cool.
The problem is that when I am scrolling down and scroll offset goes under status bar a bit and i begin to scroll down navigation bar begin to appear, but it should appear only when offset y reached the status bar height. Than in expands with out animation.
Video:
https://www.dropbox.com/s/x024oe0hkydlfyx/bug.mp4
Please help me with this problem. How I can fix it?
Thank you!

Thank you for this work!
Can I bind status bar with shyNavBarManager for hiding status bar when navigation bar hides?

@Mazyod Any update on @Jauzee's [question] (https://github.com/telly/TLYShyNavBar/issues/16#issuecomment-87633929) above?


Follow suit of urllib3 and drop python2.6

Already untested (?)
Resolves https://github.com/urllib3/urllib3/issues/1456

I used pyupgrade for the syntax changes.  Most of the motivation was to resolve the urllib3 issue.

Hi @asottile, thanks for the pull request. As we noted in the urllib3 issue, this is already addressed and will be in our release within the next week once the changes in urllib3 have had some time to air out.

I’ve created #4830 for visibility. Thanks again @asottile!

@nateprewitt disregarding the urllib3 issue -- is this PR not ok? does requests intend to support python2.6 (it doesn't test against it)

There’s nothing wrong with the PR, but we already did this work a year ago. We haven’t supported python2.6 in a while but hadn’t intended to forcibly break compat until 3.0.0.
The reason we declined to merge this is it’s more work to rebase the release commits and would remove credit from the original author. It also introduces some breakages that will affect a number of our downstream dependencies which are unrelated to 2.6.


Consistency of Http4sClientDsl with Http4sDsl

In Http4sClientDsl and Http4sDsl, the apply syntax returns an F[Request[F]] and F[Response[F]], respectively.  This made sense when EntityEncoder returned an F[Entity[F]], but now it returns an Entity[F].
Returning an F[Response[F]] is still sensible in Http4sDsl, as we are always constructing an F[Repsonse[F]].  This lifting avoids repetitive .pure[F] calls at the end (e.g., Ok("foo") vs. Ok("foo").pure[F].  Changing this would break the world.
F[Request[F]] is not a necessary construction now that EntityEncoder is no longer effectful.  And it's s burdensome construction, as we overloaded the Client interface with both F[Request[F]] and Request[F] methods.  It would be nice to make the Http4sClientDsl return pure Request[F], and deprecate these Client overloads.  However, this would make the apply syntax inconsistent with the server DSL.
Discuss.

I think having a DSL that's better suited for the intended use case is more important than having the DSLs be consistent.

Bigger question: does anybody like the client DSL?  I don't, and discourage its use.  Should it survive at all?

I remove that dsl everywhere I find it at $WORK.


General Issue: Link to admiraldev and admiral.test to admiral project board

Background Information
We should be able to link this repo to the admiral board automatically, but I can not figure it out
https://docs.github.com/en/issues/organizing-your-work-with-project-boards/managing-project-boards/linking-a-repository-to-a-project-board
Definition of Done
Successfully link admiraldev and admiral.test to the admiral core board.

When creating a new issue I can see admiraldev and ophtha


[C#] Implement C Stream Interface in C#

Describe the enhancement requested
Follow up to #33856.
Component(s)
C#

@wjones127, is this something you've already started work on? If not, I have a partial implementation that I can drive to completion.

@CurtHagenlocher well before we can do this we should start with the C Data interface for ArrowArrays. The one for ArrowSchema is about to be merged (https://github.com/apache/arrow/pull/34133).
Would you be willing to start with a PR for the arrays? I haven't started that yet.

Yes, I'd start with a PR for the arrays.


build --static still adds prefetch links to head

Im running mdx-go build pages --static but the output html files still get
    <link rel='prefetch' as='script' href='/main.js'><link rel='prefetch' as='script' href='/1.main.js'><link rel='prefetch' as='script' href='/2.main.js'><link rel='prefetch' as='script' href='/3.main.js'><link rel='prefetch' as='script' href='/4.main.js'>

appended to the head tag. Is there a way to prevent this when building static? I'm trying to use mdx-go to create HTML emails and this tag is useless to that.
Also static still builds {number}.main.js files though I just need the HTML and zero JS files.

dupe of #26 oops


Handle declarable CPU architectures

Release, operator, and sample images must allow for architecture declaration

#88 covers catalog image arch selection only (not bundle/related images).


Split tests into groups + SafeTestsets

This PR reorganizes the test structure as described in #28 .
The grouping logic happens automatically based on file structure:

Tests without a group, in the top folder are run as part of the group "top"
test/mytest1.jl
test/mytest2.jl
Tests within a folder are assigned to the group based on the folder name:
test/utility/test1.jl
test/basics/test2.jl
Examples are run as part of the group "examples"
examples/myexample.jl

To select/run a subset of the tests, the Tests.yml CI can make use of the group input. Selecting this in a matrix ensures parallelism through the github runners.
To select/run a subset of the tests locally, the test_args keyword, along with the --group=groupname syntax can be used, for example:
using Pkg: Pkg
Pkg.test("mypackage"; test_args=`--group=examples`)

Note that all group name matches are insensitive to capitalization. The default group ALL runs all tests.

Nice, I really like the idea of basing the groups off of the folder structure!

Does this also work with the environment variable? Or did you decide not to go that route?

This works both with environment variables and test args, it first checks the latter, if this is empty it checks the environment variable, if that is empty it runs all tests

(TODO: codecov token)

If the tests pass, I would merge this and I'll add the setup folder/files in a separate PR.


Add eth_gasPrice as a fallback gas price getter

Overview
We're currently using 3rd party APIs to fetch the average gas price for each network. Ethereum has a built-in RPC method called eth_gasPrice that returns the gas price in the last block.
We should start using it as a fallback instead of a fixed price.
Requirements

Add a wrapper for it on the Safe Core SDK
Use the method in this repo as a fallback "oracle"

What is eth_gasPrice?
Richard:

oracles normally have some additional logic (using averages and block statistics), while eth_gasPrice just returns the current price (see https://eth.wiki/json-rpc/API#eth_gasprice)

also eth_gasPrice is available via the normal web3 providers as a rpc method, while oracles are custom endpoints

Goals
Make the gas price fetching more robust. Oracles are not super reliable and often rate-limit requests.
Arbitrum doesn't even have any oracles at all.
Code example
Mikhail:
const gasPrice = (await provider.getGasPrice()).add(ethers.BigNumber.from(2000000000));

Should go together with https://github.com/gnosis/safe-react/issues/2744 to enable priorityFee (@mikheevm recommends 2 Gwei always on top)

Solved in #2863.


Merge Address propagation and handling back into SymbolicValue.

Merge Address propagation and handling back into SymbolicValue.
This moves us towards a model where SymbolicValue can track addresses.
I avoided this originally because they are nearly distinct concepts in
SIL, but such an attempt was doomed to fail: SIL has operations that
convert addresses to Builtin.RawPointer and ptrtoint to convert it to
integers.  These all get used with strings and arrays, so we need to
model them as SymbolicValues.
The heap model is also incorrect, but I'll address that in the next
patch.

@swift-ci please test tensorflow


Add extra contextual parameters to render filters

This change adds extra parameters to the timber/loader/render_data and timber/output filters so more context is available when using the filters.

Coverage increased (+3.3%) to 91.547% when pulling f9e59ce00ced8b490707dce03f366557c08bfd19 on johnbillion:contextual-parameters into 0cfb37b8e3455608e5735e8a800e3673128c8f4a on timber:master.

Thanks @johnbillion! I'll review this week

@johnbillion I added a quick question in line notes, lemme know what you think!

@johnbillion — thanks again for submitting this, I added #1091 with some tests and tweaks (re-ordering $file and $data so the order is consistent). Lemme know if you have any thoughts on this, otherwise I'll plan to merge in sometime tomorrow


Solution notebook tutorial 1 #54

did we agree to put these in a subdirectory?
Exercise 4. There are few things here where the questions are a bit ambiguous I think. I would have coded something different...
a. print out the dimensions - > print out the number of dimensions
b. print out its coordinates. You have printed the coordinate names. We need to either change the question to be "print out the names of the coordindates" or change the code to print the coordinates in full

Solution notebooks should be in different directory. Because notebooks require python script, we need to restructure the files. I am not sure how Saeed is doing, so I thought to put it in same directory and later on do the restructuring when we have all the files.
I was inclined to print the coordinate names. printing out data or min/max can also be a good task

did we agree to put these in a subdirectory?
Exercise 4. There are few things here where the questions are a bit ambiguous I think. I would have coded something different...
a. print out the dimensions - > print out the number of dimensions
b. print out its coordinates. You have printed the coordinate names. We need to either change the question to be "print out the names of the coordindates" or change the code to print the coordinates in full

did we agree to put these in a subdirectory?
Exercise 4. There are few things here where the questions are a bit ambiguous I think. I would have coded something different...
a. print out the dimensions - > print out the number of dimensions
b. print out its coordinates. You have printed the coordinate names. We need to either change the question to be "print out the names of the coordindates" or change the code to print the coordinates in full

Solution notebooks should be in different directory. Because notebooks require python script, we need to restructure the files. I am not sure how Saeed is doing, so I thought to put it in same directory and later on do the restructuring when we have all the files.
I was inclined to print the coordinate names. printing out data or min/max can also be a good task

did we agree to put these in a subdirectory?
Exercise 4. There are few things here where the questions are a bit ambiguous I think. I would have coded something different...
a. print out the dimensions - > print out the number of dimensions
b. print out its coordinates. You have printed the coordinate names. We need to either change the question to be "print out the names of the coordindates" or change the code to print the coordinates in full


[BUG] Unable to use with eslint.config.js

Describe the bug
I'm trying to use eslint-plugin-tailwindcss but no rules are being triggered despite being violated.
I'm sorry for reporting this here, I'm not even sure if this is a bug, it's probably just a miss configuration in my part...I've searched everywhere for an answer, but I can't find any...
This is happening in a .svelte file, could that be the problem? is eslint-plugin-tailwindcss compatible with .svelte files?
I'll leave the link to the stack overflow question I posted for more details.
https://stackoverflow.com/questions/79096277/eslint-plugin-tailwindcss-configuration-not-working
Sorry again for posting this here, but couldn't find any answers elsewhere.
Thank you!

Ok, I didn't think about the possibility of this problem being caused because eslint-plugin-tailwindcss didn't support svelte files, but after doing some more testing that seams to be the case.
Is svelte file support something that is being worked on?
Thank you!


WB2L Dump - Phopollo RGBW bulb

WB2L: https://developer.tuya.com/en/docs/iot/wb2l-datasheet?id=K9duegc9bualu
Phopollo Bulb:  https://www.amazon.com/gp/product/B0953F8BTN
Used bk7231tools to dump:
phopollo_dump.zip

added in 9dc6acd @mattvirus


Added ability to use multiple images

I wanted to use multiple images so I added this little bit of functionality. Main changes are that "src" has to be an array now. I thought about allowing it to be both an array and a string, but that would cause some duplication of code to occur.

Great!
What about a new release, @VincentGarreau?

the code which you have added for multiple images is not working

the code which you have added for multiple images is not working
It is working... setup it correctly


Add jq as dependency required for oci_push

As jq is required for oci_push in https://github.com/bazel-contrib/rules_oci/blob/d49f7b6cfee40179d8accf420ec219cb874c040e/oci/private/push.bzl#L139 mark it as such.

could you rebase this against 2.x?

@thesayyn done


[cmake] Enable new runtime build in Linux smoketest

Enabling running the new build system in the Linux smoketests. This just enables running the build, it doesn't yet run the tests against the runtimes built by the new build system. This is mainly to help keep things in sync as the stdlib is being developed.

@swift-ci please smoke test

@swift-ci please smoke test Linux


Remove ARIN-NONAUTH from IRR explorer

ARIN-NONAUTH has been decommissioned (https://www.arin.net/announcements/20220128-irr/). We need to remove it completely from the code.
For the website I removed ARIN-NONAUTH as a datasource for IRRD, but here are also some references to ARIN-NONAUTH in the IRR explorer code.

(venv) irrexplorer2@irrexplorer0:~/irrexplorer$ grep -l -r ARIN-NONAUTH .
./frontend/node_modules/.cache/terser-webpack-plugin/content-v2/sha512/b9/e9/5d69456f3c968752907ca70918d6776645abb0dec6d26187c608bae8568c212aa98900586b1c636221144ccab8381bf055110597c40ac6d73120ea53cc62
./frontend/node_modules/.cache/terser-webpack-plugin/content-v2/sha512/f8/87/c11223ec4359c0326d2bfbc48972cbb03fbea3441b6c1c645857fb3e19e931dc31025e7141a122d59d45747b9f06072df086a3cf65fd574cc78c5a87f238

Only some caches left.


Generate + upload new documentation

Since we made generator updates, we should update documentation.

Last should be generating new docs from this change: https://github.com/vkottler/ifgen/issues/50.

Done: https://vkottler.github.io/cpp/sphinx/hal-rp2040/.


Feat : Added Welsh-Powell graph coloring algorithm

Fixes #117
Added the Welsh-Powell graph coloring algorithm and also updated the readme section.

@joweich I made the changes you pointed out in the above comment.Please do have a look once...Thanks!!

@joweich Updated the PR...Do take a look

@joweich Updated the PR...Do take a look

@GouraV-Chatterjee looks great, thank you! We'd now need to add tests and documentation, although I'd argue that the documentation can also be done in a follow up :slightly_smiling_face:

@joweich Updated the PR and added a test file for Welsh Powell Algorithm..!

@bobluppes Please do take a look on my PR once!!

@bobluppes Since the discord sever is not working attaching the required files here!!!!


Update server dependencies

Run poetry update to update dependencies.
The main motivation is to update torch version which has critical vulnerability.

@njhill PTAL


External switch toggle capability

Added capability to connect an external switch to Sonoff GPIO14 pin in order to be able to togle the relay state, this is useful to conect the Sonoff to a wall toggle switch and be able to togle the relay state through wifi & direct wall switch as if it was a normal switch.
The wall switch will act as a togle so if you use the wall switch tu turn on then use wifi to turn off the wall switch then would toggle to On again.
Conect wall switch to GND pin & other conector to GPIO14 (switch should not have voltage)

Dude I deliberately left all this out of the basic sonoff. A lot of beginners don't have the ability of soldering etc into a basic sonoff.

Ok, but not aditional soldering requiered, they have already soldered in order to program the Sonoff with your firmware. They only have to conect som jumper cables to the described pins.


Temporary documentation fix because of bug in 2.1.0b1.

See: https://github.com/mendersoftware/integration/pull/663
Signed-off-by: Kristian Amlie<EMAIL_ADDRESS>

Thanks @kacf & @lluiscampos  !


Editing the ylabel in plots generated with stat_bin

Hello,
thank you for this great toolbox!
Is there a way to alter the y label in histograms? For example if I use the defaults in stat_bin it reads 'count'. Is it possible to change this? I would expect it to be possible by calling set_names('y','mylabelhere') but it does not seem to be the case.

Hi and thanks :)
You're right, it seems that stat_bin() overrides the name set with set_names(). I'll change it so that it says "count" only if the y name was unspecified.

that was fast :)
thanks again!

Just pushed the commit now :)


Compile code using ngc

Fixes #75
@gevgeny just check package.json

the travis build is red :(

ill take a look again :D

Now this should be more then green, BTW we should only enable the squash merge option. Its the best way to keep the commit history readable.

np


HTTP 400 Being Recieved during field ping

Experiencing HTTP 400 "Command.[undefined].is.unknown" during node pings from field servers, can this be cleaned up?
field-tcpdump.txt
tcpdump output is attached

Thanks! Will be fixed.

Done.


Missing Documentation per OSC Governance

The following Required docs are missing and should show on the Main page of Code: CODEOWNERS, CHANGELOG.md
If there are CHANGELOG's please create a top level file and link accordingly.
For Reference: https://intersect.gitbook.io/open-source-committee/policies/governance
Also see Documentation and Legal

Thank you for reporting the issue!
@MattChain volunteered to take care of this, but I cannot add him as an assignee for some reason, so I've added myself for the time being. @MattChain please still do all the work, I'm only going to take credit for it!

@mattchain any progress on this issue?

Hi @Ranchhand87 could you please point to the area of the documentation that says the above are required and what specifically is being asked? I don't see it. thanks!

https://intersect.gitbook.io/open-source-committee/policies/documentation#:~:text=CODE_OF_CONDUCT-,A,per package may be more appropriate),-The%20documents%20should
Here is the link regarding the Changelog, Please ensure that one shows on the Top level for ease of understanding. Again the top level can links to any changelog that is already in place.
CODEOWNERS  is a general requirement and reinforces those that are primarily responsible for writing and maintaining code within this repo. Although this may be in the ReadMe. This is a standard across the other core repos.

Please provide an update. Thank you.

@marshada is on long-term leave, so probably not gonna take care of this.
@zliu41 it looks like somebody else should get this ticket?

Several team members are on PTO, and we have a team meetup the week of Aug 26. We can aim to tackle this in early September.

Closing this issue as it has been renewed with a more specific tasking #6423