(maint) Update stale messages

Description
Update the stale messages used by the GitHub Action.
Motivation and Context
On the Contributing.md file, we include a note about not commenting just to try to circumvent the automatic closure. This adds a similar note directly to the comments left by the GitHub Action.
How Has this Been Tested?
This is an update to the wording of the action, no testing has been done.
Screenshot (if appropriate, usually isn't needed):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Migrated package (a package has been migrated from another repository)

Checklist:

[ ] My code follows the code style of this repository.
[ ] My change requires a change to documentation (this usually means the notes in the description of a package).
[ ] I have updated the documentation accordingly (this usually means the notes in the description of a package).
[ ] I have updated the package description and it is less than 4000 characters.
[ ] All files are up to date with the latest Contributing Guidelines
[ ] The added/modified package passed install/uninstall in the chocolatey test environment.
[ ] The changes only affect a single package (not including meta package).

:white_check_mark: Package verification completed without issues. PR is now pending human review

@corbob awesome work! Thanks for your contribution!


Fix error message in assertion

Due to error text adjustment of sqlcipher repository https://github.com/sqlcipher/sqlcipher/commit/821782a23b06ab2fd774ae2500d18e1cc2a82a80
Through running pysqlcipher3 I never get the file is encrypted or is not a database message.
Only get file is not a database message, so I was studying some reported Issues and the third point in this comment.
So I think this modification fixes 4 failures and only 2 errors remain when running python setup.py test provided using Python3.X (I used Python 3.9.6 on an Mac OS X 11.4 system)

Is this an issue because you are linked against SqlCipher version 4? If so, do your changes actually break the tests for anyone running with version 3?

The error message change in https://github.com/sqlcipher/sqlcipher/commit/821782a23b06ab2fd774ae2500d18e1cc2a82a80 was first active for the released version 3.20.1 (tag v3.4.2).
Therefore, I tested this 3.20.1 and previous released version 3.15.2 (tag v3.4.1) in a clean Docker environment with "deprecated" Python version 3.5.3.
Who would have thought that with the older version 3.15.2 the tests passed, and with the error message change version they fail.
So it has nothing to do with compatibility between SqlCipher version 3 and 4. They changed the message within SqlCipher version 3 releases. It depends on which specific SQLCipher 3 version is installed.

I missed your last round of the changes a long time ago. Is this still something you want merged? Because it looks like you are now only modifying test files, so I'm fine merging if you still want.

yes it is still relevant

Can you bump the version and then I'll merge

Long time no see!
Now you can merge.


Drop node 16 support

If we drop node 16, we can update the build scripts with the --openssl-legacy-provider flag to support node 18+ without having to upgrade to webpack 5 just yet.
Node 16 end of life is set for september 11.
Any objection?
cc @greenscientist @davidmurray @kaligrafy @vincentchab @Frost000 @samuel-duhaime @XavierKMT

no objection here!

Do we need to do the change in transition also?

eventually too, but it's not a requirement for this one (I think)

No objection! Let's do this!


fix authorizer Uri

Coverage remained the same at 50.678% when pulling 953775fe53a540d1ba3184d82d9c3ac691232fa7 on vkkis93:master into c2d4dba62d48f0b97684e2b8b17ac2c7a63a7903 on HyperBrain:master.

Nice work 👍 . Just verified that the deployed authorizer calls the correct function alias. (I changed the alias example project to contain an authorizer test branch that can be used to verify authorizer functionality).
The only thing I found is, that the "test your authorizer" functionality in the console does not work with the stage variable. But I think that's ok, as the lambda function name is editable - I'm sure that is the same behavior as for Serverless 0.5.
PR approved. I'll merge it.

@HyperBrain you absolutely right


DockerV2 build with AWS ECR Push

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug?
Enter Task Name: Docker@2
Environment

Server - Azure Pipelines or TFS on-premises? Azure Pipelines

Agent - Hosted or Private: Private (within AWS)

Issue Description
I am using the Docker task to build and image and the ECRPushImage task to push the image up to AWS ECR (since the agent host is within AWS, it will use the creds of the host rather than needing to define a service connection). However, the Docker@2 build seems to only assign a tag to the image if part of a connection, which is not the case here. This means I don't know what source image name/tag to provide to the ECRPushImage, since all it results in is the SHA image ID.

We have not tested the task without service connection flow. Do you want to debug it and raise a PR for it?

Fixed the issue. The fix is being rolled out and should be available in a few days.


Quick Script Question

Hey Leviathan,
for 1.12.1 LootTweaker, do you happen to have a sample script that removes all items from the loot table? I'm trying to empty out all loot chests.
Thank you :)
Darkosto

Solved in Discord


Using AI to extract Newick from images

Scientific papers often share phylogenetic trees as images, which makes them hard to use without a conversion to a machine readable format like Newick.
I did a brief experiment to see if AI engines could help with this, and the initial results are not good! I pointed the engine to the following image (from https://github.com/OneZoom/OZtree/discussions/620), with the prompt "Turn this tree into Newick format".

Google Bard came up with the following, which is completely wrong:
(Bandicota indica:0.0,
(Lepus tolai:0.0,
(Cebus albifrons:0.0,
(Hylobates lar:0.1,
(Pygathrix nemaeus:0.1,(Galeopterus variegatus:0.1,Daubentonia madagascariensis:0.1):0.0):0.0):0.1):0.0,
(Eulemur mongoz:0.1,
(Nycticebus coucang:0.1,(Tarsius bancanus:0.1,(Tupaia belangeri:0.0,
(Tupaia minor:0.0,(Tupaia montana:0.0,(Tupaia splendidula:0.1,(Tupaia tana:0.0,Tupaia nicobarica:0.0):0.1):1.0):1.0):1.0):1.0):1.0):0.0):0.1):0.0;

Microsoft Copilot (based on GPT, not clear if 3.5 or 4.0) did even worse, getting confused by the prefix before the species name, and generally ignoring many leaves:
(((KT028097:0.000000,Bandicota_indica:0.000000):0.000000,(KT028098:0.000000,Bandicota_bengalensis:0.000000):0.000000):0.000000,((KT028099:0.000000,Bandicota_savilei:0.000000):0.000000,(KT028100:0.000000,Bandicota_maxima:0.000000):0.000000):0.000000):0.000000,((KT028101:0.000000,Tupaia_nicobarica:0.000000):0.000000,(KT028102:0.000000,Tupaia_belangeri:0.000000):0.000000):0.000000);

I was a bit surprised that they did so poorly, as it doesn't feel like that hard a problem. Maybe better results can be obtained with different prompting, or with different engines.
This is a good area to explore, as it could potentially be a game changer to extract Newicks directly form papers.

I suspect other people might be working on this too. I will ask the OpenTree folks.

@hyanwong yes, that would be interesting, thanks!
I went back and tried to iterate with Bard, pointing out an example of what is wrong in its tree. It always agrees, saying things like "You are absolutely correct. The corrected Newick format for the tree is ...". And it does fix one little thing, with the rest still very random.
Worth noting that I'm using free offerings. It could be that the premium offerings for $20 per month perform better, and maybe at some point I'll try that!

Would it help to convert the diagram to SVG first? I'd assume that most of the time you're dealing with a PDF of the paper that inkscape could happily convert. Even if it's in a bitmap, you could use inkscape to trace/OCR it. At least then there's a series of tokens to reason about. You could even write an algorithm to parse the SVG path, but I suspect it wouldn't withstand reality.
A tool to help a human do it might be most useful though IMO, where you could click each sibling node to create the level up. That wouldn't take very long to use, and it'd be pretty obvious if you've made a mistake, and the overlaid tree doesn't match the tree underneath.

Many papers are behind paywalls that I can't access, but usually, those that I can access are web pages, not PDFs. e.g. let's look at https://www.ncbi.nlm.nih.gov/pmc/articles/PMC6731702/ as an example.
In this case, the relevant diagram is figure 5. Some interesting challenges:

It has 3 trees in the same figure
They're oriented vertically (unlike the example above)
To view it at full res, you need to go into the viewer, which downloads it in small chunks (chunk example). So it never really exists as a single image without some client logic to reassemble it. There is however a low res version that's directly accessible.

All that to say that just getting an image to work with is not straightforward. But let's assume we have that solved somehow.
The idea of converting the image to an SVG is interesting. But the challenge here is that the cladogram can come in so many different forms (orientation, style, labels, edge lengths, etc) that writing an algorithm to parse it could be a losing battle.
And I think that's where AI potentially makes a lot of sense, as (given the right training) it can adapt to an unpredictable set of variations without us needing to write a complex algorithm. Us humans can certainly do this quite easily, and the pitch is that AI should be able to as well.

A tool to help a human do it might be most useful though IMO, where you could click each sibling node to create the level up. That wouldn't take very long to use, and it'd be pretty obvious if you've made a mistake, and the overlaid tree doesn't match the tree underneath.

I guess I'm looking for a higher level of automation here, e.g. input the URL to a paper and get back a set of Newick trees.

To view it at full res, you need to go into the viewer, which downloads it in small chunks

Download the PDF (link top-right). Importing page 14 into inkscape reveals how they made the diagram, they typed out the text on it's side, then drew the tree in a paint program to match the text spacing.
You get to skip any OCR with a PDF, but there isn't really a logical connection between the text and the tree to work with, for you or the AI.

writing an algorithm to parse it could be a losing battle

Yes, definitely. Trying to use AI makes a lot more sense. My guess is the battle is to regard the tree as interesting, and not just a background image. Prompt engineering might be what to do here, but I'm sure you already know that :)

Thanks for the tips, I was able to import the page in Inkscape (new to me) and turn it into an svg.
My take is that the AI can do better if it looks at the 'cooked' image like a human would, rather than try to reason based on separate text and tree input.
Yes, it probably comes down to using the right AI, and good prompt engineering. I'll try to go deeper into that when I get some cycles.


Awsome Work, A Couple Simple Questions.

Hey Ben,
Thanks for this awesome open source project. I do a lot of open source work too.
https://github.com/bdring/Grbl_Esp32
https://www.youtube.com/watch?v=M1gXuKFspgY
I stumbled upon one of your designs on AliExpress. I bought one to test. The motor I received looks like this.

The documentation I received is pretty limited.
I hope to use the motor some sort of fabrication or kinetic art machine. The motor is so clean looking and the wiring can almost be invisible. I am quite excited.
I have been able to move the motor via the CAN bus, but I don’t have a real feel for what values to provide for Kp, Kd and Feed-Forward Current. Is there any guidance you can give me?
Thanks
Bart Dring

I have been able to move the motor via the CAN bus

Hope you don't mind me butting in, but I've finally someone else with a motor that looks like the one I'm trying to get going :)
I can't seem to make mine move at all - whenever I plug in the 24V only a red led turns on and the CAN bus message I send never receives an ack from the motor.  Is the red led normal on the new revisions?  Based on videos of the older ones, it should be a green led and the red one indicates a fault.  I can backdrive it with my fingers even when the 24V is applied.  I'm assuming you've only attached the 24V and the H/L of the CAN bus?
Trying to determine if the problem is my CAN programming/setup or if it's the motor itself.
Thanks!

It is red at power on. If you send the motor enable signal, it turns green. You can then send it a move command.
Without fully understanding all the parameters, the motor can be very jerky and not get to position. We were able to SWAG some numbers to get it better, (slow and low torque).
I am dumping everything I know in a drive folder. Feel free to browse around. I am not ready to publish my SWAG values until I get a better understanding.
I am not sure if the encoder is calibrated. I did not get a 3 pin UART connector. I ordered a few from Digikey.

It is red at power on. If you send the motor enable signal, it turns green. You can then send it a move command.

Awesome, thanks for the quick reply.  I'll see if I can figure it out :)

I won't be doing much on it until later this week. If you figure anything out, post it here and I'll add it to the doc/folder

@bgkatz I am still playing with this motor as I get time. I have loaded your firmware and the motor appears to work the same as before, so I doubt they changed your firmware much.
I did tweak the gear ratio because my motor has a 6:1 reduction. The range of motion seems to match the +/-12.5 radians of the firmware.
When I send it a command, the motor will move with the values I give it, but it never appears to reach its target position. with low values for kp, kd and ff it can be as far as a radian away. If I send the same position values, but higher kp, kd, and ff values it moves closer. If I max out Kp it gets pretty close, but is very stiff.
I would like to be able to tune it so it always reaches the target, but has adjustable stiffness.
I hope make some sort of CNC machine, like a delta or SCARA. I am thinking about adding a CAN command that disables the UART on the fly and converts those pins to step and direction inputs.

I bought same motor from Steadywin(on aliexpress).
I want to upgrade the firmware with mbed compiler. Which target board shall I select?

@nyxrobotics I documented what I did to program it
I hope it helps.

@bdring Thank you so much! I will try it tomorrow.

I was able to write the firmware, thank you!
The motor moves pretty well in normal operation, but I sometimes get "1f" message on serial terminal, and the motor won't move untill reboot.
Don't you have this problem?

The "1f" is normal operation. It is on line 63.
printf("%df\n\r", rxMsg.id);
It is printing the message id of the received CAN message on all messages. I am not sure why it is printing the f. It initially fooled me into thinking it was a hex value. It never has any effect on my operation.

Thak you for your reply!
The "1f" message was just CAN target ID...
We are investigating the problem of resetting the MCU while the motor is rotating, and the motor will not work unless the encoder is recalibrated.....

I replaced the power supply with one with a higher allowable current. It came to move stably.
However, I can't set any CAN command for ID "4".
While I send the packet for ID 4, CAN::_irq_handler is not called.
It seems that mbed-dev issue.
Does anyone have same problem ?

I found that ID numbers of "0bxxxxx1xx" pattern, such as 4,5,6,7,12,13,14,15 don't work.

I comented out  line 537 and it works pretty well. Thank you!
    //can.filter(CAN_ID<<21, 0xFFE00004, CANStandard, 0);

Sounds like you are on an old version of the firmware, which likely has other bugs as well.  The link to the latest fork is in the documentation Google doc or here
https://os.mbed.com/users/benkatz/code/HKC_MiniCheetah/
Commenting out that line will cause every motor drive to go into the CAN interrupt any time any message is sent on the CAN bus, which is not at all what you want.

Documentation for my motor drives is here:
https://docs.google.com/document/d/1dzNVzblz6mqB3eZVEMyi2MtSngALHdgpTaDJIW_BpS4/edit?usp=sharing
It has an explanation for what the different commands mean and how to set them in real physical units, but here's a qualitative description of what these terms do.
Kp is desired position stiffness. If you set all commands to zero except for Kp, the motor will behave like a spring with stiffness Kp about the 0 angle.
Kd is velocity gain. Kd acts like a damper. If you set all the commands to zero except Kd and try to spin the motor by hand, you will feel some drag, proportional to Kd.
The feed-forward torque is a bias torque. If you set all the commands to zero except for the feed forward torque, the motor will just apply the torque you set.
All the commands get summed up in the motor drive, so the final torque is:
Kp_position_error + Kd_velocity_error + feedforward_torque
All this being said, the Aliexpress company just copied my schematic, but I have no idea if they made any changes to the firmware,.

Dear all,
The explanations really helped. I got pure velocity control and pure position control work too.
However, I wonder why a PD controller is selected instead of the classical multi-loop(position, velocity, or torque) controller for servo motor. With only PD control, I found it difficult to control the position and velocity at the same time. Can anyone explain that to me.
Thanks

Dear all,
The explanations really helped. I got pure velocity control and pure position control work too.
However, I wonder why a PD controller is selected instead of the classical multi-loop(position, velocity, or torque) controller for servo motor. With only PD control, I found it difficult to control the position and velocity at the same time. Can anyone explain that to me.
Thanks

It's not quite a classic PD controller, which would only take a position command, and would take the derivative of the position error to get the derivative term.  The position + velocity commands with position + velocity proportional gains is equivalent to the classic PD controller in continuous time, IF the position and velocity commands are consistent with each other, but is works better when commands are sent slower than the control loop is updated.
Which brings up the point - you fundamentally can't do independent position and velocity control.  If you want to control to a trajectory, you should send position and velocity commands that are consistent with each other, i.e. the velocity command integrates to the position command.
To summarize how it was intended to be used:

If you want to just control velocity set the position gain to zero.  If you want better steady-state error rejection, you can wrap an integrator around it yourself  using the feedforward torque term.
if you want to just control position, and you do not care about the trajectory the motor takes between position setpoints, set BOTH Kp and Kd to be non-zero (if Kd is zero it will oscillate), send 0 velocity command, and send whatever position command you want.  This will behave "sluggishly", because the derivative term acts like damping on the rotation, always trying to slow the speed down to zero, but it will work.
if you want best performance and to track a trajectory, set both Kp and Kd to be non-zero, and send continuously changing position and velocity setpoints along your trajectory, which are consistent with eachother.

The motor drive itself will not generate intelligent trajectories (e.g. trapezoidal velocity profiles between position setpoints), that is up to you to do on whatever is controlling the motor.  But if you can generate the trajectories, you should be able to send self-consistent position and velocity commands to track it.
Hopefully that clears up any confusion

That is pretty interesting. I will do more research on command generation and motion planning.
Thanks for your detailed explanation.

Nowadays, is anyone able to compile the firmware? I can't import it into the mbed cloud compiler. I can't even compile it with mbed CLI and mbed Studio. I believe the cause is due to the version of the mbed library.
Can someone please help me?


Massive Performance Drop With Firefox

Version: 0.4.2
Browser: Firefox (v. 55 64bit)
I'm getting serious performance issues only on Firefox when using a lot of vivus instances. See the following codepen:
https://codepen.io/rontdq/pen/RLoBKZ
Basically I have 38 separate svg's that use vivus to animate a bunch of roads made out of lines. For triggering each road I use jquery waypoints.
On chrome, Edge and even IE performance is smooth, but on firefox the fps tanks to single digits. If you open the codepen in chrome and firefox you should see the difference. I'm running this all through Windows 10. Is this a browser issue or am I missing something on my end with the js code that I wrote?
Thanks!

Hi there,
Thanks for providing examples, that's helpful! However when I read you had
38 svg to animate I was pretty sceptical because that's too many elements
to animate. But their content is pretty simple so it's ok.
I have a smooth experience on Chrome, but in Firefox too (v55, 64bit, Mac).
Im afraid the problem is more about the browser engine than anything else.
Ill try to find a Windows 10 to test. Did you notice any errors in the
console?

Yeah I tried Firefox on mac and it is relatively speaking better than the performance you get on the windows version. Here is a performance log captured from firefox for windows 10:

Seems to be paint calls is the killer here?
No errors related to vivus, though looking again I do have a bunch of css declaration dropped errors. I'm not that familiar with web development in general but surely that shouldn't kill performance?

I installed a Windows 10 VM to play around but I couldn't extract any
interesting information. The animation wasn't smooth. Same on other
browsers.  The VM couldn't provide a fluid experience.
Can you tell me the size of the repaints you're getting? If it match the
size of elements that need repaints, well the browser is poorly performing
on the rendering. There's nothing I can do to help.

If I'm understanding you, do you mean this?

The size varies from 70ms all the way up to 100ms. Think I recall something about each paint needing to take less than 16ms to look smooth
I take it then this is just a firefox specifc issue and no optimisations can be done on on the users end to workaround it (other than just not animating it)? If it helps, this is what the repaint job is doing visually in 10fps gif quality:

Sorry to bump this, but don't suppose you had a chance to take a look at my previous post for this?

Sorry about the delay, I was afk and without a real Windows machine. I
tried again on my VM and got this.  The painting time is interesting, it's
pretty short.
But still wondering about the reason of the animation smoothness. Im afraid
it's a problem due to the browser and platform, otherwise the experience
should be consistent across platforms.
[image: Images intégrées 1]

Sorry I couldn't upload my screenshot (Corporate networks are awesooooome!!)
It was to show the performance tab : my paint was taking ~6.99 ms.

No worries: yeah I'll see if I can figure something out then i.e. pretend Firefox doesn't exist or just disable features specifically on that browser. I've done a simple animation test using css animations and even then Firefox causes stuttering...
Feel free to close this topic up and thanks for the help! 👍

I'll try to find a real Windows 10 machine and torture it a bit to make sure, and will also try with their new engine Quantum. Firefox and SVG got a love-hate relationship.
I'll keep you posted :)

Hey, delayed response on my end, but thought I'd share a solution. If you put translate3D on the svg/container it mitigates for the frame drops (I'm only dipping to 45fps at worst). Why it's only firefox that needs that I don't know but either way it works now :).

That's pretty cool! That means that firefox was probably rendering the whole page at every frame. Nice catch!

So. ehm what's the sollution to this? I have a svg where the animation is massivley delaied on FF compared to chrome: https://meteotest.meteotest-test.ch/ (the svg happens on the inital big blue surface)

I can give my 2 cents on this from using the library:
I checked your site and tried applying translate3d to the svg (rather than the container above it in the dom as it doesn't seem to work when on the container itself). It made a small improvement but I think the bigger problem is how many paths you have; I had nowhere near that many when building mine.
The other thing with svg I've noticed is that the smaller the size, the smaller the paint area = better fps. Try shrinking your browser and you'll see an improvement in Firefox with the animation. The library creator might know if this is definitely worth it, but you could try splitting apart your animations into multiple svgs to see if that helps - I noticed it was all just one giant one. Another option is oneByOne  for scenario sync, that can help spread the drops out. Other than that I dunno if the library could pull off what you're looking for.
Hope that helps!

Thank's for the answer. I admit it might be a bit overkill :D and needs some refinement on my side. But always good to know where the limitations are.


Implementation of distance on GeoSeries

Implementation of 1:1 distance on GeoSeries
Fix deprecated in ffi acquire_gil
Always return python GeoSeries when using getitem
Fix typing in test fixture

I had all precommit passed
Trim Trailing Whitespace.................................................Passed
Fix End of Files.........................................................Passed
black....................................................................Passed
isort....................................................................Passed
pyupgrade................................................................Passed
flake8...................................................................Passed

I had all precommit passed

Yeah pre-commit only runs the python lints at the moment. The rust lints are manual through cargo fmt --all (formatting) and cargo clippy --all --all-features --tests (lints)

In #42 @stuartlynn put up a proposal for handling both pairwise Series-Series and broadcasted Series-Scalar function handling. In the future we'll want distance to support other being a scalar as well, but I don't think that's a blocker; it's fine to have series-series support only

I agree. It didn't have an idea how to implement second behavior so i started with this implemented one in geo, the one that geopandas also uses

Can I add in black line length 120 instead of default 80?

Can I add in black line length 120 instead of default 80?

I'd prefer to stay as close to the upstream py-polars settings as possible, and they use the default of 88 I believe.

In #42 @stuartlynn put up a proposal for handling both pairwise Series-Series and broadcasted Series-Scalar function handling. In the future we'll want distance to support other being a scalar as well, but I don't think that's a blocker; it's fine to have series-series support only

I agree. It didn't have an idea how to implement second behavior so i started with this implemented one in geo, the one that geopandas also uses

Hey @mchalecki ! Thanks for this, hoping to finish up that proposal this week and then implement it for each of the functions we already have. Will add this one to the list!


Move project files into src/omnicore

As result of the previous discussion, this PR moves the Omni Core files into src/omnicore and src/omnicore/test, without mastercore_ or omnicore_ file prefix.
Additional grouping within the subdir would probably make sense, and in the longer run I could imagine to split files and have less classes per file, for example in the case of the traditional DEx and meta DEx, or to have a dedicated file solely for transaction decoding, and another one for the actual logic.
I wouldn't prioritize this, but it should visualize the changes and the file structure:

https://github.com/dexX7/bitcoin/tree/oc-0.10-project-move-subdir/src/omnicore

The QT files should probably live in src/omnicore/qt, but I'm not 100 % sure at this point, how well this can be integrated.
Alternatively, it could also be possible to move the files early, then integrate #13, but leave all UI and QT files in src/qt, to reduce the impact, and address it later. Nevertheless it would be required to update the mastercore_ references, and maybe resolve other conflicts.
While I could convert #13, I assume getting this in significantly affects the UI development, and unless @zathras-crypto thinks it would absolutely be no issue, I suggest to just move the discussion from #15 to this place, and postpone the actual move, given that it's only "nice to have", but without immediat gain.

Sorry, must have missed commenting on this - I support the idea - re the UI I don't think it would be too much of a hardship to fix that up to respect the new naming convention :)

I'd like to postpone this PR until #13 was merged, and ideally mastercore_dex was split into mastercore_dex and mastercore_mdex.
To resolve the conflicts here, I have to go though the steps anyway, which doesn't take long, but it would break again, once either one of the above takes place, thus "on hold".

Updated, but I tend to enqueue this after the UI integration, given the conflicts it introduces.

@zathras-crypto: given that the UI branch was merged, it's probably a good time to merge this one too. Do you agree?

given that the UI branch was merged, it's probably a good time to merge this one too. Do you agree?

Sorry bud I've been slack on this one - I haven't actually had a chance to look at what's required to move the UI files to /src/omnicore/qt yet

Currently only the src/mastercore*, src/omnicore* and src/test/mastercore* files are moved, while the the QT files are still in src/qt/, which is fine, I guess, and it could be done later, but I haven't really made up my mind how the secondary files (e.g. the images etc.) could fit into this nicely.
I mentioned the UI PR, because it touched many files, and many of them were affected by the src/ -> src/omnicore/ move.

Ah OK then - no objections here :)

Sorry, accidental close there :(

Haha, no worries. :)


allow users to set a configurable FSAC url

Fixes #1048 by adding a new configuration setting and flowing that through.  If the url is set we don't spawn an FSAC instance, but if it's not we use the same logic as before.

Can you rebase?

A note here: The default for the fsacRuntime config value needed to be removed because VSCode would silently add it on Configuration.get calls, so we couldn't tell the difference between user-set and the default value. So now we handle the default-setting in code in the language service.

One thing I’d add to it would be some kind of notifications when we can’t connect to FSAC pointing to the setting - people will mess their setting and they will forget they’ve changed something and then they will complain that F# is broken ;-)
So in our request helpers I’d check for the particular error (404? Timeout?) and display error message

That sounds reasonable to me. I won't be able to get to it until after Thursday (prepping for Meetup ATM) but I'll add that and we can take another look then.

That's a really interesting feature, will be awesome to have for the current Outreachy internship on FSAC (it's already hard to explain FSAC alone).
I too missed it, having to run vscode in debug just to check FSAC locally.
So i fixed the missing thing, i hope it helps @baronfel (good luck for meetup!)
@Krzysztof-Cieslak afaik is now ready, i think i added the feedback.

rebased on latest master
closed/reopen to trigger azure devops build
updated the instruction on CONTRIBUTING
fixed the logic to start FSAC (the name of config was different fsacUrlConfigured = Configuration.tryGet "FSharp.FSACUrl" vs Configuration.tryGet "FSharp.fsacUrl" so wasnt working correctly)
added the notify at startup for users, if that config is used

Thank you @enricosada! I hope it helps :) I've got a coworker at work who like to dev on windows using ionide but has to mount the source on osx for reasons, and he was the key driver for this feature.

updated doc, no need for experimental instance

Thanks a lot to both of you.


Creating multiple records using service.create(data) with an array yields: no id error

When dispatching create action on a service with an array of multiple objects as data:
var data = [
{name: 'index', permissions: 'guest'},
{name: 'about', permissions: 'guest'},
{name: 'admin', permissions: 'superuser'}
]
store.dispatch('/pages/create', data)

, the following error appears:
Error: No id found for item. Do you need to customize the `idField`?

The data is succesfully added to the database. The problem is when the promise is returned to the action and sent to the addOrUpdate action.
Upon analyzing the create action in src/service-module/actions.js, it seems that the error is produced by treating the response of the service.create(data) as a single object and passing that to addOrUpdate instead of addOrUpdateList:
create ({ commit, dispatch }, data) {
      commit('setCreatePending')

      return service.create(data)
        .then(item => {
          dispatch('addOrUpdate', item)
          commit('setCurrent', item)
          commit('unsetCreatePending')
          return item
        })
        .catch(error => {
          commit('setCreateError', error)
          commit('unsetCreatePending')
          return Promise.reject(error)
        })
}

Ah, yes.  I haven't handled array responses.  Thank you for spotting this.  I'll probably be able to fix this over the weekend, unless you have the bandwidth to submit a PR.  🙏

+1

what should i do to filter that progame catch this error

@bobcat1 sorry i looked at your original issue just now, but it seems like this issue is dealing with the problem of not handeling the response of bulk 'create' as specified here https://docs.feathersjs.com/api/services#createdata-params
data may also be an array.
Your Problem seems to be, not having an unique single id.

@Torge This issue is not related to #67.
My use case in relation to this specific issue is:
I'm trying to add an array of items, and then I need to use the IDs returned to add more items, based on the IDs returned from the first array. It's just that all IDs are null when returned. So my workaround right now is to make a find call after they have all been added. That way I get all the IDs, and can use them to add the rest of my data.

This is fixed in the latest pre-release.  npm i feathers-vuex@pre, and it will be included in the next minor version.


Remove SC2068 exception

bash handles "$@" more intelligently than one might expect. See docs: https://www.shellcheck.net/wiki/SC2068:

Double quotes around $@ (and similarly, ${array[@]}) prevents
globbing and word splitting of individual elements, while still
expanding to multiple separate arguments.

Fixes #65

cc @nathantypanski

@nathantypanski Any chance this can get merged? :)

Looks good to me.


Rewrite #[derive] removal code to be based on AST

We now remove any #[derive] before and including the one we want to expand, in the macro_arg query.
The same infra will be needed by attribute macros (except we only remove the attribute we're expanding, not any preceding ones).
Part of https://github.com/rust-analyzer/rust-analyzer/issues/8434 (doesn't implement the cfg-expansion yet, because that's more difficult)

bors r+

changelog skip


fscache: do LRU cache removal when the cache is full on store()

This implements a simple LRU removal when FsCache.store() is called but the cache is full.
With that the cache should behave a bit better and the issue that Dusty describes in https://github.com/osbuild/osbuild/issues/392 should be gone.
Please review carefully, I think this is sound but it's an important area :)
One more followup to make _rm_r robust aganst crashes would be nice but I will probably only do this after I finished working on bootc support for centos stream9 (which will be based on https://github.com/ondrejbudai/osbuild/commits/bootc) .
Another potential followup would be a simple CLI interface to inspect/debug the cache (i.e. get objects sorted by LRU order, query current size etc).
We could consider adding a stress testing test to the testsuite. Could be a followup.
[edit: comment about testing]

I think this will run into problems on systems where storage is mounted with noatime. Not sure what the solution is though :/

I tried this out. I have a cache size of 20G and it was full. When running with this enabled it is taking a really really long time. Anyone else having that same experience?

I think this will run into problems on systems where storage is mounted with noatime. Not sure what the solution is though :/

Sorry, I really should have written a comment on this either in the code or commit message (probably both). There is a test now though (but that is not as helpful as a comment :) - the noatime should be fine, it  atime update from the filesystem but the explicit calls to utime() (for futimens in our case) are not blocked. There is a test that checks this by running a testcase inside a tmpfs mounted with noatime. I will update the code to include better comments.

I tried this out. I have a cache size of 20G and it was full. When running with this enabled it is taking a really really long time. Anyone else having that same experience?

Thanks for testing this Dusty! I have not tested this on a large cache yet :/ When you say "it takes a long time", does it mean it's just slow? or is it not doing anything (just looping trying to find old entries)? I will also add some debug traces here I think. Sorry for the trouble!

I tried this out. I have a cache size of 20G and it was full. When running with this enabled it is taking a really really long time. Anyone else having that same experience?

Thanks for testing this Dusty! I have not tested this on a large cache yet :/ When you say "it takes a long time", does it mean it's just slow? or is it not doing anything (just looping trying to find old entries)? I will also add some debug traces here I think. Sorry for the trouble!

It was taking longer to run than I would expect an entire one of my local pipeline runs to take so I killed it. I don't know if it was infinite looping or just being really slow.

I tried this out. I have a cache size of 20G and it was full. When running with this enabled it is taking a really really long time. Anyone else having that same experience?

Thanks for testing this Dusty! I have not tested this on a large cache yet :/ When you say "it takes a long time", does it mean it's just slow? or is it not doing anything (just looping trying to find old entries)? I will also add some debug traces here I think. Sorry for the trouble!

It was taking longer to run than I would expect an entire one of my local pipeline runs to take even without any caching so I killed it. I don't know if it was infinite looping or just being really slow.

Thanks, that is a useful data point, the algorithm right now is very naive (and probably too naive). I will tweak it :)

I think this is working better now. Maybe we can get it in soon. I added a debug statement to help visualize things:
org.osbuild.ostree.deploy.container: 97d15cdd48697246a6058a5e91f1ad53c020b334783d6eddb3f0d9678ec4bb69 {
  "osname": "fedora-coreos",
  "target_imgref": "ostree-remote-registry:fedora:quay.io/fedora/fedora-coreos:stable",
  "mounts": [
    "/boot",
    "/boot/efi"
  ],
  "kernel_opts": [
    "rw",
    "$ignition_firstboot"
  ]
}
Failed to open file "/sys/fs/selinux/checkreqprot": Read-only file system
ostree container image deploy --imgref=ostree-unverified-image:dir:/tmp/tmp2jm1rn9p/image --stateroot=fedora-coreos --targ
/run/osbuild/tree

⏱  Duration: 39s
XXXX evicting objects/9c52e78ecd8a4a4526494a7ba0dd06a793392f1f84c0d550297c2e0539aa8c2b from cache
XXXX evicting objects/12c6876d803c299e771e6a459a53088bcd19f4286d1ab8c41cebc75970b16e3f from cache
XXXX evicting objects/38787448fc988c8edc4f15d7992f2af28404683a6f9ef47ac1c90a67f410779c from cache
XXXX evicting objects/e75491be3bf10ceadc1d1bfe7e5cdea39454680520f4d0525d10c213e0571a64 from cache
XXXX evicting objects/c6a382a05908de9f766876b4e7351e852ce77d7bc776b55ea2dba19ed3bc6e3a from cache
XXXX evicting objects/e58e16dc4e3cb687897fe9b5c885dc48e4dbf74eef2db4a1aece04a532fa837f from cache
XXXX evicting objects/27e8318bf69a50f5a9559cff444ec0ea6c5d26a51719d6a4b416cf01c8a4a1e9 from cache
XXXX evicting objects/343b3e92212013f8a1df16a977ebdef32f125d2601d30217c5098a31d9d67cbe from cache
XXXX evicting objects/369ffcbf45179ded1b05c6c10acaa2ce80cedde72d5e305fd6c38d71da051acd from cache
org.osbuild.ostree.aleph: 94ff89c985d08545f6188461a86a96dcb889eab5937b005fda76764c821ae8b3 {
  "coreos_compat": true,
  "deployment": {
    "osname": "fedora-coreos",
    "ref": "ostree/1/1/0"
  }
}
Failed to open file "/sys/fs/selinux/checkreqprot": Read-only file system
ostree container image metadata --repo=/run/osbuild/tree/ostree/repo registry:quay.io/fedora/fedora-coreos:stable
ostree container image metadata --repo=/run/osbuild/tree/ostree/repo registry:quay.io/fedora/fedora-coreos:stable --config

⏱  Duration: 0s

I almost wish there was some sort of visual indicator when we are executing things to let you know something is going on with caching in the background.
i.e. when a stage ends:
cached -> true; cache object evictions -> 4

or something.

I like the idea of dusty to have more visibility into what fscache is doing and will do a small followup in https://github.com/osbuild/osbuild/compare/main...mvo5:fscache-debug-logs?expand=1 (see the last commit there)

It would be nice to have maybe just one log statement that is shown even debug isn't enabled.

I pulled the latest version of this. Still seems to be working :)  Still excited for when it lands.

Nice! 🎉


SFSafariViewController dismisses two times after pressing Done

Description:
let handler = SafariURLHandler(viewController: vc, oauthSwift: instaOAuth)
handler.factory = { url in
     return SocialSafariViewController(url: url)
}

SocialSafariViewController has no other special function dismissing.
here is my logic
i open twitter to auth(with SFSafari) -> i press done(without authentication) -> i open twitter again -> i login to twitter account and finish authorize -> redirects to my app -> the SafariURLHandler dismisses my modal view as well(it occurs dismiss two times)
need fix
OAuth Provider (Twitter, Github, ..):
twitter / instagram
OAuth Version:

[o] Version 1
[o] Version 2

OS (Please fill the version) :

[o] iOS : 10.0.2
[ ] OSX :
[ ] TVOS :
[ ] WatchOS  :

Installation method:

[ ] Carthage
[o] CocoaPods
[ ] Manually

Library version:

[o ] head
[ ] v1.0.0
[ ] v0.6
[ ] other: (Please fill in the version you are using.)

Xcode version:

[o] 8.0 (Swift 3.0)

[ ] 8.0 (Swift 2.3)

[ ] 7.3.1

[ ] other: (Please fill in the version you are using.)

[ ] objective c

You can call on your SafariURLHandler the function clearObservers
(there is also cancel method on OAuthSwift object)
Must be call automatically by safariViewControllerDidFinish in OAuthSwiftURLHandlerType, but if there is some issue, you can put a break point
Pressing "Done" close the window without passing here?

I cannot reproduce it in demo app
I press Done for twitter first time
Then I retry twitter auth, and enter my user credential, authorize the app
I have only one dismiss
In demo a SafariURLHandler is created each time we try to connect
then SocialSafariViewController is unknown for me, you override SFSafariViewController ?
I close until there is more information


Fragments in default field values

Is there a way to define default field value (especially primary key but point valid for every column)
as a fragment (i.e. without further escaping), e.g.
field :some_id, :string, default: fragment("generate_object_id()")

or
@primary_key {:id, :string, autogenerate: false, default: fragment("generate_object_id()")}

(Code above don't work obviously)
P.S. one more example:
field :did_something_at, : datetime, default: fragment("now()")

Please use the mailing list or StackOverflow for questions/help, where a wider community will be able to help you. We reserve the issues tracker for issues only.

As far as i understand that's the issue/enhancement. There are no way of doing so (according to my understanding of source code - because of strict type validation)
And this ability would be really useful for many people

@thousandsofthem it is possible. Also, if it was a feature, we should first discuss them in the mailing list, with everyone. Please open up a discussion in the mailing list.

Ok, thanks


[Question/Features] How can I use the self dataset and model in semilearn?

I have a dataset and model that I built, and how do I use that semilearn to do SSL?
My dataset can be summarized as:

dataset
num_classes
labeled_per_samples
unlabeled_per_samples
test_per_samples
shape

AIS-dataset
50
10
120
130
1 $\times$ 256

And my model is use one-dimension signal as input (AIS-dataset).

Hi there,
We have a custom dataset example in the notebook.
For custom model, currently the codebase are not that flexible. You need to add your model into nets accordingly.


doc page link 404

Documentation page in https://github.com/ongr-io/ElasticsearchDSL/blob/master/docs/index.md
Build Queries link https://github.com/ongr-io/ElasticsearchDSL/blob/master/docs/Query/index.md opened 404

I did a bit of digging and I found that the index.md file was removed in e1de4d0d7bc58d0b947ad7085ed1eabbedb0cdf9 by @einorler
I wanted to make a PR returning it to the project, but then again, it was probably removed for a reason since that commit reorganizes a lot of other doc files. I'm just starting to use this library, so I don't (yet) feel knowledgeable enough to fix the links or re-introduce the index.md page.
These are my two cents, hope it helps. I might come back to this once I'm more familiar with the project :+1:


Revert "Remove implicit dependencies"

Reverts actions/setup-node#758

Hello @Anglemmj7. Could you please attach an issue related to this pull request? For now I'm going to close it.


Spread Operator allows Defeat of Type System

Flow Try.
type Example = {
  a: number
}

const create = (props: {[string]: mixed}): Example => ({...props})

let a = create({a: 'test'})
let n: number = a.a

This produces no errors at all. Try identifies the a.a on the last line as a number, despite the fact that it clearly contains a string.

This now errors.


Shared icon doesn't disappear in chat model for user1 if the chat is deleted from "Shared with me" by user2 (#1047 UI)

Preparation:

By user1 prepare shared link for a chat
By user2 click on the link

Steps:

By user2 delete the chat from "Shared with me"
By user1 refresh the browser and check model icon ->  Shared icon is still on model -> bug

Expected result: Shared icon disappears when all the users (which whom it was shared) delete the chat from "Shared with me" structure
Note: Please re-check for Prompts. Folders chats and folders prompts. There is the same issue!

Verified on staging successfully. Shared icon disappears from folder/model icon when all the users delete chat/prompt/folder from "Shared with me".


(test): edit clear data function

closes #94
—
Created via Raycast

@2wce it works as expected now.


DEVC-1150: added functionality to download latest devon-ide-scripts from the sidebar

I am displaying the "upgrade" banner component in the sidebar only if there is a version available which is newer than the ones setup locally on the user machine. For the info icon in the component, I am displaying the latest version locally setup in a tooltip.
TODO: Need an alternative approach to handle downloads as the current one impacts all components globally. (Success/error message on download completion has been disabled on the Home page for this reason).

@jambulud Incorporated suggested changes


phoenix.Camera.center is broken

Setting phoenix.Camera.center does not effect the camera immediately.
These features are also broken as a result: luxe.Camera.center, luxe.Camera.focus.

There are definitely some things going on that are being resolved in the new vectors (mentioned in the dev log briefly) and there are a few issues already listed for this like #110 #106
I noticed you mentioned focus as a way to follow during a movement - that's a tween and will create a new tween every time you call it, which is not ideal of course.
If you want to follow with some form of smoothing you should look at Vector weighted average or the maths counterpart it's using. Then every frame you do camera pos = weighted average( dest pos , slowness ) instead of using focus.
With regards to the center: can you run tests/features/camera_views as that uses the center and seems to still be working (press arrow keys), I'm just curious.

OK, I see now. Then I won't submit a pull request, since its probably not going to be valid once those systems are rewritten sometime around alpha-3.0. Got it.
I'll take a look at alpha-2.0 and see if there is anything I can do to help progress towards alpha-3.0.

While I was looking at the internals of luxe.Camera and phoenix.Camera for another reason, I came across the problem I was experiencing.
In phoenix/Camera.hx, line 491 in set_center:
                    pos.ignore_listeners = true;
                        pos.x = _p.x - (viewport.w/2);
                        pos.y = _p.y - (viewport.h/2);
                    pos.ignore_listeners = false;

The position vector is updated, but ignore_listeners is set to false, so the change doesn't propagate properly. A solution would be to swap the last two lines.
Another issue related to this is what appears to be an attempted work around, in luxe/Camera.hx, line 115 in set_center,
        pos = new Vector(_c.x - (viewport.w/2), _c.y - (viewport.h/2));
        return view.center = _c;

By setting luxe.Camera.pos, this partially "fixes" the above bug, but it doesn't change luxe.Camera.view.pos until the next update(), which can cause the camera to jitter. So the assignment to pos in luxe.Camera.set_center should be removed.


refactor xds resource generator interface

Attempt to avoid the boiler plate code for all generators. Does this make sense?
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[X] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

but I feel like this kind of overcomplicates things a little bit? Not really sure what the huge downside of GenerateDeltas is, I think it's a pretty clean interface

I do not think it complicates any stuff. As I mentioned it does not force to implement GenerateDeltas if it is not needed.


Control flow diagrams

Add the automatic generation of control flow diagrams for a given ir output. This functionality can be accessed using flags in the cli.

ive noticed a coupe bugs, I'll fix those

Resolves #11


[OSF-6565] Treebeard update SHA

Purpose
The treebeard source was changed to fix a bug where you couldn't shift-click and select multiple files if you scrolled. Treebeard ticket.
Changes
Changed the treebeard version that was being imported. Simple.
Side effects
Might not work on osf, I'm not able to test because of some current waterbutler issues, but it should probably go to QA or someone who can test. It should work though.
Ticket
OSF-6565

This needs merging with Develop. Did treebeard get updated again?


Update travis conf using Ubuntu 16

Currently, we are using Ubuntu Precise (12.04) in travis. We must use Ubuntu Xenial (16.04)

I want to use docker in a Windshaft-carto similar way: you can run the test in local with or without docker.

I am going to join this issue with https://github.com/CartoDB/CartoDB-SQL-API/issues/477 because the work is related


Linux Dockerfile: Use Debian Wheezy as the base image

Tested with Debian Wheezy and Ubuntu Vivid.

Great, thanks Andreas. Inspired by this I might also test with Debian 6 as that should allow support for RHEL/Centos 6.

Thanks a lot!

@papandreou I've gone a quick test with Debian 6 inside a Docker container (on Ubuntu 14.04) but it keeps freezing the CPU, so probably a no-go without a lot of extra effort.

Bummer, but cool that you tried it out. I'm still happy that Wheezy fell on the right side of the sweet spot :)


Postgres connection string not printed if connection fails because database does not exist

Environment
Liquibase Version:
3.5.5
Database Vendor & Version:
Postgres:latest (12.4)
Operating System Type & Version:
Linux Pop_OS 20.04, Docker 19.03
Description
Attempting to Debug a connection can be difficult as the connection string is only printed if the database exists.
Steps To Reproduce
The following docker-compose file (using keycloak as it is where I encountered the issue) should produce the unsuccessful connection. Piping the logs to a file, lines 223-224 should be the lines posted in the description section (assuming fresh data volumes). Setting DB_DATABASE: public should give the "connected to" example, while DB_DATABASE: keycloak (or anything else) will produce the "database does not exist" example.
version: "3"
services:
  postgres:
    image: "postgres"
    ports:
      - "5433:5432"
    environment:
      POSTGRES_DB: public
      POSTGRES_USER: admin
      POSTGRES_PASSWORD: password
      PGDATA: /var/lib/postgresql/data/pgdata
    volumes:
      - "postgres_data:/var/lib/postgresql/data/pgdata"
  postgres_wait:
    image: dadarek/wait-for-dependencies
    depends_on:
      - postgres
    command: postgres:5432

  keycloak:
    image: "quay.io/repository/keycloak/keycloak"
    depends_on:
      - postgres_wait
    ports:
      - "8080:8080"
    environment:
      KEYCLOAK_LOGLEVEL: ALL
      DB_VENDOR: POSTGRES

      DB_USER: admin
      DB_PASSWORD: password
      DB_DATABASE: keycloak
      DB_SCHEMA: public
      DB_ADDR: postgres
    volumes:
      - "keycloak_data:/keycloak"

volumes:
  postgres_data:
    driver: local
  keycloak_data:
    driver: local

Actual Behavior
No Connection string is printed. The following lines are printed instead.
keycloak_1 08:28:36,617 DEBUG [org.keycloak.connections.jpa.updater.liquibase.conn.DefaultLiquibaseConnectionProvider] (ServerService Thread Pool – 63) Added package org.keycloak.connections.jpa.updater.liquibase.lock to liquibase
postgres_1 2020-08-22 08:28:36.859 UTC [74] FATAL: database "keycloak" does not exist

Expected/Desired Behavior
Even if the database does not exist, the connection string is printed like in the following log lines, after which point the database does not exist error would then happen.
keycloak_1 07:14:31,038 DEBUG [org.keycloak.connections.jpa.updater.liquibase.conn.DefaultLiquibaseConnectionProvider] (ServerService Thread Pool – 67) Added package org.keycloak.connections.jpa.updater.liquibase.lock to liquibase
keycloak_1 07:14:31,337 TRACE [org.keycloak.connections.jpa.updater.liquibase.conn.DefaultLiquibaseConnectionProvider] (ServerService Thread Pool – 67) Connected to admin@jdbc:postgresql://postgres:5432/public?schema=keycloak

Additional Context
First Line of logs (keycloak) is located in keycloak here and the connection string is logged (via liquibase) here.
Originally reported to keycloak here but closed as successful connection string is printed by liquibase. I have grabbed the environment data to the best of my ability given i'm working with keycloak, not on keycloak.
┆Issue is synchronized with this Jira Bug by Unito

Hi @deef0000dragon1 Thanks for writing up this issue. We will add it to the list of issues that we need to process.

If this is a good first issue, I could try a shot at it :)

Hi @karuppiah7890  I would say go for it.

@molivasdat looks like this has to be handled by keycloak codebase because of the way it's coded there - the control comes to liquibase code base only when everything is successful in the connection and that's when control is given to liquibase code where it logs the connection string, but when it fails, it fails well before getting into liquibase related code for postgres
It fails at this line itself -
https://github.com/keycloak/keycloak/blob/bd5dec18303b7a8ce7d7d5669a386e18bb56c87f/model/jpa/src/main/java/org/keycloak/connections/jpa/updater/liquibase/lock/LiquibaseDBLockProvider.java#L65
by going into this code here
https://github.com/keycloak/keycloak/blob/47d6d65bbb18a5f23a5b67c2282e2090fab9e4a3/model/jpa/src/main/java/org/keycloak/connections/jpa/DefaultJpaConnectionProviderFactory.java#L371
and then exception occurring here
https://github.com/keycloak/keycloak/blob/47d6d65bbb18a5f23a5b67c2282e2090fab9e4a3/model/jpa/src/main/java/org/keycloak/connections/jpa/DefaultJpaConnectionProviderFactory.java#L377
Liquibase code is here
https://github.com/keycloak/keycloak/blob/bd5dec18303b7a8ce7d7d5669a386e18bb56c87f/model/jpa/src/main/java/org/keycloak/connections/jpa/updater/liquibase/lock/LiquibaseDBLockProvider.java#L69
And the flow for the successful connection message is
https://github.com/keycloak/keycloak/blob/bd5dec18303b7a8ce7d7d5669a386e18bb56c87f/model/jpa/src/main/java/org/keycloak/connections/jpa/updater/liquibase/lock/LiquibaseDBLockProvider.java#L69
https://github.com/keycloak/keycloak/blob/af5df1e535fb854b1e8070b9ffdd76ebee0986f8/model/jpa/src/main/java/org/keycloak/connections/jpa/updater/liquibase/conn/DefaultLiquibaseConnectionProvider.java#L136
https://github.com/liquibase/liquibase/blob/liquibase-parent-3.5.5/liquibase-core/src/main/java/liquibase/database/DatabaseFactory.java#L131
https://github.com/liquibase/liquibase/blob/liquibase-parent-3.5.5/liquibase-core/src/main/java/liquibase/database/core/PostgresDatabase.java#L116
https://github.com/liquibase/liquibase/blob/liquibase-parent-3.5.5/liquibase-core/src/main/java/liquibase/database/AbstractJdbcDatabase.java#L137
@deef0000dragon1 Thanks for reporting, but looks like keycloak has to change their code to print the connection string when the throw new RuntimeException("Failed to connect to database", e); exception occurs in their code. If they want liquibase to handle it, they still have to change their code in some way or the other to let the control to liquibase and then if liquibase doesn't do it, the issue can be raised. Ideally I think the easiest is to let them handle it by just printing the connection string when the error occurs in their code.
Also, I think there are lot of exceptions in the logs to clearly mention that the database doesn't exist, showing the connection string is just extra info, but yeah, it's good to know that the input given was wrong and hence the error. I think the logs are
still helpful enough. Just saying.

I have commented on the keycloak Jira issue too here

Thanks @karuppiah7890  for the detailed description and where the bug happens to be.  Going to close this as needing to be fixed in keycloak code.  Really appreciate the thorough details on the issue.


[Feature Request] Search

It would be useful to be able to search all journals for some text.  For the implementation, I would like to suggest to query the back-end for the search text and to select the (first) journal which contains that text or to highlight all journals' names in the left-hand sidebar which contain that search text.
For the SQL back-end, I would like to suggest to use select title from entries where content like "%{}%" as template for the query in order to determine all matching journals; in order to prevent SQL injections, you could replace all non-alphanumeric characters by the SQL placeholder % in the search text.  Note:  sqlite3 is not case sensitive regarding text search with placeholders.

I think these could be valuable as a basic search to find some keywords. We can create a search prompt and then select the first journal which content has the text.
Then after having a concept to filter the journals which we discussed in #9 , I would apply this search function as a filter criterion too to show only they journals with the text in their contents


tzdata missing

fixed by issuing:
apk add --no-cache tzdata
but obviously it will be lost when you restart the container, any permanent solution would be appreciated

You could set the container's timezone to match the host via these volume mappings.  Here is an example for Docker compose:
    volumes:
      - '/data:/home/user'
      - '/etc/timezone:/etc/timezone:ro'
      - '/etc/localtime:/etc/localtime:ro'


Reduce code complexity

Reduce code complexity: remove if statements, remove constant, remove new String
Description

Motivation and Context
Reduce code complexity
How Has This Been Tested?
Function Tests
Screenshots (if appropriate):
Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[X] My code follows the code style of this project.
[X] I have updated the documentation accordingly.

This duplicates #516
Closing this one


Option to use "lighter" lottie builds

vue3-lottie is by far the biggest chunk in my bundle. lottie-web actually exposes different builds, e.g. only including the svg renderer and it would be great if as a vue3-lottie user I would be able to control with of those builds is loaded.
On another note, the es build does not seem to properly treeshake lodash, causing a large bundle size of vue3-lottie itself.

My PR #296 partially solves this. It makes use of the proper lodash package to enable tree-shaking. I don't know much about the lottie-web stuff though. Haven't looked into that.
(I am not one of the maintainers by the way)

Related: https://github.com/airbnb/lottie-web/issues/1184

Thank you for the PR. Let me see if I can release a new version for it

Thanks, @tafelnl for your work. I just released v2.5. Should be available for download here: https://www.npmjs.com/package/vue3-lottie/v/2.5.0

This doesn't solve the original issue of adding user-selectable bundles but I can look at it in the future. Closing this issue for now


Experiments on introducing newer approach

The current approach is based on playing videos on top of webview, which is using PlatformViews (Android & iOS). And PlatformViews are known to have issues and are resource hungry too. (See here and here).
Some of the issues in current approach:

Memory Intensive #21
Not working for iOS as expected(rarely  works in 3/4 builds) #2
Problem while resizing or refreshing screens.
Couldn't adapt aspect ratios. #6
Crashes the app when rapidly navigating through screens. #8

I intend to address all these issues with a new approach. If I succeed with this new approach then:

Player will be lot more faster.
Will have more controls over the player.
Addresses all the issues listed above.
Will also support Android KitKat devices (API Level 19).

So, I will be working on this from today and won't be replying to newer issues in this repo until something is decided regarding the newer approach.
Thank you for love and support folks. :heart:
Your feedbacks will be appreciated.

Sounds Great. Please make sure it's in a way that it does not violate YouTube terms.

What technique will you be using to implement this? Can you share some details about how it will work?

Sorry but it did not work intended, was intending to draw the player on canvas and export the texture to flutter.


Bump to Jupyter Book v1.0

Addresses https://github.com/xarray-contrib/xarray-tutorial/issues/241, https://github.com/xarray-contrib/xarray-tutorial/issues/188, #88
Drops sphinx-exercise which seems unmaintained and not compatible with JupyterBook v1
Replaces #242

Exercises now rendered consistently in website and jupyterlab with gated syntax:
::::{admonition} Exercise
:class: tip

Calculate the rolling mean in 5 point bins along both latitude and longitude using
[`rolling(...).reduce`](https://docs.xarray.dev/en/stable/generated/xarray.core.rolling.DataArrayRolling.reduce.html)

:::{admonition} Solution
:class: dropdown

```python
# exactly equivalent to data.rolling(...).mean()
data.rolling(lat=5, lon=5, center=True).reduce(np.mean).plot();
```
:::
::::


BOM Not present yet

Any idea when you'll have a chance to add the BOM? I've ordered the PCB's and 5823 modules but need to do a farnell order for the other things and was waiting to see whether you uploaded the BOM.
Look forward to working on this project and hopefully contributing.

Hi Brett,
Had no idea someone was also using this! It's uploaded - also see the note on video interference in the README.

Brett,
I updated some information on the README about the interference issue. It's power supply related. I'm suspicious of the power trace, and if that is the issue I can probably get you a fix since you already ordered boards. I'm also really curious how your build turns out - if you have any questions feel free to email me at [github username] at gmail.com.


A bule border appears on startup

Microsoft PowerToys version
0.53.3
Running as admin

[ ] Yes

Area(s) with issue?
General
Steps to reproduce
On Windows Startup.
It apears a blue border on the right of the screen.

✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
It don't appear on previous version (0.53.1)

Windows 11.
My Two PCs are both have this bug.

Duplicate of #15453

Thanks for reporting this. This issue is a duplicate.
I'm linking this issue to #15453 to centralize the discussion thread for tracking.
Thanks for your help to make PowerToys a better piece of software!


ON reports successful monitoring of KVM-HV's, although it fails due to ulimit being hit

Author Name: Christian Wehrlin (Christian Wehrlin)
Original Redmine Issue: 5199, https://dev.opennebula.org/issues/5199
Original Date: 2017-06-22
Original Assignee: Vlastimil Holer

If you have a KVM-Hypervisor in your setup, that has reached, or is about to reach the ulimit, OpenNebula will probably fail trying to do the run_probes, but instead of throwing an error, it will simply report that the machine was successfully monitored.
While trying to open a remote shell manually, you'll get the Error:
@Resource temporarily unavailable@
But in the oned.log, all you just see is basically something like
@Wed Jun 21 12:36:54 2017 [Z0][InM][D]: Host node18.blafasel (23) successfully monitored.@
Of course, the quick fix is to increase the ulimits on the Hypervisor to more suitable values, nonetheless, it should be expected for OpenNebula to report an issue when trying to remote-execute run_probes

Original Redmine Comment
Author Name: Vlastimil Holer (Vlastimil Holer)
Original Date: 2017-10-30T10:10:07Z

Hello Christian,
I have tried to reproduce the problem with ONE 5.4, but couldn't. Do you have any chance to confirm it doesn't happen for you on 5.4?
What kind of resources are you limiting?
Best regards,
Vlastimil Holer

Closing because we haven't been able to reproduce it. If you can provide further information please address it in forum.opennebula.org


Trigger manual update is not working

It always looks like this:

Look like it just takes quite a while to process the queue. "Trigger manual update" just forcefully enqueues the package for an update, so when the half hourly check of all packages is already in progress, it still has to wait for that to complete. Unfortunately GitHub only allows about one request per second, so that checking all packages/branches/tags takes quite some time, even with aggressive caching.
See also https://github.com/D-Programming-Language/dub-registry/issues/92, https://github.com/D-Programming-Language/dub-registry/issues/91 and https://github.com/D-Programming-Language/dub-registry/issues/10

Now it makes sense.

I've now implemented a more detailed status message, so that it's now clear where in the queue a package currently is.
(Closing this issue)


Update chisel3 to 3.3-20200227-SNAPSHOT

Updates edu.berkeley.cs:chisel3 from 3.3-SNAPSHOT to 3.3-20200227-SNAPSHOT.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "edu.berkeley.cs", artifactId = "chisel3" } ]

labels: library-update

Nope. We don't want robots updating our managed versions.


activerecord: Apply recent changes to AR 7.2

refs:

https://github.com/ruby/gem_rbs_collection/pull/652
https://github.com/ruby/gem_rbs_collection/pull/655
https://github.com/ruby/gem_rbs_collection/pull/659
https://github.com/ruby/gem_rbs_collection/pull/660

/merge


what is 'meta' column in wallet_transaction table?

Can you explain 'meta' column in wallet_transaction table?
thank you!

I got it


Is it possible to change the marker css class on onMarkerClick or onMarkerReached events?

Hi,
I want to change the color of the marker when it is clicked or reached. Is it possible?

Do you only want to change 1 particular marker or all? What you can do is assigned a custom marker class, as provided in the markers array. Then in the callback of onMarkerReached or onMarkerClick, manually change the css of such class.
Let me know if that works.
// setup plugin
player.markers({
   onMarkerClick: function(marker) {
     // change stlye here based on marker.class
   },
   markers: [{
      time: 9.5,
      text: "marker",
      overlayText: 'overlay',
      class: 'custom-marker1'
   }]
});

I want to change the color of cliecked marker. Your way is not working for IE as it does not allow to change the CSS definitions.
It may be good feature to have such a functionality to change the css of markers when clicked.


Add static assertions to clarify incorrect use of signal

Users are sometimes baffled by the cryptic error messages of autowiring::signal when defining handler types with non-const reference arguments.  Add static asserts to clarify these errors earlier.

Awesome, thanks!

Will reopen if I can get this thing working as I expect.


Error: invalid expiresIn,jwtid option for number payload

I am trying to use the latest version of the module only I keep getting issues when trying to sign a token with the expiresIn and jwtid-ptions. Only keep getting the same error (see below) keeps complaining about number payload but why? The documents seem to suggest it can be a string. What am I doing wrong?
Error: invalid expiresIn,jwtid option for number payload
    at Object.module.exports [as sign] (/Users/Development/Projects/xyz/backend/node_modules/jsonwebtoken/sign.js:81:22)

I am using the following code:
    return jwt.sign(
        payload,            // This is the payload we want to put inside the token
        process.env.TOKEN_SECRET || "oursecret", // Secret string which will be used to sign the token,
        {
            expiresIn: '2h', // let the token expire after 2 hours of creation
            jwtid: identifier, // unique identifier (uuid.v4())
        }
    );

If you want to have as payload a number the JWT can't contain any claim in the payload, this is only supported for object payloads.
That's why exp and jti can not be added, thus you get a complain about your options expiresIn and jwtid which are requesting those claims to be added.

Ah right, now it's working. Quite confusing error message. Thank you!


move gui-related requirements in a separate file

I propose to keep only core requirements in requirements.txt. This avoid forcing Wx (strong) dependency when building from source in those environments that do not need it (e.g. Jupyter notebooks, Qt-based GUI).

@newville closing this pull request as I am working to get both Qt and Wx co-existing in the same environment.


onPress event isn't firing with Xcode 8?

I haven't traced to the root of this issue, but want to raise it to the community to see if someone has hit similar problems.
Problem: onPress event handler isn't triggered.
Observations:

It only happens with Xcode 8, for both iOS 10 and 9.3. When I moved back to Xcode 7.3 and iOS 9.3. The problem disappears
If I set a breakpoint in the hitText:withEvent:withTransform function in RNSVGGroup.m file. The problem also magically disappears
It always works on Android fine

It is very puzzling. Please let me know if anyone has similar experiences or suggestions! I really hope this is just something I did wrong.

Further investigation points to Touchable shipped with react-native. Using onPressOut instead of onPress resolved the issue. Although I'm not sure why. I will close this since this is not an issue of this lib.


Selection of Windows MS VS runtime DLLs is not determinisitic

The openjdk make process attempts various path searches for choosing the required Redist and C runtime DLLs,
see https://github.com/openjdk/jdk21/blob/890adb6410dab4606a4f26a942aed02fb2f55387/make/autoconf/toolchain_microsoft.m4#L550
The DLLs it finds can be different on different machines, for example comparing a Jenkins built JDK, with a local build using the same VS2022 version, resulted in different ucrt API DLLs.
Should we perhaps improve this?
Maybe specify directly via the configure args, eg: one I did earlier!
export CONFIGURE_ARGS="
 --with-msvcr-dll=C:/Progra~1/Micros~2/2022/Community/VC/Tools/MSVC/14.37.32822/bin/Hostx64/x64/vcruntime140.dll
 --with-msvcp-dll=C:/Progra~1/Micros~2/2022/Community/VC/Tools/MSVC/14.37.32822/bin/Hostx64/x64/msvcp140.dll
 --with-vcruntime-1-dll=C:/Progra~1/Micros~2/2022/Community/VC/Tools/MSVC/14.37.32822/bin/Hostx64/x64/vcruntime140_1.dll
 --with-ucrt-dll-dir=C:/progra~2/WI3CF2~1/10/Redist/10.0.22621.0/ucrt/DLLs/x64"

It seems strange to me that the build "attempts various path searches for choosing the required" redistributable files rather than having them as an explicitly listed and managed dependency like other dependencies via the command line options (--with-msvcp-dll and friends).
The way of reliably finding them is defined on the MS site, however, it states that the redistributable installer will upgrade, or not downgrade, as required. For reproducible builds I suspect we wish to capture a specific version of the redistributables in our base image rather than reinstall, and use them from the location identified above in the packaging.

So interesting, I just compared my two machines, configure logs, and they show they chose the same PATHS,
but I believe the UCRT DLLs were not identical. I will check again
configure: Found vcruntime140.dll at /cygdrive/c/progra~1/micros~3/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/vcruntime140.dll using well-known location in VCINSTALLDIR
checking found vcruntime140.dll architecture... ok
checking for vcruntime140.dll... /cygdrive/c/progra~1/micros~3/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/vcruntime140.dll
configure: Found msvcp140.dll at /cygdrive/c/progra~1/micros~3/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/msvcp140.dll using well-known location in VCINSTALLDIR
checking found msvcp140.dll architecture... ok
checking for msvcp140.dll... /cygdrive/c/progra~1/micros~3/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/msvcp140.dll
configure: Found vcruntime140_1.dll at /cygdrive/c/progra~1/micros~3/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/vcruntime140_1.dll using well-known location in VCINSTALLDIR
checking found vcruntime140_1.dll architecture... ok
checking for vcruntime140_1.dll... /cygdrive/c/progra~1/micros~3/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/vcruntime140_1.dll
checking for UCRT DLL dir... /cygdrive/c/progra~2/wi3cf2~1/10//redist/ucrt/dlls/x64

configure: Found vcruntime140.dll at /cygdrive/c/progra~1/micros~2/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/vcruntime140.dll using well-known location in VCINSTALLDIR
checking found vcruntime140.dll architecture... ok
checking for vcruntime140.dll... /cygdrive/c/progra~1/micros~2/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/vcruntime140.dll
configure: Found msvcp140.dll at /cygdrive/c/progra~1/micros~2/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/msvcp140.dll using well-known location in VCINSTALLDIR
checking found msvcp140.dll architecture... ok
checking for msvcp140.dll... /cygdrive/c/progra~1/micros~2/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/msvcp140.dll
configure: Found vcruntime140_1.dll at /cygdrive/c/progra~1/micros~2/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/vcruntime140_1.dll using well-known location in VCINSTALLDIR
checking found vcruntime140_1.dll architecture... ok
checking for vcruntime140_1.dll... /cygdrive/c/progra~1/micros~2/2022/commun~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/vcruntime140_1.dll
checking for UCRT DLL dir... /cygdrive/c/progra~2/wi3cf2~1/10//redist/ucrt/dlls/x64


Support external SAML2-P providers

In AccountController carry over a property for SAML from temp cookie into main cookie.

Also refactor the callback code.

Stop rendering the <html> in AuthenticationRequestHandlerWrapper (IOW, merge our iframe into any rendered html)

html and body tags are no longer being rendered around the iframe in the federated signout handling code.

I've also done some consolidation and cleanup in the AccountController. HTH @AndersAbel


GitHub stats row is wrapping on some cards

See the two cards on the left side of this screenshot:

Couldn't reproduce it. @pmonks - is this still happening now? Maybe the CSS width have been fixed already.

Yes:

Note that it only appears to happen on cards where the fork / watcher / star / contributor counts are high (multi-digit numbers).

Sorry, cannot reproduce this issue. Can you please HTML inspect the element and check if raising the CSS width of a card fixes the issue? See https://github.com/finos/finos.github.io/blob/master/css/catalogue.css#L140

May be related with the scrolling (on the right card, not shown on the left one); can you try now on http://rawgit.com/finos/finos.github.io/staging/index.html ?

The issue is fixed there, but it's created a worse problem - the cards take up too much horizontal space:


add assert protection and unittest

So is this pr ready for review?
The current changes looks good to me, but only one concern is that whether we need to check the size here as it's already checked in c/c++ implementation. Furthermore, I suppose why c/c++ implementation need to check the size is to deal with pointer type, but for more high-level programming language like python or lua, we already have very rich function data structure, so just like our implemented api interface, the simple form already contains all the information we need.

The test is consistent now.
I think checking the size in python will make the it easier to debug. And this will barely bring any additional overhead.


Merge spatial+ algo

This is a B-spline implementation, which allowed us to directly use python's GLMGam from statsmodels.
If time could try to replace the B spline with TPS (TPS did not have same attributes that would allow us to plug into GLMGam).
Also need to add statsmodels to the dependencies in the requirements yaml.
Accommodates binary exposure and continuous exposure.

Solved in #78


do not fail vmtool.cmd if buildertype is vsphere using Packer 1.5.2+

Vsphere-iso and vsphere-clone are two completely new builders that interface with esxi using the vspere api.  Originally written by Jetbrains and merged into Packer master as on 1.5.2.
The original vmware builders are still there and do the same as what they used to do for local vmware workstation and esxi builds using ssh to a apecific host.
The vsphere builders are really nice and work well.

Ah, was thinking it was related to hashicorp/packer#7212.
There were a number of conditionals in the vmware builders that allowed esx to be split up into two distinctly different builders. Regardless, glad that vsphere builders are separate from the vmware builders instead of it being a number of conditionals that were hacked into the vmware builders.


Fix: image pull secret on agent should be `open-cluster-management-im…

…age-pull-credentials`
Signed-off-by: xuezhaojun<EMAIL_ADDRESS>https://github.com/stolostron/backlog/issues/24807

/assign @eemurphy

/review @zhiweiyin318

/lgtm


Exception when registering AzureAD bearer scheme and other JWT bearer scheme

Description
When a Web API is configured as follows, where ConfigureAzureAD and ConfigureJWTBearer contain valid configuration:
services
    .AddAuthentication(JwtBearerDefaults.AuthenticationScheme)
    .AddAzureADBearer(ConfigureAzureAD)
    .AddJwtBearer(ConfigureJWTBearer);

The application crashes during startup with the following exception:
OptionsValidationException: The 'Instance' option must be provided.
    Microsoft.Extensions.Options.OptionsFactory<TOptions>.Create(string name)
    Microsoft.Extensions.Options.OptionsMonitor<TOptions>+<>c__DisplayClass11_0.<Get>b__0()
    System.Lazy<T>.ViaFactory(LazyThreadSafetyMode mode)
    System.Lazy<T>.ExecutionAndPublication(LazyHelper executionAndPublication, bool useDefaultConstructor)
    System.Lazy<T>.CreateValue()
    System.Lazy<T>.get_Value()
    Microsoft.Extensions.Options.OptionsCache<TOptions>.GetOrAdd(string name, Func<TOptions> createOptions)
    Microsoft.Extensions.Options.OptionsMonitor<TOptions>.Get(string name)
    Microsoft.AspNetCore.Authentication.AzureADJwtBearerOptionsConfiguration.Configure(string name, JwtBearerOptions options)
    Microsoft.Extensions.Options.OptionsFactory<TOptions>.Create(string name)
    Microsoft.Extensions.Options.OptionsMonitor<TOptions>+<>c__DisplayClass11_0.<Get>b__0()
    System.Lazy<T>.ViaFactory(LazyThreadSafetyMode mode)
    System.Lazy<T>.ExecutionAndPublication(LazyHelper executionAndPublication, bool useDefaultConstructor)
    System.Lazy<T>.CreateValue()
    System.Lazy<T>.get_Value()
    Microsoft.Extensions.Options.OptionsCache<TOptions>.GetOrAdd(string name, Func<TOptions> createOptions)
    Microsoft.Extensions.Options.OptionsMonitor<TOptions>.Get(string name)
    Microsoft.AspNetCore.Authentication.AuthenticationHandler<TOptions>.InitializeAsync(AuthenticationScheme scheme, HttpContext context)
    Microsoft.AspNetCore.Authentication.AuthenticationHandlerProvider.GetHandlerAsync(HttpContext context, string authenticationScheme)
    Microsoft.AspNetCore.Authentication.AuthenticationService.AuthenticateAsync(HttpContext context, string scheme)
    Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)
    Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.SetRoutingAndContinue(HttpContext httpContext)
    Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

To reproduce
Steps to reproduce the behaviour:

Create an empty ASP.NET Core app using ASP.NET Core '3.0.0-preview8.19405.7'
Install Microsoft.AspNetCore.Authentication.AzureAD.UI '3.0.0-preview8.19405.7'
Change the Startup.cs as follows:

public class Startup
{
    public void ConfigureServices(IServiceCollection services)
    {
        services
            .AddAuthentication(JwtBearerDefaults.AuthenticationScheme)
            .AddAzureADBearer(o => o.Instance = "https://login.microsoft.com/")
            .AddJwtBearer(o => { });
    }

    public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
    {
        if (env.IsDevelopment())
        {
            app.UseDeveloperExceptionPage();
        }

        app.UseRouting();

        app.UseAuthentication();

        app.UseEndpoints(endpoints =>
        {
            endpoints.MapGet("/", async context =>
            {
                await context.Response.WriteAsync("Hello World!");
            });
        });
    }
}

Run and send request to /

=> Exception during application startup
Expected behaviour
The AzureAD bearer authentication can coexist with the other JWT bearer authentication as it did in '2.2'.
Suspected issue
I suspect the regression happens in AzureADJwtBearerOptionsConfiguration.Configure.
In ASP.NET Core 3.0 this method gets called for every scheme during startup. For any other scheme name GetAzureADScheme(name) returns null which means that _azureADOptions.Get(azureADScheme) returns the default options instance. During normal setup the default options instance for AzureADOptions will never be configured as all options are configured for the specific scheme name.
Proposed fix
Check the scheme name returned by GetAzureADScheme(name) and only get the AzureADOptions if it is valid.

This was already fixed on the release/3.0 branch as part of #13480. I assume this fix will be part of the final release.


Git lens infos in css files

Hi Git Lens teams, gitlens infos are quite overflowing css files. How could i remove them ?
Thanks

Is that a standard CSS file? I can't reproduce that behavior. Is it possible you have a custom setting for gitlens.codeLens.scopesByLanguage?

I am closing this issue because it needs more information and has not had recent activity.  Please re-open this issue when more details can be provided.
Thanks!

@eamodio  It's a postcss file, sorry i didn't saw your answer

@Aarbel np -- what is the extension of the file?

@Aarbel if you add the following to your settings.json
"gitlens.codeLens.scopesByLanguage": [
    {
        "language": "css",
        "scopes": [
            "document"
        ]
    },
    {
        "language": "html",
        "scopes": [
            "document"
        ]
    },
    {
        "language": "json",
        "scopes": [
            "document"
        ]
    },
    {
        "language": "jsonc",
        "scopes": [
            "document"
        ]
    },
    {
        "language": "less",
        "scopes": [
            "document"
        ]
    },
    {
        "language": "postcss",
        "scopes": [
            "document"
        ]
    },
    {
        "language": "python",
        "symbolScopes": [
            "!Module"
        ]
    },
    {
        "language": "scss",
        "scopes": [
            "document"
        ]
    },
    {
        "language": "stylus",
        "scopes": [
            "document"
        ]
    },
    {
        "language": "vue",
        "scopes": [
            "document"
        ]
    }
]

Does it resolve the issue for you?


Refactor get_catalog.sh to allow local camel-catalog

Refactor get_catalog to allow camel-catalog from local camel-k-runtime
Remove outdated TODO from package_maven_artifacts.sh

Release Note
NONE

Yes, makes sense.


使用docker 微调的时候报错

是否已有关于该错误的issue或讨论？ | Is there an existing issue / discussion for this?

[X] 我已经搜索过已有的issues和讨论 | I have searched the existing issues / discussions

该问题是否在FAQ中有解答？ | Is there an existing answer for this in FAQ?

[X] 我已经搜索过FAQ | I have searched FAQ

当前行为 | Current Behavior
IMAGE_NAME=qwenllm/qwen:cu117
#CHECKPOINT_PATH=/path/to/Qwen-7B                # 下载的模型和代码路径
CHECKPOINT_PATH=/data/ai-models/qwen-models/qwen/Qwen-14B-Chat-Int4    # 下载的模型和代码路径 (Q-LoRA)
DATA_PATH=/data/ai-projects/yyn-qwen-7b/data                    # 准备微调数据放在 ${DATA_PATH}/example.json
OUTPUT_PATH=/data/ai-models/qwen-models/qwen/yyn          # 微调输出路径

# 默认使用主机所有GPU
DEVICE=all
# 如果需要指定用于训练的GPU，按照以下方式设置device（注意：内层的引号不可省略）
#DEVICE='"device=0,1,2,3"'

mkdir -p ${OUTPUT_PATH}

# 单卡Q-LoRA微调
docker run --gpus ${DEVICE} --rm --name qwen-finetune \
    --mount type=bind,source=${CHECKPOINT_PATH},target=/data/shared/Qwen/Qwen-7B \
    --mount type=bind,source=${DATA_PATH},target=/data/shared/Qwen/data \
    --mount type=bind,source=${OUTPUT_PATH},target=/data/shared/Qwen/output_qwen \
    --shm-size=2gb \
    -it ${IMAGE_NAME} \
    bash finetune/finetune_qlora_single_gpu.sh -m /data/shared/Qwen/Qwen-7B/ -d /data/shared/Qwen/data/alias_cn_gpt_question_data_prod.json

使用docker 进行q-lora 训练报错

==========
== CUDA ==
==========

CUDA Version 11.7.1

Container image Copyright (c) 2016-2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.

This container image and its contents are governed by the NVIDIA Deep Learning Container License.
By pulling and using the container, you accept the terms and conditions of this license:
https://developer.nvidia.com/ngc/nvidia-deep-learning-container-license

A copy of this license is made available in this container at /NGC-DL-CONTAINER-LICENSE for your convenience.

[2024-03-07 07:26:13,042] [INFO] [real_accelerator.py:161:get_accelerator] Setting ds_accelerator to cuda (auto detect)
You passed `quantization_config` to `from_pretrained` but the model you're loading already has a `quantization_config` attribute and has already quantized weights. However, loading attributes (e.g. disable_exllama, use_cuda_fp16) will be overwritten with the one you passed to `from_pretrained`. The rest will be ignored.
Warning: please make sure that you are using the latest codes and checkpoints, especially if you used Qwen-7B before 09.25.2023.请使用最新模型和代码，尤其如果你在9月25日前已经开始使用Qwen-7B，千万注意不要使用错误代码和模型。
Try importing flash-attention for faster inference...
Loading checkpoint shards: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 5/5 [01:00<00:00, 12.13s/it]
trainable params: 223,150,080 || all params: 1,780,700,160 || trainable%: 12.53159206769544
Loading data...
Formatting inputs...Skip in lazy mode
Detected kernel version 3.10.0, which is below the recommended minimum of 5.5.0; this can cause the process to hang. It is recommended to upgrade the kernel to the minimum version or higher.
Using /root/.cache/torch_extensions/py38_cu117 as PyTorch extensions root...
Creating extension directory /root/.cache/torch_extensions/py38_cu117/fused_adam...
Detected CUDA files, patching ldflags
Emitting ninja build file /root/.cache/torch_extensions/py38_cu117/fused_adam/build.ninja...
Building extension module fused_adam...
Allowing ninja to set a default number of workers... (overridable by setting the environment variable MAX_JOBS=N)
[1/3] /usr/local/cuda/bin/nvcc  -DTORCH_EXTENSION_NAME=fused_adam -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -I/usr/local/lib/python3.8/dist-packages/deepspeed/ops/csrc/includes -I/usr/local/lib/python3.8/dist-packages/deepspeed/ops/csrc/adam -isystem /usr/local/lib/python3.8/dist-packages/torch/include -isystem /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include -isystem /usr/local/lib/python3.8/dist-packages/torch/include/TH -isystem /usr/local/lib/python3.8/dist-packages/torch/include/THC -isystem /usr/local/cuda/include -isystem /usr/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_86,code=compute_86 -gencode=arch=compute_86,code=sm_86 --compiler-options '-fPIC' -O3 -DVERSION_GE_1_1 -DVERSION_GE_1_3 -DVERSION_GE_1_5 -lineinfo --use_fast_math -gencode=arch=compute_89,code=sm_89 -gencode=arch=compute_89,code=compute_89 -DBF16_AVAILABLE -U__CUDA_NO_BFLOAT16_OPERATORS__ -U__CUDA_NO_BFLOAT162_OPERATORS__ -std=c++17 -c /usr/local/lib/python3.8/dist-packages/deepspeed/ops/csrc/adam/multi_tensor_adam.cu -o multi_tensor_adam.cuda.o
FAILED: multi_tensor_adam.cuda.o
/usr/local/cuda/bin/nvcc  -DTORCH_EXTENSION_NAME=fused_adam -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -I/usr/local/lib/python3.8/dist-packages/deepspeed/ops/csrc/includes -I/usr/local/lib/python3.8/dist-packages/deepspeed/ops/csrc/adam -isystem /usr/local/lib/python3.8/dist-packages/torch/include -isystem /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include -isystem /usr/local/lib/python3.8/dist-packages/torch/include/TH -isystem /usr/local/lib/python3.8/dist-packages/torch/include/THC -isystem /usr/local/cuda/include -isystem /usr/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=0 -D__CUDA_NO_HALF_OPERATORS__ -D__CUDA_NO_HALF_CONVERSIONS__ -D__CUDA_NO_BFLOAT16_CONVERSIONS__ -D__CUDA_NO_HALF2_OPERATORS__ --expt-relaxed-constexpr -gencode=arch=compute_86,code=compute_86 -gencode=arch=compute_86,code=sm_86 --compiler-options '-fPIC' -O3 -DVERSION_GE_1_1 -DVERSION_GE_1_3 -DVERSION_GE_1_5 -lineinfo --use_fast_math -gencode=arch=compute_89,code=sm_89 -gencode=arch=compute_89,code=compute_89 -DBF16_AVAILABLE -U__CUDA_NO_BFLOAT16_OPERATORS__ -U__CUDA_NO_BFLOAT162_OPERATORS__ -std=c++17 -c /usr/local/lib/python3.8/dist-packages/deepspeed/ops/csrc/adam/multi_tensor_adam.cu -o multi_tensor_adam.cuda.o
nvcc fatal   : Unsupported gpu architecture 'compute_89'
[2/3] c++ -MMD -MF fused_adam_frontend.o.d -DTORCH_EXTENSION_NAME=fused_adam -DTORCH_API_INCLUDE_EXTENSION_H -DPYBIND11_COMPILER_TYPE=\"_gcc\" -DPYBIND11_STDLIB=\"_libstdcpp\" -DPYBIND11_BUILD_ABI=\"_cxxabi1011\" -I/usr/local/lib/python3.8/dist-packages/deepspeed/ops/csrc/includes -I/usr/local/lib/python3.8/dist-packages/deepspeed/ops/csrc/adam -isystem /usr/local/lib/python3.8/dist-packages/torch/include -isystem /usr/local/lib/python3.8/dist-packages/torch/include/torch/csrc/api/include -isystem /usr/local/lib/python3.8/dist-packages/torch/include/TH -isystem /usr/local/lib/python3.8/dist-packages/torch/include/THC -isystem /usr/local/cuda/include -isystem /usr/include/python3.8 -D_GLIBCXX_USE_CXX11_ABI=0 -fPIC -std=c++17 -O3 -std=c++17 -g -Wno-reorder -DVERSION_GE_1_1 -DVERSION_GE_1_3 -DVERSION_GE_1_5 -DBF16_AVAILABLE -c /usr/local/lib/python3.8/dist-packages/deepspeed/ops/csrc/adam/fused_adam_frontend.cpp -o fused_adam_frontend.o
ninja: build stopped: subcommand failed.
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/torch/utils/cpp_extension.py", line 1893, in _run_ninja_build
    subprocess.run(
  File "/usr/lib/python3.8/subprocess.py", line 516, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['ninja', '-v']' returned non-zero exit status 1.

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "finetune.py", line 365, in <module>
    train()
  File "finetune.py", line 358, in train
    trainer.train()
  File "/usr/local/lib/python3.8/dist-packages/transformers/trainer.py", line 1555, in train
    return inner_training_loop(
  File "/usr/local/lib/python3.8/dist-packages/transformers/trainer.py", line 1687, in _inner_training_loop
    model, self.optimizer, self.lr_scheduler = self.accelerator.prepare(
  File "/usr/local/lib/python3.8/dist-packages/accelerate/accelerator.py", line 1284, in prepare
    result = self._prepare_deepspeed(*args)
  File "/usr/local/lib/python3.8/dist-packages/accelerate/accelerator.py", line 1666, in _prepare_deepspeed
    engine, optimizer, _, lr_scheduler = deepspeed.initialize(**kwargs)
  File "/usr/local/lib/python3.8/dist-packages/deepspeed/__init__.py", line 171, in initialize
    engine = DeepSpeedEngine(args=args,
  File "/usr/local/lib/python3.8/dist-packages/deepspeed/runtime/engine.py", line 304, in __init__
    self._configure_optimizer(optimizer, model_parameters)
  File "/usr/local/lib/python3.8/dist-packages/deepspeed/runtime/engine.py", line 1208, in _configure_optimizer
    basic_optimizer = self._configure_basic_optimizer(model_parameters)
  File "/usr/local/lib/python3.8/dist-packages/deepspeed/runtime/engine.py", line 1285, in _configure_basic_optimizer
    optimizer = FusedAdam(
  File "/usr/local/lib/python3.8/dist-packages/deepspeed/ops/adam/fused_adam.py", line 94, in __init__
    fused_adam_cuda = FusedAdamBuilder().load()
  File "/usr/local/lib/python3.8/dist-packages/deepspeed/ops/op_builder/builder.py", line 458, in load
    return self.jit_load(verbose)
  File "/usr/local/lib/python3.8/dist-packages/deepspeed/ops/op_builder/builder.py", line 502, in jit_load
    op_module = load(name=self.name,
  File "/usr/local/lib/python3.8/dist-packages/torch/utils/cpp_extension.py", line 1284, in load
    return _jit_compile(
  File "/usr/local/lib/python3.8/dist-packages/torch/utils/cpp_extension.py", line 1509, in _jit_compile
    _write_ninja_file_and_build_library(
  File "/usr/local/lib/python3.8/dist-packages/torch/utils/cpp_extension.py", line 1624, in _write_ninja_file_and_build_library
    _run_ninja_build(
  File "/usr/local/lib/python3.8/dist-packages/torch/utils/cpp_extension.py", line 1909, in _run_ninja_build
    raise RuntimeError(message) from e
RuntimeError: Error building extension 'fused_adam'

期望行为 | Expected Behavior
能够正常训练
复现方法 | Steps To Reproduce
No response
运行环境 | Environment
- 环境: docker：qwenllm/qwen:cu117

备注 | Anything else?
No response

There are two issues presented in the provided log.

Detected kernel version 3.10.0, which is below the recommended minimum of 5.5.0; this can cause the process to hang. It is recommended to upgrade the kernel to the minimum version or higher.: Your operating system has an old kernel.
nvcc fatal   : Unsupported gpu architecture 'compute_89': Your GPU card is too new for cu117.

在提供的日志中存在两个问题：

Detected kernel version 3.10.0, which is below the recommended minimum of 5.5.0; this can cause the process to hang. It is recommended to upgrade the kernel to the minimum version or higher.：您的操作系统的内核版本过旧，您可能需要升级系统。
nvcc fatal   : Unsupported gpu architecture 'compute_89'：您的GPU卡对于cu117来说太新了，可以使用cu121的docker版本。


duplicate Albums label on sidebar

Duplicate Albums label in sidebar.
Clicking either of the two highlights both.
Screenshot:

Hi there, if this is a valid issue, I would like to work on this. Thank you

Hi there, if this is a valid issue, I would like to work on this. Thank you

Go ahead..remove it from one place


Error in README.md

Issue:
In how to contribute, this is given wrong, as it is used for files not folders.
5. [your-project-folder-name](https://github.com/31Sanskrati/Python_Projects/blob/main/<your-project-folder-name>)
The correct way will be
5. [your-project-folder-name](https://github.com/31Sanskrati/Python_Projects/tree/main/<your-project-folder-name>)
What to do:
Update the wrong code with the correct one

done.


getUnsubmitted and getSubmitted by userId

/cib get-hours-by-id

Branch 66-get-hours-by-id created!