Can't save a default value for new users.

After the changes to have to use master key by passing it on methods, I've encountered a problem. I've seen some similar questions but nothing with a solution for setting a value on the user class on a beforeSave scenario as I don't have a way to force the use of a masterkey on beforeSave. What options do I have?
`Parse.Cloud.beforeSave(Parse.User, function(request, response) {
var user = request.object;
if (user.isNew) {
    user.set("premium", false); //Default new user to non-premium upon creation
}
response.success();

});`

isNew is a function https://parseplatform.github.io/Parse-SDK-JS/api/classes/Parse.Object.html#methods_isNew
But that should work as is.

It only works if I change permissions and allow changes on User.
Right now I just get an error
"Permission denied for action addField on class _User"

@QB3L check how you are setting up the permissions on the _User class; I'm specifically referring to allowing or disabling adding new fields to a class. Go over the security section in the docs.
One suggestion I would make is: launch the dashboard, and try to add the "premium" property via dashboard, and run again your code. That should work.

Also, what are your CLPs defined for the _User class?

My CLPs do not permit addField and I think that is the root problem. But I wanted only the parse server via the masterkey to perform any changes on the User class to keep it extra secure.
I am worried of just enabling Public addFields as that may permit users to perhaps send a Sign Up request with a new field I may not want. I may be overreacting security wise as I am not permitting _User creation but wanted to be as secure as possible. I just wanted to know if there was a way of letting the code know on beforeSave to use masterkey and perform any changes necessary to the class.
Does the parse server (beforeSave) run with a different role so that I may add a new role on CLP perhaps and permit addField only for that role?

If the field exist, addField should let it pass through, as well the field exists in the Schéma.
Do you have some logs of the failure?

I changed the permissions (thinking this would fix it). I think something else might be going on as now I have a different error.
"Permission denied for action create on class _User"
I updated parse recently not sure what changed. Any ideas? I will check logs

If you're preventing _User class creation from CLP, that's what'a expected...

hmmm this is interesting. I don't remember making any changes to the permissions in a long time and only now this is giving me problems. I was able to create a user via Sign Up without permitting Public Create on _User.
Before the upgrade, I was able to do Parse.Cloud.UseMasterKey() (part of the reason I updated the code)...did that have a global effect perhaps and was letting me create users before?
What options do I have to create users now? Do I need to write my own cloud function to create users?

Can you provide:

screenshot or JSON of the _User CLP
code that create your users, and specify if client or server
original code with Parse.Cloud.useMasterKey()

This is the CLP as it is right now (to make it work)

Code that create users:
    var username = req.body.username;
    var password = req.body.password;
    if (username !== undefined && password !== undefined) {
        var user = new Parse.User();
        user.set("username", username);
        user.set("password", password);
        user.set("email", username);
        user.signUp(null, {
            success: function(user) {
                // Hooray! Make them login now
                res.send(jsonOk({redirect:"/signin"}));
            },
            error: function(user, error) {
                // Some error on signup
                res.status(200).send(jsonError(error.message));
            }
        });
    } else {
        res.status(400).send("Missing Parameters");
    }

beforeSave Code never had Parse.Cloud.useMasterKey() inside. What I had said is that useMasterKey() was called on other cloud functions. Hence my question that maybe it worked because it was global and I had called a cloud function before and from then on it used the master key.

Yes, useMasterKey() 'leaked' before, we should have taken steps earlier to prevent that.
However, you should not need the addFields CLP on, if the column exist on the _User table.

Cool, i'll try that out. Thanks for the help.
Is there any other straightforward way to achieve what I want without permitting Public write?
Only option I see is to create my own signup and put useMasterKey parameter on save operation.


Fix a bug for loss calculation

I think it is a bug for mini batch loss calculation. math_ops.reduce_sum(score_array) will make the 'batch' dim disappear. In the end, K.mean(score_map) doesn't work.

I signed it!

Nagging Reviewer @pavithrasv: You have been added as a reviewer to this pull request. Please add your review or reassign. It has been 14 days with no activity and the awaiting review label has been applied.

Thank you @Shanlans. Which version of TensorFlow are you using? This function has not been used in loss calculations for a while now, it was only used in a unit test and that has been removed as well.

@Shanlans Did you get a chance to look on reviewer comments? Please let us know on the update. Also request you to have a look on conflicts. Thanks!


unbound-control broken

Trying to get unbound-control to work with 1.13.0 and it doesn't seem to be working.  Trying to provide it the location of the config file, as per the unbound-control documentation, does nothing other than spit out the help information again.
root@cloudhole:/var/log# unbound-control -c /etc/unbound/unbound.conf.d/pi-hole.conf
Usage:	unbound-control [options] command
	Remote control utility for unbound server.
Options:
  -c file	config file, default is /usr/local/etc/unbound/unbound.conf
  -s ip[@port]	server address, if omitted config is used.
  -q		quiet (don't print anything if it works ok).
  -h		show this usage help.
Commands:
  start				start server; runs unbound(8)
  stop				stops the server
  reload			reloads the server
  				(this flushes data, stats, requestlist)
  stats				print statistics
  stats_noreset			peek at statistics
  stats_shm			print statistics using shm
  status			display status of server
  verbosity <number>		change logging detail
  log_reopen			close and open the logfile
  local_zone <name> <type>	add new local zone
  local_zone_remove <name>	remove local zone and its contents
  local_data <RR data...>	add local data, for example
				local_data www.example.com A <IP_ADDRESS>
  local_data_remove <name>	remove local RR data from name
  local_zones, local_zones_remove, local_datas, local_datas_remove
  				same, but read list from stdin
  				(one entry per line).
  dump_cache			print cache to stdout
  load_cache			load cache from stdin
  lookup <name>			print nameservers for name
  flush <name>			flushes common types for name from cache
  				types:  A, AAAA, MX, PTR, NS,
					SOA, CNAME, DNAME, SRV, NAPTR
  flush_type <name> <type>	flush name, type from cache
  flush_zone <name>		flush everything at or under name
  				from rr and dnssec caches
  flush_bogus			flush all bogus data
  flush_negative		flush all negative data
  flush_stats 			flush statistics, make zero
  flush_requestlist 		drop queries that are worked on
  dump_requestlist		show what is worked on by first thread
  flush_infra [all | ip] 	remove ping, edns for one IP or all
  dump_infra			show ping and edns entries
  set_option opt: val		set option to value, no reload
  get_option opt		get option value
  list_stubs			list stub-zones and root hints in use
  list_forwards			list forward-zones in use
  list_insecure			list domain-insecure zones
  list_local_zones		list local-zones in use
  list_local_data		list local-data RRs in use
  insecure_add zone 		add domain-insecure zone
  insecure_remove zone		remove domain-insecure zone
  forward_add [+i] zone addr..	add forward-zone with servers
  forward_remove [+i] zone	remove forward zone
  stub_add [+ip] zone addr..	add stub-zone with servers
  stub_remove [+i] zone		remove stub zone
		+i		also do dnssec insecure point
		+p		set stub to use priming
  forward [off | addr ...]	without arg show forward setup
				or off to turn off root forwarding
				or give list of ip addresses
  ratelimit_list [+a]		list ratelimited domains
  ip_ratelimit_list [+a]	list ratelimited ip addresses
		+a		list all, also not ratelimited
  list_auth_zones		list auth zones
  auth_zone_reload zone		reload auth zone from zonefile
  auth_zone_transfer zone	transfer auth zone from master
  view_list_local_zones	view	list local-zones in view
  view_list_local_data	view	list local-data RRs in view
  view_local_zone view name type  	add local-zone in view
  view_local_zone_remove view name  	remove local-zone in view
  view_local_data view RR...		add local-data in view
  view_local_datas view 		add list of local-data to view
  					one entry per line read from stdin
  view_local_data_remove view name  	remove local-data in view
  view_local_datas_remove view 		remove list of local-data from view
  					one entry per line read from stdin
Version 1.13.0
BSD licensed, see LICENSE in source package for details.
Report bugs to<EMAIL_ADDRESS>or https://github.com/NLnetLabs/unbound/issues
root@cloudhole:/var/log# unbound-control reload
[1607570876] unbound-control[1206:0] warning: control-enable is 'no' in the config file.
[1607570876] unbound-control[1206:0] fatal error: could not send: Connection reset by peer

Contents of /etc/unbound/unbound.conf.d/pi-hole.conf:
server:
    # If no logfile is specified, syslog is used
    # logfile: "/var/log/unbound/unbound.log"
    verbosity: 0

    interface: <IP_ADDRESS>
    port: 5335
    do-ip4: yes
    do-udp: yes
    do-tcp: yes

    # May be set to yes if you have IPv6 connectivity
    do-ip6: no

    # You want to leave this to no unless you have *native* IPv6. With 6to4 and
    # Terredo tunnels your web browser should favor IPv4 for the same reasons
    prefer-ip6: no

    # Use this only when you downloaded the list of primary root servers!
    # If you use the default dns-root-data package, unbound will find it automatically
    #root-hints: "/var/lib/unbound/root.hints"

    # Trust glue only if it is within the server's authority
    harden-glue: yes

    # Require DNSSEC data for trust-anchored zones, if such data is absent, the zone becomes BOGUS
    harden-dnssec-stripped: yes

    # Don't use Capitalization randomization as it known to cause DNSSEC issues sometimes
    # see https://discourse.pi-hole.net/t/unbound-stubby-or-dnscrypt-proxy/9378 for further details
    use-caps-for-id: no

    # Reduce EDNS reassembly buffer size.
    # Suggested by the unbound man page to reduce fragmentation reassembly problems
    edns-buffer-size: 1472

    # Perform prefetching of close to expired message cache entries
    # This only applies to domains that have been frequently queried
    prefetch: yes

    # One thread should be sufficient, can be increased on beefy machines. In reality for most users running on small networks or on a single machine, it should be unnecessary to seek performance enhancement by increasing num-threads above 1.
    num-threads: 1

    # Ensure kernel buffer is large enough to not lose messages in traffic spikes
    so-rcvbuf: 1m

    # Ensure privacy of local IP ranges
    private-address: <IP_ADDRESS>/16
    private-address: <IP_ADDRESS>/16
    private-address: <IP_ADDRESS>/12
    private-address: <IP_ADDRESS>/8
    private-address: fd00::/8
    private-address: fe80::/10

# Remote control config section.
remote-control:
    control-enable: yes

Usage:	unbound-control [options] command
What command did you intend?

Usage: unbound-control [options] command
What command did you intend?

It's quoted above, but:
root@cloudhole:/var/log# unbound-control -c /etc/unbound/unbound.conf.d/pi-hole.conf

unbound-control -c /etc/unbound/unbound.conf.d/pi-hole.conf reload

~# sudo unbound-control -c /etc/unbound/unbound.conf.d/pi-hole.conf reload
error: SSL handshake failed
140621558969152:error:1416F086:SSL routines:tls_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1913:

Unfortunately I'm not sure if that's due to something I did wrong when I packed 1.13.0 or not...

Did you follow the steps on https://nlnetlabs.nl/documentation/unbound/howto-setup/ at the bottom for Remote Control Setup?

I did, but I think something may have gone awry when I was working on the 1.9 to 1.13 package & update.  This is a testbox for me and I'm overdue to nuke and start fresh anyway.  Too many variables at this point.

Worked fine on a clean Ubuntu 20.04 install using 1.9 instead of 1.13.  So I'll have to go back and look into my 1.13 package.


Hero Image 2:1 ratio on different screen resolutions

Please add acceptance criteria.

@meols  Check when using Tall or Narrow in the hero image ratio that the hero image does not take up the whole screen on laptop.


disabling colors if terminal doesn't support colors

fixes #34
Supports windows (hopefully, untested)
When piping to files, and in zbs-torch, color characters are no longer outputted.
Old behavior:
th -e "print('hello world')" | more
ESC[0mhello worldESC[0m

New behavior:
th -e "print('hello world')" | more
hello world

cc: @Atcold this might make you happy.

Yay! :+1: (Is the trailing \t also gone?)

Hmm... Now th is always black and white... No more colours, even thought the terminal supports them...

yeah, on os x too

:disappointed:

sorry, fixed in trunk.


custom enable and disable text

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add universal binary support to OpenSSL

I added universal binary support to OpenSSL, which can be used by setting CMAKE_OSX_ARCHITECTURES in the toolchain. For example:  set(CMAKE_OSX_ARCHITECTURES "i386 x86_64" CACHE STRING "")
This scheme is very similar to the ios scheme; it builds each architecture, then combines them using the lipo command. It also supports BUILD_SHARED_LIBS, by combining the resulting dylib files using the same process.
This is also how the GTest project is working currently, so it fits in nicely I think.

I'm not so familiar with Hunter, so any advice on how to fix this would be appreciated

It's not about Hunter really but about relocatable build. You can't use hardcoded RPATH since machine on which OpenSSL is built and on which it's used may be different, hence full path may be different too. You should use RPATH with relative path. There is undocumented file(RPATH_CHANGE ...) command in CMake, usage:

https://github.com/ruslo/hunter/blob/c47c0ae5f3d12ca290b46fa339a2a55bcb389a44/cmake/projects/Qt/ep-stages/qt-install.cmake.in#L198-L203

Note that this code is for Linux and it will differ from OSX. Please read this document for details:

https://cmake.org/Wiki/CMake_RPATH_handling

I got the dylib path working correctly, but since I had to use a command to updated the shared libraries I kept the second ExternalProject_Add.

Testing:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.3347
https://travis-ci.org/ingenue/hunter/builds/341301982?utm_source=github_status&utm_medium=notification

Uploading:

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.3348
https://travis-ci.org/ingenue/hunter/builds/341310486?utm_source=github_status&utm_medium=notification

Released: https://github.com/ruslo/hunter/releases/tag/v0.20.7

Thanks!


<class 'str'>

Something is sending <class 'str'> to stdout.
Fix.

> /home/jh/.local/lib/python3.8/site-packages/imlresi/trace.py(573)hash()
-> print(type(raw))
(Pdb) s
<class 'str'>
> /home/jh/.local/lib/python3.8/site-packages/imlresi/trace.py(575)hash()
-> return hashlib.md5(
(Pdb)

Looks like the version built and uploaded to pypi was wrong. Bumped package version to 0.0.4 and  uploaded. Now all good.


Send Button/Image JSON via Watson

Hi team,
I'm a DE over in Watson Customer Engagement. We're implementing Watson Assistant for our Facebook page.  Can you advise how I can send a button or an image via Watson Assistant/Conversation response?  Essentially this json:
https://developers.facebook.com/docs/messenger-platform/send-messages/template/button
I'd like to add a Follow button to our dialog flow to make it easy for a customer to follow Watson via a messenger bot chat.
Thanks,
Michael

Hi @mbordash you should be able to directly put Facebook JSON into your dialog nodes to accomplish this.  Basically in the output object create a facebook object and then place the payload object from the link you provided.  See here: https://github.com/watson-developer-cloud/conversation-connector#interactive-messages , there is a small facebook example if you scroll past the slack one.

Nice!
-1 for me not looking hard enough.  Will give it a shot.

Just in case others want to know, this is the payload I used to send a button of type url through watson to facebook:
{   "output": {     "facebook": {       "message": {         "attachment": {           "type": "template",           "payload": {             "text": "Hi,\n\nWe have a great giveaway for you, but first we’d like for you to follow us so that you can stay updated on the latest news and trends.\n\nPlease take a moment to follow us and let me know when you've followed us by typing DONE:\n\n",             "buttons": [               {                 "url": "https://www.facebook.com/ibmcommerce/",                 "type": "web_url",                 "title": "Follow IBM Commerce",                 "messenger_extensions": "false",                 "webview_height_ratio": "full"               }             ],             "template_type": "button"           }         }       }     }   } }


XRI3 migration make speech disabled default in rig

Disabled MRTKSpeech component in controllerless rig (same as old rig)
Enabled rig's MRTKSpeech component in each scene (same as main branch)
Removed unity-test MRTKSpeech disablement no longer need because of above ^ changes.

Changes look good. Just please double check all the scenes that changed something other than the enablement of the Speech Interactor. I've marked the scene files you should double check.

Double checked all the scenes that showed extra changes than just enabling MRTKSpeech component, those extra changes in file are introduced by Unity Editor.  Just in case, I repeated the process of copying .unity file from feature/XRI3 branch latest commit -> double-checked the new controllerless rig is used -> enabled MRTKSpeech rig component.

/azp run

/azp run

/azp run


Fix minimum range difference for cols/rows in case of negative numbers

Currently a difference of -2 column/row steps will override a difference of 1 or 0.
This leads to wrong behavior e.g. in for fields that span multiple columns/rows.
Closes #413

Codecov Report

Merging #420 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #420   +/-   ##
=======================================
  Coverage   82.41%   82.41%
=======================================
  Files          86       86
  Lines        4361     4361
  Branches      808      808
=======================================
  Hits         3594     3594
  Misses        576      576
  Partials      191      191

Flag
Coverage Δ

#unittests
82.41% <ø> (ø)

Impacted Files
Coverage Δ

src/fonduer/utils/utils_table.py
79.41% <ø> (ø)


Clarify Keptn namespace rules

Install docs need good information about Keptn and namespaces.  Someplace, we say that Keptn can share a cluster but must have its own namespace, but I see that the Keptn Full Tour on Prometheus specifies that prometheus-service must be in the same namespace as Keptn, then that monitoring must be in the same namespace as prometheus...
Need to determine the truth then document it.

outdated


too many redirects

The Microsoft Dynamics 365 branding rules documentation link (which links to "https://worldready.cloudapp.net/Styleguide/Read?id=2858&topicid=44517") doesn't open. I am getting a 'too many redirects' error when I try to open that page. I've tried it in chrome, chromium edge, internet explorer, and safari and the same error shows up everywhere

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 463e4bf4-3be8-4b89-21e2-9194e264fe38
Version Independent ID: c2619d79-96f0-bd7b-e230-5e5d59f2bc3a
Content: Language and Branding - Business Central
Content Source: dev-itpro/developer/readiness/readiness-checklist-a-languange-branding.md
Service: dynamics365-business-central
GitHub Login: @v-liober
Microsoft Alias: v-liober

Hello, thanks for catching this. The referenced page doesn't work at the moment. We will update the topic with the next refresh. Thanks.


Deprecated brew tap-pin usage consistently fails CI if cache is not present

Expected behaviour
After forking, I expected the CI to work in the fork.
Actual behaviour
Builds are consistently failing due to usage of deprecated (see https://brew.sh/2019/04/04/homebrew-2.1.0/ and https://github.com/Homebrew/brew/pull/5925) brew tap-pin functionality.
The problem is in line 101 of travis_config.sh:
brew tap --list-pinned | grep -qxF cartr/qt4 || brew tap-pin cartr/qt4

In the main repo, the first part brew tap --list-pinned | grep -qxF cartr/qt4 always succeeds, I assume because the cache always kicks in.
In the fork however, it always falls through to brew tap-pin cartr/qt4 because there is no cache, and then it always fails, so cache is never created. If only I could escape this catch 22 ;)
Steps to reproduce

Fork the repo.
Enable Travis CI builds for the fork.
Trigger a build.
See it crash and burn.

Bunch of examples: https://travis-ci.com/mbdevpl/opencv-python/builds
One specific log: https://travis-ci.com/mbdevpl/opencv-python/jobs/263773575 - in this build no changes have been made in the fork whatsoever, it's simply a build of current master branch.
Solution idea
I guess one quick solution to try would be to use:
brew tap-pin cartr/qt4/formula_name_here

But unfortunately as I am unfamiliar with the opencv-python CI setup, I have no idea about what should be in the formula_name_here. Would any one of maintainers be able to provide ideas to try?

And after I solve this in my fork, I'd like to submit a PR so that other new forks don't get stuck on this issue in the future.

@skvark Thanks for merging! You might wanna trigger a new build so that cache is fully re-generated because of:
https://travis-ci.org/skvark/opencv-python/jobs/622109414

Building dependencies took too long. Restart the build in Travis UI to continue from cache.

I had click there myself once as well to finish setting up the initial cache. I think somehow the pull request might have triggered a cache rebuild for the main repo...

Ah, yes. I cleared the Travis cache because if there's a long time between builds homebrew recipes fail to update sometimes which makes the cache build fail.


Review and Merge how-to - Custom Save Button

Rewrite the how-to to move it to refguide

Looks good!


Claudia does not utilize local .npmrc file

Expected behaviour:
claudia create deploys lambda function with a private registry.

What actually happens:

packaging files	npm install --production
npm install --production failed.

the npm debug log shows
'@nike/lambda-node-logger' is not in the npm registry.

Link to a minimal, executable project that demonstrates the problem:
I am unable to do this, because the private registry is not externally accessible.

Steps to reproduce the problem:
use a local .npmrc file to link to a private registry

registry=http://artifactory.nike.com/artifactory/api/npm/npm-nike
@nike:registry=http://artifactory.nike.com/artifactory/api/npm/npm-nike/

npm install --production works from the CLI, but somehow claudia invokes it without the .npmrc file, which causes the above error.

is the .npmrc file in this case in your project directory or somewhere else?

It is in the project directory

OK, i'll fix that soon. Meanwhile, using .npmrc in your user home dir should allow you to work around this problem.

this is now available on NPM as version 2.1.3


No configuration box

The configuration instructions state "When loaded, there will be a configuration box, where you have to enter your Station ID and a Personal Token to get access to your data." The configuration box does not appear after downloading nor after restarting HA. WeatherFlow Integration does appear in HACS Integrations. I do not know whether this observation is related, but in logs there is a message "Received invalid command: mobile_app/push_notification_channel". I do not get this message on restarting HA after uninstalling WeatherFlow Integration.

HACS is just a smart way of getting non Core Integration, it is not doing anything else than downloading the files to HA. After the installation through HACS you must restart HA. Then go to 'Configuration' and 'Devices and Services'.
When on this page do a hard refresh of your browser, and then click the '+ ADD INTEGRATION' button in the lower right corner.
In the dialog search for WeatherFlow, and when found click on it, and you will see the dialog box to enter your details.

Thanks. You were right that I did not understand how to use HACS. It is
also possible that I did not have the VM for HA configured with
sufficient memory. All good now.
I found a card in Mushroom that displays Tempest temperature (and I see
that there are others as well). Are there cards that I should be aware of?
On Thu, Apr 28, 2022 at 10:14 AM Bjarne Riis @.***>
wrote:

HACS is just a smart way of getting non Core Integration, it is not doing
anything else than downloading the files to HA. After the installation
through HACS you must restart HA. Then go to 'Configuration' and 'Devices
and Services'.
When on this page do a hard refresh of your browser, and then click the '+
ADD INTEGRATION' button in the lower right corner.
In the dialog search for WeatherFlow, and when found click on it, and you
will see the dialog box to enter your details.
—
Reply to this email directly, view it on GitHub
https://github.com/briis/hass-weatherflow/issues/37#issuecomment-1112398837,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AY47CTLC37AFEMTOSKQUXW3VHK2OFANCNFSM5US4LYWA
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Jeffrey Barish

Glad it worked out for you 😁
How you want to present your data is very dependent on who you are. Most of the sensors could be presented nicely with the built-in Sensor Card and the Forecast could be presented with the built-in Weather Forecast Card. But else, search HACS for Weather and you will get a lot of options to display the data.

As the issue is resolved, I will close this.


CI: update bindings in release channels

Closes #1829

#1856  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Shoeboxam and the rest of your teammates on  Graphite


fix bug when use crane-agent first

Which issue(s) this PR fixes:
Fixes https://github.com/gocrane/crane/issues/131

/lgtm


Request-signing types + doc skeleton

@markhibberd just a start, does this look like it's going in the right direction?
Would be good to whiteboard this at some point so I'm clear on what the functionality needs to be.

Yep, this looks pretty close to what I imagined. Whiteboard would be good, Friday? But for the time being this looks good. The one thing that I didn't click to before you wrote that down is that it has to be remarkably similar to the AWS V4 algorithm, I haven't compared notes, just from memory, I didn't really click to how general it was. The question then becomes can/should we try to make it identical (with different base key-id generation), not sure if there is an advantage either way just a thought.
👍

Friday sounds good.

The question then becomes can/should we try to make it identical (with different base key-id generation), not sure if there is an advantage either way just a thought.

The version I have in mind is based on a partially-complete spec called escher which I wasn't intending to implement strictly, just use as a baseline - it's in turn based on AWSV4. I'm not sure wrt making it identical; a few of our requirements seem a little different, e.g., I'm not sure if we want to restrict scope by region or not. Then again, it could be convenient on the client side? I'm not sure how many external API clients we're expecting though.


BLD: Update CI files for py35

Currently just testing this out to see what happens in CI with Python 3.5

Coverage decreased (-0.4%) to 87.03% when pulling 41e0f406de15ca4c43da5f47795d9b1f589ff408 on py35-support into f90cd1ca0f0e15811e9b96f6859a2a8eef7fc59a on master.

Coverage decreased (-0.05%) to 87.349% when pulling db89d23a7996ce0757511bde63b282389d9659a4 on py35-support into f90cd1ca0f0e15811e9b96f6859a2a8eef7fc59a on master.

Coverage remained the same at 87.403% when pulling 59d117a24dec171c43180504971e42bd4828883a on py35-support into f90cd1ca0f0e15811e9b96f6859a2a8eef7fc59a on master.

Coverage increased (+0.009%) to 87.413% when pulling d66ebd89d583ed2908965fa476046dec5e4674f9 on py35-support into f90cd1ca0f0e15811e9b96f6859a2a8eef7fc59a on master.

Coverage increased (+0.009%) to 87.413% when pulling daaedc8c3753f5c3d98482c84bad1b2f0b13f18f on py35-support into f90cd1ca0f0e15811e9b96f6859a2a8eef7fc59a on master.

Coverage remained the same at 87.48% when pulling 518db8085018130fa174ba55d56e50354d87e566 on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage remained the same at 87.48% when pulling cf0a3f410a03251ae9ef7264c07f935b3b37c86c on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage remained the same at 87.48% when pulling cf0a3f410a03251ae9ef7264c07f935b3b37c86c on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage remained the same at 87.48% when pulling 52d7c216fb043de2c07602e1df0f87caf36e849c on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage increased (+0.03%) to 87.513% when pulling 26595bf079380b20f6fdfb1ff94e02334c4707a8 on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage increased (+0.03%) to 87.513% when pulling 26595bf079380b20f6fdfb1ff94e02334c4707a8 on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage increased (+0.03%) to 87.513% when pulling a13a8a785543e9b3beef08243cee836033ae90f7 on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage increased (+0.03%) to 87.513% when pulling a13a8a785543e9b3beef08243cee836033ae90f7 on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage increased (+0.03%) to 87.513% when pulling b6136e5dd752c2855a013df99b619bf14dd76d83 on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage increased (+0.03%) to 87.513% when pulling 6c6a7756dfb4fcbdae016fdfce61e19ca6323164 on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage increased (+0.05%) to 87.532% when pulling cfa952a69aaf6cbdf52d57104eb815359760e176 on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage increased (+0.05%) to 87.532% when pulling cfa952a69aaf6cbdf52d57104eb815359760e176 on py35-support into 5fd20e182ffba21324feed5623e4f1d9ae3caf81 on master.

Coverage remained the same at 87.532% when pulling 2096f2b614e1742763dcbae5ee6e05df63567e7f on py35-support into 35c3cf0eb72ce51a865045032a460b6644f72285 on master.

Coverage remained the same at 87.532% when pulling c375d852f0b243040e013cd813532cde4914a5ef on py35-support into 35c3cf0eb72ce51a865045032a460b6644f72285 on master.

Coverage remained the same at 87.739% when pulling be584489f99091cdca84bbe280f91f5bb9da5b5d on py35-support into ca26208569b1465cd86e8fba5c746ca96c32967e on master.

Coverage decreased (-0.05%) to 87.686% when pulling 88e34071d5fcbe79609b797238affaf20bb9bb45 on py35-support into ca26208569b1465cd86e8fba5c746ca96c32967e on master.

Coverage decreased (-0.1%) to 87.594% when pulling ecd86aa799db1c962851e0e714a9d57997f22368 on py35-support into ca26208569b1465cd86e8fba5c746ca96c32967e on master.


Processing failed in resplicing

When uploaded with a small 2 minutes mp4 having a talk, it errors in FFMPEG and in resplice.
Console output:

Moviepy - Running:
> > > "+ " ".join(cmd)
Moviepy - Command returned an error
Traceback (most recent call last):
  File "/test/filler-word-removal/server/project.py", line 143, in resplice
    ffmpeg_extract_subclip(source_video_path, start, end,
  File "/test/filler-word-removal/venv/lib/python3.11/site-packages/moviepy/video/io/ffmpeg_tools.py", line 41, in ffmpeg_extract_subclip
    subprocess_call(cmd)
  File "/test/filler-word-removal/venv/lib/python3.11/site-packages/moviepy/tools.py", line 54, in subprocess_call
    raise IOError(err.decode('utf8'))

FFMPEG Error output:

Stream mapping:
  Stream #0:0 -> #0:0 (copy)
  Stream #0:1 -> #0:1 (copy)
  Stream #0:2 -> #0:2 (copy)
[mp4 @ 0x6ebf840] Using non-standard frame rate 16/1
[mp4 @ 0x6ebf840] You requested a copy of the original timecode track so timecode metadata are now ignored
[mp4 @ 0x6ebf840] Could not find tag for codec none in stream #2, codec not currently supported in container
[out#0/mp4 @ 0x6ebf580] Could not write header (incorrect codec parameters ?): Invalid argument
Conversion failed!

And followed by the error:
Traceback (most recent call last):
  File "/test/filler-word-removal/server/project.py", line 96, in process
    self.resplice(source_video_path, split_times)
  File "/test/filler-word-removal/server/project.py", line 149, in resplice
    raise Exception('failed to split clips') from e
Exception: failed to split clips
failed to split clips

The environment is 3.11 and ffmpeg4.2.2 is installed with moviepy automatically. Also, a latest version of ffmpeg is available at /usr/loca/bin/ folder as well. All the venv and requirements are completely installed without any issues.

I'm getting the same issue - did you ever sort this @sponnusa ?

I was able to sort this, but the python script launches so many ffmpeg processes that it crashes. Nothing I've done seems to help it clean up the zombie sub processes, they only go away when I quit quant.
I used ffmpeg to strip the extra data track (timecode data in my case) - ffmpeg -i <input-file> -c copy -write_tmcd 0 <output.mp4>


Fix gemspec sanitization bug when heredoc has methods chained onto it

When dependabot is processing a gemspec, it performs some sanitization of the gemspec's content. In most situations, it handles a heredoc by replacing the heredoc's content as seen in this test.
Given a gemspec like this:
Spec.new do |s|
  s.version = "0.1.0"
  s.post_install_message = <<~DESCRIPTION
    My description
  DESCRIPTION
end

The sanitized output should look like this:
Spec.new do |s|
  s.version = "0.1.0"
  "sanitized"
end

That's the current behavior, and it meets our needs. However, if the heredoc has methods chained onto it, the sanitzation currently produces invalid Ruby code.
Given a gemspec like this:
Spec.new do |s|
  s.version = "0.1.0"
  s.post_install_message = <<~DESCRIPTION.strip.downcase
    My description
  DESCRIPTION
end

We should get the same sanitized output that we got in the previous example, but we currently get the following output instead:
Spec.new do |s|
  s.version = "0.1.0"
  "sanitized"
    My description
  DESCRIPTION
end

Later on in the dependabot-core workflow, when we ask bundler to evaluate the sanitized gemspec, it fails with a parser error because the output above is invalid Ruby code.
TODO

[x] Add a failing test to demonstrate the bug
[x] Fix the bug

Looks like this is where we try and do the sanitisation: https://github.com/dependabot/dependabot-core/blob/main/bundler/lib/dependabot/bundler/file_updater/gemspec_sanitizer.rb#L237-L242 haven't worked on this code but would be up for spending a short block on trying to fix it.

The npm_and_yarn CI job is failing due to a flaky test. That flaky test is fixed in https://github.com/dependabot/dependabot-core/pull/3229. Once https://github.com/dependabot/dependabot-core/pull/3229 is merged, I'll merge main into this branch, and that should give us a green build.

Just merged #3229 👌
On Thu, 4 Mar 2021 at 18:07, Jason Rudolph<EMAIL_ADDRESS>wrote:

The npm_and_yarn CI job is failing due to a flaky test. That flaky test is
fixed in #3229 https://github.com/dependabot/dependabot-core/pull/3229.
Once #3229 https://github.com/dependabot/dependabot-core/pull/3229 is
merged, I'll merge main into this branch, and that should give us a green
build.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dependabot/dependabot-core/pull/3220#issuecomment-790817697,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAE5RPBL55W6UFK6VXY42DTB7D7ZANCNFSM4YPT2FFA
.


*: add codegen for scripts/codegen/Boilerplate.go.txt and fix typos

cc/ @hasbro17

Test:
$ operator-sdk new test-operator
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/cmd/manager/main.go
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/pkg/apis/apis.go
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/pkg/controller/controller.go
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/pkg/build/Dockerfile
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/pkg/build/build.sh
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/deploy/role.yaml
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/deploy/role_binding.yaml
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/deploy/operator.yaml
Create /Users/fanminshi/work/src/github.com/operator-framework/test-operator/scripts/codegen/Boilerplate.go.txt
Run dep ensure ...
could not find project Gopkg.toml, use dep init to initiate a manifest
2018/09/20 14:13:58 failed to exec dep []string{"ensure", "-v"}: exit status 1
fanmins-MacBook-Pro:operator-framework fanminshi$ cat test-operator/scripts/codegen/Boilerplate.go.txt

LGTM.
I'll see if I can't refactor the codegen command to remove the need for scripts/codegen/boilerplate.go.txt altogether later on.


Conflict maxUnreachableDepartures

Bug description
As soon as I add a number of maxUnreachableDepartures (e.g. 3) it is not showing maxReachableDepartures anymore.
Module config
{
module: "MMM-PublicTransportHafas",
		position: "top_right",
			config: {
				stationID: "732872",
				stationName: "Albertinenstraße",
				direction: "",
				excludedTransportationTypes: [],
				ignoredLines: [],
				timeToStation: 7,
				showAbsoluteTime: false,
				displayLastUpdate: false,
				maxUnreachableDepartures: 3,
				maxReachableDepartures: 5,
				showColoredLineSymbols: true,
				customLineStyles: "berlin",
				showOnlyLineNumbers: true,
				showTableHeadersAsSymbols: true,
				useColorForRealtimeInfo: true,
				tableHeaderOrder: [ "line", "direction", "time" ]
				}
},

Screenshots
maxUnreachableDepartures: 3,
maxReachableDepartures: 5,

maxUnreachableDepartures: 0,
maxReachableDepartures: 5,

Additional context
It is working properly if I'm not using the option maxUnreachableDepartures

Thanks for the good description of the issue.
 Please update the module and check whether it works now.
By the way: Have you created an extra css file for berlin? The line customLineStyles:" berlin " indicates this. I would be interested in what you defined there.

Thanks for the quick response. Unfortunately the changes doesn't fixed the issue. It is still the same weird behavior. It feels it has a conflict with the timeToTravel option. You can may test it with my stationID: 732872.
Yes, I created a full stylesheet for berlin lines which include all public transportation. I'm happy to share that with you. :) Just let me know how to upload the file.

Oh, never mind. I missed to perform a npm install after git pull 😅. Everything is working as expected. Thank you.

Nice that it works 🙂

Hi Kristjan - just noticed that the issue appears again. It was working for 4-5 hours.

I'll see if I can take a closer look at it over the weekend.
Of course, I am also grateful for participation :slightly_smiling_face:

The problem was that there are very very many departures at Alexanderplatz. And therefore too many departures during the lead time.
I solved it by setting the lead time lower by default and adding a dynamic adjustment. So at stations with a lot of departures the lead time will be reduced and at stations with few departures the lead time will be increased.

Just want to say thank you! It works like charm - you rock 💪

Thanks for the motivating feedback 😀


Fix input locale issue

Description
This PR attempts to fix the locale-related issues with inputs across the Kwenta interface.
Related issue
#1596
Motivation and Context
This ensures that users in European regions do not have issues entering values in the UI.
How Has This Been Tested?
N/A
Screenshots (if appropriate):

Unfortunately, this did not change the input. Noticing different behavior between Firefox and Chrome, so browsers might forcefully overwrite the set locale.
E.g. Firefox displays 5.8995, while Chrome displays 5,8995 on the deploy for this PR (tested on Exchange)
Might need to investigate if there's a way to avoid that?

Chrome and Firefox define the locale differently.

Chrome: by the browser’s language.
Firefox: by the “lang” attribute (as @koredefashokun did).

We may try sth similar as https://github.com/yairEO/react-number-input

This has been fixed with #1842 by using text


typeIndex shapes

For SHACL and SHeX

@woutermont thank you so much for the feedback thus far!
Let me know about the open question above and then I will go in and fix the rest to streamline the file.
Afterward, I will check in the meeting if the constraints are enough and correct.

One general comment I have about TypeIndexes, and how they are used, is that we currently rely on the unspecified anti-LinkedData convention that Type Registrations will be served in the same file as the Type Index itself.
I.m.o. it would be better to specify this in a Linked Data manner, by adding an extra predicate to the Type Index shapes:
:TypeIndexShape a sh:NodeShape ;
    # ...
    sh:property [
        sh:path solid:hasTypeRegistration ;
        sh:nodeKind sh:IRI
    ] .

typeIndex:TypeIndex EXTRA a {
    # ...
    solid:hasTypeRegistration IRI .

This way, all Type Registrations are linked to from their Type Index.

Maybe have separate alternative paths for instance and instanceContainer  and set the target class (range) of instanceContainer to be ldp:Container


Add warning for bad justify input, in circuit_drawer

CHECKS:

[x] I have read the CONTRIBUTING document.
[x] I have added the tests to cover my changes.
[x] I have updated the documentation accordingly.
[x] All available test passing:

Summary current state:
PR originally tackling https://github.com/Qiskit/qiskit/issues/12089, to raise a warning for bad justify argument inputs.
The relevant code changes of this PR (+ after first review), are:

Changed the default value of justify, to "left" (previously None).
Added the corresponding DeprecationWarning, saying we will error for wrong justify arguments in the future.
Added the corresponding tests for the warning.
Some minor auto-formater reordering of imports (can be undone, if desired).

Corner cases now working better:

If the user manually passes justify=None (which ends as justify="left") we raise a warning, which before since itwas the default value, we couldn't...

If the user manually passes any justify that passes as True if justify:, but which is not a string. Since before we would have done justify.lower() to it, getting a non-personalized error message: 'X'object has no attribute 'lower'...

OUTDATED original Summary (before first review):
(before changing the default value None to "left", when only a warning was raised [except for None])
PR tackling https://github.com/Qiskit/qiskit/issues/12089, where I have added a warning, for when the justify argument is not in the three accepted cases "left", "right" and "none".

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Currently, tests are not passing due to a circular import, most likely due to using _is_valid_justify_arg, in all the files...
I have to go to work, I'll take a look later, any suggestion will be much appreciated. Because I had a couple quick ideas, but it requires moving this function definition, to places, where it doesn't feel right..

I think we should keep None as a valid argument.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

18 of 18 (100.0%)  changed or added relevant lines in 3 files are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.02%) to 89.733%

Files with Coverage Reduction
New Missed Lines
%

qiskit/visualization/circuit/circuit_visualization.py
1
73.79%

crates/qasm2/src/lex.rs
7
91.86%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
63409

Relevant Lines:
70664

💛  - Coveralls

History of the PR (context to new reviewers):
0) Original code:
if justify:
    justify = justify.lower()

# default to left
justify = justify if justify in ("right", "none") else "left"

Problems:

Any value different than  "left", "right" or "none", would be changed to "left", without raising anything...
If the user manually passes any justify with bool value True, but which is not a string.  Since we would do justify.lower() to it, getting a non-personalized error message: 'X'object has no attribute 'lower'...

1) PR first implementation:
Added a warning, for when the justify argument is not in the three accepted cases "left", "right" and "none":

if justify:
    justify = justify.lower()

if justify not in ("left", "right", "none"):
    if justify is not None:
        warn(
            f"justify must be 'left, right or none', not: '{justify}'. Default (left) will be used.",
            UserWarning,
            2,
         )
    justify = "left"

Problems:

If the user manually inputs justify=None, it would be changed to "left", without raising anything...
If the user manually passes any justify with bool value True, but which is not a string.  Since we would do justify.lower() to it, getting a non-personalized error message: 'X'object has no attribute 'lower'...

2) PR second implementation (after @Eric-Arellano review) // [current state]:
Changed the default value of justify from None to "left" in cascade up, calls the .lower() method only for strings, and instead of raising a warn(), used the argument wrapper for DeprecationWarning:
# In `QuantumCircuit` and `drawer()`:
@deprecate_arg(
    "justify",
    since="1.2.0",
    deprecation_description="Setting QuantumCircuit.draw()’s justify argument to a value other than"
    "'left', 'right', or 'none'. Default 'left' will be used. Support for invalid justify arguments",
    predicate=lambda justify: (
        not isinstance(justify, str) or justify.lower() not in ("left", "right", "none")
    ),
)
def draw(...

def _is_valid_justify_arg(justify):
    """Return True if the `justify` argument is valid."""
    if isinstance(justify, str):
        justify = justify.lower()

    return justify in ("left", "right", "none")

justify = justify.lower() if _is_valid_justify_arg(justify) else "left"

Problems:

It adds more complexity to what needs to be removed in the future deprecation...
It changes more code, making this PR deviate further from the original Issue...

Future of the PR (two proposals):
3.A) PR third implementation proposal from @1ucian0 & @kevinsung:
Go back to point "1) PR first implementation", so None is still a valid argument (equals to "left"), and to remove the complicated DeprecationWarning argument wrapper logic, which in this case instead of helping, complicates things:

if isinstance(justify, str):
    justify = justify.lower()

if justify is None:
    justify = "left"

if justify not in ("left", "right", "none"):
    warn(
        f"Setting QuantumCircuit.draw()’s justify argument to a value other than "
        "'left', 'right', 'none' or None (='left'). Default 'left' will be used. Starting "
        " in Qiskit 2.0, invalid arguments will error.",
        DeprecationWarning,
        2,
     )
    justify = "left"

+
# Improve documentation, to make clear that None, will get changed to "left"

Problems:

If the user manually inputs justify=None, it would be changed to "left", without raising anything... But this shouldn't be a major problem since, it should be documented.

3.B) PR third implementation, mix between their proposal and current state:
Remove the complex logic from the DeprecationWarning argument wrapper, but not remove the change of the default value of justify from None to "left":

if isinstance(justify, str):
    justify = justify.lower()

if justify not in ("left", "right", "none"):
    warn(
        f"Setting QuantumCircuit.draw()’s justify argument to a value other than "
        "'left', 'right' or 'none'. Default 'left' will be used. Starting in Qiskit 2.0, "
        "invalid arguments will error.",
        DeprecationWarning,
        2,
     )
    justify = "left"

+
# Change justify default value from None to "left" in cascade up

Problems:

It changes a bit more code, making this PR deviate further from the original Issue...

Just added a release note for the PR as discussed in the call, if you think:

its not necessary in the end,
some note is not in the correct section

please tell me, and I'll change it 🙌

I'm getting this error in the Preliminary tests now, due to the release note:
lint: commands[4]> pylint -rn qiskit test tools

------------------------------------
Your code has been rated at 10.00/10

lint: commands[5]> python /home/vsts/work/1/s/tools/verify_headers.py qiskit test tools examples crates
lint: commands[6]> python /home/vsts/work/1/s/tools/find_optional_imports.py
lint: commands[7]> python /home/vsts/work/1/s/tools/find_stray_release_notes.py
lint: commands[8]> reno -q lint
  docs: FAIL code 1 (606.14=setup[410.84]+cmd[24.06,171.24] seconds)
  lint: OK (673.33=setup[175.87]+cmd[39.08,2.25,0.73,53.68,397.27,0.16,0.66,0.08,3.56] seconds)
  evaluation failed :( (1279.88 seconds)

##[error]Bash exited with code '255'.

In local everything passes correctly, but I think its not checking new files...

Also, I have tried various changes I thought would solve it, but nothing worked so far.
If you have encountered this before, any help would be appreciated.

@GuillermoAbadLopez reno lint was a red herring :/ The warning is from Sphinx higher up in CI logs:

/home/vsts/work/1/s/docs/release_notes.rst:438: WARNING: Inline interpreted text or phrase reference start-string without end-string.

--
I talked more to @1ucian0 and @kevinsung we decided to indeed go back to using None as the default argument. While it makes the documentation a little less clear, Qiskit SDK tends to use None as the default like this and then set the "true default" at runtime because it gives more flexibility for the future.
For example, imagine we want to change the default of left to a new value like justified -- that is a breaking behavior change and would need a deprecation cycle. To detect when people are using the default—rather than explicitly setting ='left'—we would need to check if arg is None. But we can't do that check anymore if we've now set the default directly to be 'left'; we no longer know if you explicitly set the value or you're relying on the default.
So, please go back to using None as the default arg, which results in left being used. But, of course, still warn on otherwise invalid arguments.
Pardon the back-and-forth and thank you for persistence on this issue!

@GuillermoAbadLopez reno lint was a red herring :/ The warning is from Sphinx higher up in CI logs:

/home/vsts/work/1/s/docs/release_notes.rst:438: WARNING: Inline interpreted text or phrase reference start-string without end-string.

That makes a lot of sense, found something, thanks! 👍

No worries at all, we should do what its best for the stack, in the end!
I'll change it, but it might take a bit, since I'm going OOO for a couple of days  👍

I talked more to @1ucian0 and @kevinsung we decided to indeed go back to using None as the default argument. While it makes the documentation a little less clear, Qiskit SDK tends to use None as the default like this and then set the "true default" at runtime because it gives more flexibility for the future.
For example, imagine we want to change the default of left to a new value like justified -- that is a breaking behavior change and would need a deprecation cycle. To detect when people are using the default—rather than explicitly setting ='left'—we would need to check if arg is None. But we can't do that check anymore if we've now set the default directly to be 'left'; we no longer know if you explicitly set the value or you're relying on the default.
So, please go back to using None as the default arg, which results in left being used. But, of course, still warn on otherwise invalid arguments.
Pardon the back-and-forth and thank you for persistence on this issue!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

18 of 18 (100.0%)  changed or added relevant lines in 3 files are covered.
22 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.02%) to 89.753%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/lex.rs
4
93.13%

crates/qasm2/src/parse.rs
18
96.69%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
63571

Relevant Lines:
70829

💛  - Coveralls

Last suggestions addressed!
@Eric-Arellano @kevinsung @1ucian0

Have gone back to None as the default value for justify
Simplified the deprecation logic to a simple warn, similar to the starting one.
(Since even though the @arg_dreprecation decorator/wrapper was better for localizing the error, it seemed a bit confusing for the future maintainer that would have finally deprecated this, with single lines around to delete, that he could have missed..., now it's super simple! Also this way allows for a Regex check in the test)
I have made some final changes to the docstrings (both public and private), and updated the release note.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

18 of 18 (100.0%)  changed or added relevant lines in 2 files are covered.
13 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.006%) to 89.767%

Files with Coverage Reduction
New Missed Lines
%

crates/qasm2/src/parse.rs
6
97.61%

crates/qasm2/src/lex.rs
7
91.6%

Totals

Change from base Build<PHONE_NUMBER>:
-0.006%

Covered Lines:
64079

Relevant Lines:
71384

💛  - Coveralls


After start Scratch 3.0 it isn't work with new projects

Hello.
After start Scratch 3.0 it isn't work with new projects
https://scratch.mit.edu/projects/277289481/
https://phosphorus.github.io/#277289481
Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 YaBrowser/<IP_ADDRESS>5 Yowser/2.5 Safari/537.36

A lot of my scratch projects runs with lugs on scratch 3.0. On phosphorus the same projects work without lugs. And on smartphones too! Phosphorus is needed.
(Sorry for my English.)

Super-lagging new 3.0 s**ks

I haven't noticed any issues with scratch 3.0. People are extremely ungrateful about it. Flash isn't supported for much longer, and the scratch team have worked hard to prevent you from being riddled with security bugs.


make a single file option

idea: sometimes you just want to add a single file to a project. maybe a common make file, package.json, .gitignore, license file, etc.
in addition to templates, there could be a files directory. this would just contain a bunch of files.
tinpig -s or tinpig --single would display a list of these files - just the file names. choose one and it's copied to the current directory. no token replacement, no path selection, no manifests.
tinpig -s filename or tinpig --single filename should work as well, with or without the extension. if it finds the file it copies it directly. if not, it opens the list. example:
tinpig -s .gitignore
and you're done.

would need to prioritize arguments, what if someone types tinpig -p foo -t HTML -s .gitignore ?
which one wins?
do both?
display error?

closing now. made another note for later.


WIP: try making PR view style more like github

hello, these days , I try doing something to make PR view page more like github and has done someting,  and also have someting arn't finished, and because I am just a beginner for golang,
the code may be so low . and I have some problem which I don't know how to resolve them.
some thing have been done:

chang the review status icon to github style
add review status icons on sidebar

add review request function like github

add add UI notification for reviewer

TODO:

add commit  change  history comment like github

github example:

add email notify for push history change comment and review request  (maybe too hard for me )
update test code after all change

may be they will be down last weekend
something need help:

I don't know how to  align the icons to the right

It's necessary to block request review from PR author and themslf , but  I hvae no ideal  to do that.
the icons which is not dot is not bound wihth lines like github, I don't know how to release it.
now :

github:

bound issue: #10550

now finish push code command function :smile:

Hi, please split these as multiple PRs so that it will be easier to review and merge.

@lunny  ok,thanks for your responses.  I will split them after all work finished , this PR is just for plan and to get help , response and CI message.


Configurable threadPool in EngineBuilder

Coverage decreased (-0.04%) to 63.472% when pulling b2b58001063784c03467f23ed25b6f0d8fbcef8d on threadpool into b89df1d8566d49c0345f2ee0be34af295edf548f on master.


[BUG] Reading CSV file is giving error on browser console.

🐛 Bug Report
Reading CSV file is giving error on browser console. Below is the screenshot for same.
Please help with this issue. Can anyone share a proper example for reading data of CSV file.

duplicate of #1168 .


Version bump to 0.10.0

Please make sure the code is following contribution guidelines in CONTRIBUTING.md

[ ] : This PR has a corresponding issue open in the Repository.
[ ] : Approach is signed off on the issue.

consider adding recorded tests for these, this could have been easily caught..


broken link to app.js

"The app.js file of"
if you click on the link you get a 404.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 08836ace-1fd0-b59b-18ce-6e615fe86c5b
Version Independent ID: 193861e9-5a1c-82b1-bc92-7e68b7263662
Content: Node.js examples for Azure Cosmos DB
Content Source: articles/cosmos-db/sql-api-nodejs-samples.md
Service: cosmos-db
Sub-service: cosmosdb-sql
GitHub Login: @deborahc
Microsoft Alias: dech

@lukeb1961 Thanks for the valuable feedback. I'll assign this issue to the content author for updating the document appropriately.
@deborahc Could you please look at this issue and update the document accordingly.

Hi @lukeb1961, thank you for the feedback. We are working on updating our JavaScript SDK samples, and will be updating this page.

@deborahc could you please confirm the ETA for updating the page.

@lukeb1961 Thanks for pointing out the issue, I submitted a Fix to update the links and point the sample to the latest version. In the next iteration, we will add regions to the sample and reference region from docs instead of hardcoding. This way we can have integration between sample and doc.
We will now close this issue if there aren't further questions.
#please-close


University Of Costa Rica (UCR) added

I'm adding the "Universidad de Costa Rica", I don't know why this dissapeared but I'm adding it again.

@ZanaUCR I am sorry, the domain ucr.ac.cr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).

Thanks :,)


Blinking eyes

Hi，partrikhuber:
I installed eos on my computer and can run the example,  it was amazing. Thank you for sharing your code.
But I found some problem, when I finished reconstruction of the 3D face, I found that the rendering of the face can only detect the opening and closing of the mouth, When I blinked my eyes，the eyes of the face model did not move, why this happen? Is that the lower-resolution model do not catch the blinking of eyes?

Hi @ChriswooTalent,
There's no mechanism to detect blinking in eos. Blinking could be handled in different ways - e.g. by a separate eye/eyelid model, or blink blendshapes. It's quite an application-specific task. I suggest that if you need it, you implement whichever solution is most appropriate for your circumstances.
I think there might also be one or two related closed issues here, if you search for "eye" or "blink" or something like that.


No longer seems to work

I just got it working by changing the css selectors in scraper.py

@sakshamahluwalia could you create a pr with the updated css selectors please?

You can look at the changes I made in this commit that I made on my fork. I don't want to open a pull request since I have added other functionality which will contaminate this base project written by @lyyka


EntityTagSpec became a part of too many things

with the introduction of e2e, TED can extract entities and will be capable to extract roles and groups. It created a lot of overlap between TED, its featurizers and DIET. Which requires refactor

incorporate @joejuzl's comments in https://github.com/RasaHQ/rasa/pull/7785

I'd do it together with the whole nlu, core, featurizers refactoring


So many traceback errors.....
Rectify as soon as possible .

@Cyber-Dioxide

@Cyber-Dioxide

I've ran the script, no errors at all. Configure your internet connection.


RFP - WD Backup

Checklist

[x] The package I am requesting does not already exist on https://chocolatey.org/packages;
[x] There is no open issue for this package;
[x] The issue title starts 'RFP - ';
[x] The download URL is public and not locked behind a paywall / login;

Package Details
Software project URL : https://support.wdc.com/downloads.aspx?p=249
Direct download URL for the software / installer : https://downloads.wdc.com/wdapp/WD_Backup_1.9.7375.5719.zip
Software summary / short description: WD Backup is an easy-to-use backup application. It automatically protects your files, photos and documents with on premise backups to a WD drive as primary storage. Off-premise backups to a cloud as secondary storage for disaster recovery purpose.

I would like to pick this up

Pushed and ready for review

Package was approved yesterday. Should be clear to close this one out.

Package published.


access policy

what access is needed by databricks to spin event grid and other azure resources ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 141a682b-afaa-a36c-f3cc-baab732b38a9
Version Independent ID: 6202c305-b765-6237-fb49-18ad0fa7374c
Content: Load Files from Azure Blob storage or Azure Data Lake Storage (Gen1/Gen2) using Auto Loader - Azure Databricks
Content Source: databricks/spark/latest/structured-streaming/auto-loader.md
Service: azure-databricks
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

Thank you for your detailed feedback.  We are looking into the issue, and we will respond when we have more information.

@saurabhcummins Thanks for reaching out. To better assist on your query, could you please elaborate more on your ask/requirement?

We will now proceed to close this thread as we have not heard back from you. If there are further questions regarding this matter, please tag me in your reply and reopen the issue. We will gladly continue the discussion.


It raise EmailProcessor NameError when there is no config file.

I put the email_proccessor.rb in the lib folder and set the autoloading, but without a griddler.rb config file, for which I meant to use all the default settings. but it turned out to give me NameError, I have checked the code and found this:
if Kernel.const_defined?(:EmailProcessor)
  EmailProcessor
else
  raise NameError.new(<<-ERROR.strip_heredoc, 'EmailProcessor')
              To use Griddler, you must either define `EmailProcessor` or configure a
              different processor. See https://github.com/thoughtbot/griddler#defaults for
              more information.
  ERROR
end

So Kernel.const_defined?(:EmailProcessor) always returns false while EmailProcessor actually can be loaded. but it will return true when there is a config file, in which has such code:
config.processor_class = EmailProcessor

Here the EmailProcessor has been called, so it's loaded correctly since then and this is why it return true.
So the problem is, in the document it says the griddler.rb file is optional, which apparently is not. Please do a update to the document or change the if...else... logic or something else.
Thanks.

If the config is required, it should be called out in the README, whether or not this is intended to be changed in the future.
The line
An initializer can be created to control some of the options in Griddler.
should be changed to
An initializer *must* be created and can be used to control some of the options in Griddler.

I don't think a config file is necessary, unless I missed something. We certainly don't want it to be.
I'm closing this, but I'm listening for new comments about whether a config file is required.

Doing the griddler setup by the book (the current README) brings an unsuspecting developer to this issue.
@gabebw How a config file is unnecessary? Can griddler guess which adapter to use without the config? How the issue above can be avoided without a config file?
Thank you!

@gabebw yep, I'm getting a NameError on 1.2.1 as well.


Can i use my own grid system instead grid: { xs: 1, sm: 2, md: 3, lg: 4, all: 0 }

Hi,
In my angular 4 component i have written some grid using grid-template-columns:repeat(4, 1fr) CSS with some break points,  In desktop 4 item in tablet 3 item and mobile 1 item like this.
when i use ngx-carousel i should use, grid: { xs: 1, sm: 2, md: 3, lg: 4, all: 0 } options but i prefer using my own grid is that possible, if so how do i do that?
thanks in advance.
Tamil

@tamilvaanan that's the future plan. But currently, it doesn't support this. I will inform you if it is ready


Implement UI part of Log Search feature

Based on API response from https://github.com/hortonworks/streamline/pull/1002, UI can provide following functionalities:

Log Table Listing + Pagination
Filter on multiple components
Filter on multiple log levels
Search for logs
Add date-time picker to select from and to date-time to fetch logs.

Raised PR: https://github.com/hortonworks/streamline/pull/1037

Thanks for addressing this issue and providing the patch. Merged #1037 to master


can i buy this

can i buy this

Discord; Hasanx
Hasanx
4 Ağu 2024 Paz, saat 18:22 tarihinde Truci @.***> şunu
yazdı:

can i buy this
—
Reply to this email directly, view it on GitHub
https://github.com/S0X0S/fansite-cms/issues/1, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI2UGRD4CQZWRF2GQUHQMS3ZPZBKNAVCNFSM6AAAAABL65SMXWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DOMJXHE4TONA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

I added you

Discord; Hasanx Hasanx Posted on Sun, Aug 4, 2024 at 18:22 by Truci @.> Wrote:
…
can i buy this — Reply to this email directly, view it on GitHub <#1>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI2UGRD4CQZWRF2GQUHQMS3ZPZBKNAVCNFSM6AAAAABL65SMXWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQ2DOMJXHE4TONA . You are receiving this because you are subscribed to this thread.Message ID: @.>

are you able to accept me? I added you


Rename Create HMI Humber to HMI-humber.yml

@tatyree can you please check why this is failing?

Will do @kyliemulholland


Generator and ValueBuilders

I am using a built_redux_repatch with a dev brunch. The BuiltReduxGenerator does not recognize ValueBuilders. For a example:
ActionDispatcher<Repatch<AppState, AppStateBuilder>> repatchDispatcher;
leads to:
  final ActionDispatcher<dynamic Function(AppState, dynamic)>
      repatchDispatcher =
      new ActionDispatcher<dynamic Function(AppState, dynamic)>(
          'AppActions-repatchDispatcher');

Not generated class instead of a builder generates fine:
ActionDispatcher<Repatch<AppState, AppState>> repatchDispatcher;
leads to:
  final ActionDispatcher<dynamic Function(AppState, AppState)>
      repatchDispatcher =
      new ActionDispatcher<dynamic Function(AppState, AppState)>(
          'AppActions-repatchDispatcher');

https://github.com/davidmarne/built_redux/pull/84


[BUG] Connection Leak

There seams to be a connection leak issue when connections are left idle. Ideally if any connection that cannot be used must be closed.
Sample Code:-
import asyncio
import ssl
from opensearchpy import AsyncOpenSearch
from opensearchpy.connection import create_ssl_context
ssl_context = create_ssl_context()
ssl_context.check_hostname = False
ssl_context.verify_mode = ssl.CERT_NONE
async def run():
client = AsyncOpenSearch("", http_auth=("", ""),
verify_certs=False, ssl_context=ssl_context, maxsize=1,
ssl_show_warn=False,
headers={"securitytenant": ""})
count = 0
while True:
data = await client.get("", "myid")
count += 1
if count == 100:
await asyncio.sleep(30)
count = 0
if name == "main":
asyncio.run(run())
When we look at the lsof output after every 30 seconds
lsof | grep 9200 | wc -l
30seconds:- 16
60 seconds:- 32
90 seconds:- 48 ..
If i remove the sleep the connection count does not increase.
Any help will be appreciated
Thanks In Advance,
venugopalnaidu Ch.

This is a good catch. When this is fixed it would be great to add a test for this.

@venugopalnaiduch would you be up for taking a stab at a PR for this?

@saimedhi can you take a look?

I will work on it.

@saimedhi hi! How're are you going with the issue? Do you need help?

Hello Reffy, Sorry for not getting started on this issue sooner. It's on my to-do list. It would be fantastic if you could work on this issue.

I'll work on this issue

Hello @Refffy, I'd like to know whether you were able to reproduce this bug?

Hello @venugopalnaiduch, please refer to this example code. It might help in this scenario. As far as I understood, we can close the client session at the end of execution as given in the example.

Hi @saimedhi,
Thanks for sharing the sample code, we will try and let you know.

@ArkTZ ok, no problem! Feel free to PR and ask any questions

@Refffy, @ArkTZ  Please feel free to take up this issue and raise a PR with your proposed solution. Thanks :)


My accounts

Description
Your account or related account are forbidden to log in
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

@Awan7-del, Please send an email to<EMAIL_ADDRESS>or<EMAIL_ADDRESS>to sort out any datatracker account related issues.


Initial configuration of sixaxis controller failing

OS: ubuntu server (Trusty)
ES: precompiled debian binary and manually compiled
Running sixad I can connect the sixaxis controller and see the controller working using jstest-gtk. When I start ES I can see "1 gamepad detected, Hold A button ..." any button I press or hold does not get recognized by ES. es_log.txt states that it has added an unconfigured Playstation3 controller. Let me know if there is any more information I can provide.

I ran into this too, emulationstation would never recognize my ps3 controllers.  I managed to compile that SDL test program, and for reasons I can't explain, it detects 0 controllers when ran under my user, but 2 controllers when ran as root with sudo.  emulationstation detects them also when ran with sudo.  What I don't understand is jstest and jstest-gtk both detect them and work when NOT ran as sudo, so I guess it's not a permissions problem?
Any ideas?


➕ Add IconAlignment to new Material Buttons

Description
I have added a new property to three material buttons:

TextButton
ElevatedButton
OutlinedButton

The new property allows the user to align the icon to the left or to the right 🚀, which appears to be useful in some usages.
Related Issues
Fixes #71941
Tests
I added the following tests:

TextButton.icon is configurable when iconAlignment set to ButtonIconAlignment.start
TextButton.icon is configurable when iconAlignment set to ButtonIconAlignment.end
OutlinedButton.icon is configurable when iconAlignment set to ButtonIconAlignment.start
OutlinedButton.icon is configurable when iconAlignment set to ButtonIconAlignment.end
ElevatedButton.icon is configurable when iconAlignment set to ButtonIconAlignment.start
ElevatedButton.icon is configurable when iconAlignment set to ButtonIconAlignment.end

Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.

Should I add this functionality to old material buttons or leave them so people get encouraged to use new material buttons?

@HansMuller can you review this PR?

@YazeedAlKhalaf This will definitely need tests. Any new functionality needs tests, because otherwise we might accidentally remove the functionality without noticing. That's what the tests are for: to make sure accidental regressions don't happen.

@Hixie I added some tests for all the new buttons that should make removing the additions I did break the code so I guess that is what the tests are for! 🚀

I added all required changes, hopefully, the checks are all successful. I will request re-request review from @Hexie and hope that @HansMuller can take a look. Thanks, everybody 🚀.

To reverse the default order in which the icon and label widgets appear, why not just write
TextButton.icon(label: bar, icon: foo)

instead of
TextButton.icon(label: foo, icon: bar)

This PR seems like a rather lot of API and implementation to get the same effect?

To reverse the default order in which the icon and label widgets appear, why not just write
TextButton.icon(label: bar, icon: foo)

instead of
TextButton.icon(label: foo, icon: bar)

This PR seems like a rather lot of API and implementation to get the same effect?

To reverse the default order in which the icon and label widgets appear, why not just write

TextButton.icon(label: bar, icon: foo)

instead of

TextButton.icon(label: foo, icon: bar)

This PR seems like a rather lot of API and implementation to get the same effect?

I don't see the difference in code blocks above

To reverse the default order in which the icon and label widgets appear, why not just write

TextButton.icon(label: bar, icon: foo)

instead of

TextButton.icon(label: foo, icon: bar)

This PR seems like a rather lot of API and implementation to get the same effect?

I don't see the difference in code blocks above

To reverse the default order in which the icon and label widgets appear, why not just write
TextButton.icon(label: bar, icon: foo)

instead of
TextButton.icon(label: foo, icon: bar)

This PR seems like a rather lot of API and implementation to get the same effect?

It works but does not make sense. This new API would allow for new buttons to use it. If we create a button where the label and icon are not widgets but rather a String and an IconData type, this will make it more usable and makes a lot more sense to use in that way.

To reverse the default order in which the icon and label widgets appear, why not just write
TextButton.icon(label: bar, icon: foo)

instead of
TextButton.icon(label: foo, icon: bar)

This PR seems like a rather lot of API and implementation to get the same effect?

It works but does not make sense. This new API would allow for new buttons to use it. If we create a button where the label and icon are not widgets but rather a String and an IconData type, this will make it more usable and makes a lot more sense to use in that way.

@YazeedAlKhalaf So now that we have a patch to show how much code this takes, we have to consider the trade-offs of resolving the issue vs leaving it as-is (without this feature). (We have to do this for all features.)

Pro: It allows one to switch the direction of the icons and buttons without using TextDirection or misusing the two fields on the button.
Con: It adds a bunch of code (289 lines across multiple files), including a new enum (top-level in the API docs, which is especially expensive for when people try to find something in the docs). More code means less performance and bigger binary sizes, as well as the opportunity for more bugs, slower velocity when adding new features, and more complexity for people using Flutter.
Con: It doesn't seem to be a feature that the Material specs recommend. There's no examples of having the icons on the "end" side of a button, for instance. There's one with buttons above the text rather than to the left of the text, but that is marked as a thing to avoid doing.

Given that it's relatively easy to make buttons do this by just passing them a label that's a Row, or by swapping the icon and label parameters (a weird thing to do but it does work), or by using Directionality, I think overall the value of this change is probably not enough to warrant the cost. I understand that that is painful to hear (I've experienced this myself many times, where I'll spend a bunch of time on a branch building something only to decide that it's just not worth it :-( ).
If you agree, you can close the PR. That said, if there's something I missed, e.g. some important reason why this PR does offset its cost, please do let me know! For example, if icons and labels are more complicated to align than just swapping them around, or if this is a highly-thumbed-up issue.

@YazeedAlKhalaf So now that we have a patch to show how much code this takes, we have to consider the trade-offs of resolving the issue vs leaving it as-is (without this feature). (We have to do this for all features.)

Pro: It allows one to switch the direction of the icons and buttons without using TextDirection or misusing the two fields on the button.
Con: It adds a bunch of code (289 lines across multiple files), including a new enum (top-level in the API docs, which is especially expensive for when people try to find something in the docs). More code means less performance and bigger binary sizes, as well as the opportunity for more bugs, slower velocity when adding new features, and more complexity for people using Flutter.
Con: It doesn't seem to be a feature that the Material specs recommend. There's no examples of having the icons on the "end" side of a button, for instance. There's one with buttons above the text rather than to the left of the text, but that is marked as a thing to avoid doing.

Given that it's relatively easy to make buttons do this by just passing them a label that's a Row, or by swapping the icon and label parameters (a weird thing to do but it does work), or by using Directionality, I think overall the value of this change is probably not enough to warrant the cost. I understand that that is painful to hear (I've experienced this myself many times, where I'll spend a bunch of time on a branch building something only to decide that it's just not worth it :-( ).
If you agree, you can close the PR. That said, if there's something I missed, e.g. some important reason why this PR does offset its cost, please do let me know! For example, if icons and labels are more complicated to align than just swapping them around, or if this is a highly-thumbed-up issue.

Hi @YazeedAlKhalaf, this has not been updated in a while, and is not in a state for code review, so I am going to close it for now. If you would like to come back and continue discussing this change, feel free to re-open! Thank you for the contribution!

it's an important feature... simply adding a flag in constructor would help a lot... rather than change the widgets between icon and label (which is not good for semantics)

it's an important feature... simply adding a flag in constructor would help a lot... rather than change the widgets between icon and label (which is not good for semantics)

@Hixie

it's an important feature... simply adding a flag in constructor would help a lot... rather than change the widgets between icon and label (which is not good for semantics)

it could be fixed simply by changing icon & widget name in textbutton class to widget1 and widget2 and assign to these two final variable by system with the constraints of textdirection and iconalignment....
but it could make a big diff, eg, in pagination (< Prev 1 2 3 4 5 Next >)

The extra flag would also allow for more functionality such as putting the icon above or under the text.

yezzirrr


Cannot use ES6 modules and TypeScript

I have tried a lot of different configuration settings to be able to load my templates like so:
import myTemplateUrl from './hello-angular2-template.thtml';
angular
    .module('pd')
    .component('helloAngular2', {
        templateUrl: myTemplateUrl,
    });

However either all I get from the template import is either "undefined" or an error:
    ERROR in ./src/components/hello-angular2/hello-angular2-template.thtml
    Module parse failed: /home/sfriedrich/dev/ng-webpack/node_modules/ngtemplate-loader/index.js!/home/sfriedrich/dev/ng-webpack/node_modules/html-loader/index.js??ref--0-1!/home/sfriedrich/dev/ng-webpack/src/components/hello-angular2/hello-angular2-template.thtml Unexpected token (2:11)
    You may need an appropriate loader to handle this file type.
    | var path = '/home/sfriedrich/dev/ng-webpack/src/components/hello-angular2/hello-angular2-template.thtml';
    | var html = export default "
Angular, from templateURL!
";;
    | window.angular.module('ng').run(['$templateCache', function(c) { c.put(path, html) }]);
    | module.exports = path;
     @ ./src/components/hello-angular2/hello-angular2-component.ts 5:38-80
     @ ./src/index.ts
     @ multi (webpack)-dev-server/client?http://localhost:8375 ./src/index.ts

See example project at https://github.com/eekboom/ng-webpack (and also the stackoverflow question at https://stackoverflow.com/questions/44889493/ ).

is there any news about this? thanks

+1

Got it compiling with https://stackoverflow.com/questions/44889493/how-to-get-ngtemplate-loader-working-with-webpack-3-angular-1-typescript-and-e/46448698#46448698 (both answer and comment)


CircleCI redownloads

Is there a reason for the force_update=True introduced in https://github.com/braindecode/braindecode/commit/01aa0ce9283597e95a8263a39c70301a8e4eab0d ?
These lines https://github.com/braindecode/braindecode/blob/01aa0ce9283597e95a8263a39c70301a8e4eab0d/.circleci/config.yml#L93-L97
seem to lead to quite long downloads in case there is a example different from master branch as far as I understand.
See e.g. https://app.circleci.com/pipelines/github/braindecode/braindecode/340/workflows/75971e52-7fec-47ea-a4b9-ffdc114e2410/jobs/398/steps
Wouldn't update_path=False, force_update=False work? This is what we do inside code usually (force_update=False per default from mne), e.g.
https://github.com/braindecode/braindecode/blob/01aa0ce9283597e95a8263a39c70301a8e4eab0d/examples/plot_skorch_crop_decoding.py#L43-L45
Or will this break CircleCI completely again? Annoying to wait for long times in new pull requests always redownloading same stuff, even multiple times :/ @agramfort

give it a try. Yes it should be possible to avoid redownloads using
circleci caching

thanks that solved it


Typeform pack

Transferring the Typeform pack from st2incubator. The pack is still a bit too specific and requires some fiddling with Typeform fields and a MySQL database to set the sensor up, but it’s still mature enough to list in contrib, I think.
 This is the reason I’m not removing the pack from incubator just yet: if we want to save the chains, we have to move them elsewhere first. st2-community maybe?
Will wait for someone’s LGTM then merge.

I'm fine with that for now as long as all the tests / checks succeed.


Text values are hardcoded. No ability to add translations.

Please add the ability for localization.

@filipfonal  Can you make a PR for that?

Yes, created https://github.com/stephenjude/filament-blog/pull/11

Okay, I will check it out

I have tagged a release — https://github.com/stephenjude/filament-blog/releases/tag/0.1.6
Thank you.


Support for other languages

Hi!
I would like to ask whether viseme generation will be available for other languages apart from English and Chinese? We are currently building an application where we rely on Azure Speech for STT, TTS and visemes. There are already customers who request language support for Italian, German, French and Spanish.
Is this something that is being currently developed?
Best regards,
Rudi

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8a828b42-9517-1ff8-c98c-1c245a07d340
Version Independent ID: d4962c85-a80c-eaab-90c4-8c8a6a1fb8e7
Content: Get facial position with viseme - Azure Cognitive Services
Content Source: articles/cognitive-services/Speech-Service/how-to-speech-synthesis-viseme.md
Service: cognitive-services
Sub-service: speech-service
GitHub Login: @yulin-li
Microsoft Alias: yulili

@RealtimeGraphX
Thanks for your feedback! We will investigate and update as appropriate.

Hi @RealtimeGraphX
According to the documentation, visemes are currently supported only for the en-US (US English) neural voices. However, the neural voices are multilingual and fluent in their own language and English. If the input text in English is spoken with a Spanish accent, for example, you can use the es-ES-Elvira Neural voice. If the voice does not speak the language of the input text, the Speech service won't output synthesized audio.
For viseme generation will be available for other languages in the future, I'd recommend working closer with our support team via an [Azure support request] (https://docs.microsoft.com/en-us/azure/azure-portal/supportability/how-to-create-azure-support-request). Or you can leverage our Q&A forum by posting your issue there so our community, and MVPs can further assist you in troubleshooting this issue or finding potential workarounds.
[Teams Q&A forum] (https://docs.microsoft.com/en-us/answers/topics/46488/office-teams-windows-itpro.html) for technical questions about the configuration and administration of Microsoft Teams on Windows.
[Microsoft Teams Community forum] (https://answers.microsoft.com/en-us/msteams/forum?sort=LastReplyDate&dir=Desc&tab=All&status=all&mod=&modAge=&advFil=&postedAfter=&postedBefore=&threadType=All&isFilterExpanded=false&page=1

Hi @Naveenommi-MSFT
Thanks for your response. Using the US neural voices for other languages unfortunately yields very bad audio synthesis results, so its not really a solution.
If I understand you correctly, making viseme generation available for other languages is not being in active development right now?

@RealtimeGraphX
Thank you for Reply.
I've delegated this to content author @yulin-li, who will review it and offer their insightful opinions.

@yulin-li
Could you please review add comments on this, update as appropriate.

@yulin-li
Do you have any update on that? Or should I create an Azure support request for that question?
Thanks a lot. :-)
Best,
Rudi

Hi, sorry for the late reply. Which kind of viseme are you using? Viseme ID or blendshape?

I am using the blendshapes for animation (3D character in Unreal Engine)

OK thanks, then we can support more locales such as it-it, de-de, fr-fr, and es-es. I will update the ETA when I get.

That sounds wonderful! Really looking forward to that. Thanks a lot for the quick reaction, and yes please let me know about the progress. :-)

I noticed visemes for de-DE-KatjaNeural (female) is available but not de-DE-ConradNeural (male) - is that a known error? since the ConradNeural responds visemes as well, but just empty strings!

Hi @Zaniyar, for now ConradNeural doesn't support blendshape. But we will add it soon.

#please-close

Hi @Zaniyar, for now ConradNeural doesn't support blendshape. But we will add it soon.

Any other German male model with blendshapes?
#dont-close-yet

@RealtimeGraphX Unfortunately only female voice. Are there maybe other companies providing a viseme API for German?

@Zaniyar I am not sure about other viseme generation solutions. There must be other options. But I am sure, Microsoft is working on that. Would be sad to miss out on this opportunity.

@Zaniyar I am not sure about other viseme generation solutions. There must be other options. But I am sure, Microsoft is working on that. Would be sad to miss out on this opportunity.

at least the programmer here are not really interested into that topic - they already closed the issue lol

I tried vsiemes for some Indian languages. It works for Hindi, Tamil and Telugu but not for Bengali or Kannada. Is there a way to know for what languages they work?

We have the doc saying blendshape is supported in which languages. If you are asking for feature support, we can add them in about one month


S8 [User Story] Create API to receive inbound login token from AD

[User Story] [Epic]
Create API to receive inbound login token from AD

Epic Title
#271

User Story Title
Create API to receive inbound login token from AD

T-shirt size: S(mall), M(edium), L(arge)
M

Story Points - Fibonacci (1,2,3,5,8,13)

User Story
[Value Statement] "As a user of a certain type (specify), I want to do something (action) so I can provide business value"

Description
A short description

Business Need (the why):
from epic, if needed

Details
All the details needed to accomplish the story. Tasks - can be linked

Additional User Story
linked

Acceptance Criteria/Tests
The list of tests or criteria to be used to validate the story has been completed. May still need UAT or SIT / integration testing with other stories.

Failure
if any, fold in negative tests

Definition of Done
e.g.Passes all regression tests, Passes testing per acceptance criteria, Approved by UI team, Able to show feature in demo

UX/UI Details and/or mockups
if UI change, a mockup or description of what to change, attach image/file

Applications or Systems impacted
upstream/downstream applications/systems

Dependencies
non story dependencies

Assumptions
if any

Performance Considerations
Will the work performed as part of this story impact system performance. If there is potential for a performance hit, where would you expect it to manifest in the system.

Security Considerations
E.g., does this story involve working with Personal Identifying Information (PII)? Note any such security sensitive aspects.

QA Considerations
what might be hard to test or test setup criteria

Acrhitectural/System or Component Impacts
if we're adding something new or significantly changing architecture flag for architect review

Reverse Engineering Required
to document areas not known well by dev team

Questions/Clarifications
Create new issue (add label: question) in this repo and link to this issue

Needs an estimate. Why was the previous estimate removed?
Does this need to be in S8?
Also needs a real user story... while this certainly sounds important to have, it's not clear what user functionality is unavailable without this work. This helps us to prioritize.


Dell XPS 13 is now throttled to 95C instead of 97C

I think this is related to move to "throttled" to fix the intel throttling issue on various laptops.
While trying to use undervolt last night, I realized that something is still overriding the temperature target. Watch:
[cole@xeep:~/code/nixcfg]$ sudo undervolt --temp 97

[cole@xeep:~/code/nixcfg]$ sudo undervolt --read
temperature target: -3 (97C)
core: -99.61 mV
gpu: -75.2 mV
cache: -99.61 mV
uncore: -99.61 mV
analogio: -99.61 mV

# wait a second

[cole@xeep:~/code/nixcfg]$ sudo undervolt --read
temperature target: -5 (95C)
core: -99.61 mV
gpu: -75.2 mV
cache: -99.61 mV
uncore: -99.61 mV
analogio: -99.61 mV

And yet:
● lenovo_fix.service - Stop Intel throttling
   Loaded: loaded (/nix/store/ra5wj7nzkgyxgj5w22fbdjnyxscs9a3w-throttled-0.6/lib/systemd/system/lenovo_fix.service; enabled; vendor preset: enabled)
  Drop-In: /nix/store/ys52kwpvs7b3psrllinzlk0axrckhcs7-system-units/lenovo_fix.service.d
           └─overrides.conf
   Active: active (running) since Thu 2019-11-21 04:06:59 PST; 11h ago
 Main PID: 910 (.lenovo_fix.py-)
       IP: 0B in, 0B out
    Tasks: 2
   Memory: 34.5M
      CPU: 3.425s
   CGroup: /system.slice/lenovo_fix.service
           └─910 /nix/store/gpnm7i19lpj8p43mjrdw03d0hjalmskl-python3-3.7.5/bin/python3.7 /nix/store/ra5wj7nzkgyxgj5w22fbdjnyxscs9a3w-throttled-0.6/bin/.lenovo_fix.py-wrapped

Nov 21 04:06:59 xeep systemd[1]: Started Stop Intel throttling.
Nov 21 04:06:59 xeep lenovo_fix.py[910]: [I] Detected CPU architecture: Intel Kaby Lake (R)
Nov 21 04:06:59 xeep lenovo_fix.py[910]: [I] Loading config file.
Nov 21 04:06:59 xeep lenovo_fix.py[910]: [I] Starting main loop.

I guess it looks like throttled can do undervolting as well. Maybe I should only use one or the other.
It also appears that throttled might default to a trip target of 95C, which would explain the behavior I'm seeing.

Further, throttled's docs say that it might not be okay to run with thermald at the same time.

This might be relevant to the 9370 config, as it enables thermald and throttled.

https://github.com/NixOS/nixos-hardware/pull/127 was the PR for that


cdn.jsdelivr.net blocked can't get github-sync.umd.js

Hello, I'm trying to use the plugin but the icon to configure never appears. When I observer the network I see that I'm being prevented from loading anything from cdn.jsdelivr.net.
Is there some way to get this from any other cdn?

Actually, it looks like it isn't my corporate network blocking. Maybe Firefox...

It pings and looks up just fine:

Yeah, works just fine in Chrome. Re-open if you want but I'll use chrome.
Thanks!


Add Ecole Supérieure d'Ingénierie et d'Innovation (ESIITECH), Gabon

Add Ecole Supérieure d'Ingénierie et d'Innovation (ESIITECH), Gabon

@aristideman First stage of verification passed, official domain is esiitech-gabon.com as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@aristideman Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Ommit Category in the log message

Is there a way to ommit category information from log message.
Right now if I log information

Requested home/index

the logger will actually log

MyProject.Controllers.HomeController
Requested home/index

Obviously this is no problem in most cases but for me its just cluttering the log. I am interested only in message.
Is there a way to accomplish this without writting my own implementation of ILoggerProvider?

No, there is no builtin way of accomplishing this.

Is there any reason why the category should be logged in the message.
Since I use EventLogLogger I have downloaded all the classes that define this logger and removed the part of the code that logs category. It seems like this should be a candidate for an option in logger.

Because we think the source of the message is as important as the message itself.
We would consider it as an option if more people request it.

Not always.
If I want to, lets say, log the requested path than I am very much interested in something like:

/api/v1/waitList

What I will get is:

MyProject.v1.Controllers.WaitListController
/api/v1/waitList

I think this is redundant. Not for me but for client.
To him it means absolutely nothing. If it was an exception that is being logged than I guess it doesn't have to have any meaning to him and it would be prefered if he could give me the log entry so I can examine it. Yes! I absolutely agree that in this case it is as important as the message.
But if I want to log something along the lines of a program flow that might be of interest to my client than I  wouldn't want to clutter the log message. So for instance, if I want to log the IP address where the application has started listening than I don't want the class name.
In any case, it is not so difficult to download the EventLog code and change this one bit which is exactly what I did.


Reflect Ripper support in the latest JRuby in #ripper_supported

... so that rspec-core on JRuby <IP_ADDRESS> or later can benefit from the multiline failure snippet extraction.
I've checked if the spec passes on all JRuby 9.x.x.x.
https://travis-ci.org/rspec/rspec-support/builds/222465272

LGTM, good work as usual @yujinakayama

@yujinakayama this seems to have broken our rspec-core build https://travis-ci.org/rspec/rspec-core/jobs/222657797 and https://travis-ci.org/rspec/rspec-core/jobs/222511307 any ideas?

Will try to fix it today.