Update packages and supported ink! version

Overview (What and Why)
Dependencies and supported ink! version need to be updated to keep swanky-cli compatible with ecosystem changes
How

[x] ink! to v4
[x] all polkadotjs dependencies
[x] oclif package
[x] swanky node to v1.1.0
[x] cargo-contract to 2.X (only applies to dev container and docs)

Definition of Done

[x] Packages updated and a new version of swanky-cli released to npm and Github
[x] Dev container template updated to use the new version
[ ] docs updated

After this is done, the dev container also needs to be updated:
https://github.com/AstarNetwork/swanky-dev-container/issues/3

Everything is reviewed and merged, except the docs part, which is still in review.
Once that is merged, this can be closed.
https://github.com/AstarNetwork/astar-docs/pull/307

The doc part is merged, let's close this issue.


SyntaxError: Identifier 'to32' has already been declared

after solving that issue (so still identical setup & versions) ... I have a new problem:
truffle test

Compiling ./contracts/HTLC.sol...
Compiling ./contracts/Migrations.sol...
Compiling zeppelin-solidity/contracts/ReentrancyGuard.sol...

Compilation warnings encountered:

.../ethereum-htlc/contracts/HTLC.sol:35:5: Warning: No visibility specified. Defaulting to "public".
    function HTLC (address _recipient, bytes32 _image, uint _expirationTime) payable {
    ^
Spanning multiple lines.
,.../ethereum-htlc/contracts/Migrations.sol:14:5: Warning: No visibility specified. Defaulting to "public".
    function Migrations() {
    ^
Spanning multiple lines.
,.../ethereum-htlc/contracts/Migrations.sol:18:5: Warning: No visibility specified. Defaulting to "public".
    function setCompleted(uint completed) restricted {
    ^
Spanning multiple lines.
,.../ethereum-htlc/contracts/Migrations.sol:22:5: Warning: No visibility specified. Defaulting to "public".
    function upgrade(address newAddress) restricted {
    ^
Spanning multiple lines.
,.../ethereum-htlc/contracts/HTLC.sol:113:5: Warning: Function state mutability can be restricted to pure
    function hash (bytes32 _preimage) internal returns (bytes32 _image) {
    ^
Spanning multiple lines.

.../ethereum-htlc/test/htlc.js:34
const to32 = buffer => `0x${pad(buffer, 64, '0')}`
                                                ^^

SyntaxError: Identifier 'to32' has already been declared
    at createScript (vm.js:56:10)
    at Object.runInThisContext (vm.js:97:10)
    at Module._compile (module.js:542:28)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at /usr/lib/node_modules/truffle/node_modules/mocha/lib/mocha.js:231:27

line 16 https://github.com/functionalfoundry/ethereum-htlc/blob/a15185713b451f33a71afcc77c65616f60054c3e/test/htlc.js#L16
vs
line 32 https://github.com/functionalfoundry/ethereum-htlc/blob/a15185713b451f33a71afcc77c65616f60054c3e/test/htlc.js#L34

as to32 was only used in line 110, I commented out line 16.
that solved that.


test user story

### Tasks
- [ ] https://github.com/octo-org/octo-repo/issues/45
- [ ] Draft issue title


Clarify gossip limits

In the gossip specification, the GOSSIP_MAX_SIZE constant is specified for the uncompressed payload size in the gossipsub message. MAX_CHUNK_SIZE serves the same purpose for req/resp and this PR unifies the two constants under MAX_PAYLOAD_SIZE to simplify maintenance.
This PR clarifies how this limit applies to the various fields of the gossipsub message and provides additional limits derived from it that allow clients to more aggressively discard messages.
In particular, clients are allowed to impose more strict limits on topics such as attestation and aggregates - an Attestation for example takes no more than ~485 bytes (to be verified!), far below the 10mb limit, though implicitly clients should already see these limits imposed as rejections by their SSZ decoder - this clarification mainly highlights the possibilty to perform this check earlier in the process.

I understand from a purely spec perspective the GOSSIP_MAX_SIZE definition is clear for readers and may help pose limits on derived consensus blocks.
However for implementers, it might be nice to specify GOSSIP_MAX_SIZE more intuitively, as the maximum size of the protobuf message we can receive on gossipsub. Because Protobuf initially gives us the varint of the payload size, implementers can then just use this constant to instantly filter gossipsub messages.
With the current definition, which is defined only on the data field, implementers have to work out the total payload size in order to do this initial filtering check (which arguably is the most important). i.e they will have to take this max data size, add the expected size of the other protobuf field elements and also add the protobuf encoding overhead. I imagine this is highly prone to error and will leave clients implementing different total sizes.
I suggest instead, we define the GOSSIP_MAX_SIZE as the total protobuf message size each implementation accepts. Then if we like, we can derive from that, the max data field size, the max consensus block size etc.
This way, all implementations will have the same total upper bound of message size being transmitted in gossipsub messages. It is easily checked, by the first few bytes of the message being sent (the protobuf varint).

This way, all implementations will have the same total upper bound of message size being transmitted in gossipsub messages.

I kind of agree that it would be nice and simple to go with the total protobuf size, but it has a few problems:

we need to have the same limit on Req/Resp for the payload (so we can send or not send payloads of the same size in both protocols) - the encoding overhead here is different.
we need a fixed upper bound on the uncompressed message size is to limit the potential for a decompression bomb
the protobuf is actually not just the payload but part of the full gossipsub envelope, which might hold control messages as well - this overhead might change with libp2p versions, so it feels more relevant to specify the limit in terms of what application payload sizes we want to support (ie how big the blocks can be).

I see two strategies we can take:

derive a precise upper bound based on the maximum theoretical size of the minimal encoding of each field, for a gossipsub message that holds only this large payload and no other control struff - this PR starts this journey by specifying an upper limit on the data field
wing it and say maxlen(data) + 1kb or something like that - certainly is easier to specify.

Yeah. Agreed.
Perhaps to save everyone time, and to make sure all clients implement the same thing and we are not prone to mistakes due to wild calculations, we specify a few constants:

Max Uncompressed Block Size
Max Compressed Block Size
Max Gossipsub protobuf message
Max RPC Chunk Size

Then each implementor doesn't have to make up their own calculations + fudge factors and we don't get weird mismatch of message transmissions when we approach these limits?
I don't mind adding some fudge factor/buffer (like the 1kb you suggested) to handle the max sizes, its easy and everyone can implement it.

I like the idea of having all of these well defined so they're consistent.

Perhaps to save everyone time,

022bb22 adds functions for computing these derived limits as well as the suggested 1kb fudge factor, in anticipation of coming up with a better way of limiting the maximimum block size
Something to consider for the future is that the topic takes space from the fudge factor - we must be careful not to create massive topis or we'll exceed this fudge factor. We don't have a common fixed upper limit on topic lengths - instead, clients are expected to reject unknown topics which effectively limits their upper-bound size.

Max RPC Chunk Size

RPC already has strict fixed upper limits on everything - we can be a lot more strict there because we use chunked snappy encoding which limits size of any one "RPC frame" to 64kb + some small constant and there is no "additonal" framing to consider (ie no mixing with control messages and whatnot).
We also already had in place the max compressed and max uncompressed sizes based on the same "worst case snappy" encoding - I've updated the spec to use the same functions and constants for both, for clarity.

would if I could ;) Invited you for write access instead.

It should be good now 👍 I initially thought it was a caching issue but it turns out that new functions (max_compressed_len and max_message_size) are included in the pyspec and they had some linting issues. I fixed their indentations & type annotations. And then I ran into a caching issue and had to bump the cache key anyway 😅

The Bellatrix spec at specs/bellatrix/p2p-interface.md also mentioned GOSSIP_MAX_SIZE. Should that be edited as well?


[hotfix] Fix the checkstyle of fluss

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add prepocessed path query to input. Fixes #1636

Signed-off-by: Matej Vetrak<EMAIL_ADDRESS>

Thanks for the review. I've tried to fix the issues. Let me know if something needs to be changed/added.


Get the PID from job execution

@peppeocchi  The unit testing weren't passed successfully due to there uses an output to get the PID. Any idea on this? I can reset the output just after execution anyway.

@peppeocchi, can you please add it to the project?

@adarmanto, looks like the fix does not return the process id of the php process. It returns the process id of the sh process. If you try to kill the sh process, the php process is still running.

@saschanos it has been a long, and also as noticed my changes also blocked by travis CI, I am happy if you have a better approach on this and cancel this PR.

@adarmanto thanks for your PR and sorry if my reply comes so late, I just didn't have time yet to check it but of course I can't merge it untile the tests are all pass (the risk is to break somebody else implementation by doing so). If you can make the test pass I'll be happy to merge it

@peppeocchi, are you still working on the project?

@saschanos yes I am. If you're wondering why I haven't merged this PR it's because 2 tests are failing and breaking existing functionalities.

@peppeocchi, thank you so much :).

https://github.com/adamz01h/php-cron-scheduler
I have implemented using a PID written to the lock file to check running processes. If the spawned PID does not match the script that its running it will assume it died and spin up a new instance.


Safe handler dictionary iteration

I got this stack trace while running tests. I imagine it is a very rare race condition:
Can we make the handler data object safe for multi-threading?
tests/e2e/inprocess/grpc/test_inprocess_grpc_reconnect.py::test_provider_unavailable
  /Users/c.bailey/Library/Application Support/hatch/env/virtual/openfeature-provider-flagd/2sJ2q5Uj/openfeature-provider-flagd/lib/python3.9/site-packages/_pytest/threadexception.py:77: PytestUnhandledThreadExceptionWarning: Exception in thread Thread-3

  Traceback (most recent call last):
    File "/Users/c.bailey/.pyenv/versions/3.9.13/lib/python3.9/threading.py", line 980, in _bootstrap_inner
      self.run()
    File "/Users/c.bailey/.pyenv/versions/3.9.13/lib/python3.9/threading.py", line 917, in run
      self._target(*self._args, **self._kwargs)
    File "/Users/c.bailey/Source/python-sdk-contrib/providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/connector/grpc_watcher.py", line 95, in sync_flags
      self.provider.emit_provider_error(
    File "/Users/c.bailey/Library/Application Support/hatch/env/virtual/openfeature-provider-flagd/2sJ2q5Uj/openfeature-provider-flagd/lib/python3.9/site-packages/openfeature/provider/provider.py", line 81, in emit_provider_error
      self.emit(ProviderEvent.PROVIDER_ERROR, details)
    File "/Users/c.bailey/Library/Application Support/hatch/env/virtual/openfeature-provider-flagd/2sJ2q5Uj/openfeature-provider-flagd/lib/python3.9/site-packages/openfeature/provider/provider.py", line 87, in emit
      run_handlers_for_provider(self, event, details)
    File "/Users/c.bailey/Library/Application Support/hatch/env/virtual/openfeature-provider-flagd/2sJ2q5Uj/openfeature-provider-flagd/lib/python3.9/site-packages/openfeature/_event_support.py", line 75, in run_handlers_for_provider
      for client in _client_handlers:
  RuntimeError: dictionary changed size during iteration

    warnings.warn(pytest.PytestUnhandledThreadExceptionWarning(msg))

Relates to https://github.com/open-feature/python-sdk/issues/96.
@colebaileygit would this be something you would be willing to help with? FYI @federicobond @gruebel @toddbaert

Thanks for reporting @colebaileygit, it's nice to have an existence proof for the thread-safety issues we knew were there.

I wrote a test that can reproduce the issue 100% of the time on my computer and implemented some locks to prevent concurrent access to the event handler dictionaries. See https://github.com/open-feature/python-sdk/pull/329

There is still quite a lot of thread-safety work to be done with other methods, particularly in the openfeature.api module.

I think we can mark this particular issue as resolved.


⚠ ClamAV has degraded performance

In fb6b426, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 442 ms

Resolved: ClamAV performance has improved in 265f94b.


AudioPlayer Seek File, Playback Progress Block, Convenience Methods

AudioPlayer seek to play audio from specific time
Added playback progress block via a DisplayLink class (useful for updating UI components)
And some helper methods like duration, sampleRate, and current (playback time)

TO DO:

Seek buffers

Hi there, this looks like a good start. There are a number of things to attend to. How would you like to proceed? I can either just tell you stuff to change, or you can add me as a collaborator to your fork and I can make commits to it and have it appear in this PR.
The first issue is that this PR does not pass tests because you included UIKit which does not exist on macOS. To use UIKit you have to check that you're on appropriate operating system. This is done in several places in AudioKit.
The next issue is that you're adding a feature to AudioKit without adding a test of that feature.  The test suite is pretty easy to use, I can help you out if you need me to.
Finally if you want to join the AudioKit slack group, send me an email and I can add you.

Thanks @aure! I don't mind giving it a shot myself, however if it's easier and quicker for you I can add you. I just resolved the UIKit issue.
Next would be the tests which I don't actually have any experience with but wouldn't mind giving a shot.
Lastly, email for slack is<EMAIL_ADDRESS>Thanks!

Drive by comment – I'm new to AudioKit but these changes just helped me hack seeking into my local project. However I wonder if an even more useful approach might be a current time property you can set, regardless of playing state? Then if you play() later that's where it starts. I had to adjust these changes a little to get seeking while paused to not resume by itself, and also meanwhile report the seeked time as the current time.

@KieranHarper How were you able to use this PR in your code? I want to as welL!

@KieranHarper How were you able to use this PR in your code? I want to as welL!

I have a local checkout of the repo, which I'm able to edit directly and try in my project. You could check out this specific branch from willsmillie's fork if you want it as-is, but in my case I just applied that parts of the changes here that I wanted to try. If you've installed the package into your project using SPM, you can get it to point at your local repo by editing the project.pbxproj file and changing the path, as per Jared Sinclair's comment in this thread.

Yes, I'll have some time today.

@ryanfrancesconi I got this to at least pass tests, but could you have a look and if you approve, I will merge. It would be great if there were something that worked with macOS.

@ryanfrancesconi I got this to at least pass tests, but could you have a look and if you approve, I will merge. It would be great if there were something that worked with macOS.

Two main things would be that the display link shouldn't be in a player class. If you have 200 players you want 200 display links?
I would prefer that the player have a delegate that could send progress events if desired. In general this looks very much like a hack for a specific project rather than a clear addition. I use a CADisplayLink timer in my own work, but that is external to all players, and I only need one to update the screen with.
Also, force unwrapping all those optionals isn't good. It's better to let them silently fail with ? or strong check them to make sure the properties are valid.
Thanks!

Good call @ryanfrancesconi
I can replace it with a delegate, or could also do a block. Any preference or reason to go with one over the other? I'm thinking just one for playerDidStart, and playerDidStop. Does that sound like a good alternative?

@willsmillie honestly, you shouldn't need these types of progress methods in the player. What exactly are you making?
Basically a player is generally controlled from a larger set of logic for playback, so it's preferable to put your delegate methods in your application level. For the most part you know if a player is started or stopped. What you don't know is the completion event, which is already handled in the player.
If you are wanting to update a playhead in a waveform type of editor, I recommend keeping this timing logic outside of your player class. The reason that hostTime is a thing is for the purpose of syncing different types of play events. For example, you can base your timer class off of hostTime and use AVAudioTime addition to track the position of the playhead rather than looking at the playerTime as you have added. It's not a bad thing, but you probably will no longer have the correct time if you are looping in a buffer after it goes past the end - the numbers will keep going up, not go back to 0.

I wouldn't dispatch the completion handler to main like that personally. Though the completion handler comes in on a thread other than main, you're introducing an unknown amount of latency by dispatching async.
I would remove all the display link stuff. I really don't think that belongs in this class. I can give you more info on how to handle this situation differently if interested.

Don't use AVAudioNodeCompletionHandler as a type for a progress block. That's pretty confusing to read. Just use the underlying () -> Void

on macOS the analog to CADisplayLink is CVDisplayLink, which is a bit more complicated to manage via swift (as it's really C) but works well. Should Ak wanto use use this method of timer I'd recommend a generic cross platform protocol that goes to CA or CV depending on the platform. But the api would be the same.

Honestly this PR is getting old and out of date, and the original author hasn't responded, so I'll close it for now. I think it shouldn't be reopened but if parts of it were resubmitted separately we could get some in. Or if someone wanted to look at this code and make their own smaller PRs, that would be fine.

Honestly this PR is getting old and out of date, and the original author hasn't responded, so I'll close it for now. I think it shouldn't be reopened but if parts of it were resubmitted separately we could get some in. Or if someone wanted to look at this code and make their own smaller PRs, that would be fine.

PR for seeking the AudioPlayer:
https://github.com/AudioKit/AudioKit/pull/2428


Errors found in the input_output notebook

duplicate of https://github.com/empa-scientific-it/python-tutorial/issues/236


Travis: Publish wheels to PyPi

The manylinux wheel built by travis (from #159) wasn't getting deployed to PyPi on tagged commits.
Closes #194

To test the automated deployment I made a new release in github with the tag v0.12.1-beta.1. Unfortunately I forgot to add the beta part to the version in setup.py. A travis job built and published the wheel file as a new release to pypi.


BUG: Rework LAMMPS calls

@apenat this, with the documentation works for the examples/akmc-fe-lammps and should work for QUIP (need an input file set for pair quip to test).

Merging in for now.


Newly installed IPT does not create a new resources directory

At least when installed from the el8 RPM, the IPT does not create a new data directory. It does create config, logs and tmp.
After completing setup2.do, setup3.do reports "Resources directory does not exist: /var/lib/ipt/resources"
(Version 2.6.2, el8 RPM.)

Thanks Matt. Have you tried a regular installation?

This might be related 37b528fe6782ea998c17df7adb5ed967ed790270

This happens indeed when directory path is provided in the datadir.location, but doesn't actually exist.

I found what was the issue here. It's UI settings in the wrong place

@MattBlissett please check it works when you can


duktape have http or network api support native?

Hi.
If yes, have examples? (ajax-like)
thanks.

Duktape doesn't provide an event loop, network bindings, etc as it is intended to be an engine you can embed into a variety of applications. There are other projects which provide application specific bindings, for example https://github.com/creationix/dukluv.


filepath.endswith(".nc") in .save()  breaks pathlib compatibility

According to the docstring this isn't explicitly supported, but it used to work.
I think the solution is just str(filepath).endswith(".nc") or Path(filepath).suffix==".nc"

Path(filepath).suffix == ".nc"

I would use that.


Exclene gamecube controller instant disconnect v1.8.4

BlueRetro firmware version
1.8.4
BlueRetro firmware specification
HW2
BlueRetro firmware variant
System specific
BlueRetro hardware type
Internal install modkit
Manufacturer
Lazer Bear
System used
Nintendo GameCube
Bluetooth controller brand & name
Excelene Gamecube controller
What is problem? (only list ONE problem per report)
Controllers constantly disconnecting after not even a minute. (exclene gamecube controller) 4 of them. Had to flash back to 1.8.3 for now as I tried all sorts of fixes or troubleshooting and nothing worked. Bright side rumble worked but I truly hope this gets fixed soon.
What did you expect to happen?
Not disconnect
Attach files like logs or Bluetooth traces here
No response

Did you pair controller in Y + Home mode?
https://github.com/darthcloud/BlueRetro/wiki/Controller-pairing-guide#12---exlene-gamecube-paring-guide

Yes and same problem.

Tried with my own Exlene in  v1.8.4 and it totally work fine for me in IOS/Xinput mode (Y + Home). Played 15min with no issue.
The fact you say rumble work tells me you are not connected in the right mode.
Also you may want to try latest v1.9 beta:
https://github.com/darthcloud/BlueRetro/actions/runs/6437347093

Tried with my own Exlene in v1.8.4 and it totally work fine for me in IOS/Xinput mode (Y + Home). Played 15min with no issue.
The fact you say rumble work tells me you are not connected in the right mode.
Also you may want to try latest v1.9 beta: https://github.com/darthcloud/BlueRetro/actions/runs/6437347093

I tested both the home + y pairing mode (that has no rumble) and just the home pairing mode that has rumble. It works fine if in use I believe on 1 controller. But when 4 are connected and left idle for a minute or less it loses connection.
I will try this beta version you suggested and see how it goes. Not sure if I will get to it this weekend but will try. I can also record a video if you want if the issue persists.
I know 1.8.3 has been working solid for me on both just pressing home to pair and home + y. But will report back once I do testing when I have a chance.

Tried with my own Exlene in v1.8.4 and it totally work fine for me in IOS/Xinput mode (Y + Home). Played 15min with no issue.
The fact you say rumble work tells me you are not connected in the right mode.
Also you may want to try latest v1.9 beta: https://github.com/darthcloud/BlueRetro/actions/runs/6437347093

Flashed the beta you linked and my controller disconnects were fixed! Now I am back to solid! The only issue now is the l+r button kinda half works? Its like it works but then sometimes doesnt or depending on the game doesnt at all. (mario party 7 it worked perfectly fine in). Well the L shoulder button. The R I had to kinda press harder? or press multiple times. Tested multiple controllers.

Fixed in v1.9 https://github.com/darthcloud/BlueRetro/releases/tag/v1.9


Use the path of snapshot data from data_dir

Signed-off-by: Harsh Gupta<EMAIL_ADDRESS>

Looks good. Thanks!


clippy::blocks_in_if_conditions

Input
fn main() -> Result<(), String> {
    let o = Some(true);
    if o.ok_or_else(||
        "Some error long enough to trigger rustfmt, but still short enough to not require a block".to_string()
    )? {
        println!();
    }
    Ok(())
}

Output
fn main() -> Result<(), String> {
    let o = Some(true);
    if o.ok_or_else(|| {
        "Some error long enough to trigger rustfmt, but still short enough to not require a block".to_string()
    })? {
        println!();
    }
    Ok(())
}

Expected output
fn main() -> Result<(), String> {
    let o = Some(true);
    if o.ok_or_else(||
        "Some error long enough to trigger rustfmt, but still short enough to not require a block".to_string()
    )? {
        println!();
    }
    Ok(())
}

Meta

rustfmt version:  rustfmt 1.4.37-nightly (0bd2b192 2021-04-03)
From where did you install rustfmt?: rustup
clippy version: clippy 0.1.53 (6df26f89 2021-04-20)
From where did you install clippy?: rustup

The example is a bit contrived, but it is just a simplified version of code I'm working on.
The current output looks fine to me, the problem is that clippy complains about it:
warning: in an `if` condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
 --> src/main.rs:5:24
  |
5 |       if o.ok_or_else(|| {
  |  ________________________^
6 | |         "Some error long enough to trigger rustfmt, but still short enough to not require a block".to_string()
7 | |     })? {
  | |_____^
  |
  = note: `#[warn(clippy::blocks_in_if_conditions)]` on by default
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_if_conditions

So if I fix the clippy issue it will be back the moment I routinely do a rustfmt.

I guess this can be 'fixed' with a custom rustfmt.toml:
unstable_features = true
preserve_closure_block_wrapping = true

At least it's not as ugly as #[allow(clippy::blocks_in_if_conditions)]


[V5] Topbar Chrome Js Error

We' ve been seeing this issue in Chrome consistently over the past 15 days.

Chrome breakdown:

It can be difficult to reproduce, but if you reload a page with a topbar enough times you will see the error in the console.  The error is within the resize event.
Resolution: Pull request coming soon.

Chrome 57.0.2987 released around the same time.

Looks like a fix for this was merged.


Good Job!

I  think you guys need a little bit of cheer! Keep it going. Good job on working on Mybb 1 and 2!

Just the opposite, but peace :)

@pixiuPL I don't think the project is dead?

why this project is even alive?

It is alive because we still work on it.


Add support for file watching in the build server protocol

This PR adds requests for registering and unregistering file watching via the build server protocol. This will trigger a notification on changes that includes the updated build settings for a registered file. The same mechanism will be used for dependency changes via a separate notification.

@swift-ci please test

@swift-ci please test


fix(react): updates Portal to have backward compatibility

Fixes #2154 and #1787
There were a lot of ways this could be solved, most of them are by working around typescript. I decided to push the most type-safe solution since Portal's return type now gets inferred as JSX.Element, so the code will work on all versions of @types/react@18. The only downside is adding a Fragment without actually needing it.
I also added some tests for the Portal component since there weren't any :)

Thanks!


.NET Core 3.x.x installer language in Portuguese instead of English

Issue Title
.NET Core 3.0.x and 3.1.0 installers using different language to installation instead of the language of the download, seems like that prior to 3.x.x the installers runs at system language, and with 3.x.x runs with server location.
General
The behavior of the installer changed with .NET Core 3.x.x. For example, if i go to the official download site and pickup the .NET Core 2.1.14 Server Bundle (english site), download and execute it on a server, the installer will be in English language.
If i download the .NET Core 3.0.1 Server Bundle on the same official site, and execute on the same server, the installer will be in Brazilian Portuguese language. The same occurs with 3.0.0 and the new 3.1.0.
The server is with English language, but region set to Brazil. So seems like the behavior changed with the 3.0.0.
This is normal? This is expected? Does this affect the behavior of the server? (All installed in english, but only with .NET 3.x.x installed in PT-BR).
Prior to .NET Core 3.x.x, for example, i'm from Brazil, and download the .NET Core. I would install on a server with english language and region settings set to Brazil.

@dagood

The version number makes sense, since localized text was added for 3.0.0+ with https://github.com/aspnet/AspNetCore/commit/349ed16587d4368906d4cd8bc8977454428bd320#diff-1aceaf1dc6b3dcbcbb6e779245a4ae1b.
About region vs. language setting affecting the language used, there's an issue about it at https://github.com/dotnet/core-sdk/issues/2453, but I'm not too familiar with that. (It's possible this is something that the WiX Burn engine or is handling that we can't change.) @joeloff
You can pass a command line arg to set the LCID used in the installer, -lang 1033, if that happens to help.
None of this affects the product you get on the machine after the install is complete.

I cannot pass the command line arg, because i cannot read full helper..
If i put this:
.\dotnet-hosting-3.0.1-win.exe /?
The helper screen appears in Portuguese and there's more text than the window size and i cannot scroll down or export the text, so i cannot even read how i should pass the arg correctly.
I tried to start the installer with that:
.\dotnet-hosting-3.0.1-win.exe -lang 1033
.\dotnet-hosting-3.0.1-win.exe --lang 1033
.\dotnet-hosting-3.0.1-win.exe "-lang 1033"
.\dotnet-hosting-3.0.1-win.exe "--lang 1033"
.\dotnet-hosting-3.0.1-win.exe '-lang 1033'
.\dotnet-hosting-3.0.1-win.exe '--lang 1033'
.\dotnet-hosting-3.0.1-win.exe /lang 1033 (seems like the args to install .NET Core are with "/" instead of "-", but didn't work to)
.\dotnet-hosting-3.0.1-win.exe "/lang 1033"
.\dotnet-hosting-3.0.1-win.exe '/lang 1033'
Start-Process dotnet-hosting-3.0.1-win.exe -ArgumentList '/lang 1033'
Start-Process dotnet-hosting-3.0.1-win.exe -ArgumentList '-lang 1033'
Every one of these opens a Portuguese window instead of a English window.
I have these 1001 Error events in my server:
Fault bucket , type 0
Event Name: CbsPackageServicingFailure2
Response: Not available
Cab Id: 0
Problem signature:
P1: 10.0.17763.793
P2: Microsoft-Windows-LanguageFeatures-Basic-pt-br-Package
P3: 10.0.17763.1
P4: amd64
P5: unknown
P6: 800f0954
P7: CBS Other
P8: Absent
P9: Absent
P10: FodHelper(LanguageFeaturesOnDemand)
So i think that may be connected these errors with the .NET Core 3.x installed in pt-br language.. or it's just a coincidence?

The helper screen appears in Portuguese and there's more text than the window size and i cannot scroll down or export the text, so i cannot even read how i should pass the arg correctly.

Yikes, yes, I see this as well in Spanish (a lang pack I happen to have on my VM). Filed https://github.com/aspnet/AspNetCore/issues/18152 for this issue, thanks for pointing it out.

Every one of these opens a Portuguese window instead of a English window.

Apologies, I've used -lang x before with the SDK and Runtime installers, and it works there. You're right, it doesn't work on the hosting bundle. I had no idea it would work differently for this specific installer. 😕
The -? message doesn't list any language option anyway (even for the SDK and Runtime installers), so my suggestion there was also pointless in the first place, sorry.
I think there are two issues that I'll need to let @joeloff answer at this point:

How can the hosting bundle installer be forced to use a certain LCID? (Also useful for testing.)
Should the installer be using Region or Language to choose the language it displays, and should this be fixed?

The UI should default based on the OS locale as that's set by the underlying installer engine. AFAIK, burn doesn't support overriding the LCID, at least, it's not officially documented, but the support might have been added in a later WiX update.
@dagood which version of WiX is runtime/SDK using when building? 3.11 or later?

Core-Setup, 3.10.4 https://github.com/dotnet/core-setup/blob/68b32ff4b583fa458d124b81acc316b223e6b223/src/pkg/Directory.Build.props#L58
Core-SDK, 3.10.4 https://github.com/dotnet/core-sdk/blob/2bedb36a6a83ebb72e993f82ff439896046471ae/src/redist/targets/GenerateMSIs.targets#L6

ok, I tried with the 3.0.1 hosting bundle on an en-CA OS. I was able to run with -lang 1036 and it popped up the French UI as expected. Ditto for 1049 which displayed Russian.

We are missing the 1033 folder, so when you have a non-ENU region in the OS, it will default in this case to pt-BR, but then try to apply the override to en-US (1033), not find the folder and fallback to the OS default.
@anurse this issue is mentioned in the other UI issue for the help page. We'd be touching the same code, so might be good to just fix this as well. They'd also repro for the shared-framework installer since they share UI elements.

So now we know now why the override isn't working, and that's fixable in a future patch to the installers.
About the main issue where it's using an unexpected language in the first place... I'm able to repro the problem as described in the issue description on the 3.0.1 hosting bundle (but in Spanish), and and at that point my OS is in this state (PowerShell commands):
$ [CultureInfo]::CurrentCulture

LCID             Name             DisplayName
----             ----             -----------
3082             es-ES            Spanish (Spain)

$ [CultureInfo]::CurrentUICulture

LCID             Name             DisplayName
----             ----             -----------
1033             en-US            English (United States)

So maybe the burn bundle, some UI stuff it depends on, .NET, or something along those lines is using CurrentCulture when it should use CurrentUICulture? Looking it up, CurrentUICulture is newer than CurrentCulture, so maybe this is a problem of legacy code. This is all just a theory though, I'm not familiar enough with loc or the depths of the installer UI to go much further without doing a lot more digging.

For the default engine in WiX, that's all native code. I'm guessing there's similar rules to how .NET handles resources. If I remember correctly, it's something like specific first, then the language, then neutral so for English it might search "en-US", then "enu" or "en", then neutral.
I did notice that the engine logs a property value it sets for the LCID, but regardless of the override, it doesn't seem to record when the value changes in the log

Still happens with 3.0.3 and 3.1.2

@anurse the fix for this is pretty simple. It's just the 1033 folder that's missing, causing the UI to fail when you force it to 1033 on a non en-US OS

@dagood has this been resolved? Thanks.

It hasn't, as far as I know. Moving this to dotnet/aspnetcore as the installer mentioned is built there, and there's also https://github.com/dotnet/installer/issues/2453 tracking the same issue in dotnet/installer for the SDK installer.


Hotfix/doc

Describe what this PR does / why we need it
Rewrite examples in doc & README to use new standard APIs.
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Thanks!


Potential error - wrong Collation in 1045 Polish.

Hi Microsoft team! I've noticed a potential error in your documentation regarding the 1045 Polish language and Collation. According to the Collation documentation for this language is: "_CI_AI", on the other hand, according to Power Platform support and ticket no. '2309260050003902' we learned that the Collation for this language is: "_CI_AS". Can you please check and confirm what is the Collation for this language?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 74eaabd4-dc38-6393-d6e6-0f6929242cb8
Version Independent ID: db2590c1-bbcc-35c2-2dfa-e6181e11fa82
Content: Microsoft Dataverse language collations - Power Platform
Content Source: power-platform/admin/language-collations.md
Service: power-platform
Sub-service: admin
GitHub Login: @NHelgren
Microsoft Alias: nhelgren

Thanks for your comment, @MaciejPokrzywinski. This issue has been assigned to the doc author for review.

@bishalgoswami, what is the status of this case?

@NHelgren, what is the status of this case?

@mgra8ski @MaciejPokrzywinski
The purpose of these GitHub issues is to provide feedback about the documentation. This isn't a support case.
These issues will be going away in the coming months. I don't know that you can expect a resolution before this goes away.
If you want to escalate this and increase the chance this will be addressed, I recommend you edit this page, and submit a PR and change the value yourself to what you believe it should be.  That will trigger a new review that will persist after these GitHub issues are removed.


iframe the site into weebly

Use Case
we want to iframe this site into allencell.org
Acceptance Criteria
view it the same way we do the current catalog except no content other than the header. The text above the tables is now included in the site instead of being a part of weebly
Details
the website is https://cell-catalog.allencell.org/disease-catalog/

Same message in Slack: I ran into this issue:


CNV-29307: Fix copy and paste to serial and vnc consoles

📝 Description
The paste function on consoles wasn't working for firefox, this is due to firefox not supporting the full functionality of navigator.clipboard as chrome does, i used another approach of events in order to make it work for all browsers.
🎥 Demo

Please add a video or an image of the behavior/changes

/retest


sort out FMT_SMF and FMT_MOF

We likely want one table with SMF and MOF, for the management functions (a la MDF PP 2.0).  ]
Or maybe a classical FMT_SMF, with an FMT_MOF that just has a selection which refers to an arbitrary subset [defined by the ST author] of the selections in FMT_SMF.

FMT_MOF - Table added to identify mandatory and optional management functions for administrator and user.


TC-DA-1.4: Darwin tool support needed for [--paa-trust-store-path] optional attribute

As per TC-DA-1.4 step 7, Darwin tool support is needed for [--paa-trust-store-path] optional attribute to execute the scenario. This optional attribute is present in chip tool but not in the Darwin tool.

@krypton36 @vivien-apple

@bzbarsky-apple I can take this one. I am already working with Shyam.


Fix chainxchg race issue

Summary of changes

Changes introduced in this pull request:

Fix race issue when waiting for chainxchg results

Reference issue to close (if applicable)

Closes #2934
Other information and links

Change checklist

[x] I have performed a self-review of my own code,
[x] I have made corresponding changes to the documentation,
[x] I have added tests that prove my fix is effective or that my feature works (if possible),
[x] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

It may be simpler just to directly use a JoinSet and Semaphore in handle_chain_exchange_request.

It could help to keep the code in a dedicated struct for testing purposes, like Hubert is suggesting, no?

I like this implementation, by the way. :)


Handle endpoint modification events

When one of the pods backing a service is deleted,
we should delete the endpoint from the load-balancer.

CC @rajatchopra
This is not yet ready for review. But I am posting anyway to prevent any duplicate work.

@rajatchopra Ready for review.


Match searchbox from upstream

This has been since 1.x
https://github.com/sphinx-doc/sphinx/blob/v1.5/sphinx/themes/basic/searchbox.html
The latest version includes some nice things like js enabled detection
and aria labels :)
~I don't see anything special we are doing to make this custom.~
Ah, looks like we remove the "Go" button

Personally don't like the "Go" button. Closed in favor of https://github.com/readthedocs/sphinx_rtd_theme/pull/1024


WCON-90 - tagbrowser implementation

I have created a way for configs to select tags using a "tagbrowser", similar to using the existing pathbrowser.
Creating configs with widgettype=tagbrowser will be rendered differently.  The tags can be selected using a tag-picker and will be displayed correctly:

Both single and multi value tags are supported.
I did have to refactor the backend code a bit because now both the pathbrowser and tagbrowser use the same rootPathProvider code.  Having it named "PathBrowserRootPathProvider" wasn't very clean.
Because of these refactorings I had to up the version in package-info.java in some places.

i've also did a quick test in AEM 6.5 - looks good there as well

i've tested this with our sample application and the PR wcm-io/io.wcm.caconfig.sample-app#1 and detected a strange problem with the "dirty" state when overwriting inherited configurations.
...
expected behavior: "Save" button should stay active

I fixed this and made the dirty/pristine-logic a little simpler.


"external"-state with new API

If i activate the new API in config, my record data will got weird data:

I cant import "old-Data" got an error.

To Reproduce
Steps to reproduce the behavior:
Just enable new API
Expected behavior
Got record-values
Screenshots

Disabled new API:

Version

HA version 2022.6.7
HA Bosch component version 0.18.0a
Python Bosch HTTP client version (?)

** Debug SCAN **
** IMPORTANT **

read https://github.com/bosch-thermostat/home-assistant-bosch-custom-component/wiki/New-API-support

Thanks,
but so i dont get (central heating data). Just:

(and these values are always the same)
and i cant import old history-data

can you translate error from last screen?

Its like..
"Cant execute service bosch.move_old_statistic_data. Unknown error"
On Debug-Service i got error as seen in first post:
"Cant execute bosch.debug_scan. Need array index uuid. Got none"
:)
Thank you.
I have tried new installation of hacs-component, "reinstall" of integration in home assistant with new setup. got the same error.

Ah, in log-files i got:
File "/usr/src/homeassistant/homeassistant/components/recorder/pool.py", line 75, in do_get
check_loop(
File "/usr/src/homeassistant/homeassistant/util/async.py", line 168, in check_loop
raise RuntimeError(
RuntimeError: Blocking calls must be done in the executor or a separate thread; Use homeassistant.components.recorder.get_instance(hass).async_add_executor_job(); at homeassistant/components/recorder/pool.py, line 75: check_loop(
if i try to import old stats.
and 2022-07-05 16:06:42 ERROR (MainThread) [homeassistant.helpers.script.websocket_api_script] websocket_api script: Error executing script. Invalid data for call_service at pos 1: required key not provided @ data['uuid']
2022-07-05 16:06:42 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [140067235651344] Error handling message: required key not provided @ data['uuid']. Got None (invalid_format)
if i try to run debug scan

(I found the UUID on Buderus App <3)
bosch_scan.txt

Let me know if it works for you with the newest version.

With 12 days old 18.1 ?
Nope, same error, recording CH power = unknown

Error still there with 0.18.2

can you somehow turn on heating for at least 15 minutes? :) I think unknown is because of no heating during last month.

May i will try, atm its around 30° here ♨

Runs around 25 minutes, still Unknown

I don't know if it's interesting, but in 0.18.3 the bug is thill sere ;)

I got it working here with new stats api when using the colon-name instead. But how do I rename the entity now? I don't see the colon-entities in the entities config screen?

You can't rename it because those are not entities, those are entries in statistics table.


Go To Definition of decorated functions that get wrapped goes to the wrapping function

This appears to be regression of https://github.com/DonJayamanne/pythonVSCode/issues/742
Environment data

VS Code version: 1.22.2 and 1.23.0
Extension version: 2018.4.0 (edit: confirmed not an issue under 2018.3.1)
OS and version: Ubuntu 16.04.4 LTS (Xenial)
Python version: 2.7 and 3.5 tested
Type of virtual environment used: None (for Python 2.7), virtualenvwrapper (for Python 3.5)
Relevant/affected Python packages and their versions: —

Actual behavior
Navigating to definition of a decorated function shows the definition of the decorator.
Note: this only reproduces in a package and not in a single file.
In one sense I can see why this is happening -- the decorator is actually what the symbol in question really is. However, that is not a useful thing for an editor to do and I would much prefer to be shown the definition of the decorated function instead.
I believe this is also a regression as I've only noticed this behaviour recently (I think it started failing some time after the new year, but I'm not sure).
Expected behavior
(copied from https://github.com/DonJayamanne/pythonVSCode/issues/742)
Navigating to definition of a decorated function should show the function in question.
Steps to reproduce:
(copied from https://github.com/DonJayamanne/pythonVSCode/issues/742)

Create a package with a decorated function in one file and a usage of that function in another. I've put an example at https://gist.github.com/PeterJCLaw/38b39e6ee7bfa0cd69e00ce984aebde3.
Open VSCode to the directory containing the above files
Open the usages file
Navigate to the definition of the my_context_manager function from either the import or the usage (I use Ctrl+Click, though F12 and the context menu also reproduce the issue)
Will navigate to the wrong place

This issue shows up for both class- and function-based decorators and for both local and standard-library decorators.
Logs
None from either the Output pane or the developer tools

It seems plausible that this is related to the environment changes alluded to in #1033, though that may be unrelated.
While I appreciate that the underlying functionality here is part of Jedi, the repeated reappearance of this bug is a little frustrating. Does this project have any automated testing around this sort of thing? If not, would you be open to some?
I'm imagining that these integration tests would take the form of a small number of chosen test cases which exercise common workflows, probably at the level of the Python <-> TypeScript interop boundary.

yes I'm seeing the same issue I'm using python plugin 2018.4.0, vscode 1.23.0

@PeterJCLaw more tests are always a good thing, so yes, we would accept them.

@brettcannon I've just had a look at this and spotted that there are already some higher level integration tests (specifically src/test/definitions seems related) which I'd not spotted the last time I had a look :)
It seems more useful to add a test to those, rather than trying to create an entirely new infrastructure, so I'll look at doing that for this test case instead.

Hrm, from what I can tell of looking at the results for a bunch of test cases, this issue appears to be a result of the change to using goto_assignments primarily (see footnote) and without follow_imports. I think I agree with https://github.com/Microsoft/vscode-python/issues/1033#issuecomment-378733832 that goto_assignments is what we should be using, however the missing piece here is that we need to pass follow_imports=True (it defaults to False) so that the imports are followed.
As I've got a branch with a bunch of test cases for this, I'll add the fix to that and open a PR.
As a related point, I suspect that this means that the 'tooltip' lookups should also change (to using goto_assignments(follow_imports=True)) as they currently use goto_definitions, however that needs further investigation and probably deserves its own issue/PR.
Note on the current implementation: while _process_request calls goto_definition first it does so with follow_imports=True which emits a TypeError. I'm not entirely sure why that is, however I suspect that may be a result of a misunderstanding of https://github.com/Microsoft/vscode-python/issues/1033#issuecomment-378733832 (cfee1092243ff29f907d682664e0d0858d0c33fa changes the first call from being goto_assignments to goto_definitions) which happens to appear to fix the issue by making that call always error, so priority ends up going to goto_assignments.

To be very clear about this, it occurs only if the decorator returns a wrapping object, e.g. this does not cause any issues:
def identity(func):
  return func

@identity
def spam():
  pass

@brettcannon to check my understanding of your clarification:

do you get the failing case for a wrapped function in the same file as the usage? (I didn't think I'd seen that)
do you get the failing case for a non-wrapped function in a different file as the usage? (I don't recall testing that, but could believe that this behaves correctly)

I tested across files like you did, I'm just saying that if the decorator doesn't modify the returned object there's no issue.


correcting TLS certificates config path

In config schema is this config path described: grpc.tls.cert and grpc.tls.key. Neither runtime flags --grpc-tls-cert/--grpc-tls-key nor yaml configs grpc.tls.cert and grpc.tls.key are mapped correctly.
Mismatch is done by:
https://github.com/openfga/openfga/blob/0999404bfb1ef7846b2ca12469ef049cb6c6f8e9/pkg/cmd/service/service.go#L70-L74
Fields cert and key cannot be mapped to CertPath and KeyPath without mapstructure tag.
Description

fixes #284
References

Review Checklist

[x] I have clicked on "allow edits by maintainers".
[x] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[x] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


feature

just changed the border color (from white to green) for items that can be salvaged, I think it is better this way and more easily to spot what item to pick up.

Sorry, I don't quite like this and I think this is more of a personal preference.
I'll revisit the long-term color question in the 'big' filter that's coming up in a week.


Fatal error soon after starting coda deamon

Attached is the crash report as requested. Ubuntu 18.04 LTS, c5.2xlarge on AWS.
2019-12-06 18:14:39 UTC [Fatal] Unhandled top-level exception: $exn
Generating crash report
        exn: "(monitor.ml.Error\n  \"RPC #72 failed: \\\"internal RPC error error: input isn't valid multihash\\\"\"\n  (\"Raised at file \\\"src/error.ml\\\" (inlined), line 9, characters 14-30\"\n
  \"Called from file \\\"src/or_error.ml\\\", line 72, characters 17-32\"\n    \"Called from file \\\"src/deferred1.ml\\\", line 17, characters 40-45\"\n    \"Called from file \\\"src/job_queue.ml\\\" (inlined), line 131, characters 2-5\"\n    \"Called from file \\\"src/job_queue.ml\\\", line 171, characters 6-47\"\n    \"Caught by monitor coda\"))"

  ☠  Coda daemon crashed. The Coda Protocol developers would like to know why!

coda_crash_report_2019-12-06_18-14-39.707581.tar.gz

@smartins I'll cut a new release to hotfix this soon! For now, you can workaround by force-installing version 0.0.11-beta2

Thanks, I installed version 0.0.11-beta2 as a temporary "fix". Should I go ahead and install the latest version now?

Should be fixed with the latest version


Support for QQ Mail

QQ mail seems to be very popular in China. We should add support for it at some point.
URL: http://mail.qq.com/

Reopen when people ask for it.


Old version 2.0.1 on npm

Hi
Not sure if this is the right channel but I just wanted to let you know that the latest package of 2.0.2 on npm seems to be still containing 2.0.1 code.
To verify, download the tarball from npm:
https://registry.npmjs.org/easygraphql-load-tester/-/easygraphql-load-tester-2.0.1.tgz
Open up package/lib/index.js and navigate to lines 74 and 75. You'll see that the env still contains the old 2.0.1 definitions VUS and DURATION which were changed in one of the 2.0.2 commits:
https://github.com/EasyGraphQL/easygraphql-load-tester/commit/79919b1f2ee58405ab7a81a57103e52117c58333
I ran into an issue with k6 loadtesting because of this (vus wouldn't get picked up from my initializer).
Cheers

I'm not sure why it happened but now there's a new version v2.0.3 which is working as expected!
Thanks.


RaspiBlitz Took a Dump

I found my RaspiBlitz in this state (possibly due to power outage):

No route to SSH in. Power cycling Pi leads to same screen.
Any ideas how to resolve?

Thank you, openoms, Option 1 worked. Exploring Option 2 soon.


Nice feature, needs to be more open

We are looking for a way for our users to have a one stop shop for things like time, geog, sales, hr and product hierarchies. It would be great to set these up on a central data model and allow folks to hit it and join their own data to the standard data sets. This doesnt quite fit the bill :(

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a1cce347-2064-d2b3-d7dd-008ecdb36013
Version Independent ID: 6abb84b5-1657-c8b1-62ef-641883c0e4b9
Content: Connect to datasets in the Power BI service from Power BI Desktop - Power BI
Content Source: powerbi-docs/desktop-report-lifecycle-datasets.md
Service: powerbi
GitHub Login: @davidiseminger
Microsoft Alias: davidi

Thank you for your feedback @tdexterus.


ENH: Improve the error message in to_gbq when schema does not match #11359

See the discussion in #11359

Travis is green.

thank you sir!


Return 404 when admin doesnt exist

Codecov Report

Merging #40 into development will increase coverage by 9.42%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development      #40      +/-   ##
===============================================
+ Coverage        64.91%   74.33%   +9.42%
===============================================
  Files               16       20       +4
  Lines              419      643     +224
  Branches            49       49
===============================================
+ Hits               272      478     +206
- Misses             138      165      +27
+ Partials             9        0       -9

Impacted Files
Coverage Δ

app/secret/routes.py
83.58% <100.00%> (+8.95%)
:arrow_up:

app/__init__.py
76.81% <0.00%> (ø)

test_basic.py
100.00% <0.00%> (ø)

app/email.py
35.29% <0.00%> (ø)

config.py
100.00% <0.00%> (ø)

app/models.py
87.38% <0.00%> (+0.90%)
:arrow_up:

app/redis_registry.py
90.62% <0.00%> (+3.12%)
:arrow_up:

app/secret/forms.py
96.00% <0.00%> (+4.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4274cd0...790dfa4. Read the comment docs.


[RFC] Workflow demo

Hi,
I think it could be very usefull to have an example of the workflow component inside the demo project.
Add a status property on the post, have a listener with guard and personal feature (admin check validation, sending email etc)
(Spec to be decided)
I know there is already https://symfony-workflow-demo.herokuapp.com
but it think having this kind of code example inside this demo app will definitly be better.
I can work on this if this issue is approved 👍
Thank you,

ping, with the next merge of demo on sf 4.3, i think it could be very usefull
i am available to discuss what i called (Spec to be decided) in the issue desc
cheers :)

I haven't changed my mind about this :(
Introducing this component in the app will turn the Symfony Demo from "an easily understandable app to explore Symfony features and possibilities" to "an unnecessarily complex app" which can do more harm than good to us.
Keep in mind that some people still insist that Symfony is "too complex". They are wrong, because they refer to the old Symfony 2.0 versions, which made some things unnecessarily complex. But if we do changes like the one proposed here, they'll have arguments to keep talking about "how complex Symfony is" even for simple things such as a demo blog app. Symfony 4 is great, amazing, fast, minimal. We should showcase that.

@javiereguiluz oki understood
lets onyl refer to doc (+ example) and blog post
thank you!

@noniagriconomie However, it makes sense to have a Workflow Demo App. Something like a next level once a beginer explores this demo app.

there is https://symfony-workflow-demo.herokuapp.com where @lyrixx try to keep it uptodate
it is a nice one IMO, but we can not reference it to the doc as it is not hosted on sf infra

@javiereguiluz Indeed I keep this "demo" up to date with the framework and there is a lot of resource there. May be it could be nice to add a link to the demo. I know we don't do that usually. WDYT ?

please can you have a look at this https://github.com/symfony/symfony-docs/issues/9834#issuecomment-552105172 @lyrixx @javiereguiluz ?
also the @fabpot tweet https://twitter.com/fabpot/status/1188833580039987202
do you think we can rediscuss/reconsider this issue?
cheers :)

lets close for now :)


problem:grpc communication is slow

When I use this package to export logs to rabbitMQ, if the rabbitmq service is not started, the grpc client requests I generate using dependency injection will be about 30 to 40 seconds late. Why?

Could you please give an example of container registration?

Could you please give an example of container registration?

ok,i create a project on github ,the link grpctest,now  i know the question is ,if i set async="true" it is work ,but i dont no why,I haven't started printing anything yet, after all

direction for use：1、start GrpcService2
2、start webApplication1
3、debug the api use swagger,then you kan  see the timeuse in  console
thank you!


Minor UI issue in restore your seed window

There is a minor UI issue in the restore your seed window. I cannot take a screenshot of it (as expected), but essentially it shows a table to enter the 33 different words:
Word #1
Word #2
...
Word #9
Word
#10 (not visible, covered by the next line)
Word
#11 (not visible, covered by the next line)
...
Word
#33 (not visible, covered by the bottom line)
As a user, I expect to see all the numbers fully present on my screen, but from #10 onwards I can only see a tiny part of the top. It's not a show stopping issue, but it does deserve a fix in the next release.
Background information
Device: Moto G5
Screen size: 5 inch
Pixels: 1080 x 1920
Ratio: 16:9
OS: Android 7.0

This issue was solved in the testnet 2019-03-24 build.
The seed numbers now fit on one line:
Word 1
Word 2
...
Word 9
Word 10
Word 11
...
Word 33


Start using pre-commit in CI

@jairhenrique I have added one deliberate formatting error to showcase how this integration will present formatting errors in practice. Looking forward to your review :beers:
PS: Review on commit level is advised :smiley:

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (88cf01a) 90.13% compared to head (fc51e1f) 90.14%.

:exclamation: Current head fc51e1f differs from pull request most recent head ecc45b1. Consider uploading reports for the commit ecc45b1 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #800   +/-   ##
=======================================
  Coverage   90.13%   90.14%
=======================================
  Files          27       27
  Lines        1815     1816    +1
  Branches      336      283   -53
=======================================
+ Hits         1636     1637    +1
  Misses        134      134
  Partials       45       45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@jairhenrique cool! Let me revert the error-trigger commit and see if CI gets all green…

@jairhenrique cool! Merging…


feat(WEB-7437): [MB][Literature] Use a thumb for author image

This is done by adding another input as an indirection to the live_file_input to prevent immediate upload. A resize hook is then attached to the new input which will resize the incoming image before passing to the live_file_input.
To test: (Based on #248)
Note that all tests below should be done with the master branch of https://github.com/martide/elixir

Since this change hasn't been released yet. In the elixir repository code, replace all written {:literature, "~> 0.1"}, with {:literature, git: "https://github.com/martide/literature.git", branch: "resize"}, Use find and replace in your code editor
Run mix deps.get in your terminal
Run the server mix phx.server
https://localhost:4103/literature/blog/posts
Go to https://localhost:4103/literature/blog/authors add or edit an author
In the profile image, upload a file with width > 160. (Note that if the filename already exists when editing, you may need to rename it so that waffle will replace it with the resized one).
Go to https://localhost:4203/en/blog/authors
Inspect the author image, the src attribute should have an image with a width of 160.

Pull Request Test Coverage Report for Build d6b487754902b0a1099251ba4252023fa3b54311
Details

0 of 15 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 70.699%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

lib/literature/uploaders/profile_image.ex
0
15
0.0%

Totals

Change from base Build 72842f9e57bf56a22b142e93aa240d81f795c979:
-0.6%

Covered Lines:
1274

Relevant Lines:
1802

💛  - Coveralls


Tailor context menus to developer needs

In my opinion, context menus are underdeveloped and not used for dev needs.
The biggest offender, in my opinion, is the context menu is in Source bar. Most of the option are not relevant for development or debugging. Most of the actions can be removed (Emoji, Save As..., search, define). I doubt that all text manipulations are needed, since all devs know shortcut for those operations. Others are relevant at the file level and make more sense in File tab in side navigator.
It would be much better to have basic operations similar to ones in VS Code, go to definition, find all references, and things of that nature.
It would also be super handy to have context dependent options for DOM object. Especially "Scroll into view".
In general, it would be good to have context menu unified as much as possible. For example, make "Store as global" and "Scroll into view" available from Source tab context menu, not only from Elements. I've create another issue on the scroll into view subject here.
It feels like context menus are neglected at this point, and they can have great value for productivity during debugging.
Will be happy to hear what you think, and would love to get involved in discussion and brainstorming of this subject.
Cheers
AB#39424738

Thanks so much for the feedback. This is very valuable, and I agree with you that some of the menus are too crowded with not so useful options. The Sources tool menu when text is selected is a great example.
I think this would need a careful review of each and every menu, to decide what can and needs to be changed.
Your idea to add things like "go to definition" and "find all references" is good, but DevTools doesn't do the same kind of project indexing that VS Code does, and so can't offer as much as VS Code. But I'm sure there are some good things that could be added.
Good point about having "scroll into view" and "store as global" available across all tools!
We'll definitely keep this on our backlog and evaluate/prioritize with the other things we're doing. Thanks for your input.

Ok, I get it regarding indexing. Frankly it's not that needed, simple 'Find in file' as implemented right now does the thing. Usually I miss VS code's F12 ("Go to definition") the moss - quick way jump to between invocations of the function and  it definition. I can do that with F3 then search in open.

Makes sense, thanks for confirming.


Aggregation count: Do not return null categories

Related to https://github.com/CartoDB/support/issues/1368
The issue appeared only if the aggregationColumn wasn't provided, and as it's optional in count  aggregation, it is being provided in the main map screen but not in the embeds.

Ok, seeing https://github.com/CartoDB/Windshaft-cartodb/issues/497 seems that returning a NULL category with 'count' was done in purpose. Needs to be decided then

The decision is to remove the NULL categories in all cases, so I've updated the test that checked it and added some extra test to check that both cases (with and without aggregationColumn) don't return NULL values.


Bug: Newer release for deadline-cloud 0.49.* ?

Describe Behaviour
Hi, I just did a pip install --upgrade for the latest deadline-cloud boto3 and the various dcc submitter projects.
Unfortunately, I was surprised to discover the latest version of this package is not compatible with all those.
$ pip install --upgrade deadline ... Using cached deadline-0.49.3-py3-none-any.whl (249 kB) Installing collected packages: deadline   Attempting uninstall: deadline     Found existing installation: deadline 0.48.9     Uninstalling deadline-0.48.9:       Successfully uninstalled deadline-0.48.9 ERROR: pip's dependency resolver does not currently take into account all the packages that are installed.  This behaviour is the source of the following dependency conflicts. deadline-cloud-worker-agent 0.27.4 requires deadline==0.48.*, but you have deadline 0.49.3 which is incompatible. Successfully installed deadline-0.49.3
Will there be a new release of this that is shortly?
thanks.
Expected Behaviour
the latest version of this package would upgrade in alignment with the latest deadline available.
Current Behaviour
the latest deadline upgraded, but complained about this package
Installing this package rolls back deadline and all depended dcc packages
Reproduction Steps
$ pip install --upgrade deadline-cloud-worker-agent
pip install --upgrade deadline
Possible Solution
No response
Package Version
deadline 0.48.9 deadline-cloud-worker-agent 0.27.4
Language Version
Python 3.9
Dependencies
No response
Operating System
linux
Other information
No response

Thanks for the report @embassytech, im going to close this issue in favour of https://github.com/aws-deadline/deadline-cloud-worker-agent/issues/504.


dockerfile update for http2_badserver_interop

added h2 and twisted python modules

The failures seem unrelated to the dockerfile change. Merging.

We require all failing tests to be listed.


ha efficiency update

ha.py is slow on large datasets 3000+ rows
Iterating the dataframe in a for loop is slow
HA_open and HA_close to list and iterate the list
between 40x to 60x efficiency improvement

Hello @BCusack,

ha.py is slow on large datasets 3000+ rows

Yes.

Iterating the dataframe in a for loop is slow

Yes. I knew there was a quicker implementation.

HA_open and HA_close to list and iterate the list
between 40x to 60x efficiency improvement

Awesome! Thanks for contributing! 😎
Kind Regards,
KJ

@BCusack,
Would you mind checking out the development branch and updating HA and making a new PR? If not I will make the changes and update development.
Thanks
KJ

Sure thing - later today 👍

@BCusack,
Anytime this week. Trying to knock out some low conflict code where possible. 😎

Hi @twopirllc
I just checked on the dev branch for ha and found  - https://github.com/twopirllc/pandas-ta/pull/592
This depends on the Numba lib which is compatable with python 3.10 or later and may not be future proof (I occassionally use 3.11).
The pull request I propose uses zero lib dependancies and on a quick test is still faster than the 592 pull solution.
Low spec test machine
With simple list: 0.03125s
With numpy/numba: 2.484375s
I can complete timeit tests later this week - just a bit swampt ATM.
Would you like me to still pull to dev?
Regards
BCusack

@BCusack

Low spec test machine
With simple list: 0.03125s
With numpy/numba: 2.484375s

Nice!

Would you like me to still pull to dev?

The merge will give you contribution. Up to you. 😎
KJ

@twopirllc
Can be closed - moved to dev - https://github.com/twopirllc/pandas-ta/pull/662


SDXL? :)

Hey!
Will this be updated to work with SDXL in A1111? :) This is such an awesome little gem, but I miss it when working with SDXL. I know the process is a bit different, but I don't use the refiner and rely on sharp models to begin with!
Thanks for considering it! ❤

I don't think anything broke or changed related to SDXL - likely you're encountering whatever dev branch change caused #60

When activating it, it doesn't work when used with XL on A111 1.6.0 but maybe it's something else? ;) Thanks for the response though!

I guess it is, but will try again!


⚠ Samsung has degraded performance

In 5d2b966, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2485 ms

Resolved: Samsung performance has improved in e594d65.


3-D Map construction

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

KIndly, assign me this issue.

Hey @mansi75, the issue template is made for you so that you can follow that and describe what the issue/feature is all about. Please use that to let us know what exactly you are up to. Thank you.


docs(): Fix a typo in the warning header

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update. Fix a small typo in a comment in  $compile
Other information:
My first contribution to angular.js 😄

I signed it!

I signed it!


Support differing batch sizes at train and test time

Due to the pre-allocation of intermediate matrices (like pre-activations), the settings used for batch sizes at training time, will automatically be expected at test time. This creates problems if we expect these to differ (ex. no mini-batch training where the batch size is the number of records).

As batch_size is no longer stored as part of model parameters, we are successfully able to train a model with one batch size, save it, load it, then use it to generate predictions of a different batch_size.


Implement BindingMode for pattern matching.

Implement BindingMode for pattern matching, so that types can be
correctly inferred using match ergonomics. The binding mode defaults to
Move (referred to as 'BindingMode::BindByValue` in rustc), and is
updated by automatic dereferencing of the value being matched.
Fixes #888.

Binding modes in The Reference
rustc implementation (and definition of BindingMode)
Match Ergonomics RFC

bors r+


Models to XML

I'm trying to use Pydantic to create models from data in CSVs and it's doing the job perfectly. I'm using multiple models then referencing them from within the others.
My motive is to dump the data in the main Model as an XML. Would you recommend a way to do this or is the best way to go about it - iterate through each object and generate the XML as it comes?

I haven't done this, so best to try for yourself.
You might want to use model.__fields__ to get the types of each field, or you might just use model.dict().
Let us know if you have trouble with anything.

Hey - I was wondering if anything ever came from this. I'm looking into this use case at the moment. The easiest option might be going from JSON to XML - as suggested - but if there was an inbuilt option that would be awesome!

@SammyHerring one option would be using dicttoxml


Fix #505

The -o flag in the ps command allow to specify the column width, so setting a fixed, and relatively wide value, should fix the issue.

This looks an awesome fix ! Thanks !
I just wonder if this is a portable solution on all "ps" implementations. Can you test this is accepted by "ps" on centos 6/7, debian stretch/buster, ubuntu xenial/bionic and maybe some BSD ? I'll test this ASAP.

Is tested in Debian Testing/Unstable/Stable that share the same ps version 3.3.15, but I will try to test it on Debian Stretch and in CentOS 6/7 too. For BSD, I can't promise anything... :sweat_smile:

This looks good on old distro too.
Merged, thanks!


Added SKAdNetworkItems as in the official docs

Source: https://developers.google.com/admob/ios/ios14#skadnetwork

I think, all SKAdNetworkItems needs to be removed in README.md. Because it is too long and developers can click more info. Readme file appears on this package's pub.dev page, so it is better to keeping it short. Developers shouldn't scroll a lot to see package usage.

Thank you all for this PR! 🚀


Bug since v4.22.2p3

#323

Coverage decreased (-0.09%) to 95.644% when pulling f556f18c31696e547f3a3b995338acf7bf085767 on bug-since-v4222p3 into 6d5e24a2d12bd2b06dd7e11469fa6e7feb596562 on master.


ViewPagerAndroid renders empty dynamically added views after upgrade from v0.42.3 to v0.44.2

Description
I have an array to store children views for ViewPagerAndroid, as I dynamically append views to the array, I am expecting to see newly added views to be rendered as I swipe through the pager, it was working however after the upgrade from v0.42.3 to v0.44.2, it is currently rendering empty views.
Reproduction Steps and Sample Code
 addPage() {
    let pages = this.state.pages
    pages.push(<View style={{ flex: 1 }}><Text>{'New Page'}</Text></View>)
    this.setState({ pages: pages })
  }

  render() {
    return (
      <ViewPagerAndroid ref='viewPager'
        {...this.props}
        style={{ flex: 1 }}>
        {pages}
      </ViewPagerAndroid>
    ) }

Solution
Going through the upgrades changes, it seems to call for a re-render upon layout change on the container.
I am doing a bad hack for now is to adjust the layout so as to trick a render to occur. Modifying the style with marginBottom of 1px seems subtle enough for me.
       <ViewPagerAndroid ref='viewPager'
        {...this.props}
        style={[{flex: 1}, {marginBottom: pages.length % 2 == 0 ? 1 : 0 }]}>
        {pages}
      </ViewPagerAndroid>

Additional Information

React Native version: v0.44.2
Platform: Android
Development Operating System: Windows 10

I'm also experiencing this, so I have also a hack in place to trigger a re-render so the view shows. I also encountered this issue while using (react-native-community/react-native-tab-view)[https://github.com/react-native-community/react-native-tab-view] when using the lazy option.

Should be similar to #13463, see my comment there for a work around fix.

We could build a simple workaround this way:
https://github.com/facebook/react-native/issues/13463#issuecomment-310896400

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!
If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.


Fix input type reset

$this->Form->control(__('Reset'), ['type' => reset, class => 'btn btn-default btn-sm']);
Adds to input class form-control.
Before:

<input type="reset" class="form-control btn btn-default btn-sm" value="Reset">

After:

<input type="reset" class="btn btn-default btn-sm" value="Reset">

If you want reset buttons, you need to use submit: https://book.cakephp.org/3.0/en/views/helpers/form.html#creating-buttons-and-submit-elements
What do you get with submit?

If you add the button "manual" then you can use Submit instead of Input.
However, if you use Controls to add several inputs at once, then that is when Control must detect if it is a Reset button.
$this->Form->controls($fieldset, ['legend' => false]);

I see what you mean, but in this case it's a CakePHP bug, so you should PR on their side. There are special "handlings" for submit in control() (and indirectly in _getInput) which are not manager for reset(), so you should open an issue / submit a PR directly to CakePHP.

Workaround finded.
Using "templates" option:
php $this->Form->control(__('Reset'), ['type' => reset, 'templates' => ['input' => '<input type="{{type}}"{{attrs}}>'], class => 'btn btn-default btn-sm']);


Dynamic category legend.

Hi guys is there any possibility of the category legends to be dynamic??
Related - https://github.com/CartoDB/design/issues/1092

There is a ticket in RT dashboard (waiting to enter the TODO column) about this same issue: #11102


.extract() after composite() not working

Possible bug
Is this a possible bug in a feature of sharp, unrelated to installation?

[x] Running npm install sharp completes without error.
[x] Running node -e "require('sharp')" completes without error.

If you cannot confirm both of these, please open an installation issue instead.
Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.
If you are using another package which depends on a version of sharp that is not the latest, please open an issue against that package instead.
What is the output of running npx envinfo --binaries --system --npmPackages=sharp --npmGlobalPackages=sharp?
System:
OS: Windows 10 10.0.19044
CPU: (8) x64 Intel(R) Core(TM) i7-4790 CPU @ 3.60GHz
Memory: 2.83 GB / 15.94 GB
Binaries:
Node: 18.16.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
npm: 9.6.6 - C:\Program Files\nodejs\npm.CMD
npmPackages:
sharp: ^0.32.1 => 0.32.1
What are the steps to reproduce?
const sharp = require('sharp');
async function cropImage() {
  try {
    await sharp({
      create: {
        width: 800,
        height: 600,
        channels: 4,
        background: { r: 0, g: 0, b: 0, alpha: 0 },
      }
    })
    .composite([{
      input: 'test.png', // test.png is picture 400x300
    }])
    .extract({
      top: 0,
      left: 0,
      width: 200,
      height: 150,
    })
    .toFile('result.png');
  } catch (error) {
    console.log(`An error occurred during processing: ${error}`);
  }
}

cropImage();

What is the expected behaviour?
Expected cropped area of test.png image in file result.png, but i have error:
An error occurred during processing: Error: Image to composite must have same dimensions or smaller
Please provide a minimal, standalone code sample, without other dependencies, that demonstrates this problem
See above.
Please provide sample image(s) that help explain this problem
test.png

You'll need to split this into two pipelines, generating the composited image in the first then extract the required area in the second.
The docs for composite hint at this, but I'll update these to make it clearer that extract is also included.

Any resize or rotate operations in the same processing pipeline will always be applied to the input image before composition.

https://sharp.pixelplumbing.com/api-composite#composite

I hope this information helped. Please feel free to re-open with more details if further assistance is required.

@nick-kang Yes, that looks good.


Something to reload info

Is it possible to reload the info like title and url dynamically? Could be very helpful

@gabo2595 No, it isn't possible now.
I think that we can use functions instead of immutable strings in options for this.
PR welcome :)


Outsource supportedAlleles of predictors

Readability of code in EpitopePrediction can be increased by outsourcing the set of supportedAllels to files instead of listing them in the code

In PR #77 a few issues were identified, which have been introduced by this feature


Make the example configurable

Configurable MIDI device index
Configurable MIDI channel

Depends on:

https://github.com/geomyidia/erl-midi-server/issues/6

Done.


New style queries - fixes #2041

Well, the code still merges, so I guess I can just send the PR. :angel:
I never planned to switch all the queries to this style in a PR, just "encourage" the use in future queries and maybe convert while going on.

Maybe I should make some of the commit message more "nice"?


changelog: add missing issue link

I think I need to start linting the Markdown :)

Codecov Report

Merging #197 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   92.98%   92.98%
=======================================
  Files           4        4
  Lines         399      399
=======================================
  Hits          371      371
  Misses         28       28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b224787...ee0852c. Read the comment docs.


Range support

Range support
A range SlimTrie is same as a key-value SlimTrie internally.
The only difference is a range SlimTrie uses two keys(starting and ending key) to represent a range.
// Create a range SlimTrie with 3 range:
// ["a", "p"] --> 1
// ["q", "q"] --> 5 // a range with only one item.
// ["r", "z"] --> 3
st, err := NewSlimTrie(xxx, []string{"a", "p", "q", "r" "z"}, []int32{1,1, 5, 3, 3})

Creating a SlimTrie with range support is the same as creating a normal SlimTrie, except that two adjacent keys(start, end for a range) have the same value.

Add example_range_test.go to illustrate how to create/use a range SlimTrie.

Rewrite tests for the new range support. Also the max number of keys in a range SlimTrie can be determined before creating it.

Add trie/README.md explaining how range SlimTrie works.

trie.Node.Append(): remove argument isStartLeaf and attribute Node.isStartLeaf, which is not required anymore according to latest design.

Push to branch "release-0.3"

This issue is finished. Use RangeGet(key) to get the value of the key located in a range.

This issue is finished. Use RangeGet(key) to get the value of the key located in a range.


Re add e2e reading

Proposed changes:

last part of the revert of https://github.com/RasaHQ/rasa/pull/6518
add support for reading end-to-end stories for training Rasa Open Source

Status (please check what you already did):

[x] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

@wochinge, we also need our md reader back for now as well, because we have e2e stories only in md

It doesn't make any sense adding it back in as we can't merge it to master anyway. I suggest to convert the stories.

yes, we'll see about removing it, but for now we need it. It is already implemented and it doesn't make sense to waste time on converting stories

You have to convert these anyway before we are merging back to master, haven't you? The decision for Markdown was made so I don't see why we should do work which we will have to throw away anyway.

no we don't have to convert these stories

because when I suggested to create separate branch, you said you'll return everything back! Please do it

Ok, makes absolutely no sense to me, but I can do it. I'm pretty busy with RC related tasks at the moment, so I'll have to see when I get to this.

cool thanks

@Ghostvv too many things changed in the markdown reader - I don't think it's worth the time to reapply all these changes.

@evgeniiaraz can we continue working without markdown?

@Ghostvv we can, but it will eat a bit of time on my side, but it's not the end of the world though.

ok, @wochinge then could you please finish PR without markdown

@evgeniiaraz The production code implementation changed slightly as support for end-to-end testing was added on master


C++-Reversestring

Pull Request Type
What kind of change does this PR introduce?
[ ] Solved an issue/task
added ReverseString.cpp this file include a method to reverse a given string using c++ lang

Merged

This is an automated message from Fork, Commit, Merge [BOT].

Thank you for your contribution! Your pull request has been merged. The files have been reset for the next contributor.
What's next?
If you're looking for more ways to contribute, I invite you to check out our forkcommitmerge.io website repository. The repository contain real issues that you can help to resolve or create some of your own if you see any bugs or want to add new features to the site, etc. You can also check out the Influences section in the README to find more projects similar to this one.
Also please leave a star to this project if you feel it helped you, i would really appreciate it.
I look forward to seeing your contributions!


nalgebra support in pixelcolor

Being able to transform colors to/from nalgebra vectors can be pretty handy for certain applications.
Seeing as though nalgebra is already an optional dependency, it is perhaps a sensible enhancement.  Or it is scope creep and belongs outside of this crate?  What do you reckon?

Do you have a specific use case in mind? It's a bit of feature creep, but as you said we already have the optional nalgebra dependency anyway and I would be OK with adding this.


Support for hooking into the parser process?

As an alternative to stubbing out required functionality used in the templates (like Html.Raw and friends) I was thinking that an easier way out is to support replacements for various code calls.
For instance, if coming across Url.Route(foo, bar, { foo : bar }) it could be substituted with the static string "/foo/bar" before trying to execute the compiled template later on.
Instead of writing my own (bad) Razor parser from scratch, I was thinking that it might be possible to hook into the Razor parser directly, somehow, to do such things. Is this in any way supported by the current RazorEngine code?

RazorEngine doesn't actually contain any parser code at all, we just use the Razor engine (the MVC engine actually sits on top, exactly like we do). So basically the answer is no you can't (at least from our perspective).
On the other side the raw Razor Api gives you a lot of  extension points and is now open source since version 4: https://github.com/aspnet/Razor (MVC is here https://github.com/aspnet/Mvc by the way)
Since this is all new it might be possible to use the real MVC classes now as they should be pretty self contained because of moving to corefx and stuff.

Ok, thanks. Looking into it.


[Bug]: Error: Could not find Chrome in production environment

Bug expectation
I expected my app in production (Linux) could download a generated report file using the puppeteer library. It works safely in my local environment (windows).
What happened instead was an error while downloading the file in the production environment so the pdf could not be generated. The error message is shown below:
Error: Could not find Chrome (ver. 114.0.5735.133). This can occur if either
1. you did not perform an installation before running the script (e.g. `npm install`) or
2. your cache path is incorrectly configured (which is: /home/support/.cache/puppeteer).

For (2), check out our guide on configuring puppeteer at https://pptr.dev/guides/configuration. at Chrome Launcher.resolveExecutablePath (/home/auction/node_modules/puppeteer-core/lib/cjs/p at Chrome Launcher.executablePath (/home/auction/node_modules/puppeteer-core/lib/cjs/puppeteer: at Chrome Launcher.computeLaunchArguments (/home/auction/node_modules/puppeteer-core/lib/cjs/1 at async Chrome Launcher.launch (/home/auction/node_modules/puppeteer-core/lib/cjs/puppeteer/1

I used Chrome ver. 114.0.5735.134 (Official Build) (64-bit). I ran npm ci and npm install puppeteer but nothing changed.
The ./cache/puppeteer directory is automatically created in the local environment but not in the production.
Any help will be appreciated.
Bug behavior

[ ] Flaky
[ ] PDF

Minimal, reproducible example
const puppeteer = require('puppeteer');

async generateStream(payload) {
        const browser = await puppeteer.launch({headless: true, userDataDir: './.cache/puppeteer'});
        const page = await browser.newPage();

        const template = fs.readFileSync('./template/reports/my-template.html', 'utf-8')
        const html = mustache.render(template, payload)

        await page.setContent(html);
        await page.emulateMediaType('screen');

        const pdf = await page.pdf({
            format: 'A4',
            printBackground: true,
            preferCSSPageSize: true
        })
        await browser.close();

        return new Promise((resolve, reject) => {
            const stringBase64 = Buffer.from(pdf).toString('base64');
            return stringBase64 ? resolve(stringBase64) : reject('ERROR GENERATE');
        })
    }

Error string
Error: Could not find Chrome (ver. 114.0.5735.133). This can occur if either 1. you did not perform an installation before running the script (e.g. npm install) or  2. your cache path is incorrectly configured (which is: /home/support/.cache/puppeteer).   For (2), check out our guide on configuring puppeteer at https://pptr.dev/guides/configuration.
Puppeteer configuration
No response
Puppeteer version
20.5.0
Node version
v16.14.0
Package manager
npm
Package manager version
8.3.1
Operating system
Linux

Do you run npm install in your production environment? How do you deploy? can you check if the binary is there is in your production environment (at  /home/support/.cache/puppeteer)

Unable to reproduce, so I assume it is a misconfiguration when deploying to the server. Make sure to follow the guidance displayed in the error message: run npm install (npm ci) during or after deployment to the new environment; or change the configuration to download browser binaries inside your local folder. See https://pptr.dev/#installation and https://pptr.dev/guides/configuration

is it necessary to create a /home/support/.cache/puppeteer directory?

@ainuraliyah it is where the cache directory is located on your server. If you run npm ci for installing puppeteer on the server, it is where Puppeteer would download the browser. Alternatively, you can re-configure the cache location but since your local system is a Windows, you still would need a binary for Linux.


Include options to use scikit-learn predictions

Include widget to show scikit-learn classes predictions options to process and show the results.

See too https://automl.github.io/auto-sklearn/stable/

Prediction methods, at this point, is not necessary.


Prevent regeneration

Is there an environment variable that we can use to conditionally stop regeneration (opposite of FORCE REGENERATE I suppose)? We're in a position where our build project references the "main" project that contains the Facil generated code etc., and under certain conditions we end up stuck where the build project can't run because the main project needs to build itself first, but that fails because Facil tries to connect to the DB to regenerate itself - but fails because the database doesn't exist, because the build process hasn't yet run...

Sounds like a simple thing to implement! But given your issue, it also kinda sounds like I would be implementing a foot-gun, or at least something that does not push you into the "pit of success". So I'd like to understand your issue a bit more first.
 This seems like a bad idea, as it gives the issue you describe. This is a cyclic dependency: Facil depends on the DB which depends on the code generated by Facil. Since you're an F# dev, I'm sure I don't have to tell you that cyclic dependencies are evil. Moreover, it's an unnecessary cyclic dependency: If it were actually necessary, it would of course be impossible to ever build the project.
I of course have very limited information to go on regarding your code, but given what little I can infer, I would strongly recommend you to refactor to remove the cyclic dependency. There seems to be no reason why the Facil-generated code that uses a DB should be a dependency of the code that sets up the DB. If you disagree, I am guessing Facil is generating code from multiple DBs, and can be split into multiple projects.
For the record, I always have a dedicated project for Facil-generated code (which I usually just call "DbGen"). This gives the following benefits:

No weird dependencies; the only reason to reference the project is to use the Facil-generated code.
Improved compilation times, since the Facil-generated code (which may be sizable) does not need to be re-compiled whenever something else changes
I can have a project file like this, which automatically picks up new SQL scripts, changes to SQL scripts and Facil config, etc.

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net6.0</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <None Include="SQL\**\*.sql" />
    <None Include="facil.yaml" />
    <Compile Include="*.fs" />
  </ItemGroup>

  <ItemGroup>
    <UpToDateCheckInput Include="SQL\**\*.sql" />
    <UpToDateCheckInput Include="facil.yaml" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="Facil" Version="2.5.7" />
    <PackageReference Update="FSharp.Core" Version="6.0.6" />
  </ItemGroup>

</Project>

Should probably officially document this somewhere...
In any case: I have probably spent longer just writing this than I would have spent implementing the flag you request, but I really want to make sure that it's not a bad idea, and right now I think it may be, since it may push developers out of the "pit of success".

Hi @cmeeren and thanks for the detailed reply :-) And yes, we know that this is not an ideal place to be in. The reason for it is that the build project is also used not just for standard CI build but for some automation and ad-hoc operational business tasks that use types and functions from the "main" project. I'm hoping that we can move away from this approach in the short/medium term.
Splitting the Facil related code into its own project sounds like a really good idea and might work around the issue we're seeing here anyway, so we'll give that a try - thanks.
Would you mind leaving this issue open for discussion (or closing it and moving to a dedicated Discussion in the repo?).

Sure, I'll leave it open for the time being. 👍

Can you ping me privately - Twitter or some DM solution (email?) - if you're interested, it might be good to jump on a quick call to talk about things.

I'm closing this issue since I think it is best solved by the tips I have provided, but feel free to continue discussion. I will re-open if I am convinced that something needs to be changed in Facil.


PROGMI-242 Add site_name and build_context vars

@RobLoach I'm pretty sure we don't need this anymore


Unable to expand abbreviation "!" (basic HTML page) when working on .erb files

Trying to expand "!" results in "<!></!>" instead of the basic HTML structure. Only happens when working on .erb files. Expanding "!" into the basic HTML structure works fine when working on .html files.
Mac OS X Mavericks
Atom 0.115.0

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

Probably duplicate of #104.


Duplicate identifier 'p0' error in JSDOC comments

From @4kochi on March 3, 2016 9:4
I have a node.js javascript file with some functions. The functions have JSDOC comments. Since the latest insider build (0.10.10-insider, Mac OS X 10.11.3) i got errors from the IDE.
Duplicate identifier 'p0'
See the screenshot below.

Here is the code:
module.exports = function () {
    var self = {};

    /**
     * Gets all messagess from db.
     *
     * @param {!object} req The request object.
     * @param {!object} res The response object.
     * @param {function(error)} next The next middleware in the express.js stack.
     */
    self.getAll = function (req, res, next) {
        repo.find({}, function (error, result) {
            if (error) {
                return next(error);
            }

            res.status(200).json(result);
        });
    };

    /**
     * Remove all messages in same room.
     *
     * @param {!object} req The request object.
     * @param {!object} res The response object.
     * @param {function(error)} next The next middleware in the express.js stack.
     */
    self.removeAll = function (req, res, next) {
        repo.deleteMany({}, function (error, result) {
            if (error) {
                return next(error);
            }

            res.status(200).json(result && result.result.n);
        });
    };

    return self;
};

Renaming the param error in the comments did not resolve the error message.
Copied from original issue: Microsoft/vscode#3664

I can reproduce it - moving to TypeScript

Duplicate https://github.com/Microsoft/TypeScript/issues/6993