Add Pinch Gestures and improved other gesture recognizers

What does the pull request do?
Adds a pinch-zoom gesture recognizer, PinchGestureRecognizer, along with some changes to the other gesture recognizers.
Changes

ScrollGestureRecognizer.ScrollStartDistance is now a DIrectProperty
Removed redundant pointer event handlers in PullGestureRecognizer
Added a Gestures sample page demonstrating Pull and Pinch-Zoom Gestures

Added API

PinchGestureRecognizer
PinchEventArgs

double Scale { get; }
Point ScaleOrigin { get; }

PinchEndedEventArgs

PinchGestureRecognizer does not do any direct manipulation of the attached visuals.
What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

[ ] Added unit tests (if possible)?
[ x ] Added XML documentation to any related classes?
[ ] Consider submitting a PR to https://github.com/AvaloniaUI/Documentation with user documentation

Breaking changes

Obsoletions / Deprecations

Fixed issues
Fixes #3430

You can test this PR using the following package version. 11.0.999-cibuild0027796-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0027823-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]


Passing RawCreateParams to z.tuple() doesn't apply to all errors generated by z.tuple().

Example:
const schema = z.tuple([z.string(), z.number()], { message: 'this doesnt look right' });
schema.parse([]);

This will throw with a ZodIssue of { too_short, 'Array must contain at least 2 elements' } instead of the supplied message.

Maybe I am misunderstanding what the purpose of the message argument in RawCreateParams is, but if I [read this correctly]h9https://github.com/colinhacks/zod/blob/19687315b5b24bbd1ff6c346bfc2975700221748/deno/lib/types.ts#L139-L148) then message seems to only be used under a few very specific circumstances. Is this intended?

So I just read the pull request and issue that relatively recently added message.
Maybe I'm still lacking some insights here but I kinda agree that adding the message shorthand may have been a mistake in terms of ergonomics and clarity. But since it's there it should definitely apply to all errors, not just the two preexisting shorthands plus the invalid_enum_value. That just does not make any sense and the very general name of message provides no inidication, that that is the behavior one should expect.

Here's a little code snippet that achieves the desired effect nicely without any changes in zod itself.
const zMapAll = (message: string) => {
  return { errorMap: () => ({ message }) };
}
const schema = z.tuple([z.string(), z.number()], zMapAll('this doesnt look right'));
schema.parse([]);

I think the main problem for most people is ergonomics of defining an error map combined with the overall complexity of the example in the error map documentation.
I understand that the intention in the documentation is to demonstrate the power of the zod error mappng API, but most people are probably just looking for an easy way to drop in a different error message for any given validator. Maybe adding a simple example to the documentation could be a great way to help with that while reducing confusion and bad API changes.


Test explorer is not discovering mocha tests in the subdirectories

Expected Behavior
Test explorer should show all tests in sub-directories
Actual Behavior
Only shows tests in the root directory

NTVS Version: --
Visual Studio Version: 2017
Node.js Version: 6.9.1

Steps to Reproduce

I have a nodejs project with a file which its Testframework is set to Mocha and created a test suite/test in it.
Import another JS/TS file that is in a different project
msbuild will compile and output the test file into a sub-folder instead of into the root
Test explorer could not discover it

I'm not sure I understand your repro, can you create a sample project and put it on GitHub so I can take a look?

I was unable to reproduce this.

I have the same issue:
Microsoft Visual Studio Professional 2017, Version 15.4.4
Node.js Tools   1.4.10918.1
I saw in the "test" output window that VS was searching the file in the sub-directory "tests", but not finding any tests. I moved my test file up from "\tests" directory to ""  and now I see my tests in the test explorer.
If I add the test file to both directories, "\test.js" AND "\tests\test.js". Now, VS will discover both sets of tests, but the files must contain the same tests. This can be used as a workaround, I then  group tests by "namespace" and just run the tests in the sub-directory.

Hi,
Even after following the above steps in VS 2017, Mocha Test is not getting discovered in my project.

I have installed mocha in the project within the solution. (My solution has 3 projects)

I have set the Test Framework in the properties window to Mocha. In fact adding a new file of type "Typescript Mocha Unit Test file" automatically sets.

I have bothe describe and it . Sample code below.
describe("Test Suite 1", () => {
it("Test A", () => {
assert.ok(true, "This shouldn't fail");
});
it("Test B", () => {
assert.ok(1 === 1, "This shouldn't fail");
assert.ok(false, "This should fail");
});
});

Any idea why this behaviour?

In addition to @sath002 's proposal, I solve the issue I have due to typescript by adding the following lines to my settings.json:
{
    "mochaExplorer.files": "test/**/*.ts",
    "mochaExplorer.require": "ts-node/register"
}


add gpu test notebook

Short notebook to confirm JH is using GPU's

@erikerlandson I added a bit more content to this notebook. Take a look and let me know if its ready to merge : )

:tada:


Surround subquery in the args aggregate function

Coverage increased (+0.001%) to 98.288% when pulling a7eaa7582bbf1b4bd98b0f5b477d6a6a4dd6cb46 on magiskboy:subquery-in-function into 011a4f86ce97b24a4a72c8060686435ef12d0266 on kayak:master.

That seems to be a duplicate of https://github.com/kayak/pypika/pull/566. I'd merge this if the conflicts are addressed. Or https://github.com/kayak/pypika/pull/566 in case the author adds tests.

Why? This pr is more early than #566

@magiskboy like I said there is a conflict in this, so I cannot merge it now. Either you fix it or #566 adds tests. I'll merge whatever happens first.


Make it work for the new WordPress editor

https://try.wpdemo.net/ WordPress 6.2

Works with "Only change visible content?" checkbox.


Fix mjml-column can deal with one children

Hello thanks for your PR,
I'm not fully understand why you need React.map ?
<mjml>
  <mj-body>
    <mj-section>
      <mj-column>
        <mj-text>Hello</mj-text>
      </mj-column>
    </mj-section>
  </mj-body>
</mjml>

Please see: https://facebook.github.io/react/tips/children-props-type.html

Usually, a component's children (this.props.children) is an array of components

However, when there is only a single child, this.props.children will be the single child component itself without the array wrapper. This saves an array allocation.

When you deal with React component children you need to use React.Children utilities.
https://facebook.github.io/react/docs/top-level-api.html#react.children
To fully understand, here is a snippet from my own component module:
  render() {
    const { mjContent } = this.props;

    const content = cleanContent(mjContent());

    return (
      <MJMLSection parentWidth={this.props.parentWidth} padding="0 10px">
        <MJMLColumn width="100%">
          <MJMLText
            color="#000000"
            font-family="Helvetica, Arial, sans-serif"
            font-size="24px"
            font-weight="bold"
            padding="20px 0 10px"
          >
            {content}
          </MJMLText>
        </MJMLColumn>
      </MJMLSection>
    );
  }

In this case you're using mjContent that rely on that technique https://github.com/mjmlio/mjml/blob/master/packages/mjml-core/src/decorators/MJMLElement.js#L80
props.children is overriden by buildProps on mjElement too, so that shouldn't be an issue here ?

But issue is not related to mjContent. Let's say we have own simple component <my-hello-world-text /> with source code similiar to mine:
render() {
    return (
      <MJMLSection>
        <MJMLColumn width="100%">
          <MJMLText font-weight="bold" color="#ff0000">
            Hello World!
          </MJMLText>
        </MJMLColumn>
      </MJMLSection>
    );
  }

Usage:
<mjml>
  <mj-container>
    <my-hello-world-text />
  </mj-container>
</mjml>

Error occurs TypeError: children.map is not a function
Issue was introduced in commit https://github.com/mjmlio/mjml/commit/e31506c1e5c4b7c75f82ee9a3a586d53011ace07#diff-f05055ec67f20a0c84b13f69f0a3998cL128

Sure i can fix all my components and ensure having array inside <MJMLColumn>, but I think it's not best solution.

I get it ! Thanks for the PR and for the explanation 👍

Thank you


Every list element is on one line

Hello
$ ruff --version
ruff 0.6.6

I have this list:
data = [
    0x9B, 0x02, 0x20, 0x02, 0x80, 0x00, 0x04, 0x80, 0x00, 0x01,
    0x80, 0x00, 0x01, 0x02, 0x04, 0x10, 0x01, 0x04, 0x4B, 0x02,
    0x40, 0x40, 0x80, 0x00, 0x45, 0x02, 0x40, 0x40, 0x80, 0x00
    ]

But ruff formatter makes it like this:
data = [
    0x9B,
    0x02,
    0x20,
    0x02,
    0x80,
    0x00,
    0x04,
    0x80,
    0x00,
    0x01,
    0x80,
    0x00,
    0x01,
    0x02,
    0x04,
    0x10,
    0x01,
    0x04,
    0x4B,
    0x02,
    0x40,
    0x40,
    0x80,
    0x00,
    0x45,
    0x02,
    0x40,
    0x40,
    0x80,
    0x00,
]

What I have done:

In settings.json file I have added this: "ruff.lint.ignore": ["COM812"], but it does not worked for me. I have tried this both on linux and windows.
on windows under C:\Users\buser\AppData\Local\Programs\Python\Python311-arm64\Lib\test I have found .ruff.toml file. I have added this line (at the end) ignore = ["COM812"]; also this does not work!
I have created .ruff.toml file in my linux machine's home directory and add those lines and nothing changes:

[lint]
ignore = ["COM812"]

[format]
# Like Black, respect magic trailing commas.
skip-magic-trailing-comma = true

I have longer lists! like 1024 bytes. And it is very very annoying when all elements are on one line separately!
What is the solution? How can I make formatter not to put single element on a newline? Especially; can I fix this just by editing settings.json?
P.S. folks sorry for my bad English; not my mother tongue.

Hi @xJrJackBlack
No, you can't change the formatting with a setting. But you can use fmt: off or fmt: skip for the few statements where you don't want this specific formatting.
Improving formatting for very long lists is something we want to tackle eventually.
data = [
    0x9B, 0x02, 0x20, 0x02, 0x80, 0x00, 0x04, 0x80, 0x00, 0x01,
    0x80, 0x00, 0x01, 0x02, 0x04, 0x10, 0x01, 0x04, 0x4B, 0x02,
    0x40, 0x40, 0x80, 0x00, 0x45, 0x02, 0x40, 0x40, 0x80, 0x00
] # fmt: skip

However, note that this will disable all formatting for that statement

Great thanks for your immediate reply # fmt: skip works without any additional setting for me!
I hope that feature will come sooner 😊
close #13751


Using SQL_CALC_FOUND_ROWS with eager-loaded relationship returns wrong count

Laravel Version: 5.1.45
PHP Version: 7.0.12
Database Driver & Version: MySQL 5.7.15

Description:
In my Laravel app I was doing an ordinary query on a model (ModelA) whilst making use of SQL_CALC_FOUND_ROWS and then performing SELECT FOUND_ROWS() afterwards to retrieve the count of all records since the first query used LIMIT and OFFSET.
This worked perfectly fine, but now that I've added a relationship to the model I was querying above, if I do the same query but using with->('modelB'), this query is performed after the initial query and before SELECT FOUND_ROWS() so I get the count of the ModelB results instead of ModelA as I was expecting.
Is there a way to make this work as desired where I get the count of the first (main) query and not the relationship?
e.g. This works fine:
$query = ModelA::select([DB::raw("SQL_CALC_FOUND_ROWS *")])
    ->where('active', 1);

// conditional ->where()'s

$query->skip(intval($skip))
    ->take(intval($take))
    ->orderBy($column, $dir);

$results = $query->get();

$total = DB::select(DB::raw("SELECT FOUND_ROWS() AS 'total';"))[0]->total;

but changing the first line to this doesn't:
$query = ModelA::with('modelB')
    ->select([DB::raw("SQL_CALC_FOUND_ROWS *")])
    ->where('active', 1);

A workaround is to just do it without eager-loading and fetch each relationship individually but then I'd have one query per result when I loop through the results later in the code.

That makes sense because with eager loading you're running a second query, so the results of SQL_CALC_FOUND_ROWS is presented with regards to the second query because it's the latest query.
Not sure what's an alternative way for that since it depends on your case; however, I suggest that you ask this question on the forums since this repo is for bug reporting only, maybe there you'll find more help :)

You can also use Constraining Eager Loads for first relation.
$total = 0;

$query = ModelA::with([
    'modelB' => function () use (&$total) {
        $total = (int)DB::select("SELECT FOUND_ROWS() as `row_count`")[0]->row_count;
    },
    'modelC',
])
->select([DB::raw("SQL_CALC_FOUND_ROWS *")])
->where('active', 1);

$rows = $query->get();

echo $total;


Investigate Undo Support

What is required to implement undo support for both the local editor and the remote?
This could be separate solutions if it makes more sense to leverage UnityEditor.Undo for the local editor, or it could be a single unified solution.

Now only needed for local editor, remote inspection has been deprecated


Change to LibraryImport

Change all uses of DllImport to LibraryImport
https://learn.microsoft.com/en-us/dotnet/standard/native-interop/pinvoke-source-generation

FFI stands for foreign function interface. I am not sure if the name can be separated out into a separate file. It is not something I have seen before, although I get the incentive. Maybe the string can be defined in the .csproj file and then replaced compile-time by the build system?

Nvm, managed something. It is now defined in the Util.cs file, although it could maybe be moved more out.


PyPy from shapely.geos import causes "TypeError: unsupported operand type(s) for +: 'list' and 'tuple'"

Expected behavior and actual behavior.
PyPy is able to import from shapely.geos.
Steps to reproduce the problem.
While running Travis tests on geoalchemy2.
__________________ ERROR collecting tests/test_comparator.py ___________________
tests/test_comparator.py:5: in <module>
    from geoalchemy2.types import Geometry
geoalchemy2/__init__.py:1: in <module>
    from .types import (  # NOQA
geoalchemy2/types.py:17: in <module>
    from .shape import to_shape
geoalchemy2/shape.py:10: in <module>
    import shapely.wkb
.tox/pypysqla11/site-packages/shapely/wkb.py:4: in <module>
    from shapely.geos import WKBReader, WKBWriter, lgeos
.tox/pypysqla11/site-packages/shapely/geos.py:224: in <module>
    new_func.argtypes = [c_void_p] + old_func.argtypes
E   TypeError: unsupported operand type(s) for +: 'list' and 'tuple'

https://travis-ci.org/github/geoalchemy/geoalchemy2/jobs/662462792#L760
I've tried PyPy and PyPy3.
Tests on Python 2.7, 3.{5,6,7,8} work fine.
Unfortunately I don't have PyPy installed locally to test further.
https://github.com/Toblerity/Shapely/blob/d8ff5de8baee6bbbd8465c92197764cdaaa6395a/shapely/geos.py#L224
Can this be changed to
new_func.argtypes = [c_void_p] + list(old_func.argtypes)
Not that I know if that would work, or quite why it was needed.
Operating system
Linux Ubuntu Xenial (Travis)
Shapely version and provenance
1.70 installed from PyPI using pip.
https://files.pythonhosted.org/packages/44/ec/4eddbf9d17a917c51fb4ad159aa7137f506681e91ab559cf87d120e1d78d/Shapely-1.7.0.tar.gz
libgeos-3.7.1

@cjmayo thanks for the report! I'll look into it.

@cjmayo we haven't had PyPy in the CI build matrix due to past issues with it and a very small number of users, so I must rely on you for a confirmation.

Thanks for the quick update. I've tested geoalchemy2 with https://github.com/Toblerity/Shapely/archive/9ca22240d3272df9598c30878c6f8562e50f1ec8.tar.gz and it is passing all tests with PyPy and Python 2.7, 3.{5-8}.

Faced the same issue. Changing line 224 in geos.py as mentioned by @cjmayo  works

any chance on publishing this to pypi please?


BUG: Comparison of image type tag (0008|0008) was incorrect.

The string tag is required to be of even length. If it is not even
then it is padded with spaces. The specific location of the spaces is
not specified (prefix, suffix, somewhere in the middle).
Change-Id: I29533ca43628e92c68b9928a20c4b3c9fa4bdbeb

Great! Thank you for digging into DICOM to find the correct solution!


Update-Dabase -Script does not generate seed sql

We have disabled automatic migrations. We use Update-Databse to update our local dev databases and migrate.exe to update our dev/test remote database.
However, when deploying for our client, we need to generate a sql script with seed (= referential) data as well.
The Update-Database -Script does not generate the seed sql.

We have discussed implementing scripting for seed data, but it would be pretty complex to do and isn't something our team is planning to tackle on EF6.x. We may tackle it when we implement seeding in EF Core (https://github.com/aspnet/EntityFramework/issues/629).
An option is to not use the built in seed methods, but instead use raw SQL in you migrations (the Sql(...) API) to insert the data. These operations will be included in the generated script.


library not found for -limage_picker

Trying to use the image_picker plugin.
This is what I get from Xcode's Procuct -> Archive
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel beta, v0.5.1, on Mac OS X 10.13.6 17G65, locale en-RO)
[!] Android toolchain - develop for Android devices (Android SDK 27.0.3)
✗ Android license status unknown.
[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
[✓] Android Studio (version 3.1)
[✓] Connected devices (2 available)
! Doctor found issues in 1 category.

It was an issue on my side, no issue with the library.


[libxlsxwriter] upgrade to 0.8.9

Upgrade to the latest version of libxlsxwriter.
Closes #9408

/azp run

@ras0219-msft

/azp run

What does this mean.

What does this mean.

I guess you were using it to re-trigger the CI.

I've made the required changes and force pushed to master to redo the PR.
Thanks for your help.

Thanks for the PR!


Gas saving

Saving some gas by creating a temp variable that stores storage variables for function usage.

Great.


Downloading of dependency sources with gradle idea plugin+task

Works in principle (when invoking the command from cli) but will test in actuality before merging


Prebuilt Binary Fails with GLIBC_2.32 not found

When I try to run the pre-built linux binary, it fails with this error:
/lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.32' not found (required by /bin/ord) /lib/x86_64-linux-gnu/libc.so.6: version GLIBC_2.33' not found (required by /bin/ord)
/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /bin/ord)
Looks like I'm running 2.31
libc6:
  Installed: 2.31-0ubuntu9.9
  Candidate: 2.31-0ubuntu9.9

I'm running Ubuntu 20.04.4 LTS. Guess I need to update, but was just sharing in case you could compile with support for 2.31 in case others have this problem.

@lylepratt Please have a look the response here: https://github.com/casey/ord/issues/1430

yeah I upgraded to 22.04 and am all good. closing this.


500 SERVER ERROR

does not appear as campaigns or the side menu, help me?

Hey @andrelmariano. Pull updated code from repo. I already tested it. Sidebar is working.

Also check the AuthServiceProvider.php. If the gates are introduced properly or not.


find a way to embed new devs and discuss

for now we have one admin team and no real way but github issues to discuss openly.

Hey @filmaj we are looking for an open discussion place, and github teams might be a nice way: could you create another team admins have rights on? adobe-dx-dev that has write access but not admin access on the repository? then we can eventually create child teams of etc...but it looks we can't create one right now.

@adobe/adobe-dx-devs is created and existing members from @adobe/adobe-dx-admins are added. -devs has Write access to this repo.
Closing this but if anything else is needed feel free to ping me.

thanks @filmaj ! https://github.com/orgs/adobe/teams/adobe-dx-devs/discussions works great!


Datetime Picker

Hi,
Is there any way to get datetime picker or any alternatives?
Thanks
Ravi

@chandra2ravi, sorry for the super late reply. We've been busy on projects lately and haven't been able to support some of our open-source work.
As far as new features go: we currently have no plans to create new components for ALJS at this time. This is due to us focusing our efforts in the Lightning Components front with our Strike library (www.lightningstrike.io).
We may be building a Datetime and Time Picker for Strike soon, as there are styles available for them in the Winter '18 release coming up;.


[Discussion] UnicodeDecodeError with vdf.load

We encountered an error where vdf.load(open("config.vdf")) would crash when the vdf file contains an invalid UTF-8 character. This was reported a few times now. See https://github.com/DavidoTek/ProtonUp-Qt/issues/424 for details.
The error occurs in this line of vdf/__init__.py:
  File "/app/lib/python3.11/site-packages/pupgui2/steamutil.py", line 221, in get_steam_global_ctool_name
    d = get_steam_vdf_compat_tool_mapping(vdf.load(open(config_vdf_file)))
                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/vdf/__init__.py", line 211, in load
    return parse(fp, **kwargs)
           ^^^^^^^^^^^^^^^^^^^
  File "/app/lib/python3.11/site-packages/vdf/__init__.py", line 97, in parse
    for lineno, line in enumerate(fp, 1):
  File "<frozen codecs>", line 322, in decode
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfd in position 2170: invalid start byte

We are not sure how often the error occurs and were not able to reproduce it. It is likely caused by a misconfigured system locale on Linux.
A similar issue was reported and fixed for vdf.binary_loads in https://github.com/ValvePython/vdf/issues/20.
The fix we implemented looks like this (see ProtonUp-Qt PR #455). Invalid UTF-8 characters are simply replaced by "�".
with open("config.vdf", "r", encoding="utf-8", errors="replace") as f:
    x = vdf.loads(f.read())

# Something like this would probably also work - untested:
vdf.load( open("config.vdf", "r", encoding="utf-8", errors="replace") )

I don't think this is something that can be fixed from your side as vdf.load only accepts the file object and the Unicode-decoding and error handling is part of open() which is called by the user. I just thought it might be interesting to share in case others also have a similar issue (this could go into "GitHub Discussions").

Yeah, nothing we can do about it. Has to be handled by the open() call or whatever is used to create the file object


--tfflags does not work with multiple -var-file options

Thanks to bruceedge on Reddit for reporting this.

The only gotcha was that the "--tfflags" arg doesn't understand repeated uses of "-var-file...", so one has to append all var-files into one big one and pass that in.

I've been unable to reproduce this with infracost v0.7.11 and terraform v0.14.2 using the command:
infracost  --tfflags='-var-file=x.tfvars -var-file=y.tfvars'

Variables from both files are used as expected.

I've been unable to reproduce this with infracost v0.7.11 and terraform v0.14.2 using the command:
infracost  --tfflags='-var-file=x.tfvars -var-file=y.tfvars'

Variables from both files are used as expected.

Should this be closed? it can be re-opened when we have more details or reproduction steps.

Should this be closed? it can be re-opened when we have more details or reproduction steps.


popovers: Disable "Confirm" button in Move topic menu when origin and destination are the same.

Disables the submit button in the move_topics popover, instead of relying on an error box, when the user hasn't selected a new topic.
Fixes #21711)

Commit f49667c implements the functionality in a minimal but incomplete way.
Commit 7613f5f also checks the names, with some small refactoring, and removes the prior error check.
This is my first-ever contribution. I went down the template checklist and hopefully didn't miss too much. Any feedback or concerns about style or approach are greatly appreciated. :-) If a test should have been included, apologies in advance, and I'll add one right away!

Showing the fix for topic changes, including the expected behavior for trailing spaces.

Looks good to me!

I played around with the PR -- looks good to me!

We can consider adding a tooltip, but I don't think it's necessary... What do you guys think?

I don't feel a need for a tooltip either.  Merged, after adding a code comment explaining that the case-sensitive comparison is intentional. Thanks for fixing this @salmonax!
A good follow-up project might be to do this same "disabled button if not changes" adjustment to the in-message feed "message edit" component.

Acknowledged. And thanks for the suggestions, @timabbott!


Add support of Vite 5

Warnings on dev mode:
plugin 'vite-plugin-svg-spritemap:dev' uses deprecated 'enforce' option. Use 'order' option instead.
plugin 'vite-plugin-svg-spritemap:dev' uses deprecated 'transform' option. Use 'handler' option instead.

Thanks for the report. This is just deprecation warning and an easy fix to implement. This fix will be implemented in the 2.0.0 and so, the plugin will drop the support of Vite 3.
Related to #24


⚠ Bofrost.de has degraded performance

In 941f5ab, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1502 ms

Resolved: Bofrost.de performance has improved in e5151f7.


TLS vs SSL

As your document says that you use TLS for encrypted transmissions. Even more specifically1.2 then you should drop the SSL letters.  That applies to 3.0 and before.  Kinda like Star Wars they do not come in numerical order ;)

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cffc5753-1125-f6ee-de76-8ea460144c10
Version Independent ID: af3b7535-e78b-abb6-4a54-cdc55b6641bf
Content: Security and data privacy - Azure Cognitive Search
Content Source: articles/search/search-security-overview.md
Service: cognitive-search
GitHub Login: @HeidiSteen
Microsoft Alias: heidist

@gwenbettwy Thank you for continuing to identify and point out the SSL vs TLS discrepancies within the documentation. I will have the AI + ML service area review this specific issue and have the documentation updated as appropriate.

@Mike-Ubezzi-MSFT @gwenbettwy  Doc change is merged into master and will appear on the live site Monday morning 10:00 PST.  Thank you @gwenbettwy !!  Your explanation made me laugh :)

Again thanks so much for being responsive ;)
Glad to add a giggle to your day Heidi

On Apr 25, 2020, at 1:37 PM, Heidi Steen<EMAIL_ADDRESS>wrote:
@Mike-Ubezzi-MSFT https://github.com/Mike-Ubezzi-MSFT @gwenbettwy https://github.com/gwenbettwy Doc change is merged into master and will appear on the live site Monday morning 10:00 PST. Thank you @gwenbettwy https://github.com/gwenbettwy !!
Reply to this email directly, view it on GitHub https://github.com/MicrosoftDocs/azure-docs/issues/53316#issuecomment-619415009, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJSIZS77UWJ7OZKPUZ3BWT3ROMNXPANCNFSM4MQ2C3OQ.

Since the doc has been updated, I am going to close this issue.
#please-close


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
a47175533bb303efb465029bbb8ec5e6d1c14a65
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
a47175533bb303efb465029bbb8ec5e6d1c14a65
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
a47175533bb303efb465029bbb8ec5e6d1c14a65
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Bug report: JWT Verify doesn't require an algorithm

As detailed here, JWT verification functions should require specifying the algorithm that should have been used, in order to prevent an attacker from changing the algorithm to a symmetric algorithm from an asymmetric one and using the public key to sign the token. Probably low priority for this particular app, but it would be good to at least have the option.

Hi Josh,
Correct me if i am wrong or misunderstand you, but isn't the problem you link to, a serverside issue where developers simply trust whatever alg the token specifies? Removing "none" from Cyberchef won't help the problem. Servers need to interpret the tokens with the alg it writes the tokens with.
Having the "none" alg there is a great tool for testing your implementation of JWT verification, to catch the problems mentioned in the link.

I don't mean removing the none algorithm, I meaning allowing the user to specify which algorithm is expected and raise an error if the jwt defines it differently. The relevant part of the article is this: https://auth0.com/blog/critical-vulnerabilities-in-json-web-token-libraries/#RSA-or-HMAC-. Specifically "If a server is expecting a token signed with RSA, but actually receives a token signed with HMAC, it will think the public key is actually an HMAC secret key." Basically, the solution is, rather than trusting the jwt alg field, allowing the user to define the algorithm. Hope that makes more sense.

Yeah, that would be good especially since the JWT header isn't shown at all. I recommend using https://jwt.io/ for playing with JWT tokens.


Ansible docs sprawl

The Ansible documentation is getting really long.
This thread on lines is in part about a perceived issue that came down to

a change in default behaviour after a firmware update
...that they couldn't find an explanation of how to alter in the documentation
...despite it actually being documented.

Ansible now has... five apps, MIDI support, Teletype docs, USB disk mode docs, and further notes. This is a lot for one page, and the monome site's design means that headers aren't super-varied in their styling (despite header levels being well-used in the docs).
I propose that we break up Ansible into an 'index' page (with brief descriptions of the apps, and some global notes) as well as individual documentation pages for apps. This is also a good opportunity to review the docs properly, for inaccuracies, duplication, and also for consistency in terminology.
I'm happy to take the lead on this, but want to raise it with the community.

@infovore , I just mentioned this to @tehn yesterday -- there was a Kria support request that made clear the need for some optimization. excellent timing and thank you for opening the issue!
I love the idea to split the apps into separate doc pages, which is also in line with a plan to create short video demonstrations of parameters/functions within each app.
happy to share the work if you're able, but can also totally take this on. I've already self-assigned, let me know!

I think I'd like to take a pass at this - I enjoyed working on the Ansible docs last time, and I wrote a pile of the docs for Ansible-Earthsea too. It's likely it's going to be a bit of a running branch whilst we fettle it - I don't think it's just a case of cutting it into six!
One question, which @tehn might be able to answer: is there an easy way of previewing how the docs will look in the monome site itself?
(one note: I am on vacation the next two weeks, but I might still do some prodding. but it becomes easier to work on this in October).

(might be worth kicking off a 'project' - there are some things where I'd like review etc of)

sounds great! happy to do whatever's needed, just let me know :)
https://github.com/monome/docs/projects/1

Annoyingly, it looks like I can't add tickets to a project - I wasn't quite sure how that worked on repos I'm not a collaborator on. No worries, there's not a burning issue just yet. Although I've kicked off my own branch for now and my own project, and I'll manage it there and maybe just submit PRs. We'll see.

@infovore added you as a collaborator!


Add support for moving focus between panes with the keyboard

Summary of the Pull Request
Enables the user to set keybindings to move focus between panes with the keyboard.

References
See #1000 for panes megathread

PR Checklist

[x] Closes #955

Detailed Description of the Pull Request / Additional comments
This is highly based off the work done for resizing panes. Same logic applies - moving focus will move up the panes tree until we find a pane to move the focus to.

Are these panes being implemented as XAML controls, or something more Win32 based?


Form and inputs

What are the plans for forms? It seems like a crucial component for any app.

@montanaflynn forms work on HTML as normal. You just have to implement the handler in go on the HTTP server to deal with the data.
It would work like any other web application.

I think the documentation / examples could definitely showcase that better. I don't think there is an example with HTML inside currently.

@montanaflynn those examples will depend on PR #20 :)


hubble: Support --cel-expression filter in hubble observe

I originally opened this PR to the hubble repo https://github.com/cilium/hubble/pull/1465 but now Hubble CLI is part of the cilium repo so I've reopened the PR here.
Implements the CLI side of https://github.com/cilium/cilium/pull/31070

Not really sure of the right release note label since we already have https://github.com/cilium/cilium/pull/31070 as a release note and this being separate is an artifact of the Hubble CLI repo being merged with cilium.

/test

@kaworu good catch, tests added.

/test


feat(app, app-shell, api-client): include analysis as cli tool within app for protocol ingestion

Overview
Expose the protocol analysis engine functionality from the opentrons python module. Add machinery to
allow this cli to be called from within the running Opentrons App via a configurable path to a
python interpretter. Wire up the protocol file analysis to the existing protocol file system storage
machinery. Wire up analysis data to protocols landing and details page scaffolding.
Feel free to take a look at the code and test things out.  For efficiency's sake I will be adding unit test coverage for the following features while this PR is up and reviewable.

[x] TODO: tests for new api-client/src/protocols/utils accessors
[x] TODO: test for DeckThumbnail
[x] TODO: test for ChooseRobotSlideout
[x] TODO: test for ProtocolDetails organism
[x] TODO: test for protocol-storage redux
[x] TODO: test for config migration

Changelog

include app-shell machinery to execute python
include new config for specifying an alternative path at which to find a python interpreter (dev defaults the the virtualenv of the monorepo's api dir)
initiate local protocol analysis within app-shell protocol storage when protocol files are uploaded
build out analysis on protocols landing and detail pages. use shared protocol analysis file parsing utils exported from api-client

Review requests

Upload a protocol to the app, you should see it appear with parsed data after FE analysis succeeds.
Navigate to that protocol's detail page.
Open the "Choose a Robot" slide-out from the "Run this protocol" CTA's in the overflow menu of the ProtocolCard on the landing page, as well as the Primary Button on the Protocol Detail page.

Risk assessment
high, this wires up a lot of verticality across our stack.

https://github.com/Opentrons/opentrons/runs/5837426226?check_suite_focus=true#step:8:140

Yeah this is a failure in CI only now. It won't pass until the follow up work to bundle standalone python into the electron build is completed.  I'll find a way to swallow this error for now.


ENOENT error when packaging something that uses Ionic

Type of Issue
[X] Bug Report
[ ] Feature Request

Description
Whenever I try to include something that uses anything from ionic-angular in my package, the building proccess breaks.
No matter what specific components/service/module I'm using, 99% of the time the file mentioned in the error is something in the utils folder,.
Building Angular library
Generating bundle for ion-with-packagr
Cleaning bundle build directory
Processing assets
Running ngc
Compiling to FESM15

BUILD ERROR
ENOENT: no such file or directory, open 'C:\...\...\...\...\ion-with-packagr\node_modules\ionic-angular\components\app\app-constants.ts'
Error: ENOENT: no such file or directory, open 'C:\...\...\....\...\ion-with-packagr\node_modules\ionic-angular\components\app\app-constants.ts'

I've read #129 and found a few issues related to this, which all can be solved by including the faulty package's UMD module ID in "externals" - I tried to use "ionicBundle" (shown below) for "ionic-angular", but no effect.
The new RCs seem to change something related to this, but I can't install them. (npm ERR! enoent ENOENT: no such file or directory, chmod 'C:............\ion-with-packagr\node_modules\ng-packagr\cli\main.js')
I've noticed Ionic seems to handle module IDs in a different way than other packages. I don't know if it could be related to this issue.
/ionic-angular/bundles/ionic.umd.js
(function (global, factory) {
   typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
   typeof define === 'function' && define.amd ? define(['exports'], factory) :
   (factory((global.ionicBundle = global.ionicBundle || {})));
}(this, (function (exports) { 'use strict';

/ionic-angular/umd/index.js
(function (factory) {
    if (typeof module === "object" && typeof module.exports === "object") {
        var v = factory(require, exports);
        if (v !== undefined) module.exports = v;
    }
    else if (typeof define === "function" && define.amd) {
        define(["require", "exports", "..._< bunch of stuff >_..."], factory);
    }
})(function (require, exports) {

How To Reproduce

Start a new Angular project
Install ionic-angular with --save (or just use the ionic start command as the first step)
Install ng-packagr with --save-dev
Set up a packaging environment and have a file be exported in public_api.ts
In that file, import something from "ionic-angular" (the IonicModule or any component) and use it in the file itself
Run ng-packagr -p -package.json

Expected Behaviour
Package ionic-angular properly and have it as a dependency.
Version Information
  "dependencies": {
    "@angular/common": "5.0.3",
    "@angular/compiler": "5.0.3",
    "@angular/compiler-cli": "5.0.3",
    "@angular/core": "5.0.3",
    "@angular/forms": "5.0.3",
    "@angular/http": "5.0.3",
    "@angular/platform-browser": "5.0.3",
    "@angular/platform-browser-dynamic": "5.0.3",
    "@ionic-native/core": "4.4.0",
    "@ionic-native/splash-screen": "4.4.0",
    "@ionic-native/status-bar": "4.4.0",
    "@ionic/storage": "2.1.3",
    "ionic-angular": "3.9.2",
    "ionicons": "3.0.0",
    "rxjs": "5.5.2",
    "sw-toolbox": "3.6.0",
    "zone.js": "0.8.18"
  },
  "peerDependencies": {
    "ionic-angular": "3.9.2",
    "@ionic-native/core": "4.4.0",
    "@ionic-native/splash-screen": "4.4.0",
    "@ionic-native/status-bar": "4.4.0",
    "@ionic/storage": "2.1.3",
    "ionicons": "3.0.0"
  },
  "devDependencies": {
    "@ionic/app-scripts": "3.1.6",
    "ng-packagr": "^1.6.0",
    "typescript": "2.4.2"
  }

@ludvon I met the same problem. Have you solved it?

@chenyuanchn Nope. Still getting the same error so far.

@dherges Adding the ionicBundle to umdModuleIds does not work. Are there any other details to the workaround that we are missing in this thread?
...
scripts: {
  "packagr":"ng-packagr -p ng-package.json",
  // rest of scripts
},
"ngPackage": {
  "lib": {
    "entryFIle": "public_api.ts",
    "umdModuleIds": {
      "ionic-angular": "ionicBundle"
    }
  }
}
... rest of package.json

What exactly is then non-working? Can you put up a repro?

From the initial post:
Compiling to FESM15
<some-path>\
ion-with-packagr\node_modules\ionic-angular\components\app\app-constants.ts

I wouldn't know why rollup tries to resolve a module from *.ts file in node_modules. It could be that re-mapping the source maps fails. I'd need a repro to tell more.

Interestingly, Ionic stuff seems to be working perfectly with the new 2.0.0 release.

Sorry @dherges, I'll send you repro soon.
@ludvon that's interesting! I'll upgrade and try again!!

@olivercodes any update?

Update - the latest version of ng-packagr I was able to bundle an Ionic application and then reuse it (YAY!). However, it only works if that application does not use lazy loading for any of it's components. It seems that when you use ng-packagr on a component/page that brings in any lazy loaded components, it then breaks.

The @Inlustra solution works for me, but I've replaced the lib.umdModuleIds key by lib.externals, like @dherges said. I'm using ng-packagr: 1.7.0 for Angular 4.x (AOT builds) and Ionic 3.2.
Moreover, I'm using sub-package directory structure described in tell-me-now-how-do-i-use-secondary-entry-points-aka-sub-packages, that generates a mypackage.d.ts referenced like typings into package.json file. That use typescript exposts like this:
export { MyComponentOrService as 0a } from 'my-package/subpackage';

Because of this, I just remove  the as 0a and into my ionic app, import directly from my-package. Sadly, I have that create a script to remove this, or I need remember remove them every ng-package build :cry:
For sass, the 1.7.0 don't have any schema key to map your .sass/.css files. I've to create a script to copy all my extra .sass (that not add to my component using styleUrls of @Component decorator) to src dist compiled package.
Like suggested by @dherges on issue #344 , I've created a branch [angular-4] that use the ng-packagr 1.7.0 version, and the branch [master] point to ng-packagr: 2.4.2, Angular 5.x and Ionic 3.9.x.
This is a "hard" solution, but it works :sweat_smile:

Hi @mfdeveloper - Can you detail your solution getting it work with Angular 5.x and Ionic 3.9.x?
I run into build issues like this when running the ng-packagr script:
BUILD ERROR
node_modules/ionic-angular/components/picker/picker-component.d.ts.PickerCmp.html(13,71): : Expected 0 arguments, but got 1.
node_modules/ionic-angular/components/input/input.d.ts.TextInput.html(1,928): : Expected 0 arguments, but got 1.
node_modules/ionic-angular/components/input/input.d.ts.TextInput.html(1,961): : Expected 0 arguments, but got 1.

Error: node_modules/ionic-angular/components/picker/picker-component.d.ts.PickerCmp.html(13,71): : Expected 0 arguments, but got 1.
node_modules/ionic-angular/components/input/input.d.ts.TextInput.html(1,928): : Expected 0 arguments, but got 1.
node_modules/ionic-angular/components/input/input.d.ts.TextInput.html(1,961): : Expected 0 arguments, but got 1.

In the case of ionic 4, check your code using ionic-angular then replace with @ionic/angular

I think that this issue can be closed because:

It's a stale issue referring to the now deprecated ionic-angular package; which has been replaced by @ionic/angular (whith ionic.angular for the UMD  module ID).
The upcoming version of APF will drop UMD modules, so this will no longer be an issue.


F* should return a non-zero error code when given invalid command-line options

If I run F* with an invalid option, it returns a success (0) return code:
$ fstar.exe --blah T.fst
unrecognized option '--blah'
$ echo $?
0

This means that build systems that rely on the return code to detect verification failures will think that verification succeeded, whereas we should be treating this as a failure.

Can you say a bit about your setup? It seems to fail as appropriate on a recent F* in my machine:
$ ./bin/fstar.exe --blah ; echo $?
unrecognized option '--blah'
1
$ ./bin/fstar.exe --blah A.fst ; echo $?
unrecognized option '--blah'
1

The relevant logic is in go inside FStar.Main.fs, and seems fine except for the fact that it doesn't fail when no files are provided (fstar.exe --debug A should fail, but it doesn't), which I can fix.

Sorry, I should have specified:
$ fstar.exe --version
F* <IP_ADDRESS>
platform=Darwin_x86_64
compiler=OCaml 4.04.0
date=2018-05-23T16:26:43-07:00
commit=5b3b9a84e

This is on Mac OS X.  In my case T.fst does exist:
$ cat T.fst
module T

let test (x:int)
  =
  assert ( x > 0 )
$ fstar.exe --blah T.fst && echo $?
unrecognized option '--blah'
0

Looks like I was using an out-of-date master.  With the latest version, this issue is gone.  Sorry for the confusion.


Support: how does one import expenses from a Spliit JSON file?

I had Spliit run on my own instance and there are now too many expenses to port over to the public instance by hand so I exported them via the "export" button. I thought there'd be some obvious option to import expenses from said JSON file but there appears to be none.
Is this feature available (I'd assume so given that this would be easier than importing from Splitwise)? If so, where can I find it?

Hi - There is no import feature yet

Should I open a feature request?


Update eth_getTransactionCount to return contract nonce

Description:
Still need to add acceptance tests
Related issue(s):
Fixes #
Notes for reviewer:

Checklist

[ ] Documented (Code comments, README, etc.)
[ ] Tested (unit, integration, etc.)

Codecov Report
Patch coverage has no change and project coverage change: -0.85 :warning:

Comparison is base (02a0b03) 78.92% compared to head (e150ccf) 78.08%.

:exclamation: Current head e150ccf differs from pull request most recent head 34772f5. Consider uploading reports for the commit 34772f5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1535      +/-   ##
==========================================
- Coverage   78.92%   78.08%   -0.85%
==========================================
  Files          19       32      +13
  Lines        2036     2573     +537
  Branches      435      533      +98
==========================================
+ Hits         1607     2009     +402
- Misses        299      400     +101
- Partials      130      164      +34

Impacted Files
Coverage Δ

packages/relay/src/lib/eth.ts
85.51% <ø> (+0.29%)
:arrow_up:

... and 15 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


gulp-jscs requires reporter and .jscsrc validateJSDoc now jsDoc

When running the first task, gulp vet, no output was generated from jscs.
It appears that gulp-jscs now needs a reporter like jshint:
gulp.task('vet', function() {
    console.log('vetting');
    return gulp
        .src([
            './src/**/*.js',
            './*.js'
        ])
        .pipe(jscs())
        .pipe(jscs.reporter())
        .pipe(jshint())
        .pipe(jshint.reporter('jshint-stylish', {verbose: true}));
});

Thanks to EdinM for that one.
Having fixed that, multiple errors are produced: Unsupported rule: validateJSDoc
This comes from line 56 in .jscsrc and can be fixed by changing the key to jsDoc.
Thanks Sven Schoenung

Sorry, looks like there are a couple of pull requests already dealing with this.


fix: LSDV-3025-12: Fully hide the dropdown component when closing it

PR fulfills these requirements

[x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[x] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[x] Frontend

Describe the reason for change
The dropdown component is not hidden enterally, there is a small timeout that is making the transition method is being triggered before afterTransition. And it is making the dropdown is being clickable even after it's hidden.
Does this change affect performance?
no
Does this change affect security?
no
What alternative approaches were there?
na
What feature flags were used to cover this change?
na
Does this PR introduce a breaking change?
(check only one)

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[x] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[x] unit

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.04 :tada:

Comparison is base (f44a935) 64.82% compared to head (14ec33b) 64.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1344      +/-   ##
==========================================
+ Coverage   64.82%   64.87%   +0.04%
==========================================
  Files         436      436
  Lines       27109    27111       +2
  Branches     7139     7137       -2
==========================================
+ Hits        17574    17587      +13
+ Misses       8202     8195       -7
+ Partials     1333     1329       -4

Impacted Files
Coverage Δ

src/common/Dropdown/DropdownTrigger.tsx
95.52% <ø> (ø)

src/common/Dropdown/DropdownComponent.tsx
93.20% <100.00%> (+3.00%)
:arrow_up:

src/components/Filter/Filter.tsx
97.14% <100.00%> (+0.08%)
:arrow_up:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

/git merge master


beast: misc-typos

Found via codespell -q 3 -L uint,te,tim --skip="./test/extern/zlib*,./example/http/client/crawl*"

Good finds! One little detail though, the files http_parser.c and http_parser.h should be left alone since they are external code and it is important that the source files are exactly the same as they are in the foreign repository, even with the spelling errors.

@vinniefalco oops...tried to avoid changing any 3rd party code. Reverted in 1e96ee0


BUG: CREATE TABLE AS SELECT * FROM my_file.parquet not working on Cloud

Description
I'm hitting an unexpected issue with the following query:
CREATE TABLE IF NOT EXISTS abc AS select * from read_parquet('https://github.com/GlareDB/tutorial_data/raw/main/nyc_sales/SALE_YEAR_2020/SALE_MONTH_1/b04c8a5e117a48bd96b2b3924ba6993d-0.parquet');

The above looks like it works fine, but I hit an error when trying to select from the table:
SELECT * FROM abc;

I've tried this with a non-Cloud GlareDB instance and it works fine. I've tried this with Cloud and a CSV file and it works fine.
I've tried this with Cloud in the Cloud workspace and also a Cloud connection in a Python notebook, and both of those cases fail. I've also tried this with a Parquet file that's local to my machine and it fails on Cloud also.
I'm reasonably certain I was able to create a table from these Parquet files successfully in Cloud a couple of weeks ago, so this may be a regression.

Resolved by the latest Cloud release


add versioning, help for makefile, little improvements

Codecov Report

Merging #36 (db0a494) into main (b9ba8d9) will decrease coverage by 3.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   85.10%   81.91%   -3.20%
==========================================
  Files           3        3
  Lines          94       94
==========================================
- Hits           80       77       -3
- Misses         10       12       +2
- Partials        4        5       +1

Impacted Files
Coverage Δ

internal/app/http/server.go
72.54% <0.00%> (-5.89%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Program request

Maybe adding ExplorerPatcher could be a good idea, it has good
amount of customization on windows 11

Added to #374


SSG works perfectly, can it also work for SSR?

Great work!
I really love it, it really was plug and play for my personal portfolio.
But i'm not sure, i don't think that this astro-critters works when you astro is in SSR mode.

There is a middleware issue on AstroCompress which is basically the same feature https://github.com/astro-community/AstroCompress/issues/131


Remove .idea directory and add to .gitignore

The directory uses customized local settings and should not be added to the Git repository. This PR removes the files added in #47 and adds it to the .gitignore file.

Looks great Michael! Going ahead and getting it merged thank you for your work this closes #48

Thank you, Michael! Forgot to deal with the .idea folder, sorry 😇 Also you should be looking for a more skilled maintainer that can help you verify the PRs (not me, I still have a lot to learn)!

@khanhtranngoccva Thanks for the suggestion, and no worries. Together we can ensure to correct things when we see them.
Everyone needs to start learning somewhere, and mistakes are a great way to learn and grow. Skilled maintainers are those who grow by collaboration, and iteration. cc @laurelayounis


[5.0][runtime] Add tests of pre-stable ABI objects with the stable ABI runtime

Someday old Swift apps using the pre-stable ABI may pass their objects to OS code implemented using the stable Swift ABI and runtime. This test verifies that the new Swift runtime handles such objects correctly.
This test does nothing until we enable the intended is-Swift bit in the stable ABI. At that point this test will run by creating ObjC classes and objects with bits set to mimic the pre-stable ABI.

Cherry-picked from #21403.

@swift-ci please smoke test

@apple/swift5-branch-managers This is a test-only change for Swift stable ABI. It won't actually test anything until a later flag change so it is not high priority yet.

@swift-ci please test


RepositoryNotFoundException

E:\workspace\terasology1\Terasology>groovyw module init iota
org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
E:\workspace\terasology1\Terasology\config\groovy\common.groovy: 12: unable to resolve class org.eclipse.jgit.errors.RepositoryNotFoundException
@ line 12, column 1.
import org.eclipse.jgit.errors.RepositoryNotFoundException
^
1 error
How can I solve this problem?

I do not believe I have seen this particular error before. Have you made sure that you are using Java 17?
It could be that the dependency failed to download. Can you access https://ajoberstar.github.io/bintray-backup/org/ajoberstar/grgit/1.9.3/grgit-1.9.3.pom successfully?

my java version
C:\Users\ZHL>java --version
java 17.0.10 2024-01-16 LTS
Java(TM) SE Runtime Environment (build 17.0.10+11-LTS-240)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.10+11-LTS-240, mixed mode, sharing)

and I can access the website you said and download it , I also tried java11, but it didn't work

you did something like:
git clone --filter=blob:none git@github.com:MovingBlocks/Terasology.git
cd terasology
git checkout develop
groovyw module init iota

is it?

I clone the develop branch directly. It's default, isn't it? I use develop branch

Can I manually init or clone these modules such as https://github.com/Terasology/CoreWorlds ？

I manually clone these modules but can't build them because they don't have the build.gradle.kts file. How do I fix this？


Attack/move points (phases)

Mostly done in pair with https://github.com/ozkriff/zemeroth/issues/23 . Cleaning up the code.


Request to display information in consolidated table

Hello HighVolt-Dev,
Thank for the amazing software. May I request you to consolidate the information in a simple table.

Thanks for the suggestion, @CapabaleSpecimen - I will keep this in mind when I have the chance to work on it


Clicking Diagnostics option kills

×
TypeError: Cannot read property 'indexOf' of null
ProxyComponent.componentDidMount
src/components/diagnostic/GeneratePackage/GeneratePackage.js:116
  113 | }
  114 |
  115 | componentDidMount() {
> 116 |     if (window.halinContext.getCurrentUser().roles.indexOf('admin') === -1) {
      | ^  117 |         return this.setState({ userIsAdmin: false });
  118 |     }
  119 |
View compiled
▶ 4 stack frames were collapsed.
HTMLUnknownElement.sentryWrapped
src/helpers.ts:85
  82 |   // NOTE: If you are a Sentry user, and you are seeing this stack frame, it
  83 |   //       means the sentry.javascript SDK caught an error invoking your application code. This
  84 |   //       is expected behavior and NOT indicative of a bug with sentry.javascript.
> 85 |   return fn.apply(this, wrappedArguments);
     | ^  86 |   // tslint:enable:no-unsafe-any
  87 | } catch (ex) {
  88 |   ignoreNextOnError();
View compiled
▶ 16 stack frames were collapsed.
(anonymous function)
src/components/higherOrderComponents.js:62
  59 | componentDidMount() {
  60 |     return compatibilityCheckFn(window.halinContext)
  61 |         .then(result => {
> 62 |             this.setState({ compatible: result, pending: false });
     | ^  63 |         })
  64 |         .catch(err => {
  65 |             sentry.reportError('Compatibility function failure', err);
View compiled
This screen is visible only in development. It will not appear if the app crashes in production.
Open your browser’s developer console to further inspect this error.  Click the 'X' or hit ESC to dismiss this message.

Install Enterprise and now it doesn't die


Could not link ...homebrew/share/doc/homebrew error on install

Please always follow these steps:

[x] Confirmed this is a problem with running a brew command and not brew installing or the post-install behaviour of one or more formulae? If it's a formulae-specific problem please file this issue at the relevant tap e.g. for Homebrew/homebrew-core https://github.com/Homebrew/homebrew-core/issues/new

When doing a manual homebrew install, I get a strange error. From /tmp:
$ mkdir hbtmp
$ cd hbtmp/
$ mkdir homebrew && curl -L https://github.com/Homebrew/homebrew/tarball/master | tar xz --strip 1 -C homebrew
$ ./homebrew/bin/brew update
Initialized empty Git repository in /private/tmp/hbtmp/homebrew/.git/
remote: Counting objects: 1119, done.
remote: Compressing objects: 100% (1029/1029), done.
remote: Total 1119 (delta 116), reused 379 (delta 50), pack-reused 0
Receiving objects: 100% (1119/1119), 1.20 MiB | 5.45 MiB/s, done.
Resolving deltas: 100% (116/116), done.
From https://github.com/Homebrew/brew
 * [new branch]      master     -> origin/master
HEAD is now at 8187776 Merge pull request #3112 from mistydemeo/search_online_failure
To restore the stashed changes to /private/tmp/hbtmp/homebrew run:
  'cd /private/tmp/hbtmp/homebrew && git stash pop'
==> Homebrew has enabled anonymous aggregate user behaviour analytics.
Read the analytics documentation (and how to opt-out) here:
  https://docs.brew.sh/Analytics.html

==> Tapping homebrew/core
Cloning into '/private/tmp/hbtmp/homebrew/Library/Taps/homebrew/homebrew-core'...
remote: Counting objects: 4556, done.
remote: Compressing objects: 100% (4345/4345), done.
remote: Total 4556 (delta 36), reused 457 (delta 12), pack-reused 0
Receiving objects: 100% (4556/4556), 3.64 MiB | 6.44 MiB/s, done.
Resolving deltas: 100% (36/36), done.
Tapped 4342 formulae (4,601 files, 11.4MB)
Already up-to-date.
Error: Could not link:
/private/tmp/hbtmp/homebrew/share/doc/homebrew

Please delete these paths and run `brew update`.

If I do rm -rf /path/to/homebrew/share/doc/homebrew before doing the update, I don't get the error.
Perhaps the tarball shouldn't include that directory at all?

We don't support installing in non-default prefixes so I'm afraid you'll need to figure out the solution for this yourself as it's not a widespread issue. We'll accept PRs for fixes, though, if you figure that out.

Ah, I see. Interestingly enough, it doesn't happen if I untar to the default prefix. Will investigate more and open a PR...

This turned out to be a boneheaded mistake on my part. I had curl -L https://github.com/Homebrew/homebrew ... from my notes, which was before the brew/homebrew-core split, which should now be curl -L https://github.com/Homebrew/brew .... No PR needed!


Issue when using nginx secure link

When passing a url for an m3u8 playlist with secure link parameters (https://url.net/whatever/index.m3u8?st=HASH&e=TIMESTAMP), Player seems to be unable to start the stream. The stream works from AVPlayer/AVPlayerLayer just fine, and is accessible from a browser, quicktime, VLC, etc... I have tested this by replacing the URL in the test project with a verified functional link, and it just produces a blank screen. When using the original video from the project, it plays just fine.

I have found that for some reason, other HLS streams are (NON secure link) are having this issue too. It appears that the HLS playlist loads correctly, but nothing ever plays. I tried again with the swift 3 branch, and followed the output of my web server's access log, and I can see that Player is requesting and retrieving the ts chunks, but they are not being displayed.

hey @thetravischannel thanks for the note. i don't know what could be causing the issue, but i believe it might be a known problem with AVPlayer.
📎 http://stackoverflow.com/questions/34026175/ios-avplayer-not-loading-most-hls-streams
📎 http://www.openradar.me/16764535


docs(README): Make capabilities for all available lsp servers & remove "other_fields"

Excuse my for force pushes, messed up current formatting with my formatter, fixed some typos

Thanks!


Document how to add a beanstalk queue

Resolves #1313

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for this! It looks like it was pretty straightforward.


No syntax highlighting support for GHCi

I see that font-lock-mode is enabled and yet there is no syntax highlighting for GHCi ? Am I doing something wrong or is this how it's supposed to be ?

It shouldn't be highlighting haskell code. This isn't supported at the moment.


Do not fail if memory-pressure toleration is present and qosClass is different than BestEffort

build-depends: 25728
Context
In this change, it was discussed that there is a toleration that seems to be added by k8s and is not being treated by the access-control-pod-toleration-bypass, so that it is not considered as a modified toleration.
The reason why this memory-issue toleration is appearing is because QoS class applied to the pods under test. If resource limits (for CPU and RAM) are defined, according to this k8s docs, it is said that "The control plane also adds the node.kubernetes.io/memory-pressure toleration on pods that have a QoS class other than BestEffort".
So, if the QoS class applied to the pod is different than BestEffort, this toleration should not be considered as modified and the access-control test must pass in that case.
Changes included

Include QoSClass as a parameter to be interpreted by toleration check
Also consider that a toleration is not modified if we have NoSchedule - memory-pressure toleration with QoS class different than BestEffort, following k8s docs
New unit tests

SUCCESS https://www.distributed-ci.io/jobs/32157cb6-a08e-4661-b114-db7afd5def5b/jobStates
from Do not fail if memory-pressure toleration is present and qosClass is different than BestEffort #417

This change makes our job to work again :) because, for our tnf testing pipeline, we were making the job to fail if any tnf unit test was failing, and the only one that was still failing was access-control-pod-toleration-bypass. In this last DCI job, we can see it is passing thanks to this change.
I'd say this is ready for review, CC @sebrandon1 @greyerof

Unable to find -e pipeline

Do not pay much attention to this and further messages, because I'll create some other too, I am testing some automations in our labs to be able to catch PRs from this repo, so that we can test them in our labs to verify if they are fine or not. But it's not affecting the change, the change is, in fact, ready for merging.

@sebrandon1 @greyerof If someone of you can merge it, it would be great, because I don't have permissions to do that, I'll ask in your gchat if I can have them too for the future, as I intend to collaborate if finding bugs and issues while testing on DCI. Thanks for your review by the way!


Typescript support?

Perhaps I'm missing something obvious here, but I can't see anywhere in the docs where we can add the type declaration to the NextApiRequest type to be able to do req.log.

Did some digging into the source, and I've deduced my own type to get by for now. This definitely feels like something that should come out of box though.
interface AxiomNextApiRequest extends NextApiRequest {
  log: AxiomLogger;
}

interface AxiomLogger {
  info: (message: string, args?: any) => void;
  debug: (message: string, args?: any) => void;
  error: (message: string, args?: any) => void;
  log: (message: string, args?: any) => void;
}

Oh, I found AxiomAPIRequest. Probably a good idea to add this to the docs. I'll leave this open to remind myself to submit a PR.

Hey @mclean25, very good point, we should probably have typescript docs too 👍

Closing, we changed our docs in the README.md to TypeScript 🙌


Reward certain substructure matching

Dear Reinvent4 developer,
Thanks for developing such an amazing tool!
I did a quick look at the code as well as the manuscript and am wondering whether it is possible to reward the generation of certain substructures. It seems to me that both CustomAlerts and MatchingSubstructure will penalize the matching of substructures.
Thanks

Hi,
many thanks for your interest in REINVENT and welcome to the community!
Yes, those components would be suitable for that as both take SMARTS.  Just be aware that they work differently.  CustomAlerts is a filter and MatchingSubstructure a penalty which technically runs last and multiplies the total score with 0.5 if the pattern does not match.
Many thanks,
Hannes.

Thanks Hannes for the clarification!
Am I understand it correctly:
For CustomAlerts, a design matches any of the substructure SMARTS pattern, it will be excluded immediately for any subsequence scoring.
For MatchingSubstructure, depends on how the transform is setup, it can be either a penalty or reward. For example, the following toml setup will penalize the matching of "CO" by zeroing the score if any CO is found in the design:
[[scoring.component]]
[scoring.component.MatchingSubstructure]
[[scoring.component.MatchingSubstructure.endpoint]]
name = "Matching SMARTs substructure"
weight = 1
params.smarts = "CO"

transform.type = "reverse_sigmoid"
transform.high = 3
transform.low = 1
transform.k = 0.5

while removing the transform section will turn it to a reward.

Hi again,
Yes, CustomAlerts is a filter and that is how a filter is supposed to work i.e. avoid unnecessary calculation if you already know that the total score will be zero.
You can transform any component, so also MatchingSubstructure, but a sigmoid may not be that ideal as you would have to find out how the two only values, 1.0 and 0.5, would best reverse map.  We will update the value mapping transform to handle this better.
Cheers,
Hannes.

Thanks for the detailed explanation!

Thanks for the detailed explanation!

I just realize that you should also be able to use the left step transform with a lower value, say 0.5, to invert a binary input.


Any recommended workaround for embedding resources in Create/Update requests

Hi,
I've read up a lot of information about how 'embedded' / 'nested' resources are scheduled for v1.1 of the json-api but I was just wondering if anyone using jsonapi-resources has an interim solution, for de-serializing create/update requests where I can create / update a set of related entities. In the case of the create they wouldn't have client generated ids. I'm just hoping to create them as Rails nested resources.
Is there possibly a workaround for json-api resources similar to what was created for Active Model Serializers here: https://github.com/json-api/json-api/issues/795#issuecomment-202810800
I'm just trying to create a a few related entries in an atomic request.
For record fetching, I use sideloading.
I'm using Ember-data with the EmbeddedRecordsMixin to include the embedded relationships
Thanks for any suggestions

Have you read this article?

This will be resolved when JSON API is extended with Operations. Over the next few weeks I'm hoping to put some time into testing this in JR as a step in writing the update to the spec.

Thanks @aldhsu . That is a great article, and lovely solution for the client side. Does this work for you with json-api-resources.
I keep getting an error message:
code: "115"
detail:" Data is not a valid Links Object.

@ianpetzer I haven't had to implement saving embedded records yet. Just something on my horizon. You may need to handle the request manually using the processor hooks.

Hi @ianpetzer , can you implement that? I'm new in ruby rails world and I don't understand how to use the "processor hook"..

@ianpetzer, have you manage to overcome this issue? I keep getting the same error message like you:
title: "Invalid Links Object"
code: "115"
I follow http://jsonapi.org/format/#crud-creating

Hi,
My understanding is that jsonapi-resources aims to be a json-api compliant
implementation.
This behaviour of embedded nested resources is slated for json-api v1.1
which hasn't been adopted yet. I tried to look into how to add this to
json-api resources but it was a bit beyond me.
The only option that I've managed to find that offers this behaviour is
https://jsonapi-suite.github.io/jsonapi_suite/ but I'm currently stuck on
Active Model Serializers 0.8 because of this issue.
Good luck, and if you manage to make embedded resources work on Json-api
resources, please let us know. I would love to switch over and this is the
only thing blocking me.
On Fri, Mar 31, 2017 at 6:39 AM, LarryMckuydee<EMAIL_ADDRESS>wrote:

@ianpetzer https://github.com/ianpetzer, have you manage to overcome
this issue? I keep getting the same error message like you:
title: "Invalid Links Object"
code: "115"
I follow http://jsonapi.org/format/#crud-creating
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/cerebris/jsonapi-resources/issues/775#issuecomment-290614177,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHZh6IVfNbx_E80Ro4_r-_9vBV5Si0_ks5rrIOQgaJpZM4JSklF
.

Thanks for bringing JSONAPI Suite to my attention, @ianpetzer.
I, too, would absolutely love for JR to support embedded resources one way or another, even though it’s not (yet‽) part of the jsonapi.org spec.
The way JSONAPI Suite deals with temporary client IDs seems pretty cool.
I wish someone smarter and faster than me would whip together a fork of JR which does this.

I managed to create a record with nested association records following the docs section on flattening relationships.
So instead of writing my request this way:
{
  "data": {
    "type": "redemptions",
    "relationships": {
      "items":
        "data": [
          { "type": "items", "attributes": { "offer_id": "1", "quantity": "7" } },
          { "type": "items", "attributes": { "offer_id": "3", "quantity": "3" } }
        ]
    }
  }
}

I sent the relationship data as part of the main object's attributes:
{
  "data": {
    "type": "redemptions",
    "attributes": {
      "items": [
        { "offer_id": "1", "quantity": "7" }
        { "offer_id": "3", "quantity": "3" }
      ]
    }
  }
}

And I defined my resource object getter and setter:
class Platform::Api::RedemptionResource < JSONAPI::Resource

  attributes :items

  model_name 'Platform::Redemption'

  has_many :items, class_name: 'RedemptionItem'

  def items
    @model.items.pluck(:id)
  end

  def items=(params)
    @model.items.destroy_all
    params.each do |param|
      @model.items.build(offer_id: param[:offer_id], quantity: param[:quantity])
    end
  end

end

I have a feeling there will be a better solution in the future depending on how the conversation goes, but this is my working solution for now.

Thanks @martinverdejo, this example was very helpful. I hope to see this feature included soon. There is an example of this in the official JSON API docs here http://jsonapi.org/format/#crud-creating


Build failing with typescript

Hi guys,
Any idea why this fails to compile? I followed all the guidelines correctly.
Server works in dev mode.
Code for the line 44:
// ...
const db: Prisma = new Prisma(prismaOptions)
const typeDefs = importSchema('app-schema.graphql')
const schema = makeExecutableSchema({typeDefs, resolvers})
const server = new GraphQLServer({
  schema,
  directiveResolvers: directiveResolvers,
  context: req => {
    return {
      ...req,
      db,
    }
  },
})

Build failed output:
$ rimraf dist && tsc --pretty
src/index.ts:40:34 - error TS2345: Argument of type '{ schema: GraphQLSchema; directiveResolvers: { isAuthenticated: (next: any, source: any, args: an...' is not assignable to parameter of type 'Props'.
  Types of property 'schema' are incompatible.
    Type 'GraphQLSchema' is not assignable to type 'GraphQLSchema'. Two different types with this name exist, but they are unrelated.
      Types of property 'astNode' are incompatible.
        Type 'SchemaDefinitionNode' is not assignable to type 'SchemaDefinitionNode'. Two different types with this name exist, but they are unrelated.
          Types of property 'loc' are incompatible.
            Type 'Location' is not assignable to type 'Location'. Two different types with this name exist, but they are unrelated.
              Types of property 'startToken' are incompatible.
                Type 'Token' is not assignable to type 'Token'. Two different types with this name exist, but they are unrelated.
                  Types of property 'prev' are incompatible.
                    Type 'Token' is not assignable to type 'Token'. Two different types with this name exist, but they are unrelated.

 40 const server = new GraphQLServer({
                                     ~
 41   schema,
    ~~~~~~~~~
...
 48   },
    ~~~~
 49 })
    ~

thanks

Server works in dev mode.

In what mode doesn't it work then? are you deploying it to a specific system?

I need to build it to create docker box. the project is based off official Prisma TS boilerplate which has an issue ( found out about it yesterday )  with version mismatch in yarn.lock and package.json.  Meaning that if you clone project and run yarn then yarn build it builds it nicely if you install any package then build it fails.

The issue has been solved and I'm adding it here as a ref.
I had the following
// UserMutation.ts
import {forwardTo} from 'prisma-binding'
import {Context} from '../../interfaces'
export default {
  async createUser(parent, {data}, ctx: Context, info) {
    return ctx.db.mutation.createUser(
      {
        data,
      },
      info,
    )
  },
  updateUser: forwardTo('db'),
}

Signatures are different, that's why it fails on the updateUser.
...
  createUser: [Function: createUser],
  updateUser: [Function],
...

because clearly Iresolvers interface is defined bit differently:
export interface IResolvers {
    [key: string]: (() => any) | IResolverObject | GraphQLScalarType;
}

So changin all that to following:
import {Context} from '../../interfaces'
export default {
  async createUser(parent, {data}, ctx: Context, info) {
    return ctx.db.mutation.createUser(
      {
        data,
      },
      info,
    )
  },
  async updateUser(parent, {data, where}, ctx: Context, info) {
    return ctx.db.mutation.updateUser(
      {
        data,
        where,
      },
      info,
    )
  },
}

builds it even with --declarations :)

I'm having similar issue with IResolver. My project compiles if I modify it but appending  | any at Interface.d.ts definition.
(I'm breaking the type checking like other cited solutions)

I don't know this is same for everyone else, but after I added
yarn add --dev  @types/graphql
everything works fine for me


[New Algo] Can we support mining Dero (AstroBWT/v3) On Webminer

@MarcoCiaramella Can we support mining Dero (AstroBWT/v3) for this package
Pool: https://miningpoolstats.stream/dero
Coin: https://dero.io/
Miner: https://github.com/whalesburg/dero-stratum-miner

Hello @tuananh19961  sorry for the late reply.
I didn't find a C version of the algo so I have to port the GO source to C. I hope to deal with it asap :)

Thank for your hardworking @MarcoCiaramella.
Wait good news from you.


UI refresh preview

preview: https://deploy-preview-184--friendly-raman-30db7b.netlify.app
Netlify comment: https://github.com/Toniq-Labs/entrepot-app/pull/184#issuecomment-1260342384

Closing this because toniq-main is now the source of truth for the new marketplace UI.


CharacterBody3D sticks, stutters, slows down when sliding against walls

godot 4.1.1
godot-jolt 0.5.0-rc1
In my 3d platformer game the character sticks to, stutters on and slows down against walls.
I have attached a project that I hope will be useful for testing this.
joltWallSlideTest0.zip
Video (sped-up to trade off length versus file size):
joltwallslidetest0demo.webm
When you press run, a thousand-odd characterbody3d's with box collision will walk across a section of trimesh level collision at some amount of slope into a wall at some angle. You can also click one for a closer look (click again to return). The project will run slow but I don't think (?) this will affect results. If desired I could add a smaller, more focused test scene.
Generally, characters should slide along walls until they fall off the level (except those on green sections with a flat wall). You'll see under a lot of typical configurations that some will get stuck. If you move them by repeatedly tapping up, most (but usually not all) will make progress along their wall. The most success appears when block on walls is disabled, but normally you'll want it enabled.
note: haven't tested under godot physics yet, but I expect it might be similar (I think I've seen some allusions to similar issues being more to do with move_and_slide than the physics itself?)

That's quite the setup! Thank you for taking the time to report the issue.
It does seem like Godot Jolt performs worse than Godot Physics on some of these, even when using the more traditional capsule shape for the player. Specifically the left side of the lower half seems to be more adversely affected than the rest, as your video clearly shows already. Godot Physics is not entirely immune to this though, and there are some stragglers here and there.
Similarly, when just adding a third-person controller and walking around on these platforms, the same relationship can be observed, where with Godot Jolt you might end up getting stuck a bit more often, specifically on the walls of some of the steeper platforms, and with Godot Physics you might not get stuck as often, but you do eventually.
I suspect this will end up being similar to #524, where it's likely that some flaw in the implementation of move_and_slide has been made more prominent in Godot Jolt due to some differences in the types of collision detection that the two engines use.
I will need to step through the code to see what's actually going on here though.

That's quite the setup! Thank you for taking the time to report the issue.
It does seem like Godot Jolt performs worse than Godot Physics on some of these, even when using the more traditional capsule shape for the player. Specifically the left side of the lower half seems to be more adversely affected than the rest, as your video clearly shows already. Godot Physics is not entirely immune to this though, and there are some stragglers here and there.
Similarly, when just adding a third-person controller and walking around on these platforms, the same relationship can be observed, where with Godot Jolt you might end up getting stuck a bit more often, specifically on the walls of some of the steeper platforms, and with Godot Physics you might not get stuck as often, but you do eventually.
I suspect this will end up being similar to #524, where it's likely that some flaw in the implementation of move_and_slide (which is largely implemented on the Godot side of things) has been made more prominent in Godot Jolt due to some differences in the types of collision detection that the two engines use.
I will need to step through the code to see what's actually going on here though.

Slightly related question, I assume with godot-jolt we are using Godot's implementation of CharacterBody3D, would it be possible to expose the jolt native character controller?

I assume with godot-jolt we are using Godot's implementation of CharacterBody3D

Yes, move_and_slide is mostly implemented on the Godot side of things, but the actual collision checks it relies on is delegated to the physics server, so this extension still plays some part in it.

would it be possible to expose the jolt native character controller?

Maybe. I haven't really looked into it. I've tried to limit the amount of custom nodes I expose, since nodes exposed from GDExtension can't be interact with programmatically from C#, which is very unfortunate, especially from something as logic-heavy as a character controller. I'm also not sure how exactly the inheritance of PhysicsBody3D would play out in practice, which it would have to inherit from in order to work with things like Area3D and whatnot.

This problem should be fixed once #559 is merged, and seems to perform slightly better than Godot Physics even.
Thanks a lot for providing this test scene, @tom-jk, it was incredibly useful for tracking this one down. It also helped me find and fix another bug related to move_and_slide. It honestly made me regret not having spent more time creating some sort of test suite, like I promised myself I would once upon a time.
Here's what it looks like after a default run when using Jolt, before the changes:

Here's what it looks like after a default run when using Jolt, after the changes:

Here's what it looks like after a default run when using Godot Physics:

Note that it still stutters slightly when sliding along the walls though, but from what I can see that's pretty much identical to how Godot Physics behaves, so I'm assuming that's due to how move_and_slide is implemented on the Godot side of things.

The fix for this is included in the newly released 0.7.0-stable.

Thanks, that's definitely a big improvement:

It differs a little from yours above, but other commits have happened in the meantime so that's not too unexpected.
I've given it a brief test run in my main project but little seems to have changed there, so I'll have to look closer at what it is I might be doing wrong - though I, too also expect that it now probably lies more with godot than jolt.

I've given it a brief test run in my main project but little seems to have changed there

If you find that it behaves better when using Godot Physics then I'd be interested in seeing a more representative repro. It doesn't have to be as flashy as the one you provided here.

Best I've managed so far is this where both get stuck, but GP gets a little further up the slope and maybe does it a little smoother?
joltwallslidetest1.webm
GP looks to snag on a spurious wall-like normal, Jolt's not so clear.
joltWallSlideTest1_share.zip
Pressing Enter while the player is stuck will print something like the following:
(Godot Physics)

Slide Collision Count = 2
  slide #0: depth = 0.00106543221045, travel = (-0.001497, 0, -0.001663), remainder = (-0.026376, 0, -0.029307), collision count = 3
    collision #0: pos = (0.639648, 8.602197, -12.28522), nor = (0, 0.819152, 0.573576)
    collision #1: pos = (-0.360352, 8.602197, -12.28522), nor = (0, 0.819152, 0.573576)
    collision #2: pos = (-0.360424, 8.602134, -11.28524), nor = (0.975253, 0.126812, -0.181106)
  slide #1: depth = 0.00189882400446, travel = (-0.000558, 0, -0.003003), remainder = (-0.005931, 0, -0.031939), collision count = 3
    collision #0: pos = (0.640631, 8.60288, -12.2862), nor = (0, 0.819152, 0.573576)
    collision #1: pos = (-0.359369, 8.60288, -12.2862), nor = (0, 0.819152, 0.573576)
    collision #2: pos = (0.640631, 8.60364, -12.28728), nor = (0, 0, 1)

(Jolt Physics)
Slide Collision Count = 2
  slide #0: depth = 0.00138680811506, travel = (-0.001089, 0, -0.00121), remainder = (-0.026785, 0, -0.029761), collision count = 4
    collision #0: pos = (-0.093299, 8.255125, -10.08977), nor = (0.975253, 0.126812, -0.181107)
    collision #1: pos = (-0.093299, 7.977794, -10.28395), nor = (1, 0, 0)
    collision #2: pos = (0.518514, 7.664889, -10.9466), nor = (0, 0.819152, 0.573576)
    collision #3: pos = (0.105318, 7.664889, -10.9466), nor = (0, 0.819152, 0.573576)
  slide #1: depth = 0.00115310552064, travel = (-0.000253, 0, -0.001365), remainder = (-0.006235, 0, -0.033577), collision count = 4
    collision #0: pos = (0.105429, 7.665005, -10.94677), nor = (0, 0.819152, 0.573576)
    collision #1: pos = (0.867551, 7.665005, -10.94677), nor = (0, 0.819152, 0.573576)
    collision #2: pos = (-0.093299, 8.234673, -10.10409), nor = (0.975253, 0.126812, -0.181107)
    collision #3: pos = (-0.093299, 8.255015, -10.08984), nor = (1, 0, 0)

I'll try to come up with something a little more definitive...

The getting stuck part was resolved recently in #581, but I haven't published an actual release with it yet.
The smoothness part of it is a more complicated topic, with no good solution, unfortunately. It's a side effect of the mechanism that fixes the getting stuck part. There are ways to make it better in this particular test case, by making this configurable and setting it to a lower value, but that will simply lead to getting stuck in other places instead, as well as negatively affecting RigidBody3D. Frankly, this is probably one of those cases where the best option is to fix (or at least improve) move_and_slide from the Godot side of things instead, but that's a big task that I can't really afford to spend time on right now.
In general though you will see better (albeit not perfect) results by simply not using a BoxShape3D for your character and instead something like the more traditional CapsuleShape3D, so if that's an option for you then you might want to explore that.

Apologies for the long wait, but the fix for the getting stuck part of your latest repro is included in the newly released 0.8.0-rc1. I'd appreciate it if you could give it a try and report back how well it works for you.

Haven't tested it properly otherwise yet, but I can affirm that it does solve getting stuck in that repro.

The fix for this is now also included in the newly released 0.8.0-stable.


For loop incorrect placement of closing bracket

The following python code
def clear():
    grid = []
    for i in range(0, config.SIZE):
        grid.append(0)

maps to
function clear() {
    grid = [];
    for (i in range(0, config.SIZE)) {
        grid.push(0;    });
}

This happens with while loops as well. Do you know any workaround?

Hi @Dimitri0xff,
Thanks for finding this issue! I've pushed a new release to PYPI 1.2.1 which is available for download now and resolves this problem.
Thanks!
~Timothy


paginator add context manger

https://broadworkbench.atlassian.net/browse/CD-212

@ACharbonneau branch for testing https://github.com/CancerDataAggregator/cda-python/tree/adding_new_print


Better UI Testing

We're currently doing a bad job at testing the mitmproxy console UI. While there's an argument to be had that test coverage for UI code quickly yields diminishing returns, we should certainly do better than we do right now. It would be very cool if we had a basic framework to drive UI interactions for testing. I'd love to be able to write a test that roughly looks like this:
def test_edit_setcookies():
    ui = TestUI()
    ui.run("console.edit.focus set-cookies")
    ui.press("a foo <tab> bar <tab> <enter>")
    # set a cookie attribute
    assert ui.focus_flow.cookies == ...

The syntax is obviously up for debate, but it should get the general idea across. I'm sure @Kriechi would be happy to extend his testing empire to mitmproxy.console as well. :smile:

I will take a look at it :)

Fixed: https://github.com/mitmproxy/mitmproxy/blob/main/test/mitmproxy/tools/console/test_integration.py


Interrupted Effect

Was thinking of this Katana Zero effect where someone gets interrupted and recreating it in scribble.
https://thumbs.gfycat.com/CreamyInconsequentialGermanspaniel-size_restricted.gif
I was thinking to do this in scribble, I probably just need to get the glyph x and y position, translate that to room coordinates. Figure out the blend mode and then if I'm using a sprite font then you can easily access the sprite data and make them fly offscreen.
At the moment, is it possible to get the glyph x and y position of each character? Wanted to see the challenges of implementing a system like this.

Answered of Discord, but for future reference use .get_glyph_data()