multistageFlatten.test Query appears to diverge during compilation

Attempting to explain the following query from multistageFlatten.test against the MongoDB connector just hangs at the repl:
explain select * from mongo32/testdata/nested_foo where (foo LIKE "%zap%" OR foo[*] LIKE "%15%" OR foo[*][*] LIKE "%meh%" OR foo[*][*].baz LIKE "%moo%" OR foo[*][*].baz[*] LIKE "%quu%" OR a LIKE "%13%")
it isn't clear if it is just taking a very long time (I waited minutes) or has indeed diverged. I also haven't tried against other connectors to confirm the divergence is in QScript, but it seems likely as this test is disabled for all connectors.

As of #2902 this query takes ~10 seconds to explain. Though it returns incorrect results against spark. I didn't test any other connectors. The qscript contains many joins because source merging through the shifts is failing. This is possibly related to #2133.

Possibly also related to #2366.

This relates to the search card slows

Closing for the same reason as #2935


core: add helpers for LocalDestination and LocalSource (close #98)

Current coverage is 68.04% (diff: 100%)

Merging #100 into master will increase coverage by 0.39%

@@             master       #100   diff @@
==========================================
  Files            16         16
  Lines           643        651     +8
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            435        443     +8
  Misses          157        157
  Partials         51         51

Powered by Codecov. Last update b2d3810...432b7fb


[WFCORE-5065] Add an optionally implemented, ServiceLoader loadable i…

…nterface to do deployment transformation
https://issues.redhat.com/browse/WFCORE-5065
This has no effect unless a dist provides a module with an impl. The idea being that an EE 9 variant of full WildFly would.

@bstansberry I'm fine with merging the PR as it is. My only question is about in-place replacement of files. Should we add a comment in the java doc to let the implementors know that src and target could be the same and they're the ones that have to take that into consideration.

@bstansberry thanks


Add GroupNorm and LayerNorm onnx parsing

This PR extends the normalization support with GroupNorm and LayerNorm.
Since they are very similar in implementation and usage, it is grouped in one PR.
I saw that there was already support for layernorm. This extends the parsing of the onnx node, but still uses built in primitives for calculation.
Similar support for groupnorm is not added yet. Is it needed? dnnl supports it. If so, i would recommend a follow-up PR instead of extending this.
Also MIOpen just introduced layernorm as a primitive, but it is in BETA.
Resolves https://github.com/migraphx-benchmark/AMDMIGraphX/issues/94 and https://github.com/migraphx-benchmark/AMDMIGraphX/issues/100

Similar support for groupnorm is not added yet. Is it needed?
Would be good to add that. But not sure about priority. We already have matcher that pattern matches primitives to LayerNorm. Perhaps it can be tweaked to match for group norm as well.
cc : @pfultz2  what do you think ?


Add  CountAsOne config option to RSpec/ExampleLength

To add CountAsOne configuration I had to adapt ExampleLength cop to use CodeLength methods like Metrics/BlockLength, Metrics/MethodLength, Metrics/ClassLength already uses.

Before submitting the PR make sure the following are checked:

[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Updated documentation.
[x] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
[x] The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

If you have created a new cop:

[ ] Added the new cop to config/default.yml.
[ ] The cop is configured as Enabled: pending in config/default.yml.
[ ] The cop documents examples of good and bad code.
[ ] The tests assert both that bad code is reported and that good code is not reported.
[ ] Set VersionAdded in default/config.yml to the next minor version.

If you have modified an existing cop's configuration options:

[x] Set VersionChanged in config/default.yml to the next major version.

I realized that I forgot to adapt specs to ExampleLength:
It was (copy-paste from ModuleLength specs):
expect_no_offenses(<<~RUBY)
  module Test
    ...

I fixed to:
expect_no_offenses(<<~RUBY)
  it do
    ...

Sorry hehe.

If you rebase on master, the edge tests should pass on CI.

Done @bquorning. Thanks.


Width customization

How to customize the size at which the table is converted to stack. Default is 40em (640px) How to increase say 60em or 900px

The mixin will not work with any other css file, correct? For example: tablesaw.bare.css

That is correct, I believe.
It probably could be made to work with that with some wrangling or overrides, but with the current project infrastructure, tablesaw.stackonly.scss (which provides this mixin) is only a drop-in replacement for tablesaw.stackonly.css, which includes all the default tablesaw styles.


Should the custom element reject boards above 2217 bytes and if so, how?

It's without question possible to do this as part of the validation step, but what should the element do when a board it is loading fails? It could possibly:

Dispatch a spring-board-invalid event and leave it up to the larger client to decide.
Refuse to display the loaded HTML at all...
...and instead render some sort of generic "not valid" output...
...or not! I've yet to see (so far) any other client actually attempt to enforce this part of the spec.

I think it might be fun & useful to define some "default content" for basic error conditions, including "board too big", "board's signature is busted", and, I suppose, "board ain't there". These are such neat little spaces for expressiveness & culture-building; I'm thinking of the Fail Whale, and of Chrome's offline dinosaur game.
Fields of emoji flowers? I don't know; I truly haven't given it a thought until this moment. But I think it's a cool opportunity.

That's a great (and fun) idea! I'm trying to think of ways to open up the door to clients to make these kind of design decisions, so each one can have their own flourishes — one possible path is to establish <slot> elements for each condition so those condition-based responses can be defined by the client via HTML and CSS.
What I may try to do first (in the same spirit) is have <spring-board> throw custom events for each scenario so folks can start experimenting with fun/interesting ways to react to different error states.

What I may try to do first (in the same spirit) is have  throw custom events for each scenario

Ooo, this is really cool -- and, a good opportunity for me to "learn how this works" in a modern component-ized JavaScript environment. I will absolutely wire this into my demo client, and figure out some creative ways to handle those events.


IR: Use frozen dataclasses to enforce immutablity - Part 1

Note: This is part 1 of a double-header, which is first concerned with changing the definition and constructor usage of regular IR nodes. Part 2 will specifically focus on the constructor usage of Scope objects and expand the change presented here to ScopedNodes.
The core rationale behind this change is the fact that we currently use a lot of monkey-patching and hidden magic functions in our IR node definition to enforce pseudo-immutability. However, with Python 3.7+, dataclasses have been introduced that can be used to natively express all these concepts (immutable attributes; dict-like comparison; hashes based select attributes, ...) including the ability to declare an object frozen=True and thus prevent direct regular-style updates to the object. We can, however, keep our explicit back for in-place updates (Node._update) in place by accessing Node.__dict__ directly.
~The most crucial and high impact user-level change that this PR brings is the strict requirement to use keyword-only notation for Node constructors. From Python 3.10 onwards, we will be able to enforce this strictly via kw_only=True, but until then the requirement is implicit and will need updating of all(!) downstream scripts. On the other hand we now gain strict validation at constructor level via pydantic, which means any wrongly constructed (or re-constructed) Node will immediately fail if the provided type is incorrect. The reason for the keyword-only need comes from our use of inheritance, which would otherwise force the utility attributes (source, label) from the common base class to the front of *args (see here).~
After some more soul searching, I've found a way to keep our current argument ordering in place, and thus continue to allow mixed args and keyword-arg constructor usage. To achieve this, a slightly quirky class definition pattern is used, where the typed attributes of a Node type are defined in a private base class of the form class _NodeTypeBase, so that we can post-pend it to the Node/LeafNode/InternalNode base classes, thus ensuring that the argument ordering stays as before. This modification of the PR (sorry), means that only a rigorous usage of tuples for tuple-typed attributes (like body or pragma) are needed on the user-side, keeping the impact fairly low). However, with this style, the auto-conversion of None or list-type constructor arguments to tuples is no longer automatic, so shortcutting this will now throw errors, and likely requires user-side changes to transformation recipes / scripts.
Some more comments on the detailed implementation:

In-place updates via Node._update() are supported via direct insertion into Node.__dict__
label and source are now pure attributes, not properties
the dataflow analysis attributes are kept as private copies and inserted directly into Node.__dict__ in the post_init; this allows us to check the attachment from the properties as before, but means they are excluded from hash and comparison operators
Node._args is gone now, but custom comparison and hashes remain for now; this will be removed in part 2 (see next point)
ScopedNode objects are not yet frozen dataclasses, as the way we construct Scope objects conflicts with this approach; there are several follow-on restrictions due to this:

we store the Node._argnames as a class attribute, so that we don't need Node._args anymore; this will eventually be removed again in part 2
We need to maintain custom dunder methods and custom canonical caching until we can switch the Scope to be pseudo-immutable too (in part 2)

As a final note, the concrete type definitions might not be ideal, since in a few cases I have to use body: Tuple[Any, ...] instead of body: Tuple[Node, ...]. This is due to the fact that our transformers are prone to inserting nested tuples in some places, which would otherwise put more onus on the user scripts to flatten things super-rigorously. A further tidy up of the transformers could also be in order once part 2 has landed, but that is a "future work" item.

Codecov Report

Merging #15 (c0c9d7e) into main (a2403d5) will increase coverage by 0.25%.
The diff coverage is 98.80%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
+ Coverage   91.07%   91.32%   +0.25%
==========================================
  Files          86       76      -10
  Lines       14847    13734    -1113
==========================================
- Hits        13522    12543     -979
+ Misses       1325     1191     -134

Flag
Coverage Δ

lint_rules
?

loki
91.32% <98.80%> (-0.01%)
:arrow_down:

transformations
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

loki/visitors/transform.py
79.90% <77.77%> (+0.18%)
:arrow_up:

loki/ir.py
91.84% <99.20%> (+0.19%)
:arrow_up:

loki/analyse/analyse_dataflow.py
93.95% <100.00%> (-0.05%)
:arrow_down:

loki/frontend/fparser.py
92.90% <100.00%> (+<0.01%)
:arrow_up:

loki/frontend/ofp.py
97.52% <100.00%> (-0.09%)
:arrow_down:

loki/frontend/preprocessing.py
90.75% <100.00%> (ø)

loki/frontend/regex.py
96.62% <100.00%> (ø)

loki/frontend/util.py
93.02% <100.00%> (ø)

loki/program_unit.py
96.53% <100.00%> (ø)

loki/scope.py
92.06% <100.00%> (ø)

... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@reuterbal Ok, I've changed the approach in this and updated the PR description accordingly. I think I've also chased down the last few idiosyncrasies, but CI will confirm soon. I think it's ready for review now.
One last comment is that, once the constructor checks were activated, I found a bunch of subtle undetectected bugs that I'e tried to fix in the head commit. It's noteworthy that these are not complete, and I think there is significant scope for improvement and for tightening some of these checks, but I leave that for a follow-up PR, as even re-creating current behaviour is not easy.

@reuterbal Ok, finally managed to fix the underpinning issue that was tripping up full-physics transformations (see the commit related to preventing Section.body to become nested). I've also pushed fixes for the other comments, so I think this one is ready for another look. :smile: :pray:

Thanks so much for chasing up all of that, looks great now and ready to be merged (curious about the fallout this is going to create ;-) )


Add multi transformer ability

Updating an earlier pull request: https://github.com/yajra/laravel-datatables/pull/838

Released on v1.1.0, thanks a lot and sorry for the delay. ❤

BTW, if you can, please also a submit a PR on docs at https://github.com/yajra/laravel-datatables-docs. Thanks!


[WIP] Allow accessing binary from vendor/bin

Refs #1
I am trying to see if there is a way I can get the binary working.

I think before this is possible we have to have a better/different way for phpchunkit to be configured. Right now the configuration is in the bin file.

It could maybe be done by introducing a phpchunkit.xml file that the configuration is read from which would allow you to configure everything and define what to use for the listener callbacks for sandbox preparation, database creation and sandbox cleanup. Then the bin/phpchunkit would be the same for every implementation.

Take a look at #3. This is what I think we should do. Something like that.

Closing in favour of #3


Fix lock order for UpdateWorkflowExecution

Previous style held lock for longer than necessary. Lock and update was moved to end of transaction.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Direct sms not working on Android 13

When I try this package code on Android 13 device message not initiated on messaging app and not send to the receiving device.

This package tested Android 13 devices. It's working fine. are you permitting android.permission.SEND_SMS In android/app/src/main/AndroidManifest.xml. And also check your mobile balance

Can you tell what kind of device you are being tested on?

As all pertinent details have been addressed, I assume the matter has been resolved, and I will proceed to close this issue

As all pertinent details have been addressed, I assume the matter has been resolved, and I will proceed to close this issue


Add an option to skip github forks

A few commands enumerate GitHub repositories:

scan --github-user=USER
scan --github-org=ORG
github repos list --user=USER
github repos list --org=ORG

These currently do not offer any filtering mechanism on the set of resulting repo URLs. It would be useful to have an option to ignore forked repos.

It would also be useful to have some kind of functionality when enumerating a Git repository to focus only on commits authored by a particular user (This is related to #29). The idea there being that if you had that mechanism, you could still scan forked repos, but only focus on certain commits within the fork.
(The use case in this comment is more complicated than simply skipping forked repos.)

Also useful things:

Add an option to enumerate repositories belonging to the authenticated user when using a token
Add an option to enumerate gist repos for particular users
Add an option to enumerate wiki repos for each project

Visibility is also a really useful filtering option. If my token gives access to an entire organisation (since that gives me a higher rate limit from GitHub), can I then specify to only scan public repositories

Might make logical sense to split it up with --github-organization and --github-user scanning options. Then you could have a subsequent validation step depending on whether the user matches the auth token you receive, or just wait for the API request to fail with a mismatched type and bubble that back to the terminal.

After looking at the github CLI , its quite nice and does all of this already https://cli.github.com/. Maybe you just follow the unix philosophy and if we want to do repo filtering, do it first using github cli and then parallelise scanning with nosey parker

After looking at the github CLI , its quite nice and does all of this already https://cli.github.com/. Maybe you just follow the unix philosophy and if we want to do repo filtering, do it first using github cli and then parallelise scanning with nosey parker

Yeah, that's a solid idea, and the sort of thing I often recommend to people when they run into a situation where Nosey Parker's built-in enumeration capabilities don't hold up: gather whatever content you want in advance, and then scan that location on the filesystem.
That said, I still intend to keep GitHub enumeration capabilities in Nosey Parker. Having something built-in that works much of the time is a big convenience. (When I first implemented this support, I was surprised myself with how useful it was at casting a larger net.)

Note that the official GitHub CLI (gh) has a repos list command, which uses the --source and --fork arguments to specify only non-forks and forks, respectively.


Variance annotations are not allowed in type aliases for intersections

🔎 Search Terms
variance measurement markers sub sup intersection type aliases
🕗 Version & Regression Information

This is the behavior in every version I tried

⏯ Playground Link
https://www.typescriptlang.org/play/?ts=5.6.0-dev.20240808#code/C4TwDgpgBAKgYgewQHgGoEMA2BXCA+KAXigG8oFtgAuKDHaAXwG4AoUSWAIXQCc0tcBYmQCWAOxoAKXgHMadXAEoiBAG4IRAEyjM24aDG4AvZOPKVaA-EViIUC6wDIuvfvTysgA
💻 Code
interface Foo<Value> {
  out: Value;
}
interface Bar<Value> {
  in: (arg: Value) => void;
}

// }
interface Foo<Value> {
  out: Value;
}
interface Bar<Value> {
  in: (arg: Value) => void;
}

type Baz<in out Value> = Foo<Value> & Bar<Value>;

type First<in out Value> = Foo<Value>;
type Second<in out Value> = Bar<Value>;

// Variance annotations are only supported in type aliases for object, function, constructor, and mapped types.(2637)
type Baz<in out Value> = Foo<Value> & Bar<Value>;

// both members are allowed to have annotations
type First<in out Value> = Foo<Value>;
type Second<in out Value> = Bar<Value>;

🙁 Actual behavior
Error is raised
🙂 Expected behavior
I'd expect this to work, especially since https://github.com/microsoft/TypeScript/pull/56418 allowed it to work on more types. Note that this issue isn't even strictly related to using generic references as constituent members. The same issue happens with type aliases and interfaces
Additional information about the issue
Maybe this is expected but I couldn't quickly find any issue related to it or an explicit mention of intersections being purposefully disallowed here

The behavior matches the error message; why is this unexpected?

I'm not saying it doesn't match the error message. That part is fine - although somebody could argue that { a: 1 } & { b: 2 } is still an object type. I just expected an intersection like this to almost always be substitutable with its "resolved" form and it caught me off guard that it wasn't here. So I got interested in why this isn't allowed today or why it might no be a good idea to allow it 😉

"Is an intersection of object types an intersection, an object type, or both" the greatest thread in the history of forums, locked by a moderator after 12239 pages of heated debate

The real answer IIRC is that variance is never used when checking intersections, but I might be off here. @ahejlsberg ?

FWIW, I checked what happens under the hood. When comparing 2 instantiations of Baz from this example relateVariances gets called as normal and in the case of failure allowStructuralFallback gets computed as false. So this intersection takes the regular variance-based codepath as far as I can tell.


Supervised consumers

This is a first cut at having supervised consumers. This feature can be used to support things like RPC servers where a client application wants to have long-lived subscriptions that last across re-connect attempts. It works by adding an entry to your supervision tree like:
consumer_settings = %{
  connection_name: :rpc_gnat,
  consuming_function: {Dispatch.RpcServer, :handle_request},
  subscription_topics: [
    %{topic: "rpc.atlas.dispatch.shard_service.search", queue_group: "rpc.atlas.dispatch.shard_service.search"},
    %{topic: "rpc.atlas.dispatch.user_shard_service.search", queue_group: "rpc.atlas.dispatch.user_shard_service.search"},
  ],
}

children = [worker(Gnat.ConsumerSupervisor, [settings, [name: :rpc_consumer]], shutdown: 30_000)]
supervise(children, strategy: :one_for_one)

This consumer supervisor will check for the named connection, and if it finds the connection available it will subscribe to the given topics and monitor that connection. It automatically retries in the case that the connection dies or is unavailable. It will then call the module and function you specify whenever a message arrives for one of those subscriptions.
In a future cut I will add graceful shutdown that unsubscribes itself from the topics and waits for all of the outstanding tasks to complete before finishing its shutdown. How long to wait can be configured in the supervision tree via the :shutdown option which will give the ConsumerSupervisor a configurable number of milliseconds to finish its own shutdown before it is sent a hard kill signal and forced to shutdown.
I also need to add a moduledoc and perhaps a few sanity tests in a followup PR
/cc @newellista @film42 @abrandoned

I did some benchmarking on 8-core nodes and adding in the supervised tasks adds a little overhead. A previous benchmark that setup 4 connections and spawned the handling of those messages as raw unlinked processes was able to complete 10,258 request/sec. A similar version with 4 supervised connections and 4 supervised consumers did 9,595 request/sec (94.5%).
I think that 5.5% is worth giving up in order to get SASL error reports when the processing of a message fails and have graceful shutdown semantics.

I'm going to go ahead and release this change, but document it as experimental. I'm working an a potential alternative where people send messages to a managing process that automatically re-subscribes when a connection is re-established. That way consumers don't have to monitor the connection or worry about whether it currently exists. I want to experiment both types of solution so I can better learn the pros and cons.


spiff diff does not show differences in template ordering

spiff diff fails to recognize that the ordering of templates is relevant (not for bosh but -in practice- for monit)
$ cat a.yml
---
templates:
  mytemplate:
  - name: A
    version: 1
  - name: B
    version: 2
$ cat b.yml
---
templates:
  mytemplate:
  - name: B
    version: 2
  - name: A
    version: 1
$ spiff diff a.yml b.yml
no differences!
$ spiff -v
spiff version 1.0.8dev

I was able to reproduce this issue off the latest official release of spiff.  Since only severe issues are being fixed in spiff at this time, we will document this as a known issue in the README on the master branch.

The README changes have been made: https://github.com/cloudfoundry-incubator/spiff/commit/1d3169748936e4891a4f6f6d082e6d0537abaca3

@CAFxX turns out this is actually intentional.  spiff diff only notifies you of changes that matter for a deployment manifest, so if you're using it to diff arbitrary YAML you might not get expected results.  I've updated the README.
As you point out, BOSH doesn't technically guarantee anything about the ordering of templates (https://github.com/cloudfoundry/bosh/issues/832) so it makes sense that spiff doesn't tell you anything about those diffs.  Perhaps in practice it matters, but I'm not sure spiff should have knowledge of undocumented behaviour in BOSH.  Given that spiff isn't under active development, I'm not inclined to actually change any spiff code.


translation error

I found a translation problem with version 12

@diwu01 please provide more information (and links, if possible)

the error code file : addons\web\i18n\zh_CN.po
error code : #. module: web
#. openerp-web
#: code:addons/web/static/src/js/core/misc.js:17
#, python-format
msgid """You may not believe it,but the application is actually loading..."
msgstr "请内心等待，应用仍在加载..."
right code:
msgstr “”请耐心等待，应用仍在加载...“”

This does not seem to be Testcontainers related at all.


Slow video scrubbing down in order to appear more fluid?

Apple's standard video scrubber changes the speed as you lift your finger higher, leading to more "smooth" scrolling as it goes through more frames. Currently, it looks like the seek bar is not returning enough values, which causes scrolling frames to appear jittery.
Tagging @colejd  on this one, would be a good video feature addition

Turns out adding the tolerance before and after caused the issue. Removed it and we're golden! Same behavior as Apple's stock video player
@colejd


Add a global handler function

Is your feature request related to a problem? Please describe.
We supply a REST API. We are using await fetch() extensively in our code when calling external services. If an external service has a response where res.ok is falsy, we have to add a custom handler to every place we call fetch. I would like to simplify this logic for users that develop our REST API by adding a global handler.
Describe the solution you'd like
https://www.npmjs.com/package/node-fetch#handling-client-and-server-errors recommends this:
function checkStatus(res) {
    if (res.ok) { // res.status >= 200 && res.status < 300
        return res;
    } else {
        throw MyCustomError(res.statusText);
    }
}

fetch('https://httpbin.org/status/400')
    .then(checkStatus)
    .then(res => console.log('will not get here...'))

I would rather want to to be able to add a custom handler, like:
fetch.responseHandler(checkStatus()); // this should be globally set on fetch
fetch('https://httpbin.org/status/400');

// alternative to avoid using the default handler
fetch('https://httpbin.org/status/400', { handler: null });
// OR
fetch('https://httpbin.org/status/400', { handler: someOtherFunc() })

This way, I can create a sane approach where I can throw errors upstream in all API routes to be handled in a generic way when peer services fail. It would also be cool if the handler actually got access to more things, like the URL that was called and other options.
Describe alternatives you've considered
To use the handler at every invocation, but this is easy to miss for users.

@thernstig did you find any workarounds for this?

this will not happen, we follow the fetch specification. and we don't want to adda any extra non-spec'ed methods to this.
what you could do is adding a custom fetch method that dose it for you
async function request (...args) {
  const res = await fetch(...args)
  if (res.ok) {
    return res
  } else {
    throw MyCustomError(res.statusText)
  }
}

and then you can always use request to make all the request


Add app roles (Optional) step fails with "Property appRoles on the service principal does not match the application object"

Import-Module Microsoft.Graph.Applications

$params = @{
	appRoles = @(
		@{
			allowedMemberTypes = @(
				"User"
			)
			displayName = "User"
			id = "8774f594-1d59-4279-b9d9-59ef09a23530"
			isEnabled = $true
			description = "User"
			value = $null
			origin = "Application"
		}
		@{
			allowedMemberTypes = @(
				"User"
			)
			displayName = "msiam_access"
			id = "e7f1a7f3-9eda-48e0-9963-bd67bf531afd"
			isEnabled = $true
			description = "msiam_access"
			value = $null
			origin = "Application"
		}
		@{
			allowedMemberTypes = @(
				"User"
			)
			description = "Admin,WAAD"
			displayName = "Admin,WAAD"
			id = "3a84e31e-bffa-470f-b9e6-754a61e4dc63"
			isEnabled = $true
			value = "arn:aws:iam::212743507312:role/accountname-aws-admin,arn:aws:iam::212743507312:saml-provider/WAAD"
		}
		@{
			allowedMemberTypes = @(
				"User"
			)
			description = "Finance,WAAD"
			displayName = "Finance,WAAD"
			id = "7a960000-ded3-455b-8c04-4f2ace00319b"
			isEnabled = $true
			value = "arn:aws:iam::212743507312:role/accountname-aws-finance,arn:aws:iam::212743507312:saml-provider/WAAD"
		}
	)
}

Update-MgServicePrincipal -ServicePrincipalId $servicePrincipalId -BodyParameter $params

This steps fails with
Update-MgServicePrincipal : Property appRoles on the service principal does not match the application object.
At line:1 char:1
+ Update-MgServicePrincipal -ServicePrincipalId $servicePrincipalId -Bo ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: ({ ServicePrinci...vicePrincipal }:<>f__AnonymousType2`2) [Update-MgSe
   rvicePrincipal_Update1], RestException`1
    + FullyQualifiedErrorId : Request_BadRequest,Microsoft.Graph.PowerShell.Cmdlets.UpdateMgServicePrincipal_Update1

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d9067ae9-89d0-5854-7327-856d930e7712
Version Independent ID: e0ed6a1b-34bc-55a2-b4ca-61fe3f8ca367
Content: Use Microsoft Graph APIs to configure SAML-based single sign-on - Microsoft Graph
Content Source: concepts/application-saml-sso-configure-api.md
Product: applications
Technology: microsoft-graph
GitHub Login: @FaithOmbongi
Microsoft Alias: ombongifaith

Hi @LijuV-MSFT - Unfortunately, this forum is only for documentation-related issues but Microsoft Graph Q&A is the best forum to answer this functionality question. I recommend that you raise this question there. You may be requested for a request ID for investigation. Closing this issue here.


feat: unbox_snapshot to unbox Box<T> into @T

Feature Request
Describe the Feature Request
A libfunc/corelib function to unbox a Box<T> type into a @T type. This would allow us to not take ownership of the value inside the box when unboxing it, and would avoid unnecessary unbox-rebox operations when accessing a field of the T type without modifying it.
Describe Preferred Solution
A libfunc similar to match_nullable_snapshot - that converts a Box<T> to a @T.
Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)
I can try myself at it with some guidance

[x] Yes
[ ] No

I think instead adding a: extern fn box_forward_snapshot<T>(value: @Box<T>) -> Box<@T>; would be better (less actual logic).
same for: extern fn nullable_forward_snapshot<T>(value: @Nullable<T>) -> Nullable<@T>; - this can probably replace match_nullable_snapshot as well.
I'm wondering if having the opposite as well would be beneficial.

I'm wondering if having the opposite as well would be beneficial.

I don't see any specific use case for this. Do you mean @T into Box<T>?

no - just instead of forwarding the snapshot pulling it backwards - i indeed don't see a particular usecase.


Ng2-smart-table list set selected item trouble.

Hi everyone,
I'm working on a crud scenario. Adding new item is OK but edit time I have some trouble.
I'm using settings like this, I have listed clearly on adding new item.
vehicleType: {
        title: 'Araç',
        editor: {
          type: 'list',
          config: {
            selectText: 'Select',
            list: this.vehicleTypeList,
          },
        }
      }

But when I want to edit new item select option  list notthing to show selected item. I want to set select item saved data to update data.
As you see below image , when click edit button on the right drop down selected item always empty on red line circle, I need to do blue circle , items need to fill like this.

note that selection is done by what you have in the VALUE property of an object
I had the same issue, i had to set the 'value' property to be the same as the title property in order for it to work
editor: {
type: 'list',
config: {
list: this.groups && this.groups.map((grp)=>{
return {'value':grp.name,'title':grp.name}
})
}

this is not worked for me ☹

project.component.ts
columns: {
project_code: {
title: 'Project',
type: 'html',
filter: false,
editor: {
type: 'list',
config: {
selectText: 'Select',
list: []
},
}
},
...
}
And then ,
getProject() {
this.service.getProject()
.subscribe(
data => {
this.settings.columns.project_code.editor.config.list = data;
this.settings = Object.assign({}, this.settings);
},
)
};
It's Worked 🤗


Portal General Notice Banner

As an APS user, I would like to be informed of any issues with the portal/gateway from the portal, so that I may be better aware of issues affecting these services.
During the Oct 4 Silver Outage, it would have been useful to provide notice to clients using the portal that the gateway in Silver was not available. While we do have a maintenance banner, the outage with the gateway did not stem from maintenance. Additionally, the portal was still functional; only the gateway was experiencing issues.

Needs some UX for showing how this banner is displayed on the Portal.

Duplicate of #288, closing


Rewrite DMN Editor's "Data Types" tab in React

As the title says, the scope of this task is to come up with a new implementation of the Data Types tab for the DMN Editor.
This implementation needs to be 100% in React, and provide all the features that are available on the DMN Editor today.
There's work that has already been done in this area, but never made it to the main branches. @kelvah did a lot of progress in the past, and he shared some details with me. See https://github.com/kelvah/kogito-tooling/tree/DTE-prototype-2-treeview. There are some other resources for information I can share with whoever takes this task.
Keep in mind that we're gonna be developing this without having the DMN Editor ready to use it, as a rewrite is also ongoing for it in React. It is expected that the new component called DmnDataTypesTab exposes enough features that will allow the new DMN Editor to use it without problems. We need to think about it and agree on the props that the DmnDataTypesTab component will have.
### Acceptance criteria
- [ ] A new package called `dmn-data-types-tab` is created.
- [ ] The `dmn-data-types-tab` has its own dev webapp, and works in isolation.
- [ ] The `dmn-data-types-tab` exports a component called `DmnDataTypesTab` to be consumed by the `dmn-editor` package.
- [ ] The `DmnDataTypesTab` component is  able to provide all the features available on the current Data Types tab in in the DMN Editor.
- [ ] The `DmnDataTypesTab` is entirely written in React nas has no dependencies with GWT.
- [ ] Some basic unit tests are expected for pure functions with minimal mocking necessary.
- [ ] Some basic UI tests are expected, using PlayWright against the dev webapp.

may we add a acceptance crieteria to update docs? feel free to assign to me such point

As many things that were planned as individual tasks before, I'm going to close this ticket and address it as part of

#577

The Data Types screen has changed a little bit too. I still think it may be a good idea to extract a new package called dmn-data-types, especially because there is so much logic related to external ItemDefinitions. But this won't be done right away. For now, all Data Types-related logic is going to be inside dmn-editor.
Here's a sneak peak of the new interface.


Long load times / hang and high CPU usage

With my medium sized 1.16 modpack that I'm currently trying to update from 1.16.2 to 1.16.3, I seem to run into the issue of the game practically hanging when starting up when Towelette is enabled. Depending on the selection of mods, it might just take a long time to load.
Minecraft: 1.16.3
Fabric API: 0.22.0+build.408-1.16
Towelette: 4.1.6+1.16.2
... and 50+ more mods.
With all mods, the game can get stuck for over 8 minutes - I didn't bother running it any longer.
With Tech Reborn and Reborn Core disabled, the loading still hangs for over 1 minute.

Looking at the log when my game starts this seems to be caused by it trying to add the same block state over and over for EVERY SINGLE BLOCK STATE causing massive log outputs and presumably largely contributing to this

Can confirm on 1.19.2


Fix typo, ignore editor metadata

Hi @tufanbarisyildirim, thanks for starting this project!  I have started working on other features, so more PRs will follow soon.

Thanks @qba73, I appreciate it. Looking forward to seeing new features.


/horoscope ares and it will get your daily horoscope

    What about horoscopes /horoscope ares and it will get your daily horoscope

Originally posted by @rk250ky in https://github.com/KieranRobson/Clarence-Bot/issues/26#issuecomment-1294789799

Implemented in https://github.com/KieranRobson/Clarence-Bot/commit/5b37d5a2e93a973d75091b23400938dc21332a0e


Update nunit reference to 2.7.1

Updates the nunit reference to latest nunit2 binaries.
as existing binaries 2.6.4 do not support OneTimeSetup and OneTimeTearDown
having this in an official nunit-vs-adpater would help alot in migrating from nunit2 to nunit3

Is it possible to switch to using the package rather than checking binaries into GitHub?

Sure, I will check it!
I just updated what was there, without bigger changes 😉 to make the release happen.
Because I need it for a larger set of nunit 2.4 Tests to migrate finally to nunit 3...

@CharliePoole is there a nuget package which contains these dlls

nunit.core.dll
nunit.core.interfaces.dll
nunit.util.dll

I just found the TestRunner Package itself to contain them

@BobSilent You found it while I slept! :smile:

But I did not find the util.dll, therefore this one is still checked in.
PackageReference is no big deal, but build needs to have a newer Visual Studio (currently 2015)

I forgot about util. When I created the package for use by the v2 adapter extension, I managed to get rid of it by replicating a few helper classes. Probably not worth the trouble here, but that's up to @osiristerje as is the decision about which VA to target.

@CharliePoole @OsirisTerje how to proceed here?

@BobSilent I got involved because I maintain the legacy NUnit V2 project and created the V2 pacakge. But I'm not on the team that works on the adapter any longer, so @OsirisTerje has to decide whether to merge your change. Since he hasn't commented here, I am wondering if he isn't getting notifications. I'll ping him with an email.

Sorry,  seems I lost the notifications for this some time ago.  Thanks @CharliePoole  for pinging me :-)
I'll have a look at this.

Thanks, it would really be helpful for me to get the latest binaries in here, it simplifies my migration path to v3.
And sorry for making stress 😀

Sorry,  seems I lost the notifications for this some time ago.  Thanks @CharliePoole  for pinging me :-)
I'll have a look at this.

Merged the PR now, there should be a new package out on the dev feed (myget) shortly.  I'll work through the stuff also and put out a quick beta probably tomorrow, that will then be on the nuget feed.

Thanks a lot.


Several leftovers of 403

Several leftovers:

I still wish idiom brackets to be desugared in the desugarer, so (| 1 + 2 |) would work.
It would be nice if LocalVar.IGNORED are generated for unused telescopes, but doing so fails the assertion. I think this might mean that we have substitution bugs (maybe we need to formalize everything like Idris2 did...).
There isn't something like do(myBind, myReturn), and we don't have local openings. I guess we may want local openings.

Originally posted by @ice1000 in https://github.com/aya-prover/aya-dev/issues/403#issuecomment-1134983216

I think it makes sense for now to improve the idiom brackets feature and push the others until we have time


[BUG] Repeated join and leave before the cluster ever gets to a stable status

The edge case that the memberCluster is marked as Leave right after it is marked at Join.

we removed the state in the member cluster so that we won't get into this status anymore.


Crashes when completing std::libc::

Hi!
I've been having this issue since I installed racer a few days ago and today I did a git pull and rebuilt racer but still the same issue exists.
mm@JMBA-DEV:~/rust/racer$ target/release/racer complete std::libc::
bogofile:1:9: 1:14 error: file not found for module types
bogofile:1 pub mod types ;
^~~~~
bogofile:1:9: 1:14 help: name the file either types.rs or types/mod.rs inside the directory "."
bogofile:1 pub mod types ;
^~~~~
thread '' panicked at 'Box', /home/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libsyntax/parse/parser.rs:971
thread '' panicked at 'called Option::unwrap() on a None value', /home/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libcore/option.rs:362

Hi @yohanesu ,
For the record, I get a recursive loop when I complete std::libc::
Marking as bug

Yes, that was what I meant. Not crash.. It uses 100% for a long time and eventually exits.

cool thanks

I think this is fixed now, closing


nodeAffinity/nodeSelector doesn't impact postgres pod

The values.yml provides both a node selector + node affinity configs:
# Node labels for pod assignment
# Ref: https://kubernetes.io/docs/user-guide/node-selection/
nodeSelector:
  kubelet.kubernetes.io/sonarqube: "true"

and
# Affinity for pod assignment
# Ref: https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#affinity-and-anti-affinity
affinity:
  nodeAffinity:
    requiredDuringSchedulingIgnoredDuringExecution:
      nodeSelectorTerms:
       - matchExpressions:
          - key: kubelet.kubernetes.io/sonarqube
            operator: In
            values:
              - "true"

Which work as expected for k8s to schedule the sonarqube pod. However, this is not used / I don't see any affinity or selector configs available for the postgres pod, so the postgres pod will get scheduled on whatever node available in the cluster. The use case for this in my situation is we have the k8s cluster in EKS, and we basically have a few special type of nodes that we don't want random things scheduled on / have security group controls that prohibit communication between certain nodes. If/when the postgres pod gets scheduled on one of these restricted nodes sonarqube breaks. We'd like to either be able to specify the node affinity/anti-affinity or nodeSelector for the postgres pod as well.
I know we could create postgres outside of this chart and use the available vars to point sonarqube to use it instead so we have work arounds but it would be easier to just use the baked in postgres included in the chart and be able to control it's scheduling a bit more. Thanks!

Try the following which works for me:
postgresql:
  primary:
    nodeSelector:
      kubelet.kubernetes.io/sonarqube: "true"

This is referenced at the end of the SonarQube configuration section starting at "You can also configure values for the PostgreSQL database via..." which will take you to the postgres configuration parameters. Just be sure to place all postgres parameters under the "postgresql" config section in your values file.
Hope that helps!


i_<C-\><C-o>gcc  prints g@$

Thank you for this amazing plugin! (TJ brought me here)
I found this strange bug that happens for your plugin, but doesn't occur with Tpope's.
Write the following: (I used python for this example)
print("hello world")

When while still in insert mode write: <C-\><C-o>gcc
(<C-\><C-o>) takes you into normal mode for a single command before returning to insert mode)
expected behavior:
# print("hello world")

actual behavior:
print("hello world")g@$

setup (default):
lua require("Comment").setup()

nvim v0.7.0-dev
Let me know if you need any other information please!

I am not sure about the <C-\><C-o> combination but AFAIK even <C-o> is enough to put you on normal mode from insert mode.

for some strange reason even gcc exhibits the same behavior as above

I see, that both <C-\><C-o> and <C-o> are similar. Although, I am not sure how to fix this as of now. vim-commentary must be doing something to prevent this, might be a workaround or something trivial.

Hmm, I found another bug that I fixed with might actually lead to some clues as to what the problem might be with this plugin.
So let this be a motivating example:
nnoremap J mzJ`z

This map ensures the cursor stays where it is when joining lines together.
So let this be a motivating example, with the cursor placed at the end of the first line:
print("hello world")
print("hello world")

Now, when I try joining the lines in insert mode using the <C-o> hack this happens:
print("hello world")J`z
print("hello world")

Essentially, it seems that the remap doesn't seem to completely work here as it makes a mark for the first command mz, but then returns to insert mode before the other commands are completed.
I found that this solves the problem:
function! LineJoin()
norm! mzJ`z
end function
nnoremap J :call LineJoin()<cr>

It seems like a function call fixed the problem, but I can't be entirely sure without diving deeper into the code.

Hey @Josiah-tan, Sorry for coming on this so late. But would you mind trying #204 and let me know whether this fixes the issue?


Add classes to the markup based on tags

Eleventy lets you define tags on Markdown pages, which can then be accessed in a group through Eleventy's collections.
{% for page in collections.vocabulary %}
  ...
{% endfor %}

I used this in Bronze Guidelines and we'll add info about it to the Quire documentation as I could see it being a useful feature for the community, and certainly us again in the future.
It was also then useful to be able to style those tagged pages in a particular way, and by adding tags in as part of our page classes, as this PR does, it eliminates the needs to add both tags: and a separate class: to every page.

@mphstudios good idea to add more detail there, thanks! just pushed the update

@geealbers per team discussion, to avoid naming collisions we are going to refactor this to use a data attribute, data-tags=[], on the page.


Moved javadoc exclude to parent pom to fix 'mvn javadoc:aggregate'

With the 4.5.2 release I wanted to update the published javadocs but found that running ´mvn javadoc:aggregate` runs into problems because of the sugarcrm WSDL stubs that are generated and not 100% javadoc "correct". Normally we have an exclude rule for that in the sugarcrm module but since the ´aggregate´ goal runs on the parent module, it does not apply. So with this PR I want to change it back so that the exclusion is done in the parent POM.
I removed it from the sugarcrm module to avoid redundancy. Hope that is correct, but feedback welcome.

LGTM


Passing process id of parent process for monitoring.

Passing process id of parent process for monitoring.

@harshjain2,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Suggestion: Port ETS2/ATS native Razer support to Aurora

SCS Software just released native RGB support for ETS2/ATS but it's only available for Razer Chroma. I suggesto to port the lightning to Aurora.
Thanks

Duplicate of #1556


bug: execution treasury appear on proposal without execution

I tried to create a proposal without execution, but for some reason the execution treasury appear on the proposal page, we should remove it.
https://snapshot.box/#/sn:0x071977084d73002fed430d99108da39d241b900099ccc2a4cdcb7d5041d851d2/proposal/15

I am not able to reproduce, you still see it? maybe share a screenshot

Fixed in #491


LImit K unrolling in amx gemm kernel

The amx gemm kernels now fully unroll K. This results in code buffer size issues, thus for K >= 4096 we fallback to avx512 code gen. We can limit the unrolling of the K loop for large K values and still get amx code.

Addendum: It also seems that we have undefined behavior when running out of code buffer space. Sometimes we gracefully exit with NULL pointer return by code gen, sometime we just exit and crash.

Close by PR #868


Update the PR template

Description
The goal is to minimize the items in the checklist so it is easier to abide by, and to add clear reminders for opening docs tickets and getting explicit approval from Product/DX for interface changes.
Let's discuss the proposed change here, and if we agree to merge I'll open identical PRs against the adapter repos.
Changes

Removed changie checklist item because it is a required branch protection and automation responds with instructive PR comments
Removed CLA checklist item because it is a required branch protection and automation responds with instructive PR comments
Removed docs checklist item in favor of adding a place to link the open docs tickets at the top
Added Product/DX approval checklist item to remind contributors to call out interface changes specifically
Split "Description" header into "Problem" and "Solution".

Just to play devil's advocate, how do know for sure what an interface change is? And is this end user interface? Adapter maintainer interface? etc.

@jtcohen6 @dbeatty10
We can use checklist bullets instead of sections if we like that better. We could also incorporate the interface list you included in the above comment to be more explicit and specific.

Product/DX approval: PRs with significant interface changes require explicit approval from Product or DX. That could be approving the PR, or having written / signed off on an earlier design doc for which this PR is the implementation.

could instead become
Product/DX approval: This PR has no interface changes (e.g.  macros, cli, logs, json artifacts, config files, adapter interface) or this PR has already received feedback and approval from Product or DX.

@nathaniel-may I like your suggestions!
Either checklist bullets _or sections would work equally fine from a DX perspective. Since engineers are the intended audience, we should go with whatever would serve as the best aid to them.

Either checklist bullets or sections would work equally fine from a DX [+ Product] perspective. Since engineers are the intended audience, we should go with whatever would serve as the best aid to them.

Seconded!

I'm expanding the scope of this PR to include more template changes after speaking to @martynydbt @dbeatty10 and @Mathyoub.

I'm going to merge as it is now, and we can update it again if we decide to automate the doc portion as described in https://github.com/dbt-labs/actions/issues/111


Event enrichments

[Current coverage][cc-pull] is 83.58%

Merging [#157][cc-pull] into [master][cc-base-branch] will decrease coverage by 3.82%

@@             master       #157   diff @@
==========================================
  Files           119        127     +8
  Lines          3558       3826   +268
  Methods           0          0
  Messages          0          0
  Branches        407        443    +36
==========================================
+ Hits           3110       3198    +88
- Misses          356        527   +171
- Partials         92        101     +9

Powered by Codecov. Last updated by [27261f0...30163c0][cc-compare]
[cc-base-branch]: https://codecov.io/gh/SpineEventEngine/core-java/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/SpineEventEngine/core-java/compare/27261f03c024b15ffabbd7b0c2f58b6e67861c37...30163c058b094d8c82d7380b232c0f9784a0a5f7
[cc-pull]: https://codecov.io/gh/SpineEventEngine/core-java/pull/157?src=pr

Please improve the code coverage.

I think that CodeCov changed the way it calculated the coverage. Because we had 90% or so, and now we have 75.06%... Though I covered Enricher and other new methods good enough. And some results are stale. I'll add some more tests.

Please see that examples are excluded from coverage.

PTAL. Covered enricher, event bus and new util methods.

PTAL.

PTAL.

Done, PTAL.

LGTM


Search and replace is no longer opening files and is just auto-saving them.

Previous versions of VSCode instead opened all of the files with replacements and adding this functionality without any way to disable it is a major bug IMO.

VSCode Version: 1.26.0
OS Version: Windows 10 Pro, v1803

Steps to Reproduce:

Do a global search and replace.
Files are saved automatically.
Observe all sorts of problems that I didn't previously encounter, such as Node.js based tools re-loading their content since they're watching the files that I replaced.

Does this issue occur when all extensions are disabled?: Yes

OK, sorry this is a duplicate of #49681
I didn't see it the first time I searched.


CursorColor changed on its own

Running 17672, I suddenly found (with two terminal windows open) that one terminal window's cursor had turned black instead of gray. From that point onwards, all my terminals (Windows or WSL) have had a black cursor (even after DECSCUSR calls).
I imagine this might be related to the newly landed support for setting cursor shape, but I'm unable to get this color change to revert.
Deleting CursorColor in the Console registry key took care of the issue, but I'm not sure how it could have come to be in the first place. This option isn't exposed userland, is it? Black is DWORD 0, so it could be that the value was simply created with a default integer for its content, but again, not sure how that happened.

Oh no, this bug actually made it out to insiders 😢
I noticed this a few builds ago internally, I'm not totally sure what it is, but I believe it's a bad manifesting issue, but I already have a bug open to investigate more.
You're correct, deleting the CursorColor key will revert it to the old behavior. Alternatively, you could set it to another hex value to actually give the cursor a specific color.
What's happening with this bug I believe is that we're zeroing out the cursor color, causing it to render as black on black.

Thanks for the speedy reply! Would pre-creating the registry field with a non-zero value on build upgrade perhaps avoid the problem?

That's almost certainly going to be the fix, yea.
To get more specific: conhost treats 0xffffffff as an invalid color. When it sees that value for the cursor color, it knows to instead use the legacy "invert color" behavior of the cursor.
I think I forgot to add to the manifests that the defaults for that reg key (and shortcut property) should be 0xffffffff, so those values are left un-filled.
At about the same time we started type-checking the values in the registry for settings, and zeroing them appropriately.
I'm not sitting in front of the code right now, but my guess is that we're finding no value for the cursor color, and instead of defaulting to 0xffffffff, we're defaulting to 0x00000000 - black.
Fortunately, because these settings get re-applied on build-to-build upgrades, as soon as I fix the manifest it should fix your settings :)

Checked in the fix earlier today.
WE really should create a batch script that people can use to set their cursor colors just in case they run into this, or if they want to change the colors of their cursor just for the heck of it. I just haven't had the cycles to put something together.

Fix is out in Insider build 17711. On the main Windows Build blog too vice WSL/Console Release Notes (which I found odd).

We fixed an issue that could result in the console forgetting the cursor color on upgrade and it getting set to 0x000000 (black). The fix will prevent future users from hitting this issue, but if you’ve already been impacted by this bug, you’ll need to manually fix the setting in the registry. To do this, open regedit.exe and delete the ‘CursorColor’ entry in ‘Computer\HKEY_CURRENT_USER\Console’ and any sub-keys, and re-launch your console window.

As per https://github.com/Microsoft/console/issues/232, this has NOT been fixed even as of 17713, and more fixes are inbound.

Is there a workaround that works on 17713? Deleting the registry key seems not to,  changing the registry key seems not do (tried 0x00202020), or if I go to Fast Insiders, maybe I pick up enough fixes?
Ironically, I went to Insiders just to get the Copy/Paste console fix, which is best feature ever 😁

Yea, it seems that the black cursor color could corrupt your shortcut, which you'd be unable to fix at all. So please be patient while more fixes bubble out :)

What worked for me was setting the cursor color to 60606060, and the cursor type to 1 from zero.
Happy to be patient, sort of, not having a cursor was killing me, was about to roll back, the workaround saved running Insider....

Hi, what's the full path for the registry key? I've been struggling with this as well

@ioweb-gr That depends on how you're launching the console. I'd take a look at HKCU\Console and all of it's sub-keys. If you remove all the CursorColor settings from that tree, then the setting is being stored in the shortcut (.lnk), not the registry.
The persistence (and loading) of the cursor color was disabled for the 1809 release, so whenever you get upgraded to the October Update, that should fix it.

thanks @zadjii-msft I wanted to try the solution here in case it helped because my problem seemed similar however my problem doesn't seem to be the same as this one as the cursor color settings didn't change anything at all. My cursor seems to disappear when moving it with arrow keys or while typing. If I leave it there it starts blinking again after a while and I see it but it makes it really hard to type.
The shortcut I'm using is the default shortcut from the ubuntu store app. I'm running currently build 18252.1000.

@ioweb-gr that's #269, unrelated to the cursor color issue.

Ah great. I couldn't find it before. I'll monitor that thread then


Values of some associated data are not displayed in entity grid

Values of associated data named feed-heurekaCz are not displayed in entity grid, however, GQL returns it.

The issues was in inconsistency of property key cases. The property descriptor builder and the query builder still used camel case notation from the original REST API implementation, however, the internal entity model uses original case. I've simplified it to use the original case everywhere as that's what we want if the API supports it.


SQLI in Node Identifier

The node identifier does not sanitize its input for some of the mysql queries.

This is fixed as I've moved to dynamodb.


ambari: Add jdeb support

This patch add jdeb (debian) package creation support for the following
packages.
-ambari-funtest
-ambari-logsearch
-ambari-metrics-grafana
-utility
Signed-off-by: Naresh Bhat<EMAIL_ADDRESS>What changes were proposed in this pull request?
Add jdeb support for branch-2.6
How was this patch tested?
The patch has been applied, built and tested on Debian 9 stretch.
Please review Ambari Contributing Guide before opening a pull request.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/2912/
Test FAILed.
Test FAILured.

@adoroszlai  Can we merge pull request ?

retest this please

Sure, I will re-test and let you know.

@nareshgbhat - the phrase retest this please is meant for the automated test framework to re-run the unit tests on a pull request.
When I made that comment, it triggered the unit tests to re-run. If they succeed, then we can submit this PR.

@jonathan-hurley and when you repeated the same phrase to explain its meaning, it triggered another re-run. ;)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4374/
Test FAILed.
Test FAILured.

Hah, I actually didn't know that. I would have expected it only to trigger once. Since it failed on 1 test, let's try it again: retest this please.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/4379/
Test PASSed.

@nareshgbhat I actually failed to notice that this was for branch-2.6 which is no longer under development. If these changes are needed in another branch (such as trunk), can you please open a new PR for that?

@jonathan-hurley The patch has been merged into trunk you can refer https://github.com/apache/ambari/pull/1642


Fix cirlcleci tests

Circle CI tests are failing, but tests run locally. Figure out why.

Circle CI is passing


H/adat

-merged upstream/master
-ADAT modularization part for HTML

Ran the sample adat generation and was successful. Ready to be merged.


WIP: BUG: Fixed issue with 4th component in FreeSurfer ASCII mesh

S. explanation https://github.com/InsightSoftwareConsortium/ITK/issues/3772#issuecomment-1334689836.
Changed ascii class extension to .asc to avoid FreeSurfer crash, old extension .fsa preserved for backwards compatibility, with warning for writing. Fixed 4th element.
itkFreeSurferMeshIOTest is reduced mostly for quantitative, get/set and 'expect exception' things for coverage.
Tested with FreeSurfer 7.3.2, 2022/08/04

https://youtu.be/Pylza3ePZTs

I think it is. @blowekamp do you agree?
BUT, that format will be used by almost all writes, instead of other formats. Let's say I want to create new mesh IO module which will support *.dzz format - it will have to fight with FreeSurfer for that extension. Not to mention other well known formats such as *.obj.

Does the MeshIO automatically determine the IO class for reading and writing like the ImageIO? If so accepting all files for CanWrite would cause priority difficulties depending on the order of the MeshIO registered. For example if *.vtk is supported by freesurfer and meshvtk, then the order the factories are registered will determine which meshIO is used. Worse if freesurfer cannot read the file, when it says it can it could take higher priority that IOs which can actually read the file.
I'd recommend just using the "supported" extensions for the CanWrite method.
If the freesurfer IO is wanted to be used for another format it can be explicitly test as the MeshIO for the reader/writer.

If so accepting all files for CanWrite would cause priority difficulties depending on the order of the MeshIO registered.

Thanks. Yes. I will not change CanWrite.

Sorry for the delay. Thanks for having investigated all issues and proposing a fix to them @issakomi :100:. I'm not an expert on FS file formats :pensive:.
For the current state of things:

Am fine concerning @blowekamp's and @dzenanz's comments on the extensions. Have not used enough ITK in recent times so as to have an opinion on this.
OK as for the .fsa warning, and the addition of .asc.
However, I am not sure what is the best way (deprecation, etc.) to gradually remove the .fsa warning to only refuse to read/write them, as the code does not essentially change. @dzenanz @thewtex @blowekamp ?
Should the label argument be an int, or should it be a bool (as initially suggested in the picture in https://github.com/InsightSoftwareConsortium/ITK/issues/3772#issuecomment-1334689836)?
Whether it should be a bool or an int, it changes the API so a migration guide entry is necessary I guess. Not sure if something more would be required, as the removal of the switch cases would also mean that if a third-party code contains such cases, they'd be affected (not sure if their code would work after Mihail's investigation in the related issue, though). I don't know how these changes should be dealt with :pensive:.

In the mid term:

As for the .fsb extension being also weird for FS, not sure whether using e.g. .stl, .vtk, or .gii can then be considered in the tests instead of the .fsb extension.

In the longer run:

@issakomi Many thanks as well for having investigated the mesh/cell vs. curvature/point data distinction (https://github.com/InsightSoftwareConsortium/ITK/issues/3772#issuecomment-1334689836). I guess we will need to e.g. add a flag to say that the file to be tested is a mesh vs. curvature file so that the corresponding methods are called for that type of file. Can be done in a separate PR.
Removing the write/read cycle from the test is fine for me if it makes things easier/allows to go forward at this state. Eventually we will be willing to test the methods somehow; can be done in a separate PR; better to have a working version for now.

@hjmjohnson @seanm @gdevenyi do you know anyone from https://github.com/freesurfer/freesurfer? It would be good if someone more familiar with the file format would provide some feedback.

Whether it should be a bool or an int, it changes the API so a migration guide entry is necessary I guess.

the template is protected, probably there is no API change from user perspective

Not sure if something more would be required, as the removal of the switch cases would also mean that if a third-party code contains such cases, they'd be affected (not sure if their code would work after Mihail's investigation in the related issue, though).

cell components are indices, float, double, long double don't make sense and will crash FreeView.

cell components are indices, float, double, long double don't make sense and will crash FreeView.

I have reverted this to simplify the discussion.

Edit: We will also be willing to clarify the cell vs. point distinction, and the mentioned order in the documentation so that the class methods are called appropriately. Can definitely be done in a separate PR.

AFAIK, Update seems to work. Probably it is the recommended way: just set file name, (input) for mesh reader/writer and Update, BTW.

The class is backward compatible with old buggy files with wrong 4th components e.g.
0.000000  0.850651  0.525731  0.000000
They still could be read.

Edit: I've updated the PR message to avoid closing #3772 with this PR: the right PR will be the one that will fix the binary version.

What fix do you mean? The #3772 is the issue with the test, not with the binary mesh class.

I shall check asc extension once again. The problem is that there are other formats in FreeSurfer with the same extensions, generally any ASCII file with whatever inside can have "asc" extension. Bad. Probably it was the reason that ITK introduced own extensions. Other files (not mesh data) with asc extension can crash the ascii mesh class. Maybe i shall revert the part with "asc" extension and let it be as before or find a way to prevert a crash. It is very difficult with FreeSurfer and extensions.

What fix do you mean? The https://github.com/InsightSoftwareConsortium/ITK/issues/3772 is (or was) the issue with the test, not with the binary mesh class.

@issakomi you're right, my mistake. Added it back. Got confused by the focus on the ASCII files and the commit and PR messages not mentioning that the method calls in the test were modified to fix the issue.

I shall check asc extension once again. The problem is that there are other formats in FreeSurfer with the same extensions, generally any ASCII file with whatever inside can have "asc" extension. Bad. Probably it was the reason that ITK introduced own extensions. Other files (not mesh data) with asc extension can crash the ascii mesh class. Maybe i shall revert the part with "asc" extension and let it be as before or find a way to prevert a crash. It is very difficult with FreeSurfer and extensions. To load ASCII mesh into FreeSurfer they must have "asc" extension, otherwise FreeView crash, but we can not assume that any file with "asc" extension is a mesh and will work with ITK. Oh.

Maybe we should separate the fix to the memory leak in the test and fixing the ASCII format? That way at least the fix to the leak will be eventually merged without being blocked by the fix to the ASCII format.

If you like. I stuck a little with the PR. There are many things I don't like in both classes, e.g. switches over data types that can not work, this 'curvature data' stuff (where is cell type?). Also MeshIOBase could be a little bit bloated with cell/point pixel (?) types like RGBA, tensor, etc. But i don't want to step into this stuff and make so many big changes.

I think best is to split, have the memory leak issue resolved and merged, and then go to tackle the other issues incrementally. As you found the fix, I'd prefer if you would submit it to credit you as the author.

I think best is to split, have the memory leak issue resolved and merged, and then go to tackle the other issues incrementally. As you found the fix, I'd prefer if you would submit it to credit you as the author.

S. https://github.com/InsightSoftwareConsortium/ITK/pull/3796

S. https://github.com/InsightSoftwareConsortium/ITK/pull/3796

The Valgrind defect is gone:
https://open.cdash.org/index.php?project=Insight
I have updated this PR to only change 4th component now. Didn't change extension.
Replaced sphere.fsa with sphere.asc.fsa, produces with FreeSurfer's mris_convert sphere.fsb sphere.asc, but old files with 4th component 0.000000 will work too.
I stuck somehow with FreeSurfer files and mesh IO in general, too many questionable stuff. So the PR is still draft.

The Valgrind defect is gone:
https://open.cdash.org/index.php?project=Insight&date=2022-12-15

This is fantastic @issakomi ! A big thank you.

I stuck somehow with FreeSurfer files and mesh IO in general, too many questionable stuff. So the PR is correct, but still draft, I am not sure what to do with the rest.

I see your feeling, but when we feel the changes needed are big, and we do not have time to properly do them all at once, or have a somewhat incomplete picture, if possible, it is better to split them and do small steps towards the solution.
e.g. you also did some changes to the binary FS mesh IO class in an earlier commit:
https://github.com/InsightSoftwareConsortium/ITK/commit/51832791689480af7dc236e8a95e6e073b890f30#diff-6484fbca670f039ecbb0541b42332f2b0b9844b719c42327b38d90c326335692
If you are more confident with these, can they be put to a separate PR, and make the appropriate changes to the test data/files so that the difference gets tested, fixed and merged independently?
Thanks for all this effort. I know tracking down some stuff can consume a lot of time and energy.

e.g. you also did some changes to the binary FS mesh IO class in an earlier commit:

The only significant change was to modify CanReadFile to use magic number instead of extension
  if (fileTypeIdentifier == (-2 & 0x00ffffff))
  {
    // The input file is FreeSurfer binary surface file
    ok = true;
  }
  else if (fileTypeIdentifier == (-1 & 0x00ffffff))
  {
    // The input file is FreeSurfer binary curvature file
    ok = true;
  }

The problem is I think that a curvature file something very special. In ASCII format it looks like:
000 -11.15284 -100.95035 -0.40290 2.59229
001 -10.57401 -100.85500 -1.28304 2.75554
002 -10.89847 -101.10920 -1.06143 2.48846
003 -11.44057 -101.25616 -0.94590 2.29264
...
...
...
135503 -31.83741 2.20956 -27.58961 3.48273
135504 -16.78938 -65.03230 1.17469 1.45606
135505 -17.24210 -82.13521 -15.37917 2.26153
135506 -44.70148 43.66516 5.29382 2.99865

1st column is the index of the vertex
2nd, 3rd and 4th are coordinates
5th i don't know, a curvature probably :)
I am not sure that it can be used standalone at all, maybe together with other file. Or maybe there different kind of files.
I don't think that binary mesh class works, it reads number of points and cells (?), the numbers is different, how it could be? What kind of cell it should be? Only Read/WritePointData methods are used.
So i decided to do no changes in binary class at.
I am playing with FreeSurfer. It is interesting. Shortly, it works like this (after installation, licensing and setting the environment)
Take T1 MRI and do
recon-all  -i ~/Downloads/DICOM/t1_gre_fsp_3d_sag__132750/00000001.dcm -subjid uih1 -all
Give only one DICOM file, the series will be detected, after several hours there will be new subject (here uih1) with  skull strip (very high quality, BTW), segmentation, surfaces and tons of stuff. There are hundreds of tools (recon-all calls them), rather complicated. There are also videos and tutorials. I am not yet experienced with.

The only significant change in binary class was the modification of CanReadFile to use magic number instead of extension

:+1:, but we all agree that this is an ENH: improvement that we'd like to have: makes the FS binary mesh IO more robust, does not introduce breaking changes, etc. Or am I wrong?

The problem is I think that a curvature file something very special. In ASCII format it looks like:

OK, but this is separate from the above binary format improvement.

I am not sure that it can be used standalone at all. I don't think that binary mesh class works for such files (but works well with surfaces), not sure, it reads numbers of points and cells (?), the numbers are different, how it could be? What kind of cell it should be? Only Read/WritePointData methods are used.

I am not very familiar with mesh files. Maybe the curvature file is always accompanied by a vertex file? @PranjalSahu has been working on mesh files lately. Maybe he can cast some light on this.

So i decided to do no changes in binary class at all.

I see, but we agree that the magic number change is independent of the curvature/point/cell data issue, right?

There are hundreds of tools (recon-all calls them), rather complicated. There are also videos and tutorials.

I know FS does a lot of processing and generates a lot of files, and that it requires several hours of computation for a single subject. But these people have worked hard to develop the tool and make it available. I have not played with FastSurfer, and IDK if it computes the same features/generates the exact same number of files, but might be an option if we want to get the output fast for experimenting with the files.

Maybe the curvature file is always accompanied by a vertex file?

Yes, it can not be used standalone. There are just float values, one per vertex. In fact there are different types: curvature, thickness, weights, etc. In Slicer's FreeSurfer importer plugin it is called overlay file. Also binary and ASCII formats are different, binary has a kind of header: magic number, number of points, number of cells (unused), number of components (always 1) and a float array of values. I don't know how it is supposed to be used in binary mesh class standalone, it is not a mesh, probably there could be a method, something like SetOverlayFile. In ASCII class it is not available, the related methods (for point data) are empty. Generally ASCII files are not native, FreeSurfer doesn't produce them, actually they can be only created with mris_convert (asc extension signals that output should be in ASCII file).

Looks like this is loosely related: https://github.com/InsightSoftwareConsortium/ITKIOMeshSTL/issues/44


Fixed the users dispatching when it got infinite loop (issue-2345)

I currently do not have not a local configured unittests, so this is WIP MR for checks.

Nice! Whats a good title for the PR? Something like ”Fix problem with fixed_count in combination with LoadShapes”?

Nice! Whats a good title for the PR? Something like ”Fix problem with fixed_count in combination with LoadShapes”?

Done. =)

👍 thx!


Quiet logging support

Add support for message muting.
Background: Warnings make trouble in pasteboard of emacs.

msg.c is a mini-library that I wrote (adapted from conventions in the Git source, IIRC) because I did not know about warn(3) et al. It seems wrong to add a “suppress all output” switch to a generic library like this.
Which messages are causing problems for you? If it is just the “unsupported old/new OS” messages, then it would be better to suppress only those. It certainly seems wrong to suppress all of the other possible output (even when in a newly added quiet mode) since there are genuine errors or fatal problems that should still be reported.
If your area of concern is just short-lived executions of pbcopy and pbpaste (e.g. not a long-lived, interactive shell), then you might consider ignoring stderr directly instead (e.g. a 2>/dev/null redirection done in the invoking context).

Thanks. I just found that the problem was not caused by the logging.


[BUG] CI failing on Linux with Java runtime error

Linux tests are currently failing on main with a fatal Java runtime error:
?  #
?  # A fatal error has been detected by the Java Runtime Environment:
?  #
?  #  SIGILL (0x4) at pc=0x00007febd28ff4b9, pid=1657, tid=2008
?  #
?  # JRE version: OpenJDK Runtime Environment Zulu21.34+19-CA (21.0.3+9) (build 21.0.3+9-LTS)
?  # Java VM: OpenJDK 64-Bit Server VM Zulu21.34+19-CA (21.0.3+9-LTS, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64)
?  # Problematic frame:
?  # C  [libopensearchknn_faiss_avx2.so+0x4ff4b9]  sgemm_small_kernel_b0_tn+0x229
?  #
?  # Core dump will be written. Default location: Core dumps may be processed with "/usr/share/apport/apport -p%p -s%s -c%c -d%d -P%P -u%u -g%g -- %E" (or dumping to /__w/k-NN/k-NN/build/testclusters/integTest-0/distro/3.0.0-ARCHIVE/core.1657)
?  #
?  # An error report file with more information is saved as:
?  # logs/hs_err_pid1657.log

Example full log of failure: https://github.com/opensearch-project/k-NN/actions/runs/9455222049/job/26044511867?pr=1722
For the above PR, the tests are passing on a local Linux build.

@ryanbogan Could you confirm if the failure is due the PR or not?

@heemin32 the same error is happening on another PR here: https://github.com/opensearch-project/k-NN/actions/runs/9455190832/job/26044410766?pr=1734

After enabled dynamic arch for openblas build in x64 AL2 build env, the build CI is passed now, closing this issue.
More details on https://github.com/opensearch-project/opensearch-build/issues/4379
CI test example: https://github.com/opensearch-project/k-NN/actions/runs/9735975558/job/26904055122


NRF PWM pin default state is high

Describe the bug
I've set up a custom pin for PWM on my nrf52840dk board - the first thing the main function does is set up a 50kHz signal at a 50% duty cycle. However, the problem is that the pin is getting initialized as HIGH before the code in main even starts running. Line 239 of zephyr/drivers/pwm/pwm_nrfx.c in the pwm_nrfx_init function is the moment where the pin goes HIGH:
int ret = pinctrl_apply_state(config->pcfg, PINCTRL_STATE_DEFAULT);

I stepped into the code but couldn't figure out what exact config is determining the initial state.
Please also mention any information which could help others to understand
the problem you're facing:

nRF52840DK
Stepping through the code to try and identify any parameters that would let me set the initial state

To Reproduce
Steps to reproduce the behavior:

Import the hello_world example
Add the following to the overlay file:

/ {
    pwmleds {
        compatible = "pwm-leds";
        pwm_led0: pwm_led_0 {
            pwms = <&pwm0 0 PWM_USEC(10) PWM_POLARITY_NORMAL>;
        };
    };
};

&pwm0 {
    status = "okay";
    pinctrl-0 = <&pwm0_default>;
    pinctrl-1 = <&pwm0_sleep>;
    pinctrl-names = "default", "sleep";
};

&pinctrl {
    pwm0_default: pwm0_default {
        group1 {
            psels = <NRF_PSEL(PWM_OUT0, 1, 4)>;
        };
    };

    pwm0_sleep: pwm0_sleep {
        group1 {
            psels = <NRF_PSEL(PWM_OUT0, 1, 4)>;
            low-power-enable;
        };
    };
};

Connect up P1.4 to a logic analyzer and see that the pin gets initialized to a HIGH state.

Expected behavior
Either the pin should be LOW or maybe have a config somewhere that dictates what the state should be?
Impact
Annoyance because I can get around this by using the nrfx_pwm API but this affects the native_sim application from building.
Logs and console output

Environment (please complete the following information):

Linux
Zephyr SDK 0.16.4
v3.5.0

I have switched over to using the sw_pwm peripheral and there, if I set up my node like this:
pwmleds {
    compatible = "pwm-leds";
    pwm_led0: pwm_led_0 {
        pwms = <&sw_pwm 0 PWM_USEC(20) PWM_POLARITY_NORMAL>;
    };
};

&sw_pwm {
	status = "okay";
	channel-gpios = <&gpio0 16 (GPIO_ACTIVE_HIGH | PWM_POLARITY_NORMAL)>;
};

I can avoid that initial state of the pin being high. But setting the polarity to NORMAL for the hardware pwm0 node doesn't have the same effect.

I've set up a custom pin for PWM on my nrf52840dk board - the first thing the main function does is set up a 50kHz signal at a 50% duty cycle. However, the problem is that the pin is getting initialized as HIGH before the code in main even starts running.

That happens because the overlay you are using is incorrect. You are altering the pwm0_default node from the nrf52840dk_nrf52840 board definition and you are only changing the psels property in group1 there. And the nordic,invert property stays set, hence the PWM output pin is configured initially high.
You should either remove this property or better, as this way you can avoid similar problems, use different names for pinctrl nodes in your overlays (so that new nodes are created), for example pwm0_default_alt and pwm0_sleep_alt in this case.

@anangl Thank you for your attention to this problem. I thought that by redefining group1, I would be overwriting the entire thing, including the removal of nordic,invert.
If I set up the _alt versions of the pinctrl, how do I make sure that pwm0_default_alt gets applied during the boot cycle and not pwm0_default? This line of code from the driver is executed during the initialization:
int ret = pinctrl_apply_state(config->pcfg, PINCTRL_STATE_DEFAULT);

Here, the PINCTRL_STATE_DEFAULT will refer to the item that is at pinctrl-0. Would I just do this?
pinctrl-0 = <&pwm0_default_alt>;
pinctrl-1 = <&pwm0_sleep_alt>;

Thank you!

@anangl I was able to carve some time out today and test it - I can confirm that what you said is correct. I created the two _alt pinctrl nodes and did this
pinctrl-0 = <&pwm0_default_alt>;
pinctrl-1 = <&pwm0_sleep_alt>;

and that solved the issue for me.
I am going to close this ticket.

I am not able to close it - but it is ready to be closed. Thank you for your help.


Feature request: displayCompleted LifeCycle Method

Moved from: https://github.com/aurelia/cli/issues/487
I'm submitting a feature request

Library Version: 0.24
Operating System: Windows 10
Node Version: 6.7.0
NPM Version: 3.10.3
Browser: Chrome 56.0.2924.87 (64-bit)
Language: all

Current behavior:
I've seen many users, including myself, run into difficulty because there's no clean way to determine when the DOM binding has completed for things like repeat.for loops and other display items that take more than 1ms.  Most recent example here:
http://stackoverflow.com/questions/42241091/execute-function-after-content-has-been-dynamically-loaded-in-aurelia
http://stackoverflow.com/questions/41697495/using-jquery-datatables-with-aurelia
The workaround solution is to add a task at the bottom of the queue, which theoretically will run after all binding jobs have completed.  However, this is not a clean approach.
Expected/desired behavior:
I believe that Aurelia should implement a lifecycle method like displayCompleted or bindingCompleted or something else along these lines.  This is something that would be useful in many scenarios and would alleviate frustrations for designers.
This might even be a very easy solution to implement if the taskQueue.queueMicroTask() approach doesn't have any fatal flaws.  You could simply always insert a task in the queue to call the lifecycle hook if it exists.

consider for vNext?

This is solved in vNext with the bound hook, is a "bubble-up" style hook that runs after all bindings are done. I think we can close this? Since we're not going to have that hook in vCurrent..


Servicing updates for Windows Server, version 1909

Related to #708

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.


Support AWS backups

It should be simply possible to backup data to AWS. Restic has already support for this.

I'm looking for a S3 backup target, any progress on this?

@johansmitsnl It's working for some time now. I'm using this on a production server without any issues..


UI design for homepage

Issue that this pull request solves
Closes: # (issue number)
Proposed changes
Brief description of what is fixed or changed
Types of changes
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Put an x in the boxes that apply

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] My changes does not break the current system and it passes all the current test cases.

Screenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request

Hey @himanshu007-creator I appreciate your effort but I don't think it's good enough to take into consideration. I request you to comeup with a better design

i am working on it mam

i am working on it mam

@himanshu007-creator Closing due to prolonged inactivity

@himanshu007-creator Closing due to prolonged inactivity


Assign a static-nat label to the public-ip address

ISSUE TYPE

Enhancement Request

COMPONENT NAME
Componet:UI
Componet:api

CLOUDSTACK VERSION
4.18 nightly
4.17.2

SUMMARY
Assign a static-nat label to the public-ip address
When a static nat is enabled on a public ip address and its assigned to a vm.
It will be nice to have a static-nat label assigned automatically by cloud stack similar to the source-nat label
It will be easy for the admin user to identify which public ip address is static-nat and which source-nat

@borisstoyanov Could you please add the required labels


toggle-prompt

https://sphinx-toggleprompt.readthedocs.io/en/latest/
pyfluent, but also wherever appropriate for other packages

sphinx_toggleprompt==0.4.0 needs sphinx <7 and >4.5.

We need to wait until sphinx_toggleprompt supports sphinx>=7.1.2


Draw Region Feature

It would be very nice if we had some alternative to Chisels & Bits' draw region. It would make building with this mod much faster and intuitive. Extra points if we could not only break bits but also place them this way.

added in 2.5.4


Fix ember client cancellation bug

Fixes #6058
makeCase surpresses cancellation. makeCaseFull does not. We could probably specify better what spaces are cancelable and get some better semantics, but this fixes the critical issue of all cancellation being suppressed.
Big Bug need to fix ASAP

Can we add a test for this, or is it tricky?

It will only reproduce in an end to end scenario. So possible but not in a clean unit test I don't think. Since it can't run into an error in the middle. Its expected behavior taking a long time and then we cancel that reproduces.

👍 can confirm this fixes https://github.com/http4s/http4s/issues/6058


Fix build problems in NixOs

Updated @samuelrivas

Looks good other than that minor comment in trv.ml

@samuelrivas fixed


chore(behavior_velocity): add system delay parameter and minor update

Description

add system delay parameter
add experiment feedback

Related links

Tests performed

by experiment branch
psim

https://user-images.githubusercontent.com/65527974/164909046-9e01fb5a-beea-40b4-9178-314648c95203.mp4
Notes for reviewers
check for the change
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@taikitanaka3  system_delay apprears to be a global palameter across all scene modules. Could you add an explanation in README.md or something ?

@0x126
Thank you . system delay description was not yet applied so I added.
It's a delay time until autoware process plannig , control and vehicle.

[x] release note


Use better name than "service" for instance of client library

Provide more context in your issues (language, what part of the code, etc.)

@vchudnov-g Renamed the title. The language is in the label.

Thanks. I saw the labels after I posted my comment. I would also have added "in the generated snippets" here and to #112 and #116. Just to make them less cryptic when we're looking back without context.


Prevent Using the Managed Identity for Cloned App Services

When cloning a completely configured app service (e.g. a deployment slot), this also clones AppConfig:AuthConfig:ManagedIdentityEnabledOnUnixTime, but the Managed Identity has no permissions yet.
Ideas: Also store the the app service name for which the managed identity was configured and let SCEPman refuse to request tokens if it is a clone.
Maybe check whether the "Deployment Slot" checkbox helps for this case.

A cloned App Service has no System-assigned Managed Identity. Therefore, no token can be requested anyway. But the docs say you should do it, so we must still take care of this problem.
The "Deployment Slot" checkbox does not help. It just determines whether the setting should stick with the slot or the app when swapping deployment slots.


[ci] Add --kv-cache-dtype option in run-benchmark.sh

vLLM now supports kv cache data type fp8_e5m2. I think we need to update run-benchmark.sh. @simon-mo @zhuohan123 Could you please have a review?

Thanks for the contribution! However, we would not be able to benchmark every setting. I think we will only keep track of benchmarking the one setting that is currently in the CI. If you believe this is also OK, let's maybe close this one? @simon-mo @zhaoyang-star

@zhaoyang-star, thank you again for your contribution. As @zhuohan123 mentioned, we also don't have enough resource to run these benchmark currently in our automated CI system (we are low on GPUs).


Inconsistent descriptions for FlushInterval default

Isssue
The README says the default FlushInterval is 30s, however values.yaml lists the default as 5s
Expected
Identify correct default and make the documentation consistent

@darend, yes the Helm chart has a different default value that this repo.  The docker image is set to 30s.  The YAML files in this repo do not set the defaults.  Honestly this was an oversight, a bug was discovered where the docs said 5s in this repo, but the Dockerfile was set to 30 seconds.  However, for backwards compatability, we have not pushed a new release that changes that.  More waiting until we have more features to collect so yes the Helm chart and YAML in this repo are not in sync at the moment.

fixed with v1.8


Implements Popular Tables and Table Detail APIs

Includes the basic implementation of Popular Tables and Table Detail APIs.
Popular Tables:
For now it simply returns all the available (Amundsen Compatible) tables, as we'd refactor and improve that over the time, once we'll generate all the fields to atlas needed for the Amundsen project.
Table Detail:
Simply returns the basic information of a table at the moment and will get mature over the time.
Note: Apache Atlas python client is not very mature at the moment, so I also opened a couple of PR in that project (also added that as comments) and hence I need to rely heavily on the Atlas REST API structure and the way atlas client is providing the data. Once my PRs would be merged, the number of API calls/queries would be much lower.
Also adds the documentation on how to make atlas tables appear in Amundsen, along with code snippets needed to generate the Super Type and assign that super type to required entity definitions.
Coverage:
Master: 67%
This branch: 71% (covers all the lines in atlas proxy, excluding pass statements)

@feng-tao @jinhyukchang ready for review

nice @verdan , will take a look. BTW, are you able to get the frontend table detail page shown with the atlas proxy?

@feng-tao yes, I was able to populate the Popular Tables and Table Detail pages. Please ignore the test data in the screenshots as I didn't populate all the fields yet in atlas, but atlas_proxy points to the correct attributes.

great news @verdan !

@verdan I am in the strata conference this week, so my review will be slow. cc @jinhyukchang  and see if he has cycle. Otherwise I will try to get to it end of the week.


Instagram::getMediaCommentsByCode() returning 405

Hello - this method is now returning 405 errors with the example provied.
Any idea?
Thanks!

Hi, I am seeing the same problem. getMediaCommentsByCode returns 405
error is on src/InstagramScraper/Instagram.php on line 347
Any idea how to solve it?
Thanks!

405 means method not allowed(GET)
Use POST

Thanks, but isn't that something that should be changed in the API itself?

I did try to change request method to post on Instagram.php:339 but now I am getting a 403. Was someone able to get around this issue? Maybe we need a new endpoint to get comments?
Thanks!

@joseflorido I will release fix soon

I have released fix for this issue

Thanks @raiym, @Bolandish!
It's working again.

Thanks everyone!

I'm having the following error
InstagramScraper\Exception\InstagramException thrown with message "Response code is 403. Body:  Something went wrong. Please report issue."
C:\xampp\htdocs\instagram_api\instagram\vendor\raiym\instagram-php-scraper\src\InstagramScraper\Instagram.php Line 603


Convert/Rewrite frontend in Next.js

To be more flexible in the future and in favor of a new API (#150), the frontend should be rewritten in Next.js or React.

To make it easier and clearer for us and because several people are currently working on the Next.js variant of VeganCheck.me, the repo for the code rebase is not public.
We will publish it as soon as a broken "fix" is not pushed every five minutes.
But until then, the current status can be seen at https://vegancheck-next.vercel.app/.
Attention: Some things are already working!
Huge thanks to @gitgauner and @fastrcloud for coding-along with me!