No self.vocab when not using partitions for the CTM-class

OCTIS version: 1.2.0
Python version: 3.8.3
Operating System: Linux

Description
When performing hyper parameter search with the CTM-model and use_partitions=False, I get the error: AttributeError: 'CTM' object has no attribute 'vocab'.
I believe moving line 94 in CTM.py [self.vocab = dataset.get_vocabulary()] prior to the self.use_partitions if-statement in line 87 would solve the problem.
Current call:  0
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-63-7718f92a8020> in <module>
      1 optimizer=Optimizer()
----> 2 optimization_result = optimizer.optimize(
      3     model, dataset, npmi, search_space, number_of_call=optimization_runs,
      4     model_runs=model_runs, save_models=True,
      5     extra_metrics=None, # to keep track of other metrics

~/anaconda3/lib/python3.8/site-packages/octis/optimization/optimizer.py in optimize(self, model, dataset, metric, search_space, extra_metrics, number_of_call, n_random_starts, initial_point_generator, optimization_type, model_runs, surrogate_model, kernel, acq_func, random_state, x0, y0, save_models, save_step, save_name, save_path, early_stop, early_step, plot_best_seen, plot_model, plot_name, log_scale_plot, topk)
    158
    159         # Perform Bayesian Optimization
--> 160         results = self._optimization_loop(opt)
    161
    162         return results

~/anaconda3/lib/python3.8/site-packages/octis/optimization/optimizer.py in _optimization_loop(self, opt)
    283             else:
    284                 next_x = opt.ask()
--> 285                 f_val = self._objective_function(next_x)
    286
    287             # Update the opt using (next_x,f_val)

~/anaconda3/lib/python3.8/site-packages/octis/optimization/optimizer.py in _objective_function(self, hyperparameter_values)
    214
    215             # Prepare model
--> 216             model_output = self.model.train_model(self.dataset, params,
    217                                                   self.topk)
    218             # Score of the model

~/anaconda3/lib/python3.8/site-packages/octis/models/CTM.py in train_model(self, dataset, hyperparameters, top_words)
     89             data_corpus = [' '.join(i) for i in dataset.get_corpus()]
     90             self.X_train, input_size = self.preprocess(
---> 91                 self.vocab, train=data_corpus, bert_train_path=self.hyperparameters['bert_path'] + "_train.pkl",
     92                 bert_model=self.hyperparameters["bert_model"])
     93

AttributeError: 'CTM' object has no attribute 'vocab'

Despite looking at some demos, I am still not capable of making pull requests, but wanted to let you know nonetheless.
Best,
Thyge

Hi,
I fixed this bug. You can upgrade the package and it should work.
I added your name into the credits of the readme to thank you for your help :)
Bye,
Silvia


Support thumbsup/thumbsdown emojis

The current EntityRecognizer does not support thumbsup and thumbsdown emojis (👍 and 👎). It would be interesting to add them to the valid yes/no answers.
If you think it's a good idea I can send a PR.

@palmerabollo, please go ahead and submit the PR if you have this coded already. Will close this issue, we'll deal with this in the PR. Thanks!


HDFS-15532: listFiles on root/InternalDir will fail if fallback root has file.

https://issues.apache.org/jira/browse/HDFS-15532

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 34s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
33m 48s
trunk passed

+1 :green_heart:
compile
30m 27s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
28m 41s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
4m 25s
trunk passed

+1 :green_heart:
mvnsite
4m 28s
trunk passed

+1 :green_heart:
shadedclient
29m 14s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m  6s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
4m 17s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
4m 24s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
7m 49s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 49s
the patch passed

+1 :green_heart:
compile
28m 16s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
28m 16s
the patch passed

+1 :green_heart:
compile
23m 51s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
23m 51s
the patch passed

-0 :warning:
checkstyle
3m 33s
root: The patch generated 1 new + 44 unchanged - 0 fixed = 45 total (was 44)

+1 :green_heart:
mvnsite
3m 48s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 38s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 31s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
4m  8s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
8m 49s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
14m 50s
hadoop-common in the patch passed.

-1 :x:
unit
154m 35s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 51s
The patch does not generate ASF License warnings.

414m 40s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestFileChecksumCompositeCrc

hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

hadoop.hdfs.TestFileChecksum

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.TestMultipleNNPortQOP

hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2298

JIRA Issue
HDFS-15532

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux b92e771b2da8 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9960c01a25c

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

checkstyle
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/1/artifact/out/diff-checkstyle-root.txt

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/1/testReport/

Max. process+thread count
3208 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 13s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 20s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
29m 13s
trunk passed

+1 :green_heart:
compile
22m 44s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
23m  1s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
3m 27s
trunk passed

+1 :green_heart:
mvnsite
3m 28s
trunk passed

+1 :green_heart:
shadedclient
25m 50s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 42s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
3m 26s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
3m 56s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
6m 52s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 33s
the patch passed

+1 :green_heart:
compile
26m 25s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
26m 25s
the patch passed

+1 :green_heart:
compile
21m 39s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
21m 39s
the patch passed

+1 :green_heart:
checkstyle
3m 27s
the patch passed

+1 :green_heart:
mvnsite
3m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
19m  6s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 39s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
3m 31s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
7m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
11m 20s
hadoop-common in the patch passed.

-1 :x:
unit
120m 30s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 52s
The patch does not generate ASF License warnings.

344m 34s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks

hadoop.fs.viewfs.TestViewFsHdfs

hadoop.hdfs.TestFileChecksumCompositeCrc

hadoop.hdfs.server.datanode.TestBPOfferService

hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy

hadoop.hdfs.TestFileChecksum

hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.TestMultipleNNPortQOP

hadoop.hdfs.TestStripedFileAppend

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2298

JIRA Issue
HDFS-15532

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 6599a7f3ff4a 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 958cab804ef

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/2/testReport/

Max. process+thread count
3166 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 21s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
3m 30s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
33m 58s
trunk passed

+1 :green_heart:
compile
29m 32s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
23m 55s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
3m 35s
trunk passed

+1 :green_heart:
mvnsite
3m 39s
trunk passed

+1 :green_heart:
shadedclient
24m 48s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 48s
trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
3m 32s
trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
4m 10s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
7m  3s
trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 30s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 45s
the patch passed

+1 :green_heart:
compile
31m 23s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
31m 23s
the patch passed

+1 :green_heart:
compile
27m  5s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
27m  5s
the patch passed

+1 :green_heart:
checkstyle
3m 52s
the patch passed

+1 :green_heart:
mvnsite
3m 58s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
19m 10s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 53s
the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
3m 44s
the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
8m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
13m  4s
hadoop-common in the patch passed.

-1 :x:
unit
144m 16s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 31s
The patch does not generate ASF License warnings.

396m 13s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestFileChecksumCompositeCrc

hadoop.hdfs.TestFileChecksum

hadoop.hdfs.server.datanode.TestBPOfferService

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics

hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR

hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2298

JIRA Issue
HDFS-15532

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 4037b09c1838 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 958cab804ef

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

unit
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/3/testReport/

Max. process+thread count
2820 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2298/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Update AlphaFold on .org

Version 2.3 databases are now on CVMFS at /cvmfs/data.galaxyproject.org/byhand/alphafold/2.3
I removed the 2.1 version that's already installed from Main's shed_tool_conf.xml by hand since this never worked on .org due to the lack of databases.
Installation sequence for tool-installers

[x] Test using @galaxybot test this
[x] Inspect CI output for expected changes
[ ] Deploy using @galaxybot deploy this if test install was successful
[ ] Merge this PR

@galaxybot deploy this


Add support for JSON Patch

After a quick glance at your code it seems to me that you implemented PATCH the same way like PUT. Would be cool if you would consider implementing JSON Patch in order to allow (better) partial updates.
See:

http://williamdurand.fr/2014/02/14/please-do-not-patch-like-an-idiot/
http://jsonpatch.com/

I'd love to be able to use the same function to talk to json-server which we use for staging as we use for full postgress

It'd be sweet if RFC 7386 was supported too - it's a simpler variant of JSON Patch (RFC 6902).


EAGLE-670: make kafka publisher configurable and default is async

Kafka send alert in sync would limit the throughput. Make this configurable, and use async by default

@garrettlish the implementation looks a little confusing.
Please just simply use kafka configs: https://kafka.apache.org/08/documentation.html#clientconfig and another part using async kafka producer: https://github.com/apache/incubator-eagle/blob/master/eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/sink/KafkaStreamSink.java#L53-L57
kafka properties
producer.type = async
batch.num.messages = 3000
queue.buffering.max.ms	= 5000
queue.buffering.max.messages = 10000

The convention here:
we will have these properties as part of publishment and need to avoid "." in key, since mongo store doesn't support "." in key, use "_" instead.
There would be many configuration for kafka, let us focus on above properties, and request.required.acks one in this PR.

The configuration is ok. The primary concern here is the async implementation, kafka producer natively support async mode, so that you just need pass through it instead of handle async thread manually which will look not very clean.

BTW: these selected config keys are what we have evaluated in real-case and impact kafka throughput mostly, instead of not requiring you guys to include additional many kafka configurations
producer.type = async
batch.num.messages = 3000
queue.buffering.max.ms  = 5000
queue.buffering.max.messages = 10000

Thx @haoch @RalphSu. I thought we set async for kafka producer and what we need to change is using callback rather than future wait, it is wrong, thanks for pointing out.
I have updated the code to add kafka_client_config (list of name/value map) to specify kafka producer configurations.
By default, I only set producer.type=async.
For batch.num.messages, queue.buffering.max.ms and queue.buffering.max.messages, I think we can use kafka producer default values.
The only difference for default value is batch.num.messages, it is 200 if not specified. Could u please share with us what is your reason to set it to 3000?
the kafka producer properties could be defined in publish properties as follows:
{
"name": "",
"properties" : {
"kafka_broker": "",
"topics": "***",
"kafka_client_config" : [
{
"name" : "request.requrie.acks",
"value": 1
},
{
"name" : "producer.type",
"value": "async"
},
...
]
}
}

The default value is just for example :-).
And when using kafka producer async mode and throughput becomes extremely larger, batch size is one of the most important configurations for tuning.

Yes, cool, then we can keep the current implementation and override the batch size configuration in publish properties kafka_client_config :-)

@garrettlish thanks.


evolution-data-server: 3.36.4 -> 3.36.5

Motivation for this change
Version bump for evolution-data-server.
Changelog:
Evolution-Data-Server 3.36.5 2020-08-07
---------------------------------------

Bug Fixes:
	I#236 - Uses LC_ADDRESS unconditionally in libphonenumber code (Milan Crha)
	I#240 - IMAPx: Disable move to real junk/trash in server-side virtual folders (Milan Crha)

Miscellaneous:
	Fix a memory leak in ebmb_gather_photos_local_filenames() (Milan Crha)
	ESoupSession: Provided SoupAuth might not be always used by libsoup (Milan Crha)

Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

CC: @jtojnar @worldofpeace

Thanks.


std::distance on strided iterator runs forever

Minimal reproducible example on boost 1.64
boost::compute::vector<float> vec(300);
boost::compute::strided_iterator<boost::compute::buffer_iterator<float> > begin(vec.begin(),1);
boost::compute::strided_iterator<boost::compute::buffer_iterator<float> > end(vec.end(),1);
std::distance(end,begin);

This code will run forever. Note that this works perfectly on the buffer iterator alone and it works perfectly when switching begin and end. A rough debugging session reveals that the call above for some reason will choose the default version of std::distance which will iterate over the iterator range. For 64 bit this takes some time.
I came to this issue because for some reason for some iterators a call of begin.distanceTo(end) in the iterator base class is rewritten as -end.distanceTo(begin) somewhere deep in the call stack.

First, I wanted to reference make_strided_iterator_end function, which is there to create correct ends for strided_iterator, but after a moment I've noticed that the stride is equal 1.

i would argue that the issue is that strided_iterator uses iterator_adapter and that assigns the iterator_category strict by standard. The issue is that buffer_iterator returns a proxy object instead of a reference and therefore does not even qualify as forward_iterator. so i bet strided_iterator is just a forward_iterator which explains everything.

The issue is that buffer_iterator returns a proxy object instead of a reference and therefore does not even qualify as forward_iterator.

Actually, buffer_iterator is tagged with std::random_access_iterator_tag.

so i bet strided_iterator is just a forward_iterator which explains everything.

It looks like it's tagged with boost::iterators::random_access_traversal_tag tag, which STL treats like an InputIterator.

exactly. buffer_iterator forces itself the "right" tag, even though it does not qualify for it fully. but iterator_adaptor will check again and rectify this "error". So i bet you have to force the iterator_adaptor to choose the "right" tag as well.

I think it's simpler: the problem is that boost::iterators::iterator_traversal<Iterator>::type, which is used by default in iterator_adaptor converts STL tags to Boost tags. std::random_access_iterator_tag becomes boost::iterators::random_access_traversal_tag.  Using std::iterator_traits<Iterator>::iterator_category in strided_iterator fixes that problem.

thank you for fixing this. The change looks good. If you want, you can close this!


Network december release --- DDoS policy customization

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

Can one of the admins verify this patch?

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-python

Automation for azure-sdk-for-java

Automation for azure-sdk-for-go

Automation for azure-sdk-for-node

@seyedfayaz there is no activity resolving comments provided, milestone is missed. please target on the next monthly branch (review milestones section in one note)

creating a new pr


the free version may refer to this page：https://speech.microsoft.com/audiocontentcreation

This API is quite different than the azure tts API and aspeak won't add support for it.
FYI, if you want to continue to use aspeak for free, you can try to figure out how to use the edge tts endpoint(https://github.com/kxxt/aspeak/issues/56#issue-1640328594) . But aspeak won't use edge tts as the default trial endpoint because the feature set is quite limited and it involves stealing trusted client token.

Anyway, API at https://speech.microsoft.com/audiocontentcreation is strictly restricted too. which I have made a demo and found it.
(You can try it with aspeak in branch alt-impl)


[Task] Add unit test cases for VoiceButton component

Task Description:
Currently, we run unit tests using jest which can be found here.
However, the test cases are not yet comprehensive enough and work can be done to cover more grounds. Specifically for this issue, we hope to add test cases for the VoiceButton component.
Deliverable(s):
New unit test cases that cover the testing of the VoiceButton component.
Additional Context:

Button components can be found here
An example for AudioButton can be found here which may serve as a good source for reference

I'll like to work on this...

I'll like to work on this...

Go for it!

Hey @jerry-604, are you facing any problems with this issue? If so, feel free to reach out for clarifications!

Hey @jerry-604, with hacktoberfest coming to a close very soon, I'll be leaving this issue un-assigned for any final PRs. This is to minimize leftover issues and provide an opportunity for those looking to get that last few PRs in. Feel free to continue with a PR if you're still working on this issue and I seek your kind understanding, thank you! 😊

Hi! If there is no one working on this I would like to have a try!

Hi! If there is no one working on this I would like to have a try!

Go for it!

Hi I have made PR pls check if it's ok

Hey @tjtanjin! I found that the issue has been hanging unchanged for more than a month now so I decided to give it a try and created alternative PR to resolve it. Please, review when you have time. Thanks!


Update GitHub links with new username

Currently, the old links will redirect to the new and correct links, however that is not guaranteed to happen forever. Changing the links to match ahead of time will prevent any potential issues in the future.

Thank you :)
Very nice


Update placeholders to new syntax.

Placeholder syntax changed from

{%query} to <query>.
{%query|type=city} to <query: {type: city}>.

(Now using YAML Flow style.)
Read more: https://trovu.net/docs/shortcuts/url/

Thanks, I didn't see this PullRequest and just synched my repo to yours.


No button

As far as I am aware, it no longer works on Firefox (using Greasemonkey). I viewed the image that accompanied the introduction of ugoira, and the button doesn't appear near the bookmark button or anywhere else at all.

Hello and thanks for your feedback. I just tested it in Firefox 47 and it works as intended. The "Create!" button is supposed to be right below the ugoira animation and it appears right there. Also, clicking the button performs the intended action without any problems. I would like to know more details about your system and or browser version in order to know what can I do to fix the problem you're having. Thanks in advance.

I stuffed up. Never mind, I mistook this script for another one (ugoira2gif). This one works perfectly fine. Apologies for having wasted your time, and thanks for creating this script. Please delete this.

No problem. Thanks to you for using it.


Check Against Main

Just Comparing the 2 seeing what I missed. I have 11 problematic tests so far..

this didnt seem to be comparing to latest update I pushed


i18n doesn't work

Thank you for doing this amazing project, it provides many features that I want, that's great.
But I am now facing some small issues while using it. I added a file name zh.json which located in i18n folder, but I still got English when the page was flashed and commento++ had been reloaded.
I get no error in F12, so what can I do for it?
commento++: v1.8.7
browser: firefox 96.0 in ubuntu 20.04

Thanks for the feedback! Happy to help you with this. Did you recompile the frontend code using make? If not, you will need to add the zh locale to the LOCALES string in the commento.js file if you are using the precompiled version. This string is automatically generated during the compilation process by gulp.

I added the zh.json file to the i18n folder and compiled it from the source code, the language is displayed successfully, thank you.


MinGW64 Zest mrbgem.rake error.

Pardon, I'm a bit new to this. Is there something I should look out for?
---------Getting Zest---------------------
Cloning into 'mruby-zest-build'...
remote: Enumerating objects: 39, done.
remote: Counting objects: 100% (39/39), done.
remote: Compressing objects: 100% (37/37), done.
remote: Total 39 (delta 0), reused 21 (delta 0), pack-reused 0
Receiving objects: 100% (39/39), 52.74 KiB | 8.79 MiB/s, done.
Submodule 'deps/mruby-complex' (https://github.com/pbosetti/mruby-complex) registered for path 'deps/mruby-complex'
Submodule 'deps/mruby-dir' (https://github.com/iij/mruby-dir) registered for path 'deps/mruby-dir'
Submodule 'deps/mruby-dir-glob' (https://github.com/gromnitsky/mruby-dir-glob) registered for path 'deps/mruby-dir-glob'
Submodule 'deps/mruby-errno' (https://github.com/iij/mruby-errno) registered for path 'deps/mruby-errno'
Submodule 'deps/mruby-file-stat' (https://github.com/ksss/mruby-file-stat) registered for path 'deps/mruby-file-stat'
Submodule 'deps/mruby-glew' (https://github.com/IceDragon200/mruby-glew) registered for path 'deps/mruby-glew'
Submodule 'deps/mruby-glfw3' (https://github.com/IceDragon200/mruby-glfw3) registered for path 'deps/mruby-glfw3'
Submodule 'deps/mruby-io' (https://github.com/iij/mruby-io) registered for path 'deps/mruby-io'
Submodule 'deps/mruby-nanovg' (https://github.com/mruby-zest/mruby-nanovg) registered for path 'deps/mruby-nanovg'
Submodule 'deps/mruby-process' (https://github.com/iij/mruby-process) registered for path 'deps/mruby-process'
Submodule 'deps/mruby-regexp-pcre' (https://github.com/iij/mruby-regexp-pcre) registered for path 'deps/mruby-regexp-pcre'
Submodule 'deps/mruby-set' (https://github.com/yui-knk/mruby-set) registered for path 'deps/mruby-set'
Submodule 'deps/mruby-sleep' (https://github.com/matsumoto-r/mruby-sleep) registered for path 'deps/mruby-sleep'
Submodule 'deps/nanovg' (https://github.com/memononen/nanovg) registered for path 'deps/nanovg'
Submodule 'deps/pugl' (https://github.com/mruby-zest/pugl.git) registered for path 'deps/pugl'
Submodule 'deps/rtosc' (https://github.com/fundamental/rtosc) registered for path 'deps/rtosc'
Submodule 'mruby' (https://github.com/mruby/mruby) registered for path 'mruby'
Submodule 'src/mruby-qml-parse' (https://github.com/mruby-zest/mruby-qml-parse) registered for path 'src/mruby-qml-parse'
Submodule 'src/mruby-qml-spawn' (https://github.com/mruby-zest/mruby-qml-spawn) registered for path 'src/mruby-qml-spawn'
Submodule 'src/mruby-zest' (https://github.com/mruby-zest/mruby-zest) registered for path 'src/mruby-zest'
Submodule 'deps/osc-bridge' (https://github.com/mruby-zest/osc-bridge) registered for path 'src/osc-bridge'
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-complex'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-dir'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-dir-glob'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-errno'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-file-stat'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-glew'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-glfw3'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-io'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-nanovg'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-process'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-regexp-pcre'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-set'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/mruby-sleep'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/nanovg'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/pugl'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/deps/rtosc'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/mruby'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/src/mruby-qml-parse'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/src/mruby-qml-spawn'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/src/mruby-zest'...
Cloning into '/c/Users/dmixh/Documents/Gits/zyn-fusion-build/mruby-zest-build/src/osc-bridge'...
Submodule path 'deps/mruby-complex': checked out '4f57a1ef9f968e9d5eef53667c7960a2e98c9750'
Submodule path 'deps/mruby-dir': checked out '89dceefa1250fb1ae868d4cb52498e9e24293cd1'
Submodule path 'deps/mruby-dir-glob': checked out '334c040a2e2c4c2689f8c3440168011f64d57ada'
Submodule path 'deps/mruby-errno': checked out 'b4415207ff6ea62360619c89a1cff83259dc4db0'
Submodule path 'deps/mruby-file-stat': checked out 'aa474589f065c71d9e39ab8ba976f3bea6f9aac2'
Submodule path 'deps/mruby-glew': checked out '6849202f885516b381406e799dcdb430065e19cf'
Submodule path 'deps/mruby-glfw3': checked out '0eeee012fd4bbd6544dd34f17ce2b476ad71d86b'
Submodule path 'deps/mruby-io': checked out '1c4428880b2f0f0fcd81ea2debc5f4459a7ed53c'
Submodule path 'deps/mruby-nanovg': checked out 'd7d4e1ce434131babb5fd6026201011f5b0b50ea'
Submodule path 'deps/mruby-process': checked out 'fe171fbe2a6cc3c2cf7d713641bddde71024f7c8'
Submodule path 'deps/mruby-regexp-pcre': checked out 'a961225c0953dd2bd987111f0836821573616de2'
Submodule path 'deps/mruby-set': checked out '68334311ac7386eef84f3034a256e7135a87625d'
Submodule path 'deps/mruby-sleep': checked out '263d70351a4f75a875f2a35ab9a9128d1ef5da90'
Submodule path 'deps/nanovg': checked out 'b83cf926525e7cea8d2483da2a75852b8c7b6d28'
Submodule path 'deps/pugl': checked out 'd87062625ed652df9455bd6f60ea89c53515c43a'
Submodule path 'deps/rtosc': checked out '6a65b24469068a8f334567b72a3125bd1d7fd1b1'
Submodule path 'mruby': checked out '7e229c470ae7aa2187b0fe9d3b66ac20943cd2b8'
Submodule path 'src/mruby-qml-parse': checked out '3e2c32cc55c60027e6406eca89bf1ae5301aa16b'
Submodule path 'src/mruby-qml-spawn': checked out 'ff5a0417bb37c72967e1c551c9f39c2e47a2b503'
Submodule path 'src/mruby-zest': checked out '586ef1a92b9805b204365c80f80494904959b5ae'
Submodule path 'src/osc-bridge': checked out '2816cacae0346ba363080b4a352037a06088889c'
error: patch failed: mrbgem.rake:8
error: mrbgem.rake: patch does not apply

Sounds like it's encountering the problem that the pending pull request #39 or #43 address.

Thank you for sending me these, I haven't been able to make much progress with MinGW, but ZLau92's solution may have gotten me past the zest gauntlet on Ubuntu. Now I'm at a similar point from where I had trouble with building for Linux.
/home/gridzydev/Documents/Gits/Zyn-Fusion-win/zyn-fusion-build/zynaddsubfx/src/Misc/MiddleWare.cpp: In function ‘void zyn::preparePadSynth(std::string, zyn::PADnoteParameters*, rtosc::RtData&)’:
/home/gridzydev/Documents/Gits/Zyn-Fusion-win/zyn-fusion-build/zynaddsubfx/src/Misc/MiddleWare.cpp:199:47: error: cannot convert ‘zyn::preparePadSynth(std::string, zyn::PADnoteParameters*, rtosc::RtData&)::<lambda(unsigned int, zyn::PADnoteParameters::Sample&)>’ to ‘zyn::PADnoteParameters::callback’ {aka ‘std::function<void(int, zyn::PADnoteParameters::Sample&&)>’}
  199 |                        }, []{return false;}, 1);
      |                                               ^
In file included from /home/gridzydev/Documents/Gits/Zyn-Fusion-win/zyn-fusion-build/zynaddsubfx/src/Misc/MiddleWare.cpp:44:
/home/gridzydev/Documents/Gits/Zyn-Fusion-win/zyn-fusion-build/zynaddsubfx/src/Misc/../Params/PADnoteParameters.h:193:57: note:   initializing argument 1 of ‘int zyn::PADnoteParameters::sampleGenerator(zyn::PADnoteParameters::callback, std::function<bool()>, unsigned int)’
  193 |         int sampleGenerator(PADnoteParameters::callback cb,
      |                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
make[2]: *** [src/CMakeFiles/zynaddsubfx_core.dir/build.make:540: src/CMakeFiles/zynaddsubfx_core.dir/Misc/MiddleWare.cpp.obj] Error 1
make[1]: *** [CMakeFiles/Makefile2:1334: src/CMakeFiles/zynaddsubfx_core.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
ERROR: 'make' failed

I accidentally managed to get past this point before and successfully build Linux binaries, but I cannot recall how to replicate it. I think I was at about 66% in both cases.

I'm encountering this same issue when I try to build on Windows using MinGW64. I'm somehow able to get past the Zest issues that others have mentioned but this is another roadblock I'm reaching.

Strange, perhaps this is some more strict behavior of a newer version of gcc or something.
I checked the commit logs and the signatures haven't been changed since 2017, but there is a difference between:
void(int, zyn::PADnoteParameters::Sample&) and
void(unsigned, zyn::PADnoteParameters::Sample&)
So I guess changing the definition of PADnoteParameters::callback would suffice.
This should be something that can be verified by building zynaddsubfx/zynaddsubfx directly (or semi-directly if you're part way through a build which also builds up the dependencies).
To the best of my knowledge I don't currently have a version of gcc/clang/etc which triggers this issue though, so I cannot replicate.

OK, some things I found via some experimentation:
The backtrace issue mentioned in #33 still exists in the current repository and impedes the build process before build-package.sh can be executed. However, by using the workaround in #39 the backtrace problem is no longer an issue and the building process can continue to building Zyn. The process, however, abruptly stops according to the issue above but I went ahead and tried building Zest according to build-package.sh which takes place after the building of Zyn and is never reached normally due to the previously mentioned roadblock. After running make windows, the following error manifests and halts the building process:
LD    build/w64/bin/mruby.exe
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.1.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:/msys64/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/build/w64/lib/libmruby.a(gem.o):C:/msys64/home/bep/zyn-fusion-build-master/mruby-zest-build/src/mruby-widget-lib/src/gem.c:293: multiple definition of 'mrb_nvg_context_type'; C:/msys64/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/build/w64/lib/libmruby.a(nvg_context.o):nvg_context.c:(.rdata+0x3e0): first defined here
collect2.exe: error: ld returned 1 exit status
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.1.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:/msys64/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/build/w64/lib/libmruby.a(gem.o):C:/msys64/home/bep/zyn-fusion-build-master/mruby-zest-build/src/mruby-widget-lib/src/gem.c:293: multiple definition of 'mrb_nvg_context_type'; C:/msys64/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/build/w64/lib/libmruby.a(nvg_context.o):nvg_context.c:(.rdata+0x3e0): first defined here
collect2.exe: error: ld returned 1 exit status
rake aborted!
Command failed with status (1): [gcc -L/home/bep/zyn-fusion-build-master/mr...]
/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/lib/mruby/build/command.rb:31:in '_run'
/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/lib/mruby/build/command.rb:36:in 'rescue in _run'
/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/lib/mruby/build/command.rb:32:in '_run'
/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/lib/mruby/build/command.rb:210:in 'run'
/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/rakefile:79:in 'block (4 levels) in <top (required)>'
Caused by:
Command failed with status (1): [gcc -L/home/bep/zyn-fusion-build-master/mr...]
/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/lib/mruby/build/command.rb:33:in '_run'
/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/lib/mruby/build/command.rb:210:in 'run'
/home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/rakefile:79:in 'block (4 levels) in <top (required)>'
Tasks: TOP => default => all => /home/bep/zyn-fusion-build-master/mruby-zest-build/mruby/build/w64/bin/mruby.exe
(See full trace by running task with --trace)
make: *** [Makefile:42: windows] Error 1
This was done in the MinGW64 shell but it doesn't seem to be a Windows exclusive thing since there seems to be some people having a very similar issue with building Zest from the AUR.. So, even if the building of Zyn succeeded, the process would still halt with the building of Zest.

Off-topic (not sure if it'll come up again)

Strange, perhaps this is some more strict behavior of a newer version of gcc or something.
I checked the commit logs and the signatures haven't been changed since 2017, but there is a difference between:
void(int, zyn::PADnoteParameters::Sample&) and
void(unsigned, zyn::PADnoteParameters::Sample&)
So I guess changing the definition of PADnoteParameters::callback would suffice.
This should be something that can be verified by building zynaddsubfx/zynaddsubfx directly (or semi-directly if you're part way through a build which also builds up the dependencies).
To the best of my knowledge I don't currently have a version of gcc/clang/etc which triggers this issue though, so I cannot replicate.

I tried that, but it didn't work out. Later, I changed the & operator to && in Middleware.cpp Ln:193 Col:63. It worked, but I just hope I didn't do anything stupid. 😅

Off-topic (not sure if it'll come up again)

Strange, perhaps this is some more strict behavior of a newer version of gcc or something.
I checked the commit logs and the signatures haven't been changed since 2017, but there is a difference between:
void(int, zyn::PADnoteParameters::Sample&) and
void(unsigned, zyn::PADnoteParameters::Sample&)
So I guess changing the definition of PADnoteParameters::callback would suffice.
This should be something that can be verified by building zynaddsubfx/zynaddsubfx directly (or semi-directly if you're part way through a build which also builds up the dependencies).
To the best of my knowledge I don't currently have a version of gcc/clang/etc which triggers this issue though, so I cannot replicate.

I tried that, but it didn't work out. Later, I changed the & operator to && in Middleware.cpp Ln:193 Col:63. It worked, but I just hope I didn't do anything stupid. 😅

That defenitely makes sense because of commit https://github.com/zynaddsubfx/zynaddsubfx/commit/651c6618255a2f1a7fceeff00d5e7bb849126469, where this change is made in many places but not in the line you changed (forgotten?).

That defenitely makes sense because of commit zynaddsubfx/zynaddsubfx@651c661, where this change is made in many places but not in the line you changed (forgotten?).

Indeed. The error probably wasn't noticed because it happens only on windows as it's inside #ifdef WIN32

@FormulaGX since it looks like you're the first to find the one character diff, do you want to do a PR to get your name attached to the fix? (If not I'm fine applying it now that it's clear what the issue is)

Nah, I'm a bit of a noob with git anyway. I kinda borked my workspace between then and now. Apologies. (^_^;)

The change is now committed.


Set the binary as entrypoint not command

The deployment manifests only specify args which in the UBI image is pointing to bash.
This sets up the entrypoint of the containers correct.

/lgtm


how to tell composer which php.ini file should be used for current project?

Hello, just as the title says, how to tell composer which php.ini-file to use?

PHP loads the ini file(s) from known locations: See https://www.php.net/manual/en/configuration.file.php
To use a different ini file, you can pass its location on the PHP command line, using the -c option:
path/to/php.exe -c path/to/ini path/to/composer.phar

yes i'm aware how php loads its config
ok so composer is just a php-"script" if i understand that correctly, so typing composer in cmd will just do
php path/to/composer.phar

do you know where i can edit this command to add my ini-file?

You can edit the shim scripts in the bin directory:
https://github.com/composer/windows-setup#Install-Locations

ah nice thanks, that was the relevant information ;) works now without warnings


Skype: Copy and Paste Images

I cannot copy any images directly into chat with copy and paste.
I have tried with shortcuts as CTRL + C and CTRL + P , too
Your Environment
Franz Version used: 5.0.0-beta.15
Operating System and version: Windows 10

@marfar00 i tested this behavior in the browser, it is exactly the same as in Franz: copying & pasting images only pastes the image URL, dragging and dropping a (native) file or image uploads correctly.
@adlk skype apparently handles this well (no bugs like with gmail #76, #476, #72, #120, #219 et al) we should look into this


Add connection_name configuration

What does this PR do?
Add connection_name config
Motivation
User request.
This will allow user to provide multiple host/port.
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

/azp run


[AUTOPATCHER-CORE] Upgrade subversion to 1.14.3 Azure Linux 3.0 Upgrades

[AUTOPATCHER-CORE] Upgrade subversion to 1.14.3 Azure Linux 3.0 Upgrades
Upgrade pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=511749&view=results
buddy build -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=511753&view=results

Version checking in progress.


Bug: When a skill consumes the remaining mana, the mana bar disappears

I may have found a bug, if someone can confirm.
It looks like when a mana bar is depleted during a combat, it completely disappears for the duration of the fight. It will appear again at the beginning next combat.
From my point of view, I expected the mana bar to display 0 / 8 for Robi instead of just disappear.

In the HookableManaBar, I found the HIDE_ON_DEPLETED exported variable set to true.
Maybe there is a reason for that?

You're correct, that's the reason. Though, if the desired effect is to hide the manabar when it's depleted, we shouldn't show it again once another encounter starts.


can't delete drained nodes (webui bug?)

v 2.3.0
custom
I just tried to delete a few nodes but 2 are not deleteable, even though they are the same like the others. Delete button is grey and Delete is missing from dropdown menu.
Any ideas?

it's a worker, empty


CIDs may exceed 255 chars

it appears that sometimes CIDs may exceed 255 chars which then will be truncated by the DB.
https://github.com/cloudfoundry-incubator/bosh-vsphere-cpi-release/issues/77

Can this be fixed using a schema migration?

@Lafunamor yup, it could. it would probably involve altering tables to change column type.

Closing and re-opening to trigger a github issue

This issue should not be closed if it's not fixed. Please remove reconfigure the bot to not just auto close all issues.


remove libsuitesparse?

While looking into the failure to set up the test suite because pacopy 0.1.2 couldn't be found #463 , I noticed that the test suite installs libsuitesparse
https://github.com/kinnala/scikit-fem/blob/2f97ce292d892f7ffd7880c2dc2094029513d55f/.travis.yml#L11
Is this vestigial since sksparse.cholmod was removed from ex19 in #447 and replaced with scipy.sparse.linalg.splu #448?

This is actually a good example of what happens when the testing is not isolated from the other packages. If writing tests to scikit-fem, it should only use the functionalities of scikit-fem. Otherwise, tests are going to break sooner or later, even without touching the code. Highly undesirable behavior in the mind of someone who has repeatedly corrected hundreds of tests. This is something that we have been doing and learning during JuliaFEM project.

Interesting comment, thank you.
I'm not sure.  You write as though tests breaking is a bad thing, but aren't they the canaries in the coalmine?  Breaking tests only slows the acceptance of new code.  Breaking tests are to be preferred over breakages in the field, breakages in downstream packages, or errors in end-users' finite element analyses.
Also when tests break, here, it usually doesn't mean correcting the tests, it means correcting the code.  More often than not, with the tests in question here, that code is not scikit-fem code.   The tests in question (mostly tests/test_examples.py) are integration tests or system tests.  I think these serve a very important role beside the unit tests and validation tests in the other subdirectories of tests.
Yes, tests are going to break sooner or later, even without touching the code, when some upstream package changes.  This has already happened more than once with meshio, but this is an important dependency not of scikit-fem's core but of an important subset of users and potential users of scikit-fem; meshio is relied upon for input and output of all but the simplest problems.  meshio has many competing demands on it and evolves in ways that are beyond our control, so it's helpful for us to know as soon as possible when a change in meshio breaks representatively complete finite element analyses using scikit-fem as finite element library.
We could pin old versions of dependencies, but that would mean missing out on upstream bug fixes and new features, both of which are frequent in meshio, in particular.  Would this introduce the problem that there would be a new task of periodically testing when the pin could be updated?
I can see a case for separating tests that isolate scikit-fem from other packages and integration and system tests, but were the latter removed, I think I'd have to set them up independently, and run them regularly myself.  This would have the big disadvantage that it would be removed from the continuous integration workflow, so a change could be inadvertantly introduced into scikit-fem that broke its interaction with one of the select dependencies exercised in the integration and system tests.  That doesn't sound convenient.
Those are my thoughts, but it sounds like you have more experience in this kind of thing.  Am I on the wrong track?  I haven't looked at JuliaFEM, so don't know how well it is integrated into or isolated from its ecosystem (does it handle its own geometry, meshing, input, output, solvers, preconditioners, graphics, logging, &c., &c.); scikit-fem was designed to focus on assembly and leave the auxiliaries to the flourishing ecosystem.


Features/kind cleanup

James, I m gonna just merge right now, and then go over everything with a major cleanup.


Edit Single Data Entry

Provide the ability to manually add a single smoking data entry.
Provide the ability to manually edit a single smoking data entry.

Removed the 'add' feature as it highly overlaps with other functions. The primary goal is to record one's behavior and habits, reducing issues when reviewing retrospectively. Hence, we now focus on the present and the future, so this function only supports modifications now.

Done


Rails 5 compatibility

A bunch of stuff required for Rails 5 compatibility.
Best reviewed on a commit-by-commit basis.

guidance-guarantee-programme-rails5 branch pushed to origin in order to run tests

✨ 🌟 ⭐ 👍 ⭐ 🌟 ✨

💟 Thanks 💟

😍


'unknown error: no such logical database \x02employees'

What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

Start server refer this PR comment: #90 .
Connect the server with mycli: mycli -h<IP_ADDRESS> -P13306 -udksl employees -p123456
show databases;  is OK.
use employees; is OK.
show tables; is not OK.  error message: (1105, 'unknown error: no such logical database \x02employees')

Yup, that is a bug, confirmed. Will be fixed soon.


Verify with additional certificates in addition to system certificates

Allow passing additional certificates via SSLContext.load_verify_locations(). Only load system certificates when SSLContext.load_default_certs() is used.

On Windows, by default CertVerifyCertificateChainPolicy uses a default "chain engine" which only trusts root certs from system cert stores (https://docs.microsoft.com/en-us/windows/win32/seccrypto/certificate-chains has a bit more info on this). So far I think I've found 2 ways we could also trust additional roots loaded with load_verify_locations:

After constructing a cert chain with CertGetCertificateChain, check whether the chain's root cert matches any of the certs that have been loaded with load_verify_locations. If so, include CERT_CHAIN_POLICY_ALLOW_UNKNOWN_CA_FLAG in the dwFlags of the CERT_POLICY_PARA structure passed to CertVerifyCertificateChainPolicy so that it won't complain about the root cert that is not trusted by Windows. I believe this approach is also used by oscrypto

It looks like it's possible to use CertCreateCertificateChainEngine to create a custom chain engine with a CERT_CHAIN_ENGINE_CONFIG that uses hExclusiveRoot to only trust CA certs from a store we give it. But it doesn't look like it's possible to create one that will trust both the hExclusiveRoot store and the default system stores (though I could certainly be overlooking something). So we might need to call CertCreateCertificateChain and CertVerifyCertificateChainPolicy twice, once with the default chain engine and once with a custom one, and consider the server certs verified as long as they didn't both fail.

@davisagli I started a thread on Twitter about potential solutions and received lots of great discussion: https://twitter.com/sethmlarson/status/1510630808524103689
Basically confirms that there is no "easy" way to accomplish this, the typical flow is either custom trust anchors or system ones.

In Go if additional trusted roots have been configured (opts.Roots in the diff I'm about to link), then it first tries to verify using the system APIs (i.e. without considering the additional roots), then if that fails it tries to verify using Go's own verifier which takes the additional trusted roots into consideration. https://github.com/golang/go/commit/3544082f75fd3d2df7af237ed9aef3ddd499ab9c
We could do something similar by first attempting the platform-specific verification code, then falling back to OpenSSL if load_verify_locations has been called.

@davisagli That seems like a great way to proceed, especially for now :)

However, is there a way to do a certificate verification in Python without a handshake? We might need a binary extension to do it this way?

I think you're right that there is not (seems to be built in to how the OpenSSL APIs are structured). So for now I drafted a solution using the 2nd approach I listed above (fallback to custom chain engine) in #36


Test VID Fusion

There is a new VINS with rotos' dynamic called VID-Fusion. Do you plan to test this new one?

Wow. Thank you for suggestion @dssdyx .
However, sadly I am not planning to purchase optical encoder nor hall sensor for measuring the rotor thrust of drones.
If you find some other algorithms to recommend, please tell me!
Thank you.
Eungchang Lee.

Wow. Thank you for suggestion @dssdyx . However, sadly I am not planning to purchase optical encoder nor hall sensor for measuring the rotor thrust of drones.
If you find some other algorithms to recommend, please tell me! Thank you. Eungchang Lee.

OK


Update set-up-your-development-environment.md

The latest version is 1.14.0 (not 1.14.1)
Category

[X] Content fix

Docs Build status updates of commit e27b19d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/set-up-your-development-environment.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


CLI update

This updates the CLI interface to include the new VI algorithm.
Note that we are dropping the requirement to specify a prior for now -- all prior are now centered around 0 with variance 1.
We also changed the subsampling procedure - 1 sample corresponds to a batch size of 1.
Continues #45

[ ] fix broken unittests, since there has been some refactoring done.

Closing. Will readdress at a later date


[$500] [Scan/Receipt] User is able to enable flash while permission is not granted

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click plus button => Request Money => Scan
While permission is not granted, click Flash button
Notice that Flash button is enable while permission is not granted

Expected Result:
Flash button should disable if there's no permission granted
Actual Result:
User is able to enable flash while permission is not granted
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.70-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/430eee1e-ff5c-4662-86f1-d5b6e742dc23
https://github.com/Expensify/App/assets/78819774/ab8ca03d-a3cc-4aed-9d78-ba82a7a574ec
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694579188856809
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013af8889a83bae302
Upwork Job ID:<PHONE_NUMBER>960399360
Last Price Increase: 2023-09-22

@abdulrahuman5196 what do you think about these proposals?

TAL now

@jjcoffee reaasigning, can you please take a look at the proposals above? thanks

@hungvu193's proposal LGTM! I think my preference is for an error message, as disabling the button may not be that obvious visually (or we could do both!). I don't know if we might need to seek some broader feedback on the expected behaviour here? @laurenreidexpensify
:ribbon::eyes::ribbon: C+ reviewed

Chatted with @dylanexpensify and we agreed that we should just disable the button without throwing any error message. Does that change your choice of proposal @abdulrahuman5196?

It seems @jjcoffee  has been re-assigned this issue to review.

@puneetlath We're good to stick with @hungvu193's proposal (they proposed first via Slack as the issue reporter).

Damn looks like the automation failed here!

The PR that introduced the bug has been identified. Link to the PR: N/A - behaviour was always there
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - just required more thorough testing
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test proposal

Go to FAB -> Request Money -> Scan
Deny permissions request
Verify that the flash button is disabled and pressing it does not do anything
Do we agree 👍 or 👎

@puneetlath The PR for this hit production a couple weeks ago so this is ready for payment (the automation just failed). Thanks!

Ah cool. @laurenreidexpensify mind handling that? Thanks!

@laurenreidexpensify Gentle bump on payment for this :bow:

Sorry everyone I completely missed this when the automation failed. Looking now

Payment Summary

Bug reporter @hungvu193 $50 - payment issued in Upwork
Contributor - @hungvu193 $500 - payment issued in Upwork
C+ @jjcoffee $500 - payment issue in Upwork

@laurenreidexpensify I think this issue is eligible for urgency bonus, It was approved and merged within 3 days. cc @jjcoffee

@hungvu193 If you post timestamps it helps to verify - IIRC this one was right on the edge.

Yeah, I was assigned on Oct 2, 11:05 PM and the PR was approved on Oct 5, 1:18 AM. So I believe this is still within 3 days.

@hungvu193 The bonus usually applies for time to merge rather than to C+ approval. The merge happened 52 minutes too late - sometimes this is taken into account, but it's up to the BZ. cc @laurenreidexpensify :sweat_smile:

@hungvu193 The bonus usually applies for time to merge rather than to C+ approval. The merge happened 52 minutes too late - sometimes this is taken into account, but it's up to the BZ. cc @laurenreidexpensify :sweat_smile:

I remembered we talked about this cassette before and the bonus will be applied for C+ approval time if there was no requested change after that, which is this cassette 😄


Add a binding to CGFontGetUnitsPerEm()

Pathfinder 2 is using this. It saves a little bit of time and memory by avoiding creation of CTFont objects just to do this simple query.
r? @jdm

This change is

:pushpin: Commit b11b04d has been approved by emilio

@bors-servo r+

:hourglass: Testing commit b11b04db2ee12bbdfc89c7a8947098410e804144 with merge de898c8ee98ae5561cafec452e043bbb63824f74...

:sunny: Test successful - status-travis
Approved by: emilio
Pushing de898c8ee98ae5561cafec452e043bbb63824f74 to master...


Add AngularJS Testing Blog Post

Did you want to paste the entire post here as well, or just an intro blurb like the first couple of paragraphs?

:shipit:


Add additional Launch App button, Update readme

Added an additional Launch App button
And added development info to the readme.md

Hi sorry for slow response, please fix the merge conflicts so i can run your changes and take a look, thanks

@LeonmanRolls Thanks Leon. Imo a complete site redesign might make more sense at this point.

@seichris Yes this is in the works!


Texts become messy when scrolled up after scrolling down a bit using tmux.

See the following image:

Without tmux it is fine.(is this tmux issue?)
A bit irritating.
I am using termite.
rtv is installed from official repo of manjaro using pacman. rtv version is rtv 1.24.0.
echo $TERM spits xterm-termite inside tmux.

Yes this is a tmux issue, see the tmux FAQ. In short, you shouldn't be overriding your TERM to xterm-termite when running inside tmux. There's no way to fix this in RTV (that I've found), without breaking other, valid terminal configurations.

Okay. No need to keep this issue opened.


Support DRAND in Sui

Primitives in Move and an example smart contract (not std, not just a test) for DRAND itself. Ie how the smart contract should record the DRAND committee key (a basic description that DRAND key is not rotated), ensure BLS signature non-malleability, and recommendations re how to properly use of DRAND if we don't report a few rounds (ie DRAND is not supporting history regeneration as STROBE does, do we need to record every beacon on chain or there is any light client option to get the latest? Maybe we can support a function that takes as input multiple older beacons and chain it until we reach the most recent round?

Implemented already in https://github.com/MystenLabs/sui/blob/main/sui_programmability/examples/games/sources/drand_lib.move
and we have examples in https://github.com/MystenLabs/sui/tree/main/sui_programmability/examples/games/sources


use estree-walker to properly parse es6 and added new tests.

Use estree-walker to handle arrow functions. Also added unit tests for it.

Thank you very much! This is great.


Bind listener property to listen at all hosts

Bind listener property to listen at all hosts

:+1:

:+1:


movie just stops playing after some minutes

I run kodi on a s905 with 1gb. Unfortunately, your plugin stops playing after some time, the video just quits and I'm back in the menu of elementum. I changed to option to store the torrent file in as file on an external usb stick but the same thing happens.
Any idea what I could do?

20:49:07.682 T:3508532112   ERROR: ffmpeg[D11FF390]: [mov,mp4,m4a,3gp,3g2,mj2] stream 0, offset 0x680046b: partial file
20:49:07.685 T:3508532112   DEBUG: CVideoPlayer::SetCaching - caching state 0 clock:626.302 start pts:616.616
20:49:07.685 T:3508532112   DEBUG: CDVDClock::SetSpeedAdjust - adjusted:0.000000
20:49:07.685 T:3508532112  NOTICE: CVideoPlayer::OnExit()
20:49:07.685 T:3508532112  NOTICE: VideoPlayer: eof, waiting for queues to empty
20:49:07.685 T:3508532112  NOTICE: Closing stream player 1
20:49:07.686 T:3508532112  NOTICE: Waiting for audio thread to exit
20:49:07.686 T:3935691664   DEBUG: CDVDAudio::Resume - resume audio stream
20:49:07.686 T:3935691664  NOTICE: thread end: CVideoPlayerAudio::OnExit()
20:49:07.686 T:3508532112  NOTICE: Closing audio device
20:49:07.686 T:3935691664   DEBUG: Thread VideoPlayerAudio<PHONE_NUMBER> terminating
20:49:07.708 T:3508532112   DEBUG: CDVDAudio::Flush - flush audio stream
20:49:07.708 T:4064355216   DEBUG: CActiveAE::DiscardStream - audio stream deleted
20:49:07.708 T:4064355216   DEBUG: CActiveAE::ClearDiscardedBuffers - buffer pool deleted
20:49:07.708 T:3508532112   DEBUG: Previous line repeats 2 times.
20:49:07.708 T:3508532112  NOTICE: Deleting audio codec
20:49:07.709 T:3508532112  NOTICE: Closing stream player 2
20:49:07.709 T:3508532112  NOTICE: waiting for video thread to exit
20:49:07.715 T:3417093008   DEBUG: CVideoPlayerVideo::OutputPicture - ttd:866ms pts:627.168 Clock:626.302 Level:-1 elapsed:63.068ms
20:49:07.715 T:3417093008  NOTICE: thread end: video_thread
20:49:07.715 T:3508532112  NOTICE: deleting video codec
20:49:07.715 T:3417093008   DEBUG: Thread VideoPlayerVideo<PHONE_NUMBER> terminating
20:49:07.715 T:3508532112   DEBUG: CAMLCodec::CloseDecoder

The log chunk is a no helper. Can you post a full log, so I can see what happens?

Sorry, sure here it is.
https://mega.nz/#!HtpmWYBC!Kg9QWpmEUM2UNHHWhtsThR1p-_di6akBjxXD0TSJaMc

@elgatito Do you need further information? I'm happy to help.

I performed some test and what I can tell is that it crashes faster the higher the resolution of the movie.

I am reviewing your issue, thanks for the log.

Can you try the latest version?

Just tried.
Torrent in memory: video stops like described before.
https://mega.nz/#!fxwEGBbY!vYMzhrwHmc2E1xfdhKi_qAVANEhTdmAfpMI92E-vd8w
Torrent in file: video stops like described before.
https://mega.nz/#!D9w0CQYA!IvLZtovlB5GaVHe8ne1pAhJKFFr7BqvWC7U82hzcin8
In general if I start watching 2 videos after each other elementum is eating all the memory until the box dies.

Can't open first file, it looks like a binary.

Seems the first part of the file is binary. The rest should be readable. Can I provide further things to help?

I can't open that log.
Don't use fat32 storage. Use file storage, not mmap or fat32.
For memory storage don't use more than 100mb for 1gb devices.

https://mega.nz/#!6lQyzbxD!w1NGD45aDejbArI8MuCDBRjfGD7JLDRdsAYPTCXFXMg
Does this work?
I used memory <=100mb. I also tried 50mb but same result.

Had the same issue with the latest version. Here is the log file https://drive.google.com/open?id=1GWvj7xHcafOZUUNS0gx2s2eH95XtJ2z6


Fix a few typos and small problems on the code search cheat sheet page

I was just reading the page to learn about the search syntax, spotted a few problems, and decided to fix them to improve this page.
For the types, I used https://docs.sourcegraph.com/code_search/reference/queries as a source.
Type of change
Typo fixes.
What should this PR do?
There's no related Asana or Jira issue. These are random minor fixes to a page content, not requested by anyone.
Why are we making this change?
I intend to improve this page.
What are the acceptance criteria?
The page should not look broken. The content should be better than it was before the change.
How should this PR be tested?

Check out the GitHub diff (I think the two-column view is best for this), see if you spot any typos in my version.
If there's a test environment to run this branch then go to that environment, scroll through the page and see the new content, and make sure it looks good.

Pull request process
Reviewers:

Test functionality using the criteria above.
Offer tips for efficiency, feedback on best practices, and possible alternative approaches and things that may not have been considered.
For shorter, "quick" PRs, use your best judgement on #2.
Use a collaborative approach and provide resources and/or context where appropriate.
Provide screenshots/grabs where appropriate to show findings during review.

Reviewees:

Prefer incremental and appropriately-scoped changes.
Leave a comment on things you want explicit feedback on.
Respond clearly to comments and questions.

Thank you, @ltagliaferri!
After creating the PR, I realized you were not with Sourcegraph anymore.
So, special thanks for jumping in! :)


MergingSortedBlockInputStream return wrong result randomly.

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)

Run the unit test SpillSortTestRunner.SimpleCase in #6609 multiple times, and the test will failed randomly.
Note the failure is not related to Spiller since I hacked the spiller to just save the spilled blocks in the memory during spill stage, and when restore the spilled data, the spiller will return the same blocks saved before.
2. What did you expect to see? (Required)
3. What did you see instead (Required)
4. What is your TiFlash version? (Required)

It turns out the root cause is currently, DAGRequest does not support final TopN, so after compile, the pipeline looks like this:
Union: <for test>
 Expression x 8: <final projection>
  SharedQuery: <restore concurrency>
   MergeSorting, limit = 20480
    Union: <for partial order>
     PartialSorting x 8: limit = 20480
      MockTableScan

So after MergeSorting, the data is expanded by SharedQuery, so there is no order guarantee at all.


chore: debug delete table permission issue in bigframes-load-testing

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Duplicate of https://github.com/googleapis/python-bigquery-dataframes/pull/1090, there was an apparently transient cloning issue in kokoro so I created this suplicate PR to repro that.


[iOS] Virtualized List does not render when moving from initially offscreen to onscreen

[x] I have reviewed the documentation
[x] I have searched existing issues
[x] I am using the latest React Native version

Issue occurs only on iOS.
When a VirtualizedList inside of a parent ScrollView is initially rendered off-screen, then some other part of the UI changes such that the VirtualizedList becomes on-screen WITHOUT a user scrolling to it, the contents of the list fail to render.  See example code below.
Note that if the top-level component is a ScrollView, the list can be made to render by scrolling anywhere on that ScrollView, including inside of the list itself.  If the top-level component is NOT a ScrollView, this problem DOES NOT OCCUR.
Environment
Environment:
OS: macOS High Sierra 10.13.4
Node: 9.4.0
Yarn: 1.3.2
npm: 5.6.0
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 2.3 AI-162.3764568
Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: 0.55.2 => 0.55.2
Also reproducible in Expo on their Snack web interface as of today's date (21 May, 2018).
Steps to Reproduce
Render a UI with a View of height at least equal to the height of the screen (to later either shrink or be removed) and a VirtualizedList after it.  Shrink or remove that View.
Expected Behavior
The VirtualizedList should present its contents appropriately for its given parameters.
Actual Behavior
The VirtualizedList is not rendering any contents.
Example Code
https://snack.expo.io/rk_aQYgyX
import React, { Component } from 'react';
import { Text, View, StyleSheet, VirtualizedList, Button, ScrollView } from 'react-native';
import { Constants } from 'expo';

export default class App extends Component {
  constructor(props) {
    super(props);
    this.state = {
      expanded: true
    }
  }

  renderItem = ({item}) => {
    return (
      <View>
        <Text>{item.label}</Text>
      </View>
    );
  };

  render() {
    const spacerStyle = {
      backgroundColor: 'cyan',
      height: this.state.expanded ? 1000 : 100
    };
    const data = Array(100).fill({ label: 'I am the best', key: Math.random * 1000 });
    return (
      <ScrollView style={styles.container}>
        <Text style={styles.paragraph}>
          Tap the button to expand the View below this guy.
        </Text>
        <Button title={'Tap me!'} onPress={() => this.setState({expanded: !this.state.expanded})} />
        <View style={spacerStyle} />
        <View style={{maxHeight: 200}}>
          <VirtualizedList
            data={data}
            getItem={(data, index) => data[index]}
            getItemCount={() => data.length}
            renderItem={this.renderItem}
            windowSize={11}
            removeClippedSubviews={true}
            initialNumberToRender={20}
            bounces={false}
            keyExtractor={(item) => item.key}
          />
        </View>
      </ScrollView>
    );
  }
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    paddingTop: Constants.statusBarHeight,
    backgroundColor: '#ecf0f1',
  },
  paragraph: {
    margin: 24,
    fontSize: 18,
    fontWeight: 'bold',
    textAlign: 'center',
    color: '#34495e',
  },
});

Note that this problem is also resolved by setting removeClippedSubviews to false, but that largely defeats the purpose of virtualizing the list rather than just using a regular ScrollView.


Avoid materializing, more concrete types

This PR avoids materializing and more concrete types. It also changes our perf measurements to use the ByPassLogger, so that we avoid performance hits from using the logger.
We're down to ~20μs/game with this PR.

bors r+


DO-NOT-MERGE testing RHTAP

Closing this PR as the repo has migrate to https://github.com/konflux-ci/sprayproxy


Not able download from Vimeo

./youtube-dl https://vimeo.com/21063795 --verbose
[debug] System config: [u'--prefer-free-formats']
[debug] User config: []
[debug] Command-line args: [u'https://vimeo.com/21063795', u'--verbose']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.05.10
[debug] Python version 2.7.5 - Linux-3.19.8-100.fc20.x86_64-x86_64-with-fedora-20-Heisenbug
[debug] exe versions: ffmpeg 2.1.8, ffprobe 2.1.8
[debug] Proxy map: {}
[vimeo] 21063795: Downloading webpage
[vimeo] 21063795: Extracting information
ERROR: Unable to extract info section (caused by RegexNotFoundError(u'Unable to extract \x1b[0;34minfo section\x1b[0m; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/vimeo.py", line 275, in _real_extract
flags=re.DOTALL)
File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 555, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract info section; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/youtube_dl/YoutubeDL.py", line 650, in extract_info
ie_result = ie.extract(url)
File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/common.py", line 273, in extract
return self._real_extract(url)
File "/usr/lib/python2.7/site-packages/youtube_dl/extractor/vimeo.py", line 289, in _real_extract
cause=e)
ExtractorError: Unable to extract info section (caused by RegexNotFoundError(u'Unable to extract \x1b[0;34minfo section\x1b[0m; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

You are using an outdated version of youtube-dl. Read our FAQ if you have troubles updating.


CI - docker build (and publish) failing

Hello! 👋
I noticed that you were using GitHub Container Registry from this PR from @thim81 - https://github.com/apideck-libraries/postman-to-k6/pull/91
But I noticed that there are zero packages published - https://github.com/orgs/apideck-libraries/packages?repo_name=postman-to-k6
So I went and looked at the Actions (CI) and saw https://github.com/apideck-libraries/postman-to-k6/actions/runs/4133989496
buildx failed with: ERROR: failed to solve: executor failed running [/bin/sh -c npm install --production]: exit code: 127

Thanks for considering! Have a wonderful day!

https://github.com/apideck-libraries/postman-to-k6/pull/114

hi @mccurdyc
Thanks for the PR, I approved it and is merged.
It will be part of the next release.

hi @mccurdyc
We just released version 1.8.9, which includes your Docker PR.
Can you let me know, if the Docker is behaving as expected, and close the issue if it is OK.


Packages are not getting recognized

Hello,
the integration doesn't seem to find my Packages in my mails.
I tried the new Beta 0.3.5-b21 and the stable version 0.3.4-2 without any success.
I live in Germany and received multiple packages from DHL the past days.
The const.py matches the email, subject, and body to find the email but it doesn't find it.
The logs tell me that he seems to find an email, but cant match it with the const.py(if I understand the logs correct).
The last line of the shared logs should definitely find a mail...
Logs:
2023-01-03 04:02:06.335 DEBUG (SyncWorker_3) [custom_components.mail_and_packages.helpers] Search for<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (DHL On Demand Delivery) results: b'' count: 0
2023-01-03 04:02:06.336 DEBUG (SyncWorker_3) [custom_components.mail_and_packages.helpers] Attempting to find mail from<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Ihr DHL Paket kommt heute)
2023-01-03 04:02:06.336 DEBUG (SyncWorker_3) [custom_components.mail_and_packages.helpers] DEBUG subject: Ihr DHL Paket kommt heute
2023-01-03 04:02:06.336 DEBUG (SyncWorker_3) [custom_components.mail_and_packages.helpers] DEBUG imap_search: (OR OR OR FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>SUBJECT "Ihr DHL Paket kommt heute" SINCE 03-Jan-2023)
2023-01-03 04:02:06.538 DEBUG (SyncWorker_3) [custom_components.mail_and_packages.helpers] DEBUG email_search value: ('OK', [b''])
2023-01-03 04:02:06.538 DEBUG (SyncWorker_3) [custom_components.mail_and_packages.helpers] Searching for (scheduled for delivery TODAY) in (1) emails
2023-01-03 04:02:06.538 DEBUG (SyncWorker_3) [custom_components.mail_and_packages.helpers] Search for (scheduled for delivery TODAY) count results: 0
2023-01-03 04:02:06.539 DEBUG (SyncWorker_3) [custom_components.mail_and_packages.helpers] Search for<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Ihr DHL Paket kommt heute) results: b'' count: 0

2023-01-03 04:02:06.538 DEBUG (SyncWorker_3) [custom_components.mail_and_packages.helpers] DEBUG email_search value: ('OK', [b''])

0 results from the search query.

Yeah i see that... But what could be the issue? There is definetly a Email that matches but he cant find it.

No issue, there's just no matches.

How is that not a match?

You IMAP server stated it wasn't a match for some reason.

I have just deleted some filters on my email account(which doesnt filter these emails) and something changed but still not result.
2023-01-03 14:55:25.534 DEBUG (SyncWorker_5) [custom_components.mail_and_packages.helpers] Search for<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Ihr DHL Paket kommt heute) results: b'499' count: 0
Can u tell me what "results: b'499'" means?

that would be the message number

What message number?

It's the message number of the email matching the search parameters.

How is that not a match?

The screenshot shows the Reply To is<EMAIL_ADDRESS>Only the From field is searched for addresses. What is the From email address? The screenshot only shows the display name DHL Paket.

@firstof9 Ok now im confused, he finds it but dont count it?
@moralmunky Yeah thats confusing, but its still<EMAIL_ADDRESS>

@firstof9 Ok now im confused, he finds it but dont count it?
@moralmunky That is confusing, i dont know why he hides is but it is still<EMAIL_ADDRESS>

Ok now im confused, he finds it but dont count it?

Not sure, which version are you running currently?
What's the rest of the debug log look like?

Currently i am running on the beta "0.3.5-b21".
Im not sure how much of the log is usefull for you, because it is logging quite a lot:
2023-01-03 15:30:33.323 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Attempting to find mail from<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (DHL On Demand Delivery)
2023-01-03 15:30:33.324 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG subject: DHL On Demand Delivery
2023-01-03 15:30:33.324 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG imap_search: (OR OR OR FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>SUBJECT "DHL On Demand Delivery" SINCE 03-Jan-2023)
2023-01-03 15:30:33.388 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG email_search value: ('OK', [b''])
2023-01-03 15:30:33.388 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Searching for (has been delivered) in (1) emails
2023-01-03 15:30:33.388 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Search for (has been delivered) count results: 0
2023-01-03 15:30:33.389 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Search for<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (DHL On Demand Delivery) results: b'' count: 0
2023-01-03 15:30:33.389 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Attempting to find mail from<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Powiadomienie o przesyłce)
2023-01-03 15:30:33.389 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG subject: Powiadomienie o przesyłce
2023-01-03 15:30:33.389 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG imap_search: SINCE 03-Jan-2023 SUBJECT
2023-01-03 15:30:33.389 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] UTF-8 not supported: command ENABLE illegal in state SELECTED, only allowed in states AUTH
2023-01-03 15:30:33.390 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG email_search value: ('BAD', 'command ENABLE illegal in state SELECTED, only allowed in states AUTH')
2023-01-03 15:30:33.390 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Attempting to find mail from<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Ihr DHL Paket wurde zugestellt)
2023-01-03 15:30:33.390 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG subject: Ihr DHL Paket wurde zugestellt
2023-01-03 15:30:33.390 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG imap_search: (OR OR OR FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>SUBJECT "Ihr DHL Paket wurde zugestellt" SINCE 03-Jan-2023)
2023-01-03 15:30:33.448 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG email_search value: ('OK', [b''])
2023-01-03 15:30:33.449 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Searching for (has been delivered) in (1) emails
2023-01-03 15:30:33.449 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Search for (has been delivered) count results: 0
2023-01-03 15:30:33.449 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Search for<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Ihr DHL Paket wurde zugestellt) results: b'' count: 0
2023-01-03 15:30:33.449 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Sensor: dhl_delivered Count: 0
2023-01-03 15:30:33.450 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Attempting to find mail from<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (DHL On Demand Delivery)
2023-01-03 15:30:33.450 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG subject: DHL On Demand Delivery
2023-01-03 15:30:33.450 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG imap_search: (OR OR OR FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>SUBJECT "DHL On Demand Delivery" SINCE 03-Jan-2023)
2023-01-03 15:30:33.510 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG email_search value: ('OK', [b''])
2023-01-03 15:30:33.510 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Searching for (scheduled for delivery TODAY) in (1) emails
2023-01-03 15:30:33.511 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Search for (scheduled for delivery TODAY) count results: 0
2023-01-03 15:30:33.511 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Search for<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (DHL On Demand Delivery) results: b'' count: 0
2023-01-03 15:30:33.511 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Attempting to find mail from<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Ihr DHL Paket kommt heute)
2023-01-03 15:30:33.511 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG subject: Ihr DHL Paket kommt heute
2023-01-03 15:30:33.512 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG imap_search: (OR OR OR FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>SUBJECT "Ihr DHL Paket kommt heute" SINCE 03-Jan-2023)
2023-01-03 15:30:33.572 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG email_search value: ('OK', [b'499'])
2023-01-03 15:30:33.572 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Searching for (scheduled for delivery TODAY) in (1) emails
2023-01-03 15:30:33.628 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Content type: multipart/signed
2023-01-03 15:30:33.628 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Content type: text/html
2023-01-03 15:30:33.629 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Content type: application/pkcs7-signature
2023-01-03 15:30:33.629 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Search for (scheduled for delivery TODAY) count results: 0
2023-01-03 15:30:33.630 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Search for<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Ihr DHL Paket kommt heute) results: b'499' count: 0
2023-01-03 15:30:33.630 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Attempting to find mail from<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Powiadomienie o przesyłce)
2023-01-03 15:30:33.630 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG subject: Powiadomienie o przesyłce
2023-01-03 15:30:33.630 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG imap_search: SINCE 03-Jan-2023 SUBJECT
2023-01-03 15:30:33.630 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] UTF-8 not supported: command ENABLE illegal in state SELECTED, only allowed in states AUTH
2023-01-03 15:30:33.631 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG email_search value: ('BAD', 'command ENABLE illegal in state SELECTED, only allowed in states AUTH')
2023-01-03 15:30:33.631 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Attempting to find mail from<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Ihr DHL Paket kommt bald)
2023-01-03 15:30:33.631 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG subject: Ihr DHL Paket kommt bald
2023-01-03 15:30:33.631 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG imap_search: (OR OR OR FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>FROM<EMAIL_ADDRESS>SUBJECT "Ihr DHL Paket kommt bald" SINCE 03-Jan-2023)
2023-01-03 15:30:33.687 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] DEBUG email_search value: ('OK', [b''])
2023-01-03 15:30:33.687 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Searching for (scheduled for delivery TODAY) in (1) emails
2023-01-03 15:30:33.687 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Search for (scheduled for delivery TODAY) count results: 0
2023-01-03 15:30:33.688 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Search for<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Ihr DHL Paket kommt bald) results: b'' count: 0
2023-01-03 15:30:33.688 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Sensor: dhl_delivering Count: 0
2023-01-03 15:30:33.688 DEBUG (SyncWorker_16) [custom_components.mail_and_packages.helpers] Sensor: dhl_packages Count: 0

0.3.4-b25 should work properly for you. Let me know.

Yes works, thank you!
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>with subject (Ihr DHL Paket kommt heute) results: b'499' count: 1


Continuation externalising cmdline

@bryphe @Bretley  following my comment in #1127, I've cleaned up the merge conflicts, so we can bring in the changes you made to externalize the cmdline,
just to note that the primary ongoing issue I can see is the lack of a proper cursor, at the moment I've tweaked the component to be an input and force focus so it seems like its cursor responds to input but actually this is controlled by redux so the cursor doesn't behave properly.
EDIT: @Bretley I can also make this PR to your branch if you'd prefer to merge it in then we merge in the original.

I'm good to bring this in - as you mentioned I don't want it to get lost in a sea of merge conflicts. Thanks for bringing it up-to-date @Akin909 , and thanks @samvv and @Bretley for your work on this! I'll bring this in now and merge #1175 with it tomorrow.

Sorry I've been AWOL since finals and visiting family, things have gotten busy as there's been an unexpected death recently in my family. I've got no objections to you fixing my initial work up; I'm not going to continue it. Keep up the great work folks

Sorry I've been AWOL since finals and visiting family, things have gotten busy as there's been an unexpected death recently in my family.

Sorry to hear that 😦 Hope everything is okay!

I've got no objections to you fixing my initial work up; I'm not going to continue it.

Thanks for getting us started here!


Use 404 page for not existing items

There is a dedicated "404 - Page not found." webpage, if you use a wrong URL that does not exist on the base-URI of marketplace, e.g. https://marketplace.sshopencloud.eu/i-dont-exist
This webpage does not show up, if you have a wrong (or not longer working) URL of one of the items (resp. within the namespace of the items), e.g. try out https://marketplace.sshopencloud.eu/tool-or-service/i-dont-exist. There you get the error message "Something went wrong". Looking into the network analysis I see a 404 returned by backend.
I think it is better to also show the dedicated"404 - Page not found" for not existing items. @laureD19 @stefanprobst do you agree?

yes, agreed


Bump api-schema-builder with readOnly and writeOnly support

Coverage remained the same at 99.115% when pulling abbc2d4142ad85d36397e77dd0a7da90453a828a on bump-api-schema-builder into d0a4ec150565d093dab45e0a53f9f52e84ffb208 on master.


Update server bilibili

Please update server bilibili

Please do sometging about update its doesn't update on its own


delete authPassword namespace of emailconfig

Signed-off-by: wanjunlei<EMAIL_ADDRESS>

/assign @FeynmanZhou


Add information about how to handle write errors

Originally: https://github.com/influxdb/influxdb.com/issues/100
See this thread: https://twitter.com/tisba/status/618416895272845312

A good thing to revisit for 1.0, but no one seems to be needing it lately.

The lack of documentation concerning idempotence of writes is still confusing. Googling something like "influxdb write idempotent" gives no helpful results. If I write the same exact data point (with the same timestamp) twice, what happens? Does influxdb make any guarantee about this?


Fix NPE in the constructor of TopNQuery

Description
This PR fixes a bug in the constructor of TopNQuery class.
In the constructor, dimensionSpec is accessed to construct postAggregatorSpecs object before the null check of itself, which results in NPE.
This PR fixes this bug by moving all argument checking code to the begin of the constructor.

This PR has:

[X] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

I found this bug in my test cluster, so there should be no tests cover this edge case. I will add a unit test.


Download binary regardless cargo existed or not

Is your feature request related to a problem? Please describe.
Currently, clap takes too much disk space because build maple cost me around 460MB.
function! clap#installer#install(try_download) abort
  " Always prefer to compile it locally.
  if executable('cargo')
    call clap#installer#build_all()

The code shows that if cargo installed, there is no option to download the prebuild.
Describe the solution you'd like
An option to download package directly.  Specially for the user have cargo installed.

Use:
Plug 'liuchengxu/vim-clap', { 'do': { -> clap#installer#force_download() } }


Feature/pass id thru

I have complete the passing of the student id that is scanned or typed in so that through out the whole process the YDP and student will know which user who information is being recorded. It is passed through fwd and bkwd so if a selection is e YDP and student will know which user who information
made accidently it student can go back and not have to start all over from the scan.

Super job Pat!! Great job figuring this out. There is an issue in that there are two versions of the success page? I see the older one I made last week (pages/SuccessPage/Success.js ) which I discarded and the recent one I pushed ( src/components/pages/Success/Success.js) yesterday.

I just sent it to both so either or it is still will work

The conflict error is taken care of and merged to main