Odes two column

Closes #31.

type to filter cities and regions
enter in searchbox moves the map
clicking on a region name moves the map

https://mapzen-odes-extracts-pr-33.herokuapp.com/static/06-16-two-column/index.html 👀

This is looking pretty great.


Adding integration with the kn/pkg schema cli for the Discovery repo.

Changes

:gift: Add schema defintion to the clusterducktype

/kind  documentation
Before:
(╯°□°)╯︵  kubectl explain ClusterDuckType
KIND:     ClusterDuckType
VERSION:  discovery.knative.dev/v1alpha1

DESCRIPTION:
     <empty>

After:
(╯°□°)╯︵  kubectl explain ClusterDuckType
KIND:     ClusterDuckType
VERSION:  discovery.knative.dev/v1alpha1

DESCRIPTION:
     <empty>

FIELDS:
   apiVersion	<string>
     APIVersion defines the versioned schema of this representation of an
     object. Servers should convert recognized schemas to the latest internal
     value, and may reject unrecognized values.  Servers may infer this from the endpoint the client submits
     requests to. Cannot be updated. In CamelCase. More info:
     https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds

   metadata	<Object>
     Standard object's metadata. More info:
     https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata

   spec	<Object>
     Spec holds the desired state of the ClusterDuckType (from the client).

   status	<Object>
     Status communicates the observed state of the ClusterDuckType (from the
     controller).

Or more detail:
(╯°□°)╯︵  kubectl explain ClusterDuckType.spec
KIND:     ClusterDuckType
VERSION:  discovery.knative.dev/v1alpha1

RESOURCE: spec <Object>

DESCRIPTION:
     Spec holds the desired state of the ClusterDuckType (from the client).

FIELDS:
   group	<string>
     Group is the API group of the defined duck type. Must match the name of the
     ClusterDuckType (in the form `<names.plural>.<group>`).

   names	<Object>
     Names holds the naming conventions for this duck type.

   selectors	<[]map[string]>
     Selectors is a list of selectors for CustomResourceDefinitions to identify
     a duck type.

   versions	<[]map[string]>
     Versions holds the schema and printer column mappings for specific versions
     for duck types.

Etc...
Integration steps
go run ./cmd/schema/ dump ClusterDuckType | pbcopy

Paste this inside the CRD (config/300-clusterducktype.yaml) for ClusterDuckType:
...
      schema:
        openAPIV3Schema:
          <**paste**>
      additionalPrinterColumns:
...

Release Note

ClusterDuckType now supports kubectl describe.

/retry

/lgtm
/approve


can not create operator by helm

[root@d0404 ~]# kubectl create ns spark-operator
namespace/spark-operator created
[root@d0404 ~]# helm install my-spark chartmuseum/sparkoperator --version 0.8.6
WARNING: This chart is deprecated
Error: rendered manifests contain a resource that already exists. Unable to continue with install: existing resource conflict: namespace: , name: sparkapplications.sparkoperator.k8s.io, existing_kind: apiextensions.k8s.io/v1beta1, Kind=CustomResourceDefinition, new_kind: apiextensions.k8s.io/v1beta1, Kind=CustomResourceDefinition
what does this error refers to?

Similar to #1087
Helm has moved away from the Helm 2 model of a central repo for charts. Work is being done in this repo to migrate to Helm 3 and get this deployment working again.

The migration has been completed. Please see https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/issues/1021 for more details.


Unable to get nest_path working with DIH

Should nest_path work with DIH?  If I generate the fields as columns in the 'select' statements is that enough to get nest_path working with DIH?
I opened this issue a while back but it got no movement since the package was moving to community driven:
https://issues.apache.org/jira/browse/SOLR-14490
It's possible i've just got a something misconfigured but I haven't been able to find any resources regarding DIH and the nest_path field.

I have same issue. I think we have to wrap child document in to field element.

I was able to get it working by manually setting nest_path properties in
the child doc queries (using DIH with mariadb).


[Event Parameter Request] Table 36 Sales Header - procedure RecreateSalesLines - event OnRecreateSalesLinesOnAfterSetSalesLineFilters

We would like the Parameter/-s Rec added to the following event.
Table 36 Sales Header - procedure RecreateSalesLines - event OnRecreateSalesLinesOnAfterSetSalesLineFilters
Original:
Table 36 Sales Header - procedure RecreateSalesLines - event OnRecreateSalesLinesOnAfterSetSalesLineFilters

OnRecreateSalesLinesOnAfterSetSalesLineFilters(SalesLine);

[IntegrationEvent(false, false)]
local procedure OnRecreateSalesLinesOnAfterSetSalesLineFilters(var SalesLine: Record "Sales Line")
begin
end;

Change:
OnRecreateSalesLinesOnAfterSetSalesLineFilters(SalesLine, Rec); // <-- ADDED Rec

[IntegrationEvent(false, false)]
local procedure OnRecreateSalesLinesOnAfterSetSalesLineFilters(var SalesLine: Record "Sales Line"; SalesHeader: Record "Sales Header") // <-- ADDED Rec/SalesHeader
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10392.


parse_operator_metadata - recurse to find pkg path

When running parse-operator-metadata.yml, the operator_work_dir extra-var is specified to indicate the directory where metadata files reside. The find module needs to recurse so as to discover the package file if the metadata is contained a sub directory of operator_work_dir.

I am going to close this. Operator courier expects the package file to reside at the top level directory and not within a sub directory. So the playbook should fail in the same manner.


Add Burlington VT

Please add Burlington, VT https://www.burlingtonvt.gov/CityCouncil

DUE TO HIGH VOLUME EMPTY ISSUES, OR ISSUES MISSING THE FOLLOWING INFORMATION WILL BE IMMEDIATELY CLOSED. THANK YOU!

A subject message for the email
A list of emails (at least one) for the government officials you’d like to receive the message
A detailed message concerning the budgeting decisions that are at stake in your community

Please read more about our email style guidelines here.
If this information is copied from an external source please provide a link to the original source.
See our current links for examples at https://defund12.org.
Thank you!!


Never synced secrets should get priority over existing secrets

Is your feature request related to a problem? Please describe.
We manage about 2000 external secrets in 20+ namespaces. Whenever we create a new secret we need to wait until the refresh queue (our secrets have a refresh interval of 30 secs) is done and the new secrets get synced. Due to the volume of secrets we also had to disable the webhook because it started to regularly time out on deployments/applying of ArgoCD managed applications. This leads to newly created secrets taking anywhere from 5-15mins to get synced for the first time.
Describe the solution you'd like
There should be some logic that external-secret resources which never had a successful sync attempt get triggered first. There should be like a scan for all external-secrets and if one is found that never was synced before it should be placed in the front of the queue instead of the back.
Describe alternatives you've considered
Re-enabling the webhook and analysing why the connection to the webhook endpoint times out might be the alternative to this.
Additional context
N/A

Hello. Did you try out 0.11.0 yet? We significantly optimized the refresh of external secrets. I encourage you to try that out and see if it helps with your problem.

I've updated to 0.11.0 and while it seems to create the secrets quicker it doesn't seem to set the "SecretSynced" status anymore.

Well... running 2000+ secrets with 30s intervals will destroy your API server no matter what we do about it.

Does the refresh interval affect the first sync attempt? We could technically increase it to 5min or 10min or so.

@philipp-durrer-jarowa  are you on kubernetes slack? If so, do you mind DM'ing me @gusfcarvalho in there? I just want to understand your business requirements for having refreshInterval: 30s, which might be a sensitive discussion to have on public channels 😄

Does the refresh interval affect the first sync attempt? We could technically increase it to 5min or 10min or so.

RefreshInterval tells how many 'jobs' are on queue for ESO to reconcile. ESO will reconcile 10 at a time (the concurrent value). If one reconcile takes e.g. 1 minute due to throttling, this means for every one reconcile, two jobs are added - making this an impossible race for the controller to win.
In a setup as big as yours, I wouldn't even recommend enabling higher values for client sided throttling, as you'll start to hammer hard the API server (which is probably already busy with more important stuff such as ArgoCD).

One way to troubleshoot whats happening is to check if the workqueue_depth metric is growing. This should never grow and should always reach zero. Spike behavior is fine, but if you see it in a constant line or growing, it means you need to adjust your setup

I'm changing the issue name, as @Skarlso already mentioned, the feature request you added is not really possible - and the problem you're seeing is not really related to external-secrets at all - it is a configuration problem 😄

Personally, I think we should increase the default QPS and Burst (I will raise a PR to do this), but I also am skeptical that people should ever be increasing the concurrency beyond 1.

I have raised a PR to make the default QPS/Burst 50/100:

https://github.com/external-secrets/external-secrets/pull/4202

Ok, I also found a bunch of other API calls that we can reduce, namely that we are spam creating events on the cluster when we fail to reconcile an ExternalSecret for any reason.
For example, if an ExternalSecret was failing to reconcile for any reason, it would retry many times very quickly, and may create hundreds of events on the cluster.
I think we can reduce this by storing a lot of the event info in the ExternalSecret status, but also reducing how quickly we retry after a failure (currently an exponential back off starting at 15ms up to a max of 15min).

Another thing I realized is that once an ExternalSecret is in the exponential back-off (because it's failing for some reason) even if you update the ExternalSecret or fix the error which is causing it to not sync, it could take up to 15 minuets to try again (which is the max error backoff).

Thanks for digging into it, sounds like very reasonable improvements.

even if you update the ExternalSecret or fix the error which is causing it to not sync, it could take up to 15 minutes to try again (which is the max error backoff).

is this a new behavior with 0.11.0? I am sure for older versions any new updates causes a force reconcile immediately.

Thanks for digging into it, sounds like very reasonable improvements. @gusfcarvalho we don't have a real business reason for the aggressive refresh interval and we will go and switch them to 5mins or larger.

@philipp-durrer-jarowa you might need to change it to at least 15min… as this is the value that you’re seeing it’s taking for secrets to be synced.

even if you update the ExternalSecret or fix the error which is causing it to not sync, it could take up to 15 minutes to try again (which is the max error backoff).

is this a new behavior with 0.11.0? I am sure for older versions any new updates causes a force reconcile immediately.

No, this is always the case, note that it is an exponential back off so it does take a while to get to 15 minutes.

Also, only syncing once every 15 minutes is probably way too long for most business cases, If a secret is rotated, being out of date for 15 minutes is probably going to cause an outage.
And I'm talking about when people set the refresh interval explicitly here, because we can still fix the retry exponential back off thing and make it max out at 5 minutes.

even if you update the ExternalSecret or fix the error which is causing it to not sync, it could take up to 15 minutes to try again (which is the max error backoff).

is this a new behavior with 0.11.0? I am sure for older versions any new updates causes a force reconcile immediately.

@gusfcarvalho No, this is always the case, note that it is an exponential back off so it does take a while to get to 15 minutes.

On that, I just did a local test and if we do update the manifest, we are re-triggering a new reconcile loop for the failed manifest s immediately (even with refreshInterval: 0), so this becomes less of a problem 😄

Also, only syncing once every 15 minutes is probably way too long for most business cases, If a secret is rotated, being out of date for 15 minutes is probably going to cause an outage.
And I'm talking about when people set the refresh interval explicitly here, because we can still fix the retry exponential back off thing and make it max out at 5 minutes.

A retry every 5 minutes just might cause rate limiting to kick in more strongly on providers... typically ExternalSecrets on normal conditions should have higher refreshIntervals, so this might not be a good max.
but I agree we should increase the min to 1min

On that, I just did a local test and if we do update the manifest, we are re-triggering a new reconcile loop for the failed manifest s immediately (even with refreshInterval: 0), so this becomes less of a problem 😄

@gusfcarvalho was the ES in a true "error loop" as in the controller logs were showing "Reconciler Error", or was it just in a "sync failed".

A retry every 5 minutes just might cause rate limiting to kick in more strongly on providers... typically ExternalSecrets on normal conditions should have higher refreshIntervals, so this might not be a good max.
but I agree we should increase the min to 1min

I was actually saying 1 second not 1 min because we do want to quickly retry for some errors (e.g. API conflicts), so anything longer is probably way to long (default is 5ms).

On that, I just did a local test and if we do update the manifest, we are re-triggering a new reconcile loop for the failed manifest s immediately (even with refreshInterval: 0), so this becomes less of a problem 😄

@gusfcarvalho was the ES in a true "error loop" as in the controller logs were showing "Reconciler Error", or was it just in a "sync failed".

Yup - Reconciler error logs appearing. It does gets added to the stack appropriately without waiting for a new reocncile loop (which is why I was expecting)

A retry every 5 minutes just might cause rate limiting to kick in more strongly on providers... typically ExternalSecrets on normal conditions should have higher refreshIntervals, so this might not be a good max.
but I agree we should increase the min to 1min

@gusfcarvalho I was actually saying 1 second not 1 min because we do want to quickly retry for some errors (e.g. API conflicts), so anything longer is probably way to long (default is 5ms).

yeah, also good.

@philipp-durrer-jarowa can this be closed? 😄

Sure, merry christmas incase you celebrate it.


Focus switch/animation complete after pressing a button

Hello @dlenroc,
Is it possible to track somehow that the focus was moved after pressing a button? At this moment I use 0.5 sec sleep after each press to make sure the animation is complete and the focus is moved, but maybe there is a smarter way to do it instead of using this sleep.

I use Action API to focus/select elements via a project step.
await browser
  .action('pointer')
  .move({ origin: element, duration: 5000 })
  .perform();

Alternatively, you can use knowledge about the current element in focus to create more complex steps.
// 1. Identify focused element
const previousActiveElement = await $(await browser.getActiveElement());

// 2. Press a button from the remote
await device.driver
    .action('key')
    .down(Key.ArrowDown)
    .up(Key.ArrowDown)
    .perform();

// 3. Wait focused element to change
await browser.waitUntil(
  async () => {
    const activeElement = await $(await browser.getActiveElement());
    return previousActiveElement.elementId !== activeElement.elementId;
  },
  {
    interval: 100,
    timeout: 5000,
  }
);

PS:

Samples use WebdriverIO api, but similar methods are available for other languages/libraries. Please refer to their documentation for the exact names.
If there is interest, I may enable GitHub discussion for this repository for questions and ideas.


Hi, does anyone pay attention to the update of the document Localizations?

Acknowledgement

[X] I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.

Comment
https://github.com/microsoft/TypeScript-Website-Localizations
TypeScript-Website-Localizations 's PR has been overstocked for a long time.
I have noticed this since a year ago.
I believe there are many people who are as difficult as I am to understand static type terms without a local translation.

Probably https://github.com/microsoft/TypeScript/pull/55479#issuecomment-1692139435 is relevant

Unfortunately, Microsoft fired so many of its translators this year that we don't have budget for fixing anything but critical mistranslations. 💀 It might be possible to switch over to community translations, although I'd have to learn whether that would be possible.

Probably #55479 (comment) is relevant

Unfortunately, Microsoft fired so many of its translators this year that we don't have budget for fixing anything but critical mistranslations. 💀 It might be possible to switch over to community translations, although I'd have to learn whether that would be possible.

As a matter of fact, there was no translation, and I had to code anyscript in typescript to enjoy the convenience of type prompts.
Someone has finished the translation, and no one wants to update it to the website. Maybe the owner of the website doesn't care.

Maybe the owner of the website doesn't care.

See https://github.com/microsoft/TypeScript-Website/issues/2804 - the localizations are no longer being officially maintained.

Please understand that not having the resources to do something isn't the same as not caring about it.


Adds two new 'views' to Wikilabels -- ParsedWikitext and PageAsOfRevision

@he7d3r,  OK, I cleaned up some of the wrapping HTML tags, but I couldn't find a good way to clean up the tags that immediately surround content.  It seems like they are working OK in practice, so I'd like to move forward.  What do you think?

@he7d3r, I think we should suspend code review for wikilabels since it's going too slow right now.  Does that sound OK to you?  I'd still be happy with submitting my major changes as PRs and giving you a couple days to leave notes.  I just want to get these changes merged ASAP.

That is ok with me.
On Thu, Aug 13, 2015 at 1:19 PM, Aaron Halfaker<EMAIL_ADDRESS>wrote:

@he7d3r https://github.com/he7d3r, I think we should suspend code
review for wikilabels since it's going too slow right now. Does that sound
OK to you? I'd still be happy with submitting my major changes as PRs and
giving you a couple days to leave notes. I just want to get these changes
merged ASAP.
—
Reply to this email directly or view it on GitHub
https://github.com/wiki-ai/wikilabels/pull/74#issuecomment-130748494.


[$500] [Teachers Unite!] Implement optimistic whisper message

After the volunteer referral flow ("I know a teacher") is completed, we redirect the user to the public room. But if the user performs this action in offline mode, we’ll just display the chat report as loading (since we’ll persist the request, we will share the room anyway once the request has been made).
Given that’s the default offline behavior for public rooms (i.e. when the user opens the native app from a deep link), we’ll implement, as a follow-up, the optimistic whisper message to notify the user that at least something is happening.
Whisper message for the inviter/referrer:
"Hey @" + inviterDisplayName + "! Thanks for referring your friend " + firstName + " to Expensify.org Teachers Unite. We have gone ahead and reached out to them! We'll continue to share any important announcements here to keep you in the loop about the campaign's impact. If you'd like to refer someone else, just click on Save The World in the app's main menu. Thanks for helping us to Save The World!"

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01ab3acade482df27d
Upwork Job ID:<PHONE_NUMBER>263553024
Last Price Increase: 2023-12-21

I was investigating the issue. Already have an idea how to do it clear.
Guys, I’m OOO from tomorrow until next Monday due the RNEU conference. If it is not an urgent issue, I can continue to work on.

@burczu can you take a look at @hoangzinh proposal?

@tjferriss Yes - I'll review it today.

@hoangzinh Could you be more specific how exactly you want to add this whisperedToAccountIDs parameter to optimistic data? I've tried it with no luck...

Just to inform: I'll be OOO on Thursday and Friday (7-8 September).

Hi, guys!
I am back. So, please let me know do you need my help here?

Not overdue - @tjferriss are we gonna assign @rezkiy37 as he is back? Or maybe we are going to put this on hold (https://github.com/Expensify/App/issues/26738#issuecomment-1712409474)?

@tjferriss, just to friendly reminder about - https://github.com/Expensify/App/issues/26738#issuecomment-1715377224.

Yes, I think we can put this on hold for now while we figure out when we'll be launch the Save the World flow. The tracking issue for the project is here: https://github.com/Expensify/Expensify/issues/223645

@tjferriss, can I continue work on the issue?
FYI: https://github.com/Expensify/App/issues/26738#issuecomment-1723750652

Stop, @hoangzinh I don't see "Save the world" in the latest main anymore. Are we going to remove the flow?

The issue backs to on hold - https://github.com/Expensify/App/pull/27763#issue-1902566877.

Assigning myself to track it, I will change it to daily to check it out tomorrow

@marcochavezf have you been able to look into this one at all?

Oops, I was focused on another wave7 item. @rezkiy37, let's continue with this issue. We're planning to add the STW button when the campaign is live, but meanwhile, let's implement it, and you can access the page by adding the route /teachersunite to the URL in the browser.
@hoangzinh thanks for the proposal. When I created the issue I asked for help from the Callstack team first, appreciate your proactivity 🙇🏽

@marcochavezf, /teachersunite does not work for me 🧐

@marcochavezf, I have a few questions:

Should be the whisper message interactive? I mean that in the description there are inserts with an account and link.
Who should be a sender of the message<EMAIL_ADDRESS>If yes, can I hardcode login and display name of the sender?

Thank you!

Also, can I ask you for a translation of the message?

@marcochavezf, /teachersunite does not work for me 🧐

Ah it should be the full relative route (without /r) https://staging.new.expensify.com/teachersunite

Should be the whisper message interactive? I mean that in the https://github.com/Expensify/App/issues/26738#issue-1881048071 there are inserts with an account and link.

Yup, it should use the existing mention implementation which has the format <mention-user>@${accountEmail}</mention-user> if I recall correctly.

Who should be a sender of the message<EMAIL_ADDRESS>If yes, can I hardcode login and display name of the sender?

Yup, you can try to "refer" a teacher with the URL posted in the previous comment and you will see the whisper that we send from the backend:

The idea is to create the same whisper optimistcally in the client-side instead of waiting for the server to send it

Also, can I ask you for a translation (ES) for the message?

Yes, and this brings an interesting point I haven't considered. Do you know if we're translating other optimistic whisper messages? Because we don't support locale in the backend atm and we're just generating this message in English, which could be a problem if the app is configured in Spanish and receives eventually the message in English. So I think we would need to modify the ReferTeachersUniteVolunteer API command to receive the whisper message from the client-side.

Melvin, I am actively working on a proposal now.

Also, can I ask you for a translation (ES) for the message?

Yes, and this brings an interesting point I haven't considered. Do you know if we're translating other optimistic whisper messages? Because we don't support locale in the backend atm and we're just generating this message in English, which could be a problem if the app is configured in Spanish and receives eventually the message in English. So I think we would need to modify the ReferTeachersUniteVolunteer API command to receive the whisper message from the client-side.

Yeah, I see that whisper messages aren't localized yet. So, I will skip localization for now.

So I think we would need to modify the ReferTeachersUniteVolunteer API command to receive the whisper message from the client-side.

Could you please clarify what should we expect?

A proposal is under Callstack's internal review now.

Proposal
Please re-state the problem that we are trying to solve in this issue.
Implement optimistic whisper message for Teachers Unite when a user invites someone.
What is the root cause of that problem?
Feature request.
What changes do you think we should make in order to solve the problem?
Basically, we need to generate a new action (whisper message) for the Teachers Unite room.
Before, we need to add a few constants for a owner of the action (whisper message):

PUBLIC_ROOM_ADMIN_ID - 8340048 - sender (admin) id.
PUBLIC_ROOM_ADMIN_LOGIN -<EMAIL_ADDRESS>- sender (admin) login.
PUBLIC_ROOM_ADMIN_DISPLAY_NAME - Expensify.org Admin - sender (admin) name.

The action includes html and text with a few inserts for a current user email and receiver email. Also, it includes whisperedToAccountIDs with a current user id (to be a whisper message).
Btw, we need to sync the front-end and backend whisper messages. Because they are the same, but with different ids.
Example

https://github.com/Expensify/App/assets/57314631/56705aa5-0480-4e05-929e-13b192fff3e3

@marcochavezf, please take a look at a proposal above 🙂

Hi @rezkiy37, yeah the proposal looks good, thanks! I think the only change we'd need to sync the frontend and backend is to send the reportActionID from the optimistic whisper message to the API command ReferTeachersUniteVolunteer as a parameter. Could you include that change so I can test the backend changes?

Hi @rezkiy37, yeah the proposal looks good, thanks! I think the only change we'd need to sync the frontend and backend is to send the reportActionID from the optimistic whisper message to the API command ReferTeachersUniteVolunteer as a parameter. Could you include that change so I can test the backend changes?

Added a commit - ead10a05da9d906fd81e893f45562c8a0a0354a9. I've tested and it is still duplicating a message.

@marcochavezf, a friendly reminder about - https://github.com/Expensify/App/issues/26738#issuecomment-1755766345.

Thanks for the change, I will working on the backend changes to avoid the duplicate message

No update

No update

No update

No update

Waiting on the backend changes.

No update.

@marcochavezf, should we add "On Hold" to this issue?

I have to inform that starting tomorrow I have a short vocation until next Monday (6.11.2023). Feel free to left any comments, I will address them. See you soon 😉

Just to inform, I'll be ooo for the next few days and we'll be back on Monday, November 6th.

No update, seems Melvin didn't detect the on hold label in the title

@marcochavezf, we can change the updates frequency from daily to weekly.

Yeah, good call, I will move it to weekly

I'm asking in Slack about the priority of this issue

Please let us know then.

Alright, the priority is really remaining the same, but we're taking this off hold.

Still waiting on the backend here.

@marcochavezf, any news?

Hi @rezkiy37, sorry for the delay here. I've been focused on other high-priority items. I plan to retake this one this week (or early next week).

No update, but I'm retaking this one today or tomorrow.

Hey @tjferriss! I'll be OOO till January 6th, and right after that I'm leaving the C+ role and joining Waves. Could you please assign another C+ engineer to handle this issue from now on? Thanks.

Guys, I am having a vacation till the 4th January. So, I will be OOO within this period.

I can take over as C+

No update, we'd need to implement first a way to test the TU flows without impacting the data in the real policy. I already created a couple of PRs to flip the constants and one of those has been merged.

Feel free to move this to vip-vsb if you'd like to prioritize this, though I don't think it's required for wave7 any longer.

Moved to vip-vsb with priority Medium although it's not part of Complex splits

@marcochavezf any update here?

Sorry no update, I've been focused on wave bugs

Sorry no update, I've been focused on wave bugs

Same, but fortunately most of them are done. I will move it to daily to continue with this one next week

No update today, wrapping up other dailies, then I will continue with this one

Phew, I thought I was going to have time to check out this one, still a bit behind with some critical bugs

Prioritizing today some critical bugs

Looks like we need a new BZ here, reassigning.

https://expensify.slack.com/archives/C01GTK53T8Q/p1708375641196609
Closing


.NET 6?

Would you be willing to take a PR to upgrade this repo to .NET 6?

Hi @davidop
Thank you for showing interest in Demo Generator, we are planning to work on that. Any PR which supports .NET 6 would be much helpful and appreciated.
Thanks!


[docs] Standardize the usage of callouts in the MUI Core docs

This PR is part of the ongoing effort to standardize the style and formatting of the MUI docs.
The purpose here is to enforce consistent usage of the four types of callouts, based on the rules set forth in the doc I've created in the Company Handbook.
Additionally, I've removed all signifiers (⚠, 💡, Note:, Tip:, etc.) within the callouts, which are redundant now that we have different types.
I've also made some tiny grammar and style changes in and around the callouts where I noticed them, but tried to limit the scope of this PR by not actively editing the content.
If/when we're in agreement about the implementation of the style rules here, I'll perform this same audit for the X and Toolpad docs.
https://deploy-preview-35361--material-ui.netlify.app/experiments/docs/callouts/

Additionally, I've removed all signifiers (⚠, 💡, Note:, Tip:, etc.) within the callouts, which are redundant now that we have different types.

@samuelsycamore It sounds great, we can later implement them in a systematic fashion based on the design direction that we would like to them to look like 👍

Stripe https://stripe.com/docs/billing/subscriptions/overview

Docusorus https://docusaurus.io/docs/docusaurus-core#errorboundary

Us https://deploy-preview-35361--material-ui.netlify.app/experiments/docs/callouts/

Nextra https://nextra.site/docs/docs-theme/built-ins/callout#default

Minimist https://mintlify.com/docs/components/callout

Tailwind CSS ❌ can't find any, they don't use this pattern. Maybe we should use it parsimoniously.


chore(gateway): lower "Tunnel error" to debug

This is spamming Sentry and we have almost reached our rate limit for the amounts of events ingested.

Proper fix here is of course to identify what the actual error is and either fix it or silence it to not be a warning. That will happen afterwards. For now, we need to paper of this to not send excessive amounts of events to Sentry.


Discrepancy between git source and pip 0.0.21 package for convert_reshape

I have tried to convert onnx model with change_ordering=True but conversion broke on convert_reshape.
I have managed to perform conversion by removing line 179 in /Lib/site-packages/onnx2keras/reshape_layers.py
layers[node_name].set_shape([None, *input_1[1:]])

This line breaks when shape has values which are less than 0. In my conversion input_1 was [None, -1, 3]. With that line removed layers[node_name] shape was [None, None, 3] and it worked (I have tested outputs from PyTorch and Keras models and they were identical).
When I tried to post an issue for this problem, I found out that previously mentioned line is not presented in a git source (for tag v0.0.21):
https://github.com/nerox8664/onnx2keras/blob/0585e070ea96cad9f08eed3dcc7d429fe9b82dd0/onnx2keras/reshape_layers.py#L176-L179
After a further research I found out that this problem occurs only in onnx2keras version 0.0.21 but not in 0.0.20.
0.0.20 version (https://pypi.org/project/onnx2keras/0.0.20/#files) contains following lines in reshape_layers.py convert_reshape:
reshape = keras.layers.Reshape(np.int32(input_1[1:]), name=keras_name)
layers[node_name] = reshape(layers[node_name])

0.0.21 version (https://pypi.org/project/onnx2keras/0.0.21/#files) contains following lines in reshape_layers.py convert_reshape:
reshape = keras.layers.Reshape(np.int32(input_1[1:]), name=keras_name)
layers[node_name] = reshape(layers[node_name])
print(layers[node_name], input_1)
layers[node_name].set_shape([None, *input_1[1:]])

I am guessing that these two line were mistakenly added during debug or testing process. If that is not the case could you explain how did it came to that.
My environment:
onnx | 1.7.0
onnx2keras | 0.0.21
python | 3.6.10
tensorflow | 2.1.0

Hello @Jukyy.
Yes, it was a temporary code I wrote when I tried to debug ONNX version of ShuffleNet model conversion and it accidentally was packed to the pip package.
Thanks for your research! I updated pip package version.

Hello @nerox8664.
Thank you for a quick fix


cm-error highlight after img dataurl

When it finds a img tag with dataurl in the src attribute, like
<img src="data:image/jpeg;base64,/9j/4AAQSkZJRgABAQAAAQABAAD/2wBDAA0JCg....

it highlights next tag as an error; it seems to be due to the length of the src attribute;

Highlighting ridiculously long lines is a performance hazard, and yes, that can sometimes confuse the tokenizer. You can set the maxHighlightLength to Infinity or to something larger than the default (10000) to work around this, but I don't know of a general solution to this problem. Suggestions welcome, though.


Update atlantis 0.19.5, TF 1.2.4, TG 0.38.4

Is blocked because of issue mentioned here: https://github.com/runatlantis/atlantis/issues/2371

I have to bump atlantis version to 0.19.6 to fix issue with platform


Hotfix. evaluate_agent() with return_trajectories=True right now return wrongful trajectories

Trajectories returned are off-by-one in the indexing. Essentially, the tuple that is supposed to be (s_t, a_t, r_t) is collected as (s_{t+1}, a_t, r_t) with s_0 unrecoverable. This commit fixes it.

This does not affect any existing result, as the return_trajectories=True are not used (or the data collected used)


docs: added instruction from rpm to container

Fixes #1799
Signed-off-by: Miquel Sabaté Solà<EMAIL_ADDRESS>

@vitoravelino fixed everything except the part in which I was not sure.


HDFS-16455. RBF: add zk-dt-secret-manager.jute.maxbuffer property for Router's ZKDelegationTokenManager

Description of PR
https://issues.apache.org/jira/browse/HDFS-16455
How was this patch tested?
no test
For code changes:
add zk-dt-secret-manager.jute.maxbufferproperty to default value 20000000,  20MB

这是自动回复邮件。来件已接收，谢谢。

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  6s

trunk passed

+1 :green_heart:
compile
22m 22s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 41s

trunk passed

+1 :green_heart:
javadoc
1m 13s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 28s

trunk passed

+1 :green_heart:
shadedclient
22m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 58s

the patch passed

+1 :green_heart:
compile
21m 37s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m 37s

the patch passed

+1 :green_heart:
compile
19m 29s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
19m 29s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

the patch passed

+1 :green_heart:
mvnsite
1m 38s

the patch passed

+1 :green_heart:
javadoc
1m 10s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 44s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 37s

the patch passed

+1 :green_heart:
shadedclient
23m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 50s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

196m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3983/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3983

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 8e25a43a97f7 4.15.0-161-generic #169-Ubuntu SMP Fri Oct 15 13:41:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 535e276b55dc36ea220708a71d4094c18669aa35

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3983/1/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3983/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  1s

trunk passed

+1 :green_heart:
compile
22m  9s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 39s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 43s

trunk passed

+1 :green_heart:
javadoc
1m 15s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 26s

trunk passed

+1 :green_heart:
shadedclient
21m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 59s

the patch passed

+1 :green_heart:
compile
21m 31s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m 31s

the patch passed

+1 :green_heart:
compile
19m 39s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
19m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  5s

the patch passed

+1 :green_heart:
mvnsite
1m 39s

the patch passed

+1 :green_heart:
javadoc
1m  9s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 44s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 36s

the patch passed

+1 :green_heart:
shadedclient
22m 14s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 37s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

196m  3s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3983/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3983

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux<PHONE_NUMBER>fc 4.15.0-161-generic #169-Ubuntu SMP Fri Oct 15 13:41:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e898cb2a0668e54069b1ba26401e570ad33f3302

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3983/3/testReport/

Max. process+thread count
1289 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3983/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 14s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 22s

trunk passed

+1 :green_heart:
compile
25m 38s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
21m 14s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 43s

trunk passed

+1 :green_heart:
javadoc
1m  8s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 34s

trunk passed

+1 :green_heart:
shadedclient
25m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  5s

the patch passed

+1 :green_heart:
compile
24m 13s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
24m 13s

the patch passed

+1 :green_heart:
compile
21m 21s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
21m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 59s

the patch passed

+1 :green_heart:
mvnsite
1m 36s

the patch passed

+1 :green_heart:
javadoc
1m  5s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 38s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 41s

the patch passed

+1 :green_heart:
shadedclient
25m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m  4s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

219m 11s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3983/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3983

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 378f1572afc2 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e898cb2a0668e54069b1ba26401e570ad33f3302

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3983/2/testReport/

Max. process+thread count
3059 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3983/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Question: why don't you use the request.Context()?

In the HTTP Handler, I see that ctx is passed explicitly (along the *http.Request).
Do you have any reason not to use Request.Context()?
And Request.WithContext(ctx) when the context must be augmented.

Thanks for putting together this repo. It is a goldmine to learn more about structuring production-ready applications!

Yes, that pattern of keeping the context in the request might be ok when you are stuck using a router and can't change the handler. Even with that, once the request enters into the business layer, you will not pass the request to pass the context.
So I believe it is best to start passing the context as a parameter ASAP. Since this project creates its own handler, we can do that immediately. We do use the request context as the parent.
By passing the context as a parameter, it so doesn't hide the context and makes everything more precise.

Thank you for you quick reply.
If I understand correctly this is a tradeoff:

a bit of duplication for every function (or handler) which gets a context and a request
be more explicit for functions which don't get the Request as parameter

I think I would (personally) rather have only one context available in each function call, to be sure not to take the wrong one (a function which has a Context and a Request.Context could make use of the "wrong" context).

Read this post. What I am doing follows these guidelines
https://www.ardanlabs.com/blog/2019/09/context-package-semantics-in-go.html

Even with that, once the request enters into the business layer, you will not pass the request to pass the context.

As soon as I reach the business layer, I can extract context from the Request and pass it to the business layer.

Since I control the web framework I decided to extract the context out of the request immediately and pass it down the call stack as the first parameter sooner. I believe it lends itself to more consistency in the code.
I also believe the Go team would have done the same with the http package if they didn’t have the backwards compatibility promise to adhere to. They would have changed the handler function to take a context. There solution to hide it in the request solved a problem.


Also fix existing lint errors and define some reused prop types.
refactor: remove directory-named-webpack-plugin

The behavior granted by this plugin is very unintuitive and increases
barrier to entry
Poor compat with current Webpack / Storybook version

Also add index.js for all folders.
chore: Fix storybook webpack config + add SVG support
fix(EventCard): Small fixes

Fix GraphQL Meetup query to give correct values
Fix date parsing
Align icons properly
Run Prettier

chore(EventCard): Add story

@a-trost do you think you can look into this build error when you get a chance? I think I'm configuring the Meetup GQL query wrong, as it keeps trying to fetch time instead of local_time despite querying for local_time. Thus event.local_time is undefined causing the error in the build.

@a-trost do you think you can look into this build error when you get a chance? I think I'm configuring the Meetup GQL query wrong, as it keeps trying to fetch time instead of local_time despite querying for local_time. Thus event.local_time is undefined causing the error in the build.

@timhwang21 You just need to change the field in the eventlist component graphql query from time to local_time:

Ah I see now. There are two duplicate queries -- one in eventlist and one in events. That was the source of the confusion... I'll remove one.


Question 11

Possibly change to does it require hardware not supported by openshift, or does it require specific hardware that is supported but may require additional Cluster considerations.
Now that OCP support several potential hardwares.   Power, GPUs etc.

Done


Should indicate that Emphemeral drive is always /dev/sdb

On the section "Temporary Disk", it should indicate that in every Linux VM the Ephemeral drive (temporary disk) is /dev/sdb

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b61b1427-1941-9831-e823-e2d114decb4a
Version Independent ID: 1ad9a4b7-0190-5f31-835c-fcf020cb39ad
Content: Azure Disk Storage managed disk overview for Linux VMs
Content Source: articles/virtual-machines/linux/managed-disks-overview.md
Service: virtual-machines-linux
GitHub Login: @roygara
Microsoft Alias: rogarana

@msLinuxNinja Thanks for your feedback.
That's mentioned in the document under performance optimization.
We can also add a note in this document since this document gives an intro about all the disk types.
@roygara Please add your comments

Yep, it is mentioned in other docs, but if we can put it everywhere the Emphemeral disk topic is touched upon we can help avoid people using this disk for storing data. By having a clear note saying that /dev/sdb is always the ephemeral disk might help reduce the instance of people storing data there and then realizing it is gone.

I have assigned the issue to the content author to investigate further and update the document as appropriate.

@msLinuxNinja thanks for reaching out, we appreciate it.
That does make sense to me. I'm going to confirm with the product team that it is always /dev/sdb and if so then I'll add that note.

@msLinuxNinja I've confirmed that is indeed the default and will be adding this to the article. Thanks again for helping improve our documentation, we appreciate it! :)

The changes have been merged and should be live later today.
Accordingly,
#please-close

@msLinuxNinja
Thanks for bringing this to our attention. We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


$tmpAccountName in accounts onboard script is used but not declared

Summary
$tmpAccountName in accounts onboard script is used but not declared leading to empty account name in logs and screen displayed message
looks like below:
[2021-12-09 01:13:16]	[INFO]	[2/2] Added  successfully.

Thanks @akgitrokz
We changed to a different parameter and obviously forgot to change this one
Thanks for letting us know
This will be fixed shortly


Can we disable connections to slave servers ?

As redis slaves do not server read requests unless you have READONLY on, the slaves do not server any purpose and redirect to master.
Can we disable connections to slave server, we experienced multiple issues like the ones mentioned below
We found out that slaves were not in sync with master, once we synced the slaves then it loaded all the data (45 GB) in memory which took around 30 mins. During this time, the slaves were not able to server any requests and gave an error "Loading data in memory"

I agree with this propose. I read the jedis code 2.9.0, it seems client only connect the slave to update Cluster Slots Map, and never read from or write to the slave.
But slave's  issue also can cause problem to the client.
Rencently it has a malfunction in our company, a del of a huge ZSet block the slave for 43 seconds, and many client applications have problem at that time. We are still studying why slave block can cause client to have problem.


docs: update compiler collision error to add helpful information

What I did
update compiler collision error message output to include collision name

fixes: #178
How I did it
updated error message with f string
How to verify it
put a contract called Token.sol and another called Token.vy and then try to compile and you will get an error pointing to the contract.
Checklist

[ ] All changes are completed
[ ] New test cases have been added
[ ] Documentation has been updated

raise CompilerError(f"ContractType collision across compiler plugins with contract name: {contract_type.name}")


Fix aggregate-reports.yml

Moving https://github.com/Azure/azure-sdk-for-js/pull/19004 to a branch off the main repo.
The aggregate-reports.yml pipeline restricts usage of some service connections and will fail if not run from a branch off the main repo.

This error is interesting because the PR is not from a fork of the repository: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1234398&view=logs&j=9e400fad-ff47-5b38-f9dc-cae2431972da&t=1733f376-36c8-5713-fc2d-c4bb22c9119a&l=1


SDCard format leads to speed decrease

I have SD card using 4-line SD mode (SDMMC peripheral). SD is formatted under Windows 7 with exFAT (cluster 16k). I measured SD Card speed writing 1mb file in circle. The speed depends of buffer size, as expected. Results are:
1kb buffer: 0.3-0.4 Mb/s
2kb buffer: 0.6-0.9 Mb/s
4kb buffer: 0.9-1.9 Mb/s
8kb buffer: 1.0-3.8 Mb/s
16kb buffer: 1.4-4.1 Mb/s
If I format SD using esp32 than I have significant decrease of speed. The speed does not depend of buffer size:
1kb buffer: 0.14-0.16 Mb/s
2kb buffer: 0.14-0.16 Mb/s
4kb buffer: 0.14-0.16 Mb/s
8kb buffer: 0.14-0.16 Mb/s
16kb buffer: 0.14-0.16 Mb/s
FATFS configuration is:
CONFIG_FATFS_CODEPAGE=866
CONFIG_FATFS_LFN_HEAP=y
CONFIG_FATFS_MAX_LFN=255
#define FF_FS_EXFAT		1
#define FF_LFN_UNICODE	2
#define FF_STRF_ENCODE	3

I use the following format function:
static sdmmc_card_t* s_card = NULL;
static uint8_t s_pdrv = 0;
static char * s_base_path = NULL;

esp_err_t MySD::_format(String &sLog) {
    // input parameters
    const char* base_path = (char*)MOUNT_POINT;
    const sdmmc_host_t* host_config = &m_host;
    const void* slot_config = &m_slot_config;
    const esp_vfs_fat_mount_config_t* mount_config = &s_mount_config;

    esp_err_t err = ESP_OK;
    const size_t workbuf_size = FF_MAX_SS; //f_fdisk needs FF_MAX_SS
    void* workbuf = NULL;
    FATFS* fs = NULL;
    sLog = "";
    BYTE pdrv;
    FRESULT res;
    DWORD plist[] = {100, 0, 0, 0};
    char drv[3];

    if (s_card != NULL) {
        sLog = "Previous unmount() is not fully completed";
        return ESP_ERR_INVALID_STATE;
    }

    // connect SDMMC driver to FATFS
    pdrv = 0xFF;
    if (ff_diskio_get_drive(&pdrv) != ESP_OK || pdrv == 0xFF) {
        sLog = "The maximum count of volumes is already mounted";
        return ESP_ERR_NO_MEM;
    }

    s_base_path = strdup(base_path);
    if(!s_base_path){
        sLog = "Could not copy base_path, not enough momory";
        return ESP_ERR_NO_MEM;
    }

    s_card = (sdmmc_card_t*)malloc(sizeof(sdmmc_card_t));
    if (s_card == NULL) {
        sLog = "Could not allocate memory for sdmmc_card_t";
        err = ESP_ERR_NO_MEM;
        goto fin;
    }

    err = (*host_config->init)();
    if (err != ESP_OK) {
        sLog.printf("Host init returned err=0x%x", err);
        goto fin;
    }

    // configure SD slot
    if (host_config->flags == SDMMC_HOST_FLAG_SPI) {
        err = sdspi_host_init_slot(host_config->slot,
                (const sdspi_slot_config_t*) slot_config);
    } else {
        err = sdmmc_host_init_slot(host_config->slot,
                (const sdmmc_slot_config_t*) slot_config);
    }
    if (err != ESP_OK) {
        sLog.printf("Slot init returned err=0x%x", err);
        goto fin;
    }

    // probe and initialize card
    err = sdmmc_card_init(host_config, s_card);
    if (err != ESP_OK) {
        sLog.printf("Card init returned err=0x%x", err);
        goto fin;
    }

    ff_diskio_register_sdmmc(pdrv, s_card);
    s_pdrv = pdrv;
    ESP_LOGD(TAG, "%s() using pdrv=%i", __func__, pdrv);
    //char drv[3] = {(char)('0' + pdrv), ':', 0};
    drv[0] = (char)('0' + pdrv);
    drv[1] = ':';
    drv[2] = '\0';

    // connect FATFS to VFS
    err = esp_vfs_fat_register(base_path, drv, mount_config->max_files, &fs);
    if (err == ESP_ERR_INVALID_STATE) {
        // it's okay, already registered with VFS
    } else if (err != ESP_OK) {
        sLog.printf("FAT register returned err=0x%x", err);
        goto fin;
    }

    ESP_LOGW(TAG, "%s() partitioning card...", __func__);
    workbuf = malloc(workbuf_size);
    ESP_LOGW(TAG, "%s() workbuf_size=%d workbuf=0x%x", __func__, workbuf_size, (unsigned int)workbuf);
    if (workbuf == NULL) {
        sLog = "Could not allocate memory for workbuf";
        err = ESP_ERR_NO_MEM;
        goto fin;
    }

    ESP_LOGW(TAG, "%s() fdisking card...", __func__);
    res = f_fdisk(s_pdrv, plist, workbuf);
    if (res != FR_OK) {
        sLog.printf("f_fdisk returned err=0x%x", res);
        err = ESP_FAIL;
        goto fin;
    }
    ESP_LOGW(TAG, "%s() formatting card...", __func__);
    res = f_mkfs(drv, FM_ANY, s_card->csd.sector_size, workbuf, workbuf_size);
    ESP_LOGW(TAG, "%s() formatting done", __func__);
    if (res != FR_OK) {
        sLog.printf("f_mkfs returned err=0x%x", res);
        err = ESP_FAIL;
        goto fin;
    }
    free(workbuf);
    workbuf = NULL;

    ESP_LOGW(TAG, "%s() mounting again", __func__);
    res = f_mount(fs, drv, 0);
    if (res != FR_OK) {
        sLog.printf("f_mount after format returned err=0x%x", res);
        err = ESP_FAIL;
        goto fin;
    }
    //return ESP_OK;

fin:
    if (sLog.length() > 0) {
      ESP_LOGE(TAG, "%s() %s", __func__, sLog.c_str());
    }
    sdmmc_host_deinit();
    free(workbuf);
    if (fs) {
        f_mount(NULL, drv, 0);
    }
    esp_vfs_fat_unregister_path(base_path);
    ff_diskio_unregister(pdrv);
    free(s_card);
    s_card = NULL;
    return err;
}

FatFS is unmounted before calling format function. Just after format, Windows 7 can not read SD card. When I insert an adapter with SD card it is blinking endless, drive letter is appeared but system hangs on trying to open it. If esp32 formats SD card with FAT, the situation is the same. I used 5 different SD cards (2gb, 8gb, 32gb). To recover SD card I insert it into phone with android, format with FAT, than format with exFAT under Windows.

That probably has to do with the allocation unit size set to sector size in
res = f_mkfs(drv, FM_ANY, s_card->csd.sector_size, workbuf, workbuf_size);

According to the FATFS manual, "The value must be power of 2 and between the sector size and 128 * sector size".
Setting the allocation unit equal to 64kB will result in the best performance.

You are right, the third parameter in
res = f_mkfs(drv, FM_ANY, s_card->csd.sector_size, workbuf, workbuf_size);
not a sector size, but a cluster size. After setting allocation unit to 64k and forcing exFAT by FM_EXFAT I got expected speed:

const DWORD allocation_unit = 65536;
res = f_mkfs(drv, FM_EXFAT | FM_SFD, allocation_unit, workbuf, workbuf_size);

According to the source file vfs_fat_sdmmc.c, if mount fails and flag format_if_mount_failed is set, than format will be called as:
res = f_mkfs(drv, FM_ANY, s_card->csd.sector_size, workbuf, workbuf_size);
and we see that allocation unit will be 512 bytes. Maybe it should be like this?:
res = f_mkfs(drv, FM_ANY | FM_SFD, workbuf_size, workbuf, workbuf_size);
just like in vfs_fat_spiflash.c, at least allocation unit will be 4096 bytes. By the way, file system in this case will be FAT32, not exFAT (type is calculated according to overall size of sd card, for very large cards it can be exFAT).

It does make sense to make the allocation unit size configurable through esp_vfs_fat_mount_config_t, agree on that. FM_SFD flag should not be used in case of an SD card though, as it indicates that the media should not be partitioned, with the FAT volume starting from sector 0. This is something that makes sense for FATFS in flash (it is never read by other devices), but for an SD card this may cause compatibility issues.

Thanks for the hint on FM_SFD. I removed this flag.


Withdrawal

Good day,
your withdrawal screen does not allow me to enter a wallet address. There is already a wallet address and it will not let me change it.
Please assist
thank you

could you provide a screenshot?

Good morning,
Here is the screenshot.
As you can see, it does not allow me to enter a wallet address, it only
lets me submit a withdrawal. I definitely do not want to lose my DOT
Thank you
On Mon, Feb 15, 2021 at 5:29 AM Shawn Yang<EMAIL_ADDRESS>wrote:

could you provide a screenshot?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/polkawallet-io/polkawallet-flutter/issues/210#issuecomment-779191611,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AS2TT4LO2ECM7PW2UPWF423S7EHQ5ANCNFSM4XRMPWRA
.

--
Jeremy Dallas
(587)500-4947
<EMAIL_ADDRESS>

I didn't see any picture in your relay message. Try replaying on github website, not in email.

This is the Tx confirm page, you can select transfer destination on previous page, just upon the amount input field.

Can you walk me through it because this is all I see

When I click transfer, the screenshot I first sent you shows up

When you click transfer, it should take you to the transfer page, where you can select target and input transfer amount:


testID added

Tnx for useful lib.  But I need to add "testID" functionality.

fixed name conflict


Introduce Mocha + sinon instead of Jasmine

Mocha + sinon seem to have better options for dealing with time and async.

After literally days of adding files and romoving them i've asked the wallaby Guru what i'm doing wrong in my wallaby config in wallabyjs/public#1065

ArtemGovorov is a legend and provided pull request #18
It seems ordering is important!
Going to merge and see if I can get any closer to making this conversion

The conversion is almost complete. There are issues getting the e2e to work though.
http://stackoverflow.com/questions/42839202/protractormocha-fails-suite-with-typeerror-before-browser-loads-sut

Looks like i'm not the only one who wants to do this angular/angular-cli#4071. Seems to be a feature request for ng test.
It would nice if angular-cli allowed you to generate the config with mocha as an alternative for both ng test and ng e2e, but I certainly get it that it's extra overhead.

merged as part of #24


Be able to store files in a cloud bucket.

It'd likely be a dramatically slower load due to network stuff but, it'd be helpful for load balanced instances using this. Nothing to stress now but a thought.

This is going to be pushed to it's own module once the persistence API changes, Closing.


[Profile detail] Tabs shown depending on company/startup choice

Profile detail view part of the #316

backend: after #334 no changes
frontend:
[ ] show appropriate tabs when company selected (point 2 at #316)
[ ] show appropriate tabs when startup selected (point 3 at #316)
[ ] show appropriate tabs when company and startup selected (point 4 at #316)

implemented in #323


Radzen.Blazor build failures and components not rendering in Visual Studio 17.6

Describe the bug
Radzen.Blazor fails build, and has other real cute silent failures, when using Visual Studio 17.6 (Release -- the old preview worked just fine).  Releated to razor issue #8718.
To Reproduce
Steps to reproduce the behavior:

Download source
Build source with VS 17.6

Expected behavior
Source builds.
Workaround
I've added some comments on #8718 with my workarounds.  Additionally, any components like tick.razor that have neither a .razor.cs file, nor anything other than a @code{} block, would simply not be called.  No errors, no warnings - the code was simply never called.
I resolved the Tick part by turning tick.razor into tick.cs; something like:
public partial class Tick : ComponentBase {
    // Insert copy/pasta from tick.razor
}

Hope this helps.

Hi @blake-fm,
This definitely looks as a regression in the .NET SDK. It seems the Microsoft team is fixing this issue with https://github.com/dotnet/razor/pull/8721
This change caused all kinds of problems though so we will closely monitor the progress and act accordingly.

It sure is.  Though, with the suggested structure, I have zero build issues on a fairly large project.  For now, it also includes the entire build for /Radzen.Blazor, with modifications.

This would solve the build errors indeed. We have bigger issues with our other products though :( Hopefully we find a workaround.

Very sorry to hear!  I've not seen the other products personally, but I do hope you guys are not forced to rollback and wait for too long.

Hi again @blake-fm,
Would you mind opening a PR with the changes you have made? Or at least tell us what files you have changed.

Sadly I was forced into a temporary hard fork (time constraints), and had to stop planning PRs from my local branch.  Reconciling back is not something I could achieve in a timely manner.
I saw you posted another @code{} only file, that had similar issues - those are the scary ones, what with the potential for almost entirely silent failures.  Good thing nobody does access control in components.. I hope?  But should be easy enough to regex find that one.
Beyond that, I haven't noticed any other types of silent failures - so if you're compiling, hopefully that's that.  FYI I did also submit the Tick issue, as a separate issue (https://github.com/dotnet/razor/issues/8737).

That felt like too much of a cop-out.  So, here's some actual effort:
^(?<![\s\S\r])((\s|\n|\r)*@(using|typeparam|page|inherits|inplements).*)*(\s|\n|\r)*@code

Results:

Will put up an at least partial PR asap.

The commit was pushed: https://github.com/radzenhq/radzen-blazor/commit/edf381c9142e136acaa337ed42a7a7e8f8be8e22
A Microsoft developer confirmed a new version of the .NET SDK would fix the regressions.

I'm sure you've tested thoroughly already, but I did a fresh clone and it built and ran just fine for me (very quick test though!).

Potentially related. My Pipelines on Azure failed today on 7.0.302 (for a project using Radzen.Blazor 4.11.2 library) with those errors:
##[error]C:\devOpsAgent\_work\1\s\Libraries\Radzen.Blazor\Microsoft.NET.Sdk.Razor.SourceGenerators\Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator\RadzenDataGridCell_razor.g.cs(566,162): Error CS0307: The namespace '__Blazor.Radzen.Blazor.RadzenDataGridRow' cannot be used with type arguments
C:\devOpsAgent\_work\1\s\Libraries\Radzen.Blazor\Microsoft.NET.Sdk.Razor.SourceGenerators\Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator\RadzenDataGridCell_razor.g.cs(566,162): error CS0307: The namespace '__Blazor.Radzen.Blazor.RadzenDataGridRow' cannot be used with type arguments [C:\devOpsAgent\_work\1\s\Libraries\Radzen.Blazor\Radzen.Blazor.csproj]
##[error]C:\devOpsAgent\_work\1\s\Libraries\Radzen.Blazor\Microsoft.NET.Sdk.Razor.SourceGenerators\Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator\RadzenGrid_razor.g.cs(3323,158): Error CS0307: The namespace '__Blazor.Radzen.Blazor.RadzenGrid' cannot be used with type arguments
C:\devOpsAgent\_work\1\s\Libraries\Radzen.Blazor\Microsoft.NET.Sdk.Razor.SourceGenerators\Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator\RadzenGrid_razor.g.cs(3323,158): error CS0307: The namespace '__Blazor.Radzen.Blazor.RadzenGrid' cannot be used with type arguments [C:\devOpsAgent\_work\1\s\Libraries\Radzen.Blazor\Radzen.Blazor.csproj]
##[error]C:\devOpsAgent\_work\1\s\Libraries\Radzen.Blazor\Microsoft.NET.Sdk.Razor.SourceGenerators\Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator\RadzenDataGridRow_razor.g.cs(491,162): Error CS0307: The namespace '__Blazor.Radzen.Blazor.RadzenDataGridRow' cannot be used with type arguments

It was first time running it on this SDK version. I updated my SDK locally to 7.0.302 - builds on my machine.


Supplier responds to a brief

Note:
This set of functional tests creates 3 new published briefs each time it runs.  Not sure if this is a problem or if we're happy to ignore it.

Create briefs; return users
Updated the create_and_return_buyer_brief() function so that it can create a publishable brief and (optionally) publish it.
Returning a user from user creation because we need to be able to associate a published brief with a buyer user.
Delete non-live briefs
Since the functional tests are constantly creating new briefs, this step deletes those that it's able to.
Live briefs can't be deleted, nor will expired briefs be able to.
Supplier responds to a brief

set up supplier users
set up a buyer user
publish a brief
sign in as a supplier
visit the brief response page (directly)
check for the correct title and requirements
answer brief response questions
submit response
check for success message

Should we be able to delete briefs that have ever been published? Is an expired brief one for an expired framework?

All the test published briefs are going to make it a bit of a mess for anyone trying to use preview for stuff (e.g. user lab sessions).
Maybe it would be OK to use staging for that, but the problem with staging is that it gets wiped every night, and it'd be nice to be able to set up some data somewhere and have it usable without getting drowned out by functional test noise.
We should be able to clean up the published briefs by calling the API directly to delete I think (might have to switch them back to draft first?) - if we can't do it right now then maybe that's something we should enable in the API.

@TheDoubleK at the moment we can't delete live briefs or move them back to draft by design. I'd be reluctant to add that ability just for the sake of the tests. It implies that it's a valid thing to do, which I don't think it is.
I can see a few alternative approaches we might want to consider.

Create specific routes in the API for the functional tests that are not available in staging or production
Have the functional tests delete the data directly from the database :exclamation: :exclamation:
Use staging for user research and script the creation of fixture data

Looking at this I think we should be able to move briefs back to draft by calling the API:
https://github.com/alphagov/digitalmarketplace-api/blob/master/app/main/views/briefs.py#L138

I don't think scripting fixture data for staging is a good solution - Kevin, Jacob, Catherine, Ralph or whoever should be able to set up the data they need for user research on an ad hoc basis without devs needing to get involved.

Returning a brief to draft after it's been made live seems wrong, is that by design or a bug?

I think it's by design and OK - the API should be able to do what it wants with its data, and updating a status to any allowed value is part of that.  It's up to the frontend apps to enforce what API calls actually get made though.  It's the same principle as checking user roles at the frontend apps - it's a level of "business logic" that the API doesn't need to be aware of.

OK sorry, I'm wrong - it can't be done, as designed by @allait:
https://github.com/alphagov/digitalmarketplace-api/blob/master/app/models.py#L889

I'm not mad on any of the three options for fixing it though...

After discussion elsewhere we will live with the published briefs.
So the only thing left to do is remove that @wip and check that the test passes OK I think.

:sparkles: I've run these tests against preview and can confirm they pass :sparkles:

Including the buyer dashboard one marked as @wip but that shouldn't be?

Those @wip scenarios are not implemented as yet

Ah OK, sorry.
:+1: to this then.

Hey @andrewchong, I forgot to replace the word brief in the Scenarios, but I'll open a new pull request that does it.


Pass in llm into ChatMemoryBuffer for condense_question chat engine

Description
Was looking at understanding how the chat engine works with the ChatMemoryBuffer (for #7765) and noticed that the LLM wasn't getting passed into the condense_question engine. PR passes it in so that the token limit can be set from it.
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] New and existing unit tests pass locally with my changes

@git-hamza this is an ancient PR -- the code has been moved/refactored since this. Its here
https://github.com/run-llama/llama_index/blob/762a45e13a28b3bff677b6901661bae582199cb6/llama-index-core/llama_index/core/chat_engine/condense_question.py#L95


Add Cargo cache to Travis

This allows to avoid rebuilding all deps on each CI run, thus significantly speeding up compilations.

Thanks!


Support bridge code in NuGet packages without having to reference all dependencies in web app

I started a discussion here, but I think it's worth adding here as a feature request.
Currently there doesn't seem to be a good solution to sharing code via NuGet packages. Even if JS is included in NuGet packages for Bridge libraries; the output JS will not be copied to the correct location in the Web project unless the NuGet package is explicitly referenced there.
It's not practical to have all web projects have direct NuGet references to the entire tree of NuGet dependencies from the Bridge code projects. Nor is it practical to have all code in a single solution.
I'm not really sure what a good solution would be, but if the JS for a project could be included in its assembly, then maybe it could be pulled out and dumped into the Bridge output folder during build?
I'm guessing you must already have something similar to this for bridge.js?

Yes, it is a right place for feature requests)
And yes, bridge.js is in bridge.dll and unpacked during transpilation. We will think about facilitating this process for Bridge libraries.
Will setting up the Bridge project referencing NuGet to copy the NuGet's JS into the Web project?

Will setting up the Bridge project referencing NuGet to copy the NuGet's JS into the Web project?

While our projects are small, this (or something similar) will work fine. But once our NuGets packages have dependencies on other NuGet packages, I think it'll break down quickly (in order to copy them all the way down, we'd need to be committed all JS files at every level, to include them in all NuGets that reference any given NuGet).
It's not urgent there's some solution now, but I do think there's great value in having some solution that allows nested NuGets easily.

I will just share some thoughts about your feature request here. Hope this helps in anything.
A problem in such approach would be naming conflicts. Although not likely to happen when outputBy bridge.json setting is 'Namespace', it would most likely happen if outputBy is class-based for example, and the user would have no control over it, as even two NuGet packages could conflict between themselves.
Other issue would be to identify between the project references which ones should be or should be not used as targets for Bridge Builder.
Otherwise, it sounds pretty straightforward to have Bridge builder, from a Bridge.DLL, output the correct JavaScript.
What seems more feasible in my opinion is, having the NuGet packages deploy not DLL files, but the .cs source files in a separate directory. This way you can both guarantee and give user control over name conflicts. Also conflicts with outpubBy='class' would not happen as instead of overwriting the files they will be appending (as it is the same single DLL being processed).
After all, the code is meant to be readable as the target product is a readable code, right?

A problem in such approach would be naming conflicts.

I don't think conflicts is a big issue. If people build packages with vague names, that's their fault and people will avoid their packages. That's not a million miles different to NuGets having same namespace/classes. It would be acceptable to me to fail a build if this happens.

Other issue would be to identify between the project references which ones should be or should be not used as targets for Bridge Builder.

I'm not entire sure what this means, but Id' say that any project being built by Bridge should have all of its dependencies checked for bridge embedded resource, and have them pulled out. I don't think it makes sense to reference a bridge-built NuGet/DLL and not have the scripts from it?

What seems more feasible in my opinion is, having the NuGet packages deploy not DLL files, but the .cs source files in a separate directory.

This sounds like it could work; though does mean committing the .cs files at all levels down to source control (since I don't think package-restore puts back content files). I don't think it's an ideal solution, but might be the best current option.
I'll try it out this afternoon and see if it works well.

Hi @DanTup !
We have implemented feature #413:

Translator should inject generated script to an assembly and if the assembly is referenced inside another project then extract embedded script to output folder

Please let us know if this works for you.

Excellent! One of my colleagues actually got some of this working using your plugin API; though I didn't get chance to thoroughly test it. Native support is even better!
I'll try to test this out next week and let you know if it's all working. I need to figure out what's changed in your repo that has broken our build server first! =D

I need to figure out what's changed in your repo that has broken our build server first!

Builder and Testing repos have been merged into Bridge - #405. Maybe, it is a case.

Builder and Testing repos have been merged into Bridge - #405. Maybe, it is a case.

That sounds likely - I saw the error was failing to find a dll in the build output, but didn't get chance to dig into it. Thanks!

@DanTup Sorry for buzzing, did you have a chance to try this new feature? We would very appreciate a feedback from you... )

@LeonidVeriga Sadly, not yet. Really busy at work this week (mostly our Bridge/React time is limited to Friday while we're prototyping). I'll do my best to find a little spare time, but if not it might have to be Friday.
If you can easily build a nupkg and mail it to me, that'd save me having to fix up Bridge on our buildserver and I might be able to get to it a little quicker (email is firstname @ lastname .com).

@DanTup I sent the package.
There is no rush, please take your time. We are targeting next Monday to release 1.9. Looking forward to your feedback.

Ok, I've managed to have a quick test of this; and it all seems to work as expected :) We now can build NuGets that don't directly bring the .cs files into our projects, but do output the required JS during builds :)
However, the version you emailed to me does seem to have a serious bug, I'll raise a separate case about that in case it's present in the current code (I'm hoping to get our buildserver building again today, so I'll be able to test this with latest code).

That is great! Thanks for testing and providing the feedback.


SP5 Cookbook: Add additional information to DateTime axis recipes

Question: Those two pages are all great on their own: https://scottplot.net/cookbook/5.0/DateTimeAxes/DateTimeAxisQuickstart/ and https://scottplot.net/cookbook/5.0/LinePlot/, however it's not clear how to mix the two. For instance, I have a scatter, and I just wish to add a single line on that scatter.
On page https://scottplot.net/faq/datetime/ it says "Use LINQ and DateTime.ToOATime() to convert DateTime[] to double[] before plotting" - do you mean DateTime.ToOADate? Fundamentally, I think date times are converted to numbers before plotting, but it's not clear from the documentation or source code (ScottPlot.PlottableAdder.Scatter<T1, T2>(T1[] xs, T2[] ys, Color? color = null) and ScatterSourceGenericArray) how this is done.
ScottPlot Version: 5.0.17
Code Sample:
Solution is kind of implied on https://scottplot.net/faq/datetime/ and I tried this:
namespace ConsoleApp1
{
    internal class Program
    {
        [STAThread]
        static void Main(string[] args)
        {
            ScottPlot.Plot plot = new ();
            plot.Add.Signal(ScottPlot.Generate.Sin());
            plot.Add.Line(0, 0, 1, 1);
            plot.Add.Scatter(new DateTime(2003, 10, 01).ToOADate(), 4);

            plot.Axes.DateTimeTicks(ScottPlot.Edge.Bottom);

            ScottPlot.WPF.WpfPlot wpfPlot = new();
            wpfPlot.Reset(plot);
            System.Windows.Window win = new() { Content = wpfPlot };
            win.ShowDialog();
        }
    }
}

And it works well.
I suggest:

Fix function name: ToOATime() should be ToOADate()
Making an update to https://scottplot.net/cookbook/5.0/Scatter/ScatterDateTime/ to add an example how to mix it with regular double values on x axis
Somewhere in the documentation or in code (for curious minds) (or as a comment to this issue) explain how the generic automatically converts DateTime to double?

This is great library and I've been bugging you guys lately😂
Thanks!

Hi @chaojian-zhang, thanks so much for bringing this up! I'll work to make that FAQ page describe the newer/simpler way to manage dates with ScottPlot.
For now, note that this is possible, and it doesn't require converting dates to doubles:
DateTime[] dates = Generate.DateTime.Days(100);
double[] ys = Generate.RandomWalk(100);
plot.Add.Scatter(dates, ys);

https://scottplot.net/cookbook/5.0/DateTimeAxes/

following-up, the information on https://scottplot.net/faq/datetime/ is specific to ScottPlot 4.1, but the current version of ScottPlot is 5.0 which has better support for DateTime which is why we don't need to do the complicated conversion to double anymore.
That FAQ page is out of date, and there's a banner at the top indicating that, but I'll make it a priority to update it and close this issue after I do 👍

Fix function name: ToOATime() should be ToOADate()

Done! 🚀

Making an update to https://scottplot.net/cookbook/5.0/Scatter/ScatterDateTime/ to add an example how to mix it with regular double values on x axis

Somewhere in the documentation or in code (for curious minds) (or as a comment to this issue) explain how the generic automatically converts DateTime to double?

Since 2 and 3 are similar, we can solve both by creating a cookbook recipe demonstrating how to convert DateTime[] to double[] using ToOADate() and demonstrate plotting the two types of data together

Awesome as usual!

I'm adding this cookbook recipe
// create an array of DateTimes one hour apart
int numberOfHours = 72;
DateTime[] dateTimes = new DateTime[numberOfHours];
DateTime startDateTime = new(2024, 1, 1);
TimeSpan deltaTimeSpan = TimeSpan.FromHours(1);
for (int i = 0; i < numberOfHours; i++)
{
    dateTimes[i] = startDateTime + i * deltaTimeSpan;
}

// create an array of doubles representing the same DateTimes one hour apart
double[] dateDoubles = new double[numberOfHours];
double startDouble = startDateTime.ToOADate(); // days since 1900
double deltaDouble = 1.0 / 24.0; // an hour is 1/24 of a day
for (int i = 0; i < numberOfHours; i++)
{
    dateDoubles[i] = startDouble + i * deltaDouble;
}

// now both arrays represent the same dates
myPlot.Add.Scatter(dateTimes, Generate.Sin(numberOfHours));
myPlot.Add.Scatter(dateDoubles, Generate.Cos(numberOfHours));
myPlot.Axes.DateTimeTicks(Edge.Bottom);


Windows event log

This PR integrates the scheduler and workers services with the Windows Event Log by using the win-eventlog package. We still log on Prometheus, the two reporters are combined.
Windows services cannot log onto standard output/error, so when used as services, the workers and the scheduler use a file formatter for Prometheus logging.
The worker doesn't expose Prometheus cmdliner options, so does it make sense to even use Prometheus for logging?
Debug events are too verbose and are not reported into the Windows event log.

I think I forgot this, I'll do a fixup of the last commit.
diff --git a/bin/worker.ml b/bin/worker.ml
index 0102a85..ebf4bf1 100644
--- a/bin/worker.ml
+++ b/bin/worker.ml
@@ -43,7 +43,7 @@ let update_normal () =
   Lwt.return (fun () -> Lwt.return ())

 let main default_level ?formatter registration_path capacity name allow_push prune_threshold state_dir obuilder =
-  setup_log ?formatter default_level "ocluster-worker";
+  setup_log ?formatter default_level name;
   let update =
     if Sys.file_exists "/.dockerenv" then update_docker
     else update_normal

Ok, I've now added the DLL that Windows Event viewer needs to print the logged messages nicely. It needs to be registered with Windows:
set REG_DLL_PATH=%PREFIX%\lib\ocluster\dllprovider.dll
set REG_PATH=HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\EventLog\Application
set REG_WORKER_PATH=%REG_PATH%\%WORKER_NAME%
set REG_SCHEDULER_PATH=%REG_PATH%\ocluster-scheduler

reg ADD "%REG_WORKER_PATH%" /v CategoryCount        /t REG_DWORD /d 0x00000001
reg ADD "%REG_WORKER_PATH%" /v CategoryMessageFile  /t REG_SZ    /d "%REG_DLL_PATH%"
reg ADD "%REG_WORKER_PATH%" /v EventMessageFile     /t REG_SZ    /d "%REG_DLL_PATH%"
reg ADD "%REG_WORKER_PATH%" /v ParameterMessageFile /t REG_SZ    /d "%REG_DLL_PATH%"
reg ADD "%REG_WORKER_PATH%" /v TypesSupported       /t REG_DWORD /d 0x00000007

reg ADD "%REG_SCHEDULER_PATH%" /v CategoryCount        /t REG_DWORD /d 0x00000001
reg ADD "%REG_SCHEDULER_PATH%" /v CategoryMessageFile  /t REG_SZ    /d "%REG_DLL_PATH%"
reg ADD "%REG_SCHEDULER_PATH%" /v EventMessageFile     /t REG_SZ    /d "%REG_DLL_PATH%"
reg ADD "%REG_SCHEDULER_PATH%" /v ParameterMessageFile /t REG_SZ    /d "%REG_DLL_PATH%"
reg ADD "%REG_SCHEDULER_PATH%" /v TypesSupported       /t REG_DWORD /d 0x00000007

There's just one type of message, the simplicity is intentional.

I now think that logging should use TraceLogging on Windows. There are examples of a TraceLogging easy-to-use wrapper with a dynamic implementation that doesn't require to register all logging messages. There are also examples of backend for TraceLogging using LTTng, a library available on Linux, that can help if someone tries to build an OCaml wrapper for TraceLogging.


Add possibility to style buttons with a class

I added a new attribute button-class to set a custom class for the ngMaterial buttons.
I think this will fix #18

Ok, i see this isn't working like expected ...

Have you understood why it isn't working? Sorry I have little time these days.

Yes i think it has something to do, that the material directive changes the classes on compilation.

Ok, keep me posted on this one then


Fix background color and text alignment in heroes with no image

Fixes https://GHE/CFGOV/platform/issues/3276
Changes

Move background-color rule outside of if img condition
Always output <div class="m-hero_image-wrapper">, even if empty, for correct text alignment

Testing

Create a Sublanding Page
Add a Hero
Set some text for the Heading and Body
Remove empty default link from the Links list
Add a valid hex color in the Background color field
Click Preview and see a hero with the specified background color and expected text alignment

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the CFPB development guidelines
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Browsers

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Internet Explorer 8, 9, 10, and 11
[ ] Edge
[ ] iOS Safari
[ ] Chrome for Android

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

Maybe we don't want notes to ourselves in the markup though.

Eh, probably not worth the extra logic in the template either.

Why do we add a required link field into the hero by default when it's first added?

I believe this to be a standard behavior of the Wagtail ListBlock that we have no way to workaround. Asking in the Wagtail Slack if anyone knows how to avoid it.


[FEATURE] Render goldmark taskList checkboxes

I have checked all the prerequisites below and I don't see this is available

[x] Read the README.md
[x] Have the extended version of Hugo installed
[x] Used the exampleSite's config.toml as a reference

Describe the feature
https://github.github.com/gfm/#task-list-items-extension-
The taskList extension for goldmark markdown (enabled by default in hugo) produces the following html:

<input disabled="" type="checkbox"> foo

<input checked="" disabled="" type="checkbox"> bar

I can see these in the generated html for my article, but they are not rendered on the website. It seems there are a few things that prevent it from being displayed but I'm not entirely sure what.
First -webkit-appearance: none seems to be set. I also had to add display: initial on the element to be able to see it.
Then it seems github also sets list-style-type: none, which does make it look better.
I'm not sure if they have anything else used to move it slightly to the left and make the space less awkward.
Of course github doesn't need to be copied :)
Desktop (please complete the following information):

OS: Linux
Browser: Firefox nightly 111.0a1

@Ppjet6, this should now be resolved. please test


support for new GPIO_SET_OUTPUT options

This is needed to prevent a race condition triggering a device while configuring it. For example, you can end up triggering a parachute release on boot, or a camera shutter release.

Rebased and applied, thanks!


Publish library versions as JSON for documentation

Sought some advice and clarification: https://nvidia.slack.com/archives/C01RP7T89PY/p1655920435985939

Closing due to limited traction and Karl's comment:
They should be, so I'm not sure if we need to do anything specific here, but wanted to make sure we didn't miss adding a crucial step to the new pipelines (if necessary.)


Centralise feature flags into sub-package

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c6ce460) 16.12% compared to head (bcb52df) 15.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   16.12%   15.04%   -1.09%
==========================================
  Files           6        5       -1
  Lines        1110     1097      -13
  Branches        3        2       -1
==========================================
- Hits          179      165      -14
- Misses        931      932       +1

Files
Coverage Δ

jobrunner/src/jobs/ProcessMediaJob.ts
11.53% <100.00%> (ø)

jobrunner/src/index.ts
19.08% <50.00%> (+0.22%)
:arrow_up:

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


gpg-agent failing to start in supervised mode on Ubuntu 18.04

Currently the gpg-agent is failing to start in supervised mode (required to properly sign packages, import keys, passphrase) with Ubuntu 18.04 which uses gpg-agent v2.2x, which is based on systemd internally, and will probably be an issue for upcoming Buster (Debian 10).
Issue has been isolated to salt/utils/process.py function daemonize_if and it calling daemonize(False) which then does not redirect stdout, stderr.  Faking out the daemonize_if with a 'return' works starting gpg-agent correctly but they highstate will fail since no daemonizing  when required.
Due to Python multiprocessing issues with redirection as highlighted in function daemonize, where the first multiprocessing daemon redirects successfully, but a subsequent multiprocessing daemon redirection of that daemon will blow up.  Hence need to allow for an single use indication (opts) that starting up and allow an initial daemon with redirection this once for an initial redirection with daemonize_if.
The initial daemonization during init is due to old System V init process, but with systemd now prevalent on most Linux distributions, we should add a check for systemd present and allow it to daemonize the salt startup instead of init process: but that is for the develop branch.

Upon a night's reflection, the daemonize_if may not be the problem, but shows similar, given that the issue occurs with a steady state master and minion and is not related to startup.
Perhaps there may be some method to decide on whether the daemonization is being done from another multiprocessing daemonized process and attempt to avoid the issue described above.
Further this occurs with the method of invocation on the master, therefore something has to be passed to the minion in the command messaging to the minion.

revised the gpg-agent_kill.sh to also check that the script pid was not the ppid of the gpg-agent process getting killed, that is check pip and ppid since the script can have a sub-shell, also updated for $BASHPID as opposed to just $$, better check for script pid.
This could explain the randomness of the gpg-agent sometimes working or not, depending on the returned list from $(ps -ef | grep -v 'grep' | grep gpg-agent)
Testing with nightly builds over the weekend


Feature Request: A way to build a shared library (.dll or .so) instead of an EXE

This has been discussed as a possibility.
I would like to be able to output a shared library (e.g. a .dll on Windows, .so on Linux, etc.) from a python script instead of building a --standalone .exe.  I'm thinking that there would need to be some way to let nuitka know the exported functions and types within a main module that is to become the DLL file.

Yes, it's good, lets keep track of it here.

As for the interface, I feel a .pyi file that you create should be used, but we would have to have it type annotated to something that Nuitka can handle, e.g. int, and something opaque passed through, etc.


How to configure the jsfmt to the line break I want?

I'm working with React Native these days, so instead of
var {Text, ListView, View, Image, StyleSheet, TouchableHighlight, } = React;

I want
var {Text,
    ListView,
    View,
    //...
    TouchableHighlight } = React;

I've walked through the esformatter preset files but I can't understand it well... So any help will be appreciated.

Something like this should do the trick for your particular line of code.
{
    "options":
    {
        "lineBreak" : {
            "after": {
                "ObjectPatternComma": 1
            }
        }
}

You can read more about your configuration here:
https://github.com/millermedeiros/esformatter/blob/master/doc/config.md
The ast parser is very helpful in situations like this.

Yes, it works! Thank you!
I also installed esformatter-var-each to make the new configuration work.


Enable support for API level below 16(android version 4.1)

I have discussed you on dev.to about this problem. Now I have modified it to support for below versions.

I'll check your PR later today

@AbdulhakimZ v0.1.1 is available


remove back to school banner

This PR removes the Vue School Back to School banner from the top of Vuejs.org, which was added in PR#2688, and later altered in this PR#2694.
Please note that the PR brings back the BLM banner, visuals can be seen here.

👍


resources: fix failure to check returned errors from SetControllerReference

This also makes the error logging calls consistent between the calls to
SetControllerReference and the API calls to create/update/whatever the
resource. This eliminates the functions that existed to create a
resource type and then set the controller reference as it was easier
to inline these "two line" functions than plumb error handling through
everything.
NOTE: I expect this may cause the CI to fail. If so, that's a good thing. :-)
But I want to see it first.

Yup it failed. This means that issue #87 is on the right track and my recent changes in this area were incorrect. The good thing is that the CI actually catches a problem (tests were added as part of that work) once we add the appropriate error checking to the code.
Now's just a matter of deciding what to do for long term behavior wrt namespaces.

Obsoleted by #100. Closing.