Feature: support variable naming in pkg_deb

Description of the problem / feature request:
pkg_deb takes a version parameter for setting the version of the version of the generated deb-package.
It would be appreciated if this parameter would support "stamping", so that an external script (--workspace_status_command) can dynamically generate this version.
Similar to how the container_push rule supports stamping in it's tag parameter.
Feature requests: what underlying problem are you trying to solve with this feature?
Simplify creation of pkg_debs, if this was supported I wouldn't need to save the version to a file and use the version_file parameter.
What's the output of bazel info release?
release 0.22.0

I think there are already some mechanisms to stamp package yield, say using a dynamically generated version_file which consumes workspace_status. However, doing so means we have to write such genrule everywhere. It would be nice to have it integrated in the pkg rules directly.

Whatever mechism designed must work for pkg_rpm() as well.
What we do internally at Google is allow $var substitutions in the version strings and then provide those variables in the builds that make distributable versions.
Doing this well probabl requires some design. Open questions:

should we jus allow variable substitution from the environment?

Personally, I don't like it. Setting environment variables is not as obvious as a flag passed to bazel.

should it only be from workspace_status_command?

Keep it consistent with other rules using variables from workspace_status_command would be great.

What do people even want as paramaterizable version numbers? Is a date/time based substitution sufficient if you want it automatic? If not, why is it better to parametirize it than to update the BUILD file?

Updating BUILD file on every release sounds like toil. Also introducing changes to codebase during the release is problematic -- consider the case where a cherry-pick is needed for an old release branch, such change on the BUILD file may prevent the cherry-picked patch from being applied.

What I could see is a shared attribute env_vars:string_list.
If you set that on any rule you get the dependency on stable_status and enable the lookup, but only for those variable listed. That nicely documents that the rule depends on something outside the BUILD file (perhaps a default can be specified there). I could also see this variable expansion extend into the template and spec files.
This needs a better design with some examples before implementing it. Any implementation should also cover all the rules, not just one package type.

Indirectly related to this, when a debian package is created, it's currently named with the version,
https://github.com/bazelbuild/rules_pkg/blob/098022cedd0d249b28eac933bb0813dccfceb442/pkg/pkg.bzl#L381
There are tools that assume that the file is named in this way, e.g., in dak:
https://github.com/Debian/dak/blob/master/daklib/regexes.py#L126-L128
https://github.com/Debian/dak/blob/master/dak/import.py#L116-L124
If the version isn't known till build time, then it can't be used as part of the output file. Ideally, there would be a way to output a tar file with the files named correctly based on version as well.

More flexibility in output file naming is part of #193, #143, and #101. The solution to that proposed in #198 will also handle this stamp case.

#198 was merged, but it's not possible to use the functionality with pkg_deb

Yes. File renaming from configuration in all rules is on my list. Getting
date and time stamps in the name is still a difficult task.
That is simply not available at analysis time. I have an idea about how to
hack around that but exploring it is not a priority for me.
On Mon, Dec 7, 2020 at 6:55 PM Terin Stock<EMAIL_ADDRESS>wrote:

#198 https://github.com/bazelbuild/rules_pkg/pull/198 was merged, but
it's not possible to use the functionality with pkg_deb
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_pkg/issues/53#issuecomment-740253543,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXHHHAQLN2VLKNVAUNE323STVTQLANCNFSM4IBLVJIA
.

I ended up calling out to [dpkg-name[(https://manpages.debian.org/buster/dpkg-dev/dpkg-name.1.en.html) as part of my releases pipeline, so I was running into the normal issues with the version not being available at analysis time.

Version should be easy. Timestamp is the hard part.
On Mon, Dec 7, 2020 at 11:28 PM Terin Stock<EMAIL_ADDRESS>wrote:

I ended up calling out to [dpkg-name[(
https://manpages.debian.org/buster/dpkg-dev/dpkg-name.1.en.html) as part
of my releases pipeline, so I was running into the normal issues with the
version not being available at analysis time.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_pkg/issues/53#issuecomment-740367618,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXHHHCL4O6FYJUKLNZPD2TSTWTPRANCNFSM4IBLVJIA
.

I too am interested in this functionality, specifically being able to produce a tar file that contains version info provided by the workspace status. Eg: my-tarball-1.2.3.tar.gz

I too am interested in this functionality, specifically being able to produce a tar file that contains version info provided by the workspace status. Eg: my-tarball-1.2.3.tar.gz

I'm going to declare this fixed.  It was not about "stamping" as the other bazel rules use it (time stamping of the artifacts).  This was about injecting variable names into the output artifact name.
The examples in https://github.com/bazelbuild/rules_pkg/tree/main/examples/naming_package_files
show how you can inject a variable from the command line into the names.
The original request was to extract variables form the workspace status output. I'm not going to build that because it is impossible to do it well. You have to parse the file during the execution phase, while the techniques we already have let you get the variable values at analysis time. Having it at analysis time lets us pass the information up in providers so other rules can act on the output sensibly.
Part of this discussion talked about time stamping, which is a different need.  #288 adds an implmentation of --stamp and the stamp attribute for pkg_tar. As soon as that is in I can add it for the others.

If package version is available in workspace-status files, using pkg_deb is still too cumbersome unless I am missing something. I need to provide the same version string via two mechanisms:

version_file
package_file_name + PackageVariablesInfo

If it is possible for pkg_deb to get the version number from version_file when constructing the package_file_name, it would make the most common use-case very convenient.

It is not possible to get elements of the file name from the version_file. That would require reading the file at analysis time. The way we will have to work this is to generate the version_file from PackageVariablesInfo, or from attributes in the rule instance.

Thanks for the quick response!
Would it be possible to provide an example for how to use pkg_deb if version is available in workspace-status files? Most (if not all) use-cases do not need fully custom file names. We just need a properly named output file.

Why would your version ever be available in the workspace status file?
If you want to specify it externally to the BUILD files, define a string
flag and set it from the command line.
Then write a rule that takes the flag and writes the version file.
Take a look at
https://github.com/bazelbuild/rules_pkg/blob/41a00ee70e7ec5eafe77e9fc21e042fde39a5339/examples/naming_package_files/BUILD#L121
for an example of creating the flag.
From that you could write a rule that also gets the flag value and the does
ctx.actions.write to create the version file.
On Tue, Jul 13, 2021 at 12:57 PM Alok Priyadarshi @.***>
wrote:

Thanks for the quick response!
Would it be possible to provide an example for how to use pkg_deb if
version is available in workspace-status files? Most (if not all) use-cases
do not need fully custom file names. We just need a properly named output
file.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_pkg/issues/53#issuecomment-879248972,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXHHHAQ7WIOOHPZNHMX2ODTXRV5XANCNFSM4IBLVJIA
.

I think it is pretty common to use --workspace_status_command to generate version number based on git tags:
bazel build --workspace_status_command="echo STABLE_PKG_VERSION $(git describe)"

Generating a version file is trivial using a genrule. I guess you are suggesting a custom rule instead of the genrule that would do both - provide PackageVariablesInfo and generate version file?

workspace_status is probably the worst way to pass build time variables like the package name. Put them on the command line as string flags. That makes them available during analysis instead of execution time.

The nice thing about workspace_status is that it can be added to workspace bazelrc which works for both - developers and CI - without any additional setup. I am not sure if CLI flags can be made to work without a wrapper script around bazel.
If it is not possible to produce a properly-named deb file, I guess another option is to rename the file before uploading to the apt repository. I will look into adding this step to the upload script.

But the bottom line is that there is a basic bazel limitation to using the
workspace file to name an output file. So don't waste your time trying to
make that work.
On Tue, Jul 13, 2021, 3:40 PM Alok Priyadarshi @.***>
wrote:

The nice thing about workspace_status is that it can be added to workspace
bazelrc which works for both - developers and CI - without any additional
setup. I am not sure if CLI flags can be made to work without a wrapper
script around bazel.
If it is not possible to produce a properly-named deb file, I guess
another option is to rename the file before uploading to the apt
repository. I will look into adding this step to the upload script.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/bazelbuild/rules_pkg/issues/53#issuecomment-879350015,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAXHHHHNR5MOZOOVRDVTXUDTXSJBTANCNFSM4IBLVJIA
.

Understood - thanks for the pointers!


Marshal returns a string

Hi!
Thanks for make this library! I've been using it and it is great! I just have a doubt.
When marshaling data to JSON this is returned as a string and I don't know if it's better to handle decimal numbers as strings or why this marshaling is happening in this way 😮

Hi,
Marshaling JSON to a string is preferable for high-precision decimals to avoid precision loss during unmarshaling (you can check this SO question. I believe this is the default behavior for most decimal libraries

!> Hi, Marshaling JSON to a string is preferable for high-precision decimals to avoid precision loss during unmarshaling (you can check this SO question. I believe this is the default behavior for most decimal libraries
Wow! Thank you. That make sense to me!


euphoria-flink: caching states

AbstractWindowOperator which is part of the Euphoria's RSBK implementation for the streaming flink executor caches once retrieved states per key/window in memory. While this seemed a good idea initially, it turns out to be problematic when a lot of different keys with lot of different windows are open - this is easily achievable with time-sliding for example. Further, it turns out that caching the state objects doesn't bring much!

We shall rework the window operator such that it avoids maintaining the map and thus preventing out-of-memory errors.
Further we shall ensure that the state objects are not unnecessarily created multiple times when processing a given input element.

When not caching state instances, it appears worth while to avoid frequent translation of euphoria storage descriptors into flink state descriptors. As part of the initialization of the state descriptors and the state storage objects, flink's type inference and serializer initialization is at work, adding constant overhead per element/window/state to a euphoria flow, which on an equivalent program is present only once at the start of the program.
I've pushed some experiments into the brach pete/experimental-state-descriptors.

This was resolved by #69


CD for ava-issue-handler and closing issues automatically

Hi. First of all thanks for this solution. Having a lot of fun trying it out at LEGO together with shopfloor colleagues.

If I would like to make some minor adjustments to the ava-issue-handler Lambda function, how do I deploy it? The preconfigured codecommit -> codepipeline seems to only deploy the frontend with Amplify. Should I bundle a zip myself and upload on the console?

I succeeded in raising issues in an automated fashion when a PLC tag reads an error code. Now I need to close issues automatically when the error code goes back to zero. How would you recommend doing this? It seems I need the complete random ID before I can close, so I need to do a quick query before a mutate on UpdateIssue is possible? If I wanted to extend the AppSync-schema and add a mutation to simply close all issues for a particular device, how would I go about doing so?

Thanks for contacting us @binaryPUNCH
For your questions,

you can download the source code from GitHub, and when you make a change, you can build the source code and deploy the zip file to Lambda function.
Do you use Amazon Virtual Andon UI to raise issues and update issue or you are sending messages to IoT topic directly? In either case, if you want to close every issues related to a specific device, as you mentioned, you might need to call GraphQL APIs several times or update (or create) the resolver.

Also, we've updated this solution to v2.0.0, so if you are interested in the latest version, you can deploy the new stack with the latest template which provides more flexibility to update the solution. You can refer to the latest information here.


clear metrics api add

Also a general comment, please provide pseudo-code and link to issue(s) in the PR header.

Way to use clear_metrics api -
metrics = api.clear_metrics()
metrics.choice = 'ports'
metrics.ports = ["p1", "p2"]
api.clear_metrics(metrics)

With the use cases detailed in PR (#234) where is the need for this API?
Specifically what are the use case(s) where a user would want to clear metrics that isn't met by PR 234.

Agree with @ajbalogh.  Perhaps we can park this till we really have a use-case for it?

Closing this PR until specific use cases dictate a need for it.


[Playground] [Infrastructure]: Removing the google storage client from python scripts

fixes #22388
@olehborysevych
Removing the google storage client from python scripts and using the cloud datastore client

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @pabloem


Think about React folder structure

Look for examples of how to organize the folder structure in a React project.
Keep in mind that there has to be a place for tests, and unit and e2e test should be in separate folders.
Also keep in mind that we are going to use Storybook.
Right now you can see in the app readme our basic folder structure given by astro.

@ehdlg Post here the examples or your proposals for the folder structure here, so we can discus on them and then decide.
An example would be the react atomic design.

Here are my proposals:
First proposal:
/
├── src/
│   ├── components/
│   ├── layouts/
│   ├── pages/
│   ├── tests/            // Folder for all tests
│   │   ├── unit/         // Folder for unit tests
│   │   │
│   │   └── e2e/          // Folder for end-to-end tests
│   │
│   └── stories/          // Folder for Storybook
└──

Second proposal:
/
├── src/
│   ├── components/
│   ├── layouts/
│   ├── pages/
│   ├── unitTests/        // Folder for unit tests
│   │   └── ...
│   ├── e2eTests/         // Folder for end-to-end tests
│   │   └── ...
│   └── stories/          // Folder for Storybook
└──

@ehdlg

/
├── src/
│   ├── components/
│   ├── layouts/
│   ├── pages/
│   ├── tests/            // Folder for all tests
│   │   ├── unit/         // Folder for unit tests
│   │   │
│   │   └── e2e/          // Folder for end-to-end tests
│   │
│   └── stories/          // Folder for Storybook
└──

I like more this approach, but it needs more description inside the components folder.

Reminder for when reviewing this.
Add a folder for models (for typescript types and interfaces)
The tests folder goes outside src.

Merged documentation in #142


ZTE H3600 V9  not supported

raceback (most recent call last):
File "/Users/macbookpro/Downloads/zte-config-utility-master/examples/decode.py", line 194, in
main()
File "/Users/macbookpro/Downloads/zte-config-utility-master/examples/decode.py", line 49, in main
payload_type = zcu.zte.read_payload_type(infile)
File "/Users/macbookpro/Library/Python/3.10/lib/python/site-packages/zcu-0.4.0-py3.10.egg/zcu/zte.py", line 56, in read_payload_type
File "/Users/macbookpro/Library/Python/3.10/lib/python/site-packages/zcu-0.4.0-py3.10.egg/zcu/zte.py", line 48, in read_payload
ValueError: Payload header does not start with the payload magic.
macbookpro@192 zte-config-utility-master %

Updated

Any updates?

error for h3600 v9
decode.py message
"ValueError: Payload header does not start with the payload magic."
for h3600tool.py message
"Wrong encrypted file header"

I've seen examples where the config.bin is Base64 encoded, so needs decoding before this tool can read it. Can you upload your config.bin for me to test?

Hey @mkst. You can use my config.bin for testing.


feat: public ip resolution from domain name

this works if you happen to have a domain name, and don't want to type in the IP; or if https://api.ipify.org/ doesn't return the correct IP for you ;)

Thanks for the change!

Oh did not see that you are returning the v6 address if the v4 could not be resolved. Imho IP v6 is not supported by the server. I'm going to remove this fallback


to_log() should support any legend field

I would like to export any legend field as a list, or as an integer log.

This has been done — export as a sampled array.


Ci Failure for loopback-android-getting-started

see #25

@siddhipai , the PR #25 has been landed.  Is it good to close? Thanks.


more typed gdscript

Changed: The icon image in Trenchbroom_game_config_folder is now loaded as texture, and converted to image upon saving. Could not figure out how to preload file as image directly.

Nice, thanks- I was wondering if the image format would be a stumbling block. If memory serves I went with using image directly because of some concerns about different texture types and their interfaces, but this seems to work fine so I'm happy to go with it.


Regarding MSTRG tag

Hi Developer,
I saw that in some cases, the sam MSTRG tag is tagged onto two different gene names in the GTF output for merging the transcripts from all samples. Is that right? Also, how does prepDE.py calculate such that its final gene count and transcript count output files consider the mentioned case?
Thank you.

This could happen in a couple of cases:

when a small gene is location-embedded within another gene (e.g. within an intron of another gene) and sometimes due to incomplete/partial splicing (or intron retention?) StringTie may assemble transcripts covering both the embedded gene and the exons of the encompassing gene
when one ore more assembled transcript is stretching across multiple adjacent loci; such a chimeric transcripts can be assembled by if, for example, there are read alignments that are [incorrectly] crossing the intergenic space between two genes which are close together on the genome

If could be useful to load the alignments (and/or the GTF) in a viewer to see for yourself which of the above are the case for your genes of interest.
And to your last question -- obviously the read counts for the genes and transcripts are going to be affected accordingly, prepDE doesn't care about gene names, it only sees the gene IDs and the transcripts with coordinates and coverages as given in the GTF.

Thank you for your reply. In that case, does it also mean that I can consider them as noise in my data? I think without coordinates information, it will be a painful process to map the MSTRG IDs in the final gene count output to a reference GTF file.

Just to show you an example:

Hi developer, I guess prepDE will assign the same MSTRG tag for genes that falls within the same region / genes that falls in the same genomic location but one is on the plus strand and the other on the reverse strand.

No, that should not happen - only exon overlaps on the same strand are considered when StringTie (and other programs like gffread etc.) groups transcripts under the same locus/gene.
As for the example you posted above, you should take a look at the transcripts assembled in that area for MSTRG.54661. The two genes there are on the same (forward) strand, and I am pretty sure that there are alignments/transfrags that overlaps both loci, that's why StringTie created a single large locus called MSTRG.54661 which encompassed both genes.

I think without coordinates information, it will be a painful process to map the MSTRG IDs in the final gene count output to a reference GTF file.

Yes, most of the time data are noisy, and if the experiments were not planned properly it might get "painful", for example, to remap IDs between separate analyses which should've been done together in the first place etc.

How do you deal with cases like this? If I found a set of genes tagged with MSTRG tags only, and some of them have difficulties assigning gene names, say, MSTRG.54661 tag that encompassed both genes, how would we like know which is the gene that which is expressing high, gene 1 or gene 2? Coordinate information are already lost, either in ballgown output or prepDE output (samples ran in the same analysis).


[5.8] Simplify code Arr::wrap()

Simplifies the code a little bit.
Let me mention that according to official docs of php :

[7.2.0] is_object() now returns TRUE for unserialized objects without a class definition (class of __PHP_Incomplete_Class). Previously FALSE was returned.
--

But we do not have to worry about those edge cases, since unserialized objects without a class definition can only happen when spl_auto_loader is not used.
In other words, in presence of the composer autoloader that can never bite us.
https://stackoverflow.com/questions/6574984/php-problem-with-php-incomplete-class
so we can just pretend that is_object() behaves consistently between php7.1 and php7.2

Thanks, but actually this is not true. This may still break if an object is deserialized but the class no longer exists.

and what about gettype($var) === 'object' ?

Honestly, there's nothing wrong with the existing code.

I just wanna know it for the rest of the contributions


Unable to use SDNS stamp

I'm trying to use a SDNS stamp from dnscrypt-proxy serverlist, needless to say, it probably is valid
But in the logs:
socksLogger2023/08/09 20:45:06 2023-08-09 20:45:06 [E]: server: illegal base64 data at input byte 123

Using termux and proot to run linux armv7 build

please send your config.json i will look into it

It's pretty much the defaults except for the DNS.
I tried multiple SDNS stamps (dnscrypt protocol) from this link: https://dnscrypt.info/public-servers/
Works if I use a DoH

Yes i tested it its clearly a bug i will fix it within a day

unfortunately official sdns v2 library doesnt support custom dialer in golang. so i need help to resolve this issue

unfortunately official sdns v2 library doesnt support custom dialer in golang. so i need help to resolve this issue

I'm not familiar with golang, but assuming "hacking around" the library internal APIs is not a suitable solution, isn't it just better at this point to create an issue in sdns repository?

unfortunately official sdns v2 library doesnt support custom dialer in golang. so i need help to resolve this issue

which one do you mean dnscrypt-proxy or sdns ?
both are based on Go and they are accessible for future improvement.


Question: Possible simplification in mutex.h?

Hello, I have a question regarding the code at include/sys/mutex.h: https://github.com/zephyrproject-rtos/zephyr/blob/1337f7fe245b8dbdf0d70699f74d35589ed1ec61/include/sys/mutex.h#L157
Can we simplify this.... (see below)
static inline int sys_mutex_unlock(struct sys_mutex *mutex)
{
	if (mutex->kernel_mutex.lock_count == 0) {
		return -EINVAL;
	}

	if (mutex->kernel_mutex.owner != _current) {
		return -EPERM;
	}

	k_mutex_unlock(&mutex->kernel_mutex);
	return 0;
}

....To this?
static inline int sys_mutex_unlock(struct sys_mutex *mutex)
{
	return k_mutex_unlock(&mutex->kernel_mutex);
}

According to the documentation k_mutex_unlock() already returns EINVAL and EPERM so these additional if() statements look redundant to me.
k_mutex_unlock() docs: https://docs.zephyrproject.org/latest/reference/kernel/synchronization/mutexes.html#c.k_mutex_unlock

Another side point:
sys_mutex_unlock() docs: https://docs.zephyrproject.org/latest/reference/kernel/synchronization/mutexes.html#c.sys_mutex_unlock
sys_mutex_unlock() returns -EACCESS (typo in docs, should be -EACCES no?), when using k_mutex_unlock() this is not true. Does this apply to z_sys_mutex_kernel_unlock()? I could not see it's source so am not sure.

I am now also thinking that in lib/os/mutex.c: https://github.com/zephyrproject-rtos/zephyr/blob/074dbb9982ad2e4158b92c9aff174969b72402c3/lib/os/mutex.c#L55
Can be simplified from:
int z_impl_z_sys_mutex_kernel_unlock(struct sys_mutex *mutex)
{
	struct k_mutex *kernel_mutex = get_k_mutex(mutex);

	if (kernel_mutex == NULL || kernel_mutex->lock_count == 0) {
		return -EINVAL;
	}

	if (kernel_mutex->owner != _current) {
		return -EPERM;
	}

	k_mutex_unlock(kernel_mutex);
	return 0;
}

To this:
int z_impl_z_sys_mutex_kernel_unlock(struct sys_mutex *mutex)
{
	struct k_mutex *kernel_mutex = get_k_mutex(mutex);

	if (kernel_mutex == NULL || kernel_mutex->lock_count == 0) {
		return -EINVAL;
	}

	return k_mutex_unlock(kernel_mutex);
}

Here I am assuming the file at kernel/mutex.c defines the k_mutex_unlock() call https://github.com/zephyrproject-rtos/zephyr/blob/074dbb9982ad2e4158b92c9aff174969b72402c3/kernel/mutex.c#L212

sys_mutex_unlock

yes, this can be simplified. The error checking in kernel/mutex.c came after, so now we have it duplicated. Please submit a PR :-)


reference ruby/setup-ruby for cache

Why:

What's being changed:

Check off the following:

[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

T

T

https://youtu.be/AHlL3j86be0

https://youtu.be/AHlL3j86be0

@lauraGgit Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@lauraGgit Thanks for opening a PR 👍 Please fill out the pull request template in the top comment in this pull request, then we'll get this up for review!

@janiceilene reviewed the pr template. should be good to take a look

@janiceilene reviewed the pr template. should be good to take a look

@lauraGgit Can you answer the Why: and What's being changed: in the top comment to help us better understand your suggested changes?

@lauraGgit Can you answer the Why: and What's being changed: in the top comment to help us better understand your suggested changes?

@janiceilene why currentlythe caching module doesn't quite work for the ruby, what so point toward an alternate implementation of caching for ruby that speeds up the builds.

@janiceilene why currentlythe caching module doesn't quite work for the ruby, what so point toward an alternate implementation of caching for ruby that speeds up the builds.

It looks like our new action inadvertently closed this 🙃 Sorry about that! Reopening and triaging this for review 💛

Alomaisi

Thank you!


Unable to make an order with the market.indexPrice ?

How to get the price for long or short ?
To pass an order i'm using getMarket.indexPrice but order cannot pass without using a multiplier (0.1%)

	const accounts = await getAccounts();
	console.log(accounts);

	const market = await getMarket("MATIC-USD");
	console.log(market);

then
const order = await placeOrder(
	"MATIC-USD",
	"BUY",
	"MARKET",
	"FOK",
	false,
	parseInt(accounts[0].freeCollateral / market.indexPrice).toString(),
	(market.indexPrice * 1.002).toFixed(size),
	plus30m
);
console.log(order);

What can I use as price to a market order ?
Transaction is systematically expired

Probably because it can round it down below market price. You can try something like that, it worked for me:
Math.round(market.indexPrice * 1.001) + 1


"Last version time" sorting issue

I encountered an issue with sorting by the "Last version time" in ascending and descending order, where the minimum open issue remains stuck and cannot be moved from its position if I keep switching between ascending and descending order.

Closed by #17


[$500] Distance-All available workspaces are not shown while making distance request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.93-0
**Reproducible in staging?:**Y
**Reproducible in production?:**Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Launch app
Login as<EMAIL_ADDRESS>Tap profile
Tap Workspaces
Note the number of workspaces are displayed
Navigate back to LHN
Tap fab
Tap request money
Tap distance request
Enter start and finish waypoints
Tap next and note the number of workspaces are displayed

Expected Result:
All available workspaces should be shown while making distance request
Actual Result:
All available workspaces are not shown while making distance request
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/78819774/461f9ec1-f04f-4b22-badd-a6b3fa650e65

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e33e6730e7c176a8
Upwork Job ID:<PHONE_NUMBER>423808000
Last Price Increase: 2023-10-30

@neil-marcellini I saw your proposal. Given the available list is going to be changing here soon anyway, I'm thinking no action needed on this one and we can close it. But curious if you agree?

Brought to Slack

We discussed and are going to close this, since we are planning some changes to this form that will obviate this issue.


incorrect schema generated when using discriminated value and field constraints

Initial Checks

[X] I have searched GitHub for a duplicate issue and I'm sure this is something new
[X] I have searched Google & StackOverflow for a solution and couldn't find anything
[X] I have read and followed the docs and still think this is a bug
[X] I am confident that the issue is with pydantic  (not my code, or another library in the ecosystem like FastAPI or mypy)

Description
When creating a model with an Annotated field which has a discrimination, and combining it with a Field with restrictions, the generated schema doesn't properly takes into account the discriminated values
root cause seems to be similar to this issue
In case there is a Field with any constraints, other annotations are ignored, in this case the discriminated value is ignored due to overriding of the annotation here
Example Code
class Cat(BaseModel):
    pet_type: Literal['cat']

class Dog(BaseModel):
    pet_type: Literal['dog']

Pet = Annotated[Union[Cat, Dog], Field(discriminator='pet_type')]

class PetsWithDiscrimination(BaseModel):
    pets: List[Pet] = Field(title="Have discriminated values")

class PetsWithoutDiscrimination(BaseModel):
    pets: List[Pet] = Field(title="Don't have discriminated values", max_items=2)

PetsWithDiscrimination.schema()  # Contains mapping as expected
PetsWithoutDiscrimination.schema()  # Don't contain mapping

{'title': 'PetsWithDiscrimination',
 'type': 'object',
 'properties': {'pets': {'title': 'Have discriminated values',
   'type': 'array',
   'items': {'discriminator': {'propertyName': 'pet_type',
     'mapping': {'cat': '#/definitions/Cat', 'dog': '#/definitions/Dog'}},
    'anyOf': [{'$ref': '#/definitions/Cat'}, {'$ref': '#/definitions/Dog'}]}}},
 'required': ['pets'],
 'definitions': {'Cat': {'title': 'Cat',
   'type': 'object',
   'properties': {'pet_type': {'title': 'Pet Type',
     'enum': ['cat'],
     'type': 'string'}},
   'required': ['pet_type']},
  'Dog': {'title': 'Dog',
   'type': 'object',
   'properties': {'pet_type': {'title': 'Pet Type',
     'enum': ['dog'],
     'type': 'string'}},
   'required': ['pet_type']}}}

{'title': 'PetsWithoutDiscrimination',
 'type': 'object',
 'properties': {'pets': {'title': "Don't have discriminated values",
   'maxItems': 2,
   'type': 'array',
   'items': {'anyOf': [{'$ref': '#/definitions/Cat'},
     {'$ref': '#/definitions/Dog'}]}}},
 'required': ['pets'],
 'definitions': {'Cat': {'title': 'Cat',
   'type': 'object',
   'properties': {'pet_type': {'title': 'Pet Type',
     'enum': ['cat'],
     'type': 'string'}},
   'required': ['pet_type']},
  'Dog': {'title': 'Dog',
   'type': 'object',
   'properties': {'pet_type': {'title': 'Pet Type',
     'enum': ['dog'],
     'type': 'string'}},
   'required': ['pet_type']}}}

Python, Pydantic & OS Version
pydantic version: 1.9.0
            pydantic compiled: False
                 install path: /Users/danielkatzan/personal/pydantic/pydantic
               python version: 3.9.13 (main, May 24 2022, 21:13:51)  [Clang 13.1.6 (clang-13<IP_ADDRESS>)]
                     platform: macOS-12.1-arm64-arm-64bit
     optional deps. installed: ['devtools', 'dotenv', 'email-validator', 'typing-extensions']

Affected Components

[ ] Compatibility between releases
[ ] Data validation/parsing
[ ] Data serialization - .dict() and .json()
[X] JSON Schema
[ ] Dataclasses
[ ] Model Config
[ ] Field Types - adding or changing a particular data type
[ ] Function validation decorator
[ ] Generic Models
[ ] Other Model behaviour - construct(), pickling, private attributes, ORM mode
[ ] Settings Management
[ ] Plugins and integration with other tools - mypy, FastAPI, python-devtools, Hypothesis, VS Code, PyCharm, etc.

Thanks for reporting, this should get fixed in V2 where all validation will be migrated to pydantic-core.
Sadly I don't think it will be possible to fix this before then in V1.10.

Since we did a complete refactor on how we generate the JSON schema, I don't think we'll be fixing it on V1. That said, this is already fixed on V2. 🙏


Preserve file permissions and support include / exclude filters for "Use Jenkins source"

Issue #, if available:
#125, #126
Description of changes:
Improvements for "Use Jenkins source"

Preserve file permissions, especially execution bits. This makes it easy to run jobs using script files on CodeBuild.

Used ArchiverFactory Jenkins core provides as JDK's implementation doesn't handle file permissions.

Support include / exclude filters. This allows exclude files like '.git/**' from the zip source.

Used Apache Ant directory scanner.
It requires users to write ant file patterns but I believe it's not so difficult for Jenkins users as ant file patters are often used in Jenkins plugins.

mvn install has passed in my environment (maven:3.8.1-jdk-8 docker container).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Merged, thanks for your contribution!


🔥Remove tui support

Summary by CodeRabbit

Documentation

Updated the README to reflect the switch from ratatui to tui-rs, including compatibility notes and revised code examples.

New Features

Transitioned the default library from ratatui to tui-rs in the core library to enhance UI capabilities.

Refactor

Modified demo examples to use ratatui for consistency and updated Throbber widget references to align with the new library standards.

@coderabbitai
I want to remove tui-rs and switch to ratatui only.
So your point seems to be backwards, where did the discrepancy occur?


How to do a callback function that updates a char * with a buffer size

I am leaving this note for the next person that needs to figure this out.
I have a C++ DLL that has two functions. One that allows you to register a callback function. The other creates some memory and passes a pointer to that memory as a parameter to the registered callback function. The callback function should update that memory with a string and return the size.
The solution can be found here https://github.com/funvill/TestNodeFFI

The solution can be found here https://github.com/funvill/TestNodeFFI


OS#14101048: Fixes #249: built-in functions should not have caller/arguments (and related fixes)

Replaces #4639
Several tests and test baselines needed to be updated to reflect the change in behavior. This change improves caller/arguments behavior without regressing any previous Chakra behavior. Chakra still differs from the spec and other engines on some aspects of caller/arguments.
See: https://tc39.github.io/ecma262/#sec-forbidden-extensions
Fixes #249
Fixes OS#14101048

Test262 results strictly improved.
Using test262 commit https://github.com/tc39/test262/commit/03da22868a3e0b9ecdee4a5d754c72df93baf995:
Previously 44130 passed, now 44138 passed out of 57102. (Duplicates below are strict and non-strict versions of the tests.)
+PASS e:/dd/test262/test262/test/built-ins/Function/prototype/restricted-property-arguments.js
+PASS e:/dd/test262/test262/test/built-ins/Function/prototype/restricted-property-arguments.js
+PASS e:/dd/test262/test262/test/built-ins/Function/prototype/restricted-property-caller.js
+PASS e:/dd/test262/test262/test/built-ins/Function/prototype/restricted-property-caller.js
+PASS e:/dd/test262/test262/test/built-ins/ThrowTypeError/forbidden-arguments.js
+PASS e:/dd/test262/test262/test/built-ins/ThrowTypeError/forbidden-arguments.js
+PASS e:/dd/test262/test262/test/built-ins/ThrowTypeError/forbidden-caller.js
+PASS e:/dd/test262/test262/test/built-ins/ThrowTypeError/forbidden-caller.js

Updated the description with test262 results. /cc @bterlson

See: https://tc39.github.io/ecma262/#sec-forbidden-extensions

@boingoing

Oh I thought I saw a comment in one of the test files that said object-literal methods had different behavior on spidermonkey / v8.

Yes, that's right. I didn't realize we would call those methods. Getting that right would fix that behavior. But I think that can be outside the scope of this fix (fixes the bug, no regressions).


LZ download links? official website down?

hello,
where can i download the latest version of LightZone? i cannot find the links on Github here?
and the website at www.lightzoneproject.org is not up for quite a bit of time...months if i recollect right.
any updates on the above will be appreciated.
best regards.

Howdi,
Head to https://github.com/ktgw0316/LightZone
On the right hand side, half way down, you'll find the Releases section - currently the latest is v4.2.4
You can click on that to get instructions and links to assets for various distros.

Hi,
I've just added a link for download page in 'Installing' section of the README.md.

Thank you jedd and ktgw0316!


Rails 5 support

Trucker would not load in Rails 5, looks like legacy, non-Thor based generators have been dropped.

Nice work, Rob! It would be sweet to get this working on the latest version of Rails.
Are you using this with MySQL or Postgresql? I noticed the generator is using MySQL for the legacy database connection, but we should probably update that to Postgresql since that's what most folks are using these days.

@mokolabs moving from mysql to postgres as part of a Rails 2.3 to Rails 5 upgrade. Going to be doing that twice this month, so legacy being mysql makes sense to me... really it just needs to have some sort of default, it will likely need to be changed in a lot of cases.  Not sure its critical to change which one you change things from.

Legacy data is just another way of saying old data. It may or may not be in a different database system.
Why don't we just copy the adapter settings from the development environment in database.yml? That way, if someone is using Postgres for their development database, the generated legacy adapter will use Postgres. If they're using MySQL for their development database, the legacy adapter will use MySQL.
But this file is just generated as a convenience. If they need to switch from one database stack to another, they can just edit the generated adapter code and correct it as needed. (And we can add a FAQ note to the README for this).
If that sounds good, I can work on this a bit later today.


Request must be in JSON format with content type application/json

I am using the 2.0.3-beta and trying to implement through demo example with my credentials but this error is returned
"Request must be in JSON format with content type application/json"
I am also attaching the API Debug console snapshot

Please find your problem here with the correct answer.
https://github.com/paytabscom/paytabs-android-library-sample/blob/PT2/common_issues.md


extension types

To resolve #23

@favonia So there is a slight snag lol (which may not matter): the global scope of the family of cofibrations in the syntax means that we can't actually write down a TermBuilder for ext in a useful way --- that is, you cannot do something like Splice.con phi @@ Splice.term @@ TB.ext n phi ..., because phi is a variable and there are of course no variables allowed in that position. With a notion of "metavariable" we could overcome this, but it may be overkill.
Something to watch out for.

(This would also be solved by a full-fledged necessity modality!)

@favonia So there is a slight snag lol (which may not matter): the global scope of the family of cofibrations in the syntax means that we can't actually write down a TermBuilder for ext in a useful way --- that is, you cannot do something like Splice.con phi @@ Splice.term @@ TB.ext n phi ..., because phi is a variable and there are of course no variables allowed in that position. With a notion of "metavariable" we could overcome this, but it may be overkill.
Something to watch out for.

Did you mean Splice.con phi @@ fun phi ->?

yes

I guess all this can also be resolved (if needed) by secretly adding a "validity context" in the style of Pfenning & Davies.


Build Issue

I am unable to get the build work. Getting the below error when running MAKE. any help??

I'm also getting an error on build. Running MacOS High Sierra 10.13.4.
after pulling the docker images, i get to here:
Install  1 Package

Total download size: 263 k
Installed size: 800 k
Downloading packages:
zip-3.0-11.amzn2.x86_64.rpm                                                                                | 263 kB  00:00:00
Running transaction check
Running transaction test
Transaction test succeeded
Running transaction
  Installing : zip-3.0-11.amzn2.x86_64                                                                                1/1
  Verifying  : zip-3.0-11.amzn2.x86_64                                                                                1/1

Installed:
  zip.x86_64 0:3.0-11.amzn2

Complete!
./build_lambda.sh: line 23: pip: command not found
make: *** [archive] Error 127

but I check:
 which pip
/Users/itsme/.pyenv/shims/pip

@nreddipalle this is because the repo doesn't have clamav in it...
@kevitan yes you have it locally but when make runs it launched the docker image, and needs to install there, edit build_lambda.sh and change python27-pip to python2-pip.

Fixed by #57


Remove semicolon to test sonarqube comments

Test PR do not merge

SonarQube analysis reported 1 issue

 1 major

Watch the comments in this conversation to review them.

closing this as old and stale


the switch from installPythonTool() to pipInstall() breaks package installation on Windows

Is there an existing issue for this?

[X] I have searched the existing issues

Description
I left a comment here https://github.com/fortran-lang/vscode-fortran-support/commit/8ab32be747dadd826807178b3d899c272f691a30#r92547814 describing the issue.
Screenshots
No response
Expected Behaviour
Package installation should also work on Windows :).
Version of Modern Fortran
v3.4.2022120901
Version of Visual Studio Code
v1.74.0
Platform and Architecture
Windows
Additional Information
No response

PR #772 fixes this

for windows both functions are technically wrong, the correct way according to the docs is py. I will leave a more detailed comment in the PR about all of this.


Refactor skip logic/pagination in questionnaires

Page numbers are sometimes wrong (e.g. when missing a required field and being redirected to the same page, or while skipping questions).
Obscure bug that we currently prevent by adding extra validation (non-trivial skip fields have to be marked as required): https://github.com/unicef/iogt/pull/505#issuecomment-910055219
This extra validation makes input type 'checkbox' basically useless for the purpose of validation.

split up to be skip logic only see #866


heap-buffer-overflow libyara/exec.c:1196 in yr_execute_code

Describe the bug
AddressSanitizer: heap-buffer-overflow libyara/exec.c:1196 in yr_execute_code
To Reproduce
Steps to reproduce the behavior:
1, compile yara with asan: ./configure CC=gcc CXX=g++ CFLAGS="-g -O0 -fsanitize=address" CXXFLAGS="-g -O0 -fsanitize=address" LDFLAGS="-g -O0 -fsanitize=address"
2, run this command: ./yara -C PoC binFile
Please complete the following information:

OS: ubuntu 20.04
YARA version:  4.3.2

Additional context
ASAN reprot:
==1855673==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000002510 at pc 0x7f1f120df3f6 bp 0x7fff9d9480a0 sp 0x7fff9d948090
READ of size 8 at 0x602000002510 thread T0
#0 0x7f1f120df3f5 in yr_execute_code libyara/exec.c:1196
#1 0x7f1f12145cd8 in yr_scanner_scan_mem_blocks libyara/scanner.c:526
#2 0x7f1f121467a0 in yr_scanner_scan_mem libyara/scanner.c:670
#3 0x7f1f12146b3e in yr_scanner_scan_fd libyara/scanner.c:706
#4 0x55f0c48f511a in scan_file cli/yara.c:736
#5 0x55f0c48f9444 in main cli/yara.c:1654
#6 0x7f1f119c6082 in __libc_start_main ../csu/libc-start.c:308
#7 0x55f0c48f1ced in _start (/home/root/latestFiles/yara-4.3.2/.libs/yara+0x7ced)
Address 0x602000002510 is a wild pointer.
 See #1948 for more context.


[Table] minimum width for "TableRowColumn"

Description
It could be usefull to set the minimum width for a table row column.
In this way when we have a large number of columns the table could automatically show the horizontal overflow.

@francescabarbazeni87 could you figure out any solution around that?

You could work around it using custom styles:
//...
const styles = {
    longCell: {
        minWidth: '1000px',
    },
    tableWrapper: {
        overflowY: 'auto',
    },
};

const LongTable = ({classes}) => (

            <TableHead>
                <TableRow>
                    <TableCell>ID</TableCell>
                    <TableCell className={classes.longCell}>Long Cell</TableCell>
                </TableRow>
            </TableHead>

);
//...

Why not TableCell can not add xs like Grid ??

@AndriusBil Thanks for sharing a solution.


Linux Mint 20.2 error GLibc 2.34

Hi,
after the last update quickgui won't start on Linux Mint 20.2 due to the error
quickgui: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by quickgui)
Mint latest glibc version is 2.31 (Mint is based on Ubuntu focal 20.04)
ldd --version
ldd (Ubuntu GLIBC 2.31-0ubuntu9.2) 2.31

Salvation. I came precisely to raise the problem, and I see that it has already been done! It's cool ;)
Error message:
quickgui: /lib/x86_64-linux-gnu/libc.so.6: version 'GLIBC_2.34' not found (required by quickgui)
Linux Mint Uma 20.2 system, Ubuntu Focal 20.04.2 base.
ldd --version
ldd (Ubuntu GLIBC 2.31-0ubuntu9.2) 2.31
The two links which follow, it is to reward the work of the developer and all the people who maintain this beautiful project.
https://youtu.be/qeQ667zf74U
https://youtu.be/4klbTIIW5mg

Oh merci !! Je vais immédiatement regarder cela avec intéret!

And I will also have a look at that problem, of course :P

Ok, I have confirmed the problem. I think I'll have to build on a focal VM for focal. Good thing that I know of a cool program to run VMs !! :P

Alright, this has been fixed with release 1.2.1! Thanks for quickly reporting this problem! I hope this little downtime didn't impact you too much.

Many thanks for the very quick support !  Fortunately, you have THE ultimate virtualization software to quickly solve problems ;) It didn't impact me.  I could still present your project and its novelties, specifying that you are responsive ;) Good luck.

Works now! Thanks for quick fix and for all your work

Still get this error
$ apt show quickgui
Package: quickgui
Version: 1.2.3-1~focal1.0
Priority: optional
Section: utils
Maintainer: Yannick Mauray<EMAIL_ADDRESS>Installed-Size: 24.7 MB
Depends: zenity
Download-Size: 7,216 kB
APT-Manual-Installed: yes
APT-Sources: http://ppa.launchpad.net/yannick-mauray/quickgui/ubuntu focal/main amd64 Packages
Description: A Flutter frontend for quickget

$ quickgui
quickgui: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by quickgui)


Bring in language docs via submodules

Hi all. I see that you've already spent some time fleshing out a Process for authoritative 'getting started' guides #472, which is based on file copying.
I'd like to suggest that we keep things DRY, by using submodules instead. I've implemented that successfully in other projects. (Btw, we're already using (recursive) submodules for Docsy.)
We can do this incrementally, and for one language to start off with, if you'd like to test the concept.
Thoughts? @tedsuo @austinlparker @mtwo @flands

Disadvantages of file mirroring and copying:

We loose true edit/blame history
There's the risk of edits being done in the wrong place (since files are present in two repos)
There's potential confusion of where to open issues (again, since files are present in two repos)

Advantages of using submodules (other than the counterpart of the disadvantages listed above):

Website maintainers can bring in doc updates from all language repos with a single command

[x] Go - #690

Couple of notes...
First, I generally agree with @dyladan that website docs should live entirely in this repository. That's how it was for many months! Maintainers of other SIGs disliked this approach, as it caused 'drift' between documentation that they were writing in their repositories and documentation on the website. When we proposed moving docs per-language into the language repositories, submodules were considered and rejected for several reasons:

Submodules are finickly and I dislike using them
They require website maintainers to know the correct commit/tag to pull from in order to get the 'correct' docs version on the site. Running an update on each build (or nightly, whenever) wouldn't necessarily get the 'right' version of the docs either.

The 'push' model of having docs mirrored was proposed and agreed to by all maintainers several months ago. While it's obviously not a perfect solution, it's the one we built up a consensus around. @chalin your summary of the disadvantages is spot-on, and most of them have already happened, but the only real option as I see it is to continue to allow maintainers to "push" PRs here with updates or go back to the well and try to re-migrate docs back into this repo.

Another disadvantage of submodules that austin didn't mention is that it depends on external repositories not merging changes which break the website build, something that is very easy to do. Not all valid markdown compiles into a working site. For an example, see the most recent JS docs update where the valid relative links of the form [text](../relative_path.md) caused the build to fail even though it worked perfectly fine in the github markdown UI.
Personally, I see huge advantages of having only one place where the documentation resides. I think my proposed solution would be to have SIG repositories have an extremely simple "getting started" section on the README which does the bare minimum to get autoinstrumentation working in the most common case. Anything more advanced than that should link out to the website which may contain significantly more information and all of that should live in this repository.

Thank you both for your feedback. I'm not wed to using submodules. The most important thing IMHO is to avoid having files reside in two repos.

Personally, I see huge advantages of having only one place where the documentation resides.

I agree, and this brings up another point: IMHO we don't need to have the same solution implemented for all languages. (In fact, we don't currently -- there seemed to be pushback on the mirroring scheme, see the table in https://github.com/open-telemetry/opentelemetry.io/issues/472#issue-819224793).

FYI, another example of how having files into two places can go wrong: #709.

Per discussion during the last comms meeting, we'll be moving forward with the following -

If maintainers wish to keep the canonical copy of their docs in their SIG repo, those docs will be pulled into opentelemetry.io via submodule.
Otherwise, their docs will be migrated back to the opentelemetry.io repository.

This ensures that there is only ever one copy of the documentation.
We strongly recommend that maintainers choose to host the canonical copy of their documentation on opentelemetry.io repository in order to benefit from upcoming features such as internationalization and versioning.

Collector wants the docs in the website if that simplifies things

Per @jkwatson, java will keep their docs in their repo, so we'll need to submodule that @chalin

Per discussion during the last comms meeting, we'll be moving forward with the following -

If maintainers wish to keep the canonical copy of their docs in their SIG repo, those docs will be pulled into opentelemetry.io via submodule.
Otherwise, their docs will be migrated back to the opentelemetry.io repository.

Let's use #730 to track the decision and overall progress for each SIG.

All done!
#542 will be next.


inputmode should default to text not none

:book: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode

my reading of this CSS Tricks article does not refer to text: :book: https://css-tricks.com/everything-you-ever-wanted-to-know-about-inputmode/


Delayed rendering of pages upon scrolling

I have been using this template for more than a year now and overall very satisfied with it. However, there has been one annoying issue all along. I see the same issue with the official GitHub hosted project as well.
When I scroll up or down on the pages, the content rendering is very slow. I see a blank space for a while and then the content renders after a considerable delay, and it makes the whole experience very frustrating.
I'm always on the latest version of Chrome browser and using Macbook Pro 15" (2015) machine, which is relatively high power. It only happens on pages that use this template. I don't see a problem on other websites even those which are graphic intensive. I do "not" see this issue on Michael's "Made Mistake" dot com website either.
Is there some "feature" in this template that might be causing the page to render with a delay?

Can you provide more detail? I'm having a hard time reproducing this.
What exactly on the the page is delayed? Is the large hero images? is it the text?

The entire content rendering (including images and text) is delayed. As I scroll down, I see blank space first and then the content is rendered after a considerable delay.
Here are some more observations:

I can only reproduce this on my blog (which uses MM theme) and the MM site itself. I tried reproducing on very graphic intensive sites with lots of ads etc. but could not reproduce on those sites. So that indicates to me that it has something to do with the theme.

I can't reproduce it 100% of the time even on my blog and MM site. For example, right now I can't reproduce it on either site.

A few times when it happened, I shut down my browser (Chrome) completely and restarted it hoping that the issue would go away, but it didn't. I then closed all other applications and ensured that there were plenty of system resources available, but the issue still didn't go away. Ultimately I had to reboot my machine, and that got rid of the issue (temporarily) before coming back again after 2-3 days.

I mostly use Chrome browser and keep it on the latest stable public release. The next time it happens, I'll test it across all the browsers at my disposal and update the results here.

Try using Chrome's web developer tools to get more detail. Could be related to your ISP, or something is taking longer to load. The reason it likely doesn't happen 100% for you is the browser caches the page so it's faster the second time.
The theme does have some CSS that fades the page on load. It's not that you're noticing is it?

Hit the 3 vertical dots in the upper right corner, hit Settings, go under Network and make sure  "Disable cache (while DevTools is open) is check.
Click on the Network tab, hit the gray circle to record, then refresh the page.
Let the page fully load.

You'll get a filmstrip of the page loading, see if you can find screenshots there where it's loading with blank spots. For me it's completely gradual. The page starts blank and fades in. The hero image takes longer to come in, but all of the text is there in around 400ms.

I'll try it out when I'm able to reproduce the issue (hopefully in the next few days). But let me make it clear. The initial page loading is not a problem. The pages load usually, but the issue appears on long pages (not very long either), when I scroll down or back up. The content just renders very slowly. I'll try to screen record it next time when I see it.

@mmistakes Hi, I was away for a while, but I'm able to reproduce the issue again. I managed to do a screen recording to show you exactly what the issue is. Let me know how I can share it with you. I prefer not to post it publicly.
Based on your previous comments, you seem to be confusing it with page loading or image loading issue. But it's not. The page just doesn't refresh fast enough when scrolling up and down (it's captured very clearly in the video). It has nothing to do with ISP or bandwidth. And it happens only on my site which is using the MM theme. It doesn't happen on any other site in the same browser.
And it's not a one-off issue. It happens very consistently and the only thing that resolves is a machine reboot (Mac).

@mmistakes Hi, I managed to reproduce this issue on the MM pages as well (https://mmistakes.github.io/minimal-mistakes/docs/layouts/), and have captured a screen recording of it. That eliminates my site out of the equation.
You can find the recording here:
https://drive.google.com/open?id=1iQF7qlO7OX2n08BP3ppRDKwtHK0k_fQD
It's in .mov format recorded with QuickTime on MacOS.

I honestly have no idea what is causing this. I can't reproduce it at all. Ive tested on macOS and Windows and in multiple browsers and have never seen it stutter liked it does for you.
The fact that it corrects after a reboot tells me it's application related or some sort of memory leak that affects your computers performance.
Does it happen right after a reboot? Or after you've been browsing for a bit? Do you have browser extensions enabled that could be interfering? Do you have other apps running that might be hitting performance? Multiple tabs?
Can you rule out any of those?

@mmistakes
It happens only after a while, not immediately after the reboot. Since I'm able to reproduce it right now, I managed to perform a few more tests using the MM Github site. A few observations:

It's happening only on Chrome. I can't reproduce this on Firefox or Safari. I'm currently using Chrome v74.x (which is the latest right now), but it was a much older version when I first reported the issue.

I cleared Chrome browser cache, disabled every single extension, and completely restarted Chrome, but it did NOT resolve the issue. I was running just one Chrome tab. I also tried it in incognito mode. There is absolutely no other application running on the system. CPU is at 2% with 10GB unused RAM.

I cannot reproduce this on any site other than those using the MM theme. For instance, even a heavily loaded site reddit dot com scrolls through very smoothly without any issue in the adjacent tab of the same Chrome browser.

I'm sure reboot will resolve the problem but I will hold off on it so that I can do more testing if needed.
Can you provide me links to a few other sites using this theme? I can test it on those sites as well.

Is it the entire site or just pages that are really tall and/or have a lot of images?
Not discounting the fact this is an issue, but seeing how no one has chimed in makes me think it’s isolated to your computer. I don’t know of other urls to test. I guess go through the people who have starred or forked the repo and see if you can test their sites.
There are over 8,000 forks so you should have plenty of users to test.

It happens to every page of your MM site and other sites using the same theme, even the ones that are not very long and have just one or two small images.
I looked at various forks but couldn't find a site using the theme, but then I found a few through Google.
Here's a list of sites using the same theme and all exhibit the same issue:
http://prettyquestions.com/THEME_DATA/
https://copdips.com/ (the home page is very simple but still delays; every other page on this site has huge delay)
https://azurecitadel.com/contributing/minimalmistakes/
https://www.aravindiyer.com/tech/yet-another-solution-related-posts-jekyll/#

I noticed that some sites say that they are using Minimal Mistakes theme but have a very different look from the one used on your reference site https://mmistakes.github.io/minimal-mistakes/docs/quick-start-guide/. Following are the sites using a "different" MM theme and have NO issue:
https://blog.christianposta.com/theme-setup/
http://varianceexplained.org/theme-setup/
http://www.zenna.org/theme-setup/

What's the difference between the MM theme used in the above sites and your site?
While I agree with your point that since no one else has reported it so far, it's got something to do with my computer, but at the same time, I have not seen this issue with any site other than the ones using this theme. I'm an IT professional and use this computer for 12 hours a day. I'm using Chrome 99.9% of the time. I'm NOT seeing this issue on your Made Mistakes site either which is using a different theme.
Also FWIW, I changed to another Mac (same year but slightly higher configuration) since the time I first reported the issue, but I did restore the whole system from backup. So it's not hardware related but yes, it could have something to do with the OS image.
Even if it's just my computer, there's got to be something peculiar on this theme that doesn't play well with my computer.
I even reset Chrome back to factory settings but it didn't resolve the issue.
I know I'm not providing you much actionable info, but I still wanted to let you know that the issue exists on my system and capture as much details as I could.

Those sites are using prehistoric versions of the theme.
Have you tried disabling JavaScript and seeing if you still have the issue? Only thing I can think of is maybe Font Awesome or some 3rd party script the theme uses is thrashing the browser window.
There's very little consistent between those old versions of the theme and the newer one. jQuery is in both I believe and Fobt Awesome.
Other than that I have no idea. This is almost impossible to triage as I can't reproduce it.

Thanks for the clarification on the different versions of the theme.
I somehow think that it has have something to do with Chrome, as the issue only occurs on Chrome. So I was looking for solutions on Google. I found something but not quite sure whether it's relevant to this theme. Could you spend a moment to look at the link mentioned below and see if it is applies to this theme by any chance?
https://mention.com/blog/chrome-performance-rendering-issues/

I enabled the paint flashing option in Chrome Dev tools on your MM site and see that there's a lot of "painting" happening on your site upon scrolling that doesn't happen on other sites. So, I suspect that something is wrong with the theme. I can screen record it for you if you want.
Unfortunately, I'm not CSS-savvy and cannot pinpoint to any specific so far.

I tested after disabling Javascript, and still see the same issue.

I think I've found the root cause. The animation on the main id is causing the rendering delays. If I remove webkit-animation and animation, the problem instantly disappears. What is the purpose of this animation anyway?
#main {
    clear: both;
    margin-left: auto;
    margin-right: auto;
    padding-left: 1em;
    padding-right: 1em;
    /* -webkit-animation: intro 0.3s both; */
    /* animation: intro 0.3s both; */
    max-width: 100%;
    /* -webkit-animation-delay: 0.15s; */
    /* animation-delay: 0.15s; */
}

The animation fades in the #main div element. Looks like for you it's applying that animation to each child element which is causing them all to fade in.
No idea how that's possible or why it only happens for you.

I'm not convinced that it's an issue just with my machine. I'm more inclined to think that it's a bug with Chrome, or Chrome on MacOS, or MacOS, and gets triggered under certain circumstances. It's almost as if some OS-level process (as it keeps running even when Chrome is shutdown) on Mac gets "tired" after a while (potentially due to memory leak). I generally don't reboot my machine for months. So that could be one of the reasons others have not reported it. Or I could be more picky than others :)
I have already fixed the issue on my blog by getting rid of the animation entirely. And while I was at it, I got rid of similar animations from everywhere else on the site. My site feels so much smoother and lighter now. I had almost started to repel my blog because of this issue.
I don't get the point of running an animation that triggers upon page scrolling. I can understand having it trigger upon the initial page load, but when it triggers upon scroll, it just makes the whole site feel sluggish and heavy even under normal circumstances. I personally like clean and lightweight themes, no fancy stuff (which is what attracted me to MM in the first place).
I'm not asking you to get rid of it, but you might want to look at the way it actually works and adjust it or provide a setting to turn of the animations in a future version.
Thank you for the wonderful service that you are providing to the community!

The animation isn't intended to load on scroll. Whatever browser issue/bug you're encountering is causing that. It's meant to fade the page in on load to ease the abruptness of content staggering in.
Not sure what else to tell you. I'm on macOS as well, have latest Chrome, have a 7+ year old iMac, and haven't rebooted in weeks and the demo site and every one of the links above load and scroll silky smooth for me.
If animations aren't your thing Sass variables were added many releases ago that you can override and disable animations completely.
$global-transition: none;
$intro-transition: none;

Thanks for the tip!
Just a note there that I had to include those variables before the @import statements. They seem to work well.


Bottled Memory Relic

Slight issue with using the CustomBottleRelic implementation; tiny bottle icon when rendering everywhere.

Filed https://github.com/daviscook477/BaseMod/issues/243 for the tiny icon on the card


Add contributing instructions

Fixes #2704
Given that there was already a Contributing section in the README, I've added to this rather than create a separate CONTRIBUTING.md - but if we'd prefer move it all out to a separate one I can do this.

Thanks @domdomegg !


Scroll to top button should come at midway or end of page

Describe the bug
The Scroll to top button should remain hidden on the main page unless the user scrolls

@AnirudhPanda Go ahead !!

#69

#69

thanks @AnirudhPanda ...keep contributing :)


Copilot chat breaks when I have a python file open

Copilot Chat Extension Version: v0.17.1
VS Code Version: 1.91.1
OS Version: Ubuntu 22.04.4 LTS
Logs: 2024-07-20 12:13:13.257 [info] [streamChoices] request done: requestId: [d0abd9d4-8e4f-4edd-bb63-58886c079866] model deployment ID: []
2024-07-20 12:13:13.742 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 346 ms
2024-07-20 12:13:13.778 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-07-20 12:13:13.778 [info] [streamChoices] request done: requestId: [f2879b91-b963-47be-ab40-b5333e65ef24] model deployment ID: [dep-0]
2024-07-20 12:26:15.335 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 2541 ms
2024-07-20 12:26:25.668 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-07-20 12:26:25.668 [info] [streamChoices] request done: requestId: [d4f2f1b9-97b3-4bdf-afae-503e98c60793] model deployment ID: []
2024-07-20 12:26:29.109 [info] [chat fetch] request.response: [https://api.githubcopilot.com/chat/completions], took 397 ms
2024-07-20 12:26:29.111 [info] [streamMessages] message 0 returned. finish reason: [stop]
2024-07-20 12:26:29.111 [info] [streamChoices] request done: requestId: [a0f2c52c-14d1-4b14-98b5-b711c69af18d] model deployment ID: [dep-0]
2024-07-20 12:32:57.669 [info] [auth] Logged in as rileyblackwell
2024-07-20 12:37:59.399 [info] [auth] Logged in as rileyblackwell
2024-07-20 12:48:22.159 [info] [auth] Logged in as rileyblackwell
2024-07-20 12:49:31.089 [info] [auth] Logged in as rileyblackwell
2024-07-20 12:50:00.759 [info] [auth] Logged in as rileyblackwell
2024-07-20 12:51:25.659 [info] [auth] Logged in as rileyblackwell

Steps to Reproduce:

Create a python file
Try to use chat

Github copilot chat and Github Copilot inline suggestions are still not working when I create a python file. I've tried using C, C++, Java and everything works fine, but as soon as I create a Python file then Copilot Chat won't let me send a chat message. Copilot is enabled for Python, in case anyone was wondering.

Can you attach a screen recording of some sorts? Your logs don't show much, I'm not 100% sure what you're seeing when you state it doesn't let you send anything but works in other files

Uploading main.py - copilot [WSL_ Ubuntu] - Visual Studio Code 2024-07-24 10-31-14.mp4…

https://github.com/user-attachments/assets/9db0a548-8141-4cf9-9645-c5ffd0ff3e74

@rileyblackwell Thanks for the recording. I see you have some extensions to install  so please make sure you're up to date just to be sure.
Additionally, I notice that you're in WSL. Does Copilot Chat work when not in WSL? Can you also show it working in a non Python file? I think this is a WSL vs no WSL issue rather than a Python vs others issue.

https://github.com/user-attachments/assets/de330d69-f881-4319-bf3b-6904d9ba15ab

https://github.com/user-attachments/assets/364d45f4-b460-4750-a961-e51bae77103f

Copilot works with C in WSL and works with Python not in WSL. The issue is with Python in WSL.

It looks like you reloaded between the two. If you just switch within WSL from a C file back to a Python file and vice versa does it disable itself when in the python file but not in the C file?

https://github.com/user-attachments/assets/b040d0db-1d68-4c73-9b78-975efa16e7c8

Switching between a c file and python file seems to work. As you can see in the video, the last 2 chat responses have a lot of latency. I don't think the latency is due to my internet connection.
As I was preparing the video, I did have some instances where Copilot was not working with only a C file open. Your initial thought that the problem is a wsl vs no wsl issue might be correct.

Could you check what is in the Extension Host (Remote) output channel when this happens? The Chat view and the Copilot output channel are completely empty, I guess this might be some early error preventing the extensions to activate properly.
Could you then also try with VS Code Insiders and GitHub Copilot and GitHub Copilot Chat's pre-release versions?

https://github.com/user-attachments/assets/5325fad0-c30a-4152-8fbd-67720e821c6a

Before taking this screen recording I was using Copilot with a C file and it was working just fine. I then closed vscode, deleted the c file , and then created a python file. When I opened vscode again with the python file Copilot wasn't working.
I can't imagine why python would have anything to do with Copilot failing. I just restarted my Copilot subscription last week, and have experienced this kind of buggy behavior with Copilot the entire time. When I ended my previous Copilot subscription about 6 months ago I never had any issues up to that point.

Copilot and Copilot Chat work in vscode-insiders. Switching to pre-release versions in vscode doesn't fix the problem.

@rileyblackwell Glad to hear that insiders works. It will be released to stable next week.
Pre-release of Copilot chat in VS Code stable is basically the same as the stable version of Copilot chat in VS Code stable since Copilot chat is very new the latest pre-releases can only run on VS Code insiders.

Alright, if insiders will be released to stable next week then hopefully that will fix the issues. I will follow up next week if I'm still experiencing problems after the update. Thank you for your help!

I'm now having the same issue while using vscode insiders. This happens immediately after I open vscode.

Can you try the latest pre-release + insiders again. We made some changes

https://github.com/user-attachments/assets/08631b65-9391-4c2e-af7c-e9b7ffc7ff49
I still get this error using insiders + latest pre-release

Can you include the copilot chat logs too? They should be under the Github Copilot Chat output channel. Pasting the complete log is helpful. Hoping we can get to the bottom of this 👍

https://github.com/user-attachments/assets/ff2e12a4-b337-41fe-9c00-e5c688fcfe08
Here is the complete copilot chat log. Thank you for digging into this :)

And your chat panel is blank and not working with that log? That logs shows everything is working properly so just trying to understand the state you're in

That is correct. It won't let me send a chat message.

https://github.com/user-attachments/assets/621cba5b-92af-4cb6-94b4-7b05efb6bc78
I'm clicking the send message button in this recording and nothing is happening. I also try to open a new chat window and nothing happens either.

https://github.com/user-attachments/assets/40b0243a-261e-4b16-9b0a-7b47bd540e2c
If I open insiders with a c file rather than a Python file then Copilot Chat seems to work. I know this is a weird distinction, but I've had it happen consistently.

Can you try disabling your extensions except for WSL + GitHub Copilot Chat + Github Copilot

https://github.com/user-attachments/assets/f6082fe4-a6eb-4d32-91a4-fb27256a2b02
disabling all extensions in wsl except for WSL + GitHub Copilot Chat + Github Copilot seems to fix things

Your best bet is to bisect your extensions. F1 -> Start Extension bisect. You can also try manually re-enabling python for example. And then figuring out what extension is causing the breakage

If you look back at previous copilot chat logs you will notice that "Logged in as rileyblackwell" is the last thing that gets logged. After removing the extra extensions, the log now shows "Got Copilot token for rileyblackwell". I'm guessing the times when copilot chat isn't working that vscode isn't receiving the copilot token.

It seems to be intellicode.

The log doesn't show that it received the copilot token

Thanks for now I would keep intellicode disabled and file a bug here https://github.com/MicrosoftDocs/intellicode/issues
Glad we figured it out!

Sounds good. Thank you for your help.


Why PatchEmbed do not have norm layer?

Compared with DeiT/ViT in a supervised learning setting, it seems like your PatchEmbed does not have a norm layer. Can you explain your choice?

Hi @gaopengcuhk
From my understanding, PatchEmbed does not have a norm layer neither in DeiT, ViT nor DINO. We are following exactly the architecture DeiT-S from deit codebase: https://github.com/facebookresearch/deit/blob/cb29b5efd522a0ac83d64aa8b41fe27cead3a030/models.py#L77-L89
If you take a look at timm codebase https://github.com/rwightman/pytorch-image-models/blob/c16d65a8a7a27c0a0418cf601a5ee0fcbb740135/timm/models/vision_transformer.py#L224-L225 and https://github.com/rwightman/pytorch-image-models/blob/master/timm/models/layers/patch_embed.py
you see that norm_layer is set to None.


Improved undo/redo of RoadPoint edit panel's add next/prior rp

Consolidate to use the same method as in the click-to-add code. The actual do/undo references there could be improved too, but seems to work stably in the meantime.
This also includes a change to improve the automatic in/out magnitude handles for the new and initially selected RoadPoint, making for more natural graceful turns (but still without modifying the prior curves, so the handles can become asymmetric).
Closes #84

While the undo/redo is not perfect (still some exceptions sometimes showing on the consoles), the end user result in the 3D view seems to work pretty nicely. I want to get to the godot 4 branch upgrade, so I'll merge this in the meantime.


"@loop" directive does not work (for me)

Edit: Maybe you changed your templating, but I found your compoment partial/the_loop.blade.php does all in all what you described
@component('partials.the_loop')

{{the_title()}}

{{the_excerpt()}}

@endcomponent

mountainbreeze feels very structured and clean so far! thank you
richard
Describe the bug
I tried to use your custom blade directive @loop but got an error in wordpress.
To Reproduce
New Installation of Wordpress (with laragon)
created a new template "page.blade.php" to alter the sample-page.
Used your example code snippet
"@extends('layouts.app')
@section('content')

    @loop
        {{ the_title(); }}
{{ the_excerpt(); }}
    @endloop

@endsection
"
Expected behavior
seeing the wordpress loop in action
Screenshots

Desktop (please complete the following information):
Windows 10, Chromium, Laragon as a Local Server
Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hello, I'm checking out Mountain breeze and am also having an issue with the example loop. The post content is retrieved but the opening and closing @loop/@endloop are also being printed  to the div. Any insight into this is appreciated.
@loop
{{the_title()}}
{{the_excerpt()}}
@endloop


using exact commit content from correction downstream PR #586

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>@lberk I went back, and did an exact comparison of my change for MASTER/release-next, and found a little diff there - I do recall debugging this.
Let's try this

and this does match the invocation from usptream as well:
https://github.com/knative/eventing/blob/release-0.15/test/e2e-tests.sh#L38


[newfeature]: inject node between nodes

palantir has a concept of being able to inject a node between two existing nodes.

Given the curve chosen what would be a good solution to adding a button in the center of the connection?
https://www.ngx-vflow.org/features/curves
Thanks

Hi! This is probably what you are looking for
https://www.ngx-vflow.org/features/labels


Feature/executeables

Goal: Have an executable that reads a modified external config.
https://www.npmjs.com/package/pkg
Without the need to build and execute over command line

Will close for now and tackle later again


fix: package extensions

This PR fixes the three  Package Extensions namely, JuMPExt, JLD2Ext, MakieExt. The first two have been successfully compiled as well. The WGLMakie takes forever to compile, so couldn't really test MakieExt by drawing weight_plots.
As instructed, I tested the "src/Quantum/misc_known_codes_test.jl". This contains many codes that uses JLD2Ext. All the tests passed.
julia> include("misc_known_codes_test.jl")
Precompiling JLD2Ext
        Info Given JLD2Ext was explicitly requested, output will be shown live
WARNING: could not import CodingTheory.PlanarSurfaceCode3D into JLD2Ext
WARNING: could not import CodingTheory.ToricCode3D into JLD2Ext
  1 dependency successfully precompiled in 23 seconds. 180 already precompiled.
  1 dependency had output during precompilation:
┌ CodingTheory → JLD2Ext
│  [Output was shown above]
└
┌ Warning: The distance set is greater than the current upper bound of 2
└ @ CodingTheory ~/Desktop/ct/task/CodingTheory/src/Quantum/stabilizer_code.jl:556
┌ Warning: The distance set is greater than the current upper bound of 2
└ @ CodingTheory ~/Desktop/ct/task/CodingTheory/src/Quantum/stabilizer_code.jl:556
┌ Warning: The distance set is greater than the current upper bound of 2
└ @ CodingTheory ~/Desktop/ct/task/CodingTheory/src/Quantum/stabilizer_code.jl:556
Test Summary:               | Pass  Total     Time
Quantum/misc_known_codes.jl |  130    130  1m15.3s
Test.DefaultTestSet("Quantum/misc_known_codes.jl", Any[], 130, false, false, true, 1.726006162109859e9, 1.726006237412491e9, false, "/home/Transcendence/Desktop/ct/task/CodingTheory/test/Quantum/misc_known_codes_test.jl")

There was a minor bug in the ToricCode that was detected by the tests.  1 test failed. It was that set_dressed_X_minimum_distance! seems to be for subsystem codes, but since Toric code is a Stabilizer code, so we have to use set_X_minimum_distance!.
julia> include("misc_known_codes_test.jl")
┌ Warning: The distance set is greater than the current upper bound of 2
└ @ CodingTheory ~/Desktop/ct/task/CodingTheory/src/Quantum/stabilizer_code.jl:556
┌ Warning: The distance set is greater than the current upper bound of 2
└ @ CodingTheory ~/Desktop/ct/task/CodingTheory/src/Quantum/stabilizer_code.jl:556
┌ Warning: The distance set is greater than the current upper bound of 2
└ @ CodingTheory ~/Desktop/ct/task/CodingTheory/src/Quantum/stabilizer_code.jl:556
Quantum/misc_known_codes.jl: Error During Test at /home/Desktop/ct/task/CodingTheory/test/Quantum/misc_known_codes_test.jl:1
  Got exception outside of a @test
  Only valid for subsytem codes; use `set_X_minimum_distance!` for stabilizer codes.
   The PR is now ready for review. Thank you!


Dateline: Help

[ ] help modal action (sg - add hover (red #993333) or click (blue) [?] fa-question-circle button)
[ ] help modal content (kg, sg)

What needs to be said?

Maybe if there is a time slider it should be open by default, where it is obvious what it is and needs no help. Easy to miss when closed.

OK, easy enough to set the control to be open by default, and the initialisation automatically encompasses the entire range of dates present in the dataset/collection and has Include undated checked by default.
Perhaps there's a case for a detailed explanation in a popover, which would have a Don't bug me with this again any time soon button to set a disabling cookie?


Connect child devices to Cumulocity with configuration management enabled for them

Is your feature request related to a problem? Please describe.
Provide a mechanism for child devices to connect to thin-edge and report their supported configuration types so that its child device twin is created in Cumulocity with c8y_ConfigurationUpload and c8y_ConfigurationDownload capabilities enabled for the config types reported by the device.
Describe the solution you'd like
Implement the device provisioning mechanism as documented in https://github.com/thin-edge/thin-edge.io/pull/1236

The c8y-mapper to handle the creation of child device twin using the device-name and device-type fields in the tedge/meta message.
The c8y-configuration-plugin parses the configuration key in the tedge/meta message to extract the supported config types and create c8y-configuration-plugin.toml file for the child device.

It's outdated and the topic is covered by the work of https://github.com/thin-edge/thin-edge.io/issues/2098. Therefore, I'd close the ticket.

as above


Get strange results by running sparse_tensor_dense_matmul_op_test.py

When I run sparse_tensor_dense_matmul_op_test.py with large n,m,k
I get:
% nnz 	 n 	 gpu 	 m 	 k 	 dt(dense) 	 dt(sparse) 	 dt(sparse)/dt(dense)
0.5 	 512 	 True 	 1822 	 4608 	 0.0222946 	 0.0130646 	 0.585998
0.5 	 512 	 True 	 1821 	 4608 	 0.0224976 	 0.0130761 	 0.581222
0.5 	 512 	 True 	 1820 	 4608 	 0.022529 	 0.79513 	 35.2936
0.5 	 512 	 True 	 1819 	 4608 	 0.0217343 	 0.795709 	 36.6107

It is strange that dt(sparse)/dt(dense) are very different when m=1821 -> 1820
BTY, I set the iterations to 10 for time saving...
delta_dense = _timer(sess, ops_fn, 10)
delta_sparse = _timer(sess, ops_fn, 10)

I apologize but I am having a hard time understanding what the problem is, where the problem is, and what version it affects. Please resubmit and pay attention to the issue template (https://github.com/tensorflow/tensorflow/issues/new) . Please provide all the information it asks.  Thank you.


Command to update global hq.

Issue number: DH-1608
Description of change
This adds a command that updates given company's global hq if global hq doesn't already exist.
It adds additional parameter overwrite which cause command to write global hq regardless if it exists.
I also moved simulate param to the base command class as it was present in all commands.
Checklist

[ ] Have any relevant search models been updated?
[ ] Have any relevant fixtures (fixtures/test_data.yaml) been updated?
[ ] Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
[ ] Has the admin site been updated (for new models, fields etc.)?
[ ] Has the README been updated (if needed)?

Codecov Report

Merging #928 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #928      +/-   ##
===========================================
- Coverage    96.65%   96.64%   -0.02%
===========================================
  Files          171      172       +1
  Lines         4876     4855      -21
  Branches       468      472       +4
===========================================
- Hits          4713     4692      -21
  Misses         104      104
  Partials        59       59

Impacted Files
Coverage Δ

...ance/management/commands/update_omis_uk_regions.py
93.75% <ø> (-0.99%)
:arrow_down:

...gement/commands/update_company_headquarter_type.py
90.47% <ø> (-1.2%)
:arrow_down:

...s/update_investment_project_estimated_land_date.py
100% <ø> (ø)
:arrow_up:

...t/commands/update_investment_project_created_on.py
93.75% <ø> (-0.99%)
:arrow_down:

...ement/commands/update_investment_project_sector.py
100% <ø> (ø)
:arrow_up:

...t/commands/update_service_delivery_grant_fields.py
100% <ø> (ø)
:arrow_up:

...ment/commands/update_investment_project_company.py
96.55% <ø> (-0.33%)
:arrow_down:

...nagement/commands/update_company_company_number.py
100% <ø> (ø)
:arrow_up:

...s/update_investment_project_possible_uk_regions.py
100% <ø> (ø)
:arrow_up:

...anagement/commands/update_adviser_contact_email.py
100% <ø> (ø)
:arrow_up:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26dbee4...ae959cf. Read the comment docs.

I think it's more complicated than this :(
records in datahub can be marked very incorrectly with means that:

a subsidiary company could be marked as Global HQ
there could be more companies marked as subsidiary than the one in the spreadsheet
the selected company might be subsidiaries of different Global HQ companies

Therefore the script should:

mark the right company as global HQ unmarking the old ones if necessary
unmark all the subsidiaries and mark the ones in the spreadsheet

@marcofucci assumption is that the subsidiaries data already in Data Hub is correct, as this feature has been enabled only recently (it is not old data). This command is only adding subsidiaries to the global HQ (chosen by us) and we already have a command that changes headquarter type.
We can use overwrite option which will "move" subsidiaries to the chosen global HQ if there is a need.

Perhaps we could use CompanySerializer to do the updates for this one? Then, if there are any consistency errors, we'll at least know about them. (It might mean that we have to update modified_on for these updates, but I'm not sure that's necessarily wrong in this case.)

Agree with point 1 - it's an implicit part of the model that a subsidiary can only belong to a global hq, so it should be an error if this is not true
As far as override goes - my assumption is that any companies that re currently marked as subsidiaries of a global hq are correct - this is not data we migrated from CDMS, it's only possible to create this in Data Hub, so if users have created subsidiaries we should respect their knowledge. However there may be cases where we need to overwrite the user data, so override remains optional.
And as far as who creates the data - I'm guessing this will be the output of the cleanup tool?

@jim68000 👍

And as far as who creates the data - I'm guessing this will be the output of the cleanup tool?

Ehm, unfortunately they said that they don't have enough time to help us sort out subsidiaries as well but they can just commit to One List specific matching tasks.
We might have to create a separate tool to send to individual global account managers and ask them to sort out their company's subsidiaries instead.

@reupen @marcofucci now it uses CompanySerializer to validate the data. Also added extra validation for Company that was missing.

@marcofucci I have two remaining commands to update name and trading_name (alias) that accept CSV. Is that also not needed? (those are to clean up company names from ghq etc)


[top] Add a multi-clock crossbar for the LC_CTRL DMI TLUL interface

The external LC_CTRL DMI TLUL interface operates on the main clock, whereas the LC_CTRL IP operates on the periphery clock. To cross those clock domains, we add a 1x1 crossbar between this TLUL interface that supports different clocks for each port.
To attach the external LC control TLUL interface to a crossbar, it required a few changes:

The TLUL interface is not defined as an intersignal anymore. Instead, it is defined as a bus interface. This change caused the original device TLUL interface that did not use a dedicated name to be assigned the name core, and the external TLUL interface is assigned the name dmi. This causes, however a change in the generated register tops.
A new xbar was added top the top, to  interface the top-level TLUL interface to the external TLUL interface of the lifecycle controller

Closing to continue in https://github.com/lowRISC/opentitan/pull/20508


Add SuspendFunWithCoroutineScopeReceiver Rule

Fixes https://github.com/detekt/detekt/issues/4587

Ah, there is the default configuration. I've already searched for it :D

I forgot the embedded Kotlin compiler provided by Gradle uses a different language API than the actual compiler executing the tests. So you can't use Duration, a inline class with compile-test-snippets=true.

I just found this on the project I work: fun foo(block: suspend TestCoroutineScope.() -> Unit) {}. This is basically the same issue. Should we handle it in this rule too?

@BraisGabin Sure, added

Oh, it seems that #4630 is making this PR to fail now. I suppose that they are just the indentation of """.

Yeah, fixed it.

@BraisGabin What about changing compile-test-snippets to true by default, to run this check with gradlew build too?

@BraisGabin BTW are you sure about flagging lambdas too? In IntelliJ, only the function with the receiver is marked, but I don't know if this is a bug of IntelliJ...
import kotlinx.coroutines.*
import kotlin.time.Duration.Companion.seconds

suspend fun main() {
    coroutineScope {
        receiver()
    }
    block {
        launch {

        }
    }
}

suspend fun CoroutineScope.receiver(block: suspend CoroutineScope.() -> Unit) { // Ambiguous coroutineContext due to CoroutineScope receiver of suspend function
    delay(1.seconds)
    launch { // Ambiguous coroutineContext due to CoroutineScope receiver of suspend function
        delay(1.seconds)
        block()
    }
}

suspend fun block(block: suspend CoroutineScope.() -> Unit) {
    delay(1.seconds)
    coroutineScope {
        delay(1.seconds)
        block()
    }
}

block {
  launch { } // Which scope am I using the one from suspend or the receiver?
}

I think that the issue is the same. But can you open an issue to intellij to confirm that is a missing part on their end?

Sure.
CoroutineScope: the inner one wins
coroutineContext: this is the problem, because the outer one wins.

Honestly, after reading https://youtrack.jetbrains.com/issue/KTIJ-12776 and https://youtrack.jetbrains.com/issue/KTIJ-13692/Ambiguous-calls-to-coroutineContext-should-be-reported, I still don't know, when we should mark every coroutine builder (suspend lambda with coroutinescope).
https://youtrack.jetbrains.com/issue/KT-52042/Clarifying-suspend-lambda-and-function-with-coroutineScope-as-pa

We can wait to see what they say in the new issue. But for me the issue is the same. In the body of those lambdas is confusing what coroutineContext mean. And that's the main reason to use forbid it in funs.

@BraisGabin Got an interesting answer. https://youtrack.jetbrains.com/issue/KT-52042/Clarifying-suspend-lambda-and-function-with-coroutineScope-as-pa#focus=Comments-27-6029021.0-0
So I would revert marking the lambda parameter too and focus on suspend fun CoroutineScope.foo only.


Mark post as ready

Make it possible for the captain to mark the post as ready with a slash command. After it has been marked as ready, the bot will mark will close the post and not handle it any further. After replays have been uploaded in a post, the bot could suggest to the captain that if everything is done, mark the post ready with the slash command.

@Juholei Who should be granted permission to use that command? RL Captain and RL Organizer or just the captain/organizer?

I think both in this case


🐛 BUG: D1 Data import fails

Which Cloudflare product(s) does this pertain to?
D1
What version of Wrangler are you using?
2.10.0
What operating system are you using?
Windows 11 x64
Describe the Bug
D:\cloudflare\archived1>wrangler d1 execute archive_tg_db --file=10.sql
Delegating to locally-installed<EMAIL_ADDRESS>over global<EMAIL_ADDRESS>Run `npx wrangler d1 execute archive_tg_db --file=10.sql` to use the local version directly.

▲ [WARNING] Processing wrangler.toml configuration:

    - D1 Bindings are currently in alpha to allow the API to evolve before general availability.
      Please report any issues to https://github.com/cloudflare/workers-sdk/issues/new/choose
      Note: Run this command with the environment variable NO_D1_WARNING=true to hide this message

      For example: `export NO_D1_WARNING=true && wrangler <YOUR COMMAND HERE>`

--------------------
🌀 D1 is currently in open alpha and is not recommended for production data and traffic
🌀 Please report any bugs to https://github.com/cloudflare/workers-sdk/issues/new/choose
🚧 To request features, visit https://community.cloudflare.com/c/developers/d1
🚧 To give feedback, visit https://discord.gg/cloudflaredev
--------------------

🌀 Mapping SQL input into an array of statements
🌀 Parsing 10000 statements
🚣 Executing on archive_tg_db (5f2568d5-8c19-4004-951e-a475a16b2d9b):

X [ERROR] Received a malformed response from the API

  <!DOCTYPE html>
  <!--[if lt IE 7]> <html class="no-js ie6 oldie" lang="en-US"> <![endif]-->
  <!--[if I... (length = 6515)

  POST
  /accounts/d7fd792641c0f950e8e4979eac0cfe5a/d1/database/5f2568d5-8c19-4004-951e-a475a16b2d9b/query
  -> 504 Gateway Time-out

  If you think this is a bug, please open an issue at:
  https://github.com/cloudflare/workers-sdk/issues/new/choose

Unable to import data. Have to retry several times then it succeeds. Also there should be a auto retry parameter. like --retry=3

We shipped a new backend for D1, which should fix this issue - you can read more about it here: https://blog.cloudflare.com/d1-turning-it-up-to-11/

We shipped a new backend for D1, which should fix this issue - you can read more about it here: https://blog.cloudflare.com/d1-turning-it-up-to-11/

Got it. But I've tried several times via email and all but they never provided more storage capacity. And i can't test D1 with 100 MB. Can you help increase it. As without it cannot test it properly and I've to use Mongodb for large datasets. My work doesn't affect any production environment or data loss doesn't affect me either.
Email for CF is admin at hashhackers dot com