[SPARK-47243][SS] Correct the package name of StateMetadataSource.scala

What changes were proposed in this pull request?
The package name for StateMetadataSource.scala is defined as org.apache.spark.sql.execution.datasources.v2.state, but it is in the org/apache/spark/sql/execution/datasources/v2/state/metadata directory. This pr corrects its package name to org.apache.spark.sql.execution.datasources.v2.state.metadata to ensure consistency.
Why are the changes needed?
Correct package name of StateMetadataSource.scala
Does this PR introduce any user-facing change?
Yes, the package name of StateMetadataSource.scala changed from  org.apache.spark.sql.execution.datasources.v2.state to org.apache.spark.sql.execution.datasources.v2.state.metadata , but this feature was added in Apache Spark 4.0, it has not been released yet.
How was this patch tested?
Pass Github Actions
Was this patch authored or co-authored using generative AI tooling?
No

+1, LGTM. Merging to master.
Thank you, @LuciferYang.

Thanks @MaxGekk and @dongjoon-hyun ~


Fix isEmailAddress function

Closes #645

[x] Running yarn lint does not trigger any linter errors
[x] The test of the method you have fixed is passing
[x] You have written a new skeleton method for someone else to work on!
[x] You have written tests to accompany your skeleton method

@davcs Thanks. OOooooOO vector math!  Thanks!


Spring Boot 2.x 的Endpoint为actuator

https://github.com/spring-cloud-incubator/spring-cloud-alibaba/blob/master/spring-cloud-alibaba-examples/sentinel-example/sentinel-core-example/readme-zh.md中的Spring Boot 2.x 的Endpoint为actuator

Don't understand what you mean, can you describe it more clearly?

Welcome to create pull request to fix this.


Transaction Type Lookup Table - Center Automatic Payment Checkboxes

The checkboxes for the automatic payment column is left aligned - it needs to be centered.

Issue resolved.


DDAssert for Swift

New Issue Checklist

[x] I have read and understood the CONTRIBUTING guide
[x] I have read the Documentation or CocoaDocs
[x] I have searched for a similar issue in the project and found none

Issue Description and Steps
It seems there is currently no equivalent for DDAssert in CocoaLumberjack's Swift API. Would you be open to adding this? I thought I'd ask before I send a pull request.
I'd like to see two Swift functions, mimicking what's available in the Swift stdlib: DDAssert and DDAssertionFailure.
I imagine the implementation would look something like this:
public func DDAssert(_ condition: @autoclosure () -> Bool, _ message: @autoclosure () -> String, level: DDLogLevel = defaultDebugLevel, context: Int = 0, file: StaticString = #file, function: StaticString = #function, line: UInt = #line, tag: Any? = nil, asynchronous async: Bool = false, ddlog: DDLog = DDLog.sharedInstance) {
  if condition() {
    DDLogError(message, level: level, context: context, file: file, function: function, line: line, tag: tag, asynchronous: async, ddlog: ddlog)
    Swift.assertionFailure(message, file: file, line: line)
  }
}

public func DDAssertionFailure(_ message: @autoclosure () -> String, level: DDLogLevel = defaultDebugLevel, context: Int = 0, file: StaticString = #file, function: StaticString = #function, line: UInt = #line, tag: Any? = nil, asynchronous async: Bool = false, ddlog: DDLog = DDLog.sharedInstance) {
  DDLogError(message, level: level, context: context, file: file, function: function, line: line, tag: tag, asynchronous: async, ddlog: ddlog)
  Swift.assertionFailure(message, file: file, line: line)
}

+1 for this (as it just came up again :-))
@bpoplauschi thoughts on reviewing/merging if someone puts up a PR?

@ole @diederich I like this idea. If someone has the time to create a PR, I will make sure it is merged and published soon

@bpoplauschi Cool. I'll send a PR in the next few days.

Implemented in #934.


Switch to client-server

Server has full game state, clients have Perception, history, etc.. Server performs state changes, clients have AI and UI (both can be enabled or disabled, even partially, e.g., AI for all but 1 member of the party, or full AI control, but display of game board via UI). The clients and the server either run on different threads or in different executables and then communicate via network. Naturally many players and many independent AI parties are then possible.

The separation of engine/content would be completely orthogonal to client/server. The content files would probably land in the common library or server land, while the config files would apply to both client and server (probably need to be split into server config and client config).

Log of an initial design discussion:
10:47 < kosmikus> mikolaj: re client/server: very funny. back when I started LambdaHack as a student project, my
original plan was to make it client/server. but then I quickly abandoned the idea. I still think
it'd be better though.
10:50 <@mikolaj> kosmikus: sure, it forces a better separation of concerns in code, better control of "cheating" by
AI, etc., not to mention PvP, etc., etc.
10:50 <@mikolaj> no idea how hard it will be though
10:51 < kosmikus> the main issue is hammering out an interface
10:51 < kosmikus> the rest should follow from there
10:51 <@mikolaj> bah
10:51 < kosmikus> :)
10:51 < kosmikus> one point to think about: you'll probably end up with some duplication between the two
10:51 < kosmikus> so you might as well still have a common library
10:52 <@mikolaj> sure; actually I intend to have all: AI client, UI client and server in each exe and switch
components on and off on the fly
10:53 <@mikolaj> e.g., put some party members under AI, or peak into AI party action via UI
10:53 <@mikolaj> peak/peek
10:53 <@mikolaj> so the interface between the components will be inside Haskell, first
10:54 < kosmikus> most of the things that are currently there are probably server anyway
10:54 <@mikolaj> yes
10:54 <@mikolaj> then, a version of the interface will be translated to a network protocol
10:54 <@mikolaj> or something
10:54 < kosmikus> so it's really just the frontend stuff that isn't
10:54 <@mikolaj> and AI
10:55 < kosmikus> well, yes
10:55 < kosmikus> although you probably don't want to end up having to run a client for each monster :)
10:55 <@mikolaj> I will switch AI to think about a party as a whole
10:56 <@mikolaj> but each monster will have a mind, too
10:56 < kosmikus> right
10:56 < kosmikus> swarm intelligence is certainly a nice feature
10:56 <@mikolaj> then each party will have a AI "client"
10:56 < kosmikus> also, the game should still be allowed to cheat, within limits
10:56 <@mikolaj> agreed, but I'd rather explicitly allow that by sendint cheating info within the protocol
10:57 < kosmikus> aha, but if you allow that via the protocol, then people can write cheating clients, too
10:57 <@mikolaj> in the future authenticating so that only true AI can get that, not malicious players
10:57 <@mikolaj> yeah :)
10:57 < kosmikus> I see
10:57 <@mikolaj> well that's tricky
10:58 <@mikolaj> perhaps the "authentication" will be just residing in the same exe as the server
10:58 < kosmikus> I think for starters you can just work with capabilities that the server can hand to the clients
10:58 < kosmikus> since the server will probably start the client for the AI
10:58 < kosmikus> it can grant more permissions to that one
10:59 <@mikolaj> oh, shrewd
11:00 <@mikolaj> anway, players disconnecting AI and posing as AI, etc., etc., if far future :), I'd love to get
there :D
11:00 < kosmikus> sure
11:00 < kosmikus> lots of fun


[BUG] Corrupt token is allowing activation of the membership.

Description
Created a new account (A1) and invited an another new user to the team.
Copied the invitation link, corrupted the attached token with random values and opened it in the browser.
Entered password for SignUp.
Automatically adds me to the A1 account team.
Steps to reproduce the behaviour:

Login Using Email and Password.
Invite new User
Open the invitation email and copy the link
Corrupt the token by replacing any character with a random character.
Open link, enter password.
Automatically adds to the invitee organization.

Important Details

Version: Cloud
OS: MacOs 10.14.6
Browser: Firefox 80.0.1 (64-bit).

We no longer use invitation tokens. The new user is added to the organization when the invitation is sent out to them. The signup link is only for their account accessibility.
In order to fix this, we need to remove the unused query parameter token from the URL being sent in the email. This can be done by removing the token parameter in variable INVITE_USER_CLIENT_URL_FORMAT in UserServiceImpl.
The function createNewUserAndSendInviteEmail in the same class also needs to remove the token replacement when it constructs the email parameters.

Verified the issue and works as expected


Init

What

init assumed roles tf module

Why

automate IAM roles creation

Please add:

[ ] groups associated with each role


Autoformatter fails after closing an unneeded pull request.

The autoformatter job fails after closing an unneeded pull request.
No formatting changes were made
✓ Closed pull request tmp398243/tmp32487543#6 (gbruer/enkf-extension - Automatic JuliaFormatter.jl)
failed to run git: error: pathspec 'main' did not match any file(s) known to git

Error: Process completed with exit code 1.

It doesn't always fail. Seems to be related to switching to 'main' branch.
No formatting changes were made
✓ Closed pull request tmp398243/tmp337502#4 (main - Automatic JuliaFormatter.jl)
✓ Deleted branch auto-formatter/main and switched to branch main


Logs are getting bigger and bigger

This is new in Ghost v1
I feel this is overkill for most installations. In 7 days, the size of my logs in prod is about 140 MO.
@acburdine can you points us to some docs about the level of the log we can collect?
I looked in https://docs.ghost.org/v1.0.0/docs/cli-log#section-options and there is no mention of this.
Cheers!
Pascal

I found this from the npm docs.
loglevel
Default: "warn"
Type: String
Values: "silent", "error", "warn", "http", "info", "verbose", "silly"

I think it would make sense to use error instead of warn.
We could also add this info as a comment in the Dockerfile.
Make sense?

Does Ghost itself read the NPM_CONFIG_LOGLEVEL environment variable? (that seems odd)

https://docs.ghost.org/v1.0.0/docs/config#section-logging seems to be the relevant config section

So, something like -e logging__level=error should do the trick; testing now.

Yep, works great!
$ docker run -it --rm --name ghost -e logging__level=error ghost:1-alpine
[2017-08-21 22:37:23] INFO Finished database migration!

(I've already sent several requests to this instance, and there are no logs for the events.)

What you POV about using error in prod @tianon ?

My opinion is that folks should choose what makes sense for themselves, and
that our image ought to not deviate from the defaults provided by upstream
without strong rationale.

The reason why default is warn is because the default NODE_ENV is also development. So the image itself is currently in the same context. It is a development setup. Not a production setup. (But changing that only takes 2 env vars)

Hey @SISheogorath
Here we can see that NODE_ENV = production.
I guess I'm missing something here:

The reason why default is warn is because the default NODE_ENV is also development.

@pascalandy Looks like I missed that ^^ I was totally sure that it's still development. In this case, it makes sense to modify the loglevel, too. Maybe creating an upstream issue that changes the default loglevel for production would be useful.

Indeed, I think this should be taken up with upstream to see what their opinion would be about changing the default loglevel for production to something less verbose. :+1:


dns/sni: Reduce duplicated code in network tracers

Reduce duplicated code in network tracers
This PR also moves the attachment key's management internally into the tracer itself to avoid callers generating a key that was always the network namespace (it can be computed internally from the PID).

I was a bit confused because there is a map inside a structure that is saved in another map. Perhaps we can move that inside map to the outer structure and make the code a bit simpler?

Mmmm yeah, we could, but the problem with that approach is that the variables Tracer.pidToNetNs and attachment.users keep track of basically the same information, so it is a little bit redundant. My idea was to have this:

Tracer keeps track of the attachments, one for each network namespace.
Each attachment keeps track of its users, one for each PID.

That's why we have a map with key netns and value an attachment. Then, each attachment, among other fields, has a map with key PID and the value struct{} (it is just because the lookup is quicker than a slice).
What do you think?

I think the only difference is in Detach(), your proposal has to perform multiple lookups in the different users map of each attachment, while the change I suggested only needs two lookups, one in pidToNetNs and another one in attachments.
I'm fine with both approaches, if you feel more comfortable with the current one go and merge it!

I think the only difference is in Detach(), your proposal has to perform multiple lookups in the different users map of each attachment, while the change I suggested only needs two lookups, one in pidToNetNs and another one in attachments.

Agree. The lookup is faster, but we also need to update both users and pidToNetNs at every attach/detach. That's what I find redundant. I think both have pros and cons. I will go ahead with the current approach, but let's monitor it.


[NIFI-7470] - ElasticsearchHttp malformed query when using Fields

Change "_source_include" to "_source_includes" in response to [NIFI-7470], so that queries work.
Enables using the Fields functionality in elasticsearch queries. fixes bug NIFI-7470.
Adds an 's' character to the String FIELD_INCLUDE_QUERY_PARAM so that it won't break the queries when using Fields in ElasticSearch HTTP processors.

It seems like that Elasticsearch deprecate the _source_include and _source_exclude url parameters in favor of _source_inclues and _source_excludes in 7.7.0. Could you compatible with previous versions and add some unit tests?

Clould you add some unit tests after you changed the to compatible with previous versions of ES?


Update etcd to v2.2.0

Discussing with @jfmyers9 we believe there is a race condition on startup which doesn't play nice when etcd expects to be able to find itself over consul DNS.  We don't need this bump right now, closing PR.


Make SubprocVecEnv Thread Safe

As discussed in issue #217, SubprocVecEnv uses on Unix systems the non-thread-safe fork method of multiprocessing, which can cause issues e.g. when the parent process has an extant TensorFlow session. This PR changes SubprocVecEnv to use the thread-safe spawn method.

Only real downside of spawn is that it's slower than fork. On my system, it introduces around a 5 second fixed cost to environment setup; this might be larger for complex projects with more imports. I expect this overhead to be negligible for RL training, but could be moderately annoying for interactive use. Users could always switch to DummyVecEnv in such cases; we could also make the method multiprocessing uses configurable.
Before PR:
0 rollouts
Time:  [0.3692049980163574, 0.39535021781921387, 0.31310319900512695]
1000 rollouts
Time:  [2.1021463871002197, 2.0643362998962402, 2.264810800552368]
10000 rollouts
Time:  [19.19278883934021, 19.433793306350708, 19.497289896011353]

After PR:
0 rollouts
Time:  [5.425152778625488, 5.514942646026611, 5.524834871292114]
1000 rollouts
Time:  [7.168581247329712, 7.421223163604736, 7.134859561920166]
10000 rollouts
Time:  [23.813771963119507, 23.359588384628296, 23.930598735809326]

Generated using:
import time

import gym
from stable_baselines.common.vec_env import SubprocVecEnv

ENV_NAME = 'SeaquestNoFrameskip-v4'
N_ENVS = 8

def benchmark(n_steps):
    def make_env():
        return gym.make(ENV_NAME)

    venv = SubprocVecEnv([make_env] * N_ENVS)
    venv.reset()
    for i in range(n_steps):
        action = [venv.action_space.sample() for _ in range(N_ENVS)]
        venv.step(action)
    venv.close()

if __name__ == '__main__':
    for n in [0, 1000, 10000]:
        print('{} rollouts'.format(n))
        times = []
        for rep in range(3):
            start = time.time()
            benchmark(n)
            end = time.time()
            times.append(end - start)
        print('Time: ', times)

Hello Adam,
Thank you for your contribution.
I'll be AFK until wednesday, so unless @hill-a or @erniejunior have time before, you'll need to wait a bit before having some feedbacks ;)

Using forkserver on platforms where it's available improves performance and is still thread safe. It's still slower than using fork, though. Benchmark:
0 rollouts
Time:  [3.565499782562256, 3.5964715480804443, 3.493802785873413]
1000 rollouts
Time:  [5.70629620552063, 5.803895950317383, 5.861036539077759]
10000 rollouts
Time:  [27.23869800567627, 27.16290044784546, 26.949447870254517]

Hey,
I think you should add a hyperparameter to SubProcVecEnv, such as subprocess_type=None, and if it is None, keep the autodetect forkserver else spawn, otherwise use the given type.
This is mainly because the environment might need a global variable, forkserver and spawn might lead to unexpected behaviour, and it would make much more sense to empower the user (ref).

@hill-a thanks for the feedback, I agree this is an improvement, incorporated.
I've also written a test case, but it depends on some helper functions I wrote for PR #217. I'm planning on adding that test case into this PR once PR #217 is merged; if that doesn't happen, I'll backport the tests.

@AdamGleave you meant PR #207 ?
That's a good thing you added a test.

I'm planning on adding that test case into this PR once PR #217 is merged; if that doesn't happen, I'll backport the tests.

There is a high probability your two PR will be merged ;)
It just take some time because this is a side project for all the three maintainers and I would say it is better to be sure about a feature than merging too fast something and breaking master branch.

Yes I meant PR #207 -- sorry. No problem, I understand things can take a while. I'm happy using my fork until things get merged, so there's no rush.

Updated with latest changes to master and added the test case.

The failure on travis is due to a memory error. I suspect it to be related to what I experimented when trying to do hyperparameter search in the rl zoo.
My solution was to kill the different processes to avoid taking all the RAM.
See fix here

You can try to cherry-pick this comit: https://github.com/hill-a/stable-baselines/commit/987cfdfdd99a3f13989884c53760f9c61280d7d6
(on the gailt-test branch)

Thanks @araffin. I'm a little confused why we need to kill the processes explicitly -- shouldn't this happen when venv.close() is called? I ran into a similar problem with processes not being terminated that seems related to an OpenMPI bug, see https://github.com/HumanCompatibleAI/adversarial-policies/issues/3, perhaps it's the same issue. If we can't figure out the underlying cause then this seems like a good workaround.

I'm a little confused why we need to kill the processes explicitly

Good remark, I did not noticed that method (I thought it was related only to the render() method). Could you try calling it in the different run_atari.py scripts (as in my commit) ? (this is what takes a lot of memory)

I made the changes here: https://github.com/hill-a/stable-baselines/pull/206/commits/6e655a7417b7d5eb23acef0d538395b8d781de28
Let's hope it will solve the issue.

@araffin thanks, closing the VecEnv after my tests has resolved the memory issue for this PR.

Hello @AdamGleave ,
Because of your good contributions, and as we need more people like you to help us improve stable-baselines, we would like to propose you to join us and become maintainer of this repository.
You will have the ability to create branches, do code reviews and will be obviously credited in the README ;)
With @hill-a  and @erniejunior  in CC

EDIT related to your PR
I'm experimenting several issues with the new behavior on different machines (pytest hang, weird seg fault errors, python asking me to put everything in __main__ or to call freeze_import()), so we may switch back to the previous behavior (to avoid breaking people code) but adding a warning to the documentation.
The cool thing with your PR is that the user has still the ability to change that behavior.

Hi @araffin,
Thanks for the offer of joining the team! Potentially interested depending on time constraints -- I'll send an e-mail to discuss this further in private.
In terms of the PR, I'd be happy for the default behaviour to be switched to fork if we feel this will break fewer things by default. The requirement to put stuff in __main__ is expected behaviour, but the other problems "should not" happen.
Were the problems you were experiencing related to MPI at all? In particular, if the segfault had anything involving pmix, it's probably MPI related. I also experienced strange hangs with MPI. I think MPI in general tends to interact poorly with Python multiprocessing, they're very different programming paradigms. I can't see many use cases for both SubprocVecEnv and MPI-based RL algorithms, so if this is the problem then one workaround might be to only ever import mpi4py lazily when it's actually needed.

In terms of the PR, I'd be happy for the default behaviour to be switched to fork if we feel this will break fewer things by default.

Yes, that's my main concern, keeping things easy for users (and not breaking their code), even though it has some risk (which are hopefully rare).

Were the problems you were experiencing related to MPI at all?

Yes, some where with MPI,  some where not, but surprisingly enough, it depends on the machine I'm working with.

so if this is the problem then one workaround might be to only ever import mpi4py lazily when it's actually needed.

I think that what they did recently in the Baselines repo. I assume that the number of users affected by those problems is low (we did not have any issue yet) compared to the complexity of making several tweaks to import mpi only when needed.


The library generates proper qr code as expected but the payment fails everytime

I have used this library in a project where it generates QR code for payment to the customer. By scanning it from Gpay or phonepe it shows correctly the Receivers VPA and the amount to be paid but the payment fails every time meanwhile the QR code which the client already uses for the payment works perfectly indicating there's no bank server issue

Happened with me as well, not with bhar4t/upiqr but I implemented something similar, there the QRs were partially working (only amount, and payeeVPA) but the payments failed with the intent links. We are missing something very important, Sadly this isn't documented well enough anywhere :(
see this: https://www.labnol.org/files/linking.pdf

Works well with phonepe merchant upi ids

This seems to be API/server issue, hence closing the issue, Thanks!


Setup repo and add fifo queue + clock

This adds a FIFO queue package and the clock contract. The queue data-structure is tested, the clock is not.

Some remaining TODO items:

Setup CI (interchaintest + schema generation + unit test).
Test clock.


Not renaming / moving the files (using WSL , folder in windows itself)

And how do I run it as an app? Or is it just the demo command

It's not really supposed to, as it only has demo mode currently


License updates for computed-notices

This PR was auto generated by the licensed-ci GitHub Action.
It contains updates to cached github/licensed dependency metadata to be merged into computed-notices: (branch, PR).
The licensed-ci action will add comments to this PR with the status of license checks.  Please make any changes needed to fix any status failures on this branch, then merge license updates into your branch.
If updates are unexpected, please check the github/licensed changelog for recent updates.

The licensed-ci GitHub Action updated cached license metadata based on changes to computed-notices: (branch, PR).
licensed status result: SUCCEEDED
All status checks succeeded, please merge when ready.
Checking cached dependency records for licensed
....................
20 dependencies checked, 0 errors found.

/cc @jonabc


Windows ARM Not charging

Windows OS is newly installed and have a default charger but still not charging even battery saver not showing
Device : POCO F1
My charger details :
input 100-240v-50/60hz
output 5v==2a
Maybe causing a problem:
Drivers
Outdated WindowsARM OS

The smartphone will be charged only from power supplies supporting QC 3.0 and higher!! or use the docking station.

The smartphone will be charged only from power supplies supporting QC 3.0 and higher!! or use the docking station.

What you mean for this sir

https://en.m.wikipedia.org/wiki/Quick_Charge

So it will charge if i change the adaptor with that ?

https://en.m.wikipedia.org/wiki/Quick_Charge

I used the orginal charger that you suggest but same problem is not charging on windows boot

Your wire may not have a +/- data line.
Check the connector, it may be damaged or dirty.
Charging works fine on my poco f1, but sometimes it may not work on the first try.

Its charging on android boot but on windows is not i used dual boot on my poco F1

Use PD chargers instead of QC ones. The driver doesn't support QC currently.


Area of trapezoid in c

Why
Closes #498

Code
#include <stdio.h>
	int main()
	{
	float b1;
	float b2;
	float h;
	float area;

	printf("Enter Base 1: ");
	scanf("%f",&b1);
	printf("Enter Base 2: ");
	scanf("%f",&b2);
	printf("Enter Height: ");
	scanf("%f",&h);

	area=(b1+b2)*h/2;

	printf("The area of a trapezoid with Base 1 as %.1f, Base 2 as %.1f, and Height as %.1f, is: %.1f",b1,b2,h,area);
	return 0;
}

Hey @martyn-su
Is there any issue with this PR ?


Revise Administration / Access Services Outside the Cluster page

Description

[x] Check default service type of all the current applications, and eventually update it
[x] Revise how to create a new service, and how to expose it for internal network access
[x] Explain how to expose to the internet a given service

Also, new commands are tested with a umh instance.
Related issues
close united-manufacturing-hub/MgmtIssues/issues/1331
Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have read the contributing guidelines and the code of conduct.
[x] I have followed the documentation style.

I am waiting for @DaruZero to review first


Incorrect Metro Area Bed Count

@igorkofman James asked me to tag you
summary
[from user]
From the main US map, I clicked on the state of Texas.  That page shows the overall state grid and then a map in the upper right corner with counties highlighted.  When I clicked on Williamson County, this is the link it goes to and shows all those counties combined.
https://covidactnow.org/us/tx/county/bastrop_county_hays_county_travis_county_williamson_county
expected result
3673 Total beds
Bastrop County - 6 beds
Hays County - 330 beds
Travis County - 2533 beds
Williamson County - 804 beds
actual result
6 beds
environment
Web
link
https://covidactnow.org/us/tx/county/bastrop_county_hays_county_travis_county_williamson_county
screenshot

P.s. is the metro area feature is supposed to be live and available to users?

Seeing this merge on the front end with the following counties as well

Adams & Jefferson Counties - https://covidactnow.org/us/co/county/adams_county_jefferson_county
Larimer & Weld Counties - https://covidactnow.org/us/co/county/larimer_county_weld_county
Multnomah and Washington Counties - multnomah_county_washington_county

Obsolete.  Clicking on counties should no longer take you to combined pages.


Add OWNERS file to openstack-helm

Added OWNERS file to the repository to mirror other repos

What is the purpose of this pull request?:  To add the OWNERS file to declare reviewers and approvers for openstack-helm
What issue does this pull request address?: Fixes #145
Notes for reviewers to consider: N/A
Specific reviewers for pull request: @v1k0d3n

This change is

Actually in comparing to other kubernetes proper repos (meaning, not the one example I was using as my reference), i think these options are perfectly fine. going to merge in.

@alanmeadows would  like your input just before the final merge (if you give me a lgtm).

LGTM


Update Composer dependencies (2022-04-16-00-05)

Visual regression test passed!
View the visual regression test report


galoy-pay improvment

[ ] move repo to nextjs 14 / app router
[ ] update logo (new logo was provided by Andrej)
[ ] better dev workflow so that an account is automatically usable when using buck2 run //dev:up. right now it seems the core api endpoint env variable from is not properly configured? (it might be that this is the case only when opening the link from another device)
[ ] add some tests for receiving payment so we make sure we don't break it as we're refactoring it.
[ ] add receive to NFC for boltcard transaction (we have done it on the mobile app already)
[ ] design improvement https://t.me/blinkbtc/6427
-- I would completely remove the notion of "sats" in the POS, and make it dollar / fiat currently only as an input
-- this is because most people using the POS are the one that are the less trained, and having a fiat/dollar only option will limit the odds that they put a sats number instead of a dollar amount
[ ] printing the current transaction after it has been received (with bluetooth NFC that are enabled on bitcoinize POS)
[ ] "sign with blink" to see past transactions
[ ] make the interface translatable by plugging it into transifex

need backend work

[ ] make it onchain enable

-- I would completely remove the notion of "sats" in the POS, and make it dollar / fiat currently only as an input

@m36connect thoughts?

"I would completely remove the notion of "sats" in the POS"
in that case, what do we do if we're selling stuff denominated in sats?

"I would completely remove the notion of "sats" in the POS"
in that case, what do we do if we're selling stuff denominated in sats?

good question. how much are the team in Ekasi using the POS versus the mobile app?
This thinking is only for the POS / web-based app.
The reason is because most of people using it are the one that are less educated on using bitcoin, and making it only available in local currency make it that they have less ways to get it wrong.
But an option suggested by Andrej is to have SATS as a currency you could choose. in that case it would be SATS only (no fiat equivalent).
The goal is also to have less information on the screen, there is currently too much things. That make it harder to use for (very) occasional and uneducated users

@nicolasburtey
In response to:
> I would completely remove the notion of "sats" in the POS, and make it dollar / fiat currently only as an input
In our pursuit to drive Bitcoin adoption we have to slowly but surely shift the perspective from thinking fiat to thinking SATS, if you remove SATS completely what does that represent; "Bitcoin in disguise" I guess?
It's time we take the next step and start denominating products in SATS so suggestion by Andrej to:
> have SATS as a currency you could choose
is a step in the right direction.
@bitcoinekasi we use both the Blink PoS and the Mobile Wallet.
Lastly in response to:
_**> The reason is because most of people using it are the one that are less educated on using bitcoin, and making it only available in local currency make it that they have less ways to get it wrong.
This is precisely what needs to change; Bitcoin adoption is about changing the way one thinks and the future is create by how we approach it, if we keep repeating the patterns the fiat supporters conforms to we will not realise the future we believe is possible through the solution that Bitcoin is.
To conclude:

Let's display SATS first and foremost and have the currency conversion as an option to be displayed.
And encourage merchants to denominate their products in SATS eliminating conversion mistakes.

This is precisely what needs to change; Bitcoin adoption is about changing the way we think to create a better future, if we keep repeating the patterns that fiat supporters conforms to we will not realise the future we believe is possible through the solution that Bitcoin bring.

the input on this thinking is that, currently in El Salvador, merchants are favoring blink because it's too complex for their employees, and so they are converging for other solutions. there is a high turnover for employees and they don't get trained on using POS for a credit card, but needs to get trained for bitcoin, unless we make it as simple as with a credit card
but I understand you are in a different category that may need a different front end interface. we'll have to think on how to go about that, maybe with some settings that could be activated or not

"But an option suggested by Andrej is to have SATS as a currency you could
choose. in that case it would be SATS only (no fiat equivalent)."
This would be a good solution.
Hermann Vivier
Chairman
Bitcoin Ekasi
bitcoinekasi.com
On Tue, 13 Feb 2024 at 22:20, nicolasburtey @.***>
wrote:

This is precisely what needs to change; Bitcoin adoption is about changing
the way we think to create a better future, if we keep repeating the
patterns that fiat supporters conforms to we will not realise the future we
believe is possible through the solution that Bitcoin bring.
the input on this thinking is that, currently in El Salvador, merchants
are favoring blink because it's too complex for their employees, and so
they are converging for other solutions. there is a high turnover for
employees and they don't get trained on using POS for a credit card, but
needs to get trained for bitcoin, unless we make it as simple as with a
credit card
but I understand you are in a different category that may need a different
front end interface. we'll have to think on how to go about that, maybe
with some settings that could be activated or not
—
Reply to this email directly, view it on GitHub
https://github.com/GaloyMoney/galoy/issues/3979#issuecomment-1942389734,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDB4ZPX4BA2OWOES4MYS4FLYTPDI7AVCNFSM6AAAAABDD4ATTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBSGM4DSNZTGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

I like having SATS as a separate currency. Then there will be less visual clutter in the POS because less things will need to appear in the POS. Also less chance of making a mistake.
Cashiers don't even care about the price of bitcoin so I'm not sure why the price of BTC is shown there at all (above the keypad). I would remove that one as well.
I was onboarding a merchant and they in fact entered 10 satoshi instead of the actual currency. I could have easily scammed them if I wanted. Also, I saw the mistake just a second before pressing the Send button from my wallet.
Another thing I just saw is that if I set my currency in the app the EUR and then click -> how to get paid -> open pos in browser, the currency in the POS will default to USD, even though I had EUR in the app. This is also something that makes things hard for the cashiers who only want to click a few numbers and don't think too much.
Currently the POS is way too complicated, shows unnecessary things and doesn't show the important things clearly and it's not def not convenient for new people. I want to onboard people with Blink but I can't for the mentioned reasons and I have to offer them to do it with WoS... Please treat this is a higher priority and let's all make Blink the go-to wallet and pos-service.

@ishristov we're actively working on it. you can expect all the bullets points listed in this issue to land in the upcoming weeks.

Cashiers don't even care about the price of bitcoin so I'm not sure why the price of BTC is shown there at all (above the keypad). I would remove that one as well.

That may be the case in some places, but here in Turkey under extreme inflation and permanently changing exchange rates, there is a pressing market demand by payers to know what exchange rate they are getting to make an educated decision if they want to take the deal they are offered.

Cashiers don't even care about the price of bitcoin so I'm not sure why the price of BTC is shown there at all (above the keypad). I would remove that one as well.

That may be the case in some places, but here in Turkey under extreme inflation and permanently changing exchange rates, there is a pressing market demand by payers to know what exchange rate they are getting to make an educated decision if they want to take the deal they are offered.

shouldn't the payer get the rate from their wallet?
IMO, it makes little sense to trust the POS, when hidden fees are unfortunately too common.

Driver for the bitcoinize POS: https://github.com/yyzz2333/NyxPrinterClient

closing this ticket for now. will reopen more dedicated issue for things to improve


phantomjs mode seems sucked at post step

problem may come from there:
var fetch = JSON.parse(request.postRaw)
And postRaw is
"post": {
"method": "GET",
"url": "https://www.twitter.com"
},
"postRaw": "url=https%3A%2F%2Fwww.twitter.com&method=GET",
seems JSON.parse can not parse the string. Maybe because the package Requests?

Could you give me an example to reproduce this issue?

Actually I have no idea why this happened, not often but sometimes. When I backtracked it, seems there's no post attribute in request class but postRaw, in fact it should be from what you implemented in code, but funny thing is that the postRaw has the value like what I comment in the issue, and which can not be parsed in JSON.parse() function. BTW, there is another issue when I try to access website with SSL by phantomjs, it always return "HTTPError: SSL handshake failed" all the time in every fetch, your demo works well in your machine, quiet strange. I guess probably it's SSL-judgement issue in phantomjs server script, I remembered there is a config for phantomjs to stop SSL-judgement, namely "security" or others. Or could you give some other suggestions about SSL issue?

--ignore-ssl-errors=[true|false]
ignores SSL errors, such as expired or self-signed certificate errors (default is false). Also accepted: [yes|no].
It's an option in phantomjs, probably you can add it into pyspider to let users choose.

postRaw is an attribute of phantomjs's request object. The content of the post body is packed in Fetcher.phantomjs_fetch and should always be a JSON.
--ssl-protocol=any

Thank you! --ssl-protocol=any works!


py2neo Graph creation issue.using py2neo 4.0.0. version

I have created Graph using
def init(self,uri = "bolt://localhost:7687",username='neo4j', password='password'):
self.graph = Graph(uri,user=username, password=password,auth=('neo4j', 'password'))
I have tried to change the port but I am getting the same issue.
Traceback (most recent call last):
File "D:\Python36\lib\site-packages\py2neo\database.py", line 88, in new
inst = cls._instances[key]
KeyError: 'd158bbdc01814f7bdce8ebe3a78d26bc'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "D:\machine_learning_ai_tasks\Auto-complete-System-master\app.py", line 49, in
app = Application(root)
File "D:\machine_learning_ai_tasks\Auto-complete-System-master\app.py", line 16, in init
self.app = Server()
File "D:\machine_learning_ai_tasks\Auto-complete-System-master\src\Server.py", line 38, in init
self.db = Database.DatabaseHandler()
File "D:\machine_learning_ai_tasks\Auto-complete-System-master\src\Database.py", line 12, in init
self.graph = Graph()
File "D:\Python36\lib\site-packages\py2neo\database.py", line 298, in new
database = Database(uri, **settings)
File "D:\Python36\lib\site-packages\py2neo\database.py", line 97, in new
user_agent=connection_data["user_agent"])
File "D:\Python36\lib\site-packages\neo4j\v1\api.py", line 127, in new
return subclass(uri, **config)
File "D:\Python36\lib\site-packages\neo4j\v1\direct.py", line 73, in new
pool.release(pool.acquire())
File "D:\Python36\lib\site-packages\neo4j\v1\direct.py", line 44, in acquire
return self.acquire_direct(self.address)
File "D:\Python36\lib\site-packages\neo4j\bolt\connection.py", line 453, in acquire_direct
connection = self.connector(address, self.connection_error_handler)
File "D:\Python36\lib\site-packages\neo4j\v1\direct.py", line 70, in connector
return connect(address, security_plan.ssl_context, error_handler, **config)
File "D:\Python36\lib\site-packages\neo4j\bolt\connection.py", line 707, in connect
raise last_error
File "D:\Python36\lib\site-packages\neo4j\bolt\connection.py", line 697, in connect
s = _connect(resolved_address, **config)
File "D:\Python36\lib\site-packages\neo4j\bolt\connection.py", line 587, in _connect
raise ServiceUnavailable("Failed to establish connection to {!r} (reason {})".format(resolved_address, error.errno))
neo4j.exceptions.ServiceUnavailable: Failed to establish connection to ('<IP_ADDRESS>', 7687) (reason 10061)
please provide some guidance to resolve the issue.

Hi Farzana,
Thanks for trying out my app.
The issue looks like database connection issue.
I am assuming you are running app.py or import app?
If so I tried the same thing but there is no issue. Below are information from my database. You can use any of the below method to access.
Version 3.3.3 Enterprise Status RUNNING HTTP port 7474 HTTPS port 7473 Bolt port 7687
You should be able to connect without changing the default parameters in DatabaseHandler.__init__()
Please make sure that you have Neo4j database correctly installed. There is an app called Neo4j desktop, which allows you to visualize the data in the database. Verify that you can insert some simple values into DB using Py2Neo library.

Closing for not reproducible.


check style of recipes

The created recipes should follow the style defined in
https://wiki.yoctoproject.org/wiki/Recipe_%26_Patch_Style_Guide
and
http://www.openembedded.org/wiki/Styleguide.
Possibly make checking the style part of some testing process.

@bulwahn < Can this issue be closed?

"Silence implies consent" (see http://wiki.c2.com/?SilenceImpliesConsent).


Request for adding three of my papers relevant to auditing/verification

FairProof: Confidential and Certifiable Fairness for Neural Networks (2024)

Keeping Up with the Language Models: Robustness-Bias Interplay in NLI Data and Models (2023)

XAudit: A Theoretical Look at Auditing with Explanations (2023)

hello, yes of course, can you include them in a pull request ? that is the intended process of awesome lists thanks

got it thanks.. submitted a pr


Login don't work in powershell version 6.1.3

I get this when I try to login:
 Open-JiraSession -Credential $credential -Uri $uri -Save
New-StoredCredential : Argument 'New-StoredCredential' is not recognized as a cmdlet: Could not load type 'System.Web.Security.Membership' from assembly 'System.Web, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
At C:\Users\sdaa\Documents\PowerShell\Modules\jira\0.2.2\jira.psm1:88 char:21
+             $null = New-StoredCredential @storedCredential -Comment " ...
+                     ~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : ObjectNotFound: (New-StoredCredential:String) [], CommandNotFoundException
+ FullyQualifiedErrorId : CmdletNotFoundException

This the current version:
 $PSVersionTable

Name                           Value
----                           -----
PSVersion                      6.1.3
PSEdition                      Core
GitCommitId                    6.1.3
OS                             Microsoft Windows 10.0.17134
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

I guess I need to install something to get this to work. But what exactly?
Get-Module -Name jira

ModuleType Version    Name                                ExportedCommands
---------- -------    ----                                ----------------
Script     0.2.2      jira                                {Add-Comment, Get-Issue, Invoke-IssueTransition, New-Issue...}

Does it work without the -Save?
I am depending on 2 modules that should have auto installed if you installed from the PSGallery. CredentialManager and PSFramework. I don't know if I will keep the option of saving credentials because I don't have a solution for Linux. The save is using the credential store to keep your credential secure.

It works without -Save. Thanks.

Thank you. Please feel free to give me feedback any time.

Created issue #11 to track the work around this


The answer does not match with the question in FAQ

In FAQ, the answer does not match with the question.

Once SAML/WS-Fed IdP federation is configured with an organization, does each guest need to be sent and redeem an individual invitation?
Setting up SAML/WS-Fed IdP federation doesn’t change the authentication method for guest users who have already redeemed an invitation from you. You can update a guest user’s authentication method by resetting their redemption status.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7b1d9428-2dbb-c80b-c2cd-b4841d3d8bd3
Version Independent ID: 20af5f8d-479c-66ec-aacd-d3f9cb79c814
Content: Federation with a SAML/WS-Fed identity provider (IdP) for B2B - Microsoft Entra External ID
Content Source: docs/external-id/direct-federation.md
Service: active-directory
Sub-service: b2b
GitHub Login: @msmimart
Microsoft Alias: mimart

@sscchh2001
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.


Add a trigger migration to enable a bug in ABCI error decoding

This bug is needed to allow legacy behaviour while replaying old blocks. It requires a new migration type to allow for modern behaviour to be enabled by default, which we want moving forward.

Codecov Report

Merging #321 (94b9a32) into main (7754efb) will increase coverage by 0.27%.
The diff coverage is 0.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   83.20%   83.47%   +0.27%
==========================================
  Files         129      128       -1
  Lines       15080    14741     -339
==========================================
- Hits        12547    12305     -242
+ Misses       2533     2436      -97

Impacted Files
Coverage Δ

src/many-error/src/error.rs
67.56% <0.00%> (-1.12%)
:arrow_down:

src/many-error/src/reason.rs
68.18% <0.00%> (-3.25%)
:arrow_down:

src/many-ledger/src/storage/idstore.rs
91.46% <0.00%> (-3.66%)
:arrow_down:

src/many-kvstore/src/module.rs
83.08% <0.00%> (-1.50%)
:arrow_down:

src/many-migration/src/lib.rs

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Assuming CI passes, LGTM!


Fixing 'cutover' position in migration mtv resource

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

need to verify this doesn't break 2.1

/approve

lgtm 👍

/verified

/approve


getting io is not defined

ReferenceError: io is not defined
at Object. (http://localhost:8100/build/main.js:56191:5)
at webpack_require (http://localhost:8100/build/main.js:20:30)
at Object. (http://localhost:8100/build/main.js:100897:77)
at webpack_require (http://localhost:8100/build/main.js:20:30)
at Object. (http://localhost:8100/build/main.js:89023:73)
at webpack_require (http://localhost:8100/build/main.js:20:30)
at Object. (http://localhost:8100/build/main.js:126107:70)
at webpack_require (http://localhost:8100/build/main.js:20:30)
at http://localhost:8100/build/main.js:66:18
at http://localhost:8100/build/main.js:69:10

did you implement io in your project?

yes.
you have to add socket.io to your project. e.g. add your sails.io.js
(SAILS_ROOT/assets/js/depenencies/sails.io.js)
in angular2-sails, io is just declared, but you need to add it yourself

or add sails.io.js to the scripts array of your webpack config

i am using an ionic2 app (cordova) not a sails app
so i was able to get it working by adding:
(APP_ROOT/src/assets/depenencies/sails.io.js)
and adding to index.html (just after the  tag)

is there a better why to include the io? i tried adding npm install --save sails.io.js-dist
but it didn't work

is ionic2 with system.js or webpack?

no more complaints so far, I will close.. :)


MiDaS 2.1

Just to confirm, this is compatible with MiDaS <= 2.1
https://github.com/intel-isl/MiDaS/releases/tag/v2_1

You are right. To use MiDaS 3.0, you just have to go to python/export_model.py and import the DPTDepthModel class to convert the pre-trained model to a torchscript model.

Could you please teach me the detailed steps?


Bug in internal function get_field_name_str_view(), cuts off last character

Yes, I am aware this is an internal function, but I was looking to use the implementation for something and noticed that it cut off the last character. It's possible this is causing issues elsewhere.
#include <iostream>
#include <rfl/internal/get_field_names.hpp>

struct foo {
  int number;
};

int main() {
  std::cout << rfl::internal::get_field_name_str_view<foo, &foo::number>() << '\n';
}

I tried with GCC 11 and Clang 16 on Ubuntu 22.04, with libstdc++. Instead of printing "number", it prints "numbe".
Printing the full std::source_location::current().function_name() ends with [with T = foo; auto ptr = &foo::number].
In that function, there are the following lines:
#if defined(__clang__)
	const auto split = func_name.substr(0, func_name.size() - 2);
	return split.substr(split.find_last_of(":.") + 1);
#elif defined(__GNUC__)
	const auto split = func_name.substr(0, func_name.size() - 2);
	return split.substr(split.find_last_of(":") + 1);
#elif defined(_MSC_VER)

It's possible that the -2s should be -1s, but it may be more complicated than that. I wonder if this is stdlib specific behavior rather than compiler specific. (Edit: copied my modified code. Original problem still stands).

I am pretty sure the issue is the missing terminating null character.
I am 100% sure that the function works and the -2 and -1 are correct. This is a very central functions, pretty much none of our tests would pass if this weren't right.
Obviously, you shouldn't be using internal functions, because there is no guarantee that the API is stable. But you seem to be aware of that and willing to take the risk.
So here is what you should do instead:
#include <iostream>
#include <rfl/internal/get_field_names.hpp>

struct foo {
  int number;
};

int main() {
  std::cout << rfl::internal::get_field_name_str_lit<foo, &foo::number>().string_view() << '\n';

This will add the missing terminating character.

If you are unsure that rfl::internal::get_field_name_str_view, just compile and run the JSON tests...they all use this function.

It appears the tests are fine, and making my change breaks the tests. Your suggestion still gives the truncated name, unfortunately. I suspect that the rest of the code is working around this behavior somehow. So good news, the library works, bad news is I can't use the function as-is.
Truthfully, I planned to just copy the one function for something externally, so I'll just make the modification there.
Thanks for the quick reply regardless, I appreciate it! Feel free to close this, I imagine you have bigger problems to work on :)

@Ahajha, the problem might be that what you are doing is slightly different from what we are doing.
We have to create this fake object in order to access the fields, but your code assumes that the fields are already known. That might be why we have an additional character that you don't have.
Feel free to copy as much of this code into your code as you see fit and make the appropriate adjustments...this is open source, after all.

This is what I mean:
https://github.com/getml/reflect-cpp/blob/main/include/rfl/internal/get_fake_object.hpp
https://github.com/getml/reflect-cpp/blob/main/include/rfl/internal/get_ith_field_from_fake_object.hpp
You don't do this and that is probably the reason your std::source_location::current().function_name() looks slightly different from ours.


render paths under construction thinner than roads

iD normally renders paths thinner than roads, but for roads/paths under construction the width is the same regardless of whether it is a road or path.
It would be nice if highway=construction + construction=path/footway/cycleway/bridleway/steps was rendered thinner than highway=construction + construction=(any other value)
Perhaps something like this:

Before
	After

Hi Kyle,
I think this is a carto rendering issue not an ID issue. There are several issues listed re construction rendering.
https://github.com/gravitystorm/openstreetmap-carto/issues/3579
Cheers - Phil
From: Kyℓe Hensel @.>
Sent: Saturday, 9 October 2021 4:08 PM
To: openstreetmap/iD @.>
Cc: Subscribed @.***>
Subject: [openstreetmap/iD] render paths under construction thinner than roads (#8743)
iD normally renders paths thinner than roads, but for roads/paths under construction the width is the same regardless of whether it is a road or path.
It would be nice if highway=construction + construction=path/footway/cycleway/bridleway/steps was rendered thinner than highway=construction + construction=(any other value)
Perhaps something like this:
Before
After
https://user-images.githubusercontent.com/16009897/136644791-fa9dc801-eb5f-40b3-be62-8d8fa7d5f82c.png
https://user-images.githubusercontent.com/16009897/136644679-e209bcb1-84f7-48b2-8718-462dc13c4822.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/openstreetmap/iD/issues/8743 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACC6NY6XDVSCA2X64WF7RFDUF7EZ5ANCNFSM5FU35WHQ .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .   https://github.com/notifications/beacon/ACC6NYZB6SPWPAN2E7VZOJLUF7EZ5A5CNFSM5FU35WH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4PHEOGHA.gif


fix loop-protect issue on anagram palindrome and in general

Please provide more details on the same

@mansisce right now there is an issue with the loop protection, for example, if you try to run the solution of Anagram Palindrome, the loop-protect babel transform is not working correctly and the tests don't run. This has to do with the fact that there was an issue with adding loop-protect to code that is unaffected by the babel transform (i.e. code that doesn't have loops, or loops that aren't recognized by loop-protect as having the potential to be infinite like for...of and for...in.
I've figured out the issue though, and essentially what is happening is that when loop-protect transforms code, it trims white space at either end of the code string, and thus is concatenating it with the tests array undesirably.
So, what needs to happen, is starting here, lines 30 & 31 can be replaced with:
  if (!DISABLE_LOOP_PROTECT.test(code)) {
    code = loopProtect(code) + '\n'
  }

this will make it so that all code is transformed by loop-protect unless the user has left a // DISABLE LOOP PROTECT comment in their code.
Since we're not using HAS_LOOPS any more, or trimComments both of those imports can be removed, as well as the trim-code file and the HAS_LOOPS declaration in the regexp file.
You can test that all of this works by running the anagram palindrome solution to make sure all the tests pass, and by going to the Sorting Algo Benchmarks repl and making sure that runs as well (toggle on and off the disable loop protect comment and make sure it runs both ways, when disable loop protect is enabled, it should throw a range error)
Let me know if all of this makes sense or if you have any questions!

Also, if you're working in these files, starting here, lines 41-44 can be replaced with console.log(e.toString() as long as we change the error being thrown to a new RangeError instead of just new Error right here

Finally, I've also been thinking about changing the timeout from 500 to 200 ms for loop-protection. If you end up taking this on, let's go ahead and make that change as well (to both the timeout declaration and the error message in the loop-protect.js file


[ADD ME TO THE ORGANIZATION]

Name: Harshit Kr Vishwakarma
Location: Varanasi, Uttar Pradesh
Interest: Backend Web Devlopment (Node.js)
Discord username(optional):- WOLVERINE911#3940
Why do you want to join?

I want to join because I want to learn and learning is more fun by working on projects and collaborating with like-minded people.

You can also join our Discord community here
Feel free to check out other cool repositories of the Open Source Community here.

@HarshitRV Thanks for your interest. Invitations have been sent to you. Kindly accept it and make your membership public.


[BUG] SnapshotPurge error cases handle improvement

Currently, for snapshot purge there are two steps, first step to start the purge seems missing some error status return here. which is get start failure or success. Second step is to do the actual work with a separate go routine here.
We need to revisit this part to make sure the error case is handled properly.
Some notes:
If there is any error maybe we should mark the replica as 'ERR' state, and let volume controller to trigger a rebuild from a good one. Also tried to failed the purge by resize the new snapshot with a smaller size to mimic this error
[instance-manager-r-1faf369f] time="2020-10-21T00:36:24Z" level=error msg="failed to coalesce volume-snap-d189d75b-8680-450b-9ffe-ea9ff78ef004.img on volume-snap-89fb93c6-8097-4102-a06f-ae704bf5adf2.img: file sizes are not equal and the parent file is larger than the child file"

And currently there is no rebuild or replica is not marked as error, but we have an exclamation mark on the replica to indicate the error

There are 2 problems in this issue:

Error when starting SnapshotPurge is not reported back to Longhorn manager
How do we handle the situation when we detect a bad replica while doing SnapshotPurge?

The problem #1 is fixed by https://github.com/longhorn/longhorn-engine/pull/556
The problem #2 is part of a bigger problem: how do we monitor/handle the situation where the files in some replicas are corrupted (by users or external error). I think detecting and marking a bad replica while doing SnapshotPurge is not a complete solution for this problem because it depends on whether Longhorn pick the corrupted replica to be the source for rebuilding. Also, if SnapshotPurge doesn't happened, we don't detect the bad replica.
Currently we don't detect if a replica has corrupted files until the engine reads/writes to the location of that file.
I am thinking if we should have some background process/controller that periodically check the consistent of volume's replicas
@yasker @shuo-wu @joshimoo

There are 2 problems in this issue:

Error when starting SnapshotPurge is not reported back to Longhorn manager
How do we handle the situation when we detect a bad replica while doing SnapshotPurge?

The problem #1 is fixed by https://github.com/longhorn/longhorn-engine/pull/556
The problem #2 is part of a bigger problem: how do we monitor/handle the situation where the files in some replicas are corrupted (by users or external error). I think detecting and marking a bad replica while doing SnapshotPurge is not a complete solution for this problem because it depends on whether Longhorn pick the corrupted replica to be the source for rebuilding. Also, if SnapshotPurge doesn't happened, we don't detect the bad replica.
Currently we don't detect if a replica has corrupted files until the engine reads/writes to the location of that file.
I am thinking if we should have some background process/controller that periodically check the consistent of volume's replicas
@yasker @shuo-wu @joshimoo

I think the case here is similar to what we encountered in the restore part. I can take a look first: There may be errors before the restore start (failed to execute the cmd) or during the restoring progress. For the error returned by the cmd, Longhorn manager will record it in the status by itself. For the error during the restoring progress, it will be recorded by the engine/replica process automatically. Then once there is an error in the restore status, the volume controller of longhorn manager will mark the replica as failed.
As for the periodic data check, it's almost impossible. Since the replica directory on each node may store thousands of gigabyte data, checking/syncing these data may consume lots of CPU/IO/Network resources then degrade the whole cluster greatly. Besides, the data/files in the replica directory may be always changing, which means the checking result may be out-of-date in the next second.

I think the case here is similar to what we encountered in the restore part. I can take a look first: There may be errors before the restore start (failed to execute the cmd) or during the restoring progress. For the error returned by the cmd, Longhorn manager will record it in the status by itself. For the error during the restoring progress, it will be recorded by the engine/replica process automatically. Then once there is an error in the restore status, the volume controller of longhorn manager will mark the replica as failed.
As for the periodic data check, it's almost impossible. Since the replica directory on each node may store thousands of gigabyte data, checking/syncing these data may consume lots of CPU/IO/Network resources then degrade the whole cluster greatly. Besides, the data/files in the replica directory may be always changing, which means the checking result may be out-of-date in the next second.

Thanks @shuo-wu for the suggestion
Regarding to the error during the snapshot purge progress, it might the case that the replica fail to delete a snapshot because a transient error. Marking replica faulty has a big cost and not every snapshot purge error is critical and require marking the replica as faulty. Therefore, I am thinking we should design an error/response codes as mentioned in https://github.com/longhorn/longhorn/issues/1875 . Something similar to http repose code.

Thanks @shuo-wu for the suggestion
Regarding to the error during the snapshot purge progress, it might the case that the replica fail to delete a snapshot because a transient error. Marking replica faulty has a big cost and not every snapshot purge error is critical and require marking the replica as faulty. Therefore, I am thinking we should design an error/response codes as mentioned in https://github.com/longhorn/longhorn/issues/1875 . Something similar to http repose code.

Reproduce Steps:

Create a volume of 3 replicas. Attach to a pod.
Take a snapshot. Delete a replica. Wait for the rebuild to finish. Take an other snapshot. The end result should look like:

ssh into a node, reside the snapshot on the left side of the volume-head in the above picture. (e.g dd if=/dev/urandom count=50 bs=1M of=<SNAPSHOT-NAME>.img)
Triggle snapshot purge by delete the snapshot on the right most
Verify that the replica is not marked as failed. Longhorn doesn't rebuild the replica. Similar to the picture at https://github.com/longhorn/longhorn/issues/1895#issue-726043071

Test Steps:
Verify that Longhorn rebuilds the replica in step 5 above

Reproduce Steps:

Create a volume of 3 replicas. Attach to a pod.
Take a snapshot. Delete a replica. Wait for the rebuild to finish. Take an other snapshot. The end result should look like:

ssh into a node, reside the snapshot on the left side of the volume-head in the above picture. (e.g dd if=/dev/urandom count=50 bs=1M of=<SNAPSHOT-NAME>.img)
Triggle snapshot purge by delete the snapshot on the right most
Verify that the replica is not marked as failed. Longhorn doesn't rebuild the replica. Similar to the picture at https://github.com/longhorn/longhorn/issues/1895#issue-726043071

Test Steps:
Verify that Longhorn rebuilds the replica in step 5 above

Test steps for Error when starting SnapshotPurge

Create a volume. Attach it to a pod. Write 500MB to the volume
Take 2 snapshots.
Delete a replica to trigger replica rebuilding
While the rebuilding is happening, delete a snapshot to trigger SnapshotPurge.
Verify that Longhorn manager reporting error similar to this format Failed to purge snapshots: REPLICA_ADDRESS: cannot purge snapshots because REPLICA_ADDRESS is rebuilding[longhorn-manager-xm6w5] time="2021-01-08T22:35:15Z" level=error msg="Error in request: fail to purge snapshot: error starting snapshot purge: failed to execute: /var/lib/longhorn/engine-binaries/phanle1010-longhorn-engine-purge_error_2/longhorn [--url <IP_ADDRESS>:10000 snapshot purge --skip-if-in-progress], output , stderr, time=\"2021-01-08T22:35:15Z\" level=fatal msg=\"Error running purge snapshot command: Failed to purge snapshots: tcp://<IP_ADDRESS>:10000: cannot purge snapshots because tcp://<IP_ADDRESS>:10000 is rebuilding\"\n, error exit status 1"

Test steps for Error when starting SnapshotPurge

Create a volume. Attach it to a pod. Write 500MB to the volume
Take 2 snapshots.
Delete a replica to trigger replica rebuilding
While the rebuilding is happening, delete a snapshot to trigger SnapshotPurge.
Verify that Longhorn manager reporting error similar to this format Failed to purge snapshots: REPLICA_ADDRESS: cannot purge snapshots because REPLICA_ADDRESS is rebuilding[longhorn-manager-xm6w5] time="2021-01-08T22:35:15Z" level=error msg="Error in request: fail to purge snapshot: error starting snapshot purge: failed to execute: /var/lib/longhorn/engine-binaries/phanle1010-longhorn-engine-purge_error_2/longhorn [--url <IP_ADDRESS>:10000 snapshot purge --skip-if-in-progress], output , stderr, time=\"2021-01-08T22:35:15Z\" level=fatal msg=\"Error running purge snapshot command: Failed to purge snapshots: tcp://<IP_ADDRESS>:10000: cannot purge snapshots because tcp://<IP_ADDRESS>:10000 is rebuilding\"\n, error exit status 1"

Verified with Longhorn-master - 01/14/2020
Validation - Pass
Scenario 1
With master, on triggering the purge at step 4 as mentioned https://github.com/longhorn/longhorn/issues/1895#issuecomment-756575857, the Longhorn-manager reported the the failure of the purge and rebuild the failed replica.
[longhorn-manager-r2ljs] time="2021-01-15T02:06:05Z" level=info msg="Event(v1.ObjectReference{Kind:\"Volume\", Namespace:\"longhorn-system\", Name:\"pvc-04fd9ebb-fd8b-483a-bb06-b0ab7a800dad\", UID:\"71d16427-2307-47f3-a969-6493640e73eb\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"4727801\", FieldPath:\"\"}): type: 'Warning' reason: 'FailedSnapshotPurge' replica pvc-04fd9ebb-fd8b-483a-bb06-b0ab7a800dad-r-db18fd9d failed the snapshot purge: file sizes are not equal and the parent file is larger than the child file"

Scenario 2: Trigger a snapshot when a rebuilding is in progress.
The Longhorn-manager reports the error.
[longhorn-manager-r2ljs] time="2021-01-15T02:14:19Z" level=error msg="Error in request: fail to purge snapshot: error starting snapshot purge: failed to execute: /var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-master/longhorn [--url <IP_ADDRESS>:10000 snapshot purge --skip-if-in-progress], output , stderr, time=\"2021-01-15T02:14:19Z\" level=fatal msg=\"Error running purge snapshot command: Failed to purge snapshots: cannot purge snapshots because tcp://<IP_ADDRESS>:10000 is rebuilding\"\n, error exit status 1"

Verified with Longhorn-master - 01/14/2020
Validation - Pass
Scenario 1
With master, on triggering the purge at step 4 as mentioned https://github.com/longhorn/longhorn/issues/1895#issuecomment-756575857, the Longhorn-manager reported the the failure of the purge and rebuild the failed replica.
[longhorn-manager-r2ljs] time="2021-01-15T02:06:05Z" level=info msg="Event(v1.ObjectReference{Kind:\"Volume\", Namespace:\"longhorn-system\", Name:\"pvc-04fd9ebb-fd8b-483a-bb06-b0ab7a800dad\", UID:\"71d16427-2307-47f3-a969-6493640e73eb\", APIVersion:\"longhorn.io/v1beta1\", ResourceVersion:\"4727801\", FieldPath:\"\"}): type: 'Warning' reason: 'FailedSnapshotPurge' replica pvc-04fd9ebb-fd8b-483a-bb06-b0ab7a800dad-r-db18fd9d failed the snapshot purge: file sizes are not equal and the parent file is larger than the child file"

Scenario 2: Trigger a snapshot when a rebuilding is in progress.
The Longhorn-manager reports the error.
[longhorn-manager-r2ljs] time="2021-01-15T02:14:19Z" level=error msg="Error in request: fail to purge snapshot: error starting snapshot purge: failed to execute: /var/lib/longhorn/engine-binaries/longhornio-longhorn-engine-master/longhorn [--url <IP_ADDRESS>:10000 snapshot purge --skip-if-in-progress], output , stderr, time=\"2021-01-15T02:14:19Z\" level=fatal msg=\"Error running purge snapshot command: Failed to purge snapshots: cannot purge snapshots because tcp://<IP_ADDRESS>:10000 is rebuilding\"\n, error exit status 1"

Same issue here with Longhorn v1.4.2. Any news?

cc @ejweber @shuo-wu is something related to unexpected volume expansion?

Probably YES... @R-Studio Have you seen that similar longhorn-manager pod error mentioned in issue https://github.com/longhorn/longhorn/issues/6078?

@shuo-wu no I have similar errors like boknowswiki mentioned

I think #6078 have the same cause (inappropriate replica expansion, as suggested by @innobead), but different external factors. In #6078, the engine and all the replicas crashed due to node shutdown. When the engine came back, it was started with one (inappropriately expanded) replica. This caused its engine.status.size = wrong and the particular error in that issue.
If @R-Studio and @wirwolf are seeing "failed to prune" and/or "failed to coalesce" and NOT seeing #6078's "expansion error", your engines probably did not crash (and are still running with the right engine.status.size). You are trying to rebuild a replica from a source replica that has the wrong size. The possibility for a replica to be expanded to the wrong size incorrectly is the underlying issue we are tracking in #6078, so this discussion probably fits well there.
The workaround in #6078 should work in these cases as well. However, it may be possible to proceed without expanding these volumes or restoring from backup assuming we still have one healthy replica that is the right size. We could just delete the incorrectly sized one and allow rebuilds to proceed from the healthy one. The challenge is to determine which replica needs to be deleted.


Add Heading and Icon concatenation support

Add the ability to concatenate Icon and Heading of various styles in any order. Inspired by How to insert images into text.
This addition will allow us to create layouts with text akin to this

Clone of !276

@PavelHolec what do you think about the snapshots?

@PavelHolec what do you think about the snapshots?

All sizes seem to be off.. 🤷  I hoped this task only touches Heading and nothing else.


Update MessageApiClient to support Telegram.

Added the channel Telegram Messenger as per the other text-sdk's.
Had a look through the project and couldn't see any other integration that was required other than appending the Channel type.
Please let me know if any other work is needed 🙂

This looks 100% correct. 🚀
I'll plan a  new version and release later this week!


KickAssembler format

I happen to be using KickAssembler and I see that only TASS and ACME are natively supported. Would very much welcome support for this widely adopted development tool.
http://www.theweb.dk/KickAssembler/Main.html#frontpage

SourceGen also supports cc65's assembler (and Merlin 32, though that's not so useful for C64 work).
I'm a little hesitant to support Kick because it doesn't handle 65816.  Adding an assembler isn't much work, but it adds to the maintenance burden -- if anything changes that affects output, all assemblers have to be updated.  So I tend to favor assemblers that handle the full 65xx line.  (This is not a hard requirement -- in a recent release I started the process of updating my regression tests to not assume 65816 so I could support 8-bit-only assemblers.)
I googled around a bit and it does seem to have good support.  It's hard to gauge popularity.
My question would be: if you could add only one assembler, would KickAssembler be the one?  Why?  Why not DreamAss or DASM or one of the various other assemblers on http://6502.org/tools/asm/?

Fair question of course.
I have been all over the place - Turbo assembler being my natural home when
coding on the native platform and hence the logical syntax for me. Hacking
on the PC, there were parts of Tass that didn't cut it and I passed both
ACME and Dasm before landing at KickAssembler. The only functional with I
have now that is t supported is the ability to write 1581 images. 1541 is
can do easily. I use it to read, patch and write patched copies. It's
really a swiss army knife if you know the tricks it has up it's sleeve.
But which assembler to support? Well not the assembler that the native
coders use - but what reversers fancy. And my guess we are spread over
Tass, Dasm, Acme and KickAssembler - but over time more leaning over
towards Kickass.
I love the fact that you support assembling the file and doing a comparison
between the new destination and source. That is simply great. My general
use case is mainly to document. Identifying the inner workings, how things
can be patched away and so on. Having said this, supporting the he right
assembler is mainly about being readable to me as it's less likely that I
would extract code to use it.
I will get back with more feedback once I have been able to dig into the
program a bit more.
On Fri, 9 Oct 2020, 20:06 Andy McFadden<EMAIL_ADDRESS>wrote:

SourceGen also supports cc65's assembler (and Merlin 32, though that's not
so useful for C64 work).
I'm a little hesitant to support Kick because it doesn't handle 65816.
Adding an assembler isn't much work, but it adds to the maintenance burden
-- if anything changes that affects output, all assemblers have to be
updated. So I tend to favor assemblers that handle the full 65xx line.
(This is not a hard requirement -- in a recent release I started the
process of updating my regression tests to not assume 65816 so I could
support 8-bit-only assemblers.)
I googled around a bit and it does seem to have good support. It's hard to
gauge popularity.
My question would be: if you could add only one assembler, would
KickAssembler be the one? Why? Why not DreamAss or DASM or one of the
various other assemblers on http://6502.org/tools/asm/?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fadden/6502bench/issues/88#issuecomment-706327422,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGZWZSUVQTYKIYAPILODCIDSJ5GKTANCNFSM4SKH5LOQ
.

From the manual: "Kick Assembler run on any platform with Java8.0 or higher installed."
This may be a deal-breaker.  Any supported cross-assembler has to be installed on my system so I can run the regression tests.  While I will run Java if I have to, I won't if there's another option.  It looks like supporting KickAssembler would essentially require a long-term commitment to having a Java runtime installed, and I'm just not okay with that.
You can get the listing in the general neighborhood with the various application settings, changing pseudo-op names, string delimiters, and operand-width disambiguators.  It won't likely assemble, but it will at least look familiar.  You can generate HTML or text files that use the on-screen formatting using File > Export.

Den mån 19 okt. 2020 kl 06:15 skrev Andy McFadden<EMAIL_ADDRESS>
:

From the manual: "Kick Assembler run on any platform with Java8.0 or
higher installed."
This may be a deal-breaker. Any supported cross-assembler has to be
installed on my system so I can run the regression tests. While I will run
Java if I have to, I won't if there's another option. It looks like
supporting KickAssembler would essentially require a long-term commitment
to having a Java runtime installed, and I'm just not okay with that.

Yes, KickAssemler is distributed as a jar file and that means you need Java
on the system in order to use it.
I guess there are options to convert the JAR into a WIndows executable like
here:
https://www.genuinecoder.com/convert-java-jar-to-exe/
I don't code Java so I have no idea, but I guess you yourself can take the
JAR file and convert to a Windows exe using the above method and then void
the requirement to have Jave JVM on your machine.
You can get the listing in the general neighborhood with the various

application settings, changing pseudo-op names, string delimiters, and
operand-width disambiguators. It won't likely assemble, but it will at
least look familiar. You can generate HTML or text files that use the
on-screen formatting using File > Export.

Indeed so. Given that my general use case is documenting the code, and not
necessarily revert it to a native executable then this might be good
enough, albeit a bit sad ...
/Pontus

That puts an EXE wrapper around the JAR so you can launch it directly, rather than having to run it with java -jar.  Java programs depend on a large library of Java classes and native code (including the virtual machine executable, or runtime support library if they're fully AoT).  This is collectively referred to as the Java Runtime Environment, or JRE.  There are ways to bundle that, though developers of smaller projects generally don't because it adds 50-100MB.
If somebody wants to add support for KickAssembler on a branch I won't object, but... I have some issues with Java.


Not work in fish shell

Environment

System OS:

Python Version: <3.9>

Actual Behaviour

When i run spotdl using fish terminal, i got this error:
❰rohit❙~/Music❱✔≻ spotdl https://open.spotify.com/album/5GFRX8eDfxjasX8DZFBmr6?si=dUsVEGRTQuKjeSqKnwyz3A fish: No matches for wildcard “https://open.spotify.com/album/5GFRX8eDfxjasX8DZFBmr6?si=dUsVEGRTQuKjeSqKnwyz3A”. See help expand. spotdl https://open.spotify.com/album/5GFRX8eDfxjasX8DZFBmr6?si=dUsVEGRTQuKjeSqKnwyz3A
Any other information:

Please follow our issue templates when reporting bugs or requesting features.
The devs put in hours of effort, and you should show enough respect to put in a few minutes & follow the template.
Following the template also provides us all the information we need, without having to ask for it.
Closing. Please create a new issue following the template if you would like assistance.


automatic attendance not workinh

Exception in Tkinter callback
Traceback (most recent call last):
File "C:\Python36\lib\tkinter_init_.py", line 1699, in call
return self.func(*args)
File "E:\juju\JTtech\STAR\Attendace_management_system\AMS_Run.py", line 329, in Fillattendances
recognizer = cv2.face.LBPHFaceRecognizer_create()  # cv2.createLBPHFaceRecognizer()
AttributeError: module 'cv2.cv2' has no attribute 'face'
getting this error kindly help

@jenish-jain dude you need to install opencv-contrib package than this error will be solve
Because in normal openCV package there is no LBPH and other faces algorithms
So you need to install opencv-contrib package for access face algorithms
That's why it's showing cv2 has no attribute face


OCM-7961 | chore: update the fips flag description

This was added as a way to let users know before attempting a deployment, that FIPS is not available for hosted control plane at this time.  This can be removed at a time when hosted control plane is FIPS validated.  See https://docs.aws.amazon.com/rosa/latest/userguide/rosa-deployment-options.html#rosa-deployment-model-differences for more details.

@ciaranRoche Much appreciated and thanks for staging that up for me!  It should be all fixed now.  Thanks!

/lgtm


Fix extraEnvVars in helm chart

Fixes #581
extraEnvVars was being treated as a string in some places and a list in others. This PR makes it a list everywhere, any values files that look like this should be updated to remove the |:
extraEnvVars: |
  - name: BEAMLINE
    value: i04

Maybe naive question but is possible to have written a test that would have caught this? For hyperion we occasionally run our deploy script into /tmp for testing

Yes, but I need to look into it further: https://github.com/DiamondLightSource/blueapi/issues/559

I think this was required for other edge cases where we're injecting something in values.yaml into extraEnvVars as part of the tpl call? Or else maybe if extraEnvVars is empty?

Hmm, it may have been needed for rabbitmq password injection?

Looking at i22,
extraEnvVars: |
    - name: SCRATCH_AREA
      value: {{ .Values.scratch.containerPath }}
    - name: RABBITMQ_PASSWORD
      valueFrom:
        secretKeyRef:
          name: rabbitmq-password
          key: rabbitmq-password

Has this been checked if it worked with the {{.Values.scratch.containerPath}} injection? Or are we going to replicate the value here?

With #520, the $SCRATCH_AREA variable is no longer needed,  I assume the tpl was because of $RABBITMQ_PASSWORD

@DiamondJoseph and @DominicOram are we happy for this to go in?


Issue #SB-18683 fix:Resend otp and submit otp button text is not a…

…ligned properly in OTP page when user selects tamil language

This issue has been closed due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
CC @vinukumar-vs @rajeevsathish @ShameerYezz


Ground items - fix bug where you cannot remove items via the overlay [-] or [+] buttons if it has a quantity.

e.g. if you have coins<10.

This behavior I think was intentional, since you cannot add quantity values with the +/- buttons, it doesn't allow you to then remove them. This is consistent with the wildcard matches too which do not allow +/- to work.


fix: DEV-2113: Fix annotation disappear on undo

block empty recorder states

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@98f0617). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #1043   +/-   ##
========================================
  Coverage          ?   9.37%
========================================
  Files             ?     109
  Lines             ?    7788
  Branches          ?    1954
========================================
  Hits              ?     730
  Misses            ?    5912
  Partials          ?    1146

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[DCM-KIT] DCM Standard Add On Explanation

Description

Add additional explanation of DCM Standard content to the DCM KIT,
To be able to provide additional content around the DCM standard to enable a better understanding of the standard content for new adopters of the DCM Use Case and providing guidelines to apply the DCM standards.
This will in the future contain explanation with regards to the DCM core business logic as well as additional introduced optional add on features out of the DCM standard.
Focus will also be to illustrate various topics to make the standard more touchable and attracting for new adopters
Impact
The additional standard explanations are supporting an easier access for new adopters to the DCM standard. Further information around the DCM standard content will be developed, explained and provided to strengthen the general understanding of the DCM standard.
Tasks

[ ] Formal Handover of individual topics from DCM Consortia Group
[ ] Expert Group internal alignment and understanding on Consortia Group handover topics
[ ] Final Preparation of DCM Standard Add on explanation content for DCM KIT
[ ] Initial Pull Request GITHUB until 11.07.2024
[ ] Final Pull Request GITHUB until 25.07.2024
[ ] Publication in DCM KIT on Tractus-X 08/24

Was presented in open planning ⇾ contributors and committers are involved.

Willing to contribute:
@LukasSchmetz

Hello @MWADCM ,
Since the feature is a 24.08 feature and the development phase is coming to an end, we need a status on the feature.

[ ] Currently you are assigned (Responsible) → Is this correct? If not, please assign the correct contact person
[ ] Please check whether the status (backlog, work in progress ...) is set correctly
[ ] Please check whether there is an assignment to a committee or expert group (supported-by) to be found on the board
[ ] Please comment on the current status of the feature
[ ] Are all SubTasks (issues from other repositories that deal with the feature) linked? → The easiest way is to mention the feature here in the issue (via the ID) so we can see which teams/repositories are involved.

If you need any clarification, please get in touch, thank you very much.
Stephan

Ongoing

Hello @MWADCM
In a few weeks, we want to publish Tractus-X Release 24.08. For this, we need a clear status about the features (which will be included in the release and which will be cancelled or postponed to the next release).
Currently, the feature is still in status Work in progress. Please update the status by 09.07.24 eob.
If the feature is not ready for release 24.08, or it is possibly not planned at all, please set the status to Not in release. Please remember that in this case, any dependent components must be informed.
Thank you and best regards.
PS: Please dont forget the milestones for the KIts PRs.

DCM Standard Add-on Explanation is currently be finalized. Initial Handover will be executed on 12.07.2024.


Provide UI page to create, edit and add a member to an organization and view all the projects related to it

There will be the following user interaction on the UI:

The dashboard will show all the details related to the organization.
To edit, the user has to go to settings that will contain the organization's details in an editable state.
The fields shown are:

name
username
avatar

User is able to invite members using email and see all the existing members

Closing this issue as UI is completely integrated with API and tested e2e.

Add member has not been done, closing it after that

Add members have been integrated with API and tested E2E.


Configuration admin page is not up-to-date with the latest design

Brief bug description
The Kontent design changed quite a lot since (Admin/Configuration.vue)[https://github.com/Kentico/kontent-sample-app-vue/blob/master/src/components/Admin/Configuration.vue] was last updated. It should look completely different now. Check out https://github.com/Kentico/kontent-sample-app-net/pull/128 for an inspiration.
Repro steps

Clone repository fresh (or clearn up projectID)
Run the app
See the configuration in the old design:

Expected behavior
The configuration should now look like this:

Hi Simply007, I'd love to tackle this issue if that's alright?

Sure go ahead!
Feel free to join Kentico organization. If you do so, I'll be able to assign you the issue.

Done :), thanks!

Feel free to verify that the UI looks like expected.


Android: App crashes

Steps to reproduce

open test here stream .
scroll to bottom
try to write something
app crashes

ScreenShot

Log
04-26 00:07:52.846  3570  5392 I ReactNativeJS: Running application "ZulipMobile" with appParams: {"initialProps":{},"rootTag":1}. __DEV__ === true, development-level warning are ON, performance optimizations are OFF
04-26 00:08:16.009  3570  5392 E ReactNativeJS: Nesting of <View> within <Text> is not supported on Android.
04-26 00:08:17.483  3570  5392 W ReactNativeJS: Possible Unhandled Promise Rejection (id: 0):
04-26 00:08:17.483  3570  5392 W ReactNativeJS: Nesting of <View> within <Text> is not supported on Android.

Stacktrace

@borisyankov  Please review this issue

@borisyankov Please review this issue

This is caused by the html rendering code. It is not Android specific, same bug is on iOS.
I am trying to rewrite message rendering to avoid this issue.


Ensure that linting error about "Lane" guides user to the lane

We should improve the "lane" error message by guiding the user to the lane. Currently, the message references the process.

This would cause multiple errors if multiple lanes per process are used. But I assume this is acceptable because the user has to solve this issue lane by lane (e.g. to delete a lane it must be selected).

Lanes are actually supported by Zeebe. The engine will not throw an error when deploying a BPMN with lanes. https://github.com/camunda/bpmnlint-plugin-camunda-compat/pull/26 will make this issue obsolete.


reporting phishing attemp

Example URL(s)
https://abuse.cloudflare.com/?_gl=1*1niqcpq*_ga*NDc1MjM0MjY1LjE3MTE1MTk3MDM.*_ga_SQCRB0TXZW*MTcxMTUxOTcwMy4xLjEuMTcxMTUyMDcwNy4wLjAuMA..
Actual Behavior
Trying to report a phishing attempt. Both the email address it was sent from and the link for the phishing attempt have domains that are using DNS servers that point to cloudflare servers. But the abuse form doesn't accept them saying cloudflare doesn't serve those domains.

The abuse form also says it supports upto 5000 characters, but it wouldn't process. Kept getting an error saying it was over 2000 even though it wasn't close to that.
Expected Behavior
The abuse form should have a way to attach files, and not rule out submissions when the DNS does point to cloudflare
Additional information
No response

Howdy @mattknowles, forwarding this along internally... but closing out the issue as this is a documentation repo and our team doesn't have any influence over abuse.cloudflare.com.


Hidden fields and dynamical default values

Hi there!
I have some requests for features that I can't find so far:

hidden input fields, that show up once you click on an 'advanced settings' button/check box/radio button or similar

dynamical default values of input text fields (that change depending on a selected value above)

Is something like that implemented right now?

Howdy howdy!
On the first point, if you squint, you can kind of do this with Mutually Exclusive Groups now. It won't be hidden, but the widget will be disabled ("greyed out") until the user specifically opts in to using it.
Second point: Gooey currently has an experimental feature which can handle some dynamic values, but its discovery mechanism is pretty basic and only runs when the user hits the edit screen. So, not exactly what you're after.
I've toyed around with a few ideas for enabling dynamic changes in response to user actions, but so far, they've all been shelved due to either complexity or user burden. I still vaguely feel like it could be done, but a lot more thinking would be required around how the API / interactions would work. In the grand scheme of things though, in the 5(?) years Gooey's been available, this has only come up maaaybe once before, so it's niche enough not to get any dev effort thrown at it.


Fix Example Applications

Description:
Many example applications have incorrect components. If you find any example application that has an incorrect template, README, code, or just needs to be updated, please comment with what's wrong and link to the example below.
If you find a broken example and know how to fix it, please submit a PR!

kinesis-process-record
https://github.com/awslabs/serverless-application-model/tree/master/examples/apps/kinesis-process-record
Remove irrelevant policy templates, verify code works, fix README to refer to this app (and not a slack app).

kinesis-firehose-syslog-to-json
https://github.com/awslabs/serverless-application-model/tree/master/examples/apps/kinesis-firehose-syslog-to-json
Remove policy templates, verify code works, update README to be relevant.

kinesis-firehose-process-record
https://github.com/awslabs/serverless-application-model/tree/master/examples/apps/kinesis-firehose-process-record
Remove policy templates, verify code, update README.

These were removed in https://github.com/awslabs/serverless-application-model/pull/1341
They can be found in a new repository: https://github.com/aws-samples/serverless-app-examples


[Bug] Log Search function not effective

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
UI (apache/skywalking-rocketbot-ui)
What happened
I have use grpc reporter to collect log to the es,but in /log page,I can not use any english character or chinese character to search log.
by the way,search by trace id is ok.

request is:
curl 'http://localhost:8080/graphql'
-H 'Connection: keep-alive'
-H 'sec-ch-ua: "Chromium";v="94", "Google Chrome";v="94", ";Not A Brand";v="99"'
-H 'Accept: application/json, text/plain, /'
-H 'Content-Type: application/json;charset=UTF-8'
-H 'sec-ch-ua-mobile: ?0'
-H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/94.0.4606.81 Safari/537.36'
-H 'sec-ch-ua-platform: "macOS"'
-H 'Origin: http://localhost:8080'
-H 'Sec-Fetch-Site: same-origin'
-H 'Sec-Fetch-Mode: cors'
-H 'Sec-Fetch-Dest: empty'
-H 'Referer: http://localhost:8080/log'
-H 'Accept-Language: zh-CN,zh;q=0.9,en;q=0.8,zh-TW;q=0.7'
--data-raw '{"query":"query queryLogs($condition: LogQueryCondition) {\n    queryLogs(condition: $condition) {\n        logs {\n          serviceName\n          serviceId\n          serviceInstanceName\n          serviceInstanceId\n          endpointName\n          endpointId\n          traceId\n          timestamp\n          contentType\n          content\n          tags {\n            key\n            value\n          }\n        }\n        total\n    }}","variables":{"condition":{"keywordsOfContent":[],"excludingKeywordsOfContent":[],"tags":[],"paging":{"pageNum":1,"pageSize":22,"needTotal":true},"queryDuration":{"start":"2021-10-13 123731","end":"2021-10-13 130731","step":"SECOND"}}}}'
--compressed
What you expected to happen
search my log
How to reproduce
skywalking 8.7.0
es 7.5
springboot + logback
Anything else
No response
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Press enter after input.

but,to be honest,It's not obvious.

Press enter after input.

but,to be honest,It's not obvious.

Because you could set multiple keywords to match, there is no other way to provide this.


Issue in typescript

Collect.js is having various warning errors in typescript.

Merged a PR that updated the Typescript definitions just a few hours ago. Could you try version 4.0.22 and see if you get the same errors? If not; I’ll change the definitions back.


New ART check

Added docs entry for new ART check, Guest user access

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks

@jaimeo Please merge this PR. Thanks


CHANGELOG.md for 0.28.0

cc @AugustoFKL

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.392%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
12443

Relevant Lines:
14403

💛  - Coveralls


WebSocket Endpoint to tap PowerPlant signals

We need an Endpoint to which we can listen for the PowerPlant signals emitted by the PowerPlant. This Endpoint should be a WebSocket endpoint with BackPressure! This Endpoint should also be filterable by the PowerPlant ID!

Done! Currently it is only possible to ask for the TelemetrySignals for a single PowerPlant by specifying its id! It is not yet backpressured!