svelte parser errors when hitting a template string with a close script tag in it. close style tags are even weirder

Describe the bug
let c = `</script>`

is legit javascript, but svelte's parser shits itself when it sees it. note, you can close any other tag in a string temple, except for script.
let c = `<p>
hi, I'm a P tag
</p>`

works...
what is even weirder yet, close style tags gives a even stranger result, but only in sveltekit  (which may help you track it down.)
<script>
  let c = `<style>
    hi I am a p tag
    </style>`
</script>
{c}

gives
<style> hi I am a p tag *{}</style>

where it puts in a *{} before the end of the style tag, always.
it isn't a vite problem, since old svelte has the issue with  in template strings.
Reproduction
https://svelte.dev/repl/3789e31e9baa4a37b1da7d7939a94ccb?version=3.44.1
Logs
No response
System Info
System:
    OS: Linux 5.8 Ubuntu 20.10 (Groovy Gorilla)
    CPU: (8) x64 Intel(R) Core(TM) i5-8365U CPU @ 1.60GHz
    Memory: 9.33 GB / 31.17 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 16.6.1 - ~/.nvm/versions/node/v16.6.1/bin/node
    npm: 7.20.3 - ~/.nvm/versions/node/v16.6.1/bin/npm
  Browsers:
    Chrome: 91.0.4472.77
    Firefox: 90.0
  npmPackages:
    @sveltejs/kit: next => 1.0.0-next.196
    svelte: ^3.42.6 => 3.44.1

Severity
annoyance
Additional Information
You can always split the string up. slightly annoying but, not really an issue.

The issue with the script tag is related to parsing it belongs in the Svelte repo, not SvelteKit. If you'd searched there you'd have found multiple issues about it posted about it. It's a wontfix, see https://github.com/sveltejs/svelte/issues/5024#issuecomment-644667794
Can't say the same about the style tag, so please remove mentions of the script tag problem, and make the issue more descriptive about the style tag problem if you want it to get more exposure.

ok, I'll close this, and open a new one for the style one directly.

@gtm-nayan is right. This is a known limitation and has been raised in the issue linked. Regarding the style issue, it's because vite-plugin-svelte adds a CSS preprocessor which prepends * {} for HMR, but due to the core issue it's incorrectly replaced as well. Closing this as this is similar to the issue linked.


Problems using sqlite with claudiajs

Hi there,
I am having some problems using sqlite3 with claudiajs, the app works fine locally but when uploading it to API gateway I get:
{"message": "Internal server error"}
Cloudwatch translates to:
Unable to import module 'lambda': Error
at Function.Module._resolveFilename (module.js:325:15)
at Function.Module._load (module.js:276:25)
at Module.require (module.js:353:17)
at require (internal/module.js:12:17)
at Object.<anonymous> (/var/task/node_modules/sqlite3/lib/sqlite3.js:4:15)
at Module._compile (module.js:409:26)
at Object.Module._extensions..js (module.js:416:10)
at Module.load (module.js:343:32)
at Function.Module._load (module.js:300:12)
at Module.require (module.js:353:17)

And possibly the line causing this is:
const db = new sqlite3.Database(path.join(__dirname, '../path/to/db'));
I have run the command
npm pack --production
and checked the db file was correctly placed in the folder.
Any ideas?

The only place you can write is /tmp, your sqlite db would be read only anyway. Beside that it would not be consistent because there's no guarantee that you'll run the same server at your second request. Consider using other db or at least other way to store your sqlite file.
This error can be unrelated to sqlite, it says "Unable to import module 'lambda'", so it seems that your lambda module is not exporting a handler.
This doesn't sound like a Claudia bug, please use gitter for questions to get help with the code: http://gitter.im/claudiajs/claudia.

hi, this looks as an import problem, not a bug in claudia. please use the gitter channel for general discussions https://gitter.im/claudiajs/claudia


Refactor: add append element and separator or line break functions

Codecov Report

Merging #11 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #11   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           8      9    +1
  Lines          75     77    +2
  Branches       11     13    +2
=====================================
+ Hits           75     77    +2

Impacted Files
Coverage Δ

src/modules/convert-array-of-objects-to-csv.js
100% <100%> (ø)
:arrow_up:

src/modules/convert-array-of-arrays-to-csv.js
100% <100%> (ø)
:arrow_up:

src/helpers/append-element.js
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c237523...fbfc417. Read the comment docs.


Hi, why does mace use default fp16 type in arm

Hi, I found mace used 3rd-party lib half: Half-precision floating-point library on cpu.
Why does mace use arm fp16, ref:

Using the GNU Compiler Collection (GCC): Half-Precision
Using the GNU Compiler Collection (GCC): ARM Options.

THanks in advance.

@ysh329 It is used for GPU computation. Please reference: https://mace.readthedocs.io/en/latest/user_guide/advanced_usage.html#deployment-file

eh, I found gpu support half type. Does this library used for fp16 model storage?

yes, it is mainly used for fp16 model storage.


Automatically propose to square or round buildings

Many beginning mappers forget to square or round their buildings and it takes a lot of time for other mappers to clean this. iD could propose, as soon as the building key is selected, to square or round the buildings.

I'm working on an orthogonal drawing mode that will make it much faster to draw square buildings.  I'll extend it to round buildings too (like for huts or other shelters) sometime later, if I can come up with a reasonable UI for them.
see #528

From my experience with teaching JOSM and the building tool, beginners may totally skip the building school, even if you taught them more than once. I think you will not prevent the unsquare issue with people using only the polygon drawing tool.


Use a common library for animations

There are currently some requests about including the animations with every element. What if instead of coding the transitions ourselves we used a library? For example https://daneden.github.io/animate.css/
Seems to me this is the same approach as using Foundation for the grid.

Considering the animations have to be done differently depending on libraries / frameworks, this is not valid. Closing.


array, object precondition violations

reserve and possibly other functions allow capacity to exceed max_size

Related to #270


peerflix + "open with" module firefox to play video on right click with your favorite external player.

Just an information about to play your link video on right click with your favorite external system player.
It's possible with Open with.
https://addons.mozilla.org/fr/firefox/addon/open-with/
https://addons.mozilla.org/en-US/firefox/addon/open-with/
After configurations of your players path,you will see on right click on generated link file, the list of your players and you can send them, it's perfect and easy
++

The english link
https://addons.mozilla.org/en-US/firefox/addon/open-with/
an another solution is  the extension " media player connectivity ".  It gives you more advanced options but "open with" is more simple.
https://addons.mozilla.org/en-US/firefox/addon/mediaplayerconnectivity/

Thanks a lot for the tip but it doesn't work alone. VLC cannot do anything with a magnet-link alone.
How to make VLC play a torrent stream directly please ?

hello , it's working good, but perhaps you don't understand that it work with the link generated by peerflix just after the submit process, not directly a magnet link or torrent link.
Without the process to get your the link from your server , it's not working.
1 - paste your magnet or torrent link in the input
2- submit to get your link avi etc with your server
3- On right clik from this link, choose to open with your vlc, or smplayer, or mpv (the best).
After that if you have any problems for reading the flux , test with another player (smplayer or mpv).

Well that's what I was thinking. Thanks for the detailed information.

an another solution is the extension " media player connectivity ". It gives you more advanced options but "open with" is more simple.
https://addons.mozilla.org/en-US/firefox/addon/mediaplayerconnectivity/
I am trying to hunt down the guy who made this extension so I can learn how to set it up for html5...Don't suppose you could help?  I'm not exactly a developer, or used to git hub in general.


Improve runmode testrun by updating params, adding mm10

Describe what enhancement you'd like to see.
Need improvements to the testing environments

[x] make the tinytest run the standard run (decrease contrast to one, samples to 5)
[x] update defaults so only one q value is run, all peak callers, and both dedup and nondedup
~- [ ] create testrun_hg38 and testrun_mm10 runs~
~- [ ] update all test samples~

decided against adding mm10 as a test sample option - goal of test data is to check each rule works. running a dry run with the test data, switching the config to mm10 would still achieve the same result


fix(npm-scope): converts npm scope to lowercase during publish and fetch

fix #799: converts npm scope to lowercase during publish and fetch. This ensures issues when a package is published, scope is already converted to lowercase and the package is not found during release/prepare/fetch when the scope is provided in upper/mixedcase

Codecov Report

Merging #833 (855d079) into develop (f762db2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #833   +/-   ##
========================================
  Coverage    66.22%   66.22%
========================================
  Files           46       46
  Lines         1593     1593
  Branches       342      342
========================================
  Hits          1055     1055
  Misses         538      538

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f762db2...855d079. Read the comment docs.


Use ActiveCable to update scores on live overlay views

Instead of refreshing the page, which causes flicker, we should use ActionCable (or some other javascript) to update the scores.

Or perhaps https://hotwire.dev/

Or perhaps https://hotwire.dev/

Or perhaps https://hotwire.dev/

Or perhaps https://hotwire.dev/


vkGetPhysicalDeviceFeatures2 is not exposed

instance.get_physical_device_features exists, but I want to check for extension features - for which you need vkGetPhysicalDeviceFeatures2. That one does not seem to be exposed, as there's no get_physical_device_features2`?
I assume it's somehow related to https://github.com/MaikKlein/ash/issues/12 since it's also a "free function" that neither takes an instance nor a device (though I think as seen from the loader it's "instance-scoped", sort of).

It is exposed as a function pointer https://docs.rs/ash/0.29.0/ash/vk/struct.InstanceFnV1_1.html#method.get_physical_device_features2, but it is currently missing from the high level wrapper.

Just to note it is correctly marked as an instance level function, as this is where the function pointer comes from with https://www.khronos.org/registry/vulkan/specs/1.1-extensions/man/html/vkGetInstanceProcAddr.html
Had to look it up myself again, I probably should document that somewhere.


narrow: Add 'more topics' state to browser history.

When navigating "back" or "forward", the left sidebar state should be restored.
Earlier, "more topics" expanded was not considered a distinct state.
This PR makes it possible to correctly place you in the "more topics" view or not, depending on where you were.
Fixes: #29548.

Screenshots and screen captures:

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Works for me in manual testing!

This was updated with the approach Tim suggested in CZO

This version doesn't work for me in manual testing. This may not be a minimal reproducer, but I did the following:

Mute a topic (to get a "more topics" link).
Click "more topics".
Click on the muted topic.
Click on another topic in the same stream.
Go "back".

Expected: "More topics" view would remain open in the left sidebar.
Actual: I ended up back in the regular sidebar.

@alya Fixed that bug.

Works for me in manual testing now!

Addressed the review comment.

Looks great, merged, thanks @prakhar1144; but see a comment above for follow-up refactoring to use zod to avoid type assertions.


Latest version of XrmDefinitelyTyped is not generating definitions

When I attempt to execute the latest XrmDefinitelyTyped exe using the same config as the previous version  I get an error message Unable to generate TypeScript files: access to path "X" is denied
Where X is path + \WebResources\typings\XRM_internal\Enum\Folder
Where Folder is the name of the folders of the entities in the solution / entities specified in the config
eg Folder hive_blpu.statecode.d.ts = Entity name hive_blpu.statecode
Any ideas why?

I'm having the same exact issue. Since is it looks like it's a file system permission issue thing, I'm making sure I have full access in all folders/sub-folders, and I'll post back here if that works. Did it not do this for previous versions?

I also have a previous version and this problem doesn't occur. I'm going to continue to use this previous person till this has been resolved

This bug has been fixed with the latest minor update (version 2.1.1).

Thanks a ton!!!

Much appreciated Martin


api: Fix conversion from fiat to satoshis

Conversion to satoshis incorrectly used data.to as fiat currency rather
than data._from.
Note: The api currently assumes you are either converting to or from satoshis. This could be fixed to allow arbitrary conversions, so I will add that if needed.

I noticed this PR already contains a fix for this: https://github.com/lnbits/lnbits-legend/pull/495

Thanks for noticing this and also finding the duplicate (which is closed now). Merging.


kubernetes-concepts-overview-components-pr

Introduction to kubernetes component concept

This change is

@chenopis Hi Andrew, @dankohn and I have talked about making even faster progress on the K8s i18n efforts during the Linuxcon China; the agreed action path is to organize a working group from the Chinese community to do the translation work, and let CNCF members among them review the Pull Request, and finally let upstream maintainers merge the Pull Request, upon seeing the reviewer's comment "I am from {a CNCF organization}, and this pull request looks good to me".
Does it look OK to you? I can open an issue to formally state this process

The edit is that there is no need to be a CNCF member to participate. What we were aiming for is a process where developers from one company to the translation, and then unrelated folks from a different company proof-read it and sign off on it. Once that has happened, they would signal to @zacharysarah or other documentation SIG folks that the PR is ready to be merged.
Presumably, we should write up this process somewhere.

@dankohn Thanks Dan for the clarification!
Currently we've pulled together a working group of 20+ people, with the following instructions:
https://docs.google.com/document/d/1xz7BhW8Qkh6reYU7S7RDzSov5e101Vz_fHjq-fEX-W4/edit#heading=h.30j0zll
And our progress has been tracked here:
https://docs.google.com/spreadsheets/d/1FDFCv9RK5nSMgLXhPrJ5k7r5QvHnNEFnXbvoFiM8v20/edit#gid=906253755
And so far we have sent dozens of Pull Requests, so having the upstream participating with the merging with speed would be great!

@xingzhou , please help to review the translation.

@xinzhangcmu I fine w/ reviewers identifying which company they're from, but then the person submitting the PR also needs to identify which company they're from so that we know it's from a different organization.

Also, we need to set the Milestone to Chinese translation so we can track all of these PRs together.

BTW, I created the Needs CN Review and CN LGTM labels.

@tengqm Thanks for review

@markthink :wave: Thanks for opening this PR. Please check the box to allow edits from maintainers.

@zacharysarah Thanks, has been set，We have a translation group：
https://github.com/k8smeetup/kubernetes.github.io
Weekly updates：
https://github.com/k8smeetup/kubernetes.github.io/blob/master/contribution.md

@chenopis I approve of this PR.

I'll wait to merge this until after @tengqm's comments are addressed.

@tengqm thanks , @chenopis I have updated..^ ^

Just ping me when this is ready to be merged, or ask @zhangxiaoyu-zidif -- he now has merge privileges.

@tengqm thanks , @chenopis @zhangxiaoyu-zidif  I have updated..^ ^

@zhangxiaoyu-zidif I have updated..^ ^


Fix event_sequence test

Assigning to nets from a procedural context is not allowed, so make them variables instead.
Example error:
../..tests/chapter-9/<IP_ADDRESS>--event_sequence.sv:30:10: error: cannot assign to a net within a procedural context
				@seq y = 1;
				     ^

Thanks!


Update CODEOWNERS to keep only actual maintainers.

Refers to #1371

Codecov Report
Base: 76.41% // Head: 88.09% // Increases project coverage by +11.68% :tada:

Coverage data is based on head (8f238d5) compared to base (145d2b7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1413       +/-   ##
=============================================
+ Coverage     76.41%   88.09%   +11.68%
=============================================
  Files           170       32      -138
  Lines          2798      378     -2420
  Branches        489       55      -434
=============================================
- Hits           2138      333     -1805
+ Misses          413       32      -381
+ Partials        247       13      -234

Impacted Files
Coverage Δ

.../main/kotlin/org/zalando/zally/core/RulesConfig.kt

.../kotlin/org/zalando/zally/core/ObjectTreeReader.kt

...in/kotlin/org/zalando/zally/core/ast/ReverseAst.kt

...zalando/zally/apireview/ApiViolationsController.kt

.../zally/ruleset/zalando/VersionInInfoSectionRule.kt

.../ruleset/zalando/UseStandardHttpStatusCodesRule.kt

...ando/zally/exception/ApiReviewNotFoundException.kt

...zalando/zally/ruleset/zalando/model/ApiAudience.kt

...zalando/zally/ruleset/zally/ExtractBasePathRule.kt

...org/zalando/zally/ruleset/zally/CaseCheckerRule.kt

... and 128 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

👍

@tkrop please review

:+1:


Add invite_url method

Basic implementation, open to changes.
Usage:
use serenity::client::CACHE;
use serenity::model::permissions::*;
let cache = CACHE.read().expect("Could not read cache.");

// Pass empty permissions to get a url without the added "&permissions=" section
let no_perm_url = cache.user.invite_url(Permissions::empty());

// Pass in permissions to get them added to the end of the url.
let perm_url = cache.user.invite_url(READ_MESSAGES | SEND_MESSAGES);

Thanks


Switch to using Lean to run the tests (so it runs on Windows)

Description
This uses the Lake "Script" feature to run the LeanInk tests.
Notable Changes
So make -C test run_tests becomes lake script run tests and make -C test capture becomes lake script run capture.
Also removed a problematic install.sh that was tinkering with the $HOME/.elan/bin folder.  It is better for users to simply add the LeanInk/build/bin to their PATH environment when using alectryon.
Additional Notes
Fixes issue #21

Good work!


Deployment with persistence.xml - check if data source is available

When user is deploying application with defined persistence.xml it would be nice to check if defined data source is available.
Inform user when DS is not available so he/she can take some actions.
By informing I mean to show DS name which is not available and the list of available ones on the server.
This is equivalent of  https://issues.jboss.org/browse/JBEAP-10713 for hal.next

As a first step the failure description of failed operations are now pretty printed:

:thumbsup:

Moved to https://issues.jboss.org/browse/HAL-1425


Enable FxCopAnalyzers code analyzers

PR Summary

Enable FxCopAnalyzers code analyzers for build and live analysis
Ruleset based on microsoft.codeanalysis.fxcopanalyzers\3.0.0\rulesets\AllRulesDefault.ruleset with actions changed from Warning to Info to fix the build.

PR Context
Concept taken from dotnet/runtime
see also: #11916
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[x] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[x] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[x] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[x] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:

Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

In #11916 my intention is to force Roslyn analyzers at build time to exclude regressions in code formatting and code style.
Here you add analyzers but not enable/activate them for build or design time (otherwise the build would fail). Also we already have editorconfig file - why do we need the ruleset. I am not sure that we need this in the time.
It would great if you grabbed  #11916 and improved it.

@iSazonov  yes this PR has a similar intention as #11916, but review should be easier 😛
Please see 6acc529 for proof analyzers are activated.

@xtqqczze Thanks for clarify! I see the behavior of VS was changed since 16.5. But It is not clear has EditorConfig a priority on CodeAnalysisRuleSet?

@xtqqczze  Please have a look at the failing builds.

@xtqqczze Could you please check with CA1001 that EditorConfig has a priority over CodeAnalysisRuleSet?

@iSazonov  2c736cb shows EditorConfig has a priority over CodeAnalysisRuleSet

In the case I suggest to use default ruleset and do all customizations in EditorConfig.

@xtqqczze Can respond to @iSazonov comment

In the case I suggest to use default ruleset and do all customizations in EditorConfig.

In the case I suggest to use default ruleset and do all customizations in EditorConfig.

I think using Ruleset only makes more sense than specifiying default rules in Ruleset and overriding some rules in EditorConfig.

@iSazonov I think we should use a Ruleset until EditorConfig support for diagnostics is mature.

TreatWarningsAsErrors  ike a very rare case. We don't use this.

@xtqqczze It seems the https://github.com/dotnet/roslyn/issues/43051 issue consider a specific scenario to have an exclusion list of warnings. It is not our case. We use TreatWarningsAsErrors to force all warning as errors.

/apz restart

@xtqqczze Please rebase. I hope this will fix CIs.

Ruleset based on microsoft.codeanalysis.fxcopanalyzers\3.0.0\rulesets\AllRulesDefault.ruleset with actions changed from Warning to Info to fix the build.

Please enumerate these changes. Maybe in new issue. This helps us to fix its in follow PRs.

@xtqqczze Please add comments in rules so that we fix temporary changes in follow PRs.

See https://github.com/dotnet/runtime/pull/42272#pullrequestreview-488980943 about RunAnalyzers

@xtqqczze I see .Net team updated their code (rule list and csproj) - could you please update the PR too?

rebased

@iSazonov I think it would make more sense to abandon this PR, and start from scratch with new Microsoft.CodeAnalysis.NetAnalyzers using EditorConfig rules.

@iSazonov I think it would make more sense to abandon this PR, and start from scratch with new Microsoft.CodeAnalysis.NetAnalyzers using EditorConfig rules.

Ok.

@iSazonov I think it would make more sense to abandon this PR, and start from scratch with new Microsoft.CodeAnalysis.NetAnalyzers using EditorConfig rules.

Ok.

Previously, you had wanted to use EditorConfig instead of ruleset configuration.

My thought was and is that we shouldn't have two configs - in EditorConfig and in ruleset. If VS Code supports(?) ruleset it is better to use ruleset and follow .Net team's pattern.
Originally posted by @iSazonov in https://github.com/PowerShell/PowerShell/pull/13835#issuecomment-714652241

Let's stick with ruleset configuration then. Honestly, I don't have a preference either way, but I would like to get something merged soon.

This PR is ready for review and is the prerequisite enabling further code analyzers so speedy review would be appreciated.

@xtqqczze I see MSFT updated documentation.
https://docs.microsoft.com/en-us/visualstudio/code-quality/roslyn-analyzers-overview?view=vs-2019#build-errors

Create a .NET 5.0 project which includes analyzers by default in the .NET SDK. Code analysis is enabled, by default, for projects that target .NET 5.0 or later. You can enable code analysis on projects that target earlier .NET versions by setting the EnableNETAnalyzers property to true.

So we already got this.
https://docs.microsoft.com/en-us/visualstudio/code-quality/use-roslyn-analyzers?view=vs-2019#convert-an-existing-ruleset-file-to-editorconfig-file

Starting in Visual Studio 2019 version 16.5, ruleset files are deprecated in favor of the EditorConfig file for analyzer configuration for managed code. Most of the Visual Studio tooling for analyzer rule severity configuration has been updated to work on EditorConfig files instead of ruleset files. EditorConfig files allow you to configure both analyzer rule severities and analyzer options, including Visual Studio IDE code style options. It is highly recommended that you convert your existing ruleset file to an EditorConfig file. It is also recommended that you save the EditorConfig file at the root of your repo or in the solution folder. By using the root of your repo or solution folder, you make sure that the severity settings from this file are automatically applied to the entire repo or solution, respectively.

I think we could start with this recommendation. Sorry that I stopped your new PR - it was right direction.

Please also see https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/overview#code-style-analysis
about EnforceCodeStyleInBuild. I think we could add this.

So We have no need to reference the package.
I have removed the PackageReference, and pushed commit be5c5c3 which proves that a change in the ruleset will break the build.

In VS2019 16.8, you should be able to workaround this issue by using global analyzer configs as per https://github.com/dotnet/roslyn/issues/43051#issuecomment-692837489.
In VS2019 16.9 Preview1 and later, the original reported issue should be resolved and you can use editorconfig file itself and /warnaserror will escalate diagnostics configured as warnings in editorconfig to be errors.

Originally posted by @mavasani in https://github.com/dotnet/roslyn/issues/43051#issuecomment-701702375

I have tested EditorConfig configuration with TreatWarningsAsErrors and it is still not working with VS2019 16.8.0 Preview 5.0. The alternative is to use a global AnalyzerConfig (see #13835).

@xtqqczze TreatWarningsAsErrors issue is about using warning severity only but we should use error severity if we want to force a rule. Yes?

@xtqqczze TreatWarningsAsErrors issue is about using warning severity only but we should use error severity if we want to force a rule. Yes?

That is a goal of this PR, to enforce various rules during build.

I mean why would we use warning severity if we want to stop build with error?

If TreatWarningsAsErrors is enabled then warnings should stop the build.

Since we get a fix for TreatWarningsAsErrors in near future I believe we have no need a workaround today. In EditorConfig we can set severity to error if we want to force a rule.

Since we get a fix for TreatWarningsAsErrors in near future I believe we have no need a workaround today. In EditorConfig we can set severity to error if we want to force a rule.

@iSazonov In that case, I suggest closing this PR in favour of #13835. Can we make a decision please.

We can use .globalconfig file instead, closing.

@xtqqczze Why would we need a global config? We can use our .editorconfig file. If we set a severity of a rule to error we will stop the build if the rule violates. Yes?

@xtqqczze Why would we need a global config? We can use our .editorconfig file. If we set a severity of a rule to error we will stop the build if the rule violates. Yes?

Using a global AnalyzerConfig avoid bloating EditorConfig with analyzer configuration. Documentation is at https://docs.microsoft.com/dotnet/fundamentals/code-analysis/configuration-files#naming

avoids bloating EditorConfig with analyzer configuration

Bloating? Our file has 194 lines and 142 lines of them with analyzer configuration. I don't expect we will add a lot of rules in near time (maybe ~10 to force new syntax). I believe can live with the EditorConfig while.

avoids bloating EditorConfig with analyzer configuration

Bloating? Our file has 194 lines and 142 lines of them with analyzer configuration. I don't expect we will add a lot of rules in near time (maybe ~10 to force new syntax). I believe can live with the EditorConfig while. Also global config does not still supported in VS GUI that is bad UX.

I think we would want to specify the severity for each rule explicitly as in #13835. There are 246 rules in Microsoft.CodeAnalysis.NetAnalyzers alone, ~738 additional lines.
My main concern  analyzer configuration options

I think we would want to specify the severity for each rule explicitly (like #13835). There are 246 rules in Microsoft.CodeAnalysis.NetAnalyzers alone, ~738 additional lines.

Currently we use defaults and it is well. Do you expect that we will change defaults and set severity to error for 246 rules?

AnalyzerConfig is a simple text file, I'm not sure what IDE support is needed.

It is mandatory requirement that IDE support Roslyn analyzer configuration. I know VS Code supports EditorConfig but I am not sure it supports GlobalConfig. Can you confirm?

I tried VS Code with GlobalConfig and it does not work at all :-( OmniSharp uses defaults and ignore the global config. I will open the feature request in OmniSharp repo.
@xtqqczze Now I suggest to put all global config content to a end of out EditorConfig file. After we get the feature in OmniSharp we will be able to move the rules back to a global config file.

OmniSharp

Works for me. Do you have omnisharp.enableRoslynAnalyzers set to true in .vscode\settings.json

@xtqqczze EditorConfig works but GlobalConfig doesn't work.

@iSazonov I tested in VS Code 1.50.1 (Omnisharp 1.37.3) with src\Microsoft.PowerShell.Commands.Management\cimSupport\cmdletization\SessionBasedWrapper.cs open in the editor.
As expected, a diagnostic with code CA1507 is listed in the problems tab.
Then I set dotnet_diagnostic.CA1507.severity = silent in .globalconfig and restarted VS Code and the diagnostic is no longer listed.
In my environment, OmniSharp is using the MSBuild instance provided by Visual Studio Enterprise 2019 16.8.30615.102.
Perhaps you could you try setting omnisharp.loggingLevel to debug and examine the log output?

Visual Studio Enterprise 2019 16.8.30615.102

I updated to latest preview and now it works. Thanks!

It is mandatory requirement that IDE support Roslyn analyzer configuration. I know VS Code supports EditorConfig but I am not sure it supports GlobalConfig. Can you confirm?

Support for .globalconfig is built into roslyn, so it should work in any IDE (including Visual Studio Enterprise 2019 16.8)


Importing causal graphs generated by DAGitty into dowhy

Hi there.
DAGitty is an R-based program that can be used to plot causal graphs using a point-and-click interface, and export the code to generate those graphs. DAGitty is increasingly used in health and medicine, and some users may wish to analyse their models in Python. Example code for a causal directed acyclic graph (DAG) is shown below, reproduced from the DAGitty browser default:
dag {
A [pos="-2.200,-1.520"]
B [pos="1.400,-1.460"]
D [outcome,pos="1.400,1.621"]
E [exposure,pos="-2.200,1.597"]
Z [pos="-0.300,-0.082"]
A -> E
A -> Z [pos="-0.791,-1.045"]
B -> D
B -> Z [pos="0.680,-0.496"]
E -> D
}

I would like to import the DAG into dowhy, but am unsure how to format the graph so it is compatible with dowhy's GML requirements. I investigated the GML parser through the link on the dowhy main page, but could not work out the format conversion. I would appreciate if you could point me in the right direction.
I am a Python user with a basic grasp of R, and am new to causal inference. Many thanks.

@joannadiong Looks like the DAGitty format is the same as the graphviz DOT format. DoWhy also supports the DOT format. You can directly input this graph string in DoWhy by changing dag to digraph in the first line.
This notebook has an example for using a DOT format graph with DoWhy: https://github.com/microsoft/dowhy/blob/c29f29949890d6d28980cc2538991e8ba2e1b16e/docs/source/example_notebooks/load_graph_example.ipynb

Great, thanks for the pointers. Cheers

DoWhy now supports Dagitty graphs. So you can simply provide the graph copied from Dagitty into dowhy.

That's great! Thanks for the heads up


Add some browser related comments

This is my very first pull request on GitHub :tada:

/cc @MrSwitch 🔔

😆

🎉
@coltaemanuela There we go. 😁


Detecting chords using WebMIDI

I have a general question. How would you detect a chord using WebMIDI? From what I read in the API docs, you can use the noteon  for single note/key events. If I want to detect a chord event, say when 3 or more notes are played together. Do I have to detect separate events for each note?  Any suggestions?

There is nothing in the library to let you do that automatically. You would have to listen for noteon events triggered within a certain time frame. Or, you could also save the state of all notes in your app. This way, when a noteon is triggered you could check if other notes are currently played.


Added a Custom effect in Cursor

Sucessfully added a custom cursor to improve User interaction
https://github.com/user-attachments/assets/983888f4-8b12-4af3-8ec8-2559b79b8f80
Please Merge the pull request and also give a level2 or level3 label to me.
Thankyou!

Hi, @AnujShrivastava01
I got My account back today. On next leaderboard update you'll be able to see your points.
Sorry for the inconvenience. Keep contributing.🚀


Support Lazy-loading <turbo-frame> contents

Add support for declaring [loading="lazy"] (in the style of
iframe[loading="lazy"] and
img[loading="lazy"]). When both src and
loading="lazy" are declared on the frame, navigation will be deferred
until the element is visible in the document.
As an example, consider a / pairing:

  Lazy load

  <turbo-frame id="frame" src="/lazy-loaded.html" loading="lazy"></turbo-frame>

On initial load, the frame's contents will be empty. When the
 element is clicked and the contents are visible, the
<turbo-frame> element will navigate to the URL specified in the src
element.
By default, <turbo-frame> elements that omit the loading attribute
will be treated as if they've declared loading="eager".
The attribute (and corresponding TurboFrameElement.loading property
accessors) provide a means of controlling the loading strategy
declaratively without additional application-side JavaScript, while
still providing a means for application-side JavaScript to intervene if
necessary.
If visibility-based intersection is insufficient for an application's
need, there are various ways to control the loading strategy.
For example, consider an optimization to pre-load the frame when the
 element's disclosure  button is hovered or
focused. First, consider HTML annotated with Stimulus attributes:

  lazy-loader#prefetch focus->lazy-loader#prefetch">Lazy load

  <turbo-frame id="frame" src="/lazy-loaded.html" loading="lazy" data-lazy-loader-target="frame"></turbo-frame>

Next, consider the corresponding lazy-loader Stimulus controller:
import { Controller } from "stimulus"

export default class extends Controller {
  static targets = [ "frame" ]

  prefetch() {
    this.frameTarget.loading = "eager"
  }
}

I very much like how hey.com manages the lazy loading for details/summary-driven dropdowns, especially the graceful leaning on browser baseline behaviour through interception of activation events on elements with a data-turbo-frame attribute. It's so effortlessly elegant, that I'd already assumed Hey's method is the gold standard.
More generally; by allowing an external controller to mediate the decision, turbo frames can participate in any variant of lazy-loading UX, rather than just this one example, and this might be desirable.

Just wanted to share some "prior art" that it looks like GitHub is using. You can see the same pattern for the Author, Label, Milestone, etc filters on the Issues index page.
https://github.com/github/details-menu-element#deferred-loading
https://github.com/github/include-fragment-element/
One detail that I thought was very nice: the usage of hover on the details disclosure to trigger the server fetch to shave off a few milliseconds of the "Loading" state being visible. I know there are similar patterns for using hover in "Turbo-esque" setups (e.g. https://instant.page).

@swanson yep, there's more than one kinda of lazy loading. I think turbo frames is better off providing one of the puzzle pieces, rather than trying to supply an entire UI component behaviour.
In terms of UI latency, I have pure CSS drop-downs that use focus-within in preference to details/summary (although I like both approaches, and don't discount <dialog>, or even an old-school checkbox hack), because it triggers on mousedown rather than up. Preloading the content on hover is a terrific idea for progressive enhancement, thanks for highlighting it!
The particular use of intersectionObserver, which I think is the cool part of this PR, would (if extracted) make a neat documentation example of how turbo frames can be wired up for lazy loads.  To me that'd feel more open for extension, and more inviting of novelty, than hard-wiring one behaviour and saying "you have two modes to choose from".

To me that'd feel more open for extension, and more inviting of novelty, than hard-wiring one behaviour and saying "you have two modes to choose from".

The two values ("eager" and "lazy") reflect the possible loading modes that  elements and  elements do/will support. The intention behind supporting them as turbo-frame attributes was to provide a general case, declarative way to defer the HTTP request. By default, the current behavior is to eager load all frames immediately.
This diff will require some changes to support it, but one improvement would be to monitor changes to the loading attribute. That way, consumer applications could declare elements with loading="lazy" initially, and the listen for whatever events are appropriate in their JS (e.g. a hover on a  element, an intersection observer of their own, etc), and then set the attribute to loading="eager" to trigger the load at that time.
Does that sound flexible and extensible enough to serve as a puzzle piece?

Some way to programmatically trigger (likely from a Stimulus controller) the server fetch to happen would be great. I'm not sure I would personally want visibility-based automatic triggering -- it felt kind of backwards to me: content that is below the fold is what I want to lazy load, but I don't want to wait until it becomes visible; I want it to load as soon as possible.

Does that sound flexible and extensible enough to serve as a puzzle piece?

Not really - it sounds like the kind of tight coupling that Turbo and Stimulus are trying to avoid. Maybe it's my Ruby roots showing, but I don't think one component should be interfering with the attributes of another in order to force behaviour.
Most of the Hotwire ecosystem signals their collaborators via events, and leans on existing browser-level capabilities besides, and nowhere is this more elegantly expressed that how hey.com relies on overhearing a toggle, and then sending a simple click, to drive the lazy-loading of frame content.
Without events for loose coupling, it becomes much harder to scale up, e.g. for other components listening to the same.
Turbo frames doesn't seem to have been pitched as a replacement/alternative for iframes, so I think any comparison is a problematic equivalence. From an application perspective, they have different applicability, granularity, and capability; the custom element itself does not extend HTMLIFrameElement, doesn't try to implement any of the other iframe behaviours, and when we want an iframe we can still have one.  Given a guiding principle of Hotwire being "for the HTML we already have", grafting specific UI behaviours from other elements into page-level infrastructure seems like crossing a line.
(It doesn't help that the spec for lazy loading is still a sea of red caveats and XXX/FIXME markings)
In other words, this still sounds to me like behaviour best driven by events emitted from a Stimulus controller. Hopefully, one that is then composable/re-usable for other event-driven uses of intersectionObserver.

Perhaps I'm not fully understanding some of the other points made above, but I can see a lot of value in this PR as proposed. I have a number of screens in my app that present lists that allow users to drill down (via detail/summary tags) into information if they want/need, but it doesn't make sense to pre-render all of that content because in all likelihood most of that data may never actually need be presented to the user.
Having a concise way to only load the content upon expansion on the elements could very useful in improving the initial loads of these pages.

For me this is a great addition.
Before turbo-frame, we had stimulus controller (content_loader) that had basically same functionality.
Sure, we can implement this without loading: lazy, but it will require stimulus controller + more bloat on the HTML side.
This addition will make those "use-cases" beautifully simple.

This is a good one. as @dixpac said it could be done with content_loader, but we need to handle some layout stuff to make it work properly, having this feature out-of-the-box on turbo-frame tags would be awesome.

This is a good one. as @dixpac said it could be done with content_loader, but we need to handle some layout stuff to make it work properly, having this feature out-of-the-box on turbo-frame tags would be awesome.

From my perspective this PR buys Porsche 911 for the price of VW Golf. I hope it will get merged, since it will clean our codebase a lot. But, I may be subjective 🤷🏼

From my perspective this PR buys Porsche 911 for the price of VW Golf. I hope it will get merged, since it will clean our codebase a lot. But, I may be subjective 🤷🏼

How do I mark a lazy loaded frame as "stale" so it reloads the next time it is displayed?


Tested for generating Drupal scripts

Reference issue #28 when reviewing this PR.

@j-tafoya - sounds good, you'll see the updates in the latest commit. Merge whenever you're ready!


Unify all entrypoints into a single binary, that we can set as docker ENTRYPOINT

A single almond-cloud command, with subcommands for the different servers and scripts. Much cleaner, easier to use and to document. Ideally installed in $PATH, although yarn makes that hard.

Pull Request Test Coverage Report for Build 1475

127 of 229 (55.46%)  changed or added relevant lines in 15 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-1.3%) to 64.537%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

training/gpu_training_daemon.js
2
4
50.0%

nlp/nlp_model.js
4
7
57.14%

scripts/apply-credits.js
2
5
40.0%

scripts/execute-sql-file.js
14
17
82.35%

scripts/get-config.js
4
7
57.14%

almond/master.js
16
22
72.73%

scripts/sync-discourse-sso.js
3
12
25.0%

scripts/get-user-shards.js
5
22
22.73%

scripts/generate-cheatsheet.js
2
27
7.41%

scripts/migrate-dataset.js
8
39
20.51%

Files with Coverage Reduction
New Missed Lines
%

nlp/nlp_model.js
1
56.82%

routes/my_conversation.js
2
62.83%

Totals

Change from base Build 1468:
-1.3%

Covered Lines:
6319

Relevant Lines:
9233

💛  - Coveralls


Feedback for: engine/installation/linux/centos.md

File: engine/installation/linux/centos.md
The link https://download.docker.com/linux/centos/7/x86_64/stable/Packages/ under "Install from a package" does not work. It seems download.docker.com has been developed into store.docker.com.

my bad, this is a dupe of several existing open issues.


ng new  ... fails when not performed on c:\ drive

Bug Report or Feature Request
- [x] bug report

Command
- [x] new

Versions
node v10.7.0
npm v6.1.0
ng v7.0.4
Windows 10
Repro steps

Open command prompt
Change the disk to a drive other than c:\

e: for example

Enter ng new some-app
Enter Y to add Angular routing
Scroll down to SCSS and hit Enter

Output:

Mention any other details that might be useful
I have run through and uninstalled global angular/cli also verified cache afterwards. I installed it again even using @latest. I've installed 10.x and 8.x Node/NPM versions switching back and forth with nvm to no avail.
It seems that the Angular app will be created just fine on a C:\ but not any other disk. I verified permissions were correct, ran everything as administrator, and could not come up with any reasons why it would fail.
One interesting thing to note is when I ran the ng new <appname> on a non-c drive an empty folder named as the drive letter was created at the same directory level. I've reproduced it several times. Otherwise I've only been able to get the ng new to work on the C:\.
Drive letter folder created:

Working on C:\:

Duplicate of https://github.com/angular/angular-cli/issues/12670


[Bug]: Disable Vanilla trade remove ALL trades

What happened?
I created a simple trade template
I turned on the "disable vanilla trade" options, to have villagers with only the trades I wanted
When I click a villager with the template, it gets the trade
I leave, I click again without the template, it has lost the trade
If I try again, turning off the vanilla option, it work normally
Alternatively: is there a way to delete all current trades a villager has?
Relevant log output
No response

I do confirm this bug. Any progress or something like this?

Looks like this affects 1.18+. I'll try to fix and make a release for 1.20.1, It should be backwards compatible with 1.18.

i recommed put values in "chance" not lower than 1
thats allows u to avoid this problem at some point


Add SimplecaseEpisode Unit test

Closes #111

Codecov Report

Merging #173 into main will increase coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   72.32%   72.81%   +0.49%
==========================================
  Files          76       76
  Lines         607      607
  Branches      109      109
==========================================
+ Hits          439      442       +3
+ Misses        144      140       -4
- Partials       24       25       +1

Impacted Files
Coverage Δ

...d/src/components/simplecast/simplecast-episode.tsx
100.00% <ø> (+25.00%)
:arrow_up:

src/components/simplecast/simplecast-episode.tsx
83.33% <0.00%> (+33.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7abf049...1e98449. Read the comment docs.


Rebrand to SINGE

We're changing the abbreviation from SINGE to SCINGE.  I'll change the repo name immediately and leave this open until we have fixed all of the individual files.

Zenodo is temporarily down so I'll have to update that record later.


APP-624 Support MessageML v2

Base parser class to generate MessageML v2 objects

Nice docs!
Lot's of new classes here, but no matching unit tests.
Does Travis report unit test coverage?

@dnsymphony I'm not sure but I think Travis isn't reporting unit test coverage yet.
We need to check with Maurizio if it's required to configure some plugins on Maven to perform that report.
However, this PR has only the class MetadataParser with business logic. The other classes are only POJO to store the XML content. This class specifically has been tested.

@rsanchez-daitan @dnsymphony we can integrate with sonarqube in order to calculate testing coverage and other quality metrics; please read more on https://symphonyoss.atlassian.net/wiki/display/FM/Reporting#Reporting-SonarQube ; and - if interested - open an issue to request sonarqube to be enabled.
As an example, check the sonarqube dashboard of the symphony-java-client - https://sonarqube.com/dashboard?id=org.symphonyoss.symphony%3Asymphony-java-client

@dnsymphony please check again


I want you to add trains and platform doors that are not yet implemented in HKMTR.

Is your feature request related to a problem? Please describe.
I want you to add trains and platform doors that are not yet implemented in HKMTR.
Describe the solution you'd like
Currently, the following items are not implemented.

[ ] M-Train (before renewal)
[x] C-Train (Kwun Tong Line)
[ ] S-Train (South Island Line)
[ ] Q-Train
[ ] R-Train (East Rail Line)
[ ] CRH380
[ ] PSD (Nabtesco, Faiveley Transport)

Note: PSD / APG manufactured by Shenzhen Fangda Automatic System has not been installed yet, and the appearance is unconfirmed, so it is not included in the list.

as far as I know they've all been suggested and a few are being made. I think somebody finished the unrefined m train and Eric280 made a C train.

It seems that the C-train was completed by the pull request, so I checked the task.

Oh yeah somebody made an unrefurbished m train for centown and the s train has finished modelling and is now being textured. R train and Q train are being modelled.

You know you shouldn’t make an issue about trains.

everything except the psd is nearly finished

Duplicate / related to #196


Publish to GitHub packages and update dependency info

Along with Maven Central, also publish to GitHub packages and update dependency info in the README.

added deploy.yml so this can be done after the next time I create a release


fix(cache,gateway-queue): add missing sync-readme checks

Codecov Report

Merging #1259 (488bec8) into main (b28fdde) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1259   +/-   ##
=======================================
  Coverage   31.06%   31.06%
=======================================
  Files         359      359
  Lines       14231    14231
=======================================
  Hits         4421     4421
  Misses       9810     9810

Impacted Files
Coverage Δ

http/src/routing/route.rs
5.67% <0.00%> (-0.32%)
:arrow_down:

http/src/routing/route_display.rs
10.74% <0.00%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b28fdde...488bec8. Read the comment docs.

After this gets merged in next, http-ratelimiting needs to get the same treatment in a seperate PR


Hi~ Catsluck Team. Have you design some playing methods on catsluck combined with catsNFT, such as PK and bet ？

Hi~ Catsluck Team.
Thank you for supporting many other tokens in a short time
Have you followed 10000 catsnfts.
They are very cute. But there is no way to play.
Can we design some playing methods on catsluck combined with catsnft, such as PK and bet 。
That will be very interesting

We are still studying NFT. No such plan now.


Update Teslamate to 1.29.1

Updated Teslamate dependency to 1.29.1

@matt-FFFFFF or any other maintainer. If the MR is ok, can you kindly merge it?
Thanks!


Tree methods are not implemented in base classes

In the Toga demo project, the cocoa tree widget is implemented, but the Tree widget in the base project does not have same the method signatures (or any for that matter).
From what I've seen it's the only widget to be completely missing methods in base, is this by design?

Oversight, not intention. The interface layer is a relatively recent addition, and not all the widgets have been refactored to use it.

This has been resolved by a refactor of the Tree/Table data source implementation.


Created Japanese Translations

It still needs a font

Hello @Neuxs0 ! You missed the .json file extension, might as well fix it in the next commit?

Hello @Neuxs0 ! You missed the .json file extension, might as well fix it in the next commit?

fixed

Recently pulled in the font changes needed so, merging now, thank you!


fixed progress bar bug in result page

@iakancay For me the progress elements aren't showing on the result page, does that work for you? It seems like after the result page is renderd, the application is still trying to do things in the nextQuestion function of the previous page. I think when we call initResultPage(); we need to make sure no other code is run afterwards.

Arco we show progress elements in result page because we don't see the last result when we are in last question.After answering last question we move to the result page so to learn final score and total number of correct incorrect answers we need to show progress element in result page.


Protected features UI

Is your feature request related to a problem? Please describe.
UI for #430 does not exist.
Describe the solution you'd like
When creating, updating, and viewing features, we need an ability to view and modify a feature's is_server_key_only value.
I propose we call the checkbox "Protected feature".
The help text should be something like: "Prevent this feature from being accessed with client-side environment keys."
Additional context
is_server_key_only is available to the following endpoints:

/api/v1/projects/{project_id}/features/

Will be live under the feature flag is_server_key_only


Typo

[Enter feedback here]
Peer-to-Psafaseer replication, is in the text.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2d481270-9da8-1af1-b010-2bcf9807a0a8
Version Independent ID: 146f72dc-f0cf-6699-b055-83c5e0f07f94
Content: Transactional Replication - SQL Server
Content Source: docs/relational-databases/replication/transactional/transactional-replication.md
Product: sql
Technology: replication
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

@larrystavinoha -- thank you for bringing this to our attention.  I am updating the article.

Thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.


Inconsistent use of Metadata_Well vs Metadata_Well_Value

I'm not sure why we use Metadata_Well in some pipelines and Metadata_Well_Value in others, but (unless I'm forgetting/missing something) it would be cleaner to stick to just Metadata_Well.

My recollection is there was a parsing issue in some pipelines, such that sometimes we wanted it maybe digit padded and sometimes not? But it was always a hacky fix, so feel free to make it more elegant


First setup issues

Hi,
I've setup a headless RPi 3B+ with hassio. I am not getting this working... What I've done is the following:
Changes made according to specifications in configuration.yaml aswell as copied the *.py files to .homeassistant/custom_components/sonoff/
First issue log

Logginformation (ERROR)
Logger: homeassistant.setup
Source: setup.py:127
First occurred: 13:26:17 (8 occurrences)
Last logged: 13:26:17
Setup failed for entity_prefix: Integration not found.
Setup failed for username: Integration not found.
Setup failed for grace_period: Integration not found.
Setup failed for sonoff: Integration not found.
Setup failed for debug: Integration not found.

Second issue log

Logginformation (ERROR)
Logger: homeassistant.loader
Source: custom_components/sonoff/init.py:28
First occurred: 13:26:17 (1 occurrences)
Last logged: 13:26:17
Error loading custom_components.sonoff. Make sure all dependencies are installed
Traceback (most recent call last):
File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/loader.py", line 436, in _load_file
module = importlib.import_module(path)
File "/usr/lib/python3.7/importlib/init.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "", line 1006, in _gcd_import
File "", line 983, in _find_and_load
File "", line 967, in _find_and_load_unlocked
File "", line 677, in _load_unlocked
File "", line 728, in exec_module
File "", line 219, in _call_with_frames_removed
File "/home/homeassistant/.homeassistant/custom_components/sonoff/init.py", line 28, in
import websocket
ModuleNotFoundError: No module named 'websocket'

Any ideas?

If you used virtual environment:

enter virtual env
pip3 install websocket-client OR pip install websocket-client
and you should good to go


Keep windows distribution

[x] I am on the latest Hyper.app version
[x] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name: OSX Sierra
Hyper.app version: Last

Issue
Hi guys, how are you?
I want to know if there is any way to keep the windows distribution. I would like to start my hyperterm split on three.
Is this possible?
Thanks!

Have you tried this? https://www.npmjs.com/package/hyperlayout

Thanks!


Look for .env file in root dir

Based on https://github.com/pydanny/cookiecutter-django/issues/490 and some other discussions.
Docker is looking for a .env file in root directory. But with the old code, django settings will expect the file in /config/settings directory. This change fixes this, so that django settings will look for .env file in the root directory.

https://github.com/pydanny/cookiecutter-django/pull/985 is a better implementation


Support WriteFilesExec in Spark-3.4 to fix several tests [databricks]

Closes #7441
Closes #7617
changes in Spark
Spark 340 introduced a new operator WriteFiles(logical) WriteFilesExec(physical).
Execute InsertIntoHadoopFsRelationCommand
+- Coalesce 1
   +- LocalTableScan

Changed to:
Execute InsertIntoHadoopFsRelationCommand
+- WriteFiles   // Added in Spark 340
   +- Coalesce 1
      +- LocalTableScan

Or
Execute InsertIntoHadoopFsRelationCommand
+- WriteFiles   // Added in Spark 340
  +- Sort   // added by planning phase
     +- Coalesce 1
        +- LocalTableScan

Spark code
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/V1Writes.scala#L75-L82
    if (conf.plannedWriteEnabled) {   // The config is: "spark.sql.optimizer.plannedWrite.enabled"
      plan.transformUp {
        case write: V1WriteCommand if !write.child.isInstanceOf[WriteFiles] =>
// Note: Add Sort if necessary
          val newQuery = prepareQuery(write, write.query)
          val attrMap = AttributeMap(write.query.output.zip(newQuery.output))
// Add WriteFiles
          val writeFiles = WriteFiles(newQuery, write.fileFormat, write.partitionColumns,
            write.bucketSpec, write.options, write.staticPartitions)
          val newChild = writeFiles.transformExpressions {

solution

Add GPU version GpuWriteFilesExec
Copy GpuFileFormatWriter to 2 shims, one is for Spark [311, 340), one is for Spark 340+
Add a rule to tag WriteFiles according to its parent node. When WriteFiles  can't run on GPU, so does WriteFiles
Also fix https://github.com/apache/spark/commit/3d5af03070

Note:
Some of tests in parquet_write_test.py still fail because of this issue #7495
Signed-off-by: Chong Gao<EMAIL_ADDRESS>

Still a draft, need to do more tests.

Spark-3.4 build on spark-rapids is currently broken due to this issue: https://github.com/apache/spark/commit/faedcd91

Blocking by:
https://github.com/NVIDIA/spark-rapids/issues/7557
https://github.com/NVIDIA/spark-rapids/issues/7617

build

build

build

build


Failed to parse speedtest.net configuration 0.3.4

HI. Please, help!
$ /usr/local/bin/python2 /home/dmx/speedtest_cli.py
Retrieving speedtest.net configuration...
Failed to parse speedtest.net configuration
$ /usr/local/bin/python2 /home/dmx/speedtest_cli.py --ver
0.3.4
FreeBSD aero.cv.ua 9.3-RELEASE FreeBSD 9.3-RELEASE
Yesterday everything worked.

speedtest is unknown if the ISP information("speedtest-config.php line 3") sent to the Data Link Escape (U + 0010).
So, this is necessary to modify the source code.("speedtest_cli.py line 393")
speedtest_cli.py.txt

Same issue here

this patch fix the problem.
there are 2 issues i had to add http header to support gzip format and i had extract the configuration  gzip
diff --git a/speedtest_cli.py b/speedtest_cli.py
index d93d5c3..be630ca 100755
--- a/speedtest_cli.py
+++ b/speedtest_cli.py
@@ -24,6 +24,8 @@ import socket
import timeit
import platform
import threading
+from StringIO import StringIO
+import gzip
version = '0.3.4'
@@ -216,6 +218,7 @@ def build_request(url, data=None, headers={}):
schemed_url = url
 headers['User-Agent'] = user_agent

headers['Accept-Encoding'] = """gzip, deflate, sdch"""
return Request(schemed_url, data=data, headers=headers)

@@ -382,7 +385,11 @@ def getConfig():
sys.exit(1)
configxml = []
while 1:

   configxml.append(uh.read(10240))

   buf = StringIO(uh.read(10240))

   f = gzip.GzipFile(fileobj=buf)

   data = f.read()

   configxml.append(data)
   if len(configxml[-1]) == 0:
       break

if int(uh.code) != 200:

Just encountered this problem. How can I resolve?
➜  ~ speedtest-cli
Retrieving speedtest.net configuration...
Retrieving speedtest.net server list...
Failed to parse list of speedtest.net servers

Running 0.3.1.

apply the patch above or edit speedtest_cli.py
add the following lines after line 24 (import threading)
from StringIO import StringIO
import gzip
and
replace line 216
headers['User-Agent'] = user_agent
with
headers['Accept-Encoding'] = """gzip, deflate, sdch""" return Request(schemed_url, data=data, headers=headers)

@amk21 why is the patch just pushed and a new version deployed to pip?

i had some issues with pushing the fix.
On Thu, Nov 3, 2016 at 1:22 AM, Justin Keller<EMAIL_ADDRESS>wrote:

@amk21 https://github.com/amk21 why is the patch just pushed and a new
version deployed to pip?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sivel/speedtest-cli/issues/271#issuecomment-258029322,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVc7jJKHFXlvxAtaOPD4RNGC0XpYvgVVks5q6RsugaJpZM4JDafy
.

Please test with the recently released v1.0.0.


Configure Azure Pipelines

This configuration builds the application and produces builds for both Debug and Release configurations.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: kmadhus sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

This configuration builds the application and produces builds for both Debug and Release configurations.


[labs/nextjs] Support Next.js 14

Which package(s) are affected?
Other/unknown (please mention in description)
Description
The plugin still should work with the Page router even in Next.js 14.
We could include it in our peer dependency sem ver to allow installs. We should still clearly document limitation with App router.

what about the app router?

@foadtkf support for app router is tracked in a separate issue https://github.com/lit/lit/issues/3657

Supporting v14 seems a bit more complicated as they're now bundling react/jsx-dev-runtime and react/jsx-runtime rather than it being external for us to use the normal module replacement plugin. See https://github.com/vercel/next.js/discussions/46470#discussioncomment-8375627 and https://github.com/vercel/next.js/pull/55362
We may need to make users specify jsxImportSource instead and also forego with wrapping the webpack externals config. This means we no longer have the ability to touch any jsx-runtime imports within node_modules code, e.g. npm installed react components that use bare Lit components within them. This was considered a pretty niche use case to support but nonetheless disappointing to have to give up.
Monkey-patching of React.createElement still seems to work.

Found a way to monkey-patch everything without resorting to module replacement in above linked PR.


Updating Quickstart guide

Making changes to Quickstart guide to include how to add OpenAI API key.

Thank you! closes #130


govuk_app_console does not set correct env vars for publishing-api in development VM

Running govuk_app_console publishing-api sets the relevant env vars for the Postgres role to "deploy" rather than "vagrant" when running in the development VM. This means that any actions in the console that rely on the database fail.
The workaround is to run bundle exec rails console instead, but it would be good to get this to work consistently.
I have opened this issue as I cannot see exactly where this env var is set from.

@rubenarakelyan Seems to be hardcoded in modules/govuk_scripts/files/usr/local/bin/govuk_app_console


Can I mock _httpContextAccessor.HttpContext.GetMultiTenantContext ()?.TenantInfo.

Is there a way how to mock this method for unit testing?

I'm interested in this question.
I think this is the way for debug multitenant applications in Visual Studio when the url is localhost:xxxx.
Or do you know any other way for debug Finbuckle applications in Visual Studio debugger?

Mocking GetMultiTenantContext is rather painful, as it invokes HttpContext.RequestServices.
If you want to be able to Mock TenantInfo in your controllers you would be better off having IMultiTenantContextAccessor<TenantInfo> as an constructor injection.

@Nisden is right -- just use IMultiTenantContextAccessor<TenantInfo> directly rather than the GetMultiTenantContext which is just a simple wrapper for it anyway. Let me know if you run into any issues with this.

Thanks to all for your help

If anyone is interested, this is how I ended up doing a quick fix on our integrations tests after migrating to multi-tenant
var multiTenantContextAccessorDescriptor = services.First(d =>
    d.ServiceType == typeof(IMultiTenantContextAccessor<ApplicationTenantInfo>));

services.Remove(multiTenantContextAccessorDescriptor);

// Register testing version
services.AddScoped<IMultiTenantContextAccessor<ApplicationTenantInfo>>(_ =>
{
    var multiTenantContextAccessor = Mock.Of<ITestingMultiTenantContextAccessor>();
    var multiTenantContext = new MultiTenantContext<ApplicationTenantInfo>
    {
        TenantInfo = new ApplicationTenantInfo
        {
            Id = "FAKE_TENANT",
            ConnectionString = _configuration.GetConnectionString(ConnectionStringName)!,
        },
    };
    multiTenantContextAccessor.MultiTenantContext = multiTenantContext;
    return multiTenantContextAccessor;
});

That’s a good approach.
In v9 there is an internal implementation called StaticMultuTenantContextAccessor which I will make public in the 9.1 release that works well for this need. I created it for the MultiTenant db context create factory function and realize now that it should be public not internal.
internal class StaticMultiTenantContextAccessor<TTenantInfo>(TTenantInfo? tenantInfo)
    : IMultiTenantContextAccessor<TTenantInfo>
    where TTenantInfo : class, ITenantInfo, new()
{
    IMultiTenantContext IMultiTenantContextAccessor.MultiTenantContext => MultiTenantContext;

    public IMultiTenantContext<TTenantInfo> MultiTenantContext { get; } =
        new MultiTenantContext<TTenantInfo> { TenantInfo = tenantInfo };
}


Add some code to allow dns resolution

Allow for dns resolution across vpc peers spanning multiple caccounts

Looks like that CI fails even on master. I don't think the linter likes having variables named outside the template using them. It's dying on ${var.stage} which I didn't change.

Made the requested changes.

@lofidellity  thanks.
Was it tested on AWS (terraform apply)?

please also run terraform fmt on all TF files
TravisCI is failing https://travis-ci.org/cloudposse/terraform-aws-vpc-peering-multi-account/builds/490675953

@lofidellity  can you please address the latest comments so we could merge it?

yes I am using this code across multiple accounts in my terraform codebase.


Falcon7b (tt-lib) non-deterministic demo hang on nebula x1

The Falcon7b demo randomly hangs during different invocations of the model forward pass (both compile and inference, and both prefill and decode, but usually decode inference). Additionally, the model usually produces non-deterministic and incorrect output before hanging. The hangs / incorrect outputs become more likely as the number of output tokens increases (i.e. more forward passes). The frequency of the hang is machine dependent, but it can occur as often as every 1-4 runs of the demo.
Additional information:

800 MHz clock is being used
This is not a newly introduced bug (first observation was in late Feb/ early March)
The hang/ND-outputs has never been observed on nebula x2 after 100 runs of the demo (note: experiment is run on single device of t3000), except when forcing 8x8 core grid using WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml, making 8x8 grid size a potential culprit (unless running fast dispatch on idle ethernet cores is causing other issues)
The hang still occurs with slow dispatch (using TT_METAL_SLOW_DISPATCH_MODE=1)
The hang still occurs after forcing all ops to be blocking (by hacking HWCommandQueue::enqueue_command)
The last op running before hanging is inconsistent, but has been observed to be (from most frequent to least): the lm-head Matmul op, the RotaryEmbedding op, the EltwiseBinary Add op. All of these have DRAM-interleaved inputs and outputs under the default model config in the demo, and there are no sharded ops in the model, making dram-interleaved ops potential culprits
The hang/ND-outputs has not yet been observed using TT_METAL_WATCHER=1, making timing a potential culprit
The hang/ND-outputs occurs more often when using TT_METAL_LOGGER_TYPES=Op TT_METAL_LOGGER_LEVEL=DEBUG

Instructions to stress-test demo:
Commit: b5fe44ddf7631e3d59cb953c238666113a76913d
bash models/demos/falcon7b/tests/run_demo_test.sh

Note that we don't run performance models on a X1 machine, only X2.

The hang/ND-outputs has never been observed on nebula x2 after 100 runs of the demo (note: experiment is run on single device of t3000), except when forcing 8x8 core grid using WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml, making 8x8 grid size a potential culprit (unless running fast dispatch on idle ethernet cores is causing other issues)

this is interesting. 8x8 fails on both n300 with ethernet idle core (X2) and n150 (X1), while 7x8 passes on n300.
Are we able to isolate to which op this is with a repro?

The 8x8 failure on n300 occurs with the same ops listed above for n150, specifically RotaryEmbedding and the lm-head Matmul (although it is non-deterministic).

@uaydonat Strange observation/breakthrough: If this line is removed (i.e. input tokens are not updated at end of iteration), no longer seeing hang. Obviously we can't remove that line, but will try to investigate why that is making a difference.

Additional finding: On X1, if the grid size for all matmuls (1d, dram interleaved) is set to 8x7, I no longer see the hang. Based on this and the other observations above, the issue seems to be a combination of grid size and timing.

Investigation update:

The hang appears to be a symptom of data corruption which causes the model to produce ND outputs during the prefill stage. Without any modifications, the ND outputs start occurring at different stages of the model and at different ops.
However, after adding numerous sync points to the model (by saving intermediate tensor outputs using tt2torch calls) and removing some of the ops, the ND outputs can be isolated to a specific op - the h-to-4h matmul in the 4th layer (out of 32) of the model. Both inputs of the matmul are correct before and after the op, while the output always seems to have corruption in 2 tiles (the corruption appears as small differences in the output, and is not the same between runs).
Forcing all matmuls to have a compute grid size of 8x7 makes the ND behaviour go away as expected. An additional finding is that the ND behaviour can also go away by forcing out_subblock_h = out_subblock_w = 1 (which happens to be the configuration of this matmul when using 8x7 grid size). One hypothesis for this making the ND output go away is that this makes the matmul slower and eliminates some race condition.

Commit: 925c9b04ef9e31b844eadf11b37ce3b537e4a249
Command: pytest --disable-warnings -q -s --input-method=cli --cli-input="Tell me a joke." models/demos/falcon7b/demo/demo.py

i think we should have @TT-BrianLiu starting taking a look at the matmul behaviorial. Triaging to op_cat: mm queue

I am in the loop with this issue already. @skhorasganiTT Do you have next steps to try?

@cfjchu mentioned this may be related to another hang #6917 (1d mm + l1 packing seems sus)

Disabling l1 accumulation on all matmuls makes the hang/nd-outputs significantly less frequent

Probably a timing issue. L1 accum is supposed to be faster?

@s-jovic mentioned that this might be related to the block matmul hang from #4968

If you suspect that #4968, it might be worth just looping that matmul with different clks to confirm.

Decode hang
but prefill generate in correct result.

Added workaround to main to set falcon7b matmuls to 8x7 (e766e2d). Lowering priority to P1 until related matmul nd-output/hang issues are investigated.

@skhorasganiTT we should try without the work-around using FD2.

I re-tried the demo on x1 without the workaround and with the firmware update on c3bbc07 (after FD2). It worked 16 times and hung on the 17th, so it seems like it's still an issue, although much less frequent (before it would hang after a couple runs).

I re-tried the demo on x1 without the workaround and with the firmware update on c3bbc07 (after FD2). It worked 16 times and hung on the 17th, so it seems like it's still an issue, although much less frequent (before it would hang after a couple runs).

Based on the data

switch to MMs from 8x8 to 8x7 --> hang gone
disable L1 accumulator --> hang 10x frequent

@uaydonat this smells like di/dt
fyi @ttmtrajkovic @rtawfik01

@skhorasganiTT which machine did you see the hang on?
Can you try it on a different machine assess board-dependence?

It was on aus-glx-06, I will try another one as well.

can you try a T3000 or a single N150, or a single N300?

aus-glx-06 is configured as a single n150, i can try it on n300 with WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml as well

Tried the same test on sjc-nmrk-t3001 without the workaround, hung on the 9th run of the demo.
Command:
WH_ARCH_YAML=wormhole_b0_80_arch_eth_dispatch.yaml pytest --disable-warnings -q -s --input-method=json --input-path='models/demos/falcon7b/demo/input_data.json' models/demos/wormhole/falcon7b/demo_wormhole.py


Support API Keys with data_view resource

Fixes https://github.com/elastic/terraform-provider-elasticstack/issues/529
Does what it says on the tin, adds support for API key auth into the data view resource.

@tobio , is lack of privilege in the API key causing acceptance tests to fail?

Looks like the data view api spec is missing details for API key auth 😢. It's also missing support for Kibana spaces so I'll try and get both of those added in and fix this one up.


Fix bug: We should use lpush not rpush

Pretty simple change but an important one. LIFO vs FIFO queue.

Released as 0.6.1


Increase module flexibility

The changes I'm proposing will allow this module to be used in a streamlined fashion where we don't need one object per bulb, which will allow us to override the configured MAC value with a MAC specified in msg.topic, and the same with the bulb type if msg.bulbtype is specified. The rest are standardization, stylistic, and documentation changes.

Use msg.topic to override the specified MAC in the control if it is present in the msg object.
Use msg.bubltype to override the specified bulb type in the control if it is present in the msg object.
Update the control to use "Topic" and the topic icon from the core Node-RED controls in the configuration page.

The screen caps haven't been updated.

Looks good to me!

Sweet! It looks like the update on NPM hasn't shown up yet. Also, do you want me to do some new screen shots?


Changing profile section to settings

Problem Statement
There is no profile concept in Inji. The options currently working here are actually settings. As part of this issue, we would be changing the profile to settings with some label changes and hiding some features.
Resolution

Change the profile icon to a cogwheel, so that, it looks like a settings option on the home screen.
Change the heading for the profile page from "PROFILE" to "SETTINGS".
Remove the option - "Credits and Legal Notice" and add a docs page in the source code for Credits.
Hide the option - "Revoke ID"
Hide the option - "Unlock Auth Factor"
Remove the option - VC Label and the default value for VC Lable should be "Card".
Change the label for "Biometric Unlock".

Screenshot

@SwatiPeriwal, Please provide the label for Biometric Unlock.

@nayakrounak Think we can use Unlock using Biometrics /  Unlock Biometrics
@nayakrounak    Display the QR Code to request/receive resident ID   (please review and trim as required)

@PuBHARGAVI is looking into this

Unlock with biometrics can be used as the label
Get Outlook for iOShttps://aka.ms/o0ukef

From: krishna kumar T @.>
Sent: Monday, March 6, 2023 11:03:09 AM
To: mosip/inji @.>
Cc: Swati Periwal @.>; Mention @.>
Subject: Re: [mosip/inji] Changing profile section to settings (Issue #607)

This e-mail originated outside of the Organization. Exercise caution before clicking links or opening attachments *

@PuBHARGAVIhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FPuBHARGAVI&data=05|01|swati.periwal%40mindtree.com|6931ce466adf48da729108db1e0446a4|85c997b9f49446b3a11d772983cf6f11|0|0|638136775954793718|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=1%2FKzMWUseHFUJP1j75CXuMFzqF84PlOchQFtRu0r3hk%3D&reserved=0 is looking into this
—
Reply to this email directly, view it on GitHubhttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmosip%2Finji%2Fissues%2F607%23issuecomment-1455483773&data=05|01|swati.periwal%40mindtree.com|6931ce466adf48da729108db1e0446a4|85c997b9f49446b3a11d772983cf6f11|0|0|638136775954793718|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=%2FWUiPvX3iad0qePco9XlSuwpserrFmwjIACbgb1CIwk%3D&reserved=0, or unsubscribehttps://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWXLBSOOMRUYADMDRTMECUDW2VZJLANCNFSM6AAAAAAVNV6XCA&data=05|01|swati.periwal%40mindtree.com|6931ce466adf48da729108db1e0446a4|85c997b9f49446b3a11d772983cf6f11|0|0|638136775954793718|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=s2IcgSVnN8e2dktipkMsWIjn3jk3uVkAnjzjan8s%2BcI%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

http://www.mindtree.com/email/disclaimer.html

I made changes in the profile screen and now screen looks like this

Changed the default value of VCLabel from "ID" to "Card"

Also changed the screen header title from profile to settings in all the languages using goggle translator
Notes:

when translating "settings" into all the languages i have again retranslated them into english to check if they are coming correct or not. After retranslating also i am getting "settings" in english

For filipino language the translation for "Home" was missing in fil.json file. so i have used google translator to get the equivalent word in filipino language and it showed "Bahay" and when i again retranslated it to english it showed "House"

3.For the scan screen title "scan" google translator showed "scan" in the filipino language. so as it is same in both english and filipino i didn't change anything for scan screen
@SwatiPeriwal  could you please check this?

@PuBHARGAVI For point no. 4, lets wait for @nayakrounak to revert. On the settings page, any specific reason for us to have "Log-out" instead of "Logout"?

Regarding the 4th point in the above comment :
Currently the "ID type" for every card in the home screen is getting translated in all languages and it is an hardcoded value in the code
Case1:
if i need to change this to "Card type" i need to change this in all the languages json files.
Case2:
I can also replace this hardcoded one with the {VcLabel} but this value is not getting translated in all the languages it shows "Card" irrespective of what language is choosen

@PuBHARGAVI Irrespective whether translations existed. We should not show useBle in the UI since its not a value but a key.
Having said that, We can keep english names on all languages -> "Powered by BLE" and "Powered by GoogleNearby"

Changes made in this task:

The profile icon to settings icon
Hided RevokeId, Vc Label, Unlock auth Factor and credits and legal notices option in settings screen
Moved the Powered By BLE text from setting options to the bottom in settings screen and added english text in all languages as discussed
Log-out to Logout in all languages
The Sharing Vc screen labels to "Share" and "Share with Selfie" in all languages
Default value of VC Label to "Card"
Added translations for Home screen header title in filipino language

Profile icon has been changed to Settings, & all requested changes are done as per the above comment.
PR for mosip/inji: https://github.com/mosip/inji/pull/630
The PRs have been merged in 09-03-2023 Release and the latest commit id on mosip/inji/develop is fa142c6

Profile icon has been updated to "SETTINGS" with all the expected changes. Attaching the screenshot for the reference


Update core-concepts.md

Wrong closing tag :)

@danielduckworth Thanks for the catch & PR :)

No worries, I really love what you've got going here!


rlImGui doesn't respect WantCaptureMouse/WantCaptureKeyboard

When you click inside an ImGui window, that click should be "consumed" by ImGUI and not delivered to the app (ie: IsMouseButtonPressed() should return false after that).
ImGUI uses the flag WantCaptureMouse to signal it wants to capture mouse movement and clicks, but rlImGui doesn't currently read this flag. This is explained in ImGUI's FAQ.
Same goes for keystrokes and the flag WantCaptureKeyboard.
Note: This doesn't seem possible to implement on top of the current Raylib API, new API methods might be needed.

This is no how ImGui works. you are supposed to check ImGui if it wants the device input or not. The IO has want key and want mouse fields. If ImGui wants the device, it's your job not to check the underlying platform. It's not the job of rlImGui to change event states in the underlying platform. ImGui does not assume that the underlying platform even has events.
This is a user error issue not a missing feature in raylib.
rlImgui doesn't need to read that flag. that flat is for YOU and your code. rlImgui sends data to Imgui so it knows if it needs to set that flag or not. I am very aware of how that flag works.
In that FAQ, the 'underlying application', is your code, it is not raylib and it is not rlImGui, it's you.

That said, rlImGui should not pull key events from the buffer when WantCaptureKeyboard is false so it can let the underlying application read those events.
But for mouse, there are no events to clear.

rlImGui no longer eats KeyPress events, it computes them from polls, and it only eats character events if ImGui wants keyboard input.
This should allow the underlying app to get access to the events needed after checking the input capture flags in the IO structure.

This can indeed be implemented on the user app's code, it's just a bit more convoluted: either you check before each IsMouseButtonPressed() or you wrap that method and update all usages.
IMO it would be a quality of life improvement to have it in the application side, and also a smaller change. For an example, here's how I implemented it on top of SDL with just two ifs in total.
It might not be as simple in Raylib and maybe not worth doing it for that reason, but I do think it would make people's life easier if it was there.

I don't think that is the correct fix for the level that rlImGui is designed to be at.

That change assumes the underlying app doesn't still need to poll the input data, it may for various reasons, like drawing your own cursor. I don't want rlImGui to assume anything.
I don't think that will work for pure keyboard navigation, once you lost capture, there would be no way to get back to it.
I need raylib's API to send the input TO ImGui, if I tell raylib to stop processing input I'll loose the ability to get that input next frame.
The field in the IO structure is from the last ImGUi frame, events this frame may change it. I don't think your fix is as robust as you thing, it may work for simple mouse based navigation.
I have worked with the author of ImGui in the past and I don't think the intnent of the flag is to change the underlying platform state, just tell the calling application if it should query the platform or not.
I think the 'convenience' of this would cause more confusion than it solves. It's your job to manage input in your app, not raylib's or ImGui. Nobody has ever asked for this in the past. In fact the problems I do get are the opposite of your request, that we are not exposing enough of the ImGui input events back to the calling app.

I have made some changes to minimize how much of the raylib events that rlImGui eats so that the app can have as much data as possible for whatever reason it needs. I don't want to assume that I know how people are using rlImGui, and it should be up to them how they handle input and if they want to use the consume flags.

Makes sense, thanks a lot for the detailed reasoning and sharing your insights into this 🙇


Error: No process running on port

Привет,
I have an issue using the reloading with the Reloader from advanced-extension-reloader-watch-2 with esbuild.
My esbuild config:
import esbuild from 'esbuild'
import stylePlugin from 'esbuild-style-plugin'
import tailwindcss from 'tailwindcss'
import Reloader from 'advanced-extension-reloader-watch-2/umd/reloader'

import {
  copyLocalesFolderTo,
  generateLocales,
} from './scripts/generate-locales'

const reloader = new Reloader({
  port: 6223,
})

reloader.watch()

const watchPlugin = {
  name: 'watch-plugin',
  setup(build: esbuild.PluginBuild) {
    build.onStart(() => {
      console.log(`Build started at ${new Date().toLocaleTimeString()}`)
    })
    build.onEnd(async (result) => {
      const time = new Date().toLocaleTimeString()
      console.log(
        `Build finished at ${time}, ${result.errors.length} errors, ${result.warnings.length} warnings`,
      )
      console.log('Reloading extension...')
      reloader.reload({
        ext_id: 'ehfifdpieloecbgndipmciaoahdodlme',
        play_sound: true,
      })
      console.log('Watching for changes...')
    })
  },
}

console.log('Dev build started...')
const options: esbuild.BuildOptions = {
  entryPoints: {
    content: './src/index.ts',
    resources: './resources/index.ts',
    background: './background/index.ts',
    popup: './popup/index.tsx',
  },
  bundle: true,
  minify: false,
  sourcemap: 'inline',
  loader: {
    '.tsx': 'tsx',
    '.ts': 'ts',
    '.css': 'css',
  },
  outdir: 'dev',
  define: {
    'process.env.NODE_ENV': '"development"',
  },
  jsxFactory: 'React.createElement',
  external: ['./xhr-sync-worker.js'],
  jsxFragment: 'React.Fragment',
  plugins: [
    watchPlugin,
    stylePlugin({
      postcss: {
        plugins: [tailwindcss],
      },
    }),

  ],
}

console.log('Building...')
const ctx = await esbuild.context(options)
await ctx.watch()

my config in chrome:

Do you have any idea why this is happening?
Cпасибо тебе.
EDIT: It works, i don't know what I changed, does editing the port in the settings saves on change ? 🤔

it's not really about esbuild, anything should work since you're calling method on the listener class, but now it works, thanks for the extension, it's actually the best i've found among many ones I tried.

It doesn't work again. I don't know why. port 6000 on both the extension settings and in the
const reloader = new Reloader({
  port: 6000,
})

i get :
Error: No process running on port

in offscreen.js

Port 6000 is restricted in Chrome. Use a different port, make sure it's not on this list.
In your the offscreen screenshot Advanced Extension Reloader tries to connect to a server with port 6060 not 6000. See GET http://localhost:6060/socket.io/... in your screenshot. Are you sure port 6000 is in the settings, or do you use 6060 alongside with 6000?
When and where do you get the "Error: No process running on port" error?

Here is my settings

const reloader = new Reloader({
  port: 6223,
})

Error: No process running on port
    at node_modules/advanced-extension-reloader-watch-2/umd/reloader.js:9:618699

I tested it and was not able to reproduce this bug. Need more info. I'm reopening this issue, maybe someone else knows the cause of this.

Btw, I tried again and had to do
import Reloader from 'advanced-extension-reloader-watch-2/es/reloader'

// @ts-ignore
const reloader = new Reloader.default({
  port: 6223,
})

with this tsconfig:
{
  "compilerOptions": {
    "noUncheckedIndexedAccess": true,
    "strict": true,
    "allowJs": true,
    "allowSyntheticDefaultImports": true,
    "baseUrl": "./",
    "esModuleInterop": true,
    "experimentalDecorators": true,
    "jsx": "react-jsx",
    "module": "esnext",
    "moduleResolution": "node",
    "noImplicitAny": true,
    "resolveJsonModule": true,
    "paths": {
      "common": [
        "./common"
      ]
    },
    "sourceMap": true,
    "target": "esnext",
    "types": [
      "chrome",
      "node",
      "react",
      "react-dom"
    ]
  },
  "include": [
    "esbuild.prod",
    "esbuild.dev",
    "chrome-webstore-manager",
    "environment.d.ts",
    "src/**/*",
    "common/**/*",
    "background/**/*",
    "resources/**/*",
    "popup/**/*",
    "_locales/**/*",
    "scripts/*",
  ]
}

I don't know why this problem arose.
But regarding the port problem, it seems resolved.

I managed to reproduce this issue on Linux. The advanced-extension-reloader-watch-2 didn't actually work there at all for me (tested on Ubuntu).
I released an update to advanced-extension-reloader-watch-2 some time ago that may have fixed the issue on macOS too. If you're still interested in using the extension you can test it now.
Also, fixed another issue with Chrome stealing focus on an extension reload.

Closing due to lack of response. The issue is likely resolved, but feel free to reopen if the problem persists.


check running nats server for errors

Description

check running nats server for errors and use the runtime context
don't import NATS via REVA

Because of these changes you now can also run and kill NATS, just like other extensions:

ocis kill nats
ocis run nats

Related Issue

Motivation and Context

was not fully integrated into the runtime

How Has This Been Tested?

manually

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[ ] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

:boom: Acceptance test localApiTests-apiSpaces-ocis failed. Further test are cancelled...


Not working on React native

I'm not able to build my react-native app using this awesome module. I have this error inside metro bundler:
error: bundling failed: Error: Unable to resolve module `fs` from `/Users/ XXX /node_modules/typescript-ioc/index.js`: Module `fs` does not exist in the Haste module map

my packages:
    "tslint": "^5.14.0",
    "react": "16.8.3",
    "react-native": "0.59.8",
    "react-native-router-flux": "^4.0.6",
    "react-native-vector-icons": "^4.6.0",
    "typescript-ioc": "^1.2.5"

    "typescript": "^3.4.5"

I got the same with simple js app.
It decided whether to use es5 or es6 by checking if this === window, then check if it is es6 with process.env.ES6 === 'true'. Both those checks fail so it assumes it is a node app and does that:
var fs_1 = require('fs');
var path_1 = require('path');

This breaks the app. I feel like the way it is exported should be changed, maybe using package.json fields like module etc.

Fixed in version 3


Add support for codeLens/resolve request on server

The LanguageServer trait is currently missing support for the codeLens/resolve request which is often used in conjunction with the textDocument/codeLens request (see #10).

Closed by #107.


Reopen "get k8s config from requestConfig. and added test."

I rebased this PR(#1279) from master.
Please review.

IIUC, this PR will allow to configure K8 in workflow definition ?
If so, I would like to ask you to add server configuration to enable/disable of it and default is disable for server administrators.

@yoyama
Sorry for late reply.
I'm sorry if it's not what I intended.
I would like to add a parameter that allows setting using the parameter of "kubernetes" from the workflow.
The parameters are as follows.
agent.command_executor.kubernetes.allow_configure_workflow_definition=true

If this parameter is true, requestConfig is merged with systemConfig and used like PR.
If false, only systemConfig is used. (As an image, the original createFromSystemConfig method)
If this parameter is not set or defaults, it is treated as false.

@yoyama
Added parameter.
https://github.com/treasure-data/digdag/pull/1692#issuecomment-1175773307
I don't know if this is intended by yoyama san, so please tell me your opinion.
I fixed it based on some indications in the code.
https://github.com/treasure-data/digdag/pull/1692#discussion_r914495928
https://github.com/treasure-data/digdag/pull/1692#discussion_r914499547
https://github.com/treasure-data/digdag/pull/1692#discussion_r914501498
Please review.

@hnarimiya Could you rebase your PR to the laster master and fix the CI failures ?

@yoyama @szyn
I'm sorry for being late.
Please review.


Autodoc

Should fix issue #65 .  Also renames function to clarify meaning.

Codecov Report

Merging #66 (b182919) into master (6d4ac56) will decrease coverage by 3.85%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   92.71%   88.86%   -3.86%
==========================================
  Files           7        7
  Lines         453      440      -13
==========================================
- Hits          420      391      -29
- Misses         33       49      +16

Impacted Files
Coverage Δ

src/autodoc.jl
100.00% <100.00%> (ø)

src/core.jl
83.72% <100.00%> (ø)

src/streamutil.jl
25.00% <0.00%> (-62.81%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


feat: new landing page

I see it good on mi firefox, anyone else ?

@cazala knows the issue with wide fonts, it already happened in the past

I thing we are doubling the risk with the festival so close, having two versions of the front increases chance of failure. Both Romi and I agree the "hidden animated button" was comprehensible enough for everybody. If nobody has an issue with it, please lets go 100% with that and release asap. We need time to react to the analytics before the event.


[NL] layout updates

Add header back
Make query history items clickable (triggers typing animation + enter)

Nice edits!
Are we enabling history on climate trace with this? (It doesn't have currently)?  Maybe I misunderstood, but I thought guha didn't want history on custom dc (owing to privacy questions).

Nice edits!
Are we enabling history on climate trace with this? (It doesn't have currently) Maybe I misunderstood, but I thought guha didn't want history on custom dc (owing to privacy questions).

ah ok, i wasn't sure. that was from my localhost. it's better to leave it out (and should work either way)

thanks for the reviews!