[Question] Difference between this project and azure-sdk-for-go (using its azidentity)

I was looking at go packages to handle EntraID Auth and was wondering the difference between this project and a project that the microsoft docs pointed out here? If anyone could provide some explanation that would be appreciated.

azidentity is the authentication library for the Azure SDK. It's useable in other contexts but it exists to support Azure SDK clients as used by developers who aren't Microsoft employees. MSAL (this project) is lower-level and more general purpose in that it isn't designed to integrate with any particular service client and is in principle open to supporting a broader range of scenarios. I believe the most significant feature difference today is that only azidentity supports managed identity authentication.

Both support the OBO flow, actually with the same implementation: azidentity's OnBehalfOfCredential wraps MSAL's confidential Client.

Alright thanks for explaining! I appreciate the answers.


Option for Contrapposto considered shoulder/body motion

What the feature is for:

Realize cute motion

As-is:

Shoulder roll motion moves same direction as head, with slight delay

To-be:

Shoulder roll motion moves opposite to head

Delay is TBD (no-delay might be better)
Whether yaw movement should be opposite or not is TBD

Note:

This feature must be optional and off by default, to respect  male avatars.
Setting should be in control panel, NOT in settings window.
UI label must be carefully considered, though main focus is female avatars.

Merged to develop branch in #734 -> will be released in next version.


Updated 01_Error_Handling.md

Corrected indentation in yaml part of docs

Current coverage is 70.23% (diff: 100%)

Merging #6128 into master will not change coverage

@@             master      #6128   diff @@
==========================================
  Files           416        416
  Lines         35711      35711
  Methods        4688       4688
  Messages          0          0
  Branches          0          0
==========================================
  Hits          25083      25083
  Misses        10628      10628
  Partials          0          0

Powered by Codecov. Last update 7663102...d830e5c


INSERT INTO casing not normalized

Describe the bug
For some statements, casing is not corrected. I have an example with INSERT INTO, but maybe it's others too.
To Reproduce
Formatting this produces no changes:
insert INTO foo (bar) VAluES (123);

Expected behavior
Casing should be normalized to what https://docs.sqlfmt.com/style says.
Actual behavior
Bad casing left as is.
Additional context
What is the output of sqlfmt --version?
sqlfmt, version 0.18.0

Also:
$ echo "insert INTO foo (bar) VAluES (123);" | sqlfmt - --check
1 file passed formatting check.

See https://github.com/tconbeer/sqlfmt/issues/262
PRs welcome


Migrating to Metal?

What about to migrate CoreML to Metal?
It is said that raw Metal code has much better performance than Core ML

Hi.
The coreml and the metal are completely different.
It is difficult to reuse the weight of Tensorflow.


Bump OSL 1.35 RC

Bump RC version for OSL 1.35

https://github.com/parodos-dev/orchestrator-helm-operator/pull/376/files#diff-08e2a84120b174eff25c9924a7e41c292eba38cc7cd1269547811f4eb1455d8b will be deleted on OSL 1.35 release (#377 )

I had to fix the CRD; some fields were missing cc @jenniferubah
I kept source and sourceName for the rhdhOperator but I would remove sourceName and only keep source for consitency


Add observable

Codecov Report

Merging #34 (a7b51a8) into main (d8b3a1d) will increase coverage by 0.06%.
The diff coverage is 55.65%.

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   58.07%   58.13%   +0.06%
==========================================
  Files          90       91       +1
  Lines        5987     5960      -27
==========================================
- Hits         3477     3465      -12
+ Misses       2510     2495      -15

Impacted Files
Coverage Δ

src/processors/real_time_plot.jl
50.48% <50.48%> (ø)

src/processors/finalize.jl
100.00% <100.00%> (ø)

src/processors/initialize.jl
100.00% <100.00%> (+41.07%)
:arrow_up:

src/processors/process.jl
100.00% <100.00%> (+25.97%)
:arrow_up:

src/processors/processors.jl
100.00% <100.00%> (ø)

src/solvers/solve_animate.jl
77.77% <100.00%> (+1.30%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


$templateCache not being hit

I'm using the following code to test my directive (with external template):
app.directive('test-element',function(){
    return {
        templateUrl: '/statics/template.html'
        restrict: 'E'
    }
});

//test
var $compile,scope;
beforeEach(function(){
    module('app');
    inject(function(_$compile_,_$rootScope_,$templateCache){
        $compile = _$compile_;
        scope = _$rootScope.$new();
        $templateCache.put("/statics/template.html","
test
");
    }));

it ('works',function(){
    var element = $compile('<test-element></test-element>')(scope)
    scope.$digest();
    console.log(element);
    pending();
}

The element is not being compiled, and shown as <test-element class='ng-scope'></test-element>.
I've put a console.log on angular's templateCache source code, and it seems that the put is run properly but get is never used.
Can anyone point me to a correct direction? Thanks!

it turned out to be a custom httpInterceptor that screwed this up.


Need to control chromedriver chrome language, but chrome_options can't be passed along

Hello,
Try to use chrome instead of firefox as it is faster and because firefox stop working recently for apparently selenium/splinter/firefox update missmatch of some kind...
I have ubuntu with french locales and chrome seems to be installed with french as a default language... My tests need to be executed in us-en chrome instance to succeed. Even if I set default language to us_en in chrome preferences the instance lauched by browser('chrome') don't seems to use the default profile preferences but the chrome built one or something.
So, I try many way to pass language specification to chrome instance without succes.

    from splinter.driver.webdriver.chrome.Options import Options
    import splinter
    options = splinter.driver.webdriver.chrome.Options()
    options.add_argument('--lang=en-us')
    browser = Browser('chrome', chrome_options=options)

Inspire by some answer from this SO question : http://sqa.stackexchange.com/questions/9904/how-to-set-browser-locale-with-chromedriver-python
Not working...

    from selenium.webdriver import Chrome
    from selenium.webdriver.chrome.options import Options
    from splinter.driver.webdriver import BaseWebDriver, WebDriverElement

    options = Options()
    options.add_argument('--lang=en-us')
    global browser
    browser = BaseWebDriver()
    browser.driver = Chrome(chrome_options=options)

This other option failed with the following error :

  do_login_if_need(username, base64.b64decode(password))

controllers/test_analysis.py:180:
controllers/test_analysis.py:90: in do_login_if_need
if browser.is_element_present_by_css('div.login_box'):
/usr/local/lib/python2.7/dist-packages/splinter/driver/webdriver/init.py:251: in is_element_present_by_css
return self.is_element_present(self.find_by_css, css_selector, wait_time)
/usr/local/lib/python2.7/dist-packages/splinter/driver/webdriver/init.py:237: in is_element_present
if finder(selector):
/usr/local/lib/python2.7/dist-packages/splinter/driver/webdriver/init.py:387: in find_by_css
original_query=css_selector)
self = <splinter.driver.webdriver.BaseWebDriver object at 0x7fd3bc2b8d90>
finder = <bound method WebDriver.find_elements_by_css_selector of <selenium.webdriver.chrome.webdriver.WebDriver (session="e32ee751b41d469e5138fac42c7d25e4")>>, selector = 'div.login_box', original_find = 'css'
original_query = 'div.login_box'
def find_by(self, finder, selector, original_find=None, original_query=None):
    elements = None
    end_time = time.time() + self.wait_time

    func_name = getattr(getattr(finder, _meth_func), _func_name)
    find_by = original_find or func_name[func_name.rfind('_by_') + 4:]
    query = original_query or selector

    while time.time() < end_time:
        try:
            elements = finder(selector)
            if not isinstance(elements, list):
                elements = [elements]
        except NoSuchElementException:
            pass

        if elements:
            return ElementList(

              [self.element_class(element, self) for element in elements],
                find_by=find_by, query=query)

E               AttributeError: 'BaseWebDriver' object has no attribute 'element_class'

/usr/local/lib/python2.7/dist-packages/splinter/driver/webdriver/init.py:380: AttributeError
I am not sure if It is me that don't follow proper API fo BaseWebDriver or if the issue is somewhere else...
I think issues #326 and #382 are relate to mine...
Thanks

Changing system settings for english usa allow me to work around test extecution... But I would greatly prefer be able to specify language of chrome instance.
Thanks

try with latest master, should now work

Can you tell how chrome options should be passed? Neither of both way I detailed above work...
I am not sure that sudo python setup.py install had override or not version install by pip though...
Thanks

I don't believe it's currently possible to do this from the command line arguments. The "--lang=" flag only changes the language file loaded and not the Accept-Language header passed by the browser.
See the following links:

http://peter.sh/experiments/chromium-command-line-switches/#lang
https://cs.chromium.org/chromium/src/ui/base/ui_base_switches.cc?q=kLang&sq=package:chromium&type=cs&l=51
http://stackoverflow.com/a/24992503

Still struggle to search a solution for this... Best ressources so far : http://stackoverflow.com/questions/11289597/webdriver-how-to-specify-preferred-languages-for-chrome
I am trying to use the proposed workaround in the last comment to the accepted answer where c089 propose this gist : https://gist.github.com/c089/a5cbb834f9b54004de9b
The example is in java, will try to make it work in python and report back here...

Hi @BuhtigithuB,
A bit late, but just in case you still need it, I found that options.add_experimental_option("prefs", {"intl.accept_languages": "fr-FR"}) works.
Karl

Hi,
Now options.add_option("prefs", {"intl.accept_languages": "fr-FR"}) can used
Thanks

Hi, still running from germany to query english questions on google . com returns answers in german, not in english as expected...
options are
chrome_options = Options()
chrome_options.add_argument("--window-size=1024x768")
chrome_options.add_argument("--headless")
chrome_options.add_argument("--lang=en-us")
chrome_options.add_experimental_option('prefs', {'intl.accept_languages': 'en-US'})
driver = webdriver.Chrome(chrome_options=chrome_options)

In Ruby, I used it this way if that can help anyone
  BROWSER_LANGUAGE = 'el' # could be en-US, fr-FR, etc.
  options = Selenium::WebDriver::Chrome::Options.new
  options.add_option('prefs', 'intl.accept_languages': BROWSER_LANGUAGE)

  Capybara::Selenium::Driver.new(
    app,
    browser: :chrome,
    desired_capabilities: capabilities,
    http_client: client,
    options: options
  )


error when one step interpolation is selected

The model gives following error when one step interpolation (no extrapolation support) is selected in exfield.tbl.
forrtl: severe (193): Run-Time Check Failure. The variable 'mod_esmf_cpl_mp_cpl_computerh_$RH2EXIST' is being used without being defined
Image              PC                Routine            Line        Source
libirc.so          00002B0C7A175A1E  Unknown               Unknown  Unknown
libirc.so          00002B0C7A1744B6  Unknown               Unknown  Unknown
regesm.x<PHONE_NUMBER>38B9F2  Unknown               Unknown  Unknown
regesm.x<PHONE_NUMBER>325BCB  Unknown               Unknown  Unknown
regesm.x<PHONE_NUMBER>49F817  mod_esmf_cpl_mp_c         549  mod_esmf_cpl.F90

It is fixed by adding rh2Exist = .false. to one step interpolation section.


issue/213 - Add ability to complete a task

Added checkboxes for tasks on the list view and calendar tooltip
Allows users to complete tasks
Their state is persisted in the backend
This also integrates the update task endpoint with the frontend
Please give feedback on the colours and components used, I'm not good at UI/UX.

closes #213

[x] The pull request is complete according to the following criteria:

[x] Acceptance criteria have been met
[x] The documentation is kept up-to-date
[ ] Comprehensive tests (if applicable) have been generated and all pass.
[x] The pull request describes the changes that have been made, and enough information is present in the description for any developer to understand what has changed
[ ] Commits have been squashed (or will be on merge).
[x] The branch name is descriptive and follows the pull request title format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
[x] The pull request title is of the following format : {issue/bug...}/(Issue Number) - Name of issue. E.g bug/30-Fix-Project
[x] The description uses github syntax to link to the issue. E,g Resolves se701g2/Doto#{Number}
[x] At least two reviewers assigned. One of which must be the assigner of the issue.
[ ] If there are merge conflicts, run git rebase as opposed to git merge with master.

@all-contributors please add @HarrisonLeach1  for code, review, design, tests


Overlaps wrapping logo text on mobile

Hello,
I noticed that when the logo text wraps on mobile, it overlaps.

The overlap is also visible in the header

Thanks a lot! Just merged your PR and will release a new theme version later 😊


fix windows master build

https://jenkins.dockerproject.com/job/Docker Master (windows)/894/console

Hi!
If you are reporting a new issue, PLEASE make sure that does not have any duplicates already open.
We would like to take this time to remind you of the information we need to debug the problem you are seeing. This is an automated response so if this ticket is not about a bug, do not fret.
If you fail to provide this information within 7 days, we will close this because we cannot debug your issue. We can reopen whenever the information is provided.
Thank you.
Please see:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues
Description of problem:

`docker version`:

`docker info`:

`uname -a`:

Environment details (AWS, VirtualBox, physical, etc.):

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual Results:

Expected Results:

Additional info:

#ENEEDMOREINFO


Multiple deprecation warnings from doctrine/persistence

Hello @jakzal , checking a project to update it to symfony 5 I get many warnings from this project, not an impediment for the upgrade but I wanted to let you know.
  1x: The Doctrine\Common\Persistence\ObjectManager class is deprecated since doctrine/persistence 1.3 and will be removed in 2.0. Use \Doctrine\Persistence\ObjectManager instead.
    1x in ServiceInjectorListener::startTest from Zalas\Injector\PHPUnit\TestListener

  1x: The Doctrine\Common\PropertyChangedListener class is deprecated since doctrine/persistence 1.3 and will be removed in 2.0. Use \Doctrine\Persistence\PropertyChangedListener instead.
    1x in ServiceInjectorListener::startTest from Zalas\Injector\PHPUnit\TestListener

  1x: The Doctrine\Common\Persistence\Mapping\Driver\FileDriver class is deprecated since doctrine/persistence 1.3 and will be removed in 2.0. Use \Doctrine\Persistence\Mapping\Driver\FileDriver instead.
    1x in ServiceInjectorListener::startTest from Zalas\Injector\PHPUnit\TestListener

  1x: The Doctrine\Common\Persistence\Mapping\Driver\MappingDriverChain class is deprecated since doctrine/persistence 1.3 and will be removed in 2.0. Use \Doctrine\Persistence\Mapping\Driver\MappingDriverChain instead.
    1x in ServiceInjectorListener::startTest from Zalas\Injector\PHPUnit\TestListener

  1x: The Doctrine\Common\Persistence\Mapping\Driver\SymfonyFileLocator class is deprecated since doctrine/persistence 1.3 and will be removed in 2.0. Use \Doctrine\Persistence\Mapping\Driver\SymfonyFileLocator instead.
    1x in ServiceInjectorListener::startTest from Zalas\Injector\PHPUnit\TestListener

  1x: The Doctrine\Common\Persistence\ObjectRepository class is deprecated since doctrine/persistence 1.3 and will be removed in 2.0. Use \Doctrine\Persistence\ObjectRepository instead.
    1x in ServiceInjectorListener::startTest from Zalas\Injector\PHPUnit\TestListener

  1x: The Doctrine\Common\Persistence\Mapping\AbstractClassMetadataFactory class is deprecated since doctrine/persistence 1.3 and will be removed in 2.0. Use \Doctrine\Persistence\Mapping\AbstractClassMetadataFactory instead.
    1x in ServiceInjectorListener::startTest from Zalas\Injector\PHPUnit\TestListener

  1x: The Doctrine\Common\Persistence\Mapping\RuntimeReflectionService class is deprecated since doctrine/persistence 1.3 and will be removed in 2.0. Use \Doctrine\Persistence\Mapping\RuntimeReflectionService instead.
    1x in ServiceInjectorListener::startTest from Zalas\Injector\PHPUnit\TestListener

@hugochinchilla thanks!


Fix french wording

Update French YPImagePickerLocalizable.strings.
Line 12:

"authorizer" to "authoriser"

@alefaure eagle eye! 👌 🇫🇷 🥖


MINOR. Fix scala 2.11 compilation error

The fix was cherry-picked from trunk where scala version is 2.12. So it
failed in 2.4. Couple of fixes:

Either doesn't have toOption method, so used match directly
SAM can't be used, fixed that to mention interface

Compilation with -PscalaVersion=2.11 passes.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

ok to test

Scala 2.11 build has one test failure:

org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication

which is not related to this change (which only touches a unit test)


fix(README): change overseer references to jellyseer

Description
Screenshot (if UI-related)
To-Dos

[x] Successful build yarn build
[x] Translation keys yarn i18n:extract
[x] Database migration (if required)

Issues Fixed or Closed

Fixes #XXXX

Jellyseerr is a fork from Overseerr. There is no point in deleting every reference from the original project.


Email subject line starts with “?utf-8?Q?”

Sending email using CI the subject line starts with “?utf-8?Q?”. The subject line is not over 75 characters
The following post suggestions don't solve the problem:
http://codeigniter.com/forums/viewthread/154493/
http://stackoverflow.com/questions/8350865/malformed-email-subject-header-when-subject-75-chars-using-codeigniter-email-l
I  copied the email class into my application/libraries and then made the edits suggested here:
http://codeigniter.com/forums/viewthread/119946/
Works correctly now…

This code are working properly  you need to change "system/libraries/Email.php"
public function subject($subject)
{
/$subject = $this->_prep_q_encoding($subject);
$this->_set_header('Subject', $subject);
return $this;/
$subject = '=?UTF-8?B?'.base64_encode($subject).'?=';
$this->_set_header('Subject', $subject);
return $this;
}

Was facing same issue , the solution suggested here solved the problem.
https://forum.codeigniter.com/archive/index.php?thread-54634.html


reportGeneralTypeIssues in pytorch

 Environment data

Language Server version: 2023.5.20
OS and version: linux x64
Python version (and distribution if applicable, e.g. Anaconda): 3.8.16 (miniconda)
python.analysis.indexing: true
python.analysis.typeCheckingMode: basic

 Code Snippet

Install pytorch: torch==2.0.1+cu117
import torch
torch.backends.cudnn.benchmark = False  # reportGeneralTypeIssues

Additional Context
In torch/__init__.py there's a line:
import torch.backends.cudnn

 Expected behavior
No error.
 Actual behavior
"backends" is not a known member of module "torch" Pylance(reportGeneralTypeIssues)

The torch library is a "py.typed" library, which means that it provides inlined type annotations. It also means that it follows certain rules about specifying which imported symbols it intends to re-export from its various modules. If you're interested, you can read about these rules here.
The top-level torch module doesn't re-export the backends submodule. It's worth noting that it does re-export several dozen other submodules including fft, futures, etc. So it appears that it was an explicit decision by the pytorch maintainers not to re-export backends. That means you need to import it explicitly in your code if you want to access it.
import torch.backends

@erictraut Thanks very much for the explanation! I'll ask the pytorch community.
By the way, I'm curious if it's possible to re-export only torch.backends.cudnn in the top-level of torch without torch.backends. Could you please explain a little more?

I'm curious if it's possible to re-export only torch.backends.cudnn in the top-level of torch

It's possible to export the torch.backends.cudnn module and then re-export it as cudnn from the top-level module. Is that what you have in mind? To do so, the top-level module could use the statement from torch.backends import cudnn as cudnn or import torch.backends.cudnn as cudnn. Then your user code could simply import torch and use torch.cudnn to access that submodule.
It's also possible for the top-level module to import and re-export the backends submodule (from torch import backends as backends), and then the backends submodule could import and re-export the cudnn submodule from its namespace (from . import cudnn as cudnn). If done this way, your user code could import torch and then use torch.backends.cudnn to access that submodule.
It all depends on how the torch maintainers want to define the library's public interface.

The first changes the interface, and I'm afraid they would not adopt it.
So is the second approach the only one to expose torch.backends.cudnn as is to users?

Or you can import the submodule explicitly in your code: import torch.backends.cudnn. That's the only option that will work with the library as it is currently authored.

Thanks!

The torch library is a "py.typed" library, which means that it provides inlined type annotations. It also means that it follows certain rules about specifying which imported symbols it intends to re-export from its various modules. If you're interested, you can read about these rules here.
The top-level torch module doesn't re-export the backends submodule. It's worth noting that it does re-export several dozen other submodules including fft, futures, etc.

@erictraut is there any runtime check one can use to check if something is re-exported or not from pyright PoV?  I.e. both fft and backends are module members of torch, per:
% python -c "import inspect; import torch;print('backends' in sorted(x[0] for x in inspect.getmembers(torch, inspect.ismodule)))"
True

is there any runtime check one can use...?

Not that I can think of. You could perhaps walk the AST for the parent module to look for nodes that use redundant import forms. That would work for some cases, but it wouldn't account for cases where a type stub is present.
Out of curiosity, why do you want to verify this at runtime? Are you a library maintainer and want to validate this in a test? Or are you a library consumer?

Not that I can think of. You could perhaps walk the AST for the parent module to look for nodes that use redundant import forms. That would work for some cases, but it wouldn't account for cases where a type stub is present.

Is there a PEP describing why it's proper to expose it one way vs the another?

Out of curiosity, why do you want to verify this at runtime?

Because anything that is not covered by CI has a high probability of regressing again.

Are you a library maintainer and want to validate this in a test? Or are you a library consumer?

Former.

I've addressed the issue that caused the hang when running pyright --verifytypes torch. This fix will be included in version 1.1.310 of pyright.


[#567] feat: add a shuffle-server metric about read_used_buffer_size

What changes were proposed in this pull request?
add a shuffle-server metric about read_used_buffer_size
Why are the changes needed?
Show more server's info for users.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Don't need.

Codecov Report

Merging #568 (29322c5) into master (0779946) will increase coverage by 0.83%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##             master     #568      +/-   ##
============================================
+ Coverage     60.86%   61.69%   +0.83%
+ Complexity     1795     1664     -131
============================================
  Files           213      200      -13
  Lines         12375    11103    -1272
  Branches       1049      927     -122
============================================
- Hits           7532     6850     -682
+ Misses         4435     3876     -559
+ Partials        408      377      -31

Impacted Files
Coverage Δ

...he/uniffle/server/buffer/ShuffleBufferManager.java
83.09% <0.00%> (-0.89%)
:arrow_down:

...rg/apache/uniffle/server/ShuffleServerMetrics.java
97.34% <100.00%> (+0.02%)
:arrow_up:

...g/apache/hadoop/mapred/SortWriteBufferManager.java

...mapreduce/task/reduce/RssInMemoryRemoteMerger.java

...preduce/task/reduce/RssRemoteMergeManagerImpl.java

...pache/hadoop/mapreduce/task/reduce/RssShuffle.java

...pache/hadoop/mapreduce/task/reduce/RssFetcher.java

...apache/hadoop/mapreduce/v2/app/RssMRAppMaster.java

...n/java/org/apache/hadoop/mapreduce/MRIdHelper.java

.../hadoop/mapreduce/task/reduce/RssBypassWriter.java

... and 6 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


HTML-proofer currently failing on all PRs due to 16S tutorial

had to make it a proper page to fix the new-style boxes, but now its also being proofed for broken links, but it fails on all the citations because the references aren't renedered in the content.md file

ok, just ignore it for now: https://github.com/galaxyproject/training-material/pull/3749


[MM-12970] Update webapp unit-testing and move into a separate page

Update webapp unit-testing and move into a separate page.
Page screenshots:

Merging


Prepare for adapters

This PR is focused on the:

A noticeable difference to ExecutionContexts is that Adapter is no longer responsible for the Element search logic, which requires an action to find the element before passing it to adapter.

of the https://github.com/san650/ember-cli-page-object/issues/479.
Also in this PR we drop findElementWithAssert code as not needed anymore.

Coverage decreased (-1.8%) to 96.625% when pulling 8e20854371c00bd30cb873fa0c79605a1c73871f on ro0gr:prepare-for-adapters into 0c209b48670833abc6fbbf08223b69f64e19b53d on san650:v2-beta.

close in favour of #509


Replace line-parsing RegEx by manual code

Replace line-parsing RegEx by manual code
This avoids pulling in regex and lazy_static and makes this a true
zero-dependency crate.

Thanks for the quick review :-)
BTW, is there some kind of official spec for all of this? Allowing whitespace around the = would be a change to the regex that was there before. Also I think I made a mistake around export. I’m not sure if it is a reserved keyword or it can just as well be a var itself, like in export="some value"?
It will take some time for me to revise, this was just a quick experiment to see how far I come :-)

There is no official spec for this. It's based off of https://github.com/bkeepers/dotenv but there is no official spec. We currently implement only a subset of the parsing capabilities of the original ruby gem.

I completely rewrote this with something resembling a "real" parser… And updated the tests to verify the new behavior (whitespace around =, treating export as key itself).

some flakiness with cargo-junit

No, it was a real failure… I added a comment why those two ifs you suggested to merge need to be separate…

Oh right, I see the logic issue now. I do need to fix the pipeline though to error out better though it seems.


Module reported as unused when it contains main

Describe the bug
I have a module named snapshot-runner/SnapshotRunner.elm located in a Lamdera project. The following error is reported
-- ELM-REVIEW ERROR -------------------- snapshot-runner\SnapshotRunner.elm:1:13

NoUnused.Modules: Module `SnapshotRunner` is never used.

1| port module SnapshotRunner exposing (main)
               ^^^^^^^^^^^^^^

This module is never used. You may want to remove it to keep your project clean,
and maybe detect some unused code in your project.

I found 1 error in 1 file.

Expected behavior
I'm expecting no error since this module contains a main function.
main : Program Json.Decode.Value Model Msg
main = ...

Additional context
Since this is a Lamdera app, the issue might be that NoUnused.Modules is only making an exception for app instead of main even though app is only relevant in Frontend.elm and Backend.elm (correct me if I'm wrong on this @supermario).

Awesome, thanks @jfmengels ! 🎉

Seconded! This means I can now remove an ignored module from one of my projects 😃


Parallel build enabled for unix build scripts.

PR closed by Hazelcast automation as no activity (>3 months). Please reopen with comments, if necessary. Thank you for using Hazelcast and your valuable contributions

Linux test FAILed.

Linux test FAILed.

Linux test PASSed.

Windows test PASSed.

Windows test FAILed.

Windows test PASSed.

Linux test PASSed.

Windows test PASSed.

Can one of the admins verify this patch?


Example being behind main is fine

resolves #

Problem

Solution

Checklist

[ ] I have read the contributing guide and understand what's expected of me
[ ] I have run this code in development and it appears to resolve the stated issue
[ ] This PR includes tests, or tests are not required/relevant for this PR
[ ] This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
[ ] This PR includes type annotations for new and modified functions

This PR is behind main by 1 commit, as it is missing 7df747ae04a8c99dbd745085f42cd4647ec71d80. However it is also ahead. The Artifact Changes Check still passes, whereas before it would fail.

Closing as this was just an example of the updated Check Artifact Changes


[Feature]: dir time for Webpack Loader Analysis

What problem does this feature solve?
It will be great if I can easily visualize how much time every dir take to parse for example (babel-loader)
so let's see the following dir have 10 files it will be great to have sum of all the time for the containing files represented in the parent dir

Never mind I found the overview when I click on the dir name.


browser monitoring injection logic hardening

These changes introduce hardening to the logic that determines whether or not to inject the browser agent script tag.
In particular, the following 2 issues have been addressed:

If either #traced_call or #should_instrument? encounter any exceptions, these exceptions should be handled and logged without impacting the observed web application.
Allow a response headers hash to use symbols for values.

Closes #2462

NOTE to @kaylareopelle and @hannahramadan: I was worried about introducing performance overhead while supporting hash values as symbols. After some benchmarking, the solution I came up with is to use #match? which is defined on both Symbol and String. The switch to using #match? should actually introduce a small performance boost to all existing users, while also adding support for hash-values-as-symbols users.
Here is the benchmarking code in question:
require 'benchmark'

SYMBOLS = { :'an/example' => :'a/value',
            :'another-example' => :'another-value',
            :content_type => :'text/html',
            :traceparent => :'00-da8bc8cc6d062849b0efcf3c169afb5a-7d3efb1b173fecfa-01',
            :tracestate =><EMAIL_ADDRESS>}

STRINGS = SYMBOLS.each_with_object({}) { |(k,v), h| h[k.to_s] = v.to_s }
TEXT_HTML = 'text/html'
TEXT_HTML_PATTERN = %r{text/html}.freeze
TIMES = 1_000_000

puts 'Finding a speedy way to test symbol text inclusion...'

Benchmark.bm do |x|
  x.report 'baseline' do
    TIMES.times do
      # use STRINGS twice, as SYMBOLS will error out
      STRINGS.each { |k, v| STRINGS[k].include?(TEXT_HTML) }
      STRINGS.each { |k, v| STRINGS[k].include?(TEXT_HTML) }
    end
  end

  x.report '#to_s' do
    TIMES.times do
      SYMBOLS.each { |k, v| SYMBOLS[k].to_s.include?(TEXT_HTML) }
      STRINGS.each { |k, v| STRINGS[k].to_s.include?(TEXT_HTML) }
    end
  end

  x.report '#match? with pattern' do
    TIMES.times do
      SYMBOLS.each { |k, v| SYMBOLS[k].match?(TEXT_HTML_PATTERN) }
      STRINGS.each { |k, v| STRINGS[k].match?(TEXT_HTML_PATTERN) }
    end
  end

  x.report '#match? with string' do
    TIMES.times do
      SYMBOLS.each { |k, v| SYMBOLS[k].match?(TEXT_HTML) }
      STRINGS.each { |k, v| STRINGS[k].match?(TEXT_HTML) }
    end
  end
end

I really like these updates, @fallwith. Especially with the performance boost!
I think we might want a changelog entry for this. What do you think?

Sounds good. Let me figure out what's going on with these unit tests that aren't happy with the new rescue blocks and then I'll circle back with an entry that matches whatever the code that passes the tests ends up looking like.

I really like these updates, @fallwith. Especially with the performance boost!
I think we might want a changelog entry for this. What do you think?

Sounds good. Let me figure out what's going on with these unit tests that aren't happy with the new rescue blocks and then I'll circle back with an entry that matches whatever the code that passes the tests ends up looking like.

Ah ok. I was rescuing too far up the chain. We want legitimate issues to be surfaced and not rescued. With the latest commit we're still rescuing all headers parsing and other determinations of whether the browser agent should be inserted. The tests should pass now and a changelog entry has been added.


Add Prettier

I added:

Prettier
Lint staged (run prettier only in staged files)
Husky (pre commit hooks)
Also formatted the whole codebase with the current prettier configuration

Let me know what do you think

Travis tests have failed
Hey @alejandronanez,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
Node.js: 8

     npm test

><EMAIL_ADDRESS>test /home/travis/build/bluzi/travis-buddy
> mocha

15:40:56.323Z  INFO unknown : Max attempts to get done is: 10
15:40:56.634Z  WARN unknown : Database logging is: OFF

  api
    POST /
15:40:56.964Z  INFO unknown : Received payload (and successfuly extracted data)
15:40:56.965Z  INFO unknown : Handling request for 'create sdfdsfsd' by 'Eliran Pe'er'
15:40:57.741Z  INFO unknown : Comment created successfuly: https://github.com/bluzi/name-db/pull/501#issuecomment-377701875
15:40:57.742Z  INFO unknown : Finished
      ✓ should return HTTP status 200 and ok message (1096ms)
    GET /status
      ✓ should be running and return HTTP status 200

  site
    GET /
      ✓ should return HTML and status 200
    GET /getting-started
      ✓ should return HTML and status 200
    GET /contact-us
      ✓ should return HTML and status 200
    GET /dashboard
      ✓ should return HTML and status 200

  6 passing (1s)

     npm run lint

29:20  error  Missing trailing comma  comma-dangle
  38:13  error  Missing trailing comma  comma-dangle
  42:13  error  Missing trailing comma  comma-dangle
  49:22  error  Missing trailing comma  comma-dangle
  59:20  error  Missing trailing comma  comma-dangle
  68:13  error  Missing trailing comma  comma-dangle
  72:13  error  Missing trailing comma  comma-dangle
  78:22  error  Missing trailing comma  comma-dangle

/home/travis/build/bluzi/travis-buddy/utils/pullrequest.js
   9:38  error  Missing trailing comma  comma-dangle
  15:19  error  Missing trailing comma  comma-dangle
  35:29  error  Missing trailing comma  comma-dangle
  44:34  error  Missing trailing comma  comma-dangle
  70:24  error  Missing trailing comma  comma-dangle
  76:27  error  Missing trailing comma  comma-dangle
  90:7   error  Missing trailing comma  comma-dangle
  97:32  error  Missing trailing comma  comma-dangle

/home/travis/build/bluzi/travis-buddy/utils/utils.js
   14:34  error  Missing trailing comma                                                               comma-dangle
   27:13  error  Missing trailing comma !     /home/travis/.npm/_logs/2018-03-31T15_40_59_921Z-debug.log

Hey @alejandronanez,
Your changes looks good to me!

Hey @bluzi!
Any suggestions about fixing the codeclimate issue as it does not belong to the work done in this PR.

Please ignore codeclimate at this point, it's complaining about a known technical debt we already know of. Not sure why it complains about it in your PR though. Anyway, just ignore it.


feat(kubernetes): Handle empty --kubeconfig_file

Context
When running Prowler in Kubernetes, --kubeconfig-file is needed.
Description
Sets the --kubeconfig-file to its default route if it's not set
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Good idea @pedrooot , but for in-cluster executions, the kubeconfig file is not needed.


Dev

Using CMAKE_BUILD_TYPE=Release makes -Werror flag enabled. This fix removes warn_unused_result warnings.
0 is returned, the same as if the file has not been opened

Can you squash these two changesets into a single one?


HIVE-27269: Create multiple MatchTracker when using VectorFastHashMapContainer

What changes were proposed in this pull request?

This patch changes VectorMapJoinFastHashMapContainer to create multiple MatchTracker, each of which tracks distinct HashMap in the HashMapContainer.
In addition, it fixes fixed size array allocation problem in 3 classes and adjusts the number of partitioned HashTable when it is not a power of 2.
Why are the changes needed?

Current VectorMapJoinFastHashMapContainers have 1 MatchTracker and multiple HashMaps. MatchTracker tracks MATCHED entries by marking the index of HashTable entry in a bitset. Since multiple HashMaps use the same MatchTracker, if one of the HashTables marks the index as MATCHED, then the other HashMap's entry on the same index is also treated as MATCHED regardless of actual join result. This leads to missing non-matched join results of FullOuterJoin.
Does this PR introduce any user-facing change?

No
Is the change a dependency upgrade?

No
How was this patch tested?

I added unit tests for Long, String, and MultiKey VectorizedFastHashMapContainer. Also, I ran TPC-DS query97 on 100GB dataset for verifying the patch.

@ayushtkn , I added a qfile which reproduces the issue using long and string key. Could you please review this PR again? Thank you.

@ngsg, isn't it the same for VectorFastHashSetContainer?

@deniskuzZ , if my memory serves me correctly, this problem happens when Hive uses MatchTracker. Only FullOuterJoin uses MatchTracker, and FOJ always uses HashMap. So I think this issue is irrelevant to HashSet and HashMultiSet. I'll check it again and leave you a comment if there is something wrong.

@deniskuzZ , I fixed numHTTLoadhreads adjustment code and removed assertions from the patch. Also I have checked that HashSet/HashMultiSet containers do not have this issue. Could you please review the changes?

@deniskuzZ , I fixed numHTTLoadhreads adjustment code and removed assertions from the patch. Also I have checked that HashSet/HashMultiSet containers do not have this issue. Could you please review the changes?

Could you please explain why that issue is not applicable to HashSet/HashMultiSet containers?
Based on the description in a PR I would assume that all classes introduced in HIVE-25583: Support parallel load for HastTables are affected.
Current VectorMapJoinFastHashMapContainers have 1 MatchTracker and multiple HashMaps. MatchTracker tracks MATCHED entries by marking the index of HashTable entry in a bitset. Since multiple HashMaps use the same MatchTracker, if one of the HashTables marks the index as MATCHED, then the other HashMap's entry on the same index is also treated as MATCHED regardless of actual join result.````

As I mentioned above, MatchTracker is used only by FOJ, and FOJ does not use HashSet/HashMultiSet container.
In current implementation, VectorMapJoinOperator sets MatchTracker by VectorMapJoinOuterGenerateResultOperator.fullOuterHashTableSetup(), which is called only by VMJFullOuter{Long/String/MultiKey}Operator. According to the Vectorizer.specializeMapJoinOperator(), these operators are chosen when joinType is JoinDesc.FULL_OUTER_JOIN and they always use HashTableKind.HASH_MAP. Therefore, this issue does not happen when using HashSet/HashMultiSet.
--- The remaining part explains about current fast VectorMapJoinHashTable implementation in order to help understanding the patch.
HIVE-25583 introduces parallel HT loading by creating multiple HashTables and putting them into a single HashTableContainer. (e.g. VectorMapJoinFastLongHashMapContainer has an array of VectorMapJoinFastLongHashMap.) The number of HashTables in a container is equal to the number of HT-loading threads, and a HashTable for the given KV pair(or Key in case of HashSet/HashMultiSet) is determined by the following formula: (Hash of key) & (# of HT threads - 1).
e.g.
key hash = 0 -> use HT #0
key hash = 7, numHTThreads = 2 -> use HT #1
key hash = 7, numHTThreads = 4 -> use HT #3

Every HashTable has a long array which represents entries of HashTable. HashTable inserts a KV pair in 3 steps:

write KV pair on somewhere, usually a buffer
compute a long value that refer to the position of the written KV pair.
find an empty HashTable entry and save the long value
The last step is done by quadratic hash probing starting from the following index: (Hash of key) & (length of the array).

e.g.
Insert key hash = 0 -> use HT #0, use slot #0
Insert key hash = 0 -> use HT #0, use slot #1 (slot #0 is already filled)
Insert key hash = 0 -> use HT #0, use slot #3 (slot #0, #1 are already filled)

MatchTracker tracks the slot index. MapJoinOperator may have a MatchTracker, and if it has one, it passes MatchTracker to HashTable when performing lookup. If HashTable finds matched element, then it records the slot index of matched element to MatchTracker.
e.g.
HashTable entries: {5, 0, 0, 6} where 0 represents an empty entry.
Lookup 1 -> MatchTracker: no slots matched
Lookup 5 -> MatchTracker: slot #0 matched
Lookup 6 -> MatchTracker: slot #0, #3 matched

Current implementation uses a single MatchTracker for all HashTables, which makes false-negative errors when listing non-matched elements.
e.g.
HT #0: {1, 5, 0, 0}, HT #1: {0, 2, 0, 0}, 0 represents an empty entry
Lookup 1 -> MatchTracker: slot #0 matched
Lookup 2 -> MatchTracker: slot #0, #1 matched
HT #0, non-matched entries according to the above MatchTracker: empty <- wrong result, should be slot #1

slot #0 matched

As I mentioned above, MatchTracker is used only by FOJ, and FOJ does not use HashSet/HashMultiSet container.
In current implementation, VectorMapJoinOperator sets MatchTracker by VectorMapJoinOuterGenerateResultOperator.fullOuterHashTableSetup(), which is called only by VMJFullOuter{Long/String/MultiKey}Operator. According to the Vectorizer.specializeMapJoinOperator(), these operators are chosen when joinType is JoinDesc.FULL_OUTER_JOIN and they always use HashTableKind.HASH_MAP. Therefore, this issue does not happen when using HashSet/HashMultiSet.
--- The remaining part explains about current fast VectorMapJoinHashTable implementation in order to help understanding the patch.
HIVE-25583 introduces parallel HT loading by creating multiple HashTables and putting them into a single HashTableContainer. (e.g. VectorMapJoinFastLongHashMapContainer has an array of VectorMapJoinFastLongHashMap.) The number of HashTables in a container is equal to the number of HT-loading threads, and a HashTable for the given KV pair(or Key in case of HashSet/HashMultiSet) is determined by the following formula: (Hash of key) & (# of HT threads - 1).
e.g.
key hash = 0 -> use HT #0
key hash = 7, numHTThreads = 2 -> use HT #1
key hash = 7, numHTThreads = 4 -> use HT #3

Every HashTable has a long array which represents entries of HashTable. HashTable inserts a KV pair in 3 steps:

write KV pair on somewhere, usually a buffer
compute a long value that refer to the position of the written KV pair.
find an empty HashTable entry and save the long value
The last step is done by quadratic hash probing starting from the following index: (Hash of key) & (length of the array).

e.g.
Insert key hash = 0 -> use HT #0, use slot #0
Insert key hash = 0 -> use HT #0, use slot #1 (slot #0 is already filled)
Insert key hash = 0 -> use HT #0, use slot #3 (slot #0, #1 are already filled)

MatchTracker tracks the slot index. MapJoinOperator may have a MatchTracker, and if it has one, it passes MatchTracker to HashTable when performing lookup. If HashTable finds matched element, then it records the slot index of matched element to MatchTracker.
e.g.
HashTable entries: {5, 0, 0, 6} where 0 represents an empty entry.
Lookup 1 -> MatchTracker: no slots matched
Lookup 5 -> MatchTracker: slot #0 matched
Lookup 6 -> MatchTracker: slot #0, #3 matched

Current implementation uses a single MatchTracker for all HashTables, which makes false-negative errors when listing non-matched elements.
e.g.
HT #0: {1, 5, 0, 0}, HT #1: {0, 2, 0, 0}, 0 represents an empty entry
Lookup 1 -> MatchTracker: slot #0 matched
Lookup 2 -> MatchTracker: slot #0, #1 matched
HT #0, non-matched entries according to the above MatchTracker: empty <- wrong result, should be slot #1

@ngsg, thanks again for the detailed explanation! I understand the problem, I was just worried that we'll get exactly the same issues with HashSet/HashMultiSet maybe not with FOJ, but somewhere else. Anyhow, I'll merge this PR once we get a green build.


yesod persistent-odbc mysql

For those who need to run a yesod webapplication on a windows with MySQL, it would be a great help if you guys included among the templates a yesod-mysql-odbc, please.

Sounds good to me. I opened an issue on the stack-templates repo.
https://github.com/commercialhaskell/stack-templates/issues/35


feat(documents): Allow to retrieve a document by its ID

Issue being fixed or feature implemented
Add shorthand method to retrieve documents by their $id
Example:
    const document = await client.platform.documents.getById(
      'PaymentRequest.PaymentIntent',
      'DD9yD2G63GPdwcQi987tmiCeL3YybGDmXLkQr1jBLPhm'
    );

closes #102
supersedes #103

Seems good to me! What do you think @shumkov @Alex-Werner ?

#103  had a brief discussion if it's worthwhile to rename the methods to e.g. fetch and fetchById to clearly communicate the data is retrieved remotely rather than locally ..
there is also a brief convo on discord on it https://discord.com/channels/670271785974890526/670540408593448980/732938013356851251
of course it can always be changed later

@dashameter Yeah, I guess we can do that later. Regarding getByID, I would accept an array of IDs. Any thoughts?

accepting a string for one ID and array for multiple IDs feels intuitive, or a wrapper function getById wrapping getByIds

I would keep just one method.


Installer v0.3.6 error

version: 0.3.6
env:
os: win32
arch: x64
PATH: C:\Program Files\AdoptOpenJDK\jdk-<IP_ADDRESS>-hotspot\bin;C:\Program Files\Java\jdk-14.0.2;C:\Program Files\Java\jdk-14.0.1\bin;C:\Users\sharm\AppData\Local\Microsoft\WindowsApps;C:\Program Files\Java\jdk-14.0.1\bin;
JAVA_HOME: C:\Program Files\Java\jdk-14.0.1

log:
[5:30:49 AM] arch:x64
[5:31:20 AM] Download Visual Studio Code ... [Completed]
[5:31:20 AM] Install Visual Studio Code
[5:31:35 AM] Install Visual Studio Code ... [Completed]
[5:31:35 AM] Configure Java Settings
[5:31:35 AM] Error occurred
[5:31:35 AM] Error:  Please check if you have access to Windows Registry.

Please attach %TEMP%\vscode-java-installer\log.txt and %TEMP%\AdoptOpenJDK-MSI.log for more details.

In the last step, it searches Windows Registry for the location of installed vscode. But never mind,  you can open VS Code, install Java Extension Pack, and it should be all set. Let me know if it doesn't work.
BTW, your PATH env is not in a good state.


Pam's Harvestcraft Trees generating in strange biomes

Pam's Trees are spawning in biomes they shouldn't be tagged in (Papaya, mango, durian in the snowy taiga).
Disabling trees during world gen using datapack until able to resolve.

Was not able to launch server on GCP with Pam's Trees and/or Serene Seasons.
Removed from modpack, as well as datapack disabling trees until able to diagnose.


[oc_erchef] move authz sql statements to pgsql_statements.config

For consistency with chef_sql, move the statements previously
in oc_chef_authz_db.erl  to oc_chef_authz/priv/pgsql_statements.config
A further step here will be to consolidate both sql files, once we move
oc_chef_authz object modules into chef_objects.
ping @chef/lob

:+1:


GIDSignInButton in Swift doesn't work

Welcome to FirebaseUI and thanks for submitting an issue!
Please take a look at open issues, as well as resolved issues, to see if your issue is either already being addressed, or has been solved by someone else.
If your issue concerns the CocoaPods error, "...transitive dependencies that include static binaries", please take a look at any of the following issues and see if your problem is solved: #48, #47, #46, #34, #23.
If not, please feel free to fill in the following info so we can help faster!
Step 1: Are you in the right place?

For issues or feature requests related to the code in this repository file a GitHub issue.
For general technical questions, post a question on StackOverflow tagged appropriately.
For general Firebase discussion, use the firebase-talk google group
For help troubleshooting your application that does not fall under one of the above categories, reach out to the personalized Firebase support channel

Step 2: Describe your environment

Objective C or Swift: Swift
iOS version: 11.0
Firebase SDK version: 4.13.0
GoogleSignIn (4.2.0)

Step 3: Describe the problem:
I am following these instructions and I have added a GIDSignInButton. For some reason pressing it does nothing. I expect it to launch a view where I log into gmail. Do I need the gmail app on the phone as well? I'm running in a simulator. I've followed all the other steps and have done the necessary updates to my UIViewController where login logic occurs.
Steps to reproduce:

Setup AppDelegate, and the Login ViewController.
Add a UIView and set up the class.
Run the simulator and press the G-SignIn button.

Observed Results:

What happened?  This could be a description, log output, etc.
The button doesn't do anything.

Expected Results:

What did you expect to happen?
Pressing the gmail button should allow me to authenticate with gmail.

Relevant Code:

    override func viewDidLoad() {
        super.viewDidLoad()

        self.hideKeyboard()
        self.emailOrUsernameTextField.delegate = self
        self.passwordTextField.delegate = self
        self.spinner = setupSpinner(view: self.view, inverted: true)

        // Enable the Google Sign In Button
        GIDSignIn.sharedInstance().uiDelegate = self
        GIDSignIn.sharedInstance().signIn()
    }

func sign(_ signIn: GIDSignIn!, didSignInFor user: GIDGoogleUser!, withError error: Error?) {
  // ...
  if let error = error {
    // ...
    return
  }

  guard let authentication = user.authentication else { return }
  let credential = GoogleAuthProvider.credential(withIDToken: authentication.idToken,
                                                    accessToken: authentication.accessToken)
  // Authentication logic
}

Does pressing the button cause your app to crash?

Can you share your code or a reproducible example?


Crypto support

Hi!
I have been messing around w/ the esp and would like to add a hal impl for the hardware hmac signing / DS on the esp32 c3 (and more). I assume that would happen in esp-idf-svc, but I'm opening this issue to make sure I'm targeting the right place.
As a side note, really enjoying working w/ this ecosystem! :tada:

I think you should rather do this in esp-idf-hal, as the hardware HMAC / DS is a "device" (and as a matter of fact, EspWifi and EspEth* should also be moved to esp-idf-hal as they also rely on hardware devices (the modem in the case of EspWifi and the SPI/EMAC controllers in the case of EspEth, but it is a gray area for those as they are mixing the ethernet layer with the IP layer in a single trait)).
Also, esp-idf-hal/esp-idf-svc is all about wrapping ESP-IDF drivers & APIs, so you probably need to wrap this and this API in your impl. If you are looking to implement a bare-metal driver, it probably belongs to the esp-hal crate, not to esp-idf-hal.
What I would suggest is to first of all make sure that the above ESP-IDF APIs are exposed by esp-idf-sys. If they are not, you need to contribute a PR to esp-idf-sys which includes the relevant ESP-IDF headers here.
Once you have the unsafe bindings to the HMAC/DS ESP-IDF APIs in esp-idf-sys, you can write your own code that calls these APIs to e.g. sign with the HMAC key. If this works, the next step indeed is to indeed write a typesafe "driver" in esp-idf-hal that actually wraps the unsafe ESP-IDF driver exposed in esp-idf-sys in the previous step.
PRs greatly appreciated!

I appreciate your direction. Will see if I can woth a solution together for simple upstream hmac, though I don't have an ETA until I explore further.
Cheers


Improve string parsing

Currently we implement string parsing for height/time from the absolute module but not the relative module.
Improve the macros used to implement string parsing and use the new versions to implement string parsing for the height and time types in relative.
Done while reviewing data structures in relation to serde.

Looks good to me. I think there is no behavior change here, but it's much more obvious that Height Time and relative::LockTime are all being parsed in the same way.

I think there is no behavior change here

This adds functionality to the relative height/time types. No change for the absolute types. Somehow we totally missed doing FromStr for relative height/time types. I noticed while trying to serde roundtrip by way of strings.

Rebase only, includes fixes to newly introduced calls to the parsing macro in weight and fee_rate.

Looks like someone kicked CI for me on all my open PRs, I'm guessing that was you @apoelstra, thanks man!

Heh, nope, I actually had no idea that CI was fixed (I guess a new nightly dropped).

Maybe Github has some auto detection for this? I'm sure the new nightly fixed it.

Pretty impressive if so. I could understand this for network issues or things that are Github's own fault, which would have pretty identifiable fingerprints (and be easy to determine "when they're fixed"). But an ICE on a specific Rust compiler is pretty obscure and annoying to distinguish.
Maybe if they have some deep learning thing watching for lots of repos having the same issue and being fixed at the same time they could do it.

Sorry for being late with review, I got somehow confused into thinking I already did.


Android embedding v2

This migrates the Android side of the plugin to the new Embedding V2 API.

The V2 APIs make lifecycle a lot more explicit to plugins, thus should allow for improve code structure and predictable memory usage
There may have been a memory leak observed due to missing cleanup methods in the previous implementation (I've been testing with "leakcanary" and "Don't Keep Activities" both set to on
The plugin will now lazily initialize the audio manager and most of the RTC classes on the first method call invocation (important when in a multi-engine environment, e.g. when a App utilizes firebase_messaging & flutter-webrtc)
Small refactors and decouplings have been done

Functionality has been tested locally on a few phones, but I'll appreciate if others can test as well.
Note: My Android Studio installation probably formats the code different than other contributors. Could the project agree on a standard set of rules? Most of the official flutter code uses google-java-format (a plugin in Android Studio) with the Google rules. Maybe this project could use it, too.

@ened Thank you for your contribution, I will test your modification and merge it without error.

@ened Just now I did some tests. When I lowered the Android SDK API level to 21 or below, GetUserMedia could not get the camera stream. Does it seem that the SDK migration process caused a bug? The loopback example also doesn't work.
But I use a higher API level, for example, 29, it works fine.

I had some some tests successfully on older Android versions but not extensively.
Can you please share the steps you took exactly and I will try to reproduce them here. Have about 7 different phones to test with, starting on Android 6.
What do you mean "lowered the Android SDK API level to 21"? It means you just ran a test on older phones, right? No code change was involved, right?
Regarding the bug itself, I am 100% sure; it should not have been caused by this, but will test.

I used AVD Manager to create an emulator and selected Android 5.0 (Google APIs) x86_64 bit API 21 image. It seems that I cannot complete the GetUserMedia action, but the master
Version can pop up a permission request confirmation dialog, I guess the permission request process is not performed correctly.
~$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 1.19.0-6.0.pre.57, on Mac OS X 10.15.5 19F101, locale zh-Hans-CN)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Xcode - develop for iOS and macOS (Xcode 11.2.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 4.0)
[✓] VS Code (version 1.46.0)
[✓] Connected device (4 available)

• No issues found!

@cloudwebrtc ok - I was able to reproduce the problem on a 5.1 device.
Will try to rework the permission handling a bit more and check the loopback example.

Out of interest, what sort of devices are you supporting this old?
On Sat, 13 Jun 2020, 10:02 Sebastian Roth<EMAIL_ADDRESS>wrote:

@cloudwebrtc https://github.com/cloudwebrtc ok - I was able to
reproduce the problem on a 5.1 device.
Will try to rework the permission handling a bit more and check the
loopback example.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudwebrtc/flutter-webrtc/pull/274#issuecomment-643594683,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABG66E7GMWKRTJHIHEAOQDRWM6C5ANCNFSM4NXGDR3Q
.

@cloudwebrtc can you please share the android studio editor settings this project is using

@ghenry Samsung J3 comes to mind. Because WebRTC also supports audio-only or data channel operation, it’s not completely out of the equation, yet.

@cloudwebrtc have tested again & hopefully fixed the bug rgd. the permissions on pre-M devices.
Successfully tested the example App on these phones:
samsung - crownltexx - SMN960F - 10 (API 29)
samsung - j3xnltexx - SMJ320FN - 511 (API 22)
samsung - kltexx - SMG900F - 601 (API 23)
Sony - F8132 - F8132 - 800 (API 26)
Sony - G3311 - G3311 - 70 (API 24)

This PR now also bumped the webrtc dependency.

@ened I tested API 21 and can capture the camera, I will merge it now.

@cloudwebrtc can you please share the android studio editor settings this project is using

I usually use VSCode to directly edit the code, and Android Studio will be started unless necessary for native debugging, so I use the default settings. xD

@cloudwebrtc thx for merging & understood rgd your process.
If you don’t mind I’d reformat using the flutter recommendation (Google-Java-format), and adjust readme and CI scripts. That should make future PRs a bit easier to read, as typically everyone has a different configuration.

@ened No problem, we can use standard formats like google clang-format to format the code.


Unable to set Corale.Colore.Core.Color in Unity Inspector

Hey, I recently learned about Colore with my new keyboard and decided to take it for a spin in Unity! However I seem to have run into a problem in which I am unable to set the color unless I hard code it in as it will not appear in the inspector otherwise, I've included my code bellow any help is greatly appreciated!
(Using Unity 5.5.0f3)
using System.Collections;
using System.Collections.Generic;
using UnityEngine;
//corale
using Corale.Colore.Core;
using Corale.Colore.Razer.Keyboard;
using ColoreColor = Corale.Colore.Core.Color;

public class ColoreTest : MonoBehaviour {

    public LayerMask mask; //appears (just an example that isn't a float or string which I know unity UI can handle
    public ColoreColor color; //doesn't appear

    //appears in unity under functions that can be called via OnClick(), doesn't do anything obviously as color isn't set
    public void SetAll_A() {
        //color = ColoreColor.Red; //uncommenting this line will have it work
        Chroma.Instance.SetAll(color);
    }

    //doesn't appear in unity under functions that can be called via on click
    public void SetAll_B(ColoreColor inputColor) {
        Chroma.Instance.SetAll(inputColor);
    }
}

Colore isn't supported in the inspector.
It would be better to use Unity's color and convert it to Colore.

Thank you very much for a response I was assuming that was the case but I just wanted to make sure I wasn't doing something stupid haha.


Add initial code

[x] add initial code
[ ] correct packages
[ ] correct connector name
[x] create assets junits
[x] create process junits
[x] create schematype junits
[x] create schemaAttributes junits
[x] update asset junitsjunit
[x] update process junits
[x] update schematype junits
[x] update schemaAttributes junits
[x] delete schematype junits
[x] delete schemaAttributes
[ ] check audit log and error log content
[ ] readme / docs
[ ] test create EventType, assets and attributes  are catalogued and confirm lineage is as expected
[ ] test update EventType,  assets and attributes are correctly cataloged and confirm lineage is as expected
[ ] test delete EventType  and attributes are not cataloged after the delete
[ ] test update dataflow to change SQL
[ ] create postman collection

There's a few 'TODO:' items in the project which relate to updating artifact names etc - they may be helpful

Raised issue https://github.com/odpi/egeria/issues/7122 to be able to get existing Dataflow relationships associated with a process. We need this to work out which dataflows and assets need to be deleted.

Raised issue https://github.com/odpi/egeria/issues/7134  to allow EventTypeListts to be added to Egeria lineage context. This would allow this connector to catalog multiple EventTypes under an asset

All addressed - still waiting for datatype update issue #7147 to be merged,


Figure out why GitHub thinks you have a lot of "LLVM" code

Useful links

https://github.com/github/linguist
https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-repository-languages
https://stackoverflow.com/questions/40659265/using-gitattributes-for-linguist-examples
https://github.com/SymbiFlow/symbiflow-arch-defs/blob/master/.gitattributes

Hmmmm. Not sure what "LLVM" code is.   Any idea?
Our stuff is 95% python...

@nelsobe Linguist is probably misdetecting some file -- see the above links.


Blockchain wallet schema

Depends on #689
In this first implementation, the private key for the wallet can be encrypted and stored in the DB with the encryption key being stored in an environment variable. The security around the storage of the encryption key will be added in another issue.
The schema will at least need the following fields:

uuid
id
type: hot / cold
encrypted_private_key
public_key
address
primary
timestamps

A set of rules should also be available for this. Like balance shouldn't go above xxx, with a few options like notifying or transferring to a cold wallet.

@T-Dnzt What's the purpose of primary field?

The primary: true wallet identifies the unique hot wallet used by default to receive funds from the blockchain.

For reference, #806 PR was closed because it should be much simpler to add. Just need to add blockchain addresses and transaction ids to existing tables.


Migartion Commit

PR Description 📜
Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # <your_issue_number>

Mark the task you have completed ✅

[X] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[X] I have performed a self-review of my own code or work.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] My changes generates no new warnings.
[X] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[X] I have added screenshot for website preview in assets/images
[X] I have added entries for my game in main README.md
[X] I have added README.md in my folder
[X] I have added working video of the game in README.md (optional)
[X] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Thank you soo much for contributing to our repository 💗

Thank you @MohnishK7 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit is the pull request correct?
can you please check it .

Hey @MohnishK7 👋!
@kunjgit here,
We have this annoucement to make 📢!!
During the time of PR don't alter main index file ! 🙂
In main Readme file just use * as a game number during the time we are merging we will add number !! 👀
Make sure you join our Discord🕹 if you haven't 😇
Thank you 💗!

@Arun9739 Ya here is the screenshot of a full web view.

@MohnishK7 Update your game's entry in main README file as per guidelines.

@Arun9739 already updated

@MohnishK7 Don't give the direct number in main README. Just give a '*' in place of number, we will add the number. Also resolve branch conflicts.

@Arun9739 sir, the above conflict was not present before.  #427 did the same thing as mine and got the successful merge. I have made the first issue regarding the doodle jump and as per the guidelines of gssoc . Could you look into this matter?
Thank you

my pull request is first #321 and how come #427 pull request got merge first ?
how will i resolve this conflict?

@MohnishK7 Create separate branches for separate PR. Also only one PR for one issue. If you're facing conflict issue, please create new pr.

Hey @MohnishK7 !! we already have this game on GameZone !!
if you want you can do enhancement we can't have exact same again !!

Thank you  @MohnishK7 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


⚠ Processors has degraded performance

In 1671be1, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 43 ms

Resolved: Processors performance has improved in 7c4aaae.


add python 3.6 to travis

Does not work this way: https://travis-ci.org/jezdez/envdir/jobs/279112021
Please also look into the other failures then.

Will do

superseded by #67


Closes #869 - Feature/enhanced mdinput

Fix bug with MdInput component not saving state (Issue #869)

Start to add additional features from Issue #1010 (see issue for gif of feature in action

[x] min-height 100px / max-height 500px
[x] Autosize to fit content
[x] Disables autosize after user resize event
[x] Saves all state when switching back and forth to preview mode

[x] size
[x] scroll location
[x] focus and selected text
[x] preserve undo old text (ctrl+z)

Other changes

Also changed textarea padding from 1rem (16px) to 0.5rem (8px) - I believe it looks better
Moved styles into module scss file

I added jest-dom and refactored out the entire suite to use the newer api (screen / userEvent)


TestAgent unit test flaking

https://prow.istio.io/view/gs/istio-prow/pr-logs/pull/istio_istio/29918/unit-tests_istio/1347272616779452416
TestAgent failed when the only changes were to a galley/istioctl analyzer.
istio-agent: TestAgent 52s
istio-agent: TestAgent/VMs_provisioned_certificates_-_short_lived 10s
    agent_test.go:243: retry.UntilSuccessOrFail: timeout while waiting (last error: file is unchanged)

I am surprised, I ran this overnight in a loop before merging without failures :slightly_frowning_face:

I am surprised, I ran this overnight in a loop before merging without failures :slightly_frowning_face:

looks like the test node is so busy signing a single CSR takes 2.5s...

looks like the test node is so busy signing a single CSR takes 2.5s...


JRTB-3: Implemented Command pattern for handling Telegram Bot commands

PR Details
Implemented Command pattern for handling Telegram Bot commands.
And Tests added, too.

-[x] Docs change / refactoring / dependency upgrade
-[ ] Bug fix (non-breaking change which fixes an issue)
-[x] New feature (non-breaking change which adds functionally)
-[ ] Breaking change (fix or feature that would cause existing functionality to change)

added in #17 pull-request


A code to print housie tickets in c

A simple code that will generate unique housie tickets every time.

Hello Sir, Can you assign this issue to me?

A simple code that will generate unique housie tickets every time.

Hello Sir, Can you assign this issue to me?

A simple code that will generate unique housie tickets every time.

Hello Sir, Can you assign this issue to me?

Assigned the issue @Bitan-Kundu

Hello i raised this issue, pls assign it to me

@VedantKCSE

Hello sir, Can you assign this issue to me? Now I am free.

@Bitan-Kundu can PR directly


LSP vs EFM

I did not see discussions enabled so I thought I would just open an issue. So what I am not grasping is what is the difference between this plugin and EFM? Should you use both? I have 2 of them and when I hit save I see the following message. So it seems like they are competing against each other. It might be I am just not grasping what both of these do?

You should read the README, as it states that discussions are to take place on the discourse. I also answered you questions on a discord channel, but for others, EFM and jsonls are alternative language servers that can both operate on json (EFM operates on a bunch of different  filetypes by wrapping linters/formatters)

Yes @mjlbach I forgot to come close this after you answered. Sorry


Array filtering

Hi! I have an array like this:
{
"robots": [
{
"name": "R2D2",
"id": "19385789238"
"home": "California"
},
{
"name": "R2D2",
"id": "339949623"
"home": "Ohio"
},
{
"name": "Robby",
"id": "242324654"
...
},
{
"name": "WALL-E",
"id": "c3c3c3c3c3c3"
...
}
]
}
i am using this adaptive expression:  select(where(robots, r, r.name == 'R2D2'), n, n.id), to get the id by passing in the name, but if i want to filter on "home" aswell, lets say i want the id of R2D2 with the home California?

The Microsoft Bot Framework team prefers that how to questions be submitted on Stack Overflow. The official Bot Framework Github repos are the preferred platform for submitting bug fixes and feature requests.

Use and().
select(where(robots, r, and(r.name == 'R2D2', r.home == 'California')), n, n.id)


Update centralized-deployment-of-add-ins.md

@nenonix @JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

Suggested changes have been made. Thank you for reviewing!


Confusing blocks-pruning description

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

Description of bug

Default is to keep all finalized blocks. otherwise, all blocks can be kept (i.e 'archive'), or for all canonical blocks (i.e 'archive-canonical'), or for the last N blocks (i.e a number).
NOTE: only finalized blocks are subject for removal!

If only the finalized blocks are subject to removal, and all finalized blocks are canonical (maybe I'm wrong here?), what is the difference between parameter default (all finalized blocks) and archive-canonical ?
Steps to reproduce
No response

Hi,

all finalized blocks are canonical (maybe I'm wrong here?)

The consensus engine may not revert a finalized block,
while the canonical block (theoretically) can be reverted.
Therefore, a finalized block also implies that the block is canonical
(but not necessarily the other way around).

what is the difference between parameter default (all finalized blocks) and archive-canonical ?

The default option is BlocksPruning::KeepFinalized (see appendix section) which
is equivalent to the archive-canonical CLI flag.
The BlocksPruning::KeepAll is equivalent to the archive CLI flag.
The archive-canonical option implies that ONLY the finalized blocks are kept around
and displaced branches (blocks from forks) are eventually pruned (ie removed).
[block 0] -- [block 1 ] -- [block 2 ] -- [block 3]
         |
          -- [block 1'] -- [block 2']

In this example, when block 3 is finalized, the displaced branch (the fork containing 1' and 2')
is pruned (presuming the node is started with archive-canonical).

NOTE: only finalized blocks are subject for removal!

I'm not quite sure if this is right. I supposed that was true at some point and
we should update the documentation for this.
// CC @arkpar @cheme @bkchr
As opposed to archive option that implies that ALL the blocks are kept around in the DB.
Appendix
The BlocksPruning that you mention is defined in the client/db code:
https://github.com/paritytech/substrate/blob/54b7395a532df9b2fc79916b9f830d7300f0e216/client/db/src/lib.rs#L322-L331
The CLI exposes this option to end-users here:
https://github.com/paritytech/substrate/blob/54b7395a532df9b2fc79916b9f830d7300f0e216/client/cli/src/params/pruning_params.rs#L33-L42
While the user input flag is parsed here:
https://github.com/paritytech/substrate/blob/54b7395a532df9b2fc79916b9f830d7300f0e216/client/cli/src/params/pruning_params.rs#L66-L76
Then, here is where the pruning actually happens:
https://github.com/paritytech/substrate/blob/54b7395a532df9b2fc79916b9f830d7300f0e216/client/db/src/lib.rs#L1738-L1750

Thank you for the clear explanation. I think the confusion came from the "NOTE: only finalized blocks are subject for removal!" which as you are suggesting might not be true anymore.

As I understand it, the note is here to underline that the pruning (when a pruning range is defined) is done against finalized the blocks in db, with range applying over the latest finalized block number.
But it should maybe say "within the finalized block number range" or something similar.
But when using range pruning only canonical blocks are stored in state so it is not fundamentally false (only in archive mode we do prune forks in state).


Update log4j version

We currently ship log4j version 2.12.1 in the java agent
https://github.com/elastic/apm-agent-java/blob/2e40422635e573bf83da84c67a325d2bf629a91a/pom.xml#L111
The version at the time of writing is 2.14.1. We should consider updating it to silence some security findings from vulnerability scanners.

2.12.1 is the last version compiled with Java 7, so we cannot upgrade to a later version without dropping support for Java 7.
However, since we are not using the vulnerable appender (the SMTP appender), we made sure we don't package this appender though #1878, so that our users can feel safe to ignore related vulnerability reports.
I hope this safety measure is sufficient. Please close this issue if it is.
Thanks!


Remove comments unrelated to plugin example app

Fixes https://github.com/flutter/flutter/issues/10472


support of adding value to tabs in roles added

sorry, I didnt saw the guideline for contributing in this repository initially. I was in need of these changes for some project, so made them and making a pull request if it can be of any help.

@anikgoel thanks for your PR. The DocuSignObjects have been refactored in #75; can you check if your PR is still valid/needed, and rebase it if it is the case ?


Slow checkboxes

Toggling a checkbox works very slow for me in a particular case:
I have a document with ~150 checkbox summaries, each of them has 5-10 subitems. When I toggle checkbox in a subitem, recalculation of all summaries is done. I suppose it's enough to recalculate only affected ones.
I've made a fix for this problem: https://github.com/Sinamore/orgextended/tree/slow-checkboxes
Please, have a look at it, and tell if it's good enough to make it as a PR.

Sure
Make a PR for it and I will pull it and test it out.
Thanks for hacking on that.


Config option classes from isort (and constants and variables probably)

The order in isort is CONSTANTS, Classes, functions, which is detected by the case of the letters, but sometimes classes are in all-caps, like SVC from sklearn or SELU from pytorch.
In order to sort them correctly, I can specify classes:
[tool.isort]
classes = ["SVC", "SELU"]

and then isort treats them like classes even though they're in constant-case.

Thanks. Not too hard to support, but I have to get to some other things first! Would be a good first contribution if anyone is interested :)

I think this should have been closed by #1849.

Not sure if we want to implement constants and variables options as well?

I think we should, for consistency.


WIP: fVDB CI setup

@danrbailey, I implemented the updates since the last attempt (merge master->feature/fvdb and feature/fvdb->fvdb_ci_setup) but I'm still triggering all the other tests.  I manually cancelled them.  Perhaps it is the changes I make here to .github/workflows?

@danrbailey, I implemented the updates since the last attempt (merge master->feature/fvdb and feature/fvdb->fvdb_ci_setup) but I'm still triggering all the other tests. I manually cancelled them. Perhaps it is the changes I make here to .github/workflows?

I wondered that too, I can't seem to find any reference docs on this to confirm this. Either way, I think now that you've merged your changes to these .github/workflow files to master, I don't think you need to modify either of these yaml files? From the diff, it looks like you're adding the fvdb/** line when it already exists?

@danrbailey, I implemented the updates since the last attempt (merge master->feature/fvdb and feature/fvdb->fvdb_ci_setup) but I'm still triggering all the other tests. I manually cancelled them. Perhaps it is the changes I make here to .github/workflows?

I wondered that too, I can't seem to find any reference docs on this to confirm this. Either way, I think now that you've merged your changes to these .github/workflow files to master, I don't think you need to modify either of these yaml files? From the diff, it looks like you're adding the fvdb/** line when it already exists?

Oh yes, that is a mistake... a slight mismatch in the changes I was making.  I'll make sure to fix that up.


Once I enabled CGO_ENABLED, I get this error. Is it some kind of gcc issue?
$ env CGO_ENABLED=1 GOOS=linux GOARCH=386 go build -o anan !(*_test).go
runtime/cgo
In file included from _cgo_export.c:2:0:
/usr/include/stdlib.h:25:10: fatal error: bits/libc-header-start.h: No such file or directory
#include <bits/libc-header-start.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.


How to use caddy to reverse it

I want to use caddy as frontend to process web pages, can you show me how to config it? I've tried, but it comes error that "Invalid Host header"

I'm not super familiar with caddy, but you do need to rewrite the Host header for the express server to accept it.
From quick googling, it looks like you can do this:
reverse_proxy ... {
    Host {upstream_hostport}
    ...
}

reverse_proxy

Thank you for your reply, I've build website, but here are some error info I found, is that My database mysql is mysql8.0? Does it support mysql8.0?

You didn't submit any error info. MySQL 8 seems to be pretty old, my server is running 15, but I need your error info

I think you have an old version of the tables. This is more of a personal project, so I've neglected updating some things.
The stats_database.sql should be up to date now, it will recreate the tables tho (losing any data)

And yeah the play style and rating will not work, that is custom for my system.

I greatly appreciate for your work, it's fine that I'll rebuild my satabase, there is no data now except test data. I'm gonna try it.      : )


With Attribute fails to properly name method parameters when they collide with c# keywords

Describe the bug
If a property is named Default, the parameter is named default which is a reserved keyword in C#. It should be named @default.
To Reproduce
[With(MemberType = Property)]
public partial class MyClass
{
   public bool Default { get; set; }
}

Generates
public partial class MyClass
{
    public ImageDataModel WithDefault(bool default)
    {
        this.Default = default;
        return this;
    }
}

Expected behavior
public partial class MyClass
{
    public ImageDataModel WithDefault(bool @default)
    {
        this.Default = @default;
        return this;
    }
}

Environment info
.NET version:  8.0
Lombok.NET version: 2.4.0

Thank you for the issue, the fix is available in v2.4.1.


Request for contributions: proofreading docs for Keras 2

I've updated the docs for Keras 2. However I may be missing some leftovers from Keras 1, or typos, etc. If you can proofread the docs and send PRs to fix any mistakes, that would be really helpful.
Thanks!

FYI, Keras 2 is on master now. All further PRs should be sent to master.
Keras 2 will go live on PyPI tomorrow morning, alongside the new docs and a release blog post.
Thanks to all who contributed!

Docs are now fully updated. If you find anything missing, please open a PR.


Make object name empty by default

For static and some dynamic objects no name is nessesary

https://github.com/kudryashovda/createAmotion/pull/5/commits


Upgrade LinkTap to 0.2.3

Support for new device types and ioBroker dependency (admin) update

2.0.3 created 9.9.2023

just a feedback for next releases:
Added support for new devices sounds like new functionality. Thus increasing the minor version would have been correct.
The rules for versioning are:

increase major if Breaking changes are introduced. This may include new features and bugfixes.
increase minor if  a new feature was added without breaking things. This may include bugfixes.
increase patch if only a bug was fixed without adding new functionality.

@Smart-Gang
Your adapter https://github.com/Smart-Gang/ioBroker.linktap does not use standard iobroker testing.
Please see requirements https://github.com/ioBroker/ioBroker.repositories#requirements-for-adapter-to-get-added-to-the-latest-repository
Adapter needs to have at least Adapter basic testing (installing, running) using GitHub actions. More information in Forum from apollon77 (Just take from other adapters the samples)

You may copy the test-and-release.yml workflow from the example adaptzer or newly created adapter. If you need help, please let uas know.

I've created a PR to aid in updateing / adding standard tests.
Please merge and check that tests pass.
After merging and checking, please drop a comment to let us continue release management.
NOTE: If there is no reaction within 14 days I will close this PR.

Thanks for your work.
Github test feedback still shows a failure. This is not caused by the standard github tests - they are ok - but by appvayour integration:

If you do not use appveyor I suggest to remove it from your test configuration. I was told that this canbe achived by

open settings poage of github repository
go to webhooks
remove appveyor webhook

Of course its ok to fix the appveyor setup and to use it if you prefer. I'm sorry but I cannot aid with this testing environment. The goal should be to get a green checkmark as all tests pass.
mcm1957
P.S: appveyor issue is NOT blocking as I can check which tests fail manually - but it should be fixed in future to give you a quick feedback for durtehr work at the adapter. THANK YOU once again for your effort.

0.3.0 created 18.10.2023
manual adapter check OK
wait for minimum time at latest

Thanks for your work. Github test feedback still shows a failure. This is not caused by the standard github tests - they are ok - but by appvayour integration:

If you do not use appveyor I suggest to remove it from your test configuration. I was told that this canbe achived by

open settings poage of github repository
go to webhooks
remove appveyor webhook

Of course its ok to fix the appveyor setup and to use it if you prefer. I'm sorry but I cannot aid with this testing environment. The goal should be to get a green checkmark as all tests pass.
mcm1957
P.S: appveyor issue is NOT blocking as I can check which tests fail manually - but it should be fixed in future to give you a quick feedback for durtehr work at the adapter. THANK YOU once again for your effort.

Thanks for the info, I stopped using the appveyor and have now removed the webhook as well.
Now all tests should be green.
Thanks for the support.

0.3.0 created 18.10.2023


Getting type instantiation error

Describe the bug
Hi, I'm still getting used to the library and most likely am doing something wrong.
Still, I want to use internationalized strings as headers in some of my columns. The compiler throws TS2589 error: Type instantiation is excessively deep and possibly infinite, pointing to a place where i call my translation function, which return simple string, not a deep literal type.
Curiously, when I replace the call with a simple string, the error moves to accessor function for this column.
ColumnDef for this column looks something like this:
columnHelper.accessor((transaction) => DateTime.fromJSDate(transaction?.created_at).toUTC(), {
	cell: (props) => (
		<Text title={props.getValue().toRelativeCalendar() ?? ""}>
			{props.getValue().toLocaleString(DateTime.DATETIME_SHORT_WITH_SECONDS)}
		</Text>
	),
	id: "created_at",
	header: t("sections.main.transactions.items.created_at"),
}),

I'm sorry I can't provide reproducible example, because I feel the problem is really project-dependant. I'm creating this issue asking mostly for answers on how to tame inferrance in tanstack-table, so I can avoid similar problems
Your minimal, reproducible example
no link
Steps to reproduce

Define columns in a memo, providing a call to t function from react-18next as a header of a column.
Try to compile the app

Expected behavior
I expect the app to compile correctly
How often does this bug happen?
Sometimes
Screenshots or Videos
No response
Platform
Linux
react-table version
v8.3.3
TypeScript version
v4.4.2
Additional context
No response
Terms & Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

Please post the errors you are seeing
On Jul 26, 2022, 12:50 AM -0600, Ivan Bespalov @.***>, wrote:

Describe the bug
Hi, I'm still getting used to the library and most likely am doing something wrong.
Still, I want to use internationalized strings as headers in some of my columns. The compiler throws TS2589 error: Type instantiation is excessively deep and possibly infinite, pointing to a place where i call my translation function, which return simple string, not a deep literal type.
Curiously, when I replace the call with a simple string, the error moves to accessor function for this column.
ColumnDef for this column looks something like this:
columnHelper.accessor((transaction) => DateTime.fromJSDate(transaction?.created_at).toUTC(), {
cell: (props) => (
<Text title={props.getValue().toRelativeCalendar() ?? ""}>
{props.getValue().toLocaleString(DateTime.DATETIME_SHORT_WITH_SECONDS)}

),
id: "created_at",
header: t("sections.main.transactions.items.created_at"),
}),
I'm sorry I can't provide reproducible example, because I feel the problem is really project-dependant. I'm creating this issue asking mostly for answers on how to tame inferrance in tanstack-table, so I can avoid similar problems
Your minimal, reproducible example
no link
Steps to reproduce

Define columns in a memo, providing a call to t function from react-18next as a header of a column.
Try to compile the app

Expected behavior
I expect the app to compile correctly
How often does this bug happen?
Sometimes
Screenshots or Videos
No response
Platform
Linux
react-table version
v8.3.3
TypeScript version
v4.4.2
Additional context
No response
Terms & Code of Conduct
• I agree to follow this project's Code of Conduct
• I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

I'm facing this as well (I think):
TS2589: Type instantiation is excessively deep and possibly infinite.
It's on columnHelper.accessor

I’ll need something reproducible to debug :/

It may happen due to some project-specific stuff. Because I tried adding {incremental: false} to tsconfig and the error went away. Even after I reverted tsconfig back to it's original state 😕.

This has occurred for us, since 8.2.6.

We just shipped new column helper types and better underlying column def types. Please give them a try and report?

My project might face the same error. When I upgrade from 8.2.6 to 8.5.5. The typescript compiler got into the infinite compilation.

I think the error comes from in v8.3.0

Minimal repro: https://codesandbox.io/s/react-table-repro-s2b796?file=/src/index.ts
It indeed started happening on 8.3.0

I think the DeepKey is the reason
https://github.com/TanStack/table/pull/4185/files#diff-ecfb42689379fb8b0ebe6328e01b25aba4a31d2d076b723ff9fcaf502ac9d0f7R49

This error occurs again in v8.5.8

Example
import { ColumnDef, createColumnHelper } from '@tanstack/react-table'

type Room = {
  id: string
  activated_at: Date
  expires_at: Date
  userId: string
  join_code: string
  room: Room
}

const columnHelper = createColumnHelper<Room>()

const defaultColumns: ColumnDef<Room, any>[] = [
  columnHelper.accessor('id', {
    header: 'ID',
    cell: info => info.getValue()
  })
]

TS2589: Type instantiation is excessively deep and possibly infinite.

@tannerlinsley I get this error, Im on v8.5.11

I also get this error on v8.5.11.
I've tried using my own interface and the same interface in @Himself65 example above.

I think if you apply this patch, the issue will be fixed
https://github.com/TanStack/table/pull/4262

I'm still facing this issue in react-table:8.7.4

Also facing the same issue in react-table:8.7.4

Me too, facing the same issue in react-table:8.7.4

Facing this issue in react-table:8.7.6, wonder if they're going to fix it ...

I was surprised to see it happen in one of the projects only, but now I think it might be connected to typescript version: I had 4.1.6 fixed in project, bump to latest and error went away.
const columns = [ch.accessor("currency", {})];
^ When I checked (hovered over) this, with 4.1.6 I saw
accessor: <"currency", never>(accessor: "currency", column: IdentifiedColumnDef<TransportLineItem, never>) => ColumnDef<TransportLineItem, never>

and now with 4.9.5
(property) accessor: <"currency", string>(accessor: "currency", column: IdentifiedColumnDef<TransportLineItem, string>) => ColumnDef<TransportLineItem, string>

import { createColumnHelper } from '@tanstack/react-table';

interface Dog {
  name: string;
  owner: Owner;
}

interface Owner {
  name: string;
  dog: Dog;
}

const columnHelper = createColumnHelper<Dog>();

const columns = [
  columnHelper.accessor('name', { // ts(2589): Type instantiation is excessively deep and possibly infinite.
    header: 'Name',
  }
]

https://codesandbox.io/s/tanstack-table-issues-4224-u92zmn?file=/src/App.tsx
Is it possible to fix it?

do we have a solution for this error???

using     "@tanstack/react-table": "^8.7.9",

I have an issue where if I put a type like FileList, it will cause the the ts(2589) issue
With FileList

string only

Any updates?

any updates?

Just wanted to report I sorta naively thought I could add a complex object in to the column helper and it straight up breaks TS across my entire project when I do so.
For example, I had a table I wanted to display Stripe Charges on. So I tried to do const helper = createColumnHelper<Stripe.Charge>(). And this causes VS Code to infinitely display the loading... prompt when hovering over an element on any file afterwards!
For now I am just creating temporary DTOs with the props that I actually need

Also seeing this on 8.8.5 with the following (abbreviated) example. If I change ObjectId to be string, the ts error goes away so something to do with larger nested types maybe.
interface Patient {
    _id: ObjectId // from Mongoose
    ... other properties
}

const columnHelper = createColumnHelper<Patient>()
const columns = [
  columnHelper.accessor("name", {
    header: "Patient Info",
    cell: (info) => {info.getValue()},
  }),
]

Having the same issue with 8.9.1

any updates ?
I'm using the official example and getting this error just by adding a new prop 'actions' to the type which is a React.ReactNode,

@tannerlinsley @KevinVandy Please help

Please help :)

GG


[GOBBLIN-1354] Change homepage link in documentation for mkdocs build to pass on RTD

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1354

Description

[x] Here are some details about my PR, including screenshots (if applicable):
Changing to apache url didnt work last time, so changing to index.md

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
Not testable locally

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3194 (d9398c4) into master (1b31c90) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #3194   +/-   ##
========================================
  Coverage      9.10%   9.11%
- Complexity     1726    1728    +2
========================================
  Files          2017    2017
  Lines         77221   77221
  Branches       8568    8568
========================================
+ Hits           7033    7039    +6
+ Misses        69500   69496    -4
+ Partials        688     686    -2

Impacted Files
Coverage Δ
Complexity Δ

...main/java/org/apache/gobblin/util/HadoopUtils.java
30.59% <0.00%> (+0.65%)
25.00% <0.00%> (+1.00%)

.../org/apache/gobblin/cluster/GobblinTaskRunner.java
62.50% <0.00%> (+0.96%)
33.00% <0.00%> (+1.00%)

...lin/util/filesystem/FileSystemInstrumentation.java
92.85% <0.00%> (+7.14%)
3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b31c90...d9398c4. Read the comment docs.

Codecov Report

Merging #3194 (d9398c4) into master (1b31c90) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #3194   +/-   ##
========================================
  Coverage      9.10%   9.11%
- Complexity     1726    1728    +2
========================================
  Files          2017    2017
  Lines         77221   77221
  Branches       8568    8568
========================================
+ Hits           7033    7039    +6
+ Misses        69500   69496    -4
+ Partials        688     686    -2

Impacted Files
Coverage Δ
Complexity Δ

...main/java/org/apache/gobblin/util/HadoopUtils.java
30.59% <0.00%> (+0.65%)
25.00% <0.00%> (+1.00%)

.../org/apache/gobblin/cluster/GobblinTaskRunner.java
62.50% <0.00%> (+0.96%)
33.00% <0.00%> (+1.00%)

...lin/util/filesystem/FileSystemInstrumentation.java
92.85% <0.00%> (+7.14%)
3.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b31c90...d9398c4. Read the comment docs.


Enhancement: Introduce the ApplicationContext class.

Describe the enhancement
Introduce the application configuration class that allow the users to define the generalized and globalized values for the library.
Reading values:
var isAutomaticConversion = ApplicationContext.Get<bool>("WhateverKey");

if (isAutomaticConversion)
{
     ...
}

Setting values:
ApplicationContext.Set("WhateverKey", "WhateverValue");

Additional Context
In general, this class can be utilized in any means, regardless of scenarios/use-cases. As a recommendation, the usual properties used by the application must be held by this class. See the Constant class properties (i.e.: DefaultBatchOperationSize and DefaultCacheItemExpirationInMinutes) and/or the Converter class properties (i.e.: ConversionType and EnumDefaultDatabaseType).

Referencing #1087

I considered this initiative as invalid. The purpose of an ORM is to solve the hydration/push operations for the object/data via the proper mappings and not for giving a facility of defining the application behavior.

This is currently invalid and up for grabs at the same time.
Which is it please ?
And if it is up for grabs, I'll need more context as to what exactly is expected.

I think, this has been fixed by this already, in our last release.
Link: https://repodb.net/class/globalconfiguration

This has been marked invalid at the later stage due to its design as not aligned to the actual implementation.