Can't install update

I'm trying to update from 1.1.19 to 1.1.21 and it sits on installing update indefinitely and never installs.

Getting this error in HA log.
This error originated from a custom integration.
Logger: homeassistant.setup
Source: custom_components/bureau_of_meteorology/init.py:32
Integration: Bureau of Meteorology (documentation, issues)
First occurred: 6:28:02 PM (1 occurrences)
Last logged: 6:28:02 PM
Setup failed for custom integration bureau_of_meteorology: Unable to import component: No module named 'custom_components.bureau_of_meteorology.PyBoM.collector'
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 215, in _async_setup_component
component = integration.get_component()
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/loader.py", line 813, in get_component
ComponentProtocol, importlib.import_module(self.pkg_path)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/importlib/init.py", line 126, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1204, in _gcd_import
File "", line 1176, in _find_and_load
File "", line 1147, in _find_and_load_unlocked
File "", line 690, in _load_unlocked
File "", line 940, in exec_module
File "", line 241, in _call_with_frames_removed
File "/config/custom_components/bureau_of_meteorology/init.py", line 32, in
from .PyBoM.collector import Collector
ModuleNotFoundError: No module named 'custom_components.bureau_of_meteorology.PyBoM.collector'

Try manually updating. You have to update to fix this

Is it normal for it to say there is still an update available after manually updating?

No but it seems your HACS is broken

Any idea how I could fix it?

It couldn't update because HA couldn't contact the Github server.  Fixed it by disabling IPV6 in HA network settings.

I only have HA connected to IPv6 so it's not IPv6 itself causing an issue

I have v1.1.20 installed - and so I am getting the "deprecated" warning. When I try to update to v1.1.21, nothing changes.
I have deleted the integration in both Integrations and HACS and reinstalled - selecting v1.1.21, but it still just loads v1.1.20.
Also on on the HA warning about a deprecated attribute  (https://github.com/bremor/bureau_of_meteorology/issues/189)...  I also changed weather.py as per https://github.com/bremor/bureau_of_meteorology/pull/190 and that makes the error go away.

@Steve2017 not related to this issue. 1.1.20 is still the current release until either @bremor or I get time to check that the PR for 1.1.21 is in fact going to fix the issue properly. Closing this as the OP appears to have found a solution to his problem, which was related to HACS and not this integration.


Notify clients of SignData changes. Fixes #88.

This pull request fixes #88 by marking signs as dirty when new SignData is offered to them.

I tried applying a similar fix when working on the Stargate's plugin and markDirty wasn't solving the issue for me. I ended up having to call a method on net.minecraft.world.World that marked the block as needing to be updated.

World.markBlockForUpdate(BlockPos)

I'll close this and make a new one for the Value API if necessary.

@JBYoshi I've noticed the change required, as all DataProcessors have to be changed for the update, I'll make the mental note to ensure they keep this type of change as I progress with the implementation in #94. If possible, I'd appreciate any double checks and or contributions if you can follow the implementation and understand it, I'm available on IRC most of the time.


Print warning if no dev.ts file was found

With #10 the user does not necessarily know whether a project local or system global version of edcb is executed. Ideally, this should be indicated in the CLI output. One option would be injecting an additional flag.

Rather than indicating that dev.ts was executed, edcb should assume that this is the default. All projects should be locked to a particular edcb version.

An open question is whether --help and --version should always use the installed version. It should be clear when the repository version is displayed, rather than the local one.


:sparkles: handle pending policies

Summary
This pr handle pending policies in back-end and dashboards
Related issue(s)
https://issues.redhat.com/browse/ACM-10818
https://issues.redhat.com/browse/ACM-10817

/retest

/cc @clyang82 @yanmxa

/retest


"Could not locate .NET Core project. Assets were not generated."

Environment data
dotnet --info output:
dotnet --info
.NET Command Line Tools (1.0.1)

Product Information:
 Version:            1.0.1
 Commit SHA-1 hash:  005db40cd1

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.12
 OS Platform: Darwin
 RID:         osx.10.12-x64
 Base Path:   /usr/local/share/dotnet/sdk/1.0.1

VS Code version:
C# Extension version:
Version 1.12.0-insider (1.12.0-insider)
2017-04-25T06:53:33.728Z

C# 1.9.0
Steps to reproduce

have various .net core csproj and a main sln
one .net standard 1.6 project
cmd shift p > .net restore or .net build
sometimes .net restore only finds the .net standard project (depending the active tab i guess?)

Expected  behavior
.net restore acts the same as dotnet restore when ran in main folder (reads the sln)
Actual behavior
Could not locate .NET Core project. Assets were not generated.

@Jonathan34: C# for VS Code doesn't provide .net restore or .net build commands. It does provide a .NET: Restore Packages command, but that lets you pick the project you want to restore. Could you clarify what command your picking? Do you have other extensions installed that might be providing these commands?

Also, the "Could not locate .NET Core project. Assets were not generated." is produced by C# for VS Code, but it doesn't have anything to do with dotnet restore. It's about generating tasks.json and launch.json files for your project.
It might be helpful if you could provide a project with precise steps that reproduce the issue. Thanks!

Thanks for the answer.
I am talking about these two commands:

It is ok if the .Net restore only restores for one project although a bit annoying. I was assuming it would behave like a dotnet restore. In my case, it only listed the .net standard project but after a restart of vscode it now lists the other (not sure what happened). so i guess this one is good.
As for the .Net generate assets... i do not have the message anymore after the restart, but it does not seem to run anything anymore. so i assume it tries to find a specific task in the tasks.json (i have a task named 'build')

Yes, it is a bit annoying that it makes you pick projects. It in fact does just do a dotnet restore, picking a project just tells it what folder to run into in. The experience needs revisiting to include .sln files. To get the experience you're looking for (for now), you can just open the Integrated Terminal in VS Code (Control+</kbd>) and type dotnet restore`.
"Generate Assets for Build and Debug" simply generates a build task in a tasks.json file (if one doesn't already exist) and debug configurations in a launch.json file (if one doesn't already exist).  The point of the command is to generate the assets if you've clicked "Don't Ask Again" on the prompt for this project.

yes i use dotnet restore right now from terminal.
ok i misunderstood the "Generate Assets for Build and Debug" command, i thought it would run dotnet build :).
we can close this ticket except if we want to improve the experience on restore with .sln.

How about I just repurpose this to track improving the experience?

Actually, nevermind. I had forgotten that I already have an issue tracking this: https://github.com/OmniSharp/omnisharp-vscode/issues/240.


Refactor user-guide-windows-nodes

change images of the command output to text.
split long text in PowerShell command into multiple lines.

For details, refer to https://github.com/kubernetes/website/issues/15833

file name is "flannel-master-kubeclt-get-pods.png ", are you serious?

/cc @feiskyer

/assign @tengqm

/approve


In SCIM2 single attribute filtering, 'EW' operator used with domain is not working.

The [1] filters users whose userNames EW 'sominda2' and it gives a response as expected. But [2] and [3] does not provide any results. This needs to be fixed.
[1] - curl -v -k --user admin:admin 'https://localhost:9443/scim2/Users?filter=userName+ew+sominda2&count=10&domain=test1'
[2] - curl -v -k --user admin:admin 'https://localhost:9443/scim2/Users?filter=userName+ew+test1/sominda2&count=10'
[3] - curl -v -k --user admin:admin 'https://localhost:9443/scim2/Users?filter=userName+ew+sominda1&domain=primary'

Attaching domain name in front of attribute value when the operator EW is wrong, since results are matched from the end to the beginning of the attribute value.

Resolving this as this is not a valid scenario supported as per comment above, and the recommended practice of  filtering users groups for a domain needs to be documented and reported


move filter tests out of 'run_all_in_graph_and_eager_modes'

See #1328

@mainak431
You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

@gabrieldemarmiesse I've marked all tests inside with @pytest.mark.usefixtures("maybe_run_functions_eagerly") . Not sure if that's necessary. Let me know if there's something wrong here.

Thanks for the pull request @abhichou4  that's a great help! Those tests already take a long time to run, we don't need to double the running time. You can remove all usage of maybe_run_functions_eagerly except for one test. Let's say test_symmetric_padding_with_3x3_filter_mean.


Dependencies for react-native need to change

for now it support "react-native": "^0.53.3"
while react-native: 0.56.0 this is already here

Does it break in react-native ^0.56 ?


Landscape : Link Text "forgot password" and "create new account" are almost overlapped.Unable to click on link once in a time.

Version : 5.4.0
Description :
Landscape : Link Text "forgot password" and "create new account" are almost overlapped.Unable to click on link once in a time.
Steps to reproduce :
1.Load the app in landscape mode.
2.Observe "forgot password" and "create new account" links.
3.Try to click on them.
Actual :As both the links are not correct aligned as per landscape mode due to which their functionality is not working correct.
Expected : Alignment of "forgot password" and "create new account" links should be correct with proper spacing .Functionality should be work fine.

Can I take this up?

Sure @nasreekar

@Swati4star  Update: sorry for the delay. I was busy with some office work and also traveling. Will try to complete it asap.

@nasreekar Any update?

I can take a look on it. Can you assign it to me?

@prabhakar267  Sorry Prabhakar (for both late reply and no update).. was a little busy with office work (currently on site) and couldn't fix the bug.

@miso11 You can have a look into this


".selector" deprecated on jQuery 1.9+

Hi!
Your (excellent) plugin uses lots of ".selector", which is deprecated as of jquery 1.9+.
So the plugin doesn't work for jQuery 1.9+
Any roadmap for this issue?
Thanks!

Hi,
Where did you see that deprecation? I couldn't find any mentioning about it, and even on jquery official site it is used with a jquery-1.10.2 version, see here.
I think there is some other issue in your page... feel free to ask a question on stackoverflow.co

Hi!
Thanks for your quick answer and sorry if I've not explained very well the issue.
Look at https://api.jquery.com/selector/ which is deprecated.
As far as I understand, this jQuery property is used in the plugin lots of times.
Please, excuse me if I'm wrong.

You are right, .selector  was deprecated since 1.7 but still present in the latest versions of jquery and  yadcf is also working with the latest version of jquery without any problems.
Since this issue is related to #96 issue I will keep it closed and the moment I fix the #96 issue there will be no use of the selector at all...

Thanks!!
Only one remark, yadcf works for me if I don't use yadcf.init, except for "range-number" which uses ".selector" internally.
I'll suscribe for #96 waiting for a solution.
Thanks and great job!

you should use yadcf.init only when you are using the capital D datatables constructor as to the range-number issue, I jsut checked with jquery-1.12.0 and it works just fine, so you can post a questoin on stackoverflow.com with a jsbin sample and I will see what went wrong there.


This page doesn't answer the question

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8b52a210-1be6-4e5f-d95c-8ea7b87919ca
Version Independent ID: 02a43ebb-7471-d7ff-4f7e-84c9f7a66326
Content: Back up and recover accounts with the Microsoft Authenticator app - Azure AD
Content Source: articles/active-directory/user-help/user-help-auth-app-backup-recovery.md
Service: active-directory
Sub-service: user-help
GitHub Login: @curtand
Microsoft Alias: curtand

@jbaboval
Thanks for your feedback! Would you be able to provide some more details of what this doc isn't answering? This way we can correctly route your issue and assist.
If you have any other questions, please let me know.
Thank you!

@jbaboval
Thanks for your feedback! Would you be able to provide some more details of what this doc isn't answering? This way we can correctly route your issue and assist.
If you have any other questions, please let me know.
Thank you!

Wow, somebody read this.
The question was "how do you transfer accounts without an iCloud account"?
The answer, apparently, is "you can't".

Wow, somebody read this.
The question was "how do you transfer accounts without an iCloud account"?
The answer, apparently, is "you can't".


Add AMobjObjType()

@orionz, @alexjg and @ConradIrwin, I've done the following to ease writing language bindings based upon the C API:

Exposed autocommit::AutoCommit::object_type() as AMobjObjType().
Replaced the phrase "Lamport timestamp" with "epoch timestamp" within the documentation.

Thank you @jkankiewicz


Post upload progress events

Inspired by http://stackoverflow.com/questions/23348812/android-retrofit-onprogressupdate-for-showing-progress-notification, feedback welcome

@lifedemons has added one more commit, adding the ability to cancel running requests

Looks good!
Did you consider handling the UploadLocalFileResponse event in the Filepicker class and having some kind of interface users can implement and set as the listener?
So in Filepicker there would be something like:
private static UploadFileProgressListener sUploadFileProgressListener;

public static void setUploadFileProgressListener(UploadFileProgressListener uploadFileProgressListener) {
  sUploadFileProgressListener = uploadFileProgressListener;
}

public void onEvent(UploadProgressEvent event) {
  if(sUploadFileProgressListener != null) {
    sUploadFileProgressListener.onProgress(event.uri, event.progress);
  }
}

public interface UploadFileProgressListener {
  public void onProgress(Uri uri, float progress);
}

@maciejwitowski we didn't consider adding a static listener, on first impression it feels a bit on the risky side, because it may be easy to leak activities. For me, it felt most natural to put it alongside other EventBus events, i.e.:
public void onEventMainThread(FpFilesReceivedEvent event) {}
public void onEventMainThread(UploadFileErrorEvent event) {}
public void onEventMainThread(UploadProgressEvent event) {}

@exviva The argument against static listener makes sense. I think it's ready to be merged, thanks for the contribution!


feat: Customize Search logic for Combobox

Something that would be really helpful is a OnOptionsSearch  callback for the FluentCombobox, as the FluentAutocomplete already has. Additionally, it would be great to ensure that always one valid value is selected. Therefore, that the last valid value is selected again if a search text is typed with zero search results after leaving the combobox focus.
But I am afraid that the logic from the FluentAutocomplete cannot be simply taken for the FluentCombobox because the web component itself is handling the filtering... When I debug the FluentCombobox, i can see that the OnChangedHandlerAsync  is called only when the final value is updated. Therefore, I think it is not that straightforward to add the filter logic inside the C# part of the component like in FluentAutocomplete...

We are not going to implement that for the Combobox. It already has three different autocomplete settings which offer a firm of search capabilities

My question here is why the Autocomplete component have the possibility to specify an OnOptionsSearch callback and the Combobox component does not? The Combobox default behaviour is not sufficient as it only search the items from the beginning which is a huge limitation for a search capability...
From my point of view, the Autocomplete and Combobox components are exact the same controls regarding functionality. These are

Selected item/items
Show an overlay with all bound items
Filter / Search for items

The only difference is that the Autocomplete can select multiple items. I would go even one step further that Autocomplete, Combobox, Listbox and Select are the same controls with options for configuring search/filter, overlay or not, single/multi select.


[FLINK-10426] [tests] Port TaskTest to new code base

What is the purpose of the change
Port TaskTest to new code base
Brief change log
Port every existing tests to FLIP-6 code base. Mainly remove the dependency of ActorGateway, ActorGatewayTaskExecutionStateListener and ActorGatewayTaskManagerActions. See also #6729 FLINK-10386.
Also add a test to test task fails on blob missing TaskTest#testExecutionFailsInBlobsMissing. See also #6768 FLINK-10427.
With a refactor of createTask → TaskBuilder
Verifying this change
This pull request itself is about tests. Thus the guardian is itself.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving):  (no)
The serializers:  (no)
The runtime per-record code paths (performance sensitive):  (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper:  (no)
The S3 file system connector:  (no)

Documentation

Does this pull request introduce a new feature?  (no)
If yes, how is the feature documented? (no)

cc @StephanEwen @uce @aljoscha @tillrohrmann (with a lookup of TaskTest history)

This pull request need a rebase on #6729 and thus now WIP.

After a rebase on #6729 and its followings, I think this pull request is ready to be reviewed.
cc @tillrohrmann and @uce .

Thanks for your contribution @TisonKun. I think you merged at some point and now the git history is a bit messed up (some of your commits appear twice). Could you please clean this up. Otherwise, it is really hard for me to resolve the merge conflicts

@tillrohrmann sure


Fix Fate operation name

See comments #2842

Another option for the enum name could be "REPO_NAME", which I think is too vague or "RUNNING_REPO_NAME".

I think we are both confused :grin:. OK I figured it out...
The weird debug REPO is just the first REPO in the transaction. The only time it ever gets set is during seedTransaction(). So sometimes it makes sense as "target" like you were thinking but other times it doesn't. For example, the legacy Bulk import it will be BulkImport from bulkVer1 package but for the new bulk import it gets set to PrepBulkImport. For a compaction, it will be CompactRange. For create table it will be CreateTable.
You were correct that the top is actually the current running REPO.
I guess the name should be something like INITIAL_REPO or we can just remove it since its caused so much confusion. The only value I think it has is to see if its the same as the running repo to try and gauge progress. But an admin really doesn't know the REPOs of the TX without looking at the code. Since there is usually only 1 REPO that will hang during a problematic TX, this doesn't really help.
We should be passing in the name of the FateOperation ENUM since that is the name of the TX.

It is helpful to admin to know both the intent and the current step.  Even with delete table, there are stages that can take awhile - just showing a delete operation is less helpful than showing its a delete, currently running clean-up.  While it would be nice to have the intent clearer, its is better to have something.  If it only reflected the running REPO - say clean-up, that could be a delete, an import,...

Sunny ITs are passing.

In my latest change, I passed in a string for the TX_NAME. This works better than using the strong type FateOperation because the shutdown tserver tx doesn't use the FateOperation enum.

This fix is good to go now. I like the new name. Here is what fate -print will display now:

TABLE_COMPACT   txid: 754ab57de33ea843  status: IN_PROGRESS        locked: [R:+default, R:1] locking: []              op: CompactionDriver created: 2022-08-31T17:01:55.523Z

Can you try fate -summary?

Can you try fate -summary?

Report Time: 2022-08-31T19:44:00Z
Status counts:
  IN_PROGRESS: 1

Command counts:
  TABLE_COMPACT: 1

Step counts:
  CompactionDriver: 1

Fate transactions (oldest first):
Status Filters: [NONE]

Running	txn_id				Status		Command		Step (top)		locks held:(table id, name)	locks waiting:(table id, name)
0:00:09	3f94c44c38546f76	IN_PROGRESS	TABLE_COMPACT	CompactionDriver	held:[R:(+default,ns:), R:(1,t:ci)]	waiting:[]


tsrc push error messages

Neatpicking...
$ tsrc push                                                                                Error: /home/cedric/.config/tsrc.yml: Could not read file: [Errno 2] No such file or directory: Path('/home/cedric/.config/tsrc.yml')
See https://tankerapp.github.io/tsrc/ref/formats/ for details

Can it redirects to another page or to at least to: https://tankerapp.github.io/tsrc/ref/formats/#tsrcyml_format

it's nitpicking, not neatpiking :P
But you're right, this could be improved. Probably worth storing the doc urls inside the exception themselves, so this stays manageable ? Not sure ...

let's close?


Make InteractionManager.runAfterInteractions() return a Promise

In accordance with the unwritten rule that any API that takes a callback should also return a promise, I've changed InteractionManager.runAfterInteractions() to do just that.
  InteractionManager.runAfterInteractions(() => {
    ...
  });

can become
  InteractionManager.runAfterInteractions().then(() => {
    ...
  });

(but doesn't have to). Most importantly, though, this change enables code like
  doSomeUIStuff();
  await InteractionManager.runAfterInteractions();
  doSomeNonUIStuff();

which is nice.
Note: Because returning a Promise means the callback argument is now optional, the behaviour of the API is slightly changed, though not in a backwards-incompatible way (unless a consumer is in some way relying on the exception, but that would be insane).

cc @joesavona

(Hi! :wave:)

This is pretty useful, we do something similar in the Exponent fork of react-timer-mixin, called react-native-timer-mixin: https://github.com/exponentjs/react-native-timer-mixin/commit/80646223fa81d7c15c6fba0cae97887088c04fe6
This allows us to do:
await this.waitForInteractionsAsync()

Are those CI failures for real, btw? Seems unlikely that this affected layout...

Pingsies?

Meow.

@facebook-github-bot import

Sorry, I don't usually review code on this repo ;-)


App drains device battery

This is an issue in the current v2.1.0-beta1.
Android energy monitor shows the device consuming the most battery power and holding a CPU wake lock. This might be related to the scheduled actions service.

Yes, I think it's something with scheduled actions too. The other day, while testing with scheduled transactions, I found about a hundred of transactions that had been created. I still haven't been able to look into it, though.


link "markup reference guide" is broken or missing

What article on docs.github.com is affected?
In README.md, while clicking on the link "markup reference guide" it throws 404 page not found error.
https://github.com/github/docs/blob/main/content/README.md#versions

What part(s) of the article would you like to see updated?

Additional information

I want to tackle this issue, please.

Thank you for fixing this issue @Anita-ihuman! ✨:blush:


New package: Yealink.YealinkUSBConnect version <IP_ADDRESS>

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Credits to https://github.com/microsoft/winget-pkgs/pull/101382
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/116158&drop=dogfoodAlpha

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree

@iMonZ please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree


Jexcel Thems. Added params: themeHeaderBgColor, themeHeaderTextColor,…

Jexcel Thems.
Added params: themeHeaderBgColor, themeHeaderTextColor, themeEvenLineBgColor.
To see example in jexcel-themes.html

This is no longer compatible. Thanks, but if you can request again in the new version.


ability to change Group for a resource description, after it has been saved

The ability to change the Group in which a resource description has been saved.
I've been creating resource descriptions under Stanford group, but now that an MLA group has been created, I would like to associate these descriptions with the new group. As part of a project, I would like to query the data created by MLA.
The only alternative I have considered is recreating the same data and resaving to the new group, but that seems like a bad idea. There might be a way to edit this via API, but I'm not technically savvy enough to pull it off.

Hi @kevkishi, this enhancement to Editor will be prioritized with the existing tickets for the next Sinopia work-cycle. In the meantime, if you can provide a list of the URIs of the resources you would like to move to the MLA group, I can do that through the API.

is the desired feature to allow users to change a resource's group by themselves?
also do we need to allow users to put a resource in more than one group?

to your first question: Yes. We would not want to have to ask a developer every time! If a person belongs to more than one group, that person should be able to move their descriptions from one of those groups to another (templates too)--I'm sure people will save to the wrong place by mistake from time to time. If there is group admin (is there?) they should be able to move anyone's from one group to another.
to the 2nd question: I think we need to have that capability. The workflow is still so uncertain here and may have to be different for different institutions.

closing this as features will be added as part of #2901


Added league/pipeline.

Added league/pipeline to the Architectural section.

+1
On Mon, Aug 3, 2015 at 9:03 AM Frank de Jonge<EMAIL_ADDRESS>wrote:

Added league/pipeline to the Architectural section.
You can view, comment on, or merge this pull request online at:
https://github.com/ziadoz/awesome-php/pull/438
Commit Summary

Added league/pipeline.

File Changes

M README.md
https://github.com/ziadoz/awesome-php/pull/438/files#diff-0 (1)

Patch Links:

https://github.com/ziadoz/awesome-php/pull/438.patch
https://github.com/ziadoz/awesome-php/pull/438.diff

—
Reply to this email directly or view it on GitHub
https://github.com/ziadoz/awesome-php/pull/438.

I'm only merging so you can tell Phil that he owes me some beers.

@josegonzalez I'll remind him till the end of time.


Refactor messaging system

Description
According to Paper implementation, the only entity that implements sendMessage methods is the Player.
The code was refactored to comply with this behavior, taking into account the least possible impact on the user.
Additionally to this, the support for Conversation API was added.
Checklist
The following items should be checked before the pull request can be merged.

[X] Code follows existing style.
[X] Unit tests added (if applicable).

Fixes

https://github.com/MockBukkit/MockBukkit/issues/550

Unfortunately I was not able to find a way to properly unit test the ConversationTracker . If someone has an ideia in how to do it, please let me know.
(The implementation is the same as in Paper)

Unfortunately I was not able to find a way to properly unit test the ConversationTracker . If someone has an ideia in how to do it, please let me know.
(The implementation is the same as in Paper)

Yes, as the implementation is exactly the same as paper, it might not be necessary to test this for now. The only reason to add tests here would be if we later on specifically refactored this code, I honestly don't see that happening, and to be real here, I don't think everything needs to be tested. I would just add some simple tests for this that just tests if a class instance is in the right state after given input and say it's good enough.

This PR has been updated to draft, because of the following:
Comparing CommandSender and Player there's a diference in implementation, the method:
@Override
@Deprecated(forRemoval = true)
public void sendMessage(final @NotNull Identity source, final @NotNull Component message, final @NotNull MessageType type)
{
    Preconditions.checkNotNull(message, "input");
    this.messages.add(message);
}

This might be the root cause of the issue, i need to analyse it further.

Did not find any other alternative way. This seems the best approach at the moment.

@4everTheOne could you possibly join the Discord Server? We have a few questions we would like to talk about (don't worry nothing bad ^^)


Add Helm options to extend auto-approval or disable it

This PR adds Helm options to simplify configuring the build-in cert-manager auto-approver.

It adds the option to approve external issuers (including an "approve all external issuers" options)
It adds the option to easily disable the auto-approver

This will simplify installing cert-manager combined with an external issuer or in combination with approver-policy (https://cert-manager.io/docs/policy/approval/approver-policy/installation/).
Fixes https://github.com/cert-manager/cert-manager/issues/6521
NOTE: We will keep the default "only approve cert-manager.io Issuer and ClusterIssuer" rule. In approver-policy and csi-driver-spiffe, we removed this constraint. The reason we keep the constraint here is because cert-manager's auto-approver will automatically approve all CertificateRequests that it can approve (which is not the case for approver-policy and csi-driver-spiffe). To prevent breaking existing setups (prevent two approvers from racing to approve the same resource), we will not expand the default set of issuers.
Kind
/kind feature
Release Note
If the `--controllers` flag only specifies disabled controllers, the default controllers are now enabled implicitly.
Added `disableAutoApproval` and `approveSignerNames` Helm chart options.

/retest

/test pull-cert-manager-master-make-test

/hold

/approve

/unhold

/cherrypick release-1.15


Update FAQ.md

typo fixed - in "addition" to

Hello @dfpoon, thanks for catching those typos and contributing to the project 🙂. There's a slight conflict right now because the FAQ.md you modified is now named FAQ-en.md and it's under a new directory FAQ/. I can fix this manually from my end, but I believe that way your username wouldn't get registered in the list of contributors. Would you like to be acknowledge for your contribution? If so, can you resubmit the PR? If not, just let me know and I will merge manually.
I think it's neat to have all contributors acknowledged, but up to you!

This also includes PR #242, If you want to resubmit you can probably lump the two typos in one PR. Again if you don't care, no worries I'll merge manually.

Thanks for your response.
I would like to take this opportunity to suggest correcting two more typos:
Q17. no single point of "faillure" --> failure
Q19. What is a descentralized ID (DID)?  --> decentralized
Thanks!

Hi @medied and @dfpoon I made the correction to those 2 typos, thanks @dfpoon for pointing them out!!

@dfpoon tiny contributions are powerful too! So thanks again, I will fix the two original typos now. And yes @SFSandra thanks for catching the other two typos! All four will be resolved after my commit coming up.


Use includes instead of preload acts_as

Includes intelligently joins the acts_as table only when required i.e., when there are conditions on that table
Avoids unnecessary join & thereby preventing .select(new_attribute)

Only problem I faced till now is when I use this in conjunction with enumerize gem
Child.select("some fields which doesn't include atleast one of enumerize column") doesn't respect eager loading & makes N+1 calls to parent object
Its not a blocker though.

Thanks


add catalan data structures book

What does this PR do?
Add resource(s)
For resources
Description
This pull request adds a book about datastructures and algorithms created by some professors of the University of Lleida.
Why is this valuable (or not)?
Could be valuable for people trying to understand some data structures like graphs, linkedlists, etc and they want a book about this topic that is written in catalan.
How do we know it's really free?
It is licensed behind a Creative Commons license, which has:
Attribution, Non commercial and no derivatives.
For book lists, is it a book? For course lists, is it a course? etc.
This is a book (has an ISBN:  978-84-9144-101-4)
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

I am participating on HacktoberFest, so I would like to have the "Hacktoberfest-accepted"  label if it is possible 😄 .

language code is ca.
You want TWO index headings for one resource?
It's usually not helpful to add a category for a single resource. Try to find another category, or see if there are other books in our lists that would fit into your category.

Hi @eshellman! The commit  5d51b3deac574f1e7aad55f7219acc8fae136570 fixes the issues you commented in the pull request review 😃 .
The two books I've added one is a book-wiki about C, and the other is licensed with a creative commons with non commercial derivatives.
Cheers!

Some maintainer will review again this pull request? 7 days have passed and the project is accepting other pull requests. Should I change something more?

you have not fixed the language code. it should be ca, not es_CA

see #9109


The linked library 'libPods-*****.a' is missing one or more architectures required by this target: arm64

升级到xcode 12 以后运行项目就报了以下的错误
The linked library 'libPods-*****.a' is missing one or more architectures required by this target: arm64

https://github.com/facebook/react-native/issues/29984#issuecomment-696328815


blog: highlight Max's OCI talk at CNCF

Signed-off-by: Daniel Holbach<EMAIL_ADDRESS>

→ https://deploy-preview-1225--fluxcd.netlify.app/blog/


why there is no pagination

<SimpleTable       data={data}       dataKeyFn={item => item?.name || "empty"}       cols={[         ["name", "Name", "name"],         ["email", "Email", "contact.email"],         [           "dob",           <i>Date Of Birth</i>,           item =>             djs(${item.dob.year}-${item.dob.month}-${item.dob.day}).format(               "Do MMMM YYYY"             )         ]       ]}     />

The project just focuses on the table, but now that you've raised it up, maybe I should include pagination. I'll consider it in the next update.


Add Test cases for modules

closes #49

Codecov Report

Merging #231 (25385db) into master (0b80fc6) will increase coverage by 1.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #231      +/-   ##
============================================
+ Coverage     41.48%   42.48%   +1.00%
- Complexity      661      685      +24
============================================
  Files           150      150
  Lines          3375     3375
  Branches        405      405
============================================
+ Hits           1400     1434      +34
+ Misses         1879     1855      -24
+ Partials         96       86      -10

Impacted Files
Coverage Δ

...ava/seedu/address/model/tamodule/AcademicYear.java
69.69% <0.00%> (+3.03%)
:arrow_up:

...in/java/seedu/address/model/tamodule/TaModule.java
64.81% <0.00%> (+20.37%)
:arrow_up:

...seedu/address/model/tamodule/UniqueModuleList.java
90.24% <0.00%> (+46.34%)
:arrow_up:

...l/tamodule/exceptions/ModuleNotFoundException.java
100.00% <0.00%> (+100.00%)
:arrow_up:

.../tamodule/exceptions/DuplicateModuleException.java
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b80fc6...25385db. Read the comment docs.


🐛 Fix support for extending openapi_extras with parameter lists

Issue
When specifying parameters in openapi_extras for an endpoint, they will overwrite the existing query parameters with the extra parameters. This is due to deep_dict_update in utils.py overwriting list types rather than merging them together.
PR Content
This PR updates deep_dict_update to merge arrays instead of overwriting. I have also added a test case that demonstrates and verifies the desired behavior.
Testing
Ran bash scripts/test-cov-html.sh  with 100% test pass including new test case

Awesome, thanks for the contribution @orilevari! :rocket: :tada:

Is there a way to fall back to the old functionality somehow? 🤔 We have Query(default=datetime.utcnow()) and we are trying to override it like openapi_extra={"parameters": [{"schema": {"default": "Current timestamp in UTC"}}]} 😄 And this change now simply appends a new parameter in the list.
We might do include_in_schema=False and write it completely if there isn't, so no worries... :blush: (Other solutions for changing the default in the OpenAPI-schema also welcome!)


Fix broken bluetooth tracker

Description:
Fix an issue introduced by #15252
Related issue (if applicable): fixes #
https://github.com/home-assistant/home-assistant/pull/15252/files#r217228994
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass

Just realizing the timing of this matches when mine broke (never got around to figuring out why). Great catch!


Docs > general > introduction, missing word fix.

Fixes #1663.

Clearly I did something wrong here... Going to try again.


[Accessibility]A11y_GoToLine_SelectIndication_keyboard: after clicking on "Tab" key the opened "Screen" get closed

Environment Details:
VSCode Version : 1.24.1
OS Version : Win10
Additional Details:
Keyboard, MAS2.1.1
Repro Steps:
1 Navigate to menu Bar and select Go and select “Go To Line" button form the dropdown.
2.Navigation through TAB
Actual:
after clicking on "Tab" key the opened "Screen" get closed
Expected:
after clicking on "Tab" key the opened "Screen"  should not be closed
Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/Pages/browse-fixes.aspx

User Impact:
Colorblind and low vision user will not identify the screen content and controls.
MAS Reference:
[https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={a4bbd37d-ee11-485e-b5c8-0539f0ac94b2}
](url)
Attachment for Reference:
A11y_VSCode_GoToLine_keyboard.pptx
Does this issue occur when all extensions are disabled?: Yes

The root cause of this is with the "Quick pick" control that opens when you choose "Go to Line". The same control is shown in many different scenarios, so I'm going to close all but one instance of this problem.
(https://github.com/Microsoft/vscode/issues/51854)


Saving new pdb from dataframe

I have a very basic question. I often load pdb files as ppdb objects and then convert to pandas df to manipulate them:
ppdb = PandasPdb().read_pdb(input_pdb)
chainA_df = ppdb.df['ATOM'][ppdb.df['ATOM']['chain_id'] == 'A']
...(more code to alter the chainA_df)...
For instance, I want to renumber residues in only chain A using a conversion dictionary, so I find it easier to work with the individual chain as a pandas df, like this:
chainA_df = chainA_df.replace({'residue_number': conversion_dict})
However, I can't find a function to now to take the altered pandas df and save a new PDB. Is there any way to go backwards (i.e. create a ppdb object from the altered df and then save)? Any advice would be helpful.

You can set it on a new pandas pdb object.
Something like:
from biopandas import PandasPdb

new_ppdb = PandasPdb()
new_ppdb.df["ATOM"] = my_new_df
new_ppdb.df["HETATM"] = my_new_hetatm_df

new_ppdb.to_pdb("my_transformed_pdb.pdb")

This is exactly what I was missing, thank you!


merge latest

Make sure you've checked off all these things before submitting:

[ ] This pull request isn't for a company's fork, it's intended for the upstream Slate shared by everybody.
[ ] This pull request is submitted to the dev branch.
[ ] If it makes frontend changes, this pull request has been tested in the latest version of Firefox, Chrome, IE, and Safari.

... wrong way around... closing this


Aliyun OSS upload error

Describe the bug
配置阿里云oss上传错误
Configuring Aliyun OSS upload error.
Steps to reproduce

{
  "error": "code=500, message=Failed to upload via s3 client, internal=operation error S3: PutObject, https response error StatusCode: 403, RequestID: xxxx, HostID: xxxxx.oss-cn-hongkong.aliyuncs.com, api error SignatureDoesNotMatch: The request signature we calculated does not match the signature you provided. Check your key and signing method.",
  "message": "Failed to upload via s3 client"
}

Screenshots or additional context
No response

我是像这样配置的 可以上传
https://tc.iimx.cn/picgo/202303080855289.png

我是像这样配置的 可以上传

问题解决了，Storage Path多了个「/」: /memos -> memos
The problem has been solved. Storage Path has written an extra "/": /memos ->memory


stats.contingency not listed as public API

Follow-up on https://github.com/scipy/scipy/pull/14898#issuecomment-950387176: stats.continency is public I believe, because the namespace is used in http://scipy.github.io/devdocs/reference/stats.html#contingency-table-functions and the functions there are not present in the main namespace. There was some discussion on an issue or PR about that, but probably not on the mailing list.
The bug report here is that contingency is not listed as a public submodule in http://scipy.github.io/devdocs/reference/index.html#api-definition.

@Smit-create could you take this along in your public API test PR?


Compile issue with Visual Studio 2015 community edition

Can latest SharpNL be compiled with Visual Studio 2015 community edition (update 3, latest at time of writing)?
I got a lot of compile error like: \SharpNL\src\SharpNL\BaseObject.cs(42,48,42,100): error CS8026: Feature 'expression-bodied property' is not available in C# 5.  Please use language version 6 or greater.
But Visual Studio 2015 community is capable of working with C# 6. Any hint?

Hi, just change the version to 6.0 in Properties => Build Tab => Advanced button => Language Version
VS 2015 should support C# 6.0


Rewire nested module support?

Thanks a lot for the library, it's a very cool idea to utilise aliasing and I really enjoy not having to deal with Application.fetch!
However, I am facing an issue with nested modules right now.
In my example,
defmodule Messaging do
  def send, do: Courier.send()
end

defmodule Courier do
  def send, do: Pigeon.send()
end

Pigeon is the mock that I want to implement, now, if I do:
defmock(PigeonMock, for: PigeonBehaviour)
rewire Messaging, Pigeon: PigeonMock

This compiler gives a nice helpful message and says it can't find Pigeon in Messaging, which is only available in Courier.
My actual use case is a little more complicated (with protocol dispatch), but this should illustrate the point just fine.
I can see that it is mentioned in the README,

Only the dependencies of the rewired module will be replaced. Any modules defined around the rewired module will be ignored. All references of the rewired module to them will be pointing to the original. You're always able to rewire them separately yourself.

But is this due to a technical reason, or will it be possible to do it? I'd gladly take a look at it if that's the case.
Since rewire works by replacing the module with a new version with alias, perhaps we could just recursively walk and replace the modules?
I haven't really looked into where it would work or not, but the proposed idea could look something like:
rewire Messaging, [Courier: [Pigeon: PigeonMock]]

This generates a new Messaging module that uses a rewired version of Courier, which uses a rewired version of Pigeon

Actually, I'm using protocol which means this would likely never work for me anyway, but nested rewiring could still be nice!

Here is my exact protocol version:
defprotocol Courier do
  def push(mod)
end

defmodule Push do
  defimpl Courier do
     def push(_), do: Pigeon.send()
  end
end

defmodule Messaging do
   def send, do: Courier.push(%Push{})
end

I'm not sure if protocol would impact it (I'd probably need to disable consolidation), I think what I really need is to rewire the Push module in Messaging to a Push that rewired?

Hey Edison, thank you!

Since rewire works by replacing the module with a new version with alias, perhaps we could just recursively walk and replace the modules?

You're right, rewire only looks one level deep and could support a recursive strategy but I hope we can avoid that. Rewire can actually support nested modules already, the syntax is just not as nice as the one you posted (good idea!): see https://github.com/stephanos/rewire/blob/master/test/rewire_alias_test.exs#L17. The secret is just to have multiple rewire. Seems like you already found that our yourself!

defprotocol

That's interesting! I didn't think about that at all, yet. Could you explain how disabling consolidate_protocols fixed the issue for you? What was the error message you saw?

rewire only looks one level deep and could support a recursive strategy but I hope we can avoid that.

Any particular reason why we're trying to avoid that? Just trying to understand if it would introduce too much noise into the codebase or something?

The secret is just to have multiple rewire

That's exactly what I'm doing now which is great! I'm actually kinda surprised that it worked, but I guess since it's just aliasing it works pretty similar to nested modules?
The consolidate_protocol error message was something described here:
https://elixirforum.com/t/protocol-has-already-been-consolidated-in-tests/11308
I suppose it's because Rewire tries to reload the file in memory after aliasing, but reloading a file with protocol definition won't have an effect because mix had already "consolidated" them, so the "fix" is to disable it.

Any particular reason why we're trying to avoid that? Just trying to understand if it would introduce too much noise into the codebase or something?

Yes, exactly. I think it would be the code base larger and only add more problems. The way it is now it does exactly one thing, no hidden magic.

That's exactly what I'm doing now which is great! I'm actually kinda surprised that it worked

I was, too, when I tried it first :D it's really just because the output of the first rewire is still a simple, ordinary module that itself can be used to rewire something else. There's nothing inherently  different about the rewired module.


VSCode Go to Definition - "wrong" file

Versions:

ide-helper Version: 2.12
Laravel Version: 9.2
PHP Version: 8.1

Question:
Hello! Not sure if this is a current issue, can't find it in the issues list.
I'm on VSCode, the package works fine, but when I click to a Model -> Go to definition, always shows the _ide_helpers_models.php file. It's good for autocomplete, but now I never can go to the definition class quickly with the package.
Is this a common issue? Any ideas to "solve" or change this?
Thank you!

not fixed yet?

I'm having this issue as well, has anyone found a work-around?

Anyone have a fix?


Implement async test functions and inventory

One of the main concerns for usability of the framework is performance and the fact that tests are run in sequence for each inventory device. Most of the tests are RPC calls over the network and creating connections that cause delays for am inventory of hundreds of devices. Would be nice to have an async method where all the tests (or just a subset) can run in parallel and waiting time could be used efficiently.
Also async inventory could initiate connection to all inventory hosts in parallel.

Hi !
PR #122 implement tests as coroutines and use an async library to create a device session in the InventoryDevice object.
This has been merged in the master branch.
Feel free to test and let us know if this issue can be closed.


4.27 Support

For the most part the plugin compiles but theres an error that causes the plugin to not compile:
error C2666: 'TFieldPtrAccessor::operator ==': 3 overloads have similar conversions

Too much NULL , doesent work


Demo not working

Hi,
I tried the program but got issue: save file failed:, 8f92cdb5-e386-4eff-8b0f-00d345def67a.
Attached screenshot;

Thanks in advance

My situation will not help you but the demo didnt upload the pdf unless I turned off ad blocker chrome addon

Hi, I tried the program but got issue: save file failed:, 8f92cdb5-e386-4eff-8b0f-00d345def67a.
Attached screenshot;
Thanks in advance

Im also getting the same error


Google STT crashing- livekit-plugins-google==0.6.2, livekit-agents==0.8.8

{"message": "google stt connection failed, retrying in 0s\nTraceback (most recent call last):\n  File "/root/pythonenv/enve/lib/python3.10/site-packages/livekit/plugins/google/stt.py", line 247, in _run\n    await self._run_stream(stream)\n  File "/root/pythonenv/enve/lib/python3.10/site-packages/livekit/plugins/google/stt.py", line 295, in _run_stream\n    _streaming_recognize_response_to_speech_data(resp)\n  File "/root/pythonenv/enve/lib/python3.10/site-packages/livekit/plugins/google/stt.py", line 344, in _streaming_recognize_response_to_speech_data\n    text += result.alternatives[0].transcript\n  File "/root/pythonenv/enve/lib/python3.10/site-packages/proto/marshal/collections/repeated.py", line 125, in getitem\n    return self._marshal.to_python(self._pb_type, self.pb[key])\nIndexError: list index out of range", "level": "WARNING", "pid": 652876, "job_id": "AJ_fPuvKmLPFM6y", "timestamp": "2024-08-28T13:53:15.418214+00:00"}

hi there, this was fixed in #680 and will be released soon!


Feature/review copy and to_field

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.08%. Comparing base (7efe4da) to head (c8f73bd).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #522   +/-   ##
========================================
  Coverage    91.08%   91.08%
========================================
  Files          147      147
  Lines        10730    10732    +2
  Branches       510      510
========================================
+ Hits          9773     9775    +2
  Misses         794      794
  Partials       163      163

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


remove at mention for INSPECT

fixes #2060

Pull Request Test Coverage Report for Build 68297

0 of 0   changed or added relevant lines in 0 files are covered.
25 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.01%) to 77.115%

Files with Coverage Reduction
New Missed Lines
%

/libraries/Microsoft.Bot.Builder/Inspection/InspectionMiddleware.cs
25
79.55%

Totals

Change from base Build 68166:
0.01%

Covered Lines:
4896

Relevant Lines:
6349

💛  - Coveralls

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1

I also found a couple of fragile cases in the new TestBot tests - tomorrow doesn't always equal today + 1.  Had to fix so this passes.
JavaScript seems to be missing the whole mention filtering code - that is a different (and bigger) issue. Possibly its just that I haven't found it yet!

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.3.1
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.3.1


Jupyter exampleAuth error

I'm getting an error in this line of code under accounts.ipynb
import json
import oandapyV20
import oandapyV20.endpoints.accounts as accounts
from exampleauth import exampleauth

accountID, access_token = exampleauth.exampleAuth()
client = oandapyV20.API(access_token=access_token)

r = accounts.AccountList()
response = client.request(r)
print(json.dumps(response, indent=2))

ModuleNotFoundError                       Traceback (most recent call last)
 in ()
2 import oandapyV20
3 import oandapyV20.endpoints.accounts as accounts
----> 4 from exampleauth import exampleauth
5
6 accountID, access_token = exampleauth.exampleAuth()
ModuleNotFoundError: No module named 'exampleauth'

Hi,
that class is in the oandapyV20-examples repo. I will take a look and see to update code and/or docs.


Multiple type checking passes

To support recursive struct types, or struct types that reference other types, we need to have two passes in the type checking.

a registration pass, which saves all structs and function signatures
a validation pass, which validates the types using the list of registered types

This will enable referencing types defined further down in a file, like this:
struct Person {
    fname string
    lname string
    dob Date
}

struct Date {
    year int
    month int
    day int
}

It will also make the following possible:
struct Node {
    data string
    next Node
}

It seems that the first "registration" pass should happen during the parsing stage, and all "validation" should be moved to a new pass after the AST is generated.

Lots of progress made. Need to check mutually recursive types.

Added function type checking to the second pass.

Implemented.


Suspicious line-level CPU profile information

I cannot fathom how thisData.visitId == id can use 2.06% of CPU, on a fairly large run.
This is a trivial field access, and the target class is always the same, so it must be a monomorphic access.
The same is for int cacheLength = caches.length; - using 3.94% for reading length of a List - I don't believe it.
At the same time visitor(target, thisData); - the callback that actually does some work (not much, but it must be much more than just a field access).

a) Observatory's profiler is a sampling based one. So these are percentages of samples and not CPU usage. Interpreting these numbers as time or CPU usage is incorrect.
b) The first column represents inclusive percentage of samples not exclusive so the 3.94% is the percentage of samples where this function was waiting for a callee to complete. It would also be ticked waiting for a GC or compilation to complete.
c) The source profile blurs unoptimized and optimized code for the function. They have different performance characteristics and in unoptimized code some "fast" operations still require transitioning from Dart to C and back.
d) The PC -> line mapping is approximate and there is room for improvement. I suggest you create a reproduction that demonstrates a bad PC -> line mapping -- I can then look at the disassembly and see what source lines the compiler attributed to each code address and then I can fix the compiler so that it properly tracks the line number for that code block.
Consider the "2.06%" line, what is happening on this line is:
we load the local for id
we load the local for thisData
we invoke the getter for visitId
we test for equality
we branch based on the result of the test
There may also be register spills / copying to/from the stack / class id checks / other compiler backend stuff that is attributed to that line because it is part of the machinery of evaluating the expressions, comparing them, and branching.

Yes, I understand that it's a sampling profiler. But this means that statistics might shift or be not quite exact on a small number of runs. In this case the method is a hot one, it is executed many thousand times, maybe a million times. And statistics always have the same pattern, with high time associated with lines that IMHO cannot use much time, as I think after looking on code of other methods.
method_code.pdf
method_statistics.pdf


Release 3.4.0 full regression issues

[ ] Known address v1 - broken image is displayed if no logo for know address on back-end - https://app.zenhub.com/workspaces/safe-multisig---web-5ce554debb310a35b2f8b6f8/issues/gnosis/safe-react/2133

[ ] Known address v1: mix of data from known address list and address book - https://app.zenhub.com/workspaces/safe-multisig---web-5ce554debb310a35b2f8b6f8/issues/gnosis/safe-react/2135 Note: addressbook has higher priority than known addressbook always

[x] The app is crashed - https://app.zenhub.com/workspaces/safe-multisig---web-5ce554debb310a35b2f8b6f8/issues/gnosis/safe-react/2136

[x] Tx failed with default gas values in xDai - https://app.zenhub.com/workspaces/safe-multisig---web-5ce554debb310a35b2f8b6f8/issues/gnosis/safe-react/2137. - won't fix

[x] Gas limit is inconsistent right now https://github.com/gnosis/safe-react/issues/2146 - the fix on back-end was done

I think the issue "Known address v1: mix of data from known address list and address book" is the same case as I addressed in this comment
https://app.zenhub.com/workspaces/safe-multisig---web-5ce554debb310a35b2f8b6f8/issues/gnosis/safe-react/2113#issuecomment-811458931

@francovenica , yes, agree with you and you was completely right in the comment, but :

the PR was closed without solving it
The addressbook goes first - even on the transactions list the safe name should be used instead of the name and logo from known addresses.

@liliya-soroka

Known address v1 - broken image is displayed if no logo for know address on back-end
This one is not a bug, we did that on purpose, there is a discussion in the issue.

@liliya-soroka

Known address v1: mix of data from known address list and address book

Same for this one.

@nicosampler

Known address v1 - broken image is displayed if no logo for know address on back-end
This one is not a bug, we did that on purpose, there is a discussion on the issue.

The backend provides an image in reallly all cases, i.e. the image icon is a required field which is not nullable in the ABI?
I tried to find the discussion but couldn't find it in #1638 - could you link me to it pls?

Known address v1: mix of data from known address list and address book
The same for this one.

In the ticket desciption of #1638 it says "Local address book names should overrule the human readable name that comes from the backend." hence I would expect this. Could you elaborate why this was done differently?

@tschubotz

https://github.com/gnosis/safe-react/pull/2113#issuecomment-812151859

https://github.com/gnosis/safe-react/pull/2113#issuecomment-811916591

Ah, in the PR, didn't check there, thanks for linking.

1. [#2113 (comment)](https://github.com/gnosis/safe-react/pull/2113#issuecomment-812151859)

Hmm, in our backend the logo is optional, right @Uxio0? I think the frontend needs to check if the logo exists to be honest. And if it desn't, we need the <> placeholder.

2\. [#2113 (comment)](https://github.com/gnosis/safe-react/pull/2113#issuecomment-811916591)

I don't get why we would now build it differently on mobile and web then to be honest. But seems like this is expected then 🤷

@tschubotz , just as a note to align two platforms, on mobile it was agreed to show address indeticon  + known address name if the address is located in the known address list without logo (transactions list and on transaction details )

if the address is located in the known address list without logo

Now I'm complete lost :D
You mean "if the address is located in the address book list without logo"?

I mean "Known address" list on back-end in Django administration (the  logo is optional , only the name is required )

Hmm, in our backend the logo is optional, right @Uxio0? I think the frontend needs to check if the logo exists to be honest. And if it desn't, we need the <> placeholder.

if not logo was provided by the backend, it will show the identicon, but if the logo was provided and the link is broken, we are not setting a placeholder. I think that if the image is broken, we should report it, not patch it.

if not logo was provided by the backend, it will show the identicon, but if the logo was provided and the link is broken, we are not setting a placeholder. I think that if the image is broken, we should report it, not patch it.

So you are saying the client gateway should just not return a logoURI in that case ,right?
@jpalvarezl @rmeissner Is this how the client gateway is built? i.e. it would only return the logoURI if there is actually a logo for the known address present?
(Example is nonce 442 on this Safe: https://safe-client.rinkeby.staging.gnosisdev.com/v1/safes/0x1230B3d59858296A31053C1b8562Ecf89A2f888b/transactions/history)

no, perhaps the URL exists but is broken for some reason. Like it happens on Rinkeby for some images, there is a link, but when you open that link it returns a 503 I think.

It returns a 403. And that's normal AWS behavior also when the file doesn't exist afaik.

sorry, it's a 403.
This is an example, on Rinkeby the backend returns this image: https://gnosis-safe-token-logos.s3.amazonaws.com/0x9Ea007843318B9EcD85f93eCC55D4e19143f007A.png and it is broken.
So, if we face that scenario, what should we do?
a. omit the error and use the identicon (we will hide the error)
b. render the broken image as it is now (on mainnet this error is no common at all)

This is an example, on Rinkeby the backend returns this image: https://gnosis-safe-token-logos.s3.amazonaws.com/0x9Ea007843318B9EcD85f93eCC55D4e19143f007A.png and it is broken.

I'm not sure what you mean by "broken" - it's simply not available, right? :)
So either the client gateway needs to not return the logo url when there is no image. Or the frontend needs to filter it out. That's the 2 options I see. Hence my question, on how the client gateway does it.

There's a difference between contract logos and token logos on the core services, as they were implemented in a different way:

contract logoUri is null if not logo was set.
token logoUri will always return an address, even if file cannot be fetched.

@jpalvarezl @rmeissner I think that could be the problem with some contracts having logos that are not "valid"

So, if we face that scenario, what should we do?
a. omit the error and use the identicon (we will hide the error)
b. render the broken image as it is now (on mainnet this error is no common at all)

I think we should go with option a since

* if file does not exist (will get a 403 from S3).

As Uxio said.
The images aren't "broken" as in corrupted. But they are just not existing.

There are separate issues open for the 2 open questions. -> closing


.css included in the main nuxt bundle? why?

I've looked around for an answer for this but couldn't find one, I can see that in the main bundle some of the tailwind.css is included:

The snippet with some of the css in the file itself.

When I run Nuxt in analyze mode I can see that it takes 4.28KB Gzipped in the main bundle, why does this happen? my CSS is usually loaded in the head of the page.

Hi @OfekA
Actually it is necessary to have it in the JS to be able to server-render it for any page.
This is his Nuxt (and vue server renderer) handles CSS actually.

Thanks for the answer @Atinux 😄


Splash Screen Request Feature to Defer Activating Window

Hi dotMorten,
First, we greatly appreciate the SplashScreen feature of this project.
We wanted to know if it's possible to suppress Activating the window from the splash screen. There's some styling that occurs in the window and when the window is activated too early some of that styling causes considerable flicker.
Perhaps there can be a flag to indicate whether to Activate the window?
private async void Content_Loaded(object sender, RoutedEventArgs e)
{
    if (IsAlwaysOnTop)
        this.SetIsAlwaysOnTop(true);
    else
        WindowExtensions.SetForegroundWindow(this);
    double h = Height;
    double w = Width;
    if (Content is FrameworkElement f)
    {
        if (double.IsNaN(Width) && f.DesiredSize.Width > 0)
            w = f.DesiredSize.Width;
        if (double.IsNaN(Height) && f.DesiredSize.Height > 0)
            h = f.DesiredSize.Height;
    }
    if (double.IsNaN(w))
        w = 640;
    if (double.IsNaN(h))
        h = 480;

    this.CenterOnScreen(w, h);
    await OnLoading();
    if (_windowType != null)
        _window = Activator.CreateInstance(_windowType) as Window;
    _window?.Activate(); // Is it possible to suppress / defer this?
    this.Close();
    _window?.SetForegroundWindow();
    Completed?.Invoke(this, _window);
    _window = null;
}

I'm thinking a good workaround for us it to instantiate a window ahead of time and utilize the first constructor of the SplashScreen that takes in an instanced window. That way the styling can be applied while the window is invisible. Only issue now is that it doesn't start the window out as maximized, but we can do that in the main app.xaml.cs file.

I'm not quite following the issue here (do you have a repro?). If you don't activate the window, the window won't start loading and rendering it contents.
The splashscreen isn't that special - it's just one window with a few fixed size settings showing before opening the next one, so you could just create any window and use as a splashscreen.

True, we tried that option (our own version of the splash screen) and that worked as well. I think we're good to close this issue.
Thank you!


General test performance enhancement

Cut down on some unnecessarily long sleeps wherever possible.  This cuts the total unit test execution time down by about 50%.

Debug
Release

Original
4936 ms
3248 ms

Current
2439 ms
1699 ms

Build server times are even more substantially improved.
| -------- | -------- |
| Original | 1560 ms  |
| Current  | 240 ms  |

+1


Add to VWAD

You should add the project to VWAD: https://github.com/OWASP/OWASP-VWAD
Also a few other minor notes: your README should have a leading capital on the first sentence. You should remove the .DS_Store file, then add it to your .gitignore (order of operations will matter :wink:)
https://github.com/OWASP/OWASP-VWAD#editing-process

thank you @kingthorin


added dataAttr prop on ComboSelect component

Updates refactored and new PR created #23

Updates refactored and new PR created #23


If Completed/Installed Config Exists but Logos Dir is Missing, Program Fails

We need code to check if the config is valid, else the program breaks. Ideally we should notify the user if the config can't find the declared install and offer either to install or prompt for the user to check their config.
Make sure config paths are relative so that the install is self-contained and can be moved freely; that is, make sure the config doesn't break if someone moves their install from their initial install dir. cf. https://github.com/FaithLife-Community/LogosLinuxInstaller/issues/13.

I ran into this while testing, and it's not clear what the precise conditions are to make this happen. In my testing I had a proper Logos Dir, etc., except that Logos itself wasn't installed within the wine prefix. The curses UI would just return to the initial screen when choosing either "Install Logos" or "Exit".
Removing the config file was the solution, but it doesn't seem to be related to bad config variables but rather something about the timing of when the config file is looked for when LLI runs. This needs more testing for sure.

Somehow this function is probably involved:
https://github.com/FaithLife-Community/LogosLinuxInstaller/blob/b472f4f85443e5ce64f05565df2cc8133c9a4fed/tui_app.py#L525


Can't add audio files from Google Drive

Using the most recent version of Chrome on Windows 7 and OS X Yosemite, I can't add audio files from Google Drive. When browsing my Drive, Drive Player launches correctly when I double-click an mp3, but when I try to add files to the queue or to make a play list, I can't. I'm prompted to log in, and I do, but I either get the same login screen over and over OR I'm told the feature I'm requesting isn't available at the time and to try again later. This has always been the case. Are there Chrome extensions known to interfere with Drive Player?

I am having the exact same problems as listed above, does anyone have any suggestions??

nope, this is happening to me too!

.

Five and a half months later, sounds like it's still an issue.

yep, it seems like the don't care, or don't pay attention to problems
anymore.
On Thu, Apr 27, 2017 at 6:43 PM, 79goat5<EMAIL_ADDRESS>wrote:

Five and a half months later, sounds like it's still an issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/googledrive/drive-music-player/issues/165#issuecomment-297869025,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aa0RiFEBmc34iYSZJA1xbpCpG9q9sa08ks5r0Sg7gaJpZM4KVGRU
.

Same problem, no solution I take it?

None that I'm aware of yet.

not yet, it makes me angry
On Sun, Jun 4, 2017 at 6:36 PM, 79goat5<EMAIL_ADDRESS>wrote:

None that I'm aware of yet.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/googledrive/drive-music-player/issues/165#issuecomment-306075038,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aa0RiMjs_WR53GoCw67ayKlSGWMBVJc0ks5sAz96gaJpZM4KVGRU
.


Origin logging / metrics

We would like to generate a report of all the Origin URLs/hosts that are presented by callers of the API over a six month period. This will allow us to make more confident decisions about CORS.
Logs do not persist in Datadog for six months so the report generation for this may need to be a little bit creative. E.g. a cron job to regularly backup a record of the specific hostnames and counts for each day, or a daily email report with the Origin counts and then manual tabulation of those emails into a six month report.
Six months will give us enough time to see multiple changes in API usage and build an understanding of what our CORS configuration should be.

Closed due to project shutdown


How can i get cookies and media ids ?

I need my login cookies and my other question is how can i get media ids from url ?

I get cookies from cookie jar but i dont find media id thing.

Is the problem solved ? How did you get media ids from url ?

Is the problem solved ? How did you get media ids from url ?

Yes it is. I used "instagram-id-to-url-segment" package on npm. It has "urlSegmentToInstagramId" func on it.


Choice Object does not work right after a jump

When having something like this, the choice dialog at the Yes label is not shown but the dialog inside it is.
var script = {

    // The game starts here.

    "Start": [

        {

            "Choice": {

                "Dialog": "h Have you already read some documentation?",

                "Yes": {

                    "Text": "Yes",

                    "Do": "jump Yes"

                },

                "No": {

                    "Text": "No",

                    "Do": "jump No"

                }

            }

        }

    ],

    "Yes": [{

            "Choice": {

                "Dialog": "h show dialog",

                "Yes": {

                    "Text": "Yes",

                    "Do": "jump Yes"

                },

                "No": {

                    "Text": "No",

                    "Do": "jump No"

                }

            }

        },

        "h That's awesome!",

        "h Then you are ready to go ahead and create an amazing Game!",

        "h I can't wait to see what story you'll tell!",

        "end"

    ],

    "No": [

        "h You can do it now.",

        "display message Help",

        "h Go ahead and create an amazing Game!",

        "h I can't wait to see what story you'll tell!",

        "end"

    ]

}

Fixed in PR https://github.com/Hyuchia/Monogatari/pull/25


How to save best epoch？

Hi, dear authors！
I want to save the best epoch during the entire training period(that is, only the best model is left after the training is completed), how can I do it?
Thank you！

Hello,
You can use
evaluation = dict(
    ..
    metric='bbox',
    save_best = 'bbox_mAP',
    ...
)

in your config file.

@deepakksingh Thank you, are there any other options besides this option?  Could you tell me where can I see these options?

I actually found out after going through the code of EvalHook. You can find it here:
https://mmdetection.readthedocs.io/en/latest/_modules/mmdet/core/evaluation/eval_hooks.html?highlight=save best

@deepakksingh Thank you

i

Hello,
You can use
evaluation = dict(
    ..
    metric='bbox',
    save_best = 'bbox_mAP',
    ...
)

in your config file.

it seems not only  save the best model, but also save the every model after training. The best model is the soft link of the model with best bbox_mAP among all the models.

I have the same question, and I set the config as
evaluation = dict(
    ..
    metric='bbox',
    save_best = 'bbox_mAP',
    ...
)

errors still happened.
Traceback (most recent call last):
  File "tools/train.py", line 185, in <module>
    main()
  File "tools/train.py", line 181, in main
    meta=meta)
  File "mmdet/apis/train.py", line 150, in train_detector
    runner.run(data_loaders, cfg.workflow, cfg.total_epochs)
  File "/usr/local/lib/python3.6/dist-packages/mmcv/runner/epoch_based_runner.py", line 125, in run
    epoch_runner(data_loaders[i], **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/mmcv/runner/epoch_based_runner.py", line 45, in train
    self.call_hook('before_train_epoch')
  File "/usr/local/lib/python3.6/dist-packages/mmcv/runner/base_runner.py", line 307, in call_hook
    getattr(hook, fn_name)(self)
  File "mmdetection/mmdet/core/evaluation/eval_hooks.py", line 116, in before_train_epoch
    self.after_train_epoch(runner)
  File "mmdetection/mmdet/core/evaluation/eval_hooks.py", line 150, in after_train_epoch
    last_ckpt = runner.meta['hook_msgs']['last_ckpt']
KeyError: 'last_ckpt'

i

Hello,
You can use
evaluation = dict(
    ..
    metric='bbox',
    save_best = 'bbox_mAP',
    ...
)

in your config file.

it seems not only save the best model, but also save the every model after training. The best model is the soft link of the model with best bbox_mAP among all the models.

add
'''
checkpoint_config = dict(interval=-1)
'''
in your config
-1 means never save checkpoint

i

Hello,
You can use
evaluation = dict(
    ..
    metric='bbox',
    save_best = 'bbox_mAP',
    ...
)

in your config file.

it seems not only save the best model, but also save the every model after training. The best model is the soft link of the model with best bbox_mAP among all the models.

add
'''
checkpoint_config = dict(interval=-1)
'''
in your config
-1 means never save checkpoint

Thank you, but how to test your model without checkpoint?

i

Hello,
You can use
evaluation = dict(
    ..
    metric='bbox',
    save_best = 'bbox_mAP',
    ...
)

in your config file.

it seems not only save the best model, but also save the every model after training. The best model is the soft link of the model with best bbox_mAP among all the models.

add
'''
checkpoint_config = dict(interval=-1)
'''
in your config
-1 means never save checkpoint

Thank you, but how to test your model without checkpoint?
'''
evaluation = dict(
..
metric='bbox',
save_best = 'bbox_mAP',
...
)
'''
will save best checkpoint


Update ANOTHER EDEN: Add identified ACs

Game Title
ANOTHER EDEN
Game Website
https://en.another-eden.jp/
Anti-Cheat Software
CrackProof + WFSDrv (icon)
Status of the Anti-Cheat
😥 Broken
Tinkering Steps
PC port is unplayable due to WFSDrv.
Proof of Mention
https://www.protondb.com/app/1252600

@Starz0r just found out the game is already on the list so consider this issue as an update.


[ImageCard] Zoom buttons go off screen when zoomed in

From the html it looks like the zoom buttons positions are dependent on the edge of the image, not the edge of the container, so when you zoom in they go off screen.

This has been fixed. https://next.carbon-addons-iot-react.com/?path=/story/1-watson-iot-imagecard--basic The zoom buttons are now positioned absolutely relative to the container.


Add note on generating XML file if it doesn’t exist

Wow! In order to create a short, simple library for testing purposes, I created a new account on my Mac, created a simple library and playlist, then discovered there was NO .xml file in ~/Music/iTunes. Then found the Apple doc mentioned in this PR. So we can NOT assume the user has an XML file at all!


introspectTableView - background color not being set in iOS 15

I have a SwiftUI List that I am attempting to introspect so I can set the background color.  The code looks similar to this:
List {
  ...
}
        .listStyle(SidebarListStyle())
        .accentColor(.white)
        .introspectTableView { tableView in
            tableView.backgroundColor = UIColor(Color.orange)
        }

On iOS 14 this produces the desired outcome and gives me an orange background on the list.  On iOS 15, however, it does not.  I have set a breakpoint on the introspect body and in iOS 14 it is being triggered, but in iOS 15 it is not, so clearly the code is not even being called.

In iOS15 you can do this natively with SwiftUI. Just use the .background(Color.blue) modifier on the List. For iOS 14 you still need to introspect. I find it useful to have conditional backfills for this kind of thing. eg

@Utsira You may be right for the .plain list style. However, this does not work for other styles like SidebarListStyle and / or InsetGroupedListStyle.

In iOS15 you can do this natively with SwiftUI. Just use the .background(Color.blue) modifier on the List. For iOS 14 you still need to introspect. I find it useful to have conditional backfills for this kind of thing. eg
public extension View {

	func listBackgroundColor(_ color: UIColor) -> some View {
		Group {
			if #available(iOS 15.0, *) {
				background(Color(color)) // doesn't work on iOS 14
			} else {
				introspectTableView {
					$0.backgroundColor = color
				}
			}
		}
	}
}

I don't think .background() modifier on a List does what you say it does.
In iOS16 they introduced scrollContentBackground  for this.
Btw. have the same issue:
.introspectTableView { tableView in
    tableView.backgroundColor = .red
}

^ Doesn't work.

@theedov Did you find an answer?

@theedov Did you find an answer?

No, not really, I just switched to iOS16+
I think Lists are now powered by the UICollectionView instead of UITableView.  So changing UICollectionView.appearance() might work(haven't tried it).

See https://github.com/siteline/SwiftUI-Introspect/issues/110#issuecomment-1611835461 for a working solution.


FIX: Use / instead of os.sep

In _version.get_versions() the root directory is determined by splitting versionfile_source. According to the documentation this is something like package/_version.py, i.e. separated by slashes. Since os.sep is used in get_versions() this string will be splitted by a backslash which is wrong. Since most Python packages should work on Windows and Linux, the versioneer configuration should follow the slash convention to separate directories and files.

Good catch. Landed (in rebased form) in fa3e11ec


NotificationListGroup render issue without buttons

OpenUI5 version: nightly 1.45.0
Browser/version (+device/version): any
Using NotificationListGroup without buttons aggregation avoids correct floating of NotificationListItem!
https://svgimage-p1940953245trial.dispatcher.hanatrial.ondemand.com/demo/index.html
Any other information? (attach screenshot if possible)

Thank you for the ticket @hschaefer123 . I can reproduce it on my machine as well.
Issue is confirmed and tracked internally:<PHONE_NUMBER>
We'll start working on it right away.


'host' deprecated in manifest - how to emulate with 'routes' and variables?

The latest CLI is noting that host, domain etc are deprecated in manifests, and instead we should use routes. The latter routes requires a full subdomain.domain.com known in advance which is unfortunate for sample applications or "ready-to-deploy-to-your-cloudfoundry" aplications.
For example, https://github.com/cloudfoundry-incubator/stratos/blob/4e15499bb3f9cd4779f44b6e0a1388ed8aeda3f8/manifest.yml#L5
Is there an equivalent method for achieving this, whilst using routes?
If not, could I propose that cf includes some functional variables that will be calculated at cf push time if not provided by users?
E.g ((shared_domain)) could be automatically resolved to the first shared domain.
The stratos example above could then be changed to:
applications:
  - name: console
    memory: 1512M
    disk_quota: 1024M
    timeout: 180
    buildpack: https://github.com/cloudfoundry-incubator/stratos-buildpack#v2
    health-check-type: port
    routes:
    - route: console.((shared_domain))

Hi @drnic
I would have thought that the equivalent would be to simply omit host and routes attributes.
Without those, cf CLI would create & map a route for you, which consists of the app name with the first shared domain.
The idea was that most use cases would be either you want a particular route, so specify it in full under routes, or you are not too picky, in which case don't specify anything and you'll get a default route.
Note that to get no route (which has plenty of valid use cases, but in CF's world has always been a minority), you (still) explicitly set no-route: true, and to avoid clashes when teaching a class on CF and have everybody deploy the same app to the same space, you (still) use random-route: true.
Regards,
Dies

@dkoper what is/was the plan for communal apps that are deployed to many CFs across many orgs such as https://github.com/cloudfoundry-incubator/stratos/blob/v2-master/manifest.yml#L5 - here host: console means https://console.your-domain?

cc @zrob for visibility

cc @shalako @shubhaat for visibility

... I'd still want to wait on us having a good default domain story ...

Depending on implementation default domain may not play well with isolation segments or the case where different domains have different purposes.

@giner some ideas around "default domains" are being discussed in this proposal for V3 Domains.
I think the current thinking is that v3 Organizations will have a link to their default domain which will either be a global platform default or a default specific to that organization. For orgs in isolation segments operators should configure them to have a domain that is applicable for the isolation segment that the org belongs to. For different domains with different purposes, this default domain concept should still be an improvement over the CLI's current "first domain in the list is the default" approach.

Thank you @tcdowney, left a comment on the document.

Hi @drnic thanks again for reaching out. We recently sent a call for feedback about this issue. If you could please review this document, we would appreciate your feedback. Thanks.

Currently blocked on review with the CC API team, who owns the manifest in v3/v7. For routes, we'll need to think about how they are able to change the manifest since the property is a list of routes and overriding a particular route using a flag will require changes to the manifest. Also blocked on adding a host to the manifest, which will not work in conjunction with the routes property.

Hi @drnic , thanks again for this issue.
It would really help to get your feedback on the following. In a scenario where we support:

a host: property and a --host override flag on v7 cf CLI which will be mutually exclusive with the --route flag below
for the following (existing v7) manifest:

---
applications:
- name: dylan
  routes:
  - route: route.example.com
  - route: another-route.example.com

Would you require flag overrides for:

EACH route in the manifest. This would require multiple --route override flags on push.
OR the ability to override only the first route in the list. This would require only one --route override flag on push which will always override the first route in the list

If you require multiple --route flags on push, why and what are your use cases?
cc @selzoc  @ssisil  @reid47

github + projects' documentation is full of sample and shared applications for people to deploy to their own CF installations. Each CF will obviously have different shared domains.
Therefore these pre-created applications cannot include fully-defined routes in their manifest.yml.
I would like a solution to how a sample/shared application can be pushed to all CF installations without the documentation having beg the user to first "find out what your shared domain is" and then "update the manifest.yml to edit the routes". If we take our user base down this dark path of awkward tutorials, it will be upsetting.

@tcdowney I'm a little confused by your explanation; could you clarify how specifying host differs in the new world from simply not specifying any route at all (i.e. relying on the default <appname>.<primary-domain>)? It was my understanding before that specifying host just overrode the <appname> in that calculation.

@davidje13 my comment was specific to what the V3 "serverside" app manifest would do with that information. Right now the Cloud Controller API will not do anything around routes if you do not specify routes in the server-parsed app manifest. At the time I wrote that there was no concept of a "primary" or "default" domain on the API -- it was purely something that the CLI did by inferring that the first domain returned from the api was "primary."
When the CLI owned the parsing/understanding of the app manifest it did what you say.
This all has changed a bit since I wrote that comment last year. Organizations in V3 now have the concept of a "default domain" (see the link on V3 org response https://v3-apidocs.cloudfoundry.org/version/3.79.0/index.html#the-organization-object) and I could see the  serverside manifest potentially taking advantage of this information.
I don't work on the API anymore, so looping in @Gerg @selzoc who may be able to speak more on the current (and potential future) state of things.

Yes, please add a host option of some type for the v7 api so we don't need to hack it with variable substitutions. We run private instances of cloudfoundry on different servers (each with its own domain), and our apps have unique routes via <appname>.<server-domain>. Using the host: variable allows us to easily manage the route names when deploying apps to different servers with different domains.

Some work was done on newer versions of CC API with changes on manifests that allow the user to say they want a random route or if they want a default route to be created based on the name of the app. Please check https://v3-apidocs.cloudfoundry.org/version/3.178.0/#manifests for more information.
I am going to close this issue based on the above paragraph. Please check if the latest CLI v8 version addresses yll's concerns if not please create a new issue with more information.


Fix crash on addImportFromExportedSymbol with default exported symbol

Fixes #52662.
The crash was happening because we were using a filename as the name of the default exported symbol when looking up its export info, and we couldn't find it in the export info map. We were using the filename as the name of the default exported symbol because we couldn't properly get its name from its declarations, so I fixed the logic of getting the symbol name for a default exported symbol.

@typescript-bot user test tsserver
@typescript-bot test tsserver top100

@typescript-bot perf test this faster

@typescript-bot perf test this faster