Collect test coverage for reports

Hi,
I use this tool by using stylelint-test-rule-tape.
It works like a charm.
But now I want to create coverage reports with instanbul/nyc.
Unfortunately it won't detect all testet files 🤔
tap-nyc does not make a difference.

I'm not sure what you're asking, but it seems like this is an nyc question (solveable with your .nycrc) and not a tape question?

Thank you for your quick response @ljharb
Okay, maybe I'm asking this in the wrong channel.
Anyway I used instanbul/nyc without any problems with mocha, jest, ava.
But with tape, it just does not detect covered code paths 😕
And I don't get why.
I have read that node-tap hay build-in coverage support, here:
https://istanbul.js.org/docs/tutorials/tap/
But I wonder how tape is supposed to be used with nyc.

@ljharb Alright.
It seems is a regressen in nyc.
https://github.com/istanbuljs/nyc/issues/1281
I will check.

@AndyOGo try tape with v4, compared to v5?

Closing, per https://github.com/istanbuljs/nyc/issues/1281#issuecomment-619448234

Just a quick update: I have a tiny reproducible test for this now. Quite possibly the issue is on the nyc side of things but basically nyc no longer works with either Tape 4.11.0 or 5.0.0:
https://github.com/istanbuljs/nyc/issues/1281#issuecomment-630273102

Per https://github.com/istanbuljs/nyc/issues/1281#issuecomment-630333743, seems like it was an issue with your machine and nyc, and not tape?

@ljharb It was apparently even more niche than that :) It fails if the Node.js binary is granted permissions to bind to ports < 1024 on Linux. I documented it here: https://github.com/istanbuljs/nyc/issues/1281#issuecomment-630333743


Ghidra applies decompilation analysis even when disabaled

Describe the bug
When all function decompilation analysis options are disabled ghidra applies decompilation analysis anyway.
To Reproduce
stack0.zip
In main rename stack local_54 to anything.
Variable assignments and predicates change
Expected behavior
The variable is renamed and nothing else happens.
Screenshots

Environment (please complete the following information):

Ubuntu 18.04
Ghidra public 9.0

entry point values int ==1  would it be this?


Use the latest history page designs and copy

make the search box look as intended
readd the show-hide code and make it work in IE8
fix the search box markup to make changes easier
remove unnecessary table columns
add tests

v minor, but webpack is complaining about console in line 1 of mtp_cashbook/assets-src/javascripts/main.js


add CFF (citation file format) file

Is your feature request related to a problem? Please describe.
its related to citation for the AMUSE
Describe the solution you'd like
add CFF file (citation file format file: https://github.com/citation-file-format/citation-file-format) with the
references for AMUSE code papers. (not references for the community codes)
Describe alternatives you've considered
The default citations only show up after using AMUSE. CFF files are also used by automated tools to generate citations
Additional context
CFF are an emerging standard for software citations. I am no particular fan of the format itself (doesn't look very elegant), but if this is what other people are using...

Seems good to have something like this.
Perhaps we could additionally generate bibtex files with ADS entries?
We could easily get those for all the citations that are currently printed.

fixed by #311


PhoneGap: View.updateIndex() is too slow

This issue is originally posted on Couchbase Mobile Google Group.
https://groups.google.com/forum/#!topic/mobile-couchbase/urIqcOocmq4
Few days back you had given me a updated build of cblite phonegap plugin which improved the view performance for android. I reported that it took around 7 seconds initially to index about 150 docs but then it dropped to milliseconds.

Seems like i judged it very early and with only a particular type of docs. I changed my document and added a few more fields to make it little big. I added around 100 docs on a click of button to cblite and then performed a view query. It took around 2.2 - 2.5 seconds for android to index that view first and then return the data. This time interval is very long for the users of my application. Every time i add 100 docs and then query the view, it takes about that much time to return the data.

Now my application involves modules wherein i need to call 2-3 different views after adding about 12 or more docs. Now it takes 400 ms for android to index the view after adding 10 docs (the view which i am talking about here is a simple view with just a emit, no reduce or heavy emit's. If  view has a reduce function or some complex emit structure then the above times mentioned are even more higher). So when all my view are called one after another the time adds up and it takes about 5 seconds for my views with reduce function to return data from cblite.

Also there are many other screens which involve calling multiple views and whenever and significant change is made to db, the first query thereafter to all these views take time and when u add up the time it is in seconds.

Speaking from a user perspective i cannot make the user wait for those many seconds every time they create new records and hence the app becomes unusable on android.

Same app on ios indexes views in milliseconds. Even for 100 docs inserted , a view query takes anywhere between 150 ~ 200 milliseconds to index and return data. 2200 ms and 200ms. Thats a difference of 2000 ms between ios and android. You can check the same in your todo lite phonegap app which i have modified to show my stats. I am attaching the source code dropbox folder link here. You can download the app and run tests on it.

I know the performance you get on iOS will not be matched on android due to fundamental differences but what i need to find out that is there any way possible to make performance on android relatively close to iOS if not match it. Can we do something to bring the view indexing time down. Are we doing anything fundamentally wrong while working with cblite ? maybe you can look at the ToDoLite code and help us out somewhere.

I am letting my environment know under which i got the view indexing times

FOR ANDROID
Device  - Moto G 1.2 Ghz quad core running android 5.0.2
Ram - 1 gb
view index time for 100 docs - around 2.2 secs
view index time for 10 docs - around 400 ms

FOR IOS
Device  - Iphone 5s with ios 7
view index time for 100 docs - around 150ms
view index time for 10 docs - around 20 ms

The cblite plugin used for above test was taken from the below link which u gave earlier.

http://cbfs-ext.hq.couchbase.com/builds/Couchbase-Lite-PhoneGap-Plugin_1.0.4-47-63.zip

Todo Lite Source code link

https://www.dropbox.com/s/xmiip8fbugh6682/ToDoLite%20%28copy%29.tar.gz?dl=0

Awaiting your feedback !
Thanks !

Test results:

Performance measured by ToDo Lite Sample which was modified by customer
https://www.dropbox.com/s/xmiip8fbugh6682/ToDoLite (copy).tar.gz?dl=0

Test platforms: I used iOS simulator and Genymotion simulator

Measure elapsed time for 100 docs insertion and 100 doc indexing

Result

Platform
iOS
Android

Insert 100 Docs
27ms
239ms

Index 100 docs
18ms
473ms

Sample Document from code

{
                    amt: i,
                    channels<EMAIL_ADDRESS>                    clear: true,
                    createdAt: "2015-05-07T08:11:51.974Z",
                    creditAccount: "Checking",
                    creditAccountKey: "aa019602-da64-4a0f-8dec-5ab18b3f03ff",
                    creditCat: "Cash & Bank",
                    creditSubCat: "",
                    date: "Wed May 13 2015 00:00:00 GMT+0530 (IST)",
                    debitAccount: "Charity",
                    debitAccountKey: "84dbde7b-3165-4c4c-9292-f636cc524093",
                    debitCat: "Expense",
                    debitSubCat: "Activities",
                    isBill: false,
                    memo: "",
                    notificationInfo: {
                        daysBefore: null,
                        notifications: null
                    },
                    parentCycle: null,
                    parentTransactionId: null,
                    repeat: null,
                    split: null,
                    totalAmt: null,
                    tranType: "Expense",
                    type: "trans",
                    unclearedAmt: null,
                    updatedAt: null
}

NOTES: JSON's string values contain only ASCII characters. So, slowness might not come from JSON collator.

@hideki Have you tried using traceview to check which functions are taking most time?
Basically you surround the method call with:
// starts tracing to "/sdcard/indexing.trace"
// You need android.permission.WRITE_EXTERNAL_STORAGE
Debug.startMethodTracing("indexing");
view.updateIndex();
Debug.stopMethodTracing();

You can open the file with Eclipse or the device monitor.

@sergio91pt, Thank you very much for your advise. I have not used TraceView. I will try it.

:+1: glad to hear there's a good time-profiling tool for Android. I've sped up the iOS/Mac version a lot using similar tools.

Note to Self:
Actual command we are tackling
10.5.4. /db/_design/design-doc/_view/view-name

http://docs.couchdb.org/en/latest/api/ddoc/views.html

Additional test result
Original test tool on Nexus  6

action
1st
2nd

100 docs insertion
332ms
366ms

100 docs indexing and query
1981ms
1928ms

100 docs query
71ms
59ms

Applied PR on Nexus 6

action
1st
2nd

100 docs insertion
345ms
338ms

100 docs indexing and query
325ms
315ms

100 docs query
49ms
52ms

Original test tool on Genymotion

action
1st
2nd

100 docs insertion
272ms
221ms

100 docs indexing and query
470ms
471ms

100 docs query
58ms
61ms

Applied PR on Genymotion

action
1st
2nd

100 docs insertion
261ms
238ms

100 docs indexing and query
282ms
247ms

100 docs query
53ms
56ms

NOTE
From above test result, applying PR makes indexing operation around 6 time faster with the test tool this test is using.

I noticed you referenced a pull request which has made some improvements and your test result shows them.
@hideki I would just like to know when do you intend to merge the PR and consequently the plugin can be updated. The urgency on my part is partly because the application which is using this plugin is live on the Android Play Store right now and it would help us tremendously on the performance front if we can reduce the indexing time in the app.
Thanks again a lot for the help.

Hi @vinaynb,
Accepting community developer's PR might take a time. Meanwhile, you can build from his source codes https://github.com/couchbase/couchbase-lite-java-javascript/pull/10 .
Thanks,
Hideki

UPDATE
I built the source code from the PR and the indexing time are slashed by 6x !!
The plugin seems to be working fine with the modification no issues reported till now.
@hideki thanks for the help..is very much appreciated and i hope the PR is merged so that other developers who are in search of performance can have the updated plugin.

Hi @vinaynb,
Thank you for your updates. I am glad to hear your app's indexing speed improved 6 times. We are working for merging the PR. But the process is taking the time.

PR was merged. JavaScript map/reduce could improve its performance around 6times.


refactor(transformer): introduce TransformCtx::duplicate_expression

#7745
#7757
#7756
#7755
#7754  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Support production profiling with React Developer Tools

Closes #7734.
Some of the process I went through to test the changes include the following:

I ran yarn test

After I ran yarn build

Following this, I ran yarn create-react-app my-app built a small (very small) app
to test the react devtools profiler and source code

Source Code ClassName:

Looks like this needs to rebased on master.

Do you mean to before I changed it and caused the merge conflict?

Do you mean to before I changed it and caused the merge conflict?

If you revert it to whats in master then we shouldn't see any changes for that file, just the webpack config should show a diff.

Do you mean to before I changed it and caused the merge conflict?

If you revert it to whats in master then we shouldn't see any changes for that file, just the webpack config should show a diff.

I was able to revert the file to the master branch yarn.lock.cache to the previous state on commit
e0719e4c5f00d2870ae16a2b57a00c66941ea429

This is great 💯

What about yarn profile or yarn build --profile? Not sure I'm a fan of using an env variable here.

I suggested the env variable because I didn't expect this to need a special script or flag. But I'm fine either way :) I just want it to be reasonably possible.

What about yarn profile or yarn build --profile? Not sure I'm a fan of using an env variable here.

@gaearon what could be some potential pitfalls or anything else you can think of, for not doing it this way? Just curious and trying to understand where you are coming from on this 😄

This is slick 👍
I also think yarn build --profile (or similar, command flag) would be preferable to an ENV var.

This is slick 👍
I also think yarn build --profile (or similar, command flag) would be preferable to an ENV var.

I will work on figuring out how to accomplish it this way then.
I appreciate your input and suggestions @gaearon @bvaughn

I think you should be able to get it with process.env.argv.includes('--profile')

I think you should be able to get it with process.env.argv.includes('--profile')

I just came back from lots of Googling to see this and had come up with something similar. That makes me both super proud and extremely surprised.
Thank you very much for your help @kentcdodds 🎉 😃

Once this lands, let me know and I can add it to https://fb.me/react-profiling as well.

@ianschmitz I added what you suggested for potential documentation to the section you mentioned

React DOM automatically supports profiling in development mode for v16.5+, but since profiling adds some small additional overhead it is opt-in for production mode. You can opt-in by using the --profile flag. Use npm run build -- --profile or yarn build --profile to enable profiling in production mode. You can read more about profiling using the React DevTools here: https://reactjs.org/docs/optimizing-performance.html#profiling-components-with-the-devtools-profiler

If anyone has other suggestions or ideas I am more than happy to proceed with further changes or discuss further changes.
Thank you for the help and suggestions so far everyone! 😄

@kentcdodds @bvaughn This change is released now in v3.2.0.

Thanks a bunch!
Docs have been updated:
http://fb.me/react-profiling#create-react-app-v32


Support for easy certificate pinning

Hey,
certificate pinning has become more and more important. But sadly it's still very complicated to do in IOS. So i was hoping you would like to implement a simple abstraction around cert pinning in SwiftHTTP.
What are your thoughts on the topic?
Thanks and greetings
Leo

I would like to see SSL pinning added to SwiftHTTP. I personally haven't had the time to research and implement a solution yet, so Pull Requests are welcomed.

Hahaha, i can give it a shot but i actually was asking you for the feature because i failed in my first trail g It's so complicated to get right, i actually think Apple does not want it's users to pin there certs. But i will give it a try in the next few days.

ah, ok, makes sense, no worries then :smile:. I want to look into it in the near future so if nothing comes together in the next few days, I will start working on it soon.

There are actually a lot of things to keep in mind while doing it. Some implementations just include the fingerprint of the cert and then check it. Some people embedd the entire cert and then fingerprint it on the fly.
Another thing to keep in mind is if you allow to pin multiple certs. Because if you pin one cert and it expires it would render all non-updated apps broken. Just because they have not had time to install the update yet. So maybe it should be possible to pin multiple certs so if i know my cert expires in 3 months i deploy and update containing the upcoming cert and the current one.
Thats just a few things i thought about while trying to implement it.
Greetings
Leo

@daltoniam,I am really appreciated to use this Library.It was perfect Lib and easy to use.If you dont mind,can u do the support for HTTPS?Thank you.I am also newbie to Swift,too.

@LeoUnglaub thanks for the notes, I will keep that in mind. @htarwara6245 I hear ya, I will get the SSL pinning done as time permits.

Alright folks, I have something checked into the master branch for SSL pinning. I don't have a easy way to test it, so I am hoping y'all can help me out :smile:.
https://github.com/daltoniam/SwiftHTTP#ssl-pinning
I haven't created the 0.9.5 yet, as I want to much sure this works first. Please test from the master branch and then we can create the stable 0.9.5 once we are happy.

Hey,
i was trying the current version in my project but do to some other change in the failure callback i was unable of compiling it. But the cert pinning parts looks good as far as i can tell.
I am going to report back as soon as i have figured out the other issue.
Thanks and greetings
Leo

tag 0.9.5 released!


371-MOFs

请问由三位化学家标注的371个MOFs材料的水稳定性数据集在case sudy3的哪一个环节被用到？
May I ask which part of case sudy3 is used in the water stability data sets of 371 MOFs materials labeled by three chemists

Hi. I'm not sure if I am understanding your question. Could you elaborate?

Closing due to no activity.


ADR 110: Remote mempool

Per recent discussions surrounding the default mempool in Comet and its flooding gossip mechanism, this ADR is proposed to allow application developers to build their own mempools (or mempool clusters) that reside in entirely separate processes with a simple, standardized interface.
:book: Rendered
Currently in early draft for review. TODO: Create a tracking issue for the ADR if the team decides it's a good idea to go ahead with this.
cc @zmanian @ValarDragon @bpiv400

PR checklist

[ ] Tests written/updated
[ ] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

https://github.com/cosmos/security/pull/19

https://github.com/cosmos/gaia/pull/2767

https://github.com/cosmos/ibc-go/issues/4859

https://forum.cosmos.network/t/amulet-security-advisory-for-cometbft-asa-2023-002/11604/21?mobile_view=0

https://acrobat.adobe.com/id/urn:aaid:sc:AP:a4848a0c-3f78-4e08-872a-843147955a0c

@faddat continued spamming of our team or off-topic comments will result in you being blocked from our GitHub organization.

I'm very grateful for this ADR.

It's clear signal to builders that the built in mempool is more like a preproduction convenience than a serious system and that they will have to budget time and effort to write an appropriate solution for their chain.

I think the emergence of a cottage industry of alt transaction system will be hugely beneficial to the cosmos ecosystem.

This is also a clear indication that transaction propagation is not part of the liveness goals of the Comet system and that enables Comet devs to sacrifice the mempool system to protect consensus and block propagation liveness

@thanethomson Sir, can you please cite examples of where you feel I have been spamming, harassing, and abusing your team?
I think then I posted a bunch of links that show why we are removing the mempool and sir I believe strongly that why actually does matter.
Your behavior and the behavior of others that informal systems, like your CEO Ethan, Is nothing more than retaliation against those reporting security issues. I assume that your intent is to attempt to create chilling effects, to ensure that others do not report security issues. Of course, we have seen over time that it doesn't matter if you report security issues, ICF and informal will leave the vulnerabilities in place. As obviously, you must be aware that the first time that I reported this issue was in 2021.
I was and I remain quite surprised that this was placed here without any context whatsoever on why we are suddenly removing the mempool.
If you feel that reporting security issues constitutes harassment, I want no part in this software

Hey @zmanian you see any harassment here?
Did my reproduction of the problem result in this PR?

@faddat if you wish to discuss Comet's security processes, such as clarifying how to submit a singular clear, concise vulnerability report that exclusively relates to Comet, please open a new dedicated GitHub discussion topic. If you want to discuss our spam/harassment policy and specific instances of spam/harassment, open a separate discussion topic. This PR is not the place for either such discussions.
Continued off-topic comments or rants will result in you being banned from this org. This is your final warning.

hey pad here - i've found more blockchain exploits than anyone breathing
what's going on here? censorship? i don't care if this is "off topic" answer me

https://github.com/cometbft/cometbft/issues/1571

Please ban me.  @thanethomson I did exactly as you asked.
#1571
Absolutely no point to my participation here. I will take it up with people who are actually interested in solving these issues.

Would it be correct to understand that

all mempool-related functionalities are moving out of CometBFT
the said new mempool implementation is of Application's concern (i.e. whether how CheckTx works, potential parallelization, separate MempoolRouter service impl etc)
the only interface between Proposer's CometBFT instance to the new mempool impl is RemoteMempoolService, which can be anything as long as the interface matches?

IIUC this should lead to better customisability. Transactions are app's concern anyways especially because any validation has to go through application. Like... even PBS is possible 👀

This is great and aligns well with the direction we (Astria) have been looking towards, we'll be planning to work on a Rust implementation of this. The desired architecture for a scaleable mempool sounds very similar to a service mesh and both Istio and Linkerd are potentially useful prior art.

the only interface between Proposer's CometBFT instance to the new mempool impl is RemoteMempoolService, which can be anything as long as the interface matches?

There's a new proposal https://github.com/cometbft/cometbft/pull/1585. We've realized that the interface is not needed.


Incomplete tests crash Test Results screen

When there are results with {is_done: false}, the Test Results listing screen crashes because the incomplete tests appear on top of the older test in the results array and breaks the chronology of the tests.

@hellais A broader question is how do we want to show incomplete tests in the 'Test Results' screen. On mobile, we show it along with the other results with N/A in the preview.
On CLI, ooniprobe list --batch doesn't count incomplete tests towards total_tests in result_summary

I think that ideally we would handle the termination of tests in a more graceful way and in any case have some logic as part of probe-cli that does a cleanup of the database so that it doesn't leave broken/unreadable files lying around.
This is related to: https://github.com/ooni/probe-cli/issues/76


[wip] feat(iroh-sync): store peers per doc

Description
testing the waters, the store is hella confusing
Notes & open questions

Change checklist

[ ] Self-review.
[ ] Documentation updates if relevant.
[ ] Tests if relevant.

test is meh right now but would like an opinion on the core @Frando thanks for the patience, sync and redb are both foreign to me


Add six dependency.

|Add the six dependency also in the setup.py so that you don't need to install six manually and everything works fine with just pip install soundcloud.

This fixes #65 as well (mentioning it so that people who see that issue don't miss this pull request).
As the person who introduced this issue (in 8f6e83f68d00334342c1e2b4107b60ce3c264be4), this pull request gets a :+1: and :clap: from me.

This will indeed fix the import problems.


Parser for EML Mime Mail messages

Could it be possible to have a parser for .eml mail messages ?
These mails are multipart mail messages. They can embed binary attachments (PDF, DOCX...) and plain text or HTML bodies. I think the parser has to render all the parts recursively.
Return-Path<EMAIL_ADDRESS>Received: from localhost.localdomain (localhost.localdomain [<IP_ADDRESS>]) by remote.lan (Postfix) with ESMTP id 228221501B4; Wed, 11 Feb 2015 08:26:28 +0100
From: "myself"
<EMAIL_ADDRESS>User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101
Thunderbird/24.8.0
MIME-Version: 1.0
To<EMAIL_ADDRESS>Reply-To: "Me"<EMAIL_ADDRESS>
This is a multi-part message in MIME format.
--------------060902060407060800020405
Content-Type: multipart/alternative;
boundary="------------060706000202070604060404"

--------------060706000202070604060404
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

mail body here

--------------060706000202070604060404
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">   <span ....
--------------060706000202070604060404--

--------------060902060407060800020405
Content-Type: application/pdf;
name="=?ISO-8859-1?Q?-_NE_Limiter_la_pratique_de_l=27envoi_?=
=?ISO-8859-1?Q?de_mails_34=29=2Epdf?="
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename*0*=ISO-8859-1''%38%34%31%36....
filename*1*=%38%34%31%36...;

JVBERi0xLjQKJcOkw7zDtsOfCjIgMCBvYmoKPDwvTGVuZ3RoIDMgMCBSL0Zp
bHRlci9GbGF0ZURlY29kZT4+CnN0cmVhbQp4nK0cyY7juvHeX+FzgJ6wuIkC

......
--------------060902060407060800020405--

Thanks

We made an initial implementation. The recipients, subject, html and plain text body are extracted.
We are working on the attachment now.


Can I use this Library to connect to Unix Domain Socket.

Hello,
I am looking for some java library to connect to a process(daemon) which is listening on a unix domain socket. Not sure if this library can be used for that. Apart from that I am currently using JUnixSocket to write and read through the socket, but the read is causing the CPU spikes as it waits for the daemon to return the data back and at that that it keep blocked on the read() function.

Hello @princrai,
as far as I know this is not possible.
This library implements RFC 6455 and to my knowledge there is now way to access a IPC socket using websockets.
Best regards,
marci4

Apparently node.js supports this. See this question on stackoverflow. They are using a cool syntax for the url: var client = new ws("ws+unix:///tmp/server.sock")

Is this issue solved for you?
Best regards,
marci4

I am trying Netty library to connect to Unix Socket. And getting some good
result(latency,throughput).
Thanks,
Prince
On Tue, Jul 3, 2018 at 1:05 PM Marcel Prestel<EMAIL_ADDRESS>wrote:

Is this issue solved for you?
Best regards,
marci4
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TooTallNate/Java-WebSocket/issues/716#issuecomment-402277030,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL5Glb0goaEE4LbClNt6UXdutk7Tmqf6ks5uC86hgaJpZM4UT_28
.


powertop

This looks like a great project. Are you also going to optimize the system for low power usage? In a typical Ubuntu setup you can save a lot using powertop

The powertop utility seems to be included by default in my k3os-v0.8.0 iso and most optimizations could be made persistent by just adding sysctl values in ones config.yaml.
But, If I am not mistaken, /proc/timer_stats seems to be disabled in the kernel and so powertop does not really work as well (https://elinux.org/Kernel_Timer_Systems#.2Fproc.2Ftimer_stats)
myhost [~]$ sudo ls /proc/timer_*
/proc/timer_list


ROS2 CI

I'm going to enable CI on this for ROS 2 with travis and appveyor.

+1

This isn't ready for review.

These are all failing, but in ways I'd expect them to without https://github.com/ros/class_loader/pull/27, so I'll merge and rebase #27.


[FR] Support for AWS DocumentDB

Is your feature request related to a problem? Please describe.
Ability to manage the lifecycle and credentials used by applications that make use of a DocumentDB instance in AWS.
Describe the solution you'd like
Ability to create delete and bind to a Document DB service instance similar to postgres or mysql.
Describe alternatives you've considered
Using terraform directly to manage database lifecycle however credential creation on an app by app basis
Additional Context
Teams are branching out and making use of newer data services provided by Amazon and this fits the bill for those that where using MongoDB in the past.
Priority
Medium
Priority Context
Team is currently developing an application that makes use of this DocumentDB currently and would be looking to roll to production in the Jan/Feb timeframe of 2021.
Platform
AWS
Applicable Services
n/a

Hey Bryan, I have flagged this as "good first issue."
This would be a fantastic opportunity for someone on your team to leverage the Brokerpak Dissection and get their hands dirty. Contribution would find a welcome home!
If this is a blocker to your adoption of CSB, please reach out.

Challenge accepted!

Hi @adampeklay, if you are looking into contributing to the brokerpak, we have very recently created a few tutorials on how to get started. Do not hesitate to reach out either here or at our cloud foundry slack channels #cloudservicebroker and #wg-service-management

Two years on, are there any plans on the CloudFoundry side to release an update for this brokerpak that includes DocDB?   I've inherited the above "accepted challenge" on our behalf and it's not proving to be a quick job.  We'd like to avoid any duplicated efforts.  Thanks in advance!  Aaron @ Smarsh

Hi @aaronclements, we have plans to address this in the second part of the year, however we cannot make any promises as priorities might change. You could try to create your own brokerpak or add the service to this brokerpak and contribute it back. For both scenarios I recommend looking into the tutorials mentioned above, specifically the one about creating your own brokerpak.
We are happy to help and we welcome any feedback that could ease the learning curve to contribute.


Encode by this lib,can't be decode by java lib

Encode by this lib,can't be decode by java lib,version 0.6.12

You need to show your input data, or encoded data, if you want any comments.

The result is Uint8Array after encode by js-lib,But decoding in java need a byte,How  js-lib encode it to  Int8Array？

Uint8Array is just an array of bytes.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Uint8Array

For js：

var source = {userId: 18662, grade: 66, nickName: 'qwe'};
var uint8Arr = msgpack.encode(source);
console.log(uint8Arr instanceof Uint8Array);// print: true
console.log(uint8Arr);// print:[131,166,117,115,101,114,73,100,205,72,230,165,103,114,97,100,101,66,168,110,105,99,107,78,97,109,101,163,113,119,101]
For Java：
SimpleObj obj = new SimpleObj();
obj.setUserId(18662);
obj.setGrade(66);
obj.setNickName("qwe");
MessagePack pack = new MessagePack();
byte[] bs = pack.write(obj);
System.out.println(Arrays.toString(bs));//print: [-109, -51, 72, -26, 66, -93, 113, 119, 101]
How can I transfer the data and decode it between them?

Try http://kawanet.github.io/msgpack-lite/ and ask it to Java lib maintainer.
 [-109, -51, 72, -26, 66, -93, 113, 119, 101] represents an array:
[
  18662,
  66,
  "qwe"
]

[131,166,117,115,101,114,73,100,205,72,230,165,103,114,97,100,101,66,168,110,105,99,107,78,97,109,101,163,113,119,101] represents a plain object:
{
  "userId": 18662,
  "grade": 66,
  "nickName": "qwe"
}

Excuse me,so is there a right way to encode or decode the binary data cross js and java?


[CP Staging] fix: app crash when we save the user search value and reset the app

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/49249
PROPOSAL: https://github.com/Expensify/App/issues/49249#issuecomment-2352490236
Tests

Go to Search page > Chats
Click on Filters > Select some users for From field and save the search
Reset cache and restart
Verify that app doesn't crash

[x] Verify that no errors appear in the JS console

Offline tests

None
QA Steps

Go to Search page > Chats
Click on Filters > Select some users for From field and save the search
Reset cache and restart
Verify that app doesn't crash

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/user-attachments/assets/ef59ac86-701b-4805-91c7-4c5d0314cd2a

Android: mWeb Chrome
https://github.com/user-attachments/assets/30a4fed8-1681-4693-a633-3057928751d2

iOS: Native
https://github.com/user-attachments/assets/720f8c15-a4c2-4b0f-b7c9-6d8437eaab5f

iOS: mWeb Safari
https://github.com/user-attachments/assets/ae67fe6f-ed2c-444c-81e4-f2dac23449b0

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/1d740e08-2937-40c4-ae8c-13f3a22e0eb6

MacOS: Desktop
https://github.com/user-attachments/assets/1ff08e8f-1dfb-4bc2-860a-5004ab737110

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Merging it @techievivek as this is a minor change, the bug has been properly tested by a C+, and it fixes a blocker.

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.35-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Hi team! Can you check this GH to see if it's a regression @DylanDylann @techievivek @lakchote

🚀 Deployed to production by https://github.com/grgia in version: 9.0.35-7 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Hi team! Can you check this GH to see if it's a regression @DylanDylann @techievivek @lakchote

It doesn't look like a regression if we're basing ourselves on what was reported by a C+ here


Preact support

I think that your library don't work with Preact JSX only with react because it relay on internals of React.
I've created basic example with Preact (sorry no JSX but it shouldn't matter the code is the same)
https://codepen.io/jcubic/pen/PobgJPM?editors=0010
but got error "rectangle" is not registered in 'withInstructs' at composeFromJsx(jsx, withInstructs) function
I use almost the same code as your basic JSX example but I used Preact instead of React.

Thanks for providing me the example. I just realized that JSX implementation on React and Preact are quite different. Let me add JSX implementation support for Preact.

The way it's handled by Babel that transform JSX is that they use Pragma that allow to use different function in Preact the name is h and in React it's React.creteElement. I'm not sure if there are other differences please let me know if there are other differences. In my projects I Use SXML I use lisp on top of JavaScript, I would to know if there are other differences that I need to handle properly.

Hi, this issue can be solved if you use Rectangle in your code instead of rectangle over here:
const composed = compodraw.composeFromJsx(
    h("Rectangle", {x: 210, y: 170, width: 200, height: 150}),
    instructs
);

You need to do this because window['compodraw-instructs'] contains an object of instructs, and the instruct it contains is Rectangle instead of rectangle, thus while evaluating Compodraw looks for the instruct, rectangle and it does not find this instruct, raising the error.

I was able to update my demo, with Preact. I'm wondering if it will work if you use JSX+Preact because the example use rectangle not Rectangle.

You could try using JSX and Preact, but I think you would have to use Rectangle instead of rectangle. As far as I know, it should work with Preact and JSX. Anyway, you should be good to close the issue, if you don't have any other issue.


Thermostat Card Clipping (Font scaling)

Hello,
I just wanted to point out that the thermostat card does not play well in a horizontal stack with any small browser window (really mobile is where I see it the most).  Just feel like at least it should not clip out the bottom buttons but should still be able to be stacked horizontally.  Doesn't make sense for this to be one of the exceptions.
https://imgur.com/a/nPr24VH

This is fixed now, I believe

It is much better than it used to be.  I still get a slight clipping on the bottom for a normal window.  But I can also really screw with it if the window gets tiny.  Not sure if that should be looked at or not, cause I really had to make it small to get there.  Here are the two pictures I took, the first one is what I see on mobile, the second is what I got to look wonky.
https://imgur.com/cZ15iPr
https://imgur.com/DY9BReL

Unfortunately, there are still issues with the thermostat card.

The config I have is really simple:
type: vertical-stack
cards:
  - cards:
      - entity: climate.study
        type: thermostat
        name: Kuchnia
      - entity: climate.study
        type: thermostat
        name: Sypialnia
    type: horizontal-stack
  - cards:
      - entity: climate.study
        type: thermostat
        name: Pokój dzienny
      - entity: climate.study
        type: thermostat
        name: Korytarz
    type: horizontal-stack

When You have 2x2 grid with thermostats it looks quite good on PC (Win10 Chrome 76), but on mobile, it looks terrible:

is there a chance to fix the cropping issue? Also, can the thermostat card adjust font size based on its size?
I manually changed the font size in cards and it looks much better (two bottom left cards):

@iantrich  Can the font size be dynamic? Based on card size?

Any update on this issue?

@iantrich font isn't the only issue. here is also unneeded padding for modes class when ha-card has small class. This should be a very simple fix -quick-change in CSS rules.

PRs welcome 😁

I'd like to help, but I use Windows and from all the descriptions it is hard to get frontend development up and running on Windows.
Padding can be easily solved by replacing this line: https://github.com/home-assistant/home-assistant-polymer/blob/dev/src/panels/lovelace/cards/hui-thermostat-card.ts#L558
so instead:
.modes {
  margin-top: 16px;
}

You will have:
.large .modes {
  margin-top: 16px;
}

this way padding will be added only to large view.
I'm not sure about font-size, because it would be better to change that in the code and then look at demo site.

@Misiu I used to do HA frontend work on Windows. The easy way to do that is to install WSL.
You could also do it in a virtual machine or dual boot to Linux.
I currently have dual boot setup on my PC. Linux is free and easy to setup and makes dev work a breeze, so highly recommend it to anyone. You can PM me on Discord if you want to dive into it.

@iantrich thank for offering help.
Give me some time, I have a deadline on a project (that involves Home Assistant). When I finish it I'll have some free time so we can get back to this then. I need roughly one, maybe two weeks.


Problems Mounting NFS volumes

Rancher OS amd64 4.14.32-rancher2
RancherOS v1.4.0
VMWare
Sometimes NFS volumes mount perfectly fine, other times...
MountVolume.SetUp failed for volume “pvc-dba9311c-a7c4-11e8-b39a-00505685234f” : mount failed: exit status 32 Mounting command: mount Mounting arguments: -t nfs la-6pnasvmnfs02.internal.ieeeglobalspec.com:/k8s_vols/qt_cluster_max_test/zabbix-zabbix-4-web-nginx-nfs-pvc-dba9311c-a7c4-11e8-b39a-00505685234f /opt/rke/var/lib/kubelet/pods/46471c56-a7cc-11e8-b39a-00505685234f/volumes/kubernetes.io~nfs/pvc-dba9311c-a7c4-11e8-b39a-00505685234f Output: mount.nfs: rpc.statd is not running but is required for remote locking. mount.nfs: Either use ‘-o nolock’ to keep locks local, or start statd.
If I set a mount option of nolock on the volume:
MountVolume.SetUp failed for volume "pvc-b9b65f81-a7cf-11e8-b39a-00505685234f" : mount failed: exit status 32 Mounting command: mount Mounting arguments: -t nfs -o nolock la-6pnasvmnfs02.internal.ieeeglobalspec.com:/k8s_vols/qt_cluster_max_test/zabbix-zabbix-4-nginx1-nfs-pvc-b9b65f81-a7cf-11e8-b39a-00505685234f /opt/rke/var/lib/kubelet/pods/a9d7d0ad-a7d5-11e8-b39a-00505685234f/volumes/kubernetes.io~nfs/pvc-b9b65f81-a7cf-11e8-b39a-00505685234f Output: mount.nfs: access denied by server while mounting la-6pnasvmnfs02.internal.ieeeglobalspec.com:/k8s_vols/qt_cluster_max_test/zabbix-zabbix-4-nginx1-nfs-pvc-b9b65f81-a7cf-11e8-b39a-00505685234f
This is after rebooting the worker node as well.  Two other pods with PVC's on the same NFS export are working well.
I was able to successfully bring up the PVC (read/write many) on the pod once. I then tried to scale out and add a node, then got the above error on the second pod.    I then rebooted the worker node and got the first error immediately upon restart.
Doing a mount and grepping for the volume shows nothing mounted.
Trying to mount it from the command line fails with permission denied or
[rancher@la-1tkube-w2 docker]$ sudo mount -t nfs -o nolock la-6pnasvmnfs02.internal.ieeeglobalspec.com:/k8s_vols/qt_cluster_max_test/zabbix-zabbix-4-nginx1-nfs-pvc-b9b65f81-a7cf-11e8-b39a-00505685234f /opt/rke/var/lib/kubelet/pods/a9d7d0ad-a7d5-11e8-b39a-00505685234f/volumes/kubernetes.io~nfs/pvc-b9b65f81-a7cf-11e8-b39a-00505685234f
mount: mounting la-6pnasvmnfs02.internal.ieeeglobalspec.com:/k8s_vols/qt_cluster_max_test/zabbix-zabbix-4-nginx1-nfs-pvc-b9b65f81-a7cf-11e8-b39a-00505685234f on /opt/rke/var/lib/kubelet/pods/a9d7d0ad-a7d5-11e8-b39a-00505685234f/volumes/kubernetes.io~nfs/pvc-b9b65f81-a7cf-11e8-b39a-00505685234f failed: No such file or directory
Any ideas?  This doesn't seem like a usable option for persistent storage right now.

@rootwuj
Is there still a problem switching to the Ubuntu console?
I suspect that it is caused by the default console cleanup data after reboot.

@niusmallnan
Yeah, I am testing on the ubuntu console. I will have this issue when I reboot node.

Have been facing the same issue on proxmox vms.


Update url.pushTo and url.replaceTo update only on dev.

In order to warn the user, now we are using a warn function
which is located in the lib/utils module.

Coverage increased (+0.09%) to 58.501% when pulling 1e333a09710c064b8393a14d421b0ea23a73ada1 on arunoda:warn-push-to-only-in-dev into e45cc89ce3c02c91418e473971c2191a874d2c0e on zeit:master.

Coverage increased (+0.09%) to 58.501% when pulling 1e333a09710c064b8393a14d421b0ea23a73ada1 on arunoda:warn-push-to-only-in-dev into e45cc89ce3c02c91418e473971c2191a874d2c0e on zeit:master.


Config for CircleCI

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9c2e917). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             master    #2   +/-   ##
======================================
  Coverage          ?   50%
======================================
  Files             ?     2
  Lines             ?     8
  Branches          ?     0
======================================
  Hits              ?     4
  Misses            ?     4
  Partials          ?     0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c2e917...e078482. Read the comment docs.


Make ChasmClassWriter and co more lenient

Right now, the class writer essentially requires a fully specced node to create the classes.
It would be better if certain fields that are optional can be omitted.
For example, fields currently have 7 nodes:

access modifier
name
descriptor
signature
value
annotations
attributes

Only access, name and descriptor are required, and ChasmClassWriter should simply provide defaults for the others if they are missing.

Implemented with #22


fix: service config listener check should check ExporterListener

What is the purpose of the change
<dubbo:service listener="xxx" />  , AbstractServiceConfig should check ExporterListener ,not InvokerListener

this issue has been addressed by 04c93e8b98250230c4d22423372acd1c29e2c770, pls. check.


Document use of key parameter to allow choosing language served by the Google Maps API script

The Google Maps API supports specifying a language for use with the API. This is great to prevent having multiple languages around a website, which happens when using a different language on the browser than the used on the website.
Problem
This library currently does not specifically support specifying parameters for the loaded script, which is used to specify a language for the script.
<script src="https://maps.googleapis.com/maps/api/js?key=YOUR_API_KEY&callback=initMap&language=ja&region=JP"></script>

I have no concrete proposition on how it should be presented in this library's API, but it looks like this would be a breaking change, unless the second parameter is type checked and an Object is used with a libraries: [] key for libraries and other keys passed (sanitized?) to the URL.
Solution
The key parameter also allows setting parameters, used mainly to allow use of enterprise accounts (See #3). Luckily, this allows us to use these keys to set a language, or any other parameters accepted on the script tag.
Instead of :
const mapsapi = require( 'google-maps-api' )( 'your api key', ... );

Use:
const mapsapi = require( 'google-maps-api' )( {key: 'your api key', language: "xx"}, ... );

Old Workaround
I'm using the fact that the libraries array is unsanitized to append my own language.
~~https://github.com/Jam3/google-maps-api/blob/master/index.js#L103~~
mapsapiLoader(GMAPS_API_KEY, ["places","&language=xx"]);
Though, this is as wrong as it can be! I would hazard, that while it is a bad idea, it would be better to keep this behaviour until an API breaking version is released.

@samueldr I like this solution. I'm not sure I have the time right now to implement it but a pull request would be AWESOME!

Well, this is already implemented! The tricky bit is that it is an undocumented side-effect of PR #3. It already checks whether it's a string or an object, which means that the usage above already works as is.
The missing bit would be documenting it and writing tests, to make sure it does not break 🙂.


How am I suppose to run the project?

1) Home am I suppose to run the project?
Should be just like running a normal Electron App? I have electron-prebuilt installed globally.
This should work, right?
electron .
This is what shows for me

2) How do I load an index.html?
var menubar = require('menubar');
var mb = menubar();

mb.on('ready', function ready () {
  index: 'file://' + __dirname + '../index.html')
});
```

Nothing loads, just showing the same thing (image above).

everything under 1 is correct (that is what Electron is supposed to be doing), but the syntax of the code in part 2 of your question is incorrect. the example code might be helpful for you: https://github.com/maxogden/menubar/tree/master/example

Okay, thanks!
I ran the example and as far as I understood, I have to have a index.html on the root of my project, right?
But is not calling any where (that's what confused me). My index.html is in a dist folder, is there a way to call a index inside a dist folder?

@BuKinoshita you can put it wherever you want, you just need to update the index option to point to it


e2e test fail with kind when operator is using pipe tasks

This PR https://github.com/kudobuilder/operators/pull/201 is failing with
        logger.go:37: 08:05:29 | kafka-upgrade-test | 2020-01-24 08:00:26 +0000 UTC	Normal	Pulling	Pulling image "mesosphere/kafka:1.1.0-2.4.0"
        logger.go:37: 08:05:29 | kafka-upgrade-test | 2020-01-24 08:00:26 +0000 UTC	Normal	Killing	Stopping container kubernetes-zookeeper
        logger.go:37: 08:05:29 | kafka-upgrade-test | 2020-01-24 08:00:37 +0000 UTC	Normal	Pulled	Successfully pulled image "mesosphere/kafka:1.1.0-2.4.0"
        logger.go:37: 08:05:29 | kafka-upgrade-test | 2020-01-24 08:00:37 +0000 UTC	Normal	Created	Created container init
        logger.go:37: 08:05:29 | kafka-upgrade-test | 2020-01-24 08:00:37 +0000 UTC	Normal	Started	Started container init
        logger.go:37: 08:05:29 | kafka-upgrade-test | 2020-01-24 08:00:41 +0000 UTC	Normal	Pulling	Pulling image "busybox"
        logger.go:37: 08:05:29 | kafka-upgrade-test | 2020-01-24 08:00:41 +0000 UTC	Normal	Pulled	Successfully pulled image "busybox"
        logger.go:37: 08:05:29 | kafka-upgrade-test | 2020-01-24 08:00:41 +0000 UTC	Normal	Created	Created container waiter
        logger.go:37: 08:05:29 | kafka-upgrade-test | 2020-01-24 08:00:41 +0000 UTC	Normal	Started	Started container waiter
        logger.go:37: 08:05:29 | kafka-upgrade-test | 2020-01-24 08:00:43 +0000 UTC	Warning	PipeTaskError	Error during execution: fatal error: kudo-test-composed-krill/kafka failed in deploy.deploy-kafka.generate-tls-certificates.generate-tls-certificates: failed to fetch cluster REST config: could not locate a kubeconfig
        logger.go:37: 08:05:29 | kafka-upgrade-test | Deleting namespace: kudo-test-composed-krill

The tests are passing when using a live cluster. KUDO controller is trying to read the file from default kubeconfig location rather than the kubeconfig created by kind.
Also when tried to export KUBECONFIG inside makefile, KUDO is failing to read the kubeconfig file.

The workaround in #201 only helped for CI for the operators repo.
Now we have the same breakage in the kudo e2e CI test.
Arguably, this should be fixed in a single place.

Also, setting KUBECONFIG in the Makefile like it was done in https://github.com/kudobuilder/operators/pull/201/files#diff-b67911656ef5d18c4ae36cb6741b7965R15 seems rather fragile, since it creates an implicit coupling with how kind determines where to put the config file.


[Meta] Have you seen the existing graphql_parser, graphql*, etc. libraries?

Hello, Klavs! I saw this pop up on my Github feed. If you didn't know, I have existing GraphQL parser/schema/introspection/server libraries here: https://github.com/angel-dart/graphql
It may be easier in the long run to join that project and contribute there.
Of course, though, it is your choice, and completely up to you.

Hi @thosakwe,
I am aware of your work on graphql_parser and I've taken a tiny bit of inspiration from it. To be fair, I've noticed that it's docs are highly misleading as it is not compatible with the latest GraphQL spec and it is not implementing the Visitor Pattern (as suggested in readme file).
This project really started as my pet project to better understand GraphQL spec, but it unexpectedly grew into the most up-to-spec GraphQL parser for Dart ecosystem. So I had to share my work.
Due to it's current state and our different approaches in source parsing, I do not really see how my work can benefit your's other than to replace it as a major version update.
My goal is to make it easy to write tooling for GraphQL so my focus is on parsing, transformation and printing (validation coming up later). I am not interested in execution of GraphQL Documents.
If you are interested in taking your packages to the latest version of the GraphQL spec, consider using this parser. Feel free to contribute by filing issues and creating Pull Requests.
My current plan is to improve test coverage. After that is done, I'll publish 0.1.0 version.

Ah, I see what you mean now. graphql_parser is not misleading in its docs (it is up to date with the June 2018 spec), it's just that it only parses queries - not the schema language (because it expects these to be defined in Dart). There's also no explicit mention of the visitor pattern, but the AST visiting logic was actually moved to graphql_server. So "misleading" isn't exactly the word I would use.
But I understand. Good luck with this project. No hard feelings.

As of version 2.0.0-beta, both graphql_server and angel_graphql are using the package:gql parser. I intend to deprecate graphql_parser entirely.
https://pub.dev/packages/graphql_server/versions/2.0.0-beta

@thosakwe, thanks for the info!
I'll add your packages to the users list in the readme.


Adopt platform standards for menus

The Application menu should be file on Windows and Linux.

Was fixed by #736 😄


[Question] Discrepancy between Humanoid-v3 and Humanoid-v4

Question
The Humanoid-v4 environment uses  the official mujoco binding, which offers simplicity in usage. However, in our reinforcement learning (RL) experiments, we've encountered notable differences in simulation performance compared to Humanoid-v3.

Comparison between Blue - V3 and Orange - V4, with all settings identical
When testing these two environments side by side, I found that even though they share the same mujoco model, random seed and initial qpos and qvel, their initial observations upon reset diverge. So, I wonder if it is caused by different mujoco version (2.1.0 vs 3.1.4)? Is it possible to change certain simulation config to match the original environment?

Identical behavior is not guaranteed across different gymnasium environment versions, in fact that is the point of environment versions, that being said if you want closer performance, you could try using an earlier version of  mujoco

Humanoid version 3 and humanoid version 4 are definitely not identical, They have different reward functions because version 4 contact cost is always 0, (due to a bug)


calico_backend and helm chart

I have a hybrid linux+windows workload,
On linux nodes I set up calico_backend to vxlan following
https://docs.projectcalico.org/getting-started/kubernetes/installation/config-options
And on windows nodes I tune the ps1 script to set up
CALICO_NETWORKING_BACKEND
https://projectcalico.docs.tigera.io/reference/node/configuration
Is there a way to do a helm deployment with vxlan instead of ipip?
I have not found this documentation any way to do it
https://projectcalico.docs.tigera.io/reference/installation/api#operator.tigera.io/v1.Provider
having an ippool with encapsulation type to VXLAN does not seems to be enough

Are you using the Calico official helm chart?  That helm chart doesn't have a calico_backend config option, so suspect you might not be.
Using the official helm chart, creating a VXLAN IP pool and setting bgp: Disabled should do the trick.

I have was trying an helm install with these options, but it never work
--set installation.BGPOption="Disabled"
--set installation.calicoNetwork.ipPools[0].encapsulation="VXLAN"
--set installation.calicoNetwork.ipPools[0].cidr="<IP_ADDRESS>/24"

but it never work

I'm afraid you're going to need to give me a bit more to go on than this! What are the symptoms that you are experiencing?
Can you share the generated Installation resource? e.g., kubectl get installations -o yaml


Form field does not display selected value of search-value-selector

The selected value of voting right delegated to is not displayed in the form field if you select a list item with list index > 12. It's interesting that the value is displayed for item with list index <= 12.
Steps to repeat

Select any item with list index 13 or greater

Click Save

Reopen the details dialog

I get the same issue for voting right received from if only one item is selected.

That is due to lazy loaded lists. The things do not exist in the DOM anymore, or rather, your DOM only loads a tiny subset of users so you can scroll through some thousands without lagg. But I thought I have fixed that before, strange.

Moved to TODO milestone. This is an open angular issue. Cannot currently provide a fix.
https://github.com/angular/components/issues/13087

outdated, should be fixed in os4.


chore: Add karpenter.sh/registered label

Fixes #N/A
Description

Adds the karpenter.sh/registered label to keep internal data consistency within the Node after all the labels, annotations, and taints have been properly propagated onto the Node after registration

How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

35 of 43 (81.4%)  changed or added relevant lines in 7 files are covered.
14 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.1%) to 81.553%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/machine/lifecycle/registration.go
15
19
78.95%

pkg/controllers/state/statenode.go
14
18
77.78%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/scheduling/topology.go
2
86.49%

pkg/controllers/provisioning/scheduling/topologygroup.go
2
96.75%

pkg/test/cachesyncingclient.go
2
82.47%

pkg/controllers/node/controller.go
4
70.59%

pkg/test/expectations/expectations.go
4
96.61%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
6994

Relevant Lines:
8576

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

35 of 43 (81.4%)  changed or added relevant lines in 7 files are covered.
17 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.2%) to 81.518%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/machine/lifecycle/registration.go
15
19
78.95%

pkg/controllers/state/statenode.go
14
18
77.78%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/scheduling/topologygroup.go
2
96.75%

pkg/test/cachesyncingclient.go
2
82.47%

pkg/controllers/node/controller.go
4
70.59%

pkg/test/expectations/expectations.go
4
96.61%

pkg/test/environment.go
5
89.71%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
6991

Relevant Lines:
8576

💛  - Coveralls


feat: US_46/InvisibleWallWithCamera

Description

We are looking for the camera to have a border that will be in line with the camera so that mario cannot move backwards and go out of the screen.
Related Issue(s)

Changes Made

[x] Modifications of the PlayerMovementSystem.

Screenshots (if applicable)

Checklist

[x]  There are collisions with map objects and gravity to make it fall to the ground.
[x]  The wall must advance together with the camera, so that it is always present.

code reviuw
@aguirrekarina
@OropezaHugo

e368eeac-443d-416e-93bf-e1faa088af36.webm
When Mario goes to the left with a jump he can leave the scene and no one looks at him

Done, now on the jumping the game check if he can not leave the scene and no one looks at him
@aguirrekarina


Change aspect ratio on preview

Hi,
I propose to add an AspectRatio to the preview widget so the image is not distorted anymore.
the ratio is computed using camera ratio.
What do you think ?

It's make sense. Can you create test for this? For example, send prints ou write test in flutter_test.


⚠ GitLab Server has degraded performance

In ef048e4, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 7157 ms

Resolved: GitLab Server performance has improved in 808c437.


Unity: Ignore SceneDependencyCache

In a DOTS project (that is one referencing Unity Entities package) when you add a subscene Unity will add Assets/SceneDependencyCache
Note that working with subscenes is a requirement of DOTS<EMAIL_ADDRESS>While SceneDependencyCache is unfortunately visible in the Project explorer it is not a user managed file. And if you delete it, it will be recreated.
Observe that Unity ignore this in their ECS samples
https://github.com/Unity-Technologies/EntityComponentSystemSamples/blob/master/.gitignore#L63C1-L63C29
It does seem the use of this folder is temporary, but I observe it in 2022.3 LTS version, so it may be with us for some time<EMAIL_ADDRESS>Finally, this comment from a Unity rep

These files should be in .gitignore in your project
They will be moved into the Library folder when the asset pipeline supports that.

https://forum.unity.com/threads/scenedependencycache-shouldnt-be-an-asset.863140/#post-5685628

+1 for this one! 👍🏿 Surprised it hasn't been added to the Unity.gitignore yet.


How to use a new FIHR server?

Hi,
I created an FHIR server and I want to connect to this server through your app and use my own data.
Is it possible in your App to connect to other FHIR servers? If yes, could you please guide me and tell me how?
LG
Sohrab

Feel free to change any of these api
https://github.com/1uphealth/1upwebapp/blob/master/oneup.js#L7-L9


IntegrityError when creating more than 1 instance of Page object in SQLServer

When creating more than 1 instance of the Page object (either via Admin or via shell), SQLServer throws an IntegrityError:
IntegrityError: ('23000', "[23000] [FreeTDS][SQL Server]Violation of UNIQUE KEY constraint 'UQ__cms_page__612F7F623943762B'. Cannot insert duplicate key in object 'dbo.cms_page'. (2627) (SQLExecDirectW)")

When we go to the DB and look at constraint 'UQ__cms_page__612F7F623943762B', it becomes clear that this constraint is refering to the column publisher_public_id, and publisher_public_id is required to be unique. When looking at the source code under cms.models.pagemodels.Page, we have the following code for publisher_public:
class Page(Mptt):
    ...
    publisher_public = models.OneToOneField('self', related_name='publisher_draft',  null=True, editable=False)
    ...

However, from what I can see atleast, I don't see any explicity assignment of what publisher_public should be in pageadmin.py or in pagemodel.py. Since publisher_public is None, the first record can be saved. However, when another instance of Page is going to be saved with Page.publisher_public == None, this IntegrityError is being thrown.
I didn't encounter this error with MySQL, which I used for development. However, our Production DB servers are SQLServer2008, where this error is being thrown.

I just came up against something similar, though it had to do with the unique_together for reverse_id, publisher_is_draft, and site, as well as two other constraints. I ended up adding an AppConfig to my project's main app, using a post_migrate hook to execute queries modifying the constraints so they filter for IS NOT NULL. Note that you have to have a models.py in your app, or post_migrate won't run - at least as of Django 1.7.6.
from django.apps import AppConfig
from django.db.models.signals import post_migrate
from django.db import connection
from django.conf import settings

def fix_keys(sender, **kwargs):
    cursor = connection.cursor()
    cursor.execute("ALTER TABLE [dbo].[cms_page] DROP CONSTRAINT [UX_cms_page_reverse_id_site_id_publisher_is_draft]")
    cursor.execute("""CREATE UNIQUE NONCLUSTERED INDEX [UX_cms_page_reverse_id_site_id_publisher_is_draft] ON [dbo].[cms_page]
(
	[reverse_id] ASC,
	[site_id] ASC,
	[publisher_is_draft] ASC
)
WHERE (reverse_id IS NOT NULL)
WITH (STATISTICS_NORECOMPUTE  = OFF, SORT_IN_TEMPDB = OFF, IGNORE_DUP_KEY = OFF, DROP_EXISTING = OFF, ONLINE = OFF, ALLOW_ROW_LOCKS  = ON, ALLOW_PAGE_LOCKS  = ON) ON [PRIMARY]""")
    cursor.execute("ALTER TABLE [dbo].[cms_page] DROP CONSTRAINT [UX_cms_page_publisher_is_draft_application_namespace]")
    cursor.execute("""CREATE UNIQUE NONCLUSTERED INDEX [UX_cms_page_publisher_is_draft_application_namespace] ON [dbo].[cms_page]
(
	[publisher_is_draft] ASC,
	[application_namespace] ASC
)
WHERE (application_namespace IS NOT NULL)
WITH (STATISTICS_NORECOMPUTE  = OFF, SORT_IN_TEMPDB = OFF, IGNORE_DUP_KEY = OFF, DROP_EXISTING = OFF, ONLINE = OFF, ALLOW_ROW_LOCKS  = ON, ALLOW_PAGE_LOCKS  = ON) ON [PRIMARY]""")
    cursor.execute("""declare @qry nvarchar(max);
select @qry =(SELECT  'ALTER TABLE ' + ob.name + ' DROP CONSTRAINT ' + ix.name
FROM  sys.objects ob
LEFT OUTER JOIN sys.indexes ix on ob.object_id = ix.object_id
LEFT OUTER JOIN sys.index_columns ic on ix.index_id = ic.index_id and ic.object_id = ob.object_id
LEFT OUTER JOIN sys.columns col on ic.column_id = col.column_id

WHERE ob.name = 'cms_page' and ix.name like 'UQ__cms_page_%' and ob.type = 'U' and col.name = 'publisher_public_id');

exec sp_executesql @qry;
""")
    cursor.execute("""CREATE UNIQUE NONCLUSTERED INDEX [UQ__cms_page__publisher_public_id] ON [dbo].[cms_page]
(
	[publisher_public_id] ASC
)
WHERE (publisher_public_id IS NOT NULL)
WITH (STATISTICS_NORECOMPUTE  = OFF, SORT_IN_TEMPDB = OFF, IGNORE_DUP_KEY = OFF, DROP_EXISTING = OFF, ONLINE = OFF, ALLOW_ROW_LOCKS  = ON, ALLOW_PAGE_LOCKS  = ON) ON [PRIMARY]""")

class MyAppAppConfig(AppConfig):
    """
    After DB migration, we need to fix some keys that are
    created incorrectly in SQL Server.
    """
    name = "myapp"
    def ready(self):
        post_migrate.connect(fix_keys, sender=self)

Hi, this is still happening (along with other random errors when using Django-CMS with MS-SQL Server).
Now, I know MSSQL isn't in the supported DB list, but are there any plans on including it?


[Snyk] Security upgrade python from 3.7-slim to 3.13.0rc1-slim

Snyk has created this PR to fix 3 vulnerabilities in the dockerfile dependencies of this project.
Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Snyk changed the following file(s):

terraform/resources/Dockerfile

We recommend upgrading to python:3.13.0rc1-slim, as this image has only 43 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
  829

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-5927132
  829

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-6210098
  721

Out-of-bounds Write SNYK-DEBIAN12-GLIBC-6210098
  721

CVE-2024-37371 SNYK-DEBIAN12-KRB5-7411315
  714

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Checkmarx One – Scan Summary & Details – 1bafc7b2-a56d-43a0-b603-f511b1d37fa2
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

Missing User Instruction
/Dockerfile: 1
A user should be specified in the dockerfile, otherwise the image will run as root

Sensitive Port Is Exposed To Entire Network
/ec2.tf: 56
A sensitive port, such as port 23 or port 110, is open for the whole network in either TCP or UDP protocol

Sensitive Port Is Exposed To Entire Network
/ec2.tf: 56
A sensitive port, such as port 23 or port 110, is open for the whole network in either TCP or UDP protocol

Healthcheck Instruction Missing
/Dockerfile: 1
Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working

IAM Access Analyzer Not Enabled
/es.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/lambda.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/s3.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/iam.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/ecr.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/ec2.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/eks.tf: 12
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

IAM Access Analyzer Not Enabled
/kms.tf: 1
IAM Access Analyzer should be enabled and configured to continuously monitor resource permissions

Fixed Issues

Severity
Issue
Source File / Package

Missing User Instruction
/Dockerfile: 1

S3 Bucket SSE Disabled
/s3.tf: 39

S3 Bucket SSE Disabled
/ec2.tf: 171

S3 Bucket SSE Disabled
/s3.tf: 25

S3 Bucket SSE Disabled
/s3.tf: 1

S3 Bucket SSE Disabled
/s3.tf: 55

S3 Bucket Without Enabled MFA Delete
/ec2.tf: 171

S3 Bucket Without Enabled MFA Delete
/s3.tf: 1

S3 Bucket Without Enabled MFA Delete
/s3.tf: 25

Healthcheck Instruction Missing
/Dockerfile: 1


[Bug]: VLLM crashes when prefix caching is enabled

Your current environment
PyTorch version: 2.3.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.4 LTS (x86_64)
GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
Clang version: Could not collect
CMake version: version 3.28.3
Libc version: glibc-2.35

Python version: 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] (64-bit runtime)
Python platform: Linux-5.15.0-1008-gcp-tcpx-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.4.99
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA H100 80GB HBM3
GPU 1: NVIDIA H100 80GB HBM3
GPU 2: NVIDIA H100 80GB HBM3
GPU 3: NVIDIA H100 80GB HBM3
GPU 4: NVIDIA H100 80GB HBM3
GPU 5: NVIDIA H100 80GB HBM3
GPU 6: NVIDIA H100 80GB HBM3
GPU 7: NVIDIA H100 80GB HBM3

Nvidia driver version: 535.104.05
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_engines_precompiled.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_engines_runtime_compiled.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_graph.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_heuristic.so.9.0.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops.so.9.0.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      52 bits physical, 57 bits virtual
Byte Order:                         Little Endian
CPU(s):                             208
On-line CPU(s) list:                0-207
Vendor ID:                          GenuineIntel
Model name:                         Intel(R) Xeon(R) Platinum 8481C CPU @ 2.70GHz
CPU family:                         6
Model:                              143
Thread(s) per core:                 2
Core(s) per socket:                 52
Socket(s):                          2
Stepping:                           8
BogoMIPS:                           5399.99
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single ssbd ibrs ibpb stibp ibrs_enhanced fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves avx_vnni avx512_bf16 arat avx512vbmi umip avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq la57 rdpid cldemote movdiri movdir64b fsrm md_clear serialize amx_bf16 avx512_fp16 amx_tile amx_int8 arch_capabilities
Hypervisor vendor:                  KVM
Virtualization type:                full
L1d cache:                          4.9 MiB (104 instances)
L1i cache:                          3.3 MiB (104 instances)
L2 cache:                           208 MiB (104 instances)
L3 cache:                           210 MiB (2 instances)
NUMA node(s):                       2
NUMA node0 CPU(s):                  0-51,104-155
NUMA node1 CPU(s):                  52-103,156-207
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit:        Not affected
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Not affected
Vulnerability Retbleed:             Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Enhanced IBRS, IBPB conditional, RSB filling, PBRSB-eIBRS SW sequence
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Not affected

Versions of relevant libraries:
[pip3] flake8==7.1.0
[pip3] mypy==1.11.0
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.24.4
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] onnx==1.15.0rc2
[pip3] optree==0.10.0
[pip3] pytorch-lightning==2.3.3
[pip3] pytorch-quantization==2.1.2
[pip3] pytorch-triton==2.2.0+e28a256d7
[pip3] torch==2.3.0
[pip3] torch-tensorrt==2.3.0a0
[pip3] torchdata==0.7.1a0
[pip3] torchmetrics==1.4.0.post0
[pip3] torchtext==0.18.0
[pip3] torchvision==0.18.0
[pip3] transformers==4.40.2
[pip3] triton==2.3.0
[conda] Could not collect
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.4.3
vLLM Build Flags:
CUDA Archs: 5.2 6.0 6.1 7.0 7.2 7.5 8.0 8.6 8.7 9.0+PTX; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0	GPU1	GPU2	GPU3	GPU4	GPU5	GPU6	GPU7	CPU Affinity	NUMA Affinity	GPU NUMA ID
GPU0	 X 	NV18	NV18	NV18	NV18	NV18	NV18	NV18	0-51,104-155	0		N/A
GPU1	NV18	 X 	NV18	NV18	NV18	NV18	NV18	NV18	0-51,104-155	0		N/A
GPU2	NV18	NV18	 X 	NV18	NV18	NV18	NV18	NV18	0-51,104-155	0		N/A
GPU3	NV18	NV18	NV18	 X 	NV18	NV18	NV18	NV18	0-51,104-155	0		N/A
GPU4	NV18	NV18	NV18	NV18	 X 	NV18	NV18	NV18	52-103,156-207	1		N/A
GPU5	NV18	NV18	NV18	NV18	NV18	 X 	NV18	NV18	52-103,156-207	1		N/A
GPU6	NV18	NV18	NV18	NV18	NV18	NV18	 X 	NV18	52-103,156-207	1		N/A
GPU7	NV18	NV18	NV18	NV18	NV18	NV18	NV18	 X 	52-103,156-207	1		N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

🐛 Describe the bug
VLLM crashes 100% of the time when using an async engine initialized with enable_prefix_caching=True
The stacktrace is:
File "/workspace/src/vllm/vllm/model_executor/layers/sampler.py", line 112, in forward
  prompt_logprobs, sample_logprobs = _get_logprobs(
File "/workspace/src/vllm/vllm/model_executor/layers/sampler.py", line 760, in _get_logprobs
  assert len(next_token_ids) == len(query_indices)
AssertionError

The problem goes away completely when enable_prefix_caching=False. This is on VLLM version 0.4.3.

Same bug, with vllm=0.5.3.post1

@zachzzc @raywanb Still facing the same issue when running following:
self.policy_model = LLM(
            model="openbmb/MiniCPM-V-2_6",
            max_model_len=4096,
            trust_remote_code=True,
            gpu_memory_utilization=0.5,
            enable_prefix_caching=True
        )

Here are my env:
PyTorch version: 2.4.0+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Ubuntu 22.04.2 LTS (x86_64)
GCC version: (Ubuntu 9.5.0-1ubuntu1~22.04) 9.5.0
Clang version: Could not collect
CMake version: version 3.30.1
Libc version: glibc-2.35

Python version: 3.10.13 (main, Sep 11 2023, 13:44:35) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.15.0-113-generic-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 12.2.140
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA A100 80GB PCIe
GPU 1: NVIDIA A100 80GB PCIe
GPU 2: NVIDIA A100 80GB PCIe
GPU 3: NVIDIA A100 80GB PCIe
GPU 4: NVIDIA A100 80GB PCIe
GPU 5: NVIDIA A100 80GB PCIe
GPU 6: NVIDIA A100 80GB PCIe
GPU 7: NVIDIA A100 80GB PCIe

Nvidia driver version: 535.183.01
cuDNN version: Probably one of the following:
/usr/local/cuda-12.2/targets/x86_64-linux/lib/libcudnn.so.8.9.7
/usr/local/cuda-12.2/targets/x86_64-linux/lib/libcudnn_adv_infer.so.8.9.7
/usr/local/cuda-12.2/targets/x86_64-linux/lib/libcudnn_adv_train.so.8.9.7
/usr/local/cuda-12.2/targets/x86_64-linux/lib/libcudnn_cnn_infer.so.8.9.7
/usr/local/cuda-12.2/targets/x86_64-linux/lib/libcudnn_cnn_train.so.8.9.7
/usr/local/cuda-12.2/targets/x86_64-linux/lib/libcudnn_ops_infer.so.8.9.7
/usr/local/cuda-12.2/targets/x86_64-linux/lib/libcudnn_ops_train.so.8.9.7
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                       x86_64
CPU op-mode(s):                     32-bit, 64-bit
Address sizes:                      46 bits physical, 48 bits virtual
Byte Order:                         Little Endian
CPU(s):                             96
On-line CPU(s) list:                0-95
Vendor ID:                          GenuineIntel
Model name:                         Intel(R) Xeon(R) Gold 6248R CPU @ 3.00GHz
CPU family:                         6
Model:                              85
Thread(s) per core:                 2
Core(s) per socket:                 24
Socket(s):                          2
Stepping:                           7
CPU max MHz:                        4000.0000
CPU min MHz:                        1200.0000
BogoMIPS:                           6000.00
Flags:                              fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single intel_ppin ssbd mba ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm mpx rdt_a avx512f avx512dq rdseed adx smap clflushopt clwb intel_pt avx512cd avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts pku ospke avx512_vnni md_clear flush_l1d arch_capabilities
Virtualization:                     VT-x
L1d cache:                          1.5 MiB (48 instances)
L1i cache:                          1.5 MiB (48 instances)
L2 cache:                           48 MiB (48 instances)
L3 cache:                           71.5 MiB (2 instances)
NUMA node(s):                       2
NUMA node0 CPU(s):                  0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46,48,50,52,54,56,58,60,62,64,66,68,70,72,74,76,78,80,82,84,86,88,90,92,94
NUMA node1 CPU(s):                  1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47,49,51,53,55,57,59,61,63,65,67,69,71,73,75,77,79,81,83,85,87,89,91,93,95
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit:        KVM: Mitigation: VMX disabled
Vulnerability L1tf:                 Not affected
Vulnerability Mds:                  Not affected
Vulnerability Meltdown:             Not affected
Vulnerability Mmio stale data:      Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed:             Mitigation; Enhanced IBRS
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1:           Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:           Mitigation; Enhanced IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI Syscall hardening, KVM SW loop
Vulnerability Srbds:                Not affected
Vulnerability Tsx async abort:      Mitigation; TSX disabled

Versions of relevant libraries:
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.26.4
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] open-clip-torch==2.24.0
[pip3] optree==0.12.1
[pip3] pyzmq==26.0.3
[pip3] torch==2.3.1
[pip3] torch-struct==0.5
[pip3] torchaudio==2.3.1+cu121
[pip3] torchvision==0.18.1
[pip3] transformers==4.44.0
[pip3] transformers-stream-generator==0.0.5
[pip3] triton==3.0.0
[pip3] vllm-nccl-cu12==<IP_ADDRESS>.4.0
[pip3] zmq==0.0.0
[conda] blas                      1.0                         mkl
[conda] ffmpeg                    4.3                  hf484d3e_0    pytorch
[conda] libjpeg-turbo             2.0.0                h9bf148f_0    pytorch
[conda] mkl                       2023.1.0         h213fc3f_46344
[conda] mkl-service               2.4.0           py310h5eee18b_1
[conda] mkl_fft                   1.3.8           py310h5eee18b_0
[conda] mkl_random                1.2.4           py310hdb19cb5_0
[conda] nomkl                     0.0.3                    pypi_0    pypi
[conda] numpy                     1.26.4          py310h5f9d8c6_0
[conda] numpy-base                1.26.4          py310hb5e798b_0
[conda] nvidia-nccl-cu12          2.20.5                   pypi_0    pypi
[conda] open-clip-torch           2.24.0                   pypi_0    pypi
[conda] optree                    0.12.1                   pypi_0    pypi
[conda] pytorch-cuda              12.1                 ha16c6d3_5    pytorch
[conda] pytorch-mutex             1.0                         cpu    pytorch
[conda] pyzmq                     26.0.0                   pypi_0    pypi
[conda] torch                     2.3.1                    pypi_0    pypi
[conda] torch-struct              0.5                      pypi_0    pypi
[conda] torchaudio                2.3.1+cu121              pypi_0    pypi
[conda] torchvision               0.19.0                   pypi_0    pypi
[conda] transformers              4.44.0                   pypi_0    pypi
[conda] transformers-stream-generator 0.0.5                    pypi_0    pypi
[conda] triton                    3.0.0                    pypi_0    pypi
[conda] vllm-nccl-cu12            <IP_ADDRESS>.4.0             pypi_0    pypi
[conda] zmq                       0.0.0                    pypi_0    pypi
ROCM Version: Could not collect
Neuron SDK Version: N/A
vLLM Version: 0.5.4
vLLM Build Flags:
CUDA Archs: Not Set; ROCm: Disabled; Neuron: Disabled
GPU Topology:
GPU0    GPU1    GPU2    GPU3    GPU4    GPU5    GPU6    GPU7    CPU Affinity    NUMA Affinity   GPU NUMA ID
GPU0     X      PIX     NODE    NODE    SYS     SYS     SYS     SYS     0,2,4,6,8,10    0               N/A
GPU1    PIX      X      NODE    NODE    SYS     SYS     SYS     SYS     0,2,4,6,8,10    0               N/A
GPU2    NODE    NODE     X      PIX     SYS     SYS     SYS     SYS     0,2,4,6,8,10    0               N/A
GPU3    NODE    NODE    PIX      X      SYS     SYS     SYS     SYS     0,2,4,6,8,10    0               N/A
GPU4    SYS     SYS     SYS     SYS      X      PIX     NODE    NODE    1,3,5,7,9,11    1               N/A
GPU5    SYS     SYS     SYS     SYS     PIX      X      NODE    NODE    1,3,5,7,9,11    1               N/A
GPU6    SYS     SYS     SYS     SYS     NODE    NODE     X      PIX     1,3,5,7,9,11    1               N/A
GPU7    SYS     SYS     SYS     SYS     NODE    NODE    PIX      X      1,3,5,7,9,11    1               N/A

Legend:

  X    = Self
  SYS  = Connection traversing PCIe as well as the SMP interconnect between NUMA nodes (e.g., QPI/UPI)
  NODE = Connection traversing PCIe as well as the interconnect between PCIe Host Bridges within a NUMA node
  PHB  = Connection traversing PCIe as well as a PCIe Host Bridge (typically the CPU)
  PXB  = Connection traversing multiple PCIe bridges (without traversing the PCIe Host Bridge)
  PIX  = Connection traversing at most a single PCIe bridge
  NV#  = Connection traversing a bonded set of # NVLinks

Can you share the input that caused this to error?

Can you share the input that caused this to error?

Here is my input:
sampling_params = SamplingParams(temperature=0.5, max_tokens=1, prompt_logprobs= 1, stop=["<|im_start|>", "<|im_end|>"])
messages = [{
        'role': 'user',
        'content': '(<image>./</image>)\n{question + "Yes"}'
}]
prompt = self.policy_tokenizer.apply_chat_template(messages,
                                                    tokenize=False,
                                                    add_generation_prompt=True)
input = {"prompt": prompt,
            "multi_modal_data": {
            "image": som_img  # Any PIL Image with shape 1280*720
        },
}
output = self.vlm_model.generate(input, sampling_params=sampling_params)

This would raise the issue:
assert len(next_token_ids) == len(query_indices)


Pytest options in pyproject.toml

@rafsaf hello !
Could you please explain what does the following keys means ?
[tool.pytest.ini_options]
addopts = "-vv -n auto --cov --cov-report xml --cov-report term-missing --cov-fail-under=100"

From my understanding, -n auto sets number of workers to auto(based on CPU), and --cov --cov-report xml --cov-report term-missing --cov-fail-under=100 we're using for coverage information, but what about -vv ?

Hello, you are correct for -n auto (that's for pytest-xdist, numer of processes) and coverage flags (pycoverage). As of -vv it's for pytest itself, shortcut for --verbose.
You can remove it completely, change to -v or even print more verbose output with -vvv if I remember correctly. Actually the same goes for other flags, this is just setup works for me.

@rafsaf thank you for your answer !