bug: Inconsistent/breaking 'swipe to go back` transition on iOS native Ionic build

Bug Report
Ionic version:

[x] 4.4.0
Current behavior:

I discovered inconsistent behavior while using swipeBackEnabled: true on an iOS native Ionic build.
Video of the issue here: https://streamable.com/1ux20
Things to notice in the video:

Sometimes, swiping back will cause the animation to trigger twice (seen near the beginning of the video).
At the 0:06 second mark, the app transitions to the details page but I can no longer swipe back. When I try to swipe nothing happens (you can see the screen sorta go up and down because my swipes aren't perfectly horizontal).
You're able to see the home page beneath the details page when swiping down on the details page which uses ion-refresher.
Tapping the back-button in the toolbar doesn't do anything
Tapping tabs at the bottom doesn't do anything either

Expected behavior:

I don't expect to see doubled animations occasionally and I also don't expect the app to get "stuck" on a page where I cannot route to a different page or even swipe to go back a page.
Steps to reproduce:

I have only been able to reproduce this on a physical iOS device (but I have reproduced this problem on 2 different Ionic apps, one of my apps is in production with this issue), as I state below this is extremely inconsistent, but I tend to be able to reproduce it more often when I swipe from the very edge of the device from left to right to go back to the home page. Click the "Details page" button to route forward. Do you guys have a suggestion for gesture tracking/recording? That may help debug this issue better so we can pinpoint the exact stroke that breaks things, but I don't know of such software.
Related code:

Like I said, this is extremely difficult to recreate consistently (typically can get it within the first 50 attempts, but as seen in this video I was able to trigger the problem within 4 attempts, but I have a repo of the demo app you see in the video (ignore the name because I'm using it for another bug submission already):
https://github.com/uncvrd/ion-refresher-bug
Other information:

Ionic info:

Ionic:

   ionic (Ionic CLI)             : 4.12.0 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.4.0
   @angular-devkit/build-angular : 0.13.9
   @angular-devkit/schematics    : 7.3.9
   @angular/cli                  : 7.3.9
   @ionic/angular-toolkit        : 1.5.1

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : ios 5.0.0
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 4.0.1, (and 6 other plugins)

System:

   ios-deploy : 1.9.4
   ios-sim    : 7.0.0
   NodeJS     : v10.15.3 (/usr/local/bin/node)
   npm        : 6.4.1
   OS         : macOS Mojave
   Xcode      : Xcode 10.2.1 Build version 10E1001

I can confirm that the "swipe to go back" does result in weird behaviours sometimes.
The 2 biggest issues that I noticed:

If you start the "swipe to go back" gesture, but then let it go (so you stay on the child page), some elements are transparent. I noticed this when the are area surrounding the ion-searchbar in the header turned transparent (this was fixed by placing it in an ion-toolbar, but the same happens for the "pull down to refresh area", as shown in this video.
If you start the "swipe to go back" gesture very slowly, then sometimes the transition gets "stuck". So moving your finger doesn't do anything anymore. You have to let go and touch the screen again, which then works nicely again.

I was planning to open up a separate issue for those, but it seems that there are some issues around this feature, so we can summarise them here.

To add to @AndreasGassmann additional iOS swipe bugs, I noticed (and have created a bug request) for the background going transparent after "half-swiping" on ion-refresher #18284
I've also experienced flickering header icons on transitions. Sometimes, after "swiping to go back" and I tap on another element, the icons flicker at the top of the page, then disappear. I then have to tap on an element again before the page transition happens. You can see the issues here:
Video link: https://streamable.com/147x7
My header looks like this:
<ion-header mode="md" no-border>
  <ion-toolbar>
    <ion-buttons slot="start">
      <ion-back-button class="back-button" color="light" mode="md"></ion-back-button>
    </ion-buttons>
    <ion-buttons slot="primary" (click)="presentMoreInfoModal()">
      <ion-icon class="more-button" name="share"></ion-icon>
    </ion-buttons>
  </ion-toolbar>
</ion-header>

yes sir, I have the same issue, but the problem is now with cordova-plugin-googlemaps

<ion-content style="--ion-background-color: initial!important">  this work for me sir. I think you can try this

aw, damn it. That set background to white, will remove the google map layout. I have to set it become transparent. so sad :(

I have the same issue, the bug happens very often and can be recreated easily, especially quick enter ->  swipe back -> enter -> swipe back ... actions.
ionic 4 back button is buggy all the time~
note that swipe back is an important feature of iOS, we cannot make an app without it.

Are there any updates on this? I'm experiencing all of the same issues and it's quite frustrating to have to disable swipe to go back app-wide because of them. I can easily recreate the issue if I push multiple pages on, and then swipe back quickly multiple times (ie. start the next swipe before the first animation has finished.). Sometimes when I do this the whole app jams and all tap events stop working, I can't event change tabs in my tab controller.
It would be great to have an event hook for when a swipe back has started, and for swiping to be disabled when a current back animation is in progress.

I'm currently experiencing an issue where the background goes transparent when swiping back / transitioning back, once the Google Map is loaded. This is due to the fact that the map isn't actually an element but a background, with a viewport window cut out to display it. That's the way I understand it... anyone encountered this and have any hack to fix it?


[Bug] [Niche] URI links only open when VRCX is closed

Describe the bug
URI links only open when VRCX is closed
To Reproduce
Steps to reproduce the behavior:

grab a URI link i.e

USER -  vrcx://user/usr_ID
GROUP - vrcx://group/grp_ID
AVATAR - vrcx://avatar/avtr_ID
WORLD - vrcx://world/wrld_ID
AVTARDATABASE - vrcx://addavatardb/LINK

(all the ones I've tested)

put the URI into the browser and press enter and press allow on the pop-up for "Do you want to open "VRCX" "

IF it's closed it will work as expected and open VRCX
IF it's open already nothing will happen. it will not even focus the VRCX app
What version you are running
VRCX2024.10.25

I have a feeling this is already fixed in latest nightly build, give that a try.

yup just tried this is working again thanks


SAML and SAML2 new model validation: Issuer Signing Key

SAML and SAML2 new model validation: Issuer Signing Key

Added issuer signing key validation to SAML and SAML2 security token handlers
Added tests for both

Resolves #2963 and #2964
Part of #2711

Leaving as draft until the signature PR is merged.


API Endpoint: Mod User

Modifying a user through api/user/add is possible, but harder because of the password setting mechanics.
Add an API endpoint that is just for modifying (not adding) a user.

The new upsert semantics are cover this: 12adc57a6a88b8c57e1b03b03021d05ea621b5f7.


Integration with DNS Zone

Is your feature request related to a problem? Please describe.
Not a problem, it's an enhancement to be considered.
Ability to creates public/private accessible DNS names for application endpoints.
Describe the solution you'd like
Creation of DNS Zone in the Azure subscription and watches for Kubernetes Ingress resources and creates DNS A records in the cluster-specific DNS zone.
The concept is the same as implemented on HTTP application routing

You should be able to use https://github.com/kubernetes-sigs/external-dns for this

@hkamel Did you try the documentation on ExternalDNS with Azure DNS zones ? https://github.com/kubernetes-sigs/external-dns/blob/master/docs/tutorials/azure.md

It works with external-dns but not when using annotation-filter, so you will get issues in external-dns when you run multiple ingress controllers side by side. This might be a compound issue related to the following bugs:
https://github.com/Azure/application-gateway-kubernetes-ingress/issues/699
https://github.com/kubernetes-sigs/external-dns/issues/1336
https://github.com/kubernetes-sigs/external-dns/issues/1335

The AKS docs for the http-routing-addon state that you shouldn't use it for production scenarios, yet when it comes to using something like AGW in production you're forced to reverse-engineer the thing about http-routing-addon that makes it so clutch: the automatic DNS management.
I know that in concept, adapting how the http-routing-addon integrates with ExternalDNS should be easy to copy by setting EDNS up from scratch along with AGWKI, but it (along with the above-mentioned #699 mentioned) make it feel like it's a huge step backwards in terms of the user experience.

@akshaysngupta I have tried setting up AGIC using ExternalDNS with Azure DNS zones. It doesn't work!. Below is my manifest.
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: sba-ingress
  annotations:
    kubernetes.io/ingress.class: azure-application-gateway
spec:
  rules:
  - host: sba3.aks-egress-fw.io
    http:
      paths:
      - backend:
          serviceName: sba-service
          servicePort: 80
        path: /

ExternalDNS do update the A and TXT records in Azure DNS Zone with public IP of Application Gateway. But if I try to navigate to HOST (sba3.aks-egress-fw.io), I get an error This site can’t be reached sba3.aks-egress-fw.io’s server IP address could not be found.
ExternalDNS team says it's an issue related to DNS.
I am not sure though if it's Application Gateway or DNS issue.
Any thoughts?


cleanup(tests,vmi_lifecycle): Use client instead of virtctl and minor cleanups

What this PR does
Use the KubeVirt client instead of using virtctl through a
NewRepeatableVirtctlCommand where applicable in tests/vmi_lifecycle_test.go.
Internally virtctl uses the same client call, so using virtctl does not provide
any additional value.
This also handles a previously unhandled error and drops the unused
nowAsJSONWithOffset helper.
The correctness of API calls made by virtctl unpause is already covered in unit
tests specified in pkg/virtctl/pause/pause_test.go.
The goal of this and further PRs is to reduce the amount of unnecessary uses of
virtctl in the e2e tests to stabilize tests, to reduce the number of flakes and to
remove redudant tests.
Before this PR:
NewRepeatableVirtctlCommand is used unnecessarily.
After this PR:
The KubeVirt client is used instead.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

None

/sig code-quality

Thank you @0xFelix! Great stuff!
/approve


NameError: name 'model_path' is not defined

Please check the pretrained model are in the './checkpoint/pretrained' directory.


Type imports are treated as dependecies

type imports cause a dependency check to fail even though they do not create an actual dependency
import type is always guaranteed to be removed from your JavaScript
if a.ts imports a type from b.ts, the import is considered a "type only" import by the compiler but ts-arch currently ignores that flag on the node
here is an example project that fails but shouldn't
test.tar.gz

Thank your for creating the issue and taking the time to creating a failing test. I do not see that a type import does not create a semantical dependency, although your are right that it doesn't create a technical dependency. I think, if this feature is useful for you, it should be implemented. I am considering making the dependency engine more flexible (also looking at #49). so one could create an extra option to ignore type imports. ( Although you would have to convince me making this the default behaviour).
What do you think?

What I ended up doing was building the rule, runing it and filtering the result manully
sort of like this

// importAllowed checks the violation against a list of known type only imports

const rule filesOfProject()
        .matchingPattern('/a/')
        .shouldNot()
        .dependOnFiles()
        .matchingPattern(`/(b|c)/`);

const all = (await rule.check()) as ViolatingFileDependency[];
const violations = all.filter(v => !importAllowed(v.dependency));

then expect the list length to be 0.
It'd be really cool if I could specify in the rule which type of imports is allowed


New cmdlet Restart-PnPFlowRun

Type

[ ] Bug Fix
[x] New Feature
[ ] Sample

Related Issues?
Fixes #1909
What is in this Pull Request ?
New command to restart/resubmit a previous Power Automate flow run.
Examples
$environment = Get-PnPPowerPlatformEnvironment
Restart-PnPFlowRun -Environment $environment -Flow fba63225-baf9-4d76-86a1-1b42c917a182 -Identity<PHONE_NUMBER>2024670884771461819CU230

$environment = Get-PnPPowerPlatformEnvironment
Restart-PnPFlowRun -Environment $environment -Flow $flowObject -Identity $flowRunObject -Force

Thanks @milanholemans !


Added fletching table

Added the fletching table block.

I believe you may have committed too many files. Welcome back to life by the way!


reuse searchParams

currently every time get searchParams will create a new object, which is waste memory and cause problem.
currently, in chrome 49.
const url = new URL('http://example.com/?a=1');
url.searchParams.set('b','2')
url.searchParams.set('c','3')
console.log(url.toString())

=>
http://example.com/?%3F%3Fa=1&b=2&c=3

will get some mysterious %3F in search string, seems it's caused by duplicated searchParams create.

btw, chrome 49 support both URL and URLSearchParams, but no url.searchParams.
this may help you debug.

well no i guess wrong.
only one searchParams call will cause this problem too.
const url = new URL('http://example.com/?a=1');
const params = url.searchParams;
params.set('b','2');
params.set('c','3');
console.log(url.toString())

=>
http://example.com/?%3Fa=1&b=2&c=3

Well, I haven't a chrome 49 version. Could you check what native code exists on URL/URLSearchParams for chrome 49 ? Or even do a pull request if you find a fix ?
This polyfill is intended to be lightweight, so it use the maximum of native functions. Some could be errored. For example, on the last version of chrome (60~62) the URL is not spec compliant because the hash is not url-escaped... But this still covers 99.9% of the usage.

Could you please provide methe result of `new URLSearchParams('?a=1').toString()' on chrome 49 without polyfill.
I can't accept right now your pull request because of the lacks of test, build and description... I can do it if you tell me what is buggy on chrome 49.

new URLSearchParams('?a=1').toString() #=> "%3Fa=1"

Fixed in https://github.com/lifaon74/url-polyfill/commit/53ddfbaccb8ff3e9eeb2cb57f48678cb43c291db ?


Query on whats installed [docker daemon]

Hi,
rather than having docker daemon installed on each machine and needing root access, have you looked at kaniko from google?
It provides an executor to build container images inside a container running on a Kubernetes cluster.
example of using kaniko and knative I read recently:
https://itnext.io/how-to-use-knative-to-automate-an-application-build-on-kubernetes-904034341f9f

Yup, have been keeping a pretty close eye on that ecosystem. That would solve the container building part of the puzzle, but what about executing workloads in containers?
https://github.com/uber/makisu is also another one to keep an eye on.

Rootless Buildkit (unrelated to Buildkite) is another thing to keep an eye on! https://medium.com/@tonistiigi/experimenting-with-rootless-docker-416c9ad8c0d6


Hacky solution

@easadler Please describe the rationale of this PR. Also, look into the failures from Travis.

@zachgarwood oh meant to make this against my fork. Just messing around to get CartCreate functionality. First time ever playing with elixir.


Jenkins-spock should automatically execute parallel closure steps

Desired Behavior
Jenkins-spock should automatically execute parallel closure steps.
Benefits
Should allow the testing of pipelines containing parallel steps more easily without refactoring.

mockDSL.parallel(_) >> { _args ->
            _args.each { Map _args2 ->
                _args2.each { _key, _value ->
                    if( _value instanceof Closure ) {
                        _value()
                    }
                }
            }
        }

Adding this to the setup stage can do the trick.


Setting nodeDimensionsIncludeLabels to true works not well for zero degree nodes

I set nodeDimensionsIncludeLabels to true to avoid label overlap, which is helpful. But for zero degree nodes , their layout looks out of order. Not N*M layout regularly.
I think the reason is that measure zero degree nodes position should use the width of node, which also include the width of label. But the width of label is not fixed depend on the text.

So is it possible to set label width or set boundingbox of node ?

@Does666 I am not sure I understand your concern. If node labels are considered in node dimensions and node labels do not have uniform dimensions, you should expect a grid layout for disconnected nodes when they are tiled.
Why not truncate your labels above a certain width to ensure uniformity if it's important for you?

@ugurdogrusoz Thanks for your reply. I think you got my concern.
I use cose-bilkent layout and cytoscape.js-expand-collapse extension for the compound feature. The disconnected nodes exists on diffrent groups.

Is it possible to layout nodes with edges with cose-bilkent and layout nodes disconnected with grid ?
Some label text maybe a letter, while some text maybe a long label.  I have set text-max-width 120px  for all nodes. But I can't truncate all labels a certain width. I expect the label only with a letter also has width 120px.

When tile is true, we tile/pack disconnected nodes w.r.t. their dimensions. In below example, since labels are considered, this is the tiling we get:

I suppose you'd like to see the actual nodes tiled to a grid. This is not something this layout style will do under any circumstances since it strives to minimize area.
Your other more general Cytsocape.js related questions, I suggest you ask them in proper forums.


Update FFTW.jl

Removed "precompile()", not needed in Julia 0.7: https://github.com/JuliaLang/julia/blob/0ef882679f00d331467b23ffe89906505f5774bf/NEWS.md
Throws warning here:
https://github.com/JuliaLang/julia/blob/dd248bf06c6d136ebc214c10f52730be362d290a/base/loading.jl#L780

Better to change it to VERSION < v"0.7.0-beta2.199" && __precompile__() so that other 0.7 prereleases don't break.

Superseded

Superseded


[chore] Update doc to inform v3 users about close transition

Does not fix any issue. But informs the user about the discussion in #530
Changes proposed:

Update to documentation.  Inform users of v3 be aware that close transition does not work with conditional render

Coverage remained the same at 87.703% when pulling 5e5d5c0d36c3717398955ce73274e23d0d3e60c8 on hoodwink73:master into f715a69e31b00eaf7912595a9bd2d22ab5cecdb3 on reactjs:master.

Thanks, @hoodwink73. I'll have a look on your PR later.

@diasbruno hey I did some debugging and figured out concrete reasons why conditional rendering is not working in React 16.
I will add this to the opened issue.
Thanks a lot for all help. Have a great weekend.

Thank you so much. Great effort on getting this, @hoodwink73.

🙌
I also posted a lengthy comment on #530 regarding my debugging efforts. It might help you to close the issue.

Yeah, that was great. That should clarify what is going on. Great job.


Updating the transformKey

Hi there,
Firstly thanks for the great contribution!
Would there be any way to change the transformKey at a later time?  The use case I have in mind is to enable namespacing the persisted key/values by something dynamic like a UUID.
-James

I'm not sure foo isn strong enough for a PR, I haven't been able to think of a clean way to achieve this.
My thinking got as far as:  ideally we would need to destroy the dynamically created selectors and re-create, which would respect the new transformKey.  However Apple removed the ability to destroy sel_registerName created selectors.   If old ones were left around they could be inadvertently called and/or have unexpected behaviour.  Code could detect calls to these now invalid selectors and handle some how, but we're in dirty territory.
Do you have any ideas on how this could be cleanly accomplished?

Well the easiest way is to not save the result of the transformKey method, but simply always ask the category for the current value, then you can return whatever you want at that time. But that would be a performance hit...
I don't really see the need for this feature for our apps, so unless it can be done cleanly (and by a contributor like yourself) your best bet would be to use a fork and hack this in your fork.


Defining functions and modules within InterpContext

I've been wondering if there is a way to call def and add_module functions on InterpContext rather than globally. I went through the examples and unit tests code but couldn't find anything relevant.
Basically I have an application that can run multiple "instances" of itself in threads and it currently supports Lua for scripting, in Lua I simply define a new state for each instance and when exposing functions to Lua I pass direct function references to current instance. I wanted to achieve something similar with pyd and ideally I'd define InterpContext for each instance and add the functions there - without being able to define functions and modules within InterpContext, I'd have to resort to proxy functions which take an instance identifier, fetch the instance object, then call the actual function which isn't ideal because with a few dozens of functions it can get quite messy. Is there any way to achieve this?

I seem to have resolved the issue by simply defining dictionary with functions instead of a module within InterpContext, while it's not ideal, it's a good enough solution for my use case.
For anyone interested or looking through the issues in the future this is app.d:
module test;

import std.stdio;
import std.file: read;

import pyd.pyd;
import pyd.embedded;

shared static this()
{
	py_init();
}

shared static ~this()
{
	py_finish();
}

void test(PydObject callback)
{
	callback("Test");
}

void test2(PydObject callback)
{
	callback("Test2");
}

void main()
{
	auto data = cast(string) read("test.py");
	auto ctx = new InterpContext();
	ctx.test = py([
		"test": &test,
		"test2": &test2
	]);
	ctx.py_stmts(data);
}

And this is test.py:
def hello(name):
    print('Name: {}'.format(name))

test['test'](hello)

The only downside of InterpContext is that when you import something outside the function scope (hello in this case), it won't be visible within the function. You can get around the issue by doing:
import library
global library


Issue 81- ResourceResolver should be closed in try-with-resources

fixes #81

Coverage increased (+0.06%) to 96.481% when pulling ac6e10eb931bb200a1e9737eba3ae95900c64d02 on issue-81 into 3173f50367ca99d624124a83cb55f78bcfe2dae5 on master.

New pull request: https://github.com/Cognifide/AEM-Rules-for-SonarQube/pull/154


How to make \left\langle with arbitrary height?

Consider this equation
\left\langle\frac{\frac{\Big(}{\Big)}}{\frac{\Big(}{\Big)}}\right.
with the (same as plain LaTeX) result:

To make it higher, suggestions for LaTeX are using some external packages or scaling.
Is it somehow possible to make the angle bracket higher in KaTeX?
Thanks
Jan

This crude hack would work - probably depends how many of them you'll have.
The span that wraps the angle bracket has a default "top:0". Change that to something like this:

Result:

You could surround the slab of math with a span and give it an id. Then with javascript (after KaTeX has processed everything on the page), find that id, then find the first span with class "mopen dlimcenter" and change its "top" to whatever value you want.
Hope that makes sense.

Thanks, makes perfect sense. Playing with JavaScript and DOM would probably work.
I was just wondering if there is another "standard" solution, e.g. something like \left\lSpecialAngle or solution using scalerel package..


get profileCardProperties error

Describe the bug
https://graph.microsoft.com/beta/organization//settings/profileCardProperties gives error :
message": "Resource not found for the segment 'profileCardProperties'

I am global admin, Tenant ID and permission are set for User.ReadWrite andUser.ReadWriteAll

Hey @iavoo,
Ref: https://learn.microsoft.com/en-us/graph/api/peopleadminsettings-list-profilecardproperties?view=graph-rest-beta&tabs=http
I think this has the query you would need to obtain 'profileCardProperties'


[ARCTIC-1535] Fix displaying empty optimizing process

Why are the changes needed?

fix #1535, when there is no optimizing process.
Brief change log

SELECT IN(...) cannot be empty

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[x] Add screenshots for manual tests if appropriate

[x] Run test locally before making a pull request

Documentation

Does this pull request introduces a new feature? (no)
If yes, how is the feature documented? (not documented)

Test Result


ERR_DLOPEN_FAILED

System Info
System:
OS: Windows 10 10.0.15063
CPU: (4) x64 Intel(R) Core(TM) i7-5500U CPU @ 2.40GHz
Memory: 5.58 GB / 7.90 GB
Binaries:
Node: 16.20.2 - C:\Program Files\nodejs\node.EXE
npm: 8.19.4 - C:\Program Files\nodejs\npm.CMD
pnpm: 8.8.0 - ~\AppData\Roaming\npm\pnpm.CMD
Browsers:
Edge: Spartan (40.15063.0.0)
Internet Explorer: 11.0.15063.0
npmPackages:
@rspack/cli: ^0.2.5 => 0.2.12
@rspack/plugin-html: ^0.2.5 => 0.2.12
Details
When I used my windows computer to run the project, an ERR_DLOPEN_FAILED exception was thrown (there was no problem on my MAC computer), so I tried to verify it and found that as long as I quoted @rspack/binding-win32-x64-msvc, it would throw an exception:

Judging from the error results, it was caused by a lack of dlls, but the failure to call process.dlopen did not clearly prompt me which dlls were missing. Is there any way to solve this problem, or can you provide a list of dlls?
This problem was mentioned in #3598, and it seems to be solved by installing Visual Studio. It is a bit scary to install such a heavy IDE to solve this problem.
Reproduce link
No response
Reproduce Steps
This kind of environmental problem may not be easy to reproduce stably. I just switched from mac to windows development, and this windows computer was just reinstalled.

what's the minimal environment for napi-rs related library run on windows? @Brooooooklyn is Visual Studio a must need?


Refresh API docs for #32

Update API doc to include #32

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   20.62%   20.62%
=======================================
  Files           5        5
  Lines         223      223
=======================================
  Hits           46       46
  Misses        177      177

Flag
Coverage Δ

#CredentialsGoogle
20.62% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7da50...f1dcc5d. Read the comment docs.


test: Support producing kafka records with timestamp.

    > > Generally LGTM, please add e2e tests to this.

There is a problem: how do we add e2e test for this... We can't infer the _rw_kafka_timestamp.

Yes, it's a little difficult. We can attach a timestamp to each kafka record, but as far as I know, no tool can support this. We need to use kafka producer api for this.
https://kafka.apache.org/23/javadoc/index.html?org/apache/kafka/clients/producer/KafkaProducer.html
Originally posted by @liurenjie1024 in https://github.com/risingwavelabs/risingwave/issues/7275#issuecomment-1381475015

cc @tabVersion

I think we can do this in simulation.
In simulation, we read record from test_data file and send it to the kafka producer.
https://github.com/risingwavelabs/risingwave/blob/main/src/tests/simulation/src/kafka.rs
So we can

modify the test_data file format to contain a timestamp for each record
e.g.

origin test_data format:
{"v1":1,"v2":"name0"}

new test_data format:
{"v1":1,"v2":"name0"},timestamp:2022-01-01 12:00:00

parse and construct the record

In simulation, we read record from test_data file and send it to the kafka producer.

After a second thought, I still prefer to do it in normal kafka producer, so that we can test more cases in normal e2e

After discussion, we don't need to verify the exact kafka timestamp, but use some functions, for example:
select _rw_kafka_timestamp > 10000  from xxx

cc @ZENOTME


change the flutter doctor check for the atom plugin

flutter doctor currently checks for the existence of the atom plugin and prints out the installed version:
[✓] Atom - a lightweight development environment for Flutter
    • flutter plugin version 0.2.5
    • dartlang plugin version 0.6.39

We should change this check to be optional; if atom is not installed, change to not print anything. If it is, the text can remain as is - the version info.
/cc @danrubel

If no IDE is installed, we could show ...
[ ] IDE support not installed. Supported IDEs include:
    • Atom - https://atom.io/
    • IntelliJ - https://www.jetbrains.com/idea/

We would only add IntelliJ to the list above when it is ready and remove Atom from the list sometime after that. If at least one IDE is installed then we only show information about the plugins for those installed IDEs similar to what is shown today for Atom.

Closing in favor of https://github.com/flutter/flutter-intellij/issues/229


renamed preflightCommitment parameter to commitment; added commitment…

… parameter when sending transaction

⚠ NOTE: Use notes like this to emphasize something important about the PR.
This could include other PRs this PR is built on top of; API breaking changes; reasons for why the PR is on hold; or anything else you would like to draw attention to.

Status
Type
⚠ Core Change
Issue

Hold
Refactor
Yes
Link

Problem
https://github.com/garbles-labs/Solana.Unity-Core/issues/14
Solution
The parameter that was formerly called "preflightCommitment" is now called simply "commitment", and is used for both preflightCommitment and normal commitment. In SolanaRpcClient.SendTransactionAsync, a "commitment" argument was added to the outgoing RPC request, in addition to the already existing "preflightCommitment". Both have the same value, which comes from the "commitment" parameter.
Other changes (e.g. bug fixes, small refactors)
The main change is in SolanaRpcClient.SendTransactionAsync. Other methods which have that same parameter, which feeds into SolanaRpcClient.SendTransactionAsync, have had their "preflightCommitment" parameter renamed to "commitment"  as well.
New scripts:
none
New dependencies:
none

The not blocking behaviour is actually correct. I added additional methods, following the solana web3js library to confirm and sendAndConfirm transaction in #20. This include the blocking behaviour that can be used when needed.


[BUG] withResource can trigger serialization of query plan nodes

Describe the bug
withResource is a member function rather than a static function, and thus any closure that uses this function must also serialize the corresponding object.  When withResource is used in the closure for an exec node's RDD columnar evaluate function, it will cause the exec node itself to become part of the closure, causing that node and any child nodes to be serialized as well.
Steps/Code to reproduce bug
Apply a serialization "poison pill" to GpuExec with a patch like this:
diff --git a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuExec.scala b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuExec.scala
index 5284cf8c5..ed2957757 100644
--- a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuExec.scala
+++ b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuExec.scala
@@ -208,7 +208,11 @@ object GpuExec {
   }
 }

+class SerializationPoisonPill {}
+
 trait GpuExec extends SparkPlan with Arm {
+  protected val poisonPill = new SerializationPoisonPill()
+
   import GpuMetric._
   def sparkSession: SparkSession = {
     SparkShimImpl.sessionFromPlan(this)

Then run a query that triggers use of nodes that are using withResource in their RDD closures, e.g.: GpuBroadcastHashJoinExec or GpuShuffledHashJoinExec.
Expected behavior
The query plan should not be needlessly serialized as part of an RDD evaluation function.

Note that closeOnExcept, freeOnExcept, and withResourceIfAllowed all have similar issues with respect to closures.  It may make sense to convert Arm into a standalone object rather than a trait since these functions do not need to be member functions.


Base kubelet-to-gcm on scratch, set user to nobody, and bump tag to 1.2.2

This also fixes changes the prefix back to the correct default.
I haven't pushed 1.2.2 yet, but I don't expect any major changes, besides using an updated base image and being built with go1.7.5.

This change is

ping @Q-Lee

Actually, I'm confused - why is this image based on ubuntu? Why does it install curl? Is there any reason this can't just be from scratch?

Changed the base image to scratch. I still haven't pushed this anywhere yet. Not sure how to test this.
cc @timstclair

Done. Also added an entrypoint.

Thanks, LGTM (please squash).

squashed.

I guess this PR needs approval too

/approve

Thanks. gcr.io/google_containers/kubelet-to-gcm:1.2.2 pushed.

Thanks. Will you follow up with a change to use the updated image?


Several Places have errors when transferring to fuseki

During couchdb to fuseki transfers of a very few Place documents, errors are thrown for content like in G1164:
"plc" : "",

which seems to arise from:
<g:gis>
    <g:id/>
    <g:coords/>
</g:gis>`

The Places that seem to have problems are:
G1164
G1PD110071
G3997
G3CN1561
G3CN711
I haven't checked the others but they are likely similar to G1164.

Thanks, I suspected something like that but I'm glad you identified it! I'm currently adding more checks to the migration, I think there are still some similar errors here and there. I've started this morning but was busy the rest of the day, I should have something working nicely on monday


About in-function imports.

I saw that some modules are imported inside functions. Is there a reason for this? Or is it a complete error? If it is a bug, I will send a PR to fix all the imports I see.
Thank you, have a good day.

lazy imports are a performance optimization to improve responsiveness of python cli tools
in python, import times can actually be quite substantial. delaying those imports to if/when they are actually use improves startup times. startup times are particularly important for cli tools, not so much in other types of tools


Visually disambiguate which edge of matched parentheses

Discussion
Sometimes when you are writing code you need to find the other end of parenthesis to be sure you have just the right amount. The other end of the parentheses is shown, this is helpful.
But this can be ambiguous for the outermost matched pair because your cursor is inside or outside that last pair and the corresponding highlight only matches the character as a whole.
This can be shown visibly.
Current

Proposed

@fulldecent I am having trouble reproducing this. I always get the behavior in Proposed:

@fulldecent I'm really sorry, but I don't understand what you mean. I'm not 100% sure what you are referring to. Is it about which bracket gets matched, the one to the left or to the right of the cursor in case of two touching brackets, is it about the border rendered around the brackets?

It's about the border rendered around the brackets

Would it be preferable if brackets were highlighted using underscores? (someone already asked for that in https://github.com/microsoft/vscode/issues/15899 )

Underscores do not address the issue

@fulldecent Oh wow, After looking for what must be the 10th time at the proposed gif: **one border of the matched bracket is thicker and one border of the matched bracket is thinner, depending on the position of the cursor relative to the bracket it sits on. Such a nice idea! But, please next time just also write this in words, I did not notice this change, it would save a lot of time.

Sorry! That also means my illustration sucked. Here is a thicker one


Added .gitignore

.gitignore was missing so I added it :smile:

Thanks but I'm not a fan of putting gitignores in my repos usually.


showing both date and time

Hello I use DateTime mode and I would like to show selected date and time after selecting the date and time only the date is showing without time, is there a way I could display them both?

I'm sorry @ramisalem , I can't understand your question. Please also add more details (e.g. Android/iOS)

If I setup mode="datetime" on Android I get console warning
Cannot open time picker TimePickerAndroid has been removed from React Native. It can now be installed and imported from '@react-native-community/datetimepicker' instead of 'react-native'.

@mmazzarolo That means, show date and time part at the same time in the modal, mainly for iOS.


Virtual notes can have children!!

Issue with calculating hasChildren(), hasParents() (probably also hasFirends()) for virtual notes

resolved in 0.0.12


DOC: updated badges

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.899%

Totals

Change from base Build<PHONE_NUMBER>3:
0.0%

Covered Lines:
5343

Relevant Lines:
5814

💛  - Coveralls


⚠ Bofrost.be has degraded performance

In 61bdacb, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1841 ms

Resolved: Bofrost.be performance has improved in c3c7b1d.


stability_margins doesn't find gain=1 crossover frequency correctly for DT systems

stability_margins doesn't find gain=1 crossover frequency correctly for DT systems, but it seems to mostly do so for CT systems. I think the probelm may be in how margins.poly_z_mag1_crossing is finding roots, but there were a few  steps in that function I couldn't follow, e.g. why H(z)*H(1/z)=1 implies |H(z)| = 1.
Example:
import control as ct
omegan = 2*np.pi
zeta = 0.2
plant = 1.1*ct.tf(omegan**2, [1, 2*zeta*omegan, omegan**2])
Ts = .05
plantdisc = ct.c2d(plant,Ts,'zoh')
#_ = ct.bode_plot(plant, margins=True) # gives correct gain=1 crossover freq
_ = ct.bode_plot(plantdisc, margins=True) # no gain=1/no phase margin given

As an example of what it should look like, here is Matlab:
omegan = 2*pi;
zeta = 0.2;
plant = 1.1*tf(omegan^2, [1, 2*zeta*omegan, omegan^2])
Ts = .05;
plantdisc = c2d(plant,Ts,'zoh')
margin(plantdisc)

why H(z)*H(1/z)=1 implies |H(z)| = 1

If I am not mistaken, it follows from |H(z)|²  = H(z) * conj(H(z)) = 1. Octave uses the same formula
But the algorithm had a bug. Thanks for noticing and reporting.

why H(z)*H(1/z)=1 implies |H(z)| = 1

If I am not mistaken, it follows from |H(z)|²  = H(z) * conj(H(z)) = 1. Octave uses the same formula
But the algorithm had a bug. Thanks for noticing and reporting.

I see, Makes sense if we are restricting the root search to the unit circle, where 1/z = conj(z).
And it has been a little while but I guess it must be that h(conj(z)) = conj(h(z))

I see, Makes sense if we are restricting the root search to the unit circle, where 1/z = conj(z).
And it has been a little while but I guess it must be that h(conj(z)) = conj(h(z))

Reopening I found another example that seems to confuse the current version: a 4th order system consisting of two slightly-damped resonances in series:
import control as ct
omegan = 1
zeta = 0.5
resonance = ct.tf(omegan**2, [1, 2*zeta*omegan, omegan**2])
omegan2 = 100
resonance2 = ct.tf(omegan2**2, [1, 2*zeta*omegan2, omegan2**2])
sys = 5 * resonance * resonance2
#100*ct.tf(1,[1, 0]) * ct.tf([1, 1], [1, 100]) * resonance
sysd = ct.c2d(sys, .001)

This seems to give a reasonable result for the continuous-time case:
ct.bode_plot(sys, margins=True);

but not for the discrete-time case:
ct.bode_plot(sysd, margins=True);

If I lower the damping ratio to zeta=0.05 it seems to be manage:

I see. Looks like this may happen any time the nyquist frequency is maybe 3+ orders of magnitude faster than the slowest pole. What do you think about a stopgap solution to detect this by looking at the relative order of magnitudes of numerator and denominator polynomial and either give a warning or revert to the interpolating numerical solution via the FrequencyResponseData class?

I was thinking to use the inaccurate but not completely wrong found crossing frequency as a starting point for a local numerical solve. That way we don't have to evaluate the whole frequency range again.

Unfortunately I have another example where it is nowhere close (they invovle solutions to a class I am teaching so I will have to do some obfuscation before I can post them : )

Using an interpolating FrequencyResponseData system as an intermediary produces pretty good results (see below). Which we could use as a starting point to get a better local numerical result using an optimizer as you suggested. What if I put in the FRD version as a stopgap (which will include some sort of a test for small numerator)? Yeah, it's slow. But it might serve as a starting point to do a better numerical solve?
omega = ct.freqplot._default_frequency_range(sysd)
sysdfrd = ct.FRD(sysd(np.exp(1j*sysd.dt*omega)), omega, smooth=True)
ct.bode_plot(sysdfrd, omega=sysfrd.omega, margins=True);

On option might be to include a method keyword someplace that allows you to tune the behavior of the calculation.  So if you specify method='FRD' then you get the behavior above.  This could be a way to keep from forcing every usage to be some slow method.

(am hoping to have something working in place for 0.9 for the discrete-time controls class I'm teaching starting March 29. The students will appreciate a working DT margin calculation! : )

If we can get this sorted out before ~22 March, we can do a 0.9.0 release that week to make it easy for students to install.

@murrayrm sure, a method keyword would make sense. What if I let that override things, but by default revert to the FRD method if it looks like the "old" method isn't going to give good numerical results?

Seems fine by me to have the default be something that works well.
You might consider setting up a benchmark file (in benchmarks/) that lets you see how much of a performance hit there is on some different examples.

In any case there should be a check, whether the current results are accurate enough and give a warning if not.


Type classes for common structures: preorders and partial orders

Description
Updated 6 Sep 2023 (to reflect some of the changes requested in conversation below)
This addresses issue #34 for the special cases of preorders and partial orders.
The goal of this PR is to allow us to use

a single relation symbol ≤, to denote the "less or equal" relation on each of the types ℤ, ℕ, and Slot---on which ≤ denotes a partial order---and on the Epoch type, on which ≤` denotes a preorder.

a single relation symbol < to denote the "strictly less than" relation on each of the types ℤ, ℕ, and Slot.

Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages
[X] Code is formatted according to CONTRIBUTING.md
[X] Self-reviewed the diff

I had to modify some proofs to make the type classes for inequalities work.
Note: although we're not using the inequality for Epoch yet, I included a type class for preorders, since that would be required for the Epoch inequality (which is not antisymmetric).

I prefer #221 to this one since #221 does more/better inequality inference and #221 is based off the latest master so has no conflicts.
Because of Ulf's new computation proofs, resolving conflicts of this PR and rebasing on the latest master will be quite challenging.  That's why I created the new PR #221

We've merged an alternative PR making this one obsolete.


Use 'static' return type in docblock

For example:
    /**
     * @param  string $name
     * @return static
     */
    public function setName($name)
    {
        $this->name = (string) $name;
        return $this;
    }

Instead @return AbstractMemberGenerator

I think in that case we should use $this, there is slightly difference between static and $this and I think it is good explained in PSR-5 draft (the bottom of the page):
https://github.com/phpDocumentor/fig-standards/blob/master/proposed/phpdoc.md

$this, the element to which this type applies is the same exact instance as the current class in the given context. As such this type is a stricter version of static as, in addition, the returned instance must not only be of the same class but also the same instance.

I agree

This repository has been closed and moved to laminas/laminas-code; a new issue has been opened at https://github.com/laminas/laminas-code/issues/7.


Sumo-0 Adding Kafka alerts

I think it better to add the same cluster filter in the alerts as well. For example, if I do not want to get alerts from all clusters I will be able to filter them. I just added it to Redis, you can check. Everything else looks good.

I think it better to add the same cluster filter in the alerts as well. For example, if I do not want to get alerts from all clusters I will be able to filter them. I just added it to Redis, you can check. Everything else looks good.

Done


Use velocity in animations and optionally in shouldOpenMenu

Why can't you just use a custom animationFunction for this purpose?

@Kureev  I am, but I still need the current velocity to be passed to the animationFunction


Llp uid2 1296 terms of service

Removes location from create account.
Removes the global line-height which was causing problems.
Adds terms of service text and removes it from the dialog wrapper.


Bumped node version to latest node:10

This could fix the problem:
ERROR: unsatisfiable constraints:
  musl-1.1.20-r4:
    breaks: musl-dev-1.1.23-r2[musl=1.1.23-r2]

It seems we need to force drone server to update the docker version whatsoever.
  builds:
    image: node:10-alpine  # alpine=3.9
    pull: true


Process PDF receipts

There should be a way to extract data from the PDF and run the same matchers on it.  Work around for now is to print them out and take a picture of them.

Works in v31

Works in v31


MSBuild crashes if environment variable too long

.NET rejects env var values over 32KB with ArgumentException. MSBuild sets environment varibles in several places and in this place at least does not handle that nicely. In this particular callstack it should perhaps just not set that environment variable. Possibly it should fail at initialization though if there's an environment variable that is so long it wouldn't be able to reset it when the build is done.
Note there's a (shorter) limit on env var name also.
https://github.com/dotnet/coreclr/issues/9793
06:57:53 Starting Build at 6:57:53.56
06:57:53 BUILD: Commencing CoreCLR Repo build
06:57:53 BUILD: Checking prerequisites
06:57:56 BUILD: Using environment: "C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\VsDevCmd.bat"
06:58:02 Installing .NET Version Manager to C:\Users\dotnet-bot.dnx\bin
06:58:02 Creating destination folder 'C:\Users\dotnet-bot.dnx\bin' ...
06:58:02 Installing 'dnvm.ps1' to 'C:\Users\dotnet-bot.dnx\bin' ...
06:58:02 Installing 'dnvm.cmd' to 'C:\Users\dotnet-bot.dnx\bin' ...
06:58:02 Adding C:\Users\dotnet-bot.dnx\bin to Process PATH
06:58:02 Adding C:\Users\dotnet-bot.dnx\bin to User PATH
06:58:06 Installing dotnet cli...
06:58:13 Restoring BuildTools version 1.0.27-prerelease-01209-01...
06:58:13 Initializing BuildTools ...
06:58:52 Updating CLI NuGet Frameworks map...
06:58:52 Done initializing tools.
06:58:52 Running: D:\j\workspace\x86_checked_w---b3a226f6\Tools\dotnetcli\dotnet.exe D:\j\workspace\x86_checked_w---b3a226f6\Tools\run.exe D:\j\workspace\x86_checked_w---b3a226f6\config.json build -Project=D:\j\workspace\x86_checked_w---b3a226f6\build.proj -generateHeaderWindows -NativeVersionHeaderFile="D:\j\workspace\x86_checked_w---b3a226f6\bin\obj_version.h" -BuildOS=Windows_NT -BuildType=Checked -BuildArch=x86
06:58:52 Running: D:\j\workspace\x86_checked_w---b3a226f6\Tools\msbuild.cmd /nologo /verbosity:minimal /clp:Summary /maxcpucount /nodeReuse:false /l:BinClashLogger,Tools/net45/Microsoft.DotNet.Build.Tasks.dll;LogFile=binclash.log D:\j\workspace\x86_checked_w---b3a226f6\build.proj /p:__BuildType=Checked /p:__BuildArch=x86 /p:__BuildOS=Windows_NT /t:GenerateVersionHeader /p:GenerateVersionHeader=true /p:NativeVersionHeaderFile=D:\j\workspace\x86_checked_w---b3a226f6\bin\obj_version.h
06:59:00
06:59:00 Unhandled Exception: Microsoft.Build.Shared.InternalErrorException: MSB0001: Internal MSBuild Error: Environment variable name or value is too long.
06:59:00 =============
06:59:00 System.ArgumentException: Environment variable name or value is too long.
06:59:00 at System.Environment.SetEnvironmentVariable(String variable, String value)
06:59:00 at Microsoft.Build.BackEnd.InProcNode.HandleShutdown(Exception& exception)
06:59:00 at Microsoft.Build.BackEnd.InProcNode.Run(Exception& shutdownException)
06:59:00
06:59:00 ---> System.ArgumentException: Environment variable name or value is too long.
06:59:00 at System.Environment.SetEnvironmentVariable(String variable, String value)
06:59:00 at Microsoft.Build.BackEnd.InProcNode.HandleShutdown(Exception& exception)
06:59:00 at Microsoft.Build.BackEnd.InProcNode.Run(Exception& shutdownException)
06:59:00 --- End of inner exception stack trace ---
06:59:00 at Microsoft.Build.Shared.ErrorUtilities.ThrowInternalError(String message, Exception innerException, Object[] args)
06:59:00 at Microsoft.Build.BackEnd.InProcNode.Run(Exception& shutdownException)
06:59:00 at Microsoft.Build.BackEnd.NodeProviderInProc.InProcNodeThreadProc()
06:59:00 at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
06:59:00 at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
06:59:00 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
06:59:00 at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
06:59:00 at System.Threading.ThreadHelper.ThreadStart()
06:59:01 Command execution failed with exit code -532462766.

I opened dotnet/corefx#16766 to accept longer variables but there will always be a limit and MSBuild should not crash.

@rainersigwald As we know that we have a limitation for environment variable values of 32,767 characters, should we first check and ignore the variable set if it has more than 32,767 characters?

The .NET Core change was to not attempt to validate the length ourselves (which we can get wrong depending on the platform, etc), but instead handle any OS error from trying to set it. MSBuild should do the same.
On recent .NET Core, you should still get ArgumentException
https://github.com/dotnet/runtime/blob/6072e4d3a7a2a1493f514cdf4be75a3d56580e84/src/libraries/System.Private.CoreLib/src/System/Environment.Variables.Windows.cs#L58-L61
(Not sure about Unix)

Handling ArgumentException will work just as well on .NET Framework as well, it's just that .NET will be throwing it based on its own (stricter) validation, vs .NET Core will be throwing it based on the OS rejecting it.

What you do if you get the exception is a decision to make, I guess either fail the build, silently continue, or log it could not be set and continue -- I'm guessing the latter.

@danmosemsft I was taking a look at the .NET Framework source code and I saw that it will throw the ArgumentException error if the value length is greater or EQUAL to 32767.
https://referencesource.microsoft.com/#mscorlib/System/environment.cs,902
Looking at the function SetEnvironmentVariableW documentation, which is used by .NET Core, we can see that the maximum size of a user-defined environment variable is 32,767 characters.
.NET Core implementation: https://github.com/dotnet/runtime/blob/6072e4d3a7a2a1493f514cdf4be75a3d56580e84/src/libraries/Common/src/Interop/Windows/Kernel32/Interop.SetEnvironmentVariable.cs
SetEnvironmentVariableW documentation: https://docs.microsoft.com/en-us/windows/win32/api/processenv/nf-processenv-setenvironmentvariablew
I tried to set a value with more than 32767 characters with .NET Core and I did not get an error.
Example:
string environmentVariableName = "ABC";
System.Environment.SetEnvironmentVariable(environmentVariableName, new string('a', 999999));
var value = System.Environment.GetEnvironmentVariable(environmentVariableName);

Am I doing something wrong?

My guess is that Windows raised the limit again. Feel free to offer an issue PR for their docs.
Environment.SetEnvironmentVariable("ABC", new string('a', Int32.MaxValue/4))
Expression has been evaluated and has no value
Environment.GetEnvironmentVariable("ABC").Length
536870911

This demonstrates why it was a good change to make the OS validate the length, rather than .NET. We'd have gotten it wrong again if we did it.


[FR] - Why are there no new versions of cardano-testnet in CHAP?

External
Describe the feature you'd like
Return package releases to CHAP? issues830

Thanks for the reminder, will do!

https://chap.intersectmbo.org/package/cardano-testnet-9.0.0/


ci: check wat correctness

This PR aims same as #164 does, but I opened a new PR, since we decided to rewrite whole changes.
Here, I run our .wat tests, and check that this .wat is correct.

You asked about linking, but I can’t find the corresponding comment now. Brief answer is that you’ll need to use the Linker type.

You asked about linking, but I can’t find the corresponding comment now. Brief answer is that you’ll need to use the Linker type.

Yep, I deleted my question because found Linker struct, it is exactly what we want here

@mooori, @nagisa I think I fix all your notes. Now I use Linker struct and code looks much better IMO


feat(social link): use MaterialUI in SocialLink component

Based on our team's decision, we no longer require approval of the refactoring pull request. Instead, we will review and approve the refactoring once all changes related to a specific component have been completed.
⚠ The text can have not the same font size as the original design, due to the Typography of Material Kit.
It's possible to adjust after all changes are done in the end.
Covers #831

BeforeNow


Version checker popping up too often

Version checker should pop up only once (or with checkbox to not show again).
Currently it is popping up every start of the tool, if newer version is available and option is turned on in settings.

fixed in v0.3.1 (since pre release 1)


In webadmin, adds a Herald tab that show the isolate accesses and the content of the directory

Implemented for Java and Python isolates


System param for dynamic resources

Objective
Support accessing dynamic resources in a dynamic system, including accessing them by component id.  This is similar to how dynamic components can be queried using Query<FilteredEntityMut>.
Solution
Create FilteredResources and FilteredResourcesMut types that act similar to FilteredEntityRef and FilteredEntityMut and that can be used as system parameters.
Example
// Use `FilteredResourcesParamBuilder` to declare access to resources.
let system = (FilteredResourcesParamBuilder::new(|builder| {
    builder.add_read::<B>().add_read::<C>();
}),)
    .build_state(&mut world)
    .build_system(resource_system);

world.init_resource::<A>();
world.init_resource::<C>();

fn resource_system(res: FilteredResources) {
    // The resource exists, but we have no access, so we can't read it.
    assert!(res.get::<A>().is_none());
    // The resource doesn't exist, so we can't read it.
    assert!(res.get::<B>().is_none());
    // The resource exists and we have access, so we can read it.
    let c = res.get::<C>().unwrap();
    // The type parameter can be left out if it can be determined from use.
    let c: Res<C> = res.get().unwrap();
}

Future Work
As a follow-up PR, ReflectResource can be modified to take impl Into<FilteredResources>, similar to how ReflectComponent takes impl Into<FilteredEntityRef>.  That will allow dynamic resources to be accessed using reflection.

@chescock can you resolve the conversations that have been resolved? @mweatherley, will this be useful for future iterations of BRP?

@mweatherley, will this be useful for future iterations of BRP?

I think so. The way we currently access components is as mentioned in 'Future Work', for example.

Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to https://github.com/bevyengine/bevy-website/issues/1713 if you'd like to help out.


Path-to-regexp buggs methods / routes?

Hey since yesterday I'm experiencing in my newly created project a bug where I set the handler, and methods (ex. /api/auth/register) and it works fine, but as soon as I installed path-to-regexp all my default (non-regexp paths) paths have broken.
For example:

but the regexp paths do work just fine.
My files were set to be:

/api/

/auth/

register.ts

login.ts

I also tried:

/api/

/auth/

/register/

index.ts // [[...params]].ts

/login/

index.ts // [[...params]].ts

and still it does not work (sometimes it does, but in a weird way - to doesn't then it does, and then it doesn't).

@ggurkal

Hi @xarielah
Thanks for the report!
There was a fix that was only released in the beta channel, but now it's released under v2.0.1 which should fix what you are experiencing.
Feel free to re-open if your problem persists.

I don't have anything to say but this product excites me in ways I didn't know possible. Next API routes with NestJS decorators is awesome...


Fix for "Run Current Query" keybind no longer behaving as expected (#…

…10538) (#10557)

-"Run current" command runs the entire selection instead of only first statement in the selection

-brought some logic back from the  old code to correct the behavior

-Added unit tests for runCurrent command

-Fixed a comment

Added checks for run input parameters

-Added some extra checks

-Fixed some spacing issue

Changed to using verify instead of a counter variable

This PR fixes #

@kenvanhyning This PR fixes #10557. The changes are already merged in the master. Please approve it for the release branch.

Coverage increased (+0.02%) to 34.282% when pulling 9b6e640fa1b743aafe1fda8c565d317d291a556b on aasim/release/1.19/runQuery into 9962363f4c7698d29307b1fe05db8ddb67e2652e on release/1.19.


Sending message with attachments exceeding undeclared in docs limit leads to an error

I am using .Net Google Api packages from Nuget:
<package id="Google.Apis" version="1.15.0" targetFramework="net45" />
<package id="Google.Apis.Auth" version="1.15.0" targetFramework="net45" />
<package id="Google.Apis.Core" version="1.15.0" targetFramework="net45" />
 <package id="Google.Apis.Gmail.v1" version="<IP_ADDRESS>0" targetFramework="net45" />

Request:
POST https://www.googleapis.com/gmail/v1/users/me/messages/send HTTP/1.1
User-Agent: [ProjectName] google-api-dotnet-client/<IP_ADDRESS> (gzip)
Authorization: Bearer [Secret]
Content-Encoding: gzip
Content-Type: application/json; charset=utf-8
Host: www.googleapis.com
Content-Length: 8516125
Accept-Encoding: gzip, deflate
Response:
HTTP/1.1 400 Bad Request
Content-Type: text/html; charset=UTF-8
Date: Tue, 09 Aug 2016 13:46:34 GMT
Expires: Tue, 09 Aug 2016 13:46:34 GMT
Cache-Control: private, max-age=0
X-Content-Type-Options: nosniff
X-Frame-Options: SAMEORIGIN
X-XSS-Protection: 1; mode=block
Server: GSE
Alternate-Protocol: 443:quic
Alt-Svc: quic=":443"; ma=2592000; v="36,35,34,33,32,31,30"
Content-Length: 145

<TITLE>Bad Request</TITLE>

Bad Request

Error 400

From the bug title, does this only appear if the file size is greater than a given size?
For the Google Cloud Storage API, you need to use a different codepath for files larger than 5MiB. Perhaps the GMail API has a similar requirement.
https://cloud.google.com/storage/docs/json_api/v1/how-tos/upload
This seems to make sense, at least for Cloud Storage, because if you are uploading large file you would want to use a resumeable upload, rather than have the entire transfer be aborted if it gets interrupted.

I don't know this API, but a couple of thoughts:

In the documentation for send, it specifies the maximum message size is 35MB. It looks like you have a compressed size of ~8.5MB, but I suspect that if the uncompressed size is >35MB you will correctly receive a 400 error. What's the uncompressed size of your message?
You're using the /gmail URL, I see there's also a /upload/gmail/ URL (see the docs) which I would guess is suitable for uploading large attachments. Have you tried using this URL? It looks like this'll be used by using this Send overload, and passing in a stream. Here's the guide for uploading attachmenets.

Hope this helps.

Thanks all!
@chrsmith, correct, the error only happens when sum of attachments sizes is more than 5mb. Looks like some limit on email size.
@chrisdunelm, as I remember, there wasn't resumable upload option in .net client in old versions of client or maybe I never succeed calling it. I saw docs on resumable upload before, didn't have chance to complete it. Anyway, now we have 1.10, and it looks like it should be. I'll check it. Thanks for you suggestion about Send overload.
For the first part, I didn't compressed anything. It is just big enough pdf or png in attachment (>5mb). Do I miss something?

Closing as stale. Please re-open if this is still an issue.


typo: Double word "to"

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/How-to-Test.md
:white_check_mark:Succeeded
View

articles/ReleaseNotes/CNTK_2_0_RC_3_Release_Notes.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Drop python2

If we want to merge this or not really depends on what we decide on #302.
In the meantime, I went ahead and did the basic cleanup to drop py27 and the compatibility layer we had for it. There's probably more, small, cleanups that we can do and will come across in future.
Note that pypy is compatible with python 3.2.5, so we can't use that.
Also, some doc said the minimum version was 3.3, and other places said 3.4. I've standardized it to 3.4; I guess the rest was outdated. It's 3.3. See below.
Closes #302
Closes #257 (no-longer-valid)
Closes #190
Check how this affects #207, #256.

3.3 should work, also there's pypy3 (not sure if it's production-ready)

Like I said, pypy3 is only python 3.2.5 compatible (hence <3.3).
Installation of some dependencies failed on it, so I didn't look any further.

Argh, yes.

:+

You're right, py33 works too. I've added it to the tests suite, and everything passes.

Is it okay to also remove these lines?
# vim: set ts=4 sw=4 expandtab sts=4 fileencoding=utf-8:

I actually use vim too, but I think that most contributors should already have this configured this way. It's also present in very few files anyway, so anyone relying on this will break other files anyway.

Yes, probably.
If we care about this http://editorconfig.org/ might be the way to go.
On Sat, Nov 28, 2015 at 04:31:38PM -0800, Hugo Osvaldo Barrera wrote:

Is it okay to also remove these lines?
# vim: set ts=4 sw=4 expandtab sts=4 fileencoding=utf-8:

I actually use vim too, but I think that most contributors should already have this configured this way. It's also present in very few files anyway, so anyone relying on this will break other files anyway.

Reply to this email directly or view it on GitHub:
https://github.com/geier/khal/pull/304#issuecomment-160349272

Does python 3 assume files to be utf-8 encoded?

Does python 3 assume files to be utf-8 encoded?

It does: https://docs.python.org/3/howto/unicode.html#the-string-type

Than sure, let's get rid of those vim lines (it probably was me who put them there in the first place and I don't need them).

do we need to add something to setup.py to indicate it's python 3 only?
Also, two weeks are nearly up :) and it looks like we won't loose too many users (I'll probably add a short description on how to run khal from a virtualenv later).
@hobarrera  feel free to merge this

do we need to add something to setup.py to indicate it's python 3 only?

I changed the hashbang from python to python3. I also updated the classifiers, to pypi will reflect the python3-status.


The demo is outdated.

The demo is outdated. Cause all of the image URLs are not reachable:
"https://storage.googleapis.com/cronet/sun.jpg",
"https://storage.googleapis.com/cronet/flower.jpg",
"https://storage.googleapis.com/cronet/chair.jpg",
"https://storage.googleapis.com/cronet/white.jpg",
"https://storage.googleapis.com/cronet/moka.jpg",
"https://storage.googleapis.com/cronet/walnut.jpg"

We have revived the image hosting, the demo is fully functional again.


possiblity to paginate a list?

Problem:
Cannot pass a list of DB results to the Scrivener.paginate/2 function.
Description
Sometimes I find that I get a list of results from the DB using Ecto and I need to do a some operation on the list outside the realm of Ecto and Ecto Queries.
With the finalized list post processing, I still need to paginate the list but currently scrivener does not support passing in a list for pagination.
Proposed Solution:
Add ability to paginate a list.
I've started on this already and trying it out at the moment. I'd appreciate your feedback.
Thanks for writing this library BTW.

I'll need to think about this. I know that Kaminari supports this, but I'm worried about feature bloat.

sure thing. If you decide to go with it, the moduledoc would probably need a few edits aswell.

@stephenmoloney In thinking this over, I'd prefer to put it in a different library, perhaps Scrivener.List or Scrivener.Extensions. I'd be happy to link to the project from the README here and, if things to well, we could consider merging in the functionality.

Ok, that sounds fair, I like composing applications from smaller parts too.
Scrivener.List sounds good. I'll keep you posted on progress.

Ok, that sounds fair, I like composing applications from smaller parts too.
Scrivener.List sounds good. I'll keep you posted on progress.

@drewolson
I've almost completed the ScrivenerList implementation. Only thing left is to publish it.
The deps are running off the protocol branch for now. {:scrivener, github: "drewolson/scrivener", branch: "protocol"}
I'll wait until Scrivener 2.0 is released before I publish this to hex docs and I'll bump it to 1.0 then.
If it looks okay to you, I'll make a PR request to add to link to the README at that stage. There's no rush on that.
Thanks for implementing the protocol. It seems to work nicely. The only downside I can see is that I couldn't generate docs for defimpl so I couldn't add separate docs for that module but I've added plenty in the README to make up for it.

This is close to what I was thinking, but you should only need the list.ex file, not the top-level scrivener_list.ex. I'll put together some more details tomorrow and add them here.

@drewolson
That is correct if scrivener_list is purely and exclusively for paginating a list when a Repo module has been configured. But I wanted to extend the capability a little bit further so that any list could be paginated independently of Ecto Repos and the Scrivener use Scrivener ...  statement.
So for example, one can paginate any list independently of an Ecto.Repo and a use Scrivener..  statement... provided that a %Scrivener.Config{} or keyword or maps opts is passed in as the second parameter.
The idea here is that projects which do not use Ecto Repos at all and maybe use a different database layer can still benefit from from a familiar interface in Scrivener by using ScrivenerList.

The paginate function is already provided directly to you on the scrivener module. It delegates to the protocol. If you only include your list.ex file, you could paginate a list like so:
Scrivener.paginate([1, 2, 3, 4, 5], %Scrivener.Config{...})

This keeps the interface consistent between protocol implementations and means that you don't need to write superfluous code (and your users don't need to use any other modules).

I'll also most likely add a new paginate clause to Scrivener that accepts a pageable and a keyword of options. This will prevent you from having to create a Scrivener.Config directly. This means you'd also be able to call paginate like so (without any extra code):
Scrivener.paginate([1, 2, 3, 4, 5], page_size: 2, page: 1)

One last thing: I've update my work in progress branch name from protocol to v2. Please update your dependency as necessary.

@drewolson
Perfect, these changes will work. I didn't realize that Scrivener.paginate/2 had changed to delegate to Scrivener.Paginater.paginate/2.
The only thing missing then is like you said the ability to pass a keyword opts or map of options. I think this feature would be a nice addition. :pray:
So I'll go ahead and remove my scrivener_list.ex top level file. The readme can act as docs.

all updated now
The readme is written on the presumption that the ability to pass keyword or map options to Scrivener.paginate/2. I've adding Pending notices for those comments. And I've commented out the tests for that feature too.
I'll just remove those comments later if that feature doesn't go ahead.

I saw your changes on v2 :+1:  and so I reintroduced the tests for keyword and map options and uncommented the pending notices. All tests passed. :tada:


#295barchart

Just discussed with Nele, she agrees about removing x and y axis labels, and the title ("comparison chart").
ideally also when we hover over the columns on the graph of the assays with categorical values, eg PAMPA or clearance, instead of having a number like 1 or 5.5 have the true name (low, med2high etc.)
also garrett might mention something about units, so for pIC50 could have X uM when you hover over the pIC50 column on the graph
if the hover stuff is harder then i think just remove the axis labels and title for now


调用openai_api_demo的接口v1/chat/completions报错

System Info / 系統信息
NVIDIA-SMI 530.30.02              Driver Version: 530.30.02    CUDA Version: 12.1
torch version :2.0.1+cu117
python版本：3.10
Who can help? / 谁可以帮助到您？
openai_api_demo模块的v1/chat/completions接口
Information / 问题信息

[X] The official example scripts / 官方的示例脚本
[ ] My own modified scripts / 我自己修改的脚本和任务

Reproduction / 复现过程
1、提供接口调用参数：{'messages': [ChatMessage(role='user', content='崇明岛旅游推荐', name=None, function_call=None)], 'temperature': 0.2, 'top_p': 1.0, 'max_tokens': 1024, 'echo': False, 'stream': True, 'repetition_penalty': 1.1, 'tools': None}
2、调用v1/chat/completions，系统抛错：
File "/home/ubuntu/.local/lib/python3.10/site-packages/uvicorn/protocols/http/httptools_impl.py", line 436, in run_asgi
result = await app(  # type: ignore[func-returns-value]
File "/home/ubuntu/.local/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 78, in call
return await self.app(scope, receive, send)
File "/home/ubuntu/.local/lib/python3.10/site-packages/fastapi/applications.py", line 276, in call
await super().call(scope, receive, send)
File "/home/ubuntu/.local/lib/python3.10/site-packages/starlette/applications.py", line 122, in call
await self.middleware_stack(scope, receive, send)
File "/home/ubuntu/.local/lib/python3.10/site-packages/starlette/middleware/errors.py", line 184, in call
raise exc
File "/home/ubuntu/.local/lib/python3.10/site-packages/starlette/middleware/errors.py", line 162, in call
await self.app(scope, receive, _send)
File "/home/ubuntu/.local/lib/python3.10/site-packages/starlette/middleware/cors.py", line 84, in call
await self.app(scope, receive, send)
File "/home/ubuntu/.local/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 79, in call
raise exc
File "/home/ubuntu/.local/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 68, in call
await self.app(scope, receive, sender)
File "/home/ubuntu/.local/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 21, in call
raise e
File "/home/ubuntu/.local/lib/python3.10/site-packages/fastapi/middleware/asyncexitstack.py", line 18, in call
await self.app(scope, receive, send)
File "/home/ubuntu/.local/lib/python3.10/site-packages/starlette/routing.py", line 718, in call
await route.handle(scope, receive, send)
File "/home/ubuntu/.local/lib/python3.10/site-packages/starlette/routing.py", line 276, in handle
await self.app(scope, receive, send)
File "/home/ubuntu/.local/lib/python3.10/site-packages/starlette/routing.py", line 66, in app
response = await func(request)
File "/home/ubuntu/.local/lib/python3.10/site-packages/fastapi/routing.py", line 237, in app
raw_response = await run_endpoint_function(
File "/home/ubuntu/.local/lib/python3.10/site-packages/fastapi/routing.py", line 163, in run_endpoint_function
return await dependant.call(**values)
File "/var/data/ChatGLM3/openai_api_demo/api_server.py", line 242, in create_chat_completion
output = next(predict_stream_generator)
File "/var/data/ChatGLM3/openai_api_demo/api_server.py", line 454, in predict_stream
yield "{}".format(chunk.model_dump_json(exclude_unset=True))
AttributeError: 'ChatCompletionResponse' object has no attribute 'model_dump_json'
Expected behavior / 期待表现
能正常返回回答结果

model_dump_json 检查你的依赖，pydanitc错了

model_dump_json 检查你的依赖，pydanitc错了
pydanitc需要什么版本的


PermissionsAndroid: Request permission only when response from rationale is positive

Summary
Currently, the library makes a call to request permission even though the user taps on a neutral or negative response in the rationale dialog after initially denying permission. The mods in this PR will make it so we only make a call to request for permissions when a user taps on a positive response.
Changelog
[Android][Changed] - Only request permission when the user gives a positive response to the rationale dialog.
Test Plan

For the following test cases, Camera permission was used to test.

Tap on a button that requests permissions. Approve the permission and make sure the function returns valid permission granted value true
-- Reset the permissions after this by either reinstalling or running adb shell pm reset-permissions
Tap on a button that requests permissions. Deny the permission and make sure the function returns valid permission granted value false.
Continuation from test case 2, tap on the button again so the rationale dialog pops up with three options. (buttonPositive, buttonNegative, buttonNeutral)
Continuation from test case 3, tap on buttonNegative, the dialog disappears and the function returns valid permission granted value false.
Continuation from test case 4, tap on buttonNeutral, the dialog disappears and the function returns valid permission granted value false.
Continuation from test case 5, tap on buttonPositive, the dialog disappears and a native android dialog appears to take user's permission.
Continuation from test case 6, tap on Deny. The native dialog disappears and the function returns a valid permission granted value false. This puts you back at 3
Tap on Approve. The native dialog disappears and the function returns a valid permission granted value true.

@Bhavik-P, I think this PR is yet to be merged because of the failed tests. Would you mind going through it please?

The failed tests have nothing to do with this pull request, some maintainer needs to review the request… @satya164 was the original author – could you have a look at this by any chance?

Will this PR fix the permission dialogue appearing twice when clicked Neutral Button? (explained here: https://github.com/facebook/react-native/issues/28876#issuecomment-729549664 )

Will this PR fix the permission dialogue appearing twice when clicked Neutral Button? (explained here: #28876 (comment) )

@ThatMate Yes. We use a patch for these changes until it eventually gets merged. Works flawlessly:
diff --git a/Libraries/PermissionsAndroid/PermissionsAndroid.js b/Libraries/PermissionsAndroid/PermissionsAndroid.js
index 83124ccc24bd05acac0158f71c73bc4113d84059..35275f097009811a94343abd9f0afee210bc8dda 100644
--- a/Libraries/PermissionsAndroid/PermissionsAndroid.js
+++ b/Libraries/PermissionsAndroid/PermissionsAndroid.js
@@ -216,14 +216,20 @@ class PermissionsAndroid {
           const options = {
             ...rationale,
           };
+          const constants = NativeDialogManagerAndroid.getConstants();
           NativeDialogManagerAndroid.showAlert(
             /* $FlowFixMe(>=0.111.0 site=react_native_fb) This comment
              * suppresses an error found when Flow v0.111 was deployed. To see
              * the error, delete this comment and run Flow. */
             options,
             () => reject(new Error('Error showing rationale')),
-            () =>
-              resolve(NativePermissionsAndroid.requestPermission(permission)),
+            (action, buttonKey) => {
+              if (action === constants.buttonClicked && buttonKey === constants.buttonPositive) {
+                resolve(NativePermissionsAndroid.requestPermission(permission));
+              } else {
+                resolve(this.RESULTS.DENIED);
+              }
+            },
           );
         });
       }

@Bhavik-P, I think this PR is yet to be merged because of the failed tests. Would you mind going through it please?

@klazbaba I don't think the failed tests have anything to do with this PR. If you know someone that can review my code changes and get this through the official pipeline for the upcoming release it would be great. We currently have a patch with this PR and had it in production since I made this PR.

Would it be possible to expose a way to provide callbacks in instances where the user choice is the neutral button or the negative button. Unless there's already a way to do so, as we already provide custom buttons for those options. i.e. The neutral button has the label "try again later" and as such, we be able to request such a permission after some said time

Would it be possible to expose a way to provide callbacks in instances where the user choice is the neutral button or the negative button. Unless there's already a way to do so, as we already provide custom buttons for those options. i.e. The neutral button has the label "try again later" and as such, we be able to request such a permission after some said time

Any update on this? This affects me on v0.61.5, and the changelog makes no mention of later fixes.

FB team: could we get an update about why this pull request hasn't been accepted?

Any update on this?

Please, can we have an update about this pull request ?

This PR is still nedeed. Can we please have an update from the team ?


docs(config) stats.orphanModules doc improved slightly

A small follow up to #3362 https://github.com/webpack/webpack.js.org/pull/3362/files#r357783625

Just for reference #2437


feat: notification filters

Description
Adds filtering by type for Notifications completing #1035
Types are represented by categories that are defined and ordered in lib/constants.js

Replies: Reply, Mention, ItemMention
Followed: FollowActivity
Stacking: Votification, ForwardedVotification
Earnings: Earn, Revenue, ReferralReward
Territories: TerritoryPost, TerritoryTransfer, SubStatus
Reminders: Reminder
Referral: Invitification, Referral
Payments: Invoice, InvoicePaid, WithdrawlPaid
Streak: Streak

Like Satistics, it relies on router.query to apply and retrieve filters (a user can bookmark the URL).
Unlike it, the modal enables multi-select before applying filters and it uses router.replace instead of router.push to maintain interoperability with the existing notifications page
Screenshots
Notifications page

Default modal, no filters

Modal with filters

Notifications page with filters on

Additional Context

SubStatus.name as id and BIGINT to NULL earnedSats values was necessary to make queries work on their own, could this be a problem? Notifications works as usual :P

Also I couldn't find a query for JobChanged so I left it as-is

Filters hue for light mode maybe needs to be changed?

FilterIcon color could be green or other color, I used --theme-brandColor

Checklist
Are your changes backwards compatible? Please answer below: Yes!
On a scale of 1-10 how well and how have you QA'd this change and any features it might affect? Please answer below:
7, I couldn't reproduce some notification types! Other than that, filtering consistently works and when no filters are applied, notifications follow the same behavior as before.
For frontend changes: Tested on mobile, light and dark mode? Please answer below: Tested on mobile, PWA and also in light (additional context) and dark mode.
Did you introduce any new environment variables? If so, call them out explicitly here: No

I knew I was forgetting something, filter persistence!
I could go and do it right away^^
Thanks a lot k00b!


Status of netpoll io_uring

Hello,
thank you for your work on this. I was considering working on this myself when I found your implementation.
What is the current status of your implementation in your judgement? Is it usable, do you need testers or someone to help you work on this?

duplicate https://github.com/cloudwego/netpoll/issues/77

@kaber2 We now have a interval version of uring, but it will have a lot of changes in netpoll. And, we dont know how it will affect stability because we dont have many uring use-cases in production environment. But if you want to implement it, welcome to provide your implement.

@joway

possible to open source the internal version of uring?
how much speed up compared with vanilla netpoll?

@kolinfluence previous answer already explained it.


Fix for issue #51: Remove extraneous characters

LGTM thanks ! Can you just please add one line in the changelog file ?

I've added a line in changelog under the most recent snapshot version, I hope that's where you wanted it. :)

Perfect, let's wait for the CI to pass :)


Update getting-started.md

Small grammar fix. Removed period in the middle of a sentence.

thank you


Ensure infoset file extension match output format.

Ensure infoset file extension match output format.

Done by checking if the filepath does not end with the proper file extension. If it doesn't then:

If the path ends with a different extension it is replaced with the extension of the output format.
If the path does not end with a different extension then the extension for the output format is added to the end of the file path.

Closes #845

@arosien I added a check to make sure we are only checking the infoset's file extension when the output type is file. I also added a warning message that will let the user know they don't have the proper file extension in the output filepath and that it will updated to automatically have the correct file extension.


Fix Few Final PSSA Rules

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[x] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[x] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

There were a few PSSA rules that had not been fixed by previous PRs. These should be the last remaining PSSA rules. After this PR it should be possible to enforce PSSA rules on all new PRs.
Approach

Added required code or override where previously discussed.
Commands to test

Invoke-ScriptAnalyzer .\Functions
Screenshots

:O 🎉 🎉 🎉 🎉 🎉  🙇 🙇 🙇 🙇 🙇

My Pleasure! 😁 Now on to writing integration tests to raise code coverage!

Thanks again! Will fix the one formatting failure post mege

merge

Was just about to fix that.

We needed to fix the formatter, and niph submitted a change so it worked out well 👍


Move filtered commits from gitops-working-group/gitops-working-group to cncf/tag-app-delivery

This PR helps bring the GitOps Working Group files in line with the rest of the WGs under App Delivery TAG.
To-do before merging

[x] Create tracking issues to move OpenGitOps portions of the WG README in this PR to open-gitops/project

[x] https://github.com/open-gitops/project/issues/20
[x] https://github.com/open-gitops/.github/issues/3
[x] https://github.com/open-gitops/website/issues/37
[x] https://github.com/open-gitops/project/issues/26
[x] https://github.com/open-gitops/project/discussions/23

[ ] Get WG maintainer approval for this move

[x] @chrispat
[ ] @csand-msft
[x] @todaywasawesome
[x] @jlbutler
[x] @murillodigital
[x] @scottrigby

Boring details

Moves relevant files from gitops-working-group/gitops-working-group to cncf/tag-app-delivery.
Maintainers of the GitOps WG are added to the CODEOWNERS file, so the WG can continue to operate in the same way it did with the earlier, separate repo. Note these are the same maintainers as for the OpenGitOps project.
Certain files and directories were omitted:

Previous meeting chat text files will be moved to a google drive, co-located with the WG Agenda and Notes Google doc
Artwork files are already moved to cncf/artwork, except the styleguides and linked images, and source files, which are not allowed in the cncf/artwork repo. We'd like to keep those somewhere and this seems like a good place
Files relevant only to the OpenGitOps project have been omitted from this PR, will be moved to the appropriate repo in the https://github.com/open-gitops org.

Any teams, projects, issues, discussions, etc in gitops-working-group/gitops-working-group that are still relevant will be moved to open-gitops/project.
The git-filter-repo project was used to carry only only relevant commits into this PR branch. This properly brings in commits from working group members to the gitops-wg directory of this repo.
Once the move of all files from gitops-working-group/gitops-working-group is complete, that README will be edited to point here, and that repo will be archived.

This is awesome! We are also increasing adoption of GitOps via KubeVela within Alibaba and broader community.

/lgtm

@scottrigby wrote:

Once the move of all files from gitops-working-group/gitops-working-group is complete, that README will be edited to point here, and that repo will be archived.

After archival, would you manually migrate contents from https://github.com/orgs/gitops-working-group/projects to https://github.com/cncf/tag-app-delivery/projects ?  Thank you.

@scottrigby wrote:

Once the move of all files from gitops-working-group/gitops-working-group is complete, that README will be edited to point here, and that repo will be archived.

After archival, would you manually migrate contents from https://github.com/orgs/gitops-working-group/projects to https://github.com/cncf/tag-app-delivery/projects ?  Thank you.

@lloydchang the current plan is to move relevant GH "projects" from the WG to https://GitHub.com/open-gitops/project.
If there is a good reason for the GitOps WG to have GitHub projects outside of the OpenGitOps CNCF project, we could talk with the App Delivery TAG folks about the administrative side of this. I haven't yet heard that we need that though. WDYT?


ARROW-10114: [R] Segfault in to_dataframe_parallel with deeply nested structs

library(arrow, warn.conflicts = FALSE)
download.file("https://gist.githubusercontent.com/mskyttner/6700d6a7fe4c3d296f449171897a3ed6/raw/9f65035b3ba6d2859c5fedffced230b6184d4149/head.jsonl", "/tmp/head.jsonl")
df <- read_json_arrow("/tmp/head.jsonl")
names(df)
#> [1] "master"            "publications"      "publication_count"

Created on 2020-10-09 by the reprex package (v<IP_ADDRESS>01)

Do we want to add head.jsonl, or perhaps some other minimal fixture that triggered the bug, to the test suite?


multi-line 'else if' statements not formatted.

the code below not formatted:
else if () then
foo()
bar()
end if
when 'if' started on new line the code formatted well:
else
if () then
___foo()
___bar()
end if

@evgygor Can you provide a fully functional code snippet, or create a fork with a runnable unit test showing how this fails (you can just add a new test to BrightScriptFormatter.spec.ts)? I tried guessing what you were doing above that starting else if ().
This block of code formats properly in my tests.
if true then
    doSomething()
else if () then
    foo()
    bar()
end if

@TwitchBronBron currently, I cannot reproduce the issue . I suggest the issue may be closed.

I rechecked - works well.
Thanks