[WIP] Simple example

An increment-only counter shared among peers, as a strawman to test and improve upon the user-facing API.
Suggested action items from this experiment:

Rename mesh.Config to mesh.RouterConfig
Modify mesh.NewRouter to place mesh.RouterConfig last, and ensure sensible defaults if fields aren't specified
Create simplified mesh.NewSimpleRouter constructor, with fewer options
Remove non-MAC-based PeerName, and amend MAC PeerName documentation to make it clear it's not strictly necessary to use a MAC address
Move InitializeConnections to the Router object directly, so we can eliminate connectionMaker from the exported API
(more TODO)

Remove non-MAC-based PeerName, and amend MAC PeerName documentation to make it clear it's not strictly necessary to use a MAC address

But if MAC PeerName is the only one supported, then how would one "not use a MAC address"?

The problem is that you have a choice that's conditional on a build flag, which no one will use. Perhaps we can strictly type PeerName string and provide multiple constructors, NewHardwareAddrPeerName, NewHexPeerName, NewHashablePeerName, etc.

That won't work. The choice of peer name representation is a build time flag for a reason: it affects the protocol and therefore has to be the same on all weave peers.


Talented Tigers

Two commits slightly over the deadline; both are readme/installation related and small.
--
No merge issues
--
no flake8 linting errors

Hello. We have a few changes we'd like to make to the installation process to ensure that the site works on everyone's machines. We would like to know if they could be added to our team folder? Here are the changes:
The README.md Installation Section was changed to the contents shown here https://paste.pythondiscord.com/xahejosubi.md

We changed the Windows installation steps and added a note to always view the site at http://localhost:8000.

A new run-windows.py script was added and can be found here: https://paste.pythondiscord.com/urevewoqoy.py
This sets up and runs the site locally without showing the API key in the command.
In spydirweb/settings.py, we set ALLOWED_HOSTS = ["*"] so that there were no issues with certain hosts not working.
Let us know if you would be willing to make these changes, thanks!

@SebastiaanZ Hello, I have made a pull request, it can be found here: https://github.com/python-discord/summer-code-jam-2020/pull/136


simple unit tests for nexus units function

Codecov Report
Base: 78.10% // Head: 78.16% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (b25cf00) compared to base (df63317).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
+ Coverage   78.10%   78.16%   +0.05%
==========================================
  Files         182      182
  Lines       30923    30884      -39
==========================================
- Hits        24152    24140      -12
+ Misses       6771     6744      -27

Impacted Files
Coverage Δ

resqpy/olio/simple_lines.py
39.66% <0.00%> (-0.50%)
:arrow_down:

resqpy/derived_model/_add_faults.py
91.62% <0.00%> (-0.47%)
:arrow_down:

resqpy/olio/keyword_files.py
48.00% <0.00%> (-0.37%)
:arrow_down:

resqpy/model/_forestry.py
78.92% <0.00%> (-0.22%)
:arrow_down:

resqpy/fault/_gcs_functions.py
63.46% <0.00%> (-0.12%)
:arrow_down:

resqpy/olio/factors.py
96.96% <0.00%> (-0.09%)
:arrow_down:

resqpy/time_series/_from_nexus_summary.py
91.00% <0.00%> (-0.09%)
:arrow_down:

resqpy/lines/_polyline.py
85.10% <0.00%> (-0.07%)
:arrow_down:

resqpy/olio/vdb.py
55.60% <0.00%> (-0.07%)
:arrow_down:

resqpy/well/well_utils.py
95.00% <0.00%> (-0.07%)
:arrow_down:

... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Move backwards-compatible yet cross-unsafe mkDerivation behavior behind a single switch

During a native build, stdenv has some behaviors that are inappropriate from a cross-compilation perspective yet were kept to reduce churn and increase compatibility (e.g. packages in buildInputs being in PATH during the build). We should have these "cheats" behind a single flag so we can easily track (ideally in CI) how much we need to fix before we can disable it altogether.
Action item from #35543

https://github.com/NixOS/nixpkgs/pull/40529 puts the strict dependency handling behind strictDeps instead of crossConfig, which is much more intuitive is one might want strict deps without cross compiling too.


Binding libraries like Crashlytics use Throwable, which which leads to unusable logs

Android framework version
net8.0-android
Affected platform version
Microsoft Visual Studio Community 2022 (64-bit) - Current Version 17.11.5
Description
I initially opened this issue in the AndroidX bindings but was told that here would be a better place for this issue. (see https://github.com/xamarin/AndroidX/issues/1011)
The main issue is that Crashlytics uses Java.Lang.Throwable. To convert our exceptions to this type we can use Java.Lang.Throwable.FromException. However, the resulting crash logs are pretty hard to read and use compared to when we were using AppCenter (to be deprecated in 2025). On top of that  inner exceptions are not even displayed, so for some issues it's impossible to know what actually happened.
Given the deprecation of AppCenter and Firebase being the logical alternative (other than sentry), it feels like a big downgrade to not be able to get proper readable logs.
I believe this could improve a lot and make Crashlytics more useful if it was solved at the .net android level
Steps to Reproduce

Create a new project and set up Firebase Crashlytics
Throw a simple error -> This shows that the crashlytics error is usable but hard to understand, also firebase crashlytics groupping will not work very well in this case
Create an inner exception like starting a task and throwing and error from inside (the inner exception is not logged and thus you loose crucial information)

Did you find any workaround?
You have some control over managed crashes by preparing the throwable a bit better, but unmanaged crashes are directly handled by Firebase, which doesn't leave us any way to improve it
Relevant log output
Example of AppCenter crash:

Xamarin Exception Stack:
System.Exception: Exception NavigateToFirstViewModel
  at x.AppStart.NavigateToFirstViewModel(Object hint)
  at MvvmCross.ViewModels.MvxAppStart.StartAsync(Object hint)
  at x.Droid.Activities.RootActivity.RunAppStartAsync(Bundle bundle)
  at x.Droid.Activities.RootActivity.OnResume()
  at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)
  at Android.App.SyncContext.<>c__DisplayClass2_0.<Post>b__0()
  at Java.Lang.Thread.RunnableImplementor.Run()
  at Java.Lang.IRunnableInvoker.n_Run(IntPtr jnienv, IntPtr native__this)
  at Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PP_V(_JniMarshal_PP_V callback, IntPtr jnienv, IntPtr klazz)
--- End of inner exception stack trace ---
  System.NullReferenceException: Object reference not set to an instance of an object
    at x.Droid.UIManager.KeyboardHelper.EnableKeyboard(Activity activity)
    at x.Droid.MvxServices.UserInterfaceService.SetDisableKeyboard(Boolean disabled)
    at x.AppStart.NavigateToFirstViewModel(IAppStartStatusService appStartStatus, IMvxNavigationService navigationService, BusinessLogic dataService, IApplyUserSettingsService settingsService, IUserInterfaceService userSettingsService, IEventTracker eventTracker, String startName)
    at x.AppStart.NavigateToFirstViewModel(Object hint)

Same issue in Crashlytics:

Fatal Exception: android.runtime.JavaProxyThrowable: [System.Exception]: Exception NavigateToFirstViewModel
       at x.AppStart+<NavigateToFirstViewModel>d__6.MoveNext()
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification()
       at MvvmCross.ViewModels.MvxAppStart+<StartAsync>d__5.MoveNext()
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification()
       at x.Droid.Activities.RootActivity+<RunAppStartAsync>d__10.MoveNext()
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess()
       at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification()
       at x.Droid.Activities.RootActivity+<OnResume>d__8.MoveNext()
       at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
       at System.Threading.Tasks.Task+<>c.<ThrowAsync>b__128_0()
       at Android.App.SyncContext+<>c__DisplayClass2_0.<Post>b__0()
       at Java.Lang.Thread+RunnableImplementor.Run()
       at Java.Lang.IRunnableInvoker.n_Run()
       at Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PP_V()
       at mono.java.lang.RunnableImplementor.n_run(SourceFile)
       at mono.java.lang.RunnableImplementor.run(SourceFile:1)
       at android.os.Handler.handleCallback(Handler.java:938)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loop(Looper.java:223)
       at android.app.ActivityThread.main(ActivityThread.java:7680)
       at java.lang.reflect.Method.invokeNative(Method.java)
       at java.lang.reflect.Method.invoke(Method.java:423)
       at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

Looking at the whole crashlytics log, there is no reference at EnableKeyboard function, which is the one that threw the error

We should investigate extending 1aa0ea7a8aef616d00e8467aa9eec83a1571cbd0 to include the Inner Exceptions.
The "problem"/"concern" is that the Java stack trace consists of StackTraceElements.  Can we put in "arbitrary" text for the class and method name? Would it be possible to have a class or method name containing e.g. -- Begin inner exception …?


Add "order" key for team members

Description
We lost the correct ordering a while back when our team.json was removed, falling back to the file order (alphabetical). This re-introduces order based on a new order key. Ordering is done by C-Suite, followed by joined date.
Checklist

[x] I have read the contribution guidelines

Out of interest as I missed it happening, why was team.json removed? The ordering it provided was one of the reasons for it to exist.

@knolleary see: https://github.com/flowforge/website/pull/520
Its just taken me a lot longer than it should have to get this PR in as I'd forgotten about it until Yndira recently added herself and Tracey, and asked me to PR review


Improve cli arguments

Hello @baronfel, I noticed that the usage of the CLI tool didn't really feel well during the stream.
I'm thinking to change the following:

Also accept a response file as input. Currently, the input is a fsproj which will be rebuilt each run. If you need to do subsequentials runs you can use the rsp file instead.
Allow to save the fsc args as a response file. Either via --record while you are doing the initial run, or via --record-only where you wouldn't process any file at all.
Invert --write with --dry-run. So, no arguments would always write the file to disk. Adding --dry-run would print to console.

Thoughts?

That all sounds lovely! Another idea - since you already support binary log reading, why not allow someone to specify that directly as well?


[fix][io] Remove unused import statement in the MariadbJdbcAutoSchemaSink

Modifications
When install pulsar-io-jdbc-mariadb module occurred checkstyle error.

mvn clean install -pl pulsar-io/jdbc/mariadb

[INFO] --- maven-checkstyle-plugin:3.1.2:check (checkstyle) @ pulsar-io-jdbc-mariadb ---
[INFO] There is 1 error reported by Checkstyle 8.37 with /Users/zc/IdeaProjects/pulsar/buildtools/src/main/resources/pulsar/checkstyle.xml ruleset.

[ERROR] src/main/java/org/apache/pulsar/io/jdbc/MariadbJdbcAutoSchemaSink.java:[23,8] (imports) UnusedImports: Unused import: java.util.stream.Collectors.

Related PR：#17950
Modifications
Remove unused import statement in the MariadbJdbcAutoSchemaSink.
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/coderzc/pulsar/pull/12

Codecov Report

Merging #18031 (442048b) into master (6c65ca0) will decrease coverage by 4.71%.
The diff coverage is 40.00%.

@@             Coverage Diff              @@
##             master   #18031      +/-   ##
============================================
- Coverage     34.91%   30.20%   -4.72%
+ Complexity     5707     3948    -1759
============================================
  Files           607      393     -214
  Lines         53396    43422    -9974
  Branches       5712     4462    -1250
============================================
- Hits          18644    13114    -5530
+ Misses        32119    28398    -3721
+ Partials       2633     1910     -723

Flag
Coverage Δ

unittests
30.20% <40.00%> (-4.72%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...g/apache/pulsar/compaction/CompactedTopicImpl.java
11.42% <0.00%> (+0.71%)
:arrow_up:

...broker/delayed/InMemoryDelayedDeliveryTracker.java
22.00% <50.00%> (+22.00%)
:arrow_up:

.../pulsar/broker/service/SharedConsumerAssignor.java
3.70% <0.00%> (-64.82%)
:arrow_down:

...ion/pendingack/impl/MLPendingAckStoreProvider.java
16.86% <0.00%> (-50.61%)
:arrow_down:

...tent/NonPersistentDispatcherMultipleConsumers.java
0.00% <0.00%> (-48.15%)
:arrow_down:

...saction/recover/TransactionRecoverTrackerImpl.java
0.00% <0.00%> (-45.17%)
:arrow_down:

...apache/pulsar/broker/service/TopicListService.java
10.65% <0.00%> (-44.27%)
:arrow_down:

...saction/timeout/TransactionTimeoutTrackerImpl.java
0.00% <0.00%> (-43.86%)
:arrow_down:

...ar/broker/transaction/util/LogIndexLagBackoff.java
0.00% <0.00%> (-42.86%)
:arrow_down:

...ion/buffer/matadata/TransactionBufferSnapshot.java
0.00% <0.00%> (-42.86%)
:arrow_down:

... and 300 more


Modernize scrollbar look for TextArea

This task is completed. Refer to the changes

The scrollbar has been enhanced for its modern look and feel.
See


Rife v4.25 for Live Action

@hzwer
v4.25 is good and is probably a little better than 4.18 when using SVP as long as I lower the Scene Detection threshold. This slightly increases stuttering but reduces the remaining artefacts. Almost all of my remaining artefacts are reduced. Only my Amazing Spider-man horizontal double image issue remains obvious. But even that can be fixed if I lower SC threshold to 6, but the stutters increase and negatively affects everything else.
When you say that you "increased blocks" does that mean more interpreted frames between real ones?

No, I mean I changed the architecture of Flow model.

Good News!
I mean I changed the architecture of Flow model.

I have very little idea how any of this works so apologies in advance for this question. But is it sensible to suggest that you change the architecture of the Flow Model using the model data, or are you already doing that, or is this just total nonsense?

I don't quite understand your question, so I don't know if I have provided the corresponding answer:
v4.25 uses same dataset as v4.18. The number of blocks in the structure of IFNet has been adjusted.
v4.25 still has potential for improvement because it is an intermediate (2/3) training result of the model, and the final model will be available in three days.

I don't quite understand your question, so I don't know if I have provided the corresponding answer:
v4.25 uses same dataset as v4.18. The number of blocks in the structure of IFNet has been adjusted.
v4.25 still has potential for improvement because it is an intermediate (2/3) training result of the model, and the final model will be available in three days.

You have answered my questions and given us hope of even better things to come 🥳


Segment fault

Thank your for your work.
I use python3.8, pytorch=1.7.1 or 1.7.0. always segment fault.

Same with my situation. Do you solve this issue?

Mine is below and it works
Python 3.8.1
torch                         2.0.1
torchsummary                  1.5.1
torchvision                   0.15.2


revert LICENSE back to MIT

The license file appears to have been accidentally changed. This pull request fixes the license and puts it back to MIT.
The MIT license is required for metrics working groups per the CHAOSS charter 8.2.3.

Thank you Georg.


🌐 Add Portuguese translation for docs/tutorial/security/index.md

This PR translates the tutorial/security/index.md and add this page to the mkdocs.yml file.

Awesome, thank you @oandersonmagalhaes! :nerd_face: :rocket:
And thanks for the reviews @izaguerreiro, @cassiobotaro, @vitumenezes, @lsglucas! :bow: :cake:


TableWriter replace directory with path to CSV

https://github.com/project-lighter/lighter/blob/5741df30c4cd1b86c76216247cb67f3748ecf1d6/lighter/callbacks/writer/table.py#L25C28-L25C28

@ibro45 I don't see any benefit gained by keeping this a directory

You're right. I guess we can just get the parent dir of the csv file and pass it to the super init(), wdy think?

@dosubot


fix(checkbox): check for null reference

fixes https://github.com/aurelia-ui-toolkits/aurelia-materialize-bridge/issues/485

Thanks, Max! 👍
I need a(nother) day or two to sort a few things out and then I'll merge.


Glusterfs 3.12.3 backport for 17.09

Motivation for this change
17.09 backport of #31782
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.
[X] Tested on my production cluster

FYI @bachp

@GrahamcOfBorg build glusterfs


feat: add typesafe i18n with next-intl blog link in community blog posts

Added link to blog that includes following:

Integrate next-intl in Next.js app (App router)
Use next-intl outside of React components
Split translations strings into multiple files
Introduce typesafety in translations
Use next-intl with server components

Thanks a ton for the article you've written and published @adarshaacharya! ❤
I wrote you a longer message on X, but regarding this PR, I'm removing the community links section: https://github.com/amannn/next-intl/pull/1398. I hope you can understand!

Thanks for feedback @amannn . Closing this PR :)


Bump SQL Tools Service to 3.0.0-release.101

Picks up a couple dbpool fixes and the DacFx bump.

Pull Request Test Coverage Report for Build 817500277

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.004%) to 43.555%

Totals

Change from base Build 815368707:
0.004%

Covered Lines:
26478

Relevant Lines:
55324

💛  - Coveralls


Types definiton for textarea

Feature Request
When working with Typescript and textarea, I'm not able to access to HTMLTextAreaElement directly
Problem description
To access to HTMLTextAreaElement, I have to put the following code
//@ts-ignore
editorRef.current?.ref?.current

If not, Typescript give me the following error:
TS2551: Property 'ref' does not exist on type 'TextArea'. Did you mean 'refs'?

Proposed solution
Update the type definition for TextArea class

Please don't access private properties of class components, that's why they are not present in types definitions. You will be also can be affected by changes that will not be considered as breaking. Before #3819 will be solved and refs will be supported natively please use Ref component:
<Ref innerRef={textRef}> // use ref from there
  <TextArea placeholder='Tell us more' />
</Ref>


Alphabetize imports within groups

In order to provide absolute ordering, rather than just group-wise ordering, this PR offers an alphabetize option that enforces locale-aware alphabetical intra-group ordering.
It makes no effort to provide a more robust fix experience, so multiple passes may be necessary to bring a set of imports into a stable configuration, though since an absolute ordering is available, a single-pass fix probably isn't unreasonable.
Closes #1105.

Coverage increased (+2.9%) to 97.399% when pulling<PHONE_NUMBER>56ae426764ae34900d7a06298a8f4a on duncanbeevers:alphabetize into ebafcbf59ec9f653b2ac2a0156ca3bcba0a7cf57 on benmosher:master.

We ended up writing a custom eslint plugin that we could tune to support our specific ordering rules. I closed this issue since I no longer need the functionality myself.
If someone wants to take this to completion feel free, but I'm setting it aside.

@ljharb I finished making the changes in my repo: https://github.com/dannysindra/eslint-plugin-import/tree/alphabetize.
So I made the following configs for the alphabetize option:

order: [string] - either ignore (do not use alphabetize), asc, or desc
ignoreCase: [boolean] - if true put upper before lowercase, if 'false' put upper and lowercase together

Please let me know if you have any feedback / questions. This is my first contribution btw, so I apologize in advance if I made beginner mistakes here and there

@ljharb thanks for the quick response! My bad, I tried to rebase and somehow must have pulled and merged. I am trying to understand what causes the tests to fail here.. it passes locally and on some env in the AppVeyor; but failed on others? Also, is there a way to run the coveralls locally?

@dannysindra make sure you're checking out the rebased version; the travis tests are failing too.

@ljharb alright, I have rebased, and pushed again with the fix 7fa20f0

@dannysindra thanks, updated (next time, please delete your local branch, and re-check it out from 3db6bd7)

@ljharb it seems something wrong with the master branch?  The PR suddenly has new 41 failing tests... I am not sure what to do now :(

cc @benmosher for failing tests on master

@ljharb it seems the master has been fixed. Do you mind re-running the tests again? Or should I rebase again first?

@dannysindra There are conflicts, so you can start by rebasing the branch.
The tests will re-run with the new push.

This still needs a rebase.

Definitely want this! :D

Any progress on getting this merged?

rebased : https://github.com/stropho/eslint-plugin-import-1/commit/b80dc108280b638229a6f148e1fe10795f1c3c5e

Want it !

Any progress on this? I'm ready to contribute to this feature

Any progress on this? I'm ready to contribute to this feature

Good to hear. Right now, it's in a state of waiting for the maintainers to express themselves - and possibly merge it  https://github.com/benmosher/eslint-plugin-import/pull/1360


Add name and proxyEndpoint in indexer entity

Context
Currently we have metadata field in indexer entity, which is an IPFS cid. In order to get the values user need to have a further request from IPFS, but it's not efficient sometimes.
Requirement
Would like to decode the name and proxyEndpoint in advance and save in the indexer entity.
In that case user can get these value directly from one query. These 2 values need to update with metadata updated event.
We can still keep the metadata ipfs to make it flexible.
Solution
There has 2 solution:

Add name and proxyEndpoint in indexer entity directly
Create a new entity IndexerMetadata and derive the values from it

@lamcc21 update for the final solution. We would like to have a individual IndexerMetadata entity which contains:
id: ID! # indexer address
metadata: String # Ipfs hash to metadata
name: String # indexer name
endpoint: # indexer proxy endpoint

This entity need to be update with UpdateMetadataEvent and indexer entity have a metadata filed derives from it


How do I remove an anchor link

I'm really keen on this plugin. However, when using your demo version I add a link there doesn't seem to be a way to remove it. I highlight the linked text, then click on the link icon again (usual UI behaviour) but it brings up another modal box.
Am I missing something?

This is the default behaviour of the browser's contentEditable functionality. You'll have to delete the link (e.g. select the text + backspace), and re-add it with the button.
Unfortunately it's little things like this added all over the place that make existing WYSIWYG editors very large in size.


Istioctl enable ILB Gateway

Bug description
Expected behavior
istioctl manifest generate --set values.gateways.istio-ilbgateway.enabled=true creates the appropriate config
Steps to reproduce the bug
istioctl manifest generate --set values.gateways.istio-ilbgateway.enabled=true
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
1.4.3
How was Istio installed?
istioctl
Environment where bug was observed (cloud vendor, OS, etc)
MacOS
Additionally,  using --set unvalidatedValues.gateways.istio-ilbgateway.enabled=true does not create an ILB configuration as well.

looks like for 1.4.3, this can only accept istio-ingressgatey.
https://github.com/istio/operator/blob/1.4.3/pkg/apis/istio/v1alpha1/values_types.pb.go

Seems like Istio 1.5.0 was released without this. I'm quite eager to move from Helm to istioctl. It looks like master still only accepts the default istio-ingressgateway. Are there plans to fix this issue?

@seeruk and others, there's no separate ILB anymore but it's possible to create an ILB gateway in 1.5 by setting serviceAnnotations like this:
spec:
  ingressGateways:
  - name: istio-ilbgateway
    enabled: true
    k8s:
      serviceAnnotations:
        cloud.google.com/load-balancer-type: "internal"
        service:
          ports:
          # ...

Note that there's a bug in 1.5.0 that affects gateway naming fixed in https://github.com/istio/istio/pull/22138 that will be part of 1.5.1, so the name above currently will still show up in the generated manifest as istio-ingressgateway.
We're going to update the docs and provide some gateway examples as part of 1.5.1 release.

@ostromart
So starting v1.5.0 we don't have istio-ilbgateway any more and the workaround is to modify istio-ingressgateway (add annotation to make LB internal)?


Got the AI to review its codebase. These are the suggestions it gave back.

Instructed the AI to review its own codebase for improvement/optimization. This is the advice that it gave back for doing so:
Based on the codebase overview and the code optimization techniques, here are some suggestions for improvement and/or optimization:

1. In the `Agent` class, the `takeAction` method has a `sleep` function call in the `finally` block. This could be replaced with a more efficient scheduling mechanism, such as using `setTimeout` or `setInterval` to schedule the next action.

2. The `Memory` class could benefit from more advanced compression techniques to reduce the memory footprint and improve performance. This could include using data structures like Bloom filters or more efficient serialization methods.

3. The `Message` class and related functions could be refactored to use a more efficient data structure or encoding method to reduce the overhead of message passing between agents.

4. The `ModuleManager` class could be optimized by using a more efficient data structure for storing and retrieving module definitions, such as a trie or a hash table.

5. The `ActionHandler` class could be optimized by using a more efficient method for dispatching actions, such as a priority queue or a task scheduler.

6. The codebase could benefit from more aggressive inlining of small functions to reduce function call overhead.

7. Dead code elimination and constant propagation could be applied to the codebase to remove unnecessary code and simplify expressions.

8. Global register allocation could be used to optimize variable storage and access in the codebase.

These are just a few suggestions for improvement and optimization. Further analysis and profiling of the codebase would be necessary to identify more specific areas for optimization.

With a bit more instruction, I can probably get it to implement some of these suggestions into the codebase, but this seems to be one of the first autonomous AI, possibly the first written in TypeScript, which might actually have the potential to effectively improve itself.

Okay, set up a PR for the first change. Attempted the second change. Not confident enough with memory compression to know if this makes any sense, but these are the contents of each of the files created in the memory-compression folder the Agent created for the second improvement:
bloom-filter.ts
class BloomFilter {
  private size: number;
  private storage: Uint8Array;

  constructor(size: number) {
    this.size = size;
    this.storage = new Uint8Array(size);
  }

  private hash1(value: string): number {
    let hash = 0;
    for (let i = 0; i < value.length; i++) {
      hash = (hash * 31 + value.charCodeAt(i)) % this.size;
    }
    return hash;
  }

  private hash2(value: string): number {
    let hash = 0;
    for (let i = 0; i < value.length; i++) {
      hash = (hash * 37 + value.charCodeAt(i)) % this.size;
    }
    return hash;
  }

  add(value: string): void {
    this.storage[this.hash1(value)] = 1;
    this.storage[this.hash2(value)] = 1;
  }

  contains(value: string): boolean {
    return (
      this.storage[this.hash1(value)] === 1 &&
      this.storage[this.hash2(value)] === 1
    );
  }

  remove(value: string): void {
    this.storage[this.hash1(value)] = 0;
    this.storage[this.hash2(value)] = 0;
  }
}

export default BloomFilter;

efficient-serialization.ts
import { Event } from '../src/memory';

function serializeEvent(event: Event): string {
  const serializedEvent = JSON.stringify(event);
  // Implement a more efficient serialization method here
  return serializedEvent;
}

function deserializeEvent(serializedEvent: string): Event {
  const event = JSON.parse(serializedEvent);
  // Implement a more efficient deserialization method here
  return event;
}

export { serializeEvent, deserializeEvent };

memory-compression-integration.ts
import Memory from '../src/memory';
import BloomFilter from './bloom-filter';
import { serializeEvent, deserializeEvent } from './efficient-serialization';

class CompressedMemory extends Memory {
  private bloomFilter: BloomFilter;

  constructor(size: number) {
    super();
    this.bloomFilter = new BloomFilter(size);
  }

  addEvent(event: Event): void {
    const serializedEvent = serializeEvent(event);
    this.bloomFilter.add(serializedEvent);
    super.addEvent(event);
  }

  hasEvent(event: Event): boolean {
    const serializedEvent = serializeEvent(event);
    return this.bloomFilter.contains(serializedEvent);
  }

  // Override other Memory methods to integrate the Bloom filter and efficient serialization methods
}

export default CompressedMemory;

Unfortunately I don't think most of these are good suggestions. These agents are fairly dumb and do better with more focused instructions after an in-depth design discussion with a knowledgeable coder.

Yeah, that makes sense. I didn't give it a lot of context to work off from and I'm not strong enough with TypeScript to know whether the suggestions make any sense.

That being said, you said most weren't good suggestions. Are there any that you noticed that were good?

That being said, you said most weren't good suggestions. Are there any that you noticed that were good?

No... lol. It's all pretty much premature optimization. There's absolutely no memory, disk or algorithmic inefficiency bottleneck that is hurting performance right now, the heavy lifting is all done in OpenAI's cloud and we're just providing some light scripting to orchestrate it.

Makes sense. Gonna close this out then. No point in getting it to improve upon things that aren't really bottlenecks.

It was an interesting experiment though!


Grammar bug for connectors not in packages

It looks like a connector that is not in package is not handled correctly. The action invocation gives a syntax error. Sample:
import ballerina.net.http;
import ballerina.lang.message;
import ballerina.lang.system;

connector SimpleSOAPHttpConnector (string url) {
  http:HTTPConnector h = new http:HTTPConnector("http://localhost:9090");

  action post (SimpleSOAPHttpConnector s, xml payload) (message response) {
     xml soapPayload;
     message m;

     soapPayload = `<s:Envelope xmlns:s="foo"><s:Body>$payload</s:Body></s:Envelope>`;
     m = new message;
     message:setXmlPayload (m, soapPayload);
     response = http:HTTPConnector.post (h, "/echo", m);
     return response;
  }
}

function main (string[] args) {
  SimpleSOAPHttpConnector sc;
  message result;
  xml xp;

  sc  = new SimpleSOAPHttpConnector;
  xp = `<hello>I am xml.</hello>`;
  result = SimpleSOAPHttpConnector.post (sc, xp);
  system:print (message:getStringPayload(result));
}

Error:
$ ballerina st.bal
st.bal:27:40: Unwanted token '('

Hi Sanjiva,
This issue is fixed in the master branch. Below is the working version of the above sample (with the new grammar changes):
import ballerina.net.http;
import ballerina.lang.messages;
import ballerina.lang.system;

connector SimpleSOAPHttpConnector (string url) {
    http:ClientConnector h = create http:ClientConnector("http://localhost:9090/" + url);

    action post (SimpleSOAPHttpConnector s, xml payload) (message response) {
        message m = {};
        xml soapPayload = `<s:Envelope xmlns:s="foo"><s:Body>${payload}</s:Body></s:Envelope>`;
        messages:setXmlPayload (m, soapPayload);
        response = http:ClientConnector.post (h, "/echo", m);
        return response;
    }
}

function main (string[] args) {
    SimpleSOAPHttpConnector sc  = create SimpleSOAPHttpConnector("echo");
    xml xp = `<hello>I am xml.</hello>`;
    message result = SimpleSOAPHttpConnector.post (sc, xp);
    system:print (messages:getStringPayload(result));
}

Closing the issue as it works on master. Please reopen if the issue still exists.


Add a server side check for random book query

Currently, we have added a check on the client side so that user can see the random book modal for the very first time.
We need to add the same check on the server side also.

@pankaj-ag please update the status label on this.

@pankaj-ag I am not clear about few things here:

Where is the server side check needed?
Is this the client clide check that you mentioned in the description?
$unreadBook = (session('disable_book_suggestion')) ? null : Book::getRandomUnreadBook();


Update barcode QR reader widget

IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes https://github.com/opensrp/fhircore/issues/3350
Description

Overrides barcode layout to contain required missing views
to avoid crash on render with error
FATAL EXCEPTION: main
                                                                                Process: org.smartregister.opensrp.diabetesCompassClinic, PID: 8413
                                                                                java.lang.NullPointerException: findViewById(...) must not be null
                                                                                at com.google.android.fhir.datacapture.views.factories.QuestionnaireItemViewHolder.<init>(QuestionnaireItemViewHolderFactory.kt:64)
                                                                                at com.google.android.fhir.datacapture.views.factories.QuestionnaireItemViewHolderFactory.create(QuestionnaireItemViewHolderFactory.kt:37)
                                                                                at com.google.android.fhir.datacapture.QuestionnaireEditAdapter.onCreateViewHolderQuestion(QuestionnaireEditAdapter.kt:88)
                                                                                at com.google.android.fhir.datacapture.QuestionnaireEditAdapter.onCreateViewHolder(QuestionnaireEditAdapter.kt:64)
                                                                                at com.google.android.fhir.datacapture.QuestionnaireEditAdapter.onCreateViewHolder(QuestionnaireEditAdapter.kt:49)
                                                                                at androidx.recyclerview.widget.RecyclerView$Adapter.createViewHolder(RecyclerView.java:7295)

Engineer Checklist

[ ] I have written Unit tests for any new feature(s) and edge cases for bug fixes
[ ] I have added any strings visible on UI components to the strings.xml file
[ ] I have updated the  CHANGELOG.md file for any notable changes to the codebase
[ ] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
[ ] I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
[ ] I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

[ ] I have verified Unit tests have been written for any new feature(s) and edge cases
[ ] I have verified any strings visible on UI components are in the strings.xml file
[ ] I have verifed the CHANGELOG.md file has any notable changes to the codebase
[ ] I have verified the solution has been implemented in a configurable and generic way for reuseable components
[ ] I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS looks good! seems like the only thing missing is test coverage

Good catch! That string does not look correct, we also want to set the string from fhircore because we need to be able to translate it


pressKey doesn't work with Shift inside text field

What are you trying to achieve?
Trying to enter "Shift + a" inside text field to make it "A",
What do you get instead?
but it shows only "a".

Provide console output if related. Use --verbose mode for more details.

[ 'Shift', 'a' ]
[ '' ]

Provide test source code if related

Feature('search.feature');

Scenario('test something', (I) => {
    I.amOnPage('/');
    I.pressKey(['Shift', 'a']);
    pause();
});

Details

CodeceptJS version: 2.4.3
NodeJS Version: 11.5.0
Operating System: Windows
puppeteer || webdriverio || protractor || testcafe version (if related) webdriverio
Configuration file:

exports.config = {
  tests: './*_test.js',
  output: './output',
  helpers: {
    WebDriver: {
      url: 'http://www.google.com',
      browser: 'chrome'
    }
  },
  include: {
    I: './steps_file.js'
  },
  bootstrap: null,
  mocha: {},
  name: 'Webdriver',
  plugins: {
    retryFailedStep: {
      enabled: true
    },
    screenshotOnFail: {
      enabled: true
    },
    wdio: {
      enabled: true,
      services: ['selenium-standalone']
    }
  }
}

Going through the code, in lib/helper/Webdriver.js, pressKey(key) calls getNormalizedKey.call(this, key) twice in case of using an Array, once in that method and again in pressKeyDown/Up method. Are we trying to get normalized key of Shift twice here? Is that causing this issue?

Thanks for investigating this
If you know how to fix that please send PR!

Also, Ctrl+W (in windows) does not close a window, that does not have focus on text field.

I am facing same issue with
I.pressKey(['Shift', 'F10']);


Add session state

Codecov Report

Merging #12 (fa05d2c) into main (9050e9d) will decrease coverage by 91.23%.
The diff coverage is 0.40%.

@@            Coverage Diff             @@
##             main     #12       +/-   ##
==========================================
- Coverage   95.65%   4.42%   -91.23%
==========================================
  Files           2      10        +8
  Lines          23     520      +497
==========================================
+ Hits           22      23        +1
- Misses          1     497      +496

Flag
Coverage Δ

pytest
4.42% <0.40%> (-91.23%)
:arrow_down:

python-3.10
3.46% <0.40%> (-66.11%)
:arrow_down:

python-3.7
3.67% <0.40%> (-74.59%)
:arrow_down:

python-3.8
3.84% <0.40%> (-78.77%)
:arrow_down:

python-3.9
4.42% <0.40%> (-91.23%)
:arrow_down:

st-_0.65.
3.46% <0.40%> (-70.46%)
:arrow_down:

st-_1.2.
3.46% <0.40%> (-70.46%)
:arrow_down:

st-_1.3.
3.46% <0.40%> (-70.46%)
:arrow_down:

st-_1.4.
3.07% <0.40%> (-57.80%)
:arrow_down:

st-_1.8.
2.88% <0.40%> (-53.64%)
:arrow_down:

st-_latest
2.69% <0.40%> (-49.49%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Can't open some CPU profiles with the builtin flame chart editor

Testing #164476

2022-10-26 09:06:11.198 [error] TypeError: Cannot read properties of undefined (reading 'selfTime')
    at e.buildModel (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/ms-vscode.vscode-js-profile-table/out/extension.js:1:37873)
    at e.CpuProfileEditorProvider.openCustomDocument (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/ms-vscode.vscode-js-profile-table/out/extension.js:1:34838)
    at f.$createCustomDocument (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:94:194986)

renderer-profile-1666722014345.cpuprofile.zip

I say "some" profiles because I see some that were apparently stored yesterday that I can open. But today now that I'm looking in the right place for the logs, I've only managed to produce several .cpuProfiles that all show this error when opened.

@roblourens where exactly does the file come from? The renderer-profile-prefix doesn't look like an autogenerated one

Am I not looking at the right thing? I see
2022-10-26 09:54:52.147 [info] [perf] stored profile to DISK '/tmp/renderer-profile-1666803292101.cpuprofile' fc0d1267-d194-4c27-9b80-cdba8250f123 in the main log, and when I open that I get the same error.

@roblourens Are you sure that you are on latest? That message used to be printed in the main-log but got removed a couple of days ago (https://github.com/microsoft/vscode/commit/fec87f38cbd82f6603a44cf1686c54c3f08ffd73). Now the message is printed in the renderer log (it confusingly starts with exthost which will be fixed tomorrow)

it might be that the analysis (to find the heavy samples) mutates the actual profile but with latest insiders that shouldn't matter anymore

Hm. I'm using the snap on linux, I thought I'd checked that it had actually updated, but must have been out of date, sorry. Today I have the latest, and I tried the scenario again. Got a few profiles like /tmp/renderer-397b7e.cpuprofile, and can open all of them in vscode


An absent feature reports always changes

Even they are absent. Objects aren't affected.
Maybe the reason is that feature (available) configs always managed and an directory is created for assemble.

The last commit adds a list with all "absent" features, those featues will be handled within a separate assemble task. This task won't use the notify attribute to reload the deamon.
If this suites the purpose, I'll be happy to close the issue.

Tested again, works as preferred.


[Community] We need icon and promotional image for hypertrons-crx

We need icon and promotional image for hypertrons-crx community:

[ ] App icon (logo)

128x128 px
PNG format
Work well on both light and dark backgrounds.

[ ] Promotional image

440x280 or 440x280 or 920x680 px

We can check https://developer.chrome.com/docs/webstore/images/ for some requirements for the images.

Any progress? @heming6666

Any progress? @heming6666

We can use the following image as our logo:

Closed.
We can reopen it if needed.


Use spork. I'll also make it so test server instance (slows down startup) only starts for tests where it is used


Two RandomFlip layers with same seed do not return the same result

System information.

Have I written custom code: No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04
TensorFlow installed from (source or binary): pip install
TensorFlow version (use command below): 2.9.2 / 2.10.1 / 2.11.0
Python version: 3.8

Describe the problem.
With TensorFlow 2.10+, two RandomFlip layers instantiated with the same seed do not return the same result. For instance, when applying the two random flip operations on an image, I expect that the two augmented images are both flipped or not, with the same output. However, this is not the case: on multiple runs, the two augmented images are not always equal (see standalone code below).
Note that with TensorFlow 2.9.2, the expected behaviour is observed: same result for both RandomFlip layers. Since TensorFlow 2.10, this is not the case anymore.
Note also that for two RandomRotation layers with the same seed, the same rotation is applied on the image, whatever the version of TensorFlow (2.9, 2.10 and 2.11). This seems to be the expected behaviour, compared to the RandomFlip behaviour.
Standalone code to reproduce the issue.
import tensorflow as tf
print(tf.__version__)

x = tf.convert_to_tensor([[[1], [0]]]) # Tensor of shape (1, 2, 1)

# Create two RandomFlip layers with same seed
seed = 42
flip1 = tf.keras.layers.RandomFlip(mode="horizontal", seed=seed)
flip2 = tf.keras.layers.RandomFlip(mode="horizontal", seed=seed)

# Run 100 times random flip with the two layers
# In TensorFlow 2.9, same result every time (100 %)
# In TensorFlow 2.10+, not the same result every time
total = 0
N = 100
for i in range(N):
    y1 = flip1(x)
    y2 = flip2(x)
    if tf.math.reduce_all(tf.equal(y1, y2)):
        total += 1
print(f"y1 / y2 equal? {total / N * 100} %")

Thanks @tilakrayal for the gist. Indeed, the outputs of both RandomFlip layers are 100% identical with v2.9, but not with v2.11 and nightly. It's the same behaviour I observed.

I found out the issue. I will submit a pr soon.

I have an issue. I have tensorflow installed through pip. I would want to address the keras issue, change the corresponding file and then test this new version of keras for the changes. When i do pip install it gets installed in the dist-packages for python. How do i change the imported version of tensorflow with these new changes and test my changes.
In other words while doing development for this bug how do i import tensorflow with the changes i made so that i can test them on a gist like above? I use a virtual env for development and have working knowledge of git. Any help would be greatly appreciated. Tia.

@sachinprasadhs Would you be able to help me out with my issue

There has been some changes made in the above mentioned code.
Anyways, RandomFlip layer under the hood uses RandomGenerator https://github.com/keras-team/keras/blob/master/keras/engine/base_layer.py#L3802.
It takes handles the random number generation using user specified seed value.
I'm not sure on what changes the behavior changed since 2.10 version onwards.

@LukeWood could you take a look? Or get this to relevant CV person?
To me it looks like this was a regression introduced with the newer KerasCV changes, but then got reverted here https://github.com/keras-team/keras/commit/af76a1a391bf32ef9fb03615654fd8d5875788c1. So this might just be fixed in 2.12? I def don't have all the context on the latest with image augmentation layers though.

@mattdangerw thanks for the heads up, yeah we can take a look.

TF 2.12 seems to fix this bug. However, the bug is still present in the nightly version 2.13.0-dev20230322. See gist here.


docs: moved cert manager to global

Fixes #3513

Moved cert manager to global in all in the installation files.

@RealAnna
i have made the specified changes !

Thanks @BalaadityaPatanjali! Can you please fix the indentation issues?  https://github.com/keptn/lifecycle-toolkit/actions/runs/9644648822/job/26655448383?pr=3560

@RealAnna fixed the indentation issue !

Thank you for the merge !


Time-0 race condition for simulation

Minimal test case. simbug.zip
Summary:
The Verilog that nMigen outputs can contain time-0 race conditions which cause problems for simulation.
Details:
I'm running through the Zero to Asic course using nMigen. The digital design part assumes you're writing Verilog, runs the code through Icarus Verilog, and then simulates/tests using cocotb. Everything is fine, except I managed to stumble into a Verilog simulation subtlety. Best explained by the Icarus Verilog FAQ:

My "always" statement doesn't trigger at time 0. Is Icarus Verilog broken?

In this case, the bug is most likely in your program, and is probably the most common and unnoticed error in the entire history of Verilog use. Your program probably looks something like this:

reg [7:0] a, b, c;
always @(a or b) c = a + b;
initial begin a = 1; b = 2; end

This is in fact a race condition at time zero. James Lee has this to say:

[T]he bug is the race between the always at time zero getting to the @ and the initial setting the values.  A #1 in the initial block before changing a or b should do the trick.
I think that most verilog simulators have some sort of trick to catch the changes at time zero.
The IEEE 1364-1995 standard is also clear on this issue: the given example leaves c with an unpredictable value at time 0. This is a frightfully common mistake, we've all done it. It often goes unnoticed because compilers often start threads from first (in the source file) to last. It just so happens that Icarus Verilog, by a detail of implementation, starts threads from last to first.

What people don't typically realize is that #0 <statement> has a well defined meaning. I suggest that you preceed statements in your initial processes with a #0 to eliminate the race, like so:

reg [7:0] a, b, c;
always @(a or b) c = a + b;
initial #0 begin a = 1; b = 2; end

This improved version doesn't have a time-0 race--if the initial block is scheduled ahead of the always block, the ``#0'' will tell the scheduler to first yield to all other threads, then continue.

The Verilog generated by nMigen is something like this:
reg [3:0] a = 4'h0;
...
always @* begin
  ... use a here
end

This results in the time-0 race described above. While not synthesizable, manually altering the Verilog resolves the problem:
reg [3:0] a;
initial #0 begin a = 4'h0; end
...
always @* begin
  ... use a here
end

You'd think that you could use a reset signal to reset registers to known states, but that doesn't fix the problem.
I emphasize that this is a simulation issue, not a synthesis issue. I'm honestly not sure what the solution here is. I don't really want to see initial #0 in Verilog for synthesis.

This is a well known issue. There is a workaround for it that's supposed to be firing here, but doesn't. I'll look into it.

Wait, no, this is a different, much less well known issue. I've actually never seen this before, but it makes sense:

[T]he bug is the race between the always at time zero getting to the @ and the initial setting the values. A [#0] in the initial block before changing a or b should do the trick.

I don't really want to see initial #0 in Verilog for synthesis.

Why not? I believe that most, possibly all, synthesizers ignore it, to solve exactly this kind of issue. Alternatively, we could guard its use with `ifdef SYNTHESIS.

Oh, I didn't know that synthesizers would ignore it -- I thought they'd yell and scream about non-synthesizable statements. In that case it's fine to put it in there!
You mean something like this?
`ifdef NONSYNTHESIZING
  initial #0 begin ... end
`endif

BTW, I found that in the generated Verilog, this will not work:
  (* src = "simbug.py:12" *)
  reg _b = 1'h0;
  initial #0 begin _b = 1'h0; end

But this does:
  reg _b;
  initial #0 begin _b = 1'h0; end

Another interesting data point. If I compile simbug.py to rtlil, then use yosys to convert that to verilog via:
yosys> read_rtlil simbug.il
yosys> proc
yosys> write_verilog simbug.v

Then the test passes. Presumably because there are no always @* in the output? I dunno.

Hi,
I ran into this a year ago and I thought it was a bug in Icarus Verilog (my bad), so I reported it here.
There are two possible workarounds that, while none of them is a clean solution, may help someone until this is solved:

use Icarus Verilog <= v10.1 where variables were initialized at t=0 regardless of the standard used
use the parameter -g2005 in iverilog (the drawback is that you'll lose support for System Verilog)


numpy error when using latest 1.1.0 release

Hi, first of all thanks for the great package and support.
I had been using the 1.0.2 version through manually building and installing the package since I have an apple silicon mac and everything worked as intended. I updated to the latest version 1.1.0  since you added support for m1/m2 macs but now I am getting this error:
from ._quantile_forest_fast import QuantileForest   File "quantile_forest/_quantile_forest_fast.pyx", line 17, in init quantile_forest._quantile_forest_fast   File "__init__.cython-30.pxd", line 986, in numpy.import_array ImportError: numpy.core.multiarray failed to import
I have numpy 1.22.4. I see that you didn't specify a numpy version in the requirements but I was wondering if there was a specific version required or if you could have an idea on why this could be happening ?
Thank you very much.

Thanks for raising the issue. I'll work on identifying the source of this error to see if there's a way to get it resolved; otherwise I'll update the version requirements.
In the meantime, upgrading your version of NumPy should solve the error. The wheels are currently being built with NumPy 1.23.4, so that version should certainly work.


Spec Export Not Working on Sketch 41

No HTML file is generating after doing the SpecExport.

fixed~ v2.3.1


Fix memory leak in change_last_ack

Fixes #29.

@r58Playz Could you please apply the working code in the PR?

Applied.


Feature request: Support updating out of sync workspaces (including conflict resolution)

Similar requests

[X] I have searched and found no existing similar requests

How are you using Studio?
Legend Studio
What problems are you trying to solve?
Provide an interface to users to handle local conflicts in changes.
For now this can occur in two situations

User current workspace revision is outdated with the head of workspace. Conflicts resulted in local changes vs base/head of workspace.
User apply patches and conflicts results from patch changes and local changes.

Describe the solution you would like to see implemented

Workspace conflict

[x] Provide user notification when workspace is not in sync with head revision. i.e when saving, local change viewer

Main Conflict Resolution

[x] Compute the diff between the base revision and the current revision
[x] Compute conflicts between the 2 sets of changes
[x] Create an interface (similar to conflict resolution) to resolve the conflict, in the end, we end up with changes in the workspace. Bug detected https://github.com/finos/legend-studio/issues/814

Describe alternatives you have considered
No response
Documentation, Design, Adoption, Migration Strategy
No response
Contribution

[X] I would like to work on this feature

Discussed with the highly sought-after @MauricioUyaguari and the decision is to leave model loader out of this. Model loader operation is imperative and will override anything as well as do a hard reload on the graph, there's no safety, conflict check we would need to do, but if we do hard save like in https://github.com/finos/legend-studio/issues/191, we would probably need to do some safety check.


Add style guide

@jpfairbanks, @epatters, I have moved the style guide into the "Developer Docs" section of the Catlab documentation and merged it with the existing pull request guidelines that used to be in the wiki.


maps_search result in error

I'm trying to use this tool, I've read the doc about maps_search, and it tells nothing about my problem.
That's the code:
from gomaps import maps_search
results = maps_search("Ristoranti Divignano Piemonte", log=True, page_num=1)
p = results[0].get_values()
print(p)

running it I can see in the terminal from the log=True that it is working correctly, but instead of termitating returning the retrieved data it crash with:
<gomaps.GoogleMaps object; Place-Name: Ristorante Sapor di Vino>
<gomaps.GoogleMaps object; Place Not Found>
Traceback (most recent call last):
  File "main.py", line 3, in <module>
    results = maps_search("Ristoranti Divignano Piemonte", log=True, page_num=1)
  File "/home/loris/.local/lib/python3.8/site-packages/gomaps/gmapss.py", line 293, in maps_search
    return GoogleMapsResults(q, page_num=page_num, delay=delay, log=log)
  File "/home/loris/.local/lib/python3.8/site-packages/gomaps/gmapss.py", line 219, in __init__
    result = GoogleMaps(name, session=self.__sesh)
  File "/home/loris/.local/lib/python3.8/site-packages/gomaps/gmapss.py", line 63, in __init__
    self.__set_url(url_components); del(self.__resp)
  File "/home/loris/.local/lib/python3.8/site-packages/gomaps/gmapss.py", line 100, in __set_url
    path = re.search(fr'{prefix}.+?/data.+?\\"', self.__resp.text).group()
AttributeError: 'NoneType' object has no attribute 'group'

it would be fine if it exit the search before throwing error

Thank you for bringing up this issue. It was throwing an error because one of the places in the results wasn't an actual place but a region. I've pushed a patch to resolve this. Please update to the latest version!


Removed linter: dupl

Change Overview

Removed linter dupl
Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test
[ ] :building_construction: Build

Issues

fixes #3034

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

yet to fix some issue .

Same as the other PR. Please add some description to explain the changes.

Same as the other PR. Please add some description to explain the changes.

same

@julio-lopez I'll try to finish off these linter thing as fast as I can . Just please assist me in review❤. Thankyou


Windows Compiling (Working on getting it to work)

I have been working hard on trying to get this miner to compile in windows- If I do so, I plan to submit m work. These are the things I have found so far that can be done (I don't know if they are the best thing to do).
1.) Pancurses
It seems pancurses will work in windows, so far setting it as backend for curses seems to work, and uses it doesn't generate errors regarding it while compiling. I have fully completed a compile yet to know if it is successful.
2.) Pthreads
To my limited knowledge, if you manually load in pthreads-w32 lib, and specify it in lieu of pthreads.h, It seems like it starts reducing compile errors , but there are still errors..However, there are still little code fixes which I am trying to see if I can implement to make it work. Has anyone considered maybe switching the codebase to boost? I read that it performs better anyways, but I'm not too familiar with both to have a serious grasp on it. I was going to look into that.
3.) xargo
xargo seems to resolve a lot of std issues, but not all of them. It seems to be a good start, using xargo build instead of cargo. However, I have to make some small changes to make it work, which I will post if I ever get a compiled version.
4.) compile flags.
I am still testing compile flags, but most of the flags set right now seem to be ignored when attempting to compile. I am working on researching and changing them to suit Windows.
I have reached close to about 85% of the project being successfully compiled for a test run. At this point I am down to getting the plugins to compile.
I post this, as I see nobody else immediately attempting to figure out how to get it to work in Windows, I figure others may have suggestions which may assist.

It should be possible to get grin-miner itself working on windows without having to introduce 3rd party libraries for threading or non-standard tools (and most certainly not boost,) but the reason nobody is working on this at the moment is that the solvers themselves are completely linux pthread bound. They would need to be reworked quite a bit to get them working on windows, and given there are community alternatives for windows mining, it doesn't seem a priority at the moment.

Actually, there is currently no miner for AMD that works with nicehash windows. I have users begging me to make something happen, as I was able to compile the linux version for AMD nicehash support. So I have been trying to port over to windows. It doesn't seem the windows versions plan to support it anytime soon.

Plus, just in general, it would be nice to contribute to a cool project, and great job with what you have done so far.

I think with latest PR #246 this should compile on Windows. However I had some issues with cmake locally? I'll see if I can setup the CI with Windows later.

I'm closing that one. I believe it is possible to compile it for windows now.


Support for layers

Hi Peter, great project -- I happened to stumble across this on YouTube and it's exactly the kind of lightweight solution I'm looking for.
I'm curious if you have considered support for adding layers of images? My use case would be to gradually add and remove certain components from the Excalidraw diagram over the course of a presentation. My opinion is that the easiest way to do this as a user would be to:

transition between different images (the Excalidraw drawing) of the same size, in the background, with everything else being the same.
keyframe between the layers (either completely, or with transparent backgrounds so both can be seen)

Let me know if that brief description makes sense; happy to elaborate or perhaps contribute on any fronts that make sense for you.

Hi Joshua,
Thanks for your kind words! I apologize for answering this late – I was on a 4-week long vacation and had not a suitable device to write this long answer. 😅

Regarding your question: Yes, I considered such a feature. Let me give you a short insight into how it started:

I wanted to present Excalidraw scenes progressively.
I tried out this tool: https://github.com/dai-shi/excalidraw-animate – Blocking problems: The order of the animation steps can not be changed.
Used Apple Keynote to present my Excalidraws with panning and zooming.
I built Pan'n'Zoom mimicking the Keynote effect – just more straightforward.

As you can see, I stuck to that concept. Panning and zooming are necessary; "revealing" elements can be done by increasing the next keyframe's size – that was the idea. But it's suboptimal.
Having both features (step-by-step panning/zooming and step-by-step masks) would allow to:

reveal elements one by one in a smaller area without the need for any movement (reduced cognitive load),
move to different areas when one wants to jump to the "next big picture."

My initial "MVP" list contained the feature "allow the user to blur non-keyframe area" – but I ditched it. I think it would be awesome to reveal elements/areas step-by-step!

While hiking in Slovenia, I had time to think about the problem. I see two options from the architecture perspective:

(a) Different images (as you suggest) for the keyframes (image A for keyframes 1-4, image B for keyframes 5-12, ...).
(b) Mask editor within the tool: Let the user define which parts of the image are visible for each keyframe.

Intuitively, I would pick (b) because of the following aspects:

Storing and exporting multiple images (method (a)) would come at the high cost of big files and long loading times.

Storing per-keyframe mask information (SVG?) is probably way cheaper.
Displaying mask SVGs is probably way faster.

Managing many image variants can become frustrating.

I also developed the tool to be able to replace just one/the image when I fix a typo in the image ...
... with many images, this would become a tedious task.

Let's you animate "area-revealing" with images you don't have the source file for anymore to create variants for it ... respectively: The user does not need to use an image editor to create variants.
Masks could be changed/adjusted super fast in the editor.

When I had this thought of a "mask editor", immediately the Adobe Lightroom mask drawing mode (red mask -> https://helpx.adobe.com/content/dam/help/en/lightroom-classic/help/whats-new/2022/select_subject_masking-new.png.img.png) popped up in my head. 😅

I am super interested in your thoughts! I am also happy to brainstorm together! 🙂
Peter

It might make sense to restructure the app/editor to have a more complex but still simple timeline view – similar to a video editor.
The image below shows a brain dump:

Timeline view at the bottom.
Each keyframe can have a position/bounding rect and/or mask.
If one is not specified, the previous position/bounding rect and/or mask is used.
If the first keyframe does not have a position -> full bounding rect is used.
If the first keyframe does not have a mask -> mask revealing everything is used.

What do you think?

Yeah that all sounds good to me. It lines up with my mental model of how Adobe's masks work -- initialized to the full view, with the difference being that if there is a prior keyframe then that keyframe's mask gets inherited.

Hey @jshph!
This week, I will experiment with run-length encoded mask "bitmaps." It's probably way simpler to encode a "mask canvas" to a 0/1 run-length encoded bitmap. I will probably use that approach if it doesn't consume too much memory space.

That would be a clever bit of engineering. Thanks Peter! Eager to hear where it goes.

I create some simple tests regarding RLE encoded bitmaps.
Assuming

we present an image with a resolution of 2000x3000 pixels
and use a mask with a resolution of 500x750 (so 1/4, which should be precise enough)
the RLE-encoded bitmap mask requires (depending on the actual drawings) ~5-15KB, which is acceptable.

The format is "{width}x{height}:T{runLength}M{runLength}T{runLength}M...".

I tried to (mis)use UTF-8 to store run lengths using fewer bytes (via String.fromCharCode(runLength)) to compress the RLE-encoded bitmap even more.
Format is "{String.fromCharCode(width)}{String.fromCharCode(height)}{firstRunMasked ? 'M' : 'T'}{String.fromCharCode(runLength)}{String.fromCharCode(runLength)}..."
Results: UTF-8-hacky-RLE-encoded bitmaps are 3x smaller on average. 🤩 So around 1,5 - 5KB for the bitmap resolution state above. That is very acceptable.

To me, this looks like the best option:

It enables hand drawing.
Memory consumption is acceptable.
Easy to use. No complex SVG conversions are required.

Peter

Hi Peter, sorry I've had a pretty busy weekend / week!
That's incredibly promising, thank you for taking the time to share about it!! I'm not sure I see any downsides from the UTF-8 optimization; potentially, char codes are less interpretable, but not sure that is important to optimize. Certainly, a lightweight experience would be much appreciated :)
Let me know how I could help here -- any PRs to review?
Josh


Not working with forgejo actions (act based runner)

Forgejo actions uses (a fork of) https://github.com/nektos/act to be compatible with GitHub actions. I tried to use this action but it fails with error: unable to find zig installation directory: FileNotFound.
E.g. https://codeberg.org/linusg/icu4zig/actions/runs/51/jobs/0:
Cache miss. Fetching Zig 0.13.0
Attempting mirror: https://zigmirror.hryx.net/zig
[command]/usr/bin/tar --posix -cf cache.tzst --exclude cache.tzst -P -C /workspace/linusg/icu4zig --files-from manifest.txt --use-compress-program zstdmt
Cache Size: ~45 MB (47085060 B)
Cache saved successfully
Extracting tarball zig-linux-x86_64-0.13.0.tar.xz
[command]/usr/bin/tar xJ --warning=no-unknown-keyword --overwrite -C /tmp/d23685fb-0d15-4660-a58d-d0c8e6e362f2 -f /tmp/zig-linux-x86_64-0.13.0
[command]/opt/hostedtoolcache/zig/0.13.0/x64/zig env
error: unable to find zig installation directory: FileNotFound

::error::The process '/opt/hostedtoolcache/zig/0.13.0/x64/zig' failed with exit code 1

A successful run of goto-bus-stop/setup-zig@v2 looked like this:
attempting restore of zig-zig-linux-x86_64-0.14.0-dev.112+9be9b8ca9 to /opt/hostedtoolcache/zig/master/x64
no cached version found. downloading zig zig-linux-x86_64-0.14.0-dev.112+9be9b8ca9
[command]/usr/bin/tar x --warning=no-unknown-keyword --overwrite -C /tmp/cf1c8f5c-0ce1-489e-8413-7c6729ef795a -f /tmp/4b186b68-9731-4f97-8f10-3e66f89c4d04
adding zig master at /opt/hostedtoolcache/zig/master/x64 to local cache zig-zig-linux-x86_64-0.14.0-dev.112+9be9b8ca9
[command]/usr/bin/tar --posix -cf cache.tzst --exclude cache.tzst -P -C /workspace/linusg/icu4zig --files-from manifest.txt --use-compress-program zstdmt
Cache Size: ~68 MB (71555557 B)
Cache saved successfully
zig installed at /opt/hostedtoolcache/zig/master/x64

Did another attempt and it seems to work now. Sorry for the noise!


[BUG] restore with_mixed_precision = False option

Describe the bug
When turning the flag with_mixed_precision = False the code crashes when computing the attentions here.
I tried to solve it with this solution:
 with torch.cuda.amp.autocast():

but I'm getting stuck later when calling the backward propagation. see below.
Error
Loaded model id = 2e3160tt at epoch = 32.
Loaded run '2e3160tt' at epoch 32.
Number of trainable parameters: 530,787,856
33 : 14:06:32 :: batch_size = 96, lr = 1e-05
velocity_u: 0.15534581243991852; velocity_v: 0.16358940303325653; specific_humidity: 0.15310746431350708; velocity_z: 0.3288305997848511; temperature: 0.23762983083724976;
Traceback (most recent call last):
  File "/gpfs/home/cern/cern890661/atmorep/atmorep_May24/atmorep/core/train_multi.py", line 303, in <module>
    train_continue( wandb_id, epoch, Trainer, epoch_continue)
  File "/gpfs/home/cern/cern890661/atmorep/atmorep_May24/atmorep/core/train_multi.py", line 81, in train_continue
    trainer.run( epoch_continue)
  File "/gpfs/home/cern/cern890661/atmorep/atmorep_May24/atmorep/core/trainer.py", line 187, in run
    self.train( epoch)
  File "/gpfs/home/cern/cern890661/atmorep/atmorep_May24/atmorep/core/trainer.py", line 237, in train
    self.grad_scaler.scale(loss).backward()
  File "/gpfs/scratch/ehpc03/pyenvs/pyenv/lib64/python3.9/site-packages/torch/_tensor.py", line 525, in backward
    torch.autograd.backward(
  File "/gpfs/scratch/ehpc03/pyenvs/pyenv/lib64/python3.9/site-packages/torch/autograd/__init__.py", line 267, in backward
    _engine_run_backward(
  File "/gpfs/scratch/ehpc03/pyenvs/pyenv/lib64/python3.9/site-packages/torch/autograd/graph.py", line 744, in _engine_run_backward
    return Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
RuntimeError: Found dtype Float but expected Half
[rank0]: Traceback (most recent call last):
[rank0]:   File "/gpfs/home/cern/cern890661/atmorep/atmorep_May24/atmorep/core/train_multi.py", line 303, in <module>
[rank0]:     train_continue( wandb_id, epoch, Trainer, epoch_continue)
[rank0]:   File "/gpfs/home/cern/cern890661/atmorep/atmorep_May24/atmorep/core/train_multi.py", line 81, in train_continue
[rank0]:     trainer.run( epoch_continue)
[rank0]:   File "/gpfs/home/cern/cern890661/atmorep/atmorep_May24/atmorep/core/trainer.py", line 187, in run
[rank0]:     self.train( epoch)
[rank0]:   File "/gpfs/home/cern/cern890661/atmorep/atmorep_May24/atmorep/core/trainer.py", line 237, in train
[rank0]:     self.grad_scaler.scale(loss).backward()
[rank0]:   File "/gpfs/scratch/ehpc03/pyenvs/pyenv/lib64/python3.9/site-packages/torch/_tensor.py", line 525, in backward
[rank0]:     torch.autograd.backward(
[rank0]:   File "/gpfs/scratch/ehpc03/pyenvs/pyenv/lib64/python3.9/site-packages/torch/autograd/__init__.py", line 267, in backward
[rank0]:     _engine_run_backward(
[rank0]:   File "/gpfs/scratch/ehpc03/pyenvs/pyenv/lib64/python3.9/site-packages/torch/autograd/graph.py", line 744, in _engine_run_backward
[rank0]:     return Variable._execution_engine.run_backward(  # Calls into the C++ engine to run the backward pass
[rank0]: RuntimeError: Found dtype Float but expected Half

Hardware and environment:

System: BSC
Runtime: interactive
Special branch: iluise/head based on develop
Python Version: 3.9

Yes, flash attention only works with half precision. You can try to cast it explicitly at input and cast it back at output. But can you try setting flash_attention=False as well?

Is this still a to-do? I could try to implement and test the changes proposed by @clessig


Which types can T be for FormData?

When Im trying to call next() from futures_util::stream::Stream on FormData I always get an error that Stream is not implement for T, in my case I tried &[u8], Box<[u8]> and Vec<[u8]> - all of them didnt work.
error[E0599]: the method `next` exists for struct `FormData<Vec<u8>>`, but its trait bounds were not satisfied
  --> src/image.rs:58:13
   |
58 |         form_data.next();
   |                   ^^^^ method cannot be called on `FormData<Vec<u8>>` due to unsatisfied trait bounds
   |
  ::: /home/nifker/.cargo/registry/src/github.com-1ecc6299db9ec823/form-data-0.2.6/src/form.rs:18:1
   |
18 | pub struct FormData<T> {
   | ----------------------
   | |
   | doesn't satisfy `FormData<Vec<u8>>: StreamExt`
   | doesn't satisfy `FormData<Vec<u8>>: futures_util::Stream`
   |
   = note: the following trait bounds were not satisfied:
           `FormData<Vec<u8>>: futures_util::Stream`
           which is required by `FormData<Vec<u8>>: StreamExt`

@nifker uses hyper::Body then we can use Field::bytes to read bytes.

and when I use tiny_http?

Do you have an example that I can adapt?

tiny_http provides this function: https://docs.rs/tiny_http/0.9.0/tiny_http/struct.Request.html#method.as_reader

Thanks, I add an example case for tiny_http.

Landed in https://docs.rs/form-data/0.3.0/form_data/. Enable the sync feature. See https://github.com/viz-rs/form-data/blob/master/examples/tiny_http.rs.

'form-data' fails to parse the data from my form for some reason I get Err(invalid part header).
This is the multipart data the server received: https://paste.gg/p/anonymous/8cead24091f64098817d17b2d2e2c2db

@nifker See https://github.com/viz-rs/form-data/blob/master/tests/tiny-body.rs
It follows rfc7578, so uses CRLF to split lines.

And what am I supposed to do about it? I can check if its CRLF, but I get it like that from my browser sent.

Which browser? And Can u post the HTML Form?

Im on Firefox 78.15.0ESR. The form is the following: https://gitlab.com/nifker/webserver/-/blob/main/http/upload.html

The error definitely occurs in this function: https://github.com/viz-rs/form-data/blob/master/src/utils.rs#L21

Im unsure now I just do it similar to the example of yours but it panics each time.
`		let m = req
.headers()
.iter()
.find(|h: &&Header| h.field.equiv("Content-Type"))
.map(|h| h.value.clone())
.and_then(|val| val.as_str().parse::mime::Mime().ok())
.unwrap();
let boundary = m.get_param(mime::BOUNDARY).unwrap().as_str();
	let mut form_data = FormData::new(req.as_reader(), &boundary);

	while let Some(item) = form_data.next() {
		println!("{:?}", item.unwrap());
	}`

it seems like I actually need to read all bytes of a field first before I can read the next one.
Yes, you need to read one field data to continue reading the next one, this is the stream.

A Field has four methods to read bytes. https://github.com/viz-rs/form-data/blob/master/src/sync.rs#L105-L150.

@nifker Is it working?

Oh I forgot to actually reply, yes it is working. Thank you!


Prevent race-condition on the span name when unnamed spans are ended.

What does this PR do?

Fixes #2835, see this comment for details.
Checklist

[x] This is a bugfix

[ ] I have updated CHANGELOG.asciidoc
[ ] I have added tests that would fail without this fix

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-11-04T12:15:36.054+0000

Duration: 39 min 0 sec

Test stats :test_tube:

Test
Results

Failed
0

Passed
2533

Skipped
30

Total
2563

:green_heart: Flaky test report
Tests succeeded.
:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run benchmark tests : Run the benchmark tests.

run jdk compatibility tests : Run the JDK Compatibility tests.

run integration tests : Run the Agent Integration tests.

run end-to-end tests : Run the APM-ITs.

run windows tests : Build & tests on windows.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)


feat(Mathlib.NumberTheory.Cyclotomic.Three): add various results

We add various results about the third cyclotomic field needed to prove flt3.
From the flt3 project at LFTCM2024.

bors merge


Questions about ALM > Invoke analysis

Hello I'm currently using the Invoke analysis API. To analyse some codes from Dataverse in C# but first of all I need to understand how the API work in Postman.
I would like to know if I'm using right the API :
Fist of all the HTTP request :
POST /api/analyze?api-version=1.0 HTTP/1.1
Host: france.api.advisor.powerapps.com
Accept: application/json
x-ms-correlation-id: 9E378E56-6F35-41E9-BF8B-C0CC88E2B832
x-ms-tenant-id: [TenantIDFromAAD]
Authorization: Bearer eyJ0e.....
First question :
My AAD token request is good for using this API ?
POST /[TenantIDFromAAD]/oauth2/v2.0/token
Host: login.microsoftonline.com
client_id=071427b9-dbed-45cc-b57e-549f17c5a577&scope=user.read openid profile offline_access&username=XXXXX&password=XXXXX&grant_type=password
Result :
{       "token_type": "Bearer",       "scope": "AllSites.Manage User.Read profile openid email",       "expires_in": 4174,       "ext_expires_in": 4174,       "access_token": "eyJ0e....",       "refresh_token": "0.ATo.....",       "id_token": "eyJ0....."   }
Second question :
The x-ms-tenant-id need to come from AAD Tenant ID ? or from Power Platform Admin Center Organization ID ?
Third question :
When I'm execute the API why do I get Status : 401 Unauthorized ? And this Result :
Authentication Failed. IDX10511: Signature validation failed. Keys tried: '[PII is hidden]'.    kid: '[PII is hidden]'.    Exceptions caught:    '[PII is hidden]'.   token: '[PII is hidden]'.
Does anyone have a functional example of using the invoke analysis API, other than the Microsoft documentation ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 973baa36-3490-f3b9-8c4e-025a48485133
Version Independent ID: e5801338-5b64-3d7b-8b8d-905e2feedb23
Content: Invoke analysis - Power Platform
Content Source: power-platform/alm/checker-api/analyze.md
Service: power-platform
Sub-service: alm
GitHub Login: @mhuguet
Microsoft Alias: mhuguet

@PunkyLama please refer to https://docs.microsoft.com/en-us/power-platform/alm/checker-api/overview for an example and further explanation of usage. Please reply if you still have questions after reviewing.


Update object variables in package.json to map properties.

Update object variables in package.json to map properties.

This added better auto-completion for these variables.

Such as when you are inside of "logging" in will suggest the properties "level" and "file".

Also updated some variables to be enums so when changing the value you are shown the proper values.

Such as "infosetOutput.type" will display a little menu where you can select 'file', 'console' or 'none'.

Closes #955

I getting "2024-02-06 12:12:04,674 [io-compute-7] INFO  o.a.d.d.d.DAPSession - R> #3 configurationDone null
2024-02-06 12:12:04,707 [io-compute-blocker-1] ERROR o.a.d.d.d.DAPodil - unhandled error
java.lang.ClassCastException: class com.google.gson.JsonPrimitive cannot be cast to class com.google.gson.JsonObject (com.google.gson.JsonPrimitive and com.google.gson.JsonObject are in unnamed module of loader 'app')"  when I ty to run the extension in debug on Windows 10.
An error also displays that the debug process has ended unexpectedly.

@rthomas320 , are you using the "Ask for File" option? That's the problem that Hitesh reported.

I created a new launch json, it was "Wizard Config" instead of "Ask for File".


Fix - Update links

Pull Request
Related to #22 #21
Description
Currently, many links still point to the old DapperCollectives GitHub repo and gitbook, this PR aims to update/point to the new onflow/flowcast ones.
Checklist

[x] I have tested the changes locally and they are functioning as expected.
[x] I have assigned the PR to the appropriate reviewer(s) for their feedback.
[x]  Are all the improvements/development done?

@AmarildoGrembi

In Proposal Threshold screen while creating a community we can change the domain as to -> https://flowcast.gitbook.io/cast-docs/working-with-contracts-and-paths
While adding the strategy we can update it as to -> https://flowcast.gitbook.io/cast-docs/working-with-contracts-and-paths

Attached screenshots for reference -

@AmarildoGrembi

In Proposal Threshold screen while creating a community we can change the domain of Check our Getting Started Guide as to -> https://flowcast.gitbook.io/cast-docs/working-with-contracts-and-paths
While adding the strategy we can update Check our Getting Started Guide to -> https://flowcast.gitbook.io/cast-docs/working-with-contracts-and-paths

Attached screenshots for reference -

updated in dev@949564da


Backfill Status appears to be stuck

We have connected 4 GitHub organizations to our Atlassian instance jciproducts.atlassian.net. 3 of the GitHub organizations synced all the way, one of them keeps getting stuck.  I started a new Backfill 24hrs ago and got stuck again at 406/730. We had reached over 500 in a prior attempt.
Could you please advice how to proceed? I have no visibility (or knowledge?) how to debug this. :(
Thank you, -Rudi.

Hm, interesting.  We seem to be getting a 500 error from the Github API when trying to get pulls from a specific repository.  Could you open a support ticket with Github and provide them with this Github Request ID 4C90:6EB6:106D56B:10E30C9:632334FD for them to reference.
Thanks

@mboudreau - thank you for looking into that. I created support ticket 1801185 with your reference. Thank you.

hEY @rfriedel. Thanks for opening that support ticket with GH. I'm going to go ahead and close this issue as I don't believe there is anything else we can do on our end. If you do need more assistance from us, however, please feel free to reopen.


Fix Image import crash

I was trying to import a solid colored metal/roughness texture that worked in Godot 4.1.1 but failed to load on master. I eventually tracked it down to this: to_x and to_y can be 0, which then leads them to be -1 later, which then causes ofs to overflow.
Some of these cases were hidden because of the use of Vector so we were just happily scribbling in ram elsewhere.
Switched to LocalVector as it made debugging a bit easier.

Thanks!


chore: omit publish for release workflow

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


README.md: for Ubuntu cv2.so changed to cv2.x86_64-linux-gnu.so

Hi,
In Ubuntu 16.04.3 LTS cv2.x86_64-linux-gnu.so is the correct name instead of cv2.so. I believe this should be used instead:
sudo apt-get install python-opencv
ln -s /usr/lib/python2.7/dist-packages/cv2.x86_64-linux-gnu.so NEON/.venv/lib/python2.7/site-packages/

with NEON is the installation path of neon.

Excuse me, but did you ever get the full implementation of this project to work? If so could you help me?


parsl.executors.FluxExecutor for the Flux resource manager

Is your feature request related to a problem? Please describe.
No, it isn't.
Describe the solution you'd like
I would like to add an executor subclass that uses the Flux resource manager to launch Parsl tasks.
I have a branch that implements most of the core functionality, but it is missing tests and a lot of filling-in of features and functionality.
I think Parsl could also benefit from a FluxLauncher and FluxProvider, which I could also implement if it was helpful.
Describe alternatives you've considered
N/A
Additional context
Part of the ExaWorks collaboration with @kylechard, @hategan, and @yadudoc

Closed due to PR merging.


Appstudio update test-component-pac-qcku

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-qcku-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
30 seconds
build-container

✅ Succeeded
14 seconds
inspect-image

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
9 seconds
clair-scan

✅ Succeeded
33 seconds
clamav-scan

✅ Succeeded
11 seconds
sbom-json-check

✅ Succeeded
17 seconds
label-check

✅ Succeeded
5 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary


Material design vs Android/Flutter

This question came up in an I/O AMA, and this feels like the best place to ask it:

I have noticed some of the Material Design controls in Chrome/Chrome OS system pages/apps look more like the Android/Flutter ones than the current state of Material Web Components; are there plans to unify those with Material Web Components or otherwise make them available to developers?

Heya Jake,
Chrome OS for most of their apps use MWC under the hood with some styling and some subclassing (just inspect the pages of their apps!). Their design team has their own set of design recommendations that deviate from Google Material spec, so that is why they have different feels.
Chrome itself, due to different application requirements, use the older Polymer paper-elements with quite a lot of styles applied to them.
Speaking to the team, they do not have any intentions to distribute their code to developers, but what they achieve is possible using MWC as that is how they develop their applications. Additionally, we are working with Chrome to improve MWCs API such that even Chrome OS won't have to subclass our components to theme them to their specifications


Delete a client

As a user I can so that I can remove clients that are no longer needed.

The issue was closed due to this feature was already implemented in AB3.


Use Gauge metric instead of Histogram where applicable

This PR introduces an abstraction for Kamon Gauge
Description
As mentioned in #4311 at some places we are using Histogram to track metric which should instead be tracked as Gauge. This PR converts such usage to Gauge based
Related issue and scope

[ ] I opened an issue to propose and discuss this change (#4311)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[ ] I signed an Apache CLA.
[ ] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #4327 into master will decrease coverage by 4.37%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #4327      +/-   ##
==========================================
- Coverage   85.64%   81.26%   -4.38%
==========================================
  Files         168      168
  Lines        7814     7815       +1
  Branches      520      522       +2
==========================================
- Hits         6692     6351     -341
- Misses       1122     1464     +342

Impacted Files
Coverage Δ

...che/openwhisk/core/loadBalancer/LeanBalancer.scala
0% <0%> (ø)
:arrow_up:

...enwhisk/core/loadBalancer/CommonLoadBalancer.scala
86.17% <100%> (ø)
:arrow_up:

...whisk/connector/kafka/KafkaConsumerConnector.scala
59.7% <100%> (ø)
:arrow_up:

...e/loadBalancer/ShardingContainerPoolBalancer.scala
88.6% <100%> (-0.55%)
:arrow_down:

...in/scala/org/apache/openwhisk/common/Logging.scala
76.05% <11.11%> (-5.15%)
:arrow_down:

...core/database/cosmosdb/RxObservableImplicits.scala
0% <0%> (-100%)
:arrow_down:

...core/database/cosmosdb/CosmosDBArtifactStore.scala
0% <0%> (-95.24%)
:arrow_down:

...sk/core/database/cosmosdb/CosmosDBViewMapper.scala
0% <0%> (-92.6%)
:arrow_down:

...whisk/core/database/cosmosdb/CosmosDBSupport.scala
0% <0%> (-84.62%)
:arrow_down:

...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala
4% <0%> (-52%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a08175f...248dffe. Read the comment docs.

Note that with this change some of the metrics which were earlier tracked as histogram are now converted to Gauge. So its sort of breaking change. However I am not sure how much usable was previous Hostogram based tracking so may be fine to do such a change
@SugandhaAgrawal @vvraskin @sven-lange-last Please have a look and review!

Thanks @SugandhaAgrawal for taking a look.

@chetanmeh I am currently testing the changes from your PR in Grafana - Just FYI

@chetanmeh 👍 This looks good. Feel free to merge. Thanks again for doing this


how to add variable 'alertname' to email header subject in email_configs

This is a support question, which should be sent to<EMAIL_ADDRESS>There's also a section in the documentation on prometheus.io about the notification templating.


Fix download artifact truncate page

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

after upgrade to upload-artifact@v4, artifact name has to be unique for parallel runs. The total number of artfiacts exceeds 30 and get truncated in a single page in REST API response.
tested: https://github.com/apache/beam/actions/runs/11333082673/job/31516528112

R: @damccorm @liferoad


Add: Retrox TV [CR]

Channel Name
Retrox TV
Alternative Names (optional)
No response
Network (optional)
No response
Owners (optional)
No response
Country
CR
Subdivision (optional)
No response
City (optional)
No response
Broadcast Area
c/CR
Languages
spa
Categories (optional)
classic
NSFW
FALSE
Launched (optional)
No response
Closed (optional)
No response
Replaced By (optional)
No response
Website (optional)
https://retroxtv.com/
Logo
https://i.imgur.com/viJBL6f.png
Notes
No response

Retrox TV would not be working. Is there a way to update?
https://rpn3.bozztv.com/ssh101/ssh101/retroxtvhd/playlist.m3u8

Update URL:
https://tvservices.fullhd-streaming.com:3867/live/retroxtvlive.m3u8

they do not work

Form Argentina:
https://github.com/iptv-org/database/assets/643833/8778bab0-f964-416e-9a75-eaf1628cddfc

Now yes!. It's funny, for some unknown reason it didn't work yesterday. I tried it now and it works!
Thank you very much for your contribution. A hug from Patagonia


Text modification to "pip install -r requirements.txt" and backend port match with front end

Minor changes to text and port number
PS. Nice project 😄

@laudanum123 got a port socket error when both are served on same port, might need to revert port back

yeah, noticed as well. Already changed back. I am also not that experienced with vuejs in combination with flask yet

Same here, looking to expand on my VueJS by contributing here

@YazidKurdi yeah, noticed as well. Already changed back. I am also not that experienced with vuejs in combination with flask yet


doc: switch to sphinxcontrib.rsvgconverter

Apparently the pdf build failure (see https://github.com/google/gf180mcu-pdk/issues/82#issuecomment-1284785504) makes the final RTD documentation push fails.
Fixes #82 (hopefully)
Also enabled PDF build in https://readthedocs.org/dashboard/gf180mcu-pdk/advanced/

TEST=https://gf180mcu-pdk--87.org.readthedocs.build/en/87/digital/Digital.html
/cc @cbalint13 @mkkassem

curious if @umarcor has guidance on the proper way to test readthedocs changes extensively, so that we can prevent this from happening again (pdf changes that break the html publication); found the following actions that could be useful:

https://github.com/dfm/rtds-action
https://github.com/DavidLeoni/readthedocs-to-actions
https://github.com/ammaraskar/sphinx-action

curious if @umarcor has guidance on the proper way to test readthedocs changes extensively, so that we can prevent this from happening again (pdf changes that break the html publication); found the following actions that could be useful:

https://github.com/dfm/rtds-action
https://github.com/DavidLeoni/readthedocs-to-actions
https://github.com/ammaraskar/sphinx-action

There is this limitation of rthedocs that still does not show us PDF generation steps in PR stage (only merged):

https://gf180mcu-pdk--87.org.readthedocs.build/en/87/digital/Digital.html

With such feedback limitation on their buildsystem are hard to see, cant imagine what even to "automate" in PR stage.

@umarcor @proppy
To our sum experience up so far:

sphinx.ext.imgconverter using "imagemagick" backend fail on blank SVG (skywater had no such and it passed).
Expicit sphinx-svg2pdfconverter request still not pick up inkscape but convert, probably their docker miss it here

Lets see if this sphinxcontrib.rsvgconverter now invokes proper tools (other than imagemagick).
In case this here works, the trick can be enabled on skywater too, generated images would be smoother (as per the docs).

Expicit sphinx-svg2pdfconverter request still not pick up inkscape but convert, probably their docker https://github.com/readthedocs/readthedocs-docker-images/issues/70

my understanding (from reading https://github.com/missinglinkelectronics/sphinxcontrib-svg2pdfconverter#installation) is that inkscape would only get picked if you add sphinxcontrib.inkscapeconverter to the extensions.
Here we add sphinxcontrib.rsvgconverter which seems to depends on rsvg-convert which has been added to their image w/ https://github.com/readthedocs/readthedocs-docker-images/pull/79.

can't imagine how to "automate" in PR stage.

what I was thinking is that we could mimic what the readthedocs integration is doing in an action (i.e: run the same command on top of the same container image) to proof test our changes.

can't imagine how to "automate" in PR stage.

what I was thinking is that we could mimic what the readthedocs integration is doing in an action (i.e: run the same command on top of the same container image) to proof test our changes.

@proppy
uhh,

Q: Does that "PDF Enable" activated PDF builds too in open PR stage ?
It does't seems to work, but perhaps you enabled it after this very PR was opened (?!)

We could  check / or ask them (rthdocs) why in PR stage the PDF generation is disabled.
If there is no other way then yes a parallel docker build might be ultimate just to have PDF build feedback.

Q: Does that "PDF Enable" activated PDF builds too in open PR stage ?

It doesn't seems so, I suspect it's overridden by whatever is is .readthedocs.yaml.

@proppy see:

github.com/buildthedocs

buildthedocs/btd
pyTooling/Actions: .github/workflows/BuildTheDocs.yml

https://github.com/ghdl/ghdl/blob/5cbfa82ebe90ac1016899c9cbecbaf07daa7e588/.github/workflows/Test.yml#L65-L69    - name: '📓 BuildTheDocs (BTD)'
      uses: buildthedocs/btd@v0
      with:
        token: ${{ github.token }}
        skip-deploy: ${{ github.event_name == 'pull_request' }}

and ghdl/ghdl: .btd.yml
https://github.com/dbhi/qus/blob/7e69017991bfca24fbf5cac6bc7ae14f26cfc52a/.github/workflows/Test.yml#L13-L37 and dbhi/qus: .btd.yml
https://github.com/hdl/containers/blob/339752001a86d4029e58126f24b46efaad42c063/.github/workflows/doc.yml#L81-L100 and hdl/containers: .btd.yml
hdl/constraints: .github/workflows/doc.yml and hdl/constraints: .btd.yml
hdl/conda-eda: .github/workflows/docs.yml and hdl/conda-eda: .btd.yml
umarcor/osvb: .github/workflows/Doc.yml and umarcor/osvb: .btd.yml
See also the repos in github.com/edaa-org.

See also manual equivalents (without using an Action):

https://github.com/chipsalliance/f4pga/blob/e1cd038f06c7161b27afd0073fb507da2b8e5a9e/.github/workflows/Pipeline.yml#L63-L101
https://github.com/VUnit/vunit/blob/master/.github/workflows/docs.yml

@proppy ,
Bit more on SVG backend related:

On newer releases even sphinxcontrib.rsvgconverter fails :)

$ rsvg-convert gf180mcu_fd_sc_mcu7t5v0__endcap.schematic.svg
The SVG gf180mcu_fd_sc_mcu7t5v0__endcap.schematic.svg has no dimensions

$ rsvg-convert -v
rsvg-convert version 2.54.5

I am using these build varieties to native rpm packages: https://copr.fedorainfracloud.org/coprs/rezso/VLSI/build/4962277/

Sticking to sphinx.ext.imgconverter (native, not contrib) always works with imagemagick & inkscape  (required).
The best would be in future to avoid  trow such SVG (not so legit ones) to latex/sphinx flow, we could fix that in the future.
Thanks a lot for helping,
~Cristian.