RFC: Plugins/templates in GSC

What is missing in SGX signing flows, what is needed for "plugins/templates" in GSC?
The context are these PRs and discussions:

https://github.com/gramineproject/gramine/pull/1118
https://github.com/gramineproject/gramine/pull/1197
https://github.com/gramineproject/gsc/pull/112
https://github.com/gramineproject/gsc/pull/118
https://github.com/gramineproject/contrib/pull/19
https://github.com/gramineproject/contrib/pull/20

Woju's opinion
[the text is combined from Woju's messages in the chat]
The missing part is to fix Intel's idea about how to extend the signing Dockerfile with custom snippets.
The signing plugins (PR 1118 proper) are more or less ready, but they're only part of the solution. In real life you might need to install some dependencies (which are not necessarily packaged as pip/python packages) and even run random commands (like login/logout to HSM API, cf. azure example, PR #20). And it's not clear to me how this should be done to be both elastic enough to cater to real-world use cases and rigid enough to prevent users shooting themselves in the feet. What's clear to me is that the original proposal in #112 is a footgun; I've talked about this in the meeting and written in the thread of #112.
So this probably needs a rethink, how GSC's jinja templates are organised (directory hierarchy in templates/ and filenames) to enable template inheritance that would be conductive to overriding relevant parts while still relatively strict to keep the necessary parts like the FROM device which drops the private key, see: https://github.com/gramineproject/gsc/blob/77b1f70e297a286a82708ec6c76b8e4243a5c1bd/templates/Dockerfile.common.sign.template#L14-L16
#1118 is also relevant to one other PR in GSC (#118) that makes the --key argument optional-but-not-really.
It's true that this argument is flow-specific, i.e. applicable only to the single signing schema, with private key. This also needs to be re-thought and reworked.
So the parsing of arguments to GSC signing command is either plugin-specific or some other way. There's a question of packaging: can we package #1118 plugins and GSC plugins together? It would be convenient to do so, and while devising the proper plugin API we need at least to think about how to do it. Like another python's entrypoint that would return something? Another directory with overriding templates? Some way of parsing cli arguments?
One way of doing general parsing of cli arguments was discussed in one of the calls, and could be a generic -D, --define key=value argument very similar to gramine-manifest. That would dispense of general CLI parsing in GSC plugins, but there still will be need for templates/ overrides. This can be done relatively easy, because Jinja supports multiple template loaders and loads just the first found template, so we can insert this other template directory before the default.
Also, #1118 signing plugins will be general, while GSC problems with stuff in templates and inserting custom commands right in the middle of arbitrary dockerfiles are more-or-less GSC-specific. So I don't mind a GSC-only solution to such GSC-only problems.
So my idea how to do it: add --template-dir (or sth like that, the exact name TBD) instead of --template like proposed in #112. This is because Jinja likes loaders more than one-off templates. Somewhere in the comments in those PR's reviews is a snippet of how I would reconfigure jinja loaders when encountering this option to make it possible to inherit from template that's named the same. Then, rewrite relevant templates with {% block %}s to allow replacing respective sections and/or appending to them. This way we'll have option to later package this as python/pip packages, by adding entrypoint which will return a path to directory with templates, this directory being shipped as part of the plugin python package. Possibly even the same package as signing plugin.
As a side effect, this will expose GSC template names and block names as public APIs (plugin writers will need to override specific, named templates, and specific, named blocks inside those templates). Therefore this is a good opportunity to rewrite template names, move them between directories, etc.
Last point: #1118 is probably mergable as-is, possibly ironing out orthography in documentation. If you need to validate is against something, https://github.com/woju/gramine-sgx-otk is written to use this template API
https://github.com/woju/gramine-sgx-otk/blob/6f75511ca8e9ca1e2c39c9dd5ff73d97cf298b49/setup.py#L16.
What to do about all this?

[ ] Come up with a design and a plan to incorporate all of the above.

What's clear to me is that the original proposal in https://github.com/gramineproject/gsc/pull/112 is a footgun;

I don't think it is. We are dealing with HSMs. We really don't need the below snippet - the private key isn't coming out.
https://github.com/gramineproject/gsc/blob/77b1f70e297a286a82708ec6c76b8e4243a5c1bd/templates/Dockerfile.common.sign.template#L14-L16

I don't think it is. We are dealing with HSMs.

But #112 is supposed to be a generic template/plugin solution, not "only for HSMs".

Well, in that case all our templates can be modified and we result in the same footgun problem even with existing templates. Also, I see there are two ways that one can make any template a footgun including what we have today.

Modifying the templates itself to do some goofy thing to include keys
Modify the GSC template to copy explicitly the keys along with their own template.

With #112, we are only giving an option for the user to provide his Dockerfile as template. The basic assumption here is that they don't do explicitly some goofy thing as I mentioned in (1) above. And, (2) really needs active involvement from the user to modify the GSC code to copy stuff to inside the Docker image (along with modifying their own template.
And, we are providing the templates for AKV and OpenSSL based engines (which of course, users will need to customize because there may be many different HSMs based on OpenSSL).
My opinion is that proposal in 1118 makes it more complicated, and is much more vulnerable (including functional and security failures) if the user fails to do the right thing.

My opinion is that proposal in 1118 makes it more complicated, and is much more vulnerable (including functional and security failures) if the user fails to do the right thing.

I have seen no evidence to support the statement that "1118 makes it more complicated, and is much more vulnerable (including functional and security failures) if the user fails to do the right thing". In fact this is the other way around: user needs to just install the plugin and provide basic parameters (like key location and/or credentials). It's not possible to make 1118-style plugins do the wrong thing just by using CLI parameters. This is in contrast to --template GSC proposal, which allows user to write a dockerfile that will ship a private key. It's true PR 1118 is not the full solution and there will need to be some adapter to GSC because of how GSC is structured, but it won't be "more vulnerable".
The difference here is in packaging/encapsulating: plugins are packaged and are not expected to be modified, only parametrised with a designated set or arguments. Only GSC plugin developers have an opportunity to screw things up (which is unavoidable; and they can only screw things in GSC, not in Gramine!). But it's certainly possible to write those plugins so that day-to-day users using only -D parameters can't do it wrong.
--template is free form, and there's no distinction between plugin developers and users, and all it's uses are in fact "active involvement" as you put it, and allows those users to easily do the wrong thing. That's why I call it a footgun.
Now there's a spectrum between those. What you proposed is a complete rewrite of the signing dockerfile. This dockerfile has a complication (FROM device) for a reason. Did you think about what happens when people remove that complication "for simplicity"? It still "works" (container runs), but it ships private key, which is wrong. And user won't notice. It can be done better: prompt users to overwrite only part of the dockerfile template. This way there won't be anything for the user to "simplify", so there will be less of risk. But it requires some work on our part, not just splicing the
Another way to understand it: this is not just a technical problem, this veers into psychology and UX design. Plain --template simply puts wrong incentives before the user. Yet another way to describe this is, I disagree with your assumption that people "don't do explicitly some goofy thing". They will, because most people are clueless, or to put it in more charitable way, they don't need to know implementation details of GSC. They need to be provided with bare minimum, and this FROM device is not among the things that we should require users to understand.

And, we are providing the templates for AKV and OpenSSL based engines (which of course, users will need to customize because there may be many different HSMs based on OpenSSL).

It's not clear how those will be different, and if there won't be a way to support more than one using a single plugin. PC/SC is a common interface, so the scope of adaptation between different implementations remains to be seen. Certainly AKV plugin won't need customisations between different users.

Please go ahead push the finalized changes as per your view and provide how it works with GSC also - with AKV and OpenSSL engine validation.


upgrade netty to 4.1.74-Final due to security vulnerability

Linkedin internal elr-build is seeing some security vulnerabilities around netty version 4.1.60-Final.
This PR upgrades netty version to 4.1.74-Final due to security vulnerabilities found in netty version 4.1.60 upgraded as part of  #8307

This duplicates #8298

This duplicates #8298

I think the author is seeing some build issues around pinot-pulsar dependencies

This duplicates #8298

I think the author is seeing some build issues around pinot-pulsar dependencies and might leave working on the PR

Yes, I see.
Unrelatedly,  LICENSE-binary file needs updating.

Codecov Report

Merging #8328 (9b68e16) into master (8bde29e) will decrease coverage by 8.42%.
The diff coverage is 72.27%.

:exclamation: Current head 9b68e16 differs from pull request most recent head 573b228. Consider uploading reports for the commit 573b228 to get more accurate results

@@             Coverage Diff              @@
##             master    #8328      +/-   ##
============================================
- Coverage     70.87%   62.45%   -8.43%
+ Complexity     4253     4173      -80
============================================
  Files          1635     1623      -12
  Lines         85676    85392     -284
  Branches      12900    12874      -26
============================================
- Hits          60726    53332    -7394
- Misses        20758    28130    +7372
+ Partials       4192     3930     -262

Flag
Coverage Δ

integration1
28.93% <50.49%> (+<0.01%)
:arrow_up:

integration2
?

unittests1
66.92% <33.33%> (-0.03%)
:arrow_down:

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...he/pinot/segment/local/utils/TableConfigUtils.java
66.13% <ø> (+0.07%)
:arrow_up:

...ig/table/SegmentsValidationAndRetentionConfig.java
95.83% <ø> (-0.25%)
:arrow_down:

...rc/main/java/org/apache/pinot/spi/data/Schema.java
73.66% <ø> (+0.88%)
:arrow_up:

...he/pinot/spi/utils/builder/TableConfigBuilder.java
82.51% <ø> (-0.36%)
:arrow_down:

...org/apache/pinot/spi/config/table/QueryConfig.java
53.33% <44.44%> (-32.39%)
:arrow_down:

...pache/pinot/common/config/provider/TableCache.java
75.21% <65.78%> (-2.95%)
:arrow_down:

...roker/requesthandler/BaseBrokerRequestHandler.java
61.32% <74.28%> (-10.53%)
:arrow_down:

.../local/recordtransformer/NullValueTransformer.java
97.36% <94.73%> (+7.04%)
:arrow_up:

...t/core/plan/StreamingInstanceResponsePlanNode.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pinot/controller/recommender/io/ConfigManager.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 291 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bde29e...573b228. Read the comment docs.

This resolves https://github.com/apache/pinot/issues/8297


Unsupported class file major version 60

Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 60
This bug is coming on android platform only. i am using @stripe/stripe-terminal-react-native": "^0.0.1-beta.7" . after installation when i run on android i am getting below issue...
FAILURE: Build completed with 3 failures.
1: Task failed with an exception.

What went wrong:
Execution failed for task ':app:checkDebugDuplicateClasses'.

Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
Failed to transform moshi-1.13.0.jar (com.squareup.moshi:moshi:1.13.0) to match attributes {artifactType=enumerated-runtime-classes, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.jvm.environment=standard-jvm, org.gradle.jvm.version=8, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-runtime, org.jetbrains.kotlin.platform.type=jvm}.
Execution failed for JetifyTransform: /Users/macbook/.gradle/caches/modules-2/files-2.1/com.squareup.moshi/moshi/1.13.0/da685586facab9eb5c4fb630ce248be14e7da21b/moshi-1.13.0.jar.
Failed to transform '/Users/macbook/.gradle/caches/modules-2/files-2.1/com.squareup.moshi/moshi/1.13.0/da685586facab9eb5c4fb630ce248be14e7da21b/moshi-1.13.0.jar' using Jetifier. Reason: IllegalArgumentException, message: Unsupported class file major version 60. (Run with --stacktrace for more details.)

To Reproduce
Steps to reproduce the behavior:

Go to android studio
Click on Run to install app on emulator
Scroll down to bottom after finish processing
See error

Screenshots

Device config

Device: android emulator
OS: macOS M1
gradle wrapper - distributionUrl=https://services.gradle.org/distributions/gradle-6.9-all.zip
build.gradle - classpath("com.android.tools.build:gradle:4.2.2")
jdk version - Embedded jdk 11.0.11
react native - 0.64.2

Hi @harshVikramcrown -- please see https://github.com/stripe/stripe-terminal-android/issues/211, which is a related issue. Can you try updating your Android gradle plugin version? There's also a workaround suggested on that issue which is to add the moshi jar to the jettifier ignore list.

Hi @harshVikramcrown -- please see stripe/stripe-terminal-android#211, which is a related issue. Can you try updating your Android gradle plugin version? There's also a workaround suggested on that issue which is to add the moshi jar to the jettifier ignore list.

Thanks @billfinn-stripe
After blocking the moshi jar by adding android.jetifier.blacklist=moshi-1.13.0.jar in gradle.properties , it's working fine.

Great. I'm going to close this issue. Thanks.


Problem with optional fields: Nexting an un-nextable iterator

I have the following structs:
type Host struct {
	_                  struct{}        `quad:"@type > gc:Host"`
	Name               string          `json:"name"`
	Ssh                HostPortAddress `json:"ssh"`
}

type HostPortAddress struct {
	Address string `json:"address" quad:"address,optional"`
	Port    string `json:"port" quad:"port,optional"`
}

The problem is that if Address in HostPortAddress is not filled, I can't load the object properly with schema.Config.LoadTo() (or LoadToDepth). It doesn't fill HostPortAddress at all and logs these errors to STDOUT:
2018/12/16 09:11:53 ERROR: Nexting an un-nextable iterator: *iterator.Optional
2018/12/16 09:11:53 ERROR: Nexting an un-nextable iterator: *iterator.Optional

If I fill Address with a value, the problem disappears.
P.S. I checked the DB: physically the Port value is saved, but can't be loaded unless Address is set as well.

Modifying the struct this way solves the problem:
type HostPortAddress struct {
	_       struct{} `quad:"@type > gc:HostPortAddress"`
	Port    string   `json:"port" quad:"port,optional"`
	Address string   `json:"address" quad:"address,optional"`
}

So, I'm not sure, if this issue is a bug, or I'm just using the lib incorrectly.


Model weights

Hello,
Are the model weights available somewhere ?
Thank you

Hi,
Yes, they are, please take a look at the comment here.

Awesome
And is there any caveat for doing transfer learning using that pre trained model as a base ?
Thanks

There are built-in features in the mmdetection framework to use a pre-trained checkpoint, such as  load_from or resume_from. You may find more info in the original documentation.

Is it needed to follow the installation steps at https://github.com/open-mmlab/mmdetection/blob/v1.0.0/docs/INSTALL.md or should mmdet be installed differently ?
The conda install step there would install the latest pytorch version, but by the number of deprecation messages I see here when running pip install -v -e . , I wonder if the installation steps shouldn't restrain pytorch to a specific version

Yes, by restraining to PyTorch 1.4 backwards and also restricting the version of a couple of dependencies, I was able to setup, do transfer learning and run inference.
I can contribute with the exact installation steps I did


[bot] Update to version 2.0.10

Auto-update version number to 2.0.10

@conda-forge-admin please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


[ILLA App idea] Use Hugging Face API to create a Pokemon Generator

Description
use Hugging Face API to create a Pokemon Generator
Additional Information
use Hugging Face API to create a Pokemon Generator

/assign @akshayw1

Hi @donqu1xotechina
Can you please assign this ticket to me?
/assign @vishalkhoje

/assign @vishalkhoje

Hi @akshayw1 ,
I kindly request that you consider allowing other members the opportunity to take on assigned issues. I've observed that you have self-assigned three tickets, some of which are older and still pending completion. I appreciate your understanding and willingness to provide others with the chance to contribute.

@vishalkhoje  can uh assign this task to me

@vishalkhoje Sure Vishal, I can consider and understand your request, you could proceed assigning issue, Your self by using bot prompt.  Happy contributing!!!

/assign @harshitvashisht11

I am working on it, I will raise PR very soon.

Hello @donqu1xotechina
can you please review my PR


Training problem

I use tensorflow 2.0.0-rc1
I trained using train.py with a default training image: "girl.png"
After training with FLAGS.mode='fit', FLAGS.transfer='none',
I tested it with the same trained image using detect.py
But I got following warnings and couldn't detect any objects as well.
.......
WARNING:tensorflow:Unresolved object in checkpoint: (root).optimizer's state 'm' for (root).layer_with_weights-0.layer_with_weights-0.kernel
W0919 11:04:29.340978<PHONE_NUMBER>04928 util.py:144] Unresolved object in checkpoint: (root).optimizer's state 'm' for (root).layer_with_weights-0.layer_with_weights-0.kernel
WARNING:tensorflow:Unresolved object in checkpoint: (root).optimizer's state 'm' for (root).layer_with_weights-0.layer_with_weights-1.gamma
W0919 11:04:29.341034<PHONE_NUMBER>04928 util.py:144] Unresolved object in checkpoint: (root).optimizer's state 'm' for (root).layer_with_weights-0.layer_with_weights-1.gamma
WARNING:tensorflow:Unresolved object in checkpoint: (root).optimizer's state 'm' for (root).layer_with_weights-0.layer_with_weights-1.beta
W0919 11:04:29.341070<PHONE_NUMBER>04928 util.py:144] Unresolved object in checkpoint: (root).optimizer's state 'm' for (root).layer_with_weights-0.layer_with_weights-1.beta
WARNING:tensorflow:Unresolved object in checkpoint: (root).optimizer's state 'm' for (root).layer_with_weights-0.layer_with_weights-2.kernel
................... and so on..
It looks like weights are not fully restored for some reason.
If I train with FLAGS.mode = 'eager_tf', I don't get such warning when running detect.py
It seems like saving weight using "model.save_weights" does not provide warning but
using "ModelCheckpoint" does provide warning.
I am not sure.
Any ideas?

I had the same issue before,my issue was that the imported tensorflow was version 1 and not 2.0 (even though the V.2 was installed in the environment)
did you verify correct version during run?

I still get the same warning but the detection works.
It turned out that the reason of detection failure was not related to the warnings.
I tried to train a single class detection but the class probability was not trained since the softmax for a single class always gives 1.
So I changed the score value in the yolo_nms function such that if the class number is one, then score is the same as the confidence.

I am having a quick start using this repo. Just read your comments about single class detection! How did you change in score value in the yolo_nms function? Would you mind sharing your modified yolo_nms function here so we could use as well? Thanks

I changed the following line in yolo_nms function:
==> scores = confidence * class_probs
to like this:
==> if classes > 1:
scores = confidence * class_probs
else:
scores = confidence
This is because the class_prob is not trained for a single class case.
So its value is almost like zero from the start to the end of the training.

So I couldn't fix the warning but everything works fine so I decided to
ignore the warning.
Thanks.
2019년 9월 20일 (금) 오전 2:55, nivsmall<EMAIL_ADDRESS>작성:

I had the same issue before,my issue was that the imported tensorflow was
version 1 and not 2.0 (even though the V.2 was installed in the environment)
did you verify correct version during run?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zzh8829/yolov3-tf2/issues/70?email_source=notifications&email_token=ACOS23QILI7HDXYWON5X7NTQKO4JJA5CNFSM4IYFSYHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7EJYJQ#issuecomment-533240870,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACOS23WDZKCTGEJCZX3S753QKO4JJANCNFSM4IYFSYHA
.

This fix for one class should be pushed up to the main! Maybe i'll get around to a PR

My detection is also not work,I train with pascal 16 epochs,and then detect nothing!
I wonder what the correct steps to validate the model I trained.thks

@lazerliu see this tutorial https://github.com/zzh8829/yolov3-tf2/blob/master/docs/training_voc.md


[integration] Jenkins Webhook

Tool / Product Name
Jenkins
Goal
Provide simple instructions for integrating Keptn and Jenkins.

#help-integrations on Slack

[X] Yes

No Existing Integrations

[X] Yes

Assisted
Yes
Any other info?
These instructions will be based on usage of the webhook service.

https://www.youtube.com/watch?v=ehI23d7s-dY


Is this package maintained?

Hi @blissdev & @Adamanthil,
Is this package being maintained? :question:
We need similar functionality but our project requires that any plugin we use to have tests and up-to-date dependencies...
Would you accept a Pull Request with updates? :arrow_up:

Hi @nelsonic,
It is being maintained, but not well, as you've noticed. Would happily take pull requests with updates. We are working on updating our internal Hapi version, so that it would happen here eventually, but don't have a concrete timeline on that, so definitely feel free to contribute.


No sam init for .net core 2.1

Description:
There is no sam init for dotnetcore2.1
Steps to reproduce the issue:

run sam init --help
see acceptable --runtime options
-r, --runtime [go1.x|nodejs|python|python2.7|python3.6|go|nodejs4.3|nodejs6.10|java8|dotnetcore1.0|java|dotnetcore2.0|dotnetcore|dotnet|nodejs8.10]

Additional environment details (Ex: Windows, Mac, Amazon Linux etc)
Windows
Output of sam --version:
SAM CLI, version 0.5.0

@DamianBis Yes, currently we do not have a .NET Core 2.1 sample. Would you be willing to add this? I am unsure if the dontnetcore2.0 will work in dotnetcore2.1 but if it does this should be an easy update.

@heitorlessa  thoughts?

Working on a PR today for that @DamianBis.


dropdowns don't get the styling from :color: option

Describe the bug
context
When I set :color: warning on a dropdown element, it's not getting styled
expectation
I expected it to get the colors associated with classes sd-bg-warning sd-bg-text-warning, which is what shows up on the child dropdown in the "nested dropdowns" example on https://sphinx-design.readthedocs.io/en/pydata-theme/dropdowns.html#dropdowns-in-other-components
bug
But instead the dropdown is grey
problem
This is a problem for people using sphinx-design via pydata-sphinx-theme because the theme defines a more specific selector .bd-content .sd-card .sd-card header, so even though the sd-bg-warning rule is pegged as !important it's not getting applied.
Reproduce the bug

List your environment
$ mamba list sphinx
jupyter_sphinx            0.3.2           py310hff52083_0    conda-forge
pydata-sphinx-theme       0.8.1                    pypi_0    pypi
sphinx                    4.5.0              pyh6c4a22f_0    conda-forge
sphinx-autobuild          2021.3.14          pyhd8ed1ab_0    conda-forge
sphinx-copybutton         0.5.0                    pypi_0    pypi
sphinx-design             0.1.0              pyhd8ed1ab_0    conda-forge
sphinx-gallery            0.11.0.dev0               dev_0    <develop>
sphinx-sitemap            2.2.0              pyhd8ed1ab_0    conda-forge
sphinx-theme-builder      0.2.0a14           pyhd8ed1ab_0    conda-forge
sphinxcontrib-applehelp   1.0.2                      py_0    conda-forge
sphinxcontrib-bibtex      2.4.2              pyhd8ed1ab_0    conda-forge
sphinxcontrib-devhelp     1.0.2                      py_0    conda-forge
sphinxcontrib-htmlhelp    2.0.0              pyhd8ed1ab_0    conda-forge
sphinxcontrib-jsmath      1.0.1                      py_0    conda-forge
sphinxcontrib-qthelp      1.0.3                      py_0    conda-forge
sphinxcontrib-serializinghtml 1.1.5              pyhd8ed1ab_2    conda-forge
sphinxext-rediraffe       0.2.7              pyhd8ed1ab_0    conda-forge

Heya thanks for the report, however, this feels a bit difficult to fix here. Would you be able to open an issue on pydata-sphinx-theme (and link it here), so we can work with them to see if there is a "mutual" fix?

This was actually already fixed (at least for my use case, and I think for the general case) by the combination of https://github.com/pydata/pydata-sphinx-theme/pull/836 and https://github.com/pydata/pydata-sphinx-theme/pull/847. Sorry I didn't circle back to close this at the time.


AssertionError: Test case is leaking async ops.

Issue
Setup:

Deno Version: 1.4.4
v8 Version: 8.7.75
Typescript Version: 4.0.3
SuperOak Version: 2.3.1

I am trying to run a simple test in my app, but it constantly fails because of leaking async ops, even though there's nothing running.
Details
import { Application} from<EMAIL_ADDRESS>import { superoak } from<EMAIL_ADDRESS>
const app = new Application();
app.use((ctx) => {
  ctx.response.body = "Hello world!";
});

Deno.test("Example", async () => {
  const request = await superoak(app);
});

To run: deno test --allow-net <that code>.ts
Error log:
running 1 tests
test test ... FAILED (8ms)

failures:

test
AssertionError: Test case is leaking async ops.
Before:
  - dispatched: 0
  - completed: 0
After:
  - dispatched: 2
  - completed: 1

Make sure to await all promises returned from Deno APIs before
finishing test case.
    at assert (deno:cli/rt/06_util.js:33:13)
    at asyncOpSanitizer (deno:cli/rt/40_testing.js:44:7)
    at async Object.resourceSanitizer [as fn] (deno:cli/rt/40_testing.js:68:7)
    at async TestRunner.[Symbol.asyncIterator] (deno:cli/rt/40_testing.js:240:13)
    at async Object.runTests (deno:cli/rt/40_testing.js:317:22)

failures:

        test

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out (8ms)

Hey @antoniogamiz thanks for raising - not ideal at all given that really is the simplest usecase! 😅
Will try to spare some time soon to investigate - if you have time and are keen, please do have a dive into the code to figure out what async/promising thing is being left hanging.
It's odd this hasn't been picked up in the tests but haven't touched this in a month and may be that something in Oak / Deno has moved along since September... or just have been super lucky (or unlucky depending on how see it) with an async op race condition.

I know it's quite weird... At first, I thought it was due to some error in my files, but I have cleaned the cache and updated Deno to 1.4.6 and it's still happening.
I have downloaded this repo and I have run the tests but they are ok so...
I will try to investigate what's being left hanging.

Haven't dug too deeply, but from a quick reminder of the code performing:
const request = await superdeno(app);

Will launch an Oak server and resolve with a promise which we are awaiting. Given nothing then stops said Oak sever, my guesses are that it (the server) is effectively the async op that is not cleaned up (or more accurately the async iterator inside the Oak server that processes requests hasn't been escaped).
Hence I'm curious if the issue goes away if you actually complete the usage of superdeno as documented and make an assertion - superdeno has it's own internal logic to close the Oak server using an AbortController, and this will only be fired when the underlying superdeno .end() method is called, either implicitly or explicitly (REF: https://github.com/asos-craigmorten/superdeno/blob/main/src/test.ts#L350)
For instance, updating to the following solves it for me:
import { Application} from<EMAIL_ADDRESS>import { superoak } from<EMAIL_ADDRESS>
const app = new Application();
app.use((ctx: any) => {
  ctx.response.body = "Hello world!";
});

Deno.test("Example", async () => {
  const request = await superoak(app);

  await request.get("/"); // Need to invoke at least one superdeno method otherwise the underlying server is left runner forever (well... until it gets cleaned up by Deno which will tell you off).
});

And why does this fail, then? It produces the same error:
import { Application } from<EMAIL_ADDRESS>import { superoak } from<EMAIL_ADDRESS>
const app = new Application();
app.use((ctx: any) => {
  ctx.response.body = "Hello world!";
});

Deno.test("Example", async () => {
  const request = await superoak(app);

  await request.get("/").expect({});
});

I'm passing an object because my endpoint returns a JSON, so I want to test that.

Sorry ignore those two replies, what you have said works great. Thanks!


Example with Rust

There should be an example of using resend in a Rust-based application. I suggest we use Actix web, Axum, etc. If this works, I would like to create the application and write an article about it.

I would like work on this, if that's okay.


So many copies of logo images

Looks like every notebook has its own PNG or SVG logo file, but they are all effectively the same logo! Is this really necessary?! Can we not have only one logo file to be shared by all the notebooks in this repo?
$ find ./ -name "stsci*.png" | wc -l
14
$ find ./ -name "stsci*.svg" | wc -l
5

$ ls -lh notebooks/MAST/TESS/interm_tesscut_dss_overlay/stsci_pri_combo_mark_horizonal_white_bkgd.png
-rw-r--r--. 1 ... 112K Mar 18 15:59 .../stsci_pri_combo_mark_horizonal_white_bkgd.png

$ ls -lh notebooks/MAST/K2/K2_TPF/stsci_pri_combo_mark_horizonal_white_bkgd.svg
-rw-r--r--. 1 ... 7.8K Mar 18 15:59 .../stsci_pri_combo_mark_horizonal_white_bkgd.svg

FWIW, this renders properly for me locally:
<img style="float: right;" src="https://static1.squarespace.com/static/51815eaae4b0841085acb675/t/57220256555986178fe78612/1461846625662/stsci_pri_combo_mark_horizonal_white_bkgd.png?format=300w" alt="stsci_pri_combo_mark_horizonal_white_bkgd" width="200px"/>

Hmm, does anyone know the origin of this repetition (@ceb8, @arfon, or @JosieBunnell) ?  I have a hazy memory that there was a reason for it, but I can't recall it now, and @pllim's arguments are persuasive that it's better to share one logo location...

There's no good reason for repetition, other than the goal for each notebook to be somewhat self-contained with respect to the visual assets (images/logos).
What about having a top-level directory in this repository called 'assets' or something similar with these shared items. We can then link to them as @pllim suggests using the raw GitHub URLs e.g.:
https://raw.githubusercontent.com/spacetelescope/notebooks/master/notebooks/MAST/TESS/interm_tesscut_astroquery/stsci_pri_combo_mark_horizonal_white_bkgd.png```

I would propose that we use https://static1.squarespace.com/static/51815eaae4b0841085acb675/t/57220256555986178fe78612/1461846625662/stsci_pri_combo_mark_horizonal_white_bkgd.png?format=300w directly if that works, as that is the place for official OPO branding resources. If the link ever breaks, it is OPO's job to fix it.

I would propose that we use https://static1.squarespace.com/static/51815eaae4b0841085acb675/t/57220256555986178fe78612/1461846625662/stsci_pri_combo_mark_horizonal_white_bkgd.png?format=300w directly if that works, as that is the place for official OPO branding resources. If the link ever breaks, it is OPO's job to fix it.

Do we know how stable that URL is? Also, how would we know if/when it breaks? I'm inclined to copy the assets (images etc.) we need into this repository so that we can be certain they're working.

Fine then, but only ONE COPY. There can be only one!

Fine then, but only ONE COPY. There can be only one!

Deal.

Update: assets added in #82 (thanks, @arfon !). Duplicate logo files and affected notebooks still need to be cleaned up.


Fix a regression where the paragraph splitter was sometimes skipping blocks

When PR https://github.com/Microsoft/tsdoc/pull/109 moved DocBlock.nodes into DocBlock.content.nodes, the paragraph splitter wasn't updated.

:shipit:


support nonblocking submit and max blocking limit setting

Signed-off-by: Cholerae Hu<EMAIL_ADDRESS>

/cc @panjf2000

@choleraehyq Please resolved the issues found by GolangCI: https://github.com/panjf2000/ants/pull/41/files#r315493235

#24


How many epochs does it take roughly to converge for gtsrb2TT100K?

Hi,
How many epochs does it take roughly before the results start matching the reported results for gtsrb2TT100K

Hi, based on my experience, it tops performance around 100~150 epochs.


Use DataSteward over EnvironmentAdmin in the example

Use DataSteward over EnvironmentAdmin in the example
Based on the RBAC documentation, DataSteward should also be sufficient in this case.

we have updated the example with DataSteward, please check it out!


Language Server implementation seems to fail at handling changes

Here is an example of conversation, which I believe shows a bug in the Language Server implementation for OmniSharp:

from a correct .cs document
Connect it to OmniSharp LS, ask for completion or references => Fine
Make a couple of changes (add a line then remove it)
Expected: No issue reported; Actual: diagnostic sends non relevant issues, completion is erroneous.
My guess is that the internal document model of OmniSharp isn't updated properly, resulting in erroneous diagnostics.

This same client is used to connect to other language servers (JSON and CSS ones from VSCode) without any issue: changes are well understood, show no error diagnostic, completion works well and is updated according to the change.
Here is an example of convesation:
CLIENT_TO_LANGUAGE_SERVER: Declare addition of a new line (\n) after the int a = i / 3; instruction
{"method":"textDocument/didChange","params":{"textDocument":{"version":3,"uri":"file:/home/mistria/git/3dLocalizer/test.cs"},"contentChanges":[{"range":{"start":{"line":9,"character":23},"end":{"line":9,"character":23}},"rangeLength":0,"text":"using System;\npublic class HelloWorld\n{\n    public static void Afficher()\n    {\n   \t\tint i \u003d 0;\n        Console.WriteLine(\"Hello world !\");\n        Console.ReadLine();\n        i++;\n        int a \u003d i / 3; \n        \n    }\n}\n"}]},"jsonrpc":"2.0"}
LANGUAGE_SERVER_TO_CLIENT:
{"jsonrpc":"2.0","method":"telemetry/event","params":{"clientId":"client1","command":"/updatebuffer","request":{"FileName":"/home/mistria/git/3dLocalizer/test.cs","Changes":[{"NewText":"using System;\npublic class HelloWorld\n{\n    public static void Afficher()\n    {\n   \t\tint i = 0;\n        Console.WriteLine(\"Hello world !\");\n        Console.ReadLine();\n        i++;\n        int a = i / 3; \n        \n    }\n}\n","FileName":"/home/mistria/git/3dLocalizer/test.cs","StartColumn":23,"StartLine":9,"EndColumn":23,"EndLine":9}]},"silent":false,"sequence":"__request11","time":"2016-07-27T11:14:21.134Z"}}
LANGUAGE_SERVER_TO_CLIENT:
{"jsonrpc":"2.0","method":"telemetry/event","params":{"command":"/updatebuffer","response":true,"clientId":"client1","request":{"FileName":"/home/mistria/git/3dLocalizer/test.cs","Changes":[{"NewText":"using System;\npublic class HelloWorld\n{\n    public static void Afficher()\n    {\n   \t\tint i = 0;\n        Console.WriteLine(\"Hello world !\");\n        Console.ReadLine();\n        i++;\n        int a = i / 3; \n        \n    }\n}\n","FileName":"/home/mistria/git/3dLocalizer/test.cs","StartColumn":23,"StartLine":9,"EndColumn":23,"EndLine":9}]},"sequence":"__request11","time":"2016-07-27T11:14:21.136Z","silent":false,"failed":false,"responseTime":2}}
LANGUAGE_SERVER_TO_CLIENT:
{"jsonrpc":"2.0","method":"telemetry/event","params":{"Event":"log","Body":{"LogLevel":"INFORMATION","Name":"OmniSharp.Middleware.LoggingMiddleware","Message":"/updatebuffer: 200 1ms"},"Seq":38,"Type":"event"}}
LANGUAGE_SERVER_TO_CLIENT:
{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"uri":"file:///home/mistria/git/3dLocalizer/test.cs","diagnostics":[{"severity":1,"message":"} expected","range":{"start":{"line":9,"character":36},"end":{"line":9,"character":36}}},{"severity":1,"message":"Type or namespace definition, or end-of-file expected","range":{"start":{"line":36,"character":0},"end":{"line":36,"character":1}}},{"severity":1,"message":"The type 'HelloWorld' already contains a definition for 'HelloWorld'","range":{"start":{"line":23,"character":13},"end":{"line":23,"character":23}}},{"severity":1,"message":"'HelloWorld': member names cannot be the same as their enclosing type","range":{"start":{"line":10,"character":13},"end":{"line":10,"character":23}}},{"severity":1,"message":"The type or namespace name 'sing' could not be found (are you missing a using directive or an assembly reference?)","range":{"start":{"line":22,"character":0},"end":{"line":22,"character":4}}},{"severity":1,"message":"Type 'HelloWorld.HelloWorld' already defines a member called 'Afficher' with the same parameter types","range":{"start":{"line":25,"character":23},"end":{"line":25,"character":31}}},{"severity":1,"message":"The type or namespace name 'uusing' could not be found (are you missing a using directive or an assembly reference?)","range":{"start":{"line":9,"character":22},"end":{"line":9,"character":28}}},{"severity":2,"message":"The variable 'System' is declared but never used","range":{"start":{"line":9,"character":29},"end":{"line":9,"character":35}}}]}}

Are you inserting new text or replacing existing text.
The request content seems to imply you're replacing the text, but the range makes it append.
{
   "method":"textDocument/didChange",
   "params":{
      "textDocument":{
         "version":3,
         "uri":"file:/home/mistria/git/3dLocalizer/test.cs"
      },
      "contentChanges":[
         {
            "range":{
               "start":{
                  "line":9,
                  "character":23
               },
               "end":{
                  "line":9,
                  "character":23
               }
            },
            "rangeLength":0,
            "text":"using System;\npublic class HelloWorld\n{\n    public static void Afficher()\n    {\n   \t\tint i \u003d 0;\n        Console.WriteLine(\"Hello world !\");\n        Console.ReadLine();\n        i++;\n        int a \u003d i / 3; \n        \n    }\n}\n"
         }
      ]
   },
   "jsonrpc":"2.0"
}

If you were replacing the text (full document change) I would expect the range start position to be...
            "range":{
               "start":{
                  "line":0,
                  "character":0
               },
               "end":{
                  "line":9,
                  "character":23
               }
            },

As a note, I did my original testing with VSCode, and I'm currently implementing the Language Server Protocol for Atom, and I'm not having any issues so far.

Ok, thanks. I had a deeper look at https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#didchangetextdocument-notification and there is indeed a room for ambiguity in the protocol in that case: the range is set but not the rangle length, so VSCode decide to take it as full text whereas OmniSharp takes it as a located Text Edit. I'll simply remove the range here and see how it goes.

Closing as removing the ambiguity (removing range or correctly setting range length) works as expected.


HUB_VERBOSE environment variable is undocumeneted

The HUB_VERBOSE environment variable, which causes network requests and git commands executed by hub to be logged to stdout, is useful for both contributors and end-users. For contributors, it is obviously useful for debugging, but it is also useful for users who want to understand the commands that hub executes, especially when hub behaves unexpectedly.
I was only able to discover this variable by looking through commands.go:
https://github.com/github/hub/blob/a45f4573a32e346d7046b47657263cd17cb60c9e/cmd/cmd.go#L111-L119
Would it be appropriate to document it in the contributing guide?

Yes it would absolutely be useful to document it both in the contributing guide and the man page. Thank you for suggesting

it is still a bit confusing in the documentation. i was not sure what to set it to. it looks like i can set it to anything other than empty string. i spent more time that i should have trying to figure that out.


Fix linting issues

See individual commits for more information.

Trying to figure out why none of the dependent builds are showing up in GitHub...
ERROR: [GitHub Commit Status Setter] - {"message":"Validation Failed","errors":[{"resource":"Status","code":"custom","field":"sha","message":"sha must be a 40 character SHA1"}],"documentation_url":"https://developer.github.com/v3/repos/statuses/#create-a-status"}, setting build result to UNSTABLE


Fix for Ticket 23424 (based on fix for Ticket 23356)

Allows verbatim tag contents to contain tag delimiters eg. {{.
This pull request is based off https://github.com/django/django/pull/14686

Closing per comments.


Improve code quality of installation scripts

These changes address codacy findings in the installation shell scripts

Codecov Report

Merging #66 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   35.83%   35.83%
=======================================
  Files         114      114
  Lines       33246    33246
=======================================
+ Hits        11913    11915    +2
+ Misses      21333    21331    -2

Impacted Files
Coverage Δ

dynadjust/include/io/dnaiobase.cpp

...just/include/measurement_types/dnadirectionset.hpp

dynadjust/include/config/dnaversion-stream.hpp

...st/dynadjust/dnaimportwrapper/dnaimportwrapper.hpp

...just/dynadjust/dnageoidwrapper/dnageoidwrapper.cpp

dynadjust/dynadjust/dnasegment/dnasegment.cpp

...just/include/functions/dnatemplategeodesyfuncs.hpp

...t/dynadjust/dnaadjustwrapper/dnaadjustprogress.cpp

dynadjust/include/io/dnaiomap.hpp

dynadjust/include/measurement_types/dnaheight.hpp

... and 218 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f07da1...1853dba. Read the comment docs.


[TCES-21] Create JobApplication Model

Description

Created JobApplication Model
Wiki update needed due to schema changes

Issue # TCES-21
Type of change
Please delete options that are not relevant.

[x] This change requires a documentation update

Checklist
Please delete options that are not applicable.

[x] My code follows the style guidelines of this project (required)
[x] I have performed a self-review of my code (required)
[x] I have linted and formatted my code (required)
[x] New and existing unit tests pass locally with my changes (required)
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works

Added the status_other field in the latest commit


Refactoring of UI code

@brodecva Please specify which kind of refactoring is needed. I though it is done by Istvan? Do you mean here the use of directives?  Please also update the milestone

After a discussion with @KataBoku we collectively decided it is best left to her. First, I don't understand the whole code anyway and she already has a brief idea what the result should look like.
Briefly, what we expect from the refactoring:

modules / components should be split into files
(components are e.g. table for selection C&D, subject column,  modals - deduplication needed, etc.)
!! overall, the most important thing to do is to separate code into 'sections' (be it several files, or 'regions', ...) and describe it using comments so that it is easy to use a certain module/component. (e.g. a scenario: a component of mine, graphvis, uses 'locks', which I consider a separate component. It should be easy by looking at comments to understand the usage of the 'locks'.)
(Anything else is a waste of time.)

@tomas-knap We have a Skype planned with @KataBoku  and @istvan-satmari on Saturday 2016-12-02 morning, that should finally close this issue. @KataBoku will present the results of the re-factorization.

As for the 3/12/2016, TODO for @KataBoku :

remove unused comments
add comments describing usage of cdlock.js (cdlock directive)
rename cdtablerows => cdtablerow

Merged. Hopefully everything works.


libusb-1.0 communicate with printer and then the cups can not print

I am developing a application(state monitor) which communicate directly to the printer. The communication function I run to libusb for it provided abunch of functions to read and write with USB.
The version of cups is 1.4.5
And the kernel version is 2.6.32
My system is linux redhat and when I plug in the printer, the system generate a link under /dev/usb/lp0.
When I run my application, which calls
1.libusb_init();
2.libusb_find_busses();
3.libusb_find_devices();
4.libusb_open_device_with_vid_pid();
5.libusb_free_device_list();
6.libusb_detach_kernel_driver();
7.libusb_claim_interface();
8.use libusb_bulk_transfer() to communicate with printer
9.libusb_release_interface()
10.and then libusb_attach_kernel_driver();
11,libusb_exit();
when the state monitor application exit, and I can not print any thing from CUPS.
the CUPS log shows can not communicate to printer(can not read any thing from printer).
I found when I call libusb_detach_kernel_driver(); the /dev/usb/lp0 link disappears and then I call libusb_attach_kernel_driver() the link /dev/usb/lp0 appears again. but still can not print anything.
when I run echo "somthing" > /dev/usb/lp0 in termail and cat /dev/usb/lp0 , I can get the return string from printer.
For I am not familiar with libusb, I can not figure it out why the printer(CUPS indeed) can print.
Any suggestion will be welcome.
Thank you.

Unfortunately, when it comes to the USB backend on Linux we are at the mercy of the Linux distros.
The current (libusb-based) USB backend should work in this situation, but IIRC the 1.4.x version of the backend did not work when the usblp kernel driver was loaded. Updating just the backend (or asking Red Hat to backport the fixes) is probably the best way to fix this issue.

Hi, michaelrsweet.
Thank you for replying. But when I don't run the state monitor, and the /dev/usb/lp0 exists, I can receive data from printer and print correctly. It seems usblp is already loaded before I call libusb_attach_kernel_driver().
As what you just said "the 1.4.x version of the backend did not work when the usblp kernel driver was loaded" ,  do you mean that when /dev/usb/lp0 exists, CUPS backend can not communicate with printer?
I'm not familiar with usblp,

@liuxiaomeng2270 The usblp kernel module implements a character device that communicates with USB printers using the USB printer class, much like the USB backend does.
The CUPS 1.4.x backend did not support coexistence between libusb (the userland USB library) and the usblp kernel module, so it CANNOT work when the usblp module is loaded. I don't know what version of the USB backend is included with your Linux distribution, but if you want to use libusb separately to monitor the state of your printer you CANNOT use that USB backend - you need a newer version.
(There was a time when CUPS depended on the usblp driver, but as multifunction printers became more common and scanning became supported, we had to shift to using libusb instead so that you could scan and print at the same time.)


chore: bdd-gh-1581771917 to 0.0.1

chore: Promote bdd-gh-1581771917 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Update projectlist.md

separated out the Sampling high-resolution model output project and added link

Thanks Kyla!


Do not throw an exception when webhook_url is not supplied but a warning.

What's this PR do?
Do not throw an exception when webhook_url is not supplied but a warning.
Background context
If a user does not supply the webhook_url parameter when making a post
request, we should still go and make the request to render but let them
know that they will not be getting any webhooks posted to them instead
they will need to poll the statusUrl supplied in the initial response.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5e07638). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage        ?   99.08%
=======================================
  Files           ?        9
  Lines           ?      436
  Branches        ?        0
=======================================
  Hits            ?      432
  Misses          ?        4
  Partials        ?        0

Flag
Coverage Δ

unittests
99.08% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e07638...2aaccfd. Read the comment docs.


latest version of ffmpeg for android

Hello everyone
its maybe not right place to write this question but I search allot for latest version of FFMPEG for Android but I didnt find it, so please help me to find that.
Thanks.

You may want to compile it by yourself.


Error handling for Object.defineProperty

Object.defineProperty was not checking if accessors were available in the object. It also was not throwing when both an accessor and a value were specified in the descriptor.

:+1:

I'm waiting for the Sauce tests. I'm guessing it needs some changes in the browser specific variants too.

Yeah just what I thought.

I'm confused by the approach taken for this polyfill. In browsers that are not IE but don't have getters and setter it tries to use __defineGetter__. But if there's no __defineGetter_ it'll throw. However, in old IE if it doesn't support getters and setters it'll fail silently. What would be the correct behavior? Personally I think it should throw when it finds an accessor and the browser doesn't support them. It should be helpful for debugging.

Ok. Updated everything. There's a lot of error checking code. So much that I'm wondering if it even makes sense to have different versions for IE7 and IE 8...


W/libperfmgr: Failed to write to node: /sys/devices/system/cpu/cpu4/cpufreq/scaling_max_freq

My logcat got spammed every 500ms with this error after flashing uperf.

uperf version: DEV 22.04.09
phone: Google Pixel 3 Android 11
soc: sdm845 EAS
profile: powersave

That's what I expected. libperfmgr cannot be easily disabled, do you have any good idea?😋


Remove PEAR/PHAR

Resolves #619.
@nrk: What are your thoughts on the bin/create-single-file script, does that still work? Should we drop it in v2.0?

@tillkruss the script bin/create-single-file despite being an hack should still be working, at least in v1.1, but I don't think I've ever tested it with v2.0 and I wasn't really thinking about keeping it around as it's something that dates back from ten years ago or so, sometime before Composer, when people nagged me because they had to use autoloading with v0.7 🤷 I guess we can drop it with no remorse.
Actually the script used to generate a Phar archive was born for the same reason above, but by today's standards Phar archive make sense mostly for CLI applications.


Update matrix events to their latest version

A work in progress so we can integrate the latest changes.
So far it matches the HEAD of the spec with the exception of the new event m.direct. It will be updated (if any change occurs) until v0.3.0 comes out.

Now the PR should be up-to-date with the latest spec version (v0.3.0)

No worries, I'm glad you're back working on ruma.


brave: 1.4.95 -> 1.4.96

Motivation for this change
Keep the browser up-to-date with release from Brave
Things done
Update version to latest stable and update checksim

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/pr-approved-browser-brave-backport/6122/1


Hello! How can I hide the horizontal scroll bar in a code block so that lines of code can wrap automatically?

Hello! How can I hide the horizontal scroll bar in a code block so that lines of code can wrap automatically?
Windows 10
Extension latest version
VSCode 1.82

Example:
Sample file.md


Properly display annotated variants in case overview.

Describe the bug
After the refactoring of sequence and structural variants to store ready-to-display records in the database, the annotated variant display in the case overview does not work any more.
To Reproduce
Go to the case detail view's "annotated variants" page. See "spinner forever".
Expected behavior
The screen should display the annotated variants.
Screenshots

Additional context
N/A

Root Cause Analysis
Earlier, one could simply use the variant result store to display the variants. Now that everything has been moved to variant result rows, this is not possible so easily any more. Instead, the annotated variant view will display the variants from the previous query. Clearly, this is not the desired behaviour.

Resolution Proposal
We need to make a copy and maintain copies of the annotated records when new comments are made. These must then be displayed in the annotated variant table.

We need to introduce a special type of result set for the annotated variants of a case. Probably, a special "type" field for the existing model would make sense with None/NULL meaning that this is the default type.
In the Python API end points that create and update flags and comments, we need to maintain this set by adding/updating/removing records when flags are created/removed. We should maintain the "last updated time" flag of this special set whenever we change contained records.
We should have a periodic job that runs once every hour and refreshes these sets for cases where the last update was done more recently than two hours ago. This guarantees updates / fixes.
This special result set is loaded and paginated in the annotated variants list.

We need to do this both for sequence and structural variants.

@holtgrewe Is there a roadmap for this? This is unfortunately still blocking annotating causal variants in preparation for ClinVar upload. Thanks!

@xiamaz I'm looking into this now.

Closed with #1034


[Question] Reason behind removing lm_head in modules

Hello,
Thank you for the amazing repo. I was curious about this code below.
https://github.com/artidoro/qlora/blob/e3817441ccc7cff04ca13e8fab5196d453ff32f2/qlora.py#L221-L222
Why is lm_head removed? What does it mean by for "needed for 16-bit"? Does it mean targeting this module for fp16 or so is incorrect?

Had the same thought.  Have you figured it out?  I didn't see anything in the paper either.  If you want to add new tokens, you need to target the lm_head anyways.

@artidoro @TimDettmers some insight on this would be greatly appreciated.

Could someone share any observations or evaluations regarding the use of 'lm_head' as a target module?
Thanks!

Not sure if this is related with this issue, but I found that when applying lora to Llama-2, and include target_modules=['lm_head', 'q_proj', 'v_proj'] in LoraConfig, the lora on lm_head will be removed when the model is being distributed to gpus.  I was trying to apply lora on both embed_tokens and lm_head, but peft or deepspeed seems to forbid lora on these 2 modules without explicit warning.


Create tool for getting DCO sign off emails

This tool digs through commit messages and parses out names and email addresses from the Signed-off-by: tags, collects all unique email addresses and outputs a CSV of name/email pairs.
Example usage:
./bin/project contributors --from=2022-11-08 --to=2022-11-09 --repo=OpenSearch dco-csv
Andrew<EMAIL_ADDRESS>Andriy<EMAIL_ADDRESS><EMAIL_ADDRESS>Marc<EMAIL_ADDRESS>Owais<EMAIL_ADDRESS>Rabi<EMAIL_ADDRESS>Xiao<EMAIL_ADDRESS>
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This really needs tests. I'm a ruby newbie so I haven't waded into figuring out how all the spec stuff works yet...

Btw, I had in the past written and used https://github.com/dblock/fue which is a way to dig through commits for emails in another way than DCO.

Btw, I had in the past written and used https://github.com/dblock/fue which is a way to dig through commits for emails in another way than DCO.

After parsing through a lot of this data, the DCO proved to be highest quality source for email addresses. The email address in the commit metadata itself was frequently something like<EMAIL_ADDRESS>where the DCO signoff in the commit message would be a real email address.

@andrross Want to finish this?

@dblock Yes I will finish this.

@dblock This is ready to review again. Added the README section plus another unit test.

Nice work, welcome to Ruby!


Download page broken

See http://entityframework-plus.net/download
Its linked on http://entityframework-plus.net/installing

Hello @Jogai ,
Thank a lot for reporting, the issue has been fixing.
We are currently making some major changes to the website so feel free to re-open it if we make again this mistake.
(Yes that's normal the layout is still ugly for the download, it will be improved today)
Best Regards,
Jonathan


[Request] Use Nx monorepository instead of yarn links

Description
This repository currently employs a monorepository structure with yarn links for managing package dependencies. However, there are some challenges associated with this approach, especially during development. Contributors are required to install node modules for each package individually and then build packages sequentially, starting from the base package to the most dependent one.
Additionally, the use of yarn links may introduce complications related to dynamic linking, potentially necessitating the recompilation of every package.
Proposed Solution
I propose migrating to Nx monorepository as an alternative solution. Nx provides a more streamlined approach to managing monorepositories, offering improved development workflows and addressing the challenges posed by yarn links.
Offer of Assistance
I am proficient with Nx and willing to contribute to the implementation of Nx in this repository. I am prepared to assist in creating a pull request to transition to Nx, ensuring a smoother development experience for contributors.
Next Steps
If there is interest in pursuing this change, we can discuss the steps needed for the transition and potential collaboration on a pull request. Please let me know your thoughts on adopting Nx in this repository.
Looking forward to your response!

Thanks for offering to implement the new feature! Excited to see your contribution


Warnings throwing on WC_Gateway_Simplify_Commerce_Loader::__wakeup().

Endless warning messages show up in error log file while running on PHP 8.
The magic method WC_Gateway_Simplify_Commerce_Loader::__wakeup() must have public visibility in ../wp-content/plugins/woocommerce-simplify-payment-gateway-plugin-2.2.0/woocommerce-simplify-payment-gateway.php on line 71.
Warnings goes away when set to public. Please check this, as in cases of high traffic, error logs is on fire.
Although this is a minor lets say warning, it doesn't mean nobody has to deal with this, right?

PHP 7.4 has now reached end of life support and PHP 8.0 is now the minimum supported release - please merge 2.3.2 with this commit to fix error for public visibility. There are also some other errors when using PHP 8.0 not addressed yet:
Warning: The magic method WC_Gateway_Simplify_Commerce_Loader::__wakeup() must have public visibility in /home/.../public_html/wp-content/plugins/simplifycommerce/woocommerce-simplify-payment-gateway.php on line 72
'Deprecated: Required parameter $args follows optional parameter $authentication in /home/pottedpetite/public_html/wp-content/plugins/simplifycommerce/includes/Simplify/PaymentsApi.php on line 268'
Deprecated: Required parameter $expectedArgCount follows optional parameter $authentication in /home/pottedpetite/public_html/wp-content/plugins/simplifycommerce/includes/Simplify/PaymentsApi.php on line 268

PHP 7.4 has now reached end of life support and PHP 8.0 is now the minimum supported release - please merge 2.3.2 with this commit to fix error for public visibility. There are also some other errors when using PHP 8.0 not addressed yet:
Warning: The magic method WC_Gateway_Simplify_Commerce_Loader::__wakeup() must have public visibility in /home/.../public_html/wp-content/plugins/simplifycommerce/woocommerce-simplify-payment-gateway.php on line 72
Deprecated: Required parameter $args follows optional parameter $authentication in /home/.../public_html/wp-content/plugins/simplifycommerce/includes/Simplify/PaymentsApi.php on line 268
Deprecated: Required parameter $expectedArgCount follows optional parameter $authentication in /home/.../public_html/wp-content/plugins/simplifycommerce/includes/Simplify/PaymentsApi.php on line 268


Reduced memory usage by reading files using extractBufferedDataFromFile…

… instead of readFile. Addresses #27
Files were previously read whole into memory and then written out. This change streams them instead, reducing the amount of memory required to unzip files.

I had one question I commented inline, but also these general concerns:

[ ] Please what broke the build. It looks like a unit test is failing
[ ] Please replace tabs with spaces (4 spaces per tab)

Take a look at the above, and then I'll take a closer look at the rest of your changes.

Sorry, I guess I have tabs set instead of spaces in Xcode.  I think it was something to do with the password not being provided. I didn't change any of that code and it looked like all other tests passed.

Switching your Xcode preference will affect new edits you make, but for now can you please do a find and replace (find \t and replace with 4 spaces). Sorry, it's a nitpick, but it'll keep the code more consistent.

I've added some inline comments, but this is looking good. Thanks again!

I've left a couple more inline comments. Thanks for sticking with it. We're close; I can feel it!
I can replace the tabs with spaces when I merge, if you'd prefer to change your Xcode preference back.

Oops. I did do a search and replace and have set Xcode to use spaces. Not sure why it didn't change though. I'll get to these issues later as I have to go out to demo the next version of my app to an iOS dev meetup. I'll get rid of that dataLength var if it's no longer needed and add the file handle check.

Do you think this is suitable to merge into master now?

Hey, sorry, I missed the commit you pushed. I took a look and made an inline comment. Take care of that, then I'll fix the tab-to-space conversion and merge manually.

ok, fixed. Hopefully it's ok now.

All set now. Thanks for suggesting and writing this. Awesome job!


Refactor messages-util.

Summary
I'll make some bigger changes to this module, first I'm gonna move everything into one file and remove the unnecessary indirection that's present here.
Test plan
jest

Codecov Report

Merging #3339 into master will decrease coverage by 0.02%.
The diff coverage is 86.9%.

@@            Coverage Diff             @@
##           master    #3339      +/-   ##
==========================================
- Coverage   65.07%   65.04%   -0.03%
==========================================
  Files         178      176       -2
  Lines        6539     6535       -4
  Branches        4        4
==========================================
- Hits         4255     4251       -4
  Misses       2283     2283
  Partials        1        1

Impacted Files
Coverage Δ

packages/jest-message-util/src/index.js
87.05% <86.9%> (-12.95%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554e884...6da92b3. Read the comment docs.


Async iteration over AsyncSearchItemPaged raises Forbidden on fetching next page

Package Name: azure-search-documents
Package Version: 11.2.1
Operating System: Ubuntu
Python Version: 3.9.7

Describe the bug
When using the Async version of the SearchClient from azure-search-documents python SDK, I get an error when iterating over a Search result with more than 50 products. It looks like the error occurs when thz AsyncSearchItemPaged object tries to post for the next page. I then get a "HttpResponseError: Operation returned an invalid status 'Forbidden'"
To Reproduce
Steps to reproduce the behavior:

Create an index with at least 50 items
Instantiate a SearchClient from azure.search.documents.aio
Request the empty string to get all documents
iterate over the search results with:
async for x in results:  print(x)

Expected behavior
I would expect every result to be printed, or to get a way to iterate over the pages of results without getting an error.

Hi @MrToustous thanks for the feedback. We'll take a look at this and get back to you asap.

Hi @MrToustous I am working on fixing the issue on my side. In the meantime as a work around, I was able to use the sync client and retrieve the items from the index properly.


How-To

I am just wondering on what the instructions are to use this git.  I have been looking for a way to implement this same feature in a CTF event that I am trying to put together for some people in my unit to learn pentesting.

I haven't had time yet to document how to use this, but you can always come by on OverTheWire IRC and we can talk about it


Logging with time #432

Now it includes a timestamp to every log message.
The travis icon change should be reverted.

I signed it!
2017-11-24 12:39 GMT+01:00 googlebot<EMAIL_ADDRESS>
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.

If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data https://cla.developers.google.com/clas and verify
that your email is set on your git commits
https://help.github.com/articles/setting-your-email-in-git/.
If your company signed a CLA, they designated a Point of Contact who
decides which employees are authorized to participate. You may need to
contact the Point of Contact for your company and ask to be added to the
group of authorized contributors. If you don't know who your Point of
Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have
the pull request author add another comment and the bot will run again.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensor2tensor/pull/440#issuecomment-346809790,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFEYXQ9VsPOFSfRQ2ZwuNEPQRpZrTkThks5s5qsKgaJpZM4Qptqg
.


docs: update vue jsx usage

Background
Currently. swc-plgin-vue-jsx is same as babel plugin.
So. I think we shouldn't need vue-jsx-compat anymore. ( and this way can be faster.

This pull request also fix the preact config error


chore: add guards to scripts to check presence of required programs

Just adds some friendlier messages when running our test and example
scripts.  This came up when a developer tried to use the scripts and
encountered errors.
Signed-off-by: Mikhail Swift<EMAIL_ADDRESS>

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.117%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
834

Relevant Lines:
2188

💛  - Coveralls


Dropbox service

Closes #41 and #40

Adds dropbox service for handling the dropbox API interaction
Adds nodejs logging using pino
Delete CV from dropbox when application is cancelled

Codecov Report

Merging #42 into master will decrease coverage by 1.12%.
The diff coverage is 57.36%.

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   67.85%   66.73%   -1.13%
==========================================
  Files          44       52       +8
  Lines         952     1043      +91
  Branches       97      107      +10
==========================================
+ Hits          646      696      +50
- Misses        295      336      +41
  Partials       11       11

Impacted Files
Coverage Δ

src/types.ts
100.00% <ø> (ø)

src/util/fs/writer.ts
25.00% <25.00%> (ø)

src/controllers/adminController.ts
21.27% <33.33%> (+2.52%)
:arrow_up:

src/util/strings/unicode.ts
33.33% <33.33%> (ø)

src/services/cloudStorage/cloudStorageService.ts
42.50% <42.50%> (ø)

src/util/errorHandling/errorHandler.ts
58.33% <50.00%> (+3.78%)
:arrow_up:

src/services/applications/applicantService.ts
77.41% <75.00%> (+0.37%)
:arrow_up:

src/app.ts
93.54% <80.00%> (+2.77%)
:arrow_up:

src/util/fs/loader.ts
79.41% <83.33%> (ø)

src/controllers/applicationController.ts
90.66% <100.00%> (+0.12%)
:arrow_up:

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7162e92...721b57f. Read the comment docs.


Icons not showing up

Not sure if I need to install a font, but the folder and other icon 'fonts' are not showing https://www.dropbox.com/s/yob5j7jl7d5rks8/Screenshot 2016-05-09 06.45.36.png?dl=0

Material UI doesn't change any icons. And looks like you have a problem with atom-monokai.


tar.gz in a tar file

my archives are backuped in tar format
and in that tar package there is the tar.gz
because i added the gzip compressor
so why is the compressed backup file again in a tar file
this does not make any sense to me
my model has the following
  compress_with Gzip
  archive :data do |archive|
    archive.add '/var/mydir'
    archive.tar_options '-p'
  end

So what is the actual structure of your backup file? Like so?:
- backup.tar
  - archives/
    - archive.tar.gz

That's normal. Well, that's how backup is set up. Backup performs all the separate backup procedures, archives that and compresses it. Then in the final step it archives it in one big backup file.
It makes it easier to transfer the data as one file compared to splitting it up.

Yes that's exactly the structure.
But it's annoying for restore potions because now we need several more
steps to unpack and restore
Are there any tricks to solve this?
Op do 29 okt. 2015 21:51 schreef Tom de Bruijn<EMAIL_ADDRESS>
So what is the actual structure of your backup file? Like so?:

backup.tar

archives/

archive.tar.gz

That's normal. Well, that's how backup is set up. Backup performs all the
separate backup procedures, archives that and compresses it. Then in the
final step it archives it in one big backup file.
It makes it easier to transfer the data as one file compared to splitting
it up.
—
Reply to this email directly or view it on GitHub
https://github.com/backup/backup/issues/718#issuecomment-152318579.

Can't really change this now. It's how the backup pipeline works. You could write a little script for it to extract all nested files


Background Service sleeps when screen is locked

Describe the bug
The background service returns coordinates until the screen is locked.
During the locked screen the service seems to sleep.
After screen is unlocked the service restart to return coordinates.
To Reproduce
Steps to reproduce the behavior:
Add Location: Allow always to the app permissions.
In Location.cs add a statement (WriteLog) to write timestamp to file
		public async Task Run(CancellationToken token)
		{
			await Task.Run(async () => {
				while (!stopping)
				{
					token.ThrowIfCancellationRequested();
					try
					{
						await Task.Delay(2000);

						var request = new GeolocationRequest(GeolocationAccuracy.High);
						var location = await Geolocation.GetLocationAsync(request);
						if (location != null)
						{
							var message = new LocationMessage
							{
								Latitude = location.Latitude,
								Longitude = location.Longitude
							};

							WriteLog(location.Timestamp.ToString());

							Device.BeginInvokeOnMainThread(() =>
							{
								MessagingCenter.Send<LocationMessage>(message, "Location");
							});
						}
					}
					catch (Exception ex)
					{
						Device.BeginInvokeOnMainThread(() =>
						{
							var errormessage = new LocationErrorMessage();
							MessagingCenter.Send<LocationErrorMessage>(errormessage, "LocationError");
						});
					}
				}
				return;
			}, token);
		}

		private void WriteLog(string msg)
        {
			string fileLog = System.IO.Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments), "log.log");
			using (System.IO.StreamWriter sw = System.IO.File.AppendText(fileLog))
			{
				sw.WriteLine(msg);
			}
		}

Expected behavior
Run app and lock the screen. After 10 minutes unlock the screen and close the app.
Connect the iPhone to PC and copy the log file that has been created and analyze the content.
You will find a hole in the period that the screen was locked.
Desktop:

OS: iOS

Smartphone:

Device: iPhone 10
OS: iOS 15.1

Why this post hes been closed without any answer?


Fails to interact with rest api

2:58 PM	Failed set file review status for Gerrit change: com.google.gerrit.extensions.restapi.RestApiException: Expected JSON but got 'text/html'.
2:58 PM	Failed to save draft comment: com.google.gerrit.extensions.restapi.RestApiException: Expected JSON but got 'text/html'.
I get this on clicking on the diff and adding comments.
Gerrit 3.4.1
Plugin 1.2.5-203

@theoman6: Do other operations work for you? For example set a star for a change (using change context menu) or any other write operation?

Hi. I'm having the same issue on windows but not on linux. Can I help somehow to diagnose this defect?

@teodozjan: Do other operations work for you? For example set a star for a change (using change context menu) or any other write operation?

14:06	Failed to star Gerrit change (not supported for Gerrit versions older than 2.8): com.google.gerrit.extensions.restapi.RestApiException: Expected JSON but got 'text/html; charset=iso-8859-1

while server version is newer

Powered by Gerrit Code Review (3.4.1)

@teodozjan: What authentication method does your Gerrit server use? Is it a single sing on system?

No, it is user password based login

SOLVED
Problem was with http:// instead of https:// prefix. I feel little embarrassed to make such mistake. I'm not sure if plugin can show better information to a user?

Thanks for sharing the update.
I'm not sure how we can detect such an error in a better way in the plugin... In case your server also responds on http port, it will just result in an http error.


Use ExternalSorter for Statistics while buiding index

What changes were proposed in this pull request?
To resolve #785 , in local test building B+ tree index for 3 * 10^7 rows, original takes 2.1min with 1.5min GC, with this PR it takes 1.8min with 58s GC.
Current implementation has 1 not so graceful point: because Part-by-value & sample both need this sortedKeys, and one Iterator can only be traversed once, a duplicate ExternalSorter is created.
Still trying to avoid creating 2...Another consideration is after the current sqlite version of sample PR is merged, we remove the original Part-by-value & sample code path, than this problem will resolve.
How was this patch tested?
SampleBasedStatisticsSuite.scala, StatisticsManagerSuite.scala

As synced offline, we will change to 1 sorter and merge this after #794 is merged

This may currently not be supported, due to the potential issue in PR description. : (


Can I use it in Window System?

Thank you very much for your excellent work; the results are truly exciting. I would like to ask, if is it possible to run your code on a Windows system.
Best Regards

应该不行，有一些包不能装在windows上

好吧😞，谢谢！


How to add custom attribute to the mailboxer tables?

I want to add the product with the message so i can filter the messages according to the products. I have passed the product id to the new message form and created a new column names as product_id in the mailboxer_conversations table. But The product id value is not saved in the table when i send the message. Please help me to fix this.

Sorry, this isn’t in scope for this project.


Update capitalization in nav pane en-GB & en-US

Resolved / Related Issues
Closes #8221
Details of Changes

I changed to capital letter in en-GB and en-US.

Validation

[x] Built and ran the app
[x] Tested the changes for accessibility

@michalmrowiec before we merge this, can you add your agreement to #7625?

I have already done


How to get subtitle in original audio language without translation ?

Checklist

[X] I'm asking a question and not reporting a bug/feature request
[X] I've looked through the README
[X] I've read the guidelines for opening an issue
[X] I've searched the bugtracker for similar questions including closed ones

Question
I want to download subtitle of original audio without translation. This is the one I get on screen by default when I press de CC button.
With the key writeautomaticsub I get a translation in English. I want it to, but I can't find the way to get the text of original language.
Thank you for your help.
Verbose log
No response

See the available languages in --list-subs and select the one you want with --sub-lang

Sadly it is not what I have expected. I guess that a automatic selection is impossible...
But how make yt to select the language that I want and put this one on screen by default ?

I don't understand your question. Please explain, with --list-subs output and any other relevent logs

Sorry, English is not my mother tongue. What I mean was:
When I push the CC button on the screen, YT display by default subtitle with the language I want.
Is this a completely hidden mechanism ? Must I investigate or Is it hopeless ?

Downloading with the option --write-auto-subs I get the English version following the Accept-Language directive of the header.
For the same video with my browser, I get the Portuguese subtitle as default and the only options are :

off
Portuguese (auto-generated)

I want to get this last language and English translation too without the need to manually selecting anything.
The expression (auto-generated) of YT means that this subtitle is from a speech recognition. I though that --write-auto-subs should be the same.
With hope that this technical message is clearer.

I though of a possible work around :
accept all languages and download English version with --sub-lang
Not tried but I see in cookies PREF=cvdm=grid&hl=en... that precede certainly the Accept-Language

Pukkadan I think I understand him.
When downloading captions yt-dlp always downloads translated to english when is available.
Even if you don't tell yt-dlp to do that.
https://github.com/yt-dlp/yt-dlp/blob/455a15e2dcf29b4712d92a89a95ad5f3ddad69a1/yt_dlp/YoutubeDL.py#L2669-L2670
[debug] Invoking downloader on "https://www.youtube.com/api/timedtext?v=tQqDBySHYlc&asr_langs=de%2Cen%2Ces%2Cfr%2Cid%2Cit%2Cja%2Cko%2Cnl%2Cpt%2Cru%2Ctr%2Cvi&caps=asr&exp=xctw&xoaf=5&hl=en&ip=<IP_ADDRESS>&ipbits=0&expire=1644532828&sparams=ip%2Cipbits%2Cexpire%2Cv%2Casr_langs%2Ccaps%2Cexp%2Cxoaf&signature=99999999999999999999999999999999999999999999999999999999999999999999999999999999999&key=yt8&kind=asr&lang=pt&tlang=en&fmt=vtt"

The YT behavior is captions generate on original language, it only translate if you tell YT to translate.

So, to match YT behavior, default requested langs should be the one returned on JSON not hard coded as 'en'
  "captions": {
    "playerCaptionsTracklistRenderer": {
      "captionTracks": [
        {
          "baseUrl": "https://www.youtube.com/api/timedtext?v=tQqDBySHYlc&asr_langs=de,en,es,fr,id,it,ja,ko,nl,pt,ru,tr,vi&caps=asr&exp=xctw&xoaf=5&hl=en&ip=<IP_ADDRESS>&ipbits=0&expire=1644533677&sparams=ip,ipbits,expire,v,asr_langs,caps,exp,xoaf&signature=9999999999999999999999999999999999999999999999999999999999999999999999999999999999&key=yt8&kind=asr&lang=pt&fmt=srv3",
          "name": {
            "runs": [
              {
                "text": "Portuguese (auto-generated)"
              }
            ]
          },
          "vssId": "a.pt",
          "languageCode": "pt",
          "kind": "asr",
          "isTranslatable": true
        }
      ],
      "audioTracks": [
        {
          "captionTrackIndices": [
            0
          ]
        }
      ],
      "defaultAudioTrackIndex": 0
    }
  },

Pukkadan I think I understand him.

Thank you, you have understood. :+1:

Now the "original" auto-subs will appear with language code ending in -orig. You can use regex in --sub-langs to match it. The pt and pt-orig subs are actually the same. I didn't remove pt so as not to break anyone's setup. Hopefully, this duplication doesnt bother anyone

Wow, Many Thanks @pukkandan

yt-dlp --cookies cookies.txt --sub-langs 'en.*,.*orig' --write-auto-subs https://www.youtube.com/watch?v=tQqDBySHYlc
work as expected. Many thanks again.
But I am too stupid to put this in options:
yt_dlp.YoutubeDL({
'subtitleslangs': 'en.*,.*orig',
'writeautomaticsub': True,
})
throw the error:
nothing to repeat at position 0

yt-dlp --cookies cookies.txt --sub-langs 'en.*,.*orig' --write-auto-subs https://www.youtube.com/watch?v=tQqDBySHYlc work as expected. Many thanks again.
'subtitleslangs': ['en.*','.*orig'],
'writeautomaticsub': True,

Work as expected too. Thank you
Very sorry for the video sample. I even not watched it.

Thank you for this workaround. However note that videos having automatically generated subtitles but being set to Off by default aren't retrieved with your method. My workaround is to first call YouTube Data API v3 Captions: list endpoint with part=snippet and retrieve the language that has "trackKind": "asr" in item/snippet.


improve doc on keyring usage

I get your point, but the user should really check which keyring backend was chosen for storing the password (which is why I removed feature of adding the password from vdirsyncer).

While I get your point (and you might want to add a warning to make people configure keyring and a link to keyring's documentation), I do believe the current situation is not really userfriendly.
Secondly, it will make people's systems less safe (because people are lazy, at least I am). If  people configure password retrieval wrongly and it doesn't work, theywill put their password into the config file in clear text (at least I did that after upgrading), which leads IMO to a much higher risk of accidentally publishing once password.
Also, if keyring returns None (what happens when it's not configured properly) a warning should be given to the user, instead of trying to use no password and than failing (I didn't try it for other password retrieval options).
If a username but no password is set, a warning should be printed as well (there is a warning if auth is set). If users really want to connect with a username but no password, they still can set an empty password (if that even is a thing).

While I get your point (and you might want to add a warning to make people configure keyring and a link to keyring's documentation), I do believe the current situation is not really userfriendly.

Are you proposing adding the feature of "store password on prompt" back into vdirsyncer? I can't see a way how it'd work in a sensible way, given how the current "fetching" system is so generic.
Tbh this is precisely why I am getting sick of keyring, it adds an opaque abstraction layer that doesn't make it obvious where stuff is actually stored. One advantage of custom CLI commands is that you can just try them out on the console to see if they work. You don't have a true equivalent with keyring, unless you consider the Python REPL. But if you're not a Python dev, that's not a good experience.
Perhaps this could be circumvented with a new subcommand on vdirsyncer that allows users to get and set passwords using keyring, but it seems grossly out of scope for vdirsyncer.

Also, if keyring returns None (what happens when it's not configured properly) a warning should be given to the user, instead of trying to use no password and than failing (I didn't try it for other password retrieval options).

I've fixed this by erroring out on all false-ish values for now. Since there's afaik no param in any vdirsyncer storage where an empty value makes sense, I think this doesn't kill any usecase, but oh well, we'll see.

Sorry for not replying to this before. No, I don't think the "save password feature" should be come back. Perhaps the keyring feature should just be removed, people who want to use it can use a minimal script like many people use it for offlineimap.

Opened #313 for further planning.


⚠ Bofrost.nl has degraded performance

In a3c0ee6, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 1412 ms

Resolved: Bofrost.nl performance has improved in 9880a27.


Stop throwing errors in env.js for unexpected variables

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs (https://github.com/sveltejs/kit/discussions/10877)
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

I couldn't find any tests that actually tested for throwing the errors. This PR removes that behavior, so I haven't added/removed any tests.
I can add tests if you'd like.

This behavior is intentional. If a new version of the Node adapter adds a new environment variable that controls its behavior that you happened to already have set, we don't want to suddenly change the behavior of the built application.
If you want to have APPLICATION_NAME_FOO and APPLICATION_NAME_BAR as environment variables, you can set your prefix to something like APPLICATION_NAME_LISTEN_ so that you then have APPLICATION_NAME_LISTEN_PORT etc. and the application would only complain about other unknown APPLICATION_NAME_LISTEN_ variables, which you won't have any of.

Thanks @Conduitry That's actually what we did in the mean time. Thanks for the response!


Unable to attach event to specific Button(radio button) change

Hi @felixnielsen ,
Is there a way to attach an event to a specific action i.e a radio button ?
I've noticed that the form doesn't build out the id attributes in run time.
So I am unable to target the specific event.
Regards

hi @khaalidm you highlight a good thing, I will add id attributes to the fields.
What you can do now is listen to cf.UserInputEvents.CONTROL_ELEMENTS_ADDED event and then you can get the buttons there and attach your events.
I will also add an event that will get exposed through the event dispatcher for these buttons. Added in next release.

hi @felixnielsen
Thank you for the speedy response,
I am using the cf.ControlElementEvents.SUBMIT_VALUE event  to listen for radio-button clicks,
I have steps with multiple options(radio buttons), so I do not think that cf.UserInputEvents.CONTROL_ELEMENTS_ADDED would help, since I cannot target the specific button click. so I won't be able to attach an event.
If I have the id attribute from the input tag in the form that populates during run time, I can listen for that in the event and trigger my function call.
I am a big fan of CF, I see a lot of potential with this, Thanks for the great work =D

@khaalidm thx :)
As you are using a radio button, can you then not use flowCallback?
Like this example: https://jsbin.com/ponibimeka/edit?html,js,output

@felixnielsen ahh I see,
apologies, I didn't understand what you said previously.
Thanks a million for the help =D

Didn't understand how to trigger an event on radio inputs. Does someone have a more precise example  ?


Retweet bot

Script Title - Simple script that retweets any hashtag provided in it.
Brief -
Instructions

Create a new folder for your script and file/folder name should be appropriate.
Create a README.md in your folder for program Instructions
add requirements.txt if needed

Programming Language

[x] Python

Happy Coding

Hi @pawangeek , Can I work on this issue?

Sure, go ahead


Rename repo?

Should we rename this repo tutorials.quanteda.io ?

I think we can rename the repo to tutorials.quanteda.io. If @koheiw agrees, I will check all links on the website (some refer to the quanteda_tutorials GitHub repo) and make a PR.

I created a new branch where I updated the URLs from http://github.com/quanteda/quanteda_tutorials/... to https://github.com/quanteda/tutorials.quanteda.io/....
@koheiw, could you have a look at this, make changes if necessary, rename the repo, rebuild the website, and make a PR?


fix: add missing peer deps

Resolves missing peer dependency errors when using Yarn PnP, e.g.
ERR! Error: @storybook/builder-vite requires @vitejs/plugin-vue to be installed when using @storybook/vue or @storybook/vue3.  Please install it and start storybook again.

Thanks for the PR, @adalinesimonian.  It looks like the yarn.lock needs to be updated, mind pushing that up?

Will peerDependenciesMeta keep all package managers from erroring or installing the dep if it's missing?

Thanks for the PR, @adalinesimonian. It looks like the yarn.lock needs to be updated, mind pushing that up?

Whoops, I'll get that fixed.

Will peerDependenciesMeta keep all package managers from erroring or installing the dep if it's missing?

afaik all three major package managers support the key:

npm: https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependenciesmeta
yarn: https://yarnpkg.com/configuration/manifest#peerDependenciesMeta
pnpm: https://pnpm.io/package_json#peerdependenciesmetaoptional

Thanks again for this.  We're in the middle of a re-organization of the monorepo in https://github.com/storybookjs/builder-vite/pull/502.  I'd like to hold off on this PR until that's done and the dust settles.  It should be soon, and we'll be sure to get the peer deps taken care of before the next release.


Composer compains about nunomanduro nunomaduro/collision package

Pulse Version
1
Laravel Version
10.35.0
PHP Version
8.2.3
Livewire Version
not using livewire
Database Driver & Version
mysql
Description
When trying to install Pulse on existing project getting composer error

here is a part of composer.json
"require": {
       "php": "^8.2",
       "barryvdh/laravel-dompdf": "^2.0",
       "beyondcode/laravel-websockets": "^1.13",
       "doctrine/dbal": "^3.4",
       "guzzlehttp/guzzle": "^7.2",
       "inertiajs/inertia-laravel": "^0.6.3",
       "jenssegers/agent": "^2.6",
       "laravel/framework": "^10.0",
       "laravel/horizon": "^5.14",
       "laravel/jetstream": "^2.11",
       "laravel/sanctum": "^3.0",
       "laravel/slack-notification-channel": "^2.4",
       "laravel/tinker": "^2.7",
       "league/flysystem-aws-s3-v3": "^3.0",
       "meilisearch/meilisearch-php": "^0.24.2",
       "predis/predis": "^2.0",
       "pusher/pusher-php-server": "^7.2",
       "spatie/laravel-activitylog": "^4.5",
       "spatie/laravel-medialibrary": "^10.0.0",
       "staudenmeir/belongs-to-through": "^2.5",
       "staudenmeir/eloquent-has-many-deep": "^1.7",
       "symfony/http-client": "^6.1",
       "symfony/mailgun-mailer": "^6.1",
       "tightenco/ziggy": "^1.0",
       "laravel/spark-paddle": "^3.0"
   },
   "require-dev": {
       "barryvdh/laravel-debugbar": "^3.7",
       "barryvdh/laravel-ide-helper": "^2.12",
       "fakerphp/faker": "^1.9.1",
       "itsgoingd/clockwork": "^5.1",
       "laravel/pint": "^1.0",
       "laravel/sail": "^1.0.1",
       "mockery/mockery": "^1.4.4",
       "nunomaduro/collision": "^6.1",
       "pestphp/pest": "^1.22",
       "pestphp/pest-plugin-laravel": "^1.4",
       "phpunit/phpunit": "^9.5.10",
       "spatie/laravel-ignition": "^2.0"
   },

Steps To Reproduce
Run composer require laravel/pulse on existing application.

Which exact version of Pulse are you using?

I have the same problem and I just wanted to use pulse on the existence project and faced this error:
laravel/pulse[v1.0.0-beta1, ..., v1.0.0-beta2] conflict with nunomaduro/collision <7.7.0.

You need to upgrade nunomaduro/collision up to ^7.7 version: composer require nunomaduro/collision:^7.7 --dev

Which exact version of Pulse are you using?

@jbrooksuk i am using one as for today. Dont know which one is as it never installs cause of nunomanduro/collision package error

Ok here is how i did it.
i removed those:
 "pestphp/pest": "^1.22",
 "pestphp/pest-plugin-laravel": "^1.4",

as they are requiring nunomanduro/collision 6
then i run composer update
then i changed in composer.json version for nunomanduro/collision to 7
run composer update
then again installed pest.
run composer require laravel/pulse

Works now.

thanks worked for me too.

Hey folks, sorry for the troubles here.
This version is required in order to be able to show exceptions correctly in development environments.


[Teams - Post message in a chat or channel].    Message input fields are not able to refer to the set values.

Describe the Bug with repro steps

Display the designer of an existing workflow.
Select the existing Teams - Post message in a chat or channel action.
Make sure Message in Parameters is blank.
Click Code View.
Make sure that body.messageBody is set.

What type of Logic App Is this happening in?
Standard (Portal)
Are you using Preview Designer or GA Designer
Generally Available
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos

Browser
Microsoft Edge
Version 114.0.1823.41 (arm64)
Additional context
No response
AB#24211176

@tottokug - is the issue that even if you have message set in definition it is not showing up in the parameter field on reload?

From some initial testing it looks like this serializes fine if you don't change the parameter value, but loading the component loads empty if the value is wrapped in a  tag.  Also if you input a plain text value to the editor it wraps it in a  tag, and upon reload is empty.