How do I make this work?

I'm trying to build my system config with this, but it just gets stuck in a loop of throwing errors at me, a lot of them too. Here is an example output that I ran for about 20 seconds.

⏱ 1strace: warning: External use of `lib.modules.applyModuleArgsIfFunction` is deprecated. If your use case isn't covered by non-deprecated functions, we'd like to know more and perhaps support your use case well, instead of providing access to these low level functions. In this case please open an issue in https://github.com/nixos/nixpkgs/issues/.
trace: warning: lib.cartesianProductOfSets is a deprecated alias of lib.cartesianProduct.
trace: warning: lib.zip is a deprecated alias of lib.zipAttrsWith.
trace: warning: lib.zipWithNames is a deprecated alias of lib.zipAttrsWithNames.
error: cannot evaluate a function that has an argument without a value ('src')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/sources.nix:73:7:
           72|       # A path or cleanSourceWith result to filter and/or rename.
           73|       src,
             |       ^
           74|       # Optional with default value: constant true (include everything)
trace: warning: lib.crossLists is deprecated, use lib.mapCartesianProduct instead.

    For example, the following function call:

    nix-repl> lib.crossLists (x: y: x+y) [[1 2] [3 4]]
    [ 4 5 5 6 ]

    Can now be replaced by the following one:

    nix-repl> lib.mapCartesianProduct ({x,y}: x+y) { x = [1 2]; y = [3 4]; }
    [ 4 5 5 6 ]

error: cannot evaluate a function that has an argument without a value ('newScope')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/customisation.nix:616:7:
          615|     { splicePackages
          616|     , newScope
             |       ^
          617|     }:
error: cannot evaluate a function that has an argument without a value ('derivation')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/derivations.nix:92:7:
           91|     args@{
           92|       derivation,
             |       ^
           93|       meta ? null,
trace: warning: External use of `lib.modules.dischargeProperties` is deprecated. If your use case isn't covered by non-deprecated functions, we'd like to know more and perhaps support your use case well, instead of providing access to these low level functions. In this case please open an issue in https://github.com/nixos/nixpkgs/issues/.
error: cannot evaluate a function that has an argument without a value ('warn')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/modules.nix:1286:5:
         1285|     #        - this may or may not work outside NixOS
         1286|     warn,
             |     ^
         1287|     # A function that is applied to the option value, to form the value
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/modules.nix:86:19:
           85|   evalModules = evalModulesArgs@
           86|                 { modules
             |                   ^
           87|                 , prefix ? []
trace: warning: External use of `lib.evalOptionValue` is deprecated. If your use case isn't covered by non-deprecated functions, we'd like to know more and perhaps support your use case well, instead of providing access to these low level functions. In this case please open an issue in https://github.com/nixos/nixpkgs/issues/.
error: cannot evaluate a function that has an argument without a value ('root')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/fileset/default.nix:427:5:
          426|   toSource = {
          427|     root,
             |     ^
          428|     fileset,
error:
       … from call site

       error: function 'packagesFromDirectoryRecursive' called without required argument 'callPackage'
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/filesystem.nix:358:5:
          357|   packagesFromDirectoryRecursive =
          358|     {
             |     ^
          359|       callPackage,
error: cannot evaluate a function that has an argument without a value ('depthLimit')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/generators.nix:428:7:
          427|     {
          428|       depthLimit,
             |       ^
          429|       throwOnDepthLimit ? true
error: cannot evaluate a function that has an argument without a value ('derivation')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/derivations.nix:92:7:
           91|     args@{
           92|       derivation,
             |       ^
           93|       meta ? null,
error: cannot evaluate a function that has an argument without a value ('startSet')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/deprecated/misc.nix:147:25:
          146|
          147|   lazyGenericClosure = {startSet, operator}:
             |                         ^
          148|     let
trace: warning: lib.crossLists is deprecated, use lib.mapCartesianProduct instead.

    For example, the following function call:

    nix-repl> lib.crossLists (x: y: x+y) [[1 2] [3 4]]
    [ 4 5 5 6 ]

    Can now be replaced by the following one:

    nix-repl> lib.mapCartesianProduct ({x,y}: x+y) { x = [1 2]; y = [3 4]; }
    [ 4 5 5 6 ]

trace: warning: lib.literalExample is deprecated, use lib.literalExpression instead, or use lib.literalMD for a non-Nix description.
error: cannot evaluate a function that has an argument without a value ('newScope')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/customisation.nix:616:7:
          615|     { splicePackages
          616|     , newScope
             |       ^
          617|     }:
trace: warning: External use of `lib.modules.mergeModules` is deprecated. If your use case isn't covered by non-deprecated functions, we'd like to know more and perhaps support your use case well, instead of providing access to these low level functions. In this case please open an issue in https://github.com/nixos/nixpkgs/issues/.
trace: warning: External use of `lib.modules.mergeModules'` is deprecated. If your use case isn't covered by non-deprecated functions, we'd like to know more and perhaps support your use case well, instead of providing access to these low level functions. In this case please open an issue in https://github.com/nixos/nixpkgs/issues/.
error: cannot evaluate a function that has an argument without a value ('message')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/options.nix:270:7:
          269|   mergeUniqueOption = args@{
          270|       message,
             |       ^
          271|       # WARNING: the default merge function assumes that the definition is a valid (option) value. You MUST pass a merge function if the return value needs to be
error: cannot evaluate a function that has an argument without a value ('startSet')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/deprecated/misc.nix:147:25:
          146|
          147|   lazyGenericClosure = {startSet, operator}:
             |                         ^
          148|     let
error: cannot evaluate a function that has an argument without a value ('inputList')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/deprecated/misc.nix:114:16:
          113|   # This function has O(n^2) performance.
          114|   uniqList = { inputList, acc ? [] }:
             |                ^
          115|     let go = xs: acc:
error: cannot evaluate a function that has an argument without a value ('inputList')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/deprecated/misc.nix:123:19:
          122|
          123|   uniqListExt = { inputList,
             |                   ^
          124|                   outputList ? [],
trace: warning: lib.mkFixStrictness has no effect and will be removed. It returns its argument unmodified, so you can just remove any calls.
error: cannot evaluate a function that has an argument without a value ('name')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:117:7:
          116|       # the type function name.
          117|       name
             |       ^
          118|     , # Description of the type, defined recursively by embedding the wrapped type if any.
trace: warning: mkPackageOptionMD is deprecated and will be removed in 25.05; please use mkPackageOption.
error: cannot evaluate a function that has an argument without a value ('from')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/modules.nix:1141:5:
         1140|     /* Old option path as list of strings. */
         1141|     from,
             |     ^
         1142|     /* New option path as list of strings. */
trace: warning: External use of `lib.modules.applyModuleArgsIfFunction` is deprecated. If your use case isn't covered by non-deprecated functions, we'd like to know more and perhaps support your use case well, instead of providing access to these low level functions. In this case please open an issue in https://github.com/nixos/nixpkgs/issues/.
trace: warning: lib.modules.defaultPriority is deprecated, please use lib.modules.defaultOverridePriority instead.
trace: warning: External use of `lib.modules.dischargeProperties` is deprecated. If your use case isn't covered by non-deprecated functions, we'd like to know more and perhaps support your use case well, instead of providing access to these low level functions. In this case please open an issue in https://github.com/nixos/nixpkgs/issues/.
trace: warning: External use of `lib.modules.collectModules` is deprecated. If your use case isn't covered by non-deprecated functions, we'd like to know more and perhaps support your use case well, instead of providing access to these low level functions. In this case please open an issue in https://github.com/nixos/nixpkgs/issues/.
error: cannot evaluate a function that has an argument without a value ('warn')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/modules.nix:1286:5:
         1285|     #        - this may or may not work outside NixOS
         1286|     warn,
             |     ^
         1287|     # A function that is applied to the option value, to form the value
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/modules.nix:86:19:
           85|   evalModules = evalModulesArgs@
           86|                 { modules
             |                   ^
           87|                 , prefix ? []
trace: warning: lib.mkFixStrictness has no effect and will be removed. It returns its argument unmodified, so you can just remove any calls.
trace: warning: External use of `lib.modules.mergeModules'` is deprecated. If your use case isn't covered by non-deprecated functions, we'd like to know more and perhaps support your use case well, instead of providing access to these low level functions. In this case please open an issue in https://github.com/nixos/nixpkgs/issues/.
trace: warning: External use of `lib.modules.pushDownProperties` is deprecated. If your use case isn't covered by non-deprecated functions, we'd like to know more and perhaps support your use case well, instead of providing access to these low level functions. In this case please open an issue in https://github.com/nixos/nixpkgs/issues/.
trace: warning: External use of `lib.modules.unifyModuleSyntax` is deprecated. If your use case isn't covered by non-deprecated functions, we'd like to know more and perhaps support your use case well, instead of providing access to these low level functions. In this case please open an issue in https://github.com/nixos/nixpkgs/issues/.
error: cannot evaluate a function that has an argument without a value ('from')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/modules.nix:1141:5:
         1140|     /* Old option path as list of strings. */
         1141|     from,
             |     ^
         1142|     /* New option path as list of strings. */
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
⏱ 2strace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixpkgsVersion is a deprecated alias of lib.version.
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
error: cannot evaluate a function that has an argument without a value ('message')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/options.nix:270:7:
          269|   mergeUniqueOption = args@{
          270|       message,
             |       ^
          271|       # WARNING: the default merge function assumes that the definition is a valid (option) value. You MUST pass a merge function if the return value needs to be
trace: warning: lib.literalExample is deprecated, use lib.literalExpression instead, or use lib.literalMD for a non-Nix description.
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
error:
       … from call site

       error: function 'packagesFromDirectoryRecursive' called without required argument 'callPackage'
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/filesystem.nix:358:5:
          357|   packagesFromDirectoryRecursive =
          358|     {
             |     ^
          359|       callPackage,
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: mkPackageOptionMD is deprecated and will be removed in 25.05; please use mkPackageOption.
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838| trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
trace: warning: lib.nixos.evalModules is experimental and subject to change. See nixos/lib/default.nix
    submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
⏱ 3serror: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
⏱ 4serror: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
error: cannot evaluate a function that has an argument without a value ('modules')
       Nix attempted to evaluate a function as a top level expression; in
       this case it must have its arguments supplied either by default
       values, or passed explicitly with '--arg' or '--argstr'. See
       https://nixos.org/manual/nix/stable/language/constructs.html#functions.
       at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/types.nix:839:9:
          838|     submoduleWith =
          839|       { modules
             |         ^
          840|       , specialArgs ? {}
trace: Obsolete option `snapraid' is used. It was renamed to `services.snapraid'.
⏱ 8strace: Obsolete option `jobs' is used. It was renamed to `systemd.services'.
trace: Obsolete option `snapraid' is used. It was renamed to `services.snapraid'.
error:
       … while evaluating the attribute 'value'
         at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/modules.nix:821:9:
          820|     in warnDeprecation opt //
          821|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          822|         inherit (res.defsFinal') highestPrio;

       … while evaluating the option `passthru':

       … while evaluating the attribute 'mergedValue'
         at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/modules.nix:856:5:
          855|     # Type-check the remaining definitions, and merge them. Or throw if no definitions.
          856|     mergedValue =
             |     ^
          857|       if isDefined then

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: The option `passthru' is used but not defined.
⏱ 9strace: Obsolete option `snapraid' is used. It was renamed to `services.snapraid'.
⏱ 10strace: Obsolete option `jobs' is used. It was renamed to `systemd.services'.
⏱ 11serror:
       … while calling the 'throw' builtin
         at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/pkgs/top-level/all-packages.nix:106:36:
          105|   ### Evaluating the entire Nixpkgs naively will fail, make failure fast
          106|   AAAAAASomeThingsFailToEvaluate = throw ''
             |                                    ^
          107|     Please be informed that this pseudo-package is not the only part

       error: Please be informed that this pseudo-package is not the only part
       of Nixpkgs that fails to evaluate. You should not evaluate
       entire Nixpkgs without some special measures to handle failing
       packages, like using pkgs/top-level/release-attrpaths-superset.nix.
⏱ 15s nom hasn‘t detected any input. Have you redirected nix-build stderr into nom? (See -h and the README for details.)trace: Obsolete option `jobs' is used. It was renamed to `systemd.services'.
error:
       … while evaluating the attribute 'value'
         at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/modules.nix:821:9:
          820|     in warnDeprecation opt //
          821|       { value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          822|         inherit (res.defsFinal') highestPrio;

       … while evaluating the option `passthru':

       … while evaluating the attribute 'mergedValue'
         at /nix/store/jvpl6r8pjkc17jni8h5qf67mpnbsy1xs-source/lib/modules.nix:856:5:
          855|     # Type-check the remaining definitions, and merge them. Or throw if no definitions.
          856|     mergedValue =
             |     ^
          857|       if isDefined then

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: The option `passthru' is used but not defined.
⏱ 16s nom hasn‘t detected any input. Have you redirected nix-build stderr into nom? (See -h and the README for details.)trace: Obsolete option `boot.binfmtMiscRegistrations' is used. It was renamed to `boot.binfmt.registrations'.
⏱ 17s nom hasn‘t detected any input. Have you redirected nix-build stderr into nom? (See -h and the README for details.)trace: Obsolete option `boot.copyKernels' is used. It was renamed to `boot.loader.grub.copyKernels'.
trace: Obsolete option `boot.cleanTmpDir' is used. It was renamed to `boot.tmp.cleanOnBoot'.
⏱ 18s nom hasn‘t detected any input. Have you redirected nix-build stderr into nom? (See -h and the README for details.)trace: Obsolete option `boot.extraGrubEntries' is used. It was renamed to `boot.loader.grub.extraEntries'.
trace: Obsolete option `boot.earlyVconsoleSetup' is used. It was renamed to `console.earlySetup'.
⏱ 19s nom hasn‘t detected any input. Have you redirected nix-build stderr into nom? (See -h and the README for details.)trace: Obsolete option `boot.extraGrubEntriesBeforeNixos' is used. It was renamed to `boot.loader.grub.extraEntriesBeforeNixOS'.
⏱ 21s nom hasn‘t detected any input. Have you redirected nix-build stderr into nom? (See -h and the README for details.)^CINFO:nix_fast_build:nix-fast-build was canceled by the user ()
Exception ignored in: <function BaseSubprocessTransport.__del__ at 0x7f92e705f2e0>
Traceback (most recent call last):
  File "/nix/store/z7xxy35k7620hs6fn6la5fg2lgklv72l-python3-3.12.4/lib/python3.12/asyncio/base_subprocess.py", line 126, in __del__
    self.close()
  File "/nix/store/z7xxy35k7620hs6fn6la5fg2lgklv72l-python3-3.12.4/lib/python3.12/asyncio/base_subprocess.py", line 104, in close
    proto.pipe.close()
  File "/nix/store/z7xxy35k7620hs6fn6la5fg2lgklv72l-python3-3.12.4/lib/python3.12/asyncio/unix_events.py", line 568, in close
    self._close(None)
  File "/nix/store/z7xxy35k7620hs6fn6la5fg2lgklv72l-python3-3.12.4/lib/python3.12/asyncio/unix_events.py", line 592, in _close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/nix/store/z7xxy35k7620hs6fn6la5fg2lgklv72l-python3-3.12.4/lib/python3.12/asyncio/base_events.py", line 795, in call_soon
    self._check_closed()
  File "/nix/store/z7xxy35k7620hs6fn6la5fg2lgklv72l-python3-3.12.4/lib/python3.12/asyncio/base_events.py", line 541, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

You need to build config.system.build.toplevel of your nixos configuration. But I actually don't see much advantage over nix-build for a single derivation because the speed advantage comes with multiple derivations.

You can copy this snippet to your flake: https://github.com/Mic92/dotfiles/blob/2a89b32984d8cb5f0655c284098054c432af08ca/flake.nix#L174 than nix-fast-build without arguments will build everything in your flake including nixos.


Make office and classroom links clearer

Students are confusing Office and Classroom meeting rooms

:-1:

Merged.


Documentation: React Wiki and related method

Description
I created the React version of from the Wiki https://github.com/collab-project/videojs-record/wiki/React
The saveAs method https://github.com/collab-project/videojs-record#save-data needs to have this.player() instead of the original player, full React line:
this.player().record().saveAs({'audio': 'my-video-file-name.webm'});

Additionally a console.log will return undefined unless the 'finished recording' log message is changed to:
console.log('finished recording: ', this.player().recordedData);

It could be helpful pointing this out in a separate section for people like me who are new to React.

@johnblakey I've used arrow functions in #270 so this.player can be used everywhere.


[cfid-45] Add github, twitter, linkedin, facebook login - Story Id: 35352675

Link: https://www.pivotaltracker.com/story/show/35352675
Labels:
Owners: Dave Syer
Estimate: 3.0

Add github, twitter, linkedin, facebook login.  Choose idp by selecting button or icon.

Link: https://www.pivotaltracker.com/n/projects/997278/stories/35352675/comments28136395

The hardest thing to do is correlate a UAA user account with a social provider.  None of them reliably provide both and email and a user-friendly id, and it is also likely that a user will wnat to associate multiple social accounts with his one cloudfoundry accouint.  There is no explicit slot in the SCIM schema for it, but we could use something like IM data, e.g.

...
"ims": [
    {
      "value": "$FGHFDX78",
      "type": "linkedin-id"
    },
    {
      "value": "joe.bloggs.9",
      "type": "facebook-id"
    },
    {
      "value": "joebloggs",
      "type": "github-id"
    },
    {
      "value": "joe_bloggs",
      "type": "twitter-id"
    }
  ],
  ...

Downside of using "ims" field is that we can't use it for real IM data later.
Probably we need to handle it internally (i.e. not expose through SCIM).  It is only really an authentication concern after all.
Comment Id: 28136395

Link: https://www.pivotaltracker.com/n/projects/997278/stories/35352675/comments28136397

I added SocialAuthenticationFilter which can immediately replace the old OpenIdAuthenticationFilter (until we have id tokens and OIDC proper).
Comment Id: 28136397

Link: https://www.pivotaltracker.com/n/projects/997278/stories/35352675/comments28136403

A similar situation came up in a call with emc today. They want some users to be redirected to a saml IdP, and other to user name/pwd, but no user should be able to use both. Should this be a general "acceptable authentication source" in the user database?
Comment Id: 28136403

Link: https://www.pivotaltracker.com/n/projects/997278/stories/35352675/comments28136401

I realised after I posted that comment that we actually don't need the social links to be part of the SCIM schema (maybe we could do that as well, but it's orthogonal).  For authentication we use UaaUserDatabase not ScimUserProvisioning (for good reasons since they are orthogonal), so it is there that we need the relationship and any logic required to match a user to a social account.
Comment Id: 28136401

Link: https://www.pivotaltracker.com/n/projects/997278/stories/35352675/comments28136399

Regarding the first comment, SCIM is extensible. Why not just add a new attribute similar to "ims" called something like linkedAccounts? We'll probably want other extensions as well, so we'd might as well start our own schema space.
Comment Id: 28136399

Link: https://www.pivotaltracker.com/n/projects/997278/stories/35352675/comments28136405

Re the EMC requirement: how can you redirect to a different authentication source until you know who the user is?  There has to be some form of authentication before the redirect?
Comment Id: 28136405

Link: https://www.pivotaltracker.com/n/projects/997278/stories/35352675/comments28136407

that's part of the issue. We could give a list of identity providers such as you suggest above. The problem is that after they've authenticated we can check their account and find out we don't accept that authentication source.
In practice, this situation may not be too bad. If we can accept something in the url path or query that tells us which authN source to use, then the users for a major area such as EMC access CF via a portal that preloads the url with the idp hint.
Comment Id: 28136407

Link: https://www.pivotaltracker.com/n/projects/997278/stories/35352675/comments28812523

Commit by Dave Syer
https://github.com/cfid/login-server/commit/5ce690ba5c78da97932fd1b54514e3e6656620a2
[cfid-45] Add social login page for usual suspects

Just authentication for now - no attempt is made to
correlate with existing CF accounts.  So if a user
has a social account that reveals an email address
and the email is not a valid CF account he can log
he can log in but won't be able to get tokens from
the UAA (in production).
UAA deployed with default profile (i.e. not in prod
or any BOSH environment) has autoadd enabled
by default so new user accounts will be created if
user authenticates at social and then gets a token.
Draft implementation as a separate page from main login
Support for google, github, facebook, twitter, linkedin
Default credentials are dsyer personal accounts
Google button works when deployed at localhost:8080/login
Others only work out of the box at socialauth.cloudfoundry.com

[#35352675] [cfid-45] Add saml, github, twitter, linkedin, facebook login -- how to choose idp?
Comment Id: 28812523

Link: https://www.pivotaltracker.com/n/projects/997278/stories/35352675/comments29208007

Commit by Dave Syer
https://github.com/cloudfoundry/uaa/commit/b02873b655de02ffceed38d7b2b34f484af57889
[cfid-45] Fix app sample for previous changes
[#35352675] Extract SocialUserDetailsSource so it can be used later
Change-Id: Ia5c8e0908a1ae170e6b2a90f7c8a1505bfe29096
Comment Id: 29208007

Link: https://www.pivotaltracker.com/n/projects/997278/stories/35352675/comments28813967

Commit by Dave Syer
https://github.com/cloudfoundry/uaa/commit/19be72bcbc00b96b0d15dea87aaf9b18c4370651
[cfid-45] Extract SocialUserDetailsSource so it can be used later
[#35352675] Add saml, github, twitter, linkedin, facebook login -- how to choose idp?
Change-Id: I0a1cf6c3254e72f4c82e839022a560a454040dab
Comment Id: 28813967

Link: https://www.pivotaltracker.com/n/projects/997278/stories/35352675/comments33787855
User: Shannon Coen

Is the work which has been done so far available in a dev env where I can try it out?
Comment Id: 33787855


Improve Storage/Management of Extensions/Extension Documentation

Currently, when extensions are declared, information about those extensions, handlers, and their relevant documentation is maintained in a series of global atoms. This isn't ideal and can cause confusion (see #10) where extensions can be duplicated if files are reloaded without properly clearing out the global atoms.
Ideally, I think we should try and remove this from global state. At the moment, I don't have a great solution to this problem and would love input from others :)

Maybe it could work like add-watch?  On atoms, refs, etc you associate a function with a particular reference.  It's not super neat but it would allow multiple bot instances with potentially different extensions.

@JasonKDarby I looked at the add-watch documentation and I guess I'm not immediately seeing how add-watch would facilitate multiple bot instances. Can you explain a bit more about the idea? I'd never heard of add-watch and it looks pretty useful!

Maybe we should just store extension and command related information in the same namespace they're declared in, and have a facility that can associate between these bits of data and a specific reference to a bot.
This way, we could have defextension and defcommand describe what an individual bot should do when queried with a defined command, and we'd use @JasonKDarby's idea of an add-watch-like facility to associate between the bot and the extension behavior: (add-extensions bot & extensions)
Below is an example of how I think the syntax of this might work out, used in a REPL-like setting.
(require '[discord.bot :as bot])
;; Bots are stored as refs using this create-bot facility
(def my-first-bot (bot/create-bot ...))
(def my-second-bot (bot/create-bot ...))
;; Command and Extension info is stored in place using these def-like facilities
(defcommand my-command ...)
(defextension my-extension ...)
;; Commands and Extensions are associated with their bots explicitly using this add-extensions facility
(bot/add-extensions my-first-bot my-command my-extension)
(bot/add-extensions my-second-bot my-extension)
;; Bots can be started independently from the extension adding and bot creation process.
(bot/start my-first-bot)
(bot/start my-second-bot)

defcommand and defextension would have to treat command and extension information like aggregate data though, because there isn't a great, super clean way to store the functions and docstrings all in one data structure, so given an extension name ext-name, we'd probably have to have a multimethod for calling the function, and a nested map structure for storing and navigating the docstrings, named ext-name-handler and ext-name-doc, respectively.


Updating maven liberty plugin to 1.1 release

The ci.maven project from WASdev released a new version of the plugin (1.0 -> 1.1). Consequently the current version in the pom.xml (1.1-SNAPSHOT) isn't working and it breaks the sample. This pull request will fix the project.

FYI, it's not quite released yet.

yeah, sorry, I realized I was using the staging repo, I've updated to 1.2-SNAPSHOT in the meantime.


don't make the guide disappear when typing

Problem Description:

This isn't a great experience. I don't think we need to do this everywhere, but at least on the guide where you're trying to type out what you see in the guide it's really annoying that it goes away.
Suggested Solution:
I think the best thing would be to implement this: https://github.com/FormidableLabs/react-live/issues/20
But after that if we could just do a debounce or try/catch somewhere to make it so we don't render the guide if there's a syntax error that'd be awesome.
Who wants this!? :smile:

I'd love to help 🤠

Awesome! Thanks! I look forward to seeing your PR :smile:

To place <StyledLiveError /> inside the <RightHandSide> will prevent the editor from jumping when errors come.
It may help a bit until react-live provides an extra option to completely resolve the original issue.

That sounds great! Could you make a PR for that @yuanchuan?

😄 https://github.com/kentcdodds/glamorous-website/pull/272


chore: add _total suffix to counter metrics

Closes https://github.com/paradigmxyz/reth/issues/8150

I couldn't find any Grafana dashboards to update


deploy pipeline-service customized SHA

Deploy Pipeline-service with a customized PR OWNER and PR SHA

/approve

/retest

/retest

/lgtm

/approve

@rhopp could you approve this PR?

/approve

/lgtm


Insert   at UseFormMethods section for visibility.

The section for UseFormMethods,  there is no space  between of and useFormContext. So, I insert   explicitly.  https://react-hook-form.com/ts/

ty 🙏


Add Makeability Lab as icon in sidebar and footer

Footer too:

Added in footer:

Still think it could be the icon for the links to the lab and handbook:

Finished this during a faculty meeting! Yay!
It's a bit kludgey so hope it works!


Any thoughts on how to use this great module with custom views which are derived from UIKit views

I am using this library https://github.com/CosmicMind/Material, and want to have these components integrated with animatable feature in Interface Builder. I think moving forward I also want to have such kind of thing for any other great UI libraries. Do you have any ideas on how to get this done in the generic way.

@tuyencoder I just had a quick look at https://github.com/CosmicMind/Material, it has its own UI elements like MaterialButton, to use both of them, you need to either modify MaterialButton to conform to Animatable or create a subclass of MaterialButton to conform to Animatable.
Material design elements is in the backlog, https://github.com/JakeLin/IBAnimatable/issues/16 IBAnimatable protocol extentions should be easy to create Material Design elements. One goal of IBAnimatable is to easily extend to create new elements with custom styles.

Thanks JakeLin. I think while we are waiting material design components built into IBAnimatable, we should have documentation on how to integrate IBAnimatable with other view frameworks. Of course, what you answered is roughly enough for now.

@tuyencoder can I ask you a favour to share what you find to put them together by following my comments above? please let me know if you have any questions. Thanks.

Please see #174 , close this issue now.
@tuyencoder , please let me know if you have any questions, thanks.


Add documentation for pubsub/jetstream tls configuration

Note: maybe there needs to be a new issue template (or reword an existing template) for simple updates?

What content needs to be created or modified?
Document new fields for TLS Client Authentication.
Describe the solution you'd like
N/A
Where should the new material be placed?
Existing
The associated pull request from dapr/dapr, dapr/components-contrib, or other Dapr code repos
https://github.com/dapr/components-contrib/pull/1924
Additional context
N/A

Closing issue in favor of https://github.com/dapr/docs/issues/2872


Error handling using new Exceptions

This is more of a question rather than a bug report. At this point I don't have real devices with me, so please forgive me asking something I could figure out in couple of months - I just like to prepare the migration to your latest lib release.
In the current implementation of Chroma Feedback I use this to detect lights from not being connected.
from busylight.lights import USBLightIOError, USBLightNotFound
from busylight.lights.agile_innovative import BlinkStick as api

try:
	api.first_light().release()
except (USBLightIOError, USBLightNotFound):
	logger.error(wording.get('connection_not_found').format('agile_innovative_blinkstick'))
	sys.exit()

I saw you changed the exception naming and introduced a new method?
from busylight.lights import USBLightIOError, USBLightNotFound
from busylight.lights.agile_innovative import BlinkStick as api

try:
	api.first_light().is_pluggedin()
except (LightUnavailable, LightNotFound):
	logger.error(wording.get('connection_not_found').format('agile_innovative_blinkstick'))
	sys.exit()

Can I use this approach across all devices?

Yes, the method is_pluggedin is designed to work across all Light subclasses. If you find an instance where it doesn't, that's a bug.

Thanks for the quick response. I still wonder if release() over is_pluggedin() is the better option to insure a connected and accessible / non busy device? Does the one send an operation and the other just return a properly outdated state?
According to the exceptions: I would expect a singular exception naming for first_light() and plural exception naming for all_lights() but the is not the case as all_lights() does not raise any exception. After quick research I figured out that LightNotFound are part of the API only. It's a bit confusing to me... :)

Since Light.all_lights() returns a list it follows that an empty list signifies no lights were found and no reason to raise an exception. The caller will always get the expected object instance returned to them, a list, but it will not always be populated with Light subclasses.  The Light.first_light() class method only returns a Light subclass or raises an exception if no lights were found.  I suppose I choose the plural NoLightsFound since I know the implementation will check for the existence of multiple different kinds of lights before giving up (depending of course where in the Light subclass hierarchy first_light is called from).
WRT to is_plugged, it is an abstract property method that is implemented in the HIDLight and SerialLight subclasses since the method for determining whether a light is available vary between to the two different I/O strategies.  I don't understand why release would be favored since it only performs a close on the underlying serial or HID device. In most cases, users of Light subclasses should never need to use acquire and release methods. On some operating systems, for instance HID devices on MacOS, if the device is unplugged it is possible that it will not be assigned the same OS-specific path when plugged back in. Plug/unplug events should generally result in disposing of the current Light subclass instance and getting a new one when the light is available again.
Creating a light with exclusive=True will result in the underlying HID or serial device being acquired, IO performed for the requested operation, and then released. This approach introduces latency between initiating an operation and the operation completing, but it allows the lights to be accessed via another process which may be desired in some cases. That design point is the driver behind the acquire and release methods in this implementation.

Wow, thanks for that deep dive into the HID universe... I will close this issue for now.


added default location to location picker

The helper error is the only problem, but adding it causes a loop. it may need to be updated a different way.


Wall Fix

Closes #129

@BrandonPacewic Everything is working fine
Approved

I'm getting ready to merge and updating the change log - please @me if any other changes are pushed.


better progress reporting while network is being generated

Description of new feature

Let the user know how long they have to wait to get the result.
A faked progress bar?
Just say, 'under a 60 seconds'.
Show a notification?

Downside: permission

Motivation for new feature

I have no idea how long the app should take.
It takes longer than a few seconds, so I leave.

A faked progress bar is not a terrible idea. Netflix does this. I've noticed many times when Netflix is buffering the percentage slowly increases, until it gets to some value, and then pauses, even though the video never loads. This keeps you waiting thinking its going to actually work!

Faked progress bars work really well when you overshoot the estimated duration a bit.  Aim for the worst case duration.  The last bit of progress might go at a faster speed than the first part, since you’ve actually got the query response before the bar has finished.  That’s not as smooth an accurate duration estimate, but it can feel like a bonus to the user:  It went faster than I expected for the last bit.  Bonus!
The thing to try to avoid with a progress bar is undershooting the duration.  It’s really annoying when the progress bar stops moving.  Is it frozen?  Is it broken?  I feel ripped off.  Maybe I’ll leave…
Do we already have a way to track how long an end-to-end query takes?  Maybe something like a custom google analytics metric?  We could make an educated guess for now and then refine the estimate based on what the real worst case is in practice in the long term.

Just adding one note re. prioritisation:  A progress bar is nice to have, but there’s a lot of other, important things to do.  Even just text like ‘your results will be ready in under 60 seconds’ would be enough to start.

If we're going with the simple text approach for now (i.e. the spinner has text beside it that says 'Your result will be ready in under a minute'), then we'll need a new issue for tracking more sophisticated approaches for future (e.g. a progress bar).

Add stats for input proxy measures / stats (input file size) and query duration in MongoDB for the network. Estimation later
Text 'takes about a minute' and/or fake progress bar with hard-coded upper-limit time estimate

Do we currently state the ~1min query response time in the UI now?


Error messages should place most relevant information first.

Here's an actual example of an error message that can go wrong in our library when mispelling a property when creating an object literal:
[ts]
Type '{ containers: { nginx: { image: string; memory: number; portMappings: NetworkListener[]; enviroment: number; }; }; }' is not assignable to type 'FargateTaskDefinitionArgs'.
  Types of property 'containers' are incompatible.
    Type '{ nginx: { image: string; memory: number; portMappings: NetworkListener[]; enviroment: number; }; }' is not assignable to type 'Record<string, Container>'.
      Property 'nginx' is incompatible with index signature.
        Type '{ image: string; memory: number; portMappings: NetworkListener[]; enviroment: number; }' is not assignable to type 'Container'.
          Object literal may only specify known properties, but 'enviroment' does not exist in
          type 'Container'. Did you mean to write 'environment'? [2322]

- fargateService.d.ts(169, 5): The expected type comes from property 'taskDefinitionArgs'
  which is declared here on type 'FargateServiceArgs'

The funny thing here is that the final parts of the error message are superb. Namely:
- Object literal may only specify known properties, but 'enviroment' does not exist in
  type 'Container'. Did you mean to write 'environment'? [2322]

- fargateService.d.ts(169, 5): The expected type comes from property 'taskDefinitionArgs'
  which is declared here on type 'FargateServiceArgs'

However, the actual output is quite cluttered and hard to glean the information from.  This is esp. true in an ide setting where one sees something like this:

This view is particularly problematic due to the wrapping and wall-of-goop nature of this type of error.
My suggestion would be to invert the information being provided by errors.  Give the most specific and directly impactful information first (i.e. Object literal may only specify known properties, but 'enviroment' does not exist in type 'Container'. Did you mean to write 'environment'?), and then follow that up with all the extra details that can be used to dive deeper into things when that isn't clear enough.

Tagging @DanielRosenwasser for thoughts here.  I'm curious if there is a specific reason why we do things this way?  It seems like a bunch of effort was put into extracting out some really good information to tell the user.  But that good information is buried after the really crufty info which, while occasionally useful, seems strange to place front and center.

Sometimes inside-out is the best error, sometimes outside-in is the best error. It depends on whether your error is because the type "isn't even close" (i.e. you have the completely wrong kind of object), or if there's something "subtly wrong" (i.e. you are off by one property spelling or type).
Consider this code:
// Library code
type ReturnTypeOf<T> = T extends () => infer U ? U : never;
class Alpha<T> {
    thing: T;
    getBar() {
        return {
            doSomething() {
                return {
                    another: null as ReturnTypeOf<T>
                }
            }
        }
    }
}

class Beta<T> {
    thing: T;
    getBar() {
        return {
            doSomething() {
                return {
                    another: null as Array<ReturnTypeOf<T>>
                }
            }
        }
    }
}

// User code
const a: Alpha<() => string> = new Beta<() => string>();

The error message here is:
sample.ts:28:7 - error TS2322: Type 'Beta<() => string>' is not assignable to type 'Alpha<() => string>'.
  Types of property 'getBar' are incompatible.
    Type '() => { doSomething(): { another: string[]; }; }' is not assignable to type '() => { doSomething(): { another: string; }; }'.
      Type '{ doSomething(): { another: string[]; }; }' is not assignable to type '{ doSomething(): { another: string; }; }'.
        Types of property 'doSomething' are incompatible.
          Type '() => { another: string[]; }' is not assignable to type '() => { another: string; }'.
            Type '{ another: string[]; }' is not assignable to type '{ another: string; }'.
              Types of property 'another' are incompatible.
                Type 'string[]' is not assignable to type 'string'.

The last 7 lines of that error message are not really relevant (it's not really the error the developer is making, just an explanation of why the assignment is an error), and arguably only the first line is needed for the user to know what's gone wrong.

Well, for a variable, it would be very confusing if you dove deep into the structure of the type and never explained how the mismatch occurred.
declare var x: { a: { b: { c: { d: number } } } };
declare var y: { a: { b: { c: { d: string } } } };

x = y;

It'd be weird to get an error like
Type 'string' is not assignable to type 'number'.

even if it looks less scary than
Type '{ a: { b: { c: { d: string; }; }; }; }' is not assignable to type '{ a: { b: { c: { d: number; }; }; }; }'.
  Types of property 'a' are incompatible.
    Type '{ b: { c: { d: string; }; }; }' is not assignable to type '{ b: { c: { d: number; }; }; }'.
      Types of property 'b' are incompatible.
        Type '{ c: { d: string; }; }' is not assignable to type '{ c: { d: number; }; }'.
          Types of property 'c' are incompatible.
            Type '{ d: string; }' is not assignable to type '{ d: number; }'.
              Types of property 'd' are incompatible.
                Type 'string' is not assignable to type 'number'.

But when we already try to do this when we have the syntax available, we're able to error exactly on the appropriate declaration.
declare var x: { a: { b: { c: { d: number } } } };
x = { a: { b: { c: { d: "" } } } };
//                   ~ Error: Type 'string' is not assignable to type 'number'.

It's only on excess property checks (like here) that we don't currently, and that's because we don't try to do it as part of the syntactic walk that @weswigham implemented to elaborate on the most specific error location.

I suppose we could just set a bit to say "don't try to elaborate any further" when excess property checks are issued.

Note: i'm not proposing stripping out the "path" part of the error.  Just that it feels as if the innermost message is sometimes far more appropriate on the outside level.  I mean, just look at that useless vscode message :)

How'd you get in a state where the excess property check wasn't the top-level error? Having a hard time reproducing the OP

The error message here is:

sample.ts:26:7 - error TS2322: Type 'Beta<boolean>' is not assignable to type 'Alpha<string>'.

Note: i would say that hte error here is good because the "type not assignable" message is non-complex.  And, by 'non-complex' i mean: there is a good named type that can be presented to the user.  In this case, saying "Foo is not assignable to Bar" is nice and clear.  And the path then leads to an explanation why.  When the message is:
'{ containers: { nginx: { image: string; memory: number; portMappings: NetworkListener[]; enviroment: number; }; }; }' is not assignable to type 'FargateTaskDefinitionArgs'
(or even worse at times).
It seems like this may be about having a weighed strategy depending on what sort of message you'd print.

How'd you get in a state where the excess property check wasn't the top-level error? Having a hard time reproducing the OP

let x: { a: string, b: number } = {
    a: "",
    b: 10,
    c: 20
}

To be clear, the span is exact (we literally override the original span) but the error is the last one.

It'd be weird to get an error like

Type 'string' is not assignable to type 'number'.

It could be:
Deeply nested assignment of 'd: string' is not assignable to `d: number`
// now print hte long path
       Type 'string' is not assignable to type 'number'.

But it's not really nested like the OP shows
let x: { q: { m: { t: { a: string, b: number } } } } = {
    q: {
        m: {
            t: {
                a: "",
                b: 10,
                c: 20
            }
        }
    }
};

sample.ts:4:5 - error TS2322: Type '{ a: string; b: number; c: number; }' is not assignable to type '{ a: string; b: number; }'.
  Object literal may only specify known properties, and 'c' does not exist in type '{ a: string; b: number; }'.

4     c: 20
      ~~~~~

  sample.ts:1:20
    1 let x: { q: { m: { t:  { a: string, b: number } } } }= { q: { m: { t: {
                         ~
    The expected type comes from property 't' which is declared here on type '{ t: { a: string; b: number; }; }'

@RyanCavanaugh Are you asking for a repro for the OP i posted?

I just wanted a multi-level error message originating in an excess property check

Also Cyrus what version are you on?

package.json says "typescript": "^3.0.0".  But i'm using: vscode Version: 1.30.2.  I'm not sure what that means at the end of the day.

In the lower-right corner you should see a version number:

... I should just walk over to Cyrus's office?

So this isn't a full repro.  But this is basically what we have;
export class FargateService {
    constructor(name: string, args: FargateServiceArgs) {
}

export interface FargateServiceArgs {
    taskDefinitionArgs?: FargateTaskDefinitionArgs;
}

export interface FargateTaskDefinitionArgs {
    container?: Container;
    containers?: Record<string, Container>;
}

export interface Container {
    // Properties from aws.ecs.ContainerDefinition
    image?: pulumi.Input<string>;
    memory?: pulumi.Input<number>;
    environment?: pulumi.Input<KeyValuePair[]>;
    // ...
}

// And then we're constructing like so
const nginx = new awsx.ecs.FargateService("nginx", {
    taskDefinitionArgs: {
        containers: {
            nginx: {
                image: "nginx",
                memory: 128,
                enviroment: 128,
            },
        },
    },
});

// Unfortunate, Input is a pretty complex type on it's own... but maybe this is enough to get by?

Check out #29760.

Would love to know whether https://github.com/microsoft/TypeScript/pull/33473 mostly fixes the issue @CyrusNajmabadi @lukehoban.

My question is why the error messages in TypeScript can not be inverted... so that if value is not compatible with value  is not clear enough I can read down the list instead of being scared to death...

As noted above, if we inverted errors, then the other ~half of the time, you'd have the same problem as you have now. The "correct" end of the error depends on the nature of the problem, which the computer doesn't really have a way of knowing since it doesn't know what your intent was.

As noted above, if we inverted errors, then the other ~half of the time, you'd have the same problem as you have now.

Can it be a flag (in the IDE settings) I am using the ubiquitous VSCode


Action should not be using a deprecated set-output method

Wen running the newest version of the action, there is a Warning stating the action is using a  the deprecated set-output method.
Sending webhook request to ***/deploy-api
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using
Environment Files. For more information see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Received status code: 200

My config
    deploy-api:
        name: Redeploy API
        runs-on: ubuntu-latest
        needs: [build-and-push]
        steps:
            - name: Deploy docker container webhook
              uses: actions/setup-node@v3
              with:
                  node-version: "16"
            - name: Webhook call
              uses: joelwmale/webhook-action@master
              with:
                  url: ${{ secrets.DEPLOY_WEBHOOK_URL }}/deploy-api
                  headers: '{"secret": "${{ secrets.WEBHOOK_SECRET }}"}'

Source: https://github.com/jkulak/smartplaylist-backend/actions/runs/3347471589/jobs/5545500696#step:3:7

openshift-webhook:
    name: OpenShift webhook for image builder
    needs: [build-node-versions, njsscan]
    runs-on: ubuntu-latest

    steps:
      - uses: joelwmale/webhook-action@master
        with:
          url: ${{ secrets.WEBHOOK_URL }}
          body: '{"event": "${{ github.event_name }}","uri": "${{ github.repository }}","ref": "${{ github.ref }}","commit": "${{ github.sha }}"}'

Bit simpler webhook trigger for OpenShift image build

I guess it happens because of the checkout version in the package json file.
As far as I can see the develop branch updated with bot to the latest version. Try to use this branch:

I'll be pushing a new version of the action today!

@joelwmale it's a great news! 🥳

But it didn't fix the issue, probably due to "@actions/core": "^1.10.0" being set as a caret dependency. If you look in the dist folder, you'll see that it still uses the old version:
https://github.com/joelwmale/webhook-action/blob/2c43ebbef8b9c5e5ea27cd65dfdeac58f90e7e29/dist/index.js#L334-L344


a little bug when folding code block

VSCode Version: Code 1.15.1 (41abd21afdf7424c89319ee7cb0445cc6f376959, 2017-08-16T18:05:38.342Z)
OS Version: Windows_NT ia32 10.0.15063
Extensions:

Extension
Author (truncated)
Version

path-intellisense
chr
1.4.2

regex
chr
0.1.0

vscode-html-css
ecm
0.1.7

vscode-great-icons
emm
2.1.14

vsc-material-theme
Equ
1.0.2

json-tools
eri
1.0.2

php-debug
fel
1.11.1

php-intellisense
fel
1.5.0

auto-rename-tag
for
0.0.14

mdhelper
jos
0.0.11

debugger-for-chrome
msj
3.1.8

material-icon-theme
PKi
2.1.0

vscode-css-peek
pra
1.3.1

markdown-preview-enhanced
shd
0.2.5

html5-boilerplate
sid
1.0.1

quokka-vscode
Wal
1.0.50

wallaby-vscode
Wal
1.0.56

html-css-class-completion
Zig
1.8.0

(3 theme extensions excluded)

Steps to Reproduce:
1.fold a code block
gif here

Reproduces without extensions: Yes

another bug is also obvious

@deepkolos Sorry, I can't see the issue. Can you paste also the code snippet? Or make an animated gif that also shows the folding markers?

For the second, issue, can you file a separate bug? Again with code sample and a description of the bug?

@aeschli done update the description and new another issue

Please paste the code snippet...

Closing due to lack of information.


[Toolbar] toolbar-title overflow:  Set width in the example

This references issue: https://github.com/callemall/material-ui/issues/3192
Previously submitted PR: https://github.com/callemall/material-ui/pull/3250

Since the issue still persists even after the last PR was merged, I decided to change the fix a bit. All other css changes in toolbar-title.jsx remains the same except for the width attribute.

The earlier logic of having the width based on the number of characters within the component jsx code seemed dodgy. I decided to move the width attribute as a part of the inline style in the example code instead.

This makes more sense to me since the use of toolbar might change based on the use-case and so does the title width which is dependent on the number of elements being present in a toolbar implementation.

I have included a value of width:150px based on the implementation in the example page but I understand that it is still a magic constant and my suggestion would be to add a note in the docs mentioning the same like its done for the popover ghost touch issue , as it is more of an implementation issue.

I could add the note if needed. @alitaheri @newoga need you opinion about it.

As you both know I have started work on redesign of the Toolbar component. This can work as a temporary fix till then.

P.S: I created a new branch and proceeded the issue in a fresh manner hence the new branch.

Screenshots of the implementation:

The earlier logic of having the width based on the number of characters within the component jsx code seemed dodgy.

Giving users the power to fix it seems better :+1:. Can we remove the magic width value now?

@oliviertassinari : Which magic width are you referring to?  I have removed it from toolbar-title.jsx which had a width attribute as per the previous fix.
The width value of 150px is in the docs example page, which is to show the user how to implement it in their use-cases.

Which magic width are you referring to?

Sorry I was confused not seeing this line removed https://github.com/callemall/material-ui/pull/3250/files#diff-6ac27b5e67882578a46d38f690fd414bR20.
Could you rebase :+1:?

Could you rebase :+1:?

@oliviertassinari : Done.


Suggestion: Feature Filter projects

Hi, is it possible for you  add search box at the top of main screen to filter projects and groups by keywords?

yeah, sure. my personal dashboard also is getting kind of full and i end up getting lost. a search would be nice.


Add Sentry context

What
Add extra data to be reported to Sentry when a contract fails.
Link to story
Checklist
Before you ask people to review this PR:

[x] Tests and linters should be passing
[x] Github should not be reporting conflicts; you should have recently run git rebase master.
[x] Avoid mixing whitespace changes with code changes in the same commit. These make diffs harder to read and conflicts more likely.
[x] You should have looked at the diff against master and ensured that nothing unexpected is included in your changes.
[x] You should have checked that the commit messages say why the change was made.

Is it only when a contract fails that we tend to see Sentry logs?

All exceptions get reported to Sentry. Contract failures are not exceptions, so this PR makes sure we report these occurrences in Sentry even if they aren't exceptions.

Is it only when a contract fails that we tend to see Sentry logs?

All exceptions get reported to Sentry. Contract failures are not exceptions, so this PR makes sure we report these occurrences in Sentry even if they aren't exceptions.

Makes sense, thank you


Add shell script for downloading JAR dependencies

ping @AbletonDevTools/gotham-city

I hate to be the person to ask for a rewrite but, why is this a shell script? It seems like the script is doing complicated enough parsing that we should make it a small Python script that calls os.system. It might be possible to do something with subprocess that would be 'cleaner,' but I believe you would have to work harder to get nice TTY output.

Please don't use os.system. Use requests for downloading, and tarfile and gzip for extracting.

@AbletonDevTools/gotham-city I've rewritten this change and now the fetch_jars script is in Python (which is admittedly kinda nice, since the output from requests is better than wget). Mind taking another look?

@ala-ableton Whoops, I just noticed that I didn't use the tarfile module as you'd recommended. Fixup coming.

@nre-ableton no problem. Please also reword the commit message :wink:

@ala-ableton Done! Also rebased/squashed.

@mst-ableton ah, sorry, I misread the diff. I was on my phone at the time. 😅

@ala-ableton thanks for the review, I think I’ve addressed your comments. I’ve also rebased/squashed @mst-ableton‘s changes and force pushed. Mind taking another look?

@nre-ableton once rebased, LGTM :+1:

@rco-ableton Any last opinions on this PR before I merge?


add possibility to replace with new line

Hi, I'm on Ubuntu 14.04 using Release 1.3 experimental build 1.3.0-16022 is it possible to search for a string and replace it with line return, like this,
original:
azerty, qwerty

expected result:
azerty,
qwerty

so search for ', ' and replace with ',\n' or ',\r' do it this will result in azerty,\nqwerty or azerty,\rqwerty
also can write multi-line replace string or search string in the search boxes.

@yahyaKacem No. Its not possible currently to include newline in replace string. Although you can use newline in search. Information is given here We have feature backlog for this. Please upvote here to help in picking this feature. Similar to issue #8093 . Closing this


How To add user widget in navbar ?

Hello, I have the following code in my navbar:
...
const { user } = useAuth();
...
{!user ? (
            <Button href="/login" className="overflow-hidden">
              <Icons.user />
              Login
            </Button>
          ) : (
            <Button href="/account" className="overflow-hidden">
              {user.photoURL ? (
                <>

                    <Image
                      priority
                      width={48}
                      height={48}
                      src={user.photoURL}
                      alt="username"
                    />

                  {user.displayName}
                </>
              ) : user.displayName}
            </Button>
          )}

If I delete the cookies, I'm still logged in, how do I work around this ?

I guess I need to logout the user if cookies go missing or the token is no longer valid. How would I do that ?

Hey @rgbskills,
Your navbar component looks right. The problem your having is inconsistency between cookies and web client firebase library. Removing cookies is not enough, you also need to sign out using client firebase library as in starter example:
https://github.com/awinogrodzki/next-firebase-auth-edge/blob/main/examples/next13-typescript-starter/app/profile/UserProfile/UserProfile.tsx#L27-L35
Official firebase client library stores tokens using IndexedDB and possibly falls back to LocalStorage on older devices.  You can notice that when you open dev tools after logging in:

What I recommend to do in such cases is using Clear site data in dev tools to avoid state inconsistencies:

Let me know if that helps. Cheers!

hey @awinogrodzki
I'm using the same code, I must be doing something wrong then, here is the file where I have the logout button.
https://github.com/rgbskills/undercover/blob/master/src/app/account/Menu.tsx

Hey @rgbskills,
I have tested your code and I have no issues with the logout either by clicking on logout button, or deleting site data. Could you describe what exactly does not work as you would expect?

I will close the issue now due to lack of reproduction on my site. If you still face the issue, feel free to comment and we'll reopen. Cheers 🍻


Makefile is missing an install target

That should be configurable, ideally, to define where to put the binary, if it should install Qt, POCO, or other libraries somewhere, etc.

Fixed with move to CMake


Add option to not read golangci-lint config yaml

Why?
I would like to be able to use a selection of linters only. But the current setup does not allow this, as it automatically pulls in the golangcilint.yml config. This config takes precedence over CLI args.
I'd like to be able to do this:
sggolangcilint.Run(ctx, "--no-config", "--enable=gofumpt,goimports,gci", "--fix")

...which should correspond to this in the shell:
$ golangci-lint run --no-config --enable=gofumpt,goimports,gci --fix

What?
Add ability to read --no-config (this is an actual golangci-lint commandline option, but cannot be combined with --config).
$ golangci-lint run --help | grep config
  -c, --config PATH                    Read config from file path PATH
      --no-config                      Don't read config file

Notes
The only caveat I can come to think of is we have to define certain configs in both yaml and in Go, such as gofumpt's extra-rules (specified in yaml here).

@fredrikaverpil What about overriding the default config with your own? That should allow you to achieve the same result no?

@fredrikaverpil What about overriding the default config with your own? That should allow you to achieve the same result no?

Yeah, something like that is likely required/desired, because I cannot specify linter options on the commandline (see here).


Implement Chalk::Config#reload.

Add the ability to reload a specified configuration file.
This is useful for applications that need to pick up configuration from
an external source (e.g. puppet) and want to be able to gracefully
reload.
Add an interface to reload a single file, instead of everything, since
supporting targetted reload seems much saner than potentially having all
of your runtime configuration change out from under you on disk, but I'm
open to discussion on this point.

r? @franklinhu
cc @mcfunley since this may be relevant to your feature-flag work?

Great, I should be able to use this. Thanks, lgtm

merging on @mcfunley's lgtm

One nit, but otherwise lgtm


Add ts-node dev dependency to repo to fix running it locally

Checklist

[ ] I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why
When executing bin/run on main I see the following:

How
It seems like we are depending on ts-node installed transitively via eslint-plugin-graphql:
yarn why ts-node
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "ts-node"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "_project_#eas-cli#eslint-plugin-graphql#graphql-config#@endemolshinegroup#cosmiconfig-typescript-loader" depends on it
   - Hoisted from "_project_#eas-cli#eslint-plugin-graphql#graphql-config#@endemolshinegroup#cosmiconfig-typescript-loader#ts-node"
info Disk size without dependencies: "1.84MB"
info Disk size with unique dependencies: "3.25MB"
info Disk size with transitive dependencies: "4.05MB"
info Number of shared dependencies: 7
✨  Done in 0.30s.

This PR adds it as an explicit dev dependency to the repo, and uses a known working version (the latest).
Test Plan
Pull the PR, run yarn, then run bin/run. It should work.

/changelog-entry chore Add ts-node dev dependency to fix bin/run script

It looks like this also fixes an issue where bin/run -> ../packages/eas-cli/bin/dev was using typescript version from project where it was called. I usually used packages/eas-cli/bin/run + yarn watch for development to avoid that issue.

Closing in favor of https://github.com/expo/eas-cli/pull/1262