Speed up the failure of tapable elements to appear on the page

The timeout is just in case none of [the tapable elements] are found. We don't want to wait for them for forever.

That was my question, if none of them appear, we just wait for the timeout, which is a little silly IMO, especially for tests with longer timeouts.
This stackoverflow has some code that we should consider using: https://stackoverflow.com/questions/52497252/puppeteer-wait-until-page-is-completely-loaded.
Originally posted by @BryceStevenWilley in https://github.com/SuffolkLITLab/ALKiln/pull/602#discussion_r959993336
Reply:

Always good to have a new eye on things! When I looked, I only remember finding stuff about networidle being unreliable. This looks like an interesting solution. We should back it up with the timeout as well, though, just in case it keeps changing for some reason. See the comment below the answer for an example.

A partial implementation of this is when searching for continue buttons, as in https://github.com/SuffolkLITLab/ALKiln/pull/620. We know when some of the continue buttons are present, they all should be. So if we iterate through them and don't see a continue button, we can stop immediately and say so.


Allow configuring trust certificate for LDAP authenticator

I agree that unit tests would be nice, but that would require setting up an in-process LDAP server (like Apache Directory) along with SSL, which is a lot of work and should be a separate task.


Add containerized distribution to allow users to experience the full version of libro using a container.

Duplicate with #311 .


Hangs when loading file

Running Ruby 2.2.3-p173 and Streamio-ffmpeg 3.0.2.
It hangs on this: FFMPEG::Movie.new("Video.mov")
I've traced it down to something with the Open3.popen3 in movie.rb. After finding a suggestion in  https://bugs.ruby-lang.org/issues/9082 to use Open3.capture3 it's working.
I replaced this:
  Open3.popen3(*command) do |stdin, stdout, stderr|
    std_output = stdout.read unless stdout.nil?
    std_error = stderr.read unless stderr.nil?
  end

With:
std_output, std_error, status = Open3.capture3(*command)

Not sure if that's the best solution, but so far it works for me.

@seanthingee I can confirm that this solved it for me well. Do you know of any disadvantages of this approach? Otherwise I think this is worthy a PR based on the comments in that bug description.

@kvaggelakos Sorry, I'm not familiar enough with this area of unix/ruby to know if there are disadvantages.

The Open3.capture3 method is documented here: https://www.rubydoc.info/stdlib/open3/Open3.capture3
Its implementation is very simple and isn't subject to the deadlock issues the usage of popen3 in this project has.
The only disadvantage I can think of is that Open3.capture3 reads stdout and stderr in threads, thus adding some overhead.


select!{} documentation has truncated paragraph

The second paragraph of the select!{} docs reads,

If an expression which yields a Future is passed to select! (e.g. an async fn call) instead of a Future by name the Unpin requirement is relaxed, since the macro will pin the resulting Future on the stack. However the Future returned by the expression must still implement FusedFuture. This difference is presented

(emphasis mine)
It is not clear how the difference is presented. It seems that this paragraph has been accidentally truncated.

@Matthias247: This seems added in #1874. Do you remember what you were trying to write here? If not, I think it's okay to just delete it.

This was probably just my brain which sometimes shows data loss when doing many context switches while writing long docs 😀. Those have to be better reviewed.
Feel free to delete the incomplete sentence. I don't know anymore what it was about.


XP Drop colour not changing while using godsword and piety

Mine is usually set to red when using a melee weapon and piety. Works for other weapons but not godswords.

I can confirm this does not work for godswords. Bug can also be reproduced with the Abyssal Bludgeon.
Reproduction Steps:

Equip Abyssal Bludgeon or Bandos Godsword
Turn on Piety
Attack an NPC

Expected: XP drop is colored based on plugin settings for "XP drop color melee".
Observed: XP drop is colored based on default drop color, "XP drop color"

Same issue also exists with Keris Partisan of Breaching.

Hopefully fixed with the merging of https://github.com/runelite/plugin-hub/pull/5733

Just tested again and doesn't seem to be fixed. Tested with SGS and BGS

I am also still seeing this bug with the Keris Partisan of Breaching


Removed unused property 'pending_resize' from Control

See https://github.com/godotengine/godot/issues/16863#issuecomment-727567656

Thanks!


Clang AST Call parser adding duplicates

The clang call parser seems to add duplicate calls when they're detected.
As a quick fix a cleanup() method has been added, but it's extremely hacky, and adding duplicates would make the program extremely inefficient when ran over large codebases.

💡: One thing that might help using saving functions and calls directly as a Boost Graph. This will avoid duplicates and some unnecessary loops.


Response card is not showing when chaining rule is added.

Describe the bug
When I am adding chaining rule in the Intent, Response Card is not displaying. It only shows Answer section and then displays next intent.
To Reproduce
Steps to reproduce the behavior.
Expected behavior
When the user asks question, bot should display Answer, then response card, then implement chaining rule(move to next intent).
Please complete the following information about the solution:
5.5.0
To get the version of the solution, you can look at the description of the created CloudFormation stack. For example, "(SO0189) QnABot [...] v0.0.1".
Region: e.g. us-east-1
Was the solution modified from the version published on this repository? Yes
If the answer to the previous question was yes, are the changes available on GitHub? No
Have you checked your service quotas for the services this solution uses?
Were there any errors in the CloudWatch Logs? No
Screenshots

1.Before adding Chaining rule

2.After adding chaining rule
Additional context
Add any other context about the problem here.

Hi @preethy-1
This does not give us enough information to help. Can you please use the bug  template to submit your issue - see https://github.com/aws-solutions/qnabot-on-aws/blob/main/.github/ISSUE_TEMPLATE/bug_report.md or use the new issue button in the github webpage

Updated the bug.

I'm attaching an export from a qnabot with three questions that demonstrate chaining to a QID that has a response card with image that works properly. Key notes are that the response card must have a title to work properly. Hope this example helps. Could you export your questions that have the chaining problem and I can take a quick look at them?
test_chain_to_response_card_qna.json

@bobpskier Thanks for your response. I am attaching the export that is what I am looking for.
test_chain_to_response_card_qna.json

@preethy-1 Attached is a qna json file with a response card in AnythingElse that has an image and buttons. It works correctly for me. See screenshot below. Note that only one response card will be used. If the qid which chains to AnythingElse has a response card, it will be replaced with the response card from AnythingElse once chaining completes. Multiple response cards are not merged together. In the case where the AnythingElse does not have a response card, the original response card from the first qid will be used.

test_response_card_working_with_image_and_buttons.qna.json


Use "poolData" instead of "namespace" in fftokens

Depends on:
https://github.com/hyperledger/firefly-tokens-erc1155/pull/84
https://github.com/hyperledger/firefly-tokens-erc20-erc721/pull/70

Codecov Report

Merging #913 (9394999) into main (e78a05c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head 9394999 differs from pull request most recent head 245296d. Consider uploading reports for the commit 245296d to get more accurate results

@@           Coverage Diff           @@
##             main     #913   +/-   ##
=======================================
  Coverage   99.82%   99.83%
=======================================
  Files         299      299
  Lines       19527    19487   -40
=======================================
- Hits        19492    19454   -38
+ Misses         31       30    -1
+ Partials        4        3    -1

Impacted Files
Coverage Δ

internal/events/token_pool_created.go
100.00% <100.00%> (ø)

internal/events/tokens_approved.go
100.00% <100.00%> (ø)

internal/events/tokens_transferred.go
100.00% <100.00%> (ø)

internal/orchestrator/orchestrator.go
100.00% <100.00%> (ø)

internal/tokens/fftokens/fftokens.go
100.00% <100.00%> (+0.42%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us.


IHttpInterceptor and Authorization header

Hi to all,
using IHttpInterceptor is it possible to add an Authorization header? Where ?
Thanks.

Yup, you do it in the onRequest method, you can access the headers there and include it.

onRequest(requestOptions: RequestOptionsArgs): RequestOptionsArgs {     requestOptions.headers = new Headers({ 'Authorization': 'Bearer ' + mytoken });     return requestOptions; }
Perfect, thanks!

Closing this but setting as faq for future questions


freebsd has 2 zip packages and needs a -$(MODEL) suffix

also use 2.x instead of 2015 url

Auto-merge toggled on

LGTM.


MWPW-147046

Resolves : MWPW-147046
@peller @kbenelli-adobe do we need to a value for exhLimitCookieMap for chat-pdf.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.01%. Comparing base (732f5fd) to head (32f6096).
Report is 7 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #644      +/-   ##
==========================================
+ Coverage   97.99%   98.01%   +0.02%
==========================================
  Files          34       34
  Lines        4137     4141       +4
==========================================
+ Hits         4054     4059       +5
+ Misses         83       82       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

For the chat-pdf verb, we aren't predicting limit exhaustion in the cookie.  The only limits are the abuse limits. So I think what we want is just to not add anything to the map, let it assume the limit is not exhausted and paint the dropzone.  Sound good @kbenelli-adobe?


Application.start parameter update and subscribe argument

This has two changes:

Dialyzer caught the Application.start callback requiring :normal which it won't actually be sent. I updated the code to ignore the restart type field and where something was passed, I made it :temporary since that's the default.
Add a check on the argument type to subscribe to avoid a never ending recursion.

Thanks. To be honest I haven't run dialyzer that much during the development—and my ears are red. I am usually the one that preaches the use of it, but somehow I've locked everything down using structs in the project, so the compiler has been complaining a lot while I developed the thing.
Thank you very much :)


Custom spans

Update the user interaction client example creating custom spans for the different tasks the click handler runs.
Also, update a little the documentation on how to do it. I know the documentation is not complete now, however, it will be completely updated later in the next weeks for productionization, for now just update a bit the documentation on this.

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   96.33%   96.33%
=======================================
  Files          31       31
  Lines         928      928
  Branches      144      144
=======================================
  Hits          894      894
  Misses         34       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8abcac...14be981. Read the comment docs.

Requested changes are done. Ready to review.


How to supply multiple custom options?

 Issue by ptr727
Monday May 22, 2017 at 20:50 GMT
Originally opened as https://github.com/gsscoder/commandline/issues/444

In the v2 branch, I want to ignore case, but I want to keep the default help output.
How do I combine multiple custom options in the constructor?
Or how do I override default current values?
Parser parser = new Parser(with => with.CaseSensitive = false);
Parser parser1 = new Parser(with => with.HelpWriter = Console.Error);
// Parser parser = new Parser(with.CaseSensitive = false and with.HelpWriter = Console.Error);
ParserResult<Options> result = parser.ParseArguments<Options>(args);

If I try to modify the settings, I get an exception at runtime:
Parser parser = new Parser();
parser.Settings.CaseSensitive = false;
parser.Settings.HelpWriter = Console.Error;

System.InvalidOperationException occurred
  HResult=0x80131509
  Message=Operation is not valid due to the current state of the object.
  Source=CommandLine
  StackTrace:
   at CommandLine.Infrastructure.PopsicleSetter.Set[T](Boolean consumed, T& field, T value)
   at CommandLine.ParserSettings.set_CaseSensitive(Boolean value)
   at Plex.Program.Main(String[] args) in C:\Users\piete\OneDrive\Projects\Plex\Plex\Program.cs:line 31

 Comment by ptr727
Tuesday May 23, 2017 at 14:46 GMT

Ok, I figured it out:
            Parser parser = new Parser(with =>
            {
                with.CaseSensitive = false;
                with.HelpWriter = Console.Error;
            });


[SPARK-33290][SQL][2.4] REFRESH TABLE should invalidate cache even though the table itself may not be cached

Backport #30187 for branch-2.4

What changes were proposed in this pull request?

In CatalogImpl.refreshTable, this moves the uncacheQuery call out of the condition if (cache.nonEmpty) so that it will be called whether the table itself is cached or not.
Why are the changes needed?

In the case like the following:
CREATE TABLE t ...;
CREATE VIEW t1 AS SELECT * FROM t;
REFRESH TABLE t;

If the table t is refreshed, the view t1 which is depending on t will not be invalidated. This could lead to incorrect result and is similar to SPARK-19765.
On the other hand, if we have:
CREATE TABLE t ...;
CACHE TABLE t;
CREATE VIEW t1 AS SELECT * FROM t;
REFRESH TABLE t;

Then the view t1 will be refreshed. The behavior is somewhat inconsistent.
Does this PR introduce any user-facing change?

Yes, with the change any cache that are depending on the table refreshed will be invalidated with the change. Previously this only happens if the table itself is cached.
How was this patch tested?

Added a new UT for the case.

Test build #130492 has started for PR 30215 at commit f5062f7.

Thank you for making a backport, @sunchao !

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35096/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35096/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35096/
Test PASSed.

Test build #130492 has finished for PR 30215 at commit f5062f7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130492/
Test PASSed.

Merged to branch-2.4. Thanks!


Azure DevOps repos support

Is your feature request related to a problem? Please describe.
Our project hosts the target repos in Azure DevOps. I can see the tool is currently using go-git which doesn't support he Azure DevOps git protocol (libgit2 is required)
Describe the solution you'd like
Should be able to target a https://dev.azure.com/<sample org>/<sample project>/_git/<sample repo> link
Describe alternatives you've considered

Mirroring repository || not secure and a pain to maintain
Inspected how flux is doing it -> for azdo they use libgit2

Additional context

Flux used to have the same issue -> https://fluxcd.io/docs/components/source/gitrepositories/#git-implementation

Interesting problem, thanks for opening an issue.  We mainly use AWS/GCP internally and are light on Azure experience.  Could you clarify what version of git you would normally use on your machine and what OS/version?
The reason we went with go-git initially was because it was a pure go implementation.  The reason that Flux can do what they are doing is they are controlling a very fine-grained build process to produce an OCI image that runs for a controller to handle the git operations using https://github.com/fluxcd/golang-with-libgit2 and https://github.com/libgit2/git2go from what I can see. We don't have that luxury because we need to support multiple architectures and OSs for the CLI and so running in a very controlled environment like a container isn't possible.
Thinking out loud it might be worth just falling back to https://pkg.go.dev/os/exec#example-Cmd.Run and use the host-os git instead for zarf package create.  This is also the recommendation mentioned for Pulumi facing the same issue.
A good summary from someone who tried to fix this in go-git is here: https://github.com/pivotal/kpack/issues/213#issuecomment-742027991.  The related PR in that tool that actually swapped go-git -> libgit2 is here:  https://github.com/pivotal/kpack/pull/636, but note the ability to control the environment with a container.

One other note, if you could run zarf version and zarf package create -l=trace for any additional info that would be great.

I'm getting a 400 on a public repo: https://dev.azure.com/me0515/_git/zarf-public-test.

Yeah, the error is vague, but I saw that before when working with Azure DevOps and go-git issue. The main challenge comes with the multi_ack required by AzDO.

Agreed re: multi_ack.  What are your thoughts on falling back to a host-provided git binary?

Agreed re: multi_ack. What are your thoughts on falling back to a host-provided git binary?

Sorry mate didn't follow. What do you mean by host-provided git binary? Something like download zip file?

Yeah sorry, so basically my proposal (only on the zarf package create side) would be to attempt to us the internal go library to do the pull, and then if that errored out for any reason, to then attempt to simply call git clone or similar using the machine's git installation/configuration if possible.  Does that make sense?

@jsburckhardt we're hoping #471 will resolve this (it currently passes for our test azure repo).


Automation log output no longer displayed in UI when running in pods

Since the worker running automate runs in a different pod than the UI worker, the UI does not have access to the automate logs. Also, there can be multiple workers running the automate role and therefore, logs would be distributed across multiple pods.
Ideally, there should be log aggregation for podified MIQ because this issue is not limited to automate.

Duplicate of https://github.com/ManageIQ/manageiq-pods/issues/697

Thank you! can we have an ETA ? there is an MVP ongoing @gtanzillo @Fryguy

@ggclass No ETA, since it will involve a very complicated change.  We might be able to do something in the interim, but I'm not sure there level of effort.

Can we size and provide a comeback by COB? We have a meeting with local team. We might need to escalate to get traction
       ～L

Luigi Savorana -IBM Cloud Labs WW Senior Technical Support Manager - IBM Cloud Labs -M: +39-335-7260-139

Il giorno 16 mar 2021, alle ore 20:39, Jason Frey @.***> ha scritto:

This Message Is From an External Sender
This message came from outside your organization.
@ggclass No ETA, since it will involve a very complicated change. We might be able to do something in the interim, but I'm not sure there level of effort.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

any news?


[2.x] Issue #4719 - Helidon DBClient does not trigger an Exception when no sane DB connection can be obtained

Signed-off-by: Tomas Kraus<EMAIL_ADDRESS>PR #4771 backport to 2.x

/trigger

/trigger


API for getting keys by pattern

I think thiere is need in getting keys by pattern. Its quite easy
As storage keys can be taken with Object.keys(localStorage)

What do you mean with "by pattern"?

Well it could get all keys by defalut, but also as sugar could take string or RegExp on which it would test key and return only keys matched.

I think it would be useful if you could provide a concrete use case you have in mind.

Well for example you are keeping some items with keys document_{id}, and you want to get all the documents available in storage, you either need to keep some where ids list, you you can filter the key names.

Hi sorry for the long silence.
I don't feel this feature belongs into the driver. The driver just implements the storage API as is.

Closing this for now.


Issues with srb tc reading from sorbet generated gems rbi

Input
-- site.rb
class Site < ActiveRecord::Base # actually it's ApplicationRecord, but ApplicationRecord subclass ActiveRecord::Base
end

-- in gems/activerecord.rbi
class ActiveRecord::Base
  include ActiveRecord::AttributeMethods::Dirty
end

module ActiveRecord::AttributeMethods::Dirty
  def saved_change_to_attribute?(attr_name, **options); end
end

Observed output
./sorbet-test.rb:10: Method saved_change_to_attribute? does not exist on Site https://srb.help/7003
    10 |T.reveal_type(Site.last!.saved_change_to_attribute?(:name))
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expected behavior
No error because the method is present in a Site object

Found out that some gems file was marked as # typed: ingore due to srb tc suggest-type

@manhhung741 do you have an idea why the RBI was being ignored? We should probably make it so that no autogenerated RBI ever introduces an error in typed: false.

It's probably my fault when I run srb rbi suggest-typed when it was in an error state.
I think it may be a good idea to not let this changes generated files.
More context:

We add "Elem" to ActiveRecord::Base
Some generated code define classes that subclass ActiveRecord::Base
Running srb rbi suggest-typed mark those files and dependent files as # typed: ignore

Separately, I also have an issue with the Elem = type_member(fixed: ...) affecting srb init. I wonder why subclasses can't inherit this attribute. If it isn't possible, what workaround can I apply?


[AIRFLOW-1893] Propagate PYTHONPATH when using impersonation

Make sure you have checked all steps below.
JIRA

[x] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-1893

Description

[x] Here are some details about my PR, including screenshots of any UI changes:

When using impersonation via run_as_user, the PYTHONPATH environment
variable is not propagated hence there may be issues when depending on
specific custom packages used in DAGs.
This PR propagates only the PYTHONPATH in the process creating the
sub-process with impersonation, if any.
Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Tested in staging environment; impersonation tests in airflow are not very portable and fixing them would take additional work, leaving as TODO and tracking with jira ticket: https://issues.apache.org/jira/browse/AIRFLOW-1901.
Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

[x] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

PTAL @aoen

Is it possible to add a test for this?

Codecov Report

Merging #2860 into master will increase coverage by 0.07%.
The diff coverage is 25%.

@@            Coverage Diff             @@
##           master    #2860      +/-   ##
==========================================
+ Coverage   73.95%   74.03%   +0.07%
==========================================
  Files         160      160
  Lines       12137    12141       +4
==========================================
+ Hits         8976     8988      +12
+ Misses       3161     3153       -8

Impacted Files
Coverage Δ

airflow/task_runner/base_task_runner.py
70.31% <25%> (-3.03%)
:arrow_down:

airflow/models.py
87.42% <0%> (-0.05%)
:arrow_down:

airflow/jobs.py
79.89% <0%> (+0.44%)
:arrow_up:

airflow/executors/dask_executor.py
81.39% <0%> (+2.32%)
:arrow_up:

airflow/utils/helpers.py
56.32% <0%> (+2.87%)
:arrow_up:

airflow/task_runner/bash_task_runner.py
100% <0%> (+6.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8626186...6d99fab. Read the comment docs.

LGTM

Failing job in CI is due to coveralls https://travis-ci.org/apache/incubator-airflow/jobs/315082177


Fix: replace every double quote

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           9      9
  Lines          89     89
  Branches       14     14
=====================================
  Hits           89     89

Impacted Files
Coverage Δ

src/modules/convert-array-of-arrays-to-csv.js
100% <ø> (ø)
:arrow_up:

test/fixtures/data.js
100% <ø> (ø)
:arrow_up:

test/fixtures/expected-results.js
100% <100%> (ø)
:arrow_up:

src/helpers/append-element.js
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d772a61...a69411c. Read the comment docs.


fix "species = ROBOT_POP_SPECIES_3" - referncing a species created in buildable_pops

CW240 error created in vanilla crisis_events_3.txt line 733. The parser doesn't recognize the species defined in common/buildable_pops.

Fixed with f773546


Update team page and add feedback partial to the accessibility posters page

Description
Update team page to:

remove old members (Amber, Amy, Catherine and Mua)
add new team member (Mo)

Update Download accessibility posters page to include a feedback partial linking to the relevant issue in the community backlog on GitHub.
Related issue
#1657
Checklist

[x] Tested against the NHS.UK frontend testing policy (Resolution, Browser & Accessibility)
[x] Code follows the NHS.UK frontend coding standards
[x] Version number has been increased in package.json (using SEMVER)
[x] CHANGELOG entry
[x] Whats new page entry
[x] Page updated date

PR ready for review from @DomBaker and @truecroft2

@henocookie half of this has already been done https://github.com/nhsuk/nhsuk-service-manual/pull/1662

Closing this PR and branch as half the changes in this PR (and branch) are covered by other work


Possibly Adjusting Deposit

Changes:

Don't pass in txBytes
Pass in address to deposit msg.value to
Pass in bool or use some type of flag to distinguish when the depositor will deposit to an address other than their own

Pros:
Allows for deposits to any address while adding a little user safety by using some type of flag. User doesn't need to construct the txBytes themselves.
Cons:
Slightly more complexity and less clean.
A way to get around passing in txBytes is to build an on chain rlp encoder or as proposed on omisego/plasma-mvp in issue 65 make a deposit tx hash only be hash(address, value).

Why can't we just overload the deposit function. deposit() sends to msg.sender, deposit(address receiver) sends to receiver?

Yeah that sounds good, I wasn't sure if solidity functions supported overloading


Update Astro to 5.0

Summary
This pull request updates Astro and related dependencies to support Astro 5.0.
Closes #73.
Quick changelog

Update Astro, @astrojs/mdx, astro-pagefind
Update other dependencies within current semver rules
Update to the new Collections system
Rename ViewTransitions component
Update CSS variables
Update TypeScript configuration
Fix a build error that probably became visible due to a TypeScript update

Detailed changes
Package updates

Astro updated to ^5.0.3
Astro mdx integration updated to ^4.0.1
Astro-pagefind updated to ^1.7.0
Pagefind updated to ^1.2.0
Other packages updated in package.json according to semver constraints

Collections updates
Collections now use the new Content Layer API. The upgrade to the new API requires changes:

The content config file no longer lives within the src/content/ folder. This file should now exist at src/content.config.ts.
Collection definitions require loaders, do not allow you to set collection types, and require a file pattern.
slug references are now named id.
Entries no longer have a render() method, as they are now serializable plain objects. Instead, you must import the render() function from astro:content, and use different syntax.

ViewTransitions rename
Astro 5.0 renames the <ViewTransitions /> router component to <ClientRouter /> to clarify the role of the component within the API.
TypeScript configuration change
Astro 5.0 uses a .astro/types.d.ts file for type inferencing, and now recommends setting include and exclude in tsconfig.json to benefit from Astro types and avoid checking built files. src/env.d.ts is only necessary if you have a custom configuration.
Shiki css-variables color token name changes
In Astro v4.x, the Shiki css-variables theme used the --astro-code-color-text and --astro-code-color-background tokens for styling the foreground and background colors of code blocks respectively. Astro v5.0 renames them to --astro-code-foreground and --astro-code-background respectively to better align with the Shiki v1 defaults.
Fixes
These updates triggered a TypeScript bug with readingTime() functions in the projects and blog collections. The functions expect a string argument, but the passed argument is defined as string | undefined. This check blocks the build process.

  {readingTime(post.body)}

To fix the error, the function only runs if its argument is defined.
{post.body && (

    {readingTime(post.body)}

)}

Thank you!!


fix Fix compatibility with CgroupV2

What problem does this PR solve?
Problem Summary:

Fix memory.max value is max.
Fix memory_usage minus slab_reclaimable, part of "slab" that might be reclaimed.

Check List (For Author)

Test

[ ] Regression test
[ ] Unit Test
[ ] Manual test (add detailed scripts or steps below)
[x] No need to test or manual test. Explain why:

[ ] This is a refactor/code format and no logic has been changed.
[x] Previous test can cover this change.
[ ] No code files have been changed.
[ ] Other reason

Behavior changed:

[x] No.
[ ] Yes.

Does this need documentation?

[x] No.
[ ] Yes.

Check List (For Reviewer who merge this PR)

[ ] Confirm the release note
[ ] Confirm test cases
[ ] Confirm document
[ ] Add branch pick label

run buildall

run buildall


Add ST X-NUCLEO-EEPRMA2 EEPROM shield and a EEPROM driver sample

This PR adds the ST X-NUCLEO-EEPRMA2 as a new Arduino shield and adds a minimal sample to demonstrate the EEPROM driver api.

I see from @henrikbrixandersen as eeprom maintainer no review was requested.
Could you have a look at this?

@str4t0m If you could you help verify #35743 on this shield I would be grateful.

The eeprom tests still pass on the shield.
I wonder whether I should add an eeprom-1 alias for the eeprom4 node to the shield, such that one I2C and one SPI device are active?

Good idea. Also, thanks for testing!


Load user-data as YipConfig files

This PR tries to load user-data from providers as YipConfig files,
if the parsing fails it does nor raise any error. User-data is stored to
the provided path. The file is named userdata.yaml if it could be
parsed as a YipConfig structure otherwise it is just called userdata.
In addition this commit also includes logic to apply the authorized keys
if the provider extracts a ssh/authorized_keys file.
Fixes rancher-sandbox/cOS-toolkit#93
Signed-off-by: David Cassany<EMAIL_ADDRESS>

This PR drops the json parsing specific logic from linuxkit for which it was possible to create files and directories. There is no need for that yip can already do that, so I opted for a dummy approach, try to match if  user-data is a yip parseable content and if so store it as userdata.yaml into the provided path (so yip could eventually execute it in a later stage). If the content is not parseable it is just stored as userdata. If no path is provided the file is stored as /run/config/userdata.
See the test I did in AWS at https://github.com/rancher-sandbox/cOS-toolkit/issues/93#issuecomment-826779731

Almost forgot... we should update the readme ( at least the cos one ) with the new feature syntax 🙂

by calling schema.Load we should also support the userdata.yaml as a cloud config (as in the original syntax spec), not only the yip config format

Yes I know, that's why at the end I opted using schema.Load. It took me a while getting into yip code, but I enjoied it and learned from it :)


issue in views.py file "assignedDoctorId must be Doctor instance"

There is some issue please check views.py file. Please check line number- 90, 326, 352, 432, 517,....and several more in views.py file.

its already doctor instance...

@sumitkumar1503  write patient.assignedDoctorId = models.Doctor.objects.filter(user_id = request.POST.get('assignedDoctorId')).first() instead of patient.assignedDoctorId=request.POST.get('assignedDoctorId')

patient.assignedDoctorId
we need to assign only id of that doctor.
why i need to need assign instance of doctor ?

@sumitkumar1503  actually you added FK constraints last days. Now assignedDoctorId is no longer take PositiveIntegerField, it takes ForeignKey Doctor. So, assignDoctorId is no longer take an integer number. When we write patient.assignedDoctorId=request.POST.get('assignedDoctorId')  it shows "ValueError at/patientsignup Patient.assignedDoctorId" must be a "Doctor" instance". Download your code directly from this github and runserver and check it.

ok ok got it
actually I merged pull requests without checking it.
for now, I am going to undo the previous changes (foreign key)
After some time I will fix it


tablet: load_tablet should remove the old tablet in the cache.

Signed-off-by: SpadeA-Tang<EMAIL_ADDRESS>
What is changed and how it works?

Issue Number: Close #12985
What's Changed:

Remove old tablet in the registry in `load_tablet`.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List
Tests

Unit test

Release note
None

/run-test

PTAL @tonyxuqqi @5kbpers

I didn't know we allow randomly changing path like this before. Knowing that I don't think this code is very robust.
I can immediately think of a few cases:

load_tablet(random_path, random_id, random_suffix) will drop the root db (0, 1) instead of returning an error.
if load_tablet fails at rename, the region can't use the old id to get the engine anymore.

I think this is mainly used in apply snapshot where we will change the suffix to the log index of the snapshot.
Maybe I should only remove the old one if open_tablet_raw succeeds.

/merge


Update outdated examples (single-file, helm, etc.)

closes #242.
The examples were built with an old version of docker-app.
- What I did
Update the generated files to match with the new version of docker-app.
- How I did it
Follow the readme instructions for each example and update the readme and generated files.
- How to verify it
Go through examples.
- Description for the changelog
Update examples to use version 0.3.0
- A picture of a cute animal (not mandatory but encouraged)

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "feature/update-examples" git@github.com:Dimrok/app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842362012464
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


Flicker while submitting rating

There is an issue with flicker when submitting rating for requesters. Easily fixed by loading data after request is returned in dashboard controller.

Resolved in https://github.com/crowdresearch/crowdsource-platform/pull/485


Feature - I18n translate files and add helper wrapper to labels

General

I18n translate files to spanish

.
Type

ℹ  What types of changes does your code introduce?

👉 Put an x in the boxes that apply

[ ] Fix
[x] Feature

Describe the changes here (summarized)
Closes #23

Btw, @lewandy please, resolve those conflicts and commit to your branch.

@Jadhielv I just resolved the conflicts, you can review again.

Perfect! xD. Still waiting approval of @itsalb3rt


APT whitelist request for libace-dev

This replaces travis-ci/travis-ci#4360.
The original text by @Tuxity follows

libace-dev from Ubuntu Precise (http://packages.ubuntu.com/precise/libace-dev)

Ran tests and found setuid bits by purely textual search. Further analysis is required.
If these are found to be benign, add:
mpc-ace libace-6.2.8 libace-dev libace-doc libace-ssl-6.2.8 libace-ssl-dev libace-rmcast-6.2.8 libace-rmcast-dev libace-tmcast-6.2.8 libace-tmcast-dev libace-htbp-6.2.8 libace-htbp-dev libace-inet-6.2.8 libace-inet-dev libace-inet-ssl-6.2.8 libace-inet-ssl-dev ace-gperf gperf-ace libacexml-6.2.8 libacexml-dev libace-xml-utils-6.2.8 libace-xml-utils-dev libkokyu-6.2.8 libkokyu-dev libace-qtreactor-6.2.8 libace-qtreactor-dev libace-xtreactor-6.2.8 libace-xtreactor-dev libace-tkreactor-6.2.8 libace-tkreactor-dev libace-flreactor-6.2.8 libace-flreactor-dev libace-foxreactor-6.2.8 libace-foxreactor-dev ace-netsvcs libnetsvcs-6.2.8 libnetsvcs-dev
See https://travis-ci.org/travis-ci/apt-whitelist-checker/builds/72545576.

Cross-referencing whitelist request for ubuntu-trusty: #4273.


[MRT Core] Add support for VS's FastUpToDate check in MRT Core.

Description
Please see issue: https://github.com/microsoft/WindowsAppSDK/issues/1898
Credit
The fix here is from @evelynwu-msft (thanks Evelyn!) with two modifications from me.
How verified
Used https://github.com/microsoft/WindowsAppSDK/issues/1898#issuecomment-1058629425 with the following modifications:

Upgraded the NuGet package to WAS 1.0.
Commented out the contents of Directory.Build.targets.
Moved fix into MrtCore.PriGen.targets in the NuGet pkg with the None ItemGroup removal bit removed (it's not needed, and if kept, will introduce an issue).
Removed the change to the DisplayName (changes the name displayed in the Build Action drop-down list where there is already a "Resource").

Without and with fix:

Delete string in RESW in the StringResources project.
Build the solution.
Add string in RESW in the StringResources project.
Build the solution.

With the fix, all 4 projects are built, and without, only 2 are built (StringResources and the WAPPROJ project).

/azp run

/azp run

winui doesn't use this. is that a problem too?

Refers to: dev/MRTCore/packaging/MrtCore.PriGen.targets:1 in ee096d6. [](commit_id = ee096d66070775c43ed79c94f1a068ee6e935cb1, deletion_comment = False)

winui doesn't use this. is that a problem too?
Refers to: dev/MRTCore/packaging/MrtCore.PriGen.targets:1 in ee096d6. [](commit_id = ee096d6, deletion_comment = False)

WinUI does use this for WAP proj based apps.

The XML declaration is optional. UTF-8 is the default encoding when no declaration is present unless there's a Unicode BOM (in which case it's UTF-16). https://docs.microsoft.com/en-us/previous-versions/troubleshoot/msxml/xml-encoding-dom-interface-methods
Including it in this case is making things extra-explicit, but there's no advantage or disadvantage to doing so. Personally, I would bias to including it in new XML files (if I remembered to) but I wouldn't go out of my way to add it to existing files.

In reply to:<PHONE_NUMBER>

Refers to: dev/MRTCore/packaging/MrtCore.PriGen.targets:1 in ee096d6. [](commit_id = ee096d66070775c43ed79c94f1a068ee6e935cb1, deletion_comment = False)

/azp run

I meant WinUI doesn't use MrtCore.PriGen.targets, does it?

In reply to:<PHONE_NUMBER>

Refers to: dev/MRTCore/packaging/MrtCore.PriGen.targets:1 in ee096d6. [](commit_id = ee096d66070775c43ed79c94f1a068ee6e935cb1, deletion_comment = False)

I meant WinUI doesn't use MrtCore.PriGen.targets, does it?
In reply to:<PHONE_NUMBER>
Refers to: dev/MRTCore/packaging/MrtCore.PriGen.targets:1 in ee096d6. [](commit_id = ee096d6, deletion_comment = False)

I think the WAPPROJ based solutions use it.

WinUI has "false". It's no longer the case?

In reply to:<PHONE_NUMBER>

WinUI has "false". It's no longer the case?
In reply to:<PHONE_NUMBER>

Can you clarify which property you're referring to?

uhh, xml doesn't display well. it's EnableCoreMrtTooling

In reply to:<PHONE_NUMBER>

uhh, xml doesn't display well. it's EnableCoreMrtTooling
In reply to:<PHONE_NUMBER>

EnableCoreMrtTooling is our control switch. WinUI doesn't set it or reference it.

isn't that the switch controls importing mrtcore.prigen.targets? (WinUI has a separate path to import, but that should also be turned off in normal case)

In reply to:<PHONE_NUMBER>

what you quoted is for WAP or UWP which is of no interest to me here. My point is if mrtcore.prigen.targets is not imported, your change would make no effect.

In reply to:<PHONE_NUMBER>

what you quoted is for WAP or UWP which is of no interest to me here. My point is if mrtcore.prigen.targets is not imported, your change would make no effect.
In reply to:<PHONE_NUMBER>

WinUI does use this in the non single project MSIX case.

it's not clear to me how WinUI uses this based on code search. but i could miss something. How about single project MSIX or unpackaged?

In reply to:<PHONE_NUMBER>

Single project MSIX uses Microsoft.Build.Msix.Pri.targets. Not sure about unpackaged (I suspect WinUI doesn't support it). I suggest asking Evelyn or Tommy.

do you need to make sure your fix covers all cases?

In reply to:<PHONE_NUMBER>

do you need to make sure your fix covers all cases?
In reply to:<PHONE_NUMBER>

I think this is sufficient. The verification is whether the project's changes are picked up by FUTD or not and whether the parent projects are rebuilt. That's what was done.


Use master builder.

Might need to upload the bench results too, not sure?

:+1: With  maybe HADDOCK

These aren't the same, missing publish

Sorry didn't see the original description, keeping the history is important now (especially given how ci is going to operate in the future).
master has a runner that supports publish bench now as well

For publishing bench (https://github.com/ambiata/twine/blob/master/test/bench.hs#L45) will need to change as well to dist/build/twine/twine-bench.html as per https://github.com/ambiata/master-ambiata#haskell-library

Update to latest runner then :100:


Command scp being called twice

I believe 8a452a9629969b5368aace64df8e296a506c5156 introduced a regression where the files are copied twice.
Being called like this:
docker-machine scp -r www machine-name:/www
These are the lines introduced. This looks like a merged copy from the previous commit and earlier commits. Note that runCmdWithStdio is run twice if there is no err.
73	if err := runCmdWithStdIo(*cmd); err != nil {
74			return err
75		}
76
77		return runCmdWithStdIo(*cmd)

Oh yes you are right! I'll fix that

This has been fixed with PR #2452


InvalidAuthorization Error with Python Sample Example

Followed the instruction and used the sample code as documented with just replacing the Workspace ID and Primary Key to Customer ID and Shared Key respectively. But the execution is failing with error "An invalid signature was specified in the Authorization header" and Status code 403.
Thanks,
Santhosh.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1295e1b3-5aed-3aee-4331-8b81e7a7e544
Version Independent ID: 3c00a5ee-7093-1e8b-9004-8fed3f82960e
Content: Log Analytics HTTP Data Collector API
Content Source: articles/log-analytics/log-analytics-data-collector-api.md
Service: log-analytics
Product: unspecified
GitHub Login: @bwren
Microsoft Alias: bwren

@santhoshvellingiri Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@santhoshsomayajula This appears to have something to do with the version of Python.  I just tried the script from Python 3.6.5 and also got 403.  I had to make some minor edits though because of errors I got.  We definitely would have seen those errors when we initially tested this.  Sure enough, I tried to original script with Python 2.7, and it worked fine.  I suspect the problem is with line 50 which I had to change to get the script to run.  That's building the signature, so I suspect that my change was incorrect, so I have a bad signature.  I didn't write the original script, so I'll follow up with our engineering team to see if someone can help with a fix.  In the meantime, I'll label this as Python 2 in the article (which is also the version of Python that Azure Automation uses).

#please-close

@santhoshvellingiri We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

I got the exactly same issue and find out this post. I believe that we should provide the right Python3 example. Here is the revised build_signature function working for Python3.
`def build_signature(customer_id, shared_key, date, content_length, method, content_type, resource):
x_headers = 'x-ms-date:' + date
string_to_hash = method + "\n" + str(content_length) + "\n" + content_type + "\n" + x_headers + "\n" + resource
bytes_to_hash = bytes(string_to_hash, encoding='utf-8')
decoded_key = base64.b64decode(shared_key)
encoded_hash = base64.b64encode(hmac.new(decoded_key, bytes_to_hash, digestmod=hashlib.sha256).digest())
authorization = "SharedKey {}:{}".format(customer_id,encoded_hash.decode('utf-8'))
return authorization`

I got the exactly same issue. Here are the changes in build_signature function which make the sample code work for python3.
bytes_to_hash = bytes(string_to_hash, encoding='utf-8')

authorization = "SharedKey {}:{}".format(customer_id,encoded_hash.decode('utf-8'))


Remove 'thenify' dependency, since 'thenify-all' also includes and ex…

…poses it. Fixes #503. r=vporof

Coverage decreased (-0.02%) to 42.852% when pulling 0ae89a25dec910deb72891ed13a51ad9ab94e8af on jsantell:remove-thenify into 38ebe1d266fda0588a48f110dc2bed372997a024 on mozilla:master.

r+


Wallet takes long to load and will not input numbers properly

Issue description
The wallet takes longer to load as in there is a 30 sec delay before it loads up.  Then when I try to input my pin, I can only input one number.  then I have to click each time, but I am denied access because it indicates I have the wrong pin.
Firefly version
1.2.0
OS details
Windows 10
Can the issue be reliably reproduced?
Yes
Steps to reproduce the issue
1.Opening the wallet
2. Trying to input pin to login
3.
...
Expected behaviour
Loads immediately and should allow login with the correct pin.  Should allow user to input pin number
Actual behaviour
The wallet has a white screen for about 30 seconds before loading up.  Once the wallet loads up, I choose my account.  However, when I input my pin, I can only input the first number.  After that I cannot input any other numbers with my keyboard unless I click the next space.  After inputting the entire pin the wallet still does not grant access indicating the pin is wrong.
Errors
Sun, 26 Sep 2021 21:28:03 GMT
ClientError: {}
Sun, 26 Sep 2021 21:17:02 GMT
ClientError: {}
Sat, 25 Sep 2021 19:10:56 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 25 Sep 2021 19:10:50 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 25 Sep 2021 19:10:37 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 25 Sep 2021 19:10:25 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 25 Sep 2021 17:47:17 GMT
ClientError: {}
Sat, 25 Sep 2021 17:38:36 GMT
ClientError: {}
Thu, 29 Apr 2021 22:50:11 GMT
ClientError: {}
Sat, 24 Apr 2021 19:01:52 GMT
ClientError: {}
Sat, 24 Apr 2021 18:56:43 GMT
ClientError: error sending request for url (https://chrysalis-nodes.iota.cafe/api/v1/addresses/iota1qzvd84r6ew6jn3yf07s885fdfxkaagph5cxxvy0we000cx60cdm3xkv2ql6/outputs?include-spent=true): error trying to connect: dns error: No such host is known. (os error 11001)
Sat, 24 Apr 2021 15:18:38 GMT
ClientError: {}
Sat, 24 Apr 2021 15:13:28 GMT
ClientError: error sending request for url (https://chrysalis-nodes.iota.org/api/v1/addresses/iota1qzvd84r6ew6jn3yf07s885fdfxkaagph5cxxvy0we000cx60cdm3xkv2ql6/outputs?include-spent=true): error trying to connect: dns error: No such host is known. (os error 11001)
Sat, 24 Apr 2021 15:08:06 GMT
ClientError: {}
Sat, 24 Apr 2021 15:02:55 GMT
ClientError: error sending request for url (https://chrysalis-nodes.iota.org/api/v1/addresses/iota1qzvd84r6ew6jn3yf07s885fdfxkaagph5cxxvy0we000cx60cdm3xkv2ql6/outputs?include-spent=true): error trying to connect: dns error: No such host is known. (os error 11001)
Sat, 24 Apr 2021 14:54:15 GMT
ClientError: error sending request for url (https://chrysalis-nodes.iota.org/api/v1/addresses/iota1qzvd84r6ew6jn3yf07s885fdfxkaagph5cxxvy0we000cx60cdm3xkv2ql6/outputs?include-spent=true): error trying to connect: dns error: No such host is known. (os error 11001)
Sat, 24 Apr 2021 14:54:10 GMT
ClientError: error sending request for url (https://chrysalis-nodes.iota.org/api/v1/addresses/iota1qzvd84r6ew6jn3yf07s885fdfxkaagph5cxxvy0we000cx60cdm3xkv2ql6/outputs?include-spent=true): error trying to connect: dns error: No such host is known. (os error 11001)
Sat, 24 Apr 2021 14:53:57 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:53:26 GMT
ClientError: error sending request for url (https://chrysalis-nodes.iota.org/api/v1/addresses/iota1qzvd84r6ew6jn3yf07s885fdfxkaagph5cxxvy0we000cx60cdm3xkv2ql6/outputs?include-spent=true): error trying to connect: dns error: No such host is known. (os error 11001)
Sat, 24 Apr 2021 14:46:40 GMT
ClientError: error sending request for url (https://chrysalis-nodes.iota.cafe/api/v1/addresses/iota1qzvd84r6ew6jn3yf07s885fdfxkaagph5cxxvy0we000cx60cdm3xkv2ql6/outputs?include-spent=true): error trying to connect: dns error: No such host is known. (os error 11001)
Sat, 24 Apr 2021 14:46:39 GMT
ClientError: error sending request for url (https://chrysalis-nodes.iota.cafe/api/v1/addresses/iota1qzvd84r6ew6jn3yf07s885fdfxkaagph5cxxvy0we000cx60cdm3xkv2ql6/outputs?include-spent=true): error trying to connect: dns error: No such host is known. (os error 11001)
Sat, 24 Apr 2021 14:46:36 GMT
ClientError: error sending request for url (https://chrysalis-nodes.iota.cafe/api/v1/addresses/iota1qzvd84r6ew6jn3yf07s885fdfxkaagph5cxxvy0we000cx60cdm3xkv2ql6/outputs?include-spent=true): error trying to connect: dns error: No such host is known. (os error 11001)
Sat, 24 Apr 2021 14:44:16 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:44:08 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:43:56 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:43:41 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:42:02 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:41:55 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:41:27 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:41:16 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:40:45 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:40:41 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:40:28 GMT
StrongholdError: failed to perform action: Snapshot Error: Crypto Error: error in algorithm XCHACHA20-POLY1305, Unable to read snapshot. Please try another password.``
Sat, 24 Apr 2021 14:39:46 GMT
ClientError: error sending request for url (https://chrysalis-nodes.iota.cafe/api/v1/addresses/iota1qzvd84r6ew6jn3yf07s885fdfxkaagph5cxxvy0we000cx60cdm3xkv2ql6/outputs?include-spent=true): error trying to connect: dns error: No such host is known. (os error 11001)
Sat, 24 Apr 2021 14:37:03 GMT
ClientError: {}
Sat, 24 Apr 2021 14:29:09 GMT
ClientError: error sending request for url (https://chrysalis-nodes.iota.org/api/v1/addresses/iota1qzvd84r6ew6jn3yf07s885fdfxkaagph5cxxvy0we000cx60cdm3xkv2ql6/outputs?include-spent=true): error trying to connect: dns error: No such host is known. (os error 11001)

Hi, has this always happened or did this only start when you opened the issue? I saw that you posted error messages from April

This issue has resolved, I apologize, I didn't realize I forgot to close the case.  I believe it may have been because I was not using the English keyboard.


x/tools/gopls: move analyzers to an extensible sidecar

We've talked a lot about how users can extend the set of analyzers that gopls runs so it can include org-specific checkers. Historically the challenge was that users would have to re-build gopls with the extended set of analyzers (which is not difficult but is inconvenient), or gopls would have to communicate with a separate process that contains the analyzers, which means it would have to do type checking yet again. (gopls already does--and must do--type checking of each package twice: once for its main index, and again for analysis.) But today @findleyr pointed out that, as of v0.12.0, there's no real efficiency reason not to move all of gopls' analysis into the sidecar process, so that the net number of invocations of the type checker is unchanged.
In essence, gopls would fork+exec a long-lived child process and communicate with it over a pipe. (The child process wouldn't need any other capabilities.) A request would send the metadata, source files, facts, and export data required to analyze a package, and the child would do the work and return serialized facts and diagnostics over the pipe. By default the child program would be a mode of gopls itself (e.g. 'gopls analyze'), but users could specify an alternative program that implements the same interface, analogous to the way 'go vet -vettool=...' runs an alternative unitchecker-based tool.
This approach still requires the user to build an executable containing both gopls code (the driver and core analyzers) and user code (their analyzers), but this could be done automatically by gopls: it would generate a main file from the user's configuration and then execute it, a bit like 'go test'. But perhaps this approach (and the potential for version skew of both the go toolchain and the gopls source) is more complex than the simple "re-build" approach.  Something to think about.

Per in-person discussion, we need to decide whether this has significant advantages over simply making it easier to recompile gopls itself.
One primary advantage is isolation: analyzers can't mutate other global state that may affect gopls. But on the other hand, does this limit gopls extensibility to analyers? If so, is that sufficient?

Yes, @hyangah raised a similar question: the user still has to build something containing their analyzers; why should that not just be gopls itself? There are fewer moving parts that way.
The only real advantage I can think of is isolation: a sidecar could make gopls robust to panics and crashes in the analyzers, and with some bisection logic it could automatically identify and retire the culprits. Also, we could run completely untrusted analyzer code safely if it ran in a sandbox (e.g. something like seccomp) with no capabilites. But that does seem like a lot of work, and presumably users trust their own org's analyzers.
The security angle is more interesting in the context of an idea that @griesemer brought up yesterday, of allowing each module to define its own analyzers that are automatically run on packages that import it. This would allow a module with a complex API to provide a set of checkers to catch misuses of it. Checkers could run as part of 'go test' (which is already running untrusted code), or they could be run by a hypothetical 'go build -analyze' command if the checkers can be sandboxed so that they run in an unprivileged process that can't access the file system or network.
Also, @ianthehat mentioned that in an earlier experiment with extensible sets of analyzers, there were significant user interface challenges with too many error messages, and cross-talk between analyzers. I don't have details but perhaps he can elaborate.

Another big advantage of an analyzer sidecar is that it could be dynamic.
An idea that has been thrown around is having codebase-specific analyzers (e.g. I have a local analyzer that I use to catch when I forget to add a Go copyright header). If there were a configurable "workspaceAnalyzers" setting that had a pre-determined layout similar to x/tools/go/analysis/passes, we could recompile an analyzer binary for each workspace, and allow users to run their own analyzers for their codebase, for each workspace.

Another potential advantage is the ability to run multiple sidecars and cleanly merge the results

I look forward to a future where gopls hotreloads analyzers in x/tools while I edit them.

A goplschecker.Main analog to *checker.Main seems like it would be easy for others to adapt a list of analysis.Analyzers to talk the gopls analyze protocol. Then a minimum but flexible configuration for external checkers is just a list of external binaries and flags. These could be compiled ahead of time. This only really requires an external_analyzer setting.
A part of the protocol could be a handshake to check for version skew (+config skew). gopls can warn when a a tool is disabled due to version skew.
More flexible users could just give a list of packages and Analyzer variable and the goplschecker + go.mod could be generated relatively easily. gopls could compile and recompile this on demand. It seems like this would be done fairly infrequently. This could just be another external_analyzer. My gut instinct is that a provided external_analyzer binary would be more attractive to security sensitive organizations.

Historically the challenge was that users would have to re-build gopls with the extended set of analyzers (which is not difficult but is inconvenient)...

The difficulty, or inconvenience, for me is not the action of recompiling gopls, but that it is an unintuitive workflow. Setting an analyzer occurs like a config, and it's pretty uncommon when configuring an IDE tool to need to recompile the tool to collect the config.
Is it possible for gopls to call out to a binary that is a singlechecker or multichecker instead of a custom gopls API? Then users can build analysis tools as they do today, and build their multichecker, and use it with gopls.
The checkers have a -json option. If it isn't sufficient, can we improve the API of the checkers so they're usable with gopls?

The difficulty, or inconvenience, for me is not the action of recompiling gopls, but that it is an unintuitive workflow. Setting an analyzer occurs like a config, and it's pretty uncommon when configuring an IDE tool to need to recompile the tool to collect the config.

I agree, it's confusing and inconvenient, but we should keep in mind that there may be solutions to this other than the sidecar-based approach, for example a gopls that can rebuild itself based on configuration changes. (Something like this is already being discussed in the context of #61185, not that this approach is by any means trivial.)

Is it possible for gopls to call out to a binary that is a singlechecker or multichecker instead of a custom gopls API?

No, it's not possible today,  and I don't think it's even the right interface for a gopls analysis sidecar because it {single,multi}checker uses go/packages to load a complete program from source, whereas gopls should be in charge of dependency analysis and invalidation (and indeed providing source files, which may contain unsaved edits). The 'unitchecker' model of separate analysis is much closer to what we want, though again I would not use that interface exactly.
But the idea of building a multichecker-like tool that consists of a special main function plus a bunch of analyzers---and nothing else---is exactly what this proposal is about. It's just that the main function would be designed around the channel to gopls.

But could we build the gopls interface into the {single,multi}checker applications as a flag, -gopls that enables this different mode, so that checkers by default are compatible with the language server? It seems more useful if the community of checkers are naturally and efficiently compatible with other ecosystem tools.
(Or the flag could be called -pipe or -stream or something else that isn't gopls specific if that notion of coupling to gopls specifically isn't welcome.)

But could we build the gopls interface into the {single,multi}checker applications as a flag, -gopls, that enables this different mode, so that checkers by default are compatible with the language server? It seems more useful if the community of checkers are naturally and efficiently compatible with other ecosystem tools.
(Or the flag could be called -pipe or -stream or something else that isn't gopls specific if that notion of coupling to gopls specifically isn't welcome.)

That's a really interesting idea. Yes, I think it should be possible to define a system-level interface to a process that runs a set of analyzers and communicates entirely over a pipe or socket (and has no other capabilities), without reference to any code in the gopls module.

Some usability advantages of bundling the logic into a single build for checkers:

Developers of checkers don't need to be educated about gopls' (or other tools like gopls) unique requirements.
Developers of checkers only need to build and distribute one binary for folks to use in a variety of places.
Users of checkers don't need to choose between different builds of multicheckers for use in different places.
Users of checkers who use both the regular and gopls multichecker modes in different places do not have to deal with problems such as having different versions of the two binaries leading to inconsistent errors in CI vs IDE vs console. (For an example of where this type of inconsistency pain with IDE vs terminal usage can be so painful, see rust-analyzer and rustc.)

The different places I'm thinking of being:

CI, which would likely use the regular multichecker mode.
IDE, which would likely use the gopls / pipe variety of multichecker mode.
Console/terminal, which would likely use the regular multichecker mode.

I think golangci-lint's new plugin system is worth taking a look at. TL;DR: The main package does almost nothing except call another package, so it's very easy to create a custom golangci-lint build that imports plugins; plus there's a builder tool that will automatically generate a custom main package and add plugin imports based on a config file. Regardless of whether analyzers are moved into a sidecar process, this seems like a promising model for including build-time plugins into a binary. Putting analyzers in a sidecar process seems somewhat orthogonal to custom analyzers to me. Unless each analyzer its its own separate executable (and process), some component would need to be dynamically rebuilt (when configuration updates) regardless of whether that component is a sidecar or gopls.
This is also applicable to the feature I'm working on, #59445. Specifically, it would be helpful to have an extensible mechanism for detecting test suites using 3rd party frameworks:

vscode-go has existing support for stretchr tests.
golang/vscode-go#111
golang/vscode-go#228

@hyangah made the point here https://github.com/golang/vscode-go/issues/228#issuecomment-644846514 that supporting 3rd party frameworks could grow to be a considerable maintenance burden and that extensibility might be a better option. However, it's a lot harder to extend gopls than it is to extend vscode-go (Go vs JavaScript). If an extensibility mechanism is added for analyzers, I'd like to add something similar for this case.

Per in-person discussion, we need to decide whether this has significant advantages over simply making it easier to recompile gopls itself.

gopls seems pretty easy to compile. I just pop over to the tools repo and go install ./gopls whenever I want to test some change. I'm not familiar with other development environments, but at least for vscode-go rebuilding gopls shouldn't be hard.

Regardless of whether analyzers are moved into a sidecar process, this seems like a promising model for including build-time plugins into a binary.

I agree that this is a promising model, and it is certainly the simplest way to support extensible sets of analyzers. It has the advantage that there is only a single executable for gopls plus its analyzers, which simplifies the architecture considerably; however it does mean that users will no longer run the same gopls  executables as each other, or as the one we test in our release process. A sidecar approach could reduce the proportion of code that varies across users.

Unless each analyzer its its own separate executable (and process), some component would need to be dynamically rebuilt (when configuration updates) regardless of whether that component is a sidecar or gopls.

Yes, there is no getting away from that. (BTW, I don't think one executable per analyzer is feasible because each would have to repeat type checking, which is expensive. Ideally we would build one executable containing all analyzers in the workspace, and then tell that executable's process which subset of analyzers to run for each package.)

Putting analyzers in a sidecar process seems somewhat orthogonal to custom analyzers to me.

Part of the promise of dynamically recreating and loading sidecar processes is that gopls (and perhaps other analysis drivers) could automatically run sets of analyzers appropriate to the code being analyzed, with a minimum of configuration. For example, if your application depends on a third-party database and template package, your application's module would be automatically analyzed for mistakes in its database queries and template literals, without any extra action. This is a double-edged sword: it means the std packages are no longer special citizens, and any package can define static checkers that automatically apply to client code; but it also means your module's analysis experience (latency, CPU cost, verbosity) are now partly at the mercy of third-party analyzer maintainers. We would have to define clear norms.

This is a double-edged sword: it means the std packages are no longer special citizens, and any package can define static checkers that automatically apply to client code; but it also means your module's analysis experience (latency, CPU cost, verbosity) are now partly at the mercy of third-party analyzer maintainers.

I assume gopls and/or the sidecar would be able to gather telemetry on the latency and stability (crash rate) of analyzers? gopls could expose that telemetry via a custom command or by opening up a report in the browser, and (I think?) gopls could send a notification to the editor that an analyzer's latency is out of bounds. Giving the user a way to look under the hood and see which analyzers are misbehaving should mitigate the impact of a misbehaving analyzer.

I assume gopls and/or the sidecar would be able to gather telemetry on the latency and stability (crash rate) of analyzers?

Yeah, I was thinking along similar lines, but it's more stuff--measurement, configuration, feedback loops--that we would have to build and maintain.

#48429 (or a minor extension to support go vet -vetool=... in addition to go run) could be a user friendly way to get a sidecars tools for specific modules. It would also be nice to play together with that proposal. There is a lot of overlap with the goals of the two proposals.
But AFAICT that kinda requires a separate process for a gopls analyzers (whether in a sidecar or the main gopls process) and that implies type checking twice to enable this. Thats a definite cost. Maybe we have a protocal for the tool to say which analyzers it can run, and if there is 100% overlap with the Analyzer list that gopls would run, we do not run the gopls analyzers that use types.

It seems like Alan is leaning towards a separate process, because otherwise you'd need to recompile gopls for every different combination of analyzers required by a workspace, which probably would mean recompiling it for every workspace that specifies any custom analyzers. With a sidecar process, only the sidecar would need to be recompiled for each workspace.

[Tim] But AFAICT that kinda requires a separate process for a gopls analyzers (whether in a sidecar or the main gopls process) and that implies type checking twice to enable this.

As a matter of fact, gopls already (necessarily) has two completely separate paths for type checking--one for most features and one for analysis--so it already type-checks some packages twice. So, the net effect on type-checking cost of moving all its analysis logic into a (single) sidecar process would be zero.

Perhaps relevant that in a separate discussion, @aclements reports poor gopls performance when having both the runtime package and a high level package open, because the analysis driver has to reprocess every package in between, making even the VS Code process itself painfully slow to respond.
Having analysis in a separate process might make it easier to decrease the priority of that process.

I strongly suspect the performance problem is that we didn't implement type-check batching in the analysis driver; we should do that, to reduce the amount of export-data parsing.


Performance of _get_series_len

I am having some performance issues with creating fMRIPrep workflows for large datasets. As such, I did some profiling, and found that a lot of time is spent during creation of the workflow in init_func_preproc_wf on doing outlier detection.

As far is I understand, this is to make sure that slice timing correction is only included if a sufficient number of volumes remains after removing non-steady state volumes in init_bold_reference_wf/EstimateReferenceImage. However, if dummy_scans is specified in the configuration, then this check may not be necessary, and workflows could be created twice as fast.
Is my reasoning correct? Would you be interested in me contributing code to make this faster?
https://github.com/nipreps/fmriprep/blob/674124ee80b3e2a8affddf005e910e4ca1c97cc0/fmriprep/workflows/bold/base.py#L221-L225
https://github.com/nipreps/fmriprep/blob/674124ee80b3e2a8affddf005e910e4ca1c97cc0/fmriprep/workflows/bold/base.py#L879-L887
https://github.com/nipreps/niworkflows/blob/11ac7a18a403af717c0c2a29a33b7cadb75eabd7/niworkflows/interfaces/registration.py#L552-L557

Wow, yes. Thanks for this profiling. I didn't think that function would ever be a bottleneck, but let's optimize...

My pull request only fixes this for the maintenance branch. Please let me know if I should also make one for the main branch :-)

We'll merge it. If it would be useful to have it merged sooner than later, we can do it right away.

Ah perfect, I wasn't sure how you normally handle this


JSON parsing error when ECS tries to launch the empire task

Just came across this issue after killing all the ECS instances and creating some fresh ones - each time the empire task starts up I'm getting this logged just before the docker image dies:
2015/08/11 14:18:10 unexpected end of JSON input
Seems to happen on every boot, no matter what instance it runs on. I've been trying to track down what could be causing it but there are no line numbers or anything in the logs. Any thoughts?

Think I just worked it out. I updated the user data for the launch configuration to use ECS_ENGINE_AUTH_TYPE=docker instead of "dockercfg" - I'm guessing that empire requires the file at /home/ec2-user/.dockercfg to be present.
Will close this once I've booted an instance to verify the fix works. If this is in fact the issue, it might be worth documenting somewhere that empire requires you to use dockercfg as ECS mentions you can use either.

Yep that was the issue!


⚠ Bofrost.be has degraded performance

In ab59113, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1612 ms

Resolved: Bofrost.be performance has improved in 05229f0.


Ability to change log levels of MVC log entries

I would like to change the log levels of the MVC log entries so that we don't get spammed in our logs by MVC while still enabling application wide log levels. I've modified the values in appsettings.json/Logging:LogLevels and set them to Debug, but I still see 5 log entries logged at the Information level.

@veccsolutions to silence log messages you can filter by both log level and by category. And categories tend to be hierarchical because they are structured around namespace and type names. So, you could easily silence all logs that start with Microsoft.AspNetCore.Mvc and you won't see any MVC logs.


MB-2594: Domestic origin pricer

Description
This PR creates the domestic origin pricer
Reviewer Notes
To do the math on calculating price you will need to take (WeightBilledActual / 100) *  rate for the service area * escalation compounded. You can find those in the service Item params that are returned by the request and the rate and escalation can be looked up with the following query:
select price_cents, escalation_compounded from re_domestic_service_area_prices dsap
 inner join re_domestic_service_areas sa on dsap.domestic_service_area_id = sa.id
 inner join re_services on dsap.service_id = re_services.id
 inner join re_contracts on re_contracts.id = dsap.contract_id
 inner join re_contract_years on re_contracts.id = re_contract_years.contract_id
 where sa.service_area = '197'
  and re_services.code = 'DOP'
  and re_contracts.code = 'TRUSS_TEST'
  and dsap.is_peak_period = true
  and '2020-07-16' between re_contract_years.start_date and re_contract_years.end_date;

Payload price: 11819
Manual verification price: 11,818.548
Setup
make db_dev_e2e_populate
make server_run
Follow the instructions in the acceptance testing wiki.
Code Review Verification Steps

[ ] Code follows the guidelines for Logging
[ ] The requirements listed in
Querying the Database Safely
have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 91da04b31bc639d2ff6e052d3a17fca7744cf7fd

Just a few nits from a DB perspective:

Your migration name in the manifest is out-of-order based on its timestamp.  That probably won't cause a failure in this case, but could if someone moved it to the right order later and there was a dependency on something happening in another migration.  I think we want to try to keep these in chronological order.
You use both from and FROM (different caps) in the SQL.  Not a problem, just a consistency thing (all caps better in this case).
Generally, you want a semicolon at the end of the SQL statement; I think it's working in this case with our migrator since it's the last statement in the file.

I'd like to see the first one fixed. The other two are up to you.

Thanks Reggie! I addressed all 3


Support for consuming current build Artifacts

This feature is required to validate the BIS documentation as part of the "Pull Request" build. In case of any broken links, the build will fail and the PR will not complete until these links are fixed and build succeeded.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Naveed.Khan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Duplicate SNARKs

https://minasearch.com/snarks?q-state-hash=3NKP5eG9qvMbJM78thgQMvwnNnjrEkfcAfS31YbNNzeBsa8ADqPR

How do you know these are duplicates and not just two SNARKs by the same prover in the same block with the same fee? This is certainly possible

Closing as I can't prove duplication


Using k8s 1.22.2 version

Signed-off-by: Matthias Wessendorf<EMAIL_ADDRESS>Fixes #

Proposed Changes

as per title

Release Note

Docs

/lgtm
/hold please unhold once they are green.

/unhold


Add syntax for Trace[F]

Will conflict with #157. Need to resolve.

BindException was thrown during property evaluation.
[info]     Message: Address already in use

@janstenpickle restart the job please


Provides a drush tool to change field's language.

What's this PR do?

Provides a drush tool to change field's language

Usage example

drush ds-update-field-language field_additional_text_title

Any background context you want to provide?
A tool to fix #5676
What are the relevant tickets?
Fixes #5676

cc @sheyd

code looks :ok: though


No permission to create new file in the mounting point

Mountpoint for Amazon S3 version
mount-s3 1.10.0
AWS Region
us-east-1
Describe the running environment
Running on an EC2 with linux 2023 image against s3 in the same account
Mountpoint options
mount-s3 us.com.syngenta.htp.scv.nonprod /home/EAME/s1082344/scv_bucket --allow-delete --allow-overwrite --gid 676856321 --cache /tmp --dir-mode 0775 --file-mode 0774

What happened?
Mount point successed but I can see all the contents in the mounting point. However, I can only create folder but not creating new files in it.
Relevant log output
No response

Without logs, it's hard to know what's going wrong.
I'd recommend you see what Mountpoint logs report. You can learn more about how to configure and view the logs here: https://github.com/awslabs/mountpoint-s3/blob/main/doc/LOGGING.md


Fix protocol for domain example on website

I finally found a fix for this in another project, just need a reminder to get it done.

JavaScript, I guess?

no

I think this has been fixed since 60387c8c7c028a412deab9c06f0b46d3b5ae8a21, really. It just defaults to https.
Since the node app itself uses http, there's no (good, reliable) way to tell if someone initially accessed a downstream reverse-proxy via https on the back-end. The only thing you can do is check the document protocol via JS.
If someone forks/uses this but doesn't use https, they can still change it use https on their site.


New family request

I have an XCVU33P and would like to see the Virtex Ultrascale+ HBM parts supported!

Ultrascale + Ultrascale+ support is being worked on as part of https://github.com/SymbiFlow/prjuray -- we would love your help with that.

I'd love to help out! Thanks!.


Expose TimeKeeper

Description
The Foundation DB cluster needs to keep track of the cluster timestamp associated to a versionstamp.
Because time is a hard concept to keep coherent, FDB choose to create an actor TimeKeeper which regularly writes into
a special key range the actual timestamp mapped to the versionstamp
timestamp1 => versionstamp1
timestamp2 => versionstamp2
timestamp3 => versionstamp3
...

The actor is unique and as the responsibility to cleanup too old KVs
More information about it there => https://forums.foundationdb.org/t/versionstamp-as-absolute-time/2442/3?u=pierrez
The range is prefixed by \xff\x02/timeKeeper/map/.
https://github.com/FoundationDB/fdb-record-layer/blob/main/fdb-extensions/src/main/java/com/apple/foundationdb/system/SystemKeyspace.java#L80
The Timekeeper will be a struct which provides a static method "versionstamp_hint_after_timestamp"
which will the implementation of https://github.com/FoundationDB/fdb-record-layer/blob/b9fb711c6104b1c519e5d88066ebe2c10b6408f9/fdb-extensions/src/main/java/com/apple/foundationdb/clientlog/VersionFromTimestamp.java#L66
The function will have this signature
impl Timekeeper {
  pub fn versionstamp_hint_after_timestamp(database: Database, timestamp:  Instant) -> Result<Option<VersionStamp>, FDBBindingError>
}

The Option stands for missing versionstamp after.
To do

Create inside the foundationdb crate a new "admin" module "timekeeper"
Create the Timekeeper and expose it

Actor CPP https://github.com/apple/foundationdb/blob/0032465c539daeef7aea060a4d96a379fb38f87d/fdbserver/ClusterController.actor.cpp#L1456


feat: adds guide for collecting cards via Proxy

Description

adds guide for collecting cards via Proxy

Testing required outside of automated testing?

[x] Not Applicable

Screenshots (if appropriate):

Rollback / Rollforward Procedure

[x] Roll Forward
[ ] Roll Back

Reviewer Checklist

[ ] Description of Change
[ ] Description of outside testing if applicable.
[ ] Description of Roll Forward / Backward Procedure
[ ] Documentation updated for Change

:tada: This PR is included in version 1.29.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Revert "Revert "Balder/no more fs4 dispatching from fastsearcher""

Reverts vespa-engine/vespa#10691
system tests had a breakdown -needs to go again

👍


Train on expressions

Hi, voice cloning is working good with bark, is there way of training more expressions in Bark?

I've been doing great with Tortoise TTS using [I am very happy and sad,] Your emotional text
There's variants that have worked for me such as [I am very happy and yelling with excitement,] Your emotional text

I will close the issue for now. Please reopen it if there are more questions.


[IMPROVE] Spawner Item in menu

option to turn off the default message displayed at the spawner item
https://imgur.com/a/JbPy8XZ

You should be able to hide it by adding the following flag:
item_flags:
- HIDE_POTION_EFFECTS

Don't ask me why it is named like that because spigot gave it the name not us.


Azure.Messaging.EventHubs Readme issues

Section link

Suggestion:
Update link to  https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/eventhub/Azure.Messaging.EventHubs/src

Section link

Reason:
producerClient  is not defined.
Suggestion:
Update producer to producerClient.

Section link

Suggestion:
Remove  extra script.
@jongio for notification.

Fixed by: #15336


Fix running tags on Windows

@nickdunn  cool, thanks! I don't have windows handy to verify, but I trust you did and it works, right? :)

I see the linting fails - could you please run npm run fixStyle  and push?

This morning I've been working through trying to get this running in Jenkins on a Windows box and we isolated it down to this issue. Our build is now building/passing using my fork, so I'm comfortable that this fix works :-)

How soon do you think a new version could be pushed out to npm?

shoot, it should happen automatically but I forgot to add a fix: prefix to the commit message

I will merge this one https://github.com/TheBrainFamily/cypress-cucumber-preprocessor/pull/176/files and it will release a new version with both changes, I need up to an hour

Brilliant, thank you! I'll keep looking out for it.

:tada: This PR is included in version 1.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Unable to preview pdf in Outlook

Microsoft PowerToys version
0.56.1
Running as admin

[ ] Yes

Area(s) with issue?
PDF Preview
Steps to reproduce
Outlook reports that there is no preview handler when the setting in "File Explorer add-ons" is enabled "Enable PDF (.pdf) preview".
For me, the problem was solved by changing the setting in Powertoys. Under "File Explorer add-ons", try to disable "Enable PDF (.pdf) preview"
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
Office 365

Duplicate of #14283

Issue is a duplicate
Thank you for your issue! We've linked your report against another issue to centralize the thread.
Thanks for helping us to make PowerToys a better piece of software.


Virtio-FS Windows service crashes

Describe the bug
The Virtio-FS Windows service crashes, resulting in the disk being inaccessible and no longer visible. No data is accessible.
To Reproduce

Start service through services.msc -> (Service name) -> Properties, set "Start Parameters" to -d -1 -D C:\viofs.log -m X: for debugging.
Run copy X:\FolderName\Filename C:\Users\Me\Desktop\

Powershell shows the following:
copy : The operation was canceled.
At line:1 char:1
+ copy Z:\FolderName\Filename C:\Users\Me\Desktop\
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Copy-Item], OperationCanceledException
    + FullyQualifiedErrorId : System.OperationCanceledException,Microsoft.PowerShell.Commands.CopyItemCommand

Once this happens, the drive letter vanishes from Explorer, Windows Event Viewer shows that the service has crashed and services.msc shows that the service is no longer running.
The problem isn't limited to Powershell. Opening any file causes the crash, as does opening any folder aside from the root.
I've tried <source type='memfd'/> in case hugepages were an issue but the problem persists.
I've tried setting permissive permissions on files and directories but no luck there either.
Expected behavior
File copy succeeds, data can otherwise be interacted with.
Screenshots

Windows service log
Windows Event Viewer log for service crash
virtiofsd log

Host:

Distro: Arch Linux
Kernel version Linux Starlight 5.15.34-1-lts #1 SMP Thu, 14 Apr 2022 05:08:35 +0000 x86_64 GNU/Linux
QEMU version 6.2.0-4
QEMU command line/usr/bin/qemu-system-x86_64 -name guest=win10-new,debug-threads=on -S -object {"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain-1-win10-new/master-key.aes"} -blockdev {"driver":"file","filename":"/usr/share/ovmf/x64/OVMF_CODE.fd","node-name":"libvirt-pflash0-storage","auto-read-only":true,"discard":"unmap"} -blockdev {"node-name":"libvirt-pflash0-format","read-only":true,"driver":"raw","file":"libvirt-pflash0-storage"} -blockdev {"driver":"file","filename":"/var/lib/libvirt/qemu/nvram/win10-new_VARS.fd","node-name":"libvirt-pflash1-storage","auto-read-only":true,"discard":"unmap"} -blockdev {"node-name":"libvirt-pflash1-format","read-only":false,"driver":"raw","file":"libvirt-pflash1-storage"} -machine pc-i440fx-6.2,usb=off,vmport=off,dump-guest-core=off,pflash0=libvirt-pflash0-format,pflash1=libvirt-pflash1-format,memory-backend=pc.ram -accel kvm -cpu host,migratable=on,topoext=on,hv-time=on,hv-relaxed=on,hv-vapic=on,hv-spinlocks=0x1fff,hv-vendor-id=whatever,kvm=off -m 16384 -object {"qom-type":"memory-backend-file","id":"pc.ram","mem-path":"/dev/hugepages/libvirt/qemu/1-win10-new","share":true,"x-use-canonical-path-for-ramblock-id":false,"prealloc":true,"size":17179869184} -overcommit mem-lock=off -smp 20,sockets=1,dies=1,cores=10,threads=2 -object {"qom-type":"iothread","id":"iothread1"} -uuid <redacted> -display none -no-user-config -nodefaults -chardev socket,id=charmonitor,fd=32,server=on,wait=off -mon chardev=charmonitor,id=monitor,mode=control -rtc base=localtime,driftfix=slew -global kvm-pit.lost_tick_policy=delay -no-hpet -no-shutdown -global PIIX4_PM.disable_s3=1 -global PIIX4_PM.disable_s4=1 -boot menu=on,splash-time=1000,strict=on -device qemu-xhci,p2=8,p3=8,id=usb,bus=pci.0,addr=0x3 -chardev socket,id=chr-vu-fs0,path=/var/lib/libvirt/qemu/domain-1-win10-new/fs0-fs.sock -device vhost-user-fs-pci,id=fs0,chardev=chr-vu-fs0,tag=pics,bus=pci.0,addr=0xa -netdev tap,fds=<redacted>,id=hostnet0,vhost=on,vhostfds=<redacted> -device virtio-net-pci,mq=on,vectors=18,netdev=hostnet0,id=net0,mac=<redacted>,bus=pci.0,addr=0x2 -audiodev {"id":"audio1","driver":"none"} -device vfio-pci,host=0000:2e:00.0,id=hostdev0,bus=pci.0,addr=0x4,romfile=/var/lib/libvirt/3070.bin -device vfio-pci,host=0000:2e:00.1,id=hostdev1,bus=pci.0,addr=0x5 -device vfio-pci,host=0000:24:00.0,id=hostdev2,bus=pci.0,addr=0x6 -device vfio-pci,host=0000:30:00.3,id=hostdev3,bus=pci.0,addr=0x7 -device vfio-pci,host=0000:43:00.0,id=hostdev4,bootindex=1,bus=pci.0,addr=0x8 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x9 -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny -msg timestamp=on

libvirt version 8.2.0
libvirt XML file win10-new.txt

VM:

Windows version or commit hash that was used to build the driver: virtio-win-0.1.217
Which driver has a problem: viofs.sys
Driver version: virtio-win-0.1.217

I see your vhost-user-fs-pci device has no queue-size=1024 parameter, could you have a try with it?
There is an existed bug about it.


packagegroup-qt5: Mark it as TUNE_PKGARCH

Fixes
ERROR: packagegroup-qt5-1.0-r0 do_package_write_ipk: An allarch packagegroup shouldn't depend on packages which are dynamically renamed (qtsensors-dev to libqt5sensors-dev)
ERROR: packagegroup-qt5-1.0-r0 do_package_write_ipk: An allarch packagegroup shouldn't depend on packages which are dynamically renamed (qtsvg-dev to libqt5svg-dev)
ERROR: packagegroup-qt5-1.0-r0 do_package_write_ipk: An allarch packagegroup shouldn't depend on packages which are dynamically renamed (qtsensors to libqt5sensors5)
ERROR: packagegroup-qt5-1.0-r0 do_package_write_ipk: An allarch packagegroup shouldn't depend on packages which are dynamically renamed (qtsvg to libqt5svg5)
ERROR: packagegroup-qt5-1.0-r0 do_package_write_ipk: An allarch packagegroup shouldn't depend on packages which are dynamically renamed (qtsvg-plugins to libqt5svg-plugins)
Signed-off-by: Khem Raj<EMAIL_ADDRESS>

Thanks


Fix success? call

well the HI one didn't fail because it was not deployed :)

LGTM. Will accept pending your thoughts on this question: Might make sense to ask that they all succeeded rather than just the first one? I know each of the aggregators essentially checks that @total_errors == 0 but it's possible in the future that could be different -- e.g., SlackAggregator could fail in the notification doesn't go out.
Will have to update products to reference new gem version :-(

@mccolin yeah, i think that makes sense. i'll update this, and then can bump the other apps


Issues in executing mysql scripts of AM table.

Description:
In the latest stable pack when executing the API management MySQL DB scripts ($APIM_HOME/dbscripts/mysql.sql), errors encountered.
ERROR 1067 (42000) at line 1512 in file: 'wso2am-4.0.0-SNAPSHOT/dbscripts/apimgt/mysql.sql': Invalid default value for 'UPDATED_TIME'.
This is encountered due to the UPDATED_TIME TIMESTAMP column of the AM_API_COMMENTS table.
When changing UPDATED_TIME TIMESTAMP DEFAULT NULL  to  UPDATED_TIME TIMESTAMP DEFAULT CURRENT_TIMESTAMP in the scripts this error get resolved.
Steps to reproduce:
Run the MySQL scripts in $APIM_HOME/dbscripts/apimgt/mysql.sql
Affected Product Version:
APIM 4.0.0
Environment details (with versions):

OS: Ubuntu 18.04
Mysql : mysql Ver 14.14 Distrib 5.7.33

This is already fixed in master hence closing the issue
https://github.com/wso2/carbon-apimgt/blob/master/features/apimgt/org.wso2.carbon.apimgt.core.feature/src/main/resources/sql/mysql.sql#L1511

Seems the issue still persists.

Fixed this in this PR


core/lib/CloudFrontDistributionForApiGateway function bug

https://github.com/awslabs/aws-solutions-constructs/blob/ccf819c99a907634cc78de26cca07d77eb748656/source/patterns/%40aws-solutions-constructs/core/lib/cloudfront-distribution-helper.ts#L119-L125
The above source code has a bug. No matter what parameter is provided to httpSecurityHeader, _httpSecurityHeaders would be true.

This is :bug: Bug Report

I guess the idea was to do an undefined check. This is currently messing up using this solution for a different region than us-east-1, because the edge lambda association fails.

This has been addressed in the latest release v1.54.0


[Improvement] Stop python tasks should add wait time for graceful shutdowns

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
When stopping a python task, the event action captured by singal is not performed。The python code is：
signal.signal(signal.SIGTERM, handler)
signal.signal(signal.SIGINT, handler)
The source code uses kill first, and immediately determines whether the process exists, and if it does, performs kill -9.
    // kill , waiting for completion
    boolean alive = softKill(processId);

    if (alive) {
        // hard kill
        hardKill(processId);
    }

Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Maybe we can add a configurable kill timeout for task definition/instance.


MAC unbinding is not happening  when terraform destroy is performed

network_interface {
network_name = "default"
wait_for_lease = "true"
}
when we use wait_for_lease  mac-binding works (able to see the mac entry)
.But mac-binding entry is not getting removed when terraform destroy is performed
 <network>
  <name>default</name>
  <uuid>376edc07-e4aa-4cb5-a752-a95f5af87c38</uuid>
  <forward mode='nat'>
    <nat>
      <port start='1024' end='65535'/>
    </nat>
  </forward>
  <bridge name='br0' stp='on' delay='0'/>
  <mac address='48:df:37:89:e8:55'/>
  <dns enable='no'/>
  <ip family='ipv4' address='<IP_ADDRESS>' prefix='23'>
    <dhcp>
      <range start='<IP_ADDRESS>' end='<IP_ADDRESS>'/>
      <host mac='52:54:00:42:A7:7D' name='libvirt-Lukjvf' ip='<IP_ADDRESS>'/>
      .232.50'/>
    </dhcp>
  </ip>
  <route address='<IP_ADDRESS>' prefix='23' gateway='<IP_ADDRESS>'/>
</network>

localhost:~ # virsh version
Compiled against library: libvirt 6.0.0
Using library: libvirt 6.0.0
Using API: QEMU 6.0.0
Running hypervisor: QEMU 4.2.0**
Terraform v0.12.24

@MalloZup / @dmacvicar  any updates on the issue

I have the same problem.

I can trace this behavior of adding the MAC entry to f6a85
I don't really know why we are adding the MAC to the network host list. If a network card specifies DHCP, it has nothing to do with the network configuration, which should be done in the network resource.
The current network resource tries to do lot of magic, and I'd prefer to focus efforts in finishing network_v2 which follows a schema/behavior closer to libvirt.
That said, I will gladly accept patches. I'd guess a function similar to addOrUpdateHosts in the domain destroy hook should do it.


Collision shape

Add CollisionShape2D to Player node
Add RectangleShape2D to CollisionShape2D
Modify AnimatedSprite2D Offset to (0, -5)