[SPARK-35705][PYTHON] Adjust pandas-on-spark test_groupby_multiindex_columns test for different pandas versions

What changes were proposed in this pull request?

Adjust pandas-on-spark test_groupby_multiindex_columns test in order to pass with different pandas versions.
Why are the changes needed?

pandas had introduced bugs as below:

For pandas 1.1.3 and 1.1.4
Type error: only integer scalar arrays can be converted to a scalar index

For pandas < 1.0.4
Type error: Can only tuple-index with a MultiIndex

We ought to adjust test_groupby_multiindex_columns tests by comparing with a predefined return value, rather than comparing with the pandas return value in the pandas versions above.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Unit tests.

Test build #139599 has started for PR 32851 at commit 43b30bd.

Test build #139599 has finished for PR 32851 at commit 43b30bd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44126/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/139599/

CC @ueshin @HyukjinKwon @itholic

Merged to master.

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44126/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44126/


Home page issue

Hi there,
loving this theme, thanks for the work!
I'm having an issue where i have a home defined:
[[menu.main]]
name = "Home"
identifier = "home"
weight = 100
url = "/"
I also have an empty index.md file
However the index.html layout is not loading?
I'd like a home page that shows the most recent blog posts.
Any help on how to fix this would be appreciated

Hi just an update my website is hosted here: https://adamjones.website/
I would like my "About" page to appear automatically when the websites starts, but if i create a index.md and add the markdown from my about page, the site navigation fails?

Hey,
A quick update.
Setting type: post on my posts fixed this issue.
The index page now appears correctly listing  my latest blog posts.
I'd still be interested to know if i could remove that and just have a satic text page as the default root page though.
Thanks

Hi Adam,
anatole comes with a custom archtype called post. If you create a new post by issuing the following command 'hugo new post\foo.md' it will be of type post.
Do I understand you correctly, that you want to use another site other than the index.html as your homepage? (Like your about site)


cigien: Watch (?-i:SuperfasteasyAirdrop)(?#t.me)

cigien requests the watch of the watch_keyword (?-i:SuperfasteasyAirdrop)(?#t.me). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

(?-i:SuperfasteasyAirdrop)(?#t.me) has been seen in 1 true positive, 0 false positives, and 0 NAAs.

(?-i:SuperfasteasyAirdrop)(?#t.me) has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ

Approved by Spevacus in Charcoal HQ


Update how-to-upgrade-using-dump-and-restore.md

psql should have dbname(database name) specified.

@yosaeki : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

Merging with PM @kabharati approval; thanks for the review.


Float degree rotation (Help wanted)

In my project I wanted to use this cropper, and I think it's cool, but I really need to rotate image to float degree, and right now can't imagine how to do it right. Any suggestions? Thanks.

You mean that rotation by 5 degrees is not fine enough, you want by 5.6 degrees?
Not sure what kind of UX will support it..
Also, rotation by non-straight angles support is currently problematic, will improve it in a week or two.

Well, OK thanks for the answer.


Symbol "INCOMPLETE-GAMMA" not found in the SPECIAL-FUNCTIONS package.

System: MacMini late 2014,  Monterey OS
~ 532>sbcl
This is SBCL 2.4.7, an implementation of ANSI Common Lisp.
More information about SBCL is available at <http://www.sbcl.org/>.

SBCL is free software, provided as is, with absolutely no warranty.
It is mostly in the public domain; some portions are provided under
BSD-style licenses.  See the CREDITS and COPYING files in the
distribution for more information.
* (ql:quickload :lisp-stat)
To load "lisp-stat":
  Load 1 ASDF system:
    lisp-stat
; Loading "lisp-stat"
..............Library #P"/Users/roffe/quicklisp/dists/quicklisp/software/cephes.cl-20231021-git/scipy-cephes/libmd-x86-64.dylib" exists, skipping build
;
; caught ERROR:
;   READ error during COMPILE-FILE:
;
;     Symbol "INCOMPLETE-GAMMA" not found in the SPECIAL-FUNCTIONS package.
;
;       Line: 70, Column: 29, File-Position: 2705
;
;       Stream: #<SB-INT:FORM-TRACKING-STREAM for "file /Users/roffe/quicklisp/dists/quicklisp/software/distributions-20221106-git/src/gamma.lisp" {1002788B53}>

debugger invoked on a UIOP/LISP-BUILD:COMPILE-FILE-ERROR in thread
#<THREAD tid=259 "main thread" RUNNING {1003F90143}>:
  COMPILE-FILE-ERROR while compiling #<CL-SOURCE-FILE "distributions" "gamma">

Type HELP for debugger help, or (SB-EXT:EXIT) to exit from SBCL.

restarts (invokable by number or by possibly-abbreviated name):
  0: [RETRY                        ] Retry
                                     compiling #<CL-SOURCE-FILE "distributions" "gamma">.
  1: [ACCEPT                       ] Continue, treating
                                     compiling #<CL-SOURCE-FILE "distributions" "gamma">
                                     as having been successful.
  2:                                 Retry ASDF operation.
  3: [CLEAR-CONFIGURATION-AND-RETRY] Retry ASDF operation after resetting the
                                     configuration.
  4:                                 Retry ASDF operation.
  5:                                 Retry ASDF operation after resetting the
                                     configuration.
  6: [ABORT                        ] Give up on "lisp-stat"
  7: [REGISTER-LOCAL-PROJECTS      ] Register local projects and try again.
  8:                                 Exit debugger, returning to top level.

(UIOP/LISP-BUILD:CHECK-LISP-COMPILE-RESULTS NIL T T "~/asdf-action::format-action/" ((#<ASDF/LISP-ACTION:COMPILE-OP > . #<ASDF/LISP-ACTION:CL-SOURCE-FILE "distributions" "gamma">)))
   source: (ERROR 'COMPILE-FILE-ERROR :CONTEXT-FORMAT CONTEXT-FORMAT
                  :CONTEXT-ARGUMENTS CONTEXT-ARGUMENTS)

Quicklisp has been slow to update as of late and it's likely that the version there is out of date.  Try two things:

Load special-functions on it's own, (ql:quickload :special-functions) and see what happens
Update special-functions, and possibly other libraries, from their source repositories

special-functions isn't required any longer and cephes.cl is recommended, so in the worse case just comment out the special-functions dependency in the ASD file -- but, best is to sync with the current sources.

Just loading special-functions first worked! :)
Thank you.


Pointer size fix

This fixes issue #478
Basically it implements GetOSPointerSize() in a way that works around bugs see $478 for more
It also removes some unused ifdefs.

Codecov Report

Merging #576 into master will increase coverage by <.01%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   17.49%   17.49%   +<.01%
==========================================
  Files         215      215
  Lines      124698   124703       +5
  Branches    12032    12031       -1
==========================================
+ Hits        21818    21822       +4
  Misses     102016   102016
- Partials      864      865       +1

Flag
Coverage Δ

#2017
17.49% <44.44%> (ø)
:arrow_up:

#Debug
17.49% <44.44%> (ø)
:arrow_up:

#Release
100% <ø> (?)

Impacted Files
Coverage Δ

src/TraceEvent/TraceEventNativeMethods.cs
26.53% <ø> (ø)
:arrow_up:

src/TraceEvent/ZippedETL.cs
21.22% <ø> (ø)
:arrow_up:

src/TraceEvent/TraceEvent.cs
63.83% <ø> (ø)
:arrow_up:

src/TraceEvent/ETWReloggerTraceEventSource.cs
0% <0%> (ø)
:arrow_up:

src/TraceEvent/TraceLog.cs
61.26% <0%> (+0.01%)
:arrow_up:

src/TraceEvent/ETWTraceEventSource.cs
47.6% <57.14%> (+0.26%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ed309f...c512416. Read the comment docs.

@Alois-xx  before submitting this, I if it is easy for you to test that this fixes your issue, I would appreciate you doing that test (if that is hard, at least you should confirm that it will work in theory)

@vancem: I will take a look tomorrow.

@vancem: The pointer size issue is fixed with that one. But I have noticed that the exception handling does not work out with an older fix where I have proposed a event to get notified when ETW tracing could no be started.
Tracelog.cs
            if (TraceLog.rawKernelEventSource != null)                 {                     kernelTask = Task.Factory.StartNew(delegate                     {                         TraceLog.rawKernelEventSource.Process();                         TraceLog.rawEventSourceToConvert.StopProcessing();                     });                     kernelTask.Start();                 }
a) If on Win7 two instances are started I never get an exception back because .Process will never be called at all.
b) The current Task based code does not work because you call Task.Factory.StartNew and you then call start again where the task will then throw a Task Already started exception. Looks like this was never tested.


feat(core): update to fxmanifest + remove useless stuff server side

This does not work

You removed code that was needed :(


[FLINK-8547][network] Implement CheckpointBarrierHandler not to spill data for exactly-once

What is the purpose of the change
Currently in exactly-once mode, the BarrierBuffer would block inputs with barriers until all inputs have received the barrier for a given checkpoint. To avoid back-pressuring the input streams which may cause distributed deadlocks, the BarrierBuffer has to spill the data in disk files to recycle the buffers for blocked channels.
Based on credit-based flow control, every channel has exclusive buffers, so it is no need to spill data for avoiding deadlock. Then we implement a new CheckpointBarrierHandler for only buffering the data for blocked channels for better performance.
And this new CheckpointBarrierHandler can also be configured to use or not in order to rollback the original mode for unexpected risks.
Brief change log

Implement the new CreditBasedBarrierBuffer and CreditBasedBufferBlocker for buffering data in blocked channels in exactly-once mode.
Define the parameter taskmanager.exactly-once.blocking.data.enabled for enabling the new handler or not.

Verifying this change
This change added tests and can be verified as follows:

Added tests for the logic of CreditBasedBarrierBuffer
Added tests for the logic of CreditBasedBufferBlocker

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (yes)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@pnowojski , thanks for reviews!
I understand your concerns and I should deduplicate some common utils in these tests. I will do that tomorrow together with other comments!

@pnowojski , I have submitted a separate commit to address above comments.

@pnowojski , thanks for suggestions and I totally agree with that.
That abstraction indeed makes the code simple.  I will update the codes ASAP.

@pnowojski , I have submitted the updates for above comments.

Thanks for rebasing the conflicts.
Yes, the default value can be changed to true after the credit-based is totally merged. If need any changes on my side after all, pls let me know. :)

@pnowojski , I have changed the EXACTLY_ONCE_BLOCKING_DATA_ENABLED as true and squashed the commits.


This is awesome.

Thanks for making it.

Glad you like it. Let me know if you run into any bugs. :)


solid: get everything up to date

i think its wip, will check later, could be wrong and its ready.


refactor

Deleting unnecessary stuff

Coverage increased (+0.1%) to 10.281% when pulling 1521ad612104a83955f258b2a5060cd585b5a310 on refactorSlim into b09a364bc59944831fb6bb10ea0091b79c326bda on master.


Add GDCR in Pamplona

Adds a GDCR event in Pamplona.
It will be hosted and sponsored by @Openbravo.

Looks good, welcome!


Being able to set environment variables using 'envFrom'

What was changed
Add the ability to define environment variables that come from configmaps or secrets
Why?
Make use of envFrom is pretty handy when, for instance you have all the environment variables defined in Secrets or Configmaps.
That way we only need to have this bit of code if we have all the config env vars in a secret
web:
  additionalEnvSecret:
    - "temporal-web-envvars"

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

What about this PR? Do you need anything else?

+1 to that.
@SmaineTF1 could you please fix the semgrep, so that @XaF @underrun or @mindaugasrukas can merge it?

@sgrzemski sorry, I'm confused but what should I do for that check? This is not obvious to me :/

@SmaineTF1 :

Sorry, I thought it was in a failed state, but it's just queued to be triggerred manually.

I'm going to close this PR due to inactivity. Please re-open if you'd like to continue the process.


ParsingException: Unknown vox version: 200 expected 150

I guess this library no longer works?
Trying to load a file I just created with latest version gives this error message:

ParsingException: Unknown vox version: 200 expected 150

yeah, I've not really been maintaining this.... also the file format spec is outdated: https://github.com/ephtracy/voxel-model/blob/master/MagicaVoxel-file-format-vox.txt
I've asked if we can have an update: https://twitter.com/gromgull/status/1767634680323428679

Ah seems @midstreeeam has a more updated version here: https://github.com/midstreeeam/MidVoxIO

https://github.com/midstreeeam/MidVoxIO/issues/3

Thanks for the info!
I've tried the MidVoxIO library and it appears to work for version 200 with that small parsing change. Well enough for my purposes anyway.


Yttrium data not interpolating correctly

The interpolator is not successfully changing from the linear to cubic spline for this data. May be a problem with how the edges are handled.

Seems to have been a problem with oscillations in the cubic spline interpolation. Changed interpolation from cubic spline to Pchip in commit c3a84a8. Removes oscillations in interpolated data. Not clear if this is the best option, but seems to result in better interpolation of data.
Should compare interpolation to XCOM source code.


Introduce rotate-credentials-{start,complete} operation annotations

How to categorize this PR?

/area security
/kind enhancement
What this PR does / why we need it:
This PR introduces new rotate-credentials-{start,complete} operation annotations for Shoots which can be used to start or complete the rotation of all Gardener-provided/Gardener-generated credentials.
Which issue(s) this PR fixes:
Related to #3292
Release note:

There are two new `rotate-credentials-{start,complete}` operation annotations for `Shoot`s which can be used to start or complete the rotation of all Gardener-provided/Gardener-generated credentials.

/assign @shafeeqes @kris94

/lgtm

/milestone v1.48


Creating a Jar with conf files not working

I have been trying to create a Jar file with application.conf files inside the jar. But unfortunately, seems the .conf files are not being included in the final jar. Here is my BuildSettings.scala file:

object BuildSettings {

  lazy val basicSettings = Seq[Setting[_]](
    organization  := "com.my.project",
    version       := "0.1.0-SNAPAHOT",
    description   := "sample preparation",
    scalaVersion  := "2.11.7",
    scalacOptions := Seq("-deprecation", "-encoding", "utf8"),
    resolvers     ++= Dependencies.resolutionRepos
  )

  // sbt-assembly settings for building one fat jar
  import sbtassembly.Plugin._
  import AssemblyKeys._
  lazy val sbtAssemblySettings = assemblySettings ++ Seq(

    jarName in assembly := {
      name.value + "-" + version.value + ".jar"
    },

    // META-INF discarding
    mergeStrategy in assembly <<= (mergeStrategy in assembly) { (old) =>
       {
         case "application.conf" => MergeStrategy.concat
         case PathList("META-INF", xs @ _*) => MergeStrategy.discard
         case x => MergeStrategy.first
       }
    }
  )

  lazy val buildSettings = basicSettings ++ sbtAssemblySettings
}

What should I do to include the conf folder? Here is my project structure:
MyProject
-src

main

mypackages and source files
conf // contains application.conf, application.test.conf and so on

test
-project // contains all the build related files
README.md

Try place them under src/main/resources


[x] website builds and runs in production - for information on how to test locally go here.

Description

Hey, we recently published a tutorial on making a MERN stack application cloud native using appsody (https://developer.ibm.com/tutorials/make-your-mern-stack-application-cloud-native-with-appsody/) and thought it would be great to have it on the appsody website as well.

@SueChaplain It would be great to get a quick review from you on this.

Should also add, my Kubernetes is so messed up on my laptop and I'm not sure how to fix it, so I was only able to run through the first half of the tutorial


Only for test.

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run external

run external

run external

run buildall


Create Pie Chart in reading section

Description
Now that we have a working skeleton for Lab 8, we should fill in reading section fully. Add a pi chart that has to deal with machine learning.
Acceptance Criteria

[ ] Have statistics taken from credible resources
[ ] Make sure when its added to datagrip everything else renders successfully

https://docs.google.com/document/d/1-9SOVWuRQK6nu709mwYyKqMptJntrEgnLwtGYAU0QA4/editJaden's sources

The pie chart looks great, the color scheme looks great and is accessible and the data is great. Good job!


[Enhancement]: Add a DNN_Platform.local-sample.build to make setup easier

Is there an existing issue for this?

[X] I have searched the existing issues

Description of problem
It's really hard to get started building DNN. Especially the step with the build-target local is really hard to figure out.
Description of solution
Create a sample file called DNN_Platform.local-sample.build containing a template and instructions.
This would be the contents
<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <!--
    *** Background ***
    This file is a sample for your own "DNN_Platform.local.build" file.
    Read about it in the readme: https://github.com/dnnsoftware/Dnn.Platform/blob/develop/.github/BUILD.md

    *** Instructions ***
    1. Copy this file in this folder, but rename the copy to "DNN_Platform.local.build".
    2. Customize the target path below to match your local environment.
  -->
  <PropertyGroup>
    <WebsitePath Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">C:\Projects\dnn\dnn-09\Website</WebsitePath>
  </PropertyGroup>
</Project>

Description of alternatives considered
No response
Anything else?
No response
Do you be plan to contribute code for this enhancement?

[X] Yes

Would you be interested in sponsoring this enhancement?

[ ] Yes

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Sounds good to me. I wanted to make some sort of wizard on the build scripts to guide people through steps according to what they plan to do, but never found the time to do so.


Refactor Mantaray notebooks to squid -> keeper 0.6

Pending release of squid-py!

Refactor against squid 0.4.2 complete.


Refactor: Mail sending

progress #378
Note that this stops saving a Message for overdue applications to lenders (the associated application was random, and there are already Messages for the overdue applications to OCP). I forgot to include this in the commit message.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

114 of 122 (93.44%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 86.243%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

app/routers/users.py
1
2
50.0%

app/mail.py
95
102
93.14%

Totals

Change from base Build<PHONE_NUMBER>1:
0.02%

Covered Lines:
1818

Relevant Lines:
2108

💛  - Coveralls


(PUP-6410) puppet/util/plist should handle malformed plist data

CFPropertyList::List.new() can raise "NoMethodError: undefined method `elements' for nil:NilClass" if the data to parse isn't a valid (e.g., zero-length or not a plist).

Catch NoMethodError in parse_plist
explicitly return convert_cfpropertylist_to_native_types()
add a 'return nil' at the end of read_plist_file so callers won't end up with the return value of Puppet.warning(...) if things fall through.

CLA signed by all contributors.

:+1: Thanks @ccaviness!


Question(Pipeline): Should  run onLast with same context with other middlewares?

const createCurrentCounter = (hooks: Hooks, onLast?: (input: I) => O) => {
    return createCounter<I, O>((index, input, next) => {
      if (index >= middlewares.length) {
        if (onLast) return onLast(input)
        throw new Error(`Expect returning a value, but all middlewares just calling next()`)
      }

      const middleware = middlewares[index]
      const result = runHooks(() => middleware(input, next), hooks)

      return result
    })
  }

All middlewares run with runHooks but the onLast is not, is it a feature or could improve?

It could be improved as an opt-in feature when calling pipeline.run(context, options)

Emm, why is it a opt-in feature?

Just like this.
const createCurrentCounter = (hooks: Hooks, onLast?: (input: I) => O) => {
    return createCounter<I, O>((index, input, next) => {
      if (index >= middlewares.length) {
        if (onLast) return runHooks(() => onLast(input), hooks)
        throw new Error(`Expect returning a value, but all middlewares just calling next()`)
      }

      const middleware = middlewares[index]
      const result = runHooks(() => middleware(input, next), hooks)

      return result
    })
  }

Yes, it can be a default setting, I mean we should offer an option to enable or disable.


Support plugin docs auto generation

Support plugin docs auto generation.
My idea is to generate a README.md for plugin based on two inputs:

plugins/*/README.adoc,  and
the auto generated help doc by package github.com/spf13/cobra/doc

/assign

@maximilien FYI

I create a golang util to generate README.md for a plugin which includes a generated Usage part in the middle of a header and a footer. The content of header and footer are reading from docs/header.md and docs/footer.md. @maximilien and I will use this util to generate README.md for eventing source plugins.
Since the repo client-contrib is not a go module. I'm not able to find a place to put this golang util which could be shared by all plugins. I have to put it to kn-source-pkg, which is a private repo. I'm seeking advice to contribute this util to some place of Knative, maybe to knative/client/lib.


Zapier doc updates

Minor updates including:

work around to "Is Trusted" bug
Deauthorizing Zapier

Tweaked, thanks!

Pushing this one in as the updated instructions are needed for Zapier to test our app. Leaving the 2nd review label on.


[Popover] On mobile Chrome while zoomed, opening popover causes page to jump

[x] The issue is present in the latest release.
[x] * I have searched the issues of this repository and believe that this is not a duplicate.

* There's an open issue related to IconMenu for iOS devices, but this is not the same component, and also no longer exclusive to iOS devices but happens on Android also.
Current Behavior 😯
On mobile Chrome, while the page is slightly zoomed, opening the popover will cause it to open but will also cause the page to scroll itself up into a position in which the popover can no longer be visible.
Also, while being in that position, the scrolling/zooming of the page is disabled and the only interaction allowed is to tap the invisible backdrop in order for the popover to close.
The issue does not happen on the root component (Modal) which leads us to believe that this may be an issue with the calculation of the anchor position, but we're not 100% sure.
We have also tested all the combinations of disableAutoFocus, disableEnforceFocus and disableRestoreFocus for the root modal props, but to no effect.
The issue only happens on the actual mobile device, using the desktop Chrome Devtools to emulate the issue was unsuccessful.
Expected Behavior 🤔
Expected the popover to open and for the page to stay in the same scroll position regardless of the current zoom level in order for the popover content to be visible, also expected to be able to at least drag the viewport in order to reach the relevant popover after the jump (solved it by overriding the touch-action: none css for the backdrop, but was confused by its default value)
Steps to Reproduce 🕹
The issue can be reproduced on the material-ui popover component demo website: https://material-ui.com/components/popover/
Including video of the interaction described in the steps below: https://drive.google.com/file/d/12MLICM7nngPuthRaVhXurLLkKq1212PK/view
Steps:

Browse on mobile Chrome to https://material-ui.com/components/popover/

Detect the "Simple Popover" demo section, slightly zoom in (device pinch) so that the "Open Popover" button is still visible.

Click the "Open Popover" button

At this point, the popover is open but the page already scrolled itself up

Context 🔦
We've been using material-ui for our project for quite some time and are very pleased by it. Due to the nature of our project, mobile support has been minimal but users that wished to browse through mobile generally had no difficulties to pan/zoom in order to move around the page.
We made heavy usage of modals, popovers and dialogs, but the current issue prevents users from completing simple actions.
We believe that the issue is quite new and that the new Chrome mobile version might also have something to do with it.
Your Environment 🌎
Our local environment is a bit outdated (React v16.7 & material-ui v3.7.0) but the issue occurs even on the demo website, which leads us to believe that the issue is consistent even on the latest version.

Tech
Version

Material-UI
v4.4.3 (latest)

React
v16.8.0+ (latest)

Browser
Google Chrome (mobile) 77.0.3865.92

Device
OnePlus 6 (ONEPLUS A6003), but happens on all of the Android and iOS devices we had a chance to test

@ilyamerman Thank you for reporting the issue, I can reproduce it. I might have ready seen it a few months ago.
I'm not sure this issue is impacting enough users to justify Material-UI investing a lot of resources in it. However, I think that we have an opportunity to see bigger and solve #17353, #17636, and #9802 at the same time. The Material Design specification seems to have given up on the idea of content anchor, it accounts for a large part of the Popover sources. If we also give up on it, we might be able to use the Popper component to position the Popover and allow scrolling. So we should be able to allow scrolling with the Menu and Select component. The only cons I'm aware of of is the smaller set of position we would support. Also, if we are willing to support 12 instead of 81 positions, we can further simplify the logic.
@mui-org/core-contributors What do you think of the idea?

@ilyamerman Thanks for taking the time to submit a thorough issue report!

The Material Design specification seems to have given up on the idea of content anchor

@oliviertassinari Any context for that? I didn't know where to look for what changed.

Any context for that? I didn't know where to look for what changed.

@mbrookes Sure!
The current implementation of the Popover inherits the specification from https://material.io/archive/guidelines/components/menus.html#menus-behavior

While the new specification says the opposite:
https://material.io/components/menus/#exposed-dropdown-menu

The "appears over" behavior requires the getContentAnchorEl prop. My hope is that we can remove this requirement (Is this a breaking change 🤔?). Without, it starts to make sense to use a single solution to relatively position two distinct elements. (Popper.js doesn't have this zooming issue)

The position section adds some nuance:
"They typically appear next to (or in front of) the element that generates them. If they are in a position to be cut off by the browser or screen’s edge, the menu can instead appear to the left, right, or above the element that generates it."

This sounds like a behavior that we can support with Popper.
As long as the "selected item appears on top of the emitting element" requirement is gone, we should be able to move forward.

By the way, the "appears over" is pretty unique to Material Design (legacy?), I haven't seen it implemented in any of the other Design systems I could encounter.

@oliviertassinari I agree with that, please keep the "appears over" available.

As long as the "selected item appears on top of the emitting element" requirement is gone, we should be able to move forward.

@oliviertassinari Did you mean you want to remove the "appears over" behaviour?

oh I get it. I was worried the "appears over", or "in front of" will no longger present in MUI. As for this behaviour https://material-ui.com/components/menus/#selected-menus I didn't realise it was exist. Yes you should good to go... just chase it out of MUI.

In terms of "impact" this has a huge impact in our ability to utilize material-ui menus in our transition to a mobile responsive website.  We do not have the entire site mobile-responsive, but we get closer by introducing more material/react components to different pages. However until the majority of the page is responsive, the mobile experience will be a zoomed out experience. Thus interacting with any menu will ultimately feel like the site is "broken" because they are panned away and dragging/zooming doesn't work until you think to just "tap" somewhere to unknowingly close the open menu.  Considering the prevalence of menu use headers / mobile header experiences, it seems likely this will have high impact.
This really makes it hard for us to get to a mobile responsive experience if our toolset introduces new problems while replacing old UI.
Just wanted to highlight how important this can be for that goal and it is one of our biggest initiatives at our company right now, so it's a big impact.

@NicholasTuck Thanks for sharing your story. Material-UI doesn't have the resources to solve all the problems faced by our users, but we try to bet on the topic that have the most potential. Right now, we have a significant focus on building new components and features. I can't give you an ETA on when the problem will be solved.
Notice that your company could support this effort with: https://material-ui.com/getting-started/support/#custom-work

Just for notice... Also me have similar problem.
stackoverflow link..

Note: This can be replicated on chrome desktop mobile emulator, you do need to set the "zoom" to "auto-adjust zoom" (the drop down of the "100%" has that as the last option, to kick in the foe mobile zooming experience.

I've tried to identify what is causing the actual pan to the corner and I can't pin point it, I've spent a lot of time debugging through. I am suspicious it's not dom manipulation side effects, and that it's specific js calls, but it's hard to determine that with how react implements dom changes and the effect loops.
I was able to programatically implement the hack @ilyamerman mentioned in the original ticket to allow scrolling back over after opening a menu.  I did this by adding the following class to the  element:
`const useStyles = makeStyles({
popover: {
'& *': {
touchAction: 'auto !important',     // used to override material adding touch-action to none on the popover
}
},
});
...

...
`

Im not sure anyone else has noticed this and i'm not sure yet if its from the Popover component. Im following what was done in the example thats on the docs. (Docs) When the popover is open and the screen size changes the popover prevents any of the page mobile responsiveness.
i'll look into the issue more, might be something i did. Will follow up once I find out more

Just want to add that I have the same issue. It occurs on desktop chrome when you zoom in with a 2-finger pinch. I think that chrome is recognizing the popover root or the backdrop as the 'main element' that you're looking at and centering that. Or, the popover element itself is scrolling the body. Any thoughts on how to disable if the latter is the case?

We ended up re-making the menu component to look the same and behave the same (or as close as we could). Here is the code we made for our Menu component to work around this problem:
import ClickAwayListener from '@material-ui/core/ClickAwayListener';
import {Box} from '@material-ui/core';
import Typography from '@material-ui/core/Typography';
import Popper from '@material-ui/core/Popper';
import Paper from '@material-ui/core/Paper';
import * as PropTypes from 'prop-types';
import React from 'react';

export function Menu({id, children, onClose, launchElement}) {

    const handleClose = (event) => {
        event.stopPropagation();
        setAnchorEl(null);
        if (onClose) {
            onClose(event);
        }
    };

    const [anchorEl, setAnchorEl] = React.useState(null);

    const toggleMenu = event => {
        setAnchorEl(anchorEl ? null : event.currentTarget);
    };

    const open = Boolean(anchorEl);

    return <Box my={4}>
        <ClickAwayListener onClickAway={handleClose} touchEvent={false} >
            <Box display='flex' flexDirection='column' justifyContent='center' alignItems='center'>
                {React.cloneElement(launchElement, {onClick: toggleMenu})}
                <Popper id={id} open={open} anchorEl={anchorEl} popperOptions={{positionFixed: true}} style={{zIndex: 100}}>
                    <Paper elevation={8}>
                        {children}
                    </Paper>
                </Popper>
            </Box>
        </ClickAwayListener>
    </Box>;
}

Menu.propTypes = {
    children: PropTypes.arrayOf(PropTypes.element).isRequired,
    launchElement: PropTypes.element.isRequired,
    id: PropTypes.string,
    onClose: PropTypes.func
};

LaunchElement is the button or link or wtv that you want to cause the menu to open.

@oliviertassinari Any update on this issue? When i set my browser zoom/display setting on my laptop to any value less than 100%, the position of popover is wrong.
Material UI: ^4.0.0
React: ^17.0.1
Browser: On chrome, version 91
My document.body.style.zoom is at 75%. It works as expected when the value is 100%, but once it is decreased or increased the position of popover is wrong.
Tried both Menu and Popover components for the same, but it doesn't work.
In case i tried to position the anchor through anchorPosition prop, calculating the left % is very difficult for all laptop resolutions.
<Popover
        id="menu-appbar"
        anchorEl={anchorEl}
        getContentAnchorEl={null}
        anchorOrigin={{ vertical: "bottom", horizontal: "center" }}
        transformOrigin={{ vertical: "top", horizontal: "center" }}
        open={openMenu}
        onClose={menuClose}
        // anchorReference="anchorPosition"
        // anchorPosition={{ top: "5%", left: "75%" }}
      >
        {menus &&
          menus.map((item, index) => (

              {item.displayText}

          ))}
 </Popover>

Any work around or alternate to make it working as of now?

still have this issue today, pinch zoom on mac desktop
chrome
safari same behaviour
this is pretty annoying bug, does anyone have a workaround?
or do you suggest that I should use popper?

I love mui until I run into such trivial issues like this...something that should be an easy fix but isnt. They have it working in their docs but it doesnt explain how.
https://mui.com/material-ui/react-menu/ in the section (MenuList Composition) with Popover.

@oliviertassinari Any ETA when this will be fixed or any workaround?


[第5組]Refactor: Almost Re-Build full backend

Summary
Refactor the single file main.py into a modular architecture to improve maintainability and readability.
Changes

Create a modular directory structure
Categorize related functionality into different modules
Implement dependency injection pattern
Optimize routing management
Standardize error handling

Add file structure
src/
├── main.py
├── config.py
├── constants.py
├── database.py
├── dependencies.py
├── models.py
├── schemas.py
├── services.py
└── routers/
    ├── auth.py
    ├── news.py
    └── prices.py

Changes
1. add dependencies

Extract database connection and user authentication logic into separate dependencies
Implement a unified error handling mechanism

2. Add routers/

Categorize API routes by functionality
auth.py: User authentication related APIs
news.py: News related APIs
prices.py: Prices related APIs

3. Add services.py

Extract business logic into service layer
Implement AuthService, NewsService, and AIService

4. Add database.py

Centralize database connection settings
Provide database session management mechanism

5. Add config.py

Centralize all configuration items
Support reading configuration from environment variables

Notes

This refactoring does not change any existing functionality
Keep the original API interfaces unchanged
Keep the original database structure
Ensure downward compatibility

Related documents

API documentation remains unchanged
Added documentation for the modular architecture
Updated deployment guide

Review points

Code organization structure
Error handling mechanism
Implementation of dependency injection
Configuration management approach
Code readability

PT Notes
Please review this PR to ensure that the refactored code quality and maintainability are improved, while not affecting existing functionality.
And please use the Chinese(Traditional) to write the comment. Plz q.q
Oh and this PR was generated by claude-3-ops.

fixed!

這次重構的最大亮點在於清晰的模組結構，將主文件 main.py 的邏輯分拆到各個模組中，使得每個模組的責任明確，並依功能劃分 API 路由（如auth、news、prices）。這樣的分工讓代碼的擴展性變得更加靈活，便於後續增加新功能。將業務邏輯提取到 services.py 層並使用依賴注入的模式，這種設計使得功能測試更獨立，也能減少模組之間的耦合度。此外，統一的錯誤處理機制讓代碼在處理例外情況時更具一致性。但例如完全相同的 models, config 在重複出現在 根目錄, auth/, news/，可能不太好，建議進一步精簡並優化配置的集中管理（例如統一import自根目錄的 models, config）。


Release 2.1.0

Codecov Report

Merging #474 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #474   +/-   ##
=======================================
  Coverage   21.38%   21.38%
=======================================
  Files         166      166
  Lines        1230     1230
=======================================
  Hits          263      263
  Misses        967      967

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aaea0f...c60e862. Read the comment docs.


the window is not responding ubuntu, and slowly work

:warning: We have copied additional data to your clipboard. Make sure to paste here. :warning:
:warning: Make sure to attach these files from your home-directory: :warning:
-prof-LbNsbG7i.main.cpuprofile.txt

file:///home/rostyslav/prof-LbNsbG7i.main.cpuprofile.txt

Uploading prof-LbNsbG7i.main.cpuprofile.txt…

@RostislavZalevsky please re-upload or re-capture the profile trace as your previous update didn't succeed.

now i cant re-report since i reinstalled VS Code. And i dont see any issues
Thanks


feat: Reentrant variant of schedStateName

That was my first instinct, but it does look a little ugly compared to the original.

What if it were to have a default value instead of a buffer?
This would allow you to perform JAToI(), or a more advance lookup function before entering the function.


Should fortran-lang.org have a Fortran code snippet on the landing page?

What prompted me to open this: https://twitter.com/asmeurer/status/1334423581837561856
When putting together the first version of the website back in April, I wanted and tried to include an example Fortran code snippet. However, at the time, I struggled with my HTML and CSS to make it look pretty so in interest of time I dropped it and moved on. Then I forgot about it.
First question is, should the landing page have an example code syntax, nicely styled, syntax-colored, some minimal but real-world example? The purpose is to show what Fortran looks and feels like, on a first impression to a newcomer to the language.
Second, if the answer is yes (and I think so), can you please think of and propose some example snippets that you think would be good for this? Then we can all discuss them and choose our favorite.
Third, are you interested in making this happen? It should be a relatively low-hanging fruit, with I think a high ROI. It would probably require basic-to-intermediate HTML+CSS skills and a basic sense of good design.
Here are examples for inspiration, some pretty, some not so pretty:

Python
Go
Nim
Elixir
Ruby
Haskell

Some ideas could include a simple mathematical computation, a loop structure, or an input/output operation. For instance:
program HelloWorld
implicit none
write(*, '(A)') 'Hello, World!'
end program HelloWorld
Will be happy if I can contibute to any of the issue here

Including a Fortran code snippet on the landing page of fortran-lang.org can be beneficial for users seeking a quick glimpse of the language's syntax and usage. It could provide a concise example to showcase Fortran's strengths and encourage further exploration.
Will be happy if I can contribute to any of the issue here.

Here are a few minimal but real-world Fortran code snippets that could be considered for the landing page:
! Example 2: Simple Array Operation
PROGRAM ArrayOperation
INTEGER, PARAMETER :: N = 5
REAL, DIMENSION(N) :: numbers
INTEGER :: i
numbers = (/1.0, 2.0, 3.0, 4.0, 5.0/)
DO i = 1, N
numbers(i) = numbers(i) * 2.0
END DO
END PROGRAM ArrayOperation


Update command summary of UG

Previously, command summary of our UG is vague for edit command, and there is no summary for the other commands, hence readability becomes an issue
Let's
*update the command summary of the UG so as to enhance user readability

can you include a screenshot?


Support for guest-comments

I have my blog setup with using utterances as my comment manager. Is there an option of having guest comments where person doesnt need to login using Github to add a comment?

I don't think that is possible unless Utterance supports different auth rather than Github.


Fix dueDate of MergeRequest and introducing assignees property to GitLab

dueDate property
First is dueDate, since due date of a milestone on GitLab is possible to become null, and the current definition of dueDate is not optional, so it might produce parsing error while it meets a null-dueDate milestone:

ERROR: Failed to parse JSON: dataCorrupted(Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "danger", intValue: nil), CodingKeys(stringValue: "gitlab", intValue: nil), CodingKeys(stringValue: "mr", intValue: nil), CodingKeys(stringValue: "milestone", intValue: nil), CodingKeys(stringValue: "due_date", intValue: nil)], debugDescription: "Date string does not match format expected by formatter.", underlyingError: nil))

assignees property
The assignees array is exist in the JSON but we don't have a property for that. It is not convenient if some team need to add some rules while they are able to set multiple assignees on merge request.

Warnings

:warning:

Any changes to library code should be reflected in the Changelog.
Please consider adding a note there and adhere to the Changelog Guidelines.

  Generated by :no_entry_sign: Danger Swift against 0a80eb53b5af85f1da5a545018bb2380138652de

@417-72KI Hi, thanks for viewing my pull request. Btw, I have noticed that CI failed due to this change https://github.com/SwiftDocOrg/swift-doc/commit/dc1cac952820161f50d445ee656ee635a9f68580#diff-37ca2dd15ca0f6b1b49e78db084ef5b9R1 , shall we pump up the the swift tools version or just keep it as it?

@vc7
I'm sorry but I can't judge it.
But, I think it should be keeped because of Swift 5.1 compatibility.
@f-meloni
Can I get your opinion?

👋
If you merge master in the branch it should solve the problem :)

@f-meloni Hi :)
I just made the branch from the newest master so I was not able to merge the newest master to my branch.
Please let me know if I missed something

Let me see if I can merge it for you :)

My bad I though I merged https://github.com/danger/swift/pull/380/commits/fc2e5b20070b0cc2d235149db30fe7d09e484cea to master, but is still on an open PR, sorry

Fails

:no_entry_sign:

danger-swift failed.

Log
/tmp/_tmp_dangerfile.swift:1:8: error: no such module 'Danger'
import Danger
       ^
ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /tmp/danger-response.json

  Generated by :no_entry_sign: dangerJS against f90bf13b6fa2bfdcaab070a198656a979d89cca2

Fails

:no_entry_sign:

danger-swift failed.

Log
/var/folders/17/5mc7816d3mndxjqgplq6057w0000gn/T/_tmp_dangerfile.swift:1:8: error: no such module 'Danger'
import Danger
       ^
ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /var/folders/17/5mc7816d3mndxjqgplq6057w0000gn/T/danger-response.json

  Generated by :no_entry_sign: dangerJS against f90bf13b6fa2bfdcaab070a198656a979d89cca2

Thanks for the advice!
For the upgrade of the library, it works great on Xcode 12, but the KeyPath syntax seems causing build failures both on my local machine's Xcode 11.0 and couple of CI tasks. Do you have this kind of issue on your side?
And after upgrade the library, I am running into and trying to solve some unexpected test failures related to DiffParser and not able to push right now.
The failure message is as following.

Test case testParsesDiff()
XCTAssertEqual failed: ("[@@ -0,0 +1,7 @@+<?xml version="1.0" encoding="UTF-8"?>
+<Workspace
+   version = "1.0">
+   <FileRef
+      location = "self:">
+   </FileRef>
+</Workspace>, , @@ -1,7 +0,0 @@-# frozen_string_literal: true
-
-source "https://rubygems.org"
-
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
-
-gem "xcpretty-json-formatter", @@ -20,7 +20,8 @@ extension ReportSection {
     init(fromSPM spm: SPMCoverage, fileManager: FileManager) {
         titleText = nil
-        items = spm.data.flatMap { $0.files.map { ReportFile(fileName: $0.filename.deletingPrefix(fileManager.currentDirectoryPath + "/"), coverage: $0.summary.percent) } }
+        items = spm.data.flatMap { $0.files.map { ReportFile(fileName: $0.filename.deletingPrefix(fileManager.currentDirectoryPath + "/"), coverage: $0.summary.percent)
+        } }
     }
 }, @@ -1,8 +1,11 @@ import Foundation
+
+
+
+
 protocol SPMCoverageParsing {
-    static func coverage(spmCoverageFolder: String, files: [String]) throws -> Report
-}
+    static func coverage(spmCoverageFolder: String, files: [String]) throws -> Re
 enum SPMCoverageParser: SPMCoverageParsing {
     enum Errors: Error {
@@ -22,6 +25,10 @@         let coverage = try JSONDecoder().decode(SPMCoverage.self, from: data)
         let filteredCoverage = coverage.filteringFiles(notOn: files)
-        return Report(messages: [], sections: [ReportSection(fromSPM: filteredCoverage, fileManager: fileManager)])
+        if filteredCoverage.data.contains(where: { !$0.files.isEmpty }) {
+            return Report(messages: [], sections: [ReportSection(fromSPM: filteredCoverage, fileManager: fileManager)])
+        } else {
+            return Report(messages: [], sections: [])
+        }
     }
 }, @@ -3,6 +3,8 @@ protocol ShellOutExecuting {
     func execute(command: String) throws -> Data
+
+
 }
 struct ShellOutExecutor: ShellOutExecuting {]") is not equal to ("[@@ -0,0 +1,7 @@+<?xml version="1.0" encoding="UTF-8"?>
+<Workspace
+   version = "1.0">
+   <FileRef
+      location = "self:">
+   </FileRef>
+</Workspace>, , @@ -1,7 +0,0 @@-# frozen_string_literal: true
-
-source "https://rubygems.org"
-
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
-
-gem "xcpretty-json-formatter", @@ -20,7 +20,8 @@ extension ReportSection {
     init(fromSPM spm: SPMCoverage, fileManager: FileManager) {
         titleText = nil
-        items = spm.data.flatMap { $0.files.map { ReportFile(fileName: $0.filename.deletingPrefix(fileManager.currentDirectoryPath + "/"), coverage: $0.summary.percent) } }
+        items = spm.data.flatMap { $0.files.map { ReportFile(fileName: $0.filename.deletingPrefix(fileManager.currentDirectoryPath + "/"), coverage: $0.summary.percent)
+        } }
     }
 }
 , @@ -1,8 +1,11 @@ import Foundation

+
+
+
+
 protocol SPMCoverageParsing {
-    static func coverage(spmCoverageFolder: String, files: [String]) throws -> Report
-}
+    static func coverage(spmCoverageFolder: String, files: [String]) throws -> Re

 enum SPMCoverageParser: SPMCoverageParsing {
     enum Errors: Error {
@@ -22,6 +25,10 @@         let coverage = try JSONDecoder().decode(SPMCoverage.self, from: data)
         let filteredCoverage = coverage.filteringFiles(notOn: files)

-        return Report(messages: [], sections: [ReportSection(fromSPM: filteredCoverage, fileManager: fileManager)])
+        if filteredCoverage.data.contains(where: { !$0.files.isEmpty }) {
+            return Report(messages: [], sections: [ReportSection(fromSPM: filteredCoverage, fileManager: fileManager)])
+        } else {
+            return Report(messages: [], sections: [])
+        }
     }
 }, @@ -3,6 +3,8 @@
 protocol ShellOutExecuting {
     func execute(command: String) throws -> Data
+
+
 }

 struct ShellOutExecutor: ShellOutExecuting {]")

Test case testChangeTypeForModified()
XCTAssertEqual failed: ("modified(hunks: [@@ -20,7 +20,8 @@ extension ReportSection {
     init(fromSPM spm: SPMCoverage, fileManager: FileManager) {
         titleText = nil
-        items = spm.data.flatMap { $0.files.map { ReportFile(fileName: $0.filename.deletingPrefix(fileManager.currentDirectoryPath + "/"), coverage: $0.summary.percent) } }
+        items = spm.data.flatMap { $0.files.map { ReportFile(fileName: $0.filename.deletingPrefix(fileManager.currentDirectoryPath + "/"), coverage: $0.summary.percent)
+        } }
     }
 }])") is not equal to ("modified(hunks: [@@ -20,7 +20,8 @@ extension ReportSection {
     init(fromSPM spm: SPMCoverage, fileManager: FileManager) {
         titleText = nil
-        items = spm.data.flatMap { $0.files.map { ReportFile(fileName: $0.filename.deletingPrefix(fileManager.currentDirectoryPath + "/"), coverage: $0.summary.percent) } }
+        items = spm.data.flatMap { $0.files.map { ReportFile(fileName: $0.filename.deletingPrefix(fileManager.currentDirectoryPath + "/"), coverage: $0.summary.percent)
+        } }
     }
 }
 ])")

Test case testChangeTypeForRenamed()
XCTAssertEqual failed: ("renamed(oldPath: "Sources/DangerSwiftCoverage/ShellOutExecutor.swift", hunks: [@@ -3,6 +3,8 @@ protocol ShellOutExecuting {
     func execute(command: String) throws -> Data
+
+
 }
 struct ShellOutExecutor: ShellOutExecuting {])") is not equal to ("renamed(oldPath: "Sources/DangerSwiftCoverage/ShellOutExecutor.swift", hunks: [@@ -3,6 +3,8 @@
 protocol ShellOutExecuting {
     func execute(command: String) throws -> Data
+
+
 }

 struct ShellOutExecutor: ShellOutExecuting {])")

Fails

:no_entry_sign:

danger-swift failed.

Log
/tmp/_tmp_dangerfile.swift:1:8: error: no such module 'Danger'
import Danger
       ^
ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /tmp/danger-response.json

  Generated by :no_entry_sign: dangerJS against f4cc8465e036ab7f4333ec661319cd7954847a0b

Fails

:no_entry_sign:

danger-swift failed.

Log
/tmp/_tmp_dangerfile.swift:1:8: error: no such module 'Danger'
import Danger
       ^
ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /tmp/danger-response.json

  Generated by :no_entry_sign: dangerJS against 0e89f5ce705c627c7428cb9500c815f8690f1e07

Fails

:no_entry_sign:

danger-swift failed.

Log
/var/folders/17/5mc7816d3mndxjqgplq6057w0000gn/T/_tmp_dangerfile.swift:1:8: error: no such module 'Danger'
import Danger
       ^
ERROR: Dangerfile eval failed at Dangerfile.swift
ERROR: Could not get the results JSON file at /var/folders/17/5mc7816d3mndxjqgplq6057w0000gn/T/danger-response.json

  Generated by :no_entry_sign: dangerJS against 0e89f5ce705c627c7428cb9500c815f8690f1e07

No code changes at https://github.com/danger/swift/pull/381/commits/a4fd57f984ab5a6212e71de791d933a6d7042c44 , two link references fixed at CHANGELOG.

My thank you guys for the reviews, I have found there are still some issues related to GitLab and I will filing pull requests later on :)


Oauth2 App database should not require the refresh_endpoint

According to the specs for oauth2 the token endpoint shall be used for the refresh: https://www.oauth.com/oauth2-servers/making-authenticated-requests/refreshing-  an-access-token/
I suggest we deprecate the argument in the OAuthApplicationDatabase, or can it be cut completely without breaking the entire world?

i'd say we cut it and bump a version number to signal the breaking change just in case, only the HA plugin, alerts skill and spotify use oauth, not too much out there for us to update

@forslund @JarbasAl I just took a look at the HA plugin. I don't think it's event using this as it's delegating to the OAuth plugin entirely, so as long as that plugin can handle it we shouldn't have a problem.

Closed via #61


Remove node_modules

I have detected the existance of node_modules folder in your repo, this PR removes it and adds it to your .gitignore

lgtm 👍


Enable fasterxml to read/write bigquery classes

We are using BigQuery from Temporal, a tool to schedule and run workflows, and it passes results and arguments over JSON, so it must be able to read and write these structures. As it happens, it is perfectly capable of converting to JSON with fasterxml, but it is then not capable of reading it back because the classes do not offer a NoArgs constructor:
io.temporal.common.converter.DataConverterException:
  com.fasterxml.jackson.databind.exc.InvalidDefinitionException:
  Cannot construct instance of `com.google.cloud.bigquery.Schema` (no Creators, like default constructor, exist): cannot deserialize from Object value (no delegate- or property-based Creator)
 at [Source: (byte[])"{"fields":[{"name":"bike_id","type":
{"constant":"INTEGER","equivalent":"INT64","standardType":"INT64"},"subFields":null,"mode":"NULLABLE","description":null,"policyTags":null},{"name":"start_date","type":{"constant":"DATE","equivalent":"DATE","standardType":"DATE"},"subFields":null,"mode":"NULLABLE","description":null,"policyTags":null},{"name":"trip_count_last_week","type":{"constant":"INTEGER","equivalent":"INT64","standardType":"INT64"},"subFields":null,"mode":"NULLABLE","description":null,"p"[truncated 199 bytes]; line: 1, column: 2]

I have considered copying the data I need to an internal class, but it feels like unnecessary work if everything we are missing is a NoArgs constructor (which can be private, fasterxml works OK with this).

Another thing that would work is making public the toPb fromPb methods and I can just send those in params/returns.

Please feel free to submit a PR with NoArgs constructor and I will review it.

OK, will do


Umami site keeps refreshing and going back to previous page every few seconds

Describe the Bug
We have been running umami for about a month with no issues until today. I clicked into a page on our site to see some page specific insights and whenever I tried to clear the filter, after about 3 seconds the page would refresh and the filters would be applied again. It applies everywhere though. Any time I navigate to a new page, after 3 seconds it refreshes and returns me to the previous page. This is even the case when I try to log in, it brings me back to the login form though the sign-in succeeded.
Other details:

We are on kubernetes and I am running the latest image. I even tried redeploying the pods and pulling the latest image fresh but the issue persists.
If I log in incognito the issue is gone
If I quickly refresh the page after I navigate before it refreshes itself I will stay on the page.

Database
PostgreSQL
Relevant log output
server logs just show a successful boot. Javascript console shows nothing.

Which Umami version are you using? (if relevant)
ghcr.io/umami-software/umami:postgresql-latest
Which browser are you using? (if relevant)
Chrome
How are you deploying your application? (if relevant)
Kubernetes

I've never heard of anything like this. Have you tried a completely new browser? Sounds like a browser extension doing some weird stuff.

Well, it goes away in incognito so I'm thinking it's cookie/local storage related. If it was a browser extension I would expect the behaviour in other tabs than just umami. There is another similar ticket titled something like "umami refreshes every 3 seconds" though the resolution appears to be the platform the reporter deployed to? But me experiencing it now on kubernetes makes me think it isn't isolated. It does seem very tricky to replicate though. I can't get it to happen in my incognito browser but I can't get it to go away in my main browser.


How to apply FLYP on custom dataset?

which py files do I need to modify to use FLYP on my own datasets? Thanks.

You need to add a dataloader class file in this folder : https://github.com/locuslab/FLYP/tree/main/src/datasets.
I would create a .csv which has image path and caption in each line (see the data creation scripts)
You should be run with these changes


Update to Xcode 9 & Swift 4

Hey- been loving Outlander. It was exactly what I was looking for after being frustrated with Avalon.
I was planning to start picking off some easy bugs/tasks, but I'm having trouble getting things building. I'm guessing it compiles ok with Xcode 8.2 and Swift 2.3. Was hoping it'd be straightforward to upgrade but no such luck, seems that OysterKit has changed a lot (0.3.0-beta seems like a complete rewrite?).
Wondering if you have suggestions on the path forward- happy to do the grunt work and contribute back, but have spent enough time in the rabbit hole now I figured I'd get your input.  Great to hear someone else looking to work on Outlander!

Hey, yeah no such luck.  I did an initial update to Swift 3 in #124 , though at that time OysterKit had no plans for a future version (as far as I could tell).  I ripped that and a few other dependencies out (I had to re-do some of the map integration) and completely re-wrote the script engine.  I ran into some other issues after that and frankly just ran out of steam to complete it.
That branch has a start of a re-write of the core game stream.  Right now the xml is evaluated on a per-line basis and I believe that is causing a lot of the current performance issues.  They became exaggerated in that re-write branch.
I've been doing some minor updates to the master branch with Xcode 821.
If you're up for it, I wouldn't mind ripping down the project to bare-bones, getting it running with Xcode 9 + Swift 4, and pulling in my script engine changes or working with you to come up with a good pattern for the script and processing engine.  I'm not a full-time dev with Obj-c and Swift so I wouldn't be surprised if there are better ways to do things.


Support for TypeScript + JSX language (.tsx)

There's a somewhat popular variant of TypeScript that incorporates JSX, and replaces TypeScript's normal angle-bracket casts with the as keyword.  Source files typically end in .tsx.  It would be nice to have a language definition for this -- it's not hard to make one, but not clear how to cleanly share the bulk of the definition with typescript.
Related issues: #878, reviewable/reviewable#285

Ping @isagalaev?

We'll get to this (and other) issues in eventually. No estimates though, as there are too few of us…

OK, no problem -- I just noticed that this was the only open issue without a label so I was afraid you'd missed it.  :)

Is there any progress on this? @pkaminski have you figured out any other solution?
Thanks :)

Nope, I don't have any workaround at this time, sorry.

Thanks for the answer. I'll use 'js' as language than, it looks good enough.

Tagging this beginner friendly and help welcome incase @ddevault doesn't have time to see this thru to completition.

This will be closed by https://github.com/highlightjs/highlight.js/issues/2568 when it closes.

So in the future it will be possible to highlight tsx using ```tsx `````?

No. It's built into Typescript. It's not a different grammar.

@joshgoebel it would be much nicer to use tsx (rather than integrating it into ts) because IDEs might differentiate between ts and tsx.
My IDE (WebStorm) complains when writing TSX code inside of a ts code block:

But it does not complain when the code from above is inside of a tsx code block:

Unfortunately, highlight.js only renders syntax highlighting when using ts (and not tsx). 😥

because IDEs might differentiate between ts and tsx.

But how is this relevant to us?  If you just mean "people think of it as tsx"... then it seems like perhaps we should add an alias to typescript for tsx in addition to ts, so people could label it as such.  That would make sense.

Right now our current grammar should "just work" regardless of whether you throw TS or TSX at it... meaning there is no need for two grammars.  Having a separate TS grammar would be simpler in one or two regards (highlighting operators, no having to tell type annotations from HTML), but I dunno if having yet another variant is actually a good idea or not.  Because if we went that way we'd really need 4:

JS and JSX
TS and TSX

Definitely something to keep in mind if I ever find the time to try and finish/flesh out our TSX support further.

In fact since we already do this for jsx seems obvious we should add the alias, yes?

Using an alias sounds like a great idea. It will improve the developer experience for people like me who edit files, which are later highlighted by highlight.js, and want to have syntax support in their IDEs (which differentiate between TS and TSX).

0c14f68c


The movie is displayed in small full screen mode

The movie is displayed in small full screen mode. please help me
Sample address: http://paniatv.r98.ir/128
Sample photo: https://s17.picofile.com/file/8415167842/photo_2020_11_24_13_34_38.jpg

Hello!
Apologies, but this ticket has been closed because there is no actionable way to identify what the actual issue is.
The initial ticket description fails to provide details required to identify the problem, such as error output, request logs, environment and browser details, and other details that could aid and allow in identifying the problem you are facing.
Before submitting a new ticket, please make sure that the problem you are facing is related to this software and is not a result of a misconfiguration or third party code - including your usage of this software.
As a general rule, we are unable to help with user-specific implementation details, and we are not able to debug user implementations, such as websites, plugins, scripts, etc..
You are required to take the minimum steps necessary to identify the issue, such as debugging the software, your specific configuration, the requests made, the responses returned by any external services.
You are required to submit enough details about the problem so that we would be able to reproduce and verify the problem.
Make sure to fill out any issue templates as provided by the issue tracker when such templates are present.
This is an automatic response. Please, do not reopen or re-create this ticket without addressing the requirements and problems outlined above.


Bot API 7.2

https://core.telegram.org/bots/api-changelog#march-31-2024
Integration with Business Accounts

[ ] Added the class BusinessConnection and updates about the connection or disconnection of the bot to a business account, represented by the field business_connection in the class Update.
[ ] Added updates about new messages in a business account connected to the bot, represented by the field business_message in the class Update.
[ ] Added updates about message edits in a business account connected to the bot, represented by the field edited_business_message in the class Update.
[ ] Added updates about message deletion in a business account connected to the bot, represented by the class BusinessMessagesDeleted and the field deleted_business_messages in the class Update.
[ ] Added the method getBusinessConnection.

Working on Behalf of Business Accounts

[ ] Added the parameter business_connection_id to the methods sendMessage, sendPhoto, sendVideo, sendAnimation, sendAudio, sendDocument, sendSticker, sendVideoNote, sendVoice, sendLocation, sendVenue, sendContact, sendPoll, sendDice, sendGame, and sendMediaGroup.
[ ] Added the parameter business_connection_id to the method sendChatAction.
[ ] Added the field business_connection_id to the class Message.
[ ] Added the field sender_business_bot to the class Message.

Information about Business Accounts

[ ] Added the class BusinessIntro and the field business_intro to the class Chat.
[ ] Added the class BusinessLocation and the field business_location to the class Chat.
[ ] Added the classes BusinessOpeningHours and BusinessOpeningHoursInterval and the field business_opening_hours to the class Chat.

Mixed-Format Sticker Packs

[ ] Removed the fields is_animated and is_video from the class StickerSet.
[ ] Added the field format to the class InputSticker.
[ ] Removed the parameter sticker_format from the method createNewStickerSet.
[ ] Added the parameter format to the method setStickerSetThumbnail.
[ ] Increased the maximum number of stickers in any regular and mask sticker set to 120.
[ ] Allowed to upload WEBM stickers using SendSticker.

Request Chat Improvements

[ ] Added the fields request_name, request_username, and request_photo to the class KeyboardButtonRequestUsers.
[ ] Added the fields request_title, request_username, and request_photo to the class KeyboardButtonRequestChat.
[ ] Added the class SharedUser and replaced the field user_ids in the class UsersShared with the field users.
[ ] Added the fields title, username, and photo to the class ChatShared.

Other Changes

[ ] Added the field is_from_offline to the class Message.
[ ] Added the field can_connect_to_business to the class User.
[ ] Added the field personal_chat to the class Chat.
[ ] Added the method replaceStickerInSet,
[ ] Added the class Birthdate and the field birthdate to the class Chat.
[ ] Added the field BiometricManager to the class WebApp.

@TiiFuchs DB nightmare incoming, gonna be good to not have to go there :innocent:


Remove restriction on one forwarding rule per container port

@paetling Closes #607. I think this restriction was a relic of the early builds when we ran nginx on the Mac side. It works perfectly fine without these checks in place now.

Now I am confused.  In a single container, how is it possible to have two systems running on the same port and thus the need to forward to that port twice?
I guess this does not technically speak to the nature of what is running in the container. This specification is just used to set up nginx forwarding and ensure that ports are forwarded correctly into the container. I guess with that in mind, this restriction does not need to be there, just seems a little strange to me to remove it.

Check the linked issue, the use case is having two or more combinations on the host pointing to the same final destination in the container, e.g. local.service.com:80 and local.service.com:8000 and local.service2.com:80 can all point to port 80 in the container. Nginx can handle this just fine.


Webmin/Virtualmin default tab doesn't work + general issues + speed

No matter the setting I use in "Default tab after logging in to Webmin", WebMin is always shown on the left hand side by default when I log into virtualmin (ubuntu 14.04). Is there some trick to make this work?
All the other themes default to VirtualMin for a reason. The main/right side then shows the default
Also not working:

change default virtualhost. It always shows the first one in my list

Also probably not working:

Spinners. Everywhere are spinners. Waiting waiting waiting. This theme is exceedingly slow to load on each page load. 4.3secs for the home page, roughly 1.5secs to apply any page change. It is this reason, more than any other which causes me to prefer Finally or XenLayer Framed themes (which generally return the page nearly instantly).

Default tab and default virtualhost should be working. Spinners were fixed in theme version starting 13.00 and it works same fast (0.5 sec.) in my all 3 systems with different OS.
System info page takes a long time, because it checks for updates and outgoing connection takes that long on your side - you can disable it in settings. There is no spinners really as it was before version 13, and anyway, you can disable it in settings.
There is a video overview and you can see the way theme should work.
I will double check default tab and virtualhost settings and let you know next week as I'm on vacation right now.
Meanwhile, tell me which browser/os you're using? Which theme version are you using? Latest, 13.05? Did you clear browsers cache after updating?

I'm using chrome 43 (latest), osx 10.9 (mavericks), theme version 13.05, virtualmin/webmin 1.76 (just updated).
I've tested this on several ubuntu 14.04 boxes over the last few months (all VM's), and the result has always been the same. It's very sluggish, and the 'default tab' has never seemed to work.
I think we have very different ideas of 'speed'.
Even looking at the video, for example 5:18 when using BIND editor, the page refreshes are not snappy. Perhaps it's all that animation stuff. I turned off the 'gauges' on the information page for that reason: I'd rather have nothing than have some 'pretty' animation wasting my time.
Perhaps I'd be happy with an option to turn off absolutely every animation. (eg nav bar slide ins, page fade in) perhaps this may affect how you approach any ajax requests being made too.
My machines (either local, or remote) have ping times <10ms. Generally I would have a virtualmin page loaded and usable in <500ms.
Nevertheless, regardless of any animations, here are some comparisons on initial page refresh times (Ctrl/Shift+F5, Cmd+R)
Authentic Theme: 4.3 secs
XenLayer Framed: 2 secs
Finally Theme: 2.5 secs
These times are relatively consistent, with maybe 300ms maximum variance. As you can see, I see an extra 2secs for Authentic...
Have a great holiday (sorry to disturb you... but you shouldn't be logging into github anyway!)

OK!
I will add an option in next release to disable animation on the left menu.
For some reason something tells me that ping ~10ms is horribly big for local machine. I'm at the sea now and having ping to my server that is in thousands km away around 50ms.. Ping for local should be around ~0.050ms..
Here is what we'll do. (I am at the laptop and can type now with ease)..

Go to theme settings. Set default page and tab and hit save button. Afterwards, in Chrome, click right mouse button on the right page (frame) and click Reload Frame. Now question: "Do you have selected options saved"?? In case they are not (this is what I believe is happening in you case) - you have to change the chown/chmod on the folder /etc/webmin/authentic-theme as root:root and 755. In that folder you will find a file settings.js. It should be updated each time you save theme settings.

Authentic Theme: 4.3 secs
That is not good and the only reason why it's happening because it takes a long time for your server to connect to GitHub - try running for server's console ping raw.githubusercontent.com to see the ping? What is it? I have 48ms from my server in Moscow (it's in DC). Like I said, from where I am now - it takes less than 2 seconds for me to see System Info Page of my server in Authentic Theme (and WiFi here is not the best on earth, that's for sure). In case settings work for you go there and set Check for Authentic Theme updates to No. And again, make sure that settings are save.

For me everything you say can not be reproduced (tabs are working and pages load just slightly-lightly slower that in default theme). In case all that I have proposed will not help, all I can do is to install Ubuntu on my test server and then try again.
Let me know more about  points 1 and 2 described above.

Yes, the settings save correctly. This is easily checked by doing 'ls -al /etc/webmin/authentic-theme/settings.js' after changing something. When I mention 'spinners', it seems that you imply the big ones that appear in the left/right, which you can turn off. All that does is hides the images and doesn't speed up anything, as far as I can tell.
The spinners I mention are the ones that happen everywhere else. eg When I go to "Webmin Configuration > Webmin Themes", there is a two second or so wait before the first tab appears and says "Current Theme". A spinner appears there & in the page below it.
The 10ms was simply to indicate that my remote server responds quickly and that the problem is not due to latency. (I typically get pings around 0.1ms to my remote server.) Of course local is faster again.
Pings to raw.githubusercontent.com are 0.750-0.900ms, which is pretty fast indeed. Clearly your assumptions are misplaced.
My install setup is nothing special. A blank ubuntu 14.04 (with only OpenSSH). Install webmin. Authentic = unusably slow.
What can I say? I've seen this on every install I've made. I've mentioned in the video 5:18 where it is obviously slow. I have had others mention slow response as the reason why they have moved to other themes.
It is not my configuration, nor my imagination. I would suggest that lots of css and lots of js, and lots of ajax calls are only making UX worse. Adding animations to make things look nice are also adding to the problem.
This is just to load the "Current Theme" page (in just under 2secs):
#CSS files: 10
#JS files: 20
#Font files: 8
(Plus the bug where the select tab upon entering is always webmin on the left, and not the page I specified in settings on the right).
Load up the other themes. Talk to your friends about it and get them to compare.

The spinners I mention are the ones that happen everywhere else. eg When I go to "Webmin Configuration > Webmin Themes", there is a two second or so wait before the first tab appears and says "Current Theme". A spinner appears there & in the page below it.

Because the new tab is injected. There is no way not to show it or speed it up. Besides users don't tweak their themes all the time and it's ok as one-time scenario.

I've mentioned in the video 5:18 where it is obviously slow. I have had others mention slow response as the reason why they have moved to other themes.

I checked 5.18 and if it feels slow for you, then I would say it is not. Yes, it's slower than default theme (by some milliseconds).. but you must understand that Authentic Theme loads a lot of stuff (unlike default theme, not even closely). Speaking of that moment above, where BIND CodeMirror editor is loaded, yes it's a bit slower but again, you get a lot of stuff loaded/initiated. I wouldn't be harsh on that much of a delay.. and it's nowhere near that slow as you say. On the first load, yes agree. But then we're talking about milliseconds. I can't assist you with that.
To speed up the first load I could combine all files in one big bundle but that would make any difference on the first start and would result in very little speed-up, which again makes it very unreasonable to do.

This theme is exceedingly slow to load on each page load. 4.3secs for the home page

To solve this issue go to Theme settings and disable Check for Authentic Theme updates and Check for ConfigServer Security & Firewall updates by setting its value to no. Then you will get proper (as anywhere else on the theme) time for loading System Information page.

Change default virtualhost. It always shows the first one in my list and "Default tab after logging" doesnt work.

No and again no possibility for me to confirm this as bug. I just double checked it for you on my machines - result it works perfectly fine for both Webmin and Usermin. Same as for setting up default virtualhost/virtualdomain. All is loaded as expected.
Solutions:

Clear browsers cache (less liky to help)
Reset theme settings to default and try again right away with setting up default tab and default virtualhost.

In case it still doesn't work, please make a video-screencast with console opened to let me see what is happening.
How did you install the theme?

..in addition, when you disable content page loader, you get nearly the same speed as in default theme (reload the theme or clear browser's cache). You are welcome to disable it, to save extra few milliseconds.

However, I will make a new option for you to completely disable all animation on the left menu.
...and also you will be able to disable tabs animation and get back to what you get used to!
It will be there in version 13.10.
Thanks for the ideas!

Good luck with this theme. I tried 13.10, and turned off animations. I still wait >4 seconds for the initial load. Webmin tab is still the default tab. I still spend more time 'waiting' than I do 'using'.
I have tried to be as open and as helpful as possible, giving sage advice on why the theme is slow. I have tried to be clear and concise as to the nature of what I'm seeing.
I can only recommend very highly that you do some profiling of the theme, rather than stating "it works for me".
I give up. I shall not bother with this theme anymore.

I don't say 'it works for me'. On the other hand, you are the only one saying 'it doesn't work for me'.
I have people on Ubuntu servers and they never complained about this bug. (However, I'll ask them to double check.)
I'm interested in fixing bugs and in improving the theme, in objective ways but not fight costs.
What you're saying can not be confirmed and I can't fix 'something', that works perfectly on 3 different machines.
 My point is to improve where possible. Make it possible please, like I asked, provide the videoscreencast, of how it works/doesn't work for you so I can see, that tabs are really not working.
Last update, 13.10, imensly increases the speed when all animation is disabled, it litteraly works as fast as default theme.

To prove my point, please take a look at the following videoscreencasts.

Videoscreencast of working default tab and default virtual server:

https://rostovtsev.ru/pub/src/authentic/13.10/videoscreencasts/working_default_tab_default_server.webm

Screencast of showing the speed of Authentic Theme when all animation is disabled:

https://rostovtsev.ru/pub/src/authentic/13.10/videoscreencasts/speed_of_authentic_theme_with_animations_disabled.webm

@cmroanirgo I use the theme on production env on Ubuntu servers 14.04LTS, the default tab and default vhost are working just fine!
Note: I re-logged in to see the changes.
Note2: I do preloading the virtualmin's libraries. I suppose you don't waste the appropriate amount of ram for the convience of your users, if you got any.

@cmroanirgo The new version 14 will be working a bit faster as I made some  improvements.
I just found out that going to Webmin->Webmin Configuration->Web Server Options and setting gzip switch to Use pre-compressed file and compress dynamically, speeds up the whole process by almost  2 times.
You can try it yourself to check.

Been using authentic theme on multiple virtualmins for several months now, never worked.
CentOS 6.3 and 7 as base.
As much as that likely shouldn't be an issue, perhaps it's a contributing factor? (oh, no, I see the OP had this on ubuntu)
I can grant access to a machine exhibiting this behaviour if you'd like to try to debug it.  Also, this has gone on under multiple virtualmin versions (not just one, and I've updated everything) and multiple authentic-theme versions (just tested today on both 13.10 and 14.00)

Been using authentic theme on multiple virtualmins for several months now, never worked.

How you managed to use it for several months if it didn't work? What is not working?

"default tab doesn't work"  The thread issue was (primarily) about the default tab stuff not working, hence my shorthand.  Apologies.

I see. Alright, if you can provide it for debug, that would be find. However, I will ask you come back with me in 2-3 days as I'm in the mid of re-setting up my server, ok?

I've used virtualmin for about 8 years, and webmin since... 1999?  2000?  They work, and I'm comfortable in them.  I found the authentic theme about... 4 months ago?  It's nice - I like it.  The default tab stuff has never worked for me.  It's not a huge deal breaker, but wanted to add in that the OP isn't the only one having the issue.  Again, I can give access to someone to dig on the server and see if you can diagnose it.

sure.  i tried to poke around in the code, but perl's not my strong suit anymore.  was looking for obvious JS bugs that might cause something, but didn't see anything in JS consoles.
This is probably a very easy fix once you can be on a system that is 'broken'.
I've put a video up at https://vimeo.com/134746471 which will be ready to view in about 30 minutes. (free plan queued up for processing!)
@qooob - how about you ping me at<EMAIL_ADDRESS>when you're ready and I'll either grant access to an existing server or set up a new one.

Ok, right from the first second watching :) the reason is that Authentic Theme is not set as default theme in global settings. You set the theme as a user in Webmin->Change Language and Theme module. It will not work this way.
Please go to Webmin->Webmin Configuration->Themes->Change Theme and set Authentic Theme as default. After doing so, you will have nice login screen as on Theme YouTube video presentation.
@mgkimsal Tell me if it works for you?
@cmroanirgo Please, man, also tell how it is for you?

that seemed to work.  would be useful if it wasn't a requirement, but I've not written a theme, so not sure of the requirements.

I will check but I think that would no be possible otherwise. Because, theme uses it's on session_login.cgi and sets some cookies on init.

After install webmin i do see blank page why?

There are many reasons.
What system are you running it on?
Do you have default port opened?

ubuntu 16

how do i open default port?

On Ubuntu you could use:
sudo ufw allow 10000
sudo ufw allow 20000

You must also make sure that Webmin is running.
What is the output of curl -L localhost:10000

Error - Document follows
This web server is running in SSL mode. Try the URL https://localhost:10000/ instead.

Okay, great.
Just type in your browser: https://localhost:10000/ and hit enter.

on vps

not on my local computer

Actually it might not work. Try different.
Find the IP (inet):
ip addr show

Then type in URL:
https://x.x.x.x:10000

get this
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet <IP_ADDRESS>/8 scope host lo
valid_lft forever preferred_lft forever
inet6 ::1/128 scope host
valid_lft forever preferred_lft forever
2: ens4: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1460 qdisc mq state UP group default qlen 1000
link/ether 42:01:0a:8e:00:04 brd ff:ff:ff:ff:ff:ff
inet <IP_ADDRESS>/32 brd <IP_ADDRESS> scope global ens4
valid_lft forever preferred_lft forever
inet6 fe80::4001:aff:fe8e:4/64 scope link

Try:
https://<IP_ADDRESS>:10000

not working

ping <IP_ADDRESS>

Actually, looking at your configuration, broadcast doesn't seem to set correctly.
Ask your VPS provider for network configurations.
Then make sure that you set your server interface correctly.

ok


Misc Performance

https://github.com/NodeRedis/node-redis-parser/blob/master/lib/javascript.js#L42 changing this huge if else block to a switch would improve the perf quite a bit 👍
Would do a PR myself but my battery is at 4%, send help. 🆘
EDIT: doing a PR now, lots of perf increases!

Chunking way faster now. And simple strings so far are about 900% faster, will post benchmarks in a mo.


Step identifier other than title

We use localization for titles and some of the step titles are quite complicated (long with spaces, including accented characters and so on) to be used as an identifiers for the step (e.g. current-step attribute). I think it would be great to add some kind of ID which is NOT the title of the step and use it instead of the title to point to a step (e.g. in a goTo or current-step).
<wizard current-step="'continuing'">
    <wz-step title="Getting started" name="starting">
        ...
    </wz-step>
    <wz-step title="Continuing and so on" name="continuing">
        ...
    </wz-step>
</wizard>

I will add this to my next push, trying to find time to get all of these issues and pull requests handled, ill update you when I have a due date

+1 on this one. I'll try to take a jab at it.

@kocsenc you ever write any code for this? If not I can add the ID attribute in the next release.

@jacobscarter I wish I did. But sadly no.


XIII Small Changes to nbterm

Hello David,
I'm offering You small changes to nbterm. It's just a few keys mapping.
Feel free to scratch the whole or accept the changes.
Some of the additions are:

support for php, c, java, javascript kernels
additional j,k vi-like mappings in command mode
basci ctrl-f search (currently opening dialog in external editor)
n, ctrl-n search for the string forward, backwards
m,  - mark the cell
',  - go to marked cell
ctrl-p - run all cells
some info to readme regarding other kernels
that's about it

Thank You for You great work and have a nice day

P.S. the result from the workflow (mypy, pytest, formatter) seems ok
https://github.com/mtatton/nbterm/actions/runs/1031453534

Replaced by 0.0.14


Profile branch ready to merge

The main thing to merge from profile is the account/manage directories.
There are some changes that I did make outside the profile specific page in order to ensure functionality:

An ApplicationUser model was created
All references to IdentityUser were changed to ApplicationUser
Profile page specific CSS was added to wwwroot/css

Changes I made in the following can be ignored:

register.cshtml
Views/Shared/layout.cshtml

For some reason I'm having a hard time pulling it up on my end. I'd like to look at it during our meeting. Don't forget, you'll have to take care of those conflicting files before we can merge.


add a "skip next line" pragma

Some configuration files, like Java's .properties files and Docker's Dockerfile, don't allow inline comments. This PR adds support for a "skip next line" pragma to solve this use case. For example:
# pragma: allowlist nextline secret
password=xyz

This should solve #319.

Totally missed the top comment and link to the diff in your previous review. Sorry about that. 😅
Just to double check, is this the line in question? https://github.com/Yelp/detect-secrets/blob/pre-v1-adding-verification/detect_secrets/core/scan.py#L165 It looks like GH can't scroll to a line in a diff that's not part of the diff context.

Yup, that's the one.

Hey @domanchi, just want to follow up on this. Is there anything left unresolved at this point?

I think that's everything, but just lmk if there's anything more to be done here. 🙂

Ah whoops. Did not mean to close this PR by cleaning up my branches. I will merge your changes manually.

This has been merged: https://github.com/Yelp/detect-secrets/pull/355/commits/b73c473c1df6c417c69391ce447a9fc042f9e1ef

Hello @domanchi ! When can we expect to see this change published?


Lapatylin.toml

https://github.com/anoma/namada-testnets/commits?author=lapatylin
Description
All previous genesis validators should name their PRs "Update {validator_alias}.toml for tesntet-15" and provide links to previous PRs merged.
If this is an UPDATE for a previous genesis validator
Checks are made against your net_address. If this has changed since the previous testnet, make sure you provide links of previous prs merged from your previous git username.
Thanks in advance!
Checklist before merging

[ ] Only one toml is added in this PR
[ ] The file being added is indeed a .toml file
[ ] The toml being added is to the correct folder, and only to the correct folder
[ ] The eth_hot_key and eth_cold_key are present
[ ] The email, discord, elements telegram, and twitter fields are present and valid

Filename contains whitespace
This PR has been automatically closed because it does not follow the correct procedure for updating the genesis file.

Filename contains whitespace
This PR has been automatically closed because it does not follow the correct procedure for updating the genesis file.

No validator section found
TOML file is not valid


Built-in free subscription tier

We want an easy way for users to follow/subscribe to maintainers, especially so they can follow their posts.
Currently, it's possible to have free subscription tier but it suffers from the following limitations:

The maintainer has to create such subscription tier and set the price to zero.
The subscription process is the same and goes through Stripe (with a simplified form nonetheless)

As it'll be core to Polar experience, we would like to streamline this:

[ ] Create a free subscription tier by default — with its own type so it's easy to identify it and apply special logic in backend/frontend

[ ] In combination with #1748, add a benefit on this tier granting access to the default post audience

[ ] Have a dedicated subscription flow for this tier that doesn't go through Stripe. It means:

[ ] A specific API which would expect either a logged-in user or an email address
[ ] Create a Subscription object directly without any time limitation and not tied to a Stripe subscription

Thanks for adding this to the backlog @frankie567. I've removed (strikethrough) the task around tying access to posts via benefits. Why?
Starting simple, we'll only offer segmenting posts by Free or Paid (any paid subscription). We believe that will be the most common use case to start. However, we (or I at least) expect additional segmentation to become a feature request. We can then later expand the product to allow the maintainer to select a certain tier(s) they want it to be accessible for. Or chose to filter by benefit, i.e if they have multiple benefits of type "premium post", e.g "Educational material", "Roadmap Updates" or what have you.
So initially, we're not going to tie the logic to benefits. Just paid subscriptions (binary) to unlock paid content.
With this said, we should still create the "premium post" type of benefit. Just that it will be more of a social construct and marketing upsell the maintainer can customize for their paid tiers vs. technically required to unlock such access beyond the paid subscription itself. Later, in case we add additional filtering based on tiers/benefits, we could promote the maintainer to create different versions of it that they can then use in filtering.
I hope my explanation makes sense? Let me know if not and I can share a Loom talking it through instead :)

I understand, @birkjernstrom, but, to be honest, I don't agree with this approach.
It looks like we'll need to have specific logic to check if the user has an active (paid) subscription or not to grant him access to the posts. Said another way, we totally bypass the Benefits system which is exactly designed for this, i.e. grant access to things depending on your subscription.
I don't really see why it would be more difficult/time-consuming to just create the benefit and tie it to the Post logic than tinkering with a dummy one.

The way I see it, we would have two main objects:

Post
Audience

A Post is tied to an Audience and an Organization (i.e. maintainer).
An Audience is tied to an Organization (i.e. maintainer) and to one or several User (i.e. people who can read the posts).
At first, we can pre-create two Audience (Free and Premium) for each Organization and not let the user create/modify them.
Then, we can implement a PostBenefit which would have a single parameter: which Audience it grants access to. The granting logic is quite straightforward: add the newly subscribed user to the Audience.
To display posts to the user, we'll just need to make a query filtering the posts for the Audience there are into.

That looks pretty straightforward to me and would lay pretty solid foundations for future expansions of this feature. Besides, it would be a great demonstration of what we can achieve with the benefits system.


App Service - Instance internal health check Load Balancer URL

Hello Team,
The documentation for the "Authentication and Security" section for health check should include that when a new Web App is created the default listener will be created as secure "HTTPS" protocol. However when you setup the Web App health probe for your various instances you cannot set which protocol to use or the ability to update the probe to use a custom domain.  Therefore the health probe will automatically fail unless you select "HTTPS-Only".
Default Web App.

Health Check:

Authentication and security
Health check integrates with App Service's authentication and authorization features. No additional settings are required if these security features are enabled. However, if you're using your own authentication system, the Health check path must allow anonymous access. If the site is HTTPS-Only enabled, the Health check request will be sent via HTTPS.
Please feel free to reach out to me if you have any questions.
-Chris

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20c42a13-f6cb-1e60-0438-f7f32b86a336
Version Independent ID: 79e7dd15-24aa-2e6d-cee7-7714e1940c11
Content: Monitor the health of App Service instances - Azure App Service
Content Source: articles/app-service/monitor-instances-health-check.md
Service: app-service
GitHub Login: @msangapu-msft
Microsoft Alias: msangapu

@ChrisClarkRs, Thanks for the feedback! We are taking a look into this and will get back to you soon.

ChrisClarkRs, I have assigned the issue to the content author to review further and update the document as appropriate.

Hi @ChrisClarkRs, sorry for the delay. We'll be updating this doc and I'd moving your feedback here: https://github.com/MicrosoftDocs/azure-docs/issues/72998

Consolidating feedback to 72998. closing this #please-close


#27: add index.html fallback

[x] If path does not end with / and exists, just return it. Else:

[x] If path does not end with /:

[x] Append / and fallback-file to path and look for that
[x] If that exists, append / to request.rawPath and redirect there.
[x] If not, return 404

[x] If path does ends with /:

[x] Append fallback-file to path and look for it
[x] If that exists, return it
[x] If not, return 404

[x] Fallback-file is index.html, but this might change later: #57. Prepared for this.

Needs a solution to #58, as well as docs (#59) and updated unit tests (#60: unit tests will fail before this). This PR is only functionality.

Complete for release v1.0? @rymsha


[pebble] low mem error on Bangle.js

Hello, I'm using the latest cutting edge firmware on Bangle.js and this app isn't working anymore. When I try to start it, I get a lowmem error, even with almost no apps installed. I know it says the app is tailored for Bangle.js 2 but until recently it was working on Bangle.js, too. Any chance anyone can fix it? :)

Thanks for the quick fix. I can confirm everything is working now :)


middle click on result details

needs to be popup on middle click, or stay in window on left click
safari and chromium handle differently, need to test on both

fixed - need href, and handle both click and auxclick events to work in all browsers


Implementing drag & drop to apply materials

issue: https://github.com/appleseedhq/appleseed/issues/1543

I posted it but I dont think I will have a answer, from what I have tested, the problem come from the fact MainWindow is drop enabled. When your leave RenderWidget, Qt still think you are inside RenderWidget but QDragMoveEvent is now relative to MainWindow, which is why my check does not fully work.
This bug will not break the software but it would be nice to fix it.

Alright, let's merge this PR as is. We'll think of a fix.

Thanks for your contribution!


支持select_scatter/slice_scatter/tensor_split转换

PR Docs

https://github.com/PaddlePaddle/docs/pull/6666
PR APIs

torch.Tensor.select_scatter
torch.Tensor.slice_scatter
torch.tensor_split
torch.Tensor.tensor_split

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.