Provide change log for plugin

It would be very helpful to have a change log that summarizes each release of the plugin.  This could include new features, bug fixes, enhancements, or other information.  The de facto convention appears to be a file called CHANGELOG.md in the root of a repository.  Here's some unofficial info about GitHub change logs (it even has its own change log)...
https://github.com/olivierlacan/keep-a-changelog/blob/gh-pages/README.md
On a related note, each release could be tagged in order to populate this list...
https://github.com/awslabs/aws-codedeploy-plugin/releases
And finally, thank you for providing a REALLY useful plugin!  I really appreciate it.

Instead of maintaining a change log we'll start tagging all future releases with a brief description of updates and bug fixes. Thanks for your feedback.

Perfect. Thank you!


add cf value of "current" stack to template vars

This gives templates a way to reference the parameters under "cf" in a stack the
config file without referencing a stack name directly. The "currentstack" key in
the map passed to the template will contain the "cf" map of the stack which is
being generated.
In this way, a single template can be used by multiple different stacks and have
different outputs.
If you can think of a cleaner way to achieve something like this, please let me know. I'm also very open to changing the name "currentstack".
I'd also like to call out that this could be a backwards incompatibility if someone had a stack named "currentstack" already.

Hey Matt, thanks for this.
I believe I implemented something similar, you're able to reference which stack is calling a template by using {{ .stack }}, this however, only gives you the name of the stack calling the templates, you would need to use if-statements to swap values.
I think your method is better as the values are also accessible using {{ $.currentstack.etc }}.
So i'd recommend, overriding my {{ .stack }} functionality with this.  Should just be removing line 632 in stack.go and changing currentstack to stack.
Thanks again :-)

I've made that change:
I like the simplicity of your suggestion, but are you concerned that there will no longer be access to the current stack name?
I'm also hesitant since this is a breaking change to anyone currently using {{ .stack }}.

Ye, you're right, this will be a breaking change, but i'm still in beta, so no better time to do it :-)
The main reason I added {{ .stack }} was for the exact functionality you've added, so i'm more keen on going with your solution here, as it's a bit cleaner than an if-block and scales better.
Currently working on 0.60-beta, hopefully get it out later tonight, so i'll implement another keyword, possibly, {{ .stack_name }} to replace {{ .stack }}.
Thanks again Matt 👍


Integration Test - Release - 2019/04/25 01:41:40

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest3 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


Introduce admin api to get broker and namespace-isolation policy map

Motivation
Right now, with multiple namespace-isolation-policies, it is little bit tricky to find out list of brokers which are part of shared pool by going through regex. we also want to know policies attached to every broker for isolation policy analysis.
Modifications
Introduce admin api

Get list of brokers with namespace isolation policy attached to them
get specific broker with namespace isolation policy attached to it

Result
it will not impact any existing functionality.

There are some compilation errors:
2018-04-12\T\23:34:40.670 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:testCompile (default-testCompile) on project pulsar-broker: Compilation failure: Compilation failure:
2018-04-12\T\23:34:40.670 [ERROR] /home/jenkins/jenkins-slave/workspace/pulsar_precommit_cpp/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApiTest2.java:[840,17] cannot find symbol
2018-04-12\T\23:34:40.670 [ERROR]   symbol:   method getBrokersWithNamespaceIsolationPolicy(java.lang.String)
2018-04-12\T\23:34:40.670 [ERROR]   location: interface org.apache.pulsar.client.admin.Clusters


perf: new header map implementation

This change swaps out the current header map implementation for one that
is heavily optimized for performance. We implement our own string implementation
used for headers, as well as a new map implementation that allows direct access
to all headers that Envoy uses during fast path processing. We attempt to copy
and allocate as little as possible. There are some more wins that can be had that
are noted in the code but this change is too large as it is and we can do some
of them in follow ups.

@lyft/network-team this change looks giant, and it is, but a few notes to help review it:

Do not look at the diff for header_map.h, header_map_impl.h, and header_map_impl.cc. Just look at them as new files.
Most of the rest of the prod changes will be obvious and are just using the new interfaces.
The vast majority of the test changes are just replacing HeaderMapImpl -> TestHeaderMapImpl since HeaderMapImpl no longer has niceties that make writing tests easy.

might be out of scope of this review, but i'd really want to have state change diagram or explanation which we are doing in header_map_impl and changing states under various conditions.


Question about .register_module() function

Hello, I noticed in the mmlab tutorial that when registering a custom module, it seems that modifying the corresponding __init__.py file is required for the model to be successfully registered and used by the build_model() function in other files. However, I didn't see such operation in thinktwice. Could you please tell me how is it achieved?
@DETECTORS.register_module()
class EncoderDecoder(BaseModule):
    def __init__(self,
                img_encoder,
                decoder,
                lidar_encoder=None,
                num_cams = 4,
                use_depth=False,
                use_seg=False,
                downsample_factor=16,
                seg_downsample_factor=2,
                train_cfg=None,
                test_cfg=None,
                ):
        super().__init__()

@xanhug Thanks for your interests.  We note that some of the modules are not built by mmcv mechanism and we choose the brute-force building directly by Pytorch for fast development.
Besides, make sure you are reading the document of  mmcv 1.x version since the latest/default mmcv 2.0/mmengine has made significant API changes.

@xanhug Thanks for your interests. We note that some of the modules are not built by mmcv mechanism and we choose the brute-force building directly by Pytorch for fast development.
Besides, make sure you are reading the document of mmcv 1.x version since the latest/default mmcv 2.0/mmengine has made significant API changes.

thanks for your reply.


feat: add drizzle

Closes #
✅ Checklist

[ ] I have followed every step in the contributing guide (updated 2022-10-06).
[ ] The PR title follows the convention we established conventional-commit
[ ] I performed a functional test on my final commit

Changelog
[Short description of what has changed]

Screenshots
[Screenshots]
💯

next-auth + drizzle isn't a super happy story at the moment 😓

Why? Worked when I tried it 🙄

How about considering Lucia instead of next-auth?
It pairs well with Drizzle and Kysely. Lucia's v1 works well, and v2 is on its way.

Fixes #1452

nextauthjs/next-auth#8258 https://authjs.dev/reference/adapter/drizzle
Next Auth now has an official drizzle adapter

This comment is buried way up but here's the latest one for y'all:
pnpm create<EMAIL_ADDRESS>

Looks like we can't quite do that @c-ehrlich.
Can we somehow detect this exit in the action and exit the action gracefully from there?
Or maybe we can add an if-statement to the action
- name: Check valid config
  if: ${{ matrix.prisma == "true" && matrix.drizzle == "true" }} # unsure of exact syntax
  run: # graceful exit

Nice, now the Drizzle + Prisma exits early: https://github.com/t3-oss/create-t3-app/actions/runs/6052746581/job/16426820256?pr=1461

Ship 🚢

Thanks a lot to all of you who have contributed to this 🙏


[Enhancement] DKIM-Signature header includes headers (in h= tag) that do not present in actual email

What Operating System are you seeing this problem on?
Ubuntu 22.04.3 LTS
What Hardware is this system running?
Google Cloud Platform
KumoMTA version
2023.11.28-b5252a41
Did you try the latest release to see if the issue is better (or worse!) than your current version?
No, and I'll explain why below
Describe the bug
I appreciate the flexibility provided by the current configuration options, particularly within the dkim_data.toml file.
However, I have identified an improvement that could enhance the precision and efficiency of DKIM-Signature headers. Currently, the MTA includes headers as specified in the dkim_data.toml file, regardless of whether these headers are present in the email itself.
I propose that DKIM-Signature headers only include the headers specified in the dkim_data.toml file if and only if those headers are present in the actual email.
To Reproduce
No response
Configuration
# The default set of headers to sign to include
headers = ["CC", "List-Id", "Resent-Date", "Content-Description", "List-Owner", "Resent-From", "Content-Id", "List-Post", "Resent-Message-ID", "Content-Transfer-Encoding", "List-Subscribe", "Resent-Sender", "Content-Type", "List-Unsubscribe", "List-Unsubscribe-Post", "Resent-To", "Date", "MIME-Version", "Sender", "From", "Message-ID", "Subject", "In-Reply-To", "References", "To", "List-Archive", "Reply-To", "List-Help", "Resent-Cc"]

Expected Behavior
KumoMTA was supposed to include only the following headers in DKIM-Signature: header as only these were present in the email.
h=Date:To:From:Subject:Message-Id
Anything else?
No response

The current behavior is because DKIM signatures can attest that the listed headers were not present in the original mail; this excerpt is from https://www.rfc-editor.org/rfc/rfc6376.html#section-5.4

Signers MAY claim to have signed header fields that do not exist
(that is, Signers MAY include the header field name in the "h=" tag
even if that header field does not exist in the message).  When
computing the signature, the nonexisting header field MUST be treated
as the null string (including the header field name, header field
value, all punctuation, and the trailing CRLF).

INFORMATIVE RATIONALE: This allows Signers to explicitly assert
the absence of a header field; if that header field is added
later, the signature will fail.

If we were to make header signing conditional on the header being present, it would need to be through an additional separate option so that the sender can choose which behavior they desire.
What is your objection to the current behavior?  Is it because the default in the docs is a rather long list of headers that are not always present, and it results in a larger signature header?  Is the size of the signature header an issue in practice?
Would it perhaps be reasonable to change that example to something shorter?

Over signing missing headers helps to prevent DKIM replay attacks where a malicious party adds headers that were not in the header list, and is a desirable feature. If there was an error or automatic filter on missing headers from showing in the header list, this security feature would not be possible.

Thanks for citing the relevant section from RFC 6376. I wasn't aware of that.
I made the request based on how I saw DKIM-Signature in emails sent by open source and commercial MTAs. I'm not sure if the larger signature header would be a problem but I can tell, it's uncommon to include headers that do not present in emails.
I would prefer to have a way to tell KumoMTA that you can sign the specific headers if-present. In my test email, I saw 29 headers included in h= though only 5 needed to be present.

Syed did you include a header list in your DKIM signing config? The signer should only sign for headers you specify if you did specify a header list.
Sent from a mobile device.

From: Syed Alam @.>
Sent: Saturday, December 9, 2023 2:39:00 PM
To: KumoCorp/kumomta @.>
Cc: Mike Hillyer @.>; Comment @.>
Subject: Re: [KumoCorp/kumomta] [Enhancement] DKIM-Signature header includes headers (in h= tag) that do not present in actual email (Issue #110)
Thanks for citing the relevant section from RFC 6376. I wasn't aware of that.
I made the request based on how I saw DKIM-Signature in emails sent by open source and commercial MTAs. I'm not sure if the larger signature header would be a problem but I can tell, it's uncommon to include headers that do not present in emails.
I would prefer to have a way to tell KumoMTA that you can sign the specific headers if-present. In my test email, I saw 29 headers included in h= though only 5 needed to be present.
—
Reply to this email directly, view it on GitHubhttps://github.com/KumoCorp/kumomta/issues/110#issuecomment-1848676229, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC4KGZZK66VNS6SPBQ72BG3YITD6JAVCNFSM6AAAAABAN2JDWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYGY3TMMRSHE.
You are receiving this because you commented.Message ID: @.***>

Yes, the 29 headers were configured in DKIM signing config and that's why they were added to h=. I basically have to know in advance what headers will present in email and then specify the required headers only in config.

That is only the case if you do not want to assert the absence of those headers when they are not present. Otherwise you can configure h= to the list of all possible headers you want to assert on, knowing that they all get signed for, either their presence or absence. There's not many headers where signing the absence of the header will break something further down the chain, otherwise the header should not be in the list anyway.

From: Syed Alam @.>
Sent: Sunday, December 10, 2023 5:15 AM
To: KumoCorp/kumomta @.>
Cc: Mike Hillyer @.>; Comment @.>
Subject: Re: [KumoCorp/kumomta] [Enhancement] DKIM-Signature header includes headers (in h= tag) that do not present in actual email (Issue #110)
Yes, the 29 headers were configured in DKIM signing config and that's why they were added to h=. I basically have to know in advance what headers will present in email and then specify the required headers only in config.
—
Reply to this email directly, view it on GitHubhttps://github.com/KumoCorp/kumomta/issues/110#issuecomment-1848919706, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC4KGZZVPPXEDFEAOY3RRYLYIWDV7AVCNFSM6AAAAABAN2JDWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBYHEYTSNZQGY.
You are receiving this because you commented.Message ID: @.***>


2018.3 managed code stripping fix

When using Medium or High code stripping with Unity 2018.3 on iOS (IL2CPP) CloudOnce causes a crash as reflection code is stripped.
Not very elegant but using this link.xml allows preserving all CloudOnce code which fixes the crash. I think this can be also fixed by using the Preserve attribute for the code that uses reflection but it was hard for me to to track & find all so I've opted with link.xml method.
Here is an example crash code:
NullReferenceException: Object reference not set to an instance of an object.
at CloudOnce.Internal.GameData.MergeWith (CloudOnce.Internal.GameData otherData) [0x00000] in <00000000000000000000000000000000>:0
at CloudOnce.Internal.DataManager.MergeLocalDataWith (System.String otherData) [0x00000] in <00000000000000000000000000000000>:0
at CloudOnce.Internal.Providers.iOSCloudSaveWrapper.LoadImpl (System.String devString) [0x00000] in <00000000000000000000000000000000>:0
at CloudOnce.Internal.Providers.iOSCloudProvider+<>c__DisplayClass20_0.b__0 (System.Boolean success) [0x00000] in <00000000000000000000000000000000>:0
at UnityEngine.SocialPlatforms.GameCenter.GameCenterPlatform.AuthenticateCallbackWrapper (System.Int32 result, System.String error) [0x00000] in <00000000000000000000000000000000>:0
(Filename: currently not available on il2cpp Line: -1)

Thanks for the PR. I'll merge it early next week when I get a chance to update GPGS again.


[Gardening] ffi/native_callables_async_structs_by_value_generated_test/2 RuntimeError (expected Pass)

The tests
ffi/native_callables_async_structs_by_value_generated_test/2 RuntimeError (expected Pass)

are failing on configurations
vm-linux-release-riscv64-qemu

logs
cc @liamappelbe

Duplicate of #48645


Improve and enhance as a standalone tool

https://github.com/danielfdickinson/perfectionist-dfd/issues/38


Error after 30 seconds of fetch execution.

Describe the bug
I have a long executing request on my Go backend and once the fetch request takes more than 30 seconds, I get this error. With axios everything works fine.

await fetch('http://localhost:8080/g4', {
    method: 'POST',
  })

r := gin.Default()
r.POST("/g4", func(c *gin.Context) {
    time.Sleep(40 * time.Second)
}

Reproduction
Expected behavior
No response
Platform and versions
Environment
› OS: Mac OS 12.6.0 X64
› Node.js: 18.10.0
› npm: 8.19.2
› pnpm: 7.13.0
› yarn: 1.22.19
› rustup: Not installed!
› rustc: 1.64.0
› cargo: 1.64.0
› Rust toolchain:
Packages
› @tauri-apps/cli [NPM]: 1.1.1
› @tauri-apps/api [NPM]: 1.1.0
› tauri [RUST]: 1.1.1,
› tauri-build [RUST]: 1.1.1,
› tao [RUST]: 0.14.0,
› wry [RUST]: 0.21.1,
App
› build-type: bundle
› CSP: unset
› distDir: ../dist
› devPath: http://localhost:1420/
› framework: Vue.js
App directory structure
├─ dist
├─ node_modules
├─ public
├─ src-tauri
├─ .git
├─ .vscode
└─ src
Stack trace
No response
Additional context
No response

As far as i know attohttpc (the http client our fetch implementation uses by default) has a default timeout of 30 seconds. You could try changing the request timeout to a higher number or to 0 which should disable it:
await fetch('http://localhost:8080/g4', {
    method: 'POST',
    timeout: 60
  })

I have tried but this doesn't work and the error report for timeout is not the same.

Can you try the reqwest client then to check if it's not related to attohttpc#118. You can switch the client by adding the "reqwest-client" feature flag to the tauri dependency in Cargp.toml

attohttps will be removed in tauri v2: https://github.com/tauri-apps/tauri/pull/6468


来看了好多次server的代码有没有push，啥时候push啊？

来看了好多次server的代码有没有push，啥时候push啊？

@luyiisme
辛苦了:+1:

@luyiisme any updates?

需不需要帮忙

@linzon We were still working on it, probably open source the server side in a couple of mouth later.

欢迎大家贡献适配主流的存储库 #57


Prioritised demo css over src

Probably want to demo using component source all the time, but just in case someone wants to hack together a change but not include it in the src/, it makes sense anyway to have demo/ styling override the src/.

to be honest, i dont think this would be helpful, i really want the css for the component to be the most important thing on the page. there should not be any need for overrides... i havent come across a need yet anyway


chore: typed response codes

Reason for Change:

Upgrade the response codes from raw int to a first-class ResponseCode type. Implicitly guarantees that the codes being returned are a known response code, since returns must be correctly typed to compile.
Issue Fixed:

Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests

Notes:

failing test is unrelated and was introduced in https://github.com/Azure/azure-container-networking/pull/960#issuecomment-894521249


react/jsx-max-depth false positive

With the react/jsx-max-depth rule enabled with default settings, I get a false positive with the following code:
const TABLE_HEADERS = (

    {'Title'}

    {'Estimate'}

    {'Priority'}
    {'Timeframe'}

);

It reports:
  12:5  error  Expected the depth of nested jsx elements to be <= 2, but found 4   react/jsx-max-depth
  13:5  error  Expected the depth of nested jsx elements to be <= 2, but found 5   react/jsx-max-depth
  14:5  error  Expected the depth of nested jsx elements to be <= 2, but found 6   react/jsx-max-depth
  15:5  error  Expected the depth of nested jsx elements to be <= 2, but found 7   react/jsx-max-depth
  16:5  error  Expected the depth of nested jsx elements to be <= 2, but found 8   react/jsx-max-depth
  17:5  error  Expected the depth of nested jsx elements to be <= 2, but found 9   react/jsx-max-depth
  18:5  error  Expected the depth of nested jsx elements to be <= 2, but found 10  react/jsx-max-depth
  19:5  error  Expected the depth of nested jsx elements to be <= 2, but found 11  react/jsx-max-depth

It appears that maybe there's a false positive when a tag is self-closing, but I'm also confused as to why it registers 4 instead of 2 on line 12, which maps to the first th tag above.

In what context is TABLE_HEADERS used?

It looks like this:
render() {
  return (

{TABLE_HEADERS}

  );
}

I realized that the 4 instead of 2 bit was because it measures the nesting of all elements in the file, regardless of indirection, but still the count going up is a little odd.

Indeed, the tr there is at the 4th level, and the th's each on the 5th.
I don't think being self-closing matters, or else the lines with two non-self-closing th tags in a row wouldn't have incremented the count - but there's definitely a bug here with the reported count in the error message.


Set bundle_root to current directory by default

Is your feature request related to a problem? Please describe.
It's easy to misconfigure the bundle root when copying bundle files around. I would suggest to use "bundle_root": "$os.getcwd()".
Then issues like #144 could be avoided.
Describe the solution you'd like
Set bundle_root in all models to "bundle_root": "$os.getcwd()" by default.
Describe alternatives you've considered
Current hard-coded paths for bundle_root can cause confusion and might be unexpected to have to configure for users.
Additional context
Tested spleen_ct_segmentation with "bundle_root": "$os.getcwd()" and it seems working as expected.

Hi @wyli ,
What do you think about it?
Thanks.

I think putting a good default value makes sense... Also the device default could be cuda0 if has cuda else cpu0?

Thanks @holgerroth . Hi @Nic-Ma and @wyli , how about address this ticket after this release?

Sure. This is not urgent.

Sometimes user might not be in the same directory.  When people use bundles programmatically, there is a higher chance of such situation where user is invoking the scripts from a different user directory.
I think It's ok to have invalid directory than unknown directory.
Especially when the script allows to run python statements through json files.  Atleast user will know that he/she has to fix the path for bundleroot instead of seeing something messed up in his/her current working directory.

Also we never have valid train/validation dataset values correctly configured in these scripts..

If one follows the instructions, e.g. here for spleen_ct_segmentation bundle, then they already assume the user being inside the bundle root folder itself
python -m monai.bundle run training --meta_file configs/metadata.json --config_file configs/train.json --logging_file configs/logging.conf

So, the current user directory shouldn't be messed up but output files will be added only the bundle folder - which makes sense to me. We are only talking about the default behavior. For other programmatic uses of bundle, you would probably have to change the bundle_root anyhow as we do for example in MonaiAlgo

Hi @SachidanandAlle , here I wish to follow up with this ticket. What do you think of @holgerroth 's suggestion? I agree that for default value, we can unify to use current directory (at least for bundles contributed by MONAI teams) for convenience (users do not need to modify too much things when running the example commands).

Yes.. we can go ahead and make the changes as @holgerroth suggested.  I have verified it to be working for some bundles.


[O11Y-217] always use int64 to represent row indexes

This PR unifies external APIs to always use int64 instead of int for row indexes.

What's the motivation behind this change?

Go makes no strong guarantees on the capacity of a int value, it's "at least 32 bits", and there may be more than 2 billion rows to in a parquet file (or set of merged files).

I see a bunch of casting like int64(len(...)). I'd expect that value to be at most the maximum value of int. When int is only 32 bits, isn't the program still not going to be able to handle sets of more than 2B values?

I see a bunch of casting like int64(len(...)). I'd expect that value to be at most the maximum value of int. When int is only 32 bits, isn't the program still not going to be able to handle sets of more than 2B values?

On 32 bits systems, I would expect that the maximum memory addressable by a program would be 2GiB, so it wouldn't be possible to create slices which exceed the available memory.

On 32 bits systems, I would expect that the maximum memory addressable by a program would be 2GiB, so it wouldn't be possible to create slices which exceed the available memory.

I'd expect that too. Is that a change to future-proof the API then?


sbt compatible publish for mill

Contributor Checklist

[x] Did you add Scaladoc to every public function/method?
[x] Did you add at least one test demonstrating the PR?
[x] Did you delete any extraneous printlns/debugging code?
[x] Did you specify the type of improvement?
[x] Did you state the API impact?
[x] Did you specify the code generation impact?
[x] Did you request a desired merge strategy?

Type of Improvement

bug fix

API Impact
None
Backend Code Generation Impact
None
Desired Merge Strategy

Rebase: You will rebase the PR onto master and it will be merged with a merge commit.

Reviewer Checklist (only modified by reviewer)

[ ] Did you add the appropriate labels?
[ ] Did you mark the proper milestone (1.2.x, 1.3.0, 1.4.0) ?
[ ] Did you review?
[ ] Did you mark as Please Merge?

Currently mill will only publish in ~/.ivy2/local/edu.berkeley.cs/firrtl-2.12.10_2.12/1.3-SNAPSHOT/, which is non-compatible to sbt build.
This patch will overwrite artifactName from firrtl-$crossVersion_$artifactScalaVersion to firrtl-$artifactScalaVersion, giving the same directory with sbt.

While this looks fine, I think it highlights a potentially larger issue. Why is mill publishing the artifact as firrtl-2.12.10_2.12? I get that it's a cross module but there is semantic meaning in that String, mainly that firrtl_2.12 is FIRRTL publishes against Scala 2.12, the 2.12.10 is (to my understanding) nonstandard. Is this something that other mill users have run into and solved this way?

@jackbackrack I look back into mill souces:
_2.12 is defined for artifactSuffix,which is based on scalaVersion, it can be changed to _2.12.10 with def crossFullScalaVersion = true,
firrtl-2.12.10 is from artifactName, which is from millOuterCtx.segments ++ Seq(millOuterCtx.segment). It means split user commands and join them with '-'. Thus it leads to CrossModule parameters exist in artifactName.
Maybe this behavior can help Cross in small version?(but open crossFullScalaVersion can also do this).
utest from lihaoyi also has this behavior:
https://github.com/lihaoyi/utest/blob/9067c938660831d2cbe7b73ef388256a728ba0f0/build.sc#L5
Emmm, I'm not sure what's the design purpose here.

Interesting, my guess is it's a wart but who knows. The fact that utest has the same thing convinces me that this is the right solution.


Removed vulnerability by checking for valid methods

I removed the edge case of sorting by applicant_age_when_event_starts since the order should remain the same in comparison to a sort by age

Coverage remained the same at 100.0% when pulling 21d8a85162faec83b17baa60f488724c2c49ed42 on 513_remote_code_execution_vulnerability into 619abfc5bd310933b8c34101943332d385ede7f1 on dev.

Coverage remained the same at 100.0% when pulling 31b7538634ce90fbfb8b91a948bf6af2a80b6882 on 513_remote_code_execution_vulnerability into 619abfc5bd310933b8c34101943332d385ede7f1 on dev.


Allow parsing of multiple visual or collision elements

Now re-targeted at melodic-devel with suggested issues addressed

Thanks Shane.  Merging.


Fix crackling audio when using Sink

Fixes #318.
Fixes #319.
Fixes #266.
Combined, these two fixes also fix crackling audio on my computer. The reason for the crackling audio was that Done did not implement size_hint so it would always fall back to a frame size of 512. Somewhere down the pipeline this causing crackling every 512 samples I suspect (which might be worth fixing too).
The current_frame_length fix is necessary because in my case I was playing from a sound file and it returns a size hint on the format (very_large_number, Some(very_large_number)) and the current_frame_length method would just ignore that and fall back to a frame length of 512 samples anyway.
This might also fix #225 (I am running on linux, so I cannot test that).

Is this method really the right place to clamp it though? If a method further down the pipeline needs to break things up into chunks for more efficient buffering it should be free to do that anyway, right?
The frame_len is only supposed to be an upper bound on the allowed buffer if I understand it correctly.

In a test I changed it to always return Some(4096) and that does get rid of the crackling as well.

Hmm yeah I think I misread src/source/buffered.rs. It's fine.

Hmmm, actually UniformSourceIterator::bootstrap does use the frame size without any limits. Might want to have some limit there.

@HalfVoxel PRs welcome!

I would gladly open one, but I'm not sure what the best limit value is? I haven't got enough insight into the library to have a feel for the possible consequences.

buffered.rs uses 32768. I guess that value is okay.


Preparation for Packaging

Describe your improvements
Started packaging process by changing the project structure and defining the setup configuration.
To Reproduce
Follow the steps outlined in the README.md.

Hey @fuzhanrahmanian, I started this PR to make packaging of this project possible. I noticed that currently, the alexnet.py uses luna/pretrained_models/data/meta_clsloc.mat, which is not included in the project. Should we include this or can we maybe get rid of this requirement?

I removed unused code from the alexnet file, so that the .mat file is not needed anymore. However, in googlenet.py, we still have:
googlenet.load_weights(os.path.join(os.path.dirname(__file__), 'googlenet_weights.h5')), and in models.py we have     return alexnet.alex_net("alexnet_weights.h5"), which are referring to static files. We should think about how to remove that in a future PR.


Login not working (cookies expired)

The NaturalCrit site has a hardcoded date to expire cookies, set to December 18, 2018. This has prevented anyone from logging in since this morning.
The issue is on the NaturalCrit repository, so only @stolksdorf has access to edit the code.
Please be patient with us until the problem is corrected. Thanks!

Just pushed out the fixed for this. Apologize for the delay.


Issues with GCE and service type LoadBalancer

Now that publicIPs have become deprecatedPublicIPs, and is on its way out. I have found a couple of issues dealing with service type LoadBalancer.

It doesn't support UDP (if I recall correctly this is being addressed)
Doesn't support static IPs on GCE. I can't seem to find a way to create a LoadBalancer service on kubernetes, and then assign an existing static IP you already have on GCE to it. So if you delete the service and create it again, there is no way to go back to the old IP you had, even if you still own that IP (GCE) and is free to be used.
It creates a target pool per each service. So if I have 70 services and I scale the cluster, I have to manually go thru all 70 backends and update its members. It will be nice if LoadBalancer type had a way to pass which backend to use, if it doesn't exists create it, otherwise reuse it. At the end all backends point to the same set of minions, why create one per each service?

Use cases:

DNS: this applies for 1 and 2
Any service that requires an static IP, lets say a company web site: this applies for 2
If you have a lot of services and decide to scale the cluster... have fun: applies for 3.

The way I used to deal with those use cases was to manually create the forwarding rules on GCE using only one backend and then create a service clusterIP with publicIP set to the GCE loadbalancer IP. This solves 1, 2 and 3.
Am I looking at this from the wrong angle and missing something? Is there anyways to deal with those issues without publicIPs / deprecatedPublicIPs ?

+cc @cjcullen / know who else to rope in?

UDP: Yes, it should not actually be a big change it just didn't get done.  #2849
Static IP: This is actually two problems.  part 1 is "I want o keep an IP".  Until proper support is done you can just not delete your Service object.  part 2 is "I want to use a specific IP".  This is, in fact missing from the current API.  It's not a very big change, I think, but it's also not done.  I just don't think it can be squeezed in before 1.0, but it should be easy after 1.0.  I opened a new issues for this - #10323
TargetPools - those should be updated automatically.  If that is not the case, it's a bug.  The rationale is that a future rev of kube-proxy would be smarter about choosing local backends, and the LB would then not target all nodes, but just the nodes with backends.  Anyway, the service controller is supposed to be updating target pools, I think.  If it is not doing that, please please open a bug on that specifically.
@a-robinson
The reason this API was changed is because the old way SO loose it was hard to do safely and it while it worked on GCE, it did not work on any other platforms (afaik).
I hope that explains, if not softening the blow.
Given that there are issues open for the individual points, I am going to close this (just for tidiness).  That doesn't mean you can't re-open it if you think this is insufficient or want to discuss it more deeply :)

Yes, the target pools are updated automatically by the service controller when nodes are added or removed from the cluster. If they're not being updated for you, it's most definitely a bug.


Primate should not use oauth2proxy with latest tag

See https://github.com/oauth2-proxy/oauth2-proxy/issues/1669.
At least the used image tag should be configurable.

Fixed by #23

It would be great if you could also release a new version of the helmchart 😄

@brumhard ^^

@DerRockWolf yeah sorry, it's released now.


object mergewith method added

resolves #48

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@5ac1d31). Click here to learn what that means.
 Consider uploading reports for the commit acdda58 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage        ?   81.23%
=======================================
  Files           ?      347
  Lines           ?     3256
  Branches        ?      486
=======================================
  Hits            ?     2645
  Misses          ?      610
  Partials        ?        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


files not saving to BASE_AUTO_GPT fix.

I was having trouble finding the files that AutoGPTCommands was saving. I had understood BASE_AUTO_GPT to be the directory where it was saving and still couldn't find it.
So I took a look in the code and found some issues. I'm going to be honest, I don't know how to do pull requests so I'm just gonna put it here and maybe someone else will find it helpful.
my .env file
OPENAI_API_KEY=my-key-here
#ELEVENLABS_API_KEY=your-elevenlabs-api-key
FAST_LLM_MODEL="gpt-3.5-turbo"
SMART_LLM_MODEL="gpt-3.5-turbo"
#GOOGLE_API_KEY=your-search-api-key
#CUSTOM_SEARCH_ENGINE_ID=your-custom-search-engine-id
SEARX_URL=http://my-searchx-server-here.com
SEARX_USERNAME=''
SEARX_PASSWORD=''
BASE_AUTO_GPT=/root/AutoGPTCommands/auto_gpt_workspace

So the entire time I was looking for it inside of /root/AutoGPTCommands/auto_gpt_workspace but it wasn't there.
I did eventually find that it was saving inside of the scripts folder. Seemed weird because then what was the point of my BASE_AUTO_GPT variable.
Inside of the file scripts/file_operations.py, I noticed that the functions:
read_file_lines(filename, start_line, end_line, text, allow_outside=False)
write_to_file(filename, text, allow_outside=False)
append_to_file(filename, text, allow_outside=False)
all had these lines inside:
# scripts/file_operations.py
if allow_outside:
    filepath = os.path.join("/home/dev/Auto-GPT/", filename)
else:
    filepath = safe_join(working_directory, filename)

That filepath here is hardcoded when it shouldn't be. I noticed that in the function:
read_file(filename, allow_outside=False)
it had our variable of base_auto_gpt that held our environment variable BASE_AUTO_GPT
So I changed the other functions to follow suit.
When I ran the AI again, I noticed that it still didn't save anything to my BASE_AUTO_GPT directory unless I changed allowed_outside to True. However, just to avoid any issues by doing that I looked at the functions that were calling the above functions and added these lines to the top of scripts/commands.py:
# scripts/commands.py
# import functions here
# ....

cfg = Config() # was already here didn't add this.

# added these
base_auto_gpt = os.environ.get('BASE_AUTO_GPT')
allow_outside = False
if base_auto_gpt: allow_outside = True

# all other code below ...
# ...

# I then added the allow_outside variable below like so inside the existing `execute_command`
def execute_command(command_name, arguments):
# ....
# ...
    elif command_name == "read_file":
        return read_file(arguments["file"], allow_outside=allow_outside
    elif command_name == "write_to_file":
        return read_file(arguments["file"], arguments["text"], allow_outside=allow_outside
    elif command_name == "append_to_file":
        return read_file(arguments["file"], arguments["text"] allow_outside=allow_outside
# ...

This then solved my issue and started saving all my output logs by AutoGPTCommands inside the directory I wanted to use in the BASE_AUTO_GPT variable for .env
BASE_AUTO_GPT doesn't have to be set now. The code will still work and just default to placing the output files inside of scripts/auto_gpt_workspace as its default location if BASE_AUTO_GPT is missing.
Hope this helps.

Fix has been merged.


Set up Figma

[x] Set up account / customize profile
[x] Make profile/project public
[x] Add link to files in /style
[x] Add link/icon to footer

Profile: https://www.figma.com/@proudlyserving
Assets: https://www.figma.com/community/file/1012141776299219993
Style guide: https://proudlyservingbook.com/style/

FYI @rebeccawoodbury


Develop

Hello @gwenchee! Thanks for submitting the PR.

In the file d3ploy/no_inst.py, following                are the PEP8 issues :

Line 25:1: E302 expected 2 blank lines, found 1
Line 48:80: E501 line too long (85 > 79 characters)
Line 49:15: E131 continuation line unaligned for hanging indent
Line 54:80: E501 line too long (86 > 79 characters)
Line 55:15: E131 continuation line unaligned for hanging indent
Line 55:80: E501 line too long (88 > 79 characters)
Line 62:80: E501 line too long (91 > 79 characters)
Line 63:15: E131 continuation line unaligned for hanging indent
Line 63:80: E501 line too long (95 > 79 characters)
Line 65:80: E501 line too long (84 > 79 characters)
Line 69:1: W293 blank line contains whitespace
Line 86:80: E501 line too long (80 > 79 characters)
Line 120:34: E225 missing whitespace around operator
Line 121:32: E225 missing whitespace around operator
Line 122:34: E225 missing whitespace around operator
Line 123:29: E225 missing whitespace around operator
Line 124:28: E225 missing whitespace around operator
Line 125:33: E225 missing whitespace around operator
Line 126:37: E225 missing whitespace around operator
Line 127:37: E225 missing whitespace around operator
Line 131:80: E501 line too long (86 > 79 characters)
Line 150:80: E501 line too long (86 > 79 characters)
Line 151:80: E501 line too long (86 > 79 characters)
Line 157:5: E303 too many blank lines (2)
Line 159:80: E501 line too long (99 > 79 characters)
Line 160:80: E501 line too long (84 > 79 characters)
Line 164:20: E225 missing whitespace around operator
Line 167:80: E501 line too long (107 > 79 characters)
Line 167:101: E225 missing whitespace around operator
Line 169:15: E271 multiple spaces after keyword
Line 172:41: W291 trailing whitespace
Line 175:80: E501 line too long (87 > 79 characters)
Line 176:80: E501 line too long (83 > 79 characters)
Line 177:80: E501 line too long (90 > 79 characters)
Line 178:35: E225 missing whitespace around operator
Line 182:5: E303 too many blank lines (2)
Line 213:80: E501 line too long (87 > 79 characters)
Line 220:5: E303 too many blank lines (2)
Line 229:5: E303 too many blank lines (2)
Line 231:80: E501 line too long (88 > 79 characters)
Line 251:80: E501 line too long (82 > 79 characters)
Line 252:58: E251 unexpected spaces around keyword / parameter equals
Line 252:60: E251 unexpected spaces around keyword / parameter equals
Line 253:60: E251 unexpected spaces around keyword / parameter equals
Line 253:62: E251 unexpected spaces around keyword / parameter equals
Line 253:80: E501 line too long (82 > 79 characters)
Line 262:80: E501 line too long (82 > 79 characters)
Line 263:58: E251 unexpected spaces around keyword / parameter equals
Line 263:60: E251 unexpected spaces around keyword / parameter equals
Line 264:60: E251 unexpected spaces around keyword / parameter equals
Line 264:62: E251 unexpected spaces around keyword / parameter equals
Line 264:80: E501 line too long (82 > 79 characters)
Line 310:5: E303 too many blank lines (2)
Line 326:46: E251 unexpected spaces around keyword / parameter equals
Line 326:48: E251 unexpected spaces around keyword / parameter equals
Line 350:48: E251 unexpected spaces around keyword / parameter equals
Line 350:50: E251 unexpected spaces around keyword / parameter equals
Line 368:32: E231 missing whitespace after ','
Line 373:48: E251 unexpected spaces around keyword / parameter equals
Line 373:50: E251 unexpected spaces around keyword / parameter equals
Line 387:1: W391 blank line at end of file

In the file tests/fcn_unit_tests.py, following                are the PEP8 issues :

Line 10:1: E402 module level import not at top of file
Line 11:1: E402 module level import not at top of file
Line 12:1: E402 module level import not at top of file
Line 30:1: W293 blank line contains whitespace
Line 32:80: E501 line too long (121 > 79 characters)
Line 33:1: W293 blank line contains whitespace


fixed width problem for .hero

100vw does not account for eventual horizontal scrollbars, but renders to the full width, which results in an unnecessary vertical scrollbar.
This change should most likely also be made in the master branch at /pages/settings/settings.css but as this page also has overflow:hidden, I thought I'd leave it like that for now.

Looks good, thanks!


Final Meeting with clients

their place, 12:00 19/06
iter4

some changes has been made - done
they were satisfied :)


UCP instructions to create grant for a service account out of sync with UI

Problem description
UI and instructions for creating a grant for a service account do not align with current UI (UCP 3.0.2):

For instance, there is no left pane in the above screenshot, taken from UCP 3.0.2.   Current instructions:

To give the service account access to cluster resources, create a grant with
Restricted Control permissions.

Navigate to the Grants page and click Create Grant.

In the left pane, click Resource Sets, and in the Type section,
click Namespaces.

Select the nginx namespace.

In the left pane, click Roles. In the Role dropdown, select
Restricted Control.

In the left pane, click Subjects, and select Service Account.

Service account subject type
The Service Account option in the Subject Type section appears only
when a Kubernetes namespace is present.
{: .important}

In the Namespace dropdown, select nginx, and in the
Service Account dropdown, select nginx-service-account.

Click Create.
{: .with-border}

Problem location

I saw a problem on the following URL: https://docs.docker.com/ee/ucp/kubernetes/create-service-account/#create-a-grant

Project version(s) affected
UCP 3.0
Suggestions for a fix
Re-write and update screenshot to match current UI.

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!


Please suppress duplicate threads requests

Threads requests can be expensive (e.g. https://github.com/microsoft/debug-adapter-protocol/issues/159), so it would be great if the editor avoided sending duplicate ones when the program is stopped and the state is not changing. Please see issue https://github.com/golang/vscode-go/issues/940 for details on when dups can occur. It would be great if requests issued on stopped events and not just on thread events were checked for duplication. Even if we avoid pulling duplicate information from the debug backend in the debug adapter, we would still need to send the duplicate responses back, which could be a performance hit. Getting to the root of the duplication on the editor end would be most efficient.

@polinasok agreed, VS Code should not request threads unnecessarily.

Agreed.
@polinasok can you please create a reproducible steps using Mock debug or js debugging so I can reproduce this on my machine.
If that is not convenient we also accept PRs that would potentially fix this on the VS Code side.
You can put a breakpoint here and check when the threads is called duplicated.
Thanks


timeline loop ignores delay

this.tweens.timeline({
	targets: image,
	loop: 10,
	tweens: [{
		alpha: 0,
	},
	{
		alpha: 1,
		delay: 1000
	}]
});

The first time this plays, the delay of the second tween is applied. The remaining loops it is ignored and alpha tweens from 0 back to 1 immediately.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Thank you for submitting this issue. We have fixed this and the fix has been pushed to the master branch. It will be part of the next release. If you get time to build and test it for yourself we would appreciate that.


Upgrade from Nuget Package v11|Ads v10 to Nuget Package v14.2|Ads v12 cause INVALID_LOGIN_CUSTOMER_ID

Given the sunsetting of Ads v10 and the deprecation of Ads v11, I am upgrading our app to use version v14.2 of this nuget package and the v12 version of the Ads API. It used v11.0.0 of the nuget package with Ads version v10 before. The exact same API calls succeed in the old versions, but fail with an INVALID_LOGIN_CUSTOMER_ID error in the new versions. I enabled request logging and I noticed some differences between the request sent by the old package vs the new package, but unclear if those differences are related and/or responsible for the issue. (tokens and customer ids are the same across calls)

Host: in the request with the new nuget package is not populated as it is in the old nuget package. Wondering if that could be the cause of the issue with the validation of the login-customer-id.
(Probably minor?) The various versions the tools have changed as shown in the x-goog-api-client header, interestingly the new nuget package has gccl/2.1.0 instead of gccl/11.0.0 in the old nuget package.

A couple of questions re: the usage of the nuget package

Is there something that changed in the nuget package that prevents the Host: from being populated in the request?
Anything that changed with the Desktop oAuth2 flow between those package versions?
Could the difference in grpc versions (2.41.0 before, 2.46.3 now) be related to the issue with the Host:?
Is downgrading of the gccl an issue or expected?

Code snippet of how our app invokes the API
var developerToken = "";
var mccAccountNumber = "";
var oauthClientId = "";
var oauthClientSecret = "";
var oauthRefreshToken = "";

var config = new GoogleAdsConfig
{
    DeveloperToken = developerToken,
    LoginCustomerId = mccAccountNumber,
    OAuth2Mode = OAuth2Flow.APPLICATION,
    OAuth2ClientId = oauthClientId,
    OAuth2ClientSecret = oauthClientSecret,
    OAuth2RefreshToken = oauthRefreshToken
};
var client = new GoogleAdsClient(config);
var service = client.GetService(GoogleServices.V12.GoogleAdsService);

var budget = new CampaignBudgetOperation();
// Set the properties on budget
var mutateOperations = new List<MutateOperation> { new MutateOperation { CampaignBudgetOperation = operation } };
var request = new MutateGoogleAdsRequest
{
    CustomerId = account.ImmutableId.ToString(),
    PartialFailure = true
};
request.MutateOperations.AddRange(mutateOperations);

var callSettings = client.ServiceContext.CallSettings;
client.MutateAsync(request, callSettings);
...

Request/Response logged from GoogleAds v14.2 / Ads API v12
GoogleAds.DetailedRequestLogs Information: 1: [2023 - 01 - 04 23: 34: 39Z] -
-------------- - BEGIN API CALL-------------- -

Request
------ -

Method Name: /google.ads.googleads.v12.services.GoogleAdsService/Mutate
Host:
Headers: {
    "x-goog-api-client": "gl-dotnet/5.0.0 gapic/14.2.0 gax/4.0.0+7489c236e0a5801d0f6e89bf1c23433f48521956 grpc/2.46.3 gccl/2.1.0 pb/3.21.5+638779f353731a0a04496bde20d14164684c3d93",
    "developer-token": "REDACTED",
    "login-customer-id": "REDACTED",
    "x-goog-request-params": "customer_id=REDACTED"
}
{
    "customerId": "REDACTED",
    "mutateOperations": [{
            "campaignBudgetOperation": {
                "create": {
                    "deliveryMethod": "STANDARD",
                    "period": "DAILY",
                    "name": "REDACTED",
                    "amountMicros": "1000000000",
                    "explicitlyShared": false
                }
            }
        }
    ],
    "partialFailure": true
}

Response
--------
Headers: {
    "request-id": "LYpklyZ85eUYCQG9OyuvlA",
    "date": "Wed, 04 Jan 2023 23:34:39 GMT",
    "alt-svc": "quic=\":443\"; ma=2592000",
    "google.ads.googleads.v12.errors.googleadsfailure-bin": "Cl4KA5AEAxJXVGhlIGxvZ2luIGN1c3RvbWVyIGlkIGhlYWRlciAnT3B0aW9uYWxbNDAzNzAwODc2OCwgNDAzNzAwODc2OF0nIGNvdWxkIG5vdCBiZSB2YWxpZGF0ZWQuEhZMWXBrbHlaODVlVVlDUUc5T3l1dmxB",
    "grpc-status-details-bin": "CAMSJVJlcXVlc3QgY29udGFpbnMgYW4gaW52YWxpZCBhcmd1bWVudC4awAEKRHR5cGUuZ29vZ2xlYXBpcy5jb20vZ29vZ2xlLmFkcy5nb29nbGVhZHMudjEyLmVycm9ycy5Hb29nbGVBZHNGYWlsdXJlEngKXgoDkAQDEldUaGUgbG9naW4gY3VzdG9tZXIgaWQgaGVhZGVyICdPcHRpb25hbFs0MDM3MDA4NzY4LCA0MDM3MDA4NzY4XScgY291bGQgbm90IGJlIHZhbGlkYXRlZC4SFkxZcGtseVo4NWVVWUNRRzlPeXV2bEE="
}

Fault: {
    "StatusCode": 3,
    "Details": "Request contains an invalid argument.",
    "RequestId": "LYpklyZ85eUYCQG9OyuvlA",
    "Failure": {
        "errors": [{
                "errorCode": {
                    "headerError": "INVALID_LOGIN_CUSTOMER_ID"
                },
                "message": "The login customer id header 'Optional[REDACTED, REDACTED]' could not be validated."
            }
        ],
        "requestId": "LYpklyZ85eUYCQG9OyuvlA"
    }
}
----------------END API CALL----------------

Request/Response logged from GoogleAds v11.0.0 / Ads API v10
GoogleAds.DetailedRequestLogs Verbose: 1: [2023 - 01 - 04 23: 43: 00Z] -
-------------- - BEGIN API CALL-------------- -

Request
------ -

Method Name: /google.ads.googleads.v10.services.GoogleAdsService/Mutate
Host: https: //googleads.googleapis.com
Headers: {
    "x-goog-api-client": "gl-dotnet/5.0.0 gapic/11.0.0 gax/3.5.0+6cfcac416e08abe8a5d580f8d87095c9fdba577e grpc/2.41.0 gccl/11.0.0",
    "developer-token": "REDACTED",
    "login-customer-id": "REDACTED",
    "x-goog-request-params": "customer_id=REDACTED"
}
{
    "customerId": "REDACTED",
    "mutateOperations": [{
            "campaignBudgetOperation": {
                "create": {
                    "deliveryMethod": "STANDARD",
                    "period": "DAILY",
                    "name": "REDACTED",
                    "amountMicros": "1000000000",
                    "explicitlyShared": false
                }
            }
        }
    ],
    "partialFailure": true
}

Response
--------
Headers: {
    "content-disposition": "attachment",
    "request-id": "oK70D1SKOlLgLaUFyxoQXA",
    "date": "Wed, 04 Jan 2023 23:43:00 GMT",
    "alt-svc": "h3=\":443\"; ma=2592000,h3-29=\":443\"; ma=2592000,h3-Q050=\":443\"; ma=2592000,h3-Q046=\":443\"; ma=2592000,h3-Q043=\":443\"; ma=2592000,quic=\":443\"; ma=2592000; v=\"46,43\""
}
{
    "mutateOperationResponses": [{
            "campaignBudgetResult": {
                "resourceName": "customers/REDACTED/campaignBudgets/REDACTED"
            }
        }
    ]
}
----------------END API CALL----------------

You may have already checked this but when you updated the Ads API Nuget package, the fresh placeholder values for the API connection are added into the app.config. Did you remove those empty values so your existing working values are use by the Ads Library? I know this sounds simple, but I have been caught by this a few times.

You may have already checked this but when you updated the Ads API Nuget package, the fresh placeholder values for the API connection are added into the app.config. Did you remove those empty values so your existing working values are use by the Ads Library? I know this sounds simple, but I have been caught by this a few times.

We are configuring the library at runtime not via an app.config or a json config file. Is an app.config still needed in that case?
var config = new GoogleAdsConfig
{
    DeveloperToken = developerToken,
    LoginCustomerId = mccAccountNumber,
    OAuth2Mode = OAuth2Flow.APPLICATION,
    OAuth2ClientId = oauthClientId,
    OAuth2ClientSecret = oauthClientSecret,
    OAuth2RefreshToken = oauthRefreshToken
};
var client = new GoogleAdsClient(config);
var service = client.GetService(GoogleServices.V12.GoogleAdsService);

This is a duplicate of #481 and happens due to the difference in behaviour of Grpc.Core v/s Grpc.Net.Client. See https://github.com/googleapis/gax-dotnet/issues/672 for an explanation.
To get the old behaviour as a temporary workaround, you can do
config.UseGrpcCore = true;

A more permanent fix would be to construct a CallSetting from scratch instead of modifying client.ServiceContext.CallSettings.
E.g.
CancellationTokenSource source = new CancellationTokenSource(60 * 1000);
CallSettings callSettings = CallSettings.FromCancellationToken(source.Token);
await client.MutateAsync(request, callSettings);

I don't think it is trivial to consolidate the behaviour between Microsoft's and Google's implementation of grpc, but I'll continue exploring that option.


What about generating only the main App.css and not creating a css file for every other scss file?

What about generating only the main App.css and not creating a css file for every other scss file?
Originally posted by @mantsch in https://github.com/facebook/create-react-app/issues/2807#issuecomment-326020949

I don't understand what you're asking, but I think that suggestion doesn't make sense today because we have built in support for sass?


Trying to improve templates UI

Remaining issues:

hover is creating problems with resizing of flex elements shrinking and I'm not sure how to do this properly
should figure out maybe how to have more colors but tailwind doesn't support me dynamically creating new colors because they're not added by default unless in the initial render
templates make the stuff underneath go down, not sure how to structure the design

templates make the stuff underneath go down, not sure how to structure the design
easy fix is to increase the # of lines of the textarea

templates make the stuff underneath go down, not sure how to structure the design
easy fix is to increase the # of lines of the textarea

That pushes down the other (important) stuff though, what are you thinking in terms of maybe putting that to the side?

Let’s spend some time tomorrow morning on this 👍

@Uzay-G will merge this iteration and we can take it from there


AGDIGGER-30 - S2I build support for jenkins image

Motivation
Create Jenkins development base that would allow us to
= add/edit/remove plugins
= change default configuration to the base image.
= remove openshift build pipelines spam jobs from image
Notes
Added plugin would be used to authenticate users in RHMAP platform - configuration for plugin would be added later. In this ticket we just wanted to show how to update/add new plugin so use this as example.
TODO
Update dockerhub description once PR is merged.
Verification
Template published to local machine and public openshift cluster.
Use README.md for steps.
ping @luigizuccarelli

s2i works and then when I follow openshift/README.md, it is all good. Before, I was receiving an error.
It waited in the following state for 10 mins, then it said it failed.
--> Scaling jenkins-1 to 1
--> Waiting up to 10m0s for pods in deployment jenkins-1 to become ready

@wtrocki @luigizuccarelli any ideas?

@aliok I would try to replicate problem on my local machine using your versions and configuration.

Will take a look 👀  here too, but don't wait just on me...

--> Scaling jenkins-1 to 1
--> Waiting up to 10m0s for pods in deployment jenkins-1 to become ready

This is solved by creating a /tmp/jenkins folder with mod 777.
If you're on Mac with docker-machine, then you need to create this folder in your docker-machine vm.

Finally I was able to make Jenkins running on my local Openshift cluster 🎉
@wtrocki @luigizuccarelli I am reporting this but I know this might be out of this task's scope.
When I triggered the job inside Jenkins it doesn't work.
Wanted to compare with https://jenkins-digger.osm3.feedhenry.net, but login does not work there.
I was just curious if it works for you.
Started by user Jenkins Admin
Building in workspace /var/lib/jenkins/jobs/OpenShift Sample/workspace

Starting "Scale OpenShift Deployment" with deployment config "frontend" from the project "test2".
  Scaling to "0" replicas ...
Operation will timeout after 180000 milliseconds
ERROR: Build step failed with exception
com.openshift.restclient.NotFoundException: deploymentconfigs "frontend" not found deploymentconfigs "frontend" not found
	at com.openshift.internal.restclient.okhttp.ResponseCodeInterceptor.createOpenShiftException(ResponseCodeInterceptor.java:112)
	at com.openshift.internal.restclient.okhttp.ResponseCodeInterceptor.intercept(ResponseCodeInterceptor.java:65)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:92)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:67)
	at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:170)
	at okhttp3.RealCall.execute(RealCall.java:60)
	at com.openshift.internal.restclient.DefaultClient.execute(DefaultClient.java:217)
	at com.openshift.internal.restclient.DefaultClient.execute(DefaultClient.java:194)
	at com.openshift.internal.restclient.DefaultClient.execute(DefaultClient.java:183)
	at com.openshift.internal.restclient.DefaultClient.get(DefaultClient.java:291)
	at com.openshift.jenkins.plugins.pipeline.model.IOpenShiftScaler.coreLogic(IOpenShiftScaler.java:70)
	at com.openshift.jenkins.plugins.pipeline.model.IOpenShiftPlugin.doItCore(IOpenShiftPlugin.java:305)
	at com.openshift.jenkins.plugins.pipeline.model.IOpenShiftPlugin.doIt(IOpenShiftPlugin.java:318)
	at com.openshift.jenkins.plugins.pipeline.OpenShiftBaseStep.perform(OpenShiftBaseStep.java:81)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:782)
	at hudson.model.Build$BuildExecution.build(Build.java:205)
	at hudson.model.Build$BuildExecution.doRun(Build.java:162)
	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
	at hudson.model.Run.execute(Run.java:1738)
	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
	at hudson.model.ResourceController.execute(ResourceController.java:98)
	at hudson.model.Executor.run(Executor.java:410)
Build step 'Scale OpenShift Deployment' marked build as failure
Finished: FAILURE

@aliok You need to follow openshift guide for that job, but this have no actual meaning for the things we want to do. Regular jobs are working fine.

@aliok Docs update in different PR for visibility.

👍


Handle inactive generic function call

@swilliamson7 this should solve the Assertionpp->getNumUses() == 0' failed.` error you saw.

Codecov Report
Base: 75.95% // Head: 72.61% // Decreases project coverage by -3.33% :warning:

Coverage data is based on head (b548cb9) compared to base (84233b3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   75.95%   72.61%   -3.34%
==========================================
  Files          17       17
  Lines        5722     5434     -288
==========================================
- Hits         4346     3946     -400
- Misses       1376     1488     +112

Impacted Files
Coverage Δ

src/compiler.jl
75.66% <100.00%> (-0.25%)
:arrow_down:

src/compiler/interpreter.jl
26.53% <0.00%> (-65.63%)
:arrow_down:

src/compiler/orcv2.jl
0.00% <0.00%> (-61.91%)
:arrow_down:

src/compiler/utils.jl
58.57% <0.00%> (-37.32%)
:arrow_down:

src/compiler/optimize.jl
68.84% <0.00%> (-10.69%)
:arrow_down:

src/logic.jl
75.00% <0.00%> (-5.00%)
:arrow_down:

src/api.jl
58.91% <0.00%> (-2.78%)
:arrow_down:

src/compiler/validation.jl
59.59% <0.00%> (-2.48%)
:arrow_down:

src/compiler/pmap.jl
75.27% <0.00%> (-2.27%)
:arrow_down:

src/pmap.jl
83.33% <0.00%> (-1.29%)
:arrow_down:

... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Library using libtensorflow crashes with the TensorFlow packege in Python

First, thanks for attending this issue. As I couldn't find a precise category for this problem, I considered that this one was the better suited. Please let me know if this is not appropriate and I should direct my question somewhere else.
System information

OS Platform and Distribution: Ubuntu 20.04.2 LTS
TensorFlow installed from (source or binary): binary
TensorFlow version: 2.5.0
Python version: 3.8/3.9
Installed using virtualenv? pip? conda?: pip and the C API
CUDA/cuDNN version: None
GPU model and memory: None

Describe the problem
Essentia is a C++ music and sound analysis library with Python bindings that uses the C TensorFlow API for machine learning inference. When Essentia is linked against libtensorflow, and we import both  essentia and tensorflow  in a Python session, a segmentation fault happens. However, they can work perfectly in separate sessions. We are opening this issue as we believe that a similar problem can happen to other projects with a Python interface relying on libtensorflow.
As pointed out in https://github.com/tensorflow/tensorflow/issues/22810#issuecomment-433225466, using the same TensorFlow library should fix the problem. However, even if we pip install tensorflow==2.5.0 and we link Essentia against libtensorflow 2.5.0 the problem persists. Maybe this is because the way TensorFlow is shipped inside the Python wheel is not through libtensorflow so it is not recognized as the same library?
We have found two ways to overcome this issue:

With a static build of TensorFlow. However, this method was only achieved with the contrib Makefile for TensorFlow 1.15. The main problem is that this approach requires substantial patching to the Makefile, and each time it is more difficult to keep track with the updates of the library. Also, this solution makes the final build larger, and we would prefer to avoid it.
Linking against libtensorflow_framework inside the Python wheel. While this approach was working with Tensorflow 1.X, it is not working for Tensorflow 2.X. Also, while this approach was working (and it is our current way to create wheels) it feels a bit hacky, and we would prefer to use libtensorflow.

Our question is, is there a way in which we could link our library against libtensorflow without crashing with the official TensorFlow library in Python?
Provide the exact sequence of commands / steps that you executed before running into the problem
We have Python wheels linked against libtensorflow that can be installed offline. After this:
import tensorflow
import essentia.standard

Any other info / logs
The lines above produce:
2021-07-15 10:15:35.710295: F tensorflow/core/framework/variant_op_registry.cc:66] Check failed: existing == nullptr (0x563975228328 vs. nullptr)Unary VariantDecodeFn for type_name: tensorflow::data::WrappedDatasetVariant already registered
Aborted (core dumped)

We solved this issue by making our own TensorFlow build with Bazel with the monolithic option.
We found that this way libtensorflow is only optionally dependent on libtensorflow_framework.
By patching the pkg-config file generated by TensorFlow to skip libtensorflow_framework  our Python bindings do not clash with TensorFlow anymore:
sed -i 's/ -ltensorflow_framework//' tensorflow.pc


Added BeforeInstall stage and Changed CodeArtifact comamnd in readme

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Thank you @makvac-aws for the recommendations. I have incorporated as a separate commit as I clubbed a few enhancements to include memory profiling too. Please review and would request to test it to ensure it addresses the points you raised.
I will close this PR for now, but please feel free to open, if you see any issues. - Nikunj.


fix: replace native structuredClone() with a polyfill

This PR replaces native structuredClone() with a polyfill to keep compatibility with Node.js v16.

/rtm


KeyError: 'created_by' when building documentation

Full error trace:
# Sphinx version: 5.0.0
# Python version: 3.8.13 (CPython)
# Docutils version: 0.17.1 release
# Jinja2 version: 3.1.2
# Last messages:
#   reading sources... [ 50%] reference/app.crud.crud_role
#   reading sources... [ 51%] reference/app.crud.crud_team
#   reading sources... [ 53%] reference/app.crud.crud_user
#   reading sources... [ 54%] reference/app.db
#   reading sources... [ 56%] reference/app.db.init_db
#   reading sources... [ 57%] reference/app.db.session
#   reading sources... [ 59%] reference/app.initial_data
#   reading sources... [ 60%] reference/app.main
#   reading sources... [ 62%] reference/app.models
#   reading sources... [ 63%] reference/app.models.group
# Loaded extensions:
#   sphinx.ext.mathjax (5.0.0) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/mathjax.py
#   sphinxcontrib.applehelp (1.0.2) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/applehelp/__init__.py
#   sphinxcontrib.devhelp (1.0.2) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/devhelp/__init__.py
#   sphinxcontrib.htmlhelp (2.0.0) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/htmlhelp/__init__.py
#   sphinxcontrib.serializinghtml (1.1.5) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/serializinghtml/__init__.py
#   sphinxcontrib.qthelp (1.0.3) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/qthelp/__init__.py
#   alabaster (0.7.12) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/alabaster/__init__.py
#   sphinx.ext.todo (5.0.0) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/todo.py
#   sphinx.ext.viewcode (5.0.0) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/viewcode.py
#   sphinx.ext.autodoc.preserve_defaults (1.0) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/autodoc/preserve_defaults.py
#   sphinx.ext.autodoc.type_comment (5.0.0) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/autodoc/type_comment.py
#   sphinx.ext.autodoc (5.0.0) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/autodoc/__init__.py
#   sphinx.ext.napoleon (5.0.0) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/napoleon/__init__.py
#   sphinxcontrib.apidoc (0.3.0) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/apidoc/__init__.py
#   sphinxcontrib.autodoc_pydantic (1.7.1) from /Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/autodoc_pydantic/__init__.py
Traceback (most recent call last):
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/cmd/build.py", line 276, in build_main
    app.build(args.force_all, filenames)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/application.py", line 329, in build
    self.builder.build_update()
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 288, in build_update
    self.build(to_build,
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 302, in build
    updated_docnames = set(self.read())
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 409, in read
    self._read_serial(docnames)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 430, in _read_serial
    self.read_doc(docname)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/builders/__init__.py", line 483, in read_doc
    publisher.publish()
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/core.py", line 217, in publish
    self.document = self.reader.read(self.source, self.parser,
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/io.py", line 103, in read
    self.parse()
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/readers/__init__.py", line 78, in parse
    self.parser.parse(self.input, document)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/parsers.py", line 78, in parse
    self.statemachine.run(inputlines, document, inliner=self.inliner)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 170, in run
    results = StateMachineWS.run(self, input_lines, input_offset,
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/statemachine.py", line 239, in run
    context, next_state, result = self.check_line(
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/statemachine.py", line 451, in check_line
    return method(match, context, next_state)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2769, in underline
    self.section(title, source, style, lineno - 1, messages)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 327, in section
    self.new_subsection(title, lineno, messages)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 393, in new_subsection
    newabsoffset = self.nested_parse(
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 281, in nested_parse
    state_machine.run(block, input_offset, memo=self.memo,
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 196, in run
    results = StateMachineWS.run(self, input_lines, input_offset)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/statemachine.py", line 239, in run
    context, next_state, result = self.check_line(
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/statemachine.py", line 451, in check_line
    return method(match, context, next_state)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2342, in explicit_markup
    nodelist, blank_finish = self.explicit_construct(match)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2354, in explicit_construct
    return method(self, expmatch)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2096, in directive
    return self.run_directive(
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/docutils/parsers/rst/states.py", line 2146, in run_directive
    result = directive_instance.run()
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/autodoc/directive.py", line 148, in run
    documenter.generate(more_content=self.content)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/autodoc/__init__.py", line 955, in generate
    self.document_members(all_members)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/autodoc/__init__.py", line 831, in document_members
    documenter.generate(
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/autodoc/__init__.py", line 1788, in generate
    return super().generate(more_content=more_content,
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/autodoc/__init__.py", line 955, in generate
    self.document_members(all_members)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/autodoc_pydantic/directives/autodocumenters.py", line 164, in document_members
    super().document_members(*args, **kwargs)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/autodoc/__init__.py", line 1779, in document_members
    super().document_members(all_members)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/autodoc/__init__.py", line 831, in document_members
    documenter.generate(
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinx/ext/autodoc/__init__.py", line 945, in generate
    self.add_directive_header(sig)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/autodoc_pydantic/directives/options/composites.py", line 259, in wrapped
    result = func(*args, **kwargs)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/autodoc_pydantic/directives/autodocumenters.py", line 539, in add_directive_header
    self.add_default_value_or_marker()
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/autodoc_pydantic/directives/autodocumenters.py", line 586, in add_default_value_or_marker
    if self.needs_required_marker:
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/autodoc_pydantic/directives/autodocumenters.py", line 549, in needs_required_marker
    is_required = self.pydantic.inspect.fields.is_required(field_name)
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/autodoc_pydantic/inspection.py", line 188, in is_required
    return self.get(field_name).required
  File "/Users/pipeknight/.pyenv/versions/3.8.13/lib/python3.8/site-packages/sphinxcontrib/autodoc_pydantic/inspection.py", line 137, in get
    return self.attribute[name]
KeyError: 'created_by'

My conf file:
# Configuration file for the Sphinx documentation builder.
#
# This file only contains a selection of the most common options. For a full
# list see the documentation:
# https://www.sphinx-doc.org/en/master/usage/configuration.html

# -- Path setup --------------------------------------------------------------

# If extensions (or modules to document with autodoc) are in another directory,
# add these directories to sys.path here. If the directory is relative to the
# documentation root, use os.path.abspath to make it absolute, like shown here.
import os
import sys

# Also we may load a dotenv file here
sys.path.insert(0, os.path.abspath('.'))

# -- Project information -----------------------------------------------------

project = 'fastapi-alembic-sqlmodel-async'
copyright = '2022, -'
author = '-'

# -- General configuration ---------------------------------------------------

# Add any Sphinx extension module names here, as strings. They can be
# extensions coming with Sphinx (named 'sphinx.ext.*') or your custom
# ones.
extensions = [
    'sphinx.ext.todo',
    'sphinx.ext.viewcode',
    'sphinx.ext.autodoc',
    'sphinx.ext.napoleon',
    'sphinxcontrib.apidoc',
    'sphinxcontrib.autodoc_pydantic',
]

# Add any paths that contain templates here, relative to this directory.
templates_path = ['_templates']

# List of patterns, relative to source directory, that match files and
# directories to ignore when looking for source files.
# This pattern also affects html_static_path and html_extra_path.
exclude_patterns = ['_build', 'Thumbs.db', '.DS_Store']

# Apidoc options
apidoc_module_dir = '../fastapi-alembic-sqlmodel-async'
apidoc_output_dir = 'reference'
apidoc_excluded_paths = ['tests', 'kafka_test']
apidoc_separate_modules = True
# apidoc_extra_args = ['-d 2']

# -- Options for HTML output -------------------------------------------------

# The theme to use for HTML and HTML Help pages.  See the documentation for
# a list of builtin themes.
html_theme = 'alabaster'
# html_theme = 'sphinx-rtd-theme'

# Add any paths that contain custom static files (such as style sheets) here,
# relative to this directory. They are copied after the builtin static files,
# so a file named "default.css" will overwrite the builtin "default.css".
html_static_path = ['_static']

I have several models in my app with field named created_by, for example:
from sqlmodel import Field, Relationship, SQLModel

class Group(SQLModel, table=True):
    id: Optional[int] = Field(default=None, nullable=False, primary_key=True)
    updated_at: Optional[datetime]
    created_at: Optional[datetime]
    created_by_id: Optional[UUID] = Field(default=None, foreign_key="user.id")
    created_by: "User" = Relationship(  # noqa: F821
        sa_relationship_kwargs={
            "lazy": "select",
            "primaryjoin": "Group.created_by_id==User.id",
        }
    )

And for some reason this broke my docs generation. If I comment 'sphinxcontrib.autodoc_pydantic' in conf.py extensions, than everything works

So maybe it's the problem with supporting sqlmodel library in your extension, which is something like a bridge between pydantic and sqlalchemy

Thanks for reporting the issue here! It is very likely related to sqlmodel. There is a similar issue here #124. I will take a look at it soonish.

Okay, this is related to what a Relationship represents in sqlmodel. In fact, it is not a field (or column) of a pydantic model (or sqlalchemy table).
autodoc_pydantic currently assumes all class attributes of a parent pydantic model to be a pydantic field which is simply wrong in this case. It will require an additional, more explicit check if a class attribute of a pydantic model parent is truly a pydantic field. Luckily, this is not too difficult to implement and it should actually prevent further unwanted side effects.

@all-contributors please add @PipeKnight for bug

@PipeKnight This should be fixed with the current v1.7.2 release of today. Feel free to reopen if the issue persists.


Compilation under linux fix

Hi, this should be probably provided as a pulll-request, but I have some problems with it...
Nevertheless I was recently compiling your tool under linux and it seems that recent libuv (1.8) has changed its deployment.
Instead of uv/threadpool.h or uv/linux.h, uv-threadpool.h and uv-linux.h are used.
I've done following change for libuv/include/uv/unix.h:
44 #include <signal.h>
45
46 #if defined(__linux__)
47 #include "uv-threadpool.h"
48 #else
49 #include "uv/threadpool.h"
50 #endif
51
52 #if defined(__linux__)
53 # include "uv-linux.h"
54 #elif defined (__MVS__)
Would it be possible to integrate it in your code? :)

Sorry, I should probably better document version requirements.
The latest libuv uses uv/threadpool.h instead of uv-threadpool.h.  maxcso requires libuv v1.21.0 or higher, and has not been tested (on any platform) against the old version of libuv you're using.  I recommend updating libuv.
-[Unknown]

Ok, thanks for this info. I'll update my libuv then :)
(Btw. in the meantime I've tested it with this legacy libuv, and everything seems to be working correctly)
We can close the issue.

If it works well (which isn't surprising, I do think older versions of maxcso were tested against an older libuv), I wouldn't be opposed to a #if based on UV_VERSION_HEX.
-[Unknown]


Use of Mutation Events is deprecated. Use MutationObserver instead.

When using and implementing the editor, the message in the title of this issue appears in console.

@davidroyer Can you please check this?

This issue is stale because it has been open for 60 days with no activity.

This issue was closed because it has been inactive for 7 days since being marked as stale.


feat: upgrade tekton helm chart to 0.32.4

Signed-off-by: ankitm123<EMAIL_ADDRESS>

LGTM

@ankitm123 maybe you want to replace the metadata in Chart.yaml automatically
	sed -i "s/^version:.*/version: ${CHART_VERSION}/" ${CHART_DIR}/Chart.yaml
	sed -i "s/^appVersion:.*/appVersion: ${CHART_VERSION}/" ${CHART_DIR}/Chart.yaml

maybe you want to replace the metadata in Chart.yaml automatically

Done.

Great, waiting for it 🎉

@ankitm123 please upgrade to v0.32.4, latest patch available for v0.32.x
is there a way you could publish newer version as well? I would like to manually try them, even if they are not in the version stream

@ankitm123 please upgrade to v0.32.4, latest patch available for v0.32.x
is there a way you could publish newer version as well? I would like to manually try them, even if they are not in the version stream

Yes, I will disable the auto upgrade of tekton charts, so that we can test it out a bit. Also I think version and app version should not be the same, will make a change in this PR to start from 0.1.0.
https://kubernetes.slack.com/archives/C9LTHT2BB/p1657106024046269
Also going to upgrade to 0.32.4 (will read the release notes a bit)

Disabling auto upgrades in the version stream here: https://github.com/jenkins-x/jx3-versions/pull/3233

@nicolaerosia going to release this tomorrow!

But, since this PR separates chart and app version I could make a separate PR with that change instead

Yes!

@ankitm123 any plans for newer tekton as discussed?

@ankitm123 any plans for newer tekton as discussed?

Yes, we should have a new tekton chart next week (We just go all libraries updated to use 0.32.4).


CSS-BESTAND

I am very sorry I didn’t mean that it was my first time and I did not
know this to do
في خميس، ٢١ يناير، ٢٠٢١ في ١٢:٣٠ ص، كتب Mark Otto<EMAIL_ADDRESS>
:

Closed #32856 https://github.com/twbs/bootstrap/issues/32856.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/twbs/bootstrap/issues/32856#event-4230061716, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASQM44CFFZWPWZRSIOKXO3TS25DPTANCNFSM4WKSXYXA
.

I am very sorry I didn’t mean that it was my first time and I did not
know this to do
في خميس، ٢١ يناير، ٢٠٢١ في ١٢:٣٠ ص، كتب Mark Otto<EMAIL_ADDRESS>
:

Closed #32856 https://github.com/twbs/bootstrap/issues/32856.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/twbs/bootstrap/issues/32856#event-4230061716, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASQM44CFFZWPWZRSIOKXO3TS25DPTANCNFSM4WKSXYXA
.


List stations you've created?

I want a simple way to list the stations you've created through the ;talk interface
I'm ~zod, and I write (from /docs/using/messaging.md):
~your-urbit:talk> ;create channel %my-channel 'Some description.'
Can there be something like ;list-stations to print out all the stations I've created, to confirm that this works?
Ideally I would like this to be exposed via Hall as well. (Update: Apparently this is served by Hall already, I just need to figure out how)

This essentially needs a connection between the .^ namespace and %gall, something we don’t have but have wanted to do for a while...
Sent from my iPhone

On Dec 14, 2017, at 1:26 PM, Christopher Johnson<EMAIL_ADDRESS>wrote:
I want a simple way to list the stations you've created.
I'm ~zod, and I write (from /docs/using/messaging.md):
~your-urbit:talk> ;create channel %my-channel 'Some description.'
Can there be something like ;list-stations to print out all the stations I've created, to confirm that this works?
Ideally I would like this to be exposed via Hall as well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

we don't?
➤ cat gen/twit/feed.hoon
::  Display twitter feed
::
::::  /hoon/feed/twit/gen
::
/?    310
/-    twitter
/+  old-zuse
=,  old-zuse
::
::::  ~fyr
::
:-  %say
|=  $:  {now/@da eny/@uvJ bek/beak}
    {{who/iden $~} typ/?($user $home)}

==

=+  pax=/(scot %p p.bek)/twit/(scot %da now)/[typ]/[who]
:-  %tang
%+  turn   (flop .^((list post:twitter) %gx pax))
|=  post:twitter  ^-  tank
rose+[": " `~]^~[leaf+"{} @{(trip who)}" leaf+(trip txt)]
(this is what ++peek and ++peer-scry-x arms are about, in apps that have
them)
On Thu, Dec 14, 2017 at 2:34 PM, cgyarvin<EMAIL_ADDRESS>wrote:

This essentially needs a connection between the .^ namespace and %gall,
something we don’t have but have wanted to do for a while...
Sent from my iPhone

On Dec 14, 2017, at 1:26 PM, Christopher Johnson <
<EMAIL_ADDRESS>wrote:
I want a simple way to list the stations you've created.
I'm ~zod, and I write (from /docs/using/messaging.md):
~your-urbit:talk> ;create channel %my-channel 'Some description.'
Can there be something like ;list-stations to print out all the stations
I've created, to confirm that this works?
Ideally I would like this to be exposed via Hall as well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/urbit/arvo/issues/503#issuecomment-351856916, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABxXhnvajIYZNqJwOQ_wXpn8jeFIvmkcks5tAaJrgaJpZM4RCr8P
.

As we discussed with Mark, it does seem to be exposed via an API endpoint.

Right, we do :-)
On Thu, Dec 14, 2017 at 2:36 PM, Anton Dyudin<EMAIL_ADDRESS>wrote:

we don't?
➤ cat gen/twit/feed.hoon
:: Display twitter feed
::
:::: /hoon/feed/twit/gen
::
/? 310
/- twitter
/+ old-zuse
=, old-zuse
::
:::: ~fyr
::
:- %say
|= $: {now/@da eny/@uvJ bek/beak}
{{who/iden $~} typ/?($user $home)}
==
=+ pax=/(scot %p p.bek)/twit/(scot %da now)/[typ]/[who]
:- %tang
%+ turn (flop .^((list post:twitter) %gx pax))
|= post:twitter ^- tank
rose+[": " `~]^~[leaf+"{} @{(trip who)}" leaf+(trip txt)]
(this is what ++peek and ++peer-scry-x arms are about, in apps that have
them)
On Thu, Dec 14, 2017 at 2:34 PM, cgyarvin<EMAIL_ADDRESS>wrote:

This essentially needs a connection between the .^ namespace and %gall,
something we don’t have but have wanted to do for a while...
Sent from my iPhone

On Dec 14, 2017, at 1:26 PM, Christopher Johnson <
<EMAIL_ADDRESS>wrote:
I want a simple way to list the stations you've created.
I'm ~zod, and I write (from /docs/using/messaging.md):
~your-urbit:talk> ;create channel %my-channel 'Some description.'
Can there be something like ;list-stations to print out all the
stations
I've created, to confirm that this works?
Ideally I would like this to be exposed via Hall as well.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/urbit/arvo/issues/503#issuecomment-351856916, or
mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABxXhnvajIYZNqJwOQ_
wXpn8jeFIvmkcks5tAaJrgaJpZM4RCr8P>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/urbit/arvo/issues/503#issuecomment-351857518, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AALyAYk_fTtIOZlh5UN6uGxQX7z2gXIgks5tAaMGgaJpZM4RCr8P
.


Move map loading to cache

This puts the map parsing/decompressing together with similar routines for the cache, and leaves the map module for the struct and tile access.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[feat] Distinct names for all the different getCurrent functions in the frontend API

Describe the problem
Having 3 different getCurrent() functions for 3 separate concepts (window, webview, and webviewWindow) with exactly the same function name is very confusing and means using as is often a requirement if you're using two at once in the same file.
Describe the solution you'd like
In my opinion these functions should be refactored like so for the sake of clarity: getCurrentWindow, getCurrentWebview, and getCurrentWebviewWindow. It would certainly improve the DX for me.
Alternatives considered
No response
Additional context
No response

I love this change!


Readable COCO and datumaro format for CJK

Summary
Resolve #231.
How to test
Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] I have linked related issues

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Thank you for the PR! Please, add a line (DATUM_231 = ...) in tests/requirements.py and refer to it in the test annotations.

Updated!


Add 'regressor_' prefix to some transforms

IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)

[x] Did you read the contribution guide?
[ ] Did you update the docs? We use Numpy format for all the methods and classes.
[x] Did you write any new necessary tests?
[x] Did you update the CHANGELOG?

Type of Change

[ ] Examples / docs / tutorials / contributors update
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Improvement (non-breaking change which improves an existing feature)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Add 'regressor_' prefix to transforms:

Lags
DateTimeTransform
SegmentEncoder
SpecialDays

Related Issue

Closing issues

closes #74

I have a question: in WindowStatisticsTransform we have offset arg that works as lag (https://github.com/tinkoff-ai/etna-ts/blob/master/etna/transforms/statistics.py#L22); it looks like the transform should create regressor_{statistic_name}_{in_column} column if offset > 0 and {statistic_name}_{in_column} otherwise

Codecov Report

Merging #97 (4d61eef) into master (3fd40e3) will decrease coverage by 3.95%.
The diff coverage is 100.00%.

:exclamation: Current head 4d61eef differs from pull request most recent head 0e80737. Consider uploading reports for the commit 0e80737 to get more accurate results

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   88.72%   84.76%   -3.96%
==========================================
  Files          54       54
  Lines        2430     2429       -1
==========================================
- Hits         2156     2059      -97
- Misses        274      370      +96

Impacted Files
Coverage Δ

etna/transforms/datetime_flags.py
100.00% <100.00%> (ø)

etna/transforms/lags.py
100.00% <100.00%> (ø)

etna/transforms/segment_encoder.py
100.00% <100.00%> (ø)

etna/transforms/special_days.py
98.73% <100.00%> (+0.03%)
:arrow_up:

etna/transforms/pytorch_forecasting.py
26.38% <0.00%> (-73.62%)
:arrow_down:

etna/models/nn/tft.py
45.00% <0.00%> (-55.00%)
:arrow_down:

etna/models/nn/deepar.py
47.36% <0.00%> (-52.64%)
:arrow_down:

etna/loggers/base.py
92.15% <0.00%> (-2.08%)
:arrow_down:

etna/loggers/wandb_logger.py
33.33% <0.00%> (-1.50%)
:arrow_down:

etna/loggers/console_logger.py
92.30% <0.00%> (-0.29%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fd40e3...0e80737. Read the comment docs.

⬆
upd: we will fix it in https://github.com/tinkoff-ai/etna-ts/issues/98

could you please add smth like transform method creates column "regressor_..."?
it is very important to know out column name in case of transforms chain


fix: rename tfgrunt to terragrunt

@microsoft-github-policy-service agree

On Sep 23, 2024, at 15:33, microsoft-github-policy-service[bot] @.***> wrote:
@kevcube https://github.com/kevcube please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:
(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement
http://www.opensource.org/
—
Reply to this email directly, view it on GitHub https://github.com/devcontainers/features/pull/1128#issuecomment-2368265718, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFPABT5FW5RIJQ5D7DSQE3ZYAKCRAVCNFSM6AAAAABOWDD2JCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYGI3DKNZRHA.
You are receiving this because you were mentioned.

@microsoft-github-policy-service agree

@samruddhikhandale I addressed the requested changes, please re-review! Thanks


teqbot posts "null" when stream is down

Instead of posting the teqbot error messages when the stream is down, teqbot posts "null".
Something wrong with how the message is being prepared and subsequently sent out to the slack channel.

Bug fixed in recent update.


Some LaTex commands cannot be rendered

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.61.1 (Universal)
OS Version: Mac OS Big Sur 11.6

Steps to Reproduce:
I launched the Jupyter Notebook with some markdown cells having some Latex commands inside. I discovered that some Latex commands cannot be rendered. See below.

I did not encounter this bug when opening the Jupyter notebook with Anaconda, which opened the notebook at localhost on my browser. So the render problem may be caused by VSCode.

We require two things of the standarized version: a mean of zero and a variance of one. If we let $X$ be the standardized form of $Y$ then $X = \frac{Y-\mu_Y}{\sigma_Y},$ where $\mu_Y$ is the mean of $Y$ and $\sigma_Y^2$ is the variance of $Y.$ Let's check this:
\begin{align*}
E[X] & = E\left[\frac{Y-\mu_Y}{\sigma_Y}\right] = \frac{1}{\sigma_y}E[Y-\mu_Y] = \frac{1}{\sigma_Y}(E[Y]-\mu_Y) = 0  \\
\mbox{Var}(X) & = \mbox{Var}\left(\frac{Y-\mu_Y}{\sigma_Y}\right) = \frac{1}{\sigma_Y^2}\mbox{Var}(Y-\mu_Y) = \frac{\mbox{Var}(Y)}{\sigma_Y^2} = 1
\end{align*}

Here is the text of the code. Thanks.


Fulfillment of the I2c trait contract

This seeks to address the issue with the LinuxI2CDevice not correctly implementing the I2c trait as mentioned in rust-embedded/linux-embedded-hal#82. I am not sure whether the fix really belongs in this repo but since i2c_msg.flags isn't pub then it doesn't seem like there is another way. Setting the flag when the device doesn't implement the feature seems to have no effect which might lead to some confusion.

Looks good now! Thanks for your efforts!

Sorry, now rustfmt is unhappy :face_exhaling:

No worries. I'm just happy to contribute 😀


[gluon] feature request -- parameter save arguments

Could the gluon save function also include an option for

epoch -- like the default mxnet one
global_step
max_to_keep
keep_checkpoint_every_n_hours

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!
Also, do please check out our forum (and Chinese version) for general "how-to" questions.


Citation parser fails for OSHD cases

Full citation not understood.  Still investigating but a number of citations have (page?)
See examples:
Metzler v. Arcadian Corp.  1997 OSHD (CCH) P31,311
CCH OSHD P 20,091 (1975)

Fun one. See also this one about commas, in case there's a conflict of some kind #18.

This has already been fixed in reporters-db, I just added it as a test case here: https://github.com/freelawproject/eyecite/pull/189