"invalid number" warning should be different when only scientific notation is allowed

At the moment, if you enter an invalid number in a number entry part, you're shown the warning message "Your answer is invalid. You must enter an integer or a decimal."
This isn't quite correct when only scientific notation is allowed. The message should be one of:

"You must enter a number in scientific notation" (not helpful if you think you already have)
"You must enter a significand followed by the letter 'e' and an exponent" (uses a couple of words students might not recognise; some lecturers might be pedantic about upper or lower case 'e')
"Your answer is invalid." (Doesn't give any hint at all)

I think the first one is the safest.

I agree the first option is the best - but will the full message retain the first sentence "Your answer is invalid. [...]"? If so, this may be a bit too "harsh", after all at that stage the student may not have finished and the answer may be "partially" valid.
How about dropping that first sentence and go with "Warning: you must enter a number in scientific notation" or something similar?

perhaps include an example of a number in scientific notation?


Enable drawer only for proper accounts

and e.g. not for the Unified Inbox
Fixes #3493
Not ideal because isDrawerEnabled() can change from false to true if account is initialized after isDrawerEnabled() was already called, so that an uninitialized drawer can in principle be invited to be accessed, but it fixes the issue for now.

This needs a little bit more work:

the drawer should only be shown if singleAccountMode && singleFolderMode
lockDrawer and unlockDrawer should be called if it was enabled (once)

Maybe add another boolean function shouldShowDrawer or  showDrawer depending on singleAccountMode && singleFolderMode?

To avoid doing work that won't get merged please create an issue for discussions before implementing a feature.
We want to add an account switcher to the drawer and get rid of the Accounts activity. For the Unified Inbox I imagine we'll be doing something similar to what the Gmail app does and display a separate item in the (folder list part of the) drawer. I want to get rid of the "all messages" pseudo account altogether.
That means the drawer will always be shown and there will always be a "real" account selected.

To avoid doing work that won't get merged please create an issue for discussions before implementing a feature.

It was not really work and only intended as a quick fix for me and maybe others who already want to use the drawer (or just the master branch).
The corresponding issue is #3493. (A better fix for now is 298c33a1c3f43f7c130a477643f636bff83f6785)
Should I keep such "fixes" to myself or prepend a "DO NOT MERGE" to the pull request?

We want to add an account switcher to the drawer and get rid of the Accounts activity. For the Unified Inbox I imagine we'll be doing something similar to what the Gmail app does and display a separate item in the (folder list part of the) drawer. I want to get rid of the "all messages" pseudo account altogether.
That means the drawer will always be shown and there will always be a "real" account selected.

Great! That sounds exactly like what I was hoping for.


speedup unique impressions

When using the :unique option, then a impressions.count == 0is used to validate uniqueness. This requires a full table scan every time (without appropriate indexes):
SELECT COUNT(*) FROM `impressions`
Using !impressions.exists? results in a much more efficient query (but even requires a full table scan when there is no existing impression):
SELECT 1 FROM `impressions` LIMIT 1

Thanks!


The name of this tool

#84 needs extracting the definition of sapi_globals_struct from php-src/main/SAPI.h, and this file is licensed under the PHP license.
And the 4th clause of this license forbids the use of names like "PHP Foo" or "phpfoo" without permission.
Currently, the name of this tool is "php-profiler", so this tool cannot use the definition from files licensed under the PHP license.
There are some options.
a. Changing the name of this tool
b. Getting written permission from<EMAIL_ADDRESS>c. Avoiding the license problem through binary analysis
It seems that phpspy uses the plan c.
I'm not sure whether this is a legit solution.
I've already sent an email to<EMAIL_ADDRESS>asking the permission. But it seems that the mail doesn't appear in any public mailing lists available, so I guess only a limited number of people can read it, thus it unlikely guides the consensus from the community.
So the last option I have to speed up the tool (via #84) is changing the name of this tool.
Currently, I can't think of a good name for it though. :(

strrev('php-profiler') === 'reliforp-php'
So "Reliforp" and "Reli for p(hp)" are the current candidates.


Added some tests

Seems a bit overkill. Just remember to test your code in an actual running Umbraco ;)


add a new example: video-annotation

This PR gives a new example: video annotation, which is useful in some cases. For example, partitioning an audio stream into homogeneous segments according to the speaker identity is difficult, especially when the number of speakers is large, but it will be much easier with visual cues.

Coverage increased (+0.09%) to 79.813% when pulling ccfd14ca7df982c767517e572d28f34706fba664 on xx205:master into bf5ecb6983d5d6179b60e828ded59b3edfbd2afc on katspaugh:master.


fix schema() decorator

As per docs it's fine to pass None:
https://www.django-rest-framework.org/api-guide/views/#view-schema-decorator

Sorry, completely missed github notification. Thanks!


Segmentation fault (core dumped) - face_recognition

Hi
Getting Sementation fault on face recognition. I have included
import faulthandler; faulthandler.enable() to get the output. I wish I could help more but I am not a python programmer.
If i remove the code and just leave the imports , all the others work until i import face_recognition.
pip3 install face_recognition
dlib-19.17
Jeston Nano 4GIG
JetPack 4.6.
DeepStream 6.0
Python 3.6.9
32GIG CARD
OUTPUT
python3 doorcam.py
Fatal Python error: Segmentation fault
Current thread 0x0000007f822b1010 (most recent call first):
File "/usr/lib/python3/dist-packages/apt/init.py", line 35 in
File "", line 219 in _call_with_frames_removed
File "", line 678 in exec_module
File "", line 665 in _load_unlocked
File "", line 955 in _find_and_load_unlocked
File "", line 971 in _find_and_load
File "/usr/lib/python3/dist-packages/apport/packaging_impl.py", line 24 in
File "", line 219 in _call_with_frames_removed
File "", line 678 in exec_module
File "", line 665 in _load_unlocked
File "", line 955 in _find_and_load_unlocked
File "", line 971 in _find_and_load
File "/usr/lib/python3/dist-packages/apport/fileutils.py", line 25 in
File "", line 219 in _call_with_frames_removed
File "", line 678 in exec_module
File "", line 665 in _load_unlocked
File "", line 955 in _find_and_load_unlocked
File "", line 971 in _find_and_load
File "/usr/lib/python3/dist-packages/apport/report.py", line 30 in
File "", line 219 in _call_with_frames_removed
File "", line 678 in exec_module
File "", line 665 in _load_unlocked
File "", line 955 in _find_and_load_unlocked
File "", line 971 in _find_and_load
File "/usr/lib/python3/dist-packages/apport/init.py", line 5 in
File "", line 219 in _call_with_frames_removed
File "", line 678 in exec_module
File "", line 665 in _load_unlocked
File "", line 955 in _find_and_load_unlocked
File "", line 971 in _find_and_load
File "", line 219 in _call_with_frames_removed
File "", line 941 in _find_and_load_unlocked
File "", line 971 in _find_and_load
File "/usr/lib/python3/dist-packages/apport_python_hook.py", line 72 in apport_excepthook
Segmentation fault (core dumped)
Thanks
Robby

Hi, I am facing the same issue. Have you found any solutions yet?

Hi, I am not facing the same issue but I am curious about how you can add this face_recognition library into the pipeline. Hope you could share information.

I encountered the same issue when I use multithreading to execute more than two tasks simultaneously.


RUN instruction in shell mode is not consistant with other executions

Description of problem:
A bin/bash -c will run a single quoted string of commands without the need of \, on newlines, seemlessly. On docker build Error response from daemon: ENV must have two arguments is returned.
It might just be my lack of understanding of how the different shells work, or a missing documentation or a bug. Need clarification.
Environment details
>> docker version
Client:
 Version:      1.8.2
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   0a8c2e3
 Built:        Thu Sep 10 19:21:21 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.8.2
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   0a8c2e3
 Built:        Thu Sep 10 19:21:21 UTC 2015
 OS/Arch:      linux/amd64

>> docker info
Containers: 16
Images: 451
Storage Driver: btrfs
 Build Version: Btrfs v3.17
 Library Version: 101
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 3.19.0-28-generic
Operating System: Ubuntu 15.04
CPUs: 8
Total Memory: 15.57 GiB
Name: zleno
ID: SQQC:7JHE:SHHA:5WGK:77ST:KSP6:6ROK:SKRB:GSUB:KKJZ:MSN6:IJFS
WARNING: No swap limit support

>> uname -a
Linux zleno 3.19.0-28-generic #30-Ubuntu SMP Mon Aug 31 15:52:51 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

Steps to Reproduce:

Dockerfile content

FROM ubuntu

RUN  /bin/bash -c 'echo "-------------------------------------------- start" ;
                   echo $HOME ;
                   echo "-------------------------------------------- echo home" ;
                   env ;
                  '

Command

>> docker build -t test .
Sending build context to Docker daemon 2.048 kB
Error response from daemon: ENV must have two arguments

Expected Results:
>> docker build -t test2 .
Sending build context to Docker daemon 2.048 kB
Step 0 : FROM ubuntu
 ---> 91e54dfb1179
Step 1 : RUN /bin/bash -c 'echo "-------------------------------------------- start" ;                   echo $HOME ;                   echo "-------------------------------------------- echo home" ;                   env ;                  '
 ---> Running in 5db70c358859
-------------------------------------------- start
/root
-------------------------------------------- echo home
HOSTNAME=e611e15f9c9d
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PWD=/
SHLVL=1
HOME=/root
_=/usr/bin/env
 ---> a3c06f9cd4ca
Removing intermediate container 5db70c358859
Successfully built a3c06f9cd4ca

Additional info:
Expected result was gained by using the following Dockerfile content

FROM ubuntu

RUN  /bin/bash -c 'echo "-------------------------------------------- start" ;\
                   echo $HOME ;\
                   echo "-------------------------------------------- echo home" ;\
                   env ;\
                  '

Unfortunately this has nothing to do with bash, or shells in general. This is just how the dockerfile syntax works. Any time you want to continue an instruction onto the next line, it has to be ended with a backslash.
You could argue that docker should be intelligent to see that opening single quote, and that until it sees a non-escaped single quote, it should treat every character as part of the argument. But the dockerfile parser is very basic. And unfortunately changing this behavior would be a very significant breaking change as everyone is used to the current behavior.
As a general rule, when embedding one language inside another (in this case, bash inside dockerfile), you just have to keep in mind the separation between languages.

Thanks @phemmer just made pull request documenting you response.

just made pull request documenting you response.

Thanks @AmeBel :+1:


acme: Adjust DNS challenge TTL to 5 seconds

While more than likely never to come up in a real-world situation, during renewal integration testing a value of 120 seconds has proven to be too high (the old challenge record has not expired by the time the new one is created).

I'm not sure if changing the default is the right thing to do there as I'm pretty sure that many of our supported DNS providers don't even support TTL values that low.
Which DNS provider are you using and getting this problem with?

Hey @xenolf, I've been doing the testing in the R53 provider.
Fair enough on the provider side, looks like DNSSimple only supports a minimum of 1 minute, for example. Route 53 recommends 60 seconds "or less" for health check records - docs link.
I'll check with their support and see what the actual minimum is.

Looks like the Route 53 recommended minimum is 10 seconds (it can go all the way to zero, but they don't necessarily recommend it. I'll fix this up so it's just the Route 53 provider.

@xenolf - now done with an integration test as well. :)

This is looking good, thank you!
I'm sorry I fell behind on this... I had a pretty rough time :)

No worries @xenolf and thanks for the merge!


Add list of alternatives to readme

Coverage remained the same at 100.0% when pulling aa1ce4218f44c54267a51b99be314226f3dbb8ab on alternatives into 8a7a821c900e5b0c5a84999f1631d489fe8b4658 on master.

Coverage remained the same at 100.0% when pulling aa1ce4218f44c54267a51b99be314226f3dbb8ab on alternatives into 8a7a821c900e5b0c5a84999f1631d489fe8b4658 on master.


Python?

I saw like ;  NaoQi C++ framework so it means I will install C++ SDK ? So it means its for c++ developers? Can I install NaoQi Python instead of NaoQi Python

You need to install NaoQi C++ SDK for compiling the ROS driver. After that, you can program in C++ or Python whatever you want

Thanks for the answer so if I understood correctly it's also available for ros1 . Also I didnt understand claerly about these ;
Softbanks's crosstool chain and point the AL_DIR and ALDE_CTC_CROSS environment variables to their respective paths:
export AL_DIR=/home/NaoQi  <-- Or wherever you installed NaoQi
export ALDE_CTC_CROSS=$AL_DIR/ctc-linux64-atom-<IP_ADDRESS>
Where is that AL_DIR or ALDE_CTC_CROSS
I am rookie about that connection sorry for disturb for it


chore(main): release 1.1.5

:robot: I have created a release beep boop
1.1.5 (2023-08-18)
Bug Fixes

修改 auto merge action 配置 (48d3c7f)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/lwsgh/release-please-example/releases/tag/v1.1.5 :sunflower:


md-datepicker throw exception

What is the issue? *
md-datepicker directive, angilar/core 4.2.4, angular/material 1.1.4
when open the month view,it throw error.
same error from angular 1.5: https://github.com/angular/material/issues/10627

Details:
when you open the day view,you can select a month,and then you will open the month view,you will see nothing. And you open the developer tool,you will see the exception message.

HTML
<md-input-container>               <label for="ValidFrom">Gültig bis:</label>               <input mdInput name="ValidTo" [mdDatepicker]="validToDatePicker" [min]="minDate" [max]="maxDate" [(ngModel)]="oe.ValidTo">               <button mdSuffix [mdDatepickerToggle]="validToDatePicker"></button> </md-input-container>             <md-datepicker #validToDatePicker  md-placeholder="Gültig bis" class="field-input full-width"></md-datepicker>
ERROR
Error: Uncaught (in promise): TypeError: date.getFullYear is not a function
TypeError: date.getFullYear is not a function
at<EMAIL_ADDRESS>(http://localhost:4200/vendor.bundle.js:97255:21)
at<EMAIL_ADDRESS>(http://localhost:4200/vendor.bundle.js:97168:43)
at MdDatepickerInput._minValidator (http://localhost:4200/vendor.bundle.js:112974:36)
at http://localhost:4200/vendor.bundle.js:83175:49
at Array.map (native)
at _executeValidators (http://localhost:4200/vendor.bundle.js:83175:23)
at MdDatepickerInput._validator (http://localhost:4200/vendor.bundle.js:83131:33)
at<EMAIL_ADDRESS>(http://localhost:4200/vendor.bundle.js:113140:39)
at http://localhost:4200/vendor.bundle.js:83423:52
at http://localhost:4200/vendor.bundle.js:83175:49
at<EMAIL_ADDRESS>(http://localhost:4200/vendor.bundle.js:97255:21)
at<EMAIL_ADDRESS>(http://localhost:4200/vendor.bundle.js:97168:43)
at MdDatepickerInput._minValidator (http://localhost:4200/vendor.bundle.js:112974:36)
at http://localhost:4200/vendor.bundle.js:83175:49
at Array.map (native)
at _executeValidators (http://localhost:4200/vendor.bundle.js:83175:23)
at MdDatepickerInput._validator (http://localhost:4200/vendor.bundle.js:83131:33)
at<EMAIL_ADDRESS>(http://localhost:4200/vendor.bundle.js:113140:39)
at http://localhost:4200/vendor.bundle.js:83423:52
at http://localhost:4200/vendor.bundle.js:83175:49
at resolvePromise (http://localhost:4200/polyfills.bundle.js:6315:31)
at http://localhost:4200/polyfills.bundle.js:6366:17
at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invokeTask (http://localhost:4200/polyfills.bundle.js:5969:31)
at Object.onInvokeTask (http://localhost:4200/vendor.bundle.js:71783:37)
at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invokeTask (http://localhost:4200/polyfills.bundle.js:5968:36)
at Zone.webpackJsonp.../../../../zone.js/dist/zone.js.Zone.runTask (http://localhost:4200/polyfills.bundle.js:5736:47)
at drainMicroTaskQueue (http://localhost:4200/polyfills.bundle.js:6129:35)
at XMLHttpRequest.ZoneTask.invoke (http://localhost:4200/polyfills.bundle.js:6035:25)
tested on:
Win10, Chrome 59.0.3071.115
Win10, IE11
Win10, Firefox 54.0

@adoris If you are using angular/material 1.1.4 with angular/core 4.2.4, you are not using the correct setup. Please use angular/material 2.0.0-beta.7 with angular/core 4.2.4.

@donroyco i am using angular/material 2.0.0-beta.7 with angular/core 4.2.4. but now also same issue

@mmalerba sounds like there a situation that leads to trying to call getFullYear on a null/undefined value in the native date adatper

@jelbourn I assume you didn't mean to close this?

Yeah, clicked the wrong button

I'm seeing the same thing, but only if I try to set a Min or Max on the input.

@adoris @justingish can one of you please provide a plunker reproduction, this plunker seems to show it working correctly: http://plnkr.co/edit/iz3QNo4mBtjGYbWfo8ZU?p=preview

Closing this as I cannot reproduce, if you are still seeing the issue feel free to provide a reproduction link and I will re-open.

It was user error.  I was binding the input to a string, not an actual date object.  I am using reactive forms, if that makes a difference.
However, I do believe there is room for improvement here because the Min and Max directives are behaving differently than the mdDatePicker.  Binding to a string (eg... '2017-7-5) works just fine for the date picker control until you add a min or max directive to the control.
I have created a plunker to show the issue: http://plnkr.co/edit/Iih5lyGbLO1p5pgriWZK?p=preview

@justingish Thanks for the plunker, that does seem a little strange/inconsistent, reopening.

I am also facing this error. My situation is when i bind it to a formControl in reactive forms.
Error:

<input mdInput [mdDatepicker]="deadlineDatePicker" placeholder="Choose a date" formControlName="deadline">
<button mdSuffix [mdDatepickerToggle]="deadlineDatePicker">

<md-datepicker #deadlineDatePicker>
No error:

<input mdInput [mdDatepicker]="deadlineDatePicker" placeholder="Choose a date">
<button mdSuffix [mdDatepickerToggle]="deadlineDatePicker">

<md-datepicker #deadlineDatePicker>

Error is still here using angular/material 2.0.0-beta.8 with angular/core 4.3.0.
'minDate', 'maxDate' and 'oe.ValidTo' are of type "Date".

I have a PR open to make the behavior more consistent by also throwing errors when developers attempt to set the value to type other than the type expected by the DateAdapter. In the case of the NatvieDateAdapter this means strings will no longer be considered valid (this is error prone since the way that string is parsed may vary depending on locale). After #5711 lands you will need to make sure you're working with actual Date objects if you want to use the NativeDateAdapter.

That seems like a good fix.  Plus the error message is clear so it will be simple to solve for anyone who mistakenly sends in a string rather than a date.


.dl-horizontal class not working

Describe the bug
.dl-horizontal class not working
Steps To Reproduce
Steps to reproduce the behavior:

Go to https://adminlte.io/themes/dev/AdminLTE/pages/UI/general.html
Scroll down to 'Description Horizontal'
See error

Screenshots

Item
Version

Laravel
8

Hi @gaztum , please report the issue on the ColorlibHQ/AdminLTE package, the problem is related to the underlying package. This just provides integration with the Laravel framework among other things.

Closed, issue do not belongs to this package.


Unable to increase the executor memory in Hue config

All, we are not able to increase spark executor memory on hue. Even if we do it using a query it is taking a default configuration of 1 core of CPU and 1 GB of memory.
Both spark and hue are hosted on kubernetes environment. We use livy as spark client to submit queries.
Please do let us know if more information is required on the same.


Help files are not viewable when working with remote connection

I'm not entirely convinced this is a vscode-R problem, so apologies in advanced if it isn't.
When working on a remote connection (ssh into a Linux env), if I use devtools::load_all("pkg"), and I try to view the development help file, I am faced with the following:
Using development documentation for MyFunction
VSCode WebView has restricted access to local file.
Opening in external browser...
Browsing file:///tmp/RtmpM6oemu/Rtxtf8e36c15798a.html

As well as the following pop up box

My default for getOption("help_type") is "html". If I change this to "text" then everything works fine and I see my help file in the console. I can open the html file (file:///tmp/RtmpM6oemu/Rtxtf8e36c15798a.html) perfectly fine although it of course doesn't render. I am not certain how I give WebView access to development docs?
FWIW:
    "r.rterm.windows": "C://location//to//R.exe",
    "r.rterm.linux": "location/to/radian",
    "r.rterm.option": [""],
    "r.bracketedPaste": true,
    "r.lsp.debug": false,
    "r.lsp.diagnostics": false,
    "r.alwaysUseActiveTerminal": true,
    "r.sessionWatcher": true,

vscode-R 1.6.1
VSCode 1.51.1

Related to #383.

If I understood things correctly, the help function from as.environment('devtools_shims') (attached after using load_all) generates an object with class dev_topic, which is printed by print.dev_topic.
In that print function, a temporary html help file is generated and passed to utils::browseURL(), which the browser from init.R cannot show in a webivew, since vscode webviews cannot access arbitrary files.
Instead the filename is passed to the vscode-R extension, which tries to open the file in an external browser but fails, since the file is located on the remote machine.
I guess fixing this problem would be possible by modifying/overwriting any of the functions involved in that chain, but I'm not really sure, what the best approach would be to do this.

@ManuelHentschel You are right, this is largely due to the limitation of WebView security policies and how it is managed to access allowed resources.

This apparently also affects package development in dev containers.
I don't know much about this (great!) plugin, but there is an rstudioapi emulation layer, right? It may also be possible to overload the previewRd function, see here

Hi, just wanted to contribute some details (Remote SSH from Win to Linux)

I develop a package that is already installed
run devtools::document
run ?my_func

that returns (as described above):
ℹ Rendering development documentation for "my_function"
VSCode WebView has restricted access to local file.
Opening in external browser...
Browsing file:///tmp/RtmpEhDFQJ/Rtxt5a0a5d3d65d9.html

If I use the recommended F1 keybinding the "old" docs are shown as expected but not the most recent ones generated by devtools::document
{
    "key": "f1",
    "command": "r.helpPanel.openForSelection",
    "when": "editorTextFocus && editorLangId == 'r' || editorTextFocus && editorLangId == 'rmd'"
}

Same thing happens when I use the extension buttons (HELP PAGES > Help Topics ... > my_package > my_func) - the old docs are loaded instead of the most current ones.


Update netty-codec-http, ... to 4.1.66.Final

Updates

io.netty:netty-codec-http
io.netty:netty-transport-native-epoll
io.netty:netty-transport-native-kqueue

from 4.1.65.Final to 4.1.66.Final.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "io.netty" } ]

labels: library-update

Superseded by #182.


Fixed initialization of TRS Track in blend tree for root motion

Follow up to #57675.
Fixed #59407.
Root bone does not always stay at the origin (initial Transform). Also, the root motion must always be calculated from the initial Transform. So, the root motion must be set to the initial Transform at the beginning of the blend calculation, not init_pos/rot/scl (rest).

Thanks!


Allow clean submit for lookup field create dialogs

Thanks!

Looks like gql-gen is failing.

Can you rebase?


Fix random test failures in LinksetRestControllerIT and ManageGroupsFeatureIT

Description
In recent CI builds, we are seeing some random failures coming from two ITs:

Failures in LinksetRestControllerIT which look like this:[INFO] Running org.dspace.app.rest.signposting.controller.LinksetRestControllerIT
Error:  Tests run: 41, Failures: 0, Errors: 18, Skipped: 0, Time elapsed: 9.099 s <<< FAILURE! - in
org.dspace.app.rest.signposting.controller.LinksetRestControllerIT
Error:  findTypedLinkForBitstreamWithType(org.dspace.app.rest.signposting.controller.LinksetRestControllerIT)  Time elapsed: 0.292 s  <<< ERROR!
java.lang.NullPointerException
at org.dspace.content.authority.ChoiceAuthorityServiceImpl.clearCache(ChoiceAuthorityServiceImpl.java:273)
at org.dspace.app.rest.signposting.controller.LinksetRestControllerIT.findTypedLinkForBitstreamWithType(LinksetRestControllerIT.java:786)
...

The NullPointerException appears to occur when the ChoiceAuthorityServiceImpl has not yet been initialized.  The NPE appears randomly as it depends on the order in which ITs are run.  If that ChoiceAuthorityServiceImpl has been initialized by a different IT, then this code succeeds. If not, then it fails with an NPE.

Strangely, LinksetRestControllerIT does NOT even use this service, so there's no need to call it at all.

This PR removes unused services & unnecessary cache cleanup from LinksetRestControllerIT.  Some tests appear to do cleanup which is unnecessary & I've removed the unnecessary code.

Failures in ManageGroupsFeatureIT which look like this:[INFO] Running org.dspace.app.rest.authorization.ManageGroupsFeatureIT
Error:  Tests run: 76, Failures: 24, Errors: 0, Skipped: 0, Time elapsed: 16.88 s <<< FAILURE! -- in
org.dspace.app.rest.authorization.ManageGroupsFeatureIT
Error:  org.dspace.app.rest.authorization.ManageGroupsFeatureIT.testSubGroupOfAdminGroup -- Time elapsed: 0.217 s <<< FAILURE!
java.lang.AssertionError: No value at JSON path "$._embedded.authorizations[?(@._embedded.feature.id=='canManageGroups')]"

In this situation, the failure is caused by pagination, where the canManageGroups feature is returned on page 2 of the results, while the test assumes it will always be on the first page.  This pagination issue occurs mostly for full Administrator tests, because Admins have a larger number of "features" returned.
This PR fixes the issue by updating all Admin tests to use &feature=canManageGroups parameter to filter by the feature we are looking for.  This ensures it will never be on page 2.

Instructions for Reviewers

No code in DSpace was changed. Only ITs (LinksetRestControllerIT and ManageGroupsFeatureIT) were modified.  Simply review the code and verify that tests are succeeding in GitHub Actions.

Merging this immediately as these IT failures are affecting other recent PRs.  If anyone disagrees with the minor fixes here, please let me know & we can update them later as necessary.


poetry export help doesn't provide the format options

[x] I am on the latest Poetry version.

[x] I have searched the issues of this repo and believe that this is not a duplicate.

[ ] If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

OS version and name: any

Poetry version: 1.0.0b8

Link of a Gist with the contents of your pyproject.toml file:

Issue
One needs to browse Poetry docs (which are not even online for 1.0 beta yet, or I couldn't find a link) or the source code to find out how to use the poetry export command, because the help text doesn't provide the list of available formats.
$ poetry export

[ValueError]
Invalid export format: None
$ poetry export --help
USAGE
  poetry export [-f <...>] [-o <...>] [--without-hashes] [--dev] [-E <...>] [--with-credentials]

OPTIONS
  -f (--format)          Format to export to.
  -o (--output)          The name of the output file.
  --without-hashes       Exclude hashes from the exported file.
  --dev                  Include development dependencies.
  -E (--extras)          Extra sets of dependencies to include. (multiple values allowed)
  --with-credentials     Include credentials for extra indices.

GLOBAL OPTIONS
  -h (--help)            Display this help message
  -q (--quiet)           Do not output any message
  -v (--verbose)         Increase the verbosity of messages: "-v" for normal output, "-vv" for more verbose output and "-vvv" for debug
  -V (--version)         Display this application version
  --ansi                 Force ANSI output
  --no-ansi              Disable ANSI output
  -n (--no-interaction)  Do not ask any interactive question

$ poetry export -f anything

[ValueError]
Invalid export format: anything

In the current docs, the option -f is documented as:

--format (-f): The format to export to. Currently, only requirements.txt is supported.

This should be in the command help too.

Hello @absassi,
thanks a lot for reporting. Must get lost somewhere. Will be fixed with https://github.com/sdispater/poetry/pull/1653.
fin swimmer


Use CMAKE_REQUIRED_INCLUDES and CMAKE_REQUIRED_LIBRARIES only for relevant checks

Original pull request by Markus Rickert (Bitbucket: rickertm, GitHub: rickertm).

This patch is required when building SoQt with MSVC 2017 in order to prevent the No known features for CXX compiler "" version error.
The call to check_symbol_exists(__func__) etc. uses the C compiler and complains when linking against the Coin::Coin C++ target. Linking against this target is only required in the check_cxx_source_compiles() checks for Coin features.

Original comment by Bastiaan Veelo (Bitbucket: veelo, GitHub: veelo).

I am going to pull this. But shouldn't the explanation given in this PR be more visible? I think a comment in the file would be appropriate.
Thanks!


Tasks to complete before making this repo public

[x] Set up CI as in the MS project to automatically test the stubs https://github.com/pandas-dev/pandas-stubs/issues/3
[ ] Figure out how to package the stubs as a pandas-stubs project for distribution https://github.com/pandas-dev/pandas-stubs/issues/4

And I have made the repo public.

And I have made the repo public.

gr8. let's close this then.
and open separate issues for the tasks mentioned in https://github.com/pandas-dev/pandas-stubs/issues/1#issuecomment-1114960403


BUG: fix itkPeriodicBoundaryConditionTest  itkGradientImageFilterTest

http://review.source.kitware.com/#/c/23234/
Bradley Lowekamp
Uploaded patch set 1.Mar 5, 2018
Bradley Lowekamp
Patch Set 1: I had to add in the old dynamic_cast to get these tests to pass again. I am not sure where or how the new "ConstNeighborhoodIterator< TInputImage, Self > *" cast is needed. I saw no test to documented code were this is required the old cast still works and appears to be required. I left the new on there too, but some compilers seem to be producing an error related to it.Mar 5, 2018
Matt McCormick
Patch Set 1: Code-Review-2 The dynamic_cast's are not correct, and they should not be performed here. This is being addressed in this patch: http://review.source.kitware.com/#/c/23231/Mar 5, 2018
Bradley Lowekamp
Patch Set 1: @Matt Please re-review this patch. The test failures are different than the compilation errors.Mar 5, 2018
Bradley Lowekamp
Patch Set 1: (1 comment)Mar 5, 2018
Matt McCormick
Patch Set 1: I will add a the test code from Discourse that demonstrates the issue. The fix should use a reinterpret_cast for ConstNeighborhoodIterator< TInputImage, Self >. The second template argument refers to the type of the boundary condition -- if called passed inside PeriodicBoundaryCondition, it is valid to be PeriodicBoundaryCondition (Self). The conditionals and dynamic_cast's are error-prone and introduce unnecessary overhead.Mar 5, 2018
Bradley Lowekamp
Patch Set 1: That is a good point that this format of the code is error prone, and duplicative, but that be fixed up. Using reinterpret_cast is never a "good" idea, and should only be used as a last resort. """ he second template argument refers to the type of the boundary condition -- if called passed inside PeriodicBoundaryCondition, it is valid to be PeriodicBoundaryCondition (Self). """ This is not accurate, we need to take a step back and look at how this structure is currently using in ITK and how it's different than your expectations.Mar 5, 2018
Matt McCormick
Patch Set 1: reinterpret_cast is the correct operation here following an examination of the structure of the code.Mar 5, 2018
Kitware Build Robot
Patch Set 1: Verified-1 Build Failed: CDash filtered results: https://open.cdash.org/index.php?&project=Insight&filtercount=3&field1=buildname/string&compare1=63&value1=23234-1&field2=buildstarttime/date&compare2=83&value2=2015-03-01&field3=buildstarttime/date&compare3=84&value3=2029-01-01Mar 5, 2018
Bradley Lowekamp
Uploaded patch set 2.Mar 6, 2018
Matt McCormick
Patch Set 2: This approach will not work when ConstNeighborhoodIterator has been templated with a different ImageBoundaryCondition, e.g. ConstBoundaryCondition. Also, there may be other ImageBoundaryCondition's created outside of the toolkit that this will not handle.Mar 6, 2018
Bradley Lowekamp
Patch Set 2: "This approach will not work when ConstNeighborhoodIterator has been templated with a different ImageBoundaryCondition" Historically now, ConstNeighborhoodIterator was only defined with the default second template parameter. So this case of supporting it with other templates for the second has not been in ITK. We could just document that other templates for the ConstNeightborhoodITerator do not work as oppose to adding a feature via using undefined C++ behavior.Mar 6, 2018
Bradley Lowekamp
Patch Set 2: Hooray! Green.Mar 6, 2018
Matt McCormick
Patch Set 2: The reinterpret_cast works. The dynamic_cast adds unnecessary overhead and will not work for the other types.Mar 6, 2018
Kitware Build Robot
Patch Set 2: Verified-1 Build Failed: CDash filtered results: https://open.cdash.org/index.php?&project=Insight&filtercount=3&field1=buildname/string&compare1=63&value1=23234-2&field2=buildstarttime/date&compare2=83&value2=2015-03-01&field3=buildstarttime/date&compare3=84&value3=2029-01-01Mar 6, 2018
Hans J. Johnson
Uploaded patch set 3.Mar 7, 2018
Kitware Build Robot
Patch Set 3: Verified-1 Build Failed: CDash filtered results: https://open.cdash.org/index.php?&project=Insight&filtercount=3&field1=buildname/string&compare1=63&value1=23234-3&field2=buildstarttime/date&compare2=83&value2=2015-03-01&field3=buildstarttime/date&compare3=84&value3=2029-01-01Mar 7, 2018
Matt McCormick
Patch Set 3: This should be abandoned.Mar 8, 2018
Hans J. Johnson
Patch Set 3: First, I have not done a deep dive on this entire topic. but my reading is that the conversion is to change types via polymorphic changes. It sure seems to me that dynamic_cast is the correct option here, especially if this is a compile-time identifiable casting. my experience and knowledge base is that reinterpret_cast IS THE MOST DANGEROUS OF CASTING TYPES, and is usually reserved for very low level tasks like storing a pointer in an integer, or bit manipulations. I would certainly have an immediate hesitation to using code with re-interpret_cast. reinterpret_cast might "work", but it does not seem like the right tool for the job. If this is a real performance problem (real == proven), then let's put a huge note in the code : " We recognize that dynamic_cast would be the most appropriate casting mechanism here, but empirical evidence shows a 30% performance improvement for this critical piece of code when the more dangerous reinterpret_cast is used. "Mar 8, 2018
Matt McCormick
Patch Set 3: reinterpret_cast does have to be used with care, but it was used with care; considering the types involved and the calls made on the pointer. Note that the dashboard did not have any issue with the reinterpret_cast, and we have hundreds of reinterpret_cast's in ITK. There is no evidence that reinterpret_cast actually causes an issue. The issue with this approach is not only performance. It will simply will not work when other template parameters are used for itkConstNeighborhoodIterator. This confusing behavior is the condition that caused the need for the improvement in the first place.Mar 8, 2018
Dzenan Zukic
Sep 14 8:12 AM
↩
Patch Set 3:
(1 comment)
request build: all
Modules/Core/Common/include/itkPeriodicBoundaryCondition.hxx
Line 98:
Merge/rebase conflict?
Kitware Build Robot
Patch Set 3: Build Failed: CDash filtered results: https://open.cdash.org/index.php?&project=Insight&filtercount=3&field1=buildname/string&compare1=63&value1=23234-3&field2=buildstarttime/date&compare2=83&value2=2015-03-01&field3=buildstarttime/date&compare3=84&value3=2029-01-01Sep 14 8:47 AM
Matt McCormick
Patch Set 3: That has been addressed elsewhere and should be abandoned.Sep 14 9:46 AM

This was addressed in
https://github.com/InsightSoftwareConsortium/ITK/commit/7b91070b9895d31037ebf95526aee3f3fc997f9a
in a way that will not generate segfaults for other boundary conditions.


Revert "add test codesign steps for macOS to debug https://github.com/AdoptOp…"

Reverts AdoptOpenJDK/openjdk-build#2563

What is the need to revert?

Good point, it's actually quite a useful diagnostic step. Closing


Box Upload Overwrite/Update only new entries

Is your feature request related to a problem? Please describe.
Not related to a problem; however, I am attempting to upload a folder that gets updated daily and use this in a script. I get the 409 conflict error and cannot upload the new additions of the folder.
Describe the solution you'd like
An overwrite of the whole folder upon upload or for the upload command to upload only newly added folders/files
Describe alternatives you've considered
I cannot find one besides manually uploading the subfolders/files

Hi @vincenastri,
currently Box API does not allow for overriding the folder in case of the name conflict. The only option now is either to remove it first or do it the way you do it now - uploading only new items.
I suggest to add your need to Box Pulse. If there are more people that have same needs as you, your request may be prioritised and new API will be added.
Best,
@lukaszsocha2


Types are lost when loading modules via registerModule

I'd like to dynamically register modules via store.original.registerModule, but types registered this way are not detected.  Is this a feature that can be added, or am I doing something wrong?

Hi. Maybe it would be possible to add the module types using declaration merging. But this operation would  statically add the types during compilation for all the code of the application. With registerModule a module can be conditionally added, or its name can be dynamically chosen. This kind of feature can't be reproduced in types.
Direct-vuex aims to be a patch for lacks of typing in Vuex 3 and I will work to keep it compatible with Vuex 4. But this project will probably become unecessary with the redesign of Vuex 5. It is not a definitive solution that would be improved for each side-case. A pull request would of course be welcome, but I don't intend to work on this feature myself.


Error: The null object does not have a getter 'lexeme'.

I've been using the async/await syntax which is awesome, but I am getting this error on build. Any ideas?
Transform AsyncAwait on aristadart|lib/components/admin/model.dart threw error: The null object does not have a getter 'lexeme'.

NoSuchMethodError: method not found: 'lexeme'
Receiver: null
Arguments: []
dart:core-patch/object_patch.dart 45          Object.noSuchMethod
package:async_await/src/xform.dart 854        AsyncTransformer._translateSynchronousForEach
package:async_await/src/xform.dart 892        AsyncTransformer.visitForEachStatement
package:analyzer/src/generated/ast.dart 7003  ForEachStatement.accept
package:async_await/src/xform.dart 490        AsyncTransformer.visit
package:async_await/src/xform.dart 690        AsyncTransformer._translateStatementList.<fn>
package:async_await/src/xform.dart 829        AsyncTransformer.visitExpressionStatement.<fn>.<fn>
package:async_await/src/xform.dart 2040       AsyncTransformer.visitMethodInvocation.<fn>.<fn>.<fn>
package:async_await/src/xform.dart 1892       AsyncTransformer._translateExpressionList
package:async_await/src/xform.dart 2038       AsyncTransformer.visitMethodInvocation.<fn>.<fn>
package:async_await/src/xform.dart 1872       AsyncTransformer.visitSimpleIdentifier.<fn>
package:async_await/src/xform.dart 2034       AsyncTransformer.visitMethodInvocation.<fn>
package:async_await/src/xform.dart 827        AsyncTransformer.visitExpressionStatement.<fn>
package:async_await/src/xform.dart 690        AsyncTransformer._translateStatementList.<fn>
package:async_await/src/xform.dart 1155       AsyncTransformer.visitIfStatement.<fn>.<fn>
package:async_await/src/xform.dart 2071       AsyncTransformer.visitPrefixExpression.<fn>.<fn>
package:async_await/src/xform.dart 1876       AsyncTransformer.visitPrefixedIdentifier.<fn>
package:async_await/src/xform.dart 2070       AsyncTransformer.visitPrefixExpression.<fn>
package:async_await/src/xform.dart 1151       AsyncTransformer.visitIfStatement.<fn>
package:async_await/src/xform.dart 690        AsyncTransformer._translateStatementList.<fn>
package:async_await/src/xform.dart 1530       AsyncTransformer.visitVariableDeclarationStatement.<fn>.<fn>
package:async_await/src/xform.dart 1496       AsyncTransformer._translateDeclarationList.<fn>
package:async_await/src/xform.dart 1487       AsyncTransformer._translateDeclarationList.translateDecl.<fn>
package:async_await/src/xform.dart 1701       AsyncTransformer._reifyAwaitContinuation
package:async_await/src/xform.dart 1746       AsyncTransformer.visitAwaitExpression.<fn>.<fn>
package:async_await/src/xform.dart 2046       AsyncTransformer.visitMethodInvocation.<fn>.<fn>
package:async_await/src/xform.dart 1898       AsyncTransformer._translateExpressionList.<fn>
package:async_await/src/xform.dart 1975       AsyncTransformer.visitSimpleStringLiteral.<fn>
package:async_await/src/xform.dart 1913       AsyncTransformer._translateExpressionList.<fn>
package:async_await/src/xform.dart 1876       AsyncTransformer.visitPrefixedIdentifier.<fn>
package:async_await/src/xform.dart 1913       AsyncTransformer._translateExpressionList.<fn>
package:async_await/src/xform.dart 1872       AsyncTransformer.visitSimpleIdentifier.<fn>
package:async_await/src/xform.dart 1917       AsyncTransformer._translateExpressionList
package:async_await/src/xform.dart 2045       AsyncTransformer.visitMethodInvocation.<fn>
package:async_await/src/xform.dart 1737       AsyncTransformer.visitAwaitExpression.<fn>
package:async_await/src/xform.dart 1486       AsyncTransformer._translateDeclarationList.translateDecl
package:async_await/src/xform.dart 1511       AsyncTransformer._translateDeclarationList
package:async_await/src/xform.dart 1527       AsyncTransformer.visitVariableDeclarationStatement.<fn>
package:async_await/src/xform.dart 690        AsyncTransformer._translateStatementList.<fn>
package:async_await/src/xform.dart 692        AsyncTransformer._translateStatementList
package:async_await/src/xform.dart 696        AsyncTransformer.visitBlock.<fn>
package:async_await/src/xform.dart 636        AsyncTransformer.visitBlockFunctionBody
package:analyzer/src/generated/ast.dart 2902  BlockFunctionBody.accept
package:async_await/src/xform.dart 490        AsyncTransformer.visit
package:async_await/src/compiler.dart 45      compile
package:async_await/async_await.dart 10       compile
package:async_await/transformer.dart 25       AsyncAwaitTransformer.apply.<fn>
dart:async/zone.dart 1155                     _RootZone.runUnary
dart:async/future_impl.dart 484               _Future._propagateToListeners.handleValueCallback
dart:async/future_impl.dart 567               _Future._propagateToListeners
dart:async/future_impl.dart 358               _Future._completeWithValue
dart:async/future_impl.dart 412               _Future._asyncComplete.<fn>
dart:async/schedule_microtask.dart 41         _asyncRunCallbackLoop
dart:async/schedule_microtask.dart 48         _asyncRunCallback
dart:isolate-patch/isolate_patch.dart 84      _runPendingImmediateCallback
dart:isolate-patch/isolate_patch.dart 131     _RawReceivePortImpl._handleMessage

dart:core                                     Object.noSuchMethod
package:async_await/src/xform.dart 854        AsyncTransformer._translateSynchronousForEach
package:async_await/src/xform.dart 892        AsyncTransformer.visitForEachStatement
package:analyzer/src/generated/ast.dart 7003  ForEachStatement.accept
package:async_await/src/xform.dart 490        AsyncTransformer.visit
package:async_await/src/xform.dart 690        AsyncTransformer._translateStatementList.<fn>
package:async_await/src/xform.dart 829        AsyncTransformer.visitExpressionStatement.<fn>.<fn>
package:async_await/src/xform.dart 2040       AsyncTransformer.visitMethodInvocation.<fn>.<fn>.<fn>
package:async_await/src/xform.dart 1892       AsyncTransformer._translateExpressionList
package:async_await/src/xform.dart 2038       AsyncTransformer.visitMethodInvocation.<fn>.<fn>
package:async_await/src/xform.dart 1872       AsyncTransformer.visitSimpleIdentifier.<fn>
package:async_await/src/xform.dart 2034       AsyncTransformer.visitMethodInvocation.<fn>
package:async_await/src/xform.dart 827        AsyncTransformer.visitExpressionStatement.<fn>
package:async_await/src/xform.dart 690        AsyncTransformer._translateStatementList.<fn>
package:async_await/src/xform.dart 1155       AsyncTransformer.visitIfStatement.<fn>.<fn>
package:async_await/src/xform.dart 2071       AsyncTransformer.visitPrefixExpression.<fn>.<fn>
package:async_await/src/xform.dart 1876       AsyncTransformer.visitPrefixedIdentifier.<fn>
package:async_await/src/xform.dart 2070       AsyncTransformer.visitPrefixExpression.<fn>
package:async_await/src/xform.dart 1151       AsyncTransformer.visitIfStatement.<fn>
package:async_await/src/xform.dart 690        AsyncTransformer._translateStatementList.<fn>
package:async_await/src/xform.dart 1530       AsyncTransformer.visitVariableDeclarationStatement.<fn>.<fn>
package:async_await/src/xform.dart 1496       AsyncTransformer._translateDeclarationList.<fn>
package:async_await/src/xform.dart 1487       AsyncTransformer._translateDeclarationList.translateDecl.<fn>
package:async_await/src/xform.dart 1701       AsyncTransformer._reifyAwaitContinuation
package:async_await/src/xform.dart 1746       AsyncTransformer.visitAwaitExpression.<fn>.<fn>
package:async_await/src/xform.dart 2046       AsyncTransformer.visitMethodInvocation.<fn>.<fn>
package:async_await/src/xform.dart 1898       AsyncTransformer._translateExpressionList.<fn>
package:async_await/src/xform.dart 1975       AsyncTransformer.visitSimpleStringLiteral.<fn>
package:async_await/src/xform.dart 1913       AsyncTransformer._translateExpressionList.<fn>
package:async_await/src/xform.dart 1876       AsyncTransformer.visitPrefixedIdentifier.<fn>
package:async_await/src/xform.dart 1913       AsyncTransformer._translateExpressionList.<fn>
package:async_await/src/xform.dart 1872       AsyncTransformer.visitSimpleIdentifier.<fn>
package:async_await/src/xform.dart 1917       AsyncTransformer._translateExpressionList
package:async_await/src/xform.dart 2045       AsyncTransformer.visitMethodInvocation.<fn>
package:async_await/src/xform.dart 1737       AsyncTransformer.visitAwaitExpression.<fn>
package:async_await/src/xform.dart 1486       AsyncTransformer._translateDeclarationList.translateDecl
package:async_await/src/xform.dart 1511       AsyncTransformer._translateDeclarationList
package:async_await/src/xform.dart 1527       AsyncTransformer.visitVariableDeclarationStatement.<fn>
package:async_await/src/xform.dart 690        AsyncTransformer._translateStatementList.<fn>
package:async_await/src/xform.dart 692        AsyncTransformer._translateStatementList
package:async_await/src/xform.dart 696        AsyncTransformer.visitBlock.<fn>
package:async_await/src/xform.dart 636        AsyncTransformer.visitBlockFunctionBody
package:analyzer/src/generated/ast.dart 2902  BlockFunctionBody.accept
package:async_await/src/xform.dart 490        AsyncTransformer.visit
package:async_await/src/compiler.dart 45      compile
package:async_await/async_await.dart 10       compile
package:async_await/transformer.dart 25       AsyncAwaitTransformer.apply.<fn>
dart:isolate

A snippet of the code shows I am using async inside a forloop
for (ObjetoUnitySend obj in resp.objs)
        {
            ModelAdminInfo info = new ModelAdminInfo();
            info.model = obj;

            if (! notNullOrEmpty(obj.owner))
            {
                print("Owner undefined");
                continue;
            }

            UserResp userResp = await requestDecoded
            (
                UserResp,
                Method.GET,
                'user/${obj.owner}'
            );

which may be unsupported by async/await transformer.

That seems like a bug.  Thanks for the report, I'll take a look.

This should be fixed by https://github.com/dart-lang/async_await/pull/86.  Give it a try.

Thanks! Will try. I was also getting something about not having accept. Sadly I reverted back to Futures, I'll slowly test the tansformer and report back.

Thanks! Will try. I was also getting something about not having accept. Sadly I reverted back to Futures, I'll slowly test the tansformer and report back.

Thanks! Will try. I was also getting something about not having accept. Sadly I reverted back to Futures, I'll slowly test the tansformer and report back.


Languange dependecy

Hello,
could you inform if your models are language-dependent?
Thanks in advance,
Sarah

The model was only trained on English.
In addition, it seems to consider the sentiment of the test for its valence predictions as shown in https://arxiv.org/abs/2204.00400, which means it will most likely work much worse for valence in other languages.


Add Parent Volume element

This optional element is being added to improve support of Manga.
This differs from the US comic volume definition, which is tied to the series, so we will need to document that this is used for manga and not US comics.

The type should be a string because Volume can be 1-2 in terms of Omnibus releases (or 1-3 sometimes)

The type should be a string because Volume can be 1-2 in terms of Omnibus releases (or 1-3 sometimes)

Ok, made that change.


feat(terminal): changed default terminal theme to nord

This PR is included in version 2.5.0 :tada:


I have edited your CMakeLists.txt file in base now happening newer error

Hello,
The error happening :

How I have edited the CMakeLists.txt file in base folder able go more far in your GitHub fork :

They miss a lot of directory and files in base folder that I have 'touch files' and 'mkdir folers'...
Thank you in advance to help myself go more far on your GitHub fork,
Regards.
azaretdodo.

sorry the error happening is here :

You need to init the submodules as noted in the instructions.

The instructions is in the readme?
Envoyé d’Outlook Mobilehttps://aka.ms/blhgte

From: Sascha Willems<EMAIL_ADDRESS>Sent: Tuesday, April 28, 2020 11:15:28 AM
To: SaschaWillems/Vulkan<EMAIL_ADDRESS>Cc: Azaretdodo<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [SaschaWillems/Vulkan] I have edited your CMakeLists.txt file in base now happening newer error (#700)
You need to init the submodules as noted in the instructions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/SaschaWillems/Vulkan/issues/700#issuecomment-620483923, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHJN3INWOWIJ4XZMHBUQMJ3RO2NDBANCNFSM4MSTTPGQ.

Yes, it's right at the top under "Cloning".

Thank you when I will have the time I will read the readme at cloning,
If I happening again cmake error I will edited for repair,
Regards.
Azaretdodo.
Envoyé d’Outlook Mobilehttps://aka.ms/blhgte

From: Sascha Willems<EMAIL_ADDRESS>Sent: Tuesday, April 28, 2020 12:36:11 PM
To: SaschaWillems/Vulkan<EMAIL_ADDRESS>Cc: Azaretdodo<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [SaschaWillems/Vulkan] I have edited your CMakeLists.txt file in base now happening newer error (#700)
Yes, it's right at the top under "Cloning".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/SaschaWillems/Vulkan/issues/700#issuecomment-620524944, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHJN3IMU64JYCODDLBYXGGLRO2WRXANCNFSM4MSTTPGQ.


Stage to Main Sync up

Stage to Main Sync up
Test URLs:

Before: https://main--express--adobecom.hlx.page/express/?martech=off
After: https://stage--express--adobecom.hlx.page/express/?martech=off

Codecov Report
Attention: Patch coverage is 63.01370% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 34.90%. Comparing base (9188e68) to head (cb58419).
Report is 11 commits behind head on main.

Files
Patch %
Lines

express/blocks/link-list/link-list.js
2.43%
40 Missing :warning:

express/blocks/pricing-cards/pricing-cards.js
82.96%
23 Missing :warning:

express/blocks/marquee/marquee.js
38.46%
16 Missing :warning:

express/blocks/blog-posts/blog-posts.js
0.00%
1 Missing :warning:

express/scripts/utils/pricing.js
90.90%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   33.94%   34.90%   +0.95%
==========================================
  Files         128      129       +1
  Lines       25037    25219     +182
==========================================
+ Hits         8499     8802     +303
+ Misses      16538    16417     -121

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Boss Mechanic

In fighting games/sport there is a tag team option. Maybe a boss that's like a fighter and has to do a 1v1 but you can tag out/switch with your team.  Or along with that idea, a 5 on 5 where each person gets one boss enemy to fight but when they tag out then the next person has their own boss to finish off.

Thank you for the post, and sorry for the delay. Right now we're not looking for 1v1 bosses. They're supposed to be efforts in coordination.


UIP-47: adding more assets

Description of PR purpose/changes
Adding all the images, fonts, and custom icons from the narrative repo.
I'll merge this into the (newly-created) develop branch.
The next step will be moving over the css (unfortunately there are some straggler files in the narrative that aren't in the concatenated css file).
Once all the assets are in place, I'll bump the version, add release notes, and merge develop => main.
Note that there's a preexisting v1 folder in the fonts directory; unless there are different versions of the fonts themselves, I don't think we need to have this folder. Once everything has switched over to using assets served from this repo, I'll remove the v1 from the font path and delete the directory.
Jira Ticket / Issue
Related Jira ticket: https://kbase-jira.atlassian.net/browse/UIP-47

[x] Added the Jira Ticket to the title of the PR (e.g. UIP-007 Adds a PR template)

Dev Checklist:

[x] My code follows the guidelines at https://sites.google.com/lbl.gov/trussresources/home?authuser=0
[x] I have performed a self-review of my own code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

Updating Version and Release Notes (if applicable)

[ ] Version has been bumped for each release
[ ] Release notes have been updated for each release (and during the merge of feature branches)

Existing static narratives (and it's in the repo still) use the v1 font path. That was put there, mostly because the various data / app icons are included as part of a font pack, and if they ever get changed, the version should get bumped (which I think was on the path when we did this way back when).
But... yeah, I don't know that this is strictly necessary. All the existing SNs have that v1 on the path to the fonts they look for, though, so we'd either need to script a way to update those in place, or make an nginx rule that forwards from fonts/v1/xyz.font to fonts/xyz.font.

Might be easier just to leave the v1 dir in place in that case.


Make pubspec.yaml null-safe

pub.dev does not recognize this library as null-safe and it won't let you add it to null-safe projects
it is necessary to change minimum flutter-sdk version to 2.0.0 in pubspec.yaml for this library be detected as null-safe
I've also added pubspec.lock file to .gitignore

LGTM


Node checker shouldnt stop you selecting a node that is failing the checks

The Chore
The node checker function on the apps is a bit ropey and stops you selecting nodes that are actually fine.  We should disable that part so that even if it thinks the node is bad it still lets you select it anyway.
Tasks

[x] Do it
[ ] Test it
[ ] Tell Jon Ray

Additional details / background info

Duplicate ticket


Pagniate works irrespective of the limit params

Laravel Version: 5.3
Adldap2-Laravel Version: 3.0
PHP Version: 7.0

Description:
The paginate function works irrespective of the records per page and current page params.
I have made the records per page and current page params as dynamic and following is the code,
$ad = new \Adldap\Adldap();
if($offset==0){ $currentPage = 1; }else{ $offset = ($offset/$limit); $currentPage = $offset+1; }
$ad->addProvider($config);
$provider = $ad->connect();
$search = $provider->search();
$recordsPerPage = $limit;
$adUsers = $search->users()->sortBy('cn', 'asc')->paginate($recordsPerPage, $currentPage)->getResults();
For example, if the records per page is 50 and current page is 1, it should return me only 50 records from the beginning, but the above code returns me all the records, exactly 874 records in the AD.
Help will be really appreciated. Thanks

Hi @raghul-selvakumar,
Unfortunately PHP doesn't support LDAP server side sorting at the moment, so we actually retrieve the entire result set to allow sorting since it was a requested feature.
If we sort a result set of returned results from the first paged request, it won't be sorted properly since the entire resulting records haven't been retrieved yet, which will contain out of order results.
If we perform this the other way, we'll need to store the cookie somehow inside the users session to be able to request the next resulting set of LDAP records. This opens a can of worms since users may be using other frameworks for managing sessions instead of PHP's sessions. We would have to create some sort of 'driver' based cookie implementation for each type of implementation that the dev is working with.
The current pagination implementation is meant to correct the PHP LDAP sorting issue and bypass max result limits on LDAP servers to be able to retrieve all records instead of being limited to your servers maximum (usually 500 or 1000).
I'm completely open to PR's and talks about implementation of pagination that requests only the requested page of data, but it could be difficult.

Hi @stevebauman
That makes sense. Thank you for your reply steve.


GroupedColumn can't be used  Normally

Use
<Column />
and in config ser property
IsGrouped = true


Move file configuration to file usage

Ensure that editing a file configuration cannot change already
published entries.

Move configuration column to file_usages table

Split Revision#files scope into find_files and find_file
methods and return UsedFile decorators which take the
configuration from a file usage.

Move FileUsagesController actions to FilesController and make it
act like a facade that hides the concept of file usages, always
working with the usages from the entry draft.

Ensure file usages for nested files are created on file reuse.

Ensure file usages for nested files are deleted together with the
parent's files file usage.

Get complete list of entry files after making a reuse request inside
the editor. Ensure file types are associated correctly when files
are added via FilesCollection#set.

Coverage decreased (-0.01%) to 99.123% when pulling 07442b7bea185512987227d513702d086c8c6fda on tf:file-usage-config into ce06bc9be2aed64c91e3d8dfe958896f7060d030 on codevise:master.


PSI and index do not match error in RM 2019.3 EAP

I am now getting an error when first launching railways in RM. This doesn't seem to affect anything, but figured that I should put in an issue just in case it does cause a problem further down the road.
Not sure if this is an issue with RM itself or railways.
Thanks!
RubyMine 2019.3 EAP
Build #RM-193.4099.3, built on October 1, 2019
Runtime version: 11.0.4+10-b485.1 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.13
GC: G1 Young Generation, G1 Old Generation
Memory: 2000M
Cores: 4
Registry: debugger.watches.in.variables=false, ide.tooltip.initialDelay=702
Non-Bundled Plugins: Railways, com.intellij.plugins.webcomponents

com.intellij.psi.stubs.UpToDateStubIndexMismatch: PSI and index do not match.
Please report the problem to JetBrains with the files attached
INDEXED VERSION IS THE CURRENT ONE file=Ruby file, file.class=class org.jetbrains.plugins.ruby.ruby.lang.psi.impl.RFileImpl, file.lang=Language: ruby, modStamp=0
 tree consistent
 stub debugInfo=created in getStubTree(), with AST = false; with backReference
latestIndexedStub=StubTree{myDebugInfo='created from index; with backReference', myRoot=PsiFileStubImpl}2046590630
   same size=true
   debugInfo=created from index; with backReference
 viewProvider=com.intellij.psi.SingleRootFileViewProvider{myVirtualFile=file:///Users/user/.rbenv/versions/2.5.3/lib/ruby/gems/2.5.0/gems/aws-sdk-v1-1.67.0/lib/aws/record/model.rb, content=VirtualFileContent{size=13513}}
 viewProvider stamp: 0; file stamp: 0; file modCount:<PHONE_NUMBER>000; file length: 13513
 doc saved: true; doc stamp: 0; doc size: 13513; committed: true
indexing info: indexed at<PHONE_NUMBER>000 with document  byte size = 13513, char size = 13513
	at com.intellij.psi.stubs.StubTreeLoader.handleUpToDateMismatch(StubTreeLoader.java:134)
	at com.intellij.psi.stubs.StubTreeLoader.stubTreeAndIndexDoNotMatch(StubTreeLoader.java:127)
	at com.intellij.psi.stubs.StubProcessingHelperBase.inconsistencyDetected(StubProcessingHelperBase.java:147)
	at com.intellij.psi.stubs.StubProcessingHelperBase.checkType(StubProcessingHelperBase.java:89)
	at com.intellij.psi.stubs.StubProcessingHelperBase.processStubsInFile(StubProcessingHelperBase.java:68)
	at com.intellij.psi.stubs.StubIndexImpl.processElements(StubIndexImpl.java:393)
	at com.intellij.psi.stubs.StubIndex.getElements(StubIndex.java:107)
	at com.intellij.psi.stubs.StubIndex.getElements(StubIndex.java:95)
	at net.bitpot.railways.utils.RailwaysPsiUtils.findClassesAndModules(Unknown Source)
	at net.bitpot.railways.utils.RailwaysPsiUtils.findClassOrModule(Unknown Source)
	at net.bitpot.railways.utils.RailwaysPsiUtils.findControllerClass(Unknown Source)
	at net.bitpot.railways.utils.RailwaysPsiUtils.findControllerMethod(Unknown Source)
	at net.bitpot.railways.models.RailsActionInfo.update(Unknown Source)
	at net.bitpot.railways.models.routes.SimpleRoute.updateActionStatus(Unknown Source)
	at net.bitpot.railways.utils.RailwaysUtils.updateActionsStatus(Unknown Source)
	at net.bitpot.railways.routesView.RoutesManager.parseRakeRoutesOutput(Unknown Source)
	at net.bitpot.railways.routesView.RoutesManager.access$500(Unknown Source)
	at net.bitpot.railways.routesView.RoutesManager$UpdateRoutesTask.onSuccess(Unknown Source)
	at com.intellij.openapi.progress.impl.CoreProgressManager.finishTask(CoreProgressManager.java:501)
	at com.intellij.openapi.progress.impl.CoreProgressManager$4.lambda$run$1(CoreProgressManager.java:420)
	at com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:309)
	at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.doRun(LaterInvocator.java:441)
	at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:424)
	at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:407)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:313)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:776)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:727)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:721)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:85)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:746)
	at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:906)
	at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:779)
	at com.intellij.ide.IdeEventQueue.lambda$dispatchEvent$8(IdeEventQueue.java:422)
	at com.intellij.openapi.progress.impl.CoreProgressManager.computePrioritized(CoreProgressManager.java:698)
	at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:421)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

The following a files that were marked for "attachment" in the fatal error dialog in RM, so not sure if they are needed or not.
model.rb_file.txt
# Copyright 2011-2013 Amazon.com, Inc. or its affiliates. All Rights Reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License"). You
# may not use this file except in compliance with the License. A copy of
# the License is located at
#
#     http://aws.amazon.com/apache2.0/
#
# or in the "license" file accompanying this file. This file is
# distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
# ANY KIND, either express or implied. See the License for the specific
# language governing permissions and limitations under the License.

# todo move these to included modules (like validations and naming)

module AWS
  module Record

    # An ActiveRecord-like interface built ontop of Amazon SimpleDB.
    #
    #     class Book < AWS::Record::Model
    #
    #       string_attr :title
    #       string_attr :author
    #       integer_attr :number_of_pages
    #
    #       timestamps # adds a :created_at and :updated_at pair of timestamps
    #
    #     end
    #
    #     b = Book.new(:title => 'My Book', :author => 'Me', :pages => 1)
    #     b.save
    #
    # # Attribute Macros
    #
    # When extending AWS::Record::Model you should first consider what
    # attributes your class should have.  Unlike ActiveRecord, AWS::Record
    # models are not backed by a database table/schema.  You must choose what
    # attributes (and what types) you need.
    #
    # * `string_attr`
    # * `boolean_attr`
    # * `integer_attr`
    # * `float_attr`
    # * `datetime_attr`
    # * `date_attr`
    #
    # ### Usage
    #
    # Normally you just call these methods inside your model class definition:
    #
    #     class Book < AWS::Record::Model
    #       string_attr :title
    #       boolean_attr :has_been_read
    #       integer_attr :number_of_pages
    #       float_attr :weight_in_pounds
    #       datetime_attr :published_at
    #     end
    #
    # For each attribute macro a pair of setter/getter methods are added #
    # to your class (and a few other useful methods).
    #
    #     b = Book.new
    #     b.title = "My Book"
    #     b.has_been_read = true
    #     b.number_of_pages = 1000
    #     b.weight_in_pounds = 1.1
    #     b.published_at = Time.now
    #     b.save
    #
    #     b.id #=> "0aa894ca-8223-4d34-831e-e5134b2bb71c"
    #     b.attributes
    #     #=> { 'title' => 'My Book', 'has_been_read' => true, ... }
    #
    # ### Default Values
    #
    # All attribute macros accept the `:default_value` option.  This sets
    # a value that is populated onto all new instnaces of the class.
    #
    #     class Book < AWS::Record::Model
    #       string_attr :author, :default_value => 'Me'
    #     end
    #
    #     Book.new.author #=> 'Me'
    #
    # ### Multi-Valued (Set) Attributes
    #
    # AWS::Record permits storing multiple values with a single attribute.
    #
    #     class Book < AWS::Record::Model
    #       string_attr :tags, :set => true
    #     end
    #
    #     b = Book.new
    #     b.tags #=> #<Set: {}>
    #
    #     b.tags = ['fiction', 'fantasy']
    #     b.tags #=> #<Set: {'fiction', 'fantasy'}>
    #
    # These multi-valued attributes are treated as sets, not arrays.  This
    # means:
    #
    # * values are unordered
    # * duplicate values are automatically omitted
    #
    # Please consider these limitations when you choose to use the `:set`
    # option with the attribute macros.
    #
    # # Validations
    #
    # It's important to validate models before there are persisted to keep
    # your data clean.  AWS::Record supports most of the ActiveRecord style
    # validators.
    #
    #     class Book < AWS::Record::Model
    #       string_attr :title
    #       validates_presence_of :title
    #     end
    #
    #     b = Book.new
    #     b.valid? #=> false
    #     b.errors.full_messages #=> ['Title may not be blank']
    #
    # Validations are checked before saving a record.  If any of the validators
    # adds an error, the the save will fail.
    #
    # For more information about the available validation methods see
    # {Validations}.
    #
    # # Finder Methods
    #
    # You can find records by their ID.  Each record gets a UUID when it
    # is saved for the first time.  You can use this ID to fetch the record
    # at a latter time:
    #
    #     b = Book["0aa894ca-8223-4d34-831e-e5134b2bb71c"]
    #
    #     b = Book.find("0aa894ca-8223-4d34-831e-e5134b2bb71c")
    #
    # If you try to find a record by ID that has no data an error will
    # be raised.
    #
    # ### All
    #
    # You can enumerate all of your records using `all`.
    #
    #     Book.all.each do |book|
    #       puts book.id
    #     end
    #
    #     Book.find(:all) do |book|
    #       puts book.id
    #     end
    #
    # Be careful when enumerating all.  Depending on the number of records
    # and number of attributes each record has, this can take a while,
    # causing quite a few requests.
    #
    # ### First
    #
    # If you only want a single record, you should use `first`.
    #
    #     b = Book.first
    #
    # ### Modifiers
    #
    # Frequently you do not want ALL records or the very first record.  You
    # can pass options to `find`, `all` and `first`.
    #
    #     my_books = Book.find(:all, :where => 'owner = "Me"')
    #
    #     book = Book.first(:where => { :has_been_read => false })
    #
    # You can pass as find options:
    #
    # * `:where` - Conditions that must be met to be returned
    # * `:order` - The order to sort matched records by
    # * `:limit` - The maximum number of records to return
    #
    # # Scopes
    #
    # More useful than writing query fragments all over the place is to
    # name your most common conditions for reuse.
    #
    #     class Book < AWS::Record::Model
    #
    #       scope :mine, where(:owner => 'Me')
    #
    #       scope :unread, where(:has_been_read => false)
    #
    #       scope :by_popularity, order(:score, :desc)
    #
    #       scope :top_10, by_popularity.limit(10)
    #
    #     end
    #
    #     # The following expression returns 10 books that belong
    #     # to me, that are unread sorted by popularity.
    #     next_good_reads = Book.mine.unread.top_10
    #
    # There are 3 standard scope methods:
    #
    # * `where`
    # * `order`
    # * `limit`
    #
    # ### Conditions (where)
    #
    # Where accepts aruments in a number of forms:
    #
    # 1. As an sql-like fragment. If you need to escape values this form is
    #    not suggested.
    #
    #        Book.where('title = "My Book"')
    #
    # 2. An sql-like fragment, with placeholders.  This escapes quoted
    #    arguments properly to avoid injection.
    #
    #        Book.where('title = ?', 'My Book')
    #
    # 3. A hash of key-value pairs. This is the simplest form, but also the
    #    least flexible.  You can not use this form if you need more complex
    #    expressions that use or.
    #
    #        Book.where(:title => 'My Book')
    #
    # ### Order
    #
    # This orders the records as returned by AWS.  Default ordering is ascending.
    # Pass the value :desc as a second argument to sort in reverse ordering.
    #
    #     Book.order(:title)        # alphabetical ordering
    #     Book.order(:title, :desc) # reverse alphabetical ordering
    #
    # You may only order by a single attribute. If you call order twice in the
    # chain, the last call gets presedence:
    #
    #     Book.order(:title).order(:price)
    #
    # In this example the books will be ordered by :price and the order(:title)
    # is lost.
    #
    # ### Limit
    #
    # Just call `limit` with an integer argument.  This sets the maximum
    # number of records to retrieve:
    #
    #     Book.limit(2)
    #
    # ### Delayed Execution
    #
    # It should be noted that all finds are lazy (except `first`).  This
    # means the value returned is not an array of records, rather a handle
    # to a {Scope} object that will return records when you enumerate over them.
    #
    # This allows you to build an expression without making unecessary requests.
    # In the following example no request is made until the call to
    # each_with_index.
    #
    #     all_books = Books.all
    #     ten_books = all_books.limit(10)
    #
    #     ten_books.each_with_index do |book,n|
    #       puts "#{n + 1} : #{book.title}"
    #     end
    #
    class Model

      require 'aws/record/model/attributes'
      require 'aws/record/model/finder_methods'
      require 'aws/record/model/scope'

      extend AbstractBase

      # The id for each record is auto-generated.  The default strategy
      # generates uuid strings.
      # @return [String] Returns the id string (uuid) for this record.  Retuns
      #   nil if this is a new record that has not been persisted yet.
      def id
        @_id
      end

      # @return [Hash] A hash with attribute names as hash keys (strings) and
      #   attribute values (of mixed types) as hash values.
      def attributes
        attributes = super
        attributes['id'] = id if persisted?
        attributes
      end

      class << self

        # Creates the SimpleDB domain that is configured for this class.
        #
        #     class Product < AWS::Record::Model
        #     end
        #
        #     Product.create_table #=> 'Product'
        #
        # If you share a single AWS account with multiple applications, you
        # can provide a domain prefix for your model classes.
        #
        #     AWS::Record.domain_prefix = 'myapp-'
        #
        #     Product.create_table #=> 'myapp-Product'
        #
        # If you have set a model shard name, this is used in place of the
        # class name.
        #
        #     AWS::Record.domain_prefix = 'prod-'
        #     class Product < AWS::Record::Model
        #       set_shard_name 'products'
        #     end
        #
        #     Product.create_table #=> 'prod-products'
        #
        # If you shard you data across multiple domains, you can specify the
        # shard name:
        #
        #     # create two domains, with the given names
        #     Product.create_domain 'products-1'
        #     Product.create_domain 'products-2'
        #
        # @param [optional,String] shard_name Defaults to the class name.
        #
        # @return [SimpleDB::Domain]
        #
        def create_domain shard_name = nil
          sdb.domains.create(sdb_domain_name(shard_name))
        end

        # @return [AWS::SimpleDB::Domain]
        # @api private
        def sdb_domain shard_name = nil
          sdb.domains[sdb_domain_name(shard_name)]
        end

        protected
        def sdb_domain_name shard_name = nil
          "#{AWS::Record.domain_prefix}#{self.shard_name(shard_name)}"
        end

        protected
        def sdb
          AWS::SimpleDB.new
        end

      end

      # @return [SimpleDB::Item] Returns a reference to the item as stored in
      #   simple db.
      # @api private
      private
      def sdb_item
        sdb_domain.items[id]
      end

      # @return [SimpleDB::Domain] Returns the domain this record is
      #   persisted to or will be persisted to.
      private
      def sdb_domain
        self.class.sdb_domain(shard)
      end

      # This function accepts a hash of item data (as returned from
      # AttributeCollection#to_h or ItemData#attributes) and returns only
      # the key/value pairs that are configured attribues for this class.
      # @api private
      private
      def deserialize_item_data item_data

        marked_for_deletion = item_data['_delete_'] || []

        data = {}
        item_data.each_pair do |attr_name,values|

          attribute = self.class.attributes[attr_name]

          next unless attribute
          next if marked_for_deletion.include?(attr_name)

          if attribute.set?
            data[attr_name] = values.map{|v| attribute.deserialize(v) }
          else
            data[attr_name] = attribute.deserialize(values.first)
          end

        end
        data
      end

      def hydrate(id, data)
        @_id = id
        super
      end

      # @api private
      def populate_id
        @_id = SecureRandom.uuid
      end

      # @api private
      protected
      def create_storage
        to_add = serialize_attributes
        sdb_item.attributes.add(to_add.merge(opt_lock_conditions))
      end

      # @api private
      private
      def update_storage

        to_update = {}
        to_delete = []

        # serialized_attributes will raise error if the entire record is blank
        attribute_values = serialize_attributes

        changed.each do |attr_name|
          if values = attribute_values[attr_name]
            to_update[attr_name] = values
          else
            to_delete << attr_name
          end
        end

        to_update.merge!(opt_lock_conditions)

        if to_delete.empty?
          sdb_item.attributes.replace(to_update)
        else
          sdb_item.attributes.replace(to_update.merge('_delete_' => to_delete))
          sdb_item.attributes.delete(to_delete + ['_delete_'])
        end

      end

      # @return [true]
      # @api private
      private
      def delete_storage
        sdb_item.delete(opt_lock_conditions)
        @_deleted = true
      end

    end

    # for backwards compatability with the old AWS::Record::Base
    Base = Model

  end
end

stubTree.txt
PsiFileStubImpl
  RModuleStub:AWS
    RModuleStub:Record
      RClassStub:Model
        RCallStubImpl
        RCallStubImpl
        RCallStubImpl
        RCallStubImpl
        RMethodStub:id
          RInstanceVariableStubImpl
        RMethodStub:attributes
        RObjectClassStubImpl
          RMethodStub:create_domain
          RMethodStub:sdb_domain
          RIdentifierStub
          RMethodStub:sdb_domain_name
          RIdentifierStub
          RMethodStub:sdb
        RIdentifierStub
        RMethodStub:sdb_item
        RIdentifierStub
        RMethodStub:sdb_domain
        RIdentifierStub
        RMethodStub:deserialize_item_data
        RMethodStub:hydrate
          RInstanceVariableStubImpl
        RMethodStub:populate_id
          RInstanceVariableStubImpl
        RIdentifierStub
        RMethodStub:create_storage
        RIdentifierStub
        RMethodStub:update_storage
        RIdentifierStub
        RMethodStub:delete_storage
          RInstanceVariableStubImpl
      RConstantStubImpl

This doesn't just happen on first launch, but also when refreshing.

Thank you for such a detailed information! I've found the reason of this exception and already made a fix, but it needs to be tested. I will provide new build this weekend.
Thanks again!

Hi.
The issue is fixed in new 0.8.16 version. Please check and let me know if everything is ok.

@basgren I have been using all day and haven't had any issues. Thanks for the fix!


Fix/third transforms warpper

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.yanhaiqiang.yhq seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

_pickle.PicklingError: Can't pickle <class 'easycv.datasets.shared.pipelines.third_transforms_wrapper.RandomResizedCrop'>: attribute lookup RandomResizedCrop on easycv.datasets.shared.pipelines.third_transforms_wrapper failed


Upgrade AbstractDependencyReportTask to lazy properties

@bot-gradle test AST

I've triggered the following builds for you. Click here to see all build failures.

AllSmokeTestsPullRequestFeedback build


Question: Is there a way to change highlight for code action lightbulb?

Is there a way to change the color of the lighbulb (either as a sign or as virtual text)?
Here is an example:

I would like it to be Yellow with the same background color as the rest.
I tried with every single highlight in the documentation:
  vim.cmd [[ highlight link LspSagaFinderSelection Special ]]
  vim.cmd [[ highlight link LspFloatWinBorder Special ]]
  vim.cmd [[ highlight link LspSagaBorderTitle Special ]]
  vim.cmd [[ highlight link TargetWord Special ]]
  vim.cmd [[ highlight link ReferencesCount Special ]]
  vim.cmd [[ highlight link DefinitionCount Special ]]
  vim.cmd [[ highlight link TargetFileName Special ]]
  vim.cmd [[ highlight link DefinitionIcon Special ]]
  vim.cmd [[ highlight link ReferencesIcon Special ]]
  vim.cmd [[ highlight link ProviderTruncateLine Special ]]
  vim.cmd [[ highlight link SagaShadow Special ]]
  vim.cmd [[ highlight link LspSagaFinderSelection Special ]]
  vim.cmd [[ highlight link DiagnosticTruncateLine Special ]]
  vim.cmd [[ highlight link DiagnosticError Special ]]
  vim.cmd [[ highlight link DiagnosticWarning Special ]]
  vim.cmd [[ highlight link DiagnosticInformation Special ]]
  vim.cmd [[ highlight link DiagnosticHint Special ]]
  vim.cmd [[ highlight link DefinitionPreviewTitle Special ]]
  vim.cmd [[ highlight link LspSagaShTruncateLine Special ]]
  vim.cmd [[ highlight link LspSagaDocTruncateLine Special ]]
  vim.cmd [[ highlight link LineDiagTuncateLine Special ]]
  vim.cmd [[ highlight link LspSagaCodeActionTitle Special ]]
  vim.cmd [[ highlight link LspSagaCodeActionTruncateLine Special ]]
  vim.cmd [[ highlight link LspSagaCodeActionContent Special ]]
  vim.cmd [[ highlight link LspSagaRenamePromptPrefix Special ]]
  vim.cmd [[ highlight link LspSagaRenameBorder Special ]]
  vim.cmd [[ highlight link LspSagaHoverBorder Special ]]
  vim.cmd [[ highlight link LspSagaSignatureHelpBorder Special ]]
  vim.cmd [[ highlight link LspSagaCodeActionBorder Special ]]
  vim.cmd [[ highlight link LspSagaAutoPreview Special ]]
  vim.cmd [[ highlight link LspSagaDefPreviewBorder Special ]]
  vim.cmd [[ highlight link LspLinesDiagBorder Special ]]

But there doesn't seem to be a way to change it.

config LspSagaLightBulb


Specify tags in decorator

What do these changes do?
Allow to specify tags in the decorator:
@SCHEMA.api(tags=["UseCase"])

Are there changes in behavior for the user?
If tags is not specified the behavior is the same, when it is the paths will be grouped
Checklist

[x] I think the code is well written
[x] Unit tests for the changes exist
[ ] Documentation reflects the changes

If there's interest I don't mind adding tests add documentation

I think the last commit matches the requested changes, let me know if it fits

Thanks a lot for that.

Forgot the docs. If you have a moment to send a followup PR to add the parameter to the docs, that'd be great.


test wrapped line matches and add audio cue for terminal quick fix

fix https://github.com/microsoft/vscode/issues/161912

tests were failing bc passing in the output directly means that the line wrapping won't be handled. we'd need to add some things to get this to work and probably not worth it


CFE-768: Update to allow for incremental and pruning for oci feature

Description
This change allows for the the incremental and pruning functionality to work for the oci feature
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
The update was tested as follows

Add an oci catalog in the imagesetconfig (i.e cincinnati-operator) and mirror to remote registry
Update oci catalog in the imagesetconfig (remove cincinbati-operator and add openshift-logging) and mirror
Verfiy the mapping.txt had correct entry
Verify the .metatadat.json file sequence was bumped
Verify the console logs for both oc-mirror and remote registry (see below)

Pruning 6 manifest(s) from repository test-lmz/openshift-update-service/openshift-update-service-rhel8-operator
Pruning 3 manifest(s) from repository test-lmz/openshift-update-service/cincinnati-operator-bundle
Pruning 6 manifest(s) from repository test-lmz/openshift-update-service/openshift-update-service-rhel8
Deleting manifest sha256:1d3bde7bc3ce4f6acb79307e67aa0342b91fca5ff69bf38e2b0a1884c5cd7db6 from repo test-lmz/openshift-update-service/openshift-update-service-rhel8-operator
Deleting manifest sha256:2743f74cc102c059d7c1dc6698eb947cca75a3cc4230905f09703666ae7a4dbf from repo test-lmz/openshift-update-service/cincinnati-operator-bundle
Deleting manifest sha256:21e32b201bba902cc730dc43943d9cb6c4bab40afc5a148613ae51176c21cd85 from repo test-lmz/openshift-update-service/openshift-update-service-rhel8
Deleting manifest sha256:50566d6670315bc3a4526644404c8e8ab5bd1e1709c1fd9fcde5a37abcb7cb04 from repo test-lmz/openshift-update-service/openshift-update-service-rhel8-operator
Deleting manifest sha256:389c339253271477440c5f470c08a3b149f1795647b1df7b104ae95fc63af22c from repo test-lmz/openshift-update-service/openshift-update-service-rhel8
Deleting manifest sha256:3feccb95e912f2d710958e701a1b52acf16a676fde9a8219491ad9381e6284ea from repo test-lmz/openshift-update-service/cincinnati-operator-bundle
Deleting manifest sha256:66db743f2d61dddab7363ab36252812ffb63653510124c3b32d26f0ddfeb5def from repo test-lmz/openshift-update-service/openshift-update-service-rhel8-operator
Deleting manifest sha256:4bbed256e300088500ae3eb8475b3457d7a6765999e1102dc482e086e2cc0b43 from repo test-lmz/openshift-update-service/openshift-update-service-rhel8
Deleting manifest sha256:71b8f7816a01503a4af5d6f93b9b3a057f6c011aef3b560b408ee4d7abf02165 from repo test-lmz/openshift-update-service/cincinnati-operator-bundle
Deleting manifest sha256:c8f156f73bb3e5fd92c024513c9446ed30d5231e33ef0d0952b365a1fbd69db4 from repo test-lmz/openshift-update-service/openshift-update-service-rhel8-operator
Deleting manifest sha256:6e65da919ed05274e4a0101f67a149188801b715cf073dd517d0dd311a4572a4 from repo test-lmz/openshift-update-service/openshift-update-service-rhel8
Deleting manifest sha256:ce77a27ae4b7b219e44111b6322a3387f75c23fa39ecd94017d2d4bc68bf4a5c from repo test-lmz/openshift-update-service/openshift-update-service-rhel8-operator
Deleting manifest sha256:a2cc2f9d3acd147ced68d8657cf8dd6189be242b4e82852ea8ef002d5f55b31e from repo test-lmz/openshift-update-service/openshift-update-service-rhel8
Deleting manifest sha256:ce7b16803bb2bd058014a3783ed1f0a8a93819dd5769fcd8772228cf96814bf9 from repo test-lmz/openshift-update-service/openshift-update-service-rhel8-operator
Deleting manifest sha256:aea49b2145d59912757f2e371db2e23a9ba20cfa54d0c7132931e16d35655e40 from repo test-lmz/openshift-update-service/openshift-update-service-rhel8
Rendering catalog image "localhost:5000/lmz-test/home/lzuccarelli/go/src/github.com/openshift/oc-mirror/rhopi-412:2cde02" with file-based catalog

Registry log (top entry)
[16/Feb/2023:15:10:57 +0100] "DELETE /v2/test-lmz/openshift-update-service/openshift-update-service-rhel8-operator/manifests/sha256:ce7b16803bb2bd058014a3783ed1f0a8a93819dd5769fcd8772228cf96814bf9 HTTP/1.1" 202 0 "" "go-containerregistry/v0.10.0"
INFO[13249] response completed                            go.version=go1.19.5 http.request.host="localhost:5000" http.request.id=3d7cf0cd-7f03-438e-a9fc-0fb7431add9a http.request.method=DELETE http.request.remoteaddr="[::1]:33704" http.request.uri="/v2/test-lmz/openshift-update-service/openshift-update-service-rhel8/manifests/sha256:aea49b2145d59912757f2e371db2e23a9ba20cfa54d0c7132931e16d35655e40" http.request.useragent=go-containerregistry/v0.10.0 http.response.duration="259.493µs" http.response.status=202 http.response.written=0 instance.id=18c670a9-9bee-4d1b-9f24-2765bebb6c74 service=registry version=v3.0.0+unknown
::1 - - [16/Feb/2023:15:10:57 +0100] "DELETE /v2/test-lmz/openshift-update-service/openshift-update-service-rhel8/manifests/sha256:aea49b2145d59912757f2e371db2e23a9ba20cfa54d0c7132931e16d35655e40 HTTP/1.1" 202 0 "" "go-containerregistry/v0.10.0"

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

/assign @sherine-k
/assign @aguidirh

/assign @jchunkins
Hi John,
Would you mind taking a look at this PR. A demo of the working binary can be found here: https://drive.google.com/file/d/1U8cx4JMKLgBvw4dE-5dEzuiW_l5NaG7U/view?usp=sharing

/lgtm


Substring match should be case-insensitive

https://github.com/aspnet/Security/blob/5abcfe7e3d78f777d45503b50de5cea17cf9aa5e/src/Microsoft.AspNetCore.Authentication.JwtBearer/JwtBearerHandler.cs#L75
The outer check is case-insensitive, but the inner String.Substring call is not.

That's just a length check, there's no character comparison there too make case insensitive.


Bug fixes for initial deployment

I'm making this PR mainly so that I get the deploy previews from Netlify's github actions, since the video render is something that works in dev but then breaks in deployment.

Fix for the orble video render: copied it to the /public directory (in the root, not under src) and updated the path appropriately. I don't recommend moving all the images and such cuz they're imported directly, and in the README it says if theyre imported then keep them in the assets folder.


Simple two cell design, strange routing

This is a simple two cell design that I'm using for learning and evaluation -- it's two inverters and two ports:

Ports and pins are in metal1 -- the routing looks obvious: just three pieces of metal1 and you're done.  However, the router does something strange:

It's jumping up to metal2 when not necessary (in all cases), and doing some "scenic routing"
Is there a way to direct the router to conserve upper layer resources?
Complete stand-alone test case provided, just run make to reproduce.
OpenRoad_tc2.tar.gz
Thanks, Dan

We avoid routing on m1 as that tends to lead to pin access problems (not in this simple case but in general).  However the scenic routes will be investigated.

@mooredan the straight wire segments on metal1 didnt happen because there are high routing costs for running over/into the pins, due the the reasons Matt mentioned above.
Still, speaking the net a, it seems it could go metal2, and go straight to the left IO pin, and then go metal1. This didnt happen because TritonRoute forbids via access on IO pins at the moment.
Thus, in these very simple scenarios you can expect to see those things.

We generally don't see IOs on m1 so that is unusual.  In other layers planar access works well.  @mooredan is there anything more to pursue here?

This isn't a modern process so routing resources are limited with only three layers of metal, and a couple of more complex cells use some metal2.  Just looking at it from the perspective of what would a human do in these situations where a simple and obvious route in metal1 wouldn't occupy those precious metal2 resources.
Looking on the left hand side, it did do the route in metal1 (it did so too on the right hand side, but not as cleanly), and then did the unnecessary, and redundant, m1,via1,m2,via1 route blocking two metal2 tracks (metal2's preferred direction is horizontal).
Thanks for looking into this.

Do you think such simple cases occur often?  It can really only happen between adjacent pins.  We have focused on 130nm and below for which this isn't a concern.
It never really routed in m1 so much as the m1 shapes happened to touch in the process of going up and down to m2.

Sure, if it's possible and within the design rules, then it can occur.  My concern is needlessly utilizing the upper level routing resource when it isn't necessary to do so.  I did confirm that if the input and output pins were place on metal2 (in the same locations), then a much cleaner route occurs -- however it still is using metal2 for the intermediate route when a small piece of metal1 would suffice.
That said, anyone in the ASIC business knows that we spend significant time learning the tools that we work with and understanding their limitations and devising workarounds.  The tools from the "big three" aren't immune from these sort of things either.  However, I must say that support is so much better with FOSS.

It certainly could occur but I expect it will be very low frequency so the actual savings will be small.  I'm not basing this on any hard data and am open to being proven wrong on a more realistic design.

I'm going to close this as there is no further action on this simple case.  If you have a more realistic case in the future please (re)open an issue for it.


Set resource limit when using sidecar.istio.io/proxyCPU

Describe the feature request
For now in injector, we only set resources.request for istio-proxy when using sidecar.istio.io/proxyCPU and sidecar.istio.io/proxyMemory annotations. And no any resources.limit.
This will make some metrics miss, e.g. container_spec_memory_limit_bytes which makes trouble in monitor.
So can we add resources.limit in this situation?
Describe alternatives you've considered
two methods:

using two new annotations, maybe sidecar.istio.io/proxyCPULimit & sidecar.istio.io/proxyMemoryLimit or whatever;
reuse sidecar.istio.io/proxyCPU and sidecar.istio.io/proxyMemory to set both resources.request and resources.limit.

This is done recently #22395


Fix flags in cmake

This fix adds caching for default flags, so now it is possible to set them in cmake time.
Before:
cmake -DCMAKE_CXX_FLAGS="-O3" ..

will be overwritten with `set(CMAKE_CXX_FLAGS "...")
Now -- CMAKE_CXX_FLAGS will be cached from cmake arguments.

It has been decided that @bakhtin will pull these changes to his branch first.