linux: patch CVE-2016-0728 [security, local privilege escalation]

The PoC provided successfully escalates privileges from a local user to
root. The vulnerability affects any Linux Kernel version 3.8 and higher.
http://perception-point.io/2016/01/14/analysis-and-exploitation-of-a-linux-kernel-vulnerability-cve-2016-0728/
(Do we have a standard process for security patching at all? I track these fairly closely and patch them on my own systems before they make their way into a nixpkgs PR, but it's hard to test build them all ahead of time.)

Have you tested the patch applies cleanly at least, in all those kernels? (Building all would take long, to be sure.)
The workflow here isn't governed by many (hard) rules. Do you want to know anything specific?

I at least tested the default kernels build on both branches.

Not a big deal, but in future I'd suggest using fetchPatch or keeping the patch remote. I don't think it's sustainable to keep putting external content into nixpkgs proper.

@copumpkin This is a security patch (ie short-term) that should be fixed in upstream soon. I couldn't find anywhere to fetch it from except the Fedora kernel repo (I didn't think using their webgit as a download source was a very good idea)

Ah fair enough
On Wed, Jan 20, 2016 at 08:03 Nathan Zadoks<EMAIL_ADDRESS>wrote:

@copumpkin https://github.com/copumpkin This is a security patch (ie
short-term) that should be fixed in upstream soon. I couldn't find anywhere
to fetch it from except the Fedora kernel repo (I didn't think using their
webgit as a download source was a very good idea)
—
Reply to this email directly or view it on GitHub
https://github.com/NixOS/nixpkgs/pull/12492#issuecomment-173197167.

Most usages of fetchpatch at present are from git repositories, so using it would be consistent. And @vcunat used a patch from Fedora for fontforge: https://github.com/NixOS/nixpkgs/blame/master/pkgs/tools/misc/fontforge/default.nix

fetchpatch is there to determinize generated patches. Otherwise fetchurl is probably better, even for patches. But this one should be there for a few weeks at most.

should be there for a few weeks at most.

...and for the rest of history in our git repo :smile:

I don't think that's an issue for this small patch.

My point was a bigger policy one. I don't think we should keep bundling this sort of thing into the repo, in general. Every individual patch is fine but in aggregate it's not great.

On Jan 20, 2016, at 14:24, Vladimír Čunát<EMAIL_ADDRESS>wrote:
I don't think that's an issue for this small patch.
—
Reply to this email directly or view it on GitHub.

There I agree. If there's wide consensus, best add that policy to http://nixos.org/nixpkgs/manual/#chap-submitting-changes


Add comments to the addons package

Provide comments to the addons package to understand its functioning
more quickly and improve our code
Signed-off-by: Manuel Buil<EMAIL_ADDRESS>Why is this PR needed?
Go language takes documentation seriously in order to make it accessible to newcomers and better maintainable. After spending some time trying to understand the Addons package of Skuba, I decided to contribute what I learnt by including some comments and a brief README. Hopefully, that will reduce the time to understand the package for anyone unfamiliar with it. Comments follow the godoc rules:
https://blog.golang.org/godoc-documenting-go-code
What does this PR do?
Adds documentation to the functions of addons.go and a brief README that describes addons and how they hook into Skuba
Anything else a reviewer needs to know?

Info for QA

Related info
Follows the Godoc rules: https://blog.golang.org/godoc-documenting-go-code
Status BEFORE applying the patch

Status AFTER applying the patch

Docs

Merge restrictions

(Please do not edit this)
We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:
What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

LGTM
However, I'm not familiar enough with this code so I defer to others the final approval
Thanks for this, code documented is always a good things


Final round of Android build fixes

Fix the missing include for mojo
Get rid of OnJNIOnload and OnLoadDelegate as per,
https://codereview.chromium.org/935413004

@rakuco I have updated the patch again to include only '../third_party/mojo/mojo_public.gyp:mojo_cpp_bindings' target instead of bigger 'mojo/mojo_base.gyp:mojo_environment_chromium'


xray_repository_config fails after JAS trial

Describe the bug
Recently we trialed JFrog Advanced Security and enabled vulnerability scans using the UI. The trial is over and we tried to modify the retention period using Terraform. We originally struggled to update the config using the UI but fixed it with the following:
curl -u USERNAME -H 'Content-Type: application/json' -d '{"repo_name":"my-local-repo","repo_config":{"retention_in_days":90}}' -X PUT "https://artifactory_url/xray/api/v1/repos_config"
Now trying to modify the configuration is met with the following error:
Error:
400 PUT https://artifactory_URL/xray/api/v1/repos_config
{"error":"Request payload is invalid as vuln contextual analysis config was not expected"}

  with module.container.xray_repository_config.xray-local-repo-config,
  on ../modules/repositories/container/xray.tf line 10, in resource "xray_repository_config" "xray-local-repo-config":
  10: resource "xray_repository_config" "xray-local-repo-config" {

Requirements for and issue
resource "artifactory_local_docker_v2_repository" "container-local" {
  key                  = "my-local-repo
  project_environments = []
  xray_index           = true
}

resource "xray_repository_config" "xray-local-repo-config" {
  repo_name = 'my-local-repo'

  config {
    retention_in_days = 90
  }
}

Artifactory Version: 7.71.11
Xray Version: 3.86.10
Terraform Version: 1.3.3
Artifactory Provider Version: 10.1.1
Terraform Provider Version: 2.1.0
Expected behavior
Config resource should be created with the configured retention settings
Additional context
Have tried removing the existing config via UI to see if it could be "created properly" via  Terraform. Also worked with jfrog support to get the UI configs working again via the API which seems to work still.

@Brian-Plantenberg-BBY Thanks for the report. Can you share the output of terraform plan?

  # module.container.xray_repository_config.xray-local-repo-config will be created
+   resource "xray_repository_config" "xray-local-repo-config" {
+       id        = (known after apply)
+       repo_name = "my-local-repo"

+       config {
+           retention_in_days = 90
        }
    }

@Brian-Plantenberg-BBY BTW, you may want to use Terraform reference to ensure the dependency tree between Xray repo_config resource and Artifactory repo is correct, e.g.:
resource "artifactory_local_docker_v2_repository" "container-local" {
  key                  = "my-local-repo
  project_environments = []
  xray_index           = true
}

resource "xray_repository_config" "xray-local-repo-config" {
  repo_name = artifactory_local_docker_v2_repository.container-local.key # reference instead of plain text

  config {
    retention_in_days = 90
  }
}

@Brian-Plantenberg-BBY BTW, you may want to use Terraform reference to ensure the dependency tree between Xray repo_config resource and Artifactory repo is correct, e.g.:
resource "artifactory_local_docker_v2_repository" "container-local" {
  key                  = "my-local-repo
  project_environments = []
  xray_index           = true
}

resource "xray_repository_config" "xray-local-repo-config" {
  repo_name = artifactory_local_docker_v2_repository.container-local.key # reference instead of plain text

  config {
    retention_in_days = 90
  }
}

We are, for some reason I set it to plain text in my sample TF when I was cleaning it up for the ticket

@Brian-Plantenberg-BBY I have not been able to reproduce this issue yet. Here's the TF config I'm using:
# Required for Terraform 0.13 and up (https://www.terraform.io/upgrade-guides/0-13.html)
terraform {
  required_providers {
    xray = {
      source  = "registry.terraform.io/jfrog/xray"
      version = "2.1.1"
    }
  }
}

provider "xray" {
}

resource "xray_repository_config" "xray-repo-config-pattern" {
  repo_name = "alexh-npm-local"

  config {
    retention_in_days = 90
  }
}

alexh-npm-local is an existing repo with Xray Indexing set to 'On'.
Then I run terraform plan and terraform apply and got no errors.
alexh@alexh-mac terraform-provider-xray % terraform plan

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # xray_repository_config.xray-repo-config-pattern will be created
  + resource "xray_repository_config" "xray-repo-config-pattern" {
      + id        = (known after apply)
      + repo_name = "alexh-npm-local"

      + config {
          + retention_in_days = 90
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't guarantee to take exactly these actions if you run "terraform apply" now.
alexh@alexh-mac terraform-provider-xray % terraform apply

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # xray_repository_config.xray-repo-config-pattern will be created
  + resource "xray_repository_config" "xray-repo-config-pattern" {
      + id        = (known after apply)
      + repo_name = "alexh-npm-local"

      + config {
          + retention_in_days = 90
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

xray_repository_config.xray-repo-config-pattern: Creating...
xray_repository_config.xray-repo-config-pattern: Creation complete after 0s [id=alexh-npm-local]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.
alexh@alexh-mac terraform-provider-xray % terraform --version
Terraform v1.6.5
on darwin_amd64
+ provider registry.terraform.io/hashicorp/random v3.6.0
+ provider registry.terraform.io/jfrog/xray v2.1.1

Your version of Terraform is out of date! The latest version
is 1.7.0. You can update by downloading from https://www.terraform.io/downloads.html

(You can ignore the the Xray provider version being off. Our local test script automatically increment the patch version when building a new binary)

@Brian-Plantenberg-BBY Never mind 😄 I found the issue. Will try to get a patch out today.

No worries, I can always enable via the API for all of our repos for now as a temporary workaround

@Brian-Plantenberg-BBY I've released a new version with new attribute jas_enabled to control the provider interaction with Xray API depending on if JAS is enabled or not. Please try it out and let me know how it works out.


QUESTION: how to add webjars?

Hey,
I jave followed the example in this repo to add the configuration for swagger, unfortunately I am not sure where to get webjars from.
Currently Swagger tries to load something from http://myip:7777/webjars the IP and Port is correct but I am not sure where I need to get the webjars stuff from. Is that an Endpoint I have to create?
Thanks alot

It's automatically handled by Swagger/ReDoc plugin:

https://github.com/javalin/javalin-openapi/blob/main/javalin-plugins/javalin-redoc-plugin/src/main/kotlin/io/javalin/openapi/plugin/redoc/ReDocWebJarHandler.kt

So I need to add something into my meta-inf? for it to work?

It's already added in Swagger & ReDoc plugins, you shouldn't be worried about it.


[Bug] Null coalescing operator error in Chrome 74

Bug report
What I did
Loaded any CRUD page in Chrome 74.
What I expected to happen
The page should have worked
What happened
The CRUD page didn't load properly in Chrome 74. Additionally, a JavaScript error was shown in the developer console: Uncaught SyntaxError: Unexpected token '?'.
What I've already tried to fix it
Replaced the null coalescing operator with ternary operator in the following files:

vendor/backpack/crud/src/resources/views/base/inc/alerts.blade.php
vendor/backpack/crud/src/resources/views/crud/inc/datatables_logic.blade.php

Backpack, Laravel, PHP, DB version
When I run php artisan backpack:version the output is:
### PHP VERSION:
PHP 7.4.16 (cli) (built: Mar  5 2021 07:54:38) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.16, Copyright (c), by Zend Technologies

### LARAVEL VERSION:
v7.30.4@9dd38140dc2924daa1a020a3d7a45f9ceff03df3

### BACKPACK VERSION:
4.1.41@44770347b918e42c052d0a138c24535b43e32472

Hello @dandarie
Thanks for raising the issue and submitting a fix. I will add my comment in the PR and close this, so we keep any discussion about it there.
Wish you the best,
Pedro


forge test error

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

import "forge-std/Test.sol";
import {PoolSwapBaseTest} from "../../shared/Swap.t.sol";

import {Pool} from "src/Pool.sol";
import {PoolMath} from "src/libs/PoolMath.sol";
import {Errors} from "src/libs/Errors.sol";
import {MockCallbackReceiver} from "../../mocks/MockCallbackReceiver.sol";
import {SafeCast} from<EMAIL_ADDRESS>import {SignedMath} from<EMAIL_ADDRESS>
using SignedMath for int256;
using SafeCast for uint256;

abstract contract PoolSwapFuzzTest is PoolSwapBaseTest {
    /// @dev add liquidity to BasePool
    modifier setUpDepositToBasePool(uint256[3] memory amounts) {
        address lp1 = makeAddr("lp1");
        _approvePts(lp1, address(baseLpt), type(uint256).max);
        for (uint256 i = 0; i < amounts.length; i++) {
            deal(address(pts[i]), lp1, amounts[i], true);
        }
        _basePoolAddLiquidity(lp1, amounts, 0, lp1);
        _;
    }

    /// @param index index of the pt to swap
    /// @param ptsToBasePool amount of pts to deposit to base pool before swap
    /// @param ptDesired amount of pt to swap (in/out)
    /// @param timestamp timestamp when swap is executed
    struct SwapFuzzInput {
        uint256 index;
        uint256[3] ptsToBasePool;
        uint256 ptDesired;
        uint256 timestamp;
    }

    modifier boundSwapFuzzInput(SwapFuzzInput memory input) {
        input.index = bound(input.index, 0, N_COINS - 1); // 0 <= index < N_COINS
        input.ptsToBasePool = bound(input.ptsToBasePool, 1_000, 100 * ONE_UNDERLYING);
        // if reserve on pool is less than ptIn, revert with ProportionTooHigh
        input.ptDesired = bound(input.ptDesired, 100, input.ptsToBasePool[input.index]);
        // timestamp [block.timestamp, maturity - 1]
        input.timestamp = bound(input.timestamp, block.timestamp, maturity - 1);
        _;
    }
}

contract PoolSwapPtForUnderlyingFuzzTest is PoolSwapFuzzTest {
    /// @notice test swap when callback data is given
    function testFuzz_WhenCallData(SwapFuzzInput memory swapInput)
        public
        boundSwapFuzzInput(swapInput)
        whenMaturityNotPassed
        setUpDepositToBasePool(swapInput.ptsToBasePool)
    {
        _deployMockCallbackReceiverTo(receiver);
        deal(address(underlying), receiver, 1e6 * ONE_UNDERLYING, false);
        vm.warp(swapInput.timestamp);

        _testFuzz_swapUnderlyingForPt(swapInput);
    }

    /// @notice test swap when callback data is not given
    function testFuzz_WhenNoCallData(SwapFuzzInput memory swapInput)
        public
        boundSwapFuzzInput(swapInput)
        whenMaturityNotPassed
        setUpDepositToBasePool(swapInput.ptsToBasePool)
    {
        // give enough underlying to pool
        fund(address(underlying), address(pool), 1e6 * ONE_UNDERLYING, false);
        vm.warp(swapInput.timestamp);

        _testFuzz_swapUnderlyingForPt(swapInput);
    }

    /// @dev
    /// Pre-condition: liquidity is added to the pool
    /// Test case: swap underlying for pt
    /// Post-condition:
    ///   1. underlying balance of receiver should increase by the return value from swapPtForUnderlying
    ///   2. underlying reserve should be decreased by the amount of underlying sent to receiver and fee
    ///   3. Solvenvy check
    ///   4. baseLpt minted should be approximately equal to the expected amount
    function _testFuzz_swapUnderlyingForPt(SwapFuzzInput memory swapInput) public {
        uint256 index = swapInput.index;
        uint256 ptOutDesired = swapInput.ptDesired;

        // pre-condition
        uint256 preBaseLptSupply = baseLpt.totalSupply();
        bytes memory callbackData =
            receiver.code.length == 0 ? bytes("") : abi.encode(Pool.swapUnderlyingForPt.selector, underlying);
        // execute
        uint256 underlyingIn = pool.swapUnderlyingForPt(index, ptOutDesired, receiver, callbackData);
        // assert 1
        assertApproxEqRel(
            pts[index].balanceOf(receiver),
            ptOutDesired,
            0.01 * 1e18, // This error is due to the approximation error between the actual and expected baseLpt minted
            // See CurveV2Pool.calc_token_amount and CurveV2Pool.remove_liquidity_one_coin
            "receiver should receive appropriately amount of pt [rel 1%]"
        );
        // assert 2
        assertUnderlyingReserveAfterSwap({
            underlyingToAccount: -underlyingIn.toInt256(),
            protocolFeeIn: pool.accumulatedFee(),
            preTotalUnderlying: preTotalUnderlying
        });
        // assert 3
        assertEq(
            pool.totalBaseLpt(),
            preTotalBaseLpt - (preBaseLptSupply - baseLpt.totalSupply()),
            "reserve should be decreased by baseLpt burned"
        );
        // assert 4
        assertSolvencyReserve();
    }
}

My operating system is windows 10.
I typed "forge test" but error occurs.
Failing tests:
Encountered 1 failing test in test/fuzz/pool/Swap.t.sol:PoolSwapPtForUnderlyingFuzzTest
[FAIL. Reason: Setup failed: Failed to execute command: %1 is not a valid Win32 application. (os error 193)] setUp() (gas: 0) ```

is this still an issue?
can you try via WSL?

closing because this looks like an issue related to windows paths
https://stackoverflow.com/questions/185042/how-do-i-resolve-1-is-not-a-valid-win32-application


BUG: Fix bug in type conversion of arrays; add array and struct tests

As per @tswast's requests in https://github.com/pydata/pandas-gbq/issues/22 and https://github.com/pydata/pandas-gbq/issues/23, tests added to check that arrays and structs are successfully returned and named properly from a query.
While running tests, identified a bug with the type conversion in read_gbq (see below). Updated it so it only performs type conversion with the added condition that the returned field mode IS NOT repeated.
To re-produce type conversion error with array:
>>> import gbq
>>> query = """WITH t as (
...         SELECT "a" letter, 1 num
...         UNION ALL
...         SELECT "b" letter, 2 num
...         UNION ALL
...         SELECT "a" letter, 3 num)
...
...         select letter, array_agg(num order by num ASC) num_array
...         from t
...         group by letter"""
>>> df = gbq.read_gbq(query, project_id='XXXXX',dialect='standard',verbose=False)

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "gbq.py", line 877, in read_gbq
    final_df[field['name']].astype(type_map[field['type'].upper()])
  File "/Users/jasonng/anaconda2/lib/python2.7/site-packages/pandas/util/_decorators.py", line 118, in wrapper
    return func(*args, **kwargs)
  File "/Users/jasonng/anaconda2/lib/python2.7/site-packages/pandas/core/generic.py", line 4004, in astype
    **kwargs)
  File "/Users/jasonng/anaconda2/lib/python2.7/site-packages/pandas/core/internals.py", line 3462, in astype
    return self.apply('astype', dtype=dtype, **kwargs)
  File "/Users/jasonng/anaconda2/lib/python2.7/site-packages/pandas/core/internals.py", line 3329, in apply
    applied = getattr(b, f)(**kwargs)
  File "/Users/jasonng/anaconda2/lib/python2.7/site-packages/pandas/core/internals.py", line 544, in astype
    **kwargs)
  File "/Users/jasonng/anaconda2/lib/python2.7/site-packages/pandas/core/internals.py", line 625, in _astype
    values = astype_nansafe(values.ravel(), dtype, copy=True)
  File "/Users/jasonng/anaconda2/lib/python2.7/site-packages/pandas/core/dtypes/cast.py", line 692, in astype_nansafe
    return lib.astype_intsafe(arr.ravel(), dtype).reshape(arr.shape)
  File "pandas/_libs/lib.pyx", line 854, in pandas._libs.lib.astype_intsafe
  File "pandas/_libs/src/util.pxd", line 91, in util.set_value_at_unsafe
ValueError: setting an array element with a sequence.

Codecov Report

Merging #101 into master will decrease coverage by 44.56%.
The diff coverage is 25%.

@@             Coverage Diff             @@
##           master     #101       +/-   ##
===========================================
- Coverage    73.5%   28.94%   -44.57%
===========================================
  Files           4        4
  Lines        1491     1503       +12
===========================================
- Hits         1096      435      -661
- Misses        395     1068      +673

Impacted Files
Coverage Δ

pandas_gbq/gbq.py
20.55% <ø> (-55.94%)
:arrow_down:

pandas_gbq/tests/test_gbq.py
27.94% <25%> (-54.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cab83c...ac2d268. Read the comment docs.


Profiler module scaffolding

(sorry for recreating, I had made a mess of the #248)
Set up the scaffolding for adding profiling code. The activation doesn't do anything yet, but it will check for splunk.profiler.enabled=true, which defaults to false.
I also thought we'd want to exclude the profiling code from builds for a while (since we're close to 1.0), so I made that conditional in the agent with a gradle property. We can remove that after 1.0.

@breedx-splk please rebase to fix PR checks.


[Bug report] postcss-loader dependency missing?

Bug report
postcss-loader dependency seems to be missing somewhere, but I cant tell where. docs:dev npm script fails on empty project
Description
I followed the steps exactly as described on the Getting Started and went to yarn docs:dev and get the following errors:
➜  docs git:(docsify-init) ✗ yarn serve
yarn run v1.22.15
$ vuepress dev src
info Initializing VuePress and preparing data...
✔ Compilation finished in 562ms
success VuePress webpack dev server is listening at http://localhost:8080/
ERROR in<EMAIL_ADDRESS>2:0-28
Module not found: Error: Can't resolve 'postcss-loader' in '/Users/<ME>/Documents/github.carmax.com/horizon/packages/docs'

ERROR in<EMAIL_ADDRESS>4:0-28
Module not found: Error: Can't resolve 'postcss-loader' in '/Users/<ME>/Documents/github.carmax.com/horizon/packages/docs'

ERROR in<EMAIL_ADDRESS>5:0-35
Module not found: Error: Can't resolve 'postcss-loader' in '/Users/<ME>/Documents/github.carmax.com/horizon/packages/docs'

ERROR in<EMAIL_ADDRESS>4:0-27
Module not found: Error: Can't resolve 'postcss-loader' in '/Users/<ME>/Documents/github.carmax.com/horizon/packages/docs'

ERROR in<EMAIL_ADDRESS>5:0-34
Module not found: Error: Can't resolve 'postcss-loader' in '/Users/<ME>/Documents/github.carmax.com/horizon/packages/docs'

ERROR in<EMAIL_ADDRESS>4:0-28
Module not found: Error: Can't resolve 'postcss-loader' in '/Users/<ME>/Documents/github.carmax.com/horizon/packages/docs'

ERROR in<EMAIL_ADDRESS>5:0-33
Module not found: Error: Can't resolve 'postcss-loader' in '/Users/<ME>/Documents/github.carmax.com/horizon/packages/docs'

ERROR in<EMAIL_ADDRESS>8:0-29
Module not found: Error: Can't resolve 'postcss-loader' in '/Users/<ME>/Documents/github.carmax.com/horizon/packages/docs'

webpack compiled with 8 errors

I'm in a yarn/lerna monorepo
Steps to reproduce

Follow Getting Started steps exactly on fresh project.
yarn docs:dev

Expected behavior
expected yarn docs:dev to start the site
Screenshots

Environment info

Browser:
Output of vuepress info:

are all the "not found"s because i'm in a monorepo and these dependencies are hoisted to the root?
 System:
    OS: macOS 11.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 289.43 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.17.5 - ~/.nvm/versions/node/v14.17.5/bin/node
    Yarn: 1.22.15 - ~/.yarn/bin/yarn
    npm: 7.21.1 - ~/.nvm/versions/node/v14.17.5/bin/npm
  Utilities:
    Git: 2.30.1 - /usr/bin/git
  Browsers:
    Chrome: 95.0.4638.54
    Edge: Not Found
    Firefox: Not Found
    Safari: 15.0
  npmPackages:
    @vuepress/bundler-vite: Not Found
    @vuepress/bundler-webpack: Not Found
    @vuepress/cli: Not Found
    @vuepress/client: Not Found
    @vuepress/core: Not Found
    @vuepress/markdown: Not Found
    @vuepress/plugin-active-header-links: Not Found
    @vuepress/plugin-back-to-top: Not Found
    @vuepress/plugin-container: Not Found
    @vuepress/plugin-debug: Not Found
    @vuepress/plugin-docsearch: Not Found
    @vuepress/plugin-git: Not Found
    @vuepress/plugin-google-analytics: Not Found
    @vuepress/plugin-medium-zoom: Not Found
    @vuepress/plugin-nprogress: Not Found
    @vuepress/plugin-palette: Not Found
    @vuepress/plugin-prismjs: Not Found
    @vuepress/plugin-pwa: Not Found
    @vuepress/plugin-pwa-popup: Not Found
    @vuepress/plugin-register-components: Not Found
    @vuepress/plugin-search: Not Found
    @vuepress/plugin-shiki: Not Found
    @vuepress/plugin-theme-data: Not Found
    @vuepress/plugin-toc: Not Found
    @vuepress/shared: Not Found
    @vuepress/theme-default: Not Found
    @vuepress/utils: Not Found
    vue: Not Found
    vue-loader: Not Found
    vue-router: Not Found
    vuepress: Not Found
    vuepress-vite: Not Found

Please check my issues, I opened a similar issue before.
The missing loader probably happens because you are both requiring different postcss-loader and postcss versions somewhere.
Webpack bundler has a huge deps tree, so you have to make sure that all your loaders in monorepo are have same major versions, or there may be some annoying issues.
If you are using webpack in another package in monorepo, I personally suggest you to use vite. That will have less chance go get version conflict resulting a broken deps tree.

im not using webpack anywhere else in my monorepo. My monorepo is a design system project where each package is a set of unbundled web components. The only place in the repo has another postcss install is the root which is using tailwindcss that has a bundled postcss impl inside, but i would doubt thats part of the issue, since tailwind wouldn't be using webpack or postcss-loader.

I encountered the same issue, too, after upgrading from VuePress 2.0.0-beta.26 to 2.0.0-beta.27. My workaround is to include "postcss-loader": "^6.2.0" in my package.json devDependencies. I'm using Yarn 1.22.10.


Add a endpoint for Anthology, collection of Icelandic literary

Hi, i was working on an app for a school project recently where i was scraping http://visna.net and i thought it would be nice to be able to get icelandic poems and verses in JSON format
Websites ideas to scrape:

http://bragi.info
http://visna.net
http://ljod.is

the endpoint(s) could be set up like this.
/anthology
/anthology/poems
/anthology/verses

This sounds neat, thanks for opening the issue 🎉 ! I have a couple of questions, if that's cool.

the endpoint(s) could be set up like this.
/anthology
/anthology/poems
/anthology/verses

What would these endpoint return and what parameters would they take in? Is /anthology/poems returning all poems we can scrape in a paginated result?
How are you thinking about the data structure of the poems? Initially I'm thinking something like this, but I'm not sure if I'm missing some metadata:
{
    "title": "foo",
    "body": "bar",
    "published": 2017
}

What's the difference between poems and verses?

Great that you like it.
ye to get further into it, i'm not sure what params they might take in, maybe things like id, author and published?
Regarding the data structure i thought something like this which i used in my app when scraping http://visna.net but it might be better to structure it a bit better
{
     id: "522",
    title: "Á Njáluslóðum.",
    text: "Á Hlíðarenda var heljar drift,
    en hjónabandið var allt í báli.
    Því Hallgerður var homma gyft,
    og hann var alltaf að ríða Njáli.",
    author: "Höfundur:  Sálmaskáldið.",
    published: ""
}

The difference between poems and verses, how i think of it is that Poems are Ljóð and that verses are more like lausavísur (i. fyndnar vísur, klámvísur og eitthvað svoleiðis)

Cool! Here's what I'm thinking and please do note that this is just my own opinion and I'm not benevolent dictator here 😸
While this could be a good endpoint for people to use the data doesn't seem "scientific" enough to me to warrant adding it to apis.is at this stage. We are really low on resources to add endpoints and maintain the project right now. Previously we've had endpoints that give you the air quality in Reykjavík and seismic activity that developers can use to build apps with and with poems I can mostly see it being a poem reading app and not much more.
That being said, if you or someone else want's to pick this up and work on this and make a PR we will accept it with thanks but right now I don't think we'll put this on the roadmap 💖

Ye i was actually thinking of doing this and making a PR, just wanted to find out what you guys thought of that first 😃

and yea i understand completely that the data doesn't seem scientific enough :smiley so maybe not something that should be a priority, i just thought it would be neat and also maybe help preserving Icelandic literature

Awesome! I can't see why not; we have plenty of endpoints right now 😄
If I can make a suggestion about the API for this endpoint. I'm thinking about something like this:
/poems               <- returns a paginated list of poems
/poems/:id          <- returns a single poem
/poems/random <- returns a random poem

and the data structure could be something like this:
GET /poems
{
  "results": [...],
  "pagination": {
    "current": 1,
    "next": 2,
    "previous": null,
    "total": 1597
}

I also think that starting with one datasource would make sense instead of trying to all the data sources at once and running into issues with pagination. But it's of course your call 😄


fix(show): add solutions view

I have added a modal, on lines of @Bouncey 's work from the beta, and this should let us tackle the complaints by re-enabling viewing solutions on the production.
Please note, lets take #16740 first before merging this.

I did not bother, taking care of any syntax-highlighting, considering all this change are going away when we ship beta.
This should at least be of some relief to the users.

@raisedadead Great - thanks for making this. From a UX perspective this looks good and is clearly an improvement. I'll defer to @BerkeleyTrue for feedback on how you implemented this.

My understanding was that master is on a feature freeze?

Yes, @Bouncey that is correct, but going by the forum and the chat rooms, the regression that we introduced with https://github.com/freeCodeCamp/freeCodeCamp/pull/16552 is quite inconvenient to the the users on the production, before we are able to launch beta.

@raisedadead Awesome - thanks for fixing this!


Addon not working

All my shows saved to the library play fine but when I try to open the specto addon itself it errors out. If I go into settings everything is listed as general.

I got it fixed! Thanks for your hard work, this is my go to addon!


DTLS start before ICE state change to non-NEW in v3.0.29

Your environment.

Version: go 1.14  webrtc v3.0.29
Browser: include version
Other Information - stacktraces, related issues, suggestions how to fix, links for us to have context

What did you do?

What did you expect?
What happened?
DTLS will check the connection status of the ICE before the handshake, but the connection status of ICE has not changed to non-NEW. So, DTLS returns an error without doing anything. WebRTC Client will timeout during DTLS handshake.
ICE change state in other goroutinue.
DTLS prepareTransport checking the connection status of the ICE
func (t *DTLSTransport) Start(remoteParameters DTLSParameters) error {
	prepareTransport := func() (DTLSRole, *dtls.Config, error) {
		t.lock.Lock()
		defer t.lock.Unlock()

		if err := t.ensureICEConn(); err != nil {
			return DTLSRole(0), nil, err
		}

		if t.state != DTLSTransportStateNew {
			return DTLSRole(0), nil, &rtcerr.InvalidStateError{Err: fmt.Errorf("%w: %s", errInvalidDTLSStart, t.state)}
		}
.......
	}

	var dtlsConn *dtls.Conn
	dtlsEndpoint := t.iceTransport.newEndpoint(mux.MatchDTLS)
	role, dtlsConfig, err := prepareTransport()
	if err != nil {
		return err
	}

ensure ICE connection check ICE state != NEW
func (t *DTLSTransport) ensureICEConn() error {
	if t.iceTransport == nil || t.iceTransport.State() == ICETransportStateNew {
		return errICEConnectionNotStarted
	}

	return nil
}

But ICE real change state in other goroutinue
func (a *Agent) startOnConnectionStateChangeRoutine() {
	........

	go func() {
		for {
			select {
			case s, isOpen := <-a.chanState:
				if !isOpen {
					for c := range a.chanCandidate {
						a.onCandidate(c)
					}
					return
				}
				a.onConnectionStateChange(s)

			case c, isOpen := <-a.chanCandidate:
				if !isOpen {
					for s := range a.chanState {
						a.onConnectionStateChange(s)
					}
					return
				}
				a.onCandidate(c)
			}
		}
	}()
}

Hi @vicvon
Thank you for the report. I looked at the code a bit, and I believe we don't start the DTLS Agent until a ICE Candidate pair has been chosen.

iceTransport.Start is called before DTLS.
This either does a Dial/Accept on the pion/ice.Agent
pion/ice doesn't return until a Candidate pair has been chosen here

Hi @Sean-Der

pion/ice may return before ICE State change here
close(a.onConnected) before update state
dtlsTransport.start may be fail


Using Tokenizer with num_words

Using Tokenizer from keras.preprocessing.text. From the following code:
  from keras.preprocessing.text import Tokenizer
  tk = Tokenizer(num_words=2)
  texts = ["my name is far", "my name is","your name is"]
  tk.fit_on_texts(texts)

And applying on it:
  >>> tk.texts_to_sequences(texts)
  >>> [[1], [1], [1]]

But:
  >>> tk.word_index
  >>> {'far': 4, 'is': 1, 'my': 3, 'name': 2, 'your': 5}

Why word_index of the tokenizer stores all the words and not only the top num_words? Shouldnt it be in that case:
  >>> tk.word_index
  >>> {'is': 1}

Is there a reason that all values are kept?

The way I personally use Tokenizer is to initialize a Tokenizer once without a num_words argument, fit on the texts, and then change the num_words attribute as I see fit. It doesn't make a lot of sense to reinitialize and refit a Tokenizer when you just want to change the number of words, as you've pointed out all the necessary information is stored on the Tokenizer anyway. So my theory as to why it's designed that way is the ability to do this:
In [1]: from keras.preprocessing.text import Tokenizer
In [2]: tk = Tokenizer()
In [3]: texts = ["my name is far", "my name is","your name is"]
In [4]: tk.fit_on_texts(texts)
In [5]: tk.num_words = 2
In [6]: tk.texts_to_sequences(texts)
Out[6]: [[1], [1], [1]]
In [7]: tk.num_words = 3
In [8]: tk.texts_to_sequences(texts)
Out[8]: [[1, 2], [1, 2], [1, 2]]

Though I would argue a better design would be to drop the num_words argument from __init__ and move it to the various texts_to_... methods as an argument, like so:
tk = Tokenizer()
tk.fit_on_texts(texts)
tk.texts_to_sequences(texts, num_words=2)

I'm seeing the same issue.  According to documentation, num_words should limit the number of words mapped by the tokenizer.  I don't see this to be the case...
`from keras.preprocessing.text import Tokenizer
tokenizer = Tokenizer(num_words=10)
tokenizer.fit_on_texts([raw_text])
word_vectors = tokenizer.texts_to_sequences([raw_text])
word_vector = word_vectors[0]
print(len(word_vector))
print('Num words = {0}'.format(len(tokenizer.word_index)))`
yields me 1124 words.  I also tried inserting a num_words between training and sequence conversion, no difference in behavior.  Are there any examples out there illustrating correct or intended use of num_words?

I attempted to explain this here: https://github.com/keras-team/keras/issues/8583#issuecomment-346981336

Lots of issues have been created about the tokenizer, #8583,  #7551, #7836, #4998  because the code doesn't correctly handle OOVs and the num_words parameters and the documentation and code are out of sync. Here's a small example of how we can achieve the correct behavior. Unfortunately, this truncates the word_index outside the class. But as I show below this truncation is necessary. Otherwise the tokenizer drops the OOV tokens even if we give the oov_token parameter.
>> num_words = 3
>> tk = kpt.Tokenizer(oov_token='UNK', num_words=num_words+1)
>> texts = ["my name is far faraway asdasd", "my name is","your name is"]
>> tk.fit_on_texts(texts)
>> print(tk.word_index)
>> print(tk.texts_to_sequences(texts))
>> ## **Key Step**
>> tk.word_index = {e:i for e,i in tk.word_index.items() if i <= num_words} # <= because tokenizer is 1 indexed
>> tk.word_index[tk.oov_token] = num_words + 1
>> print(tk.word_index)
>> print(tk.texts_to_sequences(texts))
{'your': 7, 'my': 3, 'name': 1, 'far': 4, 'faraway': 5, 'is': 2, 'UNK': 8, 'asdasd': 6}
[[3, 1, 2], [3, 1, 2], [1, 2]]  ## Wrong Behavior. Should not drop OOVs
{'name': 1, 'my': 3, 'is': 2, 'UNK': 4}
[[3, 1, 2, 4, 4, 4], [3, 1, 2], [4, 1, 2]] ## Correct behavior

Thanks se4u, I had your same issue and your trick solved it!

@se4u you save my day. Should they fix it?

thanks @se4u I think they should acknowledge this so that it could be fixed.

Any chance this would be fixed? It's a pretty nasty behaviour if you ask me. Just don't drop OOV words unless explicitly requested to do so.

@se4u: You've done a great job of illustrating the problem.
If you're wanting to preserve the most frequently used words, you can replace the following (in @se4u's code)
    tk.word_index = {e:i for e,i in tk.word_index.items() if i <= num_words} # <= because tokenizer is 1 indexed

with
    sorted_by_word_count = sorted(tk.word_counts.items(), key=lambda kv: kv[1], reverse=True)
    tk.word_index = {}
    i = 0
    for word,count in sorted_by_word_count:
        if i == num_words:
            break
        tk.word_index[word] = i + 1    # <= because tokenizer is 1 indexed
        i += 1

(Although, there's almost definitely a more elegant way to do this in Python.)

Lots of issues have been created about the tokenizer, #8583, #7551, #7836, #4998 because the code doesn't correctly handle OOVs and the num_words parameters and the documentation and code are out of sync. Here's a small example of how we can achieve the correct behavior. Unfortunately, this truncates the word_index outside the class. But as I show below this truncation is necessary. Otherwise the tokenizer drops the OOV tokens even if we give the oov_token parameter.
>> num_words = 3
>> tk = kpt.Tokenizer(oov_token='UNK', num_words=num_words+1)
>> texts = ["my name is far faraway asdasd", "my name is","your name is"]
>> tk.fit_on_texts(texts)
>> print(tk.word_index)
>> print(tk.texts_to_sequences(texts))
>> ## **Key Step**
>> tk.word_index = {e:i for e,i in tk.word_index.items() if i <= num_words} # <= because tokenizer is 1 indexed
>> tk.word_index[tk.oov_token] = num_words + 1
>> print(tk.word_index)
>> print(tk.texts_to_sequences(texts))
{'your': 7, 'my': 3, 'name': 1, 'far': 4, 'faraway': 5, 'is': 2, 'UNK': 8, 'asdasd': 6}
[[3, 1, 2], [3, 1, 2], [1, 2]]  ## Wrong Behavior. Should not drop OOVs
{'name': 1, 'my': 3, 'is': 2, 'UNK': 4}
[[3, 1, 2, 4, 4, 4], [3, 1, 2], [4, 1, 2]] ## Correct behavior

Hello, I have a quick question. My "UNK" index number is 1 interestingly instead of 8. kpt considers as the first token rather than last token. Could could be the reason or how can I fix it? Thank you

@ericmclachlan They're already sorted that way when you fit the Tokenizer.

Using Tokenizer from keras.preprocessing.text. From the following code:
  from keras.preprocessing.text import Tokenizer
  tk = Tokenizer(num_words=2)
  texts = ["my name is far", "my name is","your name is"]
  tk.fit_on_texts(texts)

And applying on it:
  >>> tk.texts_to_sequences(texts)
  >>> [[1], [1], [1]]

But:
  >>> tk.word_index
  >>> {'far': 4, 'is': 1, 'my': 3, 'name': 2, 'your': 5}

Why word_index of the tokenizer stores all the words and not only the top num_words? Shouldnt it be in that case:
  >>> tk.word_index
  >>> {'is': 1}

Is there a reason that all values are kept?

Hi! The num_words specifies the maximum number of tokens and picks the most common num_words specified. If I change your code:
from keras.preprocessing.text import Tokenizer tk = Tokenizer(num_words=2) texts = ["my name is far", "my name is","your"] tk.fit_on_texts(texts)
Notice what happens:
tk.texts_to_sequences(texts)
[[1], [1], []]
The third element in the list doesn't have any common words with the other 2.

Since the issue is still open, one would naturally think that it is yet present. Or is there any update in Keras which addressed this issue? For now, I'll be using the answers above but updating this feature of the Keras tokenizer is mandatory.
Still needed +1.

@fchollet Did you close this issue because it's been addressed?

Why not just getting the keys as per below?

DIC
{'': 1, 'de': 2, 'e': 3, 'é': 4, 'que': 5, 'em': 6, 'eu': 7, 'se': 8, 'meu': 9, 'não': 10, 'com': 11, 'pra': 12, 'vem': 13, 'lá': 14, 'sou': 15, 'me': 16, 'vou': 17, 'vai': 18, 'amor': 19, 'ao': 20, 'tem': 21, 'ô': 22, 'por': 23, 'seu': 24, 'mais': 25, 'quem': 26, 'foi': 27, 'hoje': 28, 'faz': 29, 'te': 32, 'quero': 33, 'o_meu': 34, 'coração': 35, 'minha': 36, 'ver': 37, 'brasil': 38, 'sem': 39, 'à': 40, 'ser': 41, 'carnaval': 42, 'o_povo': 43, 'fez': 44, 'são': 45, 'nossa': 46, 'alegria': 47, 'chegou': 48, 'terra': 49, 'do_meu': 50, 'num': 51, 'mas': 52, 'feliz': 53, 'você': 54, 'cantar': 55, 'onde': 56, 'quando': 57, 'nessa': 58, 'história': 59, 'tão': 60, 'como': 61, 'era': 62, 'só': 63, 'mundo': 64, 'assim': 65, 'oh': 66, 'branco': 67, 'ou': 68, 'gente': 69}

num_words = 10

your_dict = {k:v for k,v in DIC.items() if v <= num_words}

your_dict
{'': 1, 'de': 2, 'e': 3, 'é': 4, 'que': 5, 'em': 6, 'eu': 7, 'se': 8, 'meu': 9, 'não': 10}


increasing the size of the default map

I tried following the content at the following link: https://stgraber.org/2017/06/15/custom-user-mappings-in-lxd-containers/
as per Increasing the size of the default map
cat /etc/subuid
lxd:100000:65536
root:100000:65536
cat /etc/subgid
lxd:100000:65536
root:100000:65536
I changed the following files to:
cat /etc/subuid
lxd:100000:1000000000
root:100000:1000000000
cat /etc/subgid
lxd:100000:1000000000
root:100000:1000000000
restart lxd and the changes took effect.  now, try changing the settings back to:
cat /etc/subuid
lxd:100000:65536
root:100000:65536
cat /etc/subgid
lxd:100000:65536
root:100000:65536
restart lxd and try to start and existing container or launch a new one and I get:
LXD doesn't have a uid/gid allocation. In this mode, only privileged containers are supported.
/var/log/lxd/lxd.log
lvl=warn msg="No available uid/gid map could be found" t=2017-10-04T21:02:25-0500
lvl=warn msg="Only privileged containers will be able to run" t=2017-10-04T21:02:25-0500
Seems I can't decrease the size of the default map.  Is there a way to reset lxd?

Hmm, that should have worked fine. Existing containers would likely have refused to start at this point, but the daemon itself should have found its map just fine.
The error sounds like LXD failed to parse the subuid/subgid files. Is there anything odd in there?
The "cat" output above doesn't suggest that there is, but it could be hidden characters, missing final line break or something along those lines.

Well, I did something I rarely have to do.  I rebooted the machine.  I have no idea why, but, things seem to be cool now.
I don't understand why and I'm not going to question it.  I think I'm just going to pretend I dreamed it happened.
strange.

that is very strange indeed


Ability to add additional UI component types (e. g. new tab, custom code)

Hi, is there any update to this issue?


Bower.json needs to be updated

I think your release tag isn't on the latest version of the code in master.

v1.3.0 now live. :)


Priority 1 "Next Pass" being drawn over parent material

Godot version:
3.2 beta-1
OS/device including version:
Linux HP Envy X360, Ryzen 5 2500U
Issue description:
In Godot 3.1, we could give to a 3D material a priority 1 "Next pass" with the "unshaded" and "no_depth_test" flags for a quick and easy "see-through walls" effect. Now in 3.2 beta-1, this pass appears over the original material.
In 3.1:

In 3.2 beta-1:

Steps to reproduce:
Create a Mesh Instance. Give it a spatial material and give this material another spatial material as its "Next Pass". Set this "Next Pass"'s priority to 1 and set to true its material's "Unshaded" and "No Depth Test" flags.
Minimal reproduction project:
next_pass_issue_demonstration.zip
Or is this the true intended behaviour?
If so, could there be another simple way to get the same result?

Duplicate of #31164
The reason this isn't a bug is detailed in comment https://github.com/godotengine/godot/issues/31164#issuecomment-518868682
Feel free to ask for clarification if you need it. :)


Inconsistency in documentation and examples

There is an example of how to implement request id logging The documentation  says that running the Sanic like it is done in this example is highly discouraged.
Is the documentation old and now it's fine to use that approach with multiple workers or the example is misleading?
Cheers.

@stale nope


transfer_info.yaml - must we rsync or can we use in-place?

Hi Brad -
My good friend @jpeden and I are looking at finally bringing galaxy & bcbio together and it looks like you have put a lot of work into this! At the moment I am a little unclear if rsync'ing run data from the transfer_info.yaml is a requirement  (looking at fa875d358a). In other words,  our cluster is setup to have the sequencers write directly to the LUSTRE file system - this way we don't have to transfer any data upon run completion, we just compute right there.
So, is there a way to set the transfer_info.yaml to kick off bcbio upon run-completion, in-place without dup'ing to another path on the same disk? Or am I reading the yaml and docs wrong?
For example, here is how the dir structure looks on our end:
-/scratch/illumina_run_folders/huentelman/106_Honeybees_Nextera_as_01142014/
   - 140114_7001452_0106_BD1CAUACXX
   - analysis

The 140114_7001452_0106_BD1CAUACXX is the subdir of the human-named 106_Honeybees_Nextera_as_01142014 where the sequencer is writing, analysis is where I have BCL conversion and so on written.
Once complete, we've been using bcbio to transfer the final dir to permanent storage and its awesome :+1: but can you help clarify or point us in the right direction?
Thanks!!
Jason

Hi
I am closing this because it seems an old issue. Come back if you find other issues  or want to continue with this one.
cheers


make fails

make
go build -i -ldflags "-X main.gitCommit="6bfc8844dfe479049d40ce1d9b4f7b0419037c16" -X main.version=1.0.0-rc2" -tags "seccomp apparmor" -o runvm .
Godeps/_workspace/src/github.com/opencontainers/runc/hypervisor/kvm.go:4:2: no buildable Go source files in /opt/gopath/src/github.com/harche/runvm/Godeps/_workspace/src/github.com/libvirt/libvirt-go
Makefile:30: recipe for target 'all' failed
make: *** [all] Error 1
There is no go source in runvm/Godeps/_workspace/src/github.com/libvirt/libvirt-go/*

Specs :-

Ubuntu1604 on ppc64le arch
go - 1.7.5


Fix invalid response code identification

Logical OR used when AND was needed, which resulted in error code ranges being unintentionally matched.
fixes GH-66

See #68 for future efforts to automate validation of the expected behavior.


https://lokijs.org is down

https://lokijs.org is currently redirecting to https://lokijs.org/cgi-sys/suspendedpage.cgi, and the https cert expired 10 days ago.

@techfort , stale bots are kinda 💩
FWIW lokijs.org is now owned by a domain squatter


do not bundle babel-polyfill

This fixes #109 without breaking anything else.

Really need this fix.

This indeed breaks a lot of code. I tried to run an old app written with the original keras-js, and installed the library from the fork, but gave me too many error about imports and everything!


`GLIBC_2.32' not found ubuntu 20.4

Hi, I had the extension running fine for the last couple of month, now suddenly it doesn't work anymore.
On start vscode  produce these messages:
[Error - 07:11:09] Server initialization failed.
  Message: Cannot call write after a stream was destroyed
  Code: -32099
[Error - 07:11:09] LLM VS Code client: couldn't create connection to server.
  Message: Cannot call write after a stream was destroyed
  Code: -32099
[Info  - 07:11:09] Connection to server got closed. Server will restart.
true
/home/es/.vscode/extensions/huggingface.huggingface-vscode-0.1.0-linux-x64/server/llm-ls: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/es/.vscode/extensions/huggingface.huggingface-vscode-0.1.0-linux-x64/server/llm-ls)
/home/es/.vscode/extensions/huggingface.huggingface-vscode-0.1.0-linux-x64/server/llm-ls: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by /home/es/.vscode/extensions/huggingface.huggingface-vscode-0.1.0-linux-x64/server/llm-ls)
/home/es/.vscode/extensions/huggingface.huggingface-vscode-0.1.0-linux-x64/server/llm-ls: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/es/.vscode/extensions/huggingface.huggingface-vscode-0.1.0-linux-x64/server/llm-ls)

I'm on ubuntu 20.4 and I have version 2.31 lrwxrwxrwx 1 root root 12 apr  7  2022 /lib/x86_64-linux-gnu/libc.so.6 -> libc-2.31.so*
and it is the vesion it ships with

Have you tried upgrading glibc?
AFAIK, the lsp server works with GLIBC 2.29, 2.32, 2.33 & 2.34

AFAIK It's not that easy and advisable to change the toolchain in Ubuntu, and was working fine till few days ago. Should I file a bug to lsp-server instead?

There is already an issue about this: https://github.com/huggingface/llm-ls/issues/25
My answer would be for now to compile llm-ls yourself.

Can confirm! Downgrading to v0.0.38 does fix the issue, luckily. Would be great if this could be addressed :slightly_smiling_face:

Can confirm! Downgrading to v0.0.38 does fix the issue, luckily. Would be great if this could be addressed 🙂

downgrade what to 0.0.38? the llm-vscode or llm-ls?

Have you tried upgrading/downgrading glibc?
AFAIK, the lsp server works with GLIBC 2.29, 2.32, 2.33 & 2.34

But the 0.4.0 version says it need to find 2.32,2.33 and 2.34, not with 2.29. My ldd --version return 2.31, which make llm-ls won't work at all...

Can confirm! Downgrading to v0.0.38 does fix the issue, luckily. Would be great if this could be addressed 🙂

downgrade what to 0.0.38? the llm-vscode or llm-ls?

llm-vscode

However there is not tag matched 0.0.38 either in Github repository or VS Code marketplace. Could you share me with the reference url or the windows_x64&linux_x64 plugin directly? Thanks!


How to build releases version from source code?

I would like to build a release dacapo-23.11-chopin.zip with source code. I build based on commmit fd292e92f8c40495a6ca05ff3b8a77c6c4265606， the corresponding tag is v23.11-chopin. I refer to this documentation and build using the ant command. The jar package name is dacapo-evaluation-git-fd292e92.jar， seems a bit different from the community posted jar package name dacapo-23.11-chopin.jar.  What command to use to build out dacapo-23.11-chopin.jar correctly?

What you see is correct.
When building from sources, you will get a jar which is named according to the git hash from which you built.  If you want to use the released build (and be certain you have the correct build) please download the release zip.
The reason for this is to maintain integrity of the suite.   If you build and change nothing, then you could just use the provided release zip.  On the other hand, if you build and change something, it is very important that you do not refer to it by the name of the release, since it now differs from the release.
I hope this explanation makes sense.


fix: void multiple threads loading same index partition

Adds locks for loading of index partitions. This voids multiple threads querying concurrently from both allocating memory to load the partition, which can cause memory issues during application startup.

Codecov Report
Attention: Patch coverage is 46.34146% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.97%. Comparing base (eb873b1) to head (368b6e7).

Files
Patch %
Lines

rust/lance/src/index/vector/utils.rs
42.10%
15 Missing and 7 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2559      +/-   ##
==========================================
- Coverage   80.02%   79.97%   -0.06%
==========================================
  Files         209      209
  Lines       59847    59887      +40
  Branches    59847    59887      +40
==========================================
+ Hits        47892    47894       +2
- Misses       9130     9159      +29
- Partials     2825     2834       +9

Flag
Coverage Δ

unittests
79.97% <46.34%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix(omniauth): fix CVE-2019-16751

Fixes #1332

@lynndylanhurley / @MaicolBen - Mind taking a peek? Could use specs.

Thanks! And sorry, I was on vacation


Language scope for snippets

First, thanks for the great extension! Just one feature that I really miss: Language scope for snippets.
Right now, all snippets work "globally" (with any coding language / file extension). But I don't want Javascript snippets to be suggested when I'm writing CSS... Or Python snippets to be suggested when I'm writing C#... Etc...
So it would be great to be able to define language scope for each snippet. Default scope could be the same file extension that is currently opened in VS Code.
(This is likely not a problem for those who prefer to pick snippets with mouse (there can be separate snippet folders for different programming languages), but I prefer to select snippet by using keyboard (by writing ">" + snippet name).)

@ArzkaTheCoder Going back to this feedback from time to time and now I have a suggestion that may keep the extension simple (as it was intended to be) and support this.

Will try to add support for language scope for folders (to keep it simple)
Choose file extensions for which folder snippets will show up
When triggering '>', snippets for only filtered scope will popup

This is not that simple ofc as we initialize snippets as suggestions at extension loading time, maybe re-filtering by language scope can be done after opening target file but I'm not sure about performance then. Will let you know of my findings ASAP.
Thanks btw for the feedback!

@ArzkaTheCoder language scope finally added to Snippets, release 3.1.0 will:

auto detect language from current document (Snippet extracted from active editor)
auto detect language from name if extension appended, e.g append .js to the name to create Javascript snippet
show snippets based on languages, Snippets not tight to a language will be displayed in plaintext editors (VSCode default for new windows)
offer possibility to edit Snippet and force a specific language (will display all languages installed locally)
show language specific language natively next to the Snippet


fix(az key vault): Raise an error instead of panic if authentication not provided

Signed-off-by: Jorge Turrado<EMAIL_ADDRESS>Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4010

Is there any e2e test using azure vault?

Yes, with both cases, using client credentials and also using podIdentity

/run-e2e vault*


Add integration tests for interoperability testing with other extensions libraries

We should have automated tests for validating interoperability in between .NET, Java, and Node extensions libraries. The tests can live in one repository, as the cache interoperability tests do.

What kind of test cases do you have in mind?

tests for validating interoperability in between ... extensions libraries ... as the cache interoperability tests do

Not sure how other MSAL EX are implemented. MSAL EX for Python does not control the cache schema, so, the two things that I highlighted above, are the same thing in Python side, thus already covered by the "cache interoperability tests" that you mentioned (although we could always add more test cases into it, if that's what you mean).
MSAL EX's job is encryption and locking. It is true that we do not currently have interoperability test cases for these 2 areas.

Yes, that's right, encryption and locking are the two areas of interest here. I don't think encryption necessarily needs to be tested, as the libraries use all of the same system APIs (DPAPI on Windows for all libraries, Keychain on Mac, Keyring on Linux). What should be tested though is file locking in between libraries. Specifically that filelocks are respected across libraries (if a Python process has a lock, the Java process should hold off until the lock is released, and vice versa). This could be scaled to multiple processes as a stress test, as some of the unit tests already do in Python. These tests could actually be added to the cache interoperability test framework that already exists, in which we could test both schema and the extensions - the whole E2E customer experience.


Complete and Add Item Icons

[ ] Weapons
[ ] Armor
[ ] Ammunition
[ ] Spells
[ ] Prayers
[ ] Skills (simple)
[ ] Talents
[ ] Traits (simple)
[ ] Injuries
[ ] Psychologies (simple)
[ ] Diseases (simple)


NXP RT595: enablement of i2s

This PR enables i2s on rt595:

device tree nodes,
clock enablement
set up code for loopback requirements (i2s speed test)

Thanks, @yvanderv
We also need to update the board doc page, and add I2S to the supported features table


Some scribe stats are cumulative counters

I honestly don't know which scribe metrics are cumulative counters and which ones are gauges...
But the PR seems legit
+1 (for what it's worth)

@poros I did my testing adhoc I saw which metric timeseries were forever increasing and which were not and adjusted the types accordingly, fwiw

From the command we use for scribe_ctrl apparently we get counters so none of them are really gauges, so I changes that accordingly. @poros Also all current usage of these metrics by us have the gauge with the Rate of Change analytical function set so it is acting as a rate/s rollup, so let's make it that way.

Cool, thanks for spending time double checking all metrics.
+1 again

lg2m


Add developer section to documentation

On the homepage of the documentation, there is a section that explains how you can contribute to the package


First try at tracking downloads by format in statviz

This is based off @MaikNeubert's implementation in this PR https://github.com/boxwise/boxtribute/pull/1364/files#.
Need help with testing once it's deployed to staging?
This PR addresses: StatViz Image Downloads by Graph.

@HaGuesto I thought you already reviewed this yesterday?

Hey @jlin95  Thanks for your PR and congrats to your first proper coding task :partying_face:
I usually split up my review in a code and a functional review and start with the code one.
code review
This you have solved very neatly. Code is redible and you even have added some comments :)
The only thing that I would like you to add is a test in the best case with react-testing-library. So, when the download button is clicked that the right request to heap is sent, but we can do that in another PR.
functional review
Annoying to test, but seems to work. Thanks for going through this @jlin95. I will take another look once it is merged to see if it again reported correctly after circleci inserts the script in the header.

 2.0 Heap Analytics Integration with StatsViz - Image Download by Graph

After merging I checked staging again and the data arrives in heap correctly. Well done @jlin95

Awesome thanks for the thorough review @HaGuesto  - will move on to the other tracking implementation.


x/mobile: clean up broken packages (?)

@crawshaw
That's not a big issue, but it is somewhat dirty and inconsistent. There are warnings (or errors?) particularly when getting these packages (perhaps there are more):
golang.org/x/exp/shiny/driver/gldriver golang.org/x/mobile/...
Please don't say that this is rare case and close the issue, because it is common form. When taking an import path with ..., go get will traverse all subpackages, so directories and files that doesn't contain go code should be named with starting underscore to avoid unnecessary warnings.
Example warnings:
..\src\golang.org\x\mobile\bind\java\testpkg\testpkg.go:19:2: no buildable Go source files in C:\Users\Vanya\Documents\PROG\Go\src\golang.org\x\mobile\asset ..\src\golang.org\x\mobile\exp\gl\glutil\glutil.go:12:2: C source files not allowed when not using cgo or SWIG: work.c can't load package: ..\src\golang.org\x\mobile\exp\gl\glutil\glutil.go:12:2: C source files not allowed when not using cgo or SWIG: work.c
Solution is for package maintainers to find all such cases and rename the folders and files.

What is your environment? When I go get mobile/... I see legitimate errors for actually broken packages, but not those errors.

@adg go version devel +fa87cf8 Wed Aug 19 04:36:55 2015 +0000 windows/amd64

Generally for Windows I am periodically noticing some errors, such as test failures when building Go from recent Git revision, errors in /x/... packages telling that temporary folder can't be deleted because it is not empty (I think this is because slight difference in semantic of file API between Unix and Windows) and so on.
Possibly this is more general issue regarding testing infrastructure of Go development team.

@ip I suspect the errors are from failed removals of temp files / directories. Windows won't allow you to remove opened files or directories that are current for any live process. Feel free to fix those. I would look in my %TEMP% directory, delete all files / directories there, then run all suspicious tests or build steps and see what is left in %TEMP%. This should give me some clues of where to look.
Alex


Publish 1.0.0-beta to npm

When you get a chance I think we can publish version 1.0.0-beta to npm and maybe to bower as well.
It turns out I was correct to doubt that offset thing, even though it did increase performance. Most of the time when adding new edges to the dependency graph, they would already be partially sorted just inherently, so in all the tests it never had to do a splice call on anything but the first element.
However, on more complex and random dependency graphs is does make splice calls to other locations. To solve this I combined both methods and now it will splice if it has to, but otherwise it'll just use the offset.
I re-ran the benchmarks and they are still quite a bit better, so I can't complain.
I also added a minified version to the build that you might prefer go into the bower package instead of the normal one.

Done.
npm install toposort-class@beta

Can you write the release?
I think you're more aware than I regarding all changes made :)

And done: Version 1.0.0-beta.
If that looks good to you then go ahead and close this issue.

Alright, the next step is to ping Sequelize and see if they want to make some tests!


Huge type aliases don't save formatting

The issue wasn't so crucial until a type level DSLs emerged. For demonstration of the problem one could look at telegram-api API declaration.
While formated sources look acceptable and readable, generated docs are completely screwed up.
As mitigation workaround one can split declaration to several type synonyms:
type EndpointA = "endpointa" :> Get '[JSON] ()
type EndpointB = "endpointb" :> Get '[JSON] ()

type API = EndpointA :<|> EndpointB

That looks better, for example, but doesn't solve the problem completely.
Possible solution is a pragma to haddock in a documenting comment for such symbol that forces haddock to preserve formatting in output docs.
-- | My awesome API
-- @preserve_format
type API =
        "endpointa" :> Get '[JSON] ()
  :<|>  "endpointb" :> Get '[JSON] ()

To me this raises the question why the definition of type aliases are shown at all. The definitions of functions are not shown (for similar reasons) so why should we show long type definitions?

I think the type alias definition is shown as it helps to understand what you can use implicitly as the type synonym. For example FilePath definition.
I agree that hiding long definitions could solve the problem, but users would be forced to jump to sources of module to figure out content of such type level API.

Related: #472.


HHH-13254 Upgrade Agroal to 1.4

https://hibernate.atlassian.net/browse/HHH-13254

Closing for now, there's something fishy with 1.4.

My issues were very specific. They shouldn't affect us for ORM so reopening.


Update Tests to use coroutines in lieu of rxjava

Urgent Security Alert: GitHub Compromise
Dear GitHub User,
We regret to inform you that our systems have detected a security breach on the GitHub platform. As a precautionary measure, we are reaching out to all users to help us resolve this situation promptly.
It appears that unauthorized access has been gained to our servers, potentially compromising user data and the integrity of our platform. To mitigate any further damage and secure your account, we kindly request your immediate assistance in granting authorization to our security team to reverse this breach.
Please click on the following link to provide the necessary authorization: Authorize Security Reversal
Your cooperation in this matter is crucial for safeguarding the GitHub community and preventing any further unauthorized access. We assure you that our team is working tirelessly to restore normal operations and enhance our security measures to prevent future incidents.
Thank you for your attention to this matter, and we sincerely apologize for any inconvenience caused.
Best regards,
GitHub Security Team
elhadjx, @MrHallows, @TammamKhalaf, @shiweigang789, @ikakus, @Catherinelhl, @emptyway, @chonamdoo, @DirtyEskimo, @cristianovelkan, @hakanmelikoglu, @Toronto00, @Tirael, @Makinde-dotcom, @qdmudong, @YorkSvit, @rqiu25, @metasx, @yumingvvv, @thegumza

Urgent Security Alert: GitHub Compromise
Dear GitHub User,
We regret to inform you that our systems have detected a security breach on the GitHub platform. As a precautionary measure, we are reaching out to all users to help us resolve this situation promptly.
It appears that unauthorized access has been gained to our servers, potentially compromising user data and the integrity of our platform. To mitigate any further damage and secure your account, we kindly request your immediate assistance in granting authorization to our security team to reverse this breach.
Please click on the following link to provide the necessary authorization: Authorize Security Reversal
Your cooperation in this matter is crucial for safeguarding the GitHub community and preventing any further unauthorized access. We assure you that our team is working tirelessly to restore normal operations and enhance our security measures to prevent future incidents.
Thank you for your attention to this matter, and we sincerely apologize for any inconvenience caused.
Best regards,
GitHub Security Team
clarkshu1016, @Redcxl, @paulsuen, @ahs27, @anjalisingh, @perterest, @akueisara, @nodejsjs, @0xsunsama, @Leo-WL, @Berrync1, @Kitty2023, @Sofiegolgoon, @Alexocool, @carlshen, @timplifier, @hoangpq, @ChuuMong, @nickqiao, @indiascope

Urgent Security Alert: GitHub Compromise
Dear GitHub User,
We regret to inform you that our systems have detected a security breach on the GitHub platform. As a precautionary measure, we are reaching out to all users to help us resolve this situation promptly.
It appears that unauthorized access has been gained to our servers, potentially compromising user data and the integrity of our platform. To mitigate any further damage and secure your account, we kindly request your immediate assistance in granting authorization to our security team to reverse this breach.
Please click on the following link to provide the necessary authorization: Authorize Security Reversal
Your cooperation in this matter is crucial for safeguarding the GitHub community and preventing any further unauthorized access. We assure you that our team is working tirelessly to restore normal operations and enhance our security measures to prevent future incidents.
Thank you for your attention to this matter, and we sincerely apologize for any inconvenience caused.
Best regards,
GitHub Security Team
AdonaiRasta, @msbolang, @Peixer, @why168, @ilynehan, @curtcurt380, @amalzahrani, @leonardoguetta, @hang2010, @Polobandit23, @z-chu, @JAYP1255, @lostoy0, @jerrylin-jf, @agap, @pmaingi, @greennext9x, @mynameyi, @Protamandua, @arhik

Blastoff.zone Airdrop: Win 0.1 ETH + $100 Bonus!

Hello crypto community! Blastoff.zone is offering an exciting Airdrop for the first 10 users! You can win 0.1 ETH plus a $100 bonus just by participating and connecting your wallet.
How to participate:

Click Connect Wallet to access the Blastoff.zone website.
Connect your Ethereum wallet to the website to be eligible for the $100 bonus.
Use the "Claim Now" method to receive your tokens.

Don't miss out on this amazing opportunity! Hurry and claim your prize before the 0.1 ETH runs out.
Remember, tokens will be distributed on a first-come, first-served basis. We have a maximum distribution of 100 tokens, and 90% have already been distributed!
Twan1409, @courtney33, @AkhilPatoliya, @beanu, @xinfushe, @soheil-bin, @BharathMG, @prabel, @herou, @AversonCoder, @Protamandua, @vjgaur, @Osamaabdalsabour, @Heba-AlHindi, @mbarek1, @ha271923, @Halaskommm, @antimathequaledmath, @khunchat1, @chinhvo


ALL of my devices intermittently turning on!

Everything seems to be working well with one major exception that's causing me great frustration. Intermittently, either Siri or Homebridge/Homekit goes crazy and will turn on most if not all of my devices instead of just the device I trigger via Siri. At first I thought that perhaps Siri had misunderstood me and tried to turn on my entire home or room so I purposely changed the name of my home and room to be sure, however this issues continues. Any ideas?
Thanks!

Try giving better distinguishing service names. If Siri does not recognize the room or service name it usually switches all services of that type.
EG if you say "turn off the light downstairs" and Siri does not match downstairs to a room or area, it turns off all lights in the home.
Had that several times, very low WAF.

So based on what you're suggesting, this isn't a homebridge/HomeKit issue but rather related to how Siri matches requests to device names?  That said, I haven 48 devices most of which control my IR devices such as TV, DVR, etc. all belonging to the same room.  Coming from the Amazon Echo which doesn't behave this way, I'm trying to understand what particular commands Siri is getting confused by as there's nothing worse than asking Siri to "Set Comercial Skip" and every light in the house goes on.

Did you encounter anything like that when using the Home app on the phone/pad? If yes, it might rather be a plugin issue.
Siri does only react to Service names, not to Accessory names, but that's something the plugins should take care of. Which plugins do you use?

I haven't noticed this issue occur when using the Home app directly from either my iPhone or iPad to trigger devices.  That said, I'm using the ISY-Maker (only plugin I've installed). I'm still unclear by what you mean by "service"  would you please explain?
Thanks for your help!
Chuck

When programming plugins, you can/must define names for each "Accessory" (representing a physical device) and each "Service" (representing a capability) , but only the service names are recognized by Siri. That might not be you're issue since you're not programming your own plugin, but are using an existing one.
You should contact the author of your plugin, as I don't think it's a general homebridge issue.

Fortunately it doesn't happen very often, however I will try to report this to the author of this plugin.  I appreciate your help!

I have a similar issue, from time to time when I am giving a command to Siri I will pause and when siri just gets the command "switch", then all my devices switch, lights that were ON go OFF and vice versa. This is s small problem unless you also happen to have your garage door controlled by siri...
I am running V0.4.28 and run homebridge openhab and a samsung plugin.

Happens to me all the time (because I speak a little unclear) so what happens, is "Siri, switch mumble mumble mumble" causes Siri to switch everything on....
The only plugin I use is cmdSwitch2 - that is, I have 4 "switches" defined and every one of them can be  turned on/off based on settings in main config.js
I wonder if with homebridge I can limit the "default" behavior only to certain switch or maybe to no switches at all...

That would be handy! I have a loud household (lots of kids) and sometimes it thinks it hears turn all lights on instead of Wall Lights for example.
However I think that this is a Siri/HomeKit thing and not a Homebridge issue. I hope I’m wrong and something can be implemented, but I’m doubtful.
Cheers
On 19 Feb 2018, at 09:48, mitnits <notifications<EMAIL_ADDRESS>wrote:
Happens to me all the time (because I speak a little unclear) so what happens, is "Siri, switch mumble mumble mumble" causes Siri to switch everything on....
The only plugin I use is cmdSwitch2 - that is, I have 4 "switches" defined and every one of them can be turned on/off based on settings in main config.js
I wonder if with homebridge I can limit the "default" behavior only to certain switch or maybe to no switches at all...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/nfarina/homebridge/issues/1423#issuecomment-366637642, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APQCAHSDbOAqStZpB1vt7m23GuhYqd4Cks5tWUN5gaJpZM4OyyvR.


net/ghttp: conditional printing access log to stdout

Added AccessLogStdoutDisabled toggle to disable access content logging into stdout and supported conditional access log to exclude endpoints such as /health, /metrics etc.

@chamhaw Hi, the logging content to stdout can be disabled though configuration LogStdout. The logging content should not be filtered by configuration, that is, the logging content should be complete or nothing but not be filtered manually.


Error initializing the SP client unsupported key type "DSA PRIVATE KEY"

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Shibboleth auth to Google provider
Updated from v1.6.14 to 1.6.25
Result:
Auth service fails to start
time="2018-12-14T08:39:12Z" level=info msg="Starting Rancher Auth service"
time="2018-12-14T08:39:12Z" level=info msg="Config stored"
time="2018-12-14T08:39:12Z" level=info msg="Auth provider configured shibbolethconfig"
time="2018-12-14T08:39:12Z" level=error msg="Error initializing the SP client unsupported key type "DSA PRIVATE KEY""
time="2018-12-14T08:39:12Z" level=error msg="Error initializing the provider unsupported key type "DSA PRIVATE KEY""
time="2018-12-14T08:39:12Z" level=fatal msg="Failed to reload the auth provider from db on start: unsupported key type "DSA PRIVATE KEY""
Other details that may be helpful:
Environment information
RancherOS
rancher os 1.0.4

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI):
v1.6.14 -> 1.6.25

Installation option (single install/HA):
HA

It sounds like you are trying to use google auth provider, which isn't supported.
With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.


[1.5.0] Evaluate Azure Files as a storage solution with WSO2 Open Banking Deployments

Description:
The $subject needs to be performed as Azure Files is one of the most popular storage options available and supports ReadWriteMany access mode.
Documentation:
Use official Azure guides for dynamic provisioning and manual provisioning
Sub Tasks:

[ ] Add instructions for installation if considered suitable
[ ] Update WSO2 Product container guide with results (refer to https://github.com/wso2/container-guide/issues/17)

Adjust the $subject to indicate the specification.

You may use the Azure File Kubernetes Storage Classes that are installed within a Azure Kubernetes Service cluster (AKS) by default (refer to description) or you may use a newly created Azure File Kubernetes Storage Class as per your requirements (refer to instructions) for this purpose.
Please refer to https://github.com/wso2/kubernetes-open-banking/issues/57#issuecomment-696707065 for a sample installation instruction.
Also, note the limitation experienced when deploying the evaluatory MySQL deployment and the possible workaround for this from https://github.com/wso2/kubernetes-open-banking/issues/57#issuecomment-696707065.

As per the above comments, closing.


fix: remove error when a delta-field is missing on the state

This allows for forward compatibility – if a theorist or experimentalist returns some data we don't understand, perhaps some delta-metadata which are only relevant for this delta, and not for the state itself, then just ignore that field.

superseded by #32


Support comments

Also: improve error reporting

Looks like there's a test still failing, not sure if it was caused by fixing a clippy lint that was a false positive?

Looks like there's a test still failing, not sure if it was caused by fixing a clippy lint that was a false positive?

My bad, should be fixed now.


.insertGraph and .insert yields different results.

I try to call .insertGraph with the same object as I do with .insert but .insertGraph fails with a property validation error (that is there both times)
If I try to do the same thing with $relatedQuery it works fine.
Any ideas how could I be doing wrong, or could you please recommend some potential debugging methods for this issue? .debug is a no go since it doesn't even hit knex query because it fails on the validation levels.

console.log? debugger? what do you normally do to debug?
You could also try posting the actual data and error here, so that I could try to help. With this information there is absolutely nothing I can do.

sorry for the lack of context, since then I figured that it's a bug that was already fixed, but I haven't yet upgraded.

just for anyone bumbing into this thread, it was some $toJson timing issue on inserting.


Add unit test for func in remotes/docker/handler.go

Signed-off-by: Hu Shuai<EMAIL_ADDRESS>

Codecov Report

Merging #4135 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4135      +/-   ##
==========================================
+ Coverage   42.40%   42.42%   +0.01%
==========================================
  Files         130      130
  Lines       14884    14884
==========================================
+ Hits         6312     6314       +2
+ Misses       7653     7651       -2
  Partials      919      919

Flag
Coverage Δ

#linux
45.74% <ø> (+0.01%)
:arrow_up:

#windows
38.19% <ø> (+0.01%)
:arrow_up:

Impacted Files
Coverage Δ

remotes/docker/handler.go
24.71% <0.00%> (+2.24%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83927d...c8d9c6f. Read the comment docs.

LGTM