Identity Provider not automatically chosen with signInWithWebUI & popup occurring with prefersPrivateSession enabled

Describe the bug
Issue #1
With AD Integration configured with Amplify, we would like our identityProvider, "Azure-IoT-T", to be automatically selected when the signInWithWebUI web UI is shown so that the user doesn't have to click the "Azure-IoT-T" button and proceed to their federated sign-in.
We have tried including the identityProvider within the AWSAuthWebUISignInOptions for the signInWithWebUI call, we've also tried using a custom Provider in the signInWithWebUI call (for: .custom("Azure-IoT-T")), as well as a combination of those two approaches.
Issue #2
We are intermittently getting the "App wants to use amazoncognito.com to sign in" popup alert when signing in or signing out. As far as I am aware, as long as we enable preferPrivateSession for our AWSAuthWebUISignInOptions, we should not receive these popups. Is that correct?
Steps To Reproduce
Steps to reproduce the behavior:
1. Create a AWSAuthWebUISignInOptions object with idpIdentifier set as "Azure-IoT-T" and preferPrivateSession set to true
2. Create a AuthWebUISignInRequest.Options object passing in the pluginOptions object from step 1
3. Call Amplify.Auth.signInWithWebUI(for: .custom("Azure-IoT-T", presentationAnchor: keyWindow, options: options) with the options object from step 2

Expected behavior
The web UI should display with the federated sign-in automatically to allow users to sign-in via their company credentials and no amazoncognito.com popup alerts should be displayed.
Actual Behaviour
Users have to tap the "Azure-IoT-T" button to get to the federated sign-in screen:

Popup is displayed even when preferPrivateSession is enabled:

Amplify Framework Version
1.12.0
Amplify Categories
Auth
Dependency manager
Cocoapods
Swift version
5.3
CLI version
6.2.1
Xcode version
12.5.1
Relevant log output
No response
Is this a regression?
No
Regression additional context
No response
Device
iPhone 12 Pro, iPad Pro 11" (2nd Gen)
iOS Version
iOS 14.5.1, iOS 15.0
Specific to simulators
Both simulators and devices
Additional context
No response

The popup will be shown for signIn, it will not be shown for signOut.  We do not have control over the popup, it is system provided by Apple.
Are you using the same key that you have given in the Cognito Userpool while providing the identity provider value? ie "Azure-IoT-T" should match the configuration you have on Cognito User Pool

@royjit Yes we are passing the same key. I've confirmed that.
Also please note the popup is no longer occurring for us, we have made sure all flows use the prefersPrivateSession flag and that part is working correctly.
The only outstanding issue now is the provider still not being automatically chosen.

@royjit Heard back from AWS support and resolved the issue. Here is how the sign in should be setup:
let pluginOptions = AWSAuthWebUISignInOptions(preferPrivateSession: true)
let options = AuthWebUISignInRequest.Options(pluginOptions: pluginOptions)

Amplify.Auth.signInWithWebUI(for: .custom("Azure-IoT-T"), presentationAnchor: keyWindow, options: options)

We had been including idpIdentifier in the AWSAuthWebUISignInOptions object, which was causing the issue. Removing idpIdentifier and including the "for: .custom("Azure-IoT-T")" parameter in the signInWithWebUI() call resolved our issue.
Thanks for the help!

I'm using Android, exactly facing the same issue. I don't find the way to pass custom provider in signInWithWebUI

Do we have preferPrivateSession for Android SDK?


get the latest version

Hi author, I noticed that the latest version has reached v2.2.4, but when I go get it, I only get v1.5.3, is there any way to use the latest code

Hello @lsy88 ,
Yes, that's due to how Golang manages versions (see https://github.com/mandolyte/mdtopdf/issues/45).
However, you have pre-built binaries under https://github.com/mandolyte/mdtopdf/releases for every release and of course, you can also download/clone the code from the 2.2.4 tag and build it yourself if you wish.


rest_gophkeeper.go:25: Implement authentication.

The puzzle 28-7201508d from #28 has to be resolved:
https://github.com/kerelape/gophkeeper/blob/88fa409db64b050c99a6b28a22631ef20b7cbea0/pkg/gophkeeper/rest_gophkeeper.go#L25-L25
The puzzle was created by @kerelape on 01-Sep-23.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 28-7201508d has disappeared from the source code, that's why I closed this issue.


Include webpack manual in readme.md

In case of webpack user should:
Add following lines into webpack.config.vendor.js
module.exports = ({ prod } = {}) => {
    const isDevBuild = !prod;
    return [{
...
    entry: {
        vendor: {
....
            'quill',
            'quill/dist/quill.snow.css',
            'aurelia-quill-plugin/dist/amd/'
        }
    },
...
    }]
...
};

register plugin
aurelia.use.plugin('aurelia-quill-plugin');

But user user shouldn't import quill.snow.css he/she have to only use quill-editor tag.

will do thanks.

@szogun1987 I just tried with aurelia-cli (webpack) all you have to do is:
// this is how the new webpack plugin works unless you're using the old version i guess
aurelia.use.plugin(PLATFORM.moduleName('aurelia-quill-plugin'));

and import the css:
import 'quill/dist/quill.snow.css';

or
<require from="quill/dist/quill.snow.css"></require>

the user have to load the css because there's two themes and he has to choose which one to use.
please let me know if I'm missing something.
thanks.

If I add
 <require from="quill/dist/quill.snow.css"></require> to my code I receive this error probably css cannot be loaded both via vendor.config and require/import. I have choose first option.


Fix range of styling issues identified by precommit config

#98

@Matgrb I cannot find this bug :(. Somehow, a single value changed from 0 to 0.5. As far as I can see, I only changed docstrings and other styling issues. Can you have a look? You wrote the code, perhaps you know better where to look / where it could potentially change the shap value.

I think the issue was this line:
from sklearn.experimental import enable_iterative_imputer  # noqa

It did not have the #noqa at the end, so the pre-commit has removed this line. I suppose now the issue should be fixed.

Thnx Mateusz! Still don't know what the issue was but trust it's fine :)

It was a weird shap related issue.
initially this test was checking if the mean shap value was 0.5. Then with some updates, the value has suddenly changed to 0. Now it is back at 0.5.
I have decided to disregard the mean shap value for now, since it is the mean abs shap value that is the most important there.
In the future, we can replace the shap based unit tests with mocks to ensure full stability.


Fix errors when using with Jekyll 3

Base on some issues comments I modified the _config.yml and the index.html to get it up and running with latest Jekyll (v3.6.2).

Fixed in #238.


Found a bug where type {any} is needed

Describe the bug
Infer type check of {any} or {*} is needed. Sometimes you may want to allow all types to be passed as parameter.

Added to v0.0.6


[Feature] Enhancing for Advanced Deployment: Integrating Metrics, Webhooks, and Certification Support

Certainly, the monograph-operator has supported metrics, webhooks, certification, and issuer. The monograph-chart also should be able to deploy the services and resources that are required by these features.
Tasks:

[X] Separate each RBAC into different YAML templates to ensuer maintainability.
[X] Add metrics service YAML templates.
[X] Add certifiats and issuer YAML templates.
[X] Add webhook service, webhook configuration YAML templates.
[ ] Add Grafana dashboard configmaps YAML files.
[ ] Update deployment YAML templates.
[ ] Update values.yaml.
[ ] Ues helm.hook to manage the installation order of all resources.

The resources field naming convention

Common labels{{- define "monograph-operator.commonLabels" -}}
{{ template "monograph-operator.selectorLabels" }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
app.kubernetes.io/created-by: {{ include "monograph-operator.name" . }}
app.kubernetes.io/part-of: {{ include "monograph-operator.name" . }}
{{- if .Chart.AppVersion }}
app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
{{- end }}
helm.sh/chart: {{ include "monograph-operator.chart" . }}
{{- end }}

app.kubernetes.io/component
We use original label value of app.kubernetes.io/component generated by bin/kustomize to ensure the semantics of the label.
Service selector labels
Typically a K8s operator use the label value pair control-plan: controller-manager for serivce discovery. To prevent potential performance issue, we use {{ include "monograph-operator.name" }}-controller-manager.

Why we need Chart Hooks?
Helm provides a hook mechanism to allow chart developers to intervene at certain points in a release's life cycle. For example, you can use hooks to:

Load a ConfigMap or Secret during install before any other charts are loaded.
Execute a Job to back up a database before installing a new chart, and then execute a second job after the upgrade in order to restore data.
Run a Job before deleting a release to gracefully take a service out of rotation before removing it.

Reference
https://helm.sh/docs/topics/charts_hooks/
@pangzhenzhou

NOTE: When introducing webhooks for MonographDBCluster, the CRD yaml should be templated. I propose moving the crds/* to templates/.
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
  name: monographdbclusters.monograph-service.monographdb.com
  annotations:
    cert-manager.io/inject-ca-from: '{{ .Release.Namespace }}/{{ include "monograph-operator.name" . }}-serving-cert'
    controller-gen.kubebuilder.io/version: v0.11.1
  labels:
    {{- include "monograph-operator.commonLabels" . | nindent 4 }}
spec:
  conversion:
    strategy: Webhook
    webhook:
      clientConfig:
        service:
          name: '{{ include "monograph-operator.name" . }}-webhook-service'
          namespace: '{{ .Release.Namespace }}'
          path: /convert
      conversionReviewVersions:
      - v1
...


Notification enable toggle for each service is hard to see

Describe the bug
As shown in the screenshot below, when disabled, this toggle is very hard to see at it's small size.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
Due to my experiences with other software, I had assumed all notification sources would automatically be notified for all services, but that isn't the case and I spent a lot of time debugging why I wasn't receiving any notifications, when all I had to do was enable these toggles.
Info

Uptime Kuma Version: 1.5.3
Using Docker?: Yes
OS: Ubuntu 20.04
Browser: Firefox 92.0b9-1

Screenshots

Error Log
N/A
p.s. thx for this cool app

Yes, it will be enabled automatically after added for the next version.
https://github.com/louislam/uptime-kuma/projects/1#card-68179722

Yes, it will be enabled automatically after added for the next version.
https://github.com/louislam/uptime-kuma/projects/1#card-68179722

Isn't it technically already in #340, or what do you mean by "add in" and "auto enable"?

Sorry if this was unclear, but I'm just asking for color changes which would make this toggle easier to see. Perhaps a lighter shade of gray in the background of the button, or a red outline could do it.

Better in https://github.com/louislam/uptime-kuma/commit/7a4432de1e7834d2ccd33336d0b29568ac923c2b

Thanks!


Updated cover image for Now Playing Indicator

Updated the cover image for my plugin with the new look (1.2.1)

Thanks a lot!


Create output or artifacts to ease rerun / reproduction of tests

It is challenging to have an even approach to triage.  Sometimes not all the information required to rerun tests is passed upstream.
We can try to make this task easier for triagers, and those who will be working on upstream fixes, by creating output and/or artifacts that will help rerun the problem test, and (hopefully) enable reproduction of the test failure.

[ ] Part 1 is delivered through https://github.com/eclipse/openj9/pull/6895 and https://github.com/eclipse/openj9/pull/6978

[ ] Part 2 is adding Jenkins build parameter plugin

[ ] Part 3 is adding a 'rerun' script that can be fed the grinder rebuild URL, to reproduce failure from Jenkins builds locally

Considering this as closed (the demand for Part 3 is non-existent, so no plan to add it for now).


Detect if input string is RFC1918

If the input string is private network, then return some sort of answer(TBD) indicating so.
https://en.wikipedia.org/wiki/Private_network
Include private and link-local ips for both v4 and v6
Perhaps export and reuse islocalip from https://github.com/turbobytes/pulse/blob/e60f6c0a7bcab4575000e39050bea20ecae8064f/utils/misc.go#L15

I am thinking... we could move islocalip into geoipdb package, and have minion access it from here, but that would introduce cgo dependency for minion making cross-compilation complicated.

What do we use for asn and description if the source ip is private?
Initial suggestion
ASN: RFC1918 or AS0 ... AS0 is a good choice, but it has special meaning in other TurboBytes components, unrelated to Pulse.
ASN description: Private Network

An example of the issue can be seen at https://pulse.turbobytes.com/results/584916d3ecbe407b4f000005/
See result for 104-HEDII. It incorrectly identifies <IP_ADDRESS> and <IP_ADDRESS> as Local Network .
Another example: https://pulse.turbobytes.com/results/58494e98ecbe407b4f0001a5/
It tries to lookup asn for ns[1-2].google.com.
I propose following "pre-flight" checks :-

Detect if the input is a valid IP or not, by using net.ParseIP. If not then return appropriate error.
Check the IP against islocalip(), if so then return an error type, which caller can use to determine local network.
Check if the IP is v4 or v6. if v6 then return some sort of "not implemented" error until #9 is implemented.

Ideally, I would like the logic of islocalip() to live in one place.
Note: github.com/turbobytes/utils cannot have geoipdb as dependency because of cgo requirement.

We have been refining the options of good approaches for exporting islocalip() functionality. Sajal suggested the following additional approaches, both would serve:

Export IslocalIp() from pulse repository. Geoipdb would import and use it.
Move IslocalIp() to a sub package within geoipdb. This would allow minions to import it separately, avoiding cgo dependency.

In absence of stronger arguments, I'll go with the latter approach at it looks cleaner in the sense of dependency tracking.

@sajal is the possibility of tuning / disabling islocalip() detection on the fly an important requirement?
I see this is exercised in test code only, but haven't found any "real world" usage of it.

The reason I wanted a way to tune it is for testing purpose. In the future I intend to have a mock server running locally which would have a local IP. And I want a way to bypass this test.
You could simply continue using islocalip() in pulse code which calls iputils.IsLocalIp() . For testing I could mock/overwrite the local islocalip() function.

+1

Branch detect_private_network contains subpackage iputils that exports IsLocalIP() for telling if an IP address is local to a network. This is detected by the same original logic as islocalip() from pulse repository, with extended CIDR comparison tables.
Moreover, LookupAsn() provides new error codes that meet above requirements.


Documentation issue

I am working on getting this setup for our current notebook setup. In the readme to use rolls for ECS auth this is what is written
from jupters3 import FargateSpawnerECSRoleAuthentication
Should that be
from fargatespawner import FargateSpawnerECSRoleAuthentication
I can do a PR if so.
Thanks

Hi @JasonIamAUnixAdmin
Thanks for the report, and apologies for the delay in getting back to you. Yes, you're right in the that README is wrong here. A PR fixing this would be very much appreciated.
Thanks,
Michal

Fixed by https://github.com/uktrade/fargatespawner/pull/6


Only check required labels for alert state restore

Signed-off-by: Ben Ye<EMAIL_ADDRESS>
During the alert state restoration process, check the required labels and values match only.
Comparing the labels length makes sense in Prometheus, but it makes the downstream projects like Thanos harder to reuse this code. For example, Thanos now has a stateless Ruler mode which works below.

Write path: stateless ruler writes to Thanos Receiver
Read Path: stateless ruler queries Thanos Querier for rule evaluation, alert state restoration, etc.
In this case, the series written to the storage will have additional labels like tenant ID, Ruler labels, etc. So simply comparing the label length won't work. It makes more sense to ensure only required labels, not all labels exactly the same.

This code would cause false positives in Prometheus, as if there's extra labels such a series would no longer be ignored.

Which also incidentally means that this code would also be incorrect for Thanos for the same reason.

This code would cause false positives in Prometheus, as if there's extra labels such a series would no longer be ignored.

Hi Brian, thanks for the review. Can you please elaborate more about why extra labels won't work in Prometheus and Thanos? And ignored by what?
I think ALERTS_FOR_STATE are created by the alert evaluations and it doesn't have any other extra labels so in Prometheus's case checking required labels should be fine.

And ignored by what?

Ignored by this code.

I think ALERTS_FOR_STATE is created by the alert evaluations and it doesn't have any other extra labels so in Prometheus's case checking required labels should be fine.

There can be additional labels, and we need to filter any series that have them. Consider that there's an alert with labels {foo="bar"} which we want, you don't want to pick the series associated with an alert with labels {foo="bar", baz="bar"}.

It uses alertname as one of the labels to select the series so I think it will get series from that alert only? https://github.com/prometheus/prometheus/blob/main/rules/alerting.go#L244

Let's take an example.
{alertname="up",instance="foo"}
{alertname="up",instance="foo",cluster="/bar"}
Those alerts are different.

Let's take an example.
{alertname="up",instance="foo"}
{alertname="up",instance="foo",cluster="/bar"}
Those alerts are different.

Yeah I understand they are two series. But if we want to check if there is a state for {alertname="up", instance="foo"} in tsdb then the second series should also work because they are the same alert. The second alert just renders one more label.
Or you want to mean those two series are from two different rule groups, but with the same name?

They could even be from the same rule group.
If you have two targets {instance="localhost",job="blackbox_exporter"} and
{instance="localhost",job="blackbox_exporter",target="example.com"}
And your alert is up == 0, you will have the case where two alerts do not
have the same number of labels but all labels of one will be present in the
other.
Le dim. 13 mars 2022, 12:02, Ben Ye @.***> a écrit :

Let's take an example.
{alertname="up",instance="foo"}
{alertname="up",instance="foo",cluster="/bar"}
Those alerts are different.
Yeah I understand they are two series. But if we want to check if there is
a state for {alertname="up", instance="foo"} in tsdb then the second series
should also work because they are the same alert. The second alert just
renders one more label.
Or you want to mean those two series are from two different rule groups,
but with the same name?
—
Reply to this email directly, view it on GitHub
https://github.com/prometheus/prometheus/pull/10443#issuecomment-1066076966,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACHHJWW7BM5RU2UXF64UITU7XKO5ANCNFSM5QSSXMBA
.
You are receiving this because you commented.Message ID:
@.***>

Thanks.These examples make sense to me. Then do you have any idea how we can support this alert restoration scenario?

We could make the compare function a parameter of the scrape manager?

Thanks @roidelapluie. Now I have implemented it on the Thanos side https://github.com/thanos-io/thanos/pull/5230/files#diff-5d0a744c9d7c6fe1fc5d92f998d637cb281f528852d96e1c156bccccc8e68aa5R105. Either way, users need to specify some labels to ignore from the ALERTS_FOR_STATE query result to do the comparison so that's the same.
I think it is good now.


flutter create . doesn't work

I tried running flutter create . in the directories 01_looping_animation, 02_start_stop_animation etc but i keep getting the error "01_looping_animation" is not a valid Dart package name. etc
Flutter 1.22.5 • channel stable • https://github.com/flutter/flutter.git
Framework • revision<PHONE_NUMBER> (7 days ago) • 2020-12-10 11:54:40 -0800
Engine • revision ae90085a84
Tools • Dart 2.10.4

I was trying to be too clever with my project folder names. Dart doesn't like packages that begin with a digit.
I'm going to rename these now to use F_XX_example_name; that should make Dart happy and flutter create . work.


this is my first issue( do not merge)

Issue/Feature Description:
Why this issue to fixed / feature is needed(give scenarios or use cases):
How to reproduce, in case of a bug:
Other Notes /  Environment Information: (Please give the env information, log link or any useful information for this issue)

#SODACODE-Issue-Rejected
(duplicate)


RC1 derivatives - Update documentation

In particular https://github.com/poldracklab/fmriprep/blob/8f734520370c26a82d46935f6f88c8e2e1040cae/docs/outputs.rst#L49-L93

Maybe it would be legitimate to just link to the RC1 google docs?

I agree that we should link to the RC1 google doc, but that is much broader than fMRIPrep, so I think it's still valuable to clarify what derivatives we actually generate.
Perhaps we could generate the outputs automatically, and then link to the spec for descriptions? (That might be a bit much for one-time changes, but in case there are new outputs or further spec changes, it could be worth it.)


imported types remain in compiled code after enabling this plugin

I use this plugin to rename CSS imports with this config:
{ "transform": "ts-rename-import-plugin", "type": "config", "from": "/index.css$", "to": "/index.bundle.css" }

I import some types in my TS file.
import { SomeType } from "./types.ts";

With this plugin the import/require is not removed anymore from the compiled file, though the access of the type name is gone.
const types = require("./types.ts");

What if you would check, that the transform actually changes the import, before altering the node.
https://github.com/banyudu/ts-rename-import-plugin/blob/f713b0257104da207175dbe2c0c6854e10c6fee0/src/index.ts#L35-L45

I think I found the real issue.
https://github.com/microsoft/TypeScript/issues/40603

That's the issue. After a lot of digging and some helpful direction from Andrew Branch @ MSFT, I was able to replicate the TS compiler's elision behaviour. Feel free to copy.
This is the file doing the work:
https://github.com/LeDDGroup/typescript-transform-paths/blob/master/src/utils/elide-import-export.ts
You can see how it's implemented here:
https://github.com/LeDDGroup/typescript-transform-paths/blob/master/src/visitor.ts#L103-L137

@banyudu what do think?

@banyudu what do think?

Thanks, @AndyOGo @nonara ，will fix it soon.

@banyudu Thanks for merging my PR.
It handles the case for my issue well.
@nonara approach looks to be the accurate solution for any case.

@banyudu Thanks for merging my PR.
It handles the case for my issue well.
@nonara approach looks to be the accurate solution for any case.

I'm not sure whether it's ok to automatically remove type imports for users. IMO, it seems not a behavior users would expect ts-rename-import-plugin to do.

Thanks for your quick answer.
This is the default behavior of typescript, that it removes type imports in the output JS (since types aren't valid ECMAScript, they need to be removed, else JS engine would throw syntax errors).
Anyway typescript updateImportDeclaration has a bug, it stops doing the elision process of type imports and this broke my build - all type imports where still there, without the actual file.
All details can be found in this issue:
https://github.com/microsoft/TypeScript/issues/40603

@AndyOGo Typescript stops doing the elision process of type imports by its design, it's not recognized as a bug yet.
Since updateImportDeclaration stops doing the elision process of type imports, it's reasonable to do the elision process by this plugin.
But if this plugin removes the type imports, it may break the plugins after it(if any).
So I think a better way is using the onion model:

rename import paths
run other plugins
remove the changed "type imports"

But I don't know how to do it yet.

Indeed, I have read that they choose this by design. Though the output clearly shows that it produces faulty results.
Frankly, ts is awesome, though this design decision was just wrong.
You are right, I see you point.
I would be keen what is @nonara experience with possibly breaking other plugins by this change?

May be we could just check "type imports" before rename, and skip them.

To skip those type imports is also a nice idea. Though how would you differentiate them?
I have also use case where both types and modules are import from the same ts file.

To skip those type imports is also a nice idea. Though how would you differentiate them?
I have also use case where both types and modules are imported from the same ts file.

Emm, you are right.

I would be keen what is @nonara experience with possibly breaking other plugins by this change?

This is a big issue that makes the whole world of transformers quite complex. Chaining transformers will inevitably have interesting side-effects. A well-built transformer will make use of original as needed, to walk up the chain in order to get information it needs.
IMO, with regard to this case, the worst case scenario is having a non-existent identifier imported or exported in your output JS. This causes the entire code to fail. This happens often and is critical. In contrast, causing side-effects in a subsequent transformer is a much more rare. Additionally, I believe that it becomes even more rare in this case. I'll explain why...
What we've done is we only apply our elision behaviour if the transformer is running as a JS before transform. So we don't run it during declarations transform. This means that there will be no usage of any type identifier anywhere in the JS file, so there are very few conceivable reasons that a JS transformer would have any reason to actually need to see unused identifiers in question in the import/export declaration.
However - if it does want to for some reason, it's still able to do this by accessing the node's original property to walk up the chain. This is how that scenario should be handled properly, anyway, if it wants itself to be compatible with other transformers.
So to sum it up, I would say that the chances of you causing conflict with another transformer are extremely rare. If they do occur, however, they can be easily remedied by a PR to the other transformer to use original. On the other hand, the potential for breaking code in the event of hitting this issue by having elision break down is much more common and critical. That has been our experience anyway!
Hope that helps!

It just occurred to me - would changing to an after transformer suit this library's use case?

It just occurred to me - would changing to an after transformer suit this library's use case?

In my opinion, it's not a good idea to handle this issue in every transformers. Providing an after-transform transformer as a patch to the latest typescript is better.
In this way, users could fix this issue by appending this after-transform plugin after the original transformers like ts-rename-import-plugin or typescript-transform-paths.

How about creating a new after-transform transformer from your code? @nonara

How about creating a new after-transform transformer from your code? @nonara

It looks like the TS team has started looking into the issue, so there may not be a need to work around it much longer. If it turns out that it doesnt get fixed upstream, I'll make a helper npm package that we can use.
What I mean by after is to have your users specify after in the transform config. That way it would be transforming the module specifier after type elision has already completed.
That was also just suggested by the TS team member looking into the issue as a remedy. For now, I think I'm going to hold off and see what happens with the issue.


Small Bug fixes for @slackorama #74

This pull request fixes up the tests based on the changes made by @slackorama in #74. Ends those changes highlighted a number of places where I had made mistakes in the remote_branch_name function. These changes should fix that.
@slackorama if you're happy with this merge it and then we can merge #74.

Looks good! Thanks.


Package added to a higher precedence directory in resolve.modules does not trigger compile in watch mode

Bug report

What is the current behavior?
When having multiple resolve.modules (e.g. override-packages, and base-packages), on building and initial webpack-dev-server compilation, the packages are correctly loaded from the directory with highest precedence.
However when a package is in base-packages on the first compilation, and you add an override package with the same name to override-packages (with or without source files in it), no rebuild is triggered.
If the current behavior is a bug, please provide the steps to reproduce.
I have created a minimal reproducible case on Github. See the README for instructions. It runs a dev-server and the adding and removing of an override package is automated, and tested by the script. I also included two arguments to modify cache and/or dependency behavior.

What is the expected behavior?
Since order is important in resolve.modules, and watching is enabled in webpack-dev-server, it should detect if a module now resolves to a different location.
Things I have tried
Some tests were done to trigger a correct rebuild. The only thing that worked was adding a context dependency on the whole context root (or on each module directory), AND disabling cache and resolve.cache. (Added arguments in the repository for this).
The watching of (part of) root context I can live with (We already do some context watching for a plugin we use in our case), but disabling the cache will be a severe performance hit.

Other relevant information:
webpack version:  4.30.0
Node.js version: 8.15.0
Operating System: MacOS 10.14.3
Additional tools: n/a

This is a shortcoming in webpack 4. It's fixed in webpack 5.


Improve string concatenation example

Per comments in the PR, adding this as a follow-up to #29785, which was merged to fix #29440.
While we've improved the string interpolation example, there were follow-up suggestions from @gewarren and @BillWagner which I'm capturing here.
On https://github.com/dotnet/docs/blob/main/docs/csharp/language-reference/tokens/interpolated.md:

Utilize something more complex than Hello World to have a reason for there not to be one interpolated string.
Perhaps include the preferred choice of single string interpolation to show an alternative
Language update to:

To combine multiple interpolated strings, add the $ special character to each string literal.

[Edited to add doc details]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d0665571-35b7-0841-5719-b69456b35cfb
Version Independent ID: 0410420b-3b12-6d96-40cf-56f22ac19a1d
Content: $ - string interpolation - C# reference
Content Source: docs/csharp/language-reference/tokens/interpolated.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @pkulikov
Microsoft Alias: wiwagn

Thanks for writing this up @SeanKilleen
I added the "up for grabs" label here. Did you want to submit PR? If so, I'll assign this to you.

@mjh316 That is the million dollar question. I'm starting to think we should just remove the section on concatenating two interpolated strings since it doesn't seem to be very useful and the example might only lead to confusion.

Interested on working on this, but any ideas on what reasons there could be not to have a single interpolated string? An initial thought was that perhaps in the case of adjacent expressions that would be clearer when separated, but I'm unable to think of such one.

When I was thinking this through, the only scenarios that came to me were calling multiple methods to compose different parts of the string. I like @gewarren 's suggestion for the fix:

I'm starting to think we should just remove the section on concatenating two interpolated strings since it doesn't seem to be very useful and the example might only lead to confusion.

I don't think this aspect needs an entire section as it has currently. How about we just add a sentence somewhere that states that if you concatenate two or more interpolated strings, each one must be prefixed with $?
Alternatively, sometimes we answer questions raised in issues just in the issue itself - without updating the doc. Which I think would also be acceptable in the case of #29440.


[shopifyAuth] HMAC validation not sorting URL parameters lexicographically

In the callback route https://github.com/Shopify/shopify-node-app/blob/master/shopify-express/routes/shopifyAuth.js#L40, the hmac validation process doesn’t follow the same steps listed in our docs (https://help.shopify.com/api/getting-started/authentication/oauth#verification).. Specifically, our docs say The list of key-value pairs is sorted lexicographically.
Not doing this doesn’t seem to be an issue where it’s used in this app, but if I copy the code and use it on another request sent by shopify (the one that includes the protocol property), the validation fails

Closing because this project is now deprecated.


Use Token instead of Username/Email address

There are some privacy issues regarding stored usernames and email addresses. Right now the login username or email address is used to link your account with RuneLite. This should be changed to an anonymized account token.
There are many privacy and security issues regarding this. The most obvious one is that the usernames and email addresses can be cross-referenced with password breaches of other websites. People often use the same password and this information is valuable as it gives attackers a list of people who are known to have an active runescape account. Even if people put their password in their notes, without an identifier to use, the accounts would be much safer.
Hence why I suggest the following migration, (username means login username or email address):

One way hash serverside usernames into a token and store it alongside the username
Refactor ALL hardcoded config keys that use the username to not use it or use the token. Examples are: timetracking..... and killcount..wintertodt. (I only play a low level ironman and do not have much more config values that use the username in my settings.properties file, but find-all shows 25 matches for getUsername() in the plugin package).
Add a client-side migration to convert all old config values containing the username to ones that use a token, or add a legacy check that converts the token during config lookups with the username if it wasn't found with the token
Move the "loginscreen.username" configuration value to the local computer, or explicitely ask the user if they want to sync it. This could be done with a token-map so different RuneLite accounts can load different local usernames.
Start saving the display name so it can be used to show to the user on the website
Push the update so players start using the token
Remove the usernames that are being accessed from their token
After a period of x amount of days we can remove all left-over usernames

That way the username is removed both as an identifier and as a string in config variables, in 1 update with backwards-compatibility. And to support older clients, the username and config key could be converted during the requestat the server-side, as that only happens in memory.
For generating the token I suggest a slow algorithm as it only has to be done once in a while. And the time of hashing on the server could only be an issue during migration.
There was also some talk about configuration scopes and profiles, but that doesn't change the fact that usernames are visible to the RuneLite devs. This is also meant as a fast privacy/security fix and not a whole new way of storing configuration.

Related: runelite/runelite.net#215

If your email address being public is a security issue for you, you have much deeper and more pressing issues than us.

I completely disagree. There are no security or privacy issues with this. The server stores usernames, which can include email addresses, in a secure way which are not ever given to any other users. No part of RuneLite stores passwords.
WIth that being said, I am okay with changing it to not store usernames. I am not willing to guise it under some "security" fix or try to band-aid fix the problem from trying to rush it though.
As I have already stated, the reason why the config requires the usernames in the keys is for account-specific configuration items. I would like to make account-specific config items a first class citizen of the config system, by the use of config profiles. If we did this, we could very easily change the way accounts are identified to be based on a hash rather than the username. Changing the existing key-value based system to store some username derived hash would just make the current situation worse than it already is and make fixing it more difficult.

I'm very much in favor of changing the configuration as you mentioned in Discord. The part about changing configuration keys that contain the username would just be a temporary fix, so that they wouldn't be stored on the server anymore while you work on removing them altogether.

An email address is personal data, and should be treated as such. When the database leaks, significantly less personal information is leaked when using a token (for example a token provided by OAuth services like Google). I'm not sure if RuneLite has to comply with GDPR, but implementing tokens instead of emails would mitigate the risk of the database leaking.

I actually work with GDPR compliance. Any database that includes any person(s) who have residency or citizenship in a country associated with the EEA has to comply with the GDPR. If we're storing data subjects personal information (IP addresses, account names, emails,) then there are several steps that have to be taken in order to secure that data and keep track of it. If ANYONE can look at a piece of data and say "I know who that belongs to," then it counts as personal data. Tokens would be a wonderful solution to this, so long as the token isn't associated with the email address in order to make the data "truly" anonymous.


Add git info to --version

Output of futhark --version will now be like the following. I think the format for the timestamp of the commit is horrible, but I do think it is important to have, as it tells you how recent a version was used which is usually what you want to know for non debugging purposes.
Futhark 0.1
git: 8791fd4 (Wed Jan 11 18:26:23 2017 +0100)
(C) HIPERFIT research centre
Department of Computer Science, University of Copenhagen (DIKU)

If the branch is not "master", the branchname will be inserted before the hash, and if any files have been modified this will be displayed at the end of the line
Caveats
Due to the way the gitrev package works (using TemplateHaskell),
Futhark.Version and Futhark.Util.Options will be recompiled on every
compilation. This kinda sucks, and is why I didn't just merge it right away.

Those rebuilds seem pretty harmless.  It's a small module, and a drop in the bucket compared to the ridiculous link times we already suffer.
People can use intero-mode or GHCi for snappier feedback.


Conflicting Dependencies in 0.3.x versions.

The requirement of future==0.17.1 is directly in conflict with Airflow's 1.10.3 requirements. We can remain on 0.2.3 without too much problem but I wonder if its worth following the advice set out in the "security reasons" section of this proposal:

With development of python library one cannot achieve such security, because libraries must not define concrete dependencies. Breaking this rule (thus trying to declare concrete dependencies by python library) results in problems such as:

problems to find satisfying version of shared libraries (each strict package defines exact version of shared library and it is very likely the versions will differ and prevent finding commonly acceptable version)
concrete dependencies may depend on python version, OS or other environment markers and trying to install the package in diferent context can easily fail to satisfy some of rules defined in original abstract dependencies.

Fixed in v0.4.0 but this release also removes Python 2.7 support, are you on still on it?

no we've been on Python 3 for a while. Thanks so much! will upgrade soon.


Error when trying to plot one cachefile

When plotting one cachefile (AmWo post5 ipsilesional, can be found here: /mnt/data/data08/ProcessedData/2020_Stroke_Maps/cachefiles_inspected/AmWo/post5), I get the following error:
Traceback (most recent call last):
  File "plotmaps.py", line 47, in <module>
    plot_map([cachefile1])
  File "C:\tool-offspect\offspect\cache\plot.py", line 330, in plot_map
    return plot_glass(coords, values, **kwargs)
  File "C:\tool-offspect\offspect\cache\plot.py", line 152, in plot_glass
    filled_img = project_into_nifti(coords, values, smooth)
  File "C:\tool-offspect\offspect\cache\plot.py", line 73, in project_into_nifti
    apos = pinv(affine).dot(list(chain(pos, [1])))
TypeError: Cannot cast array data from dtype('float64') to dtype('<U32') according to the rule 'safe'

For all other cachefiles that are already inspected, no errors occur.
Offspect is up to date.

Trace number 183 has [None, None, None] as coords. Additionally, I changed plot_map so it will plot even if some traces have unusable coordinates. It will log this, though.


Is there a plan to use a storage backend that would persist code between successive "odo push" executions?

Which functionality do you think we should add?
While working on #2920, we found that since we use emptyDir as backing storage volume, the k8s Deployment fails to come up after linking.
A bit about linking. Linking (odo link) creates a Service Binding Request (SBR) using the APIs provided by Service Binding Operator (SBO). A SBR creates a k8s Secret and injects this Secret's information into the envFrom field of the run container. It does this by modifying the Deployment's YAML definition.
As a result of this change in Deployment's definition, the underling pod is restarted. Upon restart, the application fails to get reloaded since the code is not stored anywhere.
Why is this needed?
As a result of our inability to store the code on cluster and bring the application back to running state, we need to do odo push after doing odo link for an Operator backed service. OTOH, we didn't have this requirement when linking Service Catalog backed service.
Thus, there's a different UX:

Linking service backed by Service Catalog doesn't require user to do odo push. (needs to be verified when working with devfile component.)
Linking service backed by an Operator requires user to do odo push.

/kind feature
/kind discussion
/area UX

@johnmcollier I was told that you did some research on using a persistent backend for components.
@kadel the issue description is largely based on what you explained me when I was stuck while implementing odo link. If there's some mistake on my part in describing our discussion, let me know.

@dharmit Yah, our earlier "kdo" poc used persistent volumes instead of emptyDir volumes for components

@kadel @johnmcollier out of curiosity, why did we go with emptyDir if there was an implementation using persistent volumes? IIRC, earlier implementation of s2i based components also had persistent volumes.

@dharmit I don't fully remember the reasons but I believe we had a few concerns around mandating persistent volumes for all components:

Concerns around volume attach times on some cloud providers (e.g. on IBM Cloud, volume provision and attach can be over 2 minutes)

@dharmit I don't fully remember the reasons why but I believe we had a couple concerns around mandating persistent volumes for all components:

Concerns around volume attach times on some cloud providers (e.g. on IBM Cloud, volume provision and attach can be over 2 minutes)
Wanted users be able to run Odo without volumes if desired, especially if dynamic provisioning of volumes isn't available

We discussed this on today's call, we decided on minimally supporting a toggle to enable users to switch between ephemeral emptyDir volumes and PersistentVolumes. We didn't decide on a default however.
https://github.com/openshift/odo/issues/3775

We didn't decide on a default however.

Since using persistent volumes would help solve more than just odo link, I would request we make persistent volumes default.

Closing since this was addressed by #4316
/close


Add gitter chatroom

Gitter  is a great way to facilitate discussion on github. Chatrooms for public repos are free.

Hello, I was wondering if you meant this in a collaboration, support or other way?

I've seen projects use it for both.

For support we already have the support forum, so I don't know how 'redundant' a chat room is.
I don't know how lively it would be, or if there is any appeal.
I think it would be good to have more people's opinion on this.
@timowest what do you think? Do you see a particular use case for a chat room?
I think when Timo comments, we can see if we can make a post on the forum to ask whether there is appeal for this. Is that okay?

Sure. I just wanted to mention it.

I am active in the Querydsl Google Group, GitHub and on StackOverflow, so also being available in a chatroom would be a challenge for me.
But I am also for asking more opinions on it in the Querydsl google group.

Good point. Providing too many avenues for support is probably not a good idea.


Moq.Mock.Verify() using It.Is inside Smock.Run throws MethodAccessException

I'm not sure if this is a Moq problem or a Smocks problem, but this works:
public void AcceptsStoreList()
{
     Smock.Run(context =>
     {
          Setup(context);

          Target.Accept(DownloadedEvent);

          Mock.Get(WorksheetReaderFactory)
                    .Verify(m => m.EntityWorksheetReader(Worksheet, It.IsAny<CellArea>()), Times.Once);
     });
}

And this does not:
public void AcceptsStoreList()
{
     Smock.Run(context =>
     {
          Setup(context);

          Target.Accept(DownloadedEvent);

          Mock.Get(WorksheetReaderFactory)
                    .Verify(m => m.EntityWorksheetReader(Worksheet, It.Is<CellArea>(ca => ca.StartRow == 1 && ca.EndRow == 5 && ca.StartColumn == 0 && ca.EndColumn == 5)), Times.Once);
     });
}

The exception that is thrown is:
Error Message:
   Test method WorksheetExtractor.Test.Extractors.Walmart.V1.StoreListWorksheetExtractorTest.AcceptsStoreList threw exception:
System.MethodAccessException: Attempt by security transparent method '?  .(Aspose.Cells.WorksheetCollection)' to access security critical method 'Smocks.Setups.Interceptor.Intercept<Aspose.Cells.Worksheet>(System.Object[], System.Reflection.MethodBase)' failed.

Assembly 'Aspose.Cells, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=716fcc553a201e56' is marked with the AllowPartiallyTrustedCallersAttribute, and uses the level 2 security transparency model.  Level 2 transparency causes all methods in AllowPartiallyTrustedCallers assemblies to become security transparent by default, which may be the cause of this exception.
Stack Trace:
    at ?  .(WorksheetCollection )
   at Aspose.Cells.WorksheetCollection.Add()
   at Aspose.Cells.WorksheetCollection.Add(String sheetName)
   at WorksheetExtractor.Test.Extractors.Walmart.V1.StoreListWorksheetExtractorTest.Setup(ISmocksContext smocksContext) in c:\Dev\Git\RetailData\import\WorksheetExtractor.Test\Extractors\Walmart\V1\StoreListWorksheetExtractorTest.cs:line 70
   at WorksheetExtractor.Test.Extractors.Walmart.V1.StoreListWorksheetExtractorTest.<AcceptsStoreList>b__2(ISmocksContext context) in c:\Dev\Git\RetailData\import\WorksheetExtractor.Test\Extractors\Walmart\V1\StoreListWorksheetExtractorTest.cs:line 130   at Smocks.AppDomains.AppDomainContext.InvokeSerializableLambda[T](SerializableLambda`1 serializableFunc, Object target, Object[] arguments)
   at Smocks.AppDomains.AppDomainContext.Invoke[T](Action`1 action, T parameter)
   at Smocks.Smock.RunAction(Action`1 action, Configuration configuration)
   at Smocks.Smock.Run(Configuration configuration, Action`1 action)
   at Smocks.Smock.Run(Action`1 action)

StoreListWorksheetExtractorTest.cs:line 70 refers to the "Workbook = new Workbook(new MemoryStream());" in the Setup method:
 public void Setup(ISmocksContext smocksContext)
        {
            SourceStream = Mock.Of<IStreamProxy>();

            //SourceStream = new StreamProxy(Assembly.GetExecutingAssembly().GetManifestResourceStream("WorksheetExtractor.Test.Extractors.Walmart.V1.StoreList.xls"));
            DestinationStream = Mock.Of<IStreamProxy>(); //(new StreamProxy(new MemoryStream()));

            Storage = Mock.Of<IDataFileStorage>();
            Mock.Get(Storage).Setup(m => m.OpenRead(DownloadedEvent.FileName)).Returns(SourceStream);
            Mock.Get(Storage).Setup(m => m.OpenWrite(It.IsAny<string>())).Returns(DestinationStream);

            Workbook = new Workbook(new MemoryStream());
            Worksheet = Workbook.Worksheets.Add("Wal-Mart Stores");
            Cell = Worksheet.Cells[1, 1];
            smocksContext.Setup(() => Workbook.Worksheets[It.IsAny<string>()]).Returns(Worksheet);
            smocksContext.Setup(() => Workbook.Worksheets["Wal-Mart Stores"]).Returns(Worksheet).Verifiable();
            smocksContext.Setup(() => Worksheet.Cells.MaxDisplayRange.FirstRow).Returns(0);
            smocksContext.Setup(() => Worksheet.Cells.MaxDisplayRange.RowCount).Returns(5);
            smocksContext.Setup(() => Worksheet.Cells.MaxDisplayRange.FirstColumn).Returns(0);
            smocksContext.Setup(() => Worksheet.Cells.MaxDisplayRange.ColumnCount).Returns(5);
            smocksContext.Setup(() => Worksheet.Cells.Find(It.IsAny<string>(), null, It.IsAny<FindOptions>())).Returns(Cell);
            smocksContext.Setup(() => Worksheet.Cells.Find("Store Nbr", null, It.IsAny<FindOptions>())).Returns(Cell).Verifiable();

            CellsFactory = Mock.Of<ICellsFactory>();
            Mock.Get(CellsFactory).Setup(m => m.Workbook(SourceStream)).Returns(Workbook);

            Reader = Mock.Of<IEntityCsvStreamReader<Store>>();
            WorksheetReaderFactory = Mock.Of<IEntityWorksheetReaderFactory<Store>>();
            Mock.Get(WorksheetReaderFactory)
                .Setup(m => m.EntityWorksheetReader(It.IsAny<Worksheet>(), It.IsAny<CellArea>()))
                .Returns(Reader);

            Writer = Mock.Of<IEntityCsvStreamWriter<Store>>();
            CsvWriterFactory = Mock.Of<IEntityCsvStreamWriterFactory<Store>>();
            Mock.Get(CsvWriterFactory).Setup(m => m.EntityCsvStreamWriter(DestinationStream.Stream)).Returns(Writer);

            Marshaller = Mock.Of<IMarshaller>();
            Producer = Mock.Of<IProducer>();

            Target = new StoreListWorksheetExtractor(Storage, CellsFactory, WorksheetReaderFactory, CsvWriterFactory,
                Marshaller, Producer);
        }

Workbook is a class from a third-party assembly, which doesn't implement any interfaces, and doesn't have virtual members, and is my reason for trying out smocks.  Is there anything that jumps out at you as something I might be doing wrong?

Thanks for reporting this. The issue was that the third-party assembly (Aspose Cells) has the AllowPartiallyTrustedCallersAttribute attribute. Smocks rewrites the assembly to make calls to methods in the Smocks assembly, which is prevented by the .NET security model because of said attribute. I've added some code to strip assemblies from the AllowPartiallyTrustedCallersAttribute attribute when rewriting them, which should resolve this problem.

The package for this fix is available on nuget now.

Looks like that did it - thanks!


cli: Fix console for big endian architecture

The function ioctl can lead to a big endian bug.
Issue already solved in containerd/console:
https://github.com/containerd/console/pull/20/commits/dbd69c59b81ec72258da35a335605e4b3ea17e6a
Fixes: #921
Signed-off-by: Alice Frosi<EMAIL_ADDRESS>

/test

Ouch!
lgtm
For reference (from https://golang.org/pkg/unsafe/#Pointer with added emphasis):

(4) Conversion of a Pointer to a uintptr when calling syscall.Syscall.
The Syscall functions in package syscall pass their uintptr arguments directly to the operating system, which then may, depending on the details of the call, reinterpret some of them as pointers. That is, the system call implementation is implicitly converting certain arguments back from uintptr to pointer.
If a pointer argument must be converted to uintptr for use as an argument, that conversion must appear in the call expression itself.


(InvitingGuests) - The tenant domain should be configurable in the admin UI

At least the global admin UI

This has been completed, but as requested should only be editable in the global admin UI.

Fixed 1c6eca2


cmpcodesize: replace the Ounchecked with the Osize benchmark shortcut.

To be in sync with the current benchmark build modes

@swift-ci smoke test and merge


feat(PLM-1415): Support validating multiple row data by dict-like Sp…

…ec natuarally
[Why]
DSV now validates Spec and treats the input value as a dictionary. We need to make another spec containing this list data for validation.
[How]

Provide multirow option for decorator dsv & function validate_data_spec
Add test & revise README

PLM-1415
Reason
Changes
Test Scope
Checks

[x] Unit tests are included or not applicable.

oops, 太久沒上這個 repo 的 PR, initial pre-commit 竟然失敗惹 XD

oops, 太久沒上這個 repo 的 PR, initial pre-commit 竟然失敗惹 XD

need to change the pre-commit repo from gitlab.com to github.com

oops, 太久沒上這個 repo 的 PR, initial pre-commit 竟然失敗惹 XD

need to change the pre-commit repo from gitlab.com to github.com

THANKS :)

Thanks :)


'Example output' boxes + wrap cURL call in quotes

Proposed Changes

Added 'example output' boxes to some commands for easier copy-paste when using the built-in clipboard button, and to better distinguish visually which are commands to be entered and which is output

Wrapped the cURL call for the Ingress gateway example in quotes. When running the existing call in my terminal I get:
* Closing connection -1 curl: (3) URL using bad/illegal format or missing URL
Possibly resulting from tripping up on query params. Wrapping in double quotes resolves this.

Minor edit in port forwarding example for opening another terminal session

Awesome fix! Thanks @msradam !
/lgtm
/approve


Fixed failing API calls for choropleth map.

Just to add a note here that calling reverse on a dictionary is only available for python >= v3.8


index.html

extends includes/layout
block content
include includes/post-list
include includes/pagination

I can't understand what you want. Please describe details. Thanks.

Because China can not download npmjs.org . it`s ok now

Then I'll close this issue.


can't run ShellCheck on vscode

Failed to run shellcheck: [undefined] Command failed with exit code 1: shellcheck -V
'shellcheck' �����ڲ����ⲿ���Ҳ���ǿ����еĳ���
���������ļ���
I can't run ShellCheck

What platform? OS and arch. Anything on your settings?

Vision: 1.82.2 (user setup)
Electron: 25.8.1
ElectronBuildId: 23779380
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT ia32 10.0.19044
64-bit operating system, x64-based processor
I'm very sorry I don't know what happened, actually I was able to use this plugin normally for the first two days.Regarding this computer being equipped by the company, I have not modified any settings, or is there any setting in its system that triggers the disabling function?

What's your system locale? You can bring up ⌘ line (Win+R, type "cmd" then enter)
Then:
cd %USERPROFILE%.vscode\extensions
dir
In the output, find something like timonwong.shellcheck-xxxxxxx, then cd into that directory.
Then you should run  cd binaries/win32/x64 and type shellcheck.exe to see what happens

I tried to enter the folder you mentioned: timonwong.shellcheck-xxxxxxx,I can actually get into this folder, but in the next step,i can't fint "binaries/win32/x64"  .Displays that the system cannot find the specified path,and i try to re-install vscode

just now i find that folder but i can't find shellcheck.exe.Maybe that's where the problem comes from

What is the version of the extension?

Are you running the extension in a remote environment or natively on Windows?

I just tested on Windows x64, and it's working for me using the bundled binary.

Thanks for you help,I re-install vscode and it's working for me now.About that issue i surmise that the shellcherk.exe file is missing from that folder due to some system rule.And  i running the extension in a  natively on Windows but forget which version of the extension.There is no problem now because I solved the problem of not working by reinstalling the software.
Finally, I would like to thank you very much for the help you provided me today.

No problem. I hope it stays working forever. Have a great day!


On IOS issues are caused when using icons on the map

Hi Bruno.
Thanks for the work on this plugin. I was able to integrate it on an online Leaflet Satellite Tracker with success.
However on IOS it crashed. What I learned is that when the controls are loaded no icons are loaded anymore on IOS and further Javascript execution stops. On Windows with Chrome the script works perfect. Only on IOS devices it goes wrong either in Safari or Chrome as soon as the control is loaded.
This is the code used:
`
var base = L.tileLayer('https://server.arcgisonline.com/ArcGIS/rest/services/World_Street_Map/MapServer/tile/{z}/{y}/{x}.png', {
minZoom: 0,   // was 2
maxZoom: 8
});
var map = L.map('map', {
layers: [base],
tap: false, // ref https://github.com/Leaflet/Leaflet/issues/7255
center: new L.LatLng(0, 0),
zoom: 2
});
// create fullscreen control *********************** When I remove this contol the icons are loaded and script is executed on IOS
var fsControl = L.control.fullscreen();
// add fullscreen control to the map
map.addControl(fsControl);
// events are fired when entering or exiting fullscreen.
map.on('enterFullscreen', function(){
console.log('entered fullscreen');
map.setZoom(4);
});
map.on('exitFullscreen', function(){
console.log('exited fullscreen');
map.setZoom(2);
});
// Add the sun to the map
var sunIcon = L.icon({
iconUrl: 'map/sun-real.png',
iconSize: [60, 60],
iconAnchor: [30, 30],
opacity: 0.7
});
var sunpos = L.marker([0, 0], {icon: sunIcon}).addTo(map);
`

Hi @mhoeneveld as i've said in https://github.com/brunob/leaflet.fullscreen/issues/75#issuecomment-768371183 i think we can forget fullscreen API use on iOS cf Safari is supported on desktop and iPad, but not on iPhone. This is a limitation in the browser, not in Screenfull..

No feedback, closing for now, feel free to comment if needed.


fix issue #810

to solve the error

[rviz2-3] [ERROR] [1652204061.476182910] [rviz2]: ItemIdentityException: Can not find codec for 'tif' image format.
[rviz2-3] Supported formats are: bmp dds gif hdr jpeg jpg ktx pgm pic pkm png ppm psd tga. in Codec::getCodec at /Users/xlla/ros2_foxy/build/rviz_ogre_vendor/ogre-v1.12.1-prefix/src/ogre-v1.12.1/OgreMain/src/OgreCodec.cpp (line 66)

To do that, we need to add <depend>libfreeimage-dev</depend> to rviz_ogre_vendor, and we also need to add libfreeimage to the rosdep database.  I've opened a pull request for the latter at ros/rosdistro#33403 .

All right, that PR is in.  I'm going to re-target this to the ros2 branch, and also add those rosdep keys to this PR.  That should solve the problem for Linux.
For Windows, I think we'll have to add freeimage as part of the build process in rviz_ogre_vendor.  If we do that, that should make this work on all platforms.


[CERT-TEST-FAILURE] [TC-RVCRUNM-2.2] [TC-RVCLEANM-2-2] -- Python Tests Failure

Feature Area
Area:RobotVacuums
Test Case
TC-RVCRUNM-2.2
TC-RVCLEANM-2-2
Reproduction steps

Command used to launch the DUT : ./chip-all-clusters-app
Command used to run the python script : python3 TC_RVCRUNM_2_2.py --discriminator 3840 --passcode 20202021 --commissioning-method on-network --storage-path admin_storage.json --PICS <RVCRUNMode cluster PICS file> --endpoint 1 --paa-trust-store-path ../../credentials/development/paa-root-certs/ --int-arg PIXIT.RVCRUNM.MODE_A:1 PIXIT.RVCRUNM.MODE_B:2 --app-pid <app pid>

While executing the TC-RVCCLEANM-2.2 Python script, the test is failing at Test Step 6b Send ChangeToMode MODE_B command with error  mobly.signals.TestFailure: Details=Expected a ChangeToMode response status of InvalidInMode(0x03), got Success(0x00), Extras=None. The issue arises from line 127, where the BitMask value self.directmodech_bit_mask is incorrectly set to 0x8000. According to the specification, the correct value should be 0x10000, which enables the 16th bit.

Same Issue in TC-RVCCLEANM-2.2

Bug prevalence
Whenever I do
GitHub hash of the SDK that was being used
dd875401ae2f5c2f39b9e69f156cd6fabebe2aa8
Platform
raspi
Anything else?
Python Script References:

https://github.com/project-chip/connectedhomeip/blob/master/src/python_testing/TC_RVCRUNM_2_2.py

Reference Log:
TC-RVCRUNM-2.2.txt
TC-RVCCLEANM-2.2.txt
Specification References:

Issue fixed in commit 708558881bf6e5b0dac3c09489124907927b6cd2. Hence closing the issue.


MultiDirChooser not found in 1.0.1

Hi,
I'm upgrading from Gooey <IP_ADDRESS> (python 2.7) to Gooey 1.0.1. However I've found that the MultiDirChooser widget is not working. Is it removed? If so may I ask how to choose multiple directories with the new version? Thanks a lot!
The error log is:
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\python_bindings\gooey_decorator.py", line 83, in inner2
    return payload(*args, **kwargs)
  File "test.py", line 87, in main
    args = parser.parse_args()
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\python_bindings\gooey_parser.py", line 113, in parse_args
    return self.parser.parse_args(args, namespace)
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\python_bindings\gooey_decorator.py", line 78, in run_gooey
    application.run(build_spec)
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\gui\application.py", line 15, in run
    app = build_app(build_spec)
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\gui\application.py", line 24, in build_app
    gapp = GooeyApplication(merge(build_spec, imagesPaths))
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\gui\containers\application.py", line 40, in __init__
    self.configs = self.buildConfigPanels(self)
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\gui\containers\application.py", line 206, in buildConfigPanels
    for widgets in self.buildSpec['widgets'].values()]
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\gui\containers\application.py", line 206, in <listcomp>
    for widgets in self.buildSpec['widgets'].values()]
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\gui\components\config.py", line 15, in __init__
    self.layoutComponent()
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\gui\components\config.py", line 80, in layoutComponent
    self.makeGroup(self, sizer, item, 0, wx.EXPAND)
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\gui\components\config.py", line 119, in makeGroup
    widget = self.reifyWidget(parent, item)
  File "C:\Users\xxx\Anaconda3\lib\site-packages\gooey\gui\components\config.py", line 158, in reifyWidget
    widgetClass = getattr(widgets, item['type'])
AttributeError: module 'gooey.gui.components.widgets' has no attribute 'MultiDirChooser'

[ ] OS: Win 10
[ ] Python Version:  Python 3.6.5 (Anaconda)
[ ] Gooey Version : 1.0.1 (pip installed)
[ ] wx Version: 4.0.3

Thanks! ^_^

Refer to my pull request


From private repo

@itechedit : Thanks for your contribution! The author, @mlottner, has been notified to review your proposed change.


[Forestry] Change tags field to sortable field list

The tags field allows to add random tags to it which could lead to rogue content tagging.
We can change it to a Sortable Field List so it behaves more like a closed multi-select.

Changing to a sortable list also avoids the problem of superfluous spaces in tag values.


feat(): Add method Sofort（Bank redirects）

Describe the bug
We have added multiple payment methods in our stripe dashboard and API PaymentIntent, but they don't show up in our paymentSheet.
To Reproduce
Steps to reproduce the behavior:
Add payment methods do your account.
start checkout session
show paymentSheet
Expected behavior
I would except the paymentSheet to allow me to choose my payment method, besides card payment.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: MacOS
Browser Safari
Version current from (29.07.2021)

Smartphone (please complete the following information):

Device: iPhone 8 and iPhone X
OS: 14.6
Browser safari / ionic app
Version: capacitor v3

Additional context
Add any other context about the problem here.
we have talked wit the stripe support and they told us to ask for your help.

@danielalbrecht
Hi, thanks for try.
What did you require payment method?? This plugin support card payment and apple pay, google pay, only. If many others need the payment method you need, consider implementing it. or please create pull request.
Thanks.

We need SOFORT and DEBIT payment. They are most common in Europe for B2B payments.

@PaintedShepherd

they don't show up in our paymentSheet.

https://stripe.com/docs/payments/sofort/accept-a-payment
This seems to be not paymentSheet function, and not settings by dashboard only. We need to implement new features in this plugin.  I won't have time to implement it right away, but welcome to create a pull request.
Visa (debit) and Mastercard (debit): https://stripe.com/docs/testing can be able to use. Please try again.
Thanks.

@danielalbrecht @PaintedShepherd Did you adapt this plugin for production? If yes, please tell us what app. Please help us to develop this plugin in 2022.
https://github.com/capacitor-community/stripe/issues/145
Thanks.

I've created a pull request that adds new payment methods: #201
@rdlabo can you check it out?

Isn't it necessary to add configuration.allowsDelayedPaymentMethods = true (Swift Notation) aswell to allow these payment methods?

Just wanted to add:
The combination SetupIntent + Sepa/Sofort does not work in PaymentSheet, because it is not yet supported by Stripe.

https://github.com/capacitor-community/stripe/issues/88

FWIW, Stripe does have support for 'us_bank_account' for in app browser usage. However, its a hidden opt in feature that you have to request. Its their "webview" payment feature. If you ask about it, they should be able to turn it on for you.


rn0.49.5 bug  moment-with-locales.min.js  require() must have a single string literal argument

Description of the Issue and Steps to Reproduce:
Please include the values of all variables used.
**Environment:RN0.49.5
moment-with-locales.min.js  require() must have a single string literal argument

is there anybody fix this?

See #65


Add vendored getTileIndices

I could not get this to run locally, but I think this is the meat and potatoes of it.

I see there is no longer an array of zoom levels for the same region. Isn't that what we want to iterate through? Maybe I'm confused. Otherwise, this looks good to me.

❯ cat chrome_http1.csv
file,format,compression,zoom,tileSize,regionId,yCoord,xCoord,height,width,numChannels,tileId,startTime,endTime
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,1,0-0--6,590.1550000016869,972.845000000234
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,1,0-0--5,592.3650000004272,1537.8950000012992
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,1,0-0--4,593.1049999999232,1696.8600000000151
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,1,0-0--3,594.1850000017439,1671.3349999990896
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,1,0-0--2,594.7950000008859,1265.5699999995704
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,1,0-0--1,595.3350000017963,825.7149999990361
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,1,0-0--6,1700.345000001107,1912.7150000022084
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,1,0-0--5,1700.8800000003248,2382.740000000922
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,1,0-0--4,1701.3450000013108,2499.4750000005297
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,1,0-0--3,1701.7550000018673,2449.4550000017625
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,1,0-0--2,1702.1700000004785,2154.5550000009825
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,1,0-0--1,1702.5849999990896,1797.2799999988638
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,2,0-0--6,2501.2950000018463,2926.755000000412
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,2,0-0--5,2502.250000001368,3779.3950000013865
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,2,0-0--4,2502.889999999752,4026.754999998957
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,2,0-0--3,2504.059999999299,3964.654999999766
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,2,0-0--2,2504.7650000014983,3426.484999999957
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,2,0-0--1,2505.6250000016007,2654.1700000016135
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,2,0-0--6,4028.425000000425,4448.585000001913
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,2,0-0--5,4029.239999999845,5137.634999999136
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,2,0-0--4,4030.044999999518,5388.605000000098
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,2,0-0--3,4030.784999999014,5343.0350000016915
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,2,0-0--2,4032.054999999673,4764.0749999991385
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,2,0-0--1,4032.9750000018976,4238.345000001573
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,3,0-0--6,5390.56999999957,5747.42999999944
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,3,0-0--5,5391.855000001669,6145.035000001371
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,3,0-0--4,5392.845000002126,6212.8650000013295
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,3,0-0--3,5393.755000000965,6190.555000001041
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,3,0-0--2,5394.93500000026,5965.390000001207
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,3,0-0--1,5396.110000001499,5510.949999999866
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,3,0-0--6,6214.4699999989825,6311.434999999619
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,3,0-0--5,6223.860000001878,6683.069999999134
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,3,0-0--4,6224.900000001071,6759.229999999661
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,3,0-0--3,6225.8499999989,6740.825000000768
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,3,0-0--2,6226.795000002312,6528.880000001664
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,3,0-0--1,6227.745000000141,6308.254999999917
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,4,0-0--6,6761.0400000012305,6943.334999999934
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,4,0-0--5,6762.380000000121,7378.534999999829
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,4,0-0--4,6763.549999999668,7500.530000001163
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,4,0-0--3,6764.79499999914,7492.3200000012
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,4,0-0--2,6766.090000000986,7261.020000001736
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,300,400,4,0-0--1,6767.30999999927,6864.260000002105
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,4,0-0--6,7502.2400000016205,7588.380000001052
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,4,0-0--5,7511.210000000574,8140.535000002274
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,4,0-0--4,7512.460000001738,8217.854999998963
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,4,0-0--3,7513.654999998835,8199.730000000272
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,4,0-0--2,7514.885000000504,7946.674999999232
original_file_name.img,zarr,blosc,-5,1024,some-unique-id,0,0,1000,1000,4,0-0--1,7516.169999998965,7625.485000000481

I only see one zoom level logged in the output, are you sure all the higher zoom levels are being computed?

@manzt This should be fixed now.  It was a reporting bug.  I also noticed another issue but fixed it.


Project fails to build properly

I've tried to build the project from 3 different sources and it does not seem to work.
First I had to add
#include <cstdint>

to both ImfDwaCompressor.cpp and imfMisc.cpp due to errors:
"path/to/build/DJV/DJV-Release/OpenEXR/src/OpenEXR/OpenEXR/IlmImf/ImfDwaCompressor.cpp:1013:38: error: ‘uintptr_t’ does not name a type
1013 |                 if (reinterpret_cast<uintptr_t>(_rowPtrs[comp][y]) & _SSE_ALIGNMENT_MASK)"
and
"path/to/build/DJV/DJV-Release/OpenEXR/src/OpenEXR/OpenEXR/IlmImf/ImfDwaCompressor.cpp:745:31: error: ‘uintptr_t’ does not name a type
745 |         if ((reinterpret_cast<uintptr_t>(rowBlockHandle + i) & _SSE_ALIGNMENT_MASK) == 0)"
And after that it spits out an error regarding RapidJSON:
"path/to/build/DJV/DJV-install-Release/include/rapidjson/document.h:319:82: error: assignment of read-only member ‘rapidjson::GenericStringRef::length’
319 |     GenericStringRef& operator=(const GenericStringRef& rhs) { s = rhs.s; length = rhs.length; }"
I presume the build problems are not fixable on your end, since they are third party libraries, right?
I found that the bug regarding the assignment has been fixed so maybe this just needs to be updated on your end?

So after a bit of fiddling I finally got the project to build:
First obviously you need to include
#include <cstdint>

in both ImfDwaCompressor.cpp and ImfMisc.cpp
Next you need to remove line 319 in rapidjson/document.h
For that (if you have followed the steps on the website) you need to navigate to
./DJV-Release/DJV-install-Release/include/rapidjson/document.h

After that you still get two more errors to fix, saying that
./DJV-install-Release/include/rapidjson/document.h:885:83: error: macro "RAPIDJSON_ENABLEIF" passed 2 arguments, but takes just 1
885 |         explicit GenericValue( T b, RAPIDJSON_ENABLEIF( internal::IsSame<bool, T> ) )
and
.//DJV-install-Release/include/rapidjson/document.h:892:75: error: macro "RAPIDJSON_STATIC_ASSERT" passed 2 arguments, but takes just 1
892 |                 RAPIDJSON_STATIC_ASSERT( internal::IsSame<bool, T>::Value );
To fix those errors you need to go into line 885 and 892 of the same documents.h respectively and set a few parentheses like so:
// Old line 885:
// explicit GenericValue( T b, RAPIDJSON_ENABLEIF( internal::IsSame<bool, T> ) )
// Fixed line:
explicit GenericValue( T b, RAPIDJSON_ENABLEIF( (internal::IsSame<bool, T>) ) )

// ...

// Old line 892:
// RAPIDJSON_STATIC_ASSERT( internal::IsSame<bool, T>::Value );
// Fixed line:
RAPIDJSON_STATIC_ASSERT( (internal::IsSame<bool, T>::Value) );

Save and exit the file.
The project should now compile and run properly.


collections entries add fails with method requires POST

I am trying to add an entry to a collection

twitter_api.collections.entries.add(tweet_id='113934951708026****', _id='custom-11431331023628*****')

I get:

File "*****AppData\Local\Programs\Python\Python36\lib\urllib\request.py", line 650, in http_error_default
raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 400: Bad Request
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "\AppData\Local\Programs\Python\Python36\lib\site-packages\twitter\api.py", line 334, in call
return self._handle_response(req, uri, arg_data, _timeout)
File "\AppData\Local\Programs\Python\Python36\lib\site-packages\twitter\api.py", line 367, in _handle_response
raise TwitterHTTPError(e, uri, self.format, arg_data)
twitter.api.TwitterHTTPError: Twitter sent status 400 for URL: 1.1/collections/entries/add.json using parameters: (id=custom-1143133102362877952&oauth_consumer_key=&oauth_nonce=&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1561886531&oauth_token=30438056***&oauth_version=1.0&tweet_id=&oauth_signature=%3D)
details: {'errors': [{'code': 86, 'message': 'This method requires a POST.'}]}

Here is the API reference:
https://developer.twitter.com/en/docs/tweets/curate-a-collection/api-reference/post-collections-entries-add
I am able to call this using Postman

Hello, looking at the result error you get, I guess the lib sends à GET message. I believe this is a new API route and the list of methods requiring POST instead of GET is hardcoded in the lib, so it would deserve to be added there :
In the mean time you can force using POST by adding the _method="POST" argument to your call.


buildroot: enable mdev

Use mdev to auto setup usb ethernet dongles.

@douglas-raillard-arm Is that something you used for the integration tests? AFAICT you're already using eth dongles with buildroot, right?

@valschneider We faced the issue on Hikey 960 where the USB network interface is detected a few seconds after the boot sequence completes. This means the dhcp client runs before there is any network interface, and when it actually comes up, the dhcp client is not run again. This solves the issue by getting an IP every time a network interface appears, so it's event-based and we don't miss it.


Grunt Build in SAP Web IDE Full-Stack

Tutorial URL: https://developers.sap.com/tutorials/webide-grunt-basic.html
Please specify the step you are referring to
How to create build for SAP Fiori Extension project. ? to create component-preload.js and component-preload-h2.js ?
BR,
Pavan

Hi Pavan,
Can you please explain your question a little bit more?
I am not sure I understand what the question is that you are asking.
Thanks!
Shira

Thank you for your feedback. We haven't heard from you in a while, so we are closing the issue.
If you still have questions, feel free to reopen the issue.


yacs.CfgNode instead of argparse.Namespace

Moved to https://github.com/tumaer/lagrangebench/pull/28 in favor of OmegaConf for multiple reasons:

more flexibility and simplicity in OmegaConf structures
integration with hyperparameter search frameworks
ease of use for library version users


Using comments with VS Code shorcuts?

In the extension presentation, I can read:

Zero config , No need to switch to django-html !

However, how auto-comment feature in VS Code is supposed to work , this way?
For example, when I want to comment this block, here is what happens:

Of course, I would expect Django template comments like {# ... #} to be used. I don't have this issue with other extension in which django-html format is used rather than normal HTML for Django templates.
Thanks for your help.

I think ctrl+/ should be left for html commenting (<!-- -->)
I am setting ctrl+shift+/ for Django commenting. But currently, it will only support single-line comments ({# #}).
For multiline comments, you can use the comment_block snippet. To do so, select the block you want to comment, type comment_block then hit tab.
Using another language(django-html) disables many vscode html and embedded css, js features. Where you have to create a language server for that language and forward requests to the respective language servers of the embedded languages. Which requires a lot of work and that other extensions don't have. But have a lot of other issues.
Don't forget to support the project if you can.

Closed by (7a6a48590d995d7dc9674c4886c253a79ce8e015)

I am setting ctrl+shift+/ for Django commenting. But currently, it will only support single-line comments ({# #})

I'm not sure how am I supposed to setup this. For example in VS Code, while I know how to configure the shortcuts to toggle comments, where am I supposed to tell: "to comment this block, please use {# ... #}" characters?
Since it's an HTML file, VS Code will always use <!-- ... --> when commenting.

For multiline comments, you can use the comment_block snippet

Please note that using {% comment %} block does not grayed out the commented text. I think this is a bug:

In addition, it seems that using this method, there is no way to uncomment a commented block.

I think ctrl+/ should be left for html commenting ()

As a personal opinion, I'd prefer using the same shortcut to comment every filetype, with my IDE intelligent enough to pick the right characters. But I understand if it's complicated.

Don't forget to support the project if you can

I'll be glad to sponsor the project if my problems can be solved in a clean way. As you said, extensions using another language (django-html) have many issues. That's why I had hope using yours. However, commenting is very important as it is constantly used by developers, and I won't be able to use this extension without proper way to do it.
Thanks!

I'm not sure how am I supposed to setup this. For example in VS Code, while I know how to configure the shortcuts to toggle comments, where am I supposed to tell: "to comment this block, please use {# ... #}" characters? Since it's an HTML file, VS Code will always use <!-- ... --> when commenting.

I have added single-line comment feature in the 0.4.0 release.
Now you can find it in the features  section.

Please note that using {% comment %} block does not grayed out the commented text. I think this is a bug:

It's not greyed out Django documentation.

In addition, it seems that using this method, there is no way to uncomment a commented block.

It requires document indent info, which VSCode does not provide currently. I have opened this issue for that.

As a personal opinion, I'd prefer using the same shortcut to comment every filetype, with my IDE intelligent enough to pick the right characters. But I understand if it's complicated.

It is impossible. Leave ctrl+/ for html commenting and use ctrl+shift+/ for django commenting.

I'll be glad to sponsor the project if my problems can be solved in a clean way. As you said, extensions using another language (django-html) have many issues. That's why I had hope using yours. However, commenting is very important as it is constantly used by developers, and I won't be able to use this extension without proper way to do it.
Thanks!

Hope you have your answers now.

Great, I'll patiently watch the new releases then. Thanks for the good work.

check the 0.5.0 release. Hope everything is fine.


Hot reload is not working when import @vue-dapp/walletconnect

The issue lies with these two packages. Importing either one of them will cause the hot reload feature to be lost.
app/app.vue
import { WalletConnectConnector } from '@vue-dapp/walletconnect'
import { CoinbaseWalletConnector } from '@vue-dapp/coinbase'

vue-dapp-starter, nuxt-dapp, and vue-dapp/app have the same problem.

Will be fixed at v1.5.0


Fix vote service ports and update readme

Update the way the ports are set so they can be updated more easily and update the readme to explain how to run the vote service.

Thanks Katherine.


RocketPool support

How feasible would it be to add automatic detection of RocketPool minipools and calculate consensus layer rewards that go to the node operator?
A column that has the node fee percentage, and a column that has the rewards earned by the NO, as opposed to earned by the validator:

16 ETH minipool: Total rewards * 0.5 + total rewards * 0.5 * node fee percentage
8 ETH minipool: Total rewards * 0.25 + total rewards * 0.75 * node fee percentage

Acknowledged that this is easy enough to add manually to the generated CSV :)

Very feasible and it's on my to-do list, see the Gitcoin grant.
I have decided to prioritize execution layer rewards over Rocketpool support (since that will benefit everyone, not just RPL node operators). I've been working on it in my free time since October but there are still some inconsistencies in the rewards calculation (especially when the fee recipient is a smart contract things can get interesting).
When I get to adding Rocketpool support I would like to include RPL rewards as well besides consensus layer rewards.
Do you know how to get the operator commission rate? I haven't looked into it yet, but I assume I'll need to go through events emitted by one of the Rocketpool contracts.

The commission rate for a Rocketpool validator can be found on chain or via the Beaconcha.in API.
For onchain, you can get this by looking at the deployment of the minipool contract (validator withdrawal address), which includes _minimumNodeFee corresponding to the commission rate of that validator.
The Beaconcha.in API also has an endpoint which contains a lot of relevant info, including the commission rate: https://beaconcha.in/api/v1/rocketpool/validator/{index}
You've possibly already figured this out, but I thought I'd drop the info here anyway.

Yeah, I agree that it would absolutely be best to have an independent implementation. But it's definitely more work 😅.
I didn't realise that you had specific plans for Rocketpool. I actually submitted a bounty application to the RP Grants Management Committee for a tax calculation tool a couple of week ago, and they will decide whether or not to include it in the next 5ish days. So there may be some incentive to complete the work!
One thing which I think is missing is the EL MEV rewards for those not in the smoothing pool. I'm pretty sure those get paid to the minipool delegate address, and then split according to the minipool commission.
The commission only changes at very specific times (almost never). It's only when a minipool performs a "bond reduction", they go from their previous fee, to 14% (in the case of 8ETH minipools). So the commission should whatever they deployed the minipool at, or if they went through a bond reduction, 14%.
RPL and smoothing pool rewards are very complicated to calculate, but fortunately you don't have to do that. The oDAO members generate this data once per rewards period and publish the per-node data on IPFS and a reference to it (the CID) is published on-chain when the rewards are distributed.
Rocketpool support is definitely not a small task, but it would help many people 🙏

I found this very helpful documentation of how the calculations are performed (and were performed historically).

I've put a lot of effort into this and it looks like I'm finally close to something viable.
A development version is running at http://<IP_ADDRESS>/preview , if anyone is subscribed to this issue and wants to give it a try, compare it to what they expect they earned, it would be greatly appreciated! Feel free to reach out to me in private as well, I'm on the Rocket Pool Discord among many more.
There are some limitations, but I believe it should work just fine for 99% of RP node operators:

the transition from solo staker to a promoted minipool is not supported at the moment. If running promoted minipools, the workaround is to use the default mode for the date range where the validator was running "solo", and Rocket Pool mode for the date range after the promotion
pre-Redstone RPL (September 2022) rewards are not supported
due to the way the calculations work, the calculate request in Rocket Pool mode may take several minutes to return, especially if the node operator is not using the Smoothing Pool. At the extremes, e.g. with a node that has 450 linked minipools without SP, the request takes about 20 minutes currently.
slashing scenarios are not handled right now but the request should return with an error response in this case, and not return incorrect/incomplete data

Rocket Pool Mode is now a part of ethstaker.tax 🚀 enjoy!
Accompanying blog post: https://serenita.io/blog/ethstaker-tax-rocket-pool-mode


added my portfolio

Added my portfolio

Thank you for your interest in Season of Docs! Would you please add your information to the end of the file as specified in the instructions? Thank you!

I will do that, thanks.

I will do that, thanks.

I will do that, thanks.


Sources and Sinks link broken

If you click on the link here: https://docs.wallaroolabs.com/book/appendix/tcp-decoders-and-encoders.html you'll be greeted by a 404. This was reported via IRC.

The link seems to work for me. Can we close this @strmpnk?

It still doesn't work for me here. It seems gitbook.js is ignoring the clicks but if I force the link open in another tab or window it is still 404.

What browser are you using?
I can't reproduce with firefox 61.0.1

Firefox 61 here too. The link shows a url when hovering. The URL loaded by itself is 404 every time. Clicking itself does not work at all.

Perhaps DNS is (part of) the cause?
% dig @<IP_ADDRESS> docs.wallaroolabs.com | egrep 'wall.*IN|netli.*IN' | grep -v ';'
docs.wallaroolabs.com.	1495	IN	CNAME	wallaroo-docs-release.netlify.com.
wallaroo-docs-release.netlify.com. 20 IN A	<IP_ADDRESS>
% dig @<IP_ADDRESS> docs.wallaroolabs.com | egrep 'wall.*IN|netli.*IN' | grep -v ';'
docs.wallaroolabs.com.	1604	IN	CNAME	wallaroo-docs-release.netlify.com.
wallaroo-docs-release.netlify.com. 19 IN A	<IP_ADDRESS>


move the developing wiki

to a hacking.md page, to make it more discoverable
https://github.com/dart-atom/dartlang/wiki/Developing

fixed by https://github.com/dart-atom/dartlang/commit/99d51c28af1b763a534b0855f802bc4bc58c0a29


[feature request] verifier - Allow disambiguating multiple occurrences of an anchor match [phab:T138]

Created by pludemann at 2016-06-10 00:29:27:
For templates and parametric declarations, it's often the case the parameter appears multiple times in a line.  e.g.
def max(arg1: T, arg2: T) -> T

The verifier doesn't allow "T" because it's ambiguous, which requires a clumsy (and error-prone) notation with absolute offsets. I suggest something like #n to match the "n"th item (leaving open the question of whether 0-origin or 1-origin is best):
#- MaxArg1Type=#1"T" ref vname("max.<template_arg>.T", "corpus", "", "", "python")
#- MaxArg2Type=#2"T" ref(vname("max.<template_arg>.T", "corpus", "", "", "python")
#- MaxReturnType=#3"T" ref(vname("max.<template_arg>.T", "corpus", "", "", "python")
def max(arg1: T, arg2: T) -> T

pludemann wrote at 2016-06-21 20:07:50:
It seems that my request has been answered by
#1244

zarko wrote at 2016-06-21 20:48:00:
Resolved by #1244.


[WIP]Feature/live modeling

This pull request is to prepare the merge of https://github.com/OpenTOSCA/winery/pull/204
DONE:
-merge master
-fix errors that prevent start
-fix errors
-connect to Container
TODO:
-check semantic
-check plan generation in Container
-drag and drop of new nodes does not seem to work properly
In YAML Mode:
-Properties are shown only in sidebar not in dropdown of the nodetemplate
-Error on Save: ERROR o.e.w.r.rest.websockets.GitWebSocket:280 run - org.eclipse.jgit.diff.DiffEntry cannot be cast to java.lang.String   java.lang.ClassCastException: org.eclipse.jgit.diff.DiffEntry cannot be cast to java.lang.String 	  at org.eclipse.winery.repository.rest.websockets.GitWebSocket$GitLogRunnable.run(GitWebSocket.java:253)
-"Hide DependsOn Relations" Button routes to http://localhost:4201/

[x] Ensure that you followed http://eclipse.github.io/winery/dev/ToolChain#github---prepare-pull-request. Especially, we require a single commit
[x] Ensure that the commit message is a good commit message
[x] Ensure to use auto format in all files
[x] Ensure that you appear in NOTICE at Copyright Holders
[ ] Tests created for changes
[ ] Documentation updated (if needed)
[ ] Screenshots added (for UI changes)

Adding a small video for reviewers to look into the new feature to have the following changes ready in the runtime: https://github.com/OpenTOSCA/container/pull/190
https://youtu.be/cJKXwwdNfrw

Follow up at eclipse.


[BUG] Can't use multiple gpu's to process list columns

Describe the bug
Trying to process a dataset containing list columns (multihot/vector continuous features) fails.
Steps/Code to reproduce bug
Passing a dask client to the workflow throws an exception if the dataset contains a list column.
Adding a dask client to any of the unittests that process lists produces an error like:
../../nvtabular/workflow.py:786: in apply
    dtypes=dtypes,
../../nvtabular/workflow.py:889: in build_and_process_graph
    self.exec_phase(idx, record_stats=record_stats, update_ddf=(idx == (end - 1)))
../../nvtabular/workflow.py:656: in exec_phase
    for r in self.client.compute(stats):
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/site-packages/distributed/client.py:2917: in compute
    actors=actors,
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/site-packages/distributed/client.py:2641: in _graph_to_futures
    "tasks": valmap(dumps_task, dsk),
cytoolz/dicttoolz.pyx:181: in cytoolz.dicttoolz.valmap
    ???
cytoolz/dicttoolz.pyx:206: in cytoolz.dicttoolz.valmap
    ???
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/site-packages/distributed/worker.py:3358: in dumps_task
    return {"function": dumps_function(task[0]), "args": warn_dumps(task[1:])}
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/site-packages/distributed/worker.py:3322: in dumps_function
    result = pickle.dumps(func, protocol=4)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/site-packages/distributed/protocol/pickle.py:60: in dumps
    result = cloudpickle.dumps(x, **dump_kwargs)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/site-packages/cloudpickle/cloudpickle_fast.py:102: in dumps
    cp.dump(obj)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/site-packages/cloudpickle/cloudpickle_fast.py:563: in dump
    return Pickler.dump(self, obj)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:437: in dump
    self.save(obj)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:549: in save
    self.save_reduce(obj=obj, *rv)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:638: in save_reduce
    save(args)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:504: in save
    f(self, obj) # Call unbound method with explicit self
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:789: in save_tuple
    save(element)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:504: in save
    f(self, obj) # Call unbound method with explicit self
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:859: in save_dict
    self._batch_setitems(obj.items())
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:890: in _batch_setitems
    save(v)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:504: in save
    f(self, obj) # Call unbound method with explicit self
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:789: in save_tuple
    save(element)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:504: in save
    f(self, obj) # Call unbound method with explicit self
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:774: in save_tuple
    save(element)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:504: in save
    f(self, obj) # Call unbound method with explicit self
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:819: in save_list
    self._batch_appends(obj)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:843: in _batch_appends
    save(x)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:504: in save
    f(self, obj) # Call unbound method with explicit self
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:819: in save_list
    self._batch_appends(obj)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:843: in _batch_appends
    save(x)
/home/ben/anaconda3/envs/cudf_dev/lib/python3.7/pickle.py:524: in save
    rv = reduce(self.proto)
../../../cudf/python/cudf/cudf/core/abc.py:132: in __reduce_ex__
    header, frames = self.host_serialize()
../../../cudf/python/cudf/cudf/core/abc.py:97: in host_serialize
    header, frames = self.device_serialize()
../../../cudf/python/cudf/cudf/core/abc.py:41: in device_serialize
    header, frames = self.serialize()
../../../cudf/python/cudf/cudf/core/dataframe.py:531: in serialize
    column_header, column_frames = column.serialize_columns(self._columns)
../../../cudf/python/cudf/cudf/core/column/column.py:1948: in serialize_columns
    header_columns = [c.serialize() for c in columns]
../../../cudf/python/cudf/cudf/core/column/column.py:1948: in <listcomp>
    header_columns = [c.serialize() for c in columns]

I can confirm that there is no ListColumn.serialize method in cudf.  This means distributed/dask-cuda will fall back onto default column serialization when it tries to send a ListColumn between processes.

Hopefully cudf#6721 will take care of this for cudf-0.17

Thanks for taking this on Rick! Thats awesome


Decorate all generated items with CompilerGeneratedAttribute

Provides XamlX functionality for AvaloniaUI/Avalonia/issues/9026. A little bit of extra work will be required in the Avalonia repository after this PR to cover all generated types.

@kekekeks this has been waiting to be merged for a while now.