s/create/apply

Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[x] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[x] Provide a title or release-note blurb suitable for the release notes.
[x] Thanks for contributing!

Replacing the use of create with apply to work with clusters that contain new or existing cilium installs.

Thanks for the PR! Please add a Signed-off-by to your commit message according to the above instructions.
What is the motivation for the range? Using experimental-install.yaml after quick-install.yaml already has been installed?

What is the motivation for the change? Using experimental-install.yaml after quick-install.yaml already has been installed?

I was playing around with GKE's Cilium dataplane (--enable-dataplane-v2) which already has Cilium but no Hubble. When I went through the Hubble quick install guide, it used the imperative create vs. the declarative apply. Since I already had Cilium running, some resources failed. Using apply is a lot more forgiving.
It appears there still might be some other woes (not detecting flows) but that can be for another issue 😄


Can pipenv freeze requirements file only include packages?

Can pipenv freeze requirements file only include packages?
I want requirement file don't include dev-packages.

I believe we would need to modify the API semantics a bit, you should propose this by making a markdown document and submitting it as a pull request to the peeps directory proposing the change so that kenneth can review it

OK, I will do it.

The new pipenv requirements command has flags for this.


[CS2103-F10-2] FoodOnWheels

FoodOnWheels help restaurant chain delivery managers manage their delivery orders. It is optimized for CLI users so that frequent tasks can be done faster by typing in commands.

Codecov Report

Merging #14 (85ad9b2) into master (4f7660a) will not change coverage.
The diff coverage is 0.00%.

:exclamation: Current head 85ad9b2 differs from pull request most recent head fbe474c. Consider uploading reports for the commit fbe474c to get more accurate results

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Impacted Files
Coverage Δ

src/main/java/seedu/address/Main.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7660a...fbe474c. Read the comment docs.


Fix lodash replacement regex

#104 did not work for me, the defineProperty replacement was not applied, as could be seen by the broccoli-debug output. The regex seems to not match https://github.com/lodash/lodash/blob/es/_defineProperty.js#L8 regarding white spaces.
cc @rwjblue

This fixed ember-cli/ember-cli#7001 for me

This seems good, but I'm surprised that ember test passed locally with only the changes from #104.

@rwjblue I was also experiencing some strange things... #104 did work for me locally the first time, but then failed later, the same in CI. There was some flakiness which I could not explain...

@rwjblue - I found that the PhantomJS tests (as per my first screenshot) would fail "sometimes" but not every time (that always adds to the awesome.. not just in general, but mixing PhantomJS in to just put the icing on the cake).  So possibly he saw the same behavior.

Yeah, this came up first in a PR of a teammate, his branch worked locally with Phantom, but failed in CI. On my machine I was then able to reproduce the failure, while it continued to work on his (even after a fresh start with rm -rf node_modules etc.). Quite weird...

This fixed ember-cli/ember-cli#7001 for me as well

This also fixed https://github.com/ember-cli/ember-cli/issues/7001 for me!

it fixes as well for me Object is not a function (evaluating '(0, _lodash_defineProperty['default'])') error is Safari < 10. And on IOS < 10. Surprised than no-one brought it up.

@tchak this seems to be good then. Can we get a merge and patch release, so this fix can be integrated into downstream addons? see https://github.com/samselikoff/ember-cli-mirage/issues/1084

@Romanior - FWIW, this will affect all platforms that do not have a native Symbol.


Mysql regex links

The uppercase R in Regexp.html was resulting in pages not being found.

As confessed at Gitter, I accidentally created a branch in the Symphony repo instead of making one in my fork. Sorry about doing it wrong; I'll be more careful in future. (And I'll probably do more locally and avoid making edits in the web interface.)

Hey @DavidOliver no worries !
This as already been fixed in 2.7.0 via https://github.com/symphonycms/symphony-2/commit/ec0a040e348730f20541d495158ed8c53ec86496
No need to merge it into integration as it will be rebased on top of 2.7.x
So I'll close this PR and delete your branch ;)


in screencast mode filter arrow key press

Issue Type: Bug
in screencast mode pressing arrow key shows up on the overlay.
can you add some setting to avoid this?
i am fine with it shown as "ctrl + upArrow"
currently its shown as "upArrow upArrow downArrow upArrow upArrow downArrow".
VS Code version: Code - Insiders 1.48.0-insider (731f9c25632dbbf01ee3a7892ad9d2791fe0260c, 2020-07-24T05:57:10.466Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-8265U CPU @ 1.60GHz (8 x 1800)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: enabledrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.87GB (9.10GB free)

Process Argv
. --crash-reporter-id 340e0eb9-5b34-4206-9e2e-bd86fc3b2cf3

Screen Reader
no

VM
0%

Extensions (29)

Extension
Author (truncated)
Version

ng-template
Ang
0.1000.4

vscode-eslint
dba
2.1.8

gitlens
eam
10.2.2

EditorConfig
Edi
0.15.1

vscode-npm-script
eg2
0.3.12

prettier-vscode
esb
5.1.3

go-nightly
gol
2020.7.2222

output-colorizer
IBM
0.1.2

mongodb-vscode
mon
0.1.0

gather
ms-
2020.7.0

python
ms-
2020.7.96456

vscode-pylance
ms-
2020.7.3

remote-containers
ms-
0.128.0

remote-ssh
ms-
0.51.0

remote-ssh-edit
ms-
0.51.0

remote-wsl
ms-
0.44.4

vscode-remote-extensionpack
ms-
0.20.0

typescript-javascript-grammar
ms-
0.0.53

vscode-typescript-tslint-plugin
ms-
1.2.3

cordova-tools
msj
1.9.4

debugger-for-chrome
msj
4.12.9

fabric8-analytics
red
0.1.0

vscode-xml
red
0.13.0

vscode-yaml
red
0.9.1

sonarlint-vscode
Son
1.16.0

code-spell-checker
str
1.9.0

vscode-stylelint
sty
0.84.0

vscodeintellicode
Vis
1.2.9

quokka-vscode
Wal
1.0.311

@joaomoreno vscode already have filter for single key press, will this not come under that setting itself?

Do you want to hide arrow keys? Do you want to not show repetitions? I don't really understand what the issue is.

hide the arrow keys when the only purpose is to traverse code.
ex: if user is using up arrow key to go up a line -> hide it.
if user is using ctrl+rightArrow to go to end of current word  - > show it.

@joaomoreno can you confirm if you understood the issue?

hide the arrow keys when the only purpose is to traverse code.

But this is sometimes the exact reason why some people would like to show the keybindings, so the viewer can see which arrow key was pressed, as code is navigated around.
I'll keep this closed as designed, sorry!

As a university lecturer, this feature "as designed" is completely unusable. It feels like this was never tested by a real-world user.
I wanted to show shortcuts like Ctrl+S. Instead my screen is completely spammed.  Just look at this... All I'm doing is moving the caret. How do you imagine this being useful?

@joaomoreno - As a university lecturer, this feature "as designed" isn't worth using. It feels like this wasn't tested in the wild.
I want to show shortcuts like Ctrl+S. Instead my screen is completely spammed.  Just look at this... All I'm doing is moving the caret. Who finds this useful?

Edit: It seems that screenshot is an unfair representation; it's because I keep changing direction (which after reviewing my class videos is not realistic). Here are some real-world cases taken straight from my classes:
TL;DR: Filtering arrows & shift+arrows would probably solve 99% of my issues.

Just to add... I also think the expectation for a setting called "Screencast Mode: Only Keyboard Shortcuts" is to filter arrows and backspace; they are literally single key presses performing their global default purpose. IMO that is not the definition of a shortcut.

How could this ever be helpful to my fellow developers?

I thing this bug is located at: /src/vs/workbench/browser/actions/developerActions.ts
Maybe in the line 227 disposables.add(onKeyDown.event(e => {...
When I have more time I will continue to investigate...

Hy guys! I have added the lines to fix this issue and sent a pull request:

Cheers!

I have added some features to screencast mode:

Fix arrow key repetition
Fix label of pressed arrow keys
Add option to hide single arrow keys pressed

Sent a new pull request too:
https://github.com/microsoft/vscode/pull/171845


421 make image

Adds new functions ModuleObj.saveImage and SceneObj.saveImage to save .hdr images of a module or scene.  These are run by default in the modelchain if simulationParamsDict['saveImage'] = True.  The gui will set  saveImage = True by default.

[ ] Pytests
[ ] Docstrings
[ ] Tutorials updated
[ ] whatsnew

At the moment the ModuleObj.saveImage is working well.  The SceneObj.saveImage function might need some tweaks to get the correct view figured out.
Under the hood, if you have a trackerdict with multiple entries, the model chain will try to take the scene closest to 20 degree tilt for the image.  This could be updated if it's not what we want.  A default ground (concrete material) and sun (due East or West azimuth and 65 elevation) are created.  These values could also be changed if it's not what we want.


fix(versions): update Activiti/example-runtime-bundle versions into master

UpdateBot pushed helm dependency: common to: 1.1.21

UpdateBot commands:
updatebot push-version --kind helm common 1.1.21


VASP/INCAR add default INCAR tag generator

VASP/INCAR add default INCAR tag generator based on VASP version. This seems to be quite complicated for two reasons: 1. There're too many INCAR tags; 2. The default value of one tag may depends on another.

Closed. Should focus on bug fix, don't have extra energy on this script for the time being.


raftstore: remove checksum calculation when init snapshot

Hi,
This PR tries to remove checksum calculation when initializing a V2::Snap. It fixes the CPU high issue happened in the test environment.
PTAL @zhangjinpeng1987 @siddontang

LGTM

Rest LGTM

PTAL @siddontang

PTAL @siddontang

LGTM

Please fix the conflict. @hhkbp2

ci failed


RPF should error when there are no facts for a supported OS

RPF should error when there are no facts for a supported OS, otherwise people will assume test coverage when there is none.

There is now SPEC_FACTS_STRICT=yes to solve this.


IOError: cannot identify image file '/tmp/pyvision-ffmpeg-7204250/1.jpg'

I am facing kind of serious error in running
turkic extract /home/bee/Desktop/omnomstori_Dy5g5Vjl.mp4 /home/bee/Documents/VATIC/vatic
Besides giving the error as IOError: cannot identify image file '/tmp/pyvision-ffmpeg-7204250/1.jpg', seriousness is the command removes whole parent folder /home/bee/Documents/VATIC/vatic from the computer without trace. For instance the command removed the whole document folder from my computer when I ran the command as turkic extract /home/bee/Desktop/omnomstori_Dy5g5Vjl.mp4 /home/bee/Documents. Luckily I was trying to install in a fresh ubunut 14.04.3, there were not much importatnt files in it. I have another instance of Ubunut with vatic running perfectly, I followed all the steps done in that insatnce and is based on anaconda virtual environment containing following libs.
anaconda-client==1.1.2
clyent==1.0.0
Cython==0.20
munkres==1.0.7
MySQL-python==1.2.5
numpy==1.10.1
parsedatetime==1.2
PIL==1.1.7
Pillow==3.0.0
PyOpenGL==3.1.1a1
python-dateutil==2.4.2
pytz==2015.7
pyvision==0.3.1
PyYAML==3.11
requests==2.8.1
six==1.10.0
SQLAlchemy==1.0.9
turkic==0.2.5
wheel==0.26.0
wsgilog==0.3

Any help in this regard is requested, The complete log of the command is below
(vatic3)bee@beehive:~/Documents/vatic$ turkic extract /home/bee/Desktop/omnomstori_Dy5g5Vjl.mp4 /home/bee/Desktop/test/hi
ffmpeg version 2.6.2 Copyright (c) 2000-2015 the FFmpeg developers
  built with gcc 4.8 (Ubuntu 4.8.4-2ubuntu1~14.04)
  configuration: --prefix=/usr --bindir=/usr/bin --datadir=/usr/share/ffmpeg --incdir=/usr/include/ffmpeg --libdir=/usr/lib/x86_64-linux-gnu/ --mandir=/usr/share/man --arch=x86_64 --optflags='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic' --enable-bzlib --disable-crystalhd --enable-frei0r --enable-gnutls --enable-libass --enable-libcdio --enable-libdc1394 --disable-indev=jack --enable-libfreetype --enable-libgsm --enable-libmp3lame --enable-openal --enable-libopencv --enable-libopenjpeg --enable-libopus --enable-libpulse --enable-libschroedinger --enable-libsoxr --enable-libspeex --enable-libtheora --enable-libvorbis --enable-libv4l2 --enable-libvpx --enable-libx264 --enable-libxvid --enable-x11grab --enable-avfilter --enable-avresample --enable-postproc --enable-pthreads --disable-static --enable-shared --enable-gpl --disable-debug --disable-stripping --shlibdir=/usr/lib/x86_64-linux-gnu/ --enable-runtime-cpudetect
  libavutil      54. 20.100 / 54. 20.100
  libavcodec     56. 26.100 / 56. 26.100
  libavformat    56. 25.101 / 56. 25.101
  libavdevice    56.  4.100 / 56.  4.100
  libavfilter     5. 11.102 /  5. 11.102
  libavresample   2.  1.  0 /  2.  1.  0
  libswscale      3.  1.101 /  3.  1.101
  libswresample   1.  1.100 /  1.  1.100
  libpostproc    53.  3.100 / 53.  3.100
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/home/bee/Desktop/omnomstori_Dy5g5Vjl.mp4':
  Metadata:
    major_brand     : isom
    minor_version   : 512
    compatible_brands: isomiso2avc1mp41
    encoder         : Lavf54.29.104
  Duration: 00:01:10.01, start: 0.000000, bitrate: 647 kb/s
    Stream #0:0(und): Video: h264 (Constrained Baseline) (avc1 / 0x31637661), yuv420p, 640x360, 545 kb/s, 25 fps, 25 tbr, 50 tbn, 50 tbc (default)
    Metadata:
      handler_name    : VideoHandler
    Stream #0:1(und): Audio: aac (LC) (mp4a / 0x6134706D), 44100 Hz, stereo, fltp, 96 kb/s (default)
    Metadata:
      handler_name    : SoundHandler
Please use -b:a or -b:v, -b is ambiguous
[swscaler @ 0x1a64f20] deprecated pixel format used, make sure you did set range correctly
Output #0, image2, to '/tmp/pyvision-ffmpeg-983757886/%d.jpg':
  Metadata:
    major_brand     : isom
    minor_version   : 512
    compatible_brands: isomiso2avc1mp41
    encoder         : Lavf56.25.101
    Stream #0:0(und): Video: mjpeg, yuvj420p(pc), 640x360, q=2-31, 10000 kb/s, 25 fps, 25 tbn, 25 tbc (default)
    Metadata:
      handler_name    : VideoHandler
      encoder         : Lavc56.26.100 mjpeg
Stream mapping:
  Stream #0:0 -> #0:0 (h264 (native) -> mjpeg (native))
Press [q] to stop, [?] for help
frame= 1750 fps= 65 q=1.6 Lsize=N/A time=00:01:10.00 bitrate=N/A
video:61888kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: unknown
Aborted. Cleaning up...
Traceback (most recent call last):
  File "/home/bee/anaconda/envs/vatic3/bin/turkic", line 4, in <module>
    __import__('pkg_resources').run_script('turkic==0.2.5', 'turkic')
  File "/home/bee/anaconda/envs/vatic3/lib/python2.7/site-packages/setuptools-18.4-py2.7.egg/pkg_resources/__init__.py", line 735, in run_script

  File "/home/bee/anaconda/envs/vatic3/lib/python2.7/site-packages/setuptools-18.4-py2.7.egg/pkg_resources/__init__.py", line 1652, in run_script

  File "/home/bee/anaconda/envs/vatic3/lib/python2.7/site-packages/turkic-0.2.5-py2.7.egg/EGG-INFO/scripts/turkic", line 16, in <module>
    turkic.cli.main()
  File "/home/bee/anaconda/envs/vatic3/lib/python2.7/site-packages/turkic-0.2.5-py2.7.egg/turkic/cli.py", line 147, in main
    handler(args[1:])
  File "/home/bee/anaconda/envs/vatic3/lib/python2.7/site-packages/turkic-0.2.5-py2.7.egg/turkic/cli.py", line 47, in __init__
    self(parser.parse_args(args))
  File "/home/bee/Documents/vatic/cli.py", line 48, in __call__
    for frame, image in enumerate(sequence):
  File "/home/bee/anaconda/envs/vatic3/lib/python2.7/site-packages/pyvision-0.3.1-py2.7-linux-x86_64.egg/vision/ffmpeg.py", line 44, in __iter__
    yield self[i]
  File "/home/bee/anaconda/envs/vatic3/lib/python2.7/site-packages/pyvision-0.3.1-py2.7-linux-x86_64.egg/vision/ffmpeg.py", line 30, in __getitem__
    return Image.open(self.getframepath(k))
  File "/home/bee/anaconda/envs/vatic3/lib/python2.7/site-packages/PIL/Image.py", line 2286, in open
    % (filename if filename else fp))
IOError: cannot identify image file '/tmp/pyvision-ffmpeg-983757886/1.jpg'

I've been running into this when the input video file or output directory to the turkic extract command do not exists. Double check those arguments.

I too have the same error and I am able to resolve. I have double checked my arguments and they are correct. Could anyone guide me on what needs to be done?

I also had this error for a bit, then it stopped occurring after I made sure I executed the turkic extract command with the vatic directory as my cwd and provided the full video and output directory paths as input arguments.

I also ran into this problem. After running the extract command the folder /tmp/pyvision-ffmpeg-XXXX/ and /path/to/output/dorectory/ are removed without trace. I tried to run inside vatic folder and using absolute path to input file and output folder but no use.

I just found the solution btw, change the line 4 in ffmpeg.py in pyvision/vision:
from
import Image
to
from PIL import Image
then build and install pyvision again using:
$(which python) setup,py build && $(which python) setup.py install


Refactor Ownership Library for better UX

Type of change

Improvement (refactoring, restructuring repository, cleaning tech debt, ...)

Changes
The following changes have been made:

Swaps the need for declaring ownership in storage for a pre-defined StorageKey to store storage. This results in the following improvements in developer UX as the use of the library was previously very verbose.

Before:
storage {
     owner: Ownership = Ownership::initialized(Identity::Address(Address::from(ZERO_B256))),
}

fn foo() {
     let owner = storage.owner.owner();
     storage.owner.only_owner();
     storage.owner.renounce_ownership();
}

After:
fn foo() {
     let owner = _owner();
     only_owner();
     renounce_ownership();
}

The downside to this approach is the inability to set the owner during compile time and a constructor must be implemented.

Before I review the changes themselves can you elaborate on the technical need for this change?
To me it seems like a subjective change in UX. I think that having the ability to set data at compile time is important and useful. At the same time being able to delay that via a constructor may be useful as well.
Without deeper consideration at this stage I'll await your response and instead superficially propose the idea of having 2 ownership standards. One for configuration and one for construction. That has trade-offs as well but I don't think that's as much of an issue as providing one UX over the other.

This is something I considered, but there are a few caveats to this.

In the future we expect to have the ability to import storage from libraries, thus enabling the ability to set the owner at compile time
With most developers coming from Solidity, a constructor is something they are already accustomed to
If a developer chooses to set the owner at compile time, they can do so using just the SRC-5 standard. This library is intended for convenience and is by no means the only way to implement the standard

I believe the proposed changes make Sway code significantly more readable and less verbose. Having to call storage.owner.my_function() for absolutely everything simply doesn't make sense compared to just the function itself. The trade off being well worth the minor inconvenience of a constructor in turn for easier auditability.


Different logos for JavaScript track throughout site

https://exercism.io/tracks uses "JS" logo
https://exercism.io/my/tracks uses "ES" logo (need to be logged in to see)
https://exercism.io/tracks/javascript uses "JS" logo
https://exercism.io/#explore-languages uses "JS" logo on mobile, "ES" logo on desktop
And they're all different from this one:
https://github.com/exercism/javascript/blob/master/img/icon.png

I'm not sure what the icon within the track is for. I guess the website-icons repo is actually the place to fix the icons used on the site, though. Made a new issue there: https://github.com/exercism/website-icons/issues/21


Fixes planner util getPlansByRosterId to return a single plan. Closes #5335

Fixes planner util getPlansByRosterId to return a single plan. Closes #5335

Thank you for another awesome PR. We will review it ASAP

Merged manually, thank you! 👏


Switch templates from HAML to ERB

Make RailsAdmin have fewer dependencies and so slightly reduce total
installation size.
Align the project with default upstream Rails practices. Starting a new
Rails project includes ERB by default but not HAML. By switching, we
don't pull in additional templating practices beyond what any default
project is already using.
The change may also help encourage contributors. While nearly all Rails
developers have direct experience working with ERB, the same is not
always true of HAML. This removes a small barrier.
Fixes #3173

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-4.7%) to 91.124%

Totals

Change from base Build<PHONE_NUMBER>:
-4.7%

Covered Lines:
3357

Relevant Lines:
3684

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-4.7%) to 91.124%

Totals

Change from base Build<PHONE_NUMBER>:
-4.7%

Covered Lines:
3357

Relevant Lines:
3684

💛  - Coveralls

Let's go with this, thanks!

@jdufresne 🌟


The problem with the code as it exists is that it is impossible to in…

The problem with the code as it exists is that it is impossible to include a pipe literal in a code span in a table! For example, this Markdown is broken:
foo | bar `|` | baz
--- | --- | ---
foo | bar | baz

There are two issues that prevent including pipes in codespans in tables:

Codespans don't support any kind of escaping (this is specified in the original Markdown spec).

Pipe-detection logic in table parsing doesn't care whether a pipe is inside a codespan or not.

(2) is actually desirable, since this allows splitting codespan contents across multiple lines when using the --multiline-tables extension. e.g. we want this to work as expected ("bar baz" being rendered as a codespan for the middle header cell):
| foo | `bar | baz |
:     : baz` :     :
| --- | ---- | --- |
| foo | bar  | baz |

So the solution goes after (1), allowing some limited escaping, only for pipes and colons inside tables.
The solution implemented here is that in tables, literal pipes and colons (in the case of multiline extension rows) must be escaped with a backslash, even in codespans. This escaping backslash is then removed from the text before it is passed to parse_inline to render cell contents.
This allows a simple rule that is easy to understand and implement by a Markdown author: "Any literal pipe on a regular row, and any literal colon on a continued row, must be escaped by a backslash."
An implementation detail is that we replace is_escaped with is_backslashed for pipes/colons in tables. This is a stricter check, since is_escaped will not consider the pipe in "\\|" to be escaped, while is_backslashed will. This is to allow `\|` to render as "|" a literal pipe in a codespan, and `\\|` to render as "\|". (See the added tests for more examples of how this stricter escaping allows greater expressiveness.)
This is not likely to break any existing Markdown, because the only cases to break would be an even number of backslashes directly before a pipe that is intended as a separator, e.g.
foo \\| bar
----- | ---
foo   | bar

This is a really, really rare edge case, that I doubt anyone does intentionally.

Current coverage is 75.76%

Merging #28 into master will increase coverage by +0.12% as of c63af3a

@@            master     #28   diff @@
======================================
  Files           14      14
  Stmts         4102    4126    +24
  Branches         0       0
  Methods          0       0
======================================
+ Hit           3103    3126    +23
  Partial          0       0
- Missed         999    1000     +1

Review entire Coverage Diff as of c63af3a

Powered by Codecov. Updated on successful CI builds.


Create ListExclusionFormPopup component

Release Type: non-breaking feature
Fixes https://x-team-internal.atlassian.net/browse/XP-2928
Description
Creates the ListExclusionFormPopup component which is a clone from xp/ListExclusionForm with some improvements and the popup effect.
Checklist

[x] set yourself as an assignee
[x] set appropriate labels for a PR (In Review or In Progress depending on its status)
[x] move respective JIRA issue to the IN REVIEW column
[x] make sure your code lints (npm run lint)
[x] Flow typechecks passed (npm run flow)
[x] Snapshots tests passed (npm run jest)
[x] component's documentation (.stories.js file) is changed or added accordingly to reflect any new or updated use cases or variants usage
[x] if any snapshots have been changed, verify that component still works and looks as expected and update the changed snapshot
[x] manually tested the app by running it in several different browsers (Firefox, Chrome, Opera, Safari, MS IE/Edge, etc.) and checked nothing is broken and operates as expected!

Steps to Test or Reproduce

run npm start
go to http://localhost:9001/?selectedKind=UI Components%2FListExclusionFormPopup

Impacted Areas in Application

A new UI component ListExclusionFormPopup was created
Included new prop scrollableSidebar at TwoColumnsLayout

Screenshots
Standalone example

Applicant name in the header is fixed
The form is scrollable
The popup have max height of 400px
Clicking on radio buttons will fill up the comment box
Changing comment box to something else will uncheck any radio
Send button is disabled by default and will be enabled once any comment exists

Flexible heigh for big applicant names

Small viewport height

Adjusts popup max height to fit in the viewport
The triangle aligns with the middle of the click target
If the click target is out of the viewport top boundary (including the popup top margin), align the triangle at the top of the popup
If the click target is out of the viewport bottom boundary (including the popup bottom margin), align the triangle at the bottom of the popup

Cancel button and clicking outside hides the popup (the state that handles this effect belongs to parent component or redux)
The scrolling of the element bellow is prevents when the popup is opened (this behaviour relies on the parent/global state and the capabilities of the scrollable component)
Custom top and bottom margins can be provided for the popup (in the demo below its 70px in the top and 10px in the bottom)

Bigger viewport height

By default, the top of the popup will be aligned to the top of click target and the triangle will be aligned to the middle of the click target
If the click target is out of the viewport top boundary (including the popup top margin), align the triangle at the top of the popup
If the click target is out of the viewport bottom boundary (including the popup bottom margin), align the triangle at the bottom of the popup
In the case that the popup can't be aligned with the top of the click target without going out the viewport bottom boundary, align the popup to the bottom of the viewport (popup bottom margin included) and align the triangle in the middle of the click target

Responsiveness demonstration

Maybe we can trim some of the margin-top from the Popup Title, see that the margin-top is bigger than the margin-bottom.

Fixed. The margins was equal but that heading has 1.2 line-height, which adds a bit more space.

The send icon is not centralized, is this how it is supposed to look like ?

Nice catch, that's fixed as well.

I clicked on the very bottom "Click Here #11" that is just barely showing, and the Popup arrow seems to be pointing to the "Click Here #10", I understand the size constrains so maybe we should prevent the user from clicking on a Button that is not showing at least half of it.

About this one, I didn't changed current behaviour. I think what you said makes sense but it's not clear what would be the best solution. I don't like to disable the click event as it could feel like a bug or something strange to happen from the user perspective, but thats just my opinion.
The current logic uses a simple principle, where the triangle is aligned in the edge of the popup when the top of the click target locates above the top of the popup element (the same for the bottom edges if the cases where popup would appear at the bottom boundaries of viewport):

The implementation allows to customise the margins top and bottom of the popup, that margin relates to the viewport, not the scrollable place where the click target is located. Bellow I reduced the top margin from 70px to 50px, the issue you spot happens differently. I mean, it makes to be not an issue anymore, but on other hand it doesn't look so good.

I'm open to suggestions. If everyone feels that disabling the click makes sense, then we need to find a more specific situation where to disable the click:
e.g. when the bottom edge of click target is above of the middle of triangle when the triangle is aligned on the top edge of the popup element, and the same principle for the bottom alignment...
yeah, that can be pretty tricky to accomplish, do we really want to handle such use case?

Yeah, that edge case is quite tricky to workaround. There's always the fact that someone can click on a visible element and resize the screen with the popup opened until the click target go out of the screen. The current implementation differs the two cases:

when the click target is somehow in a good place, the triangle is positioned the the half height of the click target.
when the click target is somehow out of boundaries, the triangle is positioned on the popup edges.

By the way, I was recording the UX mentioned above and I found an issue:
Observe how the triangle jumps when the popup docks to the bottom:

I fixed already, this is how it should be, smooth:

Will send that fix together with the code review changes.

Observe how the popup jumps when it docks to the bottom
Great, that you fixed that, looked much smoother now 👍 What I wanted to say before I read it, that it's very unlikely that somebody will be resizing while working on the app. We don't have many users and it's a very rare case I'd say. Also wanted to suggest to fix in case it was an easy one to deal with.

But, as it's fixed now, great catch 🎉 Looking forward to reviewing the code again once all review notes are addressed and we'll be great to move this forward 😄

What I wanted to say before I read it, that it's very unlikely that somebody will be resizing while working on the app.

Yeah, of course. It's makes more sense if you think about this resizing check as a fast way to test all possible positions and how the calculation results of each case. The bug exposed a wrong variable used in a condition :)

hey @nicksp and @marcoacfilho, I addressed all the code review requests. Please take a look when you have some time. Thanks!


Make datetime usage configurable

Zend Framework as we know is ancient within SS Framework ~3.x. There are several languages I wish to use, but cannot, due to missing Zend locale files located in framework/thirdparty/Zend/Locale/Data/. So while Fluent allows me to add them to fluent.yml, once I select them in the CMS, Zend will complain bitterly.
Fluent is primarily about language translation management within the CMS, but in places, it takes into account locale-specifics, such as in the current scenario, which I believe it should not, or at least it should be configurable.
Language and Locale are (usually) mutually inclusive, but for this module's purpose, perhaps they should be separate? Regardless, the issue reported here is that for my current purposes I only want to deal with Language, ergo I should be able to control whether or not Locale is taken into account.
The following patch to Fluent::install_locale() fixes it for me:
        // Get date/time formats from Zend
        if (self::config()->get('use_datetime')) {
            require_once 'Zend/Date.php';

            i18n::config()->date_format = Zend_Locale_Format::getDateFormat($locale);
            i18n::config()->time_format = Zend_Locale_Format::getTimeFormat($locale);
        }

Stupid fix. I forgot I had hacked core while testing. False positive!


[WIP] CON-4802 Always store remote categories and their relations

For SEM projects is possible to select option "Auto import categories". If it's selected then SwagConnect plugin won't store remote categories and product relations in s_plugin_connect_categories and s_plugin_connect_product_to_categories tables. In the future if merchant uncheck  "Auto import categories" option, Connect category tree will be incorrect. This PR moves storeRemoteCategories function in abstract class. AutoCategoryResolver and DefaultCategoryResolver extend it and both of them will use same functionality.

Coverage decreased (-0.1%) to 34.237% when pulling ab30ef4ffa8e59963f44164f76b9ea20a1298af3 on CON-4802 into 9604d5df19336a2454ba20b07bf12aad6ff29dad on master.

Coverage decreased (-0.04%) to 34.224% when pulling 4cf7a036a2377897060c5d8e8001880b642434fe on CON-4802 into d140fd4c287f3e3e84c621eb2b45d986cd69c24d on master.

Coverage increased (+0.2%) to 34.489% when pulling 9ea2e26717b9c98054de13ea6cfde0f045e0d503 on CON-4802 into d140fd4c287f3e3e84c621eb2b45d986cd69c24d on master.

Coverage increased (+0.2%) to 34.5% when pulling 18efbe96cb5afdf7d1930c40c6e4834879f32a56 on CON-4802 into 675c4a979b3a45833310c371d50ed2f0773e7c87 on master.


Add command line argument to place currency symbol before price

In US dollars, you often put the dollar sign before the price amount, so I've added an option to move the location of the currency symbol.

Thanks for the PR! I have released V1.1.0 containing your changes.


ControllerName validation helper

What type of PR is this?

/kind feature
What this PR does / why we need it:
A utility to check the Controller name validity has been added to apis//util/validation.
Which issue(s) this PR fixes:

Fixes #1410
Does this PR introduce a user-facing change?:

NONE

TBH I don't get the use case. Seems like each impl will make pick controllerName as a constant, and if its invalid they will pick a new one? Not sure why we need a Go helper...

Recently in the Kong implementation, we have had to make it customizable via argument. This helper is meant to validate the controllerName in such a use case.

Yeah it happens, If you request one, the others would be removed from review request.

For the case that people take the controllerName as an argument, having common code to validate seems like a great idea to me.
/approve
I'll leave the LGTM for someone else though.

We're putting this in two places with the same regex. Having copied code is usually not ideal. We recently made changes to share types between v1alpha2 and v1beta1 to reduce some of these copies, I think we should do the same here.

I factorized the regexp and kept only the v1beta1 instance.


Adding naming strategy support

Adds an extension point to allow to pass in custom queue and topic naming strategy. Additionally, fixes issue #79 - multiple badly named extra queues were crated for SQS subscriber.
Added extra Sample project to solution.

@brainmurphy Really curious on the status of this pull request.
Our team is currently using JustSaying, and we are stuck with the same use case, where we need to define custom topic names for different environments.
Either this or #87 would allow us to do it, any idea which one will be eventually be merged back to master?
Cheers!

@Edu115 it is currently possible to override the strategy for generating topic names and queue names. You would need to extend IPublishEndpointProvider and IPublishSubscribtionEndpointProvider for topic names and queue names respectively. Here is an example of how to customise topic name https://github.com/justeat/JustSaying/issues/75#issuecomment-100840888.

@payman81, are you guys still using gitter ?    This PR has been for since 24th Jul, neither approved nor rejected.

@dariusdamalakas - We had some issues with merging this without breaking change on our side. However, we think this is a valid change and we are going to look at this again later this week.

@payman81 , ok, thanks for confirming.  Don't merge it please. It's not up to maintainers to fix broken PRs. I will rebase this, and will update this PR. Will let you know here once this is done.

@payman81 , have rebased this commit. Have a look now. Also, it's been a while since I ran integration tests for this branch. So if you could run all tests and let me know if there are any failing tests, that would be great. Thanks.


Feature request: Python string values

I'm just about to release the first version of mitmproxy with config parsing based on ConfigArgParse. Thanks a bunch for your solid work.
Something we'd find immensely useful is the ability to specify values in key/value pairs as Python strings and triple-quoted multi-line strings, with Python-style escape sequences. This would make the config files for our tools hugely more powerful.
This would require converting the current parser to something more sophisticated. PyParsing has built-in definitions for quoted strings, and implementing the parser in it would not be very much work.
I don't have the bandwidth for this myself, but please let me know if a patch like this would be pulled, and I may get to it some time down the track.

coalesced into #30


Cover Topics page with tests

As an engineer using kafka-ui in production, I would like to have 100% test coverage.
Please add specs to all Topics page components (src/components/Topics)

I think this task should be done after https://github.com/provectus/kafka-ui/pull/1814 cause we already implemented a lot of tests in this one.


[3.2.15, 3.2.16] Mysterious file with no extension created along with jadeite.ERRORS

I noticed a file named jadeite3.2.16 (no extension) in my jadeite directory, and I just deleted one named jadeite3.2.15.
This file contains:
***** Starting Dolphin stack dump at 10:35:02 2/17/2023 *****
***** Ending Dolphin stack dump started at 10:35:02 2/17/2023 *****
***** Starting Dolphin stack dump at 10:35:08 2/17/2023 *****
***** Ending Dolphin stack dump started at 10:35:08 2/17/2023 *****
I think this file should not be created... if it had useful content it should have an extension so I can open it...

The error log path is derived from 1) the image path and 2) the 'errors' extension in Dolphin code File class>>default:extension: However, if the executable file has a . in the image file name prefix then the path is returned without appending the .errors extension.  The image file Jadeite3.2.16.exe has a . in the image file name prefix between 2 & 16.  This might be a bug in Dolphin code.
Jadeite uses the file returned to print header and footer timestamp information but when it dumps information about the error. (See logError:) However, it calls the vm to dump the full stack. The vm does the right thing and appends the .errors extension.  So you end up with two files - one that contains just the headers and footer timestamps and the second with the error dump.


licenseManagementEnabled flag

Can one of the admins verify this patch?

test this please

test this please

test this please


Create generic way of including prefix for standard output emitted from forked processes

Currently when we fork processes during the release the output looks like this (full log):
:api:bintrayUpload - publishing to Bintray
  - dry run: false
  - repository: mockito-release-tools-example-repo
  - version: 0.10.0
  - Maven Central sync: true
:api:bintrayUpload FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':api:bintrayUpload'.
> Could not upload to 'https://api.bintray.com/content/mockito/mockito-release-tools-example-repo/mockito-release-tools-example/0.10.0/org/mockito/release-tools-example/api/0.10.0/api-0.10.0.jar': HTTP/1.1 409 Conflict [message:Unable to upload files: An artifact with the path 'org/mockito/release-tools-example/api/0.10.0/api-0.10.0.jar' already exists]
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1.891 secs
:travisRelease FAILED
FAILURE: Build failed with an exception.
* Where:
Script '/home/travis/build/mockito/mockito-release-tools-example/gradle/cd.gradle' line: 214
* What went wrong:
Execution failed for task ':travisRelease'.
> Process 'command './gradlew'' finished with non-zero exit value 1

We should prefix the standard output from processes that we fork from the build. This way, it should be easier to investigate problems in Travis CI log.
We should also provide custom exception message when forked process fails. The message should hint to the user to investigate the log output with given prefix.
Every forked process should neatly write to the log the exact command line that is executed (including arguments).
We need a way to hide output from commands that can potentially leak secret variables (for example GitHub write token used for push can get exposed when git push fails).

[Gradle] :api:bintrayUpload - publishing to Bintray
[Gradle]   - dry run: false
[Gradle]   - repository: mockito-release-tools-example-repo
[Gradle]   - version: 0.10.0
[Gradle]   - Maven Central sync: true
[Gradle] :api:bintrayUpload FAILED
[Gradle] FAILURE: Build failed with an exception.
[Gradle] * What went wrong:
[Gradle] Execution failed for task ':api:bintrayUpload'.
[Gradle] > Could not upload to 'https://api.bintray.com/content/mockito/mockito-release-tools-example-repo/mockito-release-tools-example/0.10.0/org/mockito/release-tools-example/api/0.10.0/api-0.10.0.jar': HTTP/1.1 409 Conflict [message:Unable to upload files: An artifact with the path 'org/mockito/release-tools-example/api/0.10.0/api-0.10.0.jar' already exists]
[Gradle] * Try:
[Gradle] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
[Gradle] BUILD FAILED
[Gradle] Total time: 1.891 secs
:travisRelease FAILED
FAILURE: Build failed with an exception.
* Where:
Script '/home/travis/build/mockito/mockito-release-tools-example/gradle/cd.gradle' line: 214
* What went wrong:
Execution failed for task ':travisRelease'.
> Process 'command './gradlew'' finished with non-zero exit value 1

We stopped forking Gradle processes from Gradle. Not relevant any more.


QR Scanner is working on Android but not on iOS

The Qr scanner is working on Android but not on iOS, im not getting any error and the camera is opening correctly

Closed as you've posted it in a new issue: https://github.com/mrousavy/react-native-vision-camera/issues/1050

The Barcode scanner to scan PDF417 works on Android but not iOS; no errors, and the camera is opening correctly on both platforms.
"react-native-reanimated": "^2.9.1",
"react-native-vision-camera": "^2.14.0",
"vision-camera-dynamsoft-barcode-reader": "^0.4.3",


[WIP] Use six from pypi

It's no longer reexported from django 3.0

Coverage decreased (-0.4%) to 91.293% when pulling 7c381a110f8679dbc414dda58d0c9093a9824921 on HyreAS:use-pypi-six into 12becb059f49beea2d373b8d58c292863fe21d8a on rhblind:master.


Closed Delegate marshalling

Implement close delegate marshalling.

This PR will have significant merge conflict with my struct marshalling PR. I'll merge that one first and will resolve the merge conflict here.

@yizhang82 @tijoytom @MichalStrehovsky PTAL

Thanks @yizhang82  and @MichalStrehovsky  for the review. I will merge this one.


HashSet implementation

In a trivial case, this should be possible with a HashMap<K, ()> wrapper, which is what I'm doing right now. A nicer API would be handy for this case, though.

Thanks for the suggestion, I'll implement it soon.


Vyper code identified as Python

the language stats for https://github.com/c-protocol/crayon-governance show 100% Python instead of 100% Vyper. Clicking on the stats correctly returns 0 files written in Python.

Looking at the .gitattributes file, there is an override that forces the extension .vy to count as Python:
*.vy linguist-language=Python

If this line is removed, the repo will appear as 100% Vyper in the stats bar. Also note that the when you click on the stats bar, you end up on the search page which doesn't take gitattributes into account.

Thank you very much, Martin. That solved it.
Best regards.
Sent with Proton Mail secure email.
------- Original Message -------
On Thursday, July 13th, 2023 at 12:18 AM, Martin Leduc @.***> wrote:

Looking at the .gitattributes file, there is an override that forces the extension .vy to count as Python:
*.vy linguist-language=Python
If this line is removed, the repo will appear as 100% Vyper in the stats bar. Also note that the when you click on the stats bar, you end up on the search page which doesn't take gitattributes into account.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

My pleasure! You might want to consider closing the issue if it's now solved.


Opening a starter pack from go.bsky.app link takes too long

Describe the bug

As described in title.
To Reproduce
Steps to reproduce the behavior:

Open Bluesky
Tap on a go.bsky.app link that opens up a starter pack

Expected behavior

Shouldn't take very long for the app to realize it needs to show the page
Screenshots

https://github.com/bluesky-social/social-app/assets/148872143/48c17b95-7fcb-4804-b13c-b952420084ad
Details

Platform:  Android
Platform version: 14
Build version: <IP_ADDRESS>; Bundle info: f6b138f70 (prod); Bundle date: 24062702; Platform: android

Additional context

N/A

Ah is this what part of this PR solves? @haileyok
https://github.com/bluesky-social/social-app/pull/4659

Closing
https://github.com/bluesky-social/social-app/commit/91c4aa7c2dc598dd5e2c828e44c0d2c94cf0967d


Update Connect-ExchangeOnline.md

Added Prefix param per email request

Docs Build status updates of commit 01fa6a5:
:clock10: Full build: the average full build time is 12 min(s) 18 sec(s), this is based on the last 1000 build(s) for this repository.

Docs Build status updates of commit 01fa6a5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/powershell-v2-module/Connect-ExchangeOnline.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fixed to wait for all chunks from a request before parsing a method call

https://github.com/baalexander/node-xmlrpc/issues/39
I had an issue, where server parsed a valid method call in two (incomplete) parts into two broken calls. This fixed my issue by concatenating all data chunks from request before parsing the method call.

Thanks @baalexander for pointing to client.js and client-test.js. I'll try to make a new patch with test soon (if not tomorrow, then in a few days) and close this when I'm done.


[Java][DateTime] Port SpanishTime/SpanishTimeZoneExtractorConfiguration from C# to Java

NOTE: This PR is based both on PRs #1077 and #1119 . We'll rebase when the respective branches are merged.

Enable TimeExtractor tests
Port SpanishTimeExtractorConfiguration from C# to Java
port SpanishTimeZoneExtractorConfiguration from C# to Java

@tellarin Branch rebased and build passing.


NodePattern fails extracting node types when presented with nil

Steps to reproduce the problem
Ruby Code:
A short test case for this problem:
pattern = RuboCop::NodePattern.new('(send ($send ...) _method)')
source = 'a' # "(send nil :a)"
node = RuboCop::ProcessedSource.new(source, RUBY_VERSION.to_f, nil).ast
type = pattern.match(node)

Expected behavior
pattern.match(node) returns nil
Actual behavior
pattern.match(node) raises:
NoMethodError: undefined method `type' for nil:NilClass

Test variant that works:
pattern = RuboCop::NodePattern.new('(send $(send ...) _method)')
source = 'a' # "(send nil :a)"
node = RuboCop::ProcessedSource.new(source, RUBY_VERSION.to_f, nil).ast
result = pattern.match(node)
type = result&.type

Why this is relevant:
I'm trying to write a NodePattern that captures the difference between a send and csend.
Workaround:
For now, I can avoid this problem by:

Specifying RuboCop::NodePattern.new('(send $({send csend} ...) _method)') instead of RuboCop::NodePattern.new('(send (${send csend} ...) _method)')
Extracting the node's type based on result.type

RuboCop version
$ bundle exec rubocop -V
0.49.1 (using Parser <IP_ADDRESS>, running on ruby 2.4.1 x86_64-darwin16)

Labelling this as a feature request, as I don't think this is something that was intended to work. 🙂

I'm running into similar error:
The custom cop I'm working on;
        def_node_matcher :sketchup_require, <<-PATTERN
          (send
            (const nil? :Sketchup) :require
            (str $_)
          )
        PATTERN

        def_node_matcher :sketchup_require?, <<-PATTERN
          (send
            (const nil? :Sketchup) :require
            (str _)
          )
        PATTERN

        def_node_matcher :sketchup_extension_new, <<-PATTERN
          (:send
            (:const nil? :SketchupExtension) :new
            _
            (str $_))
        PATTERN

        def_node_search :sketchup_extension_new?, <<-PATTERN
          (:send
            (:const nil? :SketchupExtension) :new
            _
            (str _))
        PATTERN

        def on_send(node)
          if sketchup_require?(node)
            filename = sketchup_require(node)
          elsif sketchup_extension_new?(node)
            filename = sketchup_extension_new(node)
          else
            return
          end
          add_offense(node, location: :expression) unless valid_filename?(filename)
        end

Here are the tests that pass (as expected);
  it 'registers an offense when using `Sketchup.require` with file extension' do
    inspect_source('Sketchup.require("filename.rb")')
    expect(cop.offenses.size).to eq(1)
  end

  context 'SketchupExtension.new' do

    it 'registers an offense when using `SketchupExtension.new` with file extension' do
      inspect_source('extension = SketchupExtension.new("Example", "Example/main.rb")')
      expect(cop.offenses.size).to eq(1)
    end

  end

However, this tests fail with an error;
  it 'does not register an offense when using `require` without file extension' do
    inspect_source('require("filename")')
    expect(cop.offenses).to be_empty
  end

  1) RuboCop::Cop::SketchupSuggestions::SketchupRequire does not register an offense when using `require` without file extension
     Failure/Error: elsif sketchup_extension_new?(node)

     NoMethodError:
       undefined method `type' for nil:NilClass
     # C:3:in `block in sketchup_extension_new?'
     # C:2:in `sketchup_extension_new?'
     # ./lib/rubocop/sketchup/suggestions/sketchup_require.rb:47:in `on_send'
     # ./spec/rubocop/sketchup/suggestions/sketchup_require_spec.rb:38:in `block (2 levels) in <top (required)>'

It seems odd to me if that's expected to raise an error. If it is, what would be recommended to check for these various method signatures I'm trying to match?
$ bundle exec rubocop -V
0.53.0 (using Parser <IP_ADDRESS>, running on ruby 2.4.3 i386-mingw32)

Hm.. re-reading the original post closer I'm wondering if my issue isn't exactly the same. I'm not trying to match type, but method signature...

I'm on it...

Bug summary: the matcher would raise an error if most types of node matching / capturing / ... is attempted on a literal instead of an RuboCop::AST::Node.


Add a release version script for the Python SDK

PR Checklist

[X] A description of the changes is added to the description of this PR.
[ ] If there is a related issue, make sure it is linked to this PR.
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added or modified a feature, documentation in docs is updated

Description of changes
Adds a release version script to protect against typos and ensure that we're releasing intended versions to PyPI / TestPyPI after generating the library code via the OpenAPI generator call.


Add dataloaders

How do I load this dataset ?

in python, R, JS, go, Matlab
in a notebook
on a small server with little RAM
just a sample

etc. etc.

Done: https://vinzeebreak.github.io/dafter-loader/


AddAdminNote API for user moderation

Closes #4296
This implementation treats a new field on User (admin_note) as an append-only log that prefixes plaintext with a timestamp and the id and username of the superadmin that logged it.
This feature is intended to detail any relevant notes for moderation, like the reason behind banning users. Because of this, we tie it to the BanUser endpoint as well.

Backend checklist

[x] Formatted my code by running autoflake --exclude src/proto -r -i --remove-all-unused-imports src && isort . && black . in app/backend
[x] Added tests for any new code or added a regression test if fixing a bug
[x] All tests pass
[x] Run the backend locally and it works
[x] Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

@aapeliv I had the same issue I encountered implementing the event notifications feature last year where the generated migration included hundreds of lines unrelated to the minor change I created. I deleted those lines from the migration so that it is as simple and relevant as possible, but just wanted to flag that again.

Thanks for doing this!!! 🙏 It's a big help for the safety and trust team!


'go get' fails (error inside)

Hi Cadance team!
I and a coworker are seeing an issue on just about any machine we try when we attempt to run the 'Developing Cadance' instructions, specifically the first command, go get github.com/uber/cadence/....
The error text is at the pastebin here.
I've tried this on a Windows7, CentOS, and arch linux box; my coworker had the issue on a Windows 10 box.
The go version we're using on windows is from the golang download page:
$ go version
go version go1.10.1 windows/amd64

and is being run inside a cygwin environment, in which we've installed make. My machine has git version 2.17.0.
The arch box I'm using has go 1.9.2 installed, and git version 2.16.1; the centOS box has go 1.9.4, and git 1.7.1.
The arch box is on a separate (home) network from the other boxes.
Let me know if there's anything else I can provide that will help.
Thanks!
Marshall
Edit:
If I attempt the following command make copyright, the command succeeds; if I then try make bins, it fails with the error:
$ make bins
go get './vendor/go.uber.org/thriftrw'
package github.com/uber/cadence/vendor/go.uber.org/thriftrw: cannot find package "github.com/uber/cadence/vendor/go.uber.org/thriftrw" in any of:
        /usr/lib/go/src/github.com/uber/cadence/vendor/go.uber.org/thriftrw (from $GOROOT)
        /home/me/go/src/github.com/uber/cadence/vendor/go.uber.org/thriftrw (from $GOPATH)

The vendor directory, meanwhile, is empty, I'm guessing because of the failure of the get.

Sorry,
It looks like go get got broken by some external dependency.
I've updated the instructions to use git clone instead. Try the new ones:
https://github.com/uber/cadence/pull/690

No problem! The issues I've mentioned no longer pop up. I'll need to grab glide to confirm the full build works. Thanks for the help!

Those issues are confirmed gone, though it now looks like make fails with:
go get './vendor/go.uber.org/thriftrw'
go get './vendor/go.uber.org/yarpc/encoding/thrift/thriftrw-plugin-yarpc'
/bin/thriftrw --plugin=yarpc --pkg-prefix=github.com/uber/cadence/.gen/go/ --out=.gen/go idl/github.com/uber/cadence/cadence.thrift
make: /bin/thriftrw: Command not found
make: *** [Makefile:37: .gen/go/cadence/cadence.go] Error 127

The vendor/thrift directory is present, and populated;  Seems like the package isn't being placed in the path (should I have it installed separately?). Thanks!

have you set GOPATH? If not you can try setting GOPATH before running it.
https://github.com/golang/go/wiki/GOPATH

The GOPATH is set, yup.

I found that you have to run "glide up" before running "make bins".
Can you pull the latest commit and try again?

I pulled the latest commit and tried again after running glide up; same issue. I think you're correct in that the GOPATH isn't set, at least when the makefile is being run; I'm digging around in how to find out whether that env var is set in the makefile.

 It updates the dependencies in a rather random way. Run glide install which just installs the dependencies according to the glide.lock file.

@mfateev - Thanks! I ran glide install, then reran GOPATH=$GOPATH make, but still received the same error log as before.

Ha!
cd $GOPATH/src
cp -r github.com ../
GOPATH=$GOPATH make`
```

did it - the tests are now running.

Weird. Here is the output from my environment:
$ echo $GOPATH
/Users/maximfateev/external
$ pwd
/Users/maximfateev/external/src/github.com/uber/cadence

Gotta echo your 'weird' here. At this point, I'm going to chalk needing to copy things up to PEBKAC. I'll be working with my coworker next week, so I'll end up running through again, and I'll report if we run into any other issues. This can probably be closed - thanks again for the help!

I"m going to update Makefile to include linter. For now just run this command:
go get -u golang.org/x/lint/golint


GPU 3D lut transform causes banding

I'm using 3d luts that span a large dynamic range and need trilinear interpolation for correct results (I'm happy to provide details of my use case if that's helpful).
Due to the nature of the luts, they should provide sufficiently accurate results even at relatively low lut resolutions.  However, much to my surprise there is significant banding when applied by OCIO on GPU:

The only way to mitigate this is to crank the lut resolution extremely high, and even then especially dark colors exhibit some subtle banding.  The results by CPU, on the other hand, are correct even with the low resolution lut:

Looking into OCIO's source, this seems to be the culprit:
https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/b00877959f4497f9b8e5a08859d0ef8059fdd8e5/src/OpenColorIO/ops/lut3d/Lut3DOpGPU.cpp#L221-L236
It's even noted in the comment that this can be an issue on some GPUs.  For the record, I'm using an nVidia RTX 3060.  So not exactly niche.
I think it would make sense to replace the sampleTex3D() call with hand-written trilinear interpolation code, to ensure that it executes with full floating point precision and gives correct results on all platforms.  It might be a small perf hit, but for something like OCIO I suspect correctness and consistency is more important here.
Would a PR along those lines be accepted?

Any thoughts/feedback about this?  This is a significant problem for the work that I'm doing with OCIO, and I'd like to see it fixed.
I'm happy to do the leg work, but just want to double-check that the proposed solution is acceptable first.

Hi @cessen , apologies for the delayed reply.  Yes, that's a pretty shocking amount of banding in the first image.  It looks like maybe you're applying a 3d-LUT to a linear color space encoding?  If so, the banding is probably only one of several problems you will encounter.  The best practice is to convert to a log-encoded (or at least gamma-encoded) color space before applying a 3d-LUT.
In practice, OCIO users tend to be using 3d-LUTs that are a minimum of 16x16x16 (and typically larger) and being fed with log-encoded data.  So the quantization of the fractional component has not been an issue.
I agree that your proposal of writing a trilinear interpolation shader would work around the problem.  (This is what we've done for tetrahedral interpolation already.)  However, it seems that there is a risk of introducing performance regressions by not using the built-in GPU trilinear interpolation.  Tests would ideally need to be done on a variety of graphics cards (old and new) and a range of 3d-LUT sizes to validate that performance was not impacted.
While we thank you for volunteering, we won't agree in advance to accepting a PR for this.  We would need to see experimental results covering a sufficiently broad set of use-cases.  Almost certainly there will be some speed penalty and at that point it will be a judgment call about whether the improvement in quality for this edge case warrants the overall performance reduction.  This is something that would likely be decided by the project's steering committee.

@doug-walker Thanks for the thorough reply!

While we thank you for volunteering, we won't agree in advance to accepting a PR for this.

Yes, of course.  I just wanted to confirm that it wasn't out of the question for some reason.  I manage some open source projects myself, and have received PRs that I had to reject due to the scope and goals of the project, and I often wish people would ask ahead of time before putting in the work.

However, it seems that there is a risk of introducing performance regressions by not using the built-in GPU trilinear interpolation. Tests would ideally need to be done on a variety of graphics cards (old and new) and a range of 3d-LUT sizes to validate that performance was not impacted.

Yeah, I suspected that might be the case.
It occurs to me that an alternative might be to introduce another interpolation mode.  Something like INTERP_LINEAR_PRECISE, for use cases where guaranteed full precision is needed.

It looks like maybe you're applying a 3d-LUT to a linear color space encoding?

Although there are certainly cases where we would like to apply smaller LUTs in a linear color space, we've been able to work around that by using higher resolutions LUTs and applying them in non-linear color space encodings, as you mentioned.  I don't want to completely downplay this, however, because it does mean we have notably higher-res LUTs than needed for the actual transforms we want to do (which is annoying, as the size grows with the cube of the resolution) and it forces those transforms to have otherwise unnecessary log encoding/decoding steps (which performance-wise aren't free either).  So this is certainly one of the use cases we'd like full-precision interpolation for.  But it's not the main reason that I opened this issue.
An example of the kind of use case where this is more of a problem is working with HDRIs.  Unlike footage from principal photography, HDRIs can have a (potentially huge) dynamic range that isn't bounded in advance.  So to be conservative and avoid accidental clipping, a 3D LUT intended for HDRIs needs to have a huge extent.  Even using a nonlinear color space encoding, LUTs with such extents can still exhibit banding with the current GPU interpolator.
To further exacerbate things, a standard RGB LUT of such large extent doesn't have enough chroma resolution at the low end to do meaningful color transformations.  We've solved this by constructing our LUTs to be applied in OCIO's variant of HSV space, so that it has the same chroma resolution at all luminance levels.  And that's why tetrahedral interpolation doesn't solve the issue for us, because tetrahedral isn't appropriate for HSV-like spaces and produces strange results.  Additionally, you only want the V channel to be log encoded in that case, but the various log transforms in OCIO don't support selective application to single channels.  So we're stuck with ExponentTransform and friends for our non-linear encoding, which exacerbates the problem even further.
We could work around this by e.g. applying the color transform ahead of time via the CPU path and saving to an EXR.  But we have other use cases with similar issues, where that kind of thing is harder/more obnoxious to do.
So that's the practical thing we're running into.
From a user expectations side, it additionally just feels strange that the CPU and GPU path can diverge in their results by that much.  In something like OCIO I would expect the GPU path to be faster, but not lower quality.

Thanks for elaborating on the use-case.
I don't think adding INTERP_LINEAR_PRECISE is the best solution.  It seems more like an optimization setting than an interpolation method.  Take a look at the OptimizationFlags in OpenColorTypes.h.  What do you think about the approach of adding a new setting OPTIMIZATION_NATIVE_GPU_TRILINEAR to turn this on and off.  It should be off for OPTIMIZATION_LOSSLESS but on for OPTIMIZATION_VERY_GOOD or higher.  It would be similar to OPTIMIZATION_FAST_LOG_EXP_POW in the sense that it's controlling the evaluation method rather than the steps used to reduce the number of ops.
That way, by default people will continue to get the current behavior but could opt in to your shader if desired.  I think that would lower the amount of performance testing required, since it would not be used by default.  However, if we could get enough performance testing done, it could potentially be deployed beyond the LOSSLESS setting.

What do you think about the approach of adding a new setting OPTIMIZATION_NATIVE_GPU_TRILINEAR to turn this on and off. It should be off for OPTIMIZATION_LOSSLESS but on for OPTIMIZATION_VERY_GOOD or higher.

I think that's an excellent way forward.  That will also make it a little easier to do the performance testing, and for other people to join in if desired, since it won't need a custom branch.
I'll work on putting together a PR for that the next chance I get.
Thanks so much!


Dependencies are not resolvable

Dependencies in requirements file cannot be resolved. First there is no dependency python==3.10; this is already defined by the creation of the conda environment
julez@julez-t14:~/workspace-python/Simple-German-Corpus$ conda activate simple-german-test
(simple-german-test) julez@julez-t14:~/workspace-python/Simple-German-Corpus$ pip install -r requirements
ERROR: Could not find a version that satisfies the requirement python==3.10 (from versions: none)
ERROR: No matching distribution found for python==3.10

Next pytorch 1.10.2 is not compatible with Python 3.10 (torch 1.10.2 requires Python <3.10):
(simple-german-test) julez@julez-t14:~/workspace-python/Simple-German-Corpus$ pip install -r requirements
...
Collecting sentence-transformers==2.2.2
  Using cached sentence_transformers-2.2.2-py3-none-any.whl
ERROR: Ignored the following versions that require a different python version: 1.6.2 Requires-Python >=3.7,<3.10; 1.6.3 Requires-Python >=3.7,<3.10; 1.7.0 Requires-Python >=3.7,<3.10; 1.7.0rc1 Requires-Python >=3.7,<3.10; 1.7.0rc2 Requires-Python >=3.7,<3.10; 1.7.1 Requires-Python >=3.7,<3.10
ERROR: Could not find a version that satisfies the requirement pytorch==1.10.2 (from versions: 0.1.2, 1.0.2)
ERROR: No matching distribution found for pytorch==1.10.2

Hey, I run to the same issues.
"pytorch" is now "torch" and Python don't need to stand in the requirements ,because you install it with you Environment. Then I needed to delete all the "==*"
After that it worked.

Hi, my recent commits should resolve the issues concerning the requirements file


(backport) Update regions for AKS and add attribution

Backport: https://github.com/rancher/kontainer-engine/pull/167

lgtm


How do I use it

@lengyao88 it might help to provide some more information about what you have tried, what hasn't worked for you, and what kinds of error messages you have received.

How can I run this?
$ rake
rake aborted!
cannot load such file -- bundler/setup
/home/pactual.net/tomigaca/github/kanban/config/boot.rb:3:in `<top (required)>'
/home/pactual.net/tomigaca/github/kanban/config/application.rb:1:in `<top (required)>'
/home/pactual.net/tomigaca/github/kanban/Rakefile:4:in `<top (required)>'
(See full trace by running task with --trace)

$ ruby --version
ruby 2.0.0p648 (2015-12-16) [x86_64-linux]
$ gem install bundle -v 1
$ bundle install
$ rake
/usr/local/share/gems/gems/bundler-1.0.0/lib/bundler/shared_helpers.rb:3:in `<top (required)>': undefined method `source_index' for Gem:Module (NoMethodError)
        from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
        from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in `require'
        from /usr/local/share/gems/gems/bundler-1.0.0/lib/bundler/setup.rb:1:in `<top (required)>'
        from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:135:in `require'
        from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:135:in `rescue in require'
        from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:144:in `require'
        from /root/kanban/config/boot.rb:3:in `<top (required)>'
        from /root/kanban/bin/rake:2:in `require_relative'
        from /root/kanban/bin/rake:2:in `<main>'

Was able to run till the command rake succeeded.. but now what..
$ rake
...
...
Top 5 slowest example groups:
  Board
    0.29659 seconds average (0.59317 seconds / 2 examples) ./spec/models/board_spec.rb:19
  Api::BoardsController
    0.09267 seconds average (0.92668 seconds / 10 examples) ./spec/controllers/api/board_controller_spec.rb:4
  Card
    0.02719 seconds average (0.08158 seconds / 3 examples) ./spec/models/card_spec.rb:23
  User
    0.02483 seconds average (0.14897 seconds / 6 examples) ./spec/models/user_spec.rb:22
  List
    0.01541 seconds average (0.04624 seconds / 3 examples) ./spec/models/list_spec.rb:20

Finished in 1.94 seconds (files took 8.21 seconds to load)
24 examples, 0 failures, 2 pending

Randomized with seed 51671

also
yum -y install postgresql-server postgresql-contrib
# setup proper username passwrd in config/database.yml
postgresql-setup initdb
systemctl start postgresql

su - postgres
createuser --interactive --pwprompt # create root role
createdb -O root kanban_production
createdb -O root kanban_test
createdb -O root kanban_development

then...
rails s -b <IP_ADDRESS>

how can i login now..

Started GET "/api/users/current" for <IP_ADDRESS> at 2019-08-08 23:56:32 -0400
Cannot render console from <IP_ADDRESS>! Allowed networks: <IP_ADDRESS>, ::1, <IP_ADDRESS>/<IP_ADDRESS>
Processing by Api::UsersController#current as JSON
Filter chain halted as :require_login rendered or redirected
Completed 401 Unauthorized in 1ms (Views: 0.3ms | ActiveRecord: 0.0ms)

cannot believe i actually had to..
gem install bcrypt
run file |
require 'bcrypt'

my_pwd = BCrypt::Password.create("your_password")
puts my_pwd

then insert into postgre
insert into users (email,password_digest) values ('root', 'pwd')


properly test conflict error headers

We recently found out that the header of our error messages are not properly working. On Chrome and Safari, for a Conflict error chaise was showing the default Terminal Error header. I fixed this issue in ermrestjs and this PR is just to make sure Chaise is properly testing the header.
The actual change was just two lines, but since I added a new chaise.page.js function, I refactored the code a little bit.
This PR was created mainly to make sure e2e workflow is working as expected.
P.S. I also realized that this test case doesn't work. It's expecting an error while it shouldn't. I modified the given input to make sure it's invalid and test case passes.

As part of this I did #1947 as well since that change only required making sure test cases are passing.


Fix get_workspace_status for Jenkins

The builds done with Jenkins were marked as dirty. The reason was that we update the tools/bazel.rc with the content of tools/bazel.rc.jenkins. Version stable-70699be of fixes that. Update pipeline to build istioctl first.

Jenkins job manager/presubmit passed

Jenkins job manager/e2e-smoketest passed

Jenkins job manager/presubmit passed

Jenkins job manager/e2e-smoketest passed


Minting New Shares results in Error

Feature
Issue DAO Token Proposal
App

Admin

Expected Behavior
Issue new voting shares in goerli v3 DAO.
Actual Behavior
All entered fields in form appear to be correct. When clicking submit, the error as seen in screen shot below appears.
Unable to submit proposal.
Steps to Reproduce

Click Proposals
Click New Proposal
Click Issue DAO Tokens
Fill Out All Fields of Form
Click Submit
Recv Error

https://admin.daohaus.fun/#/molochv3/0x5/0x9310c1b1005f733da41e54699132cde232a6a849/new-proposal?formLego=ISSUE
Browser
Chrome
Screenshots and Context
DAO Address: 0x9310c1b1005f733da41e54699132cde232a6a849
Screenshot of error

Reproduction:
All required fields filled out, incl "0" in  Non Voting Tokens requested

Same result:

I was unable to reproduce this error

https://goerli.etherscan.io/tx/0x8f4055a9a4a3b17990cbe71e76d353a464789686cc24177d9841e49c68149951

Cannot replicate


Simplify README by making it point to RTD.

Documentation has been ported to RTD.

@jaagut thanks for the review and the suggestions!


Root Array decoding to typealiased Array

Howdy, first I wanted to say thanks so much for this library - we are getting a huge amount of use out of it.
We're hitting a third party API that is returning a root array much like how you have in your test suite.  Currently, we are typealiasing the plural of the Model like so:
struct Person . . .
typealias People = [Person]

My question is, is there an easy to way to decode into this?  We haven't been able to figure it out syntactically yet.  For the Person type, the syntax goes like this
 if let j: AnyObject = body {
                let value = JSONValue.parse(j)
                let person = Person.decode(value)
                callback(.Success(Box(person)))
            }

We even tried giving up on the typealias People = [Person] and used a simple struct w/ one data type and the JSONDecodable extension, but I just can't quite grasp how the global decode function works - Swift 1.2 is most certainly not a fan, claiming it can't find it.
Thanks!

@penland365 Hello, What version of Argo are you using? The global decode function might not be available in your version. If it is, you should be able to decode the json into the array like so:
let people: People? = decode(j)
The decode function takes the AnyObject and returns the decoded type/types, which, in this case, is People or [Person]. If that isn't working for you, would you mind posting more code around the issue so I can see what might be wrong?

Hi @tonyd256  - I'm currently on Using Argo (0.4.3) according to my Podfile - what version do I need to be at?

Hmm, this may be a cocoa pods issue, I'm not sure - decode.swift is in the project, but Swift swears by all the compiler gods that it cannot find it.  decode is the only thing I haven't been able to find however.

Can you share your podfile? ( Or at least the relevant line?)

On Apr 13, 2015, at 18:26, Jeffrey N. Davis<EMAIL_ADDRESS>wrote:
Hmm, this may be a cocoa pods issue, I'm not sure - decode.swift is in the project, but Swift swears by all the compiler gods that it cannot find it. decode is the only thing I haven't been able to find however.
—
Reply to this email directly or view it on GitHub.

platform :ios, '8.0'
use_frameworks!

target 'jonah' do
  pod 'Argo'
end

target 'jonahTests' do
  pod 'Argo'
end

I've excluded additional pods, but that's the meat of it.  That could be wrong format - I'm a Scala guy dipping in to another world here.  But I do have access ( and do use ) most if not all of the operators in both JSONOperators.swift and Operators.swift

A bit more information - I tried running off of master w/ the following:
platform :ios, '8.0'
use_frameworks!

target 'jonah' do
  pod 'Argo', :git => 'https://github.com/thoughtbot/Argo.git'
end

target 'jonahTests' do
  pod 'Argo', :git => 'https://github.com/thoughtbot/Argo.git'
end

In this case, I can see the decode.swift file:

The compiler is still confused however and it can't see it.

  I'm being told that no such module Box has been found in the file Decoded.swift

You really shouldn't be pointed at master. We'd rather you point at a specific release.
The reason you aren't finding Box is because it hasn't been added to the Podfile

RIP penland365, stung by a build tool.

Hahaha. Glad that helped, sorry it took so long to get there.


Docker 1.8.1 pull image failed from Registry 2.1.1 with auth service

Before upgrade to 2.1.1 I have a registry 2.0.1 with auth service and a lot of images has been pushed by engine 1.6.0.
Now I upgrade the registry to 2.1.1 with same s3 bucket as storage backend and upgrade engine to 1.8.1. Then I pulled an image already exists in registry
$ docker pull index.registry.io/library/ubuntu
Using default tag: latest
Pulling repository index.registry.io/library/debian
Error: image library/debian:latest not found

However when I changed engine to 1.7 and 1.6,  all works well.
The registry logs is here
{"log":"time=\"2015-08-17T04:49:01.662509793Z\" level=debug msg=\"authorizing request\" environment=development http.request.host=index.alauda.io http.request.id=45bdfc33-9f57-4baa-8b68-77f90591123c http.request.method=GET http.request.remoteaddr=<IP_ADDRESS> http.request.uri=\"/v2/\" http.request.useragent=\"docker/1.8.1 go/go1.4.2 git-commit/d12ea79 kernel/3.13.0-61-generic os/linux arch/amd64\" instance.id=d6001a7d-5591-4a3a-b92c-859cd0bff5e8 service=registry version=v2.1.1 \n","stream":"stdout","time":"2015-08-17T04:49:01.662602139Z"}
{"log":"time=\"2015-08-17T04:49:01.662991156Z\" level=warning msg=\"error authorizing context: authorization token required\" environment=development http.request.host=index.alauda.io http.request.id=45bdfc33-9f57-4baa-8b68-77f90591123c http.request.method=GET http.request.remoteaddr=<IP_ADDRESS> http.request.uri=\"/v2/\" http.request.useragent=\"docker/1.8.1 go/go1.4.2 git-commit/d12ea79 kernel/3.13.0-61-generic os/linux arch/amd64\" instance.id=d6001a7d-5591-4a3a-b92c-859cd0bff5e8 service=registry version=v2.1.1 \n","stream":"stdout","time":"2015-08-17T04:49:01.663031222Z"}
{"log":"<IP_ADDRESS> - - [17/Aug/2015:04:49:01 +0000] \"GET /v2/ HTTP/1.1\" 401 114 \"\" \"docker/1.8.1 go/go1.4.2 git-commit/d12ea79 kernel/3.13.0-61-generic os/linux arch/amd64\"\n","stream":"stdout","time":"2015-08-17T04:49:01.663259933Z"}
{"log":"time=\"2015-08-17T04:49:01.929582117Z\" level=debug msg=\"authorizing request\" environment=development http.request.host=index.alauda.io http.request.id=cc6a18d0-7674-45d9-879f-49b383c9bf28 http.request.method=GET http.request.remoteaddr=<IP_ADDRESS> http.request.uri=\"/v2/\" http.request.useragent=\"docker/1.8.1 go/go1.4.2 git-commit/d12ea79 kernel/3.13.0-61-generic os/linux arch/amd64\" instance.id=d6001a7d-5591-4a3a-b92c-859cd0bff5e8 service=registry version=v2.1.1 \n","stream":"stdout","time":"2015-08-17T04:49:01.929642181Z"}
{"log":"time=\"2015-08-17T04:49:01.929947752Z\" level=warning msg=\"error authorizing context: authorization token required\" environment=development http.request.host=index.alauda.io http.request.id=cc6a18d0-7674-45d9-879f-49b383c9bf28 http.request.method=GET http.request.remoteaddr=<IP_ADDRESS> http.request.uri=\"/v2/\" http.request.useragent=\"docker/1.8.1 go/go1.4.2 git-commit/d12ea79 kernel/3.13.0-61-generic os/linux arch/amd64\" instance.id=d6001a7d-5591-4a3a-b92c-859cd0bff5e8 service=registry version=v2.1.1 \n","stream":"stdout","time":"2015-08-17T04:49:01.929989833Z"}
{"log":"<IP_ADDRESS> - - [17/Aug/2015:04:49:01 +0000] \"GET /v2/ HTTP/1.1\" 401 114 \"\" \"docker/1.8.1 go/go1.4.2 git-commit/d12ea79 kernel/3.13.0-61-generic os/linux arch/amd64\"\n","stream":"stdout","time":"2015-08-17T04:49:01.930177444Z"}

Engine info is attached below. I wonder if there is some change in the auth mechanism implementation in engine side leads to this.
$ docker version
Client:
 Version:      1.8.1
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   d12ea79
 Built:        Thu Aug 13 02:35:49 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.8.1
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   d12ea79
 Built:        Thu Aug 13 02:35:49 UTC 2015
 OS/Arch:      linux/amd64

What kind of "auth service" are you using?

@dmp42 We implement a  token serve to control the access of registry

@oilbeater can you investigate that home grown service then?
Your registry logs are screaming about an error there.

@dmp42 I might find out the reason. As #15640 mentioned, docker 1.8.1 will ask for both push and pull privilege when pulling an image. My auth server denied the access request, which cause the error not found.
I will modify my auth server to check my guess. However I still wondering why a pull request will ask for push right.

@oilbeater thanks for referencing. I have been wondering if this was a change in 1.8.1 but didn't have the opportunity to check it out.

@oilbeater @deitch quoting dmcg: "This is the intended behavior. It is the responsibility of the token server to return a token with at most the requested scope and possibly less."
Let me know if this can be fixed.

@dmp42 from the perspective of token server,it should do like this.However from the view of docker engine ask push privilege when pulling an image is not reasonable, I'm not sure if this behaviors has changed since 1.8.
My question has been resolved, feel free to close it.

Thanks @oilbeater.
I'll make sure we look into why the engine behavior changed, and add more tests so that both the specs is clearer and unsuspected changes don't happen in the future.
Thanks all for your feedback on this.

I left more comments on the other issue https://github.com/docker/docker/issues/15640 but in short, I agree with @oilbeater that

This is not the optimal implementation. The previous one made more sense.
Either way, though, the documentation needs to make it really clear, so token implementers have what to rely upon.

I did offer to make a PR for the documentation on the other issue, but I have some open questions. As soon as those are answered, I will make the documents and create a PR.

@deitch agreed.
Looking forward to "fixing" this.


Update fuzzel-1.5.1.ebuild to fuzzel-1.6.5.ebuild

Update fuzzel-1.5.1.ebuild to fuzzel-1.6.5.ebuild.
As can be seen in https://codeberg.org/dnkl/fuzzel/commit/66b5afc71051e25ad95cf0be7cfeb847b0a98d2c , meson build flags changes from enable-{png,svg}=disabled to {png,svg}-backend=none.

Thanks!


Log when we open and close a session

https://kolmafia.us/threads/log-when-a-client-session-starts-and-ends.29143/
The biggest usecase of this for me currently, is to figure out when mafia exited abnormally and try to recover the player state from that, ignoring the remainder of the file. Such as recovering daily preferences.
Its also a bit weird that there's nothing definite indicating when a session started or ended.

This is for https://github.com/s-k-z/kolfix? Seems reasonable.


fix an issue with logging ios simulator output

Fix the last bit of https://github.com/flutter/flutter/issues/1652; in atom you'd see:
Logging for iPhone 6s...
Error listening to iPhone 6s logs.

when running against the ios simulator. This makes our log clearing logic a little more friendly to the simulator.

LGTM


bump link check action version

Description
Bump link checker action version
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Let's fix the CI/CD for those other failures before merging more?

Let's fix the CI/CD for those other failures before merging more?

This is one of the fixes as link checked fails in the dependency update PRs. Or do you want one larger PR to fix all CI issues?

Let's fix the CI/CD for those other failures before merging more?

This is one of the fixes as link checked fails in the dependency update PRs. Or do you want one larger PR to fix all CI issues?

Yeah I saw this elsewhere, thanks. Merged this one.


stats: Remove hourly data from messages sent over time.

Removes hourly data tab to enable speedup of the stats page.
Fixes #6564.

@nalinbhardwaj thanks for working on this, and sorry for the slow reply!
@rishig can you review this?

This looks great, @timabbott ready to merge on my end.
Thanks again @nalinbhardwaj, and sorry for the long delay!

Merged, thanks @nalinbhardwaj!


Feat/change fact load

What?
add function and change how the fact table is uploaded form the transformed csv files.
Why?
Replace was being use don conflict, this meant that the facts present in the fact table were not the most recent version of the facts due to their being no ordering within the files. The new function is only relevant for the fact table.

It looks like we also already have a test called test_package_dataset.py.
Is it possible to merge these (I haven't looked in detail at what test_package_dataset.py does) and remove the package sub directory test package that test_dataset is in?  I'm not sure we need another directory (package), so my vote would be flatter. i.e. test -> integration -> load of tests.
However code itself looks reasonable and good to go apart from my pedantic comment on your doc string.

Oh and yes run lint and black.

I'm keen on structuring the unit tests and integration tests on the code repository itself i.e. all tests that are testing the classes and methods in the package > dataset.py should be in the files package > test_dataset.py. Happy to be overruled but it should help when adding new tests as it's easy to find the tests that already exist etc.

👍🏼 merge away once black and lint


Implementation for Issue#1120

Part 1) The inaccuracy when calculating the geopoints textual representations: In the geopoint class the new DDD, DMM and DMS type handle the conversions and are responsible for rounding to respect the precision needed.
Part 2) During editting a waypoint the changed value is stored temporary. So it can be used for subsequents calls for edit.
There are new testcases for geopoint conversion.

Somebody rebase, please. :D

Please do not merge upstream in your branch (except for the case, that your pull request is shown as "can no longer be merged automatically"). That is not necessary for integrating your branch into master and it is also not necessary for checking whether or not your feature is working correctly.
I'll try rebasing the changes.

I cherry-picked the two interesting commits and put them on master. I hope that was correct, at least I did not yet do that. :)


Swapchain textures should be write-only

Currently we allow you to sample from a swapchain texture, but this prevents certain display driver optimizations. Any "sample from the swapchain" scenarios can be easily worked around by rendering to an RT and blitting that to the swapchain instead, so let's just disallow swapchain reads.

Resolved by #191


[ja] translate content/ja/docs/setup/production-environment/tools/kops.md into Japanese

This is a Feature Request
What would you like to be added
Translate content/ja/docs/setup/production-environment/tools/kops.md into Japanese (URI: https://kubernetes.io/ja/docs/setup/production-environment/tools/kops/)
Why is this needed
content/ja/docs/setup/production-environment/tools/kops.md exists, but it is written in English. It seems necessary to translate this into Japanese.
Comments
/language ja
/area localization
/help
/good-first-issue

Since the file (and the Japanese index) already exists, it seems like a good first issue.
If you feel otherwise, feel free to remove some labels (as the PR might become a bit too large for the first contribution).

/triage accepted
/remove-good-first-issue

/assign


System. Drawing. Common does not support webp

I hope GDI can support webp

I see WebP here: https://docs.microsoft.com/windows/win32/gdiplus/-gdiplus-constant-image-file-format-constants.
I don't see it here: https://docs.microsoft.com/dotnet/api/system.drawing.imaging.imageformat. Looks like it hasn't been updated.
If you are using .NET 6, you could make a request at https://github.com/dotnet/runtime

There is imageformat.webp, but images do not open. And it's said webp won't be supported.
https://github.com/dotnet/runtime/issues/76237


How to disable minification and uglification?

Hello!
How can I disable minification and uglification in resulting bundle altogether?
(It's required for debugging purposes. The resulting code is intended to run in special secured environment, not regular browser, and source mapping doesn't work as expected there)

remove the Uglify plugin from /build/webpack.prod.conf.js

@LinusBorg, excuse me, please, I created an issue in a wrong project...
https://github.com/vuejs-templates/webpack-simple/issues/137


click on filenames to edit

if possible,  when click on filenames >  go to file editor. I get myself always downloading files by mistake

And what you can propose for downloading files? Not all files are editable.

click on filenames > go to file editor.
click on the icon under actions to download.

click on filenames > go to file editor.
click on the icon under actions to download.

Seems really illogical to me.

I would make it optional or left it as it is. Many users got used to already existing behaviour. I can remove any actions, including action column and bring all functionality to popup menu?

Closing due to inactivity.

Dreams come true, get version 1.1.0

Wow. Im loving it.


September 2024 flowtiles

Summary

Ran gage-conditions-gif and edited vizDates in viz_config.yml for September followed by googledrive::drive_auth() & source('helper_fxns_pipeline.R')
rebuild_gage_data().

Note: I needed to comment out:
  #scipiper::scmake("1_fetch/out/dv_data_fixed_gh.rds.ind", "1_fetch.yml")
  #scipiper::scmake("1_fetch/out/sites_stage.rds.ind", remake_file = "1_fetch.yml")
  #scipiper::scmake("2_process/out/dv_stats_fixed_gh.rds.ind", "2_process.yml")
  #scipiper::scmake("2_process/out/dv_stat_styles.rds.ind", "2_process.yml")

in the helper_fxns_pipeline.R script to get the flow data since waterwatch is currently down.

converted outputted 2_process/out/dv_stats.rds to flow_conditions_202409.csv (Note: use readr::write_csv() to convert from rds to csv and avoid pesky row numbers adding)
Uploaded flow_conditions_2024079.csv to S3 water-visualizations-prod-website/visualizations/data (Note: need to be signed in using gs-chs-wma-prod as wma-developer)
Edited read_csv() in target to pull flow_conditions_202409.csv from S3
ran tar_make() to output flow_cartogram.png, flow_national_ig.png , flow_cartogram_ig.png.
I also updated the intro_image() function draw_label() for "How did X's streamflow compare to past?" to be a bit smaller since September was getting cut off
I also updated the line height of the intro question text to be a bit more spaced out

Twitter

Instagram (with Kaysa's newest edits!)

Can you create a release on this repo that marks the update to the grey color for "normal" and the explainer content? You can call it v1.0.0

Done here: https://github.com/DOI-USGS/flow-tiles/releases/tag/v1.0.0