Thread v1.3 Child updates RxOnWhenIdle from False to True to a Thread v1.1 Parent

Describe the bug
Communication between Parent-Child fails after CHILD update message to change RxOnWhenIdle from False to True.
To Reproduce Information to reproduce the behavior, including:

create a Thread network by thread v1.1 parent device,
join thread v1.3 child device as sleepy device
wait until child device updates rxOnWhenIdle = true

Parent information:
github/ot-br-posix (79a0893eec7af03ae3bbe51fa9e74f469b88f15a)  &
github/openthread (61d9e72c18588d6ee3a9b9a2720f65e7d39bdb87)
IEEE 802.15.4 hardware platform:
Qorvo GP712
Build steps
compiles as Thread v1.1
-DOPENTHREAD_CONFIG_THREAD_VERSION=OT_THREAD_VERSION_1_1
Network topology:
2 nodes Parent-Child
Console/log output If applicable, add console/log output to help explain your problem.
parent-child-update-rxonwhenidle.pcap.zip
parent_grep_CHIP_API_otbr-agent.txt
Network key = 011f81976e955a380ce6e59740e8af09
Additional context Add any other context about the problem here.
sniffer packet 754 shows the "child update request" that triggers the failure state.
corresponding to Parent logs:
12-13 14:43:42.109 I/otbr-agent( 1813): [I] MeshForwarder-: Received IPv6 UDP msg, len:107, chksum:5206, ecn:no, from:d6528a1678c67da8, sec:no, prio:net, rss:-56.0
all subsequent "child update responses" are ignored.

I checked the logs around the timestamp. I don't see anything wrong on parent side. It looks like there may be some issue on child side (it may be rebooting/resetting around the same time).
On parent, we see the "Child Update Request" from child which now says mode changed to rx-on:yes
12-13 14:43:42.110 I/otbr-agent( 1813): [I] Mle-----------: Receive Child Update Request from child (fe80:0:0:0:d452:8a16:78c6:7da8)
12-13 14:43:42.110 I/otbr-agent( 1813): [I] Mle-----------: Child 0x8801 IPv6 address[1]=fdde:ad00:beef:0:2500:7d84:659c:6b8
12-13 14:43:42.110 I/otbr-agent( 1813): [I] Mle-----------: Child 0x8801 IPv6 address[2]=fd45:6c32:296e:1:449e:c647:93f1:4d40
12-13 14:43:42.113 I/otbr-agent( 1813): [I] Mle-----------: Child 0x8801 has 2 registered IPv6 addresses, 2 addresses stored
12-13 14:43:42.113 I/otbr-agent( 1813): [N] Mle-----------: Child 0x8801 mode change 0x04 -> 0x0c [rx-on:yes ftd:no full-net:no]

Note that the child has rloc16 0x8801, ext-address  d6528a1678c67da and link-local fe80:0:0:0:d452:8a16:78c6:7da8 address along with fdde:ad00:beef:0:2500:7d84:659c:6b8 and fdde:ad00:beef:0:2500:7d84:659c:6b8
Parent prepares and sends a response but gets no ack from the child:
12-13 14:43:42.119 I/otbr-agent( 1813): [I] Mle-----------: Send Child Update Response to child (fe80:0:0:0:d452:8a16:78c6:7da8,0x8801)
12-13 14:43:42.328 I/otbr-agent( 1813): [I] Mac-----------: Frame tx attempt 16/16 failed, error:NoAck, len:82, seqnum:238, type:Data, src:ee83fb606c45044d, dst:d6528a1678c67da8, sec:no, ac
12-13 14:43:42.329 I/otbr-agent( 1813): [N] MeshForwarder-: Failed to send IPv6 UDP msg, len:98, chksum:7cfe, ecn:no, to:d6528a1678c67da8, sec:no, error:NoAck, prio:net
12-13 14:43:42.329 I/otbr-agent( 1813): [N] MeshForwarder-:     src:[fe80:0:0:0:ec83:fb60:6c45:44d]:19788
12-13 14:43:42.329 I/otbr-agent( 1813): [N] MeshForwarder-:     dst:[fe80:0:0:0:d452:8a16:78c6:7da8]:19788

Other msg to the child 0x8801 around same time also get no ack:
12-13 14:43:42.557 I/otbr-agent( 1813): [I] SrpServer-----: Send success response with granted lease: 7200 and key lease: 680400
12-13 14:43:42.787 I/otbr-agent( 1813): [I] Mac-----------: Frame tx attempt 16/16 failed, error:NoAck, len:84, seqnum:239, type:Data, src:0x8800, dst:0x8801, sec:yes, ackreq:yes
12-13 14:43:42.788 I/otbr-agent( 1813): [N] MeshForwarder-: Failed to send IPv6 UDP msg, len:83, chksum:fca7, ecn:no, to:0x8801, sec:yes, error:NoAck, prio:low

So looks like child may be off. We see in a bit later that child tries to perform "discover scan" (note fe80:0:0:0:d452:8a16:78c6:7da8 is address of the child)
12-13 14:43:44.873 I/otbr-agent( 1813): [I] Mle-----------: Receive Discovery Request (fe80:0:0:0:d452:8a16:78c6:7da8)
12-13 14:43:44.874 I/otbr-agent( 1813): [I] Mle-----------: Delay Discovery Response (fe80:0:0:0:d452:8a16:78c6:7da8)

Then tries to establish its link with parent as sleepy which all works:
12-13 14:43:47.102 I/otbr-agent( 1813): [I] Mle-----------: Receive Child Update Request from child (fe80:0:0:0:d452:8a16:78c6:7da8)
...
12-13 14:43:47.102 I/otbr-agent( 1813): [N] Mle-----------: Child 0x8801 mode change 0x0c -> 0x04 [rx-on:no ftd:no full-net:no]
...
12-13 14:43:47.107 I/otbr-agent( 1813): [I] Mle-----------: Send Child Update Response to child (fe80:0:0:0:d452:8a16:78c6:7da8,0x8801)
12-13 14:43:47.128 I/otbr-agent( 1813): [I] MeshForwarder-: Prepping indir tx IPv6 UDP msg, len:98, chksum:ac67, ecn:no, to:0x8801, sec:no, prio:net
12-13 14:43:47.128 I/otbr-agent( 1813): [I] DataPollHandlr: Rx data poll, src:0x8801, qed_msgs:1, rss:-56, ack-fp:1
12-13 14:43:47.162 I/otbr-agent( 1813): [I] MeshForwarder-: Sent IPv6 UDP msg, len:98, chksum:73f9, ecn:no, to:d6528a1678c67da8, sec:no, prio:net

@AlanLCollins , any insight into what might be triggering the device to send an MLE Discovery Request? Is this due to a Matter ScanNetworks command? For example here: https://github.com/project-chip/connectedhomeip/pull/21279

yes. the discovery requests from the accessory device are related to Matter ScanNetworks command.

So looks like this may be the issue: Child is scanning and switches to different rx channels, so does not rx and ack the "Child Update Response" from parent. After scan is done things start working again.

I think we need the logs from the accessory device because the Discovery Request may not be related to a ScanNetwork command, but a mechanism to recover from the lost network.

I don't understand the need to perform a network scan if the device detaches from the network. It should simply use MLE Parent Request (and possibly MLE Announce) messages.

the spec allows going RxOnWhenIdle from false to true, but it prohibits going from True to False. I am guessing the only way to do that is by reconnecting to the parent and send a new Child Id request.

The Thread Spec allows going from non-sleepy to sleepy if the device originally attached as a sleepy.

Perhaps I got an old version of the spec. I am referring to 4.6.1 :

This line allows a device that attached as rx-off-when-idle to change back and forth:

If it initially attached with the "R" bit value '0' (Rx-off-when-idle) it MAY modify the "R" bit value.

I see, I understand now. So if the Child request was done with R = 0, then later we can update it to whichever we want to.

offline conversation with @LuDuda: MLE discovery is process allowed only for RxOnWhenIdle=true devices, that's the reason the sensor sends the Child update request.
@abtink analysis seems correct, the MLE Discovery switches the sensor to other channels so it misses the child update response.
We have identified a potential improvement to have a 100-200ms delay before going into MLE discovery, so sensor catches the child update response (or something similar). We will run some tests to confirm assumptions.
There are other open questions like: Why the sensor decides to deattach and attach again (Parent request). We will continue investigating.
All these have nothing to do with v1.3 vs v1.1 so I will modify the title of this ticket.

Parent removes child from tables due to failures on Child update response:
12-13 14:43:42.116 I/otbr-agent( 1813): [I] Settings------: Read ChildInfo {rloc:0x8801, extaddr:d6528a1678c67da8, timeout:240, mode:0x04, version:4}
12-13 14:43:42.117 I/otbr-agent( 1813): [I] Settings------: Removed ChildInfo {rloc:0x8801, extaddr:d6528a1678c67da8, timeout:240, mode:0x04, version:4}
12-13 14:43:42.119 I/otbr-agent( 1813): [I] Settings------: Added ChildInfo {rloc:0x8801, extaddr:d6528a1678c67da8, timeout:240, mode:0x0c, version:4}
12-13 14:43:42.119 I/otbr-agent( 1813): [I] Mle-----------: Send Child Update Response to child (fe80:0:0:0:d452:8a16:78c6:7da8,0x8801)```

@AlanLCollins the log snippet does not indicate that parent removed the child. It is just updating the ChildInfo saved in Settings (non-volatile memory). It is removing the previous ChildInfo with old mode mode:0x04 (from Settings) and saving/adding it with new mode mode:0x0c.

Resolved by #8832


Missing dependencies from examples

The code example given for the Azure Databricks CI/CD pipeline references to other example code that isn't provided in the documentation. There isn't a clean way to remove the example code because it's a dependency of the pipeline sample shown.
"from dbxdemo.spark import get_spark
from dbxdemo.appendcol import with_status
"
It looks like another user opened a similar issue where the response from the content creator is that there is no sample code available.  This makes the entire article useless if it cannot be run successfully as provided.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 56b86f59-7a22-90c6-9aa6-652b85975612
Version Independent ID: b333ab7b-847b-7129-9b62-4b9b934747d7
Content: Continuous integration and delivery on Azure Databricks using Azure DevOps - Azure Databricks
Content Source: databricks/dev-tools/ci-cd/ci-cd-azure-devops.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

@chris2shehu
Thanks for your feedback! We will investigate and update as appropriate.

Hi @mssaperla
Please add your comment and provide example.

@mssaperla
could you please review this and update as appropriate.

@chris2shehu
Thanks for your feedback! We have assigned the issue to author and will provide further updates.


kotlin2cpg: test interprocedural dataflows

A general comment about these tests is that they only test dataflow one way, i.e. trough values passed as arguments in function calls. A test for tracking dataflow through a return value would be useful (assuming this doesn't exist already and was not planned for a separate future PR).


Implement "Facet by null" Command and add to Customised Facets menu

From #820
A "Facet by null" function would create a facet with the values 'true' (the cell value is null) and 'false' (the cell value is not null). It would work similarly to the existing 'Facet by Blank' option, but would only include cells containing a value of 'null', not those containing empty strings

I will work on this this weekend and get a PR up by next week :)

Thanks @joanneong - would you be able to look at doing #1487 at the same time? They should be pretty similar

Hi @joanneong did you make any progress with this?

My apologies for the long period of inactivity, @ostephens - had examinations over this period. I will get a PR up and running by this Sunday.

No problem at all @joanneong - we are always very grateful for any time people can spare to contribute! (I've done barely anything over the last month but just got a few hours last night and was reviewing stuff, that was the only reason I asked)

With #1500 you can see I tried to put in translations where I could. I don't entirely trust Google translate for the OpenRefine interface because there are so many ambiguities (e.g. 'row', 'cell', 'blank' all have multiple meanings in English) - so I used a combination of existing translations and Google translate.
Ideally we could just implement the English and rely on the i8n library falling back on English where no specific translation is supplied. Unfortunately the current  i8n library we use doesn't support fall back options, so not having translations in place can lead to problems (#1350 #1455) but the solution to this is to replace the i8n library (see #1285)


[BUG] tests/unit/test_tf4rec.py is failing on main

Describe the bug
tests/unit/test_tf4rec.py is failing on main.  This is probably due to the changes in core.
Steps/Code to reproduce bug
Run pytest tests/unit/test_tf4rec.py
Expected behavior
Test doesn't fail.
Environment details (please complete the following information):
Running this on Ubuntu server. Installing everything using pip install -e .
Additional context
I want to learn more about the codebase and learn to use NVTabular. tests/unit/test_tf4rec.py seems like a really interesting test leveraging much of the functionality. Happy to troubleshoot this and open a PR with a fix. If it would be a good time to start working on this please assign this to me. Thank you!

Seems in tests/unit/test_tf4rec.py ItemRecency is outputting two columns where if I am reading it right the original intent was for it to output a single column.
And then when this gets fed into the ops that comprise recency_features_norm the problem arises.
Also, I believe output_column_names on ItemRecency is never called.
from nvtabular.ops import Operator

# custom op for item recency
class ItemRecency(Operator):
    def transform(self, columns, gdf):
        for column in columns.names:
            col = gdf[column]
            item_first_timestamp = gdf["prod_first_event_time_ts"]
            delta_days = (col - item_first_timestamp) / (60 * 60 * 24)
            gdf[column + "_age_days"] = delta_days * (delta_days >= 0)
        return gdf

    def output_column_names(self, columns):
        return ColumnSelector([column + "_age_days" for column in columns.names])

    def dependencies(self):
        return ["prod_first_event_time_ts"]

recency_features = ["event_time_ts"] >> ItemRecency()
recency_features_norm = (
    recency_features
    >> nvt.ops.LogOp()
    >> nvt.ops.Normalize()
    >> nvt.ops.Rename(name="product_recency_days_log_norm")
)

dataset = nvt.Dataset(df)

workflow = nvt.Workflow(recency_features)
workflow.fit(dataset)
sessions_gdf = workflow.transform(dataset).to_ddf().compute()
sessions_gdf.head()

This is as far as I got, need to run now.

We're having a few issues getting cross-repo dependencies and testing ironed out as the Merlin ecosystem expands, but this issue should be resolved by NVIDIA-Merlin/core#29.

output_column_names not getting called is expected; earlier versions of NVTabular used that method to determine their outputs, but we have since shifted to relying on column_mapping, which produces a dictionary of output_column -> [input_columns] pairs (which helps us compute the correct schema info like dtype for the output columns based on the inputs they're generated from.) I don't think the example this test is based on has been updated to reflect that yet.

Thank you very much for this additional information, @karlhigley! All this makes it much easier to understand what is going on!
I updated ItemRecency, the results are now correctly returned.


Conversion from String to CString ?

Hi ! I'm looking for a crate that could help me deal with some embedded C code. My goal is to use String/str in my Rust code, and transform them into CString/CStr before calling external C code.
Is this possible with your crate ? I didn't saw anything about that in the doc.
(I'm new to Rust, maybe my idea is not possible at the moment)
Best,
V.

You should just be able to use CString::new() for this.


Workspace - Long loading and errors after a new non USD WS offline and adding a bank account

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4529975&group_by=cases:section_id&group_id=283225&group_order=asc
Issue reported by: Applause - Internal Team
Action Performed:
Precondition: Your default workspace currency shouldn't be USD

Log in with a new expensifail account
Go offline
Create a workspace
Enable Workflows in the WS settings
Go online
Start adding a bank account
Click on "Update to USD"

Expected Result:
The loading shouldn't take long and there shouldn't be any errors while adding a bank account
Actual Result:
After clicking on "Connect bank account", the loading takes up to 15 seconds or sometimes it's infinite. "Hmm it's not here" error appears briefly when it loads and the user clicks somewhere to close the "Connect bank account" modal.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/d9291ee1-a600-4b9e-9788-125f3c266d90
View all open jobs on GitHub

@AndrewGable  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

I'm also seeing a delay on production, I think it's just because there are a bunch of sequential API requests to finish before the view can be shown (also there's some crazy flickering, looks like it's due to rerenders; but that's unrelated)
https://github.com/Expensify/App/assets/2229301/8f159d93-bade-4b13-9c15-e08cd307f7af

Agree with @francoisl if it's on production let's look at it like a normal bug.

Proposal
Please re-state the problem that we are trying to solve in this issue.
After clicking on "Connect bank account", the loading takes up to 15 seconds or sometimes it's infinite. "Hmm it's not here" error appears briefly when it loads and the user clicks somewhere to close the "Connect bank account" modal.
What is the root cause of that problem?
When we create a workspace and enable a feature offline, the policy data is updated optimistically
https://github.com/Expensify/App/blob/52d4f31aeb9436ee009f862ec9bbde134cad84b8/src/pages/workspace/AccessOrNotFoundWrapper.tsx#L91

After we go online, CreateWorkspace API is called first and it takes more time to complete and other APIs need to wait it before these API are called. That why the long loading occur.

About the not found page appears briefly, the RCA is CreateWorkspace API returns this feature is disabled it overrides the optimisticData when we enable the feature in offline. And then after CreateWorkspace API is complete, the enable feature API is called and the page appears again.

What changes do you think we should make in order to solve the problem?

For the long loading, it's not a bug because it simply means we have to wait for the API to be called.

For the not found page appears briefly, when we enable feature in offline, we should add an extra field with format like ${featureName}Optimistic as true in optimisticData of policy

Example for enable workflow we will update areWorkflowsEnabledOptimistic as enable in optimisticData and we will reset as false in successData and failureData
https://github.com/Expensify/App/blob/52d4f31aeb9436ee009f862ec9bbde134cad84b8/src/libs/actions/Policy.ts#L4373
And then in isPolicyFeatureEnabled we will return true if the featureName field or featureName optimistic field of policy is true
if (featureName === CONST.POLICY.MORE_FEATURES.ARE_TAXES_ENABLED) {
    return Boolean(policy?.tax?.trackingEnabled || policy?.tax?.`trackingEnabledOptimistic`);
}

return Boolean(policy?.[featureName] || policy?.[`${featureName}Optimistically`]);

https://github.com/Expensify/App/blob/52d4f31aeb9436ee009f862ec9bbde134cad84b8/src/libs/PolicyUtils.ts#L319
What alternative solutions did you explore? (Optional)
NA

@hoangzinh thoughts on the proposal above?

@hoangzinh both CreateWorkspace and EnableWorkflow API are write API.

@hoangzinh Thanks for your information, I updated the RCA and solution https://github.com/Expensify/App/issues/41431#issuecomment-2105015885

Can you point me to the LOC where the queue is paused before we call EnablePolicyWorkflows API.?

@hoangzinh when we create a new workspace, we are missing some updates on our local storage and then the queue is pause here.
https://github.com/Expensify/App/blob/e8ae3c5acedf0e6788dc574c7b6f3043ca37092a/src/libs/actions/OnyxUpdates.ts#L121-L130

@nkdengineer Actually I realize that there 2 are times that it makes SequentialQueue pause. And the time related to our bug seems the OpenReimbursementAccountPage API

@hoangzinh Thanks for your feedback, the not found page still appears even we don't click on Connect bank account which makes OpenReimbursementAccountPage is called.

Moreover, your solution might cause a regression where the network is offline, we won't trigger resolveIsReadyPromise?.()

For that, we can add the check offline to triggerresolveIsReadyPromise?.()
if (NetworkStore.isOffline() || PersistedRequests.getAll().length === 0) {
    resolveIsReadyPromise?.();
}

@hoangzinh I tested and sometimes the PusherEvent happens before CreateWorkspace, sometimes it happens after CreateWorkspace. I think it's based on backend and network. So summary of the issue's RCA is a PusherEvent comes between CreateWorkspace and EnablePolicyWorkflows API makes the queue is paused and then a read API is called before EnablePolicyWorkflows API which overrides the policy data. What do you think?

@hoangzinh Thanks for your feedback, I checked again, the queue is paused after CreateWorkspace API is called and before CreateWorkspace is complete. But the queue is unpaused after CreateWorkspace API is complete which makes resolveIsReadyPromise is resolved after CreateWorkspace API is complete and then the read API is called immediately
https://github.com/Expensify/App/blob/ff7ba40d79871079666ef26cd0f22706d4882bb8/src/libs/Network/SequentialQueue.ts#L132
https://github.com/Expensify/App/blob/ff7ba40d79871079666ef26cd0f22706d4882bb8/src/libs/actions/OnyxUpdateManager/index.ts#L144

Issue not reproducible during KI retests. (First week)

@hoangzinh I can't reproduce it anymore, seems we can close it

Asked QA to test again.

Tester is still able to reproduce.
https://github.com/Expensify/App/assets/43996225/7a842bd5-c5bd-49b4-b2ca-0847c956a53e

QA is able to reproduce so keeping this open.

Issue not reproducible during KI retests. (Second week)

Given that QA can no longer reproduce, and others have seen the same, I'm closing this issue.


inaccurate string type from json file while resolveJsonModule option on

TypeScript Version:  3.1.1
VS Code Version: 1.28.1

Search Terms: resolveJsonModule
Code
./schema.json
{
    "type": "object"
}

./test.ts
import schema = require('./schema.json')
// give a restriction only the string value 'object' is acceptable
type Format = { type: 'object' }
// here the vscode gives the following error
// ; Type { type: string } is not assignable to Format
// ;     Type 'string' is not assignable to  type ' "object" '
const data: Format  =  schema

Expected behavior:
The imported string type from json file should be converted as:
From: { type: "object" }
To:   type FromJson = { type: string & 'object' }
As a result, the code below should not be given warnings or errors:
// imported from json
type FromJson = { type: string & 'object' }
const json: FromJson = { type: 'object' }

// type restriction
type FromTs = { type: 'object' }

//  no error here
const ts: FromTs = json

// no side effect
type StringType = { type: string }
const acceptable: StringType = json

Actual behavior:
error on vscode, but pass the compilation
Others:
1
The typescript 3.03 does not give this error, but it is still not correct because  it does not distinguish
{ type: 'object1' } from json and type { type: 'object'} from ts code.
2
just considering how to give the type from json file  if the string value is very long
the type { type: string & 'this is a very very very very very very very very long'}  seems ugly
Related Issues: Not found

Module type is always widened on import to that we aren't exposing private information in the json: eg. { name: "Some name", age: 55 } should be typed as { name: string, age: number }. This behavior is also same if for eg. you had js file instead of json with module.exports =  { type: "object" }.

I did not notice the design of "do not exposing private information". In this case, according to this design, the 'data-reflected' type exported whatever from the json or ts file will face the same problem, we can not give  particular string values as type, for example, type Type = 'object'|'array'|'string', to restrict the input data . Does anyone have the alternative way to workaround?

came across this myself. I have many large json config files checked into a particular project, whos content is not sensitive. It is currently not possible to check those file's fields for string literals unless I check the files at runtime with ts-runtime. I want to be able to check the types of said files at compile time.
Perhaps a compiler flag like widenModuleTypes defaulted to true would be possible? If this is an intentional behavior it sounds like it is possible to change, just not desired as default behavior.


Feature request - VS Code plugin

It looks fairly straightforward to create a VS Code plugin for templ, as per the getting started guide at: https://code.visualstudio.com/api/language-extensions/syntax-highlight-guide
I think it is possible to make the outline of the templ tags ({% import ... %} etc.) and then refer to HTML and Go syntax blocks to reduce the overall amount of work required.
The templ lsp command provides a language server that will take care of other elements.

See https://github.com/a-h/templ-vscode and https://marketplace.visualstudio.com/items?itemName=a-h.templ


Modify SpiralTask to use 70m as stepsize and diameter as step_count

Short Description:
SpiralNavigator used 200m as step_size, which causes kinda big blind spots since maximum radius for detecting pokemon has ben lowered to 70m.
Using 140m wouldnt be sufficient since we would still get small blind spots of over 1000m^2.
70m would reduce those blind spots. There is some big overlapping though, but this way respawned pokemons can be catched too.
I also changed the configuration from a step count to a diameter. The spiral is always a square, so the diameter describes the width/height of the spiral (Height = diameter * 70m)

👍

@tstumm make step size a parameter too ;)

@tstumm also please note that step size is the Walker's responsibility. FollowSpiral only gives the spiral points and the walker changes position in small steps.

@douglascamata The defined step size in this Spiral Navigator has NOTHING to do with the walkers. Its just the size of the steps between the waypoints. If you really think that this PR just generates points in distance smaller than the walkers steps then you should really take a look into the code before claiming this.

The size of the steps the walkers are doing is defined by the config-param "walk" and it was always like this.

Please look at the changes to clear up this MAJOR misunderstanding.

You're missing the point. If step size is defined by the config.walk, why you're enforcing a 70m step size in FollowSpiral?

Because the step with of the walker was to do more human-like steps before the bot was flodded with features. The step size in FollowSpiral is just do give waypoints so we can cover almost each point in our area. The stepsize of FollowSpiral was never related to walking at all, so you are misunderstanding the code.

The distance between the waypoints has been enforced since we have the Spiral-code

@tstumm solve merge conflicts, please.

👍

LGTM
:+1:


Fix use external to ensure it works well with VTK

@topazus please review

confirmed it built successfully on my machine.

build
ruby in 🌐 fedora in f3d on  fix_use_external [?] via △ v3.26.4 took 2s
❯ git log -1 --stat
commit ffadc9aed48eb186d0efb4d462e02a75cef44eeb (HEAD -> fix_use_external, origin/fix_use_external)
Author: Mathieu Westphal<EMAIL_ADDRESS>Date:   Sat Jun 3 09:40:02 2023 +0200

    Fix use external to ensure it works well with VTK

 CMakeLists.txt | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

ruby in 🌐 fedora in f3d on  fix_use_external [?] via △ v3.26.4
❯ rm -rf build/ && cmake . -B build -DF3D_USE_EXTERNAL_CXXOPTS=ON -DF3D_USE_EXTERNAL_NLOHMANN_JSON=ON
-- The C compiler identification is GNU 13.1.1
-- The CXX compiler identification is GNU 13.1.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/lib64/ccache/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/lib64/ccache/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Warning at cmake/f3dVersion.cmake:48 (message):
  Version from git (1.3.1) disagrees with hard coded version (2.0.0).  Either
  update the git tags or main CMakeLists.txt.  Discarding version from git.
Call Stack (most recent call first):
  CMakeLists.txt:38 (f3d_determine_version)

-- Found nlohmann_json: /usr/share/cmake/nlohmann_json/nlohmann_jsonConfig.cmake (found version "3.11.2")
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found GLEW: /usr/lib64/libGLEW.so
-- Found OpenGL: /usr/lib64/libOpenGL.so  found components: OpenGL GLX
-- Found HDF5: /usr/lib64/libhdf5.so (found version "1.12.1") found components: C HL
-- Found utf8cpp: /usr/include/utf8cpp
-- Found NetCDF: netcdf (found version "4.9.0")
-- Found JsonCpp: /usr/lib64/libjsoncpp.so (found suitable version "1.9.5", minimum required is "0.7.0")
-- Found ZLIB: /usr/lib64/libz.so (found version "1.2.13")
-- Found PNG: /usr/lib64/libpng.so (found version "1.6.37")
-- Found Eigen3: /usr/include/eigen3 (found version "3.4.0")
-- Found X11: /usr/include
-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so
-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found EXPAT: /usr/lib64/libexpat.so (found version "2.5.0")
-- Found double-conversion: /usr/lib64/libdouble-conversion.so
-- Found LZ4: /usr/lib64/liblz4.so (found version "1.9.4")
-- Found LZMA: /usr/lib64/liblzma.so (found version "5.4.3")
-- Found JPEG: /usr/lib64/libjpeg.so (found version "62")
-- Found TIFF: /usr/lib64/libtiff.so (found version "4.4.0")
-- Found Freetype: /usr/lib64/libfreetype.so (found version "2.13.0")
-- VTK 9.2.6 found
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
-- Configuring done (2.6s)
-- Generating done (0.0s)
-- Build files have been written to: /home/ruby/test/f3d/build

ruby in 🌐 fedora in f3d on  fix_use_external [?] via △ v3.26.4 took 2s
❯ cmake --build build/ -j6
[ 11%] Generating the wrap hierarchy for f3d::VTKExtensionsCore
[ 11%] Building CXX object plugins/exodus/CMakeFiles/f3d-plugin-exodus.dir/plugin.cxx.o
[  9%] Generating the wrap hierarchy for f3d::VTKExtensionsReaders
[ 11%] Building CXX object library/VTKExtensions/Core/CMakeFiles/VTKExtensionsCore.dir/F3DLog.cxx.o
[ 11%] Building CXX object plugins/native/CMakeFiles/f3d-plugin-native.dir/plugin.cxx.o
[ 11%] Generating the wrap hierarchy for f3d::VTKExtensionsApplicative
[ 15%] Linking CXX static library ../../lib/libf3d-plugin-exodus.a
[ 15%] Built target VTKExtensionsCore-hierarchy
[ 15%] Building CXX object library/VTKExtensions/Core/CMakeFiles/VTKExtensionsCore.dir/vtkF3DConsoleOutputWindow.cxx.o
[ 17%] Linking CXX static library ../../lib/libf3d-plugin-native.a
[ 17%] Built target VTKExtensionsApplicative-hierarchy
[ 19%] Linking CXX static library ../../../lib/libVTKExtensionsCore.a
[ 19%] Built target VTKExtensionsReaders-hierarchy
[ 21%] Generating the wrap hierarchy for f3d::VTKExtensionsRendering
[ 21%] Built target f3d-plugin-exodus
[ 21%] Built target f3d-plugin-native
[ 21%] Built target VTKExtensionsCore
[ 23%] Building CXX object library/VTKExtensions/Readers/CMakeFiles/VTKExtensionsReaders.dir/vtkF3DPostProcessFilter.cxx.o
[ 25%] Building CXX object library/VTKExtensions/Readers/CMakeFiles/VTKExtensionsReaders.dir/vtkF3DGenericImporter.cxx.o
[ 26%] Linking CXX static library ../../../lib/libVTKExtensionsReaders.a
[ 26%] Built target VTKExtensionsReaders
[ 32%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DDropZoneActor.cxx.o
[ 34%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DHexagonalBokehBlurPass.cxx.o
[ 32%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DCachedLUTTexture.cxx.o
[ 32%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DCachedSpecularTexture.cxx.o
[ 36%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DInteractorEventRecorder.cxx.o
[ 44%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DInteractorStyle.cxx.o
[ 44%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DOpenGLGridMapper.cxx.o
[ 44%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DNoRenderWindow.cxx.o
[ 44%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DPolyDataMapper.cxx.o
[ 46%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DRenderPass.cxx.o
[ 46%] Built target VTKExtensionsRendering-hierarchy
[ 48%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DRenderer.cxx.o
[ 51%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DRendererWithColoring.cxx.o
[ 51%] Building CXX object library/VTKExtensions/Rendering/CMakeFiles/VTKExtensionsRendering.dir/vtkF3DOrientationMarkerWidget.cxx.o
[ 53%] Linking CXX static library ../../../lib/libVTKExtensionsRendering.a
[ 53%] Built target VTKExtensionsRendering
[ 55%] Building CXX object library/VTKExtensions/Applicative/CMakeFiles/VTKExtensionsApplicative.dir/vtkF3DObjectFactory.cxx.o
[ 57%] Linking CXX static library ../../../lib/libVTKExtensionsApplicative.a
[ 57%] Built target VTKExtensionsApplicative
[ 63%] Building CXX object library/CMakeFiles/libf3d.dir/src/camera_impl.cxx.o
[ 63%] Building CXX object library/CMakeFiles/libf3d.dir/src/animationManager.cxx.o
[ 65%] Building CXX object library/CMakeFiles/libf3d.dir/src/engine.cxx.o
[ 63%] Building CXX object library/CMakeFiles/libf3d.dir/src/config.cxx.o
[ 67%] Building CXX object library/CMakeFiles/libf3d.dir/src/factory.cxx.o
[ 69%] Building CXX object library/CMakeFiles/libf3d.dir/src/image.cxx.o
[ 75%] Building CXX object library/CMakeFiles/libf3d.dir/src/init.cxx.o
[ 75%] Building CXX object library/CMakeFiles/libf3d.dir/src/interactor_impl.cxx.o
[ 75%] Building CXX object library/CMakeFiles/libf3d.dir/src/interactor.cxx.o
[ 76%] Building CXX object library/CMakeFiles/libf3d.dir/src/loader_impl.cxx.o
[ 78%] Building CXX object library/CMakeFiles/libf3d.dir/src/log.cxx.o
[ 82%] Building CXX object library/CMakeFiles/libf3d.dir/src/options.cxx.o
[ 82%] Building CXX object library/CMakeFiles/libf3d.dir/src/window_impl.cxx.o
[ 84%] Linking CXX shared library ../lib/libf3d.so
[ 84%] Built target libf3d
[ 86%] Generating F3DIcon.h, F3DIcon.cxx
[ 94%] Building CXX object application/CMakeFiles/f3d.dir/F3DConfigFileTools.cxx.o
[ 94%] Building CXX object application/CMakeFiles/f3d.dir/F3DIcon.cxx.o
[ 94%] Building CXX object application/CMakeFiles/f3d.dir/F3DOptionsParser.cxx.o
[ 94%] Building CXX object application/CMakeFiles/f3d.dir/F3DStarter.cxx.o
[ 96%] Building CXX object application/CMakeFiles/f3d.dir/F3DSystemTools.cxx.o
[ 98%] Building CXX object application/CMakeFiles/f3d.dir/main.cxx.o
[100%] Linking CXX executable ../bin/f3d
[100%] Built target f3d


Make ConvertFrom-Csv and Import-Csv support outputting (ordered) hashtables as an alternative to custom objects

Summary of the new feature/enhancement
To complement the proposal in #10999, as suggested by @vexx32:

I think we should also consider adding a switch to ConvertFrom-Csv and Import-Csv in order to import the data -AsHashtable for symmetry.

Note: To be a viable alternative, the output objects should be  ordered hashtables ([ordered] @{}, i.e. System.Collections.Specialized.OrderedDictionary), in order to preserve the input column order.
Benefits:

As with ConvertFrom-Json -AsHashtable, you may want output objects that are easier to manipulate in terms of subsequent removal / addition of properties (entries).

Ordered hashtable instances are more lightweight than [pscustomobject] instances and would enable (faster) processing of larger input datasets, in cases where [pscustomobject] output consumes inordinate amounts of memory - see #7603

What scenario would this enable?

@BrucePay.
To quote from the OP:

Ordered hashtable instances are more lightweight than [pscustomobject] instances and should suffice in many situations.

More specifically, it would enable processing of larger input datasets, in cases where [pscustomobject] output consumes inordinate amounts of memory - see #7603

Another use case: As with ConvertFrom-Json -AsHashtable, you may want output objects that are easier to manipulate in terms of subsequent removal / addition of properties (entries).

processing of larger input datasets

I do not see why I would prefer hash tables for the scenario. Rather typed output would be more useful and power.

That is a false dichotomy, @iSazonov - both features are worth implementing.
And don't forget the convenience and speed of adding / removing entries that hashtables offer.

If you look OrderedDictionary implementation you find that both "easier to manipulate" and "more lightweight than [pscustomobject]" will not bring that you expect in common.
So we need to know exactly the scenario where it will benefit. While I do not see such a scenario.
We could invest more in PSObject/PSCustomObject performance - I hope there is a way to make them better.

@iSazonov

If you look OrderedDictionary implementation you find that both "easier to manipulate" and "more lightweight than [pscustomobject]" will not bring that you expect in common.

I don't know what that means, but let's look at some scenarios, using the existing ConvertFrom-Json -AsHashtable implementation:
Note:

ConvertFrom-Json -AsHashtable uses [hashtable] instances, not ordered hashtables, but if memory servers the performance penalty for the ordered variety is fairly small:

The code uses the Time-Command function to average 10 runs with 1001 JSON objects.

# Create a JSON array with 1001 objects with 20 properties.
$jo =  '{ "p1": 1, "p2": 1, "p3": 1, "p4": 1, "p5": 1, "p6": 1, "p7": 1, "p8": 1, "p9": 1, "p10": 1, "p11": 1, "p12": 1, "p13": 1, "p14": 1, "p15": 1, "p16": 1, "p17": 1, "p18": 1, "p19": 1, "p20": 1 }'
$ja = "[`n" + (($jo + ",`n") * 1e3) + $jo + "`n]"

# Compare [pscustomobject] vs. [hashtable] deserialization time:
Time-Command { # Deserialize: [pscustomobject]
  $ja | ConvertFrom-Json
}, {           # Deserialize: [hashtable]
  $ja | ConvertFrom-Json -AsHashtable
}

'---'

# Compare [pscustomobject] vs. [hashtable] property-addition time:
Time-Command { # Add property: [pscustomobject], with Select-Object
  $objects = $ja | ConvertFrom-Json
  $newObjects  = $objects | Select-Object *, @{ n='p21'; e = { 1 } }
}, { # Add property: [pscustomobject] (loop)
  $objects = $ja | ConvertFrom-Json
  foreach ($obj in $objects) {
    $obj | Add-Member -NotePropertyName p21 -NotePropertyValue 1
  }
 }, { # Add property: [hashtable] (loop)
  $hashtables = $ja | ConvertFrom-Json -AsHashtable
  foreach ($ht in $hashtables) {
    $ht['p21'] = 1
  }
}

The above yields the following on my macOS 10.15.1 machine:

Factor Secs (10-run avg.) Command                                                                                TimeSpan
------ ------------------ -------                                                                                --------
1.00   0.073              # Deserialize: [hashtable]…                                                                                00:00:00.…
1.59   0.116              # Deserialize: [pscustomobject]…                                                                                00:00:00.…
---
1.00   0.085              # Add property: [hashtable] (loop)…                                                                                00:00:00.…
4.38   0.373              # Add property: [pscustomobject], with Select-Object…                                                                                00:00:00.…
5.59   0.477              # Add property: [pscustomobject] (loop)…                                                                                00:00:00.…

That is:

the [pscustomobject] serialization was 60% slower than the hashtable-producing one (and, if I read #7603 correctly, requires more memory)
adding a property to each object took about 4-6 times as long than adding a hashtable entry (including deserialization time).

It is known issue that adding properties to pscustomobject is relatively slow. The demo convinces me that we should invest in the area and improve psobject performance.
Without a real scenario where it is critically important, this does not convince me that we need one more parameter - cmdlets with many parameters are more likely talking about bad design or bad implementation.

The demo convinces me that we should invest in the area and improve psobject performance.

Again, a false dichotomy: that is well worth doing, but independently of what is being proposed here.
(As an aside: to be on par feature-wise, we'd need then a Remove-Property cmdlet that removes properties in place, analogous to how Add-Member adds them in place).
At a conceptual level, custom objects and hash tables can take each other's place, each with relative strengths and weaknesses, it is perfectly reasonable to support serialization / deserialization of both types:

ConvertTo-Json and ConvertTo-Json already provide that support: collections of (ordered) hash tables are supported as input, and -AsHashtable deserializes to collections of hash tables.

Making ConvertTo-Csv / Export-Csv support hash table input has already been green-lit in #10999 (and I hope my recent clarification there makes you not object to it), so not providing the same support on the output side would be an awkward omission.


Group minor version updates

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.74%. Comparing base (5a11dca) to head (4e89a5a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   40.79%   40.74%   -0.05%
==========================================
  Files          15       15
  Lines        8541     8535       -6
==========================================
- Hits         3484     3478       -6
  Misses       5057     5057

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Invisibility Cloak

Perform Invisibility Cloak designed using python and opencv.

@geekquad kindly assign me this issue.

@geekquad I have a bit of hands on this part kindly assign me this issue

@geekquad we have to mask it with RGB only right?

Hey @unnati914, have you seen that Invisibility Cloak issue #53  was opened 6 days ago, and there are 3 people already in the queue.

Hey @Dhanush2612, @i-akshat-jain @aditisneh, it has already been assigned. Please check it here #53.
If the participant fails to submit the PR in the specified duration, it will be automatically transferred to the next participant. Thankyou.


How use stopOnError

Hi, I guess this is the best validator for nodejs, but I'm having the next issue (non critic but would be great for performance care)
I can't find an example about how use stopOnError, I see on souce code it receive a boolean (true for all fields) or array, I tried set it true on main instance (as config language) and on instance of it but the validation always fired my custom async validation.
My rule:
{name    : required|max:20|unique:measure_units,name,${id},}
If I send a name with 21 characters it fires the unique rule, if I don't send name value if don't fires nither max nor unique
I'm using the last validatorjs version over nodejs 6.9.4
Thanks for your help

@garygreen do you know how this feature is used? I think you added it :)

stopOnError doesn't actually support async at the moment, unfortunately haven't had time to look into adding that feature yet, which is partly why I haven't documented stopOnError yet because it's not fully complete.

@garygreen Does this feature appear in the near future? Faced with this problem. Would be great to have some sort of stopOnError function


Move data to web server, uncompress it

Move it into final position, mark as read-only file permissions, add to .gitignore

Done


Create infix_to_prefix.c

By Shourya Gupta
A simple program using user defined function to  Evaluate an expression given by the user in infix to prefix using C languague
What type of PR is this? (check all applicable)

[x] 🚀 Added Name
[x] ✨ Feature
[x] 🌟 stared the repo
[ ] 🐛 Grammatical Error
[ ] 📝 Documentation Update
[ ] 🚩 Other

Description
Add Link of GitHub Profile

Why is it showing cross
Please help as I am new to this open source


[SPARK-32949][FOLLOW-UP][R][SQL] Reindent lines in SparkR timestamp_seconds

What changes were proposed in this pull request?

Re-indent lines of SparkR timestamp_seconds.
Why are the changes needed?

Current indentation is not aligned with the opening line.
Does this PR introduce any user-facing change?

No.
How was this patch tested?

Existing tests.

Test build #129380 has started for PR 29940 at commit 562b29c.

Test build #129380 has finished for PR 29940 at commit 562b29c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129380/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33988/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33988/

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/33988/
Test FAILed.

Thank you @dongjoon-hyun.


GitHub link for issues needs updating. Refers to renamed project

[Enter feedback here]
The link to submit issues is broken. Please change to this:
https://github.com/microsoft/automation-coe-starter-kit/issues

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca7cc938-0b2d-7c1e-27d3-2681a3c7f058
Version Independent ID: ca7cc938-0b2d-7c1e-27d3-2681a3c7f058
Content: Microsoft Power Platform Automation CoE starter kit (preview) - Power Platform
Content Source: power-platform/guidance/automation-coe/automation-coe-starter-kit.md
Service: power-platform
Sub-service: guidance
GitHub Login: @kathyos
Microsoft Alias: kathyos

The aka.ms link has been updated and works correctly now.


Update master dataset

We have a git-versioned snapshot of full manual.
The actual manual has continued to mature.
We have two options:

Apply local patches to master dataset
Identify master changes, apply them to local version

Second option can be done by forking local main, overwriting with new master, and looking at pending changes.

Defer this, because we may actually skip a version

Done


symmetric-difference - inconsistent instructions

The bonfire challenge states here:

Create a function that takes two or more arrays and returns an array of the symmetric difference of the provided arrays.

However, one of the test cases submits only 1 array as an argument.

Arguably, a function that expects certain conditions to be met should test
for these conditions. A consumer may not always invoke the function
correctly and providing either an error or some other graceful handling of
the situation is required.
On Sun, Mar 22, 2015 at 7:58 AM Darryl Dixon - Piece Digital <
<EMAIL_ADDRESS>wrote:

The bonfire challenge states here:
Create a function that takes two or more arrays and returns an array of
the symmetric difference of the provided arrays.
However, one of the test cases submits only 1 array as an argument.
—
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/freecodecamp/issues/246.

I agree with @terakilobyte. This is just a sanity check test. I think we should keep it. It's been almost a month, so I'm going to close this.


Spike: Stack Ownership Model/Guardianship

Ideas thus far:
new resource mapping type:

entity mapping (Stack) as owner of resource (ERM)
stack is owned by user (URM)
this is a small brain remapping that brings in the idea of ERM, and have URM be a specific entity that maps those relationships

new role:

owner, member, pkger/stack?

Can we turn guardianship on and off?
annotations define ownership
if you want to be able to delete it with the bucket, it is blocked by the owner of the stack.
Enhancing the templates to include
kind: Bucket
metadata:
   name: foo-name
   forceDelete: always|when only reference(?)| never (default)

Additional info during discussion:

guardianship should be turned on and off on a stack config
all resources managed by a stack should have a label with that stackID
maybe some labels can be hidden from the UI
deletion: may apply something like deletionPolicy that could be Delete and Retain to a whole stack or only a couple resources in the stack

Another discussion: resources trying to be managed/created by multiple stacks:
resource can only be managed and associated to one stack, this is a problem for resources which are unique by name
If a stack tries to create a resources which already exist, creation should fail or the resource should have a field ignoreIfAlreadyExist

see the cloud formation docs: https://aws.amazon.com/premiumsupport/knowledge-center/cloudformation-accidental-updates/


verify transaction on views.py

@GonzaDDV Why the signature entry in the js post-data ajax structure has no key? (signature alone instead of "signature": signature)

In Javascript (since ES6), when the variable you are using as the value has the same name as the key, you can use this shorthand for cleaner code and better understanding. This is explained here

In Javascript (since ES6), when the variable you are using as the value has the same name as the key, you can use this shorthand for cleaner code and better understanding. This is explained here

Oh! thank you, I didn't know that, ok, I'll try to help, how can I test this locally? Can you provide a set of values for the needed settings to test? or tell me how I can generate this values on my own? thanks


Update Pinned CI Packages

This introduces new pylint failures.
Need to get these resolved before merge.
EDIT 7/8: Updated with latest master (including virtualenv pins)

I see a new exception in pylint_guidelines_checker.py when analyzing azure-keyvault-keys:
Traceback (most recent call last):
  ...
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\__main__.py", line 18, in <module>
    pylint.run_pylint()
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\__init__.py", line 22, in run_pylint
    PylintRun(sys.argv[1:])
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\run.py", line 344, in __init__
    linter.check(args)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\pylinter.py", line 871, in check
    self.get_ast, self._iterate_file_descrs(files_or_modules)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\pylinter.py", line 904, in _check_files
    self._check_file(get_ast, check_astroid_module, name, filepath, modname)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\pylinter.py", line 930, in _check_file
    check_astroid_module(ast_node)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\pylinter.py", line 1063, in check_astroid_module
    ast_node, walker, rawcheckers, tokencheckers
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\pylinter.py", line 1107, in _check_astroid_module
    walker.walk(ast_node)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\utils\ast_walker.py", line 75, in walk
    self.walk(child)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\utils\ast_walker.py", line 72, in walk
    callback(astroid)
  File "azure-sdk-for-python\scripts\pylint_custom_plugin\pylint_guidelines_checker.py", line 547, in visit_classdef
    msg_id="client-incorrect-naming-convention", node=node, confidence=None
TypeError: add_message() got an unexpected keyword argument 'msg_id'

I see a new exception in pylint_guidelines_checker.py when analyzing azure-keyvault-keys:

This sounds like my fault. I'll look into what changed with the custom checkers for the newer version of pylint.

@chlowell pushed a commit fixing that error, you should be unblocked now.

Thanks @kristapratico, that appears to have worked.
I pushed a couple commits, one to address warnings in azure-keyvaut-keys and azure-identity, and one to disable the import-outside-toplevel rule.

/azp run python - eventhub - ci

/azp run python - servicebus - ci

/azp run python - servicebus - tests

/azp run python - servicebus - tests

/azp run python - servicebus - tests


Handle unhandled error in dispatcher

Handle unhandled error in dispatcher

Failing pipeline seems to not be caused by my change directly

Failing pipeline seems to not be caused by my change directly

I will fix it, no worries.


Update to chromedriver version 94

What is the context of this PR?
Update ChromeDriver to 94.
How to review
Check functional tests pass.
Checklist

[ ] New static content marked up for translation
[ ] Newly defined schema content included in eq-translations repo

 Update Chromedriver


Change regex for core, remove need for boolean check on core jobs

Testing PRs

https://github.com/pachyderm/pachyderm/pull/8671
https://github.com/pachyderm/pachyderm/pull/8672


Merging plugin libraries into one library, directory restructure

This is another take at merging the plugin libraries into the main mavsdk library.
This would have a couple of benefits:

Easier Python direct wrappers.
Easier linking to libmavsdk, not needing to link to every plugin required.
Making API/ABI versioning clearer in the future.

Replaces https://github.com/mavlink/MAVSDK/pull/1332.

@JonasVautherin I wonder if we should change the include paths.
Now it is:
#include <mavsdk/mavsdk.h>
#include <mavsdk/plugins/shell/shell.h>

But I would consider:
#include <mavsdk/mavsdk.h>
#include <mavsdk/action/action.h>

Or even:
#include <mavsdk/mavsdk.h>
#include <mavsdk/action.h>

And while at it I would want to swap to .hpp.
#include <mavsdk/mavsdk.hpp>
#include <mavsdk/action.hpp>

This one seems fine to me:
#include <mavsdk/mavsdk.h>
#include <mavsdk/action.h>

I really don't have any opinion about .h or .hpp, I just don't mind :laughing:

We could also move the header files but create shim header files to forward to the new ones.

We could also move the header files but create shim header files to forward to the new ones.

Your call, I don't mind if we just move the headers. Anyway this will break the users' build system, so they'll have t make some changes, and at this point updating the headers does not feel like a big deal to me.


Add DeviceTensorTrait to export annotations

Exported globals can now be parked to belong to a specific device. This works with sharding tooling to ensure globals are not misassigned to the default affinity device

We are inconsistent with the DeviceAffinity being an ordinal and this is using a the whole device name directly.

Addressed


Controlled empty select element submits first value by default

Bug report
Using a controlled Select element with a placeholder in a form causes the form to submit the first item as the selected value, even if the user hasn’t made a selection.
Current Behavior
When submitting a form with a controlled Select component, the first item in the Select is submitted as the value, even if no selection has been made. See screenshot below:

I also attempted to use a placeholder item to give the Select a valid default which resulted in an error:
A <Select.Item /> must have a value prop that is not an empty string. This is because the Select value can be set to an empty string to clear the selection and show the placeholder.

Expected behavior

If Select is not required: The form should submit an empty value ("") when no selection is made.
If Select is required: The form should throw an invalid event when attempting to submit without a selection.

Reproducible example
Select example
Suggested solution
Ideally, if the user makes no selection, the Select value should be "". However, to avoid a breaking change for current users, an optional flag to control this behavior could be provided.
An alternate solution would be to allow a placeholder item to be inserted in the first element of the select and to select that item by default.
Your environment

Software
Name(s)
Version

Radix Package(s)
@radix-ui/react-select
2.1.2

React
n/a
18

Browser
Chrome
latest

Assistive tech
None

Node
n/a

npm/yarn
npm

Operating System
OSX

I am using FormData in onSubmit and getting the same behavior.  My workaround in the meantime is to use
<SelectItem value={null}></SelectItem>
Found that passing null works here https://github.com/radix-ui/primitives/issues/2706#issuecomment-2248845816.
Note that in this case the value of the field in FormData was equal to the children prop of SelectItem.
<SelectItem value={null}></SelectItem>
result is empty string inside FormData.
<SelectItem value={null}>hello</SelectItem>
result is 'hello' inside of FormData
Seems like a bug but it's the only way I found to get a corresponding value in FormData when the value is the empty string.


Attempting to use --timestamp word crashes after a few seconds

Using insanely-fast-whisper 0.0.8 on python 3.11.7, attempting to use --timestamp word gives the following crash:
$ insanely-fast-whisper.exe --file-name stream_recording.wav --timestamp word --device-id 0 -flash true
You are attempting to use Flash Attention 2.0 with a model initialized on CPU. Make sure to move the model to GPU after initializing it on CPU with `model.to('cuda')`.
Special tokens have been added in the vocabulary, make sure the associated word embeddings are fine-tuned or trained.
🤗 Transcribing... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0:00:03
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\pipx\bin\insanely-fast-whisper.exe\__main__.py", line 7, in <module>
  File "C:\pipx\venvs\insanely-fast-whisper\Lib\site-packages\insanely_fast_whisper\cli.py", line 102, in main
    outputs = pipe(
              ^^^^^
  File "C:\pipx\venvs\insanely-fast-whisper\Lib\site-packages\transformers\pipelines\automatic_speech_recognition.py", line 357, in __call__
    return super().__call__(inputs, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\pipx\venvs\insanely-fast-whisper\Lib\site-packages\transformers\pipelines\base.py", line 1132, in __call__
    return next(
           ^^^^^
  File "C:\pipx\venvs\insanely-fast-whisper\Lib\site-packages\transformers\pipelines\pt_utils.py", line 124, in __next__
    item = next(self.iterator)
           ^^^^^^^^^^^^^^^^^^^
  File "C:\pipx\venvs\insanely-fast-whisper\Lib\site-packages\transformers\pipelines\pt_utils.py", line 266, in __next__
    processed = self.infer(next(self.iterator), **self.params)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\pipx\venvs\insanely-fast-whisper\Lib\site-packages\transformers\pipelines\base.py", line 1046, in forward
    model_outputs = self._forward(model_inputs, **forward_params)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\pipx\venvs\insanely-fast-whisper\Lib\site-packages\transformers\pipelines\automatic_speech_recognition.py", line 552, in _forward
    generate_kwargs["num_frames"] = stride[0] // self.feature_extractor.hop_length
                                    ~~~~~~~~~~^^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
TypeError: unsupported operand type(s) for //: 'tuple' and 'int'

This happens to me with both --flash true and --flash false. It does not happen with --timestamp chunk.
Happy to provide whatever additional information you need, just not sure what would be useful here -- but let me know!

Thanks for the bug report @alinsavix - This is a limitation. You can bypass this by passing --batch-size 1 for now. This is quite less efficient but still get's the job done.
Here's the issue where we are tracking this: https://github.com/Vaibhavs10/insanely-fast-whisper/issues/40
(I'll close this issue in favor of the one linked, feel free to re-open if you feel otherwise 🤗)


Retina on OS X and iOS

Canvas rendering on Retina iOS screens is wonky. The PFD looks pixel-doubled while regular HTML text looks ok.

Cool⚡


Seeking for VFW release

I wanna ask has H.266vfw codec been released? How can I obtain or how to build it?
Also, I tried to build this git using MakeFile in Ubuntu 20.04 server,
it just stuck in 34% and the system killed the process

What do you mean with H.266vfw? I don't know what its supposed to be.
Strange about your Ubuntu server build. Could you post some more information and logs?

vfw means Video For Windows
I just want to ask if there is a release for windows users
For the Ubuntu server build, the problem has resolved by upgrading the server's hardware, 2GB RAM isn't enough to build this massive work.

I see.
VVenC supports Windows mostly without issues, you can download the sources, compile it and use without problems.
We do not, and do not plan to, provide binary distributions for any platforms though.


spaceAfterObjectKeys: fix for computed properties

Ref my previous PR to fix: https://github.com/jscs-dev/node-jscs/pull/1481
Fixes #1742
@iamstarkov

looks good. thanks

Looks good. ;-)


Fresh Installation Admin only accesible from localhost

Hello, I have followed all the directions to install de Medusa Admin:
git clone https://github.com/medusajs/admin medusa-admin
cd medusa-admin
yarn install
yarn start
And all went fine but the Admin is only accessible from localhost. How can we enable to be accesible from the server IP ?
Kind Regards.

@Higherings  Can I get you to elaborate a bit on the request?
Are you looking to deploy admin to a production environment, or just change the host when running it locally?

Hello @olivermrbl, I would like to deploy Admin to a Production Environment. I want to be able to access it externally.

@Higherings I recommend checking out our guide for deploying admin on Netlify 👍

Closing this, since it's not an issue, but the standard way of setting up a Gatsby project

Thanks @olivermrbl for pointing where to search information. Just as a comment, it would be great if the README could have a Production Deployment Guide without using any other platform.


What wheels are available?

Is there a (public?) URL where one can see which wheels are available?
The README includes a link to https://dev.azure.com/astropy-project/wheel-forge/_build?definitionId=1 but I can't find that info there.

Not yet, because of the way Azure artifacts work. But you can run get_wheels.py to download all the available wheels for a given build locally for now. I agree it would be good to have a public feed in future, which is something I know is on the Azure roadmap.


collect dir entries while cleaning

change rehash to avoid calling std::fs::read_dir twice by collecting the entries while cleaning links
add documentation with example

Codecov Report

Merging #3 (f0af0d1) into main (da584eb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   94.48%   94.50%   +0.02%
==========================================
  Files           2        2
  Lines         272      273       +1
==========================================
+ Hits          257      258       +1
  Misses         15       15

Impacted Files
Coverage Δ

src/error.rs
17.64% <ø> (ø)

src/lib.rs
99.60% <100.00%> (+<0.01%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Release v1.2.0

TODOs

[x] Update version

[x] AssemblyVersion.cs
[x] .nuspec

[x] Update release notes
[x] GitFlow release
[x] GitHub release
[x] Close milestone

done


Fix to work with<EMAIL_ADDRESS>

Fixes #8
If you have a better solution in mind, by all means, use it.  :+1:

Thank you very much!


css bug: page too wide

regardless of window size, the page can always be scrolled left and right by a few percent.
this is quite annoying when scrolling with a touchpad…
not sure how to fix this, so making an issue

I don't have side scrolls, but you can remove them by adding overflow-x:hidden to the body.

ok, if no one else has this I can just add that to my custom.css
leaving this open for now to wait for further reports

Probably a CSS bug, I've noticed this as well when running rotonde client/portal out of the box. Mixed measurements might be the culprit.

this issue doesn't persist in the newest version. closing.


Don't require email for LDAP

This PR adds the ability to support LDAP authentication with a username unrelated to email as wanted  in #210.
The backend uses an LDAP_EMAIL_ATTR setting that maps an LDAP attribute to an email in order to ensure that users have an email address.
On the frontend side, this PR removes the email requirement when LDAP auth is enable. Maybe i'm missing something since I didn't find how it previously worked with the LDAP_APPEND_DOMAIN mechanism as it didn't accept non email username.
zulip-mobile
With the new zulip-moblie app, the login still requires the username to be an email address and using LDAP_EMAIL_ATTR won't work. On the other hand, the zulip-android has no issue.
Notes
On a side note, from what I saw, LDAP auth requires that get_realm_by_email_domain(email) returns something different than None. In my production env, I had to manually create a RealmDomain since a Realm (and its associated RealmDomain) is required at user creation. If I'm correct, maybe this should be written somewhere.

@Supermanu huge thanks for working on this!
I think probably what happened is that we recently regressed the username section of the login form to require an email address, not any username.  Probably what we should do is make it require an email if and only if an email is actually required; we can do that by detecting the situation inside zerver/context_processors.py, setting a variable, and then accessing that variable in the template.
Our plans actually include removing get_realm_for_email_domain before the next release, so I think we'll end up fixing that already.
I'll take a look at the code now, just wanted to note the context.

Generally, this looks great, thanks for working on this!  I especially appreciate the work on docs and tests.  Having read the code in this PR, here's what I think we want to do:

We should probably have the condition for whether an email is required be more precise (the current code would stop requiring email format even if we know the LDAP configuration is such that usernames are email addresses).  So not ldap_auth_enabled(realm) but require_email_format_usernames, which could be a new function in zproject/backends.py that is computed by checking ldap_auth enabled(realm), LDAP_APPEND_DOMAIN, etc. (and anything we add in the future that has non-email usernames).  We can then unit test that function and use it both here and to provide a new field in the /server_settings endpoint for use by the mobile app in generating its login page.

@borisyankov FYI; we'll want to do a small tweak to update the mobile app to support login with username that's not an email for these configurations.  I think what this means is we should add the require_email_format_usernames field to the server_settings endpoint, and the mobile app can check if that field appears; if it does and is false, it shouldn't require the username to be an email address.
Again, huge thanks for working on this @Supermanu!  Let me know when you have a revised version ready.

@timabbott what about adding this to the get_auth_backends call?

@borisyankov yeah that's what I meant by /server_settings; but the old get_auth_backends is deprecated in favor of the cleaner interface of /server_settings.  If you want we can put it in both.

Ah, not sure we want to, but we are still using get_auth_backends in the mobile app.
Can we replace it with server_settings or do we need to support both?

I think now that the mobile app basically requires 1.6 anyway, we can use server_settings.

I'm on it and thanks for the feedback, I appreciate!

I implemented the use of server_settings yesterday. When you decide how you will pass this information via the API, I'll implement the login via username too.

@timabbott That's it, I pushed  the changes on my branch.

I added the functionrequire_email_format_usernames(realm) into backends.py and the related tests. If there are too many tests, let me now.
I made that function available through context_processors.py as well as email_auth_enabled since we can have three different formatting cases (only emails, both emails and usernames and only usernames). Changes I reflected on the login.html template.
Also I tried to make each commit successful relatively to unit tests.
Is there something else I can do?

This looks great.  The tests are a bit verbose (I might have put them all in one test function), but certainly reasonable and cover the cases well.  I rearranged the commits a tiny bit to put the documentation for LDAP_EMAIL_ATTR in the same commit that implements it, and also to set a default of None in DEFAULT_SETTINGS in  zproject/settings.py so that servers with config from older copies of the template won't crash.
Merged with those tweaks, thanks @Supermanu!!

@borisyankov I also added a commit adding some additional data to server_settings.  You should note the approach @Supermanu used for the login form to suggest "Email", "Username", or "Email or Username" in the label for the username field, depending whether we know what is allowed (though the "Email or Username" case should be exceedingly rare, since most folks using LDAP will only allow LDAP auth).


adding RecSys multi-modal data example

This project adds an an example of RecSys on multi-modal data. It contains end-to-end workflow from data collection, enrichment, feature extraction, to training.

@vinhngx I tried to go through your workflow but encountered an issue. It seems like notebook 06 cannot find train and validation data processed by NVT. Maybe you need to insert another notebook between notebook 05 and notebook 06? I found "02-ETL-with-NVTabular.ipynb" in your working directory, is this the correct one to run before notebook 06? Let me know if I miss anything.

added ETL notebook. Thanks.

Just want to touch base re. this PR. Beyond minor improvement in data collection, do you think we shall publish the first iteration of this, or should we wait till NVTabular support for pre-trained embedding is completed? Thoughts? @benfred @karlhigley

Sorry, looks like we've been slow responding. 😅
@benfred Thoughts on publishing this example? Do we save it to publish with pre-trained embedding support? 🤔

closing & re-targeting HugeCTR, featuring HugeCTR new functionality to support pretrained embedding.


Add covid19-tracker-cli

A curl-based command line tracker for Novel Coronavirus or COVID-19 pandemic. It Supports terminal for linux and macos, command prompt for windows, and termux for android with real-time updates. curl -L covid19.trackercli.com

@jkga
Read the contribution guidelines please.


support 'flare' type data.

Hi @bumbeishvili, sending PR to support "flare" type data, rather than only flat data.
{
name: "giorgi",
data_type: "flare", // here I put data_type field to guess which hierarchy function to use. You can use different approach if you want.
children: [],
}

duplicate of #93


Update /api/set-notification-state

Update /api/set-notification-state so that it matches the signature in https://github.com/serlo/api.serlo.org/pull/189 (Move id parameter into request body load)

@inyono Changes in api.serlo.org have been merged.

@inyono Changes in api.serlo.org have been merged.

Gonna merge this but the contract tests still need some work: https://github.com/serlo/api.serlo.org/issues/209

Gonna merge this but the contract tests still need some work: https://github.com/serlo/api.serlo.org/issues/209


Canvas renderer cursor do not hide

Cursor may not hided sometimes with the canvas renderer.
Details

Browser and browser version: Chrome 60.0.3112.113
OS version: MacOS Sierra 10.12.6
xterm.js version: v3 HEAD

Steps to reproduce

run htop (brew install htop)
or run sl (brew install sl)

Screenshots

Thanks for the report, I can reproduce.

brew is a macOS-specific package manager.


New Endpoint - /city/all - returns all cities in database with only the id and name field

Description
New Endpoint - /city/all - returns all cities in database with only the id and name field.
GET https://stagebe.letsmovehomie.com/city/all
RETURNS:
{
  "cities": [
    {
      "_id": "5d8117e66b3c9148110e3104",
      "name": "Albuquerque, NM"
    },
    {
      "_id": "5d8117e66b3c9148110e3105",
      "name": "South Valley, NM"
    },
    ...
    ]
}

Type of change

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Change status

[x] Complete, tested, ready to review and merge

How Has This Been Tested?

[x] Tested endpoint locally on Insomnia

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] There are no merge conflicts

Nice work!


Update based on Sarah's review

Change the calling of the function CalculateResolutionNoiseDensity() to be the last in the if/else structure since it is the most recently defined function (lines 782-785)
Lines 1301 and 1306 contain undefined constants (1.6, 1e6, and 1e3) that should be variables defined after line 1248
There is an unnecessary whitespace after the colon on line 1675

@sastorer-ms, @Yongjie2018, could you please review this new PR? Thank you.


Please create WebPubSub bindings library that will work with Azure Function Isolated Process

Is your feature request related to a problem? Please describe.
I'd like to use WebPubSub bindings in an Azure Function Isolated Process App.
Describe the solution you'd like
According to the documentation, Isolated Process process apps use Microsoft.Azure.Functions.Worker.Extensions.* packages instead of WebJobs packages.
Are there plans to create a version of the WebPubSub binding that works with Isolated Process Function apps?

Yes, this is under planning.
BTW, Function v4 with .NET6.0 supports In-process and naturally work with the function extensions, see Supported Versions. Is there any special reasons require to work with Out-of-process specifically?

Thank you for your response. I'll be looking forward to being able to add WebPubSub to my current project.
I'm developing this project using the out-of-process mode. I think the reasons for wanting this are the same as for wanting to run out-of-process in general:
https://docs.microsoft.com/en-us/azure/azure-functions/dotnet-isolated-process-guide#benefits-of-running-out-of-process

Any progress on this? .NET 7 has been released and the in-process runtime will go away in a not to distant future.

Isolated process support is in progress.

Initial beta version is released.
Besides, see samples HERE


Cell text rotation is not working

// 'workbook' is the predefined global object for workbook instance of control
//

var sheet = workbook.currentWorksheet;

var cell = sheet.getCell("A1");
cell.Data = 'hello';
cell.Style.RotateAngle = -90;

Fixed, please use rotationAngle or RotationAngle in script from latest version.

Is this update avaliable for WPF?

WPF text rotation has been now supported #180


Editor needs to be able to resolve relative image links within lockbook

#2030 trying to use google photos is not working out for me anymore

fixed by https://github.com/lockbook/lockbook/pull/2695


Add event vuetable:checkbox-toggled to changes list

vuetable:checkbox-toggled was not listed in available events, so it should be added.

@jeitnier Thanks. :)


wip: Alloy migration example

Hey there
just a small example of what migrating to Alloy would look like. Feel free to run the tests, if this isn't needed currently, ignore.
Details:
A switch from ethers provider api to alloy's.
Provider struct including fields for Arc'd provider, cache, and max block range.
Fn for getting latest block including cache hit check.
Includes tests using rpc urls
Todo:
Retry client options including max compute units etc
helper fns
create_client fn that uses retry client options.

Thanks for the start - this task is pretty complex as it has ethers in tons of place it’s probably going to be better if I deal with it as I know the codebase pretty well it’s on list and il use this for reference as I go


Auto camel case?

ideas:

autoConvertCamelCase( true/false )
reader->to_abap( 'abcXyz' ) => abc_xyz
writer->set( structure ) -> abcXyz
writer->push

Closed with #44

Closed with #44


add fine-grained stepsize control to simulate tab

Currently the user can set the length of simulation, and the interval between images / data points.
It is then possible to simulate part of the simulation with fine time resolution of images, and another part with coarse time resolution. But if the user wants to repeat this they have to manually do the two simulations and adjust the timesteps in between.
As suggested by René it would be nice if the user could specify this up front.

UI

dialog for setting list of times with intervals?
some "advanced" text format input option e.g. list of start:end:interval values: "0:10:1, 10:100,20"
check how copasi does this, would be nice to be consistent with them if possible

think about how/where to store this

sbml annotation?

note we currently don't store the length of the simulation or timestep in the model

One simple option would be to allow a semicolon delimited list of values for both simulation length and image interval, e.g.
e.g. 0->100 with image interval 0.1, 100->500 with image interval 20, 500->550.2 with image interval 0.01 would be:

length: 100;400;50.2
interval: 0.1;20;0.01

If number of intervals doesn't match length, they can be padded with last value or trimmed such that the number of values matches in both/
First/last semicolons would be optional, so a single number for each value remains valid


Spec migration

Ref: #650
Staging branch for specs migration. Draft PR so it can be tracked.

hmm I can't merge main into this branch

I wanted to merge main to pick up the new CODEOWNERS file

What's the status of this?

@musalbas apologies for delayed response. @adlerjohn and I triaged issues in https://github.com/celestiaorg/celestia-app/issues/650 today.
I think that the specs-staging branch is already a more accurate representation of the specs than https://celestiaorg.github.io/celestia-specs/latest/index.html so I'd like to merge specs-staging to main ASAP. But if we want to block this merge on updating specs to match the existing implementation, we can block on all the issues in the "Pure specs" section.

What's the latest with this and generally adding specs to celestia-app/core now?

This branch is the most up to date version of the specs but it's not publicly visible yet. IMO we should merge this branch to main, make it publicly visible, and take down the existing specs site at https://celestiaorg.github.io/celestia-specs/latest/index.html
The remaining specs issues are tracked under https://github.com/celestiaorg/celestia-app/issues/650 . We intend on prioritizing specs and documentation work after the core/app feature freeze for incentivized testnet.

I have some general comments that can possible be followed up at a later point:

Can we break up data structures into smaller more self-explanatory files so that parts can be easily accessed in the table of contents. I also think it's less intuitive to explain a spec by just dumping all the data structures that are included in it. Would prefer more of a hierarchical function-orientated tree.
Can we add a section explaining how the "celestia app" fits in with the rest of the system and include links so people can be easily redirected if they're interested with something in "celestia node" for example. Furthermore, I think calling it "celestia app" can be better worded. As this isn't the specification of the entire system, rather a component of it, we should look to distinguish it functionally. Call it "celestia data publication specification" (to complement "celestia data availability specfication") if we want to be deliberate about having two networks.
I don't think Rationale should be a separate section but should be embedded right next to the part in the spec it refers to. I should read what a certain protocol is and directly after why it is so.
It's evident that the specification includes not just novel work specific to Celestia but the components that it is built on top of. There is a lot of work on Tendermint's consensus algorithm (such as block validity, leader selection) and how the validator set is controlled. What about other components like governance, IBC, vesting, upgrades that still seem to be missing. It seems that not all state transition messages have been documented.
Is QGB spec somewhere else?
Can we have some preamble/context in the top level pages to each of the subpages.
Are we sure we want a copy of many of the proto files in the spec as well? These are not the canonical ones that get used in generation and will constantly become outdated.

Will merge this by EOD tomorrow if no more feedback.

its weird that the docker builds are still failing here despite passing in other PRs, we didn't change anything related here afaict


[crypto] Switch to strict Ed25519 signature verification

This adopts the strict check on the order of the R component of an Ed25519 signature, as this project used to have, but removed for performance reasons in #876 . This check is routinely used in LibSodium, and hinted at in RFC8032 5.1.7 §3.
This check is discussed in [Brendel at al. 2020] §5.4 and provides message binding, along with protection against substitution attacks. A proptest added in the present PR makes a possible substitution explicit, and should make it clear that this check will probably not reject any "clumsy but honest" signatures or pose significant backwards compatibility issues.
Finally, a minimalist benchmark is added to check that https://github.com/dalek-cryptography/ed25519-dalek/pull/98 provides a performant way to do this check.
Before:
Ed25519 signature verification
                        time:   [48.504 us 48.974 us 49.757 us]
Found 14 outliers among 100 measurements (14.00%)
  1 (1.00%) high mild
  13 (13.00%) high severe

After:
Ed25519 signature verification
                        time:   [51.086 us 51.522 us 52.113 us]
Found 27 outliers among 100 measurements (27.00%)
  7 (7.00%) low mild
  5 (5.00%) high mild
  15 (15.00%) high severe

@bors-libra r=kchalkias

:pushpin: Commit 6440f21 has been approved by kchalkias

:hourglass: Testing commit 6440f21860e8c24899eba926a8d0fb72af13f292 with merge 77fd504bc09a9517247a3a4f85d468698dba6a94...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: kchalkias
Pushing 77fd504bc09a9517247a3a4f85d468698dba6a94 to master...


Adding Self-Hosted Support & Documentation

I think it will be easier for people to self-host this project on perm or as an enterprise solution for communication if there will be some proper documentation and releases for the project.
Would be cool to take this issue if possible.

Yeah this is definitely needed

Would be cool to take this issue if possible.

Go ahead!

I made an initial version: https://github.com/quackduck/devzat/blob/main/Admin's Manual.md
Feel free to suggest what other information should be added to it

I made an initial version: https://github.com/quackduck/devzat/blob/main/Admin's Manual.md
Feel free to suggest what other information should be added to it

as someone not familiar with go - i would need information on how to build this - as i am stumped when I see this after entering go install :
devchat.go:4:2: cannot find package "embed" in any of:
        /usr/lib/go-1.10/src/embed (from $GOROOT)
        /root/go/src/embed (from $GOPATH)
colors.go:10:2: cannot find package "github.com/acarl005/stripansi" in any of:
        /usr/lib/go-1.10/src/github.com/acarl005/stripansi (from $GOROOT)
        /root/go/src/github.com/acarl005/stripansi (from $GOPATH)
commands.go:15:2: cannot find package "github.com/alecthomas/chroma" in any of:
        /usr/lib/go-1.10/src/github.com/alecthomas/chroma (from $GOROOT)
        /root/go/src/github.com/alecthomas/chroma (from $GOPATH)
colors.go:11:2: cannot find package "github.com/alecthomas/chroma/styles" in any of:
        /usr/lib/go-1.10/src/github.com/alecthomas/chroma/styles (from $GOROOT)
        /root/go/src/github.com/alecthomas/chroma/styles (from $GOPATH)
twitter.go:9:2: cannot find package "github.com/dghubble/go-twitter/twitter" in any of:
        /usr/lib/go-1.10/src/github.com/dghubble/go-twitter/twitter (from $GOROOT)
        /root/go/src/github.com/dghubble/go-twitter/twitter (from $GOPATH)
twitter.go:10:2: cannot find package "github.com/dghubble/oauth1" in any of:
        /usr/lib/go-1.10/src/github.com/dghubble/oauth1 (from $GOROOT)
        /root/go/src/github.com/dghubble/oauth1 (from $GOPATH)
devchat.go:24:2: cannot find package "github.com/gliderlabs/ssh" in any of:
        /usr/lib/go-1.10/src/github.com/gliderlabs/ssh (from $GOROOT)
        /root/go/src/github.com/gliderlabs/ssh (from $GOPATH)
colors.go:12:2: cannot find package "github.com/jwalton/gchalk" in any of:
        /usr/lib/go-1.10/src/github.com/jwalton/gchalk (from $GOROOT)
        /root/go/src/github.com/jwalton/gchalk (from $GOPATH)
colors.go:13:2: cannot find package "github.com/quackduck/go-term-markdown" in any of:
        /usr/lib/go-1.10/src/github.com/quackduck/go-term-markdown (from $GOROOT)
        /root/go/src/github.com/quackduck/go-term-markdown (from $GOPATH)
devchat.go:25:2: cannot find package "github.com/quackduck/term" in any of:
        /usr/lib/go-1.10/src/github.com/quackduck/term (from $GOROOT)
        /root/go/src/github.com/quackduck/term (from $GOPATH)
commands.go:18:2: cannot find package "github.com/shurcooL/tictactoe" in any of:
        /usr/lib/go-1.10/src/github.com/shurcooL/tictactoe (from $GOROOT)
        /root/go/src/github.com/shurcooL/tictactoe (from $GOPATH)
slack.go:11:2: cannot find package "github.com/slack-go/slack" in any of:
        /usr/lib/go-1.10/src/github.com/slack-go/slack (from $GOROOT)
        /root/go/src/github.com/slack-go/slack (from $GOPATH)
config.go:5:2: cannot find package "gopkg.in/yaml.v2" in any of:
        /usr/lib/go-1.10/src/gopkg.in/yaml.v2 (from $GOROOT)
        /root/go/src/gopkg.in/yaml.v2 (from $GOPATH)

@elbosso your version of the Go compiler is woefully out of date:

/usr/lib/go-1.10/src

Go 1.10 was release in early 2018. Update your compiler to (at least) 1.17 and the project should install/compile successfully.

Added https://github.com/quackduck/devzat/commit/962d63cbd3d6bff1d42bd5dc7711aa82af22364a. That should make things clearer if someone has a similar problem.

This is unfortunate. I tried this on an arm64 architecture and there dies not seem to be a more recent version of go available...
But thanks, anyway!

Nah there’s a release for every platform Go builds to. You can get it directly from the Go site: https://go.dev/dl if nothing else works, or follow whatever guide comes up when you google “install go <your package manager>”

Let me know if it worked out @elbosso

will do - at the moment I am kind of busy breaking in my new kitchen...

lol nice

I think this is mostly fixed now


Can this boot mobile?

You mean on an arm based smartphone? No, only x86_64 is supported right now.

You mean on an arm based smartphone? No, only x86_64 is supported right now.

Got it, thanks!


⚠ Bofrost.fr has degraded performance

In e57b1ba, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 911 ms

Resolved: Bofrost.fr performance has improved in a6a2a1c.


Lock Forestry

I think your Option should have the either same setting as the 'Lock Forestry Resource' mod or should inform that there is another Mod active doing the same and pathing that one out...
ATM both conflict each other... 'Lock Forestry Resource' mod is on locked status and TreeAnarchy not... but 'Lock Forestry Resource' mod is used for locking
btw... it would be nice to have a shortcut for this to activate/deactivate and an visible indicator ingame (maybe recolor the Landscaping UI icon or Forest Brush UI button if that one is installed

The old Lock Forestry mod used a Harmony prefix to reroute NaturalResourceManager::TreesModified function. I intend to do some fine tuning inside this method, thus I suggest to stop using Lock Forestry and uninstall it, Just use my version of Lock Forestry, where I used Transpilers to enable the same functionality. This ensures future compatibility.
As for your suggestion with a shortcut (an icon, or a keymapped shortcut), I have been considering it. Because I rarely use this function, and I only use this forestry when I'm creating the forestry industry, I felt that it wasn't necessary, and avoid UI clutter.
I think it best to get some more input before I take time to implement this function.
I'm currently working on improving the FPS of tree rendering. So far I've shaved off around 10ms of computation time per frame.

key binding function added for lock forestry. Closing


Fix mismatched base vs self in get/set associatedObject

I don't understand the whole source yet,
but mismatch in get/set seems wrong.
Please check it out.

Current coverage is 68.70% (diff: 100%)

Merging #354 into master will not change coverage

@@             master       #354   diff @@
==========================================
  Files            49         49
  Lines          2259       2259
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1552       1552
  Misses          707        707
  Partials          0          0

Powered by Codecov. Last update 3f013a7...bf9d59c

Yes, that makes sense. Thanks @jechol !


Support for 1.0

Support for 1.0, based on Hackage uploads
Updated example project

I wasn't to build example project as is, so I needed some changes

Made corrections so there is no more conflicts


Tab Completion in Azure CLI does not work

Tab Completion in Azure CLI does not work as it used to work on Azure PowerShell or PowerShell. Tab completion provides automatic help when you are typing in the command pane and  pressing TAB will automatically complete a command. I am using latest version of Azure CLI on Windows 10.
azure-cli                         2.12.0
core                              2.12.0
telemetry                          1.0.6

@pratapscil Thanks for the feedback. Azure CLI's Intellisense or auto-complete feature is not supported on Windows. It only works with Linux Bash as of today.
Having said that, you could use auto-complete with Azure CLI commands on WSL or on VS Code using WSL Bash by updating your editor's settings.json file:
"terminal.integrated.shell.windows": "C:\\WINDOWS\\System32\\wsl.exe",

@jiasli Please add any additional inputs you may have.

@pratapscil Hope the above inputs help. Are there any further questions here?

We are currently experimenting with enabling auto-complete in PowerShell (https://github.com/Azure/azure-cli/pull/13576). Fortunately, this is not amongst our high-priority work items and we can't provide a solid ETA.

Thank you for the update.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From: Jiashuo<EMAIL_ADDRESS>Sent: Friday, September 25, 2020 11:07 AM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs-cli] Tab Completion in Azure CLI does not work (#2198)
We are currently experimenting with enabling auto-complete in PowerShell (Azure/azure-cli#13576https://github.com/Azure/azure-cli/pull/13576). Fortunately, this is not amongst our high-priority work items and we can't provide a solid ETA.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs-cli/issues/2198#issuecomment-698730375, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH3RPKV5AQNALJDXM7PXG5LSHQUB5ANCNFSM4RXGW7KQ.

Thank you for the quick response.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From<EMAIL_ADDRESS>Sent: Thursday, September 24, 2020 10:48 PM
To<EMAIL_ADDRESS>Cc<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs-cli] Tab Completion in Azure CLI does not work (#2198)
@pratapscilhttps://github.com/pratapscil Hope the above inputs help. Are there any further questions here?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs-cli/issues/2198#issuecomment-698477129, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH3RPKTWM4SXZH3CSDNF7ZLSHN5OFANCNFSM4RXGW7KQ.

@pratapscil Thanks for the response.
We will now proceed to close this thread as resolved, but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


load: cannot load such file

Hello,
My environment is :

rvm 1.29.8
gem 3.0.3
ruby 2.6.3

By default, I got Bundler 1.17.2.
In order to get Bundler 2.0.1, I install it with
gem install --default bundler -v '2.0.1'
I got a error when using it :

load: cannot load such file

Try running
gem install bundler

It still automatically installs bundler 2.0.1

Already tried. It creates directory with files and add it to gem list but is not functionnal.
The error happens when I try to execute bundler such as :
bundler --version
I managed to the error by removing RVM
gem uninstall -aIx rvm implode gem uninstall rvm gem dependency devise --pipe | cut -d \  -f 1 | xargs gem uninstall -a /usr/bin/sudo rm -rf $HOME/.rvm $HOME/.rvmrc /etc/rvmrc /etc/profile.d/rvm.sh /usr/local/rvm /usr/local/bin/rvm
... and reinstall it from scratch, with bundler as the first gem installed.


Jetpack compose sample

This pull request shows how to use Paypal checkout sdk with Jetpack compose.
The code sample can be customized depending on the developer's needs.
Please note, the code sample is intended to be a hands-on sample.
This PR closes (can close) issue Issue 98

@sumanabhi  Moved the checkout state into its package, I think it is neater now.


Use Trusted Artifacts in CI

EC is failing because buildah-remote-oci-ta is not in the list of trusted tasks. I'll continue to investigate it on Monday.


Audio : Fix Profiler Bug + Added stops events fade

audio - added a fix profiler bug + added Stops events with fades + if emitter is null, UAudioManager = emitter

Removed needless lines


1617 Make class DataGeneration abstract

Make DataGeneration an abstract class, only subclasses should be used. Remove datgen as a valid typecode. Move omprc as a vaild typecode for subclasses.
This PR is needed so we can migrate slots off of other classes onto either NucleotideSequencing or MassSpectrometry

This looks good to me. The only thing I noticed, I commented each I found above. In the example data files, sometimes the prefix dgms is used and sometimes dgns is used. Based on the changes to the syntax in the schema, I think we just want dgns correct? Otherwise, it looks good to me.

dgms is the typecode for Class MassSpectrometry, dgns is for NucleotideSequencing so we need both typecodes

Requires migration, but done in parallel with another PR