Magic Item Definitions

I saw this other SRD repo has a json list of magic items included in the SRD.
Has there been any investigation to adding these to 5e-database?

Not that I know of, but we'd happily like it if we don't already have it.
On Mon, Nov 25, 2019 at 12:31 PM Andrew Hansen<EMAIL_ADDRESS>wrote:

I saw [this other SRD repo[(
https://github.com/BTMorton/dnd-5e-srd/blob/master/json/10 magic items.json)
has a json list of magic items included in the SRD.
Has there been any investigation to adding these to 5e-database?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/adrpadua/5e-database/issues/115?email_source=notifications&email_token=AACWKWTT2OWJFA6C3C3QFFDQVQYZJA5CNFSM4JROLWO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H35Q4UA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACWKWURMVLZOMMM6PQBHOLQVQYZJANCNFSM4JROLWOQ
.

I was thinking about the schema and came up with this. I'd be happy to discuss it further.
{
	index: String, // "goggles-of-night"
	name: String, // "Goggles of Night"
	item_category: String, // "Wondrous Item"
	type: String, // For subtypes maybe?
	rarity: String, // Uncommon
	cost: {}, // not sure about this, there's no price in SRD only DMG
	desc: [], // array of strings
	attunement: Boolean,
	attunementDescription: String, // like class-only
	weight: Number, // 0
	modifiers: [
		{
			type: String, // "Sense"
			name: String, // "Darkvision"
			value: Number // 60
		}
	],
	spellcasting: {
		charges: Number, // e.g. 10
		recharge String, // e.g. regains 1d6 charges every dawn
		spells: [
			{
				name: String, // "Fireball"
				url: String, // "/api/spells/fireball"
				spell_charge: Number // how many charges does it cost
			}
		]
	},
	url: String
}

There's also the question of how to handle weapons and armor since they have a lot more properties but it's overlapping with the base weapon/armor.

Would item_category just be a reference to something over here?
https://github.com/bagelbits/5e-database/blob/master/src/5e-SRD-Equipment-Categories.json

Would item_category just be a reference to something over here?
What are subtypes?
I would probably drop cost if it's not in the SRD. We're not including anything that isn't in the SRD.
Should the modifiers link to Traits? Or are there some modifiers that aren't Traits?
Honestly, if you really want, we can start with just:
{
  index: String,
  name: String,
  equipment_category: {
    name: String,
    url: String,
  },
 desc: [],
 url: String
}

And only add fields that aren't immediately encapsulated there? I can see modifies and spellcasting be its own schema discussion but are currently "covered" with description.
@ogregoire Any thoughts on this?

Yes, I've been thinking the same: start simple then find structures where they are, or when needed.

Actually yes, description can cover any effects. I just thought about organizing those effects similar to how DnDBeyond handles them, but it certainly does not have to be part of the first model.

I would keep rarity, because it could be a useful as a query parameter.
For item_category˛, I had these in mind:

Armor
Potion
Ring
Rod
Scroll
Staff
Wand
Weapon
Wondrous Item

These are also taken from DnDBeyond.

Actually, I would really keep it as simple as @bagelbits mentioned.
{
  "index": String,
  "name": String,
  "equipment_category": EquipmentCategory,
  "desc": Array<String>,
  "url": String
}

Why so simple? Because of the one reason I never worked on them: they're extremely complex. When you think about adding rarity, I already present you the Figurine of Wondrous Power. How do you dataify it?

Figurine of Wondrous Power
Wondrous item, rarity by figurine
A figurine of wondrous power is a statuette of a beast small enough to fit in a pocket. If you use an action to speak the command word and throw the figurine to a point on the ground within 60 feet of you, the figurine becomes a living creature. If the space where the creature would appear is occupied by other creatures or objects, or if there isn’t enough space for the creature, the figurine doesn’t become a creature.
The creature is friendly to you and your companions. It understands your languages and obeys your spoken commands. If you issue no commands, the creature defends itself but takes no other actions.
The creature exists for a duration specific to each figurine. At the end of the duration, the creature reverts to its figurine form. It reverts to a figurine early if it drops to 0 hit points or if you use an action to speak the command word again while touching it. When the creature becomes a figurine again, its property can’t be used again until a certain amount of time has passed, as specified in the figurine’s description.
Bronze Griffon (Rare). This bronze statuette is of a griffon rampant. It can become a griffon for up to 6 hours. Once it has been used, it can’t be used again until 5 days have passed.
Ebony Fly (Rare). This ebony statuette is carved in the likeness of a horsefly. It can become a giant fly for up to 12 hours and can be ridden as a mount. Once it has been used, it can’t be used again until 2 days have passed.
Giant Fly
Large beast, unaligned
Armor Class 11
Hit Points 19 (3d10 + 3)
Speed 30 ft., fly 60 ft.
STR DEX CON INT WIS CHA
14 (+2) 13 (+1) 13 (+1) 2 (−4) 10 (+0) 3 (−4)
Senses darkvision 60 ft., passive Perception 10
Languages —
Golden Lions (Rare). These gold statuettes of lions are always created in pairs. You can use one figurine or both simultaneously. Each can become a lion for up to 1 hour. Once a lion has been used, it can’t be used again until 7 days have passed.
Ivory Goats (Rare)._ These ivory statuettes of goats are always created in sets of three. Each goat looks unique and functions differently from the others. Their properties are as follows:

The goat of traveling can become a Large goat with the same statistics as a riding horse. It has 24 charges, and each hour or portion thereof it spends in beast form costs 1 charge. While it has charges, you can use it as often as you wish. When it runs out of charges, it reverts to a figurine and can’t be used again until 7 days have passed, when it regains all its charges.
The goat of travail becomes a giant goat for up to 3 hours. Once it has been used, it can’t be used again until 30 days have passed.
The goat of terror becomes a giant goat for up to 3 hours. The goat can’t attack, but you can remove its horns and use them as weapons. One horn becomes a +1 lance, and the other becomes a +2 longsword. Removing a horn requires an action, and the weapons disappear and the horns return when the goat reverts to figurine form. In addition, the goat radiates a 30-‐‑foot-‐‑radius aura of terror while you are riding it. Any creature hostile to you that starts its turn in the aura must succeed on a DC 15 Wisdom saving throw or be frightened of the goat for 1 minute, or until the goat reverts to figurine form. The frightened creature can repeat the saving throw at the end of each of its turns, ending the effect on itself on a success. Once it successfully saves against the effect, a creature is immune to the goat’s aura for the next 24 hours. Once the figurine has been used, it can’t be used again until 15 days have passed.

Marble Elephant (Rare). This marble statuette is about 4 inches high and long. It can become an elephant for up to 24 hours. Once it has been used, it can’t be used again until 7 days have passed.
Obsidian Steed (Very Rare). This polished obsidian horse can become a nightmare for up to 24 hours. The nightmare fights only to defend itself. Once it has been used, it can’t be used again until 5 days have passed.
If you have a good alignment, the figurine has a 10 percent chance each time you use it to ignore your orders, including a command to revert to figurine form. If you mount the nightmare while it is ignoring your orders, you and the nightmare are instantly transported to a random location on the plane of Hades, where the nightmare reverts to figurine form.
Onyx Dog (Rare). This onyx statuette of a dog can become a mastiff for up to 6 hours. The mastiff has an Intelligence of 8 and can speak Common. It also has darkvision out to a range of 60 feet and can see invisible creatures and objects within that range. Once it has been used, it can’t be used again until 7 days have passed.
Serpentine Owl (Rare). This serpentine statuette of an owl can become a giant owl for up to 8 hours. Once it has been used, it can’t be used again until 2 days have passed. The owl can telepathically communicate with you at any range if you and it are on the same plane of existence.
Silver Raven (Uncommon). This silver statuette of a raven can become a raven for up to 12 hours. Once it has been used, it can’t be used again until 2 days have passed. While in raven form, the figurine allows you to cast the animal messenger spell on it at will.

Yeah, you're rigth. We would need separate entries for all those items but not right now.
What about the magical item categories, like "Wondrous Item". Do you think we could include it?

We already have the equipment_category in its own file and in the equipment file. Let's try reusing/extending that one. If needed we might choose to rename it to item_category instead of equipment_category, but we're not there yet. Iterations is the key here.

Yup! I agree with @ogregoire on all of this. It's best to keep it really simple on the first version. And after we get it all in, we can start on separate efforts to extract patterns. As I lovingly tell other engineers at work, K.I.S.S.: Keep It Simple, Silly.
I would adjust the proposed schema to:
{
  "index": String,
  "name": String,
  "equipment_category": {
    "name": String,
    "url": String
  },
  "desc": Array<String>,
  "url": String
}

As an aside, I noticed in Equipment, we refer to equipment_category as such:
"equipment_category": "Weapon",

So I'm going to cut a separate issue to get that updated.

I think we're all on the same page for the V1 of this. @vpeter1119, if you still feel up to pushing forward with a PR for this, feel free to. :D

Okay, I've setup a WIP PR for this. I'm slowly working my way through the SRD to get this all added. However, I'd love feedback for where it is so far.


Revisit accessibility solution in  https://github.com/microsoft/AdaptiveCards/pull/6763#issuecomment-1171999511

Revisit https://github.com/microsoft/AdaptiveCards/pull/6763#issuecomment-1171999511
@compulim
(I know not many people will read comments in merged/closed PRs. But I will just keep it here.)

IMO, role="toolbar" is a better role for grouping buttons. Some screen readers read "1 of 6" even without aria-posinset for things inside role="toolbar".

Turning a button into menu item hurts accessibility as shortcut keys that normally applies to buttons (and form fields) will no longer apply to menu item. Say, pressing B or F in Narrator will jump to the next closest button. However, it won't jump to button[role="menuitem"].

Buttons in toolbar are still buttons. Buttons in menu bar are no longer buttons. Better to stay as close to its original form as possible.

@paulcam206 FYI


latest firefox addon api breaks this plugin (review Redirector for fix?)

Apparently this is no longer an issue, probably just one of the regexes needs work.


Tag to digest

The names are a bit confusing for the bundle. This field is supposed to be a digest.

/lgtm


doc updates: contributing datasets and generate authors list from AUTHORS

Docs for contributing

fix #46
adapted from https://github.com/MDAnalysis/MDAnalysisData/wiki/add-new-data-set

generate authors in docs from AUTHORS (similar to what MDAnalysis does) via generated authors.py
fixed metadata in setup.py
update CHANGES

Hello @orbeckst! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file MDAnalysisData/__init__.py:

Line 20:80: E501 line too long (96 > 79 characters)

In the file MDAnalysisData/tests/test_package_metadata.py:

Line 5:1: E302 expected 2 blank lines, found 1
Line 11:1: E302 expected 2 blank lines, found 1

In the file docs/conf.py:

Line 28:1: E402 module level import not at top of file

In the file setup.py:

Line 26:1: E302 expected 2 blank lines, found 1
Line 30:1: E302 expected 2 blank lines, found 1

@orbeckst I've not reviewed yet since you seemed to be actively doing commits on this, let me know when you want me to have a look?

I'm done, I was just bored while making breakfast and fixed a typo.
Originally I only wanted to add the contributions page but then added the AUTHORS processing, and then figured that testing the authors processing involved mocking imports, and then it spiralled out of control ;-). Sorry for such a heterogenous PR.
Anyway, if you could have a quick look then that would be much appreciated.

I rewrote the history so that the three different things (doc update, setup.py fixes, and author list) are separate commits; should be mergeable as is. Thank you @IAlibay for the simpler solution with monkeypatch.

Can you please block the merge again? I realize that I took dynamic_authors() from the MDA setup.py which is also under GPL. This needs to be either rewritten or (according to git blame setup.py) I need @jbarnoud @lilyminium @tylerjereddy (who all edited the code) to re-license dynamic_authors under BSD-3.

I added the re-licensing note.

Yep, thank you!


I don't want redisson connect to some specific nodes in redis cluster, can I do it?If yes, how?

I have a redis cluster with 3 master and 6 slave,and I want redisson only connect to the nodes in config file.

I'm afraid no

Thanks, I think I should modify my  play


CloudSync guidance not accurate

The steps in "Create a custom synch rule in Azure AD Connect cloud sync for EmployeeHireDate" recommend a mapping with "Source attribute: msDS-cloudExtensionAttribute1" but msDS-cloudExtensionAttribute1 is not available in Cloud Sync out-of-the-box.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 53987154-8f6c-1ddd-ec02-2b811ae74818
Version Independent ID: eaf44627-eddc-5aeb-7189-661d5dcb90fe
Content: How to synchronize attributes for Lifecycle workflows - Microsoft Entra
Content Source: articles/active-directory/governance/how-to-lifecycle-workflow-sync-attributes.md
Service: active-directory
Sub-service: compliance
GitHub Login: @OWinfreyATL
Microsoft Alias: owinfrey

@AlexFilipin
Thanks for your feedback! We will investigate and update as appropriate.

@AlexFilipin
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly

@OWinfreyATL created https://github.com/MicrosoftDocs/azure-docs/pull/99618 should be fine as is

#please-close


Extend the update type

Add channel post and edited channel post.

Hi, just got a chance to take a look at this & it looks pretty good. I'll go ahead and merge it now, though since this adds new features we'll probably want to get this part of a release.


How to allow Bolt to connect to my database?

Describe the bug
~/project 4s
❯ npm run dev

<EMAIL_ADDRESS>dev
concurrently "vite" "tsx api/server.ts"

[1] Server running on port 3000
[0]
[0]   VITE v5.4.8  ready in 2887 ms
[0]
[0]   ➜  Local:   http://localhost:5173/
[0]   ➜  Network: use --host to expose
[1] ValidationError: An undefined 'request.ip' was detected. This might indicate a misconfiguration or the connection being destroyed prematurely. See https://express-rate-limit.github.io/ERR_ERL_UNDEFINED_IP_ADDRESS/ for more information.
[1]     at new ValidationError (file:///home/project/node_modules/express-rate-limit/dist/index.mjs:83:5)
[1]     at Object.ip (file:///home/project/node_modules/express-rate-limit/dist/index.mjs:115:13)
[1]     at wrappedValidations. (file:///home/project/node_modules/express-rate-limit/dist/index.mjs:351:22)
[1]     at Object.keyGenerator (file:///home/project/node_modules/express-rate-limit/dist/index.mjs:604:20)
[1]     at eval (file:///home/project/node_modules/express-rate-limit/dist/index.mjs:659:32)
[1]     at async eval (file:///home/project/node_modules/express-rate-limit/dist/index.mjs:639:5) {
[1]   code: 'ERR_ERL_UNDEFINED_IP_ADDRESS',
[1]   help: 'https://express-rate-limit.github.io/ERR_ERL_UNDEFINED_IP_ADDRESS/'
[1] }
Link to the Bolt URL that caused the error
https://bolt.new/~/node-jclhcd
Steps to reproduce
zd
Expected behavior
I want to allow Bolt to connect to my database. How can I configure the connection settings to ensure Bolt can interact with my database securely and efficiently?
Screen Recording / Screenshot
dzdzdz
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 48915430,
  "usedJSHeapSize": 44865954,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = p6vmmg7s
Chat ID = 3f11aa7e304e

Additional context
zddzdz

??


rooter_patterns child directories not working as expected

In g_rooters, I notice that
'>/Users/charlie/dev/'
Where I'd like to match the folder /Users/charlie/dev/project1,  /Users/charlie/dev/project2 etc.
Does not work properly.
Looks like an easy fix, and will provide a PR - assuming I'm understanding the configuration properly.
Is anyone else seeing this?

What do you mean by not working properly?  Please provide repro steps.

Configure vim as follows:
let g:rooter_patterns = ['>/Users/chucky/projects' ]
Setup a few projects.
 mkdir -p/Users/chucky/projects/project2
 echo "test" > /Users/chucky/projects/project1/test.txt
 echo "test" > /Users/chucky/projects/project2/test.txt

open vim and edit project1/test.txt. Type ":pwd". Plugin doesn't switch to /Users/chucky/projects/project1/, as expected.
NVIM v0.9.0
https://github.com/airblade/vim-rooter.git version 1353fa47ee3a81083c284e28ff4f7d92655d7c9e

@airblade let me know if my understanding is correct.  Also, it would be great to refresh NerdTree when switching projects, as I've missed the console a few times and been confused. (I can include that too).

Thank you for the example – it's much easier to debug something concrete.
And your understanding of the pattern '>/some/dir' is correct.

Plugin doesn't switch to /Users/chucky/projects/project1/
...
Does not correctly switch to project2.

It does for me.
I wonder what differs between your setup and mine?  You mentioned NerdTree; if you uninstall that, does your example start behaving as expected?

Even after uninstall of Nerdtree, the issue is there. Switching back to my branch does resolve it.


Sends Map of transcriptMessages as prop to Component

Some testing in progress. Do not merge yet.

@nikvaessen please review.


[Removal]:

Hotspot Name
Flaky Emerald Orca;Damp Denim Chipmunk;Noisy Teal Llama;Digital Rose Wolf;Orbiting Chambray Koala;Loud Cinnamon Griffin;Flaky Admiral Pig;Blurry Opaque Tiger;Dazzling Hemp Dalmatian;Dancing Licorice Iguana
Hotspot b58 Address
11235SQ1VVhjKJazXp9zDYUgLqRnyeJoCECNCXckUQ6PXXsPzfk3 1129mm8JxqekR6jUMnFSzHpXPFLRnRyk1eP8EL8zGfXqJRDeqmVo 112PxKRW3CxkDQ3E7wSe3B9xgGzjvXs6QEQoVynqtHxX79WxCBXa 11DCr7nfdvPWnu6kS2HevLgdZSCRjbnmqHQ6FXHa8FaXhmLy68p 11zVZwHpuMnKhYfkJz8ZGFhRDwxcygix6FGcUogdiVC8W3Lma6u 11ECaFyo8tzmsU8v4GFhiCUYFj521kvAgwqbKnwZ3MmS8n4dLvk 112rAdMPzUq4wZT381PgJ7K7cdM3NWz5Y7QfpNAGEqRWSWpZwko 112wdDnqAAKvGeKm4S5dHankQcnqKiMJgpkpxjuqmx2UxYg4imzx 11ArvPBZZKuCk7teJ4qSgaNRb6cSAiYpxV77knPDB7ASk3KGTZ7 112NuZbDzoyisdyYEH93p2xoa9qJ9LWBnejrp5uZTsKKtTFTpLmz
Discord Handle
No response
Hotspot Manufacturer
RF
Removal Reason
I deploy the layout through the actual address, why is it on the blacklist
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information

![6](https://user-images.githubusercontent.com/63040444/155264985-a2c999a7-68ab-4

036-aee7-a5f5b7ecc46b.jpg)
![7](https://user-images.githubusercontent.com/63040444/155264995-bfa

278bd-b446-45ed-8f27-703570cde03b.jpg)

We do not have sufficient evidence to remove these hotspots from the denylist. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


Question: can jodd HttpRequest  do XMLHttpRequest ?

The result header may contains:
X-Requested-With:XMLHttpRequest
and Request Payload is created(this is the point), for example:

{"orderBy":{"fieldName":"","orderMethod":""},"filterSet":{"orgId":"117000595","userId":"117004622","number":"","cssystem_no":"","fwtype":" and item.receiver in ('117000595')","type":""},"total":0}

I do not know to achieve this result, any suggestion would be appreciated.
Thank you !

This should be rather easy:
request.get("...").header("X-Requested-With","XMLHttpRequest").body("{"orderBy"...);
.sed();


getLocationData columns names crash

Hi, I am using this public API getLocationData from the R client.
https://github.com/AquaticInformatics/examples/blob/master/TimeSeries/PublicApis/R/timeseries_client.R#L305
The issue is that sometimes, the result's column names crash. I.e.
The correct column names are LocationName, Description, Identifier, ...
But for some locations, column names become V1, V2, V3, ....
It looks like when the location has many "Location Notes", the columns' names will malfunction. Please check.

@Quan-Cui
Hi, I am trying to repeat the issue without any success.  Can you please provide a code snippet without server creds?  (after you get the location data what do you do with it in code)
Round about how many location notes are in a Location before the error occurs?

@Quan-Cui
Hi, I am trying to repeat the issue without any success. Can you please provide a code snippet without server creds? (after you get the location data what do you do with it in code) Round about how many location notes are in a Location before the error occurs?

Thank you for checking this. We have 1000 locations, only 23 of them will return with crashed colnames. Is it possible to arrange a 10-min online meeting? I can show you the result. My email is<EMAIL_ADDRESS>

If you please could supply some sample code demonstrating this issue it would be greatly appreciated.

If you please could supply some sample code demonstrating this issue it would be greatly appreciated.

# > 1 import timeseries (R client), then log in
# > 2 define this fucntion
aqlocation <- function(LocationName) {
  if (exists("timeseries")) {
    myl <- timeseries$getLocationData(LocationName) %>%
      unlist() %>%
      as.data.frame() %>%
      t() %>%
      as.data.frame()
    return(myl)
  } else {
    warning("Please use aqengage() to connect to Aquarius.")
  }
}

# > 3
x <- aqlocation("LocationA")

We have almost 1000 locations, only 20 of them will return weird colnames as V1, V2...
Those 20 locations seem to have many location notes, referenecs points, etc. I can provide one example if you give me your email. Thank you.

Would it be possible to print(my1) to display its out and verify the output.
Also to add something like this to the client library and call to output the json in a print statement:
    getLocationDataJson = function(locationIdentifier) {
  locationData <- content(stop_for_status(
    GET(paste0(publishUri, "/GetLocationData"), query = list(LocationIdentifier = locationIdentifier))
  , paste("get location data for", locationIdentifier)), "text")
},

Then verify the json is okay

my_getLocationDataJson - timeserie.txt
my_getLocationData - timeseries.txt
Hi I've attached 2 printed result:

my_getLocationDataJson - timeserie  is from my_getLocationDataJson <- timeseries$getLocationDataJson("LocationName")
my_getLocationData - timeseries  is from my_getLocationData <- timeseries$getLocationData("LocationName")
You can get the messed colnames using

messyColname <- my_getLocationData %>%
    unlist() %>%
     as.data.frame() %>%
     t() %>%
     as.data.frame()

Thanks for checking on this. I will delete the 2 attachements when this issue is solved.

Would it be possible to print(my1) to display its out and verify the output for one of these problematic locations.
Also to add something like this to the client library and call to output the json in a print statement:
    getLocationDataJson = function(locationIdentifier) {
  locationData <- content(stop_for_status(
    GET(paste0(publishUri, "/GetLocationData"), query = list(LocationIdentifier = locationIdentifier))
  , paste("get location data for", locationIdentifier)), "text")
},

Then verify the json is okay

Hi please see my last reply. May I delete the text examples now?


Automated way to generate named jars

Hi there,
I wrote a tool called PixLyzer. It uses the yarn mappings for < 1.14.4 and mojang mappings for 1.14.4+. I like yarn mappings way more, than the original ones.
My problem is, that I need to integrate the named jar integration in my script. I have no time to manually generate yarn jars for newer versions and for all versions between 21w13a and 1.14.4. My last attempt for generating the older mappings was to checkout 1.14.4? and change the minecraft version here: https://github.com/FabricMC/yarn/blob/21w13a/build.gradle#L29. Older versions are gradle incompatible and/or don't have mapNamedJar
How to automatically generate mappings for older versions automatically? (By that I mean something like gradle mapNamedJar 1.15.2.
Thanks

Hi,
You can use tiny remapper to remap jars with given mappings.
You can find a download here: https://maven.fabricmc.net/net/fabricmc/tiny-remapper/0.3.2/ (use the fat jar if you want to use it via the cli)
You can find yarn in the tiny format here: https://maven.fabricmc.net/net/fabricmc/yarn/ (the none v2 jar or gz files will be best for older game versions)
Tiny reampper also has an API if you wish to call it directally in your code (just pull it in via maven). You can use the mapNamedJar as an example of this: https://github.com/FabricMC/yarn/blob/21w13a/build.gradle#L1050
Should just be a matter of getting your tool to download minecraft and the version of yarn you want to use and then invoke tiny remapper.

@modmuss50 Thanks for the (super quick) answer, I will definitely try it out. Sadly, I had not time the last days to answer.

Hi there,
got another question.
(Assume you use version 21w13a and want to map from official to named):
I can use tiny remapper to map from offical to intermediary. All fine with this one. Now I want to map from intermediary to named. When I checkout 21w13a and run gradle mapNamedJar I see in the temp folder a file called merge-v2.tiny. When I use this file and run the remapper everything is fine and I get the jar that I am used to. When I use the yarn mappings from maven (no matter what, the merged ones, the v2, ...) I can map most of the classes to the named names, but some (e.g. net/minecraft/class_6171) are just not getting renamed. I checked the mappings and when  grepping after this class I get the following outtput:
moritz@moritz-tp:~/yarn$ grep -r "net/minecraft/class_6171"
mappings/net/minecraft/unused/packageinfo/PackageInfo6171.mapping:CLASS net/minecraft/class_6171 net/minecraft/unused/packageinfo/PackageInfo6171
.gradle/temp/yarn-mappings-v2.tiny:c    net/minecraft/class_6171        net/minecraft/unused/packageinfo/PackageInfo6171
.gradle/temp/yarn-mappings.tiny:CLASS   net/minecraft/class_6171        net/minecraft/unused/packageinfo/PackageInfo6171
.gradle/temp/unmerged-named-v2-with-enum.tiny:c net/minecraft/class_6171        net/minecraft/unused/packageinfo/PackageInfo6171
.gradle/temp/merged-reordered-v2.tiny:c dlr     net/minecraft/class_6171        net/minecraft/unused/packageinfo/PackageInfo6171
.gradle/temp/merged-v2.tiny:c   net/minecraft/class_6171        dlr     net/minecraft/unused/packageinfo/PackageInfo6171
.gradle/minecraft/21w13a-intermediary-inverted-v2.tiny:c        net/minecraft/class_6171        dlr
.gradle/minecraft/21w13a-intermediary.tiny:CLASS        dlr     net/minecraft/class_6171
.gradle/minecraft/21w13a-intermediary-v2.tiny:c dlr     net/minecraft/class_6171

moritz@moritz-tp:~/test$ grep -r "net/minecraft/class_6171"
Übereinstimmungen in Binärdatei intermediary.jar
Übereinstimmungen in Binärdatei yarn.jar
intermediary.tiny:c     dlr     net/minecraft/class_6171

So no named mapping is available. Are the mappings in maven different or am I doing something wrong?
Ty

v2 does not contain the intermediary names, you need to download those seprately from maven and either combine the mappings or go from official -> intermediary -> named.

I can map from official to intermediary without a problem. I use v2 or v1 from maven (https://maven.fabricmc.net/net/fabricmc/yarn/) but nowhere is a named name from this class. That's the problem and not that it won't map at all (almost all ones are mapped)


Ambiguous wording

Hello,
In this section: https://learn.microsoft.com/en-us/azure/search/cognitive-search-tutorial-debug-sessions#create-data-source-skillset-index-and-indexer
Future should be used here:

("import" => "you will import", "you fix" => "you will fix")
It will make the instructions easier to understand.
Best regards,
François

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8203340c-a20f-7e2c-165f-3f99216262a1
Version Independent ID: 1c48d724-9e3a-7034-af36-9ba9a7f55397
Content: Tutorial: Debug skillsets - Azure Cognitive Search
Content Source: articles/search/cognitive-search-tutorial-debug-sessions.md
Service: cognitive-search
GitHub Login: @HeidiSteen
Microsoft Alias: heidist

@FRFR-LO
Thanks for your feedback! We will investigate and update as appropriate.

Hi @FRFR-LO , the doc has been updated by the doc author. Thanks again for the feedback!


feat: Create a backend to transform PubMed XML files to DoclingDocument

feat: Create a backend to transform PubMed XML files to DoclingDocument

Introduce XMLDocumentBackend to (1) parse PubMed XML files with the pubmed_parser library and to (2) convert this output to a DoclingDocument. Convert to DoclingDocument the authors, the abstract, the main-body text, the tables, the tables captions, the figures captions and the references. The hierarchy of the main-body text is preserved but limited to 2 levels (i.e. we know which paragraphs belong to which sections).
Add end-to-end tests for PubMed XML conversion (./tests/test_backend_xml.py).

Known limitations:

Compared to the original PDF documents, some sections are missing: page footers, page headers, figures, sections outside the main-body (for instance: Authors’ Contribution, Funding, Conflict of Interest, Acknowledgment, or Keywords).
pubmed_parser do not extract section headers if they are not followed by a paragraph (this is the case if several headings follow each other).
Column headers for tables with multi-column headers are duplicated.
pubmed_parser occasionally miss sections and paragraphs from the main-body.
pubmed_parser occasionally miss the abstract, the title and the authors.
Some PubMed XML tables (stored as HTML) are occasionally not properly converted to Docling tables and then ignored.

Issue resolved by this Pull Request:
Resolves #446 (Partially)
Checklist:

[x] Documentation has been updated, if necessary.
[x] Examples have been added, if necessary.
[x] Tests have been added, if necessary.

Invalid pull request. The feature will be implemented in #557.


chore: observe upgrade charm event in TLS certificates interface

Description
This PR aims to fix an issue, when migrating TLS certificates interface from V3 to V4, causing missing private key generation and blocking the charm.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that validate the behaviour of the software
[x] I validated that new and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have bumped the version of the library

Closing this PR as the modification will be in the TLS interface.


Add ability to call ecTrans with two "call modes" in benchmark

INV_TRANS and DIR_TRANS support two ways of passing arrays:

PSPVOR, PSPDIV, PSPSCALAR <=> PGP
PSPVOR, PSPDIV <=> PGPUV; PSPSC3A <=> PGP3A; PSPSC2 <=> PGP2

Previously we only supported the second one. With this commit you can now also call the first style. In the IFS we use both cases in different places so it's important to have both cases covered.
We can now extend the test suite so more of the code has coverage.
I am still trying to figure out how scalar fields are packed, hence this branch gives erroneous norms for scalar fields. I will continue working on this.

Finally ready for review, when you're ready @marsdeno @wdeconinck.

Hi @antoine-morvan - I'm afraid we just have to be patient with this. This PR is not considered important on our side, and the colleagues responsible for the review are not connected to the HPCW project. Hence we cannot ask them to prioritise this work. I think there is a way to make the first HPCW release even before this PR is merged -> I'll make a comment on the DKRZ Gitlab issue.


SQLi using scientific notation not detected at PL1

Description
New SQLi attack using scientific notation of numbers:
https://blog.h3xstream.com/2021/10/bypassing-modsecurity-waf.html
Author thinks libinjection should catch it, maybe better to catch it with regexp rules too.
We catch it just fine at PL2, but PL1 would be sweet.
curl localhost -d "foo=1.e(ascii 1.e(substring(1.e(select password from users limit 1 1.e,1 1.e) 1.e,1 1.e,1 1.e)1.e)1.e) = 70 or'1'='2"

Your Environment

CRS version (e.g., v3.2.0): CRS 3.4/dev
Paranoia level setting: PL1
ModSecurity version (e.g., 2.9.3): 2.9.4
Web Server and version (e.g., apache 2.4.41): Apache
Operating System and version: Ubuntu

Confirmation
[X] I have removed any personal data (email addresses, IP addresses,
passwords, domain names) from any logs posted.

Found this around: https://github.com/mindhack03d/WAF-Rule-Scientific-Notation

Waiting for @lifeforms to provide test set of FP's.

@lifeforms could you check this out please?

@emphazer volunteered to work on this, but he can't without the FPs promised by @lifeforms.

I totally forgot about this, sorry. Will have a look this week.

This is an interesting bypass. According to the blog, you can insert 1.e(...) or another number like 2.e(...).
Fortunately, MySQL does not accept a space between e and (:
mysql> select 10.e(1);
+---+
| 1 |
+---+
| 1 |
+---+
1 row in set (0.00 sec)

mysql> select 10.e (1);
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '10.e (1)' at line 1

The fact that e( should be next to each other, allows us to write a rule that hopefully will not cause many false positives.
If I'm right, we can catch this by looking for \d\.e( and I'm pretty positive about it.
In the comments I was asked for FP's, but I totally forgot what input I need to deliver. Does someone remember and can request me something specific?

@lifeforms here's where we were talking about it: https://owasp.slack.com/archives/CBKGH8A5P/p1640034126356900. You said something about having a dump from Reddit.

@lifeforms @theseion We need to fix this asap. With all the changes in the SQL detection we are doing, this still holds?
@karelorigin can you help taking a look? I know you were rewriting data files, so this might be in the top of your head by now...

@dune73 @lifeforms More than one year. Is this relevant, are we going to do something, or we close it?

OK. We're catching this at PL2 as is. Catching it at PL1 would have been cool, but there is no pressing need (as we catch it at PL2).
We're unsure of FPs and any systematic FP tests will only be available after CRS4. I am closing this now to get rid of the deadlock. And if this pops up again in the future we have the necessary discussion and the link to a PoC rule here.


Handshake failure

Problem:
I'm trying to run s2n-quic-qns perf server on a host and perf client on another to benchmark the throughput of s2n-quic. I generated some certificates on both server- and client-side. I'm running the server with --certificate and --private-key while the client with --ca but I'm getting the error:
Error: Transport { code: transport::error::Code(VarInt(296), "HANDSHAKE_FAILURE"), frame_type: 0, reason: "", initiator: Local, source: Location { file: "/home/maintain/quics/s2n-quic-fork/quic/s2n-quic-transport/src/connection/connection_impl.rs", line: 283, col: 33 } }

This happens even when the client and server are using the same certificate.
Thanks in advance!
Solution:

How did you generate your certificates? Do the SNI and SANs match?


Some API get 404 status

such as  webClient.PreGame.getPlayer
I have set the config according to the information on discord
  const webClient = new WebClient({
    client: {
      version: 'release-05.09-shipping-10-789344',
      platform: {
        platformType: 'PC',
        platformOS: 'Windows',
        platformOSVersion: '10.0.19042.1.256.64bit',
        platformChipset: 'Unknown',
      },
    },
    ...config,
  })

i think it is right
 {
  client: {
    version: 'release-05.09-shipping-10-789344',
    platform: {
      platformType: 'PC',
      platformOS: 'Windows',
      platformOSVersion: '10.0.19042.1.256.64bit',
      platformChipset: 'Unknown'
    }
  },
  axiosConfig: {
    headers: {
      'User-Agent': 'RiotClient/<IP_ADDRESS>70705.4749685 rso-auth (Windows;10;;Professional, x64)',
      'X-Riot-ClientVersion': 'release-06.00-shipping-7-812534',
      'X-Riot-ClientPlatform': 'eyJwbGF0Zm9ybVR5cGUiOiJQQyIsInBsYXRmb3JtT1MiOiJXaW5kb3dzIiwicGxhdGZvcm1PU1ZlcnNpb24iOiIxMC4wLjE5MDQyLjEuMjU2LjY0Yml0IiwicGxhdGZvcm1DaGlwc2V0IjoiVW5rbm93biJ9'
    }
  },
  throwOnError: true,
  region: 'ap'
}

maybe you didn't in "Pregame (select character phase)"


Adding Risk Scoring Module and KQL Support for Host Entities

Fixes #290
Fixes #291
Fixes #292
Fixes #301
Fixes #294
Fixes #293

This PR adds a new module to calculate risk scores.  It includes supporting inputs from Related Alerts, KQL, Watchlist and TI modules at this time.  The fundamental idea behind this is to simplify evaluating the relative risk of multiple module outputs.  While this is possible now with conditions, the conditions can get very complex if you are dealing with many modules.  By using a risk score, a score will be calculated for each module so that a condition can be as simple as if riskscore > x instead of looking at the results of each module individually.
Minor updates have been made to the supported modules (Related Alerts, KQL, Watchlist and TI) to pass the module name in the body so that the scoring module knows how to interpret the incoming data.  The TI module also has the additional of another output property, TotalTIMatchCount.  This is a simple sum of all the TI indicators that matched to make it easier to score.
This PR also includes an update to the KQL module to allow for passing of host entity data (table hostEntities) which is documented in the relevant readme in the riskscoring branch
We will need to validate deployment succeeds after merge into main
Deploy this PR from test Branch

@briandelmsft What do you mean by

We will need to validate deployment succeeds after merge into main

Is there more to test an install from scratch + a update on an already installed deployment?

This PR also now

Fixes #301
Fixes #294
Fixes #293

@piaudonn I'll stop pushing to this branch now 😆

I'll test and validate this week. I am back in business!

I'll merge and test again then...


Saw: More strange cards: bottom of "Booster Shot", "Vaccine", "Regenerative Tissue", "Research the Cure" and top of "Syringe"

https://github.com/orichalque/yet-an-other-gloomhaven-companion/blob/master/data/character-ability-cards/SB/booster-shot.png
https://github.com/orichalque/yet-an-other-gloomhaven-companion/blob/master/data/character-ability-cards/SB/vaccine.png
https://github.com/orichalque/yet-an-other-gloomhaven-companion/blob/master/data/character-ability-cards/SB/regenerative-tissue.png
https://github.com/orichalque/yet-an-other-gloomhaven-companion/blob/master/data/character-ability-cards/SB/research-the-cure.png
https://github.com/orichalque/yet-an-other-gloomhaven-companion/blob/master/data/character-ability-cards/SB/syringe.png
GAAH Sawbones! These cards all have:
"Place this card in one adjacent ally's active area and treat it as if they own the card."
barring Syringe, which is
"Place this card in one adjacent ally's active area, then put it into your discard pile at the end of the round."
So another few for Accept Card? Except with the exception of Syringe, they are ongoing effect cards once played by the Sawbones, and they play to the Active (aka "On Board") area, not into the hand = instantly take effect unless I misunderstand that one.

Damn sawbones and its annoying cards T-T

That's a tough one.

Too much nonsense unless you can find an elegant way to handle it.
We gotta fix that then !

Seriously, love your work! Wish I was skilled enough to contribute more directly.
Thanks a lot :) We're doing pretty basic stuff to be fair, no back-end, no complex framework, anybody could do the same ;)


Changing id in role table by role_id

Hello, when i change the field id in table roles by role_id i get this error :
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'permission_role_table.role_role_id' in 'field list'. Can you help me to resolve this issue?

Any idea to resolve this problem please?

Hello, Is this library still supported ?

Hi, @leonfather
can you provide a full code example to reproduce the issue?

The roles table has just the roles (one by one as name), the permission_role table is a pivot table to associate many permissions to one role.

@leonfathe Just override the default variable $primaryKey in model Role.php
protected $primaryKey = 'role_id';


GitHub Actions CI/CD

Proposed alternative to using CircleCI.
Please also consider the Design Doc available here: https://wiki.hyperledger.org/pages/viewpage.action?pageId=80774216
Fixes #6238

the unit test summary is pretty nice!

the unit test summaries that are broken out eg https://github.com/hyperledger/besu/actions/runs/7617733119?pr=6427#summary-20747591970 testRemainder section has 0 tests - is this still WIP?

the unit test summaries that are broken out eg https://github.com/hyperledger/besu/actions/runs/7617733119?pr=6427#summary-20747591970 testRemainder section has 0 tests - is this still WIP?

Yep thats a bug. Should be fixed now: https://github.com/hyperledger/besu/actions/runs/7631742082?pr=6427


runtime: silence -Wunused-variable warning (NFC)

classMetadata is only used in the ObjC path, resulting in a
-Wunused-variable warning.  Sink the variable into the ObjC path.
Because the conversion of the metadata does not rely on the type
metadata bits in the metadata, it is safe to delay the definition and
bit adjustment to the point where it is used unifying the two ObjC
paths.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test


How to get the op list in tflite

I want to use mediapipe tflite model in other project. So i want to know the op list in tflite, how to parse the tfilte model ?

I get a solution, using flatc and schema.fbs.

How to parse hand_landmark_lite.tflite?


Add embed endpoint

Add embed endpoint that will create embedding for bed file that is provided by user

Fixed


Fix test_set_background (in test_gui.vim) to not assume light background

Technically, gVim doesn't assume a default white background as it's platform-specific and depends on user settings. The current implementation of test_set_background assumes the default is "light" and that could break under certain implementations or user settings. Fix it to set background to "light" explicitly instead.
The relevant parts of the docs (:h 'background'):

'background' 'bg'	string	(default "dark" or "light", see below)

When starting the GUI, the default value for 'background' will be "light".  When the value is not set in the .gvimrc, and Vim detects that the background is actually quite dark, 'background' is set to "dark".  But this happens only AFTER the .gvimrc file has been read (because the window needs to be opened to find the actual background color).  To get around this, force the GUI window to be opened by putting a ":gui" command in the .gvimrc file, before where the value of 'background' is used (e.g., before ":syntax on").

Hmm, I'm not sure why it's breaking Travis tests. Not sure if it's related to my PR or not. May need to look into it. Also after further investigations I think if gVim's default colors are different from the standard one for whatever reason, it may fail other tests that do a term diff. Need to think more about that.

Yee Cheng Chin wrote:

Technically, gVim doesn't assume a default white background as it's
platform-specific and depends on user settings. The current
implementation of test_set_background assumes the default is "light"
and that could break under certain implementations or user settings.
Fix it to set background to "light" explicitly instead.
The relevant parts of the docs (:h 'background'):

'background' 'bg'	string	(default "dark" or "light", see below)

When starting the GUI, the default value for 'background' will be
"light".  When the value is not set in the .gvimrc, and Vim detects
that the background is actually quite dark, 'background' is set to
"dark".  But this happens only AFTER the .gvimrc file has been read
(because the window needs to be opened to find the actual background
color).  To get around this, force the GUI window to be opened by
putting a ":gui" command in the .gvimrc file, before where the value
of 'background' is used (e.g., before ":syntax on").

Right, so in the GUI the default for 'background' is light, and that's
what the test is testing.  How would the background default be dark?
What system is this on?
--
Arthur pulls Pin out.  The MONK blesses the grenade as ...
ARTHUR:  (quietly) One, two, five ...
GALAHAD: Three, sir!
ARTHUR:  Three.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I think the key part I wanted to quote was this:

When the value is not set in the .gvimrc, and Vim detects that the background is actually quite dark, 'background' is set to "dark".  But this happens only AFTER the .gvimrc file has been read

I can see this happen in Windows 10 for example if I turn on high contrast mode (Settings -> Ease of Access -> High Contrast), where programs now have their colors inverted.
Now that I look more into it though, other unit tests would also be affected by this difference in default color schemes. There are some tests that use term_dumpdiff against known "good" dumps, but those good dumps were all made assuming a default white Vim background. I guess we could go fix those too (maybe by setting an explicit white color scheme before term dumping),  or just say "you have to use a standard OS colorscheme in order to run Vim unit tests" which seems non-ideal but reasonable.
Just for context I am trying to fix unit tests for MacVim and Mojave dark mode would make test_set_background() fail, but as I said this is the case for gVim under other platforms as well.

Then I think Vim should have one additional test for the "high contrast mode" of Windows and MacVim another for the "dark mode" of macOS Mojave, while keeping the current test for "normal" or "default" mode intact, because that separation would help us determine whether or not a possible failure of the test results from the mode under which the test runs and thus make it easier to fix it.  Anyway, it would be definitely better to make sure first if Vim runs without failure for normal mode before checking if it runs successfully as well under certain special modes in order to make it easier to nail down the cause of a possible trouble.
As MacVim is an independent project, you might want to open an issue similar to this one there.

@nuko8 I'm actually the current maintainer of MacVim and thought it makes sense to submit this fix upstream to Vim since it's not guaranteed the GUI background is white, even though that's the common case. As I said though there's probably more to be regarding the misc tests that uses term_dumpdiff so I'm fine with closing this.

Yee Cheng Chin wrote:

@nuko8 I'm actually the current maintainer of MacVim and thought it
makes sense to submit this fix upstream to Vim since it's not
guaranteed the GUI background is white, even though that's the common
case. As I said though there's probably more to be regarding the misc
tests that uses term_dumpdiff so I'm fine with closing this.

The problem with dropping the test, or forcing "light" background, is
that it doesn't check for the automatic background detection.  There is
no point in checking that 'background' is "light" if it was set to that
value.
Isn't there a way to make sure that Vim is started in a way it should be
using a light background?  In general, tests should not pick up user
preferences.
--
Biting someone with your natural teeth is "simple assault," while biting
someone with your false teeth is "aggravated assault."
[real standing law in Louisana, United States of America]
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

In general, tests should not pick up user preferences.

Yeah that's a fair point. I looked through the code more and in GTK the colors are always set to white background. It's only on Windows that the backgrounds are queried dynamically (I didn't check the other less popular platforms). On Windows though the only way I could trigger a non-light background was high contrast mode which is a pretty rare case anyway. There's a dark mode in Windows 10 but it only affects UWP apps, not Win32 apps like gVim.
I'll close the PR. This seems to affect mostly MacVim (where dark mode is relatively popular among developers) so I'll look into ways to address that on that side and see if I can force a white background when running tests.


new feature can be added

VS Code can have the feature of  visual design surface known as Live View.
It will be a nice feature

Can you elaborate on what feature are you requesting?

I mean to say VS Code can have the the feature of live page which means while building the web page one can see what is happening in web page side by side. The person doesn't need to save the code and refresh the page on browser.

This seems like a good fit for an extension, while the majority of people use VS Code for web development, its core shouldn't capture all the possible features other web IDEs have so people who don't use it for web development (or have different workflow which wouldn't benefit from Live View in VS Code) don't have to be exposed to a bigger core (which is more likely to have bugs, especially in interactions between rarely used features).

So https://marketplace.visualstudio.com/items?itemName=negokaz.live-server-preview basically or https://marketplace.visualstudio.com/items?itemName=hdg.live-html-previewer?


Asynchronous hooks

Is it possible to allow asynchronous hooks to delay the execution of the underlying operation? This could be achieved like so:
var done = this.async();
setTimeout(function() {
  done();
}, 2000);

+1

+1

+1


Runtime calling filament::Texture::setImage every frame possible?

Describe the bug
I have some runtime generated images on mobile end and try to update that to the filament texture. These images are not from video. And when I try to call it frequently on main thread the app crashes.
My question is that the texture is used for rendering and at the same time being updated here. Would it crash because race condition or similar things? Is there recommendation on updating Textures at this high frequency?
To Reproduce
Steps to reproduce the behavior:

Just try to get the image data and set it to the texture we created  with filament every frame.
Then the whole system slow down and it becomes unuseable.

Expected behavior
Suppose the app should run smoothly and we can see the texture update.
Screenshots
If applicable, add screenshots to help explain your problem.
Logs
If applicable, copy logs from your console here. Please do not
use screenshots of logs, copy them as text.
v ***** FATAL SIGNAL RECEIVED *******
Received fatal signal: SIGSEGV(11)	PID: 20263
***** SIGNAL SIGSEGV(11)

*******	STACKDUMP *******
  # 0: 0x6d3bff4ab4
  # 1: 0x6d3bfeca68
  # 2: 0x6d3bfec8dc
  # 3: 0x6d3bff54fc
  # 4: 0x5837eeed04
  # 5: 0x786fec463c  __kernel_rt_sigreturn
  # 6: 0x77d21ced90
  # 7: 0x77d21a9c60
  # 8: 0x77d21b0ca8
  # 9: 0x786c444f14
  #10: 0x786c3e30cc

Exiting after fatal event  (FATAL_SIGNAL). Fatal type:  SIGSEGV
Log content flushed sucessfully to sink

Desktop (please complete the following information):

OS: Android
GPU:
Backend: OpenGL

Smartphone (please complete the following information):

Device: Samsung S10E
OS: [e.g. Android Pie 9.0]

Additional context
The API I am using:     void setImage(Engine& engine, size_t level, PixelBufferDescriptor&& buffer) const;

Could you please show more of the logs? Updating a texture every frame shouldn't be an issue. Do you properly free memory after an upload is complete? The fact that the entire system slows down would indicate you may be exhausting system memory.

There is no race condition between using setImage and the texture being used for rendering. It is guaranteed that the effect of setImage will happen after the next call to Renderer::render().
There shouldn't be any issue updating a texture every frame, but note that it's not ideal for performance.
If possible try to run a DEBUG version of filament so we get a better stacktrace. Also as @romainguy said, this looks like memory is not being freed.

Update: seems like the crash is gone if I setImage with the same size.
for example, if I createTexture to be 2k x 2k RGB image, and then try to setImage  with a RGB image, it crashes.

Please show the full logs and check that you are freeing the memory.

The crash log is indeed that short.
I am able to resolve this problem by providing setImage with the same size image that the GLTF loaded.
Technically, filament allows to link the uber shader variables to other texture we load in other source, rather than from the gltf file. In this case, we faces this case:

load the gltf model, whose texture dimension is B.
create filament texture (with dimension A)
Binding the uber shader key with the one from step 2.
Try to update the textures from step 2 with another one (dimension C)

So here I have to make sure that A == B && B == C. Or system would crash. And the image format also need to be same.

If you call setImage on an existing texture, yes you’ll have to match format and dimensions. You can however create your own texture object with a new format and new dimensions and use that as the parameter for the material. In that case you don’t need to match anything.

sounds like a user error. Please move this to a discussion if needed.


Remove the rule that the fee of an operation is burned

I propose to remove the rule that says that the fee of an operation is burned. In the minting account section of ICRC-1 it is written that

The minting account is also the receiver of the fees burnt in regular transfers.

which implies that fees must be burned by the Ledger. I propose to remove this constraint entirely. What the Ledger decides to do with the fee is up to the Ledger implementation. Our ICP Ledger, for instance, will burn the fee because there is no need to keep the fee around. Other Ledgers may transfer the fee to a "fee collector" account which will then be able to use the fees collected for various things such as buying cycles for the Ledger.

It is true that such conventions should not be written in the standard, and even if they are, they are meaningless.
This is because the goal of the standard is to achieve interoperability, and the internal details in implementing the examples (without affecting interoperability) should not be in the standard.


[Android] Rotating screens makes app restart to initial scrren

Hi!
I have a modal that shows a swiper with images, and It has landscape support. But on Android, everytime I rotate the screen the app resets to main screen. Although on iOS it works perfectly fine.
Anyone experienced this?

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.
I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!


dashboard/app: separate flaw non-root accessibility

Filing this in response to this Twitter thread: https://twitter.com/dvyukov/status/1354339035322449922
Today, AFAIK the main syskaller instances all run as "real root" i.e. CAP_SYS_ADMIN without user namespaces.  This finds a lot of bugs in the kernel which should ideally be fixed; but most of them aren't critical security flaws because we're already running as root.
In contrast for example in OpenShift we run user containers by default under a restricted security context constraint which runs them as non-root.  Hopefully soon Kubernetes upstream will gain user namespaces too.
Many other systems do this too; there are many systems out there which are still much like the "traditional Unix timesharing" model of having users ssh into machines as non-root and expecting that to be "secure".
Here "secure" doesn't mean "perfectly without flaws" - it means we believe we can fix bugs that arise and don't expect bugfixes to need fundamental redesigns.
I think it'd be useful if syskaller first when it found a flaw, tried reproducing it as non-root too.
And it'd also be good I think to e.g. steer a larger percentage of the computational resources towards "unprivileged accessible" code paths, and have a separate list for anything that arises here.  For all of us Linux OS vendors we basically need to keep that list empty.
A great example is the recent change to allow unprivileged overlayfs mounts.  Per your twitter thread - indeed, mounting traditional filesystems requires privileges - you can't do it in Kubernetes/podman/docker.    That recent change moves overlayfs into the accessible list, so ideally more syzkaller computation is targeted at it.

Hi Colin,
Is there any plan to do anything concrete with such non-root bugs if syzbot provides this info?
So far I get an impression that for upstream developers it's mostly uninteresting, for some subsystems all bugs are fixed regardless of root/non-root, for some -- non are fixed, some are somewhere in between.
If there is no concrete plan, it may just make script kiddies work easier :)

Hi Colin,
Is there any plan to do anything concrete with such non-root bugs if syzbot provides this info?
So far I get an impression that for upstream developers it's mostly uninteresting, for some subsystems all bugs are fixed regardless of root/non-root, for some -- non are fixed, some are somewhere in between.
If there is no concrete plan, it may just make script kiddies work easier :)

There is another interesting aspect in the context of fuzzing: some critical non-root bugs require some actions from root as well. Consider, root just creates a particular privileged socket type, or normal socket type with privileged setsockopt, or loads a bpf program, and then a remote side a particular network packet and exploits the machine. This won't be found by the non-root targeted instances and won't be classified as non-root.

There is another interesting aspect in the context of fuzzing: some critical non-root bugs require some actions from root as well. Consider, root just creates a particular privileged socket type, or normal socket type with privileged setsockopt, or loads a bpf program, and then a remote side a particular network packet and exploits the machine. This won't be found by the non-root targeted instances and won't be classified as non-root.

This will probably require #608 as a prerequisite as a way to mark bugs and correct the marking.

This will probably require #608 as a prerequisite as a way to mark bugs and correct the marking.

Is there any plan to do anything concrete with such non-root bugs if syzbot provides this info?

It depends on the result of the bug, but if e.g. it looks like memory corruption then it should be treated as a CVE I'd say.
And that really is the heart of this discussion; on the Twitter thread you implied that because there were a lot of root accessible flaws that that meant Linux namespaces are worthless - but I strongly disagree with that and I think a lot of others would too.

So far I get an impression that for upstream developers it's mostly uninteresting, for some subsystems all bugs are fixed regardless of root/non-root, for some -- non are fixed, some are somewhere in between.

If it's non-root accessible then I would say it should follow the Linux kernel security report flow.

If there is no concrete plan, it may just make script kiddies work easier :)

Well yes, they are almost certainly running private instances of fuzzers like syzkaller, watching commits that affect the attack surface and likely front-running with custom rules.  And you and I are here on the opposite side to protect people's computers, trying to stay ahead of the attackers.  Part of that is prioritizing the same thing they prioritize.  The vast, vast majority of syzkaller bugs are irrelevant to them because they already assume root.  And hence they should be treated as a "pool of background things to fix", not an indictment of Linux in general.
To rephrase and simplify: You guys have a choice where to spend your time and the CPU hours of the Google syzkaller instance, as well as the time of the kernel maintainers.  I think (again to pick a random number) at least 50% of that time should focus on non-root paths.

Is there any plan to do anything concrete with such non-root bugs if syzbot provides this info?

It depends on the result of the bug, but if e.g. it looks like memory corruption then it should be treated as a CVE I'd say.
And that really is the heart of this discussion; on the Twitter thread you implied that because there were a lot of root accessible flaws that that meant Linux namespaces are worthless - but I strongly disagree with that and I think a lot of others would too.

So far I get an impression that for upstream developers it's mostly uninteresting, for some subsystems all bugs are fixed regardless of root/non-root, for some -- non are fixed, some are somewhere in between.

If it's non-root accessible then I would say it should follow the Linux kernel security report flow.

If there is no concrete plan, it may just make script kiddies work easier :)

Well yes, they are almost certainly running private instances of fuzzers like syzkaller, watching commits that affect the attack surface and likely front-running with custom rules.  And you and I are here on the opposite side to protect people's computers, trying to stay ahead of the attackers.  Part of that is prioritizing the same thing they prioritize.  The vast, vast majority of syzkaller bugs are irrelevant to them because they already assume root.  And hence they should be treated as a "pool of background things to fix", not an indictment of Linux in general.
To rephrase and simplify: You guys have a choice where to spend your time and the CPU hours of the Google syzkaller instance, as well as the time of the kernel maintainers.  I think (again to pick a random number) at least 50% of that time should focus on non-root paths.

Is there any plan to do anything concrete with such non-root bugs if syzbot provides this info?
It depends on the result of the bug, but if e.g. it looks like memory corruption then it should be treated as a CVE I'd say.

I meant: who will do what with these results? Who will triage them and file CVEs?

Is there any plan to do anything concrete with such non-root bugs if syzbot provides this info?
It depends on the result of the bug, but if e.g. it looks like memory corruption then it should be treated as a CVE I'd say.

I meant: who will do what with these results? Who will triage them and file CVEs?

There is another interesting aspect in the context of fuzzing: some critical non-root bugs require some actions from root as well.

That's an interesting case and I think it boils down to: Are there parts of shipping Linux userspace that follow that pattern?  For example, systemd does set up bpf programs attached to sockets, so indeed fuzzing that path makes sense; maybe someone comes by and adds some socket API that somehow allows corrupting that bpf state or something.
But otherwise - like obscure scenarios where a root app calls perf_event_open() and passes that down to an unprivileged process...if no one is doing that in practice, then it's treated as a bug, not a CVE.

There is another interesting aspect in the context of fuzzing: some critical non-root bugs require some actions from root as well.

That's an interesting case and I think it boils down to: Are there parts of shipping Linux userspace that follow that pattern?  For example, systemd does set up bpf programs attached to sockets, so indeed fuzzing that path makes sense; maybe someone comes by and adds some socket API that somehow allows corrupting that bpf state or something.
But otherwise - like obscure scenarios where a root app calls perf_event_open() and passes that down to an unprivileged process...if no one is doing that in practice, then it's treated as a bug, not a CVE.

I meant: who will do what with these results? Who will triage them and file CVEs?

I'm not a kernel maintainer, and at this point we should probably get one in this discussion :smile:  But I suggested the existing kernel security contact list above - or you could try direct email to the maintainer(s).
I know you've gotten some pushback about the unending flow of syzkaller reports, and I hope taking this more targeted approach could help with that.

I meant: who will do what with these results? Who will triage them and file CVEs?

I'm not a kernel maintainer, and at this point we should probably get one in this discussion :smile:  But I suggested the existing kernel security contact list above - or you could try direct email to the maintainer(s).
I know you've gotten some pushback about the unending flow of syzkaller reports, and I hope taking this more targeted approach could help with that.

That's an interesting case and I think it boils down to: Are there parts of shipping Linux userspace that follow that pattern?

privileged setsockopt's, all network setup, mounting an fs and then provoking a bug by just creating a file in that fs
there seems to be lots of such cases

That's an interesting case and I think it boils down to: Are there parts of shipping Linux userspace that follow that pattern?

privileged setsockopt's, all network setup, mounting an fs and then provoking a bug by just creating a file in that fs
there seems to be lots of such cases


Effects of transitioning mel_base from '10' to 'e'

Hi All,
I'm attempting to inference a model I've trained and after weeks of debugging I've finally determined that my issues seem to be related to the mel_base setting. I understand that this repo recently transitioned from base 10 mel spectrograms to base e. These are the following things I've been thinking about, would love to hear everyone else's opinion on them:

Originally, my acoustic model utilized base 'e', while I'm assuming NSFHifiGan utilized base 10. Are there plans to release a base 'e' version of this vocoder?

As we move to base 'e', is there a problem with using old base 10 models for pretraining?

I tried manually "connecting" my base 'e' acoustic model with the base 10 vocoder by multiplying all the acoustic model output values by 0.434294 (the conversion rate between base e and base 10) but for some reason this didn't fully work? The vocals still sounded low quality and I'm not sure why. When I load my base 'e' acoustic model up in OpenUtau everything sounds fine, even though OU is using the same base 10 NSFHifiGan vocoder. Does anyone have any idea what they could possibly be doing to work with both base 'e' and base 10 models, besides simply multiplying by the 0.434294 conversion rate? (which doesn't seem to do the trick)

Any help is greatly appreciated!
Thanks

Actually all vocoder models are under base e. The problem is that early acoustic models are all base 10. But this repo have conversion between the two bases so there is no problem.
Old base 10 models should not be used for pretraining under base e.
OpenUtau itself has a conversion process. It reads the configs and determine whether to multiply the scale factor. The compatibility between different bases has already been considered. If you write the configs honestly, everything should be okay.

Ah thank you that's very helpful. I saw the portion of OpenUtau code that converts between base 10 and base e, unfortunately though when I try to replicate this by inferencing my model in Javascript (using onnxruntime)  and multiplying by the sale factor I can't get the same results. I'll close this issue for now, and if I every figure out what my problem was I'll come back here and leave a comment. Thanks again!


How to modify the height into MonthlyDay

Hello @zackify
how could i change the height into MonthlyDay?
Check it out

i tried adding the property "className" into MonthlyBody, but it just receive "children" and "omitDays" as props.
What do you think?
Is it possible?

MonthlyDay is a very simple component, this library is meant to provide simple defaults, and instead of endless prop options, you can make your own component for any part of it if you wish to change it. Here's the MonthlyDay code:
type MonthlyDayProps<DayData> = {
  renderDay: (events: DayData[]) => ReactNode;
};
export function MonthlyDay<DayData>({ renderDay }: MonthlyDayProps<DayData>) {
  let { locale } = useMonthlyCalendar();
  let { day, events } = useMonthlyBody<DayData>();
  let dayNumber = format(day, 'd', { locale });

  return (
    <div
      aria-label={`Events for day ${dayNumber}`}
      className="rc-h-48 rc-p-2 rc-border-b-2 rc-border-r-2"
    >

{dayNumber}

          {format(day, 'EEEE', { locale })}

        {renderDay(events)}

  );
}

You can paste this into your own app, MyMonthlyDay or whatever makes sense, and use it instead of the built in one. This will let you customize everything to how you want it.
This library was made with this in mind, the useMonthlyCalendar and useMonthlyBody hooks are exported for you to use.


The stakeholder cooperation is not in my LES but still in the businessmodel?

I'm using this LES where I have no stakeholder named cooperation. However I still have this stakeholder in my business case and it has a outgoing cashflow which I don't understand. I cannot see the stakeholder in the marketmodel, topology, gas asset lists or the technology table. Can someone have a look at it or explain this to me please?

Looking at the gas asset list in the database, the cooperation is the owner of all gas assets. In the front-end this is not shown however.
It seems that only stakeholders that are present in the topology file can be selected to own a part of the gas assets. This is wrong.
Moreover, the cooperation used to be the default stakeholder for gas assets so perhaps something has gone wrong when we changed that.
Hope this helps @grdw and @antw to fix the problem.

I've changed the stakeholder for the gas assets to be "system operator" (since I believe that is correct for the live/production application). The cooperation has no longer appears in the business case.

It seems that only stakeholders that are present in the topology file can be selected to own a part of the gas assets. This is wrong.

This has been fixed on beta. All stakeholders are available to be chosen for gas and heat assets.

@ThomBuijs We plan on publishing a new version to the "live" site some time next week, after which this should no longer be a problem.

I made a new LES and the cooperation stakeholder is back again. This time its value is zero, but I would rather leave him out of the picture at all. Any ideas on how to solve this?

I forgot to change the stakeholder to system operator.. So I am closing this, since it is fixed now.


fix(hasura env): Added missing environment variables

Description of PR

What component(s) does this PR affect?

[x] Back-End (Database, Detection/Configuration/etc. Microservices)
[ ] Front-End (Flask, API, UI, etc)
[ ] Monitor (RIPE RIS, BGPStream RV/RIS/CAIDA, etc.)
[ ] Docs (incl. wiki)
[ ] Build System

Does the PR require changes on other components? If yes, please mark the components:

[ ] Back-End (Database, Detection/Configuration/etc. Microservices)
[ ] Front-End (Flask, API, UI, etc)
[ ] Monitor (RIPE RIS, BGPStream RV/RIS/CAIDA, etc.)
[ ] Docs (incl. wiki)
[ ] Build System

Related Issue

Resolves #407
Resolves #416
Solution

Type

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs update
[ ] None of the above

Checklist:

[x] I have read the contributing guide and my code conforms to the guidelines.
[ ] This change requires a change in the documentation.
[ ] I have updated the documentation accordingly.

closing this PR in favour of #418


remove deprecated testrai related artifacts in SpecialKeywords

@Deprecated
public static final String TESTRAIL_SUITE_ID_OLD = "TestRailSuiteId";
@Deprecated
public static final String TESTRAIL_PROJECT_ID_OLD = "TestRailProjectId";
public static final String TESTRAIL_SUITE_ID = "com.zebrunner.app/tcm.testrail.suite-id";
@Deprecated
public static final String TESTRAIL_PROJECT_ID = "com.zebrunner.app/tcm.testrail.project-id";
@Deprecated
public static final String TESTRAIL_TESTCASE_UUID = "com.zebrunner.app/tcm.testrail.testcase-id";

testing should include running api and web job on 7.3.15-SNAPSHOT carina on Pro and CE versions. everything should be executed and tracked.

Verified on develop branch on CE, fixed.


Pause Skrollr

Hi,
is it possible to "pause" scrollr? I would like to block/unblock vertical scrolling when clicking on a button. Second possibility would be to just pause the eventlistener which is checking for vertical scrolling. But somehow I dont seem to get the syntax right.
Thanks a lot!
Vinnn

Since skrollr uses the native scrollbar you can achieve this from outside of skrollr.
Add overflow:hidden for desktop and stopPropagation for touchstart, touchmove, toucheend and touchcancel for mobile. The event listener needs to be below the document (e.g. body) so that skrollr never gets those.


cpp protobuf instructions out-of-date for MacOS

Instructions to upgrade to cpp protobuf implementation on Mac from https://www.tensorflow.org/install/install_mac#protobuf_pip_package_31 don't work work, makes TF fails with following stacktrace
Traceback (most recent call last):
  File "kronecker_benchmark.py", line 3, in <module>
    import tensorflow as tf
  File "/Users/yaroslav/anaconda/envs/mar1/lib/python3.5/site-packages/tensorflow/__init__.py", line 24, in <module>
    from tensorflow.python import *
  File "/Users/yaroslav/anaconda/envs/mar1/lib/python3.5/site-packages/tensorflow/python/__init__.py", line 54, in <module>
    from tensorflow.core.framework.graph_pb2 import *
  File "/Users/yaroslav/anaconda/envs/mar1/lib/python3.5/site-packages/tensorflow/core/framework/graph_pb2.py", line 6, in <module>
    from google.protobuf import descriptor as _descriptor
  File "/Users/yaroslav/anaconda/envs/mar1/lib/python3.5/site-packages/google/protobuf/descriptor.py", line 46, in <module>
    from google.protobuf.pyext import _message
ImportError: dlopen(/Users/yaroslav/anaconda/envs/mar1/lib/python3.5/site-packages/google/protobuf/pyext/_message.cpython-35m-darwin.so, 2): Library not loaded: /usr/local/lib/libprotobuf.10.dylib
  Referenced from: /Users/yaroslav/anaconda/envs/mar1/lib/python3.5/site-packages/google/protobuf/pyext/_message.cpython-35m-darwin.so
  Reason: image not found

Work-around is to use older link:
pip install --upgrade https://storage.googleapis.com/tensorflow/mac/cpu/protobuf-3.1.0-cp35-none-macosx_10_11_x86_64.whl
Check that it works
python -c "from google.protobuf.internal import api_implementation; print(api_implementation._default_implementation_type)"
MacOS: 10.12.4 (16E195), TensorFlow, latest nightly from today installed as:
pip install --upgrade https://ci.tensorflow.org/view/Nightly/job/nightly-matrix-cpu/TF_BUILD_IS_OPT=OPT,TF_BUILD_IS_PIP=PIP,TF_BUILD_PYTHON_VERSION=PYTHON3,label=mac-slave/lastSuccessfulBuild/artifact/pip_test/whl/tensorflow-1.1.0rc1-py3-none-any.whl

@jhseu : Any suggestions for the appropriate update here?

Sent a fix for the links in the docs (internally, should be reflected soon).
Also filing a request with the protobuf team to upload optimized mac builds to pypi.


The output of The Fuck with THEFUCK_DEBUG=true exported (typically execute export THEFUCK_DEBUG=true in your shell before The Fuck):
See above
If the bug only appears with a specific application, the output of that application and its version:
iTerm2 Build 3.3.6
Anything else you think is relevant:
image with output example

Closing for the lack of reproducibility info.


reorder-imports should have option to preserve import groups

Currently (version 0.6.2) rustfmt will change this:
use a;
use x;
use b;

use std::io;

to
use a;
use b;

use std::io;
use x;

By group i mean consecutive lines of imports. Groups are divided by empty newlines. I write my imports such that imports from the crate i'm working on are in one group and imports from other crates/std get put in different group. Rustfmt mixes them, which defeats the purpose of grouping. On the other hand i would like to have both groups sorted within themselves. Is there a way to achieve that with current version of rustfmt and if not could this be considered?
For the example above i'd like rustfmt to change it like so:
use a;
use b;
use x;

use std::io;

I'd like this as well. I typically sort my imports in three groups like this:
use std::cmp;
use std::fmt;

use byteorder;
use socketcan;

use same_crate_a;
use same_crate_b;

At least the formatters I used for Python and Java do similar things

Seconded. I also picked up that habit in the Python world and I currently keep my imports sorted manually because I value the groups more than the convenience of rustfmt.

Issue #1302 is somewhat related to this one.


[WFLY-13085] Add documentation on the TLS 1.3 support for the OpenSSL TLS provider

https://issues.redhat.com/browse/WFLY-13085
Requires https://github.com/wildfly/wildfly-core/pull/4271 to be merged.

@fjuma Do we really need a core update with the tests in core before this can be merged?

@darranl This can be merged before the tests are merged.


Collect Swift generated header in BwB mode

Fixes lldb issues.

Merging to get it into the release I'm about to cut, as a way for people to more easily test it. I can revert in a patch release if needed.


expected LP_MJMODEL instance instead of MjModel

Hi,
I had an error while using functions from mjlib
Here's an example:
>>> from dm_control.mujoco.wrapper.mjbindings import mjlib
>>> H=np.zeros(sim.model.nv * sim.model.nv)
>>> mjlib.mj_fullM(sim.model, H, sim.data.qM)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ctypes.ArgumentError: argument 1: <class 'TypeError'>: expected LP_MJMODEL instance instead of MjModel

Could anyone tell me which object should I input for the first argument? Thanks a lot!

You want model.ptr rather than model. model.ptr, data.ptr etc. expose ctypes pointers to the underlying C structs, which you can pass to the wrapped libmujoco functions in mjlib - for example see here.


Eliminate dependency on numpy

numpy is large and we only use it a small number of places, which could fairly simply be replaced

relevant StackOverflow answer https://stackoverflow.com/a/43311126/9363594


Chart components additional args to containers

Is your feature request related to a problem ?
I think it will be nice to see in this chart a possibility to add additional args to containers. Sometimes Flux developers add new flags to services but describe everything can be not so good, so maybe it will be a good option for such cases.
I can create a pull request for it.
Describe the solution you'd like.
Something like this
      containers:
      - args:
        - --events-addr={{ .Values.eventsaddr }}
        - --watch-all-namespaces={{ .Values.watchallnamespaces }}
        - --log-level={{ .Values.loglevel | default "info" }}
        - --log-encoding=json
        - --enable-leader-election
        {{- range .Values.imagereflectorcontroller.container.additionalargs }}
        - {{ . }}
        {{- end}}

Describe alternatives you've considered.
Maybe it is worth to add it across all containers.
Additional context.
No response

Sounds reasonable. If we implement it, we should do it for all containers.


ci/conformance: Various image-related fixes

This PR contains two commits (see description), fixing two issues around the usage of our CI images:

Pull in the correct version of clustermesh-apiserver-ci in the clustermesh test
Wait for hubble-relay-ci and clustermesh-apiserver-ci where needed

This PR is tested in https://github.com/cilium/cilium/pull/16714

Runs from the validation PR:

:heavy_check_mark: Conformance AKS: https://github.com/cilium/cilium/actions/runs/989567855
:heavy_check_mark: Conformance AWS-CNI: https://github.com/cilium/cilium/actions/runs/989567878
:heavy_check_mark: Conformance EKS:  https://github.com/cilium/cilium/actions/runs/989567859
:x: Conformance GKE: https://github.com/cilium/cilium/runs/2961892633?check_suite_focus=true had a failure connecting to world, this is likely a known issue. The image part addressed by this PR worked without a hitch though.
:x: Conformance Multicluster:  https://github.com/cilium/cilium/runs/2961839261?check_suite_focus=true connectivity test is still failing, but it's at least now getting further than before

Not all of them are green, but since this is an improvement over the status quo and the steps affected by this PR do have passed, I think we should not block the merge of this PR.

Marking this ready-to-merge, as it is improving/fixing CI flakes.

Do we need equivalent changes on 1.10?

Do we need equivalent changes on 1.10?

Likely yes. From a first glance, looks like this patch however also requires https://github.com/cilium/cilium/pull/16363. Marking both for backport.


graphics: Random crashes where "x must be positive"

The problem
Occassionally and seemingly at random, my game will crash with the error message / stack dump below. I can't really reproduce this.
Platform
Windows 10
Graphics Card
NVIDIA GeForce GTX 970
panic: graphics: x must be positive

goroutine 51 [running]:
github.com/hajimehoshi/ebiten/internal/graphics.InternalImageSize(0x0, 0x48)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/internal/graphics/math.go:26 +0x81
github.com/hajimehoshi/ebiten/internal/restorable.(*Image).internalSize(0xc000184230, 0x48, 0xc000184230)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/internal/restorable/image.go:233 +0x4e
github.com/hajimehoshi/ebiten/internal/restorable.(*Image).fill(0xc000184230, 0xc000000000)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/internal/restorable/image.go:194 +0xc5
github.com/hajimehoshi/ebiten/internal/restorable.(*Image).clear(...)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/internal/restorable/image.go:173
github.com/hajimehoshi/ebiten/internal/restorable.NewScreenFramebufferImage(0x0, 0x0, 0x8f57d0)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/internal/restorable/image.go:162 +0x127
github.com/hajimehoshi/ebiten/internal/shareable.NewScreenFramebufferImage(0x0, 0x0, 0x0)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/internal/shareable/shareable.go:448 +0x85
github.com/hajimehoshi/ebiten.newImageWithScreenFramebuffer(0x0, 0x0, 0x0)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/image.go:773 +0x40
github.com/hajimehoshi/ebiten.(*graphicsContext).SetSize(0xc000184000, 0x3c0, 0x280, 0x0)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/graphicscontext.go:72 +0x23e
github.com/hajimehoshi/ebiten/internal/ui.(*userInterface).updateGraphicsContext(0x8cba80, 0x6ce3e0, 0xc000184000)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/internal/ui/ui_glfw.go:742 +0xf6
github.com/hajimehoshi/ebiten/internal/ui.(*userInterface).update(0x8cba80, 0x6ce3e0, 0xc000184000, 0x0, 0x0)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/internal/ui/ui_glfw.go:766 +0xf7
github.com/hajimehoshi/ebiten/internal/ui.(*userInterface).loop(0x8cba80, 0x6ce3e0, 0xc000184000, 0x0, 0x0)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/internal/ui/ui_glfw.go:812 +0x7d
github.com/hajimehoshi/ebiten/internal/ui.Run(0x3c0, 0x280, 0x3ff0000000000000, 0x677cf0, 0xb, 0x6ce3e0, 0xc000184000, 0x402001, 0x8cfef0, 0x643d60)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/internal/ui/ui_glfw.go:679 +0x159
github.com/hajimehoshi/ebiten.run(0x3c0, 0x280, 0x3ff0000000000000, 0x677cf0, 0xb, 0xc000184000, 0x3ff0000000000001, 0x0, 0x0)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/run.go:99 +0xd5
github.com/hajimehoshi/ebiten.Run.func1(0xc0000220c0, 0xc00014e030, 0x3c0, 0x280, 0x3ff0000000000000, 0x677cf0, 0xb)
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/run.go:152 +0xf9
created by github.com/hajimehoshi/ebiten.Run
        D:/GoProjects/src/github.com/hajimehoshi/ebiten/run.go:147 +0x101

Hi, thank you for reporting!
It looks like the scale value becomes 0 🤔

@silbinarywolf Are you using multiple monitors?

Another question: does this happen on launching the app, or during playing?

I do have multiple monitors
I've recently seen it crash after a few inputs, so it's not immediate (ie. maybe the game runs for 2-5 seconds tops)

Thanks. I'll check this with multiple monitors. I couldn't reproduce this with a single monitor.
Would you mind inserting println(actualScale) at https://github.com/hajimehoshi/ebiten/blob/master/internal/ui/ui_glfw.go#L728 and checking actualScale becomes 0 or not when crashing?

Will do :)

Thank you!
I couldn't reproduce this even with multiple monitors.

I found GetDpiForMonitor function usage in Chromium https://cs.chromium.org/chromium/src/ui/display/win/screen_win.cc?q=getdpiformonitor&sq=package:chromium&dr=C&l=38, which considers the case when the dpi is 0. I think this is not documented, but apparently we also need to consider this case.

https://github.com/hajimehoshi/ebiten/commit/1392129e417c13d1917570da434cb00524e29add
Now the chances of calling Win32API functions are drastically reduced, this bug might be fixed or become really really rare.

@silbinarywolf  What's going on this?

I haven't seen anything as of late but Im not 100% sure if the issue is completely gone either.
I think we can just close this and I can re-open if I see it again?

Sure, let's revisit when we find the same issue.

@hajimehoshi Hello, I see the same issue when resizing the window & getting screen size
Code example: https://go.dev/play/p/iCreoo1rtqJ
Steps to reproduce:

Run game
With enabled debug (on by default, toggled using F3)
Resize window
Game crashes from time to time with similar stack trace

If you do the same without debug (in debug I am calling screen.Bounds() it will not crash, at least I didn't experience that once), but with enabled debug it crashes really frequently
Ebitenengine version: v2.5.0-alpha.13 (on of latest commits right now)
Go: 1.20.1
OS: Pop_OS 22.04 LTS

Stack trace

panic: graphics: x must be positive
goroutine 66 [running]:
github.com/hajimehoshi/ebiten/v2/internal/graphics.InternalImageSize(...)
/home/mymmrac/.go/pkg/mod/github.com/hajimehoshi/ebiten/v2@v2.5.0-alpha.13/internal/graphics/math.go:26
github.com/hajimehoshi/ebiten/v2/internal/graphicsdriver/opengl.(*Graphics).NewImage(0xc000192700, 0x0, 0x0)
/home/mymmrac/.go/pkg/mod/github.com/hajimehoshi/ebiten/v2@v2.5.0-alpha.13/internal/graphicsdriver/opengl/graphics.go:109 +0x17d
github.com/hajimehoshi/ebiten/v2/internal/graphicscommand.(*newImageCommand).Exec(0xc0001b79c0, {0x82f7a0?, 0xc000192700?}, 0x7f77bc5d08d8?)
/home/mymmrac/.go/pkg/mod/github.com/hajimehoshi/ebiten/v2@v2.5.0-alpha.13/internal/graphicscommand/command.go:500 +0x84
github.com/hajimehoshi/ebiten/v2/internal/graphicscommand.(*commandQueue).flush(0xaea3a0, {0x82f7a0?, 0xc000192700?}, 0x1)
/home/mymmrac/.go/pkg/mod/github.com/hajimehoshi/ebiten/v2@v2.5.0-alpha.13/internal/graphicscommand/command.go:240 +0x5c4
github.com/hajimehoshi/ebiten/v2/internal/graphicscommand.(*commandQueue).Flush.func1()
/home/mymmrac/.go/pkg/mod/github.com/hajimehoshi/ebiten/v2@v2.5.0-alpha.13/internal/graphicscommand/command.go:168 +0x32
github.com/hajimehoshi/ebiten/v2/internal/thread.(*OSThread).Loop.func1(0xc0004dfef8?, 0xc0004dfed0?)
/home/mymmrac/.go/pkg/mod/github.com/hajimehoshi/ebiten/v2@v2.5.0-alpha.13/internal/thread/thread.go:51 +0x53
github.com/hajimehoshi/ebiten/v2/internal/thread.(*OSThread).Loop(0xc000024140, {0x82cc40, 0xc0000ae0a0})
/home/mymmrac/.go/pkg/mod/github.com/hajimehoshi/ebiten/v2@v2.5.0-alpha.13/internal/thread/thread.go:52 +0x85
github.com/hajimehoshi/ebiten/v2/internal/ui.(*userInterfaceImpl).Run.func1()
/home/mymmrac/.go/pkg/mod/github.com/hajimehoshi/ebiten/v2@v2.5.0-alpha.13/internal/ui/run_glfw_notsinglethread.go:50 +0x5d
golang.org/x/sync/errgroup.(*Group).Go.func1()
/home/mymmrac/.go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:75 +0x64
created by golang.org/x/sync/errgroup.(*Group).Go
/home/mymmrac/.go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:72 +0xa5

Could you file this as a new issue? Thanks,


Add toggle to mirror tracking/VMC

Either mirror the whole tracking from the skeleton (would include BVH), or just mirror while retargetting for VMC.
For applications that don't have a way to mirror tracking for vtubers.

Would like thoughts about if this should be a VMC-only feature or apply to the whole tracking

Adding my voice as somebody who would be interested in this feature. Especially if it could take other VMC inputs & mirror those as well


Extension - Re-check some old types from ExtrinsicType

Describe task:

We need to check and remove some old types from ExtrinsicType.
[x] STAKING_POOL_WITHDRAW: deprecated
[x] STAKING_LEAVE_POOL: deprecated
[x] STAKING_JOIN_POOL: consider to move to a new one

Version test: http://<IP_ADDRESS>:8900/s/rPz3d4GNA2WgM9c
Validation passed.

Install/Upgrade version
Re-check all action

stake
stake more
unstake
cancel unstake
withdraw
claim reward

Check with staking type

nomination pool
parachain
relaychain
amplitude group
liquid staking


Additional authenticated data (AAD) is missing

the encrypt and decrypt function are missing the aad parameter, needed for secure AES GCM de/encryption

I read aad does not change the security, it just binds additional data at a protocol layer


An option to reset settings to default

This will be resolved with the new UI that I'm working on now.


Update section "Local development" in README.md

Hi,
I see gulp is used instead of grunt for development, but README.md is not updated for the change.
It would be great if it is updated.
Thanks.

Fixed by d8f9ec248681abf4d35b2982e4356c27c130bc6c


Windows11 窗口缩小时会不断最大化、还原

Windows11 Build 22000.51 中，窗口最大化后还原，窗口会再次自动最大化，然后还原，然后一直循环，只能关闭应用程序

+1

+1

+1

+1 这真的太难受了

+1

+1

微软把任务栏重写了。。。

+1

It actually works  better in last build. Still has problems with snap windows

It actually works better in last build. Still has problems with snap windows

What exactly are you referring to? I'm on last build too (22000.65) but I didn't notice improvements (still has the same bug that prevents you from minimizing a window, other than the snap windows bug).

You’re right, this is still a problem. But at least the taskbar actually hides, when a window is maximized. That didn’t work on the first build

Just noticed if you minimize a maximized window by actually clicking on the taskbar icon for the indow it seems to work fine, no bug that way, a half workaround until the bug is fixed, if it ever gets fixed that is :)

Same problem for 22000.184, hope you can fix it.

Any updates?...

I just released a version to the Microsoft store. If you find any bugs, please give me feedback.
我刚更新了一个版本到应用商店，可以去下载来试试。

I just released a version to the Microsoft store. If you find any bugs, please give me feedback. 我刚更新了一个版本到应用商店，可以去下载来试试。

Works well on my end. The only two bugs I encountered are:

The taskbar doesn't stay open when going to desktop by minimizing a fullscreen window, the autohide stays on. Doesn't happen instead when going to desktop by minimizing a reduced window.
The "taskbar going up" animation is present when hovering but is not present when reducing/minimizing a fullscreen window or when going to the desktop.

I recorded both in this video:
https://user-images.githubusercontent.com/62136803/139773834-cde07bdc-53af-4f56-bbe1-45d653ec934c.mp4

I just released a version to the Microsoft store. If you find any bugs, please give me feedback. 我刚更新了一个版本到应用商店，可以去下载来试试。

Works well on my end. The only two bugs I encountered are:

The taskbar doesn't stay open when going to desktop by minimizing a fullscreen window, the autohide stays on. Doesn't happen instead when going to desktop by minimizing a reduced window.
The "taskbar going up" animation is present when hovering but is not present when reducing/minimizing a fullscreen window or when going to the desktop.

I recorded both in this video:
2021_11_02_021419.mp4

I just updated another version and fixed the first bug. The second one seems to be windows' own bug.

几个bug：
1.在桌面点击开始，任务栏也会隐藏一次。
2.控制中心，消息中心等界面位置下移（微软的问题）。
3.全屏窗口最小化时需要点一下桌面任务栏才会出现。
https://user-images.githubusercontent.com/58252651/139791861-dc5bd037-a0cc-404d-9867-955c1f4038e0.mp4

几个bug： 1.在桌面点击开始，任务栏也会隐藏一次。 2.控制中心，消息中心等界面位置下移（微软的问题）。 3.全屏窗口最小化时需要点一下桌面任务栏才会出现。
20211102_132229.mp4

第一个问题要hook任务栏才可以屏蔽关闭开始菜单时自动隐藏任务栏的机制，因为要发布到微软商店不好弄就没弄了；
第二个我试试改成点击这些选项的时候把任务栏藏起来？
第三个我看下，修好了就更。

I just released a version to the Microsoft store. If you find any bugs, please give me feedback. 我刚更新了一个版本到应用商店，可以去下载来试试。

Works well on my end. The only two bugs I encountered are:

The taskbar doesn't stay open when going to desktop by minimizing a fullscreen window, the autohide stays on. Doesn't happen instead when going to desktop by minimizing a reduced window.
The "taskbar going up" animation is present when hovering but is not present when reducing/minimizing a fullscreen window or when going to the desktop.

I recorded both in this video:
2021_11_02_021419.mp4

I just updated another version and fixed the first bug. The second one seems to be windows' own bug.

Thank you! Now it works fine :)


[FEA] Add non-UTC cases in nightly test script

Is your feature request related to a problem? Please describe.
Follow up of https://github.com/NVIDIA/spark-rapids/pull/9773
As non-UTC cases could potentially cause OOM in process, and there must be some manual maintenance and commit history to track the changes. Lets,

Add an independent func in https://github.com/NVIDIA/spark-rapids/blob/branch-23.12/jenkins/spark-tests.sh to cover the test requirements
Add a new TEST_MODE at https://github.com/NVIDIA/spark-rapids/blob/branch-23.12/jenkins/spark-tests.sh#L266-L272 and only enable if people/CI want to test against it explicitly (do not enable the as DEFAULT)

Describe the solution you'd like
A clear and concise description of what you want to happen.

PR merged.
After the nightly CI pass, then close this issue.