gitlens messing up visual studio code UI

Issue Type: Bug
tabs are not working properly after enabling git lens
explorer
search
git
debug
plugins
Extension version: 8.3.0
VS Code version: Code - Insiders 1.24.0-insider (912fff91ac4ff1bff9695e8da69abd729f7ae956, 2018-05-18T05:17:26.925Z)
OS version: Windows_NT x64 10.0.15063

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4590 CPU @ 3.30GHz (4 x 3292)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.96GB (2.76GB free)

Process Argv
C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe

Screen Reader
no

VM
0%

when i enable gitLens, clicking on the explorer tab will show a blank explorer window, have to click again in order to see files. in the search tab and the plugins tab the upper half is empty and the search box and installed plugins are shown afterwords. when i disable git lens everything goes back to normal.
i am using the insiders build

Wow I've never heard of any issues like that, nor can I even guess to how it would be possible. My only thought is that there is something corrupted in your install either with GitLens or vscode itself. Can you completely remove GitLens and restart vscode twice and make sure GitLens is removed from your .vscode-insiders folder. Then make sure you don't experience any issues and then reinstall GitLens and see if the problem persists.

uninstalled Git lens
restarted VSC twice
installed git lens
reloaded. but issue still there. please find screenshot attached.

Confirming this issue is definitely real (macOS 10.13.4), as reported by @sanket-bhalerao.
Another weird thing: getting cannot set property 'setVisible' of undefined whenever opening the source control pane.

@ruggi are you also running the insiders build? If so can you try stable to see if you see the same behavior?

@eamodio nope, I'm using the stable build of VSCode.
GitLens version: 8.3.0
VSCode version: 1.23.1 (1.23.1) d0182c3417d225529c6d5ad24b7572815d0de9ac 2018-05-10T15:58:04.452Z
OS: macOS 10.13.4

@ruggi if you open the devtools, can you see if there is more information about the setVisible error? Or any other errors?

@sanket-bhalerao Same as above -- any more information you could provide would be very helpful.

@eamodio
Also happening on Windows

Windows version: 10.0.17134 Build 17134
VSCode version: Version 1.23.1 d0182c3417d225529c6d5ad24b7572815d0de9ac
GitLens version: 8.3.1

@eamodio okay, however if I disable GitLens the issue does not re-occur.
Here is something weird I found for replicating the issue

enable GitLens
switch to the Source control tab
switch back to Explorer tab
at first you will see an empty explorer, click on the explorer icon again to see all your files.
after this if you click one time on any icon from the left sidebar some weird behavior  is seen on the UI
the 'setVisible' issue will be visible in the developer tool is visible in the console.

@sanket-bhalerao Can you please enable output channel logging by setting "gitlens.outputLevel": "verbose" in your settings.json. This will enable logging to the GitLens channel in the Output pane. Once enabled, please reproduce the issue and attach the log lines from the GitLens channel.

Also do you have any other extensions installed? Specifically something that adds other views? I can't reproduce the issue here.

Or any other custom settings that might be triggering this behavior?

@eamodio could this be causing some issue? (this is in my user settings)

"gitlens.historyExplorer.enabled": true

@eamodio there is a GitLens tab/view added inside the SCM window when gitlens is installed. if you disable it the issue will appear.

i tried this on stable as well as insiders builds.
regarding other extensions i have deleted/uninstalled all the other extensions except GitLens.
let me know in if you are able to reproduce it.

Until vscode ships a version with the fix, the best work around is either to not hide the GitLens explorer via the vscode provided context menu, and instead use GitLens' setting to disable it. You can open the GitLens settings editor by running GitLens: Open Settings from the command palette, and from there jump to the GitLens Explorer section and uncheck Show the GitLens explorer.

@eamodio yup, already enabled them. No more issue 😁

issue is resolved for me


Removing redundant files, because redirects are in place and working perfectly

Signed-off-by: tpmccallum<EMAIL_ADDRESS>Removing redundant (legacy) files to ensure no unnecessary edits can occur.
We have implemented a single-source-of-truth approach where any single file intended to be shared among different projects, i.e. contributing-docs, is disseminated via the common folder.
The redirect rules are applied when Spin starts; adjusting routes which are pre-configured in the spin.toml so there is no need to keep legacy files around, once redirects are in place.

This has been tested locally and works perfectly.


Environment creation automation

Let's make sure that the repository checkout code works as expected.

Perfect! Now, time to see what breaks when we try to actually build this...


scrolling stops working on windows 10

I've had the application open for ~4 days now (in tray).
Scrolling in any view (including settings) became impossible using the scroll wheel.
Restarting the application restored functionality.
I have a hunch this is related to smooth scrolling (and it would be nice to be able to disable it in settings), but can't offer any more useful diagnostic, unfortunately.

Yes, this could probably be a smoothscroll issue. The smoothscroll library is listening for DOM mutation events, so maybe there's an issue with that and Ember's rendering engine Glimmer.
Right now, the lib is directly added into the repo because there was no npm/bower package available when I implemented it, but I've just seen that there is one available now since a couple of weeks. Maybe the latest version does have any bugfixes, but first I need to see if it's even compatible with my modified version. I'm not sure, though...
If this issue is not related to the smoothscroll lib, then it must either be NW.js or your OS (Win10). It would be interesting to know if scroll events are still being fired in the DOM when using the mouse wheel.

I don't think I want to use the bower package... Too many bugfixes and app-specific changes have been made. I don't want to replace this with a version that I'm unable to modify without forking the whole project.
So yeah, I can't fix this bug without being able to reproduce it. :unamused:

Maybe consider submitting bugfixes upsteam? App-specific changes-wise, not sure what to do.
Still, could it be possible to not-load it in based on some setting?

Maybe consider submitting bugfixes upsteam?

The whole lib is actually written very poorly. The things I fixed have been changed upstream in a different way, so there is no need for me to submit those changes. There's a bunch of other stuff which I haven't touched yet that should be rewritten though.

Still, could it be possible to not-load it in based on some setting?

Sure, with a little bit of extra work, but this is actually more of a design decision and I think that smooth scrolling should be enabled at all times. Disabling this feature because of a bug is not a solution IMO. Like I've said, I need to know how to reproduce it, so I can fix it.
I know this is a critial bug when it occurs, but it hasn't for me in the past two years. And restarting the app is not that big of a deal, especially if you are running it for more than a couple of days. There might even be several memory leaks within NWjs, the used frameworks or the app itself.

I disagree that smooth scrolling should be enabled at all times - personally I find the "feature" (popping up in more and more places) to be fairly annoying. It doesn't matter (much) here, since my follow list rarely overflows to the point that I have to scroll...
Is there a particular reason you think it should always be on, regardless of what a user may want?

Is there a particular reason you think it should always be on

I think that the default scrolling (especially on Windows) is terrible and simply not modern. It feels clunky and doesn't look good.

regardless of what a user may want

No, but giving the user control over everything makes it much more complex and harder to maintain. The next step would be a checkbox for disabling animations, the one after that would be about the placement of the window buttons at the top-right corner, and so on...
If there is a huge demand for a setting like this, then I will implement it of course, but I don't think this will be the case.

I think that the default scrolling (especially on Windows) is terrible and simply not modern. It feels clunky and doesn't look good.

How it feels and how it looks is subjective, and viable to vary from person to person.

The next step would be a checkbox for disabling animations, the one after that would be about the placement of the window buttons at the top-right corner, and so on...

Not really. While disabling animations is a possibility, placements of the window buttons at the top right corner is an extreme hypothetical - they are standard per platform, unlike animations, "smooth scrolling" etc.

No, but giving the user control over everything makes it much more complex and harder to maintain.

I'd be fine with a compile-time configuration. It isn't much of a deal to set a function ref to either a stub or the actual smooth-scroller. "Control over everything" isn't really a thing in anything ever, and enabling options for toggling some basic functionality is typically not as complex as some like to pretend.
After a quick look-through, the only line that uses smoothscroll.js is app/components/ApplicationComponent.js :: 48. If that's the case, I doubt it'd be "much more complex and harder to maintain", if properly isolated.

I'd be fine with a compile-time configuration

Yeah that could work. I'll add this tomorrow...
I'll leave the thread open though, until I know what is happening with the smoothscroll bug...

:+1:
Now if only I didn't have to litter my windows install even more... Still, with a compile-time config, it should be easier for me to later look into it and potentially modify/fork.

I just reworked and also hopefully fixed the smoothscroll module. Could you please try this and tell me if this resolves the issue?
https://github.com/bastimeyer/livestreamer-twitch-gui/compare/master...smoothscroll

Thank you for the config-time option.
I'll compile the refactor branch and leave it on for an extended period of time, if it fails within a month I'll report back here. If it does not I'll close the issue (and consider it fixed). If anyone else runs into it might reopen later/eventually.

The scrolling did break while using the arrow keys after scrolling with the mouse wheel.
Fixed by a452e8a in master now...
Thanks for reporting!

https://github.com/bastimeyer/livestreamer-twitch-gui/issues/204#issuecomment-186192815


Broken in Sketch Version 3.3 (11624)?

Hi,
This no longer seems to be working in the latest beta of Sketch 3.3. I'm unable to launch Preview Setup, and previewing no longer seems to send anything to Skala.
Tried re-installing and still no luck. Are you experiencing the same issue?
Thanks!
Pierre

Thanks for reporting this.
It looks like the import directive has changed from #import to @import. I've fixed this in the beta branch, but I don't think there's any way to make this backwards compatible with 3.2.
Give the beta branch a try, and let me know if that doesn't work for you.

Awesome! Thanks so much, that did the trick :)
On February 22, 2015 at 1:09:26 PM, Marc Schwieterman<EMAIL_ADDRESS>wrote:
Thanks for reporting this.
It looks like the import directive has changed from #import to @import. I've fixed this in the beta branch, but I don't think there's any way to make this backwards compatible with 3.2.
Give the beta branch a try, and let me know if that doesn't work for you.
—
Reply to this email directly or view it on GitHub.

It looks like this was made backwards compatible in later builds of 3.3, so this change is no longer required.


REDUCED ROW ECHELON FORM (RREF)

Is your feature request related to a problem? Please describe.
It is related to the mathematical algorithm to convert the augmented matrix to the ROW ECHELON FORM. It is very useful in calculating linear algebra calculations.
Describe the solution you'd like
The user will enter the augmented matrix after that step-wise step we will calculate its row-echelon form by displaying each row's operations.
Additional context
I can do this in Python and C++. Plz assign this to me.

Since this is an easy issue, it has to be implemented in all four languages
Assigned!
@Volcano-Dragon : C, C++, Java, Python

Sorry, due to timing issues, I'm unable to complete this algorithm before March 15 (i.e., the last date for the SWOC S3 project submission).
I will submit it later on (as a normal contribution).
Thank you :)


clone multiple TFS branches into one Git repo?

I am trying to migrate multiple TFVC branches into one single Git repository.
ex :  git-tfs clone http://myTfsServer:8080/tfs/DefaultCollection $/project1/branch1 $/project2/branch2
but it seems it doesn't work. did anyone try this and solution?

that syntax is entirely wrong. Not sure what made you think that would work.
You'll have to clone the parent branch of those 2 branches and use the various parameters to control which childbranches you wish to take along.

what if these 2 branches don't have a parent branch? is it possible to migrate them into one single Git repo?

AFAIK, then you cannot migrate them into 1 git repo with git-tfs

Indeed, with git, you don't put unrelated projects in the same repository
like you used to do with TFVC.
you should create multiple git repositories.
On Thu, Aug 30, 2018, 19:50 Geert Bleyen<EMAIL_ADDRESS>wrote:

AFAIK, then you cannot migrate them into 1 git repo with git-tfs
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/git-tfs/git-tfs/issues/1217#issuecomment-417408879,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcFpFp3aT8knF_qAYyxn8ta5LZ6cVzDks5uWCXhgaJpZM4WT6Kt
.

second thought, assume there is a parent branch called "branch0". branch1 and branch2 are child branches of it. what is the command to migrate all 3 branches into one single Git repo?

 git-tfs clone http://myTfsServer:8080/tfs/DefaultCollection

$/project1/branch0 --branches=all
Should do the job (if you don't have cases not supported by git-tfs)

thank you for the info. but using "branches=all" will migrate all branch0 related branches. in my case there are other branches except branch1&2 which I don't want to migrate.

So, --branches=auto
And when clone is finished, then, for each branch you want:
git tfs branch --init $/Repository/ProjectBranch

--branches=auto will initialize all branches that have merges to your branch0. To avoid this you can use the parameter --ignore-branches-regex with some regex magic to only include the branches you are interested in.

Question answered, Closing


KeyError when using votenet to do the detections.

Sorry for bothering you again. I was trying to build my first agent according to your tutorial, a KeyError occurred showing that there is no key called 'camera' in the dictionary observations['poses']:

I think it might be caused by some API mistakes, while there is actually no mention for a key 'camera' according to the README file in benchbot_api repository.

That's a good pickup @TongChiYip ; thanks for that.
This is actually a bug in our updated controller code. The pose 'camera' should exist in that object.
I'll make a fix and push out a new release later today.

Above commit should fix this. Let me know if updating BenchBot doesn't resolve the issue.

Thanks @btalb . Is a complete reinstallation needed? Or we just need to rebuild the Docker images related?

If you just re-run benchbot_install it will go through all the steps, skipping whatever is already installed and reusing cached Docker layers.

Due to the firewall set by our government, a re-run of benchbot_install might be annoying, which makes me installed benchbot in a "semi-manual way" previously. If a simple re-building for related Docker images is all what I need, that would save my time.

Ah I see, no worries.
In that case, yes updating the Docker images should be all you need (mainly Git pulling the repo in /benchbot/benchbot_robot_controller/ directory, then committing the ).
You may also want to pull the latest API in the benchbot/api directory outside of Docker as well.

So the updates are only related to Git repos benchbot_api and benchbot_robot_controller?

That's correct.

I've rebuilt the related backend image and simulator image. But when I try benchbot_run, another error occurred showing that the BenchBot Robot Controller container exited unexpectedly due to file /benchbot/ros_ws/src/benchbot_robot_controller/nodes/benchbot_robot_controller is not executable. This error haven't happened in previous versions. Could this be caused by the catkin compilation? Or just my mistakes? I'm not sure.

That I would believe be an error somewhere in the manual process you've taken @TongChiYip.
That file's existed for a long time, and not been changed in any recent updates. If you're re-building with Catkin manually, you should just have to source /benchbot/ros_ws/develop/setup.bash, re-run catkin_make, and then Docker commit the results.
Sorry I can't offer anything more concrete, supporting manual building is a bit outside of our scope.


Feature add stats to about page

Also adds timed cache RxJS operator

Live at http://beta.freecodecamp.com/about

Thanks for addressing my feedback in Gitter, @BerkeleyTrue


refreshing the page still prompts me to approve access to my previous address, rather than the new address.

Micah: Bug: When I switch addresses in MetaMask while Interceptor is in signing mode, refreshing the page still prompts me to approve access to my previous address, rather than the new address.
Micah: 1. Open a dapp with MM address A selected and Interceptor in signing mode.
2. Deny the prompt to allow the dapp to access address A.
3. Clear the denial.
4. Change MM address to B.
5. Refresh the page.
6. Notice that Interceptor prompts you to allow access to address A still.
Micah: Ah, it appears that Interceptor isn't noticing the address change in MetaMask.

unable to reproduce :/

Restarting Brave resolved the issue.  It may be valuable to continue tracking this for a bit in case it happens again.

seems like it did not reoccur, closing.


➕ Update manifest file when new resx file added

If you add a new resx file using sub-generator the manifest file gets updated with new resx files info

This will resolve #5

Updated the issue with duplicate entries in manifest file for same RESX file. Now only unique entries will be added.


How can I undefine a systemd option

I would like to document the answer to:
A NixOS-provided service module I am using sets systemd.services.someservice.serviceConfig.StartLimitInterval = "somevalue";.
How can I, in a different module or my top-level config, override that value to disappear completely?
If I try
systemd.services.someservice.serviceConfig.StartLimitInterval = null;

then it still gets rendered out as
[Service]
StartLimitInterval=

while I would like it to not render at all (also because I could not find systemd documentation on whether leaving the part after = empty has the same effect as the value not being talked about at all; edit: it fails with Failed to parse sec value, ignoring:).
mkIf and mkMerge don't seem to help me here (mkIf false naturally makes my override not be an override).
How can one do this?

Should we perhaps implement it such that setting it to null makes that field disappear?

Can't we just apply the systemd semantics here, which basically translates to this?

if it's a single value, it can be overridden by defining it again, if it's a list type and there's an assignment to the empty string, the entire list prior to this is reset?

We can't really "make fields disappear" if we ship a upstream unit and just add overrides on top.

@flokli I don't quite understand how that works: How would we use that to allow a user to get rid of e.g.
systemd.nginx.serviceConfig.StartLimitInterval = "1min";

defined in nginx, so that systemd's default StartLimitInterval is used instead of what's defined in the NixOS nginx module?
Setting that to the empty string gets you a read Failed to parse sec value, ignoring: message in journalctl.

We can't really "make fields disappear" if we ship a upstream unit and just add overrides on top.

That's right, but I'm mainly concerned about overriding things defined in NixOS systemd.services.* module units, not upstream-shipped ones.
In derivations, setting e.g. configureFlags to null makes that entire environment variable disappear from the builder environment.

We probably can't "undefine" a key in an attrset.
We could probably filter out keys that are null, but then we'd still have different behaviour between units fully defined in NixOS, and those deriving from upstream-shipped units, so not sure if it's a good idea.

Try:
systemd.services.someservice.serviceConfig.StartLimitInterval = pkgs.lib.mkForce null;

Try:
systemd.services.someservice.serviceConfig.StartLimitInterval = pkgs.lib.mkForce null;

@doronbehar I already tried that, it has the same effect as foring it to "": Will render out as StartLimitInterval= in the unit file and result in a red Failed to parse sec value, ignoring:.

Then in that case you may need to refer to systemd.unit(5) where that directive is documented - it says the default value is 0. So maybe:
systemd.services.someservice.serviceConfig.StartLimitInterval = pkgs.lib.mkForce 0;

I agree with @doronbehar here - we can't really keep track of all of systemd's defaults for each value, and can't "make them disappear" either (as we also support extending upstream-provided units) - and the behaviour should here definitely be consistent.
We should really ask the users to be more explicit. @nh2, @doronbehar, could one of you file a PR updating the docs in that regard?

I think this is somewhat implied already in the docs. For example:
https://nixos.org/nixos/options.html#systemd.mounts.*.unitconfig
Says:

Each attribute in this set specifies an option in the [Unit] section of the unit. See systemd.unit(5) for details.

The error @nh2 got was generated by Systemd - not us, so I think "see systemd.unit(5)" is good enough.

Alright then.


Notebook: status bar is not floating window aware

This is a missing adoption when notebooks became floating window capable. Notice how the status bar entry appears in the main window and not the floating window:

We have had a similar issue with the text editor status bar and solved it by instantiating it per-window:
https://github.com/microsoft/vscode/blob/b41db6119374a19f030f194ac859733a95eb7009/src/vs/workbench/browser/parts/editor/editorStatus.ts#L895-L904
I think a similar approach would work for notebooks too.
The key for this to work is that you get a scoped IEditorService in the onDidCreateAuxiliaryEditorPart that allows you to listen only to editor change events in the respective window. Consequently, you use a main-window scoped editor service for the main-window status bar:
https://github.com/microsoft/vscode/blob/b41db6119374a19f030f194ac859733a95eb7009/src/vs/workbench/browser/parts/editor/editorStatus.ts#L897
Let me know if you have questions, but I think its easy to copy what we do for editor status here.

When I reload the window with a floating notebook, the status bar does not appear (macOS):

This is my attempt to fix this issue https://github.com/microsoft/vscode/pull/224222.
The problem here is if we register the contrib afterRestore, we won't get the onDidCreateAuxiliaryEditorPart event. The event is the only place where we get the window's unique instantiationService (which gives us the right statusbarservice). Without the right statusbarservice, we can't register notebook status bar items to the right place.

Not very happy about that, filed https://github.com/microsoft/vscode/issues/224256


GHES compatiblity

Hi,
I'd like to use this action, however it looks like it's not compatible with Github Enterprise.
From main.ts#L63 of this Action, it seems like this Action is not supported in an GitHub Enterprise Server environment because the baseUrl of Octokit is left as default, also step-summary looks similar.
Any chance of enhancing this? (cue)
Thanks, Andre

Gentle ping for @IanMoroney - I believe this should be a low-hanging fruit.

I'd welcome a PR with the suggested changes if you're familiar with the change that is needed?


No deep copy of config parameter collection. why?

Description
I noticed this description in Config constructor
This will change the values "in-place" i.e. operations on this class WILL modify the provided collection
after I spend a day debugging my code assuming there is deep copy there. Why was it implemented this way?
I had an issue because config instance was reused for multiple producer, one with TransactionId set in my code, another - as it is. But setting TransactionId sets it for both configs, which results one Producer to throw "Local: Erroneous state" ProducerException, which is very hard to deal with.
How to reproduce
var producerConfig0 = producerConfig;
var producerConfig1 = new ProducerConfig(producerConfig) { TransactionalId = Guid.NewGuid().ToString() };
var producer = new ProducerBuilder<string, string>(producerConfig0).Build();
producer.Produce(...); <-- Erroneous state
Checklist
Please provide the following information:

[ ] A complete (i.e. we can run it), minimal program demonstrating the problem. No need to supply a project file.
[* ] Confluent.Kafka nuget version.
[ ] Apache Kafka version.
[* ] Client configuration.
[ ] Operating system.
[ ] Provide logs (with "debug" : "..." as necessary in configuration).
[ ] Provide broker log excerpts.
[ ] Critical issue.

yeah, I agree with you. there's a long argument in an issue/pr somewhere I was having with a contributor about this and in the end I let him have his way (shouldn't have). we can't change it now unfortunately - breaking the API is worse, it's not a big enough deal to do that.

breaking the API is worse

indeed. thanks for quick response! other than this, thanks for awesome package!


Infinite bidirectional loop when altering state on FORM_CHANGED

This is a...

[] feature request
[X] bug report
[ ] usage question

What toolchain are you using for transpilation/bundling?

[ ] @angular/cli
[X] Custom @ngTools/webpack
[ ] Raw ngc
[ ] SystemJS
[ ] Rollup
[ ] Other

Environment
NodeJS Version:
Typescript Version:
Angular Version:
@angular-redux/store version:
@angular/cli version: (if applicable)
OS:
Link to repo showing the issus
(optional, but helps a lot)
Expected Behaviour:
I have used this library to connect a form input to my redux store. However, on the frontend I would like to apply an angular pipe to the input field that will format the entered integer into a comma-separated string (e.g. 10000 --> '10,000'). I would like my store to maintain the integer (10000) as the input's value, whereas the user will see the string '10,000'.
Actual Behaviour:
I tried applying a transformation to the payload (the formatted string), when '@@angular-redux/form/FORM_CHANGED' is triggered, to transform the formatted string from the input field into a simple integer. However, this resulted in an infinite loop of "FORM_CHANGED" actions being dispatched.
Stack Trace/Error Message:
Additional Notes:
This is POC code that resolves the issue described.
ngAfterContentInit() {
    Promise.resolve().then(() => {
      this.resetState();

      this.stateSubscription = this.store.subscribe(() => {
        this.formChangedSoOmitNextChange = true;              // SET TRUE HERE
        this.resetState()
      });

      Promise.resolve().then(() => {
        this.formSubscription = (<any>this.form.valueChanges)
          .debounceTime(0)
          .subscribe((values: any) => {
            if (this.formChangedSoOmitNextChange) {
              this.formChangedSoOmitNextChange = false;       // SET FALSE HERE
            } else this.publish(values)
          });
      });
    });
  }

Template code:
<input
          class="form-control border-none"
          name="chairs"
          required
          min="0"
          [ngModel]="(woodshopState$ | async).data.chairs | number: '1.0-0' | numberHideZero"
        >

FORM_CHANGED action handler code:
switch (action.type) {
    case '@@angular-redux/form/FORM_CHANGED':
      return <IWoodshopState>{
        ...state,
        data: {
          ...state.data,
          chairs: has('chairs', action.payload.value)
          ? toNumber(action.payload.value.chairs)
          : state.data.chairs,
        },
      };

One option I might suggest is to decouple your form state from your final store state, especially in situations like this. Form state is usually temporary. Once a user is done with a form, the state of the form is no longer required. Once the form has been submitted, the data can be stored in a more permanent fashion somewhere else in your state tree. This allows for a couple of things.
The first, which you are dealing with right now, is that the value you display to your user doesn't have to match the final value that the application uses as you can do a one time transformation on submission of a valid form.
The other affordance is that your form no longer has to exactly match the final data structure that you want to use inside of your application. No need to deal with ngModelGroup to create nested object structures if so desired.
Another option would be to look into an input mask library like ngx-mask that allows for different values between model and display.
As a side note, do be careful about how input masks affect the accessibility of your site as they can sometimes cause issues.
I'm going to close this as I don't believe this is a problem that this library should address at this point in time. I will add the idea of input masks/transformations onto the to be considered list though. Thanks for highlighting the use case. Best of luck!


Import legal/official sites into Data Register

Create a script or process to import the legal/official sites from csv with all associated metadata into the data register.
Acceptance Criteria

sites from csv are imported into Data register (dev, test, prod)
indigenous characters are correctly imported
aligns with data model determined in #125

Notes

data model is created in #125 that will dictate how to import this data (blocked by #125)
csv https://apps.nrs.gov.bc.ca/int/confluence/display/BCPRS/Park+Names under sites tab

deleteing this ticket as this work is covered in #125


[CARBONDATA-2311][Streaming] Fix bug to avoid to append data to streaming finish segment

At the begin of each micro batch, check the status of current segment.if the status is streaming, continue to use this segment
if the status is streaming finish, open new streaming segment to accept new streaming data
This closes #2135
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4412/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4955/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4413/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4956/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4414/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4959/

retest this please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/4416/

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/4961/


[FR] Use UTF-8 for MANIFEST.in

What's the problem this feature will solve?
I’m trying to make my package work consistently across Linux and Windows. My MANIFEST.in file contains Unicode characters. What encoding MANIFEST.in is decoded with depends on the user’s locale settings. Most Linux distros default to UTF-8. Windows defaults to a non-Unicode encoding (in fact, UTF-8 locales are a rather recent feature in Windows. My Windows 10 system still labels them as being in beta). What this means is that my package successfully builds on most Linux systems and fails to build with a UnicodeDecodeError on most Windows systems.
Describe the solution you'd like
Make it so that MANIFEST.in files are always decoded as UTF-8. This idea is similar to #1702.
Alternative Solutions
At the moment, I tell users who want to build the package to either make their locale use UTF-8 or enable UTF-8 mode. This isn’t ideal because it requires extra effort on the users part. Plus, I’m the one who created the file; I would know best what encoding it uses, not the OS.
Another solution would be to allow package authors’ to configure the encoding used by MANIFEST.in. A similar option for configuring setup.cfg’s encoding was added but was removed in favor of always using UTF-8. Based on that, I’m assuming that this project would prefer to just require UTF-8 instead of allowing the encoding to be configured.
Finally, the easiest solution would be for me to only use ASCII characters in my MANIFEST.in file. Theoretically, this would still fail on systems with a locale encoding that isn’t compatible with ASCII, but I’m not sure if any of those systems would be able to run modern Python.
Additional context
No response
Code of Conduct

[X] I agree to follow the PSF Code of Conduct

I am more in fover of https://github.com/pypa/setuptools/issues/3341


Farming station not accepting Project Red Hoes

Using:

Forge: 1277
EIO: 321

I have added the project red to teh whitelist of the farming station as:
ProjRed:Exploration:projectred.exploration.hoeruby
ProjRed:Exploration:projectred.exploration.hoesapphire
ProjRed:Exploration:projectred.exploration.hoeperidot
After loading the world they are still not being accepted. I check many times the naming and the naming of the hoe is correct. Any other hoe that I add gets added perfect except the PR hoes.
Any suggestions ?

EIO : 321 ??? what version is this ?? the latest is 2.2.6

The Project Red hoes should already be in the default config starting with build 318
To restore the default list just delete the S:farmHoes entry from your config file and it will be replaced by the default one.
And the reason why your manually added hoes do not work is a typo (see the | vs : after ProjRed). The right names are:
ProjRed|Exploration:projectred.exploration.hoeruby
ProjRed|Exploration:projectred.exploration.hoesapphire
ProjRed|Exploration:projectred.exploration.hoeperidot

Sorry yes it is 2.2.6.
I have WailaNBT and I used that to check the naming and it showed me a : and not the | - but will try that out and also delete the entries and see if that works. for me this is closed and fixed - thank you

Minecraft's default font's | has a blank space in the middle, so it's very easy to confuse with :.

fixed


Switching Header and Query Param matching to use lists

What type of PR is this?
/kind cleanup
/kind api-change
What this PR does / why we need it:
This matches the API conventions that prefer lists of named subobjects over maps.
Does this PR introduce a user-facing change?:
Header and Query Param matching are now represented with lists of named subobjects instead of maps.

lgtm with @hbagdi's comments. =)

On May 13, 2021 at 3:37 PM, Harry @.***> wrote:
@hbagdi commented on this pull request.
In apis/v1alpha2/httproute_types.go:

@@ -406,15 +409,24 @@ type HTTPRouteMatch struct {
// +kubebuilder:default={type: "Prefix", value: "/"}
Path *HTTPPathMatch json:"path,omitempty"

// Headers specifies a HTTP request header matcher.

// Headers specifies HTTP request header matchers. Multiple match values are
// ANDed together, meaning, a request must match all the specified headers
// to select the route.
//
// If multiple entries specify equivalent header names, the first entry with
// an equivalent name MUST be given precedence. Due to the
// case-insensitivity of header names, "foo" and "Foo" are considered
// equivalent.

That is hard to understand based on the current language. I've a suggestion to improve the language a little bit here.
I think having validation to prevent the user from providing two different values for the same header with type Exact is a good idea. We should open an issue to track it if you all agree.
We can just be more explicit about  cane-insensitivity of HTTP headers (i.e. call it out in a separate sentence up front rather than an aside at the end). I agree that adding duplicate detection in the validation is good, but you will want to be careful with character sets (ie. USASCII, not UTF8).

I found a bug in our verify script and opened up #670 to fix it.
/lgtm

@robscott It seems the examples didn't pass validation, I'm not sure why they failed. Could you rebase on the latest HEAD on our dev branch?

@hbagdi it was actually a great catch - I had Name as the json field name instead of name. Should be fixed now.

/lgtm


Examine Optimus STAR parameters

We're going to adjust the STAR parameters to match CellRanger for the MVP, but careful examination of the parameters is warranted.
We will be excluding, for example:
--outSamPrimaryFlag AllBestScore (this will cause a single alignment to be output when multiple alignments are primary, yielding imprecise information).

Merging this into a backlog ticket.


Disable distribution initialization

Aside from just simplifying things a bit by disabling unused codepaths,
this also frees up about 33% of Istiod's resting heap usage dfue to
avoiding the massive channel used in the distribution queue

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-basic-arm64

integ-ipv6_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-basic-arm64

integ-ipv6_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ipv6

integ-ds_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-basic-arm64

integ-ipv6_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ipv6

integ-ds_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ds

integ-distroless_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-basic-arm64

integ-ipv6_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ipv6

integ-ds_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ds

integ-distroless_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-distroless

integ-ambient_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ambient

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-basic-arm64

integ-ipv6_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ipv6

integ-ds_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ds

integ-distroless_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-distroless

integ-ambient_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ambient

integ-pilot-multicluster_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-multicluster

integ-security-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-security-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-basic-arm64

integ-ipv6_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ipv6

integ-ds_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ds

integ-distroless_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-distroless

integ-ambient_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ambient

integ-pilot-multicluster_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-multicluster

integ-security-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-security-istiodremote

integ-pilot-istiodremote-mc_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-basic-arm64

integ-ipv6_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ipv6

integ-ds_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ds

integ-distroless_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-distroless

integ-ambient_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ambient

integ-pilot-multicluster_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-multicluster

integ-security-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-security-istiodremote

integ-pilot-istiodremote-mc_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot

integ-cni_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-basic-arm64

integ-ipv6_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ipv6

integ-ds_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ds

integ-distroless_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-distroless

integ-ambient_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ambient

integ-pilot-multicluster_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-multicluster

integ-security-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-security-istiodremote

integ-pilot-istiodremote-mc_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot

integ-cni_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-cni

integ-telemetry-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-basic-arm64

integ-ipv6_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ipv6

integ-ds_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ds

integ-distroless_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-distroless

integ-ambient_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ambient

integ-pilot-multicluster_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-multicluster

integ-security-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-security-istiodremote

integ-pilot-istiodremote-mc_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot

integ-cni_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-cni

integ-telemetry-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote

integ-basic-arm64_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-basic-arm64

integ-ipv6_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ipv6

integ-ds_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ds

integ-distroless_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-distroless

integ-ambient_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-ambient

integ-pilot-multicluster_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-multicluster

integ-security-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-security-istiodremote

integ-pilot-istiodremote-mc_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot-istiodremote-mc

integ-pilot_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-pilot

integ-cni_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-cni

integ-telemetry-istiodremote_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-telemetry-istiodremote

integ-telemetry-mc_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-telemetry-mc

integ-telemetry_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-telemetry

integ-security-multicluster_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-security-multicluster

integ-security_istio
a8218bc89f9d34eb42c77dc1f59a3a70aae39bd0
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Looks like this isn't quite right

Would be nice to have but not worth the effort currently


Fixed #25068 -- Added metaclassmaker to resolve metaclass conflicts in migrations

Ticket: https://code.djangoproject.com/ticket/25068
Superseds: #5183

I certainly don't have a firm grasp on what is going on here, and I don't know how many people actually need this functionality (as no one responded to the django-developers thread).
I think I would be more open to it if there were documentation that explained the use case for making models like this so the community can say "Yes, it's a good idea" or "No, we don't recommend this and don't want to go to great lengths to support it".
Alternatively, I wonder if there any possibility of adding a hook to customize the type() call in state.py so anyone who needs this can add it in Django without patching Django itself?

I put my answer and argumentation in the ticket.
I doubt that developers that actually are using such features are looking at django-developers thread ;) They mostly just do they work.
Ask yourself why django is using metaclasses (BaseModel), then ask why other may want to use it either, then you have explanation, why this fix is so needed.
You can construct many fancy things using metaclasses, I myself use it to populate dynamically constructed objects into kind of registry, I use it as automatic serializer that maps fields, etc...
You don't have this much responses, as many people are afraid of metaclasses and don't understand it, or just they find their ways without using them.

Closing as per "not the right approach" comment on the ticket.

Not the right approach, and the other approach after 8 weeks is still in state "needs improvements" and  in fact this is same same solution but in-lined. You will never fix that with such approach. I just maintain my own django currently.


How to Upload a File to Database using Prisma

Hello Developers
I'm new to Prisma . I want to save files in DataBase Using Prisma
How i can do this ??
`model user{
id Int @id @default(autoincrement())
name String
email String @unique
// What i do for image file or other files
profilePic ??? // What i Write here to save Imgae as well
}`

You'll need a cloud storage e.g "google cloud staorage" to store the uploaded files then  you'll updated the profilePic field with the uploaded file link.
So you're mostly going to be using something like this instead
id Int @id @default(autoincrement())
name String
email String @unique
profilePic string?
}


catch and fix file encoding

This PR catches an error I recognized while running commonvoice

@aheba could you have a look at the change made on SentencePiece on this PR ? The one on CV LGTM.

Hey, thanks for the PR!
Hardcoding UTF-8 might be problematic for core library code (dataio, tokenizer): what if someone needs to use a different encoding? Though I am not sure if we have any defined stance on encodings in SpeechBrain. This  post lists different strategies for dealing with text files. Before this PR, the library code doesn't specify an encoding explicitly, so Python looks at the OS defaults and the PYTHONIOENCODING environment variable (this is the Files in a typical platform specific encoding strategy, new strategy would be Files in a consistent, known encoding). Seems like the PR is really about the Common Voice recipe, though, am I right, @flozi00 ? Any thoughts on this? I feel like this is a bigger question.
Hardcoding an encoding for a particular recipe seems natural, when that dataset has a consistent encoding.

I don't really know if CV is consistent on his encoding scheme though .....

Could we pass the encoding scheme from the hyperparameters ?
The german commonvoice is not 100% clean and contains characters from france and greek too, that'swhy the default encoding crashed.
Retrieving the encoding from system isn't clean solution, if I want to train other languages too, then I would have to change system settings for each training.

Sure, simply create a yaml variable and get it when calling commonvoice_prepare with hparams["your_variable"].

Can we set this variable global ?
So we don't need to pass at every function call, just import it from somewhere. Like this:
file_utils.py
file_encoding = "utf-8"
Recipe:
from speechbrain.utils.file_utils import file_encoding
file_encoding = "my encoding" #override default value

In core of the library:
from speechbrain.utils.file_utils import file_encoding

open(filepath, "r", encoding=file_encoding)

Without explicitly specifying the encoding, Python3 looks at a few environment sources to determine which encoding to expect. Doesn't that achieve the same globally specified encoding, but keep the ability to change the global default?

The way with Environment variables has some more limitations I think. If you are okay with the global config variable I would start at weekend with doing it. Just tell me which way you want to go, Python environment variables or global variable in code :)

Thank you @flozi00. What do you think @Gastron about this change?

I like the environment variable approach (i.e. keeping the core library as is.), because it uses the Python standard approach. I'm happy to hear more elaboration on the possible downsides of that approach, I can surely be missing something. But if nothing else, I'd like to go with the current environment variable approach and just change the recipe in this PR.


Dynamic assertion of queues and exchanges.

I didn't find the way to access the amqplib functions like "assertQueue" or "bindQueue" to dynamically add some exchanges, queues, etc on the configuration.
for my needs as an example , i want to publish on new exchanges that i create dynamically depending on the different parameters that i receive on my API
( Thanks a lot for this library ;) )
using :
rascal : 4.6.2
node : 10.15.3

Hi @Ibrahimtrrc,
There's no way with the Rascal API to programmatically create queues / exchanges after initialisation. Your only option is to get a new connection to the broker, create a channel and then assert the queue / exchange, but Rascal won't know anything about it.

hi @cressie176,
thank you for your quick response and sorry for my late one.
is it something you plan to implement ? the problem is that rascal is like the only good library to manage rabbit connections in nodeJS :) ( i'm very gratefull for that btw ). And Rabbot is unmaintained :'(

Hi @Ibrahimtrrc. Sorry it's not something I'm planning to implement at least in the short term. Sure you've already check it out but you can also use https://www.npmjs.com/package/amqp-connection-manager to manage connections with amqplib.

Thanks for that,
rascal was a way easier and more documented. Nice job

I'll close this as it's not an Issue but a missing Feature.
Thank you very much for your fast answers and your advices :)

Hi @Ibrahimtrrc,
There's no way with the Rascal API to programmatically create queues / exchanges after initialisation. Your only option is to get a new connection to the broker, create a channel and then assert the queue / exchange, but Rascal won't know anything about it.

@cressie176 are there any concerns/pitfalls with your suggestion that we should be aware of? I need the same dynamic creation so I want to do what you suggested. But I'd like to be aware of any potential problems. Thanks!

Hi @CodeWithOz
Rascal isn't really the right tool for this. Since its broker won't know about the exchanges or queues you wont be able to use it to publish or subscribe.


If there is no link preview, the link is not visible at all

For example:

The link should be displayed, even if there is no preview.

This was fixed here: https://github.com/aeternity/aepp-raendom/pull/203
apparently someone did overwrite it..

I just had formatted it https://github.com/aeternity/aepp-raendom/pull/232/files#diff-0c9c134dbd57fccd61d57dc7ad9fac6fR120-R126
Imho it looks like this case wasn't covered

I think the problem is that there was no http:// in the url when submitted by the user. The parser couldn't access it, then failed to generate any preview out of it. I think the backend should prepend the missing prefixes before trying to access the site, also frontend should prefix the href with //

There always should be http/https prefix on the URL sent for tipping.

Yes, it appears the validation failed for some reason probably due to a bug and there is now invalid data in the db.


suggest tags based on input

[ ] populate tags as you type

not needed in the nearby future releases. closing this for now.


network-gossip: add metric for number of local messages

This is useful to debug if any gossip validator might be leaking messages (i.e. by not expiring them).
Additionally this PR also increases the known messages cache size of network-gossip. This is to accommodate the increasing number of kusama validators. ~800 validators -> ~1600 GRANDPA messages per round -> we keep track of the last 2 completed rounds plus the current one -> ~4800 messages.
Setting this cache to 8192 should use about 256KB of memory (8192 * 32 bytes per block hash).

@mxinden Thanks, I implemented all your suggestions.

@mxinden Thanks, I implemented all your suggestions.

I think this metric would be a good addition to the network dashboard, in particular adding a current value as: registered - expired.

I think this metric would be a good addition to the network dashboard, in particular adding a current value as: registered - expired.

I think this metric would be a good addition to the network dashboard, in particular adding a current messages count as: registered - expired.

Sounds good. There is already a grandpa section. Thus far each of us just edited the dashboard. Feel free to do the same, just please describe your changes in the change-title that is prompted when you hit save.

I think this metric would be a good addition to the network dashboard, in particular adding a current messages count as: registered - expired.

Sounds good. There is already a grandpa section. Thus far each of us just edited the dashboard. Feel free to do the same, just please describe your changes in the change-title that is prompted when you hit save.

bot merge

bot merge


Click on open PDF file opens viewer with PDF files only

This was suggestion from status presentation on 22/11/2022.


Writing output as smiles or SDF

Thank you for developing and providing this tool. Does MolGpKa also enumerate potential protonation sites at certain pH (pH=7.4)? I see that you have added more substructures than Dimorphite-DL tool. Could you also provide or direct me in your code to get molecular structure output as smiles or SDF?

I have added a script to enumerate potential protonation stats.
src/protonate.py

@xiaolinpan Thank you for your quick response. I will test this script.

@xiaolinpan The protonate.py script works well for me. I would like to ask for another favour.
Is it possible to also provide the ChEMBL dataset (i.e 963969 acidic sites and 1167260 basic
sites or just the compounds SMILES) that was used to train the model?. This would be really useful. Thanks a lot.


Glitch when changing the name of the root dataset

With any crate, when changing the value of "Name" property under "About", the new value is properly update in the underlying data model. However, after switching tabs, for example from "About" to "Main" and then back to "About" again, the text box still displays the old value.

no longer an issue


add babel-plugin-array-includes to convert includes to indexOf >= 0

@tomekwi how do you like this?
i.e. drop
exports["default"] = function (props, object) {
  return Object.keys(object).reduce(function (res, k) {
    // istanbul ignore next

    var _ref;

    return _extends(res, props.indexOf(k) >= 0 ? null : (_ref = {}, _ref[k] = object[k], _ref));
  }, {});
};

// instead of
exports["default"] = function (props, object) {
  return Object.keys(object).reduce(function (res, k) {
    // istanbul ignore next

    var _ref;

    return _extends(res, props.includes(k)? null : (_ref = {}, _ref[k] = object[k], _ref));
  }, {});
};

Great idea! :+1: :+1:

Thanks.
Maybe the guys from babel-plugins are interessted to take over the ownership of babel-plugin-array-includes or have some input on how to improve the plugin (it was my first :flushed:)?
// cc @sebmck

@stoeffel Seems kinda brittle, foo.includes may not always reference an array. You shouldn't be performing on the raw source or dealing with strings at all (it's quite inefficient) and is kinda pointless when you have an AST that removes all that ambiguity.

@sebmck thanks for the input.

Seems kinda brittle, foo.includes may not always reference an array

Yop, you are right. But it also works with strings and typedarrays since they also have indexOf.

You shouldn't be performing on the raw source or dealing with strings at all (it's quite inefficient) and is kinda pointless when you have an AST that removes all that ambiguity.

Will try to improve that.
Thanks again for your feedback.

@stoeffel

Yop, you are right. But it also works with strings and typedarrays since they also have indexOf.

Was more referring to cases like:
class Foo {
  includes() {
    return "magic;
  }

  indexOf() {
    throw new Error("oi");
  }
}

new Foo().includes();

@sebmck I see. Thanks. I will have to check if it's an array.
I started rewriting the hole thing.
Does this look better?
      CallExpression: function (node, parent, scope, file) {
        var callee = this.get('callee');
        if (callee.node.property && callee.node.property.name === 'includes') {
          callee.node.property.name = 'indexOf';
//TODO check if array
          return t.logicalExpression(">=", node, t.literal(0));
        }
      }

Something like:
CallExpression: function (node, parent, scope, file) {
  var callee = this.get('callee');
  if (
    // this makes sure that `foo[includes]()` isn't matched
    callee.isMemberExpression({ computed: false }) &&

    // verify that the property of the member expression is `include`
    callee.get("property").isIdentifier({ name: "includes") }) &&

    // this will resolve and infer the type of a certain value, this isn't very sophisticated which means if you want this to match you have to either:
    //
    //  1. assign an array but never reassign it (constant bindings)
    //
    //     var arr = [];
    //     arr; // we can determine this is an array
    //
    //     var arr = [];
    //     arr = bar(arr); // can't be 100% confident now
    //
    //  2. flow: give the binding an Array type
    //
    //     var arr: Array = bar(); // even though we don't know what is producing this value, we've explictly provided the type
    //     arr = foo(); // since the type is explicit we don't deopt on reassignments
    //     arr; // yup! this is an Array
    //
    //  3. flow: use a typecast expression
    //
    //     (foo(): Array); // typecast expressions are a way of annotating the return type of an expression
    //
    callee.get("object").isGenericType("Array")
  ) {
    callee.node.property.name = 'indexOf';
    return t.logicalExpression(">=", node, t.literal(0));
  }
}

Should be good enough.

@sebmck Thanks a lot for your help, I did update the plugin.

@tomekwi @hemanth should we merge this?

I will rebase asap

rebased :checkered_flag:


Allow style changes using shorthands to set all the sub-styles properly

This pull request resolves issue #1241.  To test, use
var jsdom = require("jsdom").jsdom;
var doc = jsdom("");
var el = doc.createElement("div");
el.style.border = "1px solid black";
console.log(el.style.border);          // should be "1px solid black"
console.log(el.style.cssText);         // should be  "border: 1px solid black"
console.log(el.outerHTML);             // should be '

'
el.style = "border: 1px solid black";
console.log(el.style.border);          // should be "1px solid black"
console.log(el.style.cssText);         // should be  "border: 1px solid black"
console.log(el.outerHTML);             // should be '

'

Without the patch the border would be reported as just black rather than 1px solid black.

Thank you! Would you be up for adding a test to https://github.com/tmpvar/jsdom/blob/master/test/level2/style.js ?

OK, I've added a test, as requested.
Note that the test suite fails on some canvas tests, but these are not related to my changes (the master branch fails on these same tests).

Merged as 124456566b2f93acf75a06ab363849f21e4e1a7a; thank you!!


Testing: Null Pointer Exception

Why does null pointer exception happen when trying to run any libgdx classes, despite the headless application being there.

We have discussed this with antonio and a working fix has been established and this will be intergrated as part of this ticket.


Provide all relevant POD routes to the guest

This series will provide all relevant POD routes to the guest via
DHCP option 121 (RFC4332 - https://tools.ietf.org/html/rfc3442)
Should resolve #824
Signed-off-by: Vladik Romanovsky<EMAIL_ADDRESS>

retest this please

retest this please

I miss functional test to start VM's on different nodes and ping one from another.
Or create an issue and I will add it :smile:

I miss functional test to start VM's on different nodes and ping one from another.

@cynepco3hahue - It should be covered by [1], but you are welcome to improve it :)
[1] https://github.com/kubevirt/kubevirt/blob/master/tests/vm_networking_test.go#L172

@cynepco3hahue - It should be covered by [1], but you are welcome to improve it :)
[1] https://github.com/kubevirt/kubevirt/blob/master/tests/vm_networking_test.go#L172

VM to VM would indeed be great. it would cover a very relevant additional case where something can go wrong.

@vladikr @rmohr will add it to my TODO list

 BUG: pod can not ping VM on other node

 BUG: pod can not ping VM on other node

@cynepco3hahue - It should be covered by [1], but you are welcome to improve it :)
[1] https://github.com/kubevirt/kubevirt/blob/master/tests/vm_networking_test.go#L172

these unit tests verify

pod -> VM
node -> VM
VM -> google

To finish the test matrix, we should add cases for

VM -> VM
VM -> pod

We also need to make sure that we ping from different nodes

We also need to make sure that we ping from different nodes

We do ;)

Darn. very good.

retest this please

retest this please

I may have run into an issue related to this. It seems I'm getting a static route to my gateway, and no default gateway.
My lease looks like this:

lease {
interface "eth0";
fixed-address <IP_ADDRESS>;
option subnet-mask <IP_ADDRESS>;
option routers <IP_ADDRESS>;
option dhcp-lease-time 86313600;
option dhcp-message-type 5;
option domain-name-servers <IP_ADDRESS>;
option dhcp-server-identifier <IP_ADDRESS>;
option classless-static-routes <IP_ADDRESS>.1 <IP_ADDRESS>;
renew 3 2019/05/01 23:04:52;
rebind 0 2020/08/16 23:48:11;
expire 6 2020/12/19 20:48:11;
}

And results in routing table like this:

[root@fedora ~]# ip route show
<IP_ADDRESS> via <IP_ADDRESS> dev eth0 proto static

And I can't get anywhere. Maybe in the "// Filter out irrelevant routes" it should skip routes with destination IP of the gateway? Or does that defeat your purpose?
I ran some debugging and I'm getting a VIF route entry of Src= Dst.IP=<IP_ADDRESS>/32
If I do filter out the Dst == router route I'm back in business:

[root@fedora ~]# ip route show
default via <IP_ADDRESS> dev eth0


WIP

Summary of the changes / Why this improves CrateDB
Checklist

[ ] Added an entry in CHANGES.txt for user facing changes
[ ] Updated documentation & sql_features table for user facing changes
[ ] Touched code is covered by tests
[ ] CLA is signed
[ ] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

In RewriteFilterOnOuterJoinToInnerJoin optimizer rule we use a SymbolEvaluator with empty subQueryResults to do some checks (couldMatchOnNull) which will call SymbolEvaluator#visitSelectSymbol which in turn will call subQueryResults#getSafe() which throws the exception, since that map is empty.
@mfussenegger Is what I have here a correct approach, or do you suggest something else?

@matriv Yes this looks like the correct fix to me as we want to check if the query match if any symbol inside the query is NULL.

@seut Should we backport to 4.8?