[2022-04-01-preview] Add New Api-version for Microsoft.ApiManagement

ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[ ] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

    "count": {

this is not the typical implementation of a collection response in ARM. Please remove

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1133 in 5256a61. [](commit_id = 5256a61c505929673ce5df347205f1d84cef9be3, deletion_comment = False)

      "$ref": "./../../../../../common-types/resource-management/v2/types.json#/definitions/Resource"

use either trackedresource or proxyresource instead

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1268 in 5256a61. [](commit_id = 5256a61c505929673ce5df347205f1d84cef9be3, deletion_comment = False)

    "count": {

remove

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1313 in 5256a61. [](commit_id = 5256a61c505929673ce5df347205f1d84cef9be3, deletion_comment = False)

      "$ref": "./../../../../../common-types/resource-management/v2/types.json#/definitions/Resource"

use either trackedresource or proxyresource instead
Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1268 in 5256a61. [](commit_id = 5256a61, deletion_comment = False)

@rkmanda I have opened a new PR request
https://github.com/Azure/azure-rest-api-specs/pull/20461

/azp run unifiedPipeline

@solankisamir , you said this version is only deployed to canary region, will this version roll out to other regions soon?

@solankisamir , you said this version is only deployed to canary region, will this version roll out to other regions soon?

Yes, we will start rolling out this version to all regions, once we merge the PR to the main branch.

/azp run

@ArcturusZhang how should I resolve this merge conflict? I tried to create this PR, but it is huge
https://github.com/Azure/azure-rest-api-specs/pull/20860
The Change came because of your PR https://github.com/Azure/azure-rest-api-specs/pull/20756 and since apim-2022-01-01-preview is common branch, I can't directly push to it.

@solankisamir - Does this comment (https://github.com/Azure/azure-rest-api-specs/pull/20399#issuecomment-1231032119) mean ARM review is no longer required for this PR? If so, please either Close this PR or remove the WaitForARMReview label.

/azp run

@msyyc can we merge this PR if things look good?

Hi @solankisamir Why did you remove these labels:

@msyyc a gentle reminder of this!

Hi @solankisamir Why did you remove these labels:

Each commit to this api-version is already ARM Signed Off and I also saw this comment
#20399 (comment)

@solankisamir - I think you must have misunderstood my comment. I wasn't telling you ARM signoff isn't required. I was responding to your comment that you had opened another PR. I expected you would close this PR to replace it with the other PR, but that's not the case: you are moving forward with this one. This PR is adding a new API version with new APIs, so ARM signoff is required. I've added back the appropriate labels. Current oncall will help you complete ARM review.

    "count": {

consider adding reaodnly

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1279 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

  },

Are these Azure AD? It seems implied. But you could be explicit.

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1318 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

      "description": "The post redirect url after login is completed."

Is this 'POST' as in the HTTP verb, or 'post-redirect' as in 'after redirect'?

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1326 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

      "description": "The post redirect url after login is completed."

URL

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1326 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

    "count": {

Or even better, just remove it! Its not normal to include this in ARM collection apis.

In reply to:<PHONE_NUMBER>

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1279 in f60e9cf. [](commit_id = f60e9cfc0d9fec05f768bb01d90b3a8848e2e06c, deletion_comment = False)

      "description": "Total record count number across all pages."

Are you even going to know the total count across all pages? In general, ARM paged APIs might distribute reqeusts among multiple endpoints, and then filter the results based on RBAC permissions - so the count in the returned response might not match the collections actually seen by the user.

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:3714 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

      "description": "If true, the Open ID Connect provider may be used in the developer portal test console. True by default if no value is provided."

Any security impact of this setting? If so, document it clearly! Is this the secure by default option?

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:3814 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

    "count": {

This is some requirement from UI team. We are not able to remove it and have got exception from ARM Review board. This is only used for Proxy Resource, which are bound to a single region.
Updated readonly property.

In reply to:<PHONE_NUMBER>

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1279 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

      "description": "The post redirect url after login is completed."

Thanks updated everywhere

In reply to:<PHONE_NUMBER>

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1326 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

      "description": "Total record count number across all pages."

This is only for Proxy Resource which are bound to a single APIM service in a single region.

In reply to:<PHONE_NUMBER>

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:3714 in f60e9cf. [](commit_id = f60e9cfc0d9fec05f768bb01d90b3a8848e2e06c, deletion_comment = False)

            "description": "The policy document is not Xml encoded and is hosted on a http endpoint accessible from the API Management service."

XML

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:4262 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

      "description": "Binary OR value of the Snippet scope.",

Does it need capitalizing in the middle of a sentence? I'm thinking probably not...

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:4299 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

      "description": "Descriptions of APIM policies."

Inconsideration of corporate documentation style...
Despite this being in the context of API Management service, APIM may not be clear to all readers, and style guide is to avoid excessive acronyms. [Consider that your provider name is ApiManagement, and not APIM, and your general documentation doesn't use the acronym: https://learn.microsoft.com/en-us/azure/api-management/]
Please align this with your public facing documentation and replace APIM acronym with "API management" or "API Management" (your standard capitalization for your documentation) in descriptions everywhere.

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:4312 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

"ArmIdWrapper": {

We got this object from WebApp Private Endpoint Spec. We can consider this as feedback for next stable api-version change.

In reply to:<PHONE_NUMBER>

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:7434 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

      "description": "If true, the Open ID Connect provider may be used in the developer portal test console. True by default if no value is provided."

"description": "If true, the Open ID Connect provider may be used in the developer portal test console. True by default if no value is provided."
No security impact. Customer configures the Open ID Connect Provider and we provide them a TEST Console, where can they test out stuff. This has been the By Default feature.
With property customer can choose for this to not be used in Test Console.

In reply to:<PHONE_NUMBER>

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:3814 in f60e9cf. [](commit_id = f60e9cfc0d9fec05f768bb01d90b3a8848e2e06c, deletion_comment = False)

      "description": "Binary OR value of the Snippet scope.",

It is literally the OR operator

In reply to:<PHONE_NUMBER>

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:4299 in 5b71742. [](commit_id = 5b71742e4b41c01a194c4014e56dab3459d4d8e2, deletion_comment = False)

  },

Are these Azure AD? It seems implied. But you could be explicit.
Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1318 in 5b71742. [](commit_id = 5b71742, deletion_comment = False)

@TimLovellSmith I think they are Azure AD. Can you give me example of how to be more explicit?

  },

Are these Azure AD? It seems implied. But you could be explicit.
Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1318 in 5b71742. [](commit_id = 5b71742, deletion_comment = False)

@TimLovellSmith I think they are Azure AD. Can you give me example of how to be more explicit?

I think it was just extra confusing for me in the context of 'application programming interface management', and I wanted to be sure you don't mean some other kind of application id.

      "description": "The post redirect url after login is completed."

Is this 'POST' as in the HTTP verb, or 'post-redirect' as in 'after redirect'? Or just 'post-login' as in after login?
Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1326 in f60e9cf. [](commit_id = f60e9cf, deletion_comment = False)

@TimLovellSmith  After talking with my team, it's supposed to be the redirect URL after the login has been successfully completed. I will update the description.

Hi @JeffreyRichter Could you help review the swagger breaking

Why are these breaks being introduced? Was the swagger just always wrong and this PR fixes it?

Why are these breaks being introduced? Was the swagger just always wrong and this PR fixes it?

@JeffreyRichter @mikekistler we have reverted the readonly property for all resource collection response.

    "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.ApiManagement/service/apimService1/authorizationProviders/aadwithauthcode/authorizations/authz1/accesspolicies",

-> camelCase "accessPolicies"

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/examples/ApiManagementCreateAuthorizationAccessPolicy.json:20 in a317f91. [](commit_id = a317f91afaf965c4c6820c35f3301469fa591546, deletion_comment = False)

    "id": "/subscriptions/subid/resourceGroups/rg1/providers/Microsoft.ApiManagement/service/apimService1/authorizationProviders/aadwithauthcode/authorizations/authz1/accesspolicies",

-> camelCase "accessPolicies"

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/examples/ApiManagementCreateAuthorizationAccessPolicy.json:31 in a317f91. [](commit_id = a317f91afaf965c4c6820c35f3301469fa591546, deletion_comment = False)

@mikekistler here are details of the Breaking change in this PR.

❌ 1007 - RemovedClientParameter | The new version is missing a client parameter that was found in the old version. Was 'ApiVersionParameter' removed or renamed?New: Microsoft.ApiManagement/preview/2022-04-01-preview/apimanagement.json#L132:3Old: Microsoft.ApiManagement/stable/2021-08-01/apimanagement.json#L132:3

We moved to common types and this is now showing as Breaking Change. We did it on recommendation of @TimLovellSmith

❌ 1007 - RemovedClientParameter | The new version is missing a client parameter that was found in the old version. Was 'ResourceGroupNameParameter' removed or renamed?New: Microsoft.ApiManagement/preview/2022-04-01-preview/apimanagement.json#L132:3Old: Microsoft.ApiManagement/stable/2021-08-01/apimanagement.json#L132:3

We moved to common types and this is now showing as Breaking Change. We did it on recommendation of @TimLovellSmith

❌ 1007 - RemovedClientParameter | The new version is missing a client parameter that was found in the old version. Was 'SubscriptionIdParameter' removed or renamed?New: Microsoft.ApiManagement/preview/2022-04-01-preview/apimanagement.json#L132:3Old: Microsoft.ApiManagement/stable/2021-08-01/apimanagement.json#L132:3

We moved to common types and this is now showing as Breaking Change. We did it on recommendation of @TimLovellSmith

❌ 1034 - AddedRequiredProperty | The new version has new required property 'document' that was not found in the old version.New: Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json#L5724:9Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L5059:9

This is approved breaking change here https://github.com/Azure/azure-rest-api-specs/pull/20110

❌ 1034 - AddedRequiredProperty | The new version has new required property 'document' that was not found in the old version.New: Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json#L5737:5Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L5072:5

This is approved breaking change here https://github.com/Azure/azure-rest-api-specs/pull/20110

❌ 1034 - AddedRequiredProperty | The new version has new required property 'document' that was not found in the old version.New: Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json#L5724:9Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L5059:9

This is approved breaking change here https://github.com/Azure/azure-rest-api-specs/pull/20110

❌ 1034 - AddedRequiredProperty | The new version has new required property 'document' that was not found in the old version.New: Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json#L5737:5Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L5072:5

This is approved breaking change here https://github.com/Azure/azure-rest-api-specs/pull/20110

What about

This appears to change "ApiContract" from a "Resource" to a "ProxyResource". Is this intentional? Shouldn't this be considered a breaking change?

What about

This appears to change "ApiContract" from a "Resource" to a "ProxyResource". Is this intentional? Shouldn't this be considered a breaking change?

@mikekistler
The Resource construct was incorrect. These are all ProxyResources in ARM, so this is correction of that definition.

/azp run

        "$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"

v3 is the preferred version here. Any reason you decided to update to an older version ?

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/apimapis.json:87 in 8b7c808. [](commit_id = 8b7c808b4f0af427e64ad789603de67f2fd3f33c, deletion_comment = False)

        "$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"

Same comment across this PR

In reply to:<PHONE_NUMBER>

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/apimapis.json:87 in 7169f4f. [](commit_id = 7169f4fb5cd1185eef0c977b5d151f0c36c55d9d, deletion_comment = False)

      "$ref": "./../../../../../common-types/resource-management/v2/types.json#/definitions/Resource"

use either trackedresource or proxyresource instead
In reply to:<PHONE_NUMBER>
In reply to:<PHONE_NUMBER>
Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:1268 in 5256a61. [](commit_id = 5256a61, deletion_comment = False)

Please fix this : This is explained in the guidelines here :
https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md#collections
<a name="collections-avoid-count-property> ⚠ YOU SHOULD NOT return a count of all objects in the collection as this may be expensive to compute.

@solankisamir Looks mostly good.
Please consider fixing the comment on the count in your collection responses since it is not recommended to return it and also updating to v3 if possible.

        "$ref": "../../../../../common-types/resource-management/v2/types.json#/parameters/ApiVersionParameter"

v3 is the preferred version here. Any reason you decided to update to an older version ?
Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/apimapis.json:87 in 8b7c808. [](commit_id = 8b7c808, deletion_comment = False)

@raosuhas we have moved to v3 wherever possible. Thanks for the pointer

@solankisamir Looks mostly good.
Please consider fixing the comment on the count in your collection responses since it is not recommended to return it and also updating to v3 if possible.

@raosuhas I have opened issue https://github.com/Azure/azure-rest-api-specs/issues/21111 which gives details in how we are using the count property. Previously we have got a signoff from Vlad, as these are all proxy resources in ARM.
If things look good, can you take a second look.

Breaking changes all appear to be false negatives. Marking as approved.

      "type": "string",

Consider adding format arm-id?

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:7440 in 46f9565. [](commit_id = 46f9565353ee46e3c7372be0b7d938debd67fcc9, deletion_comment = False)

            "description": "The policy document is not XML encoded and is hosted on a http endpoint accessible from the API Management service."

HTTP

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json:4262 in 46f9565. [](commit_id = 46f9565353ee46e3c7372be0b7d938debd67fcc9, deletion_comment = False)

Thanks @TimLovellSmith let me work on these changes on separate PR. I don't want to reset Breaking Change Approval status.
Will create the PR, once this is merged. Hopefully none of this is blocking.

@solankisamir please resolve the change requested otherwise the merge is blocked


Missing symbols in nuget package

The publish nuget action does not publish the pdb files. :/
This is seemingly a known issue, see publish-nuget/issues/21 for the problem and a solution w/o brandedoutcast/publish-nuget.

#8 adds the ugly AllowedOutputExtensionsInPackageBuildOutputFolder
See relevant csproj


chore(update-deps)

update all deps to latest versions
switch dev tooling to typescript and jest

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@078ac4d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master        #3   +/-   ##
==========================================
  Coverage          ?   100.00%
==========================================
  Files             ?         1
  Lines             ?        29
  Branches          ?         7
==========================================
  Hits              ?        29
  Misses            ?         0
  Partials          ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078ac4d...ee8d147. Read the comment docs.


update_admin_profile task fails on namespaced org with Person Accounts enabled

Describe the bug
I am developing a namespaced, unlocked package with a dependency on a package that requires Person Accounts enabled. When using a namespaced org, the update_admin_profile task (which is used in important CCI flows such as dev_org) is failing. This does not occur if I use a non-namespaced org.
Reproduction steps

Ensure the project has a namespace defined in cumulusci.yml:

project:
  name: MY-PROJECT
  package:
    name: MY-PROJECT
    api_version: "59.0"
    namespace: MY_NS

Add a dev_namespaced org to cumulusci.yml:

orgs:
  scratch:
    dev_namespaced:
      config_file: orgs/dev.json
      days: 7
      namespaced: true

Ensure the orgs/dev.json has Person Accounts enabled:

{
  "orgName": "MY-PROJECT - Dev Org",
  "edition": "Developer",
  "features": ["PersonAccounts"],
  "settings": {
  }
}

run cci flow run dev_org --org dev_namespace
Error:

Error: Could not process MDAPI response: Update of Profile Admin: Error on line 644, col 29: In field: recordType - no RecordType named Account.Business_Account found

Your CumulusCI and Python versions
umulusCI version: 3.84.3
Python version: 3.12.2
Operating System
MacOS 14
Windows environment
No response
CumulusCI installation method
pipx
Error Gist
https://gist.github.com/asbestossupply/1ae948bcce20b1e62ab4f1674824ff0e
Additional information
No response

Apologies, this seems like a duplicate of #3544
I did notice something interesting though. After creating the namespaced org there's a discrepency between PersonAccounts and Non-Person Accounts - the former have a namespace applied but the latter do not:

And from what I can tell, the update_profile task is setting the namespace on all types. This would explain why the failure only occurs in namespaced orgs and is on the Business_Account type since it is not namespaced.


vm: creating managed image using sources from different region fails with a bad server error

repro:
az group create -n rg -l westus
az snapshot -g rg -l eastus -n s1
az image create -g rg -n i1 --source s1 --os-type linux
Deployment failed. An internal execution error occurred

For now, I will call out in related arguments' help doc

Please please fix this for real, by enabling copies of images with managed disks from one region to another.  This is a big pain point and should not require ten obtuse commands to figure out.

@kpu
This may be what you're after?
https://github.com/Azure/azure-cli-extensions/blob/master/src/image-copy/setup.py.
Let us know and we can describe how to install the extension.
cc: @tamirkamara

The Images need to be created from sources in the same Azure region.  Once created, images can be added to Azure shared image galleries for replication to other regions

Cleaning up old issues from 2016 - 2018. Please reopen this issue if it is still a concern.


flaky test: fs/git 27 Watch.Basic operations

Noticed on several PRs
https://ci.ocamllabs.io/github/mirage/irmin/commit/cd39f79d8625ca39a8c4ab319d454aa24332f428/variant/ubuntu-20.04-4.12
https://ci.ocamllabs.io/github/mirage/irmin/commit/cd39f79d8625ca39a8c4ab319d454aa24332f428/variant/ubuntu-20.10-4.12
https://ci.ocamllabs.io/github/mirage/irmin/commit/a8c70ed6303e2050305d5bbe069fc705026fb914/variant/ubuntu-20.04-4.12

[ omitted head of the log ]

--------------------------------------------------------------------------------
+10479758us application     [INFO] ASSERT workers:  branch-key update 3 on=true expected=1/4/0:1/1 current=1/6/0:1/1 1/1 (0, 0.000s)
--------------------------------------------------------------------------------
ASSERT state:  branch-key update 3 on=true expected=1/4/0:1/1 current=1/6/0:1/1 (0, 0.000s): { adds=1; updates=4; removes=0 } / { adds=1; updates=6; removes=0 }
+10479847us irmin.watch     [DEBUG] notify-all[4.101:master]: 393 firing! (17fd78c1d908ccd7a88a856977ac917d30d576ee -> fc71391d8a7bc07619463f885744c2571a55f040)
+10479880us irmin.fs        [DEBUG] find 17fd78c1d908ccd7a88a856977ac917d30d576ee
+10479903us git.unix        [DEBUG] Reading _build/test-db/objects/17/fd78c1d908ccd7a88a856977ac917d30d576ee
+10480031us irmin.fs        [DEBUG] find fc71391d8a7bc07619463f885744c2571a55f040
+10480060us git.unix        [DEBUG] Reading _build/test-db/objects/fc/71391d8a7bc07619463f885744c2571a55f040
FAIL state:  branch-key update 3 on=true expected=1/4/0:1/1 current=1/6/0:1/1 (0, 0.000s): { adds=1; updates=4; removes=0 } / { adds=1; updates=6; removes=0 }
Raised at Lwt.Miscellaneous.poll in file "src/core/lwt.ml", line 3072, characters 20-29
Called from Lwt_main.run.run_loop in file "src/unix/lwt_main.ml", line 31, characters 10-20
Called from Lwt_main.run in file "src/unix/lwt_main.ml", line 118, characters 8-13
Re-raised at Lwt_main.run in file "src/unix/lwt_main.ml", line 124, characters 4-13
Called from Alcotest_engine__Core.Make.protect_test.(fun) in file "src/alcotest-engine/core.ml", line 229, characters 17-23
Called from Alcotest_engine__Monad.Identity.catch in file "src/alcotest-engine/monad.ml", line 24, characters 31-35

Logs saved to `/src/_build/default/_build/_tests/irmin-unix/FS.027.output'.
 ──────────────────────────────────────────────────────────────────────────────

Full test results in `/src/_build/default/_build/_tests/irmin-unix'.
2 failures! in 117.653s. 119 tests run.
"/bin/bash" "-c"
"opam exec -- dune build @install @check @runtest && rm -rf _build" failed with exit status 1
2021-05-25 22:00.35: Job failed: Failed: Build failed
2021-05-25 22:00.35: Log analysis:
2021-05-25 22:00.35: >>> [FAIL]        FS                       27   Watch.Basic operations. (score = 30)
2021-05-25 22:00.35: >>> [FAIL]        GIT                      27   Watch.Basic operations. (score = 30)
2021-05-25 22:00.35: >>> [FAIL]        FS                       27   Watch.Basic operations.          │ (score = 30)
2021-05-25 22:00.35: Failed: FS Watch.Basic operations.

Slightly different error log for the same test failing here
--------------------------------------------------------------------------------
+1684018us application     [INFO] ASSERT workers:  branch-key update 0 on=true expected=1/1/0:1/1 current=1/2/0:1/1 1/1 (0, 0.000s)
--------------------------------------------------------------------------------
ASSERT state:  branch-key update 0 on=true expected=1/1/0:1/1 current=1/2/0:1/1 (0, 0.000s): { adds=1; updates=1; removes=0 } / { adds=1; updates=2; removes=0 }
+1684054us irmin.fs        [DEBUG] find ae74e7a8533b4f94c177174f4c199644836e69d9
+1684062us git.unix        [DEBUG] Reading _build/test-db/objects/ae/74e7a8533b4f94c177174f4c199644836e69d9
+1684091us irmin.tree      [DEBUG] Tree.find_tree /a/b/c
+1684098us irmin.fs        [DEBUG] find 22df31063634acfae8db11b935bfbe9342fe8491
+1684105us git.unix        [DEBUG] Reading _build/test-db/objects/22/df31063634acfae8db11b935bfbe9342fe8491
+1684129us irmin.fs        [DEBUG] find ec8b26bb1df157e2ccb7fa97c4b03adc9b62dfe4
+1684137us git.unix        [DEBUG] Reading _build/test-db/objects/ec/8b26bb1df157e2ccb7fa97c4b03adc9b62dfe4
FAIL state:  branch-key update 0 on=true expected=1/1/0:1/1 current=1/2/0:1/1 (0, 0.000s): { adds=1; updates=1; removes=0 } / { adds=1; updates=2; removes=0 }
Raised at Alcotest_engine__Test.check_err in file "src/alcotest-engine/test.ml", line 152, characters 20-48
Called from Irmin_test__Store_watch.Make.test_watches.State.check.(fun) in file "src/irmin-test/store_watch.ml", line 192, characters 17-59
Called from Irmin_test__Store_watch.Make.retry.aux in file "src/irmin-test/store_watch.ml", line 36, characters 57-67
Called from Irmin_test__Store_watch.Make.test_watches.State.apply.check in file "src/irmin-test/store_watch.ml" (inlined), line 222, characters 31-63
Called from Irmin_test__Store_watch.Make.test_watches.State.apply.aux.(fun) in file "src/irmin-test/store_watch.ml", line 243, characters 14-45
Called from Lwt.Sequential_composition.bind.create_result_promise_and_callback_if_deferred.callback in file "src/core/lwt.ml", line 1864, characters 23-26
Re-raised at Irmin_test__Common.Make_helpers.run.(fun) in file "src/irmin-test/common.ml", line 163, characters 36-72
Called from Lwt.Sequential_composition.catch.create_result_promise_and_callback_if_deferred.callback in file "src/core/lwt.ml", line 2045, characters 23-28
Re-raised at Lwt.Miscellaneous.poll in file "src/core/lwt.ml", line 3072, characters 20-29
Called from Lwt_main.run.run_loop in file "src/unix/lwt_main.ml", line 31, characters 10-20
Called from Lwt_main.run in file "src/unix/lwt_main.ml", line 118, characters 8-13
Re-raised at Lwt_main.run in file "src/unix/lwt_main.ml", line 124, characters 4-13
Called from Alcotest_engine__Core.Make.protect_test.(fun) in file "src/alcotest-engine/core.ml", line 229, characters 17-23
Called from Alcotest_engine__Monad.Identity.catch in file "src/alcotest-engine/monad.ml", line 24, characters 31-35

As of https://github.com/mirage/irmin/pull/1581, this test is now disabled. This issue now tracks re-enabling it & fixing it to not flake.

I've investigated the issue a little bit. This happens when inotify raise an extra [MOVED_TO] event. This causes some havoc:
 grep firing update-8
+60738228us irmin.watch     [DEBUG] notify-all[4.102:master]: 438 firing! (4f4384eead77c671d0ba1dfd15e73dcae0605338 -> 32a0365ef5987008a2ff615b49ce154d7e493848)
+60750320us irmin.watch     [DEBUG] notify-all[4.102:master]: 439 firing! (32a0365ef5987008a2ff615b49ce154d7e493848 -> 5834539ecb867d9294c1e5545ebf4da6e4966909)
+60754169us irmin.watch     [DEBUG] notify-all[4.102:master]: 440 firing! (5834539ecb867d9294c1e5545ebf4da6e4966909 -> 32a0365ef5987008a2ff615b49ce154d7e493848)
+60765281us irmin.watch     [DEBUG] notify-all[4.102:master]: 441 firing! (32a0365ef5987008a2ff615b49ce154d7e493848 -> 5834539ecb867d9294c1e5545ebf4da6e4966909)
+60771583us irmin.watch     [DEBUG] notify-all[4.102:master]: 442 firing! (5834539ecb867d9294c1e5545ebf4da6e4966909 -> edd392b19c72983b1ef44ed3e3db5ec46f650784)
+60776439us irmin.watch     [DEBUG] notify-all[4.102:master]: 443 firing! (edd392b19c72983b1ef44ed3e3db5ec46f650784 -> b9287d81055114685ffb4da30eded375b1cb77e2)

(I'm not sure why we are reverting back in time - there might be a cached state somewhere in irmin-watcher)


Documentation 404

The documentation link in README is broken.

Hmmm.  Does this work?  https://radeon-pro.github.io/RadeonProRenderDocs/en/sdk/about.html

@bsavery Yes👍Could you pls make a PR to update the README?

https://github.com/GPUOpen-LibrariesAndSDKs/RadeonRays_SDK/pull/216 done.


0.12.1 steamimport

Code done by Barbolani, i just uploaded to github

You forgot the plate feature in the changelog :)

forgot? i just uploaded steam file entirely...


externals breaks monorepo

Bug report
Describe the bug + reproduction
Say I have a mono repo with marketing-site (a nextjs project) and button, and button/src/index.js and button/src/style.scss.
I have loaders correctly set up to import scss files if they are within marketing-site, e.g.
{
  test: /\.scss$/,
  use: [
    {
      loader: 'css-loader',
      options: {
        modules: true,
      },
    },
    'sass-loader',
  ],
},

If, from marketing-site, I import styles from '../button/src/styles.scss', everything works fine. However, if I import the same file from within button/src/index.js, it does not work.
It turns out that the culprit is the externals key. (I found this by comparing the two webpack configs. It was working if we were in isServer: false mode.)
Looks like this function https://github.com/zeit/next.js/blob/2e14b4491b555eb2a8103ffdcb76595fe3af5155/packages/next/build/webpack.js#L36 incorrectly causes the import of the scss file to not be processed by webpack.
Setting config.externals = [] fixes the problem, it appears!
System information
mac os
next 5.0.2. I apologize if this was fixed in a newer version.

Tracking this in #706


Default dataset feature does not work with google-cloud-bigquery 1.22.0

Hi,
It seems that creating an engine with a default dataset like in the readme example
engine = create_engine('bigquery://project/dataset')
Does not work with the newest version of the bigquery library -  1.22.0.
When trying to perform a query:
sqlalchemy.exc.DatabaseError: (google.cloud.bigquery.dbapi.exceptions.DatabaseError) 400 Table name "my_table_name" missing dataset while no default dataset is set in the request.
Works fine with:

Version 1.21.0
Using the dataset as a prefix to the table name

Thanks!

I thought this might be a regression in google-cloud-bigquery, but I'm unable to reproduce with either the query() method or the DB-API.
from google.cloud import bigquery

print(bigquery.__version__)

default_config = bigquery.QueryJobConfig(
    default_dataset="bigquery-public-data.usa_names"
)

client = bigquery.Client(default_query_job_config=default_config)

sql = """
SELECT name, SUM(number) as total_people
FROM usa_1910_2013
WHERE state = 'TX'
GROUP BY name, state
ORDER BY total_people DESC
LIMIT 5
"""

rows = client.query(sql, job_config=bigquery.QueryJobConfig(use_legacy_sql=False))

print("with query():")
for row in rows:
    print(row["name"])

from google.cloud.bigquery import dbapi

connection = dbapi.connect(client=client)
cursor = connection.cursor()

print("with dbapi:")
cursor.execute(sql)
rows = cursor.fetchall()

for row in rows:
    print(row[0])

Output:
1.22.0
with query():
James
John
Michael
Robert
David
with dbapi:
James
John
Michael
Robert
David

Please assign to me, started working on resolving the issue.

Please assign to me, started working on resolving the issue.

Thanks, I am having similar issues too. Look forward to your solution.

Opened a PR
https://github.com/mxmzdlv/pybigquery/pull/32


BUG - Odata V4 int-test OPA tests not passing when generateIndex is set to false

Description
Odata V4 int-test OPA tests not passing when generateIndex is set to false
Expected results
Opa should use the flpSandbox.html when generateIndex is set to false
Actual results

@unseen1980 OK to close this now?

@unseen1980 OK to close this now?

This can be closed, thank you. 👍


Fixed possible XSS vulnerabilities by wrapping then around with h()

Shouldn't these be using JS escaping, instead of HTML?

@matthewd fixed

yea, so brakeman doesn't know about 'j', should we teach it?

Seeing if it is possible to add support for j in presidentbeef/brakeman#706
In the mean time, do we just want to add a special case to .brakemanignore?

alternative, lets add j to our brakeman config - researching

@skateman I rand out of time and threads. Could you add safe-methods: j to a config/.brakeman.conf
This could potentially really clean out our daunting .brakemanignore
//cc @Fryguy @brandondunne do we have a custom brakeman conf file? Do we run brakeman from this directory

config/brakeman.yml

If I get the chance, I'll try out over in #3792 - which was basically overlap on this same error

Ok, so I did get the chance to verify and have a PR that fixes this.


suggesting the path that works more reliably first

Signed-off-by: Joe Heck<EMAIL_ADDRESS>Circling back to do some changes, and found the way to stage changes locally wasn't working reliably for me without using the docker image, so making a small update to encourage it's use specifically

@heckj, what problems did you have running the hugo server, locally? I only use a local hugo server for testing.
Recently, this main documentation navigation, http://localhost:1313/docs/ is not linking to docs/home (https://kubernetes.io/docs/home/?path=users&persona=app-developer&level=foundational), otherwise, the site appears to be rendering correctly for local previews.

@kbhawkey I have Hugo version v0.51 (installed via homebrew), and when I tried to use the stock hugo serve thing to render a local version to see my updates and changes, it renders all the pages fine but then fails to serve locally with the error:
Web Server is available at http://localhost:1313/ (bind address <IP_ADDRESS>)

The whole output I see is:
hugo serve

                   |  EN  | ZH  | KO
+------------------+------+-----+-----+
  Pages            | 1687 | 176 |  62
  Paginator pages  |  251 |   4 |   0
  Non-page files   |  485 | 272 | 275
  Static files     |  815 | 815 | 815
  Processed images |    0 |   0 |   0
  Aliases          |    3 |   2 |   1
  Sitemaps         |    2 |   1 |   1
  Cleaned          |    0 |   0 |   0

Total in 5063 ms
Watching for changes in /Users/joeheck/src/website/{content,data,i18n,layouts,static}
Watching for config changes in /Users/joeheck/src/website/config.toml
Serving pages from memory
Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender
Web Server is available at http://localhost:1313/ (bind address <IP_ADDRESS>)
Press Ctrl+C to stop
ERROR 2018/11/17 13:00:25 Error: listen tcp <IP_ADDRESS>:1313: socket: too many open files

@heckj, thanks for sending along the output. It looks like hugo rendered the docs site, but there is a socket error:
ERROR 2018/11/17 13:00:25 Error: listen tcp <IP_ADDRESS>:1313: socket: too many open files
The version of hugo you are using is probably okay, though the docs site Makefile sets hugo at v0.49. You may want to check what processes are running on a given port on your machine.

@kbhawkey definitely verified that port 1313 wasn't already taken. The underlying error that's being exposed too many open files is from an underlying OS call, meaning there was/is some constraint on the number of file descriptors that Hugo is trying to use. I'm running MacOS Mojave (10.14.1) - and while there's no render issue, not being able to serve the files locally is a real pain.
I did scan the Hugo discussion lists, and found two bug references (https://github.com/gohugoio/hugo/issues/3393 being one), which more or less concludes that the default OS setup isn't correct and that I should know how to change ulimits to support their tooling.


fix none src model and skip load ckpt for vllm

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.stcy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


VSCodium patching error

Describe the bug
When using VSCodium on MAC aarch64 darwin, the patching for the sources fails.
error: builder for '/nix/store/hwnjakcz1rbayxsqs2zx5jll8a4ncky6-vscodium-<IP_ADDRESS>02.drv' failed with exit code 1;
       last 7 log lines:
       > unpacking sources
       > unpacking source archive /nix/store/a9rw5anrxqj3vxn7d2jvl0m3n4n6qc0v-VSCodium-darwin-arm64-<IP_ADDRESS>02.zip
       > source root is VSCodium.app
       > setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file VSCodium.app/Contents/_CodeSignature/CodeResources
       > patching sources
       > chmod: cannot access 'resources/app/node_modules/node-pty/build/Release/spawn-helper': No such file or directory
       > /nix/store/w71caj9pkfsin952sslh62rn7kxqx5h4-stdenv-darwin/setup: line 145: pop_var_context: head of shell_variables not a function context

Steps To Reproduce
Steps to reproduce the behavior:

Create a flake with nix-unstable.
Add vscodium with extensions as dependency for devShells.
build the flake.

Expected behavior
Build should be successful to create vscodium with the requested extensions.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
I am using nix-vscode-extensions to install extensions, however, in this case this fails with VSCodium build itself.
Also, nix-22.11 works with that version of vscodium . I believe its 1.72 in 22.11.
Notify maintainers
@r-ryantm
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"aarch64-darwin"`
 - host os: `Darwin 22.4.0, macOS 13.3.1`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.13.3`
 - channels(root): `""`
 - nixpkgs: `/nix/store/acdw88ki5wlgx4r893q19blrjmbggpfh-source`

Duplicate of #230675. You can check http://nixpk.gs/pr-tracker.html?pr=230681 for whether the fix has reached the channel you use


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/75758

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/102207


Project Snowflake

One request that I often see is if we can make a new Fractal instance very easily that is explicitly temporary. As MongoDB startup is lightning fast (0.06 seconds) and we can use temporary directories this is fairly easy to do:
tmpdir = tempfile.TemporaryDirectory()
mongo_args = ["mongod", "--dbpath", tmpdir.name, "--port", str(port)]

with qcfractal.testing.popen(mongo_args):
    time.sleep(1)
    client = pymongo.MongoClient("localhost:" + str(port))

I think we would have a signature like the following:
client = qcfractal.Snowflake(dbpath=None)

which would have the interface.FractalClient attributes plus a few things like await_results so that a user can let a result complete. A typical use case would to use this in a Jupyter notebook to explore a bit before running a real instance.
Thoughts?

Interesting idea, I'm not entirely sure about the use case though. What data would you explore with a Fractal instance which just popped up (I would assume it has no data populated)?

It would be more of an easy way of trying out the whole ecosystem. I think this level of data persistency is hard to wrap your head around and we have a lot of asks for the ability to loose data when trying things out. We may also consider server = qcfractal.FractalServer(temporary=True) with big warning lights. I mostly wanted a different name to be very clear that the data was not persistent.

I think this level of data persistency is hard to wrap your head around and we have a lot of asks for the ability to loose data when trying things out.

That makes sense. I'm all for it then

We may also consider server = qcfractal.FractalServer(temporary=True) with big warning lights. I mostly wanted a different name to be very clear that the data was not persistent.

I think .Snowflake is a safer, and more explicit way of doing it than a keyword. Do that instead of temporary=True so there is no chance someone gets it wrong


[React] Thumbnail mode support

This PR tries to bring back #308. It is still a WIP.
TODO

[ ] Integrate the remaining commits from #308 (configurable pictures intervals, bug fixing, etc.).
[ ] Properly display other participants pictures (video: true, although it is ignored).
[ ] Do not subscribe when a remote participant joins after the thumbnail mode has been enabled.
[ ] Reproduce video from the speaker.
[ ] [NTH] Try to reduce the interval to get the first picture.

Out of Scope

Split Participant into smaller components (display the video, take pictures, display image/picture...).

We have decided to postpone this feature. From the UX point of view, we are not sure whether it is a good idea at all.


Action create not handled

my current file starts like this:
- defaults:
    link:
        relink: true

- clean: ['~']

- create:
    - ~/.profile.d
    - ~/.local/bin
    - ~/.config/alacritty
    - ~/.config/htop
    - ~/.config/i3status
    - ~/.config/mako
    - ~/.config/redshift/hooks
    - ~/.config/rofi
    - ~/.config/sway
    - ~/.config/swaylock
    - ~/.config/yay
    - ~/.vim/pack/dotfiles

# casual
- link:
    ~/.dotfiles: ''
    ~/.bashrc: bash/bashrc
    ~/.bash_profile: bash/bashrc
...

but it always outputs Action create not handled. So no folders are created.
Even the example from the README.md does not work for me.
maybe you could add a better explanation of the yaml configuration, because i do not see the problem.

That's unusual. Especially given the example from the README doesn't work for you either. Could you try running with -v for verbose mode and see if you get any useful output there?
Also, could you let me know what Dotbot version, OS, Python version you are using?

same problem
$ ./install  -v
Action create not handled

==> Some tasks were not executed successfully

What's your Dotbot version, OS, and Python version?
This seems pretty unusual. It's on the to-do list to add better debugging output to Dotbot. In the meantime, if you're feeling adventurous, you could try adding debug prints to dotbot/dispatcher.py, e.g. printing out the list of plugins self._plugins, and checking return values of the plugin.can_handle() and plugin.handle() calls.

Arch-Linux all up to date
$ ./install --version
Dotbot version 1.15.0 (yaml: 3.12)
$ python --version
Python 3.8.1

And did you install Dotbot via git submodule or similar, or via PyPI?

git submodule

is there anything i can help with?

I will try to set up an Arch Linux VM soon to try to reproduce the issue. In the meantime, if you are feeling adventurous, you can try debugging Dotbot yourself, perhaps starting out with the approach outlined in https://github.com/anishathalye/dotbot/issues/210#issuecomment-589971253.

printing print(self._plugins):
[<dotbot.plugins.clean.Clean object at 0x7f69311d4ee0>, <dotbot.plugins.link.Link object at 0x7f69311d4d90>, <dotbot.plugins.shell.Shell object at 0x7f69311d4c40>]

am I supposed to see also an create-plugin?

printing print(self._plugins):
[<dotbot.plugins.clean.Clean object at 0x7f69311d4ee0>, <dotbot.plugins.link.Link object at 0x7f69311d4d90>, <dotbot.plugins.shell.Shell object at 0x7f69311d4c40>]

am I supposed to see also an create-plugin?

$ ./install
[<dotbot.plugins.clean.Clean object at 0x7ff77ef3bfd0>, <dotbot.plugins.link.Link object at 0x7ff77ef3bdc0>, <dotbot.plugins.shell.Shell object at 0x7ff77ef3bc10>]
can_handle False
can_handle False
can_handle False
can_handle True
Link /home/user/.steampath -> /home/user/.steam/sdk32/steam not removed.
All targets have been cleaned
handle True
Link /home/user/.steampath -> /home/user/.steam/sdk32/steam not removed.
All targets have been cleaned
can_handle False
can_handle False
can_handle False
can_handle False
can_handle False
Action create not handled
can_handle False
can_handle True
Link exists ~/.dotfiles -> /home/user/code/dotfiles/
Link exists ~/.bashrc -> /home/user/code/dotfiles/bash/bashrc
Link exists ~/.bash_profile -> /home/user/code/dotfiles/bash/bashrc

Hmm yes, you should also see create. 🤔
When I print(self._plugins), I see:
[<dotbot.plugins.clean.Clean object at 0x10373ebd0>, <dotbot.plugins.create.Create object at 0x10373ed10>, <dotbot.plugins.link.Link object at 0x10373ec50>, <dotbot.plugins.shell.Shell object at 0x10373ecd0>]
They should all be loaded at the same time, in https://github.com/anishathalye/dotbot/blob/master/dotbot/cli.py#L59. It's weird that three seem to be loaded, while just Create doesn't seem to be there.

Oh! I know what's going on. create didn't exist until after Dotbot v1.15.0. 🤦♂
You should update your Dotbot to the latest version, e.g. with git submodule update --init --remote dotbot.

okay yes that was it.
the pyyaml had some weird files in it and was preventing the update.
thanks for your help.


Proposal: Restore users and groups from Recycle Bin if possible

Hi!
I would like to add some functionality so that users and groups that have been removed are restored from the Active Directory recycle bin, if it is available. My customers have the case that it is possible that someone deletes users and groups accidentally, which DSC easily corrects - however, since new objects are created instead of deleted ones recovered, there are all kinds of issues.
Implementing that would add a lot of value, as the SID remains the same and no orphaned ACEs and other issues would occur.
If this makes sense and I am not the only one who wants this I would be happy to implement it.

Would this be a optional property on an existing resource(s) so that it first checks if the account to be created is present in the recycle bin, if it is, then it is restored from the recycle bin?

Sure, that might be a good idea. Sounds good! I'll get started then :)

Sound great, looking forward to the PR. Labeling this as in progress.

Hi @johlju , will take a bit more time I think. One conceptual question: When restoring, there is currently one error that can theoretically occur, while the other errors that could happen during a restore are already being checked.
The issue is that the parent container of an object could have been deleted as well. In this case the restore fails of course. Since we certainly don't want to simply restore the OU as well I am currently thinking of returning from the Set-TargetResource function entirely as we do not want to create the object even though it could be restored.
So in my opinion the options are:

Restore the parent OU, if any

Do not like this approach, since it does more that the resource should do

Instead of restoring, recreate the object

Do not like this approach either, as it will not address the issues that I am trying to fix by using the recycle bin

Fail the Set-TargetResource method

Does this have further ramifications? I think not, apart from the system never reaching the desired state

My issue with all approaches is: I could not find a way of finding out what the error was apart from reading the exception message. The exception type is always the same generic ADException, only the text differs. I don't want to parse text that may or may not be translated to another language.
What do your think?

Since this functionality is added as a new optional property that determine if the account should always be tried to be restored from the recycle bin, I think it correct to throw the exception that is returned by the restore command, or another appropriate error message, so the user know what happened.
If the user has opt-in to restore the object from Recycle Bin if it exist there, before creating a new object, we should always throw when that fails.


bugfix: 修复导入相同文件不触发change事件

Codecov Report

Merging #573 (a02d9f0) into v2.6.x_develop (d95be9e) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head a02d9f0 differs from pull request most recent head cdc9ef5. Consider uploading reports for the commit cdc9ef5 to get more accurate results

@@               Coverage Diff               @@
##           v2.6.x_develop     #573   +/-   ##
===============================================
  Coverage           62.29%   62.29%
===============================================
  Files                 442      442
  Lines               27429    27429
===============================================
  Hits                17088    17088
  Misses              10341    10341

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95be9e...cdc9ef5. Read the comment docs.


Use of HttpInterceptor in forFeature in-memory will not work

When trying to register the InMemoryDbService it is required to have the HttpClientModule loaded as a sibling. This is problematic when the HttpInterceptors are attached to the root HttpClientModule. In a forFeature (loadChildren route), my root interceptors will be ignored.
I understand my scenario might be a little out of scope for handling basic GET/POST. But if I reduce it to the bare bone, this is what I get.
app.module
imports: [
        HttpClientModule,
        HttpClientInMemoryWebApiModule.forRoot(MyInMemoryDbService, { passThruUnknownUrl: true })
],
providers: [
{
        provide: HTTP_INTERCEPTORS,
        useClass: MyInterceptor,
        multi: true
    }
]

admin.module
import: [
HttpClientInMemoryWebApiModule.forFeature(AdminMemoryDbService) // Does not load without HttpClientModule, but adding HttpClientModule will clear my HttpInterceptor
}

My ugly workaround is to load MyHttpClientModule with my interceptors everywhere where I add the HttpClientInMemoryWebApiModule.

@wardbell While not hyper critical, I still think this issue has merit to at least be discussed.
Functionally, the issue exists because of having to import HttpClientModule in feature modules in order for the Mock API's parseRequestUrl to get picked up.


Syntax checking or handle bad syntax files. So confusing

Even it confuses me so I had to 'debug' only to find out that the file was in bad format.
I do print out that the file is in a bad format, but the first thing I doubted was the code itself.
After changing the file to:
title \n
\n
content

with blank space between the title and content, it 'appeared' in list and viewer.
When the syntax is bad, it gets loaded in the editor anyways.
So, I think it's very important that syntax checking feature is implemented so that writer doesn't miss it in the editor, AND make it much more obvious in the /list and /view that the users don't get confused.

Server side and application side syntax checking will be added as a feature


Support ranges in patterns

1 ... 3 (numeric literal followed by three dots and a numeric literal) indicates a pattern that matches any literal in the given range.
I hope the use of ... here doesn't conflict with macro syntax.

This was un-reverted at some point.


[BUG]: stubgen.py:add_info_to_stub() adds extension code to the end of the file instead of the end of the class being extended

Description of the bug
The extension mechanism (available on any class that inherits from the ExtendableMixin class) is not properly adding extensions to the correct class in the generated .pyi files. It simply adds new methods/properties to the end of the file without checking if there is a different class at the end of the file.
Steps To Reproduce

Add an extension to the TekScope class
Generate .pyi files using the stubgen tool from mypy
Load in the extensions after first setting the "TM_DEVICES_STUB_DIR" environment variable to update the .pyi files
Notice how the extension stubs are added at the end of the file instead of to the TekScope class

Environment Information
No response
Additional Information
No response

Fixed in https://github.com/tektronix/tm_devices/releases/tag/v2.2.2

Fixed in v2.2.2


FS-2146: Fix latest sub criteria score query

Fix latest sub criteria score query limit
Add test to verify changes function as intended

Previously, we were limiting to 1 - which was only returning a single score for the entire application id.
What we actually want, is the latest score for every unique sub criteria id in an assessment record.

Looks good 👍 can we add the expectation to see the scores when testing the assessment_dashboard route?

Hey, I think that's logic relevant to the assessment frontend.  This PR is just for the back-end to pull the data back for the front-end.  Do you maybe mean something else and I'm misunderstanding?

Looks good 👍 can we add the expectation to see the scores when testing the assessment_dashboard route?

Hey, I think that's logic relevant to the assessment frontend. This PR is just for the back-end to pull the data back for the front-end. Do you maybe mean something else and I'm misunderstanding?

No worries, I did mean to add the test data for the frontend. However, I'm now adding some sample scores data in for the tests on fs-2018 so I think that will cover it 👍


Raw identifier still not working

Hello, thanks for the fast update refering https://github.com/yassun4dev/serde_valid/issues/13!
I checked the fix and when I run your test I have the following error:
error: expected expression, found keyword `type`
    |
157 |     #[rule(sample_rule(type))]
    |                        ^^^^ expected expression

error: proc-macro derive produced unparsable tokens
    |
153 |     #[derive(Validate)]
    |              ^^^^^^^^

error: could not compile `test_app` (lib test) due to 2 previous errors

my version:

rustc 1.71.0 (8ede3aae2 2023-07-12)
serde_valid = "0.16.3"

Did I miss something?

My test case is working well in rustc 1.71.
Do you get the same result when you run the same code?

I will close this Issue until someone else encounters the same problem.