Error on import { Web, PermissionKind } from "@pnp/sp"; with "SharePoint 2016 onwards" webpart

Category

[ ] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Expected or Desired Behavior
When doing the import { Web, PermissionKind } from "@pnp/sp"; on a SharePoint 2016 onwards webpart, we don't receive gulp errors.
Observed Behavior
No errors reported by gulp
Steps to Reproduce
I recorded a transcript and I am attaching the out to the request.  The only step not recorded is inserting the line:
import { Web, PermissionKind } from "@pnp/sp";
into the file MyTestWpWebPart.ts.  The output of errors is also in the transcript.  This error does not happen when doing SharePoint online only.
PowerShell_transcript.txt

duplicated by mistake


[iOS] Adapter cannot be initialized in Foreground mode

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[*] iOS
[] Android
[] tvOS
[] macOS
[] .NET Standard
UWP IS NOT SUPPORTED DURING THE BETA PERIOD - ONLY PRs ARE WELCOME FOR NOW

Version of OS(s) listed above with issue
Tested on 11.1, but probably general.
Version of Library
6.2.3, 6.2.2.
Bug probably introduced on 4 of Oct 2018 in 19dd580e89b5aefca27749cbb01c4f6ff74d9e17
Expected Behaviour
You should be able to run your app with without BLE background mode on.
If you omit bluetooth-central from you Info.plist you must init the CBCentralManager with RestoreIdentifier = null.
Actual Behavior
All calls to CrossAdapter.Init() results in
*** Assertion failure in -[CBCentralManager initWithDelegate:queue:options:] if bluetooth-central is not in Info.plist.
Im doing:
BleAdapterConfiguration adapterconfig = new BleAdapterConfiguration();
adapterconfig.RestoreIdentifier = null;
CrossBleAdapter.Init(adapterconfig);

The problem is RestoreIdentifier = config?.RestoreIdentifier ?? "acrble" in Apple/AdapterContext.cs
Since a null value will result in RestoreIdentifier="acrble"
Code of Conduct

No Library Update Requests
No Timeline Requests
Please read through the documentation and FAQs
If you have a complaint about the docs, FIX IT - DO NOT FILE IT HERE!  I won't guarantee everything is always 100% up-to-date since I am just 1 person.
Please be respectful of my time. I put a lot of effort into my libraries.  I try to support the issue requests within a day.  I'm not psychic, so please take the time to fill out the above form as complete as possible

This has been implemented in the replacement library Shiny.BluetoothLE


WIP: Polish code, javadoc, and more tests

[ ]  Every function in this class needs Javadoc comments explaining function and purpose.
[ ] Decrease the cyclomatic complexity (i.e. Reading containsAllSequential(Collection, Collection) took

[ ] The aforementioned function should also return !right_Curr.hasNext(), because a subsequence of the smaller could be found and then we run out of the left_Curr. Therefore, it would report false positives.

Also need to update README


Remove A Pair Of 2+

Closes #4931
Multisrc is still used by Sadscans, so kept it as-is.
Checklist:

[ ] Updated extVersionCode value in build.gradle for individual extensions
[ ] Updated overrideVersionCode or baseVersionCode as needed for all multisrc extensions
[x] Referenced all related issues in the PR body (e.g. "Closes #xyz")
[ ] Added the isNsfw = true flag in build.gradle when appropriate
[ ] Have not changed source names
[ ] Have explicitly kept the id if a source's name or language were changed
[ ] Have tested the modifications by compiling and running the extension through Android Studio
[ ] Have removed web_hi_res_512.png when adding a new extension

since only one source remains in multisrc, move the code to the source and remove multisrc


Fix for ISIS-2967: Definition of maxlength in @Property and @Parameter

Fix for ISIS-2967: Definition of maxlength in @Property and @Parameter for the @UserLocale in ApplicationUser

Thanks!


change hook names to be consistent with namespacing

do not review yet

Jenkins: test this please

Jenkins: test this please


  If I remove the bad catalog in settings, the templates will show up.

Version - v1.5.0-rc5
This is not fixed and is still a problem

Version - master 2/14
Verified fixed


updated_at field not updated when using update all

Environment

Elixir version (elixir -v): 1.6.4
Database and version (PostgreSQL 9.4, MongoDB 3.2, etc.): psql (PostgreSQL) 11.3
Ecto version (mix deps): 3.0.8
Database adapter and version (mix deps):
Operating system: macOS Mojave 10.14.4

Current behavior
when i using update_all, the updated_at field not updated with the current time.
Expected behavior
the updated_at field of each record that update by the update_all - should be updated to the current time.

I think that's a documented behavior: https://hexdocs.pm/ecto/Ecto.Repo.html#c:update_all/3.

This is by design and is documented as such. See https://github.com/elixir-ecto/ecto/issues/1932 for a discussion on insert_all.


Fix CHOMP DistanceFieldManager field generation to properly disable other kinbodies

When the CHOMP module computes a distance field attached to a kinbody, it does not internally disable other kinbodies during collision checking (this enables multiple bodies to be included in one field, which you often want).  However, the DistanceFieldManager assumes that there is one field per kinbody ... but when generating that field, it was not properly disabling other kinbodies.  This led to incorrect fields and poor CHOMP performance in prpy.  This PR fixes this bug.

Comments addressed!


Create an icon for Game like a console. Good icon pack. Superb..

If you'd like to request an icon, please provide the following information:

icon name
at least one use case
screenshots of similar icons

Please create one issue for each icon request.

see #134


What shall I do to support websocket?

Nats.ws requires a nats-server with websocket support.

I saw this video https://www.youtube.com/watch?v=3PYFVN7dvxQ&feature=youtu.be
but websocket is unknown field

well, i saw this line:
well allmost, waiting for public server release...

@kuange - you can use this sandbox to pull a server and play with it. https://github.com/aricart/natsws-sandbox

@aricart thanks, and hope the websocket branch merge to master branch quickly.


For review: Set shape geometry to any arbitrary preset

This change allows user to set the geometry of shapes to any shape in the Geometry enum.
Probably the most invasive PR I've proposed, so please have a close look! Overall I think it was good to move A.PresetGeometry work into a dedicated class. Tried to follow the model used by other classes.
Fixes #806. This is the refactor I proposed in that issue.
Precursor for #798. That feature should be trivial now.

PR-Codex overview
This PR focuses on refactoring the shape addition methods in the ShapeCrawler library, replacing specific rectangle shape methods with a more generic AddShape method, and enhancing geometry handling for shapes.
Detailed summary

Replaced AddRectangle, AddRoundedRectangle, and AddTopCornersRoundedRectangle methods with AddShape.
Updated tests to reflect the new method and geometry handling.
Enhanced GeometryType and CornerSize properties in IShapeGeometry.
Removed deprecated shape XML resources.
Improved shape geometry management in ShapeGeometry.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

I'm ok with this new concept. There are just some suggestions:
* replace `shapes.AddRectangle(50, 60, 100, 70)` with `shapes.Add(50, 60, 100, 70, geometry = Geometry.Rectangle)` or `shapes.AddShape(50, 60, 100, 70, geometry = Geometry.Rectangle)`

* Rename the names of geometries, at least to the first ones we already use in our tests: `Round2SameRectangle` -> `TopCornersRoundedRectangle`, `Round2DiagonalRectangle` -> `DiagonalCornersRoundedRectangle`

@ashahabov As said, so done. Thanks for reviewing!


Updated listOVPN to Include Expiration Dates

Updated listOVPN.sh script to include Expiration Dates and Cleaned up Escape Sequences.

Your pull request made the alignment a bit off, so I suggested some small changes to fix that, and also make the output more consistent with listCONF.sh.

: NOTE : The first entry should always be your valid server!

::: Certificate Status List :::
Status ::  Name        ::  Expiration
Valid  ::  debian_9ab07e1d-9ce8-4a0a-993d-e24c63816ed3  ::  mar  30  2030
Valid  ::  user                                         ::  mar  17  2023

: NOTE : The first entry should always be your valid server!

::: Certificate Status List :::
Status      Name                                             Expiration
Valid       debian_9ab07e1d-9ce8-4a0a-993d-e24c63816ed3      mar 30 2030
Valid       user                                             mar 17 2023

(the underline and bold text are still there)

Thanks orazioedoardo for the review. I've commited the  changes that you recommended.

Thanks orazioedoardo for the review. I've commited the changes that you recommended.

I added two minor changes because of a typo in previous suggestions.


Inaccurate documentation for github_actions_public_key and github_actions_secret

Terraform Version
Terraform v0.12.24

provider.github v2.5.0

Affected Resource(s)
Please list the resources as a list, for example:

github_actions_public_key
github_actions_secret

Terraform Configuration Files
Code exactly like the sample in the current documentation:
data "github_actions_public_key" "example_public_key" {
  owner      = var.github_organization
  repository = "example_repository"
}

resource "github_actions_secret" "example_secret" {
  repository       = "example_repository"
  secret_name      = "example_secret_name"
  plaintext_value  = "var.some_secret_string"
  key_id                = github_actions_public_key.example_public_key.key_id
  public_key        = github_actions_public_key.example_public_key.key
}

Output
Error: Unsupported argument

  on main.tf line 21, in data "github_actions_public_key" "public_key":
  21:   owner      = var.github_organization

An argument named "owner" is not expected here.

Error: Unsupported argument

  on main.tf line 41, in resource "github_actions_secret" "example_secret":
  41:   key_id           = github_actions_public_key.public_key.key_id

An argument named "key_id" is not expected here.

Error: Unsupported argument

  on main.tf line 42, in resource "github_actions_secret" "example_secret":
  42:   public_key       = github_actions_public_key.public_key.key

An argument named "public_key" is not expected here.

Expected Behavior
There shouldn't be Error: Unsupported argument on required arguments
Actual Behavior
The errors above are output by the plan. If the "required" fields are moved the plan succeed correctly and can be applied. This works rather than the provided example:
data "github_actions_public_key" "example_public_key" {
  repository = "example_repository"
}

resource "github_actions_secret" "example_secret" {
  repository       = "example_repository"
  secret_name      = "example_secret_name"
  plaintext_value  = "var.some_secret_string"
}

Steps to Reproduce

terraform init
terraform plan -var-file="./my.tfvars" -out=plan.out

Important Factoids
This is a company GitHub account creating secrets on a private repository.
References

https://www.terraform.io/docs/providers/github/r/actions_secret.html
https://www.terraform.io/docs/providers/github/d/actions_public_key.html

@skoblenick @benj-fletch seems like there could be a couple ways to approach this including:
1.

For the github_actions_public_key datasource: update the key_id and key fields in the schema to be set to Computed: true as these fields are set in the Read method. Update the docs to reflect these attributes and remove owner from the example config as well
For github_actions_secret resource: update just the docs to reflect the current schema (key_id and public_key omitted).

Same action for the github_actions_public_key as in #1
For github_actions_secret resource: add key_id and public_key to the schema as Optional, add logic in CreateOrUpdate to read and use the provided vals instead of calling the API method to GetPublicKey (but only when vals are not available in config), and reflect this in the docs. This seems like something of need since a github_actions_public_key retrieved in a data block  could be referenced in the github_actions_secret block as originally intended in the docs; but without validation of one key value w/o another at the Schema level, further validation in the Read method is needed.

Same action for the github_actions_public_key as in #1
Similar action for github_actions_secret resource as in #2 but: add key_id and public_key to the schema as Required fields as part of a block (e.g. key) to ensure if a user wants to reference an existing actions_public_key, both the key_id and key itself are provided in a config.

thoughts? happy to discuss other options you might of considered or anything I've missed, thanks!

Hi @anGie44, thanks for picking this up and a comprehensive change detail! My thoughts on your proposed changes:

No issues with this change
I'm not sure the benefit of adding entries for key_id and public_key here for 2 reasons:

By providing the repository we can derive the public key details and so don't need to ask the user to provide this.
Asking for the details of the public key (which requires an authenticated call in the API) they will then be stored in the state file, potentially opening a security issue.

Similar to (2)

Since it is the least amount of work and reflects how the code currently works I think we should go with option (1).
Any questions let me know 😄. Thanks!

@benj-fletch thank you for the feedback! Option 1 it is :)


Batching Feature

Currently WIP while I implement tests, integration tests, check it actually works, refine/factor types etc.
I just thought I'd 'throw this out there' as a draft PR so that we aren't duplicating work. Happy for other input / contributions on this branch or someone else to take ownership if they're keen. I will otherwise work away on this over the next few days.
Intention to close #30

Thank you very much for your PR, I haven't had time to start this work recently!

I've tested this a fair bit with the integration tests / looking at the anthropic console for batch requests. It appears to do everything vaguely sanely (I think?). I think I just want to write some tests to make codecov happy. I will do that tomorrow morning hopefully :)

It appears to do everything I expect it to. I now have tests for all new functions, but I would like to have some more detailed tests in the future. I think that can come with a later PR. Passes all integration tests.
Hope this is of a high enough standard!

Thank you, you have made a great contribution to the project. Would you like to be the Maintainer of the project?

Thank you, you have made a great contribution to the project. Would you like to be the Maintainer of the project?

Thank you very much for offering :smiley: I would be delighted to be a maintainer. I'll see if I can get #34 in too!


Missing Known Limitations

Python Script source isn't supported by the Power BI Enterprise Data Gateway, so if you'd like to use this feature, don't count on being able to keep your data refreshed.  This is pretty massive limitation.

Deploying to Power BI Service is incredibly slow. Typically publishing reports doesn't take a ton of time (20-30 seconds). I have a very small report getting about 200 rows from a Python Script source and it take about 25 minutes to publish to Power BI Service.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 070da3e8-5146-a2ca-9ac3-ed77621fc050
Version Independent ID: 2dcfbb4b-3661-50bb-43b7-050aa77e710d
Content: Run Python Scripts in Power BI Desktop - Power BI
Content Source: powerbi-docs/connect-data/desktop-python-scripts.md
Service: powerbi
Sub-service: powerbi-ai
GitHub Login: @otarb
Microsoft Alias: otarb

Hi, @andrewtuplin -- thanks for your feedback! Assigning to the author to review.

Hello @andrewtuplin

When refreshing data, Power BI On-Premise Gateway is for Power BI Service getting On-Premise data sources like databases, OData, ODBC, web, etc. However, for R script, it's not a specific data source. You can only use Personal Gateway to make Power BI Service get your On-Premise server and assign an account with relevant permission to execute the R script.

Can you share more details? How big is the report file? Are you saying that report without Python script is published in <30 seconds but same report with added script consistently takes 25 minutes to be published?

Thanks for your comment, @andrewtuplin.
This looks like product feedback or a product question, rather than documentation feedback. You can submit product feedback or feature ideas by going to Power BI Ideas.
You can also engage with the Power BI engineering team by being active in the Power BI Community.


I cann't find  newfig in plotting.

The function is there: https://github.com/NBoulle/RationalNets/blob/master/src/Approximation/plotting.py#L43

The function is there: https://github.com/NBoulle/RationalNets/blob/master/src/Approximation/plotting.py#L43

Thanks.

Thanks.


Utilize input without cell abstraction

Thanks for the package!
I'd love to use the keyboard and mouse input without the cell abstraction, is that possible at the moment? I effectively have my own draw loop, but it looks like input is coupled with Screen's loop.
I guess the alternative in my case might be to make Screen an io.Writer as well. Any thoughts?
cheers

Sorry for the long response.
I think it should be possible to make this work -- but I need to think about this... the issue is that for UNIX style terminals you really need to control the terminfo stuff, and at present I'm doing that all at once.  Probably we need to separate the terminfo stuff used for input from that used from output, because really there shouldn't be an intrinsic link between the two.

You might want to look at golang.org/x/term
I think that package might implement the simple stuff you need.  But I'm not sure as I don't understand what precisely you're trying to achieve.

I think this isn't something I'm going to do -- tcell is very definitely screen oriented, and I think we're going to keep it that way.


[Master] fix fluentd mounted docker root isn't updated

Problem:
When user updated docker root in cluster page, fluentd mounted docker root isn't updated. This bug is introduced in 2.3.
We need to update rancher logging's app config in this case.
Solution:
Update rancher logging app's config
Issue:
https://github.com/rancher/rancher/issues/21112

Reproduced this issue in Rancher v2.4.5 dockerroot volume doesn't get updated if we change the  Docker Root cluster value.
I checked this in an HA setup
Check workload rancher-logging-fluentd-linux in System project after provisioning/edit a cluster.
App sets the answer fluentd.cluster.dockerRoot correctly in a custom cluster.
The app in the local HA cluster doesn't update the fluentd.cluster.dockerRoot answer in the rancher-logging App in my testing is that expected @aiwantaozi ?


[Bug]: Error: Navigating frame was detached

Minimal, reproducible example
import puppeteer from 'puppeteer';
import fs from "node:fs/promises";

// Launch the browser and open a new blank page
const browser = await puppeteer.launch({headless: false,  devtools: true});

const page = await browser.newPage();

const cookies = await fs.readFile("../.cookie.json");
let parse = JSON.parse(cookies.toString());
await browser.setCookie(...parse);

page.setDefaultNavigationTimeout(1000 * 60);
page.setDefaultTimeout(1000 * 60 * 2);
await page.setViewport({width: 1200, height: 1024});
async function task2(){
    let waitForNavigation = page.waitForNavigation();
    await page.goto("https://cn.bing.com");
    await waitForNavigation;
    await delay(1000);
    await page.bringToFront();
    await delay(1000);
    const searchKeywords = [
        "Python 3 最佳实践",
        "JavaScript ES6 新特性",
        "React hooks 使用教程",
        "Pandas 数据分析案例",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
    ];
    for (let searchKeyword of searchKeywords) {
        console.log("handle keyword: ", searchKeyword)
        let waitSearch = page.waitForNavigation();
        await page.locator("#sb_form_q").fill(searchKeyword + `, ${new Date()}`);
        await delay(1000);
        try {
            await page.locatorRace([ page.locator("#search_icon"), page.locator("#sb_search > a"),  ]).click();
        }catch (e) {
            console.error("出错了", e);
            await page.reload();
        }
        await waitSearch;
        await delay(1000);
    }
}

await task2();

await delay(2000);
console.log("task end");
// await browser.close();

function delay(time) {
    return new Promise(resolve => setTimeout(resolve, time));
}

Background
I'm using the latest version, launched using the chrome browser that puppeteer automatically downloads.This shouldn't be a problem, but when actually running it, the problem occurs frequently and occasionally, especially in long-running programmes where the problem is prone to occur.The probability of recurrence is about 2/5, I think.
            this.#terminationDeferred.resolve(new Error('Navigating frame was detached'));
                                              ^

Error: Navigating frame was detached

When the script is started, the window will be closed in about 3s, after which the "TargetCloseError: Protocol error (Page.bringToFront): Session closed.Most likely the page has been closed." This error has a very low recurrence rate.

Expectation
I want the programme to work.
Reality
During the run, an Error: Navigating frame was detached error occurred, causing the program to terminate.
There was also a 'targetCloseError': Protocol error (Page. ringToFront): Session closed. Most likely the page has been closed.
Puppeteer configuration file (if used)
No response
Puppeteer version
23.10.2
Node version
v18.12.1
Package manager
npm
Package manager version
8.19.2
Operating system
Windows

Addendum: I found that the probability of reproducing the problem increases when setting browser.setCokie. Without setting cookies, I tried again about 10 times and did not reproduce the problem.

如果在”Error: Navigating frame was detached“错误后，再调用await page.reload();方法后，会抛出"Error: Attempted to use detached Frame '49A068B3908070D36B7B0A4EA23B10AE'."错误。

I am unable to reproduce on Mac so maybe it is Windows specific (I will try later). Does it reproduce with the script below? I modified it to not use cookies.json which was not provided. How many times do you need to run that script to see the issue? Please also include full stacktraces for the errors you get.
import puppeteer from 'puppeteer';

// Launch the browser and open a new blank page
const browser = await puppeteer.launch({headless: false});

const page = await browser.newPage();

page.setDefaultNavigationTimeout(1000 * 60);
page.setDefaultTimeout(1000 * 60 * 2);
await page.setViewport({width: 1200, height: 1024});
async function task2(){
    let waitForNavigation = page.waitForNavigation();
    await page.goto("https://cn.bing.com");
    await waitForNavigation;
    await delay(1000);
    await page.bringToFront();
    await delay(1000);
    const searchKeywords = [
        "Python 3 最佳实践",
        "JavaScript ES6 新特性",
        "React hooks 使用教程",
        "Pandas 数据分析案例",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
    ];
    for (let searchKeyword of searchKeywords) {
        console.log("handle keyword: ", searchKeyword)
        let waitSearch = page.waitForNavigation();
        await page.locator("#sb_form_q").fill(searchKeyword + `, ${new Date()}`);
        await delay(1000);
        try {
            await page.locatorRace([ page.locator("#search_icon"), page.locator("#sb_search > a"),  ]).click();
        }catch (e) {
            console.error("出错了", e);
            await page.reload();
        }
        await waitSearch;
        await delay(1000);
    }
}

await task2();

await delay(2000);

await browser.close();

function delay(time) {
    return new Promise(resolve => setTimeout(resolve, time));
}

Out of 10 runs, there will be 3 instances where the navigation has been separated. This is an occasional and frequent issue.
The browser version I'm using<EMAIL_ADDRESS>(win64), This is the bundled browser downloaded via puppeteer.What browser did you use for the test?

This is the error message I just got on my third run, I've masked out my disk path, sorry about that.

Could you add dumpio: true to launch and post that log as well?

好的，稍等，我添加下dumpio配置。

handle keyword:  Python 3 最佳实践
[13236:26280:1213/150328.073:ERROR:cert_issuer_source_aia.cc(136)] AiaRequest::OnFetchCompleted got error -105
[13236:26280:1213/150328.074:ERROR:cert_issuer_source_aia.cc(136)] AiaRequest::OnFetchCompleted got error -105
handle keyword:  JavaScript ES6 新特性
handle keyword:  React hooks 使用教程
handle keyword:  Pandas 数据分析案例
handle keyword:  Matplotlib 可视化图表制作
handle keyword:  Scikit-learn 机器学习模型
handle keyword:  RESTful API 设计原则
handle keyword:  GraphQL 查询语言介绍
handle keyword:  Matplotlib 可视化图表制作
handle keyword:  Scikit-learn 机器学习模型
file:///Project/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/LifecycleWatcher.js:100
this.#terminationDeferred.resolve(new Error('Navigating frame was detached'));
^
Error: Navigating frame was detached
at #onFrameDetached (file:///Project/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/LifecycleWatcher.js:100:47)
at file:///Project/node_modules/puppeteer-core/lib/esm/third_party/mitt/mitt.js:36:7
at Array.map ()
at Object.emit (file:///Project/node_modules/puppeteer-core/lib/esm/third_party/mitt/mitt.js:35:20)
at CdpFrame.emit (file:///Project/node_modules/puppeteer-core/lib/esm/puppeteer/common/EventEmitter.js:77:23)
at #removeFramesRecursively (file:///Project/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/FrameManager.js:448:15)
at #onClientDisconnect (file:///Project/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/FrameManager.js:91:42)
at runNextTicks (node:internal/process/task_queues:60:5)
at listOnTimeout (node:internal/timers:533:9)
at process.processTimers (node:internal/timers:507:7)
Node.js v18.12.1
This is the log message printed by running it with the dumpio: true parameter added, this time I ran it once and got this error, which is occasional, so it's quite hidden.

So I am unable to reproduce still but for me https://cn.bing.com redirects to https://bing.com. By looking at the code I wonder if the reason could be that waitForNavigation promise is not caught. Could you change let waitSearch = page.waitForNavigation(); to let waitSearch = page.waitForNavigation().catch(err => {});.

Could you perhaps also log all CDP traffic as described in https://pptr.dev/guides/debugging#log-devtools-protocol-traffic and paste it a gist.github.com?

So I am unable to reproduce still but for me https://cn.bing.com redirects to https://bing.com. By looking at the code I wonder if the reason could be that waitForNavigation promise is not caught. Could you change let waitSearch = page.waitForNavigation(); to let waitSearch = page.waitForNavigation().catch(err => {});.

Okay, I'll adjust it.

Could you perhaps also log all CDP traffic as described in https://pptr.dev/guides/debugging#log-devtools-protocol-traffic and paste it a gist.github.com?

Since I'm on win10, I used the following command to run the script now.
$env:DEBUG="puppeteer:*"; $env:DEBUG_MAX_STRING_LENGTH=$null; node .\my_github_issue.js

Could you perhaps also log all CDP traffic as described in https://pptr.dev/guides/debugging#log-devtools-protocol-traffic and paste it a gist.github.com?

Since I'm on win10, I used the following command to run the script now. $env:DEBUG="puppeteer:*"; $env:DEBUG_MAX_STRING_LENGTH=$null; node .\my_github_issue.js

please share the link to the log

so I am unable to reproduce on Windows 10 as well. Is there another site that has this issue? cn.bing.com redirects to bing.com for me and might be a different implementation.

so I am unable to reproduce on Windows 10 as well. Is there another site that has this issue? cn.bing.com redirects to bing.com for me and might be a different implementation.

The redirection is guaranteed by waitForNavigation, so redirection should not be the cause of this problem.
Because the DOM rendered by the browser is functioning properly, is it possible that it is a problem detected by the puppeteer?
Another error is that the browser's DOM is functioning properly and there is still this node, but it does not click or fill to fill in the text.

Could you perhaps also log all CDP traffic as described in https://pptr.dev/guides/debugging#log-devtools-protocol-traffic and paste it a gist.github.com?

Since I'm on win10, I used the following command to run the script now. $env:DEBUG="puppeteer:*"; $env:DEBUG_MAX_STRING_LENGTH=$null; node .\my_github_issue.js

please share the link to the log

Here's the adjusted code:
import puppeteer from 'puppeteer';

// Launch the browser and open a new blank page
const browser = await puppeteer.launch({headless: false, dumpio: true});

const page = await browser.newPage();

page.setDefaultNavigationTimeout(1000 * 60);
page.setDefaultTimeout(1000 * 60 * 2);
await page.setViewport({width: 1200, height: 1024});
async function task2(){
    let waitForNavigation = page.waitForNavigation().catch(err=>{
        console.error("catch error1", err);
    });
    await page.goto("https://cn.bing.com");
    await waitForNavigation;
    await delay(1000);
    await page.bringToFront();
    await delay(1000);
    const searchKeywords = [
        "Python 3 最佳实践",
        "JavaScript ES6 新特性",
        "React hooks 使用教程",
        "Pandas 数据分析案例",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
    ];
    for (let searchKeyword of searchKeywords) {
        console.log("handle keyword: ", searchKeyword)
        let waitSearch = page.waitForNavigation().catch(err=>{
            console.error("catch error2", err);
        });
        await page.locator("#sb_form_q").fill(searchKeyword + `, ${new Date()}`);
        await delay(1000);
        try {
            await page.locatorRace([ page.locator("#search_icon"), page.locator("#sb_search > a"),  ]).click();
        }catch (e) {
            console.error("catch error3", e);
            await page.reload();
        }
        await waitSearch;
        await delay(1000);
    }
}

await task2();

await delay(2000);

await browser.close();

function delay(time) {
    return new Promise(resolve => setTimeout(resolve, time));
}

Could you perhaps also log all CDP traffic as described in https://pptr.dev/guides/debugging#log-devtools-protocol-traffic and paste it a gist.github.com?

Since I'm on win10, I used the following command to run the script now. $env:DEBUG="puppeteer:*"; $env:DEBUG_MAX_STRING_LENGTH=$null; node .\my_github_issue.js

please share the link to the log

https://gist.github.com/xhc-code/0219c75f8e2c84970dfd2f065aa4746b

I do not see the error in that log.

Here's the updated js code:
import puppeteer from 'puppeteer';

// Launch the browser and open a new blank page
const browser = await puppeteer.launch({headless: false, dumpio: true});

const page = await browser.newPage();

page.setDefaultNavigationTimeout(1000 * 60);
page.setDefaultTimeout(1000 * 60 * 2);
await page.setViewport({width: 1200, height: 1024});
async function task2(){
    let waitForNavigation = page.waitForNavigation().catch(err=>{
        console.error("catch error1", err);
    });
    await page.goto("https://cn.bing.com");
    await waitForNavigation;
    await delay(1000);
    await page.bringToFront();
    await delay(1000);
    const searchKeywords = [
        "Python 3 最佳实践",
        "JavaScript ES6 新特性",
        "React hooks 使用教程",
        "Pandas 数据分析案例",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
        "Matplotlib 可视化图表制作",
        "Scikit-learn 机器学习模型",
        "RESTful API 设计原则",
        "GraphQL 查询语言介绍",
    ];
    for (let searchKeyword of searchKeywords) {
        console.log("handle keyword: ", searchKeyword)
        let waitSearch = page.waitForNavigation().catch(err=>{
            console.error("catch error2", err);
        });
        await page.locator("#sb_form_q").fill(searchKeyword + `, ${new Date()}`);
        await delay(1000);
        try {
            await page.locatorRace([ page.locator("#search_icon"), page.locator("#sb_search > a"),  ]).click();
        }catch (e) {
            console.error("catch error3", e);
            await page.reload();
        }
        await waitSearch;
        await delay(1000);
    }
}

await task2();

await delay(2000);

await browser.close();

function delay(time) {
    return new Promise(resolve => setTimeout(resolve, time));
}

I do not see the error in that log.

Please click to view the full document information.

Regarding paths outside of my project, I've eliminated them, so don't feel weird about the paths. paths below the node_modules directory are still preserved.

These errors are indeed thrown by the catch, but the cause of this error is not clear, as everything works fine in the launched browser and the dom is present.The page is also displayed normally.

So what is strange is that the frame is removed in #onClientDisconnect (file:///MyProject/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/FrameManager.js:91:42) and I do not see the CDP targets for the main frame being disconnected. It looks like the WebSocket connection might be breaking? (any anivirus software installed?) Could you try with pipe: true in launch?

So what is strange is that the frame is removed in #onClientDisconnect (file:///MyProject/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/FrameManager.js:91:42) and I do not see the CDP targets for the main frame being disconnected. It looks like the WebSocket connection might be breaking? (any anivirus software installed?) Could you try with pipe: true in launch?

No third-party antivirus software is installed.

These errors are indeed thrown by the catch, but the cause of this error is not clear, as everything works fine in the launched browser and the dom is present.The page is also displayed normally.

Although the page can be displayed normally, but about the puppeteer after the subsequent operations are stopped, and then reached the timeout or after the operation of the method such as page.reload, it will immediately throw an exception to terminate the procedure.

Could you please try with pipe: true in launch?

Could you please try with pipe: true in launch?

Ok, may I ask what browser you are using for testing?Could it be that the chrome browser installed via the npx @puppeteer/browsers install command is buggy and not compatible?

The code above also has this problem sometimes, where the page doesn't load and doesn't render the content.This is also occasional.

I am using the default browser downloaded by Puppeteer when installing npm i<EMAIL_ADDRESS><EMAIL_ADDRESS>C:\Users\...\.cache\puppeteer\chrome\win64-131.0.6778.87\chrome-win64\chrome.exe)

The code above also has this problem sometimes, where the page doesn't load and doesn't render the content.This is also occasional.

that seems to be a normal error when the page fails to load (which is possible due to the network issues or if the page detects automation and turns on some infinite fake loading activity).

I am using the default browser downloaded by Puppeteer when installing npm i<EMAIL_ADDRESS><EMAIL_ADDRESS>C:\Users\...\.cache\puppeteer\chrome\win64-131.0.6778.87\chrome-win64\chrome.exe)

Well, the browser version is the same.

The code above also has this problem sometimes, where the page doesn't load and doesn't render the content.This is also occasional.

that seems to be a normal error when the page fails to load (which is possible due to the network issues or if the page detects automation and turns on some infinite fake loading activity).

Is there any other way to prevent this kind of thing besides increasing the delay per step?

The code above also has this problem sometimes, where the page doesn't load and doesn't render the content.This is also occasional.

that seems to be a normal error when the page fails to load (which is possible due to the network issues or if the page detects automation and turns on some infinite fake loading activity).

Is there any other way to prevent this kind of thing besides increasing the delay per step?

the correct way to code this is to catch errors and retry or give up if the site is blocking the automation. Increasing timeouts only helps for genuine slowness.

The code above also has this problem sometimes, where the page doesn't load and doesn't render the content.This is also occasional.

that seems to be a normal error when the page fails to load (which is possible due to the network issues or if the page detects automation and turns on some infinite fake loading activity).

Is there any other way to prevent this kind of thing besides increasing the delay per step?

the correct way to code this is to catch errors and retry or give up if the site is blocking the automation. Increasing timeouts only helps for genuine slowness.

Okay, thank you for your help.

Could you please try with pipe: true in launch?

I've retried about 7 times and I don't get the "Navigating frame was detached" error anymore, except for the grey screen above. I'm not sure if this issue has been resolved, it's just hard to reproduce it at the moment.

the stack trace indicates that the websocket connection is broken, resulting in all these errors. Pipe: true does not use a WebSocket, so if it does not reproduce anymore, it is the WebSocket connection that is the reason. As I am not able to reproduce on my Windows, it must be something on your system that terminates/interrupts WebSocket connections. I believe you would also see the disconnected event on the browser instance https://pptr.dev/api/puppeteer.browser which is also a clear indication that the entire browser got disconnected so there is no point in invoking Puppeteer APIs further.

Could you please try with pipe: true in launch?

I've retried about 7 times and I don't get the "Navigating frame was detached" error anymore, except for the grey screen above. I'm not sure if this issue has been resolved, it's just hard to reproduce it at the moment.

the stack trace indicates that the websocket connection is broken, resulting in all these errors. Pipe: true does not use a WebSocket, so if it does not reproduce anymore, it is the WebSocket connection that is the reason. As I am not able to reproduce on my Windows, it must be something on your system that terminates/interrupts WebSocket connections. I believe you would also see the disconnected event on the browser instance https://pptr.dev/api/puppeteer.browser which is also a clear indication that the entire browser got disconnected so there is no point in invoking Puppeteer APIs further.

Okay.

Just wanted to chime in as I've faced constant frame detaching errors using Chrome. It was one of the main reasons I then used the Firefox channel, but then some things don't work and hence I switched back.
I've been using this function to check that a frame is successfully detached before doing any actions with page (closing and navigating to a url)
async safelyWait(page) {         while (page.mainFrame().detached) {             await sleep(100);         }     }
But oftentimes I get frame detached errors that come out of nowhere


[Client][Transaction] Fix OpBase.callback is not called in TransactionMetaStoreHandler#failPendingRequest

Motivation
failPendingRequest() is changed to be executed in internalPinnedExecutor in #13135
But pendingRequests.clear() is called right after failPendingRequest(), so pendingRequests is always empty when the codes in failPendingRequest is executed.
Modifications

Remove failPendingRequest() out of internalPinnedExecutor. It's already executed in internalPinnedExecutor.
Changes pendingRequests.keys() to pendingRequests.forEach, as ConcurrentLongHashMap#keys makes a  copy of keys.

Verifying this change

[ ] Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as org.apache.pulsar.client.impl.TransactionClientConnectTest#testPulsarClientCloseThenCloseTcClient
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] no-need-doc

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


Error assigning OSC address for performance metrics (att & eng)

There is an error when assigning the OSC address with which information is sent for performance metrics.
When I try to give an OSC address to "attention" y automatically changes the address of "engagement" as well.
If I do it the other way around, "engagement" sets the address for "attention".
The problem occurs only with these two variables, the rest are fine.
Cheers

hi, after update to last version, you need to creat a new preset and add the mapping again

Hi @mauroLab
We fixed this issue in the newest EmotivBCI and update it into Emotiv OSC repo. https://github.com/Emotiv/opensoundcontrol


String::operator+ summary is incorrectly describing String::operator==

Fix the summary for String::operator+.  It was incorrectly describing the String::operator==

@natenovielli,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Adding custom data to build-info

Different projects generate quite different types of build metadata, from test reports to generated documentation.
It would be great if the build-info that is being pushed to artifactory would be extensible to allow for the above to be included.
For smaller data such items may be embedded into the build-info structure (and the containing artifactory repo), while for larger items, this may involve setting up additional repos with new artifacts being referenced by the build-info (similar to "dependencies").
Finally (though that is more a feature request for Artifactory itself), it would be great if the Artifactory web portal had built-in viewers for such artifact types, a way to navigate through test reports, generated HTML docs, etc.

Any update on this topic. It would be great to add more metadata associated with the generated artifact.


HTTPS scheme in email links

Hello,
Do you know a simple way to force all links generated in emails from http:// to https:// please ?
For example when I receive the "Forgot password" email, the link is take from the reset_password_link variable.
This variable is generated in the send_reset_password_email() function, but the the _scheme argument is not customizable.
Did I miss something or this feature does not exists yet please ?

See https://gitlab.com/tvaughan/docker-flask-starterkit/blob/master/flask-app/starterkit/app.py#L14

Hmmm. {{ reset_password_link }} is generated with flask.url_for(), which uses the scheme of the current request. So if the page that generates the link is using https (e.g. https://user/forgot-password), then the reset_password_link should start with https://.
Are you using https:// throughout your website?
Ling


[qt5] Qt5 build fails with an obscure error message if the vcpkg directory absolute path is 36 characters long or more

Some weeks ago, I experienced several failure when trying to install the qt5 port, always with this error message:
copy /y C:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\x86-windows\qtimageformats\lib\cmake\Qt5Gui\Qt5Gui_QWbmpPlugin.cmake C:\Users\Traversaro\Documents\Code\vcpkg2\packages\qt5_x86-windows\lib\cmake\Qt5Gui
        1 file(s) copied.
        cd webp\ && ( if not exist Makefile C:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\x86-windows\qtbase\bin\qmake C:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\plugins\imageformats\webp\webp.pro -o Makefile ) && C:\Users\Traversaro\Documents\Code\vcpkg2\downloads\tools\jom\jom.exe -f Makefile install
        C:\Users\Traversaro\Documents\Code\vcpkg2\downloads\tools\jom\jom.exe -f Makefile.Debug install
        cl -c -nologo -Zc:wchar_t -FS -Zc:strictStrings -Zi -MDd -W3 -w44456 -w44457 -w44458 /Fd..\..\..\..\plugins\imageformats\qwebpd.pdb -DUNICODE -DWIN32 -DQT_NO_EXCEPTIONS -DQT_PLUGIN -DQT_GUI_LIB -DQT_CORE_LIB -DQT_OPENGL_ES_2 -DQT_OPENGL_ES_2_ANGLE -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\plugins\imageformats\webp -I. -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\3rdparty\libwebp -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\3rdparty\libwebp\src -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\3rdparty\libwebp\src\dec -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\3rdparty\libwebp\src\enc -IC:/Users/Traversaro/Documents/Code/vcpkg2/buildtrees/qt5/src/qt-5.7.0/qtimageformats/src/3rdparty/libwebp/src/extra -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\3rdparty\libwebp\src\dsp -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\3rdparty\libwebp\src\mux -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\3rdparty\libwebp\src\utils -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\3rdparty\libwebp\src\webp -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtbase\include -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtbase\include\QtGui -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtbase\include\QtANGLE -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\x86-windows\qtbase\include -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\x86-windows\qtbase\include\QtGui -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtbase\include\QtCore -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\x86-windows\qtbase\include\QtCore -I.moc\debug -IC:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtbase\mkspecs\win32-msvc2015 -Fo.obj\debug\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\3rdparty\libwebp\src\dsp\alpha_processing_mips_dsp_r2.obj C:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\3rdparty\libwebp\src\dsp\alpha_processing_mips_dsp_r2.c
alpha_processing_mips_dsp_r2.c
C:\Users\Traversaro\Documents\Code\vcpkg2\buildtrees\qt5\src\qt-5.7.0\qtimageformats\src\3rdparty\libwebp\src\dsp\alpha_processing_mips_dsp_r2.c : fatal error C1083: Cannot open compiler generated file: '': Invalid argument

In particular it turns out that C1083 can be caused by the [1] "path/filename length limitation of Visual Studio". My  vcpkg directory absolute path is 42 characters long. Moving the vcpkg directory to C:\vcpkg indeed solved the problem. Perhaps this is obvious to experienced Windows developers. but it would be nice to provide a clean error message in this case.
A possible solution is for vcpkg to explicitly support a maximum length of the absolute directory path in which it is installed (checked using Continuous Integration, see [2]) and print a warning if it is installed in a directory whose absolute path is greater then the supported one.
[1] : http://stackoverflow.com/questions/34074925/vs-2015-cannot-open-compiler-generated-file-invalid-argument
[2] : https://github.com/Microsoft/vcpkg/issues/72

For the record, my path to vcpkg was 36 chars, and that's already too big, so this error appears.
And thank you very much for filing this issue! I'd never know what the problem is without this issue.

@ForNeVeR thanks for the info, I updated the title.

While not a direct fix, I've added a check in the portfile to help mitigate this.
As a workaround for those in the future: the subst command seems to work well for me to quickly get a short path.

Hi everyone, this issue should be fixed. Please open a new issue if this is still a problem for you.
Thanks.

Hi @wangli28, which vcpkg commit fixed the issue?

Hi everyone, this issue should be fixed. Please open a new issue if this is still a problem for you.
Thanks.

Hi @LilyWangL , which vcpkg change or commit fixed the issue? Thanks!


User should be directed to download native app (deeplinks)

where and how will user be told to download app
after he signs up
OR before he signs up
will a payment link/invite link redirect the user to download app in case he is on mobile?

this requires integration with Branch deeplinks, because other wise the invite code will be lost
is it safe to use payment link with Branch? since it is no longer private.

@sirpy @tzvister Is this still relevant ?

yes @tzvister that's a product decision

for now: just link Android app in the <meta> tags, so mobile browser supporting that feature will show an generic 'there's mobile app available... view in Google Play' popup

@TomasGonzalez @johnsmith-gooddollar
Need to add some design for this button.

The redirect works properly!
Environment:
DEV Version 1.35.1-7 (2392)
Device:
Samsung S20 FE // Android 11

I've just received the asset for the new app logo. Here it is:

@TomasGonzalez @johnsmith-gooddollar
the issue is not reproduced. The redirect works properly

closed via #3577


Documentation bug for visit

The http://zombie.labnotes.org/api.html page implies that Browser.visit exists as a shorthand constructor+visit.
I was getting method doesn't exist errors, until I realised that the visit() shorthand is actually defined on zombie, not zombie.Browser.

Thanks, fixing and uploading new docs.


Traffic Ops API/GUI configuration of FQ Pacing plugin

This activates a Traffic Server Pacing Plugin (https://github.com/apache/trafficserver/pull/3049). Pacing shortens queuing delays in the network and can reduce congestive losses.
This is an optional plugin, with a maximum rate per-Deliveryservice.

Can one of the admins verify this patch?

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1125/
Test PASSed.

@alficles thanks for the review chris. any other changes you'd like to see before this gets merged?

@limited Nope. I had comments above, but if you're happy with it, it should be fine.

@limited - what types of delivery services does this relate to? You should update the Traffic Portal as well.
There are 4 html forms in TP for a delivery service. One for any_map, dns*, http* and steering*. You should add this field to each form where it applies
https://github.com/apache/incubator-trafficcontrol/tree/master/traffic_portal/app/src/common/modules/form/deliveryService

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1148/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1157/
Test FAILed.

test this please

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1158/
Test FAILed.

@limited - looks good to me from a TP perspective

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1200/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1201/
Test PASSed.

Looks like the test case failed for
``
Use of uninitialized value in string eq at /Users/dricha209/projects/go/src/github.com/apache/incubator-trafficcontrol/traffic_ops/app/lib/UI/DeliveryService.pm line 208.
t/deliveryservice.t .. 38/?
Failed test 'exact match for JSON Pointer "/1/fq_pacing_rate"'
at t/deliveryservice.t line 300.
got: undef
expected: '500000'
Looks like you failed 1 test of 74.
t/deliveryservice.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/74 subtests
Test Summary Report
t/deliveryservice.t (Wstat: 256 Tests: 74 Failed: 1)
Failed test:  55
Non-zero exit status: 1
Files=1, Tests=74,  7 wallclock secs ( 0.03 usr  0.01 sys +  3.15 cusr  0.81 csys =  4.00 CPU)
Result: FAIL```

Ok, looks good all tests pass


TryParse /6

Contributes to https://github.com/dotnet/AspNetCore.Docs/issues/26423
Internal review URL
Moved from #26488

@fiyazbinhasan  take a look at the document:
Public review  of the doc build:

download the HTML files
unzip
view HTML file in a browser. It best to view the doc with the widest window that has no left or right TOC (Table  of contents)
For links outside the doc, remove the review. from URL.

@Rick-Anderson should we add a note like this?

Another way of parsing a string to a type using the model binder is to have one of the following methods,
public static bool TryParse(string value, T out result);
public static bool TryParse(string value, IFormatProvider provider, T out result);
This approach makes sense if you don't want to implement the IParsable<TSelf> interface. The model binder will use reflection and try to parse the supplied string to a type.

Otherwise, it looks good


Provide SOCKS proxy service option instead of full redirect

What would you like the app to enable you to do?
I want to be able to use Outline as a SOCKS proxy. With that, I won't need to redirect all the traffic but application based redirection (or rule-based redirection on the browsers with the help of FoxyProxy-like add-ons)
Describe alternatives you've considered
I'm hosting a custom ShadowSocks server and service at my local PC. Would be great if I could use the Outline for this.

How is this function developed now? I and many people need it very much.
@jigsaw-nora


Popup delay time

Did you check the docs?

[X] I have read all the noice.nvim docs

Is your feature request related to a problem? Please describe.
sometimes Popup disappears too quick
Describe the solution you'd like
Is it possible to increase/decrease delay time of the popup? I know I can run NoiceDismiss to remove it but sometimes it disappears before I finish reading it.
Describe alternatives you've considered
I don't have any alternatives
Additional context
No response

nevermind. The setting I'm looking for is in nvim-notify


HTML

HTML
User Story
As a boot camp student,
I want a Prework Study Guide website,
so that I can review all the information I learned throughout Prework.
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, Git, and JavaScript with associated notes listed

Ticket completed with PR #6


added code comments

This is just the new doc strings generated from  my debug and testing efforts.
Signed-off-by: Art McGee<EMAIL_ADDRESS>

@clusterfudge , @aatchison , @penrods  Please have a look pretty simple.


Cannot open terminal in libraries

Im not able to use the context menu to open terminal in windows libraries, is there a way we could detect for this and redirect to the real folder? This also happends with cmd and regular powershell

item(where=package.exists("WindowsTerminal") title=title.Windows_Terminal tip=tip_run_admin admin=has_admin image='@package.path("WindowsTerminal")\WindowsTerminal.exe' cmd='wt.exe' arg='-d<EMAIL_ADDRESS>

I dealt a lot with libraries, and I found that these are not directories but an xml file (to my surprise)
go to %AppData%\Microsoft\Windows\Libraries - pick and drag the folder into notepad++ or VS Code

I dealt a lot with libraries, and I found that these are not directories but xml files (to my surprise) go to %AppData%\Microsoft\Windows\Libraries - pick and drag the folder into notepad++ or VS Code

Feels like tripping over a boulder


[SPARK-46392][SQL] Push down Cast expression in DSv2

What changes were proposed in this pull request?

Push down Cast expression.
Why are the changes needed?

Push down Cast expression to accelerate computation.
Does this PR introduce any user-facing change?

Considering table blow:
CREATE TABLE `tableA`(
  s string)
PARTITIONED BY (
  `dt` string COMMENT '日期, yyyyMMdd',
  `hour` string COMMENT '小时, HH')

if we execute sql:
select * from tableA where dt=20231212 and hour=22

After V2ScanRelationPushDown Rule been applyed,
Only IsNotNull(dt), IsNotNull(hour) be pushed to datasource, log like this:
Pushing operators to tableA
Pushed Filters: IsNotNull(dt), IsNotNull(hour)
Post-Scan Filters: (cast(dt#520 as int) = 20231212),(cast(hour#521 as int) = 10)

But what we need is all expression: IsNotNull(dt), IsNotNull(hour), EqualTo(dt,20231212), EqualTo(hour,10) should been pushed to dataSource, log like blow:
Pushing operators to tableA
Pushed Filters: IsNotNull(dt), IsNotNull(hour), EqualTo(dt,20231212), EqualTo(hour,10)
Post-Scan Filters:

the root cause is: translateLeafNodeFilter in PushDownUtils  does not handle  Cast expression case
How was this patch tested?

NEW UT
Was this patch authored or co-authored using generative AI tooling?

NO

CREATE TABLE tableA(
  s string)
PARTITIONED BY (
  dt string COMMENT '日期, yyyyMMdd',
  hour string COMMENT '小时, HH')

Could you update your example with a working reproduction? This create table statement is invalid. It partitions on two columns dt and hour that do not exist in the column declaration. And the subsequent select is also invalid.; it's missing a table name.

Could you update your example with a working reproduction? This create table statement is invalid. It partitions on two columns dt and hour that do not exist in the column declaration. And the subsequent select is also invalid.; it's missing a table name.

create table statement:
```CREATE TABLE tableA(
user_id string COMMENT 'from deserializer')
PARTITIONED BY (
dt string COMMENT '日期, yyyyMMdd',
hour string COMMENT '小时, HH')
ROW FORMAT SERDE
'org.apache.paimon.hive.PaimonSerDe'
STORED BY
'org.apache.paimon.hive.PaimonStorageHandler'
WITH SERDEPROPERTIES (
'serialization.format'='1')
LOCATION
'xxxx'
TBLPROPERTIES (
'bucket'='50',
'bucketing_version'='2',
'bukect-key'='user_id',
'file.format'='parquet',
'merge-engine'='partial-update',
'partial-update.ignore-delete'='true',
'primary-key'='user_id',
'transient_lastDdlTime'='1701679855',
'write-only'='false')
It is a Paimon table, but it does not matter.

My apologies. It looks like I made some mistake trying to run a similar CREATE TABLE statement. Your original statement was fine.
By the way, if I want to reproduce this log you shared:

Pushing operators to tableA
Pushed Filters: IsNotNull(dt), IsNotNull(hour)
Post-Scan Filters: (cast(dt#520 as int) = 20231212),(cast(hour#521 as int) = 10)

How do I do that? It's not from the EXPLAIN output, it seems.

How do I do that? It's not from the EXPLAIN output, it seems.

Just run the sql and you will find the log in driver log.

Hmm, I am seeing a different plan:
spark-sql (default)> CREATE TABLE test (
                   >     s string
                   > )
                   > PARTITIONED BY (
                   >   dt string,
                   >   hour string
                   > );
Time taken: 0.222 seconds
spark-sql (default)> explain select * from test where dt=20231212 and hour=22;
== Physical Plan ==
Scan hive spark_catalog.default.test (1)

(1) Scan hive spark_catalog.default.test
Output [3]: [s#0, dt#1, hour#2]
Arguments: [s#0, dt#1, hour#2],
  HiveTableRelation [
    `spark_catalog`.`default`.`test`, org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe,
    Data Cols: [s#0], Partition Cols: [dt#1, hour#2], Pruned Partitions: []
  ], [isnotnull(dt#1), isnotnull(hour#2), (cast(dt#1 as int) = 20231212), (cast(hour#2 as int) = 22)]

And if I try another table, but this time USING parquet, I see PartitionFilters accepts the cast without issue:
spark-sql (default)> CREATE TABLE test (
                   >     s string
                   > )
                   > USING parquet
                   > PARTITIONED BY (
                   >   dt string,
                   >   hour string
                   > );
Time taken: 0.1 seconds
spark-sql (default)> explain select * from test where dt=20231212 and hour=22;
== Physical Plan ==
*(1) ColumnarToRow
+- FileScan parquet spark_catalog.default.test[s#19,dt#20,hour#21] Batched: true, DataFilters: [], Format: Parquet,
  Location: InMemoryFileIndex(0 paths)[],
  PartitionFilters: [isnotnull(dt#20), isnotnull(hour#21), (cast(dt#20 as int) = 20231212), (cast(hour#21 as int) = 22)],
  PushedFilters: [], ReadSchema: struct<s:string>

Anyway, I don't mean to waste your time. I was just trying to reproduce the issue, but it seems there are more details involved that I don't follow.

Anyway, I don't mean to waste your time. I was just trying to reproduce the issue, but it seems there are more details involved that I don't follow.

Thanks for your review, i will task times to describe this issue more details, maybe it take some days.

And if I try another table, but this time USING parquet, I see PartitionFilters accepts the cast without issue:

BTW, What is your Final Physical Plan? is FileSourceScanExec?,  the PR described here is BatchScanExec

I see this if I enable additional logging:
23/12/15 13:09:47 INFO FileSourceScanExec: Planning scan with bin packing, max size: 4194304 bytes, open cost is considered as scanning 4194304 bytes.

I guess I need to change the table format to force a BatchScanExec.

I will close this as it is unreasonable.

I will close this as it is unreasonable.


[WIP] Add support for submitting samples

This fixes issue #6

SonarQube analysis reported 2 issues

 1 critical
 1 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 7 issues

 3 major
 4 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 1 issue

 1 minor

Watch the comments in this conversation to review them.


add custom bot-api-url

In some countries, governments block requests to the telegram url. This PR is necessary to bypass this issue.

Nice contribution, I didn't even think about the fact (Germany is quite free in this case), but in other countries this is a serious issue. I will try to provide an update soon.

@SeppPenner
It was a quite pleasure.
However, I don't know why my name doesn't show up in contributors list, it's not a big deal though.

I have honestly no idea why this is not displayed properly in the contributors section... Maybe because of the merging of the pull request?

I will try something, let's see how this works.

@all-contributors please add @azhdari for new bot api feature

@all-contributors please add @azhdari for code doc

Ok, looks quite good, I would say :D

Thanks a lot @SeppPenner


visible non-narrative anchors in operators page

The problem
In the operators page a lot of anchors to individual operator section are visible, non-narrative and slightly offset from the section's title.
See as examples:

https://docs.raku.org/language/operators#index-entry-Negated_boolean_context_operator
https://docs.raku.org/language/operators#index-entry-Negated_boolean_context_operator
https://docs.raku.org/language/operators#index-entry-Addition_operator
...

This should probably be fixed, see https://github.com/Raku/doc/commit/bc233e2a3c95b18afdc044bff869bb086ebf0a8b#commitcomment-37190047
Suggestions

Should the anchors be made invisible and stuck to the sections' title, as in https://docs.raku.org/language/operators#index-entry-prefix_decrement_operator ?

Should the non-narrative description of the operators be kept, as in https://docs.raku.org/language/operators#index-entry-Division_operator ?

@stoned This Issue was just transferred to the doc-website repo, which deals with the rendering of documentation sources. I have just read the issue for the first time, and I do not understand the issue. The documentation sources are now rendered by Raku::Pod::Rendered rather than Pod::To::HTML and Documentable.
The issue appears to be related to X<> instructions. This sort of markup was used originally to create anchors that were used in Table of Contents and for search purposes. However, X<> was intended to create Indexes or Glossaries.

@coke It seems to me that this is an issue with an older way of rendering RakuDoc to HTML and is no longer a problem. Without some more explanation as to why it might still be relevant, I propose closing the thread.


Update to upstream PyTeal (TEAL 5)

Is your feature request related to a problem? Please describe.
Algob is still relying on PyTeal w/ TEAL4 support, limiting developers access to new TEAL versions. PyTeal added support for the TEAL 5 release a few weeks ago
Describe the solution you'd like
Update algob dependencies and runtime to support upstream PyTeal
Additional context

We completed the update for TEALv4 last week (together with tests).  It's in develop branch. It's going to be released this week.

is there an approximate date for TEAL v5?


Make the serach pod text box more reactive

Make the serach pod text box more reactive

https://github.com/freddycoder/AzureDevOpsTeamMembersVelocity/commit/a1ac6e5ea08ce051d06a3bd2500f16917c223aed


A11y on Clarity Datagrids

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?
Current Behavior enables a11y on Clarity Datagrids, allowing for keyboard resizability on Datagrid columns, along with screen reading functionality triggered on column resizing. As of now, we consider the feature to be in beta, but with time we can always improve the feature and the functionality overall.
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information
Feature was also a part of the Borathon Contest.

Hi @aliitani, thanks a lot for this contribution. This is a really cool feature to have in Datagrid. I think it's worth bringing our Clarity designers and a11y experts' attention to this PR and discuss how it solves the problem. But the first thing that grabbed my attention in this PR is that you are incorporating aria-live to announce the updated widths of columns after resizing. What was the reason for that? The reason why I am asking this is that I see this feature as a convenience feature for only sighted keyboard users.

Hi @Shijir, thanks for giving the PR a look! That was my first impression as well. However, this feature was worked on for Borathon, and since this year it was a11y focused, we wanted to make sure we touched on all aspects of a11y (or possibly majority of them). I can factor it out to limit the scope of the PR?

Hi @aliitani, thank you. I had to consult with @chlane on this PR. When I went over it, there were quite a few things to update and reorganize. I hope you wouldn't mind following through them.

Hi Shijir - Thanks for taking the time! I updated the pull request with the changes you went over.

Hi Shijir - I went over the changes you point out

Hi @aliitani, thank you for the changes. I will add some code refactoring on top of your changes.

Hi @Shijir, thanks for considering my feat

I'm going to close in favor of #4535, which incorporates this work. Thank you @aliitani!


Update JS package dependency versions,

Update web/package.json, examples/web/rollup & webpack package.json.
Update web/Cargo.toml
Specify "type": "module" to package.json in web/ and examples/ rollup

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 98.964%

Totals

Change from base Build<PHONE_NUMBER>:
0.02%

Covered Lines:
44043

Relevant Lines:
44504

💛  - Coveralls


Can't add dot "." symbol to keybind

I used both . and also Period, and even Dot. None of them works
cm.setOption('extraKeys', {
   'Ctrl-.': 'toggleComment'
});

When I changed the . to other characters (eg 'A'), it worked as expected. So the problem is the dot.
Tested in chrome, edge, and using version 5.62.

It may be that your OS or browser is capturing ctrl-. presses? On mine (Linux) they start some kind of input composition that I wasn't aware of before, and also aren't delivered to the page script.

Just figured it out. My adblocker extension is being toggled for ctrl+.


New SPARK course, format reword, day 2

Continuation of the work done in #298, itself a follow up of #295
This improves formating, and add dfn for chapters 6-10 of the new SPARK course

looks like the same changes as in the other patch, I'm confused...

Because it's not done and pushed yet ;)


Fix the duplicated key warning

lib/twitter/json_stream.rb:27: warning: duplicated key at line 30 ignored: :path

I have no idea about that two :path keys exist here still now. Is my PR mergeable?

Jep, this looks good - I saw a different PR fixing the same warning, so closing this out.
Thank you for your contribution, though :+1:

OK. I read #41. Thanks to fix this warning :smiley:


Fix struct the Router parameter for get URLRequest

Resolves #5

Codecov Report

Merging #6 (1e4429d) into main (2264379) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   93.10%   93.12%   +0.01%
==========================================
  Files           8        8
  Lines         406      407       +1
==========================================
+ Hits          378      379       +1
  Misses         28       28

Impacted Files
Coverage Δ

Sources/APIRouter/RouterBuilder.swift
88.37% <100.00%> (+0.27%)
:arrow_up:

Tests/APIRouterTests/RouterBuilderTests.swift
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Regarding the missing fileds and submit buutons

Hi ! Good day !
when i run this project ,
in most of the sections im unable to find the fields in all modules and the submit buttons !
can you help on this?

hi could you plz tell me which IDE you use to run this project

i have used eclipse for enterprise java developers. works on that

hi could you plz tell me which IDE you use to run this project


License?

Hi,
great components.
Under what license do you release them?
Can they be used in commercial applications?
Thanks

you can use in commercial application

I hope that as many people as possible can benefit from this project, but I don't know which license is the best choice, I just choose Apache License, Version 2.0, can anybody give me some advice?

I usually go for the MIT license but I am not sure what's the difference with Apache. With MIT, the code can be used in any type of applications as long as they mention the original author.
See this page: https://choosealicense.com

The license changed to MIT License


Feature: detached session (configuration plus command line override)

This is based on a similar pull request by user @mvaraga.
This adds the option for creating a session with tmuxinator without attaching to this session. The user can configure detaching in the session definition and later override the behavior on the command line with tmuxinator start --attach=false ... or tmuxinator start --attach=true ..., with true being the default.
The command line always overrides the yaml file.

Changes Unknown when pulling 1fd25cd2d8b8b0e5204a36995d9825a96c35ae44 on geggo98:feature/detached-session into ** on tmuxinator:master**.

Changes Unknown when pulling 1fd25cd2d8b8b0e5204a36995d9825a96c35ae44 on geggo98:feature/detached-session into ** on tmuxinator:master**.

Changes Unknown when pulling 1fd25cd2d8b8b0e5204a36995d9825a96c35ae44 on geggo98:feature/detached-session into ** on tmuxinator:master**.

If this could be rebased ontop of #293 for the command line options that'd be great.

I will clean up the failed test cases later this week. I already resolved all merge conflicts.

Thanks!

@Soliah Would you mind to release a new gem version including this PR?


Update libraries

Update pydantic-xml and fastapi versions
Update usage of pydantic-xml components

The target branch was changed to perform some adjustments before making a new release available


Ingress does not support Vault EC roles

Describe the bug:
Creating an Ingress on Kubernetes 1.21.3 with cert-manager 1.4.0 configured with Vault PKI and a role with default EC key fails on error: role requires keys of type ec. There is no documented Ingress annotation for customizing the key type and properties, for example, privateKey.algorithm and privateKey.size.
Expected behaviour:
Ingress should be created and customizable with key details.
Steps to reproduce the bug:

Create a Vault role with EC key type
Create a ClusterIssuer referencing the role
Create an Ingress object referencing the ClusterIssuer

Environment details::

Kubernetes version: 1.21.3
Cloud-provider/provisioner: none
cert-manager version:  1.4.0
Install method: helm

/kind bug

cert-manager supports ECDSA private keys. You will have to create the Certificate object yourself rather than have cert-manager create a default one based off your Ingress annotations. See the Certificate Documentation. After creating a Certificate specced to your liking, update the TLS secret reference in the Ingress to point to the secret created by cert-manager.
/triage support
/remove-kind bug
/kind feature

Creating a Certificate works as expected, however, the ingress-shim doesn't support EC-backed issuers without having the option to specify the key attributes using annotations.
Is this planned?
Maybe it should be documented as a known limitation on: https://cert-manager.io/docs/usage/ingress/


Toggling of 24-hour format impacts how "requiredInstallationDate" string value is interpreted if your region is set to United Kingdom

Curious to see if others are seeing this and able to reproduce this.
We've noticed that in some instances computers are seeing "Days Remaining To Update" set to 0. Our requiredInstallationDate is set to the following which is still in the future:
<key>requiredInstallationDate</key>
<string>2023-04-21T18:00:00</string>

To reproduce:

Go to System Settings > General > Language & Region > Region and set it to "United Kingdom".
Go to System Settings > General > Date & Time > 24-hour time: turn it on (this is the default in the UK)
Launch Nudge. Days Remaining To Update should show up correctly (e.g. 9 days at the time of this comment)
Go to System Settings > General > Date & Time > 24-hour time: turn it off
Re-launch Nudge. Days Remaining To Update shows up incorrectly with 0 days
Go to System Settings > General > Language & Region > Region and set it to "United States".
Re-launch Nudge. Days Remaining To Update shows up incorrectly with 0 days
Go to System Settings > General > Date & Time > 24-hour time: turn it on
Re-launch Nudge. Days Remaining To Update shows up incorrectly with 0 days

Note: I'm not sure why but if your Region is already set to "United States and you simply toggle 24-hour time on and off, you don't see an issue at all. The issue seems to only manifest when you set the region to "United Kingdom". It's possible it may also manifest if you start with other regions as well.
Further investigating reveals the following when you run the command:
defaults read /Library/Managed\ Preferences/com.github.macadmins.Nudge

When 24-hour time is disabled: requiredInstallationDate = "2023-04-21 6:00:00 pm +0000";
When 24-hour time is enabled: requiredInstallationDate = "2023-04-21 18:00:00 +0000";

If I change the requiredInstallationDate value from a string to a date type, the issue isn't seen:
<key>requiredInstallationDate</key>
<date>2023-04-21T18:00:00Z</date>

Running the following command:
defaults read /Library/Managed\ Preferences/com.github.macadmins.Nudge

When 24-hour time is disabled: requiredInstallationDate = "2023-04-21 6:00:00 PM +0000";
When 24-hour time is enabled: requiredInstallationDate = "2023-04-21 18:00:00 +0000";

I am aware that there have been updates to documentation that suggest support for string values in #463 but this is a really bizarre issue. Curious to see if other people have seen similar behavior.
Sample Profile:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>userInterface</key>
	<dict>
		<key>fallbackLanguage</key>
		<string>en</string>
		<key>forceFallbackLanguage</key>
		<true/>
		<key>iconDarkPath</key>
		<string>/path/to/image.png</string>
		<key>iconLightPath</key>
		<string>/path/to/image.png</string>
		<key>showDeferralCount</key>
		<true/>
		<key>simpleMode</key>
		<false/>
		<key>singleQuitButton</key>
		<false/>
		<key>updateElements</key>
		<array>
			<dict>
				<key>_language</key>
				<string>en</string>
				<key>actionButtonText</key>
				<string>Update Mac</string>
				<key>customDeferralButtonText</key>
				<string>Custom</string>
				<key>customDeferralDropdownText</key>
				<string>Defer</string>
				<key>informationButtonText</key>
				<string>More Information</string>
				<key>mainContentHeader</key>
				<string>You will need to update your Mac</string>
				<key>mainContentNote</key>
				<string>Friendly reminder from #help</string>
				<key>mainContentSubHeader</key>
				<string>Updates can take around 30-45 minutes to complete</string>
				<key>mainContentText</key>
				<string>There is a software update available for your Mac which needs to be installed. Please click "Update Mac" to initiate the update.\n\nYou may also install this macOS software update at any time by navigating to:\n\nApple menu > System Settings > General > Software Update</string>
				<key>mainHeader</key>
				<string>macOS Update Required</string>
				<key>oneDayDeferralButtonText</key>
				<string>One Day</string>
				<key>oneHourDeferralButtonText</key>
				<string>One Hour</string>
				<key>primaryQuitButtonText</key>
				<string>Update Later</string>
				<key>secondaryQuitButtonText</key>
				<string>I understand</string>
				<key>subHeader</key>
				<string></string>
			</dict>
		</array>
	</dict>
	<key>optionalFeatures</key>
	<dict>
		<key>disableSoftwareUpdateWorkflow</key>
		<true/>
		<key>attemptToFetchMajorUpgrade</key>
		<false/>
		<key>aggressiveUserExperience</key>
		<false/>
		<key>aggressiveUserFullScreenExperience</key>
		<false/>
	</dict>
	<key>osVersionRequirements</key>
	<array>
		<dict>
			<key>aboutUpdateURL</key>
			<string>https://support.apple.com/HT201541</string>
			<key>requiredInstallationDate</key>
			<string>2023-04-21T18:00:00</string>
			<key>requiredMinimumOSVersion</key>
			<string>13.3.1</string>
			<key>targetedOSVersionsRule</key>
			<string>default</string>
		</dict>
	</array>
	<key>userExperience</key>
	<dict>
		<key>randomDelay</key>
		<false/>
		<key>elapsedRefreshCycle</key>
		<string>7200</string>
		<key>imminentRefreshCycle</key>
		<string>7200</string>
	</dict>
</dict>
</plist>

This ultimately boils down to me having to write conversion code that must be incomplete for strings vs the true object type I first designed Nudge around.
Does it work when you use a json?

I have the same issue on a users machine. He has the region set to Sweden (that uses 24h as standard) and has the clock set to 12h mode.
We use the Custom json schema in Jamf to make the setup of the configuration profile easy. Is there a way to change that schema to use date instead of string? Tried to manualy change to date in the schema but then it can't read the schema..

Nope. JAMF json schema doesn't support date only string. Because of jamf's limitations I had to write special code.
If you need to handle this, you need to deploy a custom mdm profile that doesn't have jamf's limitations.

I had at least 2 users with time zone set to UK but time format not 24h.
I just moved from a custom schema CP to a plain XML one, to change the tags from  to .

I'm pretty sure I've resolved this issue by adding proper support for local installation times. Remove the Z and try on Nudge 2.0. Closing this.


Update the derive crate

I just encountered an issue where the heapSizeOf derive wasn't able to parse dyn Trait in a struct, so I thought I'd make a PR to update heapsize_derive to use the latest versions of syn and quote... Unfortunately almost all of syn's API has changed since the custom derive was originally written, so the simple cargo update turned into a rewrite :disappointed:
We'll probably want to test this PR against a large-ish codebase that already uses heapsize to make sure I didn't accidentally introduce any regressions.

This change is

When trying to run the tests on my machine I encountered some funny behaviour with Box<T>. Does anyone know why these tests might be failing?
#[test]
fn sanity_check_heapsize_works_as_expected() {
    assert_eq!(Box::new(1_u8).heap_size_of_children(), mem::size_of::<u8>());
    assert_eq!([Box::new(1), Box::new(2)].heap_size_of_children(), 2 * 4);
}

What is the test failure message?

This is what I'm seeing when running the tests:
---- sanity_check_heapsize_works_as_expected stdout ----
thread 'sanity_check_heapsize_works_as_expected' panicked at 'assertion failed: `(left == right)`
  left: `8`,
 right: `1`', test.rs:21:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- tuple_struct stdout ----
thread 'tuple_struct' panicked at 'assertion failed: `(left == right)`
  left: `24`,
 right: `9`', test.rs:13:5

---- normal_struct stdout ----
thread 'normal_struct' panicked at 'assertion failed: `(left == right)`
  left: `32`,
 right: `17`', test.rs:43:5

@jdm  It looks like Box::new(1_u8).heap_size_of_children() is returning the size of the box (i.e. the 64-bit pointer) instead of the size of the u8.

@jdm I made appveyor test the heapsize_derive crate and apparently the sanity test is now passing on Windows.
Perhaps this is something particular to whatever allocator is being used on my machine? Apparently the amount of heap memory used by a Box<[u8; 10]> is zero...
#[test]
fn sanity_check_heapsize_works_as_expected() {
    assert_eq!(
        Box::new([1_u8; 10]).heap_size_of_children(),
        10 * mem::size_of::<u8>()
    );
}

---- sanity_check_heapsize_works_as_expected stdout ----
thread 'sanity_check_heapsize_works_as_expected' panicked at 'assertion failed: `(left == right)`
  left: `0`,
 right: `10`', test.rs:21:5

It looks like the CI failure is because the top-level heapsize crate contains tests which depend on nightly APIs that no longer exist (in particular, the allocator_api feature which has been moved around).


Custom icons have a small stroke applied to them

Bug Report
Ionic Info
Ionic:

   ionic (Ionic CLI)             : 4.4.0 (C:\Users\Brane\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework               : @ionic/angular 4.0.0-beta.16
   @angular-devkit/build-angular : 0.10.6
   @angular-devkit/schematics    : 7.0.6
   @angular/cli                  : 7.0.6
   @ionic/angular-toolkit        : 1.2.0

System:

   NodeJS : v10.10.0 (C:\Program Files\nodejs\node.exe)
   npm    : 6.4.1
   OS     : Windows 10

Describe the Bug
When rendering a custom icon via <ion-icon src="/path/to/svg.svg"></ion-icon> a noticeble stroke gets applied to the svg icon. This makes the icon not appear as intended and even has some undesired side effects on certain icons as in the case with the done_all material design icon explained below.
Steps to Reproduce

Generate a new ionic project ionic start iconBug blank --type="angular"
Create a new svg file src/assets/icon/done_all.svg with the following contents

<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24"><path d="M0 0h24v24H0z" fill="none"/><path d="M18 7l-1.41-1.41-6.34 6.34 1.41 1.41L18 7zm4.24-1.41L11.66 16.17 7.48 12l-1.41 1.41L11.66 19l12-12-1.42-1.41zM.41 13.41L6 19l1.41-1.41L1.83 12 .41 13.41z"/></svg>

In src/app/home/home.page.html replace the contents of ion-content with:
<ion-icon src="/assets/icon/done_all.svg"></ion-icon>
Run ionic serve

You should see the icon rendered with a thin border around it. As well the icon itself has a little bit of stroke added to it as well.
Expected Behavior
The icon should not have this stroke added. ion-icon should render the svg as it is suppose to be. In this case the icon in question is the done_all icon from Google's Material Design Icons. The icon should appear as it does on google's site; with no border around the icon or added stroke.
Additional Info
This is currently happening with all material design icon svg files. When inspecting the element in devtools the stroke is being set in teh shadow dom as follows:
.icon-inner, svg {
  display: block;
  fill: currentColor;
  stroke: currentColor;
  height: 100%;
  width: 100%;
}

I've implemented a workaround where I add style="stroke:none" or stroke-width="0" to the svg element directly. This works, but I feel like the default should be for ionic to leave the svg as is and not change its stroke.

Thanks for the issue! We'll look into this.
Note to team: this is technically an issue in the ionicons repository but I didn't want it to get lost over there.
Here is the code in question: https://github.com/ionic-team/ionicons/blob/master/src/components/icon/icon.css#L28-L29

Hey,
What's the actual workaround for this ? Am I suppose to add (style = "stroke:none")  to the ion-icon ?
Why can't I override .icon-inner, svg in the global.scss ?

Hi @brane53 ,
Can you explain how you implemented the workaround. I'm struggling to understand how shadow dom is working, but as said on google docs, outside style applied to an element should override shadow DOM, still I can't find the propoer selector to do this, I tried to appy it to svg, .icon-inner, ::slotted(*)... etc nothing works except when I manually disable the stroke property in devTools.
How are you doing it ?
Thanks a lot

@brandyscarney anything new about this issue ?

@Mazus
if you have direct access to the svg files, a current workaround would be adding a style atrribute the the svg image:
for example turn
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24">
<path fill="#FFD64F" fill-rule="nonzero" d="M8.593 8.138l2.274-6.442.005-.014a1.206 1.206 0 0 1 2.264.014l2.272 6.442h6.386a1.206 1.206 0 0 1 .775 2.13l-5.383 4.463 2.257 6.778a1.206 1.206 0 0 1-1.858 1.353L12 18.765l-5.592 4.102a1.206 1.206 0 0 1-1.85-1.358l2.257-6.778-5.393-4.47a1.206 1.206 0 0 1 .784-2.123h6.387z"/>
</svg>

to
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" style="stroke: none !important;">
    <path fill="#FFD64F" fill-rule="nonzero" d="M8.593 8.138l2.274-6.442.005-.014a1.206 1.206 0 0 1 2.264.014l2.272 6.442h6.386a1.206 1.206 0 0 1 .775 2.13l-5.383 4.463 2.257 6.778a1.206 1.206 0 0 1-1.858 1.353L12 18.765l-5.592 4.102a1.206 1.206 0 0 1-1.85-1.358l2.257-6.778-5.393-4.47a1.206 1.206 0 0 1 .784-2.123h6.387z"/>
</svg>

@Mazus
Appologies for the late reply. I added the style directly to the svg file as @kaspaddy suggests. Ionic is going to pull in that svg file into the ion-icon element's shadow dom at which point there is no way to change the style via css unless ionic exposes a custom css variable. I thought that this was close to being implemented though. There's a pull request by @btsiders to add a css variable, but nothing has been done about it. ionic-team/ionicons#643

@brane53 @kaspaddy Thanks a lot, that works perfectly fine for now.
Until the css variable is properly merged in Ionic, that will do :)

Issue persists on most custom svg I have encountered still.

Here's an Angular directive to fix the issue until the Ionic team merges a bugfix.
removeSvgStroke directive
import { isPlatformBrowser } from '@angular/common';
import {
  AfterViewInit,
  Directive,
  ElementRef,
  Inject,
  OnDestroy,
  PLATFORM_ID,
} from '@angular/core';

@Directive({
  selector: 'ion-icon[src][removeSvgStroke]',
})
export class RemoveIonIconSvgStrokeDirective
implements AfterViewInit, OnDestroy {
  private _noStrokeStyles?: HTMLStyleElement;
  private get ionIconShadowDom() {
    return (this.element.nativeElement as HTMLElement).shadowRoot;
  }
  private isBrowser: boolean;
  private get noStrokeStyles() {
    if (!this._noStrokeStyles) {
      this._noStrokeStyles = document.createElement('style');
      this._noStrokeStyles.innerHTML = `
      svg,
      .icon-inner {
        stroke: initial;
      }`;
    }

    return this._noStrokeStyles;
  }

  constructor(
    private element: ElementRef,
    @Inject(PLATFORM_ID) platformId: string,
  ) {
    this.isBrowser = isPlatformBrowser(platformId);
  }

  ngAfterViewInit() {
    if (this.isBrowser) {
      this.applyNoStrokeStyles();
    }
  }

  ngOnDestroy() {
    if (this.isBrowser) {
      this.removeNoStrokeStyles();
    }
  }

  private applyNoStrokeStyles() {
    // We have to wait for an event loop tick before the Ionic Icon shadow DOM
    // becomes accessible
    return Promise.resolve()
      .then(() => this.ionIconShadowDom.appendChild(this.noStrokeStyles));
  }

  private removeNoStrokeStyles() {
    this.ionIconShadowDom.removeChild(this.noStrokeStyles);
  }
}

Example usage
<ion-icon src="/assets/my-icon-svg" removeSvgStroke></ion-icon>

Here's an Angular directive to fix the issue until the Ionic team merges a bugfix.
removeSvgStroke directive
import { isPlatformBrowser } from '@angular/common';
import {
  AfterViewInit,
  Directive,
  ElementRef,
  Inject,
  OnDestroy,
  PLATFORM_ID,
} from '@angular/core';

@Directive({
  selector: 'ion-icon[src][removeSvgStroke]',
})
export class RemoveIonIconSvgStrokeDirective
implements AfterViewInit, OnDestroy {
  private _noStrokeStyles?: HTMLStyleElement;
  private get ionIconShadowDom() {
    return (this.element.nativeElement as HTMLElement).shadowRoot;
  }
  private isBrowser: boolean;
  private get noStrokeStyles() {
    if (!this._noStrokeStyles) {
      this._noStrokeStyles = document.createElement('style');
      this._noStrokeStyles.innerHTML = `
      svg,
      .icon-inner {
        stroke: initial;
      }`;
    }

    return this._noStrokeStyles;
  }

  constructor(
    private element: ElementRef,
    @Inject(PLATFORM_ID) platformId: string,
  ) {
    this.isBrowser = isPlatformBrowser(platformId);
  }

  ngAfterViewInit() {
    if (this.isBrowser) {
      this.applyNoStrokeStyles();
    }
  }

  ngOnDestroy() {
    if (this.isBrowser) {
      this.removeNoStrokeStyles();
    }
  }

  private applyNoStrokeStyles() {
    // We have to wait for an event loop tick before the Ionic Icon shadow DOM
    // becomes accessible
    return Promise.resolve()
      .then(() => this.ionIconShadowDom.appendChild(this.noStrokeStyles));
  }

  private removeNoStrokeStyles() {
    this.ionIconShadowDom.removeChild(this.noStrokeStyles);
  }
}

Example usage
<ion-icon src="/assets/my-icon.svg" removeSvgStroke></ion-icon>

i have an error in the directive spec.ts file, about not passing arguments to the directive, how could i fix it?

i have an error in the directive spec.ts file, about not passing arguments to the directive, how could i fix it?

What does your spec look like?

i have an error in the directive spec.ts file, about not passing arguments to the directive, how could i fix it?

What does your spec look like?

import { RemoveIonIconSvgStrokeDirective } from './remove-ion-icon-svg-stroke.directive'; describe('RemoveIonIconSvgStrokeDirective', () => {   it('should create an instance', () => {     const directive = new RemoveIonIconSvgStrokeDirective();     expect(directive).toBeTruthy();   }); });

@javiersoto15 The directive has two dependencies, seen in its constructor:

ElementRef from @angular/core
PLATFORM_ID from @angular/core

To test it, you should create a test host component with this template
<ion-icon src="/assets/my-icon.svg" removeSvgStroke></ion-icon>

then declare it in the testing module and finally create a component fixture. This will set up the dependencies for you. However, it only does DOM manipulation on the browser platform. Not sure what platform is used in tests. Maybe it depends on whether you use Karma or a browserless environment like Jest or Mocha.

@javiersoto15 The directive has two dependencies, seen in its constructor:

ElementRef from @angular/core
PLATFORM_ID from @angular/core

In your test case, you do not pass any arguments to its constructor.
To test it, you should create a test host component with this template
<ion-icon src="/assets/my-icon.svg" removeSvgStroke></ion-icon>

then declare it in the testing module and finally create a component fixture. This will set up the dependencies for you. However, it only does DOM manipulation on the browser platform. Not sure what platform is used in tests. Maybe it depends on whether you use Karma or a browserless environment like Jest or Mocha.

I applied the directive but it does not seem to action any change in my svg, i have applied it to difference but there is no difference

Which version of Ionic do you use? This is for Ionic v4.x.

Thank you for the easy-to-follow steps to reproduce this! I've created two pull requests for this:

Ionicons: https://github.com/ionic-team/ionicons/pull/688
Ionic: https://github.com/ionic-team/ionic/pull/18241

I also published an Ionicons dev build which I am currently testing<EMAIL_ADDRESS>So far the colors are all looking fine in Ionic.
If anyone would like to test this out please do so and let me know if you see any problems with this approach, thank you!

I released a dev build of Ionic with this fix in if anyone would like to try it:
4.5.0-dev.201905101544.3041241

The fix will be in the next release. Thanks again for reporting! 🙂


solid example ssg: question about string generation.

I need the SSG generated string of {tmp} the same as that of {"abc"} to do string replacement, like replacing abc to ABC, but js keeps {tmp} to be abc.
Is it possible to do that?
import { Component } from "solid-js";
import { Counter } from "./Counter";

let tmp = "abc"

const Page: Component = () => {
  return (
    <>

Welcome

        This page is: {tmp} {"abc"}

Rendered to HTML.

            Interactive. <Counter />

    </>
  );
};

I'm not sure I'm following what are you trying to achieve here? What is your overall goal?


Injected path cannot be marked as external: Vite 4.0.4

I added the lib using yarn and updated vite.config.js as instructed, but I get this error when I run the server:
✘ [ERROR] The injected path "myproj/node_modules/node-stdlib-browser/helpers/esbuild/shim.js" cannot be marked as external

Build failed with 1 error:
error: The injected path "myproj/node_modules/node-stdlib-browser/helpers/esbuild/shim.js" cannot be marked as external

I'm using
Vite: 4.0.4
Node: 18.12.1
Yarn: 1.22.19

Same as this issue from a similar lib that uses node-stdlib-browser

@saravanabalagi this is fixed in v0.7.0.


Pipeline reports 'pipeline contains no child elements capable of processing' if a reader is placed before a parser

I can't reproduce this error.


Test all flight modes with a quad

We need to verify that none of the fixed wing fixes did create regressions for multicopters.

@LorenzMeier I can do this as soon as I have my quad back.

@sjwilks Do you have bandwidth to test this? ;-)

He's going to use your quad ;)

@AndreasAntener Sure :-D

Today should work.
On Mon, 22 Jun 2015 22:35 Roman Bapst<EMAIL_ADDRESS>wrote:

@AndreasAntener https://github.com/AndreasAntener Sure :-D
—
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/issues/2415#issuecomment-114255059.

@sjwilks Something to do during food-coma maybe? 8)

We tested both v1 and v2 setups today. Ada will post the results tonight.
In general all good.
On Tue, 23 Jun 2015 13:19 Lorenz Meier<EMAIL_ADDRESS>wrote:

@sjwilks https://github.com/sjwilks Something to do during food-coma
maybe? 8)
—
Reply to this email directly or view it on GitHub
https://github.com/PX4/Firmware/issues/2415#issuecomment-114447859.

Test report is submitted, just missing the F450 logs :) (btw, my qav didn't log half the flights.. missing the mission and the cough flip)