How to build the docker image

I had met the below question while exec the cmd "make -C docker release_build" with GPUs A800 and L40s.

@LeoCeasar  Can you share the Operating System and CUDA version?

@juney-nvidia  cuda and nvidia version like this

System version:
<img width="555" alt="image"  #src="https://github.com/NVIDIA/TensorRT-LLM/assets/24872184/d492af57-e691-4c4a-aa7b-473a47930f1b">

Could you please share a complete log like this? Thanks!

how can I get the log file like this ?

@Shixiaowei02
make: Entering directory '/data1/LLM/tmp/TensorRT-LLM/docker'
Building docker image: tensorrt_llm:latest
DOCKER_BUILDKIT=1 docker build --pull
--progress auto
--build-arg BASE_IMAGE=nvcr.io/nvidia/pytorch
--build-arg BASE_TAG=23.08-py3
--build-arg BUILD_WHEEL_ARGS="--clean --trt_root /usr/local/tensorrt"
--build-arg TORCH_INSTALL_TYPE="skip"

--file Dockerfile.multi
--tag tensorrt_llm:latest
..
[+] Building 1464.7s (26/31)                                                                        docker:default
=> [internal] load build definition from Dockerfile.multi                                                    0.0s
=> => transferring dockerfile: 1.78kB                                                                        0.0s
=> [internal] load .dockerignore                                                                             0.0s
=> => transferring context: 233B                                                                             0.0s
=> [internal] load metadata for nvcr.io/nvidia/pytorch:23.08-py3                                             1.8s
=> [auth] nvidia/pytorch:pull,push token for nvcr.io                                                         0.0s
=> [internal] load build context                                                                             0.2s
=> => transferring context: 647.00kB                                                                         0.2s
=> [base 1/1] FROM nvcr.io/nvidia/pytorch:23.08-py3@sha256:12a39f22d6e3a3cfcb285a238b6219475181672ff41a557a  0.0s
=> CACHED [devel  1/10] COPY docker/common/install_base.sh install_base.sh                                   0.0s
=> CACHED [devel  2/10] RUN bash ./install_base.sh && rm install_base.sh                                     0.0s
=> CACHED [devel  3/10] COPY docker/common/install_cmake.sh install_cmake.sh                                 0.0s
=> CACHED [devel  4/10] RUN bash ./install_cmake.sh && rm install_cmake.sh                                   0.0s
=> CACHED [devel  5/10] COPY docker/common/install_tensorrt.sh install_tensorrt.sh                           0.0s
=> CACHED [devel  6/10] RUN bash ./install_tensorrt.sh && rm install_tensorrt.sh                             0.0s
=> CACHED [devel  7/10] COPY docker/common/install_polygraphy.sh install_polygraphy.sh                       0.0s
=> CACHED [devel  8/10] RUN bash ./install_polygraphy.sh && rm install_polygraphy.sh                         0.0s
=> CACHED [devel  9/10] COPY docker/common/install_pytorch.sh install_pytorch.sh                             0.0s
=> CACHED [devel 10/10] RUN bash ./install_pytorch.sh skip && rm install_pytorch.sh                          0.0s
=> CACHED [release 1/6] WORKDIR /app/tensorrt_llm                                                            0.0s
=> CACHED [wheel 1/9] WORKDIR /src/tensorrt_llm                                                              0.0s
=> CACHED [wheel 2/9] COPY benchmarks benchmarks                                                             0.0s
=> CACHED [wheel 3/9] COPY cpp cpp                                                                           0.0s
=> CACHED [wheel 4/9] COPY benchmarks benchmarks                                                             0.0s
=> CACHED [wheel 5/9] COPY scripts scripts                                                                   0.0s
=> CACHED [wheel 6/9] COPY tensorrt_llm tensorrt_llm                                                         0.0s
=> CACHED [wheel 7/9] COPY 3rdparty 3rdparty                                                                 0.0s
=> CACHED [wheel 8/9] COPY setup.py requirements.txt ./                                                      0.0s
=> ERROR [wheel 9/9] RUN python3 scripts/build_wheel.py --clean --trt_root /usr/local/tensorrt            1462.6s

[wheel 9/9] RUN python3 scripts/build_wheel.py --clean --trt_root /usr/local/tensorrt:
0.607 Looking in indexes: https://pypi.org/simple, https://pypi.ngc.nvidia.com, https://pypi.ngc.nvidia.com
3.170 Collecting build (from -r requirements.txt (line 1))
3.170   Obtaining dependency information for build from https://files.pythonhosted.org/packages/93/dd/b464b728b866aaa62785a609e0dd8c72201d62c5f7c53e7c20f4dceb085f/build-1.0.3-py3-none-any.whl.metadata
4.146   Downloading build-1.0.3-py3-none-any.whl.metadata (4.2 kB)
4.148 Requirement already satisfied: torch in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 2)) (2.1.0a0+29c30b1)
5.164 Collecting transformers==4.31.0 (from -r requirements.txt (line 3))
5.164   Obtaining dependency information for transformers==4.31.0 from https://files.pythonhosted.org/packages/21/02/ae8e595f45b6c8edee07913892b3b41f5f5f273962ad98851dc6a564bbb9/transformers-4.31.0-py3-none-any.whl.metadata
5.465   Downloading transformers-4.31.0-py3-none-any.whl.metadata (116 kB)
6.828      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 116.9/116.9 kB 80.7 kB/s eta 0:00:00
8.203 Collecting diffusers==0.15.0 (from -r requirements.txt (line 4))
8.510   Downloading diffusers-0.15.0-py3-none-any.whl (851 kB)
62.08      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 851.8/851.8 kB 15.2 kB/s eta 0:00:00
63.35 Collecting accelerate==0.20.3 (from -r requirements.txt (line 5))
63.35   Obtaining dependency information for accelerate==0.20.3 from https://files.pythonhosted.org/packages/10/d3/5382aa337d3e67214003a17b06bfc07cf0334356b4e8aaf3b12b0d38c83f/accelerate-0.20.3-py3-none-any.whl.metadata
63.61   Downloading accelerate-0.20.3-py3-none-any.whl.metadata (17 kB)
64.74 Collecting colored (from -r requirements.txt (line 6))
64.74   Obtaining dependency information for colored from https://files.pythonhosted.org/packages/6f/0d/a10351ef1a98e0b03d66887ec2d87c261f9a0fbff8f2bdb75614cc0a2850/colored-2.2.3-py3-none-any.whl.metadata
65.00   Downloading colored-2.2.3-py3-none-any.whl.metadata (3.6 kB)
65.03 Requirement already satisfied: polygraphy in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 7)) (0.48.1)
65.03 Requirement already satisfied: onnx>=1.12.0 in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 8)) (1.14.0)
65.04 Requirement already satisfied: mpi4py in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 9)) (3.1.5)
65.04 Requirement already satisfied: tensorrt>=8.6.0 in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 10)) (9.1.0.post12.dev4)
65.04 Requirement already satisfied: numpy in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 11)) (1.22.2)
66.08 Collecting cuda-python==12.2.0 (from -r requirements.txt (line 12))
66.08   Obtaining dependency information for cuda-python==12.2.0 from https://files.pythonhosted.org/packages/2b/5c/ad3b6bee78f95134834dc2ce8805fc12ac70d7a9ba065e2d7c05263549dc/cuda_python-12.2.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
66.35   Downloading cuda_python-12.2.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (749 bytes)
67.54 Collecting sentencepiece>=0.1.99 (from -r requirements.txt (line 13))
67.81   Downloading sentencepiece-0.1.99-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.3 MB)
71.64      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.3/1.3 MB 346.6 kB/s eta 0:00:00
71.64 Requirement already satisfied: wheel in /usr/local/lib/python3.10/dist-packages (from -r requirements.txt (line 14)) (0.41.1)
72.88 Collecting lark (from -r requirements.txt (line 15))
72.88   Obtaining dependency information for lark from https://files.pythonhosted.org/packages/99/ca/f3532a61dce7dd52fbd38737a12e16cdc7699697e23287eb7addfdd93e3f/lark-1.1.8-py3-none-any.whl.metadata
73.14   Downloading lark-1.1.8-py3-none-any.whl.metadata (1.9 kB)
73.63 Requirement already satisfied: filelock in /usr/local/lib/python3.10/dist-packages (from transformers==4.31.0->-r requirements.txt (line 3)) (3.12.2)
74.64 Collecting huggingface-hub<1.0,>=0.14.1 (from transformers==4.31.0->-r requirements.txt (line 3))
74.64   Obtaining dependency information for huggingface-hub<1.0,>=0.14.1 from https://files.pythonhosted.org/packages/ef/b5/b6107bd65fa4c96fdf00e4733e2fe5729bb9e5e09997f63074bb43d3ab28/huggingface_hub-0.18.0-py3-none-any.whl.metadata
74.90   Downloading huggingface_hub-0.18.0-py3-none-any.whl.metadata (13 kB)
74.91 Requirement already satisfied: packaging>=20.0 in /usr/local/lib/python3.10/dist-packages (from transformers==4.31.0->-r requirements.txt (line 3)) (23.1)
74.91 Requirement already satisfied: pyyaml>=5.1 in /usr/local/lib/python3.10/dist-packages (from transformers==4.31.0->-r requirements.txt (line 3)) (6.0.1)
74.91 Requirement already satisfied: regex!=2019.12.17 in /usr/local/lib/python3.10/dist-packages (from transformers==4.31.0->-r requirements.txt (line 3)) (2023.6.3)
74.91 Requirement already satisfied: requests in /usr/local/lib/python3.10/dist-packages (from transformers==4.31.0->-r requirements.txt (line 3)) (2.31.0)
76.64 Collecting tokenizers!=0.11.3,<0.14,>=0.11.1 (from transformers==4.31.0->-r requirements.txt (line 3))
76.90   Downloading tokenizers-0.13.3-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (7.8 MB)
81.28      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 7.8/7.8 MB 1.8 MB/s eta 0:00:00
82.71 Collecting safetensors>=0.3.1 (from transformers==4.31.0->-r requirements.txt (line 3))
82.71   Obtaining dependency information for safetensors>=0.3.1 from https://files.pythonhosted.org/packages/20/4e/878b080dbda92666233ec6f316a53969edcb58eab1aa399a64d0521cf953/safetensors-0.4.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
82.97   Downloading safetensors-0.4.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (3.8 kB)
82.97 Requirement already satisfied: tqdm>=4.27 in /usr/local/lib/python3.10/dist-packages (from transformers==4.31.0->-r requirements.txt (line 3)) (4.65.0)
83.06 Requirement already satisfied: Pillow in /usr/local/lib/python3.10/dist-packages (from diffusers==0.15.0->-r requirements.txt (line 4)) (9.2.0)
83.07 Requirement already satisfied: importlib-metadata in /usr/local/lib/python3.10/dist-packages (from diffusers==0.15.0->-r requirements.txt (line 4)) (6.8.0)
83.11 Requirement already satisfied: psutil in /usr/local/lib/python3.10/dist-packages (from accelerate==0.20.3->-r requirements.txt (line 5)) (5.9.4)
83.12 Requirement already satisfied: cython in /usr/local/lib/python3.10/dist-packages (from cuda-python==12.2.0->-r requirements.txt (line 12)) (3.0.0)
84.61 Collecting pyproject_hooks (from build->-r requirements.txt (line 1))
84.87   Downloading pyproject_hooks-1.0.0-py3-none-any.whl (9.3 kB)
84.88 Requirement already satisfied: tomli>=1.1.0 in /usr/local/lib/python3.10/dist-packages (from build->-r requirements.txt (line 1)) (2.0.1)
84.88 Requirement already satisfied: typing-extensions in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 2)) (4.7.1)
84.88 Requirement already satisfied: sympy in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 2)) (1.12)
84.89 Requirement already satisfied: networkx in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 2)) (2.6.3)
84.89 Requirement already satisfied: jinja2 in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 2)) (3.1.2)
84.89 Requirement already satisfied: fsspec in /usr/local/lib/python3.10/dist-packages (from torch->-r requirements.txt (line 2)) (2023.6.0)
84.89 Requirement already satisfied: protobuf>=3.20.2 in /usr/local/lib/python3.10/dist-packages (from onnx>=1.12.0->-r requirements.txt (line 8)) (4.21.12)
85.15 Requirement already satisfied: zipp>=0.5 in /usr/local/lib/python3.10/dist-packages (from importlib-metadata->diffusers==0.15.0->-r requirements.txt (line 4)) (3.16.2)
85.16 Requirement already satisfied: MarkupSafe>=2.0 in /usr/local/lib/python3.10/dist-packages (from jinja2->torch->-r requirements.txt (line 2)) (2.1.3)
85.23 Requirement already satisfied: charset-normalizer<4,>=2 in /usr/local/lib/python3.10/dist-packages (from requests->transformers==4.31.0->-r requirements.txt (line 3)) (3.2.0)
85.23 Requirement already satisfied: idna<4,>=2.5 in /usr/local/lib/python3.10/dist-packages (from requests->transformers==4.31.0->-r requirements.txt (line 3)) (3.4)
85.23 Requirement already satisfied: urllib3<3,>=1.21.1 in /usr/local/lib/python3.10/dist-packages (from requests->transformers==4.31.0->-r requirements.txt (line 3)) (1.26.16)
85.23 Requirement already satisfied: certifi>=2017.4.17 in /usr/local/lib/python3.10/dist-packages (from requests->transformers==4.31.0->-r requirements.txt (line 3)) (2023.7.22)
85.23 Requirement already satisfied: mpmath>=0.19 in /usr/local/lib/python3.10/dist-packages (from sympy->torch->-r requirements.txt (line 2)) (1.3.0)
85.56 Downloading transformers-4.31.0-py3-none-any.whl (7.4 MB)
87.39    ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 7.4/7.4 MB 4.0 MB/s eta 0:00:00
87.65 Downloading accelerate-0.20.3-py3-none-any.whl (227 kB)
87.69    ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 227.6/227.6 kB 6.5 MB/s eta 0:00:00
87.96 Downloading cuda_python-12.2.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (20.1 MB)
90.87    ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 20.1/20.1 MB 8.1 MB/s eta 0:00:00
91.13 Downloading build-1.0.3-py3-none-any.whl (18 kB)
91.41 Downloading colored-2.2.3-py3-none-any.whl (16 kB)
91.67 Downloading lark-1.1.8-py3-none-any.whl (111 kB)
91.68    ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 111.6/111.6 kB 16.6 MB/s eta 0:00:00
91.94 Downloading huggingface_hub-0.18.0-py3-none-any.whl (301 kB)
91.97    ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 302.0/302.0 kB 12.4 MB/s eta 0:00:00
92.23 Downloading safetensors-0.4.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (1.3 MB)
92.36    ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.3/1.3 MB 11.3 MB/s eta 0:00:00
94.58 Installing collected packages: tokenizers, sentencepiece, safetensors, pyproject_hooks, lark, cuda-python, colored, huggingface-hub, build, transformers, diffusers, accelerate
94.83   Attempting uninstall: cuda-python
94.83     Found existing installation: cuda-python 12.1.0rc5+1.g994d8d0
94.84     Uninstalling cuda-python-12.1.0rc5+1.g994d8d0:
94.89       Successfully uninstalled cuda-python-12.1.0rc5+1.g994d8d0
99.26 Successfully installed accelerate-0.20.3 build-1.0.3 colored-2.2.3 cuda-python-12.2.0 diffusers-0.15.0 huggingface-hub-0.18.0 lark-1.1.8 pyproject_hooks-1.0.0 safetensors-0.4.0 sentencepiece-0.1.99 tokenizers-0.13.3 transformers-4.31.0
99.26 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
101.4
101.4 [notice] A new release of pip is available: 23.2.1 -> 23.3.1
101.4 [notice] To update, run: python3 -m pip install --upgrade pip
102.2 -- The CXX compiler identification is GNU 11.4.0
102.2 -- Detecting CXX compiler ABI info
102.3 -- Detecting CXX compiler ABI info - done
102.3 -- Check for working CXX compiler: /usr/bin/c++ - skipped
102.3 -- Detecting CXX compile features
102.3 -- Detecting CXX compile features - done
102.3 -- NVTX is disabled
102.3 -- Importing batch manager
102.3 -- Building PyTorch
102.3 -- Building Google tests
102.3 -- Building benchmarks
102.3 -- Looking for a CUDA compiler
104.3 -- Looking for a CUDA compiler - /usr/local/cuda/bin/nvcc
104.3 -- CUDA compiler: /usr/local/cuda/bin/nvcc
104.3 -- GPU architectures: 70-real;80-real;86-real;89-real;90-real
105.3 -- The CUDA compiler identification is NVIDIA 12.2.128
105.3 -- Detecting CUDA compiler ABI info
107.5 -- Detecting CUDA compiler ABI info - done
107.6 -- Check for working CUDA compiler: /usr/local/cuda/bin/nvcc - skipped
107.6 -- Detecting CUDA compile features
107.6 -- Detecting CUDA compile features - done
107.6 -- Found CUDAToolkit: /usr/local/cuda/include (found version "12.2.128")
107.6 -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
107.7 -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
107.7 -- Found Threads: TRUE
107.7 -- ========================= Importing and creating target nvinfer ==========================
107.7 -- Looking for library nvinfer
107.7 -- Library that was found /usr/local/tensorrt/targets/x86_64-linux-gnu/lib/libnvinfer.so
107.7 -- ==========================================================================================
107.7 -- ========================= Importing and creating target nvuffparser ==========================
107.7 -- Looking for library nvparsers
107.7 -- Library that was found nvparsers_LIB_PATH-NOTFOUND
107.7 -- ==========================================================================================
107.7 -- CUDAToolkit_VERSION 12.2 is greater or equal than 11.0, enable -DENABLE_BF16 flag
107.7 -- CUDAToolkit_VERSION 12.2 is greater or equal than 11.8, enable -DENABLE_FP8 flag
108.1 -- Found MPI_CXX: /opt/hpcx/ompi/lib/libmpi.so (found version "3.1")
108.1 -- Found MPI: TRUE (found version "3.1")
108.1 -- COMMON_HEADER_DIRS: /src/tensorrt_llm/cpp;/usr/local/cuda/include
108.1 CMake Warning at CMakeLists.txt:248 (message):
108.1   Ignoring environment variable TORCH_CUDA_ARCH_LIST=5.2 6.0 6.1 7.0 7.5 8.0
108.1   8.6 9.0+PTX
108.1
108.1
108.1 -- TORCH_CUDA_ARCH_LIST: 7.0;8.0;8.6;8.9;9.0
108.4 -- Found Python3: /usr/bin/python3.10 (found version "3.10.12") found components: Interpreter Development Development.Module Development.Embed
108.4 -- Found Python executable at /usr/bin/python3.10
108.4 -- Found Python libraries at /usr/lib/x86_64-linux-gnu
111.6 -- Found CUDA: /usr/local/cuda (found version "12.2")
111.6 -- Found CUDAToolkit: /usr/local/cuda/include (found version "12.2.128")
111.7 -- Caffe2: CUDA detected: 12.2
111.7 -- Caffe2: CUDA nvcc is: /usr/local/cuda/bin/nvcc
111.7 -- Caffe2: CUDA toolkit directory: /usr/local/cuda
111.8 -- Caffe2: Header version is: 12.2
111.9 -- /usr/local/cuda/lib64/libnvrtc.so shorthash is eaa826f0
111.9 -- USE_CUDNN is set to 0.

Dockerfile.multi:48
46 |
47 |     ARG BUILD_WHEEL_ARGS="--clean --trt_root /usr/local/tensorrt"
48 | >>> RUN python3 scripts/build_wheel.py ${BUILD_WHEEL_ARGS}
49 |
50 |     FROM devel as release
ERROR: failed to solve: process "/bin/bash -c python3 scripts/build_wheel.py ${BUILD_WHEEL_ARGS}" did not complete successfully: exit code: 1

The batch manager library is truncated or incomplete. This is usually caused by using Git LFS (Large File Storage) incorrectly. Please try running command git lfs install && git lfs pull.


Not loading styles

Why is that if i follow the installation process and the configuration process the styles are not applied unless i place the
@tailwind base;
@tailwind components;
@tailwind utilities;

in my styles.css file but if i place it in the layout.svelte file like so
<style lang='postcss'>
	@tailwind base;
	@tailwind components;
	@tailwind utilities;
</style>

the styles are applied is this issue on my side or?

Hi @Ciamuthama 👋.  I'm not certain what the issue can be, but I've used both approaches.
The docs currently use sveltePreproces and <style lang='postcss'> in +layout.svelte.
The npx create-svelte-ux@latest templates, such as starter, use vitePreprocess and app.postcss.  The Tailwind SvelteKit guide also uses this process as well (but names their file app.css).
I would take a look at your svelte.config.js and postcss.config.cjs and compare to the docs setup or the template and see if there is a difference.  If you want to share a repo / stackblitz link, I could take a look.

Hello @techniq here are the links to my postcss and svelte config files https://github.com/Ciamuthama/anonjot-svelte-v/blob/master/postcss.config.cjs
https://github.com/Ciamuthama/anonjot-svelte-v/blob/master/svelte.config.js

@Ciamuthama Hmm... I haven't tried using vitePreprocess with <style>.  I've done sveltePreprocess with <style> and vitePreprocess with a separate app.css.
I know the kit docs say vitePreprocess do not support all the use cases of sveltePreprocess, but I think it's mostly things like CoffeeScript and not postcss related.  Also, when I look at the vite-plugin-svelte docs, it says...

By default, PostCSS or LightningCSS (if configured in Vite) is applied to all

Thank you @techniq, since svelte-ux is working with app.css I will stick with that for now, thank you again for taking your time to respond to my issue. 🙏

Very welcome.
Btw, I just switched the docs to use vitePreprocess (see commit) and it required using a separate .css file just for the @tailwind (@apply and everything else looks to work without issue).
Been on my list of things to do, and felt like no time like the present (closed an old issue and removed an extra dependency, which is always a win).
I'm going to close this issue for now, but if I find a way to handle @tailwind within +layout.svelte, I'll be sure to post here.

Yeah, I don't think there's any other solution here.
Putting the @tailwind tags inside <style> in your +layout.svelte file, the styles end up scoped to just that one file, just like any other CSS that you might put in a Svelte file.
With sveltePreprocess you could write <style global>, which would mark all the styles in that tag as global, but vitePreprocess doesn't support that so putting it in a separate CSS file is the right way here.

Thanks @dimfeld.  Surprisingly I didn't have to use <style global> or <style>:global(...) { ... }</style> when using sveltePreprocess.  Adding a separate app.css isn't a big deal and I've been wanting to get away from sveltePreprocess (#57)


play: link to the playground source code in the help page

I can never remember where it is. It's pretty standard nowadays to link back to the implementation of any open source website. IIRC, there are actually multiple playground moving parts. It'd be nice to link to all of them. I'd send a CL, but, um, I can't remember where the code is.
cc @andybons

IIRC, there are actually multiple playground moving parts.

But yeah, worth linking to.


Revert linter exception removal

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #222
Summary:
Restore linter exceptions that should have been left in place.
Type of change:
Please delete options that are not relevant.

[ ] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

:tada: This PR is included in version 2.10.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add annotation image module

It should includes:

blending merge functions (img + segmentation mask)
annotation function to use in jupyter for interactive annotation

ipyannotations is broken, maybe I need to build directly using ipywidgets... I am not sure how much work this will take to do that...
I am kinda anxious with that, the final deadline is close
https://github.com/jupyter-widgets/ipywidgets

Maybe consider using ipycanvas instead https://ipycanvas.readthedocs.io/en/latest/usage.html
It has nice properties that can be useful:

https://ipycanvas.readthedocs.io/en/latest/drawing_shapes.html#drawing-polygons
https://ipycanvas.readthedocs.io/en/latest/drawing_images.html#from-a-numpy-array
https://ipycanvas.readthedocs.io/en/latest/retrieve_images.html#get-image-data-as-a-numpy-array
https://ipycanvas.readthedocs.io/en/latest/events.html#built-in-mouse-events

And to create dropdown menus, box, and buttons I can use the normal pywidget.
It seems feasible!!!

with ipycanvas I'm getting some progress!


ARROW-9560: [Packaging] Add required conda-forge.yml

@github-actions crossbow submit conda-linux-gcc-py36-cpu

@github-actions crossbow submit -g conda


Feature: Add an ability to show audit access control list

What feature or improvement do you think would benefit Files?

Requirements

Add segmented control or top stled navigation view in the middle of the advanced security page.
Show them

Files Version
2.5
Windows Version
10.0.22000
Comments
No response

Thank you for the feedback, we don't have plans to do this right now but we'll keep this open to gather more feedback.


Unittest: Table To Point test written

Looks good and tests seem to run fine...
C:\Users\<user>\Documents\GitHub\military-tools-geoprocessing-toolbox\utils\test [jh-ut-dev]> .\TestKickStart.bat
Python 3.4 Tests ===============================
Debug messaging is OFF
Logging results to: MTGT_2016-May-16_14-03-59_seq0.log
adding test: test_convert_coordinates_pro
adding test: test_table_to_twopointline_pro
adding test: test_table_to_ellipse_pro
adding test: test_table_to_lineofbearing_pro
adding test: test_table_to_point_pro
adding test: test_table_to_polygon_pro
adding test: test_table_to_polyline_pro
running 7 tests...
ArcPy works
Testing Convert Coordinates (Pro).
ArcPy works
Testing Table To 2-Point Line (Pro).
ArcPy works
Testing Farthest On Circle (Pro).
ArcPy works
Testing Table To Line Of Bearing (Pro).
ArcPy works
Testing Table To Point (Pro).
Running tool (Table To Point)
ArcPy works
Testing Table To Polygon (Pro).
ArcPy works
Testing Table To Polyline (Pro).
Test success: True
RESULTS =================================================

Number of tests run: 7
Number of errors: 0
Number of failures: 0

END OF TEST =========================================

Python 2.7 Tests ===============================
Debug messaging is OFF
Logging results to: MTGT_2016-May-16_14-04-29_seq0.log
adding test: test_convert_coordinates_desktop
adding test: test_table_to_twopointline_desktop
adding test: test_table_to_ellipse_desktop
adding test: test_table_to_lineofbearing_desktop
adding test: test_table_to_point_desktop
adding test: test_table_to_polygon_desktop
adding test: test_table_to_polyline_desktop
running 7 tests...
ArcPy works
Testing Convert Coordinates (Desktop).
ArcPy works
Testing Table To 2-Point Line (Desktop).
ArcPy works
Testing Farthest On Circle (Desktop).
ArcPy works
Testing Table To Line Of Bearing (Desktop).
ArcPy works
Testing Table To Point (Desktop).
Running tool (Table To Point)
Inside AddUniqueRowID.py
Adding field JoinID
Adding unique row IDs
ArcPy works
Testing Table To Polygon (Desktop).
ArcPy works
Testing Table To Polyline (Desktop).
Test success: True
RESULTS =================================================

Number of tests run: 7
Number of errors: 0
Number of failures: 0

END OF TEST =========================================


Adding a section for 3 d geometry

I would like to add a 3d geometry section which will consist :-

Distance from the Origin

Distance between 2 point

Division of a line joining 2 points

Projection in 3D Space

Direction cosines and direction Ratios of a Line in Cartesian Plane

Direction cosine of line joining two given points

Projection of line segment joining 2 points, on another line

Angle between 2 lines in 3 Dimensional Space

Projection of a plane area on 3 coordinate planes

Area of a triangle:

Concept of Plane in 3 Dimensional Geometry

Normal Form of a Plane

Intercept form

Planes passing through 3 given points

Angle between 2 planes

Two sides of a plane

Position of origin

Two Intersecting plane

@sairish2001 Please assign me the above mentioned issue

Go ahead
Deadline 4 April,2021 (11:59 PM IST)


Namespace Org Warning Message

Provide a warning message on the Namespace when the namespace has not been associated yet to a Namespace:

Since the hierarchical access feature hasnt been implemented yet, we will provide this message in the meantime:

The link goes to JSM, but we don't have a link to the form yet. I'll provide the JSM link once I have it.

This copy differs slightly from the Figma's, which one should I use? Also let me know the JSM link.

Use this one for now

until we have the hierarchical access implemented


MB-32 update

:white_check_mark: Build mentorbot 1.0.111-ohovnbmf completed (commit https://github.com/MentorSource/mentorbot/commit/a7a1379dd5 by @rosenkolev)

Codecov Report

Merging #37 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   94.88%   94.89%   +0.01%
==========================================
  Files          33       33
  Lines        1407     1411       +4
==========================================
+ Hits         1335     1339       +4
  Misses         72       72

Impacted Files
Coverage Δ

src/MentorBot.Functions/Services/MailService.cs
82.22% <100%> (+0.82%)
:arrow_up:

...MentorBot.Functions/Processors/OpenAirProcessor.cs
96.26% <100%> (+0.02%)
:arrow_up:

...MentorBot.Functions/Connectors/OpenAirConnector.cs
99.25% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2993650...ac16fd2. Read the comment docs.


[FLINK-15250][doc] Docs of Table Connect to External Systems is outdate and need to fix

[FLINK-15250][doc] Docs of Table Connect to External Systems is outdate and need to fix.

What is the purpose of the change

This pull request update DDL content in Docs of Table Connect to External Systems.*

Brief change log

update file connect.md, connect_zh.md

Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): ( no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks @leonardBang . I will make some changes and merge it.

Thanks very much!


java.net.PortUnreachableException for wildcard UdpClientMavConnection

I'm trying to connect to a simulator via Mavproxy udp forwarding but can't get it to work.
Setup:

I use dronekit-sitl and mavproxy on a Mac and try to connect to the simulator from an Android tablet.
I start the simulator using: dronekit-sitl copter
I start mavproxy using: mavproxy.py --master tcp:<IP_ADDRESS>:5760 --sitl <IP_ADDRESS>:5501
and then add a mavproxy output for the tablet: output add <IP_ADDRESS>:14550
To rule out general connection issues, I have also tried connecting to the simulator with the Ardupilot Mission Planner app and it automatically finds and connects to port 14550.

Problem:
When starting a UdpClientMavConnection with the wildcard ip <IP_ADDRESS>, I get a java.net.PortUnreachableException. When using the mac's local ip instead of <IP_ADDRESS>, I don't get an exception but the connect call never finishes and no frames are received.
Relevant code:
private var _connection: CoroutinesMavConnection? = null
private val scope = CoroutineScope(Dispatchers.Main)

init {
        val dialect = ArdupilotmegaDialect
        _connection = UdpClientMavConnection("<IP_ADDRESS>", 14550, dialect).asCoroutine()
        _connection
            .mavFrame
            .onEach { onMavFrame(it) }
            .launchIn(scope)
        _connection
            .streamState
            .onEach { onStreamState(it) }
            .launchIn(scope)
}

private fun onStreamState(state: StreamState) {
        when (state) {
            StreamState.Active -> {
                log("connection active")
            }

            StreamState.Inactive.Stopped -> {
                log("connection stopped")
                startConnection()
            }

            is StreamState.Inactive.Failed -> {
                log("connection failure ${state.cause.message}")
                state.cause.printStackTrace()
            }
        }
    }

private fun startConnection() {
        scope.launch {
            log("start connection $_connection")
            _connection?.connect(scope)
            log("after start connection $_connection")
        }
    }

So the connection always starts with StreamState.Inactive.Stopped which I assume is the expected behaviour. When trying to start the connection with "<IP_ADDRESS>", I get the java.net.PortUnreachableException. When trying to start with the mac's local ip, it reaches the log statement "start connection" but not "after start connection" and no frames are received.

@dph-jan, please correct me if I'm wrong. You're routing MAVLink packets from your PC to your Android tablet. In that case, your PC is acting as a UDP broadcaster. You should use UdpServerMavConnection instead of client.
Please try this:
_connection = UdpServerMavConnection(14550, dialect).asCoroutine()

That seems to have fixed it, thank you! Just for general understanding, when would you use the UdpClientMavConnection instead?


Add typing in of the scores.

Add typing in of the scores for when updating matches on both bracket view and matches tab.

added to latest version of design brank


adding build options for sbt-assembly.

This is to address https://github.com/yahoo/kafka-manager/issues/18 .  While I'm not sure that's a productive route it's easy to implement.

CLA is valid!


Bug: Bender sources may start with false

Hi!
Brief
Since a recent version of Bender, a parasitic false appears at the beginning of bender.sources, making them uninterpretable by Morty. I tried at least with the current 0.27.0 version.
The output source manifest is as below, where the first line is not wanted:
false
[
  {
    "package": "ariane",
    "independent": false,
    "target": "all(*, all(*))",
...

How to reproduce
git clone https://github.com/openhwgroup/cva6.git
bender sources -f -t ariane > my.sources
head my.sources

And Morty (at least 0.8.0) does not like it:
morty -f my.sources
error parsing json in `my.sources`: invalid type: boolean `false`, expected a sequence at line 1 column 5

Suggestion
There was a similar issue with similar tools (sv2v I think). I'd suggest either or both:

adding a -o target_file (or another letter) to avoid using stdout as the  way of writing to the output file.
removing what seems to be a debug print.

Thanks!
Flavien

Does #115 fix your issue?

Looks very probable, thanks!


Symbol settings in RedPen server api

New RedPen API supports the configuration of validators but does not support configurations of symbols.
I would like to send not only validator but also symbol settings to the api. The following is the image of the json format.
https://gist.github.com/takahi-i/0da2ef3cf6ea89358982

Fixed in v1.2


PERF: CRS - use WKT for cache and lazy load EPSG code

Port of https://github.com/opendatacube/datacube-core/pull/1322

@snowman2 thanks for this, but I'm not too sure this is the right way to approach this problem. I think rasterio.crs.CRS is a common enough input type and we should handle it in the _make_crs cached path, rather than handling it in a "generic" section. rasterio.crs.CRS is a hashable object so can be used as a key directly, only issue is that I want odc-geo to be independent from rasterio, so it might be a bit trickier to implement because of that.
I'm guessing that a performant way to handle rasterio.crs.CRS object would be to query .is_epsg_code property before attempting to call .to_epsg, also with those things going through cache performance impact will be reduced.


client storage not persistent in web but works in desktop(windows) not tested in mobile (android, ios)

Description

Code example to reproduce the issue:
run this code twice normally one chould expect value hello world second time and first time none but i am getting none both first and second time
import flet as ft

def main(page: ft.Page):
	str_=page.client_storage.get("icanhackyou")
	print(str_)
	page.client_storage.set("icanhackyou","hello world")
	print(page.client_storage.contains_key("icanhackyou"))
	str_=page.client_storage.get("icanhackyou")
	print(str_)

ft.app(target=main, assets_dir="assets", view=ft.WEB_BROWSER)

#use dropdown instead

Describe the results you received:

Describe the results you expected:

Additional information you deem important (e.g. issue happens only occasionally):
Flet version (pip show flet):
Name: flet
Version: 0.10.3

Windows 11:

Additional environment details:

The same origin policy for local storage ties the data to the protocol + hostname + port. So even though it's the same code/domain, using a different port would be treated as a separate "origin" by the browser. When re-running flet app it simply ran on a new port each time i re-ran it the port number and due to local storage protocol hostname and port should be same due to which i got the unexpected behaviour.


Install pyeclib from source

I'm still getting these on my vsaio:
Aug 11 01:45:23 saio liberasurecode[4476]: liberasurecode_backend_open: dynamic linking error libJerasure.so.2: cannot open shared object file: No such file or directory
Aug 11 01:45:23 saio liberasurecode[4476]: liberasurecode_backend_open: dynamic linking error libJerasure.so.2: cannot open shared object file: No such file or directory
Aug 11 01:45:23 saio liberasurecode[4476]: liberasurecode_backend_open: dynamic linking error libisal.so.2: cannot open shared object file: No such file or directory
Aug 11 01:45:23 saio liberasurecode[4476]: liberasurecode_backend_open: dynamic linking error libshss.so.1: cannot open shared object file: No such file or directory
Aug 11 01:45:23 saio liberasurecode[4477]: liberasurecode_backend_open: dynamic linking error libJerasure.so.2: cannot open shared object file: No such file or directory
Aug 11 01:45:23 saio liberasurecode[4477]: liberasurecode_backend_open: dynamic linking error libJerasure.so.2: cannot open shared object file: No such file or directory
Aug 11 01:45:23 saio liberasurecode[4477]: liberasurecode_backend_open: dynamic linking error libisal.so.2: cannot open shared object file: No such file or directory
Aug 11 01:45:23 saio liberasurecode[4477]: liberasurecode_backend_open: dynamic linking error libshss.so.1: cannot open shared object file: No such file or directory
So lame.  I'm also scared to review https://review.openstack.org/#/c/344066/ because I don't know how to build/test the damn thing in my development environment :'(

fixed in 54334b

Hi! Nice to meet you.
I have the same errors with you and I found some related bugs about it but I could not find the solution. Could you share the info of 54224b? Is there any link here?
JFYI:
shared object file: No such file or directory
https://access.redhat.com/solutions/3012541
Bug 1440326
https://bugzilla.redhat.com/show_bug.cgi?id=1440326
Bug 1636541
https://bugzilla.redhat.com/show_bug.cgi?id=1636541


make cert usage optional or configurable

It would be nice if cert usage could be set to optional or at least the name of the certs in the directory could be set manually.

Thank you @rgarcia89 for filing the issue. Controller-runtime excepts certs to be available for serving webhook endpoint and certs directory is configurable (https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/manager#Options).
Can you clarify the following questions regarding your feature request -

Intention for making cert usage to be optional, is it to serve webhook on http instead of https?
By name of the certs do you mean the actual server certs (tls.crt and tls.key)?

@SaranBalaji90 I am asking because I have configured a cert and ca using cssljson, I have also placed it correctly.
Pod is coming up, everything looks fine, caBundle has been updated etc.
However, I get the following issue on every service create/update
2020/12/16 10:53:25 http: TLS handshake error from <IP_ADDRESS>:44160: remote error: tls: bad certificate

@rgarcia89 I tried with with cfssl and it seems to work as expected.
Step-1:
cfssl gencert  -ca=ca.pem  -ca-key=ca-key.pem  -config=ca-config.json  -hostname=externalip-validation-webhook-service.externalip-validation-system.svc  -profile=server   server-csr.json | cfssljson -bare server
Step-2:
kubectl create secret tls webhook-server-cert --cert=server.pem --key=server-key.pem -n externalip-validation-system
Step-3:
Updated ValidatingWebhookConfiguration caBundle with output of cat ca.pem | base64 and everything seems to work.
Step-4:
Applied the service file and saw the following error
Error from server (spec.externalIPs: Invalid value: "<IP_ADDRESS>": externalIP specified is not allowed to use): error when creating "clb-svc-2.yaml": admission webhook "validate-externalip.webhook.svc" denied the request: spec.externalIPs: Invalid value: "<IP_ADDRESS>": externalIP specified is not allowed to use

@SaranBalaji90 good to know. In that case something must be wrong with my ca-config.json. Which usage types do you have set and which address?
Thanks in advance

Got it working - I was missing some parameters in the usage section.
Works fine now - Thanks :)


View All Events (web)

Bakground
Event organizers need a way to view all events for a particular category.  The View Event page shows a brief list of events, but the View All Events page will show all events for a category (e.g. past events).  The list of events will be paginated and there will be a back button to return to the view events page.
Functional Requirements

All events for a category are displayed in a paginated form
Event cards use data from database
User should be able to navigate to a different page by clicking the next page
Clicking on an event card will display more information about an event

Non-Functional Requirements

The results should take less than 2 seconds to load
Switching to the next page of results should take less than 2 seconds
Event cards are aligned properly on any screen size

Dependencies
"View Events" and "Detailed Event" pages should be complete
Dummy data for event cards must be in database
Tasks

[x]  Design the UI for the view all events page - 3 hours
[ ]  Implement event card clicking functionality -3 hours
[x] Use live data from database for event cards - 5 hours
[x] Implement pagination -1 hour
[x] Implement back button - 30 minutes

Estimate
12 hours
Acceptance Criteria

Design closely follows the figma designs
Everything is aligned properly for any screen size
Clicking on an event redirects to page showing more information
Back button works properly
Pagination works

check


How to override theme.css now?

It appears that the documentation is out of date. The current instructions say to override theme.css, but it appears that theme.css disappeared in 6c00c53d5f471ffbb24705671b971433ced65ebd.
The out-of-date documentation says:

Overide Existing CSS Or JS
Create the matching file in your static folder, hugo will use yours instead of the theme’s one. Example :
create a theme.css and place it into static/css/ to fully overide docdock’s theme.css

What's the recommended way of overriding themes now?

For the original theme, I was able to override the CSS by placing it at: static/theme-original/style.css

I believe that the docs still need to be updated.
The solution that I used, which avoids copying the entire theme into my own codebase, was to load my own JavaScript and CSS files that I then use to tweak the styles.
I used a custom header partial layouts/partials/custom-head.html to load the files:
<link rel="stylesheet" href="/css/custom.css">
<script src="/js/custom.js"></script>

Then overrode the style I wanted to change in static/css/custom.css (in this case, to avoid altering the casing of titles):
h2 {
    text-transform: none;
}

And executed some additional JavaScript from static/js/custom.js (note that jQuery is already loaded by the theme):
function tweakPage() {
    // make some changes here
}

$(tweakPage)


chore: add diagnostics to flaky test

I added diagnostics in order to read the streamed events of the flaky test to understand what's happening.
I also undid the changes done in #2268 as they didn't fix the issue.

Converting this to draft because I can test the flaky test here as well, it doesn't need to be merged.

The problem is not showing up in our flaky test suite anymore and I cannot reproduce it when repeating the flaky test 100 times, which makes me confident enough that the problem doesn't exist anymore.


Add a redirect handler for the NuGet Package Explorer activation url

The next version of NuGet Package Explorer will enable activation from a url. So for example, if you put this url on your webpage:
http://nuget.codeplex.com/releases/59864/clickOnce/NuGetPackageExplorer.application?package=http://packages.nuget.org/v1/Package/Download/EntityFramework/4.1.10715.0
Anyone who has NPE installed on his machine can click on this link to have NPE open and automatically load the Entity Framework package.
Obviously, the above url is too long and nobody can remember it. So I'm thinking we can add a redirect handler on nuget.org like this:
http://nuget.org/npe/EntityFramework/4.1.10715.0
then all it does is redirect to the original url.

This is not a ship-stopper for 1.6. If it gets done in time, great. Otherwise moving it to 1.7

This would be fine to have.  We'll accept a pull request for it if submitted; otherwise it's in the backlog.


Close form after submission

Handles form close post submission of job
Shows the progress notification in the notification list

@blueorangutan package

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/797 (JID-3578)


fix(navigation bar): dark theme

Closes https://github.com/ngseke/leetcode-night/issues/39

Thanks @MuhtasimTanmoy


Design a new logo

From my perspective, as Bluebird is approaching v3, it could use some clean visuals. Just gave it a shot:
#683

FYI this the website under construction http://bluebirdjs.com/docs/api-reference.html. I wonder how it would fit there? The colors are white orange blue

The edit link does not seem to work.

it is for submitting pull requests for article modifications once the site goes live (is merge to master)


Update distribution.yaml

If you open a new PR, please close out the old one so we don't waste time looking at it.


record-edit performance issue

We should do a profile on record-edit and improve performance where applicable.
A gpcr user has notified that when she created 16 records, the app was very slow, especially when she had to choose a foreign key from a construct or biomass table which could take more than 1 minute to render. She ended up deleting 8 out of 16.
Will update the issue with browser type and version when I hear more from the user.

This issue is linked to PR #974.


WIP Implemented START STOP qualifiers support for Splunk SPL query

I have refactored splunk qualifier code. I have added condition to check qualifier if it has just START or STOP  single patameter but at the moment qualifier object expects both values to be passed. Also, I wrapped existing fields of x509-certificate to field object because it was breaking.


Fee credits not attempted first for item create and retry?

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
https://stacker.news/items/804607
Screenshots
No response
Steps To Reproduce
unknown
Expected behavior
fee credits are attempted first during initial create and retry
Logs
No response
Device information
No response
Additional context
No response

I believe this was not a bug but a limitation of retries. They won't use fee credits again if a wallet payment failed previously. Closing this since we are aware of this. For now, stackers can disable their attached wallets so they can see a QR code.


feat: Add task request flow

related to #904
Task Request Flow
This merge introduces api for task request feature.
The features include

API to fetch task requests to SUPERUSER
API to approve task request by SUPERUSER
API to request for a task for user.

Waiting on: Task Request API Contract

related to #904

try using closes #904, this will automatically close the issue ones this PR is merged

Coverage stats are as follows

file
%stmts
%Branch
%Funcs
%Lines
Uncovered Lines

constants/taskRequests.js
100
100
100
100

controllers/tasksRequests.js
89.18
85.71
100
89.18
56-57,75-76

middlewares/taskRequests.js
86.95
90
100
86.95
21,39-40

models/taskRequests.js
92.45
100
100
92.15
83-84,113-114

@iamitprakash Have commented the test coverage please check


Rails/HttpStatus not running when rubocop-rspec is loaded after rubocop-rails

Expected behavior
Rubocop output should be the same, whatever is the load order of its extensions.
Steps to reproduce the problem
Given file:
class SimpleController
  def index
    render status: 200
  end
end

When rubocop is ran with:
bundle exec rubocop --require rubocop-rspec --require rubocop-rails --only Rails/HttpStatus simple_controller.rb
We get:
Offenses:

simple_controller.rb:5:20: C: Rails/HttpStatus: Prefer :ok over 200 to define HTTP status code.
    render status: 200
                   ^^^

1 file inspected, 1 offense detected

But when rubocop is ran with:
bundle exec rubocop --require rubocop-rails --require rubocop-rspec --only Rails/HttpStatus simple_controller.rb
We get instead:
1 file inspected, no offenses detected

RuboCop version
$ bundle exec rubocop -V
0.74.0 (using Parser <IP_ADDRESS>, running on ruby 2.5.1 x86_64-darwin17)

Gemfile.lock
GEM
  remote: https://rubygems.org/
  specs:
    ast (2.4.0)
    jaro_winkler (1.5.3)
    parallel (1.17.0)
    parser (<IP_ADDRESS>)
      ast (~> 2.4.0)
    rack (2.0.7)
    rainbow (3.0.0)
    rubocop (0.74.0)
      jaro_winkler (~> 1.5.1)
      parallel (~> 1.10)
      parser (>= 2.6)
      rainbow (>= 2.2.2, < 4.0)
      ruby-progressbar (~> 1.7)
      unicode-display_width (>= 1.4.0, < 1.7)
    rubocop-rails (2.3.0)
      rack (>= 1.1)
      rubocop (>= 0.72.0)
    rubocop-rspec (1.35.0)
      rubocop (>= 0.60.0)
    ruby-progressbar (1.10.1)
    unicode-display_width (1.6.0)

PLATFORMS
  ruby

DEPENDENCIES
  rubocop
  rubocop-rails
  rubocop-rspec

BUNDLED WITH
   1.16.1

It may be resolved by https://github.com/rubocop-hq/rubocop-rspec/pull/834 in the future.

I think this issue has been solved by using the latest RuboCop Rails with the latest RuboCop RSpec.


RunAlways="true" still fails checksum errors

Search first

[X] I searched and no similar issues were found

Description
Currently, if you have just runAlways="true" on a changeSet it will always run, unless you change your changeset. When that happens, it throws a validation error. This is surprising to people, as they think saying runAlways="true" means to always run it regardless, and the reason they are often wanting it to always run it always is because they change it frequently.
See https://forum.liquibase.org/t/changelog-parameters-and-checksum-errors/639/6 as an example thread.
Currently it can be worked around by setting both runAlways="true" and runOnChange="true" but that should not be necessary.
Steps To Reproduce
Create a changeset:
 <changeSet id="1" author="example" runAlways="true">
        <outputMessage message="Hello World"/>
    </changeSet>

and update with it twice. It should output the message each time.
Change it to
 <changeSet id="1" author="example" runAlways="true">
        <outputMessage message="Hello To You"/>
    </changeSet>

and run update again. It fails with a validation error.
Expected/Desired Behavior
The updated changeset should still run without validation error
Liquibase Version
No response
Database Vendor & Version
No response
Liquibase Integration
No response
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
No response
Additional Context
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR (Thank you!)

@nvoxland I proposed a possible solution and created a related PR. I hope it helps in the resolution of the issue.

In all my nearly ten years at Liquibase, I never considered that needing to use runOnChange=true in conjunction with runAlways=true shouldn't be a requirement to leverage the runAlways functionality. My mind is blown!


Cannot login. Credentials are incorrect.

I am running Artemis (vromero/activemq-artemis) in a docker container and none of my microservice can login to Artemis. I am using the default settings so artemis / simetraehcapa. I tried the console url and I get an error 'Failed to login, forbidden'. I tried setting the username and password using the docker environment values ARTEMIS_USERNAME and ARTEMIS_PASSWORD. This doesnt work either. What is going on with this docker image??

What is going on with this docker image??
Regrettably, I'm closing this issue as the aforementioned comment can be considered an unsolicited opinion. Feel free to re-create the issue without it, fork the project or simply use a different docker image.


Haskell generic builder: enable parallel builds for GHC 8.0.2

According to https://ghc.haskell.org/trac/ghc/ticket/4012, this should/could work again. I think it's worthwhile enabling it and if errors appear, we report to upstream.

awesome!


[Feature][branch-2.5] Implement Adapative Nullable Column (#16506)

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #16460
Problem Summary(Required) ：

NullableColumn has two columns: data column and null column. Based on the data, we classify null column into four types:
(1) All data is null: data column is all default value, and null column is all 1
(2) All data has default value(not null): data column is all default value, and null column is all 0
(3) All data has different value(not null): data column has different value, and null column is all 0
(4) Some data is null, some data has different value: data column has different value, and null column has 0 and 1
For type (1) (2) (3), we can compress the nullable column, no need to materialize the data and null column.
We can set a flag to indicate that data column is all default value and null column is all 0/1, especially for
type (1) and (2), both data column and null column can be compressed, for type (3), we can only compress null column.
AdaptiveNullableColumn is designed to handle this issue. It has five state:  kUninitialized, kNull, kConstant
kNotConstant and kMaterialized.
(1) kUninitialized:         AdaptiveNullableColumn is in init stat.
(2) kNull:                  AdaptiveNullableColumn is all null. (data column and null column is compressed)
(3) kConstant:              AdaptiveNullableColumn is all default value (not null) (data column and null column is compressed)
(4) kNotConstant:           AdaptiveNullableColumn has different value (not null) (null column is compressed)
(5) kMaterialized:          AdaptiveNullableColumn has null and differnt value
The state transfer is as following:
kUninitialized ------------->  kNull --------------
                   |                              ｜
                   -------->  kConstant -----------
                   |                              ｜
                   -------->  kNotConstant --------
                   |                              ｜
                   ----------------------------------------------------->   kMaterialized
In the beginning, AdaptiveNullableColumn is in kUninitialized stat, then it will transfer to kNull,
kConstant, kNotConstant and kMaterialized after receiving some data. In kMaterialized state,
both data column and null column are materialized and the behaviour is same as nullable column.
AdaptiveNullableColumn can optimize both CPU and memory, for example, if the data is all null,
when append null data to AdaptiveNullableColumn, we only need increase _size in AdaptiveNullableColumn,
no need to append default to data column and 1 to null column.
At the end of AdaptiveNullableColumn, you need to call materialized_nullable() if you want to use the data column and null column.

Test result:

A table with 670 varchar columns, we start a routine load to load 250,0000 records.
Test is on a single machine with 104 core and 187GB memory, one FE and one BE
Before optimization, routine load takes 137s, the speed is around 18000 row/s
After optimization, routine load takes 77s, the speed is around 32000 row/s, improved by 1.7x

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_fe_unittest

run starrocks_fe_unittest

run starrocks_be_unittest


Create a WMS Dataset that can be displayed in Minerva

Have UI control to create a new WMS Source
Call GetCapabilities (backend) on WMS source and retrieve list of layers (with/without authentication)
Have UI control to create a new WMS Dataset from the WMS Source
Have the WMS Dataset rendered on geojs (currently, only not-authenticated WMS Datasets can be rendered on the map)
Retrieve legend (backend), include it in the metadata, and display it on the bottom left corner of the map (currently, only not-authenticated legends can be displayed)

Nice @essamjoubori :clap:.. ..I will review it after @mgrauer does it.

@essamjoubori I'll start listing QA comments here, though I won't finish this today.

[ ] change the name of the branch from essam to something more meaningful; if you are on the head of this branch on your command line, you can do git checkout -b wms_display or similar, then you'll have to push it and create a new PR.  Do you have the permissions to push directly to this repo?
[ ] there is already a .jshintrc that we merge with the overall Girder one, you can make additions there if need be.  Can you remove the one you added at the top level?
[ ] remove the three files added under src, add src to the .gitignore (I should have done this before now :grin:: )

@mgrauer I've made the changes and created a new PR with the same title. You may close this one.
I don't believe I have the permissions to push directly to this repo.
Thanks!

We should get the Epidemico folks permissions on this repo.  Currently all of us Kitware people have access with the Arbor workflows group.  I'm thinking we should create a new group for this purpose.  What do you think @aashish24?

Thanks for bringing this up @jbeezley. I will fix the group and the permissions.

@jbeezley should be all set. I added Matt and others. @essamjoubori let me know if I missed someone.


[VL] CI: auto merge with main branch then run tests

What changes were proposed in this pull request?
do  a merge with main branch before ruining tests
(Fixes: #ISSUE-ID)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

it seems gha can do this automatically


fish-shell renamed $CMD_DURATION to $cmd_duration

done fails for me because $CMD_DURATION was renamed to $cmd_duration.
This is the commit https://github.com/fish-shell/fish-shell/commit/18b06f3768d6f964dd2c679aee2e80a21c820fe4

I just noticed that I encounter this error because I built fish shell directly from git and the commit I referenced is not yet contained in the most recent release 2.7.1.
I'll close this for now.


Discussion: NavigationView Back Button and Windows Tablet Mode

The NavigationView back button and the back button that appears when Windows is set to "Tablet mode" seem to need some functional reconciliation.

For example, the behavior I'm seeing in the Windows Settings app is the in-app back button is hidden when in tablet mode. Shouldn't the NavigationView control also behave in the same way by default?
The Windows back button on the task bar also functions as I would expect: navigating back to previous pages in the app. Currently, apps I have using NavigationView don't seem to respond as expected in Tablet mode--not navigating back to past pages. It goes to the Start Screen or last app instead.

Tablet Mode has a lot of QoL changes that should be added, but the Hardware Back Button is very useful, and consistency with hiding in app ones, would be welcome.

Currently, apps I have using NavigationView don't seem to respond as expected in Tablet mode--not navigating back to past pages. It goes to the Start Screen or last app instead.

I don't know what the future of the back button is in Windows but this sounds like a bug report for NavigationView's handling of the system back button. Would you like me to convert this issue into a bug for that?

Sure. I wasn't sure if I needed to do more plumbing for the system back button to be handled by the apps a certain way. But again, my expectation, at least, is it gets handled automatically when in tablet mode.

From: Jevan Saks<EMAIL_ADDRESS>Sent: Monday, September 2, 2019 1:39:00 PM
To: microsoft/microsoft-ui-xaml<EMAIL_ADDRESS>Cc: Carlo Mendoza<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [microsoft/microsoft-ui-xaml] Discussion: NavigationView Back Button and Windows Tablet Mode (#1243)
Currently, apps I have using NavigationView don't seem to respond as expected in Tablet mode--not navigating back to past pages. It goes to the Start Screen or last app instead.
I don't know what the future of the back button is in Windows but this sounds like a bug report for NavigationView's handling of the system back button. Would you like me to convert this issue into a bug for that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fmicrosoft-ui-xaml%2Fissues%2F1243%3Femail_source%3Dnotifications%26email_token%3DAA36LQK45BHFGWFRNYS7JBTQHV2WJA5CNFSM4ISJ4RI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5WQTFA%23issuecomment-527239572&data=02|01||a11666d2c55e4b6e2eb108d72fe59687|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637030535422244728&sdata=8f46QXFb77ra8R8McSYvEm7ot5g2We%2BoBOxFO5xo8tY%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAA36LQKPXYOXCOBFZGCMC63QHV2WJANCNFSM4ISJ4RIQ&data=02|01||a11666d2c55e4b6e2eb108d72fe59687|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637030535422254734&sdata=bM2HZo50Xjj5j3dnLOUZichVlNGG1026ni9GzcG6yjs%3D&reserved=0.

It seems like that the UIViewSettings.UserInteractionMode is our best bet to detect whether we are in tablet mode or not.
So if that's a suitable API to use here, I would like to fix this issue.
So to clarify, in Tablet mode, we hide the BackButton.
We won't need to listen to the NavigationManager.BackRequested event right? Or should we listen to the event and just forward it?


Incorrect Stack prototypes

Description
There are currently many incorrect stack prototypes defined in the resources.
A correct stack prototype should have the following fields:

spawn - An entity prototype ID specifying an entity of this stack type. Used by construction to spawn stacks by their stack prototypes alone.
name - A localization ID for the stack name.
icon - A sprite specifier that represents the stack. Used by construction for showing stack icons in guides.

Hi, I just came across this issue and reviewed the old PR.
I'm still quite new to this, but I believe I can tackle it. I’ll create a draft PR later and start working on it.


BatchHTTPRequest: only add access token header if we have it

re-fixes #350. it was originally fixed by c669a3b9a89402c14179d11e587f5438b7209b5c following discussion in https://github.com/google/google-api-python-client/pull/351#discussion_r101218589 , but then that fix got lost in the next commit, https://github.com/google/google-api-python-client/pull/376/commits/282fc889956e42de8ec3e26aecbe39509f027333 .

Can you show me a case where this is problematic?

sure! my repro is pretty much the same as @mgilson's in his original report in #350:
from apiclient import discovery
import httplib2

service = discovery.build('plus', 'v1')
batch = service.new_batch_http_request()
batch.add(service.comments().list(activityId='123'))

# creds is an instance of oauth2client.client.OAuth2Credentials
http = creds.authorize(httplib2.Http())
batch.execute(http=http)

which results in:
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File ".../oauth2client/oauth2client/util.py", line 137, in positional_wrapper
    return wrapped(*args, **kwargs)
  File ".../googleapiclient/http.py", line 1424, in execute
    self._execute(http, self._order, self._requests)
  File ".../googleapiclient/http.py", line 1340, in _execute
    body = self._serialize_request(request)
  File ".../googleapiclient/http.py", line 1211, in _serialize_request
    _auth.apply_credentials(credentials, headers)
  File ".../googleapiclient/_auth.py", line 113, in apply_credentials
    return credentials.apply(headers)
  File ".../oauth2client/oauth2client/client.py", line 621, in apply
    headers['Authorization'] = 'Bearer ' + self.access_token
TypeError: cannot concatenate 'str' and 'NoneType' objects

with this PR, it runs fine.
now, to get it to pass the tests... :P

I don't know if it's helpful -- I haven't looked at this for quite a while, but way-way back I put together a branch/fork that seemed to work.  You can see my changes:  https://github.com/mgilson/google-api-python-client/compare/master...mgilson:app-default-creds?expand=1
Obviously don't trust that this actually works :-).

@mgilson it does work! i actually ran that patch in production for months, until just yesterday, and based this PR on it. thank you!


fix: correct logic for startTime in trx-generator.ts

fix startTime

Thank you for the fix, can you please change the commit message so that it follows semantic commit message? This is necessary for the automatic release job to work properly. Please see CONTRIBUTING.md for tools that can help you.

Is the commit message okay now?

You updated just the name of the Pull Request (to a correct format), but you also need to change the commit itself to the same value too. Please see https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---amend for how to do that

I think it's correct.  Not sure why I tried using the web interface from the beginning rather than the command line.


For an authenticated REST API, allowed editing from the fetch editor

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Summary 💡
I have a REST API that I want to use in Toolpad. Since it requires authentication I am bound to do it using code queries. It would be great if I could just add my secrets and API pro-code way and expose it as a connection in the fetch editor (like earlier).  Then I can just add my endpoint, params etc. and build faster.
Snapshot of how it looks currently in master--toolpad

Examples 🌈
No response
Motivation 🔦
No response

Alternatively, allow binding to environment variables directly


ui/map: cache navigation images at startup

Cache images to avoid reloading, scaling, and flipping (rhd) images with each refresh.it can also prevents Qlable from redrawing the pixmap when its content has not changed.

The scaling appears to be wrong for some instructions:
This PR:

master:

The icons seem to be correct (or at least, same as master in replay) for RHD. Will test in the car just to make sure. The mapbox directions don't seem perfect for roundabouts here.

Fixed it, I didn't realize there were some icon files that were shared. It just scales differently when used.

I didn't realize there were some icon files that were shared. they  just scales differently when used.


Deprecate the typed Neo4j labs plugins

Some user experience improvement.
There were some renaming that makes the whole concept inconsistent. Users should activate the plugin by name from now on.
This commit introduces a new method withPlugins to also get rid of the labs part and be in line with the withPlugins(MountableFile plugins) method.

Thanks for your contribution, @meistermeier !


Camera exposure

The camera exposure is way to high which makes it impossible to test outside during the day (image is completely white). We definitely need the possibility to set the exposure of the camera manually. Even better would be an auto exposure.

Still working on this one, the exposure api in V4L2 did not worked for this camera/atomisp, still debugging to see if I can make this to work.

Added support in this commit https://github.com/zehortigoza/aero-optical-flow/commit/c1c6aec3f19afb103f24062b4f00af74ccef42fb


Still see system /usr/bin/python after activation

I am learning pyenv.
After reading existing open/closed issue. I finally got pyenv installed on RockLinux 8.5.
But when I try to activate 3.9.8 for log4j project, the which python still return /usr/bin/python.

Please advise where I did wrong. from following log

[me@rocky8t01 ~]$ which python
/usr/bin/python
[me@rocky8t01 ~]$ pyenv --version
pyenv 2.2.3
[me@rocky8t01 ~]$ pyenv activate log4j
pyenv-virtualenv: prompt changing will be removed from future release. configure `export PYENV_VIRTUALENV_DISABLE_PROMPT=1' to simulate the behavior.
(log4j) [me@rocky8t01 ~]$ which python
/usr/bin/python
(log4j) [me@rocky8t01 ~]$ pyenv versions
  system
  3.9.8
  3.9.8/envs/log4j
* log4j (set by PYENV_VERSION environment variable)
(log4j) [me@rocky8t01 ~]$ /usr/bin/python -V
Python 3.6.8
(log4j) [me@rocky8t01 ~]$ echo $PATH
/home/me/.pyenv/bin:/home/me/.cargo/bin:/home/me/.local/bin:/home/me/bin:/usr/share/Modules/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
(log4j) [me@rocky8t01 ~]$

Not sure why activate didn't insert "/home/me/.pyenv/versions/3.9.8/bin/" path into $PATH variable ?

(log4j) [me@rocky8t01 ~]$ export PATH=/home/me/.pyenv/versions/3.9.8/bin:$PATH
(log4j) [me@rocky8t01 ~]$ which python
~/.pyenv/versions/3.9.8/bin/python
(log4j) [me@rocky8t01 ~]$

I have the same issue, but on MacOS 12.0.1.
Solved with adding /.pyenv/shims to PATH (not only /.pyenv/bin). This doc about shims helped me.
export PATH="$HOME/.pyenv/shims:$HOME/.pyenv/bin:$PATH"

I have the same issue, but on MacOS 12.0.1.
Solved with adding /.pyenv/shims to PATH (not only /.pyenv/bin). This doc about shims helped me.
export PATH="$HOME/.pyenv/shims:$HOME/.pyenv/bin:$PATH"

Thanks! That solved my issue on Arch Linux!

Thanks - I had the same issue on Ubuntu 20.04 and the solution above worked.


fix(install): improve reliability of latest version detection by using non rate limited api

Proposed changes

Improve the get thin-edge.io install script to avoid rate limiting enforced by GitHub. Sometimes the install script was failing due to the latest version detection logic which relied on the api.github.com endpoint which has fairly low limits for unauthenticated requests.
For example, if a user does too many requests, then the following response is returned by GitHub.
{"message":"API rate limit exceeded for <IP_ADDRESS>. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}

The error was mostly occurred in the integration test runs in GitHub as the rate limiting would be hit due to parallel workflow runs which are attributed to the same IP address.
Below shows the before and after the change.
Before
The requests are limited after about 60 attempts in a short period of time
i=0
while true; do (curl -Ls 'https://api.github.com/repos/thin-edge/thin-edge.io/releases/latest' | grep -vi 'rate limit exceeded' >/dev/null ) && echo " success - attempt $i" || echo " failed - attempt $i"; sleep 0.25; i=$((i+1)); done

Output
 success - attempt 56
 success - attempt 57
 failed - attempt 58
 failed - attempt 59

After
No rate limiting (or an at least the limit has not been found yet)
i=0
while true; do (curl -Ls -o /dev/null -w "%{url_effective}" 'https://github.com/thin-edge/thin-edge.io/releases/latest' | grep '0.12.0' >/dev/null ) && echo " success - attempt $i" || echo " failed - attempt $i"; sleep 0.25; i=$((i+1)); done

Output
#...
 success - attempt 116
 success - attempt 117
 success - attempt 118
 success - attempt 119
 success - attempt 120
 success - attempt 121
 success - attempt 122
 success - attempt 123
 success - attempt 124
 success - attempt 125

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

LGTM, Why don't we use authenticated users for the GH installations?

Because we would have to inject the github token into the containers where the tests are running from...but using an authenticated api request does not make sense to for the install script anyway so there is no point adding it for a special cause for the integration tests.


Package request: linux-tkg

Project description

Metadata

homepage URL: https://github.com/Frogging-Family/linux-tkg
source URL: https://github.com/Frogging-Family/linux-tkg
license: GPL 2.0
platforms: Linux.

Add a :+1: reaction to issues you find important.

I add a +1 :) TKG kernel would be great for gamers !

Since this patches the kernel can it still be packaged as a normal package or something else needs to be done?

Also it doesn't have a license in the repo itself which is odd, so that might need to be resolved. I would assume it would have to be the same as the kernel? I'm nor a legal expert

https://github.com/Frogging-Family/linux-tkg/discussions/887

Also it doesn't have a license in the repo itself which is odd, so that might need to be resolved. I would assume it would have to be the same as the kernel? I'm not a legal expert. That is the reason I put "gpl v2?" Instead of just "gpl v2"

Normally when a repo doesn't have a license I'm not even sure if we can use it

Hopefully it can be resolved

Reply from the maintainer:

Outside of Project C which is GPL 3.0, all other patches are GPL 2.0.
Regarding our build scripts, this falls into public domain atm. Please let me know if you need anything regarding packaging for NixOS and I'll happily help.

Reply from the maintainer:

Outside of Project C which is GPL 3.0, all other patches are GPL 2.0.
Regarding our build scripts, this falls into public domain atm. Please let me know if you need anything regarding packaging for NixOS and I'll happily help.

I'm pretty sure that while he doesn't add a license I can't do anything. Correct me if I am wrong.

I just added the aforementioned licenses.

I just added the aforementioned licenses.

Hello, thanks for being so cooperative and helpful with us! I will be packaging this package as soon as I can.

Up ! 🐼The TKG work is insane! It's a must hase to all distributions !

I am thinking in putting linux-tkg building all in one package so it can be "nixOS compliant", now I wonder should I add a "linux-tkg-configurer" also? What is the community opinion?

I am thinking in putting linux-tkg building all in one package so it can be "nixOS compliant", now I wonder should I add a "linux-tkg-configurer" also? What is the community opinion?

My personal opinion is :
Tkg provide a customization.cfg so I suppose its easy to configure using it as a base.
If it's all from source, the customization is essential, even if you want to use modprobed-db to optimize compilation time for your own system.
It has also the waydroid module in option and this can be useful too.
So for me, a linux-tkg-configurator is Yes.

I don't know if you can add multiple builds, personally, I would see an eevdf and an eevdf-bore with the default options, plus their Waydroid variants.

Don´t know what is technically possible on your end but in a perfect world, I would like 2 options:

a default option with the latest stable kernel already compiled with the default options from the linux-tkg script
a customizable option with the linux-tkg script that will launch on the user side. The user choose the options then compile it on its end then the kernel get installed locally.

Hope this help!

I don't know if you can add multiple builds, personally, I would see an eevdf and an eevdf-bore with the default options, plus their Waydroid variants.
It might be a good idea to have kernels compiled in V3 to gain a bit of performance.

Hello, I never worked with kernels anywhere so I am not sure if I can do that, but if someone wants to do it I will try to help

Don´t know what is technically possible on your end but in a perfect world, I would like 2 options:

a default option with the latest stable kernel already compiled with the default options from the linux-tkg script
a customizable option with the linux-tkg script that will launch on the user side. The user choose the options then compile it on its end then the kernel get installed locally.

Hope this help!

I will try to do this, thank you for the suggestion

Hello, after some time I figuted out I can't do this because:
A) Never used this package;
B) Never touched with kernels, in general, including NixOS.
I will let anyone who can do this do it. If someone can give me a example of a package like this, I can always try again.
Sorry for letting the community down.

I will ping @nonetrix as he is the author.

I am not experienced in packaging Nix stuff but I have toyed with kernel stuff a tad, don't think I can really help though

I pinged you just so you would know and not await anything, I tried seeing some kernel stuff here but they appear hard as it should.

+1

Any updates?

Any updates?

I wanted to make it but I wasn't able to since I don't have the knowledge on how to package kernels to nixos nor I have knowledge about the project. Any help would be appreciated.

As it turns out, Nix has builtin tools to patch the kernel. There's a module called boot.kernelPatches. Using the fetchPatch fetcher combined with this module, you can just get the linux-tkg patches directly from the git repo. No module making required. Just make sure you update the patch hashes before updating the kernel so you don't break it.
This information is split between three different sections across two different Nix manuals, so you aren't able to find it easily. But apparently, it exists. Hope this helps :)


Pull in the path constants into polymer sidebar.

This looks a lot easier than I had originally thought. Now I don't know why I thought it would be so bad actually.
This doesn't change the commit at all, but one thing that we may want to keep in mind for a later addition to the sidebar: it would be nice to be able to list subpages (or even the entire page structure) under each top level page using expandable twisties. The idea would be that when you click the user page for example, the sidebar expands to show add users as a subpage that you can navigate to without a user reference. The details page wouldn't be shown, or maybe would redirect to make you select a user to view details for first. Similarly for proxy servers starting with list as the top level page, then add, edit, and delete would be subpages. Just a thought to consider as something that might help navigation eventually.
Great work on this!

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

Thanks for the review!  Yes, I made the changes with what we currently have in place.  What you suggest is great, and will need to be done when those features being implemented.


Use neovim's async job's instead of system

This commit makes branch.vim use neovim's async jobs instead of a system()
function. This way we avoid the v:shell_error overwrite bug and allow live
updates of the untracked status.

thanks!


fix: Fixing pulumi-equinix/sdk version update

This PR removes dirty from pulumi-equinix/sdk 0.14.0 version.

Do we know how "dirty" got there? I see in the release action that there was some uncommitted diff in provider/cmd/pulumi-resource-equinix/schema.json that resulted in that action failing, marking the repo as dirty. Could that have triggered the dirty in the SDK go.mod?

Since this is to address problems in the v0.15.0 release, should we be updating to v0.15.0?

Since this is to address problems in the v0.15.0 release, should we be updating to v0.15.0? (or v0.15.1 since that is the next release).

We can update it to 0.15.1

Closed in favor of https://github.com/equinix/pulumi-equinix/pull/165


feat: add support for merge results/trains

Merge Result/Trains were enabled in GitLab v12(https://docs.gitlab.com/ee/api/merge_trains.html). Adding those api in the library.
closes #1782

@svanharmelen, Can you please review this one?

@svanharmelen ,
any thoughts? I have sort if stopped development of my code til this PR is merged.

Thank you.


Fix arm hf and add zeus support

This fixes issue #2

Thanks for your contribution!
Can anyone that commented in #2 test this and verify it works for them? @HerrMuellerluedenscheid @mcampbellizo @yohboy

I can confirm it works on warrior! Great job!

Merged in a0b80c1. Thanks!


HTTP/2 + Streaming Response

Based on the comments in https://cloud.google.com/run/quotas#request_limits

Remove 32 MiB request size limit by switching from uvicorn to hypercorn with HTTP/2 support
Remove 32 MIB response size limit by using FastAPI Streaming response (which sets Transfer-Encoding: chunked)

Oh, no - wait. Still need to do something to get a StreamingResponse....


Controller got undefined

Hi, Sorry for bother, and hope it's not a silly question.
I have the following example:
XController.js
angular.module('XModule', ['oc.lazyLoad'])
	.controller('XController',  function ($scope, $window, $ocLazyLoad) {

   $ocLazyLoad.load({
      name: "YModule",
      files: ["/path/to/controller/YController.js"]
    }).then(function() {
      // Then just resolve the promise.
    }, function(e) {
      console.log(e);
    });
...
});

YController.js
angular.module('YModule', ['oc.lazyLoad'])
	.controller('YController',  function ($scope, $window, $ocLazyLoad) {
...
});

HTML:


GenerateDocumentation should return an error to the user if pandoc and other required programs aren't installed

Currently it just crashes on the server and barfs into the server's log, without ever returning to user.

need to see if all of these are installed:

pandoc
doxygen
sphinx_build


Added and example to Envelopes notebook

Hi Colin, sorry it has taken me so long I have had a few problems with my git authentication. Nevertheless, I have put together an example for CS 454 in the Envelopes notebook.
There area couple of points to note:

To simplify the problem I have limited the application of load to either loading a full span or not at all. This may produce action effect slightly less than the maximum. I think a more elegant method may be to use the coordinates from the IL diagram to position the load where it has the most onerous effect. Like a reservoir filling up if you like.
The example makes use of the envelope feature but not the load patterning so it might not be exactly what you are after. if it is not what you are after I won't be offended at all if you don't want to include the example.

Thanks again for sharing the library.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.60%. Comparing base (e580334) to head (2cf4a09).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   80.60%   80.60%
=======================================
  Files          13       13
  Lines        1356     1356
=======================================
  Hits         1093     1093
  Misses        263      263

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks @alexandergriffiths526 ! That's great. I made a few tweaks to make it more generic. It was a really good solution to use the LoadPattern object. However, I realised it could be simpler (at least conceptually, the code is similar) to use the Envelopes class. It just needed a factor_LM method. I'll add this and then revise the notebook accordingly shortly.
Sorry it took so long to get to this, but I'm really grateful for the PR and contribution to the package!


[Userscript] Buffer extension hides Like button

Not sure if this is something to bring up here, or with Buffer.
Having both the userscript and Buffer extension installed via Chrome means that the Buffer icon below tweets will hide the "Like" dialog.
Not sure if this is something that can be fixed.

Above image is with both active.

Above image is without the Buffer Extension active.

Thanks for letting me know - it looks like Buffer adds a new class name to the bar below tweets I should be able to use to avoid this when both are running at the same time

No worries! Sorry to add to your workload with an edge usecase.

Not at all - I have a specific label for these bugs because it's not the first time there's been a conflict with other extensions.

No, the two to the far right are from another userscipt (Twitter Media Downloader) and tipping through Brave Browser (which I believe can be toggled). Both have never had any problems; I just noticed the Like button disappearing.


Allow additional slow calls in huge-service test

What type of PR is this?
/kind bug
/kind regression

What this PR does / why we need it:
After enabling the new huge-service test configuration, there were multiple failures related to slow pod lists per namespace. Investigation showed that there are on average 1-2 slow requests each time the cluster is drastically scaled up or down.
In the load test this was not visible as the test for a larger number of nodes lasts long enough for the p99 to get below 5s threshold. The huge-service test lasts at most a few minutes which is not enough for the same thing to happen.
Therefore a new parameter is introduced for the huge-service test that allows to ignore those few regularly appearing slow calls.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
This change is currently being tested.
Does this PR introduce a user-facing change?:

N/A

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

/assign @mborsz

IIUC, this will start ignoring (verb, resource) pairs with <= 300 count, isn't?
What is an impact on set of (verb, resource) that will be checked?


Introduce MemoryOverCommitment with freePageReporting

What this PR does / why we need it:
With freePageReporting the guest OS informs the hypervisor about pages which are not in use by the guest anymore. The hypervisor can use this information for freeing these pages.
freePageReporting is an attribute that can be defined at Memory balloon device in libvirt.
Extend KubeVirt with freePageReporting support, to allow the hypervisor freeing memory that is not used by the guest, reducing memory pressure on the host.
This PR aims to introduce the ability for cluster admins and VMI creators to enable or disable freePageReporting.
For both cluster and VMI the default value is false.
VMI configuration
In the VMI the value can be specified under vmi.spec.domain.memory.memoryOverCommitment.freePageReporting, with a boolean.
Cluster configuration
Preset configurations (strategy) and the ability to specify a custom value are available at the cluster level.
These can be specified under kv.spec.configuration.memoryOverCommitment.
In the latter a cluster admin can specify a Strategy or a Custom field.
Using strategy
Strategy should be one of the following:

Baseline
Off
Insecure

e.g.
apiVersion: kubevirt.io/v1
kind: KubeVirt
metadata:
 name: kubevirt
 namespace: kubevirt
spec:
 [...]
 configuration:
   [...]
   memoryOverCommitmentProfile:
      strategy: Baseline
 [...]

All these strategies will enable the freePageReporting. Differencies will appear with future enhancements.
Using custom
If cluster admins want to manually specify a value for freePageReporting, they can use the Custom field
e.g.
apiVersion: kubevirt.io/v1
kind: KubeVirt
metadata:
 name: kubevirt
 namespace: kubevirt
spec:
 [...]
 configuration:
   [...]
   memoryOverCommitmentProfile:
      custom:
         freePageReporting: true
 [...]

VMI value for freePageReporting, when specified, will always override the cluster defined one.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

User can now decide whether to use or not freePageReporting. The value can be defined at cluster and vmi level.

/cc @fabiand @xpivarc @enp0s3 @iholder101

@fossedihelm are we sure that freePageReporting works with live migration?
Thinking about this, I'm not sure how would it ...
Could you please add a functional test that verifies this?

I am just thinking out loud.
Does the term "overcommitment" make sense?
KubeVirt will not overcommit guests' memory if freePageReporting is enabled. Enabling freePageReporting would help with overcommitted nodes.
To me, reading vmi.spec.domain.memory.memoryOverCommitment.freePageReporting somehow suggests that the guest will be overcommitted.
In addition, freePageReporting only works with the virtio-memballon driver, but our current API suggests that this feature will be available to any VMI, regardless of the driver.
I wondering, what would be the drawback if we will silently enable this option if autoattachMemBalloon is not false?

I am just thinking out loud. Does the term "overcommitment" make sense?
KubeVirt will not overcommit guests' memory if freePageReporting is enabled. Enabling freePageReporting would help with overcommitted nodes. To me, reading vmi.spec.domain.memory.memoryOverCommitment.freePageReporting somehow suggests that the guest will be overcommitted.

I got your point! To me, it was something like "memory overcommitment management", but you might be right! Any suggestions? Thanks

In addition, freePageReporting only works with the virtio-memballon driver, but our current API suggests that this feature will be available to any VMI, regardless of the driver.
I'm wondering, what would be the drawback if we will silently enable this option if autoattachMemBalloon is not false?

I added a reference in the field description. I'd prefer not to add a constraint between freePageReporting and autoattachMemBallon, since the freePageReporting value will be ignored if autoattachMemBalloon is false. From this point of view I cannot see any drawback. If you prefer, I can add a rule on the vmi validating webhook, but in this case I should add checks in both cases:

Ensure that autoattachMemBallon is true or nil when enabling freePageReporting
Ensure that freePageReporting is not set when disabling autoattachMemBallon

@vladikr Thanks

Thanks @fossedihelm! Great to see this! See small comment below.
In addition, I agree with @vladikr's comment about over-commitment.

How about MemoryBacking or MemorySupport? @iholder101 @vladikr

Thanks @fossedihelm! Great to see this! See small comment below.
In addition, I agree with @vladikr's comment about over-commitment.

How about MemoryBacking or MemorySupport? @iholder101 @vladikr

I wonder if we can get away without any API changes. I fail to see why we need it...
My take on this is that KubeVirt can be smart enough to know when to enable the freePageReporting. We can enable this all the time when autoattachMemBallon is true and the VM is not requesting dedicated CPUs/realtime/etc... (high performance) and no huge pages have been requested on the VMI.
That way, it will be a simple easy change...
What do you think?

Thanks @vladikr for your feedback. I don't totally disagree with your proposal. Actually, I find it a very good starting point for improvements. What I mean is that the logic you exposed could be the default logic KubeVirt can have, and I really think this would be great. That said, I wonder why we should not leave the ability, for those who want it, to disable or enable freePageReporting voluntarily.
KubeVirt may be smart, but those who have full knowledge of the cluster and vmi workloads will still remain cluster admins and vmi creators.
Also, I am not looking at the individual freePageReporting but at memory management in its entirety.
The MemoryOverCommitment (or MemoryBacking or another name yet to be decided) will contain all memory-related tuning (ksm enabled, locked pages, swap, etc..). The combinations can be many IMHO, and I would not leave all the onus on KubeVirt to decide on the right configurations; or rather, I would let KubeVirt choose unless a top-down configuration is explicitly set.
What do you think about this?

Can this PR be closed now that #9572 is merged?


Create a new pull request by comparing changes

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 95.487%

Files with Coverage Reduction
New Missed Lines
%

js/src/dom/event-handler.js
1
92.73%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1961

Relevant Lines:
2015

💛  - Coveralls


Sanitize 1st parameter of Uri and fix a bug where URI parameters were removed because of a bug

I have tried to address 2 problems here.

The regex to remove colon-delimited regexes was removing all the intermediate path if there was another path variable. e.g. /${base-service.server.api-path:}/api/v1/group/{id}/participant was shortened to /${base-service.server.api-path}/participant. So I broke this path into individual paths and then apply regex

REST controllers can have a variable value as a parameter that is picked from application.yaml file. e.g. URI can be /${base-service.server.api-path:}/api/v1/group/{id}/participant. However, this variable will not be resolved while parsing the Controller file and RAML parsing will fail because the 1st parameter cannot be a path variable according to the RFC-6570 URI template.

We can check whether a URI is valid or not as per this regex - https://regex101.com/r/DstcXC/1/

@balthorium Could I please get a review of this PR? Thanks.


Sync-GSCourse

Sync-GSCourse function per issue #334.

@FISHMANPET Thanks for the feedback. This is something that I was working on to replace an existing script that does the same thing. As with all things the existing script, although complicated and messy works just fine and other priorities have since come up. So truthfully I have not looked at this since I put in the initial PR to see if this is something that might be well received for PSGSuite.
If you think this is something worth contributing to the module though I will review your feedback and make some changes in the coming weeks. I wouldn't plan to merge this soon though as it will take me some time to work on it.
Thanks!

@Foggy2 Hey, I know that feeling, I got added as a contributor here 2 years ago and then never had time for anything 😁.
I think this could be useful, but I'll remove it from the 2.37.0 Milestone and give you time to come back and incorporate the feedback.


fix: docker compose

Description
Run docker compose without needing to specify envars.
Fixes # (issue)
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] This change requires a documentation update

How Has This Been Tested?
Manually.  Further help required.
Checklist

[x] I have read the CONTRIBUTING doc
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have already been accepted and merged

Further comments

Thanks for the PR!
Any successful deployments (not always required) will be available below.
Backend available
Once merged, code will be promoted and handed off to following workflow run.
Main Merge Workflow

I thought about this change over last night and I'd like to keep using environment variables for the database properties.
I (and I believe it's the case with @RMCampos as well) am not dealing with any other local database at the moment, so the change would be fine for now; but a time might come when we need to a parallel version of this application's database, for instance, and the hard coded "default" would be a hindrance.
Because of that, I suggest keeping the environment variables for the database and attributing default values to them so we don't need to use environment variables, but we can if we want or need to.

Do not use envars for Docker Compose.  That's bad practice and increases barriers for entry.