Please add one column in the “add Slices to Dashboard” Pop-up window

Make sure these boxes are checked before submitting your issue - thank you!

[X] I have checked the superset logs for python stacktraces and included it here as text if any
[X] I have reproduced the issue with at least the latest released version of superset
[X] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version
0.20.5
Expected results

Steps to reproduce

@luciuschina  - I can have a crack at this one.

Thank you very much!


Fix bug in calculation fact renewal timestamp (#5724)

Pull request opened by the merge tool on behalf of #5724

Merged in 08c41d1a87bd24da7424500d933201320dda4eb3


Court selector should not be required when disabled

Describe the bug
When the user chooses a court from the pre-selected options based on the address they entered, the drop-down selector with the full list is disabled, but the required indicator asterisk still appears:

This could be confusing to some users, since the asterisk and the "Select…" text suggests they ought to do something, but they can't because the field is disabled.
To Reproduce
Steps to reproduce the behavior:

Go to the choose a court (courts matching provided address were found) screen after entering a valid address
Select any of the courts shown
Scroll down to drop-down selector below "Does the list above look wrong?"
See that the red asterisk is still showing even though the selector field is disabled

Expected behavior
The red asterisk should not show up when the field is disabled.
Additional context
I used CSS to solve the problem for a small claims interview for the Massachusetts Trial Court. Here is the pull request.

This is actually an issue on other disabled fields, as well, so I think we can generalize the fix.

I haven't researched all the ways Docassemble adds a required indicator, but this CSS gets all the indicators in the above screenshot:
.darequired:has(.form-control, .form-select:disabled) .da-form-label::after {
  display: none;
}


Uncaught Exception: String given contains NUL-bytes which cannot be present in a C string

Hi,
I thought that since both Rust and PHP support null bytes inside strings, they would interop seamlessly but they do not.
Here are a few cases where it fails:
Example 1
#[php_function]
pub fn class_name_of(obj: &ZendObject) -> String {
    obj.get_class_name().unwrap()
}

<?php

var_dump(class_name_of(new class {}));

Expected result:
string(%d) "class@anonymous/path/to/file.php:3$0"
// or, with XDebug enabled:
string(%d) "class@anonymous\000/path/to/file.php:3$0"

Actual result:
PHP Fatal error: Uncaught Exception: String given contains NUL-bytes which cannot be present in a C string. [...]

Example 2
#[php_function]
pub fn come_on() -> Result<Zval, Error> {
    let mut zv = Zval::new();
    zv.set_string("throw_me_something", false).unwrap();
    call_user_func!(zv)
}

<?php

function throw_me_something() {
    throw new \RuntimeException("Sure, here you go!");
}

come_on();

Expected result:
PHP Fatal error: Uncaught RuntimeException: Sure, here you go! [...]

Actual result:
PHP Fatal error: Uncaught Exception: String given contains NUL-bytes which cannot be present in a C string. [...]

In ZendStr::new() the &str argument is first converted to a CString before being passed to zend_string_init, but this is not right. zend_strings must be able to contain null bytes.
References:

The internals book
zend_string.h


Add SF Symbol support for tool bar, Touch Bar, menu icons

Can now specify SF Symbols for tool bar / Touch Bar icons. The API remains the same where we use the "icon=" syntax in Vim menus to specify the icon, and just passing in the symbol name (e.g. 'gear.circle'). Also extended this to system named images like 'NSAdvanced' (the old gear shaped image), as previously we only had a specical case for Touch Bar system named template images. When loading the icon, MacVim will automatically determine whether it's an SF Symbol, system named image, or a file.
SF Symbols can also be customized to be of a particular symbol style, or have a variable number set, by using colon-delimted option strings. For example: aqi.high:palette:variable-0.5 is a symbol that uses the palette style, set to 0.5 variable value.
Menu items now also support icons, the same as tool bars. We still don't support specifying icons for a submenu (which has been an issue for Touch Bar) since the Vim menu API doesn't support a way to do so.
Also add an ability to use a :template value to specify that an image file is a template image. This is important to fix a minor regression introduced in #1214 where every image loaded in were assumed to be template.
Add documentation to make this clear. See :help macvim-toolbar-icon.
Also see comment in #1105 which requested this feature

Just a screenshot of how the different SF Symbols options would look like, and that we now have support across menu items, tool bar, and Touch Bar:


git-tfs subtree fails: fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.

see below...

Version Git-TFS-0.29.0
Console log:

C:\Users\BRITTG2\source\repos\tbsm-commonretail-db>"C:\Users\BRITTG2\AppData\Roaming\GitTFS\GitTfs-0.29.0\git-tfs.exe" subtree add -p TBSM.CommonRetail.DB http://craadvcp02ttf.d2-tdbfg.com:8080/tfs/TD-TBSM $/Vision/TBSM.CommonRetail.DB
executing subtree add
-> new owning remote default
-> new remote default_subtree/TBSM.CommonRetail.DB
Fetching from TFS remote 'default_subtree/TBSM.CommonRetail.DB'...
C62471 = deff6f75f5bb3337562fe333c3157d7579153126
C62472 = 138afa19b26d0060440540dac0d6c737a952eb9b
C62490 = cc14251e7f163a3a1f18f4bdda809177b88716d4
C63050 = 748afb7dac7642967b1a6aadf42c90816ef3e777
C63179 = ac3a1212f0b39d9c0fca71c50dd19f46fbd27872
fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git  [...] -- [...]'
error running command: git subtree add --prefix=TBSM.CommonRetail.DB "-m Add 'TBSM.CommonRetail.DB/' from commit 'ac3a1212f0b39d9c0fca71c50dd19f46fbd27872'
git-tfs-id: [http://craadvcp02ttf.d2-tdbfg.com:8080/tfs/TD-TBSM];C63179" refs/remotes/tfs/default_subtree/TBSM.CommonRetail.DB
Command exited with error code: 1
Working tree has modifications.  Cannot add.
All the logs could be found in the log file: C:\Users\BRITTG2\AppData\Local\git-tfs\git-tfs_log.txt
C:\Users\BRITTG2\source\repos\tbsm-commonretail-db>"C:\Users\BRITTG2\AppData\Roaming\GitTFS\GitTfs-0.29.0\git-tfs.exe" subtree add -p TBSM.CommonRetail.DB http://craadvcp02ttf.d2-tdbfg.com:8080/tfs/TD-TBSM $/Vision/TBSM.CommonRetail.DB

We are trying to clean up old/stale issues. As this issue hasn't seen any updates (or progress with pull requests) in quite a while, the issue will be closed. In case further information is provided, we can revisit that and reopen the issue again.

We are trying to clean up old/stale issues. As this issue hasn't seen any updates (or progress with pull requests) in quite a while, the issue will be closed. In case further information is provided, we can revisit that and reopen the issue again.


Added test file for header errors and a zip of all test files

Added some test files, these are the ones up on #testing channel, but weren't in the repo yet

@jworcestBAH done reviewing, and one quick question...in the .zip, there's a file called programActivityRaw.csv. I was expecting something called programActivityMixed.csv based on the pattern of the other files. Is this a typo in the name?

Good catch, I've replaced that with the correct file.

@jworcestBAH looks good--thanks!


set/tuple/datatime data types not JSON serializable

The tuple is serializable but gets deserialized back to a list
Set is not serializable at all
Datetime also not serializable:

I think we can add support for these by doing some custom encoding parameters similar to what we did for Pandas in MesopJSONEncoder
For set and tuple, probably can do something like:
      if isinstance(obj, set):
        return {"[set]": obj}

Then in decode_mesop_json_state_hook
    if "[set]" in dct:
      return set(dct["[set]"]),
``

Haven't tested it though. Depends on how the encode decoding works. If it works it's way upwards, then this should work. But if the serialization/deserialization works from root to leaf, then wouldn't work for nested types. But I imagine it should work from leaf to root

--------

Datetime would be similar I think. But need to determine the format we want to store the date as. Some ISO standard or unix timetamp. Maybe some kind of ISO standard especially if we need to handle time zones.

----

Code link: https://github.com/google/mesop/blob/main/mesop/dataclass_utils/dataclass_utils.py

One other note is that for set/tuple changes we may need to adjust the paths for the state diff output to apply the diffs correctly.

Hey can I work on this, this seems to be similar to the one I did before, would be easier.

Someone was working on this. They did the datetime part. I don't know if they plan to come back to work on the set / tuple, so you may want to wait a week before attempting this.
Also the implementation for tuple may not be straightforward.


Startup scripts - updates, new ones for mining pool

Motivation
The run-client and run-miner scripts have been updated for the updated functionality

enable use of environment variables (e.g. miner address)
only restart the snarkos executable when the code has updated and must be recompiled

Two new scripts have been added to make running a mining pool easier.

run-operator makes it obvious to run a mining pool operator
run-prover makes it simple to add a miner to the mining pool

Test Plan

The scripts were tested multiple times on multiple servers.
Related PRs
None

LGTM overall. I have one clarifying question:
In the run-client and run-miner scripts, the logic was updated to no longer terminate the existing node every 30 minutes, but still run the update checker for Github changes. Does this properly terminate if updates are made? Has it been manually checked?

@howardwu The short answer is Yes.  The backgrounded $COMMAND process is terminated if an update is needed.  This was tested successfully (several times).  All testing was done on an ubuntu 20.04 server.  Would you like some additional testing or other checks?

LGTM, thanks @wcannon-aleo !


Menu ribbon hidden in mobile view

On iOS you need to hide the toolbar to see the menu.

Same on Android, Google Pixel 4 and 6. You have to swipe up, which moves the map view, closes the toolbar and presents the ribbon; but it disappears again when you swipe down, which brings the toolbar back.


feat(open-api): production mode

This PR adds support to enable the open API route in the production build output.
Resolves #2418 (experimentally!)
New configs (openAPI: {})

production

false - (default) does not expose openapi.json to the production
runtime - Add runtime event handlers
prerender - Prerender swagger JSON and UIs

route: Default is /_openapi.json
ui.scalar

can be false to disable scalar UI (default is on)
route: Default is /_scalar

ui.swagger

can be false to disable swagger UI (default is on)
route: Default is /_swagger

[!NOTE]
New routes removed /_nitro prefix to be simpler.

Security
Production rotues are explicit opt-in to make sure users deliberately want to expose available routes in the production and make necessary protection if needed.
production: 'runtime'
Ideally before moving the OpenAPI feature to stable, we will have guard route rules to allow a hookable method to protect routes.
In the meantime, in this mode a server middleware can be used to protect
production: 'prerender'
Prerender mode is most efficient because the JSON output is literally a constant response but the case is, the deployment presets that natively have a CDN (netlify, cloudflare, vercel, etc) never hit nitro server and in this mode, protection should be considered on CDN level somehow.

hello it would be cool to have the production key in the doc too :)
just wasted hours trying to do this

Ah sorry for this dear @mirsella. we need to create proper docs for open API indeed in the docs! (feel free to draft a PR if liked to contribute ofc!)


[driver] An exception about subscription.close()

Is there any way to ensure that the state of PublicationImage has changed to LINGER, so that the next step can be done safely？

You can check for presence of the send channel status counter to see if it is still around.
https://github.com/real-logic/aeron/blob/master/aeron-driver/src/main/java/io/aeron/driver/status/SendChannelStatus.java#L32

But it doesn't seem to work
channelStatus() always return -1 when subscription is closed.

If you need to await that the sockets are no longer in use. Which seems to be what you want, then use something like LocalSocketAddressStatus.findNumberOfAddressesByRegistrationId. It will let you know if all of the sockets under the subscription (in case it is MDS) are closed or still open.

it works.
However, exceptions may be thrown in some scenarios, such as when an AeronAchive connection fails(close subscription) and retries(add subscription) immediately。I mean that some of the internal logic is not under the control of the user

If you need to await that the sockets are no longer in use. Which seems to be what you want, then use something like LocalSocketAddressStatus.findNumberOfAddressesByRegistrationId. It will let you know if all of the sockets under the subscription (in case it is MDS) are closed or still open.

thks. i get it


Prevent duplicate app windows

Note: base-branch of this PR is https://github.com/lensapp/lens/pull/5433 instead of master, because the requirements of unit testing are introduced in the branch.
Note: this fixes bug about multiple application windows opening if user reopens Lens using tray while the splash screen was still visible. The bug was reproduced in a unit test and some behaviours around starting and stopping Lens where created.
Relevant test:
opening application window using tray › given application has started › when the application window is closed › when an application window is reopened using tray › given opening of splash window has not finished yet, but another attempt to open the application is made › does not open any new windows

It's odd that, when clicking on "Open Lens" from the tray shows the splash window and doesn't show the app window until it's "ready", but clicking on "Open Lens" from the tray a second time, while the splash window is still shown, the app window is shown immediately, and it is empty until it becomes "ready". Would be cleaner if the app window does not show until it is "ready", regardless of how many times "Open Lens" is clicked.

This was a request of mine since that is how it used to work. It is a useful debugging tool for when the app window crashes so that we can then open the dev tools.

It's odd that, when clicking on "Open Lens" from the tray shows the splash window and doesn't show the app window until it's "ready", but clicking on "Open Lens" from the tray a second time, while the splash window is still shown, the app window is shown immediately, and it is empty until it becomes "ready". Would be cleaner if the app window does not show until it is "ready", regardless of how many times "Open Lens" is clicked.

This was a request of mine since that is how it used to work. It is a useful debugging tool for when the app window crashes so that we can then open the dev tools.

I think in the future we should catch the errors which prevent opening of window somehow, and show some kind of error dialog for them. Then we could go back to implementation where we show application window only once it's ready.
But since this isn't the case yet, we need to have way to access developer tools to see the real error preventing window to be started.
Motivation is documented in the behaviour, so we should be fine and we can change this in the future if we so decide.


Pomodoro icon missing and pop-out menu is blank in Gnome-shell v3.30

What an extension!  Impressive functionality, thank you!
When I enable the Pomodoro from the settings, a blank space appear to the right of the  'add file' icon.  When I click on that blank space a pop-out menu appears which is also blank (see screenshot below).

I have that too.
I only needed the pomodoro option, but https://extensions.gnome.org/extension/53/pomodoro/ only throws an error...
Did you manage to solve that issue @aurovrata? If so, how did you solve it?

this issue is still open

Okay, I solved it.
I previously installed this extension from https://extensions.gnome.org/extension/1238/time/ but this is updated and seems to be buggy (see your bug report).
What I did to make it work

Uninstall time++, if it's installed
I had to reboot my computer
Go to the release section here on github
Choose v3.24--v3.30 and download the zip
Extract zip, rename the folder you got to timepp@zagortenay333
Move it to /home/YOUR_USER_NAME/.local/share/gnome-shell/extensions/
Reboot computer
Go to gnome tweaks and activate time++

Testet on Debian GNU/Linux 10 (buster), Gnome shell 3.30.2.
Now pomodoro also works. You could try to update this extension now, but this should introduce the very same bug again.

Okay, I solved it. I previously installed this extension from https://extensions.gnome.org/extension/1238/time/ but this is updated and seems to be buggy (see your bug report).
What I did to make it work
1. Uninstall time++, if it's installed

2. I had to reboot my computer

3. Go to the [release](https://github.com/zagortenay333/timepp__gnome/releases) section here on github

4. Choose v3.24--v3.30 and [download the zip](https://github.com/zagortenay333/timepp__gnome/archive/refs/tags/v3.24--v3.30.zip)

5. Extract zip, rename the folder you got to _timepp@zagortenay333_

6. Move it to /home/YOUR_USER_NAME/.local/share/gnome-shell/extensions/

7. Reboot computer

8. Go to gnome tweaks and activate time++

Testet on Debian GNU/Linux 10 (buster), Gnome shell 3.30.2.
Now pomodoro also works. You could try to update this extension now, but this should introduce the very same bug again.

I tested it on Zorin Os 15.3, gnome 3.30. Works great, thank you!
There is no release package here, so I downloaded from v140 from this page

Fixed.


suggestion: error messages (format & content)

I know this is early reference implementation (#7 ), but .. Can you maybe provide more explanatory error messages and maybe if possible for all of them to follow a certain format? (it will be easier to handle things off-chain programmatically if so).

No problem. Is there a particular recommended / idiomatic way defined for AE to communicate errors?

Implemented with commit 05e4ef914f2e8387eea59b6bc2db8f20f9b26b42.


Show All PR's for All Repos?

I traditionally work out of workspaces that contain multiple repositories. As it stands, it appears I have to navigate between each repository individually from within source control.
Is there a way to just all all the PR's for every repo within my active workspace?
This comment appears to possibly reference what I am referring too with multi select.

I'd like "Show PRs for All Repos for which I have the ability to review" whether I have a repo loaded into my workspace or not.

This is a must-have feature: it would greatly streamline working in a multi-repository environment. Without it, one needs to click back and forth between Explorer and GitHub panels, and wait for the PR lists to load every time.

Support for this has been added in version 0.20.0 of the extension, the pull request tree should now show all repos in the workspace at the top level


BGP CP: Adds Support for LoadBalancerClass

Updates BGP CP to support advertising services configured with a LoadBalancerClass.
Fixes: #26556
When BGP control plane is enabled and configured for service announcements, it will only advertise a matching service that has an unspecified loadbalancerClass or set for "io.cilium/bgp-control-plane".

The integration-test job is failing due to:
    node_manager_test.go:608:
        node_manager_test.go:593:
            c.Errorf("Node %s allocation mismatch. expected: %d allocated: %d", s.name, minAllocate, node.Stats().AvailableIPs)
        ... Error: Node node10 allocation mismatch. expected: 10 allocated: 20

        ... obtained int = 1010
        ... expected int = 1000

However, this test passes when run locally:
--- PASS: Test (13.39s)
    --- PASS: Test/IPAMSuite (13.39s)
...
        --- PASS: Test/IPAMSuite/TestNodeManagerManyNodes (0.04s)

@danehans Could you also update the docs for service-announcements accordingly?

The integration-test job is failing due to:

This is a known flake https://github.com/cilium/cilium/issues/26617

/test


fix(resolve): css request fallback to node_modules

Description
fix #12260
vite server will try to resolve files from the root directory while receiving assets requests which start with '/', but some requests maybe expect to visit the assets from the node_modules, this PR is trying to add a fallback to resolve assets from the node_modules while requested files don't exist in the root directory.
We could mock a fake entry file _vite_entry_.js to import assets URLs, then covert asset URLs to import statement and transform them to the safe URLs via import-analysis plugin.

Additional context

Also, I think we could enhance to resolve asset requests which match the alias pattern for better DX.
What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the PR Title Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

You're fixing a ton of bugs! 👏🏼 Would it be possible to explain a bit more about how this fix works and add the repro as a test case? (in the css or html playground?)

Sorry for missing the PR's description, I've updated it. Not sure whether this PR is a good solution. I will add the test cases later

I'm not sure if this is the right fix. I think we need to change it here
https://github.com/vitejs/vite/blob/dd7a2f160660c2f8e6c33b7626259f1924773c65/packages/vite/src/node/server/middlewares/indexHtml.ts#L232-L247
Something like server.pluginContainer.resolve to resolve to the right path, but it get's trickier because import-analysis doesn't run here to transform into URL-safe paths.
I think the initial idea is to have the HTML be as plain as possible (without much processing). The implementation detail when building HTML files enabled #12260, but isn't something we publicly support, so I guess we could say that this is intended behaviour.

Yeah. I've thought about this approach too, but it's a bit trickier for now. So I was wondering whether we can support resolving URLs during runtime in these special cases.
I think transforming URLs in the html first via indexHtml is not in conflict with resolving  it during runtime, both approaches depend on resolve and import-analysis plugins.
On the other hand, reserving the html's URLs in dev mode has a better DX.

The issue I think is that this PR carves out a part of the resolve logic for a case in HTML, so it doesn't cover aliases etc, and causes extra resolving for unrelated parts of the lifecycle. So it's probably better to do it once that supports all correctly.

I think it's possible to add alias resolving to resolve plugin, even though I haven't added it to this PR.
I agree with you

So it's probably better to do it once that supports all correctly.

I had an idea that we could convert the assets URLs to js code like import 'style.css' first, then call import-analysis.transform API to transform the js code to URL-safe paths and replace the origin assets URLs with the new URL-safe paths at last.

I'm also not sure if we should support this. My first reaction is that we should do it because it is valid to do the same with a script tag and js. But I agree with @bluwy that we shouldn't bend the current resolve logic to support this. We discussed today about perf with the team, and we should try to remove and simplify the resolve plugin moving forward instead of adding more checks.

Yeah. I agree with @bluwy too. As I dig deeper into this, I think it's possible to reuse the capability of import-analysis plugin in indexHtml middleware via an easy way. We could covert the URLs to import statements and mock importing them in a js file so that we can call import-analysis plugin's transform API. Thus we can bypass the resolve plugin and avoid the runtime's resolving perf loss.

@patak-dev @bluwy sorry to ping you again, I just implemented the idea mentioned before, it works for the regression tests and new cases of alias pattern link, there may be still some edge cases that need to be handled, but I guess the solution will work fine.
If you still have questions about this solution, that's fine to close the pr directly.

This looks like a neat trick! But I'm not sure if it's a good thing to keep this hack within Vite, and I can't say I've not done this myself before though 😄
I think ideally we should try to extract normalizeUrl from import-analysis, but I've tried that before and it's harder than expected (It relies on this IIRC to emit stuff). Maybe I should re-look into it, I think it'll be better to do this the right way in case it bites us back in the future.
Thanks for testing this out though. We could probably reserve this hack as a last resort if needed.


Qube TN

Please merge your commits to the Qube branch - not the main branch.
This allows us to all work off the same draft.


Gets confused when using Simple Tab Groups add-on

The Simple Tab Groups add on resurrects an older Firefox feature: Tab Groups. That add-on confuses the tab-numbering add-on as the latter appears to be counting all tabs, not just visible tabs.
See add on here:
https://addons.mozilla.org/en-US/firefox/addon/simple-tab-groups/
To reproduce:

Install simple tab groups
Pin one tab (I keep my outlook.com open in a pinned tab)
Open two new tab groups
Open tabs in each group, totaling more than 9 collectively among the groups.
observe numbers

For example, right now my second tab (after the pinned tab) is numbered a "8" and the third tab has no number.

Planning to close this issue, since the maintainer of this extension seems very inactive, might fork it.
Please comment here, to send me a notification, if I do not act withing 2 weeks.

Hmm. I mean, not sure why you want to close it.

by close meant solving

Oh, well that sounds great!

Moved to https://gitlab.com/jtagcat/tab-numbering/issues/1
Soon to be closed.

Closed, get v1.2 now!

While I appreciate the effort, @jtagcat,  your version of the addon doesn't resolve the problems I experience. The tabs' own index value can't be trusted when they are being hidden by the Simple Tab Groups add-on. I found it required a bit more complexity.
I finally got around to looking into this and have made my own fork with a fix (actually, a significant rewrite). I haven't submitted it to Mozilla's addons for public distribution yet as I haven't yet decided how I want to manage that. But for anyone coming across this they can go to my fork and download a self-distributed, Mozilla-signed release there.
https://github.com/rajpaulbagga/tab-numbering/releases/tag/v2.0.0b
@tuomassalo , I'd be interested in taking over this project on the Mozilla addons site and pushing out my revision since you don't want to maintain this anymore. Leave a comment here if interested.


FEAT: Add LOMO optimizer

WIP - on par with https://github.com/huggingface/transformers/pull/30178

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Nice, thanks so much ! OK I will work on an example that use accelerate + LOMO and open a follow up PR !


Request view

Call to 'View Service Endpoint' implementation.

Hi, @GustavoArriola.
I appreciate the contribution, however I don't think this is a good addition to B1SLayer as the View Service Endpoint is only available in the SQL Server version of Bussines One, so this implementation would not work in the HANA version where views are exposed through the Semantic Layer.
In any case, you can already call views by simply specifying the desired endpoint and performing a standard GET request:
View Service Endpoint in SQL Server version
var result = await serviceLayer.Request("view.svc/YourViewName").GetAsync();

Semantic Layer Service in HANA version
var result = await serviceLayer.Request("sml.svc/YourViewName").GetAsync();


As a team manager I can add player's match stats

so that I can decide the lineup and give award accordingly.

change to rating


Update gn_helpers.py

Just a minor change in a comment.

@googlebot I signed it!

Thank you for the contribution. However the original comment is already grammatically correct. It means "Helper functions (which are) useful ...".


[Question]: Difference between DocumentSummaryIndex, TreeIndex and RecursiveRetriever?

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
It seems that both of DocumentSummaryIndex, TreeIndex and RecursiveRetriever are building tree or graph structured hierarchies of node, so I seem to met troubles understanding their differences. What are the practical considerations to decide which one to choose? and, can these Indexes/Retrievers be unified under a single abstract class?

[Question]: Difference between DocumentSummaryIndex, TreeIndex, and RecursiveRetriever? #9664
Answer
Based on the information provided, it appears that DocumentSummaryIndex, TreeIndex, and RecursiveRetriever are components involved in organizing and retrieving information from a collection of documents. Here's a breakdown of their potential differences and use cases:
DocumentSummaryIndex:

Likely related to summarizing or indexing document content.
Provides a quick overview or summary of the document.

TreeIndex:

Implies a hierarchical structure, possibly a tree, for organizing documents.
Useful when organizing documents hierarchically is essential for your use case.

RecursiveRetriever:

Suggests a retrieval mechanism that involves recursion.
Valuable when you need to navigate through a hierarchical structure to retrieve information.

Practical Considerations for Choosing:

DocumentSummaryIndex: Quick access to summaries or key information.
TreeIndex: Useful for hierarchical organization.
RecursiveRetriever: Retrieval through nested structures.

Unifying Under a Single Abstract Class:

Consider creating a common interface or abstract class if there are shared functionalities or methods.
Use inheritance or composition based on the specific purposes and behaviors of each component.

This commit updates the documentation to clarify the differences and provides insights into practical considerations when choosing among these components.
Closes: #9664

#9664 answered

"likely" and "possibly" in answers, means that author have no idea what he is talking about. :)

"likely" and "possibly" in an answer, means that author have no idea what he is talking about. :)

the answer was likely generated by chat GPT and it possibly had no access to the documentation that is why its using these words :D


Type 'time' can not inserted to postgresql db

Database definition

Entity definition

Test result

This issue is related to the postgresql-client driver. Please open issue into https://github.com/panates/postgresql-client repository


How should use other video

Hi, great work! I want to use this video and its10th frame as an nft, but the video does not appear. I think it is because of some wrong properties. Maybe add in readme info about how to use other assets?

Are you referring to the videos in the assets directory of this repository? Whether that is the case or your own video, please export the 10th frame as a still image and create a marker with the NFT Marker Creator.
https://carnaux.github.io/NFT-Marker-Creator/#/
For the basic flow for marker recognition, we recommend referring to the official AR.js documentation and sample code.
https://ar-js-org.github.io/AR.js-Docs/
As a reminder, please note that my images and videos are created using The NDL Image Bank and are subject to their own terms of use. I will also add the MIT license for the source code later.


Remove scrolling in mobile view

issue #150
https://github.com/user-attachments/assets/21862fae-6621-44f0-9a44-b0af374be26f
Removed scrolling in mobile view as it create bad user experience

Summary by CodeRabbit

New Features

Enhanced responsiveness for the BackToTopButton, GoogleTranslate, and Footer components to improve usability on smaller screens.

Bug Fixes

Improved initialization logic for Google Translate with a retry mechanism to ensure better loading reliability.

Style

Updated styling for all components to include responsive design classes for better visual adaptation across different screen sizes.

@Sawan-Kushwah resolve the conflicts and don't change the scrolling stying


support for "indexing" syntactic sugar in create collection

it's a brand new parameter at top-level in the request -> must be a named parameter in the method

solved by merging 1.0.0 ("idiomatic")


youtube age restriction

Is there a way for youtube videos to be played if they are restricted to logged in users? Like the server and/or clients using youtube cookies to allow to play those videos?

I don't think so, since youtube applied age restrictions to iframe player, there is no good way to get worked video player on web platform for such videos. You can only reupload that video without restrictions to other channel or some http server and then add mp4 url to playlist.


Add aggregate functions snippets

add all of aggregate functions.

Sorry I'm getting to this late.
Thank you @novy400 !!


Meter reading only for 1 port

Hi,
I have a 2 port Alfen Wallbox (Eve Double Pro-line), the sensor meter reading and Active Power Total only seem to be taken port 1 into account and not port 2. Most of the other sensors do have a 1 and 2 variant.

thanks for this issue, problem is that I don't have a dual port alfen box. So I need more data to fix them.
do you mind sending me the debugger log? so I can see which API param it should be?
or can you use ace installer and let me know which param_id it should be?
on the single port it s. 2221_22 for meter reading and 2221_16 for Active Power Total

Sure,
I don't have the ace installer. The debugger log, is that by enabling debug logging on the integration or something else?

Sure,
I don't have the ace installer. The debugger log, is that by enabling debug logging on the integration or something else?

yes turn them on for 2-3 min, and if you stop them, you will get a log. but be sure that during that debugging, both charging port is charging, so I can see some value in it.

This is the car charging on port 2, I currently only have 1 car to charge
home-assistant_alfen_wallbox_2023-09-27T20-11-07.824Z.log

can you take a look at this beta version if it works?
the socket 1 is also changed name:

active_power_total to active_power_total_socket_1
meter_reading to meter_reading_socket_1

https://github.com/leeyuentuen/alfen_wallbox/releases/tag/2.7.10

@johnnybegood can you take a look on the beta version above? to confirm if this solved it?

@leeyuentuen looks good

@leeyuentuen looks good

it will release for public soon


dbeaver/pro#1319 check password expiration; fix password changing

Please check:

password changing with https://github.com/dbeaver/dbeaver/wiki/Change-current-user-password
password expiration message (one per connection)

verfified


Teach granite to create gds layout, watsonx challenge 2024

If your PR is related to a contribution to the taxonomy, please, fill
out the following questionnaire. If not, replace this whole text and the
following questionnaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy

25 examples of writing python code to generate GDS layout (for semiconductor design purpose)
Organized into 4 qna.yaml under the taxonomy/compositional_skills/designing/gds_layout folder

Input given at the prompt

Generate a GDS with a 30*10 mm rectangle on layer 0 with a text "IBM Research"
    at the center of the rectangle. Put the text on layer 1.

Response from the original model

Here is a Python code snippet using the `numpy` and `matplotlib` libraries\
    \ to generate a parametric spiral based on the given function `r(t) = e^(-0.1t)`\
    \ for `0 <= t <= 6pi`. The line width is set to 1.\n\n```python\nimport numpy\
    \ as np\nimport matplotlib.pyplot as plt\n\ndef parametric_spiral(t, r):\n   \
    \ theta = 2 * np.pi * (1 - r ** 2) ** 0.5\n    return np.array([[r * np.cos(theta),\
    \ r * np.sin(theta)]])\n\nt_values = np.linspace(0, 6 * np.pi, 1000)\nr_values\
    \ = parametric_spiral(t_values, 1)\n\nfig, ax = plt.subplots()\nax.plot(t_values,\
    \ r_values, label='Spiral')\nax.legend()\nax.set_xlabel('t')\nax.set_ylabel('r')\n\
    ax.set_title('Parametric Spiral')\nplt.xlim(0, 6 * np.pi)\nplt.ylim(0, 1)\nplt.grid()\n\
    plt.show()\n```\n\nThis code defines a function `parametric_spiral` that takes\
    \ `t` and `r` as inputs and returns a 2D array representing the parametric spiral.\
    \ The function uses the given function `r(t) = e^(-0.1t)` and calculates the corresponding\
    \ `theta` value using the formula `theta = 2 * pi * (1 - r ** 2) ** 0.5`. The\
    \ resulting 2D array contains the coordinates of the spiral at each `t` value.\n\
    \nThe code then plots the spiral using `matplotlib` and sets the appropriate labels\
    \ and title. The `xlim` and `ylim` parameters are used to set the limits of the\
    \ plot, and the `grid()` function is used to add a grid to the plot.\n\nThe final\
    \ plot shows a clear parametric spiral based on the given function `r(t) = e^(-0.1t)`.\
    \ The user can modify the function and parameters to generate different parametric\
    \ spirals.\n\nKeep in mind that this is just one way to generate a parametric\
    \ spiral, and there are many other methods and libraries available in Python that\
    \ can be used for this purpose.

Response from the fine-tuned model

'Certainly! I''ll create a Python script to generate the GDS layout based
    on your specifications.

    Here''s the code:

    ```python

    import gdspy

    # Create a new GDSII file

    gds = gdspy.GdsDesign()

    # Define the dimensions of the main rectangle

    rectangle_width = 30  # in mm

    rectangle_height = 10  # in mm

    # Define the layers for the rectangle and text

    layer0 = gds.add_layer(''Layer 0'')

    layer1 = gds.add_layer(''Layer 1'')

    # Create a new cell

    cell = gdspy.Cell(''MyCell'')

    gds.append(cell)

    # Define the coordinates for the rectangle

    x_min = -rectangle_width / 2

    y_min = -rectangle_height / 2

    x_max = x_min + rectangle_width

    y_max = y_min + rectangle_height

    # Create the rectangle with the specified dimensions and coordinates

    rectangle = gdspy.Rectangle((x_min, y_min), (x_max, y_max))

    rectangle.layer = layer0

    cell.append(rectangle)

    # Define the text properties

    text_size = 6  # in mm

    font_name = ''Arial''

    # Create the text object with the specified content and coordinates

    text = gdspy.Text(''IBM Research'', (0, 0), size=text_size, font=font_name)

    text.layer = layer1

    cell.append(text)

    # Save the GDSII file

    gds.write_gds(''MyDesign.gds'')

    ```

    This code creates a new GDSII file with a 30*10 mm rectangle on layer 0 and a
    text "IBM Research" at the center of the rectangle, placed on layer 1. The text
    is written in Arial font with a size of 6 mm.

    Please let me know if you have any questions or if there''s anything else I can
    help you with!

    ```'

Contribution checklist

[X] The contribution was tested with ilab generate
[X] No errors or warnings were produced by ilab generate
[X] All commits are signed off (DCO)
[X] The qna.yaml file contains at least 5 seed_examples
[X] The qna.yaml file was linted and prettified (yaml-validator can do both)
[X] An attribution.txt file in the same folder as the qna.yaml file
[X] Content does not include PII or otherwise sensitive or confidential information
[X] Content does not include anything documented in the project's Avoid these Topics guidelines

I'm sorry, but we are only taking approved source submissions right now. Until we have clear direction from Red Hat legal when it comes to IBM documentation. Please take a look at this to find the approved location resources. https://github.com/instructlab/dev-docs/blob/main/docs/knowledge-submissions-past-wikipedia.md
This is the upstream Taxonomy repository, if this was specific to the Watsonx challenge please close this PR and submit it to the correct repository.
Also this looks a lot like math, and math an LLMs are not great, per our canned response:
While LLMs can do simple reasoning and counting out of the box, solving complex tasks like linear equations with multiple variables, or matrix inversion and multiplication belongs to "core skill", which is not open to contribution.

Or this also seems like something that grantite-code would be doing, not our standard granite model which we are only taking submissions for.


Add tests for AnnotationChangeRefactor

There are currently no unit tests for AnnotationChangeRefactor. These should be added, potentially to the existing TestAnnotationsRefactor which already has tests for adding annotations with the AddAnnotationRefactor.

Closing as this has been addressed by @monjurmorshed793 under issue #68.


Image kong/kong-gateway:<IP_ADDRESS>-amazonlinux-2023 does not allow write permissions for kong user

Hi,
I'm using a Dockerfile with the kong/kong-gateway:<IP_ADDRESS>-amazonlinux-2023 and my plugins fail to start because apparently the kong user does not have written permissions to /usr/local/kong.
This problem does not occur using the image kong/kong-gateway:<IP_ADDRESS>-amazonlinux-2022 and kong:3.5-ubuntu for example.
The permissions of the folder are:

I'm seeking for advice on where to look to investigate this issue.

Well, all the docs around plugins relate to adding the binaries to /usr/local/kong see: https://docs.konghq.com/gateway/latest/plugin-development/pluginserver/go/
There is NO documentation under Kong docs about the good practices where the plugins should be, and the issues that one can find on using it.

@hanshuebner the problem is that the kong user does not have write permissions under /usr/local/kong where it creates the .socket files. The documentation points to that path as default, for the creation of it.

@lays147 You mentioned that you're using a custom Dockerfile - Can you add RUN chown kong /usr/local/kong to that so that the incorrect permissions set up by the container are fixed?  This seems like a bug in the Amazon Linux container which we'll need to fix.

@hanshuebner I changed to use the kong-ubuntu based image, since this one is recommended for enterprise users, which I'm not. I just reported the bug :)


[tool_crash] FileSystemException: Failed to decode data using encoding 'utf-8', null

Command
flutter --no-color run --machine --track-widget-creation --device-id=AYIFMNDABIS859S4 --start-paused --dart-define=flutter.inspector.structuredErrors=true lib\main.dart

Steps to Reproduce

...
...
...

Logs
FileSystemException: Failed to decode data using encoding 'utf-8', null
#0      _File._tryDecode (dart:io/file_impl.dart:564:7)
#1      _File.readAsStringSync (dart:io/file_impl.dart:584:7)
#2      ForwardingFile.readAsStringSync (package:file/src/forwarding/forwarding_file.dart:97:16)
#3      ForwardingFile.readAsStringSync (package:file/src/forwarding/forwarding_file.dart:97:16)
#4      FlutterManifest.createFromPath (package:flutter_tools/src/flutter_manifest.dart:36:51)
#5      FlutterProject._readManifest (package:flutter_tools/src/project.dart:218:34)
#6      FlutterProjectFactory.fromDirectory.<anonymous closure> (package:flutter_tools/src/project.dart:48:55)
#7      _LinkedHashMapMixin.putIfAbsent (dart:collection-patch/compact_hash.dart:291:23)
#8      FlutterProjectFactory.fromDirectory (package:flutter_tools/src/project.dart:47:21)
#9      FlutterProject.current (package:flutter_tools/src/project.dart:87:61)
#10     FlutterCommand.findAllTargetDevices (package:flutter_tools/src/runner/flutter_command.dart:1001:81)
#11     RunCommand.validateCommand (package:flutter_tools/src/commands/run.dart:351:21)
<asynchronous suspension>
#12     FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:933:11)
<asynchronous suspension>
#13     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:836:33)
<asynchronous suspension>
#14     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart)
#15     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#16     _rootRun (dart:async/zone.dart:1190:13)
#17     _CustomZone.run (dart:async/zone.dart:1093:19)
#18     _runZoned (dart:async/zone.dart:1630:10)
#19     runZoned (dart:async/zone.dart:1550:10)
#20     AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#21     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:825:20)

[✓] Flutter (Channel stable, 1.22.4, on Microsoft Windows [Version 10.0.19041.630], locale en-AU)
    • Flutter version 1.22.4 at C:\src\flutter
    • Framework revision 1aafb3a8b9 (4 weeks ago), 2020-11-13 09:59:28 -0800
    • Engine revision 2c956a31c0
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\pamps\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[!] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[✓] VS Code (version 1.51.1)
    • VS Code at C:\Users\pamps\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.15.1

[✓] VS Code, 64-bit edition (version 1.46.0)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.15.1

[✓] Connected device (1 available)
    • Lenovo A7010a48 (mobile) • AYIFMNDABIS859S4 • android-arm64 • Android 6.0 (API 23)

! Doctor found issues in 1 category.

Flutter Application Metadata
FileSystemException: Failed to decode data using encoding 'utf-8', path = 'E:\Work_Precise\Mobile\precise_wms\pubspec.yaml'

Closing as a duplicate of https://github.com/flutter/flutter/issues/65021.
See https://github.com/flutter/flutter/issues/65021#issuecomment-685095919 for a workaround for this issue.
Thank you


Set size and position of window

Would it be possible to set the dimensions and position of a given window?

I would be interested as well.
Do you know if there are plans to implement this ?


The 1.3 versions of the C# & C++ Templates are not available

Describe the bug
The WinAppSDK has been updated to version 1.3, but the templates in Studio are still 1.2.  The downloads of the VSIX have been removed from the downloads page, so how do I get the updated templates?
Steps to reproduce the bug

Install VS 2022
Add WinAppSDK C# or C++ VS 2022 Templates
Start a new project

Expected behavior
The templates shoud at the very least point to WinAppSDK 1.3.  I would expect them to be 1.3 versions.
Screenshots
No response
NuGet package version
Windows App SDK 1.3.1: 1.3.230502000
Packaging type
No response
Windows version
No response
IDE
Visual Studio 2022
Additional context
No response

The updates are on the way. We discovered a breaking C++ bug very late in the 1.3 cycle and then the templates exceeded a size limit. As for the downloads, using both standalone and component versions of the extensions were causing issues with upgrades. Standardizing on the component version should remove those issues (as long as we get them released 😳).  We apologize for the inconvenience.

Can someone look into my pull request (#3619)? The C++ templates don't seem to have been cleaned up that much in the repo.

Updated templates are now available in Visual Studio 17.7 Preview 2. The current stable VS (17.6) will get them in the next update (17.6.4) which will be out in the next week or so.
In addition, we understand that this delay in updating the templates is painful. We are looking at solutions to make the WinAppSDK version and the templates version in Visual Studio loosely-coupled, so that each can be updated independently.


IOS build failed 'Undefined symbols for architecture x86_64' #387

I upgraded to version 2.0.0 because of the following error: https://github.com/react-native-community/react-native-text-input-mask/pull/140
After that, I started to get the following error:

I tried to restart XCode, clean an rebuild but nothing worked.
This is how my Podfile ends:
pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party- podspecs/DoubleConversion.podspec'
pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'
use_frameworks!
pod 'RNInputMask', :path => '../node_modules/react-native-text-input-mask/ios/InputMask'

use_native_modules!
end

React Native Version: "0.61.5",
react-native-text-input-mask Version: "2.0.0"

Someone found any solution for this?

Same here.

the same issue

Please fix this issue I have the same issue!

I found solution, add duumy.swift file with bridging header to your ios project (it is described in readme)

I found solution, add duumy.swift file with bridging header to your ios project (it is described in readme)

Thank bro

@ElizavetaDevel Thank You!

This issue should no longer exist

This issue should no longer exist

We are talking about Apple. The must expensive but cheaper platform.

I've the same issue and this Solution worked really well for me


unit-e consumes too much memory on sync

When syncing node from the testnet the client quickly eats up all of the RAM and is killed by the OOM killer.
To reproduce it is enough to try to sync the node. It is especially easy to reproduce when having good connection with the node used for syncing.
I've identified that the issue is finalization state which is stored for every header+commits message received during header+commits sync. The state repository is not pruned fast enough as the validation lags far behind the sync and the effect is that the node consumes enormous amounts of memory (30GBs during first 40k blocks).
@frolosofsky further identified two issues:

The commits are synced too far ahead
Individual finalization states consume too much memory

Limiting the allowed offset between tip and synced headers should be enough to ensure proper resources usage during sync.
The state repository data could use some optimization too, as most of the states don't differ in any way (only differences arise when checkpoints are reached or there are commits on the chain - usually once or twice per epoch). In the attached Massif's output one can see that individual finalization state takes up to 4MBs of memory (at around 40k height).

massif.out.txt.zip

Good catch, in general and by syncing few times, I'd strongly consider limiting the commits based sync to the fast sync use case only. There it's essential to iterate over the commits only, while in full sync we anyway need to download full blocks for validation. In full sync, the node anyway needs to download the full blocks.
Commits should still, of course, be validated epoch by epoch thus allowing but by taking them from the block and eliminating duplicate download of the  full commits history


New package: SmoothLocalProjections v1.0.0

Registering package: SmoothLocalProjections
Repository: https://github.com/justinjjlee/SmoothLocalProjections
Created by: @justinjjlee
Version: v1.0.0
Commit: 32810d859332ef4db011c63bf449e9371e1abd3c
Reviewed by: @justinjjlee
Reference: https://github.com/justinjjlee/SmoothLocalProjections/issues/2#issuecomment-2209444962
Description: julia implementation of Smooth Local Projections (SLP)

Closing in favor of https://github.com/JuliaRegistries/General/pull/110461


Quick pick: improve eventing on value change

(from a 1on1 with Tyler): The intent of this change is to let the input box event handler be the only one that emits events on value changes, and to address the refiltering on programmatic value change (which fixes #137279).

Looking at this with slightly fresher eyes from this morning, this change breaks this:
                const quickpick = controller.createQuickPick();
		quickpick.onDidChangeValue((e) => value = e);
		quickpick.show();
		quickpick.value = 'changed';

where that first quickpick.value does not get a changed triggered. I feel as if we should be doing something based on the visibility of the quickpick?

Very good catch 👍 . Let's wait for input from @chrmarti how this should work.

Continues in https://github.com/microsoft/vscode/pull/137857


Update chat-go.md

Update code to azure-sdk-for-go/sdk/ai/azopenai 0.5.0

@mrbullwinkle
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

adding @aahill

I sent a Teams message to @aahill today.

Sorry we missed your request. The code on this page has been updated to the latest version 0.6.0 which was released in June so this PR is no longer applicable.
https://pkg.go.dev/github.com/Azure/azure-sdk-for-go/sdk/ai/azopenai
Thank you so much for taking the time to put this PR together, apologies that we were unable to accept it due to the release of newer versions since your PR was created.

#please-close


ok

Template
Please write your blade template that occurs issues.
Context (Environment)

write your environment

Description

Any other informations

@shufo Can you ban this guy or something? He keeps posting empty issues and those who watch the project would get notified for nothing! 😡

Maybe we should add github action that automatically close empty issues :sweat_smile:

Closed by #372


More Explication + FFI Changes

Introduces some new logic to the explicator to allow inferring of function outputs

Introduces minimal typechecking of the spec into the explicator
Iterates through each possible allocation and greedily recurses using a basic heuristic

Also fixes up the weird FFI vs Native distinction by making the Native types exactly apply to Caiman logic (and so unifying with the IR).

i64 -> %i64 naming
function classes and specs should use Native types
external functions still use FFI
fixed up the interfaces with HLC, which should also make future translation more straightforward

The changes should be updated and merged with main!  Thanks for the detailed review :)


Fix the image rendering and alignment issue

Purpose
Fix the image rendering and alignment issue.

Closing since this is already addressed via another PR.


Update GTID regex to accept new format on Buzzcards

Read the first 9 digits and take those as the GTID without validating the entire format, as newer Buzzcards won't have the proxID in them

Fixed in #57


Nerf the Rock Guitar Melee

About the PR

Resolves #17669.
Nerfs the damage to 14 (from 20), while also changing the damage to mostly blunt instead of pierce (a guitar isn't that sharp).
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: Lank

tweak: The culprit sharpening everyone's rock guitars has been caught. They should now be more dull and subsequently weaker as a result.

Please see my comment on the issue.

I like moonys suggestion but this is fine for the moment


Any plans for clonable errors?

Related: 121, 134 and 24135.

First, nothing stops you from implementing Clone for a type that implements Fail. Errors in general can be Clone just like any other type, because unlike error-chain we don't inject a trait object into your error type.
However, the Error type provided by failure itself is not Clone, because it is essentially a trait object. It has occurred to me that we could make it into an Arc instead of a Box, but we can't do that backwards compatibly because we exposed the downcast_mut method on `Error. I don't feel great about this because I think mutating an error is an anti-pattern, whereas cloning it is not. But I don't know what to do.

If the issue is "we can't make breaking changes to Error &c. because then things using old-failure won't be using the same types as things using new-failure" ...I am probably completely ignorant of how this sort of thing actually works, and if so I will apologise and continue to watch and learn things — but could you instead of the dtolnay trick, do something like making new-failure import the type from old-failure and impl From<old-failure::Error> for Error?

I think coherence won't let us provide that impl. That would solve the most annoying problems but not all of them, e.g. if Error is a part of the signature of a trait method and its being implemented by another crate using the other Error type.
Currently grepping the source of all reverse dependencies to find out if anyone actually uses downcast_mut ever.

Actually, nevermind. This would also invalidate downcast (by value). I don't want to give up the ability to turn an Error into a concrete value again.
In theory, Clone will some day be object-safe using alloca. Unfortunately, we can't then add Clone as a supertrait on Fail without breaking everything. So I think Error will never be Clone.
Fortunately, there are several work arounds:

Rc<Error> and Arc<Error>.
Using your own type that implements Clone and Fail.

Thanks @withoutboats for the great explanation! The Arc and Rc approach is a nice workaround for this problem.


Added description

 Here is an overview of what got changed by this pull request:

Clones added
============
- src/state/user/userActionCreator.js  5

See the complete overview on Codacy


[FR-4] CRITICAL: Non root page loading is failing

All the pages other than path="/" (home) are not working, routing is failing.

This was a webpack config error!

Stack overflow solution: https://stackoverflow.com/questions/43209666/react-router-v4-cannot-get-url


Open-AMP：power on can not communicate

this issus appeared when i test sample/subsys/ipc/openamp demo.
first step: download image to flash through make flash.
second step: press reset switch on LPCXpresso5411X board and the following message appeared on serial port, as below:
  ******* Booting Zephyr OS v1.12.0-rc1-41-gfcc56e3 *****
  Starting application thread!

  OpenAMP demo started
   Primary core received a message: 1
   Primary core received a message: 3
   Primary core received a message: 5
   ...
   Primary core received a message: 101
   OpenAMP demo ended.**

third step: disconnect the power supply of the development board, and then power on board, i found m4 can not communicate with m0, serial port message as below:
  ******* Booting Zephyr OS v1.12.0-rc1-41-gfcc56e3 *****
  Starting application thread!

OpenAMP demo started**

so why m4 can not communicate m0 when i power on the board， only reset board can communicate?

hi all,
i am now using nxp lpc54102, have we support this chip in the future? lpc54114's flash is 256k, i need mcuboot+parameter storage+m4 image+m0 image, i think it is difficult to OTA. lpc54102 have 512k flash, i can design application program more easily with it.

i am now using nxp lpc54102, have we support this chip in the future? lpc54114's flash is 256k, i need mcuboot+parameter storage+m4 image+m0 image, i think it is difficult to OTA. lpc54102 have 512k flash, i can design application program more easily with it.

You can open an issue asking for support for the lpc54102.  I'd assume it would be too difficult based on the support we have for LPC54114.  @MaureenHelm can comment further.

I have tried the RPMsg-Lite demo (which is not in the repository). Modified it to send a million of messages. When connected USB cable, which powers the board, and opened console afterwards, I could see the stream of messages.
When I did the similar thing with Open-AMP demo, it did not output anything (the initial banner etc. could be already sent before, which is expected, but there was no message output, which is not ok). It worked with the reset button.
When I added some k_sleep() call into app_task (either remote or master), it did not work even after reset button. Note that the second core image is loaded before main(), so the timing could affect initialization of communication.
Even with RPMsg-Lite demo, if I upload using on-board debugger and JLink SW, I see only the initial banner and message and have to press reset button (or power off/on completely) to see the subsequent output.

It should be straightforward to port to lpc54102 using lpc54114 as an example, and reuse the existing peripheral drivers. To get mcuboot working, a flash driver is also needed. The write-block-size for this flash is significantly larger than other devices (256 bytes vs. 8 bytes on k64), so I'm not sure of the implications to mcuboot.
Pull requests are welcome.

i have a question, lpc54114 based on arch/lpc54xxx, but all lpc54102's peripheral drivers are different from lpc54114, so i have to add lpc54102 independence, for example:
@@arch/arm/soc/nxp_lpc/lpc54xxx/soc_lpc54102.c/h ext/hal/nxp/mcux/drivers/lpc54102 drivers/serial/Kconfig.mcux_lpc54102usart ......
but i don't think it's a good idea, i usually think lpc54xxx should include both lpc54102 and lpc54114, lpc also should include both lpc54102 and lpc54114. do you have any good suggestions about how to add lpc54102? @MaureenHelm

i have open an new issue about how to add lpc54102 board.


Add to regro landing page

We should add conda-mirror to the regro landing page: https://regro.github.io/
The source for this is at https://github.com/regro/regro.github.io.
@xhochy, would you mind taking a stab at this, please?  We probably should also have an icon for conda-mirror (and maybe docs?)

Probably would be good to update the package url as well

Very true!


[Question] Pay attention to the value and other fields when importing and monitoring through ymal files in batches: spaces need to be added later, and UTF8 is required when the character set is required

Question
通过批量导入ymal文件发现报错

一个是ymal文件保存的时候字符集需要是utf8，还有一个问题要注意填写的字段的冒号后面需要有一个空格，注意这两点一般导入就没啥问题了。或者使用excel来导入。

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Question
Errors are found by importing ymal files in batches

One is that the character set needs to be utf8 when the ymal file is saved, and there is another problem that needs to be noted that there needs to be a space after the colon in the filled field. Note that these two points are generally imported without any problems. Or use excel to import.


Feature: 'Add Book' Button Border Enhancement

Feature description
Working on the styling especially the border design enhancement of the button, we can make its design attractive.
Current Design

Expected Updated Design

👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

@rohanbabbar04 Kindly assign me this issue.

please assign me this issue under gSSOC 2023

Hi @rohanbabbar04
Kindly assign me this issue.


Allow paths to icons in iconName property

Fixes https://github.com/swaywm/sway/pull/1431#issuecomment-339105775
Feel free to replace with good code.

Thanks!


Move parallelcompat and chunkmanagers to NamedArray

@dcherian I got to this point before realizing that simply moving parallelcompat.py over isn't what it says in the design doc, which instead talks about

Could this functionality be left in Xarray proper for now? Alternative array types like JAX also have some notion of "chunks" for parallel arrays, but the details differ in a number of ways from the Dask/Cubed.
Perhaps variable.chunk/load methods should become functions defined in xarray that convert Variable objects. This is easy so long as xarray can reach in and replace .data

I personally think that simply moving parallelcompat makes sense so long as you expect people to use chunked NamedArray objects. I see the chunked arrays as special cases of duck arrays, and my understanding is that NamedArray is supposed to have full support for duckarrays.
cc @andersy005

[x] As requested in #8238
[ ] Tests added
[ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
[ ] New functions/methods are listed in api.rst

thank you for doing this work, @TomNicholas! moving these modules unblock me.

I personally think that simply moving parallelcompat makes sense so long as you expect people to use chunked NamedArray objects. I see the chunked arrays as special cases of duck arrays, and my understanding is that NamedArray is supposed to have full support for duckarrays.

👍🏽 i concur. and yes, NamedArray will have full support for duckarrays.

Moving utils.either_dict_or_kwargs to namedarray.utils required touching a lot of files to fix!
Also moving the entrypoint seems to have broken the discovery of the DaskManager at least in my local environment, let's see what happens in the CI...

Thanks for the review @andersy005. I feel like I'm trying to hit a moving target with this PR - I'm pretty sure all your comments would not have applied last week. I'll try to make it compatible now though.
This pandas dependency issue however is an actual problem - I don't know how to proceed there.

thank you, @TomNicholas! i have plenty of time today, and i'm happy to help bring this PR to completion.

i have plenty of time today, and i'm happy to help bring this PR to completion.

Great!
Ping me if you need help here @andersy005

@Illviljan and @andersy005 I think we should decide whether to try and fix the (valid) issues with input arguments to .chunks etc. in this PR or a later PR.
For context, these method signatures are somewhat messy because they were dask-specific, they built up various dask-specific kwargs over time, then I generalized them to handle anything via from_array_kwargs, but currently the main xarray API has both for backwards-compatibility purposes.

@dcherian / @TomNicholas / @Illviljan, this is ready for another round of review..
i might have overlooked/ignored quite a few typing errors, but I'm more than willing to correct them with a bit of assistance ;)

this is ready for another round of review :)


Added command line options for host and port to bind to.

Adds command line options:
$ mdr show --help
Usage: mdr show [OPTIONS] MARKDOWN_FILE

  Visualize your presentation (default).

Options:
  -h, --host TEXT     Listen on IP (default: localhost).
  -p, --port INTEGER  Listen on port (default: 8123).
  --help          Show this message and exit.

Codecov Report

Merging #17 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   83.36%   83.43%   +0.06%
==========================================
  Files          13       13
  Lines         475      477       +2
  Branches       37       37
==========================================
+ Hits          396      398       +2
  Misses         74       74
  Partials        5        5

Impacted Files
Coverage Δ

markdownreveal/commands.py
46.93% <100%> (+1.1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c344474...6280418. Read the comment docs.

Thanks a lot! :blush:

Included in 0.1.5 release.


Compatibility with 1.19.3? Any time soon?

Just wondering if there will be a release soon as we love this mod so much and feel it is an essential mod we can't live without.
Describe the bug
Game crashes with 1.19.3 when using 1.19.2 obviously as it is not compatible.
To Reproduce
Steps to reproduce the behavior:

Install latest version of mod (1.19.2). I know there is no 1.19.3.
Start game
Game Crashes with Exit Code: -1

Expected behavior
Game should not crash and mod should work
Desktop (please complete the following information):

OS: Windows 11
Minecraft Version: 1.19.3
Version: 1.19.2

Additional context
Crash Error that is produced:
The game crashed whilst initializing game
Error: java.lang.RuntimeException: Could not execute entrypoint stage 'main' due to errors, provided by 'yigd'!

I'll try to get a 1.19.3 release up this weekend. The 1.19.3 release is done, I just want to fix up some bugs and drop it together with 1.18.2 and 1.19.2 updated versions (with bugfixes and such)

The mod has now been updated. Thank you for your patience!

  Thank you so much!!


Test Framework

Add test task in make.py
Create tests in test/tests folder
Implement exit function, and/or assert (either statement or function, though function will be better)

Implemented in: b91a4ece73 04d5e971d8 3fcac1c056 76c50c0e54


i have problem with timer

timer is only displaying minutes and seconds, but it should display days also.
If you are reporting a problem with Token Wizard, please include the following information:
Which network did you use? (Mainnet, Kovan, Rinkeby, etc.)
Your answer
If you were able to create it, what is the URL of your crowdsale?
https://wizard.poa.network/manage/0x026Ae2C37A44c9b2415d91ef74A6885ED4e13027
Do you have screenshots showing the problem?

Your answer
Do you see errors in the dev console? If yes, please include a screenshot
To open the dev console in Google Chrome, press F12, or go to View -> Developer -> Developer Tools, and open the Console tab
If you see errors, please right click on them and "Save as..". Zip saved file and attach it to the Issue.
Your answer

Another user has the same problem with timer (the crowdsale will start in June, but it shows 3 days): https://wizard.oracles.org/invest?addr=0x21ED7C5bcc78Bd719EE65D95eC65510C81D218da&networkID=1 @fvictorio @fernandomg could you take a look?


Project-level dependency for pydantic-ome-ngff missing

pydantic-ome-ngff is imported but not declared in the dependencies
https://github.com/janelia-cosem/fibsem-tools/blob/00bdfbbe596754dee86b38066db0ab709f47b125/src/fibsem_tools/io/zarr.py#L20

that's gross! i will fit it immediately

This happened as a side-effect of me doing a lot of aimless unfocused changes in a dev branch. It should be fixed in 1.3.0

fixed in https://github.com/janelia-cosem/fibsem-tools/commit/33c38bcab9d384614e146062ef16c15b44dae306


Avoid manual table headers?

Hi,
Great package! I noticed in your templates you are manually typing the table headers in the
 tags. Is there a way to avoid that and manually get them from the database table?
Thanks
Saurabh

If I'm understanding your question correctly, I think this is more of a question for datatables, but columns.title option (https://datatables.net/reference/option/columns.title) can be used so all you have to do is create the

 and datatables will fill in the headers.


Synchronize layer2+layer3 guards when using OnionBalance

This script should be compatible with OnionBalance. However, because multiple instances of this script do not communicate through OnionBalance, each additional instance of this script will choose different vanguards. This increases the overall exposure to guard discovery attacks, because more vanguards are in use. In cases where it is just as bad for the adversary to discover any of your onion service instances as it is to discover all of them, then obviously each additional instance lowers your security a bit.
This integration will be complicated and will require design changes on behalf of both components.

I am working on a change that allows you to disable active vanguards updates. With this, OnionBalance users can have a single parent service instance that updates vanguards, and then their child services can disable vanguards. The state file from the parent can then be scp'd over to the children once per hour, and the children can call vanguards with 'vanguards --one_shot_vanguards --state_file copied.state' upon copy. This will sync the vanguards of the children.
The children can still use a separate live vanguard process with live vanguard updates disabled, but with bandguards and rendguard operating with a different state file. That way they get the layer2 and layer3 updates from the parent (via a different state file and one_shot update), and the live instance can monitor RP use and side channel activity on a separate state file, without rotating their layer2 and layer3 guards.
It will require an ugly pile of scp + ssh shell scripts to do this, but it will at least be possible to do without reducing guard discovery security.

We have a hackish way to do this documented in https://github.com/mikeperry-tor/vanguards/blob/master/README_SECURITY.md#how-to-onionbalance

I'm going to close this since we have a hack to make this work, and no one is maintaining onionbalance at the moment anyhow.


[IMAGING-194] Enable Imaging to read TIFF files that use JPEG compression

This pull request enables Imaging to read TIFF files that use the JPEG compression as defined in "Adobe Photoshop(R) TIFF Technical Notes, March 22, 2002".   This enhancement does not support the obsolete JPEG variation that was in use before 2002.
Additional sample files were added to support JUnit testing.
As you review the code changes, you will notice a large block of code that appears to be deleted starting at line 499 in JpegDecoder.java.   I actually did not delete this code, but wrapped it up in a conditional block.  You can see it in its new position starting at line 569.

Codecov Report

Merging #334 (efadf21) into master (2399383) will increase coverage by 0.06%.
The diff coverage is 83.01%.

@@             Coverage Diff              @@
##             master     #334      +/-   ##
============================================
+ Coverage     71.18%   71.25%   +0.06%
- Complexity     3521     3541      +20
============================================
  Files           351      352       +1
  Lines         17292    17370      +78
  Branches       2668     2689      +21
============================================
+ Hits          12310    12377      +67
- Misses         3930     3931       +1
- Partials       1052     1062      +10

Files
Coverage Δ

...ing/formats/tiff/datareaders/DataReaderStrips.java
93.37% <80.00%> (-0.82%)
:arrow_down:

...ging/formats/tiff/datareaders/DataReaderTiled.java
94.64% <71.42%> (-1.04%)
:arrow_down:

...mons/imaging/formats/jpeg/decoder/JpegDecoder.java
90.87% <88.52%> (-0.67%)
:arrow_down:

.../formats/tiff/datareaders/DataInterpreterJpeg.java
75.00% <75.00%> (ø)

... and 2 files with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Gary,
Thanks for your comments which, as usual, were spot on.  I will address them as soon as I can.
I did have a question.  Some of the coverage results were not what I expected.  I was looking for an interface that would show me what lines of code were covered and which lines we not.  Maybe I just missed it.  Is one available? Is that feature open only to committers? Also, I did a search for this topic on the developers mailing list, but didn't find any discussion.

Hi @gwlucastrig
Yes, run: mvn clean site and  open target/site/jacoco/index.html: The site is generated with a JaCoCo report. There is probably a short-hand Maven invocation to create the coverage report instead of the whole site but I can't recall what it is off the top of my head.

Also, please rebase on git master, I moved the test data folder under resources and had to adjust some tests.

I am not particularly adept at git, and I can't figure out how to rebase (the rebase attempt fails and git complains that I have unstaged changes).  So I am going to scrap this pull request and start over.  I have already updated the code with your suggestions and will incorporate them into the next pull request.  I will also move the new test files under the new hierarchy.

Well, the "scrap it and start again" option is still available if we need it, but I attempted to rebase and push the changes your requested up to github.   If it didn't work, let me know.


Build failed on Ubuntu 24.04

Instructions To Reproduce the 🐛 Bug:

Full runnable code or full changes you made: nothing
What exact command you run:
mkdir /opt/vrs_Build && cd /opt/vrs_Build
cmake -DCMAKE_BUILD_TYPE=RELEASE -S /opt/vrs -G Ninja -Wno-dev
also try
cmake -S /opt/vrs -G Ninja
Full logs or other relevant observations:

-- External dependencies at /opt/vrs_Build/external
-- The CXX compiler identification is GNU 13.2.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- CMAKE_CXX_COMPILER: /usr/bin/c++
-- CMAKE_CXX_COMPILER_VERSION: 13.2.0
-- CCACHE enabled
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") found components: filesystem chrono date_time system thread
Cloning into '/opt/vrs_Build/external/rapidjson'...
-- Found RapidJson: /opt/vrs_Build/external/rapidjson
-- Found Lz4: /usr/lib/x86_64-linux-gnu/liblz4.so
-- Found Zstd: /usr/lib/x86_64-linux-gnu/libzstd.so
-- Found xxHash: /usr/lib/x86_64-linux-gnu/libxxhash.so
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.3")
-- Found PNG: /usr/lib/x86_64-linux-gnu/libpng.so (found version "1.6.43")
CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find JPEG (missing: JPEG_LIBRARY JPEG_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake-3.28/Modules/FindJPEG.cmake:106 (find_package_handle_standard_args)
  cmake/LibrariesSetup.cmake:34 (find_package)
  CMakeLists.txt:66 (include)

please simplify the steps as much as possible so they do not require
git clone, install tools and lib, cmake with error

Expected behavior:
compiling successfully

resolved by sudo apt install libjpeg-dev

Did you have libturbojpeg-dev installed?

Ubuntu 24.04 Minimal Server does not have libjpeg-dev by default

Thanks for your contribution, your code change is merged.


update toml

I'm not sure why none of the github actions ran on this. Looks like it's cause this is from a fork, so you're considered a first-time contributor: https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks
I'll see if I can have it run the actions.

Yeah, forking the repository was the recommended workflow before the refactoring. I'm not totally sure how to reset things on my machine so it's not working from the fork

Seems like I just need to add pull_request event for the on section of the github action: https://stackoverflow.com/questions/73314842/unable-to-trigger-github-actions-when-pull-request-comes-from-a-forked-repositor

Updated, and I also added a "tolerance" option to DieParameters that shrinks the pads to allow for MLA alignment error (which is inevitable, so accounting for it should be the default option)


Develop a single-bit read/write function

Inconsistency in _set_single_bit()

Type 'int' and 'bytearray' are not supported by _read_single_bit

Variable has uppercase


ebay sandbox vs. production differences to note

Although this is not a bug or an issue with either eBay or this SDK, I think the following 'gotchas' may be worth noting in the documentation somewhere.
listing size limit
With eBay's sandbox, there doesn't seem to be a listing size limit, or at least it's a lot higher than 90K.  Googling for eBay's listing size limit doesn't yield any results, but I think it's ~90K, which I read somewhere that escapes me.  So, if you plan on using something like Bootstrap and inlining it in your listing, you'll surpass this limit.  Instead, bring it in via <link>.
If you surpass the limit, eBay's error doesn't indicate that it's a filesize limit (!), so it may leave you perplexed in determining where the issue is.
phone numbers and emails in listings
With eBay's sandbox, you can list your email address and phone number, but you cannot with production.

I also believe sandbox doesn't recognize the set restocking fee.

There's a few things that the sandbox does not support. eBay have created a Knowledge Base article about this but I don't know how up to date it is.
I'm very reluctant to start documenting the sandbox limits or the difference between it and production.   This is more eBay's responsibility as they should know more than me.


[IQE]: Health Data Report File Stat metric for working set count is not consistent for new files when saved

Steps:

Launch Brackets
Create two new files
Open Health report (No count)
Save first file (Only 1 count)
Save second file (have 2 counts on second save total=3)

Result : Not consistent count metric

Lowering priority as creating a new file is a lower number than working on a file, so the distribution should be unaffected by this behavior over a large number of users.


Code samples missing from reactive-rest-service guide (Unresolved directive in  - include::complete/...)

In the code preview windows I only see text saying there was a problem including the file, like
Unresolved directive in <stdin> - include::complete/src/main/java/hello/GreetingRouter.java[]
I'm getting this in all code boxes, there's different file names in error messages.
example:

Looks OK to me. I think it was a stale cache.

Getting this same error
https://spring.io/guides/gs/reactive-rest-service/

Getting this same error
https://spring.io/guides/gs/reactive-rest-service/

Fixed again (cleared cache). There are some other errors, but unrelated.

Fixed again (cleared cache). There are some other errors, but unrelated.

Hey, it looks like issue happened again
https://spring.io/guides/gs/reactive-rest-service


I start docker and the explorer freezes

Ver: Windows 10
Steps:

I start "Docker for Windows.exe "

Issue:
the explorer (as in windows explorer or explorer.exe) just stops working
I still can use applications though. I am not using VirtualBox btw, alas I am using Hyper-V.
My computer has 8GB and an intel i5 if that helps.

"Docker for Windows" is a separate project and does not use the iso produced here.  This project is for the "Docker Toolbox" with docker-machine.  You'll probably want to file an issue over in their repo: https://github.com/docker/for-win/.


Update package from Bro to Zeek

I took a pass at making the package for Zeek instead of Bro. I renamed the files, renamed the functions, and updated most of the references in the documentation, except the repo names.

Will open new PR with changes.


adapt send2cgeo script to new map

The Greasemonkey script part of send2cgeo needs to be adapted to the new map and afterwards be put onto the server.

I've fixed the script and issued a pull-request.

Thanks a lot, looks good in my browser again.

Is the new script public on the hp?
Cause I think there is the old version with still "beta" in the map-string

I've checked the web site this morning.
The script is not there yet.
I'll create another issue to upload the script to the web site.


GUI click on URL to open in VLC

When a camera is accessed successfully, it would be nice to be able to click the URL to open it directly in VLC.

This issue was moved to EtixLabs/cameradar-app#1


Media preview in admin UI list doesn't fallback to original size with plugin-cloud-storage

Link to reproduction

Describe the Bug
If I use the plugin plugin-cloud-storage in the media list I can't see the thumbnail for images smaller than the crop I chose in the configuration.
To Reproduce

Setup in the collection media the upload.imageSizes and the upload.adminThumbnail props
upload an image smaller than the upload.adminThumbnail size
open the collection media list in the admin ui
the system try to show the crop of the upload.adminThumbnail despite it doesn't exist

The config is the following
const Media: CollectionConfig = {
	slug: "media",
	admin: {
		group: "Media",
	},
	fields: [
		{
			name: "title",
			label: {
				it: "Titolo",
				en: "Title",
			},
			type: "text",
			localized: true,
		}
	],
	upload: {
		staticDir: path.resolve(__dirname, "../../media"),
		imageSizes: [
			{
				name: "squareSmall",
				width: 480,
				height: 480,
				position: "centre",
			},
			{
				name: "squareMedium",
				width: 900,
				height: 900,
				position: "centre",
			}
		],
		adminThumbnail: "squareSmall",
		mimeTypes: ["image/*", "application/pdf"],
	},
};

The cloud storage plugin config
cloudStorage({
    collections: {
        media: {
            adapter: s3adapter,
            disablePayloadAccessControl: true,
            prefix: process.env.S3_PREFIX_MEDIA,
            generateFileURL: ({ collection, filename, prefix, size }) => {
                if (!filename) return null;
                const folderPrefix = prefix ? `${prefix}/` : "";
                return `${process.env.S3_ENDPOINT_ORIGIN}/${folderPrefix}${filename}`;
            },
        },
    },
})

The workaround I found is to declare the upload.adminThumbnail property as function that check if the doc property of the crop exists. I expected this behaviour as default because it's the default without the plugin.
adminThumbnail: ({ doc }) => {
	return media.sizes.squareSmall.url || media.url;
}

Payload Version
2.3.1
Adapters and Plugins
	"@payloadcms/bundler-webpack": "1.0.5", 		"@payloadcms/db-mongodb": "1.1.0", 		"@payloadcms/plugin-cloud-storage": "1.1.1", 		"@payloadcms/plugin-form-builder": "1.0.15", 		"@payloadcms/plugin-nested-docs": "1.0.9", 		"@payloadcms/plugin-seo": "1.0.15", 		"@payloadcms/richtext-lexical": "0.3.1", 		"@payloadcms/richtext-slate": "1.2.1",

Hey @matteo-naif nice catch, this has been fixed and will be out in our next release. Thanks for raising this!


Retrieve Subject and Queue

This is based pretty closely to the project retrieval with the addition of the queue. There might be some intrinsic changes that need to be made, as this is the second time I've used Redux, so I'm open to suggestions.
Working through this, there should also be a subject location reader helper method, similar to what exists in PFE. I might push this up in another commit, but if you review this before that commit, feel free to merge and I'll add the addition in another PR.

Also, the Yarn error appears similar to what you were experiencing in a recent PR, so the Yarn issue is still outstanding.

Ok, I wrote a little helper method and then realized afterwards we might not have any multi-image subjects! However, this should also work well to check images contain compatible extensions and also make it cleaner to get the source of a subject. There could possibly be a more succinct way to write that method.

I've temporarily disabled Travis checks on liberating-the-liberator while we figure out the yarn issues.
PR checks are ongoing, but what I'm seeing so far LGTM! The only thing I'm still digesting is the structure of our helper methods.

@shaunanoordin I think this might be relevant https://kb.heroku.com/why-is-my-node-js-build-failing-because-of-conflicting-lock-files
As per a Slack convo, the issues people were facing with Travis were caused by running yarn and npm commands, which generated confusion in Travis. Also I believe we're actually moving away from Yarn. SO I'd say it's safe to remove yarn.lock and add a package-lock.json. I've done so in Pandora and Travis is running fine.

Yarn is still really new and basically npm implemented in version 5 one of the major differences, lock files, between it and npm . We never really had enough time to implement yarn for a project that's made it to production. I'm of the opinion that we should drop our experimenting with yarn since npm can pretty much do what what yarn does now and is more stable with existing feature sets (yarn was buggy with many standard npm features).


fix(NetworkBehaviour): removing NB that belong to another NI from list

If there are Nested NetworkBehaviours and NetworkIdentity then there can be a problem where the parent NetworkIdentity will find Behaviour that belong to another child NetworkIdentity.
This will remove those NB from the current NI's array and then resize the array to be the correct size
fixes: #973

I'll make a test to check the speed of this code vs the LINQ version proposed in #1006 (in this comment).
P.S. Please let me know if such things need a new issue opened or if something else has to be done differently, I'm fairly new here.

@James-Frowen So I made a prefab with NI, which has 100 nested NIs inside it. Each NI, included the root one, has 100 NetworkTransforms under it. Which totals at 100100 NBs.
Added LINQ code from #1006 and Array code from #970 to NI, and an enum field to set the test mode. Test script:

Spawns prefab with nested NIs.
Sets test mode on the root NI.
Initializes root NI using _ = rootIdentity.NetworkBehaviours;
Initialization speed is logged into conole.
Destroy the object, repeat with Array.
I also added an alternative method using List.

Note: the results fluctuate a bit between runs and sometimes LINQ takes ~1 ms longer, becoming slower than Array. Given that the difference is marginal, I suggest we use the LINQ version, because it's readability in much better.
@James-Frowen I can push the modified NI to the branch of #1006 and provide unitypackage with the prefab, so you can test it. All test code is in a separate #region, so it will be easy to remove it after.

we need to be careful with GC/alloc here too because that could cause performance problem too.
Ideally we have the default case (where there is no child NI) to not allocate so it wont effect anything in existing projects.  But I'm not sure if there is a way to have it not allocate when there is child NI.
I might be overthinking all this tho, and maybe it wont matter either way

we need to be careful with GC/alloc here too because that could cause performance problem too.

From the top of my head, with the LINQ solution there are 2 places where allocations happen:

GetComponentsInChildren() when we look for child NBs. This can be mitigated by having a pre-allocated static List<NetworkBehaviour> which will serve as a cache that we pass to GetComponentsInChildren() (same as I do in code for Unity 2019 in #1006). This will avoid allocations if the number of child NBs does not exceed the original array's size. What should the default size be in this case?
LINQ call, the result of which gets assigned to networkBehaviours cache array. However, it gets allocated anyway when NetworkBehaviours property is initialized, even with no NIs. So maybe not a big deal for now?

Static list passed into GetComponentsInChildren sounds promising. Doing .toArray() after should be fine because we are keeping the array anyway.
I think .Where itself allocates so we'll have to check that vs a loop calling remove on the list

.Where does indeed allocate. I have combined your logic with a cached List and tested the performance, it is now as fast as LINQ implementation, but without extra allocation that came from .Where.
The changed parts look something like this:
// cache list to call GetComponentsInChildren() with no allocations
private static List<NetworkBehaviour> ChildNetworkBehavioursCache = new List<NetworkBehaviour>(1024);

private NetworkBehaviour[] FilterChildNetworkBehaviours()
{
    int linkedNetworkBehaviourIndex = 0;
    for (int r = 0; r < ChildNetworkBehavioursCache.Count; r++)
    {
        var item = ChildNetworkBehavioursCache[r];
        if (item.Identity != this) continue;

        ChildNetworkBehavioursCache[linkedNetworkBehaviourIndex] = item;
        linkedNetworkBehaviourIndex++;
    }

    // copy part of the list containing linked NBs to a new array
    int linkedNetworkBehavioursCount = linkedNetworkBehaviourIndex;
    Debug.Log(linkedNetworkBehavioursCount);
    var components = new NetworkBehaviour[linkedNetworkBehavioursCount];
    ChildNetworkBehavioursCache.CopyTo(0, components, 0, linkedNetworkBehavioursCount);

    return components;
}

I have already pushed it to the new branch in my fork, so I will create a new PR tomorrow and reference this PR in there.

I've managed to benchmark these 2 options
[BenchmarkMethod(name: "List removeAt", description: "2: no gc")]
private NetworkBehaviour[] FindBehaviourForThisIdentity2()
{
    GetComponentsInChildren<NetworkBehaviour>(true, childNetworkBehavioursCache);

    // start at last so we can remove from end of array instead of start
    for (int i = childNetworkBehavioursCache.Count - 1; i >= 0; i--)
    {
        NetworkBehaviour item = childNetworkBehavioursCache[i];
        if (item.Identity != this)
        {
            childNetworkBehavioursCache.RemoveAt(i);
        }
    }

    return childNetworkBehavioursCache.ToArray();
}

[BenchmarkMethod(name: "List move copy", description: "4: no gc")]
private NetworkBehaviour[] FindBehaviourForThisIdentity4()
{
    GetComponentsInChildren<NetworkBehaviour>(true, childNetworkBehavioursCache);

    // keep track of read and write index
    // if we find a NB that belongs to another NI then we set it to null
    // then if any have been set to null we shift the remaining NB down to the write index as we continue the loop
    // after the loop we resize the array if we have removed any
    int write = 0;
    for (int read = 0; read < childNetworkBehavioursCache.Count; read++)
    {
        NetworkBehaviour item = childNetworkBehavioursCache[read];
        // if not this identity then skip
        if (item.Identity != this)
            continue;

        // write item to start of array, this is so that if one is skipped all kept ones are on low end of array
        childNetworkBehavioursCache[write] = item;
        write++;
    }

    var temp = new NetworkBehaviour[write];
    childNetworkBehavioursCache.CopyTo(0, temp, 0, write);
    return temp;
}

Results

Name
Description
Category
Mean
Ratio
StdDev
StdError
min
max

List move copy
4: no gc

2.033 us

2.316 us
0.073 us
1.435 us
18.080 us

List removeAt
2: no gc

2.097 us

2.578 us
0.082 us
1.400 us
19.895 us

they seems to be mostly the same for performance (probably because the StdDev is so high)
I'm probably going to go with the RemoveAt one because it looks simpler


Healthcheck endpoint for load balancer

Describe the feature
I've been digging around looking for an endpoint to use as a health check for my load balancer.
Does this exist?
Expected interaction
A simple endpoint that returns a 200 response indicating the server is up and running
Additional context
Background:
I'm deploying this as a Fargate service in AWS and putting the service behind a load balancer. AWS needs a path the load balancer can ping frequently to ensure the service is up and running.

Ah looks like this exists just on a different port?
localhost:5001//livez looks to be what I'm looking for. Is that the intention of this endpoint?

Hey @jcity I'm glad you've found it, yes, that is the endpoint you should use 👍
There's also /readyz for checking if the authentication is successful. /livez just indicates that it is up and running.

Great, thanks for the response!
I just got everything deployed in an AWS Fargate container. The other thing I had to do to get this to work was add a custom conf.yaml file and add an IP (wildcard) to the allow list.
Anything else you can think of that I might run into? Figuring out a 2FA solution is coming soon 🙃

Nice, well done!
2FA indeed may be the next step. Try to see if you can get SMS 2FA from IBKR and then use Google Messages. There's a guide for it in the Wiki: https://github.com/Voyz/ibeam/wiki/Two-Factor-Authentication#google-messages-handler

I'm going to close this issue due to inactivity. Thanks for your contribution and please feel free to request a reopen if you'd like to continue the discussion 👍