Can't launch vulkano examples with RenderDoc

Version of vulkano: 0.19.0
OS: Gentoo Linux amd64
GPU (the selected PhysicalDevice): GeForce GTX 1060 6GB
GPU Driver: NVIDIA Accelerated Graphics Driver (Version 450.66)
Upload of a reasonably minimal complete main.rs file that demonstrates the issue: triangle in the examples or just the minimal example code
RenderDoc Version: 1.10

Minimal Example Code
use std::sync::Arc;
use vulkano::device::Features;
use vulkano::device::{Device, DeviceExtensions};
use vulkano::instance::InstanceExtensions;
use vulkano::instance::{Instance, PhysicalDevice};

fn main() {
    let instance = Instance::new(None, &InstanceExtensions::none(), None).unwrap();
    let physical = PhysicalDevice::enumerate(&instance).next().unwrap();

    let queue_family = physical.queue_families().next().unwrap();

    let (device, mut queues) = Device::new(
        physical,
        &Features::none(),
        &DeviceExtensions::none(),
        [(queue_family, 1.0)].iter().cloned(),
    )
    .unwrap();
}

Issue
I'm trying to launch the 'triangle' example with RenderDoc, but it crashes.
Here is the RenderDoc diagnostic log: renderdoc-triangle.log
And the program output: thread 'main' panicked at 'called Result::unwrap() on an Err value: FeatureNotPresent', src/bin/triangle.rs:141:6
I don't understand why the error is FeatureNotPresent as it indicates that a feature was requested that is not supported, but that seems not to be the case. The error still occurs when I change physical.supported_features() to &Features::none().
The same behavior occurs when I just add the "VK_LAYER_RENDERDOC_Capture" validation layer instead of launching the app with RenderDoc.
I also tried to launch the hello_triangle example from the Vulkan Samples (https://github.com/KhronosGroup/Vulkan-Samples) to test whether my vulkan installation is the problem, but it worked without problems.
Maybe this is a bug in vulkano's device creation process?
EDIT:
After more investigation I found (using vulkaninfo) that bufferDeviceAddressCaptureReplay = false.
RenderDoc produces warnings about this (VkPhysicalDeviceBufferDeviceAddressFeaturesEXT.bufferDeviceAddressCaptureReplay is false, can't support capture of VK_EXT_buffer_device_address) but ONLY when using vulkano. The VulkanSample hello_triangle doesn't produce these warnings which seems strange to me.
Another EDIT:
Found out what caused the device creation failure. In the device module exists this code
            let infos = vk::DeviceCreateInfo {
                sType: vk::STRUCTURE_TYPE_DEVICE_CREATE_INFO,
                pNext: features.base_ptr() as *const _,
                flags: 0, // reserved
                queueCreateInfoCount: queues.len() as u32,
                pQueueCreateInfos: queues.as_ptr(),
                enabledLayerCount: layers_ptr.len() as u32,
                ppEnabledLayerNames: layers_ptr.as_ptr(),
                enabledExtensionCount: extensions_list.len() as u32,
                ppEnabledExtensionNames: extensions_list.as_ptr(),
                pEnabledFeatures: ptr::null(),
            };

which sets pNext instead of pEnabledFeatures.
When I set pNext to ptr::null(), RenderDoc can successfully launch the app.
So the issue seems to be that RenderDoc can't handle more advanced physical device features.
But I still get this warning: VkPhysicalDeviceBufferDeviceAddressFeaturesEXT.bufferDeviceAddressCaptureReplay is false, can't support capture of VK_EXT_buffer_device_address

Ok, so baldurk helped me to find the cause of the problem.
Here is a code snipped with macros expanded from the FeaturesFfi constructor:
        #[inline(always)]
        pub(crate) fn new() -> Pin<Box<Self>> {
            #![allow(unused_assignments)]
            let this = FeaturesFfi {
                _pinned: PhantomPinned,
                main: vk::PhysicalDeviceFeatures2KHR {
                    sType: vk::STRUCTURE_TYPE_PHYSICAL_DEVICE_FEATURES_2_KHR,
                    pNext: ptr::null(),
                    features: unsafe { mem::zeroed() },
                },
                ..unsafe { mem::zeroed() }
            };
            let mut this = Box::pin(this);
            unsafe {
                let this = this.as_mut();
                let this = this.get_unchecked_mut();
                let mut base = &mut this.main as *mut _ as *mut Base;
                {
                    this.phys_dev_buf_addr.sType =
                        vk::STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_ADDRESS_FEATURES_EXT;
                    let next = &mut this.phys_dev_buf_addr as *mut _ as *mut Base;
                    (&mut *base).pNext = next;
                    base = next;
                };
                {
                    this.variable_pointers.sType =
                        vk::STRUCTURE_TYPE_PHYSICAL_DEVICE_VARIABLE_POINTERS_FEATURES;
                    let next = &mut this.variable_pointers as *mut _ as *mut Base;
                    (&mut *base).pNext = next;
                    base = next;
                };
                {
                    this.shader_atomic_i64.sType =
                        vk::STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_ATOMIC_INT64_FEATURES;
                    let next = &mut this.shader_atomic_i64 as *mut _ as *mut Base;
                    (&mut *base).pNext = next;
                    base = next;
                };
                {
                    this.i8_storage.sType =
                        vk::STRUCTURE_TYPE_PHYSICAL_DEVICE_8BIT_STORAGE_FEATURES;
                    let next = &mut this.i8_storage as *mut _ as *mut Base;
                    (&mut *base).pNext = next;
                    base = next;
                };
                {
                    this.i16_storage.sType =
                        vk::STRUCTURE_TYPE_PHYSICAL_DEVICE_16BIT_STORAGE_FEATURES;
                    let next = &mut this.i16_storage as *mut _ as *mut Base;
                    (&mut *base).pNext = next;
                    base = next;
                };
                {
                    this.f16_i8.sType =
                        vk::STRUCTURE_TYPE_PHYSICAL_DEVICE_SHADER_FLOAT16_INT8_FEATURES;
                    let next = &mut this.f16_i8 as *mut _ as *mut Base;
                    (&mut *base).pNext = next;
                    base = next;
                };
            }
            this
        }

The feature extension chain is always build.
But it seems that you need to enable the device extension VK_KHR_buffer_device_address to be able to use STRUCTURE_TYPE_PHYSICAL_DEVICE_BUFFER_ADDRESS_FEATURES_EXT. But this device extension isn't enabled anywhere.
Thats why I get a FeatureNotPresent error only when using it with RenderDoc.
Normally, VK_KHR_buffer_device_address is supported but with RenderDoc it is not!
When I modify Vulkano to enable the VK_KHR_buffer_device_address device extension, my app detects that this extension is not supported before trying to create the device.
So if I didn't misunderstand anything, this really is a bug in the Vulkano device creation process.
It could be fixed if the device creation feature chain only contains the supported extensions and not all.

But this seems like an extensive fix and I'm not confident enough to do it myself.

I could take a look at it after work possibly.
On Sep 23, 2020, 10:32 AM, at 10:32 AM, michadaniel<EMAIL_ADDRESS>wrote:

But this seems like an extensive fix and I'm not confident enough to do
it myself.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/vulkano-rs/vulkano/issues/1416#issuecomment-697550037

i just ran into this issue as well. passing Features::none() is a workaround for now (i don't need any extension features in my program) but it's definitely a problem that vulkano is querying for unsupported extension features.


fix(docs): Fela and fontAwesome classes conflict

fix(docs): Fela and fontAwesome classes conflict
Fixes #950
Fix is proposed by @rofrischmann (creator of Fela) here
Downside:
The prefix is added to all class names:

EDIT:
Alternative to #951

What about #951?

@miroslavstastny haha, let's vote? 😆

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS

closing in favor of #951


Calculation of indexOfQuery incorrect

https://github.com/peerigon/extract-loader/blob/fb7139af56bb9b61fa6779257b33857b28446ef3/src/extractLoader.js#L93-L95
Shouldn't this be Math.min not Math.max? Otherwise we might as well write:
const indexOfQuery = givenRelativePath.length;

I've rolled back to 2.0.1 in order to use oneOf/resourceQuery in webpack config until this is fixed.

I'm also having issues with this bug.

const relativePathWithoutQuery = givenRelativePath.replace(/(\S+)(?:?\S+)/,"$1");

I've open a PR to solve this issue, is anyone able to review and push it through?


Any issues with using exec.Cmd inside a Go plugin?

Wondering what the implications might be using exec.Cmd inside a bespoke plugin to execute another program.  In my case, I want to write a plugin which processes XSLT against a legacy XML web service to transform the response body.  I was able to do this with a JavaScript plugin, but was able to find an npm module which was easy to use in my code.  There doesn't seem to be a comparably simple Go library to do similar (at least not that I could find), but one example I did come across was using Go to call the xlstproc executable (passing the XSLT and XML as file objects) and capture what that produces to stdout.
But I wasn't sure whether trying to do this in the context of a Kong plugin would create issues in the flow of processing an API request, so curious if anyone else has attempted it.

try it!  the whole idea of Go plugins is to be able to use the Go ecosystem.  Especially with the embedded server (and not the go-pluginserver), each plugin is a completely "standard" Go process.  No idea how it would affect latency, of course...

try it! the whole idea of Go plugins is to be able to use the Go ecosystem. ... No idea how it would affect latency, of course...

Fair enough, will give it a shot. :-) To clarify ...

Especially with the embedded server (and not the go-pluginserver), each plugin is a completely "standard" Go process.

I've really just begun looking at the Go PDK, so I assume this is to what you're referring?

I assume this is to what you're referring?

yep!

Thanks for the replies.  If I'm successful, I'll try to post something back.


Issue_9

The report for this issue is in "Security Bug" Folder with txt file name Issue9.txt which contains doc file link of this report.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Sodium - dont use cull face on faces that are still visible

shouldn't affect vanilla negatively, vanilla is just more resistant to using cull face on faces that shouldn't have it.

Thank you for the PR!


Recover from errors in Go_xxfi_connect() & make gobencode optional in setpriv

Recover from errors in Go_xxfi_connect()
There appears to be a race condition in libmilter in which
hostaddr is set to nil before or while calling the connect
callback if the client aborts its connection during that
window.
Make gobencode() optional in SetPriv(), return errors instead of integers

All my testing was successful, but once again some issues on production.
=> Closing for now


others(ios): extract hardcoded url

Issue Link :link:
Refactor code under iOS test project
Goals :soccer:

Reducing Maintenance Cost by better folder structures
Implementation Details :construction:

Extract hardcoded urls and util functions
Testing Details :mag:
N/A

Thanks for the PR! However, the sample app needs a much larger rewrite, and these changes are fairly low value, so I won't be accepting them.


Multi-cluster namespaces are sometimes not deleted in joined clusters

If you run through the Example in the user guide after #157 merges, you will see that after running through the Example Cleanup, the test-namespace is sometimes not deleted from cluster2.

@font Can you still reproduce this?  Namespace garbage collection is often problematic and it would be useful to determine the source of the problem.

Closing as this has since been fixed.


Add a new plugin ishell for Jenkins job

This plugin was released. See also https://github.com/jenkins-zh/jcli-ishell-plugin/releases/tag/v0.0.1


lua ascii

Hi,
I've just packaged onefetch for NetBSD and pushed it into the main repo.
I've just realized, how ridiculously huge the lua ascii is. No big deal but, maybe something to consider for future releases.

Thanks for bringing this up! We'll discuss this in #105 :slightly_smiling_face:

As mentioned on reddit, no problem :)
The package is now in the main repo and should be available as a binary by the next bulk-build.
It was problem free, no patches and no hick-ups.


"helm completion" command sends warnings, and possibly errors to STDOUT

"helm completion" command (ex. "helm completion bash") sends warning messages and probably errors to STDOUT instead of STDERR.  This leads to the output containing the warning and sourcing into the running shell throws errors.
How to reproduce: Make your ~/.kube/config file group readable, then run "helm completion bash | head -n 10".
Example:
$ helm completion bash | head -n 10
WARNING: Kubernetes configuration file is group-readable. This is insecure. Location: /home/redacted/.kube/config
# bash completion for helm                                 -*- shell-script -*-

__helm_debug()
{
    if [[ -n ${BASH_COMP_DEBUG_FILE} ]]; then
        echo "$*" >> "${BASH_COMP_DEBUG_FILE}"
    fi
}

...leading to:
$ source <(helm completion bash)
-bash: WARNING:: command not found

Please send warnings and errors to STDERR.

Output of helm version:
version.BuildInfo{Version:"v3.3.3", GitCommit:"55e3ca022e40fe200fbc855938995f40b2a68ce0", GitTreeState:"clean", GoVersion:"go1.14.9"}
Output of kubectl version:
lient Version: version.Info{Major:"1", Minor:"17+", GitVersion:"v1.17.7-eks-bffbac", GitCommit:"bffbacfd13a805a12d10ccc0ca26205ae1ca76e9", GitTreeState:"clean", BuildDate:"2020-07-08T18:30:00Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"17+", GitVersion:"v1.17.9-eks-4c6976", GitCommit:"4c6976793196d70bc5cd29d56ce5440c9473648e", GitTreeState:"clean", BuildDate:"2020-07-17T18:46:04Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Cloud Provider/Platform (AKS, GKE, Minikube etc.):

Note that this prevents -oyaml from producing valid yaml.

Please see #8779 for the fix.
Closing as a duplicate of #8776.


Add gdf/shp/geojson support for plotly

This feature allows creating plotly maps from vector data with one line of code.

import leafmap.plotlymap as leafmap

m = leafmap.Map()
url = 'https://github.com/giswqs/data/raw/main/us/us_states.geojson'
m.add_gdf(url, color_col='name')
m


Assignment 3

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Answered assignment 3 about clustering and resampling.
What did you learn from the changes you have made?
Plotting, K-means clustering, Elbow method, and Boot strapping
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
None for this assignment
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Extracting a column to a data frame so I can use it in the code. I've researched on the most easiest way to do that
How were these changes tested?
Trial and error
A reference to a related issue in your repository (if applicable)
Memory leak issue that was solved by following this: https://stackoverflow.com/questions/69596239/how-to-avoid-memory-leak-when-dealing-with-kmeans-for-example-in-this-code-i-am
Checklist

[x] I can confirm that my changes are working as intended

A3 complete


Improve less-than comparison between arrays

It appears that the issue is simply caused by the misuse of element dereference.
Also included some relevant test cases.
Bugsquad edit: This closes #39299.

Thanks for opening a pull request!
Please amend the commit to use a human-readable commit message. This way, people reading the Git log can easily figure out what's going on.

Tests should go in the tests folder.

The tests never compiled and weren't fixed so closing.
The bug actually seems to be fixed in 4.0 already though the code is still the same. For 3.x I can still reproduce the issue so this might still be relevant to salvage, though I don't understand why this fix changes the behavior.


Open stdin write side in shim

This ensures that the stdin fifo always has a write side open in the shim
Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

LGTM

The problem with previous implementation is that after writer (docker / containerd-CRI-shim) dies, the shim will close the STDIN pipe, because there is no writer open. Then we can't reconnect the STDIN any more.
This fix resolved the issue, but introduced another problem: How to disable STDIN? How to implement StdinOnce.
When STDIN is disabled, should we really make sure shim close the STDIN pipe? Or should shim still keep STDIN pipe open, and let the upper system (docker / containerd-CRI-shim) reject further STDIN?
What is the expected behavior?

Since we have a hold of the fifo fds, we can implement an API for stdinonce by both copies of stdin

Since we have a hold of the fifo fds, we can implement an API for stdinonce by both copies of stdin

So previous containerd has this api, right? https://github.com/docker/docker/blob/master/libcontainerd/process_unix.go#L82-L86

Yes, we can add the same api.  I have not clue how, when, and why its used.  its been in docker since before my time and was originally added to work around other limitations of the system at the time.
@mlaventure @tonistiigi can you remember what this is still being used for today?  stdin-once?

@crosbymichael Even for simply disable STDIN of a container (which is much more common than stdin-once), we could not achieve that after this fix is merged, right?
If I pass-in an empty STDIN fifo path, I believe containerd will report error.
If I pass-in a working fifo path, there is no way to close it, because the shim will always hold it open. Should I remove the fifo after creating the container? Is that safe?

@Random-Liu i pushed a fix to handle STDIN not being provided

LGTM. Thanks for the fix.
I'll create a separate issue for stdin-once. :)

@crosbymichael I actually never understood why we open STDIN even when not requested.
@Random-Liu what is the use case for StdinOnce?

@Random-Liu what is the use case for StdinOnce?

Based on my understanding, people use stdin to pass some initial data into the container, and they don't want to keep the stdin open after the initialization.
See https://github.com/kubernetes/kubernetes/issues/23335#issuecomment-201241191 and https://github.com/kubernetes/kubernetes/issues/1521#issuecomment-58287495.

I see. in that case a CloseStdin API  would be better than a config flag. This would take in account a case where your program crash, fails or get killed before sending the rest of the input data and allow it to send the rest later.

I see. in that case a CloseStdin API would be better than a config flag. This would take in account a case where your program crash, fails or get killed before sending the rest of the input data and allow it to send the rest later.

Hm, that's true. A CloseStdin API will be more flexible and reliable than the StdinOnce config. However, it takes time to change our API.
Anyway, no matter we use StdinOnce flag or CloseStdin API, we need to close the stdin at some point after container is started. :)


[Feature]: Make URIs generated during development configurable

What area(s) will this request affect?
App, Running your code locally
What type of change do you want to see?
Substantial change to existing feature
Overview
When running 'dev' the cli updates the App URLs with the new ngrok tunnel URL. My app has non-standard suffixes so I always have to edit the URLs in the Partners App setup page. It would be nice if you could configure the suffixes in shopify.web.toml. As a bonus, the installation URL and the app-proxy URLs could also be configurable. Here's an idea of how the config could look like:
`
type="frontend"
[commands]
dev = "npm run dev"
build = "npm install --force"
[dev]
redirect_uris = ['/offline/callback', '/online/callback']
root_uri = '/toplevel'
proxy_uri = '/app-proxy/'
`
Motivation
Every time your run dev the URLs are updated. If the app uses non-standard URLs you need to update them manually in the partners dashboard. It slows down development.

You can use the --no-update flag to stop the urls updating in the shopify app setup dashboard

Hi @darfire -- thanks for sharing your idea! Very timely, as we are looking generally at URL updating right now in fact, so will add your feedback to your conversation.
In the meantime, @watzing comment is a good steer, plus probably using the --tunnel-url option to keep your URLs consistent over time by providing your own tunnel.
Can I ask what language/framework/etc. you're using to build your app? Am curious if those URLs are a default from some technology, or of your own choice.

On board with doing this - adding this to our backlog. I don't think we automatically update the app proxy URL though, so this would primarily just be for the top-level app URL and the redirect URLs.

We've added a prompt that you might have seen in dev. We now give you the choice to have URLs manually or automatically updated (https://github.com/Shopify/cli/blob/c1fa9ea0d9855832c25f5ed8d4dd5b94179909c5/packages/app/src/cli/prompts/dev.ts#L144 ) -- for your use case I recommend manual. Hope this helps!


Security Example Updates for General Use

The security example and files is specific to Keyolk,  and should be made generic.
(e.g. namespace, quay.io images, etc).

@joejulian @coffeepac Can I do an overhaul of this to have it refer to this instead? The config in this is seriously out of date.

https://github.com/samsung-cnct/k2/pull/723


Hotfix/amendments from testing

As discussed used CPP to test the library, had to change support to details in a few areas on the library side.

You have done some sort of find and replace across the library, which has ruined most of the code.
This needs reverting and doing again, without changing every detail to "details".


Use !interactive instead of argc > 1 in dosinst.c

Since code below uses if(interactive), using if(!interactive ...) is more coherent and intuitive than argc > 1.

It is used for checking if argv[1] is available. I think argc > 1 is more intuitive. (Not coherent, though.)

Hm, true. I did not think about it like this.


Ability to customize emails

Of what I understand this isn't supported yet? Would it be enough to follow this or would other steps/methods be required?

I am not sure I understand what you mean by customising emails?
Do you mean whitelisting emails domain that are allowed to register? If it's that, it is supported.
If not what page are you referring to?

I mean the emails that keycloak sends to users when they e.g. sign up and need to verify their email.

Ahh yeah of course, I see.
Yes this is probably something that we would like to support in the future but that is out of scope for now.

Note, however, that we will never be able to implement the emails in React, we can't bundle JS into emails.
If I provide a solution il will probably be using eta...

Thought about it a bit more. For our usecase we don't yet need full easy theming of the emails, being able to easily replace the "message" files at the same time as loading the rest of the theme would be enough. In our case it's keycloak/themes/customtheme/email/messages/messages_en.properties. It would be cool if we could put that in some folder of static files and then it would be inserted by keycloakify in the right location in the jar file :)

Agreed,
I put that in my todo list but i'll encourage you to implement an alternative solution in the meantime as I don't know when I will have the time to implement it.

Hi @Powersource,
How did you customize emails? Could you please share some insight?
TIA,
Syed

I did a hack to shove an email/ directory into the theme JAR by adding some commands in package.json:
"scripts": {
        "build": "react-scripts build",
        "keycloak": "yarn build && yarn emails && build-keycloak-theme && yarn emails2",
        "emails": "mkdir -p build_keycloak/src/main/resources/theme/THEME_NAME/email; cp -R email build_keycloak/src/main/resources/theme/THEME_NAME/",
        "emails2": "jar -uf ./build_keycloak/target/THEME_NAME-keycloak-theme-VERSION.jar -C . META-INF/keycloak-themes.json",
...

Both the email/ directory hierarchy and the keycloak-themes.json are just static files.
The only reason for the keycloak-themes overlay is to add "email" to the array of types so that it will show up as an entry in the drop-down.

It's done


chore(vuepress): tweaks main entry

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing Guidelines.
[ ] Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

[ ] Bug fix
[ ] New feature
[ ] Documentation update
[ ] Other

Description

Screenshots

Before
After

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 40.781%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
676

Relevant Lines:
1700

💛  - Coveralls


Add unit test v2 for login #80

Login unit test cases added. Cases are here:

renders Login component:
This test checks whether the Login component renders correctly when it's wrapped in a MemoryRouter. It expects that the text 'Welcome' should be present in the rendered component.

calls axios.post with correct credentials on form submission:
This test simulates a form submission by changing the values of the username and password fields and clicking the 'Login' button. It then asserts that the axios.post method is called with the correct parameters (username, password, and request configuration) when the form is submitted.

handles successful login:
This test checks the handling of a successful login scenario. It mocks the axios.post method to resolve with a status of 201 (simulating a successful login). The test then clicks the 'Login' button and waits for the asynchronous actions to complete.
It expects that the onLoginSuccess callback is called, the text 'Login successful!' is present in the component, and the 'Username' input field is not present in the DOM.

Yes I could run. Results are here for app.test.js and login.test.js (mine):
Test Suites: 2 failed, 2 total
Tests:       2 failed, 2 passed, 4 total
For login.test.js others are ok but this case is failed:
FAIL  src/pages/landing/Login.test.js
● Login component › handles successful login
expect(element).not.toBeInTheDocument()

expected document not to contain element, found <input aria-invalid="false" class="MuiInputBase-input MuiOutlinedInput-input css-1t8l2tu-MuiInputBase-input-MuiOutlinedInput-input" id="login-username" type="text" value="" /> instead

Yes I could run. Results are here for app.test.js and login.test.js (mine):
Test Suites: 2 failed, 2 total Tests: 2 failed, 2 passed, 4 total
For login.test.js others are ok but this case is failed:
FAIL src/pages/landing/Login.test.js ● Login component › handles successful login
expect(element).not.toBeInTheDocument()

expected document not to contain element, found <input aria-invalid="false" class="MuiInputBase-input MuiOutlinedInput-input css-1t8l2tu-MuiInputBase-input-MuiOutlinedInput-input" id="login-username" type="text" value="" /> instead

@aykutkantas hi,
afaik, all tests should be passed.

there is a fail at  app.test.js also. I think unit tests are working properly. For passing fail cases I needed to change something in login.js @ckertam. I will check for last fail case at login.test.js but we need to solve fail for app.test.js also.
FAIL  src/App.test.js
● Console
console.log
  Rendering Header

  at Header (src/components/header/header.js:33:11)

● renders learn react link
TestingLibraryElementError: Unable to find an element with the text: /learn react/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

@aykutkantas hi,
i ran
cd backend/frontend
npm install
npm run test

and i got this:

what should i do to overcome this warning?

if you want, we can look together on dc

@aykutkantas hi,
i ran
cd backend/frontend
npm install
npm run test

and i got this:

what should i do to overcome this warning?

Well, I could run within frontend container:

Then now, we may focus on all passed tests.

Great! Is it about that we don't give a message "Login successful" when a user logged in? @sadikkuzu
● Login component › handles successful login
Unable to find an element with the text: /Login successful/. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Login test is ok but app.test failed.

FAIL  src/App.test.js
● Console
console.log
  Rendering Header

  at Header (src/components/header/header.js:33:11)

● renders learn react link
TestingLibraryElementError: Unable to find an element with the text: /learn react/i. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

@aykutkantas hi,
As I mentioned above in https://github.com/SWE574-Fall2023-Group1/SWE574-Fall2023-G1/pull/254#pullrequestreview-1773861301
Could you please update backend/frontend/src/App.test.js file as below:
import { render, screen } from '@testing-library/react';
import App from './App';

test('renders register link', () => {
  render(<App />);
  const linkElement = screen.getByText(/register/i);
  expect(linkElement).toBeInTheDocument();
});

Ok, all passed. :)

Also resolved the conflicts that is caused by #266 that is done by @oguzsenna

@sadikkuzu @ckertam many thanks for your great support and guidance :)


Improve default chunk size

Default chunk sizes are chosen arbitrarily at the moment. We're current following sgkit's chunk_length=10_000, chunk_width=`1_000 (see here) but we can probably do a bit better than that

Actually this seems like a pretty reasonable choice, let's stick with it.


[otp_ctrl,dv] Add virtual to uncorr comp function

Closed source can generate uncorr data with different mechanism.
Make a separate function to override in closed source environment.

Since it's an otp PR maybe it's best @dkabely-ot will review it.


How to return GraphQL::Client::Response instead of ShopifyAPI::Clients::HttpResponse (v10+)

Issue summary
After upgrading to 11.1.0 (or any version after v10),  client.query to returns ShopifyAPI::Clients::HttpResponse  instead of GraphQL::Client::Response. This breaks all code in our projects. How do we get GraphQL::Client::Response instead of ShopifyAPI::Clients::HttpResponse?
Expected behavior
Receive data in GraphQL::Client::Response instead of ShopifyAPI::Clients::HttpResponse
Actual behavior
ShopifyAPI::Clients::HttpResponse is returned. Result is a hash and no way to get objects such as data and error. Is there a way to:

Call GraphQL::Client.query instead of ShopifyAPI's query, or
Pass the results ShopifyAPI::Clients::HttpResponse to GraphQL::Client to return GraphQL::Client::Response?

Steps to reproduce the problem
      ShopifyAPI::Auth::Session.temp(shop: account.shopify_domain, access_token: account.shopify_token) do |session|
        client = ShopifyAPI::Clients::Graphql::Admin.new(session: session)
        client.query(query: query, variables: variables)
      end

client.query returns ShopifyAPI::Clients::HttpResponse
Specifications

shopify_api version: 11.1.0
Shopify API version used (example: 2020-07): 2022-07

I'm having the same issue.


Fixes Dom.withoutTransition()

Related to https://github.com/callemall/material-ui/pull/1014
This makes the Dom.withoutTransition method behave the way its name suggests. It will now keep track of the original transition applied to an element, temporarily disable it, then put it back the way it was.

Thanks @rolandpoulter


authentication and authorization

Hello, sorry for this issue, but i need help, or maybe some tips:
i am use Netty for game server and client!
all found good!, but now i need integrate the login and the and protocol security!
Can i use Oauth2.0? I am familiar with working with oauth in php but in http requests, not if it can be integrated to tcp or udp!
for security I need buy a ssl certificated? in the example of securechat tthis say if a emulation of ssl!
in my localhost I use CassandraDB and the server make the conexion to Cassandra for campare the user and the password, but no its the best practice when deploy the server in the web,
i have to server, one for login, when the user login this switch the client to secondary server if to the game,
Sorry for my english and for this Issue

Please use stack overflow for questions. This is a issue tracker

Ok, Sorry


set BE in mysql?

when I login mysql and excute like ALTER SYSTEM ADD BACKEND "host:port";
throw error.
what is right way?
or
where can set BACKEND in Doris Web?

BE is start


[release-1.23] Backport user-provided CA cert and kubeadm bootstrap token support

Proposed Changes
Backport features:

https://github.com/k3s-io/k3s/pull/6615
https://github.com/k3s-io/k3s/pull/6663

Types of Changes
new feature
Verification
See linked issue and original PRs
Testing
Linked Issues

https://github.com/k3s-io/k3s/issues/6896
https://github.com/k3s-io/k3s/issues/6900

User-Facing Change
K3s now functions properly when the cluster CA certificates are signed by an existing root or intermediate CA. You can find a sample script for generating such certificates before K3s starts in the github repo at [contrib/util/certs.sh](https://github.com/k3s-io/k3s/blob/master/contrib/util/certs.sh).
K3s now supports `kubeadm` style join tokens. `k3s token create` now creates join token secrets, optionally with a limited TTL.
K3s agents joined with an expired or deleted token stay in the cluster using existing client certificates via the NodeAuthorization admission plugin, unless their Node object is deleted from the cluster.

Further Comments

arm flaked; merging


build(devtools): Bundle devtools-core symbols in devtools API via api-extractor

Bundling the exports via API-Extractor accomplished a couple of things:

It ensures that our exports from devtools are complete in terms of re-exports from devtools-core. E.g. if we re-export Foo from the other package, and Foo references Bar (also in the other package), then API-Extractor will enforce that we also re-export Bar.
It bubbles up generated API documentation such that API members appear as though they are native to the re-exporting package. This makes the API docs easier to navigate.

For more info, see here: https://api-extractor.com/pages/configs/api-extractor_json/#bundledpackages

Build failure is due to this bug: https://github.com/microsoft/rushstack/issues/3521. I was hoping it wouldn't be a problem here, but apparently it is. I'll come back to this later.


Fix overlaping |Stick Score and Time to outer div

Regarding #28
Hi,

[x] Fix Snake overlap with the Time Spent.
[x] Add Enhancement so thatTime Spent and Score to top.

Thank you

@amnindersingh12 still not #responsive and the snake js overlapping


fix allocation of data into the correct column

@ddove,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@ddove : Thanks for your contribution to the Azure documentation! The author, @srinia, has been notified to review your proposed change.

@srinia. Please review this contribution and sign off if you approve. Thanks.

#sign-off @ddove Debra make sure to submit your changes to the private repo next time so you can get them signed off.


App behaves differently before and after build

Is this a bug report?
Yes,
although it's probably not a bug of create-react-app but some package it uses
(I couldn't reproduce it with only webpack and babel and I don't have time to investigate further so I just post it here and I am sure you guys will figure it out :) )
Did you try recovering your dependencies?
Yes
Environment
System:
OS: Linux 4.15 Ubuntu 18.04.1 LTS (Bionic Beaver)
CPU: x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz
Binaries:
Node: 10.12.0 - ~/.nvm/versions/node/v10.12.0/bin/node
Yarn: 1.10.1 - /usr/bin/yarn
npm: 6.4.1 - ~/.nvm/versions/node/v10.12.0/bin/npm
Browsers:
Chrome: 70.0.3538.77
Firefox: 64.0
npmPackages:
react: ^16.6.3 => 16.6.3
react-dom: ^16.6.3 => 16.6.3
react-scripts: 2.1.1 => 2.1.1
npmGlobalPackages:
create-react-app: Not Found
Steps to Reproduce

npx create-react-app project-name

Remove all files in src folder and replace it with these:
(this is the minimal example I managed to come up with)

src/getMyConfig.js
export const myConstFun = () => null;

export const getMyConfig = () => ({
  arr: [myConstFun, ...[]]
});

src/index.js
import { getMyConfig } from "./getMyConfig";

let firstConstFun;
const checkConfig = getConfig => {
  const constFun = getConfig().arr[0];
  if (!firstConstFun) {
    firstConstFun = constFun;
    console.log("running checkConfig first time");
  } else {
    if (constFun === firstConstFun) console.log("constFun is same");
    else console.log("constFun has changed");
  }
};

checkConfig(getMyConfig);
checkConfig(getMyConfig);

yarn start
output in the console:
running checkConfig first time
constFun is same

yarn build and run
output in the console:
running checkConfig first time
constFun has changed

Expected Behavior
myConstFunc shouldn't be recreated every time getMyConfig is called.
Actual Behavior
It is.
This is the built app (main.chunk.js):
(window.webpackJsonp=window.webpackJsonp||[]).push([[0],[function(n,o,c){n.exports=c(1)},function(n,o,c){"use strict";c.r(o);var r,s=function(){return{arr:[function(){return null}].concat([])}},t=function(n){var o=n().arr[0];r?o===r?console.log("constFun is same"):console.log("constFun has changed"):(r=o,console.log("running checkConfig first time"))};t(s),t(s)}],[[0,1]]]);

The important part is:
s=function(){return{arr:[function(){return null}].concat([])}}

The myConstFun (function(){return null}) is inlined in the getMyConfig function although it shouldn't be, it should be created as a separate variable.
BTW, a real life scenario where this issue can cause problems (or at least this is how I ran into it):
In my project I am using a package that exports a function that gets getConfig as a parameter and fetches some data based on it. In the config, there is ref property and if it gets a ref that it's already seen, it uses cached data instead of fetching new ones. But in that case, it expects the whole config to be deeply equal. If it's not, it gets confused and throws.
Reproducible Demo
I didn't create a demo because I think the issue is easily reproducible with the "Steps to reproduce" above. If you have some problems reproducing the issue, I may create the demo later.

Hi @lukasbalaz, thanks for raising this.
I narrowed it down to a Terser issue. The option [reduce_funcs[(https://github.com/terser-js/terser#compress-options) defaults to true, which is what causes this issue for you.
It may be best to disable this in our config, what do you think @iansu? It would increase bundle sizes, but to me this default seems dangerous.
Just on a side note, the reproducible demo is also requested because we're all volunteers here, and manually reproducing can takes time (slowing down our response times), but the code you provided was enough in this case 😉


Add bintray repo for jnr-fuse

@gpang  what's the implication of this issue?

@apc999 the jnr-fuse dependency requires this repo, so any new/fresh machine will not be able to download the dependency without this PR.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.4 please

alluxio-bot, cherry-pick this to branch-2.3 please

alluxio-bot, cherry-pick this to branch-2.3 please

alluxio-bot, cherry-pick this to branch-2.2 please

alluxio-bot, cherry-pick this to branch-2.2 please

alluxio-bot, cherry-pick this to branch-2.1 please

alluxio-bot, cherry-pick this to branch-2.1 please

alluxio-bot, cherry-pick this to branch-2.0 please

alluxio-bot, cherry-pick this to branch-2.0 please

alluxio-bot, cherry-pick this to branch-1.8 please

alluxio-bot, cherry-pick this to branch-1.8 please


Hyperlink sources on GHC distribution packages

Describe the bug
Currently the sources of packages such as text, etc, that come in the GHC distribution are not hyperlinked. This is unfortunate as it interacts with the source hyperlinker of hackage packages poorly by having a different URL format (hyphens instead of dots in the names of module source files). I am currently fixing some bugs in the hyperlinker and noticed that this URL format thing was happening.
Steps To Reproduce
Steps to reproduce the behavior:
Look at /nix/store/3bwbsy0llxxn1pixx3ll02alln56ivxy-ghc-9.0.2-doc/share/doc/ghc/html/libraries/text-<IP_ADDRESS>/src/Data-Text-Array.html or similar paths in your ghc doc package, which don't have hyperlinks to items in them.
Do nix-build '<nixpkgs>' -A haskell.compiler.ghc902.doc and replace the first part of that path as appropriate.
Expected behavior
I would like these packages to have hyperlinked sources.
Screenshots
Not-hyperlinked source from Data.Text.Array:

Additional context
I am guessing this is something that needs to be set in the GHC build system custom to pass --hyperlinked-source to haddock.
Notify maintainers
@guibou
@cdepillabout
@expipiplus1
@maralorn
@sternenseemann
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
 - system: `"x86_64-linux"`
 - host os: `Linux 5.17.1-arch1-1, Arch Linux, noversion, rolling`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.0`
 - channels(root): `"nixpkgs"`
 - channels(jade): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Related upstream filing: https://gitlab.haskell.org/ghc/ghc/-/issues/19455, which we can probably follow to figure out what we'd need to do.

@lf- This definitely sounds like something we should enable if you want to figure it out and send a PR!  It is hard to imagine anyone being against it, since the hyperlinked docs are so helpful.


change oauth proxy digest value to manifest list digest of tag v4.10

/closes #218
related to kubeflow odh notebook controller and oauth injected notebooks sidecar story, too
https://github.com/opendatahub-io/kubeflow/pull/119/
as well as odh dashboard PR https://github.com/opendatahub-io/odh-dashboard/pull/1482
Description
Make ose-oauth-proxy container version or sha256 digest reference consistent across all components e.g. odh-dashboard.
Agree on v4.10
registry.redhat.io/openshift4/ose-oauth-proxy@sha256:ab112105ac37352a2a4916a39d6736f5db6ab4c29bad4467de8d613e80e9bb33
Since ose-oauth-proxy tag reference image behind, the digest, regardless which openshift 4 minor version, changes regularly. Thus, and to be compatible with restricted network environment ImageContentSourcePolicy as well with node image caching with imagePullPolicy: IfNotPresent, change to digest notation.
Latest manifest link digest for v4.10 from July 6 2023
https://catalog.redhat.com/software/containers/openshift4/ose-oauth-proxy/5cdb2133bed8bd5717d5ae64?architecture=amd64&tag=v4.10.0-202306170106.p0.g799d414.assembly.stream&push_date=1688610772000&container-tabs=gti
included in this PR.
alternative way with downloading, just to show it is in fact the most current v4.10 digest:
docker pull registry.redhat.io/openshift4/ose-oauth-proxy:v4.10
v4.10: Pulling from openshift4/ose-oauth-proxy
1df162fae087: Already exists
d20a374ee8f7: Already exists
e88a8f7a57fc: Pull complete
dcbbfecd111e: Pull complete
Digest: sha256:ab112105ac37352a2a4916a39d6736f5db6ab4c29bad4467de8d613e80e9bb33
Status: Downloaded newer image for registry.redhat.io/openshift4/ose-oauth-proxy:v4.10
registry.redhat.io/openshift4/ose-oauth-proxy:v4.10

How Has This Been Tested?
Used this image version in copied manifests, manually modified, zipped and tarred, running on an on-prem OCP 4.10 cluster with odh core components installed (except monitoring).
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/ok-to-test

/lgtm

/approve thanks @shalberd


fix(step-indicator): ensure 45px bottom margin

Note: some of the changes only make sense when everything else is merged in, so maybe wait till then
@natalia-fitzgerald requested a consistent 45px spacing between the step indicator and the content to match the designs, so I've put together this small change for pre-clearance.
Changes

adjusts spacing to ensure 45px spacing between step indicator and the content below it

How to test this PR

Is the step indicator consistently 45px above the content below it?

Screenshots

Thanks for tackling this.  I too had a draft of this yesterday but didn't push it up, so I'll do a better job of communicating and sharing WIPs.
I've linked this to the #515


refactor(http): refactor http route attribute

What
Fixes #789

Refactor Route attributes to derive from instance instead of common parent class
Split different "types" of routes.

All user defined (attribute) routes are normal Routes.
After discovery we have a DiscoveredRoute with the handler attached to it
During route construction we have a Marked route
After matching we has a MatchedRoute

Outstanding questions

See question to brendt in comments

Ping me when ready for review :)

Ping me when ready for review :)

@brendt Ping
I do got a question for you :

Do we even want the distinction between different types of routes?  And if so, what are they?

I really struggled with this one, initially I introduced it because initially we mutated the user provided Route attribute and add the handler to it. before passing it along. To me, this seemed rather hacky.
Pro multiple routes
Clearly we only need to set the handler internally, so why should we expose this in an common interface to the user. It could be easily "misused" by fixating the handler and ignoring the attribute applied one, this also seems like a really easy and hard to spot security vector to exploit.
By having multiple different type of routes we have a better way of communicating "this is  what a user should see" at this point in time. This is also shown in the benchmark code, previously I didn't need to have a handler set , but now I need to set it due to the non nullable typing. I like this, because the RouteConfig, and the RoutingTree should never have routes without a handler, it shouldn't be possible because what are you going to call when matching it?
Con multiple routes
Naming is hard, and now we need to name 3 different things. Also , object construction doesn't come cheap. So doing this in a performance sensitive place in the framework can become quite a performance hit. And I doubt if it clearifies more or if this is just confusing people.

Sorry, @blackshadev. That was me. 😬

More for discussion than anything... I'm not really a huge fan of eliminating the #[Route] attribute, even though @brendt suggested it. 🙂
I think I'd propose an API similar to the following:
final class Route
{
    // ...
}

final class GET implements RouteProvider
{
    private Route $route;

    public function __construct(string $uri)
    {
        $this->route = new Route(...);
    }

    public function getRoute(): Route
    {
        return $this->route;
    }
}

More for discussion than anything... I'm not really a huge fan of eliminating the Route class, even though @brendt suggested it. 🙂
I think I'd propose an API similar to the following:
final class Route
{
    // ...
}

interface RouteProvider
{
    private(set) string $route { get; }
}

final class GET implements RouteProvider
{
    public function __construct(string $uri)
    {
        $this->route = new Route(...);
    }
}

Wait.. you can have an interface on property hooks o.0. That is amazing. Can't we basically remove the whole IsRoute trait and type the interface like: That way we do not need any default methods.
interface Route
{
    private(set) string $uri{ get; }
    private(set) Method $method{ get; }
    private(set) array $middleware{ get; }
}

The rebasing itself was the hardest rebase I did in years

I'm actually going to revert that commit for the biggest part 😬 I'll merge this one first though, so that you don't have to do double work. I'll review and fix things where needed myself. Sorry for the overhead

I read your question. I don't have a good answer at the moment. However, I think we can merge this as is, and figure out if we need further improvements later on. As far as I can tell, these classes are internal, so even if we change them later on, users wouldn't be impacted.

@blackshadev did you plan on changing the docs as well, or do you want me to take care of that?

@blackshadev did you plan on changing the docs as well, or do you want me to take care of that?

I will create an MR for the docs tonight.

Thanks! The docs aren't updated yet to reflect the namespace changes though. We need to make a decision on that first, just so that you're not doing double work. I'll keep you posted


add login

let people login to the admin console

this is done and waiting for pull request.  It was just a change to the render-build.sh script.  On a local system you do it by running python manage.py createsuperuser

this is done, deleting


Add graduation announcement

cc @estesp

Cool! I like it. The only problem is Travis CI would like to see a Signed-off-by:  on your commits :)

@estesp Hmmm. Both commits have a DCO sign-off.

@estesp Ah, I see now. There was a whitespace error in a commit. I forgot that all commits have to have that error addressed. I got bitten by this before. Should be okay now.

@mikebrow Updated

LGTM


Add migration script to import elisa results

Imports elisa results (IgG, IgA channels) provided by Barbara. See also: https://github.com/hci-unihd/batchlib/issues/89#issuecomment-626298169

[x] Run on dev and prod DBs

Hey @constantinpape, this is good to go IMO. I've run the migration script on dev and prod databases. Only the following plates were affected by the script (i.e. have cohorts with Elisa results):

20200417_132123_311
plate9rep1_20200430_144438_974
20200417_152052_943
20200420_152417_316
plate8rep1_20200425_162127_242
plate7rep1_20200426_103425_693

I'll extend the Mongo API in a separate PR

Thanks!
And yes, let's keep the API separate.


Print in emulator console with a dedicate memory address and a script

So taking inspiration from here: https://www.mattgreer.dev/blog/mame-lua-for-better-retro-dev/
It will be cool to have this kind of debug.
TLDR:

Create a memory address specific to write debug messages
Call in the game
From the lua script in MAME get that memory aaddress and print the value

As in this case we are talking about a script engine there is anything as default to do that, but it will simplify a lot the development.

Great idea! The gba lua code allows you to write to two specific address ranges already, see here:
https://github.com/evanbowman/BPCore-Engine?tab=readme-ov-file#ram-readwrite
The _IWRAM variable is currently not a fixed address, it is placed by the linker, but you can print its contents to see what the address is.

All the required components should exist in the api, I can try it out sometime this week.
A really cool idea would be to use an emulator's lua api to put source code strings into gba memory, then read and eval() them on the gba, and write the result back to gba memory for the emulator's lua api to read. Then you'd have interactive development!

So I have this snippet for mgba and the Metal Slug Advance (https://drive.google.com/file/d/1FNTohgCTjEHrxzeDly0l3awPoti8W0nU/view):
function detectGame()
console:log(emu:getGameTitle())
end
count = 0
function updateBuffer()
count = count + 1
-- Wait around 2 seconds
if count == 120 then
console:log('Updating ammo')
-- Unlimited arms point
emu:write16(0x02000072, 0xFF)
count = 0
end
end
callbacks:add("start", detectGame)
callbacks:add("frame", updateBuffer)
if emu then
detectGame()
end

Mgba doc: https://mgba.io/docs/scripting.html
https://github.com/mgba-emu/mgba/issues/2550
Various examples scripts: https://github.com/mgba-emu/mgba/tree/c541a79e9564310d7a81d9668f41317acf30dda1/res/scripts
I think that what are you looking to do is possible as the scripting UI has a textbox where you should be able to run lua commands.

Resolved in previous release

It isn't clear how to use the log function right now.
Reading the code I think that is not using the solution that I proposed.

Can you please describe what you're looking for in more detail? It sounded like you wanted to write text to the emulator log window, I must have misunderstood.

So that function write in the screen the content and not in the log window, like explained in this ticket?

Ah! Sorry, I was looking at the wrong issue ticket!


Groupie | Instance Filters Tab

Notes & Acceptance Criteria

Groupie Instance Data || https://docs.google.com/spreadsheets/d/1oM6i5hlA483Hyo-_JHzCYVHWQCPCR2RQOHwHlzhqeCo/edit#gid=0

Design Files

Groupie - Instance Filters || https://whimsical.com/groupie-instance-filters-D6tSkSa8NA9wcwWfXGcbfx

Tasks

[ ]

Please add some notes to the file so we know sources.
-- https://www.warcrafttavern.com/wow-classic/guides/dungeons-instances/
-- https://wowpedia.fandom.com/wiki/InstanceID
-- https://classic.wowhead.com/guides/classic-dungeons-overview
-- https://tbc.wowhead.com/guides/dungeons-overview-burning-crusade-classic
-- https://www.wowhead.com/wotlk/guides/dungeons-overview
A lot of the dungeon levels listed on sites like this...
https://www.wowhead.com/wotlk/zones/instances/dungeons#0-2+7

That's just really dumb.
It lists RFC as being 15 to 25, but like... the bosses / mobs are 13-16. Meaning if you go in at 25, you aren't going to get any XP at all. We'll have to adjust some of those levels I think. RFC, for example, should be listed as a 13 to 21 level instance. 13 being the lowest mob, and 21 being 5 levels higher than the highest mob. I think that formula would probably work OK.

Oh, also we have to watch out... WoWhead has bad data for everything. RFC, for example it lists some elites that aren't in the game. =P


Citation report update

Updates in the section on Better BibTeX (issue solved + a non-issue).

In attendance of a fix for #28, I upload here the locally rendered files so that they can be compared with the website version after this PR will be merged.

citation_style.zip (this is the gitbook)
citation_style_bst.pdf
citation_style_csl.pdf

Done with INBOmd@6a00c0b. (current master)


Reaction symbol ">>" is not being rendered

What happened?
The symbol ">>" is no longer being rendered.
What did you expect to happen?
The symbol ">>" rendered as a forward arrow.
How can we reproduce it (as minimally and precisely as possible)?
Example:
[HH].CC(C)CC1=CC=C(C(C)=O)C=C1>>CC(C)CC2=CC=C(C(C)O)C=C2

Produces:
SyntaxError
Expected "%", "(", "*", "B", "C", "[", [0-9], [NOPSFI], [-=#$:/\.], [bcnops], or end of input but ">" found.
Anything else we need to know?
On the previous version the ">>" was working as expected.
Plugin version
0.2.0
Obsidian version
1.4.2

Yeah it should be supported. Thanks for the report and will look into this.

Hi! This should be fixed in the new release. Feel free to comment if the problem persists.

It's working 👍 Thank you very much!


Fix gateway/objects/channel (voice chat) userlimit always zero (userlimit should be user_limit in json)

Ref: Discord developers
User limit should be "user_limit". "userlimit" won't work.

Going to need to fix the GCC5 build as well as not do formatting changes like that. A commit of all indenting in a namespace is a mess. Namespace contents should not be indented.

sorry I'll fix that, some ctrl C and V might have messed this up. I forgot about the C++14 not allowing variables directly into the if's too. My bad.


Added config, nconf packages with basic usage

@BrunoScheufler May I suggest - our goal is to compare the packages and even benchmark their performance, hence I suggest having the exact same requirements and configuration keys in each. I would use the convict config - I intentionally made it big enough to emphasize performance problems if one of the packages is loading entries inefficiently.
I also added few requirements (readme.md), it would be great if you can comment in the code which falls short to satisfy a requirement (e.g. which has no build-in casting capabilty and need to cast by itself, which has no default value and should do if/else switch to set default value)
Makes sense?

If one of the packages demands great effort or quirky code - that's great as it serves our goal of emphasizing which package is very flexible and verbose vs those that demand almost no setup


Fix panic on Text UI without Cameras

Objective
Fix https://github.com/bevyengine/bevy/issues/11396.
Solution
Don't panic on taffy node not existing.
Plus minor warning text improvement.

Why is this marked as a breaking change?

Why is this marked as a breaking change?

update_measure was renamed to try_update_measure

Why is this marked as a breaking change?

update_measure was renamed to try_update_measure

It's in a private module.

Why is this marked as a breaking change?

update_measure was renamed to try_update_measure

It's in a private module.

We should remove its pub marking then to avoid further confusion.


Refactor out some helper functions

These functions were previously hidden inside other functions but they
are useful enough to expose directly. Specifically, I plan to use these
when implementing Scrollable2.ensureVisible.

@Hixie

LGTM, bonus points if you write tests for these functions :-)

I guess I could test them, but I'm sort of assuming they were tested as part of the functions I factored them out of...


Return non-zero exit code when credentials are not successfully acquired

Fixes #167

@jmyersmsft @satbai


Pin PHPStan

This should fix the CI now and in the future, see #848 as an example.

Thanks! Good call, phpstan is great but having it "auto" update is not a great situation.


Receiving error that TextLoader is not a constructor—could be me

I'm writing a CLI with node and langchain. This is the code:

const OpenAI = require("langchain/llms/openai")
const TextLoader = require("langchain/document_loaders/fs/text")
const readline = require("readline")
const exec = require("child_process").exec

const rl = readline.createInterface({
  input: process.stdin,
  output: process.stdout
})

console.log(`Prompt >`)

rl.question(`What can I do you for? `, function (request) {
  var child = exec("touch " + request, function (err, stdout, stderr) {
    const loader = new TextLoader("/sample_data/sample.md")
    const docs = loader.load()
    console.log({ docs })
  })

  // Close the readline interface and exit the program
  rl.close()
})```

When I run this, I get:

/Users/russellwarner/Development/RUZ-3L/index.js:17
const loader = new TextLoader("/sample_data/sample.txt")
^
TypeError: TextLoader is not a constructor
at /Users/russellwarner/Development/RUZ-3L/index.js:17:20
at ChildProcess.exithandler (node:child_process:404:7)
at ChildProcess.emit (node:events:513:28)
at maybeClose (node:internal/child_process:1091:16)
at Socket. (node:internal/child_process:449:11)
at Socket.emit (node:events:513:28)
at Pipe. (node:net:313:12)

Nevermind. TextLoader returns a promise and so I needed to employ async/await to fix this.


vm test: add test coverage for creating VM from custom image

Bring back test code removed at #2409
Find a place to persist prepared generalized vm image and let tests use that, assuming a storage account which never goes away and be accessible from other subscriptions,

Lets close on this in this sprint.


INFINITY-2219 Switch to packagingVersion 4.0 and use translator proxy

Updates all packages to use packagingVersion 4.0. Adding upgradesFrom/downgradesTo (and the needed tooling to deal with that) will be done in a separate PR...
Updates tooling to use stub universe URLs which go via a new translation service, and to remove prior workarounds for packagingVersion values.

Note 1: This PR will likely fail CI until the translation service actually comes up at the expected URL. Waiting on a DNS entry or something.
Note 2: If you are on CLI 0.4.x, package describe will show packageVersion 3.0 even if the cluster is 1.10. Use an 0.5.x CLI and it'll show 4.0. (took a while to figure this out during testing)

@nickbp It's failing with: E           dcos.errors.DCOSException: Could not access data at URI for repository [testpkg-siw79eg9]: https://universe-converter.mesosphere.com/transform?url=https://infinity-artifacts-ci.s3.amazonaws.com/autodelete7d/hello-world/20170817-005921-IUoArhyZj9zO4ZxN/stub-universe-hello-world.json

The translator proxy appears to be up. Re-running.

Kafka is actually green, github just wasn't updated. See details link. Merging.


Remove the Manifest code.

Right now the manifest exists as it is used in the legacy indexer but it is not useful in a file per split mode.

Closed via #481


Added extra cmdlets and improved Get-PBIImports

New cmdlets:

New-PBIGroup (create a new group/workspace)
New-PBIGroupUser (add a new user to a group/workspace)

Updated:

Get-PBIImports (optional parameter group id to fetch imports of a specific group/workspace)

Thanks!


Release 0.2

Coverage remained the same at 100.0% when pulling 8344e3a63350f5a440d87f9273794bda26472361 on FlorianLautenschlager:master into 463e397faee7ac01077b57fa0597cbea1ce5f885 on ChronixDB:master.


flutter has exited unexpectedly: "FormatException: Missing extension byte (at offset 83)

Flutter crash report.
Please report a bug at https://github.com/flutter/flutter/issues.
command
flutter build ios --release
exception
FormatException: FormatException: Missing extension byte (at offset 83)
#0      _Utf8Decoder.convertChunked (dart:convert-patch/convert_patch.dart:1891:7)
#1      _Utf8ConversionSink.addSlice (dart:convert/string_conversion.dart:314:28)
#2      _Utf8ConversionSink.add (dart:convert/string_conversion.dart:310:5)
#3      _ConverterStreamEventSink.add (dart:convert/chunked_conversion.dart:72:18)
#4      _SinkTransformerStreamSubscription._handleData (dart:async/stream_transformers.dart:111:24)
#5      _rootRunUnary (dart:async/zone.dart:1362:47)
#6      _CustomZone.runUnary (dart:async/zone.dart:1265:19)
#7      _CustomZone.runUnaryGuarded (dart:async/zone.dart:1170:7)
#8      _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:341:11)
#9      _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#10     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:733:19)
#11     _StreamController._add (dart:async/stream_controller.dart:607:7)
#12     _StreamController.add (dart:async/stream_controller.dart:554:5)
#13     _Socket._onData (dart:io-patch/socket_patch.dart:2160:41)
#14     _rootRunUnary (dart:async/zone.dart:1370:13)
#15     _CustomZone.runUnary (dart:async/zone.dart:1265:19)
#16     _CustomZone.runUnaryGuarded (dart:async/zone.dart:1170:7)
#17     _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:341:11)
#18     _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7)
#19     _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:733:19)
#20     _StreamController._add (dart:async/stream_controller.dart:607:7)
#21     _StreamController.add (dart:async/stream_controller.dart:554:5)
#22     new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1696:33)
#23     _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:1208:14)
#24     _microtaskLoop (dart:async/schedule_microtask.dart:40:21)
#25     _startMicrotaskLoop (dart:async/schedule_microtask.dart:49:5)
#26     _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:120:13)
#27     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:185:5)

flutter doctor
[✓] Flutter (Channel stable, 2.2.2, on Mac OS X 10.15.7 19H1217 darwin-x64, locale zh-Hans-CN)
    • Flutter version 2.2.2 at /Users/iosteam/flutter
    • Framework revision d79295af24 (4 weeks ago), 2021-06-11 08:56:01 -0700
    • Engine revision 91c9fc8fe0
    • Dart version 2.13.3
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/iosteam/android_env/android-sdk-macosx
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/iosteam/android_env/android-sdk-macosx
    • Java binary at: /Library/Java/JavaVirtualMachines/jdk1.8.0_171.jdk/Contents/Home/bin/java
    • Java version Java(TM) SE Runtime Environment (build 1.8.0_171-b11)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] Connected device (1 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 91.0.4472.114

! Doctor found issues in 2 categories.

Closing this as duplicate of https://github.com/flutter/flutter/issues/81666


Compiler API: Expose signature.thisParameter

Suggestion
Remove @internal for the thisParameter on the Signature interface.
https://github.com/microsoft/TypeScript/blob/20c93d3b1da44d8ee740b466a5cde7894e8b3260/src/compiler/types.ts#L5771-L5772
🔍 Search Terms
compiler api, thisParameter
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
As above.
📃 Motivating Example
TypeDoc needs to access the this parameter to properly document functions via their signature rather than relying on nodes. Today, I plan to add this to a declaration file to expose it manually. https://github.com/TypeStrong/typedoc/issues/1875

It's just another parameter, so I think it should be public just like parameters.

Is there a way to turn this off? It just feels off to me to document "this" as if it were a normal parameter, since it can't be passed that way, and in the course of normal use, most users won't be thinking about the type of "this" when they call a method.

Turn what off, exactly? This issue is about API availability of this parameters

Ah! Sorry, I misunderstood what was happening here. Never mind.


Update playercore URLs

The playercore assets have been moved to the following new URLs:
https://assets.nflxext.com/player/html/ffe/cadmium-playercore-6.0045.605.911.js
https://occ-weba-h2.a.nflxso.net/sec/player/html/ffe/cadmium-playercore-6.0045.605.911.js
Since www.assets.nflxext.com no longer exists, remove this entry
while we are at it.

ty, I haven't tested this myself yet, but looks good enough to yolo merge heh


Add icon for Open Liberty

Adds an icon for the java-openliberty stack:

Sourced from https://raw.githubusercontent.com/OpenLiberty/logos/7fbb132949b9b2589e18c8d5665c1b107028a21d/logomark/svg/OL_logomark.svg
@scottkurz @mezarin Let me know if this is the right icon to use or if another should be used.

@johnmcollier  - LGTM.
I'm not sure where it's going to be displayed.    We also have a combo icon which includes the text "Open Liberty":
https://raw.githubusercontent.com/OpenLiberty/logos/master/combomark/svg/OL_logo_navy.svg
if that might fit.. but I noticed the other PRs seem to point to just pictorial icons.. which is fine.
Thanks for asking.

@scottkurz Thanks!
The icon will be displayed in the devfile registry viewer:

I generally tried to stick to the smaller / simpler icons, so I'll probably just stick to the pictorial icon

/retest


how do i change the maven group / java class name without breaking quite literally everything

Also the ModID, because last time i tried to do that I failed horribly and ended up breaking everything

other thing: the MacOS bar says this, how do i change this too :p

fabric wiki fabric.mod.json