Notification for videos that have the audio muted/removed due to copyright/other

When you add a video to the playlist that has audio muted it looks like it's playing, with no notification of the audio being muted for the video.
Is there a way to check for this and give the user a notification?

I never really found any more details on this :( And the link cited now is unmuted, so maybe the problem went away. Feel free to re-open if need be.


registering a submodule dynamically

I'm submitting a ...
[ ] bug report
[ ] feature request
[ ] question about the decisions made in the repository
[x] question about how to use this project

Summary
how does one register a module that is defined using typescript classes dynamically?
https://vuex.vuejs.org/guide/modules.html#dynamic-module-registration
This is specifically for use with JS Vue components, that have not yet been converted to vue-class-component TS components.

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. StackOverflow, personal fork, etc.)

importing the class based submodule and registering it to the store using the registerModule method does not seem to work.
import { SomeVuexModule } from '@store/modules/some-module';
beforeCreate() {
this.$store.registerModule('someModule', SomeVuexModule);
}

or
import { SomeVuexModule } from '@store/modules/some-module';
beforeCreate() {
this.$store.registerModule('someModule', new SomeVuexModule());
}

I think that's because registerModule requires a raw (already mapped) module, but I do not know how to get one from the class based submodule.

Hi @ReinisV,
Dynamical module registration isn't supported for now. However, it wouldn't be that difficult to implement, as there already is an internal function that converts an instance to a vuex module.
I added this feature to my todo list and will write a comment here once it is done.

Is the function your talking about the transformRecursive?
It'd be awesome if I could figure out a way to call it directly for my use case.

Yep it is this function I was talking about, you can probably write a function that wraps a call to transformRecursive to do what you want:
function createVuexModule(store, instance, namespace: string): Module<any, any> {
  const storeProvider: StoreProvider = { store };
  return transformRecursive(storeProvider, instance, namespace.split('/'));
}

This should transform the instance and return the module config, though I just did that on a fly and didn't test it.

Dynamic modules have been officially added to the package. There is a section in the README going over the 3 functions that have been implemented in #25:
https://github.com/sascha245/vuex-simple#dynamic-modules
Though all the tests passed and everything in the samples worked, don't hesitate to signal any bugs that may have appeared in this version.


[test/plugin] Enhance PluginTest

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[ ] New feature provided

[ ] Improve performance

[x] Enhancement

Related issues

New feature or improvement

Re-balance the workload of plugintests
Restore testcases of MySQL, remove on  #4641
Support user to runs plugin-test on debug mode. It will not remove the log files and actualData.yaml
remove paramater 'parallel_run_size' and disable parallel test.

Codecov Report

Merging #4677 into master will decrease coverage by 19.96%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28530cd...2207dfb. Read the comment docs.

Re-balance the workload of plugintests

I don't think we need this and you actually cannot "rebalance" them, as we're using matrix build, all the plugin tests of each plugin are run parallelly , no mater which workflow they belong to

Re-balance the workload of plugintests

I don't think we need this and you actually cannot "rebalance" them, as we're using matrix build, all the plugin tests of each plugin are run parallelly , no mater which workflow they belong to

The time it costs only depends on the version numbers of the plugin test and the test itself


Block elements (target, comment, block-break)

Describe the enhancement you'd like
There are three block elements to implement here:

[ ] comment
[ ] block-break
[ ] header targets

Does this solve a specific problem?
No response
What alternatives exist?
There is some prior art here:

https://github.com/executablebooks/markdown-it-myst/blob/main/src/blocks.ts
https://github.com/executablebooks/myst-vs-code/blob/83460fc5f14517e8d6c6b7eb5581d814389fbc7c/src/mdPlugins.ts

Additional context
Target
Then we also have the target syntax in myst: (label)= (a reference implementation is currently here: https://github.com/executablebooks/myst-vs-code/blob/83460fc5f14517e8d6c6b7eb5581d814389fbc7c/src/mdPlugins.ts#L32, but perhaps we should move that into this package, they also get a little trick as we also need to "propagate" them down to the next block token, see: https://github.com/chrisjsewell/rst-language-server#transformsreferencespropagatetargets).
Essentially we want to be able to easily "scan" down the markdown-it token stream, and pull out all these targets and references, along with their map (a.k.a. position in the source text) and probably index in the token stream
Originally from #10

@chrisjsewell looking at the library that you have opened up here (myst-extras) are you thinking these shouldn't be in this repo? It looks like you have moved the targets/blocks/comments over there.

These have been moved to the https://github.com/executablebooks/markdown-it-myst-extras repository.


Backport of "HHH-15709  HQL local datetime literals on Postgres, Cockroach H2"

We don't do backports to 6.1 anymore. Switch to 6.2 please.


Check dependencies and security vulnerabilities

Describe the desired behavior
Make sure we are using the latest versions of dependencies and that we do not have any high or severe security vulnerabilities.
Describe the current behavior
May be using some older packages.
Is this request related to a current issue?
No
Additional Context

This should be resolved now; we've updated to angular 13 dependencies & our showcase is updated weekly.


Support transforms argument for ImageNet / ImageFolder / DatasetFolder

🚀 The feature
Currently they seem to only support old style transform=, target_transform=. Joint transforms are needed for augmentations. I guess these datasets just need to pass in transforms= argument to the base VisionDataset class
Motivation, pitch
N/A
Alternatives
No response
Additional context
No response
cc @pmeier

What joint transformation do you want to use with a classification dataset? I know there is MixUp, CutMix, and other variants, but these can only applied after some batching happened.

I'm augmenting it with ImageNet provided bboxes: https://github.com/pytorch/vision/issues/5318
This is useful for evaluating localization.
I'm currently just setting .transforms in the resulting dataset object, and it works because the base class VisionDataets indeed supports .transforms, but it would be better for consistency if it supported the same arguments.

For ImageNet there is indeed a use case here. If we add support for bounding boxes, we will of course also add a transforms parameter. Thus, let's keep the discussion about this in #5318.
For ImageFolder I don't see a viable way forward to support this. The premise of these kind of datasets is that you only have the image and use its folder as category. Thus, there won't be support for any other annotations. And with that, I don't see a point of having a transforms parameter for them.

For ImageFolder I don't see a viable way forward to support this.

A very easy way forward is to just add a constructor argument transforms= and pass it onto DatasetFolder and VisionDataset. VisionDataset already knows how to handle all these arguments. I consider it quite viable. In any case, please feel free to close this issue if introducing such consistency would actually hurt some other aspects.

Thus, there won't be support for any other annotations. And with that, I don't see a point of having a transforms parameter for them.

I think consistency with other dataset classes is important. Please consider the case of deriving custom datasets from ImageFolder. Then this is helpful even regardless of whether it was a class for classification dataset or not.

A very easy way forward is to just add a constructor argument transforms= and pass it onto DatasetFolder and VisionDataset. VisionDataset already knows how to handle all these arguments (hmm, and also a two-line modification of DatasetFolder's getitem would be needed).

This is indeed an easy solution, but that is not what I meant with "viable". I meant "viable" in the sense that the change should make sense. See below why I think it doesn't.

I think consistency with other dataset classes is important.

Agreed, but this is an argument against adding it. We currently only use transforms for detection or segmentation datasets. Since ImageFolder is a classification dataset, adding transforms would make the API more inconsistent. See for example this for an (outdated) list of the transform support of our datasets.

Please consider the case of deriving custom datasets from ImageFolder. Then this is helpful even regardless of whether it was a class for classification dataset or not.

If you don't have classification data, subclassing from ImageFolder is probably not a good way to go. If you want a way to collect image files from an image folder structure, use torchvision.datasets.folder.make_dataset in a custom dataset.

Another usecase is easily plugging an already existing augmentation pipeline or plugging a simple dataset into an existing dataset/aug code.

That is a valid argument and we are going to solve this with the upcoming API's for datasets and transforms.

My point is that what is originally thought as classification dataset, can very well be cast or augmented as something else entirely by the users, library authors or anyone can't predict all valid usecases. Such inconsistencies are hurting user experience as require more custom classes that otherwise could have been implemented as a function (so force more object orientation and worse support of functional programming).


cannot install

PS C:\Windows\system32> install-module -name importexcel
install-module : The term 'install-module' is not recognized as the
name of a cmdlet, function, script file, or operable program. Check
the spelling of the name, or if a path was included, verify that the
path is correct and try again.
At line:1 char:1

install-module -name importexcel

  + CategoryInfo          : ObjectNotFound: (install-module:String
 ) [], CommandNotFoundException
  + FullyQualifiedErrorId : CommandNotFoundException

PS C:\Windows\system32> $psversiontable.psversion
Major  Minor  Build  Revision

3      0      -1     -1
PS C:\Windows\system32>

Thanks for logging the issue. Install-Module is part of PowerShell v5 preview. So you can either install the preview to get that cmdlet or you can click the download zip, unblock the zip, unzip it and then copy/move all the files to a sub folder in the modules directory called ImportExcel.
Install-Module does all that. Let me know if you run into issues.

Downloaded the v5 preview and system claims it's already installed.

Claims 5.0 is installed or the ImportExcel? The Apr 2015 preview should have install-module. You can do Install-Module ImportExcel -Force.

Claims v5 is installed

And when you run PowerShell, the $PSVersionTable show 3.0? Hmm, not sure what is going on.

Correct
PS C:\Windows\system32> $PSVersionTable
Name                           Value

PSVersion                      3.0
WSManStackVersion              3.0
SerializationVersion           <IP_ADDRESS>
CLRVersion                     4.0.30319.18444
BuildVersion                   6.2.9200.16481
PSCompatibleVersions           {1.0, 2.0, 3.0}
PSRemotingProtocolVersion      2.2
PS C:\Windows\system32>
Date: Wed, 13 May 2015 09:49:00 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [ImportExcel] cannot install (#19)
And when you run PowerShell, the $PSVersionTable show 3.0? Hmm, not sure what is going on.
—
Reply to this email directly or view it on GitHub.

I'm planning in adding a way to install this without needing Install-Module. Thanks to @Claustn  for the suggestion

Added an install.ps1 that can be used instead of PowerShell v5.0 Install-Module.
iex (new-object System.Net.WebClient).DownloadString('https://raw.github.com/dfinke/ImportExcel/master/Install.ps1')


Panx download data fixes

Hi,
this PR fixes two issues:

the anaconda env file cannot be installed sucessfully, because the specified version of openssl returned a 404. The PR uses a working version now.

The panx routine in the download_data.sh script originally unzipped the files into the download folder instead of a panx_dataset temp folder, so the tar command couldn't find the archives.

Thanks so much for the fix, Stefan! 👍


Add proof of work verification error.

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#503  👈
#502
#498
#470
#468
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alonh5 and the rest of your teammates on  Graphite

Codecov Report
Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.07%. Comparing base (3e27c16) to head (8fcdeff).

Files
Patch %
Lines

src/core/proof_of_work.rs
93.75%
1 Missing :warning:

src/core/prover/mod.rs
0.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@                          Coverage Diff                          @@
##           03-17-Add_OODS_verification_error     #503      +/-   ##
=====================================================================
- Coverage                              95.09%   95.07%   -0.02%
=====================================================================
  Files                                     58       58
  Lines                                   9015     9023       +8
  Branches                                9015     9023       +8
=====================================================================
+ Hits                                    8573     8579       +6
- Misses                                   389      390       +1
- Partials                                  53       54       +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Merge activity

Mar 20, 4:13 AM EDT: @alonh5 started a stack merge that includes this pull request via Graphite.


aaxaa

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bf1062f1-616d-acc2-abeb-b04e4cad28ad
Version Independent ID: 44068874-d5de-c2bf-d33b-22b649c7637c
Content: VM sizes - Azure Virtual Machines
Content Source: articles/virtual-machines/sizes.md
Service: virtual-machines
Sub-service: sizes
GitHub Login: @lauradolan
Microsoft Alias: ladolan

@kingcarlosz
Thanks for your feedback! We will investigate and update as appropriate.


[Harnmaster3] Dark modeupdate

Changes / Comments
Styling changes to make dark theme of sheet align better with roll20 dark mode.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name. yes
[x] Is this a bug fix? no
[x] Does this add functional enhancements (new features or extending existing features) ? No
[x] Does this add or change functional aesthetics (such as layout or color scheme) ? yes
[x] If changing or removing attributes, what steps have you taken, if any, to preserve player data ? n/a
[x] If this is a new sheet, did you follow Building Character Sheets standards ? n/a

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


EZ1-D 1800W

Hello,
I recently got the APSystems EZ1-D 1800 W.
Is the APSystems EZ1-D also supported or will this also come, possibly also for HomeAssistant?
Greetings,
Jochen

Is supported, also in Home Assistant.


create a sitemap.xml

I made one for LUT and have code I can copy over. I'll take this one.

Completed: https://syntax.fm/sitemap.xml


Implement /ttl set, /ttl unset, /ttl default set, and /ttl default unset commands

The command framework is now in place! I put some TODOs in case someone wants to take the opportunity to contribute to something sorta-small in the repo c:

these commands are being refactored in #38


Improve OAP server performance.

Please answer these questions before submitting a pull request

Why submit this pull request?
[ ] Bug fix
[X] New feature provided
[ ] Improve performance

Multiple ids get from storage in metrics persistent work when persistent timer extract data.
Remove the bulk size config item, use bulk action to control the batch process, use the flush interval to make the process also can send data to storage when there is no data coming.

/run e2e

/run e2e


Explore CometBFT implementation

Explore CometBFT implementation.

The CometBFT implementation being a fork of and a successor to Tendermint Core doesn't seem to significantly differ from the latter, explored in #9, as of v0.37.1.


[WIP] Refactor transaction fee charge.

:x: Build AElf <IP_ADDRESS>74 failed (commit https://github.com/AElfProject/AElf/commit/97a31b6721 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>77 failed (commit https://github.com/AElfProject/AElf/commit/f8fdda0689 by @EanCuznaivy)

:x: Build AElf <IP_ADDRESS>80 failed (commit https://github.com/AElfProject/AElf/commit/1cb0d2fffa by @EanCuznaivy)

close and merge this PR to #2193 for better verification.


Things are buggy and stop working

Describe the bug
Two things happen. If i wear HDT beards with HDT hair, one of the two stop working. And when i have either on, my quipment (sheathed weapons and shields) becomes SUPER jittery and glitchy.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
i expected physics to work with all items equipted that physics shoudl eb affected.
Screenshots and videos
https://screenrec.com/share/YVdNzk0Fwn
Desktop (please complete the following information):

OS: win11

** FSMP**

Installed version 2.5.1
CUDA: No_CUDA
AVX: AVX2

SKSE

installed version <IP_ADDRESS>
(You can check it in the bottom left part of the screen, when looking at your MCMs.)

Skyrim

Installed version number 1170
(You can check it in the bottom left part of the screen, when looking at your MCMs.)

Required files
Neither of these files exist.
Additional context
Add any other context about the problem here.

that's a bit of a strange one.
the Beards of Power are NOT smp-enabled - so they shouldn't influence anything physics-related.
try setting the following two values like so:
<enableNPCFaceParts>true</enableNPCFaceParts>
<disableSMPHairWhenWigEquipped>false</disableSMPHairWhenWigEquipped>

either in the FSMP MCM, or by editing configs.xml

Okay i'll Try it. and what about my jittery gear? anything that has physics, makes any gear i have equipped super jittery and buggy.

@snottyone hey so i turned the fsmp with wig on then off, and it solved my issue with the beards causeing teh hair to stop. but my equipment is still laggy and jittery.

assuming you have CBPC for the equipment physics - that jitter is a conflict between CBPC and SMP.
it can be sort of controlled in BHUNP (for female PCs), not sure about the male body mods (HIMBO, SAM).
it may also be reduced with the game capped at 60 fps (at high frame rates, there are weird effects accumulating which stiffen things up)


Update device-portal.md

Updating to Windows Mixed Reality documentation resulted in a broken link on line
Device Portal for HoloLens
Now update with new location

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot


Add GitLab code quality output format

See https://docs.gitlab.com/ee/ci/testing/code_quality.html#implement-a-custom-tool

Having played around with this, I don't think this would be useful. The code quality report seems to be used merely for informative purposes, and would not fail the build on violations. Better to just run Regal as a job of it's own. If GitLab adds a way to emit annotations from a job at some point, we should revisit this, but I'll close this for now. If you came here looking for how to run Regal in GitLab CI, it's as simple as:
regal:
  stage: test
  image:
    # change to whatever version is latest, don't actually use :latest
    name: ghcr.io/styrainc/regal:latest
    entrypoint: [""]
  # change policy/ to where you want Regal to lint
  script: ["regal lint policy/"]


chore: Bump actions/stale to 3.0.13 for CVE issue

Why:
Google Project Zero released an advisory on the older versions of the Action because it would print things like the title to the console without escaping.
What's being changed:
Bump the actions/stale hash to https://github.com/actions/stale/releases/tag/v3.0.13
Check off the following:

[x] All of the tests are passing.
[x] I have reviewed my changes in staging.
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

@chiedo might be good to get this one merged since it relates to a security issue that is public now

Thank you @nschonni!


ci: testplan generation cleanup and scope overhaul

originally tags were introduced to reduce the number of tests we run, so, if a driver is changed, there was no need to build kernel tests and such, so it was exclusion based. This means that we would end up building loads of irrelevant tests still because tags file does only cover a few areas.
Most importantly it was abstraction based, so it was not about running tests related to what has changed, instead just reduce the number of tests not guaranteeing coverage at all of what the PR is changing.
This new approach is based on the Maintainer file and connecting areas in that file with tests, if a PR changes one area, tests for this specific area is run. There are a few other steps taken to increase coverage and to deal with special cases.
change some code in some subsys or 2, then...
./scripts/ci/test_plan.py -c HEAD~1.. or whatever
for example, changed bindesc subsystem:
i9:zephyr(ci_plans_cleanup_2): ./scripts/ci/test_plan.py -c 6d40dca0323..

INFO: /home/nashif/zephyrproject/zephyr/scripts/twister -c --test-config custom_config.yaml --level custom --save-tests _test_plan_partial.json --integration
Deleting output directory /home/nashif/zephyrproject/zephyr/twister-out
INFO    - Using Ninja..
INFO    - Zephyr version: zephyr-v3.5.0-1517-gbbbec63eca7c
INFO    - Using 'zephyr' toolchain.
INFO    - Selecting default platforms per test case
INFO    - Building initial testsuite list...
INFO    - Writing JSON report /home/nashif/zephyrproject/zephyr/twister-out/testplan.json
INFO    - Writing JSON report _test_plan_partial.json
INFO: Added 17 suites to plan.
INFO: -------------------  post filters --------------
INFO: No twister needed or partial twister run only...
INFO: Total tests gathered: 17
INFO: Total tests to be run (after removing duplicates): 17
INFO: Total nodes to launch: 1

Nice, MAINTAINER file approach seems like a great plan.
Do we really need the tags? Maybe the plan could just scan for sample/test yaml files under the area and add those to the plan regardless on the tag.
Was also thinking, maybe it would make sense to distinguish between platform changes and subystem changes and behave differently?

That is what the script does, no?

Ok fair enough, sorry not familiar with the original code, need to put more time into understanding this, see my question above about tags+tests in the maintainer file.

@nashif Needs rebasing.

@nashif coming back to this?

@nashif coming back to this?

yes, working on that now actually, it is not easy :(


Update az-overview.md

Added Cognitive services and Databricks to Specialized Services.
Removed services that announced retirement

@Obeling : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Obeling : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Update index.yml

Two Quickstart pages: On-board (set up connections) and Get started (explore features like workbooks, visualization, detections)

@jenellea : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Related to Technical review AB#378673

#sign-off

@jenellea: I'm sorry - only the author of this article, @yelevin #Required; your GitHub user alias, with correct capitalization., can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#assign:batamig


Fix the issue that tenant can't override verifier address from comman line

Create verifier_base_url on demand.
Resolves: #447

I wonder if there is a mechanism to recheck the travis job, the failure doesn't seem related with the change and the log implies a build error.

I wonder if there is a mechanism to recheck the travis job, the failure doesn't seem related with the change and the log implies a build error.

things turned out that the test is not consistent with code.

I've tested it, and the very same bug persists. The keylime_tenant CLI is still ignoring the -v option (I actually don't see this CLI parameter being processed on the code).

I've tested it, and the very same bug persists. The keylime_tenant CLI is still ignoring the -v option (I actually don't see this CLI parameter being processed on the code).

I've tested it, and the very same bug persists. The keylime_tenant CLI is still ignoring the -v option (I actually don't see this CLI parameter being processed on the code).

This is stange, the -v is processed here https://github.com/keylime/keylime/blob/master/keylime/tenant.py#L938-L939
Any idea why this change didn't work for you?

I've tested it, and the very same bug persists. The keylime_tenant CLI is still ignoring the -v option (I actually don't see this CLI parameter being processed on the code).

This is stange, the -v is processed here https://github.com/keylime/keylime/blob/master/keylime/tenant.py#L938-L939
Any idea why this change didn't work for you?

I've tested it, and the very same bug persists. The keylime_tenant CLI is still ignoring the -v option (I actually don't see this CLI parameter being processed on the code).

This is stange, the -v is processed here https://github.com/keylime/keylime/blob/master/keylime/tenant.py#L938-L939
Any idea why this change didn't work for you?

I've tested it, and the very same bug persists. The keylime_tenant CLI is still ignoring the -v option (I actually don't see this CLI parameter being processed on the code).

This is stange, the -v is processed here https://github.com/keylime/keylime/blob/master/keylime/tenant.py#L938-L939
Any idea why this change didn't work for you?

I've tested it, and the very same bug persists. The keylime_tenant CLI is still ignoring the -v option (I actually don't see this CLI parameter being processed on the code).

This is stange, the -v is processed here https://github.com/keylime/keylime/blob/master/keylime/tenant.py#L938-L939
Any idea why this change didn't work for you?

Well, it appears we have naming issues here, cloudverifier_ip and verifier_ip are both used and easily get wrong..
Will push an update soon.

I've tested it, and the very same bug persists. The keylime_tenant CLI is still ignoring the -v option (I actually don't see this CLI parameter being processed on the code).

This is stange, the -v is processed here https://github.com/keylime/keylime/blob/master/keylime/tenant.py#L938-L939
Any idea why this change didn't work for you?

Well, it appears we have naming issues here, cloudverifier_ip and verifier_ip are both used and easily get wrong..
Will push an update soon.

Just tested it, and can confirm it is working now. My vote is to merge it as is.

Just tested it, and can confirm it is working now. My vote is to merge it as is.


Images not displayed in wiki

Please take a look at the page: https://github.com/NetEase/pomelo/wiki/Pomelo-framework-overview:
Images are not displayed but shown as: "![MMO running Architecture] (images/mmo-arch.png)"
Seems like the space characters in md file should be deleted to make it display.

Same thing happens in: https://github.com/NetEase/pomelo/wiki/Pomelo-tools-libraries-introduction
Some of links are not displayed.


Add file watcher for pod labels, only override xds request node when …

…labels update
Please provide a description of this PR:
This is to reduce calling Agent.generateNodeMetadata by watching the files.
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
72c13b5330dc432015da7721c8513d9e0b1b03d7
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
72c13b5330dc432015da7721c8513d9e0b1b03d7
link
true
/test release-notes

integ-basic-arm64_istio
72c13b5330dc432015da7721c8513d9e0b1b03d7
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

Actually I think istio/proxy reads LABELS, so both this and the comment ^ may lead to unexpected results since those labels do not update

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test unit-tests-arm64

unit-tests_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test unit-tests-arm64

unit-tests_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test unit-tests

lint_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test unit-tests-arm64

unit-tests_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test unit-tests

lint_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test lint

integ-telemetry_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test unit-tests

lint_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test lint

integ-telemetry_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test integ-telemetry

unit-tests-arm64_istio
46a45fab6473828fda6ec64c44ecae79aba61cf5
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test lint

integ-telemetry_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test integ-telemetry

unit-tests-arm64_istio
46a45fab6473828fda6ec64c44ecae79aba61cf5
link
true
/test unit-tests-arm64

unit-tests_istio
46a45fab6473828fda6ec64c44ecae79aba61cf5
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry_istio
429de559c349b6bbe68db761e298cab43e90453e
link
true
/test integ-telemetry

unit-tests_istio
46a45fab6473828fda6ec64c44ecae79aba61cf5
link
true
/test unit-tests

unit-tests-arm64_istio
bad7b0e35aa2bb5e7f870aea5735ab36896ae1b1
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Thanks for rename the title


Access realms by parameter string_id.

Replaces get_realm() function by get_realm_by_string_id() function in zerver/tests.
Fixes #2226.

Automated message from Dropbox CLA bot
@reyha, it looks like you've already signed the Dropbox CLA. Thanks!

@reyha this looks pretty good, but it looks like it doesn't rebase cleanly onto master.  The rebasing sections of http://zulip.readthedocs.io/en/latest/git-guide.html would be helpful for you; it looks like you got into a little of git trouble by running git pull without the --rebase option, and thus creating some merge commits.
Since I think your intent was just to have 1 commit, I've gone ahead and cleaned this up into a single commit using the following process:
git reset --hard 57e7b741b6ace73fa08118d8d8bf8990cadae8e7 # This commit ID is what your merge commit includes
git checkout 6dc35115bc288dae469dcc860057a82fe541689e .
And then I merged the result as 9f8630fed8378827959aed3789ffe406449384eb.  Thanks @reyha!


added static typing to data_utils.py

#610

@Sanketh7 looks like the branch needs updating as well.


fix(e2e-mapi-v2): reorder resource clean-up in afterAll

Issue
https://gravitee.atlassian.net/browse/APIM-1410
Description
Delete the API before deleting the user to avoid error that the given user is still Primary Owner of an API.
Previous error: https://app.circleci.com/pipelines/github/gravitee-io/gravitee-api-management/23946/workflows/c4639ac3-5cf3-4d39-8c3c-2ae247909d4a/jobs/422080
Additional context

📚  View the storybook of this branch here

❤


ImmediateMesh ignores specified color

Godot version
4.0.beta.custom_build [c29fe310f]
System information
Linux Mint 21, Vulkan, NVidia GTX 1060
Issue description
When drawing with an ImmediateMesh, the colors passed with surface_set_color() are ignored, and all vertices are drawn with the same color. This happens for triangles as well as lines.
In the MRP below, adding an unshaded material in surface_begin() results in every vertex being white, otherwise they appear grey. In another project where I use ImmediateMesh, the color changes somewhat randomly from one run to another, but all vertices are the same color anyway.
Steps to reproduce
Create a MeshInstance3D, add an ImmediateMesh to it, draw some triangles and give them colors with surface_set_color().
Minimal reproduction project
ImmediateMeshColor.zip
This project draws a single triangle which moves around every frame. The color of each vertex is also supposed to change every frame, but the entire triangle appears pure white.
The desired color of one of the vertices is printed to the output every frame.

You have to set mat.vertex_color_use_as_albedo = true

Oh no, I can't believe I forgot to set this flag... now I'm not sure whether I was using it at all with ImmediateGeometry in Godot 3.x either.
Anyway, thanks for reminding me about this! I'm closing this issue.


chore: Add analytics events to log execution time for the light weight git status API

Description
Adds unit execution time events for git status without fetch and git fetch from remote APIs.
PR fixes following issue(s)
Fixes #26405
Media
N/A
Type of change

Chore (housekeeping or task changes that don't impact user perception)

Testing
How Has This Been Tested?

[x] Manual
[x] Jest
[ ] Cypress

Test Plan
Issues raised during DP testing
Checklist:
Dev activity

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test sha=8f55d96af5d9be2767c4f8939059ace7cb4555cf


Update the queue configuration

Hi,
I have an environment with N queues inside RabbitMQ.
All those queues don't have the "deadLetterRoutingKey" option and now I need it.
So with a new rascal configuration I added this option: "assert" is true and "check" is also true but when I start the application I have this message:
Error: Operation failed: QueueDeclare; 406 (PRECONDITION-FAILED) with message "PRECONDITION_FAILED - inequivalent arg 'x-dead-letter-routing-key' for queue 'my_service' in vhost '/': received the value 'service.dlq' of type 'longstr' but current is none"
Is there a way to "update" the queues opitions?
Nico.

Hi @nico3dfx,
No, unfortunately not. This is a limitation of RabbitMQ. You cannot redefine a queue or exchange. For queues you need to do something like...
Option 1 (keep the existing queue name)

Stop all messages from being published to the queue
Allow the queue to drain
Stop consuming from the queue
Delete the queue
Recreate the queue
Reapply the bindings
Start consuming from the queue again
Allow messages to be published again

Option 2 (use a different queue name)

Create a new queue
Consume from the old and new queue, tolerating duplicates
Start publishing to the new queue
Stop publishing to the old queue
Wait for the old queue to drain
Stop consuming from the old queue
Delete the old queue

There are other options too - for example, you can define a shovel to copy messages from one queue to another, or you could maybe daisy chain queues together where the end queue had the dead letter routing configuration etc, but I'm not aware of painless options unfortunately.

Something else you might consider in too, In RabbitMQ I believe you can define policies based on queue / exchange name. So for example, if you had a standard that said all work queues begin with the word "w_", and all dead letter queues begin with the "d_", you could apply default configuration to those queues and reduce the chance of forgetting important configuration.
If doing it in RabbitMQ isn't an option, you could write a wrapper module for your Rascal configuration which did something similar.


Is there a way to make sure your schema is well-formed according to the format defined by json-schema.org?

Environment

Nuget Package: JsonSchema.Net
Nuget Version: 3.2
OS: Windows
.Net Target: .Net 6 (Azure Functions)

How can I help you today?
I wanted to find out if there is any functionality in JsonSchema.Net that would help with the following issue.  We have looked through the documentation and haven't found anything explicit, but we definitely could have missed something.
Our team is new to using JSON schema validation.  Unfortunately we made a very newbie mistake in our schema files where we did not realize that for our array that we couldn't list the "properties" directly under the "type": "array" section - instead you need to have the “properties” listed underneath an “items”.  If you don’t have the nesting correct, the validations are ignored.
We have manually fixed the issue in our 4 schema validation files but we are worried that we have potentially missed other things too.
Is there anything in JsonSchema.Net that we could use to check to make sure our schema is well-formed according to the format defined by json-schema.org?
I see that there was a comment to create a Schema linter back in December 2020, but I don't see any follow-up.  Not sure if my request would fit under that area, but something like that would be helpful too.
Additional context

The JsonSchema type won't deserialize properly if the data doesn't match the expected model.  I look at that as a benefit of being in a strongly-typed language.
If you want to validate the JSON representation of the schema before deserializing it, meta-schemas do exactly that.  They're also hardcoded in the MetaSchemas static type.

Note: I have tried to follow the meta-schemas documentation but I am not seeing a path forward yet.  I am going to provide this comment on the deserialization piece and then I will go back to trying to figure out the meta-schemas approach.
I don't understand your comment about the JsonSchema type won't deserialize properly.
Here is a sample schema file that is well-formed JSON but it is not correctly nested according to the Schema Validation rules as the "type": "array" does not have the required "items" (and then the "properties" should be under the "items")
{
"$schema": "https://json-schema.org/draft/2020-12/schema#",
"type": "object",
"properties": {
"Data": {
"type": "object",
"properties": {
"myProperty": {
"type": "string"
},
"myArray": {
"type": "array",
"properties": {
"arrayProperty1": {
"type": "string"
}
},
"required": [
"arrayProperty"
]
}
},
"required": [
"myProperty",
"myArray"
]
}
},
"required": [
"Data"
]
}
We read the Schema contents from a file using File.ReadAllText storing that in a string variable.
Then we do JObject.Parse on that string variable to validate that it is well-formed JSON.
Then we do JsonSchema.FromText using that string variable.
Then we can use the following code snippet to convert the JsonSchema variable back to JSON and compare it - the items in the JsonSchema exactly match the value we imported - **
including the fact that the "items" is missing**.
JsonDocument jsonSchemaAsJsonDocument = jsonSchema.ToJsonDocument();
string jsonSchemaBackFromJsonDocument;

using (var stream = new MemoryStream())
{
    Utf8JsonWriter writer = new Utf8JsonWriter(stream, new JsonWriterOptions { Indented = true });
    jsonSchemaAsJsonDocument.WriteTo(writer);
    writer.Flush();
    jsonSchemaBackFromJsonDocument = Encoding.UTF8.GetString(stream.ToArray());
}

as the "type": "array" does not have the required "items"

I see what you're saying.  properties only pertains to object values and when a schema specifies that the type must be an array, something is probably wrong.
There's a lot of conversation going on in the specification repos around linting that you might be interested in.  The idea is to design an analyzer that can detect these sorts of mistakes.  I'm not sure which issues (if any) have been created to discuss this, but we've had a lot of discussion in the JSON Schema Slack workspace, and it's definitely in the queue of things to look at.
I have held off on implementing anything like this here because I want to make sure it's in line with whatever we decide over there.

For what it's worth, JsonSchema is completely serializable.  JsonSchema.FromText() is just a shortcut for
var schema JsonSerializer.Deserialize<JsonSchema>(text);

You can see the code here.
To get the string representation of the schema object, just serialize it again.
var schemaText = JsonSerializer.Serialize(schema, new JsonSerializerOptions { WriteIndented = true });

(You may also want to set Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping as the serializer is very aggressive when it comes to escaping characters.)

I have held off on implementing anything like this here because I want to make sure it's in line with whatever we decide over there.

Completely makes sense - I wouldn't want to have design something and then have to refactor it if it isn't in line with the decided patterns.  I will try to take a look at the specification repos later today or next week.

To get the string representation of the schema object, just serialize it again.

Yeah, that is a lot simpler compared to what I was doing :)


Add better partition string escaping

Based on the https://github.com/nils-braun/dask-sql/issues/179 this PR adds string escaping to non-integer partition values. Partitions like:
forecasted_business_day=2021-05-27

will now be wrapped like
forecasted_business_day="2021-05-27"

when executing the SQL

Codecov Report

Merging #180 (cdc603e) into main (bbfee5f) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              main     #180      +/-   ##
===========================================
- Coverage   100.00%   99.90%   -0.10%
===========================================
  Files           57       57
  Lines         2209     2200       -9
  Branches       303      303
===========================================
- Hits          2209     2198      -11
- Misses           0        2       +2

Impacted Files
Coverage Δ

dask_sql/input_utils/hive.py
90.47% <100.00%> (-9.53%)
:arrow_down:

dask_sql/utils.py
100.00% <0.00%> (ø)

dask_sql/context.py
100.00% <0.00%> (ø)

dask_sql/server/responses.py
100.00% <0.00%> (ø)

dask_sql/physical/rex/core/call.py
100.00% <0.00%> (ø)

dask_sql/physical/rex/core/over.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbfee5f...cdc603e. Read the comment docs.

Thank you so much @gallamine! I have added some thoughts to https://github.com/gallamine/dask-sql/pull/1 on that and #181. I think we need to solve both issues at the same time.

Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to allowlist to allow all future PRs from the same author to run.


Deploy Checklist: New Expensify 2023-05-29

Release Version: 1.3.20-5
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

[x] https://github.com/Expensify/App/pull/17781
[ ] https://github.com/Expensify/App/pull/18293
[x] https://github.com/Expensify/App/pull/18577
[x] https://github.com/Expensify/App/pull/19083
[ ] https://github.com/Expensify/App/pull/19295
[x] https://github.com/Expensify/App/pull/19322
[ ] https://github.com/Expensify/App/pull/19390
[x] https://github.com/Expensify/App/pull/19436
[x] https://github.com/Expensify/App/pull/19452
[x] https://github.com/Expensify/App/pull/19491
[ ] https://github.com/Expensify/App/pull/19521
[x] https://github.com/Expensify/App/pull/19547
[x] https://github.com/Expensify/App/pull/19551
[x] https://github.com/Expensify/App/pull/19566
[ ] https://github.com/Expensify/App/pull/19579
[ ] https://github.com/Expensify/App/pull/19582
[x] https://github.com/Expensify/App/pull/19599
[x] https://github.com/Expensify/App/pull/19610
[x] https://github.com/Expensify/App/pull/19622
[x] https://github.com/Expensify/App/pull/19625
[x] https://github.com/Expensify/App/pull/19639
[x] https://github.com/Expensify/App/pull/19644
[x] https://github.com/Expensify/App/pull/19649
[x] https://github.com/Expensify/App/pull/19659
[x] https://github.com/Expensify/App/pull/19663
[x] https://github.com/Expensify/App/pull/19666
[x] https://github.com/Expensify/App/pull/19668
[x] https://github.com/Expensify/App/pull/19674
[x] https://github.com/Expensify/App/pull/19680
[x] https://github.com/Expensify/App/pull/19719
[x] https://github.com/Expensify/App/pull/19734
[x] https://github.com/Expensify/App/pull/19748
[x] https://github.com/Expensify/App/pull/19758
[x] https://github.com/Expensify/App/pull/19759
[ ] https://github.com/Expensify/App/pull/19818
[ ] https://github.com/Expensify/App/pull/19841
[ ] https://github.com/Expensify/App/pull/19866

Internal QA:

[x] https://github.com/Expensify/App/pull/19739 - @danieldoglas

Deploy Blockers:

[x] https://github.com/Expensify/App/issues/19814
[x] https://github.com/Expensify/App/issues/19823
[ ] https://github.com/Expensify/App/issues/19839

Deployer verifications:

[ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
[ ] I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.20-1 :rocket:

:clap: Heads up @Expensify/applauseleads :clap:
A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.3.20-2 :rocket:

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.20-2 has been deployed to staging :tada:

A PR was CP'd to resolve the two blockers.

:clap: Heads up @Expensify/applauseleads :clap:
A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.3.20-3 :rocket:

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.20-3 has been deployed to staging :tada:

:clap: Heads up @Expensify/applauseleads :clap:
A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.3.20-4 :rocket:

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.20-4 has been deployed to staging :tada:

@Julesssss Regression is completed
PR https://github.com/Expensify/App/pull/18577 is failing https://github.com/Expensify/App/issues/19852. pls double check as we cant repro in prod.
 OK to check it off?
PR https://github.com/Expensify/App/pull/19579 is failing https://github.com/Expensify/App/issues/19814
PR https://github.com/Expensify/App/pull/19582 is failing https://github.com/Expensify/App/issues/18918
PR https://github.com/Expensify/App/pull/19610 is failing
https://github.com/Expensify/App/issues/19857. repro in PROD checking off
PR  https://github.com/Expensify/App/pull/19639 is failing
https://github.com/Expensify/App/issues/19848. repro in PROD checking off
PR https://github.com/Expensify/App/pull/19818 & https://github.com/Expensify/App/pull/18293 is failing https://github.com/Expensify/App/issues/19856

:clap: Heads up @Expensify/applauseleads :clap:
A new pull request has been :cherries: cherry-picked :cherries: to staging, and will be deployed to staging in version 1.3.20-5 :rocket:

:tada: All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.20-5 has been deployed to staging :tada:

Thanks @mvtglobally. I've reviewed all of these and think the only actionable issues are the three below. Could you please check my comments for these three? I think we're good to deploy but just want to confirm the following points:

PR https://github.com/Expensify/App/pull/19521 is blocked on Desktop. rest platforms are pass. OK to check it off?

A) Is testing blocked? It seems okay in the contributors video, so I think we're good ✅

PR https://github.com/Expensify/App/pull/19579 is failing https://github.com/Expensify/App/issues/19814

B) 🚧  - We CP'd this fix. And I can confirm it's working now on staging-- could you please retest though?

PR https://github.com/Expensify/App/pull/19582 is failing https://github.com/Expensify/App/issues/18918

**C)**❓ is that the correct link? It shows a two-week old issue

PR https://github.com/Expensify/App/pull/18577 is failing https://github.com/Expensify/App/issues/19852. pls double check as we cant repro in prod.

✅ - Not a blocker, but we'll need to fix the issue you raised

PR https://github.com/Expensify/App/pull/19295 is failing https://github.com/Expensify/App/issues/19813

✅ - Not a blocker

PR https://github.com/Expensify/App/pull/19390 is failing https://github.com/Expensify/App/issues/19855

✅  - Dupe of this one, but it's also not a blocker

PR https://github.com/Expensify/App/pull/19491 is failing https://github.com/Expensify/App/issues/19863. repro in PROD checking off

✅

PR https://github.com/Expensify/App/pull/19610 is failing https://github.com/Expensify/App/issues/19857. repro in PROD checking off

✅

PR https://github.com/Expensify/App/pull/19639 is failing https://github.com/Expensify/App/issues/19848. repro in PROD checking off

✅

PR https://github.com/Expensify/App/pull/19818 & https://github.com/Expensify/App/pull/18293 is failing https://github.com/Expensify/App/issues/19856

✅ - Nice find and we'll fix this, but it's not a blocker

Blockers are cleared
App timing shows some slow down over the past few weeks, but this is likely due to AddComment regression -- we should keep an eye on this
No new Firebase exceptions on iOS or Android

@Julesssss
We are good with https://github.com/Expensify/App/pull/19521. Testers retested and it can be checked off
https://github.com/Expensify/App/pull/19579 - retesting
https://github.com/Expensify/App/pull/19582 this is good to check off. Old issue still repro

That's great, thank you

@Julesssss  https://github.com/Expensify/App/pull/19579 is pass
https://github.com/Expensify/App/pull/19866 is pass on all but Desktop. Can you check Desktop on your side? It will take me a bit longer to validate

Okay, so I'm unable to verify on Desktop. But I think this is fine and not a blocker. The single desktop app issue is far less important than having the feature live in staging for our Render ATL demo.
I'm going to check off #19866 and leave a note on the issue

:shipit:


update go directive to 1.18

Issue: https://github.com/kubernetes/node-problem-detector/issues/691
Test: make test on golang:1.17.7 container.
Let me know, if there are other dependencies I need to consider.

/ok-to-test

/lgtm

/retest

@vteratipally looks like go mod vendor removes the vendored ginkgo/ginkgo folder completely, leading to make e2e-test failure. Probably it's not picking up the make file dependency on it.
This also happens in current master. Is there a good way to resolve this?


List requirements for pomo

The necessary requirements for running pomo should be mentioned somewhere in the README or the install script.
For example, on my laptop with os x, I got an error about notify-send:
λ ~/projects/pomo/ main pomo
Traceback (most recent call last):
 File "/Users/felix/bin/pomo", line 30, in <module>
   from internal.notify import notify_and_print
 File "/Users/felix/projects/pomo/internal/notify.py", line 7, in <module>
   (run(['notify-send', '-v'], stdout=DEVNULL, stderr=DEVNULL).returncode == 0)
 File<EMAIL_ADDRESS>line 505, in run
   with Popen(*popenargs, **kwargs) as process:
 File<EMAIL_ADDRESS>line 951, in __init__
   self._execute_child(args, executable, preexec_fn, close_fds,
 File<EMAIL_ADDRESS>line 1821, in _execute_child
   raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'notify-send'

Ah right. notify-send, by the way, is a part of libnotify, usually already included in Linux systems (which is where I tested this).
I'll add a note to the README.

Resolved in d87d43c.


Ubuntu and Fedora packaging

We should have Ubuntu packages for 16.04, 16.10 and 17.04, as well as Fedora 25.
This involves:

Creating the packages (#111).
Having some repository where they can be stored and downloaded (created some on bintray).
Attaching the above two to make release.

Done!


User interrupts do not trigger in tight loops

GraalSqueak currently does not check for interrupts in case of back-jumps. Therefore, tight loops (without message sends) cannot be interrupted by the user.
Repro: [ 1 + 1 ] bench, then try to trigger a user interrupt.

Idea: ensure that interrupt handler is triggered in the presence of a loop without non-primitive sends.


add v2 with github.com/hyperledger/fabric-protos-go-apiv2

it's an alternative to pr
you can choose one of them or propose a 3rd alternative
https://github.com/hyperledger/fabric/issues/3650

For the fabric repositories, we have not followed this approach, we've followed the approach in https://github.com/IBM/idemix/pull/47.


Fix dspy Module's deepcopy

The current solution has issues if dspy.BaseModule contains non-copyable instances. The proposed approach is:

Get all attributes, if it is a BaseModule, try deep copying, if failed then do recursive call.
If the attr is not a BaseModule, try deep copying, if failed try shallow copying, if still failed just copying over the reference.
It won't hit infinite recursion because once a module has no attributes that is a BaseModule, the recursion stops.

Added unit tests to test it.

This ... is probably OK? Do we want to issue a warning on the first deepcopy that faces trouble and tell the user about it? I worry about silent bugs. People do expect deep copy to give them a real deep copy, but maybe we can explain that it only guarantees a deep copy of DSPy-related attributes.

@okhat  Yea I think that would be fine, but I will keep monitoring if this is causing trouble for users.