docs(navbar): fix a typo

Short description of what this resolves:
This adjusts the text of the navbar documentation to fix a typo.
Changes proposed in this pull request:

fix a typo

Ionic Version: 2.x

Thanks!


Log when a URL fetch in JSONData fails rather than failing the whole scan

The change is small,  instead of passing the error up, which would cause the clone to fail and the JSONData to not be scanned. This logs that a URL was unable to be fetched, passing back no error and allowing scanning to continue.
This is a short term solution until we improve our general error handling. Allowing fatal/nonfatal errors to be floated up to the application.
Added a few items to the to do list, including the aforementioned error handling.

Merging per agreement with bplaxco. This is a temporary fix that allows the intended behavior, whilst we improve our overall fatal/nonfatal error handling.


Explorer: Sender, recipient naming standardization

We are using from/to as well as sender recipient inconsistently across the explorer when it comes to transactions.
@666lcz @Jibz1 Correct me if I'm wrong I remember in an earlier issue we aligned on using sender/recipient naming.

@bwann52 , there are three transaction types:

TransferCoin
Move Call
Publish

Only the first type has the concept of  "sender" and "recipient", and for the second and third type, "Transaction Initiator"/"from" is a more appropriate term. Should we have different annotations(for first type we show: sender and recipient; for the other types we show Initiator/from) in the landing page, or should we just consistently use from/to everywhere?

@666lcz good call out.
In this case, I think using "By" is easier to understand than "Initiator"
For aggregated pages (for example, list of recent transactions), for all three let's use "By". And "To" when it makes sense (for transfer and publish)
TransferCoin: By/To
Move Call: By
Publish: By/To
For detailed view (once you click in):
TransferCoin:  Sender/Receiver
Move Call: Caller/Package Called
Publish: Publisher/Package Published
Let me know if the above make sense. The goal is to use human friendly language.

The source of truth is the design mockups


regex sometimes hangs when trying to search non-ASCII source text

Description
What steps will reproduce the problem?

I am parsing a file containing all sorts of weird characters, but treating it as if it were ANSI.
I have a somewhat complicated regex expression.
The regex search sometimes fails in two ways.
(1) More commonly the generator from re.finditer seems to be successfully created, but when looping with a "for ... in ...:" structure after iterating through to the last genuine match, it then loops to a further fictious match and then hangs.  That is when running the file normally or in the debugger.
(2) In this case I was debugging and the regex hung immediately after calling re.search (in an imported module).
Traceback
  File "C:\Program files (portable)\WinPy_3-8\WPy64-3830\python-3.8.3.amd64\lib\site-packages\spyder\plugins\ipythonconsole\widgets\namespacebrowser.py", line 96, in get_value
    return self.call_kernel(
  File "C:\Program files (portable)\WinPy_3-8\WPy64-3830\python-3.8.3.amd64\lib\site-packages\spyder_kernels\comms\commbase.py", line 537, in __call__
    return self._comms_wrapper._get_call_return_value(
  File "C:\Program files (portable)\WinPy_3-8\WPy64-3830\python-3.8.3.amd64\lib\site-packages\spyder\plugins\ipythonconsole\comms\kernelcomm.py", line 131, in _get_call_return_value
    return super(KernelComm, self)._get_call_return_value(
  File "C:\Program files (portable)\WinPy_3-8\WPy64-3830\python-3.8.3.amd64\lib\site-packages\spyder_kernels\comms\commbase.py", line 415, in _get_call_return_value
    self._wait_reply(call_id, call_name, timeout)
  File "C:\Program files (portable)\WinPy_3-8\WPy64-3830\python-3.8.3.amd64\lib\site-packages\spyder\plugins\ipythonconsole\comms\kernelcomm.py", line 142, in _wait_reply
    self._wait(got_reply, self._sig_got_reply, timeout_msg, timeout)
  File "C:\Program files (portable)\WinPy_3-8\WPy64-3830\python-3.8.3.amd64\lib\site-packages\spyder\plugins\ipythonconsole\comms\kernelcomm.py", line 168, in _wait
    raise TimeoutError(timeout_msg)
TimeoutError: Timeout while waiting for {'3f415961d7bb40758874483d85d38ac0': (False, <bound method ShellWidget.remote_set_cwd of <spyder.plugins.ipythonconsole.widgets.shell.ShellWidget object at 0x0000017532028D30>>), '026462dd222441e1ae932997c06f3294': (False, <bound method ShellWidget.remote_set_cwd of <spyder.plugins.ipythonconsole.widgets.shell.ShellWidget object at 0x0000017532028D30>>), 'f2c5f495478f4d5e886b11d2cb6bcb74': (False, <bound method ShellWidget.remote_set_cwd of <spyder.plugins.ipythonconsole.widgets.shell.ShellWidget object at 0x0000017532028D30>>), '0994e966213d497fa58e22ed98a7301a': (False, <bound method ShellWidget.remote_set_cwd of <spyder.plugins.ipythonconsole.widgets.shell.ShellWidget object at 0x0000017532028D30>>), '43907024bcc943f7928a767ac677b835': (True, None), '86e38be36ddd48d0953122011fcacc12': (True, None), 'fed3f10fd78d43fc8b8a1695372f0bec': (True, None), 'c881786c090a4e35b13fe56af7672b64': (True, None), '83321a208c564b4292faee9e067ce13f': (True, None)}

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Program files (portable)\WinPy_3-8\WPy64-3830\python-3.8.3.amd64\lib\site-packages\spyder\plugins\variableexplorer\widgets\collectionseditor.py", line 1040, in copy
    obj = self.delegate.get_value(idx)
  File "C:\Program files (portable)\WinPy_3-8\WPy64-3830\python-3.8.3.amd64\lib\site-packages\spyder\plugins\variableexplorer\widgets\collectionseditor.py", line 1383, in get_value
    return self.parent().get_value(name)
  File "C:\Program files (portable)\WinPy_3-8\WPy64-3830\python-3.8.3.amd64\lib\site-packages\spyder\plugins\variableexplorer\widgets\collectionseditor.py", line 1438, in get_value
    value = self.shellwidget.get_value(name)
  File "C:\Program files (portable)\WinPy_3-8\WPy64-3830\python-3.8.3.amd64\lib\site-packages\spyder\plugins\ipythonconsole\widgets\namespacebrowser.py", line 101, in get_value
    raise ValueError(msg % reason_big)
ValueError: The variable is too big to be retrieved.

Note: Please don't report this problem on Github, there's nothing to do about it.

Versions

Spyder version: 4.1.3
Python version: 3.8.3
Qt version: 5.14.2
PyQt5 version: 5.14.2
Operating System: Windows 10

Dependencies

# Mandatory:
atomicwrites >=1.2.0           :  1.4.0 (OK)
chardet >=2.0.0                :  3.0.4 (OK)
cloudpickle >=0.5.0            :  1.4.1 (OK)
diff_match_patch >=20181111    :  20181111 (OK)
intervaltree                   :  None (OK)
IPython >=4.0                  :  7.14.0 (OK)
jedi >=0.15.2                  :  0.17.0 (OK)
nbconvert >=4.0                :  5.6.1 (OK)
numpydoc >=0.6.0               :  0.9.2 (OK)
paramiko >=2.4.0               :  2.7.1 (OK)
parso >=0.5.2                  :  0.7.0 (OK)
pexpect >=4.4.0                :  4.8.0 (OK)
pickleshare >=0.4              :  0.7.5 (OK)
psutil >=5.3                   :  5.7.0 (OK)
pygments >=2.0                 :  2.6.1 (OK)
pylint >=0.25                  :  2.5.2 (OK)
pyls >=0.31.9;<0.33.0          :  0.32.0 (OK)
qdarkstyle >=2.8               :  2.8.1 (OK)
qtawesome >=0.5.7              :  0.7.2 (OK)
qtconsole >=4.6.0              :  4.7.4 (OK)
qtpy >=1.5.0                   :  1.9.0 (OK)
sphinx >=0.6.6                 :  3.0.3 (OK)
spyder_kernels >=1.9.1;<1.10.0 :  1.9.1 (OK)
watchdog                       :  None (OK)
zmq >=17                       :  19.0.1 (OK)

# Optional:
cython >=0.21                  :  0.29.19 (OK)
matplotlib >=2.0.0             :  3.2.1 (OK)
numpy >=1.7                    :  1.18.4 (OK)
pandas >=0.13.1                :  1.0.3 (OK)
scipy >=0.17.0                 :  1.4.1 (OK)
sympy >=0.7.3                  :  1.5.1 (OK)

I forgot to say that in the second instance while the debugger seemed to be stuck (as if processing an infinite loop or something) I went to the variables explorer pane and tried to copy a string variable's content, which was the path to a file.
After no immediate response, after 5 to 10 seconds I got several warning/error messages stating that the variable was too big to copy.

These are pretty annoying, because when they happen the only thing to do is close down the console or the kernel.  The button to "Stop the current command" doesn't work at all.

I am stepping through the second issue, and the code hangs when it gets to
the last line of
def _compile(pattern, flags):
which is
    return p

By the way, although the source text is someone long (about 15 MB), that is not the cause of the problem.  The same code can be run successfully on files of similar content that are twice as large (although it might take a dozen seconds, it doesn't hang for the other files I read in).

@DIV-on-github thanks for the report.
Could you please share with us a minimal reproducible example of what you are doing step by step (with some example content) so that we can reproduce it on our side?
Thanks

I would like to, but it could be a large amount of work for me to find the responsible characters in the files that are read in, because:
(1)  often they can be analysed without error;  and
(2)  previously every time the analysis failed Spyder would hang for an unlimited amount of time.
I finally managed to implement the wrapt_timeout_decorator
https://github.com/bitranox/wrapt_timeout_decorator/blob/master/README.rst#use-with-windows
so that at least I can get an exception after a specified duration.
If I can isolate it further I'll report back.


Editor: can't edit/create CollisionPolygon2D's polygons

Operating system or device - Godot version:
Latest commit of Godot on Linux (Lubuntu 17.04)
Issue description:
after selecting a CollisionPolygon2D in the editor and pressing the pencil icon (create polygon from scratch) clicking on the 2d editor window doesn't do anything.
What it was expected to do
create and edito polygons for the CollisionPolygon2D
Steps to reproduce:
select a CollisionPolygon2D, select pencil icon and attempt to draw polygons

See this PR and this issue.
Could be a duplicate.

Assumed fixed by 41c3ca35.

It didn't

it didn't @akien-mga

tested it, works fine


Pokemon beeing discovered to late

there are quite some Pokemon beeing discovered to late (far) after the GIVE_UP_KNOWN timeout
and the number of delayed discoveries is far higher than the errors which could cause it.
     56 Empty GetMapObjects response for [Account]. Speed: [speed]
    330 ServerDisconnectedError during hashing.
    649 Nothing seen by [Account]. Speed: [speed]

since I added https://github.com/Noctem/Monocle/pull/179 the number of late discovered Pokemon has gone done by about 75%

the Number of Nothing seen by [Account]. Speed: [speed] goes down masivly if the altitude is not random but correct (I had removed that message as it was spaming to much)

Status Update, currently about 1/40 visits is failing
Visits: 407593, per second: 5.97
Skipped: 0, unnecessary: 1123
Failed: 366, without fixed: 10431

I ran into what seems to be a similar issue possibly because the spawnpoint time may have changed and/or incorrectly identified and/or it was late in scanning. I had an Unown that got detected with 44 minutes left before despawn (8:06PM). Most detections show around 29 minutes or 14 or 59, so seeing a 44 seemed off.  A Rocket Map scanner detected the same Unown, but it was for 29 minutes (despawn 7:36PM).  I had a couple users state that the 8:06PM time was wrong because it wasn't there when they arrived.  Is there a check to see if after maybe 3 consecutive scans of a spawnpoint, if it doesnt fall within the expected range (14, 29, 59 - skip_spawn minutes left), then it should be tagged as unknown and TTH rediscovered on it?


Birdnet v1.4 crashing on a spawned process

Describe the bug
File "C:\git_repo\BirdNET-Analyzer\birdnet_analyzer\analyze.py", line 685, in      if os.get_terminal_size().columns >= 64: OSError: [WinError 6] The handle is invalid
Basically i am spawning a process from java.
If i edit source to remove the acii bird it starts working fine again.
this happens in both windows and ubuntu.
I can run it fine in a normal terminal.
thanks.
-mp

You're right makes total sense, thanks for getting back to us. I'll wrap it in a try-catch.


New logo/icon proposal

Good day sir. I am a graphic designer and i am interested in designing a logo for your good project. I will be doing it as a gift for free. I just need your permission first before I begin my design. Hoping for your positive feedback. Thanks

Thanku I dont have any problem.Thanku for appreciation
On Thu, May 30, 2019 at 12:32 AM mansyaprime<EMAIL_ADDRESS>wrote:

Good day sir. I am a graphic designer and i am interested in designing a
logo for your good project. I will be doing it as a gift for free. I just
need your permission first before I begin my design. Hoping for your
positive feedback. Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/singhbhavneet/Bungee/issues/4?email_source=notifications&email_token=AHNBPHB6FGCOGJ4LEREYWBLPX3HL3A5CNFSM4HQRAUW2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GWSAOYQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHNBPHGBZI5ZL5GTEJBRSDDPX3HL3ANCNFSM4HQRAUWQ
.

I see this logo too familiar. Are you not interested if I submit a logo that is unique and might interest you?

Ok no problem
On Thu, 30 May 2019, 01:49 mansyaprime<EMAIL_ADDRESS>wrote:

I see this logo too familiar. Are you not interested if I submit a logo
that is unique and might interest you?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/singhbhavneet/Bungee/issues/4?email_source=notifications&email_token=AHNBPHG5F2DIQFNOPMP65L3PX3QMRA5CNFSM4HQRAUW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWQQY4Y#issuecomment-497093747,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHNBPHCEK7T6RRCFBRGHV53PX3QMRANCNFSM4HQRAUWQ
.

Hi sir. I have completed the design for this project. do you like it ? if yes please tell me which one you like. and if there are changes please let me know

2nd one is good

Hi sir. I have done all this. and also uploaded all the files to this Drive. and I have also sent you PULL REQUESTS. please check


[Hub Generated] Review request for Microsoft.Maps for swagger completeness fix

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[x] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[x] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

We had 1 case of live validation which showed that we do not document the following operation in our swagger. The operation is not entirely used often by customers and most RPs do not document the api. I'm adding the operation to mark 100% completeness coverage on the affected api version. I'd like to request exception given the live traffic validation was only available after we published this API a few weeks ago.

@stack111,  could you follow the http://aka.ms/bcforapi to review this change? The review board would review your request based on your justification.


Flickering controls and stream unavailable/record -on/off

Hi
I cant make the last step of my setup to work. Frigate recives my Tapo camera streams no issues. I have set up and configured Home assistant and Tapo Camera controls. Everything fine. But when i add Frigate integration in Home Assistant the camera controls starts to flicker between unavailable and active (but unusable since its flickering every second. The video stream appears in home assistant when i add Frigate but it also flickers in the same way between unavailable and recording.
Tried everything i can figure. Reinstalled, tried all types of settings and also opened the ports suggested here:
https://community.home-assistant.io/t/custom-component-tapo-cameras-control/231795
Any input apprechiated.

Solved it. Had to disable the cameras in Frigate Integration as they also was integrated vua Tapo Camera Control (wich i thought was just a control) So it appeared it caused a conflict with dual streams of the cameras. At least i think so.


Fix train

Add new functionalities to FeatureSelection class:

include now accepts only one element
Module preprocesses the incoming dataset only at the beginning.
Minor corrections.

To avoid possible bugs, the attribute number_features has been remodelled. Now, it is a float number between (0, 1) representing the percentage of features that the user want to keep each iteration.
In this way, number_features = 0.75 means that the model will choose 75% of the best features in each iteration, removing the remaining 25%.
This change allows removing the attribute feature_division, which could lead to various errors in edge cases.

How do you control the number of total iterations?

How do you control the number of total iterations?

For now, that is something that is not possible to do. One can iterate the program only once by defining the same number_features and target_features.


Fix HA camera deprecated constant

Since HA core 2024.1.0 supported_features should use the CameraEntityFeature IntFlag
https://developers.home-assistant.io/docs/core/entity/camera/#supported-features
SUPPORT_STREAM will be removed in HA Core 2025.1
Fixes https://github.com/rroller/dahua/issues/328
PR for fixing Light deprecated constants will follow

Thank you!

Released in https://github.com/rroller/dahua/releases/tag/0.9.53


[DependencyScanning] Treat main source module as a Swift dependency node in cycle resolution graph

Otherwise Swift Overlay paths do not get printed for dependency cycles where the sink is the same module as the source module being built.

@swift-ci smoke test

@swift-ci smoke test


Add inotify-tools to elixir phoenix postgres template

inotify-tools is required in linux environments for live code reloading with Phoenix. Users seeking to use this template to development will be met with a warning when starting a phoenix project for the first time and will need to install it manually. Adding it as a dependency to the dev container would avoid that and help people get going quicker.
I wasn't sure if it would be clearer to put this as a seperate install command, but it felt like it made most sense to put it next to build-essentials. Happy to move it if needed.
ref: https://hexdocs.pm/phoenix/installation.html#inotify-tools-for-linux-users

@idyll @talk2MeGooseman As you're listed as contributors for this template, would love to hear your thoughts.

I agree with this change, I have been finding myself adding this to my personal setup so sharing it for everyone seems like a solid change.

Thanks for confirming! I'll merge this in now.

Thanks both!


Implement special treatment in cards mode for Earth Temperature Timeline (#1732)

Speaks for itself, really.

Perhaps it would be better to prevent this scenario entirely—crop tall comics to a certain size for cards mode.


SAK-31443: Added option in sites to disable presence tool

Allows instructors or site maintainers to edit visibility of the presence tool across their individual sites.

Thanks for this, generally it looks good.
One thought, if the user views the manage access page and clicks update, by default on a site I think the users present tool will be disabled for that site, is that correct?

Hey @buckett, I modified the code to allow for

@buckett: I've updated the commit with your suggestions, and left a line note in response to your suggestions in most of them.

The site property to turn on or off presence on a site already exists (it's display-users-present) it's right there on line 822. I don't think there's any changes needed to portal.
It looks like you're adding this as a controlable feature to site info, I guess that's okay, but it should also be available in either the true or false case, just not possible to override in the never/always.

@jonespm That makes sense, I'll go ahead and update it so that the site property is stored as 'display-users-present'.


Is it possible to run mmdetection without a NVIDIA GPU?

I have an AMD GPU and when I am trying to python setup.py develop I get the OSError: CUDA is required to compile MMDetection! error. I have installed the cuda toolkit and I can see it in the conda list. So my question is, if there is any way to run mmdetection with my current hardware. I am sorry if my question is stupid and thank you in advance for your help.

similar issue: https://github.com/open-mmlab/mmdetection/issues/6311
I think if you have installed mmcv successfully, you can install mmdet without any error.

I met same question!How can I solve it?

I met same question!How can I solve it?


Using Char

Hello all,
I am having an issue with using Characters in Eff
Whenever I use it, it says "unrecognised symbol" or "parser error"
The main reason why I want to use it is to be able to use the Split function from OCaml
external split_on_char : char -> string -> string list = "split_on_char"

I did everything to add Char as a type and it compiled << you can see that in my Pull-request
but I noticed that it cannot parse Char properly  << maybe the single quote is the problem
let m = '4';;
let k = 's' ;;

The single quote currently has no special meaning in Eff as far as I could tell from the lexer.
So you would actually have to additionally adapt the lexer, the parser, and probably the core syntax, sugared syntax and the desugar phase.
Which seems like a serious amount of work.
Are you sure you cannot make a similar function that just uses strings instead of char?
You can always do an additional check, to make sure that the input makes sense for your function and raise an error otherwise.

I like the other idea more
I will do my best
Thanks

I used this method to get the first char of the string which is the only one
and it worked
val get : string -> int -> char

Thanks!

@zigaLuksic : it's not that much work. It sounds like half an hour of work, so it's probably about two hours of work.


Grunt error: >> Error: libsass bindings not found. Try reinstalling node-sass?

I've run npm install, made sure node-sass is in package.json ... devDependencies & is installed globally. Can't get past the error >> Error: libsassbindings not found. Try reinstallingnode-sass?
Reinstalling hasn't helped (else I wouldn't be here!) and I'm puzzled at this.
I'm on OS X (10.10.2), npm 2.3.0, node-sass 2.0.1, grunt 0.4.5.

Which version of node.js or io.js you are testing with?

0.12.0
I blew away everything in node_modules & re-ran npm install - that fixed it.

Awesome! Congrats. :smiley: :+1:


Server Crash When Placing Mailbox [Fabric 1.19.3, 1.0.1 Beta]

crash-2023-01-09_07.02.09-server.txt
Crafted a pink mailbox, went to place outside my home and it crashes the server everytime.

Fixed in 1.0.2


Docker

How we are differentiating pid 1,17...etc of docker containers with Host's 1,17..etc pid's? and what kernel changes are happening when we craete a new process inside the docker container?

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Closing as this is not an issue.
Please use the docker-user mailing list to discuss these kinds of questions.


Production deployment

Question
Hi,  What is the best infrastructure and methodology to deploy llava for a production-grade application? Is a local application server like Ollama advisable? Do you know of other possible methods? Apart from ollama, llama.cpp is something that comes to mind. Have not tried triton-llm.

Sglang supports llava
https://github.com/sgl-project/sglang


Proposal: Introduce yocto release branches for backwards compatibility

My propsal is to intruduce yocto release branches (e.g. krikstone, mickledore) for backwards compatibility. When someone is using kirkstone, there are no surprises when meta-slint upgrades to a new yocto version.
Yocto release names can be found here: https://wiki.yoctoproject.org/wiki/Releases

I think that makes sense to introduce when a divergence happens. Ideally master is usable with multiple yocto versions. But I guess that won't work for very long.
Too bad GitHub Actions are not suitable for CI - I'm concerned that multiple branches increase the amount of effort to maintain.

You are right, as long as there is no deviation between the versions, extra branches just increase the amount of work to do. I was just feeling uneasy including master as branch into my manifest file 😄

I've switched meta-slint over to use meta-rust-bin, and I've added a CI that tests at least builds with kirkstone and scarthgap. I'll close this as not planned until other evidence arises that suggests that we should add branches.


feat: fall back to embedded config directory when looking up $import target

This change allows user-defined templates to reference the master template using ~/ without having to copy them into the priority directory. If the referenced template is not found in the priority config directory, it will be looked up in the internal config dir instead.
This also works for manufacturer templates, but they must be referenced with a ~/ path too, e.g. ~/0x1234/templates/manufacturer_template.json instead of templates/manufacturer_template.json.
fixes: #3471

@zwave-js-bot automerge


There is still miss wording at 'split view' tab in Korean ;)

separate vertical is "왼쪽/오른쪽으로 분할" that means "left/right"
separate horizontal is "위/아래로 분할" that means "up/down"
there is mismatch. :D

@zeakd Can you please raise a PR with the fix. Thanks.

@zeakd Thanks for pointing out.
Will it be possible for you to raise a PR with the fix and add someone for linguistic review. Thanks!

@zeakd Basically, the Vertical split option causes the main editor to be split vertically into 2- left and right editors; while Horizontal Split does the same into top and bottom. Hence, the Korean string "left/right split" is used for vertical split and "top/bottom split" for horizontal split.
Hope that resolves your confusion.

You can verify that the "left/right split" and "top/down split" options split the main editor as per the name.

I checked. thanks!


Rolling Attack and Damage not working

Uncaught (in promise) TypeError: r._handleResourceConsumption is not a function at o (modify-rolling.js:191)
for (const target of targets) {
		const allowed = await item._handleResourceConsumption({ isCard: false, isAttack: true });
		const targetActor = target.actor ? target.actor.data : null;

Little addition - FVTT 0.7.8
P.S. Problem related to new release of dnd5e system 1.2.0. Roll back to previous version make problem disappeared

Little addition - fancy form doesn't work at all.
Foundry version 0.7.8.

This won't be fixed, only update for mess that will be coming (regarding rolling issues) is removing them.
My replacement is now submitted and waits for approval. Meanwhile you can download the module and look at its features from its repository:
https://github.com/Moerill/fvtt-mars-5e
Manifest: https://raw.githubusercontent.com/Moerill/fvtt-mars-5e/master/module.json


doesn't support git worktree

In a git worktree, there's no .git/HEAD file, so gitHeadPath will return an error path.
Consider using  find-git-root instead of findup-sync

I changed the code to use find-git-root, but unfortunately that's not the only change needed, as there is no .git/HEAD either inside the worktree reference, the HEAD is directly inside the git root. @jonschlinkert if I open a PR can we get this fixed?

Yes absolutely! A PR would be great.
Sent from my iPhone

On Feb 18, 2021, at 6:18 PM, Joscha Feth<EMAIL_ADDRESS>wrote:

I changed the code to use find-git-root, but unfortunately that's not the only change needed, as there is no .git/HEAD either inside the worktree reference, the HEAD is directly inside the git root. @jonschlinkert if I open a PR can we get this fixed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

here you go: https://github.com/jonschlinkert/git-branch/pull/14

Any chance to get this in?
On Fri, 19 Feb 2021, 10:53 Jon Schlinkert<EMAIL_ADDRESS>wrote:

Yes absolutely! A PR would be great.
Sent from my iPhone

On Feb 18, 2021, at 6:18 PM, Joscha Feth<EMAIL_ADDRESS>wrote:

I changed the code to use find-git-root, but unfortunately that's not
the only change needed, as there is no .git/HEAD either inside the worktree
reference, the HEAD is directly inside the git root. @jonschlinkert if I
open a PR can we get this fixed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jonschlinkert/git-branch/issues/10#issuecomment-781712076,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABN5BTRENW3NHVVHXZ6D3LS7WSADANCNFSM4LQXYJXQ
.

@jonschlinkert please let me know if there is anything else I can do to get this in. The PR is fairly minimally invasive adds a test and will allow us to close a few other issues. Would be great to get it merged. If you do not want to merge it, that is okay as well, but please let me know as then I might fork this project and publish it independently.

If this is about the work of the npm publish itself I am happy to do it of you add me to the package.

That would be great to get it in, @jonschlinkert

Nice fix @joscha hope it gets merged soon.

+1

Any updates on this? It would be great to get this merged in!

I published the fixes for this via https://www.npmjs.com/package/@fork-of/git-branch


move code from cluster-debug-tools for reuse in origin

Needed for cert ownership checking.

/retest


Implement estimators and attacks for NLP tasks

We would like to implement a first set of estimators and attacks for NLP tasks.
More information to follow soon.

Hi, is there any update on this?


refactor: align runtime condition of HarmonyImportDependency

Summary
Align ConditionalInitFragment with webpack
Pass webpack-test/hotCases/conditional-runtime/accept-conditional
Require Documentation?

[x] No
[ ] Yes, the corresponding rspack-website PR is __

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #5636

PR #5643   👈

This stack of pull requests is managed by Graphite.

!bench


Disable setting keymaps when they are nil

Is your feature request related to a problem? Please describe.
I am using Lazy for configuration that loads lazily plugins when keys are mapped. However, setting insert_date_map to nil or empty string raises error in date-time-inserter.nvim
Describe the solution you'd like
Allow insert_*_map keys to be nil or empty without error.
Describe alternatives you've considered
I tried with nil and empty strings for the mapping of insert_date_time_map without success.
Additional context
Example of my configuration:
  {
    "AntonVanAssche/date-time-inserter.nvim",
    ft = "markdown",
    opts = {
      date_format = "DDMMYYYY",
      date_separator = ".",
      time_format = 24,
      insert_date_map = "",
      insert_time_map = "",
      insert_date_time_map = "",
    },
    keys = {
      {
        "<leader>tt",
        "<cmd>InsertDateTime<cr>",
        desc = "Insert date and time.",
      },
      {
        "<M-;>",
        "<cmd>InsertDateTime<cr>",
        mode = { "i" },
        desc = "Insert date and time.",
      },
    },
  },

The fix has been merged into the master branch. I'm closing this issue now. If you encounter any further issues or have additional concerns related to this matter, please feel free to reopen this


I want to fetch Only Image. I mean I don't want to set it for image view.  I want only image Using Kf.

Check List
Thanks for considering to open an issue. Before you submit your issue, please confirm these boxes are checked.

[x] I have read the wiki page and cheat sheet, but there is no information I need.
[x] I have searched in existing issues, but did find a same one.
[x] I want to reoprt a problem instead of asking a question. It'd better to use kingfisher tag in Stack Overflow to ask a question.

Issue Description
What
[Tell us about the issue]
Reproduce
[The steps to reproduce this issue. What is the url you were trying to load, where did you put your code, etc.]
Other Comment
[Add anything else here]
@gscalzo @danhollywells @korzonek @orta @krider2010 @

Please use related method in KingfisherManager. Read our cheat sheet for more.

I read it but didn't get.
Thanks
@onevcat


blog.html produces errors in Google's Structured Data Testing Tool

When checking the validity of blog.html in Google's Structured Data Testing Tool, the BlogPosting sections contain multiple errors:

The details of these errors include:

Missing Author
Missing Date published
Missing Image
Missing Publisher
Warning: Missing modified date

Thanks. The latest commit fixes these validation errors.


Has PQ been tested?

https://github.com/vqdang/hover_net/blob/909ef03d560a249a43d27bb8f4b677c7e4e410ee/src/metrics/stats_utils.py#L152
Hi @vqdang @simongraham
When I feed this image (just random polygons with unique digits per polygon) for example into get_fast_pq function as both prediction and truth

I get an error:
----> 1 compute_fast_pq(y_t1, y_t2)

~/ds-field-boundaries/segmentation/utils/score.py in compute_fast_pq(true, pred, match_iou)
     55             if pred_id == 0: # ignore
     56                 continue # overlaping background
---> 57             p_mask = pred_masks[pred_id]
     58             total = (t_mask + p_mask).sum()
     59             inter = (t_mask * p_mask).sum()

IndexError: list index out of range

When it should produce a score of 1.
Could you please clarify? Maybe I am missing something obvious here

hi @jgamper check this please, https://github.com/vqdang/hover_net/blob/master/src/metrics/sample_stats.py
And about that error, that happened because the ID for each object in either pred or true likely isn't contiguous. Please call remap_label beforehand.
https://github.com/vqdang/hover_net/blob/909ef03d560a249a43d27bb8f4b677c7e4e410ee/src/metrics/stats_utils.py#L165-L168

@vqdang as I pointed out above pred and true are exactly the same array, so the issue is not within  contiguous.

@jgamper could you attach the .png of that image then? It's still working fine for sample_stats.py. Here is the piece I replaced to test same input.

import argparse
import math
import os
import random
import re  # regex

import cv2
import matplotlib.pyplot as plt
import numpy as np
import scipy.io as sio
from matplotlib import cm

from stats_utils import *

#####
def compute_stat():
    true   = cv2.imread('sample/true.png', cv2.IMREAD_GRAYSCALE)
    pred_1 = cv2.imread('sample/pred_1.png', cv2.IMREAD_GRAYSCALE)
    pred_2 = cv2.imread('sample/pred_2.png', cv2.IMREAD_GRAYSCALE)

    true   = remap_label(true, by_size=False)
    pred_1 = remap_label(pred_1, by_size=False)
    pred_2 = remap_label(pred_2, by_size=False)
    pq_info = get_fast_pq(pred_1, pred_1, match_iou=0.5)[0]
    print(pq_info)
    exit()

# ##
if __name__ == '__main__':
    compute_stat()

here is a png ground truth as requested. Feed it as  prediction and ground truth as mentioned aboce.

@jgamper
Here is the content of your .png

np.unique(jev)
array([ 0,  1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 14, 15, 16,\n       17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33,\n       34, 35, 36, 37, 38, 39, 40, 41, 43, 44], dtype=uint8)

I'm seeing 42 is missing there so your ID is not contiguous.

Fixing the label gives normal result

Great! Thanks for pointing out the error on my side!

@jgamper Additionally, your uploaded .png still has lots of artifacts. I think you should try to export the image again. May be that the reason it is not contiguous like you thought.

Yep! Awesome, seems to be working now


🐛 [firebase_core] firebase_analytics dependency

Bug report
firebase_core ends up depending on firebase_analytics after building a project: this is both undocumented and unexpected.
Analytics is not only included in the build, but also gets started automatically (before the main flutter app)--probably due to the Firebase ContentProvider initializer mechanism (?) in com.google.firebase.provider.FirebaseInitProvider.
The documented dependencies on https://pub.dev/packages/firebase_core as of 10/8/2020 are firebase_core_platform_interface, firebase_core_web, flutter, meta, quiver.
Since all other FlutterFire plugins depend on _core, transitively all plugins include and (!) start analytics.
Different, but related issue: why-oh-why do we have to deal with this auto-starting non-sense!? Is it so far-fetched to expect developers to make a single call to FirebaseApp.initializeApp()--when needed--instead?! I would imagine no sane developer wants/needs the google-services.json based auto-initialization. It's not helping; it's "magic code", unnecessarily adding another layer of complexity. Instead, initializing the default FirebaseApp with FirebaseOptions should work just like initialization of additional FirebaseApp instances does since v0.5.0.
Steps to reproduce
Steps to reproduce the behavior:

set up a default new project: 'flutter create'
build: 'flutter run'
check dependencies to confirm no dependency on analytics: 'cd android; ./gradlew :app:dependencies'
edit pubspec.yaml, adding a single dependency: 'firebase_core: ^0.5.0+1'
build: 'flutter run'
check dependencies again to see com.google.firebase:firebase-analytics bundled: 'cd android; ./gradlew :app:dependencies'

Click To Expand
+--- project :firebase_core
|    +--- io.flutter:flutter_embedding_debug:1.0.0-5babba6c4d25fa237bbf755ab85c9a0c50b3c6ec (*)
|    +--- com.google.firebase:firebase-core -> 17.4.1
|    |    \--- com.google.firebase:firebase-analytics:17.4.1
|    |         +--- com.google.android.gms:play-services-measurement:17.4.1
|    |         +--- com.google.android.gms:play-services-measurement-api:17.4.1
|    |         \--- com.google.android.gms:play-services-measurement-sdk:17.4.1

Expected behavior
An app without analytics, unless an explicit dependency (with substantial reason) on it exists.
Flutter doctor
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 1.22.0, on Linux, locale en_US.UTF-8)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
[✓] Android Studio (version 4.0)
[✓] IntelliJ IDEA Ultimate Edition (version 2019.3)
[✓] Connected device (1 available)

• No issues found!

Flutter dependencies
Click To Expand
Dart SDK 2.10.0
Flutter SDK 1.22.0
testapp 1.0.0+1

dependencies:
- cupertino_icons 1.0.0
- firebase_core 0.5.0+1 [firebase_core_platform_interface flutter quiver meta firebase_core_web]
- flutter 0.0.0 [characters collection meta typed_data vector_math sky_engine]

dev dependencies:
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters charcode collection matcher meta source_span stream_channel string_scanner term_glyph typed_data]

transitive dependencies:
- async 2.5.0-nullsafety.1 [collection]
- boolean_selector 2.1.0-nullsafety.1 [source_span string_scanner]
- characters 1.1.0-nullsafety.3
- charcode 1.2.0-nullsafety.1
- clock 1.1.0-nullsafety.1
- collection 1.15.0-nullsafety.3
- fake_async 1.2.0-nullsafety.1 [clock collection]
- firebase 7.3.0 [http http_parser js]
- firebase_core_platform_interface 2.0.0 [flutter meta plugin_platform_interface quiver]
- firebase_core_web 0.2.0 [firebase firebase_core_platform_interface flutter flutter_web_plugins meta js]
- flutter_web_plugins 0.0.0 [flutter characters collection meta typed_data vector_math]
- http 0.12.2 [http_parser path pedantic]
- http_parser 3.1.4 [charcode collection source_span string_scanner typed_data]
- js 0.6.2
- matcher 0.12.10-nullsafety.1 [stack_trace]
- meta 1.3.0-nullsafety.3
- path 1.8.0-nullsafety.1
- pedantic 1.9.2 [meta]
- plugin_platform_interface 1.0.3 [meta]
- quiver 2.1.3 [matcher meta]
- sky_engine 0.0.99
- source_span 1.8.0-nullsafety.2 [charcode collection path term_glyph]
- stack_trace 1.10.0-nullsafety.1 [path]
- stream_channel 2.1.0-nullsafety.1 [async]
- string_scanner 1.1.0-nullsafety.1 [charcode source_span]
- term_glyph 1.2.0-nullsafety.1
- test_api 0.2.19-nullsafety.2 [async boolean_selector collection meta path source_span stack_trace stream_channel string_scanner term_glyph matcher]
- typed_data 1.3.0-nullsafety.3 [collection]
- vector_math 2.1.0-nullsafety.3

Reproducible with flutter master 1.23.0-8.0.pre.254 and firebase_core: ^0.5.0+1.

flutter doctor -v
[√] Flutter (Channel master, 1.23.0-8.0.pre.254, on Microsoft Windows [Version 10.0.19041.508], locale en-US)
    • Flutter version 1.23.0-8.0.pre.254 at C:\Development\flutter_master
    • Framework revision 0d8696f655 (3 hours ago), 2020-10-09 01:12:02 -0400
    • Engine revision 349889833c
    • Dart version 2.11.0 (build 2.11.0-203.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\marku\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6821437\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.5)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.6.30320.27
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
    • Android Studio at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6821437
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (6 available)
    • SM G950F (mobile)           • ce12171c51cc001c03 • android-arm64  • Android 9 (API 28)
    • sdk gphone x86 arm (mobile) • emulator-5554      • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)           • windows            • windows-x64    • Microsoft Windows [Version 10.0.19041.508]
    • Web Server (web)            • web-server         • web-javascript • Flutter Tools
    • Chrome (web)                • chrome             • web-javascript • Google Chrome 85.0.4183.121
    • Edge (web)                  • edge               • web-javascript • Microsoft Edge 85.0.564.70

• No issues found!

0 matches for com.google.firebase:firebase-analytics before adding firebase_core: ^0.5.0+1 and 15 matches after adding it. Full dependencies outputs:
before.txt after.txt

This isn't the case anymore. You will see the latest androidfirebase-bom in your android dependencies as recommended practice installed with firebase_core.


Add available form options to README

I started adding the available form options to the README, so users are aware of the keys available.
@chill117 I thought maybe you would want to fill in the description fields? You wrote this code so I thought you might want to give your own description for each one?

It's better if you write a description for each, not just put a list of keys. I think you can figure out what they do if you read the source code of this module.


update application-programming-interface.md

Signed-off-by: Gaurav Shukla<EMAIL_ADDRESS>Describe your changes
I have read application-programming-interface.md this is very beautifully written. But for the people's concern I tried to make it more readable and understandable because there are many peoples who only speak Bangla. So I have tried to contribute.  @Imtiaz1234 As you have said me to create a PR to merge your file to cncf: dev-bn branch.
Related issue number or link (ex: resolves #issue-number)
Checklist before opening this PR (put x in the checkboxes)

[x] This PR does not contain plagiarism

don’t copy other people’s work unless you are quoting and contributing it to them.

[x] I have signed off on all commits

signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@withgaurav  I think you again made a mistake. Did you fork this from the main branch or the dev-bn branch? May be you forked from the main branch thus all reviewers are mentioned here.


App Gateway rule requires trailing slash.  Remove this requirement.

Steps to Reproduce

Deploy the cluster with app gateway
Deploy a sample app
Visit the sample app, but without a trailing slash.  Note that it redirects to a cluster node directly, but with the vm name.
Visit the sample app with a trailing slash.  Note that it does not redirect.

curl --head --verbose http://wlsgw4a56be-weblogic-cafe-group-reza-wlsd.eastus.cloudapp.azure.com/weblogic-cafe

Trying <IP_ADDRESS>...
TCP_NODELAY set
Connected to wlsgw4a56be-weblogic-cafe-group-reza-wlsd.eastus.cloudapp.azure.com (<IP_ADDRESS>) port 80 (#0)

HEAD /weblogic-cafe HTTP/1.1
Host: wlsgw4a56be-weblogic-cafe-group-reza-wlsd.eastus.cloudapp.azure.com
User-Agent: curl/7.58.0
Accept: /

< HTTP/1.1 302 Moved Temporarily
HTTP/1.1 302 Moved Temporarily
< Date: Wed, 06 May 2020 19:13:53 GMT
Date: Wed, 06 May 2020 19:13:53 GMT
< Content-Type: text/html
Content-Type: text/html
< Connection: keep-alive
Connection: keep-alive
< Set-Cookie: ApplicationGatewayAffinity=21554b2eb568dba34d030034297eb452; Path=/
Set-Cookie: ApplicationGatewayAffinity=21554b2eb568dba34d030034297eb452; Path=/
< Location: http://mspVM2:8001/weblogic-cafe/
Location: http://mspVM2:8001/weblogic-cafe/
<

Connection #0 to host wlsgw4a56be-weblogic-cafe-group-reza-wlsd.eastus.cloudapp.azure.com left intact

~/workareas/weblogic-on-azure$ curl --head --verbose http://wlsgw4a56be-weblogic-cafe-group-reza-wlsd.eastus.cloudapp.azure.com/weblogic-cafe/

Trying <IP_ADDRESS>...
TCP_NODELAY set
Connected to wlsgw4a56be-weblogic-cafe-group-reza-wlsd.eastus.cloudapp.azure.com (<IP_ADDRESS>) port 80 (#0)

HEAD /weblogic-cafe/ HTTP/1.1
Host: wlsgw4a56be-weblogic-cafe-group-reza-wlsd.eastus.cloudapp.azure.com
User-Agent: curl/7.58.0
Accept: /

< HTTP/1.1 200 OK
HTTP/1.1 200 OK
< Date: Wed, 06 May 2020 19:14:39 GMT
Date: Wed, 06 May 2020 19:14:39 GMT
< Content-Type: text/html; charset=UTF-8
Content-Type: text/html; charset=UTF-8
< Connection: keep-alive
Connection: keep-alive
< Set-Cookie: ApplicationGatewayAffinity=87a187c991cdf614b82980abcbd81713; Path=/
Set-Cookie: ApplicationGatewayAffinity=87a187c991cdf614b82980abcbd81713; Path=/
< Set-Cookie: JSESSIONID=sVnraU9YuSKKElBzNbMk4-bGYh6AxUb0sLo27ZF7O-azJx96ZYcB!-27357165; path=/; HttpOnly
Set-Cookie: JSESSIONID=sVnraU9YuSKKElBzNbMk4-bGYh6AxUb0sLo27ZF7O-azJx96ZYcB!-27357165; path=/; HttpOnly
<

Connection #0 to host wlsgw4a56be-weblogic-cafe-group-reza-wlsd.eastus.cloudapp.azure.com left intact

In my particular situation, I have learned that the solution is best effected in the WebLogic Server configuration.

Visit the WLS Console
Click "Lock & Edit"
Click "Clusters"
Click "cluster1"
Click "HTTP"
Set the "Frontend Host", "Frontend HTTP Port" and "Frontend HTTPS Port" to be the AppGW Public IP, 80, and 443, respectively.
Release the configuration.
Restart the worker nodes in the cluster.

The issue has been fixed and commited to the master branch.
I have tested it for both the scenarios:
enableAppGateway=true & enableAppGateway=false
The changes made can be seen in the below link
:
https://github.com/wls-eng/arm-oraclelinux-wls-cluster/commit/2976907dfec137ba0a77d2d4f35455e895fba969


Event needed between manifest parsing and the start of streaming

@chrisfillmore writes in https://github.com/google/shaka-player/issues/1029#issuecomment-332386309:

We have a scenario where we need to know the bandwidth levels from the manifest before we start playback, so that we can set the max bandwidth in order to restrict certain variants.

It sounds like we need a hook or event to examine content metadata between manifest parsing and the start of streaming.
The only tricky bit is to make sure that the event is dispatched in a synchronous way at the right point.  I think this should be after filtering based on MSE & EME, and after Track info is available, but before an initial track selection is made by AbrManager.  That will allow restrictions to be set before any segment requests are made.

Ooh, very nice. We would need to know bandwidth and codec information. Thanks Joey.

That should all be available from shakaExtern.Track.  Let us know if there's anything missing!

New method cherry-picked for v2.2.5.


option to not use MustExecContext in dao

mustexec causes panic in key violations ... when normally you would want to catch those errors yourself.
an option to not use mustexec by default in dao's would be stellar.

@jcolson I will adjust, to check the error. I appreciate the comments as I need best practices advice for dao and http api handlers.

@jcolson check out v0.9.12 release - I swapped out MustExec


Allow language extensions to expose a persistent interactive console (REPL)

While it is awesome that we have the Debug Console for an interactive console experience while debugging, it would be ideal if VS Code also supported a persistent REPL (interactive console) which could also be used at any time.  Users of languages such as PowerShell, F#, Python, Ruby, and many others would benefit from this.
At least in the case of PowerShell, all that would really be needed is an event that can be registered when the user enters a command and then some API for writing the output.  The PowerShell, F#, and Elm extensions already simulate this by allowing the user to select some text, run a command to execute it, and then have the output written to an output channel.
Users of the PowerShell extension have requested feature this here: https://github.com/PowerShell/vscode-powershell/issues/10
cc @Krzysztof-Cieslak

General :+1: to feature. Would be really cool to get such feature (especially when Debugging Console practically implements everything we would need)
For sure it would be useful for many languages (nowadays even C# has REPL ;) ). As David said, in F# and Elm we just allows user to send line / selection / file to REPL and we print output to Output Channel - that's how it looks more or less:

While for F# it's my decision to have such style REPL (we've implemented exactly same functionality [read-only REPL window] in Atom even though we could get more traditional style) other languages and their communities prefers to use REPL by just typing code into it and plugins supporting those languages would really benefit from adding this.

cc: @mat-mcloughlin for Elixir plugin.

+1 on this feature

+1 on this feature. Also, I would like to see an option to see the REPL window on the bottom.

I would like to see an option to see the REPL window on the bottom

agreed and this is on our backlog.

+1 want to run some npm, or nuget or  stuff directly from vs code.

Since 1.0 is on the way, I'd love to see this get added once you guys are prepared to start adding new features again.  Users of the PowerShell extension tell me regularly that they would switch away from the PowerShell ISE completely over to VS Code if there was a persistent REPL experience.
Since Andre self-assigned this issue and removed the help wanted tag, I'll take that as a hint that work might be happening in this area soon :)

@daviwil @Krzysztof-Cieslak @mat-mcloughlin
In VS Code a debug adapter is only launched when a debug session is started. And the debug adapter is stopped when the session ends. At any point in time only a single debug adapter is connected to the debug console and can use it as a REPL.

How should this work if the REPL could be used at any time?
Is the debug adapter running all the time? So a 'terminate' does not kill the adapter but only kills the session?
When is the debug adapter started? 'Launch' is probably too late because the REPL should work at any time.
Is this a capability of a debug adapter? e.g. VS Code would not kill the adapter at the end of the session but reuse it?
What happens if I'm using more than one debug adapter with this behaviour? Will only a new session of a different adapter terminate the previous adapter?

Please provide input/insights/ideas in how we could improve the current architecture to support your use cases. Thanks!

That's an interesting idea, actually.  If the debug adapter contribution could opt in to being launched when the extension gets activated and then persist across multiple debug sessions, that would work for my needs.  Here are some general thoughts:

If the debug console is now active at all times even if the debugger isn't running, could you make the debug console control also available in the editing workspace?  I think it'd be limiting if the user could only see the console if they switch to the debug workspace.

Do you think it might be time to consider allowing multiple debug adapters to be connected to VS Code at the same time?  What if I'm a web application developer and I want to attach to both a client (JavaScript/Node) and server application (C#) and debug the requests as they travel between the two processes?  To simplify the UI you could just allow the user to select the "active" process (at any time) so that only the details of that single process (breakpoints, variables, call stack, debug console) are shown in the UI.  This would allow a persistent PowerShell debug adapter to be connected even if the user is also debugging some other type of application.

I've got a few more requirements to make this experience smooth for PowerShell but I'll send those separately in an e-mail because they require discussion that would just be extra noise on this issue.

@daviwil multiple debug sessions are already possible: just open another VS Code window on a sub- or super folder. I'm using this setup all the time to debug my (client) tests and the debug adapter (server) at the same time. We are planning to lift this limitation (a single 'if' statement) soon. Then it will be possible to open multiple windows on the same (project) folder.

Cool!  If you can open the same folder in two separate windows then that could simplify the multiple debug adapter situation.

+1 on this feature  (REPL, interactive console)

I wonder if this could be somehow connected with https://github.com/Microsoft/vscode/issues/143 - with terminal support we basically get "output" window where we can type stuff in... which is basically what we need for REPL.
On the other hand we can just start REPL from terminal and additional extension point for this is not required any more.

The other possibility in 1.2.0 is to use the new vscode.startDebug API so that you can allow the user to use the Debug Console.  It'd require your debug adapter to be able to run without a specific file, basically just dropping them into a prompt.
However, I'd much prefer to use the Terminal UI if I could provide the output for it.  I'm not really a fan of having a separate input box :)

So is the idea here to basically be able to launch a powershell instance from an extension (or python, ruby, etc.)? #143 pretty much covers this entirely doesn't it?
@daviwil what do you mean exactly by "if I could provide the output for it"?

I think the powershell (or python, ruby, etc) instance runs in debug mode and interacts with the VS Code debugger UI. This applies to the REPL as well, so it should be possible to use the debugger UI to inspect the objects returned from the REPL eval.

At least in the case of the PowerShell extension, I am hosting a PowerShell session in my language server (not as a separate instance of powershell.exe).  This allows the user to write and evaluate PowerShell code and then have their session be affected by what's executed (new commands show up in IntelliSense results, etc).
In the case of the terminal control, it means that VS Code wouldn't be performing console emulation for powershell.exe. Instead you'd be sending my extension the text that the user enters and then allowing me to write output back to the terminal.  If you check out the PowerShell ISE editor that ships with Windows (powershell_ise.exe), you'll see what I'm trying to achieve.
Andre's right, currently we expose a PowerShell console via the VS Code debugger and that works pretty well.  The dream setup would be using the Terminal UI with my debug adapter backend since that would provide the exact experience PowerShell users expect.

I'm investigating this for the julia extension.
I generally see two possible implementations right now:

something that uses the terminal support from #143 and #6458, and has no debugger integration.
something fancier that is integrated with the debugger.

For 1), all I would need is some API that I can use from my extension that opens up a new terminal window in the #6458 UI. The API should allow me to just pass in a command line that should start for that terminal (i.e. that command line would come from my extension call, not from some global terminal configuration). Ideally the API would also allow me to somehow "track" that specific terminal, i.e. it would be great if my extension would get events when the terminal is closed/hidden/terminates etc. @Tyriar is some of that maybe even already possible in insider builds? My extension would then add commands like "julia: open REPL", "julia: send current selection to REPL", "julia: send current file content to REPL".
Sending individual code to this julia instance would actually not work via just pasting that code into the REPL. instead my extension would communicate with that julia instance via a socket. This would enable some cool things, for example one could execute a specific line of code in a specific module in the julia instance, something that would not be possible if the "send to REPL" command was a stock VS code command that just sent the code via the STDIN/STDOUT to the julia REPL.
I'll have to think a bit more about 2). But my gut feeling is that something along the lines of @weinand would actually be the right design. I.e. the julia REPL is actually started via a debug adapter, and that this debug session is just active for the whole duration of the julia REPL running. The UI of this julia instance would ideally still be based on the terminal UI (the julia REPL is pretty cool and I would hate to lose its features).
I don't know whether there is enough interest in VS Code in the julia community to ever get something along the lines of 2) off the ground, but something like 1) seems pretty straightforward, so I would actually prefer if we could somehow enable that scenario first and then worry about 2) later.

Just small update. We've decided to use Terminal API for F# REPL.  Starting REPL spawns new terminal and starts repl in it. Sending line / selection etc just sends text to terminal.

Same as @Krzysztof-Cieslak, the PowerShell extension is moving to hosting its REPL using the new Terminal APIs.

Can this feature request be accomplished with the terminal API as it stands in v1.6 with the PID of the shell exposed?

For my purposes, definitely.  Not sure about other languages/platforms.

How are you guys starting the REPL for your specific language in the new terminal? I guess I would have thought that the createTerminal function would take the path of some exe that should be started in the terminal, so that I could have made sure e.g. julia runs in the terminal. How are those folks that use this for REPLs actually starting their specific language REPL?

@davidanthoff that's available in Insiders and stable soon: https://github.com/Microsoft/vscode/blob/9ad845dbec1c3e84d85ac0c49904e12325534099/src/vs/vscode.d.ts#L3523

Ah, great, I only looked at the public documentation. I'll check that out soonish, but I think that is probably enough for my case.

@weinand did you have any other plans/suggestions on this issue or can we close it off?

I wonder if there would be possibility of adding sendText overload which would not print sent text in terminal window. It would allow us to hide some "infrastructure" messages we need to send to F# Interactive.
Also someone complained to me about lack of "clear terminal" action (previously we used output channel which could be cleared), it could just remove all content from terminal leaving only last line (or something like that) ... but I guess that's discussion for separate issue.

A clear command was just added as well #6603 while will remove all content except for the prompt/current line and push it to the top. It's not possible to not show the text as the text it sent as input to the pty process and the pty process sends the output to be displayed, so it's not up to vscode what to do with the output.

Thanks to the Integrated Terminal feature that got added last year, I think this issue can now be closed.  Everyone else here agree?

:+1:


HamburgerGridWidth is not the same as the splitview pane

as above, in Wide Visual State, the HamburgerGridWidth is not the same as the pane in Hamburger Control

I can confirm that the Hamburger template is pixel-perfect. There's something in your app making it change. Not sure where I would guess. Try the template's custom.xaml and change PageHeader.Background to Red. See if it is still off. If so, hmm. We'll wait until we see it that way.

@JerryNixon if you just change HamburgerBackground to a red brush, others remain the origin from hamburger template, the problem still appear. Btw, I'm using a 125% system vision ratio, wondering if that affects.

I've checked that in 100% ratio, the problem remains.
and anyway thanks for helping


[#126965751] Install ruby gem json in cf-cli container

#126965751 Test users not removed from CC DB.
What
After merging #62, our pipeline fail when executing a ruby script which required json.
The problem is that Ubuntu contains the json gem by default, but Alpine does not. Adding the json by default.
We avoid running bundle install in the pipeline to avoid increase the time to run. We normally try to keep the scripts simple and without dependencies, but json is a really basic library.
How to test
Travis shall pass.
You can test locally with rake build:cf-cli spec:cf-cli.
Who?
Anyone but @keymon

json is a default gem that ships with ruby. Why do we even need to install it? Does alpine remove the default gems?

Answering my own question:
Assuming this is the correct APKBUILD it takes json, irb, rake etc out of the main package and puts them into subpackages.

Travis looks good, running locally it builds and tests pass, and tasks in the pipeline which use it are running okay. Merging.


Xcode AppDelegate.m crash when interact with CardField component in reload state

Describe the bug
When i interact with the CardField component (click in the fields, filling the card number input) and when I run the command to reload the application (⌘ + r) the AppDelegate.m crashes. It only happens when i interact with the component and after, execute the reload command. If i press the R key in the RN server to reload the app, or open the debug mode and click Reload, the app doesn't crash, only happen with ⌘ + r command after interacting with the component.
I already try to run the command ⌘ + r whitout interact with the component and nothing happens, appears to be the component.
To Reproduce

Open the app with a view that have a CardField component rendered.
Interact with the CardField component, for example, try to fill the card number input (insert 4242 4242).
Executes the ⌘ + r command to do a fast reload of the application.

PD: if the Xcode doesn't crash the first time, try again, something the bug happens at the 2nd or 3rd time. (yes, is pretty weir.)
Expected behavior
React Native should be able to completes the reload of the application without the AppDelegate.m crashes.
Screenshots

Smartphone (please complete the following information):

Device: Xcode Iphone 11 Simulator
OS: IOS 14.4
RN version: 0.63.4

I'm not able to reproduce this. I'm not sure this is related to the library. How would this affect your production app?

Hi, this not affect the production build but when you develops your integration with the library and if you use the ⌘ + r command to reload the app, the apps crashes. I attach a video to expand the context of how the crash works.
https://user-images.githubusercontent.com/8359234/120513153-99075180-c391-11eb-9790-6e2521a31919.mp4

This also happens to me with the introduction of CardField component into the app, this was not happening before that event.
Not sure what will help you to debug this problem and find the solution.

I may have some more information on this problem.
So after building on a real device in development, I still have this issue (fortunately, it does not happen not in dev)
I have a modal, which then has the CardField. When dismissing this modal, the app crashes.
The crash is logged as:
File STPValidatedTextField.swift
Line 88, func updateColor
Thread 1: EXC_BAD_ACCESS (code=1, address=0x699422490)
This happens every time I open and then close the modal. This did not happen before adding the CardField component, so I'm pretty positive it's the reason for the crash.
Thanks!

this is already fixed in 0.2.0v


why   use kafka insert data to druid  but show  ingest/handoff/failed

news :
2015-08-25T10:46:50,497 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:46:50.497Z","service":"realtime","host":"localhost:8085","metric":"ingest/persists/backPressure","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:46:50,498 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:46:50.497Z","service":"realtime","host":"localhost:8085","metric":"ingest/persists/failed","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:46:50,498 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:46:50.498Z","service":"realtime","host":"localhost:8085","metric":"ingest/handoff/failed","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:47:50,497 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:47:50.497Z","service":"realtime","host":"localhost:8085","metric":"ingest/events/thrownAway","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:47:50,498 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:47:50.498Z","service":"realtime","host":"localhost:8085","metric":"ingest/events/unparseable","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:47:50,498 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:47:50.498Z","service":"realtime","host":"localhost:8085","metric":"ingest/events/processed","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:47:50,498 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:47:50.498Z","service":"realtime","host":"localhost:8085","metric":"ingest/rows/output","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:47:50,498 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:47:50.498Z","service":"realtime","host":"localhost:8085","metric":"ingest/persists/count","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:47:50,498 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:47:50.498Z","service":"realtime","host":"localhost:8085","metric":"ingest/persists/time","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:47:50,498 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:47:50.498Z","service":"realtime","host":"localhost:8085","metric":"ingest/persists/backPressure","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:47:50,498 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:47:50.498Z","service":"realtime","host":"localhost:8085","metric":"ingest/persists/failed","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:47:50,498 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:47:50.498Z","service":"realtime","host":"localhost:8085","metric":"ingest/handoff/failed","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:48:50,499 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:48:50.498Z","service":"realtime","host":"localhost:8085","metric":"ingest/events/thrownAway","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:48:50,499 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:48:50.499Z","service":"realtime","host":"localhost:8085","metric":"ingest/events/unparseable","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:48:50,499 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:48:50.499Z","service":"realtime","host":"localhost:8085","metric":"ingest/events/processed","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:48:50,500 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:48:50.499Z","service":"realtime","host":"localhost:8085","metric":"ingest/rows/output","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:48:50,500 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:48:50.500Z","service":"realtime","host":"localhost:8085","metric":"ingest/persists/count","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:48:50,500 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:48:50.500Z","service":"realtime","host":"localhost:8085","metric":"ingest/persists/time","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:48:50,500 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:48:50.500Z","service":"realtime","host":"localhost:8085","metric":"ingest/persists/backPressure","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:48:50,500 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:48:50.500Z","service":"realtime","host":"localhost:8085","metric":"ingest/persists/failed","value":0,"dataSource":"wikipedia"}]
2015-08-25T10:48:50,500 INFO [MonitorScheduler-0] com.metamx.emitter.core.LoggingEmitter - Event [{"feed":"metrics","timestamp":"2015-08-25T10:48:50.500Z","service":"realtime","host":"localhost:8085","metric":"ingest/handoff/failed","value":0,"dataSource":"wikipedia"}]

The "value":0 here means that nothing actually failed (it's a count of failures):
{"feed":"metrics","timestamp":"2015-08-25T10:46:50.498Z","service":"realtime","host":"localhost:8085","metric":"ingest/handoff/failed","value":0,"dataSource":"wikipedia"}


Feature request: scroll restoration

This has been requested before: #132, (partially) #166, #189 - but the suggested code is an incomplete solution:
import { useEffect } from "react";
import { useLocation } from "wouter";

export default function ScrollToTop() {
  const [ pathname ] = useLocation();

  useEffect(() => {
    window.scrollTo(0, 0);
  }, [pathname]);

  return null;
}

This will scroll to the top of the page on any navigation, including when the user presses the back / forward history buttons, and when the user navigates in ways that only affect part of the page (e.g. changing a tab component which records the current tab in the URL). It will also have a brief flicker due to using useEffect rather than useLayoutEffect. A more complete solution would only reset the scroll position when navigating to new pages, restoring previous positions when navigating forward / back, and allowing an override on links to disable scrolling to the top of the page.
React Router provides this as a separate component, but with some necessary integration with the core. That seems like a reasonable approach to follow here too, since it fits the philosophy of not bloating the core library (saving space for people who don't need the feature).
https://reactrouter.com/en/main/components/scroll-restoration
Their (MIT licensed) code shows that there are quite a few considerations here, so it seems beneficial to offer this in the library rather than having each user recreate the functionality for themselves. This will also make it possible to add integrations such as allowing specific links to bypass the scrolling behaviour.
Generally, their approach:

takes over the native scroll behaviour (i.e. when the whole page actually switches) by setting history.scrollRestoration (docs)
listens for the pagehide event to capture current scroll position before navigating to another page (also captures refreshing) (docs)
stores scroll locations in session storage (likely to avoid taking over the state parameter used in the history API)
provides a custom implementation of scrolling to anchor elements (likely due to disabling the browser's native handling; this might not be required, but worth finding out what the disadvantages are of allowing native scroll handling)
gives links / navigate the ability to bypass auto-scrolling by setting a flag
updates the scroll position inside a useLayoutEffect call to avoid flickering that useEffect would cause.

I think a minimal approach could:

listen for pagehide events to capture scroll position
record this position in the history API for the current page (by calling history.replaceState) - this can be put into the state object since currently it's always just set to null, which avoids the need to use session storage
set up a useLayoutEffect with useLocation()[0] as a dep. Internally this can check history.state to see if it needs to scroll

it would be better if this could depend on the history.state object directly - would it be possible to expose this from useLocation somehow?

To clarify: I'm happy to work on a PR for this, but I want to make sure there's agreement on an approach first.

const [ pathname ] = useLocation();

  useEffect(() => {
    window.scrollTo(0, 0);
  }, [pathname]);

is not a best option, ideally we don't restore scroll on replace event
I believe popstate should be used for scroll restoration

the solution should respect history back and replace state, where we want to keep the scroll

Do you know how that can be achieved?

This missing feature is a game changer. I'm really eager for a solution. Even if it comes as a third party package. After all, just like the naive sample hook snippet at the top of the issue, it can all come from something/somewhere else.
In my app that I'm working on I wrote my own horrible version. Total hack. It essentially stores the previous URLs loaded, and if the  0th and the 2nd in the array of URLs is equal, I assume they user clicked the back button :) And in all other case, I trigger the window.scrollTo(0, 0).
I don't know if a third-party solution would work with wouter unless wouter exposes more.

I don't believe this can be done purely from a third-party plugin; it needs some level of integration with the core route handling.
You can see my original post for a full walkthrough of what would be needed for this feature, which draws from the way it is implemented by react-router. I was hoping to hear back from the maintainers about whether this would be a feature they'd consider, especially since it's likely to increase the library size at least a bit.

I don't believe this can be done purely from a third-party plugin; it needs some level of integration with the core route handling.

I believe that.
Especially once you get into the finer points, as you laid out.
Apr 2023 is a pretty long time ago. :(
You mentioned,

To clarify: I'm happy to work on a PR for this, but I want to make sure there's agreement on an approach first.

Perhaps it's best to come with code then. If the maintainer(s) isn't available, I'd be willing at least to help out. I can test and and I can review. Hopefully that will make the final maintainer review easier and faster. Granted, you do make the point that " it's likely to increase the library size at least a bit."

@molefrog What's your take on this feature? Do you consider it to be in scope? Are you open to community contributions?

Hey everyone, this def sounds like an essential feature to have. I'm freezing the v2 branch as we've just rolled out the new version. I reworked the internals a bit so probably it might help. What are the extensions that the core needs?

@molefrog I could imagine an implementation like this in user-space:
myBrowserLocationRouter.addEventListener('beforenavigate', (e) => {
  const historyID = e.detail.oldPage?.state;
  if (historyID) {
    if (e.detail.navigateOptions.replace) {
      sessionStorage.deleteItem(`history-${historyID}`);
      return;
    }
    const pageState = sessionStorage.getItem(`history-${historyID}`);
    sessionStorage.setItem(`history-${historyID}`, {
      ...pageState,
      scrollX: window.scrollX,
      scrollY: window.scrollY,
      backScroll: !e.detail.navigateOptions.noScroll,
    });
  }
});

myBrowserLocationRouter.addEventListener('afternavigate', (e) => {
  const scroll = !e.detail.navigateOptions.noScroll;

  if (!e.detail.newPage.state) {
    const historyID = crypto.randomUUID();
    history.replaceState(historyID);
    if (scroll) {
      window.scrollTo(0, 0);
    }
    sessionStorage.setItem(`history-${historyID}`, {
      scrollX: window.scrollX,
      scrollY: window.scrollY,
      forwardScroll: scroll,
    });
  } else {
    const historyID = e.detail.newPage.state;
    const pageState = sessionStorage.getItem(`history-${historyID}`);
    if (!pageState) {
      return;
    }
    if (e.detail.type === 'back' && !pageState.backScroll) {
      return;
    }
    if (e.detail.type === 'forward' && !pageState.forwardScroll) {
      return;
    }
    window.scrollTo(pageState.scrollX, pageState.scrollY);
  }
});

Then in some component:
const [location, setLocation] = useLocation();
return (

    <button onClick={() => setLocation('/p1')}>Page 1</button>
    <button onClick={() => setLocation('/p2')}>Page 2</button>

      <button onClick={() => setLocation('/p1/t1', { noScroll: true })}>Tab 1</button>
      <button onClick={() => setLocation('/p1/t2', { noScroll: true })}>Tab 2</button>

);

With Link and Redirect also having pass-through arguments to set this second parameter of setLocation. Right now that exists for things like replace, but ideally it would be possible to set arbitrary properties, or at a minimum, possible to set this new noScroll property.

So other than being able to pass this noScroll property through the helper objects, there's not much in the main API that needs changing. The bulk of the changes are in the browser router:
beforenavigate needs to be fired whenever the location changes (using the same logic that triggers the hook to update now), as well as when the user navigates away (via the pagehide event), and ideally is not fired when the page first loads. It needs to be fired before the page re-renders (i.e. before any hooks see the new value), and needs to be given:

oldPage: the page we are navigating from. Ideally contains url and state from the history API
navigateOptions: if the navigation comes from setLocation etc., this should be the second argument which was passed. If it comes from browser events, this should be {} or null or similar.

afternavigate needs to be fired after the page has re-rendered (probably via something like Promise.resolve().then(afternavigate)), and needs to be fired when the page is first loaded (and ideally not fired when the page is closed). It needs to be given:

newPage: the new page we have navigated to. Ideally contains url and state from the history API
navigateOptions: same as beforenavigate
type: "back" / "forward" / "navigate" depending on the trigger for the current navigation

Note also that afternavigate might need to call replaceState, as in this example, so there needs to be some handling to avoid infinite loops.
(for simplicity I think it would be nice if both events got the same set of data)
I think adding these callbacks to the browser router represents the bulk of the core features needed to make scroll restoration possible.

Link and Redirect already proxy all their props to the navigate method. So anything that is passed to the <Link foo="bar" /> will appear as an option in navigate.
Regarding the API, I'm pretty sure we can fit everything in a custom hook. This will allow some hacks to ensure that useLayoutEffect is called only once per navigation but I'm confident we can make this work.
import { useLocationWithScrollRestoration } from "wouter/scroll-restoration"

<Router hook={useLocationWithScrollRestoration}>
  <Link to="/" preserveScroll={false} />
</Router>

// implementation ideas
import { useBrowserLocation } from "wouter/use-browser-location";

export const useLocationWithScrollRestoration = (router) => {
   // all location hooks receive router object when called
   // we can use it as a singleton and store app-wide data
   // the problem is that new routers are created when they are inherited from parent
   // but I can extend the core to support something like `router.store.foo = "bar"`

  const [path, navigate] = useBrowserLocation(router)
  useLayoutEffectOnce(() => {
     // after navigate
  })

  const navigateWithBefore = () => {
     // before navigate

    navigate()
  }

  return [path, navigateWithBefore]
}

This is for V3.

I assume the useLayoutEffectOnce is intended to have path in its deps?
I think the potential gotcha is that (in the form I illustrated above), both events need to fire for all kinds of navigation (i.e. when using the browser back/forward buttons as well as when navigating programmatically), but in your code the "before" event will only fire when navigate is called.
I wonder when the teardown function of useLayoutEffect runs; I'll experiment to see if it works, but something like this might actually work: (or potentially this could run the teardown too "late"; after the page has already been updated with some new content and - critically - the page height has updated)
// assume beforeNavigate & afterNavigate behave as I illustrated in my earlier comment

export const useLocationWithScrollRestoration = (router) => {
  const [path, navigate] = useBrowserLocation(router)

  useLayoutEffectOnce(() => {
    if (router.state.currentNavigateOptions) {
      afterNavigate({
        newPage: { path, state: history.state },
        navigateOptions: router.state.currentNavigateOptions,
        type: "navigate",
      })
      router.state.currentNavigateOptions = null
    } else {
      afterNavigate({
        newPage: { path, state: history.state },
        navigateOptions: {},
        type: "??", // TODO: detect forward or back (necessary for correct handling of noScroll)
        // this might be possible if we carefully pick history.state values to be incrementing
      })
    }
    router.state.lastPageState = history.state

    return () => {
      // Note that here, router.state.currentNavigateOptions is from the call that
      // triggered the current teardown, NOT the same as its value above.
      // Also, lastPageState has not been updated yet, so it refers to the previous
      // page's history.state
      beforeNavigate({
        oldPage: { path, state: router.state.lastPageState },
        navigateOptions: router.state.currentNavigateOptions ?? {},
      })
    }
  }, [path])

  useEffect(() => {
    const handle = () => {
      beforeNavigate({
        oldPage: { path, state: router.state.lastPageState },
        navigateOptions: {},
      })
    }
    window.addEventListener('pagehide', handle)
    return () => window.removeEventListener('pagehide', handle)
  }, [path])

  const wrappedNavigate = (...args) => {
    // if this capturing could happen internally in the standard `navigate`,
    // we could make this whole hook independent of `useNavigate`, so users
    // could just include it once (saving the need to make useLayoutEffectOnce)

    router.state.currentNavigateOptions = args[1] ?? {}
    navigate(...args)
  }

  return [path, navigate]
}

Note this adds some extra handling to track the state from the history API. This is needed for 2 reasons:

to cope with situations where (e.g.) the user navigates from page 1 to page 2, then back to page 1 (via a link, not history), then navigates back through the history: page 1 has 2 scroll positions depending on which history entry we are at, so the path alone isn't sufficient
if the user leaves the page (e.g. following an external link) then returns via the history, we can't rely on local variables - all storage needs to be in the history stack and/or session storage

so it turns out to be absurdly simple to get something which 99% works:
import { useLayoutEffect } from 'react';
import { useLocation } from 'wouter';
import { useBrowserLocation } from 'wouter/use-browser-location';

const hypotheticalRouterGlobalState = {};

export const interceptingHook = (router) => {
  const [path, navigate] = useBrowserLocation(router);

  const wrappedNavigate = (...args) => {
    hypotheticalRouterGlobalState.currentNavigateOptions = args[1] ?? {};
    navigate(...args);

    // ideally we'd probably clear currentNavigateOptions here (instead of in updateScroll)
    // Perhaps something like:
    // setTimeout(() => { hypotheticalRouterGlobalState.currentNavigateOptions = null; }, 0);
  };

  return [path, wrappedNavigate];
};

const updateScroll = () => {
  const options = hypotheticalRouterGlobalState.currentNavigateOptions;
  hypotheticalRouterGlobalState.currentNavigateOptions = null;
  if (!options || options.noScroll) {
    return;
  }
  const hash = document.location.hash?.substring(1);
  const target = hash ? document.getElementById(hash) : null;
  if (target) {
    target.scrollIntoView({ behavior: 'instant', block: 'start', inline: 'nearest' });
  } else {
    window.scrollTo(0, 0);
  }
};

export const ScrollRestorer = () => {
  const [path] = useLocation();
  useLayoutEffect(updateScroll, [path]);

  return null;
};

usage:
<Router hook={interceptingHook}>
  <ScrollRestorer />
  ...
</Router>

The browser's own scroll restoration is perfectly able to cope with the history navigation, just as long as we can stay out of its way and only force the scroll position when navigating ourselves (hence the hypotheticalRouterGlobalState.currentNavigateOptions tracking)
The core library could be updated in some small ways to make this nicer:

Capturing the currentNavigationOptions in the built-in useBrowserLocation hook (i.e. in the core library) would save the need for a custom hook entirely. Then <ScrollRestorer /> would be the only thing users need to add to enable this feature.
Relatedly, putting hypotheticalRouterGlobalState into the router somehow, as you hinted at above, would make for slightly nicer encapsulation.

But also this approach is not perfect. Specifically: hash/anchor handling in Links fails:
If we have a <Link href="#my-anchor"> (linking to an anchor in the current page), the currentNavigateOptions will be set, but updateScroll will not be called, because the path from useLocation doesn't change. We also don't get a hashchange event fired (because we changed it programmatically)
If we could get the current hash from the router, then it could be added as one of the deps in the layout effect, which would fix this. As far as I can tell this isn't currently available by any means, so would need to be added to the core library (either as part of useLocation, or in a new hook).

Regarding the state, I haven't come up with anything more elegant than this. The plus is that it doesn't require us to modify the library:
const store = new WeakMap()

/*
  Returns an object that can keep state associated with the current location hook
*/
const useLocationState = () => {
  const hook = useRouter().hook;

  if (!store.has(hook)) {
    store.set(hook, {})
  }

  return store.get(hook)
}

I don't think that storing navigation parameters should be part of the library though. This sounds like a narrow use case. We could provide a way to hook into internal events via router.events for example:
export const ScrollRestorer = () => {
  const state = useLocationState();
  const router = useRouter();

  useLayoutEffect(() => {
    const ubsub = router.events.on("beforeNav", (to, options) => {
      state.currentNavigateOptions = { to, options }
    });

    return () => unsub();
  }, [router, state])

  useLayoutEffect(() => {
    const options = state.currentNavigateOptions;

    // ... restore the scroll
  }, [path]);

  return null;
};

The obvious benefit is that this is location hook independent.
This is just a draft idea, I will keep exploring if we could easily integrate it without sacrificing the size.