Add search box 🔍

Add a search widget.

Restrict search area to WA. Use our custom view of the ArcGIS World Geocoder. If that doesn't work for some reason, we can use the search's constructor to specify extent, country code, etc.

Note that the WA extent does include a bit of Oregon, since the state boundaries are not a perfect rectangle. (Investigate: Is there a way to restrict the geocoder to specific states?)

Need to determine what the users will need to search for. Some possibilities are listed below.

Built in

[x] Address
[x] Points of interest

Custom

[ ] Intersections
[ ] Exit ramps
[ ] County boundaries
[ ] City Boundaries
[ ] Other items may be possible, too.

Closing for now since the unchecked items were not requested. We can create new issue(s) if customers want these additional search features.


Should project.json be renamed?

The file name project.json is very generic, with no indication of the actual technology stack
it applies to. It shares this generic-naming problem with NPM's package.json file, and it's also easy to confuse one with the other. In contrast, bower.json has a specific name that immediately identifies the applicable tool and provides an obvious search-engine keyword to find relevant documentation.
Since the project.json file now applies to more than just ASP.NET 5, and is becoming the recommended way to describe .NET projects going forward, I would suggest renaming it to something more relevant, perhaps dnx.json or dnxproject.json.
I realize this would be a breaking change that would affect many tools besides Visual Studio. Looking back at the fallout of the K rename, I think it's fair to say that this rename would be much harder (or even impossible) to pull off after the final VS 2015 release, so I thought I should ask for feedback sooner rather than later.

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


How many ticks per second?

Hello Andy! Sorry if this question is documented somewhere, but how many ticks are there per second? By ticks I mean this function:
noa.on("tick", function(dt) { blah blah });

Thanks!
Edit: I'm guessing dt is delta time, however, on my 144 hertz (fps) monitor, dt is 33 and on my 60 hertz it's also 33. Is the rate that tick is called constant? Or does dt not stand for delta time? Thanks!

Hi, thanks for a very good question - this is the kind of thing I need to document 😁
So there are two different recurring events in the engine, tick and render. Ticks are for game logic - processing inputs, doing physics, checking for collisions, etc. And renders are when the game redraws the screen. The assumption is that game logic may be too heavy to run at 60fps, so that's why the two update rates are decoupled.
Anyway the tick rate is configurable and defaults to 33 (milliseconds), meaning that physics and whatnot happens 30 times/second. The dt parameter to that event is the delta time between events, but it's always the same number since tick events use fixed timesteps.
Meanwhile render events are a separate interval, which is usually 60fps. Note that if you need to run display logic noa also emits beforeRender and afterRender events. They both have a dt parameter, but in this case the number will vary since it's the actual time since the last render (in milliseconds).
Finally, regarding 144hz monitors: noa's render events basically originate from requestAnimationFrame. And the docs claim that most browsers will fire RAF according to the display rate, but for me personally it seems to always fire at 60fps, even when I'm on a 120hz monitor. But I haven't investigated this deeply, there could be something I'm missing.

Thanks for the answer! Have a good night!


Added OSX check

I don't know if this can be useful for you

@EmanueleCoppola Thanks for your contribution. Travis is giving an error because it no longer supports HHVM.
Merging!


add support for file-5.25 zip mimetype in macOS Sierra

Changes to the core
macOS Sierra's version of /usr/bin/file reports a different mimetype string for zip, bzip2 and gzip files:
$ /usr/bin/file -Izb -- /usr/local/Library/Taps/caskroom/homebrew-cask/spec/support/binaries/AppWithBinary.zip
application/zip; charset=binary
$ /usr/bin/file -Izb -- /usr/local/Library/Taps/caskroom/homebrew-cask/test/support/binaries/bzipped_asset.bz2
application/x-bzip2; charset=binary
$ /usr/bin/file -Izb -- /usr/local/Library/Taps/caskroom/homebrew-cask/test/support/binaries/gzipped_asset.gz
application/x-gzip; charset=binary

[x] Followed hacking.md.

There is also another PR open trying to fix these issues, see #22002

Thank you, but this is aready being worked on.


Wrong version published on NPM

It seems that the latest published version on npm does not correspond to source code here. Specifically the code for supporting the --quiet option is missing.
Do you think you could publish updated package or make a new release?

I would like a release as well, especially since there hasn't been a release in over 15 months. I need this command-line option: https://github.com/pinterest/esprint/pull/75

Hey folks, I've released and published v0.5.0 with the latest changes (hopefully better late than never 😉)


jenkins_user and jenkins_view broken in 6.1.0 release

Cookbook version
6.1.0
Chef-client version
14.2.0
Platform Details
awslinux2, fedora28
Scenario:
jenkins_user is broken by the following commit that appears to inadvertently assign the ownership of the jenkins_user resource name to the JenkinsView class.
https://github.com/chef-cookbooks/jenkins/commit/e1242340815932f1ff4c9aaa74d1832dd9ff26b9
Steps to Reproduce:
converge any recipe that uses the jenkins_user resource
Expected Result:
successful compile, converge, and user creation
Actual Result:
Fails with the following error:
================================================================================
         Recipe Compile Error in /tmp/kitchen/cache/cookbooks/csg_jenkins/recipes/default.rb
         ================================================================================

         NoMethodError
         -------------
         undefined method `full_name' for Chef::Resource::JenkinsView

         Cookbook Trace:
         ---------------
           /tmp/kitchen/cache/cookbooks/csg_jenkins/recipes/service_account_config.rb:31:in `block in from_file'
           /tmp/kitchen/cache/cookbooks/csg_jenkins/recipes/service_account_config.rb:30:in `from_file'
           /tmp/kitchen/cache/cookbooks/csg_jenkins/recipes/master.rb:14:in `block in from_file'
           /tmp/kitchen/cache/cookbooks/csg_jenkins/recipes/master.rb:13:in `each'
           /tmp/kitchen/cache/cookbooks/csg_jenkins/recipes/master.rb:13:in `from_file'
           /tmp/kitchen/cache/cookbooks/csg_jenkins/recipes/default.rb:1:in `from_file'

         Relevant File Content:
         ----------------------
         /tmp/kitchen/cache/cookbooks/csg_jenkins/recipes/service_account_config.rb:

          24:        "#{rsa_key.ssh_type} #{data}"
          25:      }
          26:      mode '400'
          27:      action :nothing # only fired if the private key file is written above
          28:    end
          29:
          30:    jenkins_user domain_service_account_name do
          31>>     full_name    'Jenkins Admin Service Account'
          32:      email<EMAIL_ADDRESS>          33:      # must do this lazily to account for scenarios when the files are being written the first time
          34:      public_keys  lazy {
          35:        [::File.read(domain_service_account_pub_pem)]
          36:      }
          37:    end
          38:
          39:    ruby_block 'set-executor-config-post-file-write' do
          40:      block do

         System Info:
         ------------
         chef_version=14.2.0
         platform=amazon
         platform_version=4.14.51-66.38.amzn2.x86_64
         ruby=ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]
         program_name=/opt/chef/bin/chef-client
         executable=/opt/chef/bin/chef-client

         Running handlers:
       [2018-07-25T14:47:08+00:00] ERROR: Running exception handlers
         Running handlers complete
       [2018-07-25T14:47:08+00:00] ERROR: Exception handlers complete
         Chef Client failed. 1 resources updated in 06 seconds
       [2018-07-25T14:47:08+00:00] FATAL: Stacktrace dumped to /tmp/kitchen/cache/chef-stacktrace.out
       [2018-07-25T14:47:08+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
       [2018-07-25T14:47:08+00:00] FATAL: NoMethodError: undefined method `full_name' for Chef::Resource::JenkinsView

The error I'm getting is almost identical:
      NoMethodError:
        undefined method `public_keys' for Chef::Resource::JenkinsView

I've run into very similar-looking issues with other cookbooks on Chef 14, so I'm beginning to suspect this may be a Chef 14 issue more so than a cookbook issue.

The error I'm getting is very similar, but not quite identical:
      NoMethodError:
        undefined method `public_keys' for Chef::Resource::JenkinsView

I was able to fix it by adding the following to my metadata.rb:
depends 'jenkins', '< 6.1.0'

the resource_name field in the new resource wasn't updated and this was causing things to load incorrectly. Should be fixed in 6.2 now

6.2 works for me!


Pull request template

WIP.
@CalleB3 requested a PR template for this repo in order to help understand what should be in a PR description.

Looks good! Maybe we can have someting similar for other repos aswell?

Love the usage of HTML comments in this way, it's my preferred way of doing things as well.

My personal opinion is that parts of the template are too detailed. This template will only be applicable to specific PRs with new feature implementations but will not be relevant for smaller changes. My experience with other projects is that it becomes cumbersome when the PR template requires a lot more information than is actually necessary.

requires a lot more information than is actually necessary

@phillebaba  The template does not intend to require any information. It intends to help you to consider what is pertinent for your pull request. How can we change the text to make this clearer?

I do not really have time to work with this now and it seems the need has subsided for the time being.


Can the APM global view support only displaying and counting selected service groups

Please answer these questions before submitting your issue.

Why do you submit this issue?
[x] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?
Can the APM global view support only displaying and counting selected service groups?We need to display and calculate only the groups that the user cares about

Bug

Which version of SkyWalking, OS, and JRE?

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.

Requirement or improvement

Please describe your requirements or improvement suggestions.

No. it can't.


Change 'Running' status to static (not animated)

Hi! If we could change the running status to a static blue dot (rather than a blinking one), that would be amazing. Thank you!
http://storybook.backstage.io/?path=/story/status--default

Hi! I'll try to tackle that :)

Thanks @Nishikoh -- assigned you 👋


pupups: header image, fix title and fields

close https://github.com/CartoDB/cartodb/issues/9701
-bumped cartodb.js with latest changes
available in ded03

CR @alonsogarciapablo

🚀


Doom Retro requires SDL v.2.28.5.

Game

Doom II
The Ultimate Doom(Probably shares the same problem)

Engine
Doom Retro
Linux Distribution
SteamOS
Luxtorpeda Version
v70.0.0
Bug description
Prompt as the title says.
Steps To Reproduce
Launch Doom Retro engine from Luxtorpeda.
Expected Behavior
Run without any problem; and expected SDL2 to be updated automaticly after "updating" Luxtorpeda from a previous version
Additional Context
I "updated" luxtorpeda from previous versions through ProtonUp-Qt; Could this has somehow prevented SDL2 from updating?
Relevant log output
No response

Doom retro has a requirement in their source code that the built version is the same as the runtime version. Not entirely sure why but that basically means each time the sniper runtime updates, doom retro comes up with that complaint.
I should be able to fix it by re building it with latest sniper again. I'll look into that sometime next week when I can.

I think I've fixed it. If you launch it again it should download a new version can you try that out and see if to works?

It's working now, appreciated for your efforts!

Great!


Update to Kotlin 1.8.0

I've released 0.3.6-1-8-0-RC with the changes up to this point

And now 0.3.7-1-8-0-RC with the latest changes from 0.3.7

And now 0.3.8-1-8-0-RC2 with the latest changes from 0.3.8 + kotlin 1.8.0-RC2

Going to get a retroactive review on this one given the small set of changes, prior integration test in the slack android repo, and desire to move this on before I go back on vacation


[Feature Request] Fetch updates directly from the tldr-pages repository

Is your feature request related to a problem? Please describe.
The pages are not always updated.
Describe the solution you'd like
Fetch the pages directly from the tldr pages-repository or download the pages ZIP.

These should get automatically updated the next day. Could be better but td is unable to rewrite it atm.


Feature: Add Category and allowCollapse to Saved Queries

Feature Description
I would like to organize, expand and condense custom queries from within the GUI.
Currently custom queries are stored 'flat' which can be hard to navigate.
Are you intending to implement this feature?
No
Current Behavior
The current /api/v2/saved-queries-endpoint supports uploading of queries with a name, query and it seems since #730 also a description but not a category as far as I can tell.
The OOTB queries already try to achive something similar by using categories:
https://github.com/SpecterOps/BloodHound/blob/e88dad44567d826d3e4ea21ca1ead1774ca1cfa6/packages/javascript/bh-shared-ui/src/commonSearches.tsx#L37
Desired Behavior
The saved_queries model and GUI need to be updated with new fields and 'collapse'-logic.
Use Case

Needed to make management of queries easier within the GUI.

Additional Information
{
  "name": "Some Test Seach",
  "category": "Category 1",
  "queryList": [
    {
      "final": true,
      "query": "MATCH (.....",
      "allowCollapse": true
    }
  ]
}

Old datamodel allowed for collapsible categories of queries.

Pre-shipped queries already seem to come with some category.

Closing as a duplicate of https://github.com/SpecterOps/BloodHound/issues/725

I tried to search but hadn't seen that one. Thanks! :)


chore: do not render use exisitng method if fairground

Related issues 🔗
Closes #[Issue number here]
Description ℹ
A description of what this PR does. This should be non-dev readable. Technical stuff should go in the technical section below.
Demo 📺
Gif/video/images of new/corrected functionality if applicable
Technical 👨🔧
Details of technical implementation that reviewers may need to be aware of, if applicable.

Actions are down so i am merging like this.


[iOS]  UiKitView will be rendered with borders.

When I use UiKitView on iOS,  the UiKitView will be rendered with  borders.
Even, while the modal bottom sheet is showing, the borders are still there.
Strangely, when I take a screenshot or record screen, the borders will disappear!!

Any UiKitView will be reproduced the problem.
Device: iPhone 8plus
iOS: 13.5.1

flutter doctor -v
[✓] Flutter (Channel stable, v1.17.5, on Mac OS X 10.15.5 19F101, locale zh-Hans-CN)

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses
[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
[!] Android Studio (version 4.0)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
[!] IntelliJ IDEA Ultimate Edition (version 2020.1.2)
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.

Edited by @cyanglaz
This seems to be device and OS specific and I'm putting up a list to keep track:
Check mark means validated and confirmed by a team member.
Reproducible devices:

[x] iPhone 8 plus 14.6
[ ] iPhone 8 plus 13.5.1
[ ] iPhone 11 pro max
[ ] iPhone 12 mini
[ ] iPhone 12 pro

Not-reproducible devices:

[x] iPhone 11
[x] iPhone 12 pro max 14.4.2
[x] iPhone 8 plus 14.6

Hi @ENUUI
Can you please provide your flutter run --verbose and a complete reproducible minimal code sample and screenshot of the borders
Thank you

EXAMPLE_CODE
There are not screenshots but photos, because UiKitViews in screenshots do not have any unexpected border.
And the borders will appear again after taking a screenshot or recording the screen.

Hi @ENUUI
Your code repository has missing code and unable to run. There is no uikitview_example.dart class and no native code for UIKitView
Please check your repository and make sure it has everything to reproduce the issue
Thank you

@TahaTesser
So sorry! Please try again.

I can run the code sample now but no borders on physical iPhone XR. This could be device specific, author has  on Device: iPhone 8plus
iOS: 13.5.1

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-7.1.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-7.1.pre at /Users/taha/Code/flutter_dev
    • Framework revision 7736f3bc90 (3 days ago), 2020-07-10 16:33:05 -0700
    • Engine revision d48085141c
    • Dart version 2.9.0 (build 2.9.0-21.2.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (6 available)
    • SM M305F (mobile)      • 32003c30dc19668f                     •
      android-arm64  • Android 10 (API 29)
    • Taha’s iPhone (mobile) • 00008020-001059882212002E            • ios
      • iOS 13.5.1
    • iPhone 11 (mobile)     • C56E212F-BE8E-4766-8610-12CFADC797F0 • ios
      • com.apple.CoreSimulator.SimRuntime.iOS-13-5 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64
      • Mac OS X 10.15.5 19F101
    • Web Server (web)       • web-server                           •
      web-javascript • Flutter Tools
    • Chrome (web)           • chrome                               •
      web-javascript • Google Chrome 83.0.4103.116

• No issues found!

flutter doctor -v
[✓] Flutter (Channel stable, v1.17.5, on Mac OS X 10.15.5 19F101, locale en-GB)
    • Flutter version 1.17.5 at /Users/taha/Code/flutter_stable
    • Framework revision 8af6b2f038 (2 weeks ago), 2020-06-30 12:53:55 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/taha/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/taha/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.47.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.2

[✓] Connected device (2 available)
    • SM M305F      • 32003c30dc19668f          • android-arm64 • Android 10 (API
      29)
    • Taha’s iPhone • 00008020-001059882212002E • ios           • iOS 13.5.1

• No issues found!

@TahaTesser
I've tried iPhone 8plus,  iPhone 11 and iPhone 11 Pro Max ,  only  iPhone 11 is normal.
See photos of iPhone 11 Pro Max.

flutter doctor -v
[✓] Flutter (Channel stable, v1.17.5, on Mac OS X 10.15.5 19F101, locale zh-Hans-CN)
    • Flutter version 1.17.5 at /Users/admin/.flutter_code_source/stable/flutter
    • Framework revision 8af6b2f038 (2 weeks ago), 2020-06-30 12:53:55 -0700
    • Engine revision ee76268252
    • Dart version 2.8.4

[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
    • Android SDK at /Users/admin/Library/Android/sdk
    • Platform android-29, build-tools 29.0.2
    • ANDROID_HOME = /Users/admin/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.8.4

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[!] IntelliJ IDEA Ultimate Edition (version 2020.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] Connected device (1 available)
    • H的iPhone • 2c2b047d44debadd29c52ea0c1136b0a6d33658a • ios • iOS 13.5.1

I can confirm, same issue on the latest dev channel build, iOS only.
In my case webview_flutter and google_maps_flutter are affected.
See the screenshot of a google maps widget. The border is drawn on top of the button.
Also the line (embedding border?) in the bottom right corner of the map is not respecting clipping.
Same behavior for a webview.

Container(
  width: 200,
  height: 200,
  child: ClipRRect (
    clipBehavior: Clip.antiAliasWithSaveLayer,
    borderRadius: BorderRadius.circular(25),
    child: GoogleMap(
...

Additionally, notice the horizontal lines artifacts above and below the status bar icons.

iPhone XR, iOS 13.5.1
flutter doctor -v
[✓] Flutter (Channel dev, 1.21.0-1.0.pre, on Mac OS X 10.15.5 19F83c, locale
    en-DK)
    • Flutter version 1.21.0-1.0.pre at /Users/roman/development/flutter
    • Framework revision f25bd9c55c (4 days ago), 2020-07-14 20:26:01 -0400
    • Engine revision 99c2b3a245
    • Dart version 2.9.0 (build 2.9.0-21.0.dev 20bf2fcf56)

Another issue, a "frost" ImageBackdrop filter page transition seems to have no effect on the embedded view, again, only on iOS.
As you can see, the map part on the right side is not blurred at all and map border is shown on top of the transparent page.
The original border issue is not reproducible on simulator while this one is.
Not sure, if it's related, @TahaTesser ?

class TransitionBuilders {
  static Widget frostTransition(
    BuildContext context,
    Animation<double> animation,
    Animation<double> secondaryAnimation,
    Widget child,
  ) {
    return FrostTransition(
      animation: Tween<double>(begin: 0, end: 1).animate(animation),
      child: child,
    );
  }
}

class FrostTransition extends AnimatedWidget {
  final Widget child;
  final Animation<double> animation;

  FrostTransition({
    this.animation,
    this.child,
  }) : super(listenable: animation);

  @override
  Widget build(BuildContext context) {
    return BackdropFilter(
      filter: ImageFilter.blur(
        sigmaX: animation.value * 5,
        sigmaY: animation.value * 5,
      ),
      child: child,
    );
  }
}

Same hardware, flutter version as in my previous comment.

@jmagman ?

@dvird Please don't @ individual contributors.  I don't generally work on these kind of bugs.

What's about it? i think its much more important than the others because It's foundations. if ios native view does work it means a lot about flutter condition. i think you should promote it and take it more seriously

Maybe this is framework?

?

Any update on this? Found same issue on iPhone 12 mini and iPhone 12 pro.

When using google map it renders the white border. But when I do screenshot or frame recording it disappears like a magic. Happens on iphone 12 mini and pro max.

It looks very circumstance dependent, I can't reproduce when I try to.

code sample
import 'dart:async';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      title: 'Material App',
      // theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('PlatformView WebView'),
      ),
      body: Container(
        width: 300,
        height: 300,
        child: ClipRect(
          child: WebView(
            onWebViewCreated: (controller) {
              controller.loadUrl('https://flutter.dev/');
            },
          ),
        ),
      ),
    );
  }
}

typedef void WebViewCreatedCallback(WebViewController controller);

class WebView extends StatefulWidget {
  const WebView({
    Key key,
    this.onWebViewCreated,
  }) : super(key: key);

  final WebViewCreatedCallback onWebViewCreated;

  @override
  State<StatefulWidget> createState() => WebViewState();
}

class WebViewState extends State<WebView> {
  @override
  Widget build(BuildContext context) {
    if (defaultTargetPlatform == TargetPlatform.android) {
      return AndroidView(
        viewType: 'webview',
        onPlatformViewCreated: _onPlatformViewCreated,
      );
    } else if (defaultTargetPlatform == TargetPlatform.iOS) {
      return UiKitView(
        viewType: 'webview',
        onPlatformViewCreated: _onPlatformViewCreated,
      );
    }
    // TODO add other platforms
    return Text(
        '$defaultTargetPlatform is not yet supported by the map view plugin');
  }

  void _onPlatformViewCreated(int id) {
    if (widget.onWebViewCreated == null) {
      return;
    }
    widget.onWebViewCreated(new WebViewController(id));
  }
}

class WebViewController {
  WebViewController(int id) {
    this._channel = new MethodChannel('webview$id');
  }

  MethodChannel _channel;

  Future<void> loadUrl(String url) async {
    return _channel.invokeMethod('loadUrl', url);
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.22.6 at /Users/tahatesser/Code/flutter_stable
    • Framework revision 9b2d32b605 (12 days ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.4)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.

[✓] Flutter (Channel master, 1.26.0-18.0.pre.156, on macOS 11.1 20C69 darwin-x64, locale en-GB)
    • Flutter version 1.26.0-18.0.pre.156 at /Users/tahatesser/Code/flutter_master
    • Framework revision 45508985b1 (8 hours ago), 2021-02-02 22:46:04 -0500
    • Engine revision 2c144c3eeb
    • Dart version 2.12.0 (build 2.12.0-282.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Volumes/Extreme/SDK
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Volumes/Extreme/SDK
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.1 20C69 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 88.0.4324.96

• No issues found!

same problem on iphone8 plus IOS13.6

这个问题有最新消息了么

Same issue here:
Flutter 2.0.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 4d7946a68d (5 weeks ago) • 2021-03-18 17:24:33 -0700
Engine • revision 3459eb2436
Tools • Dart 2.12.2

尝试过各种方案都不行。无奈最终选择了如下取巧的方式。

让WebView全屏展示。此时WebView的边框会和手机屏幕的边框重合，用户无感知

通过注入js的方式给body增加需要的间距

I have tried all kinds of schemes. Reluctantly chose the following trickery.

Let the WebView display in full screen. At this time, the frame of the WebView will overlap with the frame of the phone screen, and the user has no perception

Add the required spacing to the body by injecting js

iOS14以上系统启动App的时候清空背景色就能解决这个问题

@ENUUI  did you resolve this solution?

It also affects the https://github.com/googleads/googleads-mobile-flutter package (when using inline ads). And it is not consistant — sometimes there are borders, sometimes — no borders. Also it is hard to make a screenshot, since this borders are not captured by video screenshot or still.
This issue will prevent us to monetize the app using admob :(

Any news? this issue is really critical for UX.
A pixel bleed in a production application is a situation we all want to avoid.
Please help,
Thanks

ImageBackdrop

Backdrop filter on iOS platform view and Android hybrid composition platform view has not been implemented yet. Please follow https://github.com/flutter/flutter/issues/43902 and https://github.com/flutter/flutter/issues/58426 for more details :)

Any update? I'm facing the same issue.

On the latest flutter stable, same issue occured.

[✓] Flutter (Channel stable, 2.2.3, on macOS 11.5.2 20G95 darwin-x64, locale en-CN)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[✓] Xcode - develop for iOS and macOS
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] VS Code (version 1.59.1)
[✓] Connected device (2 available)

My app still not public because of this..

Our team is able to reproduce it only on iPhone 12 mini. On other devices, this issue does not occur. Are there any updates?

Updates: I was able to repro in a iPhone 8 plus iOS 14.6
Initially I thought the issue might caused by 1 pixel off during layout. (For example, touchInterceptor is 1 pixel larger than it suppose to be)
I tried with assigning different colors to different views,(also explicitly setting borderWidth to all the views to 0) the border still shows gray. See:

Will continue investigate and post updates if I have some progression.

same issue..
please fix asap

having the same issue, tried with physical iphone xr

@cyanglaz Do you have news about this?
Would be great if you can update on progress.
This issue is critical for production.
Thanks

Flutter Team, do u have any news about fix or some workaround?
Issue is critical for production, please fix asap

I have been pulled to some other high priority work. So as now, there hasn't been any progress since my last comment. I (or someone else) will eventually circle back to this.

Since this issue is over a year old, has anyone found a workaround? (I tried wrapping with a ClipRect and other trickery without any success)

I can run the code sample now but no borders on physical iPhone XR. This could be device specific, author has on Device: iPhone 8plus iOS: 13.5.1
flutter doctor -v
flutter doctor -v
Can you upgrade to latest master and try again Execute the follwing flutter channel master flutter upgrade --force flutter doctor -v
If the problem persist on latest master, please provide new flutter doctor -v with latest master Thank you

This may be due to the screen scale is 3

I try to found the problem point and found that: This line is show in the OverlayView which in the OverlayView set frame and if it's parent OverlayWrapper don't set clipToBounds property the line disappear

@TahaTesser EXAMPLE_CODE There are not screenshots but photos, because UiKitViews in screenshots do not have any unexpected border. And the borders will appear again after taking a screenshot or recording the screen.

I try your example, and delete the UIKIt View backgroundColor then the border disappear;
But I don't know why😂

UIKitView is premultiplied alpha and flutter view may be straight alpha, and this issue is blend mode bug ?

Update:
I have reduced the issue into a scenario where adding a UIView on top of FlutterView will reproduce the issue.
I also found that this issue only exists when using MetalLayer or EAGLLayer. CALayer doesn't have this issue.
@chinmaygarde Might have more thoughts on this.

https://github.com/flutter/engine/pull/30664
I have a solution.

 is there any solution？
flutter/engine#30664

this no iOS code，just webview page to flutter page

@maoemao I know, this question is not cause of WebView page. The reason is iOS UIKitView

https://github.com/flutter/engine/pull/30664 was reverted due to a performance issue https://github.com/flutter/engine/pull/31710

Any updates?

@cyanglaz  Do you have news about this?
This issue is critical for production.
Thanks

No updates? Issue is still present on 3.3.0.

As a partial workaround for those running into this issue with flutter_webview, I found that setting backgroundColor: Colors.transparent on the WebView mostly resolved the issue in my case.

I just use @JsouLiang solution. Turned off viewOpaque property of FlutterViewController with MethodChannel when only unexpected border lines showed up. backgroundColor: Colors.transparent is cannot solve bottomSheet or overlay view case.
@JsouLiang I know your solution has performance issue. Is this performance issue will affect after turn on viewOpaque property again or not?

@Jeonguk-ninehire I think the GPU performance loss that has increased, The exact situation may need to see Xcode instrement's analysis

I don't know if this can solve your issues, but I was facing an issue very similar to this one where I render a native UIView and when displaying a Dialog on top of this UIKitView I saw some strange lines (borders) of that view.
In my case around the native iOS view I have a container with a border radius. Passing the same border radius to the native view seem to have solved this issue. Example of my code:
 late final args = <String, dynamic>{
   'borderRadius': borderRadius,
 };

/// view
UiKitView(
  creationParams: args,
  creationParamsCodec: const StandardMessageCodec(),
  ...
)

then on Swift in the init of the FlutterPlatformView:
// create the view before the super.init() call
_view = UIView() // any custom view can be used here, used UIView only for the example
super.init()
let params = args as! [String: Any]
let borderRadius = params["borderRadius"] as! Double
// these 3 lines seems fixing the issue (at least for me)
_view.isOpaque = false
_view.layer.cornerRadius = borderRadius
_view.layer.masksToBounds = true

Hope this can help!

Un-assign myself as I'm not actively working on this.

Any update on this?

I just tested the code from https://github.com/ENUUI/uikitview_example on my iPhone XS and I can't seem to reproduce the issue on the latest version of flutter stable.
If anyone is still facing this issue, can you please provide the device you're seeing it on along with a complete minimal reproducible code sample so we can further investigate this?
Thank you


Versioning devbox config

In case of apacheHttpd, the documentation says
We recommend copying your httpd.conf file to a new directory and updating HTTPD_CONFDIR if you decide to modify it.
But in case php plugin, the php-fpm.conf path is hard coded to {{ .DevboxDir }}/php-fpm.conf.
Is the devbox.d directory managed by the project, or by devbox? To be more specific, are we allowed to add / modify files within the devbox.d directory, or should we ignore the entire directory from version control? Will devbox try update the files in devbox.d, even if they are modified?
Also, the apache plugin documentation says:

Note that by default, Apache is configured with ./devbox.d/web as the DocumentRoot. To change this, you should copy and modify the default ./devbox.d/Apache/Apache.conf

The default file is ./devbox.d/apacheHttpd/httpd.conf.

Hi @JoyceBabu
As mentioned in the other issue (#894 ), the stuff in devbox.d gets generated by the plugin, but then you're free to edit as you see fit, and commit it to version control.
Also, you can have your configuration file somewhere else if you want, and then point HTTPD_CONFDIR to that place. The plugins are just meant to make things "just work" out-of-the-box, so they create files and set environment variables in a reasonable way, but you're free to change them however you want afterwards.
--

The default file is ./devbox.d/apacheHttpd/httpd.conf.

Thank you, that's a typo in the docs. I'll send a fix.

but you're free to change them however you want afterwards.

You can override a variable that is set by a plugin by putting it in devbox.json:
https://www.jetpack.io/devbox/docs/configuration/#env

@ipince
In that case is is safe to say that we are free to modify the default httpd.conf in place, without copying it to another location? If so, the documentation should probably be updated to remove the copying part.

Note that by default, Apache is configured with ./devbox.d/web as the DocumentRoot. To change this, you should modify the default ./devbox.d/apache/httpd.conf.

Also, will devbox try update the files in devbox.d, even if they are modified?

@JoyceBabu yes, you can modify in place.
Devbox will not overwrite.
Please see this section in the docs:
https://www.jetpack.io/devbox/docs/guides/plugins/#helper-files


chore: minor fix to trigger publishing CI

Let's try this again, nix flake should do it

bors merge


Set templates to use re-base as dependency

Set and define all templates to use re-base as a dependency so there's no duplicated code, and also would help to create new ones.

According to react-native-cli source code, it seems to me that's possible to define dependencies on a template dummy package.json file, and since they are installed using npm install and copied its content to the current folder, then a template would have as dependency a parent template. I think it would work, and also maybe the dependencies.json file could be removed too...


fix: [IDP-3114]: Added the example of mkdocs.yaml

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: Added the example of mkdocs.yaml
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[x] Successful preview build.
[x] Code owner review.
[x] No merge conflicts.
[x] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://667536c66a08c64312eb49dd--harness-developer.netlify.app


Android JVM does not allow NewGlobalRef whilst exception pending

Relates to Android branch here.
Android JNI does not allow NewGlobalRef() to be called whilst an exception is pending, which is causing the following error when trying to raise an exception from the JVM side:
JNI DETECTED ERROR IN APPLICATION: JNI NewGlobalRef called with pending exception java.lang.Exception: I am an error
   at void com.example.swift.HelloSwift.throwMessage(java.lang.String) (HelloSwift.kt:58)
   at int com.example.swift.HelloSwift.sayHello(int, int) (HelloSwift.kt:-2)
   at java.lang.String com.example.swift.HelloSwift.getGreeting() (HelloSwift.kt:26)
   at java.lang.String com.example.swift.HelloSwift.access$getGreeting(com.example.swift.HelloSwift) (HelloSwift.kt:17)
   at void com.example.swift.HelloSwift$onCreate$1$1$1.invoke(androidx.compose.foundation.layout.PaddingValues, androidx.compose.runtime.Composer, int) (HelloSwift.kt:68)

NewGlobalRef() is called by JavaObjectHolder.
I haven't done any further investigation.

This appears to fix issue:
diff --git a/Sources/JavaKit/Exceptions/ExceptionHandling.swift b/Sources/JavaKit/Exceptions/ExceptionHandling.swift
index efd98e9..cf063d0 100644
--- a/Sources/JavaKit/Exceptions/ExceptionHandling.swift
+++ b/Sources/JavaKit/Exceptions/ExceptionHandling.swift
@@ -20,9 +20,8 @@ extension JNIEnvironment {

     // Check whether a Java exception occurred.
     if let exception = interface.ExceptionOccurred(self) {
-      let throwable = Throwable(javaThis: exception, environment: self)
       interface.ExceptionClear(self)
-      throw throwable
+      throw Throwable(javaThis: exception, environment: self)
     }


Fix typos in style customization doc (issue: #1527)

This PR fixes typos in the style customization doc.
To be more specific:

.cell_display => .hydrogen_cell_display: The class name of cells in a multiline result is now defined as .multiline-container .hydrogen_cell_display, but the example still uses .multiline-container .cell_display (, about which I created #1527)
Typos: availible => available, puting => putting

(I found 1 package spec error and 5 flow type-check errors, but they are definitely unrelated to this commit)

Thank you Ben for merging !


Add RandomState support for the sklearn wrapper

Some libs that expect a sklearn-compatible estimator, pass a random_state parameter.
The random_state parameter is similar to the seed parameter of LightGBM, but it can also receive a RandomState instance.
random_state : int, RandomState instance or None; default=None
    If int, random_state is the seed used by the random number generator;
    If RandomState instance, random_state is the random number generator;
    If None, the random number generator is the RandomState instance used
    by `np.random`.

At the moment, if I pass a random_state parameter with a RandomState instance, I get a Unknown type of parameter exception from line 134 in basic.py
Would it be possible to add support for a sklearn-compatible random_state parameter for the sklearn wrapper?

@wxchan

@ekerazha all our current random numbers are generated in c++ code, so do you want to use RandomState to generate random number, or only the random seed matters (the seed will pass to c++ and still generate random number in c++)?

@wxchan I think it should be ok to just take the seed, however it is not possible to get the original seed from a RandomState instance (see: https://stackoverflow.com/questions/32172054/how-can-i-retrieve-the-current-seed-of-numpys-random-number-generator ). Maybe we can still get a value (although it's not the original seed) calling get_state() (see: https://docs.scipy.org/doc/numpy/reference/generated/numpy.random.get_state.html ) and pass this value to the c++ code.
So the approach could be this:

If random_state is a int value, pass it as seed to the c++ code (just like for the seed parameter).
If random_state is a RandomState instance, call get_state() and derive from the returned value (how?) a seed for the c++ code. Ideally we would directly use RandomState to generate random numbers, but I don't know if this is feasible.

@ekerazha The simplest way is to generate a random number as the seed, but I think it won't be what you want. (because it makes no differences as passing an integer.) But actually for current codes, even if you pass an integer, it is still used to generate 4 different random number for different purposes (bagging, sub-feature etc).

@wxchan I think I'd go for the two steps I listed above, so:

If random_state is a int value, just pass that value as seed
If random_state is a RandomState instance, call get_state() and derive a int value from that (crc32 on some value returned by get_state()?) to use as seed

What do you think about this?

@ekerazha what is the different between crc32 on RandomState.get_state() (which returns tuple(str, ndarray of 624 uints, int, int, float)) and a random number generated by RandomState, like RandomState.randint(MAX_INT)? Or can you describe where you want to use RandomState instead of an integer?

@wxchan well, if for the same RandomState original seed, randint(MAX_INT) always returns the same value, I think it should be ok to use it... maybe the crc32 on internal state approach is an overcomplication :-)

@ekerazha sorry I am a little distracted by other things. Your solution is right and better. But the actual key question here is, why don't you just use an integer, what is the necessity to use RandomState. You can simply pass an integer to seed, using RandomState doesn't make thing easier in my opinion.

@wxchan Because some libs that rely on sklearn estimators, expect a sklearn-compatible behavior for the random_state parameter.

But they can't accept integer?

I think this feature is acceptable, but the solution is not elegant enough (not like we can get seed directly from RandomState). And it's not something we must add. What's the solution of those sklearn-compatible estimators?


Migrate ExtensionStartupRunnerGenerator to IIncrementalGenerator

Current version of ExtensionStartupRunnerGenerator was created as an implementation of ISourceGenerator. In this PR, we are migrating that to IIncrementalGenerator, which offers better performance characteristics.
resolves #1007
Pull request checklist

[x] My changes do not require documentation changes

[ ] Otherwise: Documentation issue linked to PR

[ ] My changes should not be added to the release notes for the next release

[ ] Otherwise: I've added my notes to release_notes.md

[x] My changes do not need to be backported to a previous version

[ ] Otherwise: Backport tracked by issue/PR #issue_or_pr

[x] I have added all required tests (Unit tests, E2E tests)

A couple things:

Just want to confirm we have no intention of supporting .NET5 with this project? If we do, I think we need to keep the old ISourceGneerator around as well. But I am fairly certain we only support NET6 and up here.
I really like how the logger message generator is organized into a parser and emitter sub class. If you have time or desire to refactor towards something like that, it would be nice to see.

Yea, I like splitting into parser and emitter approach. Let me handle that in the next iteration.

Closing this and using #1369 to track the work once we're working on 2.x


schedule is not connected to main page

We have the schedule code but we didn't add it to the main page as we have not decided the schedule fully yet :)

can you guide me on how can I add it to the main page since I'm using your template for the upcoming hackathon in my college. also, the navbar keys and faqs aren't properly formatted for mobile view.

Hey @naqeeb2710 , will fix that mobile view issue thanks for letting us know

@naqeeb2710 check this https://github.com/Limbo-Hacks/Hackathon-website-template/pull/6 on where to add

@naqeeb2710 Schedule is now connected to main application, closing this issue


fix capitalization in our yaml

Right now our yaml format uses a mix of upper and lowercase words. It should use lowercase camelCase like k8s yaml does.

ok! boring job for an afternoon, assign it to me


filter state: register disable tunneling tcp_proxy filter state object

Commit Message: register yet another filter state object - disable tunneling config.
Additional Description:
Risk Level: low, mostly documentation
Testing: no
Docs Changes: yes
Release Notes: no

/retest

/retest

/retest

/retest


Marathon cluster all apps restored to old point in time snapshot by delete deployment

May be related to https://github.com/mesosphere/marathon/pull/1399 & https://github.com/mesosphere/marathon/issues/660
We had couple of deployment task in hanged in state for 2-3 weeks
curl  marathon.shipped-cisco.com/v2/deployments | python -m json.tool
[
  {
        "affectedApps": [
            "/sleep-cluster"
        ],
        "currentActions": [
            {
                "action": "ScaleApplication",
....            }
        ],
        "currentStep": 2,
        "id": "4f918018-113e-4c06-ac3d-9294f55690c6",
        "steps":
            [
                {
                    "action": "ScaleApplication",
                    "app": "/sleep-cluster"
                }
            ]
        ],
        "totalSteps": 2,
        "version": "2015-04-06T14:21:06.685Z"
    }
]

To cleanup hanged deployment jobs , I executed delete deployment, (without force=true)
curl  -X DELETE marathon.xyz/v2/deployments/4f918018-113e-4c06-ac3d-9294f55690c6
{"version":"2015-04-26T18:34:32.517Z","deploymentId":"f54ad93a-76a6-4f38-b059-cc93f335ccf9"}

As force is false, expected only single app to be reverted. This resulted in all apps of cluster to be reverted to 3 week back point in time snapshot. Apps created after that point got deleted and already deleted apps are restored.

Thanks for reporting this, we already fixed this in master. We plan to release 0.8.2-RC1 tomorrow.

It's a bug when putting everything in the root group /
When they get stuck just scale them forcibly to the number of containers already running then re-deploy. It was fixed in the latest release.
Also your marathon UI is open to the world..


AddConversionByType for time.Time and timestamppb.Timestamp

I'm trying to convert from time.Time to timestamppb.Timestamp. This is the code I have written below but it doesn't work, and return such an error panic: reflect.Set: value of type time.Time is not assignable to type *timestamppb.Timestamp
Conversion:
	srcType := reflect.TypeOf((*time.Time)(nil)).Elem()
	targetType := reflect.TypeOf((**timestamppb.Timestamp)(nil)).Elem()
	model.AddConversionByType(srcType, targetType, func(in reflect.Value) (reflect.Value, error) {
		t := timestamppb.New(in.Interface().(time.Time))
		return reflect.ValueOf(&t), nil
	})

struct A {
 CreatedAt timeTime
}

struct B {
 CreatedAt *timestamppb.Timestamp
}

Is there anyone who can show me what I'm doing wrong here?
cc: @jeevatkm @rmohr  @CodinCat

@muradhajiyev I can barely remember having written this, but let me see if I can help :)
According to the docs I created I think the function signature should look like this:
model.AddConversionByType((*time.Time)(nil), **timestamppb.Timestamp)(nil), func(in reflect.Value) (reflect.Value, error) {

So registering e.g. (*time.Time)(nil) instead of reflect.TypeOf((*time.Time)(nil)).Elem() may do the trick.


AM-1091: License notification in UI

:id: Reference related issue.
https://gravitee.atlassian.net/browse/AM-1091
:pencil2: A description of the changes proposed in the pull request
The information is present when the license expires in 30 days and the user has "organization_settings_read permissions". Mocks are not ready the colors from 15 days and expiration are chosen randomly.
:computer: Add screenshots for UI
29 days

12 days

expired

when menu is collapsed

I click on "request change" but both comments are more a discussion.


MM-48195 - onboarding messaging item not working on guest users

Summary
The 'learn more about messaging' onboarding item was not working as expected for guest users since channel creation and user invitation are disabled for this roles. This PR makes sure to start the onboarding tour for this role only in the steps that they can see that are send messages and configure your env.
Ticket Link
https://mattermost.atlassian.net/browse/MM-48195
Related Pull Requests
n/a
Screenshots
https://user-images.githubusercontent.com/10082627/200505588-14fafff0-de47-46a8-b613-990a5eaa04a5.mp4
Release Note
NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

@pvev There are some conflicts that need to be resolved in this PR.

ok, perfect, I will, thanks!

@AshishDhama requesting re-review after fixing several merge conflicts. Thanks!

@pvev Thanks for taking care of conflicts.

@pvev Thanks for taking care of conflicts.

no worries, but there is some problems with the functionality, I will check what happened and will fix it. Will let you know when the new changes are ready. Thanks!

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/260348

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

Trying to auto merge this PR.

Cherry pick is scheduled.

Pull Request successfully merged
SHA: 5929b8c6c8327b3a628f6bd2827c0043ec01e3eb


DBToaster regressive tests failing

When running regressive_test.sh PLAN_RUNNER from a clean Squall repo on Ubuntu 14.10 the DBToaster tests fail with this kind of error:
Running test 1 (0_01G_dbtoaster_hyracks) out of 31...
Exception in thread "main" java.lang.RuntimeException: Fail to prepare DBToaster dependencies
	at ch.epfl.data.squall.utilities.StormDBToasterProvider.prepare(StormDBToasterProvider.java:63)
	at ch.epfl.data.squall.main.Main.createTopology(Main.java:148)
	at ch.epfl.data.squall.main.Main.<init>(Main.java:235)
	at ch.epfl.data.squall.main.Main.main(Main.java:157)
Caused by: java.io.FileNotFoundException: /tmp/CUSTOMER_ORDERS3042266310918904881.jar (No such file or directory)
	at java.util.zip.ZipFile.open(Native Method)
	at java.util.zip.ZipFile.<init>(ZipFile.java:215)
	at java.util.zip.ZipFile.<init>(ZipFile.java:145)
	at java.util.jar.JarFile.<init>(JarFile.java:154)
	at java.util.jar.JarFile.<init>(JarFile.java:91)
	at ch.epfl.data.squall.utilities.JarUtilities.extractJarFile(JarUtilities.java:53)
	at ch.epfl.data.squall.utilities.StormDBToasterProvider.prepare(StormDBToasterProvider.java:53)
	... 3 more

A manual inspection of /tmp/ shows that the file exists, so maybe is a permissions issue

Hi Daniel. It is actually a bug. The front_end binary I include for DBtoaster is for Mac. I will add support for Ubuntu.

Solved by a24942a79f30307242581e4644fc495bdc3ded78
Still waiting to be able to run with Scala 2.10, though :)

@akathorn You have trouble when running with scala 2.10 ?


docs: add documentation for bigquery external table resource

Create documentation for bigquery external table resource addressed in this closed issue: https://github.com/odpf/optimus/issues/44

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.098%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4092

Relevant Lines:
5922

💛  - Coveralls

@vianhazman You also need to add this into docs/sidebar.js. Try building it locally & test using
yarn install
yarn build
yarn serve

@vianhazman You also need to add this into docs/sidebar.js. Try building it locally & test using
yarn install
yarn build
yarn serve

addressed in the latest commit, thanks!

LGTM


use JsonUnit to ignore the order of fields in expected JSON string

Problem:

Test io.dropwizard.jackson.JacksonTest#objectMapperSerializesNullValues uses Jackson to serialize object pojo. However, Jackson uses reflection API getDeclaredFields (https://github.com/FasterXML/jackson-databind/blob/3c67dc5bd9714635f6999bcb401b132791e9d7d0/src/main/java/com/fasterxml/jackson/databind/introspect/AnnotatedFieldCollector.java#L70) to get the field names, values, and etc. However, API getDeclaredFields does not guarantee any specific order of fields. So the serialized result (in this case, a JSON string) can be different depending on the returned result.
Test io.dropwizard.jackson.JacksonTest#objectMapperSerializesNullValues will fail if the serialized string is not in the format as expected.
An example error message:
Expecting:
 <"{"uuid":null,"string":null}">
to be equal to:
 <"{"string":null,"uuid":null}">
but was not.

Solution:

The test is actually coded with assertJ. I found a good test plugin (https://github.com/lukas-krecan/JsonUnit) that integrates well with assertJ to compare JSON string without taking the order into consideration.
Result:

Test will generate deterministic result (always pass in this case.)

@contextshuffling Thanks for your contribution!
Any chance doing this without adding an additional dependency, for example with @JsonPropertyOrder?

@joschi thanks for the comment, I will look into it

@joschi Thank you for pointing out that annotation. There're two more tests that cannot be fixed with an annotation. I've updated my PR with those two. Let me know if you still don't want the JsonUnit dependency, and I'll look for other ways to fix those two tests.

There're two more tests that cannot be fixed with an annotation.

Why couldn't they?

@joschi applying the annotation for the map field does not seem to have any effect on enforcing the order.

@contextshuffling True. We could use a SortedMap or NavigableMap such as TreeMap in that test case.
Did these tests actually fail for you? Because this would be the first time it happened as far as I remember.

@joschi I used a tool called NonDex (https://github.com/TestingResearchIllinois/NonDex)
The tests did not fail with the current HashMap implementation in Java 8,
but using the NonDex tool to check for other implementations make the
tests fail.
Following is a script to reproduce
git clone --depth 1 https://github.com/dropwizard/dropwizard
cd dropwizard
sed -i 's;<plugins>;<plugins> <plugin> <groupId>edu.illinois</groupId> <artifactId>nondex-maven-plugin</artifactId> <version>1.1.2</version> </plugin>;' pom.xml
mvn nondex:nondex -Dtest=io.dropwizard.jackson.JacksonTest#objectMapperSerializesNullValues -pl dropwizard-jackson -DnondexRuns=10

Fixing these tests ahead of time will make them not fail when the implementation changes.

@contextshuffling While I'm not sure this was a real problem (since the respective tests never failed locally or in CI builds), I've changed the tests accordingly.
Thanks for the hint!


Migration from ethers to alloy types

This PR handles the migration from ethers to alloy types.
Should close #1681.
Related to DOJ-277.

The saya test was not always passing, it's fixed on main once #1710 is merged.

The saya test was a bit flaky, it's fixed on main once #1710 is merged.

@glihm Let me know when we can merge this one and if we need to do something else here.

The saya test was a bit flaky, it's fixed on main once #1710 is merged.

@glihm Let me know when we can merge this one and if we need to do something else here.

Amazing, thank you for all the work done here, will review shortly. :+1:


Armour sets count for gear requirements

🚀 Feature Proposal
Allow armour sets, i.e. barrows, to count as having the gear. Currently if you have an armour set, i.e. Dharok's, and want to do Giant mole it says you need the armour.
Allow sets to count for partial requirements too, i.e. allow Karil's armour set to count as having the crossbow for shamans.
This will help clear bank space.

your minion can’t wear a box, same as in osrs

your minion can’t wear a box, same as in osrs

But it could unpack the set, use the gear, and pack it back up upon returning :smile_cat:

a packed down armour set shouldn't give boosts similar to in game, even tho other single items work from bank.


Problem running dotnet run command

Problem encountered on https://dotnet.microsoft.com/learn/dotnet/hello-world-tutorial/run
Operating System: macos
Provide details about the problem you are experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
hello world does not populate in the terminal. the error message says
Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly '/Users/jordan_g.o.a.t./myApp/bin/Debug/netcoreapp3.1/myApp.dll'. The system cannot find the file specified.

File name: '/Users/jordan_g.o.a.t./myApp/bin/Debug/netcoreapp3.1/myApp.dll'

@jeffschwMSFT what would cause this?

@lpereira did we investigate paths that have '.'s at the end?  What was the outcome?

We did; the issue is that Windows ignores the . in a path name if it precedes a /, so the function to convert a Unix path name to a Windows pathname will strip it.  I decided not to fix this in order to keep it compatible with Windows; however, I remember @mateoatr looking at this right after he joined the team and sending a PR to not strip that dot on Unix.  I think that PR has been merged.

This is the PR for reference.

The fix for this issue has been merged. @mateoatr, in which version should we expect the fix to be available?

This should've been working since 3.1.1, however I just ran into the same problem. I'll take a look at it.

@mateoatr did you get a chance to take a look?

@mateoatr did you get a chance to take a look?

The aforementioned PR was merged for .NET 5 - not .NET Core 3.1 (my bad); so this is currently working. If necessary I can backport the PR to 3.1.

The tutorials on the dotnet.microsoft.com won't be upgraded until we reach .NET 6, since we'll keep using the LTS version.
Is that a common issue?

I don't know how common it is, I'd guess not too common. And, realistically, it only affects Unix, since ending a directory name with a period violates Windows' naming conventions.


Opportunity Fund changed to Accion Opportunity Fund

Opportunity Fund https://www.opportunityfund.org/ appears to be Accion Opportunity Fund https://aofund.org/ now.

thanks! I'm actually gonna remove it now, bc it seems more like a loan than a microgrant program dd3444e


Devices with battery_alert_disabled set are not filtered out

First, thanks for the package, very well done and useful.
My ios phones defined are coming with a "sensor.xxxxx_battery_level" sensor which is well detected by "automation.update_battery_status_group_members". On the other hand, I want to filter them out and they are not.
I think this is because the following condition " not is_state_attr(entity_id, 'battery_alert_disabled', true)" should apply to any item and not only to the ones with battery in their name. Indeed ios phones objects have a battery icon and are therefore matching
the condition "or 'battery' in item.attributes.icon | lower"
I aso think  " not is_state_attr(entity_id, 'battery_alert_disabled', true)" should in fact test item.entity_id.

You shouldn't get alerts for them if you're using battery_alert_disabled, but they'll be in the group.  Are you looking for a way to exclude them from the group too?
A fix to the item.entity_id issue was merged last night.

I indeed thought only devices being monitored should be in the group.

On 26 Aug 2018, at 20:26, NotoriousBDG<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
You shouldn't get alerts for them if you're using battery_alert_disabled, but they'll be in the group. Are you looking for a way to exclude them from the group too?
A fix to the item.entity_id issue was merged last night.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/notoriousbdg/Home-AssistantConfig/issues/6#issuecomment-416058671, or mute the thread https://github.com/notifications/unsubscribe-auth/Anej8lDgyAfoMBVVuxUIzYsvqah_FqIPks5uUuhVgaJpZM4WMsbG.


Unable to import BLS12-381

I'm currently trying to add the BLS curve to a typescript project I have, and am unable to compile once I import via:
import { bls12_381 as bls } from '@noble/curves/bls12-381';
here a portion of the errors, this is the first one (there are loads more, but all in the same file):
node_modules/@noble/curves/abstract/bls.d.ts:80:64 - error TS1005: '>' expected.

80     G1: CurvePointsRes<Fp> & ReturnType<typeof htf.createHasher<Fp>>;

First I thought this could be a ESM/CJS issue, but I'm reasonably sure it is not at this point. I tried importing in different modes and the outcome is always the same. I tried importing the other curves, and have no issues there at all.
Can someone reproduce this?

you're probably using old version of typescript

Ah man, indeed, updating to latest fixes this.
Thanks for the quick support and the sick library.


test_sharding_fused_ebc deadlock fix

test_sharding_fused_ebc hang on rocm, we found that reson for deadlock in this multiGPU test is unsharded model tensor was on incorrect device.
weights_dev is not on the right device. From the log below,  for current_deivce = 1, weights_dev is on the wrong device. But weights_dev cannot be controlled by itself. It is part of the Module's buffer. So, the Module itself is not on the right device.
#### bounds_check_indices 0 ### current device =  0  indicies device = 0  offsets device =  0  weights_dev =  tensor([-0.2150,  0.2619, -0.2804, -0.1981,  0.1528,  0.0294, -0.1015,  0.1595,         0.0567, -0.2304,  0.1112, -0.0188, -0.1824,  0.1332, -0.1237,  0.1334,
         0.2809,  0.0660, -0.2932, -0.1700,  0.0692,  0.1564,  0.2257,  0.1722,
         0.2922,  0.1382,  0.0896, -0.0723, -0.0967, -0.1131, -0.0397,  0.1454,
         0.0515,  0.2385, -0.2375,  0.2085,  0.2463, -0.0311, -0.0817,  0.0660,
        -0.1539, -0.0108,  0.1203, -0.1073, -0.1993, -0.1923, -0.2983,  0.2792,
        -0.0309,  0.3012, -0.0275,  0.0547, -0.1685,  0.1217, -0.0311, -0.2816,
        -0.1240,  0.0151,  0.2479,  0.2557, -0.0266, -0.2155, -0.2981, -0.0728,
         0.2158,  0.2252, -0.0245,  0.0606, -0.1249,  0.0343,  0.2030,  0.1176,
         0.2016, -0.2167,  0.1062,  0.3157,  0.2631, -0.2756,  0.1661, -0.1768],
       device='cuda:0')
#### bounds_check_indices 1 ### current device =  0  indicies device = 0  offsets device =  0 rows_per_table device =  0 OPTIMIZER = OptimType.EXACT_SGD#### bounds_check_indices 0 ### current device =  1  indicies device = 1  offsets device =  1  weights_dev =  tensor([-0.2150,  0.2619, -0.2804, -0.1981,  0.1528,  0.0294, -0.1015,  0.1595,         0.0567, -0.2304,  0.1112, -0.0188, -0.1824,  0.1332, -0.1237,  0.1334,
         0.2809,  0.0660, -0.2932, -0.1700,  0.0692,  0.1564,  0.2257,  0.1722,
         0.2922,  0.1382,  0.0896, -0.0723, -0.0967, -0.1131, -0.0397,  0.1454,
         0.0515,  0.2385, -0.2375,  0.2085,  0.2463, -0.0311, -0.0817,  0.0660,
        -0.1539, -0.0108,  0.1203, -0.1073, -0.1993, -0.1923, -0.2983,  0.2792,
        -0.0309,  0.3012, -0.0275,  0.0547, -0.1685,  0.1217, -0.0311, -0.2816,
        -0.1240,  0.0151,  0.2479,  0.2557, -0.0266, -0.2155, -0.2981, -0.0728,
         0.2158,  0.2252, -0.0245,  0.0606, -0.1249,  0.0343,  0.2030,  0.1176,
         0.2016, -0.2167,  0.1062,  0.3157,  0.2631, -0.2756,  0.1661, -0.1768],
       device='cuda:0')
#### bounds_check_indices 1 ### current device =  1  indicies device = 1  offsets device =  1 rows_per_table device =  0

bounds_check_indices from
This torchrec change to transfer the tensor to right device makes the test pass
diff --git a/torchrec/modules/fused_embedding_modules.py b/torchrec/modules/fused_embedding_modules.pyindex 6fac21f..4ca18ec 100644--- a/torchrec/modules/fused_embedding_modules.py+++ b/torchrec/modules/fused_embedding_modules.py@@ -479,6 +479,12 @@ class FusedEmbeddingBagCollection(
             if self._is_weighted:
                 weights = torch.cat(weights)
+            # Debug print
+            for emb_cfg_name in self.embedding_bags:
+                print("current device = ", torch.cuda.current_device() , "FusedEmbeddingBagCollection ", emb_cfg_name, ".device = ", self.embedding_bags[emb_cfg_name].weight.get_device(), " emb_op.device= ", emb_op._emb_module.weights_dev.get_device() )
+             # Code fails without this transfer
+            emb_op.to( torch.cuda.current_device() )
              embeddings.append(
                 emb_op(
                     indicies.int(),

tests passing on rocm after this change:

test_dir
test

distributed
test_fused_embedding_bag_collection.py::FusedEmbeddingBagCollectionParallelTest::test_sharding_fused_ebc_module_replace

distributed
test_fused_embedding_collection.py::FusedEmbeddingBagCollectionParallelTest::test_sharding_fused_ebc_module_replace

distributed
test_model_parallel_hierarchical.py::ModelParallelHierarchicalTest::test_embedding_tower_collection_nccl

hi @bmedishe, thanks for looking into this! can you take a look at the linter errors and unit test failures?

hi @bmedishe, thanks for looking into this! can you take a look at the linter errors and unit test failures?
Hi @joshuadeng  , I just pulled in recent commits to this branch , I see this message "4 workflows awaiting approval" , could you kindly approve it , Thank you


Chapter-02: Docker disk resource limit & typo

I'm running the service with a MacBook Pro m2 and I get the following error if the Docker disk space setting is too small.

$ > kind load docker-image -n dev bitnami/kafka:3.4.1-debian-11-r0                                                                                 base
Image: "bitnami/kafka:3.4.1-debian-11-r0" with ID "sha256:30edbaed7de3..." not yet present on node "dev-control-plane", loading...
...
Command Output: Error response from daemon: write /var/lib/docker/.../layer.tar: no space left on device

After adjusting the disk settings, the issue can be resolved. Would it be helpful to include a note about this in the documentation?

The command kubect get pods contains a typo. kubect should be changed to kubectl.

If there are any similar typo errors in the future, may I submit a PR directly?

@zouyingjie thanks for reporting this, yes.. if you find typo issues please submit a PR

@salaboy  Of course, https://github.com/salaboy/platforms-on-k8s/pull/29


Write a Scala program to implement linear search

Description
Write a Scala program to implement linear search
Linear search is a very simple search algorithm. In this type of search, a sequential search is made over all items one by one. Every item is checked and if a match is found then that particular item is returned, otherwise the search continues till the end of the data collection.
Linear search is the simplest search algorithm. For this reason, it is often called sequential search.
Pseudocode
procedure linear_search (list, value)

   for each item in the list
      if match item == value
         return the item's location
      end if
   end for

end procedure

Example
list = [1,2,3,4,5]
value = 4

Output : 3

How to contribute

Comment !assign to assign this issue to yourself
Fork this repository
Create a new branch
Save the solution in program/program/implement-linear-search/implementLinearSearch.scala
Commit the changes
Create a pull request

!assign


Using /bin/sh to check for HardFP/SoftFP is unreliable

The /bin/sh binary may not even use any floating point instructions. So the check is unreliable and fails on Fedora 22 armhf, for instance. In turn, rpi-update will incorrectly use the SoftFP libraries.
Maybe it is more reliable to check against something that surely uses FP instructions, e.g. /lib/libm.so?

Does that definitely work for you? A PR would be useful.

It seems to work fine, I'm still testing something. PR incoming.

Okay, looks like checking e.g. libm basically works, but the location of the library depends on whether you have a multilib system or not. So it's not reliably to assume a fixed path for it.
The right way to check for hardfp seems to be readelf -h. It outputs something like
Flags:                             0x5000402, has entry point, Version5 EABI, hard-float ABI
But apparently that only works for newer versions of readelf, so I'm not sure it works on Raspbian. Maybe someone can check with readelf -h /bin/sh?

With Jessie raspbian:
readelf -h /bin/sh
ELF Header:
  Magic:   7f 45 4c 46 01 01 01 00 00 00 00 00 00 00 00 00
  Class:                             ELF32
  Data:                              2's complement, little endian
  Version:                           1 (current)
  OS/ABI:                            UNIX - System V
  ABI Version:                       0
  Type:                              DYN (Shared object file)
  Machine:                           ARM
  Version:                           0x1
  Entry point address:               0x3098
  Start of program headers:          52 (bytes into file)
  Start of section headers:          102968 (bytes into file)
  Flags:                             0x5000402, has entry point, Version5 EABI, hard-float ABI
  Size of this header:               52 (bytes)
  Size of program headers:           32 (bytes)
  Number of program headers:         9
  Size of section headers:           40 (bytes)
  Number of section headers:         28
  Section header string table index: 27

I just check on Wheezy Raspbian. It doesn't work there, what a bummer. But maybe it's possible to check both ways.

What does readelf output on Wheezy?
There is another answer here: http://raspberrypi.stackexchange.com/questions/4677/how-can-i-tell-if-i-am-using-the-hard-float-or-the-soft-float-version-of-debian

It's pretty much the same, just without the string "hard-float ABI". Supposedly the display of this was added somewhat recently. The answer in stackexchange is specific to Debian's multilib setup. It is not portable.
Maybe we can just add the readelf -h method to rpi-update in addition to the old method. What do you think?

Yes, trying both schemes and if either results in hard-float then assume hard-float (99% of users will be running hard-float anyway).
Or you could decode the bit field from flags yourself.

I forgot to reference this issue in the PR. This was fixed by PR #199.


Dependancy builds not caching

Hi all,
I'm trying to use cargo-chef to speed up my google cloud run build times. The first stage of my docker file is hitting the cache, but the stage the builds the dependencies isn't. Any help would be really appreciated!
FROM rust AS chef
RUN cargo install cargo-chef
WORKDIR app

FROM chef AS planner
COPY . .
RUN cargo chef prepare --recipe-path recipe.json

FROM chef AS builder
COPY --from=planner /app/recipe.json recipe.json
# Build dependencies - this is the caching Docker layer!
RUN cargo chef cook --release --recipe-path recipe.json
# Build application
COPY . .
RUN cargo build --release --bin app

# We do not need the Rust toolchain to run the binary!
FROM gcr.io/distroless/cc-debian11 AS runtime
WORKDIR app
COPY --from=builder /app/target/release/mail-ai /usr/local/app
ENTRYPOINT ["/usr/local/app"]

when I run gcloud config list
[builds]
kaniko_cache_ttl = 72
use_kaniko = True

gcloud build command:
gcloud builds submit --tag gcro.io/${PROJECT}/${CLOUDRUN_NAME}

It's impossible for me to help you with this little information. As far as I can see, the Dockerfile is using cargo-chef correctly.

I just had a similar problem, and it was because the CI system was "helpfully" caching the target dir, which meant that whatever cargo chef prepared was blown away and replaced upon the COPY or ADD command. I solved this by (a) not doing that, and (b) adding a .dockerignore file to the repo so it wouldn't happen locally too. Check if your CI is doing this.

I'm seeing a similar problem when trying to build sqld.
cargo build step runs from scratch, not using the builds generated by cargo chef cook.
Dockerfile for reference:
# install dependencies
FROM rust:slim-bullseye AS compiler
RUN apt update \
    && apt install -y libclang-dev clang \
        build-essential tcl protobuf-compiler file \
        libssl-dev pkg-config \
    && apt clean

RUN cargo install cargo-chef
WORKDIR /sqld

# prepare recipe
FROM compiler AS planner
COPY . .
RUN cargo chef prepare --recipe-path recipe.json

# build sqld
FROM compiler AS builder
COPY --from=planner sqld/recipe.json recipe.json
RUN cargo chef cook --release --recipe-path recipe.json
COPY . .
RUN cargo build -p sqld --release

# runtime
FROM debian:bullseye-slim
COPY --from=builder /sqld/target/release/sqld /bin/sqld
RUN adduser --system --home /var/lib/sqld --uid 666 sqld
RUN apt-get update && apt-get install -y ca-certificates
COPY docker-entrypoint.sh /usr/local/bin
ENTRYPOINT ["/usr/local/bin/docker-entrypoint.sh"]
VOLUME [ "/var/lib/sqld" ]
WORKDIR /var/lib/sqld
USER sqld
EXPOSE 5001 5432 8080
CMD ["/bin/sqld"]

I think I managed to track down what causes it.
If I run (outside of Docker):
cargo clean
cargo chef cook --release --recipe-path recipe.json
cargo build -p sqld --release

I can see that cargo build reuses the dependencies from cargo chef cook.
But, as warned, cargo chef cook changes a lot of my local files.
And if I do:
cargo clean
cargo chef cook --release --recipe-path recipe.json
git checkout .
cargo build -p sqld --release

Then cargo build will build from scratch.
The thing is that doing COPY . . after cargo chef cook has the same effect of git checkout ..
It removes the changes that cargo chef cook would have made to the code that is going to be built.
Is there a way to run cargo chef cook without changing the repository?
Any other way around this?
It may be the case that I'm just using it the wrong way.

I think you might be hitting https://github.com/LukeMathWalker/cargo-chef/issues/231
Try replacing:
FROM rust AS chef
RUN cargo install cargo-chef
WORKDIR app

with:
FROM rust AS chef
RUN cargo install cargo-chef
WORKDIR app
COPY rust-toolchain.toml rust-toolchain.toml

If it helps then it's https://github.com/LukeMathWalker/cargo-chef/issues/231
It solved the problem for me in sqld @athoscouto mentioned above. See https://github.com/libsql/sqld/pull/549 for more details.
FYI @frasermarch @klefevre

Closing this since #231 has been merged.


Prototyping validator signature & aggregation with Winternitz OTS

@unnawut any particular implementation to start?
(i assume we'd start with an existing one, or build one from scratch?)


fix: minor refactorings of packages and namings

Some minor refactorings and renamings for better clarity.

negating the Match function does not work, because all predicates need to match. For example:
filteredPoolList := filter.Match(poolList.Items,
  MatchesFlavor(r.Spec.Flavor),
  MatchesImage(r.Spec.ImageName),
  MatchesProvider(r.Spec.ProviderName),
  MatchesGitHubScope(r.Spec.GitHubScopeRef.Name, r.Spec.GitHubScopeRef.Kind),
)

with the initial implemenation, a pool item would be only added to the filtered list, if all predicates return true. Otherwise the item would be added if only one of the predicated matches, for example MatchesFlavour returns true, but MatchesImages returns false, the poolItem would still be added to to result list.
If the function is called like so
filteredPoolList := filter.Match(poolList.Items)

all of the items are returned, because there is no predicate provided to test/filter against.


Fluent validation (For) not working when MultiSelection="true"

Bug type
Component
Component name
MudSelect
What happened?
In code below For="Model.CoffeeRisks"  does not compile because it says it canot convert my Model Property (List) to the T type (string).
The selectedValues is of type IEnumerable
The For, when MultiSelection is set to true still expect a property of type T, but to work it would need to expect an IEnumerable.
<MudForm Model="@Model" Validation="Model.GetBeanValidator().ValidateBean">
    <MudGrid Justify="Justify.SpaceBetween">
        <GridTitleItem Id="coffeeRisks" Title="Coffee Production Risks" />
        <MudItem xs="12">
            <MudSelect For="@(()=>Model.CoffeeRisks)" MultiSelection="true" SelectedValues="Model.CoffeeRisks" SelectedValuesChanged="@((values) => OnCoffeeRisksSelected(values))" T="string" Label="Select Critical Coffee Risks"<EMAIL_ADDRESS>AnchorOrigin="Origin.BottomCenter">
                @foreach (string risk in _coffeeRisks)
                {
                    <MudSelectItem T="string" Value="@risk">@risk</MudSelectItem>
                }
            </MudSelect>
        </MudItem>
    </MudGrid>
</MudForm >

There is a discussion on this topic: https://github.com/MudBlazor/MudBlazor/discussions/4209#discussioncomment-8920721
This was discovered already by @PeterVD-Lansweeper,@alexchiraples, @hilljaycie14, there was a discussion but no bug filed.
Expected behavior
For , with MultiSelection, should expect an IEnumerable property.
Reproduction link
https://try.mudblazor.com/snippet/QYmGaRliHhhcayVE
Reproduction steps

Create a model containing a property of type: List. eg. public List TestProperty {get;set;}
Configure a MudSelect with MultiSelection=true
Add the For property: For="@(()=>Model.TestProperty)
Try to compile --> fails.
...

Relevant log output
No response
Version (bug)
6.19.0
Version (working)
No response
What browsers are you seeing the problem on?
Microsoft Edge
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

An easy workaround that I am using for the time being is to add a MudTextField just below my MudSelect with a 0 height.
<MudTextField @ref="_RiskIdentifiedError" Immediate="true" Disabled="true" Style="height:0px;width:0px" For="@(()=> Model.RisksIdentifieds)"></MudTextField>
Then in the SelectedValuesChanged of the MudSelect, I am calling _RiskIdentifiedError.Validate() so validation is reset as data is entered again in the object.
SelectedValuesChanged="@(_RiskIdentifiedError.Validate())"


assert cls.check_config_paths_exist(config)

File "/home/name/habitat-lab/habitat_baselines/rl/ppo/ppo_trainer.py", line 288, in train
self.config, get_env_class(self.config.ENV_NAME)
File "/home/name/habitat-lab/habitat_baselines/utils/env_utils.py", line 43, in construct_envs
scenes = dataset.get_scenes_to_load(config.TASK_CONFIG.DATASET)
File "/home/name/habitat-lab/habitat/datasets/pointnav/pointnav_dataset.py", line 43, in get_scenes_to_load
assert cls.check_config_paths_exist(config)
AssertionError
"You can follow the instructions here: https://github.com/facebookresearch/habitat-lab#data"
Sorry to bother you. I entered this link through the method you mentioned to learn, but I still haven't found a solution. Can you provide me with a more detailed introduction? I don't quite understand how to choose the path when configuring the environment. Looking forward to your reply, thank you very much. Sorry again for bothering you.

Hi,maybe you need choose the data about Point goal navigation.
First go to task datasets to download this data:https://github.com/facebookresearch/habitat-lab/blob/main/DATASETS.md.
Second choose the task "Point goal navigation	Gibson	pointnav_gibson_v1.zip	data/datasets/pointnav/gibson/v1/	datasets/pointnav/gibson.yaml	385 MB"in https://github.com/facebookresearch/habitat-lab/blob/main/DATASETS.md#task-datasets.
Third, unzip this dataset in the true data path,refer to "TopologicalSemanticGraphMemory/programs/habitat-lab-v21/data/datasets/pointnav".
Have a good day!

Hi,maybe you need choose the data about Point goal navigation. First go to task datasets to download this data:https://github.com/facebookresearch/habitat-lab/blob/main/DATASETS.md. Second choose the task "Point goal navigation Gibson pointnav_gibson_v1.zip data/datasets/pointnav/gibson/v1/ datasets/pointnav/gibson.yaml 385 MB"in https://github.com/facebookresearch/habitat-lab/blob/main/DATASETS.md#task-datasets. Third, unzip this dataset in the true data path,refer to "TopologicalSemanticGraphMemory/programs/habitat-lab-v21/data/datasets/pointnav". Have a good day!

hello,thank you very much for your reply. I will make corrections according to your method, but now I have encountered a new problem. Do you have time to help answer it? This is my first time using Ubuntu to configure the environment, and there are still many things I don't understand that I need to consult with you all.  Q:collected splits.tar.gz 1
Traceback (most recent call last):
File "collect_il_data.py", line 290, in
main()
File "collect_il_data.py", line 260, in main
if len(list_collected) < ep_per_env[cs]:
KeyError: 'splits.tar.gz'
I am deeply indebted to you for your help.

Well,I don't use the collect_il_data.py to generate this data now. I get the data from google cloud drive https://drive.google.com/drive/folders/1-8srO6kwxf_qxnIWdH6K7AToP_oxWEYg. You can get more information from README, best wish.

Well,I don't use the collect_il_data.py to generate this data now. I get the data from google cloud drive https://drive.google.com/drive/folders/1-8srO6kwxf_qxnIWdH6K7AToP_oxWEYg. You can get more information from README, best wish.

Thank you again, I followed your advice to get the data from Google cloud, but when I run the code according to the README：“python train_il.py --policy TSGMPolicy --config configs/TSGM.yaml --version exp_name --data-dir IL_data/gibson --prebuild-path IL_data/gibson_graph”, https://github.com/rllab-snu/TopologicalSemanticGraphMemory/tree/master. I still have some problems, how do you check all your paths? I feel a bit confused, for the path piece, can you teach me how you set up your paths?I'm very sorry for taking up your time, and thank you very much for taking the time to reply!    Q：python train_il.py --policy TSGMPolicy --config configs/TSGM.yaml --version exp_name --data-dir IL_data/gibson --prebuild-path IL_data/gibson_graph
/home/cn/anaconda3/envs/tsgm/lib/python3.7/site-packages/sklearn/base.py:338: UserWarning: Trying to unpickle estimator GaussianMixture from version 0.22.2.post1 when using version 1.0.2. This might lead to breaking code or invalid results. Use at your own risk. For more info please refer to:
https://scikit-learn.org/stable/modules/model_persistence.html#security-maintainability-limitations
UserWarning,
Dataset Name:  gibson
POLICY : TSGMPolicy
Image Graph Threshold:  0.75
Object Graph Threshold:  0.8
Traceback (most recent call last):
File "train_il.py", line 269, in
train()
File "train_il.py", line 138, in train
valid_dataloader = DataLoader(valid_dataset, **valid_params)
File "/home/cn/anaconda3/envs/tsgm/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 268, in init
sampler = RandomSampler(dataset, generator=generator)
File "/home/cn/anaconda3/envs/tsgm/lib/python3.7/site-packages/torch/utils/data/sampler.py", line 103, in init
"value, but got num_samples={}".format(self.num_samples))
ValueError: num_samples should be a positive integer value, but got num_samples=0


Allow SEI layers choice

Description
Currently, the default for SEI is one inner and one outer layer.
Continuing the work of #3457, this change is to include an option to have a single layer SEI model, rather than just the 2-layer version.
Closes #2333
Type of change

[X] New feature (non-breaking change which adds functionality)

Key checklist:

[X] No style issues: $ pre-commit run (or $ nox -s pre-commit)
[X] All tests pass: $ python run-tests.py --all (or $ nox -s tests)
[X] The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

@lorenzofavaro This was being worked on by another person. Did you ask @GBlanka if they were still working on it? In general you don't want to take over the work of another developer unless they were not interested in continuing

@lorenzofavaro This was being worked on by another person. Did you ask @GBlanka if they were still working on it? In general you don't want to take over the work of another developer unless they were not interested in continuing

You're right, I forgot to write it down but I asked her about it on another platform (on Github it is no longer active) and she confirmed that she was no longer interested in working on the PR #3457.

I'm wondering whether it would be cleaner to have entirely separate classes for double-layer or single-layer SEIs. There are a lot of if statements now in sei_growth.py

@tinosulzer Could we think of adding two classes SingleLayer and DoubleLayer in this way?

After that, update the function set_six_submodel in the base_lithium_ion_model module, so that it handles the correct initialization of the submodel, based on the double SEI layer option.

NoSEI and ConstantSEI should only have the single-SEI case (as it's pointless to model a double-layer SEI if it's not there or constant). TotalSEI is an aggregator anyway so that should deal with both single and double cases. That only leaves SEIGrowth and DoubleLayerSEIGrowth. In fact we may want to put the "double" option inside the SEI option e.g. "solvent-diffusion limited" and "solvent-diffusion limited (double-layer)"
Btw, thanks for your work on this and sorry for changing the specs along the way, it just became clearer when thinking about it more

The other (simpler) option is to just get rid of double layer SEI, which is just confusing and hard to parameterize. Thoughts @rtimms @brosaplanella @DrSOKane ?

I would happily remove the double layer stuff. If people really really want it they can implement as a custom submodel or basic model.

There's pros and cons to separating into different classes. I think a good middle ground is to have different submodel classes when the variables in submodel.rhs or submodels.algebraic change, and use if statements if we keep the same general structure but only vary the form of the equations. So in this case, keep it all in one submodel class

@lorenzofavaro the conclusion is let's just go ahead and get rid of the double SEI entirely. It should make the changes much cleaner

Hi @lorenzofavaro! Any updates on this?

Hi @lorenzofavaro! Any updates on this? Otherwise we can take this over as we need this feature for some work we are doing with @kawaMANMI.


Add time shifting function

Add a new function to shift date easily.

Hello,
Looks good to me (see my comments), very good idea !
Thanks

Thanks for the changes. Looks good to me for commit.

I took into account all yours feedbacks, so please can you review new commits ?
I add a new library ( hamcrest-date ) to easily check date.

You might want to look at Duration#parse(CharSequence).

I found the format more complex and you can't add month.
But it's more java native like my implementation.
What do you prefer ?

Hello,
Regarding format, for maintainability and documentation, using Java8 Duration is better IMO.
Regards

Close with commit r1794517 : http://svn.apache.org/viewvc?rev=1794517&view=rev


[Question] What to add to a Jenkins Docker file to execute a Playwright test using Maven

I am trying to execute a Playwright test (Java) in a dockerized Jenkins job.
This is my Dockerfile (from the Jenkins site)
FROM jenkins/jenkins:2.319.1-jdk11
USER root
RUN apt-get update && apt-get install -y lsb-release

RUN curl -fsSLo /usr/share/keyrings/docker-archive-keyring.asc \
  https://download.docker.com/linux/debian/gpg
RUN echo "deb [arch=$(dpkg --print-architecture) \
  signed-by=/usr/share/keyrings/docker-archive-keyring.asc] \
  https://download.docker.com/linux/debian \
  $(lsb_release -cs) stable" > /etc/apt/sources.list.d/docker.list
RUN apt-get update && apt-get install -y docker-ce-cli
USER jenkins

RUN jenkins-plugin-cli --plugins "blueocean:1.25.2 docker-workflow:1.26"

When I executed the job I got this
Host system is missing a few dependencies to run browsers.
Please install them with the following command:                                                                                sudo mvn exec:java -e -Dexec.mainClass=com.microsoft.playwright.CLI -Dexec.args="install-deps"
<3 Playwright Team

Inside the Docker image, I tried to execute the command but at some point, I got this:
Note, selecting 'libfontconfig1' instead of 'libfontconfig'
Package ttf-ubuntu-font-family is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

Package libjpeg-turbo8 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'ttf-ubuntu-font-family' has no installation candidate
E: Unable to locate package libenchant1c2a
E: Unable to locate package libicu66
E: Package 'libjpeg-turbo8' has no installation candidate

To run the test I am using Maven
Am I missing something?

The browsers that come with playwright require native dependencies. You can use playwright docker image which has all those dependencies preinstalled or run the command line that you see printed to the terminal inside the docker to install the browsers along with the required dependencies.


should EMA consider time window?

Hi, I see the implementation of EMA does not consider the time window, is it correct?
https://github.com/sdcoffey/techan/blob/572c478f546ecfef27a8454bd653f95829269490/indicator_exponential_moving_average.go#L24-L37
Also, is RSI correct since RSI relays on EMA?

I think it's incorrect, window is not used anywhere in the calculation.

Fixed as of 0.12.1! Shoutout to @danhenke and @joelnordell for the fix


default_hp_metric should be False or better explained in the docs

🚀 Feature
Add more docs to default_hp_metric in TensorBoardLogger.  If this is used as default, all logging of hyper parameters with data is completely ignored - such as self.logger.log_hyperparameters() or self.logger.experiment.log_hparams()
Also, without this, the only way to even see any hyperparameters in the hparams tab is to use self.save_hyperparameters.
This is not very clearly explained in the TensorBoardLogger docs, but is in a note in the Logging page. Would be nice to have better documentation of the requirements - or even fail if the user tries to do this instead of getting a blank tab.  Ideally, I would say that this should not be the default or somehow enable both to occur.  Not being able to call log_hparams directly with the writer without another option is non-ideal, especially when converting to lightning from general pytorch.
Motivation
Lack of documentation, odd behavior for a general, broadly-used tensor board feature, no clear failure, and no clear way to proceed through code errors.
Pitch

Better documentation in the TensorBoardLogger.
clear failure when trying to log_hyperparameters
Ideally, change the default behavior to be what is expected for tensorboard users.

Alternatives

Use the default hp metric at the end of train/test if nothing else is given.

Hey @jadolfbr
Thanks for the issue, you're right!
Would you mind opening a PR with your suggested changes for the docs)?

Will do!  I’m not familiar with the doc organization.  Where should I make the changes for a PR? Do you do a fork model for PRs?  Thanks!

The easiest could be to add that to the respecitve logger docstrings. Otherwise you should find everything at /docs/source/common/loggers.rst
Yes, you have to fork the repo to create a PR :)

Hi @jadolfbr, you could refer to these Contributing guidelines for submitting a PR!

Thanks guys!


Plugging In Seed Not Working

My wife and I wanna race the randomizer for Ages, but whenever we want to use a specific seed to do so to make it fair, it still pulls up a random seed and uses that instead. :c

Looks like this broke in 4.1 because of some multiworld-related restructuring (the -seed flag still works, but the interactive prompt doesn't). As a workaround I suggest just generating one ROM and sharing that, if possible.

Fixed in 4.1.2.


Handles ctrl+S in monaco editor and displays a snackbar.

Hey there,
Now a snackbar with message 'Saved' is displayed instead of Save Page dialog box when Ctrl+S is pressed.
The snackbar implemented is MatSnackBar from angular/material package

Hey @kirjs , I addressed the issues in the new commit. Let me know if there are any more issues.

🔥
The code looks good, please sync and format (npm run format:write) and we can submit

@NothingEverHappens  Did another commit with everything Synced and addressed the requested changes.

Amazing, thanks a lot @jatinAroraGit !


add uniqueid attribute for ldap-based auth login

rancher/rancher#13434

Closing as we are rethinking the approach; will either reopen or recreate a new PR once the approach is finalized