Fix the kafka consumer configuration override bug.

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[x] Update the CHANGES log.

When I try the configuration below to set different consumer group for oap server, it doesn't work.
Still the default group in the program.
kafka-fetcher:
  selector: ${SW_KAFKA_FETCHER:default}
  default:
    bootstrapServers: ${SW_KAFKA_FETCHER_SERVERS:<IP_ADDRESS>:9092}
    ......
    kafkaConsumerConfig:
      enable.auto.commit: true
      group.id: test-group-mysql

The reason is that there is an order problem when setting in the code:
properties = new Properties();
properties.putAll(config.getKafkaConsumerConfig());
properties.setProperty(ConsumerConfig.GROUP_ID_CONFIG, config.getGroupId());
properties.setProperty(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG, config.getBootstrapServers());

I don't know if this is by design or a mistake in itself.
Please confirm.

In fact, it totally is not a bug. To simplify configuration, we prefect users to configure as follows:
kafka-fetcher:
  selector: ${SW_KAFKA_FETCHER:default}
  default:
    bootstrapServers: ${SW_KAFKA_FETCHER_SERVERS:<IP_ADDRESS>:9092}
    groupId: ${SW_KAFKA_FETCHER_GROUP_ID: skywalking}

Not to configure kafkaConsumerConfig, this is for advance configure.

@dmsolr I checked the codes, it seems we really provide this kafkaConsumerConfig. Once we did, I think the changed behavior is at least more sensible.

make sense.
Yes, users can configure BOOTSTRAP_SERVERS_CONFIG and GROUP_ID_CONFIG  by KafkaFetchConfig(base) and KafkaConsumerConfig(advance).

Yes, once they could be override, make kafkaConsumerConfig to override single configuration key seems a better pratice.


Revert simplelink host driver

It was noticed that a subset of the SimpleLink SDK import (the host driver) had a more restrictive license then the rest of the SDK.
As a result, the host driver import commit plus any commits based on it are being reverted, until either an alternative licensing is available, or a different method is devised for using the cc32xx WiFi driver in an open source context.

lets revert this ASAP, want to avoid taggin rc1 with this driver.

Agreed, once it passes CI will look to merge it.


Fix CSVLoader to use specified parameter when estimating number of columns

CSVLoader has a feature to automatically assign field names for each column ([c1, c2, c3, ...]) based on the number of columns in the first row of the CSV file.  However, specified constructor options (*args and **kwargs, in which users may specify delimiter, dialect, etc.) are not used when counting number of columns.  This PR fixes the problem.

Coverage decreased (-0.8%) to 92.883% when pulling dfc7edc3a9340a5d517a44fa0eddde9ff1b88296 on fix-csv-params into a55d5843a64bf78950af93c862aa3990d0c8deba on develop.

Coverage decreased (-0.2%) to 93.537% when pulling a90d575d0ca2a291c55f9f6c6cc987fa51492cab on fix-csv-params into 51215678db216fbff30337e0618763ffa65a332a on develop.

In Python 2.7,  fieldnames=False does not work when using non-ascii file.
My test is the followings:
  def test_noheader_non_ascii(self):
    with TempFile() as f:
      f.write("いち|に|さん\n1|2|3\n".encode('utf-8'))
      f.flush()
      loader = CSVLoader(f.name, fieldnames=False, encoding='utf-8', delimiter='|')

Error Messages:
Traceback (most recent call last):
  File "/home/rimms/jubakit/jubakit/test/loader/test_csv.py", line 62, in test_noheader_non_ascii
    loader = CSVLoader(f.name, fieldnames=False, encoding='utf-8', delimiter='|')
  File "/home/rimms/jubakit/jubakit/loader/csv.py", line 55, in __init__
    fieldnames = ['c{0}'.format(i) for i in range(len(r.fieldnames))]
  File "/home/rimms/.pyenv/versions/2.7.9/lib/python2.7/csv.py", line 90, in fieldnames
    self._fieldnames = self.reader.next()
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-1: ordinal not in range(128)

In Python 3.5, this patch works fine.

@rimms Thank you for review.
The root cause of the original issue was that we used different mechanism to (1) detect number of columns and (2) actually load the data.
I fixed this issue by extracting csv-related things into _UnicodeDictReader class, so now  (1) and (2) share the same code.
I also added several tests against CP932 files.

Coverage decreased (-0.07%) to 93.649% when pulling<PHONE_NUMBER>96e1471bdb4226ec5da525690ef3d6 on fix-csv-params into 51215678db216fbff30337e0618763ffa65a332a on develop.

Coverage decreased (-0.1%) to 93.649% when pulling 807a3a833014097b264df374f4221f73574cdc10 on fix-csv-params into 0d2f483f213410b861ac0a301a4d9d442f56aa41 on develop.

👍 LGTM


PPPoE "keepalive"'s arguments look reversed

OpenWRT's documentation specifies:

First number is for “seconds between each ping” (ppp's lcp-echo-interval option). Second number is “we assume the connection is down after this number of pings failed” (ppp's lcp-echo-failure option).

However, LuCI loads and saves these arguments in reversed order:
config interface 'wan'
        option proto 'pppoe'
        option keepalive '60 5'
        [...]

LuCI Master (git-20.289.33737-a2c7457) / OpenWrt SNAPSHOT r14706-5666ca913a (2020-10-16)

The documentation is wrong in this case. LuCI's implementation matches the PPP protocol handler:
https://github.com/openwrt/openwrt/blob/master/package/network/services/ppp/files/ppp.sh#L128
Quick test:
root@OpenWrt:~# keepalive="60 5"; echo lcp_failure=${keepalive%%[, ]*}; echo lcp_interval=${keepalive##*[, ]}
lcp_failure=60
lcp_interval=5
root@OpenWrt:~#

I updated the wrong documentation in the wiki.

Thanks for the clarification and update!
I was a bit confused because in my case setting interval = 5 and failure = 60 causes the line to randomly disconnect in a few minutes (while 5 is a common value for interval as per my knowledge), but setting them in reverse solved my issue.


Polling Error

Polling data from Taxii Server (OpenTaxii) using cabby is unsuccessful. I did validate the STIX files and they were pushed to the inbox successfully. Even then I get these two errors while polling :
1.

Need help solving this issue

@Mukesh0424 also, please make sure your webserver is not cutting long TAXII response short because of size limitations.

@arcsector,  @traut  ... It is working fine now.. Thank you so much for your inputs.


Azure Key Vault Trait: Support Azure Identity as authentication method

Requirement
This is a request coming from:https://camel.zulipchat.com/#narrow/stream/257299-camel-k/topic/Azure.20KeyVault.20Authentication.20Using.20Managed.20Identity
Problem
At this stage we are not supporting the Managed Identity, this means we are not supporting the DefaultAzureCredential chain: https://learn.microsoft.com/en-us/java/api/overview/azure/identity-readme?view=azure-java-stable#defaultazurecredential
Proposal
Through CAMEL-20220 I added the support for this, but it will be in 4.4.0, so this feature request is a placeholder for the moment when 4.4.0 will be released and camel-k will switch.
Open questions
No response

We are about to release Camel 4.4.0, so I guess I can start to add the support for this in the trait.

Completed by #5244


[Core]: Support BitBucket Or any host

For now only gitlab & github are supported.
To be usable i need to at least manualy deploy from any git host or bitbucket.
Maybe like clevercloud or vercel we can deploy to a git remote ?
Thank you for your work ! 💪

that would be also very important for us. Is there any timeline?

To be able to deploy from any git source is simple to add.
Adding a fully integrated Bitbucket (or any) git provider is a bit harder (webhooks, etc.).
Which one of these is important for you, @btalin ?

Subissue: https://github.com/coollabsio/coolify/issues/1233

Is it possible to achieve like caprover CLI? https://caprover.com/docs/deployment-methods.html
Which actually works like Heroku.

Is it possible to achieve like caprover CLI? https://caprover.com/docs/deployment-methods.html Which actually works like Heroku.

Yes, I will soon start working on Coolify's CLI.

You can now deploy from any git provider, public or private (with ssh-key) repositories.


Article post

Article posters for all pages,
sidebars will be a separate component due to different structure.

what are the travis errors mean? Where and how to fix? Couldn't even find the problem files...


Error [ Condition "p_elem->_root" is true. ] spamming the console

Tested versions
v4.3.stable.official [77dcf97d8]
System information
Mac Mini M1 with newest MacOS
Issue description
I have a very simple script attached to a TileLayer Node. As soon as it gets triggered, it spams the console with
Condition "p_elem->_root" is true.
errors. The weird part is that if I add (as built in) or attach (as a gdscript file) the same script to another TileLayer node, it works fine. The project is so simple that I can't see what could be causing it and was unable to isolate it.
Steps to reproduce
This is the script that's causing the errors:
extends TileMapLayer

# metadata container
#@export var data : Node

# metadata array names that hold the relevant data
#@export var slide_tiles : String # LayerTransformPlayer
#@export var slide_phase : String # LayerTransformPlayerTimer

#const Tile_Size = 100

@warning_ignore("unused_parameter")
func _use_tile_data_runtime_update( C : Vector2i ): return true # Coordinates, Vector2i

@warning_ignore("unused_parameter")
func _process ( delta ) : notify_runtime_tile_data_update()

@warning_ignore("unused_parameter")
func _tile_data_runtime_update ( C: Vector2i, TD: TileData):
	pass

As it can be seen it does nothing (I commented out and deleted everything). From my testing it looks like just using "_tile_data_runtime_update" makes it go bad.
Minimal reproduction project (MRP)
Unfortunately I can't retrigger it outside of my own project (which is a super simple test project with barely a few nodes in it). The problem is that the script works fine on other TileLayer nodes. There's nothing special about the Node that can't handle this script. I'm not using any terrains, physics, pathfinding, nothing. It's just a super simple TileLayer.

Forgot to confirm, when I fill in the actual code that I use (so the script actually does some stuff with tiles), it all works just fine even with this problematic Node… but it still floods the console with errors.

While it probably shouldn't spam a lot of errors this code is far from actually useful or realistic code, so it isn't something the class can necessarily reasonably be expected to behave well with, but should probably communicate this better

Not sure if that's what you meant, but just to confirm in my project I am making sure to update only the tiles that need updating. I just cut all checks out for the sake of example because there seems to be no difference with or without it, ie the script works on one TileMapLayer but not another.
The TileMapLayers in my case are three TileMapLayers each 10 by 10 tiles all using the same TileSet, if that matters. Just for a test I turned off all checks (so the script updates everything all the time), added more tiles to each TileMapLayer and it still worked without any performance issues that I was able to detect.
Other than that, is there something else I can do to update my tiles / what would be "useful" or "realistic" code?

The code you gave isn't useful code, but if it's triggered by more useful code that doesn't just force reloading every frame and updates everything
Please provide an example that causes the issues and is representative of your use, because the code you showed isn't what anyone should or would use, but if it's happen when not doing updates every single frame without being needed that's more critical
But in the end it's not easy to test without some concrete examples so please try making an MRP

Here's an example from my project:
class_name TileMapHandler
extends TileMapLayer

var modulated_cells: Dictionary;

func _tile_data_runtime_update(coords: Vector2i, tile_data: TileData) -> void:
    tile_data.modulate = modulated_cells.get(coords, Color.MAGENTA)

func _use_tile_data_runtime_update(coords: Vector2i) -> bool:
    return modulated_cells.has(coords)

func color_tile(color: Color, coords: Vector2i):
    modulated_cells[coords] = color
    notify_runtime_tile_data_update()

color_tile is called every frame due to the high amount of changes happening all over the place. Same behavior as observed by the OP.
To reproduce, attach the script to a tile map layer and create a second script that calls color_tile with random inputs every frame. Happens on v4.3 official, both Linux and Windows.
@AThousandShips

@Calandiel Please upload an MRP

In here: as it won't ever stop updating are you saying you expect this to enter an infinite loop and get stuck? It only seems to attempt to modify the data for tiles that already had the data set before.
The behavior is the same regardless of whether modulated_cells are erased or not - seems tangential to the matter at hand (and if it wasn't, then docs ought to be updated to be more explicit about it).
I'm not in a position to upload a MRP in the immediate future. I'll look into it if I get a chance later.

No I'm saying it will keep updating that tile, because you never clear out the check, so it's the same as if you'd just do:
func _use_tile_data_runtime_update(coords: Vector2i) -> bool:
    return true

I'm just saying that your code doesn't seem right either and would be expected to not perform well, but if you can upload an MRP soon that'd help, but otherwise there's nothing we can do, and unless you or the OP uploads one this will be closed

My understanding is that both of us aren't reporting it to not perform well, we are reporting it to flood the console with error messages. That's quite different and (imho) not expected regardless of how frequently the method is called.
I think you're getting lost on the details.
I can probably supply a MRP at some point in the future but not in the immediate future - I have other responsibilities besides Godot. If the issue is closed by then, I'll make a new one once I have a project at hand, assuming I still encounter this issue.

I think you are misunderstanding what I'm doing, I'm trying to pin down what's wrong, I never said the error was good, but trying to:

Establish the conditions under which this happens
Figure out if it happens under "proper" use or only under "improper" use where it is overworked because of repeated updates

These details are very important to establish what is going on, and how to approach this
So if you or anyone else can provide an MRP that would speed this along and once one is made I will test this and try to solve this!

Thank you for clarifying - you're right, I misinterpreted your intentions. That makes a lot more sense.
I will do my best to provide a MRP but the most likely time for that to happen is next weekend.

@AThousandShips I ran into the same issue that was mentioned here and created a small mrp
godot-mrp.zip
In my mrp the issue seems to occur if you call set_cell on a TileMapLayer before calling notify_runtime_tile_data_update() on the same layer. It seems to be important that the actual tile texture has to change which is why I added an alternative tile in the tileset. To get the error message in the debugger you have to just move your mouse over some tiles on the screen.

Will give this a test tomorrow! Thank you for providing an MRP

Also, I just figured out a workaround that works in my project and the MRP. If instead of doing:
# tile_map_layer.gd
notify_runtime_tile_data_update()

you do:
# tile_map_layer.gd
call_deferred("notify_runtime_tile_data_update")

then the update to the tiledata still happens as expected but you don't get the error message in the debugger which makes this seem like some sort of race condition maybe?

Hey, wanted to add another code that is throwing this exact same error.
extends TileMapLayer
class_name UpdateTileMapLayer

var _update_fn: Dictionary = {}

func update_tile(coords: Vector2i, fn: Callable) -> void:
	_update_fn[coords] = fn
	# Used deferred to supress errors
	call_deferred("notify_runtime_tile_data_update")

func _use_tile_data_runtime_update(coords: Vector2i) -> bool:
	if !_update_fn.has(coords):
		return false
	return true

func _tile_data_runtime_update(coords: Vector2i, tile_data: TileData) -> void:
	if !_update_fn.has(coords):
		return

	var fn: Callable = _update_fn[coords]
	fn.call(tile_data)
	_update_fn.erase(coords)

This is the same code running on my project. Without the deferred hitting over 400 errors at startup.


STRIKE THROUGH Not working

This commit seems to be implementing strike through feature. but it does not work
Code to reproduce
const fs = require('fs');
const HTMLtoDOCX = require('html-to-docx');
const filePath = './example.docx';

const htmlString = `<!DOCTYPE html>
<html lang="en">
    <head>
        <meta charset="UTF-8" />
        <title>Document</title>
    </head>
    <body>
        <s>STRIKE</s>
        <del>STRIKE</del>
    </body>
</html>`;

(async () => {
  const fileBuffer = await HTMLtoDOCX(htmlString, null, {
    table: { row: { cantSplit: true } },
    footer: true,
    pageNumber: true,
  });

  fs.writeFile(filePath, fileBuffer, (error) => {
    if (error) {
      console.log('Docx file creation failed');
      return;
    }
    console.log('Docx file created successfully');
  });
})();

example.docx
output DOCX:

Hello @privateOmega . I have fix for this one(small change). If you want I can create a PR 😇

Same problem, please accept PR from @satyajitnayk


nvidia-x11: 450.66 -> 455.38 [20.09]

Motivation for this change
nvidia-x11 versions 450.31 through 455.28 contain a serious performance regression that make my system nearly unusable. This is fixed in 455.38; the relevant changelog entry is "Fixed a performance regression in the NVIDIA X driver which affected some X11 RENDER extension use cases". I'd appreciate seeing this backported to 20.09, given that (absent #99323) it's very difficult to use a custom version of nvidia-x11 without completely forking nixpkgs.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

cc @baracoder

cc @NixOS/backports

Thanks for this backport, I had also been having issues (though, stability rather than performance) with the most recent 20.09 nvidia driver.


Citation String Empty

In GitLab by @MSKirk on Apr 5, 2023, 13:02
The citation string is empty for AIA py which is unexpected.
>>>aiapy.__citation__
''

Expected performance:
>>> aiapy.__citation__

@ARTICLE{2020JOSS....5.2801B,
       author = {{Barnes}, Will and {Cheung}, Mark and {Bobra}, Monica and {Boerner}, Paul and {Chintzoglou}, Georgios and {Leonard}, Drew and {Mumford}, Stuart and {Padmanabhan}, Nicholas and {Shih}, Albert and {Shirman}, Nina and {Stansby}, David and {Wright}, Paul},
        title = "{aiapy: A Python Package for Analyzing Solar EUV Image Data from AIA}",
      journal = {The Journal of Open Source Software},
     keywords = {Python, Astronomy, Solar Physics},
         year = 2020,
        month = nov,
       volume = {5},
       number = {55},
          eid = {2801},
        pages = {2801},
          doi = {10.21105/joss.02801},
       adsurl = {https://ui.adsabs.harvard.edu/abs/2020JOSS....5.2801B},
      adsnote = {Provided by the SAO/NASA Astrophysics Data System}
}

Relevant System Information:
Python 3.10.10
IPython 8.2.0
Sunpy 4.1.4
AIAPy 0.7.2.post1

Thanks for the report, I will fix this.

mentioned in commit cd94874051807f358ed5e32708c1ce3be1d3f4e1

mentioned in commit b7a6a9325a9c912efcd6bef14e71ae30c82ac373


shared: add WebsocketExecMirror()

This function specifically deals with shoveling data from an interactive lxc
exec session. It allows to detect background processes. The idea is to detect
when the attached child has exited. We can assume it has only exited after it
was able to write everything it wanted to write into the tty buffer. That means
at maximum output the size of one tty buffer still belongs to the attached
child. Everything afterwards belongs to another (background) process. So we dump
65536 bytes at maximum and then exit.

Not satisfied!


Fix group add and refactor

My plan for separating ParseXConfig from ParseXConfigLocal is that the former should make testing easier, since it takes in a reader instead of relying on disk paths to be correct.


nested asymetricSsr

Not sure if this is a real bug as it doesn't make a lot of sense to nest asymetricSsr components below each other. Anyways I tried to and it caused some errors as the nested component may get unmounted before requestAnimationFrame is fired which results in :
Warning: setState(...): Can only update a mounted or mounting component. This usually means you called setState() on an unmounted component. This is a no-op. Please check the code for the _class component.

componentDidMount() {
      requestAnimationFrame(() =>
        // component may be already unmounted now
        this.setState({ mounted: true }),
      );
    }

Indeed, nesting asymetricSsr is really not a good idea. I don't see how we could introspect the provided component and warn the user about his mistake. Event if it was feasible, a complex hierarchy of components couldn't be analyzed without deep and costly analysis. And I'm not even touching composition...
Well, nothing to be done here, but thanks for the info.

Actually I also have this problem even with no nested asymetricSsr :/


Store external request IDs in history events

What changed?
Store external request IDs in history events

Why?
This is a pre-step to implement idempotency check of Cadence external API

How did you test it?
unit tests

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 018e7871-15a1-494b-8525-62b6dcd74d5e
Details

33 of 33 (100.0%)  changed or added relevant lines in 9 files are covered.
85 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-0.02%) to 65.211%

Files with Coverage Reduction
New Missed Lines
%

service/history/queue/timer_queue_processor_base.go
1
77.62%

service/history/task/transfer_standby_task_executor.go
2
87.01%

common/task/weighted_round_robin_task_scheduler.go
2
88.56%

common/persistence/sql/sqlplugin/postgres/task.go
2
73.4%

common/persistence/sql/sqlplugin/postgres/db.go
2
80.0%

common/task/fifo_task_scheduler.go
2
87.63%

service/matching/taskListManager.go
2
80.46%

common/persistence/historyManager.go
2
66.67%

service/history/task/fetcher.go
3
85.57%

common/persistence/nosql/nosqlplugin/cassandra/tasks.go
4
76.09%

Totals

Change from base Build 018e77b5-9d12-41e2-8f94-99b7ce572ebe:
-0.02%

Covered Lines:
95314

Relevant Lines:
146162

💛  - Coveralls


Generate cryptographically secure states

modify constructor to take N collaborators
use ircmaxell/random-lib for state generation
update tests

Fixes #212

cc @SammyK

@ramsey I think there are no further concerns... this should be ready to go.

Thanks!


Warn-only with comments typeshed_primer

The goal of this PR is to allow typeshed to not ignore NQA102.
It does so by making the typeshed_primer job non-blocking (meaning it won't fail even if Flake8 errors are raised), and instead add a comment to the PR to show if the PR would produce any Flake8 error in typeshed.
This way, typeshed doesn't need to pre-emptively ignore new errors for flake8-pyi CI to pass.
This is heavily based on https://github.com/python/typeshed/blob/main/.github/workflows/mypy_primer_comment.yml , but simplified a bit and I extracted the JS scripts for better readability.
(CC: @AlexWaygood )
Note: .github/workflows/check.yml contains extra auto-formatting changes. I don't think they make the PR harder to review (especially if you hide whitespace changes), but I can always revert and/or split it off.

Proof of work: https://github.com/Avasam/flake8-pyi/pull/2

I'll take a proper look tomorrow, but from a cursory look, this looks fantastic. Thanks for working on this!

Note: .github/workflows/check.yml contains extra auto-formatting changes. I don't think they make the PR harder to review (especially if you hide whitespace changes), but I can always revert and/or split it off.

...I hate to be a pain, but could you possibly revert these? I agree that they don't make it significantly harder to review the PR, but it'll make for a somewhat confusing git history if various unrelated stylistic and formatting changes were made as part of this PR. It's nice to keep git blame clean wherever possible :)

This looks great to me.

Yeah, that's why in the demo I gave I have to add it to the master branch and create a PR to it to trigger.

@hauntsaninja or @JelleZijlstra, are either of you available to take a quick look before I merge?

Skimmed, I don't see any diffing logic, so this will show errors from any previously merged PRs as well.

Skimmed, I don't see any diffing logic, so this will show errors from any previously merged PRs as well.

Oh, good point. @Avasam, would you be okay with adding some diffing logic? We could probably just do something like this:

Check out flake8-pyi master, cd into typeshed, flake8 typeshed, save the results to a file
Check out the PR branch, cd into typeshed, flake8 typeshed, save the results to a file
Get the diff between the two runs using either diff or git diff --no-index, save it to a file
Upload the diff and post the comment in the same way you're already doing

I didn't add any diffing logic because the original typeshed_primer didn't. But I can see a need when adding a new check or fixing false negatives, and making another PR (or updating an old one) before typeshed has time to fix or ignore the new errors.

I didn't add any diffing logic because the original typeshed_primer didn't.

Yeah — the existing code doesn't have any diffing logic because it's pretty unlikely there'll be any typeshed_primer errors on flake8-pyi's master branch if typeshed_primer is a blocking check. But once it becomes a non-blocking check, that changes — previous PRs could have produced typeshed_primer errors that, for whatever reason, we decided we'd probably want to # noqa rather than fix.

I think I know what's going wrong, mind if I push to your branch?

I think I know what's going wrong, mind if I push to your branch?

Sorry if this gives you notifications >.<
Just had to trial and error and learn that run step always refreshes the current working directory, I need to checkout into a different folder, fix typos, etc.
Should be good now

I think I know what's going wrong, mind if I push to your branch?

Sorry if this gives you notifications >.< Just had to trial and error and learn that run step always refreshes the current working directory, I need to checkout into a different folder, fix typos, etc.
Should be good now

Heh, no worries, sorry for being slightly overbearing!

@AlexWaygood No problem, I appreciate the eagerness to help. Speaking of which, this is stumping me a bit, the diff command exits with an error code of 1 on the CI with no message. I don't think its because of missing files (locally that just resulted in an empty diff).
https://github.com/Avasam/flake8-pyi/actions/runs/3801702221/jobs/6466455790
If fact it works correctly when both old and new produce no Flake8 error.

Alright. Sorry for the mess of commits. But this should be good now. New look:
https://github.com/Avasam/flake8-pyi/pull/2#issuecomment-1367442380

Also just referencing this here since we could use it instead of a custom script if the enhancement is ever added: https://github.com/actions/download-artifact/issues/172

Looks great! I just pushed two commits to your branch to fix some readability nits I had -- everything still look good to you?
@hauntsaninja, how's this look to you now?

Looks great! I just pushed two commits to your branch to fix some readability nits I had -- everything still look good to you?
@hauntsaninja, how's this look to you now?

One small detail:
- name: Checkout flake8-pyi master
    uses: actions/checkout@v3
    with:
      ref: ${{ github.base_ref }}

Here the target branch is what I checkout, not necessarily master.

The diff for the first garbage PR was pretty good:
https://github.com/AlexWaygood/flake8-pyi/pull/1

The diff for the second garbage PR is okay, but could be better. It's got a different look to it, because of the fact that there are already flake8 errors on the master branch of my fork after I merged the first garbage PR:
https://github.com/AlexWaygood/flake8-pyi/pull/2

It would be nice if we could filter out all lines that don't start with > or < from the diff.

Good catch!

It would be nice if we could filter out all lines that don't start with > or < from the diff.

Yeah that's what I'll do instead of just removing the first line

Another thing that my testing revealed: it looks like the typeshed_primer_comment workflow is being triggered on push events as well as pull_request events (it's getting triggered every time the tests workflowis completed, and thetestsworkflow is run onpushevents andpull_requestevents. The bot obviously can't post a comment if there isn't a PR, so thetypeshed_primer_comment` workflow fails every time when it's triggered on a push event, and that leads to a lot of failing workflow runs: https://github.com/AlexWaygood/flake8-pyi/actions/workflows/typeshed_primer_comment.yml.
We can fix this by moving the typeshed_primer job into a separate workflow file, and having that workflow only be triggered on pull_request events. Then typeshed_primer_comment can continue to only be triggered on completion of the typeshed_primer job, but it won't repeatedly try and fail to post comments on push events.

Looks like I haven't broken anything. Ready to re-test on your side. It should also be slightly faster to add/hide comments since it doesn't need to wait for the entire check workflow to be complete.

Looks great to me. Here's three PRs, each building off the former, on my branch. The diff on each one looks well formatted!

https://github.com/AlexWaygood/flake8-pyi/pull/3
https://github.com/AlexWaygood/flake8-pyi/pull/4
https://github.com/AlexWaygood/flake8-pyi/pull/5

Time to merge this and see what happens, I think.


Fix client when it initially receives data rather than sending it

The connection preface wasn't sent if the first operation was to receive data. This is due to a state machine transition to :connected in the frame receive mechanism without invoking #send_connection_preface.
As an aside, I sort of think it's a bit inefficient to invoke this function on every data receive/send, but perhaps that's an issue for another time.

An alternative approach is presented in https://github.com/igrigorik/http-2/pull/44/commits/02ba3f089363c2869d211faa5e24bb7f286d2f13
Either approach is fine. However once this PR is merged, the other can be closed. I don't know a lot about the internal details of how http-2 works, but it appears that connection_management could be a more appropriate place for this logic?

I've added a final commit which implements the alternative (better?) logic. Discussion is required.

Coverage decreased (-0.07%) to 96.586% when pulling e087b92d3645283efffa17ab0f3febcdb25d3bbf on socketry:master into 2c127aec0cff711b7f27e9a7f8dad2d952984fd7 on igrigorik:master.

Coverage decreased (-0.07%) to 96.586% when pulling e087b92d3645283efffa17ab0f3febcdb25d3bbf on socketry:master into 2c127aec0cff711b7f27e9a7f8dad2d952984fd7 on igrigorik:master.

Coverage decreased (-0.07%) to 96.586% when pulling e087b92d3645283efffa17ab0f3febcdb25d3bbf on socketry:master into 2c127aec0cff711b7f27e9a7f8dad2d952984fd7 on igrigorik:master.

It looks like there are some logic errors - @igrigorik @HoneyryderChuck can you check it and let me know?

Okay, I've got all the specs passing with minimal changes. It would be good to discuss this further though, there are some issues I think need further discussion:

The connection_spec.rb really seems to test the class Client.
The Connection base class is broken in the sense that it doesn't define @state.
There are some "odd" code paths in Connection, e.g. self.is_a? Server for tracking if stream IDs are valid or not.

Stuff like
RSpec.describe HTTP2::Connection do
  before(:each) do
    @conn = Client.new
  end

  it '...' do
    @conn.send ...
  end

sort of seem a bit crappy. It would make more sense to be like:
RSpec.describe HTTP2::Client do
  it '...' do
    subject.send ...
  end
end

FWIW, the logic in https://github.com/igrigorik/http-2/commit/02ba3f089363c2869d211faa5e24bb7f286d2f13 seems simpler. Avoiding the need for new instance variables seems like a plus. Also, squinting, seems like perhaps this should all live in connection instead? WDYT?
https://github.com/igrigorik/http-2/blob/2c127aec0cff711b7f27e9a7f8dad2d952984fd7/lib/http/2/connection.rb#L367

I'd really need to spend a few days digesting how the entire thing works in more detail in order to really offer an opinion. I just made the change that I thought made the most sense and worked through all the broken specs.
You've (ideally) got a better understanding of the design of the library so I guess if you want a deeper discussion, I'm not the right person... at least, not unless I spend a few days digging into it.
I actually decided to resolve this issue in async-http by not calling read until something was written. I'm not sure it's ideal, but it's one option which avoids this whole state problem.
Honestly, I think there are some issues w.r.t. how Connection/Server/Client work together - that I mentioned earlier. It might be worth reviewing exactly how you want that to work - e.g. is @state really necessary?
Additionally, today I ran into race conditions within the library, if you don't register event handlers before calling read, you end up with race conditions, e.g. it's possible that you loose incoming requests, because you didn't call on(:stream) ... before reading incoming data.
It's quite tricky to get right and not very obvious. I'm personally a fan that once you construct an object, it's ready to go. I don't like (registering) event handlers (very much).

Thanks for your feedback.

I think the PR has a lot of moving parts (code reorder, new ivars...) that don't have to do with it's intended bugfix

There's only one unrelated bit which is the error handling. Basically, everything else is related to the bug fix.

implied what could be the fix for this particular issue, which you have implemented in your code with success, so the PR should contain that, and the necessary fixes for the tests to work.

That's almost exactly what this is. The final approach I took was the one suggested in https://github.com/igrigorik/http-2/commit/02ba3f089363c2869d211faa5e24bb7f286d2f13
Everything else is essentially fixing problems either with the specs, or issues introduced by the change. There are a few minor changes to the specs to make it clearer which ones are failing - in the case we had one spec for about 10 different scenarios, I turned that into a loop so we have 10 different specs, and that's because about half of them were failing and the other half were okay.

That's not a race condition, it's how the lib works. You do have to set all the callbacks before starting to decode frames.

It's absolutely a race condition, but it's also how the lib works :) The order of (non-deterministic) operations changes the results. In async-http in about 90% of cases the server would pick up the request just fine, but if the data was already in the socket when the server started reading, the function call to on(:stream) would not be registered in time. Anyway, I've worked around it in my code.

That's how "user code" interfaces with "lib code", at least for now. However, an alternative would be to pass an object with the callbacks already set up as methods, the way that the http_parser.rb gem does (cc @igrigorik ). However, again, this should be addressed in a separate issue/PR.

Yeah, I agree, it's another possible option. However, at this point, I'm not sure it's worth changing the entire API just because it might be more ergonomic. I think the best option would be to break it out into separate gems, e.g. the framer, hpack, and so on, so the high level implementation can be handled by the client code (with some defaults like Client and Server that basically work out of the box). Anyway, this discussion is for another time :) Let's focus on whether we can fix this bug in Client.

@igrigorik

FWIW, the logic in 02ba3f0 seems simpler. Avoiding the need for new instance variables seems like a plus. Also, squinting, seems like perhaps this should all live in connection instead? WDYT?

Yes, that's what I finally implemented.
However, that change introduces many issues with specs because changing @state caused odd issues in Connection which I wasn't really able to make sense of. I tried using an explicit variable to track whether it's sent (IMHO a better approach since it's more isolated) and it worked better and caused less issues with specs. I think if you want to try either option and see for yourself what specs break, perhaps you have a better idea of how to fix the state machine. Personally, I find the state machine pretty tricky to understand without really spending a lot of time working through it.

There's only one unrelated bit which is the error handling...

Have only taken an overlook, but I see a method in client.rb being moved, some rescue clause changing, and a bit of formatting in the specs, that don't seem to have to do with the contextual change. Again, not saying that it's irrelevant, but I'd say it could be addressed separately.

The final approach I took was the one suggested in 02ba3f0

Fair enough. I'd say that my suggestion could take less LOCs :) But I'm ok with whatever works.

The order of (non-deterministic) operations changes the results...

I didn't get this part. What is exactly non-deterministic about it? Unless you're handling streams in multiple threads, I'd say this shouldn't be an issue.

I didn't get this part. What is exactly non-deterministic about it? Unless you're handling streams in multiple threads, I'd say this shouldn't be an issue.

Call read - socket buffer empty - no streams started
Set stream handler
Call read - socket has data - stream started

vs

Call read - socket buffer has data - stream missed
Set stream handler
Call read - socket has no data - stream not started

Have only taken an overlook, but I see a method in client.rb being moved,

You mean, I made it private? As you suggested here? https://github.com/igrigorik/http-2/issues/122#issuecomment-376563850

some rescue clause changing

Yes, this could be separate.

and a bit of formatting in the specs, that don't seem to have to do with the contextual change.

This was a useful change to help figure out what parts of the initial change were causing breakage.

You mean, I made it private? As you suggested here?

My bad, I got confused while reading the diff.
Another thing that I left out before: I don't think you need to use @connection_preface_sent, if you either follow my suggestion, or follow a previously linked suggestion.
Also, I don't think there is non-determinism there. If you start reading from a socket, you better have a fully-configured parser before you pass it the bytes; specifically, you don't "miss-streams-then-set-up-handler", handler has to be set-up once you start reading from the socket.

Another thing that I left out before: I don't think you need to use @connection_preface_sent, if you either follow my suggestion, or follow a previously linked suggestion.

Yeah but I tried that and it and more specs failed. Is it worth trying to figure out why it's not working?

Also, I don't think there is non-determinism there. If you start reading from a socket, you better have a fully-configured parser before you pass it the bytes; specifically, you don't "miss-streams-then-set-up-handler", handler has to be set-up once you start reading from the socket.

Fair enough. If I was implementing this it would buffer the events until they were dequeued, but I'd also use a different event handling mechanism (probably a queue).

Yeah but I tried that and it and more specs failed. Is it worth trying to figure out why it's not working?

I think so. If you recall from my comments in the linked issue, I did say that the fix would be easy, but the tests part would be the worse :) I'll see if I can reproduce this locally to see exactly how big the gap is.

If I was implementing this it would buffer the events until they were dequeued,

The lib already does this, just that "dequeuing" is in this case "emitting", and you need behaviour set for this.

I've just run a clean master with my suggested diff:
# client.rb
+    def receive(*)
+      send_connection_preface
+      super
+    end
+

surprisingly, and against my expectation, it "just worked" (tests passed).

That's awesome, I wonder why it didn't work for me. I will have to check the original commits.

Hmm, I added it to <<. I guess that's different.

ouch, I see what happened. Will come back to it.

I didn't know alias worked like that to be honest. But, it sort of makes sense, it becomes define_method(new_name, self.instance_method(original_name)) or something to that effect.

@HoneyryderChuck @ioquatix thanks for digging into this. Been offline for a while, catching up.. what are the next steps here?

I think this PR takes things in the right direction, but whether you try to make @state work or just use a separate variable is still in question. Personally, I think @state is the wrong place to manage this transition.

Once https://github.com/igrigorik/http-2/pull/131 is merged, I will rework this PR.


[Bug] SDK emit content_length in http response with string type instead of number.

Xray SDK should send content_length with number type in the json segment for the http request data.
But I get this data when I use the latest node.js sdk version: data.txt
This is a bug and when our customers try to use OT collector to take place of Xray-daemon, they can't get the data they want.

This looks correct, as per https://docs.aws.amazon.com/xray/latest/devguide/xray-api-segmentdocuments.html content-length should be recorded as a number.
We'll need to correct this in a few places:
https://github.com/aws/aws-xray-sdk-node/search?q=content_length


Make weapon damage derive from Ice and Fire config?

Heyo!
Just wanted to see if it was possible for you to make the config from Ice and Fire influence the damage of the dragonbone and dragonsteel weapons in your mod.
Thank you!

I don't know why it isn't working right now, I'm using the Ice and Fire's own material definition which already uses the value from config. Nevertheless, I'll be doing my own config file if anything.

Sounds good man, I'll be looking forward to that. Thanks!

Closing this one, maybe I'll do my own config #7


Dependency not found: @ui5/webcomponents-base/Theming"

Hi StErMi,
While trying to implement the HCB theme feature, below mentioned dependency fails:
import { setTheme } from "@ui5/webcomponents-base/Theming";
In console I get a message:

To install it, you can run: npm install --save @ui5/webcomponents-base/Theming

but this command also fails. Did you have any trouble with this part?

yes,
the correct command should be:
import { setTheme } from<EMAIL_ADDRESS>

@myyosi can you please include this in your repo or make new update in repo..

I am getting this below error
To install them, you can run: npm install --save @ui5/webcomponents-base/Theming @ui5/webcomponents-fiori/dist/ShellBar @ui5/webcomponents/dist/ThemePropertiesProvider


Unrestricted cli-config.php file location

I can't find any informations about inform CLI where should search cli-config.php file.
In this moment I've got two options to place this file: / project directory or /config  directory in root. But what if I want store config file in eg. /app/config/cli-config.php?
Is this possible?

@kilab it will look in your cwd (current working directory).
See: https://github.com/doctrine/doctrine2/blob/53245e8a73cb16d5e9ba35ffa5bbb15cc417bb9f/bin/doctrine.php#L35-L44
The docs are indeed a bit confusing about it: http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/tools.html#configuration
Could you maybe patch them, once you get it working for your local environment?

@Ocramius thanks for the hint!
If I'll run CLI command in directory where cli-config is storing, everything is fine.
In my case command is:
/app: ../vendor/bin/doctrine orm:schema-tool:update --force --dump-sql


[KIP-345] Static membership

This PR is the start adding support for static membership (#884). The corresponding KIP is here: https://cwiki.apache.org/confluence/display/KAFKA/KIP-345%3A+Introduce+static+membership+protocol+to+reduce+consumer+rebalances
As a start, I have upgraded most of the API versions to the required version. For most of them, there is no significant difference, except adding client side throttling which we now support in JoinGroup, SyncGroup, Heartbeat, LeaveGroup and OffsetCommit. At the moment, I have not added any facility for actually setting the groupInstanceId property on the consumer, which means that we retain the old behavior of dynamic membership.
I ran into some issues when I started working on upgrading OffsetCommit to V6+. V6 adds leader_epoch to the partition you are committing offsets for, as part of KIP-320. I haven't looked into it much yet, so I may have the wrong idea, but from a brief look it sounds like we need to support Fetch v12, which adds current_leader_epoch to the response, and then keep track of that and include it in the OffsetCommit request. But frankly, KIP-320 is pretty large (check the heading "Consumer Handling" for all the behavior it expects to change).
I'm submitting this as a draft, because I wanted to get some feedback and help to figure out what we actually need to do to move forward. I think we could go ahead and merge this separately, as I don't believe there should be any implications as long as groupInstanceId is null (which it is), but let's make sure.
In order to figure out what changed in each version of the APIs, I found that the request schema files in the Java client actually has some comments at least giving you a hint, so that you know what to look for in the KIPs. For example: https://github.com/apache/kafka/blob/trunk/clients/src/main/resources/common/message/OffsetCommitRequest.json#L20-L32

Had a look through all the changes, which seem pretty straightforward protocol upgrades to me so far. Didn't check them against the protocol, but relying on tests to highlight any unlikely mistakes there.

At the moment, I have not added any facility for actually setting the groupInstanceId property on the consumer, which means that we retain the old behavior of dynamic membership.

This seems like the safe default behaviour. Any idea on how the group instance id would be set? According to KIP-345, this allows prioritising of state changes over liveliness. That seems like a trade off to make on the application level, completely depending on the amount of state change you have vs. your availability requirements. From there, I assume it's the right thing to let the user control the use of a groupInstanceId or not (whether directly or indirectly)?

Any idea on how the group instance id would be set?

It is up to the application to ensure that this is set, is unique in the group and is retained across restarts. Could be set through configuration or some environmental information (machine ids etc.) Eventually we'll expose it as a consumer option, but since we don't actually support the functionality yet, I'm not exposing it.

Great stuff @Nevon, and I agree that just the protocol update shouldn't cause any other side effects.


Refactor/VendingMachine

This is a new PR, but still related to #17767 and #18051
New components:

New vending machine component
Description

VendingMachineInventoryComponent
Standart inventory

VendingMachineEjectComponent
Responsible for issuing items

VendingMachineEmpEjectComponent
Responsible for issuing items during the EMP effect

VendingMachineRestockComponent
It is needed to replenish the machines with the help of a pack

VendingMachineVisualStateComponent
Designed for the visual state of the machine

New auxiliary component
Description

BrokeComponent
The component required for the operation of VendingMachine

DispenseOnHitComponent
Parameters for randomly throwing an item with a recharge

Separated data from the general VendingMachineComponent

Separated data
Description

VendingMachineData
A dummy class that combines the general data of vending machines

VendingMachineInventoryTypePrototype
The prototype that is being added to .yaml file of the package of items for machines itself

New systems:

New system
Description

VendingMachineSystem.Emagged
Separation from the main Vending Machine System class for easier configuration in the future

VendingMachineSystem.Damage
OnBreak and OnDamage events

VendingMachineSystem.Emp
Designed for ejecting objects after the EMP effect

VendingMachineSystem.Price
Counts the entire price inside the machine

VendingMachineSystem
Now this system is designed only to work with inventory

VendingMachineSystem.Ui
Works with UI events

VendingMachineSystem.VisualState
Visualization of the vending machine depending on the condition

Tasks

[x] Split the VendingMachineComponent into separate parts
[x] Split the VendingMachineSystem
[x] Separate inventory types from enum and make a prototype
[ ] To make items in the inventory not via string, but using EntityUid

Changelog
:cl:

tweak: NanoTrasen announces that it will improve vending machines in the future!

BASED

Is this ready for review yet because it's had many force pushes and prior prs.

@CrazyCat2048 Are you still working on this? Refactoring a large system is a big ask for your first pr.

@CrazyCat2048 Are you still working on this? Refactoring a large system is a big ask for your first pr.

Meh.... In a good way, I still need to redo the inventory instead of the list on the container. I'll try to do it, but I don't promise that I'll finish it before the end

Ready for review

@CrazyCat2048 You still working on this? (Im just gonna close this since it's so old and you've already been asked once but if you come back just make a comment and i will gladly re-open)


Screenshot in readme stopped working

Add a new one and embed it in the readme.

Several months later:
...
Nothing...

Hi Arinerron,
I maintain JavaANPR in my free time, which -- as you pointed out -- I don't have very much of.
Sorry for disappointing you, I'll do my best to fix this over the weekend.
Although, do note, that this project is open-source. You're very welcome to fix the issue (it's quite easy, try it!) and open a pull request :)

@oskopek Thanks! I am a student developer (in middle school?), so I have all day to work on stuff. I just wanted to see a screenshot so that I don't get it and integrate it and then realize it doesn't work for my needs.

@Arinerron for easy integration, see https://github.com/oskopek/javaanpr/blob/master/src/test/java/net/sf/javaanpr/test/RecognitionIT.java#L48


Fix binding validation path

Summary

Adjust binding path style for the tooltip.
VS auto upgraded projects to .NET 4.8.
Trimmed the data object.
Added the data object to the article.

Fixes #1878

Internal previews

📄 File
🔗 Preview link

dotnet-desktop-guide/framework/wpf/data/how-to-implement-binding-validation.md
dotnet-desktop-guide/framework/wpf/data/how-to-implement-binding-validation

@BillWagner Ready!


Broken template engines link in wiki

Hello,
The link to template engines here in the wiki is broken. The page on expressjs.com (https://expressjs.com/en/resources/template-engines.html) was removed in this PR. So probably the link should be removed as well?
I'm not sure if it is possible to create a PR to change the wiki, so I created this issue instead. Maybe someone can help me with how make a change request for the wiki or just update it directly.
Thank you!

Good find, I think the link should be replaced with https://expressjs.com/en/guide/using-template-engines.html.

Honestly I think we talked about deleting the wiki someday. It is not at all well kept up and was mainly from the old days before all this stuff was on the website. I wonder if we should just delete it entirely?

Good find, I think the link should be replaced with https://expressjs.com/en/guide/using-template-engines.html.

In this cas this page should be patched too, as it refers to the wiki to list the template engines, which then redirects the user to the deleted page (as seen above)

See Template Engines (Express wiki) for a list of template engines you can use with Express.

Hey @njanssoone 👋
Thank you for pointing it out. However, I agree with @wesleytodd on this. I believe there should be a single source of truth. And maintaining a single place is much simpler to keep it updated.
We should do the following,

[ ] Make sure the website includes everything that has to be included from the Wiki
[ ] Set the Wiki homepage saying users to read docs from the website
[ ] Delete other pages from Wiki

@IamLizu, would you like to work on this and prepare a PR(s) for the content migration?


Reducing ASGI.send calls

This PR exclude the extra call to the ASGI.send function.
This allows in some cases to speed up the processing of requests.
Before patching:
$ python3 asgi_srv.py -g fw -q -v 2
$ wrk -t1 -c100 -d15 -H 'Connection: keep-alive' http://<IP_ADDRESS>:5000/plaintext
Running 15s test @ http://<IP_ADDRESS>:5000/plaintext
  1 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency    35.54ms   21.75ms  87.06ms   52.51%
    Req/Sec     2.83k   232.65     3.41k    80.00%
  42324 requests in 15.01s, 7.07MB read
Requests/sec:   2820.07
Transfer/sec:    482.25KB

After patching:
$ python3 asgi_srv.py -g fw -q -v 2
$ wrk -t1 -c100 -d15 -H 'Connection: keep-alive' http://<IP_ADDRESS>:5000/plaintext
Running 15s test @ http://<IP_ADDRESS>:5000/plaintext
  1 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency    31.09ms    2.83ms  50.52ms   89.37%
    Req/Sec     3.23k   379.39     4.04k    80.67%
  48200 requests in 15.01s, 7.22MB read
Requests/sec:   3211.12
Transfer/sec:    492.33KB

PROFIT = 100 * (1 - 2820 / 3211) = 12%

Debian 11 64-bit, Python 3.9
HTTP server sources: https://github.com/remittor-pr/fastwsgi/commits/devrem
Server app: asgi_srv.py

Thanks, but the code is clearer and more robust in the current version. I'm prioritizing robustness over speed.


How to add a second IP to Azure Firewall

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

terraform:
v1.4.6
azure provider:
v3.61.0
module:
source = "Azure/caf-enterprise-scale/azurerm"
version = "4.2.0"
Description
Describe the bug
Hello,
We currently have an Azure Firewall deployed with one public IP and would like to add a second. We couldn't find in the documentation how to do this, so we looked in the code and saw that it's possible to enforce the "ip_configuration" part with "custom_settings".
However, according to the azurerm_firewall documentation, each IP requires it's own "ip_configuration" block and in "custom_settings" we can only set one.
So I'd like to know how to add a second public IP.
Steps to Reproduce
No Steps as it's not a bug.
Screenshots

Additional context

@ddejaham a workaround can be to implement the firewall outside of the module and using the output of the module for inputs to the firewall. I hope that we can get the option to configure multiple blocks of ip_configuration in the custom_setting.

Hi we don't support this at the moment. Will will consider this as an enhancement

I've played around with that a little as mentioned at https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/issues/559#issuecomment-1354931366 with some success.
The issue I encounter (as mentioned in https://github.com/Azure/terraform-azurerm-caf-enterprise-scale/issues/879#issuecomment-1873699670) is that the resources created by the module managing the pip (first public IP) is to be removed and forces management outside the landing zone module.
In addition to that, I can't apply a lifecycle management in module.enterprise_scale.azurerm_firewall.connectivity since it's inside a module and can't be used since that block type is reserved for usage in future versions.


Link on github wiki is wrong

https://github.com/quintoandar/butterfree/wiki/Documentation
It is not redirect to read the docs.
It should be : https://butterfree.readthedocs.io/en/latest/

Thanks, @gabrielclimb :smiley_cat:


VS Code not able to install extensions : "An unknown error occurred. Please consult the log for more details."

no extensions are getting installed .

this is the screenshot of "developer tools"

network snapshot of failure:

Looks like it.
Please check out the following docs page: https://code.visualstudio.com/docs/setup/network#_ssl-certificates
Then try --ignore-certificate-errors

@vkvmudunuri Please check the docs and try as suggested

proxy was blocking. setting were changed and urls were whitelisted . no problem now

Had the same issue. Monitored my Little Snitch Configurations while clicking on "install", saw that my settings were off and now everything works fine!


Can't move Discord windows

Describe the bug
This likley could be an issue with the way Vencord imports themes if this works fine on BetterDiscord but for some reason no matter where in the bar I click, I can't grab and move the discord window weather Fullscreend or 'Restored'. While recording an example video I have discovered it does work but only in very specific parts of the window
To Reproduce
I'm happy to screenshare and videocall to reproduce this if it is unreproducible on your systems
Screenshots
https://we.tl/t-5PIQHOED17
Information (please complete the following information):
Discord channel: Any (my discord is phederal_phoenix/Phederal_Phoenix#7049
OS: Windows 11
Mod: Vencord
Discord language: English/British English

In Vencord's settings, you can enable Use Windows' native title bar...

Also, just fixed this!
https://github.com/DiscordStyles/SoftX/pull/116


[Automation] Generate Fluent Lite from Swagger oracle#package-2023-09-01-preview

[Automation] Generate Fluent Lite from Swagger oracle#package-2023-09-01-preview

/azp run prepare-pipelines

/azp run java - oracledatabase - ci

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure.resourcemanager:azure-resourcemanager-oracledatabase


pkgs/by-name: make callPackage intrinsic

Ideally, I would only need to pass the input sources (and the nixpkgs lib?) to pkgs/by-name/default.nix for it to work. Haven't tested yet.

Ideally you could even pass the input sources as one argument. But generally that direction makes sense.


Implement a Progress Indicator Widget

Implement a Progress Indicator widget that will be abstract and reusable. This need arises mainly for the Outages screen where we need to show this widget while Outages and Prefectures are loading.
However, the Widget needs to be reusable in case we need to use it elsewhere in the future.

Closing this enhancement as it is no longer needed - when the outages are loading (first time, or on selecting a different outage) there is a respective screen shown. A blocking progress indicator would not be the ideal situation as the UI/UX is currently designed.
If the situation arises that we need a progress indicator in the future, for some other reason, will raise a separate issue.


can't detect sonos ip addres

its keep telling that the active network is <IP_ADDRESS> even after i restart several times.
in sonos app the ip address is <IP_ADDRESS>

The "Active Network" dropdown shows the IP address of the network interface in your PC that is selected to detect audio receivers via SSDP. It has no relation to the receiver(s) that swyh-rs is streaming to. In fact if you have multiple streamers you can stream to all of them simultaneously. The dropdown is there to select another network interface if your PC has more than one (physical or virtual):

From the Readme: By default the network that connects to the internet is chosen (so that on a multihomed Windows machine the most likely interface is selected). If necessary you can choose another network from the network dropdown, for instance if you use a VPN.

The  "Active Network" dropdown not showing correct ip address.

Then please provide some relevant information, like the output of ipconfig /all and a swyh-rs logfile.

I will close this now, as without any additional information there is nothing that I can do.
Feel free to reopen this issue if you are ready to provide the output of "ifconfig /all" and the swyh-rs logfile (debug mode if possible).


Restructure project hierarchy to be a proper gradle project

Right now it's still set up like an eclipse project, just with hook-ins to support gradle. I will try to do this today and PR back in tonight. I'm suggesting this on the assumption that you guys have switched over to Android Studio now that it's stable, so please let me know if this isn't viable right now :smiley:

We still keep the old structure because we didn't want to remove maven support just yet, but I'm not very confident maven is still working.
I think somethings are still missing for Gragle (e.g. runing tests from Travis) and maven should be there until we fix it.

I see, we could open that as a separate issue and close this for now?


Question - Expand Horizontally?

Hi, is there a way to set it to expand horizontally?  This is the perfect solution for expanding vertically.  However, I also need the textarea to expand horizontally as well.  For example, when I space over I push the right border over to a predetermined maximum then expand vertically.  Thanks.

Archiving repository.


[Feature]: I want display the number on table that which records are displaying in table.

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
I want display the numbers on table that which records are displaying in table based on page size and total records while using Server side pagination. Suppose the page size is 50 and total records are 1000 then in page 1 (1-50) records
page 2(50-100)records
page 3(100-150) records
like this the table should show the page number as well as record numbers and total records in database.
Why should this be worked on?
It is easy to track the records and pages the are there with the data.

Thanks for adding this @lavanyaG4, we will check this out.


Documentation for app.set is ambiguous

I think the recommended usage of app.set includes storing your own values in there. For instance, the examples in the docs show: app.set('title', 'My Site');. Yet the description for this method doesn't necessarily allow for this usage:

Assigns setting name to value, where name is one of the properties from the app settings table.

This sentence seems to be quite explicit in that name must be one of the app settings values in the table that appears beneath this section, yet title doesn't appear in that table. This leads to ambiguity in how this method should be used.
If I'm right that this is also a general-purpose way to store values, would you be up for a PR that makes this more explicit? Consider:

Assigns setting name to value. You may store any value that you want, but certain names have a special meaning to Express. These special names are listed in the app settings table.

If this is not the case, then the examples should probably be updated, and Express should possibly throw an Error if you set an invalid value.
Thanks for reading!

(Originally opened as https://github.com/expressjs/express/issues/3393 )

Per @dougwilson's comment:

But to the underlying question: yes, you can add custom settings in there to your liking.

So I agree we should clarify the wording in that section accordingly.   Thanks for catching it!
As Doug said, we welcome a PR for that.


[Storage] Migrate test_queue_encryption.py to test proxy

This PR migrates test_queue_encryption.py and test_queue_encryption_async.py to the test proxy testing framework!

API change check
API changes are not detected in this pull request.


BatchWrite: use ShardRowIDBits to generate row id

What problem does this PR solve?
currently ShardRowIDBits is ignored when generating row id
What is changed and how it works?
use ShardRowIDBits to generate row id
Check List
Tests

Unit test
Integration test

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests


explore marisa-trie in place of our trie implementation

This may be important for future OTU picking in QIIME 2. marisa-trie.

:+1:
On Wed, Jun 3, 2015 at 8:38 AM, Greg Caporaso<EMAIL_ADDRESS>wrote:

This may be important for future OTU picking in QIIME 2. marisa-trie
https://pypi.python.org/pypi/marisa-trie.
—
Reply to this email directly or view it on GitHub
https://github.com/biocore/scikit-bio/issues/937.

I think the next step is to deprecate the trie code in scikit-bio in favor of marisa-trie or one of the other trie Python packages (e.g., datrie, DAWG). Each trie implementation has its pros and cons (e.g., memory vs. runtime efficiency, immutable vs. mutable, etc.). The functionality provided by scikit-bio's trie object can be accomplished using one of these other packages.

I agree re: deprecation of our trie code in favor of one of the others,
though we'll just need to make sure that we can get the information we need
from those (i.e., the sets of ids that cluster to each node in the trie).
We may then want to wrap that code in our sequence clustering API (which is
yet to be defined, but which we'll need as core functionality in skbio for
QIIME 2).
On Fri, Jun 5, 2015 at 5:05 PM, Jai Ram Rideout<EMAIL_ADDRESS>wrote:

I think the next step is to deprecate the trie code in scikit-bio in favor
of marisa-trie or one of the other trie Python packages (e.g., datrie
https://pypi.python.org/pypi/datrie/, DAWG
http://dawg.readthedocs.org/en/latest/). Each trie implementation has
its pros and cons (e.g., memory vs. runtime efficiency, immutable vs.
mutable, etc.). The functionality provided by scikit-bio's trie object can
be accomplished using one of these other packages.
—
Reply to this email directly or view it on GitHub
https://github.com/biocore/scikit-bio/issues/937#issuecomment-109486493.

though we'll just need to make sure that we can get the information we need from those

Sounds good, are you interested in taking the lead on this and posting back here when it's safe to deprecate this object?

Here is another trie implementation, which may be useful.
https://github.com/dcjones/hat-trie
It's even got a python wrapper:
https://github.com/kmike/hat-trie
One comment on the page:

If you need a memory efficient data structure and don't need inserts then marisa-trie or DAWG should work better.

So if we DO need inserts, then this looks like a solid option.

Yep, I'll take this one.


Added VerboseFuck

I've added VerboseFuck to the repository.
VerboseFuck, like it's name, is very verbose.

We have done it.
We've found a programming language more complex than Brainfuck.


fix: fix rpc klay_newfilter and other some rpc

fix: fix rpc klay_newfilter and other some rpc

LGTM


Add float configuration

Adding a float setting will make the site much better.

Currently have no time to work on this project maybe in the future.


Union type not enforcing members correctly

TypeScript Version:  3.1.1

Search Terms: unions
Code
export enum ButtonStatus {
  ENABLED = 'enabled',
  DISABLED = 'disabled',
  LOADING = 'loading',
}

export interface RegularButtonProps {
  readonly status: ButtonStatus;
}

export interface LoadingButtonProps {
  readonly status: ButtonStatus.LOADING;
  readonly loadingText: string;
}

export type ButtonProps = RegularButtonProps | LoadingButtonProps;

const buttonProps: ButtonProps = {
  status: ButtonStatus.LOADING,
  loadingText: 42,
};

Expected behavior:
Error saying loadingText should be of type string.
Actual behavior:
No error. Hovering over loadingText does tell me that loadingText is a string, so the compiler knows but doesn't raise it?

Playground Link:
https://www.typescriptlang.org/play/#src=export enum ButtonStatus {
  ENABLED %3D 'enabled'%2C
  DISABLED %3D 'disabled'%2C
  LOADING %3D 'loading'%2C
}

export interface RegularButtonProps {
  readonly status%3A ButtonStatus%3B
}

export interface LoadingButtonProps {
  readonly status%3A ButtonStatus.LOADING%3B
  readonly loadingText%3A string%3B
}

export type ButtonProps %3D RegularButtonProps | LoadingButtonProps%3B

const buttonProps%3A ButtonProps %3D {
  status%3A ButtonStatus.LOADING%2C
  loadingText%3A 42%2C
}%3B

Related Issues:
Mmmaybe this one? https://github.com/Microsoft/TypeScript/issues/26450

Ah, sorry, didn't see @DanielRosenwasser's PR: https://github.com/Microsoft/TypeScript/pull/27087


Allow the tester role to be able to access inactive workflows

I wanted to test out with a small group of users our new workflow, but apparently the tester role can't see a inactive workflow even with the direct link.
Can it be changed to allow testers to access inactive workflows via the direct url. It would be great for beta testing of new workflows or future upgrades to a project.

Note this is for P4: Ridges. I thought the tester role would have access to an inactive workflow just like the tester role can see a private project.

@mschwamb this is a UI issue, I've enable the experimental feature to allow worfklow URLs to be passed around for testing.

FYI there is nothing API stopping this from happening, the UI won't wire up workflow params unless you have collab / owner roles or the experimental feature is turned on. Might be best to start this discussion over there.


GFX: Segfault due to systemd system call filter

I'll report the detail later.

This fixes it: https://github.com/Nexarian/xrdp/pull/9/files#diff-7c6de7dbf8f33c67f0829693b3172563857ed0890f47784e4387c87ee2cc2fd1
I'm not sure what is relevant in those changes and what isn't. I'm also not sure under what circumstances this is triggered.

There's more info in finding out what is triggering SIGSYS in #2697

Resolved in current devel.


Kotlin objects not working as singletons

am trying to use a kotlin object from jpype in python as a singleton. When I try to call any methods I get this: TypeError: No matching overloads found for *static* I tried importing with from package import Singleton and jpype.Jpackage(package).Singleton

When you import a class in JPype, you get the class, not an instance of the class. The error tells you it cannot find a static method, which means you are calling the method on the class versus an instance of the class.
There is a static field INSTANCE that Kotlin generates for singletons. Thus, to use Kotlin singletons in JPype, do this:
from package import Singleton as SingletonClass
Singleton = SingletonClass.INSTANCE

Singleton.someMethodOnSingleton()


Update the game over message

Update the game over message so people know how to play again!

Comment message


Implement MTU Discovery

Spectral currently does not automatically detect the Maximum Transmission Unit (MTU) size, which can lead to packet fragmentation and slower network performance.

implemented in https://github.com/cooldogedev/spectral/commit/30630bf76889603be4b41e00ae21e5f7445b0bd6


Eternal Adapter get deal information API

Is your feature request related to a problem? Please describe.
GET  /deals/{deal_id}?network=filecoin_calibration
Describe the solution you'd like
the return should be fit @liushmh 's requirement
@liushmh  can you post the return in my comments?
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
validation
http://host:port/deals/58160&network=filecoin_calibration

json format of response:
{
   "status":"success",
   "data":{
      "deal":{
         "deal_id":61308,
         "deal_cid":"bafyreibqjeplfmc7smwd3v6h3wkvh5gipxqp5fs7yt6pv63fksjvcc656i",
         "message_cid":"bafy2bzacec4gsgtxcgexqa53ipxch7zlegluzbawy77bqutkecndyvlqahqao",
         "height":462545,
         "piece_cid":"baga6ea4seaqdfr22etwsavs7usimjlbpubd4bkqpntub57ebe3sfnib7ynqc6ea",
         "verified_deal":false,
         "storage_price_per_epoch":"0 AttoFIL",
         "signature":"qcKpyTaIhIDRYfEJvTqmwnDDMcyq5QjaFrIAiMWbMERpfUVIyu+KVD6PflhTc8A+CjkX1sqFOoU7g9wMcJ4DA3JNw9pKc/eQx9X6fi3VrB+q3jv8nFNQ7VYBpLUhqEq6",
         "signature_type":"bls",
         "created_at_src":"2021-11-26 22:32:30",
         "created_at":1637965950000,
         "piece_size_format":"32.00 GiB",
         "start_height":476911,
         "end_height":2017711,
         "client":"t3udgr4olzsvolib5jd7rut5liqoeja5h7r2mahuv54u5a6q2s4ibhzywlmn4h6xdasezyr4ji3diipy6aq5oa",
         "client_collateral_format":"0 AttoFIL",
         "provider":"t024413",
         "provider_tag":"",
         "verified_provider":0,
         "provider_collateral_format":"0 AttoFIL",
         "status":0,
         "network_name":"filecoin_calibration",
         "storage_price":739631457246
      }
   }
}

GET /{deal_id}/{network}
http://host:port/58160/filecoin_calibration
@flyworker can you change it to my format, that's much more standard.

it is not easy to understand in my opinion.
flink maybe provide more infomation than just deals, in your format, if we have more than other data, we cannot add more api,
GET /deals/{deal_id}?network=filecoin_calibration
means it is the API in Deals category.
This is the standard API support.

ok

Which fields are you using? Can you list them? Since we cannot get all of the fields as last version.
@liushmh

@DoraNebula  Please post the values you have for reference

following 3 fields, thanks
     "status":0,
     "network_name":"filecoin_calibration",
     "storage_price":739631457246

@liushmh  "deal_id":61308,
"deal_cid":"bafyreibqjeplfmc7smwd3v6h3wkvh5gipxqp5fs7yt6pv63fksjvcc656i", is not needed?

not for now

currently data format and contents:
{
"status": "success",
"data": {
"deal": {
"deal_id": 10012,
"deal_cid": "bafy2bzacebpnjvas64kkvjt2xtz46g7guxkzh7r74pe7kyz243t3hdwj2gn7i",
"message_cid": "",
"height": 3912,
"piece_cid": "baga6ea4seaqa3hepscpujebo3xh657cksmahj3nvundlfn4wima7kymsmnxh6li",
"verified_deal": false,
"storage_price_per_epoch": 61035,
"signature": "",
"signature_type": "",
"created_at":<PHONE_NUMBER>,
"piece_size_format": "",
"start_height": 6790,
"end_height": 710778,
"client": "",
"client_collateral_format": "000000000000000000",
"provider": "f01782",
"provider_tag": "",
"verified_provider": 0,
"provider_collateral_format": "000000000000000000",
"status": 0,
"network_name": "filecoin_mainnet",
"storage_price":<PHONE_NUMBER>0
}
}
}


readme link broken

thanks for all your hard work
the "Retrieve the user's first deep linking params"
https://github.com/BranchMetrics/react-native-branch-deep-linking#retrieve-session-install-or-open-parameters

in the readme should be:
https://github.com/BranchMetrics/react-native-branch-deep-linking#retrieve-session-install-or-open-params

Thats for pointing it out. We will correct it


Dynamic base-path

Question
How to sent dynamic basepath?
I've seen on this link https://developers.cloudflare.com/stream/uploading-videos/upload-video-file#nodejs-example
 var options = {
    endpoint: "https://api.cloudflare.com/client/v4/accounts/{ACCOUNT ID}/stream",
    headers: {
      'Authorization': 'Bearer $TOKEN',
    }
     ....
 }

They've added  /{ACCOUNT ID}/stream on -base-path , How it is possible?... do you have any option for that?
Setup details
Please provide following details, if applicable to your situation:

Operating System: Linux
Used tusd version: 1.0
Used tusd data storage: AWS S3
Used tusd configuration: [-s3-bucket,-s3-endpoint,-s3-object-prefix,-max-size,-timeout,-port,-hooks-http,-hooks-http-retry,-hooks-http-backoff,-hooks-enabled-events ,-behind-proxy]
Used tus client library: tus-js-client

This is not possible with standalone tusd. I am not sure how Cloudflare does it since I am not sure whether they are using tusd or some other tus server. However, in theory you can use a reverse proxy before tusd to rewrite the dynamic URL into a "static" URL pointing to tusd. In addition, the proxy could store the account ID for the URL in a header, which can then by consumed in the hooks for tusd. At least, I think this should work.

Couldn't this also be solved by supporting #332?

I don't think #332 would help. Since you are already rewriting the URL using a proxy, the easiest approach is likely to also use the proxy to rewrite the Location header.

Closing this issue due to inactivity. Feel free to leave a comment if you want to continue the discussion :)


chore: add unconvert to linters and address related issues

Fixed some typo by the way.

I think we could comment the lint for now. I did not fix such issue before.

Thanks for your contribution! :tada: :+1:


Compact is misspelled as compcat in NavigationUiTest.kt

compcatWidth_mediumHeight_showsNavigationBar is misspelled in NavigationUiTest.kt which should actually be compactWidth_mediumHeight_showsNavigationBar.

Fixed with #511 , thank you!


geometry-transform support for linear

I am not sure if that is possible or how we would write it but it would be great to be able to do it.
My use case is mostly with translate which i would like to be linear.

geometry-transform is handled when tiles are loaded, not during rendering. So it is not currently possible to make it depend on [view::zoom].

@mtehver understood. So you understand the reasoning is that line-offset does not render well in some cases (joins).


Very slow speed of writing files to storage

We have already opened a ticket https://github.com/chrislusf/seaweedfs/issues/1977, but have not received any recommendations on setting up seaweedfs or setting up the OS for this.
In this ticket I will write in more detail what is and what you want to get.
Volume.server config:
2 servers:
n102: 48 cores, 512 gigabytes of RAM, 36 disks of 14 terabytes, paired in raid1 (18 arrays), 10 gigabits network
n103: 36 cores, 512 gigabytes of RAM, 36 disks of 14 terabytes, paired in raid1 (18 arrays), 10 gigabits network
swfs-master-3: virtual machine, 4 cores, 4 gigabytes of RAM, used only as a master.
Each array is one volume, the maximum number of volumeid is 12000. Each volumeid is 1 gigabyte
Everything is started using systemd commands
ExecStart=/usr/local/bin/weed master -defaultReplication=010 -port=9333 -peers=n102.unim.internal:9333,n103.unim.internal:9333,swfs-master-3.unim.internal:9333 -volumeSizeLimitMB=1024 -ip=n102.unim.internal -metrics.address=n102.unim.internal:9091 for the master and
ExecStart=/usr/local/bin/weed volume -dataCenter=netrack -rack=n102 -port=11002 -port.public=11002 -mserver=n102.unim.internal:9333,n103.unim.internal:9333,swfs-master-3.unim.internal:9333 -ip=n102.unim.internal -max=12000 -dir=/mnt/disk2/swfs for volumes.
Currently, 155000 volumeid is used on each server with a replication factor of 010.
The storages are fully replicated (it was long and difficult, but we did it).
Problem:
Very slow speed of writing files to storage (used directly by seaweedfs api, example request - curl --location --request POST 'http://master.example.com:9333/submit' --from 'file = @ "filename.jpg "') at QPS, starting from ~ 1200-1500 requests per second.
If you turn off half (8-9) volumes on n103, then the write speed becomes acceptable.
What can be configured, modified so that there are no problems with the speed of writing and reading?
PS: If you need additional data - tell me, I will add

Have you tried setting a larger volumeSizeLimitMB?
If you are benchmarking, master volume assignment could be the bottleneck for two reasons:

Assign operation in master is blocking, sometimes it is very time consuming. A small size volume like 1GB could be filled up in a few seconds (in a benchmark scene) and all write requests  have to wait for another few seconds to be handled.

Many internal operation in master is O(n), n stands for number of volumes you have.

By the way, I implement an ahead of time volume assign in my fork to avoid the previous issue.
I'll send a PR if the community is interested. @chrislusf

By the way, I implement an ahead of time volume assign in my fork to avoid the previous issue.
I'll send a PR if the community is interested. @chrislusf

Would like to see how you avoid the problem that a volume may be filled up.

Have you tried setting a larger volumeSizeLimitMB?
If you are benchmarking, master volume assignment could be the bottleneck for two reasons:

Assign operation in master is blocking, sometimes it is very time consuming. A small size volume like 1GB could be filled up in a few seconds (in a benchmark scene) and all write requests  have to wait for another few seconds to be handled.
Many internal operation in master is O(n), n stands for number of volumes you have.

Is there a way to combine volumes in this case?
We have 75% busy in each volumeserver and I do not fully understand how we can increase the volume size limit without any problems

Is there a way to combine volumes in this case?

Can not.

closing if not more updates here.


Protected Routes for Admin Pages

Please implement protected routes for all the existing admin routes (the master teacher routes/pages still need to be created)

Area management
People (both tabs)
area details
any of the site-specific pages

/cib admin-protected-routes

Branch 86-admin-protected-routes created!


[feat] Can developers decide whether to use native or embedded Webviews

Describe the problem
Sometimes dealing with compatibility is troublesome, can you decide whether to embed Chromium or safari webview according to the configuration, like electron embed Chromium
Describe the solution you'd like
Developers can configure whether to embed Chromium or safari on demand
Alternatives considered
No response
Additional context
No response

We only support using native webviews through https://github.com/tauri-apps/wry atm, supporting an embedded chromium or another renderer is a tremendous amount of work that we don't have, but hopefully in the future we can use Servo as an alternative renderer (probably with an embedded option as well).
For now, only Webview2 (chromium) can be embedded on Windows though webviewInstallMode: "fixedRuntime" see https://tauri.app/v1/api/config#windowsconfig.webviewinstallmode and on Linux, you can use the generated AppImage which embeds the webkit2gtk webview as well.


Instagram issue in 1.7.25

Ripme version: 1.7.25
Java version:
Operating system: Windows
Exact URL you were trying to rip when the problem occurred:
Please include any additional information about how to reproduce the problem:

Expected Behavior
To download instagram images.
Actual Behavior
When ripping instagram with the new update it's telling me the photo has already have been ripped when in fact they haven't and when I turn off save URL's it then just circles through the pages without downloading anything.
So it downloads 12 images and stops and just then circles through the pages.

i'm having the same issue, i only get the first 12 pics/videos

the same thing happened with jdownloader, could this be an api issue ?

This is a dupe of #474
@darko1x

could this be an api issue

Yup. Ripme changed their JSON structure as well as what endpoint you call to get the next page

This should be fixed in 1.7.26


release: 0.3.2

Automated Release PR
0.3.2 (2024-05-18)
Build

generate code coverage with sonarscanner (#58) (7d6ac56)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/khavishbhundoo/callmytrade-api/releases/tag/0.3.2 :sunflower:


Remove dependency on ramda

I know you're cherry picking the curry function but ramda is a bit big for just the one function.

Yes. You are right. But it is a fine curry function :sweat:

Haha I'd be willing to rewrite it if you want.

Please
On Fri, Apr 15, 2016, 12:15 PM Texas Toland<EMAIL_ADDRESS>wrote:

Haha I'd be willing to rewrite it if you want.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/paldepind/union-type/issues/37#issuecomment-210603699

Ok :smile: We could copy and paste the curry function into union-type.

I took a look and it'd be better to implement the subset of functionality you're using.

I would highly approve of this. Also, it would be really nice to provide the Ramda.T function on this lib. It could be called Type.Any, which would read really well imo.
var List = Type({
  Nil: {},
  Cons: {
    head: Type.Any,
    tail: undefined
  }
});

Maybe even a Type.Self alias which is just undefined for recursive types.


Add Recently Added section to Home and Community pages and make number of items configurable

Is your feature request related to a problem? Please describe.
In DSpace 7, Recently Added items (which are not labeled as such, only "Browse") appear only in Collection pages, not the Home or Community pages. Initially there are 5 items displayed. Clicking on the page links takes one to the next page of 5 items.

Describe the solution you'd like
In DSpace 6 XMLUI, Recently Added items display on the Home page, Community, and Collection pages. Initially there are a configurable number of items in the section, (recentSubmissionConfiguration, https://wiki.lyrasis.org/display/DSDOC6x/Discovery#Discovery-CustomizingtheRecentSubmissionsdisplay). Clicking on the arrows takes one to a page with the next 20 items.

One idea is to implement this section as a Browse by reverse submit or accession date. Provide a configuration of how many items to include in the initial display. On succeeding pages of results, include the same user configuration that appears on the browse by pages. This will allow the user to set how many items to display.

Describe alternatives or workarounds you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

This appears to be a duplicate of #667 .  Some early work has already begun on this feature by a volunteer, but it's unclear when it'll be ready.  Some screenshot examples are in that other ticket.
I'm closing this ticket as duplicate as discussion should move to the open ticket.


HSH-229 add eslint configuration to the backend code

HSH-229
https://hashstack.atlassian.net/browse/HSH-229
add eslint configuration to the backend code

@Shrutika-hashstack Please raise a ticket in Jira to link this commit with.


[CMS] ssbuttons insert media from the web dysfunctional button

When inserting media to a rich text field via the "From the web" option, if I accidentally enter an invalid URI the "Add URL" button never becomes available again after the error is shown.
To reproduce:
Fresh 3.6.1 install
Open admin/pages/edit/show/1
Open the insert media dialog on the Content field
Wait for it to finish loading
Click the "From the web" tab
Enter "asdf" into the input
Click "Add URL"
See the error notice top-right of viewport.
"Add URL" still displays as unavailable/processing
Note: if one then enters the URI of a valid and accessible image file and clicks the unabsorbed button, it will function as expected. This appears to be a presentational issue only, but is poor usability.
It is also possible to launch multiple requests by double (or e.g. hextuple) clicking the Add button.

This doesn't appear to affect SS4.
Unfortunately, Silverstripe CMS 3 has entered limited support in June 2018. This means we'll only be fixing critical bugs and security issues for Silverstripe CMS 3 going forward.
You can read the Silverstripe CMS Roadmap for more information on our support commitments.


fix(pr-check): reevaluate checks when the base branch of a pull request was changed

Fixes #223

:tada: This PR is included in version 1.20.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


indexer: initial setup

This sets up an iron-indexer binary, which takes a toml configuration file
The indexer code is heavily based off of @joshstevens19 's reth-indexer, but we couldn't use it directly because we'll be indexing slightly different things (and performance certainly won't be the same, which we're fine with)
For now this doesn't actually index anything (I'm dealing with a bug, either on reth itself or in my node's config, currently re-syncing to double-check). It just loops from a specific block and logs any tx it finds where either from or to are from a given whitelist of addresses
this is a smaller piece in the larger #502

Same applies
https://github.com/iron-wallet/iron/issues/502#issuecomment-1826883198


jenkins: openstack-diskimage-builder: Add some popular dib elements

Add some popular elements to the generated image to make sure that
openSUSE plays well with them. These elements are also used by the
OPNFV openSUSE Jenkins jobs.

deploying..

@dirkmueller this currently fails because of a recent breakage in the dib-python element. I have posted a fix https://review.openstack.org/410639.That was the motivation for this pull request :)

@dirkmueller that has been fixed upstream so it should be good to be merged now.


Release prometheus docs

@Mojachieee I realise all your etcd changes are on this PR too, are you ok with us merging to main ?


chore: change default endpoint to use non deprecated version

Since there has been no movement on https://github.com/fazibear/airbrakex/pull/59 I preemptively are updating our fork of the repo so we can start doing this and not scramble near the end of the month.

We actually don't need this anymore so I'm closing it


Footer design updated

What is the change?
updated my old footer design
Related issue?
issue related to #80
How was it tested?
tested on VS code and Google Crome
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x ] Have you followed the Contribution Guidelineswhile contributing.
[ x] Have you checked there aren't other open Pull Requests for the same update/change?
[ x] Have you made corresponding changes to the documentation?
[x ] Have you tested the code before submission?
[ x Have you formatted your code ? (You can use any html,css beautifier)
[x ] My changes generates no new warnings.
[x ] I'm Hacktoberfest'21 contributor.
[x] I have commented my code, particularly in hard-to-understand areas.
Here the tested ss

GIF/video of the working of component you created:
Add here the GIF you created.

Pls consider my updated footer design PR #114  for the issue #80

@siddhi-244 completed the changes pls consider the updated PR for the issue #80 . Branch has one conflict how can I resolve it ?? Pls guide.

Resolve conflicts


TypeScript types for install config are too strict.

FakeTimers version : 7.1.1
Environment : Node.js (Jest)
Example URL : Codesandbox sample
Other libraries you are using: TypeScript v4.3.2

What did you expect to happen?
The FakeTimers.install method should be usable with a partial config object, i.e. only specifying now and using the default values for other configuration properties. In the newest TypeScript version it appears that a full object needs to be passed when using the install method.
The generated Config type appears to have all properties marked as non-optional. This appears to be similar to the already fixed issue #352.
What actually happens
Calling install in the following way:
import FakeTimers from "@sinonjs/fake-timers";

FakeTimers.install({ now: 1 });

Leads to the following TypeScript error:
Argument of type '{ now: number; }' is not assignable to parameter of type 'Config'.
Type '{ now: number; }' is missing the following properties from type 'Config': toFake, loopLimit, shouldAdvanceTime, advanceTimeDeltats(2345)

How to reproduce
You can find an example in this Codesandbox

Hi, it seems the Config object should have optionals everywhere. Not sure  why that wasn't done to begin with. AFAIK, all of the props in https://github.com/henhal/fake-timers/blob/cdd0391fa39391f102bafc7678df9d060386253f/src/fake-timers-src.js#L45 should have [] added to make them optional.
- * @property {number|Date} now a number (in milliseconds) or a Date object (default epoch)
+ * @property [{number|Date}] now a number (in milliseconds) or a Date object (default epoch)

That seems fixable :)

Yup, just made a test
$ npx tsc index.ts
index.ts:3:20 - error TS2345: Argument of type '{ now: number; }' is not assignable to parameter of type 'Config'.
  Type '{ now: number; }' is missing the following properties from type 'Config': toFake, loopLimit, shouldAdvanceTime, advanceTimeDelta

3 FakeTimers.install({ now: 1 });
                     ~~~~~~~~~~

Found 1 error.

# adding the brackets in my local fake-timers
$ npx tsc index.ts

$ echo success!


JioTV Channels are buffering

Your Environment

Jiotv
2.0.0
Kodi 19
Android TV
India

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See an error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Debug log

The debug log can be found from this link:

Use the below backup file to configure your KODI to perform efficiently.
https://github.com/vivin-neelankavil/Kodi-JioTv