(Material3) DatePicker Divider cannot be removed or styled, it does not fit with a custom header background

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
When styling the DatePicker header background to some other color than default surface color and using M3 mode, the DatePicker is left with an extra not needed Divider separator that looks out of place.
Run the attached sample to see the issue.
Expected results
Expect to be able to change the background color of DatePicker from default, and for it too have a uniform header color, like so:

Material 3
Material 2

Actual results
Actual result has a Divider that looks totally out of place when the header color is not surface colored. Only M3 has the out of place Divider when using none default header color, M2 mode does not.

Material 3 - FAIL
Material 2 - OK

Issue cause
The Divider is hard coded to be shown in M3 mode and cannot be modified.
Here:
https://github.com/flutter/flutter/blob/fa117aad283ba930a7a79b472843b19e52f543bd/packages/flutter/lib/src/material/date_picker.dart#L678
And here:
https://github.com/flutter/flutter/blob/fa117aad283ba930a7a79b472843b19e52f543bd/packages/flutter/lib/src/material/date_picker.dart#L689
Proposal
It needs to be possible to control the Divider via widget and theme properties.

Divider should use no padding height/width, so it touches the header area. This way, it can, if so desired, also be used as a line between header and calendar area when their colors are different.
It should be possible to change the color of the Divider so it can if desired be removed by making it transparent (expected case above), alternatively make it more or less prominent (below).

Subtle Divider
Prominent Divider

Code sample
Code sample
// MIT License
//
// Copyright (c) 2023 Mike Rydstrom
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.
 IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';

// A seed color for the M3 ColorScheme.
const Color seedColor = Color(0xFF6750A4);
// Make M3 ColorSchemes from a seed color.
final ColorScheme schemeLight = ColorScheme.fromSeed(
  brightness: Brightness.light,
  seedColor: seedColor,
);
final ColorScheme schemeDark = ColorScheme.fromSeed(
  brightness: Brightness.dark,
  seedColor: seedColor,
);

// Example theme
ThemeData theme(ThemeMode mode, ThemeSettings settings) {
  final ColorScheme colorScheme =
      mode == ThemeMode.light ? schemeLight : schemeDark;

  return ThemeData(
    colorScheme: colorScheme,
    useMaterial3: settings.useMaterial3,
    visualDensity: VisualDensity.standard,
    datePickerTheme: settings.useCustomTheme
        ? DatePickerThemeData(
            headerBackgroundColor: colorScheme.tertiaryContainer,
            headerForegroundColor: colorScheme.onTertiaryContainer,
          )
        : null,
  );
}

void main() {
  runApp(const IssueDemoApp());
}

class IssueDemoApp extends StatefulWidget {
  const IssueDemoApp({super.key});

  @override
  State<IssueDemoApp> createState() => _IssueDemoAppState();
}

class _IssueDemoAppState extends State<IssueDemoApp> {
  ThemeMode themeMode = ThemeMode.light;
  bool longLabel = false;
  TextDirection textDirection = TextDirection.ltr;
  ThemeSettings settings = const ThemeSettings(
    useMaterial3: true,
    useCustomTheme: true,
  );

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      themeMode: themeMode,
      theme: theme(ThemeMode.light, settings),
      darkTheme: theme(ThemeMode.dark, settings),
      home: Directionality(
        textDirection: textDirection,
        child: Scaffold(
          appBar: AppBar(
            title: settings.useMaterial3
                ? const Text("DatePicker Header & Divider (Material 3)")
                : const Text("DatePicker Header & Divider (Material 2)"),
            actions: [
              IconButton(
                icon: settings.useMaterial3
                    ? const Icon(Icons.filter_3)
                    : const Icon(Icons.filter_2),
                onPressed: () {
                  setState(() {
                    settings =
                        settings.copyWith(useMaterial3: !settings.useMaterial3);
                  });
                },
                tooltip: "Switch to Material ${settings.useMaterial3 ? 2 : 3}",
              ),
              IconButton(
                icon: themeMode == ThemeMode.dark
                    ? const Icon(Icons.wb_sunny_outlined)
                    : const Icon(Icons.wb_sunny),
                onPressed: () {
                  setState(() {
                    if (themeMode == ThemeMode.light) {
                      themeMode = ThemeMode.dark;
                    } else {
                      themeMode = ThemeMode.light;
                    }
                  });
                },
                tooltip: "Toggle brightness",
              ),
            ],
          ),
          body: HomePage(
            settings: settings,
            onSettings: (ThemeSettings value) {
              setState(() {
                settings = value;
              });
            },
            longLabel: longLabel,
            onLongLabel: (bool value) {
              setState(() {
                longLabel = value;
              });
            },
            textDirection: textDirection,
            onTextDirection: (TextDirection value) {
              setState(() {
                textDirection = value;
              });
            },
          ),
        ),
      ),
    );
  }
}

class HomePage extends StatelessWidget {
  const HomePage({
    super.key,
    required this.settings,
    required this.onSettings,
    required this.longLabel,
    required this.onLongLabel,
    required this.textDirection,
    required this.onTextDirection,
  });
  final ThemeSettings settings;
  final ValueChanged<ThemeSettings> onSettings;
  final bool longLabel;
  final ValueChanged<bool> onLongLabel;
  final TextDirection textDirection;
  final ValueChanged<TextDirection> onTextDirection;

  @override
  Widget build(BuildContext context) {
    return ListView(
      children: [
        const Padding(
          padding: EdgeInsets.all(16.0),
          child: Text(
            "The DatePicker's Divider in M3 mode is hard coded, it cannot be "
            'removed or styled.\n'
            'It fits very poorly when using another color than surface '
            'color on the DatePicker header, creating an extra not needed '
            'line.\n',
          ),
        ),
        SwitchListTile(
          title: const Text('Enable DatePicker custom background color'),
          value: settings.useCustomTheme,
          onChanged: (bool value) {
            onSettings(settings.copyWith(useCustomTheme: value));
          },
        ),
        const Padding(
          padding: EdgeInsets.symmetric(horizontal: 16.0),
          child: Column(
            children: [
              SizedBox(height: 16),
              DatePickerDialogShowcase(),
              SizedBox(height: 16),
              ShowColorSchemeColors(),
            ],
          ),
        ),
      ],
    );
  }
}

class DatePickerDialogShowcase extends StatelessWidget {
  const DatePickerDialogShowcase({super.key});

  Future<void> _openDialog(BuildContext context) async {
    await showDialog<void>(
      context: context,
      useRootNavigator: false,
      builder: (BuildContext context) => DatePickerDialog(
        initialDate: DateTime.now(),
        firstDate: DateTime(1930),
        lastDate: DateTime(2050),
      ),
    );
  }

  @override
  Widget build(BuildContext context) {
    return Column(
      children: <Widget>[
        AbsorbPointer(
          child: DatePickerDialog(
            initialDate: DateTime.now(),
            firstDate: DateTime(1930),
            lastDate: DateTime(2050),
          ),
        ),
        TextButton(
          child: const Text(
            'Show DatePickerDialog',
            style: TextStyle(fontWeight: FontWeight.bold),
          ),
          onPressed: () async => _openDialog(context),
        ),
      ],
    );
  }
}

/// A Theme Settings class to bundle properties we want to modify on our
/// theme interactively.
@immutable
class ThemeSettings with Diagnosticable {
  final bool useMaterial3;
  final bool useCustomTheme;

  const ThemeSettings({
    required this.useMaterial3,
    required this.useCustomTheme,
  });

  /// Flutter debug properties override, includes toString.
  @override
  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
    super.debugFillProperties(properties);
    properties.add(DiagnosticsProperty<bool>('useMaterial3', useMaterial3));
    properties.add(DiagnosticsProperty<bool>('useCustomTheme', useCustomTheme));
  }

  /// Copy the object with one or more provided properties changed.
  ThemeSettings copyWith({
    bool? useMaterial3,
    bool? useCustomTheme,
    bool? useIndicatorWidth,
    bool? useTileHeight,
  }) {
    return ThemeSettings(
      useMaterial3: useMaterial3 ?? this.useMaterial3,
      useCustomTheme: useCustomTheme ?? this.useCustomTheme,
    );
  }

  /// Override the equality operator.
  @override
  bool operator ==(Object other) {
    if (identical(this, other)) return true;
    if (other.runtimeType != runtimeType) return false;
    return other is ThemeSettings &&
        other.useMaterial3 == useMaterial3 &&
        other.useCustomTheme == useCustomTheme;
  }

  /// Override for hashcode, dart.ui Jenkins based.
  @override
  int get hashCode => Object.hashAll(<Object?>[
        useMaterial3.hashCode,
        useCustomTheme.hashCode,
      ]);
}

/// Draw a number of boxes showing the colors of key theme color properties
/// in the ColorScheme of the inherited ThemeData and its color properties.
class ShowColorSchemeColors extends StatelessWidget {
  const ShowColorSchemeColors({super.key, this.onBackgroundColor});

  /// The color of the background the color widget are being drawn on.
  ///
  /// Some of the theme colors may have semi transparent fill color. To compute
  /// a legible text color for the sum when it shown on a background color, we
  /// need to alpha merge it with background and we need the exact background
  /// color it is drawn on for that. If not passed in from parent, it is
  /// assumed to be drawn on card color, which usually is close enough.
  final Color? onBackgroundColor;

  // Return true if the color is light, meaning it needs dark text for contrast.
  static bool _isLight(final Color color) =>
      ThemeData.estimateBrightnessForColor(color) == Brightness.light;

  // On color used when a theme color property does not have a theme onColor.
  static Color _onColor(final Color color, final Color bg) =>
      _isLight(Color.alphaBlend(color, bg)) ? Colors.black : Colors.white;

  @override
  Widget build(BuildContext context) {
    final ThemeData theme = Theme.of(context);
    final ColorScheme colorScheme = theme.colorScheme;
    final bool useMaterial3 = theme.useMaterial3;
    const double spacing = 4;

    // Grab the card border from the theme card shape
    ShapeBorder? border = theme.cardTheme.shape;
    // If we had one, copy in a border side to it.
    if (border is RoundedRectangleBorder) {
      border = border.copyWith(
        side: BorderSide(
          color: colorScheme.outlineVariant,
          width: 1,
        ),
      );
      // If
    } else {
      // If border was null, make one matching Card default, but with border
      // side, if it was not null, we leave it as it was.
      border ??= RoundedRectangleBorder(
        borderRadius: BorderRadius.all(Radius.circular(useMaterial3 ? 12 : 4)),
        side: BorderSide(
          color: colorScheme.outlineVariant,
          width: 1,
        ),
      );
    }

    // Get effective background color.
    final Color background =
        onBackgroundColor ?? theme.cardTheme.color ?? theme.cardColor;

    // Wrap this widget branch in a custom theme where card has a border outline
    // if it did not have one, but retains its ambient themed border radius.
    return Theme(
      data: Theme.of(context).copyWith(
        cardTheme: CardTheme.of(context).copyWith(
          elevation: 0,
          surfaceTintColor: Colors.transparent,
          shape: border,
        ),
      ),
      child: Column(
        crossAxisAlignment: CrossAxisAlignment.start,
        children: <Widget>[
          Padding(
            padding: const EdgeInsets.symmetric(vertical: 8),
            child: Text(
              'ColorScheme Colors',
              style: theme.textTheme.titleMedium,
            ),
          ),
          Wrap(
            alignment: WrapAlignment.start,
            crossAxisAlignment: WrapCrossAlignment.center,
            spacing: spacing,
            runSpacing: spacing,
            children: <Widget>[
              ColorCard(
                label: 'Primary',
                color: colorScheme.primary,
                textColor: colorScheme.onPrimary,
              ),
              ColorCard(
                label: 'on\nPrimary',
                color: colorScheme.onPrimary,
                textColor: colorScheme.primary,
              ),
              ColorCard(
                label: 'Primary\nContainer',
                color: colorScheme.primaryContainer,
                textColor: colorScheme.onPrimaryContainer,
              ),
              ColorCard(
                label: 'onPrimary\nContainer',
                color: colorScheme.onPrimaryContainer,
                textColor: colorScheme.primaryContainer,
              ),
              ColorCard(
                label: 'Secondary',
                color: colorScheme.secondary,
                textColor: colorScheme.onSecondary,
              ),
              ColorCard(
                label: 'on\nSecondary',
                color: colorScheme.onSecondary,
                textColor: colorScheme.secondary,
              ),
              ColorCard(
                label: 'Secondary\nContainer',
                color: colorScheme.secondaryContainer,
                textColor: colorScheme.onSecondaryContainer,
              ),
              ColorCard(
                label: 'on\nSecondary\nContainer',
                color: colorScheme.onSecondaryContainer,
                textColor: colorScheme.secondaryContainer,
              ),
              ColorCard(
                label: 'Tertiary',
                color: colorScheme.tertiary,
                textColor: colorScheme.onTertiary,
              ),
              ColorCard(
                label: 'on\nTertiary',
                color: colorScheme.onTertiary,
                textColor: colorScheme.tertiary,
              ),
              ColorCard(
                label: 'Tertiary\nContainer',
                color: colorScheme.tertiaryContainer,
                textColor: colorScheme.onTertiaryContainer,
              ),
              ColorCard(
                label: 'on\nTertiary\nContainer',
                color: colorScheme.onTertiaryContainer,
                textColor: colorScheme.tertiaryContainer,
              ),
              ColorCard(
                label: 'Error',
                color: colorScheme.error,
                textColor: colorScheme.onError,
              ),
              ColorCard(
                label: 'on\nError',
                color: colorScheme.onError,
                textColor: colorScheme.error,
              ),
              ColorCard(
                label: 'Error\nContainer',
                color: colorScheme.errorContainer,
                textColor: colorScheme.onErrorContainer,
              ),
              ColorCard(
                label: 'onError\nContainer',
                color: colorScheme.onErrorContainer,
                textColor: colorScheme.errorContainer,
              ),
              ColorCard(
                label: 'Background',
                color: colorScheme.background,
                textColor: colorScheme.onBackground,
              ),
              ColorCard(
                label: 'on\nBackground',
                color: colorScheme.onBackground,
                textColor: colorScheme.background,
              ),
              ColorCard(
                label: 'Surface',
                color: colorScheme.surface,
                textColor: colorScheme.onSurface,
              ),
              ColorCard(
                label: 'on\nSurface',
                color: colorScheme.onSurface,
                textColor: colorScheme.surface,
              ),
              ColorCard(
                label: 'Surface\nVariant',
                color: colorScheme.surfaceVariant,
                textColor: colorScheme.onSurfaceVariant,
              ),
              ColorCard(
                label: 'onSurface\nVariant',
                color: colorScheme.onSurfaceVariant,
                textColor: colorScheme.surfaceVariant,
              ),
              ColorCard(
                label: 'Outline',
                color: colorScheme.outline,
                textColor: colorScheme.background,
              ),
              ColorCard(
                label: 'Outline\nVariant',
                color: colorScheme.outlineVariant,
                textColor: colorScheme.onBackground,
              ),
              ColorCard(
                label: 'Shadow',
                color: colorScheme.shadow,
                textColor: _onColor(colorScheme.shadow, background),
              ),
              ColorCard(
                label: 'Scrim',
                color: colorScheme.scrim,
                textColor: _onColor(colorScheme.scrim, background),
              ),
              ColorCard(
                label: 'Inverse\nSurface',
                color: colorScheme.inverseSurface,
                textColor: colorScheme.onInverseSurface,
              ),
              ColorCard(
                label: 'onInverse\nSurface',
                color: colorScheme.onInverseSurface,
                textColor: colorScheme.inverseSurface,
              ),
              ColorCard(
                label: 'Inverse\nPrimary',
                color: colorScheme.inversePrimary,
                textColor: colorScheme.inverseSurface,
              ),
              ColorCard(
                label: 'Surface\nTint',
                color: colorScheme.surfaceTint,
                textColor: colorScheme.onPrimary,
              ),
            ],
          ),
        ],
      ),
    );
  }
}

/// A [SizedBox] with a [Card] and string text in it. Used in this demo to
/// display theme color boxes.
///
/// Can specify label text color and background color.
class ColorCard extends StatelessWidget {
  const ColorCard({
    super.key,
    required this.label,
    required this.color,
    required this.textColor,
    this.size,
  });

  final String label;
  final Color color;
  final Color textColor;
  final Size? size;

  @override
  Widget build(BuildContext context) {
    const double fontSize = 11;
    const Size effectiveSize = Size(86, 58);

    return SizedBox(
      width: effectiveSize.width,
      height: effectiveSize.height,
      child: Card(
        margin: EdgeInsets.zero,
        clipBehavior: Clip.antiAlias,
        color: color,
        child: Center(
          child: Text(
            label,
            style: TextStyle(color: textColor, fontSize: fontSize),
            textAlign: TextAlign.center,
          ),
        ),
      ),
    );
  }
}

Screenshots or Video
No additional media.
Logs
No logs needed.
Flutter Doctor output
Used Flutter version
Channel master, 3.11.0-5.0.pre.46
Doctor output
flutter doctor -v
[✓] Flutter (Channel master, 3.11.0-5.0.pre.46, on macOS 13.2.1 22D68 darwin-arm64, locale en-US)
    • Flutter version 3.11.0-5.0.pre.46 on channel master at /Users/rydmike/fvm/versions/master
    ! Warning: `dart` on your path resolves to /opt/homebrew/Cellar/dart/2.17.5/libexec/bin/dart, which is not inside your current
      Flutter SDK checkout at /Users/rydmike/fvm/versions/master. Consider adding /Users/rydmike/fvm/versions/master/bin to the front
      of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision fa117aad28 (3 hours ago), 2023-05-11 10:28:08 -0700
    • Engine revision f38f46f66e
    • Dart version 3.1.0 (build 3.1.0-94.0.dev)
    • DevTools version 2.23.1
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform
      update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/rydmike/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2023.1)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 73.0.4
    • Dart plugin version 231.8109.91

[✓] VS Code (version 1.77.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.62.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 13.2.1 22D68 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 113.0.5672.92

[✓] Network resources
    • All expected network resources are available.

</details>

@rydmike  Thanks for the issue, I'll fix this in the morning!


Clicking 'Send API Request' when button is disabled collapses/opens APIDemoPanel

Describe the bug
When browsing generated documentation, if an API Endpoint has required fields that are not filled in and the user clicks 'Send API Request' regardless, the panel will collapse.
Expected behavior
Unsure. Three suggestions:

An error should be displayed
Focus should move that is required should be highlighted
Nothing should happen

Current behavior
The panel collapses
Possible solution
I haven't checked the code, but I imagine the click/tap event is bubbling up to the panel, triggering the collapse
Steps to reproduce

Visit https://docusaurus-openapi.tryingpan.dev/petstore/get-order-by-id
Observe that the API Demo Panel Request field is open, but the Send API Request button is disabled (in this case: a required parameter is not supplied)
Click 'Send API request'

Screenshots

Context
An end user had missed that a field was required, and assumed that hitting 'Send request' would send the request. Instead, the panel collapsed. No response field appeared - which is seems correct (sending a known-bad request wouldn't help much either).
Your Environment

Version used:
True in 1.4.0, so I used the demo in the reproduction steps

Hi @edd, thanks for bringing this to our attention. We will be working on a fix for this as soon as possible 👍

Hi @edd, we've just released a new version of the plugin that solves for this issue. Bear in mind, that we are also planning on an ApiDemoPanel form refactor to handle input validations (as this seems to be the ideal solution). Thank you for your patience! Let us know how the update goes 👍


Update Hey Sophie Luis

closes. #300

Update Luis model for Hey Sophie.

Figure: New example input for the greetings card.

Codecov Report

Merging #450 (fe4db47) into main (6d55724) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #450   +/-   ##
=======================================
  Coverage   32.86%   32.86%
=======================================
  Files          76       76
  Lines        2127     2127
=======================================
  Hits          699      699
  Misses       1428     1428

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d55724...fe4db47. Read the comment docs.


[Draft] fix(l1xdm): run out of gas when executing transferFrom before storing in the failedMessages map

This raises the issue that the attackers can drain all locked funds on L1XDM because the relayMessage doesn't know the withdrawal amount in the L2.


feat(doc): add out path option in config

A config option for forge doc that let's you specify an output path for the doc generation. Continuation work for #2701

needs nightly formatting cargo +nightly fmt


Once fixed, TLS 1.2 issue come back again after few weeks

Hi all
After diagnosing the TLS 1.2 issue using the AzureDevOpsTls12Analysis.ps1 script on my Windows server 2016 (I have three VMs in Azure), the problem was fixed the first time with the generated mitigation scripts Mitigation-NetFramework.ps1 and Mitigation-RegFunctionsDEL.ps1 (run as administrator as suggested in the script output) and a restart was performed. The agent can connect again to azure devops and it shows the green online status.
However, after few weeks, the agent appeared as offline in azure devops and the same problem was diagnosed. I reused the same script (AzureDevOpsTls12Analysis.ps1) with the mitigation script (only Mitigation-RegFunctionsDEL.ps1 was generated this time) to refix the issue. Of course, a restart was required.
Once again, the same issue reappeared 4 or 5 times since the first one last June. Somebody can help to fix this issue once and for all.
Best regards

Are those computers in the Active Directory domain? This seems like AD group policy being applied on your computer from Domain Controller. If not this, there may be other mechanism which applies some policies regularly.
To verify AAD/GPO hypothesis, you can call command "gpupdate /target:computer /force" after fixing most recent issue. If the issue reappears after GPUpdate, you have a proof that this is enforced by DC.
The newest version of AzureDevOpsTls12Analysis.ps1 actually does this check for you and prints "Mitigation was not effective! Local cipher suite list is being overriden by group policies." if enforced.


Automatically collapse comments once they are resolved

Have an unresolved comment on a pull request that is open in VS Code
Click 'Resolve Conversation'
Comment remains open, I still have to manually click collapse

I'd expect that resolving a comment also collapses the comment so that it no longer takes up space, which is what happens on github.com

This is going to need VS Code API to enable collapsing a comment. Just like the tree view, the comment thread collapsible state cannot be modified by the extension once set to prevent conflict between user state and extension state.

The setting to control this is comments.collapseOnResolve. It is true by default.

To verify:

Install GitHub Pull Requests and Issues
Open a PR file and leave a comment
Resolve the comment
Verify that the comment immediately closes
Unresolve the comment
Set "comments.collapseOnResolve": false
Resolve the comment again
Verify that the comment is not closed.

🎉 works well! such a great feature, thank you


feat: change iosModulename to iosModuleName

Camel case iosModuleName

Good stuff, thanks!

Ah I just realized that this is a breakign change


la-go-live

Docs Build status updates of commit 755f43e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/graph-api/rsc/test-resource-specific-consent.md
:bulb:Suggestion
View
Details

msteams-platform/assets/images/e-prescriptions-app-template-admin.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/e-prescriptions-app-template.PNG
:white_check_mark:Succeeded
View

msteams-platform/samples/app-templates.md
:white_check_mark:Succeeded
View

msteams-platform/toolkit/visual-studio-code-overview.md
:white_check_mark:Succeeded
View

msteams-platform/graph-api/rsc/test-resource-specific-consent.md

Line 2, Column 8: [Suggestion-duplicate-titles] Title 'Testing resource-specific consent in Teams - Teams' is duplicated in: 'graph-api/rsc/test-resource-specific-consent.md(2,8), graph-api/rsc/test-rsc-json-file.md(2,8)'. Titles must be unique within a docset.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Run multiple statement

Is there a option to run multiple statements and save those statements to be used in future.
For example

create table emp(name varchar(20)
insert into emp.....
select count(*) from emp

I would like to save all the above statements together and run it all together one after other

Hi @preet20
Which database are you using with SqlPad? Have you tried this already? It looks like it works for MS SQL Server.
Something to consider though... SqlPad runs on the assumption that you'll only ever be returning 1 result set. If you run 2 select queries you may end up with unexpected results.

Hi @preet20 - going to close this issue for now. let me know if you have any more questions about this.


feat: Improved compliance of Encoding APIs

Description of changes
Add the following methods/properties to improve the compliance of Encoding API.

TextEncoder.encoding
TextDecoder.fatal
TextDecoder.ignoreBOM
TextDecoder.encoding
TextDecoder.decode()

And the encoding_rs crate was adopted for simplicity in dealing with various labels of TextDecoder().
Checklist

[x] Created unit tests in tests/unit and/or in Rust for my feature if needed
[x] Ran make fix to format JS and apply Clippy auto fixes
[x] Made sure my code didn't add any additional warnings: make check
[x] Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @richarddavison , Thank you for your always accurate reviews.
All have been corrected, please confirm. :)


Improve script to install Ceph AIO without Vagrant

Add mon_pg_warn_max_per_osd, osd_pool_default_size and osd_pool_default_min_size variables
Add option to configure default pool size
Add option not to install MDS and RGW
Improve ssh_setup to check if file and key already exist
Improve populate_vars for safety rerun for idempotent
Change path of inventory file to where ansible run. So this won't pollute the system
Remove check host key
Remove sudo when install Ansible

Thanks @winggundamth

My first pull request on ceph-ansible project. Thanks @leseb for helping me too :+1:


Siddata caching affects len

When we cache the two methods on the instance, we need to update the initial_len to account for these untracked attributes in the dict.
Long term goal of removing __len__ and __contains__ from this object, it is not a container.

rebased, merging on pass


Added bold, italic and font name to selection layer

style modified on each div to include:

font-weight: bold
font-style: italic

if selected font is bold and/or italic which will allow for the selected text to be styled on a paste.

This builds fine, but I don't have a PDF to check the fix.


elb health checks

failing health checks for some reason so elb won't work

closing because it actually works fine once the instance is up and running long enough to register a health check success.


tag

How does
 tag works in the ContentTools? It dissappear when I click "save".

Hi @SimBioT1954,
Line breaks /
 tags may disappear if they are positioned at the start or the end of a block of text (other than pre-formatted text, e.g
 tags). This is because white-space is trimmed/stripped from the end of text block by default in ContentTools. There is a discussion regarding this behaviour here: https://github.com/GetmeUK/ContentTools/issues/113 and a related stackoverflow post detailing an approach to modify this behaviour should you wish to here: https://stackoverflow.com/questions/36883079/how-to-preserve-multiple-br-when-no-content-before-or-after-with-contenttools/36954440#36954440


Add live testing of Postera API

Description
Fixes #700
Fixes #686
Fixes #633
Developers certificate of origin

[X] I certify that this contribution is covered by the MIT license as defined in our LICENSE and adheres to the Developer Certificate of Origin.

@JenkeScheen note that this PR changes the asapdiscovery postera API slightly, let me know if anything you are using stops working once this is merged and I can help you update it.

Codecov Report

Merging #864 (f6d5d3a) into main (79bef4a) will decrease coverage by 1.31%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

@dotsdl @jthorton @mikemhenry would I be able to snag a review here? Need to get this one in soonish to close of 0.2.2 and finalise #832


Fast aligner

Parallelised solution of the join aligner.
All rows are aligned to the full base feature list at once. The alignment happens iteratively.
In each iteration:

The feature list with the most unaligned rows is chosen as a base list.

the (remaining) features of this feature list are chosen as a base and added to the aligned feature list

the rows from the new base list are removed from the unaligned rows
the remaining unaligned rows are aligned to the full aligned feature list (this is done because the row m/z and rt might change after an alignment)
the rows without an alignmed are used as unaligned rows for the next interation

Realigning on the full feature list is up for debate! Can also just align on the rows of the newly chosen base feature list. What do you think @robinschmid, @tomas-pluskal ?

I think we should not have two modules (Join aligner and Parallel Join aligner) that do exactly the same thing, that is confusing for the user. If this new module generates the same results as the old one, we should remove the old one.

I agree. The results are very similar but not exactly the same, however, because the alignment happens for all raw data files in parallel and not consecutively.

Should i delete the normal join aligner then?

I think so.

Good?

The join aligner produces reproducible results when run on the same feature lists in the same sorting....
I guess the fast aligner does not. This is a problem for some people - although I do not know how reproducible we are overall.

Did you try it?
I just ran the aligner 4 times in a row and got the same number of features every time.

Only the scoring happens in parallel. The actual assignment is sequential.

I also tested it and it seems to prodcue reproducible results.

Yes i tried that, the total number of rows is different, but not by much.

This would be fine by me  then


Option to prevent Vite clearScreen on start-up

Environment
Nuxt CLI v3.0.0-27307420.6a25d3e                                                                                22:48:45
RootDir: /srv/codelaunch                                                                                22:48:46
Nuxt project info:                                                                                22:48:46

Operating System: Linux
Node Version:     v14.17.6
Nuxt Version:     3.0.0-27307420.6a25d3e
Package Manager:  unknown
Bundler:          Vite
User Config:      srcDir, server, vite
Runtime Modules:  -
Build Modules:    -

Reproduction
Run npm run dev
Describe the bug
Vite has a clearScreen CLI option which defaults to true.
In an attached docker-compose environment, it's quite annoying to have Vite clear the screen on container start-up, if you're looking for logs from other services, or initial container logs before vite starts, etc.
Nuxt should be able to proxy the --clearScreen false CLI option to vite. I suppose something like nuxi dev --clearScreen false ?
Additional context
https://vitejs.dev/config/#clearscreen
Logs
No response

You should be able to configure this like so:
import { defineNuxtConfig } from 'nuxt3'

export default defineNuxtConfig({
  vite: {
    clearScreen: false
  }
})

I am using Nuxt 3.2.3 and this still does not work... Using yarn dev (which calls nuxt dev) always clears the screen :-1:


Cannot find name 'Locale' - error TS2304

Hi,
Getting the following error after installing the Package:
node_modules/@worktile/gantt/utils/date.d.ts:16:18 - error TS2304: Cannot find name 'Locale'.
(The error code occurs another few times on the file at : [date.d.ts:35:18, date.d.ts:43:18, date.d.ts:51:18])
I have tried searching through the repo but can't find use of 'locale' to try and resolve it.
Any assistance on this would be fantastic.
Thanks

Hi,
I have resolved this now by doing the following.
Add the below code to the @worktile/gantt/utils/date.d.ts file:
import { Locale } from 'date-fns';`
This resolved the issue, but have I missed something or is there a reason this isn't in the file?
Thanks!

I also encountered this error with Angular 17.
As a workaround, you can disabled lib check in your tsconfig.json
"compilerOptions": {
...
"skipLibCheck": true,
},

The mentioned workarounds do not work here. I'm on angular 16.0.0 and used<EMAIL_ADDRESS>

fixed at 17.0.0-next.0 version

There is still this problem on version 17.0.0-next.0 and it can be solved by adding "skipLibCheck": true to compilerOptions.


Missing parameter call in MultiSim plot() method

In the MultiSim plot() method (in run.py) when called to make a single line plot the show_args argument is not passed to the Sim plot() method.
To reproduce: run some simulations with interventions using MultiSim.  The vertical dashed lines will be plotted at each intervention even when show_args turns them off:
sim = cv.Sim(interventions=....)
msim = cv.MultiSim(sim)
msim.reduce()
msim.plot(show_args={'interventions':False})

To fix, in the first lines of code in the MultiSim plot() method just add the show_args keyword to the call to the Sim plot() method:
if not plot_sims and self.which in ['combined', 'reduced']:
   fig = self.base_sim.plot(to_plot=to_plot, colors=colors, show_args=show_args, **kwargs)

Thanks @bu-bgregor ! We're working on a bugfix release currently which should be merged in the next week or so.

Fixed


net/http: error messages are not introspectable

I just reviewed a PR with the line case err.Error() == "http: can't write HTTP request on broken connection". That's brittle code, and it's hard to test in a way that ensures it stays in sync with any changes to the error message wording in net/http--but there's no way to improve upon it given the errors the http package emits.
Possible improments:

net/http could predeclare its errors
or make a custom error type

Any mechanism is fine as long as it lets the compiler check that people are referring to the error they intend to.
(I realize this is probably low priority.)

Too late for Go 1.5.

Closing as duplicate of #9405 (which has more detail & discussion).


Fix CallKit audio session late init

Fix a bug in Element iOS : when the user answer a VoIP call from the "Answer" button in Element room timeline, very often, his correspondant can't hear him.
It's because the Audio Session is initialized too late. See https://developer.apple.com/forums/thread/64544 (7th post from Apple Engineer)
See this issue in Element Github: https://github.com/element-hq/element-ios/issues/7721

@pixlwave Can you have a look at this fix.
It's quite urgent Tchap side.
Thanx.


Add v4.4 manual role

Hi @schmalliso , as we discussed here's a PR to create the v4.4 role for the manual.
Let me know if I need to fix anything. Thank you!

@jeff-allen-mongo THANK YOU! It'll be in our next release :)


Update static regions, versions, etc. in OCI and OKE drivers in 2.4.

Proposed changes

Update the newly available OKE versions and regions in the 2.4-fixes branch to the OKE and OCI choices manually while we wait for the PRs to pull these values in dynamically to be merged (OKE, and OCI).
Types of changes

New feature
Linked Issues

https://github.com/rancher/rancher/issues/28493
https://github.com/rancher/ui/pull/4135
Further comments

This PR is just a back-port of this PR into the 2.4-fixes branch.

@westlywright

@jlamillan thanks!


Version is examples is incorrect

This documentation is listed under 7.1-preview but examples are shown using version 6.1-preview

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ff22a24-a423-d794-2d80-9256298e1eaa
Version Independent ID: 4782ca92-bfc8-abeb-8f7b-98578d8e88e8
Content: Token Lifecycle Management REST API for Azure DevOps Services - Azure DevOps Services REST API
Content Source: docs-ref-conceptual/7.1/tokens/index.md
Product: devops
Technology: devops-ref
GitHub Login: @wnjenkin
Microsoft Alias: sergiikozak

Thank you for reporting this issue, the example has now been fixed to take the latest version.


Add support for embit EMB-Raspi-LR130x-Cape with LR1302 concentrator card

Tested and working on a Raspberry Pi Zero with Chirpstack Gateway OS.
The Embit hardware can supposedly be found in some commercial gateways, such as the Controllino Hotspot and (probably) the Arduino Pro Gateway, which are now readily available on the used market and thus worthwile to support.
The Raspbery Pi HAT (or "Cape", as Embit calls it): http://www.embit.eu/products/oem-gateways/accessories/emb-raspi-lr130x-cape/
The concentrator card: http://www.embit.eu/products/oem-gateways/emb-lr1302-mpci-e-prova/
The concentrator card uses an SX1250, nothing special. Initial configuration copied from the Waveshare card, as they are nearly identical apart from the pins used for reset and enable and the address of the temperature sensor.

Thanks @frieger :+1: I'm going to rename this entry from:
emb_raspi_130x_cape_lr1302 -> embit_emb_lr1302 to be consistent with the other entries. The Cape is only significant for connecting with the Raspberry Pi GPIO pins, it doesn't change the implemented frequencies, gain table entries etc... I will keep the pins as defined in your config and thus the default will map to the Cape pins, but users are free to re-configure these to other values (when the module is used in other gateways without the Cape).


organizationParentRelationship does not return href field

The response of a POST petition with an organizationParentRelationship field to the organizations API does not return href field inside the organization.
For example, when sending this:
{
        "relationshipType": "organization",
        "organization": {
                "id": "urn:ngsi-ld:organization:71abc083-b265-4e85-82b4-e239230455fb",
                "href": "urn:ngsi-ld:organization:71abc083-b265-4e85-82b4-e239230455fb",
                "name": "Test S.A."
        }
}

It does return the same but without the href field

Solved in https://github.com/wistefan/tmforum-api/releases/tag/0.4.1


Fix typo in help for init

Thank you for submitting a pull request!
Description
Fix for issue  #142
Please describe what you changed briefly.
Type of Pull Request

[ ] Adding a feature
[x] Fixing a bug
[ ] Maintaining documents
[ ] Others ()

Verify the followings

[x] Code is up-to-date with the main branch
[x] No build errors after npm run build
[x] No lint errors after npm run lint
[x] No errors on using charites help globally
[x] Make sure all the existing features working well
[ ] Have you added at least one unit test if you are going to add new feature?
[x] Have you updated documentation?

Thank you, @iamr-kumar ! It looks good to me!
Dear @keichan34 , can you kindly check src/cli/init.ts ?


Updated legacy code to remove old jQuery dependency

Updated legacy code to remove old jQuery dependency and unnecessary code.
Changes

Updated src/budget/strategic-plan/interactive/index.html to remove old version of jQuery.
Updated src/static-legacy/css/styles.css to remove whitespace and make report nav fixed.
Updated src/static-legacy/js/functions.js to remove unnecessary code.
Added src/static-legacy/js/jquery-1.11.3.js to upgrade the jQuery version.
Removed src/static-legacy/js/jquery-1.9.1.min.js to upgrade the jQuery version.

Testing

Visit 'http://localhost:3000/budget/strategic-plan/interactive/#goal3`.

Screenshots

Review
@anselmbradford
@KimberlyMunoz

I feel like we should minify jquery, like it is with 1.9.1. /static-legacy/ is being directly copied over to /dist/ so jquery won't be post-processed and minified elsewhere.
Otherwise looks good :+1: (and removes a ton! Yes!).
Postscript:
The following seem like issues, but I wouldn't include them in this PR:

There are a few broken links for reference docs in the appendix and the THE CFPB STRATEGIC PLAN, BUDGET, AND PERFORMANCE PLAN AND REPORT.
Bar charts can be clicked and they change from green to grey. Why? The code for this interaction could probably be removed.

So the links are relative (coming from content ) but I can write some js fix that issue.

@anselmbradford, the interaction on the bar chart is a function of Highcharts ( the code for that is coming from content ). I think we should just change it on the content side in this instance.

the interaction on the bar chart is a function of Highcharts ( the code for that is coming from content ). I think we should just change it on the content side in this instance.

Sounds good. Yeah, I'd say just minify the jquery and merge this PR. The links and bar charts are really out of scope for this PR and I'm not sure if it's even something we need resources on, but worth noting.


Buttons disappear after user input

Hi,
each new bot message like buttons dissappear after user clicks or bot outputs a new button? That is bad to follow dialogue or when bot utter two buttons like for contact or feedback...
How can I prevent this?
I use it as the script version just shown here:
https://github.com/mrbot-ai/rasa-webchat#as-a-script

Hi, this is how it is supposed to behave. It mimics the behavior of quick replies on Messenger. The title of the button is persisted as a text message in the conversation, so you can always keep track


Fix cutters and screwdrivers in lathes

About the PR

Fixes the appearance of wirecutters and screwdrivers in lathes.
It was previously just the color mask.
It MIGHT break stuff that relies on the first sprite layer, but both still displayed colors correctly so it should be fine.
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:

fix: fixed wirecutters and screwdrivers appearing incorrectly in lathes

Hasn't this been fixed by #15706 ?


GoFish has been abandoned and documentation about it in the README should be removed

gofish development has been stopped, the repo on github has been archived (https://github.com/fishworks/gofish) and the 'go.fish' domain isn't registered anymore.
I advise maintainers to remove any documentation about installing jwt-cli through it, and most importantly to remove the mention of above-mentioned domain in order to prevent phishing issues in case the domain is bought back for malicious motives.

Thanks for the notice @adamency!

Very sorry for the delay, but this is in 6.0.0 now


Julia bindings

Are there any up-to-date Julia bindings for MFEM? I've found the AdFem.jl package, though it appears to not have been maintained for a while so I assume it's outdated.

Hi @bclyons12,
There are not supported Julia bindings and it is not clear how easy it will be to create those. This something we are definitely interested in though.
There are Python binding in PyMFEM.
Tzanio

Thanks, I'll check out PyMFEM for now. Presumably Julia bindings ought to be made using https://github.com/JuliaInterop/CxxWrap.jl. I'd be happy to help make the interface, but I'd need to work with an MFEM expert most likely.

Presumably Julia bindings ought to be made using https://github.com/JuliaInterop/CxxWrap.jl. I'd be happy to help make the interface, but I'd need to work with an MFEM expert most likely.

ping: @justinlaughlin, @pazner

Hi @bclyons12, if you are working on a Julia interface, feel free to post any questions that come up here or in a draft PR, and I can try to provide some help/advice.

Hi, I am working on an interface and I have a private repo on it. However, translation is a bit rough. I could already translate large portions via https://github.com/grasph/wrapit . However, I cannot get the class Array to compile and need more time.

Thanks for working on this, @termi-official !

@termi-official Thanks! Do you need help with it?

If this is okay for @tzanio then I can just make the package public for now and give you access. Once the package is ready I can transfer ownership to the mfem org. Last time I checked the bottleneck is some issue in wrapit where the translation of template fails and I had not enough time to get a detailed error report ready.

@termi-official, that sounds good to me.

https://github.com/termi-official/MFEM.jl note that you have to go back in the wrapit git history on master to reproduce the build. On current master there are some new bugs unfortunately. There is also a list of things for which I wanted to provide MWEs about which exact steps fail in the code generator. I will transfer the package to the MFEM org once we have at least example 0 working.

https://github.com/termi-official/MFEM.jl has now example 0 working, but it's not easy to use yet.


Adds some support and tests for HydrostaticModels

For now only a few functions are tests for hydrostatic models, but it's a start

All tests pass locally. Not sure the current error means or how to fix it...

These weren't part of your changes for the review, but do these need to be YPressure... / ZPressure...?
https://github.com/tomchor/Oceanostics.jl/blob/6a0871b4450c598db0c6ac323248b12fd024d30f/test/runtests.jl#L113
https://github.com/tomchor/Oceanostics.jl/blob/6a0871b4450c598db0c6ac323248b12fd024d30f/test/runtests.jl#L116

These weren't part of your changes for the review, but do these need to be YPressure... / ZPressure...?
https://github.com/tomchor/Oceanostics.jl/blob/6a0871b4450c598db0c6ac323248b12fd024d30f/test/runtests.jl#L113
https://github.com/tomchor/Oceanostics.jl/blob/6a0871b4450c598db0c6ac323248b12fd024d30f/test/runtests.jl#L116

Not really. These were and still are passing in previous tests so they should be good :)


DSA <IP_ADDRESS> Approximation Algorithms - Audio

Description
What are approximation algorithms? State their types and properties in detail.
Task

[ ] Audio

Note

While requesting the issue to be assigned, please mention your NAME & BATCH NUMBER.
Kindly refer to the Issue Guidelines.
Do not use assign command for this issue. Follow the above procedure.
In case you see that the issue has already been assigned, try to request for a different task within the same issue.
Changes should be made inside the DSA/directory & DSA branch.
Name of the file should be same as the issue.
This issue is only for 'GWOC' contributors of 'DSA' Domain.

@nimisha-yadav Name: Nikita Jadhav
Batch No: DSA Batch-6

@jaigora24 It's been many days, please try to submit this PR within 2 days now.


Tests should only use times in the range 0000-00-00 to 9999-12-31

=== prop_time from test/Icicle/Test/Sea/Psv.hs:63 ===
*** Failed! (after 11 tests):
Exception:
  Expected values:
  [(OutputName "chef",VTime (Time (268138 3 23 1 49 33.09696s)))]
  Expected:
  barney|chef|268138-03-23T01:49:33Z
  flanders|chef|268138-03-23T01:49:33Z
  homer|chef|268138-03-23T01:49:33Z
  lisa|chef|268138-03-23T01:49:33Z
  marge|chef|268138-03-23T01:49:33Z

  Got:
  barney|chef|0000-00-00T00:00:00Z
  flanders|chef|0000-00-00T00:00:00Z
  homer|chef|0000-00-00T00:00:00Z
  lisa|chef|0000-00-00T00:00:00Z
  marge|chef|0000-00-00T00:00:00Z

We could probably restrict it even further though, zebra only allows times from 1600-2999


Update test/Concurrency/Backdeploy/linking.swift to require macCatalyst supported environment

Resolves rdar://84441879

@swift-ci please smoke test

@swift-ci please smoke test Windows platform

@swift-ci please smoke test Windows platform


Source map does not resolve correctly for imported vulnerable contracts

We have a 2 contract setup, in which the main contract inherits a vulnerable contract:
vulnerableImport.sol
pragma solidity 0.5.0;

import "./imported.sol";

contract C is Imported {}

imported.sol
pragma solidity 0.5.0;

contract Imported {
    function f() public {
        selfdestruct(msg.sender);
    }
}

Scanning finds the correct selfdestruct problem:
$ sabre ./vulnerableImport.sol
✔ Compiled with solc v0.5.0 successfully
[    ] Analyzing C(node:30670) V8: :3 Invalid asm.js: Invalid member of stdlib

./vulnerableImport.sol
  6:2  error  The contract can be killed by anyone  https://smartcontractsecurity.github.io/SWC-registry/docs/SWC-106

✖ 1 problem (1 error, 0 warnings)

However the source mapping does not point to the correct line number. Reported location is 6:2 but line 6 does not exist in the vulnerableImport.sol file.
Observation
Doing a few more tests I found an interesting behavior. Adding an extra empty line in the vulnerable contract (before the vulnerable code) will increase 6:2 to 6:3.

Yeah, it looks like there is something wrong with it, I will try to find out the reason and fix it If no one has started to solve this problem yet.

@cleanunicorn -- Thanks for the example. I'll take a quick look at it and see how I can resolve the source map issue. The problem with imports and their source map linking is something that I haven't debugged yet. Unfortunately solc doesn't support resolving imports out of the box. So we're handling it within sabre, hence all such issues 😅

I have exactly the same problem in mythos ☺


About the setting of the 3-step conf values in a new dataset

Hello. Could you please tell me how you confirm the 3-step conf values of different classifications for the 'Tanks and Temples' dataset? Do I need use another neural network to learn it? Or just need get the conf distribution and take some experiments?

We set the conf values according to our experiments on our baseline model. And it should help if you have a robust network or design a more adaptive strategy like D2HC-RMVSNet on the Tank dataset.


Add window size to configuration

As you cannot easily change the window size (In Windows the Alt+Space shortcut doesn't work) I would suggest to add a "workbench.windowSize" option in config file, in order to be able to always launch at your prefered size.

Don't you think it would be better to have workspace persistence, as proposed in #640? That's how most apps solve this.

Yes, that makes more sense.
Basically, what I miss is the standard Windows alt+space menu, where I can quickly maximize the windows with Alt-Space-X.

Right, yeah you might want to make an issue in https://github.com/revery-ui/revery for that. Doesn't sound like it'd be too hard to add, but it does require some native integration.

Should this be considered fixed by #1703? Enabling Alt+Space is a Revery-issue entirely I think.

I agree


[BUG] Searchable snapshot dependency on repository chunk_size

Background
Every repository implementation accepts an optional chunk_size parameter at repository creation time. This property defines the maximum file size that will be uploaded to the repository. Any files larger than that will be broken into smaller files of chunk_size size (with the last chunk potentially smaller).
Searchable snapshots work by fetching partial index files on-demand at search time, and storing these parts as 8MiB (current hard-coded default) files on disk (unless the entire file is smaller than 8MiB). A virtual IndexInput wraps this logic, given the appearance to the upper layers of a single file while the implementation fetches and reads what is needed from these 8MiB partial files. Some clever logic in this code relies on the partial file size being a power of 2 to leverage bit shifting techniques to convert "block number" into an actual byte offset.
Bug
The searchable snapshot code does not handle the case that fetching an 8MiB section of a file might cross one of the snapshot chunk boundaries. This means that if the repository chunk_size parameter is not a multiple of 8MiB, then this code will fail. In practice, all default chunk sizes are in fact a multiple of 8MiB (fs: no chunking, s3: 1GiB, gcs: 5TiB, hdfs: no chunking). However a user can configure any value. This was discovered while attempting to implement #9514 and some repositories choose a random value between 100 and 1000 bytes for the test case.
Possible solution

Improve OnDemandBlockSnapshotIndexInput to always download the configured block size (i.e. 8MiB) even if that means downloading multiple file parts from the repository.

I'm looking into this

@kkmr Are you still looking at it?


It is not possible to explicitly set the value of auto_now or auto_now_add fields, even when passing a set function

I have a usecase where I want to explicitly set the value of an auto_now_add datetime field. Using this library, it does not look like this is possible, even if I pass an explicit set function.
I believe this may just be a small oversight in the implementation of django_pg_bulk_update.query._validate_set_functions() where it does not respect overrides due to the ordering.

Love this library by the way!

I've also added python 3.10 and postgres 13 testing to GitHub Actions.
Here is the PR which contains your changes + minor test and linter fixes. As soon as it passes all the tests, I'll make a release.


python311Packages.celery: 5.3.4 -> 5.3.5

Changelog: https://github.com/celery/celery/releases/tag/v5.3.5
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 267021 run on x86_64-linux 1

16 packages failed to build:

sourcehut.buildsrht
sourcehut.buildsrht.dist
sourcehut.gitsrht
sourcehut.gitsrht.dist
sourcehut.hgsrht
sourcehut.hgsrht.dist
sourcehut.hubsrht
sourcehut.hubsrht.dist
sourcehut.listssrht
sourcehut.listssrht.dist
sourcehut.mansrht
sourcehut.mansrht.dist
sourcehut.metasrht
sourcehut.metasrht.dist
sourcehut.pastesrht
sourcehut.pastesrht.dist

65 packages built:

baserow
baserow.dist
dvc (python311Packages.dvc)
dvc-with-remotes
dvc-with-remotes.dist
dvc.dist (python311Packages.dvc.dist)
paperless-ngx
python310Packages.celery
python310Packages.celery-redbeat
python310Packages.celery-redbeat.dist
python310Packages.celery-singleton
python310Packages.celery-singleton.dist
python310Packages.celery.dist
python310Packages.django-celery-beat
python310Packages.django-celery-beat.dist
python310Packages.django-celery-email
python310Packages.django-celery-email.dist
python310Packages.django-celery-results
python310Packages.django-celery-results.dist
python310Packages.django-google-analytics-app
python310Packages.django-google-analytics-app.dist
python310Packages.django-health-check
python310Packages.django-health-check.dist
python310Packages.django-raster
python310Packages.django-raster.dist
python310Packages.djmail
python310Packages.djmail.dist
python310Packages.dvc
python310Packages.dvc-task
python310Packages.dvc-task.dist
python310Packages.dvc.dist
python310Packages.dvclive
python310Packages.dvclive.dist
python310Packages.flower
python310Packages.flower.dist
python311Packages.celery
python311Packages.celery-redbeat
python311Packages.celery-redbeat.dist
python311Packages.celery-singleton
python311Packages.celery-singleton.dist
python311Packages.celery.dist
python311Packages.django-celery-beat
python311Packages.django-celery-beat.dist
python311Packages.django-celery-email
python311Packages.django-celery-email.dist
python311Packages.django-celery-results
python311Packages.django-celery-results.dist
python311Packages.django-google-analytics-app
python311Packages.django-google-analytics-app.dist
python311Packages.django-health-check
python311Packages.django-health-check.dist
python311Packages.django-raster
python311Packages.django-raster.dist
python311Packages.djmail
python311Packages.djmail.dist
python311Packages.dvc-task
python311Packages.dvc-task.dist
python311Packages.dvclive
python311Packages.dvclive.dist
python311Packages.flower
python311Packages.flower.dist
sourcehut.coresrht
sourcehut.coresrht.dist
sourcehut.todosrht
sourcehut.todosrht.dist

Result of nixpkgs-review pr 267021 run on x86_64-linux 1

16 packages failed to build:

sourcehut.buildsrht
sourcehut.buildsrht.dist
sourcehut.gitsrht
sourcehut.gitsrht.dist
sourcehut.hgsrht
sourcehut.hgsrht.dist
sourcehut.hubsrht
sourcehut.hubsrht.dist
sourcehut.listssrht
sourcehut.listssrht.dist
sourcehut.mansrht
sourcehut.mansrht.dist
sourcehut.metasrht
sourcehut.metasrht.dist
sourcehut.pastesrht
sourcehut.pastesrht.dist

65 packages built:

baserow
baserow.dist
dvc (python311Packages.dvc)
dvc-with-remotes
dvc-with-remotes.dist
dvc.dist (python311Packages.dvc.dist)
paperless-ngx
python310Packages.celery
python310Packages.celery-redbeat
python310Packages.celery-redbeat.dist
python310Packages.celery-singleton
python310Packages.celery-singleton.dist
python310Packages.celery.dist
python310Packages.django-celery-beat
python310Packages.django-celery-beat.dist
python310Packages.django-celery-email
python310Packages.django-celery-email.dist
python310Packages.django-celery-results
python310Packages.django-celery-results.dist
python310Packages.django-google-analytics-app
python310Packages.django-google-analytics-app.dist
python310Packages.django-health-check
python310Packages.django-health-check.dist
python310Packages.django-raster
python310Packages.django-raster.dist
python310Packages.djmail
python310Packages.djmail.dist
python310Packages.dvc
python310Packages.dvc-task
python310Packages.dvc-task.dist
python310Packages.dvc.dist
python310Packages.dvclive
python310Packages.dvclive.dist
python310Packages.flower
python310Packages.flower.dist
python311Packages.celery
python311Packages.celery-redbeat
python311Packages.celery-redbeat.dist
python311Packages.celery-singleton
python311Packages.celery-singleton.dist
python311Packages.celery.dist
python311Packages.django-celery-beat
python311Packages.django-celery-beat.dist
python311Packages.django-celery-email
python311Packages.django-celery-email.dist
python311Packages.django-celery-results
python311Packages.django-celery-results.dist
python311Packages.django-google-analytics-app
python311Packages.django-google-analytics-app.dist
python311Packages.django-health-check
python311Packages.django-health-check.dist
python311Packages.django-raster
python311Packages.django-raster.dist
python311Packages.djmail
python311Packages.djmail.dist
python311Packages.dvc-task
python311Packages.dvc-task.dist
python311Packages.dvclive
python311Packages.dvclive.dist
python311Packages.flower
python311Packages.flower.dist
sourcehut.coresrht
sourcehut.coresrht.dist
sourcehut.todosrht
sourcehut.todosrht.dist

Breaks sourcehut.


Does this not work in remote development mode?

I installed Kite on my desktop just to check it out, but my code is on a remote machine. My workflow is editing the code using VSCode's remote development feature. Turns out Kite has to be installed on that machine as well. I'm not sure how it works, but can't my local Kite installation be used for remote development?

I second this!

I third this!

I would totally love that!
I was trying to install the Kite engine in the remote Linux machine through terminal, but it doesn't seem to be working.
Let's hope it becomes available via local installation.

I would also really like this feature for dev container!
https://github.com/kiteco/vscode-plugin/issues/267

Subsumed by https://github.com/kiteco/issue-tracker/issues/250


Appveyor badge uses sds/overcommit rather than brigade/overcommit

The Appveyor badge links to the sds/overcommit project, when it should really link to brigade/overcommit. As it is, the badge is only accurate when @sds's master is up-to-date with the main repo.
Currently there is no brigade/overcommit project on Appveyor, so the first step would be to create one.
Related: #299

When I originally set this up, I was unable to create brigade/overcommit as a project since Appveyor uses a naming convention that ties itself to the user who originally created the project (i.e. they don't support the concept of an organization from what I can see).
Thus sds/overcommit was born. However, it looks like at some point (or perhaps always) the URL changed to sds/overcommit-v4g0l. I have no idea where this came from.
In any case, I now see that you can create an organization account by registering a new account via email, and then associating a GitHub organization.
I've done that and updated the badge in a52149d2c3f2a4c75b57596823fd54c0e933ab95.


Would it make conceptual sense to not decrease the timer for the tab the user is viewing currently?

I just run into this scenario:
I have set the tabs-to-keep to 1 earlier.
I've started a language lesson on Duolingo, then halfway through I realized I wanted to do something else AFK. When I came back 20 minutes later, I saw that I had a lesson underway, but wanted to quickly check some emails I got in the meantime. I've opened up a new tab, and Tab Shepherd meticulously made sure to close the tab with my ongoing lesson that very instant. Therefore losing me a couple minutes of progress.
I know that Duolingo is partly to blame here for not using onbeforeunload, but I was wondering if a simple change to Tab Shepherd would circumvent similar mistakes: Simply don't count down for the active tab. You've already stated that you wouldn't want the active tab to be shepherded. So how about we TS would only start the timer once I navigate away?

That is a possibility, however the tab lock feature is there to handle cases where a tab cannot be closed because of data loss (though it requires the user to manually set the flag).
In the next update, however, there is a new feature which should help solve this issue.  I'm adding a configurable countdown timer that starts when max tabs is exceeded, and no tabs will be closed until that timer has expired.  Using your scenario and assuming the new timer is configured to 5 minutes, that means that the Duolingo tab wouldn't have been closed until 5 minutes after you opened the new tab.
I'm going to think about implementing your change though.  I think you're right that it shouldn't count down at all for active tabs.  But it's not a trivial change, so I probably won't be able to change it by the next release.

I see. Yeah, that two-timer based solution would have also solved this issue. I'm looking forward to trying it out. :)


Submission information tab redesign

Description
Realigns the Submission information tab with the new design.
Realigns constants and enums in both front and back end
Updated front and back end validators
Moved contact_name to contact_first_name and contact_last_name
New search submissions endpoint
5c805af Update CODEOWNERS
da33d47 Add new endpoint to search submissions
bad860c readonly store states
799cafc Set default submission type on intake
5efa3e5 Add manual migration script for contact first/last name updates
4d41631 Update unit tests
f1a3598 Fix contact names. Updates to submission types
33e75c7 Resolve issue creating empty Submission
68a633f Backend enum/constant realignment. Submission validation arealignment
599ec09 Frontend enum/constant realignment
6ce9f4d Form and validator realignment
https://apps.nrs.gov.bc.ca/int/jira/browse/PADS-155

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

[ ] I have read the CONTRIBUTING doc
[x] I have checked that unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

Contact name info is not saving on list view or new sub view...I think you might have said this was coming.
Address field needs the locality/province added on both the new sub view and the list view still

UI looks good to me!
Not sure if it's already done, but submission type for all new submissions will automatically have to be set to "guidance." NAVs would only touch that field if it has to be changed to inapplicable.
Thanks!

I will check with the NAVs tomorrow about their thoughts on not being able to edit the address field and how we want to display related enquiry submissions if there are multiple.

Contact name info is not saving on list view or new sub view...I think you might have said this was coming.
Address field needs the locality/province added on both the new sub view and the list view still

Resolved

UI looks good to me! Not sure if it's already done, but submission type for all new submissions will automatically have to be set to "guidance." NAVs would only touch that field if it has to be changed to inapplicable. Thanks!

Added this in

Related enquiry field: They are okay with displaying all related enquiry submissions by separating it with commas. Doesn't matter if one of the related enquiry is marked as complete, they'd like to see all that's related. I think it'd make most sense to display them in order of submission date (most recent ~)  when there are multiple.

For SubmissionForm.vue:
Cannot type in companyNameRegistered field, it empties itself when blurred.
FE validation for singleFamilyUnits seems to be triggering for required even when schema says not required. (Happens when blank)

I just noticed the banner doesn't show up when the project submission has a related enquiry. Enquiry information tab shows the banner message with hyperlinked activity ID. This was a part of the other ticket "related submission" from before.. 🥲


Added Met Office weather and sensor components

Description:
Get weather data from the Met Office's DataPoint API.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#2318
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: metoffice
    api_key: "myapikey"
    monitored_conditions:
      - temperature
      - weather

weather:
  - platform: metoffice
    api_key: "myapikey"

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

Hi @jacobtomlinson,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

This has been raised to replace #5463. However it's not 100% finished and is still undergoing some testing.

Good to go at my end

@fabaff I've finished working through your review. There were three items I disagreed with or had questions about. Would you mind updating these?

This is not working for me and a few others over on the forums.  Where can I log an Issue with the developer?

That would be me! Send me a link to the thread and I'll take a look.
On Wed, 3 May 2017 at 18:58, cannfoddr<EMAIL_ADDRESS>wrote:

This is not working for me and a few others over on the forums. Where can
I log an Issue with the developer?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/6742#issuecomment-298987676,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABiUYvXlc8VKq0n3QEkQfy56gY37kiKeks5r2MBHgaJpZM4Mly_C
.

Take a look here:
https://community.home-assistant.io/t/metoffice-integration/15537
Sent from my iPhone

On 3 May 2017, at 19:39, Jacob Tomlinson<EMAIL_ADDRESS>wrote:
That would be me! Send me a link to the thread and I'll take a look.
On Wed, 3 May 2017 at 18:58, cannfoddr<EMAIL_ADDRESS>wrote:

This is not working for me and a few others over on the forums. Where can
I log an Issue with the developer?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/6742#issuecomment-298987676,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABiUYvXlc8VKq0n3QEkQfy56gY37kiKeks5r2MBHgaJpZM4Mly_C
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Take a look here:
https://community.home-assistant.io/t/metoffice-integration/15537 https://community.home-assistant.io/t/metoffice-integration/15537

On 3 May 2017, at 19:39, Jacob Tomlinson<EMAIL_ADDRESS>wrote:
That would be me! Send me a link to the thread and I'll take a look.
On Wed, 3 May 2017 at 18:58, cannfoddr<EMAIL_ADDRESS>wrote:

This is not working for me and a few others over on the forums. Where can
I log an Issue with the developer?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/6742#issuecomment-298987676,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABiUYvXlc8VKq0n3QEkQfy56gY37kiKeks5r2MBHgaJpZM4Mly_C
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/home-assistant/home-assistant/pull/6742#issuecomment-298998821, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_LOh1OKOUbCdabrCNxMbrF7beDrgfLks5r2MnTgaJpZM4Mly_C.


JavaScript

JavaScript
User Story
As a boot camp student
I want the prework notes to be structured on a webpage
So that I can easily find and read the information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I view the study guide
THEN I can see the four topics I learned listed along with a suggestion on what I should study first

Still bugged, but in progress


After Import Macro is not able to fire until a reloadui has occured,

I updated and everything seemed to be working fine. I wanted to add a macro so out of habit I modified my Legacy GSE 1 hunter macro to add another macro figuring I could import it. When in game I loaded GSE and went to options, plugins where there is a import button for Legacy GSE 1. When hovering over the button I can see the new macro I added but when I clicked on the button absolutely nothing happened. No lua errors, no import messages. I could see all my old hunter macros and the new one when hovering but again nothing happens when I click the button. As a test I deleted one of my hunter macros and tried to import again. This one would not come back either. The samples button seems to work but not the Legacy GSE 1 button.

Hi Palon
Your macro most likely imported into Global Macros rather than class.  When you edit the macro does the Specialisation match?
TimothyLuke

On 12 Jan 2017, at 3:06 pm, Palonblade<EMAIL_ADDRESS>wrote:
I updated and everything seemed to be working fine. I wanted to add a macro so out of habit I modified my Legacy GSE 1 hunter macro to add another macro figuring I could import it. When in game I loaded GSE and went to option, plugins where there is a import button for Legacy GSE 1. When hovering over the button I can see the new macro I added but when I clicked on the button absolutely nothing happened. No lua error, no import messages. I could see all my old hunter macros and the new one when hovering but again nothing happens when I click the button. As a test I deleted one of my hunter macros and tried to import again. This one would not come back either. The samples button seems to work but not the Legacy GSE 1 button.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

It is not in Global when I chose show all so I can't edit it, I also don't see any chat messages indicating things were imported, the do show when importing the samples

Can you copy in what your trying to import?  Also there is an update that just hit Curse
TimothyLuke

On 12 Jan 2017, at 4:18 pm, Palonblade<EMAIL_ADDRESS>wrote:
It is not in Global when I chose show all so I can't edit it, I also don't see any chat messages indicating things were imported, the do show when importing the samples
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Just updated and tried again, same results, nothing happens when I click the Legacy GSE 1 button. It also doesn't import manually any more (copy/paste into other import screen). LUA error below
local Sequences = GSMasterSequences

----- Hunter
-- Marksmanship - 254
Sequences['HunterMMLWAoE'] = {
author='Dana',
specID= 254,
helpTxt = 'Talents: 1113313',
StepFunction = GSStaticPriority,
PreMacro=[[
/cast [target=focus, exists, nodead],[target=pet, exists, nodead] Misdirection
/cast [combat] Trueshot
]],
'/cast [nochanneling, talent:6/1] A Murder of Crows; [nochanneling, talent:6/2] Barrage; [nochanneling, talent:6/3] Volley',
'/cast [nochanneling, talent:7/1] Sidewinders; [nochanneling, talent:7/2] Piercing Shot',
'/cast [nochanneling] Marked Shot',
'/cast [nochanneling] Windburst',
'/cast [nochanneling] Aimed Shot',
'/cast [nochanneling] Marked Shot',
'/cast [nochanneling] Multi Shot',
PostMacro=[[
]],
}
Message: Interface\AddOns\GSE\API\CharacterFunctions.lua:26: Usage: GetSpecializationInfoByID(specID[, sex])
Time: 01/12/17 03:59:28
Count: 1
Stack: [C]: in function GetSpecializationInfoByID' Interface\AddOns\GSE\API\CharacterFunctions.lua:26: in function GetClassIDforSpec'
Interface\AddOns\GSE\API\Storage.lua:77: in function OOCAddSequenceToCollection' Interface\AddOns\GSE\API\Events.lua:225: in function ?'
...terface\AddOns\GSE\Lib\AceTimer-3.0\AceTimer-3.0.lua:53: in function <...terface\AddOns\GSE\Lib\AceTimer-3.0\AceTimer-3.0.lua:48>
Locals: (*temporary) = nil

You need this piece - not the top parts:
Sequences['HunterMMLWAoE'] = {
author='Dana',
specID= 254,
helpTxt = 'Talents: 1113313',
StepFunction = GSStaticPriority,
PreMacro=[[
/cast [target=focus, exists, nodead],[target=pet, exists, nodead]
Misdirection
/cast [combat] Trueshot
]],
'/cast [nochanneling, talent:6/1] A Murder of Crows; [nochanneling,
talent:6/2] Barrage; [nochanneling, talent:6/3] Volley',
'/cast [nochanneling, talent:7/1] Sidewinders; [nochanneling, talent:7/2]
Piercing Shot',
'/cast [nochanneling] Marked Shot',
'/cast [nochanneling] Windburst',
'/cast [nochanneling] Aimed Shot',
'/cast [nochanneling] Marked Shot',
'/cast [nochanneling] Multi Shot',
PostMacro=[[
]],
}
On Thu, Jan 12, 2017 at 7:31 PM, Palonblade<EMAIL_ADDRESS>wrote:

Just updated and tried again, same results, nothing happens when I click
the Legacy GSE 1 button. It also doesn't import manually any more
(copy/paste into other import screen). LUA error below
local Sequences = GSMasterSequences
----- Hunter
-- Marksmanship - 254
Sequences['HunterMMLWAoE'] = {
author='Dana',
specID= 254,
helpTxt = 'Talents: 1113313',
StepFunction = GSStaticPriority,
PreMacro=[[
/cast [target=focus, exists, nodead],[target=pet, exists, nodead]
Misdirection
/cast [combat] Trueshot
]],
'/cast [nochanneling, talent:6/1] A Murder of Crows; [nochanneling,
talent:6/2] Barrage; [nochanneling, talent:6/3] Volley',
'/cast [nochanneling, talent:7/1] Sidewinders; [nochanneling, talent:7/2]
Piercing Shot',
'/cast [nochanneling] Marked Shot',
'/cast [nochanneling] Windburst',
'/cast [nochanneling] Aimed Shot',
'/cast [nochanneling] Marked Shot',
'/cast [nochanneling] Multi Shot',
PostMacro=[[
]],
}
Message: Interface\AddOns\GSE\API\CharacterFunctions.lua:26: Usage:
GetSpecializationInfoByID(specID[, sex])
Time: 01/12/17 03:59:28
Count: 1
Stack: [C]: in function GetSpecializationInfoByID'
Interface\AddOns\GSE\API\CharacterFunctions.lua:26: in function
GetClassIDforSpec'
Interface\AddOns\GSE\API\Storage.lua:77: in function OOCAddSequenceToCollection'
Interface\AddOns\GSE\API\Events.lua:225: in function?'
...terface\AddOns\GSE\Lib\AceTimer-3.0\AceTimer-3.0.lua:53: in function
<...terface\AddOns\GSE\Lib\AceTimer-3.0\AceTimer-3.0.lua:48>
Locals: (*temporary) = nil
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/TimothyLuke/GnomeSequencer-Enhanced/issues/169#issuecomment-272109757,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjBFWxn_9TpYZepfG_xemw_nplAUQgnks5rRevugaJpZM4LhXM5
.

Also there is a 2.0.3 update on Curse which may solve some of your challenges.

The Plugin button still does nothing and the sort doesn't work correctly when I choose to load all. The manual import worked.

Its actually sorts Class/Macroname  Ive added a label in #185 to make this more obvious.
The plugin button will put those macros back into Global Macros.  I am working on the underlying problem #187 and #188

When I hit the button nothing happens, the macros do no show when I choose show all, close and reopen.

I have found a fix for this in 2.0.5

When I hit the button nothing happens, the macros do no show when I choose show all, close and reopen still after latest update

Any suggestions? When I hover over the button I can see the macro I want to import. It's from my personal collection that I have setup to load as an addon.

Depends on how you coded the plugin
On Tue, Jan 17, 2017 at 3:18 PM, Palonblade<EMAIL_ADDRESS>wrote:

Any suggestions? When I hover over the button I can see the macro I want
to import. It's from my personal collection that I have setup to load as an
addon.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/TimothyLuke/GnomeSequencer-Enhanced/issues/169#issuecomment-273021883,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjBFbXptyUp3hnce69cv7yGQoFErTPbks5rTEgegaJpZM4LhXM5
.

Here's the macro and the toc file:
`local Sequences = GSMasterSequences
Sequences['BMTest'] = {
specID=253,
author="Gweenn@Bleeding Hollow",
helpTxt = "Talents: 3112112",
StepFunction = GSStaticPriority,
icon='INV_MISC_QUESTIONMARK',
lang="enUS",
PreMacro=[[
/cast [target=focus, exists, nodead],[target=pet, exists, nodead] Misdirection
/cast [@pet,dead]Revive Pet
/cast [combat] Bestial Wrath
/cast [combat] Intimidation
/cast [combat] Aspect of the Wild
/cast [combat] Titan’s Thunder
/cast [nopet,nodead] Call Pet 1; [@pet,dead] Heart of the Phoenix
/cast [combat,pet:Spirit Beast,@player] Spirit Mend
/cast [combat,pet,@player] Roar of Sacrifice
/cast [mod] Multi-Shot
]],
"/cast Dire Beast",
"/cast Kill Command",
"/cast [talent:6/1] A Murder of Crows; [talent:6/2] Barrage",
PostMacro=[[
/cast [nogroup] Mend Pet
]],
}
 ## Interface: 70000
Title: |cffff0000GS-E:|r Dana's Bundled Macros
Notes: A good starting point.
Author: Dana
Version: v0.7 - Legion Beta
RequiredDeps: GS-Core
LoadOnDemand: 1
Macros\HunterD1.lua
`

You need to import that manually into the mod.
On Tue, Jan 17, 2017 at 5:21 PM, Palonblade<EMAIL_ADDRESS>wrote:

Here's the macro and the toc file:
`local Sequences = GSMasterSequences
Sequences['BMTest'] = {
specID=253,
author="Gweenn@Bleeding Hollow",
helpTxt = "Talents: 3112112",
StepFunction = GSStaticPriority,
icon='INV_MISC_QUESTIONMARK',
lang="enUS",
PreMacro=[[
/cast [target=focus, exists, nodead],[target=pet, exists, nodead]
Misdirection
/cast [@pet https://github.com/pet,dead]Revive Pet
/cast [combat] Bestial Wrath
/cast [combat] Intimidation
/cast [combat] Aspect of the Wild
/cast [combat] Titan’s Thunder
/cast [nopet,nodead] Call Pet 1; [@pet https://github.com/pet,dead]
Heart of the Phoenix
/cast [combat,pet:Spirit Beast,@player https://github.com/player]
Spirit Mend
/cast [combat,pet,@player https://github.com/player] Roar of Sacrifice
/cast [mod] Multi-Shot
]],
"/cast Dire Beast",
"/cast Kill Command",
"/cast [talent:6/1] A Murder of Crows; [talent:6/2] Barrage",
PostMacro=[[
/cast [nogroup] Mend Pet
]],
}
Interface: 70000
Title: |cffff0000GS-E:|r Dana's Bundled Macros Notes: A good starting
point. Author: Dana Version: v0.7 - Legion Beta RequiredDeps: GS-Core LoadOnDemand:
1
Macros\HunterD1.lua
`
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/TimothyLuke/GnomeSequencer-Enhanced/issues/169#issuecomment-273036012,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjBFdgl4aopy1Xu8Bl-H4fHi5-lt_DKks5rTGT-gaJpZM4LhXM5
.

Has the Legacy import button been removed?

no the radio button was removed - it will auto figure out what type it is.  see #216
You can also import multiple macros at the same time.

I was referring to the Options, Plugins, Legacy GSE 1 button. I don't see it anymore since removing the GS-Core.lua files and the GSE.lua files and letting them recreate. My GS-E: Bundled Macros is loaded but no button.

Is the GSE2 Legacy Adaptor enabled in your mod list?

Yes. I just see the GS-HighPerformance and Samples button.

Then Im not sure.  GS-myMacros hasn't had any support since September.

GS-myMacros and/or Legacy GSE 1 macros button are shown in your video for 2.0. The missing button is from the GSE 2.0 addon.

The Legacy Adapter won't appear if there are errors in your old GSE1 plugins.
TimothyLuke

On 18 Jan 2017, at 3:50 am, Palonblade<EMAIL_ADDRESS>wrote:
GS-myMacros and/or Legacy GSE 1 macros button are shown in your video for 2.0. The missing button is from the GSE 2.0 addon.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

Before I posted about this I had removed all my class macros from my Legacy files except for my hunter to make it easier to troubleshoot. I just uninstalled all the GSE stuff, removed all GS saved variable files and reduced my legacy hunter macro to what's below which should not have any errors. I reinstalled and loaded samples when prompted so a fresh install. I still only see the Samples button when going to Options...Plugin. I also don't see the high end button but I assume that's expected since I uninstalled them. The only 3 addons I have loaded are GSE, GSE Legacy Adapter and my macros. I've also tried to unload and reload my macros addon multiple times.
local Sequences = GSMasterSequences
Sequences['BMTest'] = {
specID=253,
author="Dana",
helpTxt = "Talents: 3112112",
StepFunction = GSStaticPriority,
icon='INV_MISC_QUESTIONMARK',
lang="enUS",
PreMacro=[[
]],
"/cast Dire Beast",
PostMacro=[[
]],
}

I would suggest to copy from the
Sequences["
line on and go to /GSE and Import via the dialog and Paste.  You can paste all of them at once and don't need to paste them individually.
Even if you figure out why it's not importing it won't import any changes you make to those files after you get the import to work.  You will still have to go into the game, click the Plugins button, go to your macro and change the active version to the new one and delete the old versions for every macro in there that you want to use.
Timothy Minahan
M 0406 413 680  |  E<EMAIL_ADDRESS>
On 18 Jan 2017, at 7:47 am, Palonblade<EMAIL_ADDRESS>wrote:
Before I posted about this I had removed all my class macros from my Legacy files except for my hunter to make it easier to troubleshoot. I just uninstalled all the GSE stuff, removed all GS saved variable files and reduced my legacy hunter macro to what's below which should not have any errors. I reinstalled and loaded samples when prompted so a fresh install. I still only see the Samples button when going to Options...Plugin. I also don't see the high end button but I assume that's expected since I uninstalled them. The only 3 addons I have loaded are GSE, GSE Legacy Adapter and my macros. I've also tried to unload and reload my macros addon multiple times.
local Sequences = GSMasterSequences
Sequences['BMTest'] = {
specID=253,
author="Dana",
helpTxt = "Talents: 3112112",
StepFunction = GSStaticPriority,
icon='INV_MISC_QUESTIONMARK',
lang="enUS",
PreMacro=[[
]],
"/cast Dire Beast",
PostMacro=[[
]],
}
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.


VSCode changes system colors on startup under Ubuntu Mate

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.76.2
OS Version: Ubuntu Mate 22.04

Steps to Reproduce:

Mate appearance is set to: Yaru-bark-dark
Starting vscode through apps menu changes the appearance (color) of whole system to light mode

Steps to Fix:
In /usr/share/applications/code.desktop I change:
Exec=/usr/share/code/code --unity-launch %F

To:
Exec=/usr/bin/code --unity-launch %F

Ok, found it. For some reason when executing with 1st method vscode is calling bashrc (in my case it was resetting gtk settings).


Update nuget package so ApplicationInsights.config is set to 'Copy if newer'

Set the ApplicationInsights.config to 'Copy if newer' after installation to make it easier for the user.

@yantang-msft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


EPIC: Account connection authentication

Problem
A BN would benefit from the ability to authenticate a connecting account on certain requests
Solution
Add logic to support account based auth on requests
Estimation considerations

Consumer Account -- Using Oauth session authenticated by Accounts signature.
Anyone who has an Account can request this.

Alternatives
No response

Candidate for move towards Phase 2b or 3


Update dependencies

Codecov Report

Merging #88 (499c487) into main (8a4a41a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   80.92%   80.92%
=======================================
  Files          16       16
  Lines        1227     1227
=======================================
  Hits          993      993
  Misses        173      173
  Partials       61       61

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a4a41a...499c487. Read the comment docs.


Should we skip the July 20th meeting?

Hi @nodejs/community-committee!
Currently we only have one item on the agenda for this week's meeting: Candidate "areas" for TSC and Community Committee  #278.
Is there anything else that folks would like to discuss? If not, I propose we skip this week's meeting. Sound good?

I have a conflict (like always ;_;), so I would appreciate it if we skipped.

okay to skip from my side

sure since we dont have consensus on the new member thing anyways

oh wait i just saw that we do. nevermind

Works for me.

Ok, let's call it then. Our next meeting will be August 3rd, see you then!


Resource android:attr/lStar not found when building release APK

This error seems to be related to the sign_in_with_apple plugin.
Environment
supabase_flutter version: 1.10.25
sign_in_with_apple plugin version: 5.0.0
Android compileSdkVersion: 34
Android targetSdkVersion: 34
Steps to Reproduce
Add sign_in_with_apple plugin to pubspec.yaml
Run flutter pub get
Try to build a release APK with flutter build apk --release
What I've Tried
I've attempted the following solutions without success:
Updated Android SDK versions in build.gradle
Ensured AndroidX is enabled
Cleaned and rebuilt the project
Disabled resource shrinking and minification
Question
Is this a known issue with the plugin? Are there any workarounds or fixes available?
Any assistance would be greatly appreciated. Thank you!

Duplicate of https://github.com/supabase/supabase-flutter/issues/1057


Update README.md

It is not true anymore.
https://nim-lang.github.io/Nim/uri.html#decodeQuery.i%2Cstring

Thank you for the PR!


Add Preliminary MHD Integrator

All non-MHD tests pass except those noted in issues #218 and #219 which also don't pass in dev.
This commit primarily adds support for MHD to the Van Leer 3D integrator along with myriad small fixes and modifications. All new features have tests as well.
The MHD implementation still has bugs but needs to be merged in before we reformat the code so that the merging doesn't provoke too many merge conflicts.
MHD

Add MHD support to Van Leer 3D integrator
All MHD code is in the mhd namespace with sub-namespaces when relevant (e.g. mhd::utils)
Add kernel to compute the CT electric fields and tests for it
Add kernel to update the magnetic field and tests for it
Add MHD support to the PCM reconstruction
Add new Linear_Wave initial condition type
Add ctElectricFields global device array
Set all MHD input parameters to default to zero
Remove incorrect MHD specializations in the boundary conditions
Add check to make sure MHD has at least 3 ghost cells
Add functions to compute the maximum magnetic divergence, report it, and exit if it's too large
Clean up make.type.mhd and enable cuda error checking
Add example parameter files for

Alfven wave
Fast magnetosonic wave
Slow magnetosonic wave
Ryu & Jones 1995 shock tubes 1a and 2a

Add the following input parameters for generalized linear waves

EigenVec_rho
EigenVec_MomentumX
EigenVec_MomentumY
EigenVec_MomentumZ
EigenVec_E
EigenVec_Bx
EigenVec_By
EigenVec_Bz
pitch
yaw

Added MHD system tests for:

Hydro only constant state test
MHD constant state
Sod test that works with PCM (this will be merged with the hydro test when MHD supports PPMC)
All 4 MHD linear waves
MHD Einfeldt strong rarefaction

#218 # HLLD Riemann Solver

Updated interface state indexing for new format
Added documentation
Moved dot product function to math_utils

Testing

Add new method, runL1ErrorTest, to SystemTestRunner that computes the L1 error compared to the initial conditions. Ideal for wave tests
Updated hydro wave tests to use new runL1ErrorTest method

Reductions

Add new FP atomic max that works on CUDA or ROCm
Update time step calculation to use the grid reduction with atomic and DeviceVector
Updated tests to match
Remove dev_dti, host_dti_array, and dev_dti_array global variables

Utilities
Cuda Utilities

Add function initGpuMemory which initializes GPU memory so the CUDA compute sanitizer doesn't complain about it. Used to initialize all GPU arrays that I know of.
Add struct AutomaticLaunchParams which is a thin wrapper over the occupancy API. Primarily intended for reductions where performance is sensitive to the number of blocks but could be used for any kernel launch

DeviceVector

New option to initialize memory

Math Utilities
New namespace and file for math utilities. Currently contains a semi-general rotation and dot product functions
MHD Utilities

The mhd::utils::computeEnergy function now works properly with either MHD or hydro and returns the appropriate energy

Other

Add a function to_string_exact to convert floating point numbers to a string such that it can be exactly deserialized back from a string to the same floating point number. Only used in tests currently

This is currently a draft and not ready for merging but wanted to make the changes available for code review as the things that are left to do are minor and should be done shortly.
To do

[ ] Rebase off of dev again now that PR #213 is merged
[ ] Replace current indexing in MHD code with grid enums

Documentation for the runL1Error method has been added to the wiki

Converting MHD to using grid_enum is done so I'm converting this from a draft to a full PR.
@alwinm, switching to using the enum was pretty easy. Could you take a look at my additions to the enum and my general usage? I think it's what we talked about but I'd like confirmation and feedback.

FYI, I think github actions are having some issues at the moment. Some jobs are getting shutdown signals from somewhere. I double checked and everything builds fine on C-3PO and the containers running on my machine. For now I'm just restarting failed jobs until they pass.

I think I figured out the issue with builds randomly failing. The error ended up being too many resources consumed. I reduced the number of jobs that Make launched and it seems to have fixed it