intake_esm import test triggers some errors

Just came accross this today.

        Args:
            pre (bool, optional): Whether this validator should be called before the standard
                validators (else after). Defaults to False.
            skip_on_failure (bool, optional): Whether to stop validation and return as soon as a
                failure is encountered. Defaults to False.
            allow_reuse (bool, optional): Whether to track and raise an error if another validator
                refers to the decorated function. Defaults to False.

        Returns:
            Any: A decorator that can be used to decorate a function to be used as a root_validator.
        """
        warn(
            'Pydantic V1 style `@root_validator` validators are deprecated.'
            ' You should migrate to Pydantic V2 style `@model_validator` validators,'
            ' see the migration guide for more details',
            DeprecationWarning,
            stacklevel=2,
        )

        if __args:
            # Ensure a nice error is raised if someone attempts to use the bare decorator
            return root_validator()(*__args)  # type: ignore

        if allow_reuse is True:  # pragma: no cover
            warn(_ALLOW_REUSE_WARNING_MESSAGE, DeprecationWarning)
        mode: Literal['before', 'after'] = 'before' if pre is True else 'after'
        if pre is False and skip_on_failure is not True:
>           raise PydanticUserError(
                'If you use `@root_validator` with pre=False (the default) you MUST specify `skip_on_failure=True`.'
                ' Note that `@root_validator` is deprecated and should be replaced with<EMAIL_ADDRESS>                code='root-validator-pre-skip',
            )
E           pydantic.errors.PydanticUserError: If you use `@root_validator` with pre=False (the default) you MUST specify `skip_on_failure=True`. Note that `@root_validator` is deprecated and should be replaced with `@model_validator`.
E
E           For further information visit https://errors.pydantic.dev/2.0.2/u/root-validator-pre-skip

/g/data/xp65/public/apps/med_conda/envs/access-med-0.2/lib/python3.10/site-packages/pydantic/deprecated/class_validators.py:228: PydanticUserError

@dougiesquire any idea?

Yup, I've actually just added a fix for this in Intake-ESM: https://github.com/intake/intake-esm/pull/619
Until a new release of Intake-ESM is issued, the solution is to pin pydantic<2.0

Thanks @dougiesquire. Let's keep this one open until they fix it.

Intake-ESM (and hence the ACCESS-NRI catalog) won't work in any MED environment created before a new Intake-ESM version is released unless you pin pydantic<2.0.

Sure, I have done that.

@dougiesquire should we put intake-esm back in the tests?

Yes please

Actually it is not there. I am closing then


Question about notifications received when app is closed

I thought I saw a discussion about this in the past but I cannot seem to find it.
Is it possible to a trigger function inside my app if a notification is received when the app is closed (not in foreground/background)?  I want to be able to set some indicators inside the app so if a person receives a notification when the app is closed, and instead of clicking the notification shade to view the notification, they click on the app icon itself, they can see what area the notification was about.
Thanks,
Adam

#158


A question about sign_with_ecdsa

At https://github.com/dfinity/oisy-wallet/blob/main/src/backend/src/lib.rs#L7
use ic_cdk::api::management_canister::ecdsa::{
    ecdsa_public_key, sign_with_ecdsa, EcdsaCurve, EcdsaKeyId, EcdsaPublicKeyArgument,
    SignWithEcdsaArgument,
};

Is it possible to hook up some custom calls at this point sign_with_ecdsa, so that 3rd parties can do some extra work like suspicious address scan or other security checks?
E.g. when the user want to sign a transaction by calling sign_with_ecdsa, if there are some hooks exist, they would do security checks for the transaction, and sign_with_ecdsa only proceeds after they pass.
Thanks and regards

Thread appears to be inactive, so I'm closing this question. Feel free to ping me if it needs to be reopened.

Interesting idea, is there a reason why you'd want such a precondition as a hook to sign_with_ecdsa as opposed to just a check before you call it ?

Yes I can write code to check before calling sign_with_ecdsa.
The point I'm trying to make is that hooks would allow extensions and plugins to be possible, in term of architecture.


Link urls to GCS from build report are out of date

In the Google Cloud Storage Upload Report, the object links appear to use out of date url bases
for link to console:
https://cloud.google.com/console/storage should be https://console.cloud.google.com/storage
for link to download:
https://storage.cloud.google.com should be https://storage.googleapis.com

Fixed as of da872a5b860c5ef485a2936d865ff1b280da72cf


utf32 moved to LegacyStrings

julia> using Gallium
INFO: Precompiling module Gallium...
ERROR: LoadError: `utf32` has been moved to the package LegacyStrings.jl:
Run Pkg.add("LegacyStrings") to install LegacyStrings on Julia v0.5-;
...

Duplicate of #133?  In other words, already fixed in master?


After 2caa3c9 Tests D3D11 Going mad

Tk-Glitch BKGBUILD. Other Commits going to D3D9 allright

Opening issues like this is almost certainly not helpful to the developers, nor was #1423 or #1337. Issues are for reporting bugs or regressions. If you are trying to report a bug, you did not provide enough information.

The changes after 2caa3c9 do not affect D3D11 in any way.
Closing because this bug report contains no info.


Basic fixes

I bumped angular to 1.2.28, switched from angularjs-scroll-glue-Luegg to angular-scroll-glue and changed the default controller address to the address that works with deis by default. Thanks for the work!

Thanks @Joshua-Anderson :)

No problem. I also opened deis/deis#3253 to resolve CORS issues.


Arguments.cs:10: 60m/DEV Parse arguments.

The puzzle 103-1449c44a from #103 has to be resolved:
https://github.com/DenisZhukovski/ObjectToTest/blob/6f6524e82283115f98db1aa2b7d14828806c5bf4/src/CodeFormatting/Syntax/Implementation/Arguments.cs#L10-L10
The puzzle was created by Stanislau on 02-Dec-22.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 103-1449c44a has disappeared from the source code, that's why I closed this issue.


Cannot run sample

I installed but could not get the sample to run.
Pytorch 1.5.
Would be really nice to use...

Sorry! I wrote this for 1.1.0, and back then autograd was serialized on CPU, meaning ceres couldn't multithread:
https://github.com/pytorch/pytorch/issues/17566
https://github.com/pytorch/pytorch/issues/18333
So I wrote a bunch of hacky code that reaches into torch's internals and spins up additional backprop threads: https://github.com/Pronto-ai/optorch/blob/8926fd6de401d7cfb2af4b9147fbe6dceddd4e73/optorch/cpp/main.cpp#L147
:sweat_smile: :sweat_smile:
It looks like multithreaded backprop was implemented in March:
https://github.com/pytorch/pytorch/commit/618104185bce6591c4697063b1faf2027c3761e7
https://github.com/pytorch/pytorch/pull/33157
I'm not entirely familiar with the release process but I assume that PR made it into 1.5.0. Going to try and implement a more reasonable backend that uses official APIs now, so there's no ABI breakage with new versions.


Dynamic add routes

Reference: nuxt/framework#2057, nuxt/nuxt.js#13054
The idea is dynamically to register router routes on runtime via a plugin. A new addRoute utility could be helpful to handle the required logic.

it looks like you are adding the route after the router is used by app with app.use(router) which triggers the initial navigation on the client to a still non existent route.
That is okay, but ideally, some navigation guard should detect that the route must be added dynamically, add the route, and then trigger a new navigation with next(to.fullPath) or by returning the location.
Originally posted by @posva in https://github.com/nuxt/framework/pull/2057#r753847873

I think adding routes before the router is initialised can be done in app/router.options.ts: https://nuxt.com/docs/guide/recipes/custom-routing#using-approuteroptions. We can use https://github.com/nuxt/nuxt/issues/23678 to track adding them asynchronously.
Adding them after the router is initialised can be done with useRouter().addRoute().


[prometheus] add 2.53 LTS release

closing  this in favor of https://github.com/endoflife-date/endoflife.date/pull/5313


String.prototype.link is deprecated

Source: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/link

https://github.com/p01/mmd.js/blob/cd7f4872174bb29ef853f880119909dc70b7b4eb/mmd.js#L13
can change to
.replace(/\[([^\]]+)]\(([^(]+?)\)/g, `<a href="$2">$1</a>`)

I do not send the pull request. I think the author may be more convenient to modify, plus if there are any other slight changes in the future that can also be combined.

I am confused about why we need this change.
String.prototype is part of the latest Ecma 262 specification, it is actively supported by all common browser engines, and I have been using it in Node from version 8 to 16.
Does mmd.js fail to generate links for you ? In which environment ?


Colored output for sh and shell commands

This can now be achieved since Discord added (limited*) support for TTY color codes on ANSI codeblocks. It's currently desktop only and probably will stay that way for a long time considering the history of syntax highlighting on mobile, therefore a new --mobile (short --m) flag needs to be added to both commands to strip color codes so they don't leak and trash the mobile output.
The child_processes themselves also need to be able to receive the color codes, in a crossplatform (Windows & Linux) way. Refs:

apt install expect & unbuffer <cmd> (Linux only?)
https://github.com/CyriacBr/get-pty-output
https://github.com/microsoft/node-pty

Discord ANSI codes are limited in the following ways:

Only primary colors work, not secondary.
Extended color doesn't work.
Some colors don't really match their official ANSI name.

Example codeblock (ANSI):
COLORMATIC


refactor: change engine name to color for output message

Finished game 9 (random_move_1 vs random_move_2): 1-0 {Black got checkmated}
fix https://github.com/Disservin/fast-chess/issues/532

Note 'White' vs 'white'

This isn't yet giving the right results. See how it writes:
0-1 {White wins by adjudication}  which would be a Black wins .. or a 1-0.
fast-chess:
Starting tournament...
Started game 1 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Started game 2 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Started game 3 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Started game 4 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 3 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0): 0-1 {White wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 1 - 0 - 0 [1.000] 1
Started game 5 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 1 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {Black wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 0 - 0 [1.000] 2
Started game 6 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 4 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 0-1 {White wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 1 - 0 [0.667] 3
Started game 7 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 6 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1/2-1/2 {Draw by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 1 - 1 [0.625] 4
Started game 8 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 7 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {Black wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 2 - 1 [0.500] 5
Started game 9 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 2 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {Black wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 3 - 1 [0.417] 6
Started game 10 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 5 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {Black wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 3 - 3 - 1 [0.500] 7
Started game 11 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 8 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {Black wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 4 - 3 - 1 [0.562] 8
Started game 12 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)

cutechess-cli
Started game 6 of 466 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 1 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {White wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 0 - 1  [0.833] 3
Started game 7 of 466 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 2 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1/2-1/2 {Draw by insufficient mating material}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 0 - 2  [0.750] 4
Started game 8 of 466 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 7 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {White wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 3 - 0 - 2  [0.800] 5
Started game 9 of 466 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 5 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 0-1 {Black wins by adjudication}

This isn't yet giving the right results. See how it writes: 0-1 {White wins by adjudication} which would be a Black wins .. or a 1-0.
fast-chess:
Starting tournament...
Started game 1 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Started game 2 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Started game 3 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Started game 4 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 3 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0): 0-1 {White wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 1 - 0 - 0 [1.000] 1
Started game 5 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 1 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {Black wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 0 - 0 [1.000] 2
Started game 6 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 4 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 0-1 {White wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 1 - 0 [0.667] 3
Started game 7 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 6 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1/2-1/2 {Draw by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 1 - 1 [0.625] 4
Started game 8 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 7 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {Black wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 2 - 1 [0.500] 5
Started game 9 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 2 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {Black wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 3 - 1 [0.417] 6
Started game 10 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 5 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {Black wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 3 - 3 - 1 [0.500] 7
Started game 11 of 932 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 8 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {Black wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 4 - 3 - 1 [0.562] 8
Started game 12 of 932 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)

cutechess-cli
Started game 6 of 466 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 1 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {White wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 0 - 1  [0.833] 3
Started game 7 of 466 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 2 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1/2-1/2 {Draw by insufficient mating material}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 2 - 0 - 2  [0.750] 4
Started game 8 of 466 (Base-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs New-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 7 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 1-0 {White wins by adjudication}
Score of New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0: 3 - 0 - 2  [0.800] 5
Started game 9 of 466 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0)
Finished game 5 (New-ee6fc7e38b4aeef44862159215a56d97122f59a0 vs Base-ee6fc7e38b4aeef44862159215a56d97122f59a0): 0-1 {Black wins by adjudication}

ahh yeah my bad

fixed 👍


Fixing large response writing on TCP connection

When we have a large response for a GET query, the server can't write the whole response on user's TCP connection and it will be imperfect data.
We need to enhance this line and send data in another way. (we can stream the result(?))
https://github.com/zurvan-lab/TimeTrace/blob/fdfae8ea172049890035294c6b775756f154cdb4/core/server/server.go#L133

Yeah streaming would help. Set an upper limit (BUFFER_SIZE) on the buffer size and you have to stream it one at a time. Connection will have to remain open till then.

@adarshjhaa100 Hi, thank you for this information! We are trying to fix that ASAP. If you are interested to help us please tell us.❤

Sure, im interested. I guess we can loop over the payload with a fixed buffer sized and stream those chunks. Also, the code on the client side might need to be changed to combine back those chunks.
If possible, I'd like to know the following:
Do we keep the BUFFER_SIZE fixed or configurable.
Are there some sort of tests and benchmarks used for this particular piece of code.

currently, there is no test, it's a work in progress.

#85

But you can try your idea on the current code, also I can help you with running and testing it in development time.
I have this gist also which is for streaming large files (data) over a TCP connection. what do you think? can we follow the same approach?
https://gist.github.com/kehiy/4bff455048a8bedf4f9374b8899b2f43

Oh, this is from the client's perspective, it will work for us.
Let me play with this for a couple of days and I'll reply with a PR soon.

@adarshjhaa100 okay, I'm here if you have any questions about anything in time-trace.

It seems that we should create a simple protocol over TCP.

@0x9n0p I agree, do you have any idea about the protocol itself, or implementing it?
I belive we can enhance results by defining a protocol also.

A protocol that has a content-length on headers and may have other flags in the future.
I have the same issue on PlutoEngine, so I can actively contribute to this protocol.

yes, I agree. we can also try to define a better way to send normal response when we have a protocol. but it need to be documented also. if you can help on this, please ping us on our discord: https://discord.gg/NU5Y2hrd.

Hello, @kehiy, apologies for the delay. Got busy with Christmas break.
How do I replicate this bug? I've made some modifications to the server.go and meanwhile testing stuff through REPL, but it's taking time to insert a lot of data.
But, is there any other way to execute the TQL commands quickly with a huge chunks of data? Should I just temporarily modify the TQL/execute.go file.

We will work on it on:

#124


Update dialog state fix

Unravels some of the deep logic involved in the update modal dialog display to make it (hopefully) a little more readable. Also revealed a reducer that wasn't reacting to a couple of update events that it should have been which was flashing incorrect messages temporarily in some circumstances.

 BUG - Electron - "Install" button doesn't work when displayed after logging in.


added comment to test failure

Pre-Flight checklist

[ ] Screenshots and design review for any changes that affect layout or styling
[ ] Migrations

[ ] Migration is backwards-compatible with current production code

[ ] Testing

[ ] Code is tested
[ ] Changes have been manually tested

[ ] Settings

[ ] New settings are documented and present in app.json
[ ] New settings have reasonable development defaults, if applicable
[ ] Opened issue for DevOps regarding necessary configuration changes to deployed environments

What are the relevant tickets?
(Required)
What's this PR do?
(Required)
How should this be manually tested?
(Required)
Where should the reviewer start?
(Optional)
Any background context you want to provide?
(Optional)
Screenshots (if appropriate)
(Optional)
What GIF best describes this PR or how it makes you feel?
(Optional)

Codecov Report

Merging #1424 (244784c) into master (b0ff861) will decrease coverage by 2.84%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1424      +/-   ##
==========================================
- Coverage   89.02%   86.18%   -2.85%
==========================================
  Files         235      122     -113
  Lines        9822     6449    -3373
  Branches     1848     1043     -805
==========================================
- Hits         8744     5558    -3186
+ Misses        948      769     -179
+ Partials      130      122       -8

Impacted Files
Coverage Δ

static/js/util/index.ts

static/js/pages/PrivacyPolicyPage.tsx

static/js/lib/ckeditor/turndown.ts

static/js/components/AuthenticationAlert.tsx

static/js/components/RepeatableContentListing.tsx

static/js/components/widgets/Label.tsx

static/js/hooks/state.ts

static/js/hooks/permissions.ts

static/js/components/DocumentTitle.tsx

static/js/types/modal_state.ts

... and 103 more

Help us with your feedback. Take ten seconds to tell us how you rate us.


I use the colab version and try to run the example, but failed

Note that --use-env is set by default in torchrun.
If your script expects --local-rank argument to be set, please
change it to read from os.environ['LOCAL_RANK'] instead. See
https://pytorch.org/docs/stable/distributed.html#launch-utility for
further instructions
warnings.warn(
usage: train.py
[-h]
[--world_size WORLD_SIZE]
[--local_rank LOCAL_RANK]
[--dataloader_imgsize DATALOADER_IMGSIZE]
[--batch_size BATCH_SIZE]
[--model_name MODEL_NAME]
[--dataloaders DATALOADERS]
[--mode {train,test}]
[--test_input_person_images TEST_INPUT_PERSON_IMAGES]
[--test_input_poses_images TEST_INPUT_POSES_IMAGES]
[--test_checkpoint_dir TEST_CHECKPOINT_DIR]
[--test_output_dir TEST_OUTPUT_DIR]
[--test_output_video TEST_OUTPUT_VIDEO]
[--test_output_udp TEST_OUTPUT_UDP]
[--test_pose_use_parser_udp TEST_POSE_USE_PARSER_UDP]
train.py: error: unrecognized arguments: --local-rank=0
ERROR:torch.distributed.elastic.multiprocessing.api:failed (exitcode: 2) local_rank: 0 (pid: 993) of binary: /usr/bin/python3
Traceback (most recent call last):
File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
exec(code, run_globals)
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launch.py", line 196, in
main()
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launch.py", line 192, in main
launch(args)
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launch.py", line 177, in launch
run(args)
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/run.py", line 785, in run
elastic_launch(
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launcher/api.py", line 134, in call
return launch_agent(self._config, self._entrypoint, list(args))
File "/usr/local/lib/python3.10/dist-packages/torch/distributed/launcher/api.py", line 250, in launch_agent
raise ChildFailedError(
torch.distributed.elastic.multiprocessing.errors.ChildFailedError:
train.py FAILED
Failures:
<NO_OTHER_FAILURES>
Root Cause (first observed failure):
[0]:
time      : 2023-05-13_16:38:58
host      : 38b080a41a03
rank      : 0 (local_rank: 0)
exitcode  : 2 (pid: 993)
error_file: <N/A>
traceback : To enable traceback see: https://pytorch.org/docs/stable/elastic/errors.html

抱歉，由于部分作者只对水文章感兴趣，v1已经没人维护了。建议改用 https://github.com/transpchan/Live3D-v2 。


LocalizedPrice: Extract web styles in orbit-design-tokens

Opened by @RobinCsl

Related to #241

Don't know if it's still relevant.
(Original issue https://github.com/kiwicom/universal-components/issues/242)

Closed by: https://github.com/kiwicom/universal-components/pull/241


devtool: 'inline-source-map' broken because of typeof check

SourceMapDevToolPlugin constructor checks:
if (typeof options !== "object") { ... } else { ... }
In WebpackOptionsApply.js, for inline-source-maps, you pass null options, which is typeof "object". Need to change the check to check for null.

Nevermind. This has been fixed in latest 1.7.2


cohere - command-r

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
command-r has a new attention mechanism which is a bit different from llama2
✔ Solution
implementation of q/lora training for cohere
❓ Alternatives
No response
📝 Additional Context
https://github.com/ggerganov/llama.cpp/pull/6033 - its merged in llama.cpp already
it would be great if we can get a way to train that model as its amazing in writing / rag / function calling
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this feature has not been requested yet.
[X] I have provided enough information for the maintainers to understand and evaluate this request.

They now also released a larger, 104B parameter model: C4AI Command R+

Hey, regular training should work as-is except for sample_packing.

It never load the model on my side.

It get stuck at this step, I wanted to toy with it but I can't load the model.
This was tested on 4xH100 with the following configuration:
base_model: ./CohereForAI_c4ai-command-r-plus
model_type: AutoModelForCausalLM
tokenizer_type: AutoTokenizer

load_in_8bit: false
load_in_4bit: true
strict: false

datasets:
  - path: ./datasets/0.json
    type: sharegpt
    conversation: chatml
  - path: ./datasets/1.json
    type: sharegpt
    conversation: chatml
dataset_prepared_path: ./last_run_prepared
val_set_size: 0.05
output_dir: ./lora-out
chat_template: cohere

sequence_len: 8192
sample_packing: false
pad_to_sequence_len:

adapter: qlora
lora_model_dir:
lora_r: 128
lora_alpha: 16
lora_dropout: 0.05
lora_target_linear: true
lora_fan_in_fan_out:

wandb_project: Cohere-Noromaid
wandb_entity:
wandb_watch:
wandb_name:
wandb_log_model:

gradient_accumulation_steps: 4
micro_batch_size: 2
num_epochs: 3
optimizer: adamw_bnb_8bit
lr_scheduler: cosine
learning_rate: 0.00002

train_on_inputs: false
group_by_length: false
bf16: auto
fp16:
tf32: false

gradient_checkpointing: true
early_stopping_patience:
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: true

warmup_steps: 10
saves_per_epoch: 1
debug:
deepspeed: ./axolotl/deepspeed_configs/zero3.json
weight_decay: 0.0
fsdp:
fsdp_config:
special_tokens:

I tried without deepspeed (screenshot show that) and with it, but nothing let me load it for whatever reasons.
I tried with trust_remote_code: true also, but no luck.
Here is what I use replacing chatml template to have the correct prompt format in sharegpt.py:
def register_chatml_template(system_message=None):
    system_message = system_message or "You are a helpful assistant."
    register_conv_template(
        Conversation(
            name="chatml",
            system_template="<|START_OF_TURN_TOKEN|><|SYSTEM_TOKEN|>{system_message}<|END_OF_TURN_TOKEN|>",
            system_message=system_message,
            roles=["<|START_OF_TURN_TOKEN|><|USER_TOKEN|>", "<|START_OF_TURN_TOKEN|><|CHATBOT_TOKEN|>"],
            sep_style=SeparatorStyle.NO_COLON_SINGLE,
            sep="<|END_OF_TURN_TOKEN|>",
        )
    )

@Undi95 , can you try preprocess it separately first?
also, make sure trust remote code is on

@Undi95 , can you try preprocess it separately first?
also, make sure trust remote code is on

I always preprocess my dataset before launching a train with python -m axolotl.cli.preprocess config.yml --debug
Trust remote code was on for some try but same result

I forgot to mention that there's an untested PR for sample packing with cohere: #1547 . If anyone else is following, do you also get the same issue as Undi?


Various Java classloader compatibility problems

Some plugins tinker with the classpath or access it in non-standard ways that are incompatible with Paperclip's methods.
This ticket exists to track plugin compatibility problems and any solutions as they appear.
It does not exist to handle Java 9 classloader issues or any plugin compatibility issues that are also present running just Paper-Server without Paperclip.

that's the plugins fault, not paper's fault. If "Some plugins tinker with the classpath or access it in non-standard ways that are incompatible with Paperclip's methods." is a problem with spigot then don't worry about it.

Depends on the situation.

We've had approximately 0 real issues related to this for 2 years so I'll consider this a moot point now. If particular issues arise we can deal with them individually.


prometheus not supporting option to disable crash recovery

I have a prometheus server deployed on openshift. We are monitoring different pods, kublets etc. Ingestion rate is ~10K/second.
Polling/scraping interval: 10s
Memory assigned: 8GiB
CPU: 6 cores
Disk type: NFS/HDD
storage.local.target-heap-size: 5.7GiB
retention period: 1h
With above config, prometheus frequently runs into rushed mode(with urgency score 1) and resulting less scraping of data. If we are trying to stop it(using SIGTERM) it takes too much time(in openshift grace period of shutdown is 15m), and still does not gets shutdown gracefully. This causes crash recovery of data which again causes delay in start for 15-20m.
Can you advice, whether i can disable with crash recovery of data, so that i can work with some loss of data?
P.S. I am selectively sending metrics to influc DB using prometheus-sop.
Details of env:
deployed on Openshift 3.5
Prometheus version:v 1.8.2
Prometheus config.yml:
global:
scrape_interval: 1m
scrape_timeout: 10s
evaluation_interval: 1m
scrape_configs:

job_name: kubernetes-nodes
scrape_interval: 1m
scrape_timeout: 10s
metrics_path: /metrics
scheme: https
kubernetes_sd_configs:

api_server: null
role: node
namespaces:
names: []
bearer_token_file: /var/run/secrets/kubernetes.io/serviceaccount/token
tls_config:
ca_file: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt
insecure_skip_verify: false
relabel_configs:
separator: ;
regex: _meta_kubernetes_node_label(.+)
replacement: $1
action: labelmap
separator: ;
regex: (.*)
target_label: address
replacement: kubernetes.default.svc:443
action: replace
source_labels: [__meta_kubernetes_node_name]
separator: ;
regex: (.+)
target_label: metrics_path
replacement: /api/v1/nodes/${1}/proxy/metrics
action: replace

job_name: kubernetes-pods
scrape_interval: 10s
scrape_timeout: 10s
metrics_path: /metrics
scheme: http
kubernetes_sd_configs:

api_server: null
role: pod
namespaces:
names:

XYZ
ABC
DEF
relabel_configs:

source_labels: [__meta_kubernetes_pod_annotation_prometheus_io_scrape]
separator: ;
regex: "true"
replacement: $1
action: keep
source_labels: [__meta_kubernetes_pod_annotation_prometheus_io_path]
separator: ;
regex: (.+)
target_label: metrics_path
replacement: $1
action: replace
source_labels: [address, __meta_kubernetes_pod_annotation_prometheus_io_port]
separator: ;
regex: ([^:]+)(?::\d+)?;(\d+)
target_label: address
replacement: $1:$2
action: replace
separator: ;
regex: _meta_kubernetes_pod_label(.+)
replacement: $1
action: labelmap
source_labels: [__meta_kubernetes_namespace]
separator: ;
regex: (.*)
target_label: kubernetes_namespace
replacement: $1
action: replace
source_labels: [__meta_kubernetes_pod_name]
separator: ;
regex: (.*)
target_label: kubernetes_pod_name
replacement: $1
action: replace
remote_write:

url: http://prometheus-sop.ft-aramse:9096
remote_timeout: 30s
queue_config:
capacity: 100000
max_shards: 1000
max_samples_per_send: 100
batch_send_deadline: 5s
max_retries: 10
min_backoff: 30ms
max_backoff: 100ms

It makes more sense to ask questions like this on the prometheus-users mailing list rather than in a GitHub issue. On the mailing list, more people are available to potentially respond to your question, and the whole community can benefit from the answers provided.


Update readme to packrat data

A description of your change.

[ ] Updated CHANGELOG
[ ] Updated README.md (if necessary)

oops


Inherited styles overriding the component styles

[X] This is not a v0.x issue.
[X] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

The header class .MuiAppBar-colorPrimary should override .MuiPaper-root and hence show blue color instead of white.
Current Behavior 😯

MuiPaper-root is overiding .MuiAppBar-colorPrimary.
Steps to Reproduce 🕹

I would try to reproduce it and edit this. I thought someone might have idea whats going on.
Context 🔦

I have single app root, no jss code etc. The only extra dependency apart from default react-material stack is unstated. I see double .MuiPaper-root class, may be something is off there.
Also I haven't used even themeprovider tag or baseline anywhere
Your Environment 🌎

Tech
Version

Material-UI
v4.0.1

React
^16.8.6

Browser
Chrome

material-table
1.38.0

This issue might be related with https://github.com/mui-org/material-ui/issues/16100
Can you please screenshot how styles look like within your <head>? No matter what classes are used by the html elements, when at the same level of specificity, it all depends on the which rules are rendered the first and the latter ones will always override the former ones.

The problem seems to lie here.
import Paper from '@material-ui/core/Paper/Paper';
changing to this removed the issue.
import Paper from '@material-ui/core/Paper';

@dereksangshi if you still want the screenshot:

Thanks for this issue, for us the problem was importing Paper like this
import Paper from '@material-ui/core/Paper/index';

It took me several hours of debugging because the import was done in another component

Hi, I still have the issue but with @material-ui/lab/Alert.
My code is like
<React.Fragment>
    <AppBar position="static">
        <Tabs>
            <Tab label="Home" value="/home" />
            <Tab label="Back Test" value="/backtest" />
        </Tabs>
    </AppBar>
    <Grid container>
        {error.length > 0 ? (
            <Grid item xs={12}>
                <Alert severity="success">This is a success message!</Alert>
            </Grid>
        ) : (
            <React.Fragment></React.Fragment>
        )}

    </Grid>
</React.Fragment>;

Before showing Alert

After showing Alert


Instantiate per-thread client stub for multithreaded applications

In gRPC the underlying channel is safe for multithreaded use, but client stubs are intended to be allocated per thread.
Like this, that can be done transparently for applications
If an application wants multiple connections, it can create multiple gNMIClient instances. But like this (unlike the current code) a multi-threaded application can use a single connection and still be thread-safe and resource efficient

Note: untested, just to share what I think would be an improvement to the code


Increment version for schemaregistry releases

Increment package version after release of com.azure azure-data-schemaregistry

Closing in favor of #15060


Object Demo doesn't show textures

Hi,
Thanks for the code!
I ran the objects demo from this file, but I do not see the object textures being loaded for articulate objects, see the image below.
What might have gone wrong?

Hi,
You are visualizing with pybullet viewer. Try iGibsons viewer to see the result of iGibson rendering. Let us know if that works.

On Apr 2, 2021, at 5:28 PM, Yash Kant @.***> wrote:
Hi,
Thanks for the code!
I ran the objects demo http://svl.stanford.edu/igibson/docs/objects.html#examples from this file https://github.com/StanfordVL/iGibson/blob/master/gibson2/examples/demo/object_example.py, but I do not see the object textures being loaded, see the image below.
What might have gone wrong?
https://user-images.githubusercontent.com/17530895/113463054-d8e1a500-93f1-11eb-8de0-6d558b844428.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/StanfordVL/iGibson/issues/73, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2YQIJJRR2P2DLZUF23DRDTGZOJBANCNFSM42JUCEPQ.

Thanks for the quick reply and the suggestion, I'll try this and would reopen if I am unable to figure this out.

Hi @yashkant , we just updated the assets folder, and if you delete the gibson2/data/assets folder and run python -m gibson2.utils.assets_utils --download_assets again, you should be able to get these models with textures.


Imported normal maps become emissive

With the latest build of Blender, the "Normal" input on the Principled BSDF node moved down a couple notches to make room for Emissive etc.  The importer picks the wrong input for normal maps now, it would seem.
/cc @julienduroure
If I get time I will try to add a test for round-tripping normals, emissive, and the others.  Only ORM is tested at this point.

With the new 2 inputs of principled node (emission and alpha), index of inputs probably changed ...


Merge develop -> main

Thank you for contributing to the Cohere Toolkit!

[ ] PR title: "area: description"

Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..."  for CI changes.
Example: "deployment: add Azure model option"

[ ] PR message: Delete this entire checklist and replace with

Description: a description of the change
Issue: the issue # it fixes, if applicable
Dependencies: any dependencies required for this change

[ ] Add tests and docs: Please include testing and documentation for your changes

[ ] Lint and test: Run make lint and make run-tests

AI Description

This PR introduces changes to the backend and interface systems, including:

Backend:

Added a new function get_files_by_user_id to the file.py module, allowing retrieval of files associated with a specific user ID.

Modified the update_file function in file.py to include a new parameter, new_file, which is an instance of UpdateFile.

Updated the call_tools function in custom.py to include a logger that provides information about tool results.

Modified the upload_file function in conversation.py to validate file size before uploading.

Removed the FileService class and associated methods (upload_file, delete_file, and generate_new_filepath') from service.py. The file uploading and deletion logic has been refactored and moved to the upload_fileanddelete_filefunctions inconversation.py`.

Updated the get_file_content function in tools/files.py to handle different file types, including PDF, text, Markdown, CSV, JSON, and Excel.

Added a new function, get_file_extension, to services/file.py to retrieve the file extension from a given file name.

Introduced a new file, services/file/__init__.py.

Modified the test_list_files_by_conversation_id_empty test case in tests/crud/test_file.py to include additional assertions for user ID.

Created a new test case, test_list_files_by_user_id, in tests/crud/test_file.py to verify the functionality of the get_files_by_user_id function.

Updated the RouterName.TOOL configuration in routers.py to include Depends(get_session) in the "default" list.

Modified the main.py module to include a global exception handler and a logger instance.

Updated the pyproject.toml file to specify the openpyxl package version as "^3.1.5".

Interfaces:

Added a new workflow configuration file, slack_bot_tests.yml, for testing the Slack bot interface.

Modified the coral_web_tests.yml workflow configuration file to rename the workflow to "Coral Web Tests".

Updated the client.ts file in the coral_web interface to include a change in the HEADERS property initialization.

Changed the error handling logic in the _app.tsx file of the coral_web interface to check for a specific error message.

Added a new file, AuthLink, to the components folder of the coral_web interface.

Modified the login.tsx file in the coral_web interface to include the AuthLink component and update the form submission logic.

Updated the package.json file in the slack_bot interface to change the version of the "pdfjs-dist" package to "3.11.174".

Added a new file, .nvmrc, to the slack_bot interface, specifying the Node.js version as "v20.12.2".

Modified the README.md file in the slack_bot interface to include new configuration commands: /set-deployment and /view-deployment.

Updated the example-manifest.yaml file in the slack_bot interface to include the new configuration commands and their respective URLs and descriptions.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.13%. Comparing base (9125660) to head (e8513e3).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
- Coverage   86.46%   81.13%   -5.34%
==========================================
  Files         178      198      +20
  Lines        6873     8355    +1482
==========================================
+ Hits         5943     6779     +836
- Misses        930     1576     +646

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Updating Pasqal classes

Significant modifications to the first version of the pasqal module. Most relevantly:

PasqalDevice was modified to be the parent class of all Pasqal devices. Also allows submission of nearly unconstrained circuits to Pasqal processors.
PasqalVirtualDevice enforces the constraints of a near-term Pasqal QPU.
ThreeDGridQubit was renamed ThreeDQubit (and TwoDQubit was created as a subclass).
More flexibility in the accepted qubits (PasqalVirtualDevice can also work with GridQubit and LineQubit)
More adequate accepted gate set, now consistent with the hardware

New additions:

Documentation (docs/pasqal) and "getting_started" tutorial

The check that is failing has to do with the new documentation files (in docs/pasqal) not being in any toctree. I don't want to mess with the structure of your documentation, so I think it should be up to you to decide where to list them. Please, feel free to do so! Otherwise, you can just tell me where you would like me to add them and I will do so. Thanks!

Hi @balopat, thank you very much for the remarks! You are absolutely right, these are all accidental and unrelated to our classes. I will  clean up every change that didn't come from our side ASAP, thank you for your patience.

Hi again @balopat, it should be okay now. I apologise for the trouble!

Hi again @balopat, thank you for your time and help so far. Regarding your recommendation, I understand your point. However, these changes are very much intertwined, so it is easier said that done. Let me elaborate on what I think, realistically, can be done:

Separating the docs is an easy split, which should already remove 8 files from the PR.
The remaining 20 are all interconnected and it is essentially impossible to contain a change to only 10 (e.g. changing ThreeDGridQubit to ThreeDQubit alone will touch nearly all of them). However, I should point out that out of these 20 files, 11 are small changes related to json serialization (either files that are deleted, added or very slightly changed) and are thus very straightforward to review.
That being said, an effort could still be made into focusing each PR on specific changes. I agree with your division, but in reality points 1-4 are very hard to dissociate. If you insist, I believe we could make 5. into a separate PR though.

To summarise,  I suggest we divide the PR into a big PR (points 1-4 or 1-5), followed by one or two smaller PR's (just 6 or 5 and 6). I understand this is not ideal, but it is really impossible to naturally dissociate the changes in the Qubit classes and the Device classes, since they influence one another. Plus, forcing this split would still entail a disappointingly small reduction in the number of files per PR.

Hey @HGSilveri,
Thanks for thinking this through with me! This sounds good, let's do 1-4, 5, 6 separately then. It is not only about the number of files. It is also about the number of concepts that change or are introduced in a PR. Last year when I developed the QASM Importer, I ran into the same issue with only 11 files that I broke out and got much faster reviews - well it still took some time, but at the end it was really easier on the reviewers (https://github.com/quantumlib/Cirq/pulls?q=is%3Apr+is%3Aclosed+author%3Abalopat+qasm+import). Thank you!

As discussed above, the PR will be closed in favour of a split into smaller PR's.


fix: codecov not valid tokenless upload

What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
fix codecov not valid tokenless upload error like this: https://github.com/openyurtio/openyurt/actions/runs/10227408471/job/28298818547
The fixes are suggested from https://github.com/codecov/codecov-action/issues/1487#issuecomment-2225600449
Special notes for your reviewer:

@rambohe-ch
Does this PR introduce a user-facing change?

other Note

/LGTM


Image handling

Goal
Correctly handle images from Word documents to avoid Arelle validation errors.
Background
Right now, we have very basic functionality to convert Word documents to iXBRL, but we need to improve the conversion. One issue is that the word-to-HTML conversion package defaults to directly imbeding images into the HTML with URIs, but that is not valid XBRL, so it doesn't validate properly.  We instead want to save the images separately and then imbed the filepaths to the images in the xbrl (using <img> tags).
Tasks

[x] Checkout this branch (28-image-handling), which will include all changes from #7
[x]  Create a folder (if it doesn't exist) to save the images. This should probably be app/static/img/
[ ] The WordDoc class has all the conversion methods. Take a look at the script in app/models/word_doc.py (you can ignore the comment class for now). The first step in the conversion uses the mammoth package on line 63.
[ ] I think the best way to do this will be to edit the convert_image function (called in line 63). It should take the image as input, save it in the img folder, and return the location. If this strategy isn't working, feel free to try something else.
[x] Ultimately, we'll need to add sessions to the Flask app (#7), so that each users' images are saved in individual folders and then deleted after use. (This is the only way we could have simultaneous use of the web app). This isn't top priority for the SEC demo, but If you want to implement this now while doing the image handling, feel free. I'll also assign you #7.

Also:

[ ] Add support for Prop Funds Statement of Net Position
[ ] Edit html to open viewer in new tab

@kwheelan Hi I want to check on how this works

Where can I find an example of where an object is made using this class?
So it looks like convert_to_html takes in a Docx file. mammoth.images.img_element is calling the function I need to work on, which is self.convert_image. I want to check that you want this function to take in an 'image', which is a docx file?

I was reading https://github.com/mwilliamson/mammoth.js?tab=readme-ov-file#image-converters but I'm not sure if self.convert_image
`
class WordDoc:
""" Class to represent a Word file """
def init(self, docx_file):
self.html_content = self.convert_to_html(docx_file)
def convert_to_html(self, docx_file):
""" Use mammoth to extract content and images """
result = mammoth.convert_to_html(docx_file, convert_image = mammoth.images.img_element(self.convert_image))
def convert_image(image):
"""
Save the image; return a dictionary {"src" : }
"""
`

@lucakato

Assuming you mean the WordDoc class, it's used when creating an ACFR object, which is created when processing the ACFR. More specifically:

If you upload a Word file on the app, you'll send a POST request to the /upload route, which calls the upload_file() function in routes.py.
In line 58 of routes.py, we call the write_html() function, which is defined in utils/xbrl_processing.py.
write_html() creates an ACFR object to store all the uploaded data. This object is created in line 42 of  utils/xbrl_processing.py
When the ACFR object is created, it stores an ordered list of all the ACFR contents, which include the tables from Excel and also the Word documents. This happens in the handle_multiple_docs() function in the models/acfr.py files. For each file, the function checks if it's a spreadsheet. If so, it creates a list of tables to be converted to inline XBRL. If the file is not a spreadsheet, it assumes it's a Word doc, and creates a WordDoc object from the file (line 26 of acfr.py).

In writing this, it's clear I need to improve my docstrings and other documentation. I'll work on this, but please feel free to add clarifying comments to the code as you go along as well.

The 'image' parameter in the convert_image function refers to an individual image element from the Word (.docx) file being processed, not to the entire Word document. The image parameter is a custom object defined by mammoth. When Mammoth encounters an image in a Word document, it invokes the callback function we specify – in this case, self.convert_image.

Here is the rough process that should happen in convert_image:
def convert_image(image):
    """
    Take an image object from the Word document and:
    - Read the underlying data
    - Save it with a unique name in the relevant session folder
    - Return its relative source path
    """
    # example pseudocode for the function
    image_data = image.readAsBase64String()  # or any other method based on your implementation
    image_path = save_to_server(image_data)  # function that saves image data to server and returns the relative path
    return {"src": image_path}

Let me know if you have any other questions!

@kwheelan thanks for the clarification it makes more sense.
I tried just calling image.readAsBase64String() but I get AttributeError: 'Image' object has no attribute 'readAsBase64String' and I'm looking into that but if you have any ideas please let me know too, you can see my code in the branch.
Image type and Image content show that it is an Image object made by Mammoth.

Hmm if that built-in function isn't working, you might have to try something like image.open().read() to get the binary. Let me know if that helps or if you're still stuck. I'll have time on Monday to take a closer look if needed.

@kwheelan Yep I changed it to
        with image.open() as image_bytes:
            encoded_src = base64.b64encode(image_bytes.read()).decode("ascii")

        return {
            "src": "data:{0};base64,{1}".format(image.content_type, encoded_src)
        }

based on https://pypi.org/project/mammoth/#image-converters
still getting an error, not sure if it's to do with Mammoth or the other files like table.py

@lucakato
The code snippet you included will encode the image directly into the converted HTML with URIs, which is what we're trying to avoid (because it isn't valid inline XBRL). We want to read the image object (probably by reading in the binary as you have, but there might be another way), and then save the image as a file, which the HTML will reference inside an <img> tag.
The error does look unrelated, but I can't tell the source from the error log. It might have to do with the format of the sample Excel you uploaded? Which document did you upload?
Keep trying a bit with this image issue, but if you can't figure it out by our meeting on Tuesday, I can assign you something else. I'll also do some research in the meantime. It's definitely not straightforward, so thanks for spending time on this.

I think the second error was a mistake on my end I was using basic_test.xlsx, error didn't show when I used Clayton.xlsx
I will see if there's other ways. Thanks!

@kwheelan Just to check, when you say 'save as a file' does it have to be in a file type like .png etc?

I think I may have got it working, could you check output/9ef...
please on #38
I tested this on Clayton.xlsx and like 3 docx files. Here are some of the images saved

While converting from Excel to inline XBRL I did still see the error comments appear a few times, although in the end everything ran. It may be this XML file syntax issue (last image pasted)

Great! Saving these as a png is perfect. I think the errors might be because the documents don't have any comments, but we can debug it when we work on the comment parser (not a top priority for the demo).
I'll take a look at your code tomorrow morning and merge if it's ready. In the meantime, feel free to return to #7 to figure out deleting sessions folders and/or start on #37 to improve the file uploads.

@lucakato This code runs without errors, but I can't get it to actually render the images in the output file. Were you able to see the images in the output XBRL viewer when you ran it?

@kwheelan Do you mean the inline viewer? I couldn't find this bar chart but I was able to view the black lines that are saved as images.

Hmm I'll look again for those, but I don't see any  tags at all in the output html. I did move the save location for the images, so I might have broken something on my end

@kwheelan Hi, do you know if graphs are for certain to be represented using <img> tags in HTML?
I tried using an online converter to see what CA-Clayton-2022-Statistical-Section would look like as html. I emailed you the file just now because I can't paste it in here. But basically I tried inspecting the source of the charts as an HTML format, and maybe this online convert is not that reliable because it may do it completely differently to XBRL, but I don't see  tags for graphs.
Wondering if this could be why we don't see any of those images once converted.

@lucakato I took a quick look at the converted HTML, and it looks like the online converter maybe just used a bunch of CSS styling on spans to represent the graphs. We definitely want to use <img> tags instead (even if that requires the user to represent charts as images instead of Word charts in the original Word docs). Don't worry about the images for now -- I think I have a workable images solution for the demo (on branch 30-support-for-new-tables), but it doesn't include any of the sessions edits.
If you can close up #7 by figuring out how to delete sessions folders after use and editing any relevant download links, I'll merge it with my images solution after the demo. Post demo, we can spend some time going over the whole code base, and I'll spend time documenting stuff better for you.

@kwheelan sounds good will work on it thank you.

Closed in #51


Docker image for v0.14.1 release does not exist

You guys released v0.14.1 a couple hours ago but the image doesn't exist:
$ docker pull gcr.io/heptio-images/contour:v0.14.1
Error response from daemon: manifest for gcr.io/heptio-images/contour:v0.14.1 not found

I wanted to roll it out to our fleet but the pods immediately errored on the image pull. Would be great if you fixed that so we can upgrade. :) Thanks for Contour!

Oops. Fixing now

On 2 Aug 2019, at 19:34, Daniel Lohse<EMAIL_ADDRESS>wrote:
You guys released v0.14.1 a couple hours ago but the image doesn't exist:
$ docker pull gcr.io/heptio-images/contour:v0.14.1
Error response from daemon: manifest for gcr.io/heptio-images/contour:v0.14.1 not found
I wanted to roll it out to our fleet but the pods immediately errored on the image pull. Would be great if you fixed that so we can upgrade. :) Thanks for Contour!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Successfully built a36c38f2ae01
Successfully tagged gcr.io/heptio-images/contour:v0.14.1
docker push gcr.io/heptio-images/contour:v0.14.1
The push refers to repository [gcr.io/heptio-images/contour]
6b4ac599e96f: Preparing
6b4ac599e96f: Pushed
v0.14.1: digest: sha256:4405a52be5c8000a78c6f75d26054a92c766a007f05a506531c9b60ba0e944b1 size: 529
Finished: SUCCESS

Thank you, Dave! Hopefully I didn't wake you with this – you tagged the release and it's only been 7 hours… 🙈


Reset notification progress state

Hello,
I've been doing some research on the codebase, and it seems the notification progress mechanism only allows to move forward by incremental step. While I understand the purpose, I wished it remained fairly abstract so we could eventually pass absolute values and that the API rather control the values than enforce them.
Here's what i'm talking about:
https://github.com/microsoft/vscode/blob/a3c64dac8d7aa97e6571445b1233ab0cc014bc47/src/vs/workbench/services/progress/browser/progressService.ts#L343-L350
There are several cases where the implementation isn't ideal:

When you download a file, you end up doing calculation because some (most) API express the download in absolute values such as bytesLoaded and bytesTotal
More generically when the total isn't 100, you end up doing 100 * value / total by yourself because the total is set in stone - if it wasn't, instead of calculation we'd do declaration which is nicer in writing.

For this reason, I think a better API would be:
type RelativeProgressValues = {
  increment: number
  total?: number
}

type AbsoluteProgressValues = {
} | {
  value: number
  total: number
}

type ProgressValues = RelativeProgressValues | AbsoluteProgressValues

const updateProgress = (notification: INotificationHandle, progressValues?: ProgressValues): void => {
  if (!progressValues) {
    notification.progress.infinite();
  } else if (typeof progressValues.increment === 'number' && increment >= 0) {
    notification.progress.worked(progressValues.increment);
    notification.progress.total(progressValues.total ?? 100);
  } else if (typeof progressValues.value === 'number') {
    notification.progress.state.worked = undefined // ← we need a a way to reset the worked value without firing an event there
    notification.progress.worked(progressValues.value);
    notification.progress.total(progressValues.total ?? 100);
  }

and change the use a bit in here to match the changes internally:
https://github.com/microsoft/vscode/blob/a3c64dac8d7aa97e6571445b1233ab0cc014bc47/src/vs/workbench/services/progress/browser/progressService.ts#L365-L385
such as:
   if (typeof step?.increment === 'number' || typeof step?.value === 'number') {
     updateProgress(notificationHandle, step);
   }

That would probably work quite well except for the notification.progress.state.worked = undefined part which isn't ideal but there's no other way to reset the state otherwise, as you can see here:
https://github.com/microsoft/vscode/blob/a3c64dac8d7aa97e6571445b1233ab0cc014bc47/src/vs/workbench/common/notifications.ts#L339-L408
and more closely here:
https://github.com/microsoft/vscode/blob/a3c64dac8d7aa97e6571445b1233ab0cc014bc47/src/vs/workbench/common/notifications.ts#L396-L407
but we could maybe patch this to allow this state reset:
  // use undefined as a token of reset
  worked(value: number | undefined = undefined): void {
    if (typeof this._state.worked === 'number' && typeof value !== 'undefined') {
      this._state.worked += value;
    } else {
      this._state.worked = value;
    }

    this._state.infinite = undefined;
    this._state.done = undefined;

    this._onDidChange.fire();
}

The desired implementation behind is to do:
import { Progress, ProgressLocation, window } from 'vscode';

export class ProgressToast {
  public modal: null | Progress<any> = null;

  constructor(
    public title: string,
    public value: number,
    public timeout: number = 5000,
  ) {}

  async show(message: string, value: number, total: number) {
    if (this.modal) {
      this.modal.report({ message, value, total });
      return;
    }

    window.withProgress({
      title: this.title,
      location: ProgressLocation.Notification,
    }, progress => {
      return new Promise<void>((resolve) => {
        this.modal = progress;
        this.modal.report({ message, value, total });

        setTimeout(() => {
          this.modal = null;
          resolve();
        }, this.timeout);
      });
    });
  }
}

which would be later used as myToast.show('upload in progress', bytesLoaded, bytesTotal)
Thanks for reading 🙏

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

😞

Let me see
On Thu, 29 Dec 2022, 4:33 pm Julien Barbay, @.***>
wrote:

Closed #166342 https://github.com/microsoft/vscode/issues/166342 as
completed.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/166342#event-8126544984, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A3BNOT3ZEZSSLZT3UOQA6CDWPWOKLANCNFSM6AAAAAASASVPFY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


RadialMenu Z-Position

Hi. What a great library !
I just integrated it in JSQMessagesViewController that I ported to Xamarin and everything is great. However, when I integrated MTZRadialMenu as a view inside RightBarContainerView of JSQInputToolBar, I noticed that the grey background of the menu will be blocked by the textview and appear behind it so I fixed it like this :
  this.ContentView.TextView.Layer.ZPosition = -99;

However, I still have a problem when the menu expands into it's full position, I could never be able to touch the 'X' or 'Up' buttons .. only the stop recording button is touched .. I can however drag from the stop recording to the 'x' or 'up' button but if i release and try to click directly on 'x' or 'up', i'm actually clicking the things behind them (TextView of input or CollectionView)
I think it may be a z-position issue or something else .. Can you please help in fixing this or point me in the right direction ?
Here is how it appears in simulator :

and here in Reveal :

Thanks

Hi @mdznr, can you please help or put me in the right direction to solve this ? Thanks

Hi @mdznr, i have same problem. plz help me!

Why set the text view’s z-position to be lower? Can the menu’s z position be set to be higher?


Autocomplete is hidden behind overlay

Describe the bug
There are two separate issues here but I was able to reproduce them in the same CodeSandbox so I figured I would create just one issue.

When I put an AutoComplete inside an Overlay the autocomplete's overlay goes behind the parent Overlay. Is there a way to get around this or is this a bug?
The Overlay does not position based on the anchorRef, it's always in the top-left of the screen. This is reproducible in the docs actually.

To Reproduce
Steps to reproduce the behavior:

Go to this CodeSandbox

Expected behavior
I would expect the AutoComplete's overlay to be on top of the parent's overlay because the autocomplete overlay was opened at a later time.
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS] macOS 12.2.1
Browser [e.g. chrome, safari] Chrome
Version [e.g. 22] 99.0.4844.51 (Official Build) (arm64)

Hi!

When I put an AutoComplete inside an Overlay the autocomplete's overlay goes behind the parent Overlay. Is there a way to get around this or is this a bug?

This is definitely a bug. I couldn't come up with a quick workaround for it.

The Overlay does not position based on the anchorRef, it's always in the top-left of the screen.

Yep! You might want to use AnchoredOverlay instead. It supports renderAnchor for writing the anchor along with the AnchoredOverlay and anchorRef if it's an external anchor.

Thanks for taking a look at this @siddharthkp . I couldn't think of any good workarounds with Autocomplete.Overlay either. Using AnchoredOverlay is probably the best way forward for now.

Ignore my last comment. I was able to work around this by following the Nested Overlay example in Storybook.
We just need to make sure the autocomplete overlay is rendered after the overlay it's nested in.
Here's working code:
  const inputRef = useRef<HTMLInputElement>(null)

  const [isOpen, setIsOpen] = useState(false)
  const [isAutocompleteOpen, setIsAutoCompleteOpen] = useState(false)
  const handleOpen = () => {
    setIsOpen(true)
    inputRef.current && inputRef.current.focus()
  }

  return (
    <AnchoredOverlay
      open={isOpen}
      onOpen={handleOpen}
      onClose={() => setIsOpen(false)}
      width="large"
      height="xsmall"
      focusTrapSettings={{initialFocusRef: inputRef}}
      side="inside-top"
      renderAnchor={props => <ButtonInvisible {...props}>open overlay</ButtonInvisible>}
    >
      <Autocomplete>
        <Box display="flex" flexDirection="column" height="100%">
          <Box
            paddingX="3"
            paddingY="1"
            borderWidth={0}
            borderBottomWidth={1}
            borderColor="border.default"
            borderStyle="solid"
          >
            <Autocomplete.Input
              block
              as={TextInput}
              ref={inputRef}
              id="autocompleteInput"
              onFocus={() => {
                setIsAutoCompleteOpen(true)
              }}
              sx={{
                display: 'flex',
                border: '0',
                padding: '0',
                boxShadow: 'none',
                ':focus-within': {
                  border: '0',
                  boxShadow: 'none'
                }
              }}
            />
          </Box>
          {isAutocompleteOpen && (
            <Autocomplete.Overlay>
              <Autocomplete.Menu
                items={[
                  {text: 'css', id: 0},
                  {text: 'css-in-js', id: 1},
                  {text: 'styled-system', id: 2}
                ]}
                selectedItemIds={[]}
                aria-labelledby="autocompleteLabel"
              />
            </Autocomplete.Overlay>
          )}
        </Box>
      </Autocomplete>
    </AnchoredOverlay>
  )

Have a similar problem with ActionMenu in Dialog


What does convertSize do?

First off, thanks for sharing this lib!
I wonder what convertSize does? Does it have something to do with compression and how is it then different from the quality option?
Thanks

See #2


NFT showing in 2 different wallets at the same time

I created a NFT on my mac wallet and sent to a different wallet on windows. The NFT is now showing in both wallets ?

Hi there. Does the issue persist if you close and re-open the app with the wallet that isn't supposed to have the NFT?

This is being worked on as a part of #150 and #151


Seclists: not able to extract archived resources as rockyou.txt

Describe the bug
Seclists has some common used resources, as rockyou.txt, that are compressed. I know that a user can copy and paste on home folder the archives, and then unzip them. But what I propose is to uncompress all .tar.gz files in the repository at building time of the package to make them immediately available for the users after install.
The .tar.gz files are:
seclists/Passwords/Leaked-Databases/rockyou-withcount.txt.tar.gz
seclists/Passwords/Leaked-Databases/rockyou.txt.tar.gz

Notify maintainers

@Tochiaha @Pamplemousse
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.41, Athena OS, 24.11 (Vicuna), 24.11pre655874.68c9ed8bbed9`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

Actually, rockyou is packaged...
$ nix-shell -p 'wordlists.override { lists = with (import <nixpkgs> {}); [ rockyou ]; }'
...

$ wordlists
/nix/store/vxwq7ba089nffxfv4ii335xzaxf4v7p3-wordlists-collection/share/wordlists
└── rockyou.txt -> /nix/store/66b599j6m4fx26d3cvh644zqpq3bnpvm-rockyou-2024.2/share/wordlists/rockyou.txt

1 directory, 1 file

$ head -n2 /nix/store/66b599j6m4fx26d3cvh644zqpq3bnpvm-rockyou-2024.2/share/wordlists/rockyou.txt
123456
12345
123456789
password
iloveyou

Not sure what is the sense to have two separated packages for the same source repository, mostly when rockyou package provide one single file. What do you think to merge it to seclists and keep only this last one?

for the same source repository

Not sure what you mean by this.
SecLists is a "list aggregator", and we don't have control over what it adds or not: We don't know if it will keep the rockyou list, and the package doesn't allow any granular picking of the lists.
I don't see the harm of having rockyou being standalone. Even more: I would rather have the ability to get rockyou  (134MB) without all the other lists that seclists are providing (2GB).
FYI, we added security lists to be used with the wordlist package. See #104712 for historical reference, and #260240.
Concerning the topic of the issue, you are welcome to add the archive extraction steps to the seclists package: https://github.com/nixos/nixpkgs/blob/master/pkgs/by-name/se/seclists/package.nix#L17-L25 .
However, be mindful: the package already takes 2GB of space on disk. Extracting everything will probably make the whole package balloon.
Probably you can rework the package to make extraction optional, and maybe even granular (allow user to only extract lists of their choice, instead of everything).

https://github.com/NixOS/nixpkgs/pull/329917


Added Slovak language (sk_sk.json)

Added Slovak language support for ppl from Slovakia

Had to update the font texture, but I'll merge it now, thank you!


Can't add songs in 0.7.1h

Describe your problem here.
I Added a song in the template mod, and it wouldn't work, if this doesn't work i'm just sticking to another engine i guess.
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, I Extracted Template Mod

the music goes in mod/songs, not mod/music

No i did everything i can even see my week or songs

Need more information. How does it not work?

So when i see my mod in the mods section of the engine it doesnt work i enabled it and nothing

Do the songs not show up in the Story Mode/Freeplay menu?

no it doesnt

Can you load your mod's assets from the main menu? (Press 7 on the main menu and press right or left till your mod shows up at the body)

thanks

Did your songs show up again?

hold on

same problems happening to me, i'm trying to add a song from starecrown definitive edition to the newest psych engine version but it doesn't do shit


Infinite scrolling no longer triggered inappropriately when the scroll view's content size is taller than its frame's height.

On UIScrollView+SVInfiniteScrolling.m's 'scrollViewDidScroll:', scrollOffsetThreshold would calculate a negative value whenever the scroll view's content size was less than the scroll view's frame's height. Under such conditions, infinite scrolling would get triggered when scrolling upwards.

I'm not sure what is your problem but try below code:
Hi I merged #260 code to https://github.com/LawrenceHan/SVPullToRefresh
Because it make more sense to me.
It will solve your problem. Let me know if it's not working in your project.


Darwin Core Geography Vocabulary terms do not have an assigned Layer property

The section heading notes for the AC Geography Vocabulary in the term list document declared that all geography terms from the Darwin Core version of 9 Dec 2009 were deemed to be included in the "Core Layer".  However, section of the term list document describing the Layers system calls them Layer 1 and 2, and specifies that "Implementers of AC representations should provide for at least Layer 1 if possible and application writers should provide for robust treatment of Layer 1 terms, of only by ignoring them."
So does "Core Layer" mean Layer 1?  If so, are we actually expecting providers to provide values for things like dwc:maximumDepthInMeters for organisms on land?
As things stand, I've explicitly listed in the term list document all of the terms organized under the dwc:Location class.  But their Layer has been left blank because of this issue.

Draft proposal for removing Layers from Audubon Core is here.  Commenting is turned on.

Note proposed change 37 in the Audubon Core term revisions Google doc


[chore] Look back into storybook configs

What needs to be done
During the run of storybook, there seems to be some errors that appear when trying to activate anything related to post as.
This was found part the storybook updates.

Closing


[Feature Request] Add support of Snakebite's poison

I know that you are busy right now with the next major update (btw, how is it going?), but still.
Don't think it's gona be hard, just smth similar to the Consuming Dark effect or that one from Cospri's Will in combine with max frenzy charges turned on on 'Calc's tab.

Fairly easy change. I just pushed it out in an update.
As for the major update, it's coming along nicely. I think I'm just about done with the changes to the backend systems. The bulk of the remaining work is for the new Calcs tab, which I'm super excited about by the way. It's way more powerful and streamlined than the current design. I think it'll be worth the wait :). I'm not sure how much longer it's going to take though; I haven't had much time to work on it lately, although there's not a huge amount of work left to do.


Support for Null Safety

Could you please provide the Support for Null Safety

yes, It's in progress, we will update


Description of wink - adding Cms

First off, great package!  this is something i've been looking for for a while.  A package that can handle my cms needs within my app.
However, I did have a difficult time finding it.  I've been looking for cms package not a publishing platform.
May I suggest adding Cms to the title.  For example:
"A Laravel-based publishing platform" to "A Laravel Cms and Publishing Package".
I think it would create more awareness for this awesome package and its structure appears to follow the Laravel Official Packages like Telescope rather than being its own standalone platform.

Thanks. Will add that :)


TN-351 formatted test_communication.py through test_dict_tools.py

Hello @John0Randolph! Thanks for submitting the PR.

In the file tests/test_demographics.py, following are the PEP8 issues :

Line 102:26: E127 continuation line over-indented for visual indent
Line 102:80: E501 line too long (85 > 79 characters)
Line 145:16: E127 continuation line over-indented for visual indent


Vec OutpointValue is not an iterator

Trying to make use of the contrub/install.sh The following warning comes by:
Compiling rgb20 v0.8.0-rc.4
error[E0599]: Vec<OutpointValue> is not an iterator
--> /home/rgbalice/.cargo/registry/src/github.com-1ecc6299db9ec823/rgb20-0.8.0-rc.4/src/create.rs:63:41
|
63 |         let issued_supply = allocations.sum();
|                                         ^^^ Vec<OutpointValue> is not an iterator; try calling .into_iter() or .iter()
|
= note: the following trait bounds were not satisfied:
Vec<OutpointValue>: Iterator
which is required by &mut Vec<OutpointValue>: Iterator
[OutpointValue]: Iterator
which is required by &mut [OutpointValue]: Iterator
error[E0599]: no method named into_assignments found for struct BTreeMap in the current scope
--> /home/rgbalice/.cargo/registry/src/github.com-1ecc6299db9ec823/rgb20-0.8.0-rc.4/src/create.rs:81:27
|
81 |                 inflation.into_assignments(),
|                           ^^^^^^^^^^^^^^^^ method not found in BTreeMap<OutPoint, u64>
For more information about this error, try rustc --explain E0599.
error: could not compile rgb20 due to 2 previous errors
error: failed to compile rgb20 v0.8.0-rc.4, intermediate artifacts can be found at /tmp/cargo-install8qHU5P
Downloaded bp-cli v0.8.0-alpha.2

@Goosie was the issue fixed by #20? I just merged it


[com.google.fonts/check/mandatory_glyphs] [code: empty] empty .notdef should FAIL instead of WARN

Observed behaviour
WARNS tend to be ignored, and an empty .notdef shouldn't be ignored imo. Users may not notice a glyphs is missing if the .notdef is a space, particularly for users who are not familiar with the content for which they make a website etc.
⚠ WARN: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)
⚠ WARN Glyph '.notdef' should contain a drawing, but it is empty. [code: empty]
Expected behaviour
Missing glyphs in font must be obvious, so I would propose to make it a FAIL instead of a WARN, for the Google Fonts profile at least.
@vv-monsalve @yanone @m4rc1e @davelab6 do you agree? thumbs up if yes.

This is a duplicate of #4093, and I fixed it in #4236.


Plugin is not working with Grails 5

First of all, very thanks for this nice plugin! I was using it with Grails 4, and it worked like a charm. Now, I've updated Grails version to 5.1.1, and it stopped working. When I try to run the application, I get the following error:
2022-01-03 12:20:04.915 ERROR --- [  restartedMain] o.s.boot.SpringApplication               : [        -                ] Application run failed
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'quartzScheduler': Invocation of init method failed; nested exception is org.quartz.SchedulerConfigException: DataSource name not set.

Are there any workaround to set the DataSource name? Thanks in advance.

This looks like my issue when upgrading my application to 5.1.1  This is how I corrected the error, I Included this in my build.gradle file.
implementation 'org.quartz-scheduler:quartz:2.2.1' // Is not pulled in by default

Please try setting this in the application.groovy (yml) (apart adding the dependency already mentioned):
quartz.jobStore.'class' = 'org.springframework.scheduling.quartz.LocalDataSourceJobStore' // previosly 'org.quartz.impl.jdbcjobstore.JobStoreTX'

more info here https://github.com/spring-projects/spring-framework/issues/27709#issuecomment-975661609

Any update here? Is the plugin no longer maintained?

Could you please verify if solutions suggested above in the previous comment by works or NOT?
I didn't get a chance to work on the plugin yet. I would appreciate if someone from the community try to help with the upgrade that way I will able to quickly push out a release soon.

Yes, I have already been using the followings with my Grails 4.x version and it has been working fine for a year-
implementation("org.quartz-scheduler:quartz:2.3.2") {
    exclude group: "slf4j-api", module: "c3p0"
}

After upgrading to Grails 5.2.3, I don't see any errors but the jobs aren't getting triggered.
When I'm adding quartz.jobStore.'class' = 'org.springframework.scheduling.quartz.LocalDataSourceJobStore', I'm getting the following exception-
2022-12-27 15:29:03.726 DEBUG [  restartedMain] org.mongodb.driver.connection            : Closing connection connectionId{localValue:2, serverValue:2}
2022-12-27 15:29:03.776 ERROR [  restartedMain] o.s.boot.SpringApplication               : Application run failed

org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'quartzScheduler': Invocation of init method failed; nested exception is org.quartz.SchedulerConfigException: No local DataSource found for configuration - 'dataSource' property must be set on SchedulerFactoryBean
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1804)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:620)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
        at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
        at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
        at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
        at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
        at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:936)
        at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
        at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
        at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:147)
        at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:734)
        at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:408)
        at org.springframework.boot.SpringApplication.run(SpringApplication.java:308)
        at grails.boot.GrailsApp.run(GrailsApp.groovy:99)
        at grails.boot.GrailsApp.run(GrailsApp.groovy:485)
        at grails.boot.GrailsApp.run(GrailsApp.groovy:472)
        at com.letscooee.Application.main(Application.groovy:11)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at org.springframework.boot.devtools.restart.RestartLauncher.run(RestartLauncher.java:49)
Caused by: org.quartz.SchedulerConfigException: No local DataSource found for configuration - 'dataSource' property must be set on SchedulerFactoryBean
        at org.springframework.scheduling.quartz.LocalDataSourceJobStore.initialize(LocalDataSourceJobStore.java:97)
        at org.quartz.impl.StdSchedulerFactory.instantiate(StdSchedulerFactory.java:1368)
        at org.quartz.impl.StdSchedulerFactory.getScheduler(StdSchedulerFactory.java:1579)
        at org.springframework.scheduling.quartz.SchedulerFactoryBean.createScheduler(SchedulerFactoryBean.java:679)
        at org.springframework.scheduling.quartz.SchedulerFactoryBean.prepareScheduler(SchedulerFactoryBean.java:616)
        at org.springframework.scheduling.quartz.SchedulerFactoryBean.afterPropertiesSet(SchedulerFactoryBean.java:504)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1863)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1800)
        ... 22 common frames omitted

Hey, I apologise.
Actually, this is not an issue for me. Job is working fine for me on Grails 5.2.3. I had an immediate statement in my execute method-
def execute() {
        if (KernelUtils.isLocalEnvironment()) {
            log.debug "Not executing ${this.class.name} in local environment"
            return
        }

        ...
}

Sorry for the noise 😔

I'm having the same issue on Grails 5.2.3  (I've upgraded from Grails 2) with the following dependencies:
    implementation('org.quartz-scheduler:quartz:2.3.2') {
        exclude group: 'slf4j-api', module: 'c3p0'
    }
    implementation 'org.grails.plugins:quartz:2.0.13'

I have a lot of jobs and triggers registered at startup like this:
`    Trigger createTrigger(FirstmoverExport export) {
try {
Trigger trigger = new CronTriggerImpl(triggerName(export), TRIGGER_GROUP, export.cron)
trigger.jobDataMap.putAll([desc: "First mover export - ${export.id} - ${export.cron}", id: export.id])
        return trigger
    } catch (all) {
        log.error "cannot create first mover trigger with ${export.id} and ${export.cron}"
        return null
    }
}`

All of this happens without error but all of the jobs and triggers are empty when I try to debug:

        def jobGroupNames = quartzScheduler.getJobGroupNames()
        def triggerGroupNames = quartzScheduler.getTriggerGroupNames()


hash functions implementation

woot!

Arf still a bug in x86. I have to go now, I'll fix that this afternoon.

There is an implementation for the 64bit hash on 32 bits platform in the same location.

I know, that is what I planned to add.


Temporary disable codecov report upload

Summary
Temporary disable codecov report upload - secrets.CODECOV_TOKEN is missing.
Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

[ ] The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
[ ] The PR has a Milestone
[ ] The PR template has been filled out
[ ] The PR has been self reviewed
[ ] The PR has a reviewer assigned
[ ] The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
[ ] The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Chicken and egg scenario. This is blocked until https://github.com/rancher/dashboard/pull/11531 merges. That PR is blocked on this one. This one doesn't touch code and is safe to force merge


Function calls and level dictionary

So I thought about introducing a  new dictionary in the Vensim parser when parsing general expression. The idea is to create a dictionary where the keys are the model functions and the values are sets of which functions are used by each function. Once we have that dictionary we can add information to each function about the level:

level 0: inputs + time
level 1: functions that depend on level 0 functions only
level2: functions that depend on level 1 functions
level 3:  functions that depend on level 2 functions
...

so for a code like this:
initial_data=
    10 ~~|

variable =
    SIN(Time) ~~|

stock =
    INTEG(variable, initial_data) ~~|

variable_2 =
    (variable + 1)/2

stock_2 =
    INTEG(variable_2, initial_data) ~~|

stock_3 =
    INTEG(stock, 0) ~~|

so we can have a dictionary like the following one:
{
'initial_data': (0, {}),
'variable': (1, {'time'}),
'stock': (2, {'initial_data', 'variable'}),
'variable_2': (2, {'variable'}),
'stock_2': (3, {'initial_data', 'variable_2'}),
'stock_3': (3, {'stock'}),
}

With this dictionary, we will be able to introduce several tools and improvements such as:

Use pycallgraph o similar libraries to create graphs of the models.
Detect circular dependencies in the model when translating the model file.
Initialize the stateful objects in the correct order: making initialization faster for large models and as we remove the try except we can remove as well the assert is not None in the step cache (making it a little bit faster)
we can include more information in the dictionary or use it to produce better cache strategy: if a function f depends only on run-cached functions and doesn't depend on time in any way (non-stateful, doesn't call Time...), the f  should be cache run.

The only problem I think we could have is with user interactions, especially for expert users that want to introduce new functions in the model as a small change may require big changes in the dependency dictionary (if we include the level). To make it possible we can create a dictionary only with the calls
{
'initial_data': {},
'variable': {'time'},
'stock': {'initial_data', 'variable'},
'variable_2': {'variable'},
'stock_2': {'initial_data', 'variable_2'},
'stock_3': {'stock'},
}

and then compute the level, just at the beginning of the initialization, so the user can update the dictionary easier.

In the case of stateful objects, we will need as well to split the call set in two (the values that are used to initialize the object and the values that are using during the integration)

This is an interesting idea, specifically for 3 and 4 above. The major issue I see is updating the dictionary when the model structure changes, especially if we relied on it too much. If it's useful, could it be generated when needed from the translated model? That way if the user made changes, we could regenerate the dictionary. (I thought pycallgraph could trace function dependencies from existing python functions already...)
If we can't make it robust to model changes, I'm skeptical, as it'd be too easy to get unintuitive behaviors, and would be hard to trace errors.


feat(seed): Change Project Euler assertion

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[ ] Small bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[ ] Addressed currently open issue (replace XXXXX with an issue no in next line)

Closes #XXXXX
Description

Changed Project Euler Problem 34 task a bit, I wonder if the task would be more challenging.
Here's the solution
function digitFactorials() {
	const factorial = n => {
		if (n == 0) return 1;
		var res = 1;
		for (let i = n; i > 1; i--) {
			res *= i;
		}
		return res;
	};

	const upperBound = factorial(9) * 7;
	var sum = 0;
	var numbers = [];

	for (let i = 10; i < upperBound; i++) {
		let s = 0;
		let number = i;
		while (number > 0) {
			let d = number % 10;
			number = Math.floor(number / 10);
			s += factorial(d);
		}

		if (s == i) {
			numbers.push(i);
			sum += i;
		}
	}
	return { sum, numbers };
}

@alvinkl Awesome! This is a big improvement. It works, but only when I apply the // noprotect. We will need to figure out a way to increase that time so fewer of these time out like that. Anyway, we'll tackle that later. Thanks for improving all of these Euler problems!


improve ediff readability

Change colours to improve readability. Only colours for the regions that are not active are changed. Pls see also issue:  94

to clarify, this addresses the issue of the poor readability of the light grey regions (not active) that can be seen in the first screenshot here ; these get nord colours (as in the second screenshot). it does not touch the active ediff region (red, green, yellow). Hope this makes it easier to understand.

to clarify, this addresses the issue of the poor readability of the light grey regions (not active) that can be seen in the first screenshot here ; these get nord colours (as in the second screenshot). it does not touch the active ediff region (red, green, yellow). Hope this makes it easier to understand.

Is there any hope for this to go in? Or has this project been abandoned? Thx!

Hi @ssnnoo :wave:, first of thanks for your contribution :+1:
Thanks for your patience, the large amount of tasks for the Nord project are really time consuming and my free time to work on all my OSS projects is limited. There are currently 60+ port project requests in the backlog and a massive amount of 350+ issues & PRs, not including support and help tasks per repository and requests from various communication channels like Twitter, the /r/nordtheme subreddit or just emails. The data transition of all port projects to the official website and documentations is still a focused job to finally reduce the maintenance overhead, create a „single source of truth“ and increase the overall project quality :octocat:
I'll review your PR as soon as there is time again to process the queue. Even though some changes might appear to the outside as if they are small, but as a maintainer it is always important to ensure that it matches the project goals and not only a single-user use case. It also requires some research about backwards compatibility because not every user uses the latest version of an application or package/plugin/addon.

Absolutely, it is just that the last commit in the nord-emacs was last year, while for other nord reps this is not true. Many thanks.


SPIFFS writing the same address without erase in between

Hi, while trying to integrate SPIFFS with https://github.com/Marzogh/SPIFlash I found that SPIFFS writes to the same address on the flash for a second time without erasing it first. This pisses off SPIFlash, because it checks before every write if that location has already been written to and allows the write only if it hasn't (it checks if the location contains 0xff or something else). This kind of behavior is reasonable for a flash memory, but is it compatible with SPIFFS? Or is SPIFFS smart enough to handle this (without an erase)? Or did I overlook something, and this double write shouldn't happen? A very simple test case of creating a new file and writing any data to it triggers this error. Here are my relevant settings:
#define SPIFFS_USE_MAGIC                (1)
#define SPIFFS_USE_MAGIC_LENGTH         (1)
#define SPIFFS_SINGLETON 1
#define SPIFFS_CFG_PHYS_SZ(ignore)        (1024*1024*16)
#define SPIFFS_CFG_PHYS_ERASE_SZ(ignore)  (65536)
#define SPIFFS_CFG_PHYS_ADDR(ignore)      (0)
#define SPIFFS_CFG_LOG_PAGE_SZ(ignore)    (256)
#define SPIFFS_CFG_LOG_BLOCK_SZ(ignore)   (65536)
typedef u16_t spiffs_block_ix;
typedef u16_t spiffs_page_ix;
typedef u32_t spiffs_obj_id;
typedef u16_t spiffs_span_ix;

I'm using the current master branch. Thanks!

Hi there,
this is as implemented - spiffs is designed this way to update flags, forcing certain bits to zero to reflect metadata changes, which in turn will save flash memory. The spiffs - spi flash HAL should merely do what specified - read, write, and erase.
Cheers / P

Alright, I think it's time to drop SPIFlash and use your spiflash_driver instead. Thanks!