ensure account also removed from memories on delete

Alternative way of doing https://github.com/k9mail/k-9/pull/600

:+1:
For future consideration: a condition like memoryEntry.getValue().account.getUuid().equals(account.getUuid()) is rather hard to read. You could either break it apart or assign it to a local variable with a descriptive name. In this case maybe something along the lines of isEntryForAccountToBeRemoved.

Sure, I wasn't really convinced by that anyway. Is the map keyed by UUID? First thing I tried was map.remove(account.getUuid()) but that didn't seem to work

static String getMemoryKey(Account taccount, String tfolderName) {
    return taccount.getDescription() + ":" + tfolderName;
}

:cry:


tabs inside pre

Hi,
I have some troubles with tab indent mith multiline code snippets.
I initially used css property white-space: normal; to remove blanks but this remove all tabs and line breaks.
In my html file, I need to indent my code to make it clean.
But with this css property removed all tabs are rendered inside the pre tag

how to resolve this ?
thanks

I think the tab-space CSS rule should help with that link
pre > [data-language] {
	tab-space: 2; /* Default tab-space value is 8 */
}


Desktop: Backport fixes needed for desktop application

Update zephyr with 2 fixes need by the desktop application.

Bluetooth: host: Fix ECC thread stack size too small
drivers: led_pwm: Handle power state changes

Will close this as an upmerge is started that will include these changes.


Passing EntityPlayer to all of the knowledge and warp functions is redundant

While making an addon, I discovered that you passed an EntityPlayer object to all of the functions regarding player knowledge/warp. This is unnecessary. If you just pass a string (player.getCommandSenderName()) and the world (player.getEntityWorld()), addons could pass in variables and modify player knowledge/warp without them having to be online.

If the system is eventually changed to a UUID system, all you would have to do is change the username String parameter to that of a uuid

I agree and I am planning changes for the 1.8 update.

\o/


Add repl command with test artifacts on path, corrensponding sbt command Test/console

Is your feature request related to a problem? Please describe.
My munit test has a bug.
Describe the solution you'd like
I want to debug my munit test in repl using scala-cli.
Describe alternatives you've considered
Use the sbt command Test/console
Additional context
Found nothing about this when reading scala-cli repl --help-full

if this is actually supported, I can't find it either in the doc or via experiment (e.g. scala-cli repl --test . is the syntax I would expect and doesn't work)
(and if it isn't supported, it seems like a pretty big hole to me)

seems like a pretty big hole to me

I agree. This seems like a feature that belongs to the "basic hygiene" category.

(and if it isn't supported, it seems like a pretty big hole to me)

It seems it isn't supported at the moment, so the feature request is valid.
Shouldn't be too hard to deliver (hopefully).

I agree that 2 is more natural. (But repl --test ., not repl . --test)

Hmm. You mean that the "test" string is passed as argument to the repl "app"?
I'd rather expect that there is an argument to scala-cli itself that adds extra stuff to the path, similar to --workspace or --js-linker-path that are args to the compile command. So if no path is given to --test then it takes src/test/scala as default.

Aha. I thought you meant repl -- test (with a space) but I see now that its just --test.
But we need the . or dir1/file.scala as arg to put the ordinary code on path so I think it should be scala-cli repl . --test [optional alt test path] as scala-cli repl without any path is not adding anything to the class path. Or maybe I'm missing something?

Aha I now see the actual dot at the end. (Sorry for my confusion.) That makes sense to me as well!

Anyway I guess it is not all that obvious in which order and how to add test artifacts in non-default dirs.

We already have compile --test, while we don't have test --compile 😅
repl --test is what I plan to go with, I just need to find time to implement it.

Great. But with the dot or not for "current dir"? And where to put the dot?

But with the dot or not for "current dir"?

. (the dot) is an input, which stands for the current working directory.
Launching repl --test without any inputs would mean you're launching the repl while including the test scope, but the test scope will be empty, since there are no inputs.
TL;DR yeah, the dot is necessary.

And where to put the dot?

As with any other case, . is treated as regular input, which can be passed anywhere after the subcommand name.
You can even pass inputs interchangeably with options, just take care not to pass it as an option argument by accident.
For example, the following is a valid command:
scala-cli repl -S 3.4.2 . --jvm 22

Makes sense! Thanks for clarification. Liberal rules, with some gotchas...

So if I write scala-cli repl someDir --test does that mean that tests have to be in someDir/src/test/scala or is scala-cli looking at any sub-dir called test for test code? Can I have my test code in a custom location?

So if I write scala-cli repl someDir --test does that mean that tests have to be in someDir/src/test/scala or is scala-cli looking at any sub-dir called test for test code? Can I have my test code in a custom location?

It needs to be identified as a test source, as per this doc:
https://scala-cli.virtuslab.org/docs/commands/test#test-sources


Breakdown helper.h > logger.h

Covered in https://github.com/HBRS-SDP/ss24-physiological-computing/tree/16-templating-new-cmake


ca-certificates required for mod_ldap + mod_authnz_ldap with ldaps://

With FROM httpd:2.4.53-bullseye
Using
LoadModule authnz_ldap_module modules/mod_authnz_ldap.so
LoadModule ldap_module modules/mod_ldap.so
<Directory "/web/">
AuthLDAPUrl "ldaps://ldapserver1 ldapserver2 ldapserver13/ou=People,dc=our,dc=organisation,dc=be?uid,cn,mail,gidNumber"
AuthType Basic
AuthBasicProvider ldap
Require ldap-group cn=group1,ou=People,dc=our,dc=organisation,dc=be

The only error message I can get in error_log (even with LogLevel debug) is
[Fri Apr 29 09:01:30.932273 2022] [authnz_ldap:info] [pid 38:tid<PHONE_NUMBER>97152] [client XXXXX:62127] AH01695: auth_ldap authenticate: user stephane authentication failed; URI /testURI/ [LDAP: ldap_simple_bind() failed][Can't contact LDAP server]
After doing
apt update && apt install ca-certificates
Everything is working correctly.
Don't know what would be better: image modification, specification in the documentation or better debug messages from mod_ldap.

I guess there are probably other features of httpd probably also can reach out to external services that might benefit from CA certificates, but I do wonder how common it is, especially with services that have a real valid certificate that ca-certificates would include?  I suppose the scaffolding around update-ca-certificates is useful regardless, though, and I think we only get that with ca-certificates installed so it probably makes sense to include in the image.


Feature Request: Add todoist setting to enable auto_parse_labels on upload

Like described in API https://developer.todoist.com/sync/v9#add-an-item it would be helpful to add custom labels on upload.

+1 to this. Keeping labels in parity would be awesome


Add a third (or any higher) level of submodule cloning

Needed for VTB testing
Cardinal is a submodule of VTB
OpenMC is a submodule of Cardinal
OpenMC has submodules
We need to be able to clone this far down

Seems this is already supported, just need to write the submodule in a nested syntax


feat (core): Event System with Cart events implementation

Event System that can be used to subscribe to events without any interaction dependency on the ngrx store and actions.
closes #5182

I did a quick review of this feature and have some remarks about the general event emitter and some cart specific points.
This event emitter uses a bit different pattern than other event emitters that I am familiar with (eg. node.js event emitter). Using observables is more pleasant in our case, but the API can be changed a bit.
I would rename get to on, but that's a detail. Bigger difference is the register method. We can only have one stream for each event type. That is forcing us to keep the whole logic for a specific event in one place (builder). I think that there could be events that will be called from different modules (eg. checkout can influence cart). Instead, I would emit function which would push new values into the event stream. You could then emit from everywhere.
Using ngrx actions to dispatch events is the easiest way for now to dispatch those events, but this approach also has some drawbacks I found during cart work. For example: adding first cart entry is combination of (attempt to load the current cart, then if not found creating a new cart and after that adding entry). In that case, the BUSY event will call 6 times, so you could see on loaders some flickering (which is not desired). Preventing such situations can't be done on the store level and the facade would be responsible for emitting events instead. However, that would require more work/code than just mapping actions. There can also be a case for events from services that don't use ngrx and for that, we need another mechanism to emit.

Thanks for your feedback!

I would rename get to on, but that's a detail.

Perfect, I actually had this earlier on, so I'm happy to switch as this better resonates with this API.

Bigger difference is the register method. We can only have one stream for each event type. That is forcing us to keep the whole logic for a specific event in one place (builder). I think that there could be events that will be called from different modules (eg. checkout can influence cart). Instead, I would emit function which would push new values into the event stream. You could then emit from everywhere.

I'll find you on slack to better understand your ideas here.

adding first cart entry is combination of (attempt to load the current cart, then if not found creating a new cart and after that adding entry).

FYI – This is likely going to change anyway, as our new cart service API will create and add in one go. Moreover, trying to convince the team that the initial create will also return the full payload so that we don't need a reload of cart data. That being said, it is like this for now. However:

In that case, the BUSY event will call 6 times, so you could see on loaders some flickering

In the busy event, I've used the distinctUntilChanged(), which seems to work fine. I'll double check if this will prevent the flickering you mentioned.

closed as we've changed the implementation heavily


Getting topic links & cleaning output file a little bit

Get all topic links beforehand, removing extra back, next, ask_a_question, report_an_issue elements.
added 1 function to grab all topics of current course.

@anilabhadatta pls, have a look at this link:-
https://www.educative.io/courses/launching-personal-website-r/m2jn9oYrP90
here, the answer is not expanded when using before and after my commits.
you have to add some more code for this.

@BoostUpStation
this part is now fixed, educative changed their dom. i will first review and merge your code and then I will push the bug fixes.
if you find any more bugs please let me know.

@BoostUpStation can you explain me how are you going to resume the scraper if there is an issue while scraping?
And which URL are you providing at the start for scraping?
Suppose the scraper stops in middle and I want to resume the scraper, which link and index should i provide in urls.txt from log.txt?

@BoostUpStation can you explain me how are you going to resume the scraper if there is an issue while scraping? And which URL are you providing at the start for scraping?
Suppose the scraper stops in middle and I want to resume the scraper, which link and index should i provide in urls.txt from log.txt?

Please wait for this, earlier you have implemented only logging of course link and index from file.
But now as i have added topic links, so need to implement logging of file_index, topic_index, link. So that it can be resumed from that particular topic of specific course, rather than downloading all previously downloaded pages.
Working on it.

@BoostUpStation i can give you an idea.
instead of changing anything in log.txt implementation, you can just tell the scraper to start scraping from the specified index from the list of available topic URLs.
[u1,u2,u3,u4] and suppose log.txt is showing 1 u2,  then driver.get(u2) will generate all the topic URLs from side bar and then update the iterator index, URL to file_index and topic_urls[file_index ] and then resume the scraping.
this will reduce the checking of the URL it is main URL or a topic url.
you may ask why keep the u2 in log.txt since the index can already resume the scraping, this is mainly done to do manual debugging If there is an serious issue with the scraping that is causing multiple crashes at the same topic url.

@BoostUpStation No need to make any required changes here.
I will do a git push probably today after few hours, then clone it in your system and implement the topic URL loading instead of next button.
There are a lot of bugs currently since educative changed their DOM massively. I am fixing them one by one, will give you an update here later.

@BoostUpStation one edge case, https://www.educative.io/page/5689413791121408/80001
here you can see there is no side nav bar so you wont be able to get any topic urls.

@BoostUpStation okay will let you know

@BoostUpStation I have pushed the latest commit, create a new pull request and you can implement the next topic function.
Uncomment line no 143 if your pagination implementation is successful as this will delete the ask a question div.
Implement the delete pagination node as well in remove_nav_tags function .

@BoostUpStation I have updated the repo again. No changes were made in scraper.py.
Have you implemented the topic URL list traversal method?

@anilabhadatta
Please fix this url : https://www.educative.io/courses/launching-personal-website-r/m2jn9oYrP90
Not clicking on show answer, the same problem as before.
I have to relook at the remove function.
And the thing is of only logging, rest topic url list traversal method is working fine.

@anilabhadatta
https://www.educative.io/courses/launching-personal-website-r/N7m5GjQKn0m
on this page, its stuck at 'slides opened' & no further improvement.
Check this too.

@BoostUpStation I tested it, it is working correctly here. try pulling to the latest commit because I fixed these issues
launching a personal website using r.zip
.

@anilabhadatta Please fix this url : https://www.educative.io/courses/launching-personal-website-r/m2jn9oYrP90 Not clicking on show answer, the same problem as before.
I have to relook at the remove function.
And the thing is of only logging, rest topic url list traversal method is working fine.

uncomment line 143 and add the footer removal only if your traversal method is working correctly along with log.txt
pagination deletion code:
pagination_selector = f"div[class*='styles__Pagination']"
delete_node(driver, pagination_selector)
I think the log.txt should typically work since it captures the current URL that is opened in the browser. and in url.txt you can just paste the index and URL from log.txt if there is any error.
Just you need to start the scraper from log.txt and that can be done easily since you are already providing the index, you can find the URL from your topic_url list if you search for the index.

@BoostUpStation I tested it, it is working correctly here. try pulling to the latest commit because I fixed these issues launching a personal website using r.zip .

So the problem here was, my browser zoom level was set to 110% due to which the script was not working correctly.
After setting it to 100%, not in the script, in the chrome driver, its working perfect.

@anilabhadatta Please fix this url : https://www.educative.io/courses/launching-personal-website-r/m2jn9oYrP90 Not clicking on show answer, the same problem as before.
I have to relook at the remove function.
And the thing is of only logging, rest topic url list traversal method is working fine.

uncomment line 143 and add the footer removal only if your traversal method is working correctly along with log.txt
pagination deletion code: pagination_selector = "div[class*='styles__Pagination']" delete_node(driver, pagination_selector)
I think the log.txt should typically work since it captures the current URL that is opened in the browser. and in url.txt you can just paste the index and URL from log.txt if there is any error. Just you need to start the scraper from log.txt and that can be done easily since you are already providing the index, you can find the URL from your topic_url list if you search for the index.
Can you tell me if you exit the scraper while scraping, does the log.txt capture the current URL and index?

Pls tell me how you are going to run the scraper from a specified index as of now? With only file index at present?

@anilabhadatta Please fix this url : https://www.educative.io/courses/launching-personal-website-r/m2jn9oYrP90 Not clicking on show answer, the same problem as before.
I have to relook at the remove function.
And the thing is of only logging, rest topic url list traversal method is working fine.

uncomment line 143 and add the footer removal only if your traversal method is working correctly along with log.txt
pagination deletion code: pagination_selector = "div[class*='styles__Pagination']" delete_node(driver, pagination_selector)
I think the log.txt should typically work since it captures the current URL that is opened in the browser. and in url.txt you can just paste the index and URL from log.txt if there is any error. Just you need to start the scraper from log.txt and that can be done easily since you are already providing the index, you can find the URL from your topic_url list if you search for the index.
Can you tell me if you exit the scraper while scraping, does the log.txt capture the current URL and index?

Pls tell me how you are going to run the scraper from a specified index as of now? With only file index at present?

in line 923 you can add the topic_url_list generate part.

in line 934 935, you can just call the scraper function and remove the next page function from scraper function.
and after increasing the counter at 937, you can do a driver.get(topic_url[file_index])

@anilabhadatta
Right now what i have done is :
file_index, topic_index, current_url in the log file.
Then if exited, add the last log line into the url_text_file
And the scraper will do its job perfectly fine, and taking into consideration that the already scraped courses and/or topics won't be scraped again,
Like if it was at 5th course and 7th topic, then the scraper will proceed from 5th course 7th topic, then it will goto 6th course automatically.
I have made some changes.
Will test it tonight, and then in the day gonna create pull request.

@BoostUpStation
file_index == topic_index

@BoostUpStation can you create a new pull request?
here I am seeing a lot of line changes

@anilabhadatta
https://www.educative.io/courses/decode-coding-interview-js/B6Gz0WjWypY
this page has a table with scroller, and is cutting some content from the scroller.
Pls fix this, and I am testing the scraper with logs and topic url list, will do for a few days and seeing if probs occur or not.

@BoostUpStation i would be very complicated actually.
how many of these scrollable elements are present?
better I  would say , try using single file, it can save the scroller but doesn't save svg images. need some work in it.


Workspace package works during build, but not development

I'm using yarn workspaces which links workspace packages under node_modules without running babel on the package. For this reason I'd like to ensure that my razzle setup runs babel on these packages.
Most likely my problem can be simplified to "run babel also for imports under node_modules/@myorg", potentially with the complication that these packages are symlinks.
I've tried changing my configuration by adding a razzle.config.js webpack override, which runs during packaging
const path = require('path');

module.exports = {
  modify: (config, { target, dev }, webpack) => {
    // rules[2] is the babel loader.
    config.module.rules[2].include.push(
      path.join(__dirname, './node_modules/@myorg')
    );
    return config;
  },
}

Everything seems to be going fine when I run the build script. My code comes out transpiled correctly. However, when I'm running the start scripts, I keep getting an error preventing the server from starting.

Any advice?

I'm using yarn workspaces which links workspace packages under node_modules without running babel on the package. For this reason I'd like to ensure that my razzle setup runs babel on these packages.
Most likely my problem can be simplified to "run babel also for imports under node_modules/@myorg", potentially with the complication that these packages are symlinks.
I've tried changing my configuration by adding a razzle.config.js webpack override, which runs during packaging
const path = require('path');

module.exports = {
  modify: (config, { target, dev }, webpack) => {
    // rules[2] is the babel loader.
    config.module.rules[2].include.push(
      path.join(__dirname, './node_modules/@myorg')
    );
    return config;
  },
}

Everything seems to be going fine when I run the build script. My code comes out transpiled correctly. However, when I'm running the start scripts, I keep getting an error preventing the server from starting.

Any advice?

You Forgot to add whitelist in node-externals.

Thanks for the advice. A variation of this worked to resolve this.

A variation of this worked to resolve this.

@philipnilsson can you share? Thank you.


404 for link from Bing Image Search

This link doesn't work:
https://docs.microsoft.com/en-us/python/api/azure-cognitiveservices-search-imagesearch/[https://docs.microsoft.com/en-us/rest/api/cognitiveservices/bing-images-api-v7-reference?view=azure-python#market-codes](https://docs.microsoft.com/en-us/rest/api/cognitiveservices/bing-images-api-v7-reference#market-codes)
It's from the Market Codes link, as described in the search() API call. Located under an optional parameter called market:
https://docs.microsoft.com/en-us/python/api/azure-cognitiveservices-search-imagesearch/azure.cognitiveservices.search.imagesearch.operations.imagesoperations?view=azure-python#search-query--accept-language-none--user-agent-none--client-id-none--client-ip-none--location-none--aspect-none--color-none--country-code-none--count-none--freshness-none--height-none--id-none--image-content-none--image-type-none--license-none--market-none--max-file-size-none--max-height-none--max-width-none--min-file-size-none--min-height-none--min-width-none--offset-none--safe-search-none--size-none--set-lang-none--width-none--custom-headers-none--raw-false----operation-config-
Here is the correct link:
https://docs.microsoft.com/en-us/rest/api/cognitiveservices-bingsearch/bing-images-api-v7-reference#market-codes

Den @docs-product thee Python code contains correct MD link, but I guess the system is processing them as RST and creates the trouble? Thoughts?

This was unfortunately not addressed in time before the links went to 404 :(. Closing the issue.


Predictive_Maintenance code example from documentation is not wroking

Code from this example: https://nixtla.github.io/neuralforecast/examples/predictive_maintenance.html
is having the following line:
!pip install git+https://github.com/Nixtla/datasetsforecast.git@predictive_maintenance
However this gives:
Collecting git+https://github.com/Nixtla/datasetsforecast.git@predictive_maintenance
  Cloning https://github.com/Nixtla/datasetsforecast.git (to revision predictive_maintenance) to /tmp/pip-req-build-lfg92i92
  Running command git clone --filter=blob:none --quiet https://github.com/Nixtla/datasetsforecast.git /tmp/pip-req-build-lfg92i92
  WARNING: Did not find branch or tag 'predictive_maintenance', assuming revision or ref.
  Running command git checkout -q predictive_maintenance
  error: pathspec 'predictive_maintenance' did not match any file(s) known to git
  error: subprocess-exited-with-error

  × git checkout -q predictive_maintenance did not run successfully.
  │ exit code: 1
  ╰─> See above for output.

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

× git checkout -q predictive_maintenance did not run successfully.
│ exit code: 1
╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

Hey @SlimakSlimak, thanks for raising this. Indeed that is outdated, the features from that branch were added to main in https://github.com/Nixtla/datasetsforecast/pull/21, so you can remove the branch name from the install command, i.e. !pip install git+https://github.com/Nixtla/datasetsforecast.git.
Please let us know if you run into any more issues.


System Error: Unable to create 'out.cur_input'

Hello ivanfratric
I installed WinAFL and it mostly seems to be running well. However after the WinAFL runs for some time, I get the following System Error message.

I am running the WinAFL tool as an Administrator, so I do not know why the OS denies permission.
Any thoughts?

It seems that WinAFL was unable to write a new sample file over existing one. When that happens, WinAFL first attempts to kill the target process and then attempts to overwrite the file again. So the error you see can be one of two things:

Either WinAFL was unable to kill the target process or
The input file was open in such a way that even killing the target process didn't help to release it.
I'm curious to see which one it was. When that happens, can you check if you can delete the .cur_input file and check in the task manager if the target process is still running and try to kill it from there?

The only workaround for now is to restart WinAFL and resume the fuzzing session. You can resume the session by using '-i -' instead of your input directory (same as Linux AFL).
In the future versions, it might be possible to resolve issues like this by falling to another input file if deleting the current one fails repeatedly (e.g. .cur_input1, .cur_input2 etc.)

So I ran WinAFL again to follow your suggestions and here are my observations.
When the tools reaches a hang, the following pops up:

Selecting cancel results in the system error message I talked about in the beginning of the issue.
However, if I don't select cancel. The tool does keep on running, and the '.cur_input' file keeps on getting updated. As such, if I try to delete the '.cur_input' file, a window pops up explaining that the deletion cannot be carried through because the file is open in another program.
Ending the task in "Task Manager" kills the target process and gets rid of the messages (shown above), and WinAFL still runs. Which is great.
Thanks ivanfratric. I believe the issue has been resolved.


Add custom font colors

Add a drop down box (<select>) for choosing the colors for the meme.

We will use a custom library for choosing colors. Maybe http://jscolor.com

Done!


WIP: feat: Adding go-tor-transport to projects.

Result :

I've choosen theses cyans for Anonymity because it's an in beetween the color of Open Source and the classic blue.
(The idea would be to add the same badge on I2P if it gets done). I think it could be also switched to yellow or red if the goal is to keep the current palette (not blue it would be too much blue in one card).
The weight I've just tried all positions in the 2nd and 3th lines and this is best one (it's makes a corner of Go-*-* in top right corner.).

Don't merge now I want to keep it to test the auto build script.


fix minor typos in hcxdumptool help

Fixed some minor typos in hcxdumptool --help.

Thanks. Merged.


chore: add issue templates

Codecov Report

Merging #57 (4be023e) into main (1beafd6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #57   +/-   ##
=======================================
  Coverage   86.60%   86.60%
=======================================
  Files           8        8
  Lines         575      575
  Branches      143      143
=======================================
  Hits          498      498
  Misses         75       75
  Partials        2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add a cpu throttling demo and make minor fixes to pending pods yaml for clarity

@arikalon1 tiny PR. Please review.

Please ask roi
On Tue, 23 Aug 2022, 14:03 Natan Yellin, @.***> wrote:

@arikalon1 https://github.com/arikalon1 tiny PR. Please review.
You can view, comment on, or merge this pull request online at:
https://github.com/robusta-dev/robusta/pull/490
Commit Summary

4dc4d1d
https://github.com/robusta-dev/robusta/pull/490/commits/4dc4d1daa47c796f898636ae71084c5cf8150602
Add a cpu throttling demo and make minor fixes to pending pods yaml for
clarity

File Changes
(2 files https://github.com/robusta-dev/robusta/pull/490/files)

A demo/cpu_throttling/throttling.yaml
https://github.com/robusta-dev/robusta/pull/490/files#diff-980b1668389c0c60226e5e749351d69eb05b6afa8133ec51fb8f5e2882abba53
(20)
M demo/pending_pods/pending_pod.yaml
https://github.com/robusta-dev/robusta/pull/490/files#diff-1e37dc23eb6ac0019df5cb6efa1f3d0e027a1d9bf3949066b9fa90ad9046a164
(6)

Patch Links:

https://github.com/robusta-dev/robusta/pull/490.patch
https://github.com/robusta-dev/robusta/pull/490.diff

—
Reply to this email directly, view it on GitHub
https://github.com/robusta-dev/robusta/pull/490, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEWC5X6W4VZ7J7PLIXPVAFTV2SVWVANCNFSM57LAN4SQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sure, @RoiGlinik can you handle?


Fixes #461

Fixes #461

Deployed to: http://staging.quran.com:32849

when you merge this, can you please change the title to be something descriptive? use fixes as the description so it doesn't take 2 clicks to know what you changed.


Improve write/read APIs to use enums instead of booleans

Improve write/read APIs to use enums instead of booleans for sync/async behaviour.

Merged on trunk.


Documentation: Fix code block in implementation/simulation.rst

Summary
Some codeblock in implementation/simulation.rst had code that wasn't correctly align, which result in the code not being in the code block.
Impact
Update Documentation only
Testing
local doc build

[Experimental Bot, please feedback here]
Yes, this PR meets the NuttX requirements.
The summary clearly explains the issue and the fix. The impact section correctly identifies the limited scope of the change. While basic, the testing section confirms the author validated their fix.


Ideas for shorter urls

We could potentially have somewhat shorter urls:

make shorter random doc names
use ed25519 or similar public/secret keys which are much shorter than RSA keys

It's already using ed25519 keys, not RSA keys, so I struck that out.


Add GRANT and REVOKE sql statements

Add authorization support on the SQL front-end.

I am looking at implementing this feature.


Backtesting

Support for things like:

downloading and storing historical data (and updating it with live data real-time),
switching to historical data as the event source.

Though order book data is not usually available, many strategies can work without it. Also, it could be recorded and maybe even shared.

+1

I'm new to this, but I wonder if we couldn't populate a backlog of ticks with https://docs.gdax.com/#get-historic-rates and then create a mock then runs them through gtt as events?


Unnecessary newline after long generics in function

-    pub fn build_texture_atlas<'a, T: IntoIterator<Item = &'a WadName>>(
-            &'a self, names_iter: T) -> (TransparentImage, BoundsLookup) {
-        let entries = ordered_atlas_entries(&self.animated_walls,
-                                            |n| self.texture(&n),
-                                            names_iter);
+    pub fn build_texture_atlas<'a, T: IntoIterator<Item = &'a WadName>>
+                                                                        (&'a self,
+                                                                         names_iter: T)
+                                                                         -> (TransparentImage, BoundsLookup) {

Would be nice to automatically insert a where clause here.

Fixed by #666


Adding additive attention mask support to Triton FlashAttention

Hey, I was working on adding optional additive attention masking support to Triton's FlashAttention kernel on Triton main to support the latest version and its features. For example, the Triton version now supports both causal and full attention, uses the new block pointer API in the forward pass, is faster than before, and adds sequence parallelism to the backward pass (taken from here).
Triton upstream really changed a lot, which the implementation in here does not reflect yet. So I'm proposing to either merge the two implementations or copy-paste upstream in here, depending on how much work should be invested. A short pro/con list of the approaches is at the end.
As a warning, I haven't compared the two versions in detail since you probably did some heavy performance optimizations for the Triton FlashAttention version in here, including adding several new features yourself.
New Triton implementation
I'd like to highlight the addition of the MODE flag to Triton upstream, which is used to switch between full/causal attention (with two implementations for the causal calculation for efficiency depending on the sequence length). My masking implementation transparently handles this MODE flag as well, meaning two things:

If causal attention is selected, adding a mask on top will never make it non-causal.
Similar to q/k/v, we only load mask blocks where necessary (i.e., we ignore the upper triangle for causal attention).

I was also very happy about a broadcasting feature (which – unlike you – still missed support for broadcasting of causal ALiBi masks, where a tensor of shape [nhead, 1, seq_len] is given), but I just realized that torch.Tensor.expand doesn't copy the expanded dimensions, so my implementation can be greatly simplified similar to how you do it while gaining causal ALiBi support for free (I think? There's some extra handling in here for it.).
Finally, just like here, usage of a mask is completely optional, so code will run as fast as before when a mask is not given while still supporting causality. The difference between the bias implementation and mask implementation is that masking has to handle -∞ (which also means placing the IS_CAUSAL query after the addition to handle the tranparent mode handling I mentioned above).
Way forward
What do you think of updating the Triton FlashAttention kernel here to make use of the newest Triton upstream features (block pointers really add to readability) and to integrate attention mask support (which implies attention bias support). I'm not sure what the best proposal here is, but I see two main options:

Mostly copy-paste the Triton PR version. This would lose:

cross-attention
arbitrary seq lens
speedups from your side
support for old Triton versions

It would win:

not much work to do
remove the current hacky workarounds (e.g. TMP buffer)
usage of new Triton APIs → speed, maintainability, readability
optimizations from the Triton side
support for current Triton version

Integrate new upstream features piece-wise. This would lose:

a lot of work to do

It would win:

anything from upstream that you decide to integrate (IMO most important: handling of -∞ in attention bias, support for current Triton, new API usage, and speedups from the Triton side)
still able to remove old baggage
ability to retain Triton backward-compatibility
careful considerations for each new integration → not much work if only considering few, small integrations

Wonderful work on the Triton implementation, and very thoughtful suggestions here. Thanks @janEbert!
Yes, I'd love to stay up to date with upstream Triton, I just haven't had time to update the Triton implementation in this repo.
Ideally some of the features implemented here should be upstreamed (option 2), but I'm not sure I'll have the bandwidth to do that. Fortunately some of the features here have gradually been implemented in upstream Triton (causal & non-causal attention, parallelize the backward pass across seqlen_k, and hopefully attention bias soon with your PR). I hope folks will contribute by sending PRs to upstream Triton.

I can take care of some of the integrations from upstream to here if you're fine with losing backward-compatibility. The attention mask/bias will probably not be integrated upstream due to the added complexity.

Alas, yours will have to be the featureful Triton FlashAttention kernel we need. ;)

I can take care of some of the integrations from upstream to here if you're fine with losing backward-compatibility. The attention mask/bias will probably not be integrated upstream due to the added complexity.

That would be wonderful. Backward-compatibility with old Triton version isn't a concern for me.

Sorry, I've just edited the post above: My only worry is having to figure out the workarounds that had to be implemented here. Were they necessary to support the arbitrary sequence lengths or were they used to fight around compiler bugs which may have been fixed upstream?
Other than that thanks for the okay!

Sorry, I've just edited the post above: My only worry is having to figure out the workarounds that had to be implemented here. Were they necessary to support the arbitrary sequence lengths or were they used to fight around compiler bugs which may have been fixed upstream?

I had to add a bunch of tl.debug_barrier() to deal with compiler bugs, which might have been fixed upstream (I haven't checked). To support arbitrary seqlen ideally one just needs to set a mask when calling tl.load.

Hi @tridao, I am noticing that even the triton fwd call is slower than the flash-cuda implementation when the head dimension is 128. I am using https://github.com/triton-lang/triton/blob/main/python/tutorials/06-fused-attention.py for profiling. I am return the time instead of flops. These are the results I get for head dimension 128 -
fused-attention-batch4-head32-d128-fwd-causal=True: (Time in ms)
     N_CTX  Triton [FP16]  Triton [FP8]    Flash-2
0   1024.0       0.285561      0.447643   0.241351
1   2048.0       0.894371      1.475016   0.778228
2   4096.0       3.183826      5.124862   2.779694
3   8192.0      12.040288     19.008390  10.662884
4  16384.0      46.750145     73.111710  41.799503

This issue is not present when the head dimension is 64. These are the results for head dimension 64 -
fused-attention-batch4-head32-d64-fwd-causal=True: (Time in ms)
     N_CTX  Triton [FP16]  Triton [FP8]    Flash-2
0   1024.0       0.148868      0.186288   0.146833
1   2048.0       0.450962      0.601676   0.457882
2   4096.0       1.598519      2.149870   1.628497
3   8192.0       6.023782      8.119765   6.196142
4  16384.0      23.513256     31.372011  24.149960

Since the triton fwd call is said to be faster than the flash-cuda implementation wanted to know if that is only for a head dimension of 64 or if I am missing some optimal setting of the hyperparameters (BLOCK_M, BLOCK_N, warps, stages).


feat: module starter

Description
Added Vaadin module type with starter download
Project Settings

Hello World Projects

Opened project
After creating project is opened on README.md (in preview mode, might be marked as using "experimental API").

Currently I don't know how to automatically load Maven / Gradle projects, will be improved in future.

Merging as PR is too big already, work will be continued in separate, smaller PRs.


IMPROVE: WordPress TitleCase Grammar

💯  WordPress TitleCase Grammar. Thanks for the FOSS work.

@ahmadawais Haha, good catch. Thanks a ton for doing this!


zoxide doesn't work

Describe the bug
zoxide enable you to change path easily, I configure it for zsh and works.
when I run z  don't change path. The command seems run successfully (no explicit errors), but the pwd folder is the same.
To Reproduce
Steps to reproduce the behavior:

z  after configuring zoxide

Expected behavior
A change of directory
Desktop (please complete the following information):

OS: MacOS M1 chip
Version 0.7.5 20240502-224736

Additional context
Add any other context about the problem here.

Same issue on Ubuntu, unable to change directory via z command
#62~20.04.1-Ubuntu SMP Tue Nov 22 21:24:20 UTC 2022
zoxide v0.9.1

Seems related to https://github.com/wavetermdev/waveterm/issues/695


Version 1.1 not compatible with SPVNAS Semantic Segmentation

It looks like version 1.1 is not compatible with SPVNAS (Version 1.0 worked). Starting at line "model = model.determinize()" in model_zoo.py I get the following error:
RuntimeError: running_mean should contain 1000 elements not 44
You can use the following Python code to reproduce the error:
# Go into the folder SPVNAS (git clone https://github.com/mit-han-lab/e3d)
from model_zoo import spvnas_specialized

net_id = "SemanticKITTI_val_SPVNAS@65GMACs"

model = spvnas_specialized(net_id, True)

I created a PR that should fix this issue and support the latest TorchSparse.

Thanks for the update @zhijian-liu it works now!
Tested with torch==1.7.1 torchvision==0.8.2


Rethink Extern

Problem
In order to pass in all the external deps, we currently use:
pub struct Extern<S: Storage, A: Api, Q: Querier> {
    pub storage: S,
    pub api: A,
    pub querier: Q,
}

and pass in either &mut Extern (handle, init, migrate) or &Extern (query).
This is great for tests and for linking to relatively stateless handlers. Now, I am working to build a integration test framework for contracts to redeploy messages and router querier to the real contracts and their state - held by the same object that is running the query itself.
The current definition means I need to pass in self, when all that is really needed is &self. I start defining impl Querier for &Router (rather than Router) and got into all kinds of lifetime issues. I also could not accept &Q, as I need Q for building Extern.
Proposal
What we really need inside the contracts is:
pub struct ExternMut<S: Storage, A: Api, Q: Querier> {
    pub storage: &mut S,
    pub api: &A,
    pub querier: &Q,
}

pub struct ExternRef<S: Storage, A: Api, Q: Querier> {
    pub storage: &S,
    pub api: &A,
    pub querier: &Q,
}

and can use handle(deps: ExternMut<S, A, Q>, ..) and query(deps: ExternRef<S, A, Q>, ...)
Impact
We could easily implement Extern::as_ref() and Extern::as_mut() to produce these from one owned Extern. This would be used almost identically inside the contract code (probably less typing - deps.storage rather than &mut deps.storage), but would make a bit more typing in the test code (mock_dependencies must return Extern for ownership, then all calls would be like: handle(deps.as_mut(), ...)
I do believe this would not change the wasm<->Rust API, just the unit tests, so pre-compiled 0.11 wasm binaries would be drop-in compatible with a new network with this change. You could just update the code in the next version of each contract, without requiring an upgrade of every contract to use the new network.

Please see https://github.com/CosmWasm/cosmwasm-plus/pull/130 for Context. In particular, the Router implementation from line 285 on. (also revert one commit to see me attempt everything with references and the lifetime tunnel).
ContractWrapper and WasmRouter should be more or less complete (untested but functionally possible)

This is what a unit test would look like if we gave of the grouping:
diff --git a/contracts/hackatom/src/contract.rs b/contracts/hackatom/src/contract.rs
index b0edd0ad..3b68290d 100644
--- a/contracts/hackatom/src/contract.rs
+++ b/contracts/hackatom/src/contract.rs
@@ -468,7 +468,7 @@ mod tests {

     #[test]
     fn handle_release_works() {
-        let mut deps = mock_dependencies(&[]);
+        let (mut storage, api, querier) = mock_dependencies(&[]);

         // initialize the store
         let creator = HumanAddr::from("creator");
@@ -481,15 +481,31 @@ mod tests {
         };
         let init_amount = coins(1000, "earth");
         let init_info = mock_info(creator.as_str(), &init_amount);
-        let init_res = init(&mut deps, mock_env(), init_info, init_msg).unwrap();
+        let init_res = init(
+            &mut storage,
+            &api,
+            &querier,
+            mock_env(),
+            init_info,
+            init_msg,
+        )
+        .unwrap();
         assert_eq!(init_res.messages.len(), 0);

         // balance changed in init
-        deps.querier.update_balance(MOCK_CONTRACT_ADDR, init_amount);
+        querier.update_balance(MOCK_CONTRACT_ADDR, init_amount);

         // beneficiary can release it
         let handle_info = mock_info(verifier.as_str(), &[]);
-        let handle_res = handle(&mut deps, mock_env(), handle_info, HandleMsg::Release {}).unwrap();
+        let handle_res = handle(
+            &mut storage,
+            &api,
+            &querier,
+            mock_env(),
+            handle_info,
+            HandleMsg::Release {},
+        )
+        .unwrap();
         assert_eq!(handle_res.messages.len(), 1);
         let msg = handle_res.messages.get(0).expect("no message");
         assert_eq!(

A bit more ugly. This is the proper types we wish for however, not claiming ownership.

Please look at this for a much cleaner version using the ExternRef and ExternMut types I proposed above: https://github.com/CosmWasm/cosmwasm/pull/586/files
It has the exact same ownership rules as the code you wrote, but is simpler to use.

Okay, so those two are basically the same thing. I don't like adding even more symbols, but if this is the price we have to pay, then fine.
But I wonder how this solves even the most basic problem that given an &mut S and a &Q, the querier cannot access the storage because you cannot have a mutable and an immutable reference at the same time.

I solved that with RefCell.
You cannot have a mutable and immutable reference to the same storage at the same time. But if each contract has their own storage, you can have a mutable reference to your storage and imutible reference to all other storage at the same time using RefCell, which allows you to get with &HashMap and each item enforces exclusive &mut or multiple & at runtime. See cell for more info

Alright, then. Seeing a bit clearer with #589. I'm still not happy we need 3 Deps types but also don't see an alternative to it.

I mocked out some ExternMut and ExternRef types in https://github.com/CosmWasm/cosmwasm-plus/pull/130 to see if it would compile without errors and Rust approved of all functionality. And it looks good so far.
This code is not tested, but the lifetimes and reference counting makes the compiler happy, which is a good start for the API design.


[llvm] Add a PlanConvLoopOrder pass

This pass converts linalg.conv into linalg.generic and permutes
its iterator order to be more CPU friendly.

Note that this will fail the bots at the moment. It needs https://reviews.llvm.org/D91357 and https://reviews.llvm.org/D91796.


打包时间过长，是项目框架太重了么，如何优化？

Version
Vben Admin V2
Description
打包时间过长，是项目框架太重了么，如何优化？
Proposed Solution
打包时间过长，是项目框架太重了么，如何优化？
Alternatives Considered
No response
Additional Context
No response
Validations

[X] Read the docs
[X] Ensure the code is up to date. (Some issues have been fixed in the latest version)
[X] I have searched the existing issues and checked that my issue does not duplicate any existing issues.

第一次打包会比较慢，很多子包都需要依次打包。
下一次打包就会比较快了，有缓存的


Can the model's automatic translation to the specified language be disabled?

from RealtimeSTT import AudioToTextRecorder
import pyperclip
def process_text(text):
pyperclip.copy(text)
if name == 'main':
print("Wait until it says 'speak now'")
recorder = AudioToTextRecorder(
model="large-v2",
language="ja",
spinner=False,
silero_deactivity_detection=True,
early_transcription_on_silence = 100,
post_speech_silence_duration=0.2,
)
while True:
    recorder.text(process_text)

The above is the content of my script. When I use it, regardless of whether I use the large or medium model, after setting the language to Japanese, when it hears other languages, it automatically translates them into Japanese instead of directly recognizing them as Japanese. If I click the speaker icon in the bottom right corner of the Windows desktop to adjust the volume, and it makes a sound in a quiet environment, it will output: ご視聴ありがとうございました. (Thank you for watching.)

Can't be disable, this is inherent to the OpenAI Whisper model we use for transcription. Only way is to leave language blank, then Whisper would autodetect the language.

If I click the speaker icon in the bottom right corner of the Windows desktop to adjust the volume, and it makes a sound in a quiet environment, it will output: ご視聴ありがとうございました. (Thank you for watching.)

That's probably a hallucination of the whisper model.

When I use it, regardless of whether I use the large or medium model, after setting the language to Japanese, when it hears other languages, it automatically translates them into Japanese instead of directly recognizing them as Japanese.

Do you mean that it auto-translates other languages in Japanese? What do you mean by 'recognizing them as Japanese' - if they're different languages how can they be recognized as Japanese?

If I set the language to Japanese, then if I speak Chinese, it will recognize my Chinese and then translate the meaning of the Chinese into Japanese.
When I previously said "recognizing them as Japanese" what I meant was that I hope it functions as if it is a standalone Japanese model.Regardless of what it hears, it should interpret the sounds as if they are Japanese pronunciations and recognize them as such.
However, as previously mentioned, it cannot work this way; this is inherent to the model.

"Thank you for watching." is a common Whisper hallucination when trying to transcribe "silent audio" without speech. This will occur with RealtimeSTT if the voice activity detection falsely recognizes noises as speech.
To mitigate this try setting webrtc_sensitivity to 3 and silero_sensitivity to lower values like 0.1 or even lower. This will make the VAD models more aggressive about filtering out non-speech, raising tolerance towards noises.

If I set the language to Japanese, then if I speak Chinese, it will recognize my Chinese and then translate the meaning of the Chinese into Japanese. When I previously said "recognizing them as Japanese" what I meant was that I hope it functions as if it is a standalone Japanese model.Regardless of what it hears, it should interpret the sounds as if they are Japanese pronunciations and recognize them as such. However, as previously mentioned, it cannot work this way; this is inherent to the model.

From my experience, setting the language of the model to Greek doesn't mean it auto-translates non-Greek speech to Greek. I can throw a mix of some English in there and it transcribes it correctly. Also bear in mind that Greek and English use a different alphabet [(α,β,γ,δ,...) vs (a,b,c,d,...)] and it doesn't have a problem with that either - meaning it uses the correct alphabet for the detected language.
I have encountered auto-translation only in the case of non-English speech being auto-translated into English - even if I've set the language to Greek. But only in the 'distil' models (like Systran/faster-distil-whisper-large-v3).
However I don't think it's possible to force the model to parse all sounds as pronunciations in a specific language, regardless of what the language parameter is set to - as evidenced by the Greek example I gave.

If I set the language to Japanese, then if I speak Chinese, it will recognize my Chinese and then translate the meaning of the Chinese into Japanese. When I previously said "recognizing them as Japanese" what I meant was that I hope it functions as if it is a standalone Japanese model.Regardless of what it hears, it should interpret the sounds as if they are Japanese pronunciations and recognize them as such. However, as previously mentioned, it cannot work this way; this is inherent to the model.

From my experience, setting the language of the model to Greek doesn't mean it auto-translates non-Greek speech to Greek. I can throw a mix of some English in there and it transcribes it correctly. Also bear in mind that Greek and English use a different alphabet [(α,β,γ,δ,...) vs (a,b,c,d,...)] and it doesn't have a problem with that either - meaning it uses the correct alphabet for the detected language.
I have encountered auto-translation only in the case of non-English speech being auto-translated into English - even if I've set the language to Greek. But only in the 'distil' models (like Systran/faster-distil-whisper-large-v3).
However I don't think it's possible to force the model to parse all sounds as pronunciations in a specific language, regardless of what the language parameter is set to - as evidenced by the Greek example I gave.

Automatic translation occurs between two non-English languages.

Automatic translation occurs between two non-English languages.

All right, I'll give my setup a test in this configuration: set the language parameter to Japanese, and feed it a mix of Japanese and Chinese (Mandarin) audio.


Update readme.md with installation and usage instructions

: it should be a idiot-proof copy paste. "Instructions for Windows", "Instructions for OSX", etc. As little text as possibe with as much brainless copy and paste.
The current one: https://github.com/HighDimensionalEconLab/VarianceComponentsHDFE.jl#using-the-executable should be redone compoletely since it is not copy/paste and there shouldn't be any "thinking" involved in following the instructions. The instructions to follow should also use the test.csv built into the binary in #84 so it really is a copy/paste to do that exact setup.
Finallly, what is written in the description of https://github.com/HighDimensionalEconLab/VarianceComponentsHDFE.jl#using-the-executable should be moved into a subsection later on which describes the executable arguments. Or you could see if the current vchdfe --help output is solid enough? If so, then maybe copy/paste that whole output into the readme to show people how to get help, and let them read what it says.
@paulcorcuera You can put on your "applied micro" hat when going through this to make sure it wouldn't seem scary to someone in that field.

What I envision for the "Manual Setup" is that we would give a sequence of powershell or bash commands.  The only thinking that the user should have is that they would choose where they want to install it.
So for windows, for example, I would have it as something like:
Windows Manual Installation

Choose where you want to install the package, open up a powershell terminal, and go to that location;
Install the latest version by executing

wget -qO- https://github.com/HighDimensionalEconLab/VarianceComponentsHDFE.jl/releases/download/v0.2/vchdfe-windows-latest.tar.gz | tar -xzv

Optional: Add the bin within this your system path  (@Alim-faraji  see more below)

setx PATH %PATH%;C:\bin\vchdfe\bin

Test using the example testfile

vchdfe --data=bin/test.csv

================
NOTE:  I would much rather this be automatic so they don't need manually change this.  Mabye there is a way to do it like
set NEWPATH = %PATH%;%HOWEVERYOUGETCURRENTDIRECTORY%\vchdfe\bin
setx PATH %NEWPATH%

Or probably something with the powershell Get-Location would be easier to copy/paste.
For ubuntu users, they will be more tech'd up, so you can tell them to modify their bash file.  Choose a reasonable default location such as just in the users diretory ~ so they can copy/paste.  See https://github.com/QuantEcon/lecture-source-jl#prerequisities for some text to copy/paste on how to edit the .bashrc that you could add.

Reminder for myself: make sure the changes to PATH are permanent.

Fix pipes in Windows instructions.


x-remap ignoring age in gold file

we can ignore an 'Age: 1' header.
This is causing random Autest failures. I assume when the CI is overloaded.

@ywkaras does this look ok to you?

Yup.

[approve ci autest]

[approve ci autest]

[approve ci autest]

Cherry-picked to v9.0.x branch.


Empty state

Crashes unwrapping an optional when searching for the max height and the element array is empty
 for index in rows.indices {
            let maxHeightIndex = rows[index].elements
                .max { $0.size.height < $1.size.height }!
                .index

Thank you for the crash report! Could you provide a sample view code that triggers this problem? By having a minimal and complete example, it will be easier to identify the root cause and verify the fix once I have one.

I've discovered this example that indeed crashes when force unwrapping the optional:
import SwiftUI
import WrappingHStack

struct ContentView: View {
    var body: some View {
        WrappingHStack {}
    }
}

I've applied a fix in version 0.1.3
Can you please validate that it solves your case as well?

I'll close the issue for now. Feel free to re-open if 0.1.3 didn't fix it for your case!


Project list

Adds the ability to "publish" project levels to a project gallery page, for other students in your classroom to see.

Coverage increased (+0.07%) to 56.992% when pulling 17debed1092a15e6dca5b849a9ebaefdde5adf9d on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage decreased (-32.6%) to 24.361% when pulling 545818b079546246de6c844b9054b1f062c96947 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.09%) to 57.005% when pulling 010863322e30cd4a839df7e2734e84df480747b8 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling 010863322e30cd4a839df7e2734e84df480747b8 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling 010863322e30cd4a839df7e2734e84df480747b8 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling 5ab64b439b8e9ca79e8298e2a09776cceb2901d4 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling ad7021252d7d690b332a5d460bfd75d24c69dbd2 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling 30281b4d538196cddc87498ec453762c07213fc3 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling 83cb837dd27c0b65e6fc89013f469455800116ab on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling d0f39605f5afcfff598f52efa645f2d730b3c915 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling acbe867752eb70928127ed5cc743916730d5bd19 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.09%) to 57.005% when pulling c725516830829d5a2d2a609a99918334ab9391e1 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling c725516830829d5a2d2a609a99918334ab9391e1 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling fa96a70c3da2b40a87cce211883f520a6ef14467 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling 1443497aa25f7e7640ff192067afa1999cd52453 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling 9c05d74c5deaf13fe5a003751cadf14086407082 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling 304bd14d6b5c49313738bd72523961d692d384ab on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling 304bd14d6b5c49313738bd72523961d692d384ab on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage decreased (-34.6%) to 22.286% when pulling 5d4d2f094c7cd3bc150dadbf9ce0879c778959e3 on project-list into ee2a42c601fa8227fb359c90003692a36e312cc9 on master.

Coverage increased (+0.07%) to 56.992% when pulling 54e3bd2f90bdd332e0f43639b3a3a1dd826905e6 on project-list into bb3ecd05f599fe3ac713119283bd3a00409deb2a on master.

Coverage increased (+0.08%) to 56.999% when pulling 54e3bd2f90bdd332e0f43639b3a3a1dd826905e6 on project-list into bb3ecd05f599fe3ac713119283bd3a00409deb2a on master.

Coverage increased (+0.07%) to 56.992% when pulling 54e3bd2f90bdd332e0f43639b3a3a1dd826905e6 on project-list into bb3ecd05f599fe3ac713119283bd3a00409deb2a on master.

Coverage increased (+0.07%) to 56.992% when pulling 0e05bca0255236ccdbfb22853727a699f1259752 on project-list into bb3ecd05f599fe3ac713119283bd3a00409deb2a on master.

Coverage increased (+0.07%) to 56.992% when pulling 0e05bca0255236ccdbfb22853727a699f1259752 on project-list into bb3ecd05f599fe3ac713119283bd3a00409deb2a on master.

Coverage increased (+0.07%) to 56.992% when pulling ce1991c6853b1bef89a8976355ecd2e9c86a40fc on project-list into bb3ecd05f599fe3ac713119283bd3a00409deb2a on master.

Coverage increased (+0.09%) to 57.005% when pulling 8331721a97a0f01b6b1c7f8df90464a7a1a9b6da on project-list into bb3ecd05f599fe3ac713119283bd3a00409deb2a on master.


event notify without container name

In the container state change event: die or destroy.
Sometimes it will response without container name, but container id is correct.
Maybe this issue  occurs from v1.6.0 in my experience.

Hi!
If you are reporting a new issue, PLEASE make sure that does not have any duplicates already open.
We would like to take this time to remind you of the information we need to debug the problem you are seeing. This is an automated response so if this ticket is not about a bug, do not fret.
If you fail to provide this information within 7 days, we will close this because we cannot debug your issue. We can reopen whenever the information is provided.
Thank you.
Please see:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues
Description of problem:

`docker version`:

`docker info`:

`uname -a`:

Environment details (AWS, VirtualBox, physical, etc.):

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual Results:

Expected Results:

Additional info:

#ENEEDMOREINFO

@linlinlinlin pretty sure container name isn't logged at all in docker events (https://github.com/docker/docker/blob/master/daemon/container.go#L205) so maybe I'm missing something here. Do you expect to get the container name in docker events? Btw I'm testing this on docker 1.6.2 so almost sure container name isn't logged

Sorry I make a mistake here. Just ignore this issue.


Could I use with React?

I would like to use with React.
Could ...?

I haven't tested this package with React, but it should.
Let me know after you test it.

OK it work fine.
Thanks

@thearabbit great, thank you for testing


ntr: calcium ion import across plasma membrane

descendent of
GO:0070509calcium ion import;
GO:0098739 import across plasma membrane
standard def
supporting ref PMID:15537393

GO:0098703 calcium ion import across plasma membrane
exists,
missing GO:0098739 import across plasma membrane
parent

couple of hops up the class hierarchy to get to GO:0098739 import across plasma membrane

OK!


Create Sign in modal

When the user selects sign in, they should be able to view the sign in modal.
Selecting sign in, should return user back to the home page. only a css modal.

Done, CSS probably needs altering (sign in lines could be smaller or input boxes if needed). Colour of submit button needs changing too.


Tooltip throws "hasOwnProperty is undefined" error after upgrading jQuery to 3.5.0

At snapappointments/bootstrap-select#2430 developers were fighting the same error.
The problem comes from JQuery 3.5.0 (jquery/jquery#3256).
Error:
jquery.self-99e868a06761df8565fc4890f21060bdf24ca79307ff02224f603448ab9044f7.js?body=1:4056 Uncaught TypeError: dataAttributes.hasOwnProperty is not a function
    at Tooltip.getOptions (bootstrap.self-268df15f6dcd79a7aab1677a4cf8f1bf54a59cb6d1e805efa0e1f8071110762e.js?body=1:1509)
    at Tooltip.init (bootstrap.self-268df15f6dcd79a7aab1677a4cf8f1bf54a59cb6d1e805efa0e1f8071110762e.js?body=1:1472)
    at new Tooltip (bootstrap.self-268df15f6dcd79a7aab1677a4cf8f1bf54a59cb6d1e805efa0e1f8071110762e.js?body=1:1442)
    at HTMLAnchorElement.<anonymous> (bootstrap.self-268df15f6dcd79a7aab1677a4cf8f1bf54a59cb6d1e805efa0e1f8071110762e.js?body=1:1944)
    at Function.each (jquery.self-99e868a06761df8565fc4890f21060bdf24ca79307ff02224f603448ab9044f7.js?body=1:382)
    at jQuery.fn.init.each (jquery.self-99e868a06761df8565fc4890f21060bdf24ca79307ff02224f603448ab9044f7.js?body=1:204)
    at jQuery.fn.init.Plugin [as tooltip] (bootstrap.self-268df15f6dcd79a7aab1677a4cf8f1bf54a59cb6d1e805efa0e1f8071110762e.js?body=1:1938)
    at HTMLDocument.<anonymous> (custom.self-cb0a74f9d336bee94b1510c8cf4ec0d5a4ff3a037787b0094eec42b3e5a0483d.js?body=1:26)
    at mightThrow (jquery.self-99e868a06761df8565fc4890f21060bdf24ca79307ff02224f603448ab9044f7.js?body=1:3763)
    at process (jquery.self-99e868a06761df8565fc4890f21060bdf24ca79307ff02224f603448ab9044f7.js?body=1:3831)

Error source: https://github.com/twbs/bootstrap/blob/v3.4.1/js/tooltip.js#L223
npm packages:
"bootstrap": "3.4.1",
"jquery": "^3.5.0",

Solution will be to use Object.hasOwnProperty.call(obj, property).
I'm not sure if this error is present also at Bootstrap v4 but v3 needs definitely fix. JQuery team is not going to change it.

Duplicate of #30553, please search for existent issues before creating a new one.

@XhmikosR my issue is related to Bootstrap v3.4.1. The fix was released only for v4.4.1.

v3 is EOL.


Library dependency not found (libippresample.so)

Hi,
When trying to build and run the SubstituteAudioEffect sample, we receive the following error:
at org.m4m.android.ResamplerAndroid.loadLibrary(ResamplerAndroid.java:47) at org.m4m.android.ResamplerAndroid.setup(ResamplerAndroid.java:53) at org.m4m.domain.Resampler.<init>(Resampler.java:38) at org.m4m.android.ResamplerAndroid.<init>(ResamplerAndroid.java:38) at org.m4m.effects.DifferentRateAudioReader.<init>(DifferentRateAudioReader.java:46) at org.m4m.effects.AudioReader.start(AudioReader.java:93) at org.m4m.effects.SubstituteAudioEffect.setFileUri(SubstituteAudioEffect.java:59)
We can see in ResamplerAndroid.java that it references:
final private String resamplerLibName = "ippresample"; // libippresample.so
This library does not appear to be in the project anywhere, and attempts to search online have not yielded anything (we also tried downloading various packages from the intel website, but could not find it anywhere).
We found a reference in a tutorial here
As you can see, others seem to be having the same issue (in the comments).

@timsk159 did you find this lib file libippresample.so ?


Complement to WithDnsServer() ?

I see that there is a "WithDnsServer()" and the effect is additive, but it would be nice if this page explained how to REMOVE a Dns server from the list.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d68bdbc7-4212-8f18-1199-e8f92ec238b5
Version Independent ID: f74a5671-8d63-c537-10d0-52c0de6d068d
Content: IUpdate Interface (Microsoft.Azure.Management.Network.Fluent.Network.Update) - Azure for .NET Developers
Content Source: xml/Microsoft.Azure.Management.Network.Fluent.Network.Update/IUpdate.xml
Service: virtual-network
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

Hi @CodyBatt.  Thank you for your feedback.  The Microsoft.Azure.Management.Network.Fluent package is deprecated and receiving only critical bug and security fixes.  As we recommend preferring the Azure.ResourceManager.Network package as a replacement, we do not plan on adding further examples to the existing documentation.


[FIX] Social accounts interface is show after going to TwoFAFragment

Even hidden (this happens when a server does not allow the authentication via social accounts - Github, Meteor, Facebook, Twitter and so on) the social accounts interface is show after going to TwoFAFragment.
To see this issue your account must be with Two-Factor Authentication enabled: enable it from the server web app (My Account>Security).

Hey @filipedelimabrito i would like to work on this issue.

@filipedelimabrito Can this one be closed already?

@rafaelks Closing it. Already fixed.


Read Me Improvements

Just added some of the things I've learned to the readme.md in case we want to include this to help other people that are new to the project.
I understand if this seems too amateurish, but maybe having this information on the readme could speed up people getting involved in the project.

This is really reasonable


Inline emotion css calls that require theme to avoid using state

Issue:
getDerivedStateFromProps can be called before the prop theme is set by react-emotion which causes errors.
What I did
Inlined the css calls instead of placing them on the component's state. withTheme will rerender this component when the theme changes so there is no need to use getDerivedStateFromProps.
How to test
Is this testable with Jest or Chromatic screenshots?
Does this need a new example in the kitchen sink apps?
Does this need an update to the documentation?
If your answer is yes to any of these, please make sure to include it in your PR.
fixes #3840
For maintainers only: Please tag your pull request with at least one of the following:
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

I've tried to get all the checks but I am unable to get it right. If someone could give me some pointers I'd be grateful.

Thank you @tkh44 !

@ndelangen I should have been more clear that this is a bugfix and the bug this issue causes keeps the storybook from rendering at all in the latest alpha releases in some situations. I couldn't pin down the exact cause of the bug but this PR fixes it.

@shilman as @tkh44 mentions, let's do an alpha release rather quick?


map.Locator request

It would be nice if there were an option for the map.Locator widget to trigger itself, without user intervention, when the page has loaded.

@thisisaaronland i just tried it by looking https://github.com/domoritz/leaflet-locatecontrol#methods
locator.start();

Ah, interesting. There is nothing in the mapzen.js documentation to indicate that the Locator thing is not our own thing or pointing to the leaflet-locatecontrol documentation.

In the README at the bottom it links out to it, but it could be written out in a clearer way in the docs :)

Yes, please. Not least because I am unlikely to get to the bottom of the README once I see that the documentation is somewhere else.
When mz.js is implementing someone else's thing it would be very helpful to call that out explicitly in the documentation for that thing.


Add template that uses the Serverless framework for deployment

Including creating the right permissions, lambda, and DynamoDB for e.g. AWS
https://serverless.com/

Hi @jankoenig i'm interested to pick up this issue

Cool! Let me know if you need more info.
I started playing with it a few months ago. Here's part of the serverless.yml (I commented out some things and am not sure if everything works):
service: jovo-project-name  # Update

custom:
  defaultStage: dev
  currentStage: ${opt:stage, self:custom.defaultStage}

provider:
  name: aws
  runtime: nodejs8.10
  stage: ${self:custom.currentStage}
  # iamRoleStatements:
  #   - Effect: "Allow"
  #     Action:
  #     - dynamodb: GetItem
  #     - dynamodb: PutItem
  #     - dynamodb: CreateTable
  #     Resource: "arn:aws:dynamodb:*:*:table/*"

# Define service wide environment variables here
# environment:
#   STAGE: ${self:custom.currentStage}

package:
 include:
   - index.js
   - app/**
 exclude:
   - platforms/**
   - models/**

functions:
  app:
    handler: index.handler
    events:
      # - alexaSkill: ${file(./app.json):stages.${self:custom.currentStage}.alexaSkill.skillId}

      # API Gateway
      # - http:
      #     method: post

    # Define function environment variables here
    environment:
      STAGE: ${self:custom.currentStage}

Thanks @jankoenig i was looking at how to setup the example projects in my free time within the past few days. It seems like the setup is not as straightforward as i thought, i might need some time to get some template files working with my own AWS account (need to get some free time to do so). If anyone with experience with this framework would like to go ahead and implement this ahead of me then i would encourage them to do so instead

This is a really interesting proposal. Has any progress been made on this? I'd definitely be happy to contribute.

No one has contributed yet, but I know that a few people are using Serverless for Jovo projects. e.g. @dominik-meissner


Overhaul of CI infrastructure

This is a overhaul of our overall CI structure to build, test and deploy artifacts. It moves all build jobs to a single workflow so we can properly declare dependencies between them.
Also removes the Generate Manifests action which adds a commit to all PRs. This is replaced by a job which regenerates charts and manifests and then fails the workflow if git diff shows any changes. This is based on the assumption that in that case obsolete crds, charts and/or manifests were committed.
fixes https://github.com/stackabletech/issues/issues/156
Also adds various fixes:

update helm & cargo deny actions
remove dependabot and add renovate
change bors to wait for an approving review
remove (but not delete) helm roles.yaml so those can be managed in the operators
fix shebang in generate manifests
fix weird cp behavior for product config in makefile (subdirectory 'config-spec' should be removed now)
add reviewdog workflow to run various linters on pull requests
add udeps job to find unused dependencies

I have created an example PR that should match what will be generated by this once it is merged here: https://github.com/stackabletech/zookeeper-operator/pull/388

I'm not sure why you reindented the python file but I'm fine. I look forward to have these changes merged!

I ran pylint offline on the file and it complained about every single line. Brief googling seemed to confirm 4 space-indentation as the norm for python ..

Ah! One more thing. Could you add .flake8 and .pylintrc (https://github.com/stackabletech/operator-templating/blob/main/template/.pylintrc) also to the main directory of the operator-templating repo?
I think that explains your last commit

Yeah 4 is a default but someone started with 2 here and I liked it better as well (consistent with our other stuff) so I decided to adapt pylint but I don't really have a super strong opinion.
With an indentation of 4 it'll conflict with the pylintrc file in the repos though.
So we should either change the pylintrc file or revert your formatting commit. I don't care which option you choose :)

reverted it to 2 space indentation

also added the linter config to templating


Charts configures the ServiceMonitor to scrape the /api/plugins/capacity-metrics/rq-metrics endpoint by default

The rq-metrics are no longer supported in the latest version of the capacity-metrics application.
I am using the default values for the ServiceMonitor configuration: https://github.com/nautobot/helm-charts/blob/fc581e61380983d24a67ac32afd3b2db3290ceeb/charts/nautobot/values.yaml#L932-L939
These values configure Prometheus to use the /api/plugins/capacity-metrics/rq-metrics endpoint, which is no longer supported in the latest versions of the capacity metrics application. We should remove this all together or make it optional: https://github.com/nautobot/helm-charts/blob/fc581e61380983d24a67ac32afd3b2db3290ceeb/charts/nautobot/templates/servicemonitor.yaml#L31
This setting generates a lot of errors like this:
[pid: 24|app: 0|req: 585/956] <IP_ADDRESS> () {32 vars in 610 bytes} [Mon Feb  5 09:47:06 2024] GET /api/plugins/capacity-metrics/rq-metrics => generated 24 bytes in 44 msecs (HTTP/1.1 404) 6 headers in 186 bytes (1 switches on core 1)

We should remove this monitor entirely.


Fix streams not stopping when buffer ends with a small ammount of frames

Continues on #55808
and fixes #54821
It was still possible for ogg streams to fail stopping (and probably other streams as well) if mixing the streams ended with less than 4 frames mixed.
This is because the if statement that is edited requires "internal_buffer_end" to be equals to "idx", but this is impossible in some cases since "idx" is never less than 4
The included minimal reproduction includes 2 ogg files. One of them fails to stop with #55808 and they both stop with this change.
cstaavetti_minimal_reproduction2.zip

I think this changes the resampling behavior in a way I don't like, but I'd have to test it to figure out exactly how. Basically, AudioStreamResampled uses a cubic resampling algorithm that looks at the last four samples of the OGG or MP3 to determine the next sample that will be played through the speakers. The audio system's time marches forward at a rate that's independent of the sample rate of the OGG, so we have to use the idx value here to determine which samples actually count as "the last four". Inside this method, mix_offset tracks which sample in the internal buffer is closest to the current time, and mu indicates the sub-sample offset that the resampling algorithm needs to take into consideration.
Looking at the code, I'm not sure this class is at all appropriate for situations in which you need sample-accurate playback.

Fair enough.
The issue still exists though, but i suppose maybe the fix needs to be different.
Anyways it appears i failed to take in to account that  "internal_buffer_end" unsigned and if this pull request were to be accepted i think the if statement would need to be changed to:
if (idx >= internal_buffer_end && mixed_frames_total == p_frames) {

Oh wow, I think the current condition is literally just checking for equality. Oops. 😆 It checks <= and >= with the same values doesn't it. I'm going to have to think about this. What we're trying to do is keep mixing until the internal buffer (that mix_offset and mu are referenced to) is empty. Detecting that is tricky though because the timescales could be completely different, but the idea here is to gracefully handle the end of stream, instead of just doing an out-of-bounds read. Maybe there's a way to simplify it though. It would be nice to handle this case on a best-effort basis instead of just never stopping playback.

Could you test this snippet you suggested earlier with a variety of files?
if (idx >= internal_buffer_end && mixed_frames_total == p_frames) {
I think it could just work, but I'm not awake enough to be compiling godot quite yet, need to get breakfast and other things. :)

Yes, ill test it with a bunch of files and then update my commit if it seems ok.
Understandable, I think we are in very different time zones :D

Well, from what I can tell, the change does not cause any issues of its own.
But when I was testing it I did run in to another edge case with a few ogg files.
If an ogg file really ends with exactly 256 frames mixed it will still fail to stop, because of the reasons previously discussed.
So far I have only come up with silly solutions to this. Its easy enough to spot when it happens, but what should be done after spotting it?
"AudioStreamPlaybackOGGVorbis::_mix_internal* could just lie about the amount of mixed frames by one, and it should work.
But maybe this would cause some issues I'm not thinking of.
I included a short ogg file that this can be tested with.
snip.zip

Could you make an issue (or even multiple issues) to track these edge cases? I want to make sure they're not lost in the comments of a PR, because it's not often the audio system gets this much scrutiny and I want to make sure your work doesn't go to waste.
Regarding a fix, I don't really like the idea of lying about how many frames were mixed, but I can't immediately think of anything else. I'll study the code for a bit. I think the solution might be more of a refactor than a point fix this time.

Ok, I guess these issues should be separated from this PR, since we don't even have a fix for one of them here.
I'll make new issues soon.
Lying about the frames is something that could be done right now, but I agree its not the nicest idea.
I would not want to add it either.
Really I think the information about the stream ending should be entirely decoupled from the last mixed frames amount, because its not always possible to know if the stream ended or not by just looking at it.

I tentatively think #55846 should fix these edge cases. @cstaavetti If you have time to test I'd love to get your opinion. There aren't many audio contributors to review code, so if you want to go through the code and review it I would also appreciate that. I know you don't have approval power, but you have read this code more recently than everyone else who does have approval power. No worries if you don't have time, though :)

Superseded by https://github.com/godotengine/godot/pull/55846.


MASTERJJJ/docs

App

Why:

Closes [issue link]
What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[ ] For content changes, I have reviewed the localization checklist
[ ] For content changes, I have reviewed the Content style guide for GitHub Docs.

Commands:
p, pick  = use commit
r, reword  = use commit, but edit the commit message
e, edit  = use commit, but stop for amending
s, squash  = use commit, but meld into previous commit
f, fixup  = like "squash", but discard this commit's log message
x, exec  = run command (the rest of the line) using shell
b, break = stop here (continue rebase later with 'git rebase --continue')
d, drop  = remove commit
l, label  = label current HEAD with a name
t, reset  = reset HEAD to a label
m, merge [-C  | -c ]  [# ]
.       create a merge commit using the original merge commit's
.       message (or the oneline, if no original merge commit was
.       specified). Use -c  to reword the commit message.

These lines can be re-ordered; they are executed from top to bottom.

If you remove a line here THAT COMMIT WILL BE LOST.

However, if you remove everything, the rebase will be aborted.

Note that empty commits are commented out

App
Why:
Closes [issue link]
What's being changed:
Check off the following:

[ ]  I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[ ]  For content changes, I have reviewed the localization checklist
[ ]  For content changes, I have reviewed the Content style guide for GitHub Docs.


[rtl/dv] Fixes for Cadence Xcelium 20.09.001 compile and run. Regress…

…ion has been run with these changes and (REGRESSION SUMMARY: 428 PASSED, 0 PASSED/FAILED, 2 FAILED)
Compile error 1: Fixed the following rtl compile error in ibex_cs_registers.sv
assign tselect_rdata = {'b0, tselect_q};
                          |

xmvlog: *E,NONOWD (/proj/riscv_ibex/users/paulok/lowRISC/ibex_1/rtl/ibex_cs_registers.sv,1288|30): Illegal use of a constant without an explicit width specification [4.1.14(IEEE)].
Compile error 2: Fixed the following DV compile error in ibex_mem_intf.sv
.data_req_o     (data_mem_vif.request ),
|
xmelab: *E,ICDCBA (./tb/core_ibex_tb_top.sv,89|14): Illegal combination of driver and output clockvar to variable 'request' detected (output clockvar found in clocking block at line 25 in file ./common/ibex_mem_intf_agent/ibex_mem_intf.sv).
Simulation probes: Fixed issue with probing in yaml for xrun and added licqueue.
Signed-off-by: Paul OKeeffe<EMAIL_ADDRESS>

Any tips on how to re-create this problem? it seems to be coming from fusesoc.
Thanks
Paul

Wasnt exactly sure how to modify an existing pull request, so I submitted it as a new one.
Closing this now.

For next time, you can just force-push to the same branch. If you had https://github.com/PaulOKCrevinn/ibex as a remote called origin, it would just be git push -f origin HEAD:b_cadence_xcelium_20_09_001_compile_fixes.

Thanks, I've noted this, I am a familiar with git but not a power user so still learning...


Ensure InstallSource extraction logic runs after privacy config downloaded

Task/Issue URL: https://app.asana.com/0/608920331025315/1208315780180365/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

#5013  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CDRussell and the rest of your teammates on  Graphite

@CDRussell I'm not seeing "Installation source extracted" in logcat

We followed up offline, was just a DI caching issue. clean build fixed it.

Merge activity

Sep 30, 9:37 AM EDT: @CDRussell started a stack merge that includes this pull request via Graphite.


[SW-15644] Adding Productnavigation for Productstream

This PR checks, when the Productnavigation is created, if a the category is a productstream. If it is, the criteria for his Productstream will be selected. And then the Programm seraches with the new criteria for the items.

Questions
Answers

BC breaks?
no

Tests pass?
yes

Related tickets?
https://issues.shopware.com/issues/SW-15644

How to test?
Create a Productstream and a category with that Productstream. Go to that category and click on an article. Then check if you can go to the next or/and privious items on the Product detail page.

Done.


Use createImageBitmap for image decoding when available

While profiling in Chrome, I noticed quite a few ms being spent in decoding satellite images on the main thread. Using ImageBitmap this decoding could be offloaded to the background. ImageBitmap is currently supported by Firefox, Chrome & Opera.
https://developers.google.com/web/updates/2016/03/createimagebitmap-in-chrome-50

"The problem with decoding images is that it can be CPU intensive, and that can sometimes mean jank or checkerboarding. As of Chrome 50 (and in Firefox 42+) you now have another option: createImageBitmap(). It allows you to decode an image in the background, and get access to a new ImageBitmap primitive, which you can draw into a canvas in the same way you would an  element, another canvas, or a video."

Resources from #5963

https://github.com/mrdoob/three.js/pull/12456
https://twitter.com/donrmccurdy/status/925800420101931008
https://twitter.com/superhoge/status/1052609244824887296

Implemented in #7579


MEN-1992: Document U-Boot/UEFI/GRUB boot method + some minor fixes

commit 0691bc54ad939ad146a13903289eaab5038dbb64
Author: Kristian Amlie<EMAIL_ADDRESS>Date:   Mon Aug 20 20:10:29 2018

    MEN-1992: Document U-Boot/UEFI/GRUB boot method.

    Signed-off-by: Kristian Amlie<EMAIL_ADDRESS>
commit fc660f12c1a5e7492518599292be004df7085b57
Author: Kristian Amlie<EMAIL_ADDRESS>Date:   Mon Aug 20 20:09:56 2018

    Fix incorrect reference to data partition.

    Be careful to keep the original anchor around as well.

    Signed-off-by: Kristian Amlie<EMAIL_ADDRESS>

@drewmoseley. @estenberg: Updated!

Cherry-picked to 1.5.x and 1.6.x as well.


gh action: add gofmt check

Add check to ensure the code is formatted according
to gofmt standards.
Signed-off-by: Francesco Romani<EMAIL_ADDRESS>

/lgtm


Change download link to bitcoincore.org

bitcoincore.org hosts binaries. Point to bitcoincore.org for downloads.

Before we do that, I think we should check how secure the bitcoincom.org domain/setup is. IMO bitcoin.org has a pretty secure setup (not sure though).
Where is it hosted, etc.?
The GPG/gitian signatues are the best way to make sure the binaries are tamper-free, though users tend to not even verify the SHA256sum.

Agree with @jonasschnelli that the technical difference of the server setup is important to consider here.

The bitcoin core setup is enormously more secure than bitcoin.org.   It is a separately racked and caged set of physically isolated hosts which requires multi-party authorization for login.

Thanks @gmaxwell for clarification. I do not know who is responsible for the setup and how it's done. But after @gmaxwell statement it seems that someone does take care of it.

Things I think could be improved:
Cloudflare DNS?
Name Server: VIOLET.NS.CLOUDFLARE.COM
Name Server: DAMON.NS.CLOUDFLARE.COM

No IPv6?
;; QUESTION SECTION:
;bitcoincore.org.		IN	AAAA

Standard SSH port (probably okay):
ssh <IP_ADDRESS> -p 22 (or ssh <IP_ADDRESS> -p 22)
The authenticity of host '<IP_ADDRESS> (<IP_ADDRESS>)' can't be established.
ECDSA key fingerprint is SHA256:0/Wakhy8n3/wJ9UkgLVU7nfyBFhqdJ+lrAY/sAXT4bY.

I'm not gonna go into all the details of the setup here. If someone wants a list of how things are set up, feel free to ping me on IRC.

I agree with changing download links to BitcoinCore.org, as it is likely much more secure than Bitcoin.org based on what I've been told about the two different setups.
I think we can probably do better by copying the rather nice MIT-licensed https://bitcoin.org/en/download page to this site and linking to that rather than the bare /bin directory..  I'll work on that presently and try to prepare a PR for it by Wednesday afternoon.

Agree with @harding. A such download page should be added (through a separate PR)

I was thinking of it as an alternative to this PR, but there's very little cost to changing the links twice, so I'll base my work on top of this PR.

I think we can probably do better by copying the rather nice MIT-licensed https://bitcoin.org/en/download page to this site and linking to that rather than the bare /bin directory.. I'll work on that presently and try to prepare a PR for it by Wednesday afternoon.

:+1: I look forward to reviewing that.


progress on #431; cleaned up build menus

Codecov Report

Merging #496 into master will decrease coverage by 18.16%.
The diff coverage is 95.23%.

@@             Coverage Diff             @@
##           master     #496       +/-   ##
===========================================
- Coverage   89.62%   71.46%   -18.17%
===========================================
  Files          47       47
  Lines        3633     3567       -66
===========================================
- Hits         3256     2549      -707
- Misses        377     1018      +641

Impacted Files
Coverage Δ

setup.py
0% <ø> (ø)
:arrow_up:

vent/menu.py
81.31% <100%> (ø)
:arrow_up:

vent/menus/tools/tool_forms.py
100% <100%> (ø)

vent/menus/tools/tools.py
91.25% <91.3%> (ø)

vent/menus/choose_tools.py
18.84% <0%> (-72.47%)
:arrow_down:

tests/test_menu.py
34.04% <0%> (-65.96%)
:arrow_down:

vent/menus/start_tools.py
27.83% <0%> (-61.86%)
:arrow_down:

vent/menus/add.py
33.33% <0%> (-60.61%)
:arrow_down:

vent/menus/add_options.py
27.27% <0%> (-60%)
:arrow_down:

vent/menus/remove_tools.py
31.64% <0%> (-58.23%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7aba75f...ff2eb7c. Read the comment docs.


Add info to the Installation section (or wiki page?) about HMAC

The HMAC library used here isn't the one available via a luarocks install, which installs the repo maintained here:
https://github.com/jamesmarlowe/lua-resty-hmac
The HMAC library we need instead is this one:
https://github.com/jkeys089/lua-resty-hmac

README gives the right repo of hmac.
And if you use luarocks to install lua-resty-jwt, it automatically installs the right hmac lib.
I'll add more tip in the readme❗ Thank for your advice

👍  done