Create local and network component resolvers

We need the option to use local components when using Slimmer in the static component guide (which lives in Static). This avoids network requests, excessive network stubbing and i18n chain hacks.
Because static components have a .raw.html.erb filename, we can’t use the default Rails component resolver. eg govuk_component/title can’t find the _title partial – we need to load title.raw.html.erb.

Split ComponentResolver into LocalComponentResolver and NetworkComponentResolver
Create new module for LocalGovukComponents which govuk_publishing_components can use when included on static
LocalGovukComponents don’t need a test version

Alternative to: https://github.com/alphagov/static/pull/1144
The LocalGovukComponents will be loaded in the govuk_publishing_components gem when used on static: https://github.com/alphagov/govuk_publishing_components/blob/master/app/controllers/govuk_publishing_components/application_controller.rb#L4

@nickcolley I've confirmed this branch works with Static i18n. On static the locale file is in the standard place that Rails looks for it, so localisation works as normal.


BUG: Document text with two dollar signs doesn't render properly in Jupyter

Steps to reproduce:

Open CoNLL_View_Doc.ipynb in this project, which views individual documents from the CoNLL-2003 corpus.
Point the viewing code at document 35 of the dev fold of the corpus

You'll see something like this:

Note the italic text without spaces. That text is supposed to read "... for $31 a share, or $135 million ...". Instead, JupyterLab is interpreting the dollar signs as the boundaries of a region of embedded LaTeX code.
The _repr_html_() method of CharSpanArray and TokenSpanArray should return a string that renders properly, even when the document contains dollar signs. The current code does escape dollar signs (the above snippet turns into for $31 a share, or $135 million), but some component of JupyterLab drills through the escaping and treats the $'s and everything between them as LaTeX.
A simpler way to reproduce the core problem is to run the following code in a JupyterLab notebook:
class ReproduceBug:
    def _repr_html_(self):
        return "for $31 a share, or $135 million"

ReproduceBug()

Recommended steps to fix this problem:

Figure out what modifications to the above ReproduceBug class's _repr_html_ method will make JupyterLab display the target text with dollar signs
Modify the function util.pretty_print_html() under text_extensions_for_pandas so that the logic in that function for escaping special characters follows whatever procedure worked in the previous step
Add a new regression test (or modify an existing regression test) to cover the current problem with displaying dollar signs and ensure that the problem does not recur. Existing regression tests can be found in text_extensions_for_pandas/test_util.py

Closed by #32.


can this be migrated to segmentation

thanks for your code release, you did detection, will segmentation be ok?

Hi,
Thank you for your interest. Our model already includes instance segmentation (see demos in README.md).
If you are asking about semantic segmentation, there are already great concurrent works using the CLIP classifier (see lang-seg and OpenSeg). However, it's unclear how to use image-level supervision to help there.
Best,
Xingyi

Closing due to lack of activities. Feel free to reopen.


Decommission GPS Network Windows server

ref: #153
Benefit
GPS server (grwgps4) is migrated. This objective ensures that the last remnants of the 2012 Windows server is dealt with and deprecated.
Success
All tasks related to ServiceNow requests to remove the on prem Windows server are completed.

Sprint 1 Tasks:

[ ] Decommission grwgps4

Closing Notes
This server was decommissioned successfully

[ ]


Pack does not include referenced project.

Description
I'm trying to use paket for packing FsXaml and the FsXaml.Wpf.dll does not get included in the package.
Repro steps
Run pack on FsXaml.Wpf.zip
Check if FsXaml.Wpf.dll is in the package.
Known workarounds
Use type file

paket.exe pack output out include-referenced-projects

==>

Oh, I thought it included by default. Why is explicit include-referenced-projects needed in this case?

that's always been an explicit parameter.

maybe you can come up with a flag in the template file so that you don't need to type that every time

so there is a new flag in the template file see http://fsprojects.github.io/Paket/template-files.html#Referenced-projects
you are welcome ;-)


Completions in macros should be aware of completing multiple idents

When typing inside a macro we should consider all downmapped positions of the ident we are currently typing out instead of just the first one, that way we get more completions that might make sense.
Example given the following macro:

macro_rules! tuple_to_record_closure {
    ($ident:ident { $( $field:ident ),+ $(,)? }) => {
        |($( $field ),+)| $ident { $( $field ),+ }
    };
}
struct Foo { foo: () }
fn main() {
    tuple_to_record_closure! {
        Foo {
            f$0
        }
    }
}

Typing at the given position should offer the completion of the foo field as the ident is downmapped to a field position as its second usage, currently we only consider the parameter position though.
This also has the potential to create a lot of duplicate completions which have to be filtered out, as well as making completions in macros potentially very slow if we were to stupidly repeat completions for each downmapped token, so this probably requires some architecture changes if we want to pursue this.
cc https://github.com/rust-analyzer/rust-analyzer/issues/11059

But shouldn't the completion make sense for all positions? So we'd have to take the intersection?

The completion makes sense in the argument position too, but it isn't suggested as any ident (including a not yet used ident) makes sense there without any preference.

As bjorn3 said, I think this issue here should be about the union of such completions, while https://github.com/rust-analyzer/rust-analyzer/issues/11059 would be filtering invalid ones out by the fragment capture type.


Migration not found on migrate:reset with --path

Laravel Version: 6.9.0
PHP Version: 7.2.12
Database Driver & Version: mysql 5.7

Description:
when running migrate:reset with --path option，show ：Migration not found 2020_01_05_165208_create_modules，but This migration belongs to another path, not this path, and is not expected to be reset
Steps To Reproduce:
Run:
php artisan migrate:reset --path=modules/Content/Database/Migrations
Show：
Migration not found: 2020_01_05_165208_create_modules
The migration '2020_01_05_165208_create_modules' is in ‘database/migrations’
if i run migrate:reset with --path option，Shouldn't it just reset the specified path?
The result is correct, but the message displayed feels wrong
Thanks for your help！

Looking at the source code：
vendor\laravel\framework\src\Illuminate\Database\Migrations\Migrator.php
    public function reset($paths = [], $pretend = false)
    {
        // Next, we will reverse the migration list so we can run them back in the
        // correct order for resetting this database. This will allow us to get
        // the database back into its "empty" state ready for the migrations.
        $migrations = array_reverse($this->repository->getRan());

        if (count($migrations) === 0) {
            $this->note('<info>Nothing to rollback.</info>');

            return [];
        }

        return $this->resetMigrations($migrations, $paths, $pretend);
    }

The paths is correct, only included ‘modules/Content/Database/Migrations’，but the $migration is all migrations，I think it should only scan migrations in this path and exclude migrations in other path

Hey there,
Can you first please try one of the support channels below? If you can actually identify this as a bug, feel free to report back and I'll gladly help you out and re-open this issue.

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

Thanks!


Node group reduction fails during checkpointing

Original author: Thomas Quinn (@trquinn)
Original issue: https://charm.cs.illinois.edu/redmine/issues/1222

Running ChaNGa on 1024 nodes (32k cores) of Blue Waters, I am getting the following error during checkpointing:
[0] Checkpoint starting in cosmo600p.768.chk1
------------- Processor 8347 Exiting: Called CmiAbort ------------
Reason: Nodegrp Excess remote reduction message received!
[8347] Stack Traceback:
[8347:0] CmiAbortHelper+0x65  [0x203d12d5]
[8347:1] _ZN18CkNodeReductionMgr15finishReductionEv+0xb7  [0x20336b97]
[8347:2] _ZN18CkNodeReductionMgr9doRecvMsgEP14CkReductionMsg+0xe1  [0x203371c1]
[8347:3] _ZN18CkNodeReductionMgr7RecvMsgEP14CkReductionMsg+0x2d  [0x203372fd]
[8347:4] CkDeliverMessageFree+0x4d  [0x202eb84d]
aborting job:
Nodegrp Excess remote reduction message received!
[8347:5]   [0x202eefbc]
[8347:6] _Z15_processHandlerPvP11CkCoreState+0x59e  [0x202f0fe6]
[8347:7] CsdScheduleForever+0x85  [0x203dab75]
[8347:8] CsdScheduler+0x2d  [0x203dae95]
[8347:9]   [0x203d968a]
[8347:10]   [0x203d9b46]
[8347:11] +0x7806  [0x2aaaaacd4806]
[8347:12] clone+0x6d  [0x2aaaadf749bd]
------------- Processor 15310 Exiting: Called CmiAbort ------------
Reason: Nodegrp Excess remote reduction message received!
[15310] Stack Traceback:
[15310:0] CmiAbortHelper+0x65  [0x203d12d5]
[15310:1] _ZN18CkNodeReductionMgr15finishReductionEv+0xb7  [0x20336b97]
[15310:2] _ZN18CkNodeReductionMgr9doRecvMsgEP14CkReductionMsg+0xe1  [0x203371c1]
[15310:3] _ZN18CkNodeReductionMgr7RecvMsgEP14CkReductionMsg+0x2d  [0x203372fd]
[15310:4] CkDeliverMessageFree+0x4d  [0x202eb84d]
[15310:5]   [0x202eefbc]
[15310:6] _Z15_processHandlerPvP11CkCoreState+0x59e  [0x202f0fe6]
[15310:7] CsdScheduleForever+0x85  [0x203dab75]
[15310:8] CsdScheduler+0x2d  [0x203dae95]
aborting job:
Nodegrp Excess remote reduction message received!
[15310:9]   [0x203d968a]
[15310:10]   [0x203d9b46]
[15310:11] +0x7806  [0x2aaaaacd4806]
[15310:12] clone+0x6d  [0x2aaaadf749bd]
Here is the top of the run so you can pick out the Charm and ChaNGa versions:
Charm++> Running on Gemini (GNI) with 2048 processes
Charm++> static SMSG
Charm++> SMSG memory: 10112.0KB
Charm++> memory pool init block size: 8MB, total memory pool limit 0MB (0 means no limit)
Charm++> memory pool registered memory limit: 200000MB, send limit: 100000MB
Charm++> only comm thread send/recv messages
Charm++> Cray TLB page size: 2048K
Charm++> Running in SMP mode: numNodes 2048,  15 worker threads per process
Charm++> The comm. thread both sends and receives messages
Converse/Charm++ Commit ID: v6.7.0-342-g5bf8ddf
Warning> using Isomalloc in SMP mode, you may need to run with '+isomalloc_sync'.
CharmLB> Load balancer assumes all CPUs are same.
Charm++> cpu affinity enabled.
Charm++> cpuaffinity PE-core map : 1-15,17-31
Charm++> set comm 0 on node 0 to core #0
Charm++> Running on 1024 unique compute nodes (32-way SMP).
Main(CkMigrateMessage) called
Balanced injection is set to 30.
[0]CkRestartMain done. sending out callback.

Original date: 2016-09-26 13:58:01

Is the abort reproducible at smaller scales? We have a nightly test for node group checkpoint/restart, and it doesn't happen there.
This is the offending commit: ~~https://charm.cs.illinois.edu/gerrit/#/c/1847/~~ https://github.com/UIUC-PPL/charm/commit/f3937a55c7aaa6cc12f679656e984d41a7f700b3
I still think that commit is in itself sound, so there might be something weird going on here with node group reductions.

Original author: Thomas Quinn (@trquinn)
Original date: 2016-09-26 15:57:58

The simulation runs fine at 512 nodes (16k cores) on blue waters.  However, I'm able to reproduce it on SDSC comet with only 64 nodes of 24 (Haswell) cores.
Yes, the commit you point to is the one that bisect points to.

Original date: 2016-09-28 13:30:16

Nothing jumps out at me on (re-)inspection of that commit. A fairly straight-forward first few steps would be trying to reproduce the error at as small a scale as possible. Smaller input problem, smaller node count, shorter run length, etc.
Sam: You may also investigate whether the barrier call in the original code has some slight semantic difference from the contribute that it uses in the new code.

Original date: 2016-09-28 13:58:22

Ah, there are differences between barrier() and contribute(). I had thought that barrier() was just a nop reduction. but it is a special nop reduction that has no state to checkpoint and doesn't allow overlapping instances. It is only used in ckcheckpoint and ckmemcheckpoint...
~~https://charm.cs.illinois.edu/gerrit/#/c/1881/~~ https://github.com/UIUC-PPL/charm/commit/5202a9b2965f4fe85354d91c147f3965e715eb12


v0.7 upgrade

Right now we're stuck on https://discourse.julialang.org/t/cfunctions-with-local-types/12343/2

Needs a DiffEqBase.jl tag https://github.com/JuliaLang/METADATA.jl/pull/15741
but:
   Testing Sundials tests passed

Woot! @MartinOtter


[Snyk] Security upgrade sanitize-html from 1.4.2 to 2.12.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

89/1000  Why? Confidentiality impact: Low, Integrity impact: None, Availability impact: None, Scope: Unchanged, Exploit Maturity: Proof of Concept, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: Low, Attack Vector: Network, EPSS: 0.01055, Social Trends: No, Days since published: 0, Reachable: No, Transitive dependency: No, Is Malicious: No, Business Criticality: High, Provider Urgency: Medium, Package Popularity Score: 99, Impact: 2.35, Likelihood: 3.78, Score Version: V5
Information Exposure SNYK-JS-SANITIZEHTML-6256334
Yes
Proof of Concept

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Checkmarx One – Scan Summary & Details – e0f1ba5b-f487-475d-acae-fa84df4067da
New Issues

Severity
Issue
Source File / Package
Checkmarx Insight

CVE-2023-42282
Npm-ip-2.0.1
Vulnerable Package

Cxab55612e-3a56
Npm-braces-3.0.2
Vulnerable Package

Cxab55612e-3a56
Npm-braces-2.3.2
Vulnerable Package

Cxca84a1c2-1f12
Npm-micromatch-3.1.10
Vulnerable Package

Cxca84a1c2-1f12
Npm-micromatch-4.0.5
Vulnerable Package

Insecure_Storage_of_Sensitive_Data
/routes/likeProductReviews.ts: 17
Attack Vector

Insecure_Storage_of_Sensitive_Data
/routes/order.ts: 40
Attack Vector

Insecure_Storage_of_Sensitive_Data
/routes/order.ts: 158
Attack Vector

Insecure_Storage_of_Sensitive_Data
/routes/order.ts: 158
Attack Vector

JWT_No_Signature_Verification
/routes/verify.ts: 113
Attack Vector

Absolute_Path_Traversal
/routes/vulnCodeSnippet.ts: 75
Attack Vector

Absolute_Path_Traversal
/routes/vulnCodeSnippet.ts: 75
Attack Vector

Absolute_Path_Traversal
/routes/vulnCodeFixes.ts: 70
Attack Vector

Absolute_Path_Traversal
/routes/vulnCodeFixes.ts: 70
Attack Vector

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 23
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 30
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Unpinned Actions Full Length Commit SHA
/codeql-analysis.yml: 28
Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...


overriding styles.

Imagine I have three nodes:
BER with classes Germany EU
PAR with class EU
MIL with class EU
if I have a style like:
[{'selector': 'node', 'background-color': 'yellow'}
{'selector': 'node[classes="EU"]', 'style': {'background-color': 'blue'}},
{'selector': 'node[classes="Germany"]', 'style': {'background-color': 'green']
Which should be the colour in case of conflict? are the styles apply strictly in order of appearance in the list?
IN which case BER for being node is yellow, for being EU is blue, and for being Germany is green. So BER will rest Green.

From https://js.cytoscape.org/#style

For simplicity and ease of use, specificity rules are completely ignored in stylesheets. For a given style property for a given element, the last matching selector wins.

and the style is ordered so I would expect the node to be green.

Can we close @joseberlines ?


Dependency on .NET Standard 1.6.1

I was trying to utilize the Twilio.ASPNet.Core library in my Lambda function, but when I went to publish it to Lambda, I was informed that it has a dependency on .NET Standard 1.6.1, and the max version supported by netcoreapp 1.0 is 1.6.0.  Lambda only supports .NET Core 1.0, which is what this library says is the lowest version it supports.  Is there a trick in the .csproj file or something I can do to make this only use .NET Standard 1.6.0?

You can mark this as closed.  I used the Twilio REST API helper library 5.8.2.  Couldn't go any higher simply because of the later versions reference .net standard 1.6.1

I can definitely see how this would be extremely frustrating. Now that AWS Lambda supports .NET Core 2.0, I am closing this issue:
https://aws.amazon.com/about-aws/whats-new/2018/01/aws-lambda-supports-c-sharp-dot-net-core-2-0/


HDFS-15389. DFSAdmin should close filesystem and dfsadmin -setBalancerBandwidth should work with ViewFSOverloadScheme.

https://issues.apache.org/jira/browse/HDFS-15389

Thanks @ayushtkn for reporting it. LGTM.
However I have one point, can we add a note about balancer bandwidth command with overloadScheme when they need to pass -fs?
I think we have other commands to cover as well https://issues.apache.org/jira/browse/HDFS-15329.
How about we will just add a note down to the section of "dfsadmin with ViewFsOverloadScheme"
Something like this "Note: -setbanalcerbandwidth, (later with HDFS-15329: cacheadmin,ECadmin etc) would work in similar way, that user needs to pass -fs option to run on child filesystems"
Or we can keep a heading "HDFS commands with ViewFSOverloadScheme" then sub heading should be: dfsadmin, -setbalancerbandwidth etc?
I am ok either way. As we already updated guide, do you mind covering in doc?
Code changes looks fine to me.

Thanx @umamaheswararao will update the document, just a minor doubt on this. got little confused
bq. Or we can keep a heading "HDFS commands with ViewFSOverloadScheme" then sub heading should be: dfsadmin, -setbalancerbandwidth etc?
Why -setbalancerbandwidth should be a separate sub-heading from dfsadmin, -setbalancerbandwidth is also part of dfsadmin only? Or do you mean to say add it as sub heading of dfsadmin?
* Usage: hdfs dfsadmin -setBalancerBandwidth bandwidth

@ayushtkn, you are right. -setBalancerBancdwidthNeed need not be a separate sub heading. You can just add note in dfsadmin itself. Later I will add remaining commands(cacehadmin..etc) doc update.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 45s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 54s
trunk passed

+1 :green_heart:
compile
1m 14s
trunk passed

+1 :green_heart:
checkstyle
1m  1s
trunk passed

+1 :green_heart:
mvnsite
1m 30s
trunk passed

+1 :green_heart:
shadedclient
19m 10s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 51s
trunk passed

+0 :ok:
spotbugs
3m 49s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 46s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 23s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
checkstyle
0m 48s
the patch passed

+1 :green_heart:
mvnsite
1m 22s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 32s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 44s
the patch passed

+1 :green_heart:
findbugs
3m 48s
the patch passed

_ Other Tests _

-1 :x:
unit
133m 53s
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s
The patch does not generate ASF License warnings.

210m 44s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestClientReportBadBlock

hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics

hadoop.hdfs.server.namenode.ha.TestHAAppend

hadoop.hdfs.security.token.block.TestBlockToken

hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor

hadoop.hdfs.TestDFSStripedOutputStreamWithFailure

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.TestDistributedFileSystem

hadoop.hdfs.TestFileCreation

hadoop.hdfs.TestDFSInotifyEventInputStream

hadoop.hdfs.TestGetBlocks

hadoop.hdfs.TestBlocksScheduledCounter

hadoop.hdfs.TestStripedFileAppend

hadoop.hdfs.TestFileChecksum

hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy

hadoop.hdfs.TestEncryptionZones

hadoop.hdfs.TestDFSFinalize

hadoop.hdfs.TestBatchedListDirectories

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2057/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2057

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 6e0883103965 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 76fa0222f0d

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-2057/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-2057/1/testReport/

Max. process+thread count
3583 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-2057/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Most of these tests failed with the OOM errors. Could you please confirm the failed tests are running fine? Thank you

Thanx, the test failures aren't related


Correction for raw affiliation Aeres University of Applied Sciences, Dronten, The Netherlands

Correction needed for raw affiliation Aeres University of Applied Sciences, Dronten, The Netherlands
raw_affiliation_name: Aeres University of Applied Sciences, Dronten, The Netherlands
new_rors: 03jnx2c74
previous_rors: 015d5s513
works_examples: W2515935174;W3138418068;W4307405265;W4308695913;W4389375968;W4391685835
contact: 0f34f9a0e71579ab3f33f7e0a1bf9e56:1ccf28540a6a1107 @ aeres.nl

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Include relevant kotlinx-coroutines libs in dependency-management

Analogue to kotlinx-serialization: we should include the latest versions jvm and test libs for coroutines.

fixed with ea1aa9b


Table tests and Column show up in table data summary + count disapear

When clicking on the "Data Quality" tab in the top row we list both table and column tests summary, is that expected? I was under the impression only table tests would be listed here.
Also, when going from "Data Quality"/"Profiler" tab to the "Summary" tab the count disapear.
https://user-images.githubusercontent.com/13626425/188887047-1a4ec7d8-bb7e-4c77-8169-d56352997e09.mov

Hello, @TeddyCr Yes showing all the tests in the data quality test is intentional and also we have provided a filter for the same to filter out the table and column test!
Another one seems like a bug, I'll have a look! Thanks

@ShaileshParmar11 the counts should be linked and redirected to appropriate page

Fixed with #7325


Possibility of extending HPC session if time is running out

It is possible to extend the runtime of active slurm jobs using scontrol.
see: https://stackoverflow.com/questions/28413418/adding-time-to-a-running-slurm-job
This could be useful for instance when running a batch job and you are notified that time is running out, giving the option to extend would be nice :)

This may be limited to admins so maybe not possible


Removed dynamic evaluate functions

closes #166

I think I found a solution - https://github.com/GoogleChrome/puppeteer/blob/v1.0.0/lib/ExecutionContext.js#L42
const result = await handle.jsonValue().catch(error => undefined);

we should change the line
https://github.com/kblok/puppeteer-sharp/blob/master/lib/PuppeteerSharp/ExecutionContext.cs#L33
var result = await handle.JsonValue<T>();

and make it catch the exception and return null

Make sense, we should also add the EvaluateBigObject test here.

PuppeteerSharp.Tests.Puppeteer.PuppeteerLaunchTests.UserDataDirOption [FAIL]
System.Net.WebSockets.WebSocketException : The 'System.Net.WebSockets.InternalClientWebSocket' instance cannot be used for communication because it has been transitioned into the 'Aborted' state.

Conflicted @Meir017


Enable type inference for Menhir.

Type inference is required by Menhir 20211215.

what's the lower bound required by that?

What do you mean?
(using menhir 1.0) is bad because it prevents Dune/Menhir from doing type inference.
(using menhir 2.0) is preferable, but it's perhaps even better to say nothing.

I mean, is there a lower bound on menhir for (using menhir 2.0) to work? Or is that purely on the dune side?

It is purely on the dune side: Menhir never sees the directive (using menhir 2.0). On the dune side, I recommend requiring dune >= 1.4.0.

Alright then, that makes sense. On the other hand, the tests are now failing because the .mli doesn't copy the header that contains module aliases :/.

Sorry, I didn't notice that. Module aliases in the header currently are a known problem with Menhir and are discouraged.
If your grammar is very small, you could just type inference off by adding (infer false) to your menhir stanza (in the dune file) and manually give %type declarations (in the .mly file).

There's already %type annotations, and it was working well… I suppose I have to use the full paths now…

directly done on master by disabling inference.

There's already %type annotations, and it was working well…

Otherwise, another option is to switch to the table back-end, which does not (currently) require full type information. Add --table, link with menhirLib, and turn type inference off, and you should be able to keep the module aliases. But I would recommend getting rid of the module aliases.


Update PdfViewerEntry.php

Fix: Allow getFileUrl to return null when no file is available

Updated the getFileUrl method to handle cases where a file URL might not exist.
Changed the return type to string|null for better flexibility and to prevent type errors when null is returned.

Merge please :)

Thanks @kmoconnect

Thanks @kmoconnect

You're welcome!


schedule optimization

What type of PR is this?

[ ] bug
[ ] feature
[x] enhancement

What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:

Current:
$ kubectl get cm nebula-graphd-zone -o yaml
apiVersion: v1
data:
  nebula-graphd: ""
  nebula-graphd-0: az2
  nebula-graphd-1: az3
  nebula-graphd-2: az1
  nebula-graphd-3: az1
  nebula-graphd-4: az2
  nebula-graphd-5: az2
  nebula-graphd-6: az3
  nebula-graphd-7: az1
  nebula-graphd-8: az3
  nebula-graphd-9: az3
  nebula-graphd-10: az2
  nebula-graphd-11: az1
  nebula-graphd-12: az1
  nebula-graphd-13: az2
  nebula-graphd-14: az3
  nebula-graphd-15: az2
  nebula-graphd-16: az1
  nebula-graphd-17: az3
  nebula-graphd-18: az2
  nebula-graphd-19: az3

After optimization:
$ kubectl get cm nebula-graphd-zone -o yaml
apiVersion: v1
data:
  nebula-graphd: ""
  nebula-graphd-0: az2
  nebula-graphd-1: az3
  nebula-graphd-2: az1
  nebula-graphd-3: az2
  nebula-graphd-4: az3
  nebula-graphd-5: az1
  nebula-graphd-6: az2
  nebula-graphd-7: az3
  nebula-graphd-8: az1
  nebula-graphd-9: az2
  nebula-graphd-10: az3
  nebula-graphd-11: az1
  nebula-graphd-12: az1
  nebula-graphd-14: az3
  nebula-graphd-15: az2
  nebula-graphd-16: az3
  nebula-graphd-17: az1
  nebula-graphd-18: az2
  nebula-graphd-19: az3


Improve Weather App

Describe the feature/ bug
The current weather app just allows users to view weather forecast of one location at a time. I want to update the app so it will have a list of searched locations with some information in another page.
Screenshots
The list will somehow look like this.

Additional context
Here are some step I will do to develop the app:

Add new list button to navigate to the history page
Save entered city names in an ArrayList
Design history page
Pass the ArrayList to the history page when the list button is clicked
Retrieve weather information of each city and display them to the list

If you have any suggestion, please let me know!

LGTM!


[$500] IOU-App crashes when creating split bill in #announce & group chat

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.20-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
Action Performed:

Launch app / Go to https://staging.new.expensify.com/
Tap on announce room
Tap plus icon----Split bill
Enter an amount and tap next
Tap split
Tap on split bill created to open split bill details page
Note split bill button is displayed even after split bill created.
Enter all fields
Tap split bill
Note tapping on split bill app crashes in Android and does not trigger any action in mweb.

Or
1.Launch app / Go to https://staging.new.expensify.com/
2.Tap fab
3. Tap start chat
4. Select few users and create group
5. Tap plus icon----Split bill
6. Enter an amount and tap next
7. Tap split
8. Tap on split bill created to open split bill details page
9. Note split bill button is displayed even after split bill created.
10. Enter all fields
11. Tap split bill
12. Note tapping on split bill app crashes in Android and does not trigger any action in mweb
Expected Result:
In split bill details page, split bill button must not be displayed after split bill is made.
Tapping on split bill, it must be created in mweb and Android without crash.
Actual Result:
In split bill details page, split bill button is displayed even after split bill is made.
Tapping on split bill app crashes in Android and does not trigger any action in mweb.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/e4c0e618-c323-44bf-956f-78c3ea3cb10d
https://github.com/Expensify/App/assets/115492554/121cbc57-d805-44d1-85dc-b3547710ab05
https://github.com/Expensify/App/assets/115492554/60acd5f0-ad0d-49b4-8f13-3438aca5192c
https://github.com/Expensify/App/assets/115492554/043fa2cd-5e5e-4026-a2e2-048754c2b5cf
Bug6329089_1703938965276!crash.txt

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01274435e5bbe3d2d3
Upwork Job ID:<PHONE_NUMBER>628956160
Last Price Increase: 2023-12-30

Thanks! Looks like that is in review now: https://github.com/Expensify/App/issues/33786#issuecomment-1873464818

https://github.com/Expensify/App/pull/33850 is now merged. Is this fixed?
cc @gijoe0295 if you can retest

@anmurali We are good to close this


sntrup761 prime sharedKeyBytes value not correct?

I am a co-maintainer of JSch & recently I began working on integrating support for the<EMAIL_ADDRESS>KEX algorithm using Bouncy Castle's SNTRUPrime implementation.
However, I have hit a roadblock, as it appears the sntrup761 sharedKeyBytes value is defined as 16 bytes, as seen at https://github.com/bcgit/bc-java/blob/1cae5431b0f315e1c7dc40392bcd60cf785831b4/core/src/main/java/org/bouncycastle/pqc/crypto/ntruprime/SNTRUPrimeParameters.java#L13-L14
This differs from OpenSSH's implementation, which defines it as 32 bytes, as seen at https://github.com/openssh/openssh-portable/blob/8241b9c0529228b4b86d88b1a6076fb9f97e4a99/crypto_api.h#L45-L48
Is there a reason that Bouncy Castle defines the sharedKeyBytes value as 16 bytes instead of 32 bytes?
The Open Quantum Safe site seems to also define the shared secret size as 32 bytes, agreeing with OpenSSH's definition?

FYI, using the following, the<EMAIL_ADDRESS>I've authored for JSch works with OpenSSH:
  static SNTRUPrimeParameters sntrup761() {
    try {
      Constructor<SNTRUPrimeParameters> c =
          SNTRUPrimeParameters.class.getDeclaredConstructor(String.class, int.class, int.class,
              int.class, int.class, int.class, int.class, int.class, int.class);
      c.setAccessible(true);
      return c.newInstance("sntrup761", 761, 4591, 286, 1158, 1007, 1158, 1763, 32);
    } catch (Throwable t) {
      return null;
    }
  }

Originally we restricted the size of the shared secret to the strength of the security properties as while the test vectors all used 256 bit values there was no guidance around whether this was actually going to happen in the final draft.
So the rule has since come down that it's always 256 bits regardless of the security strength. We have updated NTRU already to follow this, I'll do the same for NTRUPrime.

@dghgit,
Great, thank you for the update!
Thanks,
Jeremy

I've deployed a new beta with the changes now as well - you'll find it at https://www.bouncycastle.org/betas The change is in beta 178b03 or later.

HI @dghgit,
I've tested with the 178b03 beta and can confirm it works with OpenSSH, thanks!
Thanks,
Jeremy


Add Paired end filtering

Checklist

[x] Pull request details were added to CHANGELOG.rst
[x] Documentation was updated (if needed)

Codecov Report

Merging #11 (f46f898) into develop (77c7ca9) will decrease coverage by 0.47%.
The diff coverage is 93.75%.

@@             Coverage Diff             @@
##           develop      #11      +/-   ##
===========================================
- Coverage    93.87%   93.40%   -0.48%
===========================================
  Files            1        1
  Lines           49       91      +42
===========================================
+ Hits            46       85      +39
- Misses           3        6       +3

Impacted Files
Coverage Δ

src/fastq_filter/__init__.py
93.40% <93.75%> (-0.48%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c7ca9...f46f898. Read the comment docs.


Nov 20. 2024: This week in DataFusion

Introduction

Follow on to https://github.com/apache/datafusion/issues/13265
This ticket is a weekly-ish summary of interesting things happening in DataFusion. Note this is not a complete list (it is what I remember / can find). Please feel free to leave comments on this ticket about things that I may have missed or you think should get wider attention by the community

Loosely inspired by https://this-week-in-rust.org/
Highlights

🚀   DataFusion 43 currently has the fastest results on ClickBench  (blog coming soon)
📝 Completed https://github.com/apache/datafusion/issues/12740. Thanks to @Omega359 and @jonathanc-n  for driving the project to completion
⚒ Completed  https://github.com/apache/datafusion/issues/8709 -- thanks @jcsherin @jatin510 for helping push it over the line

DataFusion Related Reading List

Comparing approaches to User Defined Functions in Apache DataFusion using Python from @timsaucer
New [Concepts, Readings, Events¶](https://datafusion.apache.org/user-guide/concepts-readings-events.html) page

Recent Releases

[x] https://github.com/apache/datafusion/issues/13166
[x] https://github.com/apache/datafusion/issues/12470 (thanks @andygrove)
[x] https://github.com/apache/datafusion-sqlparser-rs/issues/1423 (huge kudos to @iffyio for all the reviews)

Highlights from last week(s):
(I am sorry if I missed you -- please add a note to this ticket with anything you would like to highlight)
Performance

@Rachelint completed https://github.com/apache/datafusion/pull/12996 for another boost on ClickBench performance
@jonathanc-n  https://github.com/apache/datafusion/pull/13457

🐛 🔨

@findepi  fixed LIKE in various places  https://github.com/apache/datafusion/pull/13288, https://github.com/apache/datafusion/pull/13260
Also fixed https://github.com/apache/datafusion/pull/13434 and https://github.com/apache/datafusion/pull/13426
@findepi  also fixed https://github.com/apache/datafusion/pull/13388

Features

@goldmedal  added https://github.com/apache/datafusion/pull/13255
Also @goldmedal added https://github.com/apache/datafusion/pull/13341
Custom type planner (also from @goldmedal ): https://github.com/apache/datafusion/pull/13294
@jonahgao completed support for PREPARE and EXECUTE, in several PRs such as https://github.com/apache/datafusion/pull/13242 and https://github.com/apache/datafusion/pull/13311

Logical Types

@jayzhan211 is reworking signatures with https://github.com/apache/datafusion/pull/13240 and  https://github.com/apache/datafusion/pull/13354

SortMergeJoin correctness and stability fixes(@comphead):

https://github.com/apache/datafusion/pull/13369
https://github.com/apache/datafusion/pull/13398

Aggregation testing coverage

@jonathanc-n  keep improving with PR after PR

Unparser (Plan --> String)

@blaginin such as https://github.com/apache/datafusion/pull/13326
@goldmedal https://github.com/apache/datafusion/pull/13418
@Sevenannn https://github.com/apache/datafusion/pull/13428 and https://github.com/apache/datafusion/pull/13427
@phillipleblanc  in https://github.com/apache/datafusion/pull/13462

Others

@alamb  started documenting how to use multiple threadpools, see https://github.com/apache/datafusion/pull/13423

Major Projects / Discussions under way

https://github.com/apache/datafusion/issues/13504 with @timsaucer and @Omega359
#13499 to try and get delta-rs updated

Looking to get more involved? Try code review!
DataFusion has a long history of community members contributing in all aspects of the project.  Reviewing PRs is an especially great way to get introduced to the project, help the community and grow your own knowledge  -- researching and understanding the code enough to review PRs also often inspires additional ideas for improvements.
We have docs about reviews. TLDR is: look for test coverage, if the change is understandable and  well documented, and if the code can be improved.  When you think the PR looks good to merge, try @ mentioning one of the committers.
Help wanted
Please feel leave your own comments on this ticket if you are looking for help
Community

Weekly Call
Slack/Discord: info links

Upcoming meetups:

2024 Dec 18 Chicago: https://lu.ma/eq5myc5i @adriangb @timsaucer
https://github.com/apache/datafusion/discussions/12988
2025 Jan 15 Boston

Background:
Previous update:

https://github.com/apache/datafusion/issues/13167

Andrew's Focus Areas:

#12393

New blog posts:

DataFusion Blog: Comparing approaches to User Defined Functions in Apache DataFusion using Python

DataFusion Blog: Apache DataFusion Comet 0.4.0 Release

Building Databases over a Weekend  -- @ameyc  ❤  (thanks to @devanbenz for this link)

Apache DataFusion is now the fastest single node engine for querying Apache Parquet files

Great plan to improve testing:

https://github.com/apache/datafusion/issues/13470

Next week: https://github.com/apache/datafusion/issues/13630


generated C++ program for sensebox is wrong, casting problem

(at least for sensebox) a program, that tries to convert arrays/lists to strings, generates an invalid cast. The compiler complains.
This occurs, for instance, if you try to output a list of numbers to the OLED I2C display: the list is connected to the show test plug, which expects a string. This generates the wrong cast.
This s a rare error because usually only primitive types are written to the display.

This problem is also encountered with Arduino robots, in essence with robots that use library Adafruit_SSD1306.
There is no matching function signature with std::list for print functions in the lib.
An idea would be to iterate through the input list in the generated code and then call the relevant print function in the library. This way, only primitive data types are being used as inputs when calling the function.


Removed headers filter from loopbackApi

Description
For better compatibility, visibility, and ease of use headers filter are removed and will no longer be supported by scicat backend
Motivation
Couple of reasons to remove header filters as following:

Limited Visibility and Debugging: Headers are less visible than query parameters or request bodies, complicating debugging and logging.
Convention and Consistency: In RESTful APIs, headers are conventionally used for control-related metadata like content type or authentication, not for business logic like filter parameters. Using them for filters goes against standard practices.
Security Concerns: Using headers for business logic can expose APIs to overlooked security vulnerabilities.

Tests included/Docs Updated?

[ ] Included for each change/fix?
[ ] Passing? (Merge will not be approved unless this is checked)
[ ] Docs updated?
[ ] New packages used/requires npm install?
[ ] Toggle added for new features?
[ ] Requires update of SciCat backend API?

For E2E test to pass, #1328 needs to be merged

I am pretty sure our ingestors use for historical reasons the headers in many places rather than the query params. Could this change wait until all facilities have rollout the new be, or at least a couple of weeks after the JOBs migration will be over? In the end all the concerns for the moment could be overcome simply by not using the headers

I am pretty sure our ingestors use for historical reasons the headers in many places rather than the query params. Could the BE change wait until all facilities have rollout the new be, or at least a couple of weeks after the JOBs migration will be over? In the end all the concerns for the moment could be overcome simply by not using the headers. Happy, otherwise, to change the FE

Hmm, as this does not remove the header support in the backend, this change should not affect ingesters running standalone. Only if a proxy does header injection (e.g. for sec. reasons) it could affect the frontend.
I think this is a good point to discuss  for the meeting.

yes, indeed. I have nothing contrary to changing the FE, but the PR description mentions a change in the BE

A PR in the new BE removed header filter usage(in datasets, policies, and user-identities controllers).
If some facilities are still using header filters to send requests in datasets, policies and user identities endpoints, then I will make the change postponed

ah ok, thanks, I must have missed that. I support Bjorn's point, let's discuss it in the meeting if time allows


Preload accounts into merkle path for staged ledger diff application

This PR adds preloading for ledger masks, using batch operations to get merkle paths and accounts for the transactions. This lets us avoid disk IO when applying transactions.
This PR builds upon #14570.
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

!ci-build-me

!ci-nightly-me

!ci-build-me

!ci-build-me


Remove ALL templating from content server

We are working to make the site completely static and delivered from the privly-applications repo. This means we should not need any templating on privly-web.
See also: https://github.com/privly/privly-applications/issues/108

At this point we have moved enough templating that I am downgrading this to "normal". This issue is higher priority than this one as it will further decrease the importance of removing templating.

To work on this issue, you should select a page from the views directory. If the page does not need to have something like a confirmation token (which must be rendered in a template) and if the content server does not need to change the page (different countries may require different terms of service and privacy pages), then it can be ported to the pages directory of the Privly-Applications repository. I would recommend starting with the registration and confirmation pages of Devise, but others may be easier to start with.

So, you want all static pages to be hosted on privly-applications. privly-web should fetch those pages when necessary. Am I right? BTW, I am not sure about how to run privly-application so that privly-web can fetch necessary pages from it.

The public/apps/ directory on privly-web is the privly-applications repository. The server automatically serves all of privly-applications.


Some general style and issue cleanup

My IDE is still going nuts, so I figured I would address the css stuff in small chunks.
Also, setup a symlinked deployment environment. Turns out this does not work well with DIR

Yep, known limitation that DIR doesn't cope with symlinks, but Elk actually relies on it some way or another (see the one instance you didn't remove).
My dev environment is pretty similar to the one you use, but I have symlinked only sources and themes, index.php and the few files in the root are "real" files...

Well, to fix that we could just move that logic over to Settings.php
But really I just wanted to be able to run it the way I had it.

I just stripped them all from Settings.php not a long time ago based on the assumption that a settings file should just hold settings and not logic. lol

Grabbing the proper install directory is a setting in my book.
Not that it matters too much, YMMV.

Sorry, I've been a bit busy on other things.

Grabbing the proper install directory is a setting in my book.

I tried to remove any login from Settings.php, because it seemed to me cleaner. In an ideal world I think the settings file could even be a yaml file for example.
Try to guess if there is around an install directory is not really a setting, more a wild guess to be sure nothing bad could happen.
But you are right YMMV. ;)
Well, I'll merge this waiting to find out what to do with __FILE__ and __DIR__.


⚠ TROJAN 🇸🇬 Singapore SGP 1 has degraded performance

In cc574b8, TROJAN 🇸🇬 Singapore SGP 1 (https://sgt-2.opensvr.net/) experienced degraded performance:

HTTP code: 200
Response time: 21031 ms

Resolved: TROJAN 🇸🇬 Singapore SGP 1 performance has improved in 1fa7a97.


Support for inverters with non-consecutive IDs

Describe the feature
Support for non-consecutive IDs for inverters
Home Assistant (please complete the following information):

Home Assistant Core Version: 2023.7.2
solaredge-modbus-multi Version: 2.4.0-pre.4

Additional context
This feature was original requested in #56, which is now closed, as the poster moved their second inverter from 3->2.
However, I installed the new (for UK) HomeHub last week.  The installer had problems getting it working, until he called SolarEdge and was reminded that ID's 1 & 2 are reserved for masters and slaves have to start from ID 3.  Changed the slave inverter to 3 resolved the issue.  My installer recalled he'd had the same issue previously.  As such, I'm reluctant to attempt changing the ID back to 2 (even if that was possible and I knew how), and I know my installer won't.  It seems easier to provide support for custom IDs.

I decided to try and change the modbus ID of the slave inverter from 3 back to 2 and everything seems to be working fine.  So no idea why the SolarEdge support and installer both insisted it should be 3.

Modbus ID range is 1 to 247, there are no "reserved" ones.

Modbus ID range is 1 to 247, there are no "reserved" ones.

I was with the installer whilst he spoke to support, and he definitely said about the 'reservation' which is bizarre because it's clearly not true!  The weird thing is, the lead inverter couldn't detect the follower until it's ID was changed to 3.  I wonder if there's an issue with the SetApp's follower inverter detection routine, which you run as part of the initial commissioning?  Regardless, when I changed it back from 3 to 2, it carried on working.

Usually the reason people say you can't use ID 2 is because they have a meter that's on modbus ID 2 (they ship factory set for 2). Or in the case of installers they know meters come with ID 2 so they skip to 3 even if a meter isn't installed since they might come back later to add a meter when the customer wonders why they don't get consumption or E+I data. But actually the inverter leader/follower chain and the bus for meters are separate, where duplicate IDs only apply to devices on the same bus. But they're not really on the same bus so having a meter with ID 2 and a follower with ID 2 is not actually a conflict. The inverter interprets data it has from meters and batteries to modbus/tcp like a proxy.
I've never heard or read anyone saying IDs 1 and 2 are reserved for leaders, so I'm not sure where that came from. There are no reserved use purposes for any specific ID: you can have a leader on ID 45 and followers on 46, 47, etc. if you really liked those numbers instead of 1,2,3.


is it possible to change border color of cropzone?

Summary
I want to set the line color of crop zone.
https://nhn.github.io/tui.image-editor/latest/ImageEditor
there is an option , named 'borderColor' , in 'SelectionStyle'.
but I can't find any changes with it.
Screenshots

Version
3.9.0
Additional context

PR
https://github.com/nhn/tui.image-editor/pull/484

https://github.com/nhn/tui.image-editor/pull/484

The cropzone is not an feature to decorate an image like a shape or icon, but an feature that helps decorate it, so it does not apply the selectionStyle option.

The cropzone is not an feature to decorate an image like a shape or icon, but an feature that helps decorate it, so it does not apply the selectionStyle option.

How can I change the line color? , it offers only white...

@stevenencar
We are going to add an option to apply selectionStyle to cropzone's selectionStyle. Can I continue working on your PR (#484)?

@stevenencar
We are going to add an option to apply selectionStyle to cropzone's selectionStyle. Can I continue working on your PR (#484)?

@lja1018  yes,sure. and Thanks. I really need it :)

hope setSelectionStyle can use in it


ngfSelect mobile safari/touch fix

For some reason the "select file or drop" box in the demo does not open an upload photo dialogue on mobile safari.
Changing the clickAndAssign function in the ngfSelect directive from:
      function clickAndAssign(evt) {
        if (evt && evt.clientY > 0) {
          fileElem[0].click();
        }

to this:
      function clickAndAssign(evt) {
        if (evt) {
          fileElem[0].click();
        }

appears to resolve the issue. The event.clientY appears to be undefined on mobile safari.
Hope this helps...

Fixed in version 6.0.3


Release ml-wrappers 0.5.1 with OD list support

Codecov Report

Merging #148 (8a67364) into main (93bdbf8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   34.60%   34.60%
=======================================
  Files          27       27
  Lines        1812     1812
=======================================
  Hits          627      627
  Misses       1185     1185

Flag
Coverage Δ

unittests
34.60% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

python/ml_wrappers/version.py
100.00% <100.00%> (ø)


SA1008 false positive on out tuple

The following code:
var x = new Dictionary<string, (int, bool)>;
x.TryGetValue("Test", out (int, bool) value);

Triggers "SA1008: Opening parenthesis should not be preceded by a space." on the second parentheses in the second line.
Fixing it causes "SA1000: The keyword 'out' should be followed by a space."
I beleive that after the 'out' keyword there should always be a space and thus SA1008 is giving a false positive.
I am using the NuGet package v1.1.0-beta004 in Visual Studio Community 2017 15.3.3

It's possible this was already fixed as part of #2472, but I don't see a specific test case for it yet.

@sharwell Can we close this issue?


Mention graphviz in the README and check that it's installed when requiring it.

Fixes https://github.com/kddnewton/regular_expression/issues/23

@kddnewton - gonna keep CCing you on small changes as I merge them.

Can't figure out how to approve on my phone but 👍


Trait for finding Points in Frustum

Currently, implementation of Frustum has method for finding the spatial relation of a bound inside this frustum, but not for finding the points.
Is this intentional?

Probably just an oversight, this was created before I joined the project.

@Rhuagh Shall I send a PR for that?

Absolutely, if you have time to do so, we love PRs :)


Restore doesn't pass caller's auth credentials to pachd

Currently, if a cluster enables auth, Extract/Restore stops working because Restore makes internal RPCs but doesn't propagate the caller's auth information

When we make this change along with #3012, we should probably extract/restore the activation token as well. This stops users from having to call activate again, but also stops users who abuse enterprise trial tokens with multiple email addresses from just extract/restoring their cluster easily.


fix(overlay): raise z-index for overlay-container

R: @kara
This will help prevent the overlay container from being covered up by other stacking contexts that are directly on the document body.
(of course there's always a higher z-index...)

I hope this is not a replacement for https://github.com/angular/material2/pull/1584#issuecomment-255947612
Otherwise good luck this that https://github.com/search?utf8=✓&q="z-index%3A+9999"&type=Code&ref=searchresults ..

Not a replacement, but should generally make things better. Though, I still don't want to remove this z-index in #1584 because it's important that the overlay container always create a new stacking context.

Read the comment. I agree, I proposed moving the custom class from pane to container as well as changing z-indexes similar to what you just did.


Missing model weights

Hello,
I was going through the repository and tried accessing the model weights from the Google Drive link provided in the README, but it seems the files are missing. Could you please provide an alternate link?
Thanks for your help
Best regards,
Shashwath P

Thank you for your interest. BrainGPT is fine-tuned from OTTER-MPT7B-Init, and thus the checkpoint follows its form (.bin). You can find the config file and PyTorch models on the google drive.
Furthermore, we have uploaded the model to hugging face (Charliebear/BrainGPT), which should be easier to download. Please put both model folders of the base model and the fine-tuned model in the ./checkpoint folder


How to compile the bc of the entire program into an executable program？

Sorry but this is not an issue.


Order candidates according to their frequency

Fixes #10

Current coverage is 92.13% (diff: 100%)

Merging #18 into master will not change coverage

@@             master        #18   diff @@
==========================================
  Files            12         12
  Lines           572        572
  Methods           0          0
  Messages          0          0
  Branches         91         92     +1
==========================================
  Hits            527        527
  Misses           25         25
  Partials         20         20

Diff Coverage
File Path

•••••••••• 100%
eli5/sklearn/unhashing.py

Powered by Codecov. Last update 553cdfd...8ee5550


Find: Highlight selected nodes

Initial Implementation
Find on graph selected via Gremlin Expression sub-graph and highlight it.

I have issue with cleaning old selection before running a new one - I will fix it and upload once again.

The issue was resolved and I have fixed also everything to "highlight"
Now user should not use the suffix "SubGraph()" in both filter and highlight requests and the selection is done on the flight (changing state of the graph every time the user types ")")


Modal docs should pass object to modal.set function instead of deprecated name/value pair

The Modal documentation page use the depracted way for setting properties on a Modal instance.
Instead of :
modal.set('minimized', true)
We have to do this :
modal.set({
    minimized: true
  })

Second potential issue, with the new 0.6.0 release, passing
.set({
 'selfDestroy': false
 })

to the modal instance disables all click events on the document.

Well, I think I found where is the problem : when closing the Modal without destroying it, we should disable the "backdrop" (i.e enable again the clicks in the body area)

Aaah, you are right. Will make a patch shortly and release v0.6.1. Thanks!

Meanwhile updated doc.

Hmm, cannot reproduce. Also checked the code and everything seems to be ok.

So what I'm doing is creating a button which triggers toggleModal() from below.
export default {
  compiled () {
    this.modal = Modal.create({
      template: 'Modal will close shortly'
    }).set({
      selfDestroy: false,
      minimized: true
    })
  },
  beforeDestroy () {
    this.modal.destroy()
  },
  methods: {
    toggleModal () {
      this.modal.show()
      setTimeout(() => {
        this.modal.close()
      }, 2000)
    }
  }
}

You could have a Javascript error thrown which breaks the JS flow so Quasar can't do its job properly closing the Modal... Otherwise I don't see how this can happen. Keep me posted please.

It's OK, no bug, I kept my old code that was creating a new Modal on each click. You can close it.


TypeError: Cannot read properties of undefined (reading 'size')

Hey, I don't think this is a duplicate of #30 but I might be wrong...
I'm running this command:
npx tolgee --api-key "$PUBLIC_TOLGEE_API_KEY" compare '[GLOB]'
And I see this error:
🐭✅     Analyzing code...
🔴 An unexpected error occurred while running the command.
🔴 Please report this to our issue tracker: https://github.com/tolgee/tolgee-cli/issues
TypeError: Cannot read properties of undefined (reading 'size')
    at compareKeys (/workdir/node_modules/@tolgee/cli/dist/commands/sync/syncUtils.js:52:30)
    at Command.compareHandler (/workdir/node_modules/@tolgee/cli/dist/commands/sync/compare.js:19:46)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Command.parseAsync (/workdir/node_modules/commander/lib/command.js:935:5)
    at async run (/workdir/node_modules/@tolgee/cli/dist/index.js:136:9)

I'm running this inside a docker image and I haven't installed the CLI tool globally (so I'm using npx).
Thanks!

Does your project only contain namespaced keys? If so, then it is the same issue as #30

So I don't think it's a duplicate? I haven't set any namespaces, are the keys namespaced by default?
All my translations look like this: {$t("about.title")}

The title is all I have to go on really. When I try to run the command I get that traceback, I don't know enough about your code to know the true nature of the bug, sorry :(

I meant of #30, not yours no worries :D
The stack trace looks the exact same of the one as the one fixed by #31; so I'm unsure if it is another bug, or the same bug. That being said, that $t is making me wonder: did you alias the t function? The CLI expects the naming schemes to be left intact (useTranslate, t, ...) and doesn't track renames. I believe this would trip the problematic code path and raise this error.

I meant of https://github.com/tolgee/tolgee-cli/issues/30, not yours no worries :D
Oh I see!

I'm using SvelteKit and I think this is how I'm supposed to do it?
<script>
    import { getTranslate } from '@tolgee/svelte';
    const { t } = getTranslate();
</script>
<h1>{$t("about.title")}</h1>

Ah, unfortunately the extraction for now only supports the React SDK (as documented here), so you won't be able to benefit from the code extraction yet.

But... You can create the extractor for Svelte. PRs are welcomed! 🤩

Ah! Silly me! Should have RTFM :)
I'll investigate what would be needed for a SvelteKit extractor tomorrow. I'm also going to be looking at how to do server side generated pages (if you have any pointers?)

I'll investigate what would be needed for a SvelteKit extractor tomorrow.

The current state of the extractor is a bit of a pain to extend, if you have any questions on that (CLI internals, etc) that aren't answered by the HACKING.md, feel free to ping me on the Tolgee community Slack and I'll be able to help 👍🏻

Hey, if you provide the static data before the page is generate / build, it works. You can check how it works in Next.js. Unfortunately, SvelteKit has no similar support for localized routing, which we are waiting for to update the docs properly.
You basically have to do it manualy. But it's possible. You can also ping me in Slack community. 😎


Removed arrow functions for fixtures

Mocha recommends avoiding arrow functions since you will lose access to this for actions like this.timeout(10). Even if these are just fixtures for testing, I think it is preferable to setup your testing to reflect how potential users will most likely be using the system.
If you have a reason for this, please feel free to close and ignore.

@aray12 awesome, thanks! Sorry I didn't see this for two days, for some reason I've not been subscribed to notifications!


Test

Docs Build status updates of commit 249f480:
:warning: Validation status: warnings

File
Status
Preview URL
Details

.openpublishing.redirection.json
:warning:Warning

Details

redirect-url/source.md
:warning:Warning
View
Details

redirect-url/target.md
:warning:Warning
View
Details

.openpublishing.redirection.json

Line 5, Column 47: [Warning: redirection-path-syntax-error] Redirection path syntax is incorrect. 'source_path' should start without '/' and 'source_path_from_root' should start with '/'.

redirect-url/source.md

Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 0, Column 0: [Suggestion: toc-missing] Article is not referenced from a table of contents. Every article must be in a TOC.

redirect-url/target.md

Line 1, Column 1: [Warning: title-missing - See documentation] Missing required attribute: 'title'. Add a title string to show in search engine results.
Line 1, Column 1: [Warning: author-missing - See documentation] Missing required attribute: 'author'. Add the current author's GitHub ID.
Line 0, Column 0: [Suggestion: toc-missing] Article is not referenced from a table of contents. Every article must be in a TOC.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


update hmax requirements.txt

add numpy, torch, and scipy to requirements.txt

God merged for competition


Assets paths are not rewritted

I want to use  and I'm using assets webpacking.
<amp-img
  alt="Case study"
  width="779"
  height="620"
  src="~assets/images/case-study-image-1.png'"
  layout="responsive"
>

But when I compile it src path stays same and not be rewritted to /_nuxt/something...
Any ideas why?

It's because amp-img is not a Vue component and it treats src as a single string attribute.
Right now the only way to load an asset is using require
<template>
<amp-img
  alt="Case study"
  width="779"
  height="620"
  :src="image"
  layout="responsive"
>
</template>
<script>
export default {
	data() {
		return {
			image: require('~assets/images/case-study-image-1.png'),
		}
	}
}
</script>

Okey thanks, since I have more images I put it right into :src also you have to use ~/assets not just ~assets. But it works.


GraphQL doesn't work properly with turbopack

Link to reproduction
No response
Payload Version
beta.36
Node Version
v20.11.1
Next.js Version
15.0.0-rc.0
Describe the Bug
When running NextJS like it's configured in this demo repo, and run it with turbopack by adding turbo to the dev script in package.json, I get a conflict error when making a request to GraphQL.
Note that without the --turbo flag it works. I initially came across this error by using Next 14 with React 18, because I wanted to integrate this in my current project, so the issue also applies to these versions. It applies to both mongodb and postgres adapters.
Reproduction Steps

Clone https://github.com/payloadcms/payload-3.0-demo
Copy .env.example to .env
Run start-database.sh
Change the dev command in package.json to "cross-env NODE_OPTIONS=--no-deprecation next dev --turbo"
Open http://localhost:3000/api/graphql-playground
Execute the following query:

query GetTopics {
  Users(page: 1) {
    docs {
      email
    }
  }
}

Receive the error:

"Cannot use GraphQLScalarType \"Int\" from another module or realm.\n\nEnsure that there is only one instance of \"graphql\" in the node_modules\ndirectory. If different versions of \"graphql\" are the dependencies of other\nrelied on modules, use \"resolutions\" to ensure only one version is installed.\n\nhttps://yarnpkg.com/en/docs/selective-version-resolutions\n\nDuplicate \"graphql\" modules cannot be used at the same time since different\nversions may have different capabilities and behavior. The data from one\nversion used in the function from another could produce confusing and\nspurious results."

where I would expect to receive a Forbidden 403 gql error. I've also tried this with custom collections where a set the access:read to open, same result

When I omit the parameters (page: 1), It works

query GetTopics {
  Users {
  	docs {
      email
    }
  }
}

Adapters and Plugins
db-mongodb, db-postgres

happens here as well. same versions.
i dont use --turbo. just "next dev"
Cannot use GraphQLScalarType "String" from another module or realm.\n\nEnsure that there is only one instance of "graphql" in the node_modules\ndirectory. If different versions of "graphql" are the dependencies of other\nrelied on modules, use "resolutions" to ensure only one version is installed.\n\nhttps://yarnpkg.com/en/docs/selective-version-resolutions\n\nDuplicate "graphql" modules cannot be used at the same time since different\nversions may have different capabilities and behavior. The data from one\nversion used in the function from another could produce confusing and\nspurious results.

This is also present for me, it appears that every request using variables fails. Using dependencies:
{
  "payload": "3.0.0-beta.60",
  "next": "15.0.0-canary.64",
  "graphql": "^16.9.0"
}

Setting resolutions/overrides does not solve the issue. Switching back to webpack does fix it of course.

@AlessioGr can you check to see if this is still not working on our latest release?

Still getting this on 3.0.0-beta.116 with a similar query (using limit on any collection), same situation with pnpm.resolutions.


ts3 filename fix

not sure if need that merge remote..

Dude, i already pulled that https://github.com/dgibbs64/linuxgsm/commit/d59bd57d44e820b355b4280756213b2a3962ba01

you forgot to change the rm filename with it

I still have issues updating a freshly updated server. There will be something more to check, watch this out :
https://github.com/dgibbs64/linuxgsm/issues/672

yes ignore this then. also, on 32-bit OS the script keeps trying to install lib32gcc1... which doesn't exist in 32bit OS. fyi

/ts3server start
[ WARN ] Starting ts3-server: Checking dependencies: Dependency missing: lib32gcc1
[ INFO ] Starting ts3-server: Attempting to install missing dependencies automatically
sudo dpkg --add-architecture i386; sudo apt-get install lib32gcc1

No problem mate, you tried ! Maybe update your repo before next time :p
I'm not done yet either btw !

Please add a bug issue for.

yes ignore this then. also, on 32-bit OS the script keeps trying to install lib32gcc1... which doesn't exist in 32bit OS. fyi
/ts3server start
[ WARN ] Starting ts3-server: Checking dependencies: Dependency missing: lib32gcc1
[ INFO ] Starting ts3-server: Attempting to install missing dependencies automatically
sudo dpkg --add-architecture i386; sudo apt-get install lib32gcc1

Done :)


Tank images not showing (unauthorized error)

Hi,
I installed the node in a Node-RED instance running on Docker. When editing the node, I get an unauthorized error when it tries to retrieve the tank images:

I inspected the node directory inside docker and the images permissions (at file system level) and everyone is allowed to read. I see nothing strange in the Node-RED settings. The only thing I changes in the settings (from default) is exposing the admin page in the "/admin" path and the dashboard in the root path "/" of my domain.
What do I have to look for to solve this?

Hey @mereshow,
Thanks for the clear description of the issue!
I was a bit surprised that it didn't work for you, so I have asked this question in the Node-RED forum.
Could you please check whether the proposed solution works:

Find your .../.node-red/node_modules/node-red-contrib-tank-volume/tank_volume.js file

At the bottom of that file remove the red underlined part:

Save that file and restart Node-RED

Hopefully it now works ...

Bart

Hey @mereshow,
Thanks for the clear description of the issue! I was a bit surprised that it didn't work for you, so I have asked this question in the Node-RED forum. Could you please check whether the proposed solution works:

Find your .../.node-red/node_modules/node-red-contrib-tank-volume/tank_volume.js file
At the bottom of that file remove the red underlined part:

Save that file and restart Node-RED
Hopefully it now works ...

Bart

That solves it! After changing the line and restarting the container the tank image is shown:

Thank you for the help and this node :+1:

@mereshow,
Thanks for the feedback!
The fix is now available in the pallette as version 1.0.1:


Internal error for POST entity API with all columns as defaults

When a POST request is generated where all the columns of the table are included in the defaults list, a 500 internal server error is returned.

I refreshed myself on this topic and I don't think there really is any appropriate solution to accept N rows of input and ask for all columns to be populated by default values. This is a SQL limitation I don't want to try to work around in the service logic.
So, I think I'm just going to fix the server to raise a 409 Conflict if the request includes all columns of the schema in the defaults list (rather than an internal server error).

This is in master as https://github.com/informatics-isi-edu/ermrest/commit/67d366281498f5fb919c81974cc11aea99913def  with a basic test case.
@jrchudy if you can easily reproduce in your test environment, please do. But if not, I think this test case already covers the reported issue and we can just close this...


Standard sideBySide enabled

Maybe it's cool/nice to be able to initialize the MDE with the preview open.
That would be so great to me.

This is possible:
const editor = new EasyMDE();
EasyMDE.togglePreview(editor);

Yes this sure works great!
Maybe I was a bit wrong with the given information. I want the side by side open on start.
Is this also possible?


Sphere method location is off.

@jcheong0428 want to submit a pull request to fix this?

fixed by @jcheong0428 in #85


HRES intermediate solution

To make progress in HRES calculation for GNSS we will divide the earth into multiple segments that can be loaded in memory.
[x] - @jlmaurer: Update the loading module to read based on bbox only.
[x] - @jlmaurer: Load HRES file into RAIDER to compute delays; use the gridding option to determine allowable chunk size.
[x] @sssangha: Based on chunk size split the GNSS "global list" into different segments. Verify if the unique (union) of all the "split station files" has the same number of stations as the original "world file"
[in progress] - @dbekaert  Compute for each "individual station file" the RAiDER delays.
[x] - @jlmaurer/ @dbekaert  Have a small program that takes the union of all the csv files per intermediate files. Verify is this program can be modified to run union of intermediate files and then union of regions; followed by intersection of the GNSS file

@sssangha @jlmaurer i updated the comment above on the progress. First two items were closed under #239

@sssangha @jlmaurer i updated the comment above on the progress. First two items were closed under #239

@dbekaert @jlmaurer within the attached zip file are 4 files corresponding to the 4 zones within which I split up the global list of stations.
I decided to decimate by longitude, i.e. split -180 to 180 longitude into 4 long strips. The distribution between the four files is more-or-less consistent -- aside for "zone D" corresponding to Lon 90-180, which is relatively sparse.
Please let me know if you have any questions/concerns.
split_zones.zip

@dbekaert @jlmaurer within the attached zip file are 4 files corresponding to the 4 zones within which I split up the global list of stations.
I decided to decimate by longitude, i.e. split -180 to 180 longitude into 4 long strips. The distribution between the four files is more-or-less consistent -- aside for "zone D" corresponding to Lon 90-180, which is relatively sparse.
Please let me know if you have any questions/concerns.
split_zones.zip

See issue related in #241 and #242

@sssangha i confirm this is working with he provided chunksizes.

@sssangha @jlmaurer im adding issue #251 to this as it would impact how fast we can make progress with our intermediate solution.

I think this can be closed now.


How do i enable intents for the bot ?

i still have issues with this bot....i did what it needed but when its about intents i cant find how to enable them ... can you help me?

@Madalin-Vis you can enable them at discord.com/developers under the token.

ok ..but i dont see a button to activate them......

@Madalin-Vis

i dont have that

@Madalin-Vis look closer.


COUNTEREXAMPLE: Numerically test finite field magmas with linear operations

See https://leanprover.zulipchat.com/#narrow/stream/458659-Equational/topic/An.20old.20new.20idea for discussion.  Loop over small finite fields F (e.g., of prime order p), and coefficients a and b in F, and consider magma operations on F of the form x ◇ y = a * x + b * y.  Then all word maps are just linear forms in the variables (with coefficients computable in terms of a, b) and it will be easy to check which equations are satisfied by these examples.  Use this to create new anti-implications (for instance, this method shows that 1286 does not imply 3).

#349 is one successful instance of using this method

claim

It looks like #380 may have completed the implications that can be shown with finite linear magmas up to Z/200Z. I will double check this tomorrow.

propose PR #416

This makes sense to me.  There are only so many primes that can divide a discriminant or resolvent, and the Chebotarev density theorem tells us (especially if we assume GRH) that polynomials will split completely over many small finite fields, so I would expect with our low degree, small coefficient examples that all constructions will be detected in a finite field of order up to 200.  I guess we could try to prove a rigorous upper bound here to completely settle the matter from a theoretical standpoint; will make an issue about this.


diesel

Setup
Versions

Rust:
Diesel:
Database:
Operating System

Feature Flags

diesel:

Problem Description
What are you trying to accomplish?
What is the expected output?
What is the actual output?
Are you seeing any additional errors?
Steps to reproduce

Checklist

[ ] I have already looked over the issue tracker and the discussion forum for similar possible closed issues.

[ ] This issue can be reproduced on Rust's stable channel. (Your issue will be
closed if this is not the case)
[ ] This issue can be reproduced without requiring a third party crate

Closed (looks like some bot created an empty issue)


fix(sync-signal): fix syncDone signal initialization

Description
The signal was shared in the RetryNotify loop and since it was never reset the next time we reconnected with Central it was already triggered.
Checklist

[ ] Investigated and inspected CI test results
~[ ] Unit test and regression tests added~
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change

[ ] Manual test with local-sensor.

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/retest


Intellisense support for ERB files?

Hi all,
I've noticed that my intellisense works for my TSX files but can't seem to make it work for my ERB files. I've tried including this in my user settings:
"windicss.includedLanguages": {
  "erb": "html" // I've also tried using "*.html.erb" and "html.erb"
}

Am I using this configuration incorrectly? Thanks in advance!

@angelocordon erb are ruby files?
Then I think you should use the language identifier ruby.
"windicss.includedLanguages": {
  "ruby": "html"
}

If you need custom pattern, you can also use more advanced configuration, described in the readme.
https://github.com/windicss/windicss-intellisense/blob/c0e057e4ac21b4f71cd0f7c7be006d6492cca5ea/README.md#L103-L112

Thanks for the input here @alexanderniebuhr  - sorry for the delayed reply. I'm not sure how this works all of the sudden, but somehow it started working today. I'm not positive what happened in between, but upon some short investigation I've found this setting works but not the windicss.includeLanguages key:
{
   "file.associations": {
        ".html.erb": "html"
    }
}

☝🏽 This was taken from the Tailwind Intellisense config and I made sure that I do not have that extension installed.
In any case, feel free to close this issue? Thanks so much!

use latest release v0.21.3 and the following config and it should allow autocompletion.
"windicss.includeLanguages": {
    "ruby": {
        "type":"html",
        "patterns": [
            "(\\s*class\\s*=\\>\\s*{?\\s*[\"'`])[^\"'`]*$"
        ]
    }
}


Support AudioTrack.setVolume for react-native

Ah yeah, good point. No equivalent getVolume method, but I think it defaults to 1 anyways.


2 Elements using the same ID

Chrome Warning:
[DOM] Found 2 elements with non-unique id #bloghubCommentSection6368b0bd2e5b6_username: (More info: https://goo.gl/9p2vKq)
<input id="bloghubCommentSection6368b0bd2e5b6_username" type="text" name="comment_name" value="Sam" placeholder="Your Username" class="form-control" readonly>
<input id="bloghubCommentSection6368b0bd2e5b6_username" type="text" name="comment_user" autocomplete="off" value placeholder="Your Username" class="form-control from-control-bloghub-special-assignment">

Fixed in current master branch.

Fixed in v1.3.3 (Version has been pushed to Octobers Marketplace).


Update azidentity samples to post-GA versions

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] MIT license headers are included in each file.

/check-enforcer override


Adds eslint-config-cesium

This PR swaps the custom ESLint configuration currently in use with eslint-config-cesium/node, along with a few options. This will make sure this repository is consistent with the style used across all the other organization JS repositories.

Looks good, thanks @sanjeetsuhag !


Wip typescript subscription

SonarQube analysis reported 10 issues

 1 major
 9 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 9 issues

 9 minor

Watch the comments in this conversation to review them.

SonarQube analysis reported 8 issues

 8 minor

Watch the comments in this conversation to review them.


Fix transform styles on initial mount.

Transforms were not being applied on initial mount because __getValue is returning transform in array style rather than string format.
Created another injectable for web based to run through mapStyles on each render.

Thanks for reviewing @vjeux


codecov

Signed-off-by: Sertac Ozercan<EMAIL_ADDRESS>this PR does / why we need it:
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #
Special notes for your reviewer:

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@69fbaa4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #6   +/-   ##
=========================================
  Coverage          ?   44.41%
=========================================
  Files             ?       48
  Lines             ?     3931
  Branches          ?        0
=========================================
  Hits              ?     1746
  Misses            ?     1967
  Partials          ?      218

Flag
Coverage Δ

#unittests
44.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69fbaa4...0c9af19. Read the comment docs.


How to use Build.SourceVersionAuthor?

I need to conditionalise the build based on whether it is a pull-request from a branch name with a specific name submitted by a specific author.
I able to express the first two conditions but I can't figure out the last one.
These work
variables:
  - name: A_IsPullRequest
    value: ${{ eq(variables['Build.Reason'], 'PullRequest') }}
  - name: A_PullRequestSourceBranch
    value: $[ variables['System.PullRequest.SourceBranch'] ]
  - name: A_IsDarcPullRequestSourceBranch
    value: $[ startsWith(variables['System.PullRequest.SourceBranch'], 'darc-main-') ]

  - name: A_SourceVersionAuthor
    value: $(Build.SourceVersionAuthor)

I can use $(Build.SourceVersionAuthor), however, more matter what I do I can't figure out how to apply a condition to it. E.g., none of these work:
variables:
  # These are unset
  - name: A_SourceVersionAuthor2
    value: $[ variables['Build.SourceVersionAuthor'] ]
  - name: A_SourceVersionAuthor3
    value: ${{ variables['Build.SourceVersionAuthor'] }}

  # These are false
  - name: A_IsMaestroAuthor1
    value: ${{ eq(variables['Build.SourceVersionAuthor'], 'dotnet-maestro[bot]') }}
  - name: A_IsMaestroAuthor3
    value: ${{ eq('$(Build.SourceVersionAuthor)', 'dotnet-maestro[bot]') }}
  - name: A_IsMaestroAuthor4
    value: $[ eq(variables['Build.SourceVersionAuthor'], 'dotnet-maestro[bot]') ]
  - name: A_IsMaestroAuthor5
    value: $[ eq('$(Build.SourceVersionAuthor)', 'dotnet-maestro[bot]') ]

I can evaluate the whole thing using a script task, but it feels lame...
- pwsh: |
      function Export { param($i); Write-Host "$i"; Write-Host "##$i" }

      $isPullRequest = '${{ eq(variables['Build.Reason'], 'PullRequest') }}';
      $sourceBranchName = "$($env:SYSTEM_PULLREQUEST_SOURCEBRANCH)";
      $sourceBranchAuthor = "$($env:BUILD_SOURCEVERSIONAUTHOR)";
      $isMaestroBuild = $isPullRequest -and $sourceBranchName.StartsWith('darc-main-') -and ($sourceBranchAuthor -eq 'dotnet-maestro[bot]')
      Export "vso[task.setvariable variable=isMaestroBuild]$isMaestroBuild"

Hi @RussKie, Please post your question on the Developer Community to get the right eyes on it, since this repo is mostly for questions about templates located in this repo.

Thank you @max-zaytsev. That's a bummer really, I hoped I could craft my pipeline a bit more declaratively.
It'd be great to have this documented in https://learn.microsoft.com/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml#build-variables-devops-services too.
Thanks again.

Thank you @RussKie
Yes, I agree. It’s quite difficult to find this information in the documentation.
I actually found this statement on the Template types & usage page page.

Only predefined variables can be used in template expressions.

Since Build.SourceVersionAuthor is not in the list of predefined variables it is an indication that it can’t be used in such expressions.
I couldn't find the information about predefined variables on the Expressions page too. I wish there was some mention of this as well.
I will close this ticket as this issue does not match the current repository and will create an issue in the appropriate repo in order to update the documentation accordingly.
Please let me know if I can help with anything else here.
Thank you!


[Chore] setup.py

Hi,
Could you provide a setup.py please?
https://packaging.python.org/tutorials/packaging-projects/#creating-setup-py

Created a setup.py for packaging

Nice thanks but it lacks of an entry point https://python-packaging.readthedocs.io/en/latest/command-line-scripts.html


Create plan wizard provides all funder templates, no default template

This bug seems related to issue #1470
When I select a funder for question 3 in the create plan wizard I get a dropdown containing all funder templates regardless of my selection (screenshot 1). there is no association between funder and template.
if i check the boxes for no Org and no Funder for questions 2 and 3 I get the error in screenshot 2. it can't find the default template
if my Org has templates then I do get those when I make the appropriate selection. However if I try to Write plan I get the error in screenshot 3 (same missing template error from #1470)

I can get the default template now, but I still see the full list of funder template in a dropdown regardless of which funder I select @briri

This all seems to be working fine now. Closing out


Replace try/catch/rethrow in unwind with unwind_guard

I noticed while investigating https://github.com/microsoft/cppgraphqlgen/issues/222 that parse_tree implements unwind on the make_control<>::state_handler<> struct, and this results in creating a try/catch/rethrow block around every rule match in match_control_unwind. Every try/catch/rethrow seems to be consuming significant stack space, so if you raise/throw an exception from a relatively shallow (< 20) nested rule, it often exhausts the stack.
This change makes it so parse_tree will only implement unwind on the Control type wrapper if either the Control or the Node type implements it. When parsing into a tree that doesn't implement either of them, the exception will be thrown once all the way from the initial raise to the caller of parse_tree::parse.
Since the unit tests use the default node which inherits basic_node, they still implement unwind. The unit tests also wrap the rule in a try_catch_type handler, though, so the exception doesn't bubble all the way up. Before I nailed down the constexpr bool definitions, I accidentally suppressed unwind for basic_node types in the unit tests as well, and the lack of stack.pop_back() calls resulted in the assert(stack.size() == 1) firing for the unit test. So that tells me this is incompatible with try_catch_type. That's the only thing I think might block it.

As you noticed, skipping the unwind() makes the assert(stack.size() == 1) fire. Conceptually, the state.pop_back() is necessary for the parse tree to work correctly, it can't just be skipped. In its current form, we therefore can not accept this PR.
However, you do have a point here, all those try/catch-blocks are something to look into and they do provide an optimization opportunity. So, what could be done? I can see some potential by checking if a grammar rule (including all reachable sub-rules) can throw an exception. This could be used to skip unwind properly. I'll see if I can come up with something.

Yeah, partly this change is predicated on letting the exception out to the caller, in which case you don't need to unwind because the stack will just be deleted and the assert is never reached. But to rely on that, you need to know that there won't be any other catch blocks that turn an exception into a regular return, like try_catch_type.
What I'm probably going to do for my own project is copy enough of the parse_tree implementation to implement a non-unwinding version. My grammar and custom ast_node implementation don't require any try_catch_type handling or per-frame unwinding, and it made a pretty dramatic difference in how far I could get without overflowing. Originally it overflowed at a depth of 18 or so, only when throwing an exception from an if_must rule. Now it can successfully throw an exception without overflowing the stack from a depth of at least 100 (I stopped at that point, I'm also going to add a depth limit since it can't remain completely unbounded).

Maybe it would be better to define an RAII unwind_guard which will pop the stack in its destructor. You'd then need to disarm it in case an exception is not thrown and you don't want to pop the stack, but then you wouldn't need an explicit try/catch block, it could just perform regular stack unwinding.

Here you go, how about something like this?

Codecov Report

Merging #309 (d0c5101) into main (e3c8cb4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   99.68%   99.68%
=======================================
  Files         253      253
  Lines        5083     5090    +7
=======================================
+ Hits         5067     5074    +7
  Misses         16       16

Impacted Files
Coverage Δ

include/tao/pegtl/contrib/parse_tree.hpp
100.00% <100.00%> (ø)

include/tao/pegtl/match.hpp
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c8cb4...d0c5101. Read the comment docs.

I like the idea about the unwind_guard, but it seems independent of the rest, so I'd like to see this as a separate PR.
Also, I would like to get some idea of how it improves code on all major compilers (GCC, Clang, and MSVC), as we don't want to improve code on one compiler on the expense of others. I ran some small checks with GCC so far and sometimes the binaries became larger, sometimes they became smaller.
Minor detail: The capture list can be shortened to just [&] instead of [&in, &st...].

One more thing that I should probably mention: We don't want to check the code with Debug mode, as the PEGTL is heavily templated and relies on the optimizer to generate reasonable code. Anything compiled without optimizations is best effort, at best. We should probably also put this in the documentation in the "Requirements" section. @ColinH Would you like to formulate something?

One more thing that I should probably mention: We don't want to check the code with Debug mode, as the PEGTL is heavily templated and relies on the optimizer to generate reasonable code. Anything compiled without optimizations is best effort, at best. We should probably also put this in the documentation in the "Requirements" section. @ColinH Would you like to formulate something?

FWIW, the same stack overflow occurs in release builds using MSVC (VS2022) on my machine. I don't think the release optimizations can save it from this particular issue.

I like the idea about the unwind_guard, but it seems independent of the rest, so I'd like to see this as a separate PR.

OK, will do.

Also, I would like to get some idea of how it improves code on all major compilers (GCC, Clang, and MSVC), as we don't want to improve code on one compiler on the expense of others. I ran some small checks with GCC so far and sometimes the binaries became larger, sometimes they became smaller. With Clang, there was a lot more overhead and most binaries grew in size.

Would you prefer an #ifdef for MSVC? I think the stack overflow I'm trying to mitigate is likely specific to the code that compiler generates for catching and rethrowing exceptions.

Minor details: The capture list can be shortened to just [&] instead of [&in, &st...] and the <functional> include should be <utility>.

OK. 👍🏼

What I'm probably going to do for my own project is copy enough of the parse_tree implementation to implement a non-unwinding version. My grammar and custom ast_node implementation don't require any try_catch_type handling or per-frame unwinding, and it made a pretty dramatic difference in how far I could get without overflowing. Originally it overflowed at a depth of 18 or so, only when throwing an exception from an if_must rule. Now it can successfully throw an exception without overflowing the stack from a depth of at least 100 (I stopped at that point, I'm also going to add a depth limit since it can't remain completely unbounded).

I have a configurable depth limit and a prototype of a custom parse_tree fork now, but I'm going to abandon the custom implementation of parse_tree in favor of this PR. I'd rather not diverge like that from PEGTL.

@d-frey Can we merge this as is?

I think we already talked about this, especially benchmarks. Are we sure this PR would not introduce drawbacks for GCC/Clang?

I think we already talked about this, especially benchmarks. Are we sure this PR would not introduce drawbacks for GCC/Clang?

I've been playing around with it on Compiler Explorer, and with -O2 it seems to slightly shrink the code for GCC (12 lines of assembly vs. 10 lines), and it grows the code by about 58% for Clang (31 lines of assembly vs. 49 lines). It's definitely an improvement for MSVC at runtime just by not causing a stack overflow, no matter what the size difference might be. Overall, I'd argue it's a wash between GCC and Clang (which seems to generate a lot more code than GCC to begin with).
N.B. A side benefit of #313 is that it'll remove this code in parse_tree entirely in cases where a Node::unwind declaration is omitted.

Here's one findings after finally playing around with this for a bit, on a Mac with M1 Max running Monterey.
With a slightly modified json_parse example that adds a couple of unwind() functions to the control, both compilers produce identical binaries, no difference between try-catch and unwind_guard.
So, at least for Clang and GCC, it doesn't seem to matter, since, at least in this simple case, the optimisers sees right through the supposed "difference".
PS: On this platform Clang consistently produced much smaller binaries than GCC 11.

Thanks Colin for testing. @wravery Can you update this PR so I can merge it? Thanks!

I merged it manually, I'll do a release of the 3.x branch shortly.


Timeline parsing

Until we can get this building in the release pipeline we should hold off merging this with master


Number pattern program

Can you assign me this issue?

sure 👍

@fms12 Do I need to add 1 or more than 1 program related to the alphabet pattern ?

Do you want to add a number pattern or an alphabet pattern?

Do you want to add a number pattern or an alphabet pattern?

Yeah actually Number pattern .
By mistake I wrote alphabet .

ok, add it to the pattern folder as Patter "serial no" with proper comments