cmd/go, crypto/x509: go mod tidy reports certificate expired on a non-expired certificate

What version of Go are you using (go version)?

$ go version
go version go1.20.5 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/yorick/.cache/go-build"
GOENV="/home/yorick/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/yorick/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/yorick/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.20.5"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/yorick/Development/dss/udptogrpc/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build1398362822=/tmp/go-build -gno-record-gcc-switches"

What did you do?

When running go mod tidy with an import from a local GitLab instance with a non-expired certificate it is reported as expired.
package main

import (
	"localgitlabinstance/package"
)

func main() {
	package.Function()
}

The snippet above illustrates the basic setup used. When running go mod tidy it returns the following output:
go mod tidy Output
server response: not found<EMAIL_ADDRESS>unrecognized import path "localgitlabinstance/package": https fetch: Get "localgitlabinstance/package?go-get=1": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2023-06-07T08:48:08Z is after 2013-07-26T11:03:57Z

When checking the certificate via Chrome and by using echo | openssl s_client -showcerts -servername localgitlabinstance -connect localgitlabinstance:443 2>/dev/null | openssl x509 -inform pem -noout -text the certificate is valid from:
Validity
  Not Before: Jan 16 00:00:00 2023 GMT
  Not After : Jan 18 23:59:59 2024 GMT

When changing my system time to before 2013-07-26T11:03:57Z I get the following output:
go mod tidy Output
localgitlabinstance/package: cannot find module providing package localgitlabinstance/package: unrecognized import path "localgitlabinstance/package": https fetch: Get "localgitlabinstance/package?go-get=1": tls: failed to verify certificate: x509: certificate has expired or is not yet valid: current time 2013-06-01T00:01:16+02:00 is before 2023-01-16T00:00:00Z

It then successfully retrieves the Not Before timestamp.
The path taken from retrieving the certificate retrieval in the TLS handshake to verifying it seems pretty clear, so I'm uncertain where this discrepancy between the crypto/x509 parsing and the other tooling comes from.

can you show the entire certificate?

Ofcourse, here is the (slightly redacted) certificate.
echo | openssl s_client -showcerts -servername localgitlabinstance -connect localgitlabinstance:443 2>/dev/null | openssl x509 -inform pem -noout -text Output
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            0e:f4:9d:77:31:77:92:42:60:eb:55:1b:2a:ad:79:d2
        Signature Algorithm: sha256WithRSAEncryption
        Issuer: C = NL, O = Trust Provider B.V., OU = Domain Validated SSL, CN = Trust Provider B.V. TLS RSA CA G1
        Validity
            Not Before: Jan 16 00:00:00 2023 GMT
            Not After : Jan 18 23:59:59 2024 GMT
        Subject: CN = localgitlabinstance
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                Public-Key: (2048 bit)
                Modulus:
                    00:a9:84:6a:b8:ff:92:0f:32:59:1b:d3:82:9b:61:
                    ea:4d:b6:4e:3e:7f:be:06:2f:2f:e5:66:96:9a:6d:
                    ce:1c:49:4c:91:68:40:e8:38:92:b4:3d:0a:e4:57:
                    60:e9:06:12:e1:b2:70:f4:3f:e6:8e:8a:14:63:9a:
                    ec:ef:d5:c1:d8:8c:53:9b:cb:42:b4:4a:84:2b:bb:
                    8e:6e:87:6a:73:6d:78:e3:e2:67:be:74:8c:57:59:
                    bc:c1:bb:9e:b8:af:93:e0:29:f9:55:51:27:5e:b9:
                    04:ff:a2:0f:2b:0d:dd:f7:c4:df:11:2c:80:ac:d0:
                    70:6e:eb:79:87:d5:0e:da:0f:bc:88:80:42:a5:2c:
                    98:cd:0c:f4:79:00:37:64:fc:44:cb:12:70:1a:0d:
                    db:6e:e6:67:42:f7:45:c5:8c:77:5e:7d:46:02:40:
                    5b:3e:61:6d:a1:5b:48:43:08:95:e6:13:81:29:fc:
                    68:d5:bf:59:34:e0:b7:f6:bc:9c:ed:18:73:a7:34:
                    9a:d5:f6:d3:b3:fb:3f:fb:64:bc:1e:ff:92:c9:69:
                    9c:12:ae:e5:87:7a:be:56:1c:61:fe:9c:8c:f7:b6:
                    01:2e:30:c0:98:0a:cf:2a:fc:b1:d0:a3:2e:d5:aa:
                    9d:7d:f0:64:70:54:73:6b:da:c6:e5:1c:90:ef:6e:
                    12:cf
                Exponent: 65537 (0x10001)
        X509v3 extensions:
            X509v3 Authority Key Identifier:
                F5:56:22:1F:D9:BF:6B:59:24:52:B0:E1:6A:CD:C0:E1:57:67:E9:E8
            X509v3 Subject Key Identifier:
                FC:D9:62:E2:98:5A:B3:8B:77:EE:A2:F5:FE:1F:F6:A7:BF:BB:EA:3D
            X509v3 Subject Alternative Name:
                DNS:localgitlabinstance
            X509v3 Key Usage: critical
                Digital Signature, Key Encipherment
            X509v3 Extended Key Usage:
                TLS Web Server Authentication, TLS Web Client Authentication
            X509v3 CRL Distribution Points:
                Full Name:
                  URI:http://cdpd.digitalcertvalidation.com/TrustProviderBVTLSRSACAG1.crl
            X509v3 Certificate Policies:
                Policy: <IP_ADDRESS>.2.1
                  CPS: http://www.digicert.com/CPS
            Authority Information Access:
                OCSP - URI:http://statusd.digitalcertvalidation.com
                CA Issuers - URI:http://cacerts.digitalcertvalidation.com/TrustProviderBVTLSRSACAG1.crt
            X509v3 Basic Constraints:
                CA:FALSE
            CT Precertificate SCTs:
                Signed Certificate Timestamp:
                    Version   : v1 (0x0)
                    Log ID    : 76:FF:88:3F:0A:B6:FB:95:51:C2:61:CC:F5:87:BA:34:
                                B4:A4:CD:BB:29:DC:68:42:0A:9F:E6:67:4C:5A:3A:74
                    Timestamp : Jan 16 12:41:04.883 2023 GMT
                    Extensions: none
                    Signature : ecdsa-with-SHA256
                                30:44:02:20:6B:AD:8D:F8:8A:57:F7:39:1C:42:BD:31:
                                7F:23:0F:31:84:64:1B:8A:7D:AD:A2:B5:D0:7E:E8:38:
                                A9:D5:A6:A5:02:20:15:44:7C:DB:2B:45:E1:06:A6:44:
                                49:7E:74:55:EC:4E:64:14:82:C0:FA:4F:DD:89:21:2D:
                                71:8C:43:40:18:E6
                Signed Certificate Timestamp:
                    Version   : v1 (0x0)
                    Log ID    : 73:D9:9E:89:1B:4C:96:78:A0:20:7D:47:9D:E6:B2:C6:
                                1C:D0:51:5E:71:19:2A:8C:6B:80:10:7A:C1:77:72:B5
                    Timestamp : Jan 16 12:41:04.888 2023 GMT
                    Extensions: none
                    Signature : ecdsa-with-SHA256
                                30:45:02:21:00:AC:F4:9B:1E:78:29:E0:EA:72:98:18:
                                CF:60:60:94:BE:64:19:1B:83:A3:4E:9C:81:31:CB:21:
                                5D:BC:E8:73:2B:02:20:12:61:91:80:65:C8:9E:31:D7:
                                26:33:2D:B2:B7:3A:4D:25:F1:73:35:6A:E6:69:8F:7E:
                                AC:98:F6:4B:AA:97:08
                Signed Certificate Timestamp:
                    Version   : v1 (0x0)
                    Log ID    : 48:B0:E3:6B:DA:A6:47:34:0F:E5:6A:02:FA:9D:30:EB:
                                1C:52:01:CB:56:DD:2C:81:D9:BB:BF:AB:39:D8:84:73
                    Timestamp : Jan 16 12:41:04.839 2023 GMT
                    Extensions: none
                    Signature : ecdsa-with-SHA256
                                30:45:02:21:00:97:71:93:C5:43:BB:EA:7B:37:D3:D3:
                                76:FE:5A:45:9C:DA:B6:41:8D:99:2F:67:71:1B:96:BC:
                                60:A9:49:17:8E:02:20:2A:72:C7:DB:41:69:D2:B4:EA:
                                C0:45:BA:95:B7:33:FA:45:80:D0:D5:FA:75:03:F2:A4:
                                7A:A8:2E:38:0C:49:1E
    Signature Algorithm: sha256WithRSAEncryption
    Signature Value:
        4d:5a:ac:c8:b4:b1:15:b6:ec:fe:91:6b:af:c3:c5:ad:36:b7:
        29:25:b4:8c:db:08:4f:c7:ea:e2:66:b4:c8:f4:d3:d7:45:31:
        4a:11:74:f7:c3:d3:49:07:29:d6:ee:62:f7:11:15:b5:fc:89:
        12:b6:89:e6:0e:4f:aa:62:3a:43:e3:9f:0d:72:8a:8d:99:c5:
        dd:e3:40:34:ec:6a:75:f6:2f:d2:a9:b6:d7:8e:d5:e3:34:86:
        33:28:e2:bf:85:e2:06:bd:a9:7b:81:5a:1e:61:1b:fd:7e:44:
        e4:7f:37:b6:eb:0a:41:61:08:39:18:b7:43:6b:d7:af:27:9c:
        a3:8e:24:5d:86:26:dd:9a:0f:16:7c:3b:fa:4c:ab:2b:a5:dc:
        f6:69:81:04:b3:9a:6e:be:f9:f5:70:36:c6:df:3a:eb:d2:7c:
        2e:17:2d:3d:5a:ab:51:97:05:f5:e2:d0:22:15:fe:3f:5e:37:
        ae:e1:c2:5c:f3:21:96:fd:19:a5:a8:27:48:b7:b2:cb:c0:33:
        3b:f9:dc:82:0a:3c:1d:b6:76:f8:69:c9:d4:2b:b9:82:8d:e2:
        e9:6b:f3:7a:1b:33:c1:5b:52:d4:12:67:45:90:1f:8e:f1:eb:
        31:cb:52:20:76:ab:b3:50:47:22:6a:22:1b:af:a7:d3:65:7b:
        4f:3d:b3:58

I don't think we've been given enough information to identify the issue.
The given certificate is a precertificate, with no real leaf certificate issued: https://crt.sh/?serial=0e%3Af4%3A9d%3A77%3A31%3A77%3A92%3A42%3A60%3Aeb%3A55%3A1b%3A2a%3Aad%3A79%3Ad2 . that doesn't sound like something we would be trusting

cc @golang/security

The given certificate is a precertificate, with no real leaf certificate issued: https://crt.sh/?serial=0e%3Af4%3A9d%3A77%3A31%3A77%3A92%3A42%3A60%3Aeb%3A55%3A1b%3A2a%3Aad%3A79%3Ad2 . that doesn't sound like something we would be trusting

No, the certificate in https://github.com/golang/go/issues/60653#issuecomment-1580343790 is the certificate corresponding to the precertificate you found. It's pretty normal for CT logs to observe the precert and not the cert, especially for internal services.
The question is where the 2013-07-26T11:03:57Z timestamp came from.
@ysmilda are you sure the server is not serving different certificates to different connections? Is the issue intermittent or does it always reproduce? If you try to make a simple net/http connection without go mod tidy, does it reproduce?
Thank you.

@FiloSottile With go mod tidy the issue always reproduces, however with a simple http.Get() the request is succesfull.

Yes, tested over multiple machines it always returns the same timestamp.

If you are on an enterprise network, it seems plausible that this could be a TLS middlebox trying to do something funky and failing, or some other class of TLS interception failure.
Running the following program should give you an impression of the certificate chain being returned, I expect this is a local configuration issue, rather than a problem on our end, but if it turns up something strange I'd be interested in seeing it.
package main

import (
	"crypto/sha256"
	"fmt"
	"log"
	"net/http"
)

func main() {
	r, err := http.Get("<insert the url you are using for your local instance>")
	if err != nil {
		log.Fatal(err)
	}
	for i, chain := range r.TLS.VerifiedChains {
		fmt.Println("chain", i)
		for _, c := range chain {
			fmt.Printf("%x %s\n", sha256.Sum256(c.Raw), c.Subject)
		}
	}
}

I would expect it to be an issue on our end, as it is a enterprise network where the gitlab instance is not accessible from outside. However there doesn't seem to be anything in our network that does non standard TLS handling, but I must admit my knowledge on the TLS subject is limited.
outcome test script Output
chain 0
bd1a100977dfa0ef4379c507635c3bfd885d57ba51624b114705b7c1c59cb1c2 CN=*.domain.nl
009871c3a4c607311e5ae92f01095f9bf76100b8794ab0a9a5210e6794c8607c CN=Trust Provider B.V. TLS RSA CA G1,OU=Domain Validated SSL,O=Trust Provider B.V.,C=NL
cb3ccbb76031e5e0138f8dd39a23f9de47ffc35e43c1144cea27d46a5ab1cb5f CN=DigiCert Global Root G2,OU=www.digicert.com,O=DigiCert Inc,C=US

When setting the GOPRIVATE variable via go env to recognize the local instance as a private instance I've got it to work.
go env -w GOPRIVATE='localinstance'

I now see that go mod uses a proxy to get the modules instead of contacting the source directly. Our local instance is not reachable from the outside world and will be redirected to our main website. This is what serves the "invalid" certificate.
The interesting part here is that here Chrome still reports a valid certificate while the above script reports the aforementioned x509: certificate has expired or is not yet valid: current time 2013-06-01T00:01:16+02:00 is before 2023-01-16T00:00:00Z error.


Generate one (or more) resulting files merging the original results

Proposal for a feature to solve the frequently asked question about how to generate only one file with extract-text-webpack-plugin.
Usually solved by external plugins (i.e. merge-files-webpack-plugin) in a completely different step, this doesn't look to be working with v3. Also, it would be nice to have a native solution.
My proposal is to have an extra merge option to work like this, generalising the stated point:
// Generate one styles.css from all the *.styles.css
// and one themes.css from all the *.themes.css files
new ExtractTextPlugin({
  merge: [{
    filename: 'styles.css',       // name of the merged output file
    test: /\.style\.css$/,        // files to include (*.styles.css)
    preventOriginalOutput: true,  // when true (by default), original files won't be generated
  }, {
    filename: 'themes.css',
    test: /\.theme\.css$/,
    preventOriginalOutput: true,
  }],
});

So let's say we have this files as original output from this plugin:

a.style.css
b.style.css
c.style.css
a.theme.css
b.theme.css
fooBar.css

The resulting files after the execution should be this:

styles.css merging a.style.css + b.style.css + c.style.css
themes.css merging a.theme.css + b.theme.css
fooBar.css which doesn't merge into any other file

If we set preventOriginalOutput option to false, then the resulting file will output also the original files:

styles.css merged from a.style.css + b.style.css + c.style.css
themes.css merged from a.theme.css + b.theme.css
a.style.css
b.style.css
c.style.css
a.theme.css
b.theme.css
fooBar.css

See comment in https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/636#issuecomment-333866537


Issue With the Command "cordova platform add ios android"

cordova platform add ios android
Adding ios project...
iOS project created with<EMAIL_ADDRESS>Installing "cordova-plugin-camera" for ios
Installing "cordova-plugin-crosswalk-webview" for ios
Installing "cordova-plugin-device" for ios
Installing "cordova-plugin-iosrtc" for ios
    cordova-plugin-iosrtc enables use of the JavaScript WebRTC APIs (as defined by the W3C) in iOS devices.
    Learn more at: https://github.com/eface2face/cordova-plugin-iosrtc

Installing "cordova-plugin-whitelist" for ios
npm http GET https://registry.npmjs.org/cordova-android
npm http 304 https://registry.npmjs.org/cordova-android
Adding android project...
Creating Cordova project for the Android platform:
Path: platforms/android
Package: com.eface2face.iosrtcapp
Name: iOSRTCApp
Activity: MainActivity
Android target: android-22
Copying template files...
Android project created with<EMAIL_ADDRESS>Installing "cordova-plugin-camera" for android
Installing "cordova-plugin-crosswalk-webview" for android
Installing "cordova-plugin-device" for android
Installing "cordova-plugin-iosrtc" for android
    cordova-plugin-iosrtc enables use of the JavaScript WebRTC APIs (as defined by the W3C) in iOS devices.
    Learn more at: https://github.com/eface2face/cordova-plugin-iosrtc

Installing "cordova-plugin-whitelist" for android
Error: Cannot find module 'xcode'
at Function.Module._resolveFilename (module.js:336:15)
at Function.Module._load (module.js:278:25)
at Module.require (module.js:365:17)
at require (module.js:384:17)
at Object. (/Users/Excendia/iOSRTCApp/hooks/iosrtc-swift-support.js:10:10)
at Module._compile (module.js:460:26)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Module.require (module.js:365:17)

Please, open a new issue if the same problem happens when adding "ios platform" instead of "android" (given that this plugin is NOT for android but just for ios).

Sorry, I thought this issue was reported into the cordova-plugin-iosrtc project. Deleting my useless comments.

BTW the Building documentation of cordova-plugin-iosrtc clearly states that xcode NPM package is required.

I've updated the README to mention that xcode NPM package is required: 77b92a84faf30437e2ef9b90a596a772435264ce

hi,
i get the error with installed xcode, i think there is a dependency problem
philipp@air ~/ifolder/code/keenmeet $ sudo npm install -g xcode
Password:
npm WARN unmet dependency /usr/local/lib/node_modules/titanium/node_modules/winston requires<EMAIL_ADDRESS>but will load
npm WARN unmet dependency /usr/local/lib/node_modules/titanium/node_modules/colors,
npm WARN unmet dependency which is version 0.6.0-1
<EMAIL_ADDRESS>/usr/local/lib/node_modules/xcode
├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>philipp@air ~/ifolder/code/keenmeet $ cordova platform remove ios
philipp@air ~/ifolder/code/keenmeet $ cordova platform add ios
Adding ios project...
iOS project created with<EMAIL_ADDRESS>Installing "cordova-plugin-console" for ios
Installing "cordova-plugin-device" for ios
Installing "cordova-plugin-iosrtc" for ios

		cordova-plugin-iosrtc enables use of the JavaScript WebRTC APIs (as defined by the W3C) in iOS devices.
		Learn more at https://github.com/eface2face/cordova-plugin-iosrtc

Installing "cordova-plugin-whitelist" for ios
Error: Cannot find module 'xcode'
    at Function.Module._resolveFilename (module.js:336:15)
    at Function.Module._load (module.js:278:25)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/philipp/ifolder/code/keenmeet/hooks/iosrtc-swift-support.js:10:10)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)

installing xcode only locally not with -g worked for me

Right. Not sure why but it works. I've updated the README and added a NPM package.json file to the project, so the user must run npm install (then xcode package is installed and build works).

I have the same issue. Please help

It is fixed in master. Please read the comment above, not so hard.

Had the same issue, and the suggested fixes didn't work. So I just deleted the .cordova folder in C:\Users(yourusername) and this resolved the issue for me, looks like a cache issue from upgrading stuff

Do you mean the first folder you have created? I am using Ubuntu.


Does the crd can be applied to cross domain distillation

hi, i wonder if you have applied the crd or cmc to cross domain distillation, for example : vqa or  different domains in visual , will it work ?

Hi, @wwwzzzmmm. I tried cross modal distillation. CRD works at least in my scenario. I think CRD and CMC will generally work if you properly construct variables X and Y, and define their joint distribution and product of marginals.

nice work!  thank you


Integration with Key management/rotation solutions

Integration with Key management/rotation solutions

AWS secret manager
HashiCorp (Configuration aspect [through secure vault])
SPIFFE/Istio

The following types of keys should be considered

File config keys - #9150
External keys (IDP, Analytics server credentials)
Internal keys (signing certs, TLS certs)

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Allow audio ducking

This is a rework of #257 with asked reviews and a few more tweaks:
Android

I use (deprecated) AudioManager.requestAudioFocus() so we don't need to update minSdk to 26 (Android O). This triggers a warning during build that I suppressed with an annotation.
This should work on android O too with conditionnal focus handling
I kept the respectSilence audioAttribute
I used AUDIOFOCUS_GAIN_TRANSIENT_MAY_DUCK so external sound will continue after sound ended

iOS
No changes made
If you have any question/reviews, tell me :)

@luanpotter Just fixed it as you requested :-)

(I'm fixing the conflicts)

Closing in lieu of #649


KACST TrueType Arabic fonts

Project description
This is a set of TrueType Arabic fonts released by the King Abdulaziz City for Science and Technology (KACST).
Metadata

homepage URL: https://packages.debian.org/bullseye/fonts-kacst
source URL: mirror://debian/pool/main/f/fonts-kacst/fonts-kacst_2.01+mry.orig.tar.bz2
license: gpl2+
platforms: all

PR merged https://github.com/NixOS/nixpkgs/pull/166166


Download link broken

I paid but the link is broken!
Huge bummer.
Please fix ASAP

Resolved, thanks for the support Pavel!


Add support for ReSharper 2019.2.x

Please support  ReSharper 2019.2.x

One of two plugins that I use that have not made the jump yet... 😭

forked and pullrequest created.
Tempororay pre build at: https://github.com/KsWare/KsWare.ReSharper.InternalsVisibleTo/releases/tag/2019.2.2-KsWare

@SchreinerK it's almost worth looking into submitting a ReSharper.InternalsVisibleTo.Unofficial package to JB as it seems this one isn't quite as updated/supported/maintained as it should be. 😞

merged :-)
https://github.com/hmemcpy/ReSharper.InternalsVisibleTo/pull/15

Woohoo!  Thank you all!  Until next time. 😁


Fixes #4: sdk should only depend on cloudevents-core

The SDK should require neither cloudevents-http-basic nor cloudevents-json-jackson. At this point, the dependency on cloudevents-core is sufficent.

Hello @zaza and thank you for your PR!
Could you please provide more context in the PR description and commit message?
Thank you!

@rjalander fyi


Expand/collapse locations

As ...
Ozzie - Operator
I want ...
To have the Location Hierarchy collapsed to just the highest level groups when you open locations and then dill down to the location you wish to interact with.
So that ...
The UI is less cluttered and less scrolling and paging looking for a location
I know this is done when...
You open the locations and only see the high-level locations and then can drill down into specific locations by clicking an arrow or maybe a > sign to the left of the location name.
Optional - Feature groups this request pertains to.

[ ] Automation
[ ] Circuits
[ ] DCIM
[ ] IPAM
[ ] Misc (including Data Sources)
[X] Organization
[ ] Apps (and other Extensibility)
[ ] Security (Secrets, etc)
[ ] Image Management
[ ] UI/UX
[ ] Documentation
[ ] Other (not directly a platform feature)

Database Changes
No response
External Dependencies
No response

See also #2516.


Issue with package creation including list views filtered on recordtype

Summary
Creating a package with list views for knowledge that have a recordtype filter I get the following error:
(1) Knowledge__kav.Archived_Articles_x: Could not resolve list view column: RECORDTYPE
Steps To Reproduce
Create a package with knowledge list views that include a recordtype filter
Expected result
successfull recordtype creation
Actual result
error as stated above
System Information
Bash and latest salesforce cli version.

{
"architecture": "darwin-arm64",
"cliVersion"<EMAIL_ADDRESS>"nodeVersion": "node-v20.10.0",
"osVersion": "Darwin 22.5.0",
"rootPath": "/usr/local/lib/node_modules/@salesforce/cli",
"shell": "zsh",
"pluginVersions": [
"@oclif/plugin-autocomplete 3.0.5 (core)",
"@oclif/plugin-commands 3.1.1 (core)",
"@oclif/plugin-help 6.0.12 (core)",
"@oclif/plugin-not-found 3.0.9 (core)",
"@oclif/plugin-plugins 4.1.23 (core)",
"@oclif/plugin-search 1.0.12 (core)",
"@oclif/plugin-update 4.1.8 (core)",
"@oclif/plugin-version 2.0.11 (core)",
"@oclif/plugin-warn-if-update-available 3.0.9 (core)",
"@oclif/plugin-which 3.0.15 (core)",
"@salesforce/cli 2.27.6 (core)",
"apex 3.0.22 (core)",
"auth 3.3.6 (core)",
"data 3.0.18 (core)",
"deploy-retrieve 3.2.9 (core)",
"info 3.0.19 (core)",
"limits 3.1.6 (core)",
"marketplace 1.0.20 (core)",
"org 3.3.10 (core)",
"packaging 2.1.8 (user)",
"schema 3.1.0 (core)",
"settings 2.0.21 (core)",
"signups 1.4.22 (user)",
"sobject 1.1.6 (core)",
"source 3.1.8 (core)",
"telemetry 3.1.10 (core)",
"templates 56.0.12 (core)",
"trust 3.3.4 (core)",
"user 3.2.6 (core)"
]
}

@GodertC I would take a look at the Metadata Coverage Report to see if all your metadata is supported for packaging.
If it's not supported, then you're not going to be able to package it
But if everything is supported, then I would try to see if you can successfully deploy it. If you're unable to deploy it, then it's likely an issue with your metadata.

Listviews are packageable and I can deploy the metadata succesfully.

Thanks for the update. One thing you can try to help debug is use the --preserve flag on package version create which will save all your converted metadata into a temp dir. You can take a look at that to see if everything is as expected
If it is, then I'd suggest opening a support case since this isn't a CLI issue.


Error: Missing Fido2 config when not providing fido2 object to Config

I have the following config
Passwordless.configure({
	cognitoIdpEndpoint: `${process.env.USER_POOL_REGION}`,
	userPoolId: `${process.env.USER_POOL_ID}`,
	clientId: `${process.env.USER_POOL_CLIENT_ID}`
})

I'm intentionally not passing a fido2 object because I only want to use the functionality around the Magic Link Sign-In.
However, the above gives me the following error
Error: Missing Fido2 config
Looking at the code, I can see why. If fido2 isn't defined, it throws this error.
Am I reading this, right? The documentation says using fido is optional, but clearly it's required

Should be optional, so that's a bug. Thanks for the report! If you're interested to send a PR?

Fix released in https://github.com/aws-samples/amazon-cognito-passwordless-auth/releases/tag/v0.12.1


fix(backend): Added missing organizationId to UserCountParams for getUserList

Description
Added missing parameter for getUserList

Checklist

[ ] npm test runs as expected.
[ ] npm run build runs as expected.
[ ] (If applicable) JSDoc comments have been added or updated for any package exports
[ ] (If applicable) Documentation has been updated

Type of change

[X] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

@dimkl seems that last_active_at_since is also used in UserCountParams and based on the link you sent it shouldn't be there

last_active_at_since

@panteliselef We probably need to move to UserListParams too.

Want me to add this to the PR here?


Quickly include/exclude filetypes on search

So right now the search has a few features to include files and to exclude files once you've pressed on the 3 dots. On these you can add something like **/*.d.ts to exclude various filetypes. When developing I quickly move from one task to the next, making me look for different things inside projects. So I'm requesting a new feature to quickly include/exclude items. Be it from history, items that you pre-define or when scanning through the files and setting depending on how often they are included is up to you guys.
Basically if I can switch between searching inside my TS files on one moment and switch to searching in HTML files in the next, it would help me a lot. I know I can exclude .d.ts files from coming up, but often I do not want results from a .js file to be included in one search but I need it in the next.
Perhaps it would be easier to add this as filtering of the list without really including/excluding them from search, but I can see this starting small and moving from there. I'm not sure if its possible to adopt this in an extension but my knowledge of file searches and regex isn't good enough to get a prototype working.

Would this cover your case? https://github.com/Microsoft/vscode/issues/16488 Like if you can have multiple search "tabs" that keep their different filters.

I would say yes, issue #16488 would cover this case. I got the same challenges like Martinspire has described in here.
VSC would be great with multiple searches.

@roblourens Well, having multiple searches would be nice, but I have way too many filetypes that I do or do not need to match that it would be easier to have a selection of filetypes to include/exclude.
I also thought that the results itself could have better filters because perhaps that would be used to match the filetypes in the search results directly giving me a way to enable/disable whatever I do or do not need.
Having another bar between the Files to exclude item and 2 results in 2 files text or next to the 2 results in 2 files text, to exclude files would also be a neat solution. And I can also see myself wanting to exclude like our test files which aren't really just .ts or .js files but with test.ts, and right now excluding those are not as easy too. Same happens with my .d.ts and my .js.map files.

History does exist in these fields, if that helps.


Warning to connect to remote server with Instance name

@MashaMSFT
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Dear @Court72, I have been using SQL Server for a long time and I will try to add my experiences and fine points that I use in the titles one by one.
Thank you for your support 🙂

Hi @saitorhan , thanks so much for your submission! I modified the text slightly, and combined the two notes :) Thanks again! #sign-off

Learn Build status updates of commit 47c01c1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/relational-databases/lesson-2-connecting-from-another-computer.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 701c92e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/relational-databases/lesson-2-connecting-from-another-computer.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


miscellaneous changes (see list)

Hi,
here a list of changes:

code has been reordered to match gtk reference manual and all C gtk widget and object (for gtk package) that should be binded has been added in comments
finished revisiting version control. Now go-gtk should compile without problems on any gtk version 2.16 or older. Functions deprecated before 2.16 haven't been removed yet.
a few fixes. Above all, avoiding use of unsafe.Pointer where possible allows to clean a lot of C code.
added a simple tool in tools/gogtkinfo to count functions and report progress status (only on gtk.go at the moment). I used its output to update progress status in Readme.md. It is not 100% precise (i.e. doesn't check if a func is a binding from C or a local convenience one) but should be good enough to keep progress updated without effort.

Great! I'll check and include it.


0.7 reactive cookie feature breaks cloudflare worker

     ../../node_modules/cookie-signature/index.js:5:21:
       5 │ var crypto = require('crypto');
         ╵                      ~~~~~~~~

   The package "crypto" wasn't found on the file system but is built into node.
   Add "node_compat = true" to your wrangler.toml file to enable Node.js compatibility

Should be fixed with #253


Change blueflood planning error condition

This changes how Blueflood plans fetching. It has the following impacts:

requesting data into the future is never a problem (Blueflood won't try to actually fetch the data, though)
if the specified resolutions don't have monotonic (increasing) TTLs, then you'll unexpected get errors with queries. Skip resolutions with non-monotonic TTLs.

@drcapulet

LGTM


DP-989 pretty printing support for SimpleHybridEditor

The tokenFocusAfterReparseAndSplitGivesDifferentTokens test fails when I try to apply it to a simple hybrid editor, still investigating the cause.

I kept SimpleHybridProperty to allow non-blocking merge.

Looks good to me. One small thing is that we could have a ParsingHybridProperty constructor taking a hybridEditorSpec. We can get a parser, a pretty printer and a parsingContextFactory (through HybridEditorSpecUtil.getParsingContextFactory(hybridEditorSpec)) from hybridEditorSpec. We can do that change later though.

@timzam I thought about that. Is ParsingProperty is part of model and keeping it with minimal set of dependencies is very useful. EditorSpec would add dependency on completion stuff to our model definition.

Ok, I see. In this case we could have a factory utility doing this job.

Please, fix my notes. You can do this in the next request.


Lost icons and sorting after upgrading to 2024.2.1

Describe the bug
After upgrading to 2024.2.1, I lost custom icons, icon colors, and sorting from battery-state-card. This worked prior to the update.
How to reproduce
Have a functioning battery-state-card with color gradients and sorting by state enabled. Upgrade from Home Assistant 2024.1.* to 2024.2.*, notice the missing icons, no color gradient, and inability to sort by battery state.
Expected behavior
Expect icon colors to reflect battery state, icon glyph to reflect the battery state, and sorting by battery state.
YAML configuration
type: custom:battery-state-card
filter:
  include:
    - name: attributes.device_class
      value: battery
  exclude:
    - name: entity_id
      value: binary_sensor.*
    - name: entity_id
      value: '*mac*'
    - name: entity_id
      value: '*s22*'
sort:
  by: state
bulk_rename:
  - from: ' Battery'
  - from: ' level'
colors:
  steps:
    - '#ff0000'
    - '#ffff00'
    - '#00ff00'
  gradient: true

Dev console errors
No console errors
Screenshots

Version
BATTERY-STATE-CARD  3.1.5
Home Assistant: 2024.2.1

Please install the latest card version

Thank you!  3.1.6 fixes this issue.


Merge prTesting_201908130042 branch to master branch

Docs Build status updates of commit 7581d3e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details
Dependent Files

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add missing extension doc ref

Add missing doc ref for newly introduced extension.

Thanks, I fixed the errors!

LGTM!


fix(exception): rename exceptions to add exception suffix

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.474%

Totals

Change from base Build<PHONE_NUMBER>8:
0.0%

Covered Lines:
221

Relevant Lines:
247

💛  - Coveralls


fix: disambiguate vnet resource group name for linux builds

What type of PR is this?

What this PR does / why we need it:
so packer can distinguish between vnets with the same name in different resource groups
Which issue(s) this PR fixes:

Fixes #
Requirements:

[ ] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 70.486%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2627

Relevant Lines:
3727

💛  - Coveralls


Balances are too small but higher than 0 isn't shown when you select Hide Zero Balances

When balances are too small but higher than 0 it doesn't show when you select Hide Zero Balances.
If you have LP balances like 0.00006482 it isn't showed up in the list when you select that filter. Deposited Vault works though.

Hi @memoyil, could you please share your wallet address (maybe DM on discord) or at least name which exact LP you are having an issue with? This way it will be easier to reproduce and fix.

Sorry i will not share my wallet address with you but it happens in Ditto-BNB LP where LP value is so high that I only have 0.00006xxx it

Sorry i will not share my wallet address with you but it happens in Ditto-BNB LP where LP value is so high that I only have 0.00006xxx it

Thanks for the details @memoyil, managed to reproduce an issue, fix is on its way...

Hey, @memoyil an improvement have been merged to prod, could you check it works for you now?

It works thank you

Closed by https://github.com/beefyfinance/beefy-app/pull/116


Modems broken by Create contraptions

Description
Modems broken by Create contraptions. Modems break by being turned into the entity / block state from the Create mod contraptions.
This issue has been reported and experience by a lot of other players. See thoses posts :
https://github.com/Creators-of-Create/Create/issues/4959
https://github.com/cc-tweaked/CC-Tweaked/issues/948
To Reproduce

Make a contraption with modem glued to it.
Move or turn the contraption so that it becomes an entity.
Turn the contraption back into blocks.

Result : Modems broke
Expected behavior
Modems not breaking off contraptions.
To resolve issue
Ok, so I have a pretty clear idea on why this is happening. Create uses the block tag "create:brittle" to indicate to it's contraption that objects such as redstone links or Valve handle should be placed last when the contraption converts back into blocks. That way blocks with the "create:brittle" have something to attach to.
Since CC:T modems (ender or wireless) don't have that "create:brittle" tag but also need to be attached to a solid block, I believe the contraption tries to place them first, therefore making them insta break / pop.
Adding this tag to modems may fix the issue. Since CCC:Bridge adds compatibility between Create and CC:T, I thought it would be a good idea to report it here.
Hope you can help,
MintTee
Software :

Minecraft Version 1.20.1
Mod Version v1.6.2b
ModLoader Fabric

Hey, thank you for this issue!
This sounds like a great idea, I didn't know about that actually.
I will look into this.

Thanks for the acknowledgment.
There is also this "create:safe_nbt" block tag which I guess tells the contraption to keep the nbt data of the blocks in order to place them with the same state. Not 100% sure though.

I found a workaround to this issue.
It's possible to use turtles on contraptions. Since they are considered a solid block, they dont need a support block (they can float mid air). Therefore, unlike modems, they wont break when turned into a contraption form or back into the block form. They will, however, shutdown and restart.
If you create a program called "startup" in the default directory and have the "shell.run("program_name")" inside it, it is possible to run any program automatically as soon as a computer / turtle restarts.
Maybe this temporary workaround can help a few people experimenting with Computer Craft on Create contraptions.

Create:safe_nbt seems to tell create that the block can have its nbt saved in a schematic without duplicating items, so not related as far as I can tell.
https://github.com/Plite7067/CreateCCModemFix I made this datapack which seems to solve the problem by adding the brittle tag as the original poster suggested. It should work for all versions necessary - I have tested that it applies the tag correctly on 1.18.2+


Select assets before showing picker

TLPhotosPickerViewController has selectedAssets but I don't think it was made to accept assets from outside. Is there a way to display picker with selectedAssets?

See this issue

Got it, I was trying to set selectedAssets = someNewAccests instead of append: operator


Microsoft Surface Laptop 5 Missing

No drivers displayed for Microsoft Surface Laptop 5 (new release) under Windows 10 22H2.
Also for other Surface models must step back to 20H2 (no longer supported) to get drivers, these should be displayed under newer versions of Windows when searching.

I too am looking for updated drivers for Microsoft products - Win11 22H2 drivers for any/all devices, drivers for Surface Laptop 5, drivers for Surface Pro 9.  Would greatly appreciate an update to the JSON for Microsoft products.


run_bug_detection behavior for failing tests on fixed version

run_bug_detection will report "Broken" status if automated tests fail on the fixed version and on the buggy version as well. I think this status should be reported only if there is some kind of error, for example related to compilation. After all, it is possible for automated tests to find new bugs.

You are right that, in principle, a test generation tool could find new bugs.
However, all of the test generation tools in Defects4J generate regression tests. This means that a generated test suite should always pass on the program version for which it was generated. If this is not the case, then the test generation tool produced broken or flaky tests.
Here are the three possible outcomes for a generated test suite, when executed with the run_bug_detection script.

Broken: The test suite fails on the program version for which it was generated.

Pass: The test suite passes on the program version for which it was not generated.

Fail: The test suite fails on the program version for which it was not generated.

As an example, suppose you generated a test suite for the fixed version of Lang-1 (i.e., Lang-1f):

Broken: The test suite fails on Lang-1f.

Pass: The test suite passes on Lang-1f and Lang-1b.

Fail: The test suite passes on Lang-1f but fails on Lang-1b.

The first execution of the test suite on the program version for which it was generated is essentially a sanity check.
Note that if you encounter a "Broken" test suite in your experimental set up, you can use the fix_test_suite script to eliminate the broken or flaky test cases that are causing the test suite to fail.
Let me know if this is unclear of if you have further questions.
Thanks,
René

Thanks for reminding me about the fix_test_suite functionality.

I'm closing this issue for now.


Add missing step

Hi,
creating this PR because it seemed like the step where mongodb dump created inside docker container has to be copied to file sytsem before being compressed was missing
let me know what you think
thnks

Hi,
Thanks for you PR, but it's not necessary to add this step since the mupx mongodb container already use volume to export all data to the host (in /var/lib/mongodb). As I say in the README.md, you just have to make a symbolic link between your docker volume and where you want to store backups.
According to Arunoda, this should change to make mupx compatible with mup 0.X.
I'm not going to merge this PR since the changes are not necessary but thanks for your interest !


Adding comments to the proto definition, and API groups.

@AndyDiamondstein So we can keep moving on the groups :)

LGTM!
On Fri, Aug 28, 2015 at 2:10 PM, Alain Jobart<EMAIL_ADDRESS>wrote:

@AndyDiamondstein https://github.com/AndyDiamondstein So we can keep
moving on the groups :)
You can view, comment on, or merge this pull request online at:
https://github.com/youtube/vitess/pull/1054
Commit Summary

Adding comments to the proto definition, and API groups.

File Changes

M proto/vtgateservice.proto
https://github.com/youtube/vitess/pull/1054/files#diff-0 (35)

Patch Links:

https://github.com/youtube/vitess/pull/1054.patch
https://github.com/youtube/vitess/pull/1054.diff

—
Reply to this email directly or view it on GitHub
https://github.com/youtube/vitess/pull/1054.

--
Andy Diamondstein
Technical Writer
YouTube
650-253-4101 (desk)
415-812-7670 (cell)


[dv/rstmgr_cnsty_chk] Reach coverage for dedicated environment

The dedicated test environment needs to reach above 90% coverage on all metrics.
Change the test strategy to scan events past each other. Inject sparse fsm faults and check they fire.
Fixes #9314
Signed-off-by: Guillermo Maturana<EMAIL_ADDRESS>

In general LGTM, but I believe this UNR exclusion actually is needed due to a bug.
I am fine with resolving this after merging this PR though.
I will push up a potential fix and comment on the tracker issue.


Add a step to build an archive for external audit

This is to make things simpler to create the archive that's sent for external auditing (currently by Insomnia)
The archive should follow the conventions:

--prefer-dist
exclude all source control files
exclude the .env file
Include the changelog containing all changes (upgrade-only dependencies must be included as well)
zip format

Notes

There has been some code in cow (since deleted) which used to archive the output to S3. So we can have a look at that for an initial reference.
Also, look at the CWP release documentation which outlines how the release needs to be built before sending to Insomnia.

Doc has been updated to cover this.


test: e2e plugin test cases

Added e2e-plugin for e2e testing
Added plugin list, sign, verify test cases
with a few test cases set to skip

Signed-off-by: Junjie Gao<EMAIL_ADDRESS>

Codecov Report

Merging #510 (1c042a8) into main (1281179) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #510   +/-   ##
=======================================
  Coverage   29.57%   29.57%
=======================================
  Files          26       26
  Lines        1515     1515
=======================================
  Hits          448      448
  Misses       1050     1050
  Partials       17       17

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Update readme with instructions that don't require mamba for macOS ARM / Apple Silicon

Previously, on Apple Silicon macs the cadquery-ocp package was not installable through pip and required mamba. But now there is a wheel release on github that can be installed with pip, which means you don't need mamba anymore.
Having to use mamba was a big annoyance and deterence for me and probably others.
Visit ocp-build-system/releases and copy the URL of the macosx_11_0_arm64.whl for your python version.
python3 --version

pip install https://github.com/CadQuery/ocp-build-system/releases/download/<IP_ADDRESS>/cadquery_ocp-7.7.2-cp39-cp39-macosx_11_0_arm64.whl

pip install build123d

For more info, you can check out the following issues:

https://github.com/CadQuery/ocp-build-system/issues/11
https://github.com/bernhard-42/vscode-ocp-cad-viewer/issues/68

I personally think it is better to wait for the Cadquery-OCP wheels to be on PyPI. With the approach you suggested it would require the user to pick the correct URL of the correct wheel that matches python / OS / CPU-type.
Since you are obviously aware of the workaround, then feel free to use it but IMHO this does not necessarily improve the ease-of-use for new MacOS+arm64 users.


ruff --config not listed in `ruff --help

❯ ruff --version
ruff 0.1.6
❯ ruff --help
Ruff: An extremely fast Python linter.

Usage: ruff [OPTIONS] <COMMAND>

Commands:
  check    Run Ruff on the given files or directories (default)
  rule     Explain a rule (or all rules)
  config   List or describe the available configuration options
  linter   List all supported upstream linters
  clean    Clear any caches in the current directory and any subdirectories
  format   Run the Ruff formatter on the given files or directories
  version  Display Ruff's version
  help     Print this message or the help of the given subcommand(s)

Options:
  -h, --help     Print help
  -V, --version  Print version

Log levels:
  -v, --verbose  Enable verbose logging
  -q, --quiet    Print diagnostics, but nothing else
  -s, --silent   Disable all logging (but still exit with status code "1" upon detecting diagnostics)

For help with a specific command, see: `ruff help <command>`.
 ❯ ruff --config
error: a value is required for '--config <CONFIG>' but none was supplied

For more information, try '--help'.

As per the title, you can see that ruff --config has no input in ruff --help, making it harder to find this exists.

You might be looking for ruff config, the subcommand, rather than ruff --config?
ruff --config shows this message because, for backwards compatibility, we treat ruff without a subcommand as equivalent to ruff check -- so, above, it's as if you ran ruff check --config.


Suggestion: OpenPGP: Allow the user to select a decryption key if decryption fails

Currently I get a few emails to an alias of mine that isn't included in my PGP key. I can't decrypt this messages automatically because rainloop isn't smart enough to ask me which key to use for decryption when it can't find a key to decrypt the message with.

In the end, it may pay off to add that address to the PGP key rather than selecting it each time. Anyway, sounds like a reasonable feature to have.

@sbrl which version do you use?

@RainLoop I tried it on 1.9, and now that I've updated to 1.10 it asks me which key I want to use as I thought it should. Thanks anyway!


Canonicalize the function name for SQL parser

Canonicalize the function name to be lower case without underscore when parsing the expression

Codecov Report

Merging #8341 (7715942) into master (262dc50) will decrease coverage by 56.65%.
The diff coverage is 4.19%.

@@              Coverage Diff              @@
##             master    #8341       +/-   ##
=============================================
- Coverage     70.83%   14.17%   -56.66%
+ Complexity     4258       81     -4177
=============================================
  Files          1636     1591       -45
  Lines         85804    83919     -1885
  Branches      12920    12710      -210
=============================================
- Hits          60779    11897    -48882
- Misses        20836    71126    +50290
+ Partials       4189      896     -3293

Flag
Coverage Δ

integration1
?

integration2
?

unittests1
?

unittests2
14.17% <4.19%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262dc50...7715942. Read the comment docs.

@richardstartin Can you please take another look? I have to change several tests to accommodate with the lower case change, but that should be able to save a lot of unnecessary extra string allocations since we use lower case to canonicalize function names in all other places.


Add float4 and float8 aliases for real/double

Summary of the changes / Why this improves CrateDB
Add float4 type alias for real and float8 alias for double
I'm unsure if SQL compatibility data types needs to be updated as well or not 🤷
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Thanks for this patch.

I'm unsure if SQL compatibility data types needs to be updated as well or not 🤷

Maybe @norosa has an answer to this question.


proposing change

Hi @4c74356b41, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

@4c74356b41 : Thanks for your contribution to the Azure documentation! The author, @sebastus, has been notified to review your proposed change.

@4c74356b41 - thank you very much for your contribution!
@PRmerger - #signoff


Jest tests fails on Link components using spy and containerId

Hi, I'm having a really weird issue with the Link component and jest tests; if I use the props spy=true and containerId the related test fails with the error TypeError: Cannot read property 'spyCallbacks' of undefined
This is the stack trace:
at Object.addSpyHandler (node_modules/react-scroll/modules/mixins/scroll-spy.js:59:20)
at Link.componentDidMount (node_modules/react-scroll/modules/mixins/scroll-link.js:119:31)
at commitLifeCycles (node_modules/react-dom/cjs/react-dom.development.js:14685:22)
at commitAllLifeCycles (node_modules/react-dom/cjs/react-dom.development.js:15905:7)
at HTMLUnknownElement.callCallback (node_modules/react-dom/cjs/react-dom.development.js:145:14)
at invokeEventListeners (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:193:27)
at HTMLUnknownElementImpl._dispatch (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:119:9)
at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:82:17)
at HTMLUnknownElementImpl.dispatchEvent (node_modules/jsdom/lib/jsdom/living/nodes/HTMLElement-impl.js:30:27)
at HTMLUnknownElement.dispatchEvent (node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:157:21)
at Object.invokeGuardedCallbackDev (node_modules/react-dom/cjs/react-dom.development.js:195:16)
at invokeGuardedCallback (node_modules/react-dom/cjs/react-dom.development.js:248:31)
at commitRoot (node_modules/react-dom/cjs/react-dom.development.js:16075:7)
at completeRoot (node_modules/react-dom/cjs/react-dom.development.js:17463:3)
at performWorkOnRoot (node_modules/react-dom/cjs/react-dom.development.js:17391:9)
at performWork (node_modules/react-dom/cjs/react-dom.development.js:17295:7)
at performSyncWork (node_modules/react-dom/cjs/react-dom.development.js:17267:3)
at requestWork (node_modules/react-dom/cjs/react-dom.development.js:17155:5)
at scheduleWork (node_modules/react-dom/cjs/react-dom.development.js:16949:5)
at scheduleRootUpdate (node_modules/react-dom/cjs/react-dom.development.js:17637:3)
at updateContainerAtExpirationTime (node_modules/react-dom/cjs/react-dom.development.js:17664:10)
at updateContainer (node_modules/react-dom/cjs/react-dom.development.js:17691:10)
at ReactRoot.Object.<anonymous>.ReactRoot.render (node_modules/react-dom/cjs/react-dom.development.js:17957:3)
at node_modules/react-dom/cjs/react-dom.development.js:18097:14
at unbatchedUpdates (node_modules/react-dom/cjs/react-dom.development.js:17518:10)
at legacyRenderSubtreeIntoContainer (node_modules/react-dom/cjs/react-dom.development.js:18093:5)
at Object.render (node_modules/react-dom/cjs/react-dom.development.js:18152:12)
at Object.render (src/App.test.js:11:12)

Bear in mind that the component behave correctly in running time, but the test fails. If I don't use spy and containerId at the same time, the unit test pass as it should be. I'm really clueless about this error and how to solve it. Thanks for your help. Jose.
Environment:
"react": "^16.4.2",
"jest": "23.6.0",
"react-dom": "^16.4.2",
"react-scroll": "^1.7.10",

I was having the same problem (but I'm using Enzyme). When I mount my component, i also use the mount option attachTo (docs)
so my mount looks like:
mount(
  <MyComponent />
  , { attachTo: document.body }
)

Hope that helps!

Hi @davywentworth
Adding attachTo: DOM element did not help

Hi @davywentworth
Adding attachTo: DOM element did not help

Wrapper the component like
<div id="containerId">
   <MyComponent />
</div>


[Test] Introduce fuzzing proptest

[x] #160
[ ] Use proptest for test random edge conditions.
[ ] Try to use proptest to generate the mock struct.

i will try this task.

The design concept of Proptest mainly corresponds to two themes, namely "input generation" and "result reduction".
"Input generation" refers to programmatically defining a way to generate arbitrary values representing the space of possible inputs. Instead of predefining a specific set of test cases, Proptest randomly generates a large number of different inputs according to set rules, which can help find anomalies that developers have not predicted or considered.
The concept of "result reduction" is that when Proptest finds a failing example, it tries to simplify or "reduce" the input until it finds the most simplified input that still fails the test. This feature is useful because simply providing random inputs that cause a test to fail can place a heavy analysis burden on the developer. In contrast, Proptest tries to provide minimal failure cases, allowing developers to better understand and fix problems.
Overall, Proptest is designed to automate the generation of random and broad-coverage test inputs as much as possible, while providing concise feedback when problems are found.

I will try to generate a mock struct of MoveAction, which will be used later to detect whether a maliciously constructed MoveAction will cause Rooch to crash.


Allow bitbake 2.0 override syntax

Allow bitbake 2.0 override syntax
Update org.jetbrains.intellij plugin to recent version
Optimize build time by disabling the "searchable options" (AFAIK we don't have something like that)

Please test carefully. I did some tests with my bitbake/Isar layers laying around but there might be corner cases that I did not cover so far.

Thanks for your contribution & sorry that I didn't review this yet - I don't have a project yet that uses the new syntax, I plan to try it out in the next week though.

Any updates? Works fine for some time now...

Any updates? Works fine for some time now...

There are still a few issues with the parsing: https://github.com/vitalibo/bitbake-intellij-plugin/issues/5#issuecomment-1583500294

Well, this issue stalled over one year now. I'm not very optimistic that we will see progress soon...

Updated the MR with the results of my one day holiday hacking. I tried to address some issues from #5. Feedback welcome.

@fbezdeka sounds great, but my apologies, I forget, how do I test this again? Is there a build somewhere?

Hm... Seems you have to build it on your own. On the long run we might implement something based on github actions that will automatically build pull requests. I will try that now, but not sure if that will work within a few tries.

The plugin with this changes applied can be downloaded from github actions now. (See last git commit in this PR).
https://github.com/fbezdeka/bitbake-intellij-plugin/actions/runs/10178590486/artifacts/1759583652

Link to the latest build download: https://github.com/fbezdeka/bitbake-intellij-plugin/actions/runs/10202860522/artifacts/1765892776

Hm... Up to now I thought that the only valid export statement is export VAR="value", so whitespaces only allowed between export keyword and VAR. According to some screenshots in #5 whitespaces are allowed everywhere. If so, the solution for the export statements is kind of over engineered and wrong...
Will look into that again soon.

Build result: https://github.com/fbezdeka/bitbake-intellij-plugin/actions/runs/10213925452/artifacts/1768710293
Everything related to export and EXPORT_FUNCTION should be fixed now.

Latest build result: https://github.com/fbezdeka/bitbake-intellij-plugin/actions/runs/10247071178/artifacts/1775814440

Proper parsing of flags (VAR[flag] = "value" syntax)
Do no longer allow whitespaces at the beginning of lines, plugin allowed that but bitbake failed to parse
Reworked addtask,deltask and addhandler statements
Do no longer allow functions with the opening bracket at the beginning of the next/first line
Fixed highlighting of python functions at the end of files
EXPORT_FUNCTIONS should be fine now
export statements allow all bitbake operators now

@vitalibo could you please have a look and merge? I think it's wrong when I merge it myself. In addition I can't do the upload to the Jetbrains/IDEA "plugin store".

Hi @fbezdeka, thanks for your contribution. I am no longer working with Bitbake. Please reach out to @moqmar for further help to upload the plugin to JetBrains/IDEA store. Thanks!

Sorry for the delay, thank you Vitalibo for merging. I'm still here (albeit with quite limited time), and have tried it out as well now, created a release & uploaded it to the marketplace. Thanks again for the PR!

@moqmar ,first of all: Thanks!
But: Are you sure the upload to the marketplace went as it should? It shows version 1.3, yes, but from 2022. Version missmatch?

Oh, you are right - seems like we are at 1.4 now, but 1.3 was never tagged in git. Re-uploaded it; it is now being reviewed.


Cleaned Classification Data with Validation & Test Splits

The Marathi News Dataset contains only the Train and Validation Splits. This made it hard to report accuracy and compare to the baseline (which reports the validation accuracy). Hence, there's a need to have separate Train-Validation-Test sets.
Also, the headlines contain non-Devanagari characters (mostly English) and Arabic numerals. These need to be mapped to Devanagari characters and numerals. The original dataset contains ~50 duplicates which need to be cleaned.
Following the above steps, I have created new splits of the dataset (link here) which can be used for properly reporting scores on the Classification dataset.

Apparently all of the datasets in iNLTK don't have a separate test set and the accuracy is reported on the validation set. The models provided are chosen based on this validation accuracy. This may cause inefficiency in model generalization. Opening this issue there.


Fix makefile so project can be compiled on Ubuntu

Hi, sorry for the delay! Looks good, I'll merge it. Thanks!


[QAB] Couple of incorrect icons in use on the quick action button since global create changes

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v1.4.69-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1714588836539229?thread_ts=1714400587.768059&cid=C036QM0SLJK
Action Performed:

Go to global create > Submit expense > manual > pick a workspace > confirm
Reopen global create
Observe the icon of the Submit expense quick action button

Expected Result:

submitManual should use the same icon as Submit expense in the "main" global create menu:
trackScan should use the scan icon (just like submitScan)
trackDistance should use the car icon (just like submitDistance)

Actual Result:

submitManual is using the old icon for Request money

trackScan is using the stacked coins icon of Track expense

trackDistance is using the stacked coins icon of Track expense

Workaround:
N/A
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
See actual results above in-line
View all open jobs on GitHub

Merged awaiting a deploy!

This is done, closing!


Add more layers of flows for Pipeline

The current state of flow_of_flows allows for two layers - extracts and transforms.
While adding extracts and transforms is widening the graph, we would like to have a functionality that allows for another layer, making the length bigger.
Current version looks like this:

What we need:

What's the new layer? There is no other step in ELT than these two.

don't we already have a flow for thart? CopyADLStoADLS or sth like that?

Correct me if I'm wrong, but all I found was:
To ADLS:

CloudForCustomersReportToADLS
SharepointToADLS
SupermetricsToADLS
CloudForCustomersToADLS

ADLS to:

ADLSToAzureSQL


docker-compose file is not present in version 0.1.0

docker-compose.yaml is not present in the released version /v0.1.0

I can tag a new version once you've verified that it works for you

Super. Will test this weekend


PATRIC RNA fasta file on ftp site is obsolete

A user was describing his problem to me.  He wants to get all the small subunit RNAs for all bacteria.  To do this he went to the ftp site, into patric_rna and what he found in there was sequences with the old vbi locus tag.  He needs peg ids as he needs to have the genome id imbedded in the locus tags.  This file on the ftp site needs to be updated with the peg ids.

All the frn files have been updated after we migrated to the new identifier scheme
last year to have patric/peg ids.
Please make sure user is getting the fern files from the current release directory on FTP,
and not PATRIC2 achieves:
ftp://ftp.patricbrc.org/patric2/current_release/frn/ ftp://ftp.patricbrc.org/patric2/current_release/frn/

On Oct 17, 2015, at 7:58 AM, ARWattam<EMAIL_ADDRESS>wrote:
A user was describing his problem to me. He wants to get all the small subunit RNAs for all bacteria. To do this he went to the ftp site, into patric_rna and what he found in there was sequences with the old vbi locus tag. He needs peg ids as he needs to have the genome id imbedded in the locus tags. This file on the ftp site needs to be updated with the peg ids.
—
Reply to this email directly or view it on GitHub https://github.com/PATRIC3/patric3_website/issues/527.

Gracias, Senior Shukla


fix: modal component

fix below error and tiny stuff
ERROR in /Users/hiroaki_yamashita/workspace/herodotus/herodotus-ui/src/components/Search/SearchResult.tsx
[tsl] ERROR in /Users/hiroaki_yamashita/workspace/herodotus/herodotus-ui/src/components/Search/SearchResult.tsx(198,9)
      TS2322: Type '{ children: Element[]; title: string; isOpen: boolean; onRequestClose: () => void; footer: Element; }' is not assignable to type 'IntrinsicAttributes & ModalProps & { children?: ReactNode; }'.
  Property 'isOpen' does not exist on type 'IntrinsicAttributes & ModalProps & { children?: ReactNode; }'.

Artifact can be viewed here: :
https://34-280051086-gh.circle-artifacts.com/0/packages/components/storybook-static/index.html

Artifact can be viewed here: :
https://35-280051086-gh.circle-artifacts.com/0/packages/components/storybook-static/index.html


If Docker is not installed, explain how to install Docker

Cog depends on Docker to package models. The installation instructions in our docs specify that installing Docker is a prerequisite to using Cog, but it is still possible to install Cog without installing Docker. Let's update the cog CLI to check whether Docker is installed, and exit with a helpful error message if Docker is not installed.
edited by @zeke

Is this still needed?


Error: Im trying to execute but gives error

While i execute, it gaves me this error :
C:\Users\Usuario\Desktop\TFG\Mapping\ComunidadMadrid\Meteorologicos>python3 -m morph_kgc config.ini
INFO | 2023-05-15 20:30:31,803 | 21 mapping rules retrieved.
INFO | 2023-05-15 20:30:31,881 | Mapping partition with 14 groups generated.
INFO | 2023-05-15 20:30:31,881 | Maximum number of rules within mapping group: 5.
INFO | 2023-05-15 20:30:31,881 | Mappings processed in 4.157 seconds.
multiprocessing.pool.RemoteTraceback:
UnboundLocalError: local variable 'data' referenced before assignment

Please, provide more details, such as the version of morph-kgc nd mappings.


improving testing experience

Better documentation

Coverage remained the same at 88.492% when pulling f068583f125706b8dd3a3b124baa3a00878818f1 on cash:improve_testing into ae5e0e117342faa0fc3396e46379b41e6ca14391 on ACI-ESP:master.


How to get fields's values within a state in the Flow Structure?

So far, rules work, but I can't actually get data to pass it back to the system upon rule execution within Flow Structure

Oh, we should use context:
print(c.m.subject) instead of print(m.subject)
within method that executes the rule when it's correct:
        @to('license_invalid')
        @when_all((m.kind == 'licensePlate') & (m.validBy < m.dateDetected) & (m.subject != None) & (m.vin != None))
        def request(c):
            print ('Car license plate "' + str(c.m.subject) + '"is no longer valid. Requesting ticket.')


Resume fetch after failure

Initially reported on https://github.com/coreos/rkt/issues/1280:

If a fetch is interrupted by a crash or by power loss, it currently must completely start over the download. It would be great if it at least stored layers, if not resumeable bytes like a basic program like wget.

this may be possible with the docker v2 registry only (since it supports the Range header when pulling layers).


Occurrence -1 does not work as intended

Highlighting with occurrences  does not work with the repeated words.

also does not highlight if it has ellipsis.

[  ] Write tests for the broken functionality
[  ] Identify broken logic/implementation
[  ] Create fix and test with ui, document code
[  ] Fix unit test

Test case: Highlights to show when there are multiple occurrences of a word.
for eg. Judges 1:3 has two occurrences of Simeon. when the OriginalQuote is copied and pasted, the highlight does not show currently , neither does the Occurrence show up.

Should be addressed with build 8.

This behavior should now give no highlights

Verified on https://develop--tc-create-app.netlify.com/

Beta-13. This works as expected. By having an ellipsis and -1 does not highlight.


Develop

Checklist

[x] npm test passes
[x] tests and/or benchmarks are included
[x] documentation is changed or added
[x] commit message follows commit guidelines

Affected core subsystem(s)

Description of change

refactor react server side render for latest egg-view plugin.

目前只简单提供render功能和暴露react engine， 如果要满足完整的项目需求，需要支持doctype，js/css等资源依赖问题，建议基于egg-view-react 扩展出解决方案，比如egg-view-react-ssr，目前实现了egg-view-react-ss

cc @popomore 也看看

@atian25  发布1.0 吧

1.0.0 !


Project lifespan

The redaction feature is essentially a "medium-delete" per UF #819. That issue has been open ~5 years, and put in "long-range planning" a few years ago. This sprinkle is my effort to provide an alternate starting point in the meantime. Redaction here will likely be deprecated whenever that issue is closed, depending on how exactly it's handled.

The "self-termination" button may have a different lifespan. Whether a single button is useful as a separate sprinkle may be up for debate.

The "self-termination" button may have a different lifespan. Whether a single button is useful as a separate sprinkle may be up for debate.

UF5 doesn't have a self-delete button yet, and I think it would still be useful for others.
"Medium-delete" may be on UF's 5.1 milestone, but until it's actually live-and-working I will keep redaction here.


Updated APIs in the provided started code to match Swift 3 style

I also re-indented all the changed files, since a bunch of them were way off.
@vokal/ios-developers code review please?

Sure

@bryanluby improved the naming of some methods, and also dropped our Swift 3 templates for mogenerator: the ones in mogen are very similar but cover some edge cases ours didn't.

@bryanluby ok NOW all my changes are here. Sorry about that.

I miss you guys 😘😘😘😘

@scottferg lets do another extralife


Smarthome node Appliance/Group selection not working

Hello,
Let's start with the end : everything I tried works except the smarthome part of nodes. I'm using it like this for my tests :

With the smarthome node I have this error : "smarthome entity not found: """
And with the routine smarthome : "could not find smarthome entity: "undefined""
In the config tab of smarthome node I have this :

Thanks for this addon !

I get the same thing, burned heaps of time on it.

What do you see in your browser's Developer Tools console when you open an Alexa Smarthome config?

What browser is this? Does it behave the same way in Chrome/Firefox?

I'm not home, but I was using firefox on Linux, and nodered is runing as a homeassistant (hassos) addon in the provided VM by home assistant. I'll tell you what's in the console tonight ? (in 9 hours or something) ^^

I have tried chrome, edge and Firefox. Not at home to check either though
Sent from Ninehttp://www.9folders.com/

From: 586837r<EMAIL_ADDRESS>Sent: Friday, 2 August 2019 6:20 pm
To: 586837r/node-red-contrib-alexa-remote2
Cc: lukefairbank; Comment
Subject: Re: [586837r/node-red-contrib-alexa-remote2] Smarthome node not working (could not find smarthome entity "undefined") (#35)
What browser is this? Does it behave the same way in Chrome/Firefox?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/586837r/node-red-contrib-alexa-remote2/issues/35?email_source=notifications&email_token=AGEF6WYFLGDGWCURRPIL3WTQCPU4PA5CNFSM4IIK2T22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NBBFA#issuecomment-517607572, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGEF6W22TFC2PKFRXAHLZ73QCPU4PANCNFSM4IIK2T2Q.

Okay I got this for an Alexa Smarthome action :

Please make sure that XHR is enabled in the console filters. (response is interesting)
Do you get an error notification at the top of the page when you open the config?

Oh okay sorry. I get a 404 :
URL de la requête :http://<IP_ADDRESS>:8123/alexa-remote-smarthome.json?account=<account.id>
Méthode de la requête :GET
Adresse distante :ip:port
Code d’état : 404
Version : HTTP/1.1

Response header :
HTTP/1.1 404 Not Found
Content-Type: text/plain; charset=utf-8
Content-Length: 14
Date: Fri, 02 Aug 2019 23:13:34 GMT
Server: Python/3.7 aiohttp/3.5.4

Are you running 3.0.6? It has fixed a 404 error (#34)

Fixed … Since I installed a less than a week ago I didn't think there was already an update.

I'm still having this issue with the most recent version. When I click Get Entities, it lists all my Smarthome Devices in the message output. However, there's doesn't seem to be a way to apply an Action to an Entity as far as I can tell.

@Dakyne Nice! No worries.
@mobamoba What exactly is wrong? Can you not select an entity in Alexa Smarthome node with the Action option? Is the "Note: Select an initialised account..." still showing?

My account is initialized and Routines, for example, work fine. I can't select an Entity in Alexa Smarthome. I get the same ??? options as in the screenshot in the initial post.

If you don't see the "Note: Select an initialised account..." then either there is an Error while initialising the internal smarthome entities structure or you simply don't have any entity that supports at least 1 action.
Do you get a warning while the account is initialising? (You can trigger an initialisation with Alexa Init).
You can look at the internal smarthome entities structure with a flow like this to see what entities have what actions:
[{"id":"e970fc13.85c32","type":"inject","z":"c0bfc064.e8d26","name":"","topic":"","payload":"","payloadType":"str","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":850,"y":200,"wires":[["fe8092e8.4f02f"]]},{"id":"912e5561.093b68","type":"debug","z":"c0bfc064.e8d26","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"payload","targetType":"msg","x":830,"y":320,"wires":[]},{"id":"e830f205.fc31f","type":"function","z":"c0bfc064.e8d26","name":"","func":"function map2obj(map) {\n    return Array.from(map.entries()).reduce((o,[k,v]) => (o[k] = v, o), {});\n}\n\nfunction isMap(o) {\n    return typeof o === 'object' && String(o) === '[object Map]';\n}\n\nif(isMap(msg.payload)) {\n    msg.payload = map2obj(msg.payload);\n}\n\nreturn msg;","outputs":1,"noerr":0,"x":850,"y":280,"wires":[["912e5561.093b68"]]}]

Sorry meant to say: I saw the select initialized account and selected the one I'd already initialized.  My result looks just like the screenshot in the first post, i.e. an initialized account selected the ??? in both lists.
I get no warnings and account works perfectly fine. I'm using right now to trigger Alexa routines.

The ??? is not an error in of itself. If you don't have any smarthome entity with at least 1 action then you will see ???.
You can check the internal structure with the flow i posted before to check if you have an entity with an action.

I'm not sure what you mean by that. Perhaps I'm misunderstanding something: I have 3 Alexa smart plugs and want to be able to turn them on and off via Node Red. When I do a complete msg output from Get Entities, I can see my smart plugs listed there in various arrays. Where would they show up such that I could turn them on or off? Thanks.

You should be able to select a smarthome device where you currently see "???".
Just to debug it would be interesting what the smarthome "Simplified" structure looks like.

Sure - here's the output of Get Simplified:
msg : Object
object
payload: object
empty
_msgid: "2fb07cd0.5cdac4"

By contrast, here's what I see for Get Entities (I picked the first plug rather than cut/paste the whole thing):
msg : Object
object
payload: array[5]
0: object
id: "66003d9c-4b37-4891-b18f-7909a2d40616"
displayName: "Trunk Lamp"
description: "Amazon Smart Plug"
supportedProperties: array[2]
0: "turnOff"
1: "turnOn"
supportedTriggers: array[0]
supportedOperations: array[2]
0: "turnOff"
1: "turnOn"
availability: "AVAILABLE"
icon: object
value: "SMARTPLUG"
providerData: object
enabled: true
relationships: array[0]
categoryType: "APPLIANCE"
deviceType: "SMARTPLUG"

Please get the simplified with this flow:
[{"id":"e970fc13.85c32","type":"inject","z":"c0bfc064.e8d26","name":"","topic":"","payload":"","payloadType":"str","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":850,"y":200,"wires":[["fe8092e8.4f02f"]]},{"id":"912e5561.093b68","type":"debug","z":"c0bfc064.e8d26","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"payload","targetType":"msg","x":830,"y":320,"wires":[]},{"id":"e830f205.fc31f","type":"function","z":"c0bfc064.e8d26","name":"","func":"function map2obj(map) {\n    return Array.from(map.entries()).reduce((o,[k,v]) => (o[k] = v, o), {});\n}\n\nfunction isMap(o) {\n    return typeof o === 'object' && String(o) === '[object Map]';\n}\n\nif(isMap(msg.payload)) {\n    msg.payload = map2obj(msg.payload);\n}\n\nreturn msg;","outputs":1,"noerr":0,"x":850,"y":280,"wires":[["912e5561.093b68"]]}]

And you can copy the output with this button:

Imported your flow and inserted Smarthome Get Simplified with my account chosen between the Inject and the Function and go nothing:

I have the same issue on 3.0.6 and have run the flow you provided above. I also get the empty message as above.

Are you sure that you don't get a warning like

in the console when initialising?
In any case you can send me the output json of Smarthome Get Devices and Smarthome Get Entities so i can see where it fails. You can send it directly to my email.

Is there private information in either of those? If not I'm fine posting here if that's easier.

I received the same error message in the NR debug window: "could not find smarthome entity: "undefined""
It occurred immediately after a re-auth was performed (the nodes asked me to go to the proxy URL to grab a new cookie).
The re-auth reported success and cookie was saved, but then all applestrudel nodes failed to work and I saw the same empty entity list "???" reported above. I deleted the cookie and retried with same error result.
I have a second Amazon account (my wife's) that was assigned to 2 nodes and working, so I copied that cookie to the path for the non-working login and all the nodes resumed to function.


Update README.md

Added some texts.

:-D
Thank you @Himanshu9430

Most welcome 😉
On Thu, 1 Oct, 2020, 12:24 am Viktor Szépe<EMAIL_ADDRESS>wrote:

Merged #5
https://github.com/szepeviktor/wordpress-plugin-construction/pull/5
into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/szepeviktor/wordpress-plugin-construction/pull/5#event-3825981094,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGZ5AKA4SQ7GWRMYBLODXA3SIN5HLANCNFSM4R7OKWGA
.


Fix clippy warnings pr

Addresses #45

Fixes clippy warnings about unnecessary vec![] and Arc<RefCell<..>>
Applies cargo fmt

With this patch applied, both these commands run cleanly:
$ cargo clippy --all-features --all-targets
$ cargo fmt --check

Notes:

running cargo version 1.72.0 (103a7ff2e 2023-08-15)
Changed all occurences of Arc<RefCell<..>> to Arc<Mutex<..>>.  These were only in the Dashboard.

Testing:

Verified that Dashboard runs and navigated all screens
ran cargo test without error

Yeah. Since the dashboard has a polling thread and is apparently multi threaded, I guess we need Arc and not just Rc there.
The rest of the commits I consider uncontroversial. Thanks for fixing this though.


JSDoc needs better JSDoc comments

JSDoc's API documentation is woefully deficient, the irony of which does not escape me. I made the problem much worse by adding dozens of // TODO: docs comments during my JSDoc 3.3 blitz through lib/jsdoc/src.
We should at least have proper documentation for the methods exported by each module. We should also make sure that the docs reflect someone's (my?) idea of JSDoc best practices (for example, "put an asterisk at the start of each line").

I can do some work on this.


["Feature promo - text"]

This component is fresh off the press on March 3rd. Design is reviewed. Next steps include:

[x] final spec sketch & PDF https://ibm.box.com/s/tqp7c0wm99ha0b7jrm0sqhq3whwdjv84
[ ] naming
[ ] func spec
[ ] hand off to development

Notes (updated Mar 15):

Component: 12 col promo text block, to be delivered wrapped in "Content section"
optional heading-01
min 1 CTA

@shixiedesign Is a design issue needed or will you post the designs into the Box folder and include the link in this epic?

Oof how did I miss these github comments for 12 days -
@RobertaJHahn the design spec boxfolder is updated in issue description, also here https://ibm.box.com/s/tqp7c0wm99ha0b7jrm0sqhq3whwdjv84
@photodow your comment above might totally apply any more but some agreed is what I'd expect: leveraging content group and link list. I think we'd also need content section for the heading-01. Lemme know your latest thought.

@photodow your comment above might totally apply any more but some agreed is what I'd expect: leveraging content group and link list. I think we'd also need content section for the heading-01. Lemme know your latest thought.

Yeah I tend to agree here, most of the questions above I believe got addressed over slack.


Tree Item "disabled" styling does not update immediately

ISSUE LINK: https://github.com/mui/material-ui/issues/33011
The issue is caused by the useRef nature of the nodeMap in TreeView component.
I think the issue arises due to the following flow.

disabled prop is updated to true
Entire Component tree is rendered. The TreeItemContent uses the old value from the nodeMap.
useEffect is then run where it ReRegisters the component.
No state update happens after that. The TreeItemContent never rerenders to disabled state

Proposed Fix: Force rerender on disabled state update

[x] I have followed (at least) the PR section of the contributing guide.

@samuelsycamore need reviews on this too

Closing the PR. See https://github.com/mui/material-ui/issues/33011#issuecomment-1198011611.


Protest against silencing of community by locking issue #478

The maintainers 4min ago locked issue #478 as "too heated".
Nothing heated was going on, it was simply the community discussing reasons what the root issue and the reasons for it were.
The discussion started going in a direction that wasn't pleasing the maintainers/SAP so the discussion was locked - without comment nor warning. This is totally against the spirit of the project.
I'm opening this issue to continue the discussion.

Update: this is the statement from the maintainers

It's not clear what the profane language was. "Clusterf*ck?"
Again, it's not explained how anything said was against the Code of Conduct. No discussion with the community.
If someone is contravening the code of conduct, it's the maintainers. I am writing a request to investigate the silencing of the community.
@piratenkatzerr, @fhajji, @arianvp @dalbre, @treysis, @sschuldenzucker

@corneliusroemer I do not think this is a very constructive way to make this point and I do not want to be associated with this discussion further.
I think we made pretty clear what the problem is, and what the solutions are, and we can now wait for a solution to come.
Locking a thread when the tone of the discussion is getting grim is something that's in their right to do especially when the signal-to-noise ratio of an issue starts to get big.  My two cents as an open source maintainer.

I think their reaction is totally fine. They are probably just communicating with the RKI and Google to get the app available in more countries. Also every comment that doesn't help to resolve a discussion just notifies all watchers.

@mohe2015 Just unwatch then...
While I agree everything has been layed out, I don't agree with the behavior of quickly locking what could result in bad press. Anyway, I think this is all that I can contribute to this issue for today and I will just silently monitor the progress for now.

A suggestion for maintainers: maybe you could set up discord / slack channels for free-for-all, open, wild-west and heated discussions.
Regarding legal requirements, I think discussing whether there is a legal requirement or not may be even constructive for solving these problems, since I'm sure community would start to dig into German law to determine it quickly and perhaps could support you with findings. We are not only developers / users, I'm sure we'd find some lawyers among ourselves as well.
But I agree that such heated discussions on GitHub issues may be counter-productive, overwhelming, and sometimes violating code of conduct - that's why it's common to have a project discord / slack for such discussions - it would keep GitHub issues temperature much lower!

@fhajji in his comment raised a good point
https://github.com/corona-warn-app/cwa-app-android/issues/478#issuecomment-645385879
It's important to know the details so that we can lobby in the right direction.
Is it in the contract that it's geo-locked? If not, what are the legal concerns raised by whom?
@arianvp made a very good point, that the Datenschutzfolgenabschätzung contains no basis to geo-lock. That makes it even more questionable what legal issues arose all of a sudden.
https://github.com/corona-warn-app/cwa-app-android/issues/478#issuecomment-645385599
By providing an update on what the precise issue is, the maintainers would enable us to lobby the right people to get this sorted quickly. Now we have to go very general instead.
The last update was yesterday evening, talking very broadly about "Special German laws". A more effective way to calm the "heated" discussion would be to update us so that we don't need to speculate.
@kbobrowski's idea of Slack/Discord is good for fast moving discussions. But I don't think the maintainers are agile enough to set it up - please convince me of the opposite!
Great point about the benefit of telling us what the legal problems are.
Violations of the code of conduct of individuals should not cause a lock on any issue as a whole. That's "Sippenhaft". The code of conduct is about individual behaviour.
Community leaders, a term which ironically is just a euphemism for SAP maintainer, should issue corrections for every violation and if appropriate ask for apologies/edits.
Locking an issue for everyone as "too heated" as a result of putative violations is not part of the code of conduct. So if anything, it may seem that the leaders are not following the code of conduct guidelines for enforcement.

@corneliusroemer Mimimi.

Yeah they were facing a lot of questions and complaints and they decided to address the language and one (minor) point of the discussion exclusively. Very strange and, again, feels like a populist exercise in reframing ("you can't say a bad word!!1" - and suddenly the content doesn't matter).
The maintainers could've tried to, you know, defuse the situation somehow. By explaining, reassuring people, providing some transparency. Like normal people do. Instead, they decided to just lock the issue. :(
They being said, I agree that while this discussion is important, a github issue is not the right place to have it.

@corneliusroemer apologies, if my usage of the word "clusterf*ck" have prompted the lock of #478.
I think it would be helpful if someone from SAP/(T-Sys)/RKI/BReg would simply state what legal issues need to get sorted out. Vaguely pointing to "special German laws" comes across as rather ominous and prompts more questions (as demonstrated) than it gives answers to. This is mostly about good community management and open communication.
Overall, maybe bring in someone from the press office of RKI or BReg to handle the communication on all issues that are less technical and involve more of a legal and/or political background/reasoning (to the technical problems that arise here). After all, RKI and BReg are the ones making those decisions anyways... let their comms professionals handle it...
(I guess, it's either IP rights or data protection/DSGVO/BDSG and whatever consequences might come form a distribution outside of "Germany". )
Regarding #478 comment, the DPIA does not explicitly require to geo-lock, buuuuut geo-locking is in sync with restricting access to the app to persons 16 or older. Or at least offloads the legal responsibility onto the Google Play Store since their terms and conditions state a minimum age of 16 for Germany. (Note: it differs between countries.)
(The CWA's age rating (IARC/USK) is set at 0 in the Google Play Store though.)
It's a great mystery. Looking forward to it being resolved. Eventually. Hopefully.

Dear @corneliusroemer ,
We highly value your passion for this topic and your contributions in the community. Nevertheless, we would like to highlight the code of conduct which explicitly mentions personal attacks as an unacceptable behavior.
You accused the maintainers of cover ups because they are not responding in your desired time frame. So, unfortunately, this leaves us no choice but to issue an official warning with this response.
Please note, that new issues going in the same direction which complain about this email response or about the closure of issue #600 will lead to a temporary ban immediately. Continued behavior that violates the code of conduct can also lead to further consequences for participating in this community.
We'd like to also inform you that the discussion was not closed because of individual code of conduct violations, but because discussions got too heated even after we already mentioned that we will take care of the issue and report back as soon as we can.
Best regards,
JB
Corona-Warn-App Open Source Team


Should GitHub Pages be disabled for this repo?

This repo is deploying to suffolklitlab.org/regex2csv, but there is no content other than the README.md. It looks like it probably needs to be fixed, or else GitHub Pages should be disabled.
@colarusso

Yes, and done


Add minReadySeconds support

wait for enough pods become "available" if minReadySeconds is set. minReadySeconds can help eliminate race condition between pod rollouts in our use case
https://kubernetes.io/blog/2021/08/27/minreadyseconds-statefulsets/

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add Tivat, Montenegro

[x] Add submodule
[x] Update README.md
[x] Update cities.json in https://github.com/EqualStreetNames/module-global/commit/93109acc863cab57ba0ed008b6389827d977e7f3
[x] Update package.json in https://github.com/EqualStreetNames/module-website/commit/6f57d03a2a397642a1d4e342d276315591e1e90b
[x] Create automated update in https://github.com/EqualStreetNames/equalstreetnames-tivat/commit/d7286f169961a5f41f3bdc009497108f22d01060
[ ] Add MAPBOX_TOKEN secret
[x] Create automated deployment in https://github.com/EqualStreetNames/equalstreetnames-tivat/commit/db01a48a6f1bc06126394ec172c2db6f85e17080

Close #615

@62mkv Let me know when you've added the MAPBOX_TOKEN secret and I'll finalize this PR.

@jbelien secret added


GHA: Remove {pre,post}-action steps for self-hosted runners

The following hooks:

ACTIONS_RUNNER_HOOK_JOB_STARTED
ACTIONS_RUNNER_HOOK_JOB_COMPLETED

could perfectly replace the existing {pre,post}-action scripts and will make a workflow independent of the runner context. This PR wipes out all GHA steps where the actions are triggered.
Signed-off-by: Hyounggyu Choi<EMAIL_ADDRESS>@AdithyaKrishnan please let me know when the runner for SEV/SNP is ready for this. I will ask for review when you guys are ready. Thanks.

Yep, those env variables seems to do exactly that so once the workers are configured it should be fine removing them here (as far as the {pre,post}_action.sh does not require some extra knowledge about the PR that wouldn't be available in the hooks but I think that shouldn't be the case, rigth?)

Yes, {pre,post}_action.sh does not depend on the workflow context. So it would be fine to simply remove them from the workflow. Thanks.

@BbolroC AMD SEV and SNP Coco runners are ready. Please go ahead


Document how to deploy

[ ] with Heroku (+ configuration)
[ ] configure it via application.conf
[ ] how to change template

@stmeissner add anything you consider necessary

this should cover the important things

Moved to starter project: https://github.com/commercetools/commercetools-sunrise-java-starter/issues/21


CI Tests

@loafyyy added a GitHub workflow, test-phen2gene.yml, that runs some end-to-end tests whenever someone makes a PR to master or pushes to master. The workflow is run on an Ubuntu VM with Miniconda and Python 3.6 hosted by GitHub, and it just goes through the steps in the README to install and setup up Phen2Gene. Then it runs the end-to-end tests using pytest; the tests just compare the actual output of Phen2Gene to the expected output (what she got when running it today) when running some of the examples listed on the README. She also added some shields to the README to make it look more legit. @MenggeZhao You may want to write some unit tests at some point in the test directory.
If any asserts fail in test_e2e.py you get a GitHub Actions failure and the build badge in the README will show that it failed. Code coverage badge from Codecov.io (not sure how accurate it is though).

thanks @loafyyy


fix workflow yml syntax

Yaml syntax was invalid workflow was not running.

Ok, merging so that the vendored code update is triggered tonight.


About Amazon Dataset

❓ Questions & Help

In the paper, pitfalls of graph neural network evaluation, the num_nodes of Amazon Computers/Photo is 13381/7487. However, the num_nodes of the two datasets is 13752/7650 when I use the function, Amazon of pytorch_geometric, to load the datasets. Why aren't these the same?

I'm not exactly sure what is causing this. We are loading the data directly from the gnn-benchmark repo.


GIve Owner Permissions to Mentorhip Champion

Hello,
We need to change the owner of the Mentorship initiative to the new champion @DavidGuttman
Thanks

@mhdawson can you add Label Agenda to this ticket please

Done


improve call structure and end-user usage

Combined variables and arguments into a single keyword list argument. Any calls of the format f.(arg_list, option_list) are now f.(arg_list).
Effects:

ExDiceRoller.roll/3 is now ExDiceRoller.roll/2
options are now passed via opts: [:keep, :explode, ...]
compiled functions have transitioned from f/2 to f/1
cache is no longer an option, but is instead it's own argument, see ExDiceRoller.Cache for more information and usage examples

Pull Request Test Coverage Report for Build 52

43 of 43 (100.0%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 50:
0.0%

Covered Lines:
193

Relevant Lines:
193

💛  - Coveralls


Create & test Tableau Datasource Customization (TDC) file

See documentation: https://onlinehelp.tableau.com/current/pro/desktop/en-us/odbc_capabilities.htm
Here is untested, community provided tbc file: clickhouse.tdc.zip

For the Tableau to recognise the TDC and to apply the customisations,
the  tag should be re-written as
<vendor name='ClickHouse' />

Some related links & issues:
https://github.com/ClickHouse/ClickHouse/issues/3830
https://github.com/ClickHouse/clickhouse-odbc/issues/166
https://community.tableau.com/ideas/6454 + https://www.google.com/search?q=clickhouse+site%3Acommunity.tableau.com&ie=utf-8&oe=utf-8

Please try TDC from https://github.com/ClickHouse/clickhouse-odbc/pull/226 and share your thoughts. Thanks.

official info have also some more info: https://help.tableau.com/current/pro/desktop/en-us/odbc_tableau.htm