ts-jest assumes it is an immediate dependency of the project being tested

Issue:
I noticed this warning while running ts-jest:
ts-jest[config] (WARN) Unable to find the root of the project where ts-jest has been installed.

It seems to be coming from this code:
  get projectPackageJson(): Record<string, any> {
    const tsJestRoot = resolve(__dirname, '..', '..')
    let pkgPath = resolve(tsJestRoot, '..', '..', 'package.json')
    let exists = existsSync(pkgPath)
    if (!exists) {
      if (realpathSync(this.rootDir) === realpathSync(tsJestRoot)) {
        pkgPath = resolve(tsJestRoot, 'package.json')
        exists = true
      } else {
        this.logger.warn(Errors.UnableToFindProjectRoot)
      }
    }
    return exists ? require(pkgPath) : {}
  }

Expected behavior:
This logic seems to assume that ts-jest was installed in the node_modules/ts-jest folder as a direct dependency of the project that is being tested.  This is not a reliable assumption in general.
For example, we use Jest in a monorepo with hundreds of projects.  It would be very cumbersome to add ts-jest and all the other tooling dependencies as a direct dependency of every single project.  Instead, we publish a toolchain package that brings along the compiler, test presets, Webpack configuration, etc.  Our projects depend on this toolchain package, instead of depending on the tools themselves.
I can simply ignore this warning, however I'm a little concerned that in some cases the check may succeed and load configuration information from the wrong project.  (For example, during upgrades we sometimes have multiple versions of our toolchain coexisting side-by-side in the node_modules folder.)
What is ts-jest looking for in the root of the project?  Is there a better way to discover this information?
@iclanton

Thanks @pgonzal, tho I'll close this as it's a duplicate of #823. But your detailed description will be useful when fixing.


Fixed very minor typo

Changed "an" to "and"

@ChristopherMank Thank you for your contribution, I am merging this now and it should be live soon. Thank you!


Order of rules matters when using url-loader and file-loader

Documentation Is:

[ ] Missing
[x] Needed
[ ] Confusing
[ ] Not Sure?

Please Explain in Detail...
I've been wrestling with an issue and crawling the web for hours.  I was in the process of documenting it as a bug when I discovered how to solve it.
I have file-loader and url-loader both configured to handle test: /\.(png|jpe?g|gif)$/I,, and url-loader has its limit set to 10KB.   url-loader works fine, but when images exceed the limit the file-loader picks them up as expected; however, it seems to ignore the configuration for how to name and output the images.   For each image, file-loader creates 2 files.  For example:
Input: src/my-path/image1.gif
Output-1: dist/my-path/image1.gif, but it's not really a gif.  Instead, it contains module.exports=afjhwheiueruiweroug.gif
Output-2: dist/afjhwheiueruiweroug.gif, which is the actual image
The problem: I had file-loader configured first followed by the url-loader configuration in my webpack config.
The solution: Set the url-loader rule before the file-loader rule.   In the correct order, images are output to the configured paths as expected, file name configuration is respected, and image files are actually image files instead of modules that reference image files.
Your Proposal for Changes
Make note that file-loader probably needs to be configured after url-loader.

Order of rules is not matters, please provide minimum reproducible test repo

Closing due to inactivity. Please test with latest version and feel free to reopen if still regressions. Thanks!


support handling join table between parentheses

Allow handling join tables in parentheses. It causes the JoinTableExpr to be wrapped in ParenTableExpr in the parser, so it needs to be unwrapped to get the JoinTableExpr inside
Fixes https://github.com/dolthub/dolt/issues/3254

Does this also fix dolthub/dolt#2203? It appears to be related. But please note that the parentheses have "semantics" and mustn't simply be ignored.

  It does fix this issue as well. Thanks for catching it!


Create a UI/UX Design for new Ticket Module

Describe the task
We introduce a new ticket module in Employee Portal. From where people can raise any issue or suggest any idea for a specific project. Users can create a GitHub issue from the page and link it to the ticket + Users can simply add the requirement in the description text field if they don’t want to create an issue for it currently.
Whenever a new Module Introduce then  prior we have to make a Plan and Create a UI/UX Design . We make a plan how the UI will look and we also have to keep in mind how the user will experience when user uses it.
Expected behavior
Make the design of UI/UX for Ticket Module and then share and discuss the design with @GauravGusain98
Make the design of Database schema of Ticket Module and then share and discuss the design with @GauravGusain98
Additional Context
You can use Online designing tools for that such as Figma, Miro etc.

@GauravGusain98 I have created this UI/UX Design. https://miro.com/welcomeonboard/Y1VPdHhxZnVrbTUyRXk0VkVRTnpFcDE0ak54UEhNUGVPSFFsc3FIcXBUWjFMcElSRTRuUU1nOG5EbTNvNUEyRnwzNDU4NzY0NTQ5MTMyMjg1MTQ0fDI=?share_link_id=895903478757

Dropdown of Ticket Module

Landing Page of Ticket Module

This modal will open on clicking in the New Ticket

This modal will open on clicking in the View

This modal will open on clicking in the Edit


feat: add plugin zentao

Pre-Checklist
Note: please complete ALL items in the following checklist.

[ ] I have read through the CONTRIBUTING.md documentation.
[ ] My code has the necessary comments and documentation (if needed).
[ ] I have added relevant tests

Description

Add zentao plugin, currently just deal with zentao installation.
For this implementation zentao application is deployed in a k8s cluster by client-go, later I expect to deploy zentao by Helm.
Implementation
1. create.go
Create zentao namespaces, persistentVolume, persistentVolumeClaim, deployment, service.

PersistentVolume use HostPath and in a single-node cluster now.
Service is exposed by NodePort.

2. delete.go
Delete zentao namespaces, persistentVolume, persistentVolumeClaim, deployment, service.

Perform the opposite operation of creation.

3. k8s.go
Some cluster-related operations
4. update.go
Just rebuild zentao deployment and service.
Options and configuration
Here needs more advice and consideration. I want to support different installation way in config files and use type field to indicate.
A simple example configuration file is as follows:
tools:
  # name of the tool
  - name: zentao
    # id of the tool instance
    instanceID: default
    # format: name.instanceID; If specified, dtm will make sure the dependency is applied first before handling this tool
    dependsOn: [ ]
    # options for the plugin
    options:
      type: "clientAPI"
      clientAPI:
        namespace: "zentao"
        storageClassName: "zentao-storage"
        persistentVolume:
          zentaoPVName: "zentao-pv"
          zentaoPVCapacity: "1G"
          mysqlPVName: "mysql-pv"
          mysqlPVCapacity: "1G"
        persistentVolumeclaim:
          zentaoPVCName: "zentao-pvc"
          zentaoPVCCapacity: "1G"
          mysqlPVCName: "mysql-pv"
          mysqlPVCCapacity: "1G"
        deployment:
          name: "zentao-dp"
          replicas: 3
          image: "easysoft/zentao:latest"
          mysqlPasswdName: "MYSQL_ROOT_PASSWORD"
          mysqlPasswdValue: "1234567"
        service:
          name: "zentao-svc"
          nodePort: 30081
      helm:

By the way, I am not particularly satisfied with the current implementation, I need more requirements and suggestions.
Please feel free to give me any advice you think would make sense, I would really appreciate it!
Related Issues

#508
New Behavior (screenshots if needed)

I used your code for a local test, and it can run well. It's good that you try to specify the deployment method through configuration. Documents can be completed. @hxcGit

/hold
I'll check the code again and add plugin docs.

It seems MySQL is a requirement for zentao. Do you think it's possible to install MySQL as well? @hxcGit @daniel-hutao @KeHaohaoke

@IronCore864 Yep, Zentao need MySQL.

For official images easysoft/zentao, zentao service and mysql service are all installed. https://www.zentao.net/book/zentaopmshelp/405.html
I'm not exactly sure what you mean. If we use a individual mysql service in another pod, we will need to modify some initialization scripts of the official image accordingly.

@KeHaohaoke @daniel-hutao  any good ideas?

By the way, the official image doesn't seem to work well in mac m1 arm. Please test in linux amd64 system.

How to reopen this pull request?

@KeHaohaoke @IronCore864  PTAL.

Zentao's official image integrates MySQL, so we discuss that we can use the official image first. That's ok. @hxcGit

@hxcGit thanks for this great contribution. I'll test it locally and get back to you ASAP.

Merging now, see discussions in Slack. Please contribute another PR to follow up on those discussions. Thanks for your contribution! @hxcGit


The fe310 PMU->cause.bits.resetcause value 0

Value 0 is not defined in the enumeration.
Apparently it corresponds to power up reset.

nope, according to Megan

The reset causes should be one-hots (so bit [0] indicates external reset, bit [1] indicates wdog reset, and so on). So I think the value 0 should be "undefined" or "unknown", which to me has a slight difference than "reserved".

renamed as undefined.

fixed on 2017-12-06


[WIP] Arithmetic circuit library subtractors

Summary
Implementing Twos Complement Subtractor
Details and comments
Tests are still missing

@Cryoris: I don't know the purpose of the classical arithmetic parts of the circuit library, but I think you might know the history.  This PR is old and never saw review, but is from around the time of some other modifications to the arithmetic library (esp #6470) - please could you judge if it's something useful that we should include, or close the PR if not?

Yeah this would be useful to have to complete the operations in the arithmetic circuit library 🙂
@ManjulaGandhi would you still be interested in pursuing this? Otherwise we can also close it and see if we can pick it up in the future 🙂

@Cryoris yes interested to complete this task.

I'm going to close this PR now due to lack of activity, but if @Cryoris and @ManjulaGandhi are committed to getting this actually merged, please feel free to re-open it.


Romantic Gateway Page Added Successfully

Add
Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #1334
Description
The "Romantic Getaway" web application is designed to provide users with a curated selection of serene and romantic destinations, perfect for planning memorable trips with their loved ones. The application offers a simple, visually appealing interface where users can explore various romantic locations, read brief descriptions, and visualize their ideal vacation.

Type of PR

[x] Bug fix
[x] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
Before
https://github.com/user-attachments/assets/fd584534-de76-4ea0-ac0d-f9931a2087d1
After
https://github.com/user-attachments/assets/04a807f1-0d83-4e4f-9267-413fb7511952
Checklist:

[x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@pc-daukiya

Please see the conflicts . Resolve the conflicts


review and document all the Helm values in values.yaml

some helm values are commented out. for example:
https://github.com/cilium/cilium/blob/c068a443049b5dedb34608069df4b1721b1e4669/install/kubernetes/cilium/values.yaml#L329-L335
these commented out values do not get included in the auto-generated README.md, which makes it difficult to know all the available configuration options.
the goal of this issue is to review and document all of these commented out helm values 📝

@nbusseneau can you take a look?


can't set minsize

Example for cluster create shows "--minsize 2".
Is that only available on cluster creation? If i try to update my cluster with "--minsize 2" it says that is only available to the provider ;-)
If not fix the example please :-)

To be able to set minsize you must be member of the provider team. The reason is that the accounting model does not work on machines, instead consumed container resources are accounted. If you need more resources, the cluster autoscaler will add additional worker nodes depending on the resource demands up to specified maxsize.

I figured as much. We are replacing an existing cluster that has set a minsize (that one was provisioned for us) so i tried to set up the new one pretty much the same and stumbled over the minsize. The old cluster only had csi-lvm storage class available, so having more than one node was important for our DB cluster. With the replacement cluster we are switching over to the new partition-* storage class anyway :-)


GSE3 broken

When can the community of users expect an update for the 10.0.7 game version of Jan. 24th?
Its completely broken and does nothing.

as 10.0.7 hasn’t been released and 10.0.5 was just released I’m not sure what you are wanting here.
As for the does nothing I suggest starting with the https://github.com/TimothyLuke/GSE-Advanced-Macro-Compiler/wiki/ActionButtonKeyDown-or-ActionButtonKeyUp-and-Why-this-matters---Macro-Cycling-not-firing
As this is neither a bug report nor an enhancement (neither template has been submittted) I will move this the discussion area.  The templates (from when you hit New Issue) ask for a bunch of information needed to troubleshoot and solve your issue.


2019.2.1-Hotfix: Enhance Bb LTI to be a MVP

See #1424

This has been cherry-picked into hotfix/2019.2.1.
I will smoke test the integration and it needs to pass the CI checks before closing.

Smoke test looks good.

CI builds are good :+1:


MudThemeProvider: Add ObserveSystemThemeChange

Description
Fixes: https://github.com/MudBlazor/MudBlazor/issues/9437
See comment: https://github.com/MudBlazor/MudBlazor/issues/9437#issuecomment-2236254496
How Has This Been Tested?
bUnit, manually
Type of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

The docs should be fixed as well.
Now, when you switch the theme to light mode but have a dark system preference, the print will not switch the theme.
If you have dark mode and a light system preference, it will also not switch.
If you set the theme to auto in the docs, it switches according to your system/browser preference, and the print page will also not trigger a theme change as it is already in your preference mode.

Thanks!

Hmm, after merging it occurred to me that ObserveSystemThemeChanges would be better than ObserveSystemThemeChange


Fix spelling mistakes

Corrected spelling "producedures" -> "procedures"
Removed duplicate occurences: "with with" to "with", "the the" to "the"

Thanks for the PR! Can we send you some LBC in appreciation?


Fields suggestions in the where clause text box

Is your feature request related to a problem? Please describe.
you need to remember the exact name of a field to write it in the where text box
Describe the solution you'd like
In the where text box show field names suggestions
Additional context
Must be done in a good way so that it does not interfere with the where text writing.

Uses now a component called Autocomplete, which is a Textfield that shows a popup with the column names by the text caret.


MediaElement-Markers: A plugin for MediaElement.js

I have created a small plugin for MediaElement.js that lets you add Visual Cues in the progress time rail.

Here is a small working demo for the same.
I would like to add it to the MediaElement main repository. Is it a welcome request? If yes, please let me know I will send a pull request for the same.
Thanks,
Harshita

@hkasera Thanks for the work on this. Just submit a PR so we can review this. Thanks.

@ron666 Sure, I will send one as soon as possible. Thank you!

@hkasera You are welcome. Closing this issue now in favor of a PR


Are AMD GPUs usable?

Hello there, thank you for this amazing repo. Saw mention only of Cuda, are AMD GPUs supported as well?

Thanks for your interest and kind words about this repo.
I apologize that I am not an expert in ML programming on AMD GPUs (because I don't have one😥), so I cannot provide help or support on inference code or packages on AMD GPUs.

I use it with ROCm and PyTorch 2 and it works.

@Plachtaa very sorry for the delayed response, no worries at all, this repo is already amazing as it is plus @serhii-nakon mentioned it works on AMD. Thank you for you for this repo!

@serhii-nakon thank you! Excited to try it out

It does not seem to use my gpu cores
can you help me?
@Plachtaa @Silfalion

HELP :(


Add visual test for two position vertex buffers pointing to same buffer

This test is currently failing in native. Adding to JS to make sure we have the same coverage on both sides.
https://github.com/BabylonJS/BabylonNative/pull/1376 is a potential fix for native, but it causes the buffer to be retained on the CPU. The right thing to do is to fix it like we did for WebGPU.
I will be adding this test to native also.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15074/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15074/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15074/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15074/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15074/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15074/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15074/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15074/merge#BCU1XR#0

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15074/merge/testResults/webgpuplaywright/index.html

WebGL2 visualization test reporter:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15074/merge/testResults/webgl2playwright/index.html

set to auto-merge, i prefer waiting for @Popov72 to approve :-)


[ja] Update content/ja/docs/concepts/overview/components.md file

There are several updates in the original English text and therefore this page is outdated.
This PR updated Japanese translation for the /content/ja/docs/concepts/overview/components.md file.
Fixes https://github.com/kubernetes/website/issues/38544

/assign @nasa9084
/cc @atoato88 @t-inu
Hi! I've updated Japanese translation for the /content/ja/docs/concepts/overview/components.md file, would you mind checking if everything looks alright at your convenience time please? Here is the original English text and thank you so much!

The title of this PR says "Update /content/ja/docs/concepts/services-networking/ingress.md", but the file updated is "content/ja/docs/concepts/overview/components.md".
Is this right title?

/retitle [ja] Update content/ja/docs/concepts/overview/components.md file

@atoato88 I just modified the title and thank you so much for your comment!

/approve

/lgtm


[post-0.7.24] Fix runWorkerTaskH when called outside of a task.

This fix has revealed some issues in the libev and libasync back ends and needs to be postponed to the next release.

I tried to reproduce this but I'm getting linker errors for libasync on windows.. might need one last patch

Hm I tried fixing this and it's going to take a little time. I'll check back on it later.

Do you have a rough idea of what goes wrong/needs to be changed? I'd like to include this on master and either fix the failing drivers, or add assertions/skip tests for them.

Last I checked I stopped at the thought that it's a runWorkerTaskH ambuiguity in the recursion (after fixing the driver error). I think it's that template parameter inference causing issues the way they're nested.

Tests finally pass now after fixing the libev driver. The libasync issue seems to have gone, too.
(the failure is just due to a Travis internal issue)


added support for reuse of existing snackbars created on the fly

Found problems trying to use snackbarjs with angularjs single page applications and creating snackbars on the fly. It would not handle resuse of existing snackbars very well.. always came out with default options with content set as "undefined".
These changes provide support to create snackbars with specific ids using javascript and will remember the options data-content, data-timeout, data-style, and data-htmlAllowed when you show, hide, or toggle snackbars on the fly.
It will also not flash (quickly show/hide) a snackbar if it was already open when you action a "show".
These changes give the ability to call existing snackbars to show again and if they are already showing, to only move to the bottom of the stack snackbar stack and not flash off screen.

merged, sorry for the delay


Website error

Hello. Help with an error on the site, after entering / lp editor, I go through the site and write
"LuckPerms
Web Permissions Editor
There was an error loading the data. Either the URL was copied wrong or the session has expired.
Please generate another editor session with / lp editor. "
Screenshot - https://imgur.com/a/k9NtILb

This could be due to a variety of reasons:

your browser has an extension blocking the connection to bytebin (where the data is stored and read from). Try using another browser or private browsing mode
your computer could have an anti-virus preventing the connection to bytebin. Disable your antivirus or try and use another device (another PC or mobile) to load the page
your internet connection (ISP) could be blocking the connection to bytebin. Try using another wifi network if possible or use your mobile data to load the page

Hopefully this helps. Nothing we can do about it unfortunately.

This could be due to a variety of reasons:

your browser has an extension blocking the connection to bytebin (where the data is stored and read from). Try using another browser or private browsing mode
your computer could have an anti-virus preventing the connection to bytebin. Disable your antivirus or try and use another device (another PC or mobile) to load the page
your internet connection (ISP) could be blocking the connection to bytebin. Try using another wifi network if possible or use your mobile data to load the page

Hopefully this helps. Nothing we can do about it unfortunately.

This could be due to a variety of reasons:

your browser has an extension blocking the connection to bytebin (where the data is stored and read from). Try using another browser or private browsing mode
your computer could have an anti-virus preventing the connection to bytebin. Disable your antivirus or try and use another device (another PC or mobile) to load the page
your internet connection (ISP) could be blocking the connection to bytebin. Try using another wifi network if possible or use your mobile data to load the page

Hopefully this helps. Nothing we can do about it unfortunately.

This could be due to a variety of reasons:

your browser has an extension blocking the connection to bytebin (where the data is stored and read from). Try using another browser or private browsing mode
your computer could have an anti-virus preventing the connection to bytebin. Disable your antivirus or try and use another device (another PC or mobile) to load the page
your internet connection (ISP) could be blocking the connection to bytebin. Try using another wifi network if possible or use your mobile data to load the page

Hopefully this helps. Nothing we can do about it unfortunately.

@kolia22871 we just made a change to the website that may improve the issue, can you please try again and see if it works?

@kolia22871 we just made a change to the website that may improve the issue, can you please try again and see if it works?

@Turbotailz just a second

@Turbotailz just a second

@Turbotailz Doesn't work anyway

@Turbotailz Doesn't work anyway

Did you try any of the options I mentioned before?

Did you try any of the options I mentioned before?

@Turbotailz I'll try another internet right now

@Turbotailz I'll try another internet right now

@Turbotailz I tried from my phone and from another internet

@Turbotailz I tried from my phone and from another internet

Could you send an editor link?
What version of LP are you running?

Could you send an editor link?
What version of LP are you running?


add sitemapsPath to the final URL in the sitemap index

Let the base URL parse the relative paths, and add a slash to the end of sitemapsPath to make sure it will not be ignored.
This fixes sitemap URLs ignoring sitemapsPath var ex: http://example.com/sitemap.xml instead of  http://example.com/sitemapsPath/sitemap.xml

thx


Always verify client's SSL certificates

Fixes issue https://github.com/itsmrwave/pesapal-gem/issues/19. See commit message in 29fb90b for the details.

@mogetutu What do you think?


Fix alembic auto-migrations

Closes #61
The issue here was that Alembic didn't patch an operations instance, which meant the operations in from alembic import op weren't able to run successfully. (Alembic does this weird thing where the operations are all added to the globals dynamically with a Operations instance being proxied by patching it first, it's really weird and complex...)
Such small change, yet so annoying to figure out
(The reason i didn't catch this in #35 is because I only tested it with empty migration files that didn't actually do anything.)

Lgtm from GitHub mobile


Version 2.1 not signed for GateKeeper

Version 2.1 of icns creator is not signed for GateKeeper.

It's a headache to get verified by the Apple dev portal. You can find install instructions in the tutorial video in the readMe document.


Document BuildKite Service

Access URL, administration, passwords, etc.

Instance at: https://buildkite.com/organizations/tbd-oss/analytics
Until SSO is enabled:

Users must be added manually for now: https://buildkite.com/organizations/tbd-oss/users

Documented in Notion


cache.js:62-64: If status=cacheOnFail and existing cache,...

The puzzle 1-8ece321e from #1 has to be resolved:
https://github.com/andrewshell/fedwikifeeds/blob/5d05106e849c85babcb29a57d023eac7144e90cc/test/cache.js#L62-L64
The puzzle was created by @andrewshell on 13-Feb-22.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 1-8ece321e has disappeared from the source code, that's why I closed this issue.


SHA256 are invalid key identifiers for Droplet creation

I ran the latest code under osx and it is still need to use below scripts to generate signature
export TF_VAR_ssh_fingerprint=$(ssh-keygen -E MD5 -lf ~/.ssh/id_rsa.pub | awk '{print $2}' | sed 's/MD5://g')

Or I'll get output like:
Error creating droplet: POST https://api.digitalocean.com/v2/droplets: 422 SHA256:<key> are invalid key identifiers for Droplet creation.

Try:
export TF_VAR_ssh_fingerprint=$(ssh-keygen -E MD5 -lf ~/.ssh/id_rsa.pub | awk '{print $2}' | sed 's/MD5://g')

Can you paste the output of ssh -version on your machine?
I'm on osx and the command you pasted was working for me so I took out the "if Darwin" statement. But it looks like we still need it, possibly conditioning on ssh -version since uname doesn't seem to sufficiently determine the command we need.

I use 10.12 default ssh client which is OpenSSH_7.2p2 and LibreSSL 2.4.1

Eek, my OpenSSH was a bit out of date.
I can't find any mention of the -E option before OpenSSH_6.9. Confirmed we need the -E version on CoreOS stable with OpenSSH version 7.2. Debian Jessie appears to be on OpenSSH 6.7 and does not take the -E option.
Hopefully 6.9 is the correct cutoff. I've put a switch based on OpenSSH version into the setup script and opened PR #11. I'll merge it soon unless you have more comments.
Thanks for pointing this out :)


Construct SCT from base64 in ct_test

This gives better code coverage and is more representative of how a user would likely construct an SCT (using the base64 returned by a CT log).

+1.  backport or not?

It's really just an improvement in test coverage, so I can't see a good reason to bother backporting it.

yeah, it was more a question for the team.  we've said backporting tests for better coverage is probably okay.

sigh.  just rebuild and tested and there are memleaks.  Can you do this:
make `V=1' 'TESTS=test_ct' tests

and fix them?  For example, there's an sk_SCT_pop_free call missing...

ping @RJPercival (sorry for the delay here)

Can you include a copy of the memleak report please? I can't reproduce it.
sk_SCT_pop_free() shouldn't be called directly, as there's an SCT_LIST_free() convenience function that calls it with the correct free function. That's called in tear_down() in ct_test.c, so if you're thinking that sct_list leaks, that shouldn't be the case.

Ah I've found a bug that will result in the leak. Fixing now...

Fixed some bugs. This almost certainly should be backported now.

clean build on master and yes it should be backported to 1.1.0  @t-j-h reconfirm?

ping @t-j-h master and 1.1.0

ping @t-j-h to re-plus-one.

+1

@RJPercival can you rebase this again?  sigh, sorry ...  against master.

Done.

thanks, merged to master and 1.1.0!


[backport v2.7-branch]  drivers: spi: stm32 spi with dma must enable cs after periph

When using DMA to transfer over the spi, the spi_stm32_cs_control
is done after enabling the SPI. The same sequence applies
in the transceive_dma function as in transceive function
Fixes https://github.com/zephyrproject-rtos/zephyr/issues/43694
Signed-off-by: Francois Ramu<EMAIL_ADDRESS>

@erwango - can you ack this one?

@erwango - please ack when you have a moment.

No rush on our side. We'd like to have some field return of experience (not just a simple test) before merging.

Thanks @erwango, please approve the PR once you're done testing.

We're not actually testing.
We'd like to have a period in which users have time to use it in multiple situations and provide feedbacks.
If having this PR open during this time bother you, it can be closed.

We'd like to have a period in which users have time to use it in multiple situations and provide feedbacks.

I think this makes sense for a LTS branch, is it feasible for the bot to create the backport PR weeks after appending the backport label, so that the changes have enough time to be tested in the development branch? It would be great if the bot can comment at the origin PR on when the backport will be created.

@FRASTM  - likely coming down to the wire to approve this before 2.7.2


dita.xsl.xhtml feature extension point effects engaging beyond expected scope

Expected Behavior
Defining a feature extension of the dita.xsl.xhtml extension within a javahelp or eclipsehelp  plugin should affect only xhtml output for the javahelp or eclipsehelp plugin defined.
Actual Behavior
The changes defined using the dita.xsl.xhtml extension point within a javahelp or eclipsehelp plugin appear in all xhtml output, regardless of the transtype called.
Steps to Reproduce

Add the two plugins in the attached zip file to the 3.4.1 version of the OT.
Use some sample files to generate javahellp using the mchp_javahelp transtype and the xhtml transtype.
Both the javahelp and xhtml output will have the footer content in the output html which is only defined in the javahelp plugin.

Javahelp.zip

Environment

DITA-OT version: 3.4.1
Operating system and version:
Windows 10
How did you run DITA-OT?
dita command,
Transformation type:
mchp_javahelp, xhtml

The extension point is global and it works as documented, indeed affecting all XHTML-based outputs:
https://www.dita-ot.org/dev/extension-points/extension-points-in-org.dita.xhtml.html#ariaid-title1
Maybe you can control the XSLT with parameters (using the "dita.conductor.xhtml.param" extension point), parameters which could be set for one transformation but not for the others.

Closing as works as intended.

Ok, so it's working as it should. That's surprising. At this point we're just using our pre-existing plugin extending the xhtml plugin and using the transtype parameter to distinguish when the templates should be applied to the various outputs.
Radu, are you suggesting that if I defined a parameter in the javahelp plugin using the dita.conductor.xhtml.param then I could define a parameter that would be passed to the xhtml plugin when the content being processed is destined for the javahelp plugin? In this application, I expect that would be redundant, but I can see that being useful for other purposes.
Are all extension points applied globally this way? I would have expected extension points defined within a plugin to be applied within the plugin.

The "dita.xsl.xhtml" extension point is defined in the "org.dita.xhtml" plugin (you can open the "org.dita.xhtml/plugin.xml" to see its definition). Both the XHTML plugin and all other plugins which extend this plugin (including Java Help Eclipse Help, Windows Help) will use your extra XSLT stylesheets defined for this extension point.
One thing the JavaHelp plugin could have probably done (but it did not) would have been to define its own separate XSLT extension point, so that when a plugin wanted to customize only JavaHelp it could have extended only that particular extension point. As far as I know the DITA OT organization no longer maintains the JavaHelp plugin.
If you use the "dita.conductor.xhtml.param" extension point in your plugin (not in the JavaHelp plugin), like for example we do for this plugin:
https://github.com/oxygenxml/dita-plant-uml/blob/master/com.oxygenxml.plantuml.svg/plugin.xml
you could pass a parameter from the transformation command line to the XSLT.
For example if this parameter would be "javaHelpTransformation", from the command line when you invoke the JavaHelp transtype you could also set this parameter to "yes", so that it reaches the custom stylesheet and can be used in the custom stylesheet to decide if the custom processing should be done or not.


Interoperability issue with RSA OAEP encryption

I'm having interoperability problems when encrypting a small payload with a RSA public key and decrypting it with a RSA private key.
The encryption is made using this library and the decryption is made using Golang's rsa package.
Decryption is made using this library in the following way:
let public_key = RsaPublicKey::new(rsa::BigUint::from_bytes_be(&n), rsa::BigUint::from_bytes_be(&e.to_be_bytes())).unwrap();

let mut rng = OsRng;
let padding = PaddingScheme::new_oaep_with_mgf_hash::<Sha256, Sha256>();
let enc_key = public_key.encrypt(&mut rng, padding, &payload).expect("failed to encrypt");

The library in Golang uses RSA OAEP with SHA-256 and SHA-256 for the MGF1.
I've been successful in encrypting the payload using Java Crypto by using the following, which confirms that the Golang implementation uses RSA OAEP with SHA-256 and SHA-256 for the MGF1.:
Cipher cipher = Cipher.getInstance("RSA/ECB/OAEPWITHSHA-256ANDMGF1PADDING");
cipher.init(Cipher.ENCRYPT_MODE, pub,
        new OAEPParameterSpec("SHA-256", "MGF1", new MGF1ParameterSpec("SHA-256"), PSource.PSpecified.DEFAULT));
byte[] encryptedKey = cipher.doFinal(secretKey.getEncoded());

I've been dealing with this problem for some time now and I haven't been able to find the right way to make this work. Am I using the library wrong or is there the possibility of an underlying problem with interoperability?

Could you provide a more full example for both the rust and the go version you are using please?

Closing for lack of a repro.
Please reopen/refile with a repro against one of the latest v0.9 prereleases (or newer) if the issue persists.


Feat: Added BertScore metrics

This PR adds:

BERTScore as the model-based metrics.
Adds tests for the same.

Addresses Issue #244

Hey @penguine-ip, I added some new tests for I guess these CI checks might be using a big model (1.8 GB) to tests for BERTScore. Is that okay, before this will be for all the CI checks from now on.

Oh, it runs lot of checks prior which also uses lot of models.

Yup it works :)


Feature: Ability to print one large full-page PDF from chromium

We have our own chromium wrapper that we use to take single-page PDF using the site content size.
We use:

Emulation.setDeviceMetricsOverride(width=, height=)
Page.getLayoutMetrics -> content_width=contentSize.width;  content_height=contentSize.height
Page.printToPdf(paperWidth=content_width / 96, paperHeight=content_height / 96)

This way the whole website is "printed" inside one page which has the requested dimensions, rather than multiple pages.
I can't use dynamically computed values for paperWidth/Height in the current version of gotenberg. Would this be something that could be implemented ?

Hello @rslinckx,
Sure, why not 😄
From a user perspective, I guess a form field like onePageLayout=true would do the trick.
Do you have more details on the implementation? For instance:

Emulation.setDeviceMetricsOverride(width=, height=) - are width and height the size of the page (e.g., A4).
Page.printToPdf(paperWidth=content_width / 96, paperHeight=content_height / 96) - why are you dividing by 96?

The Emulation.setDeviceMetricsOverride width/height are pixel values like 1280 and 800, I see also deviceScaleFactor=1 and mobile=False as parameters, presumably these are the devtools protocol json arguments. I also use Emulation.setEmulatedMedia media=screen.
All this is to emulate a screen with a common resolution viewing the website.
The Page.printToPDF call with /96, I'm not sure why it's done that way, but I suspect this is some kind of conversion between paper DPI and screen resolution in pixels? Does it ring a bell ?
Finally there's also pageRanges="1" as argument to make it single page.
The end result is something that looks like a screenshot of the whole website (at least as far as can be loaded in the imparted time, and ignoring some JS lazy infinite scroll that sometime exist) in a single PDF page which has the same dimensions as the virtual screen.
I'm not sure if this fits exactly the problem space of gotenberg, but I figured it would be a relatively small addition, given that the rest is identical.
Note: I also generate a PNG snapshot using Page.captureScreenshot(format='png', clip={"x": 0, "y": 0, "width": 1280, "height": 800, "scale": 1}), but it seems the image is out of scope for gotenberg? Maybe it would be worth adding support for rendering images in chromium but also converting PDF to images (we use pdftocairo currently to do that)

I would love to see this feature. This is exaclty what came up today at my side :-)
Could it also be useful to define the values of Emulation.setDeviceMetricsOverride via (optional) parameters? Just in case someone wants to use some other values than 1280/800.

Good to know: during my experiments (see https://github.com/gotenberg/gotenberg/issues/349), I've found that Emulation is only working with image outputs, not PDF.
For converting PDF to images, it could be interesting, but right now there are still a lot of stuff to be done regarding PDFs 😄

Right, it might be that the Emulation thing was only done because we are both taking an image output and a PDF output.

There seem to be now support for full-page image screenshots of websites, but digging into the code it seems to use a different method than the PDF conversion. The screenshot route uses https://github.com/gotenberg/gotenberg/blob/main/pkg/modules/chromium/tasks.go#L98 a special WithCaptureBeyondViewport option, not sure if it's available on the pdf variant?

@rslinckx alas no, that's two separate things :/

One page PDF flag, or something would be really useful
From docs, ideally you could use pageWidth and pageHeight for this: e.g.
pageHeight: fitContent
pageWidth: 10
Most people use PDFs for exporting, but not actually printing (as in using physical paper) so pages are actually rarely used.

Thanks for the input @matthiscock!

Just to add, tested, documentation has been updated (not by me) and all in all awesome!


ng update deletes node_modules before ensuring it will succeed

🐞 Bug report
Command (mark with an x)
ng update @angular/cli @angular/cdk ...

[ ] new
[ ] build
[ ] serve
[ ] test
[ ] e2e
[ ] generate
[ ] add
[x] update
[ ] lint
[ ] extract-i18n
[ ] run
[ ] config
[ ] help
[ ] version
[ ] doc

Is this a regression?
Not sure. Might be half bug, half feature request.
Description
When updating from angular 12 to 13, the following sequence of events happened:

ng update to determine dependencies
ng update ...
after determining dependencies and updating my package.json file, the script seems to delete node_modules
the npm install step triggered by ng update fails due to a peer dependency conflict
this is the FR/bug this part of the script should do a dry run and abort before deleting node_modules if the npm install with the updated package.json file will fail. Ideally add more details and suggestions here, and roll back the change to package.json.
Now re-running ng update a second time will note no installed dependencies, because apparently the script checks node_modules and not package.json.
The actual fix for the deeper bug is some conflict in peer dependencies between the older 12 installation of architect and build-angular and the updated package.json file. Reverting package.json to head (the 12 installation), running npm install to re-install the now-missing node_modules directory, then deleting package-lock.json, will allow the ng update command to run to completion. If this is a common issue, adding some help text in that regard would be nice.

🌍 Your Environment
NOTE this is post-upgrade, the bug happened during a 12->13 upgrade.

Angular CLI: 13.0.2
Node: 16.10.0
Package Manager: npm 7.24.0
OS: linux x64

Angular: 13.0.1
... animations, cdk, common, compiler, compiler-cli, core, forms
... material, platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1300.2
@angular-devkit/build-angular   13.0.2
@angular-devkit/core            13.0.2
@angular-devkit/schematics      13.0.2
@angular/cli                    13.0.2
@angular/fire                   7.2.0
@schematics/angular             13.0.2
rxjs                            6.6.7
typescript                      4.4.4

Anything else relevant?

I had an issue with this also, didn't think of rerunning update after deleting the contents of package.json, I ended up copying them to another location and installing them a few at a time with the new version. Something involving @angular-devkit/build-angular has a bad peer dependency listed.  I thought I had a log file to share but it inadvertently got overwritten.

Same issue with update from Angular 10 to 11. node_modules folder gone! :( :(
From https://update.angular.io/?l=2&v=10.0-12.0
npx @angular/cli@11 update @angular/core@11 @angular/cli@11
Only issues a one-line error message about incomplete repository. But I am not event using git.
Stackoverflow suggests to add --allow-dirty
It runs with that. I get
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
Not sure if that is important.
Then plenty of errors related to<EMAIL_ADDRESS>npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@angular-devkit/build-angular
npm ERR!   dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/@angular/compiler-cli
npm ERR!   peer<EMAIL_ADDRESS>|| ^11.2.0-next" from<EMAIL_ADDRESS>npm ERR!   node_modules/@angular-devkit/build-angular
npm ERR!     dev<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\andreas2\AppData\Local\npm-cache\eresolve-report.txt for a full report.

eresolve-report.txt

I think that removing a node_modules folder is:

time-consuming
counter-productive (my understanding is: npm heavily relies on a package-lock.json while installing, so removing node_modules brings to us very little or nothing in terms of a profit)

I cannot believe to solve this issue is treated like a feature request, instead of just fixing this clearly undesired behaviour ?


Record and Display Own Public IP

Nodes do not know their own public IP until they try to connect to them and discover that the instance ID is the same. At this point:

[ ] record the public IP in the networking state, wrapped in an option
[ ] display the public IP in the dashboard

From what I understand, your "public IP" is a subjective matter, and can, in many cases, not be accessed from the host machine. If you're connected through IPv6, the host machine seems to know its own public IP and everyone else agree on the value. But for IPv4, most non-servers have NAT'ed IPs wheree the host machine cannot know its own public IP. And even if it did, it could change at the whim of a local router.
@aszepieniec suggested to record the public IP when the "self-connect" error is encountered. But AFAIK, even this public IP address could change, not to mention the socket (i.e. IP, port, protocol triplet).
People with more knowledge about networking could weigh in here, informing us whether this is a good idea, and if so, how to achieve it.


Crash when trying to use the output of a drain as fuel to the same smelter

Minecraft Version
1.20.1
Fabric Version
0.15.6
Fabric API Version
0.92.0+1.20.1
Hephaestus Version
1.20.1-<IP_ADDRESS>
Describe your issue
When using the liquid inside of a smelter as fuel for the same smelter, the game will crash
Here's a video demonstrating the issue: https://github.com/Alpha-s-Stuff/TinkersConstruct/assets/60353007/ee8f236d-49a7-432d-87df-902514570f72 (I right clicked the faucet before the crash)
Crash Report
https://pastebin.com/pmYpyngR
Other mods

Mod Menu
Fabric API

Tried reproducing with just Tinkers?
Yes
Performance Enchancers
None of the above
Searched for known issues?
Checked pinned issues, Searched open issues, Searched closed issues

Can you try on the newest version <IP_ADDRESS>0?

For some reason I can't launch anything after <IP_ADDRESS>

I've never seen that error before weird... Maybe try reinstall fabric?

You can also try updating fabric api

Fabric API is up to date
I tried with Fabric 0.15.7 and the game launched

And welp seems like this works with the latest version
Sorry for the unnecessary issue then x) and thanks for the fast replies!

Its no problem, glad I was able to help!


Order of option order in help text

Appologies if this is already possible or answered somewhere, I couldn't find details in the docs or searching existing issues.
Could the Help Text generator take an order for the listed options, such as by Required first, then Alphabetical?
We have a set of available verbs that have some shared options so have built our option classes to be inherited. Currently the help builder lists these options in inherited order, but we would like to at least collect required options at the top.

The feature is not available.
PR is welcome.

I take the issue. PR will come in some days may be hours

I made some dev and finally reworked it.
Coming PR allow to redefine order using a Comparison<ComparableOption> function.
I choose to create a ComparableOption from the Specification class to not break existing visibility rules.
To redefine order you then have to provide de Comparison object as a static value of HelpText class before calling AutoBuild :
HelpText.OptionComparison = HelpText.RequiredThenAlphaComparison;
var helpMessage = HelpText.AutoBuild(parseResult,...)

Maybe not the perfect solution but it works well.
PR comes with the  order that @tehkyle proposed.
When no comparison is provided before calling AutoBuild then it defaults to the current behavior (declaration order)


📝 Update includes in docs/en/docs/tutorial/response-status-code.md

Update includes in docs/en/docs/tutorial/response-status-code.md
Part of #12554

Thank you! @kantandane :rocket:


project includes files that are missing

I believe that tstl.h needs to be pulled in from another one of your repositories. If there is an easy way to do it (or not) it would be good to include that in the readme area.

Good point. Several of my C/C++ repos depend on https://github.com/rasa/shared


UnhandledRejection error while loading the agent 1.235.0

Description
Starting from yesterday evening (2023-06-22 17:00 UTC), I'm getting the following error while loading the agent in browsers with strict privacy settings:

UnhandledRejection
Non-Error promise rejection captured with value: undefined

It's similar to #392. In the browser console I see chunks loading failures, and then the error Uncaught (in promise).
The agent is injected dinamically in HTML by the PHP agent.
Steps to Reproduce
Use a browser with strict privacy settings. It will block the requests to https://js-agent.newrelic.com.
Expected Behavior
Even if the browser blocks the agent download I expect to get only warnings in console. Rejections should be handled.
Relevant Logs / Console output
Sample warnings:
New Relic: Downloading runtime APIs failed...
New Relic: A problem occurred when starting up session manager. This page will not start or extend any session.
  ChunkLoadError: Loading chunk 860 failed.
  (error: https://js-agent.newrelic.com/860.e997904f-1.235.0.min.js)
New Relic: Downloading and initializing page_view_event failed...
  ChunkLoadError: Loading chunk 412 failed.
  (error: https://js-agent.newrelic.com/lazy-feature-loader.0ba331d7-1.235.0.min.js)
[...] and so on

Error:
Uncaught (in promise) undefined [A:6:32604](https://website/page)
    a https://website/page:6
    InterpretGeneratorResume self-hosted:1359
    AsyncFunctionThrow self-hosted:760
    (Asinc.: async)
    importAggregator https://website/page:6
    nrWrapper https://website/page:6
    (Asinc.: EventListener.handleEvent)
    nrWrapper https://website/page:6
    s https://website/page:6
    o https://website/page:6
    importAggregator https://website/page:6
    F https://website/page:6
    start https://website/page:6
    forEach self-hosted:203
    start https://website/page:6
    <anonima> https://website/page:6
    <anonima> https://website/page:6
    <anonima> https://website/page:6
    <anonima> https://website/page:6

Your Environment

php NR agent version: <IP_ADDRESS>7
the agent is configured to auto inject the js script

Additional context
Similar issues #392

Thanks for reporting this issue @ilario-pierbattista. We will investigate why the chunk loading errors are not being caught.

I encountered the same issue, any solution?

Hi @patrickhousley,
now it started to use the 1.236.0 version, and it started to fail with:

ChunkLoadError: Loading chunk 412 failed.
(error: https://js-agent.newrelic.com/lazy-feature-loader.2f55ce66-1.236.0.min.js)

It seems a regression of #392

@cwli24 nope, my bad, it was just a warning.
Some times it gives Unhandled Promise Rejection: Failed to fetch while posting to https://bam.nr-data.net.
Currently I'm not able to reproduce it, neither with a privacy strict browser.

@cwli24 nope, my bad, it was just a warning. Some times it gives Unhandled Promise Rejection: Failed to fetch while posting to https://bam.nr-data.net. Currently I'm not able to reproduce it, neither with a privacy strict browser.

I'm getting the same error. It started on Jun 30...

Any progress with the Unhandled Promise Rejection: Failed to fetch error?
I was trying to reproduce it but without any success

thank you @cwli24

@matejbasic @ilario-pierbattista @tavito @matejbasic We recently released version 1.237.1 of the browser agent. Could you please let us know if this issue is still persisting? For APM injected apps, you may need to restart your APM instrumented applications.

@patrickhousley it seems to be fixed, thanks

@patrickhousley it seems to be fixed here too, thanks!

Hello,
We are still getting version 1.236.0, we've cleared cache, redeployed (ecs+docker), rebuilt images, rebuilt php-agent, nothing is working and we're still getting 1.236.0
Has this not been published yet or something? It's causing us a huge amount of issues because it flags on Sentry, so we're hoping to get this fix ASAP.

What is the copy/paste install method?
This is how we have our agent installed (it's Docker)
RUN wget https://download.newrelic.com/php_agent/archive/<IP_ADDRESS>/newrelic-php5-<IP_ADDRESS>-linux-musl.tar.gz \
    && tar -xf newrelic-php5-<IP_ADDRESS>-linux-musl.tar.gz \
    && cd newrelic-php5-<IP_ADDRESS>-linux-musl \
    && NR_INSTALL_USE_CP_NOT_LN=1 NR_INSTALL_SILENT=1 ./newrelic-install install

And our application is still fetching 1.236.0, it's not cached either as we're getting thousands of Sentry's from over 100+ users.

@vekien You will want to reach out to the New Relic support team as this seems like a possible issue with the PHP APM agent. It should automatically get the newest version of the browser agent. We, the browser agent team, does not have any settings set right now to force this version. Sorry I could not help further.

@patrickhousley no errors reported in last week, seems to be working fine now, thank you! :blush:


App fails to compile when using rootDir in tsconfig

I am using the library ng2-permission in my project. My project is a authentication library created for generator-angular2-library...
Unfortunately the ng2-permission was publish with .ts files...
The problem is that the NPM package contains *.ts files. This seems to be due to .ts and .d.ts files existing within the same directory and causing the typescript compiler to recompile the module and then getting confused because it is outside of the rootDir.
Can you publish one version without src?
ERROR:
Error File '/opt/projeto/node_modules/angular2-permission/index.ts' is not under 'rootDir' '/opt/projeto/.tmp'. 'rootDir' is expected to contain all source files.
Error File '/opt/projeto/node_modules/angular2-permission/src/directives/except-permission.directive.ts' is not under 'rootDir' '/opt/projeto/.tmp'. 'rootDir' is expected to contain all source files.
Error File '/opt/projeto/node_modules/angular2-permission/src/directives/has-permission.directive.ts' is not under 'rootDir' '/opt/projeto/.tmp'. 'rootDir' is expected to contain all source files.
Error File '/opt/projeto/node_modules/angular2-permission/src/index.ts' is not under 'rootDir' '/opt/projeto/.tmp'. 'rootDir' is expected to contain all source files.
Error File '/opt/projeto/node_modules/angular2-permission/src/model/permission-guard.model.ts' is not under 'rootDir' '/opt/projeto/.tmp'. 'rootDir' is expected to contain all source files.
Error File '/opt/projeto/node_modules/angular2-permission/src/module/ng2-permission.module.ts' is not under 'rootDir' '/opt/projeto/.tmp'. 'rootDir' is expected to contain all source files.
Error File '/opt/projeto/node_modules/angular2-permission/src/services/permission-helper.service.ts' is not under 'rootDir' '/opt/projeto/.tmp'. 'rootDir' is expected to contain all source files.
Error File '/opt/projeto/node_modules/angular2-permission/src/services/permission.guard.ts' is not under 'rootDir' '/opt/projeto/.tmp'. 'rootDir' is expected to contain all source files.
Error File '/opt/projeto/node_modules/angular2-permission/src/services/permission.service.ts' is not under 'rootDir' '/opt/projeto/.tmp'. 'rootDir' is expected to contain all source files.
[19:21:35] 'ngc' errored after 7.28 s
[19:21:35] Error: ngc compilation failed
    at ngc.then (/opt/projeto/gulpfile.js:59:15)

tsconfig:
{
  "compilerOptions": {
    "compileOnSave": false,
    "declaration": true,
    "module": "es2015",
    "target": "es5",
    "baseUrl": ".",
    "stripInternal": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "moduleResolution": "node",
    "rootDir": ".",
    "outDir": "../build",
    "lib": [
      "es2016",
      "dom"
    ],
    "skipLibCheck": true,
    "types": []
  },
  "angularCompilerOptions": {
    "annotateForClosureCompiler": true,
    "strictMetadataEmit": true,
    "skipTemplateCodegen": true,
    "flatModuleOutFile": "my-login.js",
    "flatModuleId": "my-login"
  },
  "files": [
    "./index.ts"
  ]
}

you can concat *.js files in dist folder and use them.


roundabouts are not conflating correctly

The API doesn't generate a match for infinite circles. When city data depicts a roundabout (or a close) as a single segment, it fails to match.

Even when roundabouts are not infinite circles, they wouldn't match correctly in the example I looked at... but the API didn't know that it had failed. Example below. Matches in blue, city data in grey, unmatches in red (there are none).

perhaps related to this issue: https://github.com/sharedstreets/sharedstreets-js/issues/23


[image_picker] Fixes an issue where videos could be wrongly picked with .jpg extension

Fixes an issue where videos could be wrongly picked with .jpg extension.
Description
When picking videos on Android devices, it will return file names ended with .jpg extension, regardless of the file being actually a video. This requires a workaround implementation, such as opening a File descriptor on Flutter side and rename it to .mp4 again.
The issue happens because some URI paths doesn't have an extension and it was being extracted just by splitting the file name from . and getting the last part, which make it not quite reliable for some scenarios. Right now, I've updated the source to retrieve the extension based on the URI content.
As a note, this doesn't happen with all Android devices, but I can see it easily replicable with Samsung phones.
Related Issues
Fixes #52419
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[X] All existing and new tests are passing.
[X] I updated/added relevant documentation (doc comments with ///).
[X] The analyzer (flutter analyze) does not report any problems on my PR.
[X] I read and followed the Flutter Style Guide.
[X] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[X] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[X] I updated CHANGELOG.md to add a description of the change.
[X] I signed the CLA.
[X] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[X] No, this is not a breaking change.

This has been approved by all reviewers. If it could be merged it would be great to prevent constant rebasing 😄
Thanks!

Could this PR be approved? Many thanks in advance

I need this fix, and I have this problemI hope the author will update soon. Thank you

I can confirm that running off the fork resolves the issue for me
  image_picker:
    git:
      url: https://github.com/miguelpruivo/plugins
      ref: 9cac5347d9ab9d111a918a8154fb060565b1bf31
      path: packages/image_picker/image_picker

Thank you for your email, which solved my problem.
| |
张涛
|
|
<EMAIL_ADDRESS>|
签名由网易邮箱大师定制
On 08/6/2020 02:35，Venkat<EMAIL_ADDRESS>wrote：
I can confirm that running off the fork resolves the issue for me
image_picker:
git:
url: https://github.com/miguelpruivo/pluginsref: 9cac5347d9ab9d111a918a8154fb060565b1bf31path: packages/image_picker/image_picker
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

I can confirm that running off the fork resolves the issue for me
My pubspec.yaml declaration
  image_picker:
    git:
      url: https://github.com/miguelpruivo/plugins
      ref: 9cac5347d9ab9d111a918a8154fb060565b1bf31
      path: packages/image_picker/image_picker

I tried the way, but still it is giving me a .jpg

@miguelpruivo You may want to add Fixes before the issue id so that it automatically closes the issue when merged.

@pedromassango done! 🎉

Hi, @danielwalczak @awazgyawali @fdcgr
Thanks for your reviews!
As per our tree hygiene https://github.com/flutter/flutter/wiki/Tree-hygiene#how-to-review-code we avoid people without commit access to this repo approving changes during a review as this confuses authors into thinking the PR is ready to merge. (Regular reviews are much appreciated, just don't click the approve changes button)
@miguelpruivo
Very sorry for such a long wait 😢
I would love to merge this however due to the lack of unit tests and my lack of experience here are some questions:

Why does this happen? Does this only apply to videos not saved with a file extension?
How hard would it be to add tests?
How does this behavior differ from iOS?
This fix seems to replace the extension detection logic entirely rather than using it as a fallback. If the uri does have an extension will this still use that extension verbatim? I'm specifically looking for any notable changes in behavior outside of files given .jpg.

I trust that it works because you have done this sort of thing before but we still need to make sure this doesn't break anything on a patch release version. (love your work on file_picker btw)

@miguelpruivo I found another approach to do this here: https://github.com/flutter/plugins/pull/2821, do you think this is something that can be collaborated upon, so we only have to merge one PR to fix two bugs?

I agree that the fix for image extension issue is better handled here than on https://github.com/flutter/plugins/pull/2821. Maybe collaborate is the better idea to merge just one PR.

@PixelToast hi, thank you for the input.
Currently I’m off on vacations until next week. However, I’ll try to help you as much as I can.

Apparently this happens because the uri is treated as an image and not a video;
Unit tests are not actually the easiest for native pickers as you’ll have to fully drive the picking behavior (integration test) and handle its results;
This only affects Android, on iOS the plugin implementation is behaving properly;

Let me know if you need anything else.

@PixelToast @miguelpruivo @pedromassango
Hi! I prefer to have two PRs, one for the image resizing (GIF) and one for the correct/incorrect JPG extension handling.
@ditman Let's get this PR ready for merge first and I can rebase #2821 after that.

@ened sounds good to me!

@miguelpruivo Thanks for the update, it's good to know you are still able to help.
If full integration tests aren't feasible, just a unit test for getImageExtension should be fine.

@PixelToast ok no problem. I’ll try to get it done as soon as I return home on the weekend.

Tested with:
image_picker:
  git:
    url: https://github.com/miguelpruivo/plugins
    ref: 9cac5347d9ab9d111a918a8154fb060565b1bf31
    path: packages/image_picker/image_picker

Videos are selected correctly with .mp4 extension. The picked file playback also works as expected.

Go go ! 🎉🎉

thanks!
it fixed my problem.
hope merge this pr soon~

@miguelpruivo this may need a rebase from master.

Done.

This seems ready for review.
Cc @cyanglaz

Can this be reviewed and merged, it has been 5 days already.

I can confirm that running off the fork resolves the issue for me
My pubspec.yaml declaration
  image_picker:
    git:
      url: https://github.com/miguelpruivo/plugins
      ref: 9cac5347d9ab9d111a918a8154fb060565b1bf31
      path: packages/image_picker/image_picker

Help, this works on debug but gives me an error when building release

@frankyvij it has been 3 months, actually. 😅

any update for this pr? thanks

any update ?

Any reason why it's not merged yet?

Can this be merged in? This seems to be a problem that has existed for a while

@pedromassango I'm sorry but currently I'm out of time to work on that. I might implement it but with no ETA.

I created a PR with a working Unit Test. #3685


Exception raised while checking worker resource limits

The exception is caused when the worker monitor attempts to sort by memory_usage and there are workers with a nil value.
This is the offending line:
https://github.com/ManageIQ/manageiq/blob/master/app/models/miq_server/worker_management/monitor.rb#L107

https://github.com/ManageIQ/manageiq/pull/5916#issuecomment-165915100


A failed IOU request has the “Cancel” feature as a successful IOU request and able to cancel the request

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click on “Profile” avatar
Click on “Preference” link
Turn on “Simulate a network failure”
Open an existing chat
Click on “Actions” icon
Click on “Request money” link
Enter “Amount” and click on “Next” button
Click on “Request” button
Turn off “Simualte a network failure”
Observe that Money request has an error message
Click on the newly created IOU
Observe that the failed “Cancel” button is active
Click on the “Cancel” button

Expected Result:
“Cancel” button for failed IOUs shouldn't be clickable and should be disabled or hidden from the UI
Actual Result:
“Cancel” button for failed IOUs is active and clickable
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2.92-0
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/228881548-805d17b4-fc10-4819-93e0-07e148b48579.mp4
https://user-images.githubusercontent.com/43996225/228881565-7891daff-ced5-4014-82b7-01e7a2043392.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680162826186869
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017fdfc602b8fa6805
Upwork Job ID:<PHONE_NUMBER>235252736
Last Price Increase: 2023-04-27

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@greg-schroeder Huh... This is 4 days overdue. Who can take care of this?

Reviewing now

Hmm. I couldn't reproduce this where the error message pops up after simulating a network failure and then disabling that - it didn't show an error at all. I tested on staging.
@Natnael-Guchima can you check your reproduction steps to make sure nothing is missing?

One minute, @greg-schroeder. Let me check and get back to you.

https://user-images.githubusercontent.com/57330233/230151128-4d428bfe-3c7c-4d0b-af9a-67f7c6748223.mp4
I can reproduce it in staging, @greg-schroeder.
Steps:

Open an existing chat
Click profile avatar
Click on preferences
Turn on simulate a failing network
Close settings
Click on 'Actions' icon > Request Money > enter amount & submit
Click on profile avatar > Preferences > Turn off simulate a network failure
Close setting

The above step should produce the error message. If error is thrown open the failed IOU and click on 'Cancel' button

Let me try it again, thanks for checking!

@greg-schroeder this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@greg-schroeder Still overdue 6 days?! Let's take care of this!

@greg-schroeder 10 days overdue. Is anyone even seeing these? Hello?

Reviewing again to try to reproduce

@greg-schroeder this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

@greg-schroeder 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@greg-schroeder this issue is now 4 weeks old and preventing us from maintaining WAQ. This should now be your highest priority. Please post below what your plan is to get a PR in review ASAP. Thanks!

Job added to Upwork: https://www.upwork.com/jobs/~017fdfc602b8fa6805

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

@greg-schroeder Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

This issue has not been updated in over 14 days. @greg-schroeder, @0xmiroslav eroding to Weekly issue.

I'm currently seeing Delete instead of Cancel. Was the copy changed at some point?

No, cancel and decline buttons are removed in favor of the new Delete button on this PR

I'm currently seeing Delete instead of Cancel. Was the copy changed at some point?

No, cancel and decline buttons are removed in favor of the new Delete button on this PR

@Natnael-Guchima Thanks for the reply. So is this bug still applicable? But instead of Cancel, we should disable Delete if the request failed?

I'm currently seeing Delete instead of Cancel. Was the copy changed at some point?

No, cancel and decline buttons are removed in favor of the new Delete button on this PR

@Natnael-Guchima Thanks for the reply. So is this bug still applicable? But instead of Cancel, we should disable Delete if the request failed?

You are welcome @akinwale. I am not sure if this bug is still applicable. I haven't heard anything from internal team on weather to pursue this or not.

Proposal
Please re-state the problem that we are trying to solve in this issue.
The failed IOU request is still deleable
What is the root cause of that problem?
In https://github.com/Expensify/App/blob/1ee8cf84d60e0f60baae33f9016f6b585e869387/src/pages/iou/IOUTransactions.js#L67-L74
We get the deletable transactions without filtering out the errors transaction
What changes do you think we should make in order to solve the problem?
Solution 1: If we don't want to show the delete button
Filter out the error action by adding the following line:
.filter((action) => !action.errors)

Solution 2: If we want to disable the delete button

add a new props (shouldDisableDelete)
check if it is the error transaction set shouldDisableDelete= true, otherwise false

Improvement
We should move this line https://github.com/Expensify/App/blob/1ee8cf84d60e0f60baae33f9016f6b585e869387/src/pages/iou/IOUTransactions.js#L86
outside of map function to improve performance.
What alternative solutions did you explore? (Optional)

I'm currently seeing Delete instead of Cancel. Was the copy changed at some point?

Yes

@tienifr your proposal with solution 1 LGTM 👍🏼

Per discussion:

Looking at the reproduction steps, I don’t think this is relevant anymore. We are deprecating cancel (though not delete).

@tienifr, @Natnael-Guchima, @0xmiroslav offers sent

@tienifr, @Natnael-Guchima, @0xmiroslav offers sent

Accepted. Thanks!


Update did:web Universal Resolver to support verificationMethod

The Universal Resolver did:web driver throws an error if a DID document doesn't contain "publicKey" (which has long been removed from DID Core).
The driver on DockerHub is 6 months old, would it be possible to push an update? https://hub.docker.com/r/uport/uni-resolver-driver-did-uport/
See also https://github.com/decentralized-identity/universal-resolver/issues/168 and https://github.com/w3c-ccg/did-method-web/issues/24.

Or should the Universal Resolver use different drivers for did:web and did:ethr than https://hub.docker.com/r/uport/uni-resolver-driver-did-uport/ ?

I'm not aware of any other implementations.
We've got a bunch of updates lined up to the did:web and did:ethr resolvers that are supposed to bring them much closer to did core spec.
They should be merged in the next few days at which point I'll rebuild the docker image and let you know

@peacekeeper the @latest docker tag should have this fix along with a number of other fixes.
The did:ethr and did:web resolvers now return DID resolution results instead of DID documents.
I'm not sure if something special needs to be updated to accommodate this

@peacekeeper I created a PR in uniresolver with the update. Please take a look: https://github.com/decentralized-identity/universal-resolver/pull/180


icon_sprite.png is not found in latest serenity

icon_sprite.png which is referenced in serenity.css datepicker next prev spans doesnt exist.
Should probably convert it to data uri as well.

Try this #2895. It solved all the problems for me.

There are still two references that old sprites image in serenity.css that should be fixed.
@AlperanQ is right, he is Serenity employee btw.

This is fixed in latest version.


Add polessu domain

@kostyaostapuk I am sorry for a delay with processing your request.
Pull request merged. Thank you!

@kostyaostapuk I am sorry for a delay with processing your request.
Pull request merged. Thank you!


Custom Video Source to add skin smoothing filter.

Our team is trying to add skin smoothing filter. We are following Implementing a custom video processing step for local source from custom_video.md
In NativeMobileSDKBridge.kt, we added
    private val logger = ConsoleLogger(LogLevel.DEBUG);
    private val eglCoreFactory = DefaultEglCoreFactory();
    private val surfaceTextureCaptureSourceFactory = DefaultSurfaceTextureCaptureSourceFactory(logger, eglCoreFactory);
    private val cameraCaptureSource = DefaultCameraCaptureSource(reactContext, logger, surfaceTextureCaptureSourceFactory);

and inside @ReactMethod
fun startMeeting(meetingInfo: ReadableMap, attendeeInfo: ReadableMap) method, we added eglCoreFactory in defaultMeetingSession
                    DefaultMeetingSession(
                            it,
                            logger,
                            activity.applicationContext,
                            eglCoreFactory
                    )
                }

and then in setCameraOn method, we did the following:
    fun setCameraOn(enabled: Boolean) {
        logger.info(TAG, "Called setCameraOn: $enabled")
        val myVideoProcessor = GpuVideoProcessor(logger, eglCoreFactory);
        cameraCaptureSource.start()
        cameraCaptureSource.addVideoSink(myVideoProcessor)
        if (enabled) {
          meetingSession?.audioVideo?.startLocalVideo(myVideoProcessor)

        } else {
            meetingSession?.audioVideo?.stopLocalVideo()
        }
    }

GpuVideoProcessor is from demo code provided here
we know this processor turns the camera feed black and white, instead of smoothing it.
Our problem:
Our application crashes when we cameraCaptureSource.start()
Any guidance to successfully turn the camera feed into b/w would be appreciated and if you could guide us with adding skin smoothing filter, it would be much much appreciated.
Thank you, have a good day.

Hi @Sandip-Z
What is the exception that you are seeing when it crashes?
I would also suggest calling cameraCaptureSource.addVideoSink(myVideoProcessor) before cameraCaptureSource.start()

Hi @zhinang-amazon
Thank you for your response. Yes, calling cameraCaptureSource.addVideoSink(myVideoProcessor) before cameraCaptureSource.start() did solve our issue.
Thank you again. 🙇🏾


Guo2022 FBrf0252837

JO-in needs adding
extra info for DNg11 and DNg12

Not adding LNR1+2 at this stage, as there is no description of them


Lock not acquirable for sqlite store

After an orbit is evicted from the cache, the orbit cannot be reloaded as a lock cannot be acquired on one of the sqlite stores:
IO error: could not acquire lock on "/tmp/kepler/.../....ks3db/db": Os { code: 11, kind: WouldBlock, message: "Resource temporarily unavailable" }

We should really figure out the AWS S3 or DynamoDB backend for IPFS ~2-8 MB blocks. cc @sbihel
What do we think would be a good store that's relatively cloud-agnostic?

This is still an issue post- rust-ipfs cutover. Perhaps there is an issue with how we are using cached?


When disconnected, the player transitions to STATE_READY instead STATE_IDLE and no error is reported.

Version
Media3 1.2.0
More version details
No response
Devices that reproduce the issue
Emulator running Android 13 API 33 x86_64
MicroTouch IC-215P-AA2 running Android 10
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Not tested
Reproduction steps

Play an RTSP stream.
Turn on "Airplane Mode" to cause a disconnect.
The ExoPlayer transitions to STATE_BUFFERING, and the buffering indicator appears on the player. Then after several seconds, probably the RTSP timeout, the buffering indicator is removed and the player transitions to STATE_READY. No error is reported to onPlayerError, and playback never recovers. There's no indication that playback has failed.

I'm working around this by polling. I've discovered that if the player disconnects, the buffer will be C.TIME_UNSET, which can be used to detect a stalled state.
// Start a watcher job to restart the player if it stops or stalls. This is necessary because the
// player won't report any errors.
stoppedCheckJob = scope.launch(mainDispatcher) {
    while(true) {
        delay(3000L)

        if (restartJob == null) {
            if (player.playbackState in listOf(
                    Player.STATE_IDLE,
                    Player.STATE_ENDED
                )) {
                Timber.w("$TAG: stopped player detected, restarting. card.id='${cardId}', config.name='${curConfig?.name}'")
                restartAfterDelay()
            } else if (isPlayerStalled()) {
                Timber.w("$TAG: stalled player detected, restarting. card.id='${cardId}', config.name='${curConfig?.name}'")
                restartAfterDelay()
            }
        }
    }
}

/**
 * The player says it's playing, but it's actually stalled because the buffer isn't loading.
 * For some reason the RTSP media source or the player doesn't go into an error state here,
 * it just acts like it's still working.
 */
private fun isPlayerStalled(): Boolean {
    return player.playbackState == Player.STATE_READY && player.contentBufferedPosition == C.TIME_UNSET
}

Here's my full code for initializing the player:

// Start playback immediately instead of buffering for 5 seconds, and reduce the buffer size
@UnstableApi
private val loadControl = DefaultLoadControl.Builder()
    .setBackBuffer(0, false)
    // Min size must be over 500 to prevent low buffer warning.
    .setBufferDurationsMs(1000, 5000, 0, 0)
    // This defaults to 125Mb, which seems way too big.
    .setTargetBufferBytes(2 * 1024 * 1024)
    .build()

// Keep playback near the live edge to avoid falling behind and running out of memory for the buffer.
private val liveConfiguration = MediaItem.LiveConfiguration.Builder()
    .setTargetOffsetMs(200)
    .setMinOffsetMs(200)
    .setMaxOffsetMs(200)
    .setMinPlaybackSpeed(0.8f)
    .setMaxPlaybackSpeed(10f)
    .build()

@UnstableApi
private val livePlaybackSpeedControl = DefaultLivePlaybackSpeedControl.Builder().build().apply {
    setLiveConfiguration(liveConfiguration)
}

// Use our custom media source so that liveConfig isn't ignored.
@UnstableApi
private val rtspMediaSourceFactory = CfaRtspMediaSource.Factory()

val player: ExoPlayer = ExoPlayer.Builder(ctx)
    .setLivePlaybackSpeedControl(livePlaybackSpeedControl)
    .setLoadControl(loadControl)
    // Turn off audio because we don't need it, and it reduces the surface area for things that
    // can throw errors and crash the app.
    .setRenderersFactory(ExoPlayerNoAudioRenderersFactory(ctx))
    .build()

val eventsListener = object : Player.Listener {
    override fun onPlayerError(e: PlaybackException) {
        Timber.e(e, "$TAG: ExoPlayer error. card.id='${cardId}', config.name='${curConfig?.name}'")
    }

    override fun onPlaybackStateChanged(playbackState: Int) {
        // If we were previously playing and now we're not, then try to restart. We have to do
        // this manually because RtspMediaSource doesn't implement setLoadErrorHandlingPolicy.
        if (prevPlaybackState in listOf(Player.STATE_BUFFERING, Player.STATE_READY) &&
            playbackState in listOf(Player.STATE_IDLE, Player.STATE_ENDED)
        ) {
            restartAfterDelay()
        }

        prevPlaybackState = playbackState
        prevPlaybackStateChangedAt = Instant.now()
    }
}

init {
    player.addListener(eventsListener)
}

fun syncMediaItem(/* args */) {
    // ...
    curMediaItem = MediaItem.Builder()
        .setUri(newUrl)
        .setLiveConfiguration(liveConfiguration)
        .build()

    val mediaSource = createMediaSource(curMediaItem!!)

    player.setMediaSource(mediaSource)
    player.volume = 0f
    player.prepare()
    player.play()
}

Expected result
The player should follow it's normal error behavior, which I think is to transition to STATE_IDLE and fire an error to the onPlayerError callback.
Actual result
The player transitions to STATE_READY, even though it's not playing. This, combined with the lack of an error being reported, makes it very difficult to implement error handling at all.
Overall I'm very frustrated with ExoPlayer, stuff like correct error handling is necessary for an app to work correctly, and all the bugs and memory leaks in ExoPlayer have made it almost impossible to use. It's taken me 2 weeks and a lot of dirty hacks just to get it to reliably play an RTSP stream without running out of memory or disconnecting.
Media
Needs an RTSP stream, I'm not sure of a public one.
Bug Report

[X] You will email the zip file produced by adb bugreport to<EMAIL_ADDRESS>after filing this issue.

player.contentBufferedPosition == C.TIME_UNSET should never be true because the API doesn't even allow this value. Just looking at the code I also don't a way we can end up in this state.  @microkatz  Can you see where the value could come from or setup a test stream easily to test it out?


incus.ui: upgrade zabbly patches, split from lxd

Description of changes
Split from lxd (no longer an override), upgrade zabbly patches to use new sed replace

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build incus.ui nixosTests.incus.ui

@ofborg build incus.ui nixosTests.incus.ui


[Release-for-2.0.9] update version

update version

Codecov Report

:exclamation: No coverage uploaded for pull request base (2.0.9-prepare@7c73e3f). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 07256c5 differs from pull request most recent head 47e6687. Consider uploading reports for the commit 47e6687 to get more accurate results

@@               Coverage Diff                @@
##             2.0.9-prepare   #14227   +/-   ##
================================================
  Coverage                 ?   20.60%
  Complexity               ?     1600
================================================
  Files                    ?      540
  Lines                    ?    23118
  Branches                 ?     2775
================================================
  Hits                     ?     4763
  Misses                   ?    17860
  Partials                 ?      495

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Investigate: Can multiple devices be paired to one dongle

From how every packet sent and received includes a deviceId, I suspect this is possible.
And it looks like they will then share a single HID device.
If this is the case, then some work will be required to allow this to function properly

Yes they can


add: Sakshi29G

Description
[Include a brief description of the changes you've made]
Related Issues
[Include any related issues or pull requests that this PR addresses or is related to. Use GitHub's shorthand syntax to link to them, like #1234.]
Changes Proposed
[Describe the changes you've made in detail. Be specific and include any relevant code snippets.]
Checklist

[x] I have read and followed the Contribution Guidelines.
[x] All new and existing tests passed.
[x] I have updated the documentation to reflect the changes I've made.
[x] My code follows the code style of this project.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Note to reviewers

@Sakshi29G Thanks for adding your profile.
Share the project with your friends and on social handles so we can grow this project more.


googleFit.authorize does not fire its callback

It tested it using just this snippet:
googleFit.authorize(() => console.log('Callback fired'))

It did not log that.
I already checked the index.android.js and tried something like this:
authorize(callback) {
        googleFit.authorize(
          msg => callback(msg, false),
          res => callback(false, res)
        );
callback('I should never get here.)
    }

and 'I should never get here' got logged to the console.
As I am not a Java dev, I did not dig deeper into the native code. It seems that the problem is on the Java side because googleFit.authorizefrom the index.android.js calls a native method right?

same problem here. any solutions?

The problem was that the BuildConfig.APPLICATION_ID was not the same that I configured in the Google API Console.


Proxy release 2024-07-18

Proxy release 2024-07-18
Please merge this Pull Request using 'Create a merge commit' button

Reviewed for changelog.


Where is the source code used in the book?

Hi,
I would like to download and open the source in my local vscode then press F12 and jump into the source code of leptos or any other librarys.
Any link of the source code pack so that I can download?

thanks, I found that all I need is to click this:


forge(create): Issue with verifying with forge create --verify

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[ ] Foundryup

What version of Foundry are you on?
forge 0.2.0 (0e33b3e 2023-07-27T00:26:56.802725000Z)
What command(s) is the bug in?
forge create --verify
Operating System
macOS (Apple Silicon)
Describe the bug
Ran into an issue with forge create --verify that seems like a regression, did a foundryup and couldn't get it to work and then went to a past commit foundryup -C 08a629a5e3f33b6750222526c8f58e2beb83f794 (nothing special about this commit) and got it to work.
Steps to reproduce:
Code is here: https://github.com/marsfoundation/spark-spells/tree/sc-62-create-the-august-2-spell-see-description
export ETH_RPC_URL=$GOERLI_RPC_URL
Ran forge create SparkGoerli_20230802 --verify
And got this:
Contract verification status:
Response: `NOTOK`
Details: `Fail - Unable to verify. Solidity Compilation Error: Source "lib/aave-helpers/lib/aave-address-book/lib/aave-v3-core/contracts/protocol/libraries/types/DataTypes.sol" not found: File not found.`
Contract failed to verify.

My current theory is that it is something to do with remappings.

Fixed with #5532 ! ^^


IOOS Compliance Checker sprint topic

Replace all italicized text and the issue title with your responses. Remove this text too.
Project Description:
Compliance Checker refactor and documentation/examples for plugins
Brief summary of the intent of the project.
Refactor and possibly change the calling conventions of compliance checker.  Make documentation for development of new plugins much easier.  Possibly address OceanGliders 1.0 standard, others as needed.
Expected Outcomes:
What do you expect to get out of the project
Improved documentation for Compliance Checker, improved calling conventions, adaptation of plugins to specific metadata standards such as OG 1.0
Skills required:
Python programming, basic understanding of NetCDF files and associated metadata standards (CF, ACDD, etc).
What types of skills does the prospective contributor need?
As above
Difficulty:
Moderate
Identify the difficulty of the project. [Easy, Moderate, Difficult]
Topic Lead(s):
Ben Adams
Include topic lead names and GitHub handles as a comma separated list.
Relevant links:
Include relevant links to issues/repositories/websites here.
https://github.com/ioos/compliance-checker
https://github.com/ioos/compliance-checker-web
https://github.com/ioos/cc-plugin-glider

@benjwadams I added your content to the website at: https://ioos.github.io/ioos-code-sprint/projects/01-compliance-checker-refactor/


[SPARK-50259][BUILD] Update Parquet-Java to 1.14.4

What changes were proposed in this pull request?

Testing out the RC
Why are the changes needed?
A serious issue was discovered in the 1.14.x line: https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.14.4-rc2

Does this PR introduce any user-facing change?

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

Link to tests: https://github.com/Fokko/spark/actions/runs/11720553983/job/32646109185

Thank you for updating the PR, @Fokko !

@dongjoon-hyun Any time, some minor fixes, so we should be good to go: https://github.com/apache/parquet-java/releases/tag/apache-parquet-1.14.4

Please make the PR description up-to-date and convert it from Draft to normal PR after the CI passes.

@dongjoon-hyun Thanks for pointing out, I've updated the template and converted the draft into a normal PR. 👍


Add notebook UI

Adds a notebook to a book or adds an standalone notebook to the Notebooks View
The FileType field is for adding a notebook or a markdown file.
This PR fixes #14553

Pull Request Test Coverage Report for Build 662126606

17 of 90 (18.89%)  changed or added relevant lines in 5 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.05%) to 43.306%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

extensions/notebook/src/dialog/createBookDialog.ts
0
1
0.0%

extensions/notebook/src/book/bookTreeView.ts
1
8
12.5%

extensions/notebook/src/book/bookTocManager.ts
4
19
21.05%

extensions/notebook/src/dialog/addNotebookDialog.ts
11
61
18.03%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/common/ports.ts
4
74.14%

Totals

Change from base Build 662026877:
-0.05%

Covered Lines:
25428

Relevant Lines:
53570

💛  - Coveralls

It would be good to check with UX on if we should be consistent in ADS on what the folder icons are since we use a blue folder icon in several dialogs in projects.

It would be good to check with UX on if we should be consistent in ADS on what the folder icons are since we use a blue folder icon in several dialogs in projects.

@kisantia, I'll check with Raden. Thank you for letting me know 😄


Example site

Adds example site at www.react-scroll-up-button.com
auto build using netlify
Also forces dev environment to use the example site.
Eslinting for test files.

Coverage remained the same at 100.0% when pulling e45156679b1677d60818fa3221c7d36d92133f03 on ExampleSite into 50149198c463ebe62c2e1fd125a0b9e1f87f6342 on master.


watching multiple files with live-reloading

I have a chrome window open on:
http://localhost:8080/test/change-emitter-no-instances/?GastonID=mac-desktop-chrome-564
and one on:
http://localhost:8080/test/change-emitter-instances/?GastonID=mac-desktop-chrome-807
*note they do have different ids
check this screenflow for more info
https://drive.google.com/open?id=0B7mWuLBqmIdxMmVxX2swZk1KS28
seems a bit random :unamused:

this is not a bug lets find a way to do this #42

I'm going to close this one because it's going to be managed on #42 (the answer to life, the universe and everything)


VDC data alters domain extents?

To reproduce:

vdccreate -dimension 10x10x10 -vars3d myVar bov.vdc

Load bov.vdc into Vapor, and a domain cube will be shown.

Optional: create a renderer note the extents in the geometry tab (0:0:0:0:0:0)

raw2vdc -varname myVar ~/bov5.vdc ~/bov.bin

Load bov.vdc into vapor and no domain is shown.  Extents are now 4.5:4.5:4.5:4.5:4.5:4.5?

bov.bin.zip
Solution?  The -extents flag defaults to an empty string with vdccreate.  Maybe set it to 0:0:0:1:1:1?

The "no domain" problem doesn't appear with larger grids.  I'm ok with closing this.