fix(index): deep cloning options (options.uglifyOptions)

Proper deep clone, as recommended by MDN:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Deep_Clone
Use case: I found my config.uglifyOptions object being altered when I passed it into uglifyjs-webpack-plugin. The properties "test" and "warningsFilter" were being added. I also have processes outside of webpack that use this object and it fails as these properties are not recognized by uglify-es/js.

Please share your webpack.config.js with the UglifyJSPlugin causing this aswell :)

@scott-thrillist @michael-ciniawsky Pretty sure this is already covered in #80

@hulkish interesting, this schema method is new to me. I'll test 😄

Not sure why this isn't installing the /dist directory but can't seem to test it.
"uglifyjs-webpack-plugin": "git+ssh://git@github.com:webpack-contrib/uglifyjs-webpack-plugin.git#hulkish-OptimizeAndValidateOptions"

@scott-thrillist try commenting this line on your local: https://github.com/webpack-contrib/uglifyjs-webpack-plugin/blob/master/test/helpers.js#L51

I think my install process may be wrong. I add that dependency line in my package.json, run an npm install and I only get these files in node_modules/uglifyjs-webpack-plugin:
CHANGELOG.md
LICENSE
options.json
package.json
README.md

So subdirectories for some reason.

@scott-thrillist make sure you're using npm >= 5

Yea totally:
npm -v
5.3.0

whats the full extent of the commands youre trying and whats the error you receive? Also, whats your node version?

Node v8.1.4

add dependency line to package.json
delete package-lock.json and node_modules folder to be safe :)
npm install
npm run build

Here's the error I get: Error: Cannot find module 'uglifyjs-webpack-plugin'

dont do this:
add dependency line to package.json
delete package-lock.json and node_modules folder to be safe :)

By doing this, you're essentially side-stepping the package-lock behavior.
do this instead:
git checkout package-lock.json
rm -rf node_modules
npm install
npm install <my dependency>

Really appreciate the help, though doing all of the above gives me the same result- no subdirectories in node_modules/uglifyjs-webpack-plugin. Here's my dependency line:
npm install uglifyjs-webpack-plugin@git://github.com/webpack-contrib/uglifyjs-webpack-plugin.git#hulkish-OptimizeAndValidateOptions

Yea dont do that, it won't really work correctly. Instead:
git clone https://github.com/webpack-contrib/uglifyjs-webpack-plugjn.git
cd uglifyjs-webpack-plugin
npm install
npm link
cd <path to my test project>
npm link uglifyjs-webpack-plugin>

That seems right. All my Googling kept referencing install by URL :p Apologies for taking up so much of your time. Will try it this way

No worries, the internet has a lot of misinformation on the topic.

Dont forget to npm run build inside uglifyjs-webpack-plugin dir

That said.. let me know if your issue is resolved in that PR  and ill close this.

Will do! I'm guessing passing this to UglifyJS() won't work anymore:
{
    warnings: false,
    mangle: {
        reserved: ['$super', '$', 'exports', 'require']
    }
}

Getting this: throw new _ValidationError2.default(ajv.errors, name);

@scott-thrillist try it:
node
> console.log(require('uglify-es').minify{({ foo: `const $super = 5 + 5; exports.foo = require('foo');`,
    warnings: false,
    mangle: {
        reserved: ['$super', '$', 'exports', 'require']
    }
}).code);

Sorry, I meant the new schema for uglifyjs-webpack-plugin

I see, yes the schema is a breaking change in that regard.

Unfortunately no. :(
const UglifyJSPlugin = require('uglifyjs-webpack-plugin');

let ugOpts = {
    warnings: false,
    mangle: {
        reserved: ['$super', '$', 'exports', 'require']
    }
};

module.exports.plugins = [

    new UglifyJSPlugin(ugOpts),

    function(){
        this.plugin("compile", function(){
            console.log(ugOpts);  // ok
        });
        this.plugin("done", function(){
            console.log(ugOpts);  // has a bunch of new properties inserted (see below)
        });
    }
];

{ warnings: false,
  mangle:
   { reserved:
      [ '$super',
        '$',
        'exports',
        'require',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments',
        'arguments' ],
     cache: null,
     eval: false,
     ie8: false,
     keep_classnames: false,
     keep_fnames: false,
     properties: false,
     safari10: false,
     toplevel: false } }

I got back and forth on this, but in the end I think best practice would be for me to deep clone my own data before sending it to a plugin, mainly because the nature of open source plugins can do anything they want with the data you provide.
If you don't have any other feedback on this issue feel free to close this PR. And thanks again for being patient with my testing.

I think handling the deep clone in your implementation is probably best bet. Mainly because this is not an issue which is exclusive to this plugin.
For ex... if you were to do the same test with your actual webpack config.. you will see your original webpack config object be mutated. Which I realize is generally not a good idea from a purist perspective... but the reality is that by solving this here wouldn't really be solving the problem as a whole imo.

Oh I forgot to mention the best part. It now builds fine with my vanilla uglify-es processes in the done callback. So at least the newly added properties play nicely now. 👍

Awesome... I'm thinking we can close this now considering previous convo... agreed?

Yes, done


Use real exec on cfg(unix) targets

Closes https://github.com/rust-lang/miri/issues/2421
The standard library has a platform extension trait that lets us get the behavior we want on cfg(unix), so why not use it?
I tried this out and it produces the correct behavior in concert with nextest.

Hunh, didn't know about the tests for cargo-miri. Definitely not the right behavior here...

Well I now know how to use pipe2, though I'm really not sure if this the implementation we really want to go with. I dislike that I need to resort to using libc here, as far as I can tell there is no way to work with pipes in the standard library.

Ahhhh that's why the standard library doesn't just pipe2 for all cfg(unix). I'll switch it to just pipe later.

Well I now know how to use pipe2, though I'm really not sure if this the implementation we really want to go with. I dislike that I need to resort to using libc here, as far as I can tell there is no way to work with pipes in the standard library.

Yeah, I came to about the same conclusion. OTOH finding a location for a temporary file could also be annoying. And who's going to clean up that file?

@rustbot ready

@rustbot author

By the way, I've now read every piece of documentation on pipes that I could find and oh boy there is not very much. I was reminded that pipes have a finite capacity which is not particularly huge. MacOS is probably 16 kB by default? Linux is probably 64 kB by default? I'm just extra wary of these limits now, because the "actually exec" implementation doesn't have the child process running so if the file contents don't fit in the pipe... :shrug: we just panic from an expect I think.
My Macbook reports that its pipe size is 512 bytes via ulimit -a which seems awfully small but this branch can run doctests on it just fine :shrug:

Yeah I was wondering about pipe size issues... maybe the more robust solution is to store the input in a separate file next to the JSON, and then pass that file as stdin? Though that does make me wonder about who's going to clean up those files. (Well I already wonder that with the new *_miri files this PR starts creating.)

Hunh. The rust_out_miri files are getting cleaned up. It looks like rustdoc creates them using the tempfile crate. I need to sleep, but maybe that suggests a way to clean up a stdin file?

On Unix you can open a file and delete it and it'll get actually deleted when it gets closed... but I am not sure if that is possible on Windows.

Good thing we don't need that sort of pattern on Windows then?

Oh yeah I guess for now we're only try to real-exec on Unix, fair.

@rustbot ready

Just one more comment, then please squash it all and we're good to go. :)

@bors r+

:pushpin: Commit 622613f957e07ffe1398fa17bc84f185e62df27f has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 622613f957e07ffe1398fa17bc84f185e62df27f with merge a719c058162804480358ef16c9e3ca1c8f5e3957...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing a719c058162804480358ef16c9e3ca1c8f5e3957 to master...


running FreeU on SM_52 cards

hello. i'm trying to use freeU with SD1.5 on a TitanX 12Gb card and i get this message :
RuntimeError: cuFFT doesn't support signals of half type with compute capability less than SM_53, but the device containing input half tensor only has SM_52
the strange thing is that it runs perfectly when used with SDXL so i was wondering ..
(i'm using diffusers)

diffusers version: 0.27.0
Platform: Linux-5.15.0-94-generic-x86_64-with-glibc2.29
Python version: 3.8.0
PyTorch version (GPU?): 2.2.1+cu121 (True)
Huggingface_hub version: 0.21.4
Transformers version: 4.38.2
Accelerate version: 0.27.2
xFormers version: not installed

错误的根本原因是你的 GPU 计算能力为 SM_52，不支持 cuFFT 中的半精度浮点数操作。
你可以通过将数据类型改为 float32 或将计算迁移到更高计算能力的设备上来解决此问题。


Verfication Script

Verfication Script
After installation via the shell script , there is no script for verifying whether the particular tool , program,etc. is installed.
A shell script can be made to check whether  all programs are properly installed
Please use proper comments and coding style for the verification script
Blocking Time
Max Blocking time for this issue is 1.5 hour
[You have to update progress every 1.5 hrs]
Bounty Points
Bounty Points for fixing : 30 points

May the FOSS be with you

can i work on this?

Done @BhaviniMadhuranath

Try fixing this issue if you can


ARROW-14343: [Packaging][Python] Enable NEON SIMD optimization for M1 wheels

Depends on https://github.com/apache/arrow/pull/11431

@github-actions crossbow submit wheel-macos--arm64 wheel-macos--universal2


Simplify admin user flow for managing translations and application statuses

Is your feature request related to a problem? Please describe.
Currently CF Admins are not able to access the features “Manage translations” and “Manage application statuses” when a program is active (no draft in progress).  This means that if a user wants to add translations to an active program, they have to click "Edit", then click "Edit program details", and click "Save" (without any actual edits) so that a draft will be created.  Then they go back to the program list and click the kabob menu on the draft, where they will see the "Manage translations" and "Manage statuses" menu items.  This seems like a complicated user flow.
Proposed solution
Adding two options (“Manage translations” and “Manage application statuses”) to the overflow options for active programs. Clicking on one of these options would create a draft for an admin, if there isn’t one already, and take them directly to the specific page.
Additional context

Done when
An admin user can easily manage translations and statuses for programs and questions.

@sijiayam I created this after our conversation about this admin user flow.


Use ungated version of mistral tokenizer

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


add tests for alignment on array initialization

This adds regression tests for https://github.com/rust-lang/miri/issues/1925, https://github.com/rust-lang/miri/issues/1919.

@bors r+

:pushpin: Commit ee666d8987f29a86a8bd37a85aecc9608ba2d2eb has been approved by RalfJung

:hourglass: Testing commit ee666d8987f29a86a8bd37a85aecc9608ba2d2eb with merge 9983e0fc634e11717eb457a73fe84cfc9409ba8f...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 9983e0fc634e11717eb457a73fe84cfc9409ba8f to master...


How to make horizontal scrollbar visible on top of the div instead of the bottom?

Hi,
Please add following lines to your css.
.ps-container .ps-scrollbar-x-rail {
  top: 3px;
  bottom: auto; /* If using `top`, there shouldn't be a `bottom`. */
}

You can also find an example for the case in examples/scrollbars-on-the-opposite-side.htm.
Cheers,


Update Add-AzureADDirectoryRoleMember.md

@VinceSmith,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Adding additional example showing how to instantiate a role instance before assigning it.


Add support to update/delete composite keys models

@bendrucker Regaring #420.
As @cbollerud said, we could be missing something.
This update to the sync code allows to simply
entity.save(data)

on an instance of
// Simplified/dummy model.
bookshelf.Model.extend({
  idAttribute: ['fooId', 'barId'],
  tableName: 'foobar'
}

Whitout Error: column "0" does not exist.
Note: This code could be buggy and is not tested yet.

I'll need tests before I can review this

Wrong approach. Closing it.


Messages: Separate buzz pattern for incoming calls

As suggested here: http://forum.espruino.com/conversations/376923/newest/

@myxor I've noticed a bug in the current buzzing behavior, as it will ignore the 'Vibrate: Off' setting.
The same bug is in your version of the code, as it's very subtle and hard to track down.
See #2023 .

@LeonMatthes  thank you for your feedback. I integrated your fix into my branch with commit https://github.com/espruino/BangleApps/pull/2005/commits/d82454f942f3790996a3aede3c62a01dbc7d2b71.

Looks good - thanks!


audioop not found

C:\GeminiDiscord\Gemini_Discordbot\geminidiscordbot.py:299: SyntaxWarning: invalid escape sequence '\.'
  '(youtube|youtu|youtube-nocookie)\.(com|be)/'
C:\GeminiDiscord\Gemini_Discordbot\geminidiscordbot.py:300: SyntaxWarning: invalid escape sequence '\?'
  '(watch\?v=|embed/|v/|.+\?v=)?([^&=%\?]{11})'
Traceback (most recent call last):
  File "C:\GeminiDiscord\Gemini_Discordbot\geminidiscordbot.py", line 1, in <module>
    import discord
  File "C:\Users\eddis\AppData\Local\Programs\Python\Python313\Lib\site-packages\discord\__init__.py", line 23, in <module>
    from .client import *
  File "C:\Users\eddis\AppData\Local\Programs\Python\Python313\Lib\site-packages\discord\client.py", line 51, in <module>
    from .sku import SKU, Entitlement
  File "C:\Users\eddis\AppData\Local\Programs\Python\Python313\Lib\site-packages\discord\sku.py", line 31, in <module>
    from .app_commands import MissingApplicationID
  File "C:\Users\eddis\AppData\Local\Programs\Python\Python313\Lib\site-packages\discord\app_commands\__init__.py", line 12, in <module>
    from .commands import *
  File "C:\Users\eddis\AppData\Local\Programs\Python\Python313\Lib\site-packages\discord\app_commands\commands.py", line 53, in <module>
    from .models import Choice
  File "C:\Users\eddis\AppData\Local\Programs\Python\Python313\Lib\site-packages\discord\app_commands\models.py", line 44, in <module>
    from ..member import Member
  File "C:\Users\eddis\AppData\Local\Programs\Python\Python313\Lib\site-packages\discord\member.py", line 33, in <module>
    import discord.abc
  File "C:\Users\eddis\AppData\Local\Programs\Python\Python313\Lib\site-packages\discord\abc.py", line 59, in <module>
    from .voice_client import VoiceClient, VoiceProtocol
  File "C:\Users\eddis\AppData\Local\Programs\Python\Python313\Lib\site-packages\discord\voice_client.py", line 35, in <module>
    from .player import AudioPlayer, AudioSource
  File "C:\Users\eddis\AppData\Local\Programs\Python\Python313\Lib\site-packages\discord\player.py", line 29, in <module>
    import audioop
ModuleNotFoundError: No module named 'audioop'

what am i doing wrong?

What did you send it to do?

see this pull request:
https://github.com/Echoshard/Gemini_Discordbot/pull/18


Allow stylesheets to resolve other stylesheets via export conditions

Clear and concise description of the problem
Given a package with the following exports:
{
  "name": "@example/my-pkg",
  "type": "module",
  "exports": {
    ".": {
      "import": "./dist/my-library.js",
      "require": "./dist/my-library.js",
      "sass": "./index.scss",
      "style": "./dist/my-library.css"
    },
    "./package.json": "./package.json"
}

Developers should be able to write a Sass stylesheet for their application like this:
@use '@example/my-pkg'; // resolves to<EMAIL_ADDRESS>
Suggested solution
The CSS plugin should create resolvers which copy the mainFields option to conditions. Additionally, to match webpack's capabilities, the resolve plugin needs to pass unsafe: true to resolve.exports since we want to ignore import and require conditions when a stylesheet is making a request.
This should be doable with a new internal resolve option. Within Vite, import should only be assumed when JS modules and scripts are the importer. So in addition to the isFromTsImporter option, we should also track isFromJsImporter. Then, when the importer is JS or TS, we disable unsafe and allow resolve.exports to use import/require and node/browser conditions.
Alternative
Once CSS resolvers are passing their conditions, instead of checking for a JS importer, we ask library authors to order their style/less/sass conditions before the import/require/browser/node conditions in the exports map. I'm not in favor of this though because I believe bundlers should be opting out of these ESM/CJS conditions when when the resolver exits a JS context.
Additional context
Docs for resolve.exports's unsafe option:
https://github.com/lukeed/resolve.exports#optionsunsafe
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

It looks like the isFromJsImporter solution won't work, we don't know the importer when the CSS is loaded from index.html. Short-term, a isFromCssImporter flag will work better. I could update the HTML plugin to append a query param onto the generated import request signaling the expected module type, but I'd like to keep the scope of this fix a bit smaller. I think this is actually an ideal situation for import assertions.


rio stage -e fails with  invalid character

Describe the bug
I run rio stage -e , and after making some trivial change in the yaml,
the editor opens up repeatedly with: "Error updating content: invalid character 'a' looking for beginning of value"
To Reproduce
Steps to reproduce the behavior:

rio run --name=nginx --env=ANSWER=41 -p 80 nginx
rio stage -e nginx
change 41 to 42 save/exit

Expected behavior
Kubernetes version & type (GKE, on-prem): kubectl version
Client Version: v1.16.0
Server Version: v1.15.3

Type:
Rio version: rio info
Rio Version: v0.5.0 (303f3652)
Rio CLI Version: v0.5.0 (303f3652)
Cluster Domain: 4XXXXX4.on-rio.io
Cluster Domain IPs: 51.XXX.XX.118
System Namespace: rio-system

System Components:
activator status: running
autoscaler status: running
build-controller status: running
buildkitd-dev status: running
cert-manager status: running
controller status: running
gateway status: running
istio-pilot status: running
registry status: running
webhook status: running

Additional context
rio systemlog
output:
No help topic for 'systemlog'

@cbron Are you be able to test this on v0.6 see if it will be fixed?

Yes this was a bug in 0.5, it has been fixed on 0.6.

I confirm, I just built the latest from master:
> rio --version
rio version v0.6.0-alpha.2 (d9675e43)

and its not an issue anymore.

btw, thanks for the quick response


Changing critical memory level alert to average

@dak1n1 reviewed in stg: https://github.com/openshift/openshift-tools/pull/2249


improve for testings log_file_level = DEBUG

Purpose of PR?:
Fixes #2221
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:

[ ] Bug fix. Fixes #
[ ] New feature (Non-API breaking changes that adds functionality)
[ ] PR Title follows the convention of  <type>: <subject>
[ ] Commit has unit tests

@joernu76 Do you want debug loggings for the wms?

For my problem this change did not help, because https://github.com/Open-MSS/MSS/blob/develop/pytest.ini#L6
forces log_file_level = DEBUG not only in our library.

This looks fine!
However, the/a major problem is that the matplotlib library floods us with messages.
This is a humongous issue also with production servers.
Could you leave our stuff on DEBUG, but set the matplotlib logger to info? That would be very, veeery helpful.

Will that be continued?

Will this work @ReimarBauer ?


Fix: highlight sidebar's active section

fix: highlight active sidebar's section (regression from #2166)
fix: caching crd definitions to prevent sidebar's scroll jumps
refactored & simplified Sidebar and SidebarItem

Before:
https://user-images.githubusercontent.com/6377066/111791141-9c7b5880-88cb-11eb-901a-bfb925ca5b0e.mov
After:
https://user-images.githubusercontent.com/6377066/111791121-95ece100-88cb-11eb-9ba2-e6e4735712f4.mov

@Nokel81 ready for re-review, PTAL.

Looks good, can you do a follow up PR to remove submenu? So that they are just children?

Yes!

Next time please don't merge as it make my work with releases slightly more complicated (this is really only a problem when an active release is in progress). Thanks.

Next time please don't merge as it make my work with releases slightly more complicated (this is really only a problem when an active release is in progress). Thanks.

Alright! Usually you say it when you need to wait some time for various reasons.

True, sorry.


feat: add issue template for docs

For an example of how to fill this template out, see this Pull Request in the Wiki.
Description
This PR adds an issue template for documentation.

Fixes Issue
Closes #5

Acceptance Criteria

[X] in the .github folder create a folder called ISSUE_TEMPLATE
[X]  in the folder ISSUE_TEMPLATE create a file called docs.yml
[X]  for the name use: 📄 Documentation issue
[X]  for the description use: Found an issue in the documentation? You can use this one!
[X]  for the labels use: ["📄 aspect: text"]
[X]  in the body, add three type textarea
[X]  each of these textarea has an unique id, description, screenshots and extrainfo
[X]  each type has 2 attributes: a label and a description. Come up with own text. Hint look in other repositories which uses issue templates to get inspiration what to write
[X]  each type has a validations, set to true for the description and false to screenshots and extrainfo

Type of Changes

Make sure your code follows the code style of this project.
Make sure your code is up2date.
The title of the PR is the same as the title of the issue.

Type

:bug: Bug fix

X
:sparkles: New feature

:hammer: Refactoring

:100: Add tests

:link: Update dependencies

:scroll: Docs

Updates
Before

After

Testing Steps / QA Criteria

Well done @CBID2 👏🏽 Thanks for contributing to the project.


Fails to build in Release mode on macOS 10.13.4/Xcode 9.3

I tried building ion-c: the debug build works fine (./build-debug.sh) but the release build fails with the error:
[ 71%] Linking CXX executable all_tests
Undefined symbols for architecture x86_64:
  "join_path(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >)", referenced from:
      __GLOBAL__sub_I_test_vectors.cpp in test_vectors.cpp.o
      IonCli_ProcessBasic_Test::TestBody() in test_ion_cli.cpp.o
      IonCli_CompareNullsBasic_Test::TestBody() in test_ion_cli.cpp.o
      IonCli_CompareListsEquivs_Test::TestBody() in test_ion_cli.cpp.o
      IonCli_CompareSexpsNonequivs_Test::TestBody() in test_ion_cli.cpp.o
      IonCli_CompareAnnotatedIvmsEmbeddedNonequivs_Test::TestBody() in test_ion_cli.cpp.o
      IonCli_CompareMultipleInputFiles_Test::TestBody() in test_ion_cli.cpp.o
      ...
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [test/all_tests] Error 1
make[1]: *** [test/CMakeFiles/all_tests.dir/all] Error 2
make: *** [all] Error 2

I'm using the latest master branch (0903060fdc83c1c931aa9530d52b4a9ba9491e37), macOS 10.13.4, the Clang that came with Xcode 9.3, and latest CMake from Homebrew:
$ clang --version
Apple LLVM version 9.1.0 (clang-9<IP_ADDRESS>)
Target: x86_64-apple-darwin17.5.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
$ cmake --version
cmake version 3.11.2

@zhuowei Thanks for the report. I'm looking into this.

I was able to reproduce the issue on my machine, and solved it by removing some inline declarations for shared functions. For some reason, the linking behavior for these differed between build configurations.
I also updated our Travis and AppVeyor config to build and test both the debug and the release configuration, which should prevent this from happening again.
@zhuowei If this doesn't solve your problem please let us know.

@tgregg Removing the inline was the workaround I used locally, so it should work.
Thank you so much for the prompt response and fix!


[ MB-16199 ] Ensure service items have an origin and final destination address

Refactoring NewMTOServiceItemUpdater;
Making the function signatures more legible;

Click here for the Jira ticket
Summary
The goal of this patch is to have DDDSIT service items create a destination
origin address. This will allow for the address change calculations introduced
in #10649 and will help unblock other user stories as well.
Verification Steps for the Author
These are to be checked by the author.

[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.
Setup to Run the Code

Instructions for starting storybook
Instructions for starting the MilMove application
Instructions for running tests

How to test
More information on how to properly test this manually coming soon...

Messages

:book:
:link: MB-16199

  Generated by :no_entry_sign: dangerJS against e332b65d7153fe9e4c9196ffee8f721ca1d094d4

Currently, this does not include any changes around adding the SIT Final Destination Address in the Create MTO Service Item request. We will need to add this if tomorrow's meeting determines we should.

Okay, I've refactored based on the feedback I received here. Thanks folks.

@Mergifyio update

Functionally this looks good to me. I tested the scenario where the prime provides a final destination address and when they don't. I didn't test the scenario where there isn't a shipment destination (I think there's another ticket to populate this).

@Mergifyio update

I'll update our test scenarios after this gets merged in on a separate PR.

https://github.com/transcom/mymove/pull/10880


Multitouch capabilities of Synaptics Touchpad with VoodooPS2 2.2.9 (Acidanthera)

Dear Chris
Maybe you know, but I wanted to share with you a situation I discovered by chance.

I downloaded VoodooPS2 from Kext Updater/ Kextmanager/ NightlyBuilds
I opened VoodooPS2Trackpad.kext's Info.plist file with PlistEditor
I deleted ALPS GlidePoint and Elantech TouchPad under IOKitPersonalities. (it works even if it is not deleted, but it takes a long time to boot)
I dumped it to EFI/OC/kext and processed it to the config file. (VoodooPS2Mouse.kext passive)
I cleared the NVRAM while restarting the computer and the synaptics PS2 trackpad's multitouch features are now available.

NOTE1: Not Working: Trackpad's left and right physical buttons
NOTE2: The DEBUG version of VoodooPS2Controller.kext, which I got directly from Acidanthera's site, worked, but RELEASE does not work.
I hope you will find a solution to make the left and right buttons work.
I wish you good work.
I prepare my EFI with your HP-Probook-EliteBook-Package-Creator-OC program

My laptop is Probook 6470b

My laptop is Probook 6470b

Bruh, thx for guide on multitouch, i take it, but have same problem lft/rght keys doesnt work.
Pls tell me, you find soluition ?

Sorry I haven't found a solution yet


Disable popup

How to disable it => https://postimg.cc/Y4v9jQFX

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


Correct dust and change

Correct dust threshold, which is never less than 1 DOGE.
Correct minimum change, which is 1 DOGE.

Ждите через час отвечу
<EMAIL_ADDRESS>-----Исходное сообщение-----
От: "Max K."<EMAIL_ADDRESS>Отправлено: 03.11.2019 19:43
Кому: "dogecoin/dogecoin"<EMAIL_ADDRESS>Копия: "Subscribed"<EMAIL_ADDRESS>Тема: Re: [dogecoin/dogecoin] Correct dust and change (#1615)
Merged #1615 into 1.14-maint.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Dog error stop job
<EMAIL_ADDRESS>-----Исходное сообщение-----
От: "Max K."<EMAIL_ADDRESS>Отправлено: 03.11.2019 19:43
Кому: "dogecoin/dogecoin"<EMAIL_ADDRESS>Копия: "Subscribed"<EMAIL_ADDRESS>Тема: Re: [dogecoin/dogecoin] Correct dust and change (#1615)
Merged #1615 into 1.14-maint.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.


Patch #909 to build with Xcode 11 or Xcode 12 beta

Pull app clips out of TestProject/project.yml
Move to TestProject/project-xcode-12.yml
Generate new fixtures
Update build script to selectively build Xcode 12 based on selected xcode version
Add Xcode 12 beta to matrix

Currently, GitHub Actions uses 12b2
12b3 has known issues with Carthage so this may stop working at some point without applying workarounds to skip building for ARM macs

@brentleyjones Updated. Unfortunately, there's an issue with Spectre preventing Xcodegen from building with Xcode 12 at the moment, so I removed that entry from ci.yaml

Thanks @dflems!


add legal repo name check

What this PR does / why we need it:
FIX The issue "Helm repo_name naming conventions" #10460, check repo name if contains "/"
closes #10460
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[*] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

HI @zonggen & @yxxhero ， Thanks for code review . Is there more comments about the PR ?

@yank1  Thans for your PR. I think all is ok. This PR need core maintainer to approve.  @hickeyma

HI @hickeyma , would you please review it?

Needs review from another @helm/helm-classic-maintainers to be merged.

HI, @scottrigby would you please review the PR ? Thanks very much.

@mattfarina, thank you

I think this is technically a breaking change which has been released in a patch. It's subtle but it took some time for me to figure out why our ArgoCD diffs started failing all of the sudden.
For example:
time="2022-03-10T20:17:33Z" level=info msg="helm repo add https://strimzi.io/charts https://strimzi.io/charts" dir=charts/kafka-operator execID=1c29d
time="2022-03-10T20:17:33Z" level=error msg="`helm repo add https://strimzi.io/charts [https://strimzi.io/charts`](https://strimzi.io/charts%60) failed exit status 1: Error: repository name (https://strimzi.io/charts) contains '/', please specify a different name without '/'" execID=1c29d
time="2022-03-10T20:17:33Z" level=info msg=Trace args="[helm repo add https://strimzi.io/charts https://strimzi.io/charts]" dir=charts/kafka-operator operation_name="exec helm" time_ms=26.396266

@moustafab can you please comment on the point raised in https://github.com/helm/helm/issues/10460#issue-1079420732? According to the bug report, repository names containing forward slashes do not work in all cases because it wasn't considered a valid repository name.
The example OP described was:
$ helm repo add hub/library https://hub/chartrepo/library

Works, but then you cannot pull down a chart:
$ helm pull hub/library/elasticsearch
Error: chart "library/elasticsearch" matching not found in hub index (try 'helm repo update'): no chart found

On the point of breaking changes, I think this falls under acceptable breaking changes. A repository name like https://strimzi.io/charts wasn't considered a valid repository name, and we never considered that with helm repo add's original design. However, if you can demonstrate that this repository name works under all normal conditions, perhaps we should grandfather it in as a "hack".


build: simplify macOS path (NFC)

It does not make sense to use the cl frontend to clang to build for
macOS.  Remove the unnecessary condition and always perform the
operation.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

CC: @edymtt @drexin

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - f5a75dcefdae8bfd9c591d62c0278ac27d6f7520

@swift-ci test linux

Build failed
Swift Test Linux Platform
Git Sha - f5a75dcefdae8bfd9c591d62c0278ac27d6f7520

@swift-ci please test Linux platform


Fix minor typos.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ Googlers: Go here for more info.

@googlebot  I signed it!

Since the framework is still in pre-release mode, I think typos would not matter. Hence, I'm closing this PR.


await / pipe first precedence

await server->start

is parsed/printed as
(await server)->start

I would have expected it to mean
await (server->start)

Also,
(await (server->start))->ignore

loses the await on reformat:
server->start->ignore

This use parseUnaryExpr like other unary expressions.
Some exploration needs to be done about the implications of changing that.

My second comment (losing await) is clearly a bug though - shall I put that into a separate issue?

My second comment (losing await) is clearly a bug though - shall I put that into a separate issue?

Yes please

So, what is the precedence between await and pipe-first? await (server->start) is the expected one, pipe-first is greater than await?

What about - server->start

From googling JS: "An AwaitExpression is a UnaryExpression and has the same precedence as delete, void, typeof, +, -, ~, and !, binding stronger than any binary operator."
We should check that this is true and conform to that.

So the real question seems to be about pipe, not about await.

What about - server->start

Exactly. If we can tell await is a unary operator and pipe-first is a binary operator, negation, await and binary operators are just functions. So, we can say associativity as (-> (await server) start) or (await (-> server start)), both are possible.

From googling JS: "An AwaitExpression is a UnaryExpression and has the same precedence as delete, void, typeof, +, -, ~, and !, binding stronger than any binary operator."
We should check that this is true and conform to that.

It seems correct.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Operator_Precedence

My thinking was that
await server->start

corresponds to a method call in JS:
await server.start();

which is the same as
await (server.start());

My thinking was that

await server->start

corresponds to a method call in JS:

await server.start();

which is the same as

await (server.start());

This is a comment about pipe not await.
Someone should check how the priority for pipe was set, and what are the trade-offs.

Someone should check how the priority for pipe was set, and what are the trade-offs.

"Organically through some trial and error while trying to fix some Reason problems and it still isn't perfect for all use cases"

Anything specifically about unary operators? And in fact binary operators.
As if pipe has a higher priority than unary then it must have higher priority than binary too.

I didn't look into the parseUnary and parseBinaray in detail yet. But, the precedence of pipe-first is greater than await. https://github.com/rescript-lang/syntax/blob/d64839e3deae9ecb9a5507b18981292dc6e3ec9f/src/res_token.ml#L100
That means await e1->e2 is parsed to (await (e1->e2)) if the precedence logic is affected correctly.

Today I grab some time to look at the parse await, unary, binary expression. IMHO, there are two strange things to me.

parseAwaitExpression use parseUnaryExpr. Why not use just parseExpr?
await is not affected by precedence rules

It's a unary operator that behaves like other unary operators (- e or lazy e), and the JS standard says it's unary operator.
What's strange about it?

What I’m thinking strange about is the precendence.

op1 op2 a op3 b

op1, 2, 3 needs to be parsed by the precedence, no matter it is unary or binary. But await is not affected by precedence rule now. It has just parsed expression right next to it.

If it's parsed differently (with other priority) competed to other unset operators, it's interesting to know.
What are examples?

Assuming the discussion ends up on: what's the precedence of pipe.
Here's some TC39 proposal:
https://github.com/tc39/proposal-pipeline-operator
The pipe operator’s precedence is the same as:

the function arrow =>;
the assignment operators =, +=, etc.;
the generator operators yield and yield *;
It is tighter than only the comma operator ,.
It is looser than all other operators.

Thanks for the clarified reference.
Maybe I have to open another issue for my question. Don't we have to put await in the precedence rule and parse await expression in different way?

There's no "precedence rule". The precedences are: whatever the parser gives you.
So the level of precedence is implicit in the code.
I believe await has the same precedence as other unary operators, and higher than for example binary operators.

Don't we have to put await in the precedence rule and parse await expression in different way?
It's difficult to answer a question like that.
A more concrete comment has this form: here's one expression, here's how it is parsed, I think it should instead be parsed as ...

There's no "precedence rule". The precedences are: whatever the parser gives you. So the level of precedence is implicit in the code. I believe await has the same precedence as other unary operators, and higher than for example binary operators.

Indeed. I think my expression rule was misread.

A more concrete comment has this form: here's one expression, here's how it is parsed (the AST), I think it should instead be parsed as ... (another AST).

Good! I'll clean up my thought and leave an issue later.

Hmm, I'm reading the above as await (a->b).
-> is currently being parsed as a normal binary operator in parseBinaryExpr. We might want to change this behavior.
First step would be gathering all the possible examples.

Basically, if one wants to try to make -> behave the same way as application, one can start from parseCallExpr, see how it's triggered by (, and implement a similar behaviour triggered by ->.
This is going to interpret await a->b as await (a->b) just as -f("3") is currently interpreted as -(f("3")).
Then see what the consequences of the change are. (And the printer needs similar changes).

I don't really understand the binary/unary-stuff, but I believe this should be optimized for what people expect, what the most common use cases are, and for what results in the clearest and easiest to understand code.
To me let result = await object->async_method(arg) looks like an extremely common use case, and requiring await (object->async_method(arg)) seems a bit awful, to be honest.
I'm currently working on a program that uses Playwright pretty heavily, and probably will have hundreds of lines of await object->async_method(arg) (almost every action is triggered via an async method).
On the other hand, await async_function(arg)->handle_result() also doesn't seem great.
(await async_function(arg))->handle_result() would make it clearer and easier to visually parse what is going on, I believe.
Besides that, I would expect that a keyword has a lower precedence than an operator. Is there an example, where a ReScript keyword has higher precedence than an operator?

This can be used for testing https://github.com/rescript-lang/syntax/pull/711

Tested, seems to work fine, except that the printer adds unnecessary parentheses in this case:
(await server->start)->ignore

->
(await (server->start))->ignore


fixes for pydantic in gpt_langchain.py

Motivation
Just before a686d7d89f55bb0d5f918a995df1ed98e7e9e73a which temporarily disabled DocuChat/langchain I was getting the following error, when running the ui/web after manually installing the langchain dependency:
Traceback (most recent call last):
  File "C:\develop\SHARK\apps\stable_diffusion\web\index.py", line 94, in <module>
    from apps.stable_diffusion.web.ui.utils import create_custom_models_folders
  File "C:\develop\SHARK\apps\stable_diffusion\web\ui\__init__.py", line 82, in <module>
    from apps.stable_diffusion.web.ui.h2ogpt import h2ogpt_upload, h2ogpt_web
  File "C:\develop\SHARK\apps\stable_diffusion\web\ui\h2ogpt.py", line 15, in <module>
    from gpt_langchain import (
  File "C:\develop\SHARK\apps\language_models\langchain\gpt_langchain.py", line 418, in <module>
    class GradioInference(LLM):
  File "pydantic\main.py", line 186, in pydantic.main.ModelMetaclass.__new__
  File "pydantic\utils.py", line 167, in pydantic.utils.validate_field_name

NameError: Field name "stream" shadows a BaseModel attribute; use a different field name with "alias='stream'".

Possibly DNM, because I don't know how relevant this is in real life.
Changes

Follow the advice in the above error and change 'stream' instance variables to 'stream_output' and aliased them back to 'stream' to clear clash with Pydantic BaseModel.

Problems/Concerns

May not be relevant with this disabled.
May have been a dependency issue on my part.
My first use of pydantic was on an internal work project today, so I'm not familiar with it at all.

@vivekkhandelwal1 please review if we need this

@vivekkhandelwal1 please review if we need this

Sure, I will first locally test this patch and then review it.


What is frame filter in task setting of admin page?

I can't find any description of the admin page.
when I change the setting about the task, Frame filter setting can't be empty. but I don't know the meaning about the setting of frame filter.

@FLming
Yes, we know about this bug. You can set there step=1.


PushError: push.js is incompatible with browser.

this error is displayed when using Safari in IOS

this was due to an outdated push version. It's working with v1.0.9


Added new logs

Added hooks for exception, trace, table and onerror.

This looks good to me!

Nice, thanks @hbcarlos!


fix(params): specify func's takes no args

Make sure that functions that take no arguments does not not take "any number of parameters of unknown types"

Done! Thank you for your suggestions for improvement! :)


push base setting upon init

This fixes #3
According to SQ docs,

This should be the bare minimum option that the library should be initialized with. The user info can be pushed later with .identify() calls. Without this, there will be an error in the console upon init because it's looking for the init method in the queue.
@segment-integrations/core

LGTM


tslint? thinks SubmittableExtrinsic is a Method

whenever we want to construct an extrinsic to submit we go through the pattern of doing:
const extrinsic: SubmittableExtrinsic<'rxjs'> = api.tx.method.call(param)
then we do the validation dance and if all goes well finally enqueue it to the TxQueue.
TxQueue expects the extrinsic we submit to be a SubmittableExtrinsic<'rxjs'>, but tslint thinks the above extrinsic is actually a Method, i.e. not decorated with the send, sendAndSubscribe, etc.
Seeing as the extrinsics actually do go through successfully if we ts-ignore it, this seems to be a type checking issue somewhere somehow.

Log it in in polkadot-js/api (assuming you are on a relative new beta), @amaurymartiny may have an idea.

seems to be fixed with latest api


Warnings in numpy backend

The numpy backend prints several types of warnings, including division by zero, invalid operation, and overflow, even when these operations do not have an effect on the answer. While this is not a functionality problem, it is not a great user experience. Division by zero example:
@gtscript.stencil(rebuild=True, backend="numpy")
def copy_stencil(in_storage: gtscript.Field[float], out_storage: gtscript.Field[float]):
    with computation(PARALLEL), interval(...):
        out_storage = 0
        if in_storage[0,0,0] > 0:
            out_storage = 1 / in_storage

#132 provides a quick fix to ignore the issue, but as @ofuhrer pointed out, it could be implemented differently using a field of booleans, then a statement like a[flag] = 1/b[flag]. This idea could be further used for run-time conditionals in other backends as well, and would allow for splitting the block statements inside conditional if-else blocks. Should we consider this type of fix instead?

Fixed in #132.


[core] Missing method calls for javax.inject.Provider

Hey!
I've noticed that jadx by some reason misses calls for javax.inject.Provider.get(). An example is in the com/ebay/common/ObfuscatedData_Factory.java where repositoryProvider and encoderProvider are declared as javax.inject.Provider
    private final javax.inject.Provider<com.ebay.mobile.crypto.EbaySecureDataEncoder> encoderProvider;
    private final javax.inject.Provider<com.ebay.mobile.environment.EnvironmentRepository> repositoryProvider;

but then the get() call is missing:
    public com.ebay.common.ObfuscatedData getInlineMessagesLifeCycleViewModel() {
        return newInstance(this.repositoryProvider.getInlineMessagesLifeCycleViewModel(), this.encoderProvider.getInlineMessagesLifeCycleViewModel());
    }

APK: https://drive.google.com/file/d/1NEIPWFwukzv1BgJDHpaqKZAznMf25lqW/view?usp=sharing

Additionally, jadx renames overridden methods leading to errors. The provided getInlineMessagesLifeCycleViewModel was renamed from the correct get()


Map Rust's snake_case fields to/from Json's camelCase

I'm not sure if this is possible in serde, but it would be nice if json fields in camel case could be mapped to snake case rust field names, either explicitly via some macros or automatically by the deserializer. This way one could adhere to conventions in naming both on the frontend and backend (camel in json/JS, snake in Rust).
My apologies if this feature exists and I simply missed it, I'd appreciate some pointers.

You can use serde(rename_all = "camelCase") on a struct to map the fields this way.
#[derive(Deserialize)]
#[serde(rename_all = "camelCase")]
struct Mandreyel {
    aaa_aaa: u8, // deserializes from json "aaaAaa"
    bbb_bbb: u8,
}

That is exactly what I'm looking for, thanks! :relaxed:


Add more context to reconcile error debug logs

We were debugging some slow queue processing behaviour, and the fact these logs dont have a trace_id or key to associate them with other logs / the failing item, and to distinguish them from other parallel items, made things harder than they needed to be to follow on a busy system.
Changes

🧹 Make sure the context (key, trace id) is included in the debug logs for the non-happy path in controller.go
🧹 Fix up error message prefix in EnqueueAfter to match the actual method it's in

/kind enhancement

Release Note

Debug logs in controller now properly associate messages with trace id and key

Docs

/assign @markusthoemmes

/retest

Metrics test flake, again. Putting that on my list to look at (again :)).
/retest


Need to be able to merge or delete redundant instructor training requests

We now have duplicate instructor training requests (same name, same email address) - need some way to delete or merge these through the web interface.

This PR #871 introduces discarding training requests through web interface. You can also delete requests permanently in django-admin. Is it enough?

Yup.

Fixed in #871. You can now:

discard training requests through admin interface or
delete them permanently in django-admin.

Thanks.


If the post contains a picture no url for the picture is in the dataset

This post: https://twitter.com/PES_PSE/status/1445755473202843658
This in dataset:
{ "user": {}, "id": "1445755473202843658", "conversation_id": "1445755473202843658", "full_text": "Good luck to @CSSD in this Friday and Saturday election in Czech Republic!\n@jhamacek https://t.co/3aKRQg9wg3", "reply_count": 2, "retweet_count": 4, "favorite_count": 24, "hashtags": [], "symbols": [], "user_mentions": [ { "screen_name": "CSSD", "name": "ČSSD", "id_str": "18318781" }, { "screen_name": "jhamacek", "name": "Jan Hamáček", "id_str": "20664874" } ], "urls": [], "url": "https://twitter.com/PES_PSE/status/1445755473202843658", "created_at": "2021-10-06T14:19:00.000Z" },

this exists in this path
data.threaded_conversation_with_injections.instructions[0].entries[0].content.itemContent.tweet_results.result.legacy.entities.media[0].media_url_https

🤣

Any plans to implement this soon?


strip the read-in version number of extra whitespace

Just in case the VERSION file gets a newline added back in by an enthusiastic text editor.
> IO.read(File.join(File.dirname(__FILE__), 'VERSION'))
=> "1.2.0\n"
> IO.read(File.join(File.dirname(__FILE__), 'VERSION')).chomp
=> "1.2.0"

Thanks for the improvement.


Fix constant to check the required feature set

Thanks for noticing and for taking the time to create a pull request, instead of passing the shifted major version I directly fixed the broken macro. Closing PR with the fix in https://github.com/Sensirion/embedded-sgp/pull/32


skip script if dependecy in not installable

During the installation process ./install.sh i recived this error:
Problem: problem with installed package
  - installed package ffmpeg-7.0.2-4.fc41.x86_64 conflicts with ffmpeg-free provided by ffmpeg-free-7.0.2-7.fc41.x86_64 from fedora
  - package ffmpeg-7.0.2-4.fc41.x86_64 from rpmfusion-free conflicts with ffmpeg-free provided by ffmpeg-free-7.0.2-7.fc41.x86_64 from fedora
  - conflicting requests

I am not sure if uninstall the packages with conficts is a good idea so:
In you opinion is it possible that if there is some issue during the dependencies installation the script will install only the one that the installation part was ended good ?
Thanks

Hi @Belingheri ,
Thank you for identifying this issue! I'll check the currently installed packages on Fedora to better understand the problem. Additionally, I'll implement a logic to handle this kind of conflict in the script soon. Once I finish, I'll update this issue with the details.
Thanks again for reporting this!

Fix merged.


Fix for GoComics changes

GoComics changed comic page structure, so this patch fixes it
Issue #565

Thanks for the fix :+1:


could heatmap support openlayers?

as the title, could heatmap support openlayers?
looking for it!

https://www.patrick-wied.at/static/heatmapjs/plugins.html


[libra-vm] Add simple debugging interface to the VM

This PR adds a basic debugging interface to the VM. It was designed to be minimally invasive, and hook in where we already hook in for coverage gathering. Any transaction can be debugged using this, and it is turned on by setting the MOVE_VM_STEP env variable. In release builds this code is not included.
The debugging interface is interactive and provides a basic set of commands. These are:

stack which prints the current call stack and the contents of the frames on the call stack (see below for an example)
step which performs one step of computation (e.g., advances the PC by 1)
continue which runs the computation either until a breakpoint is hit, or execution terminates
breakpoint <instruction> sets a breakpoint for a prefix of an instruction e.g., Abort, or LdConst. Can also be set on a fully-qualified function name (e.g. 0x00000000000000000000000000000001::LibraAccount::deposit).
delete <instruction> removes the <instruction> breakpoint
breakpoints prints the current set of breakpoints that are set

Example 1
Bob just tried to send Alice some money, but the transaction aborted. Bob wants to inspect the state of the transaction at the point the abort happened. Bob can use the debugger to see this:
$ MOVE_VM_STEP=1 cargo run -- -u http://localhost:55400 replay-transaction-by-sequence-number 0xB0B 0
Connection Succeeded
Starting epoch execution at 941, 1 transactions remaining
function >> 0x00000000000000000000000000000001::LibraAccount::prologue
instruction >> MoveLoc(0)
program counter >> 0
> breakpoint Abort
> continue
Breakpoint Abort hit with instruction Abort
function >> 0x00000000000000000000000000000001::LibraAccount::deposit
instruction >> Abort
program counter >> 16
> stack
Call Stack:
    [0] main<00000000::LBR::LBR>

        Code:
            [6] MoveLoc(3)
            [7] MoveLoc(4)
            [8] CallGeneric(0)
          > [9] MoveLoc(5)
            [10] Call(2)
            [11] Ret

        Locals:
            [0] -
            [1] 1cbbf5bf2bf60e0e12896e87030fa9cd
            [2] 0
            [3] -
            [4] -
            [5] { 6a8b8c5a7e7b5a1284b2b129b05a9c2c }

    [1]<PHONE_NUMBER>0000000000000000000001::LibraAccount::pay_from<00000000::LBR::LBR>

        Code:
            [9] MoveLoc(3)
            [10] MoveLoc(4)
            [11] CallGeneric(9)
          > [12] Ret

        Locals:
            [0] -
            [1] 1cbbf5bf2bf60e0e12896e87030fa9cd
            [2] 0
            [3] -
            [4] -

Operand Stack:
    [0] 519

Current frame: 0x00000000000000000000000000000001::LibraAccount::deposit

        Code:
            [0] Call(11)
            [1] CopyLoc(1)
            [2] Call(26)
            [3] ImmBorrowLoc(2)
            [4] CallGeneric(7)
            [5] StLoc(5)
            [6] CopyLoc(5)
            [7] LdU64(0)
            [8] Gt
            [9] LdConst(4)
            [10] Call(3)
            [11] StLoc(7)
            [12] StLoc(6)
            [13] MoveLoc(6)
            [14] BrTrue(17)
            [15] MoveLoc(7)
          > [16] Abort
            [17] CopyLoc(1)
            [18] Call(86)
            [19] LdConst(11)
            [20] Call(6)
            [21] StLoc(9)
            [22] StLoc(8)
            [23] MoveLoc(8)
            [24] BrTrue(27)
            [25] MoveLoc(9)
            [26] Abort
            [27] CopyLoc(1)
            [28] ExistsGeneric(StructDefInstantiationIndex(0))
            [29] LdConst(10)
            [30] Call(3)
            [31] StLoc(11)
            [32] StLoc(10)
            [33] MoveLoc(10)
            [34] BrTrue(37)
            [35] MoveLoc(11)
            [36] Abort
            [37] CopyLoc(0)
            [38] CopyLoc(1)
            [39] CopyLoc(5)
            [40] CopyLoc(3)
            [41] MoveLoc(4)
            [42] CallGeneric(14)
            [43] CopyLoc(0)
            [44] CopyLoc(1)
            [45] LdFalse
            [46] CallGeneric(15)
            [47] BrTrue(49)
            [48] Branch(64)
            [49] CopyLoc(5)
            [50] CopyLoc(1)
            [51] Call(47)
            [52] Call(7)
            [53] ImmBorrowGlobal(StructDefinitionIndex(0))
            [54] ImmBorrowField(FieldHandleIndex(5))
            [55] CallGeneric(16)
            [56] LdConst(5)
            [57] Call(5)
            [58] StLoc(13)
            [59] StLoc(12)
            [60] MoveLoc(12)
            [61] BrTrue(64)
            [62] MoveLoc(13)
            [63] Abort
            [64] CopyLoc(1)
            [65] MutBorrowGlobalGeneric(StructDefInstantiationIndex(0))
            [66] MutBorrowFieldGeneric(FieldInstantiationIndex(0))
            [67] MoveLoc(2)
            [68] CallGeneric(17)
            [69] CopyLoc(1)
            [70] MutBorrowGlobal(StructDefinitionIndex(3))
            [71] MutBorrowField(FieldHandleIndex(6))
            [72] CopyLoc(5)
            [73] CallGeneric(18)
            [74] CopyLoc(0)
            [75] MoveLoc(3)
            [76] Pack(4)
            [77] CallGeneric(19)
            [78] Ret
        Locals:
            [0] 6a8b8c5a7e7b5a1284b2b129b05a9c2c
            [1] 1cbbf5bf2bf60e0e12896e87030fa9cd
            [2] { 0 }
            [3] []
            [4] []
            [5] 0
            [6] -
            [7] -
            [8] -
            [9] -
            [10] -
            [11] -
            [12] -
            [13] -

>

Example 2
Lets say you want to inspect the state of things right before this abort is hit in the following script, and then take a look at what happens after it:
script {
fun main() {
    let x = 1;
    let y = 2:
    let _ = x + y;
    abort 10;
}
}

$ ct dummy.move
function >> 0x00000000000000000000000000000001::Genesis::initialize
instruction >> LdConst(0)
program counter >> 0
> breakpoint Abort
> continue
Breakpoint Abort hit with instruction Abort
function >> Script::main
instruction >> Abort
program counter >> 3
> stack
Call Stack:
Operand Stack:
    [0] 10

Current frame: Script::main

        Code:
            [0] LdU64(3)
            [1] Pop
            [2] LdU64(10)
          > [3] Abort
        Locals:
            [0] -
            [1] -

> breakpoints
[0] Abort
> step
function >> 0x00000000000000000000000000000001::LibraAccount::prologue
instruction >> MoveLoc(0)
program counter >> 0
> stack
Call Stack:
Operand Stack:

Current frame: 0x00000000000000000000000000000001::LibraAccount::prologue

        Code:
          > [0] MoveLoc(0)
            [1] Call(0)
            [2] StLoc(26)
            [3] Call(25)
.......
> delete Abort
> breakpoint Call
> continue
Breakpoint Call hit with instruction Call(0)
function >> 0x00000000000000000000000000000001::LibraAccount::prologue
instruction >> Call(0)
program counter >> 1
> stack
Call Stack:
Operand Stack:
    [0] (&) { a4a46d1b1421502568a4a6ac326d7250 }

Current frame: 0x00000000000000000000000000000001::LibraAccount::prologue

        Code:
            [0] MoveLoc(0)
          > [1] Call(0)
            [2] StLoc(26)

Do we need to have debug_assertions feature to be on for libra-transaction-replay?

Also what's the difference between MOVE_VM_STEP  and MOVE_VM_TRACE ?

Also what's the difference between MOVE_VM_STEP and MOVE_VM_TRACE ?

Good question!

MOVE_VM_TRACE gathers traces through the VM without halting execution, and is used to gather coverage information for Move.
MOVE_VM_STEP halts execution and drops you in to this debug interface to inspect the stack etc. It does not gather execution traces/coverage-related information.

It sounds like this is good to land, so I'll do that now.
I think moving both tracing and debug out in to their own crate would be nice, but I think there's some work there to avoid circular includes.
If we want to circle back on the feature flags, and/or move tracing and debug to a separate module happy to do that as well in a followup PR :)
/land


Linkedin embed doesn't display

Hi, thanks a lot for ur solution.
I'm trying to show linkedin's embed but I can't do it, even the example doesn't display something. Is there any issue now about it?

Did you try it in different browsers? Do you get an error in the log?
I have the problem with the visibility of images in firefox because it blocks an script inside the iframe. This script is reponsible to lazy load the images. Without the script the data-delayed-url can not be transformed to the src attribut.


feat(app): create error toast when TLC or POC fails

closes #9000
Overview
This PR adds a failed toast if pipette offset calibration or tip length calibration fail:

Changelog

created a CalibrationFailedToast component and test
added onto ProtocolSetup

Review requests

I grabbed the failed calibration reasoning from useProtocolCalibrationStatus() not sure if that is correct (the above image has a stubbed in error_reason since ProtocolCalibrationStatus.reason is
 | 'calibrate_deck_failure_reason'   | 'calibrate_tiprack_failure_reason'   | 'calibrate_pipette_failure_reason'   | 'attach_pipette_failure_reason')
make sure it matches figma
test on a robot

Risk assessment
low, behind ff

@emilywools, a few questions for you!

is it ok if the banner is above the metadata card? or do we want it to be over the metadata card like it shows on figma?
do we want the user to be able to dismiss the banner?

can the banner sit at the top of the user's viewport, above the main content of the app? cc @shlokamin because i asked him this very question today
yes, i think it makes sense to add a close button. Sorry that I missed that! Figma is updated now

Closing this for now. We do not have a global way to handle calibration failures, so they'll need to be tackled individually inside of CalibrateTipLengthControl (for TLC) and useCalibratePipetteOffset (for POC). Since so much of this is going to be changed as part of the next gen app work, let's table this and tackle it after the PUR release.


Review/participants: transform all emails to lowercase.

I pushed a bit the heroku version to to provoque bugs.
For Participants, access to Review, Teacher mailing, and everywhere emails are handled.
Cf below : right email with capitals "G" failed. Some user capitalized their emails.

var str1 =<EMAIL_ADDRESS>var str2 =<EMAIL_ADDRESS>alert(str1==str2);  // false

var str2 = str2.toLowerCase();
alert(str1==str2);   // true

https://jsfiddle.net/y21df76q/2/

@mystermiam : is it done ?

@mystermiam : done, pushed, but to test. Side effects may appear when csv with capitals are submitted. I'am testing.


LitElement - Typescript - Redux

I have started a version of the app in LitElement.
It is using LitElement, Redux and Typescript.
https://github.com/Erikvdv/litelement-realworld

Looking forward to getting this in... do you need help?

I am planning to finish the functionality part in the coming two weeks. That should be good enough for putting it on the realword.io repo. I want to finish it asap as I would like to experiment with rxjs based redux and fetch asap.To speed the remainder up, some support with setting up unit and e2e test could be helpful.

I'm honestly not to familiar with the testing side of litElement... I guess its like the good old polymer webcomponents testing... I don't think I can be of much help with that :-/
Looking forward to seeing the results though...

There are lot more options for testing with Polymer 3 and LitElement because they don't use HTML imports. I'd probably go with the open-wc.org testing reccomendations for now.

I was thinking of using Jest for the unit tests and cypress for the e2e tests. With respect to the e2e tests I am curious to see if that approach will work given the encapsulation of the web components. The semantic-dom-diff library looks interesting as well, will give it a try when I have time.

Jest has terrible web components support, and possibly bad modules support. I really would follow the open-wc.org reccomendations.

Ok, will follow your advice and start with the open-wc setup. Seems quite straight forward in terms of setup anyway.

Hello we are currently moving all work in progress to Github Discussions.
I'll close this issue by now, you can find instruction to open a discussion there : https://github.com/gothinkster/realworld/discussions/633
Thanks for your contribution !


Gif hosting

I had to host the demonstration GIF somewhere, so where better than the repository itself!

Okay I found a way to make it bigger, so maybe it'll look better now:


Model's dimmer can't hide auto when there is a page dimmer.

Like #766.
There is a page dimmer in my page like the one on the docs  http://semantic-ui.com/modules/dimmer.html .
Then, when I open a modal, It worked.
Then when I click on the modal body, some thing happend.I can't describe it.
Util this, Everything looks normal. When I click the dimmer of modal, the model's body is disappeared, But the dimmer still display!!
I don't understand why this happend.
My English is weak to describe this problem,so , there is code:

Loading...

... the form

$('#settingpanel').modal('show');

News.
Only when the page dimmer directly under the body tag, this bug can be reproduced. If I move the page dimmer into a other div, all works normaly.

Can you reproduce it in a jsfiddle?  Thanks.

It’s been a while, we can probably close the issue until there’s a test case.

This still exists. See this fiddle: https://jsfiddle.net/ca0rovs3/1286/
It's a weird one to trigger. In my implementation it just triggers anyway, but in the fiddle you need to click the space below the buttons on the modal. You'll see something funny happening in the background and then when you close the modal, one of the dimmers still exists.
The workaround is to put your custom dimmer into a div off of the body element.


Document the classlist shim for IE compatibility

See angular/angular#6327
Internet Explorer doesn't support the classlist property on SVG elements. So things like NgSwitch don't work without a shim.
"dependencies": {
  "classlist.js": "1.1.20150312"
}

provides a working solution

Now we have a "browser support" guide that cover this.

Here's the link:
https://angular.io/docs/ts/latest/guide/browser-support.html


NJ review comments on L3 interconnect doc

The overlong hyphens should render as en-dashes, which are, I believe, grammatically correct.  However, its no big deal.  Merged.

Thanks for the merge.  On the dash/hyphen point I'm not sure you're right; I'm pretty sure most dashes in words are hyphens and not en-dashes.  E.g. see http://english.stackexchange.com/questions/2116/when-should-i-use-an-em-dash-an-en-dash-and-a-hyphen.
Also, as a practical matter, it would be just weird if RST (or equally TeX) forced us to write the most common dash usage in a less intuitive way.  In my TeX past I've always used - in words, -- for ranges (en dash) and --- for punctuation (em dash).


SA password change when lost the password

In this scenario, you have lost/forgotten your password for the SA account and have to set a new one. When using a dev container, that lies around, this can happen.

@amitkh-msft - can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thanks for the contribution. We will look into this.


Object size calculation is wrong

https://github.com/peng225/oval/blob/eeb7ab060fe8c4f011d283eea48dd3576b4b25f9/pattern/pattern.go#L37
The last "+1" should be removed.

This is not a bug because rand.Intn(n) returns a value in range [0, n).


support missing parameters as None

a field
foo: Option[Foo]

can be missing in the JSON or even null. But it looks like this decoder just fails.

Sorry I wasn't subscribed to notifications and just now saw this issue. I'll take a look at it.

awesome

Thanks!

Sorry it took so long. Jon Pretty (maintainer of Magnolia) is quite busy at the moment, so we decided to use our own published version of magnolia. The changes are minimal (see magnolia/#85), and we'll update the dependency to Magnolia proper as soon as possible.

(Also, I committed the unspeakable act of rebasing and force-pushing to master to fix a MiMa incompatibility issue in the latest commit. Sorry for the inconvenience, I didn't think you'd be working with this project at this time of day.)

My son was crying and woke me up. Now he's sleeping and I'm reading tickets on GitHub on my phone :-)
Jon doesn't believe in publishing anymore. He wrote a build tool that won't even let you do it because he hates it so much.

That's definitely a good way to to pass time!
I heard rumors about this build tool, would love to check it out. With cbt and mill, it seems they're the hot topic of 2018 in the Scala community! We're hosting a meetup about Scala build tools next week, it's gonna be quite interesting.


molecule 3.2.x will not execute

But when using molecule 3.2.x
Works fine with < 3.1.5
[I] 10:17:18 ➜  molecule molecule --version
Traceback (most recent call last):
  File "/usr/local/bin/molecule", line 6, in <module>
    from molecule.__main__ import main
  File "/usr/local/lib/python3.7/dist-packages/molecule/__main__.py", line 22, in <module>
    from molecule.shell import main
  File "/usr/local/lib/python3.7/dist-packages/molecule/shell.py", line 29, in <module>
    from molecule import command
  File "/usr/local/lib/python3.7/dist-packages/molecule/command/__init__.py", line 27, in <module>
    from molecule.command import base  # noqa
  File "/usr/local/lib/python3.7/dist-packages/molecule/command/base.py", line 32, in <module>
    import molecule.scenarios
  File "/usr/local/lib/python3.7/dist-packages/molecule/scenarios.py", line 23, in <module>
    from molecule import logger, util
  File "/usr/local/lib/python3.7/dist-packages/molecule/logger.py", line 29, in <module>
    from enrich.console import Console
  File "/usr/local/lib/python3.7/dist-packages/enrich/console.py", line 8, in <module>
    from rich.ansi import AnsiDecoder
ModuleNotFoundError: No module named 'rich.ansi'

Do you have rich installed? How did you install molecule?

hm. weird. the dependency tree is molecule -> enrich -> rich. molecule and enrich are installed, so rich should be installed too. What might be the problem would be rich being too old (so without rich.ansi) but enrich is depending correctly on rich >= 9.2.0 to avoid that...


Enter to edit: possible?

Hello
How to edit cells with enter key like in excel? this is better than double click or F2 button;
is there a feature must enabled to change this?

Any idea?
Is this an option can activated or it need to created manually?

I think you have to do the logic by programming.

Add an event for KeyDown.
Start cell edit by call StartEdit method

Hi
I don't find KeyDown? just CellMouseDown

Find it thank you:
AfterCellKeyDown

Hi jingwood
I use sheet.AfterCellKeyDown += self.enterEdit
and event: sheet.StartEdit(e.CellPosition)
The problem when i press the key the next cell don't enter in edit mode until i press the key again,
As you see in the video, the cell enter in the edit mode one by one
https://user-images.githubusercontent.com/6026588/157640970-7f739f60-3b0f-4e08-8b5a-3deb10caba57.mp4

Did you tried the BeforeCellKeyDown event. You can set the e.IsCancelled = true to cancel the original action from ReoGrid when enter key is pressed.

I try it but it stack on the first cell and i can't move to other cells with key or enter

Hi jingwood
In editor we can directly edit cell when press any key like in excel
I can't do that with windows form, i need always to click twice with mouse or use F2, can you please show me where is the code about this?
I see othe examples where this feature available , i don't know if that included in the dll or not

Thank you jingwood I will try, my work is all with ironpython which is difficult to find informations and i need try to understand the available tips

sorry to ask, is there any code for ironpython example to show how to use ReoGrid?
In fact, if possible, I will try to use ReoGrid with https://github.com/khchen/winim


[Feature]: Add template support in Chip card for icon and icon_color

Is your feature request related to a problem?
I tend to use colors according to sensor state ranges, i.e: battery, over 50% is green, 20% to 50% is orange and below 20% is red. In this case, you can also set different icons for each range.
It works great with the template card, like in this example for air quality:

but I can't follow the same logic when using the chips card:

Would be great to be able to use templates in the icon and icon_color fields.
Describe the solution you'd like
Use templates in the icon and icon_color fields of the chips card.
Describe alternatives you've considered
I've tried to use stacked template cards and play with custom styles to simulate the chips card and be able to use templates. It doesn't look the same and it feels more as a hack rather than customization.
Additional context
No response

Just notice this is already supported in template chip card. It's really about text/background. Will open a different issue.


Add new Re-submit button for Python code generated

After the Python code is generated. I want to change directly code generated and re-run it to see how it work instead of rewrite query

That could be interesting. This would involve modified the Gradio code in the command_center. I will set it as help-wanted because we all have quite a few tasks  on our plates internally for now but maybe someone will take this from the community! Or if you want to give it a go, that would be great!

We are also working on a VS code extension which will make this possible soon.

I would like to work on this issue.

Sounds great @shivamsharma00. I'll set the issue to community assigned. Let me know if you need any more info about this one

This is now handled by an automatic retry mechanism if steps fail


What about Laravel 5.3 ?

Hi ..., Recently Laravel 5.3 came out. Is there any problem If I use the version for Laravel 5.2 ?

Please use the search feature to find open issues #925

As a workaround to use mongodb in laravel 5.3 you can use this
Model
use Jenssegers\Mongodb\Eloquent\Model as Moloquent;

class AdminUser extends Moloquent
{
    protected $connection="mongodb";
    protected $collection="admin_important_users";
}

Controller
class AdminUserController extends Controller
{
    public $model;

    public function __construct(AdminUser $user) {
        $this->model = $user;
    }

$col = $this->model->getConnection()->table('admin_important_users');
$col->get();

That's how you get collection object. I'll try some fixes but for now this works.

#925 solves this , no need , just needs merged.

Thanks @lukepolo & @gp187 ..., What is the problem exactly ?

Ok @lukepolo . Let's see it done.
Merge please @jenssegers


[documentation] More information for provider implementations

I found it pretty difficult to implement a new provider. Here's a placeholder of some things I want to document for the project:

Recommended methods implementations for a subclass of ARAnalyticsProvider
What provider methods ARAnalytics calls, and under what conditions. (i.e. only through breakpoints and digging did I realize how screen views map into the generic event callsite)

This could be done by fleshing out:  https://github.com/orta/ARAnalytics/blob/master/CONTRIBUTING.md#how-can-i-add-another-analytics-provider


Quick Action Menus: Collapse tabs on click

When quick actions are interacted with and the user is taken to a panel, if there are other panels in that section they should collapse so that just the one that was highlighted is expanded.
This just fell through the cracks, it's a note in figma.
Acceptance criteria

the above interaction
a few tests to validate

This actually got cut from the feature and the ticket was just not updated.


issue with 0.9.6 and combat

There appears to be a problem with UniversalRemote-1.12.2-0.9.6.jar and combat.  When attempting to kill any mob I get an server error:
Ticking entityjava.lang.NullPointerException: Ticking entity
at net.minecraft.entity.player.EntityPlayerMP.func_152111_bt(EntityPlayerMP.java:295)
at net.minecraft.util.CombatTracker.func_94547_a(SourceFile:65)
at net.minecraft.entity.player.EntityPlayer.func_70665_d(EntityPlayer.java:1132)
etc.
and Minecraft aborts.  When I disable UniversalRemote Minecraft works fine again.  I thought it might be a compability issue with ClassicCombat but I disabled that mod and tried fighting.  Unfortunately the error still occurs...so it appears to be an explicit problem just with UniversalRemote and general MC combat.  Hope this is helpful and that this can be easily fixed.

I will look into this. There was a behind the scenes change in 0.9.6 for players which caused a few issues. Look for a fix release soon.

Fixed in 0.9.7.


Modify the autoSize warning-throwing function.

Context
The current displayAutoSizeWarning method uses the columns option, but doesn't work properly when it's defined as a function.
This PR changes the approach for checking whether any component-based renderers were declared.
How has this been tested?
Added test cases.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature or improvement (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issue(s):

#141

autoRowSize={true}

@wojciechczerniak Do you mean autoRowSize={false}? Both auto-size options are incompatible with the component-based renderers.


DS4Windows stopped working and unable to launch

DS4W has just stopped working around 5 days ago. It won't launch and the "DS4W has stopped working" box pops up when I try to launch it. I have tried updating, deleting and reinstalling and even turning my computer off and on. Not even older versions are working. It used to be fine for several months, I used it with a general bluetooth adapter when it was working, and sometimes connected directly via a Sony Xperia Z2 USB cable. Please help.

So I did one more thing. I went to my user and then went to appdata, and I deleted my previous profiles and tried launching DS4W, and to my surprise it did.


Fetch pool image from GitHub Container Registry

Signed-off-by: Miroslav Kovar<EMAIL_ADDRESS>

Codecov Report

Merging #217 (2366fbf) into master (a2e491f) will increase coverage by 7.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   53.50%   60.94%   +7.43%
==========================================
  Files         146      147       +1
  Lines       18396    19583    +1187
  Branches     4149     4316     +167
==========================================
+ Hits         9842    11934    +2092
+ Misses       5464     4200    -1264
- Partials     3090     3449     +359

Flag
Coverage Δ

integration
35.58% <ø> (?)

unittests
53.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

agency_client/src/lib.rs
57.14% <0.00%> (-4.40%)
:arrow_down:

agency_client/src/payload.rs
0.00% <0.00%> (ø)

libvcx/src/utils/object_cache/mod.rs
66.31% <0.00%> (ø)

libvcx/src/aries/messages/discovery/query.rs
88.88% <0.00%> (ø)

libvcx/src/aries/messages/trust_ping/ping.rs
74.28% <0.00%> (ø)

libvcx/src/aries/messages/discovery/disclose.rs
82.05% <0.00%> (ø)

libvcx/src/aries/messages/basic_message/message.rs
67.74% <0.00%> (ø)

agency_client/src/get_message.rs
85.71% <0.00%> (ø)

...aries/handlers/connection/invitee/state_machine.rs
71.78% <0.00%> (+0.27%)
:arrow_up:

libvcx/src/aries/handlers/connection/mod.rs
68.00% <0.00%> (+0.35%)
:arrow_up:

... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2e491f...2366fbf. Read the comment docs.


docs: Reorganize governance content.

A humble proposal for a small content restructure 🙂 This is mostly just moving files around and fixing some spelling mistakes. Largest content changes are in the main README to better surface strategic initiatives.

Move most governance documentation to
Major files like CoC, Charter, License and main README remain top level.
Re-organize strategic initiatives to reflect current state.
Move all strategic initiatives into main readme.

@amiller-gh can I fix some more typos in /governance/ in this PR?

@WaleedAshraf please go ahead! Would love that.

More tpyos fixed. PTAL


Optimize Target,  Alert and Service Discovery pages

This PR is following the enhancements of the Alert, Target and Service discovery pages from Prometheus.

https://github.com/prometheus/prometheus/pull/10103
https://github.com/prometheus/prometheus/pull/10131
https://github.com/prometheus/prometheus/pull/10142

It also align the Target Page regarding the way to manage the filter. It was easier like that to apply the changes.

[x] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

@onprem I supposed this one is for you.
I still have a test that failed, but I'm not really sure why it is failing. The number of ScrapePoolPanel should remain the same :/

It seems like the CI is failing at the linting stage:
/home/runner/work/thanos/thanos/pkg/ui/react-app/src/pages/targets/Filter.test.tsx
Error:    23:7   error  Delete `··`                                    prettier/prettier
Error:    92:11  error  Delete `··`                                    prettier/prettier
Error:   102:4   error  Newline required at end of file but not found  eol-last
Error:   102:4   error  Insert `⏎`                                     prettier/prettier

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

I think the linter is only suggesting cosmetic changes? :thinking:

--fix suggests:
diff --git a/pkg/ui/react-app/src/pages/targets/Filter.test.tsx b/pkg/ui/react-app/src/pages/targets/Filter.test.tsx
index d3c20f6c..620866f7 100644
--- a/pkg/ui/react-app/src/pages/targets/Filter.test.tsx
+++ b/pkg/ui/react-app/src/pages/targets/Filter.test.tsx
@@ -20,7 +20,7 @@ describe('Filter', () => {
     setFilter = sinon.spy();
     setExpaned = sinon.spy();
     filterWrapper = shallow(
-        <Filter filter={initialState} setFilter={setFilter} expanded={initialExpanded} setExpanded={setExpaned} />
+      <Filter filter={initialState} setFilter={setFilter} expanded={initialExpanded} setExpanded={setExpaned} />
     );
   });

@@ -89,7 +89,7 @@ describe('Filter', () => {
         const filterCallback = sinon.spy();
         const expandedCallback = sinon.spy();
         const filterW = shallow(
-            <Filter filter={filter} setFilter={filterCallback} expanded={initial} setExpanded={expandedCallback} />
+          <Filter filter={filter} setFilter={filterCallback} expanded={initial} setExpanded={expandedCallback} />
         );
         const btn = filterW.find(Button).filterWhere((btn): boolean => btn.hasClass('expansion'));
         expect(btn.children().text()).toEqual(text);
@@ -99,4 +99,4 @@ describe('Filter', () => {
       });
     });
   });
-});
\ No newline at end of file
+});
diff --git a/pkg/ui/react-app/src/thanos/pages/blocks/Blocks.tsx b/pkg/ui/react-app/src/thanos/pages/blocks/Blocks.tsx
index c488e6b5..1b7512c4 100644
--- a/pkg/ui/react-app/src/thanos/pages/blocks/Blocks.tsx
+++ b/pkg/ui/react-app/src/thanos/pages/blocks/Blocks.tsx
@@ -89,7 +89,7 @@ export const BlocksContent: FC<{ data: BlockListProps }> = ({ data }) => {
   const onChangeCompactionCheckbox = (target: EventTarget & HTMLInputElement) => {
     setFilterCompaction(target.checked);
     if (target.checked) {
-      let compactionLevel: number = parseInt(compactionLevelInput);
+      const compactionLevel: number = parseInt(compactionLevelInput);
       setQuery({
         'filter-compaction': target.checked,
         'compaction-level': compactionLevel,

@Nexucis looks good? :thinking:

aah I didn't see the linter issue. Thanks @GiedriusS for the highlight :).
For the test issue, I still don't have a clue on how it's failing sorry :(.

Lol turns out I forgot a modification in the target page. So it was good the test failed \o/.
It's good now @GiedriusS.
Let me know if you guys prefer I'm cutting this PR into multiple one. I did it like that because the changes are more or less a report / sync from what we did in Prometheus.

I don't think thats necessary. I've checked the PR's from Prometheus and it seems like it had a solid review there :D Did you test these changes for Thanos itself (i.e. perhaps we have something specific)?
My only nit would be the changelog, the sentence is a bit odd, (maybe it had to be "add a searchbar?") -

Don't forget make assets (:

Ah yeah thanks for the remember, I totally forgot thanks :).

I don't think thats necessary. I've checked the PR's from Prometheus and it seems like it had a solid review there :D

Cool thanks !

Did you test these changes for Thanos itself (i.e. perhaps we have something specific)?

I tested in Thanos yes, but not super heavily (just to be sure I didn't forgot something).

My only nit would be the changelog, the sentence is a bit odd, (maybe it had to be "add a searchbar?") -

Ah yup I forgot a word there. Sorry about that and thanks for your eyes :) !

The search button isn't clickable, though :/ or is it just me?

:o that's weird, on which page @GiedriusS ?

/alerts. If I enter anything this is what I get:
AlertContents.tsx:81 Uncaught TypeError: Cannot read properties of null (reading 'value')
    at handleSearchChange (AlertContents.tsx:81)
    at SearchBar.tsx:17

The backtrace:
  14 | const handleSearchChange = (e: ChangeEvent<HTMLTextAreaElement | HTMLInputElement>) => {
  15 |   clearTimeout(filterTimeout);
  16 |   filterTimeout = setTimeout(() => {
> 17 |     handleChange(e);
     | ^  18 |   }, 300);
  19 | };
  20 |

  78 | };
  79 |
  80 | const handleSearchChange = (e: ChangeEvent<HTMLTextAreaElement | HTMLInputElement>) => {
> 81 |   if (e.target.value !== '') {
     | ^  82 |     const pattern = e.target.value.trim();
  83 |     const result: RuleGroup[] = [];
  84 |     for (const group of groups) {

aaah thanos is still in React 16, which is not the case for Prometheus.
Thank you so much for the investigation @GiedriusS !
Unfortunately upgrading to React 17 is something that cannot be done in this PR, it is a bigger PR.
I'm wondering if we should first upgrade to React 17 and put on hold this one, or do what you suggested and then make the upgrade to React 17. WDYT ?

Maybe let's add e.persist() and then upgrade React in a separate PR?

alright, it should work better like that now @GiedriusS. Thanks again for the help !

And you forgot one persist call in another handleSearchChange

I think you forgot make assets 😄

Ah yeah indeed :(. It would be cool, if this thing would be generated in the CI instead like it is the case in Prometheus.


MWPW-136532 Quote block flexible authoring

Allow for more flexible authoring for primary text in quote block
Can be: paragraph, single line of text, bold, italic, heading, or blockquote

Resolves: MWPW-136532
Test URLs:

Before: https://main--milo--adobecom.hlx.page/drafts/methomas/quote
After: https://methomas-quote--milo--adobecom.hlx.page/drafts/methomas/quote?martech=off

Regression: https://methomas-quote--milo--adobecom.hlx.page/docs/library/blocks/quote?martech=off

This looks good. I see one style thing if you don't mind adding a quick update.
When using a blockquote w/ out a figcaption the inside bottom margin looks too large. I was thinking just move that bottom-margin value out of the blockquote element and add a top-margin to the .figcaption. That way it won't impact if it doesn't exist.

Good catch! Updated


Final Division too far apart in zoom mode

When placing divisions that are final, they are really far apart.

Fixed in 7bf19a2 as well 🔨


Augment default metrics

We'd like to see the ability to add custom labels to default metrics. For example, adding
labels['platform'] = env['HTTP_X_PLATFORM'] to http_requests_total.
Also added 'queue' as a label for default sidekiq metrics in order to view metrics on sidekiq jobs at the 'queue' level.

This is conflicting now, can you have a look?

Resolved merge conflicts!

cool let's try this out... also our CI is playing up, got to get that sorted.


Markdown render issue: text wrapping and line breaks

Documented in:

Minecraft 1.12.1
Forge <IP_ADDRESS>4
Correlated 2.0

Issue:
When Markdown text-wrapping is used, the Markdown renderer fails to add a space properly; even if there is a space in the Markdown document.
Image example:

(can be seen at "pearlsnear", "theycan", and "NOTUNDER"; there are line breaks at those points in the Markdown that have spaces at the beginning of each line, but the space isn't rendered)

Another note, Codeblocks don't render at all:

It might be helpful to have them another color to notate the names of blocks or items, maybe?

Maybe reverse video?


show values of constants in hover

Fix #8497
cc #8655

r? @flodiebold

bors r+

Needs a rebase, but it's pretty mechanical.

Rebased.

bors r+


Incorrect Link to CURSORINFO from GetCursorInfo

Link to article:
https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getcursorinfo
Problem:
The link to CURSORINFO directs to https://docs.microsoft.com/windows/desktop/menurc/o instead of https://docs.microsoft.com/en-us/windows/win32/api/winuser/ns-winuser-cursorinfo

@GrantMeStrength Can you please take a look at this issue?

Thanks for reporting. Correction submitted.


Add version command to show version info

Now it can show the Cargo pkg version and the last commit id with date and branch. #75

Thanks for guiding! I have tried to improve them!


[Fixes #43] Rename ErrorHandler and its associated types/extensions

@Eilon @rynowak

:watch:

@kichalla whats the deal with this PR

@davidfowl this PR is about renaming the extension methods UseErrorHandler to UseExceptionHandler and UseErrorPage to UseDeveloperExceptionPage.

UseDeveloperExceptionPage lol :smile:

@davidfowl what's wrong with the name? It's accurate and relevant. And scares people away from using it in non-developer scenarios, which was a key motivator for this rename.
:shipit: from me.

c46615dc534b55916e3c63bc9b0db89699b7c921


Update requirements for symfony and phpunit

Hi @DariusIII, thanks for your PR currently php-mediainfo is not fully compatible with symfony> = 5 as is (eg: see [this comment] (https://github.com/mhor/php-mediainfo/pull/83# discussion_r167436812)).
So if you want make it compatible with symfony> = 5 you should:

make a compatibility layer for currently supported symfony versions
use phpunit_bridge to fix compatibility problem between php and phpunit versions (see: https://symfony.com/doc/current/components/phpunit_bridge.html#testing-with-multiple-phpunit-versions)

I'm currently working on php-mediainfo 6.0.0 wich is compatible only with php> = 7.2 & symfony> = 3.4 (https://github.com/mhor/php-mediainfo/blob/6.0.x/composer.json # L19-L21) but no release date is planned


sample.py: Error while deserializing header: HeaderTooLarge

Hi Kat et al!  Thanks for making this great repo available.  I've trained a few models so far and it's working great.  But now I've tried to sample from a checkpoint and I'm getting an unexpected error.
I trained the MNIST demo using
/runs/shawley/k-diffusion/mnist/mnist_trans$  ~/diffusion/k-diffusion/train.py --config ~/diffusion/k-diffusion/configs/config_mnist_transformer.json

Which over time wrote a bunch of checkpoint files...
/runs/shawley/k-diffusion/mnist/mnist_trans$ ls *.pth
model_00010000.pth  model_00040000.pth  model_00070000.pth  model_00100000.pth
model_00020000.pth  model_00050000.pth  model_00080000.pth  model_00110000.pth
model_00030000.pth  model_00060000.pth  model_00090000.pth  model_00120000.pth

When I try to run sample.py using the last checkpoint, I get this...
/runs/shawley/k-diffusion/mnist/mnist_trans$ ~/diffusion/k-diffusion/sample.py --batch-size 10 --checkpoint model_00120000.pth --config ~/diffusion/k-diffusion/configs/config_mnist_transformer.json -n 10 --prefix newsample_

Using device: cuda
Traceback (most recent call last):
  File "/home/shawley/diffusion/k-diffusion/sample.py", line 75, in <module>
    main()
  File "/home/shawley/diffusion/k-diffusion/sample.py", line 44, in main
    inner_model.load_state_dict(safetorch.load_file(args.checkpoint))
  File "/home/shawley/envs/hs/lib/python3.10/site-packages/safetensors/torch.py", line 308, in load_file
    with safe_open(filename, framework="pt", device=device) as f:
safetensors_rust.SafetensorError: Error while deserializing header: HeaderTooLarge

Is it absolutely necessary to create a "slim checkpoint" before sampling?   I have not done that (yet).

Ok, if I run convert_for_inference.py first, then that works but then sample generates a different error:
/runs/shawley/k-diffusion/mnist/mnist_trans$ ~/diffusion/k-diffusion/convert_for_inference.py model_00120000.pth  --config ~/diffusion/k-diffusion/configs/config_mnist_transformer.json --output 120000_slim.pth
Loading training checkpoint model_00120000.pth...
Saving inference checkpoint to 120000_slim.pth...

/runs/shawley/k-diffusion/mnist/mnist_trans$ ~/diffusion/k-diffusion/sample.py --batch-size 10 --checkpoint 120000_slim.pth --config ~/diffusion/k-diffusion/configs/config_mnist_transformer.json -n 10 --prefix newsample_
Using device: cuda
Parameters: 9187360
Sampling...
  0%|                                                                                | 0/50 [00:00<?, ?it/s]
  0%|                                                                                | 0/1 [00:00<?, ?it/s]
Traceback (most recent call last):
  File "/home/shawley/diffusion/k-diffusion/sample.py", line 75, in <module>
    main()
  File "/home/shawley/diffusion/k-diffusion/sample.py", line 69, in main
    run()
  File "/home/shawley/envs/hs/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/usr/lib/python3.10/contextlib.py", line 79, in inner
    return func(*args, **kwds)
  File "/home/shawley/diffusion/k-diffusion/sample.py", line 62, in run
    x_0 = K.evaluation.compute_features(accelerator, sample_fn, lambda x: x, args.n, args.batch_size)
  File "/home/shawley/github/k-diffusion/k_diffusion/evaluation.py", line 86, in compute_features
    samples = sample_fn(cur_batch_size)[:cur_batch_size]
  File "/home/shawley/diffusion/k-diffusion/sample.py", line 60, in sample_fn
    x_0 = K.sampling.sample_lms(model, x, sigmas, disable=not accelerator.is_local_main_process)
  File "/home/shawley/envs/hs/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/home/shawley/github/k-diffusion/k_diffusion/sampling.py", line 267, in sample_lms
    denoised = model(x, sigmas[i] * s_in, **extra_args)
  File "/home/shawley/envs/hs/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/shawley/envs/hs/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/shawley/github/k-diffusion/k_diffusion/layers.py", line 90, in forward
    return self.inner_model(input * c_in, sigma, **kwargs) * c_out + input * c_skip
  File "/home/shawley/envs/hs/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/shawley/envs/hs/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/shawley/github/k-diffusion/k_diffusion/models/image_transformer_v2.py", line 711, in forward
    raise ValueError("class_cond must be specified if num_classes > 0")
ValueError: class_cond must be specified if num_classes > 0

Where does the class_cond go?     (I don't see it in sample.py, and the config file already has "cond_dropout_rate": 0.1.)

Ok, so class_cond can be specified via extra_args in the call to sample_lms.  So, e.g., to generate a whole bunch of MNIST digits of the number "5", the following modification of sample.py line 60 works:
            x_0 = K.sampling.sample_lms(model, x, sigmas, disable=not accelerator.is_local_main_process, extra_args={'class_cond':torch.tensor([5]).to(device)})

So, what I'm learning is that you must run convert_for_inference.py first, and you may need to modify the code to specify a class_cond in order to sample.   Does that sound right?  If so, close.

You can also just do the following:
ckpt = torch.load(args.checkpoint, map_location='cpu')
inner_model = K.config.make_model(config).eval().requires_grad_(False).to(device)
inner_model.load_state_dict(ckpt['model'])

Doesn't require conversion.

Thank you @nom!
Closing.