link config

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/24288
$ https://github.com/Expensify/App/issues/24288#issuecomment-1670161211
Tests

Open a chat in Safari.
Click on the phone icon located in the header.
Choose either Google Meet or Zoom.
Ensure that the link opens in a new tab rather than a new window.

Test steps for TextLink

Launch the app in Safari.
Log out if currently logged in.
Click on any link on the login page, such as 'Expense Management' or 'Spend Management'.
Ensure that the link opens in a new tab rather than a new window.

Test steps for addPaypalMePage

Go to settings and navigate to the 'Payments' section.
Click on add payment method -> 'PayPal.me'.
Click on the list of supported countries.
Ensure that the link opens in a new tab rather than a new window.

Test steps for BankAccountStep

Navigate to the settings, then to the 'Workspace' section, and select a workspace.
Click on 'Bank Account' option.
Click on 'Your Data is Secure'.
Ensure that the link opens in a new tab rather than a new window.

Test steps for openOldDotLink

Navigate to the settings, then to the 'Workspace' section, and select a workspace.
Click on invoices
Click on View All Invoices
Ensure that the link opens in a new tab rather than a new window.

[x] Verify that no errors appear in the JS console

Offline tests

Same as above
QA Steps

Open a chat in Safari.
Click on the phone icon located in the header.
Choose either Google Meet or Zoom.
Ensure that the link opens in a new tab rather than a new window.

Test steps for TextLink

Launch the app in Safari.
Log out if currently logged in.
Click on any link on the login page, such as 'Expense Management' or 'Spend Management'.
Ensure that the link opens in a new tab rather than a new window.

Test steps for addPaypalMePage

Go to settings and navigate to the 'Payments' section.
Click on add payment method -> 'PayPal.me'.
Click on the list of supported countries.
Ensure that the link opens in a new tab rather than a new window.

Test steps for BankAccountStep

Navigate to the settings, then to the 'Workspace' section, and select a workspace.
Click on 'Bank Account' option.
Click on 'Your Data is Secure'.
Ensure that the link opens in a new tab rather than a new window.

Test steps for openOldDotLink

Navigate to the settings, then to the 'Workspace' section, and select a workspace.
Click on invoices
Click on View All Invoices
Ensure that the link opens in a new tab rather than a new window.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/93134676/37dce450-ba74-4d50-b809-a1d0916b1e42

Mobile Web - Chrome
https://github.com/Expensify/App/assets/93134676/c872cec2-474c-4677-b2dd-caae3860b139

Mobile Web - Safari
https://github.com/Expensify/App/assets/93134676/29d9002c-eb81-4b85-9ddd-9c17f233ef10

Desktop
https://github.com/Expensify/App/assets/93134676/b351087e-1e21-46a1-8683-a25e0bbbf85a

iOS
https://github.com/Expensify/App/assets/93134676/c8d16bf4-5bef-4728-9ba0-baf32aaaa1f2

Android
https://github.com/Expensify/App/assets/93134676/5b51e0c2-26d3-41dc-b138-dfd08c1429e6

@sobitneupane Can you please re-review the PR here, thanks.

@Nodebrute Can you please add test steps for all those changes?

@techievivek I think we should either use asyncOpenUrl (with promise and url as parameter) instead of openExternalLink or add another parameter in openExternalLink to not show growl in offline. I think even when user is offline it makes sense to open a new tab with url in most of the cases.

@sobitneupane

I think even when user is offline it makes sense to open a new tab with url in most of the cases.

:100:, if we can fix that it will be great.

@Nodebrute

Should I disable the growl in all instances when the user is offline, or do we want this change to be implemented selectively in certain areas?

If it's an external link then we can disable the growl and open the URL in a new tab.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/techievivek in version: 1.3.56-0 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Warning for Plenticore G3, Requesting settings failed with code 503

Hi
I get with Plenticore G3 FW 2.4.2 following warnings.
Requesting settings - [{"moduleid":"devices:local","processdataids":["Dc_P","DigitalIn","EM_State","HomeBat_P","HomeGrid_P","HomeOwn_P","HomePv_P","Home_P","Inverter:State","LimitEvuAbs"]},{"moduleid":"devices:local:ac","processdataids":["CosPhi","Frequency","L1_I","L1_P","L1_U","L2_I","L2_P","L2_U","L3_I","L3_P","L3_U","P","Q","S"]},{"moduleid":"devices:local:battery","processdataids":["Cycles","SoC","I","U","P"]},{"moduleid":"devices:local:pv1","processdataids":["I","U","P"]},{"moduleid":"devices:local:pv2","processdataids":["I","U","P"]},{"moduleid":"scb:export","processdataids":["PortalConActive"]},{"moduleid":"scb:statistic:EnergyFlow","processdataids":["Statistic:Autarky:Day","Statistic:Autarky:Month","Statistic:Autarky:Total","Statistic:Autarky:Year","Statistic:EnergyHome:Day","Statistic:EnergyHome:Month","Statistic:EnergyHome:Total","Statistic:EnergyHome:Year","Statistic:EnergyHomeBat:Day","Statistic:EnergyHomeBat:Month","Statistic:EnergyHomeBat:Total","Statistic:EnergyHomeBat:Year","Statistic:EnergyHomeGrid:Day","Statistic:EnergyHomeGrid:Month","Statistic:EnergyHomeGrid:Total","Statistic:EnergyHomeGrid:Year","Statistic:EnergyHomePv:Day","Statistic:EnergyHomePv:Month","Statistic:EnergyHomePv:Total","Statistic:EnergyHomePv:Year","Statistic:OwnConsumptionRate:Day","Statistic:OwnConsumptionRate:Month","Statistic:OwnConsumptionRate:Total","Statistic:OwnConsumptionRate:Year","Statistic:Yield:Day","Statistic:Yield:Month","Statistic:Yield:Total","Statistic:Yield:Year","Statistic:CO2Saving:Day","Statistic:CO2Saving:Month","Statistic:CO2Saving:Year","Statistic:CO2Saving:Total"]}]) failed with code 503: {"message":"internal communication error, try again later"}
Any idea?
Greetings
Olaf

I am getting this error too. The plenticore addon uses the unofficial API from Kostal. I just checked the API on my plenticre and it throws this error when trying to resquest the settings of the plenticore. Maybe simply a bug by Kostal or Kostal is not maintaining the API anymore and therefore they are ignoring these errors. Let`s wait for the next firmware update.

Okay, thanks, good to know

It is not a bug in the API as I thought at first look. The adapter requests a setting parameter (Generator:ExtModuleControl:Enable) which seems not to exists anymore in Plenticore G3 API.
One can solve this issue by removing the following code from file "plenticore.js"
			"Generator:ExtModuleControl:Enable": { 				id: "devices.local.generator.ExtModuleControl", 				type: 'boolean' 			},

Because someone may use it for Plenticore or Plenticore G2, it is probably better not to remove but add conditions for the device type.
It may also not be the only change, because G3 seems to get new updates which G1 and G2 do not get.

My post was just meant as a workaround hint for deepdreams71. For a pull request I agree with you that one should add conditions depending on the device type.

I got the information from kostal support. that one option is not more available anymore, I can’t prove that.
called dynamical Battery management.
If someone can compare
For G2 there should be 3 options
For G3 only 2

I can confirm that there are only 2 options available on G3. But i do not believe that the paramater "Generator:ExtModuleControl:Enable" which is causing the mentioned issue has anything to do with battery management.

I can confirm that the solution you offered works fine now.
I comment out "Generator:ExtModuleControl:Enable": { id: "devices.local.generator.ExtModuleControl", type: 'boolean' },
Log looks well


cannot import name 'Literal' from 'typing'

Describe the bug
Literal Cannot be imported from typing (in Python 3.7 is not in this library, is in typing extensions)
Traceback (most recent call last):
  File "scenarioBasicOrbit.py", line 222, in <module>
    from Basilisk.utilities import (SimulationBaseClass, macros, orbitalMotion,
  File "/home/simone/Git/basilisk/dist3/Basilisk/utilities/SimulationBaseClass.py", line 36, in <module>
    from Basilisk.utilities import deprecated
  File "/home/simone/Git/basilisk/dist3/Basilisk/utilities/deprecated.py", line 23, in <module>
    from typing import Union, Literal, TYPE_CHECKING, Any
ImportError: cannot import name 'Literal' from 'typing' (/usr/lib64/python3.7/typing.py)

To reproduce
create a python 3.7 venv (as required from the instructions)
install basilisk
call scenarioBasicOrbit.py
Expected behavior
Suggest using Python 3.8 or superior in the Docs or use try error to deal with older versions
try:
    from typing import Literal
except ImportError:
    from typing_extensions import Literal

Desktop (please complete the following information):

OS: Fedora 37
Python version 3.7.16

Python 3.7 is currently only receiving security fixes and is being EOL'd next month. I vote that we increment the minimum version of python that BSK supports to 3.8.
https://devguide.python.org/versions/

Thanks, anyway I've used 3.8 and now I'm running the tests for using it with 3.10.
All seems working fine also with 3.10.
So the question is why is the recommended Python version 3.7.x?
Should it not be written ">3.7" or better ">=3.8"?

Anyway thanks for your support and for this beautiful piece of software!

So the question is why is the recommended Python version 3.7.x?

Because the change made to add the deprecation utilities did not test against Python 3.7 (our current CI process only tests against 3.9 - we can easily add more versions and will do so shortly) and therefore missed updating the docs. But the community reported it, thanks to you, and now it can be adjusted. 👍


ProcessRequestTTL must correctly handle status.Status errors

https://github.com/nspcc-dev/neofs-proto/blob/d27583245e6676249eb58e6eaab0a627df48a5c0/service/meta.go#L103-L105

closed by #14


go graticule; FILL  loses some of the graticule lines

Reported by Ansley B Manke on 30 Jan 2002 18:06 UTC
use coads_climatology
go graticule
fill/l=1 sst
Graticule lines in the Southern Hemisphere aren't
redrawn after the FILL plot.  (they are after SHADE)
Migrated-From: http://dunkel.pmel.noaa.gov/trac/ferret/ticket/358

Comment by<EMAIL_ADDRESS>on 15 Nov 2002 19:17 UTC
Fixed after v5.41

Comment by<EMAIL_ADDRESS>on 21 Oct 2003 20:15 UTC
Moving from the<EMAIL_ADDRESS>user to the<EMAIL_ADDRESS>user.


If there's nothing going on, start loading the editor in the background?

Since the editor is quite heavy (should be lighter), maybe it makes sense to load it in the background.

As the editor is very light now, this can be safely skipped.


Adding breadcrumb navigation and program type badge

What are the relevant tickets?
Fixes https://github.com/mitodl/hq/issues/2620
Partially completes https://github.com/mitodl/hq/issues/2559
Description (What does it do?)
Adding breadcrumb navigation and program type badge
Screenshots (if appropriate):

Updated screenshots:


Cache computed values of Configuration for plotting/analysis

When making plots we end up needing to calculate the same underlying quantities several times, so it would be efficient to compute them once and cache them.
See https://docs.python.org/3/library/functools.html#functools.lru_cache
or https://pypi.org/project/cached-property/
We'd need to break up some of the functions into smaller chunks to make things more efficient.
Note that we likely don't want to cache the actual compute functions that get called by the optimizer, so we might want to have separate wrapper functions that do the caching.
IE:
def fun(x):
`    do something
@lru_cache
def fun_cached(x):
    return fun(x)

Along these same lines, we can break the compute functions up into smaller parts, and then sort of build the actual objective function on the fly.
ie right now in compute_coordinate_derivatives we have a flag for whether to include the terms needed for QS and the axis etc.
it would be cleaner if we just have 3 different functions, one for regular, one for QS, one for axis, maybe one for the energy objective if that requires different derivatives.

A lot of recent upgrades have made things faster, so this should be less of an issue. Closing for now.


Undocumented breaking change (Cannot visit )

I noticed that https://github.com/beerlington/classy_enum/commit/963ac910a26d7b6d7f6a0899c9f9f677ffd0cbde removed some visitor support and changed the specs. I upgraded to the 4.0 gem version and am seeing that lines similar to Dog.where(:breed => Breed.build('golden_retriever')) now error. I didn't see any mention of that change in the CHANGELOG, but maybe I'm missing something?

@bsedat that's a good point, this should be added to the changelog since it was intentional and breaking. The reason I pulled it out was because the hacks required to make it work relied on some arel internals that were inconsistent between different versions of Active Record.
I would recommend converting the enum object to a string if possible instead of passing it directly to the query.

No worries, less hacks and more portability are awesome :smile:. Thanks for your work on the gem!

:+1: Thanks!


Error in actionCreate

Hi mootensai
I have an error in ActionCreate in method loadAll (Method app\models\Round::loadAll() does not exist'). Since that loadAll not exists as a YII native method nor a client method I can't resolve that.  Could you give me some help??? Thanks in advance.

did you generate it?

Yes. I generate my model/crud/controller with the extension

This is the generated code
/**
* Creates a new Round model.
* If creation is successful, the browser will be redirected to the 'view' page.
* @return mixed
*/
public function actionCreate()
{
$model = new Round();
    if ($model->**loadAll**(Yii::$app->request->post()) && $model->saveAll()) {
        return $this->redirect(['view', 'id' => $model->id]);
    } else {
        return $this->render('create', [
            'model' => $model,
        ]);
    }
}

This is the generated code
/**
* Creates a new Round model.
* If creation is successful, the browser will be redirected to the 'view' page.
* @return mixed
*/
public function actionCreate()
{
$model = new Round();
    if ($model->loadAll(Yii::$app->request->post()) && $model->saveAll()) {
        return $this->redirect(['view', 'id' => $model->id]);
    } else {
        return $this->render('create', [
            'model' => $model,
        ]);
    }
}

This is the generated code
`/**
* Creates a new Round model.
* If creation is successful, the browser will be redirected to the 'view' page.
* @return mixed
*/
public function actionCreate()
{
$model = new Round();
    if ($model->loadAll(Yii::$app->request->post()) && $model->saveAll()) {
        return $this->redirect(['view', 'id' => $model->id]);
    } else {
        return $this->render('create', [
            'model' => $model,
        ]);
    }
} `

I found that loadAll is a method from yii2-relation-trait extension. I supose that this extension is a dependance but I dont know why not was added. I'm still searching what's wrong here


Linux core

Hi,
this PR is based on branch "dogleft-test-mods" and contains the following enhancements:

compatibility to PSCore under Linux & Windows
adopt all unittests to be compatible to Pester 5
add dev-container config for running DEV under docker containers

All unittests are running successful in PS5, PS7 (Windows and Linux).
If you have any questions or comments, don't hesitate to contact me.
Hope you like these enhancements.
Regards,
Wolfgang

Hi Andy,
I suppose, that I didn't clearly state what my intensions are.  I took these as a base for my work to gain compatibility with the lastest Pester release and PScore runnning on Linux. Marc-Antoine made some remarks on your branches solution which I didn't recognize till last. To revert the changed things according to his remarks seems to be to "dangerous" for me.
So I would like to

take a step back to his master branch
apply the "one method per file" you introduced
add your maintance enhancements
add my modifications for PesterV5 and Linux compatibility
while respecting his thoughts and keeping the modules general structure as is (naming, psd, prefix, etc.)

This might take a few days. But I'm sure finally we'll make it to the gallery with a bunch of enhancements.
Regards, Wolfgang


Add bastion_host_security_group_rules

This commit introduces one new var:

bastion_host_security_group_rules

so that further bastion host customization is possible.

Please run make docs and push the changes from the README.md as well.

I would like to discuss on this one since I have some questions around it

I can see there is another var called security_groups, can't we use security_groups as the one to customize the SG when needed?

the default value of security_group_rules is allowing TCP 22 for incoming and everything for outgoing. our current default value will block all the traffic cuz is a empty list, I guess if we want to use security_group_rules as the default SG. I should use allow incoming 22 and allowing outgoing for everything as the default value.

Here is the reference
https://registry.terraform.io/modules/cloudposse/ec2-bastion-server/aws/latest#input_security_groups


Kata search page returns cached result

Related: #992
Kata search page returns cached result that is chosen randomly as well:

This happens in both https://www.codewars.com/kata/beta and https://www.codewars.com/kata/search/?q=&beta=true

This should be the same issue as #992 which was fixed.


refactor(atomic, headless): move automatic facets to new component

https://coveord.atlassian.net/browse/KIT-2588
This PR moves the generation of automatic facets to a new component and extracts it from the facet manager. Originally the name for it was automatic-facets. I felt it was confusing when looking at the folders because of the already present automatic-facet. For now, I went with automatic-facet-builder. Keep in mind it could be used inside of the facet-manager and would create automatic-facet.
These are other name suggestions for the new component, what do you guys prefer ? :

automatic-facets
automatic-facet-manager
automatic-facet-builder
automatic-facet-generator
automatic-facet-renderer

These are other name suggestions for the new component, what do you guys prefer ? :

automatic-facets
automatic-facet-manager
automatic-facet-builder
automatic-facet-generator
automatic-facet-renderer

Also @mrrajamanickam-coveo, what do you think about these names ? What is the best in your opinion ?


Not all names corrected

Tri vu phu should be Tri Vu Phu
Carlo D'ippoliti should be Carlo D'Ippoliti
Kerényi ádám should be Kerényi Ádám
Matteo Dell'aqcua should be Matteo Dell'Aqcua
Shuanping dai should be Shuanping Dai
What can I do to fix this?

All of those are working except Tri vu phu and Shuanping dai.
Although some Asian names may require the capitalization on 2 and 3 letter words, occidental names usually don't. A possible solution to this issue would be a new attribute to force capitalization of such words. You may detect the users' country in your application and pass the appropriate attribute to capitalize their names.
I'll be adding this feature in the next days.


Cannot have a variable named "error"

Description:
$title, but it is possible to have parameters named "error".
Steps to reproduce:
public function main() {
    error 'error = error("error!"); // ERROR: redeclared builtin symbol 'error'
}

function func(error 'error) { // OK

}

Related Issues:
https://github.com/ballerina-platform/ballerina-lang/issues/30262
Affected Versions:
slalpha5

int 'anydata = 1;
int 'json = 2;

results in the same issue

Let's use https://github.com/ballerina-platform/ballerina-lang/issues/34950 to track this.


dataset

Could you provide the whole munich dataset?
the link is expired: https://github.com/chenzhaiyu/polygnn/issues/3#issuecomment-2512819371
Thanks a lot!

Thanks for your interest. The data is also available for download on Zenodo.


Dealing with scope restrictions on connections

Currently drawing of connections is unrestricted, even if it is impossible from scoping point of view.
For example you can connect the internal top anchor of a lambda to anything which can lead to generation of bad code where the binder escapes the lambda.
The question is how to best prevent this.
One option is to treat scope errors as a variation on type errors, or maybe even block connection lines from escaping a lambda block.
Similar issues will arise with the eventual case constructs.

Blocking connection lines from leaving a lambda block will break reusing constant subexpressions:

This could either be an upside or a downside depending on your point of view.

In my opinion only the (,) block is truly part of the lambda as it depends on the binder.
So in this case the connection line to the display should not be blocked.

I agree. However, it could turn out to be nontrivial to make and explain these decisions.

This is kind of solved in #298 and #300 by allowing a display block inside a container and not parsing connections that come from an inner container. If we consider this a solution, it only needs visual feedback when the destination of a connection is outside of the source's container.

@wandernauta do you consider this issue solved with #319, or is there more to be done here?


island.is changed url format used for /names

Tests have been failing for a few days. Decided to take a look. Basic fix.

:tanabata_tree: :tanabata_tree: :tanabata_tree:


Daily limit for unauthenticated use exceeded

I'm probably doing something wrong here but I'm trying to open a Google Drive file for read-only anonymous access and I appear to be getting an error related to a daily limit. Currently on fsspec=0.8.4 and gdrivefs=HEAD. Am I doing it wrong? I would be happy to help with this if more needs to be done:
of = fsspec.open('gdrive://1LpzE8MEUYitOJeMvJAJOUMJDMVbh_GSr', mode='rb', token='anon')
---------------------------------------------------------------------------
HttpError                                 Traceback (most recent call last)
<ipython-input-7-fec500f75b47> in <module>
----> 1 of = fsspec.open('gdrive://1LpzE8MEUYitOJeMvJAJOUMJDMVbh_GSr' class="ansi-blue-fg">, mode='rb', token='anon')

/srv/conda/lib/python3.7/site-packages/fsspec/core.py in open(urlpath, mode, compression, encoding, errors, protocol, newline, **kwargs)
    436         newline=newline,
    437         expand=False,
--> 438         **kwargs
    439     )[0]
    440

/srv/conda/lib/python3.7/site-packages/fsspec/core.py in open_files(urlpath, mode, compression, encoding, errors, name_function, num, protocol, newline, auto_mkdir, expand, **kwargs)
    285         storage_options=kwargs,
    286         protocol=protocol,
--> 287         expand=expand,
    288     )
    289     if "r" not in mode and auto_mkdir:

/srv/conda/lib/python3.7/site-packages/fsspec/core.py in get_fs_token_paths(urlpath, mode, num, name_function, storage_options, protocol, expand)
    608             )
    609         update_storage_options(options, storage_options)
--> 610         fs = cls(**options)
    611         paths = expand_paths_if_needed(paths, mode, num, fs, name_function)
    612

/srv/conda/lib/python3.7/site-packages/fsspec/spec.py in __call__(cls, *args, **kwargs)
     56             return cls._cache[token]
     57         else:
---> 58             obj = super().__call__(*args, **kwargs)
     59             # Setting _fs_token here causes some static linters to complain.
     60             obj._fs_token_ = token

/srv/conda/lib/python3.7/site-packages/gdrivefs/core.py in __init__(self, root_file_id, token, access, spaces, **kwargs)
     70         self.root_file_id = root_file_id or 'root'
     71         self.connect(method=token)
---> 72         self.ls("")
     73
     74     def connect(self, method=None):

/srv/conda/lib/python3.7/site-packages/gdrivefs/core.py in ls(self, path, detail, trashed)
    167                 file_id = self.path_to_file_id(path, trashed=trashed)
    168             files = self._list_directory_by_id(file_id, trashed=trashed,
--> 169                                                path_prefix=path)
    170             self.dircache[path] = files
    171         else:

/srv/conda/lib/python3.7/site-packages/gdrivefs/core.py in _list_directory_by_id(self, file_id, trashed, path_prefix)
    186             response = self.service.list(q=query,
    187                                          spaces=self.spaces, fields=afields,
--> 188                                          pageToken=page_token).execute()
    189             for f in response.get('files', []):
    190                 all_files.append(_finfo_from_response(f, path_prefix))

/srv/conda/lib/python3.7/site-packages/googleapiclient/_helpers.py in positional_wrapper(*args, **kwargs)
    132                 elif positional_parameters_enforcement == POSITIONAL_WARNING:
    133                     logger.warning(message)
--> 134             return wrapped(*args, **kwargs)
    135
    136         return positional_wrapper

/srv/conda/lib/python3.7/site-packages/googleapiclient/http.py in execute(self, http, num_retries)
    913             callback(resp)
    914         if resp.status >= 300:
--> 915             raise HttpError(resp, content, uri=self.uri)
    916         return self.postproc(resp, content)
    917

HttpError: <HttpError 403 when requesting https://www.googleapis.com/drive/v3/files?q=%27root%27+in+parents++and+trashed+%3D+false+&spaces=drive&fields=nextPageToken%2C+files%28name%2Cid%2Csize%2Cdescription%2Ctrashed%2CmimeType%2Cversion%2CcreatedTime%2CmodifiedTime%29&alt=json returned "Daily Limit for Unauthenticated Use Exceeded. Continued use requires signup.". Details: "Daily Limit for Unauthenticated Use Exceeded. Continued use requires signup.">

I believe this is a genuine limit of the backend. If you wanted to exceed it, you would probably need some API key from google. I am not sure, but it may be possible to circumvent for files where you can get a direct http URL to the resource.
Note that this is happening during list, which is in the code to force an auth - but for anonymous, this is not needed, so you could save some API quota. It may be that list and download have different quotas, so avoiding this line for anon would be a useful change.

Okay thanks for this information. I only tried to open this file once, and this is the first time I have tried to use gdrivefs. So if the limit was exceeded, the limit is zero, which suggests to me that perhaps something isn't working quite right. I will keep looking into it. If you have any additional thoughts or suggestions please let me know.
Getting anonymous access working for Google Drive in fsspec would be fantastically useful. I wrote something stand-alone for this a couple of years ago (https://github.com/tjcrone/driveanon) which does not rely on their API, but my guess is that this access method won't work anymore.

my guess is that this access method won't work anymore.

Worth seeing; or worth trying to remove that ls in __init__ for the anon case.
Either way, the code here is no more than a stab at making gdrive work for fsspec, with the least effort (hence relying on the google package). It may well be better done directly with HTTP, like gcsfs is, but that would require some work. It would, however, enable a testing suite built on vcrpy.

@rabernat, were you able to get this working with anonymous access? Thanks.

No, I don't think so. I only ever used it with a token.
I agree that it would be amazing to unlock the fsspec / gdrive integration.
It would be great if someone would spend time really digging into this and trying hard to make it work better.
But I also worry that it violates the gdrive terms of service in some way and therefore will always remain a sort of underground hack.

Upon some thinking, I'm not sure how anon ought to work - how do you find the target file? If you already have an ID, then you have the full URL and you can just use HTTPFileSystem, right? Or is it possible to share a full folder for browsing?

Upon some thinking, I'm not sure how anon ought to work - how do you find the target file? If you already have an ID, then you have the full URL and you can just use HTTPFileSystem, right? Or is it possible to share a full folder for browsing?

Thanks for your input @rabernat. Do you have specific reason to believe that this would violate terms of service?
@martindurant, I just tried my example from https://github.com/tjcrone/driveanon, and amazingly it still works. Perhaps my code could serve as a roadmap to getting this working with fsspec. Just having the file ID is not enough for large files, because they add a click-to-confirm token which my code gets programatically. Getting a list of blob IDs is not currently possible as my code stands but it was on the roadmap. I think one solution I was considering was to include a list of blob IDs in the folders that I wanted to share, which can be generated after authentication. Ideally the code could get a list of blobs in a folder anonymously but I don't think I solved that problem without scraping.

I am not surprised that accessing the file directly still works - and it's good to know. It's getting information about files and listing that seems to hit the wall.
I haven't looked at your code yet, but I agree that it could easily be the way to go - or some merge of the two.
Since no one else is likely to spend time here, you would be more than welcome!
On the issue of terms violations, well it seems like google already have their checks in place :)

I don't think I solved that problem without scraping.

You do what you can; both the html output and the api itself (at least the limits) may well change at any moment, it seems.

@rabernat, can you please describe the process of obtaining and using a token with gdrivefs? Or point me to the docs if they exists? Thanks.

For non-anon, this line calls pydata_google_auth to do the dance.

I managed to get token='browser' to work. It was throwing an error because the cache file did not exist:
of = fsspec.open('gdrive://1LpzE8MEUYitOJeMvJAJOUMJDMVbh_GSr', mode='rb', token='browser')

---------------------------------------------------------------------------
FileNotFoundError                         Traceback (most recent call last)
<ipython-input-3-b18e1d573af0> in <module>
----> 1 of = fsspec.open('gdrive://1LpzE8MEUYitOJeMvJAJOUMJDMVbh_GSr' class="ansi-blue-fg">, mode='rb', token='browser')

/srv/conda/lib/python3.7/site-packages/fsspec/core.py in open(urlpath, mode, compression, encoding, errors, protocol, newline, **kwargs)
    436         newline=newline,
    437         expand=False,
--> 438         **kwargs
    439     )[0]
    440

/srv/conda/lib/python3.7/site-packages/fsspec/core.py in open_files(urlpath, mode, compression, encoding, errors, name_function, num, protocol, newline, auto_mkdir, expand, **kwargs)
    285         storage_options=kwargs,
    286         protocol=protocol,
--> 287         expand=expand,
    288     )
    289     if "r" not in mode and auto_mkdir:

/srv/conda/lib/python3.7/site-packages/fsspec/core.py in get_fs_token_paths(urlpath, mode, num, name_function, storage_options, protocol, expand)
    608             )
    609         update_storage_options(options, storage_options)
--> 610         fs = cls(**options)
    611         paths = expand_paths_if_needed(paths, mode, num, fs, name_function)
    612

/srv/conda/lib/python3.7/site-packages/fsspec/spec.py in __call__(cls, *args, **kwargs)
     56             return cls._cache[token]
     57         else:
---> 58             obj = super().__call__(*args, **kwargs)
     59             # Setting _fs_token here causes some static linters to complain.
     60             obj._fs_token_ = token

/srv/conda/lib/python3.7/site-packages/gdrivefs/core.py in __init__(self, root_file_id, token, access, spaces, **kwargs)
     69         self.spaces = spaces
     70         self.root_file_id = root_file_id or 'root'
---> 71         self.connect(method=token)
     72         self.ls("")
     73

/srv/conda/lib/python3.7/site-packages/gdrivefs/core.py in connect(self, method)
     74     def connect(self, method=None):
     75         if method == 'browser':
---> 76             cred = self._connect_browser()
     77         elif method == "cache":
     78             cred = self._connect_cache()

/srv/conda/lib/python3.7/site-packages/gdrivefs/core.py in _connect_browser(self)
     86
     87     def _connect_browser(self):
---> 88         os.remove(pydata_google_auth.cache.READ_WRITE._path)
     89         return self._connect_cache()
     90

FileNotFoundError: [Errno 2] No such file or directory: '/home/jovyan/.config/pydata/pydata_google_credentials.json'

Touching the file fixed this error and the credentials file was updated.

Could use a fix :)

Sorry. That was lame I will fix it.

I might have meant the comment for myself, but my list is pretty long

No after I left that comment I felt bad because it's an easy fix. Fixing now will PR momentarily.

Closing because topic is drifting. Thanks for everyone's help here.


Just add @JvmStatic

As a result of the Kotlin migration the static methods can now be accessed via FastAdapter.Companion. E.g.: FastAdapter.Companion.with(...)

Just add @JvmStatic on methods. Refactoring to Kotlin will definitely add breaking changes, but doesn't mean you have to break the things which have a working solution to

@mikepenz if you want this I can send a patch

@AllanWang sure. we can bring this in v4.1-beta01

Functions were already marked as @JvmStatic so I've updated migration docs


The "Editor Description" section does not allow you to scroll down.

Godot version:
3.2 beta 4 mono
OS/device including version:
Win10 64 Home
Issue description:
If you place the cursor in the "Editor Description" section you can scroll up but you cannot do it down.
This should not happen if no text is being written in this section and the section text cursor is inactive.
Steps to reproduce:
Place the cursor in the "Editor Description" section and leave a margin to scroll down, now try to scroll down from the mouse wheel, you will see that it does not work.

Minimal reproduction project:

This is a bug in the multiline string exports (which creates a TextEdit node). Scrolling events shouldn't be handled by that node if scrolling is enabled but no scrollbar is visible.

Seems fixed in the master branch, probably by #34572.

Couldn't reproduce this issue when working on #39717.

Fixed in v3.5.beta1.official [b9b23d222]

Thanks for re-testing all your issues, that's very appreciated :)

I have many, I will continue in the next few days.


Timed Wait for Input

Hi,
I looked at APIs for text io and did not find timed wait for input. Did I miss it or is this something not supported in text io?
Thanks,
Brian

No, timed wait is currently not supported.


Related links fix

Adding md endpoints to related links.

@v-cmans,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


gRPC client doesn't work with Service Discovery scheme resolution syntax

The format used to support URI scheme resolution recently added to service discovery (e.g. https+http://) does not work with the gRPC client stack. The GrpcChannel class does a lot of initialization in its constructor based on the scheme of the address and special-cases https:// and http:// for numerous operations including ResolverFactory resolution and credential selection.
@JamesNK interested in your thoughts on how we might go about fixing this. I messed about a bit with a custom ResolverFactory and got further but seems we'd have to integrate more deeply to make the syntax work or update GrpcChannel to tolerate it some other way.

HttpClient happily sends HTTP requests to different hosts over https or http, and you can completely change a request as it goes through the handler pipeline.
GrpcChannel is different in that you specify the scheme + host, and then it only sends request to that address. Because of this, the channel has logic in it that knows whether it is https or http, and makes decisions based on that.
Maybe something could be done in Grpc.Net.Client. But GrpcChannel wasn't designed to work like this. It really wants to know what its scheme is when it's created, not when it is sending a gRPC call.

Can we integrate Service Discovery into the gRPC client in a different way, such that the address is fully resolved by the time the GrpcChannel is being created?

Next steps are to experiment with bringing back a gRPC resolver but this time for the "https+http" scheme (or whatever combination the user wants) and see how far we get with that approach.

Moving to p6, unclear if it meets the bar though

No we can move it out.

We should consider moving this to the backlog until we get user feedback that it's worth investigating.

What kind of feedback is needed for this? We're using grpc for some services and would love to see a solution for service discovery.

@gabynevada TBC, service discovery of the hostname/addresses does work right now, it's just the multi-scheme format fallback feature that doesn't work with gRPC, e.g. https+http://my-service. Do you have a specific need for that support?

@DamianEdwards Understood! We were using multi-scheme format but changed to a single scheme and it works fine. Don't have a need for multt-scheme for the moment, thanks!


Not able to create a table in hbase

Hi,
I am not able to create a table as it is not able to connect to my cluster using zookeeper.

16/08/08 12:30:13 INFO ClientCnxn: Opening socket connection to server localhost/0:0:0:0:0:0:0:1:2181. Will not attempt to authenticate using SASL (unknown error)
16/08/08 12:30:13 WARN RecoverableZooKeeper: Possibly transient ZooKeeper, quorum=localhost:2181, exception=org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = ConnectionLoss for /hbase/hbaseid
16/08/08 12:30:13 WARN ClientCnxn: Session 0x0 for server null, unexpected error, closing socket connection and attempting reconnect
java.net.ConnectException: Connection refused
at sun.nio.ch.SocketChannelImpl.checkConnect(Native Method)
at sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:717)
at org.apache.zookeeper.ClientCnxnSocketNIO.doTransport(ClientCnxnSocketNIO.java:361)
at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:1081)

Could you please tell me where can I put/configure my hbase-site.xml and core-site.xml. Currently I have placed it in the resource folder of my project.
Thanks

That is because configuration cannot be loaded, and adding them manually might help you to solve the problem.
try to add
      hbaseConf.set("zookeeper.znode.parent", "/hbase-secure")
      hbaseConf.set("hbase.zookeeper.quorum","{zookeeper.quorum}")
      hbaseConf.set("hbase.zookeeper.property.clientPort","2181")

I'm having the same problem, but running from PySpark. Is there another way to solve this?

If you run integration tests on Hadoop Mini Cluster using HBaseTestingUtility, consider setting the property:
test.hbase.zookeeper.property.clientPort to "2181"
http://stackoverflow.com/questions/32752513/hbasetestingutility-set-configuration-zookeeper-clientport-not-working


Create testfile

Test CLA

@T-Lakshmi, it will take some time for CLA you can directly start your contribution

Hi @T-Lakshmi – it would be great if you could follow the instructions according to this link and test your CLA in a purposeful contribution, as opposed to opening a test PR. We are happy to be patient with CLA corrections in a PR that also contributes something to the Kubernetes documentation, like an update or change. With that in mind, I'll be closing this PR now – thanks for your understanding.


fix(CONTRIBUTING.md): change link to angular commit message guidelines

Current coverage is 100% (diff: 100%)

No coverage report found for master at 3868089.

Powered by Codecov. Last update 3868089...18dcb38


Fix build error due to dependency change

There is a dependency change - https://github.com/yvasiyarov/newrelic_platform_go/blob/db03d6dfd965ebc22dbfd910567c641b326ff055/component.go#L25
Build error - github.com/yvasiyarov/gorelic/agent.go:133: not enough arguments in call to newrelic_platform_go.NewPluginComponent

++

+1
[0] ~ >> go get github.com/yvasiyarov/gorelic
# github.com/yvasiyarov/gorelic
go/src/github.com/yvasiyarov/gorelic/agent.go:133: not enough arguments in call to newrelic_platform_go.NewPluginComponent
[2] ~ >>

guys, I'm sorry for this incident. Issue was fixed by another pull request


Version error print in log

io.github.gaming32.worldhost.WorldHost | WH-RecvThread-1 | Received protocol error: You are using an old insecure version of World Host. It is highly recommended that you update to 0.4.14 or later.
This message gets printed in the log every times the game boots but no version 0.4.14 is found anywhere to download.
Running on fabric 1.21.0 with world host v0.4.13

0.4.14 is currently unreleased, but will be released soon.


fix typo otherBasis -> orthoBasis

The original function name in ao.c was orthoBasis.
I guess the function is generating orthonormal basis (https://en.wikipedia.org/wiki/Orthonormal_basis).

Thank you!


Inconsistent Email Validation Between Postman API Testing and Application Interface.

Hi,
My name is Tomasz Pochron, and I am a student at Jagiellonian University. I'm writing to report a discrepancy observed in email address validation within our project.
During a practical exercise in our software development class, we noticed that when testing our API through Postman, it accepts email addresses with trailing spaces. However, this is not the case with our application's user interface, which correctly rejects such inputs. This inconsistency was also observed during routine quality assurance testing.
Here is a screenshot illustrating the issue:

We are keen to understand the reason behind this discrepancy and would greatly appreciate any insights or advice you could offer. This will not only help us resolve the current issue but also enhance our overall understanding of API development and testing.
Thank you for your time and assistance.
Best regards,
Tomasz Pochron

Hi Tomasz, thanks so much for trying out the Climate Mind backend API. Your
question is a good one. We use T-SQL (transact SQL) for our backend SQL
server and database. SQL Queries that search the TSQL databases for matches
in a table will ignore trailing spaces. This is a behavior that is built
into the TSQL server and SQL dialect.
Another separate thing to mention just to keep in mind is that we use SQL
Alchemy as an intermediary. The SQL alchemy package acts as a bridge,
allowing use python to conduct SQL database interactions. This is why you
will rarely see SQL code in our code base and why it’s harder to realize
that the inconsistency you pointed out is a feature of SQL.
I believe this answers your question. Let us know! And if not let us know
and we will do our best to help out. You can read more about this too at
the following links:
https://m.youtube.com/watch?v=kf7yop2ik3M
https://bertwagner.com/posts/trailing-spaces-in-sql-server/
https://www.brentozar.com/archive/2017/04/surprising-behavior-trailing-spaces/
https://learn.microsoft.com/en-US/sql/t-sql/language-elements/string-comparison-assignment?view=sql-server-ver16
Cheers,
Kameron
On Sun, Jan 7, 2024 at 4:15 PM Tomasz Pochroń @.***>
wrote:

External Email
Hi,
My name is Tomasz Pochron, and I am a student at Jagiellonian University.
I'm writing to report a discrepancy observed in email address validation
within our project.
During a practical exercise in our software development class, we noticed
that when testing our API through Postman, it accepts email addresses with
trailing spaces. However, this is not the case with our application's user
interface, which correctly rejects such inputs. This inconsistency was also
observed during routine quality assurance testing.
Here is a screenshot illustrating the issue:
Zrzut.ekranu.2024-01-06.221022.png (view on web)
https://github.com/ClimateMind/climatemind-backend/assets/23237107/8fc84f42-e6ce-4640-93c8-5c58daa2a772
We are keen to understand the reason behind this discrepancy and would
greatly appreciate any insights or advice you could offer. This will not
only help us resolve the current issue but also enhance our overall
understanding of API development and testing.
Thank you for your time and assistance.
Best regards,
Tomasz Pochron
—
Reply to this email directly, view it on GitHub
https://github.com/ClimateMind/climatemind-backend/issues/507, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AEXL62VL76TIKTHHXPB5EETYNM3BNAVCNFSM6AAAAABBQV527GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DSMZWHEZTQMQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@tomaszpochron  I believe this behavior of ignoring trailing spaces is controlled by the ANSI_PADDING setting for the SQL server. By default is is set to ON. Turing it to OFF might resolve the inconsistency you brought up, but it creates other problems with the database so it’s recommended to keep it set to ON. https://learn.microsoft.com/en-US/sql/t-sql/statements/set-ansi-padding-transact-sql?view=sql-server-ver16

Hi Kameron (@rodriguesk),
Thank you so much for the detailed response regarding the trailing spaces issue in the Climate Mind backend API.
Your explanation regarding the behavior of T-SQL and its interaction with SQL Alchemy provided a clear understanding of the issue.
I appreciate the time and effort you took to address our query.
Best regards,
Tomasz Pochron


Create a Grocerylist

Feature request

What is the expected behavior?
As a user I want to create a list with items which I need to by doing groceries.
What is motivation or use case for adding/changing the behavior?
First feature op the app.
How should this be implemented in your opinion?
The correct way 😆
Are you willing to work on this yourself?
yes

I'm not sure this repo is what you think it is...

This is so embarrassing!
I was trying out issues but somehow it got in your repository. My sincere
apologies.
Obviously you may remove them.
Kind regards,
Sander
On Tue, 21 Mar 2023, 03:41 Steve Smith, @.***> wrote:

I'm not sure this repo is what you think it is...
—
Reply to this email directly, view it on GitHub
https://github.com/ardalis/ardalis-com-gatsby/issues/1642#issuecomment-1477202944,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7SJIYGFMDCKYL6I5FEOWLW5EIMXANCNFSM6AAAAAAWAYHZTU
.
You are receiving this because you authored the thread.Message ID:
@.***>

No worries 😃


Added version check

[x] I've added a new note in the CHANGELOG.md file, according to docs:
https://iver-wharf.github.io/#/development/changelogs/writing-changelogs

Summary

Added meta & health endpoints
Changed (c Client) → (c *Client)
Added validateEndpointVersion method
Added validation to all endpoint methods
Updated CHANGELOG.md

Motivation
Additional missing endpoints. I actually wanted the version endpoint in wharf-cmd-watchdog.
Docs wise: Great to get the version from the client instead of having to look between the swagger docs and back. I don't think this will be difficult to maintain.
Validation wise: It's a feature I think all clients should have, and I think this implementation is simple enough yet powerful enough. Could possibly change it to only log instead of error on version mismatch?

LGTM! Nice 👍🏻
I think having it both error and log is good, issues arising from version mismatch can be very annoying if there's no obvious warning about it. And having a way when using the client to decide to use a different endpoint based on if it returned ErrOutdatedServer/ErrOutdatedClient seems good 👍🏻
E.g. if using the client and we haven't updated it in time, the user could easily check for the ErrOutdatedClient error and do a raw request instead. Or something like that.

I like this suggestion. I've changed it so logging and erroring is two separate things. By default it will always log.


feat(autoware_map_msgs): migrate autoware_auto_mapping_msgs to autowa…

Description
migrate autoware_auto_mapping_msgs to autoware_map_msgs.
migrate three messages:
HDMapBin.msg
MapPrimitive.msg
HDMapSegment.msg
Related links
Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Could you look into this PR:

https://github.com/autowarefoundation/autoware_msgs/pull/30

I've added these as:

https://github.com/autowarefoundation/autoware_msgs/blob/main/autoware_map_msgs/msg/LaneletMapBin.msg
https://github.com/autowarefoundation/autoware_msgs/blob/main/autoware_planning_msgs/msg/LaneletRoute.msg
https://github.com/autowarefoundation/autoware_msgs/blob/main/autoware_planning_msgs/msg/LaneletSegment.msg
https://github.com/autowarefoundation/autoware_msgs/blob/main/autoware_planning_msgs/msg/LaneletPrimitive.msg

Could you look into this PR:

feat(map-messages): add LaneletMapBin.msg #30

I've added these as:

https://github.com/autowarefoundation/autoware_msgs/blob/main/autoware_map_msgs/msg/LaneletMapBin.msg
https://github.com/autowarefoundation/autoware_msgs/blob/main/autoware_planning_msgs/msg/LaneletRoute.msg
https://github.com/autowarefoundation/autoware_msgs/blob/main/autoware_planning_msgs/msg/LaneletSegment.msg
https://github.com/autowarefoundation/autoware_msgs/blob/main/autoware_planning_msgs/msg/LaneletPrimitive.msg

Thanks @xmfcx :
Due to my negligence, I did not see the previous PR, I will close this PR.
I see that the Universe repository is still using the autoware_auto_map_msg, Have you made a PR for modification?

Due to my negligence, I did not see the previous PR, I will close this PR.

@cyn-liu It was our fault too, not making these changes obvious. I'm sorry that you've lost time.

I see that the Universe repository is still using the autoware_auto_map_msg, Have you made a PR for modification?

No, we should update the repository to use these new messages. I think you can start working on this task.
For the control messages I have the following issue with 5 related PRs:

https://github.com/autowarefoundation/autoware.universe/issues/3674

Right now, once the adapter node is created, I will merge rest of them.
Adapter node is to not break compatibility with outside simulator environments.

No, we should update the repository to use these new messages. I think you can start working on this task.

thanks, great job.
I plan to update  the Universe repos with new autoware_map_msg.

No, we should update the repository to use these new messages. I think you can start working on this task.

thanks, great job.
I plan to update  the Universe repos with new autoware_map_msg.


NoClassDefFoundError: IllegalName with karate-gatling 0.9.5.RC3

I have a series of tests that run fine currently on karate 0.9.4. I have a requirement to modify them to use a certificate, and have found that 0.9.5 RC3 allows me to do that successfully.
Unfortunately, what no longer works on 0.9.5 RC3 is karate-gatling. The error I get is this:
Uncaught error from thread [GatlingSystem-akka.actor.default-dispatcher-5]: Uncaught error from thread [GatlingSystem-akka.actor.default-dispatcher-4Uncaught error from thread [GatlingSystem-akka.actor.default-dispatcher-2]: IllegalName: com.intuit.karate.gatling.KarateAction$$Lambda$390/0x000000080149ac40AccAccess, shutting down JVM since 'akka.jvm-exit-on-fatal-error' is enabled forIllegalName: com.intuit.karate.gatling.KarateAction$$Lambda$390/0x000000080149ac40AccAccess, shutting down JVM since 'akka.jvm-exit-on-fatal-error' is enabled for ActorSystem[ ActorSystem[GatlingSystem]
]: IllegalName: com.intuit.karate.gatling.KarateAction$$Lambda$390/0x000000080149ac40AccAccess, shutting down JVM since 'akka.jvm-exit-on-fatal-error' is enabled for ActorSystem[GatlingSystem]
GatlingSystem]
java.lang.NoClassDefFoundError: IllegalName: com.intuit.karate.gatling.KarateAction$$Lambda$390/0x000000080149ac40AccAccess
        at java.base/java.lang.ClassLoader.preDefineClass(ClassLoader.java:889)
        at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1014)
        at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:877)
        at net.minidev.asm.DynamicClassLoader.defineClass(DynamicClassLoader.java:86)
        at net.minidev.asm.BeansAccessBuilder.bulid(BeansAccessBuilder.java:313)
        at net.minidev.asm.BeansAccess.get(BeansAccess.java:111)
        at net.minidev.json.reader.BeansWriterASM.writeJSONString(BeansWriterASM.java:17)
        at net.minidev.json.JSONValue.writeJSONString(JSONValue.java:586)
        at net.minidev.json.reader.JsonWriter.writeJSONKV(JsonWriter.java:392)
        at net.minidev.json.reader.JsonWriter$7.writeJSONString(JsonWriter.java:145)
        at net.minidev.json.reader.JsonWriter$7.writeJSONString(JsonWriter.java:1)
        at net.minidev.json.JSONValue.writeJSONString(JSONValue.java:586)
        at net.minidev.json.reader.JsonWriter.writeJSONKV(JsonWriter.java:392)
        at net.minidev.json.reader.JsonWriter$7.writeJSONString(JsonWriter.java:145)
        at net.minidev.json.reader.JsonWriter$7.writeJSONString(JsonWriter.java:1)
        at net.minidev.json.JSONObject.writeJSON(JSONObject.java:186)
        at net.minidev.json.JSONObject.toJSONString(JSONObject.java:74)
        at com.jayway.jsonpath.spi.json.JsonSmartJsonProvider.toJson(JsonSmartJsonProvider.java:83)
        at com.jayway.jsonpath.internal.JsonContext.jsonString(JsonContext.java:71)
        at com.intuit.karate.ScriptValue.copy(ScriptValue.java:212)
        at com.intuit.karate.ScriptValueMap.lambda$copy$0(ScriptValueMap.java:72)
        at java.base/java.util.HashMap.forEach(HashMap.java:1333)
        at com.intuit.karate.ScriptValueMap.copy(ScriptValueMap.java:72)
        at com.intuit.karate.core.ScenarioContext.<init>(ScenarioContext.java:393)
        at com.intuit.karate.core.ScenarioContext.copy(ScenarioContext.java:373)
        at com.intuit.karate.core.ScenarioExecutionUnit.<init>(ScenarioExecutionUnit.java:89)
        at com.intuit.karate.core.Feature.getScenarioExecutionUnits(Feature.java:128)
        at com.intuit.karate.core.FeatureExecutionUnit.init(FeatureExecutionUnit.java:75)
        at com.intuit.karate.core.FeatureExecutionUnit.run(FeatureExecutionUnit.java:91)
        at com.intuit.karate.gatling.KarateActor$$anonfun$receive$1.applyOrElse(KarateAction.scala:26)
        at akka.actor.Actor.aroundReceive(Actor.scala:517)
        at akka.actor.Actor.aroundReceive$(Actor.scala:515)
        at com.intuit.karate.gatling.KarateActor.aroundReceive(KarateAction.scala:23)
        at akka.actor.ActorCell.receiveMessage(ActorCell.scala:588)
        at akka.actor.ActorCell.invoke(ActorCell.scala:557)
        at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:258)
        at akka.dispatch.Mailbox.run(Mailbox.scala:225)
        at akka.dispatch.Mailbox.exec(Mailbox.scala:235)
        at akka.dispatch.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
        at akka.dispatch.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
        at akka.dispatch.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
        at akka.dispatch.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)

Any help or advice on what to do about this would be appreciated.

@chadccollins - you will have to submit a working minimal example because this seems to be a combination of a gatling upgrade, a copy step in Karate and you mention SSL. try avoiding a copy in your test also. the other hint is whatever you are attemting to copy is not a plain JSON (or XML) payload and you should try to avoid doing this in Karate in general.
I'll keep this open in the off-chance that someone picks it up - but without any way to replicate I will close this in a matter of time. instructions: https://github.com/intuit/karate/wiki/How-to-Submit-an-Issue

I've stripped down my project to the minimum, and I think it looks to be an issue with using CSV files to run some data drive tests. I pushed a sample project here:
https://github.com/chadccollins/karate-gatling-0.9.5-RC3-example
There are two similar tests, one with a CSV as input, and the other with an inline defined table. Both will work under 0.9.4, but not under 0.9.5-RC3.
Fortunately, I think this gives me a workaround for the time being, but hopefully this is helpful information for you.
Also, I'm brand new to this and have only been working off of examples found online. If something is obviously wrong above, please let me know.

@ptrthomas is there a branch with the 0.9.5-R53 changes?
When I extracted the classes in the v0.9.5-R53 jar and I could only see  below in "META-INF/maven/com.intuit.karate" package
karate-apache:
karate-core:
karate-netty:
karate-ui:

@chadccollins thanks for the example, super-helpful - I have fixed it so it won't happen in future
personally I think gatling feeders are a better fit for what you are doing, but do keep me posted on how it works for you. I still can't believe the massive hack which is the csv-driven scenario-outline works without any other gotchas

Can you point me to some examples of how to do this better? Thanks!

@chadccollins try this: https://github.com/intuit/karate/tree/develop/karate-gatling#feeders

released 0.9.5


Taking long time to launch App while using robotium recorder

From<EMAIL_ADDRESS>on June 05, 2015 05:04:34
What steps will reproduce the problem? 1. I tried to install https://play.google.com/store/apps/details?id=com.myntra.android on Moto E(XT1022) with few apps installed. It took me 1 min and 2 seconds to launch the app.
2. Then I tried to do the same after doing factory reset. It took me 55 seconds to launch the app. What is the expected output? What do you see instead? Is there a way so that I can reduce the install and launch time? What version of the product are you using? On what operating system? I am using robotium 2.1.29 with robotium-solo-5.3.2-SNAPSHOT.jar on Windows 7 operating system Please provide any additional information below.
Original issue: http://code.google.com/p/robotium/issues/detail?id=681

From<EMAIL_ADDRESS>on June 05, 2015 08:25:09
Robotium Recorder is using adb to install and launch the recording. The install and launch time can therefore not be reduced as its with adb the issue lies.
Status: Invalid
Owner<EMAIL_ADDRESS>


[EventModification] Table 77 Report Selections - OnBeforeGetVendorEmailAddress

Hello, Is it possible to add RecVar as a parameter in the event GetVendorEmailAddress?
Event OnBeforeGetVendorEmailAddress in Table 77:

Parameters:

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Setup Discussions and Project board

Is your feature request related to a problem? Please describe.
Currently no discussion and issue organization is possible.
Describe the solution you'd like
GitHub Project and Discussions should be used for interacting with the community and discussing about changes.
Additionally GitHub Projects will be used to organize and monitor issues better.
Describe alternatives you've considered
Additional context
This issue does not require any code changes. It can be closed manually once things are set up.
Check https://github.com/it-at-m/refarch-templates for a working example.
### Tasks
- [x] Setup Discussions
- [x] Setup Project Board

Discussions and Board was set up.


[ACS -SIP Routing] GA - API Review

New API Review meeting has been requested.
Service Name: IC3 ACS Resource Provider
Review Created By: Jorge Garcia Hirota
Review Date: 2/22/2023 9:00 AM PT
PR: ~~https://github.com/Azure/azure-rest-api-specs/pull/22672~~ https://github.com/Azure/azure-rest-api-specs/pull/22747
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description: ~~https://portal.azure-devex-tools.com/branch/Azure/azure-rest-api-specs/dev-communication-SipRouting-2023-03-01...main/~~ https://portal.azure-devex-tools.com/branch/Azure/azure-rest-api-specs/dzeliar-communication-SipRouting-2021-05-01...main/
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here
Edit: Updated link to a new PR and description as the original branch was by mistake created as protected

@dzeliar can we do some followup around async review here :)

API Stewardship Board Review: 22-Feb-23

Recommend deprecating previews using azure-deprecating header and following our preview/GA guidelines.

Next Steps
Pending the updates to the versioning, this is good for GA (2023-03-01) and preview of (2023-03-02).

Hello @markweitzel, @mikekistler . I updated the version to 2023-03-01 as suggested. The preview of 2023-03-02 will be done in a separate PR as suggested. Please have a look and approve the PR. Thank you

Cancelled by: Jorge Garcia Hirota


Added CV 79922 HF

Added https://harness.atlassian.net/browse/OIP-668 to CD RN Hotfix 79922

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


elab_as_elim does not support function application in resulting motive arguments

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Check that your issue is not already filed.
Reduce the issue to a minimal, self-contained, reproducible test case. Avoid dependencies to mathlib4 or std4.

Description
I would like to mark the following lemma elab_as_elim:
theorem natAbs_elim {motive : Nat → Prop} (i : Int)
  (hpos : ∀ (n : Nat), i = n → motive n)
  (hneg : ∀ (n : Nat), i = -↑n → motive n)
  : motive (Int.natAbs i)
  := by sorry

in order for apply to succeed at e.g.:
example (x : Int) (y : Nat) : x.natAbs < y := by
  apply natAbs_elim x
  sorry

However currently the elab_as_elim annotation fails with
unexpected eliminator resulting type
  motive i.natAbs

Context
Zulip thread: https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/apply.20motive.20failure
Steps to Reproduce
Expected behavior: elab_as_elim succeeds on the natAbs_elim example
Actual behavior: elab_as_elim fails on natAbs_elim
Versions
Lean 4.8.0-rc1
NixOS unstable
Additional Information
N/A
Impact
Add :+1: to issues you consider important. If others are impacted by this issue, please ask them to add :+1: to it.

So far, lean assumes that elims conclude with a motive a b c where the targets are plain parameters, not complex expressions like Int.natAbs. This looks like a deliberate design decision to me, and changing this would be nontrivial. By that reasoning I’m inclined to close this as “works as designed”.
Mario says that this used to work differently in lean3. Is this a significant issue here? If so, maybe an RFC would be in order?

For induction/cases tactics, one of the issues here is that when you allow arbitrary expressions in the motive application, it's not clear what the major premises are supposed to be anymore.
However, I think it would be a straightforward refactor to support this for @[elab_as_elim], since in the end the major premises don't matter — the procedure just needs to know which arguments contribute to the elaboration of the motive, so that we can eagerly elaborate those before doing expected type generalization. Supporting this feature might even simplify the elaborator.
I'd suggest keeping this issue open to track this.


nixos: systemd: initrd: add support for luks

Description of changes
This adds luks support for systemd-initrd. Luks also requires adding udev rules into initrd, so this is added as well.
Note that this PR still requires tests.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Do we still need the udev commit now that #167349 is merged?

This is already supported on master for a while. I'll close this.


Federated Genome Interoperability: Analysis on genomic variation to support treatment and research

A minimal viable solution must define how the information needs of the stakeholders are translated into queries and what the characteristics of the responses provided by the VP should be to fulfil those needs. This could be demonstrated using fictive but representative scenarios with corresponding synthetic data and simulated services that imitate components and resources connected to the VP.
The queries must be able to accurately represent (a) a variant, (b) the corresponding gene, (c) and observed phenotypes. The responses must be able to accurately represent

phenotypes, clinical conditions, and tests that support diagnosis;
the different types of information that are available across the resources connected to the VP;
subsets of information with associated frequency statistics;
(optionally) provide information the conditions for data use (DUO) and contact information for parts of results that cannot be served over the virtual platform;
(optionally) provide information about the origins of the information (protocols etc) and how the result were obtained (aggregation/query);
(optionally) record access / processing of queries run on the resources

The solution must demonstrate how queries are distributed across a single and multiple VP compliant resources and how the results are augmented by including a new VP compliant resource.
A minimal viable solution must be able to provide a pivot table of the query parameters (variant, gene, phenotype) against frequency statistics of the matching results (variant, gene, phenotype, test) across VP compliant resources. If possible, it should also provide information explaining how the results were produced, such as method and (types of) data sources (in user scenario: for authorised viewers only).
Note: It is assumed that the medical professional has been granted access to the data sources. The proof-of-concept for data access only pertains to demonstrating that access protocols and conditions have been defined in metadata.
Additional references:

Use case flash card
Swedish use case description
Mind map from sessions with @NuriaQueralt and Clinical Geneticist Gijs Santen
Overview slide to define what we would need to do to create the LUMC FAIR data station for the use case.

Implementations and sub-issues

[ ] Synthetic genome data & 1+ Million Genomes Framework implementation (NBIS - ELIXIR Sweden) #29
[ ] LUMC genome #31
[ ] Catalogue of SPARQL queries for the VP #28

Depracating #39  for clarity.
Here were its comments
Latest (one week ago):
Discuss the workflow in the coming week.
Focus update of metadata models on the parts of the models that we need.
Two weeks ago:
Discuss DCAT + CARE-SM in meeting
@NuriaQueralt Started Phenopackets V2

Update:
Proposed update of the description of #28 to drive the development of queries based on the use case flash card that can drive the development of synthetic data and and demonstrators.

Update:

Working on mapping EGA’s metadata model to entities defined in EJP-RD (NBISweden / ejprd #18). Turns out to be non-trivial, looking for training materials / examples to rely on, notably the CARE-SM Implementation CSV-template.
Remaining GDI Starter Kit components: LS AAI/REMS

Nuria and Rosa are making progress on Semantic Phenopackets model (version 2).

[ ] Nuria will add github for version 2

Model version 2 done
Rose worked on RDF
Addressed questions from mindmap in Jupyter notebook

[ ] Núria will make sure links are added to the github issue.
[ ] Next meeting: Rosa/Núria show results.


Move walking parameters to the yaml file

This change is

I also updated the radio command because there are many parameters in HighLevelCommand.

I also updated the radio command because there are many parameters in HighLevelCommand.


Decimal point being removed once all decimal numbers being delete.

I have the following scenario.

The user enters 2.3
Presses backspace key
Value in the input is 2

Expected: The value should 2.
I'm using createNumberMask addon so any help how to deal wit this problem is  welcomed1

I had the same issue. Fixed by removing guide={false}


Update the version of no-response bot.

This is to fix an issue with the sorting of the bugs being processed.
Bug: https://github.com/flutter/flutter/issues/89057
Pre-launch Checklist

[X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[X] I read the Tree Hygiene wiki page, which explains my responsibilities.
[X] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[X] I signed the CLA.
[X] I listed at least one issue that this PR fixes in the description above.
[X] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is test-exempt.
[X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I believe at this point if we really want to use the no-response bot we should fork it. It's been months with no response.

@godofredoc What's the process to make a Flutter-owned fork? Presumably we want it to be org-owned, not a fork by a random contributor.


Version bump

Coverage remained the same at 93.907% when pulling f9a74e98bd9c869719c88fd79c4bb1d61b9ee209 on version-bump into e986f3e569d596a8481a71801b741e658a55ceb2 on master.


Adding a theme from another directory

Hello,
I would like to add a theme which is not a standard theme and thus not located in sap/ui/core/themes/ how would I go about doing this?
I tried to add my theme path to the rootPaths Array but with no success. Thanks in advance.

Hey,
can you please let me know what information you passed to the theme options property as well as which path your theme is in and what you added to the rootPaths?

Hey @cevou,
thanks for replying so fast! My theme is located in: www/style/custom_theme. I added custom_theme to the theme property and ./www/style/ to the rootPaths array. Maybe I misunderstood something basic about what I should provide in those?
Thanks for your help, it is greatly appreciated and I wish you happy easter days! 😄

The openui5-webpack-plugin uses the less-openui5 library to build the themes.
So for every library that is defined, it will try to use the library.source.less file to build the theme.
Example sap.ui.core: it will try to find sap/ui/core/themes/custom_theme/library.source.less
To find this will it will use all directories defined in rootPaths as base directories. All rootPaths are relative to the directory in which the webpack.config.js file is located. So if you config file is in your projects root directory and the theme in the www/style subdirectory you would add this to the rootPaths.

Thanks for getting back to me! That explains it. I think the source.less file got lost somewhere so I will try to get back to the person who created it originally.
Is there a way to use the loader with an already transpiled custom css theme?
Thanks!

Yes, you can use for example the CopyWebpackPlugin to just copy the file to the directory, for example: sap/m/themes/custom_theme/library.css. There should be a library.css file for every library used by the application.
I will close this, as this is not a bug of this plugin.


Review apps not being cleaned up

We've seen quite a few instances of our review apps not being cleaned up when the PRs are merged or closed with unmerged changes. It'll probably take some investigation to figure out why, but it's going to be a problem if we can't make this more reliable.
NOTE: some of the review apps are being cleaned up, so we'll have to get creative about snooping out the conditions that would cause them to fall through the cracks.
NOTE 2: this might have to do with how we're using the action as well... maybe we're not invoking it at all under certain circumstances

I found and patched a pretty big flaw in our we were using the action. Closing this until we see problems that are actually attributable to the action itself.


Feature: arrow up key shows previous command

Description
Usually terminal supports thie feature: when I entered arrow up key, then the terminal automatically shows previous command.
Maybe it would be nice to implement this feature in pomodoro cli

I believe this can be added with rustyline. If it's alright I would like to work on this.

Hello, @TheRustyPickle , thank you for the comment. Yes you can. Before we dive in, it's good to clarify what the issue is.
As you already know, when we run the rust-cli-pomodoro then it shows like this.

In this case, I had to type the command manually. (No auto complete, no history supported). I want to solve this problem - command typing inconvenience.
Yes, I also think rustyline can solve this problem. And I think gluesql is a good example of using rustyline maybe.
Maybe you can take a look these two files? (I didn't read the code but might helpful haha)

https://github.com/gluesql/gluesql/blob/e32984c96a71bdc09f4e6fa76a7479c9c5af4060/cli/src/cli.rs#L1
https://github.com/gluesql/gluesql/blob/e32984c96a71bdc09f4e6fa76a7479c9c5af4060/cli/src/helper.rs#L1

Good luck!


[Feature Request] add highlighting for .diff/.patch

Context

[X] This issue is not a bug report. (please use a different template for reporting a bug)
[X] This issue is not a duplicate of an existing issue. (please use the search to find existing issues)

Description
So far that isn't included in the samples, so I guess it isn't available as a "plain" highlighter (handling comment/hint lines, giving the background of + / - a green/red style.
I came here checking if this is supported in monaco-editor as the PowerToys preview doesn't handle it - but it seems to be really missing here (if not, then it is missing in the examples).
Monaco Editor Playground Link
No response
Monaco Editor Playground Code
No response

I also think it'd be a great feature! And btw it's also implemented as part of GitHub markdown rendering.
I also created a similar issue earlier: https://github.com/microsoft/monaco-editor/issues/2471, but it was closed as a wontfix even without a possibility of commenting :(


Training logs for Swin-B/S/L

Hi authors,
Following the official training command below, I observed unstable training loss and accuracies around epoch # 20.
python -m torch.distributed.launch --nproc_per_node 8 --master_port 12345  main.py \ --cfg configs/swin_base_patch4_window7_224.yaml --data-path <imagenet-path> --batch-size 64 \ --accumulation-steps 2 [--use-checkpoint]
Can you please share the training logs for Swin-B? And if more logs are available, please consider sharing them as well.
TIA!

Has anyone been able to reproduce the results of larger architectures? I contacted the authors about two weeks ago, but it seems like a dead end.

Hi @lcmeng, training logs are available here: https://github.com/microsoft/Swin-Transformer/blob/b05e6214a37d33846903585c9e83b694ef411587/README.md?plain=1#L79-L81

Thank you. But why are all the configurations intentionally removed from the log files? For example, in the previously shared log file here, one can find the configurations of the run.
As the original post of this thread mentioned, the recommended setup for Swin-B @ ImageNet 1K does not converge. Can you please share the full log to help reproduce your results? If it requires a different setup, can you please also share exactly how? Thanks.

The logs of Swin-S/B were generated by an earlier version of the code, which didn't write the configs. However, the configs are the same with the configs provided here. 16 V100 GPUs are used to train Swin-S and Swin-B.
For your case (8 GPUs with accumulation-steps=2 ), I have tried using the same command as you. It have finished 95 epochs, and it's very stable. You can refer to this log: log_rank0.txt
If you still face the problem of training instability, I suggest:

Check the version of your python packages. You can try this docker nvcr-21.05 that I have checked.
If you are using your custom dataset, maybe you can reduce the learning rate or increase the warmup epochs.
Change to O0, since most of the instability issues are caused by float16.

If none of the above suggestions work, please share me with your log so I can take a closer look.

Hi @zeliu98 , Thanks for your great work! I met a similar problem with @lcmeng .
On four V-100 GPUs, I used the default commander below. It turns out the network can converge, but the accuracy is about 1% lower than reported.
The final accuracy is 82.1% (The reported is 83.5%).
CUDA_VISIBLE_DEVICES=0,1,2,3 python -m torch.distributed.launch --nproc_per_node 4     --master_port 12345  main.py  --cfg configs/swin_base_patch4_window7_224.yaml --data-path /dataset/imagenet  --batch-size 128
The logfile of this training is here.
Could you please take a look and advice on how to reproduce the same accuracy?
Thank you very much!

Hi @he-y, the total batch size should be 1024, but yours is 512. Try this command:
CUDA_VISIBLE_DEVICES=0,1,2,3 python -m torch.distributed.launch --nproc_per_node 4 --master_port 12345 main.py --cfg configs/swin_base_patch4_window7_224.yaml --data-path /dataset/imagenet --batch-size 128  --accumulation-steps 2

Hi @zeliu98 , thank you for the detailed reply. I've listed the installed dependencies for Swin experiments. They seem to fully agree with the requirements. Can you spot any inconsistencies? TIA.
(swin) ubuntu@ip-10-0-0-94:~$ conda list
# packages in environment at /home/ubuntu/anaconda3/envs/swin:
#
# Name                    Version                   Build  Channel
_libgcc_mutex             0.1                 conda_forge    conda-forge
_openmp_mutex             4.5                       1_gnu    conda-forge
apex                      0.1                      pypi_0    pypi
blas                      1.0                         mkl
ca-certificates           2021.5.30            ha878542_0    conda-forge
certifi                   2021.5.30        py37h89c1867_0    conda-forge
cudatoolkit               10.1.243             h036e899_8    conda-forge
freetype                  2.10.4               h0708190_1    conda-forge
intel-openmp              2021.3.0          h06a4308_3350
jpeg                      9b                   h024ee3a_2
lcms2                     2.12                 h3be6417_0
ld_impl_linux-64          2.36.1               hea4e1c9_2    conda-forge
libffi                    3.3                  h58526e2_2    conda-forge
libgcc-ng                 11.1.0               hc902ee8_8    conda-forge
libgomp                   11.1.0               hc902ee8_8    conda-forge
libpng                    1.6.37               h21135ba_2    conda-forge
libstdcxx-ng              11.1.0               h56837e0_8    conda-forge
libtiff                   4.2.0                h85742a9_0
libuv                     1.42.0               h7f98852_0    conda-forge
libwebp-base              1.2.0                h7f98852_2    conda-forge
lz4-c                     1.9.3                h9c3ff4c_1    conda-forge
mkl                       2021.3.0           h06a4308_520
mkl-service               2.4.0            py37h5e8e339_0    conda-forge
mkl_fft                   1.3.0            py37h42c9631_2
mkl_random                1.2.2            py37h219a48f_0    conda-forge
ncurses                   6.2                  h58526e2_4    conda-forge
ninja                     1.10.2               h4bd325d_0    conda-forge
numpy                     1.20.3           py37hf144106_0
numpy-base                1.20.3           py37h74d4b33_0
olefile                   0.46               pyh9f0ad1d_1    conda-forge
opencv-python             <IP_ADDRESS>                 pypi_0    pypi
openjpeg                  2.4.0                hb52868f_1    conda-forge
openssl                   1.1.1k               h7f98852_0    conda-forge
pillow                    8.3.1            py37h2c7a002_0
pip                       21.2.3             pyhd8ed1ab_0    conda-forge
python                    3.7.10          hffdb5ce_100_cpython    conda-forge
python_abi                3.7                     2_cp37m    conda-forge
pytorch                   1.7.1           py3.7_cuda10.1.243_cudnn7.6.3_0    pytorch
pyyaml                    5.4.1                    pypi_0    pypi
readline                  8.1                  h46c0cb4_0    conda-forge
setuptools                49.6.0           py37h89c1867_3    conda-forge
six                       1.16.0             pyh6c4a22f_0    conda-forge
sqlite                    3.36.0               h9cd32fc_0    conda-forge
termcolor                 1.1.0                    pypi_0    pypi
timm                      0.3.2                    pypi_0    pypi
tk                        8.6.10               h21135ba_1    conda-forge
torchvision               0.8.2                py37_cu101    pytorch
typing_extensions         <IP_ADDRESS>           pyha770c72_0    conda-forge
wheel                     0.36.2             pyhd3deb0d_0    conda-forge
xz                        5.2.5                h516909a_1    conda-forge
yacs                      0.1.8                    pypi_0    pypi
zlib                      1.2.11            h516909a_1010    conda-forge
zstd                      1.4.9                ha95c52a_0    conda-forge

(swin) ubuntu@ip-10-0-0-94:~$ nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2019 NVIDIA Corporation
Built on Sun_Jul_28_19:07:16_PDT_2019
Cuda compilation tools, release 10.1, V10.1.243

(swin) ubuntu@ip-10-0-0-94:~$ cat /usr/local/cuda/include/cudnn.h | grep CUDNN_MAJOR -A 2
57:#define CUDNN_MAJOR 7
58-#define CUDNN_MINOR 6
59-#define CUDNN_PATCHLEVEL 5
--
61:#define CUDNN_VERSION (CUDNN_MAJOR * 1000 + CUDNN_MINOR * 100 + CUDNN_PATCHLEVEL)
62-
63-#include "driver_types.h"

And about the recommended Nvidia docker image nvcr-21.05, does it not conflict with the recommended dependencies? For example, it contains CUDA 11.3 (vs. the recommended 10.1) and PyTorch 1.9.0 (vs. the recommended 1.7.1). Did I miss something here?

@zeliu98 In the newly released logs for larger Swin arches, the typical amp loss scaling, i.e.  Gradient overflow.  Skipping step, loss scaler 0 reducing loss scale to xyz is not seen anywhere. Does it mean these models were training solely in FP32 w/o any amp? From your experience, does turning off amp (set to O0) help sustain a higher learning rate? Thank you and happy new year.

Hi @lcmeng, the model is trained using the default mixed-precision (O1).  We doesn't deal with the logging of amp so the loss scaling info is not wrote to the log file.
Your environment seems correct and I am not very clear about the reason about your problem. According to other users' feedback, installing apex from source may be error-prone, so I just suspect that there might be something wrong with your apex. The nvcr-21.05 docker has installed apex by itself,  so you can try it first. The version of CUDA and pytorch is ok and I have checked.
Besides, you can share me with your log so I can look into it further.

Hi @lcmeng, the model is trained using the default mixed-precision (O1).  We doesn't deal with the logging of amp so the loss scaling info is not wrote to the log file.
Your environment seems correct and I am not very clear about the reason about your problem. According to other users' feedback, installing apex from source may be error-prone, so I just suspect that there might be something wrong with your apex. The nvcr-21.05 docker has installed apex by itself,  so you can try it first. The version of CUDA and pytorch is ok and I have checked.
Besides, you can share me with your log so I can look into it further.

@zeliu98, thank you for the explanation. I've added some TensorBoard code to Swin to generate visualization of the training. It seems the drop of accuracy near the peak LR is correlated with the explosion of gradient (norm).
Please see the attached screenshots. The LR appeared to be doubled, due to accumulation step = 2. It is in fact the same as the recommended setup.
(1) The trace of gradient norm over global steps. It increased very aggressively after the initial "flat" phase.

(2) Max top-1 accuracy happened at Epoch 15.

(3) Using the recommended LR schedule

@lcmeng Hey， I'm wondering what the point it is from the grad_norm. I have seen some people use this metric with their issue about convergence of Swin. Would you please give a hint, thanks.


NTLMv2 with MAC and EPA support [to be removed]

NTLMv2 with MAC and channel binding support
I had trouble using library in my environment, but finally managed to solve it by refactoring code to follow NTLMv2 standard according to
NTLM protocol description, in particular:

added support for MIC
added missing target info (avPairs) updates
added support for CBT (channel binding tokens)
zeroed version by default

Connection against secured IIS (NTLMv2 and enabled EPA) is working in my environment, but there's a hight risk that it can break in a different environment, especially ones that do no support NTLMv2 fully.
Could anyone assess the changes and test in their environment?

@paulmey I'm trying to delete the contents of this PR - wrong author. Could you help me out with it?

@paulmey I managed to solve the authorship issues. Feel free to review PR and suggest changes.

Hi, I have used that version from @dlorych and it works well for me in adcs-issuer (for cert-manager) with NTLMv2.
Do you think it will be merged ? When ?


Inbuilt source control (Git) not working properly.

VSCode Version: Code 1.19.3 (7c4205b5c6e52a53b81c69d2b2dc8a627abaa0ba, 2018-01-25T10:36:34.867Z)
OS Version: Windows_NT x64 6.1.7601
Extensions:

Extension
Author (truncated)
Version

gitignore
cod
0.5.0

githistory
don
0.4.0

vscode-html-css
ecm
0.2.0

auto-close-tag
for
0.5.5

auto-rename-tag
for
0.0.15

terminal
for
0.0.10

html-css-class-completion
Zig
1.16.1

Steps to Reproduce:

Whenever I try to discard some changes or stage some changes I need to do it 2 times.

Reproduces without extensions: Yes

Does that happen always? Does it happen for every workspace you try it on? Can you record a screencase?


Emmet disappeared on Brackets 1.5 (Win 10)

Emmet is still installed in Extension Manager but don't appear in the menu bar.
No error in the console.
I tried to move all extensions, except Emmet, to the disabled folder, but the problem is still there.
I tried also to install/uninstall Emmet but nothing changes.
Waiting for help, thanks

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27539043-emmet-disappeared-on-brackets-1-5-win-10?utm_campaign=plugin&utm_content=tracker%2F311111&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F311111&utm_medium=issues&utm_source=github).

I have this issue in the Mac version too.

I have similar issue with html coding in windows 7, but no with css coding

+1 on Brackets 1.7 Mac :(


[5.4] Improved Higher Order Collection

This will allow you to use:
$collection->mapName->toArray();

instead of
$collection->map->name->toArray();

I like the data_get change but I don't like the other change to even more dynamic methods.

@taylorotwell Would you prefer / accept this if it were methods rather than properties?
To me, having rejectRetired makes more gramatical sense than reject->retired
Or is it just that you do not wish for so much magic to be hidden behind these methods? In which case, fair enough.


Change the main colors to match https://lingonsaft.com

I like red 🔴

Exactly what is to be done?

Right now the main colors of https://hacktoberfest.lingonsaft.com/ are blue (header menu, links?) could we change the colors to match  https://lingonsaft.com/ colors which are red

Sure thing! Happy to work on that :)

@versavale Great 👑

Will really be happy to work on the issue! :)

I would like to contribute!

Oo and also i just merged a pull request that changed layout design and also colors to black could we get this to red again? 🔙

Yup! On it :) Finished with the navbars, moving on to links. Pull request coming soon!

@versavale Great 😃

Closing this with the power of @versavale pull request 🦀


Added support for passing beanstalk tags when creating environment

Now with new tags pattern we have to support creating environments.
With this feature we can pass beanstalk tags in the build.gradle, as this:
beanstalk {
    tags = [
            Env: 'prod',
            Product: 'feeds',
            Application: 'backoffice',
            Process: 'web'
    ]
}

This works with task deployBeanstalk

👏  awesome @linyatis

looks good, nice work @linyatis 👏

@fmamud: tks, great suggestion!
Is it good now?

@linyatis perfect! Groovy Wins! 👍

Tks guys!!

@linyatis Great work! 👏


Make source code link more prominent on details page

Suggested by @gsmet.
Options to consider include moving it to higher in the sidebar, and also/instead

have it as a big button or shaded area
a text section in the main area, same as we do for docs?
maybe a button with an icon just below the Try button

@gsmet also suggests we should maybe call it something like "project site," since a GH repo is more than just source code. On the other hand, the source is an important part of what's there, and the meaning is obvious. So I can see arguments both ways.

Also (I see what you did!), it would be nice if the icon was an octicon when it's a GH repo. It makes things more obvious for users.

Also (I see what you did!), it would be nice if the icon was an octicon when it's a GH repo. It makes things more obvious for users.

I've raised that as #320 ... the icon work doesn't need hard thinking about page layout, and I'll probably do it first. :)