Passing a training flag into EncodeProcessDecode model

So far I have failed to adapt the EncodeProcessDecode module s.t. training and testing phases can be distinguished (e.g. for the purpose of deactivating the adding of noise on latent reps during test time).
This is mainly due to the fact that a "is_training" boolean flag is typically passed when encoder, core and decoder have been already initialized (but not built) and I want to have the same EncodeProcessDecode model for train/test (i.e. no two separate train/test model objects but rather two train test tf ops). Therefore my understanding is that I somehow must be able to pass this flag into EncodeProcessDecode's _built() function. However, this function calls modules.GraphIndependent and here the number of arguments passed is pre-defined (naimly inputs and num_processing_steps)
Since this seems like a common use case to me, I was wondering how folks at DeepMind deal with this. Of course I could change the sonnet interface of GraphIndependent but that does not seem like a scalable solution to me. I could also not find a particular example for this in the documentation. Could you perhaps provide a minimum working example for this use case or provide some ideas how to do this?
Thank you!

Example:

def _build(self, input_op, num_processing_steps, is_training):
    latent = self._encoder(input_op, is_training)

--> fails with TypeError: _build() takes 2 positional arguments but 3 were given.
While _encoder is:

self._encoder = MLPGraphIndependent()

and MLPGraphIndependent is taken from the example and inherits snt.AbstractModule

Hi Fabio,
thanks for your interest in your library. Unfortunately the matter is a bit
complicated by the fact that the GraphNetwork (or GraphIndependent)
_build's method will be calling _build for different sonnet modules,
that will in principle accept or not different arguments. This is a similar
design decision as the one taken in snt.Sequential (see its docstring).
If you only care about the GraphIndependent case, one workaround would be
to bypass it and update the edges and nodes explicitely:
outputs_test = inputs.replace(
    nodes=your_node_module(inputs.nodes, False),
    edges=your_edge_module(inputs.edges, False)
)
outputs_train = inputs.replace(
    nodes=your_node_module(inputs.nodes, True),
    edges=your_edge_module(inputs.edges, True)
)

Matters are admittedly more complicated for the GraphNetwork -- and we
are still thinking about what the best way to support this would be.
Finally, let me mention that a slightly more complicated method would be to
construct your module outside of the GraphNet and wrap it's build method,
something like:
with tf.variable_scope("graph_modules"):
your_edge_module = ..  # Define your module here
your_node_module = ..
your_global_module = ..
outputs_train = modules.GraphNetwork(
edge_model_fn=lambda: lambda x: your_edge_module(x, is_training=True),
node_model_fn=lambda: lambda x: your_node_module(x, is_training=True),
global_model_fn=lambda: lambda x: your_node_module(x, is_training=True)
)(inputs)
outputs_test = modules.GraphNetwork(
edge_model_fn=lambda: lambda x: your_edge_module(x, is_training=False),
node_model_fn=lambda: lambda x: your_node_module(x, is_training=False),
global_model_fn=lambda: lambda x: your_node_module(x, is_training=False)
)(inputs)
Best,
Victor
Le jeu. 7 mars 2019 à 01:56, Fábio Ferreira<EMAIL_ADDRESS>a
écrit :

Example:
def _build(self, input_op, num_processing_steps, is_training):
latent = self._encoder(input_op, is_training)
--> fails with TypeError: _build() takes 2 positional arguments but 3
were given.
While _encoder is:
self._encoder = MLPGraphIndependent()
and MLPGraphIndependent is taken from the example and inherits
snt.AbstractModule
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/deepmind/graph_nets/issues/51#issuecomment-470351701,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGPTThkuWyVHJShXCbhIrjLr_j0rcOshks5vUHGzgaJpZM4biKRG
.

Thank you for coming back to me. Unfortunately, I do care about both, GraphIndependent and GraphNetwork.
Would something like this work? I construct operations for a train and test graph as follows:
# train
self.model.is_training = True
self.model.output_ops_train = self.model(self.model.input_ph, self.config.n_rollouts, self.model.is_training, self.sess)

# test
self.model.is_training = False
self.model.output_ops_test = self.model(self.model.input_ph_test, self.config.n_rollouts, self.model.is_training, self.sess)

And replace the in the _build() functions of the models requiring the is_training flag as follows:
def _build(self, inputs, is_training, sess):
        out = self._network(inputs)

        # modify -is_training- flags accordingly
        with sess.as_default():
            for v in self._network.get_all_variables(collection=tf.GraphKeys.GLOBAL_VARIABLES):
                if "is_training" in v.name:
                    assign_op = v.assign(is_training)
                    sess.run(assign_op)
                    assert v.eval() == is_training

            # check if it is necessary to call _network(inputs) again
            variables = out[0].graph.get_collection("variables")
            for v in variables:
                if "is_training" in v.name:
                    assert v.eval() == is_training

        return out

As long as I maintain two different operation sets / GraphTuples lists (self.model.output_ops_test and self.model.output_ops_train) I think this should work. What do you think=

Hi Fabio,
I think the second solution I describe is exactly what you want and it should work with both GraphNetwork and a GraphIndependent ?

thank you, your solution works perfectly!

outputs_test = inputs.replace(
    nodes=your_node_module(inputs.nodes, False),
    edges=your_edge_module(inputs.edges, False)
)
outputs_train = inputs.replace(
    nodes=your_node_module(inputs.nodes, True),
    edges=your_edge_module(inputs.edges, True)
)

--> just to be clear, is this done in the _build() or init() call?

It is further unclear to me, how I should call the place function, wenn the node module itself initiates a class like this:
def __init__(self, model_id, is_training, name="a):
    with self._enter_variable_scope():
            visual_encoder = get_model_from_config(self.model_id, model_type="visual_encoder")(is_training=self.is_training, name="visual_encoder")
            self._network = modules.GraphIndependent(
                ...
                nodes=lambda: get_model_from_config(self.model_id, model_type="visual_and_latent_encoder")(visual_encoder, name="visual_and_latent_node_encoder")
                ...
             )

How do I pass the flag in a replace statement in this case?

@vbapst can you comment on this?

If you go down the first option, then wherever you build your network (probably in your main training loop, or maybe in the __init__ of you module), then you would construct outputs_test and outputs_train as described. You need to enter a variable scope only in the later case. Note that in this case you don't call modules.GraphIndependent, but directly call replace on the nodes, edges and globals of your graph.
I am not sure to understand what you last comment is trying to achieve as we don't usually pass the is_training flag at build time, but at init time. So it would look more like that:
def __init__(self):
  with tf.variable_scope("graph_modules"):
    self._edge_module = ..  # Define your module here. Their `_build` method should take an extra is_training argument
    self._node_module = ..
    self._global_module = ..

def _build(self, is_training)
  return modules.GraphNetwork(
  edge_model_fn=lambda: lambda x: self._edge_module(x, is_training=is_training),
  node_model_fn=lambda: lambda x: self._node_module(x, is_training=is_training),
  global_model_fn=lambda: lambda x: self._global_module(x, is_training=is_training)
)(inputs)

Hi @vbapst and thank you. Unfortunately there are still a few things unclear to me. Do you mind a personal correspondence via email?

Thank you for your reply @vbapst. I meant the modules.GraphIndependent. For passing the is_training flag I now simply used the _build() functions of my models and omitted the _init() function like so:
    def __init__(self, name="Encoder"):
        super(Encoder, self).__init__(name=name)

    def _build(self, inputs, is_training, verbose=VERBOSITY):

        self._network = modules.GraphIndependent(
            edge_model_fn=lambda: ...
            node_model_fn=lambda: ...
            global_model_fn=lambda: ...
            )
        return self._network(inputs)

My sanity check shows that the flags are set correctly. Does this also work in your opinion or can this have negative (that I currently do not foresee) consequences?

This looks good -- just check the variables are correctly shared

Thanks. Is there a way to check this within the GN framework?

@vbapst

thanks! works!


Add the Hi-Speed devices cheat sheet

http://wiremod.com/forum/showthread.php?t=9315

@its-suun if you can find it in the archives and make a pull request, I'll add it.

It was here, but that was long time ago..

There is still a cheat sheet online here and here.

Added by 03825ec4ced3b5c82bd33fc1a988a526ec9f49ae


[BUG] Could not convert string to double

Please check this, happening from today:

Hi @sfksuperman, and thanks for rising this issue.
I see the api is returning unexpected result (latitude & longitude) for your case 😕
"meta":{
   "latitude":"*******",
   "longitude":"*******",
   "timezone":"Asia/Qatar",
   "method":{
      "id":10,
      "name":"Qatar",
      "params":{
         "Fajr":18,
         "Isha":"90 min"
      },
      "location":{
         "latitude":25.2854473,
         "longitude":51.5310398
      }
   },
   "latitudeAdjustmentMethod":"ANGLE_BASED",
   "midnightMode":"STANDARD",
   "school":"STANDARD",
   "offset":{
      "Imsak":0,
      "Fajr":0,
      "Sunrise":0,
      "Dhuhr":0,
      "Asr":0,
      "Maghrib":0,
      "Sunset":0,
      "Isha":0,
      "Midnight":0
   }
}

However, I couldn't reproduce the issue using the widget, which is an odd thing.
As a workaround, you may need to either:

Switch to the other service (you will have to set latitude/longitude in settings since it doesn't support your zip code), or
Try to use a different calculation method

Hi @sfksuperman, and thanks for rising this issue.
I see the api is returning unexpected result (latitude & longitude) for your case 😕
"meta":{
   "latitude":"*******",
   "longitude":"*******",
   "timezone":"Asia/Qatar",
   "method":{
      "id":10,
      "name":"Qatar",
      "params":{
         "Fajr":18,
         "Isha":"90 min"
      },
      "location":{
         "latitude":25.2854473,
         "longitude":51.5310398
      }
   },
   "latitudeAdjustmentMethod":"ANGLE_BASED",
   "midnightMode":"STANDARD",
   "school":"STANDARD",
   "offset":{
      "Imsak":0,
      "Fajr":0,
      "Sunrise":0,
      "Dhuhr":0,
      "Asr":0,
      "Maghrib":0,
      "Sunset":0,
      "Isha":0,
      "Midnight":0
   }
}

However, I couldn't reproduce the issue using the widget, which is an odd thing. As a workaround, you may need to either:

Switch to the other service (you will have to set latitude/longitude in settings since it doesn't support your zip code), or
Try to use a different calculation method

But it works well on my other pc, lol.

But it works well on my other pc, lol.

And on my PC too 🙂
Something is wrong with the API service for sure.
But still need to handle such situations since it can happen from time to time.
Thanks again


Fix e2e tests to search the kubeconfig consistently

Description of changes
The reading code was making assumptions about what the writing code did. This worked when the workload clusters were setup in a very specific way, but if custom folders were used, the assumptions were broken and the test can't find the kubeconfig file.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


modified color scheme and logo to match LabGrid

What do you think about this?
I updated the favicon. And I'm attaching screenshots here so you can see that I tried to change the color scheme to match the LabGrid color scheme. Non-default colors are fun, however I did this in a janky way by adding !important tags to the css. There are no hover-shadows on the buttons anymore. There is definitely a cleaner way to do this, so I'd be ok with tabling this if you don't like it!

This is the full color scheme in case you are ever looking for exciting highlight colors:

I used Themestr.app to create custom-theme.scss
I replaced the index.css import in index.tsx with importing this custom-theme.scss
I installed node-sass.
Selecting a screenshot that shows a large number of colors together.


Stereo/multichannel oscillator

Once we have rendered a multichannel set of waves (see #8 and #95), it would be nice to be able to play them in some sensible way.
We can always use one wtosc for each channel, and be done with it - and that, of course, gives us a lot of control, including stereo flanger effects and the like.
However, most of the time, we just want to play them back as rendered. It would also be nice to have some standard way of selecting a bundle of waves as one object, if we implement that. (See #95.) And of course, there are cycles to be saved here, as we can share some logic, interpolation calculations etc across channels.

Been thinking about whether or not there is a case for making stereo a "core" feature, or just an abstraction on one or more levels.

We can probably assume that two channel stereo is such a commonly used format that it should be handled in a transparent and smooth manner, if not even being the default format, so it definitely needs explicit support.

Maybe eventually this will extend to multichannel surround formats as well, but I don't think we're there yet, even when dealing with game audio meant to support surround output.

An actual interleaved stereo audio format is pretty much only a performance hack, and comes at the cost of essentially doubling the size and/or complexity of any code that needs to touch it. With inlines and macro magic, that doesn't necessarily have much impact on the source code, but it may harm performance in cases where both mono and stereo paths are used concurrently.

For both waveforms and buffers, interleaved stereo provides an advantage in cache coherency.  This is probably more important for large waveforms that are essentially always streamed from cold RAM, but in "consumer" scenarios (>10 ms latency), it's quite likely that every audio callback starts with an entirely cold engine, in which case it might be an advantage if also internal buffers are interleaved stereo.


Spreadsheet Step 19, doesn't allow space between = and ( when parenthesis is used around the parameter

Describe the Issue
The solution requires that parenthesis do not surround the parameter for the sum function. This is a bit inconsistent since previous projects and steps have either required the parenthesis or has accepted both.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures-v8/learn-functional-programming-by-building-a-spreadsheet/step-19
Your code
// Unaccepted answer
const sum = (nums) => nums.reduce((acc, el) => acc + el, 0);

// Accepted answer
const sum = nums => nums.reduce((acc, el) => acc + el, 0);

Expected behavior
Both code answers should be correct.
Screenshots
No response
System

Device: [Laptop]
OS: [ Windows 11]
Browser: [Edge]
Version: [120.0.2210.91]

Additional context
No response

Issue is actually with space, that's missing from regex, as this passes:
const sum =(nums) => nums.reduce((acc, el) => acc + el, 0);

https://github.com/freeCodeCamp/freeCodeCamp/blob/4a6b86a614a2fdda1191e1e1155094de18b44fcc/curriculum/challenges/english/15-javascript-algorithms-and-data-structures-22/learn-functional-programming-by-building-a-spreadsheet/643498755d54c6279ba09078.md?plain=1#L52-L55


Error: Object doesn't support property or method 'remove' (Element.prototype.remove())

When Line 169 in VPAIDHTML5Client.js called in <= IE 11 (and other older browsers which do not support it), throws the following error:
Object doesn't support property or method 'remove'
The ChildNode.remove() MDN specification, lists browsers which do not support the ChildNode.remove() method and provides a polyfill for adding support.
I was unable to get tests passing locally before any changes were made. So I will defer to the maintainers to ensure all tests are passing and to bump the package version.
Here is the patch:
https://gist.github.com/diggabyte/a99b06c455475b57719554b1385be4be

I got same error. Error occurred when calling remove() on IE11. The code:
function $removeEl(key) {
    var el = this[key];
    if (el) {
        el.remove();
        delete this[key];
    }
}

@diggabyte :+1: thanks.


API doc links in example notebooks still point to README

Most of d3's package READMEs have been updated to point to https://d3js.org/ for the package's documentation. However, many example notebooks still include links that point to a package's README.
Example:

Notebook: https://observablehq.com/@d3/d3-scaleordinal
API link: https://github.com/d3/d3-scale/blob/master/README.md#ordinal_domain
Actual location: https://d3js.org/d3-scale/ordinal#ordinal_domain

It may take a while since there are lots of notebooks to fix
https://observablehq.com/search?query="https%3A%2F%2Fgithub.com%2Fd3%2F"+%40d3&creator=fil&sort=relevance&direction=desc&useES=true&accessPublic=true
2 done, 94 to go :)

I think I'm done, but it's hard to search for that pattern and I might have missed some.

I've found 91 more notebooks that need changes!

Note: some notebooks are still pointing to github because they reference d3-tile, d3-hexbin, d3-geo-projection etc. + specific cases like linking to a source code file or locale json.


Performance improvements

I think I lost my notes from you, @ajnsit on what the possible avenues for performance improvement might be. I thought it might be helpful to have an issue for this. I'm wrapping up my current, major Concur project and can potentially take a look at this on the coming week or so. (Originally discussed in #2)

(I seem to recall there was discussion regarding Aff usage, but don't recall the details.)

(I seem to recall there was discussion regarding Aff usage, but don't recall the details.)

If I may chime in here. This may or may not be relevant to your question @bbarker, but I experimented with swapping out arrays in orr for Data.Sequence. I got quite a performance lift for larger DOM trees.

If I may chime in here. This may or may not be relevant to your question @bbarker, but I experimented with swapping out arrays in orr for Data.Sequence. I got quite a performance lift for larger DOM trees.

Hi @ajbarber , That sounds very promising. Do you have a branch with these changes in it where I could take a look?  Thanks!

Hi @ajbarber , That sounds very promising. Do you have a branch with these changes in it where I could take a look?  Thanks!

I just had a debugging session with Nate Faubion related to this, and we collected some interesting information. I'll try to summarize the discussion in the next 24 hours, but I'm out of time just now, so I'll leave the discussion link here for now: https://functionalprogramming.slack.com/archives/C04NA444H/p1611954274213100

I just had a debugging session with Nate Faubion related to this, and we collected some interesting information. I'll try to summarize the discussion in the next 24 hours, but I'm out of time just now, so I'll leave the discussion link here for now: https://functionalprogramming.slack.com/archives/C04NA444H/p1611954274213100

After discussing with Nate Faubion about various debounce approaches,
he didn't seem to think debounce was likely to help,
and I have to agree since we're alredy using debounce, which sems to work fine in our
smaller tests. He hypothesized that it might be related to the fact that I'm
storing state in a single global object, and in a sense, I am doing that, though
in a functional way.
At any rate, I tested the hypothesis by adding  an invocation of the same textInput Signal
to the top of the page, and having its data completely isolated from any other
state in the app. In this case, I could see the same performance degredation when typing
into this isolated widget as when I type in the other widgets that are linked into the
data model. To be clear, the performance degradation occurs when more widgets are added to the DOM;
when relatively few widgets are there, everything is fine.
Given:

(The above)
"the entire network of reactive nodes for the entire application is resolved on every input" according to the flame graph.
The root of the flamegraph has Concur discharge* calls whenever input is being handled.

, it seems  a couple of possibilities are likely:

Discharge itself needs to be reworked
Debounce is only partly working. The rendering is somehow not being debounced even though data propagation is being debounced (which seems to line up with the evidence - it just happens that the only rendering changes occur when the data itself changes)

The link to the particular branch wih the added, isolated widgets at the topc is here
A live version in production mode (without the added, isolated widgets) is on
GitHub Pages.
Flamegraph snip:

Performance summary (idle time occurs before input):

After discussing with Nate Faubion about various debounce approaches,
he didn't seem to think debounce was likely to help,
and I have to agree since we're alredy using debounce, which sems to work fine in our
smaller tests. He hypothesized that it might be related to the fact that I'm
storing state in a single global object, and in a sense, I am doing that, though
in a functional way.
At any rate, I tested the hypothesis by adding  an invocation of the same textInput Signal
to the top of the page, and having its data completely isolated from any other
state in the app. In this case, I could see the same performance degredation when typing
into this isolated widget as when I type in the other widgets that are linked into the
data model. To be clear, the performance degradation occurs when more widgets are added to the DOM;
when relatively few widgets are there, everything is fine.
Given:

(The above)
"the entire network of reactive nodes for the entire application is resolved on every input" according to the flame graph.
The root of the flamegraph has Concur discharge* calls whenever input is being handled.

, it seems  a couple of possibilities are likely:

Discharge itself needs to be reworked
Debounce is only partly working. The rendering is somehow not being debounced even though data propagation is being debounced (which seems to line up with the evidence - it just happens that the only rendering changes occur when the data itself changes)

The link to the particular branch wih the added, isolated widgets at the topc is here
A live version in production mode (without the added, isolated widgets) is on
GitHub Pages.
Flamegraph snip:

Performance summary (idle time occurs before input):

Nate Faubion pointed out:

it looks like discharge is called on every reactive event regardless? To me this would imply that it must step the entire reactive graph on every event (hence the large call graph of discharges above).

Additionally @ajbarber pointed out:

every time an event is fired handler in React.purs L32 is going to be triggered. This block is basically calling setState in React.  So following on from this, looking at the debounce code, it does not do anything to stop these input key press events being handled, then the resulting view is passed off to React setState. Ideally if you were truly debouncing, you really want to do no or very little work in your handler until the debounce time has elapsed

If my understanding is correct, first we need to fix the issue pointed out by Nate before revisiting debounce?

Nate Faubion pointed out:

it looks like discharge is called on every reactive event regardless? To me this would imply that it must step the entire reactive graph on every event (hence the large call graph of discharges above).

Additionally @ajbarber pointed out:

every time an event is fired handler in React.purs L32 is going to be triggered. This block is basically calling setState in React.  So following on from this, looking at the debounce code, it does not do anything to stop these input key press events being handled, then the resulting view is passed off to React setState. Ideally if you were truly debouncing, you really want to do no or very little work in your handler until the debounce time has elapsed

If my understanding is correct, first we need to fix the issue pointed out by Nate before revisiting debounce?

After investigation discharge , being triggered on events is not a big concern.
There is no Concur issue I could identify here.
The main driver of performance degradation appears to be some heavy weight synchronous processing of input events in the metajelo ui application. More details of my investigation [ here ] (https://functionalprogramming.slack.com/archives/C04NA444H/p1612072993287000?thread_ts=1611954274.213100&cid=C04NA444H
)

After investigation discharge , being triggered on events is not a big concern.
There is no Concur issue I could identify here.
The main driver of performance degradation appears to be some heavy weight synchronous processing of input events in the metajelo ui application. More details of my investigation [ here ] (https://functionalprogramming.slack.com/archives/C04NA444H/p1612072993287000?thread_ts=1611954274.213100&cid=C04NA444H
)

I also wonder if a more pervasive solution can be devised (not just for specific widgets, and not just for debounced widgets). In other words, is there a way for Concur to track which widgets need to have writeState called.
Perhaps doing this for every widget would be overkill, and negate some of the benefits of the VDOM. This may also be an implementation detail that isn't Central to Concur. For instance, in precise DOM-binding frameworks, I don't think this would be an issue.

In other words, is there a way for Concur to track which widgets need to have writeState called.

I've come to the same conclusion. Right now in Concur, binding the return value of a widget, say a SyntheticEvent_, will cause a full tree rerender. The mechanism for getting the event out of the widget i.e
click <- myWidget

is done using discharge, and is very tightly bound up with the re-render. In trying to rewrite debounce,  I tried to various ways to untether the two by setting the continuation to never for example, but it all felt hacky. Rather, I think we need something like a special purpose flag on a WidgetStepView  indicating whether to flush out to React.writeState.
There are plenty of scenarios where you want to fish out the event for inspection, but you don't want the render. Think about a, slightly contrived example of a slider control where you want to observe all the events, but only trigger an update of the app on the final setting.   So it's not only debounce where you could use this render Boolean.  With some sort of flag kept on the view, we could run some widgets "silently" inside a signal, and only emit a render change when we wish to.
It's also quite a straightforward change to core, with the following qualification.  purescript-concur-react which consumes the result of discharge would need a checkblock for the conditional render.  Plus I'm presuming there are other projects downstream of purescript-concur-core to consider.

are there are other projects downstream of purescript-concur-core to consider?
@ajbarber The one that I'm aware of is purescript-concur-vdom .

I have a branch out with some changes that allow us to recurse on widgets silently, without rendering until we need to.  @bbarker would you be able to assist with a test of these changes with your application? The changes are backwards compatible.
https://github.com/ajbarber/purescript-concur-core/tree/debounce-performance
There is however also a small change required to purescript-concur-react to allow us to discharge widgets without rendering:
https://github.com/ajbarber/purescript-concur-react/tree/debounce-performance
So to test you will need something like this in your concur-react dev environment's packages.dhall
+let overrides = {
+    concur-react = ./spago.dhall as Location,
+    concur-core = ../purescript-concur-core/spago.dhall as Location

I left some debug logging in the console, for now, so you can see when we are rendering :smiley:

@ajbarber Cool! Thanks for doing this. I can see that the renders are being delayed, but to be honest, I can't really tell if the performance has improved. It feels about the same, maybe slightly better in some cases but I can't say for sure.
I need to drill down a bit more, but I have to go out for now. Just wanted to paste this call tree where most of the work is happening:

I also put a debug build up temporarily at http://<IP_ADDRESS>:8080/ (with a test xml file available at https://labordynamicsinstitute.github.io/metajelo-web/ as usual to populate the page more quickly).

@bbarker thanks for your assistance, I just checked the debug build deployed at  http://<IP_ADDRESS>:8080/  and it is not running my branch.
The way to ensure you are running my branches is to check for browser console logging on debounced input forms.
So you would need to clone those branches above to your dev environment, then follow the instructions on the spago readme around overriding with a local branch.  You will know when you have it configured correctly because you will be able to see some very verbose logging showing up in the browser console.

Ah yes, I saw it locally but forgot to check out the branch on that server 🤦♂ . I confirmed it is up now.

Thanks! It's an improvement, but not the knockout I was hoping for. Any chance of keeping that debug build up for a period of time.  It is spending all it's time in that paraff block in mkNodeWidget. This block just receives the event from React and puts it in an AVar for the continuation to pick up. I.e very costly for just shunting an event around...

Sure, I'll leave it up - just let me know if it goes down and I don't notice.

Actually can I build a debug version of this myself without too much hassle? It would be nice to have...

Yes, I made a branch which you can branch off of called debounce-performance. npm run debug should make the build happen, which will appear under dist.

Almost got there, what to do here?
⠧ Building bytesToUuid.js...Browserslist: caniuse-lite is outdated. Please run next command npm update
🚨  /home/adam/metajelo-ui/prod/index.css:1:1: Cannot resolve dependency './css/style.css' at '/home/adam/metajelo-ui/prod/css/style.css'

1 | @import './css/style.css';
| ^
2 |
3 |
npm ERR! code ELIFECYCLE

Oh right, you need to run npm run getcss (only once should suffice).

Hi @ajbarber
Just wanted to follow up to see if you had any further thoughts on this - I may try to do a Scala.js port of Concur as it looks like I may have some Scala work coming up. Do you think React is a good backend, or do you think a precise DOM binding approach might be better for Concur (or something else)?

Hi Brandon
I wanted to investigate any possible degradation caused by Aff, so I ripped
it out and implemented the continuations using plain callbacks in Effect.
The result of this was there was no real difference in performance.
So in my mind that leaves the orring as the main bottleneck.  The orr
code has to go through and unwrap the free monad, and squash every view
into one, every time the application steps. And the application steps every
time you write <-, for example, to get the input value out of an input
widget in your case. The problem is as the application grows this orring
becomes too much heavy lifting, for events in rapid succession. I don't
know whether it is the resuming of the free monad, or the array traversal
and folding. I suspect the Free monad. In fact I don't really understand
why it is required. Leaving this aside, the debounce code in FRP.purs
doesn't stop the application stepping for every input. Writing a debounce
function that actually pauses the stepping probably requires the original
event handler, this is currently buried inside the free monad. I feel any
implementation exposing the handler though kind of breaks Concur's way of
doing things. I'm still mulling over possibly better ways to do this.
On the other hand, a divide and conquer strategy is another option.
Currently now the whole concur app runs as one massive react component. As
the component grows it is unsustainable. In the migration to
purescript-react-basic, we could introduce the idea of React components in
Concur. I think this may be along the lines of your point around precise
DOM binding. Still probably need a working debounce function though.
2021/3/14 22:57於 "Brandon Elam Barker" @.***>寫道：

Hi @ajbarber https://github.com/ajbarber
Just wanted to follow up to see if you had any further thoughts on this -
I may try to do a Scala.js port of Concur as it looks like I may have some
Scala work coming up. Do you think React is a good backend, or do you think
a precise DOM binding approach might be better for Concur (or something
else)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/purescript-concur/purescript-concur-core/issues/15#issuecomment-798921935,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE4LZU24WRBAIK53F5M66PLTDTFFVANCNFSM4WJPA6SA
.

Thanks @ajbarber - yes, on the Scala side I was thinking of using ZIO (if necessary, but maybe it isn't): here's some relevant discussion comparing it to a Free monad: https://gitter.im/ZIO/Core?at=5cf2922097cf235d91dfc059. It sounds like exploring an implementation of Concur without Free may be useful, and I vaguely recall this may be something @ajnsit mentioned as a possibility (though I could be wrong).

So I tried ripping out the Free monad. I think I had to do that to understand why it is used. Without Free, you simply cannot write a bind instance on an ADT comprising both an Effect and an Aff, i.e. WidgetStep. Without Free, you need to make a choice about whether to work in Effect or Aff.
If we use Effect, and just completely rip out Aff, we miss out on all of the ergonomic features of Aff. E.g. the parallel racing and killing of effects in Aff makes input events in concur very responsive.
purescript-react is integrated using Effect, e.g hooking componentClassWithMount in React.purs in concur-react holds us in Effect. So modelling WidgetStep only using Aff looks unergonomic or maybe just not possible.
I think at this point I would like to hear from @ajnsit. In particular along the lines of what PRs would be accepted, and what direction to head in, as at the moment I am seeing a lot of roadblocks!
Thanks.

Sorry I have been ignoring this issue because I had very little time and there was a lot of information here to catch up! 😀
I have a little bit more time now, I will get back with some comments today.

I think removing Aff is a good idea. It's a big ball of JS which has always made it difficult to debug issues. We can replace it with something simpler and potentially more performant. I had a POC working using callbacks sometime back and I'll need to dig it up. The same POC also used callbacks to get rid of free monads as well.
About performance with React/vdom diffing, my experimental branch which used purescript-halogen-vdom as a backend was very snappy and worked really well. It's time I dust up that branch and make that an official backend.
For the react backend itself, some performance and stability might be gained by moving to purescript-react-basic bindings.

I would be happy to accept PRs (even radical ones) which make it ergonomic to have multiple react components in a single Concur widget. Especially if they allow seamless conversion between concur widgets and react components.
Note that you don't need multiple react components to get good performance. For example, halogen-vdom already provides memoisation of sub-components. So with that if the state of a subcomponent hasn't changed, dom diffing will not take place for that component. Of course this is not currently present in the react backend.

Regarding further direction of the project - the largest areas of focus right now are performance and component local state for the react and vdom backends. Any help with those will be very welcome!

@ajnsit If you do dig up that POC, would it be possible to share it? I'm (possibly) going to try implementing Concur in ZIO/Scala.js, and it sounds like that may be helpful to refer to.

@ajnsit If you do dig up that POC, would it be possible to share it? I'm (possibly) going to try implementing Concur in ZIO/Scala.js, and it sounds like that may be helpful to refer to.

A Scala port sounds awesome! Will definitely upload the POC code in a repo once I find it.

@bbarker @ajbarber I checked in a POC here - https://github.com/ajnsit/purescript-concur-streaming-poc. This is not the original POC, but I wrote one from scratch today and is really bare bones. I have only implemented the simplest of console views and there is no vdom. However I hope this helps show that aff and free are not essential to concur.

@ajbarber That's amazing, I will give it a try soon.

Thanks again @ajbarber, this seems like a huge improvement. I tried this out a couple of weeks ago but have had very little time to look into this until now. Unfortunately, that little time didn't help much. The best I can figure is that once the debounce timer fires, it initiates a lot of computation as the state changes propagate down the tree, updating nested records. I'm using purescript-option for record updates (I guess I should say option updates). Aside from any direct computation from these updates, I suppose it may also result in a large part of the vDOM being recalculated.
I wish I had more insight, but in any case, I heartily endorse proceeding with this approach!

Thanks for your feedback. Actually I just noticed something yesterday in my
orr code which is horribly inefficient. I will fix and report back here
soon.
2021/5/29 19:58於 "Brandon Elam Barker" @.***>寫道：

Thanks again @ajbarber https://github.com/ajbarber, this seems like a
huge improvement. I tried this out a couple of weeks ago but have had very
little time to look into this until now. Unfortunately, that little time
didn't help much. The best I can figure is that once the debounce timer
fires, it initiates a lot of computation as the state changes propagate
down the tree, updating nested records. I'm using purescript-option
https://pursuit.purescript.org/packages/purescript-option for record
updates (I guess I should say option updates). Aside from any direct
computation from these updates, I suppose it may also result in a large
part of the vDOM being recalculated.
I wish I had more insight, but in any case, I heartily endorse proceeding
with this approach!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/purescript-concur/purescript-concur-core/issues/15#issuecomment-850820944,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE4LZU5X3ZUAZTW5VDACRWLTQDJGXANCNFSM4WJPA6SA
.

@bbarker I am pleased to say I think we finally have a breakthrough on this one. I fixed the issue with the orr function as mentioned above tonight on my branch https://github.com/ajbarber/purescript-concur-core/tree/integrate-streaming-poc.  Recompiling and running in the metajelo-ui app yields a big boost in performance. I did many 'Add Items' to generate more forms and stress test it a bit, but I could not see any performance degradation that would bother me.
Could you please integrate the above branch, and retest when available and let me know if this solves your problem? Please let me know if I've missed anything in terms of your performance concerns too.

Just adding to this.  integrate-streaming-poc the branch that integrates @ajnsit 's callback poc, has a very noticeable boost in performance over master.  This branch preserves the full existing Concur API* by the way. So you can still liftAff for example, among other things.
In order to demonstrate the performance boost, I've created a simple application, which in essence models @bbarker 's problem, without all the, rather voluminous, peripheral code in the metajelo app.  You can clone this repo to run it. There are some instructions in the README on how to do the comparison. Performance is measured using your browser tools, not anything clever in the app.
I was so spurred on by the jump in performance of 'callbacks Concur', that I also created an equivalent vanilla React JS app to the above mentioned Concur test application. It does the exact same thing, but in React JS. Using the console performance tools in Firefox, I couldn't see a lot of different between the frame rates when comparing "callbacks Concur" to the React JS version of the simple application! Maybe React JS had a slight edge. I hope you are as encouraged as I am.
@ajnsit, would you be open to a PR with this branch as the basis? As mentioned this branch preserves the Concur API, I suppose there would be some tidying up, and reshuffling. I'm happy to take any pointers or direction on it.
*The Wire example in concur-react appears to not be working. All other examples look good.

Excellent stuff @ajbarber!  I will be happy to take a PR once I have tried it out myself.

In case this tripped anyone up, I just fixed a bug in the examples compiling, removed the forever from the Hello.purs example just for now, until MonadRec is implemented.

I re-implented my toy debounce function to to operate on events, instead of taking Widget as an argument. So to debounce say P.onChange we simply wrap the prop in our widget like so debounce 400 P.onChange. So a real life example I just played with in the metajelo-ui app looks like this:
textInputWidget :: String -> Widget HTML String
textInputWidget txt =
  D.input [P.defaultValue txt,
           P.unsafeTargetValue <$> (debounce 400 $ P.persist P.onChange)]

I'll get to the P.persist in a minute.  Why is this a nice API in my opinion? Something like concur-formless gets debouncing for free!  At a glance at the code of concur-formless debouncing is yet to be implemented.  I would really like to see this library get some more use.
The P.persist just stops the React event recycling since we are holding on to the events in our debounce ref, their container object gets recycled before we dereference them.
Anyway, I added a debounce wrapper to FocusCount.purs in the examples in concur-react to show it works.

Visual demonstration of performance lift.
For any interested readers, I took some gifs of the performance lift between master and integrate-streaming-poc.
concur/concur-react master
Below you can see my rapid keystrokes rendering in chunks in the input boxes.

concur/concur-react integrate-streaming-poc

Both samples generated by hitting Supplementary products -> Add Item, 12 times in the metajelo-ui app, then inputting random text into the last generated form.  This is an large number of forms to have on the page at once, and maybe a little unusual in a web app, especially given that onChange is hooked rather than onBlur, but serves as a good stress test to see the boost in performance we are getting.

@ajbarber I started looking at this, it seems to work fine, but I had a quick question about the code - What is the Partial constructor doing in the Result datatype` and why was it needed?

Thanks @ajnsit. Partial is probably a misnomer, but refers to any asynchronous event. The reason for the differentiation between Partial and Completed was that synchronous events like that in liftEffect, which complete immediately, were giving runtime errors in MonadFix, used in bind. My understanding is MonadFix requires a truly asynchronous computation, or these runtime errors are thrown. So React DOM events work fine, but synchronous computations blew up Monadfix. The case block in bind is where I try and get around this.

We have a Concur project in production and are experiencing this performance issue. For us (cautiously) these branches are like a drop-in replacement, they JustWork™ and fix this problem completely.
Is there anything we can do to help move this along, any concerns blocking this? If it helps, I can relay our experience of putting this into production with a non-trivial application; let me know if that would be of interest.

@ajbarber @bbarker I have to apologise for sitting on this for so long. The only reason I did not merge this at the time was that it is a lot of code that I don't fully understand the implications of. And then the pandemic had taken a mental toll and somewhere around this time I cut down on my foss work to recover from the fatigue. The effect of all this was that this PR got buried in my todo list.
@liammcdermott the fact that you have been using this in production without issues helps a lot! Thanks for reviving the thread.
I'll be actively looking at this and will try to merge this in soon (time boxing it to at most end of Feb).

Thanks for looking at this again @ajnsit and thanks for the great library! I should clarify: we're not using this in production yet, but we are testing it and haven't found any problems (so far). Either myself or one of my co-workers will post details if we do find anything.
This looks very promising!

@ajnsit No problem, likewise, thanks for Concur, it has been a great choice for our organisation. I've been running concur master in prod with a non-trivial web app, with Signals, and have never had any performance issues. I think @bbarker's web app is quite unconventional in the sheer amount of interactive forms on the page at once. It is a good stress test, and I suppose we should always strive to speed things up if possible. The only other thing to consider would be whether Free has had any significant performance enhancements in the meantime.
Just out of curiousity, @liammcdermott are you able to share any details on how/where you are experiencing bottlenecks?

No worries - I'll echo Adam's comments and just say that I am not much of a
front-end developer. Had I more experience, I'd probably have gone a
different route!
On Wed, Feb 23, 2022 at 4:05 AM Adam Barber @.***>
wrote:

@ajnsit https://github.com/ajnsit No problem, likewise, thanks for
Concur, it has been a great choice for our organisation. I've been running
concur master in prod with a non-trivial web app, with Signals, and have
never had any performance issues. I think @bbarker
https://github.com/bbarker's web app is quite unconventional in the
sheer amount of interactive forms on the page at once. It is a good stress
test, and I suppose we should always strive to speed things up if possible.
The only other thing to consider would be whether Free has had any
significant performance enhancements in the meantime.
Just out of curiousity, @liammcdermott https://github.com/liammcdermott
are you able to share any details on how/where you are experiencing
bottlenecks?
—
Reply to this email directly, view it on GitHub
https://github.com/purescript-concur/purescript-concur-core/issues/15#issuecomment-1048571501,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG7XDT2LMN5KVFCWXL5WHTU4SPPPANCNFSM4WJPA6SA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Brandon Barker
@.***

To be clear, I mean go a different route with my app design - no regrets
using Concur!
On Wed, Feb 23, 2022 at 9:39 AM Brandon Barker @.***>
wrote:

No worries - I'll echo Adam's comments and just say that I am not much of
a front-end developer. Had I more experience, I'd probably have gone a
different route!
On Wed, Feb 23, 2022 at 4:05 AM Adam Barber @.***>
wrote:

@ajnsit https://github.com/ajnsit No problem, likewise, thanks for
Concur, it has been a great choice for our organisation. I've been running
concur master in prod with a non-trivial web app, with Signals, and have
never had any performance issues. I think @bbarker
https://github.com/bbarker's web app is quite unconventional in the
sheer amount of interactive forms on the page at once. It is a good stress
test, and I suppose we should always strive to speed things up if possible.
The only other thing to consider would be whether Free has had any
significant performance enhancements in the meantime.
Just out of curiousity, @liammcdermott https://github.com/liammcdermott
are you able to share any details on how/where you are experiencing
bottlenecks?
—
Reply to this email directly, view it on GitHub
https://github.com/purescript-concur/purescript-concur-core/issues/15#issuecomment-1048571501,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAG7XDT2LMN5KVFCWXL5WHTU4SPPPANCNFSM4WJPA6SA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***
com>

--
Brandon Barker
@.***

--
Brandon Barker
@.***

@bbarker My point was more about UI convention rather than critiquing anyone's skill level.  On reflection I think there could be other examples where a web application could be highly interactive like metajelo. For example financial derivatives trading apps, with tons of controls and forms on the screen at once.  So it might indeed be worth concur targeting this more heavy duty use case.  In any case, thanks for raising the issue, I had a lot of fun working on it.

Just out of curiosity, @liammcdermott are you able to share any details on how/where you are experiencing bottlenecks?

Sorry for not replying to this, to be honest, I didn't understand the question.
We couldn't use this because it exacerbated a race condition, actually nothing to do with the performance branch itself. We have now fixed that issue and are using @ajbarber's integrate-streaming-poc in production. Hundreds of people are now using this! :+1:

On reflection I think there could be other examples where a web application could be highly interactive like metajelo.

Yep, we have a lot of form elements on screen at a time.

@ajnsit I think it would still be cool to see this integrated into Concur - not sure if I could do anything to help, but if there is, let me know! Obviously, no rush, but I still think Concur is amazing, and just want to see it improve. Cheers!

@bbarker @liammcdermott I had a big refactoring in mind that was blocking this. However, given that it's been pending for a long time, I think I will merge this as a first step.
No need to create a new PR, I think you should be able to update the new changes on this pr itself.

I just submitted PRs for purescript-concur-core and purescript-concur-react based on the changes discussed above.

Just noting down the results and pending work here for posterity -
Both the PRs were merged - https://github.com/purescript-concur/purescript-concur-core/pull/25 and https://github.com/purescript-concur/purescript-concur-react/pull/64 !
The new implementation looks good (thanks @ajbarber)! But I haven't been able to verify the speed improvements yet. Please try it and let me know if it looks faster in your testing. The new implementation might also not be stack safe anymore. Adding 10k buttons on the page fails with a stack overflow. I am investigating that.
I also added some code for benchmarking here - https://github.com/purescript-concur/js-framework-benchmark/tree/purescript-concur-unkeyed. Due to the stack overflow I'm not able to generate any results yet.
Closing this issue for now.


ignite new error

use sudo [rest of the command]

thank you

🔥 igniting app PizzaApp                                                                                √ Which boilerplate would you like to use? · ignite-bowser                                                              √ using the Infinite Red boilerplate v3 (code name 'Bowser')                                                            √ added React Native 0.60.4 in 140.06s                                                                                √ added ignite-bowser in 118.03s                                                                                an error occured while installing ignite-bowser boilerplate.                                                            { Error: Command failed: yarn                                                                                The system cannot find the path specified.                                                                              error Command failed with exit code 1.                                                                                at ChildProcess.exithandler (child_process.js:294:12)                                                                   at ChildProcess.emit (events.js:189:13)                                                                                at maybeClose (internal/child_process.js:970:16)                                                                        at Process.ChildProcess._handle.onexit (internal/child_process.js:259:5)                                              killed: false,                                                                                code: 1,                                                                                signal: null,                                                                                cmd: 'yarn',                                                                                stderr:                                                                                'The system cannot find the path specified.\r\nerror Command failed with exit code 1.\n' }                           error installing boilerplate

how about mine i tried to change pc but same result

how about mine i tried to change pc but same result

same here, please help,

asme here ! HELP LEASE !

@mikasaloli and @geekz-reno, looks like you guys have a different issue. Looks like yarn package manager isn't installed.
try following the instructions here and trying again: https://yarnpkg.com/lang/en/docs/install/#mac-stable

The original issue was solved by running the command in sudo mode. Closing this isssue.


Add additional help when AttributeError is raised with regards check_tty

In reference to issue #52 I thought it might be useful to include an error message for people to try setting check_tty=False so this question doesn't have to be re-answered.

Thanks, can you reformat this to pass pycodestyle and squash the commits into one?

I squashed the commits. The only thing that came up when I ran it through pycodestyle linter was a missing docstring for the function, but I don't actually know enough about the function to write a docstring for it. Just enough to fix the error that I fixed.

Thanks!


StopIteration terminates any call to next(search_query).fill() - how to debug?

First, super cool package. I hope I can figure out how to use it. I would appreciate guidance in
I have only tried to use scholarly with FreeProxy and Tor. I believe I'm using these correctly:
# scholarly uses tor
scholarly.launch_tor("/opt/local/bin/tor", tor_sock_port=9050, tor_control_port=9051)
# this is MacOS MacPorts's tor

OR
# scholarly uses FreeProxy
proxy = FreeProxy(rand=True, timeout=1, country_id=["US", "CA"]).get()
scholarly.use_proxy(http=proxy, https=proxy)

(note: the documentation says I can call launch_tor with only one argument, the binary, but it appears to require 3 arguments)
I'm calling this as
search_query = scholarly.search_author("full name of author")
author = next(search_query).fill()    # here's where the StopIteration happens
print(author)

Anyway, I've done this a dozen or so times each with tor and FreeProxy and it never completes. All I get is StopIteration and I don't have any other info with which to debug. Am I doing this right? Is there any ability for me to debug further? If the "full name of author" is a well-cited person, does that make it harder to complete successfully? (Is there a way to split up the query if that's the case?)

Go to google scholars and search for your author manually (confirm there is a solution)
Assuming manual shows up with results the problem will be with your proxies.
A null set was returned and thus when you tried to fill it results in that error.
Debug help:
try:      Your code except Exception as Err:      print(err) else:      rest of code
Loop your code from top to bottom until you find the source of your error.
I highly recommend you use something like Visual Studio Code (Free) and include the python extension for easy linting.   This way you use can use breakpoints and debug easier without the above debug tool.

Thank you, this was helpful. I believe (after testing) that if your query in Google Scholar does not put a "User profiles for" at the top, then you'll get the error I saw. I was able to fix the problem with a different query string and everything is now working as advertised. Thank you for this excellent debugging tipsheet. I appreciate it. Keep being awesome!


webui: client-side display of ICL files

What were you trying to do?
Often it's useful (and better explained) to see ICL files are visual elements expanded from their text representation. This can include decoding images, expanding records and parsing them into human readable formats and more.
What did you expect to see?
Initially I'm thinking we could create a client-side webapp using the Go library compiled to WASM served from the HTTP server. This allows us to leverage all the work and future improvements in our Go library.  Client-side processing removes PII transmission across the internet, so Moov can host this (play.moov.io/imagecashletter) for the community without risk of PII storage.
See Mozilla's MDN page for loading Web Assembly.

Additional features that could come after this initial project:

color coded field highlighting in the ASCII/EBIDC formats
Editing and rendering of files
Conversion between X9 micro-versions
Test / Example files available as "getting started" options

This is deployed at https://demo.moov.io/x9/ - Let us know how it works!


feat(ecc-client-ga4gh-tes): create run component

Description
Create Web Component for creating tasks
Fixes #79
Checklist

[x] My code follows the [contributing guidelines][contributing] of this project.
[x] I am aware that all my commits will be squashed into a single commit, using the PR title as the commit message.
[x] I have performed a self-review of my own code.
[x] I have commented my code in hard-to-understand areas.
[x] I have updated the user-facing documentation to describe any new or changed behavior.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have not reduced the existing code coverage.

@git-anurag-hub @SalihuDickson Please review the component, basic implementation is complete :+1:

@SalihuDickson Sorry but I can't understand what are last two commits for, assuming they are for the problem I discussed with you, request data being inconsistent, this woudn't solve the problem imo.
When I tried the API, it was acting in a way that if non required fields are left empty the API will throw error but if I completely remove the field the error will be gone.
I think I should revert the past two commits as they are failing the ci, this would be easier. @git-anurag-hub do you have any opinions here, would reverting the commits be better or is there another way to proceed?

@SalihuDickson Sorry but I can't understand what are last two commits for, assuming they are for the problem I discussed with you, request data being inconsistent, this woudn't solve the problem imo.
When I tried the API, it was acting in a way that if non required fields are left empty the API will throw error but if I completely remove the field the error will be gone.
I think I should revert the past two commits as they are failing the ci, this would be easier. @git-anurag-hub do you have any opinions here, would reverting the commits be better or is there another way to proceed?

Make sense to me! Maybe @SalihuDickson can check this out & we can merge this pr. It has taken a long time now @JaeAeich.

@SalihuDickson Sorry but I can't understand what are last two commits for, assuming they are for the problem I discussed with you, request data being inconsistent, this woudn't solve the problem imo.
When I tried the API, it was acting in a way that if non required fields are left empty the API will throw error but if I completely remove the field the error will be gone.
I think I should revert the past two commits as they are failing the ci, this would be easier. @git-anurag-hub do you have any opinions here, would reverting the commits be better or is there another way to proceed?

I'll go ahead and revert the commits myself, but the ci issues are coming from some failing tests. All I did was rename your type file to suit convention. If those fails are coming from your tests then their a little too brittle but I guess that's an issue we'll have to solve late

@git-anurag-hub Review it so I can merge. :+1:


Direct LVM storage preflight must be run on etcd nodes

Given that we are now installing docker on etcd nodes to run etcd inside a container, we must run the direct lvm storage preflight checks on etcd nodes as well.

Fixed via https://github.com/apprenda/kismatic/commit/a50faf91d3f95bdc6be7cd8d4e5bdb956d7e7ea6


Move GetAttestationChallenge() implementation to DeviceProxy.cpp

Followup from https://github.com/project-chip/connectedhomeip/pull/18867#discussion_r886358738

Thank you!


Fix issue when using memory persistence

Purpose

Fix issue when using memory persistence

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


refactor: separate resource detector packages

Which problem is this PR solving?

Updates #1411

TODO: move to contrib in followup PR

Short description of the changes

Since there are a lot of diffs, I am keeping these packages in core repo until published(?), then they can safely be moved to contrib.
Adds optional detectors[] config to detect-resources.ts.

node-sdk will fill these in with all of the "default" resource detectors.

/cc @mwear @dyladan

What do we think about keeping the env detector in the resources package? It is simple and has no external dependencies, and is required by the spec.

Please resolve the conflicts and this can be merged

https://github.com/open-telemetry/opentelemetry-specification/pull/811


Changes made

code changed into kotlin type and made simpler, please add hacktoberfest label

please add hacktoberfest label


feat: rename to STRM Privacy

rename all streammachine to strmprivacy
BREAKING CHANGE: Stream Machine -> STRM Privacy

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Remove simplecov

This stops simplecov, a code coverage reporter, from running as part of the rspec tests for the Cosmetics application.
I'm not sure this provides much value, and it makes it harder to quickly spot the results of the tests.

We could remove this from the shared-web gemspec too, if it’s also not useful for the PSD team?

Pull Request Test Coverage Report for Build 6390

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.4%) to 95.578%

Files with Coverage Reduction
New Missed Lines
%

psd-web/test/controllers/investigations_controller_test.rb
1
99.39%

shared-web/app/helpers/shared/web/login_helper.rb
1
92.31%

shared-web/app/helpers/shared/web/user_management_helper.rb
1
80.0%

shared-web/app/clients/shared/web/keycloak_client.rb
2
83.59%

Totals

Change from base Build 6391:
0.4%

Covered Lines:
6030

Relevant Lines:
6309

💛  - Coveralls


[Demo requested] Full example on one-to-many and many-to-many relationships

Hello,
I like pretty much the idea and the layout of PyNest.
Could you please provide a demo project that has users, products modules, with many-to-many and one-to-mant relationships between them ? maybe two demos for the 2 relationships could be better.
And how user interacts with product ? by using services or something else ?
I asked for this because if seems that the examples given in the repo only show the cases that user and product are independent.

Hello! Thank you for your words.
Basically, you were correct with you assumption that user and product will talk with each other using services. In that way, product service can inject user service and perform query operations on the user assets. Nest is really about organise your  code in small and decoupled lego pieces that helps you to build robust application.
I have a few examples i can share and i will upload them asap to the PythonNest organisation.

Hello @copdips
I have an awesome news for you!
I've just public one of my pynest projects, an application for managing stocks that demonstrate the powerful architecture of nestjs in python.
This is the link to the project - https://github.com/ItayTheDar/Stockify
Thanks again for bringing this issue to our community!

awesome, thanks


feat(WorkflowInstaceDetailsPage): add page listing details of a workflow run

Listing of the process instances
TODO:

FLPATH-749 update endpoint

[ ] pagination + search
[x] Find data-source for the "next" flows of assessments
[x] documentatin link (changed to Description field)

[x] rebase previous work
[x] Show the details page for Assessment flows only

I left some questions but in general LGTM

BTW @mareklibra, in the table, what's the difference between NAME and WORKFLOW?
Maybe, instead of NAME, we should use Instance ID? WDYT?

BTW @mareklibra, in the table, what's the difference between NAME and WORKFLOW? Maybe, instead of NAME, we should use Instance ID? WDYT? (or a short version of instance id, because the value is large)

Recently none, I was searching for its data source. I think we can remove the Workflow column at all. The UI recently does not show IDs much, I think skipping it here will align the page with the rest.

BTW @mareklibra, in the table, what's the difference between NAME and WORKFLOW? Maybe, instead of NAME, we should use Instance ID? WDYT? (or a short version of instance id, because the value is large)

Recently none, I was searching for its data source. I think we can remove the Workflow column at all. The UI recently does not show IDs much, I think skipping it here will align the page with the rest.

Hmm, without the id, how can I differentiate between these 2 instances from the same workflow?

By the time? I will play with the rendered value

What if they are triggered at the exact same time? 😆
I think the unique ID we have would be useful here.
After all, the new table is an improved version of:

Ok, changing the time to: Nov 16, 2023 11:50:34 AM and preserving the ID :-D

Thanks!
Just to make it clear, I'm talking about the instance id, not workflow id. Instance ids look like this:


Send envelope using template versioning and text custom field support

[FLOW-179] - Version "send envelope using template" action
[FLOW-182] - Support for adding text custom fields for "create envelope using template" action

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[ x] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[x ] I attest that the connector works and I verified by deploying and testing all the operations.
[ x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x ] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x ] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x ] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

I didn't see many try/catch blocks for graceful error handling.
Do we rely strictly on exceptions?


fix new team 500

will fix #6728

Codecov Report

Merging #6749 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6749      +/-   ##
==========================================
- Coverage   40.97%   40.97%   -0.01%
==========================================
  Files         421      421
  Lines       57931    57933       +2
==========================================
- Hits        23739    23738       -1
- Misses      31033    31035       +2
- Partials     3159     3160       +1

Impacted Files
Coverage Δ

models/unit.go
43.24% <0%> (-2.48%)
:arrow_down:

modules/log/file.go
75.52% <0%> (-2.1%)
:arrow_down:

models/repo_list.go
67.89% <0%> (+1.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabee9b...c48d71a. Read the comment docs.


Does it support a tree structure?

A multi-level table that can be expanded or collapsed.

No, it doesn't


Clean up updatenotifications and nunjuck templating

Does the pull request solve a related issue?
No
What does the pull request accomplish? Use a list if needed.

Switch from manual DOM creation to nunjuck templating
Fix async/await issues
Removed exceptions in code and replaced them with jest mocks

If it includes major visual changes please add screenshots.

Top is nunjuck template
Bottom is current rendering

Codecov Report

Merging #2679 (1751cab) into develop (e4a0a51) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2679   +/-   ##
========================================
  Coverage    70.83%   70.83%
========================================
  Files           13       13
  Lines          696      696
========================================
  Hits           493      493
  Misses         203      203

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a0a51...1751cab. Read the comment docs.

I bumped ESLint to support ECMAScript 2018. It complained about the object literal spread operator which is supported since node v8.3

Sorry, am I missing something in the image? I don't see a difference between the top and bottom.

@MichMich that's good, it should look the same.
I just added it as a reference, since I changed the whole rendering of the module.


Karabiner elements breaks the TouchBar on the new MacBook pros

None of my touchbar buttons worked after installing Karabiner elements. After uninstalling it, they all immediately started working again.

+1

@DJCool1 check out this one. Decent fix, makes sense since I guess macs think that it's another keyboard.

Ah thanks, that fixed it. For some reason, in my case there was not just one but two "No product name" keyboards listed, so I unchecked both.

I had issues too - strangely enough the only FN keys affected were Mission Control's F11 and F12 for show desktop and dashboard respectively.  They were "stuck" at volume down and volume up instead.  I uninstalled Karabiner Elements and I got my keys back.  Incidentally this was with the latest version (as of this writing).

Yup. I'm experiencing this too.   The unchecking "No Product Name" solved the Mission Control/KB/iTunes issue, but as noted the holding down Fn is still broken.
Thanks!

Just ran into the same issues as others here. To be specific, though, the Touch Bar buttons that fail seem to be the ones formerly mapped to the Fn keys: mute, volume up/down (but not the volume button that goes into the slider), play/pause (but not when in iTunes), Mission Control, keyboard lighting, etc. It's probably just incorrectly intercepting those events.

Another important one that no longer works when Elements is installed is Option-Command-Esc to Force Quit.

Good point @allenmhc ! I think you're right. Interesting that it is registered as a keyboard. @broberts01 that's weird, so holding down the fn key doesn't show up the function buttons? For me it does, and f11 works as "show desktop"

@kyleholzinger:  Correct w/o Elements holding Fn shows F1 through F12 in any app.  With Elements Fn has no effect on the Touch Bar (though if you hit Fn twice dictation will start as expected).

Hm interesting. @broberts01 so that's even after you turned off the "No Product Name" input in the devices preferences?

@kyleholzinger: Correct. The "No Product Name" is unchecked.

i can attest to the observations @broberts01 is describing. I have the same exact issue.
Karabiner is installed, the ominous box unchecked. Volume- and Mediaplayer-Buttons work again, but the FN-Key is not able to bringt up the function-key-row. Without Elements, holding FN shows F1 through F12 in any app - with Elements FN has no effect on the Touch Bar.

I wonder if you uninstall karabiner if it work @noestreich @broberts01

@kyleholzinger funny, I just read your reply on my phone opened up the MacBook and wanted to reply:"Yes it works when Karabiner is uninstalled but not as described above", but then i realized, that the FN key worked again. This was the first time my MacBook went to sleep since my last reinstall of Karabiner maybe there is a connection.

Hm interesting @noestreich. No idea! I've never used karabiner with sierra so no idea. Glad it works now though! Maybe that's the answer

I have the same problem, with Karabiner Elements installed and "No product name" disabled the fn key on the MacBook has no effect on the Touch Bar.
Interestingly, if I add an external Apple keyboard (0x024f) and disable modifying events for it, then the fn key on the internal keyboard still does nothing but fn on the external one does toggle the Touch Bar correctly.

@vincent99 I suspect something else is going on, seems like the touchbar is definitely another input device. I'd check your installed programs for seil or karabiner or something, but for everyone else it seems like for the most part disabling the "no product name" device solved this issue

Just so we're clear -- disabling the "no product name" device solves the Mission Control/KB/iTunes issue, but as noted the holding down Fn to get the function keys is still broken as is any KB combination that includes the Fn keys or Esc.  e.g Cmd-Optn-Esc, Cmd-F9, etc.

When Karabiner-Elements 0.90.67 is running, holding down the fn key doesn't cause the function keys to appear on the Touch Bar. When I quit Karabiner-Elements, the problem goes away. Under "Devices", "No Product Name" shows up twice, both of which are unselected (and were unselected by default after installation). Under "Function Keys", "Use all F1..." can either be selected or deselected, the problem occurs either way.

I have noticed EventViewer registers the keystrokes for mute, next track, previous track, play/pause, volume up, volume down as "SysKeyUp" eventTypes, but never a "SysKeyDown" on the TouchBar. Esc, keyboard brightness, and screen brightness all register as "SysKeyDown." I don't know enough to fix the issue but it seemed important.

+1

I would also like to notice that for all applications you force the function keys to appear (System Preferences -> Keyboard -> Shortcuts -> Function Keys menu), those keys do not work with any kind of modifier key: Shift, Ctrl, Alt or Cmd + any function key is treated as function key only.

Any updates on resolving these issues for MacBook Pro TouchBar users?

fn key does not toggle TouchBar mode display
⌘+⌥+⎋ (command+option+esc) to open Force Quit is ignored

I am experiencing the same problem with karabinier elements and the Fn key. I would love to see a fix or feedback

I'm having the same problem as others; if I disable the 'no product name' device, then the fn key works to bring up the extended touchbar (with it enabled, this doesn't work), but disabling this device stops the escape key from functioning properly, this effects force-quit as well as other shortcuts involving escape. With the device disabled, escape does work as a stand-alone key, just not with modifier keys.

Same problem here ,FN dont display the FN keys on touchbar

Any progress here?

I've had good luck disabling the "No product name" device from Karabiner Elements as a workaround.

+1 for FN doesn't do anything when karabiner running

@makslevental you've tried the above suggestions of disabling the "no product name" as a device?

@kyleholzinger correct

@makslevental what others have suggested above regarding letting the computer sleep worked for me. Put it to sleep or go into screensaver then log back in. Fn keys work again... Although this is not ideal, it might partially solve the issue.

I have had similar issues (the first few keys of my control stripe stopped working after installing karabiner elements) but I can see no way to fix it, even after uninstalling karabiner and rebooting the system.
And there are people with the same issue on Apple's forum.

Any progress on the issue that prevents Option-Command-Esc from opening Force Quit when Elements running? Whenever I want to use Option-Command-Esc to open Force Quit, I have to first quit Elements.

Here's a link to my screen recording on YouTube showing the  Option-Command-Esc bug: https://youtu.be/XxQ745Zhz6k

I have the same issue

Yaah, me too

#535

There is a good solution here.
You have to apply the one from @mutantcornholio and @kasecato

Karabiner-Elements

fn to left_command
left_command to left_control
left_control to fn
checked Modifying events from No product name
Use all F1, F2 keys as standard function keys

MacOS

Touchbar shows F1/F2
Press Fn to Expand Control Strip

Still Touchbar Expand Control Strip when I press either physical fn or left_control key, in my case making it impossible to perform left_command (physical Fn key) + F1


fix #169 add correct link to the project

Description
added the correct link to the project
Fixes #169
Type of change
Choosing one or more options from the following as per the nature of your Pull request.

NOTE: These boxes can be checked using [X]

[ ] Bug fix (non-breaking change which fixes an issue)

[ ] New feature (non-breaking change which adds functionality)

[x] Documentation Update

Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.

[x] I have named my files and folder, according to this project's guidelines.
[x] My code follows the style guidelines of this project.
[x] My Pull Request has a descriptive title. (not a vague title like Update index.md)
[] I have commented on my code, particularly in hard-to-understand areas.
[x] I have created a helpful and easy to understand README.md, according to the given README_TEMPLATE.
[ ] I have included a requirements.txt file (if external libraries are required.)
[x] My changes do not produce any warnings.
[ ] I have added a working sample/screenshot of the script.

@all-contributors please add @krishnajalan for docs


Unexpected text color on hover in quick-pick

Description
Hovering over a quick-pick element leads to low-contrast color of the text - white :

Repro

Open a jupyter notebook
Click on 'Select Kernel' on top-right of editor
Click on 'Install Python Extension'
Hover over that text -- see how the 'Install Python Extension' is now white on hover

Version
Version: 1.79.0-insider
Commit: 784e72bc4486b7ea5ad3447c506e31d949848592
Date: 2023-05-30T05:23:26.066Z
Electron: 22.5.4
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 22.4.0

@ulugbekna what theme are you using? Do you see this with all quick picks?

@TylerLeonhardt the theme is Light+. This program is quite unique I believe because when the item is selected, it remains selected with quick pick not closing, see:
https://github.com/microsoft/vscode/assets/16353531/573ddc1d-8f6e-4d2d-b4a1-7ee83d8f95f1

Filed an issue for that, https://github.com/microsoft/vscode-jupyter/issues/13613
will fix that later

Easier repro:
const qp = vscode.window.createQuickPick();
qp.onDidChangeSelection((selection) => {
	qp.activeItems = [];
});
qp.items = [
	{ label: '12345678', description: 'desc 1' }
];
qp.show();


Fix chgrp

I am on mobile, so please forgive my bad bug report.
Inside chgrp the check for root is not sufficent:
if f == "/" && self.preserve_root && self.recursive {
One also has to check for // since that will be translated to / as well.

Good point :+1: ! Would you like to submit a PR?

@Anachron  I've opened a PR for this. Does it solve the problem?


[Q] arraybuffer issue

workbook.eachsheet call back can not be called:
var req = new XMLHttpRequest();
req.open("GET", fileUrl, true);
req.responseType = "arraybuffer";
req.onload = function(e) {
// load from buffer
var workbook = new ExcelJS.Workbook();
var data = req.response;
workbook.xlsx.load(data).then(workbook => {
console.log(workbook, 'workbook instance')
workbook.eachSheet((sheet, id) => {
console.log(sheet);
})
})
}
req.send();
}

Hi,
The above code cannot load from arraybuffer. Is there any error?

Hi,
Is it any incorrect code in the above, why workbook.xlsx.load(data) failed?

Hi,
why no response?

@softboy99 Please see issue #1168 , the example in this issue can handle ArrayBuffer data normally.


_.isPrinted should use util.inspect to show deep object structure.

resolved https://github.com/Originate/lodash-match-pattern/pull/27


Request for Educational License for eng.asu.edu.eg

@michael-n-a-ibrahim I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host eng.edu.eg not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this page and submit a new request with the correct information. Thank you for your understanding!

The domain name is eng.asu.edu.eg
It is not eng.edu.eg
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Philip Torchinsky @.>
Sent: Thursday, November 14, 2024 1:54:57 PM
To: JetBrains/swot @.>
Cc: Michael Ibrahim @.>; Mention @.>
Subject: Re: [JetBrains/swot] Request for Educational License for eng.asu.edu.eg (PR #25145)
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@michael-n-a-ibrahimhttps://github.com/michael-n-a-ibrahim I have to close this request without merging, because you requested to add a non-existent domain to this repository: Host eng.edu.eg not found: 3(NXDOMAIN) Please ensure that you are familiar with this repository rules located at the bottom of this pagehttps://github.com/JetBrains/swot and submit a new request with the correct information. Thank you for your understanding!
—
Reply to this email directly, view it on GitHubhttps://github.com/JetBrains/swot/pull/25145#issuecomment-2476159007, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BM5GGLQZGW6ZDCJ3HCFAL4D2ASFRDAVCNFSM6AAAAABRXEX5PSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZWGE2TSMBQG4.
You are receiving this because you were mentioned.Message ID: @.***>


Unexpected result when function doesn't return nothing

julia> function f1!(res, x)
           res[1] = sum(abs2, x)
       end
f1! (generic function with 1 method)

julia> function f2!(res, x)
           res[1] = sum(abs2, x)
           nothing
       end
f2! (generic function with 1 method)

julia> x = rand(3)
3-element Vector{Float64}:
 0.25636315689588907
 0.36803540982615546
 0.4789773718050756

julia> dx1 = zero(x);

julia> dx2 = zero(x);

julia> autodiff(Reverse, f1!, Duplicated([0.], [1.]), Duplicated(x, dx1))
((nothing, nothing),)

julia> autodiff(Reverse, f2!, Duplicated([0.], [1.]), Duplicated(x, dx2))
((nothing, nothing),)

julia> [dx1 dx2]
3×2 Matrix{Float64}:
 1.02545  0.512726
 1.47214  0.736071
 1.91591  0.957955

julia> dx1 == 2dx2
true

dx2 is the correct result.
Is there a way to warn the user. if the function doesn't return nothing?
This is with Enzyme v0.11.19 and julia 1.10.2.

Enzyme is trying to automatically determine the activity of the return argument. Since you are returning a Float64 the return is set to Active, and an automatic 1.0 is used as the differential return.
You can set the activity of the return to Const instead.

Thanks. Yes,
autodiff(Reverse, f1!, Const, Duplicated([0.], [1.]), Duplicated(x, dx1))

gives the expected result. Wouldn't it be better if
autodiff(Reverse, f1!, Duplicated([0.], [1.]), Duplicated(x, dx1))

wouldn't exist, such that the user always has to specify, if the return is active or not?

This is a design decision. The automatic activity deduction makes it easier for folks to use autodiff (e.g. just using on sin), which already gets complaints about it being more difficult than other utilities so I'm hesitant to do so.

cc @gdalle for design thoughts

Yeah it's a tough one. Ultimately it's about understanding which adjoints get propagated where. I have wanted to add something like https://discourse.julialang.org/t/do-i-understand-enzyme-properly/97760 to the docs for a while, maybe it would help?

Yeah I think more docs are definitely needed/helpful

In any case closing as nothing inside enzyme was erring


Create a document about how we write WDS components

Hey team! Please add your planning poker estimate with Zenhub @ichik @jsartisan @KelvinOm


Android Basics: Get data from the Internet

name: Android Basics Unit 4 issue
about: Report problems with the Android Basics Unit 4 codelabs
title: 'Android Basics Unit 4 issue:'
labels: ''
assignees: ''

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-training-getting-data-internet?hl=pt-br&continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-kotlin-unit-4-pathway-2%3Fhl%3Dpt-br%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-training-getting-data-internet#5
In which task and step of the codelab can this issue be found?
6
Describe the problem
it's not .getProperties()
it's a .getPhotos()

Steps to reproduce?

Go to...
Click on...
See error...

Versions
Android Studio version:
API version of the emulator:
Additional information
Include screenshots if they would be useful in clarifying the problem.

@paviotti
Thank you for reaching out to us. The issue is fixed and published.


SOLR-16588: set default knn algorithm

https://issues.apache.org/jira/browse/SOLR-16588
Description
Bugfix for Hnsw algorithm
Solution
Better param validation
Tests
minor test reformat
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[x] I have run ./gradlew check.
[x] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

thanks @risdenk ! All committed, adding the Changes.txt as soon as I know this is coming in 9.1.1!
Cheers


findDOMNode is deprecated; need to use a ref

Going to try to open a PR for this, but wanted to bring it up in an issue first. findDOMNode is deprecated in favor of refs. I think the safest way to fix this would be to create a single ref that is used in one of two ways:

When using a render prop, pass the ref into the render prop function and require the developer to pass it down to their input (I believe there is precedence for this in other libraries, but need to verify that...)
When not using a render prop, pass the ref straight to the default input that is controlled directly by the input mask component.

I'm going to try this and see what it does to the tests. If it works out, I'll open a PR for it, unless I hear objections here.

<React.StrictMode>
;
</React.StrictMode>

same problem


Simplify the number of stylesheets and templates we have.

Right now we provide:

parentStyleSheet
overlayStyleSheet
overlayTemplate
componentStyleSheet
componentTemplate

Thinking we should whittle these down to (at least)

parentStyleSheet
parentTemplate
componentStyleSheet
componentTemplate

and have the overlay encapsulated within the parentTemplate / parentStyleSheet.
Another thought -- get rid of stylesheets altogether and just rely on inline <style> tags in templates to reduce the work we're doing on the xcomponent side?

Done -- reduced down to 4 templates.


Compatibility with macOS

Before this change, running 'host' on macOS would result in a "found uuidgen: no" error. To reduce duplicate code, a for-loop was implemented.

Thank you for your feedback. I added the changes you requested. I also changed all the other files that checked for commands for sake of consistency.

Cool, thanks.


Python: Fix 06 memory notebook missing plugin name.

Motivation and Context
The Python 06 notebook had a failing cell due to a missing plugin_name. Also the KernelFunction wasn't visible from the semantic_kernel import due to it missing from the init file. Fixes: #4905.

Description
Fix the notebook by suppling a plugin_name for the memory store. Add the KernelFunction to the sk init.py file. Fix a comment related to an incorrectly named PromptExecutionSetting class.

Contribution Checklist

[X] The code builds clean without any errors or warnings
[X] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[X] All unit tests pass, and I have added new tests where possible
[X] I didn't break anyone :smile:

This was already fixed in a recent PR. Closing this PR.


Generate database configurations using bal persist init command

Purpose
$subject

Closing since duplicate of https://github.com/ballerina-platform/persist-tools/pull/9


Help please

Then use  - let someString = String(" 123 ").trimmed
have error - Value of type "String?" has no member 'trimmed'
Why?

@KBMatveev did you add "import SwifterSwift" to the top of the file?

No. But let today = Date().beginning(of: .day)!  work without import. And startDate = today.adding(.year, value: -1) too

@KBMatveev some time some extensions don't work without import, please import SwifterSwift at every file you want to use it in, and let me know if you still have the problem

import SwifterSwift - No Such module 'SwifterSwift'
I add directory 'Extensions' manually.
"Manually
Add the extensions folder to your Xcode project to use all extensions, or a specific extension."

@KBMatveev and if you didn't clean and rebuild the project from the "Product" menu after installing the pod, it's also preferred to do that

@KBMatveev Then please make sure to check "Copy items if needed" and "Add to targets" checkboxes when adding the files to your xcode project

Not work. In edit mode XCode found and show trimmed extension

When build - error

@KBMatveev I think the code should be
let someString = String(" 123 ")?.trimmed
trimmed is a String extension not a String? extension
Please try adding ? and let me know if this fixes the problem

Not work

@KBMatveev 🤔, are you using xcode 8 with swift 3?

Of course. :-)

DateExtensions work good, UITableViewExtensions too, trouble only with SringExtensions

@KBMatveev Then I assume the StringExtensions.swift file is not added to the target, could you please delete it, and re-add it to project while making sure to add it to target and copy if needed

I add the entire directory "Extensions", so it is unlikely that some files were added as DateExtensions, and some do not. But it's good. Will make again.

@KBMatveev weird!! , the StringExtensions.swift file follows the same structure of all other extensions files, and it is public
is this code working for you?
let someString = String(" 123 ")!.trimmingCharacters(in: CharacterSet.whitespacesAndNewlines)

@KBMatveev I'm trying to understand what is causing the problem in your end, I've tested this with multiple projects, as I see in the first picture you sent the autocompletion is completing the trimmed for you, which means xcode can see the file!
do you have another string method or property called trimmed somewhere else in your project?

Yes. Look second string.

Had to pull it out Stringextension. Works.
Must be let rt = region.trimmed

@KBMatveev is the problem solved ?

do you have another string method or property called trimmed somewhere else in your project?

I have not tried everything. Reverse() does not work.

@KBMatveev I don't know what is happening in your end, everything is working correctly for me, I'd be glad to check it myself with teamviewer if you want

is the problem solved ?

I replaced trimmed on trimmingCharacters. It worked, but hardly a solution to the problem.
You want to connect via TeamViewer?

@KBMatveev I'll try to check what is causing the problem if you want via teamviewer

Send password via eMail

@KBMatveev Glad your problem is fixed, I think the problem is when adding files from the file menu, they didn't get added to target for some reason, dragging the files to the project, always shows you the confirmation menu, where you can double check that files are added to your target


Automatically approve any request Cline has

Automatically aprove clineAsks after 5 seconds

Hey @rikhoffbauer, here is an example of how you can ask me to improve this pull request:

@Sweep Add unit tests for the enableAutoApprove feature in the Cline class to verify that when enabled, tool operations like write_file, read_file, and other operations are automatically approved without user interaction.

📖 For more information on how to use Sweep, please read our documentation.

Hey Sweep, please make it so that any request is approved automatically, but only after 10 seconds instead of immediately. A countdown from 10 to 0 is displayed inline in the button that approves the tool use. Focusing on the message input and starting to write a message to cline cancels the auto approve for the specific request as well as making any modifications to the code cline generated

sweep: this doesn't seem to initiate the countdown, maybe because code modifications performed by the extensions are considered code modifications that cancel the timer too, I'm not sure, please investigate and fix this.

sweep: An error occurs when running vsce pack, I have attached the log below.
 ./node_modules/.bin/vsce pack
Executing prepublish script 'npm run vscode:prepublish'...

><EMAIL_ADDRESS>vscode:prepublish
> npm run package

><EMAIL_ADDRESS>package
> npm run build:webview && npm run check-types && npm run lint && node esbuild.js --production

><EMAIL_ADDRESS>build:webview
> cd webview-ui && npm run build

><EMAIL_ADDRESS>build
> node ./scripts/build-react-no-split.js

Whitelisting shared files:  [
  '/Users/rikhoffbauer/repos/github.com/rikhoffbauer/cline/src/shared/ExtensionMessage',
  '/Users/rikhoffbauer/repos/github.com/rikhoffbauer/cline/src/shared/HistoryItem',
  '/Users/rikhoffbauer/repos/github.com/rikhoffbauer/cline/src/shared/WebviewMessage',
  '/Users/rikhoffbauer/repos/github.com/rikhoffbauer/cline/src/shared/api',
  '/Users/rikhoffbauer/repos/github.com/rikhoffbauer/cline/src/shared/array',
  '/Users/rikhoffbauer/repos/github.com/rikhoffbauer/cline/src/shared/combineApiRequests',
  '/Users/rikhoffbauer/repos/github.com/rikhoffbauer/cline/src/shared/combineCommandSequences',
  '/Users/rikhoffbauer/repos/github.com/rikhoffbauer/cline/src/shared/context-mentions',
  '/Users/rikhoffbauer/repos/github.com/rikhoffbauer/cline/src/shared/getApiMetrics'
]
Creating an optimized production build...
One of your dependencies, babel-preset-react-app, is importing the
"@babel/plugin-proposal-private-property-in-object" package without
declaring it in its dependencies. This is currently working because
"@babel/plugin-proposal-private-property-in-object" is already in your
node_modules folder for unrelated reasons, but it may break at any time.

babel-preset-react-app is part of the create-react-app project, which
is not maintianed anymore. It is thus unlikely that this bug will
ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to
your devDependencies to work around this error. This will make this message
go away.

Failed to compile.

TS2300: Duplicate identifier 'text'.
    17 |                | "partialMessage"
    18 |                | "openRouterModels"
  > 19 |        text?: string
       |        ^^^^
    20 |        action?:
    21 |                | "chatButtonClicked"
    22 |                | "settingsButtonClicked"

npm notice
npm notice New minor version of npm available! 10.8.2 -> 10.9.1
npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.9.1
npm notice To update run: npm install -g<EMAIL_ADDRESS>npm notice
 ERROR  npm failed with exit code 1