More roles (idea thread)

We need more unique roles, simple as that. If we don't all that's gonna happen is people are gonna play salvage to explore the ocean and no one else will want to play the other roles. We need some platform-side roles, maybe a few RP roles, more interesting jobs to keep people platform-side and inside Sweetwater.
ideas that i've got:
Fisherman:

Hunting fish outside sweetwater for the chef, or a fishing system for the ocean surface once i get around to adding that)

Trader:

The platform has an empty trading post, we can use it for something. Let players set up shops and somehow get materials to trade with other players. PRIVATE BUISNESSES REJOICE!!!

Oceanic nomad:

A rugged group that spawns out in the water. They aren't like settlers living in a cozy HAB unit, they live just out there in a moving caravan across the depths (for those fuckin powergamers to have something to do without ruining salvage)((also could be cool RP))

Prisoner of War:

see #43 for more info

Hydroculturist

see #42 and #41 for more info

Marine Biologist

Part of the science department, would do something with the ocean's many lifeforms and maybe (?) plankton or something? Maybe somehow uses them to gain research points. (or a reskinned zookeeper :P)

Scout

Gets a weak-but-fast pressure suit and ComTags, which if they find a Point of Interest, they can place it down for the larger and slower salvage teams to track for dismantling. They'd somehow need a way to not be a faster salvage tech, though.

I am half tempted to add some sort of petrochem for energy stuff. Kinda a mix of engi and chem, could be interesting idk

I am half tempted to add some sort of petrochem for energy stuff. Kinda a mix of engi and chem, could be interesting idk

Interesting! Well fun fact, there's actually a system that makes it so fish are processed into fish oil, which when mixed with hydroxide makes welding fuel. Some kind of power processing thing could be cool, although the artifact currently powers everything currently.

some kinda bell operator? like if you know that one thalassaphobia game where a guy operates the bell on the oil rig, making sure they come up safely

Crew roles:
Basin technician, they work under water to gain power from Hydrothermal vents and maintain any underwater structures. they also maintain the comms relay to make sure nothing goes wrong with that.
A form of Xenobio that finds microbial cultures and creatures from the deep to gain science points and can harvest them from ethical experiments and tests. (Or just use their organs and cells to make shit).
  After a while, they can close shop and "Profit-text"
Neutral Ghost roles:
Fishmen: they have a little cove in the deep and have all sorts of trinkets and goodies.... that salv will almost certainly raid... good thing they are territorial and Powered by some artifact that gives them strength with proximity (effectively deep-sea ash walkers)
Antag Ghost roles:
THE GREAT FLYING SQUID: Basically, a space dragon, but with a squid army instead and covers the rig in corrosive ink
Normal ass pirates: Cause this sea's are rough dogs only.  Goal is to take over at least a certain amount of people and call in a jelly hoard to cmake the rig their capital or something... mind jellies are weird

Normal ass pirates: Cause this sea's are rough dogs only. YYYYAAAAARRRRRRRGGGGHHHHHHH
That can be cool, can have goals to plunder certain items maybe. Give them a nukie esc pirate cove to spawn on maybe when #80 is done

Mind Jellies: Some green thing hopped on your head, and now you want to show the rig the joys of having a green thing invading your thoughts, a conversion antag... something ghost roles are normally not. Goal is to take over at least a certain amount of people and call in a jelly hoard to cmake the rig their capital or something... mind jellies are weird
Personally not a fan of conversion antags, esp for ghost roles. Just feels a little too impactful, and I don't like how they completely override someone's goals for a round. Doesn't feel like something a midround should do

Just noticed that Traders was already on the original post, darn.

Personally not a fan of conversion antags, esp for ghost roles. Just feels a little too impactful, and I don't like how they completely override someone's goals for a round. Doesn't feel like something a midround should do

I am quite the opposite, i enjoy conversion antags a lot... excluding zeds. but things like cults and revs or even Lunatics are some of the most fun ive had as a team antag. But maybe you are correct in perhaps havin a ghost role conversion antag is a bit much since it may conflict with other antags or events at random.
I wouldnt mind it being round start though, we need more variety. or maybe im being too antag focused for an MRP server...

I am quite the opposite, i enjoy conversion antags a lot... excluding zeds. but things like cults and revs or even Lunatics are some of the most fun ive had as a team antag. But maybe you are correct in perhaps havin a ghost role conversion antag is a bit much since it may conflict with other antags or events at random.
I wouldnt mind it being round start though, we need more variety. or maybe im being too antag focused for an MRP server...

My main thing with conversion antags is they conflict with the play your role rule, since you cant really opt into them, so if say you want a chill botany shift and get revved, now that supposed to be your main thing or youre a wiff on the rev convert (revs are a major rules issue tbf). I think conversion are fine in moderation, but personally I am more interested in non conversion antags. Cults are cool tbf, and I could def see a sort of Great Old One/Cthulhu cult/heretic being cool.

Potentially like an equivalent to the Stranded Hermit from SS13's Paradise Station, waking up in an escape pod's cryo chamber on the seafloor with minimal power and life support gear. Somehow you must survive the depths, get food and materials or die trying. SS14 hardmode, pretty much. Stranded hermit is my favorite role in ss13 tbh bc it's challenging and the RP when i find the station is always GREAT

I am quite the opposite, i enjoy conversion antags a lot... excluding zeds. but things like cults and revs or even Lunatics are some of the most fun ive had as a team antag. But maybe you are correct in perhaps havin a ghost role conversion antag is a bit much since it may conflict with other antags or events at random.
I wouldnt mind it being round start though, we need more variety. or maybe im being too antag focused for an MRP server...

My main thing with conversion antags is they conflict with the play your role rule, since you cant really opt into them, so if say you want a chill botany shift and get revved, now that supposed to be your main thing or youre a wiff on the rev convert (revs are a major rules issue tbf). I think conversion are fine in moderation, but personally I am more interested in non conversion antags. Cults are cool tbf, and I could def see a sort of Great Old One/Cthulhu cult/heretic being cool.

Yeah i agree, i'm iffy on conversion antags. On one hand some of the most enjoyable rounds i've been in were zombie rounds, but also i do agree it takes you out of your role. They should be a dedicated gamemode if they exist.
Maybe a system that sees what percentage of the current players are "opted in" to conversion antag activities? That way we can see how many players would actually want to be taken out of their role for a certain gamemode or something

Yeah i agree, i'm iffy on conversion antags. On one hand some of the most enjoyable rounds i've been in were zombie rounds, but also i do agree it takes you out of your role. They should be a dedicated gamemode if they exist.
Maybe a system that sees what percentage of the current players are "opted in" to conversion antag activities? That way we can see how many players would actually want to be taken out of their role for a certain gamemode or something

I think a majority server opt-in to conversion antags being present in a round would be really nice, obvs just as a potential rule option not just every round vote for zeds. Could either do it in the antags menu or something or some kind of automated vote (I think some other servers do this but im not sure)

A few ideas when it comes to shipside:
Search And Rescue Operator
Probably apart of the medical department, functions as a paramedic but possibly with a ship they can use underwater to find dead/crit salvagers? Gets tools which help with finding those whom are lost.
Plumber
Engineering based role, like atmospheric technician but underwater. Handles pipes and the draining of flooded rooms, can build like a normal engineer but specializes in draining flooded rooms.
Driller
Platform based role, probably apart of cargo? Would operate a theoretical oil drill on the platform and deal with the challenges it poses. Once set up properly could generate cargo a lot of money but comes at the risk of oil spills, explosions, etc.
Safety Specialist
RP based role, checks platform and maybe the underwater station as well for any safety violations, can issue fines maybe if a violation is found?
Torpedo Operator
Security based role that functions on the platform using a remote console probably, if hostile submarines are ever added this role can combat them using a GUI of sorts. Could also maybe operate other platform consoles as well?
Dispatcher
Final RP based role, gets access to all comms and can open doors remotely, main use is coordinating efforts between the departments to counteract threats and emergencies. (Ex: Engineering reports a Syndicate in the engi locker room, dispatcher hears this and reports it to Security and maybe raises the security level if needed).

A few ideas when it comes to shipside:
Search And Rescue Operator
Probably apart of the medical department, functions as a paramedic but possibly with a ship they can use underwater to find dead/crit salvagers? Gets tools which help with finding those whom are lost.
Plumber
Engineering based role, like atmospheric technician but underwater. Handles pipes and the draining of flooded rooms, can build like a normal engineer but specializes in draining flooded rooms.
Driller
Platform based role, probably apart of cargo? Would operate a theoretical oil drill on the platform and deal with the challenges it poses. Once set up properly could generate cargo a lot of money but comes at the risk of oil spills, explosions, etc.
Safety Specialist
RP based role, checks platform and maybe the underwater station as well for any safety violations, can issue fines maybe if a violation is found?
Torpedo Operator
Security based role that functions on the platform using a remote console probably, if hostile submarines are ever added this role can combat them using a GUI of sorts. Could also maybe operate other platform consoles as well?
Dispatcher
Final RP based role, gets access to all comms and can open doors remotely, main use is coordinating efforts between the departments to counteract threats and emergencies. (Ex: Engineering reports a Syndicate in the engi locker room, dispatcher hears this and reports it to Security and maybe raises the security level if needed).

these are cool, we probably won't have submarines due to some layering/code issues and also because of the possibility of #81, but i like the idea of atmos techs instead being like plumbers cleaning floods and such

NT nukies?

I'm not too familiar with the gameplay because I only saw a video but the wildlife looks pretty dangerous. What if we had someone on the upper platform who could extract people if they die too far out (maybe you'd need to pay for the extractor to work?). Or maybe the extractor could deploy to help out. I don't know how well that would work though and it's probably overpowered.

Other Idea: Perimeter Technitian that has to set up defenses like fences or maintain turrets that ensure that you don't get jumped as soon as you leave into the outside around the underwater section.


Question on the page "priceRanges"

Hi! I have a documentation issue on InstantSearch.js. I could not find what I was looking for on the page "priceRanges".
I am trying to implement code for priceRanges but i am getting error.
"AlgoliaSearchError: Invalid syntax for numeric condition:price0NaN\n  "
here is my code-
search.addWidget(
instantsearch.widgets.priceRanges({
container: '#facet-price',
attributeName: 'price',
collapsible: {
collapsed: is_collapsed
},
labels: {
currency: '$',
separator: 'to',
button: 'Go'
},
templates: {
header: 'Price'
}
})
);

HI @Bhavin1010. You're linking to InstantSearch.js v2 docs. Can you confirm you're using InstantSearch v2?
Here is a working example of priceRanges with InstantSearch.js v2:
https://jsfiddle.net/63saqt5w/10/
If you are indeed using v2, I cannot recommend enough to update: the upgrade guides are sitting here: https://www.algolia.com/doc/guides/building-search-ui/upgrade-guides/angular/#migration-from-v2-to-v3.
I'll close for now, but if you still have an issue, please do reopen and provide a code sample so I can help troubleshoot.


[Cloudflare for SaaS] fix typo in _index.md

Fix a typo in the "Cloudflare for SaaS with BYOIP" section of the Cloudflare for SaaS docs

Thanks, @williamhorning!


Translate the Readme.md file into Simplified Chinese

Issue: #206
About the part of "Table of Contents" , I will modify it after all parts are translated

It is okay to translate the table of contents later when you have translated the rest, I understand.


[Bug] Moving Token with changed elevation returns validations error "elevation: must be a finite number".

When moving a token and changing the elevation during the ruler measurement, it doesn't change the elevation, instead returning only an error.
Screenshot of error:

What do you mean "moving a token and changing the elevation during the ruler measurement"? Could you describe the steps you take that cause this?

Ah, apologies
It seems to have been fixed by now? Might have just been a issue on my end which updating fixed...still odd that it happened.
What happened was that when I dragged a token, and changed the elevation with a shortcut, it would when placing the token not change the elevation after.

Select Token
Change elevation up or down with the shortcuts while moving
Move Token
Error appears, and elevation didn't change.

But as said, is fixed mysteriously now anyway, sorry!!


adding parameter for setting default database to specified db by parameter for all logins

.PARAMETER DefaultDatabase
If this switch is enabled, all logins will be scripted with default database specified by parameter,
that could help to successfully import logins on server that is missing default database for login.

Type of Change

[ ] Bug fix (non-breaking change, fixes #)
[X] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

If this switch is enabled, all logins will be scripted with default database specified by parameter,
that could help to successfully import logins on server that is missing default database for login.
Approach

    adding switch and based on switch there is IF code block

Commands to test

Screenshots

Learning

I don't know that I agree with having an export command alter the state of an object after it is exported.
Is there some need or previous history of this feature being asked for or an issue for users?

I don't know that I agree with having an export command alter the state of an object after it is exported.
Is there some need or previous history of this feature being asked for or an issue for users?

hi, I am using Export-DbaLogin and believe me or not I need to run really awful parsing job after that to export file. It would be cleaner having built-in switch if possible.

ok, after last run of appveyor these two last items:

any idea how to proceed with this one?
Describe : Export-DbaLogin Unit Tests
Context  : Validate parameters
Name     : It Should only contain our specific parameter

I ran Invoke-DbatoolsFormatter but it would mean to replace whole file? Should I replace whole code with reformatted?
Describe : dbatools style
Context  : formatting

ok, after last run of appveyor these two last items:

any idea how to proceed with this one?
Describe : Export-DbaLogin Unit Tests
Context  : Validate parameters
Name     : It Should only contain our specific parameter
I ran Invoke-DbatoolsFormatter but it would mean to replace whole file? Should I replace whole code with reformatted?
Describe : dbatools style
Context  : formatting

@potatoqualitee can you pls guide me with those 2 last items?

Yes, my apologies for the delay. This week has been ultra busy. I will submit fix with comments 👍

all tests pass! I pinged you on the changes to the test file. Thank you so much for your contribution 🏅🏅🏅 .


Add custom unauthorized entity

Hi there,
Thanks for making this simple and awesome library that just fits very well into Rails APIs.
In my APIs, I always return a textual version of the error for user agents to render. Therefore I needed to be able to send a custom message with the unauthorized header.
This pull request enables us to override handling of the unauthorized entity and do the following:
class ApplicationController < ActionController::API
  include Knock::Authenticable

  private

  def unauthorized_entity(entity_name)
    render json: ["Unauthorized"], status: :unauthorized
  end
end

Thanks in advance.
Lasse

@lassebunk Nice and clean. Great PR 👍
If you could also update the Readme and the Changelog, that would be amazing.

@lassebunk Thank you for adding this. I copied that code block into my ApplicationController but I'm still getting a blank response sent back, rather than text that says Unauthorized. Do I need to put any code in the controller that's protected by before_action :authenticate_user ?

@BrennerSpear Did you install the gem from the master branch?

@nsarno yes I'm running 1.5

@BrennerSpear So you did not install from the master branch :)
The latest commit on master has not been released as a new version yet. I'll do this soon, but in the mean time you need to install the gem by specifying the following in your Gemfile:
gem 'knock', github: 'nsarno/knock'

To check what feature is included in a given version, you can always refer to the changelog.

@nsarno gotcha - thank you!!


New unreachable code compiler options need to be handled

Version 7.8.0 updated to the latest ntypescript which features some new compiler options: allowUnreachableCode, allowUnusedLabels, noImplicitReturns, and noFallthroughCasesInSwitch which are all unrecognized in tsconfig.json.

Guidance
https://github.com/TypeStrong/atom-typescript/blob/11f485ba80dc7e4aeee6176714c1efbff7398b9e/lib/main/tsconfig/tsconfig.ts#L12-L16


bump snapshot service to forest 0.16.2

Summary of changes
Changes introduced in this pull request:

bump Forest to v0.16.2,

Reference issue to close (if applicable)

Closes
Other information and links

⚠ Merge after the tag is published in Forest packages


Bracket instance for Future.

Codecov Report

Merging #237 into master will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   91.08%   91.30%   +0.22%
==========================================
  Files           8        9       +1
  Lines         157      161       +4
  Branches        3        5       +2
==========================================
+ Hits          143      147       +4
  Misses         14       14

Impacted Files
Coverage Δ

...scala/io/catbird/util/effect/FutureInstances.scala
100.00% <100.00%> (ø)

...a/io/catbird/util/effect/RerunnableInstances.scala
100.00% <100.00%> (ø)

...rc/main/scala/io/catbird/util/effect/package.scala
88.88% <100.00%> (+3.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b4b17b...36c2137. Read the comment docs.

Huh... the build was failing and I tweaked the travis config a bit (updating versions and fixing warnings), not expecting that to fix it, but now it passes.  So possibly an intermittent failure lurking here.

Huh... the build was failing and I tweaked the travis config a bit (updating versions and fixing warnings), not expecting that to fix it, but now it passes. So possibly an intermittent failure lurking here.

Scratch that, the failure was actually due to a scalafmt error, fixed now.

@felixbr Any objection to merging this before a new release?

No, looks great! 👍


API documentation Global Methods, Global Variables

Where can i find propper documentation for the available globals?
It is mentioned in the advanced scripting page that there are the Selected and the Model object available in addition to some methods
but thus far, i was unable to find any documentation especially on the methods and their typing.
And globals aren't even mentioned in the api reference.
It would be great if there was an additional page (best on top) in the api reference showing all global variables and methods

The Selected object is of type Selection.
Model is of type Model.
The global methods are listed here.
Note, a few of them are only available in TE3 - we're working on improving the docs to better indicate this.


Improved assertion for PrepareUniformSuperposition

This is a proposal to fix #221. It adds an assertion that the input state is in state |0...0>. The assertion will also get triggered when calling the Adjoint variant on a state that is not in a uniform superposition. Ideally, we would check whether the state is eventually in a uniform superposition, but this may add too much overhead.

I think this makes a lot of sense, though I'd also suggest adding an explicit note to the API documentation comment, since its not obvious a priori that the operation is adjointable only as a partial isometry and not as a unitary.


Side Menu Close Delay iOS

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[x ] 3.x
I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

I'm using the sidemenu(ion-menu) on a Iphone 7 and use the menuToggle option.
Clicking the toggle menu opens the menu as expected. If you click the menuToggle within a second or so the menu does not close. If you wait a second or so the menu is closed correctly, but with a delay.  If you use the option type='overlay' the menutoggle is not shown but you can immediately close the menu. I would like to have the same behavior with the togglemenu.
We use the ion-menu within a ion-split-pane, used for ipad users
Expected behavior:

the menutoggle should respond directly if you tap it.
Steps to reproduce:

Related code:
insert any relevant code here

You can reproduce the issue with a clean starter project.

create app with CLI

ionic start TestApp sidemenu

Deploy this on a iphone 7 device.
Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
insert the output from ionic info here

global packages:
@ionic/cli-utils : 1.4.0
Cordova CLI      : 7.0.1
Ionic CLI        : 3.4.0

local packages:
@ionic/app-scripts              : 1.3.7
@ionic/cli-plugin-cordova       : 1.4.0
@ionic/cli-plugin-ionic-angular : 1.3.1
Cordova Platforms               : ios 4.4.0
Ionic Framework                 : ionic-angular 3.3.0

System:
Node       : v6.11.0
OS         : macOS Sierra
Xcode      : Xcode 8.3.3 Build version 8E3004b
ios-deploy : 1.9.1
ios-sim    : 5.0.13
npm        : 3.10.10

Are you using the --prod flag?

already reported here: https://github.com/ionic-team/ionic/issues/9716

Hello all, I am going to close this issue as a duplicate of #9716 .


From GitHub HEAD: Custom-node addon crashing Godot

Operating system or device:
LinuxMint 64bit, Godot.x11 Editor.
Issue description (what happened, and what was expected):
The Editor wouldn't update the Nodes list after enabling/disabling the "Heart" addon example; if you add the Node after it was disabled, the Engine will crash.
Steps to reproduce:
To check on Node list update:
1- Enabling "custom_node" plugin on the addon list.
2- Click on "Add/Create a new Node"
The node won't appear on the Node List, unless you search for "Heart" node. Than it will show properly on the list.
The inverse thing will happen when you disable the Addon; it will stay appearing on the list, unless you search for him (than it won't show anymore).
To crash the Editor:
1- Enable "custom_node" plugin on the addon list
2- Disable "custom_node" plugin on the addon list
3- Enable "custom_node" plugin on the addon list
4- Add the "Heart" node to the scene.
The editor will crash; restarting it will have "Heart" Addon enabled.

Does this still happen in the current 2.1 beta?

I lost the project in which I had the particular Heard addon demo that I tested; but using the node Addon I created myself, Godot didn't crashed.
One thing that I noticed is that, by searching the parent node that your Addon node inherits to, your addon won't appear on the list (the inherited Addon won't show it's children nodes). I will make another issue with that.


Update index.html

Fixed typo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This is not a typo, thanks.


Modern version - Scroll bar in the EDGE browser

The scroll bar appears in the EDGE browser where it should not.
Microsoft Edge 44.18362.449.0

Is that the version that's based on Chrome? Do you have any specific backward compatibility enabled or is it a default configuration?

This is the EDGE browser provided with Windows 10 in the default configuration.
Microsoft Edge 44.18362.449.0
Microsoft EdgeHTML 18.18363

I reinstalled server and I delete cookie, cache etc from EDGE. The problem is still there.
In addition, I noticed (I don't know if it was before) that the elements were not positioned correctly on the login screen.

Thanks for reporting the issue.

Closing as there were a lot of changes and it shouldn't be a problem anymore. If it's still happens, please let me know.


Map Objects returning empty data

For some reason I can log in fine with the API but after calling getMapObjects, each mapObject returned is empty. I'm getting:
Cell<PHONE_NUMBER>646878208
Has 0 catchable Pokemon
{ s2_cell_id: '5220699520794361856',
  current_timestamp_ms:<PHONE_NUMBER>266,
  forts: [],
  spawn_points: [],
  deleted_objects: [],
  is_truncated_list: false,
  fort_summaries: [],
  decimated_spawn_points: [],
  wild_pokemons: [],
  catchable_pokemons: [],
  nearby_pokemons: [] }

This has happened on many many different coordinates across many accounts. Is this an issue with the API itself?

Due to constant changes in Pokémon GO API, node-pogo-signature hasn't been updated yet to make valid signatures for latest supported API. I have heard, that only one group has "cracked" the new signature and there aren't others cracking it. This one group is selling access to their paid signature making API with "requests per minute"-limits (more money = more requests). node-pogo-signature is most likely updated to support this paid service in the future (if I have interpreted the discussions in /r/pokemongodev Discord correctly) so you could just put in your paid API token and start using the API. I'm labelling this as a bug for now.

Use this one in the meantime: https://github.com/pogosandbox/node-pogo-signature.
It come from pcrypt beeing update for 0.49 but hashing still on 0.45.

Fixed with 0780e2e6e09dd54a23f5933d89f6544c83bde893


feat/add full ts support/coverage

* Please fill in the required items.

Priority*

[x] High: This PR needs to be merged first for other tasks.
[ ] Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
[ ] Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*
As we was talking on Discord, i've decided to refactor project a little and create it more ts friendly.
It'll be also very helpful for me, when i'll be working on custom env module, because i've some conflicts, now it should works perfect :)
Don't pay attention to redundant cross-env and overall env solutions because it'll be refactored #722
I'm currently working on this/
Changes*
I've changed .js to .ts where it's necessary
How to check the feature
Run it as normal pnpm build or/and pnpm dev
And check if all pages works well on Chrome and Firefox :)

CI build error will dissapear after #748 let's merge it in the first place

@Jonghakseo any chances to push it forward?

👀 There are some error in pnpm dev.

Okk, i know what's going on, it's mistake from conflicts resolving, i will fix it tomorrow 😁

@Jonghakseo Should work right now, for me and CI everything looks perfect :)


[BUG] Projects in soulution folders are not detected properly

Version 2.0.7
What happens:
When a project is in a Solution subfolder of a solution no Conan Package can be added, because the project is not recognized as msvc project. So no library can be added via the extention.
What should happen:
Projects in a subfolder of a solution should be detected as others.
Current Workaround:
Move the project direct under the solution, add the libraries, then move it back.

Hi @Maju-Ketchup,
Thank you so muchofor reporting.
I confirmed that this issue is happening as you describe. I have added this to the milestone for the next release.

Hi @Maju-Ketchup,
We have just released 2.0.8 version of the extension that should solve this issue.
Thanks a lot for reporting.


Added a new Python Implementation using Complex Maths n Function for …

…FizzBuzz
Added a 3 functions Python implementation, complex to understand using mathematics

haha nice!


Mask SQL in ExecutorLifecycle logs for AWS Credentials

Description
With MSQ submitting the tasks containing SQL which might have sensitive keys like AWS's secrets in them, they can get logged in the file if the SQL contains them.
While this is not a secure way to specify the credentials since they might get logged & reported at multiple places, this PR  aims to mask these sensitive keys in the log files using a simple regex search and replace.
For GCS and Azure input sources, the credentials cannot be specified in the InputSource itself therefore we donot need to search and mask their keys in the SQL.

Key changed/added classes in this PR

ExecutorLifecycle

[x] been self-reviewed.

[x] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

I am not sure I agree with the approach here. It seems an overkill to do a complex regex replace just to not log some specific fields.
Yeah, but since the SQL was a string, there seemed to be no other alternative, esp. since druid planner isn't available in the Peons.

I think the better thing to do is to just continue logging the secrets. This would be a good reason to encourage users to provide secrets using a EnvironmentVariableDynamicConfigProvider or similar.
We should then update the documentation since the method here only masks it in the logs in the ExecutorLifecycle class. Any deserialization of the controller's task spec would reveal the query.

If we do however feel the need to this, we should look for a simpler approach
All of the approaches (that I was able to think off) would be based on a text search and replace, so in my opinion, we can choose any one of them.

IMHO the current approach seems fine as most of the companies feed the logs to a log aggregator, like Splunk, and have alerts set up for leaking secrets.

Nit: Please update the description as well.

CI failures seem unrelated

Thanks, @LakshSingla for the securing druid even more.


Bug: Could not remove unused volume

Description
Could not remove the volume even that there is no container associated with that volume.

Steps to reproduce the issue:

Use docker-sync to create a volume
Stop all containers, restart the docker daemon, and also restart the machine
docker volume rm volumne_name got failed

Describe the results you received:
$ docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
$ docker volume rm eh_sync
Error response from daemon: Unable to remove volume, volume still in use: remove eh_sync: volume is in use - [26601c6b63deb9526da4ab550b34d312917e78c431b2b61dbed41722143d2843]
Describe the results you expected:
The volume should be removed.
Additional information you deem important (e.g. issue happens only occasionally):
Output of docker version:
Client:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 23:26:11 2016
 OS/Arch:      darwin/amd64

Server:
 Version:      1.12.3
 API version:  1.24
 Go version:   go1.6.3
 Git commit:   6b644ec
 Built:        Wed Oct 26 23:26:11 2016
 OS/Arch:      linux/amd64

Output of docker info:
Containers: 5
 Running: 0
 Paused: 0
 Stopped: 5
Images: 8
Server Version: 1.12.3
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 66
 Dirperm1 Supported: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: null host bridge overlay
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Security Options: seccomp
Kernel Version: 4.4.27-moby
Operating System: Alpine Linux v3.4
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.951 GiB
Name: moby
ID: BTR2:BEC6:TZ44:ZWK6:NPJU:J6IT:GYFZ:JVAW:GNHZ:XJKK:34DS:HW6B
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 15
 Goroutines: 27
 System Time: 2016-12-06T00:42:19.521769536Z
 EventsListeners: 1
No Proxy: *.local, 169.254/16
Registry: https://index.docker.io/v1/
WARNING: No kernel memory limit support
Insecure Registries:
 <IP_ADDRESS>/8

Additional environment details (AWS, VirtualBox, physical, etc.):
Darwin Phats-MacBook-Pro.local 16.1.0 Darwin Kernel Version 16.1.0: Thu Oct 13 21:26:57 PDT 2016; root:xnu-3789.21.3~60/RELEASE_X86_64 x86_64

Can you check docker ps -a?
Specifically it thinks there is a reference to a container with ID 26601c6b63deb9526da4ab550b34d312917e78c431b2b61dbed41722143d2843

@phatle Is there something in /var/lib/docker/containers/26601c6b63deb9526da4ab550b34d312917e78c431b2b61dbed41722143d2843?

Yes. my folder data

Is there a config json in there?
Trying to figure out how/why there would be a container referenced but no container loaded for it.
Since the volume refs are only stored in memory, it's getting reloaded for some reason on daemon restart but not showing up in docker ps -a (Some weird partially loaded state?)

@cpuguy83 Yup. It has config.v2.json and hostconfig.json

@cpuguy83 Updated docker ps -a
CONTAINER ID        IMAGE                                                                           COMMAND                  CREATED             STATUS                      PORTS                                            NAMES
f7c43a32882e        eugenmayer/unison:unox                                                          "/entrypoint.sh super"   59 minutes ago      Exited (0) 9 minutes ago                                                     eh_sync
26601c6b63de<PHONE_NUMBER>37.dkr.ecr.ap-southeast-2.amazonaws.com/APPNAME/webdev:1.0.1   "/script/start_web.sh"   4 days ago          Exited (1) 3 minutes ago    <IP_ADDRESS>:3000->3000/tcp, <IP_ADDRESS>:8080->8080/tcp   devenv_web_1
c1f15adf3b75        busybox                                                                         "sh"                     4 days ago          Exited (0) 18 minutes ago                                                    devenv_bundle_gems_1
68121c170f40        busybox                                                                         "sh"                     4 days ago          Exited (0) 18 minutes ago                                                    devenv_node_modules_1
5bf1844402ea        postgres:9.4                                                                    "/docker-entrypoint.s"   4 days ago          Exited (1) 3 minutes ago    <IP_ADDRESS>:5432->5432/tcp                           devenv_db_1
4fec1955f65e        redis:3.2-alpine                                                                "docker-entrypoint.sh"   4 days ago          Exited (1) 3 minutes ago    <IP_ADDRESS>:32769->6379/tcp                          devenv_redis_1

@phatle What changed between the previous docker ps -a and this one?
And yep, the container the volume is complaining about seems to exist (2nd entry in your list).

@cpuguy83 Thanks for helping me. Can I close it because I can not reproduce that? Sorry about that. Happy coding

Thanks for the report, glad we got it figured out!


Admin GUI in Chrome shows white page after update. Broken JS load

Rancher Version: 0.63.1, 0.63.0
Docker Version: Docker version 1.10.0, build 590d510
OS: Linux 4.3.0-sabayon
Browser: Chrome 46
Steps to Reproduce:

docker run -d --restart=always -p 8080:8080 rancher/server:latest
Go to http://localhost:8080
View Developer tools console

Results:

White page (because javascript file is not loaded)
Developers tools Console logged:

Failed to find a valid digest in the 'integrity' attribute for resource 'http://localhost:8080/assets/vendor-ef2d8c0ba9fbead853773dde7e2f49b2.js' with computed SHA-256 integrity 'fQX8Hv5RgYjrpyIvaPgXaP1hQwUmD9WQF50CyKg1qvg='. The resource has been blocked.
ui-ff548e9ae3e48f5760c70836d3559780.js:1 Uncaught ReferenceError: define is not defined

Expected:
No error in console
Usual Admin GUI loaded
In version 0.59.1 worked everything fine. After update broken.
In Firefox 41 it works fine.

@tfiduccia Does this sound like a duplicate of https://github.com/rancher/rancher/issues/2977?

I haven't been able to reproduce this but it sounds like it's related to https://bugs.chromium.org/p/chromium/issues/detail?id=527286 .  Since we're hosting the resources from the rancher/server I don't think SRI is really that valuable and will just turn it off.

Version - master 3/23
Verified fixed
I also have not been able to reproduce this in latest builds


feat: merge mac mul chip

poseidon: 8.2k -> 11.3k cycles (+3.1k)
Before:

Bn254ScalarMulChip 370 cols
Bn254ScalarMacChip 648 cols

After:

Bn254ScalarMacChip Cols 917 cols (-101)

can you describe the number of columns that saved by generalizing mac chip (ret = a*b + ret * c) to make mul as a special case?

We won't merge this pr as it only saves about 10% columns while increasing the number of cycles by about 40%.


added trailing slash for tags, fixes #22

Fixes tags being stripped out by Loggly due to missing trailing slash. See #22

Thanks @simpixelated !


Users get logged out after making a successful payment.

Whenever users try to add funds on the panel their money get deducted and they are redirected to the login page but the fund doesn't load in their accounts.

Hey bro, managed to fix this?

Hey bro, managed to fix this?

No, unable to fix

I would have to analyze the code. I'm out of time to work on BoostPanel, so it's on OpenSource. However, at the moment, no programmer contributed.
I intend to update BoostPanel to PHP >= 7.2, reformulate it all. But not at the moment, when I start this, I will notify here in this repository for everyone.

which paymet gateway not work??

which paymet gateway not work??

For me it's the paytm and payunow.


Add convenience event 'clicktap' that combines events for 'click' and 'tap'

Disclaimer: I'm not sure this is the best way of doing it.
In our code we have a few places where we do
container.once("click", doSomething);
container.once("tap", doSomething);

This PR adds a new event called "clicktap" that combines the two:
container.once("clicktap", doSomething);

I've run testem (some of the tests timed out), but I couldn't figure out how to run jshint (It's gulp jshint). The CONTRIBUTING.md is a bit out-of-date, so I apologise if I missed a step.

I wasn't even aware of this way to bind events.
We just do this :
container.tap = container.click = function(){};

yes, but that only works well if you have only one listener, the on/once approach is a lot more flexible and allows multiple listeners.

But this PR would also allow you to do
container.clicktap = function() {}

I don't think this is a good idea, if we wanted to combine events we would implement the pointer event API. This is totally non-standard.

Fair enough. Anything I can do to help to move in that direction?

There is a lot of work that needs to get done in the interaction manager IMO. I'm thinking of what the best way to do that would be.
In the meantime if you want to unify events like this, just use the standard pointer event names and I would be ok with it, at least temporarily.


Look at location method + 1.16.x support

Added method to have NPC look at a given location.

Didn’t notice latest version was 2.10, I’ll update the version to 2.11 when I get the chance

I'll merge the codebases and create an official release.
After I changed the version ID.

Merging!


Fix imgur in CI

📝 Description
Test
❓ Context

Impacted projects: ``
Linked resource(s): ``

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

/generate-screenshots


swapHiddenInput copies name attribute

When swapHiddenInput  option is used, the name attribute of the original input is copied to the visible clone.
This is problematic when the (form containing the) input field is eventually submitted:  both the formatted as the rawvalue will now be part of the request.
See: https://jsfiddle.net/wardlootens/cv67w38s/16/

See potential fix on
https://github.com/WardLootens/cleave.js/commit/d042a28100d957e31df480c1df32b19acf5c276f

Just noticed this is an issue for me too. I can see both field values on my backend.
Any news on this item?
TIA


Add readiness probe for MLServer and Increase memory for pmml in CI

What this PR does / why we need it:

The Inference requests often timing out in MLServer CI tests due to model is not ready at that time. Unlike KServe,MLServer first starts the server and after that it loads the model. The isvc is marked ready once the server starts listening on the specified port as by default KServe only configures a simple tcp readiness probe. This PR adds proper readiness probe for MLServer tests to avoid test flakiness caused by this issue.
Increase memory limit for pmml tests to prevent pods getting OOMKilled and avoid read timeout errors

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Type of changes
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A

[ ] Test B

Logs

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

[ ] Have you added unit/e2e tests that prove your fix is effective or that this feature works?
[ ] Has code been commented, particularly in hard-to-understand areas?
[ ] Have you made corresponding changes to the documentation?

Release note:

NONE

Re-running failed tests

/rerun-all - rerun all failed workflows.
/rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

/rerun-all

/rerun-all

/lgtm
/approve


Implementation of Send method

Send amount to recepient. Valid amount format examples: 10, USD10.4, EUR10000, 10000.4
Options:
-n, --network  Connect to network: [mainnet|devnet] (default: mainnet)
-c, --node  Connect directly to node .
-f, --format  Specify how to format the output [json|table] (default: json)
-v, --verbose  Show verbose logging.
-p, --passphrase [passphrase]  Enter your passphrase, if you do not enter e passphrase you will be prompted for it.
-s, --smartbridge [smartbridge]  Enter a string for the SmartBridge.
-i, --interactive Prompt to confirm transaction.
-h, --help  output usage information
// TODO implement Ledger support | implement 2nd passphrase

@wownmedia Some conflicts after your other PR was merged.

I will submit a new PR in a minute, please discard this one.


typeahead: Fix typeahead positioning for iOS keyboard case.

When the iOS keyboard is open and up, the positioning gotten by
getBoundingClientRect will display a top value that is short by the
height of the keyboard, which will usually end up placing things north
of the top of the screen.
By changing to jQuery $.fn.offset instead, the positioning appears to
be correct in all cases; iOS keyboard up, down, and desktop usage.
Fixes: #6366.

Merged, after adding a comment as well as the commit message, thanks @brockwhittaker!


create 0560-subarray-sum-equals-k.cs

File(s) Modified: 0560-subarray-sum-equals-k.cs
Language(s) Used: C#
Submission URL: https://leetcode.com/problems/subarray-sum-equals-k/submissions/1033064743/

Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.

This solution already exists.


Find a way to keep multiple versions of a specific section of the documentation

Find a way to keep multiple versions of a specific section of the documentation on README.IO. Useful for SDK versions, and some API versions while it's not ALL the documentation that changes. I think README only allows us to have full documentation version...

Moved to JIRA


[Question] What happens when Eureka instance skips a heartbeat against a Eureka server with self preservation turned off?

I asked this question on stackoverflow. Didn't get much attention (even earned tumbleweed badge). Even added bounty. Still no response. Now posting here.

Consider this set-up:

Eureka server with self preservation mode disabled i.e. enableSelfPreservation: false
2 Eureka instances each for 2 services (say service#1 and service#2). Total 4 instances.
And one of the instances (say srv#1inst#1, an instance of service#1) sent a heartbeat, but it did not reach the Eureka server.

AFAIK, following actions take place in sequence on Server side:

ServerStep1: Server observes that a particular instance has missed a heartbeat.
ServerStep2: Server marks the instance for eviction.
ServerStep3: Server's eviction scheduler (which runs periodically) evicts the instance from registry.

Now on instance (srv#1inst#1) side:

InstanceStep1: It skips a heartbeat.
InstanceStep2: It realizes heartbeat did not reach Eureka Server. It retries with exponential back-off.

AFAIK, the eviction and registration do not happen immediately. Eureka server runs separate scheduler for both tasks periodically.
I have some questions related to this process:

Are the sequences correct? If not, what did I miss?
Is the assumption about eviction and registration scheduler correct?
An instance of service#2 requests fresh registry copy from server right after ServerStep2.

Will srv#1inst#1 be in the fresh registry copy, because it has not been evicted yet?

If yes, will srv#1inst#1 be marked UP or DOWN?

The retry request from InstanceStep2 of srv#1inst#1 reaches server right after ServerStep2.

Will there be an immediate change in registry?
How that will affect the response to instance of service#2's request for fresh registry? How will it affect the eviction scheduler?

I think this question is better posed in the Netflilx Eureka project since it doesnt seem to be specific to Spring Cloud Netfilx.

Posted on Netflix Eureka. If anyone wants to have a go on it, please do.


Error in internal function cowboy_req:do_reply if cookie set before reply is called

Here's a little handler that's supposed to set a cookie:
handler(Req0, State) ->
	NewValue = integer_to_list(rand:uniform(1000000)),
	Req1 = cowboy_req:set_resp_cookie(<<"server">>, NewValue,
		Req0, #{path => <<"/">>}),
	Req = cowboy_req:reply(200, #{
		<<"content-type">> => <<"text/html">>
	}, <<"Hello, world">>, Req1),
	{ok, Req, State)

I tried this with both branch master and 2.0.0-pre.7
The crash I get is

no function clause matching cowboy_req:do_reply(200, #{<<"content-length">> => <<"12">>,<<"content-type">> => <<"text/html">>}, "Hello, world", #{path => <<"/">>,resp_cookies => #{<<"server">> => [<<"server">>,<<"=">>,"836979",<<"; Version=...">>,...]}})

I based it on the cookie example, and I can't see any meaningful difference between my attempt and the example.
2> 12:05:29.669 [error] CRASH REPORT Process <0.330.0> with 0 neighbours exited with reason: no function clause matching cowboy_req:do_reply(200, #{<<"content-length">> => <<"12">>,<<"content-type">> => <<"text/html">>}, "Hello, world", #{path => <<"/">>,resp_cookies => #{<<"server">> => [<<"server">>,<<"=">>,"836979",<<"; Version=...">>,...]}}) line 651 in cowboy_stream_h:proc_lib_hack/3 line 162
2> 12:05:29.669 [error] Lager event handler error_logger_lager_h exited with reason {'EXIT',{{case_clause,[my_http_listener,<0.329.0>,1,<0.330.0>,function_clause,[{cowboy_req,do_reply,[200,#{<<"content-length">> => <<"12">>,<<"content-type">> => <<"text/html">>},"Hello, world",#{path => <<"/">>,resp_cookies => #{<<"server">> => [<<"server">>,<<"=">>,"836979",<<"; Version=1">>,<<>>,<<>>,[<<"; Path=">>,<<"/api/login">>],<<>>,<<>>]}}],[{file,"d:/repos/chatterbeak.dashboard/erlang/_build/default/lib/cowboy/src/cowboy_req.erl"},{line,651}]},{login_handler,do_login,2,[{file,"d:..."},...]},...]]},...}}

It works if I set each response element like this, as in your unit test code. Is the cookie example just not up-to-date wrt 2.0?
init(Req, Opts) ->
	Headers = proplists:get_value(headers, Opts, #{}),
	Body = proplists:get_value(body, Opts, <<"http_handler_set_resp">>),
	Req2 = lists:foldl(fun({Name, Value}, R) ->
		cowboy_req:set_resp_header(Name, Value, R)
	end, Req, maps:to_list(Headers)),
	Req3 = cowboy_req:set_resp_body(Body, Req2),
	Req4 = cowboy_req:set_resp_header(<<"x-cowboy-test">>, <<"ok">>, Req3),
	Req5 = cowboy_req:set_resp_cookie(<<"cake">>, <<"lie">>, Req4),
	case cowboy_req:has_resp_header(<<"x-cowboy-test">>, Req5) of
		false -> {ok, Req5, Opts};
		true ->
			case cowboy_req:has_resp_body(Req5) of
				false ->
					{ok, Req5, Opts};
				true ->
					{ok, cowboy_req:reply(200, Req5), Opts}
			end
	end.

This is a change post 2.0.0-pre.7: https://git.ninenines.eu/cowboy.git/commit/?id=91ae70b06c9cc486ea2c2cf91b94de799ceb53b2
It should work on master (and does here).

But the options are last:
Req1 = cowboy_req:set_resp_cookie(<<"server">>, NewValue, Req0, #{path => <<"/">>}),

Yes because your version is before that change.

Ok, thanks. I thought I was on "master" as well, but maybe I didn't clean out my _build lib properly.

If it's rebar3 it's pretty bad at detecting that you want a newer version, you need to use the command or delete rebar.lock or it won't pick up rebar.config changes.


PublicCloud#remove: Not yet implemented

Removing nodes is not implemented in public clouds (Azure, EC2, GCE) at this time, so the interfaces for doing so should be disabled until the feature is implemented.

When removal of nodes is implemented for public cloud, this can be reverted.


image input strings are inconsistent

Some operations support 'repo' or 'repo:tag' style or 12 character hex ID style, but some do not (queries for example).  Best if the CLI supported a general lookup for any input style wherever an 'image' is an input parameter.

fixed - both input to CLI (--image, contents of file for --imagefile, and input to queries that take image names) are now handled by a single routine that determines the imageId from an input string, and will error if that string is ambigous


Plugin doesnt seem to read info, shows 0 LUX

I had this plugin working wonderfully without issue for ages, recently i went to check via homekit and it shows 0 lux, going into the logs seems to have errors.
I know the app/website has recently changed so i don't know if the API has changed?
here is from the logs:
on start up it says its a remembered accessory and configuring handlers, maybe i need to clear it all first?
[1/2/2022, 1:29:51 PM] [ISolarCloud] Remembered accessory, configuring handlers BXXXXXXX MyUsername
[1/2/2022, 1:29:53 PM] [ISolarCloud] TypeError: Cannot read property 'pageList' of null at ISolarCloudAPI.<anonymous> (/usr/lib/node_modules/homebridge-platform-isolarcloud/src/isolarcloudapi.ts:62:37) at step (/usr/lib/node_modules/homebridge-platform-isolarcloud/dist/isolarcloudapi.js:33:23) at Object.next (/usr/lib/node_modules/homebridge-platform-isolarcloud/dist/isolarcloudapi.js:14:53) at fulfilled (/usr/lib/node_modules/homebridge-platform-isolarcloud/dist/isolarcloudapi.js:5:58) at processTicksAndRejections (internal/process/task_queues.js:97:5) (node:394) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'pageList' of null at ISolarCloudAPI.<anonymous> (/usr/lib/node_modules/homebridge-platform-isolarcloud/src/isolarcloudapi.ts:62:37) at step (/usr/lib/node_modules/homebridge-platform-isolarcloud/dist/isolarcloudapi.js:33:23) at Object.next (/usr/lib/node_modules/homebridge-platform-isolarcloud/dist/isolarcloudapi.js:14:53) at fulfilled (/usr/lib/node_modules/homebridge-platform-isolarcloud/dist/isolarcloudapi.js:5:58) at processTicksAndRejections (internal/process/task_queues.js:97:5) (node:394) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict(see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1) (node:394) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Any help is greatly appreciated,
Thank you and have a wonderful new year/

Hi. Looks like isolarcloud have separated different regions to different servers. I've updated the plugin to include a server parameter. Just set it to the same server name you use on the app. E.g. Australian

oh that's awesome, thank you so much! (all up and running now!!!)


Only run this workflow if the README has been updated

In the templates repo, the update-templates workflow has been updated to accommodate repositories that have main branch rules (like factory_bot). To generate the README dynamically, you’ll need to merge a PR with the README changes. That will trigger the GitHub workflow
The PR won’t be generated if the footer content does not have any differences from the template. The PR will only be opened if there’s an update to the footer snippet.
In this PR, we are limiting this workflow to be triggered only when README changes have been merged to main (where the snippet lives).

Thanks for your patience, @mike-burns this is the follow up of https://github.com/thoughtbot/factory_bot/pull/1630
In summary, some repos have branch protection rules that conflicted with the workflow pushing changes directly to the main branch. In the templates repo, the workflow has been updated to open a PR with the README updates. So it will follow the regular flow of PR -> merge. Thank you!


initialLocation cannot be anything than /

it seems...
A hacky solution with guards (it's also possible to just beamTo on some initialization event) would be to put a BeamGuard on all paths except the desired path (using guardNonMatching) and beamTo it, like this for example:
BeamGuard(
  guardNonMatching: true,
  pathBlueprints: ['/desired/path'],
  check: (context, location) => context.hasThisBeenDoneAlready,
  beamTo: (context) => DesiredLocation(pathBlueprint: '/desired/path'),
),

Please correct me if I'm misunderstanding this but isn't this a specific limitation of the navigator when using route names which are prefixed with '/'?

@CharlyZA-2 yes, I think so too, but am not sure does Navigator 2.0 provide some workaround.
If there's no solution, I will make a workaround in beamer.

Thanks for making this an issue been wondering what was going on for about 30 min .

this was done: https://github.com/slovnicki/beamer/commit/1f53170b601b355852727a75e5c47887032f09fb


Add organizations stream

https://docs.readthedocs.io/en/stable/api/v3.html#organizations

Closed by #296


Tensor.SameChars test has non-deterministic outcomes

Outcome of test cases must be deterministic, not dependent on any random device

I agree that tests should be deterministic.
Here however, I think the problem is not the test, but the TS
implementation. The test is pointing out that TS is returning an unexpected
result.
On Thu, 21 Jan 2021 at 10:34, ajoudaki<EMAIL_ADDRESS>wrote:

Outcome of test cases must be deterministic, not dependent on any random
device
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ratschlab/Project2020-seq-tensor-sketching/issues/29,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOYQLFVJJYU52QGNLCGNFTS27YKDANCNFSM4WMRKYWQ
.

I agree that tests should be deterministic.
Here however, I think the problem is not the test, but the TS
implementation. The test is pointing out that TS is returning an unexpected
result.
On Thu, 21 Jan 2021 at 10:34, ajoudaki<EMAIL_ADDRESS>wrote:

Outcome of test cases must be deterministic, not dependent on any random
device
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ratschlab/Project2020-seq-tensor-sketching/issues/29,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOYQLFVJJYU52QGNLCGNFTS27YKDANCNFSM4WMRKYWQ
.

Fixed by https://github.com/ratschlab/Project2020-seq-tensor-sketching/commit/56f962ea3e870f7df011ae275369be9f45afe373: the constructor had the wrong variable passed in

Fixed by https://github.com/ratschlab/Project2020-seq-tensor-sketching/commit/56f962ea3e870f7df011ae275369be9f45afe373: the constructor had the wrong variable passed in


(maint) Update JSON schema paths

Previously the paths for validating JSON schema templates only worked when running from Rspec tests as they were relative to the root directory of Bolt. This commit handles the paths accordingly.

CLA signed by all contributors.

the schemas directory is not available when installing the pe-bolt-server package. Is this something we have to explicitly add in packaging?
root@j4v2varc0vcgmcr:/opt/puppetlabs/server/apps/bolt-server/lib/ruby/gems/bolt-0.22.0/lib/bolt_ext# ls
puppetdb_inventory.rb  server_acl.rb  server_config.rb  server.rb

Yes. Need to add it to bolt.gemspec.


radio button selection support

Rather than create a separate PR in the andlabs/ui I thought it would be cleaner to include this in your PR as my change needs the updated ui.h too.

Yeah, thanks! LGTM, the only thing that seems missing is a delete in Destroy, otherwise entries in the radioButtons map doesn't get cleared.

Well spotted, I added the fix.

:+1:


[WIP] Disable LTO for TinyEXR

This works around a linker bug, we'll remove this workaround once
binututils fixes a bug.
This fixes #24641

Does not currently work :)

I'll copy this work for my assimp too. Thanks!

This is not going to work, while the symbol hiding problem is solved we now get a different crash.


Enhanced K8s Configuration Script and Support

These changes seek to improve the experience deploying the SAS Egeria Repository Proxy Connector into a Kubernetes environment.
NOTE: These changes also REQUIRE the SAS Egeria Repository Connector BE INSTALLED WITHIN THE VIYA K8S DEPLOYMENT.  This is because the connector is now utilizing K8s service hostname to communicate to SAS Viya services.

Updated K8s deployment YAML to include a PVC to persist the Egeria configuration document
Set the SAS Repository Proxy to have itself automatically restarted using the persisted configuration document
Updated Repository Proxy code to utilize kubernetes service hostnames as we are running  within the Viya deployment
Updated configure.sh to allow overriding the Kafka connection information to permit connecting to remote Egeria event bus
Updated configure.sh to allow specification of a cohort name to permit the connector to join a remote Egeria cohort

Going to try to figure out how to fix the sign-off in the commits.  Trying to follow the recommend rebase solution is resulting in a bunch of scary merge conflicts.


x.lcas.dev is down causing installs using this project to fail

https://deno.land/x/sift@0.4.2/mod.ts?source=#L20

Oops ..  I see that was fixed ,  closing
https://github.com/satyarohith/sift/pull/72


Implement Server Side of Instance Registry API

@johannesduesing I have uploaded the server side on a branch instance-registry-api-server. The server is running. There is a need to implement the functionality in the methods that will be accepting the arguments from the client side.

Hey @Ayybeeshafi , thanks for the work, it does look good for now. I will try to extend that branch so that the JSON serialization is used and the actual Instace-Objects can be accepted as parameters. For now i would like to assign you to #6 , because it involves changing the OpenAPI specification you created.

API fully implemented in #7


Language detection buggy?

The https://graphicore.github.io/mdlFontSpecimen/html/drop-fonts.html page is nice but seems
buggy - i dropped Acme-Regular from github/google/fonts and it says 5 languages

I just pushed a new tool to gh-pages: https://graphicore.github.io/mdlFontSpecimen/html/language-coverage-details.html
There we can see what the language coverage detection is based on. In the lax mode (which we are using) mainly some punctuation is missing for Acme: ("…" U+2026,"†" U+2020,"‡" U+2021)
The lax mode uses a list of chars that we (I) decided is not important enough to break language support, looks like this at the moment:
https://github.com/graphicore/specimenTools/blob/master/lib/services/FontsData.js#L155
    FontsData.DEFAULT_LAX_CHAR_LIST = new Set([
        0x2010 // HYPHEN -> we usually use/include HYPHEN-MINUS: 0x002D
      , 0x2032 // PRIME
      , 0x2033 // DOUBLE PRIME
      , 0x27e8 // MATHEMATICAL LEFT ANGLE BRACKET
      , 0x27e9 // MATHEMATICAL RIGHT ANGLE BRACKET
      , 0x2052 // COMMERCIAL MINUS SIGN
    ]);

The question is of course if we can add all chars that break the fun to the lax-list and still that claim the language is supported. E.g. I personally use the ellipsis regularly but rather never dagger and double dagger.
Acme is now down to 4 languages, because "Root" was removed:


Upload logs to Box when build completes

(Applies to TravisCI logs only.)
Waiting to see if it works in production. This PR should have its logs uploaded.

I experimented with this as well, you're aware that only master will be able to publish its logs?

Yeah, I figured it out eventually :/
Branches in openwhisk/openwhisk would work as expected. Maybe we can
enable that just for those? For situations where everything is fine locally
but Travis fails, we could create such a branch..
Alternatively we can setup some public ftp server.
Only unsatisfactory solutions it seems.
On Sep 16, 2016 02:56, "Markus Thömmes"<EMAIL_ADDRESS>wrote:

I experimented with this as well, you're aware that only master will be
able to publish its logs?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openwhisk/openwhisk/pull/1272#issuecomment-247531334,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAO_K8JZZ2vckNPp1lQMZ3hsvVJn-C3aks5qqj2bgaJpZM4J-RlQ
.

Merged as https://github.com/openwhisk/openwhisk/commit/e33ead32224e1a640c906cd0cfb155dcda44ad7a.


chore modify variant_ratio_of_defaults_as_sparse_column f…

…rom 0.95 to 1
since sparse column is not stable at present
Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

need to change this config to table property


[Frontend] Minor optimizations to zmq decoupled front-end

Avoid copying message bytes (can unpickle directly from the zmq frame)
Split proxy into simpler concurrent inbound and outbound tasks
Use pickle instead of cloudpickle for response messages
Use tuples instead of lists (cpython reuses these)

Still testing but it looks like this might actually give ~100% throughput improvement (!)

The difference doesn't really show up in the standard serving benchmark in the CI tests, I think because that only sends 20 requests and the throughput bottlneeck that this helps with happens when the server is saturated.

Running
python3 benchmarks/benchmark_throughput.py --model meta-llama/Meta-Llama-3.1-8B-Instruct --dataset sharegpt.json --num-prompt 1200 --load-format dummy

on A100 gives about 18 req/sec
Before this PR, running the async engine equivalent using PR https://github.com/vllm-project/vllm/pull/7964:
python3 benchmarks/benchmark_throughput_async.py --model meta-llama/Meta-Llama-3.1-8B-Instruct --dataset sharegpt.json --num-prompt 1200 --load-format dummy

gives about 8.5 req/sec. After this PR the same benchmark gives 15.5 req/sec.
However, @robertgshaw2-neuralmagic found that the relative benefit from this PR is much smaller on H100, and in that case the non-async benchmark is still almost 2x as fast.
In any case these changes seem to be worthwhile and we will track down the next major async overhead in the H100 case.

Nice work!


Remove prop drilling to code-editor

Moved editorFontSize, editorIndentSize, editorKeyMap, editorLineWrapping, editorIndentWithTabs and nunjucksPowerUserMode into mapStateToProps in CodeEditor.
The OneLineEditor previously didn't use the editor* properties, and this PR introduces an ignoreEditorFontSettings prop, used only by the OneLineEditor, to preserve existing behavior.
If the OneLineEditor doesn't send this prop, we see the following behavior when the editorFontSide and interfaceFontSize differ, because of how the component works. In a future PR, we could look to remove this.

@jackkav because this data is already available in redux, reflects the database using the db hooks that exist, and is consumed this way by other locations straight from redux, I didn't look to use the context API in this particular case.
How do you envision the context API being useful for us here?
(I have a follow up PR in which I extract the render and getRenderContext prop drilling, and there's a part in there which uses context because it's something new.)

How do you envision the context API being useful for us here?

Quoting DEVELOPMENT.md

Note: Eventually, Redux could/should be removed

That leaves context api and composition for applying global preferences to multiple child components.

@jackkav we could talk about this sometime but I think transitioning away from Redux will need to be tackled alongside moving away from NeDB. Truth is that right now user preferences are stored in NeDB which is tightly coupled with Redux and it's not worth refactoring away Redux until we know how we intend to tackle NeDB.
If in the current state we were to use the context API, the implementation of the context provider would still need to depend on Redux, which would just add a layer to the onion without much gain (from what I can see).


Fix getDerivedStateFromProps usage

Success!
Using getDerivedStateFromProps properly, this fix passes all existing tests and is a perfect intermediate version prior to react-redux 6.x and 7.x
Fixes #965

(Moving this up to the top level in case another commit hides our thread above)
No worries. Text-based communication is always lossy.
If the polyfill works in 16.0-16.2 (where it's actually active; it's not in 16.3), then I'd have confidence in it working in older versions of React as well.
As for the PR contents itself, I still have concerns about passing props as a hack around the signature of gDSFP (essentially to make it function like cWRP did before). Something there doesn't smell right. At the very least, there's a bug with this.state.props, as they're never updated past instantiation.

You're right, the fact props aren't updated is an issue, and they should be returned from gDSFP, no idea yet if that will affect test failures. I had to be quick this morning, so I may have tested things without polyfill, or with, but it was working no failures 16.0-.4
I'll have time to breathe a bit later, I can check again.

OK, The last commit relaxes the peer dependency, and adds back the storing of props. It would only affect performance on updates, so didn't affect behavior, which is why tests weren't broken. Take a look now?
Storing props in state would normally be a problem, if we were using it to generate derived props, they could be stale. But it is only used to detect changes in props in order to make derived props generation less expensive, so I don't think we will have a problem storing them this way.

I left a few nitpicks stylistically, but code-wise this seems plausible.
I pulled and ran the tests, and it does look like everything's passing.  Sweet!
I'd say it's worth merging and publishing as 5.1.0-test.2 or something.  Let's get it out where people can try it.
@cellog , thanks a lot for collaborating with us on this!  I think we had some nice back-and-forth sharing of ideas here.
Assuming this works, we can start turning our attention to a reworked version of #898 that uses new context.

I had the same thought about onStateChange yesterday afternoon when I couldn't get to a machine, and of course forgot about it by evening. I took a moment to fix the nitpicks.
I think before we merge, it is important to add some more tests, specifically to check for how more than 1 update affects its performance and its correctness, since I had forgotten to save props in gDSFP and adding it in didn't affect any tests.
However, I have a larger issue I'd like to bring up relating to tests. Is there any reason the repo doesn't use enzyme? Also, do you think it would be feasible to make the test suite run against multiple React versions? In my gut, I feel uncomfortable publishing when every test fails in 15.x because the suite can't properly run on my machine (the issue is that react-test-renderer API changed dramatically at 16.x). If the tests were switched to use enzyme, then the change is as simple as:
import React from 'react'
import { configure } from 'enzyme'
import Adapter14 from 'enzyme-adapter-react-14'
import Adapter15 from 'enzyme-adapter-react-15'
import Adapter16 from 'enzyme-adapter-react-16'

if (+React.version.split('.')[0] === 0) {
  configure({ adapter: new Adapter14 })
} else if (+React.version.split('.')[0] === 15) {
  configure({ adapter: new Adapter15 })
} else {
  configure({ adapter: new Adapter16 })
}

If there is no blocker to making this change, I'd like to tackle it.
Also, I use wallaby in my IDE to run the tests instantly (even faster than jest, about .75 seconds to run the whole test suite), could I add my config file (it's generic) to the repo for others who might use it? It doesn't affect anyone who doesn't use wallaby, and could be ignored by npm with .npmignore
If you're cool with the test change, I'll open an issue for tracking the switch to enzyme and copy/paste the 2nd portion of this comment

P.S. enzyme doesn't support the 16.3 context yet, but it can be easily mocked out

I don't know of any specific reason why we've never pulled in Enzyme.  And yes, I'd love to see more tests added!  We've already seen the benefit of our existing test suite - adding more tests to help clarify expected behavior would be extremely valuable.  (It would also be great if we had some comments explaining why some of these current tests exist, but that can be added later.)
I have no idea about the feasibility of targeting multiple React versions with the tests, but it seems like a neat idea if we can do it.
I do find it a bit ironic that the test suite entirely relies on using connect as a decorator, yet we (I?) generally discourage it being used that way.

We haven't pulled in enzyme because we haven't needed it. We would have to rewrite all of our tests to really make use of it. And since the plan is to focus 6.0 on React 16.4+, I don't think we need to worry about targeting multiple React versions. It's a lot of effort that wouldn't have any real advantages.

I don't think converting the tests to enzyme will be hard, I did a similar thing in my own project, with 1200 tests. It took me about 1.5 hours, so I don't anticipate this will take much longer :). In any case, it will allow running the current suite against 14 and 15, which currently doesn't happen. I'll make a PR and you can decide if it's worth it.

Yeah, I see both trains of thought here.  On the one hand, 6.0 would presumably obsolete any checks against React <16.5.  But, wouldn't hurt to have that around for the 5.x branch.  And hey, if @cellog wants to contribute that, I'm not going to argue against free help :)

Incidentally, I think we will find this implementation leaks when an error is thrown in mapStateToProps, because if the error boundary simply discards the tree, we will have subscribed in the constructor.
So I'd like to move all the subscription stuff to cDM and cDU. I think it may even be dangerous to do it with a setState callback because we can't know if the component was unmounted in the mean time, since an error won't call lifecycle methods.
I'm not sure how this affects existing tests, but we'll find out.

I recommend against converting tests to Enzyme. It's been lagging behind React quite a lot.

Oh man, I did not mean to merge these pull requests, I was trying to merge it into a different branch

OK I successfully removed the accidental merge of #984 into this PR so they can be considered separately

The last commit moves subscription out of the constructor, which is async-unsafe, and into componentDidMount.
We need to do some SSR checks to see if react-redux still works there, since subscriptions will never trigger in this design. Perhaps add a check for SSR somehow and do the sub in constructor if so?

fixed nested subs with last commit

So, we appear to have a PR that passes all existing tests as-is, other than the tiny tweak to where we're checking for a store instance.
I'm going to see if I can start putting together a perf benchmark harness, but this may at least be ready for release as a 5.1.0.test-2.

P.S. I do have one concern. Right now, subscription contains parentSub at creation time, and I think this counts as a side effect. However, I think the best path going forward is to get 6.x out as soon as possible, which will remove any possible side effect subscription issues. The subscription to redux is handled properly since we use setState to trigger re-renders on new actions.

I don't think that's too much of a concern.  If a component is created and then thrown away before mounting, its subscription would ultimately get GC'd, and it hasn't produced any lasting changes outside of itself (as far as I understand things atm).  But yes, totally agree that we ought to start aggressively working on 6.0 ASAP.

After discussion with both @cellog and @timdorr , we're leaning towards not putting out a 5.1 release.  Trying to manage lifecycle behavior across multiple React versions is difficult (and apparently the react-lifecycles-compat polyfill uses the 16.3 behavior, not 16.4 , which doesn't help).
I'm currently trying to work on putting together a performance benchmark harness so that we can start comparing comparing behavior between different releases.  From there, I plan to pick up work on #898 , or at least a variation of that approach, and start serious development on a 6.0 release that would probably be 16.5+ only.

@deecewan the problem we encountered is that fixing the issue in gDSFP is incredibly complex, and results in a build about 4 times slower than 5.0.7 when benchmarked. If you stick to 16.3 or lower, the 5.1.0-test.1 will be stable, but it fails spectacularly on React 16.4

@deecewan We're doing a 6.0 release that will target 16.4+ (technically 16.3 too, but I consider that a broken release), so that's essentially what 5.1.0 will become.

@timdorr is there an issue list for the 6.0 release? anything I can help out with?

@deecewan #995 #1000 but especially #983 and the discussion in #890 is also relevant

@deecewan : we don't have a formal issues list for 6.0 yet - we probably ought to start coming up with one.
As @cellog said, right now we've got two different PRs that try to rework connect to use React.createContext(), with varying approaches.  I'm at React Rally this week, and hope to talk to Brian Vaughn and get his feedback on the two implementations.  From there we can hopefully get a better picture of what 6.0 needs to include.
I've also been trying to put together a perf benchmark harness over in #983 .  I'd certainly appreciate some help trying to flesh that out, and officially add it to the React-Redux repo.

I'm on 16.4.1. No StrictMode yet - but I still get warnings in the console that I'm using both gDSFP and cWU (cWU coming from react-redux).

@deecewan that seems unlikely to be a result of using react-redux 5.0, since the warning from react comes from a single class definition, and react-redux 5.0 connectAdvanced does not define gDSFP. Can you elaborate on the warning (or paste a copy) to help understand what's causing it? Is it this warning?
https://github.com/facebook/react/pull/12419

@deecewan : our end goal is that if you're on React 16.4 and React-Redux 5, you should hopefully be able to do a near drop-in upgrade when we finally have v6 ready.  There will be at least a few API differences, but hopefully they'll be small (things like replacing the withRef option with use of React's forwarded refs, etc).


Set Up Development Environment

Android Studio development environment must be set up.
Android Manifest file and Emulator must be set up.

Android Studio enrivonment and Manifest file is set up. Emulator is working.


DSEGOG-349 edit favourite filter

Description
A use should be able to edit a filter name or filter. There should be an error message if the user tries to edit a filter withoud chaning the values
Testing instructions
Add a set up instructions describing how the reviewer should test the code

[ ] Review code
[ ] Check Actions build
[ ] Review changes to test coverage
[ ] {more steps here}

Agile board tracking
closes DSEGOG-349

'

Code looks good, one question is that I think I remember you talking about the cursor position in the filter inputs - does that get changed in a later PR? Because it does look odd to have the cursor at the front in the edit window, as well as the readonly filter inputs in the favourite filters tab let you change the position of the tokens when you click between tokens/use arrow keys after you click on them.

Yeah the first thing mention has been changed in #511. Good spot in the readOnly mode, I didn't realised it did that :joy:. I have fix that in my most recent commit.


Reporting a typo in the manpage of lft command

Hi, I was searching for the manpage of "lft" command when I landed here https://manpages.debian.org/testing/lft/lft.8.en.html.
There is a typo in the spelling of 'service' when explaining the -I flag, in particular when mentioning the full form of ToS. I tried to find a way to fix it myself by opening a PR but I think I am wrong in thinking that this is the repository where it can be fixed, thus reporting it as an issue for some guidance or simply logging the issue.
Thanks

I tried to find a way to fix it myself by opening a PR but I think I am wrong in thinking that this is the repository where it can be fixed

Correct, this is the wrong repository.
In the manpage you read, scroll to the very bottom:

To report bugs, send e-mail to<EMAIL_ADDRESS>
I suggest you send an email.
(I checked on https://packages.debian.org/sid/lft that lft.8 is part of the lft_3.91.orig.tar.gz archive, so the manpage is part of the software, not added by Debian.)


Chapter 10, Exercise 01, first attempt.

First attempt for this question - attempted to make solutions more explanatory (using Euclidian Algorithm) since answers are numerical - not sure about all the norm_num's

Thanks a lot!


How to set enabled o disabled the FineUpload?.

I have an option buttons: Yes and No. If i check "Yes" , I want to set enabled the fineupload, If i check "No" I want to set disabled the fineupload. By default, the option "No" will be selected when the page load.

We have a dialog, where user had to make two choices and upload a file.
The file must not be uploaded without those options chosen.
Since it is an Upload dialog, we want the uploader to be visible in order to visually hint, that the user is on the correct screen. So we need the enable/disable option.
I've tried setting it with jQuery, the uploader renders as disabled, but even then I can upload files. How can I  disable uploading?


Started implementing window vibrancy

Issue #300 proposes adding support for changing window vibrancy/adding acrylic effect. I think this can be done with minimal effort and changes to the existing codebase. While this isn't ready to be merged by far, I think it's a good start and can be worked into a functional update with a few hours more work.

Looking at the window vibrancy crate it looked like in order to apply the effect the code just needs access to the raw window handle.

I've deleted the fork; sorry for being presumptuous. I've updated the pull request to allow the user to obtain the raw window handle for their own usage. It should be functional but I've assumed that the window handle doesn't change over the lifespan of a window.

This looks fine to me. I don't love the name of the function in decorator. raw_window_handle isn't super descriptive but I can't think of anything better.
@dzhou121

This approach feels a bit hacky for me. Ideally it should be one option in WindowConfig, and add the vibrancy support to our winit fork.

I don't think Floem should expose WindowHandle at all


Add an internal enum UserPlatform for web target

For optimal user experience desktop target distinguishes between user OS (for example Ctrl on non-MacOs vs CMD on MacOs). We need it for web too.
This PR adds an enum UserPlatform and UserPlatform.Current property to easily access the OS name.
For now, this code is internal in foundation module. In foundation module, UserPlatform.Current will be used to properly initialise internal actual val platformDefaultKeyMapping: KeyMapping
But beside foundation, I see that similar code would be needed at least in ui:ui and ui:ui-text modules. For now, internal enum class DesktopPlatform is duplicated in those modules. With current approach UserPlatform will need to be duplicated too in jsWasmMain source sets of ui and ui-text.
We can avoid duplication:

by making the enum public (ui depends on foundation)
by moving it to skiko, like we did with some other things we wanted to reuse. It will be public too.
@igordmn What do you think?

By the way, we already expose hostOs in skiko, which I've been using.

By the way, we already expose hostOs in skiko, which I've been using.

Nice. For now, it's desktop only.
The simplest option is to add a web only property too. At least until we have a use case where it's useful in a common (skikoMain) code.

hostOs should be available in common:

The story with DesktopPlatform is complicated (it was public before). UserPlatform is similar to it, so it is complicated too :).
The easier option will be to reuse hostOs from Skiko. At least for now. There is a conversation to make Skiko implementation details of the ui and ui-text modules, and don't propagate it to foundation and to external users (but this converstation is for the future).

Closing this PR. Moved the change to skiko: https://github.com/JetBrains/skiko/pull/738


Check links in the README as part of the CI/CD

Summary
As a followup to #1013, we can avoid this situation by adding an action to check the links in the README.md using something like https://github.com/gaurav-nelson/github-action-markdown-link-check in our workflow.
It would not block merges, but allow us to catch stale links faster without waiting for users to stumble on them

seems like it was closed by https://github.com/openfga/openfga/pull/1016


WIP Docker shell

experimental dockerShell step
command arg parser
attempt to have list of creds (blocked by docker-java now)
image pulling with verbose logging
new fields

This change is

Codecov Report

Merging #178 into master will decrease coverage by 1.4%.
The diff coverage is 6.61%.

@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
- Coverage     21.27%   19.87%   -1.41%
- Complexity      217      223       +6
============================================
  Files            58       63       +5
  Lines          2397     2642     +245
  Branches        209      238      +29
============================================
+ Hits            510      525      +15
- Misses         1831     2059     +228
- Partials         56       58       +2

Impacted Files
Coverage Δ
Complexity Δ

...a/yad/credentials/DockerDaemonFileCredentials.java
7.4% <ø> (-3.31%)
0 <0> (ø)

...github/kostyasha/yad/DockerContainerLifecycle.java
75% <ø> (ø)
13 <0> (ø)
:arrow_down:

...va/com/github/kostyasha/yad/DockerSlaveConfig.java
67.24% <ø> (+1.66%)
17 <0> (-1)
:arrow_down:

...github/kostyasha/yad/utils/ResolveVarFunction.java
0% <0%> (ø)
0 <0> (?)

...java/com/github/kostyasha/yad/DockerConnector.java
45.91% <0%> (-1.96%)
15 <0> (ø)

.../github/kostyasha/yad/commons/DockerPullImage.java
33.33% <0%> (-10.57%)
8 <1> (+1)

...ain/java/com/github/kostyasha/yad/DockerCloud.java
11.89% <0%> (+0.06%)
9 <0> (ø)
:arrow_down:

.../com/github/kostyasha/yad/utils/VariableUtils.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...yad/launcher/DockerComputerSingleJNLPLauncher.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...a/com/github/kostyasha/yad/commons/DockerExec.java
0% <0%> (ø)
0 <0> (?)

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe00b78...2a63645. Read the comment docs.


Partnership Intensity Analysis

Scatterplot that shows the number of projects on the x-axis and has the Y-axis as a variable you can choose from:

Number of Different Engagement Types
Years of Engagement
Number of Distinct Campus Partners
Interdisciplinary Score

Color coded by mission area of partners. Hover over functionality
Usual filters
HIGH Priority

Here is more information.  Need to complete ticket 1546 first.
This will be part of the intensity analysis. One of the variables that we are interested in looking at is timeframe. I would like it to be the following (please note the actual titles may change, but the logic should be relatively stable):
o	Short-term interaction (this should be if there was one event)
o	Reoccurring short-term interactions (this should be if there were multiple events associated with the community partner)
o	Short-term partnership (projects, that are not identified as events – that are one semester or one year)
o	Long-term partnership (one project that occurs over multiple years OR project that is reoccurring over multiple years)
o	Sustained partnerships (multiple projects/events occurring over multiple years with the community partner)

@ruhidamda Don't worry about plotting campus partners.
Color coding should match what is in the maps for primary mission area of community partner.  Primary mission for color coding only.
If easy, do variable for x and make projects the default.  This is the number of projects.
Each community partner is only plotted once.  Keep as a scatter plot.  Have a  cross with the median
Interdisciplinary Score - This would be based on the number of subcategories the community partners have.  If only 1 for all projects, lower score.  If more subcategories, the score is higher.
Also, if you have something to show early and want Keristiena to give feedback to help with little things, let her know.

@wlcobb Thank you Wendy. I will try to create a sample so we can get feedback early on


Merge pull request #1 from twbs/master

Master

Hi @wsycysdrhpa!
Thanks for wanting to contribute to Bootstrap by sending this pull request!
Unfortunately, your pull request seems to have some problems:

The title of this pull request strongly suggests that you were using Bootstrap to test out Git or GitHub, rather than proposing a legitimate change. If that's accurate, please DON'T do that again! Instead, use your own personal repositories to experiment with how to use Git or GitHub. Using the repos of public projects (such as Bootstrap) for such experiments wastes the time of those projects' maintainers and is thus considered rude.

You'll need to fix these mistakes and revise your pull request before we can proceed further.
Once you've fixed these problems, you can either ask the maintainers to re-open this pull request, or you can create a new pull request.
Thanks!
(Please note that this is a fully automated comment.)

Please don't test on public repos!  Not helpful to anyone 😟


Enforce root layout container to be always present

What
Previously, it was possible to end up without a root blueprint container which can cause weird ui behavior like not being able to add space views.
This is now solved by making up a root container upon reading the blueprint layout from the data store.
(Review with whitespace diff disabled!)
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[ ] I have tested the web demo (if applicable):

Using newly built examples: rerun.io/viewer
Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!

PR Build Summary
Recent benchmark results
Wasm size tracking

looks like some examples stop working with this!

Issue is getting fixed elsewhere in a more simple fashion now!
We still want this changeset, but we'll do this in combination with removing the auto_layout flag since this causes other issues right now - the blueprint tree becomes non-empty causing auto layout to no longer do an initial population.

On a previous iteration with this some examples stopped working according to notes. Need to check if that's still the case


mount: replace mountinfo handling with moby/sys/mountinfo

Trying to reduce duplicated effort in maintaining a mountinfo parser, this patch replaces the local implementation with the implementation in github.com/moby/sys, which is actively maintained and contains various optimizations.
~Using a temporary vendor, pending https://github.com/moby/sys/pull/32 and https://github.com/moby/sys/pull/34~ merged
~With this change, the only consumer of mount.Self() is containerd/cri. mount.PID() looks to be unused altogether, so both could potentially be removed if containerd/cri is updated.~ removed

But it brings new dependencies into containerd 😂

New dependencies, but fewer total lines of code? "+5,059 −8,426" ❓ 😂

New dependencies, but fewer total lines of code? "+5,059 −8,426" ❓ 😂

Yeah, most of that is currently because of golang.org/x/sys and containerd/console. If we tag a new release of containerd/console, I can vendor it separately (nudge nudge 😉)

Moving this out of draft; removed the remaining uses in the CRI code now that it was integrated
@estesp @kolyshkin @cpuguy83 PTAL

@thaJeztah thanks for working on this! LGTM overall, maybe makes sense to squash the first two (or three?) commits.

@kolyshkin I added the prefix-filter, and removed the local prefix checks; kept it as a separate commit for easier reviewing, but I can squash.

IOW this function can be replaced with unix.Umount(target, unix.MNT_DETACH) (or mount.UnmountAll(target, unix.MNT_DETACH))

Do you think we should replace it here? (mostly wondering if the current logic was addressing specific (corner) cases)

Rebased to get a fresh run of CI
@AkihiroSuda @estesp @kolyshkin @cpuguy83 PTAL

Rebased to get a fresh run of CI
@AkihiroSuda @estesp @kolyshkin @cpuguy83 PTAL


feat(wasm-dpp): provide external entropy generator to document factory

Issue being fixed or feature implemented

PR addresses next issues:

Need to provide external entropy generator to Document Factory (needed for JS)
Proper error handling for entropy generator (need to know what's going on in case external generator fails to produce entropy)

What was done?

Return Result instead of panicking in generate() function
Add entropy generator as an argument to DocumentFactory
Refactor entropy generator file structure
Update JS fixture

How Has This Been Tested?

CI

Breaking Changes

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

Agreed to refactor Box<dyn EntropyGenerator> in a separate ticket


Enhancing Repository with Better Infrastructure and Collaboration Tools

Description:
The current state of the repository is somewhat minimal and lacks certain features that enable smooth and consistent collaboration.
Expected Functionality:

Automatic syntax and layout checks.
Automated testing setup.
Enforced consistent naming conventions.
Clear and standardized issue templates.
Well-defined rules for PRs.
Clear Documentation

Proposed Solution:
To address these issues, we propose the following enhancements:

Configuring the repository settings to ensure better collaboration and project management.
Incorporating pre-commit hooks for automatic syntax and layout checks.
Providing test cases and implementing a setup for automatic testing.
Establishing GitHub Actions for both testing and running pre-commit checks.
Designing and implementing clear issue templates to standardize issue reporting.
Defining and documenting clear rules and guidelines for PRs.

@Lauenburg I added a workflow that pushes a new image to docker hub, whenever version.txt is changed. This will become important once we deploy our docker images.

Addressed with PR #81 and added issue templates manually.


Flatpickr field focus requires multiple clicks to activate

This issue is caused by the fix for https://github.com/chmln/flatpickr/issues/821
If you open Flatpickr, and then click out of the input, the input is not unfocused. You must click a second time outside of the input to remove focus before you can reactivate the picker.
I think it feels clunky when switching back and forth between multiple flatpickr inputs. Did you have a different way of handling this in mind when you made this change that you could share? Or is this unintentional and may it be fixed?
Video:
https://cl.ly/2t1z3O07131Y

Hello,
I have noticed this issue myself and am happy to let you know its fixed in v3.
https://chmln.github.io/flatpickr/examples/

Ah. Didn't even know v3 was out! Looks like it hasn't been tagged on GitHub. Thanks for the update. Just tested and it works now, and fixes several other time-zone related idiosyncrasies as well.
Thanks again @chmln !


fix(client): fix RouteLink path resolve

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.08%) to 41.683%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/client/src/components/RouteLink.ts
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
685

Relevant Lines:
1685

💛  - Coveralls

Maybe add some e2e cases?

Done @meteorlxy


Remove Materialize And Jquery

We have some dependencies to jquery that should be removed, similar to how it was done linkdrops :)

Kept Materialize, but removed Jquery as of 059f1044aa71fd75b82d1bf5518645ff89b2ed88