New package: NTKERNEL.WiresockVPNClient version 1.2.37

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

Automatic Validation ended with:

2024-02-01T22:09:41.3915172Z ##[error] One or more errors occurred. (Manifest: The manifest file path must match PackageIdentifier and PackageVersion properties from manifest. actual 'manifests\n\NTKERNEL\WiresockVPNClient\1.2.37', expected 'manifests\n\NTKERNEL\WireSockVPNClient\1.2.37') Manifest: The manifest file path must match PackageIdentifier and PackageVersion properties from manifest. actual 'manifests\n\NTKERNEL\WiresockVPNClient\1.2.37', expected 'manifests\n\NTKERNEL\WireSockVPNClient\1.2.37'

(Automated response - build 694.)


Missing pads on render of KiCad demp USB stick

Describe the bug
I tried to use it to output an image from a gerber file, attached. However, the pads are not showing in the gerber file. the gbr file is from  Kicad demp usb stick.

Could you please provide Gerber source file?
You can attach it to a comment.

It's is kicad demo files, that I have attended in my original post.

Ok, I understand, but I don't know which file and how to find it. Please either attach it to comment or link to online resource containing Gerber source code.

Please find attached the zip folder for the Gerber files. I attached them in my original post, however GitHub decided to convert it into an image. sorry about that
USB Stick.zip

Lovely, I will look into it soon. Thanks for reporting this issue.
Last small thing, can you tell me if you were using command line or Python API interface?

I was using python API interface in a python file.

Unfortunately it does not support drill files.
I will look into that after readching PyGerber 3.0

Ok, from what I see it should work with next release of PyGerber with APIv2.
Currently you can check it out by installing development version of PyGerber:
pip install pygerber@git+https://github.com/Argmaster/pygerber

Here is a code which uses mentioned APIv2:
from __future__ import annotations

from pathlib import Path

from pygerber.gerberx3.parser2.parser2 import Parser2
from pygerber.gerberx3.renderer2.raster import (
    ImageFormat,
    PixelFormat,
    RasterFormatOptions,
    RasterRenderer2,
    RasterRenderer2Hooks,
)
from pygerber.gerberx3.tokenizer.tokenizer import Tokenizer

SOURCE = Path(
    "<path-to-grb-file>",
).read_text()

def render() -> None:
    stack = Tokenizer().tokenize(SOURCE)
    cmd_buf = Parser2().parse(stack)
    ref = RasterRenderer2(RasterRenderer2Hooks(dpmm=100)).render(cmd_buf)
    ref.save_to(
        "output.png",
        RasterFormatOptions(image_format=ImageFormat.PNG, pixel_format=PixelFormat.RGB),
    )

if __name__ == "__main__":
    render()

While checking it out please make sure to replace "<path-to-grb-file>" with real local path to file :D


Make the scan area of on Windows more larger

Currently, the scan area on windows only suitable for barcode. Can you make it square when we change scanType to ScanType.qr?

@tringuyen53 It is little more complicated then just setting ScanType.qr since It uses different mechanism for web and mobiles. I will look into it.

Hi tringuyen53, where you able to get the scanner to work on desktop app? The camera opens for mine but nothing at all happens when I put my QRCode in front of the camera to read. Where you able to solve this?
Please let me know

Hi tringuyen53, where you able to get the scanner to work on desktop app? The camera opens for mine but nothing at all happens when I put my QRCode in front of the camera to read. Where you able to solve this?
Please let me know

I think because of the scanning area is a bit small, I have to folk the repo to adjust the scanning area and it works for me.

Where in the code do I charge the scanning area please?
Thanks
On Wed, Mar 13, 2024, 16:30 Tri Nguyen Duong @.***>
wrote:

Hi tringuyen53, where you able to get the scanner to work on desktop app?
The camera opens for mine but nothing at all happens when I put my QRCode
in front of the camera to read. Where you able to solve this?
Please let me know
I think because of the scanning area is a bit small, I have to folk the
repo to adjust the scanning area and it works for me.
—
Reply to this email directly, view it on GitHub
https://github.com/CodingWithTashi/simple_barcode_scanner/issues/37#issuecomment-1994668654,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK4FUFEDH5NWRK4MNYCHSU3YYBWGTAVCNFSM6AAAAAA7Y57SQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGY3DQNRVGQ
.
You are receiving this because you commented.Message ID:
@.***>

Where in the code do I charge the scanning area please? Thanks
…
On Wed, Mar 13, 2024, 16:30 Tri Nguyen Duong @.> wrote: Hi tringuyen53, where you able to get the scanner to work on desktop app? The camera opens for mine but nothing at all happens when I put my QRCode in front of the camera to read. Where you able to solve this? Please let me know I think because of the scanning area is a bit small, I have to folk the repo to adjust the scanning area and it works for me. — Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK4FUFEDH5NWRK4MNYCHSU3YYBWGTAVCNFSM6AAAAAA7Y57SQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGY3DQNRVGQ . You are receiving this because you commented.Message ID: @.>

https://github.com/CodingWithTashi/simple_barcode_scanner/blob/main/lib/assets/barcode.html
You can try to change line 45,46. The width height of the qrbox

Actually this should be default behaviour that you can set the parameters of the scan area. It's much too small for scanning QR codes with web camera on some devices. Here is some generated (unreviewed) code from ChatGPT, I hope one day something like this will get implemented into the library.
First, define parameters in your Dart code
class BarcodeScanner extends StatelessWidget {
  // Other code...

  final int qrBoxWidth;
  final int qrBoxHeight;

  const BarcodeScanner({
    Key? key,
    // Other parameters...
    required this.qrBoxWidth,
    required this.qrBoxHeight,
  }) : super(key: key);

  @override
  Widget build(BuildContext context) {
    // Other code...
  }
}

Then, pass these parameters to the HTML code embedded in the iframe
final html.IFrameElement iframe = html.IFrameElement()
  ..src = '${PackageConstant.barcodeFileWebPath}?width=$qrBoxWidth&height=$qrBoxHeight'
  // Other code...

In your HTML code, you need to parse these parameters and use them to configure the size of the scanning area
const queryString = window.location.search;
const urlParams = new URLSearchParams(queryString);
const qrBoxWidth = parseInt(urlParams.get('width'));
const qrBoxHeight = parseInt(urlParams.get('height'));

const config = {
    fps: 10,
    qrbox: {
        width: qrBoxWidth || 280,
        height: qrBoxHeight || 120,
        aspectRatio: 1.7777778
    }
};

Where in the code do I charge the scanning area please? Thanks
…
On Wed, Mar 13, 2024, 16:30 Tri Nguyen Duong @.> wrote: Hi tringuyen53, where you able to get the scanner to work on desktop app? The camera opens for mine but nothing at all happens when I put my QRCode in front of the camera to read. Where you able to solve this? Please let me know I think because of the scanning area is a bit small, I have to folk the repo to adjust the scanning area and it works for me. — Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK4FUFEDH5NWRK4MNYCHSU3YYBWGTAVCNFSM6AAAAAA7Y57SQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGY3DQNRVGQ . You are receiving this because you commented.Message ID<EMAIL_ADDRESS>
https://github.com/CodingWithTashi/simple_barcode_scanner/blob/main/lib/assets/barcode.html You can try to change line 45,46. The width height of the qrbox

how do i change this when i am using the plugin from pub. dev

Where in the code do I charge the scanning area please? Thanks
…
On Wed, Mar 13, 2024, 16:30 Tri Nguyen Duong @.> wrote: Hi tringuyen53, where you able to get the scanner to work on desktop app? The camera opens for mine but nothing at all happens when I put my QRCode in front of the camera to read. Where you able to solve this? Please let me know I think because of the scanning area is a bit small, I have to folk the repo to adjust the scanning area and it works for me. — Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK4FUFEDH5NWRK4MNYCHSU3YYBWGTAVCNFSM6AAAAAA7Y57SQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGY3DQNRVGQ . You are receiving this because you commented.Message ID<EMAIL_ADDRESS>
https://github.com/CodingWithTashi/simple_barcode_scanner/blob/main/lib/assets/barcode.html You can try to change line 45,46. The width height of the qrbox

how do i change this when i am using the plugin from pub. dev

Follow the steps from this guy then just edit the local files. https://www.youtube.com/watch?v=Tms6TUIQVzE&t=311s
This guy uses macOS but I use windows so cached packages should be at %LOCALAPPDATA%\Pub\Cache just and paste at dir input.


Make stable/0.3 compatible with JAX 0.4.0

Summary
Reproduction of #162 for stable 0.3.

Not sure why this is failing but #162 passed, given that stable/0.3 does work for all JAX versions < 0.4.0.


Unmarshaler for additionalProperties with value true incorrect

I believe the unmarshaler for additionalProperties when {"additionalProperties": true} is incorrect because the unmarshaler only unmarshals properties stated in properties:
https://github.com/grktsh/python-oas/blob/e6cc018a6f5150ff5eaca1a44adabfc818d5be55/src/oas/schema/unmarshalers.py#L79
If {"additionalProperties": true} all remaining properties not stated in properties or matched by patternProperties (see #6) should be extracted without a schema, too.

Fixed by #9


DPL-671 - Prevent hidden tag sets from being used

Closes #920
Changes proposed in this pull request

Tag sets now have an active attribute that defaults to true, along with a method to set the value
Only active tag sets are returned by the API

Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

One thing I wanted to ask about is that rubocop made me change the setter method to something that isn't set_attribute, what's the standard in Ruby or across projects here?


Map Tracker Logic - Reset Should Only Be Done Once

I applied a quick hotfix in 7f3e7234 that fixed a reported issue where json loading would hang the page. This is due to how page resets work in general at the moment.
A longer term solution needs to be put in place, this hotfix also breaks map tracker logic resets, as anything that was previously set accessible does not get reset. The main issue was the frequency of getAvailableChecks being called for as heavy of a function as it is. On a page reload, this function was getting called many hundreds of times.

After playing through a seed earlier, even with just clicking on things in the tracker there is a fairly noticeable delay. getAvailableChecks needs some optimization work.


Create a load model for latent cooling load (humidity model)

The goal could be a model analogue to the thermal RC-model with humidity resistance and capacitance.
This issue is specially relevant for the Singapore (hot+humid climate).
This issue needs some research prior to implementation.
@adam-rysanek from 3for2 might be consulted for the present state of the art of humidity modeling.

This will be tackled at the end of the WP1 of Shanshan's research (planned timeline: Nov 2017).

@shanshanhsieh and @JIMENOFONSECA
I'm closing this old issue.
it is solved for now by the issues in epic #811


Add ability to download pypy2.7 for macos and add CI

change the pydrofoil-from-sail CI run to run on both ubuntu and macos
add a python script to print which tarball to download
tweak the user-facing build documentation

CI will run x86_64 darwin, I checked that the Makefile works with arm64 darwin.

At some point we might think about running the build CI only when we have a particular label to save a few CI cycles

looks great, thank you! and agreed about running CI less often. (at the minimum we should be better at adding [skip ci] to the commit messages where it doesn't matter)
we should maybe document the need for having a python3 installed now, on the building_pydrofoil.md page.

errors with "/pypy_binary/bin/python: cannot execute binary file" :-( I suspect that this is the binary signing problem?

maybe this would help: https://github.com/ninja-build/ninja/issues/1695

the test summarizer was broken because of the changes in the xml names, I tried to fix it.

I'm merging now, will fix potential problems with the test summarizer afterwards. Thanks Matti :blush:!


Crawl https sitemap with http urls

Hi Pascal,
how can I crawl a sitemap with is reachable with https but contains urls with http. Norconex is not identifying any startURLs in that case.
I tried already setting lenient to true
<sitemapResolverFactory ignore="false" lenient="true" class="com.norconex.collector.http.sitemap.impl.StandardSitemapResolverFactory">
      <path></path>
</sitemapResolverFactory>

As well as stayOnProtocol to false
<startURLs stayOnDomain="true" stayOnPort="true" stayOnProtocol="false">
        #parse("./shared/startUrls-sitemap.xml")
</startURLs>

Any other recommendations?
Best regards
Sascha

I would try stayOnPort="false" given https is on 443.

No difference with stayOnPort="false"

Have you tried using GenericURLNormalizer and convert the said URLs to https with the secureScheme normalization?

same issue here.
secureScheme helps with such sites, but unfortunately it cannot be used globally, as we have to crawl many unsecured sites too.
Any suggestions? Thanks!

That is a tough one because any URLs, even within the same site, might be supporting different schemes: http, https, or both.
We could investigate a new feature that always tries the "preferred" scheme first,  and if failing, falling back to the other.  But for some sites, it could pretty much double the number of "hits" on the server.
My preference would be to encourage identifying those sites instead and handle them separately, in their own crawler config let's say.  It may not always be the most realistic, but preferable when possible.
If you have better options, I would like to hear them.

I thought about this again - actually, the case should be straight forward: if a link from the sitemap is an HTTP-one, and the site returns a redirect to HTTPS, then the crawler should just follow it as does, when it accesses the site not via sitemap's URLs.
Why does it behave differently when the links are from the sitemaps?
Thanks!


Update FAQ items to match Figma (#473)

Closes #473

Fix FAQCard list item internal and external spacing

Update expanded AccordingSummary colors

Should be "AccordingSummary" not "AccordingSummary"
Side effect of late night commits

AccordionSummary


[Swift] empty string highlighting problem

if you go to https://codemirror.net/mode/swift/index.html and put in this:
print("")
print("")asdfadsfkjdsf//dsfsdfsdf

You'll find that the close parens and all the characters afterwards are highlighted like strings, which seems wrong:

I'm not actively maintaining the Swift mode, so the quickest way to get this fixed would be a pull request.

No prob. We'll try to make some time to figure this one out.


9.0.1 + python 3.9.4 :: module 'websockets' has no attribute 'client'

@aaugustin  Hi! I just noticed on my dev machine (where the websockets was not upgraded before) that using websockets.client.WebSocketClientProtocol as the type returned by websockets.connect is no longer correct (or it never was but is was ignored..) as it throws things like:
File "/home.hdd/adrian/work-GRID/jalien_py/alienpy/alien.py", line 385, in <module>
async def IsWbConnected(wb: websockets.client.WebSocketClientProtocol) -> bool:
File "/home/adrian/.local/lib/python3.9/site-packages/websockets/imports.py", line 96, in __getattr__
raise AttributeError(f"module {package!r} has no attribute {name!r}")
AttributeError: module 'websockets' has no attribute 'client'

so, what is the correct type returned by connect?
also, do you have any idea why on python 3.6.8 this (websockets 9.0.1) still works but on 3.9 it does not?
Thank you!!

oh, and also i get e message module 'websockets.extensions' has no attribute 'permessage_deflate'
my usage being:
deflateFact = websockets.extensions.permessage_deflate.ClientPerMessageDeflateFactory(compress_settings={'memLevel': 6},)
wb = await websockets.connect(fHostWSUrl, sock = socket_endpoint, server_hostname = host, ssl = ctx, extensions=[deflateFact, ],
max_queue=QUEUE_SIZE, max_size=MSG_SIZE, ping_interval=PING_INTERVAL, ping_timeout=PING_TIMEOUT, close_timeout=CLOSE_TIMEOUT)

i really do not understand what was changed ...

actually this last one was solved by:
-import websockets.extensions
+from websockets.extensions import permessage_deflate

and
- deflateFact = websockets.extensions.permessage_deflate.ClientPerMessageDeflateFactory(compress_settings={'memLevel': 6},)
+ deflateFact = permessage_deflate.ClientPerMessageDeflateFactory(compress_settings={'memLevel': 6},)

In Python, you cannot rely on the fact that import a makes a.b or a.b.c available, even if you can import a.b or import a.b.c. If you're going to use an object from a.b.c, then you need to import a.b.c.
Here's an example of this in the standard library:
>>> import logging
>>> logging.handlers
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'logging' has no attribute 'handlers'
>>> import logging.handlers
>>> logging.handlers
<module 'logging.handlers' from<EMAIL_ADDRESS>
import websockets used to import all modules the library even if you used just the client or just the server — few projects need both. It's a bad choice I made super early in the project, and it's getting worse as I'm adding more modules.
This is why it was possible to use e.g. websockets.client after import websockets. However, you were relying on an implementation detail here.
It's considered OK in Python to move things around as long as imports continue working. Import compatibility is the baseline for backwards compatibility.

@aaugustin ok, i see .. so, could please advise me what is the proper usage? should i also do from websockets import connect as ws_connect ?
also, if i do the exception treatment and i have except websockets.exceptions.ConnectionClosed as e: what should i do instead?  import websockets.exceptions as ws_exceptions and then do except ws_exception.ConnectionClosed ?
as for return type i do not thing that i really need to specify so this i will just skip...
Thanks a lot for info and pointers!! :)

Most public APIs of websockets are exposed directly in the root websockets module.
Intended usage is either:
import websockets
websockets.connect
websockets.ConnectionClosed

or:
from websockets import connect, ConnectionClosed
connect
ConnectionClosed

You don't need aliases unless you have name conflicts.


Made command parameter expression binding no longer require ViewModel to exist at time of Binding

Made command parameter expression binding no longer require ViewModel to exist at time of Binding
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
It changes it so that the view model is no longer required when you pass in a expression for the Parameter on the View Model for BindCommand()
This relates to bug 1165
What is the current behavior? (You can also link to an open issue here)
If you have a null ViewModel at time of registration (eg your control is created but the view model is set later on) it will crash due to the viewModel.WhenAnyValue() causing a Null Exception
What is the new behavior (if this is a feature change)?
It uses the ViewModel property expression binding instead which binds the the View's VM rather than the directly to the VM. This uses the existing Reflection.Rewrite and Reflection.ViewModelWhenAnyValue to generate the observable to the parameter binding.
What might this PR break?
Potentially the parameter passing to the command.
Please check if the PR fulfills these requirements

[X] The commit follows our guidelines: https://github.com/reactiveui/reactiveui#contribute
[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

Other information:
Tests added to check for delayed VM setting.

@glennawatson,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Changes Unknown when pulling 75a8a40aea98f3b836ed2fa5570c36eb18c884ad on glennawatson:develop into ** on reactiveui:develop**.

Changes Unknown when pulling be8afaa690fc74db495a15b802a4e2b20dba8ccf on glennawatson:develop into ** on reactiveui:develop**.

Changes Unknown when pulling be8afaa690fc74db495a15b802a4e2b20dba8ccf on glennawatson:develop into ** on reactiveui:develop**.

Changes Unknown when pulling abc266911f1c059d1bfdb7e629f442a266009bdd on glennawatson:develop into ** on reactiveui:develop**.

Sure will make the changes tonight for you.. That's odd I'm not getting notifications about the change requests.

Changes Unknown when pulling 826a2a6412a0b61a277cbbb2e6ae277a8c300f55 on glennawatson:develop into ** on reactiveui:develop**.

Changes Unknown when pulling 3cac06a4468ca255907028bee80b9948892076b2 on glennawatson:develop into ** on reactiveui:develop**.


Update the tests table, in accordance with CI and my local development setup

Closed in favour of a PR that deletes this table


Error cloning remote repo on test-osuosl-aix72-ppc64-2

To make it easy for the infrastructure team to repeat and diagnose, please
answer the following questions:

test suite/name?
ALL tests affected, can not git clone test material on this machine

Is there an existing issue elsewhere covering this? No

Which machine(s) does it work on?

Which machine(s) does it fail on?
test-osuosl-aix72-ppc64-2

Do you have a link to a Grinder re-run if the test with the failure?

Weekend test jobs that landed on this machine failed immediately due to not being able to setup test material

See all:
https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_sanity.functional_ppc64_aix/156/console
https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_extended.functional_ppc64_aix/156/console
https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_special.functional_ppc64_aix/36/console
https://ci.adoptopenjdk.net/job/Test_openjdk8_hs_sanity.system_ppc64_aix/208/console
Grinder job that tests a short running test target (LABEL=test-osuosl-aix72-ppc64-2):
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1115
Any other details:
The recommended git tool is: git
No credentials specified
Cloning the remote Git repository
Cloning repository https://github.com/adoptium/aqa-tests.git
 > git init /home/jenkins/workspace/Test_openjdk8_hs_sanity.system_ppc64_aix/aqa-tests # timeout=10
ERROR: Error cloning remote repo 'origin'
hudson.plugins.git.GitException: Could not init /home/jenkins/workspace/Test_openjdk8_hs_sanity.system_ppc64_aix/aqa-tests
	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$5.execute(CliGitAPIImpl.java:994)

Looks like again this is the JDK16/J9 extended system test generating multiple 10GB core dump files and chewing all the disk space:
/home/jenkins/workspace/Test_openjdk16_j9_extended.system_ppc64_aix/aqa-tests/TKG/output_16263244194946/SC_Softmx_JitAot_0/20210715-015031-SharedClassesWorkloadTest_Softmx_Increase_JitAot/results
# ls -ld *dmp
-rw-r--r--    1 jenkins  staff<PHONE_NUMBER> Jul 15 01:52 core.20210715.015127.25035096.0001.dmp
-rw-r--r--    1 jenkins  staff<PHONE_NUMBER> Jul 15 01:52 core.20210715.015127.25035096.0004.dmp
-rw-r--r--    1 jenkins  staff<PHONE_NUMBER> Jul 15 01:52 core.20210715.015200.25035096.0009.dmp
#

Looks like again this is the JDK16/J9 extended system test generating multiple 10GB core dump files and chewing all the disk space

Yeah, I think the failed tests from https://ci.adoptopenjdk.net/view/Test_system/job/Test_openjdk16_j9_extended.system_ppc64_aix/101/console must have generated those files
07:51:00  FAILED test targets:
07:51:00  	SC_Softmx_JitAot_0
07:51:00  	SC_Softmx_JitAot_1
07:51:00  	SharedClasses.SCM01.SingleCL_0
07:51:00  	SharedClasses.SCM01.SingleCL_1
07:51:00  	SharedClasses.SCM01.MultiCL_0
07:51:00  	SharedClasses.SCM01.MultiCL_1
07:51:00  	SharedClasses.SCM01.MultiThread_0
07:51:00  	SharedClasses.SCM01.MultiThread_1
07:51:00  	SharedClasses.SCM01.MultiThreadMultiCL_0
07:51:00  	SharedClasses.SCM01.MultiThreadMultiCL_1
07:51:00  	SharedClasses.SCM23.SingleCL_0
07:51:00  	SharedClasses.SCM23.SingleCL_1
07:51:00  	SharedClasses.SCM23.MultiCL_0
07:51:00  	SharedClasses.SCM23.MultiCL_1
07:51:00  	SharedClasses.SCM23.MultiThread_0
07:51:00  	SharedClasses.SCM23.MultiThread_1
07:51:00  	SharedClasses.SCM23.MultiThreadMultiCL_0
07:51:00  	SharedClasses.SCM23.MultiThreadMultiCL_1

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1147/ did not show the same failure on the machine. Would be good to identify how repeatable this failure is - if at all.

40 iterations of that test on test-osuosl-aix72-ppc64-2 passed at https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1148.
Now running the extended suite on the machine again at https://ci.adoptopenjdk.net/view/Test_system/job/Test_openjdk16_j9_extended.system_ppc64_aix/104/

Looks to have been ok at https://ci.adoptopenjdk.net/view/Test_system/job/Test_openjdk16_j9_extended.system_ppc64_aix/112/ and https://ci.adoptopenjdk.net/view/Test_system/job/Test_openjdk16_j9_extended.system_ppc64_aix/112/ and https://ci.adoptopenjdk.net/view/Test_system/job/Test_openjdk16_j9_extended.system_ppc64_aix/114 on the machine.

Space looks ok now - will close and we can reopen if it recurs.


Avoid the infinite loop when loading a scene.

Avoid the infinite loop when loading a scene.
A crash occurs when an open callback is repeated forever.
Simply avoid the loop by setting the tab index before doing the relative actions so it'll be avoided in the next loop.
To reproduce:

open a project
open a scene which is not the main scene
run the game
go back to main scene
crash on infinite loop

It's probably fixable also by checking why there is an infinite loop in the load_scene() but still setting the tab index as soon as it's decided to switch doesn't seem a bad idea in general.
Here a piece of  a stack dump:
#38407 0x0000000001c78bdf in EditorNode::_scene_tab_changed (this=0x67dacc0, p_tab=0) at editor/editor_node.cpp:3998
#38408 0x0000000001c6f163 in EditorNode::load_scene (this=0x67dacc0, p_scene=..., p_ignore_broken_deps=false, p_set_inherited=false, p_clear_errors=true, p_force_open_imported=false)
at editor/editor_node.cpp:2805
#38409 0x0000000001c703da in EditorNode::open_request (this=0x67dacc0, p_path=...) at editor/editor_node.cpp:2947
#38410 0x0000000001d81a37 in FileSystemDock::_select_file (this=0xa17f3b0, p_path=...) at editor/filesystem_dock.cpp:801
#38411 0x00000000014e09d9 in MethodBind1<String>::call (this=0xa367070, p_object=0xa17f3b0, p_args=0x7fffffe0f960, p_arg_count=1, r_error=...) at ./core/method_bind.gen.inc:729
#38412 0x00000000031ad06e in Object::call (this=0xa17f3b0, p_method=..., p_args=0x7fffffe0f960, p_argcount=1, r_error=...) at core/object.cpp:945
#38413 0x00000000031a37db in MessageQueue::_call_function (this=0x4be1120, p_target=0xa17f3b0, p_func=..., p_args=0x7ffff7e9a038, p_argcount=1, p_show_error=false) at core/message_queue.cpp:256
#38414 0x00000000031a3a49 in MessageQueue::flush (this=0x4be1120) at core/message_queue.cpp:300
#38415 0x00000000024ade4d in SceneTree::idle (this=0x5f8a210, p_time=8.70000003e-05) at scene/main/scene_tree.cpp:505
#38416 0x0000000001170f8c in Main::iteration () at main/main.cpp:1856
#38417 0x0000000001dbb6c8 in ProgressDialog::task_step (this=0x8220450, p_task=..., p_state=..., p_step=0, p_force_redraw=true) at editor/progress_dialog.cpp:218
#38418 0x0000000001c72acc in EditorNode::progress_task_step (p_task=..., p_state=..., p_step=0, p_force_refresh=true) at editor/editor_node.cpp:3232
#38419 0x000000000158165f in EditorProgress::step (this=0x7fffffe0fd90, p_state=..., p_step=0, p_force_refresh=true) at ./editor/editor_node.h:803
#38420 0x0000000001ba8ae5 in EditorData::check_and_update_scene (this=0x67db418, p_idx=0) at editor/editor_data.cpp:637
#38421 0x0000000001c6e982 in EditorNode::set_current_scene (this=0x67dacc0, p_idx=0) at editor/editor_node.cpp:2742
#38422 0x00000000011d69dd in MethodBind1<int>::call (this=0xc7591e0, p_object=0x67dacc0, p_args=0x7fffffe100e0, p_arg_count=1, r_error=...) at ./core/method_bind.gen.inc:729
#38423 0x00000000031ad06e in Object::call (this=0x67dacc0, p_method=..., p_args=0x7fffffe100e0, p_argcount=1, r_error=...) at core/object.cpp:945
#38424 0x00000000031acb36 in Object::call (this=0x67dacc0, p_name=..., p_arg1=..., p_arg2=..., p_arg3=..., p_arg4=..., p_arg5=...) at core/object.cpp:869
#38425 0x0000000003213d91 in UndoRedo::_process_operation_list (this=0x67db448, E=0x112235e0) at core/undo_redo.cpp:271
#38426 0x00000000032140e5 in UndoRedo::redo (this=0x67db448) at core/undo_redo.cpp:310
#38427 0x0000000003213bca in UndoRedo::commit_action (this=0x67db448) at core/undo_redo.cpp:247
#38428 0x0000000001c78bdf in EditorNode::_scene_tab_changed (this=0x67dacc0, p_tab=0) at editor/editor_node.cpp:3998
#38429 0x0000000001c6f163 in EditorNode::load_scene (this=0x67dacc0, p_scene=..., p_ignore_broken_deps=false, p_set_inherited=false, p_clear_errors=true, p_force_open_imported=false)
at editor/editor_node.cpp:2805
#38430 0x0000000001c703da in EditorNode::open_request (this=0x67dacc0, p_path=...) at editor/editor_node.cpp:2947

I can't reproduce the bug described. Does it happen on all projects, or only a specific one?

I will try tomorrow to reproduce the issue and a new build

Moving to 3.2 milestone as we're about to enter the beta stage and release freeze for Godot 3.1. Only bug fixes against issues of the 3.1 milestone (or enhancements to core features of the 3.1 roadmap) will be considered until 3.1-stable is released.
Note: If it's merged after 3.1-stable is released, this change may be considered for cherry-picking into a later 3.1.x release.

What is the state of this? Can somebody reproduce this problem?

I couldn't reproduce the issue and I have reservations about the proposed fix, so I prefer to close this PR. Thanks for the contribution nevertheless!


Logstash update does not properly set prometheus index permissions

Raul found that on update to 5.1.0 from 5.0.8 the logstash pipeline does not have permission to write to prometheus index. Looks liek scripts are not updating this, only setting-up for new install. We can add an update step though it strikes me that it may be cleaner (and easier to maintain) to just drop a new role_mappings.yml in place on install and update.

Fixed this. Made it easier to maintain roles and roles_mapping longer-term as well by doing a direct copy. Also found some issues with post update script running before restart on update...wondering if this caused some issues in 5.0.X as well.


Fix the thread contention problem when try to fetch shuffle result fr…

If failed to create new client, record the fail time. Compare this fail time and the attempt time to create new connection and decide whether we should fail quickly.

I think we don't we need to add extra wait time because the first thread will spend about 21 seconds to try to connect to the failure machine.

I see. Agreed. LGTM.


feat(switch): implement off color variable on bl-switch

add --bl-switch-color-on and --bl-switch-color-off variables for switch
deprecate --bl-switch-color in favor of --bl-switch-color-on

Fixes #523

Hey, @buseselvi. Do you have any comments on this?


feat(lane_departure_checker, route_handler, ad_service_state_monitor): check isRouteValid

Description

Check the loading the route is valid or not using isRouteValid created by https://github.com/autowarefoundation/autoware.universe/pull/1149.
If isRouteValid is false, lane_departure_checker, route_handler, ad_service_state_monitor do not receive route.
Until https://github.com/autowarefoundation/autoware.universe/pull/1149 is merged, this PR keeps draft.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

When the wrong route is published, the nodes of autoware seem not to be died.


docs: add pull request template

Motivation
Pull request templates encourage developers to document their works better, either on the reasons behind the developments or on their impact, or even on some technical specifications.
Description
Adds a PR template that will be automatically in use at each PR on this repo. This template is based on this one in the ArmoniK.Core repository.
Original idea from https://github.com/pieterherman-dev/PR-Template-Guide/tree/main?tab=readme-ov-file
Testing
Impact
It is intended to enhance this repository documentation and thus quality of code.
Additional Information
Already in use in ArmoniK.Core repository
Checklist

[X] My code adheres to the coding and style guidelines of the project.
[X] I have performed a self-review of my code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have made corresponding changes to the documentation.
[ ] I have thoroughly tested my modifications and added tests when necessary.
[ ] Tests pass locally and in the CI.
[X] I have assessed the performance impact of my modifications.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Check for new events on query side

When a new object is created, the read model needs some time to update the model. If the object is read during this time the API will respond with a "Not found error"
Acceptance criteria

[ ] The query side should check for new events and apply it to the read model
[ ] At the moment the most important objects are:
- Organisation
- User
- Manager Roles of user (user had no permissions)
[ ] It should work on all get object requests (not on lists/searchs)

obviously not only creation of objects is affected, but also updates: https://discord.com/channels/927474939156643850/927866013545025566/969449145586810910

the fix for v1 is deployed on zitadel.ch. The fix for v2 is currently in review

https://github.com/zitadel/zitadel/issues/2760#issuecomment-1166901512


Add maintainers to recipe

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

add @eapolinario @wild-endeavor and @cosmicBboy to recipe maintainers

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@cosmicBboy Thank you for the PR. Please check the log of the build process and inspect the step where it failed. You will need to update the recipe so it does not fails.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

Old-style Python selectors (py27, py35, etc) are only available for Python 2.7, 3.4, 3.5, and 3.6. Please use explicit comparisons with the integer py, e.g. # [py==37] or # [py>=37]. See lines [45, 47]
noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

this PR is currently blocked by numpy version restrictions on flytekit: https://github.com/flyteorg/flytekit/blob/master/setup.py#L81-L84
@sugatoray as the conda expert, what's the best way of handling this?

@cosmicBboy The restriction is only applicable for python versions less than 3.8.
So, for a quick solution, I would suggest that you just bump up the lower bound of python (for host and run requirements in the meta.yaml file) to python >=3.8.

update: we'll wait for https://github.com/conda-forge/flytekit-feedstock to be updated, which should address the numpy issue

update: we'll wait for https://github.com/conda-forge/flytekit-feedstock to be updated, which should address the numpy issue

I have merged the PR. It should make the updated version available in next 2-3 hours.

what's the non-quick fix if we want to continue supporting python 3.7?

Let's see once flytekit feedstock is updated.


chore(main): release pixels 0.16.0

:robot: I have created a release beep boop
0.16.0 (2024-07-09)
Features

pixels: add slots to Label (6c9b044)
pixels: add slots to Tooltip (71c0d83)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

pixels-v0.16.0
:sunflower:


cant get react-app-rewired to run, instead get an 'Unexpected token' for using the spread operator

trying to start a freshly cloned project with the following  config-override:
const { injectBabelPlugin } = require('react-app-rewired');
const rewireLess            = require('react-app-rewire-less');
const webpack               = require('webpack');
const rewireReactHotLoader  = require('react-app-rewire-hot-loader');

module.exports = function override(config, env) {
  // Here we are handeling the Less rewriting to allow us to override antd default variables
  config = injectBabelPlugin(['import', {
    libraryName: 'antd',
    style: true,
  }], config); // change importing css to less
  config = rewireLess(config, env, {
    modifyVars: { '@primary-color': '#047fff' },
  });
  config.resolve.modules.unshift(`${__dirname}/lib`);
  config.plugins = config.plugins.map(
    (plugin) => {
      if (plugin instanceof webpack.optimize.UglifyJsPlugin) {
        plugin.options.mangle = {
          except: ['BigInteger', 'ECPair', 'Point'],
        };
      }
      return plugin;
    },
  );
  config.module.rules[1].oneOf.push(
    {
      ...config.module.rules[1].oneOf[1],
      include: `${__dirname}/lib`,
    },
    {
      ...config.module.rules[1].oneOf[1],
      include: `${__dirname}/node_modules/@somePrivateModule`,
    },
  );
  return rewireReactHotLoader(config, env);
};

but i get an error stating that a spread operator in one of our internal modules is an "unexpected token" : (..state)
 return {
        ...state,
        activeModal: (payload && payload.name) || '',
        data: (payload && payload.data) || {},
      };

here is the error:

<EMAIL_ADDRESS>Module parse failed<EMAIL_ADDRESS>Unexpecte
d token (19:8)
You may need an appropriate loader to handle this file type.

i'm using windows 10 (this does not happen on mac nor linux)

Is it the first spread operator in your code?
It could be the babel setup not working correctly.

Not sure, but I've managed to overcome this issue by upgrading my cra and cra-rewired with it. Still have some issues with the build failing though

injectBabelPlugin
https://github.com/timarney/react-app-rewired/blob/master/index.js#L17


Credits on Smaller Screens

Credits needs to be the full width of the screen on smaller screens.

I'm closing this issue as it's a duplicate entry. Please refer to Pull Request: https://github.com/kungfukoala/benjaminkinzer.com/pull/35


Alternatives?

Since this projects seems to be abandoned - does anybody know an alternative workflow with similar functionality?

I use it daily and it works. I use it for google/youtube searches.


Add new CFA analyst to CDCGov Github

What type of help do you need?

[ ] Question
[ ] New Repo
[ ] Delete Repo
[X] User Membership (please make sure new members are familiar with the CDC open practices and set up their profile with name and org info to help people collaborate with them)
[ ] Other

Please describe how you'd like us to help.
I am a new data scientist in CDC/OD/CFA. Please add me to the CDCGov GitHub Organization.
Name: Alexandre Zajic
CDC ID: GSX4
Github ID: Alexandre987

Added


Issue236 fixed stem3

This PR fix the issue #236

small typo
stem3 is good

8 plotly/plotlyfig_aux/handlegraphics/updateLineseries.m
@@ -131,6 +131,9 @@ function updateLineseries(obj,plotIndex)
%-------------------------------------------------------------------------%
line 134 %-Fro 3D plots-%
small typo
stem3 is good

Ok. In a new PR I will correct this small typo. Thanks for you carefull review dear @VolKa79. It is very important


Make esxi-build.py working on Linux

Do you plan an update of unlocker-esxi to support MacOS Catalina?

(Not the dev) Hmm i had no issues using this version of unlocker with catalina, what issues are you having?

Do you plan an update of unlocker-esxi to support MacOS Catalina?

Just select 10.14,it works well.But i still can't use AMD passthrough.Any solution?

Yes, I can confirm selecting 10.14. works, but not all. Try to go to in recovery mode (booting with CMD & R) to change the (SIP) with csrutil disable. Any workaround?

Please update unlocker-esxi for Catalina. Actual version 3.0 works only with Catalina 10.15.0, but if trying to update to 10.15.2 the boot process hang at the apple logo.
Anyone have a working solution with actual unlocker-esxi 3.0?

Please update unlocker-esxi for Catalina. Actual version 3.0 works only with Catalina 10.15.0, but if trying to update to 10.15.2 the boot process hang at the apple logo.
Anyone have a working solution with actual unlocker-esxi 3.0?

I don't think the dev has anything to do with your issue. All unlocker is doing is fooling ESXi to think it's running on mac hardware. If ESXi doesn't support something, it's not the unlockers fault.


Enable the user to get their profile using microservices

We now have an endpoint to the the profile of a user by id. The goal of this ticket is to use this endpoint to show the user information on their profile page.
Depends on #655

Added to Sprint 22.09

Added to Backlog


clipgrab: 3.6.9 -> 3.7.0

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/clipgrab/versions.
meta.description for clipgrab is: '"Video downloader for YouTube and other sites"'.

Checks done (click to expand)

built on NixOS
Warning: no invocation of /nix/store/hdbpzil031bngika42h7d00aykncxyvg-clipgrab-3.7.0/bin/clipgrab had a zero exit code or showed the expected version
0 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 3.7.0 with grep in /nix/store/hdbpzil031bngika42h7d00aykncxyvg-clipgrab-3.7.0
directory tree listing: https://gist.github.com/412a0ced39f1a4742c3280aaa0e0d5f1
du listing: https://gist.github.com/72fef0ca200bf480c936b06826ee84a9

Instructions to test this update (click to expand)

One-time optional setup to skip building using Cachix:

Install cachix from https://cachix.org/
Use r-ryantm's cache:cachix use r-ryantm

Test this update by entering a nix shell, seeing what is inside the
result, and if applicable, running some binaries:
nix-shell --pure -I nixpkgs=https://github.com/r-ryantm/nixpkgs/archive/fed29c430e1a89e70ad420533e619aaed056030f.tar.gz -p clipgrab
ls -la /nix/store/hdbpzil031bngika42h7d00aykncxyvg-clipgrab-3.7.0

Success on x86_64-linux (full log)
Attempted: clipgrab
Partial log (click to expand)
installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hdbpzil031bngika42h7d00aykncxyvg-clipgrab-3.7.0
shrinking /nix/store/hdbpzil031bngika42h7d00aykncxyvg-clipgrab-3.7.0/bin/clipgrab
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hdbpzil031bngika42h7d00aykncxyvg-clipgrab-3.7.0/bin
patching script interpreter paths in /nix/store/hdbpzil031bngika42h7d00aykncxyvg-clipgrab-3.7.0
checking for references to /build in /nix/store/hdbpzil031bngika42h7d00aykncxyvg-clipgrab-3.7.0...
/nix/store/hdbpzil031bngika42h7d00aykncxyvg-clipgrab-3.7.0

Success on aarch64-linux (full log)
Attempted: clipgrab
Partial log (click to expand)
installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3cr3ic8xd5xf34rb9iqmajaxwgwr8qp4-clipgrab-3.7.0
shrinking /nix/store/3cr3ic8xd5xf34rb9iqmajaxwgwr8qp4-clipgrab-3.7.0/bin/clipgrab
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3cr3ic8xd5xf34rb9iqmajaxwgwr8qp4-clipgrab-3.7.0/bin
patching script interpreter paths in /nix/store/3cr3ic8xd5xf34rb9iqmajaxwgwr8qp4-clipgrab-3.7.0
checking for references to /build in /nix/store/3cr3ic8xd5xf34rb9iqmajaxwgwr8qp4-clipgrab-3.7.0...
/nix/store/3cr3ic8xd5xf34rb9iqmajaxwgwr8qp4-clipgrab-3.7.0


Npc with respawntime 0 respawn on server restart

All is in the title ;)

Sentinel 0.6
Spigot 1.10.2

Are you running Citizens 2.0.20?

If you're not, could you please update and re-apply the respawn time setting?

I updated Citizens to 2.0.20 and the problem persists. (Even if I re-apply respawn time setting)


quay.io/coreos/hyperkube image for v1.4.12

Please consider releasing a hyperkube image vor K8s v1.4.12 which contains security fixes for CVE-2016-8859. See Kubernetes Changelog since v1.4.9 for details.

@felixbuenemann That CVE doesn't affect hyperkube images only alpine based images. So you would just need to bump the manifests to use the images from the PR: https://github.com/kubernetes/kubernetes/pull/42937/files
In general I'd recommend using a both a newer k8s version if possible and a repository that gets more attention in regards to keeping manifests up to date. (coreos/tectonic-installer or kubernetes-incubator/bootkube if you want to handle compute setup yourself)

Thanks for the info.


Use musl for riscv64 and bump rust in release.yml

riscv64gc-unknown-linux-musl is not supported since rust 1.82.0.
See #5333 and https://github.com/typst/typst/pull/5333#issuecomment-2449677701 .
NOTE: I don't use flake, so I did not bump rust version in the flake. I left an issue for it, see #5341

The release action fails with these changes: https://github.com/laurmaedje/typst/actions/runs/11612330587/job/32335578874

The release action fails with these changes: https://github.com/laurmaedje/typst/actions/runs/11612330587/job/32335578874

I see... This is because cross-rs does not provide an image for riscv64-unknown-linux-musl. If we want to use cross-rs to build our artifacts, we might need to file issues to the upstream and wait for a next release. I think, however, we can also cross-build the targets without cross-rs, by providing proper linker and rustc flags for cargo.

Some investigation:

I tried to manually download and specify the musl linker, it succeeded to compile for x86_64, armv7 and aarch64, but failed to compile for riscv64. See https://github.com/Coekjan/typst/actions/runs/11624761042
It is because the prebuilt riscv-musl-gcc on https://musl.cc is outdated. Current riscv asm in openssl may require higher version of gcc (https://github.com/openssl/openssl/issues/23011), so the outdated gcc cannot parse the asm instruction (with vlenb register).

Some options if we want to use musl for riscv64:

build musl using newer gcc on ourselves, in release CI or in a seperate repo (specially for building docker image)
make a small patch to openssl (change the register name into register index)
...

Is it worth it or should we just stay with the gnu version?

Is it worth it or should we just stay with the gnu version?

I think it's up to you.
Using GNU libc specifically for riscv64 makes me feel misaligned with other targets. Current investigation shows that if we want to make them aligned, we may need more engineering efforts.
If you decide to stay with the gnu version, I will clean the commits and just bump rust version in the PR.

If our principle of releasing prebuilt artifacts is making the binaries small, static-linked (and other advantages of using musl libc), I think it worth to switch to musl.

Then, maybe let's go for the "make an issue and wait a bit" route.

Thanks for the investigation!


file extensions are case-sensitive

Leafview refuses to open images unless they're all lowercase (e.g. .JPG won't open, but .jpg works). I've only tested this on my Mac.

@gcaptn
Thanks for letting me know.
Although I could not reproduce it on my Mac (APFS + not case-sensitive), I tried to fix it.
Could you try v0.4.2 and let me know how it goes?
https://github.com/sprout2000/leafview-tauri/releases/tag/v0.4.2

Yup! It works fine. A mistake on my part because I didn't realize I was on a really old build (from back when this was tauview) 🤦 Thank you so much for the quick response!


Cursor issues on mobile

Issue summary
Cursor position don't work 100% correctly.

One issue is that opacity on content editable don't work properly.
The editable area is not exactly in same place as command line.
When there are no command, cursor is at the beginning of prompt.
When cmd is not at bottom, the cmd and editable area don't overlap.
Adding shift+enter cursor don't move to next line.

Steps to reproduce
Demo https://terminal.jcubic.pl/lips.php
First issue is solved in demo that add extra css.
Browser and OS
Android

.

@noon2a if you want to be notified about issue there is subscribe button on the right.

Your original issue references Andoid, but this is a problem on iOS as well.
With enough repeated clicks near the cursor, I can get the keyboard to come up, but the clickable area is either too small or not placed correctly.
I have a lot of different iOS devices and can assist with QA if needed.

@rabbithops Yes, it's the same code I don't expect on iOS to work differently, when the fix will be added and tested on Android it should automagically work on iOS too.

@rabbithops if you have a real iOS device you can check one thing. I was wondering how it works with the new Safari padding thing. explained in this article: https://webkit.org/blog/7929/designing-websites-for-iphone-x/
Can you create a screenshot how the full-screen terminal looks like on iPhone? I have access to BrowserStack but it doesn't look like real iPhone.

Fix the demo, it was using some old file that caused JS error and white page.


Maybe it was supposed to be like that

But I think you meant sandbox and not sandox...
All tests still pass as expected...

Yes ~ sandBOX, not sandox ~ Thank you ~

Next time I code review something, I am just going to do it at home where it doesn't get mangled...

+1 for "proxy shenanigans, no code changes" ~ the best kind of code change


Fixed colorMatrix function

Hi, I found out that
filter.addFilter('colorMatrix', [
b,0,0,0,0,
0,b,0,0,0,
0,0,b,0,0,
0,0,0,1,0
]);
doesn't work as expected. The commit fixed that. I would really appreciate if you merge it into your project and make it available via npm. Thanks for the amazing work you've done here.

Thank you so much @nadine-belanova ! Excellent catch. Everything looks good to me. Will merge and publish to npm as a patch version.

@nadine-belanova version 1.0.2 is live on npm. Thanks again!


libpbc must be loaded before libdft

Closes #2272

issue related to the configuration of -DCMAKE_SKIP_BUILD_RPATH=1 . Please refer to the discussions in #2272


Can't download drn models.

The website can't download files with error 403.
I upgraded the drn.py/url to http://dl.yf.io/drn/, noticing that the author has deleted the drn-c* models.

I also get in this trouble.

Committed a change that prevents the code from loading the drn-c* models pretrained on ImageNet. Hopefully this will solve this issue.


Processing pollution of text item passages coming from item answers

Describe the bug
There is an issue when you query for text passages while having the answer query also enabled.
They should work independently with their specific thresholds and results. However, in the current code, when the query is constructed for the text passages, the answer flag is still active/true. This leads to search results that may have been matched with the answer items instead of just the text passages.
If you have a lower threshold for text passages than for answer items and if the match is better against the answer item, then this leads to an unexpected outcome: the answer is returned to the user instead of letting the normal flow run (text passages to be compared against the threshold and then have the LLM compose the final answer).
Please complete the following information about the solution:

[x] Version: v5.4.5

To get the version of the solution, you can look at the description of the created CloudFormation stack. For example, "(SO0189) QnABot [...] v0.0.1".

[x] Region: us-east-1
[ ] Was the solution modified from the version published on this repository?
[ ] If the answer to the previous question was yes, are the changes available on GitHub?
[x] Have you checked your service quotas for the services this solution uses?
[ ] Were there any errors in the CloudWatch Logs?

Screenshots
If applicable, add screenshots to help explain your problem (please DO NOT include sensitive information).
Additional context
Add any other context about the problem here.

Fixed as of v5.5.0


Add function to get token

We need a way to check that lock is held by which instance.
TokenPrefix helps us in setting instanceId as prefix to token.
But, there is no way to check tokenPrefix back in our code.

Deprecated in favour of https://github.com/bsm/redislock


fix package XREFs

These are all fixes of broken links. Most had not been updated when modules became packages. Some had been updated, but were either still broken ($(XREF package.module,symbol)) or had wrong text ($(XREF package_module,symbol)).
Depends on https://github.com/D-Programming-Language/dlang.org/pull/994.

Thanks!


Alignment with BOMSpec Team providing mandatory businessPartner in SingleLevel* structure

As IRS Team
I want a solution how to deal with missing BPN number in traversal aspects
so that we are able to traverse through the value chain
Hints / Details

Get in Contact with Nicole Kauke how to proceed on this topic

Outcome / Acceptance Criteria

[ ]  Aligment with BOMTeamSpec team for an additional attribute in SingleLevel* structure
[ ]  All necessary steps (Release Process, Testdata Management, Update Semantic Models in IRS ) are aligned
[ ]  Alignment with BOMSpec Team

Outcome

...

Acceptance Criteria

...

Out of Scope

...

2023-11-30

Aspect
Version
BusinessPatner Number
Mandatoy

SLBAB
2.0.0
Y
Y

SLBAP
2.0.0
Y
Y

SLUAB
2.0.0
N
N

SLUAP
1.1.0
N
N

Requirement Originator

Requirement of Trace-X

Progress:

Further alignment BMW Sync tomorrow 3.8.2023<EMAIL_ADDRESS>&<EMAIL_ADDRESS>&<EMAIL_ADDRESS>Alignment with policy experts<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

@mkanal I dont understand yet the topics mentioned here. I need some update on this

mail an semantic modelling team has been sent on 30th november. Waiting for response


Regarding PWM Mouse Genome

Hi,
I want to use NucleoATAC to identify nucleosomes from ATAC-seq data in Mouse. I am wondering could you please let me know if you have PWM files for Mouse or any source from where I can get/generate it in the format NucleoATAC uses.
Thanks!

Hi, PWM file should be pretty similar for any species as it is simply reflecting sequence preferences of nextera Tn5 on naked dna.  The ones included are from Human and Yeast genomic dna samples and are both very similar. If not using nextera Tn5 (i.e. using some other transposase) then  a new pwm should be created based on a genomic dna sample.


refactor: edit card gradient on full-image variant

Is your feature request related to a problem? Please describe.

On card with gradient, contrast is not enough on text (2.83).

Describe the solution you'd like

Let’s improve it → Gradient has to be full height

Additional context

Figma

Card isn't yet developed.


Test our usage of Electron safeStorage APIs and review docs

Refs: https://github.com/microsoft/vscode/issues/185677

[x] Linux @alexr00
[ ] Linux @lramos15

Complexity: 3
Roles: Developer, Engineering Manager
Authors: @TylerLeonhardt, @deepak1556
Create Issue

This iteration we've moved from keytar to using Electron's safeStorage API for encrypting secrets. This test plan item is testing a couple of scenarios that user may run into and trying to make sure they have the tools in mind to troubleshoot.
This TPI will work best with Ubuntu.
Scenario 1: "We couldn't recognize your environment"
Picture this, you're using some obscure desktop environment and we don't detect it because it's not super common. VS Code should do two things:

allow you to use a weaker encryption that safeStorage provides (and this persists)
allows you to read the troubleshooting docs

To fake this, download the latest Insiders targz, extract it, and run:
env -u XDG_CURRENT_DESKTOP -u DESKTOP_SESSION -u GNOME_DESKTOP_SESSION_ID ~/Downloads/VSCode-linux-x64/bin/code-insiders --verbose --vmodule="*/components/os_crypt/*=1"

Then turn on settings sync and go through the flow. You should get a modal that tells you about your "unknown" environment. Try both options (note, the docs should go to vnext branch for now).
When you do the weaker encryption option, make sure it saves password-store to the file opened when you run Configure Runtime Arguments. This means that if you kill the process and restart it using the same command, it should not show you the modal and instead should "just work" as you expect.
Scenario 2: "Ubuntu has a weird issue, open the troubleshooting guide"
Picture this: your system isn't setup properly and your keyring isn't working as expected... but we know you're running in a GNOME-like environment. We can tell you to just go check out the docs for assistance.

NOTE: make sure you delete the password-store property generated in the argv.json... and kill for VS Code for now...

This is an easier scenario because what we're gonna do is put the Keyring in a locked state... So, open the Passwords & Keys app (aka seahorse) and click the 🔓 next to the Login keyring. That will lock  this keyring.
Now start VS Code as normal... hitting cancel on the million modals that pop up asking you to unlock the keyring... don't do it!
Sign in to Settings Sync (keep hitting cancel on the OS modal asking you to unlock the keyring) and what you should eventually get is a notification that will bring you to the troubleshooting guide.
Conclusion
Our goal is to have a nice place to start enumerating docs. Linux will undoubtably have more unique ways to be misconfigured, so at least we are starting somewhere...
We're looking to make sure we help when we can and the docs make sense.

I didn't get a modal for scenario 1, I just got this:

I used device login to authenticate.

@alexr00 can you attach the logs from env -u XDG_CURRENT_DESKTOP -u DESKTOP_SESSION -u GNOME_DESKTOP_SESSION_ID ~/Downloads/VSCode-linux-x64/bin/code-insiders --verbose --vmodule="*/components/os_crypt/*=1"

@TylerLeonhardt the logs from @alexr00 looks good,
6049: 0627/120427.662568:VERBOSE1:key_storage_util_linux.cc(54)] Password storage detected desktop environment: (unknown)
6049: 0627/120427.662830:VERBOSE1:key_storage_linux.cc(122)] Selected backend for OSCrypt: BASIC_TEXT
6049: 0627/120427.662933:VERBOSE1:key_storage_linux.cc(142)] OSCrypt did not initialize a backend.

The check here looks incorrect https://github.com/microsoft/vscode/blob/ac34ea3a6e3334c2bfb01f5c234863747e07f18c/src/vs/workbench/services/secrets/electron-sandbox/secretStorageService.ts#L69, shouldn't it be provider === KnownStorageProvider.unknown ?

Marking my testing as complete as Scenario 2 worked as expected. Please @ mention me in the bug for https://github.com/microsoft/vscode/issues/186239#issuecomment-1609225154 and I will verify it!

@deepak1556 os right. It should be basic text... I forgot to change that back while I was testing on macOS

PR out here: https://github.com/microsoft/vscode/pull/186346
Once this goes in I'll fire off another Insiders to this TPI can be tested

New insiders released.

Suggestion: because the verbose flag causes there to be a lot of output, would it make sense to suggest storing that info into a file?
I was able to get the "locked collection" string, though :+1:
$ ~/Downloads/VSCode-linux-x64/bin/code-insiders --verbose --vmodule="*/components/os_crypt/*=1" > run.log 2>&1
$ grep locked run.log
[47408:0627/114250.985588:VERBOSE1:libsecret_util_linux.cc(169)] Dummy store to unlock the default keyring failed: Cannot create an item in a locked collection
[47408:0627/114251.984576:VERBOSE1:key_storage_libsecret.cc(73)] Libsecret lookup failed: Cannot create an item in a locked collection

@rzhao271 thanks for the feedback, you can use --verbose --vmodule="*/components/os_crypt/*=1" --log-file=<absolute-path>/chrome.log to capture runtime logs in a file.

Since I'd already done part of this I went back and verified Scenario 1 with the fix.


Document URN scheme for jti

Closes #83
📑 Description

✅ Checks

[ ] My pull request adheres to the code style of this project
[ ] My code requires changes to the documentation
[ ] I have updated the documentation as required
[ ] All the tests have passed
[ ] I have selected a committee co-chair to review the PR

ℹ Additional Information

Thankyou, we will review this during the face-to-face meeting


Changing image size

Hi @wax911
thanks for giving wonderful library,
i have a small problem to just increase the size of image which is display in a center of the screen, is it possible?
if yes then please help me.
Thanks . (_)

Hi @GauravCreed credits actually belong to @codemybrainsout he/she is the one that made the library and yes it is possible to increase the size of the image, I'll try and see if I can set some parameters to do that later on today 👍

@wax911
Okay , Not an issue.
thanks.

@GauravCreed Sorry for not looking into this as of yet, I've been super occupied with work e.t.c I'll try to set some time aside tomorrow. I've been thinking would it be easier to have a method such as set image size and you give it a resource item? the resource it might have the different dimens for the image in different screen sizes?

@wax911 not a problem to late response.
what i want  from you .

Your  library is perfect for me, i just want to increase the size of images which is displayed in app introduction, and if i want more from u to that can i  hide the description of app, i want only title and images nothing else. so the images can show bigger from previous, i saw u a UI like tthis

reference link : https://android-arsenal.com/details/1/3322
it's request to please give me solution as soon as faster.
Thanks

@GauravCreed Compile using the latest version of the project
compile 'com.codemybrainsout.onboarding:onboarder:1.0.3' and use
java .setIconLayoutParams(iconWidth, iconHeight, marginTop, marginLeft, marginRight, marginBottom); for changing the image size and margins.


Import of npm dependency not working properly

As I do not know the exact reason, feel free to rewrite the issue!
I pushed an example with two branches to https://github.com/dseebacher/ceylon-bonsaijs-npm.
The example includes a npm dependency that gets resolved correctly. If i do not add an import for the object creation of Rect the example compiles and works in the browser if i add the BonsaiJS lib manually. But run-js and test-js do not work.
If i add an import for Rect, the IDE complains The GenerateJsVisitor caused an exception visiting a InvocationExpression node: "java.lang.NullPointerException" at com.redhat.ceylon.model.typechecker.model.Declaration.getQualifiedNameString(Declaration.java:150). The same error shows up if i call compile-js directly.

@chochos could you take a look at this one too, please?

I get what I assume is the same error with the following code:
module tmp2 "1.0.0" { import npm:ffi "2.2.0"; }

import ffi { Library }

dynamic libsystemd = Library("libsystemd", dynamic []);

It looks like importing uppercase functions doesn’t work. If I escape the invocation with \iLibrary, there’s no compiler error, but the import gets a “unused import” warning and at runtime Library is an “undefined or null reference”, so clearly the compiler isn’t making the connection between import and use in that case.
Workaround on Node: use require("ffi").\iLibrary(…) instead. (Keep the module import so that the module is still installed with npm.) @dseebacher do you think there’s a similar workaround for the browser?

I'm not sure how I would apply your fix.. If I keep module import, remove file import and rewrite the constructor with ur proposed require, it compiles, but run-js and test-js still complain (TypeError: Cannot read property 'filename' of undefined).

Yeah, browser require() isn’t synchronous, it takes a callback, doesn’t it? So you’d need require("whatever", function(whatever) { /* do stuff */ }), and that might not work out for your application.

Well I didn't even bother to try in the browser, as I'm really looking forward to some running js-tests :D And by just running my module (src and test) with ceylonb, it didn't work.

@chochos I tried the initially posted example with the 1.3.3 release and i still get the same error :(

Oh, sorry, it does compile, had to update ceylonb to 1.3.3... but it does not run, but that might be some lib related problem.

Can you post a minimal example to reproduce the problem? I need to look at the gen'd js to fix the runtime issue, if there is one.


Multiple YaML files as a practical and valuable alternative to current monolithic JSON for apps.json

I can't say this is a bug report, nor can I really say it is a feature request as much as I can say it is a request for comment from the developers.
I recently started working with Wappalyzer and found it to be an excellent tool, especially when compared with similar tools. I particularly like how easy it is to add new technologies and categories.
However, in my opinion, working with this data (apps.json) could  be made simpler to work with
JSON is great for machines reading structured data. It's also definitely readable by humans. However, YaML has major benefits over JSON in my opinion:

YaML is much easier for humans to read and write
YaML supports comments
Valid JSON is also valid YaML

I've been known to be a bit of aYaML evangelist (or maybe Zealot) but I think that the process of both adding/editing the apps data as well as the process of reviewing/merging/documenting it would be made much easier if the data was stored as YaML.
Because JSON is valid YaML, this could be done in a relatively unobtrusive way.
The drawbacks here I think would be the escaping/quoting requirements that may pop up when writing YaML by hand.
As an alternative, I've considered writing a simple Makefile that will convert the JSON to YaML while I am working with it, and then back to JSON when I am done. I'm OK with this, but I thought this still might be a point worth raising
In addition to switching from JSON to YaML, I can tell you that my experience in reading as well as adding new entries to the apps database in wappalyzer would be greatly improved if an apps.d/ style approach was accepted. The apps.json file, being monolithic and containing every rule, is a bit clunky. I do concede/understand that there is convenience in everything being available in one file, but from a development point of view, it makes more sense to me to have multiple files- perhaps for different categories of entries. These could be easily merged at run-time by simply concatenating the lists of structured data together. This could potentially make merging PRs cleaner with less conflicts- though maybe that's a solution for a problem that doesn't exist.
I'm not sure I can provide a technical explanation for my claim that as a result of the file being monolithic it is "clunky", but I do expect it to continue growing in size as time goes on. At some point, isn't one file just too much to deal with?
I think there could be a benefit in a switch from JSON to YaML, even if just for the ability to contain comments. I also believe there would be benefits to the apps file being module, so that categories could be kept logically separate. Perhaps there are other ways the file could be split.
I'm not expecting this idea to gain much traction, but I do appreciate the consideration and any thoughtful response. I would very much appreciate any explanation of why JSON was chosen in the first place- purely out of curiousity. I don't intend to argue this one to the death :)
Also, allow me to apologize in advance if this has all been hashed out before. I'm new to the app and am not familiar at all with the development history and/or the design and implementation choices
Thanks

JavaScript supports JSON natively and I'd like the WebExtension to stay dependency free. I don't think a single file is problematic, conflicts are rare and easy to resolve. I know what you mean about it being clunky though. Technologies can be in multiple categories so I don't think there's a clear way to split it into multiple files.

Fair enough. Should we close this?
Thank you for your thoughts and the quick response

Another benefit of using YAML is not having to escape the regular expressions, which is a bit weird the way it is now. I'd consider it if there was native support.

Another benefit of using YAML is not having to escape the regular expressions, which is a bit weird the way it is now. I'd consider it if there was native support.

True, though YaML has some quoting/escaping issues of its own to deal with as well. Either way, I think we are in violent agreement. Thanks again


Fix CSS selectors for tab handler

I'll roll this into the next release, I just missed it this time through, sorry.

I'm going to change this manually, because I took too long to merge this PR, and a few things our out of sync.


Deduplicate EIP20Token

Follow-up to https://github.com/OpenST/mosaic-contracts/pull/728
All repositories should use EIP20Token from openzeppelin's npm package instead of re-creating it themselves.
In mosaic-contracts, make sure that the EIP20Token from openzeppelin can be used as a replacement without any breaking changes.

is there an OpenZeppeling or by others implementation that we can use to deduplicate ?

https://github.com/OpenZeppelin/openzeppelin-solidity/tree/master/contracts/token


HTTP Status code 422 received, data {"status":422,"errorCode":"15_002","message":"Required field language missing for device channel browser","errorType":"validation"}'

Magento version: <IP_ADDRESS>
Plugin version: 2.17.0
Description
Since upgrading to the latest version of the module, I have had a number of transaction attempts fail with the error code: 'HTTP Status code 422 received, data {"status":422,"errorCode":"15_002","message":"Required field language missing for device channel browser","errorType":"validation"}'
This is an intermittent error as some card transactions are processing correctly, and some are not going through on the first couple of attempts but then are later. I have not been able to replicate it so am having to use customers' descriptions of how the error presents and the error log, but have so far not been able to diagnose the issue.
Here is a stack trace from the latest one:
2019-10-04T11:18:22+00:00 ERR (3):
exception 'Adyen_Payment_Exception' with message 'HTTP Status code 422 received, data {"status":422,"errorCode":"15_002","message":"Required field language missing for device channel browser","errorType":"validation"}' in /domains/sconch.com/http/app/code/community/Adyen/Payment/Exception.php:47
Stack trace:
#0 /domains/sconch.com/http/app/code/community/Adyen/Payment/Model/Api.php(833): Adyen_Payment_Exception::throwException('HTTP Status cod...')
#1 /domains/sconch.com/http/app/code/community/Adyen/Payment/Model/Api.php(137): Adyen_Payment_Model_Api->doRequestJson(Array, 'https://1d3d870...', 'AQEkhmfuXNWTK0Q...', NULL)
#2 /domains/sconch.com/http/app/code/community/Adyen/Payment/Model/Adyen/Abstract.php(289): Adyen_Payment_Model_Api->authorisePayment(Object(Mage_Sales_Model_Order_Payment), 70, 'cc')
#3 /domains/sconch.com/http/app/code/core/Mage/Sales/Model/Order/Payment.php(1086): Adyen_Payment_Model_Adyen_Abstract->authorize(Object(Mage_Sales_Model_Order_Payment), 70)
#4 /domains/sconch.com/http/app/code/core/Mage/Sales/Model/Order/Payment.php(342): Mage_Sales_Model_Order_Payment->_authorize(true, 70)
#5 /domains/sconch.com/http/app/code/core/Mage/Sales/Model/Order.php(886): Mage_Sales_Model_Order_Payment->place()
#6 /domains/sconch.com/http/app/code/core/Mage/Sales/Model/Order.php(1104): Mage_Sales_Model_Order->_placePayment()
#7 [internal function]: Mage_Sales_Model_Order->place()
#8 /domains/sconch.com/http/app/code/core/Mage/Core/Model/Resource/Transaction.php(105): call_user_func(Array)
#9 /domains/sconch.com/http/app/code/core/Mage/Core/Model/Resource/Transaction.php(159): Mage_Core_Model_Resource_Transaction->_runCallbacks()
#10 /domains/sconch.com/http/app/code/core/Mage/Sales/Model/Service/Quote.php(189): Mage_Core_Model_Resource_Transaction->save()
#11 /domains/sconch.com/http/app/code/core/Mage/Sales/Model/Service/Quote.php(249): Mage_Sales_Model_Service_Quote->submitOrder()
#12 /domains/sconch.com/http/app/code/core/Mage/Checkout/Model/Type/Onepage.php(789): Mage_Sales_Model_Service_Quote->submitAll()
#13 /domains/sconch.com/http/app/code/local/Magestore/Onestepcheckout/controllers/IndexController.php(714): Mage_Checkout_Model_Type_Onepage->saveOrder()
#14 /domains/sconch.com/http/app/code/core/Mage/Core/Controller/Varien/Action.php(418): Magestore_Onestepcheckout_IndexController->saveOrderAction()
#15 /domains/sconch.com/http/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(254): Mage_Core_Controller_Varien_Action->dispatch('saveOrder')
#16 /domains/sconch.com/http/app/code/core/Mage/Core/Controller/Varien/Front.php(172): Mage_Core_Controller_Varien_Router_Standard->match(Object(Mage_Core_Controller_Request_Http))
#17 /domains/sconch.com/http/app/code/core/Mage/Core/Model/App.php(354): Mage_Core_Controller_Varien_Front->dispatch()
#18 /domains/sconch.com/http/app/Mage.php(684): Mage_Core_Model_App->run(Array)
#19 /domains/sconch.com/http/index.php(87): Mage::run('www', 'store')
#20 {main}

And a truncated version of the API log:
2019-10-04T11:18:21+00:00 DEBUG (7): Array
(
    [browserInfo] => Array
        (
            [userAgent] => Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36
            [acceptHeader] => text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3
            [language] =>
            [colorDepth] =>
            [screenHeight] =>
            [screenWidth] =>
            [timeZoneOffset] =>
            [javaEnabled] =>
        )

It looks like the module is not populating [language] => and so the transaction is being refused by the Adyen servers.
Is there any way to either force the language field to populate or to remove the submission of the language field to avoid it failing validation?
Bryan from the Adyen Technical Support team has asked me to give you (the Adyen developers on GitHub) the PSP reference of<PHONE_NUMBER>726356 for the latest failed transaction.
Thanks,
Hugh

Hi @hughconway ,
This is browser data that should be populated by this js file:
https://github.com/Adyen/adyen-magento/blob/9429c55c6cc0c54ae0c7662c767d18e429639978/app/design/frontend/base/default/layout/adyen.xml#L94
It will be passed by the form here:
https://github.com/Adyen/adyen-magento/blob/697ab6c0521333e94adda2801cc6ca5aa8d05c7b/app/design/frontend/base/default/template/adyen/form/cc.phtml#L96-L104
You can include some additional checks here and/or force the language field.
Do you see some patterns in shopper's behavior or browser? It is odd that it happens only sometimes.
Thanks,
Kind Regards,
Alessio
Adyen

Closing the issue for now, feel free to reopen it with more details.
Kind Regards,
Alessio
Adyen


877 page wizard step validation

Closes #877
Summary
Clicking on a step in the progress indicator should not allow skipping steps that require validation
Change List (commits, features, bugs, etc)

StatefulPageWizard now checks onValidate() of all steps before setting the selected step

Updated the PageWizard story to allow onValidate to be called from the StatefulPageWizard

Acceptance Test (how to verify the PR)

On the PageWizard story, the stateful example story should work unmodified
The stateful example with validation should show an error if the fields are empty and a following step is clicked

Just added a test to make sure the validation is working properly.

Just readded the knobs, didn't notice I had accidently removed them somehow.

:tada: This PR is included in version 2.97.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


A wordlist file with more words

Hi, I have collected a 8378 words wordlist file, hope it will helps:) see attachment
wordlist.zip

Thanks for the wordlist.
However, it seems not to be suitable for word completion. (I guess it was a dictionary for spell check)


Expose metrics

It would be nice to expose metrics, like:

Number of requests
same per table
same per request type
same per request type and table
number of errors
all combinations per table and type
...

Good idea. Along the same vein, the java driver does expose some stats already that might be useful.
https://docs.datastax.com/en/developer/java-driver/4.2/manual/core/metrics/


"FinalizationError(UnknownIssuance)" on fetch

When I tested spend + reissue I encountered "FinalizationError(UnknownIssuance)", and then it worked again without restarting (federations, clientd) or changing anything. The reissue status was Accepted though :

https://github.com/fedimint/minimint/blob/19fcfdbff4b30fa068c54237f995cf7c729f50f9/mint-client/src/mint/mod.rs#L177-L185

I just noticed this happens a lot for me just hadn't noticed it

I think no one was using the bare fetch_coins fn so far, so it not having retry logic went unnoticed:
https://github.com/fedimint/minimint/blob/19fcfdbff4b30fa068c54237f995cf7c729f50f9/mint-client/src/clients/user.rs#L269-L276
Ideally (in the short term) there'd probably be something like this
https://github.com/fedimint/minimint/blob/19fcfdbff4b30fa068c54237f995cf7c729f50f9/mint-client/src/mint/mod.rs#L234-L247
Later on I'd like to build long polling or some other form of notification system without polling.

I don't use the bare fetch_coins() (in clientd::fetch) the problem was that I was getting a non-retry-able error when I should get a retry-able one. (I was confused and didn't explained that thought). I think I found a simple solution, by just swaping the order of https://github.com/fedimint/minimint/blob/de567ba89b4fd015bee9a2596ebbf00f55bc1c62/mint-client/src/mint/mod.rs#L178-L185 and https://github.com/fedimint/minimint/blob/de567ba89b4fd015bee9a2596ebbf00f55bc1c62/mint-client/src/mint/mod.rs#L187-L192 but now I always get errors like this :

(the problem is that when the bsig is not ready the 'let issuance = ...' returnes UnknownIssuance)

Oh right, I got confused. When you read the error description of UnknownIssuance it says that the client doesn't know the issuance, so even if it existed in the federation it couldn't retrieve the coins. Swapping things around doesn't really fix anything imo? Why it looks like success: in the worst case it now fails with a retryable error all the time and sends you into an infinite loop that way if the issucance actually doesn't exist, in the best case you get a response but can't finalize it because it doesn't exist in the DB.

In my case it worked but that's right this is no solution since in not my specific case that  would end in an endless loop.

The the important method here is reissue_validate : https://github.com/NicolaLS/minimint/blob/fd98ea2da74aacf7368dc998c95abb157aeb2fec/mint-client/src/bin/clientd/main.rs#L306-L331
it just waits for the federation to 'Accept' the coins and then fetches BUT when the coins are 'Accepted' there is no sign response imediatley which caused the error because my fetch_tx_outcome looks like this : https://github.com/NicolaLS/minimint/blob/fd98ea2da74aacf7368dc998c95abb157aeb2fec/mint-client/src/clients/user.rs#L391-L410 I changed it to also wait for the sign response but that made reissue_validate take much longer (but it solved the error). See the diff from first pic and this one :

My first idea would be to put additional logic in the .ok_or(...) in fetch_coins to either return a OutputNotReadyYet OR an FinalizationError. Will try to implement now and link it later

Would this be a solution ?
https://github.com/NicolaLS/minimint/commit/5ed1948a17a3e582b3d23169a1f99fbff98de063

Ah, now I understand what's happening: the client isn't really safe when run in parallel. Easiest fix would be putting the client into a Mutex (ideally a tokio one imo). When you run fetch_all_coins in parallel it first queries a list of all ongoing issuances but then queries each issuance a second time later on. If it was processed and removed in another thread in the meantime that gives you this error.
The blocking with a Mutex would make the client slow. If a fetch is ongoing no other requests would be processed. An alternative would be to only introduce more fine grained locks for different operations:

fetch: allow only 1 (have one thread running all the time for fetching)
receive: infinitely many
send: allow only 1

I think we could use a bunch of Mutex<()> for this.
For a better solution I'd like to wait for a fix to #25 since that will allow database transactions hopefully sidestepping the whole problem.

Are the two most recent commits in #55 sufficient ?


CI: address the bug with .env

to properly trigger Simnet.
Also, add TRIGGERER for more grained pipelines there.

@bkchr this label was needed to start gitlab CI

What does the trivial label starts?

@bkchr the trivial label is for PRs which do not require an audit

@bkchr the trivial label is for PRs which do not require an audit

I know, I requested the label. However, @TriplEight said this label started a special ci job and I want to know which.
This pr doesn't need the trivial label as it doesn't touch anything runtime related and the bot not enforcing it.

@bkchr now, without D* label, GitLab CI jobs won't start.


Export LIBRARY_PATH variable

Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.68%.  Consider uploading reports for the commit 456df2e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   89.68%   89.68%
=======================================
  Files         107      107
  Lines       34759    34759
=======================================
  Hits        31175    31175
  Misses       3584     3584

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add keyboard shortcut to mark channel as read

Summary

Adds a keyboard shortcut (Alt/Option-L) to mark a channel as read.
Ticket Link

No ticket. The substantive changes here are under 20 lines, though the overall pull request is larger for documentation + test updates.
Related Pull Requests

N/A
Screenshots

before
after

Release Note

Added a new keyboard shortcut to mark a channel as read.

Hello @3ach,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Sorry, this isn't ready for review yet, I was just putting it up so that I could get some idea of what tests and things will need fixing.

Thanks for the PR, @3ach! I've added @esethna as a reviewer since he's got more of an idea of what features we want to add. I'm not sure I understand the use case for marking the current channel as read though. That's done automatically when viewing a channel (as long as the user hasn't manually marked it as unread), so I don't know when a user would want to do that.
If that's not something we want to add though, I could see taking this in a slightly different direction though by either changing it to a shortcut to mark all channels as read since we have a ticket for that (and a second one actually, or making it a shortcut that either marks the channel as read or unread. Both of those would obviously require additional work though, so I'm curious to know if I'm missing something first with how you'd want to use this.

+1 to Harrison's thoughts @3ach. If you're keen to adapt this contribution to either of these tickets we'd be happy to accept it.

Shortcut to mark all channels as read: https://mattermost.atlassian.net/browse/MM-2541
"Mark as unread" added to the channel ... menu in the sidebar: https://mattermost.atlassian.net/browse/MM-28016

If not, can you help us understand your use case a bit more?

The specific workflow I have here is for monitoring a single channel with a fairly high amount of chatter. When I first enter the channel, I have an orange line marking the top of messages sent since I was last in the channel. That line moves up as more messages enter the channel, but I wanted a way to mark that I've read the channel to its bottom now, and would like the marker to reappear if more messages come in (so if I flip to a different desktop, then back, I can easily catch up).
Right now, the only way I've found to do this is to click into a new channel, and come back to my original one. This works but is a little annoying; I am currently migrating from IRC and I know that a similar shortcut exists in at least four separate clients. I also then either need to make sure I read all the messages I'm marking as read in the second channel (by opening it) or find a channel with no unread messages as the secondary channel.
It's not the same as marking all channels as read (though I'm happy to add a shortcut to do so, in this PR or another.) I wouldn't consider mark-all as a replacement for mark-this.
I can also add a 'mark unread' to the ... menu in the sidebar, which would do the same thing, but I was kind of hoping for a keyboard shortcut for this. Overall, I'd love to add more keyboard shortcuts throughout Mattermost, and if there's a good place to discuss the overall plan around those, I'd be happy to join.

Okay, I can understand that. I don't know if I've run into that specific case in Mattermost myself, but it's probably because we have so many channels that I'm switching a lot to constantly clear that line. I think I might've also wanted that feature in Discord in the past though since I'm used to using fewer channels there.
Is the alt+L shortcut taken from somewhere else? I'm wondering if there's a standard hotkey for this sort of functionality across other apps. Slack and Discord just use ESC for it, but we'd have to make sure closing modals and autocompletes don't also mark the channel as read if we go with that.

There's not a consistent hotkey across other clients that I know of. I didn't know Slack and Discord used ESC, we could do that (though it's a little overloaded... and my intuition for escape would be that it closes the current channel somehow.) Your points about making sure ESC is not misinterpreted also seems tricky, since right now keyboard shortcuts are kind of scattered all over the codebase for the webapp. It would be awesome if they were all in one place, and much easier to avoid conflicts.
I mostly only have experience with IRC clients, and it's all over the map (Cmd+L/Cmd+M are the most common. The reason I chose Alt+L instead of Cmd/Ctrl+L was that Cmd/Ctrl+L already has an extremely well-accepted meaning in browsers -- focus the address bar. So, Alt+L.

Thanks for explaining your use case, makes a lot of sense now! +1 to using ESC given it's common usage in Discord and Slack. Since we also plan to implement the "mark all channels as read" with Shift + ESC, I think it works well to use ESC for this (as long as we can make sure it only takes effect if no modals or menus are open).
@3ach feel free to also take on the mark all channels as read shortcut if you're keen to continue this theme after this improvement

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @aspleenic

Alright, in that case, I think we should switch the hotkey to the escape key for consistency since many of our users comes from Slack, Discord, and such. For handling any potential conflicts which could come from menus, autocompletes, or modals, I think we might be able to handle that by either:

Having those stop propagation of the event or using preventDefault which the mark as read shortcut watches for
In the mark as read shortcut handler, have it look at document.activeElement and walk up the DOM tree to see if it's a child of any of those components. For example, I think our menus that close on escape are all wrapped with a MenuWrapper class.
I think either way of doing that would work, so you could go with whichever seems better to you.

As for the mark all as read hotkey, I think we can leave that for a separate PR. I think it'll require adding a new API to the server, so it'd be better to handle that separately.

OK, ready for review again. I've split this into two commits: one adding stopPropagation to handlers which may consume the event first, so that their running will prevent the read marker from being cleared. Then, the second commit actually adds the marker.

@hmhealey d'oh. Sorry, updated, thanks for catching it.
Yeah, I do sort of worry about more collisions if we continue to want more keyboard shortcuts. These are spread all over the components, there might be a better way to centralize/coordinate them to avoid having weird behavior in the future. Happy to discuss further if you're interested :)

@hmhealey d'oh. Sorry, updated, thanks for catching it.
Yeah, I do sort of worry about more collisions if we continue to want more keyboard shortcuts. These are spread all over the components, there might be a better way to centralize/coordinate them to avoid having weird behavior in the future. Happy to discuss further if you're interested :)

@3ach We are actually looking forward to doing something like this mostly with the help of Awesome community members like you and maybe using a library like https://www.npmjs.com/package/react-hotkeys. But still, open for discussion. Would love to discuss this further on our community server (Drop me a message @ashish.dhama). Thanks a lot.

We probably need QA on this. It didn't seem to work for me. Is cleared the new message line on ESC, but the sidebar didn't update (to unbold the channel after marking a post as unread and then hitting ESC), and then when i returned to the channel the new messages line reappeared
cc// @jgilliam17

(force-push to fix tests)

/update-branch

@3ach Could you please update the failing test, Otherwise looks good to me.

The files .circleci/config.yml, Makefile are in the blocklist for external contributors. Hence, these changes are not tested by the CI pipeline active until the build is re-triggered by a core committer or the PR is merged. Please be careful when reviewing it.
/cc @mattermost/core-security @mattermost/core-build-engineers

Rebased + fixed snapshot.

/e2e-test

Triggering e2e testing with options:
<nil>

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/108113

/update-branch

Thanks @3ach

Thanks you for your contribution, would you be able to add an automated cypress test for this?
I created a test case MM-T4608 MM-T4608 should be used as the ID for the automated test.
E2E report looks good, no PR related failures.
Seeing one issue when using esc
When using esc to closing modals it is also marking the channel as read

@3ach Let me know if you have any questions about one remaining issue mentioned here. Thanks

I will submit a test, I have just gotten busy. I should have time in the second half of this or early next week.

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @aspleenic

Hello @3ach Let us know if you need help getting this to finish line 🙂


Options in attributes

Adds de capacity to have more fields when defining attributes

Coverage increased (+0.003%) to 99.781% when pulling 23fb6b2dc903187ed729dfef0ec1886be02baa35 on LemontechSA:options_in_attributes into 51f5c1b017e6d389446a87bf02598fee844605fd on davydovanton:master.


1.2.0 how to programmatically set slider page

we use version 1.2.0, and did not find a way to move slider images programmatically (our app is installed on android TV using remote control actions)
bdw, I've seen version 1.3.2 has the option to set a page, the problem is the code example in the readme file is not even compiling. so we stay with 1.2.0 for now

we use version 1.2.0, and did not find a way to move slider images programmatically (our app is installed on android TV using remote control actions)
bdw, I've seen version 1.3.2 has the option to set a page, the problem is the code example in the readme file is not even compiling. so we stay with 1.2.0 for now

If you are using appcompat libraries use this version :
implementation 'com.github.smarteist:autoimageslider:1.3.2-appcompat'


Alpha-2 (0.87.0): oc logs: remote error: tls: internal error

log can not be viewed...
How to reproduce:
$ oc new-project demo
$ oc process openshift//eap72-mongodb-s2i|oc apply -f -
$ oc get pod
NAME                       READY     STATUS      RESTARTS   AGE
eap-app-1-build            1/1       Running     0          3m34s
eap-app-mongodb-1-deploy   0/1       Completed   0          3m33s
eap-app-mongodb-1-r7827    1/1       Running     0          3m21s
$ oc logs eap-app-1-build
Error from server: Get https://crc-4gdnp-master-0:10250/containerLogs/demo/eap-app-1-build/sti-build: remote error: tls: internal error
$ oc logs eap-app-mongodb-1-r7827
Error from server: Get https://crc-4gdnp-master-0:10250/containerLogs/demo/eap-app-mongodb-1-r7827/eap-app-mongodb: remote error: tls: internal error

@rbaumgar this is happen because there is no virtualbox provider so you need to approve the csr manually, try below command to do it.
$ oc adm certificate approve $(oc get csr | egrep ^csr | awk '{ print $1 }')

work around works! Thanks
but I am using libvirt...

@rbaumgar in libvirt we didn't see this before, will check what changed there.

I'm also facing the issue on libvirt (0.87.0)

If that matters I saw tls: internal error in OSX as well.

it affects the image/c;luster... it is not related to the hypervisor

on libvirt machine config operator should auto approve those csr which is not happening atm, we need to find what changed.

Question: is that workaround (oc adm certificate...) required to be periodically run? Say I create and delete a bunch of deployments/pods over time - will I need to run that workaround each time I deploy new things? Or are those certificates fixed after startup and I only have to run that "oc adm" command once?

@jmazzitelli I ran this command once 10 days ago and did not face the error again


Inlined process typings causing conflicts

Hi, appreciate the teams work setting up these dev plugins - it has helped our transition away from Flipper.
One issue however, is that since the process env definitions were inlined, we are getting failures in CI such as these:

Here is the offending type definition:
https://github.com/expo/dev-plugins/blame/917d64066815e8cdc0b59641bae44b4abc07c0ca/packages/apollo-client/src/index.ts#L1
With the changes to how environment variables are loaded out of the box in SDK 49, this may cause issues for other users and I wanted to help them avoid spending hours trying to find the source of the error.
I currently patch the library by including @types/node and including it in the tsconfig.

thanks for reporting the issue. please try out<EMAIL_ADDRESS>and let me know whether it works for you.