MouseController depends on Tree#model

This is a follow-up on https://github.com/microsoft/vscode/pull/166486 and https://github.com/microsoft/vscode/issues/166478 where I simply make the model-property of the tree public. Tho, a better fix might be needed here

👏


Edge/Chrome with version 85+ fail to load video content

Describe the bug
All Chromium based browsers (Edge and Chrome) past version 85 cannot load video content.
All Chromium based browser with version 84 and below cannot load video content if additional referrer security is enabled.
To Reproduce

Open the Learning Pathways Site in Edge or Chrome
Select any content that contains a video (eg What is Microsoft Teams)
All content loads except the video

Expected behavior
Video loads and plays without issue
Screenshots

Learning Pathways version number
3.x
4.1.x
Additional context
Workaround for Edge/Chrome 85/86

Load edge://flags  (chrome://flags for Chrome)
Search for referrer
Disable Reduce default 'referrer' header granularity
Restart browser.

For Edge/Chrome 84 and below, perform the same steps except Enable this setting to replicate Edge/Chrome 85+ default behavior.
Detailed diagnosis
From Fiddler traces with Edge 85+

Once the page loads, the page attempts to get the video player from https://videoplayercdn.osi.office.net/s/js/vxp.js with referrer as https://support.office.com
This page returns a 302 and redirects the browser to https://www.microsoft.com/videoplayer/js/vxpiframe.js
The browser attempts to load https://www.microsoft.com/client/en-us/videoplayer/embed/RE1LGec?pid=ocpVideo0-innerdiv-oneplayer&jsapi=true&postJsllMsg=true&maskLevel=20&market=en-us
Another 302 to https://www.microsoft.com/en-au/client/en-us/videoplayer/embed/RE1LGec?pid=ocpVideo0-innerdiv-oneplayer&jsapi=true&postJsllMsg=true&maskLevel=20&rtc=1
Resulting in another 302 redirect to Location: https://www.microsoft.com/library/errorpages/smarterror.aspx?correlationId=pLDNP7MeMEekH1X<IP_ADDRESS>
And finally a 404 as this page is not available.

When Reduce default 'referrer' header granularity is disabled or default behavior in Edge/Chrome 84 and below.

Request to https://videoplayercdn.osi.office.net/s/js/vxp.js as before but this time with the referrer as https://support.office.com/en-us/client/4422bf3aa-9ae8-46f1-83a2-e65720e1a34d?embed=true&fromOrigin=https://tenantnameremoved.sharepoint.com
This redirects to https://support.office.com/client/videoplayer/js/vxpiframe.js now which allows the video to load.

Root Cause: Video player requires the additional query strings to determine the correct site to redirect the browser and find the video player.

Duplicate #333

Heard back from Microsoft.  A fix for this issue has been deployed worldwide.  Testing in our environments shows that this is resolved.

I can confirm that I have also been told the issue is fixed.  Closing, thanks all for reporting.


Branding updates for Preview 3

Fixes https://github.com/dotnet/aspire/issues/2975
cc: @radical
Microsoft Reviewers: Open in CodeFlow

/azp run dotnet.aspire


Change natales to potiguar

I would like to change the term "natales"  to "potiguares", following the logic of "Bahia - baianes", "Minas Gerais - mineires", "Paraná - paranaes", and because it would open to a wide range of possibilities regarding to dialects from the country town.

Is true @lmedson, thanks about this point and please send a PR for project  \0/


[Bug] json language matching brackets not highlighted

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[ ] Not reproducible in the monaco editor playground

Monaco Editor Playground Link
Current Broken Version (latest):
https://microsoft.github.io/monaco-editor/playground.html?source=v0.36.1#XQAAAAI5AQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscrHQDZUcqL2Gu_y6-pesM5CAK4Rl2SA3OZZypoZAb43HgZ99s3BRMgXtreldIbr5SD4XF5Tatz5q50l9C62FqPMzPpUOWn0KyP2OajTzBZa3r3xwFuz_bvlBduMYE4EJ1jKJvqTNpAOrjRdK3jtBTzQOXj5_qIDbaqXPzfb5D1SHpUF1n8kjogmjV1xItO7tOO1PQ8z-sIBrqo5PvQKHC-agBecyvVVfLlwrxQbBp-cAedPSral5liedjr3fSsYJrtO9__96qDrw
Last Working Version (0.33.0):
https://microsoft.github.io/monaco-editor/playground.html?source=v0.33.0#XQAAAAI5AQAAAAAAAABBqQkHQ5NjdMjwa-jY7SIQ9S7DNlzs5W-mwj0fe1ZCDRFc9ws9XQE0SJE1jc2VKxhaLFIw9vEWSxW3yscrHQDZUcqL2Gu_y6-pesM5CAK4Rl2SA3OZZypoZAb43HgZ99s3BRMgXtreldIbr5SD4XF5Tatz5q50l9C62FqPMzPpUOWn0KyP2OajTzBZa3r3xwFuz_bvlBduMYE4EJ1jKJvqTNpAOrjRdK3jtBTzQOXj5_qIDbaqXPzfb5D1SHpUF1n8kjogmjV1xItO7tOO1PQ8z-sIBrqo5PvQKHC-agBecyvVVfLlwrxQbBp-cAedPSral5liedjr3fSsYJrtO9__96qDrw
Monaco Editor Playground Code
const text = `{
	"array-brackets": [],
	"object-brackets": {
		"value": 1
	}
}`;

// Hover on each property to see its docs!
monaco.editor.create(document.getElementById("container"), {
	value: text,
	language: "json",
	automaticLayout: true,
});

Reproduction Steps
Use as language "json", open the editor with valid json data, e.g:
{ 	"array-brackets": [], 	"object-brackets": { 		"value": 1 	} }
If the editor is opened, move the cursor to one of the brackets, e.g { or [.
Now the bracket pairs should be highlighted.
Actual (Problematic) Behavior
Matching Brackets are not highlighted:

Expected Behavior
Expected that the matching brackets are highlighted:

Additional Context
With the language "javascript" it is working as expected.
The difference I observed is that in case of javascript the lexer editor/standalone/common/monarch/monarchLexer.ts is invoked and every token line is marked with the flag MetadataConsts.BALANCED_BRACKETS_MASK:
const metadata = this._theme.match(this._currentLanguageId, type) | MetadataConsts.BALANCED_BRACKETS_MASK;
In the case of json the editor/standalone/browser/standaloneLanguages.ts is analyzing the tokens and here in the method _toBinaryTokens is looking up the line tokens metadata from the color theme, but without combining it with the MetadataConsts.BALANCED_BRACKETS_MASK.
In my custom project I hacked this into the code and it solved the problem. But I'm really only guessing and have no deep understanding of the code responsibilities.

In the case of json the editor/standalone/browser/standaloneLanguages.ts is analyzing the tokens and here in the method _toBinaryTokens is looking up the line tokens metadata from the color theme, but without combining it with the MetadataConsts.BALANCED_BRACKETS_MASK.

In my custom project I hacked this into the code and it solved the problem. But I'm really only guessing and have no deep understanding of the code responsibilities.
Thanks for looking into it! That seems to be exactly the issue!
It would be awesome if you could provide a PR that fixes this!

When is planned release with this fix? latest version 0.39.0-dev.20230529 still does not match brackets.

Works for me:

I also encountered such a problem, but I defined a new language.

In my case it's related but not same problem, I have defined custom language and I'm using tokenizer. I open new issue.


DOCS: Numpydocs1

🚀 Pull Request
Description
Progressing numpydoc strings adoption, https://github.com/SciTools/iris/issues/4721.
Notes

I have ensure numpydoc style where possible by refactoring existing docstring, I have not labelled every single type etc, this is an improvement not a 100% perfect docstring.
Where appropriate I have added # noqa: D102 or # noqa: D102 (see error codes desc).  This comment will skip the checks for the subsequent line.
A single line summary is needed on functions.  I used the first part of the summary for this so there maybe a little duplication but I think that is ok
In lib/iris/fileformats/netcdf/saver.py there are a couple of very long links, these would render with a horizontal scroll which looks weird, so I used a text and a url instead.

pydocstyle test output
No errors/warnings raised.  Commands used:
pydocstyle --convention=numpy --add-ignore=D105 ../lib/iris/config.py
pydocstyle --convention=numpy --add-ignore=D105 ../lib/iris/fileformats/netcdf/__init__.py
pydocstyle --convention=numpy --add-ignore=D105 ../lib/iris/fileformats/netcdf/_dask_locks.py
pydocstyle --convention=numpy --add-ignore=D105 ../lib/iris/fileformats/netcdf/_thread_safe_nc.py
pydocstyle --convention=numpy --add-ignore=D105 ../lib/iris/fileformats/netcdf/loader.py
pydocstyle --convention=numpy --add-ignore=D105 ../lib/iris/fileformats/netcdf/saver.py
pydocstyle --convention=numpy --add-ignore=D105 ../lib/iris/io/__init__.py
pydocstyle --convention=numpy --add-ignore=D105 ../lib/iris/io/format_picker.py
pydocstyle --convention=numpy --add-ignore=D105 ../lib/iris/time.py

Links to current and new API docs
Note, some files are private so are not rendered in the docs.

current, new: lib/iris/config.py
current, new: lib/iris/fileformats/netcdf/__init__.py
lib/iris/fileformats/netcdf/_dask_locks.py
lib/iris/fileformats/netcdf/_thread_safe_nc.py
current, new: lib/iris/fileformats/netcdf/loader.py
current, new: lib/iris/fileformats/netcdf/saver.py
current, new: lib/iris/io/__init__.py
current, new: lib/iris/io/format_picker.py
current, new: lib/iris/time.py

Consult Iris pull request check list

Review actions https://github.com/SciTools/iris/pull/5578/commits/506968f1b36f723ff3f82237ed5b71911eb5aabd


Setting tests to fail if screenshots have any differences rather than…

… the previous value of 1%.
Description
Please explain the changes you made here.
Release notes:
Describe the change as it should be communicated to partners in the release notes.
Checklist

[ ] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)
Fixes #<issue_number>; Fixes #<issue_number>; Fixes #<issue_number>...

Codecov Report

Merging #3486 (24b100c) into main (43af8b9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3486   +/-   ##
=========================================
  Coverage     80.51%   80.51%
  Complexity     2397     2397
=========================================
  Files           293      293
  Lines          9517     9517
  Branches        647      647
=========================================
  Hits           7663     7663
  Misses         1602     1602
  Partials        252      252

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Render to a specific place

Is it possible to do something like
vroom('#hereItGoes');
to render the interface to a certain <div> ?
It looks like I have to call the method right now at the place I want it which is not easy in my case, as I load the Javascript at the page's bottom.

Same here. Would be great to be able to create at a certain location more easily.

@amenk , @rolero: Could you explain the use case for this? What you are trying to achieve, are you doing this with a new theme you created, etc.
This will help me implement this in a way that is most helpful to as many people as possible.
Thank you.

yes, to include into an existing page

I understand that, but can you explain why you need it in a certain div? Are you using a custom theme? The existing themes position the UI with absolute position on the page, so which div they are in will make no difference.

I forgot it ... :-) Currently I am not using it - maybe later ...

@rolero - If you can help with the use case for this, please comment below and I will reopen the issue.

For sure I have a use case :) Sorry for the slow response but I am working in China. Have a look at the following website: https://beta.medai.io/
Currently I removed KITT but actually I wanted it where  the "Get Started" button is located. I was only able to load it in the left below corner or I need to adjust the theme.
What I would like to do, is that I give a certain element an id like  . The button I replace with this div.
Then using jQuery I activate Kitt. For example when the website/document is loaded:
$(document).ready(function () {
$('#loadkitthere').SpeechKITT.vroom(); //Just a sample.
});
Then the Kitt GUI is located where this div is located and moves when the divs moves( for example when responsive CSS kicks in). The GUI itself was already great. I like the button a lot.
Another question. Do you have any experience with connecting KITT with IBM Watson conversations? I am currently developing a WEBAPI that will work as a middleware solution, so that I can store data and also can execute other functions like showing certain data etc. For a BETA I actually want to connect it with IBM Watson directly.
Best regards,
Ron


Frontend: Create a reducer for Alerts

Is your feature request related to a problem? Please describe.

Creating a Alert reducer would be helpful to use whenever we want to add a alert in frontend.

Describe the solution you'd like

I will create a alert reducer that would call whenever we want to use a alert.

@purnima143 could you please assign this to me ?

@sachinsom93 Ya go ahead


Create icon do display in VSCode Activty Bar

I could not find the file media/python.svg, so I created the file vscode-ext/examples/media/python.svg. Below you can see the python icon displaying in the activity bar.
s/media.
Another recommendation is to change the README.me,  with easier directions instructions on how to run directly from the repository.

In VS Code:, open the folder .../vscode-ext/example
pip install virtualenv
python -m virtualenv .venv
.venv\Scripts\activate
pip install ..
python .py
depress F5

Please not every time you compile ,py, the files extension.p, extension.js,, extension.json and launch.json will change accordingly.

Closing this since that is supposed to be an example and people can themselves add it if they want.


Documentation

[x] Installation instructions
[ ] High level introductory overview

[ ] Naming conventions (in particular mBuild vs. MDTraj components)

[ ] Tutorials

[x] Methane: Atoms, Bonds and Compounds and their labeling
[x] Ethane: Ports, coordinate transforms and reading from files
[ ] Monolayer: Complex hierarchies, masks, tiling and writing to files
[ ] Try out interactive [ipython notebooks with mayavi]
(http://nbviewer.ipython.org/github/mroberts3000/IPythonIsGreat/blob/master/IPython/02 Interactively Exploring your Data with Mayavi.ipynb) 3D rendering! (not sure if the 3D will work, but 2D will)

[ ] Development

[x] How to contribute
[ ] Gallery of cool structures?
[ ] Atomtyping how-to

[ ] Autodoc API

[x] Sphinx setup
[x] Proper versioning in docs/setup.py
[ ] Proper doc strings throughout the code
[ ] Simple automated re-building and push to latest

[ ] github.io website for now (can look into custom domain later)

Random notes:

[ ] Emphasize that internal units are nanometers
[ ] Fix layout of tutorial doc files. Currently all of them are in tutorials.rst and the ones in the folder tutorials aren't used)


bugs in preprocess()

Traceback (most recent call last):
File "C:\Users\96473\Desktop\aotohelper\answer_helper\auto_answer.py", line 16, in
positions = preprocess()
File "C:\Users\96473\Desktop\aotohelper\answer_helper\ulits.py", line 37, in preprocess
pixel = pixels[500, top]
IndexError: image index out of range

这个不是bug，根据自己的手机调整一下参数就行


Finalizing Call Status

Here is a reference to the JIRA DeVX board for this qs:

https://nexmoinc.atlassian.net/browse/DEVX-92

Here is a reference to the JIRA "Technical Spec":

https://nexmoinc.atlassian.net/wiki/spaces/STCH/pages/260211023/Call+States+-+Technical+Spec

Here is a reference to the peer reviewed Pull Request that has been merged into master:

https://github.com/nexmoinc/conversation-ios-sdk/pull/268

Here is the list of requirements outlined by @mariatechmaniac:
a small code snippet as to how the dev can retrieve it
+
a table with all and what each means
+
a disclaimer that their accuracy depends on the carrier. more specifically, sometimes what is really a busy state is relayed as rejected.
+
a note stating that they are valid for all 1:1 call combinations( ip ip , ip pstn etc) for group calls;
+
The only code you would show is the expected response after the end of the call. Showing how one can retrieve the call state, what it means and possibly explaining what those SIP codes mean.

Here is code for call state:
https://github.com/nexmoinc/conversation-ios-sdk/blob/3f24d0d71f90824eb99ce1bb415c93ae138aa3e5/Stitch/Core/Controller/Call.swift#L174
Here is an example of call state:
https://github.com/nexmoinc/conversation-ios-sdk/blob/3f24d0d71f90824eb99ce1bb415c93ae138aa3e5/Demo/ViewControllers/call/CallViewController.swift#L65

Here is the state enumeration reference in the iOS documents that are 100% complete: https://developer.nexmo.com/sdk/stitch/ios/Classes/Call/State.html#/s:6Stitch4CallC5StateO7startedA2EmF

Here is the Voice API specs with a similar set of state changes: https://developer.nexmo.com/voice/voice-api/guides/handle-call-status

Thanks, @mariatechmaniac! I will update the .md with your recommendations! ;)

VAPI call states https://nexmo-developer-staging-pr-721.herokuapp.com/voice/voice-api/guides/call-flow

@mheap Should busy be in this list of states: https://developer.nexmo.com/voice/voice-api/guides/call-flow It is in this current list.

Thanks, @mariatechmaniac. I will update these asap.


WIP Mentor Preferences edit/view page

What Github issue does this PR relate to?
Close #34
Changes proposed in this pull request:

add menu entry for mentor: Preferences
add Preferences page edit/view
[ ] save to Xata

What should the reviewer know?

The yaml file is formatted differently from yours, sorry about that: do you use any other setting / extension for it?

NB ~on local dev, it seems not to store the information, although~ it seems that handlePUT receives it. ~I will test it on the preview.~ also on the preview it does not seem to store the nested mentor object. The PUT sends the correct object as payload, and the endpoint responds "ok".

Screencast

Quality Assurance(QA) Checklist

[x] The app builds and runs properly

@tsg I seem not to be able to store the info of the nested mentor object into the profile of the user. Any hints?


Defer Javascript's orig_index attribute violates w3c validation

Error: Attribute orig_index not allowed on element script at this point.
Doctype is set to <!DOCTYPE html>

Looks like we should be using data-orig_index. In practical terms this isn't anything to be too concerned about, though.

Some of our clients use free website evaluation tools to check  the quality of our work. Most tools run a few pages through HTML validation and give bad scores when orig_index is present. While in practical terms unsupported attributes aren't a big issue, we must now choose between better page performance and better ratings from automated tools.
Additionally, changing it to data-origi_index would put it in line with the <IP_ADDRESS>-beta release notes (HTML5 compliant attributes)

Hmm, trouble: caching of JS on the client means the server can't produce the new attribute. Should probably look into version of the JS then,

@morlovich pretty sure the js is named with a hash so we can change it however we need to and get longcache invalidation

http://www.jefftk.com/pagespeed_static/js_defer.tRzI7EHUpg.js

Oh, cool, thanks. That makes this straightforward then.

If there's one thing PageSpeed knows how to do, it's name resources with hashes of their contents so we don't have to worry about invalidation!


About checkpoint parameter

Hi，thank you for your great work☺
I download the checkpoint with 2048 latents，but I notice the shape of the parameter ‘_qnet.module.pos_encoding‘ is torch.Size([1, 20, 20, 20, 128])，which means pos_encoding_with_lang = False，did I misunderstand or there was no language condition for position encoding during training the checkpoint ?

@TengBoYuu, there is language conditioning, but there is no positional embeddings for those lang tokens. So "put the marker in the drawer" is treated as a bag of words.

Okay, thank you. I see what you mean.


Use Travis CI to find syntax errors and undefined names

Bare bones Travis setup for Python projects

@sophron Your review please?


Introducing IInputConverterProvider interface

Introducing IInputConverterProvider interface  to provide information about what converters to be used for bindings. This will allow binding authors to provide information about what specific converter to be used during the input conversion of that binding entry.
This is part 1 of the fix for #1121. I will have a follow up PR which consumes this version of the Microsoft.Azure.Functions.Worker.Extensions.Abstractions nuget package in the Grpc layer and use it.

Do we want to leverage the existing TypeConverter in dotnet?

I also brought up a question in the linked issue:

have we considered this alternative: instead of introducing the new contract, let the binding attribute implement IInputConverter itself and we will test for that contract and use it if present.

Abandoning this PR as the approach used here won't work to get the needed information we need when writing an analyzer. Going to switch to the attribute approach in a new PR.

Do we want to leverage the existing TypeConverter in dotnet?

Let's sync offline on this.


📚[DOC]: Hurricane Tracking Example

How would you describe the priority of this documentation request
Critical (currently preventing usage)
Is this for new documentation, or an update to existing docs?
New
Describe the incorrect/future/missing documentation
Example of tracking TCs with some traditional method comparable to Pangu weather

Won't do at the moment, added a diagnostic example with rain instead.


First login to UI times out when user has hundreds of projects

The UI login of a user with hundreds of projects in OpenStack takes so long that it times out. Subsequent attempts are successful though.

reason is O(n) calls to Keystone when Maia collects the project list for the user
These calls can be avoided if project metadata (project-name, domain-id, domain-name) is cached globally.

There is a regression somewhere which causes service user token refresh to fail. This is either a side-effect of the other changes or a change in behaviour of the more recent Gophercloud version.

so this is the regression in Gophercloud: https://github.com/gophercloud/gophercloud/commit/c818fa66e4c88b30db28038fe3f18f2f4a0db9a8
Introduces a deadlock when ever a custom reauthentication() function uses gophercloud API to do so. Maybe this is fixed by https://github.com/gophercloud/gophercloud/pull/1464, but meanwhile I learned that I can just use the built-in reauthentication introduced a year ago.

fixed


Tests | Junit improvements + Organize constants

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@78efb57). Click here to learn what that means.
The diff coverage is 100%.

@@          Coverage Diff           @@
##             dev     #982   +/-   ##
======================================
  Coverage       ?   50.56%
  Complexity     ?     2918
======================================
  Files          ?      120
  Lines          ?    27996
  Branches       ?     4681
======================================
  Hits           ?    14157
  Misses         ?    11541
  Partials       ?     2298

Flag
Coverage Δ
Complexity Δ

#JDBC42
50.15% <100%> (?)
2879 <1> (?)

#JDBC43
50.5% <100%> (?)
2913 <1> (?)

Impacted Files
Coverage Δ
Complexity Δ

...m/microsoft/sqlserver/jdbc/SQLServerStatement.java
61% <ø> (ø)
138 <0> (?)

...m/microsoft/sqlserver/jdbc/SQLServerSavepoint.java
90% <ø> (ø)
10 <0> (?)

...om/microsoft/sqlserver/jdbc/SQLServerMetaData.java
21.81% <ø> (ø)
0 <0> (?)

...oft/sqlserver/jdbc/SQLServerResultSetMetaData.java
45.52% <ø> (ø)
27 <0> (?)

...ava/com/microsoft/sqlserver/jdbc/SQLServerLob.java
100% <100%> (ø)
1 <1> (?)

...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java
68.1% <100%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78efb57...502a2d2. Read the comment docs.


Add Steps component to kinsta.mdx

Add Steps component to kinsta.mdx
Adds the Step component where needed.

Lunaria Status Overview
🌕 This pull request will trigger status changes.

Learn more
By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.
You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale
File
Note

en
guides/deploy/kinsta.mdx
Source changed, localizations will be marked as outdated.

Warnings reference

Icon
Description

🔄
The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

!coauthor


Please return back D3D10.

Hi,
I'm working on a game and game tools with SharpDX.
My target platform is Win7 and I'm using D2D interoperation.
But DX11 in Win7 dose not fully support D2D inerop as I know.
http://stackoverflow.com/questions/11771257/using-direct2d-to-draw-on-direct3d11-surface
Definitely, the MS had been guaranteed the interoperation only with the D3D10.1 by their document.
https://msdn.microsoft.com/en-us/library/windows/desktop/dd370966(v=vs.85).aspx
(DX12+ has been guaranteed as well. but my target platform is Win7 that is using DX11.)
I'm sure about that SharDX had supported D2D10 but not now.
Maybe you thought D3D10 is needless because of D3D11 and 12 but it's not.
Please return back D3D10.

I second this. I need the ability to do some 2D for an app I am working on for HoloLens: basic text and basic overlays. I have been researching all day and can't find anything linking these two other than what is mentioned above (shared device between Direct3D 10 and Direct2D).

Have you try to install https://support.microsoft.com/en-us/kb/2670838 ?
For reference http://stackoverflow.com/a/31868992/1356325
I removed D3D10 based on this, but it may not be ideal if the KB above doesn't work or it is not installed automatically by a Windows updarte (I thought it was), so I will have to restore D3D10.

Yes, it has not installed automatically. Checked my Windows 7.
And I don't think, it's a master solution.
Some end user should suffer about this. And should drop reliability of my SWs.
As you know and the article said, only support partially in Win7. It's not change when the update installed.
Maybe in other nations' people use new Windows such as 8 and 10 popularly.
But in our nation, most popular Windows is 7 yet and I'm using it as well. So I need full interface in Win7.

I'd like to third this. I have coded up a custom Direct2D WPF control for a games tool, and I'd like to support Win 7 - Win 10. I've stayed on 2.6.X so far, but I suspect I'm going to need to move to the latest at some point.

I'd like to third this. I have coded up a custom Direct2D WPF control for a games tool, and I'd like to support Win 7 - Win 10. I've stayed on 2.6.X so far, but I suspect I'm going to need to move to the latest at some point.

I've coded some sample using Direct3D11 and Direct2D using SharpDx. Here the archive
https://github.com/RobyDX/SharpDX_Demo
Check if they work on Windows 7 (I'm using Windows 10)

@RobyDX I already known about that it is working ALMOST of Win7s. But my objective is covering ALL of Win7s. NOT ALMOST. So I need guaranteed method.

Thanks to the work of @andrewst this should be fixed by latest commit. See #760
A new release will be done in the coming days with a new nuget package.


Make the Argent wallet connection faster

Description 📹
https://www.loom.com/share/a41077c55032420688bbf3b8e7c82ade
Proposed Actions 🛠
Here’s a checklist of actions to follow for resolving this issue:

Fork and Create Branch:
Fork the repository and create a new branch using the issue number:
git checkout -b fix-[issue-number]

Implement Changes:

[ ] Check the code details on argent-x auto-connect and connection process and improve it to connect faster

Run Tests and Commit Changes:
Make sure your changes don't break existing functionality and commit with a clear message:git commit -m "Fix: [Short description of the fix]"

Required 📋
To keep our workflow smooth, please make sure you follow these guidelines:

Assignment: Don't create a pull request if you weren’t assigned to this issue.
Timeframe: Complete the task within 3 business days.
Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
Review Process:

Once you've submitted your PR, change the label to "ready for review".
If changes are requested, address them and then update the label back to "ready for review" once done.

Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏
⚠ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

Hello @fricoben!
My name is Kevin Latino, and I'm a frontend developer and active open-source contributor. I'm a member of Dojo Coding, a thriving Web3 community in Costa Rica. I have experience with React, Next.js, and TypeScript, and I recently won the LATAM Hackathon hosted by Base. I've also contributed to projects in ecosystems like Starknet and Stellar.
I propose optimizing the Argent X connection by caching Starknet Kit connectors in a local state with useEffect to avoid recalculations and using useMemo to prioritize Argent X while minimizing redundant calls to connector.available(). Additionally, implementing an automatic connection attempt when Argent X is detected will significantly reduce latency, ensuring a faster and more seamless user experience.

I'd be happy to do this.

May I take care of this? Would love to tackle this! I can comfortably handle this issues

Mind if I try this one?

I’d like to resolve this.

Can I be assigned to this?

Could I try solving this?

May I try my hand at this?

Is it okay if I take this?

Let me try this one!

Could I take on this issue?

Hello @fricoben, I'd like to tackle this.
I would check the current implementation for any unnecessary process that could be delaying the connection.
I would also implement caching using useMemo for caching computations.
I would also implement a Connecting indicator to increase the perceived speed of the user.
I would also give you feedback on my progress with this.
ETA is 2 days

Hello ser can I work on this issue

Could I take a shot at this?

Could I take on this issue?

faiml sorry

will start to work on this issue


trigger a new build

Signed-off-by: liuwei<EMAIL_ADDRESS>

refer to https://github.com/open-cluster-management/backlog/issues/16302

/approve
/lgtm


EF fromSQL throws ArgumentNullException

I'm using C# (.net core v2.2) and EF core. I have pretty old code that is retrieving a row from the database:
string id = "123";
using (var context = new UsersDb())
{
    var req = context.ScanRequests.FromSql($"EXEC GetById {id}").FirstOrDefault();
    // ...
}

GetById is a stored procedure, written in Azure SQL (basically - SQL Server).
This code started to throw an exception recently:
System.ArgumentNullException: Value cannot be null.
Parameter name: key
   at System.Collections.Generic.Dictionary`2.FindEntry(TKey key)
   at System.Collections.Generic.Dictionary`2.TryGetValue(TKey key, TValue& value)
   at lambda_method(Closure , ServiceProviderEngineScope )
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService(IServiceProvider provider, Type serviceType)
   at Microsoft.Extensions.DependencyInjection.ServiceProviderServiceExtensions.GetRequiredService[T](IServiceProvider provider)
   at Microsoft.EntityFrameworkCore.DbContext.get_DbContextDependencies()
   at Microsoft.EntityFrameworkCore.DbContext.get_InternalServiceProvider()
   at Microsoft.EntityFrameworkCore.DbContext.get_DbContextDependencies()
   at Microsoft.EntityFrameworkCore.DbContext.get_Model()
   at Microsoft.EntityFrameworkCore.Internal.InternalDbSet`1.get_EntityType()
   at Microsoft.EntityFrameworkCore.Internal.InternalDbSet`1.get_EntityQueryable()
   at Microsoft.EntityFrameworkCore.Internal.InternalDbSet`1.System.Linq.IQueryable.get_Provider()
   at Microsoft.EntityFrameworkCore.RelationalQueryableExtensions.FromSql[TEntity](IQueryable`1 source, FormattableString sql)
   at ***.***Factory.<>c__DisplayClass0_0.<GetById>b__0() in /tmp/sources/SystemLayer/***/***.cs:line 29

This issue doesn't happen to me when I run the same code with the same parameters in a local environment. Also, in most cases it's also working on production servers. I guess it's at least 99.9% success rate.
The problematic line (line 29 from stacktrace) is this line:
var req = context.ScanRequests.FromSql($"EXEC GetById {id}").FirstOrDefault();

UPDATE
I thought maybe the problem is because of my mapping to the database - maybe the database schema has been changed without changing the EF accordingly. So I run the mapping command again:
Scaffold-DbContext "cs" ...

After re-generating the classes again, I found that no file has been changed since my last GIT commit. Therefor, my EF code is already aligned with the database schema.
What to do? What else should I check?
Further technical details
EF Core version: netcoreapp2.2
Database Provider: Azure Sql
Operating system: Linux debian
IDE: Visual Studio 2017 15.9.4

@Eilon Moving this to D.I. area since this looks like a concurrency issue in D.I.


EditText inside DialogSheet uneditable

Hi marcoscgdev,
I have recently update DialogSheet from 2.0.9 to 2.1.0 it was a great inprovement (good work dev :D). But, I found a problem in this version (2.1.0) that EditText (inside dialog, when using setView) are now uneditable, I can paste some text from clipboard, and I got warning from logcat:
W/TextView: TextView does not support text selection. Selection cancelled.
I also try set false or true in useNewStyle but that's gives me nothing. I can give my logcat if it's needed.
Thankyou :)

Apparently the issue has been resolved. I will publish a new release with this and other changes in a few days.
While I prepare the new release, you can use this build, which has this problem fixed:
implementation 'com.github.marcoscgdev:DialogSheet:5a4dc5d656'

Thank you for reporting this issue 😄

Fixed in version 2.1.1.


 They should be wrapped instead.
Fixes #3633.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Before:

After:

Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@haivp3010 thanks!


what's the meaning of "inside_weights"and"outside_weights" ?

i cannot understand the variables:
"bbox_inside_weights" and "bbox_outside_weights" in rpn/proposal_target_layer_cascade.py
https://github.com/jwyang/faster-rcnn.pytorch/blob/master/lib/model/rpn/proposal_target_layer_cascade.py#L54
can someone tell me what's the meaning of them?

Did anyone get time to take a look at this? I am still not able to figure out what is possibly their use and it is confusing me a lot


added customtemplates event & eventTitle

Hi
I added these two lines so the Custom-Templates for Event and EventTitle works like in the original Repo.

Hi,
Will it be merged? If you don't want the modification atleast we could change it and mege it right.

Hi, I think that the peer dependency on the package.json should be changed to be consistent. Maybe a comment about versions compatibility in the readme could be helpful, but not entirely necessary though.

Hey @diegofsza
Will it be merged? I really need that feature.


Add ROS interface integration tests

This was long overdue, and I found 3 whole bugs with the ROS interface in doing this:

The demos were not executable again for some reason...
An earlier refactor made it so the robot state was never being published
My previous PR actually broke the task plan action server (wrong field name)

This PR adds a set of integration tests that bring up the PyRoboSim ROS interface in headless mode and try hit several of the endpoints, including topics, services, and actions.
I also cleaned up the CMakeLists.txt for the pyrobosim_ros package so that there was no coupling between packages.

I cannot believe they all passed for all 4 active distros... unheard of.
Let's see how flaky these end up being in the longer term :)


Add test to ensure sampling is bounded in SQL

Also converts some odo(compute(...)) calls to compute(..., return_type=...).

+1


Sonoff TRVZB don't work anymore with firmware 1.2.X

          I had a working setup with the the Sonoff TRVZB with firmware 1.1.X and using a switch as thermostat.

I have upgraded the firmware to 1.2.1 and I'm tying to setup the thermostat using climate + the SONOFF TRVZB mode but nothing really happens anymore in my system.
For example, I don't understand why in this situation the heating is not on

This is my first attempt to setup Versatile Thermostate, so might be missing something trivial
UPDATE:
Using a valve thermostate and using the valve opening degrees as underlying managed to turn on the boiler + the valves on my thermostates.

Originally posted by @gbasile in https://github.com/jmcollin78/versatile_thermostat/issues/645#issuecomment-2491348958

@gbasile dit you enable manually Valve closing degree and Valve opening degree on your trv entity in HomeAssistant. You have to do it first in order to have Sonoff TRV native support on Vth.

ok @eflye , this is an important information, by default thoses entities are not visible I understand

Thanks for creating a dedicated issue for my problem 🙌

@gbasile dit you enable manually Valve closing degree and Valve opening degree on your trv entity in HomeAssistant. You have to do it first in order to have Sonoff TRV native support on Vth.

I have missed this piece of information. Can you point me to the right direction?

Thank you the beers ! Cheers 🍻
You have to go to Parameters / Devices. Find you Sonoff device and click on "more attributes" (or something like that) . Then you will able enable the missing attributes.
Example:

I think I have misunderstood the previous message (I was looking for an attribute calledmanually valve closing degree)
In my device the following are available, without any manual change from my side:

Valve opening degree
Valve closing degree

These attributes are the ones that currently are driving the TRV when configured in valve mode. For some reason when I configure the thermostate as climate mode with the sonoff configuration enabled, the. system is not working anymore

ok. Then can you give me the attribute of the VTherm ? (see: https://github.com/jmcollin78/versatile_thermostat/blob/main/README.md#custom-attributes)

maybe Diagnostic one should be enabled? In order to get curent value
It creates sensor._valve_opening_degree and sensor._valve_closing_degree
wheras the one you see on the Configuration are
number._valve_opening_degree and number._valve_closing_degree
Which want do you use @jmcollin78

@eflye I have enabled them now

Oooh there is a problem:
underlying_entities:
  - climate.mqtt_trv_1_living_room

...
underlying_sonoff_trvzb_entities:
  - number.mqtt_trv_2_office_valve_opening_degree
  - number.mqtt_trv_2_office_valve_opening_degree
  - number.mqtt_trv_2_office_valve_opening_degree
  - number.mqtt_trv_2_office_valve_opening_degree
  - number.mqtt_trv_1_living_room_valve_opening_degree
  - number.mqtt_trv_1_living_room_valve_opening_degree
  - number.mqtt_trv_1_living_room_valve_opening_degree

This should be not possible. there is trv2 and too many underlying_sonoff_trvzb_entities.
This is clearly a bug. I think you will have to recreate it from scratch.

I'm happy to give it and recreate the entire configuration from scratch.
Just to be on the same page, I will:

Remove all the devices from the Versatile Thermostat integration
Recreate a central configuration and the single thermostats

I will not:

Unpair/Pair again the MQTT devices
Factory reset the physical devices

Is that correct?

No need to recreate the central configuration. Only the VTherm which uses the Sonoff TRVZB (in beta). And only the one who is incorrect. No need to removes the others if you have and if they works fine
The others points are correct.

Well, in that case I don't think much will change:  this Thermostat has been recreated now as part of the effort of understanding the problem with the climate mode.
Basically my journey today has been:

configure the thermostat with climate + sonoff config (not working)
delete this thermostat and recreate it with valve (working)
[as part of the investigation for this issue, 30 minutes ago] delete the thermostat and recreate it with climate + sonoff in order to share the attributes

Nice but there is a bug in the list.

Exposing xxx_opening_degree and xxx_closing_degree from the diagnostic makes the thermostat valves to move in the system.
I wonder whatever we should:

Investigate if possible to avoid the manual step of exposing these attributes
Update the documentation and/or the UI of the sonoff config to warn the user about this requirement

There are still some behaviours that I don't fully understand. Are these as expected or not?

I turn the thermostat to 24 degree (1.6 higher then room temperature)
Valves opens to 100% ✅
Thermostat is not requesting for heating ❌
Boiler is off ❌

Screenshot for more context

Update the documentation and/or the UI of the sonoff config to warn the user about this requirement

Yes !

3. Thermostat is not requesting for heating ❌

Yes, there is still a bug on this reported in the main thread. It is requested for heat if the valve is open, but the display seems wrong.

4. Boiler is off ❌

Yes this is a consequence of the point /3. The boiler is started if VTherm are requested for heat.

Maybe we can keep this thread only for documentation and valve list and come back the main thread because you have solve your main issue. Your points can interest the others.

Regarding the valve list:

Yesterday night I have clean-up the configuration to remove the duplicates (set state)
Today the list is corrupted again

I am able to reproduce in this way:

Clean the duplications and set new state
Reload the VTherm thermostat from the integration page
Duplication re-appear again

Hi,
I have Sonoff TRVZB in 1.2.1 release too and I note that now, I'm quite sure it worked fine before, If I manually change the wished temperature on the valve itself, this change is not reflected on the associated versatile Thermostat. Same on the Versatile Thermostats of my daughter's house (different HA instance).
If I change the wished temperature on the V-th, it's well change on the valve.

If I manually change the wished temperature on the valve itself, this change is not reflected on the associated versatile Thermostat.

I have the same issue as well

Hello @gbasile , @msd3287 ,
Did you check the "Follow underlying temperature change" entity (in the VTherm device) ?

I guess this is the setting you are talking about, right? In that case, yes

No. I'm talking about this one:

ah, I was not aware of that control in the service 😓
Of course IT DOES WORK when that option is set.

It is a recent addition: https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.7.0
That is because you don't read the release notes 😉 (and it is badly documented that is true)

T'as un peu squatté le thread là. Celui-là c'était pour la liste qui ne s'affichait mal. Je vais le fermer dans qqes heures et ta question va disparaitre. Attend, je vais faire une mise à jour importante qui corrige pas mal de choses. Avec un peu de chance ça va marcher maintenant.

Ok, merci  :)

https://github.com/jmcollin78/versatile_thermostat/releases/tag/6.8.0


"Mentioned" issues are not sorted by date

Referencing #2612
Describe the bug
Take a look at only mentioned issues, and observe they are not sorted by date
To Reproduce
Steps to reproduce the behavior:

Go to "Inbox"
Click on Inbox
Click on Mentioned
See error

Expected behavior
A list of issues that is sorted by date, latest on top
Screenshots

Request:
curl -v -X GET 'https://api.github.com/issues?access_token=123filter=mentioned&page=1&per_page=50' -H 'User-Agent: Freetime/1.27.1 (com.whoisryannystrom.freetime; build:1546622353; iOS 12.1.4) Alamofire/4.4.0' -H 'Accept-Language: en-DE;q=1.0, de-DE;q=0.9, nl-DE;q=0.8' -H 'Authorization: token 7e713728cee1b78872817efad46a940ce65af232' -H 'Accept: application/vnd.github.merge-info-preview+json' -H 'Accept-Encoding: gzip;q=1.0, compress;q=0.5' -H 'Cookie: logged_in=no;'

I'll take a look at this, if nobody is against.

@BasThomas I think this is slightly different then the ticket I opened that you referenced. My older ticket focused on the aggregation of all the issues within a specific filter type, aka created or mentioned.
Your ticket revolves around time stamps. Assuming we are identifying the same thing, what I noticed is that GitHub issue tickets will not fall in chronological order specifically when you yourself are the only one post a new comment. Unless someone else comments after, the timestamp will update to newer but since there is no new activity for you to review, it doesn’t bump it to the top. I actually wish it sorted chronologically regardless but it’s not an app error but just how GitHub handles things. I have even emailed them directly about this requesting that they added an option to sort chronologically for all tickets, even if you are the only updater.
If we are on the same page here and you agree, I would love you to send GitHub another ticket on this to add visibility to what I wrote and hopefully influence them more to accommodate. If it’s something different, apologies and carry on.

Interesting, @ijm8710. It feels like it would be behaving as expected then, as of now? It’s a bit confusing though. I’m not sure what the UX would look like, but GitHawk could add it as an option to sort by “last updated”? What do you think?
Sent with GitHawk

Sounds like Ryan was against it
If you and I are on same page of having it sort chronologically regardless of if last update was by “you” or “not you”, the best way to drive it would be to nudge GitHub like I did. Like I said, I would love another voice to echo the request I already made with them!

Ps any idea if Ryan just wanted a little break or if he was trying to back away from this in general. Either way I’m super appreciate of the app and the hard work that went into it, was just curious if you expect it to pop back in whenever he so chooses (which is obv completely his call) or if it would make sense to have more people at his admin level to perhaps keep driving innovation align to what he would want

All I know is that he's not active at the moment.

@BasThomas hello,
Please see #2663 how you will have the opportunity.


fix renamed dependency

In theia-ide/theia, a typo was fixed in a source file on which we depend.
The currently published "next" version of Theia has been published with
the correct name, so we need to use the new name.
fixes #56

@JanKoehnlein  I am not sure if this fix could cause issue with the "latest" version of yangster? If so any suggestions about how to proceed?

@marcdumais We merge now and we have to release with theia's next release

Thanks @JanKoehnlein .
For my information, is there something preventing us from releasing this before the next Theia release? e.g. if we want the "next" version of yangster-docker and theia-full-docker images to build in the meantime? I imagine that many are interested in the "next" version of Theia and extensions since they are bleeding-edge and can be used to try/demo new features.
I know that so far the burden of keeping up-to-date / publishing such extensions, which are hosted outside the main theia repo, has been on you. What if someone at Ericsson helped, at least for cases like this, where simple API breakage occurs?

I don't quite get what you are after. Why not use the yangster-next image from theia-apps for demos? It uses theia-next and yangster-next.
So far my working hypothesis was that a yangster latest (release) should not link against Theia next (unreleased), because the next releases could be deprecated / removed automatically.

I don't quite get what you are after. Why not use the yangster-next image from theia-apps for demos? It uses theia-next and yangster-next.

That's what I want to do, but the "next" version of images in theia-apps that use yangster do not build ATM, because of the issue fixed in this PR. see https://github.com/theia-ide/theia-apps/issues/30
I think we would need to publish a new "next" version of yangster, that includes this fix here, for the images that include yangster to build again.

OK, I start to understand.
The 'next' version of the npm packages for yangster are built and published automatically on each commit to master on our Jenkins. We use Jenkins and not Travis because we rely on the build pipeline: yangster, yang-eclipse and yang-vscode have to be rebuilt when yang-lsp changes.
The build after the merge of this PR failed because it was still using the outdated yarn.lock. I had to remove it and re-run yarn and check it in again to upgrade. You could do that as well in the future.
In addition, I had to fixed a few new emerging bugs because of incompatible changes in downstream packages and build oddities.

Ah, I understand too now, thanks for the explanation @JanKoehnlein . Not seeing that this repo has CI at first look, I had thought that the build and publish were probably done manually.
Just a thought - do you know if it would be possible to also trigger a Jenkins build upon a PR being created? Or maybe it would be easier to have a branch for that purpose? i.e. have Jenkins watch the "build" branch and trigger a build when something is pushed on it (without releasing anything). This way we could at least see the if a PR seems like it will work, or if more adjustments are also needed to get the whole pipeline to compile and release?

Jenkins is already configured to build branches for yangster, so PRs should be built. I added a condition that only builds from  master are published. Just added a test branch to verify.
Maybe we need to do a bit more to get the build result as feedback on the PR. Will investigate tomorrow.


Unable to convert from leder-parser Ledger with multiple currency

With version 0.3.0 and above. I am not able to convert from ledger_parser to simplified ledger when it contains multiple currency. Is there any other way as other modules such as monthlyreports only works simplified ledger
This is the error and ledger file that I use to reproduce the error
let ledger = ledger_parser::parse(&file_string);
let mut simple_ledger = SimpleLedger::try_from(ledger);

2020-02-01 Buy ADA
    assets:cc:ada          2000 ADA @ $0.02
    assets:bank:checking                   $-40

with this error
Error: UnbalancedTransaction(Transaction { comment: None, date: 2020-02-01, effective_date: None, status: None, code: None, description: "Buy ADA", postings: [Posting { account: "assets:cc:ada", reality: Real, amount: Some(PostingAmount { amount: Amount { quantity: 2000, commodity: Commodity { name: "ADA", position: Right } }, lot_price: None, price: Some(Unit(Amount { quantity: 0.02, commodity: Commodity { name: "$", position: Left } })) }), balance: None, status: None, comment: None }, Posting { account: "assets:bank:checking", reality: Real, amount: Some(PostingAmount { amount: Amount { quantity: -40, commodity: Commodity { name: "$", position: Left } }, lot_price: None, price: None }), balance: None, status: None, comment: None }] })

Thank :)

Yes, thank you for reporting. I definitely want to fix it soon as it also affects my use cases.
The bug is here since introduction of SimpleLedger (which is useful to calculate missing amounts, which were not supported on reports before, but it fails with multiple currencies).

The issue is fixed now in version 0.4.1 but missing amounts during commodity exchanges are not supported yet.
New issue:
https://github.com/marek-g/rust-ledger-utils/issues/5


close #113

Please fix alignment of icons with text

please review the changes

Mooi chris! :+1:


Azure - Setup a Single Node OpenShift (SNO) Cluster

Description
SNO Cluster will be using lesser resources with respect to Virtual Machines, Disks etc., thus resulting in reduction of cost.
Potential Solutions
Make changes in the following files to create a SNO Cluster.

ARM Template
Bootstrap Script
OpenShift Install Config YAML

Additional Context

References

Closing the issue as the changes are merged into main branch with the PR #102.


Can add error message in API endpoint

When try to get user's order (for user with level < 3) we receive response with status 401 and {error: ""}
Can add message text?

Closed by #1343 #1347 #1348 #1349.


Pilot asks for 2-factor code in CI mode (TravisCI) and ignores FASTLANE_SESSION and FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
Currently I am experiencing a problem with pilot and deliver running on TravisCI. I have a cordova project which creates build artifacts for Android and iOS. Fastlane uploads these artifacts via supply, pilot and deliver. The build process runs on TravisCI.
The problem I am experiencing is with pilot and deliver when fastlane is asking for a 2 factor authentication code. Off course I cannot provide this in my CI step. So I followed the spaceship guide, created a FASTLANE_SESSION and FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD and provided these environment variables in my .travis.yml file.
When I run bundle exec fastlane ios beta locally the deployment runs without problems and does not ask for passwords or 2 factor auth codes. When TravisCI triggers a build Travis is prompted for a 6 digit code:
Login to iTunes Connect<EMAIL_ADDRESS>Two Factor Authentication for account<EMAIL_ADDRESS>is enabled
If you're running this in a non-interactive session (e.g. server or CI)
check out https://github.com/fastlane/fastlane/tree/master/spaceship#2-step-verification
Please enter the 6 digit code:

Travis will timeout after this.
The iTunes Connect account I am using is part of multiple organisations.
Removing FASTLANE_PASSWORD results in:
Missing password for user<EMAIL_ADDRESS>and running in non-interactive shell

First I thought this might be related to #8218 but I think these problems are not related because my match step is completed successful.
I hope I provided enough information 😄
Complete output when running fastlane, including the stack trace and command used

You can use: --capture_output as the last commandline argument to get that collected for you

bundle exec fastlane ios beta
[12:56:09]: -------------------------------------------------
[12:56:09]: --- Step: Verifying required fastlane version ---
[12:56:09]: -------------------------------------------------
[12:56:09]: Your fastlane version 2.17.1 matches the minimum requirement of 2.9.0  ✅
[12:56:09]: ------------------------------
[12:56:09]: --- Step: default_platform ---
[12:56:09]: ------------------------------
[12:56:09]: Driving the lane 'ios beta' 🚀
[12:56:09]: -------------------
[12:56:09]: --- Step: pilot ---
[12:56:09]: -------------------
[12:56:10]: Login to iTunes Connect<EMAIL_ADDRESS>Two Factor Authentication for account<EMAIL_ADDRESS>is enabled
If you're running this in a non-interactive session (e.g. server or CI)
check out https://github.com/fastlane/fastlane/tree/master/spaceship#2-step-verification
Please enter the 6 digit code:

Environment
Please run fastlane env and copy the output below. This will help us help you :+1:
If you used --capture_output option please remove this block - as it is already included there.
✅ fastlane environment ✅
Stack

Key
Value

OS
10.11.6

Ruby
2.3.3

Bundler?
true

Git
git version 2.10.1 (Apple Git-78)

Installation Source
~/.rvm/gems/ruby-2.3.3/bin/fastlane

Host
Mac OS X 10.11.6 (15G1212)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.3.3/lib

OpenSSL Version
OpenSSL 1.0.2k  26 Jan 2017

Is contained
false

Is homebrew
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
8.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# Customise this file, documentation can be found here:
# https://github.com/fastlane/fastlane/tree/master/fastlane/docs
# All available actions: https://docs.fastlane.tools/actions
# can also be listed using the `fastlane actions` command

# Change the syntax highlighting to Ruby
# All lines starting with a # are ignored when running `fastlane`

# If you want to automatically update fastlane if a new version is available:
# update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "2.9.0"

default_platform :ios

desc "Retrieve certificates"
lane :certificates do
    if is_ci
        create_keychain(
            name: ENV["MATCH_KEYCHAIN_NAME"],
            password: ENV["MATCH_PASSWORD"],
            default_keychain: true,
            unlock: true,
            timeout: 3600,
            add_to_search_list: true
        )

        match(
            type: "development",
            keychain_name: ENV["MATCH_KEYCHAIN_NAME"],
            keychain_password: ENV["MATCH_PASSWORD"],
            readonly: true
        )

        match(
            type: "appstore",
            keychain_name: ENV["MATCH_KEYCHAIN_NAME"],
            keychain_password: ENV["MATCH_PASSWORD"],
            readonly: true
        )
    else
        match(type: "development", readonly: true)
        match(type: "appstore", readonly: true)
    end
end

platform :ios do
    before_all do
        ENV["SLACK_URL"] = "******"
    end

    desc "Submit a new Beta Build to Apple TestFlight"
    desc "This will also make sure the profile is up to date"
    lane :beta do
        pilot(
            ipa: "platforms/ios/build/device/app.ipa",
            skip_waiting_for_build_processing: true
        )
    end

    desc "Deploy a new version to the App Store"
    lane :release do
        deliver(
            ipa: "platforms/ios/build/device/app.ipa",
            force: true
        )
    end

    after_all do |lane|
        unless is_ci
            # This block is called, only if the executed lane was successful
            slack()
        end
    end

    error do |lane, exception|
        if is_ci
            slack(message: exception.message, success: false)
        end
    end
end

platform :android do
    before_all do
        ENV["SLACK_URL"] = "*****"
    end

    desc "Submit a new Beta Build to Google Play Store"
    desc "This will also make sure the profile is up to date"
    lane :beta do
        supply(
            apk: "platforms/android/build/outputs/apk/android-release.apk",
            package_name: "*****",
            json_key: "key.json",
            track: "beta"
        )
        slack(message: "Successfully distributed a new beta build")
    end

    desc "Deploy a new version to the Google Play Store"
    lane :release do
        supply(
            apk: "platforms/android/build/outputs/apk/android-release.apk",
            package_name: "****",
            json_key: "key.json",
            track: "production"
        )
    end

    after_all do |lane|
        unless is_ci
            # This block is called, only if the executed lane was successful
            slack()
        end
    end

    error do |lane, exception|
        if is_ci
            slack(message: exception.message, success: false)
        end
    end
end

# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Platforms.md
# All available actions: https://docs.fastlane.tools/actions

# fastlane reports which actions are used
# No personal data is recorded. Learn more at https://github.com/fastlane/enhancer

`./fastlane/Appfile`
app_identifier "********" # The bundle identifier of your app
apple_id<EMAIL_ADDRESS># Your Apple email address

team_id "*********"  # Developer Portal Team ID
itc_team_id "*********"
itc_team_name "***"

# FASTLANE_ITC_TEAM_ID` or `FASTLANE_ITC_TEAM_NAME

# you can even provide different app identifiers, Apple IDs and team names per lane:
# More information: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Appfile.md

fastlane gems

Gem
Version
Update-Status

fastlane
2.17.1
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.0.0

executable-hooks
1.3.2

bundler-unload
1.0.2

rubygems-bundler
1.4.4

bundler
1.14.4

io-console
0.4.5

CFPropertyList
2.3.5

i18n
0.8.0

json
1.8.6

minitest
5.10.1

thread_safe
0.3.5

tzinfo
1.2.2

activesupport
<IP_ADDRESS>

public_suffix
2.0.5

addressable
2.5.0

babosa
1.0.2

claide
1.0.1

fuzzy_match
2.0.4

nap
1.1.0

cocoapods-core
1.2.0

cocoapods-deintegrate
1.0.1

cocoapods-downloader
1.1.3

cocoapods-plugins
1.0.0

cocoapods-search
1.0.0

cocoapods-stats
1.0.0

netrc
0.7.8

cocoapods-trunk
1.1.2

cocoapods-try
1.1.0

colored
1.2

escape
0.0.4

fourflusher
2.0.1

gh_inspector
1.0.3

molinillo
0.5.6

ruby-macho
0.2.6

nanaimo
0.2.3

xcodeproj
1.4.2

cocoapods
1.2.0

coderay
1.1.1

highline
1.7.8

commander
4.4.3

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20161129

dotenv
2.2.0

excon
0.55.0

multipart-post
2.0.0

faraday
0.11.0

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday_middleware
<IP_ADDRESS>

fastimage
2.0.1

jwt
1.5.6

little-plugger
1.1.4

multi_json
1.12.1

logging
2.1.0

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
2.8.3

hurley
0.2

mime-types-data
3.2016.0521

mime-types
3.1

uber
0.0.15

representable
2.3.0

retriable
2.1.0

google-api-client
0.9.28

mini_magick
4.5.1

multi_xml
0.6.0

plist
3.2.0

rubyzip
1.2.1

security
0.1.3

slack-notifier
1.5.1

terminal-notifier
1.7.1

unicode-display_width
1.1.3

terminal-table
1.7.3

tty-screen
0.5.0

word_wrap
1.0.0

rouge
1.11.1

xcpretty
0.2.4

xcpretty-travis-formatter
0.0.4

method_source
0.8.2

slop
3.6.0

generated on: 2017-02-19

TravisCI ENV
Setting environment variables from repository settings
$ export FASTLANE_SESSION='---\n-**** \n'
$ export SPACESHIP_SESSION='---\n-**** \n'

Setting environment variables from .travis.yml
$ export DEV_PORTAL_TEAM_ID=[secure]
$ export MATCH_PASSWORD=[secure]
$ export KEYSTORE_PASSWORD=[secure]
$ export ANDROID_HOME=/usr/local/opt/android-sdk
$ export JAVA_HOME=$(/usr/libexec/java_home)
$ export MATCH_KEYCHAIN_NAME=ios-build
$ export FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD=[secure]
$ export FASTLANE_PASSWORD=[secure]

Ok I still haven't figured this one out. What I will try now is to setup a simple 'bot' account with 2-fac disabled and use that account to deploy to TestFlight or the Appstore.

I'm with the same issue! 👎

Ok I got the build working by creating a new iTunes connect user with permissions to upload and deploy apps.
Had some time to check the source code for fastlane but could not find anything related.
I think there might be an security measure in place from Apple, even though there is a session available it still asks for a auth code because of the sudden change in location. I am located in The Netherlands and Travis Mac build servers are located in Atlanta US.
I could try to start a debug build, authorise via spaceauth (fastlane spaceauth -u<EMAIL_ADDRESS>and use the generated session as the FASTLANE_SESSION env var.
At least I got it working now with 2 factor disabled but haven't figured out if this is a problem with Fastlane, Travis or Apple.

@Badmuts it worked just with no TFA, right?

@RafaelPlantard Yes, by creating a new account where 2FA is not enabled I was able to upload builds to TestFlight via pilot. Via this method you do not need FASTLANE_SESSION only FASTLANE_PASSWORD and off course the rest of your login information via the Appfile or something else.
However the FASTLANE_SESSION workaround for 2FA is still not working for me so I am keeping this issue open.

I will use your solution for while. Thanks man @Badmuts 👍

No problem @RafaelPlantard ! Hope you get things running.
For some more clarity both the methods outlined on docs.fastlane.tools and in the spaceship readme did not work for me.

@Badmuts for me too. Nothing works into fastlane docs (👎).

Hey everyone, it seems like there is an issue with escaping the environment variable in Travis. We haven't had the chance to reproduce this yet to work on a fix. For now the only solution is to create a new account with limited access to use on your CI.

Thanks for the update @KrauseFx

@Badmuts Thinking about your theory around location... have you tried running the pilot distribution from your local machine instead of CI?
If you want to experiment with that, I would suggest ensuring that your local environment is "clean" (like you might expect on CI) by taking the steps I describe in: https://github.com/fastlane/fastlane/issues/8218#issuecomment-280862932

Hi all, I am trying to reproduce this, but so far I have not had any luck. By using a combination of FASTLANE_PASSWORD, FASTLANE_APPLE_APPLICATION_SPECIFIC_PASSWORD, and FASTLANE_SESSION I am able to do a pilot distribution from my local machine without being prompted for any credentials.
My next step will be to try to do the same from Travis CI, and see if it is any different.

Hi @Badmuts
It has taken a long time to get to this place (partially because of the Amazon internet disruption this week... 😅 ), but I believe I have interesting evidence from Travis CI:
$ export FASTLANE_SESSION=[secure]
The previous command failed, possibly due to a malformed secure environment variable.
Please be sure to escape special characters such as ' ' and '$'.
For more information, see https://docs.travis-ci.com/user/encryption-keys.

This comes from having set the session value through the web UI for defining environment variables. You had said you set yours through the .travis.yml file, correct? Do you see any output similar to the above in your runs?

@mfurtak When I put into Travis CI I always put FASTLANE_SESSION between ' before save it. Understand?

Sorry for my late reaction, been very busy lately 😄
I have encountered that issue before. I then used the travis cli with the encrypt command and made sure the special characters where escaped.
I also used an .env file to check if that would work.
I have started a debug session and printed the FASTLANE_SESSION variable. The strange thing was that I got the exact session I had locally but it was not formatted (\n was ignored) as it was locally. My local env uses zsh.
I was always able to run fastlane from my local machine, this might has something to do with the keychain?
I have not yet found the time to reproduce the Travis env locally which should make debugging a bit easier.
TLDR; I have encountered the malformed FASTLANE_SESSION error but fixed it by escaping the string as described here: https://docs.travis-ci.com/user/encryption-keys#Note-on-escaping-certain-symbols

I might think this is a problem with the travis-cli that encrypts the env var so I added an env variable without encrypting it and avoided the malformed error when I encountered these problems but still did not manage to run Fastlane without prompting for 2fa codes


Fix various typos in Markdown files

I started a pass through the repo's markdown files with aspell, but stopped at hw/lint/doc/index.md.
I used the command below, but note that it has a few deficiencies. For one, aspell does not show the name of the file you're viewing. As a result, I sometimes found myself in vendored code or changelogs, which should not be edited. Secondly, it's difficult to quit halfway through as it requires exiting from aspell N times.
find . -name '*.md' -exec aspell check {} \;

Signed-off-by: Dan McArdle<EMAIL_ADDRESS>

Just fixed trailing whitespace that CI was complaining about: https://dev.azure.com/lowrisc/opentitan/_build/results?buildId=93305&view=logs&j=3a559e2a-952e-58d2-b8db-2e604a9266d7&t=5d859c63-56da-5106-2237-dc76198705d5&l=16


Windows 11: telescope-fzf-native.nvim build failed

Describe the bug
On Windows 11 after cloning this repo to ~\AppData\Local\nvim and starting from a Developer Powershell VS2022 (to have access to CL.exe, etc.), I get the following error message during initial installation:
Failed (1)
○ telescope-fzf-native.nvim
Der Befehl "make" ist entweder falsch geschrieben oder
konnte nicht gefunden werden.
Telescope then wont work. make.exe is not available in Windows Developer Powershell 2022. What are my options here?
To Reproduce
Steps to reproduce the behavior:

Install nvim
Open terminal with "Developer Powershell for VS2022" (VS 2022 must be installed)
Navigate to ~\AppData\Local
Optionally, clean any previous installation: rm -r -fo nvim ; rm -r -fo nvim-data
git clone https://github.com/nvim-lua/kickstart.nvim.git nvim
Start nvim

Desktop (please complete the following information):

OS: Windows 11 22H2 (Build 22621.1413)
Terminal: Windows Terminal using Developer Powershell for VS2022

** Neovim Version **
:version
NVIM v0.9.0-dev-1175+g89a525de9
Build type: RelWithDebInfo
LuaJIT 2.1.0-beta3
Compilation: C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe /MD /Zi /O2 /Ob1  -W3 -wd4311 -wd4146 -DUNIT_TESTING -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -D_WIN32_WINNT=0x0602 -DMSWIN -DINCLUDE_GENERATED_DECLARATIONS -ID:/a/neovim/neovim/.deps/usr/include/luajit-2.1 -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/build/src/nvim/auto -ID:/a/neovim/neovim/build/include -ID:/a/neovim/neovim/build/cmake.config -ID:/a/neovim/neovim/src -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include -ID:/a/neovim/neovim/.deps/usr/include
      System-vimrc-Datei: "$VIM\sysinit.vim"
 Voreinstellung für $VIM: "C:/Program Files (x86)/nvim/share/nvim"

Run :checkhealth for more info

Sorry, my bad. I just saw the note on the bottom of README.MD regarding telescope-fzf-native.nvim on windows. Closing this.


ARROW-15170 [R] ignore attributes when testing Array$create error messages

This addresses the failing tests (on CentOS and Windows) introduced by the decimal256() implementation (PR #11898).
The failure was due to a mismatch in names between actual and expected. On some systems one is an empty character vector, while the other one is NULL.

Closing this PR and the issue has been solved in #12005.


commcare-cloud: set good default for --forks

I think a good default would be the number of hosts involved. This may take some finagling/calling out to the ansible library to compute. (Alternatively, might also be worth just seeing what happens when we set to a high number.)
  -f FORKS, --forks=FORKS
                        specify number of parallel processes to use
                        (default=5)

From https://www.ansible.com/blog/ansible-performance-tuning:

Regardless of what you set forks to, Ansible is smart - for example, if you have 50 systems and set forks to 500, Ansible will only spin up 50 forks because it knows it doesn't need all 500.

Looks like we can just set this to a high number. Caveat from the same article:

When using a large number of forks, be advised that any “local_action” steps can fork a python interpreter on your local machine, so you may wish to keep “local_action” or “delegated” steps limited in number or in separate plays.

I honestly don't understand what the caveat is trying to warn us against, but I think this will not be an issue. Only highlighting it here in case we see a problem related to this. (local_action is used in a couple of places.)


Add GEFS forcing reader

Added new GEFS forcing reader
Updated documentation included
Testcase also included within:
lis/testcases/metforcing/gefs

Testcase input/output files are located here:
LDT:  /discover/nobackup/projects/lis/Projects/LDT/LISF_Testcases/GEFS_Forcing/LDT_Test/testcase_ldt_input.tar.gz
LIS-Input:  /discover/nobackup/projects/lis/Projects/LDT/LISF_Testcases/GEFS_Forcing/LIS_Test/testcase_lis_input.tar.gz
LIS-Output:  /discover/nobackup/projects/lis/Projects/LDT/LISF_Testcases/GEFS_Forcing/LIS_Testtestcase_lis_output.tar.gz
Addresses ticket issue #195

Hi Kristi:
I tested the code with both Intel and GNU compilers, and found no run-time issues.
One suggested change:  in lis/configs/lis.config.adoc, remove the "devonly" markings for the new GEFS material.  I say this because the GEFS metforcing is supported by the build system by default.

Thanks for testing this commit and for the documentation suggestion.
I removed the "devonly" markings.

Hi Kristi:
I want to confer with Jim about your test case before merging this code in.  Otherwise we are ready to approve.

Sure thing, and thanks for confirming that.

I talked to Jim, and he gave me the go-ahead to merge in.  I will keep the AddToTestSuite label on this pull request, and Jim will track it down later and add to his test suite.


Add Toggl, Iridium to extras bucket

Verified working using custom git repo, feel these apps will be more at home in extras bucket though.

Open 1 PR per manifest/application

ah apologies, incoming shortly


fix: re-enable preview for interactive objkts

Regression from https://github.com/teia-community/teia-ui/pull/346
Don't know if this is the right way of doing it though :sweat_smile:

Also fix for https://github.com/teia-community/teia-ui/issues/288

Maybe at some point URL.revokeObjectURL still needs to be called to free the used memory from URL.createObjectURL ?

Maybe at some point URL.revokeObjectURL still needs to be called to free the used memory from URL.createObjectURL ?

Yes I think too, otherwise it looks good, I would need to actually properly test it since all this is quite finicky

I think this could be merged too? I mean, it's already broken now, so it would be challenging to break it even harder :laughing:

True, and if it's breaking too much we can always revert it

True, and if it's breaking too much we can always revert it

what could possibly go wrong, right? :rofl:


encode_image must accept a stream object

This will be useful for writing web-services where iamge comes as a stream object, not a file on a disk.

Image.open already accepts a stream, so the issue is only in checking a parameter type in the encode_image


Add xcprivacy for UserDefaults usage

As per new Apple privacy reports, all apps and SDKs that are using any of those APIs need to declare type and reason in their privacy file.
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api
This package is using UserDefaults

It also uses File timestamp APIs (.creationDate and .modificationDate)
Please chack other API's at https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api

Just opened this PR with the two required files, not 100% sure if anything else is required.
https://github.com/kean/Pulse/pull/252

Shipped in 4.10 thanks to @samlapse.


Update 3A.scm

minor change to scale-list procedure '+' to '*' on line 77

Thank you for the contribution!


Is it possible to use hyper-express with Bun?

hyper-express is one of my favorite Node.js package.
I've been using it in some of my Node.js projects for a while.
However, some projects can benefit a lot from switching from Node.js to Bun.
I would love to keep using this framework on Bun but I am faced with this error.
error: This version of uWS.js supports only Node.js LTS versions 16, 18 and 20 on (glibc) Linux, macOS and Windows, on Tier 1 platforms (https://github.com/nodejs/node/blob/master/BUILDING.md#platform-list).

TypeError: symbol 'napi_register_module_v1' not found in native module. Is this a Node API (napi) module?
      at C:\...\node_modules\hyper-express\node_modules\uWebSockets.js\uws.js:22:9
      at C:\...\node_modules\hyper-express\node_modules\uWebSockets.js\uws.js:22:240
      at C:\...\node_modules\hyper-express\index.js:4:7

Bun v1.1.15 (Windows x64)

I know this error is from uWebSockets.js module not hyper-express itself.
but is it possible to have hyper-express working with Bun?
I would love Node.js and Bun to be able to run the same server script.

Hello, since hyper-express is built on top of uWebsockets.js there will be no way to make it work on Bun without Bun also supporting uWebsockets.js.
As the error states, this is a napi error which Node's API for communication / working with C++ modules like uWebsockets.


DTR Upgrade Docs No Mention of Backup

@mark-church commented on Mon Mar 20 2017
What's the problem/feature request?
There is no mention of backups in the DTR upgrade docs. Field best practices always recommends doing a backup before an upgrade because many customers do not take backups or do so irregularly. A bad upgrade without a backup could result in customer data loss. Can we include doing a manual DTR backup (and link to the backup section) as the 1st step of any DTR upgrade?
DTR 2.1 Upgrade Doc
DTR 2.2. Upgrade Doc
Who is asking for this?
Technical Field
What is the (customer) Impact of this request or severity of the issue?
Potential to limit customer issues
What versions/components are affected?
All currently supported DTR versions: DTR 2.0 - 2.2

I claim this new found issue


[Bug]: Regex checks for MVC paths in some HttpModules are not case insensitive and fail to match.

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The Regex used to do the checks in MvcHttpModule.cs and MobileRedirectModule.cs is new Regex(@"DesktopModules/MVC/", RegexOptions.Compiled);, which only matches paths with that exact case, while urls can have arbitrary casing and also the check in MvcHttpModule.cs is done on the .ToLowerInvariant() of the path.
Looks like it was changed/broken a long time ago by this commit.
I am not sure what was the original intent with the checks, if changes since then have made them unnecessary, or whether fixing them now could break existing behaviors. I just found them while looking through the code and thought that would be good to share.
Steps to reproduce?
Not really any steps to reproduce, but accessing an MVC view through the browser (domain.com/en-us/dEsKtopMoDules/mvC/) should trigger a match for the checks, which does not happen.
Current Behavior
No response
Expected Behavior
No response
Relevant log output
No response
Anything else?
No response
Affected Versions
9.13.3 (latest release), 9.13.4 (alpha), 10.0.0 (alpha)
What browsers are you seeing the problem on?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

👍🏻 looks to me like something worth fixing


fix typo

Thanks for the contribution! However, this is a read-only mirror. please read the contribution guide. Also, feel free to join us on chat!


Sequence has multiple same period ,call the intersections func ,result is error

Bug Report
(Fill in the relevant information below to help triage your issue.)

Information
Description

Version
5.3

PHP version
8.1.22

OS Platform
Windows

Summary
(Please explain in plain english your bug)
Sequence has multiple same period ,call the intersections is error
Standalone code, or other way to reproduce the problem
<?php
$p1 =  Period::fromDate('2023-01-01 00:00:00','2023-01-03 00:00:00');
$p2 =  Period::fromDate('2023-01-01 00:00:00','2023-01-03 00:00:00');
$p3 =  Period::fromDate('2023-01-01 00:00:00','2023-01-03 00:00:00');
$p4 =  Period::fromDate('2023-01-02 00:00:00','2023-01-04 00:00:00');
$p5 =  Period::fromDate('2023-01-02 00:00:00','2023-01-04 00:00:00');

$seq = new Sequence($p1,$p2,$p3,$p4,$p5);
$xx = $seq->intersections()->jsonSerialize();
print_r($xx);

current output
Array
(
    [0] => League\Period\Period Object
        (
            [startDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-01 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [endDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-03 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [bounds] => League\Period\Bounds Enum
                (
                    [name] => IncludeStartExcludeEnd
                )

        )

    [1] => League\Period\Period Object
        (
            [startDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-01 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [endDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-03 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [bounds] => League\Period\Bounds Enum
                (
                    [name] => IncludeStartExcludeEnd
                )

        )

    [2] => League\Period\Period Object
        (
            [startDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-02 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [endDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-03 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [bounds] => League\Period\Bounds Enum
                (
                    [name] => IncludeStartExcludeEnd
                )

        )

    [3] => League\Period\Period Object
        (
            [startDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-02 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [endDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-04 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [bounds] => League\Period\Bounds Enum
                (
                    [name] => IncludeStartExcludeEnd
                )

        )

)

after fix output is right ????:
Array
(
    [0] => League\Period\Period Object
        (
            [startDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-01 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [endDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-03 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [bounds] => League\Period\Bounds Enum
                (
                    [name] => IncludeStartExcludeEnd
                )

        )

    [1] => League\Period\Period Object
        (
            [startDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-02 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [endDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-04 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [bounds] => League\Period\Bounds Enum
                (
                    [name] => IncludeStartExcludeEnd
                )

        )

)

or   this is right ??

Array
(
     [0] => League\Period\Period Object
        (
            [startDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-02 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [endDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-03 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [bounds] => League\Period\Bounds Enum
                (
                    [name] => IncludeStartExcludeEnd
                )

        )

)

(Please complete the text below to help us fix the issue)
can add contains func check the same in sequence  ???
public function intersections(): self
    {
        $current = null;
        $isPreviouslyContained = false;
        $reducer = function (Sequence $sequence, Period $period) use (&$current, &$isPreviouslyContained): Sequence {
            if (null === $current) {
                $current = $period;

                return $sequence;
            }

            /** @var Period $current */
            $isContained = $current->contains($period);
            if ($isContained && $isPreviouslyContained && !$sequence->contains($current)) {
                $sequence->push($current->intersect($period));

                return $sequence;
            }

            if ($current->overlaps($period) && !$sequence->contains($current)) {
                $sequence->push($current->intersect($period));
            }

            $isPreviouslyContained = $isContained;
            if (!$isContained) {
                $current = $period;
            }

            return $sequence;
        };

        return $this
            ->sorted($this->sortByStartDate(...))
            ->reduce($reducer, new self());
    }

Expected result
Array
(
    [0] => League\Period\Period Object
        (
            [startDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-01 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [endDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-03 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [bounds] => League\Period\Bounds Enum
                (
                    [name] => IncludeStartExcludeEnd
                )

        )

    [1] => League\Period\Period Object
        (
            [startDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-02 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [endDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-04 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [bounds] => League\Period\Bounds Enum
                (
                    [name] => IncludeStartExcludeEnd
                )

        )

)

or

Array
(
     [0] => League\Period\Period Object
        (
            [startDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-02 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [endDate] => DateTimeImmutable Object
                (
                    [date] => 2023-01-03 00:00:00.000000
                    [timezone_type] => 3
                    [timezone] => Asia/Shanghai
                )

            [bounds] => League\Period\Bounds Enum
                (
                    [name] => IncludeStartExcludeEnd
                )

        )

)

(What was the expected (correct) behavior?)
Remove duplicate period and give me right intersect periods
Actual result
(What is the current (buggy) behavior?)
i pull a pr , but i do not confirm the pr is right , can you help explain the case real right result ?? thinks

fixed base on PR thanks

the version 5.3.1 is released with your fix. Thanks again
https://github.com/thephpleague/period/releases/tag/5.3.1

@maogou I believe there is already a go port done here https://github.com/studiofrenetic/period maybe it needs some update (full disclosure I do not know go so I can not evaluate the library codebase).

@nyamsprod
I spent a day implementing the corresponding functions in Golang . This project is really great .  Thank you again for opening up this project and for your prompt and enthusiastic response to my message!
https://github.com/maogou/period


When metric/imperial switch is changed, it resets map style selection for route preview

This is due to isolated frame for map preview: parameters are passed from default -> mappreview, but not back.  Thus when outer frame (default) is reset to align to changed system of measure, it does not preserve any user selections inside the map preview frame.
This is possible to fix, but effort is disproportionate to impact.  Workaround: Select imperial/metric first, then make other changes.  Not perfect, but pretty low impact I think.

closing as wontfix.  Will revisit wontfix items when all others resolved.


added the feature to open 'create another task' inside a popup

Hello,
I added the feature to open 'create another task' inside a popup.

The same feature have been implemented in master but differently.


[Bug]: Adding Slashtag Contact then viewing Contacts has interrupted flow initially

Describe the bug
Just tried the iOS version again and noticed a bug with the contact list view. If I start by scanning someones Slashtag and then save it … Then enter the Contact list .. it will always just show a splash screen with “add your first contact!” .. Which is false because it’s already added, and I don’t see how I can actually just list the contacts,, eventually it worked after getting past that one
Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots / Recording
No response
Operating system
iOS
Bitkit version
No response
Log output
No response

"I tried scanning the contact and save it .. but every time I went to check the contact list I just got this splash screen so I thought it was never saved"

Fixed in https://github.com/synonymdev/bitkit/pull/788


Wrong response body for new endpoint '/api/v2/delete'

{
  "result": "Successfully wrote 11 quads.",
  "count": 11
}

Supposed to be deleted, haha

And @dennwc
After the deletion, I checked the nodes collection in MongoDB, it is empty, and it is quite reasonable, but still have bunch of data in the quads collection, can u briefly explain a bit the design here?

And @dennwc
Sorry, one more question regarding the deleteion, as u can check here test_purpose.nq, same to below content:
</user/shortid/23TplPdS> <userId> 23TplPdS companyA .
</user/shortid/23TplPdS> <userSetId> XXX_L2 companyA .
</user/shortid/23TplPdS> <realName> XXX_L3 companyA .
</user/shortid/23TplPdS> <displayName> XXX_L4 companyA .
</user/shortid/23TplPdS> <gender> M companyA .
</user/shortid/23TplPdS> <email><EMAIL_ADDRESS>companyA .
</user/shortid/23TplPdS> <isEmailVerified> false companyA .
</user/shortid/23TplPdS> <mobilePhone><EMAIL_ADDRESS>companyA .
<EMAIL_ADDRESS><isVerified> false companyA .
<EMAIL_ADDRESS><alpha3CountryCode> +65 companyA .
<EMAIL_ADDRESS><mobilePhoneNoWithCountryCallingCode> +6586720011 companyA .

In the nq file if I use the single quote ' or double quote " for the Object values, like 23TplPdS or Lable values, like companyA, whatever I do I cannot use the delete API to successfully delete the data, but If I just leave it as plain bare value, then I will be able to delete all successfully, u can refer to the test case here: /v1/write/file/nquad line:224, so two concerns here:

How Cayley deal with the single quote ' and double quote " in the Object and 'Label' fields.
If user must use plain bare value, then how to deal with the condition that the value iteself contains space.

@lnshi Regarding Mongo, it might be an append-only log of database operations. In any case we will rewrite Mongo code for reification.
@lnshi Regarding your nquads example, I don't think it's written according to standard. Cayley may accept it now, but it might stop doing so eventually :) In particular, all object values should be quoted and escaped. Currently true is interpretted as raw byte array in Cayley, and not string true which you would expect. The correct value should be "true". Same for Label.
And for writing structured data, I'd recommend using JSON-LD format instead of nquads. Don't forget to set format parameter or Content-Type header in this case, so Cayley can determine format properly.

@dennwc thank u for the response.
Yes, I know all the object in N-Quads should be quoted with ", as u can see all other test cases based on the test data here friend_circle_with_label.nq, I believe they are all proper N-Quads data.
@dennwc After compared the data wrote in by /api/v2/write and /api/v1/write/file/nquad, I think I found out the problem, they are not compatible, so: /api/v2/delete can only delete the data which are written in by /api/v2/write, and /api/v1/delete can only delete the data which are written in by /api/v1/write /api/v1/write/file/nquad, I just adjusted the test cases to use the same API version. Any plan regarding the HTTP APIs incompatibleness or just leave it there?
@dennwc  Now cayley already has the APIs for writing, reading, parsing, deleting JSON-LD data?

@dennwc Try to use the /api/v2/delete to delete the data which are written by /api/v1/write/file/nquad, then u will be able to experience what I was encountering.

@dennwc  try to use /api/v2/delete to delete the data which are written in by /api/v1/write/file/nquad then u will be able to experience what I was encountering.

@lnshi Checked /api/v2/delete after /api/v1/write/file/nquad and it works fine:
curl -F<EMAIL_ADDRESS>http://localhost:64210/api/v1/write/file/nquad
curl -H "Content-Type: application/n-quads" --data-binary<EMAIL_ADDRESS>http://localhost:64210/api/v2/delete

These v1 and v2 endpoint are compatible in sense that they can read and write the same data. But /v1/write and /v1/delete uses a hack to make JSON strings convertible to IRIs in some cases. Thus, you may see a difference when writing to these two endpoints.
@lnshi Yes, v0.6.0 can already read/write/delete JSON-LD. All you need is to set Content-Type: application/ld+json for your request (only works for /api/v2).
Note that for /api/v2/read header is different: Accept: application/ld+json. GET request with query parameter format=jsonld will also work for this endpoint.

@lnshi Oh, sorry, v0.6.0 does not support this yet. It's only in v0.6.1 (current master).

@dennwc Thank u very much for the instructions and explanations, after getting this problem solved, I will move on to the JSON-LD support.
Verified, yea, if like this, with my own test data, /v2/delete works fine, but either curl -d or --data-binary with /v1/delete will get below error:
{"error": "invalid character '\u003c' looking for beginning of value"}

But other than this, my point is: I don't think that writing in data with one N-Quads file then completely delete it with passing in the exactly same file is a common use case. Usually the common use case should be: I import bunch of N-Quads data with one N-Quads file, then in the future maybe I want to delete some N-Quads with passing in equivalent JSON data or JSON-LD data, and this is what I tried to do in the test case, and also it is where I encountered this /v1/delete and /v2/delete compatibilities problem.
Refer to test case here: line 210, It writes in data with the N-Quads file, then try to delete all the wrote in N-Quads with passing in equivalent JSON object, here the problem comes: if I use /v1/delete, it works perfectly (all nodes get deleted properly in MongoDB), but if I switch to /v2/delete, then will get the below error(the response body):
{ error: 'delete </user/shortid/23TplPLs> -- <userId> -> 23TplPLs: quad does not exist' }

None N-Quad get deleted, the count of nodes is still 12.
So, in short words: I want u to help me to find out what difference between v1/delete and /v2/delete cause with the same test code base and data base, one works as expected, but one cannot work.
BTW, I also tried to quote the false with " in the passed in JSON object, still, /v2/delete reports same error.
And my cayley is running against quay.io/cayleygraph/cayley:latest, I just updated the container in the morning.


AGPL License file in Source Distributes Confused License Scanners ...

Sorry to bother for such a stupid problem but corporate scanners are flagging the AGPL license in the uv-0.4.13\ecosystem\pretix\license file in the uv source code zip ... which we have to scan before using the executable ... even if we use pip to install it.
I can't tell if pretix package is currently even used in tests yet but its existence in the source code zip is causing issues convincing our decision makers that uv isn't really AGPL and the pretix is only being used for test purposes.

We can just remove it. I'll replace it with something that isn't AGPL.

(It's just an example project that we resolve during the test suite.)

Again ... sorry for such a silly bother!!!

This was actually really helpful for me in the Fedora package, as pretix has additional custom/nonstandard terms (“exceptions”) on top of the AGPL. Even though plain AGPL-3.0-only code is acceptable in Fedora, I was having to use a modified source archive with the contents of ecosystem/pretix/ removed while waiting for legal review of pretix’s idiosyncratic extra terms. Since saleor is just BSD-3-Clause, I can now go back to distributing the unmodified uv source archives in the source RPMs.


Replace WAR_ prefix with WINDOWSAPPRUNTIME_ prefix

Replace WAR_ prefix with WINDOWSAPPRUNTIME_ prefix due to poli check potentially rejecting WAR_ in the future.

/azp run


streams_settings: Removed unused FontAwesome references.

These selectors drill all the way down to inline_decorated_stream_name.hbs, which no longer contains any Font Awesome references.
CZO discussion

Merged, thanks @karlstolley!


Update faqs.md

The following sentence has been added.
Even in a federation environment, Azure AD DS can be used in any environment where the password hash value is synchronized with Azure AD.

However, if you are using Azure AD Connect for password hash synchronization, you can use Azure AD Domain Services because the password hash values on Azure AD.

@shyamag001 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks, @ktoliver