electron.js issue

I keep getting the following error when trying to run my MM. I've updated everything multiple times.
pi@HamsMagicMirror:~/MagicMirror $ npm start

<EMAIL_ADDRESS>start /home/pi/MagicMirror
electron js/electron.js

npm ERR! Linux 4.4.38-v7+
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start"
npm ERR! node v7.3.0
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: electron js/electron.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'electron js/electron.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the magicmirror package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     electron js/electron.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs magicmirror
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls magicmirror
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /home/pi/MagicMirror/npm-debug.log

@raspberrysauce Which RPi are you running? One, two, or three?

Pi 3!
On Dec 23, 2016 1:35 PM, "Nicholas Hubbard"<EMAIL_ADDRESS>wrote:

@raspberrysauce https://github.com/raspberrysauce Which RPi are you
running? One, two, or three?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MichMich/MagicMirror/issues/577#issuecomment-269029428,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXlDZW-8iYhqP2i5iXrQoMqOhBlZ6nX6ks5rLBSAgaJpZM4LUckn
.

I am getting the same error messages using Pi 2 Model B v1.1
node v6.9.2
npm v3.10.9

I also have the same problem on my Pi 3 Model B with the same build process.

Maybe related with #575

I'm just trying MagicMirror2 few days ago, and have same problem.
 Hope this will fix on new commit.
If you install it from curl, and failed,
cd ~/MagicMirror
nano package.json

Change grunt dependency
"devDependencies": {
    "grunt":"~0.4.0",

reinstall dependency, and then built electron
cd ~/MagicMirror
npm install
cd ~/MagicMirror/node_modules/electron-prebuilt/
node install.js

this will take a long time, and finally
cd ~/MagicMirror
npm start

My issue is fixed. Raspian lite doesn't come with x11 installed :/  so no gui means no worky.

Thank you @frdteknikelektro. This fixed my issue.

I realized it doesn't work through SSH. When I ran it directly from the pi
terminal it worked just fine
Very strange ! For now , I'm going to continue running it directly .
On Jan 7, 2017 11:40 PM, "mzawlocki"<EMAIL_ADDRESS>wrote:

Thank you @frdteknikelektro https://github.com/frdteknikelektro. This
fixed my issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MichMich/MagicMirror/issues/577#issuecomment-271129480,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AXlDZRgoi63Z9wCOF6uwFjwJ7hOui6Efks5rQGjXgaJpZM4LUckn
.

Seems like new release v2.1.0 has fixed this issue, better to close this issue. Happy new year! (?)
it says

Replaced electron-prebuilt package with electron in order to fix issues that would happen after 2017.

Does anything have to change in the install to include the new release - I did an install yesterday using the jessielite install guide, it installedl the new 2.1.0; yet I'm getting this ELIFECYCLE error on electron.js

@RBM-PITT Are you try this guide Jessie-Lite-Installation-Guide?

... and ... please check this comment https://github.com/MichMich/MagicMirror/issues/145#issuecomment-271075358

Roramirez - thank you for the reply. Yes - I used the Jessie-Lite-Installation-Guide.
I read the comment #145 and decided to try the full install from this tutorial:
https://forum.magicmirror.builders/topic/236/complete-setup-tutorial
I was successful getting it to run with the full install. I look forward to learning more about this application and building my magic mirror!

@raspberrysauce through SSH you need run
DISPLAY=:0 nohup npm start
So, this issue it seems need to close.

Hello,
I have the same issue :
`npm ERR! Linux 4.4.38-v7+
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start"
npm ERR! node vXXX
npm ERR! npm vXXX
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: electron js/electron.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'electron js/electron.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the magicmirror package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! electron js/electron.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs magicmirror
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls magicmirror
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /home/pi/MagicMirror/npm-debug.log`
I followed the automatic installation procedure, on a raspberry 3 with the last Raspbian Jessie.
I test the command : sudo npm install but I always get the error.
I tried several installs (raspian & node) but still the same error.
Can anyone help me?

@simplearetenir What version of Jessie are you running?
Maybe we should include a test in the Installer to check of it's the right OS (no Jessie Lite), to make sure everything is ok ... @roramirez Are you interested in setting this up?

Hi I'm not sure its related...
I've been trying Magic Mirror on Xubuntu 16.10 with the 'serveronly' option and found that the debian package was out of date in terms of npm version.  As the raspberry Pi is also debian based (I think) then could try installing 7.4 another way.  I found that uninstalling npm then using the Node.js v7 way here: https://nodejs.org/en/download/package-manager/#debian-and-ubuntu-based-linux-distributions - worked for me to get MM up and running.  Thus, just the lines:
curl -sL https://deb.nodesource.com/setup_7.x | sudo -E bash -
sudo apt-get install -y nodejs

I only have a Pi B+ so not tried on that yet.

@MichMich : I run the las version of Jessie (no Jessie lite)

Yes @MichMich I can do it.

To remember me... please reopen it and assign to me.

@roramirez Somehow GitHub wont let me assign it to you.

@MichMich I think you can only assign to collaborators or whatever they are called. Or @roramirez can do it by himself I think. Source

Yes, only can set to collaborators or by default user who is open the issue. It's enough with open state with this I can remember ;)

Ran into the same problem earlier, my solution to it was to just add "sudo" before the actual installer
sudo curl -sL https://raw.githubusercontent.com/MichMich/MagicMirror/master/installers/raspberry.sh | bash

I can not do it :

I mount a SD card with the latest version of Jessie (11/01/2017).
I put it in a raspberry 3 (I also tried in a raspberry 2)
I connect ssh to the raspberry
I launch the command : "sudo curl -sL https://raw.githubusercontent.com/MichMich/MagicMirror/master/installers/raspberry.sh | bash"
Then I launch directly on the raspberry, the CLI command line (not in PIXEL) :
I launch "cd Magicmirror"
I launch "npm start"

And I always get the same error :
`npm ERR! Linux 4.4.38-v7+
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start"
npm ERR! node v6.9.4
npm ERR! npm v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: electron js/electron.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'electron js/electron.js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the magicmirror package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR! electron js/electron.js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR! npm bugs magicmirror
npm ERR! Or if that isn't available, you can get their info via:
npm ERR! npm owner ls magicmirror
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR! /home/pi/MagicMirror/npm-debug.log`
Can anyone do the test with the latest version of Jessie?

Maybe someone can share with me a backup of an SD card with MM running on a PI3

What Raspberry ISO did you download?

@roramirez RASPBIAN JESSIE WITH PIXEL : https://www.raspberrypi.org/downloads/raspbian/

I just already finished a test on Jessie Little. About of HowTo Jessie Lite Installation Guide   I think is missing some packages to install, I added these :
xinit xserver-xorg
The log trace about the process, but curious can find in Pastebin http://pastebin.com/YBDW2CB7

... so, I'll hope soon finish the test for RASPBIAN JESSIE WITH PIXEL

Ok, I tested the Raspbian with Pixel and MagicMirror work by default with the script of installation
Raspbian with Pixel
Version: January 2017
Release date: 2017-01-11
Can find the log of the all process here:  http://pastebin.com/8ftthQqf
Two thing, if used Jessie Little feel free to follow https://github.com/MichMich/MagicMirror/wiki/Jessie-Lite-Installation-Guide
If MagicMirror not work for you can be two things.
1.-) X windows system of Debian is not working or not installed. This is required if dont use the serveronly mode.
2.) I suppose by comment expresed here the users  not append DISPLAY=:0 for sentence start in a  SSH remote session
If you can execute the MagicMirror on terminal by SSH session, must be run LIKE THIS
DISPLAY=:0 npm start
The Pull Request #652 fixed and  prevent this problem. For future instalations  if not set the DISPLAY the script will do it for you.
I've testing Raspbian with Pixel and Little, Release date: 2017-01-11 and all worked.
@MichMich Please close the issue after close the Pull request.

@roramirez : I followed the tutorial for Jessie Lite and it works correctly, thank you very much. Just one thing: the screen saver does not disable (perhaps due to the addition of xinit xserver-xorg).
I think I know why, I could not make it work with Jessie with Pixel : I started the "npm start" from the raspberry command line and not from a command line from PIXEL.

@simplearetenir  if you remove xscreensaver? or remove by desktop setting into Pixel

Same problem like @simplearetenir. I follow the Jessie Lite Installation guide and it works correctly  but the screensaver doesn't disable with :
@xset s noblank
@xset s off
@xset -dpms
into etc/xdg/lxsession/LXDE/autostart and :
xserver-command=X -s 0 -dpms
into sudo nano /etc/lightdm/lightdm.conf
Any idea ?

Problem solved.
It works fine when I add the 3 parameters into /home/pi/.config/lxsession/LXDE/autostart
Instead of /etc/xdg/lxsession/LXDE/autostart

@celianmissud Please add note in wiki to help new users.


A Collection of new python packages

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

@Mic92 added your suggestions to the docs in b7d257a5207f3b7e9cfe002e8b77853c97d5b697 and 005048335b85d25d3a06f65cfee89337c0cb8368.

Thank you. Added it to #29009.


evm t8n support reward -1

Invalid value for option '--state.reward': cannot convert '-1' to Wei (java.lang.NumberFormatException: Illegal leading minus sign on unsigned string -1.)

state.reward  = -1  means to just calculate state hash without coinbase touch or mining rewards to be applied.

Where is this documented in the t8n docs?

You mean this docs?
https://ethereum-tests.readthedocs.io/en/latest/t8ntool-ref.html
It's not up. We actually doesn't have t8n versioning which we should

Would PR #5138 address this? While I can not touch coinbase and not use the default reward, the TX processing will always send fees to the coinbase.  Not paying coinbase fees is going to be really hard to unwind.

https://github.com/ethereum/tests/issues/1165

coinbase fee is paid, it is just 0. if no transactions there is no fee.

Did #5138 complete this issue?

Seems to work, thanks!


[Request]  Please add a changelog.md

Describe the Request
It would be totally awesome if you could add a changelog.md to the repo. I have no experience with, but here are some helpful websites:
https://keepachangelog.com/en/1.1.0/
https://www.mokkapps.de/blog/how-to-automatically-generate-a-helpful-changelog-from-your-git-commit-messages/
Have a question?
What you think?

I do not use a changelog in any of my projects. Besides adding new feature (which will be documented on the homepage), I rarely remove features. When I remove features, I show a deprecated message first for a long time.
Maybe a changelog makes sens once the project reaches v1.0.0.


Prepare to remove prebuilt LLVM binaries. [phab:D128]

Created by zarko at 2015-03-10 23:08:01:
This CL is the first in a series that will remove
prebuilt LLVM binaries and require developers to
point campfire toward LLVM on their own. It introduces
three new properties to .campfire_settings:
llvm_repo, a path to an LLVM checkout, used to make sure
that the version is up to date
llvm_lib, a path (relative to third_party/llvm) to use
to look for built LLVM libraries
llvm_include, a path or array of paths (relative to the
build root) to add to the include search list.
buildtools/check_modules.sh uses the llvm_repo
property to interrogate LLVM checkouts. It supports
git or svn. In this CL, the assertions about minimum
checkout versions are disabled. This script is run
each time campfire is invoked.
I have also amended some extractor tests to make them
more robust in the face of changing compiler resource
files.

fromberger commented inline (context lost during migration) at 2015-03-11 03:39:00:
This works fine, but rubs me the wrong way. I'd be happier if there were a new variable for each of these transforms (or they were iterated), e.g.,
var barePaths = includePaths.reduce(…);
var fixedPaths = barePaths.reduce(…);
or .reduce(…).reduce(…).

fromberger commented inline (context lost during migration) at 2015-03-11 03:39:00:
Surely: /bin/bash ?

fromberger commented inline (context lost during migration) at 2015-03-11 03:39:00:
I assume these will need to be updated in pairs, then?

fromberger commented inline (context lost during migration) at 2015-03-11 03:39:00:
Optional:
"${1:?missing repo path}"
"${2:?missing friendly name}"
"${3:?missing SHA}"

etc. for one (perhaps the first) of the occurrences of each.

fromberger commented inline (context lost during migration) at 2015-03-11 03:39:00:
s/properites/properties/
Where is s defined? (Is that instring ?)
I think the Properites may have been a Moabite sect, though.

fromberger commented inline (context lost during migration) at 2015-03-11 03:39:00:
I think what this means is that substituteArrayProperties(v) on a property p with values [1,2,3] will yield [s:p→1, s:p→2, s:p→3] ?
What are the substituents?
Maybe an example would make this easier to document.
Edit: Having read further, I know now what the substituents look like. But please document them (briefly) anyway.

fromberger commented inline (context lost during migration) at 2015-03-11 03:39:00:
Or, if you like
var changed = false;
do {
   …
} while (changed);

fromberger commented inline (context lost during migration) at 2015-03-11 03:39:00:
I feel like all of this would be more compact as, e.g.,
return instring.replace(/$((\w+))/g, function() {
…something interesting with arguments[1]…
});

schroederc commented inline (context lost during migration) at 2015-03-11 17:35:20:
Or /bin/sh

zarko wrote at 2015-03-11 18:10:31:

Address comments.

zarko commented inline (context lost during migration) at 2015-03-11 18:12:36:
Thanks; I meant /bin/sh. This was dash when I was testing for bashisms.

zarko commented inline (context lost during migration) at 2015-03-11 18:12:36:
Yes--it's easy to do because LLVM uses git-svn, so git SHAs from origin map to svn revisions.

zarko commented inline (context lost during migration) at 2015-03-11 18:12:36:
Done

zarko commented inline (context lost during migration) at 2015-03-11 18:12:36:
Done.

zarko commented inline (context lost during migration) at 2015-03-11 18:12:36:
Done.

zarko commented inline (context lost during migration) at 2015-03-11 18:12:36:
Done

zarko commented inline (context lost during migration) at 2015-03-11 18:12:36:
This preserves the existing substitution behavior (substituteProperties was extracted from code elsewhere). Since we're going from strings to arrays here, it's unclear that .replace() will help.

zarko commented inline (context lost during migration) at 2015-03-11 18:12:36:
Done.

zarko wrote at 2015-03-11 23:15:18:

Compatibility.
Don't check modules on non-buildy actions.

zarko wrote at 2015-03-12 18:28:27:

When merging, treat arrays as values, not as dictionaries.

zarko wrote at 2015-03-12 22:57:24:
ping

fromberger commented inline (context lost during migration) at 2015-03-12 23:21:01:
Could you add a line or two summarizing how these get updated?

fromberger accepted this revision at 2015-03-12 23:21:01

schroederc commented inline (context lost during migration) at 2015-03-12 23:21:53:
Can we rename this to llvm_relative_lib or something similar to connote its relativity?

schroederc commented inline (context lost during migration) at 2015-03-12 23:21:53:
Why isn't this relative as well?
Also, why can't these be derived from just llvm_repo?

schroederc commented inline (context lost during migration) at 2015-03-12 23:26:54:
Isn't this relative to llvm_repo?

schroederc commented inline (context lost during migration) at 2015-03-12 23:26:54:
Ditto. This script is highly cryptic.  Why do we even have to check the versions?

zarko commented inline (context lost during migration) at 2015-03-12 23:54:32:
It is not. (You might build in a completely different directory.)

zarko commented inline (context lost during migration) at 2015-03-12 23:54:32:
If you don't think this is necessary, we can just remove the script. I figured that it would be better for developers to get a warning printed when our LLVM version expectations change.

zarko commented inline (context lost during migration) at 2015-03-12 23:54:32:
Do you mean how the strings in the file get updated, or how the underlying repo gets updated?

zarko commented inline (context lost during migration) at 2015-03-12 23:54:32:
The general expectation I have is that these will either be untouched or they will be set to (possibly unrelated) absolute paths. In the CL with the prebuilt libs removed, this looks like:
      "llvm_repo": "third_party/llvm/llvm",
      "llvm_lib": "llvm/build/Release+Asserts/lib",
      "llvm_include": [
        "third_party/llvm/llvm/include",
        "third_party/llvm/llvm/tools/clang/include",
        "third_party/llvm/llvm/build/include",
        "third_party/llvm/llvm/build/tools/clang/include"
      ],

I'm not sure that it's necessary that llvm_lib has the same implicit root as llvm_include--this implementation turned out to require the fewest changes to campfire. I'd appreciate any suggestions on how to simplify it further (especially since you are more familiar with the build code than I am).
I am particularly hesitant to make llvm_* implicitly relative to llvm_repo, since that seems like it would require special-casing the property names or making absolute paths weird to deal with.

schroederc commented inline (context lost during migration) at 2015-03-13 14:56:56:
Both would be helpful, but I think he meant these particular strings.

zarko wrote at 2015-03-13 18:22:35:

Address comments.
Compatibility.
Don't check modules on non-buildy actions.
When merging, treat arrays as values, not as dictionaries.
Make property names clearer.

zarko closed via commit 783f30439f3a7b3b90486e80aebbffb91ad768df at 2015-03-13 18:23:00


feat: [CDS-70318]: GitOps at Org level

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

Made changes and approved, @meenaravichandran1. Let me know when its ready to merge.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


WIP Add in-place variant of transfer_to_logical_device

The purpose of this is to insert IREE ABI affinity attributes for function arguments.
iree.flow.transfer is not sufficient for cases of in-place updates of function arguments.
An alternative approach is to set the attribute of a Torch FX graph function argument. Then during/after conversion to MLIR to set the corresponding attribute on the MLIR function.

The output IR in the test will look like this
  func.func @main(%arg0: !torch.tensor<[9,8],f32> {iree.abi.affinity = #hal.device.promise<@__device_1>}) -> !torch.vtensor<[9,8],f32> attributes {torch.assume_strict_symbolic_shapes} {
    %0 = torch.copy.to_vtensor %arg0 : !torch.vtensor<[9,8],f32>
    %1 = torch_c.to_builtin_tensor %0 : !torch.vtensor<[9,8],f32> -> tensor<9x8xf32>
    %2 = torch_c.from_builtin_tensor %1 : tensor<9x8xf32> -> !torch.vtensor<[9,8],f32>
    %int1 = torch.constant.int 1
    %int1_0 = torch.constant.int 1
    %3 = torch.aten.add.Scalar %2, %int1, %int1_0 : !torch.vtensor<[9,8],f32>, !torch.int, !torch.int -> !torch.vtensor<[9,8],f32>
    torch.overwrite.tensor.contents %3 overwrites %arg0 : !torch.vtensor<[9,8],f32>, !torch.tensor<[9,8],f32>
    return %3 : !torch.vtensor<[9,8],f32>
  }

We should try to include execution based testing. Having a simple script that performs the transfer, does some simple math, then transfers back running via iree would tell us more about functionality. E.g. IR is good, execution is better.


Laziness vs. assignment: exponential run time of a linear code!

I've generated a purely functional/immutable test, which runs in exponential time with the EO translator "as is", but in linear time with memoization in the runtime library (see commit https://github.com/dours/eo/commit/3dfcf237514c8ddf0c02405ea127196842e20168 for details).
The memoization breaks mutable code (memory and random), so I do not do a pull request. I need some suggestions on how to proceed with this.

@dours very good point, let me investigate

@dours the problem is in the duplicate calculation while "getting" attributes. This test should pass, but it fails:
public final class AtDecoratedTest {
    @Test
    public void readsOnlyOnce() {
        final Dummy dummy = new Dummy(Phi.Φ);
        final Phi neg = dummy.attr("neg").get();
        neg.attr("Δ").get();
        MatcherAssert.assertThat(
            dummy.count,
            Matchers.equalTo(1)
        );
    }
    public static class Dummy extends PhDefault {
        public int count;
        public Dummy(final Phi sigma) {
            super(sigma);
            this.add("φ", new AtComposite(
                this, rho -> {
                ++this.count;
                return new Data.ToPhi(1L);
            }));
        }
    }
}

The EO code would be this:
dummy.neg # here we have TWO calculations
[] > dummy
  1 > @

Instead of two calculations, we should have only one. I think we should "cache" the calculation that happens when we traverse through the "@" attribute.
Maybe you can fix it?

@dours I meant fixing the test I suggested. It doesn't pass now, but it should. We should not calculate an atom twice. But now we do. In the AtDecoratedTest example above, we calculate it first time in order to get the neg atom from the number, and the second time when the neg atom gets the get the number from the parent. This duplication leads to the problem you mentioned in this ticket, I believe: too many calculations of atoms, which grow exponentially.

@dours what do you think will x be equal to, instead of one:
[] > calculates-only-once
  memory > x
  [] > a
    seq > @
      x.write (x.add 1)
      42
  and. > @
    x.write 0
    a.neg.neg.neg.neg.neg.neg.eq 42
    x.eq 1

The answer is 14, which is wrong, I believe. I'm thinking about how to fix this...

@yegor256 well, I believe, mixing laziness and assignments must be fun anyway. In other words, I need to investigate...

@dours try version 0.16.12


Model is not generating accurate recommandations [QST]

Hello. I've adapted t4rec model to my own e-commerce dataset and trained it but the model is not capturing the relationships between products and not giving a logical results. For the test i give him as input a transaction containing one product. The evaluation metrics also are very low(around 0.01). The loss function is decreasing but the predictions doesn't make sense. I tried many things like changing learning rate, batch size,... but doesn't work.

Hi, after adapting default r4rec settings I also receive poor recommendations (e.g. with comparison to baseline association rules). Have you explored why this happens? Im going to debug it with small prepared dataset with minimum features to se what happens.


modernize setup.cfg

Feature or Bugfix

Feature

Purpose

Move setup.py parameters into setup.cfg

Detail

Since setuptools-30.3.0 (8 Dec 2016), almost all parameters can now be written in setup.cfg.

Relates

https://setuptools.readthedocs.io/en/latest/userguide/declarative_config.html

Uploaded information on test pypi looks fine.
https://test.pypi.org/project/django-redshift-backend/2.0.2.dev8/


react-workers: factor-out common code, improve debugging DX

Refactor: move functional core of react-workers to generic (testable/importable) moduele.
Improve DX worker-loader produces incorrect source-maps for features.worker.js so minimizing it allows to see and debug code of "business" functions.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.463%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1892

Relevant Lines:
2450

💛  - Coveralls


[Docs]: Update the documentation for OIDC Authentication for fetching Refresh Tokens

Is there an existing issue for this?

[X] I have searched the existing issues

Documentation Link
https://docs.appsmith.com/getting-started/setup/instance-configuration/authentication/openid-connect-oidc
Describe the problem
Access tokens are not refreshed once they expire and there is a need to re-login every time in order to fetch new ones.
This leads to many requests which are valid to be errored out.
Describe the improvement
As an improvement, superusers need to be educated about using offline_access scope, when setting up the OIDC Authentication, when configuring  a Self Hosted Appsmith Instance.
There are different configurations required by different OIDCs (Auth0, Okta, Active Directory, Ping Identity) and need to me mentioned in the Documentation. Also, respective changes needs to be updated in our Documentation, as mentioned below.
OIDC Refresh Token related changes

Active Directory

Add additional scope offline_access under Configure Scopes

Add additional scope offline_access under Configure Scopes in Active Directory
Changes similar to above point in the Video Attached.

Okta

Add additional scope offline_access under Configure Scopes for Okta
Check Refresh Token in Create Application
General Settings -> Grant Type -> Client acting on behalf of User -> Check Refresh Token.

Auth0

Add additional scope offline_access under Configuring Scopes for Auth0

Ping Identity

Educate Users about Checking the Refresh Token Grant Type in Application configuration as shown in the Image.

Configuration Screen on Ping Identity

@trishaanand - Could you please confirm the priority of this change?

Hi @spark-c, has there been any updates on this.
If you need further clarification on the OIDCs or anything related to the SSO, please reach out to me on the same.

Update: changes to the text are pretty much complete, now am just gathering media to replace outdated screenshots and video from the various OIDC platforms

The docs PR: https://github.com/appsmithorg/appsmith-docs/pull/482 fixes this issue.


fix(RecsListTable) useState hook to distinguish safe for test state

< Table ouiaSafe={testSafe} / > doesn't work it is always equal to true
OuiaSafe property is not described in the patternfly docs so I created an issue in their repository
We need to wait for their answer to understand it better
https://github.com/patternfly/patternfly-react/issues/7185
If it won't get fixed we can add a custom property to the elements to distinguish that it's ready to test them
OR
use refs to add some "test ready flag" to the DOM elements

Codecov Report

Merging #204 (273e9d2) into master (1b04ece) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   76.53%   76.60%   +0.07%
==========================================
  Files          27       27
  Lines         976      979       +3
  Branches      362      362
==========================================
+ Hits          747      750       +3
  Misses        229      229

Impacted Files
Coverage Δ

src/Components/RecsListTable/RecsListTable.js
75.00% <100.00%> (+0.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e1ef00...273e9d2. Read the comment docs.

:tada: This PR is included in version 1.3.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Improve the error message

I think the error message should be more useful.
If specified key is not found on a json, the current message simply says that such element is not found.
But such is not clear. It is hard to identify the key which is not found.
I love this awesome library. :smiley: Very useful!

That's definitely better with a proper error message :)


Added some discouragements if something is wrong

Encouragement is nice but discouragement is even more!

Thanks for the pull request, but I want to keep the default messages encouraging. People can change it to discouragments on their own. :smile:


fix: exclude transform without responsive variants

Description
Exclude transform without responsiveVariants config to avoid warnings in the terminal.
Additional context

Updated the regular expression for extend.

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Follow the Style Guide.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

Thank you @tianenpang ❤


Add e2e yaml templates for all three cloud providers

Remove various custom values (i.e. organization and workspace name) to be set as env variables instead
Also abstract other variables away required for credentials (i.e. github username)
Need to set the following env variables at minimum:

export TOWER_ORGANIZATION_NAME=
export TOWER_TEAM_NAME=
export TOWER_WORKSPACE_NAME=
export TEAM_MEMBER_EMAIL1=
export TEAM_MEMBER_EMAIL2=
export GITHUB_USERNAME=
export TOWER_GITHUB_PASSWORD=
export DOCKERHUB_USERNAME=
export DOCKERHUB_PASSWORD=
export WORK_DIRECTORY=

Some additional things to think about:

Setting work dir as an env variable (dependent on the cloud provider)
Using relative paths for outdir

@drpatelh Do we need a pre-run script for these pipelines? I am trying to strip down these yamls and what additionally is required for them to packaged with. We can't get around file-path for compute-envs JSON (see https://github.com/seqeralabs/tower-cli/issues/330), and maybe not nextflow.config either.


[DOCS] Add 6.8.21 release notes

@jbaiera @masseyke Going to merge this one in too, but a post-merge review is appreciated. Thanks!


Instance map keys

support for both, scrolling without the game acting on the scroll input, and keyboard input without the game acting on it.
https://github.com/runelite/runelite/issues/494

Did you attempt to attach your own mouse and key listeners to the canvas and then .consume() those events? Based on the javadoc I would expect something like that to work.

checkout the first commit LOL

Done in #805


"Add Mistral-7B-LoRA-RAHF-DUAL to AlpacaEval"

"Add Mistral-7B-LoRA-RAHF-DUAL to AlpacaEval"

Nice results 💯
Please address the few comments above and I'll merge it.
Note that the exact commands to run should be specified in https://github.com/tatsu-lab/alpaca_eval?tab=readme-ov-file#contributing-a-model if that doesn't work for you let me know.

OK, thank you for checking


Toggle window focus hotkey is triggered twice

Steps to reproduce

Open sandbox vault
Install this plugin
Focus on other window, such as the browser window
Toggle hotkey
Nothing happens because the hotkey is triggered twice. May use HotkeyDetective to notice this

@vanbang9710 that's interesting.
I think what you've noticed with HotkeyDetective may be slightly misleading, though- the event registered by the plugin is still only getting triggered once, as you can see in the image below (logged 2x by the shortcut's event handler, 4x by HotkeyDetective). My guess would be that Electron's implementation of global shortcuts is to blame (i.e. it may be detecting both keyup and keydown, even if it only actually calls the handler on one of them).

Could you please send me a screen recording of what's happening here for you + what your configuration of the plugin is? The toggle window focus hotkey is working perfectly fine for me, both in a sandbox vault and in my own local vault, so I suspect there's likely something else going on here.

How do you check the plugin log?

The plugin settings

https://github.com/dragonwocky/obsidian-tray/assets/52906188/8fb39c14-6565-4afe-a422-a1376860bd52

@vanbang9710 okay, I think I see what you mean, although there was a lot going on there.
I recommend trying a different hotkey and seeing if that works for you - some keyboard layouts/system languages/apps/etc. will transform characters when Alt is pressed, which can cause issues for hotkeys that contain it. E.g. you can be pressing Alt + E, but by the time it gets to this plugin, it may have actually ended up as É instead (or something similar).
(You can open the console via Ctrl+Shift+I and check the logs there. The coloured text is something I added during testing, but the installable version does log every action via the white text.)

I try Ctrl+q and q but still no luck. In the console, it does show only 1 event each time I press.

@vanbang9710 hm, I see. Well, if the events are being logged in the console properly then it's not a hotkey-related issue, but something to do with the window actually getting focus... but I can't replicate it, so I don't really know how to fix it/what I'm actually fixing. If you can work out what might be causing it (e.g. some conflict with another app you have running?) I may be able to give fixing it a go, but until then there's not a lot I can do, sorry.

Fixed in 0.3.5 (just released) - it was specifically related to the preservation of maximised windows that was added in 0.3.4. I couldn't reproduce this originally because I was testing with the app windowed/not maximised, sorry about that.


add support for np.append

As title suggests

Done! Ready for another round of review.

Please could you merge master into this branch to resolve conflicts, thanks.

I will wait a couple more days to merge master again.

@guilhermeleobas I don't think it was a specific commit, but that some of the conda packages caused the strange errors. I have just restarted the Azure builds, let's see if it goes anywhere.


how can i use nodejs in render process ?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

when i use require in render process ,it throw a Error !

https://www.electronjs.org/docs/tutorial/security#2-do-not-enable-nodejs-integration-for-remote-content
https://github.com/cawa-93/vite-electron-builder#using-electron-api-in-renderer
https://github.com/cawa-93/vite-electron-builder/issues/76#issuecomment-803600966


Issue with Ollama on Ubuntu 22.04 under VirtualBox 7 Windows 11

On this platform, Ollama was installed successfully but got following error when running:
ollama run codellama:7b-instruct
Illegal instruction (core dumped)

Getting same result, on any command

@dekogroup try building from source and bumping up the version of the mimetype depdendancy

Thank you @Rushmore75 . Will try.

@dekogroup my suspicion is you have VirtualBox configured to mask CPU features like AVX and AVX2.  In older builds, we'd crash with illegal instruction.  We have recently added support for running on CPUs without these vector math extensions, but if you can update your VirtualBox configuration, I'd recommend that as it will result in better performance if we have to do any inference on the CPU.

Not an exact answer, but Ollama works great on WSL2 with Ubuntu 22.04 on Windows 11. That's HyperV underneath.

Recent builds will no longer crash, but will not execute on the GPU due to lacking AVX support.  Potentially adding non-AVX support to the GPU builds is tracked via issue #2187


Fix count_all_results when ordering

Fixes error introduced in v3 when there is a pending qr_order_by (used typically in pagination to get a count before results)
Method adapted from v2 DB_active_rec line 911

You're saying it fixes an error, but you're not saying what error that is ...

Using the sqlsrv driver, query builder generates the following query for count_all_results
SELECT COUNT(*) AS "numrows" FROM "tenants" LEFT JOIN "properties" "p" ON "p"."id" = "tenants"."property_id" WHERE "tenants"."deleted_date" =0 AND "tenants"."company_id" = '72' ORDER BY "tenants"."property_id" ASC
In SQL server, this generates the error
Column "tenants.property_id" is invalid in the ORDER BY clause because it is not contained in either an aggregate function or the GROUP BY clause
In the previous version of CodeIgniter, the order by clause was omitted during compilation of the count_all_results query, to avoid this error.
MySQL seems more forgiving of this issue, but omitting the ORDER BY for count_all_results will not change the output for other database drivers


Add .webassets-cache to Flask

Add the .webassets-cache directory to the Flask section.

@2Cubed is there a link to some documentation around this, that we can share with people who want to understand more about this change?

@shiftkey

Flask-Assets helps you to integrate webassets into your Flask application.

https://flask-assets.readthedocs.org/en/latest/
In webassets Environments, a (default) .webassets-cache directory is created.
http://webassets.readthedocs.org/en/latest/environment.html#webassets.env.Environment.cache

@2Cubed excellent, thanks!


Adding a Pytorch version

Please find a Pytorch version of the reinforcement learning tutorial, if some of us want to try this library for RL. The structure is exactly the same, just some changes to build the models. I provide a suggestion of solution that solves the different exercise steps of the tutorial.

Thank you for this version :)
If you want to merge it please

remove all execution traces from the exercises notebook
remove your solution notebook

I've removed execution traces and the solution notebook in this last commit.

It seems the recommended way to install pytorch should be via:
conda install pytorch torchvision -c pytorch
I'm unable to make it work if I install using pip on OSX :(
Which way did you install it ?

I tested this version and everything seems fine. We could merge it after we figure out the recommended setup instructions for pytorch.

On the main page of Pytorch, they say "Anaconda is our recommended package manager", I think that's the most stable way to install it.


Updated ingress apiVersion from v1beta1 to v1

Ingress apiVersion v1beta1 is deprecated since k8s 1.19+ and will be unusable in k8s 1.22+. Its therefor a good idea to set the new and proper apiVersion to not break this awesome chart.

Thanks for the contribution, however I think it's important for this to be conditional on the version of Kubernetes in use. There will be plenty of people with older clusters on which this chart will quite happily install otherwise.

I've made my own version of this change which takes into account the cluster version and the changes between v1beta1 and v1.


PHP7.1 is missing php-fpm.conf and php.ini

After installing<EMAIL_ADDRESS>on Catalina i'm missing several config files, like php-fpm.conf, php-fpm.d directory and php.ini.
I've tried reinstalling but to no avail. Im on this version of brew:
$ brew -v
Homebrew 2.2.1
Homebrew/homebrew-core (git revision dd63; last commit 2019-12-18)
Homebrew/homebrew-cask (git revision 26f014; last commit 2019-12-18)

Same for me, would be great if that could be fixed!

Hi!
Thanks for reporting the issue.
Indeed, the<EMAIL_ADDRESS>bottle is incomplete, where the ini files are missing. It happened in the past and I still don't know why this happened.
I've rebuild and deployed a new bottle. It should now have the missing files. Please run brew update; brew reinstall<EMAIL_ADDRESS>to update your tap and reinstall php 7.1.
Have a nice day!

@TheLalaMan I won't be building bottles for older macOS versions, but it should work fine, just taking a little bit longer.

Thanks for the quick resolve! Works now :)


good, up to date documentation (wiki?) to promote and support contributors

Please keep the converstations in english so non-dutch speakers can read along (lower the barrier to join)

github offers wiki functionality, see for example https://github.com/OSGP/Platform/settings

ok

ok

I think that the question about up-to-date an complete documentation is relevant. My feeling is that improvement is possible and needed. @phoutman confirms this. @eduarddrenth do you have any suggestions how we can improve this?


Short circuit non-tagged unions

The idea here is to do a first pass where we do not do exhaustive validation and instead try to optimistically find a match. Then if we don't find one we go back and do exhaustive validation so that we can build up the errors and such. In the example benchmark (which I know is a list but I think is representative of more complex objects) this is a 2x speedup (and it would be a 100x speedup if there were 100 options in the union).
The penalty of this is the same as doing the strict mode pass first (although I understand there's non-performance reasons to do that): we have to re-validate in an exhaustive match later. I think it would be interesting to explore some sort of "state cache" in the future that can be used for this as well as the strict mode first pass so that a validator can "pick up where it left off". I think the easiest way to do this would be to convert:
fn validate(...) -> ValResult<...>

Into something like:
fn validate(..., state: Option<ValStateToken>) -> (Option<ValStateToken>, ValResult<...>)

And then each Validator can come up with it's own state to store if it makes sense for it. I think the only ones that would make sense are lists and typed-dict where it'd be trivial to store "the last field/index that passed validation" or something like that.

Codecov Report

Merging #430 (d86254a) into main (e0008e9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   95.50%   95.50%
=======================================
  Files          90       90
  Lines       10735    10761   +26
  Branches       10       10
=======================================
+ Hits        10252    10277   +25
- Misses        482      483    +1
  Partials        1        1

Impacted Files
Coverage Δ

src/input/return_enums.rs
97.89% <100.00%> (+0.02%)
:arrow_up:

src/validators/generator.rs
91.90% <100.00%> (+0.04%)
:arrow_up:

src/validators/mod.rs
98.76% <100.00%> (+0.04%)
:arrow_up:

src/validators/typed_dict.rs
98.95% <100.00%> (+<0.01%)
:arrow_up:

src/validators/union.rs
98.09% <100.00%> (-0.28%)
:arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0008e9...d86254a. Read the comment docs.

@ art049 I just added a benchmark here. It would be really cool if I could hit a button and say "run these benchmarks on main and show me the difference". Obviously this would fail in a lot of scenarios but I think it would work in quite a few, at least for optimization work like this where one should not be changing public APIs, adding features, etc.

We should figure out at build time if exhaustiveness applies to the child validators. E.g. a StringValidator would say no and then the caller would know to not do a first exhaustive pass.

@art049 I just added a benchmark here. It would be really cool if I could hit a button and say "run these benchmarks on main and show me the difference". Obviously this would fail in a lot of scenarios but I think it would work in quite a few, at least for optimization work like this where one should not be changing public APIs, adding features, etc.

For what it's worth, might make sense to make a separate PR to main to add this benchmark to make the before/after more obvious.

For what it's worth @adriangb, might make sense to make a separate PR to main to add this benchmark to make the before/after more obvious.

There's 2 cons to that:

Manual work, this one is obvious
If this change doesn't end up landing that benchmark in main may not make sense. In other words, we want to know how that benchmark performs on main but maybe not necessarily add it to main.

From discussion today: this is an interesting idea, but we have to:

Avoid doing an first non-exhaustive pass for types that don't support it. This means either (1) adding code to immediately return for those types or (2) doing something at validator build time to detect if that validator supports these checks or not.
We should implement the state thing first so that we don't add more passes.

@art049 I just added a benchmark here. It would be really cool if I could hit a button and say "run these benchmarks on main and show me the difference". Obviously this would fail in a lot of scenarios but I think it would work in quite a few, at least for optimization work like this where one should not be changing public APIs, adding features, etc.

Super interesting @adriangb, I think this could fit well with the historical run feature(basically running the latest benches on older revisions). It might just be a bit complicated regarding dependency management though. But I'll think about it when I work on it!

Closing this PR for now


Disallow balance move to same account

Bugfix for moveAccountBalance, throw if fromAccount and toAccount are the same.

Although we shouldn't be triggering this from the workload: https://github.com/GoogleCloudPlatform/cloud-spanner-samples/blob/main/workload/src/main/java/com/google/finapp/WorkloadClient.java#L62-L72.


Test dump limit

Created To Test Crash Server Memory issue

Closing as I guess you opened this by mistake or on the wrong repo. If you meant to open this here then can you please rebase this on master and better explain what you are doing.


Remediation for Bad OpenSSL Versions

Hi,
When uploading my Android app to the store i get this feedback from google: https://support.google.com/faqs/answer/12576638
We are using your library in our project: org.bouncycastle:bcpkix-jdk18on:1.72. I can see that the library is using openSSL, is it using a version between 1.1.1b and 1.1.1h? Where a runtime error could occur?
Thanks in advance.

Sorry, it must be something else. We don't use OpenSSL.


Cannot run npm install with custom modules with Nuxt 3.5.0

Environment
------------------------------
- Operating System: Linux
- Node Version:     v16.14.2
- Nuxt Version:     3.5.0
- Nitro Version:    2.4.0
- Package Manager<EMAIL_ADDRESS>- Builder:          vite
- User Config:      modules
- Runtime Modules:  ./modules/myModule
- Build Modules:    -
------------------------------

Reproduction
Run npm install in this sandbox:
https://stackblitz.com/edit/github-s6insh?file=nuxt.config.ts
Describe the bug
Running npm install with a custom module results in an error that the module cannot be found. I wasn't expecting an error. This previously worked fine with Nuxt 3.4.3.
ERROR  Error while requiring module ./modules/myModule: Error: Cannot find module 'modules/myModule'           5:15:13 PM
Require stack:
- /home/projects/github-s6insh/index.js

 ERROR  Cannot start nuxt:  Cannot find module 'modules/myModule'                                               5:15:13 PM
Require stack:                                                                                5:15:07 PM
- /home/projects/github-s6insh/index.js

  Require stack:
  - index.js
  at Module._resolveFilename (https://githubs6insh-mmv3.w-corp.staticblitz.com/blitz.bdcb25d8.js:35:242305)
  at Function.resolve (https://githubs6insh-mmv3.w-corp.staticblitz.com/blitz.bdcb25d8.js:35:480406)
  at Function._resolve [as resolve] (node_modules/jiti/dist/jiti.js:1:241100)
  at resolveModule (file://node_modules/@nuxt/kit/dist/index.mjs:331:36)
  at requireModule (file://node_modules/@nuxt/kit/dist/index.mjs:341:24)
  at normalizeModule (file://node_modules/@nuxt/kit/dist/index.mjs:537:90)
  at async Module.installModule (file://node_modules/@nuxt/kit/dist/index.mjs:510:41)
  at async initNuxt (file://node_modules/nuxt/dist/index.mjs:2906:7)
  at async load (file://node_modules/nuxi/dist/chunks/dev.mjs:216:9)
  at async Object.invoke (file://node_modules/nuxi/dist/chunks/dev.mjs:260:5)

Additional context
No response
Logs
No response

Thank you. As a workaround, you can update to:
modules: ['~/modules/myModule/index'],

That also results in an error:
ERROR  Cannot find module 'modules/myModule/index'
Require stack:
- /home/projects/github-s6insh-eawouj/index.js

index.js indeed doesn't exist, it should be index.ts.

You can see it working here: https://stackblitz.com/edit/github-s6insh-z11cqr?file=nuxt.config.ts

Ah, I see, I didn't add the ~ character.

I got this problem with yarn run build:
✔ Server built in 3788ms                                                                                13:41:35
✔ Generated public .output/public                                                                                nitro 13:41:35
ℹ Building Nitro Server (preset: node-server)                                                                                nitro 13:41:35
ERROR  Error: EISDIR: illegal operation on a directory, readlink 'D:\DEVELOPMENT\PROJECTS\projectX\node_modules\node-fetch-native\dist\polyfill.mjs'                                                                                nitro 13:42:14
undefined
ERROR  EISDIR: illegal operation on a directory, readlink 'D:\DEVELOPMENT\PROJECTS\projectX\node_modules\node-fetch-native\dist\polyfill.mjs'                                                                                13:42:14

@TinyLightBold I don't think that's the same issue. Could you create a new issue with a reproduction, please? 🙏

I'll try to create one


add left sliding back

add left sliding back, left sliding in entire screen(extends BaseActivity) or in left edge(extends DialogFragmentActivity)
my github/android repo https://github.com/zhengxiaopeng/android

I'm not sure I like this feature, as the app uses the horizontal scroll everywhere. But I'll install it on my phone and give it a try before deciding.

@jonanp   If the app requires horizontal slide you can only use the edge of the slide returned. Easy to use sliding returned if needn‘t horizontal scroll , but looks like the kind of place too little. : (

I'm not really a fan of this as well, if even only because of the animation. Intuition tells me that sliding something away should result in some sort of translation out of the view.

Good point

If need to, then you can add it to setting.

I've been trying this feature on my phone for a few days and I haven't had a good experience. I've closed a few activities accidentaly, which is very frustraiting, and a lot of times I really wanted to close the activity I've had to do the gesture 3 or 4 times because the horizontal scroll was taking the focus.


Discrete prices quantities

PR that switches from Double as the underlying numeric type for both prices and quantities to Long.  Still work required to sort out the weighted average pricing rule (which requires multiplying a Long by a Double).

@bherd-rb Take a look at the WeightedAveragePricingRule.  We need to sort out the following private method...
  private[this] def average(k: Double)(bid: Price, ask: Price): Price = {
    Price(k * bid.value) + Price((1 - k) * ask.value)
  }

...which raises a compilation error because 'k' is a Double' and the value parameter for Priceis now aLong`.

@bherd-rb I have sorted out a solution to computing the weighted average price. Basically, I convert everything to doubles in order to compute the average and then cast the result back to a long.  This casting is almost certainly losing precision and it would be better to round the double to the nearest long.
Perhaps it would be better to try and calculate the average without converting to doubles?

Silly me! Apparently the scala.math library has a built-in round function that converts a double to a long! Fixed up the pricing rules to use this method where necessary.  This PR is ready to merge...

@davidrpugh That looks good. I was trying to come up with a pure integer-based solution that avoids conversion to double. But that only works if the longs are sufficiently large. So I suppose your solution is the safest choice.


Quirks to support egardia / woonveilig alarm systems

This alarm system has two specific quirks which pysiaalarm has to be aware of to work properly: it needs to support messages where the CRC is in binary instead of hexadecimal, and it needs to support devices which have timestamps in local time instead of UTC.
I've seen the "binary CRC" thing mentioned online for some other alarm systems, so it doesn't seem to be unique to this specific brand. I'm not sure if other systems exist that also use non-UTC time.
The commit messages should be pretty self-explanatory. Please check the message for  the binary CRC commit to see some comments about why a server setting is necessary, and how it could possibly be avoided with some changes to error handling.
The binary CRC commit also has an unrelated correctness fix for responses, as noted in the commit message.

Also, just had the Actions run, and apparently the test where not adapted!

Hi @robvolgers I finally got around to doing some work on this package, I have added support for the device timezone in the account (in the dev branch), have done that based on pytz timezones, with a default on UTC. Please have a look. I will look at the binary stuff as well.

Just created a release with these features, 3.1.0b1, check it out @robvolgers


Dangling disk cleanup on GCP

https://www.notion.so/bisonai/03-06-Orakl-Network-Sync-492d21c8ced0422698251582f1f297eb?pvs=4#447d5573ae96462f9a22987a76720047

I've deleted unused disk by use following command.
# Set project to Baobab
gcloud config set project gcp-baobab-prod

# Execute delete command each zone(it's bothered a bit, but can't find resource with `--region` option.
gcloud compute disks list --filter="-users:*" | awk '{print $1}' | xargs -I{} gcloud compute disks delete {} --zone asia-southeast1-a -q
gcloud compute disks list --filter="-users:*" | awk '{print $1}' | xargs -I{} gcloud compute disks delete {} --zone asia-southeast1-b -q
gcloud compute disks list --filter="-users:*" | awk '{print $1}' | xargs -I{} gcloud compute disks delete {} --zone asia-southeast1-c -q

# Set project to Cypress
# Execute same command again

Great job! Thank you!


[Bug]: json.decoder.JSONDecodeError when generating Community reports

Describe the bug
json={{    "title": "Product Team: Mansz and Jrman" {{ is giving error.  I tried to fix the system message for community report. but I found out the error still persists and when I looked into report then it shows that community_report prompt is null.
in setting.yaml, prompt filename for community report is "prompts/community_report.txt"
I updated double braces '{{' to single { in "community_report.txt" but it still creating the json with double '{{'.
community_report:
  prompt: "prompts/community_report.txt"
  max_length: 4000
  max_input_length: 12000

Also, in indexing-engine.log in "community_reports" section,
its showing "prompt": null and not showing the filename as 'prompts/community_report.txt', which is mentioned in setting.yaml
"community_reports":
      "async_mode": "threaded",
      "prompt": null,
      "max_length": 2000,
      "max_input_length": 8000,
      "strategy": null

Steps to reproduce
No response
Expected Behavior
No response
GraphRAG Config Used
encoding_model: cl100k_base
skip_workflows: []
llm:
api_key: ${GRAPHRAG_API_KEY}
type: azure_openai_chat # or azure_openai_chat
model: gpt-4-32k (0613)
model_supports_json: false
max_tokens: 4000
request_timeout: 180.0
api_base: -removed because of security purpose
api_version: '2023-05-15'
organization: <organization_id>
deployment_name: gpt-4-32k
tokens_per_minute: 150_000 # set a leaky bucket throttle
requests_per_minute: 10_000 # set a leaky bucket throttle
max_retries: 10
max_retry_wait: 10.0
sleep_on_rate_limit_recommendation: true # whether to sleep when azure suggests wait-times
concurrent_requests: 25 # the number of parallel inflight requests that may be made
parallelization:
stagger: 0.3
num_threads: 50 # the number of threads to use for parallel processing
async_mode: threaded # or asyncio
embeddings:
parallelization: override the global parallelization settings for embeddings
async_mode: threaded # or asyncio
llm:
api_key: ${GRAPHRAG_API_KEY}
type: azure_openai_embedding
model: text-embedding-ada-002
api_base: removed because of security purpose
api_version: '2023-05-15'
# organization: <organization_id>
deployment_name: embedding
# tokens_per_minute: 150_000 # set a leaky bucket throttle
# requests_per_minute: 10_000 # set a leaky bucket throttle
# max_retries: 10
# max_retry_wait: 10.0
# sleep_on_rate_limit_recommendation: true # whether to sleep when azure suggests wait-times
# concurrent_requests: 25 # the number of parallel inflight requests that may be made
# batch_size: 16 # the number of documents to send in a single request
# batch_max_tokens: 8191 # the maximum number of tokens to send in a single request
# target: required # or optional
chunks:
size: 300
overlap: 100
group_by_columns: [id] # by default, we don't allow chunks to cross documents
input:
type: file # or blob
file_type: text # or csv
base_dir: "input"
file_encoding: utf-8
file_pattern: ".*\.txt$"
cache:
type: file # or blob
base_dir: "cache"
connection_string: <azure_blob_storage_connection_string>
container_name: <azure_blob_storage_container_name>
storage:
type: file # or blob
base_dir: "output/${timestamp}/artifacts"
connection_string: <azure_blob_storage_connection_string>
container_name: <azure_blob_storage_container_name>
reporting:
type: file # or console, blob
base_dir: "output/${timestamp}/reports"
connection_string: <azure_blob_storage_connection_string>
container_name: <azure_blob_storage_container_name>
entity_extraction:
llm: override the global llm settings for this task
parallelization: override the global parallelization settings for this task
async_mode: override the global async_mode settings for this task
prompt: "prompts/entity_extraction.txt"
entity_types: [organization,person,geo,event]
max_gleanings: 0
summarize_descriptions:
llm: override the global llm settings for this task
parallelization: override the global parallelization settings for this task
async_mode: override the global async_mode settings for this task
prompt: "prompts/summarize_descriptions.txt"
max_length: 500
claim_extraction:
llm: override the global llm settings for this task
parallelization: override the global parallelization settings for this task
async_mode: override the global async_mode settings for this task
enabled: true
prompt: "prompts/claim_extraction.txt"
description: "Any claims or facts that could be relevant to information discovery."
max_gleanings: 0
community_report:
llm: override the global llm settings for this task
parallelization: override the global parallelization settings for this task
async_mode: override the global async_mode settings for this task
prompt: "prompts/community_report.txt"
max_length: 4000
max_input_length: 12000
cluster_graph:
max_cluster_size: 10
embed_graph:
enabled: false # if true, will generate node2vec embeddings for nodes
num_walks: 10
walk_length: 40
window_size: 2
iterations: 3
random_seed: 597832
umap:
enabled: false # if true, will generate UMAP embeddings for nodes
snapshots:
graphml: false
raw_entities: false
top_level_nodes: false
local_search:
text_unit_prop: 0.5
community_prop: 0.1
conversation_history_max_turns: 5
top_k_mapped_entities: 10
top_k_relationships: 10
max_tokens: 12000
global_search:
max_tokens: 12000
data_max_tokens: 12000
map_max_tokens: 1000
reduce_max_tokens: 2000
concurrency: 32
Logs and screenshots
20:19:16,982 graphrag.config.read_dotenv INFO Loading pipeline .env file
20:19:16,988 graphrag.index.cli INFO using default configuration: {
"llm": {
"api_key": "REDACTED, length 32",
"type": "azure_openai_chat",
"model": "gpt-4-32k (0613)",
"max_tokens": 4000,
"request_timeout": 180.0,
"api_base": "removed because of security purpose",
"api_version": "2023-05-15",
"proxy": null,
"cognitive_services_endpoint": null,
"deployment_name": "gpt-4-32k",
"model_supports_json": false,
"tokens_per_minute": 0,
"requests_per_minute": 0,
"max_retries": 10,
"max_retry_wait": 10.0,
"sleep_on_rate_limit_recommendation": true,
"concurrent_requests": 25
},
"parallelization": {
"stagger": 0.3,
"num_threads": 50
},
"async_mode": "threaded",
"root_dir": "GraphRAG/",
"reporting": {
"type": "file",
"base_dir": "output/${timestamp}/reports",
"storage_account_blob_url": null
},
"storage": {
"type": "file",
"base_dir": "output/${timestamp}/artifacts",
"storage_account_blob_url": null
},
"cache": {
"type": "file",
"base_dir": "cache",
"storage_account_blob_url": null
},
"input": {
"type": "file",
"file_type": "text",
"base_dir": "input",
"storage_account_blob_url": null,
"encoding": "utf-8",
"file_pattern": ".*\.txt$",
"file_filter": null,
"source_column": null,
"timestamp_column": null,
"timestamp_format": null,
"text_column": "text",
"title_column": null,
"document_attribute_columns": []
},
"embed_graph": {
"enabled": false,
"num_walks": 10,
"walk_length": 40,
"window_size": 2,
"iterations": 3,
"random_seed": 597832,
"strategy": null
},
"embeddings": {
"llm": {
"api_key": "REDACTED, length 32",
"type": "azure_openai_embedding",
"model": "text-embedding-ada-002",
"max_tokens": 4000,
"request_timeout": 180.0,
"api_base": "removed because of security purpose",
"api_version": "2023-05-15",
"proxy": null,
"cognitive_services_endpoint": null,
"deployment_name": "embedding",
"model_supports_json": null,
"tokens_per_minute": 0,
"requests_per_minute": 0,
"max_retries": 10,
"max_retry_wait": 10.0,
"sleep_on_rate_limit_recommendation": true,
"concurrent_requests": 25
},
"parallelization": {
"stagger": 0.3,
"num_threads": 50
},
"async_mode": "threaded",
"batch_size": 16,
"batch_max_tokens": 8191,
"target": "required",
"skip": [],
"vector_store": null,
"strategy": null
},
"chunks": {
"size": 300,
"overlap": 100,
"group_by_columns": [
"id"
],
"strategy": null
},
"snapshots": {
"graphml": false,
"raw_entities": false,
"top_level_nodes": false
},
"entity_extraction": {
"llm": {
"api_key": "REDACTED, length 32",
"type": "azure_openai_chat",
"model": "gpt-4-32k (0613)",
"max_tokens": 4000,
"request_timeout": 180.0,
"api_base": "removed because of security purpose",
"api_version": "2023-05-15",
"proxy": null,
"cognitive_services_endpoint": null,
"deployment_name": "gpt-4-32k",
"model_supports_json": false,
"tokens_per_minute": 0,
"requests_per_minute": 0,
"max_retries": 10,
"max_retry_wait": 10.0,
"sleep_on_rate_limit_recommendation": true,
"concurrent_requests": 25
},
"parallelization": {
"stagger": 0.3,
"num_threads": 50
},
"async_mode": "threaded",
"prompt": "prompts/entity_extraction.txt",
"entity_types": [
"organization",
"person",
"geo",
"event"
],
"max_gleanings": 0,
"strategy": null
},
"summarize_descriptions": {
"llm": {
"api_key": "REDACTED, length 32",
"type": "azure_openai_chat",
"model": "gpt-4-32k (0613)",
"max_tokens": 4000,
"request_timeout": 180.0,
"api_base": "removed because of security purpose",
"api_version": "2023-05-15",
"proxy": null,
"cognitive_services_endpoint": null,
"deployment_name": "gpt-4-32k",
"model_supports_json": false,
"tokens_per_minute": 0,
"requests_per_minute": 0,
"max_retries": 10,
"max_retry_wait": 10.0,
"sleep_on_rate_limit_recommendation": true,
"concurrent_requests": 25
},
"parallelization": {
"stagger": 0.3,
"num_threads": 50
},
"async_mode": "threaded",
"prompt": "prompts/summarize_descriptions.txt",
"max_length": 500,
"strategy": null
},
"community_reports": {
"llm": {
"api_key": "REDACTED, length 32",
"type": "azure_openai_chat",
"model": "gpt-4-32k (0613)",
"max_tokens": 4000,
"request_timeout": 180.0,
"api_base": "removed because of security purpose",
"api_version": "2023-05-15",
"proxy": null,
"cognitive_services_endpoint": null,
"deployment_name": "gpt-4-32k",
"model_supports_json": false,
"tokens_per_minute": 0,
"requests_per_minute": 0,
"max_retries": 10,
"max_retry_wait": 10.0,
"sleep_on_rate_limit_recommendation": true,
"concurrent_requests": 25
},
"parallelization": {
"stagger": 0.3,
"num_threads": 50
},
"async_mode": "threaded",
"prompt": null,
"max_length": 2000,
"max_input_length": 8000,
"strategy": null
},
"claim_extraction": {
"llm": {
"api_key": "REDACTED, length 32",
"type": "azure_openai_chat",
"model": "gpt-4-32k (0613)",
"max_tokens": 4000,
"request_timeout": 180.0,
"api_base": "removed because of security purpose",
"api_version": "2023-05-15",
"proxy": null,
"cognitive_services_endpoint": null,
"deployment_name": "gpt-4-32k",
"model_supports_json": false,
"tokens_per_minute": 0,
"requests_per_minute": 0,
"max_retries": 10,
"max_retry_wait": 10.0,
"sleep_on_rate_limit_recommendation": true,
"concurrent_requests": 25
},
"parallelization": {
"stagger": 0.3,
"num_threads": 50
},
"async_mode": "threaded",
"enabled": true,
"prompt": "prompts/claim_extraction.txt",
"description": "Any claims or facts that could be relevant to information discovery.",
"max_gleanings": 0,
"strategy": null
},
"cluster_graph": {
"max_cluster_size": 10,
"strategy": null
},
"umap": {
"enabled": false
},
"local_search": {
"text_unit_prop": 0.5,
"community_prop": 0.1,
"conversation_history_max_turns": 5,
"top_k_entities": 10,
"top_k_relationships": 10,
"max_tokens": 12000,
"llm_max_tokens": 2000
},
"global_search": {
"max_tokens": 12000,
"data_max_tokens": 12000,
"map_max_tokens": 1000,
"reduce_max_tokens": 2000,
"concurrency": 32
},
"encoding_model": "cl100k_base",
"skip_workflows": []
}
20:20:39,273 graphrag.index.reporting.file_workflow_callbacks INFO Community Report Extraction Error details=None
20:20:39,273 graphrag.index.verbs.graph.report.strategies.graph_intelligence.run_graph_intelligence WARNING No report found for community: 0
20:20:39,346 httpx INFO HTTP Request: POST --"
20:20:39,347 graphrag.llm.openai.utils ERROR error loading json, json={{    "title": "Application Support Team and Controlled Environment",    "summary": "The community revolves around the Application Support Team, which provides assistance to users experiencing problems with the application. The team interacts with various features of the application, including the Controlled Environment, Admin Tab, In-app Support Ticket System, Statuses File, and Summary View.",    "rating": 7.0,    "rating_explanation": "The impact severity rating is high due to the critical role of the Application Support Team in ensuring smooth operation of the application.",    "findings": [          {{            "summary": "Functionality of the Summary View",            "explanation": "The Summary View is a customizable section of the application where users can adjust the display of information. The Application Support Team can provide assistance for customizing the Summary View, indicating its complexity and potential for user customization. [Data: Entities (26), Relationships (37)]"        }}    ]}}
Traceback (most recent call last):
File "/opt/conda/lib/python3.10/site-packages/graphrag/llm/openai/utils.py", line 93, in try_parse_json_object
result = json.loads(input)
File "/opt/conda/lib/python3.10/json/init.py", line 346, in loads
return _default_decoder.decode(s)
File "/opt/conda/lib/python3.10/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/opt/conda/lib/python3.10/json/decoder.py", line 353, in raw_decode
obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)
20:20:39,349 graphrag.llm.openai.openai_chat_llm WARNING error parsing llm json, retrying
20:20:39,978 httpx INFO HTTP Request: POST https://agvisorapimtest.azure-api.net/openapi-test/openai/deployments/gpt-4-32k/chat/completions?api-version=2023-05-15 "HTTP/1.1 200 OK"
20:20:39,980 graphrag.llm.openai.utils ERROR error loading json, json={output_text}
Traceback (most recent call last):
File "/opt/conda/lib/python3.10/site-packages/graphrag/llm/openai/openai_chat_llm.py", line 124, in _manual_json
json_output = try_parse_json_object(output)
File "/opt/conda/lib/python3.10/site-packages/graphrag/llm/openai/utils.py", line 93, in try_parse_json_object
result = json.loads(input)
File "/opt/conda/lib/python3.10/json/init.py", line 346, in loads
return _default_decoder.decode(s)
File "/opt/conda/lib/python3.10/json/decoder.py", line 337, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/opt/conda/lib/python3.10/json/decoder.py", line 353, in raw_decode
obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 1 column 2 (char 1)
During handling of the above exception, another exception occurred:
Additional Information

GraphRAG Version: 0.1.1
Operating System: AWS sagemaker distribution 1.9
Python Version: 3.10.14
Related Issues:

I also encountered this error, I solved this bug by change the default summary report prompt, In which I change the "{{" and "}}" with "{" and "}"

@WeiminLee I did that. but the graph rag still fetching the old summary_report inside the code instead of the local changed summary_report.txt file that is mentioned in my settings.yaml.

@WeiminLee I did that. but the graph rag still fetching the old summary_report inside the code instead of the local changed summary_report.txt file that is mentioned in my settings.yaml.

It's a bug, so you should change the prompt inside the Package(graphrag/index/graph/extractors/graph/prompts.py)

我做到了。但是图形抹布仍然在代码中获取旧summary_report，而不是我的settings.yaml中提到的本地更改summary_report.txt文件。

这是一个错误，所以你应该更改包内的提示（graphrag/index/graph/extractors/graph/prompts.py）

actually it may should be “graphrag/index/graph/extractors/graph/prompts.py”， anyway, thank you 4 that!

我做到了。但是图形抹布仍然在代码中获取旧summary_report，而不是我的settings.yaml中提到的本地更改summary_report.txt文件。

这是一个错误，所以你应该更改包内的提示（graphrag/index/graph/extractors/graph/prompts.py）

Actually it may should be "graphrag/index/graph/extractors/community_reports/prompts.py", anyway thank you!

我做到了。但是图形抹布仍然在代码中获取旧summary_report，而不是我的settings.yaml中提到的本地更改summary_report.txt文件。

这是一个错误，所以你应该更改包内的提示（graphrag/index/graph/extractors/graph/prompts.py）

Actually it may should be "graphrag/index/graph/extractors/community_reports/prompts.py", anyway thank you!

I am using: python -m graphrag.index --init --root GraphRAG/  , So, GraphRAG is my local folder which contains the prompts/community_reports.txt which you can edit for customized system message.

@WeiminLee I did that. but the graph rag still fetching the old summary_report inside the code instead of the local changed summary_report.txt file that is mentioned in my settings.yaml.

It's a bug, so you should change the prompt inside the Package(graphrag/index/graph/extractors/graph/prompts.py)

Is there any chance you could show the original prompt you had and what you then changed it to?

@Archdiner
in graphrag/index/graph/extractors/community_reports/prompts.py all occurrence of {{ to { and  }} to }.
for example:
{{
     "title": <report_title>,
     "summary": <executive_summary>,
     "rating": <impact_severity_rating>,
     "rating_explanation": <rating_explanation>,
     "findings": [
         {{
             "summary":<insight_1_summary>,
             "explanation": <insight_1_explanation>
         }},
         {{
             "summary":<insight_2_summary>,
             "explanation": <insight_2_explanation>
         }}
     ]
 }}

> to following.
{
        "title": <report_title>,
        "summary": <executive_summary>,
        "rating": <impact_severity_rating>,
        "rating_explanation": <rating_explanation>,
        "findings": [
            {
                "summary":<insight_1_summary>,
                "explanation": <insight_1_explanation>
            },
            {
                "summary":<insight_2_summary>,
                "explanation": <insight_2_explanation>
            }
        ]
    }

13:56:11,978 datashaper.workflow.workflow INFO executing verb create_community_reports
13:56:33,992 httpx INFO HTTP Request: POST http://<IP_ADDRESS>:11434/v1/chat/completions "HTTP/1.1 200 OK"
13:56:33,998 graphrag.llm.openai.utils ERROR error loading json, json=Here is the output in JSON format:```{    "title": "Baidu Community",    "summary": "The Baidu community revolves around Robin Li, the founder and CEO of Baidu, a Chinese technology company focused on AI applications and research. The community's dynamics are shaped by Robin Li's concerns about AI development risks and his leadership role in Baidu.",    "rating": 6.0,    "rating_explanation": "The impact severity rating is moderate due to the potential influence of Robin Li's views on AI development and Baidu's prominent position in the tech industry.",    "findings": [        {            "summary": "Robin Li's leadership role in Baidu",            "explanation": "Robin Li is the founder, chairman, and CEO of Baidu, indicating his significant influence over the company's direction and decisions. This leadership role is crucial in understanding the community's dynamics [Data: Entities (21); Relationships (24)]."        },        {            "summary": "Baidu's focus on AI applications and research",            "explanation": "Baidu is a Chinese technology company focused on both AI applications and research, suggesting its significant contribution to the development of AI in China. This focus could have implications for the community's dynamics [Data: Entities (22)]."        },        {            "summary": "Robin Li's concerns about AI development risks",            "explanation": "Robin Li is concerned about the risks associated with AI development, which could impact society. This concern suggests that he may be cautious in his approach to AI development and deployment [Data: Relationships (5)]."        }    ]}```Let me know if you need any further assistance!
Traceback (most recent call last):
  File "/data/galen_guo/workspace/LLM-Research/graphrag/graphrag/llm/openai/utils.py", line 93, in try_parse_json_object
    result = json.loads(input)
             ^^^^^^^^^^^^^^^^^
  File "/home/galen.guo/miniforge3/envs/rag_env/lib/python3.11/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/galen.guo/miniforge3/envs/rag_env/lib/python3.11/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/galen.guo/miniforge3/envs/rag_env/lib/python3.11/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
13:56:33,999 graphrag.llm.openai.openai_chat_llm WARNING error parsing llm json, retrying

----
I am encountering the same issue. I modified prompts/community_report.txt and graphrag/index/graph/extractors/community_reports/prompts.py, but the changes did not take effect. I ran the command using poetry run poe index --root .. Does this relate to the problem we discussed earlier?

@WeiminLee @Archdiner @Amitabh-Priyadarshi-Bayer
I am having this error:
json.decoder.JSONDecodeError: Expecting ',' delimiter: line 1 column 327 (char 326)`
What should I do?


Support LZ4 compression type in producer

https://github.com/joekiller/jruby-kafka/blob/v1.5.0/lib/jruby-kafka/producer.rb#L17

should be good in v1.6

Closing this issue as this has been fixed in https://github.com/logstash-plugins/logstash-integration-kafka/commit/e5bf1265f937c1d2a954e0c6ed24f63375d39bf7

Never say never.


Fix pre-commit config

@mcoughlin let's fix it properly.

Please add top-label too - variable type
On 5/14/21 12:38 PM, Dmitry Duev wrote:

@mcoughlin https://github.com/mcoughlin let's fix it properly.

    You can view, comment on, or merge this pull request online at:

https://github.com/ZwickyTransientFacility/scope/pull/34
https://github.com/ZwickyTransientFacility/scope/pull/34
    Commit Summary

fix pre-commit config
File Changes

M .pre-commit-config.yaml
https://github.com/ZwickyTransientFacility/scope/pull/34/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9
(4)
Patch Links:

https://github.com/ZwickyTransientFacility/scope/pull/34.patch
https://github.com/ZwickyTransientFacility/scope/pull/34.patch

https://github.com/ZwickyTransientFacility/scope/pull/34.diff
https://github.com/ZwickyTransientFacility/scope/pull/34.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ZwickyTransientFacility/scope/pull/34, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQMJY7Y74UJ7EDUA4YFFNDTNV34NANCNFSM4447QY2Q.

@AshishMahabal sorry?

I responded to the wrong notification. There were two dozen
notifications on PR 33, and then that first one on 34.
Sorry. I meant please add "top label" to the histogram.
On 5/14/21 12:47 PM, Dmitry Duev wrote:

@AshishMahabal https://github.com/AshishMahabal sorry?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ZwickyTransientFacility/scope/pull/34#issuecomment-841465016,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQMJY3N2YJXANP5FJ5AWSTTNV43XANCNFSM4447QY2Q.

What does that mean @AshishMahabal ?


No source code

There's a statement:
Will be free software under MIT license

Is, or will, the source code be available for the rfa.so?  Without it, it doesn't look like it's possible to modify the implementation.

Hi,
Due to the agreement with Thomson Reuters, we are not at liberty to distribute its RFA libraries. We just thought that the MIT license will allow users to freely use PyRFA worry free.


Updating api version and version

Change(s):

Changed ARM apiVersion of Microsoft.OperationalInsights/workspaces to 2021-06-01
"Version" of saved seraches to 2, as it seems to be what is actually present in Azure (what if always wants to overwrite version 2 with 1)

Reason for Change(s):

Remove what-if noise
Remove preview api

Testing Completed:

Deployed successfully

Version updated:

All contentversion updated from <IP_ADDRESS> to <IP_ADDRESS>

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @mariussm : the templates are derived files generated by ASimYaml2ARM. The changes should be applied to the "templates of templates" of this tool and will propagate to the ARM templates as we rebuild.
There are two reasons for that:

Ensuring that your changes remain on the next build.
When we build, we run a test cycle.


Add memory and CPU request to git-clone task

This is the first task that is run using the PVC, so when this task is scheduled to an AZ all other tasks in the PipelineRun that use the workspace will be scheduled to the same AZ.
If this task has no resource requests the scheduler can over assign tasks to the same AZ.

/retest

I don't think this failure is related, but I think it is a real problem. I just imported a sample in the UI and it created multiple components, so 'Expected length of the detected Components was not 1' for component detection could indicate the underlying problem.

Yop, strange, there is really CDQ with three components detected...
/retest
I would like to have this change validated by performance team.
For testing this should be created before creating component in the namespace:
apiVersion: appstudio.redhat.com/v1alpha1
kind: BuildPipelineSelector
metadata:
  name: build-pipeline-selector
spec:
  selectors:
    - name: all-pipelines
      pipelineRef:
        name: docker-build
        bundle: quay.io/redhat-appstudio-tekton-catalog/pull-request-builds:docker-build-dd8dd0bf734d23d51172bbd86364ac1a6b78d724


Flexible con grouping.

Some changes to start with #260 .

Do we really need an ordered dict?
Exposed using cortex colors from different colormaps as well.

We need to keep the same order of the keys because otherwise the order of the groups might randomly change. I think that's why there is this weird implementation of lists of dicts. However, in the newer python versions, dicts apparently do keep the order of the keys. The question would then be backwards compatibility.

We need to keep the same order of the keys because otherwise the order of the groups might randomly change. I think that's why there is this weird implementation of lists of dicts. However, in the newer python versions, dicts apparently do keep the order of the keys. The question would then be backwards compatibility.

As I understand it, when we use a list of dict, the order of the groups are preserved because it is a list. I think the "list of dict" was implemented instead of dict because previously dict did not preserve order. Now we have the option to change "list of dict" to dict/OrderedDict but there is no real reason to do so.

@ckiefer0 can you please have a look again? If you are okay with the changes then we can merge and in a new PR modify examples to reflect variable name changes if needed.

@ckiefer0 can you please have a look again? If you are okay with the changes then we can merge and in a new PR modify examples to reflect variable name changes if needed.

In general, the changes look good. However, due to the different order of functions it is extremely hard to follow any changes in con_viz.py. In the future it might be a better idea to leave that to a separate pull request where there are no changes to the code itself.

@ckiefer0 can you please have a look again? If you are okay with the changes then we can merge and in a new PR modify examples to reflect variable name changes if needed.

In general, the changes look good. However, due to the different order of functions it is extremely hard to follow any changes in con_viz.py. In the future it might be a better idea to leave that to a separate pull request where there are no changes to the code itself.

Yeah I should have kept that for a last commit, sorry about that.
Thanks a lot @ckiefer0 . Merging it now.


Route methods do not consider prefix in parent instance

In a setup I have, I make a subroute under /admin/:id. The normal instance.get() method in the subroute recognizes that the prefix has been added, so /ventilator is appended to /admin/:id. However, instance.zod.get() does not recognize the prefix, and insists that I have to assign /admin/:id/ventilator as the path.
export const runServer = async () => {
  const fastify = Fastify()

  // fastify-zod integration
  await register(fastify, {
    jsonSchemas: buildJsonSchemas(schemas),
    swaggerOptions: {
      routePrefix: '/swagger',
      exposeRoute: true,
    }
  })

  fastify.register(adminRoutes, {
    prefix: '/admin/:id'
  })

  const port = 3000
  fastify.listen({ port }, err => {
    if (err) throw err
    console.log(`Listening on port ${port}`)
  })
}

runServer()

import { FastifyPluginAsync } from 'fastify'
import { ObjectId } from 'mongodb'
import { Ventilator, ventilator } from '../../schemas/ventilator/ventilator'

const adminRoutes: FastifyPluginAsync = async (instance) => {
    // {"message":"Route GET:/admin/62765ac9c76bdc1796d81b89/ventilator not found","error":"Not Found","statusCode":404}
    instance.zod.get('/ventilator', {operationId: 'getVentilator', params: 'GetVentilatorHandlerParams', reply: 'ventilatorWithId'}, async ({params}) => {
        const document = await instance.mongo.db?.collection<Ventilator>('ventilators').findOne({vid: new ObjectId(params.vid)})
        if (document == null) throw new Error('Could not retrieve document.')
        return document
    })
    // {"vid":"62765ac9c76bdc1796d81b89"}
    instance.get<{Params: {vid: ObjectId, ventilatorid: ObjectId, itemid: ObjectId}}>('/ventilator', (req, res) => {
        res.send(req.params)
    })
}

export default adminRoutes

Thank you for pointing that out.
Would you please create a failing test case I can use to implement a fix?
Otherwise I'll do it.

I'm sorry but I didn't commit the code before migrating to typebox, so the state of the project when I made that code is gone. I sadly don't have the energy to set up a minimal repro

Is this going anywhere? Also the case for fastify-autoload plugin: #34

this makes the fastify.zod[..methods] is completely incompatible with my setup and i'll have to continue the "deprecated" route..

I am very interested in supporting this. Can you please provide me with some example code?

@elierotenberg so for context, a lot of people structure their routes like this with fastify:
app.register((i, r, d) => {
  i.register(hotTakesRoutes, {
    prefix: 'hot-takes'
  })

  done()
}, {
  prefix: 'api',
})

this is super handy since you can inject different stuff into the request depending on the request group - they all share the prefix, you can add extra guards etc
it's explained in more detail here:
https://www.fastify.io/docs/latest/Reference/Plugins/
moreover a lot of people also prefer the instance.route() way of defining routes.. ie.
instance.route<{ Reply: SomeDef }>({
  method: 'GET',
  url: '/someurl',
  preHandler: (req) => { /* check something, or query for data */ },
  handler: async () => {
    ...route logic
  }
})

I'm not here to argue for why somebody would do this, this is just part of the fastify api.  and the reason why the very nice and clever looking api instance.zod.xxx() won't work for a lot of fastify use cases.
I hope that clarifies the issue and is helpful

Is there a way I can help with this issue? Sample github project or something?

Is there any news on this?


Add GitHub Actions for linting

Changes

Add ROS2 GitHub Actions linters (ament_copyright, ament_xmllint, ament_lint_cpp) to project.
Similar work was done to rosbag2 here: ros2/rosbag2#227

Issues

Old PR: https://github.com/ros2/rosbag2_bag_v2/pull/12

Signed-off-by: Zachary Michaels<EMAIL_ADDRESS>

@Karsten1987 linters ran in this PR.
I spoke with the team and once the linters are in master, they will run on all PRs to master; including PRs from forks.


New-AzPrivateDnsZoneConfig is not recognized

[# Module: 07
Hello
in the step private dns zone
the command New-AzPrivateDnsZoneConfig is not recognized
so cannot run the script !!!
thanks

MOC Labs Review did not experience this issue.

Please insure you have Installed the Az PowerShell module


BTM-228 Athena Transaction View

This PR will be closed as BTM-228 is being deleted. The work Garth has done around Custom Views will be used in BTM-241.

This PR is closed as BTM-228 is being deleted. The work Garth has done around Custom Views will be used in BTM-241.


cruft always clones even when a local path is specified

While trying to develop a new cookiecutter repo I spent an hour trying to figure out why my test that worked in cookiecutter didn't work in cruft. Turns out cruft will always clone from the git repo even if you pass in a local directory. So unless your changes are committed then cruft won't pick them up.

Out of curiosity is this for cruft create or cruft update? If for the latter, I just pushed a PR (#282 ) to support updating from a local template and not cloning. Your local changes do still need to be committed, though, as cruft tracks history using commit refs.

I did a test-drive with a local cookiecutter template and commit the changes in the template. I can confirm this works, and this issue can be closed.


Provide 'master spreadsheet' capabilities

As an analyst
I want to see all my project information in once place
so I can track it's progress
As an analyst
I want to be able to manage all CCBC and old program data and report on it from the portal
So that the data team and the comms team have automated reports from the database
NWBC analysts are used to working with what is known as the 'master spreadsheet' which holds several important pieces of information that can be used to track the progress of the project in it's process.
This ticket is to recreate the capabilities that the analysts find useful in the master spreadsheet.

@MarsRomer can we close this card?

closing this ticket as it's part of othe rwork


Chore/fix seo

Feature or Problem
This corrects some SEO nits on our docs and blogs

Weird that lighthouse disliked this PR 🤔


Time.Clock.now does not return actual current time

Version

Phaser Version: 3.13.0

Operating system: Windows 10

Browser:

Description

The property  Time.Clock.now always returns the same time from when the clock was made, not the actual current time. Is this intended?
Example Test Code

import "../src/lib/phaser.js";

var Scene = new Phaser.Class( {
	Extends: Phaser.Scene,

	preload: function preload ()
	{

	},

	create: function create ()
	{
		this.clock = new Phaser.Time.Clock(this);
		this.timeText = this.add.text(0, 0, "Nothing");
	},

	update: function update(time, delta)
	{
		this.timeText.text = this.clock.now.toString();
	}
});

var config = {
    type: Phaser.CANVAS,
    width: 800,
    height: 600,
    backgroundColor: '#000000',
    parent: 'phaser-example',
    pixelArt: true,
    scene: [Scene],
}
var game = new Phaser.Game(config);

Additional Information

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

If you create your own instance of a Clock then you are responsible for updating it.
Scene's have a Clock instance ready enabled (this.time from within the Scene) for which the value is correct, as the Scene updates it as part of the game loop.


How about other GAN@GTEx?

Is it too time-consuming to compare with other GAN@GTEx work (they are on older version of GTEx anyway)?
Wang, Xiaoqian, Kamran Ghasedi Dizaji, and Heng Huang. "Conditional generative adversarial network for gene expression inference." Bioinformatics 34.17 (2018): i603-i611.
Ghasedi Dizaji, Kamran, Xiaoqian Wang, and Heng Huang. "Semi-supervised generative adversarial network for gene expression inference." Proceedings of the 24th ACM SIGKDD International Conference on Knowledge Discovery & Data Mining. 2018.

Good findings! Thanks for sharing, I will take a proper look at these papers soon.
While the methodology is slightly similar (e.g., GAN), the problem that we address here is different - our predictions are not based on landmark genes.

Good findings! Thanks for sharing, I will take a proper look at these papers soon.
While the methodology is slightly similar (e.g., GAN), the problem that we address here is different - our predictions are not based on landmark genes.

I think they do not release codes. I am trying to find other codes to convince you my that second last issue makes sense.


Add luisifern's file

created a branch, created a file and made a commit, and opened a pull request

post additional commits 101

finish branch, then delete


update uglify-js to 2.8.29

This addresses the following vulnerability:
https://nodesecurity.io/advisories/48

+1


mse: streams: wrong user/pass

I've seen this closed issue: https://github.com/AlexxIT/go2rtc/issues/63
In my case I have a tapo cam. I'm using this config in go2rtc:
    camara_s1:
        - rtsp://MyUser:MyPass123@<IP_ADDRESS>:554/stream2
    camara_s2:
        - rtsp://MyUser:MyPass123@<IP_ADDRESS>:554/stream1

If I open the link on the browser it opens VLC and the stream works fine. MyUser and MyPass123 only have letters and numbers. If I use tapo stream it works all fine, but I would like to access to stream2.

You can increase log level

Magically started working today...
Just changed log level to trace and seen it's working (haven't tested before changing log level...)
This is quite strange... The only thing I think it can have influenced: I had v1.8.5, there was a warning of an update available, I've updated and it updated to v1.8.4 😮  (no update available right now). It was not working anyway.
I'm not sure if I tried after reboot, I think not and it might be the problem. Could it be a problem in v1.8.5?
Otherwise I'm sorry I don't have logs now to see where the problem is.

I have never heard about similar issue with v1.8.5. There's just the problem of reconnecting to problematic streams there.


Bump easy-purescript-nix

packages.dhall specifies PureScript 0.13.8, while the easy-purescript-nix commit hash points to 0.13.6, so trying to build the project in nix-shell fails.
Before

After

I haven't jumped on the nix train yet, but I trust this is a change for the better.

Yeah, I don't know, it seems like keeping the shell.nix up to date might be a bit of a burden if the core maintainers of this project aren't using Nix, so alternatively could just scrap the Nix stuff 🤷 . For Nix users, nix-prefetch-git https://github.com/justinwoo/easy-purescript-nix.git will get the latest rev and sha256, so this at least adds those instructions if it gets out of sync in the future. I wonder if it's something that could be automated in CI.

Also, those are some nice looking shadowed screenshots. Was wondering if that was a new GH feature, but guessing you just grabbed a bit of desktop too.

I'm on a Mac, that's just the default screenshot look when you capture a window. It is nice.

I haven't jumped on the nix train yet, but I trust this is a change for the better.

Yeah, I don't know, it seems like keeping the shell.nix up to date might be a bit of a burden if the core maintainers of this project aren't using Nix, so alternatively could just scrap the Nix stuff 🤷 . For Nix users, nix-prefetch-git https://github.com/justinwoo/easy-purescript-nix.git will get the latest rev and sha256, so this at least adds those instructions if it gets out of sync in the future. I wonder if it's something that could be automated in CI.

Also, those are some nice looking shadowed screenshots. Was wondering if that was a new GH feature, but guessing you just grabbed a bit of desktop too.

I'm on a Mac, that's just the default screenshot look when you capture a window. It is nice.

Yeah, nix is a great idea but something I just don't use right now. If we did support it, I would prefer to add a disclaimer of "use nix to build this project at your own risk; maintainers have not vetted what the nix code does" or something to that effect. If we don't do that, then dropping it entirely would be best.

Yeah, nix is a great idea but something I just don't use right now. If we did support it, I would prefer to add a disclaimer of "use nix to build this project at your own risk; maintainers have not vetted what the nix code does" or something to that effect. If we don't do that, then dropping it entirely would be best.

I'm not sure I want to keep nix in the future, but I think this is safe to merge.