8300756 - Tributary to Skeena River

[x] added mention of small outlet drop (from photos) and changed comments to say not a major barrier to fish passage, because the outlet drop could be a barrier to some life stages.
[x] added mention on historic CT FISS sites upstream and downstream, as well as fry spotted during assessment of downstream crossing.

[x] Small road/trail between highway and outlet, culvert runs underneath both.  Will remove 8302959 from bcfishpass modelling

has a small outlet drop, but does not appear to be a major fish passage issue.

[x] from the photos we can see that the outlet drop is muuuch bigger than 5cm. Will revise to be 20cm, add note about estimate from photo in comments and remove the not about not a major fish passage issue.


[GSOC]: Active Sampling for Min-Max Fairness

Project Description: Min-max fairness is a natural and desirable notion of subgroup fairness. The goal of this project is to develop open source implementations of recent research into label efficient active sampling algorithms for achieving min-max fairness. Furthermore the project will involve benchmarking the algorithms against baselines, demonstrating fairness benefits on several publicly available datasets and exploring the use of accelerated gradient descent based techniques for making the algorithms more efficient.
Towards the above goal we encourage participants to first complete the following starter tasks.
Note: The following tasks are open for multiple submissions. Anyone interested in the project is encouraged so solve the tasks below and submit their work.
Starter Task 1: Train a one layer fully connected network in tensorflow to solve the binary classification problem of income prediction for the UCI Adult Dataset. Choose a reasonable batch size (say 32 or 64) and a reasonable number of epochs (say 50). Plot the test accuracy as a function of the number of processed batches. Also plot, as a function of the number of processed batches, the performance gap in the model accuracy for points with sex=Male vs. points with sex=Female.
Starter Task 2: Partition the training set into two subsets S1 and S2 based on sex. Retrain the network with the same settings as in Task 1. However this time alternate batch selection between S1 and S2. In other words if the first batch of 32 or 64 examples is chosen randomly from S1 then the next batch is chosen from S2..and so on. Report the same metrics as in Task 1. Summarize your results and suggest one or two ways to reduce the performance gap in the model accuracy for points with sex=Male vs. points with sex=Female.

I have done starter task 1 can you check gitter message please Professor where I have also sent you my notebook. Or do you want me to post my notebook here?

Hello, @pranjal-awasthi. I have completed the given starter tasks.
please have a look at my colab submission here: https://colab.research.google.com/drive/1W7wwbaVDNc9yIGhYxKFvMrAXHeKa98pP?usp=sharing
Please suggest any improvements.
Thank you.

Thanks a lot for working on the tasks! Pranjal and Jenny will take a look.
Note to future applicants: Please use a different public dataset of your choice instead of the UCI adult dataset to work on this task.

Hello @bhaktipriya ! I used the COMPAS Recidivism Racial Bias dataset to develop these tasks. Please let me know if it is fine or I should use another dataset. Anyway I share my notebook with the tasks developed for now.
@pranjal-awasthi please take a look at my notebook with the requested tasks for this project and let me know any suggestions for improvement: https://colab.research.google.com/drive/1BaFISQOc8abCIJ-elHWoO88iuQFDDa10
Thank you all!

Hello @pranjal-awasthi , please find my notebook in the following notebook:
https://colab.research.google.com/drive/1yS7nBIluesRJ8Bp1nz3tk2r7X9nKjqaQ?usp=sharing
I would be grateful to have your comments on that.

Thanks a lot for working on the tasks! Pranjal and Jenny will take a look.
Note to future applicants: Please use a different public dataset of your choice instead of the UCI adult dataset to work on this task.

Sorry, I saw your comments very late! I have been working on my notebook since the last week and didn't catch your message.  What should I do?

Hello @bhaktipriya ! I used the COMPAS Recidivism Racial Bias dataset to develop these tasks. Please let me know if it is fine or I should use another dataset. Anyway I share my notebook with the tasks developed for now.
@pranjal-awasthi please take a look at my notebook with the requested tasks for this project and let me know any suggestions for improvement: https://colab.research.google.com/drive/1BaFISQOc8abCIJ-elHWoO88iuQFDDa10
Thank you all!

@gaalocastillo : your colab looks good to me. Please formulate a preliminary project proposal with weekly tasks/deliverables and send it to me for review.

@dimoibiehg : your colab looks good to me. Please formulate a preliminary project proposal with weekly tasks/deliverables and send it to me for review.

Hello @bhaktipriya ! I used the COMPAS Recidivism Racial Bias dataset to develop these tasks. Please let me know if it is fine or I should use another dataset. Anyway I share my notebook with the tasks developed for now.
@pranjal-awasthi please take a look at my notebook with the requested tasks for this project and let me know any suggestions for improvement: https://colab.research.google.com/drive/1BaFISQOc8abCIJ-elHWoO88iuQFDDa10
Thank you all!

@gaalocastillo : your colab looks good to me. Please formulate a preliminary project proposal with weekly tasks/deliverables and send it to me for review.

I just sent you via email a project proposal draft, please let me know any comments from your side. In the next days I will work on the suggestions Jenny just left as comments in the document.

Hello @pranjal-awasthi, I request you to please take a look at my notebook which has Starter Task 1 and 2. I have used Wine Quality Data Set.
Notebook: https://colab.research.google.com/drive/1NZPyxkFRw8eWmvIQ7F8kZGAMr0qbgwuj?usp=sharing
I am working further on reducing performance gap.  I will be glad to know any suggestions or improvements. Thank you.

@pranjal-awasthi I sent you a mail regarding proposal draft with subject " GSoC Proposal draft for Title "Active sampling for ML Fairness" "please review it and give feedback on how can I improve.
Thank you.


Docs inconsistent with implementation "SelecterPickerFormableRow"

SelecterPickerFormableRow should be SelectorPickerFormableRow in the docs.

Closing this, I would suggest submitting a PR with the changes made to the README 👍


Crash on lua file

puzzledef{
  id = 'skewb_lookalike_hypercube',
  name = "skewb lookalike hypercube",
  ndim = 4,
  meta = {
    id = 'skewb_lookalike_hypercube',
    author = "Milo Jacquet",
  },

  build = function()
    for v in cd{4, 3, 3}:expand('ooox') do
      carve(v:normalized())
      add_color(v)
    end
    for v in cd{4, 3, 3}:expand('xooo') do
      slice(v:normalized()/math.sqrt(3))
    end
  end,
}

Normalizing the color fixes it

The API has changed, so this is no longer possible


Orders simply not placing?

my code is as follows:
auth_client.place_market_order(             product_id='ETH-USD',             side='buy',             funds=str(buysize)             )
The code works without errors yet the order is not placed. API key has view and trade permissions.

I was using sandbox, which did not allow for ETH trading. Switching to BTC caused it to work as expected.


in the file preprocess.py, the shape of item in featuresArray if (128,X）, not (128)

I don't understand what exactly is the issue?

Closing this, as I got no response.


.antigen/init.zsh has wrong antigen.zsh script location

Description
Antigen ignores real script location when generating cache.
Steps to reproduce

Install antigen latest version

% curl -L https://github.com/zsh-users/antigen/releases/download/v2.2.3/antigen.zsh > ~/.antigen.zsh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   600    0   600    0     0    692      0 --:--:-- --:--:-- --:--:--   692
100 58907  100 58907    0     0  29995      0  0:00:01  0:00:01 --:--:--  183k
% echo "source ~/.antigen.zsh
antigen apply" >> ~/.zshrc

% zsh # Open a new interactive shell to invoke ~/.zshrc
% antigen version
antigen:source:2: no such file or directory: /home/tim/antigen.zsh
% grep -C2 "/home/tim/antigen.zsh" /home/tim/.antigen/init.zsh
antigen () {
  local MATCH MBEGIN MEND
  [[ "$ZSH_EVAL_CONTEXT" =~ "toplevel:*" || "$ZSH_EVAL_CONTEXT" =~ "cmdarg:*" ]] && source "/home/tim/antigen.zsh" && eval antigen $@;
  return 0;
}

Expected behavior:
Antigen caches the actual location of the initial script.
Software version

antigen version

Antigen v2.2.3 (ff391b5)
Revision date: 2018-01-02 13:19:57 +0100

zsh --version

zsh 5.1.1 (x86_64-ubuntu-linux-gnu)

uname -a

Linux Desktop-01 4.4.0-43-Microsoft #1-Microsoft Wed Dec 31 14:42:53 PST 2014 x86_64 x86_64 x86_64 GNU/Linux

Configuration

gist of .antigenrc N\A
gist of .zshrc N\A

More information
The bug seems to be here https://github.com/zsh-users/antigen/blob/develop/bin/antigen.zsh#L1833 as the location of the antigen-zsh script is hard-coded there during cache generation. I think it was only tested against a git-clone installation.

2 years later, any updates? I'm unable to use the antigen command without changing my install location.

Could that be causing problems if the path I pass to antigen init has spaces in it?


Create Test Trusted Directory IG deployment

[x] Create git repo
[x] Create IG deployment for Test Trusted Directory

[x] Move routes / scripts from core IG deployment
[x] Create docker image

New repo created: https://github.com/SecureApiGateway/secure-api-gateway-test-directory


Clusters

Is it possible to assign a group of nodes with their own set of edges in a cluster without defining "cluster specific" edges?
How are clusters used in this library?

Can you give an example of what you want do achieve?
Can you do this with the native dot implementation or would it be an extension?

https://graphviz.gitlab.io/_pages/Gallery/directed/cluster.html
Yep, its possible with native DOT -> Graphviz implementation. Just not sure if this library has support for it.

Just use .cluser():
Graph g = graph().with(
    graph("1").cluster().graphAttr().with(Label.of("#1")).with(node("a0").link("a1")),
    graph("2").cluster().graphAttr().with(Label.of("#2")).with(node("b0").link("b1")),
    node("start").link("a0", "b0"));

Is this possible with MutableGraphs?

.setCluster()

I'm able to create clusters and add them to my overall graph, but I can't find a way to set the rank of specific clusters inside the overall graph so only some (potentially all) start at the same spot.

How would you do it in DOT?

a way to set the rank of specific clusters inside the overall graph so only some (potentially all) start at the same spot

Do you mean like swim lanes?
https://www.google.com/search?q=swim+lanes+graphviz

Swim lanes are similar to what I want. I ended up figuring it out though! I had to make all edges that connect different clusters "constraint"="false"

So, closing the issue.


TABLE AUTOMATICALLY KICKED ME

What happened?

NOW I LOST A LOT OF CHIPS BECAUSE OF THAT.

Steps to reproduce
Fix the bug
Operating System
Windows 10  (10.0.19043) 64bit
Wallet
Metamask
CPU
AMD Ryzen 5 3600 6-Core Processor
GPU
NVIDIA GeForce GTX 1650 3961MB
RAM
16294MB
Kernel Version
1.0.0-2189800740.commit-1ab8e83
Unity Version
desktop-main.commit-7b08a86
Realm
dg
NameTag
marites#c079

This is a problem with the scene's code, not the client


Should re-render/adjust page contents when switching monitors or screen resolution

Attach (recommended) or Link to PDF file here:
Configuration:

Web browser and its version: Version 88.0.4324.96 (Official Build) (x86_64)
Operating system and its version: MacOS 11.1
PDF.js version: PDF Viewer
2.3.164
Is a browser extension: Yes

Steps to reproduce the problem:

Open a pdf (using the extension) in a given window
Move the window to another monitor with a different resolution

What is the expected behavior? (add screenshot)
I expected the pdf to re-render the page to adjust for the new resolution. The default Chrome pdf viewer does this when you "interact" with the pdf (e.g. scroll or click) - it is a little disconcerting as it takes a moment, but it is better than continuing to use the page rendered at a different resolution.
Thank you!

Web browser and its version: Version 88.0.4324.96 (Official Build) (x86_64)

Huh; there's no actual browser name provided here, which makes this part unclear.
Based on the rest of the issue, I'm guessing that this is related to the Chromium-extension. /cc @Rob--W

Web browser and its version: Version 88.0.4324.96 (Official Build) (x86_64)

Huh; there's no actual browser name provided here, which makes this part unclear.
Based on the rest of the issue, I'm guessing that this is related to the Chromium-extension. /cc @Rob--W

Yes, it's Chrome.

Yes, it's Chrome.

Does this issue also happen with https://mozilla.github.io/pdf.js/web/viewer.html ? The Chrome extension version hasn't been updated for a while (and I need to take a very good look at the changes since the last update before publishing a new one).
If it also happens with the online version, then it's not an extension-specific problem.

Does this issue also happen with https://mozilla.github.io/pdf.js/web/viewer.html ? The Chrome extension version hasn't been updated for a while (and I need to take a very good look at the changes since the last update before publishing a new one).
If it also happens with the online version, then it's not an extension-specific problem.

It works the same with both local files (i.e. Chrome extension) and the page you posted.
I just noticed it DOES re-render when I change zoom or when I scroll more than 2 pages away from where I was. The Chrome built-in viewer re-renders when I scroll at all. I would have reported it as such initially if I had realized. Sorry about that!

It works the same with both local files (i.e. Chrome extension) and the page you posted.
I just noticed it DOES re-render when I change zoom or when I scroll more than 2 pages away from where I was. The Chrome built-in viewer re-renders when I scroll at all. I would have reported it as such initially if I had realized. Sorry about that!

The question here is if there's an event, or some other property, that can be used to check if a browser window has been moved to another screen!?
Some, admittedly very quick, searching seem to suggest that there's no good way of getting the necessary information with Javascript here (and as always we want to avoid adding "hacks").

I haven't tested (as I'm currently not connected to an external screen), but I guess that the "resize" event may be helpful there?

I haven't tested (as I'm currently not connected to an external screen), but I guess that the "resize" event may be helpful there?

Well, we already have a "resize" event listener in the default viewer so apparently that's not enough as-is; note https://github.com/mozilla/pdf.js/blob/2194fb940dac25b3da799474a1e2a9ceb63ab18a/web/app.js#L2698-L2713

Based on some quick web searches, there doesn't appear to exist any DOM method which can be used to determine (with certainty) if a window is moved from one screen to another; closing as WONTFIX for now.


GoogleDocsReader - Request contains an invalid argument

I'm trying to implement the GoogleDocsReader following the instructions here.
from llama_index import GPTSimpleVectorIndex, download_loader

GoogleDocsReader = download_loader('GoogleDocsReader')

gdoc_ids = ['1wf-y2pd9C878Oh-FmLH7Q_BQkljdm6TQal-c1pUfrec'] # I've substituted my google doc id in my code
loader = GoogleDocsReader()
documents = loader.load_data(document_ids=gdoc_ids)
index = GPTSimpleVectorIndex(documents)
index.query('Where did the author go to school?')

I managed to get auth working using the oauth2 flow and have a token.json file
Quick aside - had to set the port to any fixed value from 0 so I could setup the redirect_url, otherwise it would randomly pick the port and I'd get a mismatch url.
The bigger issue is now that I'm authenticated, enabled the GoogleDocs Api in GCP, and go to run the script.
INFO:googleapiclient.discovery_cache:file_cache is only supported with oauth2client<4.0.0
Traceback (most recent call last):
  File "~/gpt_docs/index.py", line 11, in <module>
    documents = loader.load_data(document_ids=gdoc_ids)
  File "~/Library/Application Support/pdm/venv/lib/python3.9/site-packages/llama_index/readers/llamahub_modules/google_docs/base.py", line 45, in load_data
    doc = self._load_doc(document_id)
  File "~/Library/Application Support/pdm/venv/lib/python3.9/site-packages/llama_index/readers/llamahub_modules/google_docs/base.py", line 62, in _load_doc
    doc = docs_service.documents().get(documentId=document_id).execute()
  File "~/Library/Application Support/pdm/venv/lib/python3.9/site-packages/googleapiclient/_helpers.py", line 130, in positional_wrapper
    return wrapped(*args, **kwargs)
  File "~/Library/Application Support/pdm/venv/lib/python3.9/site-packages/googleapiclient/http.py", line 938, in execute
    raise HttpError(resp, content, uri=self.uri)
googleapiclient.errors.HttpError: <HttpError 400 when requesting https://docs.googleapis.com/v1/documents/<REDACTED>?alt=json returned "Request contains an invalid argument.". Details: "Request contains an invalid argument.">

excerpt from pyproject.toml
dependencies = [
    "llama-index>=0.4.29",
    "openai>=0.27.2",
    "google-api-python-client>=2.81.0",
    "google-auth-httplib2>=0.1.0",
    "google-auth-oauthlib>=1.0.0",
]

Is this a package issue or am I missing something obvious. Thanks!

Ugh...I figured it out. I was using a the Google Docs folder id, assuming it would pull in all documents. When I changed the id to a document id the errors have resolved.


Expo 35 not working with v0.5.3 on Android

I get the following error
Encountered an error loading page, Object {
  "canGoBack": false,
  "canGoForward": false,
  "code": -1,
  "description": "net::ERR_ACCESS_DENIED",
  "loading": false,
  "target": 2305,
  "title": "",
  "url": "file:///data/user/0/host.exp.exponent/cache/ExperienceData/%2540trinet%252Fmobilev7/index.html",
}

Please refer to this expo snack https://snack.expo.io/@trinet/rn-pdf-reader-js

Duplicate issue #81


refactor: asynchronous serialization and parsing

With this PR, parsing and serializing CCs, as well as serializing messages is now done asynchronously. For this purpose, new async variants parseAsync, fromAsync, serializeAsync and mergePartialCCsAsync have been added.
For backwards compatibility, the synchronous versions of .parse(), .from(), .serialize(), .mergePartialCCs() will be kept around until the next major release, after which the ...Async versions will take their place.
This change allows using asynchronous APIs while parsing and serializing, e.g. the portable WebCrypto API as a replacement for node:crypto.

@zwave-js-bot automerge


Itch.io compatibility

Itch.io allows for embedding html5 games. However, when I convert my gamejam-project and upload it there are issues.

The viewport is much smaller than it should be (should be 1024x768)
The game does not receive keyboard input (maybe related to this? https://github.com/itchio/itch.io/issues/58)

It would be nice if love.js was compatible with itch.io.

Most likely due to styles or constraints of the itch layout

Does it take inputs when you click the game itself and then press a key? If it is iframe'd, this is to be expected - it's how the browser works.

OK, the viewport stuff was my mistake. I found the viewport (iframe) settings and set it to 1280x1024, which works fine for this 1024x768 game+text blurb on top. The confusing part here was that the 'edit game' page changes depending on what you have selected in a dropdown on this page. I simply missed the 'embed options' that showed up after selecting 'HTML project'.
The input however seems broken. Mouse clicks work, but it does not get keyboard focus.
I made a test project on itch.io: https://murks.itch.io/cookiest-lovejs-test

Keyboard works for me if you click inside the iframe first to give it focus. Nothing I can reliably do about that, though. There are ways to set focus on the canvas element with some JavaScript on the page but that's not something that should be happening at the framework level.

It did not work for me in either Firefox or Chrome (both on Linux).
A click on buttons works, keyboard, even after the clicks, does not.

Click inside the iframe but outside the canvas.

Ok, thanks, that works, but it is certainly unexpected behaviour from a user perspective. The canvas is inside the iframe after all.

I appreciate where you're coming from but it's outside of my control. Like I said, you can probably get it working with some JS specific to that page setup but it can't be easily generalized to every situation.

Ok, thanks. I'm just not familiar enough with JS and browser input specifics to fix this myself.

OK, I hacked in a window.focus(), which seems to have done the trick. It's probably not the best place to put it, but I added it at the end of the Module thing.
      var Module = {
        buffer: new ArrayBuffer(32*1024*1024*2),
        TOTAL_MEMORY: 32*1024*1024*2,
	arguments: ['./'],
...
        monitorRunDependencies: function(left) {
          this.remainingDependencies = left;
          this.totalDependencies = Math.max(this.totalDependencies, left);
          Module.setStatus(left ? 'Preparing... (' + (this.totalDependencies-left) + '/' + this.totalDependencies + ')' : 'All downloads complete.');
          window.focus();
        }
      };


Add file response type or the response headers to blob

Describe the feature
File downloading can parse a filename from the response header 'content-disposition'. As I see there is no way neither to get response headers nor the filenames.
It may be also extra parameter for .then(($blob, $headers) => {})
Not sure if it will work as
async onResponse({ request, response, options }) {
console.log("[fetch response]", response, JSON.stringify(response.headers))
},
shows no headers at all.
Additional information

[ ] Would you be willing to help implement this feature?

+1

+1 any workaround?
I have tried using $fetch.raw but without success, headers are empty

ofetch.raw also returns a response with empty headers {}

It is not a library. New security features from browsers. I do not think it may be possible to make a fix.

response.headers.get('content-disposition')


Document upgrade steps

Hello,
I am having trouble finding clear instructions for the upgrade process when SAS Viya is installed using this repo. I saw issue #135 that is related to this, but the issue is ~2 years old and mentions that the deployment operator had not yet been integrated. To my knowledge, the deployment operator is now integrated with this repo.
Therefore, is it intended that we'd follow the Using the Deployment Operator upgrade steps? If so, I believe we'd have to follow Option 2 of creating and applying the SASDeployment Custom Resource, since I don't believe that was generated on the initial deployment using this repo.
Or, are we able to just supply the new deployment assets and re-run the original docker run command with the viya,install tags? [1]
It would be helpful if this repo could document if it is only meant to initially deploy SAS Viya, or if it can be used for upgrades as well. And in either case, either directly documenting in this repo or pointing to SAS docs how those upgrades should be performed. In the meantime, hoping I can get some clarification on the recommended upgrade process. Thanks!
[1] DockerUsage readme

The link that you reference contains the Best Practices and Guidelines for updating as well as the different methods that can be used to update to a new version. Each method has its own set of steps. This section  in the viya4-deployment README also has some additional advice and it references the link to the manual update instructions that you referenced above.

Thanks for the responses here!
Just wanted to close out this loop with how we've implemented our initial deployments and upgrades (using the deployment operator method). We perform the initial deployment using this repo. To upgrade, we perform any prep tasks (e.g. reading release notes, making any changes to config files, downloading new deployment assets and images, etc). Then we redeploy the deployment operator (technically this isn't required for every upgrade, but we do so anyways to ensure we have the latest version of the deployment operator), we create the SASDeployment Custom Resource, and then apply it.
I think this can be closed out from my perspective!


Fix the stability of SAML integ test

Signed-off-by: Ryan Liang<EMAIL_ADDRESS>Description
Fix the stability of SAML integ test
Category
Enhancement
Issues Resolved

Related #1228

Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List

[ ] ~New functionality includes testing~
[ ] ~New functionality has been documented~
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Any updates for this PR, or anything we can help with?

Any updates for this PR, or anything we can help with?

Hi @peternied I was working with @scrawfor99 for the windows support for CI. This one I may need the help from @anijain-Amazon . Since he is the author of the original SAML integ test.

Codecov Report

Merging #1237 (6b31de1) into main (9dab522) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1237   +/-   ##
=======================================
  Coverage   71.78%   71.78%
=======================================
  Files          88       88
  Lines        2027     2027
  Branches      269      269
=======================================
  Hits         1455     1455
  Misses        509      509
  Partials       63       63

Impacted Files
Coverage Δ

public/apps/configuration/constants.tsx
85.71% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RyanL1997 Looks like both CI checks failed due to same reason: jarHell. Can you look into it and let us know if you need any help?


Improvements in Logging

There are gaps in our logging infrastructure that need to be addressed. I am opening this issue to list down those gaps:

[ ] We send our qemu logs to a file called qemu.log under /var/run/vc. However this file is always empty. It is essential that we capture logs from the hypervisor. We need to check and implement this for other hypervisors - firecracker and cloud-hypervisor as well.
[ ] We can use a console to log in to the virtual machine. However when the console is used, logs from the agent and the VM are no longer sent to the journal. This could potentially be solved by having another console socket passed to the hypervisor.
[ ] If the agent/VM/hypervisor crashes, all logs are potentially lost. We need to make sure that logs are available in all cases.

cc @gnawux @jodh-intel @bergwolf @jcvenegas @devimc

Hi! @tommyrousey, @maomarcus, and @yasv123 and I are students at UT Austin, and we're looking to make some open source contributions over the course of the rest of the year as a part of our virtualization class. Could we be assigned to this issue?

@bporter816 thanks, assigning this to you

@bporter816 are you working on this issue or should we assign it to someone else?

Yes, we plan to complete this soon.

@amshinde @devimc We're gotten around to looking at this, and wanted to make sure we understand the relevant parts of the logging system to work on the issue. We're able to reproduce the qemu.log file being empty while running a container, and we're looking at the console socket at console.sock to try to understand how that works. One of the things we were wondering about is how to use a console to log into the virtual machine and generally how to interact with the console socket.
Would either of you or someone else be able to connect with us on Zoom sometime soon to walk us through this?
Thanks!

@bporter816 not too much to say about qemu.log and console.sock.  I have no idea why qemu.log is empty, I tried with --enable-debug but didn't work, @kata-containers/redhat any thoughts ?
Regarding to console.sock, the implementation of a new debug console shouldn't be a big deal, just add another virtconsole-socket pair (-device virtconsole,chardev=charconsole1,id=console1 -chardev socket,id=charconsole1,path=debug-console.sock,server,nowait) and somehow connect the vport in guest (/dev/vport1p0) with the bash process, take a look to the following chunk of code
https://github.com/kata-containers/agent/blob/25d74717af5a232fccb5f6e79df8f2e3a37be255/agent.go#L1424-L1433

@amshinde @devimc We've dug into this some more and we believe that the qemu.log file is intended for severe QEMU issues such as virtual hardware errors. In most cases, this file is empty in our research. For example, we ran a plain qemu command with the -D qemu.log option outside of kata on a VM that successfully booted, and qemu.log was empty, even with all -d debug options enabled.
We were able to interact with the qmp.sock socket to capture events from the container such as when it was shutting down. This is a part of the QAPI provided by QEMU. These events also showed up in the standard runtime.log messages. Here's an example:
time="2020-11-30T22:41:55.88039594-06:00" level=info msg="{\"timestamp\": {\"seconds\":<PHONE_NUMBER>, \"microseconds\": 880098}, \"event\": \"SHUTDOWN\", \"data\": {\"guest\": false, \"reason\": \"host-qmp-quit\"}}" arch=amd64 command=delete container=eb35ee2f446e9ea4bbec3555c354167c22be0d933c1bfb2526b01e87fda55031 name=kata-runtime pid=19678 sandbox=eb35ee2f446e9ea4bbec3555c354167c22be0d933c1bfb2526b01e87fda55031 source=virtcontainers subsystem=qmp

We were wondering what types of logs you are looking for from qemu.log - are they only meant to report low level QEMU errors, and should the file thus usually be empty?

Hi @amshinde @devimc @bporter816,
I found an example of a qemu.log file in another ticket after reproducing the issue and finding the qemu.log empty with both Kata and a vanilla VM. This example found on issue https://github.com/kata-containers/runtime/issues/2978:
# cat qemu.log
warning: Opening a block device as a file using the 'file' driver is deprecated
warning: Opening a block device as a file using the 'file' driver is deprecated
warning: Opening a block device as a file using the 'file' driver is deprecated
qemu-virtiofs-system-x86_64: VirtFS reply type 117 needs 14 bytes, buffer has 14, less than minimum

Also, from the QEMU documentation:
-D logfile
Output log in logfile instead of to stderr

I believe this supports @bporter816 's hypothesis that this is only for logging virtual hardware errors with the output usually going to stderr.
I also am also a bit confused on how the console was support to produce information similar to this. If this indeed not what is intended to be logged in qemu.log, what should then be logged using the console? Any clarification is helpful!

@tommyrousey @bporter816

I believe this supports @bporter816 's hypothesis that this is only for logging virtual hardware errors with the output usually going to stderr.

Ok, sounds like you got it, could you raise a pull request to fix/update the documentation?  thanks
https://github.com/kata-containers/runtime/blob/3f92a9c076f3e8e52ec1d54a0c7068f6c8d24e8a/cli/config/configuration-qemu.toml.in#L250-L255
https://github.com/kata-containers/runtime/blob/3f92a9c076f3e8e52ec1d54a0c7068f6c8d24e8a/cli/config/configuration-qemu-virtiofs.toml.in#L243-L248

@amshinde We were wondering what sorts of logs are missing from the journal, in order to help us reproduce the second part of this issue. What's a good way to induce a log that would get captured by the console and not show up in the journal? And how would the introduction of a second console solve the issue? What does that change?

Hi @bporter816, you can take a look at the logs expected to be generated by following this:
https://github.com/kata-containers/documentation/blob/master/Developer-Guide.md#enable-full-debug
For example, after turning on debug for the agent, you may either see this log : "Serial channel type detected" or "Vsock channel type detected" in the journal.
(Have a look at the agentLog calls in the agent to see other log statements. for eg : https://github.com/kata-containers/agent/blob/f9eab0fe9adb34e4f9f4a11f42a3eff983fd0659/channel.go#L102)
Once you start a debug console, you should still be able to see those logs in the journal. I hope it is clearer now.

@amshinde @devimc @cmaf Looking for some context - we found the code in the runtime that sets up the connection with the agent via the proxy and shim:
https://github.com/kata-containers/runtime/blob/df055c8d506fe6e4d41a64d903d8c3fdf3d02592/virtcontainers/kata_agent.go#L743-L746 and https://github.com/kata-containers/runtime/blob/df055c8d506fe6e4d41a64d903d8c3fdf3d02592/virtcontainers/kata_agent.go#L1512-L1522
The logic for allowing messages to reach the system journal appears to be gated by checking if the debug console is enabled in the kernel params. Would it be sufficient to remove this part of these conditionals, or is there something else that requires the addition of a second console?

@bporter816 If you already implemented the function where the second  console-socket pair is attached to the hypervisor

We can use a console to log in to the virtual machine. However when the console is used, logs from the agent and the VM are no longer sent to the journal. This could potentially be solved by having another console socket passed to the hypervisor.

https://github.com/kata-containers/runtime/issues/2650#issuecomment-735894256

then yes, you should change that conditions

@bporter816 If you already implemented the function where the second  console-socket pair is attached to the hypervisor

We can use a console to log in to the virtual machine. However when the console is used, logs from the agent and the VM are no longer sent to the journal. This could potentially be solved by having another console socket passed to the hypervisor.

https://github.com/kata-containers/runtime/issues/2650#issuecomment-735894256

then yes, you should change that conditions

@devimc We spent a while on this and weren't able to get it working so we'll leave it to someone with more expertise on the repo.

@devimc We spent a while on this and weren't able to get it working so we'll leave it to someone with more expertise on the repo.


Make environment file compatible with Dash shell (default shell on Ubuntu)

The environment file works nicely when using bash, but when I use the dash shell (which is my /bin/sh by default on my Ubuntu 18.04) I got the following error:
./environment: 17: ./environment: [[: not found
So, this merge request fixes that issue and still works properly with bash.

thanks


Investigate & Eliminate Lag with Default Twitter Site

Hope this is worth looking into;
I experience pretty intense lag on both my desktop (powerful gaming pc) and my laptop (macbook air) after having the site open for a couple of minutes (with & without this extension installed) it slowly becomes unusable due to the sheer amount of lag between actions, specifically scrolling, liking tweets, videos lagging, etc. Taking a look into Chrome's Task Manager i've found, whilst having multiple tabs open, Twitter has both the highest CPU usage and most memory usage of all of my tabs open.
I'd greatly appreciate if this could be looked into, as it would certainly make the site alot more usable to people who experience the same issue as I. Thanks a bunch!

For anyone wanting to look into this. Try using the "Performance" tab in Dev Tools.

Here are a couple of screenshots from the performance tab:

The content.js in the last image is from refined-twitter.
This is the minified code of the first one:
const f = (new (n.n(l).a)).getAll()
      , d = async({fn: e, id: t=e.name})=>{
        u || (u = await f);
        const {logging: n=!1} = u
          , r = n ? console.log : ()=>{}
          , a = t.replace(/_/g, "-");
        if (/^$|^anonymous$/.test(a))
            console.warn("This feature is nameless", e);
        else if (!1 === u[a])
            return $("html").removeClass(a),
            void r("↩", "Skipping", a);
        try {
            $("html").addClass(a),
            await e(),
            r("✅", a)
        } catch (e) {
            console.log("❌", a),
            console.error(e)
        }
    }

And this is the second one:
()=>{
  Object(i.b)(o.b.codeHighlight),
  Object(i.b)(o.b.mentionHighlight),
  Object(i.b)(o.b.inlineInstagramPhotos),
  Object(i.b)(o.b.renderInlineCode),
  Object(i.b)(o.b.imageAlternatives),
  Object(i.b)(o.b.hideRetweetButtons)
}

I haven't looked deeply enough to see why these are slow, but I thought I'd at least log my findings here. These were the top two function calls in terms of total execution time.

Closing as this extension is now deprecated: https://github.com/sindresorhus/refined-twitter/commit/8dd9df749d3a4e82c95b2bd6628c8d65f0f72e6c


Finalize SSR & JS API

Background
We've been doing a lot of work to support the Snowpack SSR story over the last couple of weeks, and at this point are in a pretty good spot. This issue serves to document the last known work needed before we can consider this work "done" and can remove the __unstable prefix from our new JS API.
Work Needed

[x] Need a way to detect if you are in browser or Node.js: This should probably be something like import.meta.env.CLIENT or import.meta.env.ENVIRONMENT. We already have ``import.meta.env.MODE` for "development" vs. "production".
[x] requestHandler() should return errors: Right now, this middleware only calls next() on a 404. Instead, we should call next(err) with an error so that it can be handled as needed by the integrator. Currently, we'll just handle the 500 silently.
[x] Refactor out the "server" from the JS API (as much as possible):  Currently, loadByUrl() is literally making an HTTP request to localhost behind the scenes. We have all the tools to make this call via JS instead, and not have to deal with serializing success/errors over HTTP. Lets remove as much of the "HTTP" logic from our JS API, and just make direct function calls instead.
[x] Document new JS API
[x] Document SSR Story (for both dev & build) and anything else mentioned above

Nice to Have

[ ] Figure out SSR story for ESM loading in Node.js: Svelte team is using a special ESM loader for Node.js, that loads files by URL into Node.js. It's dark magic, but it works impressively well. Pull this into it's own package or pull this into Snowpack itself.
[x] Easier --ssr builds?: Right now, a Snowpack SSR build is something that needs to be run in addition to a non-SSR run. Basically, you end up having to do this yourself on every build: snowpack build --out build/client && snowpack build --ssr --out build/server. Instead, in --ssr mode, it can be assumed that you always want both. I don't believe that we have a current use-case where you only want one, although we could certainly add --ssr-only for those few weirdos :)

Open question: how much does this blow out our config surface area? What extra config is needed? If possible, I'd really like to be a sensible default and then use --ssr-only if you really need to configure stuff yourself.

[x] Finalize experiment.middleware: Related to SSR is the idea of connecting some server.js file to your final build. We already have the ability to pass a custom server to Snowpack via experiment.middleware. If possible, I'd like to explore the idea of giving Snowpack an entrypoint file/plugin, and having it automatically create a build/server.js file that can be automatically run for SSR. Not blocking this larger issue, but I'd love to do some more exploration here.
anything else?

👀

Figure out SSR story for ESM loading in Node.js: Svelte team is using a special ESM loader for Node.js, that loads files by URL into Node.js. It's dark magic, but it works impressively well. Pull this into it's own package or pull this into Snowpack itself.

Is there more information about this that I can find somewhere?

I'm not sure what their plans are to share the beta @svelte/kit repo, but hopefully its open sourced soon!

@Rich-Harris I'm planning to close out this issue as a part of v3.0 release, and had two questions for you:

SvelteKit's loader: are you happy with the import rewriting you have built on top of meriyah ? Would it help to output CJS instead of ESM in SSR mode? It would be more difficult to scan/rewrite imports, but the thinking is that instead of rewriting imports you could pass in your own require() function connected directly to sp.loadUrl
--ssr output: just confirming that we're planning to go forward with changing snowpack build --ssr to create two outputs at the same time: build/client and build/server. This should let us run both builds in parallel and share resources across both, giving a nice speed boost. snowpack build --ssr-only (or something similar) will be added to match current behavior of server-only SSR output.

This is cool!

Would it help to output CJS instead of ESM in SSR mode?

I don't think so, no:

Every Snowpack transformer plugin would need to be able to emit CJS in addition to ESM, or Snowpack would need to apply an additional transformation from ESM to CJS (which would be equivalent to the transformation currently happening inside the runtime) just in case it was to be consumed by the runtime (as opposed to e.g. a bundler, which would rather have ESM)
In order to implement live bindings, that transformation would have to be rather bloaty
I'm not entirely convinced it's even possible? A function call would need to return synchronously (unless we did some real dark magic), but module loading is generally going to be async

Yea I'm definitely only thinking about scoping this to static build output & a post-build transform so that plugins don't need to worry about it. Maybe a better way to frame this would be an opt-in buildOptions.format: "esm" | "cjs" option.
We could also just ship this as a plugin to start, something like this (just a wip for now) and then see if people want it built-in: https://github.com/snowpackjs/snowpack/commit/9f7da17939c0f4483987e206401bea2901b85f77#diff-1abfc525c64c76b319e3c8a5c3ff8df1b345e67cefa274f5a0230bcf9ea9fff8R6


Incorrect shadow applied on Drawer

Describe the bug
The shadow on the Drawer component does not match the design in Figma. We have a single box shadow defined currently:
What is the expected behavior?
Component should be using the styles for 4dp shadow (elevation = 4). These should be coming from the mat-elevation class or mixin, which includes a blend of box shadows
What are the steps to reproduce?

Go to...
Click on...

Screenshots or links to minimum reproduction example
Current definition:

Should look more like:

but with the correct black[500] color.
Currently:

Should look like:

Anything else to add?
This is probably something that needs to be adjusted in the component library and the theme (to get the right colors).

#210 fixes this.

#210 fixes this.


Retry when a request failed

The same with https://github.com/launchableinc/nose-launchable/pull/44 and change it to retry requests when it fails.

Thank you!

What is the context driving this change, @shuheiktgw?

First, it is a pretty common practice to retry requests a few times when it fails. Second, our API is still not fully reliable and returns 5xx (even though it becomes pretty rare recently) so I want our clients to retry requests to increase reliability!

Great, makes sense 👍 Thanks for driving this change


glscopeclient Fullscreen issue with dialog box

How to reproduced the issue (tested on Windows 7 Pro 64bits):

Launch glscopeclient and choose Fullscreen option
if you go to Help=>About... or File=>Open... or any Dialog box
The dialog box is displayed in background and so it is not visible and not usable..

This issue has been reproduced with Windows build https://github.com/azonenberg/scopehal-apps/commit/65879714bcbd51145448cc16e3437474d651248e but I suspect it can be reproduced also on Linux to be confirmed

To be checked if this hint https://stackoverflow.com/questions/11865150/let-a-window-display-above-a-fullscreen-window-in-gtk is applicable and fix the issue

Fullscreen works fine for me on Debian with XFWM4 and the current glscopeclient revision, but was a source of lots of problems with popup dialogs in the past. I'm not surprised to hear it fails on other platforms.


Multileg

add support for the bare strong-coupling expansion

Codecov Report

Merging #29 (c85be1b) into master (9029745) will decrease coverage by 3.23%.
The diff coverage is 17.36%.

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   61.55%   58.31%   -3.24%
==========================================
  Files          29       32       +3
  Lines        1904     2032     +128
==========================================
+ Hits         1172     1185      +13
- Misses        732      847     +115

Impacted Files
Coverage Δ

src/FeynmanDiagram.jl
41.66% <ø> (ø)

src/diagram_tree/DiagTree.jl
0.00% <ø> (ø)

src/diagram_tree/common.jl
55.55% <ø> (ø)

src/diagram_tree/traits.jl
37.17% <0.00%> (-30.27%)
:arrow_down:

src/expression_tree/io.jl
0.00% <0.00%> (ø)

src/strong_coupling_expansion_builder/Gc.jl
0.00% <0.00%> (ø)

src/strong_coupling_expansion_builder/Gn.jl
0.00% <0.00%> (ø)

src/strong_coupling_expansion_builder/common.jl
0.00% <0.00%> (ø)

src/expression_tree/build.jl
78.94% <55.55%> (-8.56%)
:arrow_down:

src/diagram_tree/optimize.jl
94.80% <73.33%> (-5.20%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9029745...c85be1b. Read the comment docs.


AlgoWorld Auction contracts

Description

Please explain the changes you made here

Renames the repo from algoworld-swapper to algoworld-contracts. AlgoWorld Swapper will be a new repo that will host a frontend separated from algoworldexplorer.
Adds stateful openNFT smart contracts (with TEAL bumped from 2 to 6) that are currently used on algoworldexplorer for trading functionality.
Adds a comprehensive single unit test that covers various scenarios of interactions with the auction contracts.

Once merged - I will rename the repo from algoworld-swapper to algoworld-contracts

Checklist

Please, make sure to comply with the checklist below before expecting review

[x] Code compiles correctly
[x] Created tests which fail without the change (if possible)
[x] All tests passing
[x] Extended the README / documentation, if necessary

just fyi @cusma ill be merging this in the coming days due to time constraints, but feel free to refer to the closed pr to provide any further feedback if you'll have any (will address it separately)


Refactor parameters to use OrderdedDictionary swift-collections

OrderedDictionary from https://swift.org/blog/swift-collections/ ensures order while allowing us to change any parameter

This sounds good. Can we encounter any flags that don't require a value?
I.e. for xcodebuild, from what I understand, it is possible to pass build flags using setting=value, which doesn't follow the normal -key value argument format. There are probably more examples like this. So I guess users won't be able to set values using a dictionary like this. For xcodebuild, we could expose another (ordered) dictionary for build settings to pass in the format of setting=value after the (build|test|archive|build-for-testing|test-without-building)

There can be some variants
-key value
-- key value
key=value
just_key
-key=value

That's why I changed from initial DIctionary to Array as for now. Maybe we can just use OrderedSet or just Set


Improve callstacks when using the dynamic error effect

When using throwError from Effectful.Error.Dynamic the call site of interest is buried under 4 lines of internal implementation details:
> Left (cs,_) <- runEff $ runError @() $ throwError ()
> putStrLn $ prettyCallStack cs
CallStack (from HasCallStack):
  throwError, called at src/Effectful/Error/Dynamic.hs:43:21 in effectful-core-<IP_ADDRESS>-1rwlVbEDo1s77mEaNtxUZU:Effectful.Error.Dynamic
  handler, called at src/Effectful/Dispatch/Dynamic.hs:371:50 in effectful-core-<IP_ADDRESS>-1rwlVbEDo1s77mEaNtxUZU:Effectful.Dispatch.Dynamic
  handle, called at src/Effectful/Internal/Monad.hs:410:10 in effectful-core-<IP_ADDRESS>-1rwlVbEDo1s77mEaNtxUZU:Effectful.Internal.Monad
  send, called at src/Effectful/Error/Dynamic.hs:60:14 in effectful-core-<IP_ADDRESS>-1rwlVbEDo1s77mEaNtxUZU:Effectful.Error.Dynamic
  throwError, called at <interactive>:1:48 in interactive:Ghci1

We can fix this by making the CallStack an explicit event argument, then:
> Left (cs,_) <- runEff $ runError @() $ throwError ()
> putStrLn $ prettyCallStack cs
CallStack (from HasCallStack):
  throwError, called at <interactive>:12:48 in interactive:Ghci7

This matches the behaviour of Effectful.Error.Static.

Hmm. Why not
diff --git a/effectful-core/src/Effectful/Error/Dynamic.hs b/effectful-core/src/Effectful/Error/Dynamic.hs
index 59080de..782f098 100644
--- a/effectful-core/src/Effectful/Error/Dynamic.hs
+++ b/effectful-core/src/Effectful/Error/Dynamic.hs
@@ -24,6 +24,8 @@ module Effectful.Error.Dynamic
   , E.prettyCallStack
   ) where

+import GHC.Stack (withFrozenCallStack)
+
 import Effectful
 import Effectful.Dispatch.Dynamic
 import qualified Effectful.Error.Static as E
@@ -57,7 +59,7 @@ throwError
   => e
   -- ^ The error.
   -> Eff es a
-throwError = send . ThrowError
+throwError e = withFrozenCallStack (send $ ThrowError e)

 -- | Handle an error of type<EMAIL_ADDRESS> catchError

instead?
Also, I wonder if this makes sense in general. Maybe there are situations in which it's good to know what exactly throws in the current implementation of ThrowError?

Oh, I didn't know about frozen call stacks -- that's a much simpler solution! I'm away from my PC today so I'll close this for now. If you don't I'll create a PR with your proposed diff next week.
As to why this is useful at all, I'm not sure why anyone would use the dynamic error effect in the first place but I do believe that they wouldn't expect to see 4 lines of internals in their stack traces.

Fair enough. I've added this in c99d1bdfae12dc3c3fee43aeea3ad49268fbbeac.


Approx z z0

Codecov Report

Merging #24 (b2cd570) into main (386cad0) will decrease coverage by 0.99%.
The diff coverage is 49.50%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   48.71%   47.72%   -1.00%
==========================================
  Files          16       16
  Lines        1170     1253      +83
==========================================
+ Hits          570      598      +28
- Misses        600      655      +55

Impacted Files
Coverage Δ

...dels/Diffusion Approximation/DAcylinder_layered.jl
80.64% <40.69%> (-18.86%)
:arrow_down:

...Diffusion Approximation/Semi-infinite/DAsemiinf.jl
69.84% <100.00%> (-0.85%)
:arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Use checked bytes pool to add raw buffer read/write guarantees

cc @xichen2020 @kobolog @martin-mao @cw9

Coverage increased (+0.02%) to 77.203% when pulling 1d9b502f319c3e76c9e54a00093190cedacc68a8 on checked-pooling into d86fc9edbf93a73725685641ad60ecb361c6d110 on master.

Coverage increased (+0.08%) to 77.257% when pulling 7c4fe8822f3f1272281f07a1fcead7f0d6af0f62 on checked-pooling into d86fc9edbf93a73725685641ad60ecb361c6d110 on master.

@xichen2020 this is ready for review when you get a chance.  Muchos gracias.

Coverage increased (+0.08%) to 77.257% when pulling 6adf915e6ba9e9ba9d305d450ea26fa2e5e7588a on checked-pooling into d86fc9edbf93a73725685641ad60ecb361c6d110 on master.

Coverage increased (+0.09%) to 77.254% when pulling<PHONE_NUMBER>6f345a554d56886315788fc91776ee on checked-pooling into f17fb3ab654b3276843d5f9f1719f8135c3b0c95 on master.

Coverage decreased (-0.09%) to 77.073% when pulling 394cab1866549cfbecded05d8f292ee0eee31cc0 on checked-pooling into f17fb3ab654b3276843d5f9f1719f8135c3b0c95 on master.

Coverage increased (+0.06%) to 77.22% when pulling 19056edf4515cad419f929f37d8a836811898272 on checked-pooling into f17fb3ab654b3276843d5f9f1719f8135c3b0c95 on master.

Coverage increased (+0.02%) to 77.185% when pulling ef482751e689d52043a84294e20f263246c6610a on checked-pooling into f17fb3ab654b3276843d5f9f1719f8135c3b0c95 on master.

Coverage decreased (-0.08%) to 77.85% when pulling e00eaddd425385d8f0890c97f9458dbcbebb2fde on checked-pooling into aee5aafd5cf620805f12a11f08ee2059338e01b1 on master.

Coverage decreased (-0.08%) to 77.852% when pulling 7796c3e772ce742a6d8bd36b7936e4b3a2c3288b on checked-pooling into aee5aafd5cf620805f12a11f08ee2059338e01b1 on master.

Coverage decreased (-0.06%) to 77.865% when pulling 7796c3e772ce742a6d8bd36b7936e4b3a2c3288b on checked-pooling into aee5aafd5cf620805f12a11f08ee2059338e01b1 on master.

Coverage decreased (-0.1%) to 77.801% when pulling 871adc3c6724f949873bf6605e526505ad5b410a on checked-pooling into aee5aafd5cf620805f12a11f08ee2059338e01b1 on master.


Add additional TFM to reduce dependencies

Is your feature request related to a problem? Please describe.
I want to minimise dependencies in my project by utilising framework dependencies wherever possible
Describe the solution you'd like
Packages should not have any dependency which can be provided by the framework and if necessary additional frameworks should be added.
Describe alternatives you've considered
Accept the additional dependency
Additional context
n/a
packages impacted

NLog.WindowsRegistry

packages to be reviewed

NLog.WindowsEventLog
NLog.WindowsIdentity
NLog.Wcf
NLog.PerformanceCounter

Pull-request are always wellcome.
But it seems to be a crazy game to chase net6,net7,net8,net9 instead of just depending on netstandard2 :)

I am not a fan of chasing all TFM'S just interested in one's where there is a benefit ie new feature or a needed dependency gets included in the framework.

But yes I will submit or for it.

Well you cannot choose one TFM as they frequently expire, so it will become an ongoing chase to stay away from unsecure packages.
Suddenly one cannot use a nuget-package because it points to a TFM that is no longer installed on the docker-image.

I think you have missed my point, what I am proposing is to add an additional TFM ie net 5/6 to the mentioned projects so that there is less dependencies for that framework just like has been done for https://www.nuget.org/packages/NLog.Web.AspNetCore.

just like has been done for https://www.nuget.org/packages/NLog.Web.AspNetCore.

My comments comes directly from my experience with maintaining NLog.Web.AspNetCore (And other NLog-projects). There Microsoft is forcing one to ride the NET-train (Ex. NET5 is now obsolete, NET7 becomes obsolete this summer. NET6 becomes obsolete this winter, etc.). Hopefully one day a NLog-maintainer will arrive that loves to tweak build-pipelines, but I have little interest besides keeping the work to a minimum.
For my own personal stuff then I only use one NET-target, and I can move when I feel like it. But when maintaining a shared-library, then suddenly one have to cater for a huge user-base. It is ofcourse interesting to learn the ups and downs of open-source-development for a widely used project. But it also a lot of baggage coming from keeping everyone happy, so they get their exaxt personal wishes.

Closing as work continues here: https://github.com/NLog/NLog.WindowsIdentity/pull/10


Update dependencies

Checklist

[x] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[x] Tests are passing
[ ] Docs have been updated (if applicable)
[x] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

Hello @connyduck,
sorry for the delay. Took a while until I caught up after Christmas break.
I need to check that Java 8+ is still supported. Did you have any particular reason for the update?

Hello @connyduck,
sorry for the delay. Took a while until I caught up after Christmas break.
I need to check that Java 8+ is still supported. Did you have any particular reason for the update?

No particular reason, just noticed when upgrading my own dependencies that yours are out of date as well

No particular reason, just noticed when upgrading my own dependencies that yours are out of date as well


GHA: Run unit tests in CI

Run unit tests in CI using Windows and Linux runners. This will help us detect compilation and runtime issues early on.

@bitsandfoxes @bruno-garcia
Good to merge? It's still waiting for approval.


Update dashboard Kubernetes / Views / Namespaces ( 39 → 40 )

This PR contains the following updates:

Package
Update
Change

Kubernetes / Views / Namespaces
major
39 -> 40

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Hi CPU on Synology DS718+

Hi
I am running deconz on a synology DS718+, the container is consuming around 25% CPU which seems a lot. My other containers are all averaging around 0.2 - 0.5% (home assistant, unifi controller, plex etc)
Is this normal, I don't remember it being so high on previous versions. Currently running 2.05.75, if its abnormal any suggestions on root cause?
Thanks for all your work, by the way!

I usually realise high CPU usage when I have LQI signal strength enabled via VNC. Maybe you are as well? Turning that off puts CPU usage back to normal.


Bug(Server): Wrong method call on server

It calls blaze3d render method on server so it causes to crash immediately.

crash report?

https://mclo.gs/m5adv6X
Also one more detail: it happens when I try to use Physgun. The mod itself gets loaded fine and stays calm until this happens.

huh, it shouldn't happen

ok i see what i did wrong. going to fix is soon


Don't roundtrip through Value to deserialize

I'd like to find a generic Deserialize interface (a-la serde) that drives the building of structs, etc. so we don't pay the price of, e.g., first building HashMaps when deserializing JSON structs.

Close by #75, most definitely


line graph is not showing da data i am giving it

Hi there!
I've coded a while with your Chart.js plugin to show data in my Graph, but I got an error, I cannot explain.
After I draw my graph, I printed out my Canvas.data json Element:
datasets: [
	{
		backgroundColor: "rgba(255, 99, 132, 0.2)"
		borderColor: "rgba(255, 99, 132, 1)"
		borderWidth: 1
		data: [ 1000, 200000, 20000 ]
		label: "Ah Price for ancient_debris"

		labels: [
			"18.11.2020  20:49",
			"21.11.2020  12:31",
			"23.11.2020  23:25"
		]
	}
]

But the graph looks like this:

My issue is, that the first point is drawn at 0/0 and not at 0/1000

What have I done wrong?
Would be nice, if I could get an answer soon!

Lables is supposed to be on the same level as the datasets like this:
{
  labales: [],
  datasets: []
}

If this doesnt fix it please provide a working example

i done that, but the problem still remains :/

@LeeLenaleee  https://codepen.io/stockinail/pen/ExgNgXV, here the case. (does not work).
I assume @Crafter-Y is using version 2.9.4.

@Crafter-Y I think the chart is working well. The problem is the scale is too large. It seems it's starting from zero but it is not.
If you reduce the max value of your data (from 200000 to 20000) you can see the 1 data correctly.

Was looking wrong at the numbers but they are too big I think, it has to split a space of 20.000 in 20 pieces and 1/20 is the point so that is not seeable

Ah okay :D
Thank you!
Shuold i close this issue? (This is the first time I wrote an issue)

If this solves your issue you can close it

Solved!


Add Display Rotation Menu 1.2

After making all changes to the cask:

[ ] brew cask audit --download {{cask_file}} is error-free.
[ ] brew cask style --fix {{cask_file}} reports no offenses.
[ ] The commit message includes the cask’s name and version.

Additionally, if updating a cask:

[ ] sha256 changed but version stayed the same (what is this?).
I’m providing public confirmation below.

Additionally, if adding a new cask:

[ ] Named the cask according to the token reference.
[ ] brew cask install {{cask_file}} worked successfully.
[ ] brew cask uninstall {{cask_file}} worked successfully.
[ ] Checked there are no open pull requests for the same cask.
[ ] Checked the cask was not already refused in closed issues.
[ ] Checked the cask is submitted to the correct repo.

Thanks for the PR! Going to pass on this because there hasn't been a new release for several years.

Rejected Casks
The Cask is for an app that is unmaintained (no releases in the last year, or explicitly discontinued).

I'd suggest creating your own tap.

No worries - I'll make a tap


Standardize exceptions of arithmetic operations on Datetime-like data

Standardize exceptions of arithmetic operations on Datetime-like data

Codecov Report

Merging #2101 (1beaa6f) into master (b413231) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
+ Coverage   95.36%   95.39%   +0.02%
==========================================
  Files          60       60
  Lines       13625    13669      +44
==========================================
+ Hits        12994    13040      +46
+ Misses        631      629       -2

Impacted Files
Coverage Δ

databricks/koalas/base.py
97.01% <100.00%> (+0.11%)
:arrow_up:

databricks/koalas/tests/indexes/test_datetime.py
100.00% <100.00%> (ø)

databricks/koalas/numpy_compat.py
96.87% <0.00%> (+6.25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b413231...1beaa6f. Read the comment docs.

Thanks! merging.


Angular 19 support

With what library do you have an issue?
native-federation
Reproduction of the bug/regression with instructions
After upgrading to Angular 19, application build did not pass.
ng build
Error:
TypeError: stylesheetBundler.bundleFile is not a function
at Object.transformStylesheet
(...................................\node_modules@angular\build\src\tools\esbuild\angular\compiler-plugin.js:149:72)
at MessagePort.
(....................................\node_modules@angular\build\src\tools\angular\compilation\parallel-compilation.js:42:18)
at [nodejs.internal.kHybridDispatch] (node:internal/event_target:820:20)
at MessagePort. (node:internal/per_context/messageport:23:28)

compiler-plugin.js (version 18.x), line 49 define function
function createCompilerPlugin(pluginOptions, styleOptions)
compiler-plugin.js (version 19.x), line 49 define function
function createCompilerPlugin(pluginOptions, stylesheetBundler)
Seems like native-federation build try to invoke function with wrong argument styleOptions. Angular 19 requires argument styleSheetBundler (which contains styleOption as inner attribute when debugging pure Angular 19 build)
Expected behavior
Build should pass without error
Versions of Native/Module Federation, Angular, Node, Browser, and operating system
Native Federation: ^18.2.2
Angular: 19.0.0
OS: Windows
Other information
No response
I would be willing to submit a PR to fix this issue

[ ] Yes
[x] No

I have the exact same error after upgrading to Angular v19.

@AlanGRutter I do some further investigations, it seems like we need to construct object of type ComponentStylesheetBundler located at @angular\build\src\tools\esbuild\angular\component-stylesheets.js. Looking into @angular\build package maintained by Google i don't see this module exported, thus it is not visible to native-federation plugin, am I correct?

I received below error with Module Federation after upgrading to ng19
⠙ Generating browser application bundles (phase: setup)...D:\thanhnlh\sample-mfe\fe-apps\node_modules\webpack\lib\container\ModuleFederationPlugin.js:58
throw new TypeError(
^
TypeError: The 'compilation' argument must be an instance of Compilation
at ModuleFederationPlugin.getCompilationHooks (D:\thanhnlh\sample-mfe\fe-apps\node_modules\webpack\lib\container\ModuleFederationPlugin.js:58:10)
at D:\thanhnlh\sample-mfe\fe-apps\node_modules\webpack\lib\container\HoistContainerReferencesPlugin.js:36:33
at Hook.eval [as call] (eval at create (D:\thanhnlh\sample-mfe\fe-apps\node_modules\tapable\lib\HookCodeFactory.js:19:10), :84:1)
at Hook.CALL_DELEGATE [as _call] (D:\thanhnlh\sample-mfe\fe-apps\node_modules\tapable\lib\Hook.js:14:14)
at Compiler.newCompilation (D:\thanhnlh\sample-mfe\fe-apps\node_modules\ngx-build-plus\node_modules\webpack\lib\Compiler.js:1273:30)
at D:\thanhnlh\sample-mfe\fe-apps\node_modules\ngx-build-plus\node_modules\webpack\lib\Compiler.js:1318:29
at eval (eval at create (D:\thanhnlh\sample-mfe\fe-apps\node_modules\tapable\lib\HookCodeFactory.js:33:10), :31:1)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

@moravkin I am not hugely familiar with the inner workings of Angular. I did find the file you referenced and I did not see it listed in the private exports or the index.ts file. We will need to wait for the package maintainers to fix this issue.
@thanhnlh - your issue is not related to this one. I believe the correct procedure is for you to create a new issue.

@AlanGRutter i agree, this should be propagated further.
As a temporary workaround to test Angular 19 with native-federation you can proceed following steps:

add import to angular-esbuild-adapter.js (change path accordingly)
const cs_1 = require("D:\\develop\\lab\\ang19\\node_modules\\@angular\\build\\src\\tools\\esbuild\\angular\\component-stylesheets.js");
change line 166 (where plugins are populated)
plugins: plugins || [              (0, private_1.createCompilerPlugin)(pluginOptions.pluginOptions,                new cs_1.ComponentStylesheetBundler(pluginOptions.styleOptions, builderOptions.inlineStyleLanguage)

@thanhnlh This issue was related to native-federation using esbuild builder. Your issue arise with module-federation using webpack. I suggest you to create another issue related to different micro-frontend approach

@moravkin - I'm not sure how to upgrade and build the project and reference it locally. Do you have an output that you can attach with instructions on how to use?

@AlanGRutter i am not building plugin locally, I updated code inside node_modules/@angular_architects of my standalone angular project project, then i just run ng build (or ng serve)

Today i tested stuff again. I created new angular app with ng new command (with latest angular-cli) and initiate project with native federation dynamic-host (ng g @angular-architects/native-federation:init --port 4200 --type dynamic-host). Both ng serve and ng build pass successfully without error.

Yes, since the latest patch version of the Angular CLI 19 everything works like before 🙌

#704 I think this issue not be closed yet

Reopen due to #704

Just published version 18@latest and version 19. It should work now.


Difference between passage_embed and embed in Embedding Class

I see that the code base has 2 methods one passage_embed and embed, but upon inspection of the code, I think that both are essentially the same, is there any difference between them. Or is it intended to add future features

The passage_embed  function adds the prefix "passage:". This is recommended usage when you're indexing a corpora into a vector store for instance.
This is expected by several embedding model implementations trained with contrastive losses. For instance, prefix is recommended by the BGE set of embedding models. BGE is default embedding we use as well in fastembed.
Similarly, query_embed function adds the "query:" prefix for usage at query time, when you want to retrieve or rank something using vector similarity
I hope this answers your question 🤞🏼
If it does not, please do re-open the issue!


Link is being played on VLC but cannot be played with Clappr

Hi,
I can play this m3u8 with VLC but cannot be played usin Clappr:
http://<IP_ADDRESS>/live/5/500000/live.m3u8
"my player:

It is likely a CORS issue.

@AmrElbalshy indeed, this is a CORS related issue.
VLC does not have this problem since it doesn't actually require compliancy with CORS policies, unlike running players in a Browser environment.
Testing your URL in the Clappr demo page I had the following errors:
On Chrome:
Access to XMLHttpRequest at 'http://<IP_ADDRESS>/live/5/500000/live.m3u8' from origin 'http://clappr.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

On Firefox:
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://<IP_ADDRESS>/live/5/500000/live.m3u8. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).


[plutil][gardening] Use switch for type casting

This would be more readable.

@swift-ci test and merge


Remove timezone

Removed timezone from tests and from getters.
Had to fix some tests from #32 in the process.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


docs: translate useSyncExternalStore hook

Closes #410
Description
Translate the useSyncExternalStore page.
Page URL: https://id.react.dev/reference/react/useSyncExternalStore

Should I translate snapshot to Indonesian or leave it as-is?

@samnap11 Let's keep it as snapshot

Should be fine but let's wait for the others. @resir014 @r17x @mazipan @zainfathoni

Waiting approval from @resir014


pgsql: properly detect multiple relations between two tables

Resolves #8012

Please add changelog.

Oww... something bad happened to the pull request...

Rebased and added changelog. I didn't add it before because I wasn't sure if the bug wasn't introduced after last release.

Merged manually https://github.com/yiisoft/yii2/commit/ced423b601c2957fc6d3394b6f24fb2cc994ea76


Phaser renderer game scaling

Restrict game size to passed value from zoom event. Size camera based on window height.

closing this one as it requires significant update and @Grenagar is taking over.


host down widget does not see downtime

The following def does not work properly, for some reason it does not exclude hosts that are in downtime:
its weird tho, because the same def is used by services, and that does work.
`def countProblems(objects)
problems = 0
objects.each do |item|
  item.each do |k, d|
    if (k != "attrs")
      next
    end

    if (d["state"] != 0 && d["downtime_depth"] == 0 && d["acknowledgement"] == 0)
      problems = problems + 1
    end
  end
end

return problems

end`

What exactly do you mean? Do you have any sample host data available from /v1/objects/hosts and their attributes (fetch with curl)?

Case can be closed, mistake on my side.

Hint: You can close your own issues on GitHub :)


feature request: incorporate README.md

The API docs are really useful for developers when working with a module.  However, this is only part of the picture.  Having access to the README.md in the same place as the API docs will give a fuller picture of the capabilities of the API and how to use the API.  For example, some of our APIs have no documentation in the code but are well documented in the README.md (example). If a README.md is present in the same directory as the mod.ts, it should linked to somehow.
Some options to include this could be:

README.md is the default view of the module with the left hand nav links to all the API details (as is)
Prominently highlight the README.md at the top of the left hand navigation
Prominently highlight the README.md at the top of the primary display pane

Closing. See https://github.com/denoland/doc_website/issues/54#issuecomment-676546051


Fix #35. Error when starting a new session.

@rashivkp @achelimed can you check and confirm this fix the problem?
Ref: #35

I had the same issue as well, this fix is valid

I know what Travis is, but I have no idea how to write test for zsh theme. If you can suggest me something, I'll be glad to hear.

I've got the same issue when I install it on my remote server.
Well, I'm gonna merge it.

Ah yeah I don't know how one would write tests for specific pieces of the theme's functionality. What I meant was something more along the lines of a 'test' that downloads the script, references to it in a config file and then tries to have the shell source the file. It would only prevent against simplest of errors, so I don't know whether its worth the effort.

I'm gonna find a way to test it more properly. I've asked here about it: https://github.com/caiogondim/bullet-train-oh-my-zsh-theme/issues/175

Ah okay sounds good, let me know if any help is needed. I'd be willing to help.

Sure, thank you.


Support for Zod validator instead of class-validator

Hi,
Great library to use with Nest JS.
I would like to use zod through out the app as a validator library.
It would be great if this library can use zod schema for validating env variables.

sure, we can think of adding support to zod.
Do you already have an idea on how you would like to use it with zod or how to implement the support for it?

I want to define zod schema with all validation logic for each group of env like
export const AppEnvSchema = z.object({
  NODE_ENV: EnvironmentsSchema.default('local'),
  APP_NAME: z.string().optional().default('Demo'),
  API_SERVICE_PORT: z.coerce.number().optional().default(3000),
  DEPLOYMENT_SERVICE_PORT: z.coerce.number().optional().default(3000),
  COSTING_SERVICE_PORT: z.coerce.number().optional().default(3000),
  CCM_SERVICE_PORT: z.coerce.number().optional().default(3000)
});

export type AppEnvType = z.infer<typeof AppEnvSchema>;

and I want to pass this schema either in @Configuration() decorator or in constructor of the class.
@Configuration()
export class ApplicationClientConfig {
constructor(){}
}

so that I can consume each env variable using config variable provided in dependency injection


airDataAiding always declared false without synthethic sideslip fusion

If the EKF stops fusing GPS it will report that it is dead reckoning if it is not fusing airspeed and synthetic sideslip. This seems wrong since synthetic sideslip fusion can e.g. be turned off by setting EKF2_FUSE_BETA to 0.
One solution would be to only check for synthetic sideslip fusion if it is enabled. However, I am questioning the usefulness of synthetic sideslip fusion to constrain drift in the scenario where GPS is failing the innovation checks. So another solution would be to simply remove the sideslip check in the calculation of airDataAiding

See https://github.com/PX4/ecl/pull/530 for Paul's explanation


Information and cover transmitted to the system.

Hello!
Thank you for your hard work!

The Linux system Operating System: Debian GNU/Linux 12
KDE Plasma Version: 5.27.5
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Kernel Version: 6.1.0-18-amd64 (64-bit)
Graphics Platform: X11
In the system tray, when automatically switching tracks, track information and cover art are not displayed.
When the track is switched manually, everything is normal.

At the same time, there is no problem in the browser.

Hi @VlaK0r
Sorry for the late reply.
Is this issue happening with any other web page? Try with Spotify, etc. I'm on Ubuntu 22.04 Gnome 42.9 and everything works fine on my end.
Thank you.

Hi @cwilvx.
I forgot about that already) I added a browser plugin for the integration of kde plasma and the problem was solved.


feat: add parameters to box ai ask and text gen (box/box-openapi#445)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

62 of 136 (45.59%)  changed or added relevant lines in 8 files are covered.
8 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.09%) to 42.028%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/schemas/aiTextGen.generated.ts
3
4
75.0%

src/schemas/aiAsk.generated.ts
2
10
20.0%

src/schemas/aiAgentTextGen.generated.ts
7
17
41.18%

src/schemas/aiAskResponse.generated.ts
22
32
68.75%

src/schemas/aiDialogueHistory.generated.ts
8
20
40.0%

src/schemas/aiAgentAsk.generated.ts
10
25
40.0%

src/schemas/aiCitation.generated.ts
7
25
28.0%

Files with Coverage Reduction
New Missed Lines
%

src/schemas/aiAgentTextGen.generated.ts
2
38.46%

src/schemas/aiAgentAsk.generated.ts
6
30.11%

Totals

Change from base Build<PHONE_NUMBER>0:
-0.09%

Covered Lines:
13012

Relevant Lines:
24079

💛  - Coveralls


CC_94_2048: Removed unnecessary direction in transposeGrid

I've removed the unnecessary direction argument from the transposeGrid function
because transposing a matrix is not dependent on a direction and this might be irritating.

Thanks for this. If I ever make a part 5 someone help me remember to mention this mistake that I made!


1.0.1

Coverage increased (+0.7%) to 84.571% when pulling d0b6b68b6915f7bae29793efb4260bf81a95e052 on 1.0 into d75492c491b78f69a5b8fd44951c0cda9c217e50 on master.


exceeded on budget or storage

My user report said that I exceeded on budget or storage. What should I do to have more budget or storage?  Thanks for your help.

HI
What is your SEPAL username ?
Thanks
Remi
From: beckyjpm<EMAIL_ADDRESS>Sent: 24 July 2019 19:06
To: openforis/sepal<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [openforis/sepal] exceeded on budget or storage (#45)
My user report said that I exceeded on budget or storage. What should I do to have more budget or storage? Thanks for your help.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/openforis/sepal/issues/45?email_source=notifications&email_token=ADHCCC6VHOGZVTUXNO3NIATQBCDXDA5CNFSM4IGSD7WKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HBIGWNA, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADHCCCZ3YL2HE2WVUNHPK5DQBCDXDANCNFSM4IGSD7WA.

Hi Remi,
Thanks for help. My SEPAL username is pjiang.
Panmei
On Mon, Jul 29, 2019 at 2:43 AM lecrabe<EMAIL_ADDRESS>wrote:

HI
What is your SEPAL username ?
Thanks
Remi
From: beckyjpm<EMAIL_ADDRESS>Sent: 24 July 2019 19:06
To: openforis/sepal<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [openforis/sepal] exceeded on budget or storage (#45)
My user report said that I exceeded on budget or storage. What should I do
to have more budget or storage? Thanks for your help.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<
https://github.com/openforis/sepal/issues/45?email_source=notifications&email_token=ADHCCC6VHOGZVTUXNO3NIATQBCDXDA5CNFSM4IGSD7WKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HBIGWNA>,
or mute the thread<
https://github.com/notifications/unsubscribe-auth/ADHCCCZ3YL2HE2WVUNHPK5DQBCDXDANCNFSM4IGSD7WA>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/openforis/sepal/issues/45?email_source=notifications&email_token=AGFQOZ44KWI22O3L2NBLAK3QB2NR3A5CNFSM4IGSD7WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2734MQ#issuecomment-515882546,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGFQOZ26BBLKC4BR3LV2IETQB2NR3ANCNFSM4IGSD7WA
.


get all composite key candidates function added

Added the function to get all of the possible composite key candidates for a delta table

This looks like a great start.  Can you add more tests for the edge cases like when the result is empty, when the DataFrame contains null values, etc?

@souvik-databricks - let me know when you've addressed the feedback from @robertkossendey and this is ready for another review, thank you!

@souvik-databricks - following up on this one.  Are you planning to address this?

@MrPowers Let's go through this details over our sync.

@souvik-databricks - anything else we need to push this over the finish line?


Remove always false checks

About the PR

Why / Balance
Warnings are not Robust.
Technical details

Media

Requirements

[x] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

None.

Thanks for the cleanup!


API return error

Sometimes it doesn't grab a definition.

For 'knew' it returned nothing.
knew_anagram_error.pdf


naabu: 2.0.7 -> 2.0.8

Description of changes
https://github.com/projectdiscovery/naabu/releases/tag/v2.0.8

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 182604 run on x86_64-linux 1

1 package built:

naabu


Fix Install Rules for yak_ros in ROS 1 build

Install rules for ROS 1 build were incorrect and library / executables could not be found.

@schornakj Could you take a look at this, please?


Inconsistent types between optional chaining and explicit if statement

TypeScript Version:  Nightly

Search Terms: strictNullChecks uninitialized
Expected behavior: The two samples below should either both produce an error (my preference) or neither should produce an error.
Actual behavior: There's an error for the explicit if statement but not the optional chain.

Related Issues: #30053
Code
class MyClass {
  getFeatures() {
    return [1, 2, 3];
  }
}

let mc: MyClass;

function query() {
  if (mc !== null && mc !== undefined) {
    return mc.getFeatures();
  } else {
    return undefined;
  }
}

console.log(query().length);
         // ~~~~~~~ Error: Object is possibly 'undefined'. (2532)

on the other hand:
class MyClass {
  getFeatures() {
    return [1, 2, 3];
  }
}

let mc: MyClass;

function query() {
  return mc?.getFeatures();
}

console.log(query().length);  // no error, throws at runtime

I would expect these to both be errors with strictNullChecks enabled. I ran into a TypeError in production today that I traced back to this!
Output
"use strict";
class MyClass {
    getFeatures() {
        return [1, 2, 3];
    }
}
let mc;
function query() {
    if (mc !== null && mc !== undefined) {
        return mc.getFeatures();
    }
    else {
        return undefined;
    }
}
console.log(query().length);

Compiler Options
{
  "compilerOptions": {
    "noImplicitAny": true,
    "strictNullChecks": true,
    "strictFunctionTypes": true,
    "strictPropertyInitialization": true,
    "strictBindCallApply": true,
    "noImplicitThis": true,
    "noImplicitReturns": true,
    "useDefineForClassFields": false,
    "alwaysStrict": true,
    "allowUnreachableCode": false,
    "allowUnusedLabels": false,
    "downlevelIteration": false,
    "noEmitHelpers": false,
    "noLib": false,
    "noStrictGenericChecks": false,
    "noUnusedLocals": false,
    "noUnusedParameters": false,
    "esModuleInterop": true,
    "preserveConstEnums": false,
    "removeComments": false,
    "skipLibCheck": false,
    "checkJs": false,
    "allowJs": false,
    "declaration": true,
    "experimentalDecorators": false,
    "emitDecoratorMetadata": false,
    "target": "ES2017",
    "module": "ESNext"
  }
}

Playground Link: Provided

There's an error in the nightly playground, as expected - maybe this just got fixed?

@RyanCavanaugh I don't think that's it, I see the same issue with 3.7.2. Here's another playground link.

@danvk that link shows only expected behavior. Inside a closure, lets are assumed to have been already initialized.

@RyanCavanaugh I see the same behavior for both nightly and 3.7.2, i.e. an error for the version with an if statement but not the version with a conditional chain:

Here's a version which shows different behavior for an optional chain and an equivalent ternary, which I would really expect to be the same! Playground link
// ...
let mc: MyClass;

function queryChain() {
  return mc?.getFeatures();
}

function queryConditional() {
  return (mc === null || mc === undefined) ? undefined : mc.getFeatures();
}

console.log(queryChain().length);  // no error
console.log(queryConditional().length);  // Object is possibly 'undefined'.

So I'm not sure which one of these should be considered to be "wrong", but these are the relevant designed behaviors, all of which are working as intended:

Defensive comparisons to null and undefined are always allowed
Both branches of a conditional are assumed to be reachable
When the CFA graph doesn't prove otherwise, lets are assumed to have been "already" initialized to their annotated type
e?.x does not introduce | undefined to the type of e.x when we believe e is never null / undefined
e?.x is not an error when we believe e is never null / undefined

This is the one that surprises me:

e?.x does not introduce | undefined to the type of e.x when we believe e is never null / undefined

That makes sense in isolation, but is the opposite behavior from what you get in a ternary which an optional chain is just shorthand for. Is there a good rationale for divergent behaviors in these two cases?
let a = mc?.getFeatures();  // number[]
let b = (mc === null || mc === undefined) ? undefined : mc.getFeatures();  // number[] | undefined


(WIP) [PECO-239] Apache Arrow support

PECO-239 Add Apache Arrow support
Easier to review commit by commit

[x] Basic Apache arrow support
[x] TSparkArrowTypes support
[x] Unit tests
[x] E2E tests
[x] Have Arrow feature always enabled
[x] Option to control if native arrow types should be used or not
[x] Return Arrow result as regular javascript object (convert from internal apache-arrow classes)

[x] Should be compatible with existing JSON result handler
[x] If native types disabled - should parse JSON-serialized fields similarly to existing JSON result handler
[x] Tests

Arrow support is always enabled. User can choose whether to represent complex types as JSON-encoded strings or as native Arrow objects by setting a options.useArrowNativeTypes option of IDBSQLSession.executeStatement (defaults to true)
TSparkArrowTypes.intervalTypesAsArrow is not currently supported by apache-arrow (see https://github.com/streamlit/streamlit/issues/4489) and therefore not exposed to user. PySQL also doesn't support this option, so at least we're consistent here

Codecov Report
Base: 93.77% // Head: 93.32% // Decreases project coverage by -0.46% :warning:

Coverage data is based on head (ce4d461) compared to base (6c977b7).
Patch coverage: 87.87% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   93.77%   93.32%   -0.46%
==========================================
  Files          49       50       +1
  Lines         707      734      +27
  Branches      100      107       +7
==========================================
+ Hits          663      685      +22
- Misses         20       21       +1
- Partials       24       28       +4

Impacted Files
Coverage Δ

lib/result/ArrowResult.ts
75.00% <75.00%> (ø)

lib/DBSQLOperation/SchemaHelper.ts
100.00% <100.00%> (ø)

lib/DBSQLSession.ts
98.63% <100.00%> (+0.14%)
:arrow_up:

lib/connection/connections/HttpConnection.ts
94.44% <100.00%> (ø)

lib/index.ts
100.00% <100.00%> (ø)

lib/result/JsonResult.ts
80.85% <100.00%> (-2.13%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Before merging this I'd like to review the interfaces and tests with @rcypher-databricks and Go driver.

Codecov Report
Base: 93.80% // Head: 90.37% // Decreases project coverage by -3.43% :warning:

Coverage data is based on head (e923815) compared to base (045bb28).
Patch coverage: 66.03% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   93.80%   90.37%   -3.43%
==========================================
  Files          49       52       +3
  Lines         710      790      +80
  Branches      100      121      +21
==========================================
+ Hits          666      714      +48
- Misses         20       38      +18
- Partials       24       38      +14

Impacted Files
Coverage Δ

lib/result/utils.ts
60.00% <60.00%> (ø)

lib/result/ArrowResult.ts
61.01% <61.01%> (ø)

lib/DBSQLSession.ts
97.22% <83.33%> (-1.27%)
:arrow_down:

lib/DBSQLOperation/SchemaHelper.ts
100.00% <100.00%> (ø)

lib/globalConfig.ts
100.00% <100.00%> (ø)

lib/result/JsonResult.ts
86.66% <100.00%> (+3.68%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Codecov Report
Base: 93.80% // Head: 93.03% // Decreases project coverage by -0.77% :warning:

Coverage data is based on head (c2dab38) compared to base (91c49b2).
Patch coverage: 85.84% of modified lines in pull request are covered.

:exclamation: Current head c2dab38 differs from pull request most recent head 671c0a0. Consider uploading reports for the commit 671c0a0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   93.80%   93.03%   -0.77%
==========================================
  Files          49       52       +3
  Lines         710      790      +80
  Branches      100      121      +21
==========================================
+ Hits          666      735      +69
- Misses         20       23       +3
- Partials       24       32       +8

Impacted Files
Coverage Δ

lib/result/utils.ts
80.00% <80.00%> (ø)

lib/DBSQLSession.ts
97.22% <83.33%> (-1.27%)
:arrow_down:

lib/result/ArrowResult.ts
86.44% <86.44%> (ø)

lib/DBSQLOperation/SchemaHelper.ts
100.00% <100.00%> (ø)

lib/globalConfig.ts
100.00% <100.00%> (ø)

lib/result/JsonResult.ts
86.66% <100.00%> (+3.68%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Codecov Report
Base: 93.80% // Head: 93.16% // Decreases project coverage by -0.64% :warning:

Coverage data is based on head (ae5ca1f) compared to base (91c49b2).
Patch coverage: 86.79% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   93.80%   93.16%   -0.64%
==========================================
  Files          49       52       +3
  Lines         710      790      +80
  Branches      100      121      +21
==========================================
+ Hits          666      736      +70
- Misses         20       23       +3
- Partials       24       31       +7

Impacted Files
Coverage Δ

lib/result/utils.ts
80.00% <80.00%> (ø)

lib/result/ArrowResult.ts
86.44% <86.44%> (ø)

lib/DBSQLOperation/SchemaHelper.ts
100.00% <100.00%> (ø)

lib/DBSQLSession.ts
98.61% <100.00%> (+0.12%)
:arrow_up:

lib/globalConfig.ts
100.00% <100.00%> (ø)

lib/result/JsonResult.ts
86.66% <100.00%> (+3.68%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@andrefurlan-db I updated tests so they cover most data types handling. Also, added a separate test to make sure that reponse with multiple arrow batches is also handled as it should. Please take a look. Thank you!

Codecov Report
Patch coverage: 85.43% and project coverage change: -0.80 :warning:

Comparison is base (91c49b2) 93.80% compared to head (2629375) 93.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
- Coverage   93.80%   93.01%   -0.80%
==========================================
  Files          49       52       +3
  Lines         710      787      +77
  Branches      100      120      +20
==========================================
+ Hits          666      732      +66
- Misses         20       24       +4
- Partials       24       31       +7

Impacted Files
Coverage Δ

lib/result/utils.ts
78.57% <78.57%> (ø)

lib/DBSQLSession.ts
97.18% <80.00%> (-1.31%)
:arrow_down:

lib/result/ArrowResult.ts
86.44% <86.44%> (ø)

lib/DBSQLOperation/SchemaHelper.ts
100.00% <100.00%> (ø)

lib/globalConfig.ts
100.00% <100.00%> (ø)

lib/result/JsonResult.ts
86.66% <100.00%> (+3.68%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix Burning Strike

Burning Strike should draw by its magic number (1 -> 2 when upgraded) so its behavior matches its description
Thank you for making this mod btw, it's amazing!

it's fixed in my pr though


error: declaration of template 'template struct SimpleList'

Hi, I connected my esp8266 but when I compile the code "meshquitto_node.ino", it shows the following error:
"
meshquitto_node:330: error: no match for 'operator[]' (operand types are 'SimpleList {aka std::list}' and 'int')
 else if (arr2[j] < arr1[i])

"
please help

It looks like your version of SimpleList does not declare/overload the operator "[]".
Are you using the correct version of SimpleList (i.e. the one under folder ../meshquitto_node/libraries)? If you have a look here then you should see that the operator is actually defined.
My suspicion is that you have another "SimpleList.h" file - one that does not have the operator defined - lying around somewhere in your workspace (maybe from painlessMesh and/or another project) and Arduino seems to favour it during compilation.
Check your compilation debugging for any warnings of the sort of Multiple libraries found for "PainlessMesh". If you see such warnings, they should indicate where the duplicate file resides.

I'm having very similar issues. It looks like the modified implementation in this project breaks when the latest versions of painlessMesh are used. I was able to get things working by using an old version of painlessMesh, but I'm hoping we can get this updated pretty easily.
My machine breaks at this line: https://github.com/sglvladi/meshquitto/blob/c82146dcb168c42372481cb9bb2e63ec8ea273b5/meshquitto_node/libraries/SimpleList/SimpleList.h#L17.
It gives me this error:
In file included from /Users/mackinleysmith/Playground/meshquitto/meshquitto_gateway/mesh_gateway/mesh_gateway.ino:17:0:
SimpleList.h:17: error: declaration of template 'template<class T> struct SimpleList'
 class SimpleList
       ^
In file included from /Users/mackinleysmith/Playground/meshquitto/meshquitto_gateway/mesh_gateway/mesh_gateway.ino:11:0:
/Users/mackinleysmith/Documents/Arduino/libraries/Painless_Mesh/src/painlessMesh.h:43:32: error: conflicts with previous declaration 'template<class T> using SimpleList = std::list<T>'
 using SimpleList = std::list<T>; // backward compatibility

I also have many other errors similar to what @RaulSuquinagua was seeing.

OK 👍  It seems like I'll need to have a look into this. It's been a while since I worked with meshquitto, so I'll have a go at sorting it out with the latest version of painlessMesh

So, it seems like in one of it's recent updates, painlessMesh implements SimpleList as a std:list container, which does not support the [] operand.
To remove any conflicts, I have updated the local implementation of SimpleList and renamed it into CustomList.
I have tested that the code now compiles (with the latest version of painlessMesh on Arduino Library Manager) however I have not tested it on actual devices, as I am away from home.
Please pull and run the latest version of meshquitto and let me know how it goes.

Amazing, it builds! Great work, @sglvladi.

@smit1625 Glad it worked for you!
@RaulSuquinagua maybe this fixes your compilation issues, too.