How can i change  folder suffix 'html' with other?such as 'home.tpl'

         $componentLoaderProvider.setTemplateMapping(function(name) {
             return 'components/' + name + '/' + name + '.tpl';
        });

Thank you very much


Outdated SHA256 hashes on the website.  Customer unwilling to install appliance until they match.

The SHA256 hash for MicrosoftAzureMigrate-Hyper-V.ps1 and the Azure Migrate Appliance do not match what is visible on the website.
MicrosoftAzureMigrate-Hyper-V.ps1 actual SHA256:
0ad60e7299925eff4d1ae9f1c7db485dc9316ef45b0964148a3c07c80761ade2
Azure Migrate Appliance actual SHA256:
7ac0b7669af7cef8285aab7eca0cc61b21642fe128e18cafd4183d945ca90837

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c4f35de7-bb82-83fe-786e-60a5c6923285
Version Independent ID: 1c713868-0f3f-744b-2fab-9d278acad4db
Content: Discover servers on Hyper-V with Azure Migrate Discovery and assessment - Azure Migrate
Content Source: articles/migrate/tutorial-discover-hyper-v.md
Service: azure-migrate
GitHub Login: @Vikram1988
Microsoft Alias: vibansa

@CodingBytes
Thanks for your feedback! We will investigate and update as appropriate.

#reassign: ajaypartha95

Hi team - I just received word that this SHA265 has not been updated yet.  Our customer is blocked from installing Azure Migrate until these hashes match.  Any idea on when we can get them to match?

@ajaypartha95  - Do we have a path to getting these hash values to match the files they link to?

The hash values have been updated. You can find the live link at https://learn.microsoft.com/en-us/azure/migrate/tutorial-discover-hyper-v#verify-security.

#please-close


improves VisibilityFilterTest

The unit test for VisibilityFilter was not testing caching or default visibility.  Updated to test these features and improved the coverage of the test to almost all of the code.

Wanted to test changes to VisibilityFilter for #4748 and the existing test did not have good coverage.  Decided it would be good to improve the test in 2.1 and merge it forward.


Mem0 fix in embedchain

Description
Fixes few issues related to mem0 integration in embedchain.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[x] Unit Test
[ ] Test Script (please provide)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Maintainer Checklist

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Made sure Checks passed

@Dev-Khant can you please check why the CI tests are failing for Embedchain here?


[DO NOT MERGE] Refactor - Move command execution responsibility to CommandHandler from IOThread

TODO
[ ] Investigate CopyTest failure
[ ] Investigate SDK tests failure
This PR is a preparatory step towards solving nearly 50-60% CPU utilisation due to context shift between user space and kernel space for frequent read and write calls.
As first step, this PR moves command execution logic out of IOThread to a new entity CommandHandler. IOThread is now responsible for reading from and writing to the client connection, and CommandHandler is responsible for execution of command by interacting with ShardManager and WatchManager.
Currently, there is 1:1 mapping between IOThread and CommandHandler, and both of them are spawned by Resp Server. IOThread and CommandHandler communicate using 3 channels

ioThreadReadChan - to send command from IOThread to CommandHandler
ioThreadWriteChan - to send response from CommandHandler to IOThread
ioThreadErrChan - to send connection error signal from IOThread to CommandHandler, so that CommandHandler shuts down when IOHandler does

@soumya-codes @lucifercr07 - please review.


wasm: Update from v6.0.2 to v8.0.1

Update wasmtime from v6.0.2 to v8.0.1.
Having an older version causes build errors in subxt with smoldot.
Subxt relies on sp-runtime which was bringing wasmtime v6.0.2, while smoldot has wasmtime v8.0.1.
This change reflects in sp-runtime, sp-core, sp-keyring primarily.
https://github.com/paritytech/subxt/pull/965
// @paritytech/subxt-team

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2861567

Please wait with merging this; I need to run a few benchmarks first to make sure the performance has not regressed.

bot merge


Top 50 users dataset

Please fix a dataset that contains top 50 users.

@hsson Should this be title, users? With all users interested in same title on same row/datapoint?

Yes, this should be like the top_5 data set (not top_5_single). So a row can have multiple users. Also, for compatibility with concatenated input consider adding subreddits as well. I guess it depends on whether the pull request gets accepted or not.


Implement React error boundaries around the app.

Instead of hard crashing, display an error page. Something fun, and not so end of the world.

https://github.com/shapeshift/web/pull/1178


Possibility to skip some models

Would like to have an option to disable the linter for some models.
Proposal:
/* prisma-case-format-disable */

model Account {
  id                String  @id @default(cuid())
  userId            String
  type              String
  provider          String
  providerAccountId String
  refreshToken      String?
  accessToken       String?
  expiresAt         Int?
  tokenType         String?
  scope             String?
  idToken           String?
  sessionState      String?

  user User @relation(fields: [userId], references: [id], onDelete: Cascade)

  @@unique([provider, providerAccountId])
}
/* prisma-case-format-enable */

I came across this issue when wanting to use next-auth

Hey @igeligel, thanks for the suggestion. What is next-auth, is that part of the nextjs ecosystem? If you don't mind me asking, what is the existing problem that you're facing, which these annotations would solve?

Hi @iiian,
you're correct next-auth is part of the next.js ecosystem. It is a package that makes it fairly simple to setup authentication for a website. It supports various providers, and Prisma is one of them. You can check the provider documentation here, the expected schema has strict requirements for casing, some fields of the generated Prisma client are expected to be snake_case (such as token_type, expires_at), while other need to be camelCase (providerAccountId, userId).
We faced the same issue as @igeligel, I've myself been bitten by the casing while cleaning up our DB schema. I now would like to rely on a tool such as prisma-case-format as a linter to ensure we use consistent names. But that would require to either be able to disable prisma-case-format for next-auth's models, or a way to specify (via comments?) the case to use for a specific column.

Got it, thanks for motivating the need--the problem makes sense to me now. Just commenting, seems like the disable feature is useful, and simultaneously the same could be achieved if just overrides for syntax expectations were allowed:
// prisma-case-format:override
// --field-case=camel
// --map-field-case=snake
model GotchaNextAuthModel {
  // now fields are forced to format as camel, with snake @map anno's
  tokenType String @map('token_type')
  expiresAt String @map('expires_at')
}
// prisma-case-format:end-override

That way, prisma-case-format can enforce the case-convention deviation.

I like comments as the trigger, but we'll probably end up wanting to do a commandline arg as well, I'll have to think on that.
Ultimately, I think I hope to support this feature by the end of the year--is that soon enough?

The override syntax is a neat idea, that would make it nicer to handle models that require a specific casing.
Looking at next-auth models, I would say that Account is the most problematic one, because it expects a mix of casing, that makes it a good test case to try out different strategies.
An idea would be to support override comments on the same line, in addition to an override block like the one you suggested.

// 👇 set a default case for the model, for both the Prisma client and columns @map()
//
// prisma-case-format:override(field-case=camel,map-field-case=snake)
model Account {
  id                 String  @id @default(cuid())
  userId             String
  type               String
  provider           String
  providerAccountId  String
                                        // 👇 override some columns, only --field-case
  refresh_token      String?  @db.Text  // prisma-case-format:override(field-case=snake)
  access_token       String?  @db.Text  // prisma-case-format:override(field-case=snake)
  expires_at         Int?               // prisma-case-format:override(field-case=snake)
  token_type         String?            // prisma-case-format:override(field-case=snake)

  scope              String?
  id_token           String?  @db.Text  // prisma-case-format:override(field-case=snake)
  session_state      String?

  user User @relation(fields: [userId], references: [id], onDelete: Cascade)

  @@unique([provider, providerAccountId])
}
// prisma-case-format:end-override

Here the logic would be straight forward:

if a line starts with prisma-case-format:override, start an override block
if an inlined comment starts with prisma-case-format:override, override only for that specific line
if a line starts with prisma-case-format:end-override, stop the override block

I don't think something more complicated such as nested override blocks would make too much sense here, that wouldn't be too readable.
What do you think? I slightly changed your override syntax to make it simpler to use inlined, but that's just a suggestion and my personal preference 😄.

Ultimately, I think I hope to support this feature by the end of the year--is that soon enough?

Oh for sure, yes!

Yep sounds good to me -- I guess we'll just have to say "it has to be the first part of a comment", because we're seizing control of the inline comment, which might clash with other functionality (why I'm generally opposed to adding control flags directly within the file, but in this case it seemed harmless as far as we were going with disable.
I'm almost wondering if there's not value in just creating a --has-next-auth flag, that applies a pre-defined set of case-conventions.
Are there any comments pushing back against @vercel doing this to y'all? Seems arbitrary and poorly published

I had to look it up because I wasn't sure but it doesn't seem to be an official project made by Vercel: https://opencollective.com/nextauth. The package name sounds official but it is made by the community at large.
I'm myself not too familiar with Next.js and its community, I couldn't tell you if this schema weirdness is something people push back against or if it seen as normal. I literally learned about next-auth 2 days ago when doing changes to tables used by a Next.js application and broke signin/signup after renaming some specific columns of the next-auth Github provider (they aren't documented anywhere on next-auth website or GitHub repo, I only found out about it thanks to Prisma having really good error messages). So, not really a fan :)

because we're seizing control of the inline comment, which might clash with other functionality put forth by prisma or other 3rd parties

Yes I agree, that's a fair point.

I found this comment:

Thanks, but this looks correct to me. NextAuth.js provided properties are camelCase while the ones based on the OAuth standard are following snake_case

I'll start with the inline // prisma-case-format:disable ... // prisma-case-format:disable-end feature, but I think an .prisma-case-format file could be a reasonable introduction:
# alternative to specifying cmd line args
defaults:
  table: pascal,plural
  field: camel
  enum:  pascal
  mapTable: snake
  mapField: snake
  mapEnum:  snake
uses_next_auth: true # optional: apply default conventions for "next-auth" models
overrides:
  ModelX:
    defaults: # specify overridden defaults for this scope
      table: snake,singular
      mapTable: pascal
    fields: # apply element-wise overrides
      # alternate short-hand; note this works in model-wise defaults & global defaults
      userId: field=pascal;mapField=pascal,plural
  other_model: disable # shut it off entirely

Okay, so I ended up not going for the //prisma-case-format:disable comments at all, since its manageable from the .prisma-case-format file.
The next PR will contain updates for the README.md, but here's an example of the syntax:
# file: .prisma-case-format
uses_next_auth: false
default: ...
overrides:
  Account:
    default: 'table=pascal; mapTable=pascal;'
    field:
      id:                'field=camel; mapField=camel'
      userId:            'field=camel; mapField=camel'
      type:              'field=camel; mapField=camel'
      provider:          'field=camel; mapField=camel'
      providerAccountId: 'field=camel; mapField=camel'
      refresh_token:     'field=snake; mapField=snake'
      access_token:      'field=snake; mapField=snake'
      expires_at:        'field=snake; mapField=snake'
      token_type:        'field=snake; mapField=snake'
      scope:             'field=snake; mapField=snake'
      id_token:          'field=snake; mapField=snake'
      session_state:     'field=snake; mapField=snake'
      user:              'field=snake; mapField=snake'
  Session:
    default: 'table=pascal; mapTable=pascal; field=camel; mapField=camel'
  User:
    default: 'table=pascal; mapTable=pascal; field=camel; mapField=camel'
  VerificationToken:
    default: 'table=pascal; mapTable=pascal; field=camel; mapField=camel'

note that the above example is strictly equivalent to
# file: .prisma-case-format
uses_next_auth: true

or to specifying the commandline argument --uses-next-auth.

<EMAIL_ADDRESS>is available for download, can you give it a spin and let me know if it looks okay?

Hey @iiian,
This looks great! Will try out today! I might also add some documentation around it if not existing already. Thanks so much for doing these changes so quickly!

That was fast! Thanks so much, I will try it out right away :)

Did you try it with --uses-next-auth as well? I swear I tested that earlier and it worked. In any case, I'll check if this was a regression, thanks for feedback

😄 it's override not overrides. Is that stupid?

Btw. tried and it works! Thanks so much!

Great suggestion, I think somebody else had previously requested this feature but didn't do a great job of explaining it

Thanks @iiian for the quick implementation 🙏. And updates to the readme are clear and easy to follow, that's appreciated!

Thanks @igeligel ! I was actually trying to replicate this.

Where is providerType String @map("provider_type") coming from?


⚠ Bofrost.at has degraded performance

In ee344c1, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 3039 ms

Resolved: Bofrost.at performance has improved in e321992 after 17 minutes.


TOPOLOGY file check should not be happening, If ABORT is requested

Signed-off-by: Mohamed Ashiq Liyazudeen<EMAIL_ADDRESS>

This change is

Seeing as we want to go forward with #81, shall we close this PR?

Only problem closing is gk-deploy --abort will still ask for a topology file. There is only one case where topology file is not required, Thats when you do # gk-deploy --abort this will just clean heketi.

So we need the topology file in all cases EXCEPT when we are aborting without -g. I don't think this corner case with worth worrying about: --abort should only ever be used AFTER a deploy attempt started and failed (or was interrupted), in which case you would have had an extant topology file already.

Agreed, So closing this PR. TOPOLOGY file is always mandatory for deployment.


Append identical header ids with counter

This ensures unique HTML id's in line with the HTML spec, and allows anchors
to always reference the intended header.
Fixes #27

Not that this change will break another test that has two identical headers.


Add graph-theory core package to the Coq Platform

Graph Theory is a library for graph theory based on the Mathematical Components library, including various standard results from the literature (e.g., Menger's Theorem, Hall's Marriage Theorem, the excluded minor characterization of treewidth-two graphs). The project is hosted in Coq-community, maintained by @chdoc and @damien-pous with occasional help from other organization members such as myself. The project has two packages:

coq-graph-theory, the core reusable library of graph definitions and results
coq-graph-theory-planar, graph planarity results depending on coq-fourcolor, i.e., Gonthier's proof of the Four Color Theorem

I propose that coq-graph-theory is included in the Coq Platform. The motivation is that graphs are a widely used formalism with many applications. And while the basic Mathematical Components library includes a form of finite graphs, coq-graph-theory goes much further with directed graphs, simple graphs, multigraphs, etc.
Note that all dependencies of coq-graph-theory (dune, coq-mathcomp-ssreflect, coq-mathcomp-algebra, coq-mathcomp-finmap, coq-hierarchy-builder) are already in the Platform.

@MSoegtropIMC I got a mandate from the main maintainer of graph-theory to do releases for the Platform here. Hopefully this will cover the "maintainer agreement" part of adding a new package.


Does HMR actually work with universal-router?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Yeah it works

@nightwolfz
I have to say it depends.
Currently it's not easy to support HMR with static module import.
In the react-starter-kit , it requires dynamic import to make HMR work:
//routes/index.js
const routes = {
  path: '/',
  children: [
    {
      path: '/',
      load: () => import(/* webpackChunkName: 'home' */ './home'), //dynamic import
    }
  ]
}

//router.js
export default new Router(routes, {
  resolveRoute(context, params) {
    if (typeof context.route.load === 'function') {
      return context.route
        .load()
        .then(action => action.default(context, params)); // call load function
    }
    if (typeof context.route.action === 'function') {
      return context.route.action(context, params);
    }
    return null;
  },
});

//client.js
if (module.hot) {
  module.hot.accept('./router', () => {
    onLocationChange(currentLocation);
  });
}

When you change code in home.js, the resolveRoute will be called through onLocationChange, and it calls load to import the changed module.
However, in cases with out dynamic import:
//routes/index.js
import home from './home'
const routes = {
  path: '/',
  children: [
    {
      path: '/',
      load: () => home,
    }
  ]
}

// client.js
import routes from 'routes';
let router = new UniversalRouter(routes);

if (module.hot) {
  module.hot.accept('./routes', () => {
    const nextRotues = require('./routes').default;
    // How can we replace routes in router ?
  });
}

The load method will return the old home module.
We can get new routes object with changed code in HMR callback, but how can we replace it in router instance?
Currently I'm replace it manually:
module.hot.accept('./routes', () => {
    // eslint-disable-next-line global-require
    const routes = require('./routes').default;
    router.root = Array.isArray(routes) ? { path: '', children: routes, parent: null } : routes;
    router.root.parent = null;
    renderApp(history.location);
  });

But I believe there should be better solution:

expose an static resolve API like #86
add setRoutes method on prototype of class UniversalRouter

Both of them looks great for me, and personally I would prefer the solution 1

@kpaxqin why don't you want to create a new instance of router after hot update?
// entry.js
import UniversalRouter from 'universal-router';
import routes from './routes';

let router = new UniversalRouter(routes);

// ...

if (module.hot) {
  module.hot.accept('./routes', () => {
    const nextRoutes = require('./routes').default;
    router = new UniversalRouter(nextRoutes);
  });
}

or
// router.js
import UniversalRouter from 'universal-router';
import routes from './routes';

export default new UniversalRouter(routes);

// entry.js
import router from './router';

// ...

if (module.hot) {
  module.hot.accept('./router');
}

@frenzzy
My bad! I just made a mistake thinking router instance as a listener and avoid to create duplicated ones.
Actually it just resolve url and returns component, so its safe to re-create router instance.
Thanks for your reply.

Anyone knows how to intercept the dynamic route value as well as route query params? I can't find that when it is using load property.

@adamchenwei if you are talking about react-starter-kit resolve route approach, then you can may use context object as usual:
const route = {
  path: '/page',
  action(context) { // action method
    context.pathname // or context.<any>
  },
};

vs
const route = {
  path: '/page',
  load: () => import('./file'),
};

// file.js
function action(context) { // the same action method as above
  context.pathname // or context.<any>
}
export default action;

You may pass any data to routes via router.resolve({ pathname, ...context })
router.resolve({
  pathname: window.location.pathname,
  dynamicValue: 'here',
})


feat!: autoload storage slots

closes: #1117 #1118
Storage slots are now loaded automatically by default (an opt-out exists).
If the StorageConfiguration indicates that autoload should take place, Contract::load_from will try and discover the storage slots file in the same directory as the contract binary to be loaded.
If it is for some reason missing this constitutes an error. The user will be guided to either provide the file or disable autoloading.
Any additional storage slots configured in StorageConfiguration act as an override taking precedence over what was loaded from the storage slots file.
Enabling the autoloading uncovered a bug where we didn't account for storage slots when calculating the heap data offset for predicates.
Breaking
The storage configuration interface changed
Autoloading by default might change behavior.
Checklist

[x] I have linked to any relevant issues.
[x] I have updated the documentation.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] I have added necessary labels.
[x] I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
[x] I have requested a review from the relevant team or maintainers.

IMO it is a bit weird that we try to get the storage slots path from the bin path. What do you think that instead we ask for the sway project folder. From there we can get both the bin and the storage slots and we can generate nice error messages. Something like this:
    let contract = Contract::load_from(
        "some/path/sway_project_name",
        LoadConfiguration::default().
    )?;

I share your feelings, but have the following reservations:
If we start giving project paths to the Contract::load_from then we're implicitly expecting a certain layout. The bin file must be named as the dir is, the ABI has -abi.json appended etc.
We would expect that the user gave us the root dir of the project (the one where Forc.toml lives) because we need it to extract the project name (then to get the contract bin name etc).
But is the build a debug or a release one? We would need to add a flag for that as well due to the artifacts landing in out/debug and out/release respectively.
Is the project titled the same as the dir? The name property of the Forc.toml can differ from the project rootdir name. From the name property all the generated files derive their names.
What if somebody just wants to load a contract binary from outside a project? We would need to support them and provide an alternative, custom-path-loading mechanism. Or they would need to recreate this folder structure by hand.
If we start accepting project paths, then we would probably want to be consistent in the abigen! as well. So that users might have the same experience of "give the thing a path to your project". Otherwise, they would remember abigen! gets the full path to the JSON, contracts get the project, and predicates again get the custom path (or they get the project).
Although it seems scripty (for lack of a better word), the fact remains that for projects it will detect the storage slots reliably, for one-off contract binaries the autoloading can be disabled and both parties are content.

IMO it is a bit weird that we try to get the storage slots path from the bin path. What do you think that instead we ask for the sway project folder. From there we can get both the bin and the storage slots and we can generate nice error messages. Something like this:
    let contract = Contract::load_from(
        "some/path/sway_project_name",
        LoadConfiguration::default().
    )?;

I share your feelings, but have the following reservations:
If we start giving project paths to the Contract::load_from then we're implicitly expecting a certain layout. The bin file must be named as the dir is, the ABI has -abi.json appended etc.
We would expect that the user gave us the root dir of the project (the one where Forc.toml lives) because we need it to extract the project name (then to get the contract bin name etc).
But is the build a debug or a release one? We would need to add a flag for that as well due to the artifacts landing in out/debug and out/release respectively.
Is the project titled the same as the dir? The name property of the Forc.toml can differ from the project rootdir name. From the name property all the generated files derive their names.
What if somebody just wants to load a contract binary from outside a project? We would need to support them and provide an alternative, custom-path-loading mechanism. Or they would need to recreate this folder structure by hand.
If we start accepting project paths, then we would probably want to be consistent in the abigen! as well. So that users might have the same experience of "give the thing a path to your project". Otherwise, they would remember abigen! gets the full path to the JSON, contracts get the project, and predicates again get the custom path (or they get the project).
Although it seems scripty (for lack of a better word), the fact remains that for projects it will detect the storage slots reliably, for one-off contract binaries the autoloading can be disabled and both parties are content.

I agree with this and I do not mind going with this option if we do not find a better one.

IMO it is a bit weird that we try to get the storage slots path from the bin path. What do you think that instead we ask for the sway project folder. From there we can get both the bin and the storage slots and we can generate nice error messages. Something like this:
    let contract = Contract::load_from(
        "some/path/sway_project_name",
        LoadConfiguration::default().
    )?;

I share your feelings, but have the following reservations:
If we start giving project paths to the Contract::load_from then we're implicitly expecting a certain layout. The bin file must be named as the dir is, the ABI has -abi.json appended etc.
We would expect that the user gave us the root dir of the project (the one where Forc.toml lives) because we need it to extract the project name (then to get the contract bin name etc).
But is the build a debug or a release one? We would need to add a flag for that as well due to the artifacts landing in out/debug and out/release respectively.
Is the project titled the same as the dir? The name property of the Forc.toml can differ from the project rootdir name. From the name property all the generated files derive their names.
What if somebody just wants to load a contract binary from outside a project? We would need to support them and provide an alternative, custom-path-loading mechanism. Or they would need to recreate this folder structure by hand.
If we start accepting project paths, then we would probably want to be consistent in the abigen! as well. So that users might have the same experience of "give the thing a path to your project". Otherwise, they would remember abigen! gets the full path to the JSON, contracts get the project, and predicates again get the custom path (or they get the project).
Although it seems scripty (for lack of a better word), the fact remains that for projects it will detect the storage slots reliably, for one-off contract binaries the autoloading can be disabled and both parties are content.

I agree. Let's use this until we have something better!


Post release automated changes for dns releases

Post release automated changes for azure-arm-dns-profile-2020-09-01-hybrid

API change check
API changes are not detected in this pull request.


script problem

we are unable to replace in contact form "phone no" to "telegram username" because PPL are afraid to give his private contact number that's why we need a telegram username button...

aha


closes #3, spinner fades out after search

The spinner was being called to show but never hidden. I instead changed this to a fadeOut method, which still doesn't reflect real-time search results but works as a hotfix for the issue.

fadeOut is a nice touch 👍


Introduce comma operator and use ,/; instead of ;/;;

The use of the ;; statement separator and a ; sequencing operator, which was inspired by OCaml, just felt too weird an unnatural. Let's go back to something most programmers will more likely already be familiar with.
A nice thing with the comma operator is that it gives us a way of succinctly but clearly discarding return values, by writing foo(123), () instead of let _ = foo(123) in () or discard(foo(123)).
A cons is that the meaning of the comma kind of becomes overloaded.
Another cons is that because we want to be consistent, we want to parse if ... then foo(), 1 else bar(), 2 as if ... then (foo(), 1) else (bar(), 2), but this means if-then-elses now need parentheses when used in an argument list, as in baz(A , (if ... then B1 else B2), C).
The PR also makes a couple of improvements here and there.

Oh that's a good catch. We currently allow trailing commas in parenthesis sections but not outside of them...
We do want trailing commas as they're very convenient. Scala has them but forces a new line right afterwards. Maybe we could do that and only in argument positions...


A Cognitive behavioral therapy (CBT) Chatbot using CNN and Tkinter for GUI

Adding a new folder that contains Cognitive behavioural therapy (CBT) a chatbot has its purpose is to make mental health support more easily accesbile.
It has some preprocessing for input chats and a basic 3 layered CNN model with the epoch of 200, and I am using python library Tkinter for Gui.
I am attaching the working image, Ipynb file, a readme file for more information.
I am GSSOC 2022 participant.

@Rutikab12 please assign this pr Gssoc Tag if possible

Hey @paritoshtripathi935 we have merged your PR.

Hey @paritoshtripathi935 we have merged your PR.

But if there is no Gssoc tag it will not count towards contribution to Gssoc

Don't worry it will be counted.


Dockerfile? -- How hard is it to run this manually?

I'd love to run this as a Github Action in our (private) repository. To do this, it would be awesome if it was easy to run it as a binary #6, or if there was an official Dockerfile to run this on a given repo or source file.
Do you have any advice on the right run-configuration?

I found this documentation from Github/Probot: https://probot.github.io/docs/deployment/#github-actions


Update Angular Template

Acceptance Criteria:

Angular template is updated to use the latest versions of all modules

This is the PR https://github.com/GovAlta/ui-components-angular-template/pull/10

Closing as the PR above has been merged


Additional critic_target gather in SAC_discrete.py

I found there's an additional gather operation in
https://github.com/p-christ/Deep-Reinforcement-Learning-Algorithms-with-PyTorch/blob/master/agents/actor_critic_agents/SAC_Discrete.py#L74
It seems that it is never used, is it necessary or redundant?

thanks, you are correct, it isn't necessary and i've removed it now


Investigate how AWS anomaly detection band is calculated for a metric

PR #80 added an API gateway traffic anomaly alarm with the goal of identifying traffic that is outside the realm of "normal" within a 24 hour day.
However, the alarm immediately began firing, and upon investigation, it was determined that the automatic band of "normal" traffic was not set appropriately:

Investigation is needed to determine how that low/high traffic band was determined and if it can be adjusted.

Findings from investigation:

The smaller the metric period, the more accurate the anomaly band determination is.
The band determination at less than a 6 hour period does not accurately capture the UTC midnight spike in traffic.
A 6 hour period does not properly calculate the current day's anomaly band, however previous days are accurate and traffic stays within the expected range.
A 1 day period completely fails to generate an anomaly band.

Next step is to create a support case with AWS.

AWS support case created and advice was to retrain the model by deleting and recreating it:

Delete model
Create model

Model retrain in progress:

Updated support case with AWS as model is still not accurate.

Latest response:

The narrowing of the bands was due to the bands transitioning from approximated "preview" bands to the bands generated by a persisted model. The preview happens to be better than the persisted in this case, which is not intentional.
We are now trying to improve our internal algorithms further to provide better bands for spiky metrics and is currently in our back log."

They also suggested:

Retraining with a smaller period of data.
Widening the anomaly detection band (increasing standard deviations)

There is no ETA for a fix and this is an AWS problem, so I'm closing this and will re-open if anything changes.


[UF-443] - Header and Footer should support Errai UI

I'll remove deprecated interfaces

JENKINS RETEST THIS

Do not merge. I still need to migrate all header implementations in the workbench.

@csadilek related PR's
https://github.com/dashbuilder/dashbuilder/pull/280
https://github.com/droolsjbpm/kie-wb-common/pull/649
https://github.com/droolsjbpm/jbpm-form-modeler/pull/85
https://github.com/droolsjbpm/drools-wb/pull/392
https://github.com/droolsjbpm/optaplanner-wb/pull/133
https://github.com/droolsjbpm/jbpm-designer/pull/542
https://github.com/droolsjbpm/jbpm-console-ng/pull/615
https://github.com/droolsjbpm/appformer/pull/69
https://github.com/droolsjbpm/kie-wb-distributions/pull/452


[virtctl] Express image-upload options deprecation via pflag

What this PR does / why we need it:
Express deprecation via MarkDeprecated, leading to the following warnings:
Flag --pvc-name has been deprecated, specify the name as the second argument instead.
Flag --pvc-size has been deprecated, use --size instead.

Further marking them as deprecated removes them from the --help page.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
An alternative may be to just drop these flags now?
Release note:
NONE

/cc @awels

/lgtm

/retest-required
/approve


Update Horizon 0.24.0 CHANGELOG

@ire-and-curses added. If I'm missing something please update this PR and merge.


Fixed: The emoji autocomplete does not appear after switching apps

Summary

This PR fixes emoji autocomplete after switching apps
Ticket Link

Fixes https://github.com/mattermost/mattermost/issues/24325
Checklist

Device Information
This PR was tested on:
Device: Samsung Galaxy S20 FE
OS: Android 13
Screenshots

Release Note

NONE

Hello @harshal2030,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Building app in separate branch.


Cannot package libraries that contain vendored Rust libraries used in the build

https://github.com/servo/mozjs is a snapshot of the JS engine from https://hg.mozilla.org/mozilla-central/, wrapped up in a crate that invokes the native Makefile build from build.rs. This native build happens to invoke cargo build on a Rust project that exists inside https://hg.mozilla.org/mozilla-central/ and generates a binary that is used in the JS engine build. The build works fine, but running cargo package causes the subdirectory containing this project to be ignored (mozjs/js/src/frontend/binsource) because it contains a Cargo.toml. I am no longer able to publish new versions of mozjs on crates.io since this Rust library was introduced upstream because of this restriction.

I believe this happens roughly around here, and unfortunately there's no clear fix for this I know of.

@alexcrichton What do you think of not excluding a subpackage from the tarball if that directory is explicitly listed in include?

By no clear fix, did you mean in the design decision of what the behavior should be, or are there implementation difficulties?

I believe this is both a difficult design decision as well has something which has a number of implementation difficulties. I think that supporting this would require an RFC as well as a champion for the implementation.


Quckstart - Local Deployment Bug in metadata docker --help

Affected module
Quickstart mostly
Describe the bug
Following the instructions on https://docs.open-metadata.org/v1.0.0/quick-start/local-deployment, the metadata command doesn't work and errors out.  Unsure specifically the root cause yet (still looking into it on this end, too)
To Reproduce
Visit https://docs.open-metadata.org/v1.0.0/quick-start/local-deployment
Follow steps in Procedure 1-6.  This errors out on part 6.
Please see the "Additional context" section below for stack trace and library versions installed.
Expected behavior
The ability to run through the entire guide.
Version:

OS: [e.g. iOS] Mac OSX 13.3.1 (a)
Python version: 3.11.3
OpenMetadata version: [e.g. 0.8]

N/A

OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Ran pip3 install --upgrade "openmetadata-ingestion[docker]", resulted in version <IP_ADDRESS> of openmetadata_ingestion

Additional context
The specific stack trace I'm getting is:
❯ metadata docker --help
Traceback (most recent call last):
  File "/Users/user/programming/work/labs/open-metadata/env/bin/metadata", line 5, in <module>
    from metadata.cmd import metadata
  File "/Users/user/programming/work/labs/open-metadata/env/lib/python3.11/site-packages/metadata/cmd.py", line 21, in <module>
    from metadata.cli.backup import UploadDestinationType, run_backup
  File "/Users/user/programming/work/labs/open-metadata/env/lib/python3.11/site-packages/metadata/cli/backup.py", line 22, in <module>
    from metadata.cli.utils import get_engine
  File "/Users/user/programming/work/labs/open-metadata/env/lib/python3.11/site-packages/metadata/cli/utils.py", line 18, in <module>
    from metadata.generated.schema.entity.services.connections.database.mysqlConnection import (
  File "/Users/user/programming/work/labs/open-metadata/env/lib/python3.11/site-packages/metadata/generated/schema/entity/services/connections/database/mysqlConnection.py", line 12, in <module>
    from metadata.ingestion.models.custom_pydantic import CustomSecretStr
  File "/Users/user/programming/work/labs/open-metadata/env/lib/python3.11/site-packages/metadata/ingestion/models/custom_pydantic.py", line 22, in <module>
    from metadata.utils.logger import ingestion_logger
  File "/Users/user/programming/work/labs/open-metadata/env/lib/python3.11/site-packages/metadata/utils/logger.py", line 20, in <module>
    from metadata.generated.schema.api.lineage.addLineage import AddLineageRequest
  File "/Users/user/programming/work/labs/open-metadata/env/lib/python3.11/site-packages/metadata/generated/schema/api/lineage/addLineage.py", line 11, in <module>
    from ...type import basic, entityLineage
  File "/Users/user/programming/work/labs/open-metadata/env/lib/python3.11/site-packages/metadata/generated/schema/type/basic.py", line 96, in <module>
    class EntityLink(BaseModel):
  File "pydantic/main.py", line 178, in pydantic.main.ModelMetaclass.__new__
  File "pydantic/typing.py", line 399, in pydantic.typing.resolve_annotations
    raise TypeError("Cannot subclass special typing classes")
  File<EMAIL_ADDRESS>line 366, in _eval_type
    return t._evaluate(globalns, localns, recursive_guard)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 864, in _evaluate
    eval(self.__forward_code__, globalns, localns),
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <module>
  File "pydantic/types.py", line 463, in pydantic.types.constr
  File<EMAIL_ADDRESS>line 227, in compile
    return _compile(pattern, flags)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 294, in _compile
    p = _compiler.compile(pattern, flags)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 743, in compile
    p = _parser.parse(p, flags)
        ^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 980, in parse
    p = _parse_sub(source, state, flags & SRE_FLAG_VERBOSE, 0)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 455, in _parse_sub
    itemsappend(_parse(source, state, verbose, nested + 1,
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 841, in _parse
    raise source.error('global flags not at the start '
re.error: global flags not at the start of the expression at position 1

Other versions, noting here:

pydantic at 1.10.7

Good morning ulixiux9.  It may be a good idea to update the quickstart guide (https://docs.open-metadata.org/v1.0.0/quick-start/local-deployment) to mention the limitation on Python.  Right now, it says "version 3.7 or greater"


[CodeCompletion] Use AnyFunctionType::Param::getParameterType()

instead of getOldType() in KeyPath as functions completion (as per an offline discussion with @slavapestov).

@swift-ci Please smoke test

@brentdax Releated to rdar://problem/59445486, could you tell
func foo<T>(x: (String...) -> T) {}
_ = foo(x: \.count)

should be typechecked or not? Should we treat \.count as \Array<String>.count?

https://github.com/apple/swift/pull/30773 answers the question above.

@swift-ci Please smoke test

@swift-ci Please smoke test


Updating com.google.gms:google-services to 4.3.8

Feature Request
Motivation Behind Feature
The current pinned version, 4.2.0, seems incompatible with Gradle 7. And indirectly with cordova-android 10.0.0.
Feature Description
Is there any chance to update the plugin to 4.3.8?

I tested it, and it seems to work


sqlccl: merge IMPORT and RESTORE jobs

PR: https://github.com/cockroachdb/cockroach/pull/21490
From release notes:

The IMPORT function now does not require the temp directory and no longer creates a RESTORE job. Additionally, the TRANSFORM_ONLY option for IMPORT has been renamed to TRANSFORM and now takes an argument specifying the target directory.

Already documented with the previous IMPORT doc.


:sparkles: Add function to detect if non-operational status is due to wire kink

Description
This PR adds a function that determines if the layout is non-operational due to kinks.
Checklist:

[x] The pull request only contains commits that are related to it.
[x] I have added appropriate tests and documentation.
[ ] I have added a changelog entry.
[x] I have created/adjusted the Python bindings for any new or updated functionality.
[x] I have made sure that all CI jobs on GitHub pass.
[ ] The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok sorry I was too fast with the approval. Once you fixed the CI, we can merge though 🙂

@marcelwa Some other changes were necessary due to some mistakes I made. It would be great if you could go through it again. Thank you very much!  🙏


Deploy to Function App not working.

Does this occur consistently? Yes
Repro steps:

Right click function and and select "Deploy to Function App..."
Select the desired subscription
Select the desired Function App
Nothing happens for a couple minutes, then "Report error" button appears.

Action: azureFunctions.deploy
Error type: InternalServerError
Error Message: Encountered internal server error. Diagnostic information: timestamp '20201019T195701Z', subscription id 'bf62bbfa-cdd0-4e13-b1e6-a509441e7b6e', tracking id '322cee03-3614-4b4f-a973-f150f67124eb', request correlation id '322cee03-3614-4b4f-a973-f150f67124eb'.
Version: 0.24.1
OS: darwin
OS Release: 19.6.0
Product: Visual Studio Code
Product Version: 1.50.1
Language: en

Call Stack
new RestError extension.bundle.js:48:94460
extension.bundle.js:48:1291123
processTicksAndRejections task_queues.js:94:5

Unfortunately these types of errors are often from Azure and it could be caused by a variety of things. We'll need some more info to help diagnose, for example:

What region?
What plan type (consumption/premium/etc.)
Is this a brand new project?
What type of triggers do the project have?
Do you have full access to the subscription?

It might help to just try creating a new function app as well.

@nturinski Thanks for the response.
It seemed Azure was down during this error as even the portal was not loading. I left it for a night and it was back working again.


Changed Website Extension

Please note: This repository is being rebuilt to accept the new volume of token additions and modifications. PR merges will be delayed.

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address:
Token Name:
Token Symbol:
Logo: (logo should be uploaded under assets/mainnet//*.<png/svg>)
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

Auto merge requirements
Your pull request will be automatically merged if the following conditions are met:

Your pull request only adds new tokens to the list. Any modification to existing
tokens will require manual review to prevent unwanted modifications.

Your pull request does not touch unrelated code. In particular, reformatting changes to unrelated
code will cause the auto merge to reject your PR.

Any asset files added correspond to the token address you are adding. Asset files
must be PNG, JPG or SVG files.

Your change is valid JSON and conforms to the schema. If your change failed validation,
read the error message carefully and update your PR accordingly.

No other tokens shares the same name, symbol or address.

For example, this change would be rejected due to unrelated changes:

The bot runs every 60 minutes and bulk-merges all open pull requests to prevent conflicts.
This means that you need to wait up to 60 minutes for your pull request to be merged or reprocessed.

you re-added the same block instead of modifying the existing one: https://github.com/solana-labs/token-list/pull/15106/files
as a result https://github.com/solana-labs/token-list/pull/15106/checks?check_run_id=4902170169 says duplicate token: token address 4ZoMoYLFjEmZjTUG4ZvKya5AEYXRGZETDFKR28Zd3wEw is already used

you re-added the same block instead of modifying the existing one: https://github.com/solana-labs/token-list/pull/15106/files as a result https://github.com/solana-labs/token-list/pull/15106/checks?check_run_id=4902170169 says duplicate token: token address 4ZoMoYLFjEmZjTUG4ZvKya5AEYXRGZETDFKR28Zd3wEw is already used

Thank you @keone for your answer, ... I've actually modified the existing one: https://github.com/solana-labs/token-list/pull/15106/files, but it looks my changes haven't been pushed/commited to the main Solana token-list repository.
Meaning, the actual main Solana token-list still show the wrong website extension.
Did I miss something ?
Looking for to your reply, thanks.

the diff disagrees with your statement "I've actually modified the existing one": https://github.com/solana-labs/token-list/pull/15106/files
that's adding a new block

Thank you @keone for your answer, ... still, how am i supposed to modify my website extension in order for this change to be commited and approved ?

edit the file in the appropriate place
if this not clear to you please ask a friend to read these messages and help you


Worker image vulnerabilities fixes

Removing all fixable vulnerabilities from the worker image.
Some of the medium or low level vulnerabilities still present due to lack of available fixes in debian docker image.
🗣 Description
Changes:

updated some npm packages and added relevant version overrides
due to serverless upgrades, updated the serverless configuration to avoid failures during local builds/testing; Added "dev" sections in the configuration to avoid warnings and failures.
updated some python packages in requirements.txt to newer packages.
updated the webpack config to remove some of the warnings coming from typeorm drivers.
refactored the docker file by extracting the ruby related commands/build artifacts to their updated ruby layer; this was required due to old version of ruby (2.7) in base debian docker image.
updated the finddomain, amass, nvdtools to latest versions to avoid vulnerabilities
installed pyhton 3.10 in debian image (to avoid vulnerabilities from python 3.9 in debian base image)
added safety policy file to ignore know vulnerability from scrapy for the next 6 months. Updated action file to use it. This will make "green" the "Check for vulnerabilities" github action.

💭 Motivation and context
Eliminate vulnerabilities that have a fix available. Ignore errors/warnings for known issues temporarily to be able to have a "green"/good build. This will help us identify more easily errors caused by new code changes.
🧪 Testing
Build the image from scratch.
📷 Screenshots (if appropriate)
Before the fixes

After the fixes

✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

@epicfaace, is it possible to get access to the snyk failure details? If not, please share the details with me, I can try to fix that too.

Just tried upgrading cryptography to the fix version, but ran into an issue of conflicting dependencies. I will have to address this in a future commit as this change will require more involved code changes.


nixos/networkd: add missing IPv6 options

Motivation for this change
Adds various missing/renamed configuration sections/options for systemd-networkd related to IPv6.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg test systemd-networkd-ipv6-prefix-delegation

@GrahamcOfBorg test systemd-networkd-ipv6-prefix-delegation

@GrahamcOfBorg test systemd-networkd-ipv6-prefix-delegation

@GrahamcOfBorg test systemd-networkd-ipv6-prefix-delegation

If there's anything I can do to advance this PR, feel free to reach out. Happy to help :)

This is missing changelog entries. Would be nice to point users towards this before they run into crypto eval errors (that do not point out the right lines :/)


Implement itertools.filterfalse

https://docs.python.org/3/library/itertools.html#itertools.filterfalse
From looking at the C Python code, it looks like it is an object a la the dict_keys and other things that have been turned into objects in Python 3

I'm interested in tackling this as a first step into IronPython development, but could use a little more guidance as I get started.
The function has clearly been renamed (ifilterfalse -> filterfalse), which is a trivial change, but there's obviously more to it. Superficially the return type of calling the function appears to match CPython 3.x's (barring the rename,  <class 'itertools.filterfalse'>), although looking at the returned objects further there are some clear differences, e.g. the presence of a __contains__ method on the IronPython version.
Can you elaborate a bit on what exactly the work for filterfalse would look like? I'm slightly confused by the lack of apparent differences in PythonDictionary.cs/DictionaryKeyView between IronPython2 and IronPython3, as you called out dict_keys as an example.

@rtzoeller Thanks for your interest.
After taking a quick look at this I would say that this is pretty much just a rename from ifilterfalse -> filterfalse. At the same time I would suggest going through the module and renaming any other method which seems to have dropped the i prefix in 3.0.
Like you said, there are a few differences between the methods of the different implementations but I don't think those are differences are necessarily specific to filterfalse but more generalized things to fix (for example the unrelated list_iterator has the same issues). The differences that I see are:

__contains__ in Ipy
comparison operators in CPy
__dir__ in CPy

You can probably safely ignore those differences (though we should probably file issues to capture these differences).


Web app crashing after a while

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
Break down in numbered steps

Open the app

Expected Result:
Describe what you think should've happened
The app should load without crashing
Actual Result:
Describe what actually happened
The app crashes with console error
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
None
Platform:

Where is this issue occurring?

Web

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661773256971749

View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

I'm not quite sure what is causing this, but I'm guessing that props.policies in AvatarWithIndicator looks something like this, where one of the policies is null. To fix this I will check for if the policy exists in the policy util method.
const policies = {
    1234: null,
    12344: {},
};

Havent linked it before, this is coming from https://github.com/Expensify/App/pull/10400


Compiling Autolinker.js with simple optimizations gives broken output

When I use closure compiler to minify Autolinker.js, the output is broken JavaScript that throws an error when loaded.
For the input file, go here:  https://github.com/gregjacobs/Autolinker.js/releases/tag/0.27.0
and grab Autolinker.js-0.27.0/dist/Autolinker.js (the unminified version)
When loaded on an HTML page, the minified file gives this error and the library is unusable:
Uncaught TypeError: Cannot read property 'prototype' of undefined on line 9
This is a somewhat new problem.  Here are a few versions of closure-compiler-unshaded that I tested with:

OK in v20160517
broken in v20160619
broken in v20160713

I see the same problem using the online webapp version of closure compiler at the time of this writing. https://closure-compiler.appspot.com/home

I did some bisecting between v20160517 and v20160619:
f257eb0a9bc90b83e55ce4fd197abebb0e1a6849 ok
d8cab3fa8ac1fa80ce372202c2e55d097b28b59f ok
e90c2eeedb70da6a3ca0d27a048b4752a5dc16e1 ok
f865cdad5644c4123948bb34c7739c81209d3945 ok
94718fd4e697a3e4cb3a9b0650958e97b52447b7 ok
7f859a15719700df812bef3dba5762b23228a5de broken
f4df975aef5df6fa3841ba48884144301d7ce601 broken
f2230394b6558bed5688018bcbeb77446219b9f7 broken
7f859a15719700df812bef3dba5762b23228a5de is the first commit with this issue, and that commit added support for @abstract.
Autolinker.js does use @abstract in eight places.  Five of those look like this and don't trigger any problems with closure compiler.  Removing the @abstract does not help:
/**
 * Returns a string name for the type of match that this class represents.
 *
 * @abstract
 * @return {String}
 */
getType : Autolinker.Util.abstractMethod,

Three of those look like this (they are all marked with @class) and do trigger problems with closure compiler.  Removing the @abstract does help if I remove all three, but if I leave any then the problems persist:
/**
 * @abstract
 * @class Autolinker.match.Match
 *
 * ...
 */
Autolinker.match.Match = Autolinker.Util.extend( Object, {

Is Autolinker.js using @abstract incorrectly, or should closure compiler be treating @abstract differently when @class is also present?  Or none of the above...?

My guess is that those marked with both @abstract and @class get pruned in ClosureCodeRemoval. Try annotating them with @constructor instead of @class. AFICT @class doesn't mean anything to Closure Compiler but @constructor does. You can probably remove the @constructor annotation on the constructor methods as well since those annotations probably won't do anything.

To be clear, I'm not the author of Autolinker.js.  I just happen to be minifying it as part of my application's build process.
I think the author is using JsDoc annotations for generated documentation, as seen here: http://gregjacobs.github.io/Autolinker.js/docs/#!/api/Autolinker.matcher.Matcher

The compiler should have warned about invalid JsDocs.

Ah, I did have a couple of warnings disabled.
CompilerOptions options = new CompilerOptions();
CompilationLevel.SIMPLE_OPTIMIZATIONS
    .setOptionsForCompilationLevel(options);
options.setWarningLevel(
    DiagnosticGroups.NON_STANDARD_JSDOC,
    CheckLevel.OFF);
options.setWarningLevel(
    DiagnosticGroups.MISPLACED_TYPE_ANNOTATION,
    CheckLevel.OFF);

If I use the default settings instead, it complains about all eight uses of @abstract, among other things.
Autolinker-0.27.0.js:1864: WARNING - Misplaced @abstract annotation. only functions or methods can be abstract
Autolinker.htmlParser.HtmlNode = Autolinker.Util.extend( Object, {
^

Autolinker-0.27.0.js:1909: WARNING - Misplaced @abstract annotation. only functions or methods can be abstract
	getType : Autolinker.Util.abstractMethod,
	^

Autolinker-0.27.0.js:2116: WARNING - Misplaced @abstract annotation. only functions or methods can be abstract
Autolinker.match.Match = Autolinker.Util.extend( Object, {
^

Autolinker-0.27.0.js:2160: WARNING - Misplaced @abstract annotation. only functions or methods can be abstract
	getType : Autolinker.Util.abstractMethod,
	^

Autolinker-0.27.0.js:2207: WARNING - Misplaced @abstract annotation. only functions or methods can be abstract
	getAnchorHref : Autolinker.Util.abstractMethod,
	^

Autolinker-0.27.0.js:2216: WARNING - Misplaced @abstract annotation. only functions or methods can be abstract
	getAnchorText : Autolinker.Util.abstractMethod,
	^

Autolinker-0.27.0.js:2816: WARNING - Misplaced @abstract annotation. only functions or methods can be abstract
Autolinker.matcher.Matcher = Autolinker.Util.extend( Object, {
^

Autolinker-0.27.0.js:2846: WARNING - Misplaced @abstract annotation. only functions or methods can be abstract
	parseMatches : Autolinker.Util.abstractMethod
	^

It seems to me that if Closure Compiler thinks these @abstract annotations are misplaced, then it doesn't understand these annotations well enough to use them as hints for code removal (or anything else).


How to get raw response body / responseData?

Agent seems to expect JSON response by default, returning an error otherwise.
Agent.get("http://google.com").end {
  response, data, error in
  println(error)
}

/*
Error Domain=NSCocoaErrorDomain Code=3840 "The operation couldn’t be completed. (Cocoa error 3840.)" (JSON text did not start with array or object and option to allow fragments not set.) UserInfo=0x7fa9f1469210 {NSDebugDescription=JSON text did not start with array or object and option to allow fragments not set.}
*/

How can I get either the body as a string or as responseData to coerce to a string?

Will be implementing functions that coerce responses into the data format you need, starting with the raw data and JSON. From there you can extend it as you need. Please keep track in:
https://github.com/hallas/agent/pull/26

Merged in #26 with out this but will start a new feature branch for this now.

Should be fixed in #29


FileNotFoundError with --multifile

% ../feditest/venv.darwin.develop/bin/feditest convert-transcript --in production/testresults/webfinger-server-all-wellknown-saas-imp.json --multifile foo
Traceback (most recent call last):
  File "/Users/jernst/git/github.com/jernst/feditest/venv.darwin.develop/lib/python3.12/site-packages/feditest/cli/commands/convert_transcript.py", line 53, in run
    serializer.write(transcript)
  File "/Users/jernst/git/github.com/jernst/feditest/venv.darwin.develop/lib/python3.12/site-packages/feditest/testruntranscript.py", line 581, in write
    self._copy_static_files(self.template_path, self.output_dir)
  File "/Users/jernst/git/github.com/jernst/feditest/venv.darwin.develop/lib/python3.12/site-packages/feditest/testruntranscript.py", line 656, in _copy_static_files
    shutil.copyfile(filepath_from, filepath_to)
  File<EMAIL_ADDRESS>line 262, in copyfile
    with open(dst, 'wb') as fdst:
         ^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'foo/foo/css/feditest.css'

It might be that the chdir gets in the way: https://github.com/fediverse-devnet/feditest/blob/b6a324b393ff601b736d5d50ef7fc099e5a0d176/src/feditest/testruntranscript.py#L578

I didn’t test this with a relative output directory. Do you want to make the change or wait until I have some time to do it. Just removing the chdir is likely to cause issues with relative template resolution but maybe that can handled by resolving all template directories in the path to absolute paths.

Still having (different) trouble:
% ../feditest/venv.darwin.develop/bin/feditest convert-transcript --in production/testresults/webfinger-server-all-wellknown-saas-imp.json --multifile foo
Traceback (most recent call last):
  File "/Users/jernst/git/github.com/jernst/feditest/venv.darwin.develop/lib/python3.12/site-packages/feditest/cli/commands/convert_transcript.py", line 53, in run
    serializer.write(transcript)
  File "/Users/jernst/git/github.com/jernst/feditest/venv.darwin.develop/lib/python3.12/site-packages/feditest/testruntranscript.py", line 612, in write
    fp.write(matrix_template.render(**context))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jernst/git/github.com/jernst/feditest/venv.darwin.develop/lib/python3.12/site-packages/jinja2/environment.py", line 1304, in render
    self.environment.handle_exception()
  File "/Users/jernst/git/github.com/jernst/feditest/venv.darwin.develop/lib/python3.12/site-packages/jinja2/environment.py", line 939, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "/Users/jernst/git/github.com/jernst/feditest/venv.darwin.develop/lib/python3.12/site-packages/feditest/templates/multifile/test_matrix.jinja2", line 15, in top-level template code
    {%  include "testrun-transcript-title.jinja2" %}
    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/jernst/git/github.com/jernst/feditest/venv.darwin.develop/lib/python3.12/site-packages/jinja2/loaders.py", line 207, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: testrun-transcript-title.jinja2

Could this exception have a message saying where it was looking for templates and couldn't find them?

Still having (different) trouble:

Maybe we should create a different issue for this?

Could this exception have a message saying where it was looking for templates and couldn't find them?

It's a jinja2 exception, raised by the jinja2 template loader. You didn't specify a template directory so it's going to look in templates/multifile, by default. Is that where the templates are located? If not, use the --template argument to specify the directory where they're located.

Separate issue created: #179.
Also, we probably need: #180.


Colored text doesn't work with logging

This works:
>>> from clint.textui import colored
>>> print(colored.green("Test"))
Test

Here, the "Test" is green, as expected.
But this doesn't work:
>>> import logging
>>> logging.getLogger().addHandler(logging.StreamHandler())
>>> from clint.textui import colored
>>> logging.critical(colored.green("Test"))
←[32m←[22mTest←[39m←[22m

In that case, the "Test" is not green and the escape sequences are visible.

In my env, it works.
So maybe this problem is fixed in the latest version, or your env is unexpected one.
% cat log.py
#!/usr/bin/env python
# -*- coding: utf-8 -*-

from clint.textui import colored
print(colored.green("Test"))

import logging
logging.getLogger().addHandler(logging.StreamHandler())
from clint.textui import colored
logging.critical(colored.green("Test"))

% python log.py
Test
Test

I can't actually reproduce this anymore, so it's likely that something in the latest version fixed it.


can you added configuration files

Hi,
Can you add the AppAmazonCredentials.csv and ClientAmazonCredentials.csv files ?

Those are credentials files. You should use your own credential files.

Those are credentials files. You should use your own credential files.


Webhook failing (in a new cluster) during kubectl apply

Solution expected
I have ExternalSecrets working nicely in our main cluster. It just won't work in the new cluster. Both have kubernetes 1.21 running. The solution I'd like is to understand what is happening on the data flow and get this new installation of external-secrets working in the new cluster as well.
What is the added value?
Get ExternalSecrets easier to install and work in different scenarios
Additional information:
I have ExternalSecrets working in one of the clusters we operate. When trying to use it in the second cluster, it just won't work. Both clusters don't have internet connection access.
The validating webhook is preventing me to apply my ClusterSecretStore and ExternalSecret (I'm attaching both of them).

Here are the ClusterSecretStore and ExternalSecret:

I did try to spin up a new pod to try to curl the service from within the cluster. It wasn't much helpful since it says I'm getting a 503 (omitted proxy configs):

While trying to troubleshoot I did realize that the logs are showing something is wrong... but I don't have enough information to tell what that is. I don't see those errors on the original installation. They are present at the beginning of the logs, and then are gone. Still after that, I still can't apply my ClusterSecretStore and ExternalSecret.
Webhook pod logs:

Cert Controller logs

External Secrets pod logs

Your help is very much appreciated. Thanks in advance.

i ahve the same error as well. I was able to deploy it on the GKE cluster but not on EKS cluster, I am using the same helm chart on both clusters. kuberenetes version: v1.21.14-eks-fb459a0
ESO version: v0.6.1
I am getting the following error when trying to create the ClusterSecretStore

Error: UPGRADE FAILED: failed to create resource: Internal error occurred: failed calling webhook "validate.clustersecretstore.external-secrets.io": Post "https://external-secretservice-webhook.external-secrets.svc:443/validate-external-secrets-io-v1beta1-clustersecretstore?timeout=5s": Address is not allowed

Hi Gustavo! Thanks for reaching out.
ESO version is 0.5.9
Here are the rolebindings I have:

About the installation: I run the helm installation with "dry-run", copied all the generated content and stored it into a file. Modified just the images address and installed on the cluster. I pulled the images and stored them on my local ECR.
Generated installation file is here:
install.yaml.zip
Thank in for your support.

Can you check with kubectl get secrets -n external-secrets external-secrets-webhook contains the data for the certificate generated by the cert-controller?

Hi Gustavo! Thanks for reaching out to this. The project I'm involved with decided to step back on the solution and adopted another one. I won't be driving these tests anymore. Thanks for the support!


Missing some properties in form element on type level

in form element from '@dlightjs/types' missing properties like onSubmit
but in fact these properties exist
so following code will fire 'submit' in console without page reload despite the type error:
form()
  .onSumbit((e) => {
    e.preventDefault()
    console.log('submit')
  })

dlight version:
"dependencies": {
  "@dlightjs/dlight": "^1.0.0-alpha.65"
},

"devDependencies": {
  "@dlightjs/types": "^1.0.0-alpha.1"
},

Fixed in the latest DLight version


(MODULES-2519) Places for More DSC Information

Initial feedback suggests that someone without direct knowledge of DSC will not know how to use our module because they do not know how to find information on how to use DSC. We should add some links to the quickstarts on Technet and some of the official PowerShell team blog posts

Address those minor issues and we're :+1:

Thanks @jpogran - looks good.


Get multiple properties inside the device information, which raises an exception

Only limited device information is available

MobileDeviceSharp.IDevice,"","","","",False,"",iPhone,xxxxxxxxxxxxxxxxxxxxxxxxxxxx,"iOS 15.1",MobileDeviceSharp.Battery,iPhone,iPhone,"iPhone10,6","iPhone X","Exception has been thrown by the target of an invocation.","Exception has been thrown by the target of an invocation.","Exception has been thrown by the target of an invocation.","Exception has been thrown by the target of an invocation.","Exception has been thrown by the target of an invocation.","Exception has been thrown by the target of an invocation.","Exception has been thrown by the target of an invocation.",3C2EFF92513E,"Exception has been thrown by the target of an invocation.","Exception has been thrown by the target of an invocation.","Exception has been thrown by the target of an invocation.","Exception has been thrown by the target of an invocation.",arm64,False,"1377717869504 (IDeviceHandle)",False

For certain protected information such as language or regional settings, the device must be paired with the computer. To do this, you must pair the device and do what libimobiledevice calls a handshake using a LockdownSession before using these properties. For that you need to use this method https://github.com/mveril/MobileDeviceSharp/blob/35a198bae2cf964b40d2d6dc99c1532a7b5c83e2/src/MobileDeviceSharp/LockdownSession.cs#L346 or one of these overloads and accept pairing on the iPhone if this is necessary.
This method returns a Task<bool> that runs until you accept the pairing.
Can you explain in more detail which properties you are interested in?
Sory for the delay of my response I don't see the notification.

Thanks for your reply, I succeeded. it is a great project.


feat(deps): replace @inquirer/confirm with prompts

prompts already used by jest and have smaller dependencies tree
https://npmgraph.js.org/?q=prompts
https://npmgraph.js.org/?q=inquirer-confirm

can you merge and publish new version?

Done! Thanks @andriyor for your contribution, and sorry the delay.


[TOPI][Hexagon] Implement quantized avgpool

Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.
cc @mehrdadh

cc: @csullivan; @Lunderberg; @kparzysz-quic

Please let me know if there are any additional comments. If not, can someone approve and merge it for me please?

cc @cconvey @mehrdadh, please take a relook of the updated files.

This PR introduces several TOPI-related functions (qnn_avg_pool2d_compute and qnn_avg_pool2d_schedule).  Does this PR make these functions available for compile-time consideration by TOPI?
I'm not very familiar with the mechanisms TVM uses for this, so apologies if I'm just missing how it happens.

This PR introduces several TOPI-related functions (qnn_avg_pool2d_compute and qnn_avg_pool2d_schedule). Does this PR make these functions available for compile-time consideration by TOPI?
I'm not very familiar with the mechanisms TVM uses for this, so apologies if I'm just missing how it happens.

That's correct. The PR does introduce several TOPI related functions. However, since they require inputs and outputs to be in 2d discontiguous buffer, they aren't yet available for use by OpStrategy. One of the issues here is that Relay is unable to handle complex layout needed for these discontiguous buffers and requires some additional work.

Thanks @jverma-quic , the PR is looking really good. I left one small suggestion, feel free to ignore it.
Once you're satisifed, I'm happy with getting this merged. You may want to ping @mehrdadh for that official review; I think he was waiting for my review to finish.

Thanks @cconvey! I really appreciate you taking time to review this PR and your detailed comments.

@cconvey, @mehrdadh, @kparzysz-quic, @TejashShah : I'm waiting to merge this PR. Unless there are additional comments, can  someone approve and merge it for me please? Thanks!

@jverma-quic sorry for the delay, looking at the PR now

@jverma-quic PR is merged! Thanks for your contribution!
Moving forward please use a meaningful PR description.
@cconvey thanks for the review!


Bar position

Hey,
the new settings look good, another idea for an option would be to define the bar position, for example [ ] - Top [ ] -Bottom.
What do you think?
This would include the Popup which moves or delete Spaces.

Thanks! This is a good suggestion, I'll add it soon.
I'll keep you updated here once its done.

I've just added a "Bottom bar" option in settings.


Revamp SCIM schemas in IS

Problem
At the moment SCIM attributes configurations are inconsistent in Identity Server.
The WSO2-defined SCIM attributes, which are mapped to local claims, are currently located in the Enterprise User schema. The Enterprise User schema is a well-defined schema extension provided in the SCIM specification RFC 7643 and should remain unaltered.
Approach
We have to resolve this problem by keeping the defined attributes in the enterprise schema and moving the attributes needed for the product functionalities to a custom schema.
There should be a separation between the schema that contains the WSO2-defined attributes and the custom SCIM attributes added by the users. This is because when we maintain a single schema, if a new WSO2 attribute is introduced to this schema in the future, and if the same attribute name has already been added by a user, it could lead to conflicts.
Therefore, we should maintain two distinct schemas:

A schema dedicated to WSO2-defined SCIM attributes.
A separate schema for custom SCIM attributes added by users.

Weekly Update:

Initiated the mail thread "Unification of SCIM Schemas in IS and Asgardeo"
Shared the proposal https://docs.google.com/document/d/1npkOi9oVTvsVwqPM1x3JYxppXJzLmY3VUxUr20wotVI/edit?usp=sharing
Shared the detailed design document https://docs.google.com/document/d/1UFqJqfv-QSMhaJAbuBNif4yZQg0DRGKX_3g84riZTbs/edit?usp=sharing

PRs:

https://github.com/wso2/carbon-identity-framework/pull/6140


Documentation: Enable validation report generation for this repository

Please select a category the issue is focused on?
Other
Let us know where something needs a refresh or put your idea here!
Need to add https://github.com/pharmaverse/admiral/blob/main/.github/workflows/common.yml#L27-L30 and https://github.com/pharmaverse/admiral/blob/main/.github/workflows/common.yml#L57-L62 to the check.y[a]ml workflow.

already exists - no action needed


add callback support for VQE, QAOA, QSVM.Variational, and add tests

Summary
Add callback support to let users access intermediate data of VQE, QAOA, and QSVM.variational
Details and comments

closed to avoid mess commits, reopen to another PR


Unresolved function or method autoSend()

Hi i have been trying to setup SMS send in my new project but i constantly get this error: Unresolved function or method autoSend() in my IDE. On my emulator i get
Typerror:null is not an object(evaluating '_reactNativeGetSmsAndroid.default.autoSend')

same here

same here

I am also having this issue. Has anyone been able to solve this?


Response of actual-equipment in cache differs from live

When user tried to retrieve the cache and live data for actual-equipment, observe mismatch.
API - /core-model-1-4:network-control-domain=cache/control-construct={mountName}/equipment={uuid}/actual-equipment
Tag:  Test_v1.1.2
Cache URL:
http://xxx:xx/core-model-1-4:network-control-domain=cache/control-construct=xxx/equipment=CTRL%20IduBoard%20Xpic%2032E1/actual-equipment

curl -X GET "http://xxx:xxx/core-model-1-4:network-control-domain=cache/control-construct=xxx/equipment=CTRL%20IduBoard%20Xpic%2032E1/actual-equipment" -H "accept: application/json" -H "user: User Name" -H "originator: Resolver" -H "x-correlator: 550e8400-e29b-11d4-a716-446655440000" -H "trace-indicator: 1.3.1" -H "customer-journey: Unknown value" -H "operation-key: Operation key not yet provided."

Live Url:

http://xxx:xx/core-model-1-4:network-control-domain=live/control-construct=xx/equipment=CTRL%20IduBoard%20Xpic%2032E1/actual-equipment

curl -X GET "http://xxx:xx/core-model-1-4:network-control-domain=live/control-construct=xx/equipment=CTRL%20IduBoard%20Xpic%2032E1/actual-equipment" -H "accept: application/json" -H "user: User Name" -H "originator: Resolver" -H "x-correlator: 550e8400-e29b-11d4-a716-446655440000" -H "trace-indicator: 1.3.1" -H "customer-journey: Unknown value" -H "operation-key: Operation key not yet provided."


Reporting bugs and issues easily

Place the template of the issues in a more visible place.

put this link somewhere visible!
https://github.com/CemrgDevelopers/CemrgApp/wiki/ISSUE_TEMPLATE.md

Commit 44f9d9c
Added link to the README.md file in the development branch. The following lines were added at the bottom of the file.
Report bugs and issues
 ----------------------
 1. Check our wiki page with instructions for [reporting bugs](https://github.com/CemrgDevelopers/CemrgApp/wiki/Reporting-bugs)
 2. Use our [issue report template](https://github.com/CemrgDevelopers/CemrgApp/wiki/ISSUE_TEMPLATE.md) to log your report


Linking to waffle board.

Not sure where to put the link to https://waffle.io/codeforhawaii/projects

Nevermind, looks like the projects board is more for people to get involved so using that.


Feature request: skipmissing keyword

Now it's hard to implement skipmissing
listingtable(
    df,
    :Conc => "Concentration (ng/mL)",
    rows = [:Formulation => "Formulation", :Subject => "ID"],
    cols = :Time => "Time (hr)",
    summarize_rows = :Formulation => [length => "N",
    Pair(x->mean(skipmissing(x)), "Mean"),
    Pair(x->std(skipmissing(x)),"SD"),
    Pair(x->median(skipmissing(x)) , "Median"),
    Pair(x->maximum(skipmissing(x)) , "Maximum"),
    Pair(x->minimum(skipmissing(x)) , "Minimum")]
)

also it lead to error when only missing data found in group.

You can use f ∘ skipmissing (written \circ + tab) for a short version of what you're doing, but if you want robustness against all-missing data, you can define a helper function like
function robust_skipmissing(f)
    return function(vec)
        all(ismissing, vec) && return Annotated("NC", "NC - Not computable", label = nothing)
        return (f ∘ skipmissing)(vec)
    end
end

data = DataFrame(
    concentration = [missing, 4.5, 2.0, 1.5, 0.1, missing, 3.2, 1.8, 1.2, 0.2],
    id = repeat([1, 2], inner = 5),
    time = repeat([0, 0.5, 1, 2, 3], 2)
)

listingtable(
    data,
    :concentration => "Concentration (ng/mL)",
    rows = :id,
    cols = :time => "Time (hr)",
    summarize_rows = [
        length => "N",
        robust_skipmissing(mean) => "Mean",
        robust_skipmissing(std) => "SD",
        robust_skipmissing(median) => "Median",
        robust_skipmissing(maximum) => "Maximum",
        robust_skipmissing(minimum) => "Minimum",
    ]
)


feat(talent trees): add basic talent trees

Type

[ ] Bug fix
[x] Feature
[ ] Refactor
[ ] Other (please describe):

Description
This PR adds Talent Tree items, which serve as the root for talents/advancement. Specialty items are replaced with the more generic Talent Trees.
Related Issue
Closes #143
How Has This Been Tested?
Created a new Talent Tree item called spy. Dragged on the talents from the compendium. Then switched the talent tree to view mode. Added the opportunist key talent to my test actor. Set skills to the appropriate values required for the first talents. Checked if the "Sure Outcome" and "Plausible Excuse" talents had the correct borders (indicating they are available), and clicked them to ensure they were added to the actor correctly.
Screenshots (if applicable)

Checklist:

[x] I have commented on my code, particularly in hard-to-understand areas.
[x] My changes do not introduce any new warnings or errors.
[x] My PR does not contain any copyrighted works that I do not have permission to use.
[x] I have tested my changes on Foundry VTT version: 12.331.

To do

[x] Make individual nodes editable
[x] Make connections removable
[x] Add tooltip with talent info on hover
[x] Add functionality to create new connection between existing nodes
[x] Make talent tree resizable
[x] Replace embedded document field with document uuid field
[x] Make connections derived from prerequisites
[x] Prevent adding the same item twice
[x] Register talent tree with each item for updating
[x] Add ability to pick a talent from the tree

This is great! Much more than a first pas ;) And I can't see any issues with the code that you've written. Really well executed.
I am curious about some structuring decisions though...

Firstly, was there not some way we could have leaned on existing libraries some how? e.g. D2/D3, ECharts, Google Charts, Mermaid? I know it wouldn't be quite as simple as plug and play, we'd need to figure out how to integrate the drag-and-drop, plus make sure they are style-able enough, but would it have saved a fair number of lines and custom component headache?
We seem to be looping through the collection a lot. Why aren't we grabbing descriptions, context, connections etc when the talent is added, then doing minimal functions (e.g. HTML Enriching) during prepare context? Also, could a lot of these be stored inside the ExtendedNode object in the first place? (I appreciate it may be worth keeping separate maps if it means we aren't adding unnecessary entries into the DataModel schema). I may be missing something key in the foundry item/sheet lifecycle though, so I just want to be sure. It could also be only minimal impact, I haven't loaded up a copy of the branch locally to see.

Good luck with the next phase!

* Firstly, was there not some way we could have leaned on existing libraries some how? e.g. D2/D3, ECharts, Google Charts, Mermaid? I know it wouldn't be quite as simple as plug and play, we'd need to figure out how to integrate the drag-and-drop, plus make sure they are style-able enough, but would it have saved a fair number of lines and custom component headache?

The rendering of the tree/connections wasn't actually all that complex to set up. I figured if I'd integrated some library I'd then have to figure out how to integrate that with drag-drop (specifically making nodes draggable), which seemed like a nightmare.

We seem to be looping through the collection a lot. Why aren't we grabbing descriptions, context, connections etc when the talent is added, then doing minimal functions (e.g. HTML Enriching) during prepare context? Also, could a lot of these be stored inside the ExtendedNode object in the first place? (I appreciate it may be worth keeping separate maps if it means we aren't adding unnecessary entries into the DataModel schema). I may be missing something key in the foundry item/sheet lifecycle though, so I just want to be sure. It could also be only minimal impact, I haven't loaded up a copy of the branch locally to see.

We could probably fold prepareNodeDescriptions in with extendNodeData but we'll always need to do it on prepareContext anyway as the items in the nodes can be updated independently of the talent tree.  The items aren't actually embedded in the tree (items can't embed other items), they're just referenced by uuid. Same goes for connections, they're derived from the prerequisites and those can be changed between renders.
In the end, we'll likely end up refactoring talent trees when we get to leveling so I'm not too worried about it.


numpy versions in conflict.... tensorflow vs cryoCARE

Hi, after installing cuda 11 environment.... pip is reporting this:
tensorflow 2.4.0 requires numpy~=1.19.2, but you have numpy 1.24.3 which is incompatible.
When importing tensorflow of this environment I get this:
(cryocare_11) pablo@youyou ~/software/forticlientsslvpn $ python
Python 3.8.16 | packaged by conda-forge | (default, Feb  1 2023, 16:01:55)
[GCC 11.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow
2023-04-24 13:33:32.362628: I tensorflow/stream_executor/platform/default/dso_loader.cc:49] Successfully opened dynamic library libcudart.so.11.0
/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/framework/dtypes.py:513: FutureWarning: In the future `np.object` will be defined as the corresponding NumPy scalar.
  np.object,
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/__init__.py", line 41, in <module>
    from tensorflow.python.tools import module_util as _module_util
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/__init__.py", line 46, in <module>
    from tensorflow.python import data
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/data/__init__.py", line 25, in <module>
    from tensorflow.python.data import experimental
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/data/experimental/__init__.py", line 96, in <module>
    from tensorflow.python.data.experimental import service
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/data/experimental/service/__init__.py", line 140, in <module>
    from tensorflow.python.data.experimental.ops.data_service_ops import distribute
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/data/experimental/ops/data_service_ops.py", line 25, in <module>
    from tensorflow.python.data.experimental.ops import compression_ops
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/data/experimental/ops/compression_ops.py", line 20, in <module>
    from tensorflow.python.data.util import structure
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/data/util/structure.py", line 26, in <module>
    from tensorflow.python.data.util import nest
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/data/util/nest.py", line 41, in <module>
    from tensorflow.python.framework import sparse_tensor as _sparse_tensor
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/framework/sparse_tensor.py", line 29, in <module>
    from tensorflow.python.framework import constant_op
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/framework/constant_op.py", line 29, in <module>
    from tensorflow.python.eager import execute
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/eager/execute.py", line 27, in <module>
    from tensorflow.python.framework import dtypes
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/tensorflow/python/framework/dtypes.py", line 513, in <module>
    np.object,
  File "/extra/miniconda3/envs/cryocare_11/lib/python3.8/site-packages/numpy/__init__.py", line 305, in __getattr__
    raise AttributeError(__former_attrs__[attr])
AttributeError: module 'numpy' has no attribute 'object'.
`np.object` was a deprecated alias for the builtin `object`. To avoid this error in existing code, use `object` by itself. Doing this will not modify any behavior and is safe.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations

Probably fixing the numpy in cryoCARE to numpy~=1.19.2 might fix it or increasing the tensorflow version in the documentation ?

After, downgrading numpy to:
pip install numpy==1.19.2
and then scipy to :
pip install scipy==1.9.3
tensorflow does not complain and detects my GPU... haven't gone further.

more data....
installing matplotlib<=3.63
Does not force the installation of numpy >=1.20.

Hi! I ran into the same problem. I made a PR that specifies the numpy version in the setup.py.

I hope that this is fixed with the latest 0.3.0 version. Otherwise reopen.


Cropped badge

Badge is cropped on few devices

Is this your problem: https://github.com/roughike/BottomBar/issues/708 ?
If so, there is an open issue and maybe this will be available in the next release. It would be nice if someone could give us an estimation when that will take place.


UX polish on the onboarding flow features page

Proposed changes:

There seems to be a lot of whitespace on the "Cody functionality" onboarding flow, so much so that it cuts the CTA to below the fold, which can be confusing. Can we make the chat image more horizontal (and less square) as well as decrease the whitespace so the CTA shows above the fold?
For the discord and github discussion links, let's make those open new tabs.

@danielmarquespt could I get your help fixing this so the CTA isn't cut off on small screens (1366x768 is a good benchmark)
CC: @thenamankumar @vdavid


No route for incoming payment

I can't seem to send a payment to phoenix from my well connected node. (current lnd + RTL)
I always receive "no_route" error immediatly. the amount does not matter as its the same even with an invoice with no amount.
I have 3 channels with plenty incoming balance in phoenix and in the past I did manage to receive a lightning payment that i sent from BLW (which created one of the channels).
currently I can't seem to be able to receive any payments that are sent by lnd with phoenix.
testing it with a different node + joule and it also tells me "unable to find node". I tried with the app open but it doesnt seem to make a difference.
Even if I force the first route as Acinq I still receive "no_route".
Any ideas why?

Can you share a payment_hash? We can then verify whether the payment reached our node or not.
But if the payment instantly failed, there is a chance the issue is your node's path-finding (which we'll be able to confirm when you share a payment_hash).
Can you also check your node's logs? There may be information in there about why the payment failed (if it's a path-finding failure on your side).

@t-bast It works now...
What changed?
maybe the channels werent confirmed?
or version 1.4.4 fixed it?
any ideas why it didn't work before but does now even though i didn't really change anything?

I just checked your invoice in our node's logs, the payment never reached the ACINQ node.
The issue is not in Phoenix nor on the ACINQ node, the issue is with your lnd node.
You should investigate your lnd logs to figure out why path-finding failed.
Can you paste your node's logs for this payment_hash (d3799f7bbd9a595a4a8d42677136086c90771e0051852c2e5b318b0cc38c6e01)?

Ok I just got 1 payment to work (100k sats) by switching of bad wifi and using 4g (i think). guess when your on wifi that just barely works that's a problem?
but immediatly after i tried another transaction and it fails (65432 sats)
INFO: PayReq => Payment Decode Received: {"destination":"02078e2f2d46ce41a8955e02e8761e6e4debcb2412286a5927891bce0d91f4d169","payment_hash":"913c7230e96197ba7c19a57f5217f51bb901f8242b83fc0b0b86b1de3231d9cd","num_satoshis":"0","timestamp":"1608123447","expiry":"604800","description":"","description_hash":"","fallback_addr":"","cltv_expiry":"9","route_hints":[{"hop_hints":[{"node_id":"03864ef025fde8fb587d989186ce6a4a186895ee44a926bfc370e2c366597a3f8f","chan_id":"18382512861721448809","fee_base_msat":1000,"fee_proportional_millionths":100,"cltv_expiry_delta":144}]}],"payment_addr":"TywTvJquhiosL2sXQCrnzcXV9iRBciRSSayjBrhpS5E=","num_msat":"0","features":{"9":{"name":"tlv-onion","is_required":false,"is_known":true},"15":{"name":"payment-addr","is_required":false,"is_known":true},"17":{"name":"multi-path-payments","is_required":false,"is_known":true},"51":{"name":"unknown","is_required":false,"is_known":false}}}
INFO: Channels => Send Payment Options: {"payment_hash_string":"913c7230e96197ba7c19a57f5217f51bb901f8242b83fc0b0b86b1de3231d9cd","final_cltv_delta":9,"amt":"65432","dest_string":"02078e2f2d46ce41a8955e02e8761e6e4debcb2412286a5927891bce0d91f4d169"}
INFO: Channels => Send Payment Response: {"payment_error":"no_route","payment_preimage":null,"payment_route":null,"payment_hash":"kTxyMOlhl7p8GaV/Uhf1G7kB+CQrg/wLC4ax3jIx2c0="}
ERROR: Channels(206) => Send Payment Error: "no_route"
2 of the channels i have in phoenix should be able to receive this tx and all channels are up and running

ERROR: Channels(206) => Send Payment Error: "no_route"

This indicates that your lnd node cannot find a route to Phoenix, so again, the error is not on the Phoenix side, it's in the path-finding of your lnd node. Your node doesn't even try to send the payment (this is confirmed on our side, the ACINQ node never received a payment attempt for that payment_hash).
Please open an issue in lnd and give them your node's logs, that should help them figure out why path-finding fails.
Maybe they internally "ban" your channel ids because they are private channels, or because a previous error was returned in the past.


audioldm2

Hi.
How do I save music to a file after the audioldm2 node?

its automatically saved in your output folder inside ComfyUI

its automatically saved in your output folder inside ComfyUI, i will add a saver node soon.

It also ignores the custom outputs path set in extra_model_paths.yaml.


support TCP heartbeat of client

What problem does this PR solve?
Issue Number: #1895
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:

Performance effects(性能影响):

Breaking backward compatibility(向后兼容性):

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

另外补充一下单测？

另外补充一下单测？

done

LGTM


Add AWS tags

@cnunciato Ah, I didn't realize this was only in the CI account. In that case, it doesn't matter. For the prod account, we would want the same set of tags we apply to the PR buckets in pulumi/docs


Update what's new for RC 1

Fixes #35600
Fixes #37105
Some links will be broken until blogs are published and API ref is updated.

Internal previews

📄 File
🔗 Preview link

docs/core/project-sdk/msbuild-props.md
MSBuild reference for .NET SDK projects

docs/core/runtime-config/compilation.md
Compilation config settings

docs/core/runtime-config/debugging-profiling.md
Runtime configuration options for debugging and profiling

docs/core/runtime-config/garbage-collector.md
docs/core/runtime-config/garbage-collector

docs/core/runtime-config/networking.md
Runtime configuration options for networking

docs/core/runtime-config/threading.md
Threading config settings

docs/core/runtime-config/wpf.md
Runtime configuration options for WPF

docs/core/whats-new/dotnet-8.md
What's new in .NET 8

Thank you @BillWagner!