Create process control scripts for Windows/Linux

Create an upstart script stop/start the PLS daemon at boot/shutdown.
investigate options for Windows installations that allow the script to start/stop at boot/shutdown time

upstart script added in b070402c32c399524e871c8cd25b8844bbc5f595

Leaving open if someone wants to commit OSX or Windows based scripts..

Thanks for adding this!
I wonder though if on Linux we should use systemd instead of upstart. That way we could hook into the existing Plex service.
I'm on Fedora, maybe the Ubuntu version of Plex doesn't use systemd?
mkdir /usr/lib/systemd/system/plexmediaserver.service.d

cat <<EOF > /usr/lib/systemd/system/plexmediaserver.service.d/lastfm-scrobbler.conf
[Unit]
Wants=plex.lastfm.scrobbler
After=plex.lastfm.scrobbler
EOF

cat <<EOF > /usr/lib/systemd/system/plex.lastfm.scrobbler.service
[Unit]
Description=Plex Media Server Scrobbler for Last.FM
After=network.target

[Service]
Environment=PLEX_LASTFM_SCROBBLER_HOME=/usr/lib/plexmediaserver
ExecStart=/bin/python "${PLEX_LASTFM_SCROBBLER_HOME}/scripts/plex-scrobbler.py"
User=plex
Group=plex
Restart=on-failure
RestartSec=5
StartLimitInterval=60s
StartLimitBurst=3

[Install]
WantedBy=multi-user.target
EOF

This is new to me, there will likely be mistakes - and I'm not sure how to handle sourcing the virtualenv - maybe the Environment should be read from plex_scrobble.conf to get a) the directory for the script and b) the directory for the virtualenv.
Let me know what you think :)

upstart script added in b070402
Does this mean you added a way to make this a service?
If so, what are the steps to enabling this service or start-up script?

@dannymichel if you are using a Windows based machine you might check out https://github.com/shiitake/Plax.FM which will run as a service.


Suggestion: (Implement prettier formatter on lint staged)

What problem do you want to solve?
This is simply to enhance developer experience by adding automated formatter on the code structure by adding it onto the pre-commit hook to format the code indentations, style, ..etc.
What do you think is the correct solution?
I'd like to implement this using prettier library and implement prettier configuration to be added on the project and also implement custom script for it to format all files on command
Participation

[X] I am willing to submit a pull request for this change.

Additional comments
Need to know first if we need this to be implemented and if I need to implement custom scripts for all file types similar to the eslint scripts for e.g lint:js or lint:md ..etc

I guess we currently don't have prettier configured in the repo and we are using some formatting rules from ESLint only for formatting purposes. stylelint for formatting stylesheets. Bringing in another tool for formatting wouldn't be great until we remove formatting rules coming in from other linting tools or rather not implement prettier. Would like @eslint/eslint-tsc to decide if we'd want to implement prettier or not.

I get that adding Prettier means reworking our current ESLint and Stylelint formatting rules. However, Prettier’s simplicity and consistency could really benefit the workflow. It ensures uniform formatting with minimal setup.
Adopting Prettier would mean removing redundant rules from ESLint and Stylelint, but I think the long-term gains in consistency and ease of use are worth it.
Happy to help with the transition if needed.

removing redundant rules from ESLint

Removing this line should do the work:
https://github.com/eslint/eslint.org/blob/0c6721d1cded58ac148147e04bdd8ea7b1b06744/eslint.config.js#L25


azure-cli-extensions adding aks_preview-0.5.92 wheel is failing with az-cli error

Hi Team,
I need to create a wheel file with aks-preview with 0.5.92 version. For that updated the "VERSION = 0.5.92" in "setup.py" and ran "setup.py bdist_wheel" and got the wheel file. When i tried to use the file and tried to import using the following command "run az extension add --source " getting the below error. Please do the needful.
"cli.azure.cli.core.azclierror: The 'None' extension version None is not compatible with your current CLI core version 2.40.0.
This extension requires a min of 2.44.0 CLI core.
Please run 'az upgrade' to upgrade to a compatible version.
az_command_data_logger: The 'None' extension version None is not compatible with your current CLI core version 2.40.0.
This extension requires a min of 2.44.0 CLI core.
Please run 'az upgrade' to upgrade to a compatible version."
Due to certain environment complications could not update CLI version currently.

route to CXP team

@ThiraviamR Apologies for the late reply. Thanks for reaching out to us and reporting this issue. Could you please upgrade your AzCLI to the most recent version and test ?

No problem. Due to environment constraints upgrading the CLI is not viable for us. Luckily i have got the golden build (https://azcliprod.blob.core.windows.net/cli-extensions/aks_preview-0.5.92-py2.py3-none-any.whl ) wheel file from the following link and that worked fine on installation. Thanks

@ThiraviamR Thanks for getting back. I am glad that you are unblocked now. We will now proceed with closure of this GitHub issue. If you need any further assistance on this issue in future, please feel free to reopen this thread. We would be happy to help.


Additional properties not allowed: schema (not conforming OpenAPI-Specification )

I have the following method definition
/shareMessageCreate:
    # binds a127 app logic to a route
    x-swagger-router-controller: message
    post:
      description: Creates share message
      # used as the method name of the controller
      operationId: shareMessageCreate
      parameters:
        - name: message
          in: formData
          description: Contains json representation of message
          required: true
          type: array
          schema:
            type: array
            items:
              $ref: '#/definitions/ShareMessage'

# complex objects have schema definitions
definitions:
  ShareMessage:
    properties:
      timestamp:
        type: integer
      text:
        type: string

I receive the following error:
API Errors:
  #/paths/~1shareMessageCreate/post/parameters/1: Not a valid parameter definition
    #/paths/~1shareMessageCreate/post/parameters/1: Not a valid parameter definition
      #: Additional properties not allowed: type
      #: Not a valid undefined definition
        #: Additional properties not allowed: schema
        #: Additional properties not allowed: schema
        #: Additional properties not allowed: schema
        #: Additional properties not allowed: schema
    #/paths/~1shareMessageCreate/post/parameters/1: Missing required property: $ref

1 error and 0 warnings

According to https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#body-parameters it is a valid definition of parameter or am I missing something?
Thank you.

Yes, but a formData is not a body parameter, and is currently restricted to primitives or arrays of primitives.  change in to body and you should be fine.


Logging to multiple logfire project simultaneously

Question
Is there any mechanism to perform logging to multiple logfire project simultaneously from the same app?
To give you an example:
I have a backend service and I have an associated logfire project to this backend (my_backend_logfire_proj)...
But for whatever reason I also want to log certain specifics events that occur in the same backend to a different logfire project.

Duplicate of https://github.com/pydantic/logfire/issues/195

@Mumbawa you can now do this using logfire.configure(local=True): https://logfire.pydantic.dev/docs/reference/api/logfire/#logfire.configure(local)

Thank you!


Range active indicator color not showing properly

Current behaviour

The color of active indicator for Range date picker remains light purple, while primary color is set to dark red...
How to reproduce?
const theme = {
  ...DefaultTheme,
  colors: {
    ...DefaultTheme.colors,
    primary: '#1F1717',
  },
};

Preview

Looks like you have to declare the color for primaryContainer...
Apparently it's not calculated automatically based on primary??
Can close now, if this is intended behaviour.

The underlying theming is derived from the parent library https://callstack.github.io/react-native-paper/docs/guides/theming.


Navigation Bar is gone when changing different storyboards

I have setup the viewcontrollers, main , left right in application
and setup when main controller is displayed. but once i clicked logout and then login back, the navigation bar  is gone and setNavigationBarItem is not working anymore.
How do i fix this?>

I have the same issue please anyone provide a solution for this issue.

@midhun93 i move to SWRevealViewController because its much more customizable. This library is good but not really that much because of its current implementation there is a limitation. SWRevealViewController is much much more better. You must try it.


Add TSAN suppression and harness

Bazel does not make it easy to add a file to every test as a dependency. But it does have --run_under, so we hijack this in order to make our suppression file. Later we may want to make a macro override for our test rules to add the suppression file if it grows too large.

This change is

FYI: #188


Cancelling from an edit form goes to the list not back to the item

When you click the cancel button in a 'Edit' form you're taken back to the list of items instead of going back to the item itself.
This was observed on the Edit Project form but likely happens for all edit forms.

:+1: Saving this one for Tuesday


disable hiv bulk upload if feature flag isn't on

BACKEND PULL REQUEST
Related Issue

Next part of #7207 that has the bulk of the upload validation logic
See #7299 for part 1
One more smaller PR to add in frontend device code lookup filtering for inactive diseases as called out in the ticket

Changes Proposed

Checks bulk upload submissions to see if a result includes a reference to a LOINC that maps to HIV

If yes, checks to see if the upload flag is on and throws an error if yes

Updates frontend guidance to inform users about this error (see this slack thread for more context)
Updates / refactors some tests / tangential objects

Additional Information

Code coverage is a couple of percentage points off, but can't think of anywhere to add a useful test. If anyone has an issue with this, lmk and I can rethink it

Testing

Deployed on dev4 (with the HIV flag turned off)
Add an HIV device and try a bulk upload pointing to that device
Notice validation error / guidance
Notice that a regular invalid upload still points to the invalid combination guidance
Notice that turning the feature flag on results in the file passing through

added an HIV device for testing / you can use this CSV to get the above
patient_id,patient_last_name,patient_first_name,patient_middle_name,patient_street,patient_street2,patient_city,patient_state,patient_zip_code,patient_county,patient_phone_number,patient_dob,patient_gender,patient_race,patient_ethnicity,patient_preferred_language,patient_email,accession_number,equipment_model_name,test_performed_code,test_result,order_test_date,specimen_collection_date,testing_lab_specimen_received_date,test_result_date,date_result_released,specimen_type,ordering_provider_id,ordering_provider_last_name,ordering_provider_first_name,ordering_provider_middle_name,ordering_provider_street,ordering_provider_street2,ordering_provider_city,ordering_provider_state,ordering_provider_zip_code,ordering_provider_phone_number,testing_lab_clia,testing_lab_name,testing_lab_street,testing_lab_street2,testing_lab_city,testing_lab_state,testing_lab_zip_code,testing_lab_phone_number,pregnant,employed_in_healthcare,symptomatic_for_disease,illness_onset_date,resident_congregate_setting,residence_type,hospitalized,icu,ordering_facility_name,ordering_facility_street,ordering_facility_street2,ordering_facility_city,ordering_facility_state,ordering_facility_zip_code,ordering_facility_phone_number,comment,test_result_status
1234,Doe,Jane,,123 Main St,,Birmingham,AL,35226,Jefferson,205-999-2800,1/20/1962,F,White,Not Hispanic or Latino,,,123,hiv device*,94558-4,Detected,12/20/2021 14:00,12/20/2021 14:00,12/20/2021 14:00,12/20/2021 14:00,12/20/2021 14:00,Nasal Swab,1013012657,Smith MD,John,,400 Main Street,,Birmingham,AL,35228,205-888-2000,01D1058442,My Urgent Care,400 Main Street,,Birmingham,AL,35228,205-888-2000,N,N,N,,N,,N,N,My Urgent Care,400 Main Street,Suite 100,Birmingham,AL,35228,205-888-2000,Test Comment,

@emyl3 fyi your comment about the asterisks interaction led me to write some more tests into the caching service


Feature: wireguard connect multple clusters and service discovery

Calico already has wireguard support between nodes.. I have not been able to find anything about being able to connect to other clusters (also using calico) ?
What I am hoping calico has (or is working on) is something like https://github.com/mandelsoft/kubelink

This is also very much like https://cilium.io/blog/2019/03/12/clustermesh - except I would like to keep calico and the KISS that it provides.. enabling me to inspect traffic routes in core Linux OS, networkpolicies in iptables etc.. But we truely are in dire need for a way to connect multiple clusters as well described in the cilium deep dive on clustermesh

I proposed this to @caseydavenport  and he agreed that 'all the bricks' are pretty much already in place in Calico - so it could be done in a perfect way, by (using Casey's wording below):

Use CoreDNS multicluster capabilities for service discovery of pods in other clusters.
Use the concept of an ExternalNode of some sort to represent nodes in other clusters (for wireguard tunnel configuration)
Use some other form of endpoint mirroring so that we know which pod IPs in the remote cluster should be routed to each remote node via the wireguard tunnel

I suspect that implementing this would not be quite as simple as the bullet points I mentioned in slack. I'll think on this some more - planning on at least making some progress on this in the form of external node support soon. That might be enough to start a proof of concept / prototype.


More noinl fixes

Codecov Report
Patch coverage: 100.00% and project coverage change: -5.04 :warning:

Comparison is base (433c14b) 77.68% compared to head (d5085b5) 72.65%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
- Coverage   77.68%   72.65%   -5.04%
==========================================
  Files          18       18
  Lines        8413     8012     -401
==========================================
- Hits         6536     5821     -715
- Misses       1877     2191     +314

Impacted Files
Coverage Δ

src/compiler.jl
75.27% <100.00%> (-3.67%)
:arrow_down:

... and 13 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


rethrow error on profile update

This is to avoid displaying the profile update notification when an error occured.

See https://github.com/FredericHeem/starhackit/pull/118


Unary - applied to a variable causes an exception in ConstexprFolder

Migrated from https://bugs.webkit.org/show_bug.cgi?id=188489:
At 2018-08-12T05:03:19Z<EMAIL_ADDRESS>wrote:
visitCallExpression() in ConstexprFolder calls unifyNode() on the argument, which can be a variableRef, which asks the "variable" parameter what its unifyNode() is, but it hasn't been set because we are doing this before the NameResolver or Checker has run.

At 2018-08-12T05:06:53Z<EMAIL_ADDRESS>wrote:
Perhaps the solution is not to call unifyNode in ConstexprFolder because the only time we use ConstexprFolder is before the "variable" parameter has been set.

At 2018-08-30T00:24:13Z<EMAIL_ADDRESS>wrote:
This is done.

At 2018-08-30T00:24:08Z<EMAIL_ADDRESS>wrote:
*** This bug has been marked as a duplicate of bug 188873 ***


Deploying with dispatchers

Currently we use dedicated deploy cheatcode. We should move this logic to deploy syscall in CairoHintProcessor so we can use cario dispatchers to interact with contracts

Can you provide a better description?

Done

This is not possible rn  -> #2101 , thus there is no use in doing this, closing


Replace pkg_resources with importlib

PR Summary:
I'm trying to fix some of the deprecation errors we're getting in the mosdef packages. One of them is coming from foyer with the use of pkg_resources.
pkg_resources will be removed in python 3.13
Note: This PR is not compatible with python 3.9, so we can't merge it until we want to drop 3.9 support and add 3.13.
PR Checklist

[ ] Includes appropriate unit test(s)
[ ] Appropriate docstring(s) are added/updated
[ ] Code is (approximately) PEP8 compliant
[ ] Issue(s) raised/addressed?

It looks like the entry points package in python 3.9 is different from python >= 3.10. So, that means we can't support both 3.9 and 3.13 whenever it's released. We can table these changes until we're ready to move on to python >= 3.10.

I don't think it's necessarily the right call here, but we could opt for using
from platform import python_version
to handle the differentiation from python 3.9-3.13 in this PR. Only if we didn't want to wait until we have to fully drop 3.9 to merge this PR.

I don't think it's necessarily the right call here, but we could opt for using from platform import python_version to handle the differentiation from python 3.9-3.13 in this PR. Only if we didn't want to wait until we have to fully drop 3.9 to merge this PR.

I say we just wait. Maybe at the next dev meeting we can start talking about the plan to drop 3.9 and add 3.13, which will be officially released next month I believe.


Explore extending the client

We have a couple of use-cases now,  which ask for extending the client:

Viewer Pattern / Permissions and Privacy Control
Computed Fields
Custom validation

We should explore how we can achieve these.

Related idea that might could fit into this is polymorphic relationships

Here's a use case I have:

Will the "ability to enforce ACL rules through table joins" be something that I can do with this new feature?


1.1.1: Can't connect between s_server and s_client with PSK

Like the title says: if you try to connect to an instance of s_server from s_client with PSK it doesn't work, failing with 32676:error:14201076:SSL routines:tls_choose_sigalg:no suitable signature algorithm:..\ssl\t1_lib.c:2484
It also fails when attempting to use PSK from code, but this is a nice way to provide a reproducer.
Commands run:
Console#1>> openssl.exe s_server -nocert -psk 123abc
Console#2>> openssl.exe s_client -psk 123abc

This is a known issue that we don't currently plan to fix (there is no easy fix).
The problem is that 1.1.1 defaults to using TLSv1.3. PSKs work quite differently in TLSv1.3 compared to TLSv1.2. One area of difference is that PSKs are associated with a hash. The spec requires that if you haven't otherwise specified a hash to use then you should default to SHA-256. The hash for a PSK must match the hash for the negotiated ciphersuite.
The default set of TLSv1.3 ciphersuites that openssl sends, and the selection criteria used means that, in a default configuration, s_server talking to s_client will always select a ciphersuite that uses SHA-384. This means that in the above example the PSK being sent will not be used because it is not compatible with the selected ciphersuite. Since no PSK is available OpenSSL will then attempt to complete a normal handshake. However, since no certificate is being used, this fails.
From a user perspective there are a couple of workarounds for this.

You can configure the ciphersuites so that a ciphersuite compatible with the PSK is used, e.g. by adding "-ciphersuites TLS_AES_128_GCM_SHA256" onto the end of your s_client or s_server command line
Use the new psk_session option to s_client/s_server which associates the PSK value to a given hash

From an openssl perspective there are a few things we could do to try and fix this:

Ignore the "should" in the spec so that the default hash used matches the default ciphersuite used. We don't like this idea. The should is there for a reason, and we shouldn't go off and do our own thing unless we've got a really good reason.
We could change the selection criteria so that by default we choose a ciphersuite that uses SHA-256. We don't like this idea either because it has implications beyond PSKs (it would affect uses where PSKs are not in use) and it has security impacts
We could make our selection criteria more intelligent so that if (and only if) a PSK has been offered by the client then we should prioritise ciphersuites that match the hash size for that PSK. This adds significant complexity to our ciphersuite selection code. At the point where ciphersuites are selected we haven't chosen a PSK yet - so we would have to leap ahead in our processing and go and peek at what PSKs are there in order to influence the ciphersuite selection choice. This would add significant complexity. It's also not clear to me whether that would actually always be desirable, e.g. if a PSK is available but we're also able to negotiate a normal connection without using that PSK, and that normal connection would use a "stronger" ciphersuite - what should we do?

None of the possible solutions are very appealing - so at the moment the view is that doing nothing is the best option. The possible fixes are all horrible and the user workaround is straight forward.

Nice writeup, @mattcaswell .  Should some edited version of the first paragraphs go into the docs?  (Not the list of why the various attempts to fix are bad.)

Yes, that's probably a good idea. We should leave this issue open until that is done.

Thanks for the reply! So the way I understand it now is that it's up to users of OpenSSL to specify a matching hash algorithm and/or ciphersuite if they're setting up a connection using PSK?
OT: This seems like a somewhat strange requirement from the RFC.

The -psk_session option is also undocumented in the manpages.

I've been thinking this one over and I've come up with an alternative fix that might be good enough (and is at least better than what we've got).
Previously I suggested this:

We could make our selection criteria more intelligent so that if (and only if) a PSK has been offered by the client then we should prioritise ciphersuites that match the hash size for that PSK.

The problem with this is that it adds quite a lot of complexity. However I think we could implement a weaker form of this check. It is simple to check whether a server has been configured with a certificate or not. Without one, it is only possible to connect via PSK. Also, if we are using the "old style" (i.e. OpenSSL 1.1.0 and below) callbacks, then we know that the PSK will default to using SHA-256. Therefore if both of those conditions hold then we could prefer SHA-256 during the ciphersuite selection.
We don't actually know what the client has offered at that point. E.g. there could be a problem if we have configured both "old style" and "new style" callbacks - in that case we don't actually know that the PSK will default to SHA-256. But I think that issue can probably be ignored for now.
PR coming up.

See #6215 for my proposed fix.


Support automatic classpath expansion in generated scripts

The launch script will fail [on Windows] if the list of application dependencies is too large. This is because the calculation of the CLASSPATH variable includes every single dependency; the concatenation of the final command line makes it too big for the Windows shell.
However since Java 7 it's possible to use a * as part of the classpath definition, which will instruct the JVM to load all JARs found at the specified location.
This is a request to add an option to select if classpath expansion is enabled or not (to keep with previous behavior and/or when classpath expansion is not desired for whatever reason).
In https://github.com/mojohaus/appassembler/blob/master/appassembler-maven-plugin/src/main/resources/org/codehaus/mojo/appassembler/daemon/script/unixBinTemplate
CLASSPATH="$REPO/*"

In https://github.com/mojohaus/appassembler/blob/master/appassembler-maven-plugin/src/main/resources/org/codehaus/mojo/appassembler/daemon/script/windowsBinTemplate
set CLASSPATH="%REPO%\*"

Hi Andres, can you please check https://www.mojohaus.org/appassembler/appassembler-maven-plugin/generate-daemons-mojo.html#useWildcardClassPath ? The * is possible since Java 6 as far as I know. Or do I miss something here?

No, no, you didn't miss anything, it was me. Somehow I completely missed that setting when looking at the documentation. It works as advertised. Closing.


python3Packages.millheater: 0.5.2 -> 0.6.0

Motivation for this change
Update to latest upstream release 0.6.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 140049 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.millheater
python39Packages.millheater


Question: How to highlight code lines?

I learn from README that we can get the editor instance through onEditorMount or getEditor(), then call APIs listed in https://microsoft.github.io/monaco-editor/api/interfaces/monaco.editor.istandalonecodeeditor.html to implement features like jump to a line or colorize lines.
I found that if APIs like editor.revealLineInCenter(line) is called inside onEditorMount, it is not working, right? So I call API like revealLine() through the instance returned by getEditor(). But I have difficulty at highlighting code lines, I keep googling and found the API colorizeModelLine() that maybe useful but find little examples about its usage, can you give me a hint?
I have posted a related question at: https://github.com/microsoft/monaco-editor/issues/1529, looking forward to answers.

I have managed to solve it by myself:
{
            range: new monaco.Range(
              conflictBlock.right_start,
              0,
              conflictBlock.right_end,
              0
            ),
            options: {
              isWholeLine: true,
              className: 'rightLineDecoration',
              marginClassName: 'rightLineDecoration'
            }
          }


Remove Guava and replace caching library with ExpiringMap.

Guava is not meant to be used on Android. The caching component included in Guava that you've used is optimized for servers with multiple connections/threads/etc.
To fix that I removed Guava completely as it's usage was minimal. I fixed the imports and "rewrote" the caching part to use the ExpiringMap library https://github.com/jhalterman/expiringmap. It has 287 methods and weighs 40KB compare to I don't wanna know what Guava clocks in on those. This should reduce compile time, reduce APK size and is just plain good practice to not use a huge library for one small thing.

Btw, I cannot test this properly because Soundcloud does not currently accept any new API clients so I cannot obtain the credentials for that.

@vpaliyX I hope you tested before the merge. As I said I wasn't able to test.

Looks like it's perfectly fine. Thank you for that!


Teachers are educators

@DaniEASmith PR has been copyedited and is ready for final review, could you please check and merge? Thanks!

@scanum I've reviewed this PR and have merged it. It'll be live later today.


Cannot drag fully zoomed composable

Drag gesture is enabled only when state.zooming == true and state.zooming = scale > minScale && scale < maxScale. This means that when some finite number is used for maxScale, fully zoomed composable cannot be dragged. Is this intentional? It feels more like a bug, state.zooming = scale > minScale will be more appropriate, I guess.

Thanks, it is a bug, I didn't notice that


Introduces fastlane, allowing easy distribution of precompiled binary for consumption with Carthage

Overview
This PR introduces the use of fastlane for testing and archiving Alamofire.
fastlane is best used in combination with bundler
Install Bundler
$ [sudo] gem install bundler

Install Fastlane
Start by installing it, after you've installed bundler, all you need to do is:
$ bundle install

Using Fastlane
$ bundle exec fastlane ios test
$ bundle exec fastlane macos test
$ bundle exec fastlane tvos test

Archiving Alamofire and creating a GitHub release
The script will prompt you for answers if you do not provide them.
$ bundle exec fastlane archive
[11:28:38]: -------------------------------------------------
[11:28:38]: --- Step: Verifying required fastlane version ---
[11:28:38]: -------------------------------------------------
[11:28:38]: Your fastlane version 2.37.0 matches the minimum requirement of 2.37.0  ✅
[11:28:38]: Platform 'tvos' is not officially supported. Currently supported platforms are [:ios, :mac, :android].
[11:28:38]: Platform 'watchos' is not officially supported. Currently supported platforms are [:ios, :mac, :android].
[11:28:38]: Driving the lane 'archive' 🚀
[11:28:38]: --------------------
[11:28:38]: --- Step: prompt ---
[11:28:38]: --------------------
[11:28:38]: A release name is required to create a GitHub release. Please provide a name:
5.5.5
[11:28:56]: --------------------
[11:28:56]: --- Step: prompt ---
[11:28:56]: --------------------
[11:28:56]: A release tag is required to create a GitHub release. Please provide a tag:
5.5.5
[11:29:00]: --------------------
[11:29:00]: --- Step: prompt ---
[11:29:00]: --------------------
[11:29:00]: What is the path of the GitHub repository?
bsarrazin/Alamofire
[11:29:10]: ----------------------
[11:29:10]: --- Step: carthage ---
[11:29:10]: ----------------------
[11:29:10]: $ carthage build --no-skip-current
[11:29:11]: ▸ *** xcodebuild output can be found in /var/folders/3n/0zjn1g0s2gbfflyvp1vjjfhr0000gn/T/carthage-xcodebuild.3lIltL.log
[11:29:15]: ▸ *** Building scheme "Alamofire macOS" in Alamofire.xcworkspace
[11:29:25]: ▸ *** Building scheme "Alamofire watchOS" in Alamofire.xcworkspace
[11:29:47]: ▸ *** Building scheme "Alamofire tvOS" in Alamofire.xcworkspace
[11:30:11]: ▸ *** Building scheme "Alamofire iOS" in Alamofire.xcworkspace
[11:30:37]: ----------------------
[11:30:37]: --- Step: carthage ---
[11:30:37]: ----------------------
[11:30:37]: $ carthage archive Alamofire --output build/Alamofire.framework.zip
[11:30:38]: ▸ *** Found Carthage/Build/Mac/Alamofire.framework
[11:30:38]: ▸ *** Found Carthage/Build/Mac/Alamofire.framework.dSYM
[11:30:38]: ▸ *** Found Carthage/Build/iOS/Alamofire.framework
[11:30:38]: ▸ *** Found Carthage/Build/iOS/Alamofire.framework.dSYM
[11:30:38]: ▸ *** Found Carthage/Build/watchOS/Alamofire.framework
[11:30:38]: ▸ *** Found Carthage/Build/watchOS/Alamofire.framework.dSYM
[11:30:38]: ▸ *** Found Carthage/Build/tvOS/Alamofire.framework
[11:30:38]: ▸ *** Found Carthage/Build/tvOS/Alamofire.framework.dSYM
[11:30:38]: ▸ *** Found Carthage/Build/Mac/D1ADB48A-32B8-3189-BF12-B51F0A537C58.bcsymbolmap
[11:30:38]: ▸ *** Found Carthage/Build/iOS/D43455C0-526B-3015-B00B-DB19F2070079.bcsymbolmap
[11:30:38]: ▸ *** Found Carthage/Build/iOS/86A6EE77-D28E-364B-AD78-E7397AA881EA.bcsymbolmap
[11:30:38]: ▸ *** Found Carthage/Build/iOS/EFDFDB25-2A98-3EB6-ABEB-B908B4CE154A.bcsymbolmap
[11:30:38]: ▸ *** Found Carthage/Build/iOS/0778389A-9014-322D-B9FD-09B19AE4C757.bcsymbolmap
[11:30:38]: ▸ *** Found Carthage/Build/watchOS/ADB2E81C-0755-362A-9E32-12414B3E38A6.bcsymbolmap
[11:30:38]: ▸ *** Found Carthage/Build/watchOS/5E925473-C762-3E62-A713-4522B9E0CB2A.bcsymbolmap
[11:30:38]: ▸ *** Found Carthage/Build/tvOS/444F697A-5784-3978-9119-2C516D80173C.bcsymbolmap
[11:30:38]: ▸ *** Found Carthage/Build/tvOS/C711CD96-E7B0-3CF0-961E-38FF9C08E094.bcsymbolmap
[11:30:40]: ▸ *** Created build/Alamofire.framework.zip
[11:30:40]: ------------------------
[11:30:40]: --- Step: git_branch ---
[11:30:40]: ------------------------
[11:30:40]: --------------------------------
[11:30:40]: --- Step: set_github_release ---
[11:30:40]: --------------------------------
[11:30:40]: Creating release of bsarrazin/Alamofire on tag "5.5.5" with name "5.5.5".
[11:30:40]: Will also upload assets ["build/Alamofire.framework.zip"].
[11:30:41]: Successfully created release at tag "5.5.5" on GitHub
[11:30:41]: See release at "https://github.com/bsarrazin/Alamofire/releases/tag/5.5.5"
[11:30:41]: Uploading Alamofire.framework.zip
[11:30:48]: Successfully uploaded Alamofire.framework.zip.
[11:30:48]: Successfully uploaded assets ["build/Alamofire.framework.zip"] to release "https://github.com/bsarrazin/Alamofire/releases/tag/5.5.5"

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | prompt                              | 17          |
| 3    | prompt                              | 4           |
| 4    | prompt                              | 10          |
| 5    | carthage                            | 86          |
| 6    | carthage                            | 2           |
| 7    | git_branch                          | 0           |
| 8    | set_github_release                  | 8           |
+------+-------------------------------------+-------------+

[11:30:48]: fastlane.tools finished successfully 🎉

The above script will produce:

Requirements
The script requires an environment variable named GITHUB_API_TOKEN. Alternatively, you can provide the token at the command line as such (along with the other values):
$ bundle exec fastlane archive github_api_token:xxx github_release_title:5.5.5 github_release_tag:5.5.5 archive_repository_path:"bsarrazin/Alamofire"
[11:37:15]: -------------------------------------------------
[11:37:15]: --- Step: Verifying required fastlane version ---
[11:37:15]: -------------------------------------------------
[11:37:15]: Your fastlane version 2.37.0 matches the minimum requirement of 2.37.0  ✅
[11:37:15]: Platform 'tvos' is not officially supported. Currently supported platforms are [:ios, :mac, :android].
[11:37:15]: Platform 'watchos' is not officially supported. Currently supported platforms are [:ios, :mac, :android].
[11:37:15]: Driving the lane 'archive' 🚀
[11:37:15]: ----------------------
[11:37:15]: --- Step: carthage ---
[11:37:15]: ----------------------
[11:37:15]: $ carthage build --no-skip-current
[11:37:15]: ▸ *** xcodebuild output can be found in /var/folders/3n/0zjn1g0s2gbfflyvp1vjjfhr0000gn/T/carthage-xcodebuild.c2QilB.log
[11:37:19]: ▸ *** Building scheme "Alamofire macOS" in Alamofire.xcworkspace
[11:37:30]: ▸ *** Building scheme "Alamofire iOS" in Alamofire.xcworkspace
[11:37:56]: ▸ *** Building scheme "Alamofire watchOS" in Alamofire.xcworkspace
[11:38:18]: ▸ *** Building scheme "Alamofire tvOS" in Alamofire.xcworkspace
[11:38:42]: ----------------------
[11:38:42]: --- Step: carthage ---
[11:38:42]: ----------------------
[11:38:42]: $ carthage archive Alamofire --output build/Alamofire.framework.zip
[11:38:42]: ▸ *** Found Carthage/Build/Mac/Alamofire.framework
[11:38:42]: ▸ *** Found Carthage/Build/Mac/Alamofire.framework.dSYM
[11:38:42]: ▸ *** Found Carthage/Build/iOS/Alamofire.framework
[11:38:42]: ▸ *** Found Carthage/Build/iOS/Alamofire.framework.dSYM
[11:38:42]: ▸ *** Found Carthage/Build/watchOS/Alamofire.framework
[11:38:42]: ▸ *** Found Carthage/Build/watchOS/Alamofire.framework.dSYM
[11:38:42]: ▸ *** Found Carthage/Build/tvOS/Alamofire.framework
[11:38:42]: ▸ *** Found Carthage/Build/tvOS/Alamofire.framework.dSYM
[11:38:42]: ▸ *** Found Carthage/Build/iOS/D43455C0-526B-3015-B00B-DB19F2070079.bcsymbolmap
[11:38:42]: ▸ *** Found Carthage/Build/Mac/D1ADB48A-32B8-3189-BF12-B51F0A537C58.bcsymbolmap
[11:38:42]: ▸ *** Found Carthage/Build/iOS/86A6EE77-D28E-364B-AD78-E7397AA881EA.bcsymbolmap
[11:38:42]: ▸ *** Found Carthage/Build/iOS/EFDFDB25-2A98-3EB6-ABEB-B908B4CE154A.bcsymbolmap
[11:38:42]: ▸ *** Found Carthage/Build/iOS/0778389A-9014-322D-B9FD-09B19AE4C757.bcsymbolmap
[11:38:42]: ▸ *** Found Carthage/Build/watchOS/ADB2E81C-0755-362A-9E32-12414B3E38A6.bcsymbolmap
[11:38:42]: ▸ *** Found Carthage/Build/watchOS/5E925473-C762-3E62-A713-4522B9E0CB2A.bcsymbolmap
[11:38:42]: ▸ *** Found Carthage/Build/tvOS/444F697A-5784-3978-9119-2C516D80173C.bcsymbolmap
[11:38:42]: ▸ *** Found Carthage/Build/tvOS/C711CD96-E7B0-3CF0-961E-38FF9C08E094.bcsymbolmap
[11:38:45]: ▸ *** Created build/Alamofire.framework.zip
[11:38:45]: ------------------------
[11:38:45]: --- Step: git_branch ---
[11:38:45]: ------------------------
[11:38:45]: --------------------------------
[11:38:45]: --- Step: set_github_release ---
[11:38:45]: --------------------------------
[11:38:45]: Creating release of bsarrazin/Alamofire on tag "5.5.5" with name "5.5.5".
[11:38:45]: Will also upload assets ["build/Alamofire.framework.zip"].
[11:38:45]: Successfully created release at tag "5.5.5" on GitHub
[11:38:45]: See release at "https://github.com/bsarrazin/Alamofire/releases/tag/5.5.5"
[11:38:45]: Uploading Alamofire.framework.zip
[11:38:53]: Successfully uploaded Alamofire.framework.zip.
[11:38:53]: Successfully uploaded assets ["build/Alamofire.framework.zip"] to release "https://github.com/bsarrazin/Alamofire/releases/tag/5.5.5"

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | carthage                            | 87          |
| 3    | carthage                            | 2           |
| 4    | git_branch                          | 0           |
| 5    | set_github_release                  | 8           |
+------+-------------------------------------+-------------+

[11:38:53]: fastlane.tools finished successfully 🎉

Hi @bsarrazin, thank you for putting this together. Unfortunately, we're not going to be moving over to Fastlane or prebuilt frameworks right now. For more info, please refer to #383 and #588.


deps: upgrade source map uploader to latest version

I don't believe so as the dependency range is still valid. In package.json: "@bugsnag/source-maps": "^2.0.0". This PR is solely the result of npm upgrade @bugsnag/source-maps

Re-pointed to next (from master)


transition conflicts with bootstrap carousel

if angular.module include ngFx then bootstrap carousel  prev() next() not work.
When not include , it 's work
code from bootstrap carousel  next button click
$scope.next = function() {
    var newIndex = (currentIndex + 1) % slides.length;

    //Prevent this user-triggered transition from occurring if there is already one in progress
    if (!$scope.$currentTransition) {
      return self.select(slides[newIndex], 'next');
    }
  };

when debug I see !$scope.$currentTransition return false so it not run into "return self.select(slides[newIndex], 'next');"

I'll look into it, any errors in the console?

Have no any errors output in console.

still working on this


Microsoft Phone System direct routing in GCC High

As per the M365 Roadmap, Microsoft Phone System direct routing is available now in GCC High. https://www.microsoft.com/en-us/microsoft-365/roadmap?featureid=54236

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2eab6a21-5773-fdba-1cad-c282e66556d7
Version Independent ID: 9b19ed7d-85f1-9f5e-b320-1749b414cd1b
Content: Plan for Microsoft 365 Government - GCC High deployments - Microsoft Teams
Content Source: Teams/plan-for-government-gcc-high.md
Service: msteams
GitHub Login: @LolaJacobsen
Microsoft Alias: lolaj

@steverlabs Thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@steverlabs Thank you for raising this issue. I will be looking into it.

@steverlabs Thank you for submitting feedback. We understand that this issue has been resolved.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.


[TEST] Improve setting of backupstore for test

What's the test to develop? Please describe
Currently, we are setting up the minio and nfs backupstore which is dependent to the testing environment. We need to think a solution to similar to deploying the nfs and minio in a pod and use them for testing.
Ref: https://github.com/longhorn/longhorn-tests/tree/master/manager/integration/deploy/backupstores

Closing it for now as per our design discussion


Adds GH login to user collection

Changes

oauth: save github login id to user collection
oauth: lookup the gh login id while registering/logging in a user
Unlike the primary email the github login id is immutable and is
therefore a better candidate to perform a user lookup

Codecov Report

Merging #389 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #389   +/-   ##
=======================================
  Coverage   89.44%   89.44%
=======================================
  Files          19       19
  Lines         796      796
=======================================
  Hits          712      712
  Misses         56       56
  Partials       28       28

Impacted Files
Coverage Δ

src/api/models/mockstore.go
65.9% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7c51ce...f3a6a30. Read the comment docs.

Does not seem like a good idea considering we may want to support oauth from various other services. Closing...


Add hook for parsing datetime objects.

A few things:

This breaks python3 support because of use of basestring
I imagine this breaks backwards compatibility
I'm curious if this has a noticeable impact performance impact when iterating over several thousand incidents for example.
Would it be nice to have the reverse work as well? (date/datetime objects isoformatted automatically) this would allow you to use the format you got back from the library towards building new or updating existing resources.

Updated PR with fixed Python 3 support.
On my hardware strptime takes around 10 µs per call. Taking in account that maximum page size is 100 items, network latency will be more noticeable for listing several thousands items.
Adding toggle option disabled by default makes sense for backward compatibility.
It seems reasonable to add reverse work as well, I will update my PR once again.

Updated PR with toggle option (disabled by default) and support for date/datetime objects as arguments (always enabled).


enn-dee

resolves #issueNumber
Checklist for profile addition

[ ] Name the PR fix: add <your-username>.
[ ] You've added file named your-username.json in the profiles directory.
[ ] You've linked the PR to the correct issue.

Other additions/changes

[ ] Changes made in this PR are mentioned below
[ ] Search previous suggestions before making a new one, as yours may be a duplicate.
[ ] I acknowledge that all my contributions will be made under the project's license.
[ ] I've read the contributing guidelines

This PR adds/fixes

Notes

Hey!
The issue number #1168 you provided is opened but someone else, and I can't find an issue opened by you. Please open an issue and also modify the image link as well.
If you have any doubt feel free to reach out
__        Summary: 🛠 This code needs a fix

Oh Yes, I didn't saw that one.


Fetch phone no from user

Hi @abhi3700,
you can't access to the user's phone number from a callback query update.
You should use message.contact.phone_number when an user sends you its (or a) contact.


UI errors in advanced policies page in admin portal

Describe your problem(s)
Following UI errors are identified in advanced policies page in admin portal.

The warning message is still visible even the relevant configs are added to deployment.toml.
Tables under header, query param and jwt condition policies are overflowed when the value has too many characters

Describe your solution

duplicate with https://github.com/wso2/product-apim/issues/12474


Selected color indicator missing on default color

Describe the issue
The default color for DLT columns does not show an indicator on the color
Failure Logs

Color indicator not visible on whilte color at all.
Maybe also change the color on that specific square


Loading failed when using Mistral model

Hi! When I use Mistral-7B-Instruct-v0-1 as the base_model, and run repllama, following training with Lora, I met some errors like: "size mismatch for base_model.model.model.layers.29.mlp.gate_proj.lora_B.default.weight: copying a param with shape torch.Size([0]) from checkpoint, while the shape in the current model is torch.Size([14336, 8])."
This error happened at this line: lora_model = PeftModel.from_pretrained(base_model, lora_name_or_path, config=lora_config).
My Transformers version is transformers==4.38.0, since 4.33.0 doesn't support Mistral.

If you have solved this problem, how did you solve it?

hi, @sunxiaojie99 I faced the same problem (using Mistral-7B model). If you have solved this problem, how did you solve it?

Hi~ Yes, I have solved this problem. In my case, after many attempts, I found that if I delete the "safetensors" file in the output directory, the model will load successfully.

Hi sorry for the late reply. Thanks to the latest PR from @ArvinZhuang the safetensor issue should be fixed. Feel free to follow up if there is still error with this.

I delete the "safetensors" file in the output directory, the model will load successfully.
Thank you for your support. It worked well for my issue.

And I will also try the revised code :)


[FEATURE] Screenshot Support

Support screenshots on window changes.

Currently being worked on.
Initial implementation: 6ccb34541c1aec1bac8db176d35a0bb0b3cdafcd

Full implementation: b402f6e7f099bec8984eda7952e3093e271bfd6f


Could you add ImageNet support to pre-trained model code ssl_pretrain.py?

Dear authors, I'm using your pre-trained model code ssl_pretrain.py and hope to apply it on ImageNet dataset. However, I noticed currently the code does not support ImageNet dataset.Would it be possible to add the support? Please let me know if you have any plans for this. Thanks!

Sorry for the late reply. We don't have a plan to support the pretraining on the ImageNet dataset, as the cost will be huge and there are already some well-established code repositories and pre-trained models out there.


Cropping stops working when someone seeks in syncplay.

As soon as a friend in the party does something that messes up the video, like seeking or pause, the script stops working and I have to leave the syncplay party and rejoin.

Hello, I'll investigate in a few days, already notice some rare case when this happened.

The commit closed the issue automatically, let me know if it's not fix.

Thanks, I'll let you know if this reoccurs or whether its fixed!

This appears to be fixed.


Create dockerfile

Closes #1
See the website running at http://rocketleaguemapmaking.com
Any questions or clarification requests please post here prior to merge.

Netifly is failing because I removed yarn and modified the package json to be more in line with the general guidelines. Can we customise netlify checks to use npm i instead of yarn install and use npm run docs:build instead of yarn create:docs?

Branch is ready for merge


Simplify the check, and remove the warning, for the nativeImageDecoderSupport API parameter

As discussed in PR https://github.com/mozilla/pdf.js/pull/8982#discussion_r142392423.
TODO

[x] Check if we possibly need to include core-js polyfills for Object.values and/or Array.includes.

/botio-linux preview

/botio test

Good improvement!


Fix standard pagination

Notes for Reviewers
This PR fixes #
Signed commits

[ ] Yes, I signed my commits.

After release our all tables can have the standard pagination


Update micro version

Would you mind bumping the version and running cargo publish?
That would allow my repo to depend on your crate instead of github.
Thanks a lot :)

Released 0.1.1

Thanks 👍


Get refresh_token automatically based on the username and password

Currently, after the refresh_token expires, the app automatically generates a new one. However, when you restart Home Assistant, it actually picks up the old one (the one that's stored in your config file). As such, the integration typically fails after some time, at the next Home Assistant restart.
I've changed the config to be able to specify your username and password, and it will get the first refresh_token automatically. Tested with my local HA and everything seems to be working smoothly.

Wow! Fantastic stuff! I checked it out and it works great! It has been running now for 10min. I will let you know in a couple of days if it appears to be fetching new token as excepted but it looks good. Thank you @rusucosmin ! 🥇

I see "my guard notification" has a notification that I can't see in the app. In the app it is all green and if I view firmware version it doesn't say anything about a new version here. I'm using firmware version: 01.51.Z22.0400.0101
This is what I get inside HA:

Hi! Thanks for testing it out 🙌!
That does seem strange. I just checked and my firmware version is
01.44.Z22.04000101 - so mine is older but it says I’m on the latest one.
Maybe because I’m in Romania and firmwares differs across countries?
Another thing I want to ask: do you have the Micro Leakage feature turned
on? Seems like your notification relates somehow to that feature?
Best,
Cosmin
On Sun, May 28, 2023 at 10:13 Peter Norlander @.***>
wrote:

I see "my guard notification" has a notification that I can't see in the
app. In the app it is all green and if I view firmware version it doesn't
say anything about a new version here. I'm using firmware version:
01.51.Z22.0400.0101
This is what I get inside HA:
[image: image]
https://user-images.githubusercontent.com/1375002/241513915-2c2d129d-010e-45b8-b22e-0853b1e292d6.png
—
Reply to this email directly, view it on GitHub
https://github.com/gkreitz/homeassistant-grohe_sense/pull/31#issuecomment-1565951365,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLVW5ZQ3C6IXU76PIKMWJ3XIL3KPANCNFSM6AAAAAAYRFQI2U
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Best,
Cosmin

Hi!
It feels odd to have different FW versions for countries, I would think it
would just be configs but sure, that may be the case.
I have the micro leakage feature enabled and it has actually been pretty
good. And it has always been in sync (when I have bothered to setup a
token) so this is new for me that it reports something that the app
doesn't. Usually they have been in good sync.
My biggest issue with this integration however (except for the one you
fixed!) is that the water consumption isn't updating on HA. It is still now
the same value as when I rebooted HA. If I reboot it will probably update
again but that isn't really what I was hoping for. 😉 Do you have the same
issue? The Grohe app is up to date.
Regards
Peter
On Sun, 28 May 2023, 21:08 Cosmin Rusu, @.***> wrote:

Hi! Thanks for testing it out 🙌!
That does seem strange. I just checked and my firmware version is
01.44.Z22.04000101 - so mine is older but it says I’m on the latest one.
Maybe because I’m in Romania and firmwares differs across countries?
Another thing I want to ask: do you have the Micro Leakage feature turned
on? Seems like your notification relates somehow to that feature?
Best,
Cosmin
On Sun, May 28, 2023 at 10:13 Peter Norlander @.***>
wrote:

I see "my guard notification" has a notification that I can't see in the
app. In the app it is all green and if I view firmware version it doesn't
say anything about a new version here. I'm using firmware version:
01.51.Z22.0400.0101
This is what I get inside HA:
[image: image]
<
https://user-images.githubusercontent.com/1375002/241513915-2c2d129d-010e-45b8-b22e-0853b1e292d6.png
—
Reply to this email directly, view it on GitHub
<
https://github.com/gkreitz/homeassistant-grohe_sense/pull/31#issuecomment-1565951365
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABLVW5ZQ3C6IXU76PIKMWJ3XIL3KPANCNFSM6AAAAAAYRFQI2U
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Best,
Cosmin
—
Reply to this email directly, view it on GitHub
https://github.com/gkreitz/homeassistant-grohe_sense/pull/31#issuecomment-1566232720,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKPWGVMMNPCJ4A2XCXZJZDXIOPB3ANCNFSM6AAAAAAYRFQI2U
.
You are receiving this because you commented.Message ID:
@.***>

Hi Cosmin,
Mine still hasn't updated, it's still the same value as yesterday.
If you could investigate that would be awesome!
/Peter
On Mon, 29 May 2023, 09:31 Cosmin Rusu, @.***> wrote:

Yeah - I have the same issue. It seems like the consumption is only updated
every day, which is why it won't always be up to date. I believe the app
updates itself every 15mins or so. It might be easy to add that too - I'll
set some time aside the next weekend to investigate.
Best,
Cosmin
On Mon, May 29, 2023 at 12:12 AM Peter Norlander @.***>
wrote:

Hi!
It feels odd to have different FW versions for countries, I would think
it
would just be configs but sure, that may be the case.
I have the micro leakage feature enabled and it has actually been pretty
good. And it has always been in sync (when I have bothered to setup a
token) so this is new for me that it reports something that the app
doesn't. Usually they have been in good sync.
My biggest issue with this integration however (except for the one you
fixed!) is that the water consumption isn't updating on HA. It is still
now
the same value as when I rebooted HA. If I reboot it will probably update
again but that isn't really what I was hoping for. 😉 Do you have the
same
issue? The Grohe app is up to date.
Regards
Peter
On Sun, 28 May 2023, 21:08 Cosmin Rusu, @.***> wrote:

Hi! Thanks for testing it out 🙌!
That does seem strange. I just checked and my firmware version is
01.44.Z22.04000101 - so mine is older but it says I’m on the latest
one.
Maybe because I’m in Romania and firmwares differs across countries?
Another thing I want to ask: do you have the Micro Leakage feature
turned
on? Seems like your notification relates somehow to that feature?
Best,
Cosmin
On Sun, May 28, 2023 at 10:13 Peter Norlander @.***>
wrote:

I see "my guard notification" has a notification that I can't see in
the
app. In the app it is all green and if I view firmware version it
doesn't
say anything about a new version here. I'm using firmware version:
01.51.Z22.0400.0101
This is what I get inside HA:
[image: image]
<

https://user-images.githubusercontent.com/1375002/241513915-2c2d129d-010e-45b8-b22e-0853b1e292d6.png

—
Reply to this email directly, view it on GitHub
<

https://github.com/gkreitz/homeassistant-grohe_sense/pull/31#issuecomment-1565951365

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/ABLVW5ZQ3C6IXU76PIKMWJ3XIL3KPANCNFSM6AAAAAAYRFQI2U

.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Best,
Cosmin
—
Reply to this email directly, view it on GitHub
<

https://github.com/gkreitz/homeassistant-grohe_sense/pull/31#issuecomment-1566232720

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AAKPWGVMMNPCJ4A2XCXZJZDXIOPB3ANCNFSM6AAAAAAYRFQI2U

.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
<
https://github.com/gkreitz/homeassistant-grohe_sense/pull/31#issuecomment-1566264938
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ABLVW52Q4YBZNPPYTTYVJO3XIO5VNANCNFSM6AAAAAAYRFQI2U
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/gkreitz/homeassistant-grohe_sense/pull/31#issuecomment-1566688645,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKPWGVRIQ3V6SZ27H7V7L3XIRGDXANCNFSM6AAAAAAYRFQI2U
.
You are receiving this because you commented.Message ID:
@.***>

Hi again Cosmin,
An update from me. None of the values has updated for four days now. So I triggered a manual restart of HA and then it failed to generate a new token for me and thus was unable to setup the integration. Any idea what I have done wrong?
Logs:
2023-06-01 22:01:13.126 ERROR (MainThread) [custom_components.grohe_sense] Grohe sense refresh token is invalid (or expired), please update your configuration with a new refresh token
2023-06-01 22:01:13.687 ERROR (MainThread) [homeassistant.setup] Error during setup of component grohe_sense
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 256, in _async_setup_component
result = await task
File "/config/custom_components/grohe_sense/init.py", line 76, in async_setup
await initialize_shared_objects(hass, await get_token(hass, config.get(DOMAIN).get(CONF_USERNAME), config.get(DOMAIN).get(CONF_PASSWORD)))
File "/config/custom_components/grohe_sense/init.py", line 89, in initialize_shared_objects
locations = await auth_session.get(BASE_URL + f'locations')
File "/config/custom_components/grohe_sense/init.py", line 144, in get
return await self._http_request(url, auth_token=self, **kwargs)
File "/config/custom_components/grohe_sense/init.py", line 157, in _http_request
token = await auth_token.token()
File "/config/custom_components/grohe_sense/init.py", line 133, in token
refresh_response = await self._http_request(BASE_URL + 'oidc/refresh', 'post', headers=headers, json=data)
File "/config/custom_components/grohe_sense/init.py", line 170, in _http_request
raise OauthException(response.status, await response.text())
custom_components.grohe_sense.OauthException: (401, '{"code":401,"message":"Unauthorized - The token was not validated by the Identity Provider"}')

Hi again,
I restarted my HA again today and then the token was generated successfully again, no errors.
I can also confirm that I only get updates upon restarting HA. Water usage has only been updated those few times that I have restarted.
Regarding the discussion about the notifications from "my guard". It has now been updated to instead say "Maximum volume reached Maximum volume reached" and that was actually the last notification I got, but that warning was triggered the day before. So that notification has been cleared in the app and should no longer be visible.

Hi Cosmin,
Finally got some time now during the summer? Nice! I know the feeling! :)
I installed your fixes but now it won't run for me? Can I extend the logs somehow because this is all I get:

And all Grohe entities has been removed

Any idea?

HI! Just fixed this. We'll have to wait a few days for the refresh token to expiry before we can see if this works or not

Hi Cosmin,
I pulled your fix and now the integration loads correctly again. But I still see the same behavior as I had last:

The usage value seems to be stale, hasn't updated now for 2 hours even though it is changed in the app.
It shows me an old value for the notification. The "Maximum volume reached" warning I got here two days ago and it has been cleared in the app so it shouldn't be showing here.

Yeah - I have the same behaviour. Will check it out next week.
Best,
Cosmin
On Thu, Jul 20, 2023 at 21:35 Peter Norlander @.***>
wrote:

Hi Cosmin,
I still have the same values, same values as yesterday. But just to be
straight with you, I had the same issues with the other main branch as
well. So I can just confirm that I don't need to get a token manually
anymore, but it doesn't make the integration much more useful for me.
Do you have the same behavior? Or how often does it update for you?
Regards
Peter
—
Reply to this email directly, view it on GitHub
https://github.com/gkreitz/homeassistant-grohe_sense/pull/31#issuecomment-1644407040,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABLVW55FTOSVYVJ5QKQW363XRF26ZANCNFSM6AAAAAAYRFQI2U
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Best,
Cosmin

Hi Cosmin,
I updated HA from 2023.7 to 2023.8 the evening of the 17:th and after that it suddenly started to work! Now the water values has been updated very well! Check below for history! :) So right now the only thing that seems off is that notification for the main unit. I don't have any notifications that are unread (I used the app to scroll back all notifications until the date of setup and verified) but it still gives me notifications.
But I would like to vote that this PR gets merged with the master branch!

Regards
peter


removed unneeded rm in update.sh

ln with '-f' flag removes existing destination files, so there is no reason to use 'rm -f'

For some reason this only works (for me) in this form:
ln -fs -T $REVISION/chrome-linux/ ./latest
(that is, -T needed)
else the symlink is not updated.

@JelF Is there any reason to use the "-T" flag? Reading the man doesn't seem to give me a rational reason for it.
I'm looking to ship your changa at https://github.com/chromium-unofficial-latest-linux/chromium-latest-linux

I've shipped it without the "-T" here: https://github.com/chromium-unofficial-latest-linux/chromium-latest-linux/commit/5415b6df944c9e8623f6c03fd4ccd2bbde5a7996

@JelF Is there any reason to use the "-T" flag? Reading the man doesn't seem to give me a rational reason for it.

Sory for late response. If latest is a directory for a reason, without -T it possibly will link to latest/chrome-linux.


Add-views

In this PR :

I add the Views associated with the Models and Controllers I've already created for my Blog App.

Thank you @brainconnect93


[ALLUXIO-2702]Specify null variable in DataFileChannel.java precondition check

https://alluxio.atlassian.net/browse/ALLUXIO-2702

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14659/
Test FAILed.

alluxio-bot, check this please

alluxio-bot, check this please

@lijunyou could you sign the contribution license agreement?

sure,i have done this 8 days ago

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15061/
Test FAILed.

alluxio-bot, check this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15160/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/15161/
Test PASSed.


cmd/argument.go: Added back support for single Target parameters.

Now that I think about it, this is kind of useless


Run make to update files

This runs make on the repo to generate files and run the license header.
Note that this renames Dockerfile.cc to Dockerfile.crosstestcc to prevent license-header from adding a header to the Dockerfile.

@jhump @Alfus was doing some dependabot updates and noticed a few files being changed when I ran make. Putting these files in their own PR for your review.


Rule criteria doesn't work with custom header

SUMMARY
The doc states:

If the criteria key contains any special characters (like -) then use the dictionary lookup format for specifying the criteria key. In case of a webhook based rule it is typical for the header of the posted event to contain such values:

criteria:
trigger.headers['X-Custom-Header']:
type: "eq"
pattern : "customvalue"

So I was trying a rule to receive a simple GitHub issues webhook, with the criteria defined like so:

But the rule is not run.
I know I have defined the webhook correctly, because if I changed the criteria to something else, like trigger.body.action eq opened, it works.
STACKSTORM VERSION
Paste the output of st2 --version:
st2 3.3dev (201c05882), on Python 3.6.9
OS, environment, install method
Post what OS you are running this on, along with any other relevant information/

e.g. Docker, Vagrant, Kubernetes, etc. Describe how you installed ST2
e.g. one-line install, custom install, etc -->

Installed on Kubernetes cluster using Helm
Steps to reproduce the problem
Show how to reproduce the problem, using a minimal test-case. Make sure to include any content
(pack content - workflows, actions, etc.) which are needed to reproduce the problem.

I have GitHub pack installed
create a rule:

webhook trigger w/ url = github
criteria (as above)
action set to github.add_comment

Expected Results
What did you expect to happen when running the steps above?
Rule runs the action upon receiving an issues webhook from GitHub
Actual Results
What happened? What output did you get?
Nothing runs
Making sure to follow these steps will guarantee the quickest resolution possible.
Thanks!

I have managed to get this to work on a StackStorm 3.3 system with python 2. Example rule
---
  name: "test_webhook"
  enabled: true
  pack: amanda
  description: "Test hook"

  trigger:
    type: "core.st2.webhook"
    parameters:
       url: sampleamanda

  criteria:
    trigger.headers['X-Parse-Application-Id']:
      type: 'eq'
      pattern: 'hello'

  action:
    ref: core.echo
    parameters:
      message: 'Found header'

Tested with curl:
curl -H "St2-Api-Key: " -k -H 'content-type: application/json' -H "X-Parse-Application-Id: hello" -d '{"arg1":"HELLOAMANDA"}' https://<IP_ADDRESS>/api/v1/webhooks/sampleamanda

I just installed the pack on a CentOS 8.1 python3 and installing the rule from the pack then all was fine.

Sorry but I'm new to stackstorm, so I'm not really sure how to create a rule aside from doing it via the UI.

I think I might have found the problem.
Could you define the rule as X-Github-Event-Id and see if that works. (i.e. Github not GitHub).
I managed to reproduce the problem with the rule and curl sending in X-GitHub-Event-Id. But if I changed the rule to match X-Github-Event-Id then it worked. It is possible that could be a curl problem, but I think that it might be something along the path or code that translates the header id to X-Github-Event-Id

Nice, it works.  Thank you.
Just for the record on GitHub it shows the header is X-GitHub-Event

@amanda11 Based on your research and discussion in Slack, turns out the original issue is that StackStorm treats headers in a case-sensitive way, while according to RFC http headers are case-insensitive and so X-Github-Event vs x-github-event or X-github-event are the same headers.
Can you please open a dedicated issue/bug report so we don't forget about it?
If you're interested in fixing it, - that would be nice too!
Also, it's a great find!

@makandre I assume this could be closed as resolved. Feel free to re-open, if needed.
Additionally @amanda11 created a separated issue in https://github.com/StackStorm/st2/issues/4998 about treating http header as case-insensitive items, according to RFC.


switch to relying on etcd info in openshift-config

No resource we use should be located in kube-system anymore
/assign @mfojtik

/lgtm

terraform
/retest


Docs update and move

fixes #1255. moves docs and changes them to look like other spring projects'

Codecov Report

Merging #1257 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1257   +/-   ##
=========================================
  Coverage     67.45%   67.45%
  Complexity     1314     1314
=========================================
  Files           186      186
  Lines          5387     5387
  Branches        547      547
=========================================
  Hits           3634     3634
  Misses         1521     1521
  Partials        232      232

Flag
Coverage Δ
Complexity Δ

#integration
?
?

#unittests
67.45% <ø> (ø)
1314 <ø> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbdadd...c268fe8. Read the comment docs.


Update PMO guide with Native app details

Was missing the step to install/use steal-platform and to add
place-my-order-assets to the list of files copied into the build
directory.

This closes #483


Disabling jobs module

According to the docs it should be possible to disable the jobs module by removing the module.jobs = github.com/robfig/revel/modules/jobs line from app.conf.
I've tried this. But on startup revel still prints Go to /@jobs to see job status. and my jobs are being run.
Bug?

TODO

[ ] refactor ProcessSource() to selectively process app code as needed
[ ] verify this fixes the unexpected loading of modules like jobs

If your code imports from jobs, then the builder will pull in the jobs module and start them.
It would be better to have a configuration setting to enable or disable adding the jobs.


Replace ByteBuffer with int[] for group-by key

RowUpdater in GroupByQueryEngine uses ByteBuffer for group by key. replacing it with int[] seemed faster and uses smaller footprint.
ByteBuffer
Benchmark                                     (numSegments)  (rowsPerSegment)  (schemaAndQuery)  Mode  Cnt       Score       Error  Units
GroupByBenchmark.queryMultiQueryableIndex                 4            100000           basic.A  avgt   25  548195.687 ± 23942.989  us/op
GroupByBenchmark.querySingleIncrementalIndex              4            100000           basic.A  avgt   25  322880.320 ± 14818.112  us/op
GroupByBenchmark.querySingleQueryableIndex                4            100000           basic.A  avgt   25  244786.136 ± 13154.709  us/op

int array
Benchmark                                     (numSegments)  (rowsPerSegment)  (schemaAndQuery)  Mode  Cnt       Score       Error  Units
GroupByBenchmark.queryMultiQueryableIndex                 4            100000           basic.A  avgt   25  509435.673 ± 22015.450  us/op
GroupByBenchmark.querySingleIncrementalIndex              4            100000           basic.A  avgt   25  293420.200 ±  7727.087  us/op
GroupByBenchmark.querySingleQueryableIndex                4            100000           basic.A  avgt   25  199744.396 ±  9634.891  us/op

@navis we are rewriting groupBy right now: https://github.com/druid-io/druid/pull/2998

@fjy The patch is using ByteBuffer for key either. If this simple replacement has some effect on performance, it will be like that also in #2998

I've did some similar test with HyperLogLogCollector, which uses ByteBuffer.
Benchmark                                              (numSegments)  (rowsPerSegment)  (schemaAndQuery)  Mode  Cnt        Score       Error  Units
TimeseriesBenchmark.queryFilteredSingleQueryableIndex              1            750000           basic.A  avgt   25    25100.436 ±  1620.870  us/op
TimeseriesBenchmark.queryMultiQueryableIndex                       1            750000           basic.A  avgt   25   189828.354 ± 12740.761  us/op
TimeseriesBenchmark.querySingleIncrementalIndex                    1            750000           basic.A  avgt   25  1726906.360 ± 91623.333  us/op
TimeseriesBenchmark.querySingleQueryableIndex                      1            750000           basic.A  avgt   25   204556.793 ± 14508.094  us/op

By replacing ByteBuffer to five columns + byte[],
Benchmark                                              (numSegments)  (rowsPerSegment)  (schemaAndQuery)  Mode  Cnt        Score        Error  Units
TimeseriesBenchmark.queryFilteredSingleQueryableIndex              1            750000           basic.A  avgt   25    23485.673 ±   2061.591  us/op
TimeseriesBenchmark.queryMultiQueryableIndex                       1            750000           basic.A  avgt   25   179789.402 ±  12704.263  us/op
TimeseriesBenchmark.querySingleIncrementalIndex                    1            750000           basic.A  avgt   25  1272280.840 ± 100677.017  us/op
TimeseriesBenchmark.querySingleQueryableIndex                      1            750000           basic.A  avgt   25   173549.084 ±  12147.194  us/op

Can see some changes in number, especially for IncrementalIndex.
For the reference, this is after removing HLL aggregator,
Benchmark                                              (numSegments)  (rowsPerSegment)  (schemaAndQuery)  Mode  Cnt       Score       Error  Units
TimeseriesBenchmark.queryFilteredSingleQueryableIndex              1            750000           basic.A  avgt   25   23912.216 ±  1884.648  us/op
TimeseriesBenchmark.queryMultiQueryableIndex                       1            750000           basic.A  avgt   25   81740.830 ±  7043.293  us/op
TimeseriesBenchmark.querySingleIncrementalIndex                    1            750000           basic.A  avgt   25  484488.713 ± 20284.775  us/op
TimeseriesBenchmark.querySingleQueryableIndex                      1            750000           basic.A  avgt   25   79206.648 ±  5434.338  us/op

@navis The HLL effect looks pretty big, that's cool! What change did you make exactly?
btw, the v2 groupBy stuff does a lot less ByteBuffer duping/slicing than the v1 groupBy stuff so the effect might not be as big there.

This change looks good to me assuming we can get consensus on the comment chain in https://github.com/druid-io/druid/pull/3111#discussion_r66278695.

hll-array.txt
@gianm attached the patch I've used. it's just done for fun not for PR.

I think ByteBuffer is preferred way of using memory in druid. If it could be used with off-heap memory by some configuration, it's reasonable to keep that way. but I saw some cases it's never be used with off-heap and got curious if it affects performance replacing that with simpler format (int[] of byte[]). I don't have hard intention this to be merged into master but wanted to show that using int[] or byte[] is reasonable in some cases.

I think this approach would complicate numeric dimensions, since the key would no longer only contain ints

@jon-wei fair enough. I'm closing.


Change "currentLocationLabel" with current street name

I've added a state on currentLocationLabel
 currentLocationLabel={this.stateCurrentStreet}
but return "Current location"

@CmDogsInc can you provide a reproducible example of this by showing some code or better yet, lining to a snack?

Closing. Please open a new issue (with clear reproduction steps/code) if this is a problem for you.


Slow motion/Fast Motion Videos made with Ffmpeg not getting played in Android 9.0 Pie

I have some videos on which i have applied slow/fast motion using below command(for slow) -
public String slowMo(String starttime, String endtime, String input, String output) {
       return "-i " + input + " -preset ultrafast -filter_complex " +
               "[0:v]trim=0:" + starttime + ",setpts=PTS-STARTPTS[v1];" +
               "[0:v]trim=" + starttime + ":" + endtime + ",setpts=PTS-STARTPTS[v2];" +
               "[0:v]trim=start=" + endtime + ",setpts=PTS-STARTPTS[v3];" +
               "[0:a]atrim=0:" + starttime + ",asetpts=PTS-STARTPTS[a1];" +
               "[0:a]atrim=" + starttime + ":" + endtime + ",asetpts=PTS-STARTPTS[a2];" +
               "[0:a]atrim=start=" + endtime + ",asetpts=PTS-STARTPTS[a3];" +
               "[v2]setpts=PTS/0.75[slowv];" +
               "[a2]atempo=0.75[slowa];" +
               "[v1][a1][slowv][slowa][v3][a3]concat=n=3:v=1:a=1[v][a]" +
               " -map [v] -map [a] -x264opts keyint=20:min-keyint=20:scenecut=-1 " + output;
   }

Videos made using above command are getting played in native player on Android 9.0 but not in your mediaplayer. I have checked in Oreo and Nougat they are working fine. Getting below in logcat.-
2018-11-20 12:24:05.045 8934-1174/com.opkix.android D/MediaPlayer: LAGGING -59369
2018-11-20 12:24:05.055 8934-1174/com.opkix.android D/MediaPlayer: LAGGING -32149
2018-11-20 12:24:05.090 8934-8934/com.opkix.android D/MediaPlayer: onInfo
2018-11-20 12:24:05.141 8934-8934/com.opkix.android D/MediaPlayer: onInfo
2018-11-20 12:24:17.047 8934-1198/com.opkix.android W/AudioTrack: releaseBuffer() track 0xeb261400 disabled due to previous underrun, restarting
2018-11-20 12:24:18.903 8934-1198/com.opkix.android W/AudioTrack: releaseBuffer() track 0xeb261400 disabled due to previous underrun, restarting
2018-11-20 12:24:20.893 8934-1198/com.opkix.android W/AudioTrack: releaseBuffer() track 0xeb261400 disabled due to previous underrun, restarting
20

Here is sample video. You can check in demo apk its not playing getting stuck.
https://www.dropbox.com/s/o5lq721zvlwpwd7/emp_20181120_120024.mp4?dl=0

command=new String[]{"-i",orignal_path,"-filter_complex",
"[0:v]trim=0:"+startMs+",setpts=PT" +
"S-STARTPTS[v1];[0:v]trim="+startMs+":"+endMS+",setpts=2*(PTS-STARTPTS)[v2];[0:v]trim="+endMS+",setpts=PTS-STARTPTS[v3];[0:a]atrim=0:"+startMs+",asetpts=PTS-STARTPTS[a1];[0:a]atrim="+startMs+":"+endMS+",asetpts=PTS-STARTPTS,atempo=0.5[a2];[0:a]atrim="+endMS+",asetpts=PTS-STARTPTS[a3];[v1][a1][v2][a2][v3][a3]concat=n=3:v=1:a=1",
"-preset","superfast","-profile:v","baseline",dest.getAbsolutePath()};


MINOR: align the constructor of KafkaConsumer to KafkaProducer

This PR includes following changes.
~1. remove KafkaProducer#propsToMap~
~2. align the constructor of KafkaProducer and KafkaConsumer~

move KafkaProducer#propsToMap to Utils#propsToMap
apply Utils#propsToMap to constructor of KafkaConsumer

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ijuma please note that this diff has changed fundamentally since you reviewed it, and it now modifies KafkaConsumer and not KafkaProducer.
I would like to endorse this PR. Funnily enough I came to very similar conclusions when I worked on the same code yesterday and raised https://github.com/apache/kafka/pull/8707 without any knowledge that this one existed.

Please note that addDeserializerToConfig(Properties, Deserializer<?>, Deserializer<?>) is now only used in test cases and can be removed along with the two tests of that method.

@nresare This "coincidence" is more favorite than "approved" :)

@chia7712 did you get around to update the PR with a variant that removes the no-longer-used addDeserializerToConfig() method?


Generate index

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/media/profiles/dan-hermes.jpg
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Watchdog tries to shut down Executor, even if ExecutorProvider has shouldAutoClose == false

Environment details

Programming language:
OS:
Language runtime version:
Package version: 2.19.2

Steps to reproduce

When using a BigQueryWriteClient with a custom ExecutorProvider
And that executorProvider has shouldAutoClose == false
The watchdog that gets spun up in ClientContext uses this provided executor, but is marked as shouldAutoClose == true (which is correct, because the watchdog has futures that need to be closed)
This tries to shut down the provided executor as well, which is not desired

I tested in my local that Watchdog is not shutting down Executor, the implementation of shutdown() in Watchdog can also confirm that it's only cancelling the future, not shutting down Executor.
Based on the linked PR, I guess the problem you are trying to solve is that you are using isShutdown() to determine if the client is shutdown or not, and Watchdog.isShutdown() is always returning false because the Executor will not be shutdown if ExecutorProvider.shouldAutoClose() is false?

We are using awaitTermination at the client level, which causes watchdogs to await, which depends on the await of the underlying executor. Ultimately, if the executor shouldn't be shutdown, I don't think we should await on the executor within the watchdog either

yep. When we provide this executor: https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/util/UnboundedScheduledExecutorService.java
and configure the executor provider like this: https://github.com/johnjcasey/beam/blob/feature/21368-re-enable-unboundedScheduledExecutor/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java#L1503
we see the issue when we later call .awaitTermination https://github.com/johnjcasey/beam/blob/feature/21368-re-enable-unboundedScheduledExecutor/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java#L1414

I still couldn't reproduce it with UnboundedScheduledExecutorService, Watchdog.shutdownNow only cancels the future and Watchdog.awaitTermination only waits for the executor but does not shut it down directly.
The Executor is still alive after I called
      this.newWriteClient.shutdownNow();
      this.newWriteClient.awaitTermination(60, TimeUnit.SECONDS);
      this.newWriteClient.close();

Are you creating a BQ client? the newWriteClient in the above code is a BigQueryWriteClient, for context.
It wraps a ClientContext, and calls forwards the various shutdown methods to the ClientContext.backgroundResources

Yes, I'm creating a BigQueryWriteClient, the various shutdown methods eventually call various shutdown methods in Watchdog, but none of them are shutting down ExecutorService.

Ah! The problem we were seeing is that our await termination is hanging for the duration of the timeout provided (60s), because the underlying executor isn't getting terminated.

but this await termination call shouldn't wait for the executor to be terminated

Sorry I've been explaining some of the issues poorly

@johnjcasey No worries, can you please update the title and description to match the issue you were observing? I'll prepare a fix in the mean time.


Hyperlinks

The spreadsheet breaks if parts are named using hyperlinks rather than just the id

Migrated to library: https://github.com/SynBioDex/Excel-to-SBOL/issues/2


Inclusive language

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Update all references in Bootstrap code that makes use of non inclusive language terms. Many guides are available online [1]
[1] https://itconnect.uw.edu/guides-by-topic/identity-diversity-inclusion/inclusive-language-guide/
[2] https://www.aswf.io/blog/inclusive-language/
Motivation and context
Within technology, one of the ways to drive a more diverse, equitable, and inclusive culture is to replace “offensive” language in code bases and documentation. This involves assessing existing code bases and documentation, identifying potentially problematic language, and replacing terms with more acceptable language. By using more inclusive and intentioned language in code and documentation, we create an environment for developers where differences are welcomed and identified as strengths.
Above copied from https://www.aswf.io/blog/inclusive-language/
There are other sites which reference this becoming more important with many companies adopting efforts for that:
https://www.forbes.com/sites/carolinamilanesi/2021/06/29/the-importance-of-inclusive-language-and-design-in-tech/?sh=703530adb167
https://www.aswf.io/blog/inclusive-language/

Thanks for suggesting this enhancement @lucianor
I've associated it with the "help wanted" label to see if folks in the community could help us spot the problematic wording in the documentation and code. IMO it would be the first step to tackle this topic. And then, discuss the possibilities of replacements. What do you think?

Feel free to open PRs to fix anything y'all find!

интересный


shard.lock is modified during update, causing error during compilation

Every time I use invidious_updater to update invidious, the update fails with the following error:
Checking player dependencies...
Player dependencies are satisfied
Showing last frame. Use --error-trace for full trace.

In src/invidious/routes/playlists.cr:227:23

 227 | if !plid || !plid.starts_with?("IV")
                         ^-----------
Error: undefined method 'starts_with?' for Array(String) (compile-time type is (Array(String) | Bool | Float64 | Int32 | Int64 | Invidious::User | Preferences | String))
/home/invidious/invidious

When checking in the git repository, I noticed that the shard.lock file is modified during the update process, resulting in the following diff:
diff --git a/shard.lock b/shard.lock
index be4333c1..5482d75a 100644
--- a/shard.lock
+++ b/shard.lock
@@ -1,5 +1,9 @@
 version: 2.0
 shards:
+  ameba:
+    git: https://github.com/crystal-ameba/ameba.git
+    version: 0.14.3
+
   athena-negotiation:
     git: https://github.com/athena-framework/negotiation.git
     version: 0.1.1
@@ -14,15 +18,11 @@ shards:

   exception_page:
     git: https://github.com/crystal-loot/exception_page.git
-    version: 0.2.0
+    version: 0.2.2

   kemal:
     git: https://github.com/kemalcr/kemal.git
-    version: 1.1.0
-
-  kilt:
-    git: https://github.com/jeromegn/kilt.git
-    version: 0.6.1
+    version: 1.1.2

   lsquic:
     git: https://github.com/iv-org/lsquic.cr.git
@@ -42,12 +42,9 @@ shards:

   spectator:
     git: https://github.com/icy-arctic-fox/spectator.git
-    version: 0.10.4
+    version: 0.10.5

   sqlite3:
     git: https://github.com/crystal-lang/crystal-sqlite3.git
     version: 0.18.0

-  ameba:
-    git: https://github.com/crystal-ameba/ameba.git
-    version: 0.14.3

I could not find the root cause of this issue by looking at the shell file, so I open this issue, hoping you might find the issue.
This is the steps to reproduce the issue:

Start with a repository without any modification (git status should not mention any modified file / log files do not impact the process).
git reset --hard f4e19ac05c33f0a0995fe9cbb7678cd0b90a3149 (3 commit behind current master)
Launch invidious_updater (version: 1.5.9)
Update invidious
The update with fail with the error message above

I could consistently reproduce this issue for a couple of months now and had to build invidious by myself since then.

Have you tried latest version? (v1.6.1)

Ah, it seems I missed some release : I followed the instructions in the Repository section of the Readme, but it seems the repo is down.
I will install it manually.

Sorry about that. Haven't added the last two updates to the repo yet.

I confirm it works as expected! Sorry for not using the latest version of the script.


Akumu, Sungod boosts

Description:

Changes:

Other checks:

[ ] I have tested all my changes thoroughly.

You made axe of the high sungod worse than drygore longs. Did you mean to do 20% for axe?


support for containerized installs

I would like to gather all issues/ needs/ ideas for containerized AMUSE installs here

run_command_redirected.py maybe installed/ and used as binary. Currently its location ends up in the command line by importing and looking at file property. This would not work for cases where the AMUSE install from which the worker is used is different than the local install (thus also not for containers).

Will be it something as https://github.com/evbauer/MESA-Docker ?
If will, maybe it is useful to maintain two versions: full, with all possible modules, including heavyweight as MESA, and lite, with minimal set.
So, such container edition will remove need in binary release and possible can make amuse available on not-so-open OS
Its look like there already was such attempts, but unsuccessful
https://github.com/mrteetoe/docker-amuse
https://hub.docker.com/r/mrteetoe/amuse/

@gekarmi: we are not sure yet about the exact form, ie whether it should be an a way to distribute the binary, or there should be a more extensive container (with development tools), or a way to isolate (the prereq of ) different community codes. There is a minimal amuse install (framework+ 3 codes) singularity image:
singularity pull singularity pull shub://ipelupessy/amuse-singularity:42.3

(if you have singularity installed)
this can be used as binary distribution (running amuse scripts), or with #214 to start single codes, with from an standard AMUSE install (at some point may be useful way to start codes on remote machines)
in other words if you have more ideas, list them here..

[disclaimer: i am not really any sort of developer, just computational astrophysics script kiddie, so there are high probability thats all are totally wrong]

whether it should be an a way to distribute the binary
Oh, sorry for my poor english and hopeless writing skills in any language, it seems I wasnt made my words clear
Container(in most usuall forms, from my newbie experience) will be successor of possibly al features  of binary releasel(except some really exotic case, as very stricted system)
It will make install as simple as possible. Because is pretty hell now. And it isnt amuse fall, at all. Reasons are all diiferent of versions of libraries in different linux distribution, python enviroments and distribution channels
Great recent story when apt-installed pip 10 in debian-based ask people to literaly destroy themself https://github.com/pypa/pip/issues/5221 https://github.com/pypa/pip/issues/5240
(so, )
And maybe simpliest way to deal with all this mess is put right distro with right versions of libraries in container and forget about it
(and again)
This will be overhead and slowdown, but maybe help with that problem and also help mantain different amuse in one machine, qick deploy %and other default containers pros and cons%

Finally, IMHO, binary in container is pretty useless, because destroy advantages of binary release itself(just executable file, small size, no need to any installation, clear and small dependences...)
Thank you for your time and attention!

https://github.com/amusecode/amuse-containers


ID returned in responses shouldn't be there

I tried the SR and Ochestrator and they return an ID for service, system and some others maybe. This presents a problem since the ID shouldn't be part of the response according to the arrowhead definition. After some emails about this, I open this issue to discuss this.
The main question are: why is the ID returned in the response? who uses it?
What would break if we get rid of it?

The management tool UI uses it (React JS), should only be present in the mgmt interfaces.

Entity classes have IDs (found in the eu.arrowhead.common.database package), so the database handling library can write to and retrieve values from the database. As a unique identifier of a resource, it is also useful keeping track, if case it needs to be updated/deleted/specified.
Besides the id field not being part of the definition, do you have other issues with it?

The issue I have with the IDs is that when the parser of the response finds it, it detects an error as a wrong type. I think the ID is fine for internal usage, I believe this shouldn't go outside of the core systems.
I have some other issues with the metadata and the orchestrationflags but those problem come from the definition itself not the implementation.

Can I ask what kind of parser do you use?
I could "manually" delete the IDs from the objects, before returning an OrchestrationResponse or ServiceRegistryEntry, although I'm not happy about it, if feels like a rudimentary solution to me.

we're using our own parser. We transform the JSON string into a string according to a standard for automation which states how structures should look like (which is rather easy to transfom). The standard doesn't allow for unkown fields, so that's why when we transform, we "clean" all the IDs. So for now it's working.
But the problem is not if I or other users can adapt to this field, but that even the oficial implementation of the Arrowhead system is not conform to the arrowhead specifications. This could be a simple issue to overcome, but from my point of view interfaces are sacred and shouldn't be broken.
I don't want to change something because it bothers me, but because from my point of view is wrongly implemented. I put the issue here for discussion and to see what other users think about it. I'll be glad to help if a lot of change is needed

I'll be glad to help if a lot of change is needed

That depends on the quality of the solution :) But for now I think I'll keep this as an open issue. There are other problems with the database design we know about, so bigger changes are bound to happen anyway, where this can be solved/clarified.
I'm not sure what is Csaba's viewpoint on all of this, specially the

even the oficial implementation of the Arrowhead system is not conform to the arrowhead specifications.

part of it.

I don't agree with having the ID fields in the messages either. That is not documented, nor should be.
The primary key for an Arrowhead system is its name, which should be unique within the LC.
The mgmt interfaces could contain this field, so that the Javascript UI can be implemented easier. Maybe I need to revisit this allowance as well, even if things are harder to implement.
I hope Jose, you are coming to Bilbao to discuss how you could help us in the works.

I'll be in Bilbao, yes. That'd be a great time to disscuss personally this things


Tracking APIs in OpenCV

The following script shows the usage of 5 of the tracking APIs in opencv including Boosting, MIL, KCF, TLD and Median Flow Tracker. Its implementation is shown using a live camera feed allowing the user to understand the usage of various APIs mentioned.
Solves issue #142

@geekquad could you kindly have a look and let me know your suggestions

@geekquad any suggestions?


Investigate NHPD Database as a potential resource for foreclosure rates

Is your feature request related to a problem? Please describe.
This is related to #994 by @lucasmbrown-usds
Contemporary foreclosure datasets that capture the current status of housing insecurity are necessary for improving Score L and ensuring we capture the current state of the United States. We have a confluence of the current pandemic, unemployment, and natural disasters that affect vulnerable communities. This dataset and the forthcoming analysis would provide some alternatives.
Describe the solution you'd like
Derive foreclosure rates using NHPD.
Describe alternatives you've considered
Looking at HUD Low-Income Housing Tax Credit Qualified Census Tracts
Additional context
Please see #1012.

Only applies to 3 states.


ViewPager+Fragment : When I  click the second tab  but the  log and Dialog (in the first tab ) show

I have fragment with 5 tabs (tab => 1,2,3,4,5).
When I  click the second tab  but the  log and Dialog (in the first tab ) show
how  can I edit  ?

i could help you, we can contribuid together, are you interesting?