RSA example fix & Test coverage

Description
This PR builds upon the changes introduced in #1229
Changes

Move the existing files ./src/examples/crypto/rsa.ts to a new directory ./src/examples/crypto/rsa/rsa.ts

Fix carry computation bug in multiplication for provable Bigint2048

The constraint (xy - qp - r)_i + c_(i-1) === c_i * 2^116 was not satisfied
Calculating the carry with carry = res_i.div(2n ** 116n);  prevents field overflow while satisfying the constraint mentioned above.

Refactor rangeCheck128Signed function

Use Gadgets.isDefinitelyInRangeN(128, x).assertTrue(); instead of doing custom range check on two 64-bit limbs.

Additions

Add a new file for test utilities: testUtils.ts

Contains utility functions for random RSA parameter generation.
Depends on the external package big-integer for faster and more scalable bigint arithmetic.

Add a new file for provable RSA65537 signature verification: rsa.test.ts

Contains test cases for:

Simple RSA verification
Hardcoded large RSA parameters imported from an external resource.
Large, randomly generated RSA parameters with modulus sizes of 512, 1024, and 2048 bits
Unhappy test cases for non-compliant RSA parameters, including modulus sizes larger than 2048 bits

Add a new file for RSA ZkProgram benchmarks: run.ts

Move the existing RSA ZkProgram from rsa.ts to run.ts
Add execution timing for proof generation & verification.

Notes

Usage of big-integer is justified for the following reasons:

modInv & modPow exceed local memory limit when operating on 2048-bit native bigints
The package is crucial to generate random large primes for RSA parameters.

It has a method to return primality of a big integer based on the Miller–Rabin primality test

Build
First of all: Build ./src/examples directory
npm run build:examples

Run RSA local tests: Skipped tests with increased iterations
NODE_OPTIONS=--experimental-vm-modules npx jest rsa.test.ts

Run RSA ZkProgram benchmarks
node ./dist/examples/crypto/rsa/run.js

Preview

Total rows
RangeCheck0
Generic
EndoMulScalar

Total
245481
1332
239525
4624

TODO

Refactor RSA tests.
Adapt bigint arithmetic to native bigint to omit using an external dependency.
Optimize RSA ZkProgram to address large circuit size causing 'Runtime Error: unreachable' in 'run.ts' execution.

This is great! Thank you so much for taking the time :)

Refactor rangeCheck128Signed function
Use Gadgets.isDefinitelyInRangeN(128, x).assertTrue(); instead of doing custom range check on two 64-bit limbs.

I think we should actually revert this change, it's less efficient this way

Total 	245481 	1332 	239525 	4624

this seems a lot 🤔 for me it was only 12k constraints, and this circuit just adds a couple of range checks on the inputs


Add --aws-profile command option

AWS CLI profile set up in the user's environment is expected to be the most common authentication method in Basti. If the user has multiple profiles set up, he or she can select a specific named profile with the AWS_PROFILE environment variable (it's a feature of AWS SDK).
Adding --aws-profile option would make Basti commands more readable and the profile selection feature more visible as well. The users would see that there's such an option in basti --help output.

The profile might affect the session-manager-plugin integration as the plugin expects the profile as an input argument: https://github.com/BohdanPetryshyn/basti/blob/f7160a9235b2fea9c2283a6764b24439cbaade13/src/session/start-session-manager-plugin-process.ts#L58
The integration has to be tested

AsyncLocalStorage could be used to propagate global values like this to deep parts of the application. However, I'd prefer to use a simple global config object for this simple case.

The new CLI option is already available in v1.2.0 🎉


Merge development into master

Pull Request Test Coverage Report for Build 651

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 98.667%

Files with Coverage Reduction
New Missed Lines
%

src/utils.ts
2
92.16%

Totals

Change from base Build 647:
-0.1%

Covered Lines:
202

Relevant Lines:
204

💛  - Coveralls

:tada: This PR is included in version 3.2.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Create entanglement forging how-to's

Create a how-to for freezing orbitals
Create a how-to for specifying different bitstrings for each subsystem.

Fixed by #44


Regression in how subtitles are displayed with line breaks.

Have you read the FAQ and checked for duplicate open issues? Yes
What version of Shaka Player are you using? 3.0.3
Can you reproduce the issue with our latest release version? Yes
Can you reproduce the issue with the latest code from master? Yes
Are you using the demo app or your own custom app? Both
If custom app, can you reproduce the issue using our demo app? Yes
What browser and OS are you using?
Chrome 84, macOS 10.15.6
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?

I will send an email with the details.
What did you do?

Load a stream
What did you expect to happen?
Subtitles are displayed correctly
What actually happened?

Subtitles are displayed incorrectly. In version 3.0.2 they are shown correctly, I think the regression is introduced here: https://github.com/google/shaka-player/commit/6c85c8cbfc1df2a2c8a34ff8b548b2fcf5ff7dea
In 3.0.3

In 3.0.2

<?xml version="1.0" encoding="utf-8"?>
<tt ttp:timeBase="media" xml:lang="" xmlns="http://www.w3.org/ns/ttml" xmlns:ttm="http://www.w3.org/ns/ttml#metadata" xmlns:ttp="http://www.w3.org/ns/ttml#parameter" xmlns:tts="http://www.w3.org/ns/ttml#styling">

    <styling>


Trade Companion improvements

Hello,
Quick note, great job on the trade companion, I was thinking of going trade trade league, this came just in time. Thanks.
My feedback on the feature:

Add an option to allow to auto-hide the overlay when there's no trade active. Avoids the following issue:

Add an option to right-align the whole UI (this kinda gets deprecated by feedback number 1, because it seems to only be a problem when visible without any trade

Add an option to auto-minimize every trade request (automatically, when added)

Add an option to auto-minimize every trade except for the last one (automatically, when a new one is added minimize the previous one)

Allow to bind keys to actions to allow quick actions on the last trade (this goes well with feedback number 4, so you'll always know which trade is active).

Add an option for outgoing trades (buying) to go to your hideout or just add a custom field in trade actions for custom commands

Thanks again on the development.
Best regards.

Great suggestions! We'll look into them and see which ones can be added. I especially like number 4 combined with 5. I have been contemplating on how I could go about adding short-cuts for certain trade actions/buttons, but held back because I couldn't think of a good way on how to deal with multiple trades.
Some further thoughts that came to mind reading the above suggestions:

Make auto-minimize work with the following options (maybe separate incoming & outgoing?):

Always Minimize incoming trades
Minimize previous trade on new incoming trade (unless the max. visibility is reached, then the last visible one stays visible instead of minimizing itself with the next trade not showing up due to the visible limit set in the settings)
Minimize new trades (i.e. keeping the first trade the "active" trade)

Also added optional key-binds to make the next/previous trade the active one; and add an option to collapse the "previously active" trade

Add an optional border color around the "active trade" to properly indicate which trade options will be used (i.e. to whom you're sending messages) when using a shortcut key.

Regarding your 6th suggestion: It was intended to add a "home" button to the companion bar, but didn't end up doing so because you can already set it as a short-cut (default is F5) so I thought it would be redundant. But apparently people want a dedicated button for it, so we can add one to the bar.

Thanks for your feedback, just a quick comment regarding my number 6 and your number 4:
My suggestion isn't to add a new button to the trade bar, but to add a new option inside the trade option:

Adding here a new checkbox "Go to hideout" or if you want it more flexible, just add a textbox with "Custom command" where people can type, for instance, /hideout:
Quick MS Paint visualization:

Thanks for all your work.
Best regards.

I'm not sure if I fully understand what you're hinting at in your last reply, so I'm going to assume some stuff.
If the intention is to have a "thx" button which sends the thx message to the player, and then also (instantly) teleports you to your hideout, then this isn't allowed. Sending a whisper is one server-command, going to your HO (i.e. sending "/hideout") is another command; and sending more than one command per button/shortcut press is not allowed by GGG's ToS for tools (such as poe overlay CF).
So if you want to return to your HO after clicking the "thx" button, you can use/create a command shortcut (in the "commands" tab of the settings menu) to go to your HO (the default shortcut for this is F5).
On top of that, I've also added a "home" or "HO" button to the trade notification panel for easy access (in case you don't like shortcut keys and prefer a button instead)

The majority of the mentioned improvements have been added in #231 and will be available in the next release.


mgmt: mcumgr: fs_mgmt: Allow querying supported hash/checksums

Adds a new mcumgr command for returning information on all supported hash/checksum types that the firmware supports.

[X] Code added
[ ] Release notes updated
[X] SMP documentation updated
[X] Manually tested
[X] Test created and added to zephyr (WIP)
[X] Automated test passes

Test will fail until https://github.com/zephyrproject-rtos/zephyr/pull/50298 is merged

CC @oyvindronningstad

Rebased


never stores changes to library

Seems to be using .termfeed but wants to use .termfeed.db.
Tells me it created .termfeed.db in my home all the time but it never is created. There is however a .termfeed file.

Have a look at this issue.


rhel: Fix build rpm error on CentOS 6.8 & 6.9 (& newest kernel 3.19.0)

Add support for RHEL6.8 & 6.9 (& newest kernel 3.19.0) which uses an old version of kernel with some new features backported.

Hi,
Thanks for your contribution.
I am closing this PR as it appears to have gone stale.
If you believe this change is still relevant then please do feel welcome to resubmit it using the preferred mechanism of the Open vSwitch project, the email workflow described in Submitting Patches.


Eclipse Temurin JDK/JRE 17.0.13+11 aarch64 (macOS ARM) version is not notarised and not signed

Eclipse Temurin 17.0.13+11 aarch64 (macOS ARM) version is not notarised and not signed.
The recent update of Eclipse Temurin 17 seems to have an issue during build process.
JDK/JRE 17.0.13+11 macOS ARM version (aarch64) is not signed and not notarised.
JDK/JRE 17.0.13+11 macOS Intel version (x64) is signed and notarised.
Could you trigger the build process for  aarch64 again?
macOS aarch64

macOS x64

Thanks
Did you test with the latest update version?

[x] Yes

Please provide steps to reproduce where possible
Download latest aarch64 version from website(https://adoptium.net/temurin/releases/?os=mac&arch=aarch64&version=17) or github (https://github.com/adoptium/temurin17-binaries/releases/tag/jdk-17.0.13%2B11)
Expected Results
JDK/JRE 17.0.13+11 aarch64 pkg to be signed (and notarised).
Actual Results
JDK/JRE 17.0.13+11 aarch64 pkg is not signed and not notarised (notarisation is only possible when pkg is signed)
What Java Version are you using?
17.0.13+11
What is your operating system and platform?
macOS ARM (aarch64)
How did you install Java?
automatic installation with pkg installer
Did it work before?
Last version(jdk/jre 17.0.12+7) of pkg is signed.

Did you test with other Java versions?
Last version(jdk/jre 17.0.12+7) of pkg is signed.

@inglenny thank you for highlighting, there was a problem uploading, we have just re-freshed the binaries, and all should be good now.

@andrew-m-leonard Thank you! I just tried again and can confirm it is now signed and notarised.


Form POST only submitting after second submit

Im currently trying to integrate Smoothstate.js into  a Django Project. I'm using the js code snippet from the smoothstate.js options example in the readme.
When I click on a link Smoothstate.js works like expected. But when I submit the form it doesn't send a post and just triggers the animations. When I click it a second time it sends the POST and works like it should.
It seems like this problem is related to #issue189 and #issue 231
When I point the POST action to a different URI it works fine but when I point it to the same URI the POST will not be sent on the first submit. On the second submit it works.
You can have a look at my code on Stackoverflow

Hi @skuzzlebud
I had the same issue a few days ago, I solved it by blacklisting the form with a class.
$('#main').smoothState({ blacklist: '.no-smoothState' });
<form class="no-smoothState">
  ...
</form>

I couldnt get it working with the forms option, but blacklisting worked

Any news on this one?


Tweak connect exceptions

Clean up manual sleep now that we have a retry implementation cc: @li-boxuan
document retries/cooldown in README
docstrings for LLM class
added exponential backoff for completion
don't send message property in embeddings (this was split out)
fixed condense to work with exception handling the same way as completion
ContextWindowExceededError stops the loop
made defaults customizable (some providers' limits are quite low)
also, added retries for embeddings.

Embeddings were in a little odd place, because they were retrying all the time, without our doing, by default from a llama-index decorator under the hood. That was defined with hard-coded values that do not seem appropriate for quite a number of users, so this PR replaces the default decorator from llama-index with one defined by us. I suppose we can find more appropriate defaults on those... I just hope that what we see is what we do. 😅
Caveats:

this was tested without the threads in memory.py... I could address that in a follow-up
there seems to be some default retry behavior in openai module too, but I'm not sure I've seen it problematic in our issues so this PR doesn't deal with it.

Fixes #710
Fixes #946
Addresses a couple of error cases with infinite loops #326
Please note exceptions retried are:

RateLimitError, APIConnectionError, in both completion and embeddings,
ServiceUnavailableError in completion (~ 500-520 in litellm)
InternalServerError in embeddings.

This PR doesn't directly address Azure. Given the patching, and the fact the file it modifies is itself copied and modified by llama-index, not an openai original file, it might not work yet for Azure.. I'll check that.
It works for Azure the same way.

About embeddings:
We don't yet get what we set, because this PR was tested without the threading added in memory.py. With them, the PR implementation still retries more than num_retries, since a second/third thread is doing the same; and faster. Maybe the right thing to do is to split embeddings completely out of this PR and follow up on them separately. It's quite ugly patching as it is, and there might be other reasons too for a refactoring there... This PR is doing this patching because I thought the priority on embeddings was to stop the inappropriate retry defaults (those from llama-index decorator, I think they're the ones that cause issues[1]), but I didn't account for the threading, and at the moment it might improve too little, and at the cost of some hacky code. @rbren
However, I've been changing my mind on the right approach on embeddings about 794 times per day lately, and I'll be happy to change it again... 😅
[1] the hard-coded decorator can do up to 6 retries * almost 50 = almost 300 retries starting with 1 sec

This is looking great! Seems like a big improvement as-is, so I'd be game to figure out the embedding stuff in a future PR


Migrate to zcash/librustzcash revision with v5 tx parsing

This doesn't affect Sapling note detection (which uses Compact Blocks),
but enables the enhancement logic to decrypt and store the corresponding
transactions for displaying memo fields.
Author

[x] Self-review: Did you review your own code in GitHub's web interface? Code often looks different when reviewing the diff in a browser, making it easier to spot potential bugs.
[x] Automated tests: Did you add appropriate automated tests for any code changes?
[x] Manual tests: Did you update the manual tests as appropriate? While we aim for automated testing of the application, some aspects require manual testing. If you had to manually test something during development of this pull request, write those steps down.
[x] Documentation: Did you update documentation as appropriate? (e.g README.md, etc.)
[x] Run the app: Did you run the demo app and try the changes?
[ ] Rebase and squash: Did you pull in the latest changes from the main branch and squash your commits before assigning a reviewer? Having your code up to date and squashed will make it easier for others to review. Use best judgement when squashing commits, as some changes (such as refactoring) might be easier to review as a separate commit.

Reviewer

[ ] Checklist review: Did you go through the code with the Code Review Guidelines checklist?
[ ] Ad hoc review: Did you perform an ad hoc review?  In addition to a first pass using the code review guidelines, do a second pass using your best judgement and experience which may identify additional questions or comments. Research shows that code review is most effective when done in multiple passes, where reviewers look for different things through each pass.
[ ] Automated tests: Did you review the automated tests?
[ ] Manual tests: Did you review the manual tests?
[ ] How is Code Coverage affected by this PR? We encourage you to compare coverage before and after changes and when possible, leave it in a better place.
[ ] Documentation: Did you review Docs, README.md, and Architecture.md as appropriate?
[ ] Run the app: Did you run the demo app and try the changes? While the CI server runs the app to look for build failures or crashes, humans running the app are more likely to notice unexpected log messages, UI inconsistencies, or bad output data. Perform this step last, after verifying the code changes are safe to run locally.

With the latest commit (815018b08ec8dbbc25cd64890670cc4a0150c8db) I was able to build https://github.com/zcash/zcash-android-wallet, run a testnet wallet, send it a v5 Sapling transaction, and have the wallet detect, decrypt and store the transaction and show the note's memo.


[doublecheck] invenio-cli assets install  missing json

Package version (if known): March/April
This has to be double-checked in a more recent install: running
invenio-cli assets install path/to/react-invenio-deposit will return an error about missing binary json. json is installed by npm --prefix path under the covers but there might be an issue with accessbilitiy to that binary.
Most current developers don't see that issue because they have installed json globally, but new developers may not have.

Haven't experienced this in a while. Closing.


Update Unit Test

I just started on dev, working tests is very helpful, thank you!

  Contract: Collateral unit test
    ✓ init totalCollateral is zero
    ✓ Error on lockCollateral with 0 amount (59ms)
    ✓ LockCollateral with 1 Gwei amount (55ms)
    ✓ after lock: totalCollateral equal 1 Gwei
    ✓ after lock: freeCollateral equal 1 Gwei
    ✓ ReleaseCollateral 0.5 Gwei (57ms)
    ✓ after release: totalCollateral equal 0.5 Gwei
    ✓ after release: freeCollateral equal 0.5 Gwei
    ✓ SlashCollateral 0.2 Gwei to new account (54ms)
    ✓ after slash: totalCollateral equal 0.3 Gwei
    ✓ after slash: 1Vault freeCollateral equal 0.3 Gwei

  Contract: ExchangeRateOracle unit test
    ✓ setExchangeRate, getExchangeRate (136ms)
    ✓ collateralToWrapped (60ms)
    ✓ wrappedToCollateral (48ms)

  Contract: Issue unit test
    ✓ Error on requestIssue with the insufficient griefing collateral (89ms)
    ✓ Register Vault with 10 ONE Collateral (94ms)
    ✓ Error on requestIssue with the exceeding vault limit (105ms)
    ✓ Issue 0.1 OneBtc (1078ms)
    ✓ Error on requester is not a executor of issue call (800ms)
    ✓ Slash in case the transferred BTC amount is smaller than the requested OneBTC amount (794ms)
    ✓ Error on cancelIssue with the invalid cancel period (747ms)
    ✓ Cancel issue (841ms)

  Contract: BitcoinKeyDerivation:On-Chain Key Derivation Scheme
0 1GznSsg3sg2RDCvsQRvusDwcVCuhya56KT 1GznSsg3sg2RDCvsQRvusDwcVCuhya56KT
1 18d6YxRFgWGFGS751CVhguDBMu4L1SmUuS 18d6YxRFgWGFGS751CVhguDBMu4L1SmUuS
....
99 1Hk59on1uvcfE9qt6iBsk9PX9diG643hSE 1Hk59on1uvcfE9qt6iBsk9PX9diG643hSE
    ✓ key derivate (63930ms)

  Contract: issue/redeem test
    ✓ vault register test (65ms)
    ✓ issue test (920ms)
    ✓ redeem test (232ms)
    ✓ cancel issue request test (982ms)
    ✓ cancle redeem request test (314ms)

  Contract: Redeem unit test
    ✓ Register Vault with 10 ONE Collateral (67ms)
    ✓ Issue 0.5 OneBtc (915ms)
    ✓ Redeem 0.1 OneBtc (390ms)
    ✓ Error on cancelRedeem with the invalid cancel period (162ms)
    ✓ Cancel Redeem (245ms)

  Contract: Replace unit test
    ✓ Register OLD Vault with 10 Wei Collateral (68ms)
    ✓ Issue 0.5 OneBtc (1052ms)

  Contract: transaction parse test
    ✓ extractTx and validateTxout (192ms)
    ✓ validateTxout with wrong requestId (234ms)
    ✓ validateTxout with less amount (184ms)
    ✓ validateTxout with more amount (196ms)
    ✓ validateTxout with wrong receiver (164ms)
    ✓ validateTxout without requestId (198ms)

  Contract: VaultRegistry unit test
    ✓ register new vault (61ms)
    ✓ after register: check vault method
    ✓ update vault public key (45ms)
    ✓ after public key update: check vault data
    ✓ Free Collateral is correct
    ✓ Register Deposit Address (963ms)
    ✓ tryIncreaseToBeIssuedTokens (43ms)
    ✓ tryDecreaseToBeIssuedTokens (43ms)
    ✓ Issue tokens 2 Wei (46ms)
    ✓ after issue: Check issued amount equal 2 Wei
    ✓ tryIncreaseToBeRedeemedTokens (107ms)
    ✓ Redeem tokens 1 Wei (71ms)
    ✓ after redeem: Check redeemable amount equal 1 Wei (40ms)
    ✓ RequestableToBeReplacedTokens (67ms)

  55 passing (1m)


Silence "file out of workspace" errors

We really should fix this limitation of the VFS, but it's some way off
at the moment, so let's just silence the user-visible error for now.

bors r+


Leaflet bottom bounds

Hi!
I working on a custom map for a company and I get an issue.The issue is: I set the bounds and everything and it works on all side except the bottom so when i start moving u it not goes back to the bottom. The funny thing if I resize the window so for example I make it small and after back to full window size the bottom part works perfectly.
Here is my code so far:
var winh = $(window).height();
	var winw = $(window).width();
	var maph = $('#map').height();
	var mapw = $('#map').width();
	var offset = $('#map').offset();
	var centerX = offset.left + mapw / 2;
	var centerY = offset.top + maph / 2;
	var changem = false;
	var cbut = $('#building');
	var southWest = new L.LatLng(winh, 0);
    var northEast = new L.LatLng(0, winw);
    var bounds = L.latLngBounds(southWest, northEast);

    var map = L.map('map', {
    	maxBounds: bounds,
        maxZoom: 2,
        minZoom: 0,
        crs: L.CRS.Simple
    }).setView([winh, winw], 0);
    // .setView([winh, winw], 0)
     map.setMaxBounds(bounds);

    // map.panTo(new L.LatLng(centerY,centerX));

// ----------------------------------
// 	Load the images for the map
// ----------------------------------
    var imageUrl = 'http://rigailoveyou.exflairdigital.com/public/img/houses.png'
    var imageUrl2 = 'http://rigailoveyou.exflairdigital.com/public/img/road.png'
    var imageBounds = [[winh,0], [0,winw]];

    var map1 = L.imageOverlay(imageUrl, bounds,'Riga I Love You').addTo(map);
    var map2 = L.imageOverlay(imageUrl2, bounds).addTo(map);

Hi, great to hear that you find Leaflet useful!
However, this issue tracker is used for reporting bugs and discussing new features. For questions on using Leaflet, please use gis.stackexchange.com or stackoverflow.


docs: Add BackboneLambdaFinetuningCallback

What does this PR do?
The docs of BackboneLambdaFinetuningCallback and BaseFinetuningCallback aren't available right now, which was probably missed in #5377.
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified
[ ] Check that target branch and milestone match!

Did you have fun?
Make sure you had fun coding 🙃

Hey @akihironitta @awaelchli @carmocca ,
After reflexion, I realise the Callback names aren't great !
Any proposition for better names ?
Best,
T.C

Hey @akihironitta @awaelchli @carmocca ,
After reflexion, I realise the Callback names aren't great !
Any proposition for better names ?
Best,
T.C

FinetuneCallback or FinetuningCallback are the simplest

FinetuneCallback or FinetuningCallback are the simplest


Mutations applied to file with inner #![cfg(test)] attribute

For a crate containing two files lib.rs and test.rs
lib.rs:
mod test;

test.rs:
#![cfg(test)]

fn foo() -> bool { false }

I expect that cargo mutants --list will not list any mutations, but I see
jkastner@dev % cargo mutants --list
src/test.rs:3:20: replace foo -> bool with true

I suspect this is because cargo mutants is not checking for inner attributes on files. Moving #![cfg(test)] to an outer attribute on the mod test; statement lets things work as expected. Inner attribute are also detected properly if I move the definition of the test module inside lib.rs.

Thanks, I can imagine how we might not be checking for that and I agree it's a bug.


Added a few optional fields to the GitHub issue templates

Added a couple of optional fields to help with Modus adoption tracking.
template:

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?
GitHub Issue templates
Checklist

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Looks good. I have a couple of requests for changes:

I suggest we remove the I have validated any HTML to avoid common problems * - at the top - this was copied/pasted from Modus Bootstrap Issue template where it makes more sense... not always relevant for MWC bug reports.
I'd like to suggest renaming 'Which npm package?' to something  like 'what is the issue regarding?' and add an additional option to the dropdown 'Modus Web Components Website.


Signals fix

This fixed Ubuntu builds but also reverts a commit I just backported because it was also reverted in master by @zwoop.

Intel CC build successful! See https://ci.trafficserver.apache.org/job/icc-github/103/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1671/ for details.

Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1567/ for details.

clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/235/ for details.


handle ESI tags in the head

Seems like jsoup doesn't recognize the tag <esi:include src="[url]"/> as a valid html tag that can exist inside the  tag. the side effect is that the parser forces the  tag to start before that ESI tag. Is it possible to add support for this tag and consider it as a valid tag inside the . The ESI tag is a placeholder that allows CDN like solution to dynamically replace it at runtime with some other info.
Here is some more info about ESI:
https://en.wikipedia.org/wiki/Edge_Side_Includes

Thanks - I don't plan on making such a change that would pull the parser out of HTML5 spec


What happens if the server receives a PacketOut message from a non-master controller?

How should the server react to such a situation? The spec just says that the controller has to be a master:

In fact, before a controller becomes able to do Packet I/O or program any forwarding entry (via Write RPC), it needs to start a controller session and become a “master”.

I see the following possibilities, apart from ignoring the message, of course:

Do nothing (Stratum current state)
Log an error on the server
Close the RPC channel with PERMISSION_DENIED (@ccascone's and my preference)

I prefer option 3 because it would match the behavior for non-master Write RPC calls:

If the client is not the master for (device_id, role_id) according to the election_id value, the server must return a PERMISSION_DENIED error.

It would also enforce stricter error checking and encourage defensive coding of controllers. A correctly implemented controller knows that it can't send packets if it's not master. A faulty one will lose its connection, which will hopefully be noticed and corrected by the operator. Silently ignoring a permission violation seems not wise to me.

Let's discuss this at the 07/17/2019 P4 API WG meeting. Hopefully, either you or Carmelo can make it.
I think one difference is that returning PERMISSION_DENIED for a Write RPC does not kill the controller-switch connection, while closing the RPC channel essentially removes the controller from the set of standbys for the switch. Maybe that's a bit extreme. Similarly, if the master controller sends a malformed packet, should we close the RPC channel and essentially leave the switch without a mater controller?

Conclusion from the 07/17/2019 P4 API WG meeting: we are investigating adding a new field to the StreamMessageResponse oneof which can optionally be used to report errors triggered by invalid / unauthorized StreamMessageRequest messages.


[ci] Move coverage test to own job

The coverage report could previously fail silently which could leave codecov in an infinite pending state. If the report fails now CI will also fail. Since this didn't test anything that test:unit didn't test already I moved this to another job so that it doesn't block other jobs because of a simple network error.
See codecov/codecov-bash#134

What do you think of keeping the existing build steps? Because running the regression tests is an intensive task, we only do it once all the other tests are green.

@oliviertassinari  I only looked at the CI runtime but test_regression will also trigger argos, right? I will add test_coverage to the requirements for test_converage.

Can we keep it into test_unit?

We only have 4 containers that can be run in parallel. Adding a fith step will slow the builds. Don't worry, CircleCi has already been optimized.

Sure, better keep it simple

Ok, found it in https://codecov.io/bash
-Z           Exit with 1 if not successful. Default will Exit with 0


Release v3.4.3

CHANGELOG 3.4.3

🚀 Added

Added support for standard navigation drawer (https://m3.material.io/components/navigation-drawer/guidelines#38800092-0149-4251-ac75-4ce8a144042a).
Added main layouts section on homepage (https://m3.material.io/foundations/layout/applying-layout/window-size-classes)
Added main layouts docs
Updated navigations section on homepage
Updated navigations docs

🩹 Fixed

The dialog elements were behind navigation rails, now will be above

// Added support for standard navigation drawer

    home
    Home

    search
    Search

    more_vert
    More

// inside dialog/article
<dialog>

      home
      Home

      search
      Search

      more_vert
      More

</dialog>

Main layouts section

Standard navigation drawer

In the codepen example I couldn’t see the difference between  and  :thinking:

Hi @leonardorafael thanks for these new features :smiley:
A few remarks:

In the codepen example I couldn’t see the difference between  and  :thinking:
Would it be possible to have an automagic class that would allow a unique menu section to be at the bottom on small screens and on the side on larger screens? Having to generate two separate menus creates duplicate IDs errors. To get only one menu I had to overwrite Beercss CSS with media queries styles, and that’s not a good solution…

Hi @leonardorafael thanks for these new features 😃
A few remarks:

In the codepen example I couldn’t see the difference between  and  🤔
Would it be possible to have an automagic class that would allow a unique menu section to be at the bottom on small screens and on the side on larger screens? Having to generate two separate menus creates duplicate IDs errors and bloats the page. To get only one menu I had to overwrite Beercss CSS with media queries styles, and that’s not a good solution…

Hi @laurentpayot , thanks!
I created another codepen with the next release modifications here https://codepen.io/leo-bnu/pen/ZEweJYj
Yes, the navs are independent today. We do that because the content can be very different between then. But in some cases I think we can try to add a class responsive in nav to do the trick for us.


Variable explorer for Notebooks (Interactive window)

What ever we do might impact interactive window as well.
This is the custom webview displayed with variable explorer

Hmm, I don't believe that this is currently planned. De-assigned and moving back to backlog.

Hmm, I don't believe that this is currently planned. De-assigned and moving back to backlog.

The native interactive window inherits the variable explorer for native notebooks.


Add the website_id to the user/register call

What is the motivation for adding / enhancing this feature?

Reference/discussion: https://github.com/DivanteLtd/vue-storefront/issues/3848
We need to add the website_id to be configurable via: config.storeViews.*.website_id and then passed via the JSON body to vue-storefront-api/storefront-api. Then we need to pass this very same information to the magento instance. So probably a minor change to https://github.com/DivanteLtd/magento would be required
What are the acceptance criteria

[ ] website_id is configurable in the config.storeViews
[ ] website_id is supported by the user/register call

Hey, Thanks for helping me with this in Slack but when I did more testing it also worked with passing on only the Store_id. One of the 2 needed to be passed though for it to register.

Interestingly, if the storeCode is before "/rest" in the Magento url in VS-API, it works fine on Magento 2.3.5 without any storeId or websiteId.
E.g. https://magento.example.info/us/rest/V1/customers/
Unfortunately the same url format causes other problems with authenticated routes, which seems like a complicated issue to work through.
For now, @ArjanStudent 's solution is easy. Just to expand on it, all that's needed is to add the storeId to the user/register event data, in the callRegister method, in the Register component. E.g.:
this.$store.dispatch('user/register', {
  email: this.email,
  password: this.password,
  firstname: this.firstName,
  lastname: this.lastName,
  storeId: currentStoreView().storeId
})


Possible to use pre-trained hifigan instead of training from scratch?

There's already pre-trained Hifigan on VCTK set. I could only fine-tune to my dataset, instead of training it from the start, thus saving processing time.

CausalHiFi-GAN model structure is not compatible with HiFi-GAN, so you cannot use pre-trained models of HiFi-GAN.

Ok


[Q] How to compare config between two or more runs?

Hi one cool feature from neptune is that we can compare the config between two or more runs, and so far I am not sure how to do the same in wandb. By comparing the config I mean comparing config in this table

Thanks!

@chris-tkinter you bet!  You can click the "+" icon in your project workspace and choose Run Comparer from the list of panels.


Check that GUI's don't generate a new draw when minimized / hidden

[x] Check for Qt

MacOS: stops drawing when window is minimized or hidden behind another window.
Win11: stops drawing when window is minimized, but not if it's behind another window.

[x] Check for glfw

MacOS: only when minimized, can even result in more frames (higher fps) because no vsync or something?
Win11: only when minimized.

[x] Check for wx

MacOS: not tested (no wheels for M1)
Win11: stops drawing when window is minimized, but not if it's behind another window.

[x] Check for jupyter (uses browser visibility API)

MacOS: works like a charm
Win11:  all fine (e.g. widget scrolls outside viewport, select other tab) except still drawing if browser is behind other window.

Notes:

These are with #272
It looks like on Windows GUI's cannot determine visibility if the window is behind another window...
Interestingly, on MacOS windows that are hidden behind another window, will still continue drawing when they're maximixed ...

I did some tests and added these in the top post. With #272 we're all good on minimized windows. It looks like detecting that a window is hidden is hard. Your best chance for good behavior is on Mac+Qt.
No tests on Linux yet.


chore(deps): update all non-major dependencies

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

jsii-diff (source)
^1.104.0 -> ^1.105.0

jsii-pacmak (source)
^1.104.0 -> ^1.105.0

pnpm (source)
9.1.2 -> 9.13.2

Release Notes

aws/jsii (jsii-diff)
v1.105.0
Compare Source
Features

pacmak: support jsii-rosetta 5.6 (#4698) (7464a59)

Bug Fixes

rosetta: python identifiers mishandle identifier translations with capital letters (#4644) (e573aab)

pnpm/pnpm (pnpm)
v9.13.2: pnpm 9.13.2
Compare Source
Patch Changes

Detection of circular peer dependencies should not crash with aliased dependencies #8759. Fixes a regression introduced in the previous version.
Fix race condition of symlink creations caused by multiple parallel dlx processes.

Platinum Sponsors

Gold Sponsors

Silver Sponsors

v9.13.1: pnpm 9.13.1
Compare Source
Patch Changes

Fixed some edge cases where resolving circular peer dependencies caused a dead lock #8720.

Platinum Sponsors

Gold Sponsors

Silver Sponsors

v9.13.0: pnpm 9.13
Compare Source
Minor Changes

The self-update now accepts a version specifier to install a specific version of pnpm. E.g.:
pnpm self-update 9.5.0

or
pnpm self-update next-10

Patch Changes

Fix Cannot read properties of undefined (reading 'name') that is printed while trying to render the missing peer dependencies warning message #8538.

Platinum Sponsors

Gold Sponsors

Silver Sponsors

v9.12.3
Compare Source
Patch Changes

Don't purge node_modules, when typing "n" in the prompt that asks whether to remove node_modules before installation #8655.
Fix a bug causing pnpm to infinitely spawn itself when manage-package-manager-versions=true is set and the .tools directory is corrupt.
Use crypto.hash, when available, for improved performance #8629.
Fixed a race condition in temporary file creation in the store by including worker thread ID in filename. Previously, multiple worker threads could attempt to use the same temporary file. Temporary files now include both process ID and thread ID for uniqueness #8703.
All commands should read settings from the package.json at the root of the workspace #8667.
When manage-package-manager-versions is set to true, errors spawning a self-managed version of pnpm will now be shown (instead of being silent).
Pass the find command to npm, it is an alias for npm search

v9.12.2
Compare Source
Patch Changes

When checking whether a file in the store has executable permissions, the new approach checks if at least one of the executable bits (owner, group, and others) is set to 1. Previously, a file was incorrectly considered executable only when all the executable bits were set to 1. This fix ensures that files with any executable permission, regardless of the user class, are now correctly identified as executable #8546.

v9.12.1
Compare Source
Patch Changes

pnpm update --latest should not update the automatically installed peer dependencies #6657.
pnpm publish should be able to publish from a local tarball #7950.
The pnpx command should work correctly on Windows, when pnpm is installed via the standalone installation script #8608.
Prevent EBUSY errors caused by creating symlinks in parallel dlx processes #8604.
Fix maximum call stack size exceeded error related to circular workspace dependencies #8599.

v9.12.0
Compare Source
Minor Changes

Fix peer dependency resolution dead lock #8570. This change might change some of the keys in the snapshots field inside pnpm-lock.yaml but it should happen very rarely.

pnpm outdated command supports now a --sort-by=name option for sorting outdated dependencies by package name #8523.

Added the ability for overrides to remove dependencies by specifying "-" as the field value #8572. For example, to remove lodash from the dependencies, use this configuration in package.json:
{
  "pnpm": {
    "overrides": {
      "lodash": "-"
    }
  }
}

Patch Changes

Fixed an issue where pnpm list --json pkg showed "private": false for a private package #8519.
Packages with libc that differ from pnpm.supportedArchitectures.libc are not downloaded #7362.
Prevent ENOENT errors caused by running store prune in parallel #8586.
Add issues alias to pnpm bugs #8596.

v9.11.0
Compare Source
Minor Changes

Experimental: added pnpm cache commands for inspecting the metadata cache #8512.

Patch Changes

Fix a regression in which pnpm deploy with node-linker=hoisted produces an empty node_modules directory #6682.
Don't print a warning when linking packages globally #4761.
pnpm deploy should work in workspace with shared-workspace-lockfile=false #8475.

v9.10.0
Compare Source
Minor Changes

Support for a new CLI flag, --exclude-peers, added to the list and why commands. When --exclude-peers is used, peer dependencies are not printed in the results, but dependencies of peer dependencies are still scanned #8506.

Added a new setting to package.json at pnpm.auditConfig.ignoreGhsas for ignoring vulnerabilities by their GHSA code #6838.
For instance:
{
  "pnpm": {
    "auditConfig": {
      "ignoreGhsas": [
        "GHSA-42xw-2xvc-qx8m",
        "GHSA-4w2v-q235-vp99",
        "GHSA-cph5-m8f7-6c5x",
        "GHSA-vh95-rmgr-6w4m"
      ]
    }
  }
}

Patch Changes

Throw an exception if pnpm switches to the same version of itself.
Reduce memory usage during peer dependencies resolution.

v9.9.0
Compare Source
Minor Changes

Minor breaking change. This change might result in resolving your peer dependencies slightly differently but we don't expect it to introduce issues.
We had to optimize how we resolve peer dependencies in order to fix some infinite loops and out-of-memory errors during peer dependencies resolution.
When a peer dependency is a prod dependency somewhere in the dependency graph (with the same version), pnpm will resolve the peers of that peer dependency in the same way across the subgraph.
For example, we have react-dom in the peer deps of the form and button packages. card has react-dom and react as regular dependencies and card is a dependency of form.
These are the direct dependencies of our example project:
form
react@16
react-dom@16

These are the dependencies of card:
button
react@17
react-dom@16

When resolving peers, pnpm will not re-resolve react-dom for card, even though card shadows react@16 from the root with react@17. So, all 3 packages (form, card, and button) will use react-dom@16, which in turn uses react@16. form will use react@16, while card and button will use react@17.
Before this optimization react-dom@16 was duplicated for the card, so that card and button would use a react-dom@16 instance that uses react@17.
Before the change:
form
-> react-dom@16(react@16)
-> react@16
card
-> react-dom@16(react@17)
-> react@17
button
-> react-dom@16(react@17)
-> react@17

After the change
form
-> react-dom@16(react@16)
-> react@16
card
-> react-dom@16(react@16)
-> react@17
button
-> react-dom@16(react@16)
-> react@17

Patch Changes

pnpm deploy should write the node_modules/.modules.yaml to the node_modules directory within the deploy directory #7731.
Don't override a symlink in node_modules if it already points to the right location pnpm/symlink-dir#54.

v9.8.0
Compare Source
Minor Changes

Added a new command for upgrading pnpm itself when it isn't managed by Corepack: pnpm self-update. This command will work, when pnpm was installed via the standalone script from the pnpm installation page #8424.
When executed in a project that has a packageManager field in its package.json file, pnpm will update its version in the packageManager field.

Patch Changes

CLI tools installed in the root of the workspace should be added to the PATH, when running scripts and use-node-version is set.

pnpm setup should never switch to another version of pnpm.
This fixes installation with the standalone script from a directory that has a package.json with the packageManager field. pnpm was installing the version of pnpm specified in the packageManager field due to this issue.

Ignore non-string value in the os, cpu, libc fields, which checking optional dependencies #8431.

Remember the state of edit dir, allow running pnpm patch-commit the second time without having to re-run pnpm patch.

v9.7.1
Compare Source
Patch Changes

Fixed passing public-hoist-pattern and hoist-pattern via env variables #8339.
pnpm setup no longer creates Batch/Powershell scripts on Linux and macOS #8418.
When dlx uses cache, use the real directory path not the symlink to the cache #8421.
pnpm exec now supports executionEnv #8356.
Remove warnings for non-root pnpm field, add warnings for non-root pnpm subfields that aren't executionEnv #8143.
Replace semver in "peerDependency" with workspace protocol #8355.
Fix a bug in patch-commit in which relative path is rejected #8405.
Update Node.js in @pnpm/exe to v20.

v9.7.0
Compare Source
Minor Changes

Added pnpm version management to pnpm. If the manage-package-manager-versions setting is set to true, pnpm will switch to the version specified in the packageManager field of package.json #8363. This is the same field used by Corepack. Example:
{
  "packageManager"<EMAIL_ADDRESS>}

Added the ability to apply patch to all versions:
If the key of pnpm.patchedDependencies is a package name without a version (e.g. pkg), pnpm will attempt to apply the patch to all versions of
the package. Failures will be skipped.
If it is a package name and an exact version (e.g. pkg@x.y.z), pnpm will attempt to apply the patch to that exact version only. Failures will
cause pnpm to fail.
If there's only one version of pkg installed, pnpm patch pkg and subsequent pnpm patch-commit $edit_dir will create an entry named pkg in
pnpm.patchedDependencies. And pnpm will attempt to apply this patch to other versions of pkg in the future.
If there are multiple versions of pkg installed, pnpm patch pkg will ask which version to edit and whether to attempt to apply the patch to all.
If the user chooses to apply the patch to all, pnpm patch-commit $edit_dir would create a pkg entry in pnpm.patchedDependencies.
If the user chooses not to apply the patch to all, pnpm patch-commit $edit_dir would create a<EMAIL_ADDRESS>entry in pnpm.patchedDependencies with
x.y.z being the version the user chose to edit.
If the user runs pnpm patch<EMAIL_ADDRESS>with x.y.z being the exact version of pkg that has been installed, pnpm patch-commit $edit_dir will always
create a<EMAIL_ADDRESS>entry in pnpm.patchedDependencies.

Change the default edit dir location when running pnpm patch from a temporary directory to node_modules/.pnpm_patches/pkg[@version] to allow the code editor to open the edit dir in the same file tree as the main project.

Substitute environment variables in config keys #6679.

Patch Changes

pnpm install should run node-gyp rebuild if the project has a binding.gyp file even if the project doesn't have an install script #8293.
Print warnings to stderr #8342.
Peer dependencies of optional peer dependencies should be automatically installed #8323.

v9.6.0
Compare Source
Minor Changes

Support specifying node version (via pnpm.executionEnv.nodeVersion in package.json) for running lifecycle scripts per each package in a workspace #6720.
Overrides now support the catalogs: protocol #8303.

Patch Changes

The pnpm deploy command now supports the catalog: protocol #8298.
The pnpm outdated command now supports the catalog: protocol #8304.
Correct the error message when trying to run pnpm patch without node_modules/.modules.yaml #8257.
Silent reporting fixed with the pnpm exec command #7608.
Add registries information to the calculation of dlx cache hash #8299.

v9.5.0
Compare Source
Minor Changes

Added support for catalogs 8122.
Catalogs may be declared in the pnpm-workspace.yaml file. For example:

v9.4.0
Compare Source
Minor Changes

Some registries allow the exact same content to be published under different package names and/or versions. This breaks the validity checks of packages in the store. To avoid errors when verifying the names and versions of such packages in the store, you may now set the strict-store-pkg-content-check setting to false #4724.

Patch Changes

Fix package-manager-strict-version missing in config #8195.
If install is performed on a subset of workspace projects, always create an up-to-date lockfile first. So, a partial install can be performed only on a fully resolved (non-partial) lockfile #8165.
Handle workspace protocol with any semver range specifier, when used in peer dependencies #7578.

v9.3.0
Compare Source
Minor Changes

Semi-breaking. Dependency key names in the lockfile are shortened if they are longer than 1000 characters. We don't expect this change to affect many users. Affected users most probably can't run install successfully at the moment. This change is required to fix some edge cases in which installation fails with an out-of-memory error or "Invalid string length (RangeError: Invalid string length)" error. The max allowed length of the dependency key can be controlled with the peers-suffix-max-length setting #8177.

Patch Changes

Set reporter-hide-prefix to true by default for pnpm exec. In order to show prefix, the user now has to explicitly set reporter-hide-prefix=false #8174.

v9.2.0
Compare Source
Minor Changes

If package-manager-strict-version is set to true, pnpm will fail if its version doesn't exactly match the version in the "packageManager" field of package.json.

Patch Changes

Update @yarnpkg/pnp to the latest version, fixing issue with node: imports #8161.
Deduplicate bin names to prevent race condition and corrupted bin scripts #7833.
pnpm doesn't fail if its version doesn't match the one specified in the "packageManager" field of package.json #8087.
exec now also streams prefixed output when --recursive or --parallel is specified just as run does #8065.

v9.1.4
Compare Source
Patch Changes

Improved the performance of the resolution stage by changing how missing peer dependencies are detected #8144.

v9.1.3
Compare Source
Patch Changes

Fix a bug in which a dependency that is both optional for one package but non-optional for another is omitted when optional=false #8066.
Clear resolution cache before starting peer dependencies resolution #8109.
Reduce memory usage by peer dependencies resolution #8072.

Configuration
📅 Schedule: Branch creation - "before 2am on Monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


VMs should have friendlier names

VM names should contain identifiable information and not just UUID.

thanks for the ref @mrdavidlaing - closing this as the new issue has more context


Implementation of fine-tuning RoBERTa on downstream tasks

Hi,
Thank you so much for publishing your code for the paper! However, I only found the implementation of Task 1 (recurrent word-level language models on Wiki-103) and Task 2 (recurrent character-level language models on Enwik8) described in the Experimental Setup (Section 5) of the paper.
Do you have the code for Task 4, namely fine-tuning RoBERTa on downstream tasks, available? I'm very interested in reproducing that part of the experiment and would really appreciate it if you could provide the implementation.

Do you reproduce the pruning strategy on finetuning Roberta? @achen353

Do you reproduce the pruning strategy on finetuning Roberta? @achen353

No, unfortunately. @robotsp


[Q] how to log matplotlib plot without having it shown up in the jupyter notebook?

Hi, I am trying to log dozens of matplotlib over course of training using self.logger.experiment.log({'myFig': wandb.Image(fig)}, commit=False), where fig is a matplotlib.Figure object.  But when the training is done, all figures would automatically show up in the jupyter notebook as well, making the size of notebook unnecessarily large.  I am wondering if there is way to log all plots without having them shown up in jupyter notebook?
Thank you!

Hey @abcde-1447 , you can try plt.close(). This will not plot the output in inline mode.

We are closing this for lack of activity.


Add macros (discussion, do not merge)

In order to add auto data storage (#157), we need macros to generate form fields. This is because the code to populate field values with data the user has entered is complex. I don't think users of the kit will find it easy to write that code for each field.
Macros also help us make prototypes accessible, again without our users having to learn that HTML.
I think we should try and keep each macro as simple as possible as an MVP.
This PR is for discussion, for example is macro. the right naming convention? Should allowing users to easily add their own macros be part of this PR?
Example of usage:
<form action="">

    {{ macro.text('First name') }}

    {{ macro.text('Last name') }}

      Role

    {{ macro.radio('Role', 'Teacher') }}

    {{ macro.radio('Role', 'Student') }}

    {{ macro.radio('Role', 'Administrator') }}

      How do you get to school?

Select all that apply

    {{ macro.checkbox('Bicycle') }}

    {{ macro.checkbox('Bus') }}

    {{ macro.checkbox('Car') }}

    {{ macro.checkbox('Train') }}

</form>

Previous work here: #99

Suggest we close this now. We're developing templates as part of GOV.UK Frontend so once the Kit is consuming that they will be available to it's users.

Closing this now

Just a note that macros for production might be too complex for the users of the kit, so we may still need our own.


Improvement of OpenSSF Scorecard Score

Title: Improvement of OpenSSF Scorecard Score
Description:
Hi, I'm Harshita. I’m working with CNCF and the Google Open Source Security Team for the GSoC 2024 term. We are collaborating to enhance security practices across various CNCF projects. The goal is to improve security for all CNCF projects by both using OpenSSF Scorecards and implementing its security improvements.
As this project already has scorecard action, I'm here to increase the final score by going over each check. I've listed all of the checks where work needs to be done, in order of its criticality. I plan to submit each PR for each fix. Please let me know what you think and for which ones a PR is welcome that I will submit it ASAP.
Current Score: 8.4
Scorecard report: https://scorecard.dev/viewer/?uri=github.com/envoyproxy/envoy
Here's a few checks we can work on to improve the project's security posture:

[ ] Branch-Protection: Score = 4

In my opinion, adding the following checks would be useful:
1. Require at least 2 reviewers for approval before merging.
2. Require review from code owners.

NOTE: This can only be done by the maintainers.

[ ] Binary-Artifacts: Score = 8

The project contains two binaries:
https://github.com/envoyproxy/envoy/blob/main/test/common/json/json_sanitizer_corpus/binary_file
https://github.com/envoyproxy/envoy/blob/main/tools/gsutil/crcmod/_crcfunext.cpython-312-x86_64-linux-gnu.so
Problems with generated executable (binary) artifacts
Binaries allowed by Scorecard
To solve this we can either remove the generated executable artifacts from the repository or build from source.

[ ] Signed-Releases: Score = 8

SLSA provenance needs to be added, which can be done using this, increasing the overall score to 10.

[ ] Pinned-Dependencies: Score = 1

Some github actions and container images of Dockerfile are not pinned by hash, which results in a low score.
Pinning dependencies to a specific hash rather than allowing mutable versions or ranges of versions improves supply chain security.

/cc @joycebrum @diogoteles08 @pnacht @nate-double-u

cc @envoyproxy/senior-maintainers @envoyproxy/security-team

cc @mmorel-35

re branch protection - i think we probably dont want to enforce 2 reviewers, or to enforce codeowner review if a maintainer has reviewed
re binaries - none of these are trivial to remove (afaiaa) or they would have been removed already
re signed releases - we do sign our releases using pgp, perhaps we can add the provenance stuff also
re pinned deps - all are pinned (afaiaa) other than the CI actions we develop ourselves - the reason these are not is that it has historically caused issues with dependabot

I think @phlax has covered this pretty well. I'm not sure there's anything we actually want to change here, except possibly the signed release provenance.
I think in particular the score you arrived at on pinned deps is incorrect, as all code dependencies are pinned already.

the OSSF score is checked on every push - there is a badge on the repo README showing it

@mmorel-35 added the necessary to make this work some time ago and we got the score above 9 at that time
since then i reverted the pins for the toolshed github actions as it was causing some issues - this dropped our score significantly
you can check the found issues here https://github.com/envoyproxy/envoy/security/code-scanning


The way not to lose routing to node pods during restart calico-node

Hi!
I have theoretical question. I need something kinda best practice or maybe advise. It isn't a bug or something like that.
I have a 1.20 k8s cluster with Calico 3.18.6
My installation with routable pods/services IPs outside the cluster (BGP ToR)
The issue I'm trying to resolve is losing node pods connectivity from the rest of the infrastructure when that node's calico-node instance is restarting. During the restart bird process inside the calico-node stops,  bgp session drops and it results in node's pod IPs unreachable for some little period of time
Is there any way to make pod IPs reachable even during calico-node restart? Thanks a lot!

@caseydavenport Thank you!
we use frr as a routing daemon, bgp graceful restart available since 8.2.2
https://frrouting.org/release/8.2.2/
updating to this version made the trick
http://docs.frrouting.org/en/stable-8.2/bgp.html#clicmd-bgp-long-lived-graceful-restart-stale-time-1-4294967295


Option to add API key

As openweathermap provides limited hits on the free keys. Implement client side feature to implement the key such that users can continue using the app without any interrupton after default key reaches limits.

Hello there, I would like to contribute to this issue during hacktoberfest 2024. It would be great if you can assign this issue to me.


remove-dynamic-imports

fixes #7
Background
Importing from paths generated at runtime breaks
parcel, see (parcel-bundler/parcel#4031),
or esbuild, see (evanw/esbuild#480).
Summary

replace dynamic import statements with hardcoded ones
utils seems to be unused so it gets removed completly

Published in v2.1.2, I rebased your commit on top of master.


Can not find preLaunchTask

I can only reproduce this with latest from source, not with vscode-insdiers

Generate a new TS vscode extension with yo code
Try to debug it -> notice error that npm can not be found

I know you are refactoring thing in the tasks frameworks so just make sure not to break any dependencies debug has on the task frameworks, especailly around debugging extensions

@isidorn I tried this with both latest insider from tonight and out of source and I can't reproduce this. Can you try again please.

I can not repro it with latest, I must have been yesterady in a weird state locally.
Sorry for the false alarm

No problem. There is of course a chance I broke something. So thanks for filing.

@dbaeumer I reproduce it on my side. on a fresh typescript extension generated with yeoman I get this error.


SIMSBIOHUB-507: Add Caribou Herd Layer to Survey Study Area Map

Links to Jira Tickets
https://apps.nrs.gov.bc.ca/int/jira/browse/SIMSBIOHUB-507
Description of Changes
Can now pick from the caribou herd layer when defining your survey study area boundary.
Testing Notes
Selecting/removing caribou regions works, like any other region layer we already supported

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.64%. Comparing base (f69d21f) to head (b1ed142).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev    #1259       +/-   ##
===========================================
+ Coverage   52.82%   72.64%   +19.81%
===========================================
  Files         561      216      -345
  Lines       16981     8791     -8190
  Branches     2631     1254     -1377
===========================================
- Hits         8970     6386     -2584
+ Misses       7405     2049     -5356
+ Partials      606      356      -250

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Send csv file to backend

User story

As a Software Developer
I want to send csv file to backend
So that I can store or process it

Acceptance criteria

Sending csv file to backend

DoD general criteria

Feature has been fully implemented
Feature has been tested
Feature has been merged into the main branch
Important parts have been documented in the technology wiki
All acceptance criteria were met
Product owner approved features
Developers agreed to release

Current error: CORS policy

Frontend ask for pre signed url
Backend ask S3 bucket -> give to frontend
Frontend uses Axios


Increase localization priority value

Localized articles are getting high page views so changing priority to ensure it gets human translated.

Docs Build status updates of commit fff3b58:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Language/Reference/User-Interface-Help/this-document-was-opened-with-macros-disabled.md
:bulb:Suggestion
View
Details

Language/Reference/User-Interface-Help/this-document-was-opened-with-macros-disabled.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Programmatic Execution?

Hey there,
I don't see this in the doc anywhere, but is there a way to fire this off programmatically?
For example:

I have an action for a button, so I display the stack programmatically
I can automatically select the index of the destination stack, or simply just the root controller by firing an execution once the reveal animation completes.

Thanks and this looks like a great library, really great idea and well done.
Dan

use  public func showControllers() method for show stack
could you clarify second question?

I can automatically select the index of the destination stack, or simply just the root controller by firing an execution once the reveal animation completes.

I think what he means is,  can he press a UIButton and have it jump back to, the root view controller, or a specific index.

user press buttons
code: present view controllers -> programmatically select index x
user is now at viewController[x] (no interaction other than pressing the button)


Add SP1 + CVE-2017-8516 GDR

Type of Change

[x] Bug fix (non-breaking change, fixes #)
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose

Add 13.0.4206 to the build list
Approach

Add new build to JSON

🎉


MRTK3 Implementation!

Step 6 includes example files that utilize 'MixedRealityPointerEventData'. This does not exist (https://localjoost.github.io/MRTK2-to-MRTK3-tapping-selecting-holograms/) with MRTK3. That being said I have temporarily commented out (thankfully) the only method that uses this called onTapped(). This allowed me to build the project but I am now having trouble interacting with the buttons, assuming they are pressable.
Thank you for your very helpful step-by-step instructions, I'm excited to move forward with my project once I can successfully get past this step.

I have the same issue!

Hi,
A version of HoloLensWithOpenCVForUnityExample containing the MRTK3 example is now available. Please set it up with the latest OpenCVForUnity2.6.3.


Add kairadiagne.com

Hello Dave, It was nice meeting you on thursday :) This adds my personal blog to the iOS Development Blogs category. It is a tech journal about things I learn about iOS development. Thanks!

Great to meet you too. Thanks for the addition!
Sent with GitHawk


Owen Hines: Watch themmaexperts.com

Owen Hines requests the watch of the watch_keyword themmaexperts.com. See the Metasmoke search here

!!/approve


Generate hot link design

First step integration

Small bug in step 2 there is a space after the Select operation input:

On the last step the link to copy should be inside an input and take all red rectangle space:

Would be nice if we can click "SELECT OPERATION" in the steps to go back

We should use default description from the blockchain code, you must to search for the operation like this https://github.com/steemit/steem/blob/8cd5f688d75092298bcffaa48a543ed9b01447a6/libraries/wallet/include/steemit/wallet/wallet.hpp#L604
Leave it empty if there is no description

Can we have the icon > centered verticaly? Also there should be a margin or padding around the icon, sort of text dont come to close.

Description text font-size should be 16px


ValueError: Unable to retrieve parameter 'w' when trying to use eval_inference

When invoking experiment.py to do inference:
python3 ./tapnet/experiment.py \
  --config=./tapnet/configs/tapnet_config.py \
  --jaxline_mode=eval_inference \
  --config.checkpoint_dir=./tapnet/checkpoint/ \
  --config.experiment_kwargs.config.inference.input_video_path=fixed10.mp4 \
  --config.experiment_kwargs.config.inference.output_video_path=result.mp4 \
  --config.experiment_kwargs.config.inference.resize_height=256 \
  --config.experiment_kwargs.config.inference.resize_width=256 \
  --config.experiment_kwargs.config.inference.num_points=20

I get the following error:
Traceback (most recent call last):
  File "./tapnet/experiment.py", line 431, in <module>
    app.run(main)
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/absl/app.py", line 308, in run
    _run_main(main, args)
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/absl/app.py", line 254, in _run_main
    sys.exit(main(argv))
  File "./tapnet/experiment.py", line 424, in main
    platform.main(
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/jaxline/utils.py", line 484, in inner_wrapper
    return f(*args, **kwargs)
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/jaxline/platform.py", line 137, in main
    train.evaluate(experiment_class, config, checkpointer, writer,
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/jaxline/utils.py", line 620, in inner_wrapper
    return fn(*args, **kwargs)
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/jaxline/train.py", line 225, in evaluate
    scalar_values = utils.evaluate_should_return_dict(experiment.evaluate)(
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/jaxline/utils.py", line 521, in evaluate_with_warning
    evaluate_out = f(*args, **kwargs)
  File "./tapnet/experiment.py", line 405, in evaluate
    eval_scalars = point_prediction_task.evaluate(
  File "/home/jrcoyle/tapnet/supervised_point_prediction.py", line 370, in evaluate
    self._eval_inference(
  File "/home/jrcoyle/tapnet/supervised_point_prediction.py", line 981, in _eval_inference
    outputs, _ = self._infer_batch(
  File "/home/jrcoyle/tapnet/supervised_point_prediction.py", line 440, in _infer_batch
    output, _ = functools.partial(wrapped_forward_fn, input_key=input_key)(
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/haiku/_src/transform.py", line 357, in apply_fn
    out = f(*args, **kwargs)
  File "./tapnet/experiment.py", line 125, in forward
    return self.point_prediction.forward_fn(
  File "/home/jrcoyle/tapnet/supervised_point_prediction.py", line 150, in forward_fn
    return shared_modules[self.model_key](
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/haiku/_src/module.py", line 426, in wrapped
    out = f(*args, **kwargs)
  File "/usr/lib/python3.8/contextlib.py", line 75, in inner
    return func(*args, **kwds)
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/haiku/_src/module.py", line 272, in run_interceptors
    return bound_method(*args, **kwargs)
  File "/home/jrcoyle/tapnet/tapnet_model.py", line 215, in __call__
    latent = self.tsm_resnet(
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/haiku/_src/module.py", line 426, in wrapped
    out = f(*args, **kwargs)
  File "/usr/lib/python3.8/contextlib.py", line 75, in inner
    return func(*args, **kwds)
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/haiku/_src/module.py", line 272, in run_interceptors
    return bound_method(*args, **kwargs)
  File "/home/jrcoyle/tapnet/models/tsm_resnet.py", line 383, in __call__
    net = hk.Conv2D(
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/haiku/_src/module.py", line 426, in wrapped
    out = f(*args, **kwargs)
  File "/usr/lib/python3.8/contextlib.py", line 75, in inner
    return func(*args, **kwds)
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/haiku/_src/module.py", line 272, in run_interceptors
    return bound_method(*args, **kwargs)
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/haiku/_src/conv.py", line 200, in __call__
    w = hk.get_parameter("w", w_shape, inputs.dtype, init=w_init)
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/haiku/_src/base.py", line 448, in wrapped
    return wrapped._current(*args, **kwargs)
  File "/home/jrcoyle/.local/lib/python3.8/site-packages/haiku/_src/base.py", line 524, in get_parameter
    raise ValueError(
ValueError: Unable to retrieve parameter 'w' for module 'tap_net/~/tsm_resnet_video/tsm_resnet_stem' All parameters must be created as part of `init`.

Attempting to use a local GPU. The live_demo.py script works for me, so not sure what the issue is here.

live_demo.py uses a TAPIR model, but it looks like you're using a TAP-Net config.  What checkpoint file are you trying to use with that code?  Did you perhaps intend to use a TAPIR config?

I'm using the checkpoint from https://storage.googleapis.com/dm-tapnet/causal_tapir_checkpoint.npy. I see that above I'm referencing a TAP-Net config, so I tried again with a TAPIR config, and got the same error.

Please let me know if there is any more info I can provide or debugging steps on my end.

Is it an option to use the code snippet we provide for inference in the colab?
Has the error message changed from using the tapir config?  The traceback you provided above has tap_net/ as the prefix for the variable names; it should be tapir if you're actually running a tapir model.  Without more information it's difficult to guess why that's happening.

Did you solve the problem, I had the same thing happen to me.

I am getting same error... Is there any solution??

I am getting same error... Is there any solution??

I found the problem. you shoud have checkpoint.npy file in checkpoint path.
wget https://storage.googleapis.com/dm-tapnet/checkpoint.npy -o tapnet/checkpoint/checkpoint.npy

I am getting same error... Is there any solution??

I found the problem. you shoud have checkpoint.npy file in checkpoint path.
wget https://storage.googleapis.com/dm-tapnet/checkpoint.npy -o tapnet/checkpoint/checkpoint.npy

Also, this is a different checkpoint than in

I'm using the checkpoint from https://storage.googleapis.com/dm-tapnet/causal_tapir_checkpoint.npy. I see that above I'm referencing a TAP-Net config, so I tried again with a TAPIR config, and got the same error.

Using https://storage.googleapis.com/dm-tapnet/checkpoint.npy, I got it to work with the experiment script.

I am getting same error... Is there any solution??

I found the problem. you shoud have checkpoint.npy file in checkpoint path.
wget https://storage.googleapis.com/dm-tapnet/checkpoint.npy -o tapnet/checkpoint/checkpoint.npy

Also, this is a different checkpoint than in

I'm using the checkpoint from https://storage.googleapis.com/dm-tapnet/causal_tapir_checkpoint.npy. I see that above I'm referencing a TAP-Net config, so I tried again with a TAPIR config, and got the same error.

Using https://storage.googleapis.com/dm-tapnet/checkpoint.npy, I got it to work with the experiment script.

I am getting same error... Is there any solution??

I found the problem. you shoud have checkpoint.npy file in checkpoint path.
wget https://storage.googleapis.com/dm-tapnet/checkpoint.npy -o tapnet/checkpoint/checkpoint.npy

Also, this is a different checkpoint than in

I'm using the checkpoint from https://storage.googleapis.com/dm-tapnet/causal_tapir_checkpoint.npy. I see that above I'm referencing a TAP-Net config, so I tried again with a TAPIR config, and got the same error.

Using https://storage.googleapis.com/dm-tapnet/checkpoint.npy, I got it to work with the experiment script.

I would like to evaluate a model. evaluation means first train a model and then evaluate it in evaluation dataset.(maybe).It means it doesn't need a pretrained model.So I can't understand why I got the error.


Lock the logger when writing the _logStream

The StreamWriter does not seem to be threadsafe. On my system I get a lot of crashes like metioned in #2878. This lock fixes the issues on my system. I'm not sure though if this the correct solution for this problem.

Sure, just wasn't entirely sure if this is the correct way to add a lock in C#. I've added the changlog entry.


Removed the ignore keyword and executed Github Actions, but the review did not run

Right after creating the PR, it was marked as a work in progress (Draft), so I launched the PR with @coderabbitai: ignore attached. Later, I removed @coderabbitai: ignore from the description and re-executed Github Actions with Re-run all jobs, but it was skipped with the message Skipped: description contains ignore_keyword.
Is this the intended behavior?

https://github.com/coderabbitai/ai-pr-reviewer/blob/d5ec3970b3acc4b9d673e6cd601bf4d3cf043b55/src/review.ts#L3
Ah, it seems that github_context is referencing the context at the time of execution. You might just need to increase the triggers for requesting a review (such as sending mentions).
Adding to the triggers for Github Actions is an approach that comes to mind.
Do you have a clear answer to this?


Feat Req: Add Button to get OCR's Text

Would love if a button was just added to the screen when viewing an item, to get the ocr'd text. Then it would save a couple of clicks (instead of always having to first right-click the item, then click the view ocr menu item). I'm all about ease of use and save clicks. :)
Mock up (ignore the drop down arrow on the button, I just forgot to remove it in the mock up):

You can now get OCRed text from contextual menu of the commander or view:

feature was added by following commits:
backend
frontend


Fix builtin and keywords highlighting depending on indentation

Fixes #2159

This is what used to happen:

Now it is corrected:

Hey, nice improvement @mariacamilaremolinagutierrez!
Does this also fixes the problem with print shown in different colors, as reported on issue #2159?

Also, could explain what was the problem before? I mean, why coloring was not applied correctly?

And more thing: you forgot to branch 3.x in your fork :-)
I mean, you directly pushed your commits on the 3.x branch of your branch, while you should have created a branch after checking out 3.x :-)

The problem was that the words True, False and None were in both lists: keywords and builtins. I left them to be colored as builtins.
The print is not in both lists, so as another member commented on the issue, print was not a problem anymore, at least not in python 3.
Next time I'll create a new branch. My apologies!

Great, thanks a lot @mariacamilaremolinagutierrez!


Update documentify

this changes the order transforms are run in: those defined in
package.json are now run first, like in browserify. technically
that's a breaking change, but maybe we can merge this without bumping
bankai because it's still -rc? :P

@goto-bus-stop Thanks! this might help solve issues with folks who want to babelify or tsify :)

ah nope :(  babelify and yo-yoify still don't seem to get along.

yeah this only changes how the html is transformed. i guess the problem with babelify+yoyoify is that babel transforms template strings before yoyoify finds them? :/ package.json transforms run before transforms included with bankai. one thing you could do is configure babel to use babel-plugin-yo-yoify haha.

ah nice! I'll use that!

We might eventually pull in Babel for a two-bundle system using module
script tags + nomodule. That way we can compile in whatever older browsers
don't have, without impacting newer browsers. Just a thought at the moment,
but might be neat in the future (:
On Thu, Oct 19, 2017 at 8:53 PM Dan Flettre<EMAIL_ADDRESS>wrote:

ah nice! I'll use that!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/choojs/bankai/pull/302#issuecomment-338003066, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACWlen200arTsytRjHrJWz3_FRShaCVDks5st5qbgaJpZM4P-U0G
.


What tool(s) were used to help reverse-engineer the original firmware?

As per the subject. The reason I ask is because I'm trying to reverse-engineer the firmware for a different piece of hardware, also based on an ARM-compatible MCU; already managed to extract the HEX files for it, but I'm stuck at the disassembly/decompiling stage.
Thanks in advance for any and all tips and info.
Sorry if that's not the proper place to ask for this, as this repo doesn't have any "Discussion" area.

You already helped me a lot @DualTachyon, much more than I had any right to expect. Thank you!
I already managed to extract the hexes, my problem now is disassembling/decompiling them.
The larger one (*.rom.hex) I'm pretty sure is for the Geehy APM32F103RBT6 (which seems to be a clone of the STM32F103RBT6).
The second one is weird, seems to be for a C8051F380DK, which looks like a clone of the venerable  C8051. But for many reasons I think it's either a red herring or a left-over from some other product that the manufacturer forgot inside the EXE.
I will give Ghidra a try. Thanks again! 👍👍👍


Fix covariant return type issue with overridden methods

Purpose
This PR will fix covariant return type issue with overridden methods
Fixes #20942
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[ ] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #22463 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22463   +/-   ##
=======================================
  Coverage   14.59%   14.59%
=======================================
  Files          51       51
  Lines        1411     1411
  Branches      219      219
=======================================
  Hits          206      206
  Misses       1189     1189
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 621defc...836046c. Read the comment docs.


Unknown connection ID when establishing Connection from cloudflare quiche.

We are working with quic-go as our server and notice some odd behavior when using quiche, in the example provided in their c library a connection should be establish after a handful of steps. Below is the qlog from go that shows that it appears to have an unknown connection ID, Not sure if there is deeper logging we can add to isolate the problem further.
{"qlog_format":"NDJSON","qlog_version":"draft-02","title":"quic-go qlog","configuration":{"code_version":"v0.39.0"},"trace":{"vantage_point":{"type":"server"},"common_fields":{"ODCID":"cc05414e650588e00f6e3f09e06153d0","group_id":"cc05414e650588e00f6e3f09e06153d0","reference_time":1710720331322.3008,"time_format":"relative"}}}
{"time":0.24964,"name":"recovery:congestion_state_updated","data":{"new":"slow_start"}}
{"time":0.287552,"name":"transport:parameters_set","data":{"owner":"local","original_destination_connection_id":"cc05414e650588e00f6e3f09e06153d0","stateless_reset_token":"eb776f07ca4e97338ac30022788e8fcc","initial_source_connection_id":"5afbd60f","disable_active_migration":true,"max_idle_timeout":30000,"max_udp_payload_size":null,"ack_delay_exponent":3,"max_ack_delay":26,"active_connection_id_limit":4,"initial_max_data":786432,"initial_max_stream_data_bidi_local":524288,"initial_max_stream_data_bidi_remote":524288,"initial_max_stream_data_uni":524288,"initial_max_streams_bidi":100,"initial_max_streams_uni":100}}
{"time":0.436061,"name":"security:key_updated","data":{"trigger":"tls","key_type":"client_initial_secret"}}
{"time":0.436592,"name":"security:key_updated","data":{"trigger":"tls","key_type":"server_initial_secret"}}
{"time":0.652729,"name":"transport:version_information","data":{"server_versions":["1","6b3343cf"],"chosen_version":"1"}}
{"time":0.665252,"name":"transport:connection_started","data":{"ip_version":"ipv4","src_ip":"<IP_ADDRESS>","src_port":8443,"dst_ip":"<IP_ADDRESS>","dst_port":39954,"src_cid":"635f636964","dst_cid":"cc05414e650588e00f6e3f09e06153d0"}}
{"time":0.903721,"name":"transport:packet_received","data":{"header":{"packet_type":"initial","packet_number":0,"version":"1","scil":5,"scid":"635f636964","dcil":16,"dcid":"cc05414e650588e00f6e3f09e06153d0"},"raw":{"length":280,"payload_length":249},"frames":[{"frame_type":"crypto","offset":0,"length":228}],"ecn":"Not-ECT"}}
{"time":0.925843,"name":"transport:packet_dropped","data":{"header":{"packet_type":""},"raw":{"length":920},"trigger":"unknown_connection_id"}}
{"time":0.955468,"name":"transport:connection_closed","data":{"owner":"local","connection_code":"","reason":""}}
{"time":0.965467,"name":"transport:packet_sent","data":{"header":{"packet_type":"initial","packet_number":0,"version":"1","scil":4,"scid":"5afbd60f","dcil":5,"dcid":"635f636964"},"raw":{"length":42,"payload_length":23},"frames":[{"frame_type":"connection_close","error_space":"transport","error_code":376,"raw_error_code":376,"reason":""}],"ecn":"Not-ECT"}}

Which quiche is this? Cloudflare quiche or Google quiche? 🙄
Does the handshake fail, or are you just curious about a singled packet_dropped log entry?

Cloudflare quiche, I know the annoyance. It appears the handshake doesn't fail yet? It seems that there is the single packet dropped and then the connection closes. The error number I get on the client side is 178, making me think it has something to do with the ALPNs, we're using some custom ones as a test.
quic-echo-

and
\x08quic-echo-


Hdds 5491: EC: Write should handle node failures.

What changes were proposed in this pull request?
Handled node failures. When nodes failed in write, we will get new block group and proceed to write there.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5491
How was this patch tested?
Added tests

I think I submitted replies via Review button, so they are just duplicated.


Cast vote UI

Vote Referendum Integration

Error state positioning needs to be fixed.

Let's me vote on abstain even with insufficient balance

Will do the needful


Sort the licensing

Hi, currently it seems you don't have an actual license listed.
I would strongly suggest this gets cleared up properly using one of the great OSI licenses https://opensource.org/licenses - that would sort any issues with saying it's open source and just have that box ticked properly.
Thanks :)

You're absolutely right :) Doing that immediately!


[SPARK-44736][CONNECT] Add Dataset.explode to Spark Connect Scala Client

What changes were proposed in this pull request?
This PR adds Dataset.explode to the Spark Connect Scala Client.
Why are the changes needed?
To increase compatibility with the existing Dataset API in sql/core.
Does this PR introduce any user-facing change?
Yes, it adds a new method to the scala client.
How was this patch tested?
I added a test to UserDefinedFunctionE2ETestSuite.

Merging.


Edit Test cases for undo and redo

Did some minor edits for automated test cases for undo, redo, delete (integration) and VersionedAddressBook

Codecov Report

Merging #197 (b7fc2b8) into master (e16a35d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #197   +/-   ##
=========================================
  Coverage     66.99%   66.99%
  Complexity      711      711
=========================================
  Files           114      114
  Lines          2433     2433
  Branches        246      246
=========================================
  Hits           1630     1630
  Misses          694      694
  Partials        109      109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16a35d...b7fc2b8. Read the comment docs.


After Update - An exception has been thrown during the rendering of a template

Winter CMS Build
dev-develop
PHP Version
8.1
Database engine
MySQL/MariaDB
Plugins installed
No response
Issue description
Just updated the working Winter CMS 1.2.1 with composer update and winter:up commands, and it's broken now.

Steps to replicate
So, I get the An exception has been thrown during the rendering of a template ("Undefined array key "about"") in "C:\laragon\www\winter3\themes\mytheme\partials\intro.htm" at line 3.
intro.htm points to hero1.htm which post list component:
[viewBag]

[blogPosts]
pageNumber = "{{ :page }}"
postsPerPage = 7
noPostsMessage = "No posts found"
sortOrder = "random"
categoryPage = "about"
postPage = "blog-post"
==

As I understand the error is pointing to categoryPage = "about" part.
Before the update, it was working
Workaround
No response

@mjauvin I think this issue is caused by the recent refactoring / improvements, are you able to replicate this at all?

Sorry, can't reproduce this.

@01Kuzma are you able to upload a basic version of your theme that contains just enough to replicate this issue in a fresh install of the winter develop branch and the latest blog plugin?

@petehalverson side note, would really love to have Octodock back in some capacity 😉

Maybe this one will help...
filmustudija.zip

I tried your theme, but it is in an unuseable state, plugins/partials missing, layout half beaten to death...
I managed to remove cruft to make it work, and didn't get the error you reported.
Please submit a theme in a usable state and a procedure to replicate your issue with it.

@mjauvin , that's strange. I'm getting some other errors with it, the frontend even is not loading throwing errors...
OK, I will try to remake it.

@mjauvin I've reviewed it, I don't know what to upload, because the theme is image dependent (pulls them from storage), without them, it looks empty (as you probably saw it).
I've just removed the partials with private information and excessive templates.
Removing the component form the page , of course, removes this error.
But I have another one, accessing page Portfolio with two components: Post list & Category List gives this:

Removing the Category List removes the error.

Can you show your Portfolio page ? Specifically, the url and the blogCategories component settings ?
I use this component without any problems on my latest website.

@LukeTowers I was able to generate an error with the blogCategories component when setting an invalid slug to the component slug property. What generates the error is this change:
-    public $currentCategorySlug;
+    public string $currentCategorySlug = '';

PHP now throws an error if you assign null to this Class property because it now expects a string.
So basically, if you have the following page/component settings, it will throw an error:
url = /blog/:slug
layout = default

[blogCategories]
slug = "{{ :invalidSlug }}"
categoryPage = "blog"
==

Notice the {{ :invalidSlug }} assigned to the component's slug property when it should be {{ :slug }}
I suspect it's possible to trigger similar errors in other blog components as well because of the extra property validation that was added. This is not necessarily a bad thing, but might break badly written themes.

@mjauvin , here it is:
title = "Portfolio"
url = "/portfolio/:page?"
layout = "default"
meta_description = "Desc..."
is_hidden = 0

[blogPosts]
pageNumber = "{{ :page }}"
categoryFilter = "{{ :slug }}"
postsPerPage = 10
noPostsMessage = "Įrašų nerasta"
sortOrder = "published_at desc"
categoryPage = "blog-category"
postPage = "blog-post"

[blogCategories]
slug = "{{ :slug }}"
displayEmpty = 0
categoryPage = "blog-category"
==
{% set posts = blogPosts.posts %}

Just change:
[blogCategories]
slug = "{{ :slug }}"

To:
[blogCategories]
slug = "{{ :page }}"

To solve your issue.

@LukeTowers should we change the component like this to restore original behavior ?
diff --git a/components/Categories.php b/components/Categories.php
index 10a958c..b0609e3 100644
--- a/components/Categories.php
+++ b/components/Categories.php
@@ -17,12 +17,12 @@ class Categories extends ComponentBase
     /**
      * Reference to the page name for linking to categories.
      */
-    public string $categoryPage = '';
+    public ?string $categoryPage = '';

     /**
      * Reference to the current category slug.
      */
-    public string $currentCategorySlug = '';
+    public ?string $currentCategorySlug = '';

     public function componentDetails(): array
     {

@mjauvin it solves the portfolio issue.
Why did this happen? I've created this theme long time ago based on some tutorials, as I remember
And how to fix the main problem? What should I change here? "\partials\intro.htm" at line 3.
is pointing to hero-slider/hero1.htm with Post List component, which is:
[viewBag]

[blogPosts]
pageNumber = "{{ :page }}"
postsPerPage = 7
noPostsMessage = "No posts found"
sortOrder = "random"
categoryPage = "about"
postPage = "blog-post"
==

@mjauvin it solves the portfolio issue. Thank you! Why did this happen? I've created this theme long time ago based on some tutorials, as I remember

It happens because there are errors in your theme and the last update to the plugin introduced property validation for the components.

And how to fix the main problem? What should I change here? "\partials\intro.htm" at line 3. is pointing to hero-slider/hero1.htm with Post List component, which is:

Please, always give the full settings section of the page you ask help for, otherwise it's hard to help.

[viewBag]

[blogPosts]
pageNumber = "{{ :page }}"
postsPerPage = 7
noPostsMessage = "No posts found"
sortOrder = "random"
categoryPage = "about"
postPage = "blog-post"
==

@mjauvin , sorry, have edited the last post

@mjauvin , any thoughts regarding last issue?


replace org_user deactivation with removal of org_user role

Resolves #3587
Description
Problem
The issue was that banks could "deactivate" a user (which is essentially a soft delete of the whole User record). However, if that user then went to a Partner they would not be able to invite that user because that user would exist (new User cannot be created) but be soft deleted (existing User is treated like they didn't have permissions).
Solution
Roles got added in https://github.com/rubyforgood/human-essentials/pull/3117. Therefore, the logic around deactivation should address the role not the user.
However, there is a caveat. I attempted to implement logic around deactivating roles themselves in https://github.com/rubyforgood/human-essentials/pull/4392, https://github.com/rubyforgood/human-essentials/pull/4382. But the logic became very complex. We decided (https://github.com/rubyforgood/human-essentials/issues/3587#issuecomment-2138464940) to go for a more architerurally simple solution of removing the deactivation functionality and just deleting the roles.
Drawbacks
There are two main drawbacks with this approach.
Existing Data
What do we do with existing discarded users? Discarded == soft deleted. I can imagine a world where a user was discarded without that meaning to be a "deactivation".
My current idea is that any User that is discarded and only had the org_user role was probably a deactivation and we can reactivate them and remove the org_user role from them. But this requires some more information.
Loss of Granularity
Previously we had 3 states for org_users: active, not an org_user and deactivated (meaning they were a user at one point but not any more).
Now there are only 2 states: user or not. This means we have a bit less information, we can no longer track if someone was once a user but not anymore. Does this matter? Probably not.
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Request + System specs
Screenshots

I hope it's going to be a pretty rare case that someone is going to try to sign in after their role has been deleted, so I'm ok with leaving the slightly confusing error message.  Not the best place to be using our resources if it's too hairy.

Looks good to me! @cielf did you want to take a look?

Looks good to me! @cielf did you want to take a look?

Yes.


Saving lecturers timetable to file can't handle empty timeslots

--> Last day is missing in file

should be fixed with commit 137c7778d067840f24c8df995c3d0c17a276e600


Filters apply a SQL query before anything has been filtered

Steps:

Create an empty dataset
Add a random row
Go to filters
Select a column in the dropdown

Current behaviour:
Without having selected anything, the "SQL query applied" message appears in the Editor:

Expected behaviour:
I would expect a query to be applied when the data is filtered, but not before.

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Uncaught TypeError: self.location.reload is not a function

I kept getting this error whenever i tried to save the project, the project working fine but any idea how to fix this?

+1 I have the same problem

+1

Same issue with my project @lxieyang. I'm relatively new so I can't figure out the solution to this. Thank you.

Any update on this?

I'm seeing this error as well, not blocking development but still annoying

+1

should be fixed!

Still happening for me

+1 still happening