Can this only be achieved using Yaml deployments?

Can we build and deploy to kubernetes using the Tasks/pipline view instead of yaml?
If yes, how do we get imagepullsecret value?
and how do we create the manifest files?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cbceb1f5-05c3-487d-6e21-dc1b4936a55c
Version Independent ID: 35355737-9ad9-9df5-b612-806d9df2462b
Content: Deploy to Azure Kubernetes Service - Azure Pipelines
Content Source: docs/pipelines/ecosystems/kubernetes/aks-template.md
Product: devops
Technology: devops-cicd-ecosystems
GitHub Login: @azooinmyluggage
Microsoft Alias: atulmal

Is there an update on this?
As per my understanding, we can manually create a build pipeline, mimicking this yaml flow. But there are some discrepancies.
For Example:
for task to deploy an app to the cluster, you need to specify manifest files.
In the yaml format, you can specify the multiple files like this:

But in the task view, we can only add 1 file,

Also, it would be great if we could get some documentation around deployment.yml and service.yml manifest files.


Application of the T Model allocation process to estimate plant growth and hence simulate the dynamics of plant growth through time.

The community structure and light capture described in #131, #132, #133 and #134 provide components that allow a community to grow dynamically through time and to represent the canopy and light environment of the community.  The P Model provides a way to calculate productivity and hence use the T Model of allocation to estimate the incremental growth of cohorts.
This needs to be implemented 😄

Has this been superseded by the recent demography updates?

Nope. This is the next stage in the demography.


ignition: add initial docs

There's more to come.

Great start! My main worry is that I don't see a single place that mentions how to actually use this. Where do I put this config file? How do I call it?

The getting-started guide isn't done yet, so I'll add those details in there. We might want an FAQ as well.

I mostly think of this repo as the glue between open source projects and a CoreOS integration. Nearly all of these docs feel like they could go into the Documentation folder on the ignition repo. Is there a reason we are putting them here vs there?

@philips I agree. When I started, most of this was glue, but as I've added to it, some of it has become very Ignition-specific. I'll rebase this once I'm further along.

While a lot of cases of what to do are covered, just important is what Ignition does not handle.  For example, it becomes clear (via the last paragraph in the getting started guide) that using Ignition precludes the user from utilizing cloud-init, cloud-configs have become entrenched in the deployment processes for many users.  This means that folks have become dependent on the use of these files.
As a specific example, what does it look like to configure etcd WITHOUT a discovery service?  How is this done through Ignition?

I notice in re-reading that there is a mention of coreos-metadata in passing, but think of me as "chief idiot @ CoreOS".  If I can overlook that (and it affects a significant tool like etcd) we should feature it's configuration more prominently.

I'm going to merge what we have for now. I will take a second pass and expand on more of these points.

LGTM


MGMT-18977: Solving problems with context menu in 'Add hosts' tab

Related to https://issues.redhat.com/browse/MGMT-18977
Before changes:

After changes:

Resolved in https://github.com/openshift-assisted/assisted-installer-ui/pull/2679


SpanState.GetHashCode should include ParentSpanId

This is a small change but GetHashCode should include parentSpanId to be more consistent with Equals.
  public bool Equals(SpanState other)
        {
            if (ReferenceEquals(null, other)) return false;
            if (ReferenceEquals(this, other)) return true;
            return TraceId == other.TraceId && ParentSpanId == other.ParentSpanId && SpanId == other.SpanId;
        }

  public override int GetHashCode()
        {
            unchecked
            {
                var hashCode = TraceId.GetHashCode();
                hashCode = (hashCode * 397) ^ SpanId.GetHashCode();
                return hashCode;
            }
        }

Good catch! Indeed, we should do Equals and Hashcode against (traceIdHigh, traceId, spanId and parentSpanId) and both must be consistent


ISSUE #165 Amdahl's law

NOTE:

Please fill out the template below

Did you read the instructions in the README?
Y

Y/N

Have you read the instructions in CONTRIBUTING?
Y

Y/N

Have you written this article by yourself? Have you taken inspiration from anywhere and then written it in your words?
Y

[Write here. Be specific.]

30% plagiarised

@megha070 : Nice job! But, please try to lower down plagiarism percent! :smile:

Merging this. Please don't let this repeat @megha070  😄


fix compiler & credo warnings: lib/elixir_script/passes/find_modules.ex

Wanting to help out in some small way. If these changes are okay I'll try to do more in my spare time.

I'm not really sure what is failing here as my local tests are passing. Any pointers?

@onelesd thanks! And don't worry about the failing test. I have to update something in the travis config so it'll fail until I get a chance to fix it


DPL-050 Automated processing on Beckmans: New LH lab Newcastle [Heron]

User story
DPL-050 | As representative fo LH labs (Alan K) I would like to begin receiving covid samples from new LH lab; Newcastle to support automated picking on robotics.
Who are the primary contacts for this story
Alan K (PAM)
Sonia G (PAM)
Cristina A (PAM)
Acceptance criteria
To be considered successful the solution must allow:

[ ] Plate maps standard distributed by Alan to Newcastle lab lead
[ ] Expected file name (individual files per plate): ICHNEnnnnnc.csv
[ ] Enable read from SFTP share /project-heron_newc (Share is there, not checked psd-lims has read access)
[ ] Create lab_id: NCL
[ ] Support creating a plate with barcode ICHNEnnnnnc (where n = character and c = letter) in Sequencescape
[ ] New COG-UK prefix: NEWC
[ ] biomek_labware_class: kingfisher DWP

Assumptions
    No unconsolidated plate map file type expected

Additional context
Change: Expected on line from 19th July

Created draft branches in crawler, baracoda and sequencescape while sftp access is granted and some more information is confirmed.

Pull requests:
https://github.com/sanger/crawler/pull/400
https://github.com/sanger/baracoda/pull/166
https://github.com/sanger/sequencescape/pull/3267

Tested this in our UAT environment today, using the file that’s on the SFTP - ICHNE00014W.csv
It didn’t process successfully (see entry at 26/07/2021, 14:31:05 in Lighthouse UI) – the main issue seems to be that their CT targets use a different capitalisation to the plate map standard.

Plate map standard
Newcastle file
Difference

ORF1ab
Orf1ab
Capitalisation

S gene
S Gene
Capitalisation

N gene
N Gene
Capitalisation

MS2
MS2
No difference


11166 fix OData default value for Collections

It was hard to find conclusive docs; I finally found some context in https://issues.oasis-open.org/browse/ODATA-1071. OData explicitly disallows Collections from being null, requiring that they be empty arrays instead. For Collections, the Nullable attribute applies to its children instead of the property itself.
Hotfixing and re-caching on Secure2 immediately so Zied can use it.

Specs are flappers


Added Ashwin Santhosh to the list of people who completed the git tutorials

Added Ashwin Santhosh to the list of people who completed the git tutorials

@AshwinSant5  Hey Ashwin, you are supposed to make a new branch on your fork. Currently you are doing the work on AshwinSant5:main, which is not recommended.


how to use the payload

I fuzz the linux by https://intellabs.github.io/kAFL/tutorials/fuzzing_linux_kernel.html.
I found some payload here

Could anyone tell how to use the payload to reproduce the crash. I didn't find tutorials.

Hi @gjm-anban ,
You can have a look at the kafl debug subcommand to replay a single payload.
The command line is similar to kafl fuzz, except that it takes an input file parameter, which is the payload.
I agree that documentation is missing on how to proceed with a fuzzing campaign, i'll add a note to do it this month !
Thanks for the feedback !

thanks, I can run the payload now
KAFL_CONFIG_FILE=./kafl_config.yaml kafl debug --kernel linux-guest/arch/x86/boot/bzImage -m 512 --input /dev/shm/kafl_root/corpus/crash/payload_00125 --action gdb --resume

hello，@Wenzel.
I tried using kafl debug to test Payload, but the program would always stop waiting for the snapshot to start.I tried to copy the qemu command and execute it in bash,it also had not any output.Here is the kafl debug log,I don't know how to run it correctly.
kafl debug --resume   --kernel /home/liu/linux-guest/arch/x86/boot/bzImage --memory 2048  --input /dev/shm/kafl_root/corpus/kasan/payload_00001 --action gdb
No trace region configured! Intel PT disabled!
Starting Qemu + GDB with payload /dev/shm/kafl_root/corpus/kasan/payload_00001
Connect with gdb to release guest from reset (localhost:1234)
Worker-1337 Launching virtual machine...
/home/liu/kAFL/kafl/qemu/x86_64-softmmu/qemu-system-x86_64
-enable-kvm
-machine kAFL64-v1
-cpu kAFL64-Hypervisor-v1,+vmx
-no-reboot
-net none
-display none
-chardev socket,server,id=nyx_socket,path=/dev/shm/kafl_root/interface_1337
-device nyx,chardev=nyx_socket,workdir=/dev/shm/kafl_root,worker_id=1337,bitmap_size=65536,input_buffer_size=131072
-device isa-serial,chardev=kafl_serial
-chardev file,id=kafl_serial,mux=on,path=/dev/shm/kafl_root/serial_1337.log
-m 2048
-s
-S
-kernel /home/liu/linux-guest/arch/x86/boot/bzImage
-append root=/dev/vda1 rw hprintf=4 nokaslr oops=panic nopti mitigations=off
-netdev user,id=mynet0
-device virtio-net,netdev=mynet0
-fast_vm_reload path=/dev/shm/kafl_root/snapshot/,load=on
[QEMU-NYX] Max Dirty Ring Size -> 1048576 (Entries: 65536)
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.07H:EBX.hle [bit 4]
qemu-system-x86_64: warning: host doesn't support requested feature: CPUID.07H:EBX.rtm [bit 11]
[QEMU-NYX] Dirty ring mmap region located at 0x7fbdedd9c000
[QEMU-NYX] Warning: Invalid sharedir...
[QEMU-NYX] Waiting for snapshot to start fuzzing...

Hi @gjm-anban ,
You can have a look at the kafl debug subcommand to replay a single payload.
The command line is similar to kafl fuzz, except that it takes an input file parameter, which is the payload.
I agree that documentation is missing on how to proceed with a fuzzing campaign, i'll add a note to do it this month !
Thanks for the feedback !

Hi @liujf628995,
When using the GDB kafl debug action, QEMU starts with -S:
-S              freeze CPU at startup (use 'c' to start execution)

so you need to connect to the QEMU instance with gdb and release the execution
gdb
(gdb) target remote :1234
(gdb) continue

Hi @liujf628995,
When using the GDB kafl debug action, QEMU starts with -S:
-S              freeze CPU at startup (use 'c' to start execution)

so you need to connect to the QEMU instance with gdb and release the execution
gdb
(gdb) target remote :1234
(gdb) continue

@Wenzel Thanks for your help!


Switch with offBackgroundColor throws 'getTrackDrawable' of undefined

Environment
Provide version numbers for the following components (information can be retrieved by running tns info in your project folder or by inspecting the package.json of the project):
√ Component nativescript has 6.5.0 version and is up to date.
√ Component tns-core-modules has 6.5.0 version and is up to date.
√ Component tns-android has 6.5.0 version and is up to date.
× Component tns-ios is not installed.

Angular: 8.1

Describe the bug

When I use Switch with offBackgroundColor it throws TypeError: Cannot read property 'getTrackDrawable' of undefined error message.
 <Switch [(ngModel)]="checklistFilters.visited" color="#b3e6f9" backgroundColor="#000000" offBackgroundColor="#444444" padding="0" margin="0" ></Switch>

Hi @csimpi,
Can you provide an example? Take a look on this  playground, I can't replicate your bug.
As a workaround, I recommend you to style the switch via CSS

Switch {
off-background-color: #444444;
background-color: #000000;
}

@Pandishpan I can't reproduce it with the playground, but maybe it's due to the playground limitations, I'm definitely getting this issue due to using offBackgroundColor. If I remove it I'm getting the error msg, when I remove it it stops.
What does this 'getTrackDrawable' of undefined means? Maybe that'd help to reproduce it. I don;t really understand this error msg.

@csimpi getTrackDrawable is a method of the native Android component
https://developer.android.com/reference/android/widget/Switch#getTrackDrawable() so you are most likely hitting some bug related to setting the native property under specific circumstances - can you please provide a sample project that reproduces the issue.

I have got the same error.
@Pandishpan  Thank You for this workaround

Same error for me, App crashes on Android if off-background-color is used:
TypeError: Cannot read property 'getTrackDrawable' of null
StackTrace:
at push....../node_modules/@nativescript/core/ui/switch/switch.js.Switch.setNativeBackgroundColor()
at push.../node_modules/@nativescript/core/ui/switch/switch.js.Switch._onCheckedPropertyChanged()
...

I if remove off-background-color CSS style for the Switch type, no crash happens.
Isolation of the issue is difficult. In our App it happens right after navigating to a view where a Switch is used and the checked property of the Switch is bound to a variable which gets updated asynchrounously.
So I suspect a timing/rendering race condition as the root cause.


Module may cause "Area Code  already set" exception when running other commands

With this module installed and enabled, running commands of other modules may result in an exception because the Area Code is set twice.
This is caused by Webkul\CodeGenerator\Console\Command\Generate setting the area code in the constructor.
The constructor is called every time magento is run on the command line, regardless of which command is run. If another command needs to set the area code, it does so in the execute() method which is called after all the constructors of all available commands. Since the constructor of Webkul\...\Command\Generate already sets the area code, by the time the command is executed, the area code has already been set and the command fails.
For more details see:
https://help.klevu.com/support/solutions/articles/5000871360-area-code-is-already-set
and
https://magento.stackexchange.com/a/332885

@arion-p We have fixed this issue in our latest commit as this has been added for custom commands now we have updated the module you can check now. You can take the latest code from the below commit.
https://github.com/webkul/magento2-code-generator/pull/43/commits/bd09067f09d93c5506cb350bdb28af7d2c7e889b


Custom kube-scheduler

Is your feature request related to a problem? Please describe.

I want to use a custom scheduler plugin from  https://github.com/kubernetes-sigs/scheduler-plugins/ as default-scheduler.
Right now I can disable the default scheduler using --disable-scheduler but I am not sure how to enable the replacement.
Describe the solution you'd like

Not sure. An option to use a container instead of an embedded feature in the binary?
Describe alternatives you've considered

Using schedulerName in the pods
Additional context

N/A
Backporting

[ ] Needs backporting to older releases

I don't believe there's anything stopping you from using a different scheduler. K3s doesn't have any built in though - if you want to run your own as a pod, you'd need to solve the chicken-and-egg problem of getting it running. Leaving the default in place and using schedulerName to use your alternative one is probably the best bet.

Closing. Using a secondary scheduler with schedulerName is enough. Thanks"

I want to customize a scheduler. How can I use k3s to debug the scheduler like using k8s?

May I ask how to register the customize scheduler to k3s?

Please check https://github.com/kubernetes-sigs/scheduler-plugins/blob/master/doc/install.md#as-a-second-scheduler

Thank you very much.  I didn't know there can be multiple schedulers.


Csharp GeneratedCode attribute - version 1.0.0?

Recently, after upgrading Kiota tool to version 1.19.1, and regenerating my http clients, I noticed that in various places the generated code is annotated with:
[global::System.CodeDom.Compiler.GeneratedCode("Kiota", "1.0.0")]

Before upgrading Kiota, it was:
[global::System.CodeDom.Compiler.GeneratedCode("Kiota", "1.18.0")]

Is it an expected behavior for kiota 1.19.1 to generate attributes with version 1.0.0?

Hi @marcinjahn
Thank you for using kiota and for reaching out.
This is an expected change. See #5489 for context.
Let us know if you have any additional comments or questions.


Panel header spacing/alignment issues

VSCode Version: Code - Insiders 1.9.0-insider (882244ea24cb0b89a9a0c6c649c8f857fb0bc408, 2017-01-23T07:12:16.134Z)
OS Version: Windows_NT ia32 10.0.14986
Extensions:

Extension
Author
Version

vscode-svgviewer
cssho
1.3.0

EditorConfig
EditorConfig
0.3.4

git-project-manager
felipecaputo
1.0.1

md-navigate
jrieken
0.0.1

vscode-scss
mrmlnc
0.6.0

seti-icons
qinjia
0.1.3

lorem-ipsum
Tyriar
1.0.0

terminal-tabs
Tyriar
0.1.1

theme-glacier
Tyriar
0.0.10

Problems:

There are 4 different horizontal spacings between items on the panel (9, 13, 20, 33), they should probably all be 20?
The icons and panel headers seem to be 1px off
The add button has an odd height so it cannot be aligned exactly
The dropdown is not vertically centered (on all platforms)

The 20px to the left is in sync with what we do elsewhere (e.g. sidebar). Panels have a spacing of 30px each, I would not apply this on the right hand action side.
So your bug is basically about fixing the right hand action side which was actually not changed for this release. I let @bgashler1 decide if we want to revisit this now that we have the panel switcher in place.

We can look at this in a future release.  As Ben has said, I've actually never touched the right side.

@jamiedawsonyoung - do you have any thoughts on this? The spacing issues mentioned in this bug are in the horizontal panel which you can bring up by going to the View menu and choosing Output/Problems/Terminal/Debug console


Proper python package and develop install

Right now there exists a setup.py that can do develop installs and might even be able to generate a wheel that could be used.
Finish this up so it's actually easy to install with pip / other python build frontends

You can now do develop / editable installs with the current pyproject.toml, merged in #10


Type incompatibilities with Ethers

SafeEventEmitterProvider is not type-compatible with Ethers. Specify, when passing an instance of SafeEventEmitterProvider to Ethers v5's Web3Provider class, the following type error is produced:
[tsserver 2345] [E] Argument of type 'SafeEventEmitterProvider' is not assignable to parameter of type 'ExternalProvider | JsonRpcFetchFunc'.
  Type 'SafeEventEmitterProvider' is not assignable to type 'ExternalProvider'.
    Types of property 'sendAsync' are incompatible.
      Type '(req: JsonRpcRequest<unknown>, callback: (error: unknown, providerRes?: any) => void) => void' is not assignable to type '(request: { method: string; params?: any[] | undefined; }, callback: (error: any, response: any) => void) => void'.
        Types of parameters 'req' and 'request' are incompatible.
          Type '{ method: string; params?: any[] | undefined; }' is missing the following properties from type 'JsonRpcRequest<unknown>': jsonrpc, id

With Ethers v6's BrowserProvider class, the following type error occurs:
[tsserver 2345] [E] Argument of type 'SafeEventEmitterProvider' is not assignable to parameter of type 'Eip1193Provider'.
  Property 'request' is missing in type 'SafeEventEmitterProvider' but required in type 'Eip1193Provider'.

To fix compatibility with Ethers v5, we could modify sendAsync and sync to automatically fill in id and jsonrpc with appropriate values. However, I'm not sure that this effort is worth it considering that v5 will only get more and more obsolete over time.
To truly fix compatibility with Ethers v6 and up, we'd need SafeEventEmitterProvider to support request, and we'd need it to be EIP-1193-compatible.


🚧  update to @octokit/webhooks TypeScript edition

See https://github.com/octokit/webhooks.js/pull/113

done in https://github.com/probot/probot/pull/1274


Is it supported to convert to Apple CoreML? I tried to use coremltools to convert this model to CoreML format, but encountered an error.

The error message is as follows:
raise NotSupportedError(r, "Comprehension ifs are not supported yet") torch.jit.frontend.NotSupportedError: Comprehension ifs are not supported yet:   File "/Users/Lucas/Library/Python/3.9/lib/python/site-packages/transformers/models/llama/modeling_llama.py", line 947         next_cache = next_decoder_cache if use_cache else None         if not return_dict:             return tuple(v for v in [hidden_states, next_cache, all_hidden_states, all_self_attns] if v is not None)         return BaseModelOutputWithPast(             last_hidden_state=hidden_states,

This project was meant to be trained and inferenced on a GPU. It does extend to CPU via GGUF, but there is no real support for CoreML/Metal, beyond the standard levels from lit-gpt


[DRAFT] [Communication Chat] GA 2023-11-07 for inline image feature

Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
APIView has identified API level changes in this PR and created following API reviews.
Azure.Communication.Chat


No Vignette

After installing the command vignette("CAPR_tutorial", package = "Capr") says that there is not a vignette.

@rfherrerac
The package must be installed with the "build_vignettes = TRUE" option.
e.g.
# install CAPR along with CirceR dependency
install.packages("remotes")
drat::addRepo("OHDSI")
remotes::install_github("OHDSI/CirceR")
remotes::install_github("ohdsi/Capr", build_vignettes = TRUE)

# run the vignette
vignette("CAPR_tutorial", package = "Capr")


Masks for Priests and Cultists

Create GFX for the masks

Still requires some fine-tuning, but mostly works.

Works for the cult without problems.
For the religion, overwriting the religious headgear entries for now, but will look further into:
https://ck2.paradoxwikis.com/Portrait_modding#Portrait_scope


Feature proposal: Command abbreviation and Set Multi Cursor with keyboard

Hi Richard,
Would be good to have abbreviation for the commands, for example:
Open File = of
Would be good too to have the choice to set multi cursors in different positions (not only vertical) with keyboard. For example, you choose a shortcut and you set many positions has you like and you go down, up, left and right and set the cursors where you want them.

Nice idea again @alexmigf :)
The command abreviations will probably be implemented, I'll just need to create a user configurable alias map in the config.
Right now there are 3 ways of adding cursors:

Press Alt + Up / Down / Left / Right (this will add a cursor in the direction you press.)
Pressing Ctrl + D will find the word that begins at the cursor and add a new cursor at the next word
Activate mouse mode (F8) and right click at any place you want to add a cursor

I'm not sure if I understood correctly, but is this what you are asking: Add new cursors by moving the 'main' cursor to a new place and then saving that place as a new cursor? That sounds like a nice idea. Let me know if I understood correctly :)

The same thing of the Mouse (F8) but with the keyboard, some shortcut.

Regarding the command abbreviations, I think #171 will help with making commands faster to run (and it will probably be implemented before the aliases.) However I will implement command aliases after that too.
Placing cursors via the keyboard will require more work, since currently all the cursor moving code is built to move all cursors at once. So that might take some more time get implemented. On the other hand, it might be easier to let the user select the desired positions without actually adding cursors. Then when the user is ready they can press a key and the cursors get added.


How the ciphertext*ciphertext multiplication works

According to the seal manual (https://www.microsoft.com/en-us/research/uploads/prod/2017/11/sealmanual-2-3-1.pdf), before the relinearization,
c0 = [t/q (ct0[0]ct1[0])]_q

c1 = [t/q(ct0[0]ct1[1]1+ct0[1]ct1[0])]_q

c2 = [t/q(ct0[1]ct1[1])]_q

where the multiplications like ct0[0]ct1[0] or ct0[0]ct1[1] etc, are non modular both in polynomial and in coefficient. So if we have a a degree 4096 ct polynomial the product is going to be degree 24096. The reduction happens only after the product is computed, so in theory I'd have to compute a 24096 degree polynomial. This is not a problem if I use the NTT for degree 2*4096 with a bunch of zeros appended to the end of each 4096 degree polynomial, but still the NTT is going to be modulo q on the coefficients, but we should do the modulo after the multiplication by t/q.
I tried finding how the multiplication is done in SEAL and found this paper https://eprint.iacr.org/2018/589.pdf but I couldn't understand how it's done.
How to do this multiplication efficiently?

Most of the current RLWE library use the negacyclic convolution NTT which does not double the polynomial degrees. In a  words, we only take care 4096 coefficients all the time.
The t/q should be a divide-then-round operation round(t/q*x) which takes x \in [0, q) and the output  is also in [0, q)

Yes, but the tensor products c0, c1 and c2 require a double degree multiplication, then multiply by t/q, and only then round and reduce the degree and coefficient
-------- Mensagem Original --------
Em 1 de mar. de 2023 22:49, Juhou escreveu:

Most of the current RLWE library use the negacyclic convolution NTT which does not double the polynomial degrees. In a words, we only take care 4096 coefficients all the time.
The t/q should be a divide-then-round operation round(t/q*x) which takes x \in [0, q) and the output is also in [0, q)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

No need to double the polynomial degree, we can think the negacyclic convolution NTT also work for some Q > p^2.
What actually matter is to keep the double precision.

3*5*7*X > C*q^2 for some constant C. For instance, we can use a heuristic bound C = 2*sqrt{degree}
For BigInt, we can get a value x \in Z_{3*5*7*x} , then the divde-then-round is simply round(t/q*x) mod q.


[ISSUE #4991] add unit test for LogUtil

Fixes https://github.com/apache/eventmesh/issues/4991
Motivation
Increase test coverage
Modifications
Added new tests for LogUtil.java located https://github.com/apache/eventmesh/blob/master/eventmesh-common/src/main/java/org/apache/eventmesh/common/utils/LogUtilTest.java
Documentation
Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Hi, please resolve the failing CI errors. To resolve the issue, you can view the test report generated during the build.

hello @harshithasudhakar, I tried solve this problem but I cannot understand. There were failing tests. See the report at: file:///Users/runner/work/eventmesh/eventmesh/eventmesh-common/build/reports/tests/test/index.html  when I saw this location but there is not fail test in index.html. Could you help with this problem?

I re-ran the log, it has passed :)

@harshithasudhakar Hello, I want to close this PR. I need someone else to accept it. Can you help me?

good job


Add regular calculator to sidebar

I would like to see a simple Regular calculator added to the RuneLite client

I dont think we really want to implement this because calculator is not really related to RuneScape and it takes like 2 seconds to open Windows open.

What are some of the instances where you would use a calculator?
I think supporting chat commands like:
!maths 70395*93853
(arithmetic operations in Java syntax for simple parsing)
is a better alternative. I always find alt-tabbing a hassle.
I agree in that a full-blown calculator is a bit overkill for the client.

I might work on this...

WINDOWS CALC SUCKS GIVE CALC OR RIOT REEEEEEEEEEEEEEEEEEEEEEEEEEE

No


:lady_beetle: The wizards of creating StorageMap and NetworkMap are missing

On the latest 2.6.0, the old wizards of creating StorageMap and NetworkMap are missing.

adding @dgur for visibitly


Added explore cc button on submit page

Fixes

Fixes #225 by @praveen-rikhari

#225

Description

This PR resolves the issue of the missing "Explore CC" button on the /submit page by introducing a separate layout file, submit.html. Instead of manually including the content for /sumbit page, this approach streamlines the process by dedicating a specific layout file for the /submit page. By incorporating the Explore CC button within this layout, users can seamlessly navigate and explore CC resources while engaging with the submission process.
Technical details

Created a new layout file named submit.html to handle the layout of the /submit page.
Integrated the "Explore CC" button within the "submit.html" layout file by including header.html, ensuring its visibility and accessibility to users visiting the /submit page.

Screenshots

Before :

After :

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main or master).
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Hi @possumbilities @TimidRobot Please have a look on my PR and let me know if any changes are requied.
Thanks

Thanks @TimidRobot I appreciate the work and ready to do such more contributions


Spec for font features and axes of variation

Summary of the Pull Request
Spec for how we could allow users to define font features and axes of variation.

References
#1790

PR Checklist

[ ] Closes #xxx
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[x] Is documentation
[ ] Schema updated.
[x] I work here

Detailed Description of the Pull Request / Additional comments
Read the spec!

Impressive spec! This makes me realize  DxFontInfo is more important than I think, as it also opens up the opportunity for all the other font features.

nit: put the epic number in the filename!

and link it in the body (in the yaml front matter)


Make a demo video

Demo should be short, explanatory pitch. Video length should be somewhere between 3-5 minutes
Need to decide:

How to make the demo video
What part will be cover by whom
What software to use for recording and editing

Things to include in the video:

Team Introduction
Project Idea
Tech stack
Project Overview (Demo)


NVSHAS-9413: UI-Ext: Compliance page

When clicking pie chart button on a selected compliance, the chart is not shown.

There is not CSV report for compliance list.

As the image does not have external link, we don't use pointer as cursor. Please change it into default which is the same as NeuVector.

In advanced filter, when I add filter for node, container, service, image, they can be added at the same configuration in NeuVector, but it cannot be added in UI extension.
When I try to choose node on the criteria list after service filter was set, the option cannot be selected in the dropdown.

@xingzhang-suse All issues should now be fixed, thanks for the input


password,data   data,password

documentation (https://github.com/vibornoff/asmcrypto.js#hmac_sha256)
says
HMAC_SHA256.base64( password, data )
But code is :
function hmac_sha256_base64 ( data, password ) {
var result = hmac_sha256_bytes( data, password );
return bytes_to_base64(result);
}
Following code seems to be correct, is the documentation outdated?

Yep, documentation is outdated. Thanks a lot for paying attention.

Yes, this has also just cost me half a day in tracking down the problem. I only figured it out after checking the source. I just wanted to report it, when seeing that there was a ticket on it already.
All the HMAC functions' documentation is "out of whack" with regards to this.
Wouldn't it make sense to use JSDoc strings for the implementations in the source code. That way stuff like that would more easily be found at the time of development, and the actual documentation then can be generated mechanically rather than having to write and maintain it manually?

On another note: There are also no unit tests for the HMAC implementations.


Update dependencies to allow newer rxjs

Angular RC6 is dependent of "rxjs": "^5.0.0-beta.11". It would be nice to update package.json of ngrx store to allow this version (and test it with it of course). Right now node throws 'UNMEET PEER DEPENDENCY' warning.

rxjs has been floating since 2.1.2
https://github.com/ngrx/store/commit/e14042c6d071d9f6c03f799d628535f75b027ab3 r

+1
rxjs is locked in  package.json to "rxjs": "5.0.0-beta.6"
Please update as TiS suggested.

There is already a semver range for rxjs in the current published version.


Adds generators for Norwegian (nb_NO) counties and "kommune", using existing static arrays in the class

The static arrays for "countyNames" and "kommuneNames" were already present in the class to seed the random selection groups, there were just not accessor methods to generate a county or a "kommune". This commit just adds in these accessor methods.

please add a related mention in the locale-specific section of the Readme. Also, please rebase to avoid merge commits.

bump

@jamesinglis
Are you still interested in working on this? If so, we could help you get this through!

Closing this because it got stale. Please feel free to reopen if needed


fabric - add more complicated sequences to fabric. support the env and checkers for it.

add full fabric seq - create a stress seq, all tiles full.
add support for tb - not generate a transaction in to a tile that already has a transactions in it.
add DI checker- create a generic DI checker for all cases, check that the transaction did get from source to target for each trans.
create more generic TB (maybe instead of the `ASSIGN macro).

@ShmuelSfez regarding "2" - to be more precise, "not generate a new transaction from a tile that has back pressure from the router"

@amichai-bd - can i assume for my checker that if a transaction is get into a local tile then it is the final target from perspective of the source that send the request?

Yes

done

@ShmuelSfez - looking at the fabric level0, I dont see param overrides. is that expected?


Bmat

Hi,
I am trying to run example 14 and 24. However, they don' run because the function Bmat is not recognized (" name 'bmat' is not defined").
Sebastien

There were some recent changes in the library. You need to either use the library version from master or then scroll back the history to the latest release, e.g., https://github.com/kinnala/scikit-fem/tree/7.0.1/docs/examples
Perhaps I need to redefine the links in the documentation to point to the latest release.

In principle, the documentation urls are now fixed. However, there seems to be some mismatch of Sphinx versions at Readthedocs and my computer because the links look a bit different.


PSMove controllers Jitter alot when in SteamVR and Drift like crazy when in config tool.

When upgrading from 8.7 to 9.0 I've noticed that my controllers now vibrate like crazy when I move but when I stand perfectly still they don't move an inch (Like they're supposed to).
Before, with 8.7 I never had this issue. So I'm thinking it's the update? Not sure to be honest. Just a bit annoying when trying to play Beat Saber and I get 0 points when I hit a box >.>

As Predicted, Rolling back to 8.7 resolves the issue and I see 0 jitter and 0 crazy sway.
So, I'm guessing 9.0 has some bugs. X.x


⚠ Bofrost.at has degraded performance

In b11997f, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1360 ms

Resolved: Bofrost.at performance has improved in aaf6c33.


Support ClamAV as a Service Type

A lot of customers require the use of ClamAV within their cluster. This is better to be run as a dedicated service over TCP/IP then building into the Nginx/PHP images (in executable mode).
Advantages of running a single service in the cluster:

Only a single virus database to update (with FreshClam)
Consumes less resources overall (only 1 deployment in the cluster)
TCP/IP scanning is much quicker than executable mode

It would be excellent if we could support this as a dedicated Lagoon service type, running on port 3310 (default port). Custom livenessProbe and readinessProbe configuration can be made to ensure we cater for the initial launch time (which can be several minutes while ClamAV initialises it's database).
At the moment, we are seeing customers create ClamAV deployments using the node service type, this has many disadvantages, mainly:

Runs on port 3000, so you need to edit the default configuration, this is confusing
The livenessProbe and readinessProbe are not tuned to ClamAV
The CPU and RAM resources are not tuned to ClamAV

I think this can be considered in two parts:

Creation of a standard, optimized ClamAV image for use in Lagoon
Creation of a helm chart with the correct configurations for running in a lagoon-remote installation

yea, for me clamav doesn't belong into lagoon, this should be deployed as a cluster level tool via helm.
Deploying it via lagoon doesn't really have any advantages and its also not a web-application like everything else in Lagoon.
Therefore to not add too many complicated things I would suggest to just deploy this via helm into the cluster and not worry about it in lagoon.

I agree with @Schnitzel  - theres no value for us to run clamav as a lagoon project, beyond a simple way to deploy it.
If it came as part of Lagoon, deployed with helm or whatever, I'd drop ours in a heartbeat.

yah - clamav in cluster is preferred. There are now more lagoon service types that could be used for clam though - basic or worker?


Bump Docker Build to Node 12.18.3

Update our node version to 12.18.3 in our docker build job, also updating the run command to open a pseudo TTY.
Checklist

[ ] PR has an informative and human-readable title

PR titles are used to generate the change log in releases; good ones make that easier to scan.
Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code follows the standards laid out in the CFPB development guidelines
[ ] Future todos are captured in comments and/or tickets
[ ] Project documentation has been updated, potentially one or more of:

This repo’s docs (edit the files in the /docs folder) – for basic, close-to-the-code docs on working with this repo
CFGOV/platform wiki on GHE – for internal CFPB developer guidance
CFPB/hubcap wiki on GHE – for internal CFPB design and content guidance

Front-end testing

Browser testing
Visually tested in the following supported browsers:

[ ] Firefox
[ ] Chrome
[ ] Safari
[ ] Edge 18 (the last Edge prior to it switching to Chromium)
[ ] Internet Explorer 11 and 8 (via emulation in 11's dev tools)
[ ] Safari on iOS
[ ] Chrome on Android

Accessibility

[ ] Keyboard friendly (navigable with tab, space, enter, arrow keys, etc.)
[ ] Screen reader friendly
[ ] Does not introduce new errors or warnings in WAVE

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Does not introduce new lint warnings
[ ] Flexible from small to large screens

@alexm118 This looks good. We can try building it before merging, by running the job with the origin/add-exit-code ref.

A suggestion is to also change node from 10 to 12 here: https://github.com/cfpb/cfgov-refresh/blob/master/Dockerfile#L28

@cwdavies I think the point here is not to do the upgrade (there's another PR for that, #5789), but just to see if we can build the artifact with Node 12 using Docker without issue (since we can't install Node 12 on Jenkins with the version of RHEL they're running).

@willbarton The test run passed and ran in under 9 minutes - lets see how it works in action.


figure 4 (b) of paper

is the figure 4 (b) of the paper for T=1000 or T=2000? If its for T=1000 then shouldn't the random guess baseline loss be 0.02?

Yes, you are right, that is the plot for T=2000. We will correct this in an updated version.
Here is the plot for T=1000, in case you are curious:


Postprocessing and visualisation pipeline

Convert notebooks to scripts that can run in pipeline:

postprocess to TIFFs
reduce resolution for visualisation
plot global maps (exposure to 100yr; change over time)
postprocess to geobuf; via ldgeojson to MBTiles for web mapping

For postprocessing to TIFF and downscaling, see https://github.com/nismod/open-gira/blob/cea3fe016a04507bdeb219dd63f2ad31c9430e14/explore-plot.ipynb


ApplicationInsights Java Agent 3.2.11 failed to start (PID 1)

Bug Report - Local Test Execution
No Connection String or Instrumentation Key Provided
Expected Behavior
Should Spin up Connector and Registration without any error
Observed Behavior
After building all the binaries, jar, and applying docker-compose command the connector and registration service throws error
Steps to Reproduce
Steps to reproduce the behavior:

Apply command ./gradlew build -x test
Build Connector JAR and Registration JAR
Apply command docker-compose -f system-tests/docker-compose.yml up --build
See error

Used version MVD:Latest
OS: [Windows]
java 11.0.17 2022-10-18 LTS
Java(TM) SE Runtime Environment 18.9 (build 11.0.17+10-LTS-269)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.17+10-LTS-269, mixed m

Detailed Description

Hi.
I have the same problem with Windows, Ubuntu and CentOS (https://github.com/eclipse-dataspaceconnector/MinimumViableDataspace/issues/98).
But I made it working with WSL2. Can you try it with WSL2 (Ubuntu 20)?
One more thing, to run MVD, you must this docker-compose, with the UI profile:

docker-compose --profile ui -f system-tests/docker-compose.yml up --build

PJC

FYI I don't think AppInsights actually caused the crash. It may look that way, due to the amount of logs it spews out, but it actually wasn't.
The last line in your log is what caused the crash, unfortunately the actual exception was swallowed by JDK logging, which I ripped out alongside AppInsights. Current main should give you a stacktrace

I agree because I did run the MVD correctly and the error message still appears.
The crash is not related to the AppInsights. It is something else.

@paulocabrita-ionos this issue was opened long time ago? It is still relevant?

IMO app insights could get removed if people take issue with it. AFAIK it is not really used ATM, but it also doesn't do any harm other than a bit of error logs.

@bscholtes1A , for me, it's not relevant in order to have the solution working..


refactor: project model using targets, features and environments

First refactor to support multiple environments.
This PR refactors the internal project model and adapts the code to use it. The concept of a Feature and a Target is introduced. At the moment when parsing the project manifest a "default" feature is created which is used throughout the code.

[!NOTE]
to reviewers, this is a first PR of a few to come. I want to quickly and iteratively land PRs. This is not the final result.

Feature
In the multi-env story Features describe a set of dependencies/tasks/etc. This concept was also introduced in the project model. At the moment there is only one default feature (described by all the keys at the root of the toml) but the project model already supports multiple features which we can use in a follow-up PR.
Target
A target encapsulates everything that you can find in for instance a [target.win-64] table. The same datastructure is reused for elements "at the root" e.g.
[dependencies]

is internally rewritten to
[target."default".dependencies]

where "default" has a special meaning.
Targets is a datastructure that encapsulates a collection of targets and allows querying which targets apply in certain situations. E.g.
[dependencies]
..

[target.linux-64.dependencies]
...

Targets will hold two Targets, the default target ([dependencies]) and the linux-64 target. You can request all applicable targets for a certain platform and it will return these two targets in order of most specific first.
Environment
Environment is already part of the model (with a default one being created) but it is not yet used throughout the rest of the code. A followup PR will refactor the codebase to always use Environments to derive the tasks, dependencies and system-requirements currently available.
Tests
The PR refactors a lot of snapshot tests. Since the project model is now very different from the toml layout the debug snapshots
often didnt make a whole lot of sense. I changed most of the tests to more closely verify the actual expected result of certain operations instead of "just" outputting a snapshot. Hopefully this makes them less prone to change with future iterations.

Ill drop some errors in this review while testing:
[target.linux-64.dependencies]
compilers = ">=1.6.0"

[dependencies]
# Dev dependencies
pre-commit = "~=3.3.0"

results in :
  × failed to parse pixi.toml from /home/rarts/development/pixi
  ╰─▶ failed to parse project manifest
    ╭─[pixi.toml:35:1]
 35 │
 36 │ [target.linux-64.dependencies]
    · ┬
    · ╰── invalid table header
duplicate key `dependencies` in table `target.linux-64`
 37 │ compilers = ">=1.6.0"
    ╰────

@ruben-arts Should be fixed now!


Persistent AR inclination calibration

It appears (from coordinate-placed beacons and the virtual horizon) that there is a ca. 2° offset (points show "too low" on the camera image) on my device (Pixel 3a). Unfortunally, AR calibration currently seems to calibrate the compass, but not the inclination (gyroscope?). It would be nice if

The inclination could be calibrated to match the correct camera angle
The calibration were remembered so as to not having to re-calibrate the offset on the next run

Beautiful app, by the way!

Thank you for the suggestion, I will look into accelerometer calibration and see if that can be persisted. That should be easier to calibrate than the compass for persisting.


@storybook/addon-info skips PropTypes.object

Issue details
When displaying Component information with @storybook/addon-info, we can see its accepted and default props. To define these, we would use Prop-Types. One of the available types is PropTypes.object. When used in a Component, @storybook/addon-info will not display it in the PropTypes table, we get empty DOM node (table cell) instead.
Other types render fine, just this one seems to get skipped.
Steps to reproduce
Create a component like in the example below and render it with the addon.
Please specify which version of Storybook and optionally any affected addons that you're running

@storybook/addon-info: 3.3.14
@storybook/addons: 3.3.14
@storybook/react: 3.3.14

Screenshots / Screencast / Code Snippets (Optional)
import React, { Component } from 'react';
import PropTypes from 'prop-types';

class ExampleComponent extends Component {
  render() {
    return <div>{this.props.children}</div>
  }
}

ExampleComponent.propTypes = {
  thisWillBeBlank: PropTypes.object,
};

export default ExampleComponent;

I can confirm this can be reproduced in official example:
http://storybooks-official.netlify.com/?selectedKind=Addons|Info.React Docgen&selectedStory=Comments from PropType declarations&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Fstories%2Fstories-panel
BTW, is there any particular reason not to use propTypes.shape in your case?

Not really @Hypnosphi. And thank you!

@CLL80 Good find! I hope @Hypnosphi says yes!

Please let me know if a PR to fix this issue would be accepted.

Sure, you're welcome

Released as 3.4.0-rc.4


Feat: Pings for leveling up should be enabled above level 40 or 50

Is your feature request related to a problem? Please describe.
Removing pings for early leveling was a good choice, but I don't feel like it should be removed altogether. Getting pinged for reaching higher levels is nice, as you can know when you've hit a milestone easier and prevent missing them altogether
Describe the solution you'd like
Make level-up messages start pinging upon reaching level 40 or 50
Describe alternatives you've considered
A lower or higher number would be ok too
Additional context
No response

we (chicken) thinks it would be better done with a command instead of hardcoding the level, which might seem random to the users.
if you want to check it out, look at the pr #148


Support SDVX 06 (EXCEED GEAR)

Same as #63, but better, I suppose.
A while ago, I've discovered that fork and that branch to be used on my personal instance.  I've condensed them into one single commit with only necessary and minimal changes.
Notes:

bemani/backend/sdvx/exceedgear.py is slightly changed from that branch and reordered here and there to minimize diff between heavenlyhaven.py.
Use of use_information flag is commented out. I think this option is for displaying custom message on entry screen, but I've not tested this. These strings will probably use same format as data/others/gameover.template.xml. If this feature is being implemented correctly, two more strs and longstrs game setting entry might be needed.
use_asphyxia_gameover flag is also commented out, but this thing is unknown, as original code suggests.
Original code has implemented Discord broadcasting support in it, but I've commented it out for now.
I think force_unlock_crew is not working properly?

I appreciate the effort and work! However, bemaniutils strives to be a preservation tool, used for playing older games that are no longer available. We do not wish to compete with Konami on any current game that is out. That doesn't fit the bill of preserving old game experiences and directly competes with Konami's interests which is kinda a big no-no. We can revisit any sort of support once SDVX 6 is end-of-life and no longer making money for them.


refactored config

Description
Refactored all env related configs. The purpose of this PR is to collect all env related initialize sections in the same place to make them easier to manage.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
After making all the changes the relays work as expected.

[ ] Test A
[ ] Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules

@aalimsahin
Thank you for your PR!
Did you confirm if the e2e tests work with this new relayer?

Yes, I completed e2e test with it


Xp 264 put coordinator as own package

References
XP-264
Summary
The coordinator file inside the former grpc module contained different classes. This ticket breaks up that file and prepares the repo basic structure for cleaning up the legacy (local coordinator, benchmarks etc)
Are there any open tasks/blockers for the ticket?
This ticket is the first to be completed for the story XP-249

Reviewer checklist
Reviewer agreement:

Reviewers assign themselves at the start of the review.
Reviewers do not commit or merge the merge request.
Reviewers have to check and mark items in the checklist.

Merge request checklist

[x] Conforms to the merge request title naming XP-XXX <a description in imperative form>.
[x] Each commit conforms to the naming convention XP-XXX <a description in imperative form>.
[x] Linked the ticket in the merge request title or the references section.
[x] Added an informative merge request summary.

Code checklist

[x] Conforms to the branch naming XP-XXX-<a_small_stub>.
[x] Passed scope checks.
[x] Added or updated tests if needed.
[x] Added or updated code documentation if needed.
[x] Conforms to Google docstring style.
[x] Conforms to XAIN structlog style.

thanks @PanicButtonPressed ! good catch, i fixed it as request


Documentation bug fixes

Fixes #900
Fixes #901
Fixes #902

I would have thought this had popped up sooner, but did updating jscs start causing our lint task to fail? It looks like it's parsing one of the system test fixtures.

I would have thought this had popped up sooner, but did updating jscs start causing our lint task to fail? It looks like it's parsing one of the system test fixtures.

Must be some semver fail upstream. Fixed in: https://github.com/GoogleCloudPlatform/gcloud-node/commit/fe2f2e1105562d542a823cc1f0974e1d54fbdd58 Sorry to force a rebase :(

Some of the methods have large-ish code examples, so rather than duplicating every example, I changed the default object to dataset and then add a section that basically says "Or if you're a transaction object" and gave a simple example of the transaction usage.
Does that sound ok for now? I think a better solution would be to use something like JSDocs virtual members and document each method in it's respective file so that we don't have to lump all these examples together (kinda confusing)

I haven't heard of virtual members, but it sounds okay to me. Would we have to re-document the parameters?

I haven't heard of virtual members, but it sounds okay to me.

The documentation for it is kind of scattered, but you essentially can use @memberof and @type to document code that lives in a different file or is global, etc.

Would we have to re-document the parameters?

We would, although it looks like transaction overwrites 2 of the DatastoreRequest methods, so small price to pay imo.


Fully remove next/router for next/navigation

Remove next/router which makes components incompatible with the /app directory.

This is working except logout doesn't actually logout, but it's broken on prod also, possibly introduced by #14 despite b5ff560 :shrug:


How to find the SLACK_BOT_TOKEN of Slack Desktop App for Windows

I have the Slack Desktop client installed on my computer.
I want to be able to use the SDK to send messages.
I read the instructions in your README file but according to the simple example:
import os
from slack_sdk import WebClient
from slack_sdk.errors import SlackApiError

client = WebClient(token=os.environ['SLACK_BOT_TOKEN'])

try:
    response = client.chat_postMessage(channel='#random', text="Hello world!")
    assert response["message"]["text"] == "Hello world!"
except SlackApiError as e:
    # You will get a SlackApiError if "ok" is False
    assert e.response["ok"] is False
    assert e.response["error"]  # str like 'invalid_auth', 'channel_not_found'
    print(f"Got an error: {e.response['error']}")

I need to use SLACK_BOT_TOKEN and I don't have it.  You wrote that I can read about Tokens and Authentication from this Auth Guide but the link is broken:  https://slack.dev/python-slack-sdk/auth.html
I am running on Windows and I am using the Slack Desktop App for Windows and I didn't find the place I can get the token.

@mydockergit Thanks for pointing out the broken link. I just fixed the URL on README. https://slack.dev/python-slack-sdk/installation/
In a nutshell, all you need to do are:

Create a new Slack app from https://api.slack.com/apps?new_app=1
Add necessary permissions like chat:write in the configuration pages
Install the app into your Slack workspace
Use the OAuth access token starting with xoxb-

Let me know if you need further help here. I will be closing this issue after waiting for a while.

Let me know if you need further help here. I will be closing this issue after waiting for a while.

You can find the token in the "OAuth and permissions" page, as mentioned in https://github.com/slackapi/python-slack-sdk/blob/main/tutorial/04-running-the-app.md


added an Example for "generate"

updated with Ali's "generate" example, see
<EMAIL_ADDRESS>

Auto-merge toggled on

Where'd the github branch go?  The auto-tester can't do it's job if it can't checkout the code.  I've disabled this pull from being tested by the auto-tester since it can't handle this case.

see #3575


fix scopeid passing logic #207

Codecov Report

Merging #219 into develop will increase coverage by 0.01%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop     #219      +/-   ##
===========================================
+ Coverage     96.9%   96.92%   +0.01%
===========================================
  Files           50       50
  Lines         1648     1656       +8
===========================================
+ Hits          1597     1605       +8
  Misses          51       51

Impacted Files
Coverage Δ

...atforms/mp/compiler/codegen/compile-to-template.js
98.79% <100%> (ø)
:arrow_up:

src/platforms/mp/runtime/instance/helper.js
98.61% <88.88%> (+0.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b9d739...e60cd8b. Read the comment docs.


Overview view: remove blueprints

Remove tabs, does not need Status tab

Make sidebar fixed so as user scrolls inside the views, the sidebar does not also scroll


Mlj interfacing tweaks

Added proper testing for the clean! method and thanks to that fixed some oversights in the model creation

Codecov Report

Merging #40 (d4de07f) into main (a3b3a7f) will increase coverage by 5.58%.
The diff coverage is 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   91.16%   96.74%   +5.58%
==========================================
  Files          10       10
  Lines         611      614       +3
==========================================
+ Hits          557      594      +37
+ Misses         54       20      -34

Impacted Files
Coverage Δ

src/mlj_flux.jl
95.86% <100.00%> (+28.91%)
:arrow_up:


block comments proof of concept

I wanted to get some feedback on this before I got too far.
I feel like this is a pretty good proof of concept for a block commenting system
It would be something like this.
##
This is a note about this code
##

And for more formal comments related to documentation
##
# This is a formatted note
# Is is a pretty note
##

why not =begin =end?

I like syntax for commenting that is not dependent on words.
I added this to another projects and really loved it.
You can add formatted commenting with a gutter hash which is nice and visibly awesome in code.
Little side benefit you can turn a comment into a block comment easier.
For me this feels like a natural extension of commenting into block commenting.
Also as has been said throughout this project this is not Ruby so I did not see the need to just implement the same feature as ruby.
These are just some of my thoughts.
I would love feedback before finishing though.

Hi @javajax,
This is actually a duplicate of #1401 (with a different syntax, but the reasons for not adding this to the language are the same)

I haven't stumbled upon a ("modern") editor yet where ctrl+3 won't comment/uncomment a selection. Single-line comments are much clearer, especially when some parts are "double commented" in wip-code. Multi-line comments has always been a nightmare in languages supporting them, in my opinion.

I actually think there is more to it then just the editor and I am glad to see another solution like this.  Anyways I thought it was a good idea but I do agree with the general sentiment as well.


Paths to theme images in style sheets must match the location of the images

Hi!
Thanks for the gem update!
Looks like the version has snuck into the image paths in the style sheets again.  I suspect the same issue as issue #5 .
Running
grep -R "jquery-ui/1.11.4/" `bundle show jquery-ui-themes`

lists 384 references from style sheets to this versioned directory.
How are these URLs inserted into the style sheets?

Any update on this?
I'm also getting routing errors having just updated from jquery-ui-themes-0.0.11 to jquery-ui-themes-0.0.12. because the image_path in the CSS files is including the version number:
ActionController::RoutingError (No route matches [GET] "/assets/jquery-ui/1.11.4/overcast/ui-bg_inset-hard_75_999999_1x100.png"):
Going back to 0.0.11 for now.

Can confirm this problem still existing. Just upgraded to 0.0.12 on Rails 5.0 and some asset links were broken, giving these errors:
ActionController::RoutingError (No route matches [GET] "/images/jquery-ui/1.11.4/ui-lightness/ui-icons_ffffff_256x240.png"):
Gem jquery-rails, jquery-ui-rails and jquery-ui-themse are present (in this order) in the Gemfile and application.css.scss has  *= require jquery-ui/ui-lightness
Going back to 0.0.11 fixes this problem for me, but I do not know if there are compatibility issues with the other (newer) versions of jquery gems.


Cargo.toml: remove aya-rustc-llvm-proxy feature

This doesn't make sense as a standalone feature.

Merging without waiting for aya integration tests because this fixes a linking failure.


Unsubscription from previous drawerClosed events

Added explicite unsubscription from previous drawerClosed events before subscribing to the new once.

Thanks for PR 👍


Be more careful when adding delta

Rust has helpful convenience methods for avoiding overflows with arithmetic and avoiding casts; this prevents https://github.com/harfbuzz/rustybuzz/issues/142.

As plausible as it seemed, this isn't quite the right fix: end should never have been usize in the first place. I can submit a PR when the dust settles (although I have some questions about why this fork has a separate codebase that can get out of sync and need this kind of PR instead of being a feature flag on the original port and/or being a PoC branch continuously rebased on it).

Yeah let's keep it close to HB. If overflow happens, that shows a bug in HB code. In this case the fix is indeed to use a signed int.

I have some questions about why this fork has a separate codebase that can get out of sync and need this kind of PR instead of being a feature flag on the original port and/or being a PoC branch continuously rebased on it

I don't think there's a good reason for it, except that the respective owners didn't reach an agreement:
https://github.com/googlefonts/fontations/issues/956


Added more unit tests.

Added test for spin_thread.c
Added test for string_helpers.c

Codecov Report

Merging #54 into master will increase coverage by 1.97%.
The diff coverage is 82.6%.

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   18.17%   20.14%   +1.97%
==========================================
  Files          13       14       +1
  Lines         930      953      +23
  Branches      123      125       +2
==========================================
+ Hits          169      192      +23
+ Misses        741      738       -3
- Partials       20       23       +3

Impacted Files
Coverage Δ

tests/test_spin_thread_s.c
82.6% <82.6%> (ø)

src/spin_thread.c
57.14% <ø> (+57.14%)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53ea6b5...2ee6f0c. Read the comment docs.

The above Codecov Report does not include [tests/test_spin_thread_e.c] which would account for the missing 43.86% coverage.


[$500 bounty] Reduce kernel boot time to <1s on comma 3/3X

systemd-analyze reports this for the latest AGNOS:
Startup finished in 3.650s (kernel) + 7.343s (userspace) = 10.994s
graphical.target reached after 7.059s in userspace

Get the kernel part of that down to <1s in a self-contained way that doesn't delay the rest of the openpilot.

can't just defer stuff to later and cost boot time at later stages
can turn off stuff openpilot doesn't use (NFC, bluetooth, etc.)

AGNOS is built with https://github.com/commaai/agnos-builder

I'm planning to do the following (most of them extracted from the boot-time-slides.pdf from the documentation links):

[ ] Measure and optimize the kernel initialization functions:

[ ] Analyze boot.svg from https://github.com/commaai/agnos-builder/issues/110#issuecomment-1925239170
[ ] Remove unnecessary functionality:
• Find which kernel configuration parameter compiles the code, by looking at the Makefile in the corresponding source directory.
[ ] Postpone:
• Find which module (if any) the function belongs to. Load this module later if possible.
[ ] Optimize necessary functionality:
• Look for parameters which could be used to reduce probe time, looking for the module_param macro.
• Look for delay loops and calls to functions containing delay in their name, which could take more time than needed. You could reduce such delays, and see whether the code still works or not.

[ ] Cut out unused drivers.

[ ] Reduce kernel size:

[ ] Compile everything that is not needed at boot time as a module.
[ ] Find the biggest symbols in the compiled kernel, for those which could be unnecessary, study the corresponding Makefile to see how not to compile them, if possible.

[ ] Check which kernel compression option is the fastest (gzip/lzma/xz/lzo/lz4/zstd or uncompressed - I love zstd but most likely lzo or lz4 is the winner, since pretty unclear if zstd support can easily be added and if the benefit is worth it).

[ ] Deferring drivers and initcalls - If you can’t compile a feature as a module (e.g. networking or block subsystem), you can try to defer its execution.

[ ] Turning off console output (Disable it by passing the quiet argument on the kernel command line).

[ ] Scale the CPU frequency to maximum (or some thermally limited maximum) during boot. The faster the CPU, the faster the boot.

Documentation links:

https://medium.com/smartmechatronics/embedded-linux-boot-time-reduction-eda5f5b4c014
https://bootlin.com/doc/training/boot-time/boot-time-slides.pdf
https://elinux.org/images/6/64/Chris-simmonds-boot-time-elce-2017_0.pdf
https://www.e-consystems.com/articles/Product-Design/Linux-Boot-Time-Optimization-Techniques.asp
https://www.toradex.com/blog/embedded-linux-boot-time-optimization
https://source.android.com/docs/core/architecture/kernel/boot-time-opt

We already use quiet to get the initial speedup of like 11s -> 3s. I suspect we'll get the most savings from disabling and deferring. Anything openpilot doesn't use is fine to disable. Also keep in mind that deferring something critical but it costs time later in bootup doesn't count, but something non-essential to driving like WiFi is fine.


Handle sample tags with "." in App

Resolves #1916
import fiftyone as fo

dataset, session = fo.quickstart()
dataset.tag_samples("hello.world")
session.refresh()

Verified the fix using foo.bar tag. This threw an error on develop.


Read UserProfile after is completely loaded in Local Storage

Hello, is there a way I can know when UserProfile informations are fully loaded in the Local Storage? I know they are loaded by loadUserProfile method.
I made this Guard, where I want to check if the Email is verified, but sometimes it take long time before I receive the email_verified  claim. I do something wrong in this Guard? If I directly access the claims, without waiting for this Observables the claims are null, because they are not loaded yet in the LocalStorage. Thanks!
 canActivate(route: ActivatedRouteSnapshot, state: RouterStateSnapshot): Observable<boolean> {

     let token_claims = JSON.parse(localStorage.getItem('id_token_claims_obj')!);

      if(token_claims.email_verified)
      {
          return this.authService.isAuthenticated$.pipe(
            map((status) => {
              if(status === true) {
                if(this.authService.identityClaims.email_verified)
                  return true;
                else
                {
                  this.router.navigate(['/notverified']);
                  return false;
                }
              }

            this.router.navigate(['/notverified']);
            return false;
          })
        );
      }
      else
      {
        return this.oAuthService.events.pipe(
          filter( (e) => ['user_profile_loaded'].includes(e.type)),
          map( (e) => {
            if(this.authService.identityClaims.email_verified)
              return true;
            else
            {
              this.router.navigate(['/notverified']);
              return false;
            }
          })
        )
      }
  }

Couple of things I notice from your snippet:

There is no isAuthenticated$ in this library perhaps you are using another library or also some custom code or perhaps even a spin-off from my sample repo? Either way we need all the relevant code to be able to help.
You are mixing usage of authService and oAuthService, why's that?
In general with OAuth flows, "is Authenticated" will happen async (hence the observable), and when it's done, loading the UserProfile will be another async call, which might take some time. So being authenticated doesn't mean the claims are there already, you may need to wait for those as well.

But all these are a bit of guessing, as some relevant application code is probably missing from your post?

Hello, thanks for the answer.
Yes, I use some code from your repo too. I analyzed the code from this library and saw when UserProfile is loaded from the loadUserProfile method user_profile_loaded event is triggered that's why I tried to mix up authService from your repository and oAuthService. But user_profile_loaded event is triggered only once, when User log in on the first time in the application.
If let only this code
        return this.oAuthService.events.pipe(
          filter( (e) => ['user_profile_loaded'].includes(e.type)),
          map( (e) => {
            if(this.authService.identityClaims.email_verified)
              return true;
            else
            {
              this.router.navigate(['/notverified']);
              return false;
            }
          })
``` will not work, and I don't know why. Do you have any suggestions to make this Guard works correctly? How should I deal with Local Storage to know when User Profile is fully loaded, if `user_profile_loaded` event is triggered only once and not every time? Thanks

Hmm, not entirely sure. At first sight that event should be it? I recommend looking through the loadUserProfile(...) code and possibly stepping through it in the debugger on your application to see what's going on. Let us know what you find!?

I did some debug. I let only this code in the Guard:

      this.oAuthService.events.subscribe((e) => console.log(e));

      return this.oAuthService.events.pipe(
        filter( (e) => ['user_profile_loaded'].includes(e.type)),
        map( (e) => {
          if(this.authService.identityClaims.email_verified)
            return true;
          else
          {
            this.router.navigate(['/notverified']);
            return false;
          }
        })
      )
  }```

And I get this results:
![image](https://user-images.githubusercontent.com/89996135/157706827-f0b67b3d-a6f3-44d2-88ae-5b32eaa88306.png)
As you can see, User Profile Loaded is triggered just after some time, until then `session_unchanged` event is triggered. While session_unchanged is triggered map will not be triggered. So I changed my code like this:
`  canActivate(route: ActivatedRouteSnapshot, state: RouterStateSnapshot): Observable<boolean> {
      return this.oAuthService.events.pipe(
        filter( (e) => ['user_profile_loaded','session_unchanged'].includes(e.type)),
        map( (e) => {
          if(this.authService.identityClaims.email_verified)
            return true;
          else
          {
            this.router.navigate(['/notverified']);
            return false;
          }
        })
      )
  } `

I hope will work in all situations now.


Implement new audio mixer concurrency limits

I debated for quite a long time whether to keep playback concurrency as part of Sample or not. Here's a few observations I made:

One problem is that Samples are inherently distinct objects - they don't know about each other and especially don't know about each others' channels, so they would have to be linked with the AudioMixer in some way anyway because that's the only component which knows about everything.
When considering the case of global (shared between all Samples with the same data backing) vs per-Sample concurrency limitations, I didn't feel like keeping playback concurrency as part of Sample to be the most extensible and intuitive way to go about this if it would ever be required.
After looking at how we're currently doing concurrency, I noticed that we have to explicitly set SampleStore.PlaybackConcurrency when creating a custom SampleStore (e.g. the DrawableRuleset SampleStore). This feels very flaky to me, easy for a consumer to miss, and quite hard to document.

With all of that in mind, I came to the conclusion that concurrency should be part of AudioMixer. It works on audio channels, which means that there's no distinction between a track or a sample - the user should be able to use this without caring about there being special cases.
By default, I've set unlimited concurrency to both the global track mixer and sample mixer.

Playback concurrency
By default, all AudioMixers play as many channels as given to them concurrently. For cases where this may be undesirable, such as when playing back samples on user interactions, the AudioMixer.Concurrency property can be used to limit the number of concurrent playback channels.
[BackgroundDependencyLoader]
private void load(ISampleStore samples, AudioManager audioManager)
{
    // Limit all global samples to two concurrent playbacks.
    audioManager.SampleMixer.Concurrency = 2;

    Sample globalSample = samples.Get(...);

    // The sample attached to the global audio mixer can only be played back two times.
    globalSample.Play(); // 1
    globalSample.Play();
    globalSample.Play(); // Upon calling this, playback #1 above will be stopped.

    DrawableAudioMixer localAudioMixer;
    DrawableSample localSample;

    // A local audio mixer allowing six concurrent playbacks.
    Add(localAudioMixer = new DrawableAudioMixer
    {
        Concurrency = 6,
        Child = localSample = new DrawableSample(samples.Get(...)),
        Effects =
        {
            ...
        }
    });

    // A sample within the local mixer can only be played back six times.
    localSample.Play(); // 1
    localSample.Play();
    localSample.Play();
    localSample.Play();
    localSample.Play();
    localSample.Play();
    localSample.Play(); // Upon calling this, playback #1 above will be stopped.
}

Note that with these changes, concurrency is shared between all samples in the mixer. To achieve the effect of the previous "global" concurrency (via the same data backing) you'd have to add samples to a separate audio mixer.
So currently the osu! limit of 6 may be too low but in my testing (https://osu.ppy.sh/beatmapsets/39804#osu/129891 + https://osu.ppy.sh/beatmapsets/177187#osu/426550) I didn't notice any abrupt cutting out.

So just to confirm, there's no way to limit concurrency per sample now? Limiting at a mixer may be something we want for general safety purposes, but the goal here was to allow us to use the concurrency specification in place of manual debounce logic, no? Does that mean that you envisage a mixer being created for hover sounds, for instance, if we want to limit concurrency there?
Also with a global limit of 6, wouldn't a long slider sound cut out if only 5 ticks played since it started? Or am I missing something?

On reading, the source looked sane but I'm partially in agreement with the preceding comment that I'm not sure that this solves the problems that the game has. I guess you could split a mixer for UI sounds, or other sounds, but that raises some questions for me - how many mixers will we end up having? how well will they scale? etc. etc.
One thing is for sure, the assumption of limiting at mixer level simplifies implementation by quite a lot. Doing per-sample tracking would add complexity to that (probably would have to keep a dictionary of concurrency settings or something).

Yeah I agree, kinda forgot about that aspect of it... Will close this PR for the time being then.


Sidekick Bookmarklet RC

This PR has been auto-generated from https://github.com/adobe/helix-sidekick-extension/.

https://sidekick-rc-661d6fb--helix-website--adobe.hlx.page/tools/sidekick/

Changes in this release:

https://github.com/adobe/helix-sidekick-extension/pull/230


Terminus backups failing ....

With regards to this site: d152e5b4-a2f7-445b-8866-be2cd81d44f9
I am connected, and attempting to run backups via terminus. This is what I am trying:
terminus site backups create --site=SITENAME --env=live --element=all
Getting this error:
.....................................................................................Error: Exception thrown - [curl] 35: Server aborted the SSL handshake [url] https://dashboard.getpantheon.com/api/sites/d152e5b4-a2f7-445b-8866-be2cd81d44f9/workflows/9e035b62-5870-11e5-94f7-bc764e10b0ce
However Dashboard UI still shows as though the Files component is still backing up.
Originally, I tried to just back up:
terminus site backups create --site=SITENAME --env=live --element=code,db
and oddly enough, the DB and Files components backed up.
Then if I run as:
terminus site backups create --site=SITENAME --env=live
and it asks me which element I would like to back up, choosing 1 actually backs up the DB, not the code.
Choosing 2 seems to back up everything, as does 3, and the same happens choosing 4 as an option.
There are really two separate issues happening here. One is the SSL Handshake Abort, and the other is that the terminus site backups --element params don't seem to be working. In an ideal world, I would be able to backup just code, and DB for this particular project and do it via Terminus. There definitely isn't a way via Dashboard UI that I know of to do this.
Please keep me posted, thank you.
-adam

I can confirm that this is an issue in version 0.8.0.
The following command: terminus site backups create --element=database --site=<site> --env=<env>
Produces this message:
Fatal error: Call to a member function createBackup() on a non-object in phar:///usr/local/bin/terminus/php/commands/site.php on line 575

I am running PHP 5.4.32 under Mac OSX 10.10.5.

@bobbygryzynger The error you were seeing has been fixed as of #494, due soon to be added to the 1.0.0 release.

@nimzie While I was unable to duplicate the server timeout error you were receiving, I believe it was related to the fact that this command was not properly formatting your requested element, and so sending improper requests which were still legal by the API's standards. I have fixed the selection in PR #532.


Anybody noticing dogpush not working as of yesterday?

I think datadog changed their APi and now pushing does nothing as it says that the monitors that were updated in the previous run are still out of date on datadog.

If I'm seeing it right, it seems datadog does not give us back same definition of monitors as we've given to them. Due to that, each time dogpush is ran, it tries to update all monitors.

So, i was able to add to the ignore items the (forgive me cause im going from memory at home) overall_modification_date? i think is the key, and upon a diff you do not get an issue with all monitors being out of date, however, it seems the push is still failing to send new data... I wonder if they keep their json files on S3 and are having problems with object writes/edits due to the failure yesterday... just a theory.

I'm experiencing this issue as well. Datadog added a field called "overall_state_modified" on Tuesday which coincided with the breaking of the push feature. We were told if we remove that field from our yaml files it would push, but after doing so, its still is not working.
Anybody have any ideas?

This PR is fixing it for me: https://github.com/trueaccord/DogPush/pull/11


15000 pods created that I'm having to manually cleanup

Well flame timed out trying to profile and now I have 15000 pods Terminating

Sorry to hear that @charlesritchea
Can you provide some more info such as logs so I would be able to investigate this issue?
Thanks

Sorry to hear that @charlesritchea
Can you provide some more info such as logs so I would be able to investigate this issue?
Thanks


Use bundle resources instead of #file

Use a resources bundle for default pattern and exception files, instead of lookup using #file.
SE-0271: Package Manager Resources is expected to be part of the Swift 5.3 release.

With the Swift 5.3 release now out is there any plan on updating this soon by chance? It works well for us in simulators but crashes on use with the default english patterns.

I haven't had much time for OSS this past year, but I've been meaning to come back to this recently, so I'll take another look at it.

@john-mueller Awesome, thank you! 🥳


Unit system

Added a coherent unit & dimensional analysis, and switched basically all existing code to use it internally.
Summary
Adds a unit system with 4 SI base dimensions. The system automatically converts between different units and performs all the dimensional analysis for unit multiplication and division, at compile time. Every instance where a unit type would implicitly be used now uses an actual unit type. Users can define a unit quantity using  the _unit suffix (eg. (90_deg).
Motivation
The use of a units system helps avoid confusion from users about what unit types are used for functions, incorrect assumptions about which units are used (potentially messing up math), and the need for additional conversion functions and unit specification arguments (many functions had a bool radians argument or similar before). Additionally, this has been a long-planned addition that I know Lem already endorses.
Test Plan
Compiles without warnings, but a lot of conversion to units were probably done incorrectly. Will run both unit tests and full hardware tests in the future, but no time atm. Also, this PR is being made to the refactor branch, which is unstable anyways.
Additional Notes
The units implementation is based on Ben Jurke's work. A large part current version of the units.hpp file was written by Sufferiing. Also, the isQuantity concept was inspired by Ryan Liao so thank to him.

Download the template for this pull request:

[!NOTE]
This is auto generated from Add Template to Pull Request

via manual download<EMAIL_ADDRESS>via PROS Integrated Terminal:

curl -o<EMAIL_ADDRESS>https://nightly.link/LemLib/LemLib/actions/artifacts/1058696870.zip;
pros c fetch<EMAIL_ADDRESS>pros c apply<EMAIL_ADDRESS>rm<EMAIL_ADDRESS>

Didnt finish the review, the rest of the files is basically the same thing. Update the doxygen comments

All requested changes have been made, ready for another round of review


Should a good idea split this project?

Hi. I used this plugin in a couple of projects and help me to save lot of time. Thanks.
Very often in my the projects (with exception of ´required´) the build-in rules are not required, and i must add a lot of custom rules.
So, I think that should be a good idea split this project in 2. one with the implementation of the form validation core. And other repo/lib/etc (whatever) with plugins required to the project.
If is this is planed for the  next versions, ignore this issue.
Thanks.

+1 - especially if you only use 1 or 2 methods and dont need the other built-in methods

This isn't planned. I'm happy to review and merge pull requests to move methods from core.js to additionals, for example creditcard really shouldn't be in core.


Init Lerna Monorepo - Merge repos

(Draft) Merge Services into a single code base repository
Merge micro-splitted services (repositories) into this single repository.
For..

Ease of management, contribution
Ease of managing single oriented documentations
To reduce redundant codes between UI required applications

Repos to be merged into this repository

Design To Code Engine - https://github.com/gridaco/designto-code
Part of https://github.com/gridaco/grida.co (docs) or All of https://github.com/gridaco/grida.co
Nothing Graphics Engine - https://github.com/gridaco/nothing
Boring Text Engine - https://github.com/gridaco/boring
Design server project - https://github.com/gridaco/design-server
Design git project - https://github.com/gridaco/design-git

Indeterminate

BASE - https://github.com/gridaco/base
CoLI - https://github.com/gridaco/CoLI

Projects (Repositories) that will be affected

https://github.com/gridaco/assistant

Pre-requirements

Setup this repo's submodules to the latest version
Making things work all together

Todo

[ ] Custom build script to silence vercel deployment for micro websites
[ ] Additional Contributing.md to guide developers through working in a single-repository environment.
[ ] Sub projects license management
[ ] TBD..

References

Lerna.js
Merging git repositories (preserve commit logs)

https://github.com/gridaco/grida/pull/62


[Fix-5477][api] when start a process manually, its local parameter  which references ${system.datetime} does not get runtime value

Purpose of the pull request
closes #5477
Brief change log
Verify this pull request
This change added tests and can be verified as follows:

Added testViewVariablesNotSchedule() in org.apache.dolphinscheduler.api.service.ProcessInstanceServiceTest.
Manually verified the change by testing locally.

Codecov Report

Merging #5554 (513c20f) into dev (842c540) will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##                dev    #5554      +/-   ##
============================================
+ Coverage     46.75%   46.78%   +0.03%
+ Complexity     3787     3786       -1
============================================
  Files           605      605
  Lines         24791    24792       +1
  Branches       2811     2812       +1
============================================
+ Hits          11590    11598       +8
+ Misses        12094    12083      -11
- Partials       1107     1111       +4

Impacted Files
Coverage Δ

...r/api/service/impl/ProcessInstanceServiceImpl.java
76.92% <66.66%> (+4.08%)
:arrow_up:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...inscheduler/service/zk/CuratorZookeeperClient.java
70.73% <0.00%> (-4.88%)
:arrow_down:

...r/server/worker/processor/TaskCallbackService.java
38.09% <0.00%> (-3.18%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.35% <0.00%> (-1.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 842c540...513c20f. Read the comment docs.


Support Django 5.0

Description
Test against Django 5.0 and declare support.
Checklist:

[x] I have added the relevant tests for this change.
[x] I have added an item to the Pending section of docs/changes.rst.

You're ahead of the testathon!

Thanks Adam!

My life is a testathon.

Ha! When we pitched the idea of a testathon, I suggested we market it as Adam vs The Community, in the vein of John Henry vs The Machine.

haha no way 😂


Camp Harmony: I f**ked up Shira's payment!

Shira paid $834 via paypal for her and Jim.  I messed up big time trying to add an additional $174 to what is owed because Jim is staying in RV 2 nights and semi-private 2 nights.
Can you delete the three entries for additional charges on Shira's payment page so I can start over.

talked to Will; just look at balance due.


php83Packages.phpstan: fix hash

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356691

x86_64-linux

:white_check_mark: 4 packages built:

php81Packages.phpstan
php82Packages.phpstan
php83Packages.phpstan
php84Packages.phpstan

aarch64-linux

:white_check_mark: 4 packages built:

php81Packages.phpstan
php82Packages.phpstan
php83Packages.phpstan
php84Packages.phpstan

x86_64-darwin

:white_check_mark: 4 packages built:

php81Packages.phpstan
php82Packages.phpstan
php83Packages.phpstan
php84Packages.phpstan

aarch64-darwin

:white_check_mark: 4 packages built:

php81Packages.phpstan
php82Packages.phpstan
php83Packages.phpstan
php84Packages.phpstan


Blog app - setup and controllers

Hello 👋 , Reviewers!
In this PR, I have implemented required tasks listed below :
TASKS DESCRIPTION

In this project, you will create all controllers and views for your Blog app. As you won't be processing any data yet, you will add simple placeholders for your views with plain HTML.

PROJECT REQUIREMENTS

Create a new app. Give it a meaningful name.
Initialize your project with Git.

Important: do NOT use rails generate scaffold command. The point of this project is to show you how to set up controllers by yourself.

Make sure that your project has Postgres database set up.
Take a look at the wireframes below. Make sure that your app handles the URLs used in the wireframes:
For each URL you should create:

A route.
An action in the correct controller.
A view file.

View files should include only placeholders written in plain HTML, e.g:

Note: I have made sure to add code to handle only the 4 required URLs.

STATUS: INVALID  ❌

Hello @Paskab012  ✋🏼
You have submitted a project, that has node_modules. Because of many files ı can't give a review. Kindly add the node_modules file in the gitignore.

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding! 💻 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
GitHub | LinkedIn | Twitter
Reviewed by Ahmet Bozacı


cilium: nodeId, add debug statements and warning

Trying to find root cause of why we have some old nodeIds lingering around with single IPs. Add some info to give us the IPs we are removing and then a Warn when we would previously have aborted adding an ID because the IP already exists.
Please ensure your pull request adheres to the following guidelines:

[ ] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[ ] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[ ] If your commit description contains a Fixes: <commit-id> tag, then
please add the commit author[s] as reviewer[s] to this issue.
[ ] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[ ] Are you a user of Cilium? Please add yourself to the Users doc
[ ] Thanks for contributing!

Fixes: #issue-number
<!-- Enter the release note text here if needed or remove this section! -->

superceded


Parsing data to stdin on exec function doesn't seem to work

The notes at https://github.com/roboll/helmfile/blob/master/README.md#L903 say that you can parse input to the exec function and it will get passed to the stdin of the command running in the exec function. However I can't seem to get this to work at all, the result always seems to come back as "null".
Example as follows
a.sh is a shell script that simply echos what is parsed to stdin
$ cat a.sh
#!/bin/bash
read var
echo $var

$ echo 'asdf' | ./a.sh
asdf

I use it in the following helmfile
$ cat helmfile.yaml
---
repositories:
# Kubernetes incubator repo of helm charts
- name: "kubernetes-incubator"
  url: "https://kubernetes-charts-incubator.storage.googleapis.com"

releases:
- name:  test
  chart: "kubernetes-incubator/raw"
  namespace: default
  version: "0.2.3"
  installed: true
  values:
    - resources:
      - apiVersion: v1
        kind: Secret
        metadata:
          name: test
        stringData:
          test: {{ "asdf" | (exec "./a.sh" (list "")) }}

And it produces the following
$ helmfile template
Adding repo kubernetes-incubator https://kubernetes-charts-incubator.storage.googleapis.com
"kubernetes-incubator" has been added to your repositories

Updating repo
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "kubernetes-incubator" chart repository
...Successfully got an update from the "cloudposse-incubator" chart repository
...Successfully got an update from the "gitlab" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete.

Fetching kubernetes-incubator/raw
Templating release=test, chart=/tmp/122827334/test/0.2.3/kubernetes-incubator/raw/raw
---
# Source: raw/templates/resources.yaml

---
apiVersion: v1
kind: Secret
metadata:
  labels:
    app: raw
    chart: raw-0.2.3
    heritage: Tiller
    release: test
  name: test
stringData:
  test: null

I would expect the test value under stringData to be "asdf"

Doing some debugging and testing I think I have successfully narrowed down some interaction with closing the writeErrs chan and when it's closed. If I comment out this line https://github.com/roboll/helmfile/blob/master/pkg/tmpl/context_funcs.go#L72 then everything works as expected.

I'm no expert but I think what might be happening is nil is being read from writeErrs channel, trigiring the select statement to return it instead of bytes. If I change the code at line 105 to
	for {
		select {
		case bytes := <-cmdOuts:
			return string(bytes), nil
		case err, isErr := <-cmdErrs:
			if isErr {
			  return "", err
			}
		case err, isErr := <-writeErrs:
			if isErr {
			  return "", err
			}
		}
	}

It seems to work as expected

@ggillies Thanks for reporting! You're absolutely correct - this is a bug.
Fortunately, as I'm seemingly a better Go programmer than me who wrote this a year ago, I've managed to fix it in #1151.
Would you mind giving it a shot once the new Helmfille release with the fix is published?

v0.102.1 has been released with the fix

@mumoshu thanks so much for looking at this! Just tested and v0.102.1 has fixed this for me!