New PR to test SignCLA at 2020-03-26 12:03:40.491893871 -0700 PDT m=+3.405112023

Body of PR

indiv-pass-staging: test succeeded


PP.Geteffect can return null

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/15433/merge
Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15433/merge/index.html
To test a playground add it to the URL, for example:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15433/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/15433/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15433/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15433/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15433/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/15433/merge#BCU1XR#0

WebGL2 visualization test reporter:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15433/merge/testResults/webgl2playwright/index.html

Visualization tests for WebGPU (Experimental)
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15433/merge/testResults/webgpuplaywright/index.html


Charity Impact Map

Description
Milan can create an interactive "Charity Impact Map" that visually displays the geographical reach and impact of different charities, NGOs, and projects. This map can provide users with a comprehensive overview of the charitable activities happening around the world and allow them to explore and support causes that resonate with them.
Kindly allow me to work on this issue under gssoc'23
Screenshots
No response
🥦 Browser
Google Chrome
Checklist ✅

[X] I checked and didn't find similar issue
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (blank for no)

Hi @Suchitra-Sahoo , i really don't understand the issue, please can you explain me in details ?

Notice 🚩
Hi there, unfortunately, I will have to close this Issue/PR, as this issue/PR has been inactive for quite a while and there's no work going on for the same.
There might be more Issues/PR which are waiting for this to be completed - so it is better to pace things up. I generally spend/wait for 3 weeks before marking any issue as stale and closing it.
If you think that this is a mistake, please drop a mail at<EMAIL_ADDRESS>and we will get back to you.
Regards,
Team Milan.


v4l_encoder: enable hevc vui header timing info flag

This pr seems to set the currect packet duration for our hevc timebase, so anything reading/playing the f/d/e cameras knows correct fps
Finding hevc metadata timing info
ffmpeg hevc metadata
Was seeing what hevc metadata ffmpeg could manipulate
https://ffmpeg.org/ffmpeg-bitstream-filters.html#hevc_005fmetadata
and saw
tick_rate
Set the tick rate in the VPS and VUI parameters (time_scale / num_units_in_tick). Combined with num_ticks_poc_diff_one, this can set a constant framerate in the stream. Note that it is likely to be overridden by container parameters when the stream is in a container.

num_ticks_poc_diff_one
Set poc_proportional_to_timing_flag in VPS and VUI and use this value to set num_ticks_poc_diff_one_minus1 (see H.265 sections <IP_ADDRESS> and E.3.1). Ignored if tick_rate is not also set.

ffmpeg trace_headers
can see header information with ffmpeg for openpilog hevcs
ntegan@ideapad ~/comma/commaapitool (git)-[master] % ffmpeg -hide_banner -i fcamera.hevc -c copy -bsf:v trace_headers -f null -  2>&1 | grep vps_timing -C4
[trace_headers @ 0x55abb865d7c0] 148         vps_max_num_reorder_pics[0]                                 1 = 0
[trace_headers @ 0x55abb865d7c0] 149         vps_max_latency_increase_plus1[0]                           1 = 0
[trace_headers @ 0x55abb865d7c0] 150         vps_max_layer_id                                       000000 = 0
[trace_headers @ 0x55abb865d7c0] 156         vps_num_layer_sets_minus1                                   1 = 0
[trace_headers @ 0x55abb865d7c0] 157         vps_timing_info_present_flag                                0 = 0
[trace_headers @ 0x55abb865d7c0] 158         vps_extension_flag                                          0 = 0
[trace_headers @ 0x55abb865d7c0] 159         rbsp_stop_one_bit                                           1 = 1
[trace_headers @ 0x55abb865d7c0] Sequence Parameter Set
[trace_headers @ 0x55abb865d7c0] 0           forbidden_zero_bit                                          0 = 0
--
[trace_headers @ 0x55abb865d7c0] 148         vps_max_num_reorder_pics[0]                                 1 = 0
[trace_headers @ 0x55abb865d7c0] 149         vps_max_latency_increase_plus1[0]                           1 = 0
[trace_headers @ 0x55abb865d7c0] 150         vps_max_layer_id                                       000000 = 0
[trace_headers @ 0x55abb865d7c0] 156         vps_num_layer_sets_minus1                                   1 = 0
[trace_headers @ 0x55abb865d7c0] 157         vps_timing_info_present_flag                                0 = 0
[trace_headers @ 0x55abb865d7c0] 158         vps_extension_flag                                          0 = 0
[trace_headers @ 0x55abb865d7c0] 159         rbsp_stop_one_bit                                           1 = 1
[trace_headers @ 0x55abb865d7c0] Sequence Parameter Set
[trace_headers @ 0x55abb865d7c0] 0           forbidden_zero_bit                                          0 = 0

ffmpeg set timing info metadata
ffmpeg -i fcamera.hevc -c copy -bsf:v hevc_metadata=tick_rate=20:num_ticks_poc_diff_one=1 output.hevc

ntegan@ideapad ~/comma/commaapitool (git)-[master] % ffmpeg -hide_banner -i output.hevc -c copy -bsf:v trace_headers -f null -  2>&1 | grep vps_timing -C4
[trace_headers @ 0x55e071b16880] 148         vps_max_num_reorder_pics[0]                                 1 = 0
[trace_headers @ 0x55e071b16880] 149         vps_max_latency_increase_plus1[0]                           1 = 0
[trace_headers @ 0x55e071b16880] 150         vps_max_layer_id                                       000000 = 0
[trace_headers @ 0x55e071b16880] 156         vps_num_layer_sets_minus1                                   1 = 0
[trace_headers @ 0x55e071b16880] 157         vps_timing_info_present_flag                                1 = 1
[trace_headers @ 0x55e071b16880] 158         vps_num_units_in_tick<PHONE_NUMBER>0000000000000000000001 = 1
[trace_headers @ 0x55e071b16880] 190         vps_time_scale<PHONE_NUMBER>0000000000000000010100 = 20
[trace_headers @ 0x55e071b16880] 222         vps_poc_proportional_to_timing_flag                         1 = 1
[trace_headers @ 0x55e071b16880] 223         vps_num_ticks_poc_diff_one_minus1                           1 = 0
--
[trace_headers @ 0x55e071b16880] 148         vps_max_num_reorder_pics[0]                                 1 = 0
[trace_headers @ 0x55e071b16880] 149         vps_max_latency_increase_plus1[0]                           1 = 0
[trace_headers @ 0x55e071b16880] 150         vps_max_layer_id                                       000000 = 0
[trace_headers @ 0x55e071b16880] 156         vps_num_layer_sets_minus1                                   1 = 0
[trace_headers @ 0x55e071b16880] 157         vps_timing_info_present_flag                                1 = 1
[trace_headers @ 0x55e071b16880] 158         vps_num_units_in_tick<PHONE_NUMBER>0000000000000000000001 = 1
[trace_headers @ 0x55e071b16880] 190         vps_time_scale<PHONE_NUMBER>0000000000000000010100 = 20
[trace_headers @ 0x55e071b16880] 222         vps_poc_proportional_to_timing_flag                         1 = 1
[trace_headers @ 0x55e071b16880] 223         vps_num_ticks_poc_diff_one_minus1                           1 = 0

ntegan@ideapad ~/comma/commaapitool (git)-[master] % ffprobe -hide_banner fcamera.hevc
[hevc @ 0x56534e9d7e00] Stream #0: not enough frames to estimate rate; consider increasing probesize
Input #0, hevc, from 'fcamera.hevc':
  Duration: N/A, bitrate: N/A
  Stream #0:0: Video: hevc (Main), yuv420p(tv), 1928x1208, 25 fps, 25 tbr, 1200k tbn

ntegan@ideapad ~/comma/commaapitool (git)-[master] % ffprobe -hide_banner output.hevc
[hevc @ 0x556ba51dfe00] Stream #0: not enough frames to estimate rate; consider increasing probesize
Input #0, hevc, from 'output.hevc':
  Duration: N/A, bitrate: N/A
  Stream #0:0: Video: hevc (Main), yuv420p(tv), 1928x1208, 20 fps, 20 tbr, 1200k tbn

on device enabling timing info
Enabling the v4l2 control flag from this pr
works (ffprobe fps) but i just realized it's not using the same vps_timing_info thing hmm
comma@tici:/data/media/0/realdata/2023-01-30--12-12-58--0$ ffprobe fcamera.hevc
[hevc @ 0x557ada3ca0] Stream #0: not enough frames to estimate rate; consider increasing probesize
Input #0, hevc, from 'fcamera.hevc':
  Duration: N/A, bitrate: N/A
    Stream #0:0: Video: hevc (Main), yuv420p(tv), 1928x1208, 20 fps, 20 tbr, 1200k tbn, 20 tbc
comma@tici:/data/media/0/realdata/2023-01-30--12-12-58--0$ ffmpeg -hide_banner -i fcamera.hevc -c copy -bsf:v trace_headers -f null -  2>&1 | grep vps_timing -C4
[AVBSFContext @ 0x558d7b9560] 148         vps_max_num_reorder_pics[0]                                 1 = 0
[AVBSFContext @ 0x558d7b9560] 149         vps_max_latency_increase_plus1[0]                           1 = 0
[AVBSFContext @ 0x558d7b9560] 150         vps_max_layer_id                                       000000 = 0
[AVBSFContext @ 0x558d7b9560] 156         vps_num_layer_sets_minus1                                   1 = 0
[AVBSFContext @ 0x558d7b9560] 157         vps_timing_info_present_flag                                0 = 0
[AVBSFContext @ 0x558d7b9560] 158         vps_extension_flag                                          0 = 0
[AVBSFContext @ 0x558d7b9560] 159         rbsp_stop_one_bit                                           1 = 1
[AVBSFContext @ 0x558d7b9560] Sequence Parameter Set
[AVBSFContext @ 0x558d7b9560] 0           forbidden_zero_bit                                          0 = 0
--
[AVBSFContext @ 0x558d7b9560] 148         vps_max_num_reorder_pics[0]                                 1 = 0
[AVBSFContext @ 0x558d7b9560] 149         vps_max_latency_increase_plus1[0]                           1 = 0
[AVBSFContext @ 0x558d7b9560] 150         vps_max_layer_id                                       000000 = 0
[AVBSFContext @ 0x558d7b9560] 156         vps_num_layer_sets_minus1                                   1 = 0
[AVBSFContext @ 0x558d7b9560] 157         vps_timing_info_present_flag                                0 = 0
[AVBSFContext @ 0x558d7b9560] 158         vps_extension_flag                                          0 = 0
[AVBSFContext @ 0x558d7b9560] 159         rbsp_stop_one_bit                                           1 = 1
[AVBSFContext @ 0x558d7b9560] Sequence Parameter Set
[AVBSFContext @ 0x558d7b9560] 0           forbidden_zero_bit                                          0 = 0

Oh it sets packet duration
comma@tici:/data/media/0/realdata$ for f in */fcamera.hevc; do ffprobe -show_entries packet=dts,pts,duration $f -hide_banner | head; done
[hevc @ 0x559f30bee0] Stream #0: not enough frames to estimate rate; consider increasing probesize
Input #0, hevc, from '2023-01-30--12-07-49--0/fcamera.hevc':
  Duration: N/A, bitrate: N/A
    Stream #0:0: Video: hevc (Main), yuv420p(tv), 1928x1208, 25 fps, 25 tbr, 1200k tbn, 25 tbc
[PACKET]
pts=N/A
dts=N/A
duration=48000
[/PACKET]
[PACKET]
pts=N/A
dts=N/A
duration=48000
[/PACKET]
[hevc @ 0x5595969ee0] Stream #0: not enough frames to estimate rate; consider increasing probesize
Input #0, hevc, from '2023-01-30--12-12-58--0/fcamera.hevc':
  Duration: N/A, bitrate: N/A
    Stream #0:0: Video: hevc (Main), yuv420p(tv), 1928x1208, 20 fps, 20 tbr, 1200k tbn, 20 tbc
[PACKET]
pts=N/A
dts=N/A
duration=60000
[/PACKET]
[PACKET]
pts=N/A
dts=N/A
duration=60000
[/PACKET]

for f in */fcamera.hevc; do ffprobe -hide_banner -loglevel fatal  -show_streams  -print_format json $f ;  done

# old hevc
    "streams": [
        {
            "index": 0,
            "codec_name": "hevc",
            "codec_long_name": "H.265 / HEVC (High Efficiency Video Coding)",
            "profile": "Main",
            "codec_type": "video",
            "codec_time_base": "1/25",
            "codec_tag_string": "[0][0][0][0]",
            "codec_tag": "0x0000",
            "width": 1928,
            "height": 1208,
            "coded_width": 1952,
            "coded_height": 1216,
            "has_b_frames": 0,
            "pix_fmt": "yuv420p",
            "level": 150,
            "color_range": "tv",
            "refs": 1,
            "r_frame_rate": "25/1",
            "avg_frame_rate": "25/1",
            "time_base": "1/1200000",
            "disposition": {
                "default": 0,
                "dub": 0,
                "original": 0,
                "comment": 0,
                "lyrics": 0,
                "karaoke": 0,
                "forced": 0,
                "hearing_impaired": 0,
                "visual_impaired": 0,
                "clean_effects": 0,
                "attached_pic": 0,
                "timed_thumbnails": 0
            }
        }
    ]

# new hevc
    "streams": [
        {
            "index": 0,
            "codec_name": "hevc",
            "codec_long_name": "H.265 / HEVC (High Efficiency Video Coding)",
            "profile": "Main",
            "codec_type": "video",
            "codec_time_base": "50000001/1000000000",
            "codec_tag_string": "[0][0][0][0]",
            "codec_tag": "0x0000",
            "width": 1928,
            "height": 1208,
            "coded_width": 1952,
            "coded_height": 1216,
            "has_b_frames": 0,
            "pix_fmt": "yuv420p",
            "level": 150,
            "color_range": "tv",
            "refs": 1,
            "r_frame_rate": "1000000000/50000001",
            "avg_frame_rate": "20/1",
            "time_base": "1/1200000",
            "disposition": {
                "default": 0,
                "dub": 0,
                "original": 0,
                "comment": 0,
                "lyrics": 0,
                "karaoke": 0,
                "forced": 0,
                "hearing_impaired": 0,
                "visual_impaired": 0,
                "clean_effects": 0,
                "attached_pic": 0,
                "timed_thumbnails": 0
            }
        }
    ]

@jyoung8607 pondered in #general-discussion if the lack of this header made it possible to just cat the HEVC files together. Is this still possible with the .hevc files from this change?

@jyoung8607 pondered in #general-discussion if the lack of this header made it possible to just cat the HEVC files together. Is this still possible with the .hevc files from this change?

As far as I know this PR doesn't add any new headers, and I believe it shouldn't.
It instructs the qualcomm video4linux encoder to save timing information in each packet (frame?) of the hevc bitstream. The encoder already knows the timing information, this just tells it to save the information (correct frame duration) in each packet.
The resulting *camera.hevc files are still of the raw .h265 bitstream format which can (still) be concattenated into one big bitstream, which might then be muxed into an mp4/mkv container (without re-encoding) that video players might more easily recognize. Muxing into an mp4 container was also the only way I was able to get the cameras to play directly in an html video element when streaming from the on-device video server.
This information could be verified with the hevc/h265 explorer tool https://github.com/virinext/hevcesbrowser mentioned in https://www.codeproject.com/Tips/896030/The-Structure-of-HEVC-Video

While experimenting with setting timing info in the .hevc h265 bitstream itself via ffmpeg, instead of storing timing info by muxing into an mp4 container, I was still modifying the bitstream itself instead of adding new headers.
ffmpeg -i fcamera.hevc -c copy -bsf:v hevc_metadata=tick_rate=20:num_ticks_poc_diff_one=1 output.hevc.
This doesn't re-encode as it modifies information in the h265 file format thing.
 A gentlemen of desired


Using outdated CSS Syntax for linear-gradient

While doing yarn run watch on a laravel project with this repo in use I get the following warning:
WARNING in ./node_modules/css-loader??ref--5-2!./node_modules/postcss-loader/lib??postcss!./node_modules/resolve-url-loader??ref--5-4!./node_modules/sass-loader/lib/loader.js??ref--5-5!./resources/sass/app.scss
(Emitted value instead of an instance of Error) autoprefixer: D:\work\hostings_other\laravel\postulate.admin.ch\resources\sass\node_modules\swiss-styleguide\src\assets\sass\chosen-theme.scss:261:3: Gradient has outdated direction syntax. New syntax is like `to left` instead of `right`.
 @ ./resources/sass/app.scss 4:14-254
 @ multi ./resources/js/app.js ./resources/sass/app.scss

Under the section "Contribution" you have the following sentence:

(...) Then, please make a Pull Request to the dev branch. (...)

Should I really do my pull request to a branch, that is 656 commits behind the master branch?

Readme and dependencies will be updated with the Material Design Migration
Issue will be closed


React 18 conflict dependencies

I can't run npm install anymore once I installed react-ogl in a clean Next project due to conflicting dependencies between React 18 and React ^17. What am I missing?
NPM version: 8.18.0
Node version: 16.15.0
The log:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR!   peer<EMAIL_ADDRESS>|| ^18.0.0-0" from<EMAIL_ADDRESS>npm ERR!   node_modules/next
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/react-dom
npm ERR!     peer<EMAIL_ADDRESS>|| ^18.0.0-0" from<EMAIL_ADDRESS>npm ERR!     node_modules/next
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/react-ogl
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     2 more (react-use-measure, the root project)
npm ERR!   8 more (react-ogl, react-use-measure, styled-jsx, suspend-react, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/react-native
npm ERR!   peer<EMAIL_ADDRESS>|| 0.0.0-*" from<EMAIL_ADDRESS>npm ERR!   node_modules/react-native/node_modules/@react-native-community/cli
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/react-ogl
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   1 more (@expo/browser-polyfill)
npm ERR!
npm ERR! Conflicting peer dependency<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/react-native
npm ERR!     peer<EMAIL_ADDRESS>|| 0.0.0-*" from<EMAIL_ADDRESS>npm ERR!     node_modules/react-native/node_modules/@react-native-community/cli
npm ERR<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     peerOptional<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/react-ogl
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     1 more (@expo/browser-polyfill)
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/arno/.npm/eresolve-report.txt for a full report.

package.json
{
  "name": "my-app",
  "version": "0.1.0",
  "private": true,
  "scripts": {
    "dev": "next dev",
    "build": "next build",
    "start": "next start",
    "lint": "next lint"
  },
  "dependencies": {
    "next": "12.2.5",
    "ogl": "^0.0.97",
    "react": "18.2.0",
    "react-dom": "18.2.0",
    "react-ogl": "^0.6.4"
  },
  "devDependencies": {
    "@types/node": "18.7.13",
    "@types/react": "18.0.17",
    "@types/react-dom": "18.0.6",
    "eslint": "8.22.0",
    "eslint-config-next": "12.2.5",
    "typescript": "4.7.4"
  }
}

The minimum supported version of react-native (an optional peer dep) doesn't support react 18 which is clashing here because of an NPM v7 policy.
You can try the --force or --legacy-peer-deps` flags without issue in your case, but I'll try to push out a reconciler upgrade which will align everything to react 18+.

Should be fixed in v0.7.0.

Hi,
Thanks for the quick fix. Unfortunately, it hasn't changed anything. I still got issue when installing react-ogl on a fresh Next app. (--legacy-peer-deps  worked like a charm but I'd like to avoid these extra parameters when deploying)
Here is the part of the code where the error appeared:
...
144 timing idealTree:node_modules/react-ogl Completed in 66ms
145 silly fetch manifest<EMAIL_ADDRESS>146 silly fetch manifest expo-asset@*
147 silly placeDep ROOT<EMAIL_ADDRESS>OK for<EMAIL_ADDRESS>want: ^0.0.3
148 silly placeDep ROOT<EMAIL_ADDRESS>OK for<EMAIL_ADDRESS>want: *
149 silly placeDep ROOT<EMAIL_ADDRESS>OK for<EMAIL_ADDRESS>want: ^2.1.1
150 timing idealTree Completed in 245ms
151 timing command:i Completed in 247ms
152 verbose stack TypeError: Cannot read properties of null (reading 'children')
152 verbose stack     at CanPlaceDep.checkCanPlaceCurrent (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/can-place-dep.js:253:35)
152 verbose stack     at CanPlaceDep.checkCanPlace (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/can-place-dep.js:157:27)
152 verbose stack     at new CanPlaceDep (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/can-place-dep.js:114:26)
152 verbose stack     at PlaceDep.place (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/place-dep.js:123:19)
152 verbose stack     at new PlaceDep (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/place-dep.js:73:10)
152 verbose stack     at /usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:990:31
152 verbose stack     at Array.map (<anonymous>)
152 verbose stack     at Arborist.[buildDepStep] (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:990:8)
152 verbose stack     at async Arborist.buildIdealTree (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:218:7)
152 verbose stack     at async Promise.all (index 1)
153 verbose cwd /Users/arno/Dev/my-app
154 verbose Darwin 21.6.0
155 verbose node v16.15.0
156 verbose npm  v8.18.0
157 error Cannot read properties of null (reading 'children')
158 verbose exit 1
159 timing npm Completed in 291ms
160 verbose unfinished npm timer reify<PHONE_NUMBER>158
161 verbose unfinished npm timer reify:loadTrees<PHONE_NUMBER>159
162 verbose unfinished npm timer idealTree:buildDeps<PHONE_NUMBER>216
163 verbose unfinished npm timer idealTree:node_modules/@expo/browser-polyfill<PHONE_NUMBER>401
164 verbose code 1

I'll take another look at this. Unfortunately, it may not be very actionable on our end since NPM is misunderstanding peer deps and version ranges as per semver. I might suggest Yarn or a package manager that correctly handles this in the meantime.

I removed the polyfill in v0.8.0 to sidestep these issues. Should be good now, we'll have to vendor polyfills like R3F does if we change our mind.

I feel like a chewing-gum stuck under your shoe but … 😬 npm install now works correctly but there is an issue with constants in the reconciler it doesn't find. 😅
error - Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/arno/Dev/my-app/node_modules/react-reconciler/constants' imported from /Users/arno/Dev/my-app/node_modules/react-ogl/dist/reconciler.mjs
Did you mean to import react-reconciler/constants.js?
    at new NodeError (node:internal/errors:372:5)
    at finalizeResolution (node:internal/modules/esm/resolve:437:11)
    at moduleResolve (node:internal/modules/esm/resolve:1009:10)
    at defaultResolve (node:internal/modules/esm/resolve:1218:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:580:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:294:18)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:80:40)
    at link (node:internal/modules/esm/module_job:78:36) {
  code: 'ERR_MODULE_NOT_FOUND',
  page: '/'

I fixed the last of the ESM issues in v0.8.1.

This looks to be resolved on my end, but do let me know if there are any withstanding issues.


std::bad_alloc from TCPResolver (libuv)

I did use make to build shared library and using uv eventloop.
When I try to run the basic example, I got null problem which is:

terminate called after throwing an instance of 'std::bad_alloc'
what():  std::bad_alloc
Process finished with exit code 134 (interrupted by signal 6: SIGABRT)

    // handler for libuv
    MyHandler handler(loop);

    // make a connection
    AMQP::TcpConnection connection(&handler, AMQP::Address("amqp://user:pass@localhost:5672/") );

It looks like something problem inside of constructor? Pass by reference for hostname? Feeding constructor of std::__cxx11_basic_string
TcpConnection::TcpConnection(TcpHandler *handler, const Address &address) :
    _state(new TcpResolver(this, address.hostname(), address.port(), address.secure(), handler)),
    _connection(this, address.login(), address.vhost()) {}

The same problem exposed with Valgrind also.

tcpresolver.h:150 2 warnings
Conditional jump or move depends on uninitialised value(s)

Are you on the master-branche? There is no code on line 150 of tcpresolver.h. Can you show the smallest possible example that I can use to reproduce this problem?

Hi, yes I am on master-branch.
Here the full usage:
https://github.com/zalper/ilyada/blob/master/amqpevent/amqp_events.cpp
I use this repo as submodule as it is. So no any change on include files.
You may not succesfully build my repo directly (lack of private libraries), but I will provide clean solution.

I copied your code into a test file:
#include <uv.h>
#include <amqpcpp.h>
#include <amqpcpp/libuv.h>

/**
 *  Custom handler
 */
class MyHandler : public AMQP::LibUvHandler
{
private:
    /**
     *  Method that is called when a connection error occurs
     *  @param  connection
     *  @param  message
     */
    virtual void onError(AMQP::TcpConnection *connection, const char *message) override
    {
        std::cout << "error: " << message << std::endl;
    }

    /**
     *  Method that is called when the TCP connection ends up in a connected state
     *  @param  connection  The TCP connection
     */
    virtual void onConnected(AMQP::TcpConnection *connection) override
    {
        std::cout << "connected" << std::endl;
    }

public:
    /**
     *  Constructor
     *  @param  uv_loop
     */
    MyHandler(uv_loop_t *loop) : AMQP::LibUvHandler(loop) {}

    /**
     *  Destructor
     */
    virtual ~MyHandler() = default;
};

int main()
{
    // access to the event loop
    auto *loop = uv_default_loop();

    // handler for libev
    MyHandler handler(loop);

    // TODO: Fix broken string issue. null str
    // make a connection
    // The problem occurs when the line below is called
    AMQP::TcpConnection connection(&handler, AMQP::Address("amqp://guest:guest@localhost:5672/"));

    // we need a channel too
    AMQP::TcpChannel channel(&connection);

    // create a temporary queue
    channel.declareQueue(AMQP::exclusive)

    .onSuccess([&connection](const std::string &name, uint32_t messagecount, uint32_t consumercount) {
        // report the name of the temporary queue
        std::cout << "declared queue " << name << std::endl;
    })

    .onError([](const char *message) {
        // something went wrong creating the exchange
        // report error
        std::cout << "queue declaration error: " << message << std::endl;
    });

    // run the loop
    uv_run(loop, UV_RUN_DEFAULT);

    // done
    return 0;
}

When I run it inside valgrind, I see no errors or warnings:
emiel@emiel:~$ valgrind ./a.out
==13407== Memcheck, a memory error detector
==13407== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al.
==13407== Using Valgrind-3.13.0 and LibVEX; rerun with -h for copyright info
==13407== Command: ./a.out
==13407==
connected
declared queue amq.gen-CclAYkkbVhofYyOLRMRdAA

Possibly something wrong with cmake/integration stuff. I'll check my flags etc.
Thank you!


feat: Securely zero memory for Passwords using secrecy Zeroize trait

Started to use RusticPassword where applicable.
@aawsome Could you let me know where else it would be good as well?
rustic_core::crypto::Key I'm aware of and currently working on. It doesn't look as straight forward as the password, though, due to more generic bounds. I will try doing that in the following commits.
Should fix #663

So, basically there is the password used by end-users (either given directly, in a file or via a command). This is then used (in combination with a key derivation function) to generate a decryption key for the information given in the KeyFile. The decrypted information is then again the master key for the repository. So, it is the password, the derived key and the master key.
I also think that Zeroize must also be used within the aes256ctr_poly1305aes crate to cover all occurences of key used in rustic.


Update repo.pp to fix #49 and #40

VMware have changed the layout of packages.vmware.com necessitating a change to this module to use the new location for the latest package releases. This PR could however break users who are specifying releases before version 10, so you might want to build a more complicated change which checks the specified version if there is one and selects either esx/$version or releases/$version...

@divad Thank you for your submission.  As per the CONTRIBUTING.md file, could you please resubmit from the develop branch?


efls-data update

Modify the deployment method of ingress in efls-data.
Add a new sample set intersection mode '--need_sort=false' in client which use lower cost of memory to get unordered data.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.chuyu.hcy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM


DataStore to use APIPlugin's Async APIs

DataStore currently uses APIPlugin's mutate, query, and subscribe APIs. It's not straight forward to move to the async APIs. For example, as an initial attempt to migrate to the async mutate API in SyncToCloudMutation https://github.com/aws-amplify/amplify-ios/pull/2250 there are issues with OutgoingMutationQueue tests where the tests hold onto the mutation's listener and resumes the API callback through the test.
To provide a path forward in removing the APIPlugin's callback APIs, they have been moved from Amplify over to AWSPluginsCore in PR https://github.com/aws-amplify/amplify-ios/pull/2253. This way, a developer does not have access to the APIs through Amplify.API, while DataStore and if other consumers really want, can cast the plugin to APICategoryGraphQLBehaviorExtended to get the GraphQL callback based APIs. APICategoryGraphQLBehaviorExtended and APICategoryGraphQLCallbackBehavior has been marked with a warning on that it has to be public but is not meant for public use, and can change without a major version bump.
For query and subscribe, both calls are encapsulated in RetryableGraphQLSubscriptionOperation and RetryableGraphQLOperation, which expects an operation. This is going to require a heavier lift to get the equivalent Retryable mechanism using the async APIs, most likely by replicating the class and creating a new version like RetryableGraphQLSubscriptionTask and RetryableGraphQLTask.

This is more of an improvement that doesn't impact the customer's call to Amplify APIs. Moving this to internal tracking.


[BUG] sok produces nan under horovod

Describe the bug
I followed the dense demo , and the loss is nan.
To Reproduce
follow the tutorial and run
horovodrun -np 2 python3 run_sok_horovod.py --data_filename_prefix="./data_" --global_batch_size=65536 --max_vocabulary_size_per_gpu=1024     --slot_num=100 --nnz_per_slot=10 --num_dense_layers=6 --embedding_vec_size=4 --optimizer="adam"

but it seems to be working well under tf strategy
mpiexec -n 2 --allow-run-as-root python3 run_sok_MultiWorker_mpi.py --data_filename="./data_" --global_batch_size=65536 --max_vocabulary_size_per_gpu=8192 --slot_num=100 --nnz_per_slot=10 --num_dense_layers=6 --embedding_vec_size=4 --data_splited=1 --optimizer="adam"

Screenshots

Environment (please complete the following information):

Graphic card: NVIDIA-SMI 460.73.01 / Tesla T4
cuda: 11.0
cudnn: 8.1.1
nccl: 2.11
tensorflow: 2.5
horovod: 0.23

Thanks for your feedback, we will try to reproduce it and will come back to you when we figure out why.

Thanks for your feedback, we will try to reproduce it and will come back to you when we figure out why.

Hello, do you use python3 gen_data.py --global_batch_size=65536 --slot_num=100 --nnz_per_slot=10 --iter_num=30 (just like the command in ReadMe) to generate your dataset?
If you don't specify --vocabulary_size in gen_data.py, the default value of vocabulary size is 8192, which means if you want to execute run_sok_horovod.py with 1 process (like you did in the screenshot), you need to change the --max_vocabulary_size from 1024 to 8192 or larger.
The reason why tf strategy does not meet this problem is that the value of --max_vocabulary_size is already 8192 in ReadMe.
Please let me know if this doesn't solve your problem.

Hello, do you use python3 gen_data.py --global_batch_size=65536 --slot_num=100 --nnz_per_slot=10 --iter_num=30 (just like the command in ReadMe) to generate your dataset? If you don't specify --vocabulary_size in gen_data.py, the default value of vocabulary size is 8192, which means if you want to execute run_sok_horovod.py with 1 process (like you did in the screenshot), you need to change the --max_vocabulary_size from 1024 to 8192 or larger. The reason why tf strategy does not meet this problem is that the value of --max_vocabulary_size is already 8192 in ReadMe. Please let me know if this doesn't solve your problem.

Problem solved if I change max vocabulary size to 8192. Thanks.


vee-validate how to validate editor content

Need to validate editor-content input field for any data inputed.
Tried to use something like this with no luck:
 <editor-content :editor="editor" class="editor__content" v-validate="'max:10'" name="editor"/>
vee-validate does not show error if more than 10 characters inputed.
Thanks for any advice.

This is not how v-validate will work because  is not an input element. You have to manually validate the content with the update event of tiptap.


Add basic epoch-interruption config to fuzzing options.

Without async fuzzing, we won't be able to test the most interesting
aspects of epoch interruption, namely the
interrupt/update-deadline/resume flow. However, the "trap on epoch
change" behavior works even for synchronous stores, and if we never
change the epoch, then we should see the same behavior as without epoch
interruption instrumentation.
This will at least give us coverage of the codegen, and ensure that the
codegen is compatible with all control flow, etc. that we otherwise
generate; and will check one half of correct execution, namely "no
interruptions happen when we don't expect any".
Created due to @alexcrichton noting that we don't have coverage of
epoch-related codegen in this oss-fuzz coverage report (thanks!).

Ah, yes, good idea -- done!


How concatenate an embedding with outputs of LSTM with variable length

i've got an LSTM with return_sequence =True and mast_zero=True, whose output shape (Samples, Timesteps, units)= (None, None, output_size) because of the variable timesteps.
Furthermore, I want to concatenate an embedding with each of the output of LSTM, to merge the information from another data modality.
However, the Timesteps of  Embedding layers can't be None(i.e. it can't be variable) even when I user mask_zeo.
How can i do to fix this?

Is there any upper limit on the number of timesteps that you consider?
If there is, then you could do something like:

pad the input to the maximum number of time steps (denote it by max_timesteps) and then pass it to embeddings layer
then you could use Keras.backend.gather to obtain the first valid timesteps of input
then use Keras.backend.concatenate

@samre12  thanks bro.
Yes indeed I've got a %max_timesteps%, do you mean that i will pass the output_mask of the previous Embedding layer and use gather to truncate the tensor?
However, Keras.backend.gather seems only perform such operation over the first dimension(which is the sample dim)
    # Scalar indices
    output[:, ..., :] = params[indices, :, ... :]

    # Vector indices
    output[i, :, ..., :] = params[indices[i], :, ... :]

    # Higher rank indices
    output[i, ..., j, :, ... :] = params[indices[i, ..., j], :, ..., :]

@Liuch10 , thanks for pointing that out. You could use keras.backend.permute_dimensions with keras.backend.gather to make it work.

@samre12 Hi, I met the same problem in implementing VAE with condition. Could you please write an example on how to use these two functions? Thanks


Fibonacci nth term in Javascript, optimized with DP

No Javascript code file was available for fibonacci sequence, and i have written the code for it. Hence, making this pull request. Pls do merge.

Thank you for creating an optimized solution


Hit / Miss When Splash Image Shown

Currently there is a "hit and miss" on when image is shown with splash screen.

Haven't been able to pinpoint on when it doesn't show and when it does.

For me, it either loads the entire splash screen (both the "Loading..." and the image) or nothing at all.

same here

Fixed #348


Drop is_bare IDX only when it exists for MySQL and MariaDB

Fixes https://github.com/go-gitea/gitea/issues/6718#issuecomment-486119583

Codecov Report

Merging #6736 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6736      +/-   ##
==========================================
- Coverage   40.73%   40.73%   -0.01%
==========================================
  Files         421      421
  Lines       57902    57908       +6
==========================================
- Hits        23588    23587       -1
- Misses      31179    31187       +8
+ Partials     3135     3134       -1

Impacted Files
Coverage Δ

models/migrations/v78.go
0% <0%> (ø)
:arrow_up:

models/unit.go
45.71% <0%> (-5.72%)
:arrow_down:

routers/repo/view.go
41.6% <0%> (-1.01%)
:arrow_down:

models/repo_list.go
67.89% <0%> (+1.05%)
:arrow_up:

modules/log/event.go
65.98% <0%> (+1.52%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59be704...9715cac. Read the comment docs.

please backport to release/v1.8


Use higher HTTP version when possible

If protocol is http, version 1.1 will be used. I the runtime only can provide 2.0, then that will be used.

@Henr1k80 looks good, thanks!


fix bug when no client id

Coverage increased (+0.2%) to 82.429% when pulling 0d54521e8cf3a8d58b08497771026f333abb39c6 on label-fix into f7c6fcdcd739261cab53d1ce3fe0f21db70efb4f on development.

Coverage increased (+0.2%) to 82.429% when pulling 0d54521e8cf3a8d58b08497771026f333abb39c6 on label-fix into f7c6fcdcd739261cab53d1ce3fe0f21db70efb4f on development.


separate_rows fails silently if there are no other columns

If we have a dataframe:
df = DataFrame(Column1 =[
"7 6 4 2 1",
"1 2 7 8 9",
"9 7 6 2 1",
"1 3 2 4 5",
"8 6 4 4 1",
"1 3 6 7 9"]
)

And try to separate it into rows:
@separate_rows(df, Column1, " ")

The returned DataFrame is unchanged and no error is thrown. The function works as expected if another Column is present, e.g:
@chain df begin
    @mutate(id = 1:6)
    @separate_rows(Column1, " ")
end

returns
30×2 DataFrame
 Row │ Column1    id
     │ SubStrin…  Int64
─────┼──────────────────
   1 │ 7              1
   2 │ 6              1
  ⋮  │     ⋮        ⋮
  29 │ 7              6
  30 │ 9              6
         26 rows omitted

Never thought to test for that when I wrote it. Happy to fix it

Advent of code makes you write weird code! It's not a common way to use the function but it took me a minute to figure out why it was failing

I think the problem may have something to do with InlineStrings - when I tested it, I was reading that little DataFrame from a file, and I can replicate the behaviour if I declare it as a String15:

wow unique situation, but good edge case to know about. i had no idea.
if ismissing(value) || typeof(value) != String
#changed to
if ismissing(value) || !(value isa AbstractString)

and it now should work works
julia> df = DataFrame(Column1 = String15[
       "7 6 4 2 1",
       "1 2 7 8 9",
       "9 7 6 2 1",
       "1 3 2 4 5",
       "8 6 4 4 1",
       "1 3 6 7 9"]
       );

julia> @separate_rows(df, Column1, " ")
30×1 DataFrame
 Row │ Column1
     │ SubStrin…
─────┼───────────
   1 │ 7
   2 │ 6
   3 │ 4
   4 │ 2
   5 │ 1

Resolved in #127.


feat: PoC for console.log() style debug prints

Skeleton PR on how to support the usage of hardhat's console.sol smart contract
There is an issue with abigen that blocks the usage of the same function log with different arguments. (ethers-rs issue)
console.log() is printed as the EVM intercepts the command.

Issues addressed. Last item is to unblock dapptools-rs and use the inctremental approach to overloaded functions and properly handle the %s replacement.
println() can't be used directly, cause we first have to replace the %s in the decoded message.

superseded by #164


NIFI-12789 - fix broken link in couchbase additional details

Summary
NIFI-12789 - fix broken link in couchbase additional details
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[ ] Apache NiFi Jira issue created

Pull Request Tracking

[ ] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[ ] Pull Request based on current revision of the main branch
[ ] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 21

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

@exceptionfactory Can you please restart the failed jobs? The changes look fine I would just like to approve once all the jobs are successful. Thanks!

LGTM+1

@dan-s1 thanks for reviewing and merging, is it possible to also get this into the support branch?

@pvillard31 Done


Prometheus metrics scrapping

Netbox Chart version: v4.1.1

I'm trying to scrape Netbox metrics using my OpenShift cluster's internal Prometheus.
I've set the value metricsEnabled to true, and I can access the /metrics endpoint from the external URL.
I also configured a ServiceMonitor to monitor Netbox Service:
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  labels:
    k8s-app: netbox-monitor
  name: netbox-monitor
  namespace: my-namespace
spec:
  endpoints:
  - interval: 30s
    port: http
    scheme: http
  selector:
    matchLabels:
      app.kubernetes.io/name: netbox

The monitoring target is created, but it is getting 400 Errors, because it tries to access the /metrics endpoint using the Pod's IP, which is not in the ALLOWED_HOSTS parameter.
As a workaround, I'm adding an ExtraEnv in the values.yaml with the Pod's IP:
# Extra environment variables to add to the Pod
extraEnvs:
  - name: POD_IP
    valueFrom:
      fieldRef:
        apiVersion: v1
        fieldPath: status.podIP

And I'm manually updating configuration.py in the netbox configmap, so that the Pod's IP is added to the ALLOWED_HOSTS:
kind: ConfigMap
apiVersion: v1
metadata:
  name: netbox
  [.....]
data:
  configuration.py: >

  import os   # add this import

  [.....]

  _load_yaml()

  ALLOWED_HOSTS.append(os.getenv("POD_IP"))

Anyone has a better solution? Or could we update the Chart so that it is simpler to allow the Pod's IP in the ALLOWED_HOSTS?

I did a bit of looking into this and I think you've come up with the cleanest solution already. It just needs stitching into the Helm chart so you don't have to do your manual step each time. Something like this PR.

Wow so quick! Thanks for your reactivity @rossigee!
This would be perfect for me 👌
Just one thing, I think you forgot to add the doc in the README in the PR.

I actually merged #167 the other day, with docs included, so it will be in the next release of the chart.

Oh I had not seen the docs sorry! Thanks for the merge


github.com/codegangsta/cli -> github.com/urfave/cli

cannot run GO111MODULE=on go get github.com/codegangsta/cli due to repo change


WFLY-16272 Fix IllegalArgumentException while using an expression in use-java-context

Issue: https://issues.redhat.com/browse/WFLY-16272
@tadamski  please review

Thanks, I have removed that piece of code.

Hi @bstansberry  @tadamski May I get your approval on this ? so I can backport this to EAP.


Update LICENSE

needed to make a change to test out the CLA.

Hey, this is pretty cool!

I have read the CLA Document and I hereby sign the CLA

recheck


Producing screencasts about OmniSharp

I was asked to open this issue to discuss getting a series of videos I am producing about using OmniSharp across editors on the site.  I have the first 2 in this playlist:
https://www.youtube.com/playlist?list=PLx_MamJPwgQMZ86orfrrFKdSzlhi2dfG9

Hey,
Max got bored and put some colour on it. Comments welcome. In particular looking for feedback from @nosami @jchannon @Mpdreamz @yantrio @stephen-james @sayedihashimi @shanselman

Looks awesome! :+1:
On Wed, Feb 18, 2015 at 10:49 AM, Mathew McLoughlin <
<EMAIL_ADDRESS>wrote:

Hey,
Max got bored and put some colour on it. Comments welcome. In particular
looking for feedback from @nosami https://github.com/nosami @jchannon
https://github.com/jchannon @Mpdreamz https://github.com/Mpdreamz
@yantrio https://github.com/yantrio @stephen-james
https://github.com/stephen-james @sayedihashimi
https://github.com/sayedihashimi @shanselman
https://github.com/shanselman
[image: image]
https://cloud.githubusercontent.com/assets/2362687/6245967/cfd77008-b75b-11e4-8232-53ed81b0bb79.png
—
Reply to this email directly or view it on GitHub
https://github.com/OmniSharp/OmniSharp.github.io/issues/5#issuecomment-74845391
.

Looks good!
You could reorder the editor names so its
C
A
V
E
S
then remove vim ;)
On 18 February 2015 at 10:50, Jason Imison<EMAIL_ADDRESS>wrote:

Looks awesome! :+1:
On Wed, Feb 18, 2015 at 10:49 AM, Mathew McLoughlin <
<EMAIL_ADDRESS>wrote:

Hey,
Max got bored and put some colour on it. Comments welcome. In particular
looking for feedback from @nosami https://github.com/nosami @jchannon
https://github.com/jchannon @Mpdreamz https://github.com/Mpdreamz
@yantrio https://github.com/yantrio @stephen-james
https://github.com/stephen-james @sayedihashimi
https://github.com/sayedihashimi @shanselman
https://github.com/shanselman
[image: image]
<
https://cloud.githubusercontent.com/assets/2362687/6245967/cfd77008-b75b-11e4-8232-53ed81b0bb79.png
--
Reply to this email directly or view it on GitHub
<
https://github.com/OmniSharp/OmniSharp.github.io/issues/5#issuecomment-74845391

.

--
Reply to this email directly or view it on GitHub
https://github.com/OmniSharp/OmniSharp.github.io/issues/5#issuecomment-74845510
.

Needs more green fire with pound sign though :)

We need @davidfowl on there too :)
On Wed, Feb 18, 2015 at 1:53 PM, Martijn Laarman<EMAIL_ADDRESS>wrote:

[image: :ship:] [image: :it:] seriously sexy !
Needs more green fire with pound sign though :)
—
Reply to this email directly or view it on GitHub
https://github.com/OmniSharp/OmniSharp.github.io/issues/5#issuecomment-74866559
.

Looks great!

One question, can we update it to include a section for the videos that @douglasstarnes has created? Perhaps we can create a few more for the other editors and have a complete showcase.

@mat-mcloughlin any status on this one? If you surface the psd from Max I could hack the site together during the flight to portland :)

Ha was thinking the same thing. Not sure if I got the psd but I can get it

Go go go
On Friday, 3 April 2015, Mathew McLoughlin<EMAIL_ADDRESS>wrote:

Ha was thinking the same thing. Not sure if I got the psd but I can get it
--
Reply to this email directly or view it on GitHub
https://github.com/OmniSharp/OmniSharp.github.io/issues/5#issuecomment-89239592
.

Super cool. Gotta do a PR to add my mug on there as well :-)

And we need a real picture of @mat-mcloughlin.

This is my real face. I'm northern so just really pale

@spboyer "Gotta do a PR to add my mug on there as well :-)"
Please do


(FACT-1389) Fix acceptance test on systems with Ruby installed

Previously the path to find Ruby was setup with system paths first, so
we would find any system Ruby installed. That caused the test to fail
when that Ruby is 1.8.7. Fix to find the puppet-agent Ruby instead.
[skip ci]

Makes sense. Don't need travis/appveyor since this is in acceptance.


Set dbuser access type on database removing

It's most probably causing the endless test workflow for the v1.13.0 release, example here (https://github.com/db-operator/charts/actions/runs/5831636739)

@db-operator/admins I think it's ready


Resources page

Can now "bookmark" a useful webpage with the following command on discord
!res link tag1,tag2..tagn des

Cannot merge most likely because last time I accidentally committed to master and then revert. Once this is approved I will use the command line to merge this branch into master manually and force push.


Error messages when non-JSON file is open

Fix: - Error when opening non-JSON file in Notepad++ while JSON Viewer Panel is active
- Error when opening JSON Viewer Panel while non-JSON file is active

I use a different way now.
One of the problems was also the workaround in NppJsonPlugin.cpp#L73. It triggers a "refresh" (same like the user clicks the button), which can lead to an error message, but on startup that's undesired.
In the current release, if the panel was reopened, the treeview wasn't updated. Fixed it too.

Hi, could you please review the pull requests when you have time.

!?

Sorry, for taking long time to review.
It causes another regression when opening Viewer panel first time with for a valid json file.
For example:

Json file
{
}

It adds "Can't parse json".

But when refreshed it manually. it works properly.

Also when invalid json file is there, then it appends "Can't parse" in the end of tree.

Fixed it via 36617c6a78420e9199906117b701acd8c2af5daa


[Bug] Paged operations model response type names don't match the actual model name

For reference https://github.com/Azure/cadl-ranch/tree/main/packages/cadl-ranch-specs/http/payload/pageable
Looking at the SdkHttpOperation.responses, the returned model has the name “PagedUser” which doesn’t match the underlying model name “User”. As a result, we don’t know how to map the response type name to the corresponding model name. I suppose we could remove the “Paged” prefix but that seems like a bit of a hack. What’s the reasoning behind the discrepancy and, if it must remain this way, what’s the proper way to map “PagedUser” to “User” (i.e. for Paged how do I get the type name of T)?

@iscai-msft we may add sth like page item just like lro logical result. what do you think?

talked with @jhendrixMSFT, this information already exists. If you go onto method.response, there is optional property responsePath. If that exists, it tells you the path to take to get from a service response -> the final method response. For paging, the service will return the paged model (which tsp gives to us as PagedUser). PagedUser has two properties: nextLink, and items. The method response ultimately returns items to the user, so in this case, method.response.responsePath === "items"

I think this is a non-issue and a bit of user error so closing.


workflow: Fix vscode debug caused by node run shell

environment：

VS Code Version: 1.64
OS Version: macOS big sur 11.4
OS chip: Apple M1
node Version: 16.13.1

Use the original launch json debugger:

This fails because VS Code's node debugger cannot debug shell scripts. The reason is that pnpm is used for installation node_modules/.bin/jest is a shell file, so the error in the figure above is reported.vscode-issues
I work fine in the config, but i didn't test other systems.

I don't know how to pass these tests. Is there any document to guide me

@LinusBorg  Please look over here. It's been a while

@HcySunYang look look

Works for me. Is there any progress?

Works for me. Is there any progress?

fix vscode debug

Thanks for the PR.
But we've migrated to Vitest. So I'm closing this one.


Pull branch action is inconsistent with git pull wrt. fetching OTHER branches from the remote

As noticed by @micpiotrowski, Pull branch action behaves in a manner INconsistent with what git pull does, which might surprise the users.
git pull by default fetches all branches from the remote (refspec +refs/heads/*:refs/remotes/origin/*, unless specified explicitly).
Our Pull branch action fetches only the given branch from the remote (refspec e.g. +refs/heads/master:refs/remotes/origin/master), other branches under refs/remotes/origin/ remain unchanged.
This can be resolved either by:

making the behavior of Pull action consistent with git pull OR
displaying a relevant message that explains that behavior is different from git pull's (questionable, hard to convey concisely, esp. to non-expert users).

As time passes, I'm convinced that (1.) is a way to go.
A nuance: com.virtuslab.gitmachete.frontend.actions.toolbar.FetchAllRemotesAction#lastFetchTimeMillisByRepositoryName is now only updated when the Fetch action happens... but after this change, this should be extracted to some shared place and also updated in the Pull action.

I ve came across an interesting finding. Maybe we are not consistent with git here but we are consistent with IntelliJ :laughing:
Anyway I see that git-way is better and I will proceed with that
IntelliJ's "Update" branch message fyi:


Add an include about resource naming.

Summary
Add an include about resource naming.
Fixes #1094

Internal previews

📄 File
🔗 Preview link

docs/deployment/azure/aca-deployment-azd-in-depth.md
Deploy a .NET Aspire app to Azure Container Apps using the Azure Developer CLI (in-depth guide)

docs/deployment/azure/aca-deployment-github-actions.md
[Windows](https://review.learn.microsoft.com/en-us/dotnet/aspire/deployment/azure/aca-deployment-github-actions?branch=pr-en-us-1104)

docs/deployment/azure/aca-deployment-visual-studio.md
Deploy .NET Aspire apps to Azure Container Apps using Visual Studio

docs/deployment/azure/aca-deployment.md
Deploy a .NET Aspire app to Azure Container Apps

LGTM


Add bluesign to CODEOWNERS

This is long overdue but @bluesign has been an amazing contributor to the Emulator and I want to make it an official codeowner of the codebase. Thank you!.

I believe we additionally need to add write permission to the repo to @bluesign will reach out to IT.

Codecov Report

Merging #261 (0e6305d) into master (e753074) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #261   +/-   ##
=======================================
  Coverage   52.38%   52.38%
=======================================
  Files          26       26
  Lines        2037     2037
=======================================
  Hits         1067     1067
  Misses        845      845
  Partials      125      125

Flag
Coverage Δ

unittests
52.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

oh thank you very much all <3


Photo cannot be deleted! 400 - Bad Request - 690: An unexpected server error has occurred

I tried to delete a few photos and got the error in the title. The images are the last few in sequence 3309117, if that helps. Also, it was on the kartaview.org site, if that matters.
This isn't a huge big deal in this instance. I was going to delete the images because they were taken when the phone fell out of the mount, not because there was anything objectionable about them other than being useless. Just letting you know about the error.
On a positive note, the processing has been quick and flawless today. Thanks.

checking now

#226 and #285 covered this sort of, the photo actually does delete but just shows an error for some reason.
It's been that way for over a year like many of the other open issues on here.

@GeekOnTheHill this issue has been fixed, please try delete the photo again on https://kartaview.org/

@GeekOnTheHill this issue has been fixed, please try delete the photo again on https://kartaview.org/

Sorry about the delay. Been busy this past week. Yes, it's working fine now. Thank you.


Disable version compatibility check.

c82703844754d7852dad695f75a78388a17401b9 cherry picked on top of release/5.4.

Cherry picking https://github.com/Terracotta-OSS/terracotta-core/pull/896 on top of 5.4.

Solved by other means


improve Arabic hero text

This seems to have a slightly different meaning than our Speak your truth, in any language.:

Updated to mean personal truth rather than the absolute truth.

Yeah. Thanks a lot!


Added a feature to allow the stepper images color to be different from the tint color

@jesster2k10 Thanks, but a little confused as both open PRs of yours have all your changes. Can you fix?


[Feature Request] global artifacts accessibility

Is this a BUG REPORT or FEATURE REQUEST?:
feature request
What happened:
Global artifacts cannot be used in a template which is referenced in a step template.
What you expected to happen:
Global artifacts can be used just like the parameter does.
Environment:

Argo version:

$ argo version
argo: v2.1.1
  BuildDate: 2018-05-29T20:39:36Z
  GitCommit: ac241c95c13f08e868cd6f5ee32c9ce273e239ff
  GitTreeState: clean
  GitTag: v2.1.1
  GoVersion: go1.9.3
  Compiler: gc
  Platform: linux/amd64

Kubernetes version :

$ kubectl version -o yaml
clientVersion:
  buildDate: 2018-06-06T08:13:03Z
  compiler: gc
  gitCommit: 5ca598b4ba5abb89bb773071ce452e33fb66339d
  gitTreeState: clean
  gitVersion: v1.10.4
  goVersion: go1.9.3
  major: "1"
  minor: "10"
  platform: linux/amd64
serverVersion:
  buildDate: 2018-06-06T08:00:59Z
  compiler: gc
  gitCommit: 5ca598b4ba5abb89bb773071ce452e33fb66339d
  gitTreeState: clean
  gitVersion: v1.10.4
  goVersion: go1.9.3
  major: "1"
  minor: "10"
  platform: linux/amd64

Duping this to issue #931

@jessesuen Is it possible to have an example ? I can't make it work
spec:
  entrypoint: ci
  arguments:
    artifacts:
      - name: repository
        git: ...

When I try to use it
  templates:
    - name: ci
      steps:
        - - name: build
            template: build

    - name: build
      inputs:
        artifacts:
          - name: repository
            path: /repository

I get invalid spec: templates.build inputs.artifacts.repository was not supplied". But I can't find a way to supply it via from or by another way


No path to target block crash

NoPath: No path to target block!
    at Object.error (/mnt/c/Users/Sinan/node_modules/mineflayer-collectblock/lib/Util.js:13:15)
    at EventEmitter.<anonymous> (/mnt/c/Users/Sinan/node_modules/mineflayer-collectblock/lib/CollectBlock.js:74:27)
    at EventEmitter.emit (events.js:315:20)
    at EventEmitter.monitorMovement (/mnt/c/Users/Sinan/node_modules/mineflayer-pathfinder/index.js:272:15)
    at EventEmitter.emit (events.js:327:22)
    at Timeout.doPhysics [as _onTimeout] (/mnt/c/Users/Sinan/node_modules/mineflayer/lib/plugins/physics.js:63:13)
    at listOnTimeout (internal/timers.js:554:17)
    at processTimers (internal/timers.js:497:7)

The bot crashes sometimes with no visible reason to me, on 1.16.4 vanilla server.

This is an issue of mineflayer-collectblock.

This is an issue of mineflayer-collectblock.

Oh sure, sorry, wrong tab :o

Oh sure, sorry, wrong tab :o


Mat1646 dataset class models

PR adds a new class BeepDataset that provides capability to assemble a ML training dataset comprised of different BeepFeatures objects corresponding to battery cycling runs from one or more projects. A few highlights

Method to merge from multiple BeepFeatures --> BeepDataset
Method to first transform a list of ProcessedCyclerRun objects --> BeepFeatures --> BeepDataset
Log failed featurizations or missing runs/folders
Can combine multiple feature sets and multiple projects.
Train test split by cells and join cell_ids with project parameters for troubleshooting, and filtering data.

@chirranjeevigopal-TRI I merged the PR with the credentialing fix. Let me know if you can merge those changes into this PR

@patrickherring-TRI Yup, pulled the master and working on fixing docstrings before re-submitting.


I clearly remember implementing garbage detection for the game the bot was originally made for, so it should be an easy fix.

Very satisfied with the bot's ability to survive Tetris positions, does the bot recognise garbage using RGB values of the garbage?  If so, that could be the issue since different Tetris games use different colours.

glad to hear!
yes, it uses RGB values indeed, the garbage was white in our game. the corresponding lines are
field_white0 = np.array(field[:, :, 0] > 200, int)
field_white1 = np.array(field[:, :, 1] > 200, int)
field_white2 = np.array(field[:, :, 2] > 200, int)

in data.py

That's probably the issue, the garbage on tetr.io is darker than white, I'll do some tinkering and see what the proper RGB values should be.

Entered the RGB values which are 28, 28, 28, bot stopped playing altogether, could this be something with the < and > symbols?

I assume the garbage is black in your case? then of course you need to change '>' to '<'. otherwise everything is recognized as garbage

It's got an rgb value of 28 for all colours, using > and < both cause the bot to stop playing entirely, could be because the colour range is a bit weird

are you sure there is nothing else on the screen that has rgb < 28?
you need to come up with an rbg range that includes only garbage, not the actual pieces, not the background

don't forget that you can look at the field array to know exactly what the bot sees

When it looks for under 28 the array sees a line at the very top and nothing else, when looking for above 28 the array just sees nothing

consider using 20 < field[:, :, 0] < 30 or something along those lines

tried doing that, the array always shows this
[[0 0 0 0 1 1 0 0 0 0]
[0 0 0 0 1 1 0 0 0 0]
[0 0 0 0 0 0 0 0 0 0]
[0 0 0 0 0 0 0 0 0 0]
[0 0 0 0 0 0 0 0 0 0]
[0 0 0 0 0 0 0 0 0 0]
[0 0 0 0 0 0 0 0 1 0]
[0 0 0 0 0 0 0 1 1 0]
[0 0 0 0 0 0 0 1 1 0]
[1 0 0 0 0 0 0 1 1 0]
[1 0 0 0 0 0 0 1 1 0]
[1 1 0 0 0 0 0 1 1 0]
[1 1 0 0 0 0 0 1 1 0]
[1 1 1 0 0 0 1 1 1 0]
[1 1 1 0 1 0 1 1 1 0]
[1 1 1 0 1 0 1 1 1 0]
[1 1 1 1 1 0 1 1 1 0]
[1 0 1 1 1 1 1 1 1 0]
[0 0 0 0 0 0 0 0 0 0]
[0 0 0 0 0 0 0 0 0 0]
[0 0 0 0 0 0 0 0 0 0]
[0 0 0 0 0 0 0 0 0 0]]

well, I don't know what it should look like in this case, but the idea is to have garbage encoded just like a regular block. So 1 for pieces/garbage and 0 for empty space

The zeros at the bottom are supposed to be mostly 1s represented by garbage but the bot doesn’t recognise them, all rgb values entered either make the bot stop playing or not detect correctly

ok it might be that I was wrong and the 'white' stuff is for garbage, it might also be for a huge TETRIS text appearing in some cases. In any case, the get_field_from_screen function is honestly not very intuitive, so it would probably be useful for you to rewrite most of it.
As the field parameter, you get an rbg image, an array of shape (h, w, 3). You need to return another array of shape (h, w) where an element is 1 if the image has a piece or garbage on this pixel

would the shape array come from the figures.py file?

did you manage to do it?
the exact values of h and w shouldn't really matter, and can vary per user, just return the same as it was

Still unable to figure out why the bot can’t detect the garbage, from what I can see it doesn’t need to see the piece shape because entering a position allows the bot to just play from what it started with so the only way I can see it doesn’t detect garbage is because of the rgb values but I’m unable to set an rgb range for the garbage detection

dont try with field_white, do it your own way. maybe if the background is darker than everything else, you can put
pieces0 = np.array(field[:, :, 0]  > bg_color,  int) for each color and then take multiply the resulting arrays to perform 'and' operation (field = pieces0 * pieces1 * pieces2)

I’ll try every method I have to change it and I’ll give an update once I finish it

def get_field_from_screen(self, img):
field = img[self.top:self.bottom, self.left:self.right]
field0 = np.array(field[:, :, 0] <130, int)  # blue
field1 = np.array(field[:, :, 1] <100, int)  # green
field2 = np.array(field[:, :, 2] <90, int)  # red
field_white0 = np.array(field[:, :, 0] >200, int)
field_white1 = np.array(field[:, :, 1] >200, int)
field_white2 = np.array(field[:, :, 2] >200, int)
pieces0 = np.array(field[:, :, 2] >0, int)
pieces1 = np.array(field[:, :, 2] >0, int)
pieces2 = np.array(field[:, :, 2] >0, int)
pieces = pieces0 * pieces1 * pieces2
field_white = field_white0 * field_white1 * field_white2
field = field0 * field1 * field2 + field_white
field = 1 - field
return field
Tried this but it makes python unresponsive, no error code, no field image, and no game inputs

Hello there @NameLmao ,
I got some time and refactored a large portion of the code, now it should be much more readable.
Besides that, I adapted the bot to tetr.io multiplayer (so garbage detection included), and it performs very well. The last commit on the master branch, with a few modifications to the new config.py, should get you there!

Ok, I’ll check the new code, thank you for your dedication

Did you find any success with the new code?

Sorry for not responding in a long time, I forgot about this. The bot works much better now that it detects garbage though, thank you.

consider starring the project if you liked it!


Wait for the review app deployment to finish in PR build workflow

Context
Currently the review app deployment is asynchronous from the build workflow,
so it is not visible in the PR checks if the app deployment has failed.
Changes proposed in this pull request
Add an action to wait for the deployment workflow
Fail the PR build check, if the review app deployment fails
Guidance to review

 Wait for review app deployment to finish


#667 Error setting resourceFile: "Maximum call stack size exceeded"

Preventing the infinite recursion by not translating warning about missing translation.

Please see and reopen issue #667 . What I provide here is fix of catastrphic failure in infinite recursion. It doesn't fix translation in compilation systems like webpack.

@cima thanks for the fix here!
Could you please take a look at suggestions above and bump patch number of package version also?

@anatolybolshakov I have taken a look at it and I wasn't happy with my own code. I've just add a brief unit test to be able to put breakpoint and debug and discovered two things:

Backslash is not necessary at all as it is in backtics that translates to double quotes so the direct apostrophe is not interfering with compiler when parsing a string quotation.
The parameter in formated string was totally wrong. It supposed to be key not path.

I have compile it, run tests and the fix is pushed in the branch.

/azp run


parameterization of the coordinates of the BBox

Thank you for your clean and effective implementation.
In the source code of calc_transformer in bbox.py, I found that the implementation for computing the center offset of the bounding boxes is slightly different from the formula given in the original paper of the Fast R-CNN. In the paper, t_x = (x - x_a)/w_a,  where x, x_a, w_a are the x coordinate of the center of the predicted box, anchor box and the width of the anchor box, respectively. But in the code, it is divided by the center_based_dst_bboxes[..., 2], which seems to be the width of the predicted boxes. This also contradicts the implementation in the apply_transformer function.
Could you please explain it a little bit?

Thanks for reporting this bug. I'll fix it in the next release.
I think it has little effect on performance, but I can only rerun the experiments when I am available.


add test to print nested json

Just adding a test to make sure nested JSON gets printed correctly (which they do) that was in https://github.com/SwiftyJSON/SwiftyJSON/pull/801

Hey @gsabran Seems like the format is broken, would you mind fixing it? Or I will do it by myself.


Disable httplib2 cache when no write permission

The library cannot be imported from a directory with
no write permissions as httplib2 fails to create the
cache. If there is an error creating deafult_http
fall back to having no cache.
Closes #51

Don't know if there is a good way to add that to the coverage testing as it only happens on the first import of the library so can only test one outcome during a single test run, sorry.


How to build a AR Android App without Gear/DayDream/Oculus Targeting

Hey,
I'm tying to build the SampleAR App where you can place a Mug, Flowers or Smily somewhere in the room. I have know that there a two different types of build settings in gradle file (GVR/OVR). But what if I don't need any of the given VR Solutions like Gear or Daydream and just want a standalone app?
Thanks for your help!

Hi @dominicrico,
If you select GVR and simply use a ViroARSceneNavigator it will work just fine. If you select OVR and use it on a Samsung device, then the device will immediately jump into GearVR mode (but still show AR).
Thanks,


[CI] Retarget to OpenAssetIO release

Now that OpenAssetIO v1.0.0-beta.2 is released, we can once again depend on the PyPI packages.

Reviewed over Zoom, looks good


Please find a solution for Ledvance BT bulbs connected directly to an echo

NOTE: For a feature to be created it has to be doable in the Amazon app because we are basically replicating the app for HA. If you can't find it in the app, we probably can't create it here.
Is your feature request related to a problem? Please describe.
My bluetooth bulbs from Ledvance which are connected directly to an echo do not show up.
After reviewing the code, it seems that they are not detected as locally connected by alexa_entity.py#is_local. I checked the appliance's json and saw that connectedVia is not set (empty string), "ALEXA_VOICE_ENABLED" is not included in applianceTypes and the zigbee id pattern does not match (which is clear to me because it isn't a zigbee device):

{
"AAA_SonarCloudService_e42267783d4ef73e9f4a16c97ecc84a8": {
"applianceId": "AAA_SonarCloudService_e42267783d4ef73e9f4a16c97ecc84a8",
"endpointTypeId": "",
"driverIdentity": {
"namespace": "AAA",
"identifier": "SonarCloudService"
},
"manufacturerName": "Ledvance",
"friendlyDescription": "Ledvance intelligentes Gerät",
"modelName": "",
"deviceType": "",
"version": "0",
"friendlyName": "Erste Licht",
"friendlyNameModifiedAt":<PHONE_NUMBER>103,
"capabilitiesModifiedAt":<PHONE_NUMBER>103,
"ipAddress": "",
"port": "",
"entityId": "41015137-bfda-4ae9-9c84-80594e38b690",
"applianceNetworkState": {
"reachability": "REACHABLE",
"lastSeenAt":<PHONE_NUMBER>739,
"createdAt":<PHONE_NUMBER>103,
"lastSeenDiscoverySessionId": {
"value": "5c3de69c-1ae1-4ef9-a813-f7f9d34e5905"
}
},
"tags": {
"tagNameToValueSetMap": {}
},
"additionalApplianceDetails": {
"additionalApplianceDetails": {}
},
"firmwareVersion": "0",
"actions": [],
"capabilities": [
{
"capabilityType": "AVSInterfaceCapability",
"type": "AlexaInterface",
"version": "3",
"properties": {
"supported": [
{
"name": "powerState"
}
],
"proactivelyReported": true,
"retrievable": true,
"readOnly": false
},
"interfaceName": "Alexa.PowerController"
},
{
"capabilityType": "AVSInterfaceCapability",
"type": "AlexaInterface",
"version": "3",
"properties": {
"supported": [
{
"name": "colorTemperatureInKelvin"
}
],
"proactivelyReported": true,
"retrievable": true,
"readOnly": false
},
"interfaceName": "Alexa.ColorTemperatureController"
},
{
"capabilityType": "AVSInterfaceCapability",
"type": "AlexaInterface",
"version": "3",
"properties": {
"supported": [
{
"name": "color"
}
],
"proactivelyReported": true,
"retrievable": true,
"readOnly": false
},
"interfaceName": "Alexa.ColorController"
},
{
"capabilityType": "AVSInterfaceCapability",
"type": "AlexaInterface",
"version": "3",
"properties": {
"supported": [
{
"name": "brightness"
}
],
"proactivelyReported": true,
"retrievable": true,
"readOnly": false
},
"interfaceName": "Alexa.BrightnessController"
},
{
"capabilityType": "AVSInterfaceCapability",
"type": "AlexaInterface",
"version": "3",
"properties": {
"supported": [
{
"name": "connectivity"
}
],
"proactivelyReported": true,
"retrievable": true,
"readOnly": false
},
"interfaceName": "Alexa.EndpointHealth"
}
],
"applianceTypes": [
"LIGHT"
],
"isEnabled": true,
"aliases": [],
"connectedVia": "",
"alexaDeviceIdentifierList": [],
"applianceKey": "41015137-bfda-4ae9-9c84-80594e38b690",
"identifiers": {
"networkInterfaceIdentifiers": []
},
"applianceDriverIdentity": {
"namespace": "AAA",
"identifier": "SonarCloudService"
},
"ipaddress": "",
"applianceLambdaControlled": true,
"mergedApplianceIds": [
"AAA_SonarCloudService_e42267783d4ef73e9f4a16c97ecc84a8"
]
}
}

Describe the solution you'd like
I would like to see such bulbs show up but I have no idea what can alternatevily be checked to determine such bulbs as locally connected.
Describe alternatives you've considered
N/A
Additional context
N/A

To start a discussion, I created the commit above. I would highly appreciate comments.


(RFC) native types and providers

This is a family of native types and providers with the aim of replacing direct usage of the cli jar via exec resources (E.g. jenkins::cli:exec).  The principle motivation is to resolve the "chicken vs egg" problem that occurs between the cli jar and jenkins when enabling security.  Similarly, it provides a mechanism to set the API token on a user account that can be used for the connection of swarm clients, which otherwise are unable to connect when using a security realm that does not use password (E.g. github-oauth).  It should be relatively easy to extend these types to provide additional functionality, such as supporting additional credentials types.
No attempt has been made to integrate the new types into the existing classes and defined types.  It should be possible to try them out in an essentially stand alone fashion against a running jenkins instance.  Preliminary and extremely terse notes are in NATIVE_TYPES_AND_PROVIDERS.md.
Comments, feedback, and/or bug reports would be greatly welcomed.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

I think this is worth including. i'm not sure, past defaulting these behaviors, how to encourage their usage though

@rtyler I agree that advertising this will be difficult.  Perhaps add a section to the README about experimental types?
There is a todo in my usage notes for known issues.  In particular, I think there needs to be some discussion about the enabled param to jenkins::job as it may break idempotency by modifying the job's config.xml.  The easiest thing to do would be to deprecate the param and make it a "no-op".  Another option would be to ignore managing the job's config string when the parameter is set.


feat: Add list prefix support

This PR closes https://github.com/apache/incubator-opendal/issues/3247

Thanks for the efforts❤


Use u32 to represent variant tags.

This makes it possible to exchange binary serialized structures between
different architectures, and reduces bandwidth.  I doubt it's even
possible to have more than 4 billions variants anyway :).

Right now my code works between architectures because self.read_uint() and self.emit_uint() are producing u64 on both x86 and x86-64.  However, I do buy your argument that 32-bits are more than enough.  I'll merge this when I figure out what is happening  with the Travis-CI build.

Actually, what about forcing emit_uint() to fit in a u32 instead of a u64?  I'll need to bump the version number because it is a breaking change, but it will make it so that once a message is encoded somewhere, it can be decoded anywhere.

I hadn't noticed that you use write_be_u64 for uint.  I think that's a bad idea, I would use write_uint and leave the responsibility to the user -- code that works with machine dependent types are always going to have different semantics on different machines.
On the other hand, I think that forcing uint to u32 is an even worse idea, because it's unexpected and without any good reason.
The build might be failing because you're depending on an outdated rustc-serialize.

The thing is that uint shows up a lot in rust data structures like Vec and HashMap, so it's not really their fault.  I could do the checking on the deserialization side as an alternative.  If it tries to deserialize a value that is to big to fit in a 32-bit uint, it could fail.

Also, yeah, the build was failing because I was using an old version of rustc-serialize and because rustc broke derive(RustcSerialize) unless you have a flag enabled.

Mhm, right, I guess serializing uint in a machine dependent way could be problematic if a lot of established data structures use it.  In any case, I think falling back to u64 is a better choice, if we have to fall back to something.  I just checked and the cereal and binary Haskell libraries do the same.
What's certain is that encoding variant tags to u32 is a win :).

Thanks for the pull request, I've thought about it for a bit and decided to merge!


Action patch hof field

Summary
Fix for validation issue which keeps breaking the Twitter bot. Please make sure your PRs pass the validate-json action. If it doesn't, the PR should not be accepted.
Your Twitter handle (Optional):
@sml555_

Thanks @prodigysml!


feat: add textarea component

This pullrequest adds the textarea component to the design system.

Hi @claudio-OST, thank you for the feedback. I have included also changes for the input intentionally, because the border behavior there had the same issue as the on textarea. Please review it and get back to me if there are still any other open topics. Thanks!!


Decouple reconnect/delay errors from ICriticalContainerError

emitDelayInfo already wraps via ThrottingWarning.wrap, so that can take any
createReconnectError was just using CreateContainerError to safely parse message and stack (I checked telemetry that there are no different errorTypes coming through here that would have runtime impact, since errorType will now be one of the driver error types). Better to use wrapError.
reconnectOnError typing was relying on incidental overlap between IDriverErrorBase and ErrorBase.  Now its typing is more correct (IMO).

Part of this fix is related to #6488

FYI - I do not know if it changes anything, but I believe it was a mistake to go with current design.
Basically globals and global behaviors should be avoided, including such notifications. While there are some per container processes (connectivity to ordering service), the rest (like uploading an image) should communicate status more locally, to the caller of the API directly, through some means (like callback).
So I think emitDelayInfo() flow should be eventually redone by removing central chocking point


Switch the DRBGs from AES128 to AES256

Does this change the strength?  NIST SP 800-90Ar1 claims in section 8.4 that:

Security_strength_of_output = min(output_length, DRBG_security_strength)

AES128 and ASE256 both have a 128 bit output length which limits the strength that can be claimed to 128 bits.
With the lack of any practical attack against either flavour of AES, I'd usually pick the faster algorithm.
Alternatively, allow the user to choose any 128 bit block cipher.

AES128 and AES256 both have a 128 bit output length which limits the strength that can be claimed to 128 bits.

The security strength is not limited by the block length, it depends on the size of the internal key. If the former would be the case then having AES256 would not make sense in the first place. In 'Table 3: Definitions for the CTR_DRBG' on page 49 the security strengths for the CTR_DRBG are explicitely listed. So when you request 256 bits of random output, you will get two AES blocks, but the security strength of the output will be 128 for AES-CTR 128 and 256 for AES-CTR 256.

Apropos AES256: I would prefer if the title of the commit log would be more precise about that and say

Switch the DRBGs from AES-128-CTR to AES-256-CTR

following our conventions:
crypto/objects/obj_dat.h:1943:    {"AES-128-CTR", "aes-128-ctr", NID_aes_128_ctr},
crypto/objects/obj_dat.h:1944:    {"AES-192-CTR", "aes-192-ctr", NID_aes_192_ctr},
crypto/objects/obj_dat.h:1945:    {"AES-256-CTR", "aes-256-ctr", NID_aes_256_ctr},

I suspect this is another question during validation....  I know of a (validated) toolkit that does limit the strength to the block size.

And it would be nice if you would change the subject line as suggested to

Switch the DRBGs from AES-128-CTR to AES-256-CTR


Resume casuses problems on pause

When i pause (from alexa, sonos app or phisical button ) music from radio streaming and sonos is no longer playing it, in the resume phase of tts-ultimate I hear about 200ms of music.
I suppose this happens when queue is in pause and not empty (it happens almost always if you really use sonos system!).
The solution maybe to check at start the state (play/pause) and decide if trigger resume only if the was is play.

Hi Evazzoler
I never heard of this issue. This can be relatet do the speed of your system where node-red is running.
I cannot unfortunately change this behaviour, because the APIs from Sonos are undocumented and the only way to do the resume, is to resume and then to pause. Other than that, it's impossible to detect if a  streaming is a real stream, or a playlist in sort of streaming or so on. Every service (Apple Music, Spotify, Sonos Radio Station...) is different from each other and there is little to no documentation on that.
I suggest you to put the tts-ultimate volume to zero somehow, until resume has finished.Sorry.


Refactor exceptions

Right now it looks like...
my %errors =
    # Success
       0 => "",

    # Generic errors
    1000 => "INI - constructor failed", ...

We should probably make some attempt to automatize it, maybe generate X::Text::CSV::Ini names and then generate the message automatically. Refactoring the code, which looks like self!fail(%error<1000>) shouldn't be too difficult either.

This is a plain copy from Text::CSV_XS. If there is an easier way, I don't mind simplification. At least I think it should be easy to keep the two in sync as much as possible.

That might become eventually impossible... But if we can automatically
convert it, I guess we could do it again...
El mar., 31 dic. 2019 a las 16:53, H.Merijn Brand<EMAIL_ADDRESS>escribió:

This is a plain copy from Text::CSV_XS. If there is an easier way, I don't
mind simplification. At least I think it should be easy to keep the two in
sync as much as possible.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Tux/CSV/issues/23?email_source=notifications&email_token=AAAAD5B7FQYVVOZPYIDXX6DQ3NTGBA5CNFSM4KBUYKZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH4LYNI#issuecomment-569949237,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAAD5D533ET3GOXOOBZ4J3Q3NTGBANCNFSM4KBUYKZA
.

--
JJ

Also, usually exceptions use the X:: namespace; right now they don't even look like exceptions, using the name `CSV::Diag'


Support RESTEasy 3.x

Please answer these questions before submitting pull request

Why submit this pull request?
[ ] Bug fix
[x] New feature provided
[ ] Improve performance

New feature or improvement

Plugin support RESTEasy 3.x, includes RESTEasy server sync HTTP request and async HTTP request tracking.

Please submit the integration test cases. Do you know where to submit!

Please submit the integration test cases. Do you know where to submit!

Yes, I'm trying.

CI fails, please do rat:check.

@ascrutae @IanCao Please review the pull request and test case.

Coverage increased (+0.1%) to 16.548% when pulling 2803cd9101214d48ae2160e46dc815e4f660fed0 on yanfch:feature/RESTEasy-plugin into e07172b84f861190e18d945fcac2d8063fa51a5a on apache:master.

Coverage increased (+0.1%) to 16.548% when pulling 2803cd9101214d48ae2160e46dc815e4f660fed0 on yanfch:feature/RESTEasy-plugin into e07172b84f861190e18d945fcac2d8063fa51a5a on apache:master.

Please resolve the conflict, the shardingsphere plugin just got merged.

@yanfch Is this ready for further tests and review?

@yanfch Is this ready for further tests and review?

Ready.

@IanCao please review and run tests

inline

Test passed. @IanCao @ascrutae do code review again before merge, please.

RESTEasy doesn't have a clear icon at https://resteasy.github.io/.
@yanfch What is current status of topology when RESTEasy works as server?
@TinyAllen What do you suggest?

LGTM

RESTEasy doesn't have a clear icon at https://resteasy.github.io/.

@wu-sheng There should be here icon.
http://design.jboss.org/resteasy/index.htm

@yanfch Then you need a pull request to https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets
There are too many words in the official logo, @TinyAllen provides one,
, or you could build one and show us the topology screenshot.

Do we need recheck on 3.5.1? It is acceptable with one version failure. Also, support list document needs to update.

Try again?  Local is the test passed. There is no such exception IllegalDataFileException actualData.yaml

@yanfch If this icon makes sense to you, submit the pull request. Otherwise, create a new one if you like :) I am not familiar with RESTEasy, so can't tell it is good or bad.

I think this is good.


Refactoring SketchNodes to PBDL

In the input phase of the system, there are classes that are only for Sketch Files (e.g., SketchNode and Artboard). These classes are highly coupled with some of the services in the optimization phase.
There should be a higher level of abstraction for the design files, instead of what there is right now. This ease the process for supporting other design files and not just Sketch. This set of classes are called PBDL. They are a set of classes the puts together the similarities of design files, enabling the intake of multiple design files into Parabeac Core.

#18


Group Tasks don't respect onlyForStage() and onlyOn() settings

Q
A

Issue Type
Bug

Deployer Version
master

Local Machine OS
Ubuntu 14.04

Remote Machine OS
N/A

Description
If you define a group task and want to limit its execution to an explicit stage then the onlyForStage() setting doesn't have any effect and all subtasks are executed on each stage.
Steps to reproduce
In the example below the task send-team-message is executed on each stage because it is
a group task that encapsulate the deploy:slack task. The deploy:slack itself doesn't have a onlyForStage() restriction.
The only workaround for this misbehaviour is to define the constraint for the subtask directly:
$deployer->tasks->get('deploy:slack')->onlyForStage(['stage']);

Content of deploy.php
task('send-team-message',[
   'deploy:slack'])->onlyForStage('production');

task('deploy', [
    'deploy:prepare',
    'deploy:release',
    'rsync:warmup',
    'rsync',
    'deploy:vendors',
    'deploy:shared',
    'compare_database',
    'clear_cache',
    'create_news',
    'deploy:symlink',
    'cleanup',
    'send-team-message'
])->desc('Deploying Project');

👍  Yeah, would love to see this changed / fixed, too

But what to do in this situation?
task('send-team-message', [
   'deploy:slack'])->onlyForStage('production');

task('send-another-message', [
   'deploy:slack'])->onlyForStage('beta');

task('deploy', [
    'send-team-message',
    'send-another-message'
])->desc('Deploying Project');

Try to fix it in 4.x release.

In your example I would expect that deploy:slack is run on

beta - via send-team-message group-task - when I trigger deploy beta
and production - via send-another-message group-task - when I trigger deploy production

Also higher level definitions should overwrite lower ones. So in the case of
task('send-team-message', [
   'deploy:slack'])->onlyForStage('production');

task('deploy', [
    'send-team-message',
])->onlyForStage('beta')->desc('Deploying Project');

beta would overwrite production. Or what do you think?

I think we can use some sort of lazy algorithm.
deploy (filter: beta)
|_ send-team-message (filter: production)
   |_ deploy:slack (no filter)

In this case deploy:slack will never be executed.

It was difficult, but i made it!


fix: allow ipv4 address in video widget

Description
Expands the Video Widget url field's regex to support ipv4 addresses.
The regex expects:

protocol
auth
hostname or ip (required, all other portions optional)
port
path/params

PR fixes following issue(s)
Fixes #25386
Media
https://github.com/appsmithorg/appsmith/assets/12687723/ce216b40-c377-4432-a69e-7697ab273c7f
Type of change

Bug fix (non-breaking change which fixes an issue)

Testing
How Has This Been Tested?
Tested a variety of valid URLs in an online regex editor to confirm they all continue to work. Also verified malformed strings fail.

[X] Manual

Test Plan
New contributor, not sure what to put here.
Issues raised during DP testing
N/A
Checklist:
Dev activity

[X] My code follows the style guidelines of this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

Bug Fixes

Improved the video URL validation in the Video Widget to support a wider range of formats and IP addresses.

Would appreciate a review of this PR.

@patrickdemers6 did not see this earlier, can you please update this PR with the latest release branch?

/build-deploy-preview

/ok-to-test<EMAIL_ADDRESS>

@jnikhila do we need the documentation updated here?

@jnikhila do we need the documentation updated here?

@harshilp24

@jnikhila do we need the documentation updated here?

@harshilp24

I'll update the Video reference doc

I have tested this on the deploy preview, working fine.
Change LGTM

@sbalaji1192 some related tests have failed. Can you help the author?

/ok-to-test<EMAIL_ADDRESS>

Struggling to get local environment setup right to get those failing tests to execute. I will work on it today/tomorrow and join Discord to ask questions as applicable.

@patrickdemers6 before that, please merge the latest release here and let us know.
Maybe something that we have changed on our as well.

@patrickdemers6 Let me know if you need help in merging this changes to release.

@sbalaji1192 thanks for the bump. I rebased with release.
I figured out the tests were failing due to updated regex not including subdomains. appsmith.com was passing but assets.appsmith.com was not. Added the missing \. to the regex.

/ok-to-test<EMAIL_ADDRESS>

@patrickdemers6 I have triggered the tests. Lets wait for the results.

@patrickdemers6 We have merged your changes to the release. Thanks for working on this!
Feel free to go through our open issues.:)


Plugin Refactor

This is the refactor to convert Babylon Native to relying on plugins as its preeminent variety of component. This change is intended to improve scalability by "flattening" the structure of the repository, moving certain responsibilities outside the library and allowing a looser coupling of components. This change is by no means finished; but with the build system working and the apps of the four primary Windows builds confirmed to run, it is now at least ready to be looked at (and, if desired, downloaded and tried).

Not much to say on the implementation. I'm focusing more on the architecture.

"BabylonNativeUtils" folder : try to avoid too generic terms for 'utils' (like 'data'). For some LoL : https://twitter.com/skaven_/status/1126645815332593664 I'd go for 'helper'
ScriptLoader is not a plugin but a helper. In the sense it doesn't extend the JS engine -> move it to dependencies/BabylonNativeUtils ?
2 files named NativeEngine.h this is dangerous and can lead to hours of cmake debugging because of order of include paths
can the jsruntime be a plugin? it looks logical to me to have a ChakraRuntime/v8runtime/... and I'd like to do tests with other JS engine more optimized for binary size
Scriptloader has a static depedency on the network utils. So, I'm a bit lost here. I believed the Scriptloader would depend on a plugin that would correspond to my platform (asset loader + curl on Android, UIKit on mac/ios, ...). Imagine a customer that doesn't want http requests but the scriptloader.
at first I was a bit scared by things like this:

        runtime->Dispatch([width, height](Napi::Env env)
        {
            auto& window = Babylon::NativeWindow::GetFromJavaScript(env);
            window.Resize(static_cast<size_t>(width), static_cast<size_t>(height));
        });

basically, we just ask here to do a resize that, functionaly speaking is that:
runtime->resize(width, height);

Same for plugin registration. As this will only be maintained by us and experienced c++ programers (most users will only use prebuilt packages) I don't think it's an issue. But the syntax looks like over engineering IMHO. The dispatch is a needed mecanism under the hood but exposing it to users who want to integrate it in their app is overkill.


fix: improve resilience and error handling

ℹ Overview

adds missing status code handlers
add wait period after error

📝 Related Issues

✅ Acceptance:

[ ] Pre-commit checks pass

nits and then LGTM


Benchmark of Scaling Very High Throughput Workload

Basic set/get/delete benchmarks are implemented for the key-value store, including similar benchmarks for raw SQL queries over protobuf. I did this rather than executing the queries directly as it is more representative of what a real-world situation is without BuffDB. That is to say that the client wouldn't be executing the queries themself, but rather send the queries to a server to be executed.
Overall BuffDB appears to have minimal overhead compared to raw query execution. The benchmarks fluctuate a lot (~30% run-to-run on occasion), so it's difficult to determine an exact amount. I am confident, however, that the overhead compared to direct query execution is in establishing and handling the gRPC connection, not processing the queries themself.

Could you make table? Also, I think multiple streams without you could be interesting.


Ignore sbol objects that can't be parsed to GenBank objects

This solves #164
Changes:

[Refactor] Removed some redundant test file paths defined in the main conversion file.
Created a dictionary to keep logs of each top-level object and mark them as being parsed / not parsed during the conversion process.
The dict returns the logs as well as the list of SeqRecords, nested in an outer dict.
Modified the convert_to_genbank method of sbol3_utilities/conversion.py for recognizing the change in return value.

TODO:

@jakebeal @tcmitchell Here, I have implemented the basic idea discussed in #164, I am not sure if this needs refinement, and also how we are to write unit tests for it.

Could you write a test that passes a combination of objects in to the converter where at least one object is converted (result dict says True), and at least on object is not converted (result dict says False). Then check those results against the expectation that object A is converted and object B is not converted.
I don't know if that's possible. If not, we can think of other ways to test it. I think we should definitely have a test to verify that objects are properly either converted or not converted, and that the result dictionary accurately informs the caller about the status of each object.

Could you write a test that passes a combination of objects in to the converter where at least one object is converted (result dict says True), and at least on object is not converted (result dict says False). Then check those results against the expectation that object A is converted and object B is not converted.

@tcmitchell  I have added a unit test to do the above stated. I added a test file with the standard component/sequences objects, along with an Attachment top-level object in the sbol3 file, which should return its conversion status as false.