how can i use ContextBlock?

how can i use ContextBlock?
is there a config.py like detecron which explans all parameters  can be modified

You can find the config files under configs/gcnet.

thanks～


Fix TVX-351 - double iq result for mix-mam queries

We return the response to the caller, who routes it for us, no need to route the response ourselves.

As discussed probably need to address the testing.

This looks like travis timeout failures rather than actual errors? Mergeable @garethf?


updates for commercial support - request from Product Management

updates for commercial support, this request came from product management

There is no change in this pull request. Do you have pending local changes that you didn't push yet?

Changes are on production:

https://www.rabbitmq.com/release-information
https://www.rabbitmq.com/contact

Looks like I did it 2 weeks ago: https://github.com/rabbitmq/rabbitmq-website/pull/1872/commits/7c9a69e649c67e20401d3b9fc7c1c93c1f6b6d35
I will close this PR now.


geojson rendering distorted on some Mac devices

Description

Some geojson objects are distorted on Mac devices
Repro Steps

I have tested on different computers and iPhone. On some devices, some objects were distorted heavily regardless the browser type. I tried Safari/Chrome/Firefox on these devices and all of them had problem. So I guess it is a precision error related to GPU.

Distorted one:

Correct one:

map.zip
Environment (please complete the following information):

Framework Version: [deck.gl 8.0.6]
Browser Version: [Chrome 80.0 64bit, Safari 13.0.4, Firefox 72.0.2]
OS: [Mac OS X 10.15.2, iOS 13.3]
Device type: [MacBook Air 2017 (GPU: Intel HD Graphics 6000 1536 MB), MacBook Pro early 2015(GPU: Intel HD Graphics 6100 1536 MB), iPhone 11]

Thanks for reporting. Looks like these devices are not reading the fp64 low part of the attributes correctly.
While we work on this, it's worth noting that there is still a limitation to the default precision that deck.gl provides. We use two 32-bit floats in the vertex shader to simulate a "double", which gets us roughly 23 * 2 = 46 bit of precision instead of the 52 bit from a real 64-bit float. On low-end GPUs, there is expected to be even more loss while doing arithmetic calculations with these numbers.
Your geometries are extremely small. At this scale, any precision issue on a low-end GPU becomes very prominent. For consistent results, I recommend pre-processing your geometries to use the LNGLAT_OFFSETS mode. Lnglat offsets can be much better presented by 32-bit floats. For reference, when the absolute values of the coordinates are smaller than 0.1 degrees, the max error is about 1e-8 degrees ~ 1mm. When the absolute values of the coordinates are around 170, like in your dataset, the max error is about 1.5e-5 ~ 1.5m.
function transformGeometry(geom, transformPoint) {
  if (Number.isFinite(geom[0])) {
    return transformPoint(geom);
  }
  return geom.map(p => transformGeometry(p, origin));
}

function processFeatures(features, processPoint) {
  return features.map(feature => ({
    ...feature,
    geometry: {
      type: feature.geometry.type,
      coordinates: transformGeometry(feature.geometry.coordinates, process)
    }
  }));
}

// Usually the center of the bounding box
const coordinateOrigin = [116.3203, 39.8619];

new GeoJsonLayer({
  id: 'lnglat-offset',
  data: processFeatures(data.features, p => [p[0] - coordinateOrigin[0], p[1] - coordinateOrigin[1]],
  coordinateSystem: deck.COORDINATE_SYSTEM.LNGLAT_OFFSETS,
  coordinateOrigin,
  ...
})

Thanks for the temporary solution and your explanation. It works as expected. Hope your can fix the errors on low-end machines and mobile devices. I will close this.

@Insane-neal Can you try 8.1.0-alpha.3?

@Pessimistress I'll try that now. Meanwhile, We found not only the geojson layer was distorted, but also the selection of it. On these devices, the selection of geojson objects by mouse clicking worked randomly. Was it caused by the same rounding error issue?

@Pessimistress We had a similar issue and 8.1.0-alpha.3 solved it. Thanks!

@Pessimistress The 8.1.0-alpha.3 version solved our problem too. Thanks!

The fix has been ported to 8.0.15.

@Pessimistress FYI. the problem re-appeared recently on Safari mobile with the release of iOS 17, even with the latest version of deck.gl and a recent iPhone.


Standalone bundle question

Hello.
I'm trying to bundle static depentencies for my project with following config
system.config.js
System.config({
  baseURL: ".",
  map: {
    jquery: 'bower_components/jquery/dist/jquery.js',
    angular: 'bower_components/angular/angular.js',
    lodash: 'bower_components/lodash/lodash.js',
  },
  meta: {
    jquery: {
      format: 'global',
      exports: 'jQuery',
    },
    angular: {
      format: 'global',
      exports: 'angular',
      deps: ['jquery'] // using full-cut jQuery insted of jqLite
    },
    lodash: {
      format: 'global',
      exports: '_',
    },
  }
});

to use in following head tag
  <!-- bundle I want to have -->
  <script src="build/app.vendor.js"></script>
  <script src="system.src.js"></script>
  <script src="system.config.js"></script>

  <!-- TypeScript 1.8 generated concatenated output for SystemJS -->
  <script src="build/app.bundle.js"></script>

  <script>
    // I used this trick to load run TypeScript bundled modules for angular App.
    for (var moduleName in System.defined) {
      System.import(moduleName);
    }
  </script>

I've used bower, but it does not metter in this case.
I want to compile dependencies without refering to any module which might requires them. Some kind of standalone third-party bundle.
I wouldn't like to make file like
  System.import('jquery');
  System.import('angular');
  System.import('lodash');

to enforce including all of my dependecies.
Could anyone guide me to rigth way to get this or show me any trick.

There is no shortcut to do this. If you're using a proper dependency declarations in all files, and never referencing globals, there should be no need to artificially enforce execution.


New Descent Scenario: City of the Dead

I have finally been able to finish a new descent scenario. It's a single encounter.
https://github.com/Quantumrunner/ValkyrieCityOfTheDead
Could you please add it to the mission list?
Just as the shadow rune campaign it will get some minor changes (undead tags) if the a valkyrie update will be released someday.
I'll add more infos on BoardGameGeek as soon as the scenario is available in Valkyrie.

I'll get this added shortly

Looks good thank you.


Question about FID score

Hi! Thank you for the awesome work and providing codes.
I have a somewhat simple question about measuring FID score on FFHQ 256x256.
Which one of the two processes below do you recommend to get a great FID score on FFHQ 256x256?

Generate 1024x1024 resolution images and resize them to 256x256 and calculate the resized 256x256 fake images on FID score.

Thank you!

Thank you for the answer.
Can I ask you one more simple question?
As you mentioned in the README.md, I converted "original" dataset to "lmdb" dataset and trained the model.
To calculate FID score, I extracted features from fake images generated from "lmdb" dataset.
But when it comes to extract features from real images, is it okay to extract features  from "original" dataset (not "lmdb" dataset) and calculate FID score?

Resolved


servicerouter: Allow disabling SSL frontend?

servicerouter.py automatically writes an SSL frontend to haproxy.cfg. It would be nice if this could be disabled via the command line.

Thanks for the suggestion, I moved it to our backlog.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-3358. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.

Note: This issue has been migrated to https://jira.mesosphere.com/browse/MARATHON-3358. For more information see https://groups.google.com/forum/#!topic/marathon-framework/khtvf-ifnp8.


const files = [...extracted.files] Hangs Entire Application

Hello, for some reason, when I run the command const files = [...extracted.files] it hangs my entire application. I have an app that downloads files, then is trying to unrar it. The files are only ~400mb, but, the whole app hangs on this line for ~5 seconds. Shows Not Responding on windows and the beachball on mac.
It is highly possible I am doing something wrong either in my node app or with this package. Any ideas on how to do this without hanging the rest of the application?
Thank you for your time.

It's normal for nodejs to take 5 seconds to extract 400mb rar file. Sorry but it's almost impossible to make this library asynchronized since async call to wasm library is super complicated in this case.
Please try to use worker thread in nodejs to put the extraction in another thread so the main thread will not be blocked. I didn't tried it but it should works.

Thank you!! It did work, but I ended up using a webworker instead of the worker thread (electron app). Appreciate it and thank you for making this!!


Cherrypick for relase/0.15 - PLUGIN-498

PR: https://github.com/data-integrations/google-cloud/pull/462
JIRA Ticket:  https://cdap.atlassian.net/browse/PLUGIN-498

/gcbrun

/gcbrun


relax dependencies

The latest cropperjs version is 1.1.3 with some bug fixes from 1.0.0-rc3: https://github.com/fengyuanchen/cropperjs/releases

The latest is v1.3.4 now !

Is this project dead?

@roadmanfong ping

@roadmanfong The outdated dependency of cropperjs breaks modern transpilers like babel-loader. Please consider maintaining your library or opening it up to other contributors.

updated


Get tools/nui working with public API -- $100 bounty

Right now it's internal API only. It's so much nicer than unlogger when it works!
If you are at the hackathon and solve this, I'll hand you a crisp blueface.

Seems like this needs to be done with raw driving data from the comma api. The problem is that the api always returns error 403 "Forbidden. Authenticated user lacks access to desired entity.". I tried other requests with the same JWT token, but this raw driving data request never works. Could it be possible that the user needs to be "superuser" for this ?


contribution: add checks on commits

We should ensure in PRS in an automated way:

commit follow the conventional changelog
pull request is done on develop

Maybe look at how jsdelivr handles it, they have good and fast checks

Number of times this led to a "bad" merge: 1

What about adding checks on the jsdoc as well? Checking that we have jsdoc on all our widgets and that it matches the arguments. I think ESLint have rules for that through a plugin, or maybe try jsdoced

I think ESLint have rules for that through a plugin

Yes we could start with an ESLINT check


feat: add onConnectChange props to ConnectButton

Problem

cannot trigger custom function when wallet connected or disconnected

Solution

add onConnectChange as props to ConnectButton

Usage
When wallet connects.
<ConnectButton
  onConnectChange={({ isConnected, data }) => {
    isConnected && console.log('gm!');
  }}
/>

When wallet disconnects.
<ConnectButton
  onConnectChange={({ isConnected, data }) => {
    !isConnected && console.log('gn!');
  }}
/>

More info
Type of params from onConnectChange callback is ConnectionInfo
type ConnectionInfo = {
  isConnected: boolean;
  data?: ConnectorData | undefined;
};

// Imported from wagmi
type ConnectorData<Provider = any> = {
    account?: string;
    chain?: {
        id: number;
        unsupported: boolean;
    };
    provider?: Provider;
};

The params from the callback like data can also be useful in cases such as logging analytics. Thanks @peduarte for this feedback.

@samyouxyz thanks for the PR! This is a cool concept, I can see how it would be useful.
Could the same thing be achieved by watching for changes in useAccount's account or useConnect's active connector?

@samyouxyz thanks for the PR! This is a cool concept, I can see how it would be useful.
Could the same thing be achieved by watching for changes in useAccount's account or useConnect's active connector?

@nickbytes thanks for the comment!
Actually, using useAccount with useEffect to watch the change was my first attempt to achieve this. But I hit a use case where depending on state changes becomes unpredictable and doesn't cover all situations (e.g. local state change vs. hitting refresh and init state from nth creating state flickering). Let me know if I am not clear on this point! 😬
so 1 popular use case might be sth similar to sign-in with ethereum:

user click connect wallet
trigger a popup for user to create signature with metamask
send that signature to backend api to login
if success, keep the wallet connected. Otherwise, disconnect the wallet.

To my knowledge, SIWE is possibly on the roadmap. But I just think this would be helpful for other use cases beside this one as well! if there is a better way to do this, please let me know. 😄

thx @samyouxyz for creating this. it is so much better than trying to mess around with wagmi's hooks. tbh I didn't know what wagmi was before using RainbowKit and thought it was weird I had to integrate with one of the 3rd party dependencies to do this basic functionality of the connection flow. And if one day, wagmi goes away, would be annoying to get everyone to migrate instead of abstracting it away like this.

we're considering this internally already, but I wanna drop some feedback.
i've been building a few side projects with rainbowkit recently to get a better feel for it as a user. it also helps me understand parts of the DX that can be improved. i'm starting to think this callback could come in handy.
it's true that we can always check the status of the connections via wagmi's useAccount/useConnect hooks. But:

Hooks don't re-render, so in order to conditionally render things based on connection, we still need to have a useEffect and set an internal state, based on the hook's data
It means, for many users, a slightly steeper learning curve, if all users want to do is check if there's a wallet connected to change something in their app. I imagine most users could do fun things with this, without going too deep into web3. Eg: interacting with contract, making transactions, signing messages, etc.

@samyouxyz i've been thinking about the API for a bit, and I was wondering about two things:

expose a bit more information to the user, beyond a connected boolean. eg: the wallet used for the connection (@markdalgleish brought up that these callbacks could be useful for analytics, and I agree, so knowing which wallet was used could be helpful to track certain events)
follow the react's "change" event convention, so instead of two independent callbacks, it'd be onConnectChange

function App() {
  const [connected, setConnected] = React.useState(false);

  return (
    <RainbowKitProvider onConnectChange={({ isConnected, data }) => setConnected(isConnected)}>
      {connected &&
Enter the metaverse...
}
      {!connected && <ConnectButton />}
    </RainbowKitProvider>
  );
}

I'm thinking that onConnectChange would return the following object (following the same convention as wagmi's useConnect hook):
{
  isConnected: boolean;
  data?: {
    address: string;
    chain: {
      id: number;
      unsupported: boolean
    }
  }
}

hey @peduarte. that's a very great feedback! I just got time to work on the improvement. Let me know what you think.

This is beautiful 😍. How soon can we get this merged.
Is there anything left to get it across the line

@jxom @markdalgleish beeping you guys on this one.

the onConnectChange prop is currently on the ConnectButton itself. I was thinking maybe it should be on RainbowKitProvider instead, as typically there will only be one provider but there could be many connect buttons

the onConnectChange prop is currently on the ConnectButton itself. I was thinking maybe it should be on RainbowKitProvider instead, as typically there will only be one provider but there could be many connect buttons

@peduarte You may want different effects to run on different buttons though right?
For example, if you have a part of your application where when the user connects they have to verify their wallet and other parts where you don't need them to verify

@peterferguson im not sure tbh. typically, a user will connect/disconnect once, and regardless where they connected from, you'll probably want to run the same side effect

if you have a part of your application where when the user connects they have to verify their wallet and other parts where you don't need them to verify

i think this usually happens on user actions, not connection. if you want to do an actual "sign in" instead of "wallet connection" you'll want to sign a message regardless which button they clicked on

@peduarte this would be problematic for us.
Our platform issues certificates and credentials to users on one hand
To claim

User connects their wallet arbitrarily to validate they own the wallet address.

To create

User connects wallet and SIWE, where we also persist a session

When they both disconnect, the cleanup is different.
One needs a clear cache, the other just disconnects like a regular user.
Unlike traditional authentication mechanisms, <Connect /> in Web3 isn't the same.
the approach you propose would require us to wrap RainbowKit provider anywhere that isn't the App.ts | _app.tsx` and move it to LayoutProvider, which doesn't sound like that much of a crime.
However I believe it's called onConnectChange for a reason

My main concern is that having onConnectChange on the ConnectButton gives the false intent that they will be fired whenever there is a disconnect from anywhere. Nothing that couldn't be solved via docs, though.
@koolamusic im really curious to understand a bit more about your use case, so we can ensure we're providing the right API for our users <3  I get it that to claim and to create are different. Like, on OpenSea, for example, you can connect your wallet and see your NFTs, but in order to favourite an NFT, you gotta sign a message. Still, there is only ever one global connection entry point. So I dont get "When they both disconnect". Could you help me understand a bit more? In my mind having on global onConnectChange is cleaner, and would allow you to do different clean ups if you need
Thanks

Yeah, I totally get that documentation can help fix this ofc.
For my intending use-case One user has a session persisted in browser cookies when they SIWE. The other user completely relies on the default mechanism provided by RBK which I believe is something with localstorage x wagmi etc.

My main concern is that having onConnectChange on the ConnectButton gives the false intent that they will be fired whenever there is a disconnect from anywhere. Nothing that couldn't be solved via docs, though.
@koolamusic im really curious to understand a bit more about your use case, so we can ensure we're providing the right API for our users <3 I get it that to claim and to create are different. Like, on OpenSea, for example, you can connect your wallet and see your NFTs, but in order to favourite an NFT, you gotta sign a message. Still, there is only ever one global connection entry point. So I dont get "When they both disconnect". Could you help me understand a bit more? In my mind having on global onConnectChange is cleaner, and would allow you to do different clean ups if you need
Thanks

Could you help me understand a bit more? In my mind having on global onConnectChange is cleaner, and would allow you to do different clean ups if you need

Yeah, I totally get that documentation can help fix this ofc.
For my intending use-case One user has a session persisted in browser cookies when they SIWE. The other user completely relies on the default mechanism provided by RBK which I believe is something with localstorage x wagmi etc.

Could you help me understand a bit more? In my mind having on global onConnectChange is cleaner, and would allow you to do different clean ups if you need

Yeah, I totally get that documentation can help fix this ofc.
For my intending use-case One user has a session persisted in browser cookies when they SIWE. The other user completely relies on the default mechanism provided by RBK which I believe is something with localstorage x wagmi etc.
I think leaving it within ConnectButton is the best way to go about it, as it takes a very functional approach to handling connection hooks.
Another example could be with analytics, where a developer might want to add additional metadata for users who connect or disconnect from a certain location in the app.

Please merge this! Totally need this.

hey frens, sorry this is taking a bit longer than expected. we've just been chatting with the wagmi core team as well to make sure that

we definitely need this API, or it's something that its better to be done wagmi's side
if we do add it, it's inline with their API, as it seems that there will be some changes in the useConnect/useAccount hooks

but i don't believe this PR should be blocking anyone, as it's currently possible to check whether a user's connected via wagmi's useConnect hook
if someone's feeling blocked by this, please let me know your use case, ideally with a reproduction sandbox
thank you!

wagmi is working on a “global status changes” to connection state. this will likely be added to the useAccount hook — you can see the draft pr here
with this change, you'll be able to get a callback whenever the connection status changes. this is a lot more accurate than relying on isConnected or account.address. this callback will be called when a connection is successful regardless of which button it came from
i think we should wait for this change, instead of adding new API to rainbowkit. we're trying to keep the API layer as slim as possible, and trying to avoid overlaps between rainbowkit and wagmi. if we think that's not enough we can re-open the discussion and work towards a different solution
how do you all feel about this?

i think we should wait for this change, instead of adding new API to rainbowkit. we're trying to keep the API layer as slim as possible, and trying to avoid overlaps between rainbowkit and wagmi. if we think that's not enough we can re-open the discussion and work towards a different solution

🫡 I like it sir. Agree that we should avoid overlaps in functionality + really like the latest wagmi changes.

wagmi is working on a “global status changes” to connection state. this will likely be added to the useAccount hook — you can see the draft pr here
with this change, you'll be able to get a callback whenever the connection status changes. this is a lot more accurate than relying on isConnected or account.address. this callback will be called when a connection is successful regardless of which button it came from
i think we should wait for this change, instead of adding new API to rainbowkit. we're trying to keep the API layer as slim as possible, and trying to avoid overlaps between rainbowkit and wagmi. if we think that's not enough we can re-open the discussion and work towards a different solution
how do you all feel about this?

really appreciated for the follow up! guess we have to wait for the new big change. closing for now!

super hot spicy alpha of what this is gonna look like in wagmi:
https://wagmi-hwz63ehib-zoo.vercel.app/docs/hooks/useAccount#onconnected-optional

super hot spicy alpha of what this is gonna look like in wagmi:
https://wagmi-hwz63ehib-zoo.vercel.app/docs/hooks/useAccount#onconnected-optional

this is out now in<EMAIL_ADDRESS>get it while its hot 🥵
https://wagmi.sh/docs/hooks/useAccount#onconnect-optional

Thanks for the hard work on this

onConnect doesn't fire most of the time. See https://github.com/wagmi-dev/wagmi/issues/777
Not sure if it is an issue with rainbowkit or wagmi

I came across the same issue where I need a disconnect callback, you can simply use useAccount() hook:
const {isDisconnected } = useAccount();

But in my case, I needed this flag outside the component, and of course, I can't use the hook outside the function. For this, I just persist the state in browser storage (local storage). Whenever the page reloads it checks is account already disconnected or not.
const {isDisconnected } = useAccount();

 useEffect(() => {
    if (isDisconnected) {
      localStorage.setItem("__DISCONNECTED__", "true");
    }
  }, [isDisconnected]);


⚠ ClamAV has degraded performance

In 84b1808, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 54 ms

Resolved: ClamAV performance has improved in eae41e5.


Update SeLion document with mobile platform, common interface for and…

Documentation for #265 (common interface for android and ios)

Thanks for seeding this change @alizelzele
All-in-all, I feel this PR is going to take a bit more work. I feel having three sections (1) for mobile app, (2) for android, (3) for iOS is going to be very confusing to a newcomer. Perhaps we should revise, edit, and/or remove existing documentation to support this change rather than adding entire new sections.

@mach6 I corrected typo and grammatical problems, will revise my commit to create better docs.

@mach6 Sorry for late response. I updated the docs, can you please take a look at it.

merged


snmplabs.com site now points to malicious site

The message in the README

This is no longer the case as the snmplabs.com site is now defunct

The domain has been taken over and is used to deliver a malware message attempting to confuse users into falling for a scam.
Recommend removing any reference to snmplabs.com completely from all files.

This has been well known, as Ilya didn't pass on the domain to anyone in the community and it lost to the wrong hands.
You can switch to pysnmp.com instead, but too difficult to fix the references in all existing forks.


Group unit tests in test suites #152

[x] Running yarn lint does not trigger any linter warnings
[ ] The test of the method you have fixed is passing
[ ] You have written a new skeleton method for someone else to work on!

@damjanh Thanks a lot for your work!


docker and travis integration

docker and travis integration

Changes Unknown when pulling 8ba3a5ac1d62a71b16470ab0131deafcb1af180c on docker into ** on master**.

Changes Unknown when pulling 26d6e989d3d41bc07285c1a2103944e2f3e0a1ee on docker into ** on master**.

Coverage decreased (-2.7%) to 51.351% when pulling 59a2c3adf6569ab3041f55dbe31c87939a42014c on docker into 82a76fa8b98c5d0ad6801b18adf152719690a69c on master.

Coverage remained the same at 54.054% when pulling 74fdf2e739f435324bb5e47c8b53d942da002615 on docker into 82a76fa8b98c5d0ad6801b18adf152719690a69c on master.

This PR is too large and should be split in separate ones


kragniz/cookiecutter-pypackage-minimal - relevant?

I don't think cookiecutter-pypackage-minimal is maintained anymore. Please reopen if this is not the case.


Fixing removeUnreachable not searching in all blocks

The method removeUnreachableBlocks was iterating through all the methods basic blocks but only keeping the last result found (in toRemove).
This will create an error later when the method checkForUnreachableBlocks is called.
Therefore, the fix is to use only one instance of the object toRemove and keep all the information there.

@Away-pp thanks!
I will try to review such approach and remove only real dead code on a very early stages before jadx do any changes to blocks tree.

I understand that there are other issues with unreachable blocks, but I think that maintaining this function is ok, not a big issue.
This commit was the first part to fix a specific decompilation problem (will make the pull request later).
 It just happens.
Thank you for the quick review.


Run CI on PHP 8 and Windows

With the increase in test coverage and the already decent coverage on the other components, it might be beneficial to additionally test on Windows.
Also with the release of PHP 8, it should be tested there.
While I do like Scrutinizer, the CI pipeline might be significantly simplified (and sped up?) if GitHub Actions is used. This might be worth looking into. Most functionality it provides can be replicated with common Composer packages and utilities.

Looks like #173 has shown that GitHub Actions is really, really slow. And it doesn't even reasonably do code analysis and coverage reports.


Check for changes in directory

I'm using deployer for a lot of Laravel web applications. I also build the front-end with npm ci; npm run prod. The problem with this is that it can take quite some time while most of the time, I did not change anything in the front-end code that needs to be builded.
So I found a solution for this, why not check for changes in specific folders and only build if there are any. This simple solution works perfectly.
It checks if there are changes in a specific folder based on the previous commit.
// Which folders to check if need to build front-end
set('asset_dirs', [
	'resource/assets'
]);

// Build assets
task('npm', function () {
	$should_build = false;
	foreach(get('asset_dirs') as $asset){
		if(exec('git diff --name-only HEAD~1..HEAD ' . $asset)){
			$should_build = true;
		}
	}
	if($should_build) {
		run( 'npm ci; npm run prod' );
	}
});

Would be a nice feature to include into the core so you don't have to add this code manually.

I will add there this addition there should be a general-purpose check enabled by default - if the last release uses the same commit as the one requested for deployment than skip updating (if not in forced mode)

I find this is really difficult to implement. If someone whats to implement in as contrib recipe - your are well come.

What makes this so difficult to implement? The way I see it, all that's needed is to add a property to tasks that contains the files to watch, and before each task is run, check all the listed files against the previous release. If none of them changed, skip the task.
e.g.
// src/Task/Task.php
<?php
namespace Deployer\Task;

class Task
{
   // An array of globs to check before running the task.
    public array $watch = [ '*' ];

    // ...
}

@sbrow Thanks for your comment and I think if you put all the configuration on the user, you are right. One needs to make sure, that files which are not on git are ignored for example.
I can only repeat Anton: Feel free to volunteer and implement it! Happy to review your PR and if you have questions feel free to ask!


Added consts for left and right outer/inner joins

Currently you have to pass string and manually specify the join type if it's not included in constants.

Names rearranged :) also I have removed those inners mentioned by @Pittiplatsch

Merged to develop for release in 2.4.


Gender selection is probably best avoided

The animals/robot can already be considered gender neutral, which is a positive thing. The issue with gender selection is:

An increasing amount of people openly don't associate with either gender, this may come across as discriminatory

The default gender is male which is a bit unfortunate in a male dominated sector

The animal is defined as female with a flower accessory, which is a gender stereotype that some may find offensive

Love the site, just flagging this in case anybody is offended or buildit's reputation is negatively affected.

Thanks for pointing it out, although so far I haven't received any negative feedback about this 'feature' I will keep this in mind.


Updates fixes branch to 3.0.2

Turns out I didn't need this PR.  I needed to update the composer.json to point to my fork.


It's not a bug, just a proposal

Hi!
It would be nice to have a ssh and https links to repo (like on github or bitbucket)

Oh, it's a duplicate.


how to define (human readeable) nested structures

Hello,
I have a struct looking like that
struct Trans
{
    double rot[4];
    double trans[3];
};

and thus
template <class Archive>
void save(Archive & ar, Trans t){
    ar(cereal::make_nvp("tx",t.trans[0]));
    ar(cereal::make_nvp("ty",t.trans[0]));
    ar(cereal::make_nvp("tz",t.trans[0]));
    ar(cereal::make_nvp("qw",t.rot[0]));
    ar(cereal::make_nvp("qx",t.rot[1]));
    ar(cereal::make_nvp("qy",t.rot[2]));
    ar(cereal::make_nvp("qz",t.rot[3]));

}

which, once serialized it looks like
		<transform>
			  <tx>0</tx>
			  <ty>0</ty>
			  <tz>0</tz>
			  <qx>0</qx>
			  <qy>0</qy>
			  <qz>-0</qz>
			 <qw>-1</qw>
		</transform>

is there any way to makes it look like this instead:
		<transform>
			<translation>
			  <tx>0</tx>
			  <ty>0</ty>
			  <tz>0</tz>
			</translation>
                        <orientation>
			  <qx>0</qx>
			  <qy>0</qy>
			  <qz>-0</qz>
			 <qw>-1</qw>
                        </orientation>
		</transform>

The most straightforward way to do this, which unfortunately might complicate your code, would be to make rotation and translation there own types, e.g.:
struct Rotation
{
  double qw, qx, qy, qz;
  template <class Archive> void save(Archive & ar) const
  {
    ...etc...
  }
};

This might complicate your code, however. We don't have a built in way to directly modify the generated XML, though you could hack the XML archive to do this.


Fix styling of sidebar in Firefox browser

Fix styling of sidebar in Firefox browser. The filter listboxes are truncated

fixed in v1.2.5


Date From - Format Mask

Hello Bartosz,
First of all i want to say that It is a very good plugin and i have been used in some of my projects. But now on thing which is i'm facing as per customer requirement that i'm not able to change date format of Date From field. Can you please guide me how can i change Date From format mask.
Thanks.

Hi Bartosz,
I apologies for my last issue as this issue was not related to plugin.
Thanks.


Error creating openshift project through launch.openshift.io

backend response is a 500 and frontend can't parse it as json:
<title>Error</title>Internal Server Error

Could somebody get the logs?

I think this is due to the fact that the "federated identities" haven't been setup. We might need a better way to indicate that ;)

Is this related ?
https://github.com/openshiftio/appdev-planning/issues/21

Should be fixed by openshiftio/appdev-planning#27.
But the JS errors should be tidied up here as well :)


use modulo based distributed hash join

as benchmarks shows that distributing the hash join using the modulo distribution approach is always faster, it will be used by default for all hash joins now.

@mfussenegger fixup pushed


Plug tempdir leak

Addresses:
https://github.com/GoogleCloudPlatform/google-cloud-python/pull/2847/files#r91715191

@tseaver it looks like you just invented a py.test fixture

@dhermes it's been around since a lot longer than our switch to py.test.

Ha, that's not what I meant, I just meant that's what (user-defined) fixtures usually look like
FYI, this fix doesn't work on Windows:
https://ci.appveyor.com/project/GoogleCloudPlatform/google-cloud-python/build/1.0.971.master/job/iij8tk8b3l3obob5


Reset version number upon rename

Currently every theme will have @since tags the same as our development versions. These should be cleaned up completly and replaced with @since 1.0.0.

I have removed all version numbering and reset all to 1.0.0
This is not a plugin or a project. It is a boilerplate so users should always get as cleaner start as possible.


Pin github action versions

Description of changes:
Pins all of our external github action dependencies to their current latest versions. The # 1.2.3 style comments are supported by dependabot.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Issacwww

The # 1.2.3 style comments are supported by dependabot.


No marketplace entries found to handle Execution

An error was reported when importing the project, how can I solve it?


Add hit-detection support for WebGL

This PR implements forEachFeatureAtPixel for WebGL. From the idea it uses the same technique as the canvas renderer: We have a 1x1px framebuffer in which we draw feature-by-feature (in reverse order) and check if there is some color.
Commit e01e556 uses an optimization, that should also be used for the canvas hit-detection: Using the new renderBuffer we build a box around the given position. And then we only check those features that intersect this box. This drastically improves the performance for WebGL.
Speaking about performance, canvas gives better results. I made some tests showing 1000, 5000, ... features on a map (zoomed-out so that really all features are shown). Then I measured the time to do a forEachFeatureAtPixel call.
# of features   Canvas    WebGL
1000            10 ms     20 - 80 ms
5000            35 ms     70 - 350 ms
10000           60 ms     140 - 650 ms
20000           120 ms    340 - 1400 ms
50000           320 ms    800 - 3000 ms

For WebGL I have given a range, because it depends on where you click with the optimization made in e01e556. If you click somewhere in the map where are no features, it's faster.
But still, for WebGL, it's too slow to run forEachFeatureAtPixel on mousemove. We came up with a hasFeatureAtPixel method, for which I will open a separate PR (here is already an example to give you an idea).

This looks very good to me. I just added two comments, one about an unused variable (groupEnd), and one suggesting to factor out some WebGL texture-related code.

One thing: we need to implement "skip feature", but I think this can be done as a separate PR.

This looks good to merge to me.
Any objections?

LGTM

+1

Thanks for the reviews!


Crash with partially bound texture arrays with variable descriptor count

If I have a texture array that has been sized 10, but I'm only providing 8 elements in a call to vkUpdateDescriptorSets(), it doesn't seem like the other elements in the array in MVKDescriptorSet get cleared out. This can cause a crash with deleted resources, since bindings for elements 8 and 9 will still try to get bound in MVKDescriptorSetLayoutBinding::bind. That function loops over the entire length of the variableDescriptorCount, and doesn't seem to account for partially bound sizes.
Happy to do a PR, just looking for confirmation my assumptions are correct.
I would think the solution is to call MVKImageDescriptor::reset() on every element of the array that isn't set in the Update. Is that correct?
Thanks

Thinking about this more. I think when a MVK resource is destroyed it needs to know all of the partially bound descriptors that reference it, and clears out those references. Otherwise dangling references to that resource can occur when converting the MVK state into Metal calls.
My test case only uses variable sized descriptors, but I'm thinking this crash would affect statically sized descriptors as well that are partially bound.

It works fine on Windows for all GPUs there. There are two crashes so far I've seen that show up.
Here is the call stack from the first crash. The mtlTexture passed into setFragmentTexture is invalid.
#0	0x00000001a23e5834 in objc_msgSend ()
#1	0x00000001a2fcd6e8 in -[MTLDebugRenderCommandEncoder setFragmentTexture:atIndex:] ()
#2	0x00000001187fe6f8 in MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int)::$_20::operator()(MVKCommandEncoder*, MVKMTLTextureBinding&) const at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandEncoderState.mm:1110
#3	0x00000001187fe6b0 in decltype(std::declval<MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int)::$_20&>()(std::declval<MVKCommandEncoder*>(), std::declval<MVKMTLTextureBinding&>())) std::__1::__invoke[abi:v15006]<MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int)::$_20&, MVKCommandEncoder*, MVKMTLTextureBinding&>(MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int)::$_20&, MVKCommandEncoder*&&, MVKMTLTextureBinding&) at /Applications/Xcode14.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/__functional/invoke.h:394
#4	0x00000001187fe654 in void std::__1::__invoke_void_return_wrapper<void, true>::__call<MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int)::$_20&, MVKCommandEncoder*, MVKMTLTextureBinding&>(MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int)::$_20&, MVKCommandEncoder*&&, MVKMTLTextureBinding&) at /Applications/Xcode14.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/__functional/invoke.h:479
#5	0x00000001187fe620 in std::__1::__function::__alloc_func<MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int)::$_20, std::__1::allocator<MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int)::$_20>, void (MVKCommandEncoder*, MVKMTLTextureBinding&)>::operator()[abi:v15006](MVKCommandEncoder*&&, MVKMTLTextureBinding&) at /Applications/Xcode14.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/__functional/function.h:185
#6	0x00000001187fd49c in std::__1::__function::__func<MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int)::$_20, std::__1::allocator<MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int)::$_20>, void (MVKCommandEncoder*, MVKMTLTextureBinding&)>::operator()(MVKCommandEncoder*&&, MVKMTLTextureBinding&) at /Applications/Xcode14.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/__functional/function.h:359
#7	0x00000001187e033c in std::__1::__function::__value_func<void (MVKCommandEncoder*, MVKMTLTextureBinding&)>::operator()[abi:v15006](MVKCommandEncoder*&&, MVKMTLTextureBinding&) const at /Applications/Xcode14.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/__functional/function.h:512
#8	0x00000001187e02dc in std::__1::function<void (MVKCommandEncoder*, MVKMTLTextureBinding&)>::operator()(MVKCommandEncoder*, MVKMTLTextureBinding&) const at /Applications/Xcode14.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk/usr/include/c++/v1/__functional/function.h:1197
#9	0x00000001187d8fec in void MVKResourcesCommandEncoderState::encodeBinding<MVKMTLTextureBinding, MVKSmallVectorImpl<MVKMTLTextureBinding, mvk_smallvector_allocator<MVKMTLTextureBinding, 8> > >(MVKSmallVectorImpl<MVKMTLTextureBinding, mvk_smallvector_allocator<MVKMTLTextureBinding, 8> >&, bool&, std::__1::function<void (MVKCommandEncoder*, MVKMTLTextureBinding&)>) at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandEncoderState.h:455
#10	0x00000001187d891c in MVKGraphicsResourcesCommandEncoderState::encodeBindings(MVKShaderStage, char const*, bool, std::__1::function<void (MVKCommandEncoder*, MVKMTLBufferBinding&)>, std::__1::function<void (MVKCommandEncoder*, MVKMTLBufferBinding&, MVKArrayRef<unsigned int const>)>, std::__1::function<void (MVKCommandEncoder*, MVKMTLTextureBinding&)>, std::__1::function<void (MVKCommandEncoder*, MVKMTLSamplerStateBinding&)>) at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandEncoderState.mm:901
#11	0x00000001187d9e14 in MVKGraphicsResourcesCommandEncoderState::encodeImpl(unsigned int) at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandEncoderState.mm:1088
#12	0x00000001186cdef0 in MVKCommandEncoderState::encode(unsigned int) at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandEncoderState.h:93
#13	0x00000001186cde14 in MVKCommandEncoder::finalizeDrawState(MVKGraphicsStage) at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/Commands/MVKCommandBuffer.mm:714

Here is the call stack from the second. This one is much rarer. In this one the MVKImageViewPlane::_imageView is NULL.
What's interesting here though is that at this point the _planes member of MVKImageView seems to be empty. And since getMTLTexture can only be called if _planes.size() > 0, I think it's a race condition where the MVKImageView is getting destroy() called on it while this code is executing. Likely because I've called vkDestroyImageView in another thread.
#1	0x000000011868dcc4 in MVKImageViewPlane::getMTLTexture() at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKImage.mm:1566
#2	0x000000011871ec54 in MVKImageView::getMTLTexture(unsigned char) at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKImage.h:574
#3	0x000000011873a0f4 in MVKImageDescriptor::bind(MVKCommandEncoder*, VkPipelineBindPoint, MVKDescriptorSetLayoutBinding*, unsigned int, bool*, MVKShaderResourceBinding&, MVKArrayRef<unsigned int>, unsigned int&) at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKDescriptor.mm:918
#4	0x0000000118735f44 in MVKDescriptorSetLayoutBinding::bind(MVKCommandEncoder*, VkPipelineBindPoint, MVKDescriptorSet*, MVKShaderResourceBinding&, MVKArrayRef<unsigned int>, unsigned int&) at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKDescriptor.mm:222
#5	0x000000011861a55c in MVKDescriptorSetLayout::bindDescriptorSet(MVKCommandEncoder*, VkPipelineBindPoint, unsigned int, MVKDescriptorSet*, MVKShaderResourceBinding&, MVKArrayRef<unsigned int>, unsigned int&) at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKDescriptorSet.mm:46
#6	0x000000011873f4c8 in MVKPipelineLayout::bindDescriptorSets(MVKCommandEncoder*, VkPipelineBindPoint, MVKArrayRef<MVKDescriptorSet*>, unsigned int, MVKArrayRef<unsigned int>) at /Users/malcolm/dev/devel/MoltenVK/MoltenVK/MoltenVK/GPUObjects/MVKPipeline.mm:60

I also notice that if I use MVK_CONFIG_PREFILL_METAL_COMMAND_BUFFERS_STYLE_IMMEDIATE_ENCODING, or ensure all my resource destructions happen in my main thread (instead of a worker thread), I can't make the crash occur. So I think there is a race condition here.
What I think is happening is that the worker thread is clearing up resources at the same time the the descriptor binding operations are occurring inside of MoltenVK. For the first case the MVKGraphicsResourcesCommandEncoderState was given a MTLTexture that has since been deleted. For the second case the MVKImageView had it's _planes object cleaned up between the start of the getMTLTexture and the end of it (since it shouldn't be able to get into MVKImageViewPlane::getMTLTexture() when _planes.size() == 0), which it is when I inspect the stack at this point.
So the question is, is it legal to destroy resources pointed to by a descriptor, while that descriptor is part of a descriptor set that is being used, even though that particular descriptor isn't referenced by the shader?

So the question is, is it legal to destroy resources pointed to by a descriptor, while that descriptor is part of a descriptor set that is being used, even though that particular descriptor isn't referenced by the shader?

As I mention above, Vulkan does require that an app not destroy resources while they are in-flight in an executing command buffer, and that a descriptor holding a destroyed resource must not be used further while it holds that destroyed resource:

The application must not destroy any other type of Vulkan object until all uses of that object by the device (such as via command buffer execution) have completed.
The following Vulkan objects must not be destroyed while any command buffers using the object are in the pending state:

...
VkBuffer
VkBufferView
VkImage
VkImageView
...

It's possible that you may not be encountering this on other platforms, because the representation within the platform command encoder may not depend on the Vulkan resource object the way it does in MoltenVK and Metal. To improve performance, MoltenVK deliberately uses a MTLCommandBuffer that does not retain the references to the MTLTextures and MTLBuffers.
Having said that, MoltenVK does retain the resource objects within descriptors, but if you also destroy the descriptor set on your worker thread, then it might all disappear too early.

Thanks for your continued attention to this. The spec also states:

VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT indicates that descriptors in this binding that are not dynamically used need not contain valid descriptors at the time the descriptors are consumed. A descriptor is dynamically used if any shader invocation executes an instruction that performs any memory access using the descriptor. If a descriptor is not dynamically used, any resource referenced by the descriptor is not considered to be referenced during command execution.

This clarification was only added recently, in spec v1.3.210.
There is also this validation layer issue that mentions a similar workflow:
https://github.com/KhronosGroup/Vulkan-Docs/issues/1794
I do understand why this would be problematic for MoltenVK though, as the translation layer between it and Metal requires accessing resources on the CPU to do the translation that would otherwise not be accessed by other implantations.
Is my understanding correct? If so, I can try to think of a solution.

Thanks for your continued attention to this. The spec also states:

VK_DESCRIPTOR_BINDING_PARTIALLY_BOUND_BIT indicates that descriptors in this binding that are not dynamically used need not contain valid descriptors at the time the descriptors are consumed. A descriptor is dynamically used if any shader invocation executes an instruction that performs any memory access using the descriptor. If a descriptor is not dynamically used, any resource referenced by the descriptor is not considered to be referenced during command execution.

This clarification was only added recently, in spec v1.3.210.
There is also this validation layer issue that mentions a similar workflow: KhronosGroup/Vulkan-Docs#1794
I do understand why this would be problematic for MoltenVK though, as the translation layer between it and Metal requires accessing resources on the CPU to do the translation that would otherwise not be accessed by other implementations.
Is my understanding correct? If so, I can try to think of a solution.

@mbechard Have you found a solution yet? Can you share that solution with me in here?

What I ended up doing is for each descriptor, I keep track of which elements have been bound. When I update the array for a new usage, I make sure I unbind elements (or bind them to known valid entries) for anything that has been previously bound. So even if your array allocation is large, you can still leave most of it partially-bound entries untouched, and only maintain the ones you are actually making use of.
It won't work for all workflows though, but it worked for me.

PR #2320 should fix this. Please retest with latest MoltenVK and close this issue if the problem is fixed.

It's been a month. Closing now.

Sorry, this fell through the cracks. Honestly I feel like the cure is worse than the symptom on this one. I think in both cases you are stuck doing non-Vulkan spec behavior. With this new change, GPU resources aren't freed until descriptor sets stop referencing them. So the choices are;

Workaround for old behavior: Keep track of all entries in the array that are bound, and whenever you use that descriptor, ensure that those entries are valid (you can ignore entries that were never used).
Required new management for new behavior: All resources now need to keep track of every descriptor that references them, and when they want to be freed, go through all of those descriptors and do an update to cause the descriptor to no longer reference them.

Dealing with #2 seems much more difficult than #1, and I worry that for people that aren't running into #1, they are going to be getting hit by #2 without realizing it.

I've created the separate enhancement issue #2359 to deal with the unreleased memory consumed by the dead resources that are still retained by a descriptor.


Minor tweak in SignInResponseGenerator for testing purposes

For testing purposes, would it be possible to change the access on the CreateSubjectAsync method in SignInResponseGenerator from private to protected? (https://github.com/IdentityServer/IdentityServer3.WsFederation/blob/master/source/WsFederationPlugin/ResponseHandling/SignInResponseGenerator.cs#L100)
Then, I could easily call this method in a test in order to test the entire claims handling in situ.

Could you not test the public GenerateResponseAsync instead of changing the source code? It wouldn't require too much effort to extract the claims from the resulting security token. The plugin only uses security tokens from the System.IdentityModel namespace, so you wouldn't be adding much of a dependency to the test.
Also, are you unit/integration testing this plugin?

Well, sure. But I would say it would be quite more difficult. Instead of having an ClaimsIdentity to test on right away, one would have to call .Write(TextWriter), parse the XML, and extract the SAML assertions from there.  In addition, the test would require more setup (X509 cert, etc.) in order to facilitate signing the response. Possible, yes. Changing the access modifier would be in my mind a simpler option, so that a subclass used for testing could call it directly.

I am trying to walk down the path of calling GenerateResponseAsync as suggested above. It seems is dependent on having an OwinContext wired, and I have a really hard time wiring one up for the test. I notice that some internal tests in IdSrv use the [AutofacConfig](https://github.com/IdentityServer/IdentityServer3/blob/68fe9f496ecbc7a10c571dc769f0fbefb8ce7fde/source/Core/Configuration/Hosting/AutoFacConfig.cs#L33) class to do this, but this is internal so I cannot get to it...

send a PR?


Unwanted Backgroud Colorchange

Hi
After Importing a Big (10MB) Excel-File with (Open-ExcelPackage) and then direct Save it with Close ExcelPackage all the Data are correct, but in many Columns the complete Column has some green Background Color. I don't know why.
Can anybody help me?
Thanks a Lot
Tom

Are you overwriting the data to the file which already had some texts with green backgrounds?
overwriting the data in the same sheet does not clear out the formatting of the cells.
You probably need to use -clearsheet while exporting...
Export-excel -path -clearsheet

No, i just load/open it and then close without any changes. Then there are the green cells.
I try to use clearsheet and give you a Feedback. I hope the other Data are not touched with this parameter.
Thanks already.

Clearsheet clears the data from the sheet.. If you are just opening and closing without changes, then it could be something else. Can you please attach the excel?

Maybe you missunderstand me
To Open > $Excel =Open-ExcelPackage -Path
To Save > Close-ExcelPackage $Excel
If this simple try don't work finde, i don't have to write a full script around.
I can not upload the Excel because of confidelity.

We do not see any such issues. Could be something else in your excel file
that's causing it.
Did you try with a different excel sheet?
Is it happening for all excel in your machine?
What happens when you manually open and close the files?
On Tue, Feb 19, 2019, 08:54 GermanPowerSHELL<EMAIL_ADDRESS>wrote:

Maybe you missunderstand me
To Open > $Excel =Open-ExcelPackage -Path
To Save > Close-ExcelPackage $Excel
If this simple try don't work finde, i don't have to write a full script
around.
I can not upload the Excel because of confidelity.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dfinke/ImportExcel/issues/532#issuecomment-465136232,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aq2jYbs2U5_-8QpMYu-KlkugpM5hEi9xks5vPAIkgaJpZM4aQ9Fr
.

Did you try with a different excel sheet?

If i try with small Excel Sheets, no problem. It works

Is it happening for all excel in your machine?

No, and i tried on different machines. With the Big Excel (12MB) is a problem, with small files no problem.

What happens when you manually open and close the files?
When i manually open it with Excel and Save or SaveAs, there is no Problem.

I couldn't replicate the issue...
Tried making a big excel by manually copying the data multiple times.
Open n close, nothing changes.
May be someone else have different ideas..
On Tue, Feb 19, 2019, 09:48 GermanPowerSHELL<EMAIL_ADDRESS>wrote:

Did you try with a different excel sheet?
If i try with small Excel Sheets, no problem. It works
Is it happening for all excel in your machine?
No, and i tried on different machines. With the Big Excel (12MB) is a
problem, with small files no problem.
What happens when you manually open and close the files?
When i manually open it with Excel and Save or SaveAs, there is no Problem.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dfinke/ImportExcel/issues/532#issuecomment-465158498,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aq2jYZJj-o-NBGqX9eXz1vEiazelp0iZks5vPA7BgaJpZM4aQ9Fr
.


New security alert: Suspicious modification of a dNSHostName attribute (CVE-2022-26923)

Please update the documentation with new security alert: "Suspicious modification of a dNSHostName attribute (CVE-2022-26923)"
Br,
Danny PANS
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f7137cd0-1ce4-bd31-4bcb-30f2b30d2959
Version Independent ID: d0dd1602-4625-78da-1a21-211d85a2baab
Content: Microsoft Defender for Identity lateral movement security alerts
Content Source: ATPDocs/lateral-movement-alerts.md
Service: microsoft-defender-for-identity
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

Thank you for your comment. We'll investigate and get back to you.

Hi - tagging an SME as a reminder. @danaim1, please take a look here.

We haven't heard back from you since the fix, so we're closing the issue for now. Feel free to add more comments and tag me if you have additional feedback.
Thanks again for your contribution!
#please-close


dynamically add plot after plot already rendered

had a thought in the shower....
what if we made it possible to do something like:
plot.add_plot(position="right")
and that would change the plot to a gridplot with shape (1,2) with the left plot having the original graphics and the right plot being empty to start
I thought it might be useful in the event that you create a plot and have done some manipulations to the graphics and decide you need another plot, @kushalkolar thoughts?

mostly a duplicate of #181, closing to reduce clutter


Jumping weird behavior.

Jumping needs to be worked on, it has weird behavior that makes it hard to use.

Can you describe the weird behavior?


styling for guardian setup

sorry autoformatter went to town on this
main changes:

spacing between some form fields
full-width header
use system monospace font

Looks like an improvement, any reason not to merge @futurepaul?


Fix title trait documentation

Fixes title trait documentation to correctly refer to the trait defining a name for a service or operation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sorry, this trait should appear on resources and services, not operations. I told you the wrong thing.


when using zod-i18n-map, field errors are [undefined]

Description
When using zod-i18n-map, errors are undefined.
if i have a schema defined as follows:
import { z } from 'zod';

const schema = z.object({
  name: z.string().min(3),
  age: z.number()
})

It works as expected, when sending a name with less than 3 characters, the error is displayed correctly.
However, if it is defined as follows (see the zod-i18n-map docs):
import i18next from "i18next";
import { z } from "zod";
import { zodI18nMap } from "zod-i18n-map";
import translation from "zod-i18n-map/locales/es/zod.json";

i18next.init({
  lng: "es",
  resources: {
    es: { zod: translation },
  },
});

z.setErrorMap(zodI18nMap);

const schema = z.object({
  name: z.string().min(3),
  age: z.number()
})

When sending a name with less then 3 characters, the form object has the following shape:
{
  id: '9yawuu',
  valid: false,
  posted: true,
  // see that even though the array has an item, the item is `undefined`
  // instead of the error string
  errors: { name: [ undefined ] },
  data: { name: '2', email: '' }
}

If applicable, a MRE
SvelteLab link to a MRE
If the link is not working, you can just grab the template and set the routes/schema.ts file content as follows:
// routes/schema.ts
import i18next from "i18next";
import { z } from "zod";
import { zodI18nMap } from "zod-i18n-map";
import translation from "zod-i18n-map/locales/es/zod.json";

i18next.init({
  lng: "es",
  resources: {
    es: { zod: translation },
  },
});
z.setErrorMap(zodI18nMap);

export const schema = z.object({
	name: z.string().min(2),
	email: z.string().email()
});

To see the bug happen, click to submit the form and look at the terminal to see the form shape.
Additional information
At first i thought it was some sort of error in zod-i18n-map itself, but i tried .safeParse() directly from the schema and the error messages are displayed correctly (in the configured language)

There is an errorMap option on the adapter that you should use instead of the global function.

See if you can make a MRE at https://sveltelab.dev/github.com/ciscoheat/superforms-examples/tree/zod and I'll take a look.

link to a MRE.
See that in schemas.ts i load the translation using i18next and the json translation file from zod-i18n-map.
Also, in +page.server.ts i also load the error map from zod-i18n-map from within the adapter.

Even after following the instructions at https://github.com/aiji42/zod-i18n, I can't get safeParse (used directly on the schema) to show localized errors, unfortunately. Can you link to a working example for that?

just found out the weirdest thing:
first, i figured that the problem is with zod-i18n (see this issue). it seems like it is having trouble with ecmascript modules.
however, i was sure that (at some point) i was able to get it to work, but didnt know how
conclusion: if the page that is importing the schema is SSR'd, it wont work (meaning the errors will be an array with a single undefined value). however, if the page is not SSR'd, it will work correctly (translated messages will show up just fine)
im going to close the issue as it's unrelated to your package, sorry for the disturbance


Drops support for xchammer and xcbuildkit

Drops xchammer in favor of legacy_xcodeproj rule.  The goal is to clean up the unused portions of the repo to facilitate an update to Bazel 6, support for bzlmod, and newer rules_apple releases.

This greatly simplifies bzlmod migration

Well that one landed pretty fast - what about this was actually broken @jszumski ?

In this PR description, I'd like to also know more about what you mean by this:

facilitate an update to Bazel 6,

We have used Bazel 6.0 in rules_ios to 6.0 about a year ago and didn't have an issue with it then either

Poorly worded... that was mean to convey moving the minimum supported version to 6.


chore: Add prepare script

Add prepare script to let use git as source for the  npm module

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Null Exception when Enum value is null

Hi,
when I tried to generate an api from:
https://api-docs.firefly-iii.org/?urls.primaryName=2.0.10 (v2)
It gave an exception for "AutoBudgetPeriod", although there are a few more enums, on this code:
class: SwaggerSchemaEnum line 30: name = value.ToString() ?? "";
I fixed it by doing this:
`
else
{
name = value?.ToString() ?? "";
}
if (string.IsNullOrWhiteSpace(name) == false)
{
if (Char.IsDigit(name[0]))
{
name = "_" + name;
}
if (!unique.Add(name))
{
    continue;
}

}
`
but it doesn't seem right to me..

Do you happen to have the json file you used to generate?
From what I can see, the link you posted only has yaml files available.
I will try to reproduce the issue and see what's going wrong if you can link me the file.

I couldn't find the enum in the V2 you linked, but after looking at the yaml file for v1 I noticed this:
    AutoBudgetPeriod:
      type: string
      format: string
      example: "monthly"
      nullable: true
      description: "Period for the auto budget"
      enum:
        - daily
        - weekly
        - monthly
        - quarterly
        - "half-year"
        - yearly
        - null

Also pulled it through a YAML to JSON converter and got this:
      "AutoBudgetPeriod": {
        "type": "string",
        "format": "string",
        "example": "monthly",
        "nullable": true,
        "description": "Period for the auto budget",
        "enum": [
          "daily",
          "weekly",
          "monthly",
          "quarterly",
          "half-year",
          "yearly",
          null
        ]
      }

It seems like it's adding null as one of the values for the nullable enums, which I did not expect nor have for the swagger documents I generated myself.
The fix for that is fairly easy and I will try and push it in the following days.
However, "half-year" is a whole other issue as there's no support yet for this.
The code currently assumes the enum's can be directly ToString'ed for query parameters and System.Text.json has no support yet for EnumMemberAttribute when used in a body.

Referencing https://github.com/dotnet/runtime/issues/74385

Do you happen to have the json file you used to generate? From what I can see, the link you posted only has yaml files available.
I will try to reproduce the issue and see what's going wrong if you can link me the file.

Hello! Sorry for the late reply it was night time already here.
Yes that's exactly the enum that gives an error, I converted to json and got the same result as you.
Sorry I thought it was on v2, I manually joined v1 and v2 and didn't notice it, well done catching that.
Great news for the null fix then!
As for the dash, I'd something like these anwsers:
Check if is has special chars:

char.IsLetterOrDigit
https://stackoverflow.com/questions/4503542/check-for-special-characters-in-a-string

Place an attribute description with the enum value as is:
https://stackoverflow.com/questions/8852253/how-can-i-get-enum-to-contain-a-dash
And before creating the member, I'd take out the special chars:
https://stackoverflow.com/questions/1120198/most-efficient-way-to-remove-special-characters-from-string

So far, I've fixed most of the generating problems that came out of this swagger document on the linked dev branch.
The problem is that these solutions all require a custom serializer to be added to the serializer options.
The difficulty there is that this generator is only very loosely coupled to System.Text.Json by default and tries not to make any assumptions which json serialization you're actually using. Or if you're even using Json as a serializer at all. These are all very easily overwritten in the __ClientOptions class. So far, this has always been very easy to do by adding the needed attributes as startup options with System.Text.Json defaults when omitted.
However, in this case, this would require also generating the Serializer itself, which is vastly different between System.Text.Json, Newtonsoft or let alone any other serialization solutions.
In essence, it would be very easy to generate something like this:
public enum AutoBudgetPeriod
{
	daily,
	weekly,
	monthly,
	quarterly,
	[System.Runtime.Serialization.EnumMember(Value = "half-year")]half_year,
	yearly
}

This will work out of the box for Newtonsoft, but not for System.Text.Json.
On top of the serializer, I also need to add support when these are used as query parameters.
I'm kind of hesitant to quickly add this functionality without thinking it through first. When dotnet8 releases next month, my main goal for this generator is to start preparing it to fully support Native AOT --> This will instantly break this solution.
Instead, I'm currently thinking I might add an option instead as a sort of "quick-fix" when working with API's like this:
--enum-strings       Generate enums as string constants. Use this if the calling API contains enumerations that do not have valid names in C#
Resulting in:
public static class AutoBudgetPeriod
{
	public const string daily = "daily";
	public const string weekly = "weekly";
	public const string monthly = "monthly";
	public const string quarterly = "quarterly";
	public const string half_year = "half-year";
	public const string yearly = "yearly";
}

@glenndierckx  : Do you have an opinion on this?

Sorry for the late reply. I would try to avoid generating enum members as those constant values. Preferably it's indeed with an attribute like that EnumMember one. It indeed then needs a custom serializer, but that's just the cleanest way I think. Which reminds me, should we also add JsonPropertyNameAttributes for properties that don't match by default?

Yes! I believe I already started implementing support for this on the branch.
One of the contracts in the supplied swagger document for this issue contained a property called 0 which is also not a valid dotnet naming.


Ensure correct error message when have error decrypting parameter and also have keys that convert

When you have an action that takes two key/value pairs whereby:

One parameter is encrypted and the key/value isnt' set
Another parameter is of a type other than string, and key/value pair is set

When the error is reported for the parameter that can't be decrypted, on handling that error another exception is raised when it attempts to validate the parameter json in regard to the parameter in key/value store that needs to be converted. This means that the incorrect error message is reported.
See #5312 for an example case of when this occurs.
Closes #5312

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Kami Thanks for review comments, I've addressed them now - and in process, realised I had one of the UT wrong! Ready for re-review when you get a chance.


Valid IP addresses are still failing validation in federation API

I receive the following when trying to establish a federation mapping with, for example, a Google DNS resolver IP of <IP_ADDRESS>. This is not the first time we have seen this issue.
{
    "alerts": [
        {
            "level": "error",
            "text": "[ <IP_ADDRESS>/128 ] is not a valid ip address."
        }
    ]
}

Wait.. my bad. /128 is why it failed, which is a v6 mask. I'll test more and will re-open if necessary. Apologies for the oversight - was overzealous with :%s/foo/bar/g


Parallel tests of multiple iterations

Added the ability to run multiple iterations of the same test in parallel. Modified loop structure, as well as passing in changed parameters as variables.

@llxia Can you please check this out?

Please provide Grinder links for 4 test cases. Thanks.

Please provide Grinder links for 4 test cases. Thanks.

Here they are:
https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder_Sandbox3/1378/
https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder_Sandbox3/1377/
https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder_Sandbox3/1368/
https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder_Sandbox3/1363/

Please format the code using the IDE. For example, { should be in the same line of the code, not in the next line. This PR is using both cases.
if (iterate == 1){

else
{

Please also add git sign off.


improve: use pod ip cache to accelerate ip allocation

Pull Request Description
Describe what this PR does / why we need it

Introduce PodIPCache
Remove the action of patching pod to accelerate ip allocation.

Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report

Merging #211 (e1448bb) into main (0a64c1f) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   27.71%   27.56%   -0.15%
==========================================
  Files          23       23
  Lines        1656     1665       +9
==========================================
  Hits          459      459
- Misses       1145     1154       +9
  Partials       52       52

Flag
Coverage Δ

unittests
27.56% <0.00%> (-0.15%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/utils/ip.go
80.00% <0.00%> (-15.66%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a64c1f...e1448bb. Read the comment docs.


[v0.2]

[ ] fix #8
[x] add hyde
[x] add lanyon
[x] fix #7
[x] fix #1

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/590
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:
git tag -a v0.2.0 -m "<description of version>" 14b1398aeb11117759bb161e225a692580c73f8b
git push origin v0.2.0


Allow prices to vary according to product options

This is common in the world of print where there's a load of options that go with each product. For example:

Paper type
Print quantity (eg box of 100)
Lamination

Each combination can have a different price.
Oscar needs a change to the strategy interface to allow this as the options aren't passed around at the moment. Here's one place to change:
https://github.com/tangentlabs/django-oscar/blob/master/oscar/apps/basket/abstract_models.py#L176

This is something we also need for most projects. Currently we keep re-implemeting it in each project so I would like to work getting this in Oscar.
We have the following requirements:

Options which have the same price for all products
Options which have a different price per product (e.g. an installation fee).

We currently achieve this by setting a default price on the Option model and create a separate model (OptionPrice) which overrides the default price for a specific option/product combination.
The selected options are then passed to Strategy.fetch_for_product() where the strategy can calculate the combined price.
This doesn't allow a different option price per partner or a stock for an option, but this can be achieved the same way I believe.
Let me know if this is something we would like to see in Oscar.

Extremely required function. Must use LFS instead Oscar because of that :(

For customizable products with multiple Options is extremely useful.

@mvantellingen definitely would like to see this. I think it requires careful redesign of the Strategy interface. If you get the time, please grab us for discussing the interface changes before submitting a PR.

So I think we can first implement some relative simple changes to the Strategy interface which allows varying prices based on the selected options. In a later phase we can extend this based on experiences learned.
The idea is to pass a dict with the selected options to the pricing_policy and parent_pricing_policy methods. This requires us to also add the options to the fetch_for_product method.
The dict can be as simple as:
options = [
    {
        'code': 'my_option',
        'value': 'my option value',
    },
]

We are going to be looking into upgrading our ecommerc system from ColdFusion to Django. Basically re-writing it. This feature (option-based price deltas) is critical. We solved this a decade ago, but we would be looking for similar functionality from Oscar if it is to be taken seriously as an ecommerce solution.
Imagine selling an Apple Watch, where the band that select changes the overall price - very common scenario.
Here is how we handled it in our legacy platform:

Is there any documentation on how to do this yet?

Any updates ?

Good day!
Has anyone implemented this?
How can I set the price for an Option?

closing all issues that are feature requests that don't have open PR's attached.

I am new to Django-Oscar. I am trying to achieve the exactly the following. And as this discussion is quite old and seems like the solution is already merged with Oscar, But I could not find any way to set the price varying as per the options selection. Can anyone please help?
This is common in the world of print where there's a load of options that go with each product. For example:
Paper type
Print quantity (eg box of 100)
Lamination

Each combination can have a different price.


Fix Dashboard dropdown link display

This setting is required for Dashboard link dropdowns to work properly.
Fixes https://github.com/teslamate-org/teslamate/issues/3499

@oivindoh - thanks a lot! I've been to optimistic on that one...


Add a new module for poi-3.11 including poi-ooxml-schemas

Added a new module for poi-3.11, and included the
poi-ooxml-schemas which is missing in the poi-3.9 module.
This provides the ability to read microsoft xlsx files (tested)
and in theory all or ther file types supported by poi-ooxml
and poi-ooxml-schemas (untested)

Thanks, I created the corresponding Jira. I will review and apply.

OK great.
let me know if there are any problems I can help with.

On 23/01/2015, at 7:25 pm, Jean-Baptiste Onofré<EMAIL_ADDRESS>wrote:
Thanks, I created the corresponding Jira. I will review and apply.
—
Reply to this email directly or view it on GitHub https://github.com/apache/servicemix4-bundles/pull/11#issuecomment-71152789.

Hi,
This should have been in the bundles-2015.01 release, but it seems that the poi-3.11 version is not pushed to Maven Central
This is also mentioned by someone else on https://issues.apache.org/jira/browse/SMX4-1922
Is that correct and if so, when will it be published on Maven?


doppkit improvements

[ ] for large transfers, it builds the list and then starts the transfer, for short duration presigned urls, this is a problem in that the url is retrieved but not downloaded until much later and it times out - depth first not depth first

it builds the list and then starts the transfer,

Instead of trapping, we should wait to fire the HEAD/GET request until we are actually going to fetch it. As async code, it should be able to build the list as it starts transferring. The distinction doesn't matter until the list gets so big.

Fixed with #10


TestOutputOrganizer should have cleanOutputSubDirectory() method

TestOutputOrganizer already has the cleanOutputDirectory() which will empty all sub directories and files. It is too brutal. It should also have cleanOutputSubDirectory() which wil empty each individual sub directories.

done at v0.2.1


Models not rendering during Remix runtime

This happens because DXVK does not know how to interperate a specific format.
"warn:  ConvertFormat: Unknown format encountered: D3D9Format::AL16
warn:  ConvertFormat: Unknown format encountered: D3D9Format::R16"
According to this change in the main DXVK Build - https://github.com/doitsujin/dxvk/commit/c13395db970d16a5631a7c0926e2c4529d2710c3
[util] Enable strict float emulation for a bunch of games
https://github.com/doitsujin/dxvk/issues/2107
Changing the d3d9.floatemulation to strict will cause the grass to render.
I was experiencing this issue in Arx Fatalis. Key objects where not being rendering during the the RTX Runtime.

I miss read this and the issues displayed are actually related to the   D3D9: VK_FORMAT_D24_UNORM_S8_UINT -> VK_FORMAT_D32_SFLOAT_S8_UINT and not specifically the the texture formats.

found a potential solution.
https://registry.khronos.org/vulkan/specs/1.3-extensions/man/html/VkFormat.html
https://github.com/doitsujin/dxvk/pull/1661
https://github.com/Joshua-Ashton/d9vk/pull/155#issuecomment-500135920
which involved adding the format to d3d9_format.cpp.
Ran a build and now I am being presented with memory allocation failures.
arx_d3d9.log
Not sure if the implementation is accuate or not.
Attached the Log for now.

This fix did not work. The error messages disappeared but the models were still not showing up.
I found that this issue was reported back in 2005 -
**(2) "all interactive objects-- NPCs, the PC, stones, inventory items, creatures, etc -- are completely invisible. This also seems to effect the game in other ways; for example I cannot select an object, such as a door, that's invisible, although I do collide with it."
This has been reported with a GeForce 5200 FX video card and DirectX 9.0c, and was fixed by using the Forceware 61.77 drivers.**

after troubleshooting I have found that the objects not being rendered are due to the objects being in another render target.
info:  [RTX-Compatibility-Info] Trying to raytrace but not detecting a valid camera. is showing even though path tracing is working.
arx_d3d9.log

This issue is already tracked by REMIX-1205.


Can pipeline have unwanted results?

I was digging through the pipline feature in the lib and I am wondering if it can lead to weird behavior?
It sets _pipeline to true and then the subsequent command calls are stored and only executed when calling flush, however, can't it also store command calls from other parts of the code?
If we have two places in the code using the same client and one is using pipeline and other isn't, if they run at same time, wouldn't the commands that aren't supposed to be in pipeline also be executed in the pipeline because of the pipeline call?
Is this expected?
Should I create another client just for pipelining purposes?
I am not an expert in Redis and this is my first time using pipeline, so I wouldn't know.

That's the expected behavior, you should not use the same connection with different purposes without expecting unwanted results.

okay


DS update causing OTG to crash on initialization

Mod Version:
modpack has <IP_ADDRESS>, tried to update to <IP_ADDRESS>
Forge Version:
<IP_ADDRESS>54
Link to crash log:
https://paste.dimdev.org/ogecumizeh.mccrash
Description:
hello! i've very much enjoyed dynamic surroundings as part of a modpack i'm playing (Rougelike Adventures and Dungeons) and i discovered that when i tried to update it to the newest version i started having issues with Open Terrain Generator giving me an error from an "unknown" mod (found out from a forum thread it's OTG). tried previous versions of OTG with updated Dynamic Surroundings to no avail. going back to the modpack's version of Dynamic Surroundings (<IP_ADDRESS>) was the only thing that fixed it, so i think something that changed between the two versions affected this.

use the latest beta, and install MixinBootstrap.  May also need to install Mixin Compat.

I tried installing those two like you said (had to install both) but am still getting the "unknown" error. Here's the updated crash log: https://paste.dimdev.org/tugodemazo.mccrash
and here's the system latest log: https://paste.dimdev.org/uroreceyup.md
also i super super super appreciate your help with this! thanks so much for the quick response.

OK - mixin looks like it is loading properly.  I am seeing this in the log - not sure if it is a problem.  There is a problem report against the mod about this from Feb but the author has not responded.
[06:36:09] [main/ERROR]: Coremod EyeOfDragonsPlugin: Unable to class load the plugin de.curlybracket.eyeofdragons.EyeOfDragonsPlugin
java.lang.ClassNotFoundException: de.curlybracket.eyeofdragons.EyeOfDragonsPlugin

I see this, too, right before MC terminates:
[06:36:21] [Client thread/WARN]: Unable to call Core API! It has not been initialized yet!

Related?  Not sure.  Can you remove Eye of Dragons to eliminate it from the equation?


REQUEST-949: Increase msg verbosity of rule 949110

@pmjdebruijn : Thank you for this contribution.
You are basically repeating the information in 980130. While I personally do not like 980130, your PR creates redundancy and I wonder if that is what you really intend and if so why.

I've made this change to be able to troubleshoot an issue we were having... It seems 980130 didn't get triggered for us... Presumably because 980130 evaluates TX.INBOUND_ANOMALY_SCORE while my change evaluates TX.ANOMALY_SCORE

That's very odd, since the former is defined in 949110 based on the latter. This means if 949110 triggers, 980130 triggers too. I plan to overhaul this whole anomaly score logging, but that's the way it is meant to run right now and you introduce redundancy and if it's only in order to get this info, then the PR does not really add value since the info is already there.
If you consistently do not get 980130, then we're open to investigate this with you, since it might be a bug.
If I do a vanilla installation and the following curl call, then I get 949110 and 980130.
curl -v http://localhost/index.html?test=/etc/passwd

error.log:
[2020-12-07 16:12:49.734405] [-:error] <IP_ADDRESS>:35912 X85GcaS@1gnke8m2Vh5wpQAAAAE [client <IP_ADDRESS>] ModSecurity: Warning. Operator GE matched 5 at TX:inbound_anomaly_score. [file "/home/dune73/data/git/crs-pull-1911/rules/RESPONSE-980-CORRELATION.conf"] [line "87"] [id "980130"] [msg "Inbound Anomaly Score Exceeded (Total Inbound Score: 15 - SQLI=0,XSS=0,RFI=0,LFI=5,RCE=5,PHPI=0,HTTP=0,SESS=0): individual paranoia level scores: 10, 0, 0, 5"] [ver "OWASP_CRS/3.3.0"] [tag "event-correlation"] [hostname "localhost"] [uri "/403.html"] [unique_id "X85GcaS@1gnke8m2Vh5wpQAAAAE"]

I'm closing this for the time being.

While I can reproduce your example case, for us this wasn't true for a false positive flagged via libinjection
https://github.com/client9/libinjection/issues/151
as libinjection javascript function matching is rather naive, and generates false positive on "onedrive"

Can you provide a onedrive-example call (ideally curl) so I can check this out, please. I do not get a FP with this. I'm interested in learning about this.
But it does not matter how what triggers the score. The deciding factor on 980130 is whether the request hit the anomaly score limit or not (in 949110).

curl --insecure --verbose https://MYHOST/?url=https://whatever.com/onedrive.aspx?id=test
Triggers the issue, however, it seems, proper logging does happen to modsecurity.log. Now I've noticed this in a test setup, where I cleared all logs before reproducing, so I'm guessing I must have missed this in our production situation due to modsecurity.log being a multiline format, which is much harder to grep/read through reliably.
So I still think there is still some value in including slightly more information in error.log which is much easier to grep/parse.

I confirm the libinjection false positive for this one.
Here are my logs, including 980130.
[2020-12-08 10:31:30.735666] [-:error] <IP_ADDRESS>:42958 X89H8kbRs0p8Gv-gDMwEcwAAAAA [client <IP_ADDRESS>] ModSecurity: Warning. detected XSS using libinjection. [file "/home/dune73/data/git/crs-official/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"] [line "60"] [id "941100"] [msg "XSS Attack Detected via libinjection"] [data "Matched Data: XSS data found within ARGS:url: https://whatever.com/onedrive.aspx?id=test"] [severity "CRITICAL"] [ver "OWASP_CRS/3.2.0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-xss"] [tag "paranoia-level/1"] [tag "OWASP_CRS"] [tag "OWASP_CRS/WEB_ATTACK/XSS"] [tag "WASCTC/WASC-8"] [tag "WASCTC/WASC-22"] [tag "OWASP_TOP_10/A3"] [tag "OWASP_AppSensor/IE1"] [tag "CAPEC-242"] [hostname "localhost"] [uri "/"] [unique_id "X89H8kbRs0p8Gv-gDMwEcwAAAAA"]
[2020-12-08 10:31:30.736015] [-:error] <IP_ADDRESS>:42958 X89H8kbRs0p8Gv-gDMwEcwAAAAA [client <IP_ADDRESS>] ModSecurity: Access denied with code 403 (phase 2). Operator GE matched 5 at TX:anomaly_score. [file "/home/dune73/data/git/crs-official/rules/REQUEST-949-BLOCKING-EVALUATION.conf"] [line "91"] [id "949110"] [msg "Inbound Anomaly Score Exceeded (Total Score: 5)"] [severity "CRITICAL"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-generic"] [hostname "localhost"] [uri "/"] [unique_id "X89H8kbRs0p8Gv-gDMwEcwAAAAA"]
[2020-12-08 10:31:30.739206] [-:error] <IP_ADDRESS>:42958 X89H8kbRs0p8Gv-gDMwEcwAAAAA [client <IP_ADDRESS>] ModSecurity: Warning. Operator GE matched 5 at TX:inbound_anomaly_score. [file "/home/dune73/data/git/crs-official/rules/RESPONSE-980-CORRELATION.conf"] [line "86"] [id "980130"] [msg "Inbound Anomaly Score Exceeded (Total Inbound Score: 5 - SQLI=0,XSS=5,RFI=0,LFI=0,RCE=0,PHPI=0,HTTP=0,SESS=0): individual paranoia level scores: 5, 0, 0, 0"] [tag "event-correlation"] [hostname "localhost"] [uri "/403.html"] [unique_id "X89H8kbRs0p8Gv-gDMwEcwAAAAA"]

You are right, that the logging is tricky to read correctly, namely when you work with the audit log. And I think this also explains why you did not notice your initial 980130 entry.
One key to successful logging is usually to filter by the unique-ID which has the last position in the alert message that is written to the error.log.
My tutorials at netnea.com advocate to write this unique-ID to the access.log as well.
If you want to be a good web citizen, you could open a false positive report over at libinjection. But I have to admit, the bugs are piling up and development is not going anywhere. But at least it would be documented.

As I already mentioned, it was already reported: https://github.com/client9/libinjection/issues/151
I polished up that code, and created a proper pull request: https://github.com/client9/libinjection/pull/153

Ah, sorry. I'm juggling too many issues in parallel here.
Thank you for your work and submitting a PR. Now if only libinjection would return from the dead.

It seems it's been resurrected by the libmodsec folks:
https://github.com/libinjection/libinjection/issues/10

We'll see if that gets any traction.


Add ability to signal selection failure for streaming nested json extraction

Recently, we hit an issue where our code that used .key.[] emitted no elements in its stream, because .key was incorrect - no such key was in the json.
I'd like to have a mode for filters that can error out if the key being filtered isn't present

Something like .key! which fails when the object ends and the key wasn't present?


Fix: IndexedStack says its children are offstage when dumping render tree, but they are indeed onstage and users get confused

Close #111478
Please see https://github.com/flutter/flutter/pull/111479#issuecomment-1463754109 for context.
This is a tentative PR, since I am not very sure what do Flutter team think about this. If you think it is OK, I will add tests, polish it (e.g. adding a longer issue) etc!
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

this should have a comment linking to the issue, namely https://github.com/flutter/flutter/issues/111478

done

That looks reasonable! @simolus3 hi could you please re-create the PR as suggested above?

I've opened https://github.com/flutter/flutter/pull/123129 again.

Thanks. I am going to close this one in the meantime.


[BUG]: AzureCLI@2 az login --federated-token ERROR: AADSTS50166: Request to External OIDC endpoint failed

New issue checklist

[X] I searched for existing GitHub issues
[X] I read pipeline troubleshooting guide
[X] I checked how to collect logs

Task name
AzureCLI
Task version
2
Issue Description
All AzureCLI tasks that use a "Azure Resource Manager using Workload Identity federation with OpenID Connect (automatic)" service connection fail with this error message:
ERROR: AADSTS90061: Request to External OIDC endpoint failed.
"Azure Resource Manager using service principal (automatic)" service connections work without any issues.
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[X] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
ubuntu-latest
Relevant log output
2024-05-01T10:15:02.1849592Z Setting active cloud to: AzureCloud
2024-05-01T10:15:02.1931750Z [command]/usr/bin/az cloud set -n AzureCloud
2024-05-01T10:15:03.3332018Z [command]/usr/bin/az login --service-principal -u *** --tenant *** --allow-no-subscriptions --federated-token ***
2024-05-01T10:15:04.6486078Z ERROR: AADSTS90061: Request to External OIDC endpoint failed. Trace ID: 88a95eb4-0c20-47e2-af76-772d85eb1600 Correlation ID: a1d847dc-6a76-4c09-80c4-c82f45e852e9 Timestamp: 2024-05-01 10:15:04Z
2024-05-01T10:15:04.6527096Z ##[error]Error Code: [1]
2024-05-01T10:15:04.6536360Z Interactive authentication is needed. Please run:
2024-05-01T10:15:04.6536615Z az login
2024-05-01T10:15:04.6537404Z ##[error]Error: Azure login failed
2024-05-01T10:15:04.6539137Z ##[error]Script failed with error: ERROR: AADSTS90061: Request to External OIDC endpoint failed. Trace ID: 88a95eb4-0c20-47e2-af76-772d85eb1600 Correlation ID: a1d847dc-6a76-4c09-80c4-c82f45e852e9 Timestamp: 2024-05-01 10:15:04Z
Interactive authentication is needed. Please run:
az login

Full task logs with system.debug enabled
see above
Repro steps
trigger:
- main

pool:
  vmImage: ubuntu-latest

steps:

- task: AzureCLI@2
  displayName: works
  inputs:
    azureSubscription: 'serv-conn'
    scriptType: 'pscore'
    scriptLocation: 'inlineScript'
    inlineScript: 'echo "hello from Azure"'

- task: AzureCLI@2
  displayName: does not work
  inputs:
    azureSubscription: 'fed-conn'
    scriptType: 'pscore'
    scriptLocation: 'inlineScript'
    inlineScript: 'echo "hello from Azure"'

Can confirm we're getting this across multiple Azure Tenants from our DevOps too - using Microsoft hosted agents but also throws error when trying to verify the workload identity service connection

The issue is being tracked on the Azure DevOps Status page:
https://status.dev.azure.com/_event/499193080


Unclear example of cached VM disk limits

In my opinion, the last two examples of cached disk accesses are unclear, or potentially misleading (depending whether I understood it correctly or not).
Look at this example:

The described setup is this:
Standard_D8s_v3
Cached IOPS: 16,000
Uncached IOPS: 12,800
If the disk IO requests have a cache hit, then I understand that the total 3x5000 IOPS is below the cached limit of 16000 IOPS. But in this case, why are there arrows going from the cache to the disk? I think this would be incorrect, since the data comes only from cache, not from the attached disks.
But on the other hand, if the data indeed comes from the attached disks as the arrows would imply (i.e. cache miss), then according to the docs, a few paragraphs above the referenced image:

When a read is performed and the desired data is not available on the cache, the read request is relayed to the disk. Then the disk surfaces it to both the cache and the VM. This read is counted toward both the VM's uncached limit and the VM's cached limit.

In that case, I would assume, that the VM uncached limit of 12800 IOPS is reached and the maximum requested IOPS of 15000 is not achieved.
A third interpretation would be that even when reading from cache, somehow disk IOPS limits apply as well? But I can't see this documented explicitly like this anywhere.
Is there a mistake in my reasoning, or is the documentation incorrect here?

Document details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 8d99436a-dbb2-a88a-9881-2472e4c5ca80
Version Independent ID: 2a2b5781-fbd1-a8ee-0aac-5aed7540d57a
Content: Virtual machine and disk performance - Azure Virtual Machines
Content Source: articles/virtual-machines/disks-performance.md
Service: storage
Sub-service: disks
GitHub Login: @roygara
Microsoft Alias: rogarana

@jhyot
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly
@roygara
Can you please check and add your comments on this doc update request as applicable.

@jhyot Thanks for reaching out and bringing this to our attention. We appreciate it!
In this case the article is incorrect, we've made some updates and they should be live in the next day. I'll let you know when they're live and close out this issue then.
Again, thanks for bringing this to our attention and helping us improve the docs! :)

@jhyot The updates are live. Accordingly, I'll close this out. Thanks again!
#please-close

#please-close


git.ignoredRepositories does not support case insensitive file systems

VSCode Version: 1.40.1
OS Version: Windows_NT x64 10.0.19013

Steps to Reproduce:

Open directory with several git repos
Add one repo in Ignored Repositories setting, for example C:\Projects\example
Repo will not be ignored, because drive letter 'C' is in uppercase. It works correctly if we type c:\Projects\example.

I guess this setting shouldn't look at case on case insensitive file systems (like Windows).

Does this issue occur when all extensions are disabled?: Yes

It probably doesn't matter, but it looks like the git extension isn't listening to changes on git.ignoredRepositories since a reload is required.

@alexr00 The setting is read once a repository is discovered. Once it is open, it remains open regardless of the setting. Much like once a file is in the repo, adding it to .gitignore isn't enough, it must also be removed from the repo.