TypeError: Cannot read property 'pop' of null

Environment details

OS: Google Kubernetes Container
Node.js version: 12.15.0
npm version: to be update.
@google-cloud/spanner version: 5.16.1

Steps to reproduce

?
?

We're seeing an issue in our production environment. It happens pretty inconsistently, so I'm not sure of how exactly to reproduce it. The error message and stack:
TypeError: Cannot read property 'pop' of null
    at Function.mergeLists (/deploy/my-project/node_modules/@google-cloud/spanner/build/src/partial-result-stream.js:255:65)
    at Function.merge (/deploy/my-project/node_modules/@google-cloud/spanner/build/src/partial-result-stream.js:227:41)
    at Function.mergeLists (/deploy/my-project/node_modules/@google-cloud/spanner/build/src/partial-result-stream.js:255:44)
    at Function.merge (/deploy/my-project/node_modules/@google-cloud/spanner/build/src/partial-result-stream.js:227:41)
    at Function.mergeLists (/deploy/my-project/node_modules/@google-cloud/spanner/build/src/partial-result-stream.js:255:44)
    at Function.merge (/deploy/my-project/node_modules/@google-cloud/spanner/build/src/partial-result-stream.js:227:41)
    at PartialResultStream._addChunk (/deploy/my-project/node_modules/@google-cloud/spanner/build/src/partial-result-stream.js:145:48)
    at PartialResultStream._transform (/deploy/my-project/node_modules/@google-cloud/spanner/build/src/partial-result-stream.js:84:24)
    at PartialResultStream.Transform._read (_stream_transform.js:189:10)
    at PartialResultStream.Transform._write (_stream_transform.js:177:12)
    at PartialResultStream.obj.<computed> [as _write] (/deploy/my-project/node_modules/stubs/index.js:26:26)
    at doWrite (_stream_writable.js:435:12)
    at writeOrBuffer (_stream_writable.js:419:5)
    at PartialResultStream.Writable.write (_stream_writable.js:309:11)
    at Pumpify.ondata (/deploy/my-project/node_modules/readable-stream/lib/_stream_readable.js:619:20)
    at Pumpify.emit (events.js:223:5)

The error seems can not be caught. I wrapped try-catch on all of my spanner operations but still got restart of my nodejs process.
Please let me know what other information would be helpful.

Hi @tallguys. If possible could you share, usually when you are trying to read/write the data and this error gets thrown are any of the columns of type array or struct(if yes, which kind)? Also does the issue seem to disappear when you rerun it the application or it persists?

Thanks for your response @asthamohta. I'm not sure which query cause this error. However, we have the scenario to read columns in type array and struct.
 Is this a persistent issue or does it disappear when you rerun the query?

@asthamohta Sorry, I can't rerun because I'm not sure which query exactly is. It happens around 10 times daily. I think it might relate to specific data or network.
Would it help if I query without ARRAY and STRUCT?

@tallguys I think the query looks okay and there is an issue on our end. Can you confirm that you are able to run it on cloud console without errors? Also if possible it would be great if you could provide a db schema where you think we can replicate this issue.

I can confirm we are able to run it on the cloud console without errors. It doesn't happen consistently in the code. Please see if this could help you. @asthamohta
// PARENT
CREATE TABLE table_a (
  table_a_id STRING(36) NOT NULL,
  field_1 STRING(36) NOT NULL,
  ....
  field_100 STRING(36) NOT NULL,
  ...
  field_120 ARRAY<STRING(256)>,
) PRIMARY KEY(table_a_id);

CREATE TABLE table_b (
  table_a_id STRING(36) NOT NULL,
  table_b_id STRING(36) NOT NULL,
  field_1
  ...
  field_30
) PRIMARY KEY(table_a_id, table_b_id),
  INTERLEAVE IN PARENT table_a ON DELETE CASCADE;

CREATE TABLE table_c (
  table_a_id STRING(36) NOT NULL,
  table_c_id STRING(36) NOT NULL,
  field_1
  ...
  field_20 ARRAY<STRING(256)>
) PRIMARY KEY(table_a, table_c),
  INTERLEAVE IN PARENT table_a ON DELETE CASCADE;

CREATE TABLE table_d (
  table_a_id STRING(36) NOT NULL,
  table_d_id STRING(36) NOT NULL,
  field_1
  ...
  field_20
) PRIMARY KEY(table_a_id, table_d_id),
  INTERLEAVE IN PARENT table_a ON DELETE CASCADE;

Hi @tallguys. We haven't been able to replicate your issue exactly and hence can't test it. We have tried deploying a solution to this branch: fixForPartialResultSet  . Could you try running your query using this and let us know if it works?

I haven't installed the new version package yet. I can't replicate it on our testing envrourment and can't do the test on production. @asthamohta

@tallguys you can install the library using
npm install git://github.com/googleapis/nodejs-spanner.git#fixForPartialResultSet  --save
and then simply run the query by connecting to the database in a new js file using:
const instanceId = 'my-instance';
const databaseId = 'my-database';
const projectId = 'my-project-id';
// Imports the Google Cloud Spanner client library
const {Spanner} = require('@google-cloud/spanner');
// Instantiates a client
const spanner = new Spanner({
projectId: projectId,
});
// Gets a reference to a Cloud Spanner instance and database
const instance = spanner.instance(instanceId);
const database = instance.database(databaseId);
// Logic for running query

I see, but I can't replicate it either. 😂 Could you release a stable version then I can run on the production? @asthamohta

Thanks for your patience. We were able to replicate the issue and the solution works. Will merge the changes today. 😊

@asthamohta Thanks. Please let me know if we publish the new package. I can't wait to try. :D

The new version is out. Let me know if it works for you. Thanks


Add support for retrieving specific versions of credentials

Suggested solution for https://github.com/roylines/node-credstash/issues/9.

Used the available options construct to pass version
If options.version is passed, add an extra filter for the DynamoDB column
Credstash uses a special padded string for version data

Also, I added support for AWS region, as the JS SDK doesn't pull that by default from the environment. This makes development from the CLI a bit easier. I didn't DRY/modularize because we only instantiate AWS in two places.
We probably want to update test case scenarios to include the passing of a {version: 1}.
I'm uncertain if this boggles any of the existing version handling logic (this is my first JS project), but it works perfectly with my local use case.

Hmm I just noticed that this whole PR is a (inferior) dupe of a subset of https://github.com/roylines/node-credstash/pull/12.


Slack error reporting

We would like to add error email reporting. Django has this nicely built-in so it's only a matter of configuration.

[x] Add error reporting config - Django docs
[x] Add sendgrid smtp email option
[ ] Study option to set as Slack instead of email - https://github.com/lamby/django-slack
[ ] Add manual email reports for non-intrusive error handlers (aka internal error such as sendgrid)

Also, we need manual reporting for some errors we rather keep internal:

http://stackoverflow.com/questions/29392281/manually-trigger-django-email-error-report

Added in production settings. I need to add it to the project (without the STMP users and password)

Nop, email is good


Get Funnotate linkout on genes with no gene family assignment

The gene linkouts include Funnotate on this record, but there is no gene family assignment. One gets an uninteresting page from Funnotate.
aesev.CIAT22838.gnm1.ann1.Ae0000010 (Ae0000010) Aeschynomene evenia CIAT22838
Unknown protein
location: aesev.CIAT22838.gnm1.Unknown:4299-8942 (1) (supercontig)
gene family: None
Expected behavior: Funnotate linkout is not provided for genes without gene family assignment.

I'm not sure there's any way for the linkout service to know this, unless it were to ask another system (e.g. intermine) about it (but how should linkout service know that a link to Funnotate is about gene families anyway?) Linkouts were never supposed to be all that smart about such things. It's kind of obvious in this case because we put the fact that it doesn't have a gene family in the search results, but I don't think we can always guard against hitting uninteresting pages in the targets. An analogous case might be linking to an expression atlas only to find the gene is not expressed. It's a result of some sort that is informative, even if it is boring info. Let me know if I've failed to convince you that I don't need to do real work here...

Yeah, I guess not, you don't actually query the mine to see if a gene family assignment exists. I'm gonna leave this up but flag it as "wontfix" as I still consider it to be a bug from an end user's point of view.

FWIW I've considered whether the linkout service should talk to the mines for other reasons, for example to convert gene ids to protein ids, for cases in which it might be convenient to form links that are based on some related identifier. The older linkout service did consult chado for such things. That said, I think doing id conversions is different than adding logic that requires the linkout service to "know" details about the sites that it's linking to. I guess if we really wanted to we could have the linkout service test the URLs it forms before sending them back and then suppress any that didn't return acceptable HTTP codes, but I'm not sure that's a good idea (just the only way I could think of doing something along these lines that wouldn't involve the linkout service having to have logic that isn't just given in the yaml specs). Open to other ideas if you have any...

We'll let it burble here as "wontfix" for a couple of months. :) We may come up with a simple solution.


Online Initializer produces broken poms, speedment:tool does not work either

There are several issues with using the Initializer to get anything started with speedment.
*1
Go to the online initializer, switch In-memory acceleration to off so the generate button works.
The generated pom file which can be previewed contains atleast 2 invalid lines:
"${speedment.version}" refers to a variable that does not exist. Only speedment.enterprise.version is defined.
speedment.enterprise.version is set to "1.1.7" if in-memory acceleration is off, this version does not exist on the repository URL. "3.1.3", the version set when in-memory acceleration is on, exists.
*2
Running "mvn speedment:tool" with a fixed pom.xml results in "The expected .json-file '...\speedinit\src\main\json\speedment.json' does not exist."
*3
Creating said json and running the command again results in "Execution default-cli of goal com.speedment:speedment-maven-plugin:3.1.3:tool failed: First argument is null"

A very serious issue. We will fix this immediately. Thank you for submitting this.

@AtomicStryker This should now be fixed. Please let us know if you find any other issues with it.


fix: create parent dirs for dist folder if don't exist

fixes #826
there two more places where we still use create_dir instead of create_dir_all here. maybe we want to fix those as well? and ideally have a linting rule to always use create_dir_all instead of create_dir as we already use a mix of both accross the repo.
steps to reproduce

build the project. cargo build
navigate to examples/yew
modify the dist value in examples/yew/Trunk.toml to something like dist = "dist/sub".
run the locally built version of trunk on this directory: ../../target/debug/trunk build

on main you should get the error that parent dir doesn't exists.
on this branch, the parent dir should be created and the build passes.

Thanks for the PR. Makes perfect sense.
I think this could even be improved as create_dir_all will handle a "does already exists" case.
If there are similar cases like that, it would be great to fix them as well in the same PR if you can find the time.


Staking mainnet is not loading

Expected behavior
> hmy governance list-proposal --space dao-mainnet
                       KEY                       |              NAME              |     START DATE      |      END DATE
-------------------------------------------------+--------------------------------+---------------------+----------------------
  QmTzqwz6acqpEExRgSZ49dVa5516sFEJ4iSHJeJ8Xnf3yT | HIP-20 Adding Decimal To The   | 26 Nov 21 17:00 UTC | 10 Dec 21 17:00 UTC
                                                 | Staking Dashboard              |                     |
  QmR3vBGLp1CfoEVL6qKrZTzcEDTfo5a3EmRhRQLSjJNGUv | Validator DAO Election to fill | 29 Nov 21 02:00 UTC | 06 Dec 21 08:00 UTC
                                                 | up a spot                      |                     |
  Qmar414bkQvbjkroAZkhV86Z7iAk28jGMVjcaH7uEe63CE | Validator DAO Elections        | 12 Oct 21 01:00 UTC | 18 Oct 21 07:00 UTC
  QmTy415weDCQd88QBaBYBSW6Ux75JiraMuyjwtSMEaEJBQ | HIP-9: Institute Last Out,     | 06 Oct 21 10:00 UTC | 13 Oct 21 10:00 UTC
                                                 | First In Redelegations for     |                     |
                                                 | Staking                        |                     |
  QmRteYUE2RAXciDJHGefKCNEpwpV6tXwYzhkoXCwtfULD6 | HIP-15: Validator Governance   | 11 Oct 21 14:43 UTC | 25 Oct 21 14:43 UTC
                                                 | Participation Indicator        |                     |
  Qmb5TkfWYo2pUhkuU5F1LdbUJwdRAwpe1pX1pQn9ozYY2N | Validator DAO Charter          | 15 Sep 21 23:39 UTC | 29 Sep 21 23:39 UTC
                                                 | Ratification Vote              |                     |
  QmeyoWEbJ3DSgudcTDW2UQHiU5QqgEAt7GQbYR7vUiedqS | Initial Validator DAO council  | 26 May 21 19:00 UTC | 01 Jun 21 06:59 UTC

Actual behavior
This command errors out in the hmy cli:
> hmy governance list-proposal --space staking-mainnet
commit: v1-71dd586, error: invalid character '<' looking for beginning of value

Also https://gov.harmony.one/#/staking-mainnet has trouble loading.
Steps to reproduce the behavior
> hmy governance list-proposal --space staking-mainnet
commit: v1-71dd586, error: invalid character '<' looking for beginning of value

Visit https://gov.harmony.one/#/staking-mainnet  and see that it hangs

JS console errors:

FYI @givp

Thanks for raising this issue. There seems to be an issue with the data from ipfs for this space. Other spaces are not affected it seems. We are taking a closer look.

@samhsiung this issue has been resolved. Thanks @jhd2best


meningitis and meningoencephalitis

Add new terms:
meningitis (a child of CNS inflammation MP:0006082)
DEF: local accumulation of fluid, plasma proteins, and leukocytes in the protective membranes (meninges) covering the brain and spinal cord, commonly caused by a bacterial or viral infection
SYN: inflammation of the meninges
SYN: meningeal inflammation
SOURCE: https://en.wikipedia.org/wiki/Meningitis
Annotations from J:106592
meningoencephalitis
DEF: local accumulation of fluid, plasma proteins, and leukocytes in the brain and its surrounding protective membranes (meninges)
SYN: encephalomeningitis
SOURCE: https://medical-dictionary.thefreedictionary.com/meningoencephalitis

Added new terms:
meningitis MP:0031110
meningoencephalitis MP:0031111


TypeError: res.body is null

with the commit 12e1081168
If you start the app it will do a POST and a GET job.
userConfig.postConfig data, (err, config) ->

userConfig.getConfig (err, res) ->

i tried to stop the POST job when the GET job return a body.length not null
userConfig.getConfig (err, res) ->

    if res.body[0] is 0
        userConfig.postConfig data, (err, config) ->

unfortunately it firebug me that res in if res.body[0] is 0 is not defined.
Actually this code work if you have already done a POST job.
But, if you start the app for the first time it will be stuck with a callback err TypeError: res.body is null.

fixed with https://github.com/RobyRemzy/cozy-map/pull/10
nb: going server side with [afterStart](https://github.com/RobyRemzy/cozy-map/blob/master/server/config.coffee#L25]


[DO-570] Payment initiation workflow – add intro

@d0rich Please check the correctness of internal links - they refer to items on different hierarchy levels


chore: update ci/cd postgres creds

What?
CI/CD uses default postgres username and password. This change will use a secret username and password.
Why?
Documentation by code - showing how the application uses environment variables for credentials.
Testing/Proof
Github actions

Codecov Report
Base: 79.92% // Head: 51.69% // Decreases project coverage by -28.22% :warning:

Coverage data is based on head (2298ee1) compared to base (d126647).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #21       +/-   ##
===========================================
- Coverage   79.92%   51.69%   -28.23%
===========================================
  Files          19       26        +7
  Lines        1270     6358     +5088
===========================================
+ Hits         1015     3287     +2272
- Misses        255     3071     +2816

Impacted Files
Coverage Δ

apps/server/src/data.rs
32.10% <0.00%> (-67.90%)
:arrow_down:

apps/server/src/lib.rs
37.67% <0.00%> (-62.33%)
:arrow_down:

apps/exporter/src/time.rs
36.67% <0.00%> (-60.20%)
:arrow_down:

apps/server/tests/e2e/bigcommerce/mod.rs
97.12% <0.00%> (ø)

apps/server/tests/e2e/mocks/mod.rs
100.00% <0.00%> (ø)

apps/server/tests/e2e/helpers.rs
97.93% <0.00%> (ø)

apps/server/tests/e2e/widget/analytics.rs
100.00% <0.00%> (ø)

apps/server/tests/e2e/widget/configuration.rs
97.82% <0.00%> (ø)

apps/server/tests/e2e/widget/publish.rs
94.89% <0.00%> (ø)

apps/server/tests/e2e/main.rs
94.11% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Date locale is fine but Date() provides an offset of 8 hours.

Hi,
I am trying to have the exact date. When I print this Date().description(with: .current) it will show in the console this "Saturday, November 16, 2019 at 1:10:12 AM Pacific Standard Time" but if I print the following:
{abs_date='2019-11-16T09:12:51Z', rep_date='2019-11-16T01:12:51-08:00', region={calendar='gregorian', timezone='America/Los_Angeles', locale='en_US'}
  ▿ date : 2019-11-16 09:12:51 +0000
    - timeIntervalSinceReferenceDate : 595588371.396397
  ▿ region : {calendar='gregorian', timezone='America/Los_Angeles', locale='en_US'}
    ▿ calendar : gregorian (current)
      - identifier : gregorian
      - kind : "current"
      ▿ locale : Optional<Locale>
        ▿ some : en_US (current)
          - identifier : "en_US"
          - kind : "current"
      ▿ timeZone : America/Los_Angeles (current)
        - identifier : "America/Los_Angeles"
        - kind : "current"
        ▿ abbreviation : Optional<String>
          - some : "PST"
        - secondsFromGMT : -28800
        - isDaylightSavingTime : false
      - firstWeekday : 1
      - minimumDaysInFirstWeek : 1
  - customFormatter : nil

The data is correct, except the time, it is 1:13 am right now, not 9:13 am.
Please, what is the step to use the date correctly?
Thank you!

Same question here. What's going on?


move docstring

https://github.com/ColumbiaCMB/kid_readout/blob/master/kid_readout/measurement/basic.py#L318
https://github.com/ColumbiaCMB/kid_readout/blob/master/kid_readout/measurement/basic.py#L460
https://github.com/ColumbiaCMB/kid_readout/blob/master/kid_readout/measurement/basic.py#L723
https://github.com/ColumbiaCMB/kid_readout/blob/master/kid_readout/measurement/basic.py#L1111
@danielflanigan having the detailed docstring on __getitem__ is less helpful because you have to artificially type measurement.__getitem__ to see it in ipython/jupyter. The place you want to see the docstring is when you have typed i.e. measurement.sweep()

Fixed by e4e34522012e3f5d2b657f0213c2490c3d68915f


Imports image from object store to PVS

Fixes Issue #386

/retest

Object files available in the bucket can be retrieved using below command.
ibmcloud cos objects --bucket rhcos-powervs-images-au-syd --region au-syd
Using this command we will get all the files in the bucket, on what basis do we have to select the file as there are multiple builds for a version of rhcos.
Is there any other way to retrieve required details?

/retest

Please review this PR @yussufsh @Prajyot-Parab @cs-zhang

/retest

@yussufsh implemented your suggestions. Please review.

@sajauddin could you please update the branch with the latest changes?

IMO, most of the data used here can be derived from the release image itself, somehow we need to find a way to extract the information from release image instead of asking user to feed all these data manually!

As we do not have a proper location from where image file name can be retrieved, we are moving forward with user inputs. Once we find a proper way to fetch details, we will address them with a patch.

IMO, most of the data used here can be derived from the release image itself, somehow we need to find a way to extract the information from release image instead of asking user to feed all these data manually!

@mkumatag As we do not have a proper location from where image file name can be retrieved, we are moving forward with user inputs. Once we find a proper way to fetch details, we will address this request with a patch.

Its fine timebeing but something needs to fixed longterm for sure!


Peng 9789

@CodingKayla Do you think any updates to the examples in the README should be done here?  I try to keep examples there for many of the resources which are available.  I realize all resources aren't documented there but thought to ask.
Thanks!

Merging as folks at my company are wanting this. :)

See #27.  Had to revert since this breaks the tests.  It appears that the create resource does not work:
=== RUN   TestAccSharedFlowDeployment_Updated
u: &url.URL{Scheme:"https", Opaque:"", User:(*url.Userinfo)(nil), Host:"api.enterprise.apigee.com", Path:"/v1/o/zambien1977-trial/environments/test/sharedflows/helloFlow/revisions/1/deployments", RawPath:"", ForceQuery:false, RawQuery:"delay=0&override=false", Fragment:""}
--- FAIL: TestAccSharedFlowDeployment_Updated (0.14s)
    testing.go:538: Step 0 error: Error applying: 1 error(s) occurred:

        * apigee_shared_flow_deployment.helloFlow_deployment: 1 error(s) occurred:

        * apigee_shared_flow_deployment.helloFlow_deployment: [ERROR] resourceSharedFlowDeploymentCreate error deploying: POST https://api.enterprise.apigee.com/v1/o/zambien1977-trial/environments/test/sharedflows/helloFlow/revisions/1/deployments?delay=0&override=false: 404 APIProxy named helloFlow does not exist in organization zambien1977-trial
    testing.go:599: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: Check failed: Shared flow still exists

        State: <no state>

Note, you may create a trial account at Apigee to test with.  That is what I've done to test.  Details of how to run the tests are in the readme.md.

hmm i tested against our apigee, tho with values for our setup. I'll see if I can reproduce this.

@zambien oh we also need https://github.com/zambien/go-apigee-edge/pull/9 merged in for this to fully work

@CodingKayla I did pull that into my workspace but forgot to merge.  I still see the issue that I had added above.   I was able to work around it by making the following changes to the test file in question:
const testAccCheckSharedFlowDeploymentConfigRequired = `
resource "apigee_shared_flow" "helloFlow" {
   name  = "helloFlow"
   bundle       = "test-fixtures/helloFlow_sharedFlow.zip"
   bundle_sha   = "${base64sha256(file("test-fixtures/helloFlow_sharedFlow.zip"))}"
}

resource "apigee_shared_flow_deployment" "helloFlow_deployment" {
   depends_on = ["apigee_shared_flow.helloFlow"]
   shared_flow_name   = "${apigee_shared_flow.helloFlow.name}"
   org          = "zambien-trial"
   env          = "test"
   revision     = "1"
}
`

const testAccCheckSharedFlowDeploymentConfigUpdated = `
resource "apigee_shared_flow" "helloFlow" {
   name  = "helloFlow"
   bundle       = "test-fixtures/helloFlow_sharedFlow.zip"
   bundle_sha   = "${base64sha256(file("test-fixtures/helloFlow_sharedFlow.zip"))}"
}

resource "apigee_shared_flow_deployment" "helloFlow_deployment" {
   depends_on = ["apigee_shared_flow.helloFlow"]
   shared_flow_name   = "${apigee_shared_flow.helloFlow.name}"
   org          = "zambien-trial"
   env          = "test"
   revision     = "1"
   delay		= "2"
   override 	= true
}
`

The reason the test above was failing was that the shared flow didn't exist for the shared flow deployment.  So really, just an issue in the test, not in the actual implementation.
Would you like to include the change above and re-PR?

@zambien absolutely, I'll get one in later this evening

@CodingKayla cool, sounds good.  Thanks!


Modify: OpenJS.NodeJS.LTS version 18.20.3

Checklist for Pull Requests

[X] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot run

@wingetbot run

https://github.com/microsoft/winget-pkgs/pull/157437#issuecomment-2161759006
For some reason that didn't seem to work. I'll rebase.


Auto-match terminal colors with syntax theme

I have an idea to match the terminal's colors with Atom's syntax theme. I'm not sure where to get started, but I know the current way of setting color is slow and unflexible. Maybe setting a "overwrite colors wtih syntax theme" checkbox?
I don't mind helping make a PR, I'm just not sure where to get started.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

A PR would be much appreciated!
Terminal colors are set here: https://github.com/platformio/platformio-atom-ide-terminal/blob/9ac54fbc398ee155286371af1fcef69a71d8d13e/lib/view.coffee#L300-L321
This defines standard ANSI colors You'll have to define all 16 colors for each theme manually (I don't think it's possible to extract the needed colors from theme directly, so manual work is necessary here). You'll also want to define the terminal background color at @terminal.colors[256] (source). I did play with background color recently myself, so I can give you a hint, if you need one.
You can use the atom.themes.onDidChangeActiveThemes() method to get notified when the active themes are changed and then atom.themes.getActiveThemes() to retrieve a list of active themes. Now you know the names of active themes, so you can set configure the terminal colors accordingly.
A list of built-in themes can be found right here. It's probably better to start with support of the built-in themes.
Let me know if you still want to work on this issue or need any help.

Dmytro, I'd like to start with this one! I might submit a PR early and ask for help/feedback. I haven't really done any Atom development yet, so this will be a fun/interesting way to jump in!
Expect a starting PR from me within the next two weeks.

Hey guys, quick update: two weeks turned into TBD. I've got some other side-project stuff I'm working on. I'd like to start this project soon but I don't have a timeline as of right now, but I'll let you know!

Ok guys, I looked into it and it will be fruitless to try and match the terminal colors with the syntax theme since there is no proper convention for labeling colors (e.g. red, blue, yellow) in the less files.
I think it would be best to just close this issue.

Considering #33 and #20 I'd say that there is a demand for this. So I'd leave the issue open and hope that someone else will have a time to implement this at least for built-in themes.

My thought is maybe having a dropdown option for preset themes (matching default themes)?
Or I guess you could write custom functions that convert some of the default themes into the terminal manually?
For me, it only took 30 seconds using the eyedropper to change the colors to my color syntax of choice. But I can see how it would be helpful to have some better default options 😄

Are there some updates regarding this isssue?

💯

I don't know if this is enough for most of you guys, but for me, adding this to styles.less this did the trick:
@import` "syntax-variables";

.platformio-ide-terminal .xterm {
  background-color: @syntax-background-color ;
}

I know that this is not the issue for most of you, but I only use 2 themes (light/dark), so this was enough for me, the catch is: finding the right colors to look nice across both themes (and in my case, windows and linux).

+1 would be nice if ansiColors are automatically set based on theme. meantime for one-dark i add this to my ~/.atom/config.cson;
"platformio-ide-terminal":
    ansiColors:
      normal:
        black: "#282c34"
        blue: "#61afef"
        cyan: "#56b6c2"
        green: "#98c379"
        magenta: "#c678dd"
        red: "#e06c75"
        white: "#abb2bf"
        yellow: "#e5c07b"
      zBright:
        brightBlack: "#454c59"
        brightBlue: "#69bbff"
        brightCyan: "#66d9e8"
        brightGreen: "#b5e890"
        brightMagenta: "#e48aff"
        brightRed: "#ff7a85"
        brightWhite: "#cfd7e6"
        brightYellow: "#ffd68a"
    core: {}
    iconColors:
      blue: "#61afef"
      cyan: "#56b6c2"
      green: "#98c379"
      magenta: "#c678dd"
      orange: "#d19965"
      pink: "#c578dd"
      purple: "#d682f0"
      red: "#df6b75"
      yellow: "#e2c08d"
    style:
      fontFamily: "Droid Sans Mono for Powerline"
      theme: "one-dark"
    toggles:
      selectToCopy: false

How can I add a hexcode colour as the theme?

should be handled by https://github.com/platformio/platformio-atom-ide-terminal/commit/27a4c0460cb453d35b02c8a65ac257ed4d7f0961


Receive "Zsh is not installed" when attempting to install :-)

When attempting to install zsh via curl, receive a message that zsh must be installed?

Ah, I should read closer... Zsh is not installed (assumed it was say oh-my-szh) . My bad, sorry for the noise


Prod: Add GKE maintenance window

https://phabricator.wikimedia.org/T338321
This PR adds a maintenance window for the production GKE cluster, which will prevent surprising node rollover most of the time. Here, times in terraform are defined in UTC.
Proposed time window: "Every monday between 9.00 and 16.00 Berlin time" - This needs agreement with the team before merging.

Sounds good to me! do you think this will apply as is? Did you e.g. test it on staging?

So far I only "planned" this for prod. Let me actually try this on staging.

Aha - in a 32-day window we need to allow 48h total of maintenance time.
So if we want one day, like monday, we would need to increase it to at least 12h.
Or split it to two days of 6h, for example.


feat: add ingress-tls helm chart

Description
This helm chart installs:

cert-manager, which takes care of issuing certificates, renewing them and managing the certificate resources. It can issue certificates from a variety of supported sources, including Let’s Encrypt, HashiCorp Vault, and Venafi as well as private PKI.
A cert-manager Issuer, which represent Certificat Authorities that generate signed certificates. This is a needed piece for making cert-manager to work. By default, a Let's Encrypt Issuer is created.
ingress-nginx, which is an Nginx running as reverse-proxy and behaving as K8s Ingress Controller, listening to the creation of K8s Ingress resources, which are K8s resources that exposes services publicly, and allows configuring TLS.

Means all services deployed to K8s can now use https with auto managed and renewed Let's Encrypt certificates. For example, https://github.com/asyncapi/server-api/pull/25.
cc @magicmatatjahu @derberg @fmvilas

@derberg I would need your approval in order to merge this and install it in AsyncAPI K8s cluster 🙏


Fix list notifications operation on the wrong realm reference

Closes #827

Looks good, but we should probably retarget releases + I had a few questions about the test.

I was already doing the fix in releases, just forgot to target that. I have tried to put some clarifying comments on the concerns.


HDFS-13293. RBF: The RouterRPCServer should transfer client IP via CallerContext to NamenodeRpcServer

…d client ip to NamenodeRpcServer
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
30m 45s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 41s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 45s

trunk passed

+1 :green_heart:
shadedclient
15m 41s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 42s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 59s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 23s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 21s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 34s

the patch passed

+1 :green_heart:
compile
0m 37s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 37s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 32s

the patch passed

-0 :warning:
checkstyle
0m 19s
/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1 :green_heart:
mvnsite
0m 36s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 30s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 52s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
1m 24s

the patch passed

_ Other Tests _

-1 :x:
unit
9m 39s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

86m  8s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.security.token.TestZKDelegationTokenSecretManagerImpl

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2363

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7785ca08b9cb 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4347a5c9556

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/1/testReport/

Max. process+thread count
3599 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Fix checkstyle, failed tests pass locally

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  6s

trunk passed

+1 :green_heart:
compile
0m 47s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 31s

trunk passed

+1 :green_heart:
mvnsite
0m 47s

trunk passed

+1 :green_heart:
shadedclient
16m 23s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m  2s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 29s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 25s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 40s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 40s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 32s

the patch passed

-0 :warning:
checkstyle
0m 20s
/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 56s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 41s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
1m 34s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
10m 11s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 40s

The patch does not generate ASF License warnings.

91m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2363

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 6944466a4ff6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4347a5c9556

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/2/testReport/

Max. process+thread count
3068 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m  3s

trunk passed

+1 :green_heart:
compile
0m 53s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 49s

trunk passed

+1 :green_heart:
shadedclient
18m 33s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 48s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m  3s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 41s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 39s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 44s

the patch passed

+1 :green_heart:
compile
0m 47s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 47s

the patch passed

+1 :green_heart:
compile
0m 39s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 39s

the patch passed

-0 :warning:
checkstyle
0m 21s
/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 41s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
17m 28s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 45s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m  6s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
1m 51s

the patch passed

_ Other Tests _

-1 :x:
unit
13m 59s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 43s

The patch does not generate ASF License warnings.

106m  3s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterRpc

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2363

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 6d1d7495d180 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c9ea344f984

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/3/testReport/

Max. process+thread count
2760 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 14s

trunk passed

+1 :green_heart:
compile
0m 49s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 47s

trunk passed

+1 :green_heart:
shadedclient
16m 31s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 46s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
1m  5s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 29s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m 26s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 37s

the patch passed

+1 :green_heart:
compile
0m 39s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
0m 39s

the patch passed

+1 :green_heart:
compile
0m 34s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
0m 34s

the patch passed

+1 :green_heart:
checkstyle
0m 19s

the patch passed

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m  3s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 39s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
1m 31s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
10m 21s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

90m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2363

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2d4e43bd84ef 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1cfe5916e20

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/4/testReport/

Max. process+thread count
3341 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 30s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
6m 11s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  3s

trunk passed

+1 :green_heart:
compile
19m 44s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
compile
17m  1s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
checkstyle
2m 42s

trunk passed

+1 :green_heart:
mvnsite
2m 22s

trunk passed

+1 :green_heart:
shadedclient
19m 54s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 41s

trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+0 :ok:
spotbugs
1m 25s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 39s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
18m 59s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javac
18m 59s

the patch passed

+1 :green_heart:
compile
16m 58s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
javac
16m 58s

the patch passed

+1 :green_heart:
checkstyle
2m 42s

the patch passed

+1 :green_heart:
mvnsite
2m 19s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 16s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 28s

the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1

+1 :green_heart:
javadoc
2m 44s

the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

+1 :green_heart:
findbugs
3m 50s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 38s

hadoop-common in the patch passed.

-1 :x:
unit
8m 53s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

184m 54s

Reason
Tests

Failed junit tests
hadoop.fs.contract.router.TestRouterHDFSContractRootDirectory

hadoop.fs.contract.router.TestRouterHDFSContractGetFileStatusSecure

hadoop.fs.contract.router.TestRouterHDFSContractRootDirectorySecure

hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

hadoop.fs.contract.router.web.TestRouterWebHDFSContractRootDirectory

hadoop.fs.contract.router.TestRouterHDFSContractGetFileStatus

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2363

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 0f3fa08473c6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / df4006eb813

Default Java
Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/5/testReport/

Max. process+thread count
3339 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2363/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Failed tests are unrelated and pass locally

The filesystem contract test failures are related to HADOOP-17281.

@goiri @aajisaka Thanks for review! Will merge later if no further comments.


Removed unnecessary word

Removed the extra 'for' from line 12.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thanks for the PR @Usinha31, but this has been fixed from a previous merge. We welcome future PR's from you - thanks and happy coding!


Use templates for doc-builidng jobs

This PR updates the jobs for all doc-building related things by using the templates introduced on doc-builder. By putting those once there, we make sure every repo gets the latest fixes on the doc-building github actions :-)
Note: all libraries must share the same docker image for those doc-building jobs. For now, all the one used (huggingface/transformers-doc-builder) contains all extra steps of the datasets install for docbuling (mainly libsndfile) but if in the future some additional steps are necessary on top of pip install -e .[dev], this docker image will need to be updated with the extra deps.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

You can ignore the CI failures btw, they're unrelated to this PR


Master is broken

I'm trying to build ixblue_ins_driver, but seems that since #10 the package is broken (ros ci is failling). I'm receiving the following error:
error: ‘class ixblue_stdbin_decoder::StdBinDecoder’ has no member named ‘parseNextFrame’
                 while(parser.parseNextFrame())

Hi @caioaamaral
Thank you for reporting the issue.
A new feature as recently been merged in the std_bin_decoder package, breaking the current API.
A new release in on its way to the buildfarm.
#10 allow to make use of this new API.
In the meantime, the CI that are using the released packaged are failing, which is normal. But the CI using the master branches directly are OK.
So you can either use the released version from apt.
Or if you prefer to build this driver from source, uninstall the std_bin_decoder package and use the latest version from the repo directly. It can now be used directly in your ROS workspace as a regular package with catkin_make_isolated or catkin tools.
Sorry for the inconvenience.

Thank you for your fast answer.
I was using ixblue_ins_stdbin_driver as a vc package, but the ixblue_stdbin_decoder is being installed by rosdep as a system dependency, so indeed I do not have this new release as it is still waiting for the approve at buildfarm. I'll revert my local branch to the previous commit until the ixblue_stdbin_decoder's new release is available.
You may close this issue, thanks for the help.

is there already an ixblue_ins_stdbin_driver kinetic release on the way with the current update (I mean #10)?

Not yet, I am waiting for https://github.com/ros/rosdistro/pull/27323 to be merged before triggering the release for Kinetic.
But in a few days it should be out. Then we will have to wait for the next Kinetic sync from OpenRobotics but it should happen before the end of the month I guess.

@caioaamaral The 0.1.5 version has been released on Kinetic: https://discourse.ros.org/t/new-packages-for-kinetic-kame-2020-11-24/17545

@romainreignier Thanks for the update :smiley:


Expanding connections in OE doesn't show firewall dialogs

Azure Data Studio Version: Insiders
OS Version: Windows 11

Steps to Reproduce:

Connect to an Azure SQL
Remove whitelisted IP to trigger firewall prompt
Reload ADS and expand server node or right click > Manage (does fail to show dialog intermittently)

Expected:
User is prompted to add firewall rule.
Actual:
Log shows error occurred, but user doesn't get prompted to add IP to firewall.

Other observations:

Adding new connection - shows firewall dialog.

Closing as not reproducible in stable networks, happens likely due to network flakiness and fallback to whitelisted IP.


ISSUE: "Error setting up entry FrontDoor for keymaster"

Describe the bug
Fresh install, getting the following error when installing the integration
Environment (please complete the following information):

OS: HassOS
Type of system that HA is running on: HA Blue
Home Assistant version: 2022.6.3
Hassio
Component version: 0.0.80
Z-Wave integration name: zwave_js
Lock make and model: Kwikset SmartCode 916

Logs
Logger: homeassistant.config_entries
Source: helpers/config_validation.py:541
First occurred: 12:13:06 PM (1 occurrences)
Last logged: 12:13:06 PM

Error setting up entry FrontDoor for keymaster
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 339, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/config/custom_components/keymaster/__init__.py", line 267, in async_setup_entry
    await hass.services.async_call(
  File "/usr/src/homeassistant/homeassistant/core.py", line 1704, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1747, in _execute_service
    await self._hass.async_add_executor_job(
  File "/usr/local/lib/python3.9/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/config/custom_components/keymaster/__init__.py", line 243, in _generate_package
    generate_package_files(hass, name)
  File "/config/custom_components/keymaster/services.py", line 284, in generate_package_files
    if reload_package_platforms(hass):
  File "/config/custom_components/keymaster/helpers.py", line 391, in reload_package_platforms
    return asyncio.run_coroutine_threadsafe(
  File "/usr/local/lib/python3.9/concurrent/futures/_base.py", line 446, in result
    return self.__get_result()
  File "/usr/local/lib/python3.9/concurrent/futures/_base.py", line 391, in __get_result
    raise self._exception
  File "/config/custom_components/keymaster/helpers.py", line 409, in async_reload_package_platforms
    await hass.services.async_call(domain, SERVICE_RELOAD, blocking=True)
  File "/usr/src/homeassistant/homeassistant/core.py", line 1704, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1741, in _execute_service
    await cast(Callable[[ServiceCall], Awaitable[None]], handler.job.target)(
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 750, in admin_handler
    await result
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 844, in execute_service
    await self._service_func(service_call)
  File "/usr/src/homeassistant/homeassistant/components/automation/__init__.py", line 270, in reload_service_handler
    if (conf := await component.async_prepare_reload()) is None:
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 281, in async_prepare_reload
    conf = await conf_util.async_hass_config_yaml(self.hass)
  File "/usr/src/homeassistant/homeassistant/config.py", line 354, in async_hass_config_yaml
    await merge_packages_config(hass, config, core_config.get(CONF_PACKAGES, {}))
  File "/usr/src/homeassistant/homeassistant/config.py", line 713, in merge_packages_config
    PACKAGES_CONFIG_SCHEMA(packages)
  File "/usr/src/homeassistant/homeassistant/helpers/config_validation.py", line 541, in verify
    return cast(dict, schema(value))
  File "/usr/local/lib/python3.9/site-packages/voluptuous/schema_builder.py", line 272, in __call__
    return self._compiled([], data)
  File "/usr/local/lib/python3.9/site-packages/voluptuous/schema_builder.py", line 595, in validate_dict
    return base_validate(path, iteritems(data), out)
  File "/usr/local/lib/python3.9/site-packages/voluptuous/schema_builder.py", line 433, in validate_mapping
    raise er.MultipleInvalid(errors)
voluptuous.error.MultipleInvalid: expected a dictionary for dictionary value @ data['automation']

What does your package config look like in your configuration.yaml file?
homeassistant:
  packages: !include_dir_named packages

Is what we're expecting.

Yes, I have that --


[Event Request] Codeunit 7500- "Item Attribute Management" - OnBeforeDeleteCategoryItemsAttributeValueMapping

Hello,
Could you please add an event as following into DeleteCategoryItemsAttributeValueMapping procedure:
    procedure DeleteCategoryItemsAttributeValueMapping(var TempItemAttributeValueToRemove: Record "Item Attribute Value" temporary; CategoryCode: Code[20])
    var
        Item: Record Item;
        ItemCategory: Record "Item Category";
        ItemAttributeValueMapping: Record "Item Attribute Value Mapping";
        ItemAttributeValue: Record "Item Attribute Value";
        IsHandled: Boolean;
    begin
        //>>New Event
        IsHandled := false;
        OnBeforeDeleteCategoryItemsAttributeValueMapping(TempItemAttributeValueToRemove, CategoryCode, IsHandled);
        if IsHandled then
            exit;
        //<<New Event

        Item.SetRange("Item Category Code", CategoryCode);
        if Item.FindSet() then
            repeat
                DeleteItemAttributeValueMappingWithTriggerOption(Item, TempItemAttributeValueToRemove, false);
            until Item.Next() = 0;

Event:
    [IntegrationEvent(false, false)]
    local procedure OnBeforeDeleteCategoryItemsAttributeValueMapping(var TempItemAttributeValueToRemove: Record "Item Attribute Value" temporary; CategoryCode: Code[20]; var IsHandled: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 48699.

Hello @JesperSchulz ,
We didn't found yet in any versions of BC.
Could You tell when will arrive?
Thx for in advance.
BR,
Laszlo

The change should be out with 21.2.


Include a "General Syntax" section at the start of each notebook

It is really helpful to see the general syntax before getting into examples and details. If this is not shown, students have to infer the general syntax.
See Introducing Functions.

I'm not sure about this. General syntax is in the core Python documentation, and is not as accessible to beginners as specific examples. I'm certainly not sure that it belongs at the beginning of each notebook.


mlang Has for Java

Continuation of pull-request mlang.Has from a previous fork.
Our discussion regarding testing for empty string and array:
Adam: I don't think we should compare the output of toString() as that may require building strings we don't need which is slow
Joel: Testing for an empty array is not straightforward. Testing for an array can be accomplished with 'value.getClass().isArray()' or 'instanceof Type[]', but then to get the length, it needs to be cast or you have to know the Type. How would you like proceed?
Adam: We can use getClass().isArray() && java.lang.reflect.Array.getLength(value)
https://docs.oracle.com/javase/7/docs/api/java/lang/reflect/Array.html#getLength(java.lang.Object)

Do we need to know if it's an array or not if we add .has() as a method to Property and then let polymorphism figure it out for us by having Array properties have a different implementation than non-array properties?

Yes, .has() on Property would simplify things.
The test for empty array was ensuring the Java Has was consistent with the javascript Has, so both would benefit.

Backtick multiline string example: https://github.com/foam-framework/foam2/blob/3bac563915e2d031b859d8687c8c5ab0742c39e2/src/foam/core/Slot.js#L22

OK, so we are converting all generated java code to use backticks?

You can use regular quoted strings if it all fits on one line, but ES6's new multi-line backquoteed strings: fblah blah blah prevent the need for using the function() {/* blah
blah */} hack. Unless you're targetting IE9, but even then, you can run the code through an ES6 transpiler for the production build.


Use sudo to run chown in init.sh of openstackclient

cephadm creates a key for the user used to deploy ceph in OSP17. This the cloud-admin user does not have permissions to change the ownership of this file in the next restart and the init container fails with:
+ chown -R cloud-admin: /home/cloud-admin/.ssh
chown: changing ownership of '/home/cloud-admin/.ssh/foo': Operation not permitted

For now run the chown using sudo until we figure out other options.

/cherry-pick v1.3.x


add latest dataset metadata to feed response

Summary:
Issue: https://github.com/MobilityData/mobility-feed-api/issues/66
Expected behavior:
New dataset columns should be visible from boh /gtfs_feeds and /gtfs_feeds/{id} endpoints

Updated the database and all referenced places based on the request at https://github.com/MobilityData/mobility-feed-api/issues/66#issuecomment-1733928274
Though I don't see any mention of GtfsDataset's in populate_db.py

@aronza The error with the tests is also in other branches. I think it was introduced into main between yesterday and now

Yep, I've tried debugging it but only found the issue with environment variables not being set correctly. It wasn't enough to fix the ImportError though


pkgclean.sh: POUDRIERE_BUILD_TYPE: parameter not set

Prerequisites

☑ Have you checked for an existing issue describing your problem?
☑ Are you running the latest version?
☑ Is your ports tree recent?
☑ Is your FreeBSD Host on a supported release?

Describe the bug
poudriere pkgclean behaves somewhat strangely where, reportedly, no packages exist.
root@mowa219-gjp4-hello-060-vm:~ # poudriere pkgclean -A -n -j 12
[00:00:00] Cleaning in previously failed build directory
[00:00:00] No packages exist for 12-default
[: -gt: unexpected operator
[: -gt: unexpected operator
[: -gt: unexpected operator
/usr/local/share/poudriere/pkgclean.sh: POUDRIERE_BUILD_TYPE: parameter not set
root@mowa219-gjp4-hello-060-vm:~ #

How to reproduce

poudriere pkgclean -A -n -j 12

Expected behavior

dry run removal of all packages (or, as observed above, a message that no packages exist) without messages about unexpected operators and non-set parameters

Environment

Host OS: FreeBSD 12.2-RELEASE-p10
Jail OS: FreeBSD 12.2-RELEASE-p10
Browser: not applicable
Poudriere Version: poudriere-devel-<IP_ADDRESS>10907_1
Ports branch and revision: I can't remember how to get this information, but the tree is up-to-date.

Additional context
I observed this behaviour with pkgclean whilst trying to troubleshoot poudriere bulk operations that neither build, nor fetch packages. Related typescript:
typescript, poudriere bulk.txt
Re: poudriere-bulk(8): pkg package missing | The FreeBSD Forums removal of ⋯/.building seemed to work around the poudriere bulk issue with FreeBSD 14.0-CURRENT but not with FreeBSD 12.2-RELEASE-p10. (I'm somewhat confused, sorry.)

I forget which commit fixed this but a recent -devel update definitely does.


Tests: Integration Tests

For complete models, ensure behaviour is correct between implementations based on some aggregate properties.
e.g. For a pedestrian model with the same inputs, a change to the spatial partitioning should not effect the average time taken for individuals to reach their destination, beyond floating point related error(s)

This issue should address a single example (circles) and as new examples are added each should have a integration test


raidboss: timeline netregex for ew startsusing

Done by running #5977.
A few backslash escapes were found which are listed in a PR comment below.

-7.9 "--sync--" StartsUsing { id: "8259", source: "Pand\u00e6monium" } window 15,15
+7.9 "--sync--" StartsUsing { id: "8259", source: "Pand\\u00e6monium" } window 15,15
-9.1 "--sync--" StartsUsing { id: "82A5", source: "Pand\u00e6monium" } window 15,15
+9.1 "--sync--" StartsUsing { id: "82A5", source: "Pand\\u00e6monium" } window 15,15


Make test output neater

@stelmo  let's organize the julia Test workarounds/improvements here
we have:

[x] a testset that isn't brutally verbose
[ ] it defaults sanely to the existing test sets
[x] a @test macro that fails with a better error description than just the plain unsubstituted expression (I might just copy it from https://github.com/JuliaLang/julia/pull/49788 for now)

Codecov Report
Patch coverage: 54.54% and project coverage change: -1.75 :warning:

Comparison is base (9c7b9d4) 80.43% compared to head (866e371) 78.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   80.43%   78.68%   -1.75%
==========================================
  Files          20       20
  Lines         593      610      +17
==========================================
+ Hits          477      480       +3
- Misses        116      130      +14

Impacted Files
Coverage Δ

src/common.jl
37.50% <33.33%> (-51.39%)
:arrow_down:

src/frog/report.jl
90.76% <100.00%> (+6.26%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Issue using another port instead of 5000

I couldn't use port 5000 because it was already in use so I changed it to 5003, but I can't access it and when I look at the logs it says it's binding to port <IP_ADDRESS>:5000. Is there a config file or something I need to edit if I want to use a different port like this? Running on a Synology NAS.

+1

i had the same issue. using traefik with labels in docker-compose, in wireguard-ui service helps me.

The app supports listening to a custom port. If you run it from the binary, add -bind-address <IP_ADDRESS>:5003 arg for example.
You can also set it via BIND_ADDRESS environment variable if you use container.


After launching to heroku, local app with flask run or heroku start broken

After I launched last night I went to back to my local development and tried  registering a new user. When I did, the following trace snippit is occured.
File "/Users/richardkhillah/Developer/levelup/app/models/models.py", line 112, in __init__
    self.follow(self)
  File "/Users/richardkhillah/Developer/levelup/app/models/models.py", line 207, in follow
    if not self.is_following(user):
  File "/Users/richardkhillah/Developer/levelup/app/models/models.py", line 226, in is_following
    followed_id=user.id).first() is not None
  File "/Users/richardkhillah/Developer/levelup/venv/lib/python3.7/site-packages/sqlalchemy/orm/query.py", line 1897, in filter_by
    return self.filter(*clauses)
  File "<string>", line 2, in filter

  File "/Users/richardkhillah/Developer/levelup/venv/lib/python3.7/site-packages/sqlalchemy/orm/base.py", line 224, in generate
    self = args[0]._clone()
  File "/Users/richardkhillah/Developer/levelup/venv/lib/python3.7/site-packages/sqlalchemy/orm/dynamic.py", line 349, in _clone
    % (orm_util.instance_str(instance), self.attr.key)
sqlalchemy.orm.exc.DetachedInstanceError: Parent instance <User at 0x10df53160> is not bound to a Session, and no contextual session is established; lazy load operation of attribute 'followed' cannot proceed (Background on this error at: http://sqlalche.me/e/bhk3)

Nothing in the auth module changed between development and deployment, so I'm confused what's going on.
Locally, I'm using Posgtres (if that's helpful at all)

Did anything change at all? Did you upgrade any packages, like maybe SQLAlchemy?

Thank you for responding. Many of the dependencies are upgraded. I ran my version under flasky_venv (loaded from the flasky requirements) and reproduced the same error.
I take that to mean there is a bug elsewhere and I'm not seeing it. Would you happen to know other causes of this error so I might direct my attention to seeking those out?
I don't imagine you'd want to look at the source code but if you do it is here.

Fixed the issue with self follow. It was due to a naming inconsistency on my part. I'll close and comment.


Hello, Startup should appear on the page with individual blog entries

These get the most traffic, but Hello, Startup does not show up anywhere on them.

Fixed.


feat: dio client interceptor

Added Dio Client interception

@jeanplevesque I still haven't received any change requests yet!

@jeanplevesque I still haven't received any change requests yet!

I haven't had time to check yet. I'll try to look soon.

I'm taking over this feature. I'm closing this PR in favor on this one #7


Remove .rollupcache folder from npm package

I'm submitting a bug report

Library Version:
1.3.3

Please tell us about your environment:

Operating System:
Windows 10

Node Version:
8.12.0

NPM Version:
6.4.1

JSPM OR Webpack AND Version
webpack 4.29.6

Browser:
all

Language:
TypeScript 3.2.2

Current behavior:
The npm package contains a folder named .rollupcache, with subfolders and files. This causes on Windows a windows maximum path length exceeded when deleting.
See https://registry.npmjs.org/aurelia-validation/-/aurelia-validation-1.3.3.tgz
Expected/desired behavior:
Don't include the .rollupcache folder. It was not included in 1.3.1 version and previous ones.
See https://registry.npmjs.org/aurelia-validation/-/aurelia-validation-1.3.1.tgz
Also occurs in aurelia-dialog (https://github.com/aurelia/dialog/issues/370).

What is the expected behavior?

I expect to not have a windows maximum path length exceeded when deleting as in versions 1.3.1 and previous.

What is the motivation / use case for changing the behavior?

The motivation is to not have a windows maximum path length exceeded when deleting as in versions 1.3.1 and previous and reduce package size.

@CedricMalfreytBL Thanks for filing this.
cc @EisenbergEffect doh, I missed this

No problem ^^


Migrate UIViewLazyList to CollectionView

A first pass at converting this into a CollectionView. It's in a decent place, but there are a few more things to be hammered out:
I put in some logs to illustrate some of the issues here, particularly with the "window" of viewport items not keeping up with the scrolling of the collection view.
🟤 – Redwood bindings
🟢 – CollectionView datasource
🔵 – Viewport Changes
🔴 – Out of range errors
https://github.com/cashapp/redwood/assets/465849/ed1528db-626d-4787-a03d-20987bea6b07

This is ready to merge and works with placeholders as well
https://github.com/cashapp/redwood/assets/465849/ec5a58f9-9e75-4033-8f4b-71bf786c45fb

Using ChangeListener to determine when to call collectionView.reloadData() is perfect
Previously, we were removing the this.view on the cell, which was a problem because that could be referencing a view that was already moved to another cell. Instead, we're just blowing away the contentViews subviews on prepare for reuse.


labels extraction not seem to be working

Hi!
I got following stream_exporter.yaml
metrics:
  - name: pdu_connection_est
    kind: counter
    pattern: "Communications established"
  - name: pdu_connection_lost
    kind: counter
    pattern: "(?P<ip>[0-9]+.[0-9]+.[0-9]+.[0-9]+).*Communications lost"

Way to start
./stream_exporter -input.type syslog -input.syslog.listenaddr <IP_ADDRESS>:9999 -input.syslog.listenfamily udp

My go verison:
go version go1.9.2 linux/amd64

Data sample
14:27:37.444626 IP <IP_ADDRESS>.52234 > <IP_ADDRESS>.9999: UDP, length 73
<EMAIL_ADDRESS>......
'..Q..<8>Feb 16 14:10:01 <IP_ADDRESS> Switched Rack PDU: Communications lost.

The problem is that metric pdu_connection_lost didn't appear in /metrics page
# HELP pdu_connection_est pdu_connection_est
# TYPE pdu_connection_est counter
pdu_connection_est 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="1e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="3.981072e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="1.5848934269184e-05"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="6.309574844888889e-05"} 2
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="0.000251188717468915"} 2
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="+Inf"} 2
stream_exporter_line_processing_duration_seconds_sum{metric="pdu_connection_est"} 8.153e-05
stream_exporter_line_processing_duration_seconds_count{metric="pdu_connection_est"} 2
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="1e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="3.981072e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="1.5848934269184e-05"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="6.309574844888889e-05"} 2
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="0.000251188717468915"} 2
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="+Inf"} 2
stream_exporter_line_processing_duration_seconds_sum{metric="pdu_connection_lost"} 0.000107829
stream_exporter_line_processing_duration_seconds_count{metric="pdu_connection_lost"} 2

I tried different types of regular expressions, but still no difference.

Hi!
Thanks for reporting!
I would guess this happens due to different versions of the syslog messages. It seems the syslog messages is not normalized the way I thought by the library I'm using.
Only the body of the log is passed to the parser. However, the name of field carrying the body differs with the different implementations, so for rfc3164, the name is content, while it is message for rfc5424...
As a workaround, if you can get your syslog client to send messages in rfc3164 format, that should work. I'll try to come up with a patch that fixes the underlying issue.

Hm, well. As far as I can see it's already in rfc3164(I personally don't much familiar with this RFC, but log samples in Examples section looks pretty close to sample I see in my tcpdump).

Hm, ok, that is odd then... In my testing with your configuration and sample data, it worked fine when I forced the logger to use rfc3164, but not otherwise.
Could you try the attached version? That should both handle the different versions better, as well as give some log output if it cannot figure it out.
stream_exporter.zip

Thanks!
I tried to poke in your stream_exporter binary with forced rfc3164, here it goes:
./stream_exporter -input.type syslog -input.syslog.listenaddr <IP_ADDRESS>:9999 -input.syslog.listenfamily udp -input.syslog.format rfc3164 -log.level debug
INFO[0000] Syslog server started listening at <IP_ADDRESS>:9999  source="syslog.go:91"
INFO[0000] Serving metrics on :9178/metrics              source="exporter.go:116"

BTW, I didn't see any additional output. Here md5sum just in case
md5sum stream_exporter
baaaa2cd1eb2e645c3d35480a902c6eb  stream_exporter

Unfortunately, I didn't see any changes. May be you interesting - before poking into socket /metric looks like:
curl -s localhost:9178/metrics | grep pdu
# HELP pdu_connection_est pdu_connection_est
# TYPE pdu_connection_est counter
pdu_connection_est 0

After sending <8>Feb 16 16:44:47 <IP_ADDRESS> Switched Rack PDU: Communications lost. it changed to
 curl -s localhost:9178/metrics | grep pdu
# HELP pdu_connection_est pdu_connection_est
# TYPE pdu_connection_est counter
pdu_connection_est 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="1e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="3.981072e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="1.5848934269184e-05"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="6.309574844888889e-05"} 1
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="0.000251188717468915"} 1
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="+Inf"} 1
stream_exporter_line_processing_duration_seconds_sum{metric="pdu_connection_est"} 5.2645e-05
stream_exporter_line_processing_duration_seconds_count{metric="pdu_connection_est"} 1
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="1e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="3.981072e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="1.5848934269184e-05"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="6.309574844888889e-05"} 1
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="0.000251188717468915"} 1
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="+Inf"} 1
stream_exporter_line_processing_duration_seconds_sum{metric="pdu_connection_lost"} 6.3073e-05
stream_exporter_line_processing_duration_seconds_count{metric="pdu_connection_lost"} 1

BTW, it may be interesting to view in hexdump of my query:
17:18:35.447220 IP <IP_ADDRESS>.52234 > <IP_ADDRESS>.9999: UDP, length 73
	0x0000:  4500 0065 0047 0000 4011 e2a6 c0a8 0abc<EMAIL_ADDRESS>	0x0010:  c0a8 0b8e cc0a 270f 0051 0000 3c38 3e46  ......'..Q..<8>F
	0x0020:  6562 2031 3620 3137 3a30 303a 3539 2031  eb.16.17:00:59.1
	0x0030:  3932 2e31 3638 2e31 302e 3138 3820 5377  <IP_ADDRESS>.Sw
	0x0040:  6974 6368 6564 2052 6163 6b20 5044 553a  itched.Rack.PDU:
	0x0050:  2043 6f6d 6d75 6e69 6361 7469 6f6e 7320  .Communications.
	0x0060:  6c6f 7374 2e                             lost.

Ok, so if there was no output, then it should at least have been recognized (I only added logging if neither the content (rfc3164) or message (rfc5424) fields were set).
Let's add some more logging then... New binary attached!
stream_exporter.zip

Start sequence is the same, no difference in output... Here is /metric after few tries, still no difference :(
curl -s localhost:9178/metrics | grep '^[^#]'
go_gc_duration_seconds{quantile="0"} 0
go_gc_duration_seconds{quantile="0.25"} 0
go_gc_duration_seconds{quantile="0.5"} 0
go_gc_duration_seconds{quantile="0.75"} 0
go_gc_duration_seconds{quantile="1"} 0
go_gc_duration_seconds_sum 0
go_gc_duration_seconds_count 0
go_goroutines 17
go_memstats_alloc_bytes 1.095968e+06
go_memstats_alloc_bytes_total 1.095968e+06
go_memstats_buck_hash_sys_bytes 1.443044e+06
go_memstats_frees_total 989
go_memstats_gc_sys_bytes 169984
go_memstats_heap_alloc_bytes 1.095968e+06
go_memstats_heap_idle_bytes 770048
go_memstats_heap_inuse_bytes 1.851392e+06
go_memstats_heap_objects 10510
go_memstats_heap_released_bytes_total 0
go_memstats_heap_sys_bytes 2.62144e+06
go_memstats_last_gc_time_seconds 0
go_memstats_lookups_total 62
go_memstats_mallocs_total 11499
go_memstats_mcache_inuse_bytes 6944
go_memstats_mcache_sys_bytes 16384
go_memstats_mspan_inuse_bytes 30704
go_memstats_mspan_sys_bytes 32768
go_memstats_next_gc_bytes 4.473924e+06
go_memstats_other_sys_bytes 797716
go_memstats_stack_inuse_bytes 524288
go_memstats_stack_sys_bytes 524288
go_memstats_sys_bytes 5.605624e+06
pdu_connection_est 0
process_cpu_seconds_total 0.02
process_max_fds 1024
process_open_fds 8
process_resident_memory_bytes 1.0850304e+07
process_start_time_seconds 1.51879300124e+09
process_virtual_memory_bytes 2.20758016e+08
stream_exporter_build_info{branch="",goversion="go1.9.2",revision="",version=""} 1
stream_exporter_line_processing_lines_total 0

Hm, you should be getting log output for each syslog message that is processed now... Also, seems odd that stream_exporter_line_processing_lines_total is still zero after a few tries (it hasn't been in your previous dumps). Are you sure that you are sending your test data to the right place?

Oh, my bad. I played with tcp/udp and forgot to switch back to udp. Here it is:
./stream_exporter -input.type syslog -input.syslog.listenaddr <IP_ADDRESS>:9999 -input.syslog.listenfamily udp -input.syslog.format rfc3164 -log.level debug
INFO[0000] Serving metrics on :9178/metrics              source="exporter.go:116"
INFO[0000] Syslog server started listening at <IP_ADDRESS>:9999  source="syslog.go:91"
INFO[0006] Processing syslog RFC-3164 message with content='Rack PDU: Communications lost.'
  source="syslog.go:96"
INFO[0063] Processing syslog RFC-3164 message with content='Rack PDU: Communications lost.'
  source="syslog.go:96"

And /metrics
curl -s localhost:9178/metrics | grep pdu
# HELP pdu_connection_est pdu_connection_est
# TYPE pdu_connection_est counter
pdu_connection_est 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="1e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="3.981072e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="1.5848934269184e-05"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="6.309574844888889e-05"} 1
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="0.000251188717468915"} 2
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_est",le="+Inf"} 2
stream_exporter_line_processing_duration_seconds_sum{metric="pdu_connection_est"} 9.9734e-05
stream_exporter_line_processing_duration_seconds_count{metric="pdu_connection_est"} 2
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="1e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="3.981072e-06"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="1.5848934269184e-05"} 0
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="6.309574844888889e-05"} 1
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="0.000251188717468915"} 2
stream_exporter_line_processing_duration_seconds_bucket{metric="pdu_connection_lost",le="+Inf"} 2
stream_exporter_line_processing_duration_seconds_sum{metric="pdu_connection_lost"} 0.000104533
stream_exporter_line_processing_duration_seconds_count{metric="pdu_connection_lost"} 2

It seems weird that I didn't see an IP address here... I tried to specify one as part of the message and that what I saw:
./stream_exporter -input.type syslog -input.syslog.listenaddr <IP_ADDRESS>:9999 -input.syslog.listenfamily udp -input.syslog.format rfc3164 -log.level debug
INFO[0000] Serving metrics on :9178/metrics              source="exporter.go:116"
INFO[0000] Syslog server started listening at <IP_ADDRESS>:9999  source="syslog.go:91"
INFO[0002] Processing syslog RFC-3164 message with content='witched Rack PDU: Communications lost.'
  source="syslog.go:96"

And here is message I sent from my PDU:
18:52:27.471541 IP <IP_ADDRESS>.52234 > <IP_ADDRESS>.9999: UDP, length 84
<EMAIL_ADDRESS>......
'..\..<8>Feb 16 18:34:51 <IP_ADDRESS> <IP_ADDRESS> witched Rack PDU: Communications lost.

I tried to dig in stream_exporter guts and insert print to see how message from syslog server looks like:
input/syslog.go
 93 ····go func(lineIn syslog.LogPartsChannel) {
 94 ········for parts := range lineIn {
 95             log.Infof("%v", parts)
 96 ············ch <- fmt.Sprintf("%v", parts["content"])
 97 ············/* parts is a map with the following keys:
 98 ············-hostname
 99 ············-tag
...

Here is message itself
INFO[0017] map[content:witched Rack PDU: Communications lost. priority:8 severity:0 client:<IP_ADDRESS>:52234 tls_peer: hostname:<IP_ADDRESS> tag:<IP_ADDRESS> timestamp:2018-02-16 19:28:02 +0000 UTC facility:1]  source="syslog.go:95"

Sorry, if it looks ugly I'm not very familiar with go syntax :(
I think it would be great if stream_exporter made prometheus label from "client" filed by default, because obviously one always want to know who sent a message to log server.

I was able to fix my problem by addind "hostname" field to syslog server output
--- a/input/syslog.go
+++ b/input/syslog.go
@@ -92,7 +92,7 @@ func (input SyslogInput) StartStream(ch chan<- string) {

        go func(lineIn syslog.LogPartsChannel) {
                for parts := range lineIn {
-                       ch <- fmt.Sprintf("%v", parts["content"])
+                       ch <- fmt.Sprintf("%v %v", parts["hostname"], parts["content"])
                        /* parts is a map with the following keys:
                        -hostname
                        -tag

I could make a PR if you'd like.

Ah, it was not part of the message - that explains it not matching :) I misunderstood the original post then - I thought the tcpdump format was what you actually syslog:ed...
So, as you might have seen in the comments there, there should be some way to choose the fields you want, but I wasn't sure what people would want. Would a format-string be good for you, or do you have other ideas for how it'd be most useful for you?
Simply adding the client is probably not good enough, generally, since a lot of people redirect to it via rules on the local machine.

Well, speaking of problem I'm trying to solve. We have a bunch of APC rack-mount PDUs which we trying to monitor. The only SNMP monitoring wasn't enough since it not show all events happening in system, such as continuous messages about reestablishing connection between internal PDU NMC and hardware monitoring which could indicate a failure inside PDU.
My point is to extract a log severity number(since we don't know what else messages PDU could send to us) and IP address(or hostname). That should be enough to find a problem PDU and set up monitoring.

diff --git a/input/syslog.go b/input/syslog.go
index 90d1f4e..eb07b5c 100644
--- a/input/syslog.go
+++ b/input/syslog.go
@@ -92,7 +92,7 @@ func (input SyslogInput) StartStream(ch chan<- string) {

        go func(lineIn syslog.LogPartsChannel) {
                for parts := range lineIn {
-                       ch <- fmt.Sprintf("%v", parts["content"])
+                       ch <- fmt.Sprintf("%v %v %v", parts["severity"], parts["hostname"], parts["content"])
                        /* parts is a map with the following keys:
                        -hostname
                        -tag

This patch completely satisfies me, looks crappy though. I'd suggest to pass whole syslog line as it is - in one string. It's more convenient and predictable for user which wants to take control over all fields of log line.

Ok, thanks for the explanation of your use-case! I cannot remember the exact reason now, but there was some weird things in the full syslog line that was why I initially just supplied the body part.
I'll have to dig into it again and see if I can find out what it was. Otherwise, I agree that getting the full data is best.


Download vscode in China  is very slow, again

I have 200M internet bandwidth
however download vscode, the speed is under 20K per second.
wget https://packages.microsoft.com/config/rhel/7/packages-microsoft-prod.rpm
wget shows that address resolved to <IP_ADDRESS>, is this a correct address for China users ?
ping this address show that:
[nexus@devopsnexus ~]$ ping packages.microsoft.com
PING csd-apt-eas-d-4.eastasia.cloudapp.azure.com (<IP_ADDRESS>) 56(84) bytes of data.

It seems eastasia means HongKong ?  Does server in HK limit speed for mainland ?
csd-apt-eas-d-1  csd-apt-eas-d-2 csd-apt-eas-d-3 also tried, the fastest is at 100K~150K.
offical updates in 2017 April claims china download has been improved 300x faster.
Now slow again ?
Download the windows version is even slower, about 5K per second.

tried another time, address changed to <IP_ADDRESS>, but still slow.

tried again, csd-apt-eas-d-3.eastasia.cloudapp.azure.com (<IP_ADDRESS>) still slow

tried again, csd-apt-eas-d-2.eastasia.cloudapp.azure.com (<IP_ADDRESS>) now get around 100K, but still not satisfied.

look this page: https://azure.microsoft.com/en-us/global-infrastructure/services/?regions=china-non-regional,china-east,china-east-2,china-north,china-north-2&products=all
any one know which product I should to check ?

This is the RPM repo, not our CDN. I'm not aware of any specific China work for those repos.

see this: azure china regions and products
any ms insider can tell which azure product provide vscode downloading service? CDN ?
sadly CDN is listed in china no-regional, does that mean using global CDN,which bring us to HK server ?

I'm live in Taiwan,  update.code.visualstudio.com also redirect to vscode.cdn.azure.cn, this cdn is very slow and easy to stop transmission. It make vscode remote ssh block in update server stage every time.

Same issue while download VSCode updates in Mainland China,  msecnd.net is so slow to connect that cause some request timeout cases.

May not just be China - I'm in New Zealand, and downloading VSCodeUserSetup-x64-1.49.3.exe from https://code.visualstudio.com/download took about 20minutes, plus it timed out once and I had to retry. I have fibre 100mbps internet and am plugged in via gigabit ethernet.
VSCode no longer auto updates since 1.49.1 as it times out.

If you're still having issues with msecnd.net in China please create a new issue. The OP's problem was about package.microsoft.com

I have the same issue in Indonesia

I have the same issue in China

same problem

If you're still having issues with msecnd.net in China please create a new issue. The OP's problem was about package.microsoft.com


"check-process.rb -p amonagent" failing

amonagent appears to be sending bad check data to the amon server:
[~]# getent group amon
amon:x:397:
[~]# grep "amon" /etc/passwd
amon:x:995:397::/etc/opt/amon:/bin/false
amonagent:x:994:994::/etc/opt/amonagent:/bin/false
[~]# gem install sensu-plugins-process-checks
[~]# su -g amon -c "check-process.rb -p amonagent"
CheckProcess OK: Found 1 matching processes; cmd /amonagent/
[~]# su -s /bin/bash amon
bash-4.2$ whoami
amon
bash-4.2$ check-process.rb -p amonagent
CheckProcess OK: Found 1 matching processes; cmd /amonagent/

However when I go into the amon dashboard all amonagent checks are failing, with:
CheckProcess CRITICAL: Found 0 matching processes; cmd /amonagent/

I should also point out I am only seeing this issue with amonagent.

@beardedeagle Can you run this one through the agent with amonagent -test-plugin=checks

@martinrusev:
~]# amonagent -test-plugin=checks
[{"name":"","command":"check-process.rb -p amon","exit_code":0,"output":"CheckProcess OK: Found 7 matching processes; cmd /amon/\n","error":""} {"name":"","command":"check-process.rb -p nginx","exit_code":0,"output":"CheckProcess OK: Found 5 matching processes; cmd /nginx/\n","error":""} {"name":"","command":"check-process.rb -p mongod","exit_code":0,"output":"CheckProcess OK: Found 1 matching processes; cmd /mongod/\n","error":""} {"name":"","command":"check-process.rb -p amonagent","exit_code":0,"output":"CheckProcess OK: Found 1 matching processes; cmd /amonagent/\n","error":""}]

@beardedeagle  And what about this command  su -g amonagent -c "check-process.rb -p amonagent"

@martinrusev more of the same:
[~]# su -g amonagent -c "check-process.rb -p amonagent"
CheckProcess OK: Found 1 matching processes; cmd /amonagent/


Your code is very useful but I think some changing here in your code for your code is very Effective.

This Music Player Application is using core java & OOP based Project for to simple beginner is very Useful. IN this way, beginner strong your own core java & OOP concept. This code is Enough  for beginner.

LGTM
Thank you for contributing 🎉


BackendListener: Allow implementations to get sample_variables

Deepak Shetty (Bug 57962):
Most listeners allow variables to be saved using sample_variables in jmeter.properties. However there seems to be no way to do the same in implementations of the BackendListener interface. Maybe the SampleResult class should also have a copy of the variable values or the interface method should have a copy of the variables object.
OS: All
Duplicates:

https://github.com/apache/jmeter/issues/4112

Any updates on this?


WIP: Volume Plugins

For now, only the skeleton which we use to contact individual plugins. The bits that actually connect to Libpod are going to be exceedingly difficult to get right, given the volumes only "sort of" exist in Libpod and the database (primary management is delegated elsewhere, which is something that was definitely not in mind we we originally wrote Libpod).

@mheon You still working on this?

Less actively - I'm switching over to APIv2 to unblock Brent and Jhon
On Sat, Dec 28, 2019, 07:10 Daniel J Walsh<EMAIL_ADDRESS>wrote:

@mheon https://github.com/mheon You still working on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/4548?email_source=notifications&email_token=AB3AOCBS7PS3OI7OKQE4HMLQ246ZZA5CNFSM4JQJI3JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHYIM3I#issuecomment-569411181,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3AOCC3LFIWV6OWAW6UEFDQ246ZZANCNFSM4JQJI3JA
.

Guys, any progress on this? The lack of NFS volumes blocks us from deploying our ABAP systems.

NFS volumes are a separate issues and have been working for a while (Podman 1.7 or 1.8, I forget which)

Oh, yeah, sorry, I had old information from colleagues of mine and I didn't bother to re-test.

Closing in favor of #8357


Manual solar system generation

Add a static method to Planet for rocky planets, and another method for gas giants.  Since Planet::evaluate() is a public method, the user can evaluate the planet on the spot.


volatility: add feature: zoom

References
https://vega.github.io/vega/examples/zoomable-scatter-plot/

This seems like a really good idea for q2-vizard.


feature: extend cri apis for get envs

Signed-off-by: Starnop<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
The CRI query container information interface adds the output of the environment variables, and returns the envs  of the container in the ContainerStatus interface
Ⅱ. Does this pull request fix one issue?

None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Done.
Ⅳ. Describe how to verify it

Synchronize changes to the proto file of cri-tools.
Use command crictl inspect to view the container's environment variables.

Ⅴ. Special notes for reviews
None.

Codecov Report

Merging #2163 into master will increase coverage by 0.08%.
The diff coverage is 100%.

 :)

LGTM


base prop not respected

The order should be defaults -> context -> props for all values. Gridand Layout no longer honor the base prop if passed directly

Closed by https://github.com/obartra/reflex/pull/334


"Course Select" and "Vehicle Restrict" options dont do anything on non-default settings.

Closed in #730 and #731.