How to get body of the response in onResourceReceived

Expected behavior
I would like to get the body of the Post Method after submit form.
Actual behavior
The body is empty in onResourceReceived for that POST request.
Any help on this issue? Thanks
Environment

OS: MacOS
Node version (node -v): v8.9.4
package version:

It would be great if you show some code.

Hi Amir,
I've tried another solution to detect new page is loaded instead of get the "body" in response.
But now i'm stuck at the submit form (ASP.NET), i called the submit form but can not received the expected result, The website is using "multipart/form-data" to POST data.
There is no button submit, it only have <input type = "image"...> to submit form.
Here is the HTML code:
<form name="aspnetForm" method="post" action="ApplicationForm.aspx" onsubmit="javascript:return WebForm_OnSubmit();" id="aspnetForm" enctype="multipart/form-data"> ...       <input type="image" name="PlaceHolderMain$imgOk" id="PlaceHolderMain_imgOk" src="/images/ok-button-25px.png" onclick="hideMyParent();WebForm_DoPostBackWithOptions(new WebForm_PostBackOptions("PlaceHolderMain$imgOk", "", true, "", "", false, false))" style="border-width:0px;border:none !important;" />
I tried these steps:

call click() of PlaceHolderMain$imgOk but it only send the form Request not multipart/form-data.
call submit form $("#aspnetForm").submit(); but the result is not correct because it's missing 2 parameter: PlaceHolderMain$imgOk.x and PlaceHolderMain$imgOk.y.

This is my code:
`await page.evaluate(function() {
$("#aspnetForm").submit();
});
console.log ('submit Form trigger')
             setTimeout(
                 async function() {
                     const pageContent = await page.property('content');
                         console.log('load new html');

                         //render only Form rectangle
                         var formClipRect = await page.evaluate(function(element) {
                             return document.getElementById(element).getBoundingClientRect();
                         }, 'Div1');
                         console.log('formClipRect = ' + formClipRect);

                         // generate PDF
                        // page.property('clipRect', {left: formClipRect.left, top: formClipRect.top,  width: formClipRect.width, height: formClipRect.height}).then(async function() {
                         var pic = await page.render('/Users/admin/Desktop/Captcha/form.pdf');
                         console.log('pic Frm = ' + pic);

                         //await instance.exit()
                     // });
                 },
            20000);

`
Please help me. I tried many solution but still not work. Maybe i have a mistake somewhere.
Thanks for your help.

It's going to be really hard for me to help you since I don't have any context. I am not sure how to help unless you ask a more specific question. Something I can reproduce.

Sorry for bad explaination.
My context is auto populate the data into the form then submit.
I can populate data to element successfully, but when i call submit, it's not work.
On the website, after fill in the data, the site show the popup and  i must to click on the OK button then the site redirect to another page. As the flow, when clicking on the OK button, it will trigger the submit form action, but i found the page source and can not see any form submit on that, so i have to call form.submit() manual to submit but not success. I think it it related to the embedded script on the site which i did not inject them to phantom. That is why i open another issue to ask about the injectJs.


Ignore vulns example

Added example script to ignore vulns across all projects

Reviewed together over zoom session with Rob.


Infix conjuctions are not commutative

Conjuction is commutative in OWL, but not in Scowl. Consider:
scala> import org.phenoscape.scowl._

import org.phenoscape.scowl._

scala>
scala> val a = Class("a")
a: org.semanticweb.owlapi.model.OWLClass = <a>

scala> val b = Class("b")
b: org.semanticweb.owlapi.model.OWLClass = <b>

scala> val c = Class("c")
c: org.semanticweb.owlapi.model.OWLClass = <c>

scala> a and b and c
res0: org.semanticweb.owlapi.model.OWLObjectIntersectionOf = ObjectIntersectionOf(<a> <b> <c>)

scala> a and (b and c)
res1: org.semanticweb.owlapi.model.OWLObjectIntersectionOf = ObjectIntersectionOf(<a> ObjectIntersectionOf(<b> <c>))

scala> (b and c) and a
res2: org.semanticweb.owlapi.model.OWLObjectIntersectionOf = ObjectIntersectionOf(<a> <b> <c>)

All of these results make sense except for the last which should return
ObjectIntersectionOf(<a> ObjectIntersectionOf(<b> <c>)) I think.
I think this is caused bc2d369 which addresses #3 unfortunately.
Just playing with Scowl and Scala. Very nice piece of work (Scowl that is,
Scala I will reserve judgement on for the moment)

Thanks for the report! In the spirit of #3 I would be inclined to change a and (b and c) to return ObjectIntersectionOf(<a> <b> <c>). I don't think there is a way to distinguish a and b and c from (a and b) and c in the code being called, since the parentheses just match the normal Scala order of operations. Does this sound okay for the "Manchester" syntax? The functional style is still available for creating nested intersections of unions.

shrugs. Six to one, half a dozen to the other. You trading off the gain in commutativity for the loss of non-associativity.
Can you not overload the and method to deal specifically with an OWLObjectIntersection to not use asConjunctSet. I guess that would work but would break A and B and C and D.
I don't have this problem in tawny, cause I use prefix notation.  But then I can't do A and B or C so nicely.


Consolidate generate-release-tarballs.go and generate-tarball.go

Summary
generate-release-tarballs.go is no more relevant after 1.8. We should consolidate the subcommand of single mode and release mode and only based on generate-tarball.go
Urgency
Low

Already consolidated, this issue is not valid anymore. Please reopen if find still valid and useful


"Key not present in Dictionary" when executing CD command

I get the following error, although the command still seems to work:
Error detected while processing function nerdtree#ui_glue#invokeKeyMap..71..70..nerdtree#ui_glue#chRootCwd:
line    7:
E716: Key not present in Dictionary: path.str()
E15: Invalid expression: cwd.str() == g:NERDTreeFileNode.GetRootForTab().path.str()

I am using the Cygwin version of Vim:
$ vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jun 22 2014 14:31:17)
Included patches: 1-335
Compiled by<EMAIL_ADDRESS>Huge version without GUI.  Features included (+) or not (-):
+acl             +farsi           +mouse_netterm   +syntax
+arabic          +file_in_path    +mouse_sgr       +tag_binary
+autocmd         +find_in_path    -mouse_sysmouse  +tag_old_static
-balloon_eval    +float           +mouse_urxvt     -tag_any_white
-browse          +folding         +mouse_xterm     -tcl
++builtin_terms  -footer          +multi_byte      +terminfo
+byte_offset     +fork()          +multi_lang      +termresponse
+cindent         +gettext         -mzscheme        +textobjects
-clientserver    -hangul_input    +netbeans_intg   +title
+clipboard       +iconv           +path_extra      -toolbar
+cmdline_compl   +insert_expand   +perl/dyn        +user_commands
+cmdline_hist    +jumplist        +persistent_undo +vertsplit
+cmdline_info    +keymap          +postscript      +virtualedit
+comments        +langmap         +printer         +visual
+conceal         +libcall         +profile         +visualextra
+cryptv          +linebreak       +python/dyn      +viminfo
+cscope          +lispindent      +python3/dyn     +vreplace
+cursorbind      +listcmds        +quickfix        +wildignore
+cursorshape     +localmap        +reltime         +wildmenu
+dialog_con      +lua/dyn         +rightleft       +windows
+diff            +menu            +ruby/dyn        +writebackup
+digraphs        +mksession       +scrollbind      -X11
-dnd             +modify_fname    +signs           -xfontset
-ebcdic          +mouse           +smartindent     -xim
+emacs_tags      -mouseshape      -sniff           -xsmp
+eval            +mouse_dec       +startuptime     -xterm_clipboard
+ex_extra        -mouse_gpm       +statusline      -xterm_save
+extra_search    -mouse_jsbterm   -sun_workshop    -xpm
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
  fall-back for $VIM: "/etc"
 f-b for $VIMRUNTIME: "/usr/share/vim/vim74"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -I/usr/include/ncursesw  -ggdb -O2 -pipe -Wimplicit-function-declaration -fdebug-prefix-map=/usr/src/ports/vim/vim-7.4.335-1.x86_64/build=/usr/src/debug/vim-7.4.335-1 -fdebug-prefix-map=/usr/src/ports/vim/vim-7.4.335-1.x86_64/src/vim74=/usr/src/debug/vim-7.4.335-1 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L.   -L/usr/local/lib -Wl,--as-needed -o vim.exe        -lm -lelf    -lncursesw -liconv -lintl   -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--enable-auto-image-base -fstack-protector  -L/usr/lib/perl5/5.14/x86_64-cygwin-threads/CORE -lperl -ldl -lcrypt

same error here

@mikedfunk are you also using cygwin? if so, are you able to reproduce this in gvim for windows? I'm guessing this is issue is only occurring in cygwin but want to be sure. Can you give me exact steps to reproduce it?

No, I am on mac. I get this when I call :NERDTreeFind occasionally. I'm thinking it might have to do with  changes to the contents of the directory that contains the file I'm on when calling this command.

Any updates on this one? I'm getting the same error.
I try to CD after cding into a specified directory and...
Error detected while processing function nerdtree#ui_glue#invokeKeyMap..72..71..nerdtree#ui_glue#chRootCwd:
line    7:
E716: Key not present in Dictionary: path.str()
E15: Invalid expression: cwd.str() == g:NERDTreeFileNode.GetRootForTab().path.str()

A bit more info...
I'm using dhruvasagar's fork of tpopes/vim-vinegar to make nerdtree behave like a split explorer vs a project drawer for more vim-like workflow. Tried vifm but vim integration was awkward and netrw keeps randomly setting files to nomodifiable or whatever.
Point is I moved away from nerdtree because it made manipulating the FS too slow compared to using like finder. But that's super annoying going back an forth so I tried netrw and same story there, the ncurses program vifm showed real promise until I tried integrating it with actual vim. Switching between vim and vifm isn't ideal. So I'm back to nerdtree and deciding to use as a split explorer. Hopefully this provides a nice blend of all the worlds.

Anyone solved this problem? I'm having a similar issue here when I try to use CD after cd.
OS: Ubuntu 14.04
$ vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jan  2 2014 19:39:32)
Included patches: 1-52
Modified by<EMAIL_ADDRESS>Compiled by buildd@

Error:
Error detected while processing function nerdtree#ui_glue#invokeKeyMap..75..74..nerdtree#ui_glue#chRootCwd:
line    7:
E716: Key not present in Dictionary: path.str()
E15: Invalid expression: cwd.str() == g:NERDTreeFileNode.GetRootForTab().path.str()
Press ENTER or type command to continue

Any updates on this? I'm still getting it in Vim8.

I'm getting this error after deleting files in neovim

I cannot reproduce this error given the scenarios presented above. If someone could show the steps needed to produce a repeatable error, that would help greatly.

Seems like the code at
https://github.com/scrooloose/nerdtree/blob/183bb53485f32f3be5e920cedc657dfc9c6d7eda/lib/nerdtree/tree_file_node.vim#L10
And
https://github.com/scrooloose/nerdtree/blob/68313ef0f512897d63aef55909847759123ce918/autoload/nerdtree/ui_glue.vim#L153
Are relevant?
My error is saying that path.str() is not present in the g:NERDTreeFileNode dictionary.

That is the code I'm looking at too, but I need to know what conditions cause the error. As I said, this issue is not happening for me.

ATTENTION: We need exact steps to reproduce this error in order to fix it.  We need the version if Vim you're using, the system you're running, and an example directory hierarchy to work with.  Anything else is just wasting time.

@lifecrisis I've had this issue in all versions of vim I've tried since posting.
That apparently includes Vim7,8 and NeoVim.
I'm on OSX Sierra & High Sierra.
Example Directory Hierarchy might be:
folderA/
  .keep
folderB/
  .keep

Open NerdTree and CD between the directories and the error should appear.
Here's my existing config
Plug 'scrooloose/nerdtree' ", { 'on': 'NERDTreeToggle' }
Plug 'dhruvasagar/vim-vinegar', { 'as': 'nerd-vinegar' }

let NERDTreeChDirMode = 0 " Don't change Vim's CWD
let NERDTreeHijackNetrw = 1
let NERDTreeHighlightCursorline = 1
let NERDTreeIgnore = ['DS_Store']
let NERDTreeMouseMode = 3 " Single click any node to open.
let NERDTreeShowHidden = 1
let NERDTreeShowLineNumbers = 1
let NERDTreeCascadeOpenSingleChildDir = 0
let NERDTreeAutoDeleteBuffer = 1

I can't reproduce this anywhere.  We'll leave this open until someone can provide well-defined context for this bug.

No one has given any useful feedback or provided the precise steps that we need to reproduce this issue.  I'll close this.  If your problem persists, please open a new issue with exact instructions to reproduce the bug.


Two finger scroll becomes laggy on Surface Book when one or more plug-in's are enabled

I'm having a scroll-lag issue in Visual Code when using two-finger scrolling on a Surface Book (i7 model) when one or more plug in is enabled.  The more plug-ins I enabled, the greater the lag.
The lag is seen when following these steps:

Scroll down some way in a large piece of code (say 200 lines)
Place two fingers at the lower side of the track pad
Slide two fingers up
The Visual Code UI will not slide immediately
There is a lag and then the sliding begins and snap scrolls

The performance of two finger scroll on Chrome or Edge is far superior.  I searched the usual places on the internet to see if someone else had this issue, but it seems two-finger scrolling has had a number of issues over the years.  I have to rule out the device itself because it works perfectly in other apps that support smooth scrolling.

VSCode Version: 1.17.0
OS Version: Latest Windows 10 Preview build.

Reproduces without extensions:  No  but any extension will slow it down.

I have this issue and I've seen it mentioned in a few other issues.  One solution is to de-maximise, then re-maximise the window.  Not ideal but a workaround until it's fixed!

Duplicate of #13612


feat(size-and-space): apply between stops and negative variables vue3

PR Title
For DT-1142, applying the dialtone's update from DT-1131 and DT-1143.
:hammer_and_wrench: Type Of Change

[ ] Fix
[ ] Feature
[x] Refactoring
[ ] Documentation

:pencil: Checklist

[ ] I have reviewed my changes
[ ] I have added tests
[ ] I have added all relevant documentation
[ ] I have validated components with a screen reader
[ ] I have validated components keyboard navigation
[ ] I have considered the performance impact of my change
[ ] I have checked that my change did not significantly increase bundle size
[ ] I am exporting any new components or constants in the index.js in the component directory
[ ] I am exporting any new components or constants in the index.js in the root

:crystal_ball: Next Steps

:camera: Screenshots / GIFs

:link: Sources

Hmm, seems like Vue2 changes weren't cherry-picked correctly. Only 3 files modified

Resumed cherry-pick, it's been waiting for me to continue for a few days now :P


Snapshot manager

This patch adds a new api to Container that is similar to the Client container, image, and profile manager api. It also adds the use of these new apis to the old snapshot methods on Container, which should no longer be used.

[Current coverage][cc-pull] is 86.59%

Merging [#115][cc-pull] into [master][cc-base-branch] will increase coverage by 2.81%

@@             master       #115   diff @@
==========================================
  Files             8          8
  Lines           333        358    +25
  Methods           0          0
  Messages          0          0
  Branches         46         49     +3
==========================================
+ Hits            279        310    +31
+ Misses           43         34     -9
- Partials         11         14     +3

Powered by Codecov. Last updated by [de3ea62...f22bd24][cc-compare]
[cc-base-branch]: https://codecov.io/gh/lxc/pylxd/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/lxc/pylxd/compare/de3ea62c0b44408c051acabe857b83b342af59e8...f22bd2448a6ee43c4df39335757f49ace8b8990c
[cc-pull]: https://codecov.io/gh/lxc/pylxd/pull/115?src=pr

I think I need to merge #114 into master and expand on those docs before I merge this patch, though a review would still be nice.

lgtm


Please save my Ether on MEW/ENS

Please save my $0.07 of Ether on ENS. (And everyone else's 7 cents.) Could you just check to see if there is already a winning bid and warn the user that revealing their bid would be a waste of 7 cents for a transaction as there's already a higher bid out there? I just revealed several bids, then realized this afterward.

Also note: This only applies to the minimum bid of 0.1 ETH, I think you'd want to execute a reveal no matter what if you bid more, in order to get your money back. (But I'm not sure on that.)

@Arachnid Would love your insights on this one...
@kvhnuke Do you know what is possible / not possible?

Please disregard. I have consulted people who know more than I know on ENS. You'll always want to reveal, even if you only had 0.1 ETH in the game and it costs you 7 cents.


UMA integration not working when building executable with unity 2021 lts

Hi, this addon its not working with latest lts unity editor, it works while you are in the editor, but the built executable its not loading characters.
Ive tried with unity:
2021.3.0f1 (lts) = Not Working
2021.2.17f1      = Working
2020.3.20f1(lts)= Working

Got it working again deleting Vehicle Models under Model Swithching Settings in Animator Character Model Uma (Script) from UmaPlayerCharacterPrefab, surely it was my mistake at something there... still... if i can find some time i will make more tests.


Allow pre-population of Group in training request form

It would be nice to be able to allow a pass through of the group_name in order to pre-populate the form with the appropriate group name. I have a group that would like to open up applications in their organization and then be able to go through a process in conjunction with us to help select the instructors who will be trained.
This feature would allow us to sent out a URL which is something like:
https://amy.software-carpentry.org/workshops/request_training/?id_group_name=Thisisatest
From my read of this stackoverflow topic I think it would be a slight tweak to the View to make it happen.

See also #877.


sdlog2: fix Segfault on Eagle

Since orb_exist doesn't work on the Snapdragon Linux side, we need to do
an additional orb_check after the orb_subscribe_multi, otherwise we copy
garbage.
The segfault was triggered by a count/length information about ESC
packets which lead to access outside the struct in the garbage case.
@LorenzMeier or @bkueng please review.
Fixes #4638.

Cool, thanks!

Can we fix 'orb_exists` on Snappy Linux?

@bkueng That would be nice (and the correct way) but you'll have to read throw all the muorb (krait/adsp) code to understand it all and come up with a fix (or different architecture). I didn't dive too deep yet but also @mcharleb and @jywilson couldn't fix it over night.


[BUG] WARN   | Unable to find any entry files. The extension might be empty

What happened?
I have encountered this bug for a couple of time already. the project works well originally even for a new created project without any new code aded on it, but everytime when the plasmo server idled for a while of time (like 45mins to 1hr), this warn
ing appear when I reload the webpage. Plasmo become unclickable and nothing works even for the default popup.tsx. I have to delete the project and start a new project everytime. May i know is there any solution to solve this? Thanks.

Version
Latest
What OS are you seeing the problem on?
MacOSX
What browsers are you seeing the problem on?
Chrome
Relevant log output
Plasmo v0.86.3
🔴 The Browser Extension Framework
🔵 INFO   | Starting the extension development server...
🟠 WARN   | Unable to find any entry files. The extension might be empty
🔵 INFO   | Loaded environment variables from: []

(OPTIONAL) Contribution

[X] I would like to fix this BUG via a PR

Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

Hi Tommy,
I had the same issue, and tried recreating the project from scratch several times to try to isolate it.
In the end, it's because I had a src directory in the root of my Plasmo directory. By simply renaming this to anything else (even just src-another), it worked.

An additional warning if a src folder is found but no entrypoint would have been helpful, this drove me crazy for a good half hour :)

Hi Tommy,  嗨，汤米，
I had the same issue, and tried recreating the project from scratch several times to try to isolate it.我遇到了同样的问题，并多次尝试从头开始重新创建项目以尝试隔离它。
In the end, it's because I had a src directory in the root of my Plasmo directory. By simply renaming this to anything else (even just src-another), it worked.最后，这是因为我在 Plasmo 目录的根目录中有一个 src 目录。只需将 this 重命名为其他任何内容（甚至只是 src-another），它就可以工作了。


IPv4 field starts with dash

Describe the bug
IPv4 type field visualization starts with dash.

Is it expected? Why does it work like this? I didn't find any specifications ordering to show ip addr with dash.
Appreciate your reply.
Steps to reproduce
select toIPv4('<IP_ADDRESS>')
Expected behaviour
<IP_ADDRESS>
Configuration
Environment

metabase-clickhouse-driver version:
seems like 1.1.7
how can check this, btw?
metabase-clickhouse-driver configuration:
default
Metabase version:
v0.46.6
OS:
CentOS 7

ClickHouse server

ClickHouse Server version:
22.8.14 revision 54460

Also might be worth mentioning.
I'm using mysql to store Metabase config. In metabase.metabase_field table there are multiple fields related to data types. I've tried to manually update some of them ipv4->string to mimic string behavior, but it didn't work either, showing dash anyways.
update metabase_field set base_type='type/Text' where id=53365;
update metabase_field set effective_type='type/Text' where id=53365;
update metabase_field set database_type='String' where id=53365;

IIRC, that's how Java serializes these types by default (see InetAddress.toString).
But it's easy enough to fix so it is less annoying :+1:

@phuntik, fixed in https://github.com/ClickHouse/metabase-clickhouse-driver/releases/tag/1.2.2

Thanks a lot, appreciate!


Portoflio mobile page

What?
Mobile phone menu page for my portoflio.
Why?
To serve as a landing page for users.
How?
Recreated template 1 of the mobile menu options given by Microverse using flexbox.

@codecaiine I had it in the src folder because I thought it could be in any folder. But I just read that it has to be in the root folder.
Instead of "node_modules" can I use "node_modules/"?

Hi @Haywayaheadshot I think your project structure is also a problem. I would like to recommend you have a structure like the one in the screenshot below.  It s makes it confusing like you are working on webpack project but it s just an HTML and CSS project.

If you need any help please tag me again or slack me .

@codecaiine I have made the changes as you mentioned. Could you please take a minute to check before I submit it?

 Please let us slack :+1:

@codecaiine I did not realize my slack app was not on. I am on now


Transport and HTTP SSL not configured on Data Nodes

I created a deployment for 5 data nodes and 2 coordinator nodes.  esHttpCaCertBlob and esTransportCaCertBlob were populated in the template to enable SSL for transport and HTTP traffic.  On the coordinating nodes, I can see that this was successfully enabled.  On the data nodes, however, the .p12 files were created in /etc/elasticsearch/ssl, but the following config is missing from elasticsearch.yml:
xpack.security.http.ssl.enabled: true
xpack.security.http.ssl.keystore.path: /etc/elasticsearch/ssl/elasticsearch-http.p12
xpack.security.http.ssl.truststore.path: /etc/elasticsearch/ssl/elasticsearch-http.p12
xpack.security.transport.ssl.enabled: true
xpack.security.transport.ssl.keystore.path: /etc/elasticsearch/ssl/elasticsearch-transport.p12
xpack.security.transport.ssl.truststore.path: /etc/elasticsearch/ssl/elasticsearch-transport.p12
This config does exist for the coordinating nodes.

Please can you provide

the arm-install.log output for one of the data nodes? This log can be found in /var/log/arm-install.log
the parameters used for the deployment

@ridensnow23 Are you able to provide the above details, so that we can investigate?

I've added the deployment of a coordinating node to the test 1d-0m-0c-ext-tls-klp.json in the 7.5.0 branch and deployed it with
$ git checkout feature/7.5.0
$ npm run release -- --test 1d\-0m\-0c\-ext\-tls\-klp.* --nodestroy

The --nodestroy flag keeps the deployment around after the tests run. I've then ssh'ed into the client and data nodes to check the configuration
$ ssh russ@<kibana public ip>
$ ssh data-0
$ sudo cat /etc/elasticsearch/elasticsearch.yml
cluster.name: "my-azure-cluster"
node.name: "data-0"
path.logs: /var/log/elasticsearch
path.data: /datadisks/disk1/elasticsearch/data
discovery.seed_hosts: ["data-0"]
cluster.initial_master_nodes: ["data-0"]
node.master: true
node.data: true
network.host: [_site_, _local_]
node.max_local_storage_nodes: 1
node.attr.fault_domain: 0
node.attr.update_domain: 0
cluster.routing.allocation.awareness.attributes: fault_domain,update_domain
xpack.license.self_generated.type: trial
xpack.security.enabled: true
xpack.monitoring.collection.enabled: true
bootstrap.memory_lock: true
xpack.security.http.ssl.enabled: true
xpack.security.http.ssl.keystore.path: /etc/elasticsearch/ssl/elasticsearch-http.p12
xpack.security.http.ssl.truststore.path: /etc/elasticsearch/ssl/elasticsearch-http.p12
xpack.security.transport.ssl.enabled: true
xpack.security.transport.ssl.keystore.path: /etc/elasticsearch/ssl/elasticsearch-transport.p12
xpack.security.transport.ssl.truststore.path: /etc/elasticsearch/ssl/elasticsearch-transport.p12

$ ssh client-0
$ sudo cat /etc/elasticsearch/elasticsearch.yml
cluster.name: "my-azure-cluster"
node.name: "client-0"
path.logs: /var/log/elasticsearch
path.data: /var/lib/elasticsearch
discovery.seed_hosts: ["data-0"]
cluster.initial_master_nodes: ["data-0"]
node.master: false
node.data: false
network.host: [_site_, _local_]
node.max_local_storage_nodes: 1
node.attr.fault_domain: 0
node.attr.update_domain: 0
cluster.routing.allocation.awareness.attributes: fault_domain,update_domain
xpack.license.self_generated.type: trial
xpack.security.enabled: true
xpack.monitoring.collection.enabled: true
bootstrap.memory_lock: true
xpack.security.http.ssl.enabled: true
xpack.security.http.ssl.keystore.path: /etc/elasticsearch/ssl/elasticsearch-http.p12
xpack.security.http.ssl.truststore.path: /etc/elasticsearch/ssl/elasticsearch-http.p12
xpack.security.transport.ssl.enabled: true
xpack.security.transport.ssl.keystore.path: /etc/elasticsearch/ssl/elasticsearch-transport.p12
xpack.security.transport.ssl.truststore.path: /etc/elasticsearch/ssl/elasticsearch-transport.p12

I can't replicate the issue; the elasticsearch.yml configuration is the same on both data and coordinating nodes.
I'm going to close this issue, but if you can provide a reproduction, please feel free to reopen to discuss 👍


g

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 206b5eae-0d27-4afc-ac55-b3c1705096db
Version Independent ID: f3763810-1049-afbe-f279-fa72ea36a99c
Content: Compiler Error CS0161
Content Source: docs/csharp/misc/cs0161.md
Product: dotnet-csharp
Technology: csharp-diagnostics
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Hi @RatGaya
Was there more you wanted to add here? If so, can you edit the issue and add more details.


where is compare_methylation

Hi there, I cannot find compare_methylation.py in the scripts. May I know where it is ?

Hi there, I downloaded the example and it is there. But when I ran it, an error message appeared (But I checked it with vim, there is no print writing like this):
File "/home/hujie/software/nanopolish/scripts/compare_methylation.py", line 84
print "key\tdepth_1\tfrequency_1\tdepth_2\tfrequency_2"
^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print("key\tdepth_1\tfrequency_1\tdepth_2\tfrequency_2")?

Hi I found the error mentioned in the original compare_methylation.py and revised it, together with another print error

Yes, that script was written for python2. I'll update it to be compatible
with python3.
Jared
On Sun, May 13, 2018 at 6:16 PM, HuJane<EMAIL_ADDRESS>wrote:

[image: image]
https://user-images.githubusercontent.com/17492179/39973918-89ad9842-5757-11e8-8cd0-8c8e1ce13974.png
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jts/nanopolish/issues/382#issuecomment-388671424, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAXxn_gTjZ44mGpBULTRS9MsEaNNGBQlks5tyNsJgaJpZM4T8QRp
.

I have updated the script in the tutorial to be compatible with python3.


Support from different logging message per threads/processes

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.86%. Comparing base (2837ecd) to head (92f20bf).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #65   +/-   ##
========================================
  Coverage    71.86%   71.86%
========================================
  Files            7        7
  Lines          263      263
========================================
  Hits           189      189
  Misses          74       74

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Changing the twitter logo to X logo in the contact us section

Changing the twitter logo to X logo in the contact us section
@Sanskriti1102 @Krishi1211 Assign this to me under gssoc 2024 ext and hacktoberfest i will work on fixing this issue the other issue is related to footer only i will fix the logo on contact us section

@Sanskriti1102 Can you assign this to me it is in the contact us section not in footer.

twitter icon needs to be changed in footer and we feature on section can you do both?

Okay will do in footer and in we feature both

@Krishi1211 assign this to me


two extensions on the marketplace

Thanks for the extensions.
There are two extensions on the marketplace which is a bit confusing.

0.0.2: https://marketplace.visualstudio.com/items?itemName=yukiuuh.vscode-modern-fortran-formatter
0.0.3: https://marketplace.visualstudio.com/items?itemName=yukiuuh2936.vscode-modern-fortran-formatter

Thanks @JHenneberg .
Both Visual Studio Marketplace accounts are mine, but 2. "yukiuuh2936" should be used.

"yukiuuh" is my university SSO account and the account is expired.
So I can't login as "yukiuuh" but the Marketplace account and the extension is still alive...

ok that explains it.


Complex password reports "Invalid password"

Should define a password requirements policy :-)
Attempted to use the following randomly generated 25 character password:
2Y&'*_sy5]/nPwtWb)\EFm&ic
And was presented with "Invalid Password". I'm guessing it probably got hung up on the * or similar input.

Successfully registered using another 25 character password which contained upper/lower/numbers.

There are two things here ...

we don't every tell the user what our password policy is
we should have a more permissive regex on acceptable passwords

I can register with this password ...
2Y&'*_sy5]/nPwtWb)\EFm&ic
But I can't login with the same password, I get an 'invalid password' error.

can you verify again, I can't reproduce an issue

Just verified on Hangout still doesn't work for me. Steps to reproduce ..

Register button
username: whatever, password: 2Y&'*_sy5]/nPwtWb)\EFm&ic
Submitt .... recieved an email, clicked on verificiation link, got to Verified Screen
Login button
username: , password: 2Y&'*_sy5]/nPwtWb)\EFm&ic
Got 'Invalid Password' error on login attempt

This appears to be logic in the the screen itself validating user input before making a rest call.

why can't I register an flowsim account on the webpage you talked above?It always show an unknown error occur, I am almost crazy about this? If my password is invalid， it should inform me of that, so it's not a password problem?what's wrong with this?


Upgrading node-redis version to 4 and redis-adapter to 7.1.0 Failing to Create Client

After upgrading redis version to 4 and redis-adapter to 7.1.0 I am facing the error.
node:internal/errors:464
ErrorCaptureStackTrace(err);
^
TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received type function ([Function (anonymous)])
at new NodeError (node:internal/errors:371:5)
at _write (node:internal/streams/writable:312:13)
at Socket.Writable.write (node:internal/streams/writable:334:10)
 client.on("connect", async function () {
console.log("Redis client connected");
const pubClient = client.duplicate();
await pubClient.connect();

const subClient = client.duplicate();
await subClient.connect();
io.adapter(redisAdapter(pubClient, subClient));
});

The issue was I had legacy mode in the createClient.
constclient = redis.createClient({
legacyMode: true,
url: redis://<host>:<port>
});

OK, I could indeed reproduce the issue with legacyMode set to true. I'm not sure how we could fix this though, the documentation describes the behavior of the classic commands, and not the PUB/SUB ones.
@djaffer have you found something?
Reference: https://github.com/redis/node-redis/blob/master/docs/v3-to-v4.md#legacy-mode

Maybe what you can do is have a legacy mode that auto connects. It is up to you but it was a pain to get this to work.


Better login UX through AJAX

Now that we've stripped the JS/AJAX from the comment login form, we could look at new ways to improve the form's UX with new AJAX.

Looks good to me in multiple browsers — I see a vestigial spinner that I think you said you removed, but that's an easy fix.
Even if we don't think the spinner is necessary because the response time is good, we should disable and grey out the submit button to prevent multiple submissions in the event that it does take a moment.
(When I was testing in IE, I got some browser-related delays, as my Paralells-based virtual PC hung for a second while working on bringing up the native "do you want to save this password" prompt.)

Once we address that, we should ask the gang to test it out.

Very minor UI bug: the textarea is a larger width than the grey area below it on larger screens.

@michellekondou: after I submit a comment, the page reloads so that I'm taken to the top of the article.  Since I want to ensure I submitted my comment, I then need to scroll down to see that my comment exists.  Is there a way to be taken down to my comment after I submit?

@michellekondou and @murtaugh: Is this issue still alive, or did we address everything through the other form updates?

The only thing left to address is scrolling down to the comment after submitting.


Reject negative readings

Purpose
Reject readings with negative values from exchanges.
Checklist

[x] My code follows the style of this project.
[x] The code compiles without warnings.
[x] I have performed a self-review of the changes.
[x] I have documented my code, in particular the intent of the
hard-to-understand areas.
[x] (If necessary) I have updated the CHANGELOG

It would be better to handle this in one place, but it is also fine to handle it as a parse error like it is here.

Yeah, I wouldn't expect it to happen, so I would treat it as a parse error, like if I got something that wasn't a number.
Also we also found a discrepancy between max_rates_saved's environment variable's name and what I had documented/specified in the build script. (Which I just remembered, and fixed by changing the name)


Add collection validation step to all Kabanero build / dev pipelines

Updates to the collections
See  https://github.com/kabanero-io/kabanero-pipelines/issues/12
Related Issues:
https://github.com/kabanero-io/kabanero-pipelines/issues/12

@smcclem Approved. Do you want me to merge the changes?


Vscode graphql updates

Added a .graphqlrc.yaml file needed for the recommended Graphql extensions to give better Graphql syntax highlighting, auto-completion and go to definition support.

This lived to the end of its lifetime and died


SPFx Page Load: Performance dropped drastically after migrating from adal-angular to msal-browser 2.8.0. My application has multiple webparts in the same solution and needs to access multiple resources

Library

[ ]<EMAIL_ADDRESS>
Framework

[ ] React

Description
Performance dropped drastically after migrating from adal-angular 1.x to msal-browser 2.8.0.
My application has multiple webparts in the same solution and needs to access multiple resources.
Error Message

MSAL Configuration
const msalConfig = {
  auth: {
    authority: `https://login.microsoftonline.com/microsoft.onmicrosoft.com`,
    clientId: config.default.AppSettings.msalClientId,
    redirectUri: window.location.href
  },
  cache: {
    cacheLocation: "localStorage",
    storeAuthStateInCookie: false,
  },
};
// Provide configuration values here.
// For Azure B2C issues, please include your policies.

Reproduction steps
const allScopes = {
  xyzWebAPIScopes: [
    "https://xyz.azurewebsites.net/user_impersonation",
  ],
  graphAPIScopes: [
    "https://graph.microsoft.com/User.Read.All",
    "https://graph.microsoft.com/Presence.Read.All",
  ]
};

export enum msalAPISource {
  Xyz = "https://campuswebapi",
  MSGraph = "https://graph.microsoft.com"
}

const msalConfig = {
  auth: {
    authority: `https://login.microsoftonline.com/abc.onmicrosoft.com`,
    clientId: config.default.AppSettings.msalClientId,
    redirectUri:  window.location.href,
  },
  cache: {
    cacheLocation: "localStorage",
    storeAuthStateInCookie: false,
  },
};

export class WebAPIHelper {
  public userName: any;
  private myMSALObj: PublicClientApplication;
  private accessTokenCommon: any;
  private httpClient: HttpClient;
  private ssoRequest: AuthorizationUrlRequest = {
    scopes: [],
  };

  constructor(wpContext: any, AuthContextCallback?: any, username?: any) {
    this.httpClient = wpContext.httpClient;
    this.userName = username;
    this.myMSALObj = new PublicClientApplication(msalConfig);
    this.myMSALObj
      .handleRedirectPromise()
      .then((tokenResponse) => {
        if (tokenResponse !== null) {
          this.accessTokenCommon = tokenResponse.accessToken;
        } else {
          // In case we would like to directly load data in case of NO redirect:
          const currentAccounts = this.myMSALObj.getAllAccounts();
          this.handleLoggedInUser(currentAccounts);
        }
      })
      .catch((error) => {
        console.log(error);
        return null;
      });
  }

  public GetxyzWebAPI(
    apiSource: APISource,
    apiRelativePath: string,
    jsonbody: string = null
  ): Promise<any> {
    return new Promise<any>(
      (resolve: (result: any) => void, reject: (error: any) => void): void => {
        this.getXyzAPIAccessToken(apiSource).then(
          async (accessToken: string): Promise<void> => {
            let fullAPIUrl: string;
            const requestHeaders: Headers = new Headers();
            requestHeaders.append(
              "User-Agent",
              "NONISV|Microsoft|XyzProjectWebparts/1.0"
            );
            requestHeaders.append(
              "X-ClientService-ClientTag",
              "NONISV|Microsoft|XyzProjectWebparts/1.0"
            );
            requestHeaders.append("Authorization", "Bearer " + accessToken);
            requestHeaders.append("Content-type", "application/json");
            const httpClientOptions: IHttpClientOptions = {
              body: jsonbody,
              headers: requestHeaders,
            };
            try {
              if (apiSource == APISource.MSGraph)
                fullAPIUrl = apiSource + "/" + apiRelativePath;
              else fullAPIUrl = this.getAPIBaseURL(apiSource) + apiRelativePath;
              const response = await this.httpClient.get(
                fullAPIUrl,
                HttpClient.configurations.v1,
                httpClientOptions
              );
              const output = await response.json();
              resolve(output);
            } catch (error) {
              reject(error);
            }
          },
          (error: any): void => {
            reject("token error" + error);
          }
        );
      }
    );
  }

  private getAPIBaseURL(apiSource: string): string {
   if (apiSource.indexOf("https://xyzwebapi") > -1)
      return config.default.AppSettings.WebApiUri + "/api/";
  }

  private getXyzAPIAccessToken(apiSource: APISource): Promise<string> {
    return new Promise<string>(
      async (
        resolve: (accessToken: string) => void,
        reject: (error: any) => void
      ): Promise<void> => {
        try {
          var accessToken = null;
          accessToken = await this.loginForAccessTokenByMSAL(
            allScopes.xyzWebAPIScopes
          );
          if (accessToken) {
            resolve(accessToken);
          } else {
            reject("Couldn't retrieve access token");
          }
        } catch (ex) {
          reject(ex);
        }
      }
    );
  }

  public async GetGraphApi(apiUrl: string) {
    try {
      var accessToken = null;
      accessToken = await this.loginForAccessTokenByMSAL(
        allScopes.graphAPIScopes
      );
      const options = {
        method: "GET",
        headers: {
          Accept: "application/json",
          "Content-type": "application/json",
          Authorization: "Bearer " + accessToken,
        },
      };
      const response = await this.httpClient.get(
        msalAPISource.MSGraph + apiUrl,
        HttpClient.configurations.v1,
        options
      );
      if (apiUrl.indexOf("photo/$value") > -1) {
        return response;
      }
      const responseJson = await response.json();
      return responseJson;
    } catch (err) {
      console.log(err);
      throw err;
    }
  }

  private handleLoggedInUser(currentAccounts: AccountInfo[]) {
    let accountObj = null;
    if (currentAccounts === null && currentAccounts.length === 0) {
      // No user signed in
      return;
    } else if (currentAccounts.length > 1) {
      // More than one user is authenticated, get current one
      accountObj = this.myMSALObj.getAccountByUsername(this.userName);
    } else {
      accountObj = currentAccounts[0];
    }
    if (accountObj !== null) {
      this.acquireAccessToken(this.ssoRequest, accountObj).then(
        (accessToken) => {
          this.accessTokenCommon = accessToken;
          //return this.accessTokenCommon
        }
      );
    }
  }

  private async acquireAccessToken(
    ssoRequest: AuthorizationUrlRequest,
    account: AccountInfo
  ): Promise<string> {
    const accessTokenRequest = {
      scopes: allScopes.graphAPIScopes,
      account: account,
    };
    return this.myMSALObj
      .acquireTokenSilent(accessTokenRequest)
      .then((val) => {
        return val.accessToken;
      })
      .catch((errorinternal) => {
        console.log(errorinternal);
        return null;
      });
  }

  private async loginForAccessTokenByMSAL(specificScope: any): Promise<string> {
    this.ssoRequest.loginHint = this.userName;
    this.ssoRequest.scopes = specificScope;
    return this.myMSALObj
      .ssoSilent(this.ssoRequest)
      .then((response) => {
        return response.accessToken;
      })
      .catch((silentError) => {
        console.log(silentError);
        if (silentError instanceof InteractionRequiredAuthError) {
          return this.myMSALObj
            .loginPopup()
            .then((response) => {
              return response.accessToken;
            })
            .catch((popupError) => {
              if (popupError.message.indexOf("popup_window_error") > -1) {
                // Popups are blocked
                return this.redirectLogin(this.ssoRequest);
              }
            });
        } else {
          return null;
        }
      });
  }

  private redirectLogin(ssoRequest: AuthorizationUrlRequest): Promise<string> {
    try {
      this.myMSALObj.loginRedirect()
        .then(() => {
          return Promise.resolve('');
        });
    } catch (err) {
      console.log(err);
      return null;
    }
  }

// Provide relevant code snippets here.
// For Azure B2C issues, please include your policies.

Expected behavior
Identity Provider

[ ] Azure AD

Browsers/Environment

[ ] Chrome
[ ] Edge

Regression

[ ] Did this behavior work before?
Performance was better while using ADAL

Security
Source

[ ] Internal (Microsoft)

@johnvittneyk It is recommended that SPFx webparts use the built-in auth APIs provided by SPFx, instead of using MSAL.js directly.
Details: https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/guidance/connect-to-api-secured-with-aad#use-the-aadtokenprovider-to-retrieve-access-token
Can you provide details on why you are using MSAL.js directly?

@johnvittneyk It is recommended that SPFx webparts use the built-in auth APIs provided by SPFx, instead of using MSAL.js directly.
Details: https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/guidance/connect-to-api-secured-with-aad#use-the-aadtokenprovider-to-retrieve-access-token
Can you provide details on why you are using MSAL.js directly?

AADHttpClient is allowed now, however web parts need to be isolated and permissions approved by IT (a lengthy process of review and approval). This is not so much of a problem if we are required to do it only once.
The problem we see moving to AADHttpClient in our scenario is making the development cycle potentially requiring multiple IT submission cycles. To avoid that, We are continuing to use MSAL.js directly, that allows completing testing. This is totally the developers' preference. What can be done if we continue to use MSAL wrt Performance in our scenario?

AADHttpClient is allowed now, however web parts need to be isolated and permissions approved by IT (a lengthy process of review and approval). This is not so much of a problem if we are required to do it only once.
The problem we see moving to AADHttpClient in our scenario is making the development cycle potentially requiring multiple IT submission cycles. To avoid that, We are continuing to use MSAL.js directly, that allows completing testing. This is totally the developers' preference. What can be done if we continue to use MSAL wrt Performance in our scenario?

@johnvittneyk We would still strongly recommend that SPFx webparts use the auth APIs provided by Sharepoint, as that is the recommendation from their team.
In regards to your code, I believe the problem is that you are invoking ssoSilent every time you want to acquire a token. ssoSilent is similar to the login APIs, as that it only needs to be called once per page load. Invoking it every time you want to call acquireTokenSilent is unnecessary and will likely result in slower token acquisition, as you observe.

@johnvittneyk We would still strongly recommend that SPFx webparts use the auth APIs provided by Sharepoint, as that is the recommendation from their team.
In regards to your code, I believe the problem is that you are invoking ssoSilent every time you want to acquire a token. ssoSilent is similar to the login APIs, as that it only needs to be called once per page load. Invoking it every time you want to call acquireTokenSilent is unnecessary and will likely result in slower token acquisition, as you observe.

@jasonnutter Let me explain you our scenario, we have multiple resources with different scope, and each time I need to get a new token when a specific scope is required.
Based on this, Is your suggestion still valid?

@jasonnutter Let me explain you our scenario, we have multiple resources with different scope, and each time I need to get a new token when a specific scope is required.
Based on this, Is your suggestion still valid?

@johnvittneyk The refresh token issued to your app after login is capable of acquiring access tokens for multiple resources, so you should not need to invoke ssoSilent each time.

@johnvittneyk The refresh token issued to your app after login is capable of acquiring access tokens for multiple resources, so you should not need to invoke ssoSilent each time.

Implemented the solution as suggested. But there is no big improvement in the performance.
@jasonnutter - Also login method fails to load after clearing the cache or with the poor network.
token error Couldn't retrieve access token

@johnvittneyk If you could post an update snippet of your code (preferably just edit the original post) we can identify where the performance gaps are here.


Wrapper task messes up wrapper script encoding when run with non-utf-8 charset on Windows

We use an additional wrapper task to create wrapper scripts specifically for AWS.
The task is configured like this:
tasks.register('wrapperAWS', Wrapper) {
	distributionUrl = "https://our-aws-cache.org/repo/${gradleDistUrl}"
	distributionSha256Sum = gradleVersionDistributionSha256Sum
	scriptFile = 'gradlew-aws'
	jarFile = 'gradle/wrapper/gradle-wrapper-aws.jar'
}

tasks.named('wrapper', Wrapper).configure {
	distributionUrl = "https://our-internal-chache/repo/${gradleDistUrl}"
	distributionSha256Sum = gradleVersionDistributionSha256Sum

	dependsOn 'wrapperAWS'
}

Expected Behavior
On a windows system with the default encoding set to utf-8 (according to Powershell [System.Text.Encoding]::Default):
This sequence of command should leave the wrapper script unmodified:
Our wrapper script gradlew-aws has been created with
gradlew wrapperAWS -Dfile.encoding=UTF-8

and commited to git.
This command should leave the wrapper script gradlew-aws unmodified:
gradlew cleanWrapperAWS wrapperAWS

Current Behavior
The current behavior when executing above command is that the wrapper-aws script file is modified, since it contains some UTF-8 characters (since gradle 7.x). Those characters are only in comments and don't break anything, but still it is annoying to users to have this file modified in their workspace.
Most people don't set their file.encoding property explicitly. They usually also don't bother to execute the wrapper task, but when you import your project to IntelliJ, it calls the wrapper task, and this in turn depends on wrapperAWS.
Of course, they do not execute the cleanWrapperAWS task explicitly, but it seems like the task is not up-to-date from time to time. Also , some of our users seem to have committed the modified file, which leads to ripple effects all over the place and more users seem to have the problem.
Context
Stopped working when we changed from gradle 6.9.2 to gradle 7.2
In "real life" we only experience this with the additional custom task wrapperAWS, but with
gradlew cleanWrapper wrapper

this can also be reproduced on the default wrapper task.
Possible root cause
StartScriptGenerator#generateUnixScript calls IoActions#writeTextFile(File output, Action<? super BufferedWriter> action). This again uses Charset.defaultCharset().
Instead it should use IoActions#writeTextFile(File output, String encoding, Action<? super BufferedWriter> action) and supply "utf-8" as encoding.
Because the TextResource for the unixScript was explicitly read with UTF-8 encoding in DefaultTemplateBasedStartScriptGenerator.java
Steps to Reproduce
On a windows machine:
gradlew cleanWrapper wrapper

make sure, file.encoding is not set and left at it's "default" value, for me that is windows-1252
I added the following closure to my wrapperAWS task to see the default charset:
	doFirst {
		println "default charset: ${java.nio.charset.Charset.defaultCharset().name()}"
	}

Your Environment
This was on a windows-10 machine with Cygwin, but it was also reproduced on "pure" windows-10 machines from cmd.
As said, the problem seems to appear when importing to IntelliJ, which calls the wrapper task.
PS C:\Users\ronald.brindl> [System.Text.Encoding]::Default

BodyName          : utf-8
EncodingName      : Unicode (UTF-8)
HeaderName        : utf-8
WebName           : utf-8
WindowsCodePage   : 1200
IsBrowserDisplay  : True
IsBrowserSave     : True
IsMailNewsDisplay : True
IsMailNewsSave    : True
IsSingleByte      : False
EncoderFallback   : System.Text.EncoderReplacementFallback
DecoderFallback   : System.Text.DecoderReplacementFallback
IsReadOnly        : True
CodePage          : 65001

Might be related to #18618

(Closed because it's the same issue mentioned above)


Game renders too small on some iOS devices

Godot version
4.0.master (860884bde7)
System information
iOS 16/ macOS Ventura
Issue description
On some devices an exported iOS game (3D/ Vulkan) doesn't scale very well.
Display Settings:

Stretch Mode = viewport
Aspect = expand

On an iPhone 11 and iPhone 11 Pro the game renders fine, but on an iPhone 12 Mini or iPhone 7 Plus I'm getting this result:

Steps to reproduce
Export a game to iOS
Minimal project to reproduce
I tried to also include the exported iOS project, but GitHub doesn't allow uploads above 25MB 😄 So you'll need to export the project (with Debug) and paste in the appended MoltenVK.xcframework.
resolution-bug.zip
MoltenVK.xcframework.zip

Citing CONTRIBUTING.md

On the contributors' end, recreating a test project from scratch takes valuable time that can be saved by uploading a minimal project.

To speed up our work, please upload a minimal project that isolates and reproduces the issue. This is always the best way for us to fix it. We recommend attaching a ZIP file with the minimal project directly to the bug report, by drag and dropping the file in the GitHub edition field. This ensures the file can remain available for a long period of time. Only use third-party file hosts if your ZIP file isn't accepted by GitHub because it's too large.

We recommend always attaching a minimal reproduction project, even if the issue may seem simple to reproduce manually.

Please join a MRP.

@adamscott done ✅

I can't reproduce with on macOS 13.0.1 and iPadOS 16.1.1, so it's might be specific to devices with a smaller screen. Are there any errors/warnings in the Xcode log when running on an affected device?

@bruvzg  Yeah it only occurs on smaller screens. As mentioned in the PR:

On an iPhone 11 and iPhone 11 Pro the game renders fine, but on an iPhone 12 Mini or iPhone 7 Plus I'm getting this result

I didn't spot any errors last time I checked, but I can check again tomorrow

@bruvzg I couldn't spot any interesting error messages. Can I somehow log the screen size Godot gets from iOS? To check if it actually knows the correct screen size.

Update: The screen size and DPI reported by DisplayServer are completely wrong. On an iPhone 12 Mini:
DisplayServer.screen_get_size() returns (750, 1624)
DisplauServer.screen_get_dpi() returns 401
The correct values, for an iPhone 12 Mini, should be (1080, 2340) and 476  (from Apple's website)

2.88000011444092

And DisplayServer.screen_get_usable_rect returns [P: (0, 0), S: (750, 1624)]

Part 1

Fixed dpi in #70022
However this won't fix the initial problem just yet

Part 2:

I realised that DisplayServer.screen_get_scale is completely off
If you turn on Display Zoom in the iOS settings (Settings -> Display& Brightness -> Display Zoom at the very bottom) I'm pretty sure every project will break. Give it a try with any existing Godot app on your iOS device.
Link to screen_get_scale

From StackOverflow:

This is without display zoom. If you enable display zoom, scale remains the same, at 3, since the intermediate buffer is still rendered at 1 point = 3 pixels. But native scale becomes 2.8.

Okay I didn't manage to solve this yet. If someone else could take a look at this I'd be very grateful. Essentially turn on/off the iOS Display Zoom and start debugging the screen_size/scale from there on. (any project)


I get unsatisfying results when reproducing your results!

I got unsatisfying results when trying to reproduce your results!
The following is what I did:
I used the matlab downsample kernel, and I only used the DIV2K as the training dataset . I used the GAN-loss and the RRDB_PSNR_x4.pth pretrained model. In fact, I just clone this repo and modify the path in the train_ESRGAN.json!
The following is my train_ESRGAN.json:
{
"name": "001_RRDB_ESRGAN_x4_DIV2K" //  please remove "debug_" during training
, "use_tb_logger": true
, "model":"srragan"
, "scale": 4
, "gpu_ids": [0]
, "datasets": {
"train": {
"name": "DIV2K"
, "mode": "LRHR"
, "dataroot_HR": "/home/liushuzhi/Desktop/fuxian/superresolution_dataset/DIV2K/DIV2K_train_HR_sub_image"
, "dataroot_LR": "/home/liushuzhi/Desktop/fuxian/superresolution_dataset/DIV2K/DIV2K_train_LR_sub_image"
, "subset_file": null
, "use_shuffle": true
, "n_workers": 8
, "batch_size": 16
, "HR_size": 128
, "use_flip": true
, "use_rot": true
}
, "val": {
"name": "val_set14_part"
, "mode": "LRHR"
, "dataroot_HR": "/home/liushuzhi/Desktop/fuxian/superresolution_dataset/Set14/Set14_raw_image"
, "dataroot_LR": "/home/liushuzhi/Desktop/fuxian/superresolution_dataset/Set14/Set14_LR_image"
}
}
, "path": {
"root": "/home/liushuzhi/Desktop/fuxian/BasicSR-master"
// , "resume_state": "../experiments/debug_002_RRDB_ESRGAN_x4_DIV2K/training_state/16.state"
, "pretrain_model_G": "../experiments/pretrained_models/RRDB_PSNR_x4.pth"
}
, "network_G": {
"which_model_G": "RRDB_net" // RRDB_net | sr_resnet
, "norm_type": null
, "mode": "CNA"
, "nf": 64
, "nb": 23
, "in_nc": 3
, "out_nc": 3
, "gc": 32
, "group": 1
}
, "network_D": {
"which_model_D": "discriminator_vgg_128"
, "norm_type": "batch"
, "act_type": "leakyrelu"
, "mode": "CNA"
, "nf": 64
, "in_nc": 3
}
, "train": {
"lr_G": 1e-4
, "weight_decay_G": 0
, "beta1_G": 0.9
, "lr_D": 1e-4
, "weight_decay_D": 0
, "beta1_D": 0.9
, "lr_scheme": "MultiStepLR"
, "lr_steps": [50000, 100000, 200000, 300000]
, "lr_gamma": 0.5
, "pixel_criterion": "l1"
, "pixel_weight": 1e-2
, "feature_criterion": "l1"
, "feature_weight": 1
, "gan_type": "vanilla"
, "gan_weight": 5e-3

//for wgan-gp
// , "D_update_ratio": 1
// , "D_init_iters": 0
// , "gp_weigth": 10

, "manual_seed": 0
, "niter": 5e5
, "val_freq": 5e3

}
, "logger": {
"print_freq": 200
, "save_checkpoint_freq": 5e3
}
}
The following is what I got:
The visual quality is less satisfying compared with yours!
Your result is:

My result is:

The ground truth is:

As for the PSNR and SSIM, I got PSNR_Y: PSNR: 24.976743 dB; SSIM: 0.673742 when I tested on Set14, but when I tested your model I got PSNR: 24.495635 dB; SSIM: 0.654736.
In the issues you mentioned that the downsampling filter implemented by python is different from the one implemented by matlab. Do you think this may cause my problem? I think your method should work for both two filters! You mentioned that you used more data in your paper while I just used DIV2K. Is this very important? If I used more data, it would take too much time to train!

For me, the results seem OK if you use only DIV2K dataset.
I think the extra gap is from the datasets. Using more data will not increase the time compared with your current settings. Because the training is counted by iterations instead of epochs.
I do not think the filter is the key factor.

I got unsatisfying results when trying to reproduce your results!
The following is what I did:
I used the matlab downsample kernel, and I only used the DIV2K as the training dataset . I used the GAN-loss and the RRDB_PSNR_x4.pth pretrained model. In fact, I just clone this repo and modify the path in the train_ESRGAN.json!
The following is my train_ESRGAN.json:
{
"name": "001_RRDB_ESRGAN_x4_DIV2K" // please remove "debug_" during training
, "use_tb_logger": true
, "model":"srragan"
, "scale": 4
, "gpu_ids": [0]
, "datasets": {
"train": {
"name": "DIV2K"
, "mode": "LRHR"
, "dataroot_HR": "/home/liushuzhi/Desktop/fuxian/superresolution_dataset/DIV2K/DIV2K_train_HR_sub_image"
, "dataroot_LR": "/home/liushuzhi/Desktop/fuxian/superresolution_dataset/DIV2K/DIV2K_train_LR_sub_image"
, "subset_file": null
, "use_shuffle": true
, "n_workers": 8
, "batch_size": 16
, "HR_size": 128
, "use_flip": true
, "use_rot": true
}
, "val": {
"name": "val_set14_part"
, "mode": "LRHR"
, "dataroot_HR": "/home/liushuzhi/Desktop/fuxian/superresolution_dataset/Set14/Set14_raw_image"
, "dataroot_LR": "/home/liushuzhi/Desktop/fuxian/superresolution_dataset/Set14/Set14_LR_image"
}
}
, "path": {
"root": "/home/liushuzhi/Desktop/fuxian/BasicSR-master"
// , "resume_state": "../experiments/debug_002_RRDB_ESRGAN_x4_DIV2K/training_state/16.state"
, "pretrain_model_G": "../experiments/pretrained_models/RRDB_PSNR_x4.pth"
}
, "network_G": {
"which_model_G": "RRDB_net" // RRDB_net | sr_resnet
, "norm_type": null
, "mode": "CNA"
, "nf": 64
, "nb": 23
, "in_nc": 3
, "out_nc": 3
, "gc": 32
, "group": 1
}
, "network_D": {
"which_model_D": "discriminator_vgg_128"
, "norm_type": "batch"
, "act_type": "leakyrelu"
, "mode": "CNA"
, "nf": 64
, "in_nc": 3
}
, "train": {
"lr_G": 1e-4
, "weight_decay_G": 0
, "beta1_G": 0.9
, "lr_D": 1e-4
, "weight_decay_D": 0
, "beta1_D": 0.9
, "lr_scheme": "MultiStepLR"
, "lr_steps": [50000, 100000, 200000, 300000]
, "lr_gamma": 0.5
, "pixel_criterion": "l1"
, "pixel_weight": 1e-2
, "feature_criterion": "l1"
, "feature_weight": 1
, "gan_type": "vanilla"
, "gan_weight": 5e-3

//for wgan-gp
// , "D_update_ratio": 1
// , "D_init_iters": 0
// , "gp_weigth": 10

, "manual_seed": 0
, "niter": 5e5
, "val_freq": 5e3

}
, "logger": {
"print_freq": 200
, "save_checkpoint_freq": 5e3
}
}
The following is what I got:
The visual quality is less satisfying compared with yours!
Your result is:

My result is:

The ground truth is:

As for the PSNR and SSIM, I got PSNR_Y: PSNR: 24.976743 dB; SSIM: 0.673742 when I tested on Set14, but when I tested your model I got PSNR: 24.495635 dB; SSIM: 0.654736.
In the issues you mentioned that the downsampling filter implemented by python is different from the one implemented by matlab. Do you think this may cause my problem? I think your method should work for both two filters! You mentioned that you used more data in your paper while I just used DIV2K. Is this very important? If I used more data, it would take too much time to train!

Hi~How many epochs will roughly Set14(e.g. Monkey image) occur? I approximately trained 5000 epoch. I got the image as follow. Are you the same?

@Feiyu-Zhang

5k is not enough, at least, > 300k.
Your figure indicates there must be something wrong, which is not from inadequate training.

@Feiyu-Zhang

5k is not enough, at least, > 300k.
Your figure indicates there must be something wrong, which is not from inadequate training.

Oh~ There could be a misunderstanding. I mean 5K epochs.
I will check my code.
Thanks!

@Feiyu-Zhang

5k is not enough, at least, > 300k.
Your figure indicates there must be something wrong, which is not from inadequate training.

Oh~ There could be a misunderstanding. I mean 5K epochs.
I will check the code.
Thanks!

I guess @xinntao means 300k iterations at least to produce satisfactory results

@Feiyu-Zhang

5k is not enough, at least, > 300k.
Your figure indicates there must be something wrong, which is not from inadequate training.

Oh~ There could be a misunderstanding. I mean 5K epochs.
I will check the code.
Thanks!

I guess @xinntao means 300k iterations at least to produce satisfactory results


Testing for Reselling with Royalties Fails

Currently there is no testing flow for reselling an NFT with royalties. When implementing this with near-workspaces-ava, the asserts fail when running the following simulation test:
workspace.test(
  "cross contract: reselling and royalties",
  async (test, { nft_contract, market_contract, alice, bob, charlie }) => {
    const royalties_string = `{"${alice.accountId}":2000}`;
    const royalties = JSON.parse(royalties_string);
    test.log("royalties: ", royalties);
    await mintNFT(alice, nft_contract, royalties);
    await payForStorage(alice, market_contract);
    const ask_price = "300000000000000000000000";
    await placeNFTForSale(market_contract, alice, nft_contract, ask_price);

    // offer for higher price
    const alice_balance_before_offer = (await alice.balance()).total.toBigInt();
    const bid_price = ask_price + "0";
    await purchaseListedNFT(nft_contract, bob, market_contract, bid_price);
    const alice_balance_after_offer = (await alice.balance()).total.toBigInt();
    const alice_balance_difference = (
      alice_balance_after_offer - alice_balance_before_offer
    ).toString();

    // assert alice gets paid
    test.is(
      alice_balance_difference.substring(0, 3),
      bid_price.substring(0, 3),
      "Expected alice balance to roughly increase by sale price"
    );

    // bob relists NFT for higher price
    test.log("bob paying for storage");
    await payForStorage(bob, market_contract);
    const resell_ask_price = bid_price + "0";
    test.log("bob placing NFT for sale");
    await placeNFTForSale(market_contract, bob, nft_contract, resell_ask_price);

    // bob updates price to lower ask
    test.log("bob updating NFT price for lower");
    const lowered_resell_ask_price = "600000000000000000000000";
    const update_price_payload = {
      nft_contract_id: nft_contract,
      token_id: "TEST123",
      price: lowered_resell_ask_price,
    };
    await bob.call(
      market_contract,
      "update_price",
      update_price_payload,
      defaultCallOptions(DEFAULT_GAS, "1")
    );

    // charlie buys NFT from bob
    test.log("charlie purchasing bobs NFT");
    const alice_balance_before_offer_2 = (
      await alice.balance()
    ).total.toBigInt();
    const bob_balance_before_offer = (await bob.balance()).total.toBigInt();
    test.log("bob_balance_before_offer", bob_balance_before_offer);
    await purchaseListedNFT(
      nft_contract,
      charlie,
      market_contract,
      resell_ask_price
    );
    const alice_balance_after_offer_2 = (
      await alice.balance()
    ).total.toBigInt();
    const alice_balance_difference_2 = (
      alice_balance_after_offer_2 - alice_balance_before_offer_2
    ).toString();
    const bob_balance_after_offer = (await bob.balance()).total.toBigInt();
    test.log("bob_balance_after_offer", bob_balance_after_offer);
    const bob_balance_difference = (
      bob_balance_after_offer - bob_balance_before_offer
    ).toString();

    // assert alice gets paid royalties
    // TODO: this fails on sandbox and should pass
    test.is(
      alice_balance_difference_2.substring(0, 2),
      "120", // 20% of lowered_resell_ask_price
      "Expected bob balance to roughly increase by 80% of sale price"
    );
    // assert bob gets paid
    test.is(
      bob_balance_difference.substring(0, 2),
      "480", // 80% of lowered_resell_ask_price
      "Expected bob balance to roughly increase by 80% of sale price"
    );
  }
);

You didnt await the purchaseListedNFT

Good point @njelich, was very helpful and put me in the right path to fix the test! Have now included it in #22


Impossible to uninstall

Steps to reproduce
make VIMRUNTIMEDIR=/usr/share/vim/vim73
sudo make uninstall
Expected behaviour
In every wiki I found says it will be deleted
Operating system
MacOS Monterey
Version of Vim
8.2
Logs and stack traces
make: *** No targets specified and no makefile found.  Stop.
make: *** No rule to make target `uninstall'.  Stop.

What's the output of the shell command pwd when you run sudo make uninstall?
Same question with the shell command  ls | grep -i makefile.

alessandrodeiturbe@MacBook-Air-di-Alessandro vim % pwd
/usr/share/vim
alessandrodeiturbe@MacBook-Air-di-Alessandro vim % make VIMRUNTIMEDIR=/usr/share/vim/vim73
make: *** No targets specified and no makefile found.  Stop.
alessandrodeiturbe@MacBook-Air-di-Alessandro vim % sudo make uninstall
Password:
make: *** No rule to make target `uninstall'.  Stop.
alessandrodeiturbe@MacBook-Air-di-Alessandro vim % ls | grep -i makefile
alessandrodeiturbe@MacBook-Air-di-Alessandro vim %

alessandrodeiturbe@MacBook-Air-di-Alessandro vim % pwd
/usr/share/vim

So you are in /usr/share/vim.  That's probably where the system's Vim gets installed, but not where you cloned the project.  How did you get Vim?  Where did you clone the repo?  You need to run the make commands in the root directory where your personal copy of the Vim project is located.
For example:
$ mkdir ~/test
$ cd ~/test
$ git clone https://github.com/vim/vim
$ cd ~/test/vim
$ ./configure
$ make
$ sudo make install
$ sudo make uninstall

alessandrodeiturbe@MacBook-Air-di-Alessandro vim % ls | grep -i makefile
alessandrodeiturbe@MacBook-Air-di-Alessandro vim %

Yes, there is no Makefile under /usr/share/vim.  If you want to uninstall the Vim binary installed by your system, you need to use your OS package manager.

I haven't installed vim via package manager, but I've compiled it from the code downloaded on the Vim's Github page, but I've deleted the folder

I've deleted the folder

Try to re-create it by cloning the repo again.

Then run make uninstall from this folder.  Only then can you delete it.

I did everything, but If I type vim in the terminal still starts vim

If I type vim in the terminal still starts vim

This Vim was probably installed by your OS.  You need to learn how to uninstall packages managed by your OS (brew uninstall vim?).
In any case, that's not a Vim bug.  I suggest you ask further questions on apple.stackexchange.com.


Updating dev docs and specification

:tada: This PR is included in version 1.0.6 :tada:
Your semantic-release bot :package::rocket:


Doses Cosmos DB for PostgreSQL Connecter really exist?

Hi Team,
I tried to follow the steps mentioned in this doc and found there's no "Azure Cosmos DB for PostgreSQL" option in actual ui.

Kindly check whether documentation is correct or not..?

Thank you very much!
Regards,
Yutaro

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3caceb5b-22c0-5382-f2f1-ab2edec63dc8
Version Independent ID: f8227673-bc3d-5982-89a6-89cfbdb03a62
Content: Azure Data Factory
Content Source: articles/cosmos-db/postgresql/howto-ingest-azure-data-factory.md
Service: cosmos-db
Sub-service: postgresql
GitHub Login: @suvishodcitus
Microsoft Alias: suvishod

@yutaro113 Thanks for your findings, We will look into it and update as appropriate.

@jonels-msft, can you assist with this question?

@suvishodcitus Can you please provide your inputs here?

Hello @yutaro113 - The document needs to be updated. Please follow below steps:

Configure Sink

6.1.	Go to the Sink tab. Select + New to create a source dataset.
6.2.	In the New Dataset dialog box, select Azure Database for PostgreSQL, and then select Continue.
6.3.	Under the Linked service text box, select + New.
6.4.	Specify Linked Service name and select your server group from the list for PostgreSQL server groups. Add connection details and test connection
** (If your server group is not there in the drop down, use Enter manually option to add server details)
6.5.	Select the table name where you want to ingest the data.
6.6.	Specify Write method as COPY command.
6.7.	Click Ok to save the configuration.

@yutaro113, I hope this answers your question. It seems like the connector is still called Azure Database for PostgreSQL but it also works with Azure Cosmos DB for PostgreSQL. We will update the article shortly with this information.

The article has now been updated:

#please-close


Feature request: Emitting event on server listening

Hello.
I've faced the problem that I can't handle exceptions on the SCP server start properly cause it lacks a listening event. If I start the server with promise, it either never resolves or doesn't handle network error. So I've created a subclass of Server with an overriding listen method.
private async listen(pacsOptions: IPacsOptions) {
    return new Promise<Server & EventEmitter>((resolve, reject) => {
      const pacsServer = (new DIMSEServer(DimseScp)) as DIMSEServer & EventEmitter;

      pacsServer.on('networkError', (error: Error) => {
        reject(error);
      });

      pacsServer.listen(pacsOptions.port, {
        ...pacsOptions.scp,
        datasetWriteOptions: { fragmentMultiframe: false },
        logCommandDatasets: false,
        logDatasets: false,
        logger: new LogService(this.pathService, DimseScp.name),
      });

    resolve(pacsServer); // Resolve before 'networkError' emitted
    });
  }

It would be helpful if Server emits some event once it is ready (propogate net.Server and tls.Server 'listening' event).

Thank you @jimOnAir for reporting this! Version 0.1.23 no propagates the net.Server and tls.Server listening event.

Hello @jimOnAir! Did you have the chance to test this?

Hello @PantelisGeorgiadis . Yes, it works like a charm, thank you

Great to hear that!


Incomplete Syntax definition

REPEAT, REPT
Marks a block that is to be repeated constantExpression times.

{{REPEAT | REPT}} constantExpression ;;
[[macroLocalDirective]]...
macroItem...
ENDM;;

non-Terminal
Definition

;;
([\x9\x20]*;[\x0-\x9\xB-\xFF]*)?\xA

id
[A-Za-z$?@_][A-Za-z0-9$?@_]{0,246}

number
[0-9][A-Fa-f0-9]*[HOQTYhoqty]?

chainString
(“[\x0-\x9\xB-\x21\x23-\xFF]*“)+|(’[\x0-\x9\xB-\x26\x28-\xFF]*’)+

constant
{{(constantExpression)}}... | terminalExpression | type

type
dataType | {{NEAR | FAR}} | PROC | structnameId | recordnameId | typeId

dataType
BYTE | SBYTE | WORD | SWORD | DWORD | SDWORD | FWORD | QWORD | SQWORD | TBYTE | OWORD | REAL4 | REAL8 | REAL10 | MMWORD | XMMWORD | YMMWORD

directive
generalDirective | segmentDirective | structDirective

generalDirective
nameDirective | includeDirective | includeLibDirective | commentDirective | recordDirective | typedefDirective | externDirective | externdefDirective | publicDirective | commDirective | protoDirective | contextDirective | optionDirective | radixDirective | titleDirective | pageDirective | listDirective | crefDirective | echoDirective | ifDirective | errorDirective | macroDirective | macroCallDirective | macroForDirective | macroForcDirective | macroPurgeDirective | macroRepeatDirective | macroTextDirective | macroTextEquDirective | macroText=Directive | macroWhileDirective | aliasDirective

constantExpression
operatorExpression | constant

operatorExpression
[[unaryOperator]] constant binaryOperator constantExpression | unaryOperator constant

recordExpression
recordnameId {{{[[constantExpression]][[,[[constantExpression]]]]...} | <[[constantExpression]][[,[[constantExpression]]]]...>}}

terminalExpression
lengthOperator | recordOperator | sizeTypeOperator | recordExpression | number | chainString

binaryOperator
arithmeticOperator | booleanOperator | conditionalOperator

arithmeticOperator
+ | - | * | / | MOD | SHR | SHL

booleanOperator
AND | OR | XOR

conditionalOperator
EQ | NE | LT | LE | GT | GE

lengthOperator
{{LENGTH | LENGTHOF}} dataLabel

dataLabel
{{variablenameId | structnameId}}[[memberOperator]]...

memberOperator
.structmemberId

recordOperator
{{WIDTH | MASK}} {{recordnameId | recordfieldnameId}}

sizeTypeOperator
{{SIZE | SIZEOF | TYPE}} {{dataLabel | type}}

unaryOperator
+ | - | NOT | highlowOperator

highlowOperator
HIGH | LOW | HIGHWORD | LOWWORD | HIGH32 | LOW32

macroItem
directive | macroExitMDirective | macroGotoDirective | macroLabelDirective

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 27294aaa-4d0d-95cc-8f0e-ea33d67ca8bd
Version Independent ID: 2c1a00e5-b777-7988-2dca-fe2e3f53b6e1
Content: REPEAT
Content Source: docs/assembler/masm/repeat.md
Product: visual-cpp
Technology: cpp-masm
GitHub Login: @corob-msft
Microsoft Alias: corob

@Player1UK thanks! See comment for #1123.


[TEST] update to cb3 using conda smithy update-cb3

Ran conda smithy update-cb3 that's proposed in PR https://github.com/conda-forge/conda-smithy/pull/781 to update the recipe to cb3. So, are the added C compilers to this recipe needed?
$ conda smithy update-cb3
List of changes done to the recipe:
Renamed build with host
Removing vc features
Removing features section as it is empty
Adding C compiler

cc @isuruf

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

So, are the added C compilers to this recipe needed?

Yep, it builds extension modules, see: https://github.com/libgit2/pygit2/blob/v0.27.1/setup.py

@conda-forge-admin, please re-render.

Btw, please use forks for PRs in the future

Btw, please use forks for PRs in the future

Yeah, sorry. It gets easier to get confused when we have three remotes, conda-forge, personal fork and bot's fork.

Btw, please use forks for PRs in the future

Good catch, @isuruf, I didn't even notice before.
@shadowwalkersb, it's rather important to do so since you insta-release on any branch of the main repo; see the new builds from this branch at https://anaconda.org/conda-forge/pygit2/files.
For more information, see: https://conda-forge.org/docs/conda-forge_gotchas.html#using-a-fork-vs-a-branch-when-updating-a-recipe.

Yeah, sounds like messed up big time. Let me remove myself. Probably, the safest thing to do.

Nah, don't be too harsh on yourself. That unconditionally uploading for new branches is a longstanding issue that quite a few people tripped over before.
And https://github.com/conda-forge/pygit2-feedstock/commits/master shows you did a good job maintaining the feedstock lately -- I'd like to encourage you to continue to do so :smile:.


Feature/lef 388 upload assets function

Implement the following methods to upload a file coming from Canva to Frontify:

createFileId
uploadFile
createAsset

📦 Published PR as canary version: Canary Versions

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

:rocket: PR was released in<EMAIL_ADDRESS>:rocket:


主题配置文件中han设置为true后，一级标题与正文之间的空行显示不正常

Expected behavior (预期行为)
一级标题与正文之间空行正确显示
Actual behavior (实际行为)
一级标题与正文之间紧挨在一起
Steps to reproduce the behavior (重现步骤)
将主题配置文件中的[han]配置项设为[true]
NexT Information
Add the  ✔  sign before an item which is affected by this behavior.
NexT Version:

Master ✔
Latest Release
Old version -

NexT Scheme:

All schemes
Muse
Mist ✔
Pisces

Other Information (Like Browser, System, Screenshots)

Pisces也有这个问题

默认样式是这样，会考虑进行一些调整。

还有一级标题下面正文的行距不对。

@fulanto don't understand u, write in English if not solved. If solved, close it please. Thank's!

@ivan-nginx there is a configuration item in the theme config file named han. If set it to true,  h1 header and article are too closed.

@fulanto screens? Live demo? Anything.

@ivan-nginx I will fix it.

@geekrainy ok, thank's a lot!

@fulanto fix in #1780. Solved?

@ivan-nginx Yes, it solved. Thank you very much. Thanks @geekrainy .


Various docstring fixes, removing unused variables

I found a bunch of issues with docstrings/unused variables during my time on #3180.
I gathered all of the diffs into this PR to keep #3180 focused.

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aabfd16) 98.30% compared to head (b44fd1b) 95.22%.
 Consider uploading reports for the commit 6fd3734 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3191      +/-   ##
==========================================
- Coverage   98.30%   95.22%   -3.09%
==========================================
  Files          74       74
  Lines        8038     8043       +5
==========================================
- Hits         7902     7659     -243
- Misses        136      384     +248

Flag
Coverage Δ

unittests
95.22% <92.85%> (-3.09%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

rich/align.py
100.00% <ø> (ø)

rich/console.py
95.16% <100.00%> (-2.88%)
:arrow_down:

rich/markdown.py
99.45% <100.00%> (ø)

rich/markup.py
100.00% <ø> (ø)

rich/progress.py
92.92% <ø> (ø)

rich/syntax.py
98.19% <100.00%> (-0.29%)
:arrow_down:

rich/text.py
99.00% <66.66%> (-0.17%)
:arrow_down:

... and 2 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


make demo-site crashes without make run

Bug Report
Expected behavior/code
When using the command make demo-site, the site should be up
Actual Behavior
If make run has not been ran before, the app container exits with code 137
Steps to Reproduce

make-demo
make status
State: Exit 137

Environment

Richie version: v1.17
Platform: Docker

This bug had already been fixed


[WIP]KVM: Changing BIOS and CPU params in QEMU launch

Changes required for Windows GPU assignment
Signed-off-by: Hariharasubramanian C S<EMAIL_ADDRESS>

@rvs, as discussed, please take a look at this change, and let me know your suggestions


How to get xpub

I'm looking for a way to get the xpub key

Not possible with any of the current external RPCs atm. If you have your seed, then you can use the aezeed package to decrypt it, and extract the entropy which is used to generate the xpub.

Just a follow up on this old and closed tickets for anybody else that finds this searching (as I did):
As of #4678 it is now possible to retreive both the ypub (addresses that start with 3xxx) as well as the zpub (addresses that start with bc1xxx) from LND with the command
lncli wallet accounts list

Hope this helps.


Rename files

LGTM

Coverage remained the same when pulling ec638b43a205a2c686cdeff72328248628eea76f on braydonf:rename-files into eb5bf8d56ec706d6d1383016e567456fbe4c4741 on bitpay:master.

needs rebase

Coverage remained the same when pulling f0e4d5cf196c72194f681ee88185d8e51487f635 on braydonf:rename-files into fe54c92694f7889aee443baed7d16a782920d98c on bitpay:master.


updating selector syntax

Hi @nschucky
Thanks for the contribution, I'm merging this and fixing the .travis.yml :)


Add tests for Dish

Codecov Report

Merging #170 (6097d9b) into master (19f645e) will increase coverage by 7.94%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master     #170      +/-   ##
============================================
+ Coverage     36.00%   43.95%   +7.94%
- Complexity      422      521      +99
============================================
  Files           144      145       +1
  Lines          2705     2712       +7
  Branches        353      354       +1
============================================
+ Hits            974     1192     +218
+ Misses         1675     1453     -222
- Partials         56       67      +11

Impacted Files
Coverage Δ

.../model/dish/NameDishContainsKeywordsPredicate.java
71.42% <71.42%> (ø)

...c/main/java/seedu/address/model/dish/NameDish.java
80.00% <100.00%> (+80.00%)
:arrow_up:

...rc/main/java/seedu/address/logic/LogicManager.java
48.48% <0.00%> (+3.03%)
:arrow_up:

...u/address/storage/JsonSerializableAddressBook.java
61.90% <0.00%> (+9.52%)
:arrow_up:

src/main/java/seedu/address/model/AddressBook.java
73.23% <0.00%> (+12.67%)
:arrow_up:

...rc/main/java/seedu/address/model/ModelManager.java
68.75% <0.00%> (+14.58%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
82.25% <0.00%> (+16.12%)
:arrow_up:

...va/seedu/address/logic/commands/CommandResult.java
83.87% <0.00%> (+25.80%)
:arrow_up:

.../java/seedu/address/model/dish/UniqueDishList.java
57.89% <0.00%> (+34.21%)
:arrow_up:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f645e...6097d9b. Read the comment docs.


chore: A bit of proofreading

Came across few recurring errors while studying the code, fixed it along with its other appearances

No problem  🤖


Update live with current Master

/cc @BillWagner

Open Publishing Build Service: The pull request content has been published and here are some sample preview links:

Docset 1: core-docs

LGTM.  Doing the :shipit: thing now.


feat: Make pint deploy package-aware. For pint packages, build the package before deploying it.

To-Do

[x] Land and publish changes in https://github.com/essential-contributions/pint/pull/995.
[x] Update toml to point to latest pint-pkg, pint-cli.

Follow-up

https://github.com/essential-contributions/essential-integration/issues/129

Closes #123, right?


Add ability to take glob patterns from stdin

as requested in issue https://github.com/solidiquis/erdtree/issues/51
This detects input on stdin using the is_terminal crate.
Each input line is treated as a separate glob pattern.
This adds a new (hidden) flag --stdin to indicate that et should
take input from stdin. Since the naming convention is to use - for
this, we replace the args - with --stdin before we hand them over
to Clap.
Example usage:
$ mkdir Hello; cd Hello
$ touch hello.rs helLo.rs HELlo.rs hello.txt
$  fd -e rs '^hel[lL]o' | et
Hello (2 B)
├─ hello.rs (1 B)
└─ helLo.rs (1 B)

Fixed the test.
I can implement the isatty functionality in a follow-up PR.
However, I would argue in favor of is-terminal because it is an actively maintained port of atty and it is also a dependency of clap, which makes it already a part of our dependency graph.

Hmmm any idea why this is happening? The test seems to be stuck. Happened yesterday as well I can help investigate if you need.

I restarted the test, but it looks like it is stuck again.
I think it's an issue with github's CI, I doubt it's related to the changes in this PR.


Add marchid for XiangShan

This PR requests the 25 marchid for XiangShan. It’s an open-source high-performance RISC-V processor maintained by Institute of Computing Technology, Chinese Academy of Sciences (ICT, CAS).

The repo is here: https://github.com/OpenXiangShan/XiangShan

Cool, thanks.


to_bytes in stdlib

Problem
It's currently inconvenient to convert a Field element into [u8]. This seems like a common use case, e.g. when incorporating a Field element into a message for signature checks, or into the input of various hash functions.
Solution
Define to_bytes as part of the stdlib.
Alternatives considered
Document a convenient and recommended snippet for writing the above function directly into your circuit.

what is the specification for converting a field to a [u8]?

This would definitely be a useful enhancement. Specifically, converting a Field element to a [u8] message for signature checks has been requested a few times, and I have needed to perform this conversion myself. For example if one wanted to use the result of a pedersen hash as the message of a signature:
    // Check signature.
    let message = std::hash::pedersen(
        [
            alias_hash,
            account_public_key[0],
            new_account_public_key[0],
            spending_public_key_1[0],
            spending_public_key_2[0],
            nullifier_1,
            nullifier_2
        ]
    )[0];
    constrain message != 0;
    let message_byte_array = utils::half_of_field_to_bytes(message);
    let sig_res = std::schnorr::verify_signature(signer[0], signer[1], signature, message_byte_array);
    constrain sig_res == 1;

I have been getting around it by writing methods such as below where I convert half of a Field to a byte array:
fn half_of_field_to_bytes(input: Field) -> [u8; 16] {
    let bit_size: comptime Field = 128;
    let input_bits = std::to_bits(input, bit_size as u32); // Bit size must be 253 or less as this is restricted in Noir for safety

    let mut byte_array: [u8; 16] = [0; 16];
    for i in 0..(bit_size/8) {
        let index = i * 8;
        let mut byte: u8 = 0;
        for j in 0..8 {
            byte = (byte << 1) | (input_bits[index+(7-j)] as u8);
        };
        byte_array[i] = byte;
    };
    byte_array
}

We could add to_byte methods written directly in Noir that use the whole field, however, it would probably be faster within the compiler itself. It is also important to note that right now we also only convert the first 253 bits of a Field when doing bit decomposition for safety, so by whole Field I mean first 253 bits on the Field. This can be seen here. This requires truncating the field some amount of bits if you are a developer (the max bit_size I can use in the snippet above is 253 not 254). I think it may be worth it to switch this check to the max size of our NativeField as to avoid any developer confusion.

We can generalise to_bits and to_bytes in the acir by adding a to_radix directive.
So for to_bits it would call to_radix(2) so its a bit decomposition, and to to_bytes it would to_radix(8)  which is a byte decomposition

There is no confusion right now, as you need to specify a maximum number of bits. If you use more than we support, you have an error because we do not support this. If the field does not fit on the supplied number of bits, it will also fail, so this if fine for me. Of course we can also support more, but then the operation will be more costly without the user knowing it.
So I suggest we do a to_radix(f,a,b)-> [T]; which generates an array of ua, corresponding to the field f being b or less bits.
n.b. I am not sure generics will allow to do this, alternatively we could return [Field], or just have to_bytes(f,b).

There is no confusion right now, as you need to specify a maximum number of bits. If you use more than we support, you have an error because we do not support this. If the field does not fit on the supplied number of bits, it will also fail, so this if fine for me. Of course we can also support more, but then the operation will be more costly without the user knowing it.

It is true a developer will get an error that we simply do support that size of bits, I just meant a developer calculating inputs to their circuit, such as a signature, will have to be aware that the message used should use a truncated Field by some amount of bits (one bit, one byte, half the field, etc).

So I suggest we do a to_radix(f,a,b)-> [T]; which generates an array of ua, corresponding to the field f being b or less bits. n.b. I am not sure generics will allow to do this, alternatively we could return [Field], or just have to_bytes(f,b).

I think this suggestion is good. to_radix with the bit size will give Noir devs the most control.

Do you think it is important to have a to_bytes that uses all the 254 bits?

I believe Joss' original usecase was converting all 254 bits to a byte array so they may all be hashed, so I'd say yes.

We can generalise to_bits and to_bytes in the acir by adding a to_radix directive.
So for to_bits it would call to_radix(2) so its a bit decomposition, and to to_bytes it would to_radix(8) which is a byte decomposition

I'm looking at switching to using to_radix as part of my to_bytes PR. One thing we should note though, is that we are referring to the term radix here differently than how it is normally used. When I hear radix I usually think of the unique number of digits used to represent a number. For radix 2 we represent using 0s and 1s, for radix 10 we use the digits 0-9, for radix 16 we use the digits 0-F.
However, here we are saying to_radix(8) is a byte decomposition into a list of u8s. Every byte is then represented as a hexadecimal, not a base 8 number. We should settle on whether to_radix refers to the size of the integer type in the output array ([u1; 256] or [u8; 32] or [u16; 16]), or the base of the numerical system we are converting into as this may be confusing to developers.

I am not sure I understand the difference between size of the integer type and base of the numerical system, may be one is log of the other?
If you have a better name or think log is better/worse, feel free to propose what you think is best, as long as we have the feature to do to_bytes and to_bits with the same opcode, it is ok for me.


Don't register duplicate CPS subscriptions for same project configura…

…tion.
Customer scenario
VS crashes with ArgumentException on opening dotnet core solutions with projects that have additional files.
Bugs this fixes:
Fixes #1563
Workarounds, if any
None.
Risk
Low risk.
We sometimes ended up with duplicate CPS subscriptions for same configured project, causing us to attempt to add duplicate items to the same workspace project in the langauge service and throwing an ArgumentException. Fix is to keep track of project configurations which have already subscribed.
Performance impact
Low
Is this a regression from a previous update?
Yes. Even though we always registered duplicate subscriptions and I can see the same ArgumentException under the debugger on older builds, the exception was getting swallowed up the stack and not crashing VS. My recent PR to move the Language service to JTF causes this code to now execute in a joinable task, and the exception goes unhandled, crashing VS.
Root cause analysis:
Noted above.
How was the bug found?
Dogfooding.

Tagging @dotnet/project-system for review

@jinujoseph can you please buddy test this change?

@dotnet/project-system can someone please review the fix? This seems to be causing crash on open solution for large number of customer solutions.
@srivatsn @MattGertz I think we should take this to shiproom today - this is a dogfood blocker.

Agreed; I've been following the thread.

Thanks a lot Lifeng!


Added alpha theme property to the pop over

I needed to show a popover with an alpha lower that 1.0f. Added this property to the theme - this is being set independently of the popover presenting animation being "enabled" (the appearing animation now goes from 0.0f to the chosen alpha and vice-versa).
Thanks and please keep up your good work! :)

Nice!


How to reorder the resources/endpoints ?

Problem statement

In the above image , is there any way we can reorder , like first 'Volume ' should come and then 'Snapshots'
swagger version:dev
go version: 1.9.2
OS:  Ubuntu 16.04 LTS

not possible, this is something you should solve in the UI client code itself

Thanks


RDKCOM-4664 RDKDEV-1013:Xdial-ARRISAPP-68-return-hidden-state-for-newer-clients

RDKCOM-4664 RDKDEV-1013:Xdial-ARRISAPP-68-return-hidden-state-for-newer-clients
(cherry picked from commit https://github.com/rdkcentral/xdialserver/commit/c5389d8df56d305dd0e79d80117e41304b3e1c36)
Signed-off-by: Margret Jaison<EMAIL_ADDRESS>

Sanity tests for ['BCM 7216OTT Refboard VA'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/52735/

Sanity tests for ['RPI4 IPSTB'] added.
https://jenkinsrdkm.cmf.code.rdkcentral.com/job/test-components-flow/52737/

You can not directly merge to main branch. first sprint -> valdiation -> RM approval and merge to stable2
The RM Approval has been provided.


Don't highlight trailing spaces within the current line

This is a small enhancement to allow patterns to be enabled only for inactive lines since some people find highlighting trailing whitespace in the current line to be too distracting.

Good idea, nice clean commit, thanks.  I added a small section to the readme. Can you switch the target branch to release/0.0.5?

Changed target branch to release/0.0.5


Why it's much faster in XE7+ versions?

Hello,
Out of curiosity - why it's much faster in XE7+ versions? Because this library utilize the new features only available in XE7+ versions, or because the System.Generics inXE7**+** is implemented worse than XE7**-** systems?

Hello,
In XE7+ there are inline functions GetTypeKind, IsManagedType and HasWeakRef, which allow to execute type-specific code, such as inline hash function and comparer in TRapidDictionary, for example.


[Bug]: BarList onValueChange callback fired multiple times

Tremor Version
3.14.0
Link to minimal reproduction
https://storybook.tremor.so/?path=/story/visualizations-vis-barlist--with-on-value-change
Steps to reproduce
This can actually be reproduced in the storybook example for the BarList onValueChange prop
https://storybook.tremor.so/?path=/story/visualizations-vis-barlist--with-on-value-change

Click the name of a bar
See that you get two alert() dialogs

What is expected?
Clicking any part of the bar (icon, text, or coloured bar area) fires the onValueChange callback once
What is actually happening?
Clicking the "name" on a bar fires the onValueChange callback twice.
What browsers are you seeing the problem on?
Chrome
Any additional comments?

Clicking the bar fires 0 times
Clicking the icon fires 1 time

parent

Clicking the text fires 2 times

/
parent

Hi! Good catch! Looks like it's missing an stopPropagation() for the click event. I will schedule a fix for this in the next release.
If you are in a hurry, I highly recommend to check out an updated version of the BarList here. We just released it over at Tremor Raw, a copy & paste library for React components.


Disable session cookie

Some user want to disable the session cookie for the admin.
There is some confusion about cookies and the use of cookies in conection with personal data. Therefore a lot of users and visitors are afraid of any cookie.

Personal i don't want any Cookie. And i want no cookie notice on my minimal website. A option without Cookie will be awesome.

The cookie in the admin area is only for keeping the SESSION ID, is need it for know if the user is logged or not to the admin area.

But why all users became this cookie? Is there no way to set the cookie only in admin, for users who login? Only for this cookie, i need to setup a cookie notice in EU or choose a other flat-file-cms.

@wpPerformance choose other CMS.. good luck!

session cookie is a normal thing in the world wide web..

It's not true that the GDPR or the EU says that there has to be a notice for a system cookie. This cookie does not track or store any personal information.
Sorry for opening the thread! Rethinking it it's nonsensense.

@wpPerformance Any other idea or an example of a CMS without session cookies?

I disable session cookie for the front page, is enabled only when you go to the admin area.

And now we cant check on front is user logged-in, right? I added "Edit" button in Pages - easy navigation to edit content. Now this is gone? What personal information contain user session? How this relate to GDPR?

For the people is trying to check if the user is logged in the homepage, you can do this.
<?php
$login = new Login();
if ( $login->isLogged() ) {
    echo "User logged";
} else {
    echo "User not logged";
}

Thanks! Working fine.