MLIR Builder in Python to support no arg before region for scf.while

These valid uses of scf.while in MLIR were not previously supported in our IR builder.
      /////////////////////////////////////////////////////////////////////////////////////
      %res = scf.while (%arg1 = %0) : (f32) -> f32 {
        %condition = arith.cmpf "one", %0, %0 : f32
        // CHECK: while before: 1.3
        graphblas.print %0 { strings = ["while before: "] } : f32
        scf.condition(%condition) %arg1 : f32
      } do {
      ^bb0(%arg2: f32):
        // COM: This should never be run
        graphblas.print %0 { strings = ["while after: "] } : f32
        scf.yield %arg2 : f32
      }
      /////////////////////////////////////////////////////////////////////////////////////
      // COM: TODO remove these
      scf.while : () -> () {
        %condition = arith.cmpf "one", %0, %0 : f32
        // CHECK: while before: 1.3
        graphblas.print %0 { strings = ["while before: "] } : f32
        scf.condition(%condition)
      } do {
        // COM: This should never be run
        graphblas.print %0 { strings = ["while after: "] } : f32
        scf.yield
      }
      /////////////////////////////////////////////////////////////////////////////////////
      scf.while : () -> (f32, f32) {
        %condition = arith.cmpf "one", %0, %0 : f32
        // CHECK: while before: 1.3
        graphblas.print %0 { strings = ["while before: "] } : f32
        scf.condition(%condition) %0, %0 : f32, f32
      } do {
      ^bb0(%arg2: f32, %arg3: f32):
        // COM: This should never be run
        graphblas.print %0 { strings = ["while after: "] } : f32
        scf.yield
      }
      /////////////////////////////////////////////////////////////////////////////////////

They are now supported.
We'll need some more tests. I've put off handling that for now and will address it in https://github.com/metagraph-dev/mlir-graphblas/issues/244.
This PR also works around https://github.com/metagraph-dev/mlir-graphblas/issues/236. https://github.com/metagraph-dev/mlir-graphblas/issues/236 seems to only occur with sparse vectors where the last element is missing, e.g. [_, 10, 20, _]. For vectors where this is not the case, e.g. [_, 10, _, 20], the intermittent failures do not come up. This PR changes the test mentioned in https://github.com/metagraph-dev/mlir-graphblas/issues/236 that causes the intermittent failures. The test now succeeds consistently. It's intended that https://github.com/metagraph-dev/mlir-graphblas/issues/236 remain open until it is actually solved, this is merely a workaround to reduce the number of unimportant CI failures that might distract us. CC @jim22k

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

21 of 23 (91.3%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 84.657%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mlir_graphblas/mlir_builder.py
21
23
91.3%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
3901

Relevant Lines:
4608

💛  - Coveralls


Add receive_error event if middleware throws error

Previously, if an error occurred in the receive middleware, the message would just get swallowed and not processed. The error is just logged to console. Now an actual event is fired which can be caught in a skill.

CoreBot.js: firing receive_error event with the error message of the middleware
Error can be caught by using controller.on('receive_error', function(err, bot, message){[HANDLE THE ERROR...]});

This is merged into my next release branch!


refactor: exporter interface

This PR is for:
https://github.com/deepflowio/deepflow/issues/3926
Trying to provide export interface:
type Exporter interface {
	// Start starts an exporter worker
	Start()

	// Put sends data to the exporter worker. Worker could decide what to do next. e.g.:
	// - send it out synchronously.
	// - store it in a queue and handle it later.
	Put(items ...interface{})

	// IsExportData tell the decoder if data need to be sended to specific exporter.
	IsExportData(items interface{}) bool
}

And a factory init method for all exporters:
func NewExporters(exportersCfg []ExporterCfg, baseCfg *config.Config) []Exporter

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jiekun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

This is a breaking change against previous exporter config. We need an item in CHANGELOG to notify user.
I'm verifying the change and test it on my Kubernetes. This PR is WIP for now.

@jiekun The server check seems to have failed

issue resolved and re-formatted just now.
/ptal @dundun9 @oilbeater @lzf575

I'm merging the main branch into feature branch, again. please take a look and drop your comment if possible.
We don't have to waste time running CICD workflow with limited runner resources for those redundant test and check.

@lzf575 Have time to review it as soon as possible

有些配置是公共的， universalTagsManager 也是公共的， 后续需单独提取出来。


Integrate tests into repo downloads

Is your feature request related to a problem?

When grading programming exercises I always have to copy a studentes exercide into my test folder in order to locally run the tests on that execise ans clean the folder after I'm done.
Describe the solution you'd like

It would be exceptionally cool if artemis would optionally do that for me when downloading repos, so that I could just import all the projects into my IDE and wouldn't be bothered with setup work anymore.
Describe alternatives you've considered

Writing my own scripts/tools that would help me, but those thoughts morphed into an artemis clone pretty quickly.
Additional context

While thinking about this it seemed to me as if artemis could use some segmentation. For example writing a toool based on the artemis api just for grading prgramming exercises seems very doable for me, but it would probably be a nightmare integrating it into artemis.

I like this idea, great suggestion. We will add an option for this in the future.

Just found out that this is a duplicate of https://github.com/ls1intum/Artemis/issues/863
Let's discuss the feature request in the original issue and I close this one


Handle bots with multiple groups [BTA-924]

Not really sure how to test it (how to set up the local env variables), but let me know if you have any feedbacks yet

This change is

src/sdk.ts, line 497 at r1 (raw file):
Previously, conord33 (Conor Dawson) wrote…
this should get the groupLabel from the NewTraceInput right?

Done.

src/sdk.ts, line 565 at r1 (raw file):
Previously, conord33 (Conor Dawson) wrote…
this should check the input for a gropuLabel

Done

src/sdkConfig.ts, line 9 at r1 (raw file):
Previously, conord33 (Conor Dawson) wrote…
what is Record?

I'm not really used to typescript : https://www.typescriptlang.org/docs/handbook/utility-types.html#recordkeystype is it not used ?
I changed for
groupLabelToIdMap: { [key: string]: string };

src/sdkConfig.ts, line 9 at r1 (raw file):
Previously, Paturages (Paturages) wrote…
they're both equivalent, Record I find is more idiomatic to TypeScript/typed languages and { [key: string]: string } is closer to JavaScript itself

So I can keep Record ?

src/sdkConfig.ts, line 35 at r1 (raw file):
Previously, conord33 (Conor Dawson) wrote…
you should add a test for this

Done.

src/types/trace.ts, line 133 at r1 (raw file):
Previously, conord33 (Conor Dawson) wrote…
i think you can leave this one out since its deprecated. i am pretty sure this interface only gets used by deprecated methods.

Done.

And about tests, how do I add variables in env files ?

:tada: This PR is included in version 2.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Always run onElementClick if provided, regardless of isSelectable or isDraggable

It would be useful to have the onElementClick event run, even if elements are not selectable or draggable.

that's a good idea! thanks.


[5.7] Extra padding for pages with short hero section

Rationale: Add extra padding for pages with short hero section (2 items or less), in order to optimize the look of hero icon.
Risk: Low
Risk Detail: Change only concerns the hero section.
Reward: High
Reward Details: Makes sure icons look good in pages with short hero section, especially API Collection pages.
Original PR: https://github.com/apple/swift-docc-render/pull/184/
Issue: rdar://90792025
Code Reviewed By: @dobromir-hristov
Testing Details: Visually test in browser and verify that padding is 60px in the hero section for pages that have 2 items or less in that section.

@swift-ci test

@swift-ci test


Unlocked citizens indicator is not showing anymore

There used to be a little circle that showed up whenever your city had citizens that had not been locked into a tile. I now see the district count icon which I am guessing will go away if the city is at max districts. Was the unlocked citizen removed to make room for this?
I am always looking for unlocked citizens as the game never seems to quite follow my instructions in filling spots, especially when district spots are involved.
I am running latest version of everything and playing as Maya this game.

District Available is a new indicator.


Timeline for stream shows NaN:NaN in google chrome

Timeline shows NaN:NaN in google chrome for mp3 streams and it stops loading the stream.
< audio preload="none" controls >
< source type="audio/mp3" src="http://<IP_ADDRESS>:8000/aligator-128.mp3">
< /audio>
mejs.version = '2.11.3';

@tsarma Closing old issues. If you'd like to reopen this, let us know. Thanks!


Add a Nix package for Infracost

See: https://nixos.org/manual/nixpkgs/stable/#idm140737317098448

Going to close this issue as it hasn't received much love since February

This has now been done in https://github.com/NixOS/nixpkgs/pull/127365. Thanks @davegallant! 🚀 🚀 🚀


bytes/hash: TestSmhasherSmallKeys flake on android-arm-corellium builder

From the android-arm-corellium builder (https://build.golang.org/log/6d0506edef76d21049f50f3d2a77cf686d063476):
--- FAIL: TestSmhasherSmallKeys (0.15s)
    smhasher_test.go:95: unexpected number of collisions: got=256 mean=0.000000 stddev=0.000011
FAIL
FAIL	bytes/hash	0.639s

CC @randall77

I think what is going on here is that we're getting invalid random data on startup (_AT_RANDOM content not actually random, or perhaps zero length, or no _AT_RANDOM and /dev/urandom isn't random).
I can reproduce the behavior on 386 by setting GODEBUG=cpu.all=off (to get the same hash algorithm that arm uses) and commenting out the call to getRandomData in runtime/alg.go:alginit.
We use different parts of the startup random data to make the hash length-dependent. If the startup random data is not random (all zero,  probably) then the length-dependence of the hash goes away, and that's the behavior we're seeing (the 256 length 1 hashes are colliding with some of the 256^2 length 2 hashes).

I guess this could happen by chance with probability ~2^-16 (top ~16 bits of two 32-bit random numbers differ by a one-bit shift).
It hasn't recurred. I'm inclined to leave this as is and see if it happens again.

It hasn't happened again.  Let's close and reopen if we see it.


Pose Control

Nice work! Regarding to your paper, it seems that the proposed Motion Encode can successfully disentangle ID and motions, and I want to know whether expressions and head poses are also disentangled in your model? If yes, how can head poses be controlled explicitly by pitch, yaw and roll?

Hello, we haven't modeled expressions because our training dataset doesn't include facial expressions, such as those found in datasets like MEAD.  We don't include emotions like happiness, anger, sadness, or joy.
Furthermore, head poses are handled differently from the decoupling of identity and action. Head pose, including the face's scale and position, is directly controlled through input. Head pose includes yaw, pitch, and roll, which we've normalized to a range of -1 to 1.
Due to the limitations of our training data limit and our use of a diffusion network (which involves a sampling process), we currently can't achieve precise, wide-range control. If you want to use this feature, we suggest starting with adjustments in the range of -0.2 to 0.2. If you need to automatically extract poses, we recommend using head pose estimation algorithms for automatic control.

No discussion in this topic from last 1 month.


Output not reduced in validation

🐛 Bug
I believe there is a discrepancy in the training and validation epoch ends when training in parallel gpus. I cannot release the code I'm working with as it is private, but I'll try and reproduce if I can.
The bug is that the output in validation epochs is not reduced, we can verify it in the source of the validation, and we can also see that all references to this function are inside an if train statement.
This can lead to bugs which are hard to detect without looking at the source code. For example,  you can calculate the mean of the loss at training_epoch_end, but the same code depending on the number of gpus, validation samples and batchsize might lead to bugs in validation_epoch_end.
To Reproduce
Given 4 gpus, 10 validation samples and a batchsize of 4. The last validation step will only have two outputs. Then:
Running torch.stack([x['loss'] for x in outputs]).mean() works in training_epoch_end as outputs are reduced before reaching training_epoch_end.
Running torch.stack([x['loss'] for x in outputs]).mean() will fail in validaition_epoch_end as outputs are not reduced, and the first dimention of the output coming from the last batch differs. so torch.stack will fail
Expected behavior
I expect that both validation and training epochs have the same behaviour, or if not there has to be a clear warning.

they should have the same behavior. mind putting together a colab to illustrate? mnist should be enough no?

I don't think I can run on colab as it is a problem when using multiple gpus, I'll try and run a short demo on my cluster

This code ilustrates the issue
If you run with

2 gpus,
batch size:2
dataloader size: 3

The outputs from the 2 training/validation steps will have dimension 2 and 1 in each epoch.
For training, it's OK as it is reduced. We verify that the exception occurs in the validation epoch end, having the sanity run disabled.
On the other hand, if we run with a batch size of 3 the problem will not happen.I belive this bug only will happen if there is a gpu with no data in a run, i.e. len(val_dataloader)%batch_size < n_gpusWhich make this bug very hard to diagnose and many times unnoticed.
The error is the following:
Traceback (most recent call last):
  File "dpbug.py", line 75, in <module>
    main()
  File "dpbug.py", line 72, in main
    val_dataloaders = val_dl)
  File "/cluster/home/dzhu/anaconda3/lib/python3.7/site-packages/pytorch_lightning/trainer  /trainer.py", line 702, in fit
    self.dp_train(model)
  File "/cluster/home/dzhu/anaconda3/lib/python3.7/site-packages/pytorch_lightning/trainer  /distrib_parts.py", line 538, in dp_train
    self.run_pretrain_routine(model)
  File "/cluster/home/dzhu/anaconda3/lib/python3.7/site-packages/pytorch_lightning/trainer  /trainer.py", line 865, in run_pretrain_routine
    self.train()
  File "/cluster/home/dzhu/anaconda3/lib/python3.7/site-packages/pytorch_lightning/trainer/training_loop.py", line 363, in train
    self.run_training_epoch()
  File "/cluster/home/dzhu/anaconda3/lib/python3.7/site-packages/pytorch_lightning/trainer/training_loop.py", line 457, in run_training_epoch
    self.run_evaluation(test_mode=self.testing)
  File "/cluster/home/dzhu/anaconda3/lib/python3.7/site-packages/pytorch_lightning/trainer/evaluation_loop.py", line 372, in run_evaluation
    eval_results = self._evaluate(self.model, dataloaders, max_batches, test_mode)
  File "/cluster/home/dzhu/anaconda3/lib/python3.7/site-packages/pytorch_lightning/trainer/evaluation_loop.py", line 316, in _evaluate
    eval_results = model.validation_epoch_end(outputs)
  File "dpbug.py", line 44, in validation_epoch_end
    loss = torch.stack([x['loss'] for x in outputs]).mean()
RuntimeError: invalid argument 0: Sizes of tensors must match except in dimension 0. Got 1 and 2 in dimension 1 at /tmp/pip-req-build-4baxydiv/aten/src/THC/generic/THCTensorMath.cu:71

QQ: Why is the reason the calls to self.reduce_distributed_output() are only for training.
I think the fix is probably adding a call to self.reduce_distributed_output() here. but I haven't looked too deep into the issue. I'm having quite a bit of work right now, so hopefully someone else will look into it

@Deanamic mind send a PR? :]

I won't be able to work on this until approximately mid May, so hopefully someone can work on this. Else I'll do it when I'm available

@Borda and @Deanamic : I can have a look at this if you do not mind :-)

I am curious the status of this issue. Could this be fixed in the near future?
I am in the process of migration from Pytorch to lightning and I ran into the same issue outlined above when I changed batch_size.
Thanks.

@junwen-austin would you be interested in sending a fix for this issue? :]

@Borda I'd love to but my background is data science and do not have lots of coding experience in DDP. I am using Lightning for my data science project at work and am really impressed by the design and philosophy of Lightning 👍

I didn't know this bug was still open, the fix shouldn't involve coding with DDP as pytorch should handle everything. I could try fix that now, but I wondered if there is any way to test multiple GPUs as I do not have access to that.

I think the fix is probably adding a call to self.reduce_distributed_output() here. but I haven't looked too deep into the issue. I'm having quite a bit of work right now, so hopefully someone else will look into it

This should probably fix the issue, but would require further testing

@jbschiratti @junwen-austin @Deanamic anyone wants to take this over?

This appears to be an issue on both training_epoch_end() as well as validation_epoch_end(), as there is now no reduction for either.

Seems to work using results objects, but not with dicts

ok... this is not a bug.
The batch sizes are too small and you're not dropping the last batch.
What ends up happening is that one GPU processes 2 items and the second only 1 item (because your batch size is 3).
And thus your outputs aren't the same length... this is not something we can automate... so you have to either check for that in your code or make sure your batch size is always a multiple of GPUs.


Paella 7: Use the localstorage to store the user preferences

This PR updates the paella to last version and updates the config file to save the user preferences in the localstorage instead of cookies.
Fixes a "HTTP 431 header too large" bug when user's preferences are too large.
See polimediaupv/paella-core#322
Your pull request should…

[x] have a concise title
[ ] close an accompanying issue if one exists
[ ] be against the correct branch
[ ] include migration scripts and documentation, if appropriate
[x] pass automated tests
[x] have a clean commit history
[x] have proper commit messages (title and body) for all commits

@miesgre how I can test this?

@miesgre how I can test this?, also, because this solves a bug, should be on r/13.x?

You can check that preferences are now in localstorage instead of cookies.
Maybe @karendolan can review it and test with large user preferences in her installation.
About r/13.x, This PR requiere to update paella-core version to 1.43, that's why I sent it to develop

Oc version
paella version

r/13.x
1.25.0

r/14.x
1.39.2

develop
1.42.0

Now you said it, It seems dependabot is not making PR updates to paella. I haven't seen one for core in a while.

@miesgre Yesterday I spoke with Lars and I forgot completely, we decided that the only branch with automatic updates will go to the develop branch.
The other branches need paella to be manually updated.
Should I take the json and the config files to the other versions so you can rollback this bugfix and the other to r/13.x?

@miesgre Yesterday I spoke with Lars and I forgot completely, we decided that the only branch with automatic updates will go to the develop branch. The other branches need paella to be manually updated.
Should I take the json and the config files to the other versions so you can rollback this bugfix and the other to r/13.x?

If there is no problem in changing the version of paella and modifying the config.json file, I can rebase to r/13.x if you want.

That is a good idea, please rebase r/13.× and I will try it and merge it today

@mliradelc Did you test other player behavior as well? If I understand this correctly, this version update will contain more than just this bugfix, so we need to ensure it's safe before putting it into a minor Opencast version.

Yes, this version also upgrades the core of paella, that is already in the develop branch. From what I tested is working well. I'm waiting for @karendolan comments over the localstorage.

HI @mliradelc, just saw this! For the intermediate solution at our site, we have increased our allowed header sizes on the server so we have not yet adopted saving preferences in storage, but will in the next couple weeks. For students getting the
"header to large" error, we ask them to clear their cookies, try an anonymous browser, or different browser.
An example of the  issue is that my own Paella preference cookie for our site is now 2102 bytes big, and that is a lot to send back to Opencast on each request along with our other session related cookies. Sites like github commonly use browser storage for preferences, instead of the cookie. If you look in your browser inspector storage/application tab right now, you will see the refs.


chore: Use header tag for trigger in visual editor

Description
Use header tag for trigger in visual editor
Task Item
closes #2028
Screenshots

What Ashish described in the issue by saying 'defined under heading tag' should be using <h1>/<h2>/<hi> instead of using span

Fixed it.


upgrade lru from "0.6.3" to  ">=0.7.1"

When I was trying to build libkrun 1.4.8 package in obs, I got the following warning
RUSTSEC-2021-0130 -> crate: lru, cvss: None, class: ['memory-corruption']
see https://rustsec.org/advisories/RUSTSEC-2021-0130.html
can this be update >=0.7.1
this is the location:
https://github.com/containers/libkrun/blob/4c108e66fb9d077bb4d6a34702bbaf74ab1de8db/src/devices/Cargo.toml#L17

Still valid in 1.4.10

@fcrozat thanks for bringing attention back, @tylerfanelli thanks for fixing


FirebaseCoreDiagnostics Compile Error

Created a new React project and included capacitor dependencies and tried to run the app for IOS worked fine.
But when I add @capacitor-community/fcm with version 2.0.2, I got the below error while building it

Lexical or Preprocessor Issue
Double-quoted include "pb.h" in framework header, expected angle-bracketed instead
Parse Issue
Could not build module 'nanopb'

Version used - 2.0.2
Screenshot

Can someone help on this?

Same issue. Where I'm running OS 12.0.1 and Xcode 13

Was there a fix / update that addresses this?
Still happens for me on v3.02 with Capacitor 4.6.1 on Xcode 14.2.
FYI a dodgy workaround is outlined in https://github.com/firebase/firebase-ios-sdk/issues/5987


KGX over-writes node properties when only importing an edge file.

the new command line structure in example/scripts/load_csv_to_neo4j.py allows the user to import either or both node/edge files.
when only importing an edge file any associated nodes have their "category" property over-written with "category":"biolink:NamedThing" when it was originally an array of values. e.g:
"category": [
"gene",
"gene_or_gene_product",
"macromolecular_machine",
"genomic_entity",
"molecular_entity",
"biological_entity",
"named_thing"
]
Thanks,
Phil.

@PhillipsOwen Having trouble reproducing this bug locally. Could you provide some example datasets?
Here is what I tried:
# first loading edges
python examples/scripts/load_csv_to_neo4j.py --edges issue_181_edges.tsv --uri http://localhost:7474 --username neo4j --password demo
# then loading nodes
python examples/scripts/load_csv_to_neo4j.py --nodes issue_181_nodes.tsv --uri http://localhost:7474 --username neo4j --password demo

issue_181_nodes.tsv:
id	name	category
A:1	Node A1	biolink:Gene|biolink:GenomicEntity
A:2	Node A2	biolink:Gene|biolink:GenomicEntity|biolink:GeneOrGeneProduct
B:1	Node B1	biolink:Gene
B:2	Node B2	biolink:Gene

issue_181_edges.tsv:
subject	edge_label	object	relation	provided_by
A:1	biolink:related_to	B:1	RO:123456	test
B:1	biolink:related_to	B:2	RO:123456	test

i have recently found that this behavior happens when you do the nodes first, then the edges.


Disable Write to Field by User

I have a field in my schema that I need to limit editing to only the owner of the document.  How do I do that?  Is it possible?  Thanks!  (I wish GitHub would get a QA section because this isn't really an "issue").

Authorisation should be handled in method or allow/deny code rather than in data validation.
Best to stick to separation of concerns

Thanks!


File Download is Corrupted - Spring Boot App

Unable to download the file using Bot Token or User Token although in some cases User token is able to download the file!
Reproducible in:
mvn dependency:tree | grep com.slack.api
java -version
sw_vers && uname -v # or `ver`

The Slack SDK version
(Paste the output of mvn dependency:tree | grep com.slack.api or gradle dependencies | grep com.slack.api)
[INFO] +- com.slack.api:bolt-jakarta-servlet:jar:1.29.1:compile
[INFO] |  +- com.slack.api:slack-api-model:jar:1.29.1:compile
[INFO] |  +- com.slack.api:slack-api-client:jar:1.29.1:compile
[INFO] |  +- com.slack.api:slack-app-backend:jar:1.29.1:compile
[INFO] |  - com.slack.api:bolt:jar:1.29.1:compile
Java Runtime version
(Paste the output of java -version)
openjdk version "17.0.5" 2022-10-18 LTS
OpenJDK Runtime Environment GraalVM 22.3.0 (build 17.0.5+8-LTS)
OpenJDK 64-Bit Server VM GraalVM 22.3.0 (build 17.0.5+8-LTS, mixed mode, sharing)
OS info
(Paste the output of sw_vers && uname -v on macOS/Linux or ver on Windows OS)
ProductName:            macOS
ProductVersion:         13.3.1
BuildVersion:           22E261
Darwin Kernel Version 22.4.0: Mon Mar  6 21:00:17 PST 2023; root:xnu-8796.101.5~3/RELEASE_X86_64
Steps to reproduce:
(Share the commands to run, source code, and project settings (e.g., pom.xml/build.gradle))

I am unable to download the file using the Bot Token even though the token is having the following permission
2.files:read
3.files:write
4.But I am able to download the file using the User Token with the same permission

Expected result:
I wanted to download the file from slack when user clicks an action the message shortcut using the Bot Token but its not working as intended in the example and documentation
Actual result:

Downloaded file is corrupted when I use the Bot Token to download the file from the my own user direct message.
But when I am using the User Token its working.

Hi @arunt4ever, thanks for asking the question!
When you updoad a file to somewhere your app's bot user does not have the access (e.g., a user's single person DM), any app's bot user and its tokens (xoxb- prefixed ones) cannot retrieve the file's metadata and content. Thus, the situation only the user token works in the scenario is expected. If the user shares the file in a public/private channel where the app's bot user is a member of, then your bot token can access the file content.
If your app needs to access the files visible only to a specific user, using the user's user token (xoxp-) is the right way to do so. If your app needs to access many people's private files, each of those people needs to go through OAuth flow to grat user scopes like files:read, and your app needs to securely stores all those user tokens and use the tokens appropriately.
I hope this helps.

Hi @seratch , Thank you for your response!
Maintaining user token (xoxp-) for every user will not work!
I will try to ask the end-users to directly upload files to Bot's DM to access the files.


OperatorLinebreakFixer - fix for alternative syntax

Fixes https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/6142

Coverage increased (+0.007%) to 92.854% when pulling 5eb854dbfcd8fc9cafa8e809535473b661695c01 on werlos:fix_OperatorLinebreakFixer into 075082e586a21fbf9faf35a2e4257f1a18ece6fe on FriendsOfPHP:master.

Thank you @kubawerlos.

Seems like a gh bug that the PR get closed and not merged when commits get squashed.. but maybe I'm running old gh version


readme(engine): move tiflow readme to tiflow and fix some outdated test discription

What problem does this PR solve?

Issue Number: close #6853
What is changed and how it works?

Move tiflow readme to tiflow dir
Add some description for e2e test
Fix some out-dated description for docker deployment

Check List
Tests

No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
 `None`.

/area engine
/cc @amyangfei
/cc @gozssky

/cc @CharlesCheung96

/status ptal

Codecov Report

Merging #6855 (77f89e5) into master (7c5032c) will decrease coverage by 0.0924%.
The diff coverage is 66.0000%.

Flag
Coverage Δ

dm
51.8710% <ø> (-0.1276%)
:arrow_down:

engine
62.6676% <66.0000%> (+0.0322%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #6855        +/-   ##
================================================
- Coverage   59.9224%   59.8300%   -0.0925%
================================================
  Files           783        785         +2
  Lines         89519      89425        -94
================================================
- Hits          53642      53503       -139
- Misses        31168      31213        +45
  Partials       4709       4709

/hold

/remove-status ptal

This pr has something conflict with the pr of CharlesCheung96.
Hold it now.

/unhold
/status ptal

/merge


Remove all references to operator names in the code

The library should not have info about operators, just the MNO ID. Now we use a small dict so that we can use connect(operator='telia')
it would be better to have the library just handle mno_id (24001 for telia) and have the program using the library provide shortcuts to mno_id if needed.


JBDS-3869 DevSuite Installer should check/warn if Hyper-V is already enabled (win32)

JBDS-3869 DevSuite Installer should check/warn if Hyper-V is already enabled (win32)

Current coverage is 80.96% (diff: 92.85%)

Merging #509 into master will increase coverage by 0.66%

@@             master       #509   diff @@
==========================================
  Files            25         25
  Lines          2324       2458   +134
  Methods         398        400     +2
  Messages          0          0
  Branches        209        212     +3
==========================================
+ Hits           1866       1990   +124
- Misses          458        468    +10
  Partials          0          0

Powered by Codecov. Last update fa87bbb...5cdefe4

test this


Fix Icons Visibility Issue

🚀 Pull Request
Description
This PR fixes an issue where the icon was not visible in certain components of the user interface. The issue was caused by incorrect styling or missing attributes, leading to the icon either not rendering properly or being hidden.
Fixes #120  (issue)
Type of Change
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Screenshot of final output/video

Pull the latest code
It has been resolved

Sir, You are not assign any label in it


Supports comparison of root class inherited objects in non ordered lists

Feature: Comparison of root class inherited objects in non ordered lists
	As a developer,
	I want to compare list of inherited object instances of a root class of my hierarchy,
	so that I see differences on matching paired object instance properties.

Background:
	Given there is specific class <Identifier> having properties
		| PropertyType | PropertyName |
		| string       | Code         |
		| string       | Type         |
		| string       | Source       |
	Given there is specific class <RootClass> having properties
		| PropertyType     | PropertyName |
		| List<Identifier> | Identifiers  |
		| string           | Description  |
	Given there is specific class <FirstChildClass> inherited from <RootClass> having properties
		| PropertyType | PropertyName  |
		| string       | LegalName     |
		| int          | EmployeeCount |
	Given there is specific class <SecondChildClass> inherited from <RootClass> having properties
		| PropertyType | PropertyName      |
		| string       | CounterpartyName  |
		| int          | SubsidiariesCount |
	Given there is specific class <ParentClass> having properties
		| PropertyType    | PropertyName |
		| string          | Name         |
		| List<RootClass> | Holdings     |

Scenario: Comparing two parent instance objects having child property with collection of root object inherited instances
	Given I received two different instances of <ParentClass> having different and various instances in Holdings container property
	And there is at least one instance of <IdentifierClass> in both hierarchies which equal on Code and Type properties
	And Collection Matching Specification attribute is as following:
		| Type                     | Identifiers                       |
		| typeof(Identifier)       | "Code", "Type"                    |
		| typeof(RootClass)        | "Identifiers", "Description"      |
		| typeof(FirstChildClass)  | "Identifiers", "LegalName"        |
		| typeof(SecondChildClass) | "Identifiers", "CounterpartyName" |
	When comparison logic performs collection matching on unordered list of <RootClass> instances
	Then it identifies instances of <RootClass> having at least one instance of <IdentifierClass>
	And it identifies instance of <Identifier> having the all matching identifiers property values
	And it compares the identified instances of <RootClass> in both lists where the Code and Type properties equal.

@znamenap The feature you have requested is very project specific.  I would just simply create a custom comparer.

I figured out it is achievable by moving two lines of code in the existing comparer, Currently, it throws exception but moving match specifications just before GetMatchIndex makes this feature working. Can this change been added into this? I can provide pull request to review.

Does it pass all of the existing unit tests?  Can you create a unit test for your specific case?

Yes - see the pull request details https://github.com/GregFinzer/Compare-Net-Objects/pull/59 .

Merged.  All tests are running.  Thanks!


Delete post requests and mutation hooks

Delete all post requests and connected with them mutation hooks. They are unnecessary, since we use wallet actions.

very old, lets close


Removing History CSS/JS

Removing History CSS/JS because we no longer have a Bureau History page.
Removals

Removing History CSS/JS

Testing

Run gulp build and observe that there were no errors.

Review

@KimberlyMunoz
@jimmynotjim
@anselmbradford

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

:100:  squash 'n' merge

:+1:


GitHub labels

Issue
Subject of the feature
We need unified labels so that to streamline issue handling across the collective.
Problem
The GitHub label defaults are broad and not very useful. With tooling it becomes easier to automate labels. We can benefit from that.
Expected behaviour
I propose the labels posted in the following comment. I got them by looking at electron/electron’s labels, MDX, unifiedjs/unified, remarkjs/remark, and recent issues across the collective.
These labels are scoped with a prefix to group them together and add a bit more context.
After these labels are added, we can streamline the triage process as well. For inspiration, see Electron’s triage process guide.
Questions

Are these labels useful and usable?
Are there other labels needed?
Suggestions on my emoji game? 😏

/cc @unifiedjs/core

Proposal
Status
Status labels can be used to review the current work log with a GitHub search.  Issues and PRs should have exactly one status label.

🔍 status/open - Newly reported bug or proposed feature
The issue is open
🙆 status/confirmed - A member reproduced the bug or agreed with the feature
The issue is open and confirmed
🚫 status/wontfix
This is not (enough of) an issue
🥂 status/merged
The issue is solved
⛵ status/released
The issue is released

Blocked
Open and confirmed issues can be blocked from progressing:

🌊 blocked/upstream
The issue cannot progress till work is done somewhere else
🗳 blocked/vote
The issue cannot progress till further comments
🛠 blocked/wip
The issue is being worked on

SemVer
Issues that affect the interface (API, CLI, input, output) must have exactly one semver label.

👶 semver/patch - Backwards-compatible fixes
🧒 semver/minor - Backwards-compatible functionality
🧑 semver/major - Incompatible changes

Type of issue
There are different types of issues.

📣 type/announcement
💬 type/discussion
🙋 type/question
🐛 type/bug
🦋 type/enhancement

Area of issue
Issues affect different areas.

📦 area/dependencies
📚 area/docs
👀 area/external
🗄 area/interface
🏁 area/performance
🔒 area/security
🕸 area/test
🏗 area/tools
☂ area/types

Affected platform
Some issues affect a certain platform.

🌐 platform/browser
🐢 platform/node
🐧 platform/linux
🍏 platform/macos
📎 platform/windows

Other
Good first issues can be created as “bait” for potential contributors.
Help wanted signals a) opinions are welcome or b) slightly harder issues.

👋 good first issue
🙏 help wanted

GitHub has special handling for the "help wanted" label

Does adding an emoji in front impact the (# issues need help) messaging?

@ChristianMurphy That’s a very good question! I searched for “React” and looked at what GitHub shows when you click that link:

GitHub detects what labels you have. If you have help wanted, it’ll pick that. If you have good first issue, it’ll use that. It prefers help wanted.
If you have such a label, it links to a search: label:"help wanted" is:issue is:open, and that count is shown everywhere
It’s case insensitive, Help wanted also works
It supports emoji, and transforms them back into gemoji (when possible?! not all emoji have an available gemoji shortcode):
https://github.com/infinitered/reactotron/issues?q=label%3A"help+wanted+%3Awave%3A"+is%3Aissue+is%3Aopen

Yay! Thanks for taking this on, I've been wanting this for a while!
I'd like to propose also adding some sort of "awaiting response" (🧘♀ status/waiting or something) label which indicates an issue has been initially triaged but requires additional information or a reproduction.
It'd be cool to also keep the label colors consistent across repos, too (IMO).

Waiting: I like the idea of that, could you confirm if my thinking matches yours?
status/waiting is applied (and status/open removed) when there’s an initial response from a maintainer and it may go somewhere, but the complete picture isn’t really there yet. The issue (or its solution) aren’t confirmed yet?
Colors: Yes!! Do you have a nice cooler scheme we can use? I’m thinking one colour per group, and slightly rotated hue or more/less lightness per label in the group?

Waiting: I like the idea of that, could you confirm if my thinking matches yours?
status/waiting is applied (and status/open removed) when there’s an initial response from a maintainer and it may go somewhere, but the complete picture isn’t really there yet. The issue (or its solution) aren’t confirmed yet?

Yeah, exactly what I was thinking.

Colors: Yes!! Do you have a nice cooler scheme we can use? I’m thinking one colour per group, and slightly rotated hue or more/less lightness per label in the group?

I don't have a color scheme on the top of my head right now, but yeah it'd be rad to rotate colors slightly in each group.

[is there a] nice [color] scheme we can use?

Maybe use the same color palette as the unified project logos use?

This is a lot of labels. About 33. Do we need them all?

I think 33 overall labels is fine. :man_shrugging:
Only 5 or so will be applied to each PR, and with prefixing they should be pretty easy to find.

Love it!
Oh, one other thing, on MDX I use an "rfc" label in place of maintaining an RFC repo since they're few and far between. I dunno if that fits in here or not, since it seems slightly different that "discussion" 🤔

@johno Please check your usage and whether it matches this proposal, could definitely be something missing!
I had type/discussion and type/rfc in here, and I opted to keep only the first because it’s broader, so it may be used for more things, and it’s not an acronym (RFC may be unknown to people).
Don’t have strong feelings though!

Yeah I'm cool to run with type/discussion for now and can open up an issue later if I find it doesn't seem to be working so we can revisit 👍

So I found that 🙏 help wanted does not work (neither does :pray: help wanted). GH seems to accept other stuff only at the end (like emoji, gemoji), as in, there’s something like a/^help[ -]wanted/ regex.
I’m going with emoji at the end in good first issue and help wanted!


Problems with Microsoft Edge

Hi,
AFAICT, the Mandelbrot demo for wasm-bindgen-rayon cannot be run on Microsoft Edge Version 129.0.2792.52. Instead, it freezes.
In general, Edge seems to always freak out when running wasm-bindgen-rayon. For example, even if a wasm-bindgen-rayon powered webpage does not freeze, this webpage crashes when opening Edge's DevTools

That's odd, it works fine for me in Edge 129.0.2792.65, only slightly newer than yours. And it worked fine in the past as well.
Might be something with your local environment, but without more details or repro steps it's hard to tell.

Hmm yeah. I can confirm that it works on Linux + Edge as well. I had some problems with running it on Windows + Edge though. Probably need to investigate this further


[Fun] Introduce StreamSSHCommand function

I thought it would be nice if we could get some output from the various drivers while we're doing provisioning.  E.g. if we call curl get.docker.com | sh over SSH it'd be quite nice to see the output of the script as its running to get a feel for how far along it is (or what went wrong if something does).  This function will stream the output of an SSH command as it is running.  It is used like:
// suppose we are in digitalocean driver (d)
if err := drivers.streamSSHCommand(d, "echo foo"); err != nil {
    return err
}
if err := drivers.streamSSHCommand(d, "echo bar"); err != nil {
    return err
}
if err := drivers.streamSSHCommand(d, "echo quux"); err != nil {
    return err
}

Output:
digitalocean | foo
digitalocean | bar
digitalocean | quux

Wasn't sure about placement etc. so I put it here.  WDYT?
Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>

I'm not sure about the prefix. I like the ability to just copy output from my terminal.

Actually as I think about it now, I don't think I like the prefix.  Since we only currently support running commands against a single machine, I'm not sure what purpose the prefix serves.  Other than that, LGTM


For custom dataset with a precise mask

Hello, great work! I would like to use the stableVideo method on a custom dataset, which has a clear mask representing the foreground objects. Is it possible to skip the Neural Layered Atlas (NLA) and directly edit the foreground and background without the need for training?

hi for now NLA is necessary to conduct editing


Add inherent field for the user who last updated the Organization element

It'd be nice to know who last updated the organization. Similar author on entries.

I go back and forth on this...whether it should be part of this plugin or if it's better suited as an 'audit' plugin that this one integrates with.  Thinking element revisions without all the content.
Thinks to consider: Updates made through the CLI do not have an identity ... how to record those.

That makes sense I'll close this and we can reopen as needed.


gates should implement an interface

every gate should implement the same clear interface
every gate should also return a vector of constraints, and we should have some logic that always combine these constraints (so we can't forget to combine them)

cc @jspada @querolita

Currently the prover code looks like a lot of repeat of this:
            let emulscalar8 =
                endomul_scalar::constraint(range::ENDOMUL_SCALAR.start).evaluations(&env);
            t8 += &emulscalar8;

            if cfg!(test) {
                let (_, res) = emulscalar8
                    .clone()
                    .interpolate()
                    .divide_by_vanishing_poly(index.cs.domain.d1)
                    .unwrap();
                assert!(res.is_zero());
            }

it'd be really awesome if we can just have something like that:
for gate in gates {
   let gate_eval = gate.evaluations(&env);
   test_gate!(gate_eval);
   evaluation += gate_eval;
}

Actually I thought we were thinking of some trait for gates to have a common set of functions such as create, verify, gadget or similar.

I have a PR out to add an interface for gates: https://github.com/o1-labs/proof-systems/pull/295
I don't think we can create an interface for create, as different gates take different inputs. Although... saying that I think the following interface would work:
pub trait Gate {
   type Inputs;
   fn create(input: Inputs, ...) -> ...
}


Error trigger when it should not ?

Hi,
can you please confirm if this is a bug or a problem with my code:
export let validationResult = function (fields:Object):IErrorReturn {
    // Create a model instance
    let directoryModel:IDirectoryLink = new DirectoryModel(fields)

    // Make sure all public field entered by user are valid
    let validationErrors = ValidationErrors(directoryModel)

    // If there are no validation errors returned...
    if (validationErrors === g.error.no) {
        // Return to the controller to inform the form is valid with no error
        return {
            error: g.error.no,
            model: directoryModel, // ERROR HERE
            errorBag: g.IsEmpty.empty
        }
    } else {
        // Return to the controller to inform there are errors and which are they
        return {
            error: g.error.yes,
            model: g.IsEmpty.empty,
            errorBag: validationErrors
        }

    }
}

and here are the interfaces:
declare type IDirectoryLink =
{
    link_title: string,
    link_desc: string,
    link_long_desc: string,
    link_url: string,
    link_note: string,
}

declare interface IErrorReturn {
    error: number,
    model: IDirectoryLink | string,
    errorBag: ([string, string] | number)[] | number  | string
}

in another, global file:
export let IsEmpty =
{
    empty: "empty",
    notEmpty: "notEmpty"
}

As you see IErrorReturn model accepts either an IDirectoryLink or a string. Yet when I pass it a directoryModel object which is of type IDirectoryLink it triggers this error:
195:             model: directoryModel,
................................^^^^^^^^^^^^^^ object type. This type is incompatible with
21:     model: IDirectoryLink | string,
...............................................^^^^^^ string. See lib: interfaces.js:21
I don't understand why it compares directoryModel against string, since string is not enforced and there is the good corresponding IDirectoryLink interface option.

Closing since this issue hasn’t seen a lot of activity. Sorry about that 😣
Please reopen with a reproduction on https://flow.org/try if you are still having issues!


Wrapup fixes for TP-59

Fixes after feedback from UAT:
List (TP-614)

Regulation ID -> ID (We already say "Regulation" in very large text above it and this is consistent with other screens)
Details: (TP-613)

Regulation ID -> ID (We already say "Regulation" in very large text above it and this is consistent with other screens)
Version control(TP-135)

Details -> Title for consistency with other screens

Codecov Report

Merging #249 (9700d00) into master (c5c3788) will decrease coverage by 0.01%.
The diff coverage is n/a.

:exclamation: Current head 9700d00 differs from pull request most recent head 6dc87a3. Consider uploading reports for the commit 6dc87a3 to get more accurate results

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   62.15%   62.14%   -0.02%
==========================================
  Files         186      186
  Lines       11576    11578       +2
  Branches      877      877
==========================================
  Hits         7195     7195
- Misses       4185     4187       +2
  Partials      196      196

Impacted Files
Coverage Δ

quotas/models.py
2.08% <0.00%> (-0.05%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5c3788...6dc87a3. Read the comment docs.


x/tools/gopls: find-references results returned in random order

Find-references (and find-implementations, and go-to-definition) should give results back in a consistent order. Currently I see a random order (sometimes it is random every time, other times it seems consistent for a while then changes). For example:
package main

func _() {
	var foo int

	_ = foo
	_ = foo
}

Finding references on "var foo int" I get back lines [5, 6] then [6, 5] in the next request.

Trace - 09:43:37 AM] Sending request 'textDocument/references - (14764)'.
Params: {
  "textDocument": {
    "uri": "file:///Users/muir/scratch/foo/foo.go"
  },
  "position": {
    "line": 3,
    "character": 5
  },
  "context": {
    "includeDeclaration": false
  }
}

[Trace - 09:43:37 AM] Received response 'textDocument/references - (14764)' in 5ms.
Result: [
  {
    "range": {
      "end": {
        "character": 8,
        "line": 5
      },
      "start": {
        "character": 5,
        "line": 5
      }
    },
    "uri": "file:///Users/muir/scratch/foo/foo.go"
  },
  {
    "range": {
      "end": {
        "character": 8,
        "line": 6
      },
      "start": {
        "character": 5,
        "line": 6
      }
    },
    "uri": "file:///Users/muir/scratch/foo/foo.go"
  }
]

[Trace - 09:43:42 AM] Sending request 'textDocument/references - (14766)'.
Params: {
  "textDocument": {
    "uri": "file:///Users/muir/scratch/foo/foo.go"
  },
  "position": {
    "line": 3,
    "character": 5
  },
  "context": {
    "includeDeclaration": false
  }
}

[Trace - 09:43:42 AM] Received response 'textDocument/references - (14766)' in 0ms.
Result: [
  {
    "range": {
      "end": {
        "character": 8,
        "line": 6
      },
      "start": {
        "character": 5,
        "line": 6
      }
    },
    "uri": "file:///Users/muir/scratch/foo/foo.go"
  },
  {
    "range": {
      "end": {
        "character": 8,
        "line": 5
      },
      "start": {
        "character": 5,
        "line": 5
      }
    },
    "uri": "file:///Users/muir/scratch/foo/foo.go"
  }
]

Perhaps we can sort first by file name, then secondarily by offset within file? Maybe also sort files from the starting package first?
Clients can still customize the sorting if they want, but I think gopls should return consistent results and results within a file should be ordered as they appear in the file.

Related: https://github.com/golang/go/issues/32572

Related: #32572

Thanks, forgot about that discussion.
To cover my bases I opened https://github.com/emacs-lsp/lsp-mode/issues/2099 with regard to my client not sorting.
@myitcv do govim and vim-go sort the results?

@muirdm

do govim and vim-go sort the results?

govim does, yes:
https://github.com/govim/govim/blob/be5a1e7a2db7f531a4f49cc1a2982a59f9478ac2/cmd/govim/util.go#L139-L182
Notice the workaround required for not sorting when we know the first result to be the definition location.

cc @bhcleek for vim-go

yes, vim-go also sorts them: https://github.com/fatih/vim-go/blob/bd56f5690807d4a92652fe7a4d10dc08f260564e/autoload/go/lsp.vim#L836

I continue to maintain that clients should sort if they want sorted results, but we should also probably return deterministic results. I'll send a CL to sort the results.

I continue to maintain that clients should sort if they want sorted results, but we should also probably return deterministic results. I'll send a CL to sort the results.

The problem as I understand it is that nowhere in the spec is it declared that the first result will be the definition (there could, in other languages, be other nuances). Hence, to avoid clients having to special case the sort, the server needs to define the meaning and hence sort the results.

Oh wow, I genuinely didn't realize that wasn't in the spec. I wonder why we did it that way then. In that case, I'm really not sure how the results should be sorted at all.

I also tend to believe that sorting shouldn't be guaranteed and that it's up to clients to do that if they want to present sorted results and that a server guaranteed deterministic order isn't worth the trouble.

@bhcleek

up to clients to do that if they want to present sorted results

How does a generic LSP client do this in a language agnostic way? How does the client know that it should sort references[1:] instead of the entire references slice (because I would venture to suggest it does make sense for the first reference to be the definition in the case of Go).
@stamblerre

I'm really not sure how the results should be sorted at all.

As a first cut my suggestion would be:

definition first
then results within the main module, ordered lexicographically
then results from outside the main module, ordered lexicographically

How does a generic LSP client do this in a language agnostic way?

I don't understand the question. What needs to be language agnostic about sorting locations?

How does the client know that it should sort references[1:] instead of the entire references slice (because I would venture to suggest it does make sense for the first reference to be the definition in the case of Go).

Why should the definition be first as a general rule? I'll grant you that I can see reasons for that, but ultimately I think it should be up to the client, not the server.


Some functionalities broken since 0.2.0

Hi,
The extension was working fine in 0.1.4 but since the update, to 0.2.0 (and also in 0.2.1) the following is not working:

Showing parent/children models (is always empty)
Go to definition
Autocompletion

This is still working:

The "play" button to run the current model
The snippets (typing ref suggests {{ref('')}}

This time, I have an error appearing in the Dev Tools:
We should never come here, means that our exceptions are not handled! (at DBTManifest.<anonymous> (/Users/xxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.1/out/dbtManifest.js:64:25))

Switching back to 0.1.4 makes everything work fine again.

This means  that the manifest is not able to be parsed, there is a unhandled exception in the refresh of the manifest, however we don't get the actual error as we forgot to log it.
I'm not able to reproduce your issue with latest version. Did a diff between the versions, but no immediate clue on what's going.
I will make an update to add this logging, would you try again?
In the future we will need to add telemetry so exceptions are reported back to us.

Of course I am happy to help debugging the issue, I really like what your extension is doing!
Here is the error with 0.2.2:
We should never come here, means that our exceptions are not handled! TypeError: Cannot convert undefined or null to object
	at Function.values (<anonymous>)
	at DBTManifest.createSourceMetaMap (/Users/xxxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.2/out/dbtManifest.js:131:16)
	at DBTManifest.<anonymous> (/Users/xxxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.2/out/dbtManifest.js:89:40)
	at Generator.next (<anonymous>)
	at /Users/xxxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.2/out/dbtManifest.js:8:71
	at new Promise (<anonymous>)
	at __awaiter (/Users/xxxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.2/out/dbtManifest.js:4:12)
	at DBTManifest.refresh (/Users/xxxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.2/out/dbtManifest.js:74:16)
	at DBTManifest.<anonymous> (/Users/xxxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.2/out/dbtManifest.js:61:28)
	at Generator.next (<anonymous>)
	at /Users/xxxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.2/out/dbtManifest.js:8:71
	at new Promise (<anonymous>)
	at __awaiter (/Users/xxxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.2/out/dbtManifest.js:4:12)
	at DBTManifest.tryRefresh (/Users/xxxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.2/out/dbtManifest.js:59:16)
	at activate (/Users/xxxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.2/out/extension.js:16:39)
	at Function._callActivateOptional (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:916:841)
	at Function._callActivate (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:916:492)
	at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:914:724
	at processTicksAndRejections (internal/process/task_queues.js:94:5)
	at async Promise.all (index 0)
	at async Promise.all (index 84)
	at async Promise.all (index 1) (at DBTManifest.<anonymous> (/Users/xxxx/.vscode-insiders/extensions/innoverio.vscode-dbt-power-user-0.2.2/out/dbtManifest.js:64:25))

Huh, that's interesting, that means there is no "sources" key in the manifest file. Could you validate this? Just search for the following string  "sources": { inside the manifest.json file in the target folder.
What version of dbt are you using?

That's it. I am currently using dbt==0.15.2 due to compatibility issues for later versions with dbt-sqlserver
Running cat target/manifest.json | jq '.sources' after generating manifest.json via dbt 0.15.2 returns NULL.
But if I run the same command with dbt 0.18rc1 it returns some values and the extension works again (but I can't really use 0.18 yet on my project until it is officially released and dbt-sqlserver is updated to work with 0.18).
Not sure if it is worth updating the extension or just mentioning in the README that it works only from a specific version of dbt.

So are you using sources within your project? if so how are they represented n the manifest file? If it's not too hard we can add support.
In all caes the failure of manifest parsing in one part (sources) should not impact the others (models, macros, ...). I am going to push out some fix to provide more isolation.

Yes, we are using sources.
In 0.15.2 the sources for each model are stored under nodes > [model_name] > sources.
And it seems that the list of all sources for a given yml file is stored under files > [file_name] > sources but I couldn't find a single parameter holding the list of all sources across all yml files.


FeatureProposal: update signer or provider with sdk.useSigner & sdk.useProvider respectively

const sdk = new APWineSDK({ signer, provider, ... })

sdk.useSigner()
//or
sdk.useProvider()

the two functions let you decide, on what will be passed to other sdk functions. When calling these, the following contracts will also be reinstantiated with the value in sdk.signerOrProvider:

sdk.Registry
sdk.AmmRegistry
sdk.Router
sdk.Controller

By default if exists (since its not mandatory), the signer will be used, otherwise the provider.
If the instance is used for just fetching, it's better to switch to the Provider, since the sdk automatically wraps it into a MulticallProvider

Hm, what is wrong with the build?

Hm, what is wrong with the build?

I haven't set up any pipelines so this is some default stuff, which is failing.

Following our discussion today, it that adds more flexibility while not changing the basic flow for a "regular" user (think workshop for instance) then let's go for it :-)


fixes #5648

Signed-off-by: jonsmith1982  - Sorry, I sent a patch to fix this in the original post. Just getting used to git and how best to do things.

Hmm, I had something different in mind; i.e. incorporating the whole thing into log_path with the possibility to parse date formats, but this is decent too. Not sure right now.
But you did raise a good point in #5648 about log_file_extension and I don't think leaving it as is would be OK.


Unit tests for strategizer

There are a batch of tests under runtime/test/strategies now. But maybe this was about adding unit tests for the strategizer at a level above the individual strategies?

yes, this is for tests for the strategizer itself, not strategies.
the individual strategies have reasonable test coverage, i think.


Expose clear button

Expose the clear button publicly, so that it can be altered in both behavior and style.

Thanks! 👍


Use edit_settings for viewing and modifying package settings

Addresses #22
Consolidated 'Settings - Default' and 'Settings - User' to a single
entry, 'Settings'.
Settings files are now opened using the edit_settings command, which
opens both Default and User settings in separate columns.
Command definitions were reduced to a single item by making use of the
${platform} environment variable, which, when expanded, provides the
host system's platform name.

Thanks for the PR!
According to https://www.sublimetext.com/docs/3/build_systems.html I think we will also need the corresponding linux, osx, and windows sublime-settings file to match the $platform argument. Would you like to add them to this PR? If not, I don't mind adding them.

No problem!
Sorry about not including the platform-specific files, I forgot to check.  I pushed a new commit that includes separate definitions.  It looks like OSX defaults to ~/opt if using the graphical installer, and ~ if using the command line version.  To keep everything in line with the current settings, the OSX file has the same values as the Linux version.

Looks great and works fine for me on Linux. Thanks again for the PR!


Build failure: arrayfire: dependency marked insecure

Steps To Reproduce
nix build nixpkgs/29e4c2ef170e66021e31b3612cc4516c1abf940a#arrayfire
Build log
<snip>

       error: Package ‘freeimage-unstable-2021-11-01’ in /nix/store/ppniwca1rrbyywfqgp80xx1lxrdripp9-source/pkgs/development/libraries/freeimage/default.nix:72 is marked as insecure, refusing to evaluate.

       Known issues:
        - CVE-2021-33367
        - CVE-2021-40262
        - CVE-2021-40263
        - CVE-2021-40264
        - CVE-2021-40265
        - CVE-2021-40266
        - CVE-2023-47992
        - CVE-2023-47993
        - CVE-2023-47994
        - CVE-2023-47995
        - CVE-2023-47996

<snip>

Additional context
On today's head, 29e4c2ef170e66021e31b3612cc4516c1abf940a.
Notify maintainers

@chessai
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.27, NixOS, 23.11 (Tapir), 23.11.20240414.6ec8515`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Add a :+1: reaction to issues you find important.

reported upstream: https://github.com/arrayfire/arrayfire/issues/3547


Fixes the NSRange to use a String defined range instead of inferring length from the count property

Fixed
String.count shouldn't be used to create NSRange. See the comment on https://stackoverflow.com/questions/27880650/swift-extract-regex-matches#comment110787889_54900097

Be careful with above solution: NSMakeRange(0, self.count) is not correct, because self is a String (=UTF8) and not an NSString (=UTF16). So the self.count is not necessarily the same as nsString.length (as used in other solutions). You can replace the range calculation with NSRange(self.startIndex..., in: self) – pd95 Jun 29 at 22:27

Thanks for the great repo!

Thanks, @adamwulf.


Draft Meltano 3 Year Strategy + 1 Year Plan

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/1027
Originally created by @dmor on 2019-09-23 16:04:22

Inspiration
https://about.gitlab.com/direction/cicd/#cicd-strategy
This seems like a really great way to structure our thinking

View 1 previous comment from the original issue on GitLab


1845 update timeline app

network_config.xml should be updated settings related to geoserver_jwt_proxy_geoserver_twa_wfs

transport mode data not add in ontop.obda. No transport data recorded in the database yet


Does not add comments with few lines of text

Description
Does not add comments with few lines of text

Steps to reproduce the issue:
f.AddComment("mySheet", "A1", 				`
{"Author": "darvin:",
"Text": " line
a new line
an another new line"}`)

Describe the results you received:
invalid character '\n' in string literal
Describe the results you expected:
added comment to cell
Output of go version:
go version go1.12.9 linux/amd64

Excelize version or commit ID:
v2.1.0

Hi @SavostinVladimir, a new line is denoted using \r\n:
f.AddComment("mySheet", "A1", `
{"Author": "darvin:",
"Text": " line\r\na new line\r\nan another new line"}`)


windows: Utils

Windows Python profiler split PR
Description
This split PR contains changes to the metadata and utils packages. It also contains workarounds to the lack of availability of windows specific packages imported by the utils package on Linux environments. Without these workarounds, the linter fails with missing library stub errors.
Related Issue
See PR for complete details

You can merge from master post #519 to solve the lint failures

@teoluwaf , I'll do the final review now, please also merge from master to resolve conflicts

Seeing import errors:

E   AttributeError: partially initialized module 'gprofiler.metadata.application_identifiers' has no attribute '_ApplicationIdentifier' (most likely due to a circular import)

Also, PyInstaller complains about the installations of Windows-specific libraries missing on Linux (this is from the CI):
#127 58.80 missing module named wmi - imported by gprofiler.utils (conditional)
#127 58.80 missing module named pythoncom - imported by gprofiler.utils (conditional)
#127 58.80 missing module named netifaces - imported by gprofiler.metadata.system_metadata (conditional)
#127 58.80 missing module named tests - imported by gprofiler.metadata.system_metadata (top-level)
#127 58.80 PyInstaller failed to pack gProfiler code! See lines above. Make sure to check for SyntaxError as this is often the reason.

I bet there is some way to tell it "this import isn't really needed", or "needed only on platform == windows.

@teoluwaf you can debug the build locally with ./build_x86_64_executable.sh

I checked that check_pyinstaller.sh works as expected, i.e - injecting an error causes the build to fail.


big duniverses exceed layer count in depext calculation

The COPY and opam pin strategy for depext calculation leads to a large number of layers in the resulting Dockerfile.  There is a limit (127) of these in the engine, which leads to build failures.
I think we need a more efficient (but still cache-friendly) way to do the opam pin / depext dance that doesn't add a lot of layers.  Some options:

copy all the opam files into a single directory and then pin them all there. This would let it work in a single COPY command.
we could create a new layer for all the opam pins, and subsequently roll that back.

I suspect the first option is best...

Another way would be to tar them up and then ADD the tar file (Docker might even untar it automatically; can't remember).

indeed! This is supported with ADD: https://docs.docker.com/engine/reference/builder/#add

If  is a local tar archive in a recognized compression format (identity, gzip, bzip2 or xz) then it is unpacked as a directory. Resources from remote URLs are not decompressed. When a directory is copied or unpacked, it has the same behavior as tar -x, the result is the union of:

Was fixed in #142.


[Linux] Unable to run VTFEdit:R

Description
When I tried to run it, I got an error about missing libvtflib.so
What has been done
I set LD_LIBRARY_PATH to VTFEdit:R directory and this fixed the first error, but created two qt 6.7 new ones
Screenshots

Other Info
Distro: Arch Linux
Kernel: 6.8.7-arch1-1

This should now be fixed. If the issue still occurs, reopen. If it's a different issue, make a new issue.


New Trainee Tracker

Is your feature request related to a problem? Please describe.
Current trainee tracker does its job, but we want to have software in place instead of a spreadsheet
Describe the solution you'd like
@SallyMcGrath to detail
Describe alternatives you've considered
@SallyMcGrath to detail
Additional context

I think this is on another board and in another project now


[Bug] Where condition is not functional for value "NA"

Description:
If the page contains NA in any column the data can not be fetched and gives an error and throws an error for any other true statement.
Steps to reproduce:

Create an API of Gsheet
Add to fetch rows
Add required fields
Add "where "condition (sl no == NA)
ensure the sheet contains NA

Observation:
It is observed that an error is displayed to the user
Expectation:
Result must be displayed to user
Video

This is happening because slno has number values for the top few rows and NA is a string value. If a column has been tagged as a number value, string "NA" has failed to be parsed as a number.

Duplicate of #7794

closing since its duplicate


documentation conflict

While reading the article Tutorial: Create a Windows service app, I noticed:
[StructLayout(LayoutKind.Sequential)]
public struct ServiceStatus
{
    public int dwServiceType;
    public ServiceState dwCurrentState;
    public int dwControlsAccepted;
    public int dwWin32ExitCode;
    public int dwServiceSpecificExitCode;
    public int dwCheckPoint;
    public int dwWaitHint;
};

If one refers to SetServiceStatus function (winsvc.h) and SERVICE_STATUS structure (winsvc.h) one sees the following:
typedef struct _SERVICE_STATUS {
  DWORD dwServiceType;
  DWORD dwCurrentState;
  DWORD dwControlsAccepted;
  DWORD dwWin32ExitCode;
  DWORD dwServiceSpecificExitCode;
  DWORD dwCheckPoint;
  DWORD dwWaitHint;
} SERVICE_STATUS, *LPSERVICE_STATUS;

According to Windows Data Types, DWORD, is A 32-bit unsigned integer which according to Built-in types (C# reference), should be uint. (or System.UInt32) not int.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 75152e30-b486-3ba0-c606-25ada7347b22
Version Independent ID: e797ddfe-a9d3-93a4-61bd-fd6dc9b8d6b4
Content: Tutorial: Create a Windows service app - .NET Framework
Content Source: docs/framework/windows-services/walkthrough-creating-a-windows-service-application-in-the-component-designer.md
Product: dotnet-framework
GitHub Login: @gewarren
Microsoft Alias: dotnetcontent

@AaronRobinsonMSFT Can you help with this question? Should a DWORD be mapped as int or uint?

@cgeier This is a good question and something we are rather poor at for a few reasons. The primary case though is unsigned integers are not CLSCompliant, which means VB.NET cannot use types with unsigned integers. In practice, since this is at an interop boundary it doesn't matter whether it is signed or unsigned.

@AaronRobinsonMSFT: Would that mean that this is true for C# as well? According to Native interoperability best practices, DWORD is uint in C#.

Would that mean that this is true for C# as well?

No. C# has support for unsigned integers. However, if a type is defined with a uint field then it can't be consumed from VB.NET. This means that most older interop documents use int. Going forward, it is quite possible to use uint if that is desired, but sometimes that is more cumbersome and pedantic for now practical gain. For example, many Win32 APIs state DWORD for a length argument for a passed in output buffer length. Consider ReadFile(), which could be defined as follows in a P/Invoke signature.
[DllImport("Kernel32")]
bool ReadFile(
    SafeHandle hFile,
    [Out] byte[] lpBuffer,
    uint nNumberOfBytesToRead,
    ref uint lpNumberOfBytesRead,
    IntPtr lpOverlapped);

The issue with this definition is there is no technical need for nNumberOfBytesToRead defined as uint. In fact it can make use annoying because one must now cast the Length property value to uint from the passed in buffer. The same is true for the lpNumberOfBytesRead, because the caller likely is going to pass that to some other .NET API that accepts int for the same CLSCompliant reasoning.
Yes, the DWORD type represents an unsigned integer, that is true. We define those best practices to help users understand what is most appropriate and accurate. In this case, the sample is a practical example where following the strict guidelines reduces utility.

Thanks @AaronRobinsonMSFT. I'm going to close this issue as resolved now.


[Question] Encryption Password

Hi, I just wanna ask about encryption password. Are you using bcrypt for the encryption? Thank you

We use Laravel's hashing method.

That is bcrypt.


add bluesky to oauth providers

I'm not planning working on other OAuth2 providers but user contributions are welcomed (as an example you can refer to the recent WakaTime and Notion prs).


Pass Int32 to db as integer

Closes #122.

I just rebased this. Is it okay to merge or is it missing something?

@mikeeus If you have a moment could you rebase this? If you're busy no problem. LMK and I'll branch and rebase it

Hey Paul, I reforked lucky_record and deleted my old fork because it was giving me issue before so I don't have access to the repository that I used to make this pull request (it says unknown repository).
How can I get access to this branch again to rebase it?

I would try installing https://github.com/github/hub and then do hub checkout https://github.com/luckyframework/lucky_record/pull/124. I think that should work!

Closing because I made a new pull request from my new fork.


add github action to run tests

@vrajmohan Tests are now fixed in this PR and other PR is deleted.


Last TON support updates into pod.spec

Hello, changes are not being pulled in cocoapods, with the added TON blockchain.  could you please update to be able to use the tone , via cocoapods main connection.

The process is automated when we do a new release. You will have to wait the next Release.


Forced line breaks aren't working in desc text of horizontal dlist

For some reason, forced line breaks aren't working in the primary description text of an item in a horizontal dlist.
Example:
[horizontal]
term::
desc +
more desc

The problem is that subs aren't being applied to the generated paragraph block.


Inter font Updated

Fixes: #39
I have updated the website to have Inter Font everywhere.

@anushbhatia kindly review this PR

Hey @smaranjitghose can you please add the JWOC and difficulty labels else the PR wont be considered


javafx/tools: Remove web pods datasource

.. because pods is actually not built, so web pods won't be found

diirt needs to merge Issue37-use-java-time into master where some pods datasource was removed from the build to allow it to succeed.
But the merge request from simply pressing the "create pull request" button results in a merge request into diirt/diirt, while we need ControlSystemStudio/diirt.

This pull request looks ok to me (i.e. it looks like it will merge into ControlSystemStudio:diirt/master).  Am I missing something?
I need this change for diirt to build.


Release candidate 2.0.1

Coverage remained the same at 100.0% when pulling 3cdee5eb4efa4cf12e4710b961b96c4ba9f03db6 on ReleaseCandidate-2.0.1 into 9b669ec89e8c7cdb39f4b2a296607332b745e3e4 on master.

Coverage remained the same at 100.0% when pulling 3cdee5eb4efa4cf12e4710b961b96c4ba9f03db6 on ReleaseCandidate-2.0.1 into 9b669ec89e8c7cdb39f4b2a296607332b745e3e4 on master.

Coverage remained the same at 100.0% when pulling 3cdee5eb4efa4cf12e4710b961b96c4ba9f03db6 on ReleaseCandidate-2.0.1 into 9b669ec89e8c7cdb39f4b2a296607332b745e3e4 on master.

Coverage remained the same at 100.0% when pulling 74dc83a8f241306c3dd27cccf7faf58604b60683 on ReleaseCandidate-2.0.1 into 9b669ec89e8c7cdb39f4b2a296607332b745e3e4 on master.

Coverage remained the same at 100.0% when pulling 1c70f8f609551eb776d5d3b0fa420fafcc65568f on ReleaseCandidate-2.0.1 into 9b669ec89e8c7cdb39f4b2a296607332b745e3e4 on master.

Coverage remained the same at 100.0% when pulling 1c70f8f609551eb776d5d3b0fa420fafcc65568f on ReleaseCandidate-2.0.1 into 9b669ec89e8c7cdb39f4b2a296607332b745e3e4 on master.


Updated common vars to mirror the repo location change.

Due to the recent location change for openstack-ansible the common
vars for the juno rpc-openstack needed to be updated to mirror the
upstream change. This was causing the dynamic inventory script to
fail due to a unkown file location
This fixes issue #404

Travis is angry because we don't have it configured for this branch. :+1: from me anyway

:+1:


Add CI step to clear S3 buckets when tests fail

Enabler
So that we don't have to clear out CI stacks manually, we want to delete S3 files stopping the teardown in case of certain test failures.
Acceptance Criteria

[ ] S3 staging/Geostore buckets are emptied after failing tests.
[ ] S3 staging/Geostore buckets are not emptied after successful tests (we want to make sure we detect missing cleanup steps).

Additional context

Tasks

[ ] ...
[ ] ...

Definition of Ready

[ ] This story is ready to work on

[ ] Negotiable (team can decide how to design and implement)
[ ] Valuable (from a user perspective)
[ ] Estimate value applied (agreed by team)
[ ] Small (so as to fit within an iteration)
[ ] Testable (in principle, even if there isn't a test for it yet)
[ ] Environments are ready to meet definition of done
[ ] Resources required to implement will be ready
[ ] Everyone understands and agrees with the tasks to complete the story
[ ] Release value (e.g. Iteration 3) applied
[ ] Sprint value (e.g. Aug 1 - Aug 15) applied

Definition of Done

[ ] This story is done:

[ ] Acceptance criteria completed
[ ] Automated tests are passing
[ ] Code is peer reviewed and pushed to master
[ ] Deployed successfully to test environment
[ ] Checked against
CODING guidelines
[ ] Relevant new tasks are added to backlog and communicated to the team
[ ] Important decisions recorded in the issue ticket
[ ] Readme/Changelog/Diagrams are updated
[ ] Product Owner has approved acceptance criteria as complete
[ ] Meets non-functional requirements:

[ ] Scalability (data): Can scale to 300TB of data and 100,000,000 files and ability to
increase 10% every year
[ ] Scability (users): Can scale to 100 concurrent users
[ ] Cost: Data can be stored at < 0.5 NZD per GB per year
[ ] Performance: A large dataset (500 GB and 50,000 files - e.g. Akl aerial imagery) can be
validated, imported and stored within 24 hours
[ ] Accessibility: Can be used from LINZ networks and the public internet
[ ] Availability: System available 24 hours a day and 7 days a week, this does not include
maintenance windows < 4 hours and does not include operational support
[ ] Recoverability: RPO of fully imported datasets < 4 hours, RTO of a single 3 TB dataset
< 12 hours

Did this PR yesterday resolve this @l0b0 ? If so can you close this?

It should do. We won't know until something breaks again, but yeah :)


impl failure::Fail for failure::Error?

Any reason this isn't the case?
I am hitting the same issue as #67 , and it seems to me impl failure::Fail for failure::Error would solve it.

It would be incoherent because of the reflexive impl of From<T> for T and the impl of From<F> For Error where F: Fail.


Replace dep with go mod

Description
Changes proposed in this pull request:

replace dep with mod, this should be enough

Related issue(s)

/test all

/test all


Adds support for Gitpod

@jlengrand Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@jlengrand Thank you for signing the Contributor License Agreement!

See https://github.com/spring-projects/spring-petclinic/issues/955 for a complete description


View memberships and revoke

Allow viewing users of a workspcae + revoking them (but not edit their role back to something yet)

cc @gabhubert

(also fixes lint errors here and there)


Disabling status in discord tool (images downloaded)

Hello, I tried few times to disable discord status (pictures downloaded) in older versions because the newest don't working for me, just after setting up everything in config file I'm open the tool and wrote something on dsc chat but the bot don't want to respond. I downloaded older version: v1.36.2 or v1.37 there wasn't [status] in config so I had to add this manually, I was setting status enabled = false but this don't working, I still have status "downloaded pictures 0" Somebody know how to help me with this?

for the status thing to actually work the exe itself would need the code to actually check that part so ofc it wont work on older versions
try the newest one and del the old config and rewrite everything in the new config
also maybe check that the interactive channel is set
Unofficial image downloader support server
https://discord.gg/d8MYEC6


breaking change in v1.6.0: dropping node versions is semver-major

Even just the engines declaration here is a breaking change, and should have been v2. Please revert, and publish a new v1, and publish a v2 if you want to drop node < 18.

@ljharb thank you for the report!  Quoting our support policy here:

The Azure SDK libraries for JavaScript will not be guaranteed to work on Node.js versions that have reached their end of life. Dropping support for such Node.js versions may be done without increasing the major version of the Azure SDK libraries.

I see that you've documented it, but that means you're not following semantic versioning, which requires increasing the major here.

@ljharb I hear you that one interpretation of semver is to consider updating runtime support to be a breaking change. However, since we support multiple runtimes that have well-known support cycles (such as Node's LTS schedule), we have chosen to focus on breaking changes to the public API surface we provide.
This is in part to ensure that for those who are keeping their environments patched are able to get the latest fixes to the code that we own rather than forcing a developer to look at our CHANGELOG.md only to find out that no change within the package itself merits their consideration.
From https://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api:

What should I do if I update my own dependencies without changing the public API?
That would be considered compatible since it does not affect the public API.

As we do not consider runtime globals or syntax provided by the browser/node/etc to be part of our Public API, it is not considered a breaking change if we depend on features that are supported by our supported runtime matrix.
I hope this helps clarify our position and I strongly recommend you use a version of Node that is maintained due to the lack of security fixes for unmaintained versions.

@xirzec your interpretation contradicts the one the entire node ecosystem users, despite following the letter of the semver spec, and imo that's far more important.
@bterlson howdy! :-) basically, these azure packages are used in github's @actions/ packages, which i'm using in a github action, some parts of which still run in node 16. I plan to upgrade it to node 20 soon, but this means i can't update a patch version of the @actions package because it assumed, like everything in node does and should, that engines would never be dropped in a non-major.

I'm sorry, that does sound frustrating. That said, I don't think we will be changing our approach in general. As you say, the letter of the law as it were is not super relevant, what matters is what our users need from our packages, and weighing tradeoffs with that in mind. And our experience has been that incrementing major creates a large burden on our consumers and various undesirable outcomes that outweigh the downsides of dropping unsupported node versions in a minor release. AWS and GCP have come to similar conclusions for their JS libraries. I have also observed other projects following this general process in my travels, so while I can't comment on the overall prevalence of this approach, I feel confident in saying it is not unheard of.
One thing we could consider is dropping unsupported nodes less aggressively. That is something we can look in to!

Certainly if you'd only gone to >= 16, which is what github.com supports in actions, then I wouldn't have even noticed :-)

That's fair, thank you for letting us know about your experience too, super valuable!

This is in part to ensure that for those who are keeping their environments patched are able to get the latest fixes to the code that we own rather than forcing a developer to look at our CHANGELOG.md only to find out that no change within the package itself merits their consideration.

I don't see this as a big problem, since the node's LTS schedule is 30 months. What I mean is that developers would only have to check the changelog effectively every 2.5 years just when they were also about to update the version of Node itself, since its end of life would have reached. Well, that's my point of view, we also had our pipelines affected due to the use of appcenter-cli running on the reactnativecommunity/react-native-android:8 image that uses Node 16, we upgraded to version 9, which already uses Node 18, for us it wasn't a big problem, but for some it could be

More information on why node16 reached EOL earlier than usual: https://nodejs.org/en/blog/announcements/nodejs16-eol

ftr, semver doesn’t pivot on wisdom or support or security, only on breakage :-)

I want to check my understanding about what is being proposed.
It sounds like whenever we adjust our engines entry we would also major version our packages.
However, since we don't support the old runtime anymore, I think that would mean we would have to npm deprecate the previous released major.
This means now instead of resolving an engines warning from npm, you have to resolve a deprecated dependency warning from npm.
Does this make your life any better? Aren't you basically in the same place?

@xirzec no, there’s never a requirement to deprecate something merely based on not supporting it.
Additionally, deprecation earnings are just warnings - they don’t obstruct, and everyone just ignores them - so it costs nothing. Engines limits fail installs.

Several of our services are still using node 16 and had these packages which used upstream (not direct deps). Moving without a major version broke our builds as ^4.6.0 for @azure/keyvault-secrets now installs 4.8.0 which is node 18+ only.
Obviously, yes we should have upgraded from node 16 at this point. However, a few legacy enterprise services exist still and given the complexities of build pipelines and the like it isn't always doable to upgrade mission critical services arbitrarily at scale without a huge amount of additional testing in production environments.
Given Azure's primary target market is enterprise customers (often big and slow at updating) this seems like an odd move to break semver. It should have gone to 5.0.0 as a major bump.
The good news is that we can fix this using package.json resolutions but it's a huge hassle to go into every repo we operate to add resolutions to fix the issue after the builds fail.
Regarding the Support Policy

The Azure SDK libraries for JavaScript will not be guaranteed to work on Node.js versions that have reached their end of life. Dropping support for such Node.js versions may be done without increasing the major version of the Azure SDK libraries.

Personally, I think this needs rewording. Not guaranteed to work is one thing and I believe many companies could accept that. However, changing the engine requirement is forcing it not to work. Big difference IMHO.

Hey folks - apologies again for the inconvenience caused by the recent changes in Node.js version support and engines field, and thanks for bringing this up and continuing to share your feedback!
We understand that this has been disruptive and should have been communicated more effectively.
In response to this, we are making the following changes to our process and policies:

We will be more conservative updating the engines field. While we will maintain our current versioning policy, we will not drop engines support until the ecosystem has broadly moved to a non-EOL runtime by default. This may include examining GitHub Actions, Azure Web Apps, Azure Functions, and others.
We will announce engines retirements 3 to 6 months beforehand. We will announce these changes via:

The Azure SDK Blog.
A pinned issue in the Azure SDK for JS github repo issues page.
We may add a warning via Node's process.emitWarning. We'd love to hear from you if this is something you'd find useful!

While it can be argued that dropping engines support for unsafe or EOL runtimes is a breaking change worthy of a semver major release, unfortunately major releases come with significant tradeoffs for some of our users. Given this, we will continue with our current versioning strategy with the above modifications and see if further changes are necessary.
Please continue to share your thoughts on this issue, this discussion has been super valuable. We really appreciate it!

To be clear, it's not "can be argued", it's the letter of the spec, and https://github.com/Azure/azure-sdk-for-js/pull/29895/files#diff-c5fe610b0215b144474106251cab954f8af55fe26cbd5d2265fd6ca19109c97bR36 means that this library is not following semver.
You're certainly free to do that! But, it would be helpful to consumers to make it clear which versioning strategy is in use, and it seems that it's not semver.


Update CI to Python 3.10

What does this changes

Update Python version in CI workflows to 3.10 (torch==1.x requires Python >=3.7,<3.11)
Update dependencies to its latest minor upgrade (e.g. 5.2 -> 5.10)

To fix #930

Hello @bact! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file setup.py:

Line 9:16: E225 missing whitespace around operator


Notification endpoint update

requires notificationEndpointUpdate backend branch to test
updated styling for notifications and added behavior where bell icon unread notification becomes read upon clicking.
When individual notification is clicked then it becomes unbolded to identify it has been interacted with. (don't worry I will squash this commit)

:+1:

Pulled, reviewed code and tested both branches successfully:

Unclicked notification count on bell disappears after clicking bell
Unclicked notification title appears bold
Clicked notification title appears unbold

:+1:

Found the following while reviewing code online:

ozp-react-commons/app/js/components/notification/UserNotifications.jsx:

I wasn't able to pull and test code again to see if this is related to Travis issue but thought it was worth noting.

@blynch11p  can I get a sanity check on the line I changed before I merge?

Looks good :+1:


findspam.py: watch_ns_for_url_domain

Refactor bad_ns_for_url_domain to an anlysis function ns_for_url_domain
and two caller functions which call it with different lists of nameservers

Coverage increased (+0.07%) to 65.162% when pulling 5eabf0fd5dc5460c58d8857adc991c2586b0d46a on tripleee:watch-ns into 1b5a86e9b355edabf25a48323389dfcfa9063fb0 on Charcoal-SE:master.

Rebased to squish typo fixes etc into one commit; sorry for the noise.


fix spelling mistake on "Bigquery"

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@bcoe can we disable these CI steps from this repo?

@JustinBeckwith @stephenplusplus @polleyg this data is also generated automatically from templates, the sample just needs something like this added:
// sample-metadata:
//   name: BigQuery
//   description: description of the sample
//   usage: node quickstart

Ahh, sorry, my bad. Didn't know it was auto generated from templates. Looks like it's already been fixed in PR #604 for the actual BQ repo.

@polleyg nothing to be sorry for, thanks for reporting this.

@stephenplusplus we should update synth.py on this repo to make it automatically generate the README.


allowPrivilegeEscalation access control missing in pubsubplus helm-chart

Hi Team,
We were trying to deploy solace pubsubplus on our environments. But it in security checks it observed the allowPrivilegeEscalation security context property is not set on the statefulset files.

https://github.com/SolaceProducts/pubsubplus-kubernetes-helm-quickstart/blob/master/pubsubplus/templates/solaceStatefulSet.yaml

https://artifacthub.io/packages/helm/solace/pubsubplus?modal=values

When we check the official solace article, there we could see it's recommended setting but same is missing in above manifests files.

Can you please help with this security context property parameter if it's needed for pubsubplus or not?

Hi @nikhilbhadane10  , this security context property is not required when deployed at Privileged or Baseline Pod security Standards level environments, however required for Restricted level. The Helm chart StatefulSet will be revised for best practices.


Does this work?

Is this dash in working state can I get few screenshots?

It does not currently work. as far as I am aware this project was dropped

Yes, this is basically dead now. Unless @EmanSza wants to revive it which he doesn't seem to care about at the moment.


Instructions to back-merge release branches into master

This allows us to continue on branches like v0.14.1, v0.14.2, and tag on
that branch.  But it will merge those tags into master so git describe
picks up the changes.

@zmerlynn @lavalamp
This discusses how to make sure master picks up tags from the release branch, so versioning picks up info from the release branch....

Should perhaps mention in that wall of text the reason for those steps.

@lavalamp Hopefully fixed.  PTAL

LGTM


Remove crash!

The issue: Remove all uses of crash! #5487
Replaced all uses of crash! from the file "src/uu/sync/src/sync.rs" with the show! macro

Please describe your pull request.

Looks good, please send it to upstream and place a like to it here.

https://github.com/uutils/coreutils/pull/5847


Add network ACLs to eks-core

The NLBs in front of the K8S cluster are running in the public and private subnets. In order restrict access to the NLBs, this PR adds Network ACLs to the subnets they are running in. The reason for using Network ACLs is that it is not possible to associate NLBs with security groups.

Let's do this after module refactoring.