Use role application

Fixes #469
Review @ctoth

Codecov Report

Merging #477 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   46.89%   46.89%
=======================================
  Files          70       70
  Lines        1898     1898
  Branches      306      306
=======================================
  Hits          890      890
  Misses        930      930
  Partials       78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edfa1b1...d834371. Read the comment docs.

Hey @frastlin, what do you think about this? Would this help? Thanks!

Yes, this is good. The problem is that for some reason, when trying to change the sliders and buttons, focus is jumped out of the application. It is not a big deal, but is a little annoying. The track information still looks a little messy though. This makes the application look cleaner and more modular which is nice.


References to Angular 2

Where have those references to Angular 2 come from? :smile:
This might be worth adding:
https://github.com/jdanyow/aurelia-breeze-northwind

Heh, I used the Angular one as a starter kit for the structure. :P
I added the breeze example, thanks!


Update RU translation

Update "Contribute" section of index page
Fix bug with More-EAV section naming: must be Атрибут not Артибут
Add some minor fixes

Thank you @u-mulder for your contribution!


Limbo (Vepium Remix High Pitch)

Song Name
Limbo (VepiumOfficial & Nighthawk22 - Isolation (Official LIMBO Remix) High Pitch
Artist Name
NightVail Team [GD]
Source
Youtube
Youtube Link
https://www.youtube.com/watch?v=4DtvqLE-Gpo
Direct File Link
No response
Song ID
86084399
Start Offset [ms]
No response
Extra
used in limbo 86084399

reject
song id is not the level id

whoops just now realized


feature-link-list: new component

Feature Link List component
View preview
Video
https://github.com/user-attachments/assets/fff346c2-1649-4a5d-b912-2c76d8366307
Checklist
Preflight

[x] Prefix the PR title with the slug of the package or component - e.g. accordion: Updated padding or docs: Updated header links
[x] Describe the changes clearly in the PR description
[x] Read and check your code before tagging someone for review
[x] Create a changeset file by running yarn changeset. Learn more about change management.

Testing

[x] Manually test component in various modern browsers at various sizes (use Browserstack)
[x] Manually test component in various devices (phone, tablet, desktop)
[x] Manually test component using a keyboard
[x] Manually test component using a screen reader
[x] Manually tested in dark mode
[x] Component meets Web Content Accessibility Guidelines (WCAG) 2.1 standards
[x] Add any necessary unit tests (HTML validation, snapshots etc)
[x] Run yarn test to ensure tests are passing. If required, run yarn test -u to update any generated snapshots.

Documentation

[ ] Create or update documentation on the website
[x] Create or update stories for Storybook
[x] Create or update stories for Playroom snippets

Creating new component

[x] Document the component for the website (docs/overview.mdx and docs/code.mdx at a minimum)
[x] Preconstruct entrypoint has been created (run yarn in the root of the repo to do this)
[x] Changeset file includes a minor
[x] Export components for docs site and Playroom (docs/components/designSystemComponents.tsx)
[x] Add component to Kitchen Sink (.storybook/stories/KitchenSink.tsx)
[x] Add snippets to Playroom (docs/playroom/snippets.ts)
[x] Add pictogram to Docs (docs/components/pictograms/index.tsx)

You'll need to do this: Add component to Kitchen Sink (.storybook/stories/KitchenSink.tsx)

Need to update the snapshots then we're good to go


Code sample in docs and GitHub code samples not up to date with latest implementations (o365 vs m365)

[ ] In the docs the code samples have more recent code, using the m365 CLI, compared to the code which is linked in the GitHub article residing in the master branch using o365 CLI.

[ ]  The login script already holds the app catalog URL which is not aligned with the latest implementation. This parameter should be removed. Otherwise the deploy fails on this step.
- script: m365 login $(m365_app_catalog_site_url) --authType password --userName $(m365_user_login) --password $(m365_user_password)         displayName: Login to Microsoft 365

[ ] It should also be stated that the first time you want to use the configured m365 user to login, you should do it with an interactive login on a device, so you are able to grant the "PnP Management Shell" app. Otherwise you are never able to login from the pipeline, which will produce this type of error.

Error: AADSTS65001: The user or administrator has not consented to use the application with ID '31359c7f-bd7e-475c-86db-fdb8c937548e' named 'PnP Management Shell'. Send an interactive authorization request for this user and resource.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6f70ab0e-7e7d-df8f-5607-8794b5d26024
Version Independent ID: 16b7890e-6e7f-0573-3d79-51bdb04758dd
Content: Implement Continuous Integration and Continuous deployment using Azure Pipelines
Content Source: docs/spfx/toolchain/implement-ci-cd-with-azure-pipelines.md
Product: sharepoint
Technology: sharepoint-framework
GitHub Login: @VesaJuvonen
Microsoft Alias: vesaj

Good feedback... with the name change, there were bound to be some things that slipped through the cracks. Care to submit PR's to help fix these things?


some types/interface are not availaible since the 0.14

Hi,
Since 0.14, certain types that were previously exported are no longer exported. It is still possible to access Tweet, but impossible to import certain types such as Mention, Photo, PlaceRaw, Video ...

On versions < 0.14, you could import them like this, but it's no more possible:
import { Mention } from '@the-convocation/twitter-scraper/dist/tweets';

Should be fixed as of v0.14.1


[Don't merge - Testing in progress] Removing raw interface type usage in NIC Ip config

Can one of the admins verify this patch?


Remove misleading "Time complexity: O(log(n))" from README

str += str is not a constant time operation. What if str is 1GB long?

While you are correct that the time complexity claim of O(log(n)) is misleading, calling it a constant time operation is neither correct :)

Could you find any reference to support your argument?

@stevemao Are you serious? The reference you are looking for is called CS101... The fact that something is a single statement and not a loop does not mean it is a O(1) operation... Think about what needs to happen internally, what is the structure in memory, and how it needs to change. In the case with string concatenation, the runtime environment needs to allocate new memory to hold the new bigger string, and then copy over the two concatenated strings over to that new memory.
The overall complexity in your implementation is O(n+m) when n is the length of the string being left-padded, and m is the length of the padding. This is the theoretically optimal complexity, you cannot go lower than this as you cannot avoid the memory allocations that would take place with sufficiently large m and n. You can reduce the constant factor and the memory trashing with optimisations, but the algorithm still remains O(n+m), not O(log(n))...

It's simply not possible to fill a memory region of size N in less than N steps (probably multiplied by a constant 1/8 or something, if JS engine can do that in 8-byte chunks, that depends on the processor). memcpy in C is also linear time operation, for example.
That said, minimizing number of operations in JS code is advantageous, because it minimizes context switching and puts less pressure on the garbage collector. So I agree with the implementation.

You probably want to also remove or change the relevant comment in the code itself.


allow sentinel replication configuration

I would like to use this bundle with a sentinel setup. This pull request allows setting the replication option to 'sentinel' and allows setting the 'service' option.
related to https://github.com/snc/SncRedisBundle/pull/274

I checked out this code and it works as i was hopping in my test environment. I did however add a extra parameter to make sure selecting a database is an option.

I removed the defaultNull for replication options as suggested by https://github.com/ivoba in https://github.com/snc/SncRedisBundle/pull/305
Also added a test for the cluster configuration where the replication options must not be set.

What does service: mymaster is for? I think it would be nice to add something to the docs about sentinal support.

@snc service: mymaster is needed to specify a set of instances. This is done within the sentinel config file. You can find some more information about this under "Configuring Sentinel" here: https://redis.io/topics/sentinel

I'm also interested in this feature.

Any update on why this isn't merged yet?

@othillo Could you add some lines to the readme about this feature?

@snc done :) https://github.com/snc/SncRedisBundle/pull/307/commits/b61f0f52b3a79d9dbdd8aa159185f923758fed28

Thanks, merged.

thanks! would you mind tagging a new release?

Could you tag a new release? @snc

For anyone subscribed to this I see that a new release was tagged 8 days ago that includes this.
Thank you!


Fetch xpack binary only when xpack enabled

Currently Elasic fetches unnecessary xpack archive even when it's disabled.

@deric:  This looks fine to me.  Could you resolve conflicts please?

@gabrielhartmann Sure, I've rebased the commit. Sorry this took so long, the message got lost in mail.

@deric No problem.  I'm kicking the elastic test once.  If it fails again I'll send you logs.

@gabrielhartmann Good, some logs would be nice. Is it possible to run those tests locally without a test cluster?


fix: #59

I'm not really sure what the logic is behind what I fixed, but this likely never worked.
utils.M.get_rows_indent does not return a list, it returns an unpacked list. This means that you need to capture both values being returned by the function. rows_indent_list was actually being assigned utils.ROWS_INDENT_RETCODE.OK instead of the indent list you are expecting.
So the fix here is (given how rows_indent_list is being used) is to capture the return code in a (currently) unused variable and then assign the returned list to rows_indent_list.
I would highly advise you review this fix as it does work but likely doesn't encompass what you were actually going for when you created M.get_rows_indent.

very thanks for your contribution~


Introduce cop for TimeZone

It was raised in a previous pr (#1748 (comment)) that we should have a linter to look at TimeZone. In that discussion it was stated that we should prefer Time.current over Time.zone.now but this is not a thing that rubocop supports. Instead I've implemented the opposite in order to ensure that we have a consistent style.

This looks a good idea to me - I don't mind too much whether we use Time.zone.now or Time.current as long as it's consistent.
It's worth shouting to see if this is something anyone else in the team has concerns about


Better way of enabling colors for processes launched from IDE

Hi,
A Node.js process launched from IDE has process.stdout.isTTY always set to false, because the Node.js process is started with redirected streams. Unfortunately, AFAIK, there is no way to set it to true.
So, to enable colors users should specify --color command line flag manually.
IDE can improve the situation and add --color flag automatically. But it seems a bit unsafe for me, because it isn't clear where the safe place for --color flag is (specifying --color as the first argument might be incorrect for some apps and specifying it as the last one might be incorrect for others).
Possibly safer way would be to introduce a new environment variable (like ENABLE_ANSI_COLORS) and check for it before checking for process.stdout.isTTY:
	if (/^1|^true|^yes|always/i.test(process.env.ENABLE_ANSI_COLORS)) {
		return true;
	}
	if (process.stdout && !process.stdout.isTTY) {
		return false;
	}

Another way is to place check for COLORTERM environment variable before checking for process.stdout.isTTY, but I'm not sure it wouldn't break some use-cases.
Thanks.

Maybe SUPPORTS_COLOR in process.env then. Still not convinced this is a good idea though.

Maybe it isn't a good idea. I just don't see any other ways to allow IDE to enable color support at the moment. Also, introducing SUPPORTS_COLOR shouldn't harm. It can be marked as experimental to make it easier to remove it in future if some better solution would be figured out.
Another name: SUPPORTS_COLOR_NO_TTY to indicate that current process doesn't have TTY device associated with it, but it's capable to color output.

My 2 cents - I have a use case where environment variables are possible, but command line flags are not. PR seems straightforward enough: #17

What kind of use-case?

The use case is that I am using child_process.exec to run a another module in a separate process. This module rejects the --color CLI parameter, as it is strict about which flags it does and does not allow, and it has good reasons for doing so.
This module needs to invoke chalk, which in turns invoked supports-color. I have no reasonable means to communicate a flag other than through an environment variable, and hence making supports-color support this, I believe, is the right place for the fix to go.

My current workaround is
var chalk = require('chalk');
if (!!process.env.SUPPORTS_COLOR) {
  chalk.enabled = function() { return true; };
}

Which is, for obvious reasons, not ideal.

@bguiz Yeah, I see the need. Just keep in mind that whatever I go with here I'll be stuck with forever, so I want to get it right.
I'm not sure SUPPORTS_COLOR is the right name either.
Some alternatives: COLOR, FORCE_COLOR.

Of course:
var choices = ['SUPPORTS_COLOR', 'COLOR', 'FORCE_COLOR', 'FORCE_SUPPORTS_COLOR'];

I am a fan of having 'SUPPORTS_COLOR' somewhere in the environment variable, because that minimises the chances of overlap with an environment variable used by something else.

SUPPORTS_COLOR is fine. The only con that occurs to me is that the name is still a bit general, so there is a small probability of overlapping with other environment variable. An example of more unique name could be (SUPPORS|ENABLE)_ANSI_COLOR_FOR_(NO_TTY|REDIRECTED_STREAMS) (addresses only this use-case and nothing more).
Seems the problem with FORCE_*COLOR* names is that it isn't clear what would happen if a CLI flag --no-color and FORCE_*COLOR* are both specified.

I'm leaning towards FORCE_COLOR, since we're overwriting all other default behaviour. No disabling when running in a non-tty/pipe. No respecting the CLI flags. Etc..

No disabling when running in a non-tty/pipe. No respecting the CLI flags.

Yes, that would be fair.

It can be very useful to output ANSI escape sequences like colours to a pipe, like when redirecting to a pager that supports raw mode.
TTY checks are generally more appropriate for inputs than outputs.
If you were doing more elaborate output like curses/ncurses, you'd want to look at TERM to determine which terminal emulator to target.

I would also vote +1. My use case is Ember CLI + Atom.io editor. Ember is passing all options to registered extensions so changing Ember would brake contract with extensions. I do not know if they are willing to do so.

fixed by #18


npm start doesn't start webserver

Here's the command line output I get:
| => npm start

<EMAIL_ADDRESS>start /Users/coryhouse/Desktop/test projects/react-babel-webpack-starter-app
webpack-dev-server --progress --profile --colors --hot

70% 1/1 build moduleshttp://localhost:8080/
webpack result is served from /
content is served from ./public
50% 60/89 build modulesContainer#eachAtRule is deprecated. Use Container#walkAtRules instead.
Container#eachRule is deprecated. Use Container#walkRules instead.
Container#eachDecl is deprecated. Use Container#walkDecls instead.
5505ms build modules
28ms seal
5ms optimize
808ms build modules
9ms hashing
45ms create chunk assets
15ms additional chunk assets
1278ms optimize chunk assets
5ms optimize assets
41ms emit

Hi Cory!  What happens when you go to http://localhost:8080 ?

I have the same output, but the webserver is working - and hot reloading as expected.  If your web server actually isn't working then perhaps check the following against my environment:
$ node --version
v5.1.0

$ npm --version
3.3.12

$ npm list -g --depth=0
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
Also, running (am on MAC) the following to check if port 8080 is operational / in use:
 lsof -i:8080

Please do report back, if it really isn't working then I shall research further. In which case, please could you also let me know the platform (o/s), and versions of Node and NPM you are using.

@coryhouse - i have applied a small commit. For me locally it doesn't "fix" anything per say, but it likely does help avoid any confusion. An upgrade to the css-loader module removes the "deprecation warnings" on webpack-dev-server start up, and I have added --quiet flag to the webpack.config.js so the other "noise" is removed too. Please note that the webpack-dev-server is generally much slower to load than the gulp equivalent.
Finally, if you are having no joy, I have also added a "npm run startLocal" option which will coerce the use of the locally installed webpack-dev-server. This is just a precaution in case it is picking up a globally installed binary on an incompatible version.
Thanks for the early feedback!

@coryhouse - Hey Cory, please let me know if you still have any issues. Othewise, I shall close this issue.

Just pulled latest and retried. Better, but dev server still isn't actually serving files when I load localhost:8080, despite the fact that the command line says it is. Quite odd.
Output of npm start:
| => npm start

<EMAIL_ADDRESS>start /Users/coryhouse/Desktop/test projects/react-babel-webpack-starter-app
webpack-dev-server --quiet --info false --profile --colors --hot

http://localhost:8080/
webpack result is served from /
content is served from ./public

Yep, that is strange... :confused:
Please try:
$npm run startLocal

This should try to force the usage of locally installed npm webpack-dev-server. (which in my understanding might not happen if you do have one globally installed).
Wait a full 30-45 seconds, once it says the server is actually running then hit refresh on browser.
Can only reassure you it is working locally  :stuck_out_tongue_winking_eye:
Thanks very much for your input Cory, much appreciated. Sorry it hasn't "just worked" as expected.

Sorry, still no dice.
| => npm run startLocal

<EMAIL_ADDRESS>startLocal /Users/coryhouse/Desktop/test projects/react-babel-webpack-starter-app
webpack-dev-server --quiet --info false --profile --colors --hot

http://localhost:8080/
webpack result is served from /
content is served from ./public


Add documentation in the Core Protocol specification github repository corresponding to the network policy rules

This was completed as part of this ticket: https://github.com/beckn/protocol-specifications/pull/449


How can I actually fetch the data of from the tables using onclick events ?

First of all thank you for this great library. It actually great to work with.
My main aim is to display the clicked record using an alert box of javascript or using a dialog box of Jquery. Right now I am able to fire the click event by clicking on the table but my aim is to fetch the x-axis element and y-axis element of the clicked box and display it using alert box or dialog box. Would like to get some help on this query of mine asap.
Thank You

This example basically does what you're looking for: https://pivottable.js.org/examples/mps_prepop.html
In the callback, the filters parameter should contain the information you're looking for.

Oh ! Okay. Like in this part clickCallback: function(e, value, filters, pivotData)
I will send my data like the name of the fields which I want to display. Right?

Thank You so much. It is done I was able to retrieve the data which I needed on click event. Thank You.


as_dense_matrix dtype

Hi,
When constructing the numpy array with appropriate dimensions from its buffer, the dtype of the buffered array should be passed as argument to numpy.ndarray otherwise TypeError: buffer is too small for requested array is raised.
It could resort to something like this:
def as_dense_matrix(robj: MutableMapping, order: str = "F") -> np.ndarray:
    """Convert a realized R object to a dense matrix representation

    Args:
        robj (MutableMapping): object parsed from the Rds file
        order (str): Row-major (C-style) or column-major (Fortran-style) order. Defaults to "F".

    Raises:
        TypeError: not a dense matrix

    Returns:
        np.ndarray: a dense np array of the R object
    """
    cls = get_class(robj)

    if cls not in ["densematrix"]:
        raise TypeError(f"obj is not a supported dense matrix format, but is `{cls}`")

    return np.ndarray(
        shape=tuple(robj["attributes"]["dim"]["data"].tolist()),
        dtype=robj["data"].dtype,  # specify dtype here
        buffer=robj["data"],
        order=order
    )

thank you for providing the solution as well. Do you have a test file where this error shows up (to add a test)?

Yes of course, here is a compressed "subpart" of the rds I was using: test_file.zip.
Along with the code to reproduce the error:
from rds2py import as_dense_matrix, read_rds
robj = read_rds("test_file.rds")
arr = as_dense_matrix(robj)  # raises the TypeError

Using the proposed fix it is converted correctly.

@vadmbertr whats your email address (for contribution)?

thanks for the mention! You can use<EMAIL_ADDRESS>


Add onPageScrollStateChanged for ViewPagerAndroid

I have an issue when combining PullToRefreshViewAndroid and ViewPagerAndroid.
ViewPagerAndroid will not able to scroll that gesture handler is being taken by PullToRefreshViewAndroid
One solution is to disable PullToRefreshViewAndroid if ViewPagerAndroid is scrolling (i.e. not idle).
Reference solution here
So here need to expose the onPageScrollStateChanged event.
Some code referenced from  DrawerLayoutAndroid, especially the VIEWPAGER_PAGE_SCROLL_STATES array.
Please feel free give me comments.
Thanks.

Any update for this?

cc @mkonicek

@satya164 by the cc do you mean I should review or cc the right person?
I can't review all the PRs myself quickly I'm afraid, maybe @brentvatne remembers how the ViewPager works since he made some changes to it recently? Brent if you're more comfortable with me reviewing this I'll do that.

@mkonicek I wanted to cc the right person. Thanks :D
Seems @andreicoman11 was assigned to this. So ccing him too.

Thank you guys' collaboration.  If you need my code snippet to test the reported issue which could be easily reproduced on real device, please feel free to let me know.

Cool thanks @satya164! I think the best reviewers for ViewPager are @kmagiera and @brentvatne.
This is an interesting issue - I'd assume the PTR would only detect a vertical gesture and the ViewPager only a horizontal gesture :(
From a quick look this look fine. We might want to come up with a unified API for horizontal paging for Android and iOS. On iOS this can be done using a <ScrollView horizontal={true} pagingEnabled={true} />. Please have a look at the ScrollView API and consider whether this should affect the naming or the possible values of the property.

I'll give this a review on the weekend, sorry for delay

np! :+1:

@Kudo thanks for you PR! I have just one small comment (see inline). Otherwise it looks good

@kmagiera Thank for your review. Nice comment for the scroll state.
I'd prefer send state as string directly which is clear and simple for JS integration.
Let me update the code and please help to review again.

Thanks @Kudo this looks good to me
@facebook-github-bot shipit

Thanks @kmagiera. As mentioned before, DrawlerLayoutAndroid also has such code that coupling with Android framework ( DrawerLayoutAndroid.android.js#L33-L37 ). Please let me know if you would like to welcome a PR to make them consistent.


cannot download playlist

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.10.29. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.10.29

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

youtube-dl -v --ignore-config https://www.youtube.com/playlistlist=PLWUeC03YLcaIoUNa7B-5DlJzL9jIc5hRZ --------playlist-start 50
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '--ignore-config', 'https://www.youtube.com/playlist?list=PLWUeC03YLcaIoUNa7B-5DlJzL9jIc5hRZ', '--playlist-start', '50']
[debug] Encodings: locale cp936, fs utf-8, out utf-8, pref cp936
[debug] youtube-dl version 2017.10.29
[debug] Python version 3.6.3 - Windows-10-10.0.16299-SP0
[debug] exe versions: ffmpeg N-88514-gd5995c531d, ffprobe N-88514-gd5995c531d
[debug] Proxy map: {'http': 'http://<IP_ADDRESS>:1080', 'https': 'https://<IP_ADDRESS>:1080', 'ftp': 'ftp://<IP_ADDRESS>:1080'}
[youtube:playlist] PLWUeC03YLcaIoUNa7B-5DlJzL9jIc5hRZ: Downloading webpage
[download] Downloading playlist: 걸스데이 2016+
[youtube:playlist] PLWUeC03YLcaIoUNa7B-5DlJzL9jIc5hRZ: Downloading page #1
ERROR: Unable to download JSON metadata: <urlopen error [WinError 10061] 由于目标计算机积极拒绝，无法连接。> (caused by URLError(ConnectionRefusedErro
r(10061, '由于目标计算机积极拒绝，无法连接。', None, 10061, None),))
File "c:\users\kokomij\appdata\local\continuum\miniconda3\lib\site-packages\youtube_dl\extractor\common.py", line 503, in _request_webpage
return self._downloader.urlopen(url_or_request)
File "c:\users\kokomij\appdata\local\continuum\miniconda3\lib\site-packages\youtube_dl\YoutubeDL.py", line 2195, in urlopen
return self._opener.open(req, timeout=self._socket_timeout)
File "c:\users\kokomij\appdata\local\continuum\miniconda3\lib\urllib\request.py", line 526, in open
response = self._open(req, data)
File "c:\users\kokomij\appdata\local\continuum\miniconda3\lib\urllib\request.py", line 544, in _open
'_open', req)
File "c:\users\kokomij\appdata\local\continuum\miniconda3\lib\urllib\request.py", line 504, in _call_chain
result = func(*args)
File "c:\users\kokomij\appdata\local\continuum\miniconda3\lib\site-packages\youtube_dl\utils.py", line 1086, in https_open
req, **kwargs)
File "c:\users\kokomij\appdata\local\continuum\miniconda3\lib\urllib\request.py", line 1320, in do_open
raise URLError(err)

can downloda one video
cannot download playlist

Most likely your proxy is broken.

but i can download any video


[Event Request] COD1380 BatchProcess - Reopen

Hi, I would like to reopen the Issue #2509 (https://github.com/microsoft/ALAppExtensions/issues/2509) because there is an error in the MS-implementation (see the last comment)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


WithConsecutiveRector is not working as expected

I saw WithConsecutiveRector added in #246 to the PHPUnit 10 rule set, and was keen to use it. But unfortunately, it's not working.
I took the example from tests/Rector/StmtsAwareInterface/WithConsecutiveRector/Fixture/some_class.php.inc and defined PersonService like this:
class PersonService {
    public function prepare($value1, $value2) {}
}

Original test:
        $mock = $this->createMock(PersonService::class);
        $mock->expects($this->exactly(2))
            ->method('prepare')
            ->withConsecutive(
                [1, 2],
                [3, 4],
            );

        $mock->prepare(9, 9);
        $mock->prepare(9, 9);

=> Test fails as expected with:
Parameter 0 for invocation #0 PersonService::prepare(9, 9) does not match expected value.
Failed asserting that 9 matches expected 1.

after running the WithConsecutiveRector:
        $mock = $this->createMock(PersonService::class);
        $matcher = $this->exactly(2);
        $mock->expects($matcher)
            ->method('prepare')->willReturnCallback(static fn(): array => match ($matcher->numberOfInvocations()) {
            1 => [1, 2],
            2 => [3, 4],
        });

        $mock->prepare(9, 9);
        $mock->prepare(9, 9);

=> Test is successful even though it shouldn't cause 9 is not equals to the expected value.
the result I get from the rector is already different from what's in the documentation. So I also checked if it would work with the result the documentation provides:
        $mock = $this->createMock(PersonService::class);
        $matcher = $this->exactly(2);
        $mock->expects($matcher)
            ->method('prepare')->willReturnCallback(function () use ($matcher) {
                return match ($matcher->numberOfInvocations()) {
                    1 => [1, 2],
                    2 => [3, 4],
                };
            });

        $mock->prepare(9, 9);
        $mock->prepare(9, 9);

=> Test is successful again, even though it still shouldn't.
Let me know if I missed something. Otherwise, I've unfortunately no idea how to fix this rector.

@f-albert reimplement at https://github.com/rectorphp/rector-phpunit/pull/313, could you check?

Closing as outdated and lack of feedback last 4 months. Thanks for understanding :+1:
This rule is quite a challange :) if you come across a weird case, please submit a test fixture here:
https://github.com/rectorphp/rector-phpunit/tree/bffd16339732095ba84bf21475eac749c1c9a154/rules-tests/PHPUnit100/Rector/StmtsAwareInterface/WithConsecutiveRector/Fixture


fix(layer): change min/max resolution logic to fix #213

There was an error in the logic in version 1.3.0 of the
directive which caused Tile layers with TileWMS sources
to not render when the layer was updated.  Plunker which
demonstrates fix http://plnkr.co/edit/NI7GkRkhJvxXM8OxroMw?p=info
closes #213

:+1:


Heroku button

Fixes #4
Adds a "Deploy to Heroku" button to the readme, along with the required app.json file.

Could you rebase your pull request :) The additional info in app.json seems useful

@vjeux Ok, I think everything's there now.


Document Existing File Upload Conflict Resolution Option

Category

[ ] Question
[x] Documentation issue
[ ] Bug

Background
Here is the relevant endpoint. Currently, if you upload a file with the same filename as an existing file, the existing file is overwritten. To change this behavior so that filename conflicts are handled by renaming the new file, you can append the following query parameter: @name.conflictBehavior=rename. This is currently not documented anywhere
Expected or Desired Behavior
The optional request parameter for handling filename conflicts for file uploads should be recorded in the documentation for the endpoint.
Observed Behavior
Files uploaded with the same name as that of an existing file overwrite the existing file.
Steps to Reproduce

Upload any file using the endpoint linked above.
Upload a different file with the same name as that of the file in part 1.
Observe that the file from part 1 was overwritten with the file from part 2.
Upload the file from part 1 again, this time adding the query parameter @name.conflictBehavior=rename.
Observe that both files exist in the drive with the last one to be uploaded having been renamed.

#1072 should be enough to resolve this issue.

@alexwaibelmsft I committed the merge, let me know if it all looks good.

@chackman Looks perfect, I can see it on docs.microsoft.com. Thank you!


check on ts formats

#84 can add more to this if needed. Used in write_ts and read_ts only at this point. added some helpers

@aappling-usgs can you take a look? Will need to switch over to OWDI now.

looks good. i'll wait for the tests and then merge.

Coverage decreased (-1.12%) to 18.88% when pulling 21686d6cf8490d391c3568354ab5d6b911f2cca5 on jread-usgs:master into b47b90799d0fb8f67a14cc31277f12c7d7112767 on USGS-R:master.


Error setting user favourites

Seen in log:
Request: [2020-01-08T17:43:32Z] Remote-IP:"<IP_ADDRESS>" Method:"POST" Path:"/pp/v1/favorites/KtC0JPrM1pUqymSOwQq9uXfz9wg-endpoint-cf/metadata" Status:500 Latency:2.101608ms Bytes-In:108 Bytes-Out:21

Fixed in 3.0.0


[Fix #8868] Fix false positives for Lint/RedundantSafeNavigation

With tap, yield_self and then methods.
Closes #8868

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

As a general question, is it documented somewhere if users need to copy all the default IgnoredMethods if they want to add to it? I don't believe that if IgnoredMethods is set in config for a cop that supports it that it is merged with the default list.

@dvandersluis See https://docs.rubocop.org/rubocop/0.93/configuration.html#inheritance

Fixed by https://github.com/rubocop-hq/rubocop/pull/8884 @tejasbubane Thanks for proposing another solution!


Run knex migrations in tests

[Finishes #88554160]

Should knex migrate:latest be removed from .travis.yml?


Add Style/IndentAssignment Cop

This is a prequel to #2361. It is enabled by default and properly fixes the auto-correct output that MultilineAssignmentLayout produces.
When assignments span multiple lines, this cop enforces proper indentation on the right-hand-side of the expression. It only corrects the first line, as the remaining lines can be corrected by other cops such as Style/IndentationConsistency.
# bad
value =
if foo
  'bar'
else
  'biz'
end

# good
value =
  if foo # corrected/accepted
  'bar'
else
  'biz'
end

I have also added a fix to Astrolabe::Node#asgn_method_call?. It used to consider != method calls as assignments - which they are not. There were also no tests for this method so I've added them.

@jonas054 updated to address your comment

The code looks good, but there's something wrong. The build fails. Please add spec example(s) that fails the same way that the rubocop self-inspection currently does (if you see what I mean), and fix.

@jonas054 The issue was some additional comparison operators that ast_node was counting as assignment operators (such as ===). I've adjusted the list and added some additional tests. I've also added a backup test to indent_assignment_spec.rb to ensure that missing operator calls don't cause failures.

:+1: Looks good but you must rebase on top of the latest master.

@jonas054 rebased on top of master

I don't see a test showing that this won't generate an offense:
ala = if bala
           tralala
         end

I have also added a fix to Astrolabe::Node#asgn_method_call?. It used to consider != method calls as assignments - which they are not. There were also no tests for this method so I've added them.

Nice!

I have also added a fix to Astrolabe::Node#asgn_method_call?

Thanks for fixing my bugs!

@bbatsov addressed your comments and rebased off master.

:+1:


Runtime shown as connected but seem not acutally

How to repeat
I sometimes leave an opened Pod repo in my browser and am away for hours. When I come back, the runtime is no longer connected -- as indicated in the side panel. So I refresh the browser tab. Then the side panel shows the runtime is connected. But when I try to run a cell, it just runs indefinitely.
Sometimes I could fix the issue by going back to the dashboard and re-enter the repo. But this does not always work. Killing the runtime does not always fix the issue either. This is a very fruastrating bug that may negatively impact users' trust to Codepod.
See the issue video below.
https://user-images.githubusercontent.com/438579/236002217-16c98e68-6c2a-4e87-ba04-edd6f820da64.mp4
This might be related to issue #171

This was not a runtime connection issue, but web-tree-sitter's version issue causing an error when loading wasm. fixed in #263


msgmerge: error while opening "/home/nemo/src/dfc/po/nl.po" for reading: No such file or directory

Hi,
I have the following error when building :
make[3]: Entering directory `/home/nemo/src/dfc/build'
[ 70%] Generating ../../po/nl.po
/usr/bin/msgmerge: error while opening "/home/nemo/src/dfc/po/nl.po" for reading: No such file or directory
make[3]: *** [../po/nl.po] Error 1
make[3]: Leaving directory `/home/nemo/src/dfc/build'
make[2]: *** [po/CMakeFiles/generate-dfc-nl-po.dir/all] Error 2
make[2]: Leaving directory `/home/nemo/src/dfc/build'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/nemo/src/dfc/build'
make: *** [release] Error 2

Can you help me ?

Hi @sebma,
I need more information because I fail to reproduce this issue (unless I explicitely delete po/nl.po).
Which commands did you use to attempt building? Are you building from the git repository or from the release tarball? Which OS and version are you using?

Hi,
I used the git and tried to build it on SailFish OS v1.0

I will try to build on SailFish OS over the weekend. In the meantime, you can try building without translation support:
$ mkdir build && cd build
$ cmake .. -DNLS_ENABLED=false
$ make

Hi, the option -DNLS_ENABLED=false worked, thanks.
I wanted to have your great tool on my two smartphones.

Interesting. How do you use it on a smartphone since it is not designed for smartphones?

I can ssh to my Jolla smartphone and it's OS (SailFishOS) is a true Linux unlike Android devices :)

Since I don't own a device with SailFish OS, I doubt that I could fix this issue. I still find the error message to be strange (po/nl.po file should exist).


_getPluginForFilename breaks for query strings containing periods

I'm generating a signed url using google cloud storage. I've placed an example URL below (Not a working url). The query parameters contain . which is throwing off the plugin selection here.
I have a few thoughts/questions.

Is there a reason to have rootUrl and sceneFilename here aside from picking the loader plugin? I found it a little annoying to have to parse my url into those separate parts. I'd prefer to just pass the entire path into the loader.

Is there a way to be more explicit about which plugin to use?

Example of problematic url
<EMAIL_ADDRESS>This results in this<EMAIL_ADDRESS>being extracted as the extension.

My apologies, it looks like this was a parsing error on my end.

The reason we need both is because the rootUrl will be use to load additional resources like textures
(No problem :))

Got it, makes sense. On third inspection there may still be an issue here:
With period in query params
SceneLoader._getPluginForFilename("YelloCar.glb?GoogleAccessId=foo.bar")

results in
{"plugin":{"name":"babylon.js","extensions":".babylon"},"isBinary":false}

Without period
SceneLoader._getPluginForFilename("YelloCar.glb?GoogleAccessId=foobar")

You get the right plugin
{"plugin":{"coordinateSystemMode":0,"name":"gltf","extensions":{".gltf":{"isBinary":false},".glb":{"isBinary":true}}},"isBinary":true}

There is a way to specify the extension you want to force:
https://github.com/BabylonJS/Babylon.js/blob/master/src/Loading/babylon.sceneLoader.ts#L253
(check last parameter)

@deltakosh thanks for pointing that out. That unblocked me. Not sure if you want to keep this open to improve the extension parsing, I'll leave that up to you.

I keep it open because I want to fix this issue:)


Question about separate tests affecting one another

We are using enzyme with tape.
There seems to be a bug when doing multiple tests on one container.
This is our code. We tryed some stuff:

Create new store objects in each of our test functions
Reset store after every test when there are multiple references on one store

A note about tape is that it should be running the test sequentially and not concurently. Also when we log mount/umnout it seems to be working fine.
The problem we found is the following. When we comment one of the tests and leave only one test() function from tape the component lifecycle 'componentWillReceiveProps' is called exacly 4 times. This is true for each of the test cases. But when we call them both 'componentWillReceiveProps' is called 16 times ( expected is 8, 4 + 4). This doesn't make sense. We've also tried giving different displayNames for every RootComponent
Edit
When we run a single test with one instance of the store the component willReceiveProps is called 4 times, so it has 4 props changes. But if we run another test that same component is receiving props x2, and it lifecycles get triggered x2 ( in the first test that had 4 times, now has 8, and that same test has nothing to do with the other test, except we are mounting and then unmounting a components, initiated from a same Component class ). This matter is that one test affects the other even thought we don't have shared state, the stores are different instances ( we are creating new store for every test, also refreshing that store for any case ). This we see as some kind of a bug with mount from enzyme. Somehow two components with same names, but with different stores are sharing the same props
`
import React, { Component } from 'react'
import { render } from 'react-dom'
import { Router, Route, IndexRedirect, browserHistory } from 'react-router'
import { Provider } from 'react-redux'
import { syncHistoryWithStore } from 'react-router-redux'
import configureStore from '../store/createStore'
import {
    App,
    AllocationsPageContainer,
    ImplementationsPageContainer,
    PodsPageContainer,
    VehiclesPageContainer,
    ToolsPageContainer,
    HomePageContainer,
    ModalFormContainer
} from '../containers'
import { NotFound } from '.'
import getLink from '../utils/getLink'
import { ADD_POD_FORM, ADD_TICKER_FORM } from '../constants/form'
import { TOOLS_REPORT_WORKFLOW, TOOLS_UPLOAD_WORKFLOW } from '../constants/tools'
import {
    VIEW_WORKFLOW,
    EDIT_WORKFLOW,
    ADD_WORKFLOW,
    DELETE_WORKFLOW,
    CLONE_WORKFLOW
} from '../constants/global'

export const configureStoreWithBrowserHistory = () => {
    const store = configureStore()

    syncHistoryWithStore(browserHistory, store)

    return store
}

const defaultStore = configureStoreWithBrowserHistory()

export const createRoot = (store = defaultStore, name = 'Root') => {
    class Root extends Component {
        render() {
            return (
                <Provider store={store}>
                    <Router history={browserHistory}>
                        <Route path={getLink('')} component={App}>
                            <IndexRedirect to={getLink('home')} />
                            <Route path={getLink('home')} component={HomePageContainer} />
                            <Route path={getLink('allocations')} component={AllocationsPageContainer} />
                            <Route path={getLink('implementations')} component={ImplementationsPageContainer}>
                                <Route path={VIEW_WORKFLOW} />
                                <Route path={EDIT_WORKFLOW} />
                                <Route path={CLONE_WORKFLOW} />
                                <Route path={DELETE_WORKFLOW} />
                            </Route>
                            <Route path={getLink('pods')} component={PodsPageContainer}>
                                <Route path={VIEW_WORKFLOW} />
                                <Route path={EDIT_WORKFLOW} />
                                <Route path={CLONE_WORKFLOW} />
                                <Route path={DELETE_WORKFLOW} />
                                <Route path={ADD_WORKFLOW} />
                                <Route path={ADD_POD_FORM} component={ModalFormContainer} />
                                <Route path={ADD_TICKER_FORM} component={ModalFormContainer} />
                            </Route>
                            <Route path={getLink('vehicles')} component={VehiclesPageContainer} />
                            <Route path={getLink('tools')} component={ToolsPageContainer}>
                                <Route path={TOOLS_REPORT_WORKFLOW} />
                                <Route path={TOOLS_UPLOAD_WORKFLOW} />
                            </Route>
                        </Route>
                        <Route path='*' component={NotFound} />
                    </Router>
                </Provider>
            )
        }
    }

    Root.displayName = name

    return Root
}

`
Test 1
import 'babel-polyfill'
import test from 'tape'
import React from 'react'
import { push } from 'react-router-redux'
import { mount } from 'enzyme'
import { getAllActions } from '../utils'
import {
    DOWNLOAD_EXCEPTION_SUMMARY,
    TOOLS_REPORT_WORKFLOW,
    TOOLS_UPLOAD_WORKFLOW,
    DOWNLOAD_UPLOAD_DETAILS
} from '../../app/js/constants/tools'
import services from '../../app/js/utils/services'
import toolsSaga from '../../app/js/saga/tools'
import getLink from '../../app/js/utils/getLink'
import { resetStore } from '../../app/js/actions/common'
import { routingPathnameSelector } from '../../app/js/reducers'
import { configureStoreWithBrowserHistory, createRoot } from '../../app/js/components/Root'

test('Tools: Clicking on Exception Summary icon should call the correct action and after getting ' +
    'response from service file download should start', t => {
    t.plan(2)
    const store = configureStoreWithBrowserHistory()
    const Root = createRoot(store, 'blabla')

    /* Step 1 mounting the component, going to report workflow and selecting the component we need */
    // Deep mounting of the component. We are passing it store and location as a prop, which usually come automatically
    // from the Provider and Route components
    const wrapper = mount(<Root />)

    // Change the workflow status manually so we are on report workflow status. The component will render different
    // information depending on the workflow status. We need information which is on the report workflow status.
    store.dispatch(push(getLink(`tools/${TOOLS_UPLOAD_WORKFLOW}`)))
    store.dispatch(push(getLink(`tools/${TOOLS_REPORT_WORKFLOW}`)))

    // Finds the button for downloading Exception Summary
    const button = wrapper.find('.fa-download')

    /* Step 2 inspecting if clicking on the button has dispatched the correct action into the store */
    button.simulate('click')
    // Checks if the correct action has dispatched into the store. This happens in a few steps:
    // 1. There is a reducer called actionsHistory, which is working only if NODE_ENV=test
    // 2. The util action getAllActions is returning that exact object actionsHistory by calling getState() on the store
    // 3. Check if some of the action types from actionHistory state subtree match the action we are interested in
    const downloadExceptionSummaryActionHasBeenDispatchedToTheStore =
        getAllActions({ store }).some(action => action.type === DOWNLOAD_EXCEPTION_SUMMARY)

    // If downloadExceptionSummaryActionHasBeenDispatchedToTheStore value is truthy the test will pass.
    t.ok(
        downloadExceptionSummaryActionHasBeenDispatchedToTheStore,
        'Clicking on Exception Summary should dispatch the correct action to the store.'
    )

    /* Step 3 mocking fileDownload function that is called after the ajax call has been completed
     and inspecting if the request has returned the correct results. This is why this last step is in setTimeout */
    let dataFromCall = null

    // Mock the import fileDownload in toolsSaga
    toolsSaga.__Rewire__('fileDownload', data => {
        dataFromCall = data
    })
    button.simulate('click')

    // Wait for the request to complete. Change the time if we test with their services.
    setTimeout(() => {
        // dataFromCall is the arrayBuffer object which has length ~ bytes
        // Reset the mocked dependency after the ajax call has been completed and we have compared the results
        toolsSaga.__ResetDependency__('fileDownload')
        store.dispatch(resetStore())
        wrapper.unmount()
        store.dispatch(push(getLink(`tools/${TOOLS_UPLOAD_WORKFLOW}`)))

        t.ok(
            typeof dataFromCall === 'object' && dataFromCall !== null && dataFromCall.byteLength > 100,
            'The file data has been received and the fileDownload function is called with correct parameters.'
        )
    }, TIME_WAIT)
})

Test 2
test('Tools: Clicking on Download (upload details) should call the correct action and after getting ' +
    'response from service file download should start', t => {
    t.plan(2)
    const store = configureStoreWithBrowserHistory()
    const Root = createRoot(store, 'blublus')
    const wrapper = mount(<Root />)
    // Go to upload workflow first and then to report. If a user hits directly report on componentWillMount he will
    // be redirected to tools/upload

    store.dispatch(push(getLink(`tools/${TOOLS_UPLOAD_WORKFLOW}`)))
    store.dispatch(push(getLink(`tools/${TOOLS_REPORT_WORKFLOW}`)))

    // Play with selectors. Select all buttons, then filter and find the one we need
    const buttons = wrapper.find('button')
    const downloadUploadDetailsButton = buttons.findWhere(button => {
        return button.text() === 'Download' && button.type() === 'button'
    })

    downloadUploadDetailsButton.simulate('click')

    const downloadExceptionSummaryActionHasBeenDispatchedToTheStore =
        getAllActions({ store }).some(action => action.type === DOWNLOAD_UPLOAD_DETAILS)

    t.ok(
        downloadExceptionSummaryActionHasBeenDispatchedToTheStore,
        'Clicking on Exception Summary should dispatch the correct action to the store.'
    )

    let dataFromCall = null

    toolsSaga.__Rewire__('fileDownload', data => {
        dataFromCall = data
    })

    downloadUploadDetailsButton.simulate('click')

    setTimeout(() => {
        toolsSaga.__ResetDependency__('fileDownload')
        store.dispatch(resetStore())
        wrapper.unmount()
        store.dispatch(push(getLink(`tools/${TOOLS_UPLOAD_WORKFLOW}`)))

        t.ok(
            typeof dataFromCall === 'object' && dataFromCall !== null && dataFromCall.byteLength > 100,
            'The file data has been received and the fileDownload function is called with correct parameters.'
        )
    }, TIME_WAIT)
})

Why does the number of times componentWillReceiveProps is called matter? That function, like render, might be called thousands of times on a single page.

Because test should be like atomic. When we run a single test with one instance of the store the component willReceiveProps is called 4 times, so it has 4 props changes. But if we run another test that same component is receiving props x2, and it lifecycles get triggered x2. This matter is that one test affects the other even thought we don't have shared state, the stores are different instances ( we are creating new store for every test, also refreshing that store for any case ). This we see as some kind of a bug with mount from enzyme. Somehow two components with same names, but with different stores are sharing the same props!?!?!?

Maybe setTimeout is affecting?

What does configureStoreWithBrowserHistory so? Any chance that's stateful?

export const configureStoreWithBrowserHistory = () => {
const store = configureStore()
syncHistoryWithStore(browserHistory, store)

return store

}

For every test we are using a new instance of the store.

I refactored the test a bit. We are using different instance for root and for store. Idelly the two tests should not affect each other. As tape runs test syncronous. But the facts are:

We are mounting the same component in both test as Root on 'tools/' url will mount ToolsPageContainer component.
We are calling wrapper.unmount() and we are reseting the rewired imports after we are finished with babel-rewire
We are loggin on the console 'props received' in componentWillReceiveProps lyfecicle of ToolsPageContainer
When we run only the first test this is logged 3 times on the concole.
2 times for the second test
7 times if we run both test. This is what bothers us. Tests are affecting each other.
Please look at this code now:

test('Tools: when clicking on Exception Summary icon file download should start.', t => {
    const store = configureStoreWithBrowserHistory()
    const Root = createRoot(store)
    const wrapper = mount(<Root />)

    store.dispatch(push(getLink(`tools/${TOOLS_UPLOAD_WORKFLOW}`)))
    store.dispatch(push(getLink(`tools/${TOOLS_REPORT_WORKFLOW}`)))

    const button = wrapper.find('.fa-download')

    button.simulate('click')

    const downloadExceptionSummaryActionHasBeenDispatchedToTheStore =
        getAllActions({ store }).some(action => action.type === DOWNLOAD_EXCEPTION_SUMMARY)

    t.ok(
        downloadExceptionSummaryActionHasBeenDispatchedToTheStore,
        'Clicking on Exception Summary icon should call the correct action.'
    )

    wrapper.unmount()
    t.end()
})

test('Tools: when clicking on Exception Summary icon file download should start.', t => {
    const store = configureStoreWithBrowserHistory()
    const Root = createRoot(store)
    const wrapper = mount(<Root />)

    store.dispatch(push(getLink(`tools/${TOOLS_UPLOAD_WORKFLOW}`)))
    store.dispatch(push(getLink(`tools/${TOOLS_REPORT_WORKFLOW}`)))

    const button = wrapper.find('.fa-download')

    toolsSaga.__Rewire__(DOWNLOAD_EXCEPTION_SUMMARY_SERVICE, () => {
        t.pass(
            `Clicking on Exception Summary icon should call the correct service.
             "${DOWNLOAD_EXCEPTION_SUMMARY_SERVICE}" is called.`
        )

        toolsSaga.__ResetDependency__(DOWNLOAD_EXCEPTION_SUMMARY_SERVICE)
        wrapper.unmount()
        t.end()

        return {}
    })

    button.simulate('click')
})

I have the same problem with componentDidMount

You probably have some shared state somewhare.
На 7.06.2017 г. 7:49 сл.об. "Moe Sattler"<EMAIL_ADDRESS>написа:

I have the same problem with componentDidMount
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/airbnb/enzyme/issues/702#issuecomment-306855694, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGVMCg-SZRtWdViNlQ1HfvPlUVzilUv_ks5sBtSRgaJpZM4K73Pu
.

@danielpetrov not that I am aware of. And only have this problem with shallow + lifecycleExperimental flag. mount works fine.

Flux stores and react-router both have shared state.
enzyme, however, does not have any shared state between tests - so I can't imagine how it could possibly be related.
I'll leave this open for a bit, but I think it should be closed since it's not related to enzyme.
My guess is that your tests are relying on some cleanup being done in componentWillUnmount (which would mean they're being polluted by state setup in "not componentDidMount").

@ljharb hi experiencing a similar problem but don't understand what you mean by.

You'll have to clear the state before or after every test manually if you want to test things in isolation

.
Any doc or example?

No, it just means, anything that can persist in your own code (which only you can know the details of) is something you'll have to ensure does not persist across test cases.


 Is there a workaround?

Hi, maybe you can try these steps:

Clone the repo:

https://github.com/huridocs/pdf-document-layout-analysis

Run src/download_models.py

cd pdf-document-layout-analysis
python src/download_models.py

After running src/download_models.py, you will have the models inside your local computer. Then, you can try to copy models folder to your remote server with everything inside of it.
Then, you can
make start

And a new image will be createdd for you.
Best

As I understand, clone the repository, run the src/download_models.py in a computer that has access to hugging face and then copy the repo to the remote server and run make start, is that right?

This command runs the already existing docker image from dockerhub:
docker run --rm --name pdf-document-layout-analysis --gpus '"device=0"' -p 5060:5060 --entrypoint ./start.sh huridocs/pdf-document-layout-analysis:v0.0.19

But since your remote servers do not have access to huggingface, when you run this command, the models cannot be downloaded automatically. So, you should not use the above command.
Instead, you should run src/download_models.py when you are in  pdf-document-layout-analysis project, this will download the models. After running this script, while you are still in pdf-document-layout-analysis, run make start. This will create a new docker image for you, with the models you have already downloaded.
So, if you download the models, and copy the models folder (this folder will be automatically created after you run src/download_models.py) to your remote server and run make start there, there will be a new image created for your remote server too.
You can also refer to building from source, which is only three lines: https://github.com/huridocs/pdf-document-layout-analysis?tab=readme-ov-file#build-from-source

@ali6parmak Thank you! I'm still getting following error. Could you help me out?
pdf-document-layout-analysis  |     raise EnvironmentError( pdf-document-layout-analysis  | OSError: Can't load tokenizer for 'naver-clova-ocr/bros-base-uncased'. If you were trying to load it from 'https://huggingface.co/models', make sure you don't have a local directory with the same name. Otherwise, make sure 'naver-clova-ocr/bros-base-uncased' is the correct path to a directory containing all relevant files for a BrosTokenizer tokenizer.

Looks like there is a problem with the models downloaded from huggingface. Try to run downloa_models.py again and make sure your models folder looks like as in the image.

Same error message @ali6parmak :(
Looks like it's unable to load below tokenizer.
  from pdf_layout_analysis.run_pdf_layout_analysis import analyze_pdf
pdf-document-layout-analysis  |   File "/app/src/pdf_layout_analysis/run_pdf_layout_analysis.py", line 16, in <module>
pdf-document-layout-analysis  |     from vgt.create_word_grid import create_word_grid, remove_word_grids
pdf-document-layout-analysis  |   File "/app/src/vgt/create_word_grid.py", line 14, in <module>
pdf-document-layout-analysis  |     tokenizer = BrosTokenizer.from_pretrained("naver-clova-ocr/bros-base-uncased")
pdf-document-layout-analysis  |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pdf-document-layout-analysis  |   File "/app/.venv/lib/python3.11/site-packages/transformers/tokenization_utils_base.py", line 2073, in from_pretrained
pdf-document-layout-analysis  |     raise EnvironmentError(
pdf-document-layout-analysis  | OSError: Can't load tokenizer for 'naver-clova-ocr/bros-base-uncased'. If you were trying to load it from 'https://huggingface.co/models', make sure you don't have a local directory with the same name. Otherwise, make sure 'naver-clova-ocr/bros-base-uncased' is the correct path to a directory containing all relevant files for a BrosTokenizer tokenizer.

We will rearrange the project to address these issues in the future. Meanwhile, you can download the tokenizer from this URL:
https://huggingface.co/naver-clova-ocr/bros-base-uncased/tree/main
And then put the path in line 14 of the file:
src/vgt/create_word_grid.py
I hope this works.


support flink native type savepoint

What changes were proposed in this pull request
Issue Number: close #2936

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

Dependencies (does it add or upgrade a dependency): (yes / no)

I have used this pr at internal environment, and I am not familiar with the FE code.
Please review code, and give some suggestions. Thank you very much.

Thanks for your reviewing. I have modified codes, you can review again.


Cannot login or deploy application: findCredentials is not a function error

Before filing this issue, please ensure you're using the latest CLI by running swa --version and comparing to the latest version on npm.
Are you accessing the CLI from the default port :4280 ?

[ ] No, I am using a different port number (--port) and accessing the CLI from that port
[X ] Yes, I am accessing the CLI from port :4280

Make sure you are accessing the URL printed in the console when running swa start!

ℹ NOTE: Make sure to enable debug logs when running any swa commands using --verbose=silly
Describe the bug
I cannot deploy an application. It was working fine, but I have updated to the newest version. During running swa deploy i got:
Checking Azure session...
Executing authenticateWithAzureIdentity

details:

tenantId:
clientId:
clientSecret:

useKeychain: true
Keychain is enabled
Executing swaCliPersistencePlugin
Executing before cache access plugin
Machine ID:
Invoking crypto service
Getting credentials
Getting credentials from native keychain
Getting keychain reference
isKeychainEnabled: true
KeychainCache: undefined
Attempting to load native keychain
Executing after cache access plugin
Machine ID:
Invoking crypto service
Did TokenCacheContext cache changed: true
Setting credentials in keychain
Encrypting credentials
Encrypted credentials:
Setting credentials in native keychain
Getting keychain reference
isKeychainEnabled: true
KeychainCache: undefined
Attempting to load native keychain
✖ Failed to setup project: this.keychainCache.findCredentials is not a function

✖ If you believe this behavior is unexpected, please raise a GitHub issue at:
https://github.com/Azure/static-web-apps-cli/issues/new/choose
It also happens when i try toswa login`
Configuration used:
{   "$schema": "https://aka.ms/azure/static-web-apps-cli/schema",   "configurations": {     "app-frontend": {       "appLocation": ".",       "outputLocation": "dist",       "appBuildCommand": "npm run build",       "run": "npm run dev",       "appDevserverUrl": "http://localhost:5173",       "tenant": "XXXX",       "appName": "app-stage",       "resourceGroup": "app-sgr-stage",       "env": "prod"     }   } }
Desktop (please complete the following information):

OS: Windows
Version 11

I am having the same issue after updating to version 2.0.1 and am unable to deploy.

Hi, acknowledging this issue. We will test this locally and get it resolved. In the meantime, are you able to login or deploy using a prior version?

+1 for issue.  Affects the Visual Studio publish as it seems to shell to swa.cmd.

I’m still getting the same error even after running az login.


Releasing objects manually vs waiting for automatic cleanup

I've set up a cache of objects using nodecache. These objects get "processed" roughly 10s after being inserted into the cache. After they're processed I don't need to reference them and they can be destroyed.
Is it more resource efficient to .del() them after processing them manually, or to let them automatically expire after ~15 seconds?

Hi,
technically the expire is done by internal a timestamp stored in the object metadata.
With a interval defined in checkperiod node-cache searches for every object with obj.timestamp != 0 && obj.timestamp <= Date.now() and deletes them. So every expired object will destroyed.
The most efficient way for you case would be so set checkperiod = 0 and delete manually without using the expire feature.
In this case node-cache can save the memory for the expire timespace and will not start the internal interval to clean up the cache every x seconds.
Hope this information helps.

Thanks for the explanation!


limit fatal error: stack overflow

Hi!
I have 2 struct:
type Profile struct {
    Name    string `json:"name"`
    Media []Media `json:"media,omitempty"`
}

type Media struct {
    Image    string `json:"image"`
    Profile   *Profile `json:"profile,omitempty"`
}

Profile has many Media, Media has one Profile.
Аnd jsonschema for models ( VoteStatsDaysList so-so ):
{
    "$schema": "http://json-schema.org/draft-04/hyper-schema",
    "$ref": "#/definitions/VoteStatsDaysList",
    "definitions": {
        "Media": {
            "type": "object",
            "properties": {
                "image": {
                    "type": "string"
                },
                "profile": {
                    "$ref": "#/definitions/Profile"
                },
                "time": {
                    "type": "string",
                    "format": "date-time"
                }
            },
            "additionalProperties": false,
            "required": [
                "image"
            ]
        },
        "Profile": {
            "type": "object",
            "properties": {
                "name": {
                    "type": "string"
                },
                "media": {
                    "type": "array",
                    "items": {
                        "$ref": "#/definitions/Media"
                    }
                }
            },
            "additionalProperties": false,
            "required": [
                "name"
            ]
        },
        "VoteStatsDaysList": {
            "type": "object",
            "properties": {
                "items": {
                    "type": "array",
                    "items": {
                        "$ref": "#/definitions/Profile"
                    }
                },
                "total_pages": {
                    "type": "integer"
                }
            },
            "additionalProperties": false,
            "required": [
                "total_pages",
                "items"
            ]
        }
    }
}

Validation result:
runtime: goroutine stack exceeds<PHONE_NUMBER>-byte limit
fatal error: stack overflow

runtime stack:
runtime.throw(0x835d10, 0xe)
    /home/boston/.gvm/gos/go1.6.3/src/runtime/panic.go:547 +0x90
runtime.newstack()
    /home/boston/.gvm/gos/go1.6.3/src/runtime/stack.go:940 +0xb11
runtime.morestack()
    /home/boston/.gvm/gos/go1.6.3/src/runtime/asm_amd64.s:359 +0x7f

goroutine 1 [stack growth]:
github.com/xeipuuv/gojsonschema.(*Schema).parseSchema(0xc82000ee00, 0x7099e0, 0xc8200154a0, 0xc82854b860, 0xc82001bb88, 0xc828378fb8)
    /home/boston/docker/projects/test/golang/src/github.com/xeipuuv/gojsonschema/schema.go:102 fp=0xc840200900 sp=0xc8402008f8
github.com/xeipuuv/gojsonschema.(*Schema).parseProperties(0xc82000ee00, 0x7099e0, 0xc820015470, 0xc82854b680, 0x0, 0x0)
    /home/boston/docker/projects/test/golang/src/github.com/xeipuuv/gojsonschema/schema.go:866 +0x568 fp=0xc840200aa0 sp=0xc840200900
github.com/xeipuuv/gojsonschema.(*Schema).parseSchema(0xc82000ee00, 0x7099e0, 0xc820015440, 0xc82854b680, 0x0, 0x0)
    /home/boston/docker/projects/test/golang/src/github.com/xeipuuv/gojsonschema/schema.go:296 +0x26af fp=0xc840201ae8 sp=0xc840200aa0
github.com/xeipuuv/gojsonschema.(*Schema).parseReference(0xc82000ee00, 0x7099e0, 0xc8200153e0, 0xc82854b4a0, 0xc8200b92a0, 0x15, 0x0, 0x0)
..........
and many errors...

If remove profile from media in shema - are ok =(

I thought #171 fixed all of these kind of issues but apparently I'm wrong. In this specific instance I suspect the ref "$ref": "#/definitions/VoteStatsDaysList" causes issues, so you might be able to work around it by bringing the #/definitions/VoteStatsDaysList to the root level instead of nested inside a definitions block.
Since writing #171 I've come across more examples of referencing which still don't work properly, so I'll try to fix those issues some point in the future.

@johandorland validating against the opspec pkg schema has recently started hitting this error as well using latest version of this library so we'd be greatful too, cheers


Unmatched "end" in grammar spills out of "while"

I found a difference in behaviour between VS Code / GitHub syntax highlighting that I originally thought was VS Code's issue, but after some comments on https://github.com/microsoft/vscode/issues/189940 I'm now not so sure.
The issue is when a rule uses begin/end (for example triple-backtick code blocks) that is nested inside a rule using while1 (for example comments). It appears that in VS Code, if endnever matches, it still never expands outside of thewhile` rule, however on GitHub it does.
Example rules:
		"dartdoc": {
			"patterns": [
				{
					"contentName": "variable.other.source.dart",
					"begin": "```",
					"end": "```"
				}
			]
		},
		"comments": {
			"patterns": [
				{
					"name": "comment.block.documentation.dart",
					"begin": "///",
					"while": "^\\s*///",
					"patterns": [
						{
							"include": "#dartdoc"
						}
					]
				}
			]
		},

This colours comments green, and code blocks light blue. When the triple-backticks are closed, it looks like this in VS Code:

And if they are unclosed, they close at the end of the comment (using while):

However on GitHub, the unclosed triple backticks run to the end of the document (starting on line 10):

I previously thought the issue was VS Code's, but the comment at https://github.com/microsoft/vscode/issues/189940#issuecomment-2312138491 suggests that while doesn't allow a begin/end to escape outside of it. On the surface this sounds sensible, so I thought it was worth filing here.
(If this isn't the right repo for issues like this affecting the GitHub UI, I apologise, please point me in the right direction! Thanks!)

I'm pretty sure this is an issue with the grammar attempting to interpret these blocks and not ignoring them as comments. Other grammars don't attempt to intepret content in comments.
Here's Ruby which is using the treesitter grammar directly in the syntax highlighting engine:
# this is comment
# ```
# this is code
# ```
# this is comment
def foo

# this is comment
# ```
# this is code
#
# this is comment
def foo

And Shell which uses an old Textmate grammar shipped with Linguist:
# this is comment
# ```
# this is code
# ```
# this is comment
def foo

# this is comment
# ```
# this is code
#
# this is comment
def foo

I believe the Dart grammar should be doing the same but @Alhadis is more knowledgable with dealing with the intricacies of GitHub's old syntax highlighter than me.

I'm pretty sure this is an issue with the grammar attempting to interpret these blocks and not ignoring them as comments. Other grammars don't attempt to intepret content in comments.

I'm not sure I understand - although I used comments as an example, I don't think that semantics of what a comment means is relevant here. I could just as easily have used some other marker that could be some concept made up by my language, and not a "comment".
I think the question here is just whether begin/end captures should be allowed to break out of while captures. If so, then I think there's a bug in VS Code's implementation, and if they are not, I think there's a bug here. I can't find anything concrete to satisfy me one or the other, but I'd really like GitHub and VS Code to agree before I try to change the Dart grammar because I might end up going in the wrong direction.

Ah. Sorry, I have no idea. Maybe @Alhadis knows.
For what it's worth, the old syntax highlighter that GitHub uses for Textmate-based grammars (called prettylights - it's not public) is no longer being maintained so if GitHub is wrong, it's been this way for a very very very long time and won't be changing.

For what it's worth, the old syntax highlighter that GitHub uses for Textmate-based grammars (called prettylights - it's not public) is no longer being maintained so if GitHub is wrong, it's been this way for a very very very long time and won't be changing.

Ah, good to know - I wasn't familiar with exactly what's used where. If it has to remain broken on GH because of a bug in prettylights, so be it - but I don't want to try to fix it here and break VS Code in the process without being sure it's VS Code at fault (and therefore it might be fixed there). Thanks!

from what I last heard
The TextMate engine has not been archived and is still taking bug reports
https://github.com/github-linguist/linguist/issues/6668#issuecomment-1967809184
I'm not sure if this is what GitHub uses
https://www.npmjs.com/package/pretty-lights
but it seems pretty-lights is not the TextMate engine, merely the CSS styler
which would be unrelated to this bug

from what I last heard The TextMate engine has not been archived and is still taking bug reports #6668 (comment)

Correct, it hasn't been archived but AFAIK it is not actively being worked on in favour of keeping the lights on whilst switching to tree-sitter grammars.
That said, @patrickt might also be a good one to answer the original question about the correct behaviour.

I'm not sure if this is what GitHub uses https://www.npmjs.com/package/pretty-lights but it seems pretty-lights is not the TextMate engine, merely the CSS styler which would make it unrelated to this bug report

That's not it; the repo is private. We don't use that npm pkg either but if you're curious about where the stylesheets come from, they come from https://github.com/primer/github-syntax-light

👋 We’re not currently using tree-sitter-dart in our syntax highlighting pipeline—it looks fairly unmaintained, so I’d be against relying on it. However, fixes on the TextMate grammar side should percolate into our highlighting pipeline as a whole. I forget exactly how that works; let me dig in.

Ah. Sorry, I have no idea. Maybe @Alhadis knows.

@lildude This matter concerns a rather oblique feature of TextMate grammars (begin/while pairs) that I admit I have little familiarity with. However, PrettyLights's behaviour appears to be correct here: the comment by @RedCMD seems to indicate an implementation difference in VSCode's handling of begin/while pairs, a discrepancy that—given the sketchy and under-documented nature of this particular feature—comes as no surprise.
For this reason, I strongly advise against using while when possible. Instead, I'd use an end pattern with a negative lookahead (end: "^(?!\\s*///)"), and I'd rewrite the embedded rules to short-circuit on the same pattern:
Click to toggle
	"dartdoc": {
		"patterns": [{
			"name":  "comment.block.documentation.dart",
			"begin": "^\\s*(///)\\s*(```)",
			"end":   "^\\s*(///)\\s*(```)|^(?!\\s*///)",
			"contentName": "variable.other.source.dart",
			"beginCaptures": {
				"1": {"name": "punctuation.definition.comment.dart"},
				"2": {"name": "punctuation.section.code-fence.begin.dartdoc"}
			}
		}]
	},
	"comments": {
		"patterns": [{
			"name":  "comment.block.documentation.dart",
			"begin": "^\\s*///",
			"end":   "^(?!\\s*///)",
			"patterns": [{"include": "#dartdoc"}]
		}]
	}

seems to indicate an implementation difference in VSCode's handling of begin/while pairs, a discrepancy that—given the sketchy and under-documented nature of this particular feature—comes as no surprise.
For this reason, I strongly advise against using while when possible

While this may work, I feel like it would be better for everyone if we could try to come to some concensus about what the behaviour should be. There are many grammers and many clients, and if the "spec" is vague, it would be better to at least have some agreement between the most popular implementations than to have to avoid the feature.
If VS Code + GitHub disagree, maybe there are other common implementations we could review to see if there's a most common interpretation that the others would agree to?

While this may work, I feel like it would be better for everyone if we could try to come to some concensus about what the behaviour should be. There are many grammers and many clients, and if the "spec" is vague, it would be better to at least have some agreement between the most popular implementations than to have to avoid the feature.

I plan on penning an authoritative spec for the TextMate grammar format, based on past and present implementations of its highlighting system. However, I'm still waiting to hear back from @lildude regarding access to the PrettyLights repository; I'll shoot him an e-mail with a follow-up as he's probably forgotten. 😁

If VS Code + GitHub disagree

I believe it's just VSCode that deviates from other implementations regarding begin/while blocks. I'll need to check, as the truncation of unclosed begin/end blocks within begin/while rules strikes me as unusual.

The 1.X TextMate manual does not mention while https://macromates.com/manual/en/
The 2.0 TextMate manual mentions while once. But only states it is related to begin language-grammars
TextMate's public repo https://github.com/textmate/textmate
TextMate.md states

\G matches end of last stacked while

Which VSCode does do, and I assume PrettyLights does as well
VSCode does however clear the \\G anchor upon the next rule match. idk what PrettyLights and TextMate does
Looking at TextMates only tested example grammar
It seems while also places a \\G anchor at the beginning of the next line.
Which VSCode definitely does not currently do, and I don't think PrettyLights does either.
The example also seems to describe that the begin/end rule places its scopes overtop the while capture.
Which PrettyLights does do, but VSCode does not.
private.h header file
grammar.cc loads grammar file etc
parse.cc parses document
https://github.com/textmate/textmate/blob/master/Frameworks/parse/src/parse.cc#L408-L411 seems to indicate that a failed while rule will return the stack back to its own parent, terminating any inside begin/end rules

However, PrettyLights's behaviour appears to be correct here

PrettyLights's behaviour is definitely not correct
I wouldn't say giving up, lighting itself on fire and dying to be any sort of good implementation.
As evident by the zero syntax highlighting after the problematic rules

https://github.com/arquivolta/desktop/blob/main/lib/platform/win32/arch_to_rootfs.dart#L23-L157
https://github.com/dart-lang/markdown/blob/cc57a08156356d7fc8c06c73de972c58ddb39a87/lib/src/block_parser.dart#L422-L1106

@Alhadis

I plan on penning an authoritative spec for the TextMate grammar format, based on past and present implementations of its highlighting system.

This sounds like a great idea - having something to use as a reference across implementations may avoid these kinds of issues.

I believe it's just VSCode that deviates from other implementations regarding begin/while blocks. I'll need to check, as the truncation of unclosed begin/end blocks within begin/while rules strikes me as unusual.

If this is the case (and you know of other implementations behaving like PrettyLights), it would be worth posting in https://github.com/microsoft/vscode/issues/189940 (I feel you're more qualified than I) as their response was that this is not a VS Code issue, and I think it's better for all if all implementers can agree on something.
That said, I don't know if @RedCMD's post changes anything here - I don't understand all the details, but on the surface it seems to make some good points (thank you @RedCMD for the input!).

I see this has been confirmed as a bug in VSCode as PrettyLights is matching TextMate 2's behaviour.
Closing as there's nothing more to do here.

@Alhadis I tried implementing your example from above (https://github.com/github-linguist/linguist/issues/7015#issuecomment-2321028904) but I see a problem and I'm not sure whether it's because the parser I'm using is bad (it's a custom parser to run some automated tests), or whether the sample was just incomplete.
Given code like:
/// ```
/// foo
/// ```

The variable.other.source.dart scope begins with /// ``` and ends with /// ```  which means all of the line prefixes /// inside the code block are marked as variables variable.other.source.dart so the comment markers will be highlighted incorrectly.
I think I could add a nested pattern to set them back as comments, but then the scope will be something like "comment variable comment". This feels clunky so I'm wondering if it's really the best way or if I've overlooked something simpler?
Thanks!

nm, I think I found a way, but removing contentName from that match and using a nested pattern to only apply it to the code after the comment markers :)
{
	"begin": "^\\s*(///)\\s*(```)",
	"end": "^\\s*(///)\\s*(```)|^(?!\\s*///)",
	"patterns": [
		{
			"include": "#dartdoc-codeblock"
		}
	]
},

// ...
"dartdoc-codeblock": {
	"begin": "^\\s*(///)\\s*",
	"end": "\n",
	"contentName": "variable.other.source.dart"
},


Draw Shapes example throws error when drawing star

The Draw Shapes example throws an error TypeError: e is null when drawing a star shape. The other shapes are fine.
You can see it here.
Browser: Firefox Developer Edition 62.0b19 (64-bit)
OS: Linux 4.18.3

Thanks for the bug report, this issue was fixed with #8483


Simplify SimonaConfig with shared param object

Parameter structures like sqlParams, csvParams are very similar (if not identical) across input types (currently primary and weather).
Shared parameters like timePattern could also be provided by a common trait/superclass.
Depending on https://github.com/carueda/tscfg/pull/126, these can be implemented as optional shared objects.

This is partly implemented for csv with #150

Now invalid since we'll switch config frameworks anyways


Updated Contribute page

Added Google Form link for people to contact us with story ideas/offers

Altered invitation language to suggest three areas of interest/focus reflecting recent discussions on "themes"

people whose work and impact in open source are not always quantifiable into a dashboard or evident from an API
communities who have navigated major inflection points in open source
open source decision makers who are interested in sharing their perspectives on foundational changes to open source projects

LGTM!


readme documentation doesn't suggest how to "accept or reject" angular analytics prompt

my first time cloning and running this, it asked "Would you like to share pseudonymous usage data about this project with the
Angular Team", I typed y, but it didn't work, so I had to do ng serve seperatly, and then accept with y, then after that, it works :)
rk@Roberts-MacBook-Air angular-tauri % npm start

><EMAIL_ADDRESS>start
> npm run tauri:serve

><EMAIL_ADDRESS>tauri:serve
> tauri dev

     Running BeforeDevCommand (`npm run web:serve`)
        Warn Waiting for your frontend dev server to start on http://localhost:4200/...

><EMAIL_ADDRESS>web:serve
> ng serve -o

? Would you like to share pseudonymous usage data about this project with the
Angular Team
at Google under Google's Privacy Policy at https://policies.google.com/privacy.
For more
details and how to change this setting, see https://angular.io/analytics. (y/N)
y
        Warn Waiting for your frontend dev server to start on http://localhost:4200/...
        Warn Waiting for your frontend dev server to start on http://localhost:4200/...
        Warn Waiting for your frontend dev server to start on http://localhost:4200/...
        Warn Waiting for your frontend dev server to start on http://localhost:4200/...
        Warn Waiting for your frontend dev server to start on http://localhost:4200/...

@robert-king Angular analytics is now disabled by default
angular.json
"cli": {
    "analytics": false
  }


Update start-with-a-template.md

Edited for present tense and active voice, as well as some ambiguous wording.

Summary
I noticed some future tense and passive voice, which don't read well. I've also noticed some ambiguous phrasing.
Test plan

A picture of a cute animal (not mandatory but encouraged)

Relevant to #1632

Deploy preview for netlify-cms-www ready!
Built with commit 8b37884c12f06c6a74ff7e3571ee6bc37c90b4c7
https://deploy-preview-1633--netlify-cms-www.netlify.com

Deploy preview for cms-demo ready!
Built with commit 8b37884c12f06c6a74ff7e3571ee6bc37c90b4c7
https://deploy-preview-1633--cms-demo.netlify.com


The function "encode" for the RS algorithms

At the moment for the RS algorithms the function encode expects a path to a private pem file rather than a structure representing a private pem file itself. Should it be changed, leave your comment.

I would like to see a version of the encode/decode function that can handle an in-memory data structure.
I can also help implementing this. Are you open for breaking changes or do you want a different encode/decode function for  this?

@Richterrettich

I would like to see a version of the encode/decode function that can handle an in-memory data structure.

will you elaborate?

Same here. We're using cognito so different keys per user pool, and per token type. An in mem representation would be excellent. Also, using the modulus + e directly, which would translate to a call to https://docs.rs/openssl/0.10.5/openssl/rsa/struct.Rsa.html#method.from_public_components instead.

Ok, will look into that