Remove deprecated experimentation field

Description
In version v0.13.0 we introduced the configuration option experimentation for your flags.
The field was introduced at the wrong level because it is supposed to be under rollout and it was not.
The v0.13.1 has fixed the problem but we have continued to support both configurations.
⚠ This PR removes the support of the old configuration, so check your flag file to be sure that you've configured the good format.
Since the version v0.13.0 and the associate documentation was here only for a quick period it should be ok, but this worth checking.
Changes include

[ ] Bugfix (non-breaking change that solves an issue)
[ ] New feature (non-breaking change that adds functionality)
[x] Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)
Resolve #114
Checklist

[x] I have tested this code
[x] I have added unit test to cover this code
[ ] I have updated the Readme
[x] I have followed the contributing guide

Coverage decreased (-0.06%) to 96.463% when pulling 8a5f83cbd8ea069c437c280bef6705b79a4930ee on change/114-remove-deprecated into feb81940eb321e73de6d006531562f41ea459567 on main.


playback-state listener not giving proper status in ios

Configuration
React Native Environment Info:
System:
OS: macOS 10.14.4
CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
Memory: 41.00 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.11.3 - ~/.nvm/versions/node/v8.11.3/bin/node
Yarn: 1.12.3 - /usr/local/bin/yarn
npm: 5.6.0 - ~/.nvm/versions/node/v8.11.3/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 21, 22, 23, 24, 25, 26, 27, 28
Build Tools: 23.0.1, 23.0.2, 23.0.3, 24.0.2, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.0, 28.0.2, 28.0.3
System Images: android-22 | Google APIs Intel x86 Atom, android-27 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.1 AI-173.4819257
Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.4 => 0.59.4
npmGlobalPackages:
react-native-asset: 1.1.3
react-native-cli: 2.0.1
react-native-rename: 2.4.1
react-native-track-player version : 1.1.4
Issue
The issue is occurring in ios whenever we play a track or skip to next track ios not providing proper status. It skips loading state when we are skipping tracks. In android is working fine.
Here is console screenshot of android

In above screenshot is related android which so console event received from playback-state event-listener. You can see the top part is when I play track initially. And then skip to next track which consoles loading event that is 6 and then consoles 3 means play. Which perfectly working in android.
But in case of ios, you can see in below screenshot that when we skip to next track it doesn't provide loading event. when i call TrackPlayer.skipToNext() it consoles paused state then ready and then playing. That means it is not giving any loading state. Sometimes when we skip to next track then the player takes some time to load tracks from the network so in this case loading is require so we can show loader but in this case, it only return pause on skip and when the player starts playing then it returns ready and playing state.

In ios need also loading event when we skip to next track as we have in android.
Code
I am using mobx in my project.
AudioStore.js
import { Platform } from 'react-native'
import { Toast } from 'native-base'
import { observable, action } from 'mobx'
import TrackPlayer, { seekTo } from 'react-native-track-player'
import findIndex from 'lodash/findIndex'

export default class TrackPlayerStore {
  @observable state = null
  @observable tracks = null
  @observable currentTrack = null
  @observable metaData = null
  @observable miniPlayerHeight = 0
  @observable currentTrackIndex = null
  @observable isNext = null
  @observable isPrev = null
  @observable totalTracks = 0
  @observable audioPlayRate = 1
  @observable audioPlayRateLabel = '1x'

  constructor() {
    console.log('STATE_BUFFERING', TrackPlayer.STATE_BUFFERING)
    console.log('STATE_PLAYING',  TrackPlayer.STATE_PLAYING)
    console.log('STATE_PAUSED',  TrackPlayer.STATE_PAUSED)
    console.log('STATE_STOPPED',  TrackPlayer.STATE_STOPPED)
    console.log('STATE_NONE',  TrackPlayer.STATE_NONE)

    // console.log('audioStore initialized')
    TrackPlayer.getState().then((status) => {
      // console.log('Initial audio Player State:', status);
      this.state = status
    })

    TrackPlayer.addEventListener('playback-state', (data) => {
      console.log('playback-state:', data.state)
      this.state = data.state
      if (data.state === TrackPlayer.STATE_PLAYING) {
        TrackPlayer.getRate().then((data) => {
          if (data !== this.audioPlayRate) {
            this.setAudioPlayerRate(this.audioPlayRate, (Platform.OS === 'ios' ? 0 : 0))
          }
        }, (error) => {

        })
      }

    });

    TrackPlayer.addEventListener('playback-track-changed', (trackData) => {
      const { nextTrack } = trackData
      if (this.tracks) {
        const queueIndex = findIndex(this.tracks, { id: nextTrack })
        this.setCurrentTrack(this.tracks[queueIndex], queueIndex)
        this.setTracksIndexDetails(this.tracks, queueIndex)
      } else {
        TrackPlayer.getQueue().then((data) => {
          const queueIndex = findIndex(data, { id: nextTrack })
          this.setCurrentTrack(data[queueIndex], queueIndex)
          this.setTracksIndexDetails(data, queueIndex)
        }, (error) => {

        })
      }
      // this.setAudioPlayerRate(this.audioPlayRate, (Platform.OS === 'ios' ? 2000 : 0))
    });

    TrackPlayer.addEventListener('playback-queue-ended', (data) => {
      // console.log('playback-queue-ended =================', data)
      if (Platform.OS === 'ios') {
        // if (this.currentTrack !== null && this.state === TrackPlayer.STATE_PAUSED) {
        // TrackPlayer.seekTo(0)
        // }
        this.stopAudio()
      } else {
        if (data.position !== 0 && data.track !== null) {
          this.stopAudio()
        }
      }
    });

  }
  @action
  setTracks(tracks) {
    this.tracks = tracks
  }

  @action
  setCurrentTrack(currentTrack, index) {
    this.currentTrack = currentTrack
    if (index !== null) {
      this.currentTrackIndex = index
    }
  }

  @action
  setTracksIndexDetails(tracks, queueIndex) {
    if (tracks.length > 0) {
      if (queueIndex === 0) {
        if (tracks.length > 1) {
          this.isNext = true
          this.isPrev = false
        }
      } else {
        if ((queueIndex - 1) === -1) {
          this.isPrev = false
        } else {
          this.isPrev = true
        }
        if ((queueIndex + 1) < tracks.length) {
          this.isNext = true
        } else {
          this.isNext = false
        }
      }
    }
  }

  @action
  async playAudio(tracks) {
    await TrackPlayer.setupPlayer({}).then(() => {
      TrackPlayer.updateOptions({
        jumpInterval: 30,
        capabilities: [
          TrackPlayer.CAPABILITY_PLAY,
          TrackPlayer.CAPABILITY_PAUSE,
          TrackPlayer.CAPABILITY_JUMP_FORWARD,
          TrackPlayer.CAPABILITY_JUMP_BACKWARD
        ],
        compactCapabilities: [
          TrackPlayer.CAPABILITY_PLAY,
          TrackPlayer.CAPABILITY_PAUSE
        ],
        stopWithApp: true
      })
    })
    await TrackPlayer.reset()
    await TrackPlayer.add([...tracks])
    this.totalTracks = tracks.length
    this.setTracks(tracks)
    TrackPlayer.play().then(() => {
      this.setAudioPlayerRate(this.audioPlayRate)
    }, (error) => {
      Toast.show({
        text: "Something went wrong!",
        duration: 5000,
        type: "danger"
      })
    })
  }

  @action
  togglePlayPause() {
    if (this.state === TrackPlayer.STATE_PAUSED) {
      TrackPlayer.play()
    } else {
      TrackPlayer.pause()
    }
  }

  @action
  seekTo(secs) {
    TrackPlayer.getPosition().then((position) => {
      const finalPosition = position + secs
      if (finalPosition <= 1) {
        TrackPlayer.seekTo(1)
      } else {
        TrackPlayer.seekTo(finalPosition)
      }
    }, (error) => {
    })
  }

  @action
  stopAudio() {
    TrackPlayer.stop()
    this.currentTrack = null
    this.tracks = null
    this.state = null
    this.miniPlayerHeight = 0
    this.currentTrackIndex = null
    this.isNext = null
    this.isPrev = null
    this.totalTracks = 0
    this.miniPlayerHeight = 0
    this.audioPlayRate = 1
    this.audioPlayRateLabel = '1x'

  }

  @action
  setAudioPlayerRate(rate, delay = 0) {
    if (this.state === TrackPlayer.STATE_PLAYING) {
      this.audioPlayRate = rate
      this.audioPlayRateLabel = (rate === 1) ? '1x' : '1.5x'
      setTimeout(() => {
        TrackPlayer.setRate(rate)
      }, delay)
    }
  }

  @action
  setMiniAudioPlayerHeight(height) {
    // console.log('setMiniAudioPlayerHeight', height)
    this.miniPlayerHeight = height
  }

  @action
  skipToNext() {
    TrackPlayer.skipToNext()
  }

  @action
  skipToPrevious() {
    TrackPlayer.skipToPrevious()
  }
}

initialize trackplayer
TrackPlayer.setupPlayer().then(() => {
      TrackPlayer.updateOptions({
        jumpInterval: 10,
        capabilities: [
          TrackPlayer.CAPABILITY_PLAY,
          TrackPlayer.CAPABILITY_PAUSE,
          TrackPlayer.CAPABILITY_STOP,
          TrackPlayer.CAPABILITY_JUMP_FORWARD,
          TrackPlayer.CAPABILITY_JUMP_BACKWARD
        ],
        compactCapabilities: [
          TrackPlayer.CAPABILITY_PLAY,
          TrackPlayer.CAPABILITY_PAUSE
        ],
        stopWithApp: true
      })
      // console.log('Audio player setup successful')
    })

And to skip to next track in any component
    this.props.audioStore.skipToNext()

+1

+1
Same issue here with latest version.
playback-state is no longer firing.

are there any updates on this?

Same issue for me, playback-state is not triggered.

Are there any updates on this? As playback-state isn't firing for me (on v2 rc-13)

@harrysayers : No solution provided yet

We believe this has now been improved in v2


OSS fiftyone-brain updates

What changes are proposed in this pull request?
Updates for an open source fiftyone-brain package
How is this patch tested? If it is not, please explain why.
Install scripts
Release Notes

Open sourced fiftyone-brain

What areas of FiftyOne does this PR affect?

[ ] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[ ] Core: Core fiftyone Python library changes
[x] Documentation: FiftyOne documentation changes
[x] Other

Summary by CodeRabbit

New Features

Introduced a new command-line option -b for source installation of the fiftyone-brain package.

Bug Fixes

Removed the obsolete -v option from installation scripts, streamlining the installation process.

Documentation

Updated the README to clarify contributions to FiftyOne and FiftyOne-Brain, and removed the section on Storybook UI development.

Running ./install.bat -b resulted in the following output:
***** INSTALLING FIFTYONE-BRAIN *****
Cloning FiftyOne Brain repository
Cloning into 'fiftyone-brain'...
remote: Enumerating objects: 5885, done.
remote: Counting objects: 100% (1600/1600), done.
remote: Compressing objects: 100% (809/809), done.
remote: Total 5885 (delta 806), reused 1310 (delta 781), pack-reused 4285 (from 1)
Receiving objects: 100% (5885/5885), 1.07 MiB | 7.48 MiB/s, done.
Resolving deltas: 100% (3065/3065), done.
WARNING: Ignoring invalid distribution -iftyone (c:\users\camro\workplace\envs\oss\lib\site-packages)Processing c:\users\camro\workplace\fiftyone\fiftyone-brain
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Requirement already satisfied: numpy in c:\users\camro\workplace\envs\oss\lib\site-packages (from fiftyone-brain==0.17.0) (1.24.2)
Requirement already satisfied: scipy>=1.2.0 in c:\users\camro\workplace\envs\oss\lib\site-packages (from fiftyone-brain==0.17.0) (1.14.0)
Requirement already satisfied: scikit-learn in c:\users\camro\workplace\envs\oss\lib\site-packages (from fiftyone-brain==0.17.0) (1.5.1)
Requirement already satisfied: joblib>=1.2.0 in c:\users\camro\workplace\envs\oss\lib\site-packages (from scikit-learn->fiftyone-brain==0.17.0) (1.4.2)
Requirement already satisfied: threadpoolctl>=3.1.0 in c:\users\camro\workplace\envs\oss\lib\site-packages (from scikit-learn->fiftyone-brain==0.17.0) (3.5.0)
Building wheels for collected packages: fiftyone-brain
  Building wheel for fiftyone-brain (pyproject.toml) ... done
  Created wheel for fiftyone-brain: filename=fiftyone_brain-0.17.0-py3-none-any.whl size=98943 sha256=2c8866defa6a4efebd2498a2f285bb0dedaf63de24285db3cab90f57587a4eaa
  Stored in directory: c:\users\camro\appdata\local\pip\cache\wheels\b1\e9\53\08525e20b4cc357b060580f391a4a5dea39988c1f49533ff9e
Successfully built fiftyone-brain
WARNING: Ignoring invalid distribution -iftyone (c:\users\camro\workplace\envs\oss\lib\site-packages)Installing collected packages: fiftyone-brain
  Attempting uninstall: fiftyone-brain
    Found existing installation: fiftyone-brain 0.16.1
    Uninstalling fiftyone-brain-0.16.1:
      Successfully uninstalled fiftyone-brain-0.16.1
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
fiftyone 0.24.1 requires fiftyone-brain<0.17,>=0.16.1, but you have fiftyone-brain 0.17.0 which is incompatible.
Successfully installed fiftyone-brain-0.17.0

seems to work as expected


Global shell settings

Switched this over to use IORefs. (https://github.com/ku-fpg/hermit-shell/issues/29)

@RyanGlScott Good points! Should debug output be controlled by the quiet mode option? I was thinking that quiet mode would be if we don't want to print out every step of a script (which gives us behavior more like HERMIT's original behavior).

If you want to separate shell output from developer-specific output, then ignore what I said about when debug. :)


Closing card do not kill stream

I have tablet on wall with HA companion app on it. When someone is near my doors, I am using browser_mod.popup to show custom:webrtc-camera card. After timeout popup disappear, but go2rtc keep showing, that stream is active and sending data. More popups over time giving more streams online, and eventually it crashing my companion app.
While I am not sure this issue is related to WebRTC, go2rtc or browser_mod.popup, problem is there.

I think this problem related to browser_mod. Because webrtc-camera can handle: lovelace view switch, browser tab switch and browser minimize. You can check all this features without browser_mod.


oneOf doesn't work

Seems like schema with oneOf is not properly handled. I have the swagger.json which looks something like this:
"/v1/something": {
      "post": {
        "tags": ["Something"],
        "summary": "Create something",
        "description": "This some description",
        "requestBody": {
          "content": {
            "application/json": {
              "schema": {
                "oneOf": [
                  {
                    "$ref": "#/components/schemas/TypeA"
                  },
                  {
                    "$ref": "#/components/schemas/TypeB"
                  }
                ]
              }
            }
          },
          "required": true
        },
        "responses": {
          "201": {
            "description": "Created",
            "content": {
              "application/json": {
                "schema": {
                  "$ref": "#/components/schemas/TypeC"
                }
              }
            }
          }
        },
        "security": [
          {
            "Bearer": ["some.scope"]
          }
        ]
      }
    },

but it results in an empty body:

I see now this comment that seems to be related


Sign error

Hi,
trying signing feature with a random pdf I encountered this error in web console. This happens after clicking "Download PDF", this error pops up and sign disappear.
Test with:

Firefox and chrome
Any type of sign (image, free draw, text)

If you want I can provide the PDF used.
Note: it is working with another (smaller) pdf.
Uncaught (in promise) Error: Expected instance of e, but got instance of undefined
    e https://whateverdomain.tld/js/thirdParty/pdf-lib.min.js:15
    lookup https://whateverdomain.tld/js/thirdParty/pdf-lib.min.js:15
    lookup https://whateverdomain.tld/js/thirdParty/pdf-lib.min.js:15
    Pages https://whateverdomain.tld/js/thirdParty/pdf-lib.min.js:15
    computePages https://whateverdomain.tld/js/thirdParty/pdf-lib.min.js:15
    access https://whateverdomain.tld/js/thirdParty/pdf-lib.min.js:15
    getPages https://whateverdomain.tld/js/thirdParty/pdf-lib.min.js:15
    getPage https://whateverdomain.tld/js/thirdParty/pdf-lib.min.js:15
    getOverlayedPdfDocument https://whateverdomain.tld/js/draggable-utils.js:231
    async* https://whateverdomain.tld/sign:1207
    EventListener.handleEvent* https://whateverdomain.tld/sign:1206
pdf-lib.min.js:15:187156
    <anonima> https://whateverdomain.tld/sign:1214
    AsyncFunctionThrow self-hosted:856
    (Asinc.: async)
    <anonima> https://whateverdomain.tld/sign:1206

I Cant reproduce this using PDFs on my side
Are you just signing the drawing sign feature or text or image?
And can you test same on
https://pdf.adminforge.de/sign

if you get same results can you please send PDF it would be very helpful!

Same result
Running: 0.18.1
Here is the pdf
AGRICOLUS_Brochure.pdf

It works if you first repair the PDF using the repair tool: https://pdf.adminforge.de/repair

Confirm. Thank you


chore(plugins/pdf-to-html): add comment re poppler title handling

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1118

Relevant Lines:
1118

💛  - Coveralls


Warning in console

After the gem is added to the Gemfile starting console gives the message

irb: warn: can't alias context from irb_context.

Gemfile at the moment
source 'https://rubygems.org'

ruby '2.1.2'

# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '4.1.5'
# Use postgresql as the database for Active Record
gem 'pg'

# assets
# Use SCSS for stylesheets
gem 'sass-rails', '~> 4.0.3'
# Use Uglifier as compressor for JavaScript assets
gem 'uglifier', '>= 1.3.0'
gem 'compass-rails'
gem 'fancy-buttons'
# Use CoffeeScript for .js.coffee assets and views
gem 'coffee-rails', '~> 4.0.0'
# See https://github.com/sstephenson/execjs#readme for more supported runtimes
gem 'therubyracer',  platforms: :ruby
# Use jquery as the JavaScript library
gem 'jquery-rails'

# Turbolinks makes following links in your web application faster. Read more: https://github.com/rails/turbolinks
gem 'turbolinks'

# auth
gem 'authlogic'
gem 'cancancan'

# views
# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
gem 'jbuilder', '~> 2.0'
gem 'haml-rails'
gem 'simple_form'
gem 'wice_grid'

# Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
gem 'spring',        group: :development

group :development do
  # i18n
  gem 'active_record_model_and_rspec_enhanced_templates'
  gem 'advanced_haml_scaffold_generator'
  gem 'factory_girl_fixtures_template'
  gem 'i18n_scaffold_controller_template'
  gem 'i18n_scaffold_generator'
  gem 'i18n_yaml_sorter', require: false
  gem 'jbuilder_rspec_generator'
  gem 'rspec_rails_scaffold_templates'
  gem 'translations_sync'

  # docs
  # bundle exec rake doc:rails generates the API under doc/api.
  gem 'sdoc', '~> 0.4.0',          group: :doc
end

group :test, :development do
  gem 'factory_girl_rails'
  gem 'guard'
  gem 'guard-rspec'
  gem 'quiet_assets'
  gem 'rspec-activemodel-mocks'
  gem 'rspec-rails'
  gem 'zeus', require: false

  # Metrics
  gem 'rubocop', require: false
  gem 'brakeman', require: false
end

group :test do
  gem 'capybara'
  gem 'database_cleaner'
  gem 'email_spec'
  gem 'poltergeist'
  gem 'shoulda-matchers'
end

+1

Same here. I fixed it by removing this gem from the development group and use it in the test group only.
group :test do
  # ....
  gem 'rspec-activemodel-mocks'
end

for me it was "guard-rspec"


ServerStreaming retries

Add retries and resume support. This is last part of #433
This PR consists of 3 parts split by commit:

minor refactoring of test helpers to enable tests on the later parts
Implement retries w. resume
Implement support for timeouts

Conceptually, retries for streams can be split into 2 phases: before the first response is observed and after. Before the first response is observed, retries can be handled automatically similar to unary RPCs. After the first response is observed, manual work needs to done to recalculate the retry request. This work is delegated to a StreamTracker, which is notified of incoming responses and can be asked to build a resume request on failure. Gax should offer out of box support for the first kind of retries and allow client developers to manually add support for resumes via handwritten code. I envision the workflow for client developers as: add retry codes & settings to GAPIC yaml to enable simple retries, then implement a StreamTracker and set it on the ServerStreamingCallSettings.
This PR also implements timeouts for RPCs. The existing concepts of RPC & total timeouts are extended: RPC timeout now limits the time interval between a consumer signaling demand for the next response via StreamController#request() and receiving a response in ResponseObserver#onResponse. Total timeout limits the total duration of the stream from the initial call() until the last onComplete/onError of the last retry attempt. Furthermore, the concept of idle timeout is added to streams with manual flow control, this limits the time between last observed consumer activity (the time between finishing processing a response in onResponse to the next call to request). This is meant to address the possibility of the caller forgetting to cancel a partially read stream.
Since GRPC does not implement the concept of RPC timeouts for streams, this PR implements it as  a watchdog helper. The helper tracks activity per stream and schedules periodic garbage collection sweeps. So stream RPC timeouts are a lot looser than their unary counterparts. Furthermore, the helper needs to receive more information from its callers than is currently available: it needs to be able to accept both an rpc timeout and a total stream deadline. I couldn't figure out how to generalize this and extend the ApiContext to carry this information.  So the watchdog helper steps outside the callable chain pattern and is implemented as a factory for ResponseObserver decorators.

Codecov Report

Merging #449 into master will decrease coverage by 0.35%.
The diff coverage is 67.34%.

@@             Coverage Diff              @@
##             master     #449      +/-   ##
============================================
- Coverage     71.94%   71.58%   -0.36%
- Complexity      746      782      +36
============================================
  Files           154      158       +4
  Lines          3329     3671     +342
  Branches        256      295      +39
============================================
+ Hits           2395     2628     +233
- Misses          837      925      +88
- Partials         97      118      +21

Impacted Files
Coverage Δ
Complexity Δ

...rc/main/java/com/google/api/gax/rpc/Callables.java
70% <0%> (-26.56%)
6 <0> (ø)

...oogle/api/gax/rpc/ServerStreamingCallSettings.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...e/api/gax/rpc/RetryingServerStreamingCallable.java
0% <0%> (ø)
0 <0> (?)

...a/com/google/api/gax/grpc/GrpcCallableFactory.java
67.92% <25%> (-4.08%)
7 <0> (ø)

...src/main/java/com/google/api/gax/rpc/Watchdog.java
85.34% <85.34%> (ø)
6 <6> (?)

...m/google/api/gax/retrying/SimpleStreamTracker.java
85.71% <85.71%> (ø)
4 <4> (?)

.../google/api/gax/retrying/RetryingServerStream.java
90.07% <90.07%> (ø)
25 <25> (?)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532aae0...08fe31e. Read the comment docs.

Closing in favor of #463


Fix minor bugs in split command

Difference in case sensitivity of days in setm and split caused errors in split command.

Codecov Report

Merging #120 (c8fedf5) into master (23fcdb7) will decrease coverage by 0.03%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master     #120      +/-   ##
============================================
- Coverage     72.34%   72.31%   -0.04%
+ Complexity      567      566       -1
============================================
  Files            98       98
  Lines          1696     1694       -2
  Branches        186      186
============================================
- Hits           1227     1225       -2
  Misses          412      412
  Partials         57       57

Impacted Files
Coverage Δ

...c/main/java/seedu/address/model/person/Person.java
93.33% <ø> (-0.42%)
:arrow_down:

.../java/seedu/address/model/util/SampleDataUtil.java
0.00% <0.00%> (ø)

...ava/seedu/address/logic/commands/SplitCommand.java
100.00% <100.00%> (ø)

...seedu/address/logic/parser/SplitCommandParser.java
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23fcdb7...c8fedf5. Read the comment docs.


Release 1.1.0 quest

Did anybody know when to expect version 1.1.0?

Hopefully, very soon. We should discuss it with @jacomyal this very Wednesday normally.


Question: Azure VM offering with accelerating networking using Mellanox nic type ConnectX-4 or ConnectX-5

Using for example the Standard_DS3_v2 offering , includes the Accelerating Networking feature, but, it uses the nic type ConnectX-3® / Pro.
The vendor Mellanox describes its products in matrix rows with driver type (Linux,Windows), supported speeds, Ethernet: RoCE versions, VXLAN, GENEVE, SR-IOV Ethernet, iSER, N-VDS ENS.
The Azure docs https://docs.microsoft.com/en-us/azure/virtual-network/create-vm-accelerated-networking-powershell describes for a Windows VM the use of ConnectX-3 Ethernetadapter only.
How to found / is there already an Azure VM offering with accelerating networking specifically using a newer Mellanox nic type ConnectX®-4 / Lx  or ConnectX®-5 / Ex?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e4be8e45-460a-fab4-519b-32d83382005c
Version Independent ID: 36a002a6-5813-da00-0a57-068eeaf491cf
Content: Create an Azure VM with Accelerated Networking - Azure PowerShell
Content Source: articles/virtual-network/create-vm-accelerated-networking-powershell.md
Service: virtual-network
GitHub Login: @gsilva5
Microsoft Alias: gsilva

Thanks for the question. We are currently investigating and will update you shortly.

@dcasota , Appreciate your patience. There is no possibility for now for checking/selecting the Mellanox driver for specific VM size before deploying. And also from the reproduced scenario, I found that a basic VM SKU which supports accelerated networking is carrying the same Mellanox ConnectX-3 network adapter as the Standard E64s v3 (64 vcpus, 432 GiB memory) VM which is largest among the SKU. So, as of now Azure by default provide you with the Mellanox ConnectX-3 network adapter. If you would like to install the Mellanox driver manually then please go through this manual.
We are closing this issue for now.If there are further questions regarding this matter, please reply and we will gladly continue the discussion.
Disclaimer: This response contains a reference to a third-party World Wide Web site. Microsoft is providing this information as a convenience to you. Microsoft does not control these sites and has not tested any software or information found on these sites; therefore, Microsoft cannot make any representations regarding the quality, safety, or suitability of any software or information found there. There are inherent dangers in the use of any software found on the Internet, and Microsoft cautions you to make sure that you completely understand the risk before retrieving any software from the Internet

Okay, thanks for clarifying. Really appreciate you answer! I switched from v2 to the Standard_E4s_v3 offering. From lessons learned, the Mellanox ConnectX-3 driver is included in newer product drivers.
The Azure docs for a Windows Server Virtual Machine is really good. And in respect to the vendors' reference for other OS the Mellanox driver could be installed manually.

Could Azure  provides the Mellanox ConnectX-4 network adapter now?

Fsv_2 series offers Mellanox ConnectX-4 beginning with the F8s_v2 size

Do they? Official docs say otherwise: https://docs.microsoft.com/en-us/azure/virtual-machines/fsv2-series
The Fsv2-series runs on the Intel® Xeon® Platinum 8272CL (Cascade Lake) processors and Intel® Xeon® Platinum 8168 (Skylake) processors.

I tried with Fsv_2 series still its support Mellanox X-3.Could you please help is there any series really supports X-4 or latest

In my experience, X-3 or X-4 gets assigned randomly which can change during VM restart.
If you add multiple interfaces, you may get X-4.

after adding multiple interfaces I have got X-4M.
Thank you !!

Hi
Is there a way to force using only connectX-4 only. Currently I see it get assigned randomly, as Nikhil also pointed out here.
See few issues on azure platform with ubuntu-18.04 based VM images:
Poor performance with testpmd on connectX-3.
sudo ./testpmd -l 0,1,2,3 -w 3f8f:00:02.0 --vdev="net_vdev_netvsc0,iface=eth1"   -- --port-topology=chained  --nb-cores 3 --rxq=3 --txq=3 -i
testpmd> show port stats all
######################## NIC statistics for port 1  ########################
RX-packets: 3989290    RX-missed: 0          RX-bytes:<PHONE_NUMBER>
RX-errors: 0
RX-nombuf:  0
TX-packets: 3989290    TX-errors: 0          TX-bytes:<PHONE_NUMBER>
Throughput (since last show)
Rx-pps:        88563          Rx-bps:    991910536
Tx-pps:        88563          Tx-bps:    991910536
############################################################################
testpmd>

@dcasota , Appreciate your patience. There is no possibility for now for checking/selecting the Mellanox driver for specific VM size before deploying. And also from the reproduced scenario, I found that a basic VM SKU which supports accelerated networking is carrying the same Mellanox ConnectX-3 network adapter as the Standard E64s v3 (64 vcpus, 432 GiB memory) VM which is largest among the SKU. So, as of now Azure by default provide you with the Mellanox ConnectX-3 network adapter. If you would like to install the Mellanox driver manually then please go through this manual.

This manual is not useful for anything. This is what MS would need to do at the host level to provide support for different adapters.
Is there a hope for the Azure SDK API to provide the ability to specify the adapter? We have customers who run into intermittent crashes with older mlx4 driver used by connectX-3 adapter in Linux. mlx5 driver used by connectX-4 adapter has no such issues.

We are also facing similar issues, where we would want to know on which instances/scenarios Connectx4/Connectx5 adapters would be attached to the VM. The Connectx3 adapter which uses the mlx4 driver is not really stable with DPDK. We would want to know that we could meet our scale requirements etc. It would be really helpful if we get list of instances that support Connectx4/Connectx5 adapters.

We are also facing similar issues, where we would want to know on which instances/scenarios Connectx4/Connectx5 adapters would be attached to the VM. The Connectx3 adapter which uses the mlx4 driver is not really stable with DPDK. We would want to know that we could meet our scale requirements etc. It would be really helpful if we get list of instances that support Connectx4/Connectx5 adapters.

What version of DPDK are you guys using?

We are also facing similar issues, where we would want to know on which instances/scenarios Connectx4/Connectx5 adapters would be attached to the VM. The Connectx3 adapter which uses the mlx4 driver is not really stable with DPDK. We would want to know that we could meet our scale requirements etc. It would be really helpful if we get list of instances that support Connectx4/Connectx5 adapters.

What version of DPDK are you guys using?

We are using DPDK 20.05

How to found / is there already an Azure VM offering with accelerating networking specifically using a newer Mellanox nic type ConnectX®-4 / Lx or ConnectX®-5 / Ex?
It works for a Standard_E4s_v3 virtual machine. The test system is a genV2 VMware Photon OS (Azure) flavor.
lspci -nn -v
1ac5:00:02.0 Ethernet controller [0200]: Mellanox Technologies MT27710 Family [ConnectX-4 Lx Virtual Function] [15b3:1016] (rev 80)
        Subsystem: Mellanox Technologies Device [15b3:0190]
        Physical Slot: 2
        Flags: bus master, fast devsel, latency 0, NUMA node 0
        Memory at fe0100000 (64-bit, prefetchable) [size=1M]
        Capabilities: [60] Express Endpoint, MSI 00
        Capabilities: [9c] MSI-X: Enable+ Count=8 Masked-
        Kernel driver in use: mlx5_core

f581:00:02.0 Ethernet controller [0200]: Mellanox Technologies MT27710 Family [ConnectX-4 Lx Virtual Function] [15b3:1016] (rev 80)
        Subsystem: Mellanox Technologies Device [15b3:0190]
        Physical Slot: 1
        Flags: bus master, fast devsel, latency 0, NUMA node 0
        Memory at fe0000000 (64-bit, prefetchable) [size=1M]
        Capabilities: [60] Express Endpoint, MSI 00
        Capabilities: [9c] MSI-X: Enable+ Count=8 Masked-
        Kernel driver in use: mlx5_core

uname -a
Linux photonos 5.10.61-1.ph4 #1-photon SMP Fri Sep 3 18:23:40 UTC 2021 x86_64 GNU/Linux


[enhancement]: Implement token validation in JokeHandler

PR Type
enhancement

Description

Introduced token validation in the JokeHandler class to enhance security.
Added a method validate to verify the token from request headers.
Integrated the validation process into the handleRequest method to ensure requests are authenticated before processing.

Changes walkthrough 📝
Relevant filesEnhancement

JokeHandler.javaImplement token validation in request handling

JokeFunction/src/main/java/ai/qodo/JokeHandler.java
Added a constant check for token validation.  Implemented validate method to check token validity in headers.  Integrated token validation in the handleRequest method.

+15/-0

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

/update_changelog
--pr_update_changelog.extra_instructions="
Focus on these files:
"
--pr_update_changelog.push_changelog_changes=true


Board jumps because of the padding moving around the timer

Maybe try using a stack instead of a column?

Same issue here on Samsung S10, one ui 2.0.
The size of the timer keeps changing and the Board jumps.


[WIP] Add typescript source component

this shows the minimum configuration to add a typescript component into the webpack build pipeline

I'd define one react component in typescript and reuse it in F#.
What do you think? Would it make sense to integrate this into the BookStore, or should I just write a blog post? ;D
Todo
[ ] Actually add a React component
Issues
[ ] I can't reference one tsx from another, when I do import X from './test2', where there is a file test2.tsx next to it, it fails with
Module not found: Error: Can't resolve './test2'

closes https://github.com/SAFE-Stack/SAFE-BookStore/issues/359

Mhm dunno. I personally think blog post would be better

Ok, makes sense to focus this project on the fable part


Vdataframe "schema_writing" ignored while computing KernelDensity model

Hello,
We tried to draw a density plot for our Vdataframe but got the error Permission denied for schema public
Looking at the error sql query CREATE  TABLE VERTICAPY_TEMP_MODEL_KDE_%name%_KernelDensity_Map (...) the function tries to create a table in the public schema which is not allowed in our Vertica setup.
We only authorize users on specific schemas in which they can create new persistent tables.
Diving into code, the KernelDensity model seems to always create a persistent table in the public schema.
Furthermore, after plotting the density graph, the KernelDensity model is systematically dropped.
With this observations in consideration, i would suggest the following :

Consider the "schema_writing" Verticapy Variable while generating the create table query
Add option to use a temporary table instead of a persistent one
Use temporary tables when model is only use for plotting purposes

I'm quite new to verticapy so feel free to correct or add precisions if I missed something
Regards
Edit: Typo

Hi FeatCrush,
Thank you for the feedback.
We will add this option in the next release.
Badr

This issue is solved in the version 0.6.0


Move Alist.Alist 3.35.0 to AList.AList 3.35.0

Microsoft Reviewers: Open in CodeFlow

@wingetbot run


add TDC snippet

Hi Omar! Thanks! How do we tag TDC in the model card? Here is one model that we uploaded: https://huggingface.co/tdc/hERG_Karim_Morgan We have around 20 more coming in the next couple of weeks!

Hey there! You can do library_name: tdc in the model card metadata :) as per https://huggingface.co/docs/hub/model-cards#specifying-a-library

Great, thank you! I have just added and it now seems like it can be found: https://huggingface.co/models?library=tdc&sort=downloads


Add proper template for issue generating

i can creat one template for creating the issue so it would be in proper format
with idea/functionality and bug as option

please assign this to me under GSSOC-23

already there- https://github.com/anmode/grabtern-frontend/issues/128


name is incompatible with Webpack 4

bundle-loader crashes in Webpack 4 when using name in the query, for example: bundle-loader?name=x!my-module.
The crash is TypeError: Cannot read property 'context' of undefined and happens right here:
https://github.com/webpack-contrib/bundle-loader/blob/master/index.js#L13

Forget that, it was fixed in 0.5.6.
Somehow yarn is playing tricks on me... I develop with a yarn link to a library that requires ^0.5.6 but it seems that I still got the 0.5.5 required by previous version (non-symlinked).
Not sure what happens here but if 0.5.6 is properly installed everything is fine.


Strange things with $_SESSION

I wanted to have a look at this cause I wanted to learn the concept of OOP & MVC at the same time.
So I tried to implement an old (PHP 5.6) procedural project.
I noticed that session only works per controller/view is it normal or I don't understand the concept ?
For exemple if I set
$_SESSION['hello'] = 'world'

in the Home (indexAction) controller I can't handle it in Home(forgotPasswordAction) ...
I try to debug or find an explanation for more than 4 hours but can't understand where the problem is and I hope that you may explain it.
The same thing if I set
$_SESSION['hello'] = 'world'

under
View::renderTemplate('Home/index.html.twig')

I can't get it under
View::renderTemplate('Home/forgot-password.html.twig')

with the global variable
$twig->addGlobal("session", $_SESSION);

Just found after +6 hours :+1: sorry gonna close this and by the way why don't you propose other solution than change root ? :)

Finally not solved ... I take my day to search..

Hi,
where are you calling session_start()? You need to call this in every request, so I would recommend calling it in the front controller.
(Your method for adding the session to Twig is what I would do though, and should work)

Thanks for pointing out !
I currently use a function that use the following before starting the session and I noticed that the session name has invalid characters.
session_set_cookie_params()
session_name($sessionName);

Thanks again and I wish you a great day/night.

No problem, glad you got it working.


fix assertions taking std::ostream

Without this const, REQUIRE(a_function_returns_ostream_ref) won't compile.

Hi! I merged it in the dev branch - from the command line - master branch is only for releases.
So if you need this change - the dev branch has it.
1.1 or 1.0.1 is coming in a few days - then this will get into master.
Thanks! I will update the Contributing section on the main readme soon.


use pkg-config to find evhtp

ellzey/libevhtp#166 (released in 1.2.11) installs a pkgconfig file in the right place which can be used to pull in headers and libs appropriately.
I found this useful when trying to build on Nixos.  Haven't yet tested in other environments but happy to test ubuntu at least.

ACK on the CLA. Will get back to you.

This breaks our continuous build, so it's unlikely that we'd accept it in this form...
Two options:

have the call to configure (in build/configure-ct) include the necessary evhtp_CFLAGS and evhtp_LIBS
update to the newer version of libevhtp

I think I worked out why the build was failing, and have updated the branch which (hopefully) should resolve the build errors.

Hmm. You seem to have broken the CLA checking.

maybe it can't cope with force pushes? I can close this and open another PR if that would help?

I think you might have changed the email address you were using in the commits?

We have forced many pushes in the past, I'm sure it can deal with those. :smiley:

@pphaneuf yeah I think the email address is probably it. I'll update my user.email setting for this repo for future.

You can fix this in a few ways... First, I think you can add additional email addresses to your CLA signature?
Alternatively, you could squash your commits into a single commit, make sure your user.email setting is correct, and do git commit --amend -C HEAD --reset-author. This will, well, reset the author in the commit. :smiley:

I used git filter-branch to rewrite the commits in the end.

Would it be possible to have this without upgrading evhtp? As in, modify the configure-ct script to add the evhtp_CFLAGS and evhtp_LIBS flags?

On Thu, 19 Nov 2015 at 19:48 Philip Potter<EMAIL_ADDRESS>wrote:

I used git filter-branch to rewrite the commits in the end.

A corner of git-land I have not explored!

@pphaneuf I'm not sure I fully understand but I've opened #1062 to do what I think you're asking for? :)

Now that #1062 has been merged, I've updated this PR.  It's much simpler now :)

I like simple a lot. :smiley:
Not sure if we'll merge that in immediately, I'd like to look at the changes in evhtp a bit first, but at least, anyone can build with what they want, easily (so you shouldn't be blocked).
Thanks!

agree, happy for this to sit for a while. :+1:


ja: Make docs/concepts/configuration/manage-resources-containers.md follow v1.19 of the original text

This is a Feature Request

What would you like to be added
Update docs/concepts/configuration/manage-resources-containers.md to follow v1.19 of the original (English) text.
Why is this needed
content/ja/docs/concepts/configuration/manage-resources-containers.md is outdated.
Comments
/language ja
/good-first-issue
File to update
https://github.com/kubernetes/website/tree/dev-1.19-ja.1/content/ja/docs/concepts/configuration/manage-resources-containers.md
Original
https://github.com/kubernetes/website/tree/release-1.19/content/en/docs/concepts/configuration/manage-resources-containers.md
diff between translated and v1.19
https://gist.github.com/28a61aa8f76160f41353d88fd3e922dc
Note
Currently, we use dev-1.19-ja.1 branch. Please open a PR targeting the branch.
ref
https://kubernetes.io/ja/docs/contribute/localization/
If you have a question, feel free to ask us at slack.k8s.io #kubernetes-docs-ja channel.

/triage accepted

/assign

/close


Replace DividerLine and Hairline by component from SR

Closes #2098
Now we use the Divider component from SR Storybook. It will replace FormDivisor, Hairline (with old arrowDown icon) and DividerLine components.
Reference (<Divider withArrow />):

Old Hairline (with icon):

Advanced Option Header: the Divider add more margin and makes the header and footer taller.

Where to test/QA?

[ ] Send funds (from address book) - replace Divider
[ ] Send funds - Review (from address book) - replace Divider
[ ] Send collectible (from address book) - replace Divider
[ ] Send collectible - Review (from address book) - replace Divider
[ ] Contract interaction (from address book) - replace Divider
[ ] Contract interaction Review (from address book) - replace Divider

[x] Send funds (from address book) - replace Divider
[x] Send funds - Review (from address book) - replace Divider
[x] Send collectible (from address book) - replace Divider
[x] Send collectible - Review (from address book) - replace Divider
[x] Contract interaction (from address book) - replace Divider

This one seems not to have the same divider as the others. Still, it looks the same as the dev environment and it doesn't look broken in any way. So if there is nothing else to it then It also pass
"Contract interaction Review (from address book) - replace Divider"

@francovenica its ok as it is:
https://app.zeplin.io/project/5b83b4fa75f90943c86ed14f/screen/5f5b856e28d3076c26881cfd
I think we can remove the chekbox for Contract interaction on review step :)


[BUG] Dynamic video remove doesn't change the numbers of videos left in playlist

When dynamically 'removing' the videos from the playlist (wihout reload), the number of videos in the playlist remain unchanged on the left of the interface.
The dynnamic 'remove' should also change this value on the interface.

:tada: This issue has been resolved in version 1.4.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


drivers: sdhc: Why does sdhc_spi_request not spi_release() on error?

Describe the bug
Suspected bug: sdhc_spi_request() calls spi_release() at its end.
However, if it returns an error, the function does not release the SPI.
Expected behavior
The current behaviour assumes that on an error, other parts of the SPI would have either not locked SPI, or properly release the SPI on errors.  Instead, would it not be more robust to release the SPI when the sdhc_spi_request exists, regardless of error?
Context
I work with Nordic Semiconductor DevZone, and a user asked me about this over there. Private ticket so I can not link it here.

Thanks for highlighting this, linked PR should fix the issue


No mouse movement in Genshin Impact

RetanoProx
No mouse movement in Genshin Impact. Launch as administrator.

Full discussion here: https://github.com/kuroni/bongocat-osu/issues/152
This is likely due to Bongocat using the absolute position of the mouse to determine where to place the mouse. To fix this issue I'd have to implement relative mouse positioning. I may add relative mouse positioning in the future, stay tuned.

An exciting PR that fixes this issue for Windows: bongocat-osu/pull/196


_containers.tpl updates

indents nested conditions/variables for easier reading of file
regenerates tests which also removes unnecessary new lines
fixes compare versions script by appending correct file suffix

I'm going to rebase this onto my branch and review it there, probably rewriting history into the existing commits and force pushing the resulting bag of commits.


refactor to real private class fields

Switch to using # instead?
https://github.com/kenchris/urlpattern-polyfill/blob/ed3c72963fc5fcf55741ea9390c64071f7f8ad44/src/url-pattern-list.ts#L6

@jimmywarting At this time the private field declarations are not available in all implementations we want to support. While we use TS, we want to keep as close as possible to JS, to keep the polyfill as small as possible

You can still use private class fields in ts and set a lower target version when you compile your src to js

@jimmywarting I know, but this does add quite a few lines of code to the polyfill, with a very small payoff.
In my opinion, that's not worth it.
@kenchris, what's your opinion?

I agree that it is not worth it for now, but we can reevaluate at a later point

I added the label won't fix it for now and will close this.
If there is a reevaluation about this in the future, we will gladly reopen it!


support for data migration of incremental snaps on xen

Description
PR attempts to fix and enhance the following:

On Xen, there are instances when the child snapshot is basically only a database entry with the file path pointing to the parent snapshot - handle this scenario such that a new entry is created for such incremental snapshots and delete the snapshot from source datastore during data migration
Wrt scaling down of SSVM, revised the logic to prevent quick scaling down of the SSVMs

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[X] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):
How Has This Been Tested?

Conducted tests on xen of files
Tests on xen for snapshots with child snaps having install path same as that as parent snapshot

Before Migration:
-----------------------

MariaDB [cloud]> select * from snapshot_store_ref where store_role = 'Image' and volume_id =11 and state <> 'Destroyed' order by parent_snapshot_id\G
*************************** 1. row ***************************
                id: 497
          store_id: 1
       snapshot_id: 63
           created: 2020-10-10 07:00:08
      last_updated: NULL
            job_id: NULL
        store_role: Image
              size: 52428800
     physical_size: 52531712
parent_snapshot_id: 0
      install_path: snapshots/2/11/d05a2c2f-6885-4932-b5a0-d11f82129a48.vhd
             state: Ready
      update_count: 2
           ref_cnt: 0
           updated: 2020-10-10 13:25:24
         volume_id: 11
*************************** 2. row ***************************
                id: 375
          store_id: 1
       snapshot_id: 67
           created: 2020-10-10 07:00:09
      last_updated: NULL
            job_id: NULL
        store_role: Image
              size: 52428800
     physical_size: 0
parent_snapshot_id: 63
      install_path: snapshots/2/11/d05a2c2f-6885-4932-b5a0-d11f82129a48.vhd
             state: Ready
      update_count: 2
           ref_cnt: 0
           updated: 2020-10-08 06:54:57
         volume_id: 11
*************************** 3. row ***************************
                id: 381
          store_id: 1
       snapshot_id: 70
           created: 2020-10-10 07:00:11
      last_updated: NULL
            job_id: NULL
        store_role: Image
              size: 52428800
     physical_size: 0
parent_snapshot_id: 67
      install_path: snapshots/2/11/d05a2c2f-6885-4932-b5a0-d11f82129a48.vhd
             state: Ready
      update_count: 2
           ref_cnt: 0
           updated: 2020-10-08 06:55:14
         volume_id: 11
*************************** 4. row ***************************
                id: 472
          store_id: 1
       snapshot_id: 74
           created: 2020-10-10 07:32:57
      last_updated: NULL
            job_id: NULL
        store_role: Image
              size: 52428800
     physical_size: 0
parent_snapshot_id: 70
      install_path: snapshots/2/11/d05a2c2f-6885-4932-b5a0-d11f82129a48.vhd
             state: Ready
      update_count: 2
           ref_cnt: 0
           updated: 2020-10-10 07:32:57
         volume_id: 11

After migration:
---------------

MariaDB [cloud]> select * from snapshot_store_ref where store_role = 'Image' and volume_id =11 and state <> 'Destroyed' order by parent_snapshot_id\G
*************************** 1. row ***************************
                id: 510
          store_id: 5
       snapshot_id: 63
           created: 2020-10-10 07:00:08
      last_updated: NULL
            job_id: NULL
        store_role: Image
              size: 52428800
     physical_size: 52531712
parent_snapshot_id: 0
      install_path: snapshots/2/11/d05a2c2f-6885-4932-b5a0-d11f82129a48.vhd
             state: Ready
      update_count: 2
           ref_cnt: 0
           updated: 2020-10-12 04:11:10
         volume_id: 11
*************************** 2. row ***************************
                id: 375
          store_id: 5
       snapshot_id: 67
           created: 2020-10-10 07:00:09
      last_updated: NULL
            job_id: NULL
        store_role: Image
              size: 52428800
     physical_size: 0
parent_snapshot_id: 63
      install_path: snapshots/2/11/d05a2c2f-6885-4932-b5a0-d11f82129a48.vhd
             state: Ready
      update_count: 2
           ref_cnt: 0
           updated: 2020-10-08 06:54:57
         volume_id: 11
*************************** 3. row ***************************
                id: 381
          store_id: 5
       snapshot_id: 70
           created: 2020-10-10 07:00:11
      last_updated: NULL
            job_id: NULL
        store_role: Image
              size: 52428800
     physical_size: 0
parent_snapshot_id: 67
      install_path: snapshots/2/11/d05a2c2f-6885-4932-b5a0-d11f82129a48.vhd
             state: Ready
      update_count: 2
           ref_cnt: 0
           updated: 2020-10-08 06:55:14
         volume_id: 11
*************************** 4. row ***************************
                id: 472
          store_id: 5
       snapshot_id: 74
           created: 2020-10-10 07:32:57
      last_updated: NULL
            job_id: NULL
        store_role: Image
              size: 52428800
     physical_size: 0
parent_snapshot_id: 70
      install_path: snapshots/2/11/d05a2c2f-6885-4932-b5a0-d11f82129a48.vhd
             state: Ready
      update_count: 2
           ref_cnt: 0
           updated: 2020-10-10 07:32:57
         volume_id: 11

Tested on xen, vmware and KVM
Tests for SSVM scale down:
Updated following global setting values:
secstorage.capacity.standby: 4
secstorage.session.max: 10

Added 7 entries to the cmd_exec_log table, to simulate scaling up operation - Successfully scaled - the new SSVM spawned continues to exist until the number of cmds drops below threshold
Deleted entries from cmd_exec_log table, such that only 4 entries were present in the table - successfully triggered scale down - as the total number of cmds in the table has dropped below half the defined max limit (10/2 = 5)
Simulated another scale up operation by adding entries to the cmd_exec log table, added entries to the second (new) SSVM however the total number of commands in the table is below threshold - does NOT scale down SSVM as a command is running on it - as expected

@blueorangutan package

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2156

@blueorangutan test matrix

@Pearl1594 a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware67, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

cc @vladimirpetrov @PaulAngus

Trillian test result (tid-2924)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35291 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4395-t2924-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Smoke tests completed. 85 look OK, 0 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-2922)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37494 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4395-t2922-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 84 look OK, 1 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_scale_vm
Failure
10.42
test_scale_vm.py

Trillian test result (tid-2923)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38523 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4395-t2923-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Failure
304.20
test_vpc_redundant.py

test_hostha_kvm_host_fencing
Error
99.43
test_hostha_kvm.py

@blueorangutan centos7 kvm-centos7 keepEnv

@blueorangutan centos7 xenserver-71 keepEnv

@blueorangutan centos7 xenserver-71 keepEnv

Tests LGTM

@blueorangutan centos7 xenserver-71 keepEnv

Code changes LGTM

@blueorangutan package

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2191

@blueorangutan package

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2192

@blueorangutan test

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2977)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36707 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4395-t2977-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 2 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL
Failure
312.21
test_vpc_redundant.py

test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers
Failure
293.38
test_vpc_redundant.py

test_hostha_kvm_host_fencing
Error
166.69
test_hostha_kvm.py


Error when  I run the Train_NER_German.py

Hi, @nreimers
when  I run the Train_NER_German.py, I got the following error. Please have a look at the issue. Thanks.
`Using Theano backend.
Using gpu device 1: GeForce GTX TITAN X (CNMeM is enabled with initial size: 40.0% of memory, cuDNN 6021)
Using existent pickle file: pkl/GermEval_2014_tudarmstadt_german_50mincount.vocab.pkl
Dataset: GermEval
['NER_IOBES', 'NER_IOB', 'NER_BIO', 'tokens', 'casing', 'characters', 'NER_class']
Label key:  NER_BIO
Train Sentences: 24000
Dev Sentences: 2200
Test Sentences: 5100
BiLSTM model initialized with parameters: {'clipnorm': 1, 'optimizer': 'nadam', 'dropout': [0.25, 0.25], 'miniBatchSize': 32, 'earlyStopping': 5, 'addFeatureDimensions': 10, 'charFilterLength': 3, 'charLSTMSize': 25, 'charFilterSize': 30, 'classifier': 'CRF', 'clipvalue': 0, 'charEmbeddingsSize': 30, 'charEmbeddings': None, 'LSTM-Size': [100, 75]}
24000 train sentences
2200 dev sentences
5100 test sentences
--------- Epoch 1 -----------
Traceback (most recent call last):
File "Train_NER_German.py", line 86, in
model.evaluate(50)
File "/home/xidb/Desktop/tf/emnlp2017-bilstm-cnn-crf/neuralnets/BiLSTM.py", line 392, in evaluate
self.trainModel()
File "/home/xidb/Desktop/tf/emnlp2017-bilstm-cnn-crf/neuralnets/BiLSTM.py", line 93, in trainModel
self.buildModel()
File "/home/xidb/Desktop/tf/emnlp2017-bilstm-cnn-crf/neuralnets/BiLSTM.py", line 247, in buildModel
tokens.add(Embedding(input_dim=embeddings.shape[0], output_dim=embeddings.shape[1],  weights=[embeddings], trainable=False, name='token_emd'))
File "/home/xidb/anaconda2/lib/python2.7/site-packages/keras/models.py", line 294, in add
layer.create_input_layer(batch_input_shape, input_dtype)
File "/home/xidb/anaconda2/lib/python2.7/site-packages/keras/engine/topology.py", line 398, in create_input_layer
self(x)
File "/home/xidb/anaconda2/lib/python2.7/site-packages/keras/engine/topology.py", line 543, in call
self.build(input_shapes[0])
File "/home/xidb/anaconda2/lib/python2.7/site-packages/keras/layers/embeddings.py", line 101, in build
self.set_weights(self.initial_weights)
File "/home/xidb/anaconda2/lib/python2.7/site-packages/keras/engine/topology.py", line 966, in set_weights
str(weights)[:50] + '...')
ValueError: You called set_weights(weights) on layer "token_emd" with a  weight list of length 1, but the layer was expecting 0 weights. Provided weights: [array([[ 0.        ,  0.        ,  0.        , .....
`

when  I change the version of keras, it worked.


Add a way to subscribe to getters

What problem is this solving
With the new setup syntax, we can define getters that are also setters using computed. In my case, I'd like to use computed getter/setters to have state values that can start undefined but cannot be accessed until they are defined, like so
const useExampleStore = defineStore('example', () => {
  const internal_exValue = ref(1)

  const exValue = computed({
    get: () => {
      if (internal_exValue.value === undefined) {
        throw new Error('Cannot access exValue before it is defined.')
      } else {
        return internal_exValue.value
      }
    },
    set: (newValue: number) => {
      internal_exValue.value = newValue
    },
  })

  return { exValue }
})

I'd like to not expose internal_exValue because it shouldn't ever be used.
The problem comes if I want to be able to subscribe to the state. exampleStore.$subscribe won't work because technically nothing is in the state!
Proposed solution
Add a method like $subscribe or $onAction that allows us to subscribe to getters.
Describe alternatives you've considered
I've written a plugin that uses vue's watch on my getter to detect changes, but it feels like a hack.

You have to return all the state. This is what allows pinia to pick it up and handle the SSR


Faceting E2E Testing

The table that we are going to use for e2e testing must at least the following,

Columns of different supported types (longtext, markdown, text, shorttext, int, float, date, system columns and timestamp).
Inbound foreignkeys.
Outbound foreignkeys.
Association relationship.

We should be able to use the same schema and table definitions that we are going to use in ermrestjs unit testing. The different scenarios for testing are:
Entity Facet (filter based on key):

Displaynames must be the rowname of table. Values must be the key column.
Search box must be available.
Clicking on "show more" should open entity picker.
Should be able to handle having preselected rows and then clicking on "show more".
In the modal

Scalar Choice Facet (entity false and text, shorttext, markdown, longtext):

Displaynames should be the column values.
Search box must be available.
Clicking on "show more" should open entity picker.
Should be able to sort based on value.
Same test cases for entity modal picker.
Make sure we're treating markdown correctly (returning HTML)

Scalar Range Facet (int, float, date, timestamptz):

no values displayed by default
range inputs visible (min and max)

date and time for timestamp[tz]

validators for each type (numeric, date, datetime)
submit scenarios:

min and max
only min
only max

handle pre-defined range that shows up in facet when page loads

Search Box:

adding chiclet based on search phrase
chiclet added when search is part of the URI
remove chiclet (removes search)
x in search removes chiclet too
new search replaces previous search in chiclet

Misc:

Go through the scenario of choosing multiple facets together and check the result. The previous cases must be done one at a time and independently from other facets.
We should also test doing the sequence of the previous scenario simultaneously and making sure that we are never showing stale data (when spinner disappears the data must be the latest data)
Clear all: all facts should have their values unchecked, range picker unchecked without removing value

Flow Control:
We might need unit testing for this, but we can leave it for later.

I have created a schema that we can use for testing. You can find it under faceting-test branch in ermrestjs. I summarized the data structure in this document.


Embedded struct support

This relates to https://github.com/kelseyhightower/envconfig/pull/12, but breaks out just the embedded struct support.

@kelseyhightower Would you please review this PR when you find a few minutes?

+1

@teepark Can I get your thoughts on this?

LGTM

Awesome @kelseyhightower. This is great, I was actually thinking we can broaden this and handle the general case of nested structs (embedded and otherwise).
You had commented on #12 about preferring struct tags to naming conventions, but what about this: given that we already decode PREFIX_FIELD into config.Field via the existing naming convention, it doesn't seem like a stretch to decode PREFIX_FIELD_INNER into config.Field.Inner. A user could still use an envconfig:"name" tag on an inner field and circumvent the whole convention.
Thoughts? I may not be able to write up the code for that right away, but I'll create an issue if you're on board.

niceeee

👍


Get backends and their supported computations

Addresses #684, in part. get_backends returns a dictionary mapping the backend package to its version, while get_compute_support is a dictionary mapping an Expr to its supported backends.
I didn't get too far into things because I had a couple of questions:

Is this still wanted?
What backends should collections.Iterator and ChunkIterator be?
What kind of interface should this functionality have?

Hope this helps.

Closing this PR due to time lag.  @alanhdu if you wish to pick this up again, please indicate so.


json script structure was changed.

#33
I checked json structure of script. It is changed. Please test it, too. The board downloading works now.

Can confirm this fixes all the errors I was getting, though your diff is like 99% whitespace changes


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

I've signed CLA

Thanks! It was great experience!


Add helper functions for vit

Differential Revision: D43932695

Codecov Report
Patch coverage: 50.00% and project coverage change: -0.01 :warning:

Comparison is base (8022789) 64.58% compared to head (fccca26) 64.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   64.58%   64.57%   -0.01%
==========================================
  Files         146      146
  Lines        9835     9838       +3
==========================================
+ Hits         6352     6353       +1
- Misses       3483     3485       +2

Impacted Files
Coverage Δ

tests/test_utils.py
76.25% <50.00%> (-1.68%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


undefined method `empty?' for nil:NilClass

See exception on errbit - https://errbit.freeukgen.org.uk/apps/5b63313de937903f2020c67f/problems/5b73f57de9379056f2d2e6de

Completed & to be deployed this sprint.


example_scaling_scalar + gcc 6.3.1 :: compilation crash (gcc RSS>10 GiB)

80cd657 master, Fedora 25, gcc 6.3.1
-DTARGET_ARCHITECTURE=auto -DBUILD_TESTING=0 -DVc_IMPL=auto -DBUILD_EXAMPLES=1
CPU i5-3570
the compilation crash with :
[ 70%] Building CXX object examples/scaling/CMakeFiles/example_scaling_scalar.dir/main.cpp.o
c++: internal compiler error: Killed (program cc1plus)
Machine have 16 Gb RAM and the gcc process is killed when has 10+ GB RSS
Switching off examples remove the problem.
Thank you.

Thanks for the report. I have seen compilation issues with this example before. This is really annoying, sorry. I'll see what I can do. But I'll probably just disable the target for GCC6.


Commented out code that can be cleaned up

https://github.com/Lambda-School-Labs/story-squad-ds/blob/fd1cc9226b1eabc2ded103afea1f204494ded1de/dotPy/matchmaking.py#L44

OBE


Retrieving OpenID-Configuration endpoint fails over SSL

I've tried to replicate in numerous other ways (outside of IdentityServer) to isolate issue but cannot recreate it.
I have a .Net Core Application that has both IdentityServer4 and IdentityServer4.AccessTokenValidation applied to it.  The access token validation middleware is used to lock down additional endpoints that I have written myself outside of IdentityServer4 itself.
The token validation apparently calls the .well-known/openid-configuration endpoint to get the discovery document, and this works when I run under HTTP alone.  However, if I try to run my service under HTTPS, for some reason the call to get the discovery document fails.
I can retrieve this discovery document just fine from other services, Postman, and Chrome.  The SSL cert is trusted, and in my Trusted Root Certification Authorities store, so the problem is not there.
It SEEMS to be something related to my service calling itself for the discovery document.  But when I simplify this in a test app that calls itself (in the same way), without all the IS4 dependencies, it works fine.
Any thoughts on why there might be an issue with IS4 and IS4.AccessTokenValidation running in the same app being that it must call itself??
The two most inner errors say: "System.Security.Authentication.AuthenticationException: A call to SSPI failed, see inner exception." and then  "The client and server cannot communicate, because they do not possess a common algorithm."

Is that on Azure?

Hi Dominick...    no, this is all running locally, but it happens on deployed server running behind IIS as well.  In both cases, it's hosted using Kestrel.
I'm going to try put together a small example using your starter "Samples", and if I can replicate with a small project, I'll post to Github for better review.
I'm wondering if it's Kestrel somehow, but I don't understand why I can call the same discovery document from anything outside the service in question and it works fine (it's just the calling of itself that seems to fail).

Here you go Dominick.  I was able to replicate the problem easily just using the Startup samples for IdentityServer4.
You can find solution that recreates the problem here:
https://github.com/obosha/IdentityServer4
Let me know if you have questions.

Further note, this appears to only happen when targeting NET452.  When I run the project as .NetCoreApp, it works fine.
So there must be some conditional code somewhere in the chain of libraries that behaves differently.  Trying to figure out which...    ugh.

I verified that this is in fact a bug today.  Took me about 8 hours to track down the problem.  Very frustrating day!   :)
I created a pull request with a proposed solution if you're happy with it.
Essentially the problem is that when targeting 452, HttpClient doesn't support the latest TLS algorithms by default, and so you need to add a line of code to "force" it to do so.  Without this line of code, it will fail to connect to hosts that are enforcing the later versions of TLS in play today.
Depending on what framework is targeted when deploying IdentityServer4.AccessTokenValidation, it can fall prey to this problem when using NET452.

Will this also work with older servers - like 2012 R2?

..and thanks for researching this?

This is a .Net Framework configuration reality in 4.5, so I'm not sure why OS (e.g. 2012 R2) would have anything to do with it per se.
In the end, and as Dominick noted on the side to me, having the user set the global configuration is likely the preferred approach and thus doesn't belong in this middleware.
My minimal suggestion is that a more specific error message (warning or error) is considered for this problem to help users isolate it much quicker.  But other than that, this was just a learning experience.  :)

Here are the current docs. Could you please add some text about the error behavior and how to fix it to that. We will soon expand this single page into a whole section about access token validation. But this would be a start.
thanks!

When you say, "here are the current docs", what were you referring to??  Am I missing a link or something?

sorry
https://identityserver4.readthedocs.io/en/release/configuration/apis.html

Thank you.  I have updated the documentation and submitted a pull request.
On Wed, Feb 8, 2017 at 12:00 AM, Dominick Baier<EMAIL_ADDRESS>wrote:

sorry
https://identityserver4.readthedocs.io/en/release/configuration/apis.html
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/IdentityServer/IdentityServer4.AccessTokenValidation/issues/48#issuecomment-278237097,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKFluvZ3e_81k9V4EhnpY2Ci0oy-xZXuks5raVoWgaJpZM4L0mIY
.


SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) + SCRAM-SHA-512(-PLUS) + SCRAM-SHA3-512(-PLUS) supports

Dear @memcached team,
In first, I wish you a Happy New Year!
A big part is in:

https://github.com/couchbase/memcached/tree/master/cbsasl
https://github.com/couchbase/memcached/search?o=asc&q=scram&s=committer-date&type=commits

Can you add supports of :

SCRAM-SHA-1
SCRAM-SHA-1-PLUS
SCRAM-SHA-256
SCRAM-SHA-256-PLUS
SCRAM-SHA-512
SCRAM-SHA-512-PLUS
SCRAM-SHA3-512
SCRAM-SHA3-512-PLUS

You can add too:

SCRAM-SHA-224
SCRAM-SHA-224-PLUS
SCRAM-SHA-384
SCRAM-SHA-384-PLUS

"When using the SASL SCRAM mechanism, the SCRAM-SHA-256-PLUS variant SHOULD be preferred over the SCRAM-SHA-256 variant, and SHA-256 variants [RFC7677] SHOULD be preferred over SHA-1 variants [RFC5802]".

SCRAM-SHA-1(-PLUS):
-- https://tools.ietf.org/html/rfc5802
-- https://tools.ietf.org/html/rfc6120

SCRAM-SHA-256(-PLUS):
-- https://tools.ietf.org/html/rfc7677 since 2015-11-02
-- https://tools.ietf.org/html/rfc8600 since 2019-06-21: https://mailarchive.ietf.org/arch/msg/ietf-announce/suJMmeMhuAOmGn_PJYgX5Vm8lNA

SCRAM-SHA-512(-PLUS):
-- https://tools.ietf.org/html/draft-melnikov-scram-sha-512

SCRAM-SHA3-512(-PLUS):
-- https://tools.ietf.org/html/draft-melnikov-scram-sha3-512

https://xmpp.org/extensions/inbox/hash-recommendations.html
-PLUS variants:

RFC5056: On the Use of Channel Bindings to Secure Channels: https://tools.ietf.org/html/rfc5056
RFC5929: Channel Bindings for TLS: https://tools.ietf.org/html/rfc5929
Channel-Binding Types: https://www.iana.org/assignments/channel-binding-types/channel-binding-types.xhtml
Channel Bindings for SCRAM over TLS 1.3: https://tools.ietf.org/html/draft-whited-tls-channel-bindings-for-tls13 -> https://tools.ietf.org/html/draft-ietf-kitten-tls-channel-bindings-for-tls13

IMAP:

RFC9051: Internet Message Access Protocol (IMAP) - Version 4rev2: https://tools.ietf.org/html/rfc9051

LDAP:

RFC5803: Lightweight Directory Access Protocol (LDAP) Schema for Storing Salted: Challenge Response Authentication Mechanism (SCRAM) Secrets: https://tools.ietf.org/html/rfc5803

HTTP:

RFC7804: Salted Challenge Response HTTP Authentication Mechanism: https://tools.ietf.org/html/rfc7804

2FA:

Extensions to Salted Challenge Response (SCRAM) for 2 factor authentication: https://tools.ietf.org/html/draft-melnikov-scram-2fa

IANA:

Simple Authentication and Security Layer (SASL) Mechanisms: https://www.iana.org/assignments/sasl-mechanisms/sasl-mechanisms.xhtml

Linked to:

https://github.com/scram-xmpp/info/issues/1

Hey,
Thanks for the notes!
I'll have to give this some thought. I've been working toward deprecating the binary protocol, which is our only usage of SASL. text is wrapped with TLS with an optional plaintext token authentication. End users getting SASL to work has been a long standing struggle that other systems (ie; redis) simply sidestepped seemingly successfully.

@dormando What is the preferred way to authenticate to a memcached process?

@madolson Nobody seems to ask for it. There's cert auth support in TLS mode and in text mode there's an extra token based auth (see doc/protocol.txt). SASL was only ever used in the binary protocol and users struggled with it so much I was never motivated to improve it. I think couchbase's had quickly written their own sasl server libs to simplify things, which defeated the purpose since it was supposed to allow users to have pluggable authentication backends.
So it's not clear anyone ever used it for its intended purpose, and if anyone had I've never heard about it :(

About Couchbase and memcached, it is specified "Memcached work planned for contribution back to memcached/memcached"
Note: There are a lot of libs/softs which use already SCRAM since a long time...
I have done a big list in "State of Play"...

That work is not being contributed back. Couchbase is its own thing and has been for a decade? They had a large rewrite that we didn't end up taking and their code was incompatible since then.
SCRAM seems perfectly fine; the problem is end user requests (haven't heard of any), consequently sponsorship (I have no motivation to do this myself unless a client pays for it, as my time's already blocked out for months), and that the text protocol doesn't use SASL anywhere (primary protocol now)


Cjs support

I have checked tsup config and it doesn't include cjs format.
Is there any reason why it does not support cjs ?
Why do I ask about this? so, I have an old UI lib project that still uses cjs and I have to modified this package on my local to work.
I could do a PR about this if it is needed.

Since my projects are mostly based on ESM, my focus has not been on CJS so far. Would love a PR for it!


Importing "C" with CGO disabled should be an error

go version go1.5.1 linux/amd64
Building with CGO_ENABLED=0 silently skips source files that have import "C", leading to incomprehensible error messages from other source files that depend on it.
There should be an error, like:
source.go:10: import "C" failed because CGO is disabled

cmd/go is a little difficult to diagnose this problem
because when cgo is disabled, go/build will not
report any CgoFiles in struct Package (the files
that need cgo will be in the IgnoredGoFiles slice.)

@minux, could we augment go/build to set a field, NeedsCGO, or HasCGO, or
something inside the build.Package structure to detect this ?
On Wed, Oct 7, 2015 at 4:16 AM, Minux Ma<EMAIL_ADDRESS>wrote:

cmd/go is a little difficult to diagnose this problem
because when cgo is disabled, go/build will not
report any CgoFiles in struct Package (the files
that need cgo will be in the IgnoredGoFiles slice.)
—
Reply to this email directly or view it on GitHub
https://github.com/golang/go/issues/12860#issuecomment-146110572.

I'm worrying about compatibility with the old behavior.
Essentially each file importing "C" used to have an implicit cgo build tag,
is there any packages out there that uses this hidden feature?
I guess we can provide a hint if the package  fails to compile with cgo
disabled.
But what if a client of the package fails to compile due to lack of cgo
support in this package?

What if the user is providing a non-cgo implementation as well?
// +build !cgo

package main

import "fmt"

func main() {
	fmt.Println("hello")
}

// +build cgo

package main

import "fmt"
import "C"

func main() {
	fmt.Println("hello")
}

We shouldn't fail this package just because it is importing C. In Go, build is constrained to the matching files for the given context. We can improve the current "no buildable Go source files" error message but anything too smart will break the existing use cases.

When there are no build directives in any Go source files, this should imply that all sources should be used on all platforms. (Except for files with platform specific names, e.g. source_windows.go)
Any Go files that import C should build always, unless it is set for cgo-only with a build directive. Without such directive, not having cgo enabled should be an error.

@pebbe I can't think of a backward-compatible way of doing that. Can you?
Whether we like it or not, import "C" is an implicit cgo build tag.
I think the solution here is for the "no buildable Go source files" to explain which files were excluded and why. For example:
can't load package: package foo: no buildable Go source files in /Users/adg/src/foo
    foo.go: no current tags match required tag 'cgo'

The problem is when there are some source files that import C, and some that don't, the latter using functions that are defined in the first. Than you get errors like:
github.com/something/something/somefile.go:10: undefined: SomeThing

People report issues because they don't understand this.
I tried adding this to Go sources that import C:
// +build cgo,!cgo

That doesn't work.
My current solution is to add an empty C file and at least one Go file that doesn't import C.
Perhaps there could be a build directive that says that it is an error if a file is not used in the build, that overrules the implicit cgo directive, like:
// +build all

What about putting // +build cgo in all the source files in the package? At least then they'll get the "no buildable source files" error, rather than confusing "undefined" errors. (That build directive is also accurate; you don't want that file to build without cgo enabled.)

My current solution is to add an empty C file and at least one Go file that doesn't import C.

How does that solve anything? I thought you already had Go files that don't import C in that package.

There are two cases. Packages where some Go source files import C, and packages where all Go files import C. Without cgo, in the first case you get the "no buildable source files", and in the second the "undefined" errors. Both are confusing. They don't tell what the real problem is.
In the second case, I only add an empty C file. This results in the error "C source files not allowed when not using cgo or SWIG".
For this to work in the first case, you have to add an empty Go file as well, one that doesn't import C.


osd: Fix number of OSD calculation

If some OSDs are to be created and others already exist the calculation
only counted the to be created OSDs. This changes the calculation to
take all OSDs into account.
Signed-off-by: Gaudenz Steinlin<EMAIL_ADDRESS>

jenkins test centos-container-purge

jenkins test centos-non_container-switch_to_containers


get the correct cell to focus on

This PR addresses issue in  #18274

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.007%) to 48.285%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/book/bookTrustManager.ts
2
96.43%

Totals

Change from base Build<PHONE_NUMBER>:
-0.007%

Covered Lines:
14819

Relevant Lines:
29135

💛  - Coveralls

closing this as this no longer valid and have a separate PR to address the issue.


MTU misconfiguration: encap mode in Kind cluster

Describe the bug
I was trying to do a basic iperf3 TCP test between 2 Pods on different Nodes in a Kind cluster.

On the server Pod, run iperf3 -s
On the client Pod, run iperf3 -c <IP of server Pod>
Expected
Bandwidth should be around 20Gbps, as observed with another CNI plugin. (Node-to-Node bandwidth is around 40Gbps).
Actual behavior
Reported bandwidth goes down to 0 almost immediately.
Versions:
I am using the following:

Docker Desktop 4.25.2 on mac
kind v0.20.0 go1.20.4 darwin/amd64
Antrea v1.15.0 (also tested with Antrea v1.14.1 and v1.13.0, with the same observation)

Additional context
After realizing that the issue didn't happen when querying a default nginx server with curl, and after confirming that this was not a checksum issue, I realized that it was actually another MTU issue.
On the Node:
abasSMD6R:~ abas$ docker exec -ti kind-worker ip addr
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: tunl0@NONE: <NOARP> mtu 1480 qdisc noop state DOWN group default qlen 1000
    link/ipip <IP_ADDRESS> brd <IP_ADDRESS>
3: ip6tnl0@NONE: <NOARP> mtu 1452 qdisc noop state DOWN group default qlen 1000
    link/tunnel6 :: brd :: permaddr 3e10:22a2:5566::
4: ovs-system: <BROADCAST,MULTICAST> mtu 1500 qdisc noop state DOWN group default qlen 1000
    link/ether 8e:33:8e:fd:fe:15 brd ff:ff:ff:ff:ff:ff
5: genev_sys_6081: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 65000 qdisc noqueue master ovs-system state UNKNOWN group default qlen 1000
    link/ether de:81:7f:da:bf:a6 brd ff:ff:ff:ff:ff:ff
6: antrea-gw0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 65485 qdisc noqueue state UNKNOWN group default qlen 1000
    link/ether ae:54:07:c2:88:0b brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 brd <IP_ADDRESS> scope global antrea-gw0
       valid_lft forever preferred_lft forever
7: antrea-egress0: <BROADCAST,NOARP> mtu 1500 qdisc noop state DOWN group default
    link/ether da:4d:08:d0:99:53 brd ff:ff:ff:ff:ff:ff
9: antrea-t-0471d9@if4: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 65485 qdisc noqueue master ovs-system state UP group default
    link/ether e6:34:d3:ba:8d:3f brd ff:ff:ff:ff:ff:ff link-netns cni-6ff1e4d7-0186-88e3-6f9e-6d78da2d0abd
17: eth0@if18: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 65535 qdisc noqueue state UP group default
    link/ether 02:42:ac:12:00:03 brd ff:ff:ff:ff:ff:ff link-netnsid 0
    inet <IP_ADDRESS>/16 brd <IP_ADDRESS> scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fc00:f853:ccd:e793::3/64 scope global nodad
       valid_lft forever preferred_lft forever
    inet6 fe80::42:acff:fe12:3/64 scope link
       valid_lft forever preferred_lft forever

The Kind Docker Nodes use the max MTU value of 65535 (for eth0). When Antrea sets the MTU for antrea-gw0 and Pod interfaces, we use 65535-50=65485. However, notice that the MTU of the tunnel interface (genev_sys_6081) is 65000 (I didn't check why). So my assumption is that when the iperf3 TCP send window reaches a value high enough (around 65000 bytes), the size of encapsulated packets start exceeding the MTU of the tunnel interface, and all the packets are dropped, leading to a TCP throughput of 0.
I confirmed that when installing Antrea with --set defaultMTU=60000, which forces the MTU of Pod interfaces to 60000, the TCP throughput reaches 17Gbps.
I don't know if this is a relatively know issue or not... It's probably worth investigating this a bit more, but maybe our MTU calculation logic should consider the MTU of the tunnel port?

cc @tnqn

So 2 options can be considered to fix this:

request a large enough MTU when creating the tunnel port; the MTU needs to be greater or equal than the MTU for antrea-gw0 and Pod interfaces
use the minimum of (MTU of tunnel port, MTU of transport interface) when computing the MTU of antrea-gw0 and of Pod interfaces

I tried 1 as it was my preferred option, however it is not guaranteed to succeed. In my case if I try to set the MTU to the required value (65485), I get the following error: Error: mtu greater than device maximum.. The maximum value is slightly less (65465), and it is not enough. I am not sure why 65465 is the max value, but it could be because that's the maximum payload size for the tunnel, when accounting for IPv6. In Antrea, we only subtract the extra IPv6 overhead (an extra 20B when compared to IPv4) when we know the cluster supports IPv6: https://github.com/antrea-io/antrea/blob/1fa4883206f671779990ee9d50e18709aa775759/pkg/agent/config/node_config.go#L42
While we could always apply the IPv6 overhead and make option 1 work, it seems that option 2 may be the least disruptive.
This is where OVS configures the tunnel MTU:
https://github.com/openvswitch/ovs/blob/3e666ba000b5eff58da8abb4e8c694ac3f7b08d6/lib/dpif-netlink-rtnl.c#L348-L360

I never met the issue when creating a kind cluster on Ubuntu server directly, the MTU was always 1500, guess it's related to the image of Docker Desktop 4.25.2 on mac?


[BUG] After restarting 3 nodes harvester, cluster can't come back ,also can't access harvester by VIP and any node's IP.

Describe the bug

After restarting 3 nodes harvester cluster, can't access harvester by VIP and any node's IP.
davidtclin@localhost:~/Documents/Harvester/tools/cloud_provider> ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
^C
--- <IP_ADDRESS> ping statistics ---
15 packets transmitted, 0 received, 100% packet loss, time 14333ms

davidtclin@localhost:~/Documents/Harvester/tools/cloud_provider> ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
^C
--- <IP_ADDRESS> ping statistics ---
30 packets transmitted, 0 received, 100% packet loss, time 29643ms

davidtclin@localhost:~/Documents/Harvester/tools/cloud_provider> ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
^C
--- <IP_ADDRESS> ping statistics ---
13 packets transmitted, 0 received, 100% packet loss, time 12270ms

davidtclin@localhost:~/Documents/Harvester/tools/cloud_provider> ping <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
^C^C
--- <IP_ADDRESS> ping statistics ---
21 packets transmitted, 0 received, 100% packet loss, time 20472ms

None of the node is in ready status

Node 1

Node 2

Node 3

To Reproduce
Steps to reproduce the behavior:

Prepare a 3 nodes harvester cluster
Provision RKE2 cluster from Rancher
Delete all RKE2 cluster from rancher
Click reboot on node 3 machine, wait 3 seconds
Click reboot on node 2 machine, wait 3 seconds
Click reboot on node 1 machine, wait 3 seconds
Check Harvester cluster can come back and access Web UI via VIP

Expected behavior

Harvester cluster should come back after reboot all 3 nodes harvester machine
Can access Web UI via VIP and ssh to any node's IP

Support bundle

No support bundle, since all node's IP and VIP have lost connection
Environment:

Harvester ISO version: 1.0.1-rc1
Underlying Infrastructure: 3 nodes harvester on provo bare machines

Additional context

Checked on harvester node 1, it looks like both the NIC can't get DHCPv4 lease from DHCP server on Provo environment.

Will check the DHCP connection by rebooting and reinstalling harvester cluster.

Double check the behavior on local kvm machines of the following environment.

Iso install 3 nodes harvester
iPXE example install 3 nodes harvester

Did not encounter this issue, after reboot all node machine in sequence.
I can access Harvester via VIP and connect to each node machine IP correctly.
The original issue could related to not able to connect to the DHCP server.
Thus close this issue.


Kong IP restriction plugin does not allow DNS name, only IP is allowed for it.

Is there an existing issue for this?

[X] I have searched the existing issues

Kong version ($ kong version)
Kong 2.0
Current Behavior
It allows like <IP_ADDRESS>/24 can be used.
but it does not allow "abc.com" as an entry list.
Expected Behavior
"abc.com" or its underlying IP should be allowed in the plugin.
Steps To Reproduce
Add Ip restriction from Kong UI
Try adding a restriction entry as "abc.com" (also try replacing domain with IP, would result in same)
try accessing the service from anywhere else
it allows access.

Anything else?
No response

This would be unreliable I think. Getting a conclusive list of IPs from a nameserver is very tricky. Typically answers are limited to only a few entries, and there can be several levels of indirection (CNAME -> SRV -> A -> IP).
How to deal with those?

Mentioning underlying ip in the restriction list also doesn't work. It allows calls from dns name.

@trafalgarf can you describe your real-world use case where you'd need this?
we cannot update the config dynamically (eg. resolve the name and store the IP's in the plugin config). So the only way would be to do this on a dataplane. But then if there is a nameserver that returns a random set of 3 IPs from the available ones (eg. a name has A records, with 4 IPs and the name server only returns 3 random), Then in a Kong cluster 2 different Kong nodes will get 2 different sets of IPs to block/allow. Really hairy stuff this request.

@Tieske
We have a service which should be restricted to a specific IP access.
Now that IP is mapped to dns too.
In the plugin i can either mention the ip or dns.
So ip addition doesn't work and dns addition is not allowed.

Why doesn't it work when you add the ip?

can this be a case that the source of that service call on the IP which is in allowed IP restriction is also on the same kong ?

A long time ago I have written something like that to try to allow my home dynamic ip (using duckdns). I did not used it in production environment, I went to a authn/authz solution. Here is my old code https://github.com/carnei-ro/openresty-controller-by-dns-name/blob/master/dns.lua

Dear contributor,
We're closing this issue as there hasn't been any update to it for a long time. If the issue is still relevant in the latest version, please feel free to reopen it. We're more than happy to revisit it again.
Please have a look at our pledge to the community for more information.
Sincerely,
Kong Gateway Team


Create simple stopwatch app

Simple stopwatch application made with Angular.
The project has got a README.md file, with all the usage information.

@Fonta22 please resolve the failed check which is due to unit specified for length zero. This article here might help. Other than that all looks good!


Add Tauseef Malik

I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.

Hey Roshan,
Your tutorial was quite helpful since I am very new to contributing in open
source projects. Though I already had some knowledge about git, I was
unfamiliar with few things which your tutorial helped me cover practically!
Thanks a lot and let me know how can I contribute to your project
(features, docs) etc.
On Mon, 18 Jun 2018 at 01:14, Roshan Jossey<EMAIL_ADDRESS>wrote:

I'm quite elated about your pull request. I wanna evolve this project to
addresses various problems faced by first-time contributors. I'd love to
learn about your journey in open source community, the problems, pain
points you had etc.
Could you explain how you felt when you went through the tutorial, made a
pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app.
Could you please go to
https://roshanjossey.github.io/first-contributions/#social-share and
share your first contribution to open source? Also, check out projects with
easy issues while you’re there.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Roshanjossey/first-contributions/pull/4979#issuecomment-397901661,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AOOAe5Po0-t0jXyranCmeK95DaAGj1Bqks5t9rGEgaJpZM4Uqz30
.

--
Best Regards,
Tauseef Malik

@TauseefMalik, look through issue of this project and see if you'd like to work on anything.
I’d urge you to continue contributing to other open source projects.
We also have a slack team to help/mentor people trying to contribute to open source projects.
You can join the team by going to https://goo.gl/PM1Jdh

Thank you @Roshanjossey, Please check your email for my feedback. Also, I would be glad to help out in your project and join the slack channel


Autocomplete has -DirectMembershipOnly

But this documentation doesn't list it an option?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 439f74a1-badd-e304-55d8-1981f86c5440
Version Independent ID: e51876c4-c39d-a1b6-4624-599eb8f823d8
Content: New-DynamicDistributionGroup (exchange)
Content Source: exchange/exchange-ps/exchange/users-and-groups/New-DynamicDistributionGroup.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@officedocsbot assign @yogkumgit

Hi @arowswell, thank you for your feedback.
Could you please give me more detail about what you think is wrong with this article? Thanks!

If you load the module in PowerShell and type New-DynamicDistributionGroup -Direct then press  to autocomplete, it shows -DirectMembershipOnly as a parameter. There is no mention of this on the docs page though.

@arowswell thank you! Super clear now!
It looks like it's to avoid nested groups membership, but it doesn't work. I think it's still "under construction", I will add something to avoid confusion.
@chrisda maybe you can add something here, thanks!

@chrisda Please merge this PR #4163 , Thanks

@dariomws306  Thank you very much for the contribution and updating the documentation with PR. @arowswell Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


will_paginate support

Having will_paginate support for ActiveRestClient::ResultIterator would be great. Right now the only option is to call paginate on the @items array but if the response returned zero results, @items is nil can will cause paginate to fail. The workaround is to use
@items.try(:paginate)
but this seems less than ideal.

Done in 3388c8e


More efficient json decoding for attestations

Use json.NewDecoder..Decode.. since it works with the reader directly and hence should be less resource intensive than using io.ReadAll and then json.Marshal.
There were some minor test changes needed to make the tests pass due to the different ways it handles malformed or empty input.

Suggested by @zregvart in #975 .