Pathology Images inconsistent magnifications / zoom levels

Hi,
I have been integrating the opensead dragon library to generate a viewer for to display pathology images for my university project.
I have implemented a custom tile-server based on this: http://localhost:8083/slide/{slideId}/{level}/{x}/{y}.jpeg
To explain the issue bellow I'm going to refer to this pathology images (pyramid, tiled), which we can access using the url above. (see screen shot bellow)

width
height
level
magnification

59759
35825
5
20

29880
xxx
4
10

14940
xxx
3
5

7470,
xxx
2
2.5

3735,
xxx
1
1.25

1868,
xxx
2
0.625

and I configured a custom tile source with this.

    <script type="text/javascript">

		//contentDiv width, height 100%
        var viewer = OpenSeadragon({
            // debugMode: true,
            id: "contentDiv",
			 tileSources: {
	          	tileSize: 512,
	          	minLevel: 0,
	          	maxLevel: 5,
	          	height: 40_000,
	          	width: 60_000,
	        	getTileUrl: function (level, x, y) {
	        		return "http://localhost:8083/slide/0001/{level}/{x}/{y}.jpeg"
	        	}
		      },
            showNavigator: true
        });
    </script>

So for most of the parts the openseadragon library has been flawless, except in trying to reproduce the objectives / magnification from microscope or native viewer (provided by manufacturing scanner)
What I have observed is that if we initialize the viewer at full screen resolution which is 2560X1440 I can very closely able to reproduce magnification hence, the real world aspect of an object.
Here is an example, same config, looking at a small white blob/tissue using objective / magnification 5x on left is openseadragon, image on the right is native viewer. (They are very closelly matching but not bang on)

Now where is the interesting part, is if I initialise the opensea dragon with half of the screen size 1280x720 and I zoom in to the same area at the same objective / magnification which is 5x, they are million miles away.

We have been utilising the suggestion from #1462 (https://github.com/openseadragon/openseadragon/issues/1462) so we are using viewportToImageZoom to display current zoom, but something is not adding up.
As an observation, I have hard-coded the initial div size to be exactly the dimension of the image at 1x.
therefore the initial contentDiv width is 2988px and we can now match the exact aspect ration as the original microscope and/or native viewer.
Do you have some suggestions on what is going on here, or what we are not doing right?
Is there any additional information we need to provide the library at initialisation?
Please forgive me if i have not included enough information or too much.
Best Regards
ade

OSD zoom values are always relative to whatever size fills the width of the viewport. When the image exactly fills the viewport horizontally, that's zoom 1. When you can see only half of the image width in the viewport, that's zoom 2. This allows you to create experiences that are consistent across a wide range of devices.
Sounds like in your case, you're not as concerned about the overview, but the individual pixels. In that case, you're interested in the image zoom, not the viewport zoom. If you want to zoom to where the image is at full resolution, that's image zoom of 1. To go there, you can use:
viewer.viewport.zoomTo(viewer.viewport.imageToViewportZoom(1));

I guess I'm just repeating myself from #1462, and it sounds like you were on the right track; you were just using viewportToImageZoom when you should have used imageToViewportZoom. 😄

Hi,
Thanks for the prompt reply.
Apologies, i know your pain, i hate too repeating  :smile_cat:
After re-reading #1462 with the suggestions above it started to make proper sense.
I guess still very much confused between the zoom types (image, viewport) although even if i don't understand the need for it i assume there is a good use case of this.
Although if you are displaying an CAD data, GIS Data, Pathology data, Google Maps, where you need to interpret the virtual image to a real world dimension working with the image zoom would be the most intuitive?
Is there any pages / wikis that explain the inner working of openseadragon library.
Regards
ade

No worries :)
Unfortunately there isn't really a good overview of the inner workings. Would be a good thing to create sometime! This has some good info though:
https://openseadragon.github.io/examples/viewport-coordinates/
As for image versus viewport zoom, I guess you can think about it as the difference between "bottom up" versus "top down". You're doing scientific imaging, so you care a lot about the individual pixels, so your perspective is bottom up (image zoom). This is the same perspective that Photoshop has. You want to think about things in terms of ratios of actual pixels.
Lots of people use OpenSeadragon to display artworks or manuscripts, and they don't care about the individual pixels as much as they care about the overall piece. When the viewer opens, they want the entire artwork to appear in whatever space is available. Their perspective is top down (viewport zoom). Maybe they want to zoom the user in to a particular detail that is 25% of the overall image area. Viewport zoom allows them to do this without worrying about the resolution of the image. In fact, you can replace a low resolution image with a high resolution one, and all of the viewport zoom calculations are the same. You can say "her earring is here" in coordinates that are relative to the entire image and therefore don't change when the resolution changes.
Of course one of those perspectives has to be dominate in the library, and the choice originally made was viewport zoom, as the original Seadragon philosophy was in moving away from thinking about pixels at all... You just have an image and you can assume it has infinitely deep pixels. We're still not fully living in that world, but as our imaging technology gets better and our displays get better, we keep getting closer.
I hope that helps shed some light!

Indeed... Perhaps in the future, we could add a more direct API for the image zoom perspective.
Glad it's working! :)


测试的时候通过，训练的时候报了这个问题，也下载了最新的train.py，依然不行。python3.6

-----------Start training-----------
Epoch 1/10
Traceback (most recent call last):
File "train.py", line 169, in
callbacks = [checkpoint, earlystop, changelr, tensorboard])
File "/opt/software/anaconda3/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper
return func(*args, **kwargs)
File "/opt/software/anaconda3/lib/python3.6/site-packages/keras/engine/training.py", line 1415, in fit_generator
initial_epoch=initial_epoch)
File "/opt/software/anaconda3/lib/python3.6/site-packages/keras/engine/training_generator.py", line 177, in fit_generator
generator_output = next(output_generator)
File "/opt/software/anaconda3/lib/python3.6/site-packages/keras/utils/data_utils.py", line 793, in get
six.reraise(value.class, value, value.traceback)
File "/opt/software/anaconda3/lib/python3.6/site-packages/six.py", line 693, in reraise
raise value
File "/opt/software/anaconda3/lib/python3.6/site-packages/keras/utils/data_utils.py", line 658, in _data_generator_task
generator_output = next(self._generator)
File "train.py", line 96, in gen
x[i] = np.expand_dims(img,axis=2)
ValueError: could not broadcast input array from shape (32,256,1) into shape (32,280,1)
swig/python detected a memory leak of type 'int64_t *', no destructor foun

输入的图片大小不对，你再gen函数中增加一个resize动作吧，免得数据大小不一致跑不起来
发送自 Windows 10 版邮件应用
发件人: wjnodejs
发送时间: 2019年3月14日 16:37
收件人: YCG09/chinese_ocr
抄送: Subscribed
主题: [YCG09/chinese_ocr]=?UTF-8?Q?=E6=B5=8B=E8=AF=95=E7=9A=84=E6=97=B6=E5=80=99=E9=80=9A=E8=BF=87=EF=BC=8C=E8=AE=AD=E7=BB=83=E7=9A=84=E6=97=B6=E5=80=99=E6=8A=A5=E4=BA=86=E8=BF=99=E4=B8=AA=E9=97=AE=E9=A2=98=EF=BC=8C=E4=B9=9F=E4=B8=8B=E8=BD=BD=E4=BA=86=E6=9C=80=E6=96=B0=E7=9A=84train.py=EF=BC=8C=E4=BE=9D=E7=84=B6=E4=B8=8D=E8=A1=8C=E3=80=82python3.6?==?UTF-8?Q?=28#185=29?=
-----------Start training-----------
Epoch 1/10
Traceback (most recent call last):
File "train.py", line 169, in
callbacks = [checkpoint, earlystop, changelr, tensorboard])
File "/opt/software/anaconda3/lib/python3.6/site-packages/keras/legacy/interfaces.py", line 91, in wrapper
return func(*args, **kwargs)
File "/opt/software/anaconda3/lib/python3.6/site-packages/keras/engine/training.py", line 1415, in fit_generator
initial_epoch=initial_epoch)
File "/opt/software/anaconda3/lib/python3.6/site-packages/keras/engine/training_generator.py", line 177, in fit_generator
generator_output = next(output_generator)
File "/opt/software/anaconda3/lib/python3.6/site-packages/keras/utils/data_utils.py", line 793, in get
six.reraise(value.class, value, value.traceback)
File "/opt/software/anaconda3/lib/python3.6/site-packages/six.py", line 693, in reraise
raise value
File "/opt/software/anaconda3/lib/python3.6/site-packages/keras/utils/data_utils.py", line 658, in _data_generator_task
generator_output = next(self._generator)
File "train.py", line 96, in gen
x[i] = np.expand_dims(img,axis=2)
ValueError: could not broadcast input array from shape (32,256,1) into shape (32,280,1)
swig/python detected a memory leak of type 'int64_t *', no destructor foun
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@xiaoyubing ,你好，测试代码有吗？我看项目里面给的demo.py只有ctpn检测部分，没有densenet+ctc的识别部分的测试代码


add image to meta tags

I'll let you know when a logo link is ready and provide it to you to include in meta tags of post

I uploaded our logo to a S3 bucket.
SVG: https://kampus-logo.s3.eu-central-1.amazonaws.com/DplcC3sZ_400x400.svg
PNG: https://kampus-logo.s3.eu-central-1.amazonaws.com/DplcC3sZ_400x400.png

Favicon: https://kampus-logo.s3.eu-central-1.amazonaws.com/favicon.ico

Fixed with #178


Fully implement entire entities in shadow state

That is, entities not backed by any CLR type. Also see #748.

May I ask what is the gain of this? Does this feature exist in any ORM? I know this is going to be used for M:M mapping in EF Core, but other that that, I honestly can't see the point. Thanks! :-)

@rjperes In general we use shadow sate to reduce the coupling between the domain model the application reasons about and the extra information EF Core might need to track and reason about. This allows for more flexibility on the shape of the types while maintaining how EF Core reasons about the model at runtime relatively simple and based on a relatively small number of different concepts.
For individual properties in shadow state one of the main examples is how EF Core always reasons about relationships between objects in terms of foreign key properties, but CLR types that participate in those relationships don't need to contain the FKs.
For full entities in shadow state, the main two potential scenarios to come to mind are:

The link entity in many-to-many associations (which you already mentioned)
Extensibility scenarios in which collections of new data can be added to an entity (e.g. by a user) without having to define a new CLR type to store the new data.

In both cases not having a type in the domain model representing this data is developer choice.

for my use case, I have audit tables that are maintained by trigger. I wanted the tables to be part of migrations so I did this:
foreach ( var entityType in modelBuilder.Model.GetEntityTypes().ToArray() )
{
    var auditEntity = modelBuilder.Entity( entityType.Relational().TableName + "History" );
    foreach ( var property in entityType.GetProperties() )
    {
        auditEntity.Property( property.ClrType, property.Name );
    }
    auditEntity.Property( typeof( DateTime ), "ValidTo" );
    auditEntity.HasKey( "ID", "ValidTo" );
}

Also had to make a custom model validator that skips EnsureNoShadowEntities, but then it works.

We should completely drop support for shadow state entities in favor of property bag entities #9914 as they are easier to work with as a customer and would require less code changes to implement.

Closing as this particular idea (entities without any CLR object) may now not be needed since something like property bags (or even object entities with shadow properties) would cover the cases where this was thought to be useful.

It's a little silly that I need to define something like internal class Dummy<T>{} which I only intend to use for audit table migrations like the above example.
If you aren't going to implement shadow entities, then why not remove methods like IMutableModel.AddEntityType(string name), since their use isn't supported.

@lakeman Currently Migrations use shadow entity types to decouple the snapshot from the implementation.
When property bag entities are implemented AddEntityType(string name) will probably change meaning.


404 when authenticating with GH enterprise

Extension version: 0.1.2
VSCode Version: 1.27.1
OS: Mac OSX

Steps to Reproduce:

Add GH enterprise to user settings hosts
ex: 	"github.hosts": [
{
"host": "https://github.example.com/"
}
]
Launch VS Code
Go To SCM Panel
Authentication popup is displayed
Click sign in
Click continue on browser tab that opens up
404 page appears for the redirected url to our enterprise instance

We ran into the same issue. While troubleshooting we discovered a couple of things:

I could get rid of the 404 if I created an OAuth app under my account with https://github-editor-auth.herokuapp.com as the callback URL. I then replaced the clientId in the URL that Code opens up when signing in with the clientId for my new app. Boom no more 404! Unfortunately auth still fails likely because it doesn't know the clientSecret of my app :(

When trying the workaround specified in https://github.com/Microsoft/vscode-pull-request-github/issues/384#issuecomment-419993453 I found that it worked just fine for forked repos under user accounts but it did not work for any repos under our org. I tried both with the specific grants as well as the ALL THE THINGS grant and had the same results. Are there are specific org-wide permissions that need to be enabled for this extension to work?

Note all this was tested locally using vsce to package the latest code from master ( specifically for #411 )

When I try the workaround specified in #384, after closing and reopening VSCode my settings.json is updated to remove the token from github.hosts (leaving just the host URL) and it asks me to sign in.

I got the same issue when connecting my Github Enterprise account. Pls keep us posted if there is any workaround or fix. I would use the extension because it seems be useful.
Thanks.

Exactly same issue here.  I got the link below when I saw 400, replace IDs with XXXX
https://github.ibm.com/login/oauth/authorize?state=action%3Acode%3Bguid%3A_XXXX_&scope=read%3Auser user%3Aemail repo write%3Adiscussion&response_type=code&client_id=_XXXX_&redirect_uri=https%3A%2F%2Fgithub-editor-auth.herokuapp.com

I've found a way to work around the token disappearing issue. Go through the sign-in process like normal and let it fail. After it fails go into your settings.json and setup your hosts:
github_hosts: [
  {
    host:'https://your.host.here',
    username: 'your.username',
    token: 'your.token'
  }
]

Then go into the SCM tab and refresh your PRs and you should be good to go.
This should work for multiple hosts as well if you have to connect to multiple GHE instances.

Thanks @ultimatemonty for the workaround. I got my plugin working by creating token with the following permission: read:user, repo, user:email, write:discussion. Got these permission from the queries of 404 request (original: scope=read%3Auser%20user%3Aemail%20repo%20write%3Adiscussion)

I've found a way to work around the token disappearing issue. Go through the sign-in process like normal and let it fail. After it fails go into your settings.json and setup your hosts:
"github.hosts": [
  {
    "host": "https://your.host.here",
    "username": "your.username",
    "token": "yourtoken"
  }
]

Make sure to use your GHE username and not oauth as the comment recommends. Then go into the SCM tab and refresh your PRs and you should be good to go.
This should work for multiple hosts as well if you have to connect to multiple GHE instances.

This doesn't work for me. The username and token attribute get automatically removed every time I save the setting file.

i did not see the scope write:discussion, is it because GHE admin turned it off or simply GHE version thing? mine is GitHub Enterprise 2.11.18

Thanks to @ultimatemonty and @reverbc. I got mine working, but I did have to restart VS Code.

@lukefan6 It's too old. Enterprise 2.11.x is deprecated and contains serious unpatched security vulnerabilities. Request your administrator to upgrade as soon as possible.

I'm also getting the 404 error. Tried creating the personal token manually as @reverbc mentioned but did not have the write:discussion scope available as @lukefan6 described. Version is 2.12

@ultimatemonty @reverbc These solution solved my issue.
GHE 2.14

The versions of GHE that support signing in with the Sign In popup are:

2.14.5 and above
2.13.11 and higher 2.13.x
2.12.19 and higher 2.12.x
2.11.25

Other versions will need a personal access token configured with the scopes read:user, repo, user:email, write:discussion, as mentioned above.

i did not see the scope write:discussion, is it because GHE admin turned it off or simply GHE version thing? mine is GitHub Enterprise 2.11.18

Oh this is a good point, some versions of GHE might not have this scope available, in which case the personal token might fail. I think we can ease restrictions on the scope validation for this so it won't fail (write:discussion is not essential at this time).

@shana Ah the patch version makes all the difference. Thank you

The wiki has updated instructions on how to sign in to GitHub Enterprise, check them out at https://github.com/Microsoft/vscode-pull-request-github/wiki#2-is-github-enterprise-supported!
If you're still having problems, please open a new issue with the details


Window doesn't refresh

I've tried upgrading from v0.2 to v1.0 and I had no problems with v0.2 but after upgrading to v1.0 I get this bug where the main app window doesn't refresh when I press buttons.
Surprisingly, the program still works, if I press "turn LEDs off" the LEDs do turn off, and I can access settings and go back, but I can't see them.
Check the gif below to understand what I mean:

Here's my OS info, let me know if you need any more info:

Have you tried fully reinstalling?

I have now, uninstalled everything and removed the folder in %USER%/AppData/Roaming too, same issue :(

Ok, this seems very weird. Could you clone this repo, make a test build and share your console logs?

I've never used Vue so that might be a bit difficult with no instructions 😅

Ahhh, forgot to add instructions to the README file 😄  Here they are:
npm i
npm run electron:serve

Ok, that took a bit more fighting with Visual Studio than I would've wanted, but managed to get it running.
When I do electron:serve the app appears as a floating window and then the UI works as expected, but when I click the tray icon so the app minimizes to tray and then I click tray again to get the pop up, I end up in the same semi-transparent, non-updating state. There are no errors either in the terminal or in the Developer Tools console :/

My best guess is that it has to do something with my workaround for window flickering. Maybe you could try to make a test build with commented lines from 125 to 129 and from 225 to 229 in this file?

Yes! Commenting out just the timeout on show fixes the issue:

I tried changing the timeout to 250 and 500 but the issue was still there.
Thanks for the help, that fixes it, at least temporarily :)

This seems weird because on my end without these lines window starts to flicker 😄  classical windows behaviour. I'll have another look for possible workarounds.


element{-desktop,}: 1.10.7 -> 1.10.8

Description of changes

https://github.com/vector-im/element-web/releases/tag/v1.10.8
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

works for me ... though I have noticed that xdg_utils maybe should be added to the propagatedBuildInputs as element attempts to open links with xdg-open which fails silently if xdg-open is not present in PATH. This however is not related to this PR.


Add a main function to python samples

This marshals argv to the sample's function, without any changes.
TODO: Make sure the elements of argv are converted to the proper types for the sample's function.

Codecov Report

Merging #2273 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2273   +/-   ##
=========================================
  Coverage     86.76%   86.76%
  Complexity     5135     5135
=========================================
  Files           452      452
  Lines         20398    20398
  Branches       2190     2190
=========================================
  Hits          17699    17699
  Misses         1929     1929
  Partials        770      770

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7216ca...13397d2. Read the comment docs.

ptal


Remove debug logging

In PR #356 a console.log() was unintentionally left. This PR removes it.

thanks is already taken care of in this 35ae1913ca83f651d09ca52d15cef026680080a2


Refactor LenientPlatformGraphResolveState to not extend DefaultExternalComponentGraphResolveState

A lenient platform component is unlike any other external components.
It does not have configurations or variants in the conventional sense, so prior logic did some odd things in order to make a lenient platform component conform to the format required for an external component state.
This commit reimplements lenient platform components standalone, to avoid some confusing logic and untangle external and module components so that we can  make further changes to module components in future changes
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test prf apt

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

All Performance Tests (Trigger)

Build Scan

The following builds have passed:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have passed:

All Performance Tests (Trigger)

Build Scan

@bot-gradle test and merge


tensordot/conj interplay

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): CentOS Linux 7, Kernel 3.10
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): v1.8.0-0-g93bc2e2072 1.8.0
Python version: Python 3.6.2 :: Continuum Analytics, Inc.
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: CUDA 9.0.176 (but not in use)
GPU model and memory: GeForce GTX 1080 (but not in use)
Exact command to reproduce: execute python script below

Describe the problem
I am using the code below to contract four tensors A[l,m,n] B[q,l,i] C[j,p,m,q] conj(D[p,n,k]) using a series of tensordot operations. To verify the result, I compare tensorflow with pure numpy. It seems like the tf.conj node is ignored (or an additional conjugation is executed) when executing tensorflow's tensordots, as the first print gives me False and the second one True, although it should be the other way round. Just as a remark: The third part of my code uses einsum instead and works as intended (output of the third print should be True and is indeed True). Thank you for your help!
Source code / logs
import numpy as np
import tensorflow as tf

n = 100
m = 4
dtype = np.complex128

### generate random tensors ###

def rand(*shape):
    return np.asarray(
        np.random.random(shape) + 1j*np.random.random(shape),
        dtype
    )

A = rand(n, m, n)
B = rand(m, n, n)
C = rand(m, m, m, m)
D = rand(m, n, n)

### perform numpy computation ###

X_np = np.tensordot(A, B, (0,1))
Y_np = np.tensordot(X_np, C, ((0,2),(2,3)))
Z_np = np.tensordot(Y_np, D.conj(), ((3,0),(0,1)))

### build tensorflow computation graph ###

A_node = tf.placeholder(dtype, (n, m, n))
B_node = tf.placeholder(dtype, (m, n, n))
C_node = tf.placeholder(dtype, (m, m, m, m))
D_node = tf.placeholder(dtype, (m, n, n))

X_node = tf.tensordot(A_node, B_node, (0,1))
Y_node = tf.tensordot(X_node, C_node, ((0,2),(2,3)))
Z_node = tf.tensordot(Y_node, tf.conj(D_node), ((3,0),(0,1)))

### run tensorflow computation ###

session = tf.Session()
Z_tf = session.run(
    Z_node, feed_dict={A_node: A, B_node: B, C_node: C, D_node: D}
)
session.close()

### compare results ###

print(np.allclose(Z_np, Z_tf))

### run tensorflow computation again with numpy conj ###

session = tf.Session()
Z_tf = session.run(
    Z_node, feed_dict={A_node: A, B_node: B, C_node: C, D_node: D.conj()}
)
session.close()

### compare results ###

print(np.allclose(Z_np, Z_tf))

### build tensorflow computation graph using einsum ###

W_node = tf.einsum(
    "lmn,qli,jpmq,pnk->ijk", A_node, B_node, C_node, tf.conj(D_node)
)

session = tf.Session()
W_tf = session.run(
    W_node, feed_dict={A_node: A, B_node: B, C_node: C, D_node: D}
)
session.close()

print(np.allclose(Z_np, W_tf))

Output
False
True
True

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Bazel version

Sorry, I deleted the fields Bazel version and GCC/Compiler version, as I was not installing tensorflow from source.

Nagging Assignee @tatatodd: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 74 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 89 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 104 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 119 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 134 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 149 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 167 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @tatatodd: It has been 181 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Hi @mrader1248 ! This issue is getting resolved in 2.8 version using compat.v1 mode. Attaching gist for reference . Thanks!


Enhancements and Refactoring for ESLint Compliance

This pull request introduces a series of enhancements and refactoring changes to the codebase, primarily focused on achieving compliance with the ESLint rules as per the Airbnb style guide. The changes span both backend and frontend components, ensuring a consistent and maintainable code quality standard across the project.
Key changes include:

Integration of ESLint with Airbnb Style Guide: We've established ESLint adherence to the Airbnb style guide, applying it to both the backend and frontend parts of the project. This includes creating ESLint configurations and adding necessary dependencies.

GitHub Actions for ESLint Checks: New workflows for GitHub Actions have been added to automatically perform ESLint checks on both backend and frontend code. This ensures that every pull request and commit adheres to our coding standards.

Refactoring and Code Style Adjustments: Numerous refactoring changes have been made, including renaming variables to camelCase, reordering function definitions, removing unused variables, and adjusting line lengths for better readability. These changes align the codebase with the established style guidelines.

Optimizations and ESLint Rule Adjustments: Various optimizations such as replacing traditional loops with array methods, utilizing useMemo for context values, and implementing prop validation in components have been implemented. Additionally, some ESLint rules were temporarily adjusted for development convenience, with plans to revert them before production deployment.

Documentation and Script Updates: The README file has been updated to include code style guidelines and linting instructions. New npm scripts for linting have also been introduced, streamlining the development process.

These changes contribute to a more robust, readable, and maintainable codebase, aligning with industry-standard practices and enhancing the overall quality of our project.
Resolves: #98

Commits Included:

Add GitHub Action for ESLint checks on backend code.
Resolve variable shadowing in getGeometry function.
Replace ++ with += 1 in regionController for loop.
Implement concurrent processing in regionController.
Ensure consistent return in controller and route functions.
Refactor variable names to camelCase in regionController.
Reorder function definitions in regionController.
Remove unused variable from regionController.
Temporarily Disable no-console Rule in ESLint for Development.
Remove Unnecessary await in Return Statements.
Refactor Line Lengths for Style Guide Compliance.
Refactor configuration management and update scripts for development environment.
... (and more changes covering frontend enhancements and adjustments).

Summary by CodeRabbit

New Features

Search functionality with a new search bar for fetching and displaying results.
GitHub Actions workflows for automated ESLint checks on backend and frontend code.
New commands for running ESLint and fixing linting errors in the backend.
New API endpoints and controller functions for region data management.
Introduction of a navigation context in the frontend for managing selected regions and hierarchies.
New frontend components for improved user interaction and display, including BreadcrumbNavigation, HierarchySwitcher, ListOfRegions, RegionMap, and more.

Enhancements

Improved error handling and response generation in backend controllers.
Refactoring of database configuration to use environment variables.
Enhanced maintainability by centralizing database configuration in the backend.
Structural changes in the frontend App component for better UI organization.
Refactoring of frontend API request functions for better readability and consistency.

Bug Fixes

Adjusted import order in backend app.js to ensure proper middleware execution.

Documentation

Updated backend and frontend README files to reflect new code style configurations and file extensions.

Refactor

Code reformatting and cleanup across various backend and frontend files for better readability and maintainability.

Style

Introduction of Airbnb's JavaScript style guide and ESLint integration for consistent coding standards.

Tests

No visible changes to end-users.

Chores

No visible changes to end-users.

Revert

No visible changes to end-users.

PR Analysis

🎯 Main theme: Code refactoring and enhancements for ESLint compliance
📝 PR summary: This PR introduces a series of enhancements and refactoring changes to the codebase to achieve compliance with the ESLint rules as per the Airbnb style guide. It includes the integration of ESLint with the Airbnb style guide, addition of GitHub Actions for ESLint checks, refactoring and code style adjustments, optimizations and ESLint rule adjustments, and updates to documentation and scripts.
📌 Type of PR: Refactoring
🧪 Relevant tests added: No
⏱ Estimated effort to review [1-5]: 4, because the PR involves a significant amount of refactoring and changes to the codebase, which requires a thorough review to ensure that the changes do not introduce new bugs or regressions.
🔒 Security concerns: No security concerns found

PR Feedback

💡 General suggestions: The PR is well-structured and the changes are clearly explained. The use of ESLint and adherence to the Airbnb style guide will help maintain a consistent coding style across the project. However, it would be beneficial to add tests to ensure that the refactoring and changes have not introduced any new bugs or regressions.

 🤖 Code feedback:

relevant file: backend/src/controllers/regionController.js
suggestion: Consider using destructuring to simplify the code and improve readability. For example, instead of const { regionId } = req.params; const hierarchyId = req.query.hierarchyId || 1;, you can use const { params: { regionId }, query: { hierarchyId = 1 } } = req; [medium]
relevant line: '+  const { regionId } = req.params;'

relevant file: backend/src/controllers/regionController.js
suggestion: It's a good practice to avoid console.log in production code. Consider using a logging library that can provide different levels of logging and can be toggled for production or development. [important]
relevant line: '+    console.error(err);'

relevant file: backend/src/models/HierarchyRegionMapping.js
suggestion: It's recommended to use a linter rule to enforce a newline at the end of files. This can help prevent potential issues with concatenation or other operations. [medium]
relevant line: '+module.exports = HierarchyRegionMapping;'

relevant file: frontend/src/index.js
suggestion: It's not recommended to disable ESLint rules unless absolutely necessary. If the rule is causing issues, consider adjusting the rule or refactoring the code to comply with the rule. [medium]
relevant line: '+/* eslint-disable react/jsx-filename-extension */'

How to use
  Instructions

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.


chore: add license field

explicitly declare the license for this package so it can be recognized by checkers

Hi,
Just wanted to do exactly the same!
Thank you @sajhu for the PR! 👍
Hopefully a maintainer can publish it (just for this sake...)


error: expected initializer before 'noexcept'  void operator delete(void *p, std::size_t n) noexcept { std::free(p); }

Hi,
[100%] Linking CXX executable pioasm
[100%] Built target pioasm
[ 20%] No install step for 'PioasmBuild'
[ 21%] Completed 'PioasmBuild'
[ 21%] Built target PioasmBuild
Scanning dependencies of target picoprobe_probe_pio_h
[ 22%] Generating probe.pio.h
[ 22%] Built target picoprobe_probe_pio_h
Scanning dependencies of target picoprobe
[ 23%] Building C object CMakeFiles/picoprobe.dir/src/led.c.obj
[ 24%] Building C object CMakeFiles/picoprobe.dir/src/main.c.obj
[ 25%] Building C object CMakeFiles/picoprobe.dir/src/usb_descriptors.c.obj
[ 26%] Building C object CMakeFiles/picoprobe.dir/src/probe.c.obj
[ 27%] Building C object CMakeFiles/picoprobe.dir/src/cdc_uart.c.obj
[ 29%] Building C object CMakeFiles/picoprobe.dir/src/get_serial.c.obj
[ 30%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_stdlib/stdlib.c.obj
[ 31%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_gpio/gpio.c.obj
[ 32%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_claim/claim.c.obj
[ 33%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_platform/platform.c.obj
[ 34%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_sync/sync.c.obj
[ 35%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_uart/uart.c.obj
[ 36%] Building ASM object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_divider/divider.S.obj
[ 37%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/common/pico_time/time.c.obj
[ 38%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/common/pico_time/timeout_helper.c.obj
[ 39%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_timer/timer.c.obj
[ 40%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/common/pico_sync/sem.c.obj
[ 41%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/common/pico_sync/lock_core.c.obj
[ 43%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/common/pico_sync/mutex.c.obj
[ 44%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/common/pico_sync/critical_section.c.obj
[ 45%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/common/pico_util/datetime.c.obj
[ 46%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/common/pico_util/pheap.c.obj
[ 47%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/common/pico_util/queue.c.obj
[ 48%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_runtime/runtime.c.obj
[ 49%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_clocks/clocks.c.obj
[ 50%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_watchdog/watchdog.c.obj
[ 51%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_xosc/xosc.c.obj
[ 52%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_pll/pll.c.obj
[ 53%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_vreg/vreg.c.obj
[ 54%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_irq/irq.c.obj
[ 55%] Building ASM object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/hardware_irq/irq_handler_chain.S.obj
[ 56%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_printf/printf.c.obj
[ 58%] Building ASM object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_bit_ops/bit_ops_aeabi.S.obj
[ 59%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_bootrom/bootrom.c.obj
[ 60%] Building ASM object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_divider/divider.S.obj
[ 61%] Building ASM object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_double/double_aeabi.S.obj
[ 62%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_double/double_init_rom.c.obj
[ 63%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_double/double_math.c.obj
[ 64%] Building ASM object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_double/double_v1_rom_shim.S.obj
[ 65%] Building ASM object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_int64_ops/pico_int64_ops_aeabi.S.obj
[ 66%] Building ASM object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_float/float_aeabi.S.obj
[ 68%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_float/float_math.c.obj
[ 68%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_float/float_init_rom.c.obj
[ 69%] Building ASM object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_float/float_v1_rom_shim.S.obj
[ 70%] Building C object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_malloc/pico_malloc.c.obj
[ 72%] Building ASM object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_mem_ops/mem_ops_aeabi.S.obj
[ 73%] Building ASM object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_standard_link/crt0.S.obj
[ 74%] Building CXX object CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_standard_link/new_delete.cpp.obj
/home/pi/pico/pico-sdk/src/rp2_common/pico_standard_link/new_delete.cpp:20:46: error: expected initializer before 'noexcept'
void operator delete(void *p, std::size_t n) noexcept { std::free(p); }
^
/home/pi/pico/pico-sdk/src/rp2_common/pico_standard_link/new_delete.cpp:24:33: error: expected initializer before 'noexcept'
void operator delete[](void *p) noexcept { std::free(p); }
^
CMakeFiles/picoprobe.dir/build.make:585: recipe for target 'CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_standard_link/new_delete.cpp.obj' failed
make[2]: *** [CMakeFiles/picoprobe.dir/home/pi/pico/pico-sdk/src/rp2_common/pico_standard_link/new_delete.cpp.obj] Error 1
make[2]: *** Waiting for unfinished jobs....
CMakeFiles/Makefile2:74: recipe for target 'CMakeFiles/picoprobe.dir/all' failed
make[1]: *** [CMakeFiles/picoprobe.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
pi@raspberrypi:~ $

Please note:  this issue is on Raspberry Pi 3B+


The storage account named amptmpstorage210 is already taken. (Parameter 'Name')

Describe the bug
I tried to install multiple times. In about one out of three times I receive the message:
The storage account named amptmpstorage### is already taken. (Parameter 'Name')
Where ### is a random three digit number.
Unfortunately, at this time an app registration was already created (not entirely sure about that).
To Reproduce
Try the installation multiple times (with different names).
Expected behavior
The storage account can be created. The generated part of the account name should be long enough to ensure a unique name and if a generated name is already used, a new name should be generated.
Documentation: Users should be advised to delete the storage account manually in case the installation fails.
Screenshots
Environment (please complete the following information):
This happens in CloudShell and Powershell (Windows 11, PowerShell 7.2.5).
Additional context
Issue #292
Installed Modules.txt
When the installation fails, hangs or is cancelled, the storage account is not deleted. Hence the names remain used until the user manually deletes the storage account.

I think we should increase the randomness of the storage account name to start with.

#236 seems to relate to the same topic.


Maven plugins not detected under different groupId

Description
Like #1340 for spring-boot, the same issue affects also the Karaf maven plugin. I'll check the others.

BTW, in which use cases are Maven plugins repackaged ?

Not aware of the others, so I'll not change them for now. But the karaf maven plugin is being repackaged with a different groupId for the purpose of having a different versioning scheme in RH quickstarts.


[Android][Image rendering] Image sizes are not being respected when rendering inside a column

Platform

[ ] Android

Version of SDK
main
Details
When images are rendered inside a column, they may shrink to allow other columns have enough space to render, this provokes behaviours as documented in #4988 , a revision must be made to verify what is the actual behaviour we want as cards as 1.2/Scenarios/FlightUpdate expect images to shrink

Closing as duplicate of #4988


Config json Added

Reference Issues/PRs
#73
What does this implement/fix? Explain your changes.
This PR is going to make these changes:

_GI_initializer function
generate_params_filter function
plot_params_filter function
filter_size function
save_config method
load_config function
save_config_file function
samilaConfigError
filter_float function
NO_FUNCTION_ERROR and JUST_DATA_WARNING removed
config parameter added to GenerativeImage `init
filter_projection function edited

Codecov Report

Merging #80 (05c8d2e) into dev (c4f193f) will decrease coverage by 1.27%.
The diff coverage is 96.75%.

@@             Coverage Diff             @@
##               dev      #80      +/-   ##
===========================================
- Coverage   100.00%   98.74%   -1.26%
===========================================
  Files            4        4
  Lines          228      317      +89
  Branches        30       48      +18
===========================================
+ Hits           228      313      +85
- Misses           0        3       +3
- Partials         0        1       +1

Impacted Files
Coverage Δ

samila/functions.py
98.06% <95.84%> (-1.94%)
:arrow_down:

samila/errors.py
100.00% <100.00%> (ø)

samila/genimage.py
100.00% <100.00%> (ø)

samila/params.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f193f...05c8d2e. Read the comment docs.

@sepandhaghighi Please review this PR.
It's a big one so feel free for commenting anywhere.
Thank you :1st_place_medal:


Provide way to destroy app in SSR

What problem does this feature solve?
This issue is related to: https://github.com/vuejs/vue-router/issues/2606
Providing a way to destroy the app or mark the SSR request as complete (maybe on $ssrContext) is a potential fix to this problem, though maybe not the best one.
To recap:
A memory leak happens when the router-view is programmed to appear conditionally, and the component matching the view has a beforeRouteEnter guard and a callback is passed to it's next(...) method (e.g. next(vm => {})).
This will cause vue-router to poll every 16ms until the router-view materializes.
In a typical SSR application an instance of the app is created per request, which means the router-view will never appear, causing infinitely recursing poll methods.
What does the proposed API look like?
A potential fix to this would be to detect when the app is destroyed in vue-router's poll method, and allow the user to destroy the app that they created in entry-server.js.
A simplified example:
export default context => {
  return new Promise((resolve, reject) => {
    const { app, router } = createApp(context)

    const { url } = context

    router.push(url)

    router.onReady(() => {
      resolve(app)
    }, reject)
  }).then(destroyApp)
}

Need too


fix: 修复华为云eneterprise-project-list异常问题

这个 PR 实现什么功能/修复什么问题:
修复华为云eneterprise-project-list异常问题
是否需要 backport 到之前的 release 分支:
None
/area region
/cc @zexi

Codecov Report

Merging #5918 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5918   +/-   ##
=======================================
  Coverage    6.94%    6.94%
=======================================
  Files         641      641
  Lines      110004   110004
=======================================
  Hits         7640     7640
  Misses     101777   101777
  Partials      587      587

Flag
Coverage Δ

#aFlag
6.94% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087a2a1...4d71f7e. Read the comment docs.


Make first level keys unique

What problem does this PR solve?
Problem Summary:
In current impl, first level keys (string, collections name) can be duplicated, which may cause confusing
What is changed and how it works?
What's Changed:
Make first keys unique, while duplicate, return Status::WrongType
Check List
Tests

Unit test
Stress test

Side effects
No

TEST


check against stored processed multiple files

This is for a multiple-entry,each with their own js/css/templates, multiple-output scenario, as follows:
example directory
.
+-- node_modules
+-- build
+-- dist
|   +-- page1.html
|   +-- page2.html
|   +-- page3.html
+-- src
|   +-- pages
|   |   +-- page1
|   |   |   +-- template.hbs
|   |   |   +-- index.js
|   |   |   +-- styles.css
|   |   +-- page2
|   |   |   +-- template.hbs
|   |   |   +-- index.js
|   |   |   +-- styles.css
|   |   +-- page3
+-- package.json
+-- webpack.config.js
+-- //etc...
webpack.config.js
// ... some var setup above
let pageNames = ['page1','page2','page3'];

pageNames.forEach((pageName) => {
  entry[pageName] = `./src/pages/${pageName}`;
  extractTexts[pageName] = new ExtractTextPlugin('[name]-styles.css');

  loaders.push({
    test: /\.css$/,
    loader: extractTexts[pageName].extract('style', 'css'),
    include: [
      path.resolve(__dirname, 'src', 'pages', pageName)
    ]
  });

  plugins.push(new HtmlWebpackPlugin({
    chunks: [pageName],
    filename: `${pageName}.html`,
    template: `src/pages/${pageName}/template.hbs`
  }));

  plugins.push(extractTexts[pageName]);
});

plugins.push(new ScriptExtHtmlWebpackPlugin({
  inline: pageNames.map((pageName) => {
    return `${pageName}-scripts`;
  })
}));

plugins.push(new StyleExtHtmlWebpackPlugin());

Not sure if what I'm trying to do here is the best way, so any thoughts/suggestions would be greatly appreciated!

Thank you!
I'll take a look - but not until the weekend I'm afraid.
If OK, do you understand the unit tests (hint, hint)?

No worries on looking at it this weekend - thanks for the quick reply!
Some of the unit tests were failing upon initial checkout, before I edited anything, and those are the same that are failing now (it seems).
I'm also wondering if my use-case for this plugin is unique and I may not need to submit this? My next step is getting a sass-loader to work before this all, so i can eventually: write sass, compile it to css, extract it out of the js file, and inline it into the ...

Closing this one as I opened a new one with sass support


Updated German translations of two new strings (second try)

Hide Inline ads as a benefit of being a supporter
Improved wording for K&P perving benefit

For the records: This is a replacement for #280 which was a mess because I had a problem rebasing my fork repo before I made that pull request. I cleaned up and it looks better now.

For the records: This is a replacement for #280 which was a mess because I had a problem rebasing my fork repo before I made that pull request. I cleaned up and it looks better now.


KAFKA-12832: Remove Deprecated methods under RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter

Jira: https://issues.apache.org/jira/browse/KAFKA-12832
We need remove below deprecated methods in RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter

org.apache.kafka.streams.state.internals.RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter#maxBackgroundCompactions
org.apache.kafka.streams.state.internals.RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter#setBaseBackgroundCompactions
org.apache.kafka.streams.state.internals.RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter#setMaxBackgroundCompactions
org.apache.kafka.streams.state.internals.RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter#maxBackgroundFlushes
org.apache.kafka.streams.state.internals.RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter#setMaxBackgroundFlushes

Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Let's try to be more careful with approving changes. This broke several tests.

Sorry! I'll be more careful next time


fix lava testnet to testnet-2

the current entry is outdated

Looking over this, I think we need to revert this PR. I think this was meant to be an archived chain with id lava-testnet-1, whereas lava-testnet-2 has chain_name: "lavatestnet". I think most the properties here are meant to be reverted, the status set to killed, and the chain_name changed to lavatestnet1 to properly archive this as having been abandoned post a hard-fork--the one leading to the creating of lava-testnet-2.
Does this sound acceptable? For now, to correct the duplicate chain-id problem, I need to at least set the chain_id back to lava-testnet-1, but it aught to be fully archived.

Looking over this, I think we need to revert this PR. I think this was meant to be an archived chain with id lava-testnet-1, whereas lava-testnet-2 has chain_name: "lavatestnet". I think most the properties here are meant to be reverted, the status set to killed, and the chain_name changed to lavatestnet1 to properly archive this as having been abandoned post a hard-fork--the one leading to the creating of lava-testnet-2. Does this sound acceptable? For now, to correct the duplicate chain-id problem, I need to at least set the chain_id back to lava-testnet-1, but it aught to be fully archived.

yes, makes sense. we can kill the lava-testnet-1 and create a new lava-testnet-2, what triggered the need for the change?

The trigger for this was the addition of automation to detect chain-id conflicts. The chain-id for multiple chains had lava-testnet-2 which will no longer be allowed at the chain registry.
I'd like to essentially revert the changes in this PR to restore the version history and other details of lavatestnet1, plus set its status to 'killed'(, assuming it to be the pre-fork chain of lava-testnet-2), and to update the chain_name for lavatestnet2 to just 'lavatestnet'. This way, no matter which version of Lava Testnet is current, it will always keep the chain_name: lavatestnet.  This is how other chains have handled archiving pre-fork chains.

This is the PR I propose to correct the handling of the pre-form chain instance:
https://github.com/cosmos/chain-registry/pull/4201


if the first connection fails, abandon the wormhole

This provides a clear error in case the user doesn't have an internet
connection at all, or something is so broken with their DNS or routing that
they can't reach the server. I think this is better than waiting and
retrying (silently) forever.
If the first connection succeeds, but is then lost, subsequent retries occur
without fanfare.
closes #68

Note that this won't work until Twisted-17.5.0 is released, as it depends upon the new clientService API that it will provide.

Twisted-17.5.0 is out, this can land as soon as CI approves.


Run fails with OpenJDk 1.7 on Debian stretch

I downloaded the command line from http://dl.bintray.com/jeremy-long/owasp/dependency-check-1.3.1-release.zip and got this error:
$ ./dependency-check.sh --project loop-server -s ~/git/mozilla-services/loop-server/
[INFO] Checking for updates
[INFO] NVD CVE requires several updates; this could take a couple of minutes.
[INFO] Download Started for NVD CVE - 2010
[INFO] Download Started for NVD CVE - 2009
[INFO] Download Started for NVD CVE - 2007
[INFO] Download Complete for NVD CVE - 2009  (3255 ms)
[INFO] Download Started for NVD CVE - 2011
[INFO] Processing Started for NVD CVE - 2009
[INFO] Download Complete for NVD CVE - 2007  (4869 ms)
[INFO] Download Started for NVD CVE - 2012
[INFO] Download Complete for NVD CVE - 2010  (5359 ms)
[INFO] Download Started for NVD CVE - 2013
[INFO] Download Complete for NVD CVE - 2011  (4176 ms)
[INFO] Download Started for NVD CVE - 2014
[INFO] Processing Complete for NVD CVE - 2009  (9497 ms)
[INFO] Processing Started for NVD CVE - 2007
[INFO] Download Complete for NVD CVE - 2013  (15684 ms)
[INFO] Download Started for NVD CVE - 2015
[INFO] Download Complete for NVD CVE - 2014  (13664 ms)
[INFO] Download Started for NVD CVE - Modified
[INFO] Download Complete for NVD CVE - 2012  (16252 ms)
[INFO] Download Complete for NVD CVE - Modified  (3611 ms)
[INFO] Download Complete for NVD CVE - 2015  (3699 ms)
[INFO] Processing Complete for NVD CVE - 2007  (13217 ms)
[INFO] Processing Started for NVD CVE - 2010
[INFO] Processing Complete for NVD CVE - 2010  (21202 ms)
[INFO] Processing Started for NVD CVE - 2011
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007fb7ed32b47f, pid=4947, tid=140427709626112
#
# JRE version: OpenJDK Runtime Environment (7.0_85-b01) (build 1.7.0_85-b01)
# Java VM: OpenJDK 64-Bit Server VM (24.85-b03 mixed mode linux-amd64 compressed oops)
# Derivative: IcedTea 2.6.1
# Distribution: Debian GNU/Linux buildd-unstable (sid), package 7u85-2.6.1-3
# Problematic frame:
# J 1133 C2 org.h2.store.Data.readString(I)Ljava/lang/String; (148 bytes) @ 0x00007fb7ed32b47f [0x00007fb7ed32b2c0+0x1bf]
#
# Failed to write core dump. Core dumps have been disabled. To enable core dumping, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/ulfr/git/dependency-check/bin/hs_err_pid4947.log
#
# If you would like to submit a bug report, please include
# instructions on how to reproduce the bug and visit:
#   http://icedtea.classpath.org/bugzilla
#
Aborted

Full error log at https://ulfr.pastebin.mozilla.org/8847821

This looks like an H2 issue.  Maybe you should try purging your local H2 database.

@jvehent any chance you could retry this with 1.4.3?

Closing the issue due to lack of response.


Boot Splash Use Filter option has no effect

Godot version
v4.0.dev.custom_build [d17201afc]
System information
Windows 10
Issue description
The "Use Filter" project setting (application/boot_splash/use_filter) does nothing when enabled, the boot splash always renders with filter off. The option works fine in v3.4.beta.custom_build [322252e], so this is a regression.
Steps to reproduce

In the Boot Splash section of project settings:

Set a boot splash image

Enable "Use Filter" (on by default)

Run the project
The boot splash will not use filter

Minimal reproduction project
testing_boot_splash_use_filter_v4.0.zip

For the record, the splash screen was reimplemented in master by https://github.com/godotengine/godot/pull/50137. Filter options now need to be set on a per-texture use thanks to Vulkan bindless textures.

Can confirm this still happens as of v4.0.alpha.calinou [c80540f9a]


Surface parse errors from input building

This makes it possible to work with the parse errors when building integrations.
This change is also consistent with the behavior of: InputFromPaths.

Does this not mean we lose location data outside of OPA? Can’t the client unwrap the error?
I don’t know a lot about how errors are normally surfaced in Go APIs, but I think even OPA does some wrapping of errs here and there?
Not meant as leading questions either, I’m genuinely clueless 😅

Closing as we can use errors.Unwrap for now. We can revisit in #271 if we need to.


filterFunction example request

Would you guys be so kind and share filterFunction example?

@kyrodabase I had trouble figuring out how the filterFunction works also. Here's my understanding of how it works when working with a text input field:
function myFilterFunction(cell: any, search: string): boolean {
  // Do filter stuff here and return true (to keep row) or false (to remove row)
}

Param cell is a reference to the cell value that's being checked. Param string is the user input from the search field that would be used for checking against the cell value.

I tried to use the filterFunction option like this
`totalRows: {
title: 'Total Rows',
type: 'number',
filterFunction: this.totalRowsFilter(),
},
totalRowsFilter(cell?: any, search?: string) : boolean{
console.log("Here");
return false;
}`
But I am unable to get it to work, can someone point out what I am doing wrong?

What does the "filterFunction " do ?

@RoryGarner92 it allows you to customize how the filter works. Like if you have a nested field or a field that is an array of objects for example:
skills: {
      title:"Skills",
      valuePrepareFunction: (skills) => {
        return skills.map(s => " " + s.name + " ").toString()
      },
      filterFunction(skills?: any, search?: string): boolean {
        let match = skills.map(s => s.name).indexOf(search)
        if (match || search === '') {
          return true;
        } else {
          return false;
        }
      },

Is there a way to access row data within the filterFunction?

 nome_razao_social: {
        title: 'Empresa',
        type: 'string',
        valuePrepareFunction: (coluna, linha) => {
          return `${linha.cliente.nome_razao_social.slice(0, 17)} .`;
        },
        filterFunction(cell: any, search?: string): boolean {
          console.log(cell);
          console.dir(search);
          return true;
        }

      }

Hi, I just tried the @ssomnoremac code however the value of cell parameter which is defined in my filterFunction is always a empty string. Is it a bug?

is there any way to have a third parameter on this filterFunction to filter against a range (between search1 and search2)?

Hi, I also tried the @ssomnoremac code, in a column with prepared value but the value of cell parameter is always a empty string too.

We really need to have a third parameter for accessing row data from filterFunction!

'customer.lastname': {                 title: 'Customer',                 valuePrepareFunction: (cell, row) => row.customer.firstname + ' ' + row.customer.lastname,                 filterFunction(cell?: any, search?: string): boolean {                     console.log(cell);                     return true;                 },             },
cell argument in filterFunction is always a empty string if valuePrepareFunction has been called before

Thx , i've made some progress with your help, i have added a input before my smart-table and bind a onsearch function on keydown ( still the same column has my previous post with filter at false )
onSearch(query: string = '') {
        this.source.setFilter([
                {
                    field: 'customer.lastname',
                    search: query,
                    filter: (cell?: any, search?: string) => {
                        console.log(cell);
                        console.log(search);
                        return true;
                    },
                },
            ], false,
        );
    }

i can catch the filter event but cell is still a empty string, one thing i have observed is if i use the same code on a root property on my objects that i put in the smart-table ( customer.lastname is a sub property ) , well its working and its working with filterFunction too

when using valuePrepareFunction instead a flat property, there is a bug calling the filter and passing always "" as value:
https://github.com/akveo/ng2-smart-table/blob/master/src/ng2-smart-table/lib/data-source/local/local.filter.ts#L11
This could be fixed just passing the element (el) to the filter and let the developer deal with getting the value.

I have tried to use valuePrepareFunction and filterFunction (with this order) and I always obtain an empty string on the cell parameter in the filterFunction.. Any solution?
  supplierCode: {
    title: 'Supplier code',
    filterFunction(cell?: any, search?: string): boolean {
      const match = cell.indexOf(search) > -1;
      if (match || search === '') {
        return true;
      } else {
        return false;
      }
    },
    valuePrepareFunction: (cell, row) => row.supplierData.code
  },

Hi Guys,
were working on it and it is working for me in the following way:
client {
first_name : "John",
last_name : "Smith"
}
In my table I show John Smith and filtering works for both fields, first_name and last_name
      client : {         title: 'Cliente',         type: 'string',         width: '150px',         filter: true,         valuePrepareFunction: (value) => {            return value.first_name + ' ' + value.last_name ;          },         filterFunction(obj?: any, search?: string): boolean {           if(obj.first_name.toLowerCase().indexOf(search) > -1 || obj.last_name.toLowerCase().indexOf(search) > -1)           return true;           return false;         },       },
Hope this helps.
Cheers,
Nico

i dont think
https://github.com/akveo/ng2-smart-table/blob/master/src/ng2-smart-table/lib/data-source/local/local.filter.ts#L11
caters object within an object and this is what causes the problem of
filterFunction(cell?: any, search?: string): boolean {
cell being null

@Motassem-MK  hi did u have yours working?

So I've encountered an issue where an empty string is always passed as the value for the first argument of filterFunction. This only happens for data that has nested objects. The issue lies in the code here: local.filter.ts
For example, let's say we have 2 sample classes:
class Name {
    firstName: string;
    lastName: string;
}

class User {
    age: number;
    name: Name;
}

In order to access the name of a user, you'll have to first get a reference to the Name class: user.name.firstName
I noticed that the filter function tries to access object properties using string names. The bug lies on the string name used. I tested it and the code is trying to access the inner property this way:
user["name.firstName"]
// or like this in the source code
el["name.firstName"]

Obviously, this doesn't work and this is why you'll always get an empty string. So as a fix, i suggest splitting the property string by "." separator and access the property like this:
user["name"]["firstName"]
// or like this in the source code
el["name"]["firstName"]

The fix to the source code:
export class LocalFilter {

  protected static FILTER = (value: string, search: string) => {
    return value.toString().toLowerCase().includes(search.toString().toLowerCase());
  }

  static filter(data: Array<any>, field: string, search: string, customFilter?: Function): Array<any> {
    const filter: Function = customFilter ? customFilter : this.FILTER;

    return data.filter((el) => {
      // Holds the data
      let data: any = el;

      // Split the property string
      const propertyList: string[] = field.split(".");

      // Access inner properties
      for(const property of propertyList) {
        data = data[property];
      }

      const value = typeof data === 'undefined' || data === null ? '' : data;
      return filter.call(null, value, search);
    });
  }
}

This should automatically loop through the inner object properties, no matter how deep they are.

As an alternative to the loop, you can also use lodash _.get(obj, property) to get the property of inner objects. Here: Lodash Get

@steffenkoenig

Is there a way to access row data within the filterFunction?

@Motassem-MK

We really need to have a third parameter for accessing row data from filterFunction!

I would suggest you checkout, upvote, and comment on this issue #897 Need Row Value in filterFunction

How I add the filterFunction to my custom filter component?
In my columns settings:
        filterFunction(cell?: any, search?: string) {
          myCustomFuncion();
        },
        filter: {
          type: 'custom',
          component: CustomFilterComponent
        }

But the data is customized and needs the compare function, there is some way to do it like:
        filter: {
          type: 'custom',
          component: CustomFilterComponent
        }

?

@RoryGarner92 it allows you to customize how the filter works. Like if you have a nested field or a field that is an array of objects for example:
skills: {
      title:"Skills",
      valuePrepareFunction: (skills) => {
        return skills.map(s => " " + s.name + " ").toString()
      },
      filterFunction(skills?: any, search?: string): boolean {
        let match = skills.map(s => s.name).indexOf(search) > -1
        if (match || search === '') {
          return true;
        } else {
          return false;
        }
      },

it work well for me!

Hi Guys,
were working on it and it is working for me in the following way:
client {
first_name : "John",
last_name : "Smith"
}
In my table I show John Smith and filtering works for both fields, first_name and last_name
`
client : {
    title: 'Cliente',
    type: 'string',
    width: '150px',
    filter: true,
    valuePrepareFunction: (value) => {
      return value.first_name + ' ' + value.last_name ;
    },
    filterFunction(obj?: any, search?: string): boolean {
      if(obj.first_name.toLowerCase().indexOf(search) > -1 || obj.last_name.toLowerCase().indexOf(search) > -1)
      return true;
      return false;
    },
  },

`
Hope this helps.
Cheers,
Nico

Hi. thanks for your help. but it dose not work for me. the model I'm using is not flat like yours what should I do?
the value is

Hi Guys,
were working on it and it is working for me in the following way:
client {
first_name : "John",
last_name : "Smith"
}
In my table I show John Smith and filtering works for both fields, first_name and last_name
`
client : {
    title: 'Cliente',
    type: 'string',
    width: '150px',
    filter: true,
    valuePrepareFunction: (value) => {
      return value.first_name + ' ' + value.last_name ;
    },
    filterFunction(obj?: any, search?: string): boolean {
      if(obj.first_name.toLowerCase().indexOf(search) > -1 || obj.last_name.toLowerCase().indexOf(search) > -1)
      return true;
      return false;
    },
  },

`
Hope this helps.
Cheers,
Nico

Hi. thanks for your help. but it dose not work for me. the model I'm using is not flat like yours what should I do?
the value is undefined

maybe at valuePrepareFuction u should change value to client


Please invite me to the Recode-Hive GitHub Community Organization

Name
yash
Discord Username (if applicable)
yashmandi
Additional Context
No response

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people


Parsing error with comment after line continuation character

The following code will generate a parsing error:
program test1    integer, parameter :: ims = 12,ime=16,jms=1,jme=10    REAL,  DIMENSION(ims:ime, jms:jme), INTENT(OUT) ::                   & ! Does not like a comment here                                         HEAT2D                            ! What about here  end program test1

Confirmed.

@johnmauff  Should be addressed by latest develop-acc changes. Please confirm on your end.

@domcharrier Thanks for the update.  Unfortunately, this modification appears to trigger an indexing error in the split_fortran_line function see issue #38.  As a result, this update does not reduce the number of files that generate errors in my application.


byapp isCandidate true

Pull Request Test Coverage Report for Build 435

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.47%

Totals

Change from base Build 433:
0.0%

Covered Lines:
92

Relevant Lines:
103

💛  - Coveralls


[BUG] useProduct() delivers manufacturer null on detailpage

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
I am trying to find out the manufacturer on the product detail page. I tested it also with standard product detailpage layout from  cms-base package. it doenst work.

I also tested to overwrite the component and here useProduct() returns manufacturer: null. I am tested it also to use  await useProduct() with no success.
On the listing page, however, it returns values.
Expected Behavior
I am expecting data for the manufacturer.
Steps To Reproduce
No response
Environment
Packages:
"@shopware-pwa/composables-next": "^1.1.0",
"@shopware-pwa/helpers-next": "^1.0.0",
"@shopware-pwa/nuxt3-module": "^1.0.2",
"@shopware-pwa/types": "^1.0.1",
"@shopware/api-client": "^1.0.1",

Shopware: <IP_ADDRESS>

Anything else?
No response

Hey, due to possible performance impact, some of the associations aren't enabled by default. however you have full control of what is fetched from API by association parameter. For this specific case, you can use search method of  useProductSearch composable to fetch the product with all related entities, like manufacturer, here's an example:

if you are using a vue-demo-store template, here's the place you can work with: https://stackblitz.com/edit/github-gltuc5?file=components%2FFrontendDetailPage.vue
let us know if this solution works for you and if it's good enough to close the issue :)

Thanks for fast reply. This solution works partly for me. I can get the name. But still not all manufacturer informations are returning, like media. Here i still get media: null.
I can also see that media is null in your screenshot above.
Think it would be nice to have a list of all associationss in the documentation.

Thanks for fast reply. This solution works partly for me. I can get the name. But still not all manufacturer informations are returning, like media. Here i still get media: null. I can also see that media is null in your screenshot above.

this is the case also for associations parameter:

and the media appears.

Think it would be nice to have a list of all associationss in the documentation.

could it be a part of core documentation, I agree. but I have a tip for that: when you see a property with a null value - it's potentially the case for association. when the property you need is not preset in the response - that's not possible to load this related entity - simply does not exist.

Thanks, for that tip! That works for me.


Browse.path not sent (Go to definition sometimes goes to the declaration instead)

I am working in VSCode Version: 1.49.3 and have this bug, macOS 10.15.4
When I click "Go to definition", sometimes it went to declarations and sometimes it went to the definition.
No error or warning messages.
c_cpp_properties.json
{
  "configurations": [
    {
      "name": "vscode_stm32_c_cpp_properties",
      "compilerPath": "/Users/AneoX/compilers/gcc-arm-none-eabi-9-2020-q2-update/bin/arm-none-eabi-gcc",
      "includePath": [
        "${workspaceRoot}/Inc/",
        "${workspaceRoot}/Drivers/cmsis/",
        "${workspaceRoot}/Drivers/STM32F0xx_StdPeriph_Driver/inc/"
        // "${workspaceRoot}/**"
      ],
      "browse": {
        "path": ["${workspaceFolder}"],
        "limitSymbolsToIncludedHeaders": true,
        "databaseFilename": "${workspaceFolder}/.vscode/browse.vc.db"
      },
      "cStandard": "c11",
      "cppStandard": "c++17",
      "intelliSenseMode": "gcc-arm",
      "configurationProvider": "ms-vscode.cmake-tools",
      "defines": ["USE_STDPERIPH_DRIVER", "STM32F042"]
    }
  ],
  "version": 4
}

Originally posted by @aneox in https://github.com/microsoft/vscode-cpptools/issues/3378#issuecomment-703267452

Any progress on this. It seems that the extension is overiding the browse.path with an empty list.

This should have been fixed with #2418.  The fix is now available in the "pre-release" version of CMake Tools.  It will be included in 1.10.  If you would like to try it out and see, please install the pre-release version.


[lc-440] - Increase reporting service http engine timeout from 55 sec…

…s to 300 sec (5 mins)

Closing for now as no longer needed as part of LC-444 release.

Closed in error. Reopening...


Add Selective type class

Add Selective type class from https://www.staff.ncl.ac.uk/andrey.mokhov/selective-functors.pdf
This is an initial implementation and missing docs, tests and instances. However, maybe someone else can contribute to this code and expand on it.

see also https://github.com/gcanti/fp-ts/issues/1191 and https://github.com/gcanti/fp-ts-contrib/pull/6

Oh cool! Thank you for pointing these out.


Fixed isinline bug

isInline option was not working because span tag was used for non-root tag.
I fixed it to be applied to root tag(.svelte-renderer).

Thanks @Seo-Rii


Simplify run-time feature checks in unit tests

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss<EMAIL_ADDRESS>

IMHO the unit tests should use the related API function instead: http://jerryscript.net/api-reference/#jerry_is_feature_enabled

During some development, I've run into this:
/home/travis/build/akosthekiss/jerryscript/tests/unit-core/test-typedarray.c: In function ‘main’:
/home/travis/build/akosthekiss/jerryscript/tests/unit-core/test-typedarray.c:475:7: error: ‘byte_length’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
       TEST_ASSERT (byte_length == element_count);
       ^
/home/travis/build/akosthekiss/jerryscript/tests/unit-core/test-typedarray.c:472:22: note: ‘byte_length’ was declared here
       jerry_length_t byte_length;
                      ^
lto1: all warnings being treated as errors
lto-wrapper: /usr/bin/gcc returned 1 exit status
/usr/bin/ld: lto-wrapper failed
collect2: error: ld returned 1 exit status

It's strange that this hasn't appeared before, but the compiler is actually right. If jerry-core is built with the es5.1 profile, the body of some API functions is macrod out to be dummy. But some of them have out parameters, which are not filled in in this case. And LTO correctly recognizes this when jerry-core is linked to the unit tests. (Note: there are runtime feature checks in the unit tests, but the compiler cannot infer info from such checks.)
In the above example, the following code causes the problem:
jerry_value_t buffer = jerry_get_typedarray_buffer (array, &offset, &byte_length);
TEST_ASSERT (byte_length == element_count);

@LaszloLango I'm not sure whether calling jerry_is_feature_enabled would help the LTO problem as that's also a runtime check.

BTW have y'all seen the appveyor checking out on the PR? :) ( @lygstate @yichoi )

It has turned out that the simpler jerry_is_feature_enabled approach worked as well. Thanks for the tip @LaszloLango . PR updated

see it need a badge on the home Page

LGTM


LE Audio: Use the BASE example from the BAP spec for the broadcast samples

Is your enhancement proposal related to a problem? Please describe.
The current broadcast samples does an OK job of showing significant amount of how the API can and should be used. However, they are not setting any metadata or creating multiple subgroups.
My suggestion is to use the BASE example from the BAP spec as the Zephyr sample:

This would showcase more of the API, and provide a more "real" scenario, as well as something that a developer can refer to from the spec.
Describe the solution you'd like
Modify the Broadcast Audio Source and Broadcast Audio Sink sample to support the BASE example from BAP.
Describe alternatives you've considered
We could/should consider offering support for mono, so that the number of BIS for each subgroup is reduced to 1 (2 total) instead of 2 (4 total), to support more controllers.
Additional context
N/A

Ping @larsgk

Just FYI, the BASE from BAP 1.0.1 is not something that actual works: 4 streams with 48 kHz is simply not possible, and IIRC the BASE example will be updated to reflect that in a later BAP version.

See https://bluetooth.atlassian.net/browse/ES-23582


client: print only active addresses

I was playing around with the client and noticed it hit an unreachable while printing the parsed addresses. It seems like BoundedArray's {any} format prints the entire inner buffer, even the uninitialized ones.
I changed the print to use .const_slice() which returns the initialized addresses.

Good catch, and mea culpa!


fix collect error memory vaule

This change is

please provide a description of the PR (what fixes, how it fixes it, etc).  Also, please remove the extraneous .iml file.

please add a description of what this is fixing.  It would appear that this includes several different changes.

Closing as obsolete. Please reopen if you still want to work on this.


Not able to get the document ID from the collection.

Hi,
I am using subscription to get documents from the server.
And then storing them in METCollection object.
Code:
METCollection *collection = [client.database collectionWIthName:@"database"];
NSArray *array = [collection allDocuments];
Now, I want to get the document ID of individual documents while looping through the array.
I have gone through the source code, but I could not find anything that gives ID of the document.
Please tell me how to get the documentID from the document.
Thanks & Regards,
Srinivas

METDocuments have a key property, which is an instance of METDocumentKey, which has a documentID property.

I tried it earlier, but the xcode threw an error saying documentID is not a property of NSString*.
This time I tried it again with instantiating the key to a separate variable first and then got the documentID from it. Thank you so much.
METDocumentKey *docKey = [collection[i] key];
documentID = [docKey documentID];

I did this to return the documentId. Ignore the sharedInstance. That's just me creating a singleton for easy use. the documentKeyFoObjectID is what's important
return [[MeteorSession sharedInstance]documentKeyForObjectID:self.objectID].documentID;


The input images and the output silhouettes

How to get the single input image and the rendered silhouettes? For example, input the following image, but the generated silhouettes has multiple models. Do I need to modify  anything?

@ShichenLiu

Hi,
Can you describe how you generate the image above? I can hardly help you without more details. Thanks.

ok,I generate the image by this,and the camera is the same as described in this project.Thank you! @ShichenLiu

Ohh, sorry i didnt make it clear. I meant how you generated the silhouette image on the right side.

I don‘t know, I generated the sihouette as described in the project. This is what I want to ask, how to generate an image with only one sihouette？


Fix CI

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If this change need a document change, I will prepare another pr against the document branch
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Pull Request Test Coverage Report for Build 6139

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.006%) to 28.058%

Files with Coverage Reduction
New Missed Lines
%

core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java
2
80.23%

Totals

Change from base Build 6137:
0.006%

Covered Lines:
26224

Relevant Lines:
93465

💛  - Coveralls

LGTM


error with summarize option

I am running falcon7b with user data and when summarize option is submitted I am getting the following error
1 validation error for Document page_content str type expected (type=type_error.str)

It's not a generic thing that happens.  I'd guess there is an issue with one of the parsers
Can you say which type of document (file extension etc.) you used to hit this?  Thanks!

This is the detailed error message raceback (most recent call last):   File "/usr/local/lib/python3.10/dist-packages/gradio/routes.py", line 442, in run_predict     output = await app.get_blocks().process_api(   File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1389, in process_api     result = await self.call_function(   File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1108, in call_function     prediction = await utils.async_iteration(iterator)   File "/usr/local/lib/python3.10/dist-packages/gradio/utils.py", line 346, in async_iteration     return await iterator.__anext__()   File "/usr/local/lib/python3.10/dist-packages/gradio/utils.py", line 339, in __anext__     return await anyio.to_thread.run_sync(   File "/usr/local/lib/python3.10/dist-packages/anyio/to_thread.py", line 33, in run_sync     return await get_asynclib().run_sync_in_worker_thread(   File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread     return await future   File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 807, in run     result = context.run(func, *args)   File "/usr/local/lib/python3.10/dist-packages/gradio/utils.py", line 322, in run_sync_iterator_async     return next(iterator)   File "/usr/local/lib/python3.10/dist-packages/gradio/utils.py", line 691, in gen_wrapper     yield from f(*args, **kwargs)   File "/app/h2ogpt/code/h2ogpt/src/gradio_runner.py", line 1663, in bot     for res in get_response(fun1, history):   File "/app/h2ogpt/code/h2ogpt/src/gradio_runner.py", line 1618, in get_response     for output_fun in fun1():   File "/app/h2ogpt/code/h2ogpt/src/gen.py", line 1703, in evaluate     for r in run_qa_db(query=instruction,   File "/app/h2ogpt/code/h2ogpt/src/gpt_langchain.py", line 2057, in _run_qa_db     docs, chain, scores, use_docs_planned, have_any_docs = get_chain(**sim_kwargs)   File "/app/h2ogpt/code/h2ogpt/src/gpt_langchain.py", line 2329, in get_chain     docs_with_score = [(Document(page_content=result[0], metadata=result[1] or {}), 0)   File "/app/h2ogpt/code/h2ogpt/src/gpt_langchain.py", line 2329, in <listcomp>     docs_with_score = [(Document(page_content=result[0], metadata=result[1] or {}), 0)   File "/usr/local/lib/python3.10/dist-packages/langchain/load/serializable.py", line 74, in __init__     super().__init__(**kwargs)   File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__ pydantic.error_wrappers.ValidationError: 1 validation error for Document page_content   str type expected (type=type_error.str)

What kind of file did you upload originally?
I'm guessing one of the files used a parser that left it as non-str.
Can you figure out which file that is and share?

I used pdf files, like publications!

I have met the same problem when I use mydata pdf or txt files to summarize, please help me to solve it. Thanks!

@pseudotensor

I'm happy to fix if there is a reproduction of it.  When I looked before I couldn't see how could happen, but added some protection anyways, but clearly not resolved.

Actually with the above earlier command I can repro with certain docs.  Checking on it.

ok fixed.  Was specific to weaviate.


FIX-#2380: don't ignore lengths parameter for dask engine

Signed-off-by: Anatoly Myachev<EMAIL_ADDRESS>
What do these changes do?

Add lengths parameter handling for dask engine.
Make split_result_of_axis_func_pandas always return a list value and removes a bug in which the wrong number of partitions is returned (in the case when num_splits==1 and lengths != 1)

[x] commit message follows format outlined here
[x] passes flake8 modin
[x] passes black --check modin
[x] signed commit with git commit -s
[x] Resolves #2380
[ ] tests added and passing

@YarShev ready for review

@anmyachev , apparently, now we don't have a case when return value is different from list. So, I think we need to remove this check and keep returning list.

Also, can you rebase on current master to fix failing of Omnisci tests?


fix PepQuery2 memory

I changed the Java options, because the JVM overhead can lead to failing jobs, when the tool uses the full amount defined in GALAXY_MEMORY_MB as stack.

https://github.com/galaxyproject/tpv-shared-database/issues/30

@mira-miracoli we have now something similar in the default tool. Do we need this PR still?

I guess not


New Pool documentation

TODO:

[ ] Update examples and check code samples in docs
[ ] Add upgrading from 0.x to 1.0 instructions
[ ] Add notes on known bugs/limitations/expected behavior

Not sure if it will be already covered by this, but the 1st example here:
https://aioredis.readthedocs.io/en/v0.3.0/api_reference.html#connections-pool
seems to be missing a call to 'acquire' before 'execute'.

Yeap, its probably example for master branch not for v0.3


Exclude apache-jsp from gwt-tests.

Gretty pulls it in too, so it's not enough to have it on other classes.
Not sure why it isnt an issue for everyone, but https://mvnrepository.com/artifact/org.gretty/gretty-runner-jetty93/2.3.0 clearly lists it as a dependency.

I've found that if you just specify a servlet container on the gretty config in Gradle, this issue goes away.

@MrStahlfelge You'd add
gretty.servletContainer = "jetty9"
Or
gretty.servletContainer = "jetty8"
Depending on the gretty version. I'm not at my computer to look which I added.


Send conversation state updates to Slack

Description
Added the ability to send any notification to our Slack integration when a conversation is closed, prioritized, archived or deleted.
Issue
354
Screenshots

Checklist

[x] Everything passes when running mix test
[x] Ran mix format
[x] No frontend compilation warnings

hey @jalford14 any updates on this? :) let me know if you need help with anything!

hey @reichert621! busy couple of days of work but I'm starting back up right now. i'll let you know if I'm running into any issues

I added some emojis to our messages for visual clarity. Totally open to any changes you want to make from a design perspective but I tried to keep it similar to the icons used in-app. Let me know what you think!

love the emojis @jalford14 😄 will take a look at this today!

@reichert621 sounds good!

thanks again @jalford14, works great! 😁


[bug] Timeout waiting for clusters/mongodb

Search before asking

[X] I had searched in the issues and found no similar issues.

Environment
Linux (self-host)
What happened
I did a fresh install on a Ubuntu 23.04 server as root. I'm ran sh install-on-linux.sh $DOMAIN and everything seemed to install fine until it tried to fire up mongodb. I get the following messsage:
....
2024-07-04T22:59:21 info trying default http mode to sync images to hosts [<IP_ADDRESS>:22]
2024-07-04T22:59:42 info Executing UpgradeIfNeed Pipeline in InstallProcessor
DOMAIN: <IP_ADDRESS>.nip.io
<IP_ADDRESS>.nip.io has address <IP_ADDRESS>
namespace/laf-system created
+ sed s/$CAPACITY/5Gi/g mongodb.yaml
+ kubectl apply -n laf-system -f -
cluster.apps.kubeblocks.io/mongodb created
+ kubectl wait --for=condition=Ready --timeout=120s cluster.apps.kubeblocks.io/mongodb -n laf-system
error: timed out waiting for the condition on clusters/mongodb
Error: exit status 1

Has anyone seen this before? btw: This is an incredible project! Cheers, Dave
How to reproduce
sh install-on-linux.sh $DOMAIN
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Added more RAM and it worked.--------------------------


packages in doc-requirements.txt are incompatible

Software Versions

Python: 3.8.2 64-bit
OS: Windows 10
Kivy: full clone of main branch up to commit #5c8cb1f (merging #7009 )
Kivy installation method: fork, clone

Describe the bug
This is a bug in the process of documentation updates instead of with Kivy itself.
Installing the packages from the provided ./doc/doc-requirements.txt skips four packages as they require a newer version of sphinx than the version is locked to.  Terminal output provided below.
Expected behavior
Install all packages succesfully.
To Reproduce

Navigate terminal to kivy/doc
run pip install -r doc-requirements.txt

Code and Logs and screenshots
sphinxcontrib-seqdiag 2.0.0 requires Sphinx>=2.0, but you'll have sphinx 1.7.9 which is incompatible.
sphinxcontrib-nwdiag 2.0.0 requires Sphinx>=2.0, but you'll have sphinx 1.7.9 which is incompatible.
sphinxcontrib-blockdiag 2.0.0 requires Sphinx>=2.0, but you'll have sphinx 1.7.9 which is incompatible.
sphinxcontrib-actdiag 2.0.0 requires Sphinx>=2.0, but you'll have sphinx 1.7.9 which is incompatible.
Successfully installed sphinx-1.7.9

Additional context

Fixed via #7623


[universe]: fix proof sync for large asset minting batches

I encountered this on testnet while trying to reproduce https://github.com/lightninglabs/taproot-assets/issues/675.
Can be reproduced with:
--universe.sync-all-assets
--universe.federationserver=testnet.universe.lightning.finance:10029

And tapcli u s --universe_host testnet.universe.lightning.finance:10029.
This PR fixes the issue by making sure any group anchors are inserted into the DB first.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 46 (0.0%)  changed or added relevant lines in 2 files are covered.
27 unchanged lines in 5 files lost coverage.
Overall coverage decreased (-0.007%) to 40.388%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

universe/base.go
0
12
0.0%

universe/syncer.go
0
34
0.0%

Files with Coverage Reduction
New Missed Lines
%

tappsbt/create.go
2
53.85%

universe/base.go
2
0.0%

tapgarden/caretaker.go
4
68.87%

tapdb/multiverse.go
7
60.32%

universe/interface.go
12
50.22%

Totals

Change from base Build<PHONE_NUMBER>1:
-0.007%

Covered Lines:
23916

Relevant Lines:
59215

💛  - Coveralls


Fix grammar and typos in Misconceptions.md

Really small fixes to the file to make it more consistent and fix some typos.

wow! lots of fixes 😅 💪


Bug356

Fix for bug 356 - instantiated mockFile with an empty string if it is null.

Thanks for your contribution, but the same thing is already being worked on in #360, so I’m closing this one. Feel free to add your comments to that PR!


[Question] Wasm / Node.js support

I'm new to Rust, and I was wondering how hard it would be to compile this into WebAssembly for usage with Node.js / browsers. I tried briefly using wasm-pack build (after adding crate-type = ["cdylib"] to Cargo.toml) and it just spit out a bunch of errors. I'm not experience enough to know whether this is relatively easy with a little bit more configuration or if it would require rewriting code.
Any feedback / help is appreciated.

After some more investigation, it seems that the main blocker on this is the fact that raw TCP sockets are used (which are supported in Node.js but not the browser).
If you want to run it in a browser, it might be possible to use Emcripten which polyfills sockets to web sockets. You'd also then need something like websockify on a server.
In theory it should be possible to run on Node.js using network calls from WASI but I'm not sure if WASM compilers work with that yet. This is a very rapidly changing space.
So TL;DR is that if you want Node.js support it looks like it might be easiest to just re-implement in JS.

Thanks for sharing your investigations @codetheweb.
Looks like there's some ongoing work on bringing socket support to Wasi.


docs for methods like "destroy"

Great plugin! It took quite a bit of digging for me to figure out how to reference the accordion after creation to execute methods like "destroy". Your test code has an example in it, but a mention like this in the documentation would be helpful:
var accordion=$('#accordion').liteAccordion();
accordion.liteAccordion('destroy');

Fixed in v2.0.2