Closes #117 : Calculate calories for given weight

Description

Added option to calculate calories for given weight in the overflow menu. This option in the overflow menu will hide automatically for products that are incomplete and don't have the calories information.

Moved getEnergy method from NutritionInfoProductFragment.java to Utils.java as this method is now used in two different classes.

Added custom layout background for the spinner as the in the default spinner layout the drop-down arrow was far away from the text and didn't look good. Somewhat like this.

Related issues and discussion
Fixes #117
Screen-shots, if any

Checklist
Make sure you've done all the following (You can delete the checklist before submitting)

[x] Apply the AndroidStyle.xml style template to your code in Android Studio.
[x] Code is well documented
[x] Include unit tests for new functionality
[x] All user-visible strings are made translatable
[x] Code passes Travis builds in your branch
[x] If you have multiple commits please combine them into one commit by squashing them.
[x] Read and understood the contribution guidelines.

@Karljoones Sure I will try to document the code. I was not sure about the UI and thus opened the PR for discussions. Yes even I feel that this feature would look more appropriate if placed in an overflow menu. Waiting for other people to review before pushing another commit.

@huzaifaiftikhar Please document this code a bit better too, we are pushing to get the code documented correctly. Please ensure that people understand what the code you wrote does

I feel like this feature could be even more useful with a diet mode: I ate 100g of Nutella, add this to my daily log.

@teolemon I have added this feature the overflow menu as suggested by @Karljoones. I agree that this feature would be more useful with a diet mode which can be implemented by adding a button "Add to diary" to the above dialog. We can have a UI something like the below image.

The user would be able to access the daily log/diary via the navigation drawer.
@Karljoones I have documented the code :slightly_smiling_face:

@teolemon What do you want to do with this? Maybe for now we can move the code into a Utils class for later reference

Can we have a final screenshot of the finished product i.e. the dialog? Going to merge this as it's been here quite a while.

The gif attached with the PR is the final one. No changes have been made after that.

@huzaifaiftikhar can you resolve the conflicts here?
@teolemon I am going to merge this, may not be the most ideal place for the feature but we can move it around later if we need to

I solved the conflict. Ok for merging.

Hey @huzaifaiftikhar,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.

@teolemon so what should we do? Add this option to the bottom bar? Do we have a list of options that we need at the bottom bar? I think according to material design guidelines, bottom bar can have a maximum of five buttons only.

Let's keep it in the top button like you did initially. The bottom bar is still a work in progress that needs to be fixed.

@teolemon So I guess this is ready for merging as you already resolved the conflicts :slightly_smiling_face:
The Travis build fails due to exceeding the time limit.

Can you rebase on latest trunk ? It should fix the build.

Hey @huzaifaiftikhar,
Something went wrong with the build.
TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.

Hey @huzaifaiftikhar,
Your changes look good to me!

was approved, builds. merging.


Hyperlink to release notes

I want the notification to link me to the release notes. I'm also not able to get any release notes in the notification.
notify:
  default_telegram:
    type: telegram
    url_fields:
      token: <secret>
    params:
      chats: "<removed>"
      parsemode: Markdown
      title: Argus
service:
  louislam/uptime-kuma:
    options: {}
    latest_version:
      type: github
      url: louislam/uptime-kuma
    command: []
    notify:
      default_telegram: {}
    webhook: {}
    deployed_version:
      url: <removed>
      basic_auth:
        username: <removed>
        password: <secret>
      regex: app_version{version=\"([0-9.]+)\",major=\"[0-9]+\",minor=\"[0-9]+\",patch=\"[0-9]+\"}
    dashboard:
      icon: https://raw.githubusercontent.com/louislam/uptime-kuma/master/public/icon.png
      web_url: https://github.com/louislam/uptime-kuma/releases/tag/{{ version }}

You can do this by giving the notify options (docs)
e.g.
notify:
  default_telegram:
    options:
      message: >-
        <{{ service_url }}|{{ service_id }}> -
        {{ version }} released{% if web_url %}
        (<{{ web_url }}|changelog>){% endif %}

This would give
louislam/uptime-kuma - released (changelog)

OK, I was close, and I'll give this a try. In the options.message block I had:  <{{ service_url }}|{{ service_id }}> - {{ version }} released{% if web_url %} (<{{ web_url }}|changelog>){% endif %}.
What is the significance of the >- at first?

OK, I was close, and I'll give this a try. In the options.message block I had: <{{ service_url }}|{{ service_id }}> - {{ version }} released{% if web_url %} (<{{ web_url }}|changelog>){% endif %}.
What is the significance of the >- at first?

That's a YAML thing. It's a way of breaking down long strings so they're more readable.
test: >
  a
  b
  c

will give you 'a b c
'
The > turns newlines into a space, and the - removes the linebreak from the end.
test: >-
  a
  b
  c

= 'a b c'
You can also use | instead of > to preserve linebreaks

Didn't notice the markdown thing, thanks
This worked on Telegram for me
      message: >-
        [{{ service_id }}]({{ service_url }}) -
        {{ version }} released{% if web_url %}
        ([changelog]({{ web_url }})){% endif %}

Thanks @JosephKav . That was it!


add best practice for select Primary key by developers

hi
please limit selection primary key types by developers in bit-framework. for example add IEntityWithDefaultIntKey like IEntityWithDefaultGuidKey and remove IEntityWithDefaultKey generic interface. the best practice for primary key types are Int or Guid. other types should not be selected by developers.
best regards.

I'm not a fan of Int16 as a key for performance considerations (?!), but in some apps you'd prefer to use Int64 as a key.


Add inspections for methods that are only called within route files

My Routes file:

The only place this method is called:

Note that PHPStorm is basically seeing it as dead code.

Example of how they can be fixed:

Manually updated _ide_helper.php for sake of explanation

After the manual change

👍 ?

Thank you for the great package, it's my first require-dev in all my Laravel / Lumen applications
Would love to see support for this use case in ide-helper:generate or separate ide-helper:routes command

Relates to https://github.com/barryvdh/laravel-ide-helper/issues/787

I think this might be better suited for a laravel static analyzer


Release 1.2.0

Summary
I also included a dependency update. Tested locally.
Ticket Link
Fixes https://github.com/mattermost/mattermost-plugin-memes/issues/21

@DHaussermann Would you be fine skipping QA testing given that this is a non Marketplace plugin?

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   78.63%   78.63%
=======================================
  Files           3        3
  Lines        1081     1081
=======================================
  Hits          850      850
  Misses        146      146
  Partials       85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66897cb...857ab3f. Read the comment docs.

@DHaussermann Heads up that I'm just going to release this as it is. There hasn't been any QA test for this plugin anyway.


Work with ContractSpecs in Other Languages

meant to fix #606

Thank you so much! I'll get this assigned next week. Our reviews are a little behind so I think you in advance for your patience!

Thanks @ElliotFriend for the review
I have made the corrections as requested

Thanks @Myestery! I'll merge this one and let's take the award conversation back to the corresponding issue. Yay!


cosmic number.cpp

Have you read the Contributing Guidelines on Pull Requests?
(Write your answer here.)
Description
(Write your answer here.)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

@priyanka001tech  Don't push more than one code file in a single PR.


IPM 0.9 dependency resolution taking a long time

Some packages will sporadically take a long time to install on the v1 branch which has IPM 0.9.x.
Steps to Reproduce
To reproduce this issue:

git clone the repo and switch to the v1 branch
docker compose -d --build
docker exec -it ipm-iris-1 bash
Inside the container, run iris session iris
In the IRIS session, run zpm "install -v demo-pandas-analytics"
Observe the output, for me, it keeps hanging after the following output:

Module demo-pandas-analytics was downloaded from registry (https://pm.community.intersystems.com/)
Loading from /usr/irissys/mgr/.modules/USER/demo-pandas-analytics/1.0.0/

Load started on 12/10/2024 19:47:39
Loading file /usr/irissys/mgr/.modules/USER/demo-pandas-analytics/1.0.0/module.xml as xml
Imported document: demo-pandas-analytics.ZPM
Load finished successfully.

Dependencies:
dsw 3.2.26 @ registry
mdx2json 3.2.41 @ registry
yaml-utils 0.1.4 @ registry
zpm-registry 1.3.2 @ registry

Press Ctrl+p followed by Ctrl + q to detach from the container.
Run docker compose down && docker compose up -d --build &&  docker exec -it ipm-iris-1 /bin/bash to start a fresh container
Run iris session iris to start an IRIS session
In the IRIS session, run the following commands to install dependencies first

zpm "install -v dsw 3.2.26"
zpm "install -v mdx2json 3.2.41"
zpm "install -v yaml-utils 0.1.4"
zpm "install -v zpm-registry 1.3.2"

Now zpm "install -v demo-pandas-analytics" finishes within a reasonable period of time.

A number of packages are influenced by this bug, including

demo-pandas-analytics
iris-flow
telegram-adapter-demo
openapi-suite
iris-flow

This is a deadlock in %SYS.NAMESPACE resulting from https://github.com/intersystems/ipm/commit/6ed90b1622ecb424240db583b102050e289ba26c - the logic here is very flawed, we explicitly add mappings for everything because of course the item doesn't exist yet, we're loading it for the first time.
This needs to be fixed for 0.9 release and may impact HS adoption.
cc @isc-kiyer @isc-eneil @isc-jlechtne @isc-jili

@isc-tleavitt thanks for flagging that. We would not run into it for hscore since we use -DNoMapping=1 but would for other components. Also, the code should probably use %SYS.Namespace:Get*Dest methods to check if the item would be loaded into the expected database instead of already checking existence.


Orphan changes in the list

This change is listed in the website as change in gene coordinates, but a change was never made. Protein has a length of 551, and the comment says introduces stop codon at position 138.
SPCC306.09c	PMID:28631610, PMID:30991417	introduces stop codon at position 138	2020-05-01 00:00:00+00:00

cc @ValWood

Same for this one:
SPAC2F3.04c		truncated 14 AA	2021-11-03 00:00:00+00:00

I'm puzzled by
SPCC306.09c	PMID:28631610, PMID:30991417	introduces stop codon at position 138	2020-05-01 00:00:00+00:00
because the linked publications are about wtfs. This gene isn't in those papers, and the gene structure looks spot on to me. I think that must have been a mistake.

Ok, I will just close then!


annotator: init at 1.0.0

Motivation for this change
Thanks OMGUbuntu for the recommendation, this is much more convenient than Shutter.
I tried to fix the elementary specific icons by linking them to elementary theme as a fallback. In the future, we should probably help with adding those to icon-naming-spec so that other themes implement them too.
cc @NixOS/pantheon @NixOS/gnome
Closes #157510
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@jtojnar can you review the suggestions from @SuperSandro2000?

@jtojnar ping

I do not need this any more.

I tried to fix the elementary specific icons by linking them to elementary theme as a fallback.

elementary probably has the plan to make their themes and icons as default fallback on their flatpak platform, so I am actually not sure whether they will just be hardcoded in the future :crying_cat_face:

I do not need this any more.

@jtojnar Is there any alternative? Can it be taken over or currently not feasible?

I reopened the pull request: https://github.com/NixOS/nixpkgs/pull/275407


Added ability to specify which columns to select in the find blueprint

Added ability to specify which columns to select in the find blueprint. With this, columns can now be specified in the URL when calling /:Model by simply adding the "columns" parameter. The columns should be separated by a comma. I.e. /:Model?columns=column1,column2

I also created this as an npm module that can be added on top of sailsjs.  This can be seen here: https://bitbucket.org/jwenz723/sails-hook-blueprint-findcolumns/overview

Hi @jwenz723, thanks for the PR.  A couple of points:

We have a new contribution guide for proposing features and enhancements that we ask you to check out to help streamline the process of reviewing new code.  You'd need to write up a proposal to make the case for adding this to the Sails core feature set.
Creating a hook is almost always a better idea than attempting to add features to core (because we're trying to keep the core as lean as possible).  So your work might be done already.
It looks like this particular feature relies on a private/undocumented select criteria property in Waterline, so it's unlikely that it would be merged into core anyway.  You'd need to rewrite the code to not rely on that property.  As a hook, it's fine, you just need to be aware that the private API could change at any time and render the hook unusable (so basically "caveat emptor" for your users!)


The notification message is not localized for one empty table

Storage Explorer Version: 1.11.0
Build: 20191105.2
Branch: rel/1.11.0
Platform/OS: Windows 10/ Linux Ubuntu 19.04/macOS High Sierra
Language: Chinese(zh-CN)/ Chinese(zh-TW)
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Launch Storage Explorer.
Open 'Settings' -> Application (Regional Settings) -> Select 'Chinese (simplified)' -> Restart Storage Explorer.
Expand one storage account -> Tables.
Create a new table -> Check the notification message in the editor.

Expect Experience:
The notification message is localized.
Actual Experience:
The notification message is not localized.

More Info:

This issue also reproduces for one empty queue.(related bug: 1604)

This issue doesn't reproduce for one blob container/ file share.

Related bug: 1697

@craxal Is this message exposed to localization ?

Duplicate of #1697.


[FLINK-29702] Add micro benchmarks module and merge tree reader/writer benchmarks

In this PR we create flink-table-store-micro-benchmarks module in flink-table-store-benchmark, and add merge tree reader/writer benchmarks:

In MergeTreeReaderBenchmark we first create a writer to write about 50*50000 records to the store, and performance the latency of scan in reader.
In MergeTreeWriterBenchmark we performance the throughput of write in merge tree with compaction

Hi @JingsongLi I have split the reader/writer factory for compaction in the micro benchmarks and fix the concurrency problem, please review again, thanks


Support for LSP Diagonostics

Does rust-tools have support for Lsp diagnostic? When I have an error I am receiving inline hints about the error. But if I wanted to view the error in a hover I need to call.
vim.lsp.diagnostic.show_line_diagnostics()

I wonder if there a way to integrate this with the hover system from rust-tools?

This shouldn't be super hard to implement, but the real hard part would be getting correct highlighting going
https://github.com/simrat39/rust-tools.nvim/issues/23 is also having the same issue, but i'll look into it with the new api's.


Does not work out-of-the-box with RTIC

Hi,
I just tried this shortly (so I might be missing something), but the rtt_init_print!() does not seem to be usable with RTIC. This is most likely due to the fact that RTIC prevents the use of a main function which would scope the rtt struct. Initializing it in the init function does therefore not work, as the RTT channel is then dropped again.
Would be great if this can be used with RTIC as simple as the use of hprintln! is :slightly_smiling_face::+1:
Or maybe an RTIC example...
Best Regards
Jonathan

I've been debugging a similar problem for a while. It turned out that RTIC wasn't at fault in my case: It just introduced a wfi, which my working non-RTIC example didn't have. It looks like the sleeping is somehow interfering with memory access and thus RTT.
Not sure if this is your problem too, but it may be worth a try.

The macros create everything as static and they cannot be dropped, so in theory everything should work with RTIC unless it's a chip where "wfi" (that RTIC uses) has issues

Yeah, I use a wfi in the idle loop. That's likely the problem


fix: Lazy create telepathy client/server

Otherwise any options set via script are never going to be applied with no way of doing so since everything is "locked in" in Awake

yep nice find.
gonna leave it open and port to telepathy repo in a bit


Article: Understanding let and const in JavaScript ES6

@kshpikat Thank you for your commit. Unfortunately i have some remarks before we can merge your PR:

Briefly write a description and why it should be added to the list

Please make sure you read the contribution guidelines before submitting a PR next time.

Hi @jvaes . That time it was important for me to get the difference between let and const but now I don't think we need two articles for the same topic. I'll close PR. Thank you for your time!


Finish settings page

General:
???
Node:
Node picker
Node status
Sync status
Wallet:
Export mnemonic
Export private key
Reset (resync from 0)
Resync from x
Rewind
Theme:
Pick themes (duh)

Completed.


Segfault compiling conv expression

Describe the bug
The following minimal example highlights an issue in expression compilation where using a scalar-vector multiplication term inside a conv expression causes a segfault when a length-1 vector is used. The segfault occurs within cvxcore/src/cvxcore.cpp::build_matrix when compiling the model into matrix form.
To Reproduce
import cvxpy as	cp

x = cp.Variable((1,)) # or cp.Variable((1,1))
problem = cp.Problem(
    objective=cp.Minimize(
	cp.max(cp.conv([1.], cp.multiply(1., x)))
    )
)
problem.solve("ECOS") # or any solver

The segfault does not occur if the first argument in the cp.multiply term is changed to a non-scalar (e.g., cp.multiply([1.], x)), or if the vector variable x has more than one element.
Expected behavior
Anything but a segfault. If the expression system thinks the involved dimensions are invalid, an earlier exception would be great.
Version

OS: mac, python 3.6
CVXPY Version: master

Something like the following may be all that is needed.
diff --git a/cvxpy/cvxcore/src/LinOpOperations.cpp b/cvxpy/cvxcore/src/LinOpOperations.cpp
index e854d9f5..6f001943 100644
--- a/cvxpy/cvxcore/src/LinOpOperations.cpp
+++ b/cvxpy/cvxcore/src/LinOpOperations.cpp
@@ -434,8 +434,10 @@ Tensor get_conv_mat(const LinOp &lin, int arg_idx) {
   Matrix constant = get_constant_data(*lin.get_linOp_data(), false);
   int rows = lin.get_shape()[0];
   int nonzeros = constant.rows();
-  int cols = lin.get_args()[0]->get_shape()[0];
-
+  int cols = 1;
+  if (lin.get_args()[0]->get_shape().size() > 0) {
+    cols = lin.get_args()[0]->get_shape()[0];
+  }
   Matrix toeplitz(rows, cols);

   std::vector<Triplet> tripletList;

Fixed on master. Thanks for figuring it out!


StoreTypeMultimapCacheTest - off-heap should work

Looking at the  multimap module, I've realised there is a test ignored attending this issue to be integrated: (functional maps + data conversion)
https://issues.jboss.org/browse/ISPN-7993
The issue is integrated now.
I uncommented the test, and everything should pass but the OFF_HEAP does not.
I added a single reproducer test in the StoreTypeMultimapCacheTest called testSinglePut.
This method calls the assertValuesAndOwnershipmethod and the assertOwnershipAndNonOwnership.
In the assertOwnershipAndNonOwnership we try to get the InternalCacheEntry directly from the data container, using the proper encoder. In the case of OFF_HEAP is the GlobalMarshallerEncoder.
The InternalCacheEntry is null, all the tests doing this check fail.
I've been debugging but I don't understand why this is not working. (is the test doing something wrong for OFF_HEAP, something missing, a potential bug ?). Functional maps support encoding now, and tests cover OFF_HEAP.
This PR should be modified after so at least the Object and Binary version of the test don't fail.

Looking...

Integrated into master, thanks @karesti !


Generate tags with --fields=+l for YouCompleteMe support

YouCompleteMe can autocomplete from tags files, but the tags file needs to be generated with --fields=+l.
The following patch seems to work ok (in my limited testing!). Have you considered adding this flag?
diff --git a/plat/unix/update_tags.sh b/plat/unix/update_tags.sh
index a4366e4..18ddbfd 100755
--- a/plat/unix/update_tags.sh
+++ b/plat/unix/update_tags.sh
@@ -80,7 +80,7 @@ fi

 echo "Running ctags"
 echo "$CTAGS_EXE -f \"$TAGS_FILE.temp\" $CTAGS_ARGS \"$PROJECT_ROOT\""
-$CTAGS_EXE -f "$TAGS_FILE.temp" $CTAGS_ARGS "$PROJECT_ROOT"
+$CTAGS_EXE -f "$TAGS_FILE.temp" $CTAGS_ARGS "$PROJECT_ROOT" --fields=+l

 echo "Replacing tags file"
 echo "mv -f \"$TAGS_FILE.temp\" \"$TAGS_FILE\""

I suppose that this is a better patch:
diff --git a/res/ctags.options b/res/ctags.options
index e13de4a..42ec57e 100644
--- a/res/ctags.options
+++ b/res/ctags.options
@@ -1,2 +1,4 @@
 --recurse=yes
+--fields=+l

You can just create a .ctags file in your home directory, and add --fields=+l in it. Ctags reads this file by default (nothing to do with Gutentags) to get any default options you always want applied (see the Ctags documentation for more info).
Note that Gutentags also offers a per-project options file with the .gutctags file.

searching for an answer led me here, but I found this in your .vimrc will also work perfectly well:
let g:gutentags_ctags_extra_args = ['--fields=+l']


Make Solana deposit function callable from ZetaChainClient and from browser

Right now the function reads a key from a filesystem. This works in a Hardhat/Node.js environment, but of course doesn't work in a browser.
https://github.com/zeta-chain/toolkit/blob/73b823d9341b2e30e6ece801c8cbe19daaca7e5d/packages/client/src/solanaDeposit.ts
We need to ensure that the function can be used from a browser.
const client = new ZetaChainClient({
  network: "testnet",
  //...
});
client.solanaDeposit()

For EVM chains we're using Ethers signer. For Solana I'm assuming it's going to be something else. Although, RainbowKit integrates with Solana.
### Tasks
- [ ] Modify the function to be used from `ZetaChainClient` in a browser
- [ ] Ensure that address derived in the toolkit matches the one in the official Solana extension wallet for the same key/mnemonic.
- [ ] Ensure that the function can be called using official Solana extension walllet (Phantom) by passings Solana equivalent of Ethers signer. So that in a browser context you're using extension wallet's signer rather than passing a key/mnemonic

Related: https://github.com/zeta-chain/toolkit/issues/180

@fadeev We haven't used this function in any examples yet, have we?

@fadeev We haven't used this function in any examples yet, have we?

Not yet, no, but it can be used with this example https://github.com/zeta-chain/example-contracts/tree/main/omnichain/swap
See https://github.com/zeta-chain/toolkit/pull/179


Make the SQLAlchemy type hint work better in Pycharm.

Description

Checklist

This pull request is:

[ ] A documentation / typographical error fix

Good to go, no issue or tests are needed

[x] A short code fix

please include the issue number, and create an issue if none exists, which
must include a complete example of the issue.  one line code fixes without an
issue and demonstration will not be accepted.
Please include: Fixes: #<issue number> in the commit message
please include tests.   one line code fixes without tests will not be accepted.

[ ] A new feature implementation

please include the issue number, and create an issue if none exists, which must
include a complete example of how the feature would look.
Please include: Fixes: #<issue number> in the commit message
please include tests.

Have a nice day!

since the pipeline continues to work, I think we can just merge

thanks! published as https://pypi.org/project/sqlalchemy2-stubs/0.0.2a27/


avoid SQLiteDatabaseLockedException

Fix https://github.com/cookpad/puree-android/issues/23
It might occur on multi-process applications so let each process have its database file.

This approach is interesting. We have a option of using ContentProvider, but in this case,

Insert/Select would be slow if we use ContentProvider.
Puree treat DB as a queue.
Writing logs from multi process is a rare case.

so this change is not bad :+1:

Thanks!


Unable update to the most recent version (2.0.2)

Operating system: El Capitan
Messenger for Desktop version: 1.4.3

During app startup a popup apprears asking whether I want to download & update now. I hit OK and nothing happens.

We'll take care of that. In the meantime, please use our downloads page: https://github.com/Aluxian/Facebook-Messenger-Desktop/releases

Please review this link immediately to prevent possible malware/adware issues. If I'm wrong I'm hoping for further updates there.
https://github.com/Aluxian/Facebook-Messenger-Desktop/issues/804


RBAC Inheritance

If we have a reader role provided at Management groups RBAC and if we provide an owner role for a specific subscription under the same management group. I could notice reader permissions are working for the user.
Is that right? if yes, what is the solution or workaround here?
Thanks in advance.
Hemanth

@cloudlearner253
Since this channel is for driving improvements towards MS Docs, could you provide the URL of the specific documentation that your feedback is applicable to? That way, we are able to make sure your feedback is addressed by the right team.

@cloudlearner253
Since we have not heard back from you, we will now proceed to close this thread.If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Pathfinder Community Sheet v1.826 updates

Added Racial modifiers and Ability Score Increases to the Ability Score grid. Given these modifiers are already accounted for in the Base column either directly or through the Misc modifier, you will need to manually adjust these fields for existing characters if you would like to track these modifiers separately.
Feat and Trait abilities will display their type2 value with the roll template subtitle in chat if provided on the repeating row.
Feat and Trait datalist translation added.

Submission Checklist
Required

[ ] The pull request title clearly contains the name of the sheet I am editing.
[ ] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[ ] The pull request makes changes to files in only one sub-folder.
[ ] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Character Sheet Info Roll20 Internal Use only.


This article doesn't define key terms that are used.

This article uses the following terms.  But as to what those means not clearly defined here or anywhere else.
Therefore it is hard to glean a precise meaning of these terms by simply reading this or any article.
Terms:
Registration Virtual Network
- You can get somewhat of an idea by reading the article. . But could be defined before
using this term.
Resolution Virtual Network
- Not clear at all.  Who and in what scenarios do you resolution networks?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7d766d17-0650-407e-1aed-d94966ea4932
Version Independent ID: 0254b3d9-adaf-8292-c3d3-93cb665b7504
Content: Use Azure DNS for private domains
Content Source: articles/dns/private-dns-overview.md
Service: dns
GitHub Login: @vhorne
Microsoft Alias: victorh

Actually I found my own answer: But it should be clearly worded.  Here is my suggestion.
Azure Private DNS introduces 2 new concepts to DNS.
1. Registration Virtual Network. - VNet with private DNS zone name, that is resolved by Azure (Internal) DNS.
○  VMs added to this are automatically registered with its name as an A record.
○ VMs resolved by Azure (internal) DNS for any queries coming from VNet's that are
permitted to query.
Resolution Virtual Networks. - VNet's that are permitted to query the Private DNS Zone.

@DMoonesinghe Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

@DMoonesinghe
Article updated.
#please-close


Bug: C4 in asia-southeast1

Compute API reports machine type C4 in asia-southeast1. However, the price is not available and the website does not list the instance in the region.

[x] Check again as soon C4 is GA.

https://github.com/Cyclenerd/google-cloud-compute-machine-types/commit/a6486944890e8dee74602279e1f74be06833ca9b

GA: https://cloud.google.com/compute/docs/release-notes#August_19_2024
Singapore - asia-southeast1-[a,b] - listed.

https://github.com/Cyclenerd/google-cloud-compute-machine-types/commit/df9beb4cb17de65ae310d885e44ef767ee42136d


refactor: kcl playground frontend

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[x] N
[ ] Y

refactor: kcl playground frontend

LGTM


[feat]: Initialization.sh should play a "bep" noise

Prerequisites

[X] I have searched for existing issues that already suggest this feature, without success.

Describe the Feature Request
Initialization.sh should play a "bep" noise
Describe the Use Case
When the user first plugs in their embassy, they have to wait 5 minutes for the initialization.sh script to run. Then once it's done, there's a bep immediately followed by a chime, so the bep does not serve much purpose here.
Describe Preferred Solution
No response
Describe Alternatives
No response
Anything else?
No response

This is too hard to be worth it.

Well, I guess as long as we're communicating some other way that the embassy will take a few minutes after you plug it in for it to do anything, then that's fine

this only applies to build-from-source. embassy images that we ship will have initialization.sh already run

Should this be closed? Anyone building from source will be following a guide. We could include messaging in the guide setting expectations. Also, we have the "Embassy is initializing page" that will show during this time, correct?

I'd say this is solved handily by "nc  8080"


Configurable token lifetimes  (Preview) OR Azure Active Directory Conditional Access

Can someone clarify which feature we should use?.....
Configurable token lifetimes or Azure AD conditional Access?...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 02ff3d62-dc0e-ad0c-f5ae-418337cf31e4
Version Independent ID: d50952b5-6b98-c40d-d3a3-f9cbec58dd28
Content: Configurable token lifetimes in Azure Active Directory
Content Source: articles/active-directory/develop/active-directory-configurable-token-lifetimes.md
Service: active-directory
GitHub Login: @CelesteDG
Microsoft Alias: celested

@ichkoj If possible you should use conditional access because configurable token lifetimes are being discontinued, as mentioned in the article. If you need this to work right away, however, you can start with configurable token lifetimes and switch to conditional access when the configurable token lifetimes feature is deprecated and the new conditional access feature becomes available.

This is also explained in the doc.

After hearing from customers during the preview, we're planning to replace this functionality with a new feature in Azure Active Directory Conditional Access. Once the new feature is complete, this functionality will eventually be deprecated after a notification period. If you use the Configurable Token Lifetime policy, be prepared to switch to the new Conditional Access feature once it's available.

Hope this answers your question! If you'd like to continue the discussion please leave a comment, re-open the issue, or open a new issue and I will gladly continue the conversation.

Any ETA update on Token Lifetime features being available in AAD Condition Access?
Thanks.


fix(portal): Use modal for confirmation dialogs

Still need to replace a few more data-confirm actions (have an issue with HTML  positioning when it's defined inside Tailwind tables.)
Closes https://github.com/firezone/firezone/issues/5794
Closes #5766

Would it be possible to fix the description so it closes relevant PRs?

@AndrewDryga I spent a lot of time working through an issue with Flowbite data- triggers and Phoenix on Probe recently. Essentially, I found that if an element is updated() in the DOM by Phoenix, Flowbite doesn't reinitialize its listeners. See this hook I added as a workaround.
I'm not sure if it's an issue here, but something to take note of. We may need to use the Phoenix-native JS helpers to manipulate the DOM in the future.

@jamilbk we don't use Flowbite data- helpers, I know they do not work with LiveView (thats why we have our own tabs Hook to fix them).

Much improved UX here! Just looks like a few CI checks that need to be cleaned up and LGTM


TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/28043

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/28043

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/41662


perf($parse): improve performance of assignment expressions

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Minor perf improvement.
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

Other information:
There was a ~5% improvement in the parsed-expressions-bp/assignment benchmark (which only contains assignment expressions). In real-world applications, the time spent in assignment expressions will be a tiny fragment of the overall processing time (so this change is hardly expected to make any noticeable difference).
Related to #14951.

Btw, this essentially voids the prototype check if any of the banned prototypes changes dynamically (i.e. after we have cached it). Considering these checks are not security-related and that dynamically changing prototypes of core constructors is likely to break other things as well, I don't think it should be a concern.
/fyi @petebacondarwin

I note that we were already caching Function.prototype.call, Function.prototype.apply and Function.prototype.bind. So I am confident that this is OK. LGTM.
Can we get another LGTM from someone, perhaps @IgorMinar or @lgalfaso?

LGTM


⚠ Bofrost.fr has degraded performance

In 202209b, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 919 ms

Resolved: Bofrost.fr performance has improved in e489314 after 6 minutes.


docker

A quick Dockerfile from which to start.
Puts dependencies first so that layer can be reused by the later one (where the app code changes). Tests would similarly run after dependency install so you're able to more rapidly test with a container setup.

moved to develop branch


Too many connections (max=250) WARNING (how to fix?)

Hi!
With dnscrypt-proxy 2.0.19, I got this "Too many connections (max=250) WARNING " in my
log-file of dnscrypt-proxy.
How can I fix this?
In my config file of dnscrypt-proxy, I have the standard value.
max_clients = 250
Here's the output of my log-file of dnscrypt-proxy:
[2018-12-28 06:57:23] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-28 06:57:23] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-28 06:57:23] [NOTICE] Dropping privileges
[2018-12-28 06:57:23] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-28 06:57:23] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-28 06:57:23] [NOTICE] Now listening to <IP_ADDRESS>:5300 [UDP]
[2018-12-28 06:57:23] [NOTICE] Now listening to <IP_ADDRESS>:5300 [TCP]
[2018-12-28 06:57:23] [NOTICE] [aaflalo-me] OK (DoH) - rtt: 21ms
[2018-12-28 06:57:23] [NOTICE] [arvind-io] OK (crypto v2) - rtt: 143ms
[2018-12-28 06:57:23] [NOTICE] [de.dnsmaschine.net] OK (crypto v2) - rtt: 22ms
[2018-12-28 06:57:23] [NOTICE] [dnscrypt.eu-dk] OK (crypto v2) - rtt: 14ms
[2018-12-28 06:57:23] [NOTICE] [dnscrypt.eu-nl] OK (crypto v2) - rtt: 20ms
[2018-12-28 06:57:23] [NOTICE] [dnscrypt.me] OK (crypto v2) - rtt: 21ms
[2018-12-28 06:57:23] [NOTICE] [dnscrypt.nl-ns0] OK (crypto v2) - rtt: 19ms
[2018-12-28 06:57:23] [NOTICE] [dnscrypt.uk-ipv4] OK (crypto v2) - rtt: 29ms
[2018-12-28 06:57:23] [NOTICE] [doh-blahdns-de] OK (DoH) - rtt: 62ms
[2018-12-28 06:57:24] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:24] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:24] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:24] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:25] [NOTICE] [doh-blahdns] OK (DoH) - rtt: 799ms
[2018-12-28 06:57:25] [NOTICE] [doh-crypto-sx] OK (DoH) - rtt: 50ms
[2018-12-28 06:57:25] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:29] [NOTICE] [gridns-sg] OK (DoH) - rtt: 258ms

New log output:
[2018-12-28 06:57:02] [NOTICE] Stopped.
[2018-12-28 06:57:22] [NOTICE] System DNS configuration not usable yet, exceptionally resolving [raw.githubusercontent.com] using fallback resolver [<IP_ADDRESS>:53]
[2018-12-28 06:57:23] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-28 06:57:23] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-28 06:57:23] [NOTICE] Dropping privileges
[2018-12-28 06:57:23] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-28 06:57:23] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-28 06:57:23] [NOTICE] Now listening to <IP_ADDRESS>:5300 [UDP]
[2018-12-28 06:57:23] [NOTICE] Now listening to <IP_ADDRESS>:5300 [TCP]
[2018-12-28 06:57:23] [NOTICE] [aaflalo-me] OK (DoH) - rtt: 21ms
[2018-12-28 06:57:23] [NOTICE] [arvind-io] OK (crypto v2) - rtt: 143ms
[2018-12-28 06:57:23] [NOTICE] [de.dnsmaschine.net] OK (crypto v2) - rtt: 22ms
[2018-12-28 06:57:23] [NOTICE] [dnscrypt.eu-dk] OK (crypto v2) - rtt: 14ms
[2018-12-28 06:57:23] [NOTICE] [dnscrypt.eu-nl] OK (crypto v2) - rtt: 20ms
[2018-12-28 06:57:23] [NOTICE] [dnscrypt.me] OK (crypto v2) - rtt: 21ms
[2018-12-28 06:57:23] [NOTICE] [dnscrypt.nl-ns0] OK (crypto v2) - rtt: 19ms
[2018-12-28 06:57:23] [NOTICE] [dnscrypt.uk-ipv4] OK (crypto v2) - rtt: 29ms
[2018-12-28 06:57:23] [NOTICE] [doh-blahdns-de] OK (DoH) - rtt: 62ms
[2018-12-28 06:57:24] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:24] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:24] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:24] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:25] [NOTICE] [doh-blahdns] OK (DoH) - rtt: 799ms
[2018-12-28 06:57:25] [NOTICE] [doh-crypto-sx] OK (DoH) - rtt: 50ms
[2018-12-28 06:57:25] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:29] [NOTICE] [gridns-sg] OK (DoH) - rtt: 258ms
[2018-12-28 06:57:30] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:30] [WARNING] Too many connections (max=250)
[2018-12-28 06:57:30] [NOTICE] [publicarray-au] OK (crypto v2) - rtt: 482ms
[2018-12-28 06:57:35] [NOTICE] [securedns] OK (crypto v1) - rtt: 20ms
[2018-12-28 06:57:36] [NOTICE] [sfw.scaleway-fr] OK (crypto v2) - rtt: 170ms
[2018-12-28 06:57:36] [NOTICE] Server with the lowest initial latency: dnscrypt.eu-dk (rtt: 14ms)
[2018-12-28 06:57:36] [NOTICE] dnscrypt-proxy is ready - live servers: 15
[2018-12-28 08:44:13] [WARNING] Too many connections (max=250)
[2018-12-28 08:44:13] [WARNING] Too many connections (max=250)
[2018-12-28 08:44:13] [WARNING] Too many connections (max=250)
[2018-12-28 08:44:13] [WARNING] Too many connections (max=250)
[2018-12-28 08:44:53] [WARNING] Too many connections (max=250)
[2018-12-28 08:45:55] [WARNING] Too many connections (max=250)
[2018-12-28 10:42:45] [WARNING] Too many connections (max=250)
[2018-12-28 10:43:06] [WARNING] Too many connections (max=250)
[2018-12-28 10:43:26] [WARNING] Too many connections (max=250)
[2018-12-28 10:43:47] [WARNING] Too many connections (max=250)
[2018-12-28 10:44:26] [WARNING] Too many connections (max=250)
[2018-12-28 10:57:54] [NOTICE] Server with the lowest initial latency: dnscrypt.eu-dk (rtt: 13ms)
[2018-12-28 11:15:29] [WARNING] Too many connections (max=250)
[2018-12-28 11:15:29] [WARNING] Too many connections (max=250)
[2018-12-28 11:15:29] [WARNING] Too many connections (max=250)
[2018-12-28 11:15:29] [WARNING] Too many connections (max=250)
[2018-12-28 11:15:39] [WARNING] Too many connections (max=250)
[2018-12-28 11:15:49] [WARNING] Too many connections (max=250)
[2018-12-28 11:16:00] [WARNING] Too many connections (max=250)
[2018-12-28 11:16:10] [WARNING] Too many connections (max=250)
[2018-12-28 11:16:20] [WARNING] Too many connections (max=250)
[2018-12-28 11:16:31] [WARNING] Too many connections (max=250)
[2018-12-28 11:16:41] [WARNING] Too many connections (max=250)
[2018-12-28 11:16:51] [WARNING] Too many connections (max=250)
[2018-12-28 11:17:01] [WARNING] Too many connections (max=250)
[2018-12-28 11:17:11] [WARNING] Too many connections (max=250)
[2018-12-28 11:17:21] [WARNING] Too many connections (max=250)
[2018-12-28 11:17:32] [WARNING] Too many connections (max=250)
[2018-12-28 11:17:42] [WARNING] Too many connections (max=250)
[2018-12-28 11:17:52] [WARNING] Too many connections (max=250)
[2018-12-28 11:18:02] [WARNING] Too many connections (max=250)
[2018-12-28 11:18:13] [WARNING] Too many connections (max=250)
[2018-12-28 11:18:22] [WARNING] Too many connections (max=250)
[2018-12-28 12:19:48] [WARNING] Too many connections (max=250)
[2018-12-28 12:19:59] [WARNING] Too many connections (max=250)
[2018-12-28 12:20:10] [WARNING] Too many connections (max=250)
[2018-12-28 12:20:21] [WARNING] Too many connections (max=250)
[2018-12-28 12:20:32] [WARNING] Too many connections (max=250)
[2018-12-28 12:21:01] [WARNING] Too many connections (max=250)
[2018-12-28 12:21:19] [WARNING] Too many connections (max=250)
[2018-12-28 12:21:29] [WARNING] Too many connections (max=250)
[2018-12-28 12:21:38] [WARNING] Too many connections (max=250)
[2018-12-28 12:21:43] [WARNING] Too many connections (max=250)
[2018-12-28 12:21:49] [WARNING] Too many connections (max=250)
[2018-12-28 12:22:00] [WARNING] Too many connections (max=250)
[2018-12-28 12:22:05] [WARNING] Too many connections (max=250)
[2018-12-28 12:22:10] [WARNING] Too many connections (max=250)
[2018-12-28 12:22:20] [WARNING] Too many connections (max=250)
[2018-12-28 14:11:18] [NOTICE] Stopped.
[2018-12-28 15:45:28] [NOTICE] Network not available yet -- waiting...
[2018-12-28 15:45:37] [NOTICE] Network connectivity detected
[2018-12-28 15:45:37] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-28 15:45:37] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-28 15:45:37] [NOTICE] Dropping privileges
[2018-12-28 15:45:37] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-28 15:45:37] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-28 15:45:37] [NOTICE] Now listening to <IP_ADDRESS>:5300 [UDP]
[2018-12-28 15:45:37] [NOTICE] Now listening to <IP_ADDRESS>:5300 [TCP]
[2018-12-28 15:45:37] [NOTICE] [aaflalo-me] OK (DoH) - rtt: 19ms
[2018-12-28 15:45:39] [NOTICE] [arvind-io] TIMEOUT
[2018-12-28 15:45:39] [NOTICE] [de.dnsmaschine.net] OK (crypto v2) - rtt: 22ms
[2018-12-28 15:45:39] [NOTICE] [dnscrypt.eu-dk] OK (crypto v2) - rtt: 15ms
[2018-12-28 15:45:39] [NOTICE] [dnscrypt.eu-nl] OK (crypto v2) - rtt: 20ms
[2018-12-28 15:45:39] [NOTICE] [dnscrypt.me] OK (crypto v2) - rtt: 21ms
[2018-12-28 15:45:39] [NOTICE] [dnscrypt.nl-ns0] OK (crypto v2) - rtt: 19ms
[2018-12-28 15:45:39] [NOTICE] [dnscrypt.uk-ipv4] OK (crypto v2) - rtt: 27ms
[2018-12-28 15:45:39] [NOTICE] [doh-blahdns-de] OK (DoH) - rtt: 60ms
[2018-12-28 15:45:41] [NOTICE] [doh-blahdns] OK (DoH) - rtt: 801ms
[2018-12-28 15:45:41] [NOTICE] [doh-crypto-sx] OK (DoH) - rtt: 48ms
[2018-12-28 15:45:46] [NOTICE] [ibksturm] TIMEOUT
[2018-12-28 15:45:46] [NOTICE] [publicarray-au] TIMEOUT
[2018-12-28 15:45:51] [NOTICE] [securedns] TIMEOUT
[2018-12-28 15:45:51] [NOTICE] [sfw.scaleway-fr] TIMEOUT
[2018-12-28 15:45:51] [NOTICE] Server with the lowest initial latency: dnscrypt.eu-dk (rtt: 15ms)
[2018-12-28 15:45:51] [NOTICE] dnscrypt-proxy is ready - live servers: 10
[2018-12-28 18:38:16] [NOTICE] Stopped.
[2018-12-29 08:16:24] [NOTICE] Network not available yet -- waiting...
[2018-12-29 08:16:29] [NOTICE] Network connectivity detected
[2018-12-29 08:16:29] [NOTICE] System DNS configuration not usable yet, exceptionally resolving [raw.githubusercontent.com] using fallback resolver [<IP_ADDRESS>:53]
[2018-12-29 08:16:30] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-29 08:16:30] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-29 08:16:30] [NOTICE] Dropping privileges
[2018-12-29 08:16:30] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-29 08:16:30] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-29 08:16:30] [NOTICE] Now listening to <IP_ADDRESS>:5300 [UDP]
[2018-12-29 08:16:30] [NOTICE] Now listening to <IP_ADDRESS>:5300 [TCP]
[2018-12-29 08:16:30] [NOTICE] [aaflalo-me] OK (DoH) - rtt: 21ms
[2018-12-29 08:16:30] [NOTICE] [arvind-io] OK (crypto v2) - rtt: 164ms
[2018-12-29 08:16:30] [NOTICE] [de.dnsmaschine.net] OK (crypto v2) - rtt: 24ms
[2018-12-29 08:16:30] [NOTICE] [dnscrypt.eu-dk] OK (crypto v2) - rtt: 16ms
[2018-12-29 08:16:30] [NOTICE] [dnscrypt.eu-nl] OK (crypto v2) - rtt: 21ms
[2018-12-29 08:16:30] [NOTICE] [dnscrypt.me] OK (crypto v2) - rtt: 21ms
[2018-12-29 08:16:30] [NOTICE] [dnscrypt.nl-ns0] OK (crypto v2) - rtt: 20ms
[2018-12-29 08:16:30] [NOTICE] [dnscrypt.uk-ipv4] OK (crypto v2) - rtt: 26ms
[2018-12-29 08:16:31] [NOTICE] [doh-blahdns-de] OK (DoH) - rtt: 61ms
[2018-12-29 08:16:32] [NOTICE] [doh-blahdns] OK (DoH) - rtt: 834ms
[2018-12-29 08:16:32] [NOTICE] [doh-crypto-sx] OK (DoH) - rtt: 53ms
[2018-12-29 08:16:40] [NOTICE] [ibksturm] TIMEOUT
[2018-12-29 08:16:40] [NOTICE] [publicarray-au] TIMEOUT
[2018-12-29 08:16:45] [NOTICE] [securedns] OK (crypto v1) - rtt: 19ms
[2018-12-29 08:16:45] [NOTICE] [sfw.scaleway-fr] OK (crypto v2) - rtt: 40ms
[2018-12-29 08:16:45] [NOTICE] Server with the lowest initial latency: dnscrypt.eu-dk (rtt: 16ms)
[2018-12-29 08:16:45] [NOTICE] dnscrypt-proxy is ready - live servers: 13
[2018-12-29 12:16:55] [NOTICE] [ibksturm] TIMEOUT
[2018-12-29 12:16:56] [NOTICE] [publicarray-au] OK (crypto v2) - rtt: 309ms
[2018-12-29 12:17:02] [NOTICE] Server with the lowest initial latency: dnscrypt.eu-dk (rtt: 15ms)
[2018-12-29 12:45:19] [WARNING] Too many connections (max=250)
[2018-12-29 12:45:19] [WARNING] Too many connections (max=250)
[2018-12-29 12:45:19] [WARNING] Too many connections (max=250)
[2018-12-29 12:45:19] [WARNING] Too many connections (max=250)
[2018-12-29 12:45:39] [WARNING] Too many connections (max=250)
[2018-12-29 12:47:19] [WARNING] Too many connections (max=250)
[2018-12-29 16:17:12] [NOTICE] [ibksturm] TIMEOUT
[2018-12-29 16:17:19] [NOTICE] Server with the lowest initial latency: dnscrypt.eu-dk (rtt: 17ms)
[2018-12-29 18:40:46] [NOTICE] Stopped.
[2018-12-29 21:18:24] [NOTICE] Network not available yet -- waiting...
[2018-12-29 21:18:33] [NOTICE] Network connectivity detected
[2018-12-29 21:18:33] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-29 21:18:33] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-29 21:18:33] [NOTICE] Dropping privileges
[2018-12-29 21:18:33] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-29 21:18:33] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-29 21:18:33] [NOTICE] Now listening to <IP_ADDRESS>:5300 [UDP]
[2018-12-29 21:18:33] [NOTICE] Now listening to <IP_ADDRESS>:5300 [TCP]
[2018-12-29 21:18:33] [NOTICE] [aaflalo-me] OK (DoH) - rtt: 19ms
[2018-12-29 21:18:33] [NOTICE] [arvind-io] OK (crypto v2) - rtt: 142ms
[2018-12-29 21:18:33] [NOTICE] [de.dnsmaschine.net] OK (crypto v2) - rtt: 21ms
[2018-12-29 21:18:33] [NOTICE] [dnscrypt.eu-dk] OK (crypto v2) - rtt: 13ms
[2018-12-29 21:18:33] [NOTICE] [dnscrypt.eu-nl] OK (crypto v2) - rtt: 19ms
[2018-12-29 21:18:34] [NOTICE] [dnscrypt.me] OK (crypto v2) - rtt: 21ms
[2018-12-29 21:18:34] [NOTICE] [dnscrypt.nl-ns0] OK (crypto v2) - rtt: 19ms
[2018-12-29 21:18:34] [NOTICE] [dnscrypt.uk-ipv4] OK (crypto v2) - rtt: 28ms
[2018-12-29 21:18:34] [NOTICE] [doh-blahdns-de] OK (DoH) - rtt: 71ms
[2018-12-29 21:18:35] [NOTICE] [doh-blahdns] OK (DoH) - rtt: 811ms
[2018-12-29 21:18:36] [NOTICE] [doh-crypto-sx] OK (DoH) - rtt: 50ms
[2018-12-29 21:18:44] [NOTICE] [ibksturm] TIMEOUT
[2018-12-29 21:18:44] [NOTICE] [publicarray-au] TIMEOUT
[2018-12-29 21:18:49] [NOTICE] [securedns] TIMEOUT
[2018-12-29 21:18:49] [NOTICE] [sfw.scaleway-fr] TIMEOUT
[2018-12-29 21:18:49] [NOTICE] Server with the lowest initial latency: dnscrypt.eu-dk (rtt: 13ms)
[2018-12-29 21:18:49] [NOTICE] dnscrypt-proxy is ready - live servers: 11
[2018-12-30 00:56:57] [NOTICE] Stopped.
[2018-12-30 11:26:08] [NOTICE] Network not available yet -- waiting...
[2018-12-30 11:26:12] [NOTICE] Network connectivity detected
[2018-12-30 11:26:12] [NOTICE] System DNS configuration not usable yet, exceptionally resolving [raw.githubusercontent.com] using fallback resolver [<IP_ADDRESS>:53]
[2018-12-30 11:26:34] [NOTICE] System DNS configuration not usable yet, exceptionally resolving [raw.githubusercontent.com] using fallback resolver [<IP_ADDRESS>:53]
[2018-12-30 11:26:54] [NOTICE] System DNS configuration not usable yet, exceptionally resolving [download.dnscrypt.info] using fallback resolver [<IP_ADDRESS>:53]
[2018-12-30 11:26:55] [WARNING] TLS handshake failure - Try changing or deleting the tls_cipher_suite value in the configuration file
[2018-12-30 11:26:55] [CRITICAL] Unable to use source [public-resolvers]: [Get https://download.dnscrypt.info/resolvers-list/v2/public-resolvers.md: remote error: tls: handshake failure]
[2018-12-30 11:26:55] [FATAL] No servers configured
[2018-12-30 11:29:15] [NOTICE] System DNS configuration not usable yet, exceptionally resolving [raw.githubusercontent.com] using fallback resolver [<IP_ADDRESS>:53]
[2018-12-30 11:29:15] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-30 11:29:15] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-30 11:29:15] [NOTICE] Dropping privileges
[2018-12-30 11:29:15] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-30 11:29:15] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-30 11:29:15] [NOTICE] Now listening to <IP_ADDRESS>:5300 [UDP]
[2018-12-30 11:29:15] [NOTICE] Now listening to <IP_ADDRESS>:5300 [TCP]
[2018-12-30 11:29:15] [NOTICE] [aaflalo-me] OK (DoH) - rtt: 20ms
[2018-12-30 11:29:16] [NOTICE] [arvind-io] OK (crypto v2) - rtt: 146ms
[2018-12-30 11:29:16] [NOTICE] [de.dnsmaschine.net] OK (crypto v2) - rtt: 24ms
[2018-12-30 11:29:16] [NOTICE] [dnscrypt.eu-dk] OK (crypto v2) - rtt: 13ms
[2018-12-30 11:29:16] [NOTICE] [dnscrypt.eu-nl] OK (crypto v2) - rtt: 19ms
[2018-12-30 11:29:16] [NOTICE] [dnscrypt.me] OK (crypto v2) - rtt: 20ms
[2018-12-30 11:29:16] [NOTICE] [dnscrypt.nl-ns0] OK (crypto v2) - rtt: 17ms
[2018-12-30 11:29:16] [NOTICE] [dnscrypt.uk-ipv4] OK (crypto v2) - rtt: 27ms
[2018-12-30 11:29:16] [NOTICE] [doh-blahdns-de] OK (DoH) - rtt: 63ms
[2018-12-30 11:29:17] [NOTICE] [doh-blahdns] OK (DoH) - rtt: 800ms
[2018-12-30 11:29:18] [NOTICE] [doh-crypto-sx] OK (DoH) - rtt: 51ms
[2018-12-30 11:29:26] [NOTICE] [ibksturm] TIMEOUT
[2018-12-30 11:29:26] [NOTICE] [publicarray-au] OK (crypto v2) - rtt: 350ms
[2018-12-30 11:29:31] [NOTICE] [securedns] OK (crypto v1) - rtt: 138ms
[2018-12-30 11:29:32] [NOTICE] [sfw.scaleway-fr] OK (crypto v2) - rtt: 208ms
[2018-12-30 11:29:32] [NOTICE] Server with the lowest initial latency: dnscrypt.eu-dk (rtt: 13ms)
[2018-12-30 11:29:32] [NOTICE] dnscrypt-proxy is ready - live servers: 14
[2018-12-30 15:29:45] [NOTICE] [ibksturm] TIMEOUT
[2018-12-30 15:29:55] [NOTICE] Server with the lowest initial latency: dnscrypt.eu-dk (rtt: 78ms)

How to fix?
TLS handshake failure - Try changing or deleting the tls_cipher_suite value in the configuration file
in dnscrypt-proxy config file I use:
tls_disable_session_tickets = true
tls_cipher_suite = [52392, 49199]

I removed the server ibksturm from my dnscrypt-config file.
Now the logoutput is:
[2018-12-30 17:46:09] [NOTICE] Stopped.
[2018-12-30 17:46:09] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-30 17:46:09] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-30 17:46:09] [NOTICE] Dropping privileges
[2018-12-30 17:46:09] [NOTICE] Source [public-resolvers.md] loaded
[2018-12-30 17:46:09] [NOTICE] dnscrypt-proxy 2.0.19
[2018-12-30 17:46:09] [NOTICE] Now listening to <IP_ADDRESS>:5300 [UDP]
[2018-12-30 17:46:09] [NOTICE] Now listening to <IP_ADDRESS>:5300 [TCP]
[2018-12-30 17:46:10] [NOTICE] [aaflalo-me] OK (DoH) - rtt: 25ms
[2018-12-30 17:46:10] [NOTICE] [arvind-io] OK (crypto v2) - rtt: 142ms
[2018-12-30 17:46:10] [NOTICE] [de.dnsmaschine.net] OK (crypto v2) - rtt: 20ms
[2018-12-30 17:46:10] [NOTICE] [dnscrypt.eu-dk] OK (crypto v2) - rtt: 15ms
[2018-12-30 17:46:10] [NOTICE] [dnscrypt.eu-nl] OK (crypto v2) - rtt: 20ms
[2018-12-30 17:46:10] [NOTICE] [dnscrypt.me] OK (crypto v2) - rtt: 21ms
[2018-12-30 17:46:10] [NOTICE] [dnscrypt.nl-ns0] OK (crypto v2) - rtt: 19ms
[2018-12-30 17:46:10] [NOTICE] [dnscrypt.uk-ipv4] OK (crypto v2) - rtt: 28ms
[2018-12-30 17:46:10] [NOTICE] [doh-blahdns-de] OK (DoH) - rtt: 70ms
[2018-12-30 17:46:12] [NOTICE] [doh-blahdns] OK (DoH) - rtt: 771ms
[2018-12-30 17:46:12] [NOTICE] [doh-crypto-sx] OK (DoH) - rtt: 54ms
[2018-12-30 17:46:18] [NOTICE] [publicarray-au] OK (crypto v2) - rtt: 314ms
[2018-12-30 17:46:23] [NOTICE] [securedns] OK (crypto v1) - rtt: 18ms
[2018-12-30 17:46:23] [NOTICE] [sfw.scaleway-fr] OK (crypto v2) - rtt: 31ms
[2018-12-30 17:46:23] [NOTICE] Server with the lowest initial latency: dnscrypt.eu-dk (rtt: 15ms)
[2018-12-30 17:46:23] [NOTICE] dnscrypt-proxy is ready - live servers: 14
I hope that fixed it.


TraceLoggingEnhancer.setCurrentTraceId is not in correctly formatted.

The class  RequestContextScope.java class  is not formatting the traceId correctly.  According to the javadoc the TraceLoggingEnhancer.setCurrentTraceId expects  projects/[PROJECT_ID]/traces/[TRACE_ID], while we are just supplying [TRACE_ID]  within https://github.com/GoogleCloudPlatform/jetty-runtime/blob/master/jetty9-base/src/main/java/com/google/cloud/runtimes/jetty9/RequestContextScope.java
This was changed in the logging library with this pull request:
https://github.com/googleapis/google-cloud-java/pull/3301
For more information see this blog post: https://cloud.google.com/blog/products/gcp/viewing-trace-spans-and-request-logs-in-multi-project-deployments
Thanks

PR #244 has been merged, can this issue be closed?


Constant name "plain_user" doesn't conform to UPPER_CASE naming style

https://github.com/lbonanomi/scripts/blob/d4369094fb277f5c08521500b3186b83b4c530b9/jenkins_webhook.py#L11

Issues for naming style are now ignored.


Create initial VDS tests

Signed-off-by: Chris Wahl<EMAIL_ADDRESS>

Looking good here! (Not that I tested VDS remediation)

Config.ps1

Line 10, add a comment for $config.scope.vds

Config.Tests.ps1

Line 96 could be $VDSKeys :smile:

:+1:

Good eye @brianbunke ... this is why I made the needs review tag, haha! :)
You can also comment the lines of code directly by reviewing the code and clicking the + next to the line. Not that your method was bad, I just wasn't sure if you knew about that feature.

Fixed and merged.


Update index_5.vb with example of ReDim statement

Title
Add a correct example for the ReDim statement
Summary
The previous example contained no use of the ReDim statement as the preceding paragraph implied.  It was an example of a List collection type.  This is an article about arrays, not Lists.
Fixes #Issue_Number
N/A
Details
Summary should be sufficient.
Suggested Reviewers
If you know who should review this, use '@' to request a review.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

The code in Arrays in Visual Basic, section Creating an Array is definitely wrong, but I don't think this is the way to fix it, because that would break the article that uses this snippet correctly: Collection Initializers (Visual Basic).
I'll look at this further and if I find something, I'll continue in the issue you created about this (https://github.com/dotnet/docs/issues/2526).

That sounds fair.  Go ahead and fix the article under #2526.   This is my first attempt at contributing and I didn't realize how the snippets were setup.  Perhaps it would be better if someone more experienced fixes it until I learn more about  how the snippets are linked into articles.   I appreciate the quickness with which the issue was reviewed.

Thank you @Shawn1874 and @svick for looking into this. I'm closing this one and commenting on the new PR #2526.


[AF-544] Allow close a expanded dock via API

@paulovmr thanks for the review! fixed!

Wondering about the purpose of the "DeSelect" feature...
What about toggle feature? If this is about close/expand.. why not use setExpand or just close() or hide?

@porcelli deselect and expand API will be used by bookmarkable URLs. Even if we use to expand or close without the reference for the dock, we should pass with dock area we are wanna close.
Is that ok for you?


Use external modules within internal module

I am trying to use external module within an internal module but Visual Studio won't let me do that.
As soon as I add an import x = require('xxx'); the internal module no longer consider the file to be part of the module and all exports are not referenced by the module anymore.
I have read the Module Documentation but I could not find the scenario of using external modules within an internal module.
As described in my post, I want to create a ViewModel module that will contain all the ViewModels of my application.
The application will use Knockout in order to insure the communication between the Views and the ViewModel and I therefore need to import the knockout module.
// HomePageViewModel.ts
import ko = require('knockout'); // When adding this line I can no longer access HomePageViewModel from the internal ViewModels module
module ViewModels {
    export class HomePageViewModel {
        constructor() {
            console.log('Creating HomePageViewModel');
        }
    }
}

// ViewModelFactories.ts
module OtherModule {
    export class ViewModelFactories {
        public static CreateHomePageViewModel(): ViewModels.HomePageViewModel {
            return new ViewModels.HomePageViewModel();
        }
    }
}

When importing the external module knockout, the internal module no longer exports the HomePageViewModel class.
Thank you for your help.

@RyanCavanaugh For instantiated modules, this is true. But the compiler complains in non-instantiated modules, too, which means it is impossible to describe global types in an ambient declaration if those global types refer to a type that comes from some other external module:
/// <reference path="../external/external.d.ts" />

declare module foo {
	// TS Error: Import declarations in an internal module cannot reference an external module.
	import request = require('external/request');

	interface RequestError extends Error {
		// …

		/**
		 * The response object for the request.
		 */
		response: request.IResponse;
	}

	// …
}

declare module 'foo/Bar' {
	// …
	class Bar {
		error: foo.RequestError;
		// …
	}
	export = Bar;
}

// …

The internal module foo could be written as an external module, but given the way other declaration files are authored, I think that would be considered an anti-pattern at this point.

@csnover is it expected that the JavaScript molded by these definitions be accessed as both an internal module (e.g. include the js in a script tag) or required (either using an AMD loader or commonjs)?
one pattern that i have seen is to define all your typeings in an internal module, and then have an external module to expose them as well:
declare module foo {
     function f ();
     var x;
]
declare module "foo" {
    export = foo;
}

The main problem is that external modules and internal modules are really different, the shared syntax does not help here obviously. The compiler can understand external modules consuming internal modules, as they just represent global objects, but it can not understand what the opposite means in absence of a loader system.
Since your code is accessible both as a module, or addition to the global namespace, i assume your dependencies are as well (e.g. 'external/request'), if your dependencies expose an internal module (something along the lines i mentioned above) then that should solve the problem.
We have the same problem with typescript definitions, and the way we worked around it is by using two files one internal and one external, though we have no dependencies that we expose in the .d.ts.

@csnover is it expected that the JavaScript molded by these definitions be accessed as both an internal module (e.g. include the js in a script tag) or required (either using an AMD loader or commonjs)?

No, always required. The internal type foo is just for the type system, it’s never related to any real code. See https://github.com/theintern/intern/blob/typings/typings/leadfoot/leadfoot.d.ts#L5-L51 for a concrete example.

if your dependencies expose an internal module (something along the lines i mentioned above) then that should solve the problem.

Unfortunately I don’t think it’s safe to presume that the way the external dependencies are structured could be changed, as they are, well, external.
In this concrete example above, the dependencies come from well-structured modular code, and it would be wrong for that upstream project to move all these interfaces out of external modules.

What I understand is there no option to create standalone node.js application consisting of internal modules? As using node.js requires importing external dependencies (like streams, events etc.) hence every module using these becomes external module. It's even more restrictive, extending this policy on non-module TS files, so that any file containing require can't be used as <reference>.
Correct me if I'm wrong, but this makes internal modules completely useless, and the only hope is in Suggestion: multi-file external modules #17.

@csnover sorry for the late reply. I am a bit confused. so why do you need the internal module for your typings?

As a convenience for generic interfaces that are used in multiple places across an entire package but don’t emit code. The alternative is to create some a separate interfaces/typedefs module, which could be OK (and would improve portability), but just runs against how these things are typically modelled right now in DefinitelyTyped. I’m mostly OK moving to that model if that’s what everyone thinks is best, but I’m sure some people will complain about all the extra typing they have to do whenever they want to use one of these generic interfaces (most developers are incredibly lazy).

i see. thanks for the explanation. The problem is internal modules should have been called namespaces :). i do not think the two really mesh well just because of dependencies in external modules, and the open-ended nature of internal modules.

I do not think there is more actions here that are not already captured in other issues. please reopen a new issue if this is not the case.


REPORT - Package build week 20221114 - 2022118

Continuation of https://github.com/open-rmf/rmf/issues/265

20221114

Still pending to release for humble https://github.com/ros/rosdistro/pull/35285
https://github.com/ros/rosdistro/pull/35300

20221115
 nlohmann_json_schema_validator_vendor

Fixed commit of vendored package to point to json-dev <3.8

Releaseing
https://github.com/ros/rosdistro/pull/35320

20221116
After releasing https://github.com/ros/rosdistro/pull/35320
rmf_websocket
rmf_task_sequence  started to fail


"check" fails as ssh commands are missing

seems like the Dockerfile needs an update
resource script '/opt/resource/check []' failed: exit status 2

stderr:
2017-06-22 15:21:46 - Configuring git credentials
/opt/resource/helpers/git.sh: line 9: ssh-agent: command not found
/opt/resource/helpers/git.sh: line 12: ssh-add: command not found

I've got a PR up to fix that problem, but unfortunately it stops when checking out the git repo. Not sure what is wrong there just yet

@gijsboer I'm btw using this resource now productively https://github.com/zarplata/concourse-git-bitbucket-pr-resource . I added support for Bitbucket Cloud and it also supports self-hosted Bitbucket Server


fix(#44): Failed to create napi buffer, when use dataframe.toJson().

Failed to create napi buffer, when use dataframe.toJson().

@ryanrussell @dannyvankooten @YuRiTan pls review code,if you have time, thanks.

@chaozwn , Please don't ping people to your 3 minutes old PR. We come to it in due time.

@chaozwn , Please don't ping people to your 3 minutes old PR. We come to it in due time.

I am sorry for my behavior this time. I was affected by the project and felt a bit anxious. I will pay attention to it in the future. Thank you for your response.


Query builder from a relationship should always scope the query

Laravel Version: 5.8.14
PHP Version: 7.2.17
Database Driver & Version: sqlite 3.22

Description:
I have the following query:
return auth()->user()->tasks()
        ->select(['id', 'text', 'points', 'type', 'completed'])
        ->whereDate('date', $date)->orWhere(function ($query) use ($date) {
            $query->whereDate('date', '<', $date)->where('completed', false);
        })->get();

This query is expected to return the authenticated user's tasks that have not been completed or are due today.
However, the orWhere() condition is applied on the same level as the where "tasks"."user_id" = 5.
In my opinion, such queries should always be scoped as per the relationship, regardless of any orWhere() queries. The first line of the query says "the authenticated user's tasks", so the developer should not have to worry about the rest of the query breaking that condition.
A solution is to wrap all of the where conditions in a pair of brackets.
This query works as expected:
return auth()->user()->tasks()
        ->select(['id', 'text', 'points', 'type', 'completed'])
        ->where(function ($query) use ($date) {
            $query->whereDate('date', $date)->orWhere(function ($query) use ($date) {
                $query->whereDate('date', '<', $date)->where('completed', false);
            });
        })->get();

Here are the queries in SQL:

The original query
select
  "id",
  "text",
  "points",
  "type",
  "completed"
from
  "tasks"
where
  "tasks"."user_id" = 5
  and "tasks"."user_id" is not null
  and strftime('%Y-%m-%d', "date") = cast("2019-05-11" as text)
  or (
    strftime('%Y-%m-%d', "date") < cast("2019-05-11" as text)
    and "completed" = 0
  )

The modified query
select
  "id",
  "text",
  "points",
  "type",
  "completed"
from
  "tasks"
where
  "tasks"."user_id" = 5
  and "tasks"."user_id" is not null
  and (
    strftime('%Y-%m-%d', "date") = cast("2019-05-11" as text)
    or (
      strftime('%Y-%m-%d', "date") < cast("2019-05-11" as text)
      and "completed" = 0
    )
  )

Please see #28207 why this is the expected behavior and a complicated issue.

Wrapping all wheres in a where() closure does fix this, though I see how fixing it could break constraints that come with a relationship
public function notes()
{
    return $this->hasMany(Note::class)
        ->where('type', 'private')->orWhere('type', 'hidden');
}

I didn't find why this is the expected behavior in that thread though. The fact that fixing this could be hard doesn't mean it's the expected behavior.
Having a separate method for where inside a relationship could solve the issue with relationships. Or perhaps something like
public function notes()
{
    return $this->hasMany(App\Note::class)->filteredBy(function ($query) {
        $query->where('foo', 'bar');
    }
}

Obviously with a better name.

I think that the solution should work like this:
public function notes()
{
    return $this->hasMany(App\Note::class)->where('type', 'private);
}

auth()->user()->notes()->where('foo', 'bar')->orWhere('x', 'y');

The resulting SQL:
select
  *
from
  "notes"
where
  (
    "notes"."user_id" = 5
    and "notes"."user_id" is not null
    and "notes"."type" = "private"
  )
  and
  (
    "notes.foo" = "bar"
    or "notes.x" = "y"
  )

The relationship scope ("tasks.user_id" = 5) would be in the same group of brackets as the wheres in the public function notes(). A step further, that's probably unnecessary, would be to put the relationship scope in one pair of brackets, the relationship wheres in a second pair and the other wheres in a third pair. This would make sure that you can't break the relationship scope even in the public function notes().

Why this is expected behavior (IMO): When adding a where()->orWhere() clause to a query, you should always wrap it in a closure. If the query has any additional constraints before or after it, the query breaks.

When adding a where()->orWhere() clause to a query, you should always wrap it in a closure. If the query has any additional constraints before or after it, the query breaks.

You don't see any other wheres when you do this:
auth()->user()->tasks()->where('completed', false)->orWhereDate('date', '<', date('Y-m-d'))

The first part of the call says "the authenticated user's tasks". There should be no way to break the promise of getting only the authenticated user's tasks.
You shouldn't have to worry about what the framework does in the background. You shouldn't have to think "right, auth()->user()->tasks returns a HasMany relation which has a query builder with a where clause". You ask for the current user's tasks, and you should get them.
The code above is expressive, the code below is not.
auth()->user()->tasks()->where(function ($query) {
    $query->where('completed', false)->orWhereDate('date', '<', date('Y-m-d'))
});

Anyone who hasn't experienced this problem recently won't understand why there's a where closure and might think "I can refactor this, I'll remove the where closure".

As noted by @staudenmeir and numerous other issues on this repo this is currently the expected behavior. If you wish to see this changed please open up an issue on the ideas repo to get support for your idea. Then perhaps attempt a PR after that.

I see that the solution is probably not worth the trade-offs. @driesvints what do you think about a PR to the docs repo adding a notice that there might be unexpected behavior when using orWhere with relationships?

@stancl you can always try to see if it gets accepted by Taylor/


LICENSE file missing

Thank you for this interesting plugin.
I can't find if the source is released under a license. Is there a license?

Forgot to add a license, thanks for letting me know. It's under the MIT license now.


Not all points are written when using write_point inside a loop without sleep

I am using the following code:
require 'influxdb'
database = 'tt'
name     = 'foobar3'
influxdb = InfluxDB::Client.new database
5.times do
	item = {
  	values: { count: rand(10...42).to_f },
  	tags:   { type: 'Draft', subtype: 'dummy', state: 'Live' } # tags are optional
	}
	influxdb.write_point(name, item)
	sleep 1 # Removing this will cause the issue
end

Above code inserts 5 values into influx. If I remove the sleep 1, then only one point gets inserted into the DB. When I have sleep in the loop, all 5 values gets inserted.
Is this expected?
Influx version: 1.2.4
Influx ruby: 0.3.14

Yeah, this is a common pitfall when using the Ruby gem:

if you omit the timestamp, the server will select one, based on the presicsion parameter
the Gem's default precision is 1 second, because that's what Ruby's Time operations are based on
data points with the same timestamp and tag set are considered equal

So if you don't specify a precision, we'll fall back to second-precision. When you write five points with the same tags (within the same second), the first four points are overwritten by the last point (i.e. each subsequent point overwrites the last one).
You can find the corresponding note in the README in the Writing data section (scroll to the "Note:" under the second code sample):
The easiest soultion is to explicitly define a time_precision (on the InfluxDB::Client) and the timestamp option (when writing points):
influxdb = InfluxDB::Client.new "tt",  time_precision: "ns"
tags = { type: 'Draft', subtype: 'dummy', state: 'Live' }

def now_in_nanoseconds
  (Time.now.to_r * 10**9).to_i
end

5.times do
  item = {
    values:    { count: rand(10...42).to_f },
    tags:      tags,
    timestamp: now_in_nanoseconds,
  }
  influxdb.write_point(name, item)
end

I've added a link to the readme: https://github.com/influxdata/influxdb-ruby#a-note-about-time-precision

FYI: If you're feeling adventurous, you could try the timestamps branch, whilch might be included in the next release:
# Gemfile
gem "influxdb", github: "influxdata/influxdb-ruby", branch: "timestamps"

# your code
influxdb = InfluxDB::Client.new "tt",  time_precision: "ns"
# item = { values: {...}, tags: {...} }
influxdb.write_point(name, item, Time.now)

As you can see, you still need to define the time_precision option on the client and explicitly provide a timestamp on the data point, but you'll save the second→whatever conversion.


add domain

@YanisKi First stage of verification passed, official domain is marienschule-euskirchen.de as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://www.marienschule-euskirchen.de/?page_id=15595

@YanisKi Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Domain files are still using version 2

The domain files is still using version 2.
It would be great to upgrade to version 3, thanks! 😃
https://github.com/RasaHQ/conversational-ai-course-3.x/blob/5eff0475702c2c750b668397c2554b8c0160968e/video-09-1-basic-forms/domain.yml#L1

Thanks for raising this issue, @dakshvar22 will get back to you about it soon✨
Please also check out the docs and the forum in case your issue was raised there too 🤗

Fixed via https://github.com/RasaHQ/conversational-ai-course-3.x/pull/2


fix: #123 tab close button swap

@barraponto I tested you fix on the ESR version 128.3.1esr of Firefox and while it puts the close button to the left, it puts the tab label off center:

Hi @barraponto, thanks for submitting this pull request!
I've looked into this and at a surface it fixes where the close button is located, because of the changes of how the CSS order works in one of the recent updates to Firefox, a bit more work is needed.
I think the main cause of @dcd-arnold 's issue is due to the way flexand flex-grow works in the ::before and ::after of the tab content. And since Firefox changed the order, it doesn't look like it's going to be simple to get a fix working..
Testing out your pull request, i've noticed the same as in the picture above, where because of the flex box, centred text starts cutting off sooner.
Happy to work together on this!

Ended up changing the type of padding around the text from the flex to putting an auto margin on the icon and text to keep it centered. Fix working on all types of tabs, including with sound playing and pinned


Sticky footer not working

I can't get the sticky footer to work in safari - works in Chrome and Firefox.  I am on safari 7.1.5.  I also cleared my cache just to make sure.

Do you have a demo site we can look at?

Can I email it to you? private dev environment.

Morning...
Yes. My e-mail -<EMAIL_ADDRESS>

Done - sent ....

It relies on flexbox, and whether or not it works relies on the browser to support it

Not sure why this is closed. Does this mean the sticky footer solution you have doesn't work in Safari? I am on version 7.1.5.

It was closed because it's browser-specific. Alvin noted that if it doesn't, it's due to the browsers' support of it.
Could I suggest looking at the legacy Safari fixes on this page?
https://css-tricks.com/using-flexbox/

I wanted to confirm that this is an issue everyone else using materializecss is facing - i.e. the sticky footer solution doesn't work in safari. I think you should mention it somewhere on your sticky footer page.

I definitely would but I'm not a developer on this project. That said, it's not a 'done' thing - did you take a look at the link I sent you previously?

I did - but again, it's not mentioned anywhere in their documentation the sticky footer solution does not work on safari and you have to resort to hacks to make it work. I posted here to check if its working for everyone without any hacks .  Surprised it hasn't come up.

Here is what is said on the website:
"Note: This may cause issues in Internet Explorer which has weak support for flex box."
No mention of safari.

That's fine, but between you and me right now, you need a solution. You'll find one in that link, I'm sure of it. Let's worry about documentation changes later.
That said, it's somewhat sinister that caniuse.com doesn't agree:
http://caniuse.com/#feat=flexbox

I mean it does say you need to add prefixes.
On Mon, Apr 27, 2015 at 10:55 AM, krisDOTco<EMAIL_ADDRESS>wrote:

That's fine, but between you and me right now, you need a solution. You'll
find one in that link, I'm sure of it. Let's worry about documentation
changes later.
That said, it's somewhat sinister that caniuse.com doesn't agree:
http://caniuse.com/#feat=flexbox
—
Reply to this email directly or view it on GitHub
https://github.com/Dogfalo/materialize/issues/1216#issuecomment-96685555
.

--
Doggy sends his greetings from Mars.

"Supported with prefix: -webkit-."
I am sure that will fix the problem. I've tested it locally and it works for me.

Thanks guys - the webkit prefix works for me.

This is still not working for me
body {
  -webkit-display: flex;
  -webkit-flex-direction: column;
  -webkit-min-height: 100vh;
  flex-direction: column;
  display: flex;
  min-height: 100vh;
}

main {
  -webkit-flex: 1 0 auto;
  flex: 1 0 auto;
}

What am I missing?

This is what is working for me ( stylus code - jsut rewrite into regular css )
body
display -webkit-box
display -webkit-flex
display -ms-flexbox
display flex
min-height 100vh
-webkit-box-orient vertical
-webkit-box-direction normal
-webkit-flex-direction column
    -ms-flex-direction column
        flex-direction column

main
-webkit-box-flex 1
-webkit-flex 1 0 auto
    -ms-flex 1 0 auto
        flex 1 0 auto

Thank you, did the trick!

Thank you! :)

@vacquah this worked great thanks.

Sorry to bring up this old post but I tried the solution @vacquah proposed (along with a couple other similar solutions) and it still doesn't work for me in Safari 9. Here's my markup:
body{
  font-family: "Raleway" !important;
  font-weight: 200;
  display: -webkit-box;
  display: -webkit-flex;
  display: -ms-flexbox;
  display: flex;
  min-height: 100vh;
  -webkit-box-orient: vertical;
  -webkit-box-direction: normal;
  -webkit-flex-direction: column;
      -ms-flex-direction: column;
          flex-direction: column;
  background: image-url("mdbg_alt.png");
  background-size: 100vw;
  background-repeat: no-repeat;
  background-attachment: fixed;
  overflow-x: hidden;
  background-color: #fff !important;
  @media (max-width: 769px){
    background-size: auto 100vh;
    }
}

main {
   -webkit-box-flex: 1;
   -webkit-flex: 1 0 auto;
       -ms-flex: 1 0 auto;
           flex: 1 0 auto;
 }

Any ideas?

The solution didn't work as I expected but I get there by a fix in javascript
Adding this line to set up the height of the slider
var h = window.innerHeight;
$('.slider').slider({full_width: true, indicators:false, height:h});
This work without the class  fullscreen of the slider
Hope it works for you


[SPARK-30930][ML] Remove ML/MLLIB DeveloperApi annotations

What changes were proposed in this pull request?
jira link: https://issues.apache.org/jira/browse/SPARK-30930
Remove ML/MLLIB DeveloperApi annotations.
Why are the changes needed?
The Developer APIs in ML/MLLIB have been there for a long time. They are stable now and are very unlikely to be changed or removed, so I unmark these Developer APIs in this PR.
Does this PR introduce any user-facing change?
Yes. DeveloperApi annotations are removed from docs.
How was this patch tested?
existing tests

Test build #119589 has started for PR 27859 at commit a651343.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24319/
Test PASSed.

Test build #119589 has finished for PR 27859 at commit a651343.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119589/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24320/
Test PASSed.

Test build #119591 has started for PR 27859 at commit a651343.

Test build #119591 has finished for PR 27859 at commit a651343.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119591/
Test PASSed.

This is a good one for @mengxr @marmbrus and maybe @gatorsmile -- the theory here which I agree with is that, from 3.0 on, we almost surely will not change these public APIs. Therefore marking them as anything less like "Experimental" or "DeveloperApi" doesn't mean much of anything. What do you think? is "DeveloperApi" different, communicating that it's public and stable just generally not meant for applications to call?

@srowen I actually used the annotation to indicate the APIs are for developer use instead of end users. I just checked the definition of the annotation, it seems I misunderstood it. If we always use it to label very unstable API, then I agree that we should remove them. But I still hope that we have some annotation to separate user and developer APIs. cc: @gatorsmile

+1 to remove them if we expect stability here.

Yes. https://github.com/apache/spark/commit/87bd1f9ef7d547ee54a8a83214b45462e0751efb shows the definition and original motivation.
+1 to remove them for the stable APIs.

Merged to master/3.0

Thank you all!


Suggestion: Player information display

Player Name ...
Player Current  Lv , Exp...  e.g.   Lv 5  3127/5000XP
Current Stardust..
Current Item...
Thanks  Eric

This would be a great addition once we hit the 1.0.0 milestone! Once the stat table / cards is satisfactory, I'll prioritize this in 1.1.0 or 1.2.0. I'm also playing with the idea of an evolve calculator, so we'll just have to see what the more popular feature would be when we get there.

Closing because player information is not really in scope right now. Everything player related is available in the app and there's not really any convenience functions that we can add.


Fix package names used in SIT/PERF scripts

There were some package name issues identified while reviewing #133. Please fix package names in the scripts and documentation accordingly.

@faizalrub-datastax could you PTAL? TY


feat: construct a smooth function on a manifold equal to one on a given closed set and with given support

[x] depends on: #6069
[x] depends on: #6070

bors r+


Add Tolgee.md

Thank you for taking the time to work on a PR for Awesome-Open-Source-Supporters!
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines: [Company Name](link) `tag` - description
[x] Your additions are ordered alphabetically.
[x] Your additions are commercial software that offer their services for free to Open Source projects.
[x] Your additions contain any relevant tags: requires-approval
[x] You have searched the repository for any relevant issues or PRs.
[x] Any category you are creating has the minimum requirement of 2 items.

Thanks for your contribution @marketachalupnikova! I took a look at Tolgee's website, and can't seem to find anything that indicates that you offer your services for free or at a discount specifically for Open Source projects. I see the free tier, but that looks like it is available for everyone.
Am I misreading somewhere?

Closing stale pull request


update to use owasp 5.x

The generated json has changed so it needs to be parsed differently

This was done


Term Requests from the NIH CHEAR project

I'm working with the NIH Children's Health Exposure Analysis Resource (CHEAR) data center to establish CHEBI as part of the data standard for the chemical analytes reported in our studies. We would like to request the following 53 class additions to CHEBI, as these are analytes of interest to the CHEAR program, but do not have corresponding classes yet in CHEBI. We have identified the corresponding PubChem records when available, and have proposed parent classes for each class in the table below.
Thanks,
Jim McCusker
Director, Data Operations
Tetherless World Constellation, RPI

Name
PubChem Compound
subClassOf

Arsenocholine
104820
chebi:15354

2,3,4,5-Tetrachlorophenol
21013
chebi:52049

2,3,4,6-Tetrachlorophenol
6028
chebi:52049

2,4,5,6-Tetrachlorophenol

chebi:52049

Bisphenol F
75575
chebi:22901

Bisphenol S
6626
chebi:22901

Protocatechuic acid ethyl ester
77547
chebi:15882

3,4-Dihydroxy-benzoic acid methyl ester
287064
pubchem:77547

1-hydroxybenz[a]anthacene

chebi:35298

1-hydroxybenzo[c]-phenanthrene

chebi:28851

1-hydroxychrysene
44284
chebi:51687

1-hydroxynaphthalene
7005
chebi:16482

2-hydroxybenzo[c]-phenanthrene

chebi:28851

2-hydroxychrysene
47782
chebi:51687

2-hydroxynaphthalene
8663
chebi:16482

3-hydroxybenzo[c]-phenanthrene

chebi:28851

3-hydroxychrysene
44285
chebi:51687

4-hydroxychrysene
44286
chebi:51687

6-hydroxychrysene
37766
chebi:51687

9-hydroxyfluorene
74318
chebi:24699

9-hydroxyphenanthrene
10229
chebi:28851

Benzo[a]pyrene tetraol

chebi:29865

Mercapturic acid of benzene

chebi:47911

Mercapturic acids of acrolein and crotonaldehyde

chebi:47911

Perfluorobutanesulfonic acid
67815
chebi:37143

Perfluorohexane-1-sulphonic acid
67734
chebi:37143

mono benzyl phthalate (BzBP)
31736
chebi:26092

mono-benzyl phthalate
31736
chebi:26092

mono (5-carboxy-2-ethylpentyl) phthalate (DEHP)
148386
chebi:26092

Monocyclohexyl phthalate
165618
chebi:26092

mono(7-carboxyheptyl)phthalate

chebi:26092

mono-carboxy isononyl phthalate

chebi:26092

mono-carboxy isooctyl phthalate

chebi:26092

Mono-2-(carboxymethyl) hexyl phthalate
187353
chebi:26092

mono (3-carboxypropyl) phthalate (multiple)
53435014
chebi:26092

mono-(2-ethyl-5-carboxypentyl) phthalate
148386
chebi:26092

mono (2-ethyl-5-hydroxyhexyl) phthalate
170295
chebi:26092

mono (2-ethyl-5-oxohexyl) phthalate
119096
chebi:26092

mono-2-heptyl phthalate

chebi:26092

mono-hexyl phthalate
20269373
chebi:26092

mono-isobutyl phthalate (DiBP)
92272
chebi:26092

mono-isodecyl phthalate

chebi:26092

mono-isononyl phthalate
110394
chebi:26092

monoisononyl phthalate
110394
chebi:26092

Monoisopropyl phthalate
118770
chebi:26092

mono-isopropyl phthalate
118770
chebi:26092

Mono-n-octyl phthalate
79362
chebi:26092

mono-pentyl phthalate
90531
chebi:26092

Mono-n-pentyl phthalate
90531
chebi:26092

mono (6-COOH-2-methylheptyl) phthalate

chebi:26092

mono (7-COOH-2-methyloctyl) phthalate

chebi:26092

Mercapturic acids of 1,3-butadiene

chebi:47911

Nicotine-N-oxide
211457
chebi:18723

Hi Jim,
We will add the new terms as soon as we can, though it may take a few weeks. I have created a spreadsheet on GoogleDrive that ChEBI curators will use to record & monitor which.terms have and have not been dealt with; I will share it with you so that you can monitor our progress.
Kind regards,
Gareth Owen

Fantastic, thanks!


Slightly smaller modern output for react-router-dom

This is just the remaining tweaks for #7168, without the erroneous prop-types fix.

Thanks, @developit. I'm going to go ahead and do this on the react-router preset-modules build as well.

BTW, so glad to have your eyes on this @developit. I was using preset-modules, but wasn't 100% sure if I was doing everything right. So thank you for reviewing 🙏

No problem! I'd like to get this done in more repos.


Rename package dataflows

Codecov Report
Patch coverage is 100.00% of modified lines.

:exclamation: Current head 9f52735 differs from pull request most recent head 57a120e. Consider uploading reports for the commit 57a120e to get more accurate results

Files Changed
Coverage

src/gravitorch/creators/dataflow/base.py
ø

src/gravitorch/dataflows/base.py
ø

src/gravitorch/creators/dataflow/dataloader.py
100.00%

src/gravitorch/creators/dataflow/iterable.py
100.00%

src/gravitorch/dataflows/__init__.py
100.00%

src/gravitorch/dataflows/dataloader.py
100.00%

src/gravitorch/dataflows/iterable.py
100.00%

src/gravitorch/datasources/vanilla.py
100.00%

:loudspeaker: Thoughts on this report? Let us know!.


Obsidian Gallery lists Version 1.0.3 and refuses to install; 1.0.2 latest release in this repo

The title pretty much says it all. I noticed that an update was pending but failing in my Obisidian vault. I tried uninstalling the 1.0.2 version and reinstalling it from the gallery, but it still failed. That's when I realized this repo hasn't published a 1.0.3. So now, the plugin can't be installed from the gallery at all.
I realize that I could manually install it, but I'll wait until this is resolved.
Hope this helps. Thank you!

Hi @ozdemir08, please fix this issue.
We will remove this plugin from the community plugins if this issue is not fixed within 30 days.

The Obsidian team.

Thanks @davejdyer for filing this. I reverted the version to 1.0.2 now. I also tried uninstalling/installing it on my laptop. This should be fixed now. Let me know if the issue persists for you.


Add support for multiple genetic codes

I've been looking all over for a Rust library that supports multiple genetic codes. This library seems to be the best translation library, so I hope this is on your radar. Thanks!

Hey @Benjamin-Lee, this is the type of use-case I'd like to cover with this. Thanks!
I'm thinking that the current From<Kmer<Dna, 3>> for Amino isn't the way to go. For safety and generality it would be cool if

The genetic code should be explicitly named, even if it's just the standard code
Users should be able to build their own translation tables at runtime

So with:

trait TranslationTable<A: Codec> {
    fn to_amino(self, codon: Kmer<A, 3>) -> Amino;
    fn to_codon(self, amino: Amino) -> Option<Kmer<A, 3>>;
}

There can be a Standard struct that implements these methods the same way that translation is implemented now with zero cost (I'm not a fan of the all-caps name, clippy is):
const STANDARD: Standard = Standard;

But then users can define their own Custom translation table:
impl Custom {
    pub fn from_vec(table: Vec<Amino>) -> Self {
        Custom { table }
    }
}

impl<A: Codec> TranslationTable<A> for Custom {
    fn to_amino(self, codon: Kmer<A, 3>) -> Amino {
        self.table[Into::<usize>::into(codon)]
    }

I've pushed these changes but they aren't ready yet. The old test cases have been updated:
       let seq: Seq<Dna> =
            dna!("AATTTGTGGGTTCGTCTGCGGCTCCGCCCTTAGTACTATGAGGACGATCAGCACCATAAGAACAAA");
        let aminos: Seq<Amino> = seq
            .kmers()
            .map(|kmer| STANDARD.to_amino(kmer))
            .collect::<Seq<Amino>>();

and the usage looks very similar to the original. That type annotation on collect is probably unnecessary now.
What I'm mulling over now is how to, or whether to support fallible translations. This is tempting because I want to support IUPAC to amino acid sequences. A lot of the triples of iupac ambiguity codes unambiguously represent amino acids (and vice-versa!) so we'd be able to get rust's type system to cover some error prone uses.
The goal is that this library could be something someone uses to implement a tool like FACIL or Codetta in rust.

I'm somewhat satisfied with this for now. There are details at the bottom of the README now, and lots of test cases in the translation module:
pub trait TranslationTable<A: Codec, B: Codec> {
    fn to_amino(&self, codon: &SeqSlice<A>) -> B;
    fn to_codon(&self, amino: B) -> Result<Seq<A>, TranslationError>;
}

/// A partial translation table where not all triples of characters map to amino acids
pub trait PartialTranslationTable<A: Codec, B: Codec> {
    fn try_to_amino(&self, codon: &SeqSlice<A>) -> Result<B, TranslationError>;
    fn try_to_codon(&self, amino: B) -> Result<Seq<A>, TranslationError>;
}

The standard genetic code is provided in the translation::standard module:
use crate::prelude::*;
use crate::translation::standard::STANDARD;
use crate::translation::TranslationTable;

let seq: Seq<Dna> =
    dna!("AATTTGTGGGTTCGTCTGCGGCTCCGCCCTTAGTACTATGAGGACGATCAGCACCATAAGAACAAA");

let aminos: Seq<Amino> = seq
    .windows(3)
    .map(|codon| STANDARD.to_amino(&codon))
    .collect::<Seq<Amino>>();

assert_eq!(
    aminos,
    amino!("NIFLCVWGGVFSRVSLCARGALSPRAPPLL*SVYTLYM*ERGDTRDISQSAHTPHI*KRENTQK")
);

Instantiate a custom translation table from a type that implements Into<HashMap<Seq<A>, B>>:
let codon_mapping: [(Seq<Dna>, Amino); 6] = [
    (dna!("AAA"), Amino::A),
    (dna!("ATG"), Amino::A),
    (dna!("CCC"), Amino::C),
    (dna!("GGG"), Amino::E),
    (dna!("TTT"), Amino::D),
    (dna!("TTA"), Amino::F),
];

let table = CodonTable::from_map(codon_mapping);

let seq: Seq<Dna> = dna!("AAACCCGGGTTTTTATTAATG");
let mut amino_seq: Seq<Amino> = Seq::new();

for codon in seq.chunks(3) {
    amino_seq.push(table.try_to_amino(codon).unwrap());
}

assert_eq!(amino_seq, amino!("ACEDFFA"));

Implementing the TranslationTable trait directly:
struct Mitochondria;

impl TranslationTable<Dna, Amino> for Mitochondria {
    fn to_amino(&self, codon: &SeqSlice<Dna>) -> Amino {
        if *codon == dna!("AGA") {
            Amino::X
        } else if *codon == dna!("AGG") {
            Amino::X
        } else if *codon == dna!("ATA") {
            Amino::M
        } else if *codon == dna!("TGA") {
            Amino::W
        } else {
            Amino::unsafe_from_bits(Into::<u8>::into(codon))
        }
    }

    fn to_codon(&self, _amino: Amino) -> Result<Seq<Dna>, TranslationError> {
        unimplemented!()
    }
}