[File] resource needs to have an option to set encoding

Hello,
Currently DSC [File] resource by default saves file in UTF8-BOM encoding and there is no way to set it inside resource. This breaks bunch of things in certain scenarios. Please add that feature.

We have no way of changing that resource here on GitHub as it is not part of the DSC Resource Kit, it is a built in resource in Windows PowerShell Desired State Configuration. But we could create an issue with a new resource proposal in PSDscResources.
@kwirkykat do you have any more insights on how to resolve issues in the built-in resources?

If your proposal is to extend the builtin File resource, then I suggest you add your proposal as a uservoice, if it doesn't already exist, so that you can track it and other users can vote on it.
Or you can propose a new resource in the repository PSDscResources that will include this suggestion.
I'm closing this issue at this time since we can't do anything more about it in this repository.


bump dustin/go-humanize v1.0.0

full diff: https://github.com/dustin/go-humanize/compare/8929fe90cee4b2cb9deb468b51fb34eba64d1bf0...v1.0.0
probably most relevant change:

https://github.com/dustin/go-humanize/commit/64dbdae0d393b7d71480a6dace78456396b55286 Add space between the numbers and units

closes dustin/go-humanize#21 Space between numerical value and unit symbol for SI output
related: dustin/go-humanize#32 no space between bytes and units

ping @dperny ptal


testSubsetTargetToUsableOnes is missing dataprovider

HDF5PCACoveragePoNCreationUtilsUnitTest.testSubsetTargetToUsableOnes() is always skipped because its dataprovider "readCountAndPercentileData" was deleted in #634
See here:(https://github.com/broadinstitute/gatk-protected/pull/634/files#diff-8dd9131901a75d391a8e3781d9eea0e0L465)

@mbabadi Since you were the one who deleted the dataprovider, could you take this one?  I'm not sure if the test should be deleted or if it's data should be reinstated.


example of VM booting with cloudmesh

@laszewsk is this what you were envisioning?
Here's the documentation for this branch.
I haven't actually tested this. Maybe one of the students can try it out?
edit: update link

@laszewsk mind taking a look?

needs warning that this is a proposal and not yet implemented.


[Question] How can I reproduce the safe driving results?

Thank you very much for your contributions to the Safe RL community!
I am trying to reproduce the Safe RL baseline algorithms, namely PPOLag and SACLag, on MetaDrive.

I found that the training success rate of PPOLag is roughly consistent with the paper, but the Cost is significantly higher. (Here is the performance of PPOLag. The Reward is the success rate.The dIfferent dolors denote different num_scenarios)

I have read the paper and did not find any hyperparameters related to the environment settings. May I ask if you used the default hyperparameters provided in MetaDrive? Also, do you have any code references to reproduce the results in the paper? Thank you in advance!

Thank you again for your answer! I no longer have any confusion.


Multiline Message

Feature Description
Currently, the behavior for long messages is to truncate the text to fit on one line. I believe it would make more sense for the view to increase in height based on the dimensions of its contents to allow for more lines of the message text to show. In order to maintain backwards compatibility, I think the default number of lines for the message should be 1, and the container should expand when the number of lines is modified to be greater than 1 (and has multiple lines).
From what I can tell, areaHeight is currently constant and only used in one place. With some preliminary testing, it seems increasing this value here increase the size of the container, so I image one could just measure the height of the children instead of using areaHeight.

The following would also be nice:

Wider toasts
Unlimited lines of text.

Related issue from burnt, my library which relies on SPIndicator: https://github.com/nandorojo/burnt/issues/39
(PS thanks again for this great lib!)


Update rules.yaml

This is long overdue, and if it works should go to the public monitoring chart as well.

What was Voltron 😛

The old transformation app


Wish counter

Wish counter is counting all pity up to 90 (including weapons) after data is put in

@crystaliene do you mind checking the date today 😉


Edge-Case: Using lit-html in a typescript project may cause compiler error. (resolved)

Update: (resolved)
I did some testing and found that "noImplicitAny": false in tsconfig.json causes this unexpected behaviour and surprisingly setting it this option to true seems to be assume that any[] is a fact and does not complain about it being an implicit any.
Typescript Issue: Microsoft/typescript.

https://github.com/PolymerLabs/lit-html/blob/9d6f581f77533cb47783d0271d6d968b1f7690de/src/lit-html.ts#L150
I'm currently working on an experimental with a TSX to lit transformer using TypeScript 2.5.2 and I keep running into some issues related to the line above.
It is not a serious issue and I am not sure if it is caused by my own TypeScript setup or due to recent (potentially breaking) changes in TypeScript.
TypeScript seems to favour checking lit-html.ts in my setup and since type checking for lit-html and my project are configured differently it throws (here's my pretty print tsc output):
199           nodesToRemove.push(node);
                                 ~~~~
../../node_modules/lit-html/src/lit-html.ts(199,30): error TS2345: Argument of type 'Element' is not assignable to parameter of type 'never'.

207       n.parentNode!.removeChild(n);
            ~~~~~~~~~~
../../node_modules/lit-html/src/lit-html.ts(207,9): error TS2339: Property 'parentNode' does not exist on type 'never'.

In any case, I've noticed that recently TypeScript complains about array items when the array's variable is not typed  and is initialized with an empty array:
  let array = [];
  array.push(1); // error: 1 is not never;

TypeScript (under certain conditions that I did not bother testing) doesn't infer any[] as the type of a never[] and instead seems to assume that people like their arrays to actually hold nothing.
This is not a lit-html issue but can I recommend adding a type annotation like:
  let array: number[] = []; // append as number[] or initializing with any number also works.

and, in case of the line in lit-html.ts, consider:
  const nodesToRemove: any[] = []; // this will do the trick.

Thanks!

Adding the type annotation is fine. Want to make a PR?

Actually, since it is really more of a TypeScript edge-case, I think this thread is a good reference for anyone who hits the same snag.

The summary
Don't Do This:
{
  "compilerOptions": {
    "strict": true,
    "noImplicitAny": false
  }
}

Or else you have to do this
  let array: any[] = [];

Since both strict and noImplicitAny false make it impossible for TypeScript's type-system to make the assumption about your empty array that never implies any.

I think your code should not change, those settings are likely to cause breaks in a lot of places for anyone using them.

Good to know. I've ended up typing the array as Node[] in a recent PR anyway.


Update from hadolint scan suggestions:

Use COPY instead of ADD
Use json-type args for ENTRYPOINT
My company does automated scans with hadolint. It identified these changes and I thought I would upstream this. Thanks.

Thank you for your PR


SEND DOESN'T WORK

RECEIVE WORKS BUT SEND DOESN'T.

Send only works once you are connected - no cache


Not all attributes are working in LDAP AUTH PLUGIN (access.lua)

I am using Kong over Kubernetes.
I have tried to use the LDAP AUTH with this configuration
{
“id”: “93dsd0bfa-g851-4953-abdkje54-b7461545S806”,
“name”: “ldap-auth”,
“enabled”: true,
“created_at”:<PHONE_NUMBER>000,
“config”: {
“attribute”: “sAMAccountName”,
“cache_ttl”: 60,
“timeout”: 10000,
“start_tls”: false,
“hide_credentials”: false,
“ldap_host”: “@IP of my ldap”,
“base_dn”: “dc=dev,dc=com”,
“ldap_port”: 389,
“keepalive”: 60000,
“verify_ldap_host”: false
}
}

However, with the attributes ‘sAMAccountName’ the connection doesn’t works properly.
When I configure my Header Authorization with a base64(samaccountame:password)
Kong said that my credentials are invalid and returns an error in the logs:

AcceptSecurityContext error , data 52e , v3839

But the LDAP plugins works well with a CN attribute and the proper Base DN.
Related topics: (NOT FIXED YET)
https://discuss.konghq.com/t/error-the-supplied-credential-is-invalid-in-ldap-authentication-plugin/268
https://github.com/Kong/kong/issues/1821

I think the error come from this line in access.lua file 'https://github.com/Kong/kong/blob/893740ec7d6d59d81e7eedd9f930e9ff159c0e12/kong/plugins/ldap-auth/access.lua#L94)
line 94 :  local who = conf.attribute .. "=" .. given_username .. "," .. conf.base_dn
The binding is done with a Distinguised Name Base. Therefore, we can only use CN attribute for the binding.
An attribute based on sAMAccountName or UPN cannot be used because DN cannot contain any of theses attributes.

Exemple of working go LDAP Binding with an UPN :
package main

import "log"
import "fmt"
import "gopkg.in/ldap.v3"

var username =<EMAIL_ADDRESS>var password = "Pwd#LDAP2019"

var ldapServer = "<IP_ADDRESS>"
var ldapPort = 389

func main() {
        l, err := ldap.Dial("tcp", fmt.Sprintf("%s:%d", ldapServer, ldapPort))
        if err != nil {
                log.Fatal(err)
        }
        defer l.Close()
        err = l.Bind(username, password)
        if err != nil {
                log.Fatal(err)
        }
        log.Printf("Successfully binded.")
}

And the results after runing the go app :
2019/10/13 18:56:53 Successfully binded.
If I try to make a mistake on the password:
2019/10/13 18:57:45 LDAP Result Code 49 "Invalid Credentials": 80090308: LdapErr: DSID-0C09042A, comment: AcceptSecurityContext error, data 52e, v3839
(The same error as in the Kongs logs so, it is officially the line 94 which compromis the authentication with another attribue (UPN, sAMAccountName)

closing for lack of activity


Added support for FreeBSD

For root: Changed '/bin/login' to '/usr/bin/env login'
For non-root: Added keyboard-interactive authentication

Any movement on this?

Thank you!

thanks @khanzf


[request] Enable installation on macOS using brew cask

Hi,
installation on macOS would be much easier if I could
brew cask install ungoogled-chromium
Thanks!

kys is much more simple for mac untermensch.
On Sun, Feb 5, 2017 at 7:34 PM, Srinivas Gorur-Shandilya <
<EMAIL_ADDRESS>wrote:

Hi,
installation on macOS would be much easier if I could
brew cask install ungoogled-chromium
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Eloston/ungoogled-chromium/issues/185, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABKM7-urbfyBi0WkQc2cjFUBgmLRUhXfks5rZhZIgaJpZM4L3lFu
.

Srinivas Gorur-Shandilya - poo in the loo now
On Mon, Feb 6, 2017 at 12:01 AM, blitz<EMAIL_ADDRESS>wrote:

kys is much more simple for mac untermensch.
On Sun, Feb 5, 2017 at 7:34 PM, Srinivas Gorur-Shandilya <
<EMAIL_ADDRESS>wrote:

Hi,
installation on macOS would be much easier if I could
brew cask install ungoogled-chromium
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Eloston/ungoogled-chromium/issues/185, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABKM7-urbfyBi0WkQc2cjFUBgmLRUhXfks5rZhZIgaJpZM4L3lFu
.

AFAIK, it's already available as eloston-chromium

Huh, I wonder why they called it eloston-chromium. I only wrote less than half of the patches.

But you can't find the package by typing in ungoogled which sort of bugs me.

yes, my problem precisely.

I guess small PR can change it (rename it). I can do it, or anyone, really.

The Caskroom maintainers decided against that name when the cask was added, per https://github.com/caskroom/homebrew-cask/pull/24969#issuecomment-250848695.

vitorgalvao has made fair points. In that case, I will just add a section to the README about it.

Sorry for replying on a closed issue but i found this is where it suits best. I somehow wonder why there's no way to build the 57 version on the mac. Maybe cask is the way to go here but many users don't have homebrew in favour of a different pkg-manager. I'd be really keen to know why currently there's no mac 57-option willing to spend some time on building this if possible without a strict requirement for homebrew (so free to chose brew, macports or nixpkg).

You could try setting up an environment with udocker, and compile from there.

@dieideeistgut There's no version 57 support for macOS yet because it hasn't been updated yet.

@Eloston is this why i can't generate matching buildfiles targetting macos as the process changed since the 55? Maybe i can help @9Morello out if he needs some helping hands doing the dirty-work?

@dieideeistgut macOS support haven't been implemented in the build files generator yet, nor has any of the macOS-specific patches been updated yet.
I don't know if 9Morello needs help or not. You can ask by sending a One-to-One message on Gitter.

@9Morello i'll give it a shot during next week, let's see how far i'll come


Pixhawk 4, preflight fail: EKF High IMU accel bias. (arming very difficult)

Hello, I tried to put a new Holybro 4 with 1.8.0 into my fixed wing (using the GPS and Magnetometer from the Holybro 4)
Before was holybro PIX32 successful in place in the same UAV.
I get  “critical: preflight fail:EKF High IMU accel bias)” and “Critical: Not arming: Preflight checks failed”
Tried several times the following:
Run power the unit for 30min and started the calibriation from “ground up” again.
Took a second Holybro 4 Unit and tried again. Tried to change the param: COM_ARM_MAG from default to 0.5, did not change anything.
Up to now, I was only able to go once successful trough the calibration process. Out of then attempts. Calibration is done outside a building,
What is your advice to get to the root cause? Using QGC daily built from 22-6
Thanks for your help. Jakob
https://logs.px4.io/plot_app?log=2e9582c4-95c6-43ca-88fb-a388eff98028

Hey Jacob,
What I see in the logs is many "Manual control lost: failsafe" can you check your remote control connection?

@AlexisTM Alexis, My RC was not switched on during calibration.  Thx Jakob

After trying unsuccessfully to calibrate the Pixhawk 4 countless times via QGC, I did a param reset via console on the pixhawk.
Heureka: the error message is gone.
I already did a parameter reset via QGC before that. But it seems that this did not have the same effect.
My suspicion is that because I work with several different pixhawk HW controllers, something has got mixed up. Hopefully this info helps other to save some time. Jakob

Good tip! I will try this as well!

I had the High IMU accel bias problem. It was caused by the onboard computer fan that was too close of the Pixhawk and not dampened.


Everything seems to need a UUID

This might be react-specific, but in order to reuse various reducers across components, it seems like every action creator and reducer needs to accept a UUID.
Let's suppose I have two items on my page, completely different aside from the fact that they can be visible or not visible. So we make a reducer that allows one to toggle visibility.
function visibility(state, action){
  switch(action.type) {
    case 'TOGGLE_VISIBLE':
      state = !state;
    default:
      return state;
  }
}

And an action creator...
function toggleVisibility() {
  return {
    type: 'TOGGLE_VISIBLE'
  }
}

We combine the reducers...
// Component A
combineReducers({
  visibility
});

// Component B
combineReducers({
  visibility
});

We dispatch the action for item 1:
store.dispatch(toggleVisibility());

And now, both Components A and B's states have changed. The only way around this is to pass UUIDs to the action creators that then pass those to the reducers to consume and apply to their transformations on the store. This obviously leads to a lot of crufty code wherein you're passing UUIDs into absolutely everything.
I get the impression I'm "missing something", or maybe ignoring a pattern that would help here.

Your combineReducers example is vague.  What are you doing with the results of these calls?

If I'm understanding your question correctly, though, you're right.  There is only a single global state; therefore if you have two components using that state that are updating independent of one another you'll need to structure your state and actions to accommodate for that.

What @adamdonahue said is correct, you're dealing with a single global state so updating your state from somewhere will update it for both components!

I do have one further comment.  I tend to use Redux state to model business rules and status, and try to make UI state a function of that.  So rather than a visibility state, I would probably store whatever business data is required to determine whether the widget is visible, and then, in connect, map that business logic to the local component state.  This might also lead to a more natural solution to your problem.
If you're really just talking about toggling whether a component is visible on the screen for whatever reason, it might be a candidate for local UI state (using the traditional this.state variable on the component).

Thanks for your insights, guys. @adamdonahue it helps a lot more to know there's still a place for local ui state in a redux world.

@dclowd9901 : yeah, "multiple instanced" data is still one of the big topics of discussion in the Redux world.  The Redux FAQ partially covers this, at http://redux.js.org/docs/FAQ.html#organizing-state-only-redux-state.  There's also at least a dozen community libraries that attempt to tackle this in various ways - I have most of them listed over at https://github.com/markerikson/redux-ecosystem-links/blob/master/component-state.md .
Finally, there's been a number of discussions here in this repo regarding this sort of topic.  A quick search turns up the following relevant discussions: #1528 , #1182 , #822 , #569 , #1098 , #897 , and #1171 .  You might also want to look at https://github.com/slorber/scalable-frontend-with-elm-or-redux.
(This probably needs to be added to the FAQ.)

Awesome resources, thanks @markerikson.

I've recently made a project that tries to cover this situation for those who use react, let me know if it works for you. https://github.com/eloytoro/react-redux-uuid


Expose per-route counters for throughput and frame types

For each route, track the total input and output throughput in bytes and the total number of each input and output frame type across all associated high-level application streams.
The reaktor should internally keep these counts up-to-date without requiring specific per-nukleus participation.
Requires reaktivity/reaktor.java#23.

All these are merged


Can't find package.json

Report
Plugin Version
<EMAIL_ADDRESS>On what Platform are you having the issue?
android
What did you do?
rush add -p<EMAIL_ADDRESS>npx cap sync
npx cap build android
What did you expect to happen?
Dependencies installed
What happened instead?
Error message saying can't find your package.json
Please provide any other relevant information.
The solution should be easy and self contained so it works on any kind of repo. In the android build.gradle file:
Why don't you do "$buildFile/../../package.json" instead of "$rootDir/../node_modules/appsflyer-capacitor-plugin/package.json" ? Then you don't need workarounds in project that integrates with your SDK.

The fix is scheduled for the upcoming release (probably 2nd half ofFebruary).
For now you can use this version:
npm install<EMAIL_ADDRESS>

Fixed in 6.13.0


Added multi-user support in front-matter

Came across with a scenario where multiple users' repos needed to be cached in the same page, so I added the feature. Now the front-matter may look like this:
---
gh:
  user:
    - someuser
    - someotheruser
  type: get_repos
layout: xxx
title: xxxx
date: xxxx-xx-xx
---

Response results will be cached separately as [username].json in the cache directory. Also modified gh_repos so that single user's cache can be retrieved by calling gh_repos([username]).
Note that the scenario only applies for gh.type as get_repos. Want your opinion on this!

Thank you for your contribution, but I think it's better to be compatible for old version configuration.


Update Composer dependencies (2023-11-27-00-17)

Visual regression test passed!
View the visual regression test report


Record and Replay functionality

A use case I ran into was to actually have the flow metadata collection active in a deployed non-prod environment and then send a test event, which would generate some type of file. That file could then be provided to metz.sh along with the code and allow for "replaying" of events.
For my particular case, this would be very helpful for visualizing the process flow for canary events before allowing broader releases. I know in my example I said non-prod environments, but imagine hitting an endpoint [POST] /your/endpoint/here, it returns some ID and then be able to in a browser navigate to /metz.sh/ui/, which would visualize the replayable events based on the returned id in the previous step.
How achievable does this seem ? Is this in line with your intended functionality ?

I actually didn't imagine this to be used as a spectroscope!
A few question though:

Currently metz only accepts code which follows its rules. Meaning the deployed non-prod code has to be follow them as well if we want it be processed by metz. But I imagine when you say record, your code simply emits events that can be compiled and run on metz. Your actual code doesn't get processed by metz. Is this understanding correct?
To have a visualisation though, we need code. Does this mean we'd have a mini version of deployed code which can act as a vessel for the real one?

Once again, interesting idea and use case!

Currently metz only accepts code which follows its rules. Meaning the deployed non-prod code has to be follow them as well if we want it be processed by metz. But I imagine when you say record, your code simply emits events that can be compiled and run on metz. Your actual code doesn't get processed by metz. Is this understanding correct?

Yep. I made a similar functionality when I built mocha-tape-deck. It would record the real network calls during a test, and then encode the results to a file for playback.
I would imagine playback would be possible if you had a "runtime events" playback file (e.g. a scenario cassette that could be loaded into the VCR that is metz) and visualization could happen with a copy of the code, which is where my other opened issue about possibly having a UI in a vscode extension makes sense -> the code context is now local to the UI in that case.
To expand on this further - I could see companies recording a playback of some bug and actually storing it either with a commit hash reference or in VCS directly so that they could replay historic and patched bugs to help identify other affected data down the line (e.g. a math error screwing up the books and it only becoming clear 2 months after patching the bug, where being able to recreate the original bug and have a replayable reference would be massively helpful in resolving affected data).
I do need to apologize, I'm making these asks without looking under the hood deeply into implementation details! If it helps, I can try to find some time to give more concrete implementation suggestions.

Hey, thanks for getting back!
The tape-deck approach makes sense. Tangential, but if support is added then going back a step in the playground also becomes possible.
The bottleneck I see is the code context. I can look into a VS-code extension to do same, but that would require me to change the roadmap which I have already started building.
Maybe a self hosted version for now might suffice?
As for the asks, no worries, keep them coming! For contribution, feel free to join the slack, and I would be happy to answer any questions you might have about the code.

@microsoftly, what you're describing sounds a lot like OpenTelemitry tracing. We're using that now to see what happens with a request. You get a trace that looks like this

Source: https://grafana.com/blog/2021/04/13/how-to-send-traces-to-grafana-clouds-tempo-service-with-opentelemetry-collector/

We're already using tracing libraries.
I think having visualizations like metz.sh for code level data propagation would be useful for debugging.
Logically, I see it to be potentially complimentary to tracing, e.g. certain traces may "record" metz/equivalent compatible data for viz and include that as part of the UI.


Initial implementation of Border Agent role

Added the Border Agent Role in OT stack. User could enable border agent role on end device via CLI.

Codecov Report

Merging #1553 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1553      +/-   ##
==========================================
- Coverage    69.7%   69.43%   -0.28%
==========================================
  Files         157      157
  Lines       20125    20477     +352
  Branches     2480     2554      +74
==========================================
+ Hits        14029    14218     +189
- Misses       5194     5355     +161
- Partials      902      904       +2

Impacted Files
Coverage Δ

src/core/thread/thread_netif.cpp
82.05% <ø> (ø)
:arrow_up:

src/core/coap/secure_coap_server.cpp
72.15% <ø> (ø)
:arrow_up:

src/core/thread/thread_netif.hpp
96.29% <ø> (ø)
:arrow_up:

src/cli/cli.cpp
37.52% <ø> (ø)
:arrow_up:

examples/platforms/posix/random.c
85% <0%> (-15%)
:arrow_down:

src/core/thread/mle.cpp
77.04% <0%> (-4.3%)
:arrow_down:

src/ncp/spinel.c
73.49% <0%> (-3.62%)
:arrow_down:

src/core/net/ip6.cpp
63.44% <0%> (-2.36%)
:arrow_down:

src/core/common/message.hpp
96.29% <0%> (-1.86%)
:arrow_down:

src/core/net/ip6_mpl.cpp
93.07% <0%> (-1.54%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02bd8e1...9c96647. Read the comment docs.

This PR can not show the report from travis, but the build result is passed from background process, please refer: https://travis-ci.org/openthread/openthread/builds/218515488. I have to close this PR and reopen it.

There is a problem on Travis-ci for this PR, so i have to reopen the PR to arouse it.

Reopen this PR to try recover Travis check.

@aeliot, @nibanks and @jwhui, do you have any comments or suggestions to this PR? Looking forward to your comments. Thanks.

Is there any documentation to go with this initial implementation? Even a list of Border Agent features implemented would be helpful.

@beriberikix Thanks a lot for you comments. The implementation of the Board Agent is based on the chapter 8 “Mesh commissioning protocol” in Thread v1.1.1 specification.  I will share a slides to you.
The Border Agent mainly implement the following features:

Establish the Commissioning session with External Commissioner via DTLS handshake.
Assist the External Commissioner to complete the Commissioner Petition with the Lead by handling the messages (COMM_PET, LEAD_PET), and keep the commissioning session between the External Commissioner and Leader through processing the messages (COMM_KA, LEAD_PET)
Assist the External Commissioner to achieve the Commissioner Management via relaying MGMT_SET message.
Relay Joiner authentication messages (RLY_RX, RLY_TX) between the External Commissioner and Joiner Router

I think the quick way to learn the Border Agent functions is to refer two diagrams in Thread specification v1.1.1.

figure 8-1 in page 8-1
figure 8-5 in page 8-29


macOS with Intel Iris Graphics - Godot 4 beta 5 Project Manager using OpenGL3 is empty.

Godot version
v4.0.beta5.official
System information
macOS Big Sur v11.6.8, MacBook Pro (Retina, 13-inch, Early 2015), 2,7 GHz Dual-Core Inter Core i5, Intel Iris Graphics 6100 1536 MB, 8GB RAM
Issue description
When launching Godot, the Project Manager doesn't show anything at all. I can open the project through the project.godot file and everything seems to be working well.
Steps to reproduce
Just launching the Godot app.
Minimal reproduction project
No response

I wonder if it is related to the fact you are using an older macOS (I assume that 2015 laptops, can't, or shouldn't be updated to the lates macOS.

The ProjectManager using GLES3 driver are broken on macOS 11.7.1, I think we can use Vulkan Mobile instead of GLES3 in Godot 4.0, because Vulkan Mobile is working OK on older macOS.

@snougo Can you try opening the editor from the command line with the command line argument --rendering-method mobile?

@clayjohn yes It's opening
peter@KevindeMacBook-Pro /Applications % Godot.app/Contents/MacOS/Godot --rendering-method mobile
arguments
0: Godot.app/Contents/MacOS/Godot
1: --rendering-method
2: mobile
Current path: /Applications
Godot Engine v4.0.beta5.official.89a33d28f - https://godotengine.org
[mvk-info] MoltenVK version 1.2.0, supporting Vulkan version 1.2.231.
The following 81 Vulkan extensions are supported:
VK_KHR_16bit_storage v1
VK_KHR_8bit_storage v1
VK_KHR_bind_memory2 v1
VK_KHR_create_renderpass2 v1
VK_KHR_dedicated_allocation v3
VK_KHR_depth_stencil_resolve v1
VK_KHR_descriptor_update_template v1
VK_KHR_device_group v4
VK_KHR_device_group_creation v1
VK_KHR_driver_properties v1
VK_KHR_dynamic_rendering v1
VK_KHR_external_fence v1
VK_KHR_external_fence_capabilities v1
VK_KHR_external_memory v1
VK_KHR_external_memory_capabilities v1
VK_KHR_external_semaphore v1
VK_KHR_external_semaphore_capabilities v1
VK_KHR_fragment_shader_barycentric v1
VK_KHR_get_memory_requirements2 v1
VK_KHR_get_physical_device_properties2 v2
VK_KHR_get_surface_capabilities2 v1
VK_KHR_imageless_framebuffer v1
VK_KHR_image_format_list v1
VK_KHR_maintenance1 v2
VK_KHR_maintenance2 v1
VK_KHR_maintenance3 v1
VK_KHR_multiview v1
VK_KHR_portability_subset v1
VK_KHR_push_descriptor v2
VK_KHR_relaxed_block_layout v1
VK_KHR_sampler_mirror_clamp_to_edge v3
VK_KHR_sampler_ycbcr_conversion v14
VK_KHR_separate_depth_stencil_layouts v1
VK_KHR_shader_draw_parameters v1
VK_KHR_shader_float_controls v4
VK_KHR_shader_float16_int8 v1
VK_KHR_shader_subgroup_extended_types v1
VK_KHR_spirv_1_4 v1
VK_KHR_storage_buffer_storage_class v1
VK_KHR_surface v25
VK_KHR_swapchain v70
VK_KHR_swapchain_mutable_format v1
VK_KHR_timeline_semaphore v2
VK_KHR_uniform_buffer_standard_layout v1
VK_KHR_variable_pointers v1
VK_EXT_debug_marker v4
VK_EXT_debug_report v10
VK_EXT_debug_utils v2
VK_EXT_descriptor_indexing v2
VK_EXT_fragment_shader_interlock v1
VK_EXT_hdr_metadata v2
VK_EXT_host_query_reset v1
VK_EXT_image_robustness v1
VK_EXT_inline_uniform_block v1
VK_EXT_memory_budget v1
VK_EXT_metal_objects v1
VK_EXT_metal_surface v1
VK_EXT_post_depth_coverage v1
VK_EXT_private_data v1
VK_EXT_robustness2 v1
VK_EXT_sample_locations v1
VK_EXT_scalar_block_layout v1
VK_EXT_separate_stencil_usage v1
VK_EXT_shader_stencil_export v1
VK_EXT_shader_viewport_index_layer v1
VK_EXT_subgroup_size_control v2
VK_EXT_swapchain_colorspace v4
VK_EXT_texel_buffer_alignment v1
VK_EXT_texture_compression_astc_hdr v1
VK_EXT_vertex_attribute_divisor v3
VK_AMD_gpu_shader_half_float v2
VK_AMD_negative_viewport_height v1
VK_AMD_shader_image_load_store_lod v1
VK_AMD_shader_trinary_minmax v1
VK_IMG_format_pvrtc v1
VK_INTEL_shader_integer_functions2 v1
VK_GOOGLE_display_timing v1
VK_MVK_macos_surface v3
VK_MVK_moltenvk v36
VK_NV_fragment_shader_barycentric v1
VK_NV_glsl_shader v1
[mvk-info] GPU device:
model: Intel Iris Graphics
type: Integrated
vendorID: 0x8086
deviceID: 0x0a2e
pipelineCacheUUID: 000027D8-0B07-07D1-0000-000000000000
supports the following Metal Versions, GPU's and Feature Sets:
Metal Shading Language 2.3
GPU Family Mac 1
GPU Family Common 2
GPU Family Common 1
macOS GPU Family 1 v4
macOS GPU Family 1 v3
macOS GPU Family 1 v2
macOS GPU Family 1 v1
[mvk-info] Created VkInstance for Vulkan version 1.2.0, as requested by app, with the following 3 Vulkan extensions enabled:
VK_KHR_get_physical_device_properties2 v2
VK_KHR_surface v25
VK_MVK_macos_surface v3
Vulkan API 1.2.231 - Using Vulkan Device #0: Intel - Intel Iris Graphics
[mvk-info] Vulkan semaphores using MTLEvent.
[mvk-info] Created VkDevice to run on GPU Intel Iris Graphics with the following 4 Vulkan extensions enabled:
VK_KHR_create_renderpass2 v1
VK_KHR_multiview v1
VK_KHR_swapchain v70
VK_GOOGLE_display_timing v1
[mvk-info] Created 3 swapchain images with initial size (1152, 648) and contents scale 1.0 for screen VX2260WM.
[mvk-info] Created 3 swapchain images with initial size (1152, 648) and contents scale 1.0 for screen VX2260WM.
[mvk-info] Created 3 swapchain images with initial size (1152, 648) and contents scale 1.0 for screen VX2260WM.
[mvk-info] Created 3 swapchain images with initial size (482, 94) and contents scale 1.0 for screen VX2260WM.
[mvk-info] Created 3 swapchain images with initial size (482, 94) and contents scale 1.0 for screen VX2260WM.
[mvk-info] Created 3 swapchain images with initial size (482, 94) and contents scale 1.0 for screen VX2260WM.

@snougo Could you also let me know what gets printed when you run godot using the OpenGL renderer?

@clayjohn
peter@KevindeMacBook-Pro ~ % /Applications/Godot.app/Contents/MacOS/Godot --rendering-method gl_compatibility
arguments
0: /Applications/Godot.app/Contents/MacOS/Godot
1: --rendering-method
2: gl_compatibility
Current path: /Users/peter
Godot Engine v4.0.beta5.official.89a33d28f - https://godotengine.org
OpenGL Renderer: Intel Iris OpenGL Engine

Just tried in on macOS 13.0.1 and the editor interface is rendering as expected

I tried the same method but mine doesn't work I'm running on a macOS High Sierra version 10.13.6 with an intel Iris graphics 6100

oh it works i just need to wait a little bit...

oh it works i just need to wait a little bit...

Yes, at first time you may need to wait a seconds, but next time it will be quickly to launch.

wait, my mesh is not showing

wait, my mesh is not showing

my device is MacBookPro 2013 late, maybe you can try to upgrade your os version to macOS 11.7.1

i cant upgrade it my mac will break

uh did you use the --rendering-method gl_compatibility?

uh did you use the --rendering-method gl_compatibility?

yes and it's just show this, because it's the default setting by Beta5

i tried the same and all is grey

no gizmo too only skybox

my fps is also 1000

I bought a 2015 Macbook pro (same as in the OP) this weekend and can now reproduce the issue. I hope to have a fix later this week. I will update here once I am closer to fixing this.

I change the computer to macOS Catalina version 10.15.7 and it seems to fix the problem :)

With the new Beta 7 out today, I spent some time trying to get Godot 4 working on my older Macbook. I'll document my findings here:
System:
MacBook Pro (Retina, 13-inch, Early 2015)
Processor: 2.7 GHz Dual-Core Intel Core i5
Memory: 8 GB 1867 MHz DDR3
Graphics: Intel Iris Graphics 6100 1536 MB

With the new Beta 7 out today, I spent some time trying to get Godot 4 working on my older Macbook. I'll document my findings here:
System
MacBook Pro (Retina, 13-inch, Early 2015)
Processor: 2.7 GHz Dual-Core Intel Core i5
Memory: 8 GB 1867 MHz DDR3
Graphics: Intel Iris Graphics 6100 1536 MB
1. Mobile
./Godot --rendering-method mobile
Result is a blank editor screen as per original issue.
This occurred for me on macOS High Sierra (10.13.2) and Mojave (10.14.6).
Incidentally, buttons are pushable (i.e. blindly clicking in the first "Please Confirm..." dialog where buttons should be visible (same in the main editor window) yields familiar dialogs (import, create new etc).
On Catalina (10.15.7) the editor launches correctly.
Further, creating a project with Forward+ causes the editor to terminate upon load, and a Godot active application icon is left in the menu bar.
With Mobile support it launches fine, and I can see the gizmo when I select a Node3D scene root.
2. GL Compatibility
./Godot --rendering-method gl_compatibility
In each case of macOS High Sierra (10.13.2), Mojave (10.14.6) and Catalina (10.15.7), the editor fails to launch. For 10.13.2 and 10.14.6, lots of log output but no window. For 10.15.7, the editor window appears but has no UI (though these "invisible" buttons are clickable as in Mobile.
I don't have the log output anymore, but the issues appeared quite similar.

As a quick update on this issue. I spent a day this week debugging this issue. Oddly enough, there are no errors and the shaders appear to be running correctly. The only catch is the shaders aren't receiving data from some of the bound uniforms (some of them work correctly). Oddly enough the uniform buffers appear to be bound properly and filled properly, but the shader doesn't get any of the data. I think given a few days I could get a workaround up and running, but at this point I am 99% sure that this is a driver bug.
Given that our plan is to exclusively ship Apple using ANGLE to translate OpenGL to Metal, I have started working on getting ANGLE working with current master (building on the great work of @bruvzg in https://github.com/godotengine/godot/pull/54914). If my theory is correct everything will render correctly once ANGLE is used and we won't have to add any workarounds into the renderer.

I got ANGLE working earlier this week and it worked, but much to my disappointment, it bloated shader compile times by around 100x (it took about 5 minutes to load the project manager).
This afternoon I did a little investigation into rewriting the canvas shader in a way that might be a bit more friendly to the poor macOS drivers and came up with https://github.com/clayjohn/godot/tree/GLES3-attribs This branch works on my early 2015 macbook (12.6.1)
If anyone who is facing this problem is okay building the engine themself, please test out https://github.com/clayjohn/godot/tree/GLES3-attribs and let me know if it works for you.
I need to do some more investigation as https://github.com/clayjohn/godot/tree/GLES3-attribs runs slower on my main device than master (master runs the project manager in 2 ms and this branch takes 4 ms)

it bloated shader compile times by around 100x (it took about 5 minutes to load the project manager).

I'm not sure if this is a new issue. Project manager also takes 5 minutes to load on a new Godot install if I force --rendering-device vulkan (and so does every new project the first time I open it). So it sounds to me like the same amount of setup time as vulkan. As long as they get cached between runs of Godot, it shouldn't be that bad.

i tried the new beta 8 but when i open it the same grey screen still hapened

fixed in beta9

i have access to forward + :D

i'm kinda sad because theres less features :(

opengl3 still fast tho


Added uninstall action capability to package manifest

Todo

[ ] get a custom catalog from Microsoft for both the sideload and store version of Files
[ ] modify the pipeline to adjust the package name CertificateSignatureHash in the sccd file
[ ] modify the arguments to undo registry changes

Good luck. It would be helpful to user if this capability is approved by Microsoft.

Rescap Custom install actions isnt approved by MS Store

This capability is designed for certain types of desktop PC games that are published by Microsoft and our partners. It will not be granted for other scenarios.

Good luck. It would be helpful to user if this capability is approved by Microsoft.

I got it approved, I'm just having trouble building the app. Can you spot anything I did that's outright wrong (aside from the arguments that are passed to the full trust process)?

Good luck. It would be helpful to user if this capability is approved by Microsoft.

I got it approved, I'm just having trouble building the app. Can you spot anything I did that's outright wrong (aside from the arguments that are passed to the full trust process)?

If Microsoft would like to approve this capability, I will take a look and try implement this capability on RX, I will share more information if I have the same trouble in building apps (If you have trouble in build app, how you submit you app to MStore?)

Rescap Custom install actions isnt approved by MS Store

This capability is designed for certain types of desktop PC games that are published by Microsoft and our partners. It will not be granted for other scenarios.

I know that because I shared this capability to @yaichenbaum and just don't know if MS would like to approve it. So @yaichenbaum said he will try to do it.

@zhuxb711 It seems like there is more to the approval process than I originally thought, I updated the pull request description with more details.

What is the cAI.sccd file? And why do we need customCapability?
I found an issue in here. InstallAction might be required otherwise UnstallAction will not be executed

The same problem...Just don't allow to deploy

What is the cAI.sccd file? And why do we need customCapability?

The sccd is what we need to get from Microsoft in order to use the custom capability. It seems that the rescap isn't enough.

I found an issue in here. InstallAction might be required otherwise UnstallAction will not be executed

I tested without the install action and it worked fine.

@yaichenbaum I found that you copid the Catalog from 'classicAppInstaller_WSA.scd' in 'WsaPackage_1.8.32822.0'.
But seems no help with the deploy error. I don't know if CustomCapability is necessary because almost no guidance about that.

DEP0700: Registration of the app failed. [0x80073CF6] error 0x80080204: While preparing to process the request, the system failed to register the windows.customInstall extension due to the following error: The Appx package's manifest is invalid.

@zhuxb711 after various trials it seems that customInstallActions works ONLY if there is a specific custom capability, (classicAppInstaller), at the time I tested it.
Especially because that cap (customInstallActions) was made only for MSIXVC.
Yes, to run the custom capability you need a signed custom capability descriptor file (.sccd) and I just put a random catalog in it (from WSA). Actually, only with developer mode enabled, you can put any catalog, even invalid, it will not be checked and enforced. So for testing is great but unfortunately with dev mode not enabled it will be verified and given it's not valid you know the result.

@zhuxb711 after various trials it seems that customInstallActions works ONLY if there is a specific custom capability, (classicAppInstaller), at the time I tested it.
Yes, to run the custom capability you need a signed custom capability descriptor file (.sccd) and I just put a random catalog in it (from WSA). Actually, only with developer mode enabled, you can put any catalog, even invalid, it will not be checked and enforced. So for testing is great but unfortunately with dev mode not enabled it will be verified and given it's not valid you know the result.

Actually. I have deploy issue even debugging in VS. So that is really strange and deploying is not work for me even in dev mode.

I make it worked. But I don't know why the fullTrustProcess could not be launched by FullTrustProcessLauncher.LaunchFullTrustProcessForCurrentAppAsync() with value does not fall in expected range exception

I make it worked. But I don't know why the fullTrustProcess could not be launched by FullTrustProcessLauncher.LaunchFullTrustProcessForCurrentAppAsync() with value does not fall in expected range exception

@zhuxb711 do you have a branch with your changes?

I make it worked. But I don't know why the fullTrustProcess could not be launched by FullTrustProcessLauncher.LaunchFullTrustProcessForCurrentAppAsync() with value does not fall in expected range exception

@zhuxb711 do you have a branch with your changes?

I created a new project for Uninstall action and it works well now. All I need is get the permission to use customInstallAction & Catalog. How could I get the catalog? Yes I have a branch for this "CustomUninstallAction"

@zhuxb711 I'm not sure if there is an official process to get the catalog.

@zhuxb711 I'm not sure if there is an official process to get the catalog.

It seems that we need to contact with Windows Technical Account Manager, but I think that is prepared for business users. Any solution?

@zhuxb711 we tried to get a catalog, but Microsoft doesn't want to provide one. @d2dyno1 suggested that we bundle a launcher together with Files which will install silently in the background if the user sets Files as the default file manager. The launcher will automatically revert the settings and remove itself if the user tries opening explorer and it detects that Files is no longer on the device. I think this is the safest way to make sure the settings don't corrupt Windows if the user removes Files without turning of the setting to make it the default file manager.


Input handler for Clickhouse

It be great to have input handler for Clickhouse. I would do that, but my Javascript skills are limited :(.

We'd love to merge if anyone wants to submit a PR :)


Add center position and fix Icon size bug on high DPI screens

I had an issue where when I set the icon size, only one quarter of the icon was coloured. After a bit of debugging it turned out to be an issue with my High DPI screen. So I fixed the issues for these screens.
I also added a CENTER position to be completely centred in both axis of the screen.
Thank you for your project ;)

Thanks for looking over everything. I will change the stuff you pointed out.
I have attached a before and after image so you can see the difference ;)


feat: Update xCall and IBC connection to lates spec and update spec

Add fee logic to connection, allow xCall to be used the same as original xCall by introducing optional parameters and admin controlled default protocols. Use per connection timeout height based on each lightclient.

Changelog Entry
version: <log entry>

Checklist:

[ ] I have performed a self-review of my own code
[ ] I have documented my code in accordance with the documentation guidelines
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have run the unit tests
[ ] I only have one commit (if not, squash them into one commit).
[ ] I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Codecov Report

Merging #451 (d1615a0) into main (df4754f) will increase coverage by 0.13%.
The diff coverage is 86.20%.

@@             Coverage Diff              @@
##               main     #451      +/-   ##
============================================
+ Coverage     67.19%   67.33%   +0.13%
- Complexity      551      578      +27
============================================
  Files           191      191
  Lines         17365    17482     +117
  Branches        349      372      +23
============================================
+ Hits          11669    11772     +103
+ Misses         5518     5517       -1
- Partials        178      193      +15

Flag
Coverage Δ

java
79.65% <86.20%> (+0.37%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ore/ibc/src/main/java/ibc/ics24/host/IBCStore.java
73.21% <0.00%> (-1.34%)
:arrow_down:

...a/foundation/icon/btp/xcall/CSMessageResponse.java
100.00% <ø> (ø)

...ava/foundation/icon/btp/xcall/CallServiceImpl.java
77.72% <77.77%> (+1.18%)
:arrow_up:

.../main/java/ibc/xcall/connection/IBCConnection.java
87.36% <90.09%> (+0.52%)
:arrow_up:

...on/src/main/java/ibc/xcall/connection/Message.java
100.00% <100.00%> (ø)

...va/foundation/icon/btp/xcall/CSMessageRequest.java
100.00% <100.00%> (ø)

...in/java/foundation/icon/btp/xcall/CallRequest.java
100.00% <100.00%> (+2.22%)
:arrow_up:

You can hold of on merge found some small issues


fix: imports for node-fetch when using webpack

Fixes partially: https://github.com/googleapis/google-cloud-node/issues/2933 (this comment)
Hey yall! This should fix the problem which was discussed here when initiating a client with the fallback: true option.
I can create another issue if needed :)

[x] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[x] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[x] Appropriate docs were updated (if necessary)

cc @alexander-fenster
not sure about the codecov report... - if someone can point me to the right direction I'd be thankful 🙂

Thanks @denniskribl!  I believe the coverage will go up as soon as the remaining tests complete (I just started them).


[Feature][Ready for Review] Wiki version dropdowns with usernames and timestamps

Purpose
Give users more information regarding wiki version history
Changes

previously unused date formatted, exposed
dropdown item format changed to:

([# or 'Current']) [Firstname Lastname]: [YYYY-MM-DD HH:mm] UTC

Side Effects
None

CR1 looks good.

CR2 looks good @mfraezz :sunny:


par2cmdline-turbo: init at version v1.1.0

Description of changes
This is a fork of par2cmdline that adds performance improvements. This package can be used with sabnzbd to improve verification and repair performance.

Homepage https://github.com/animetosho/par2cmdline-turbo
Sab docs: https://sabnzbd.org/wiki/installation/par2cmdline-turbo

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

The commit message for adding the package should be par2cmdline-turbo: init at 1.1.0 https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions

The commit message for adding yourself to maintainers should be maintainers: add proglottis

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1373

Reviewed points
Result of nixpkgs-review pr 264706 run on x86_64-linux 1

1 package built:

par2cmdline-turbo

[X] package path fits guidelines
[X] package name fits guidelines
[X] package version fits guidelines
[X] package builds on x86_64-linux
[X] executables tested on x86_64-linux
[X] meta.description is set and fits guidelines
[X] meta.license fits upstream license
[X] meta.platforms is set
[X] meta.maintainers is set
[X] build time only dependencies are declared in nativeBuildInputs
[X] source is fetched using the appropriate function
[X] the list of phases is not overridden
[ ] when a phase (like installPhase) is overridden it starts with runHook preInstall and ends with runHook postInstall.

N/A: No phase is overridden

[ ] patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed

N/A: No patch is applied

[ ] patches that are remotely available are fetched rather than vendored

N/A: No patch is applied

Possible improvements
Commit message does not adhere to conventions
As stated by @Lurkki14, the commit message should be par2cmdline-turbo: init at 1.1.0, that is, without the v prefix, as it is shown in the commit messages
conventions for pkgs.
Parallel building
I've added enableParallelBuilding = true; to the derivation and the project
built without any issue. Any reason not to enable it?
New upstream version
As stated by @Nanotwerp, upstream has released a new version, so this PR could bump its version to newest one.
mainProgram meta attribute
The derivation contains only one binary (par2), the other files in bin/ are just symlinks to it. Hence, it could become the projects meta.mainProgram.

Result of nixpkgs-review pr 264706 run on x86_64-linux 1

1 package built:

par2cmdline-turbo


update dockerfiles to use dotnet/sdk:8.0

update docker files to use dotnet 8.
New image base is mcr.microsoft.com/dotnet/sdk:8.0-bookworm-slim-amd64
fixes EdwinVW/dapr-traffic-control#32

Hi @markarnott. I just merged a fix for this when I saw this PR. I should have let you know I was working ont it. My apologies!
Thanks again for spotting this bug!

See #34


Support .npmrc registry/auth settings

https://docs.npmjs.com/using-private-packages-in-a-ci-cd-workflow#create-and-check-in-a-project-specific-npmrc-file
In practice we probably just have to validate that the Bazel downloader config flag is set, and the downloader config has mirrored the settings from .npmrc.

I think this has been fixed with https://github.com/aspect-build/rules_js/pull/475

I think we're missing a documentation update to consider it done

Basic auth support has landed in #623. I think we should just add more color to the npm_translate_lock docstring for the npmrc setting and we can close this one.


chore: new line fix

/code review

:robot:
File: examples/complete/main.tf

Suggestion: It's good practice to keep the source attribute at the top of the module block for better readability. Since you've moved it to the bottom, consider moving it back to the top.
Before:
module "workdpaces" {
  agent_pool_id                 = var.agent_pool_id
  ...
  source                        = "../../"
}

After:
module "workdpaces" {
  source                        = "../../"
  agent_pool_id                 = var.agent_pool_id
  ...
}

Issue: There's a typo in the module name "workdpaces". It should be "workspaces".
Correction:
module "workspaces" {
  ...
}

File: examples/complete/variables.tf

Issue: Removal of the tags variable. If this variable is indeed unused in your configurations, then its removal is justified. However, ensure that this variable is not required by any resources or modules not shown in the diff. If it's used elsewhere and mistakenly removed, it could lead to issues.

No further issues or suggestions. The rest of the changes seem appropriate based on the provided context.

> gpt-4-turbo-preview

/code review

:robot:
General Overview
The series of patches introduce several changes to the Terraform configuration and the CI pipeline. These changes include code style adjustments, removal of unused variables, addition of required variables, setting a minimum Terraform version, and disabling a part of the CI validation process. Below are specific suggestions and issues identified by file.
examples/complete/main.tf
Patch 1/3

Suggestion: Adding a newline at the end of the file is a good practice for POSIX compliance and to avoid issues with tools that process text files.

Patch 2/3

Issue: The source attribute's position in the module "workdpaces" block has been changed. While this does not affect Terraform's functionality, it's important to maintain a consistent ordering of attributes for readability. The final placement at the end is more conventional.
Suggestion: Correct the typo in the module name from "workdpaces" to "workspaces". This typo correction was partially addressed in Patch 3/3 but should be consistent across all modifications.

Patch 3/3

Suggestion: After correcting the module name typo, ensure all references to this module are consistent throughout the project to avoid confusion or errors.

examples/complete/variables.tf

Issue: The removal of the tags variable is a significant change. Ensure that this variable is indeed unused across all Terraform configurations in the project. If it's used in other modules or resources, this change could lead to errors.

.github/workflows/ci.yaml

Suggestion: The update to the Terraform version matrix in the CI pipeline to start from 1.3 is aligned with the new minimum version requirement. This is a good practice to ensure the CI tests the supported versions.
Issue: Commenting out the "Example Remote Validate" step reduces the scope of the CI validation. If this is intentional due to compatibility issues or other reasons, it's advisable to provide a comment explaining the rationale for future reference.

README.md

Suggestion: Updating the minimum Terraform version requirement in the README is crucial for setting the right expectations for users. This change is well-noted.

Summary
The patches make several important updates and improvements. However, attention should be paid to ensuring consistency, especially with the module name correction, and to thoroughly document significant changes such as the removal of variables or disabling parts of the CI process.
> gpt-4-turbo-preview

/code review

:robot:
.github/workflows/ci.yaml

Suggestion: Correct the typo in the commented-out section from "Exmaple" to "Example". While this section is commented out and won't affect the execution, maintaining correct spelling in comments is good for readability and professionalism.

README.md

No issues.

examples/complete/main.tf

Issue: The module name was corrected from "workdpaces" to "workspaces", which is good for clarity and correctness.
Suggestion: It's good practice to add a description for the newly added variable remote_state_consumer_ids in variables.tf to maintain consistency and provide clarity on its purpose.

examples/complete/outputs.tf

No issues. The correction of the module name in the outputs is consistent with the change in main.tf.

examples/complete/variables.tf

Issue: The removal of the tags variable is noted. Ensure that this variable is indeed unused across the module to avoid breaking changes.
Suggestion: If the tags variable was being used for tagging resources and is no longer needed due to a change in strategy or module design, consider documenting this change in the module's upgrade guide or release notes to inform users of the change.

> gpt-4-turbo-preview

:robot:
.github/workflows/ci.yaml

Suggestion: The disabling of the "Example Remote Validate" step is a significant change. If this is intentional due to the removal of relevant code or other reasons, it's fine. However, if the remote examples still exist and are relevant, consider re-enabling this step or providing a clear rationale for its removal in the commit message or comments.

README.md

Issue: The minimum Terraform version has been updated to >= 1.3. This is correctly documented, but ensure that all documentation and examples reflect this requirement to avoid confusion.

examples/complete/main.tf

Issue: The module name typo correction from workdpaces to workspaces is good for clarity and consistency.
Suggestion: The addition of remote_state_consumer_ids variable is a good enhancement. Ensure that this variable is well-documented in variables.tf and that its usage is clear to users.

examples/complete/outputs.tf

Issue: Correcting the module reference in outputs from workdpaces to workspaces aligns with the fix in main.tf. This is a necessary change for consistency and to avoid errors.

examples/complete/variables.tf

Issue: The removal of the tags variable is a significant change. If this variable is no longer needed due to a change in the module's functionality or design, this is fine. However, ensure that this removal does not affect users who might have been using this variable for tagging resources.
Suggestion: After the removal of the tags variable, consider if there are alternative ways to handle tagging or if documentation needs to be updated to guide users on how to apply tags with the new version of the module.

> gpt-4-turbo-preview

:robot:
.github/workflows/ci.yaml

Suggestion: The disabling of the "Example Remote Validate" step is noted. If this is a temporary measure, consider adding a TODO comment to clarify the intention for future reference. For instance:# TODO: Re-enable remote validation once XYZ is resolved
# - name: Example Remote Validate

Issue: There's a typo in the commented-out section, "Exmaple" should be corrected to "Example".

README.md

Suggestion: The update to require Terraform >= 1.3 is clear. It might be helpful to briefly mention why this specific version requirement has been set, for the sake of clarity to the users.

examples/complete/main.tf

Issue: Corrected the typo in the module name from "workdpaces" to "workspaces". This is a necessary fix for consistency and to avoid confusion.
Enhancement: Addition of remote_state_consumer_ids variable is a good practice for managing dependencies between Terraform states. Ensure that this variable is well documented in variables.tf and README.md to help users understand its purpose and usage.

examples/complete/outputs.tf

Issue: Updated references from "workdpaces" to "workspaces" to match the corrected module name. This change is crucial for ensuring the outputs are correctly mapped.

examples/complete/variables.tf

Issue: The removal of the tags variable is noted. If this variable is no longer needed due to a change in the module's functionality or design, this change is justified. However, consider if there's a need for tagging resources for organisational or billing purposes.
Suggestion: After removing the tags variable, ensure that any documentation or examples that referenced it are also updated to reflect this change.

> gpt-4-turbo-preview

:robot:
.github/workflows/ci.yaml

Suggestion: The commented-out section for "Example Remote Validate" could be removed if it's no longer needed to keep the workflow file clean and maintainable.

README.md

No issues. The update to specify Terraform >= 1.3 aligns with the changes in the CI workflow.

examples/complete/main.tf

Issue: Typo in the module name "workdpaces" corrected to "workspaces". Good catch.

Enhancement: Addition of remote_state_consumer_ids variable usage is a good practice for managing remote state access.
module "workspaces" {
  ...
  remote_state_consumer_ids = var.remote_state_consumer_ids
  ...
}

examples/complete/outputs.tf

No issues. The correction of the module name in the outputs is consistent with the change in main.tf.

examples/complete/variables.tf

Suggestion: Removal of the unused tags variable is a good practice to avoid confusion. However, ensure that this variable is indeed not used anywhere in your Terraform configurations or by any consumers of the module. If it was intended for future use, consider documenting its purpose or implementing its usage before removal.

Overall, the changes are positive, focusing on cleaning up the codebase and aligning with best practices. Ensure any commented-out or removed code is not needed before finalizing these changes.
> gpt-4-turbo-preview

/code review

:robot:
Summary of Review
General Observations

The patches focus on updating the minimum Terraform version to 1.3 across various files, removing unused variables, and correcting a typo in a module name. These changes are generally positive, enhancing clarity and ensuring compatibility with newer Terraform versions.

Specific Suggestions and Issues

.github/workflows/ci.yaml

The update to the Terraform version matrix is appropriate given the shift to a minimum version of 1.3.
The disabling of the "Example Remote Validate" step might need justification. If it's temporary, consider adding a TODO comment.

README.md

The update to the minimum Terraform version is correctly reflected.

examples/complete/main.tf

Correcting the typo from "workdpaces" to "workspaces" improves readability and consistency.
Adding remote_state_consumer_ids without an example or default in variables.tf might lead to confusion. Ensure there's a default or example provided in the documentation or variables.tf.

examples/complete/outputs.tf

The correction in module references aligns with the typo fix in main.tf.

examples/complete/variables.tf

Removal of the tags variable is fine as long as it's indeed unused. Ensure that this change is communicated if the variable was previously documented or used in examples.

TERRAFORM.md, examples/complete/README.md, examples/complete/versions.tf, versions.tf

The updates to the minimum required Terraform version are consistent and correctly applied across these files.

Additional Notes

Ensure that all documentation and examples reflect the removal of the tags variable and the addition of remote_state_consumer_ids.
Consider adding a brief explanation or documentation for the removal of the "Example Remote Validate" step and the addition of remote_state_consumer_ids to guide users through these changes.

Overall, the patches make meaningful improvements to the codebase. However, attention to the potential impact of removed variables and disabled steps on end-users is advisable.
> gpt-4-turbo-preview


Add a license

Please add a license so other developers know what they are allowed to do with your source and what is forbidden.
http://choosealicense.com/licenses/

You should use a GPL compatible license, because several dependencies are GPL'd or use licenses which are GPL compatible.

fixed in 0e48fca


Mark project as deprecated

The description should probably be prefixed with "Deprecated" as well.

Closing stale PRs.


I get audio, but only a green screen instead of video playback

I'm submitting a ...

[ x ] bug report
[ ] feature request
[ ] support request

General infomration
Prerequisites

[x ] Are you running the latest version?

Description
Audio plays fine, video is only a green screen.
Steps to Reproduce

Try to play anything. With laptop screen or with HDMI monitor, nothing plays.

Expected behavior: Video plays
Actual behavior: Only a green screen.
Context (Environment)
Using Windows 10, AMD CPU, AMD GPU. Dell Inspiron 13 7375.
Installation

[x ] I installed the plugin via zip from the Releases page
[ ] I´m using the Netflix Repo
[ ] I´m using a different source (Please tell which)

Operating System

[ ] Linux (x86/x64)
[ ] OSX (x86/x64)
[x ] Windows (x86/x64)
[ ] Linux (ARM)
[ ] Android

Additional information on the environment
Leia RC2
Debug log
http://paste.kodi.tv/kamemorofa
Other information
I guess it is something related to my hardware, as this seems to work fine for everyone else.

I does not work because you have HEVC Enabled and you are not on Android, so Go Plugin Settings, Expert and disabled HDR and DDVision under HEVC, and then disable HEVC, and It will work.

These were disabled previously and it did not work either.
I disabled them and tested again, still only get a green screen, test run logs below.
http://paste.kodi.tv/gahorumola
http://paste.kodi.tv/usotuyiged

Go input stream settings section on netflix addon settings and set stream selection to manual and select all in streams... And restart tuen try to play something and change the resolutions by clicking settings on video playback...please share your results

I just remember that I had that issue when I enebled OMX player, try disabling it

@jakermx , he is "Using Windows 10, AMD CPU, AMD GPU. Dell Inspiron 13 7375."

I think I found the issue and the fix. In short: it is a driver issue, AMD is the faulty part.
After noticing VLC also gave me a green screen on some X.265 videos, I googled about it, then disabled Direct3D11 in VLC and it worked.
Tried the same in Kodi, but sadly Netflix DXVA fails in Kodi even if it works in VLC.
Software decoding, on the other hand, works perfectly. This Ryzen CPU is fast enough to use Software decoding with all the movies I have tried, so this is it.


Crate breaks with different build targets

I am attempting to write some code to control a robot in Rust using the EV3 brick and with ev3dev-lang-rust. I want to use and Xbox Controller to control it and have used this crate for Xbox control before. To use the ev3dev crate for rust you are required to use a linux musleabi toolchain which I have found a compatible dll for but the crate breaks with that build target. I attempt to call rusty_xinput::XInputHandle for my handler but the compiler tells me that it cannot find XInputHandle in rusty_xinput.

Would there be any way to make this crate work with different build targets or would I need to create me own interface with the dll or find a different crate? Thank you for the amazing crate and thanks for any help in advance!

https://github.com/Lokathor/rusty-xinput/blob/master/src/lib.rs#L28
This line here is what makes the whole module be effectively blank when not on windows.
Normally, I'd say we can just add a cargo feature to allow the crate to build more places if another crate provides a compatible interface, but I think that the winapi crate (which this crate depends on for many of its definitions) is itself configured to be windows only.
The docs at https://docs.rs/ev3dev-lang-rust don't seem to show the base windows definitions, how are you getting them on linux?

First of all thank you for your help I greatly appreciate it.  This means you cannot use the crate without configuring your build target to the Linux musleabi toolchain. Essentially to my understanding it just doesn't have Windows bindings. I have attempted to use the crate without a configured build target but it just produces similar issues the the one found here. I will look into the winapi crate and see if there is any way to make this work on Linux. If not then I will have a look at some other XInput handlers as I know of at least one in a different language to Rust which is built for Linux.  Thanks again for your help

I have looked into winapi and it doesn't appear to be at all compatible with Linux not altogether shockingly. I am using this https://github.com/kozec/dumbxinputemu for an XInput dll on Linux and am now trying to port over some of the functionality used for windows onto Linux.

If you just provide all the defines that rusty-xinput imports the rest should "just work" in terms of those definitions, though since they could theoretically vary by target and your "use xinput on linux" situation sounds rather unusual there could be some unexpected problem.
If you figure it out and get it working I'd be happy to try and integrate it back into this crate. Without your special linux device I'm bot sure how much help i can provide from my end though.

When you say provide all the defines do you mean just define them eg for XInputHandle just something like ```
#[cfg(not(windows))]
#[derive(clone)]
pub struct XInputHandle {}

I was thinking more like a use that imports the definition from whichever other crate, but if we have to then we could define the types directly in this crate I guess.

Ahh ok I didn't think of that I will try have a look at both, thank you again


Rye init script in a folder named python breaks rye causing symbolic loop

Steps to Reproduce

Install rye with the default values curl -sSf https://rye.astral.sh/get | bash

Welcome to Rye!

This installer will install rye to /home/tomas/.rye

This path can be changed by exporting the RYE_HOME environment variable.

Details:
  Rye Version: 0.36.0
  Platform: linux (x86_64)

✔ Continue? · yes
✔ Select the preferred package installer · uv (fast, recommended)
✔ What should running `python` or `python3` do when you are not inside a Rye managed project? · Run a Python installed and managed by Rye
✔ Which version of Python should be used as default toolchain? ·<EMAIL_ADDRESS>Installed binary to /home/tomas/.rye/shims/rye
Bootstrapping rye internals
Fetching requested internal toolchain<EMAIL_ADDRESS>Downloading<EMAIL_ADDRESS>Checking checksum
Unpacking
Downloaded<EMAIL_ADDRESS>Updated self-python installation at /home/tomas/.rye/self

The rye directory /home/tomas/.rye/shims was not detected on PATH.
It is highly recommended that you add it.
✔ Should the installer add Rye to PATH via .profile? · yes
Added to PATH.

Create a folder for a project mkdir -p myproject/python && cd myproject/python
rye init --script
rye sync
Run rye add -d ruff or any other package. Or any other command where rye uses python.

Expected Result
Some sort of error or at least warning when running rye init --script inside a folder named python.
At first it wasn't obvious to me that Rye would end up using my package named python to execute commands internally and simply break without any error or warning, specially because at no point I executed explicitly any command to install my python in my system nor told rye to use that version.
This isn't a problem when simply running rye init inside a folder named python.
If you are wondering why I'm running rye init --script inside a folder named python, that is because I was creating a repository with a problem solved in different programming languages and one of them was python.
Maybe add an error when trying to execute inside a folder named python and a flag like -i or --ignore to ignore errors in case someone really knows what they are doing and wants to install their python anyway.
Actual Result
[~/myproject/python] $ rye add -d ruff
error: Failed to run uv compile DEBUG uv 0.2.22
DEBUG Starting Python discovery for Python 3.12.3
DEBUG Looking for exact match for request Python 3.12.3
DEBUG Searching for Python 3.12.3 in system path
DEBUG Failed to query Python interpreter at `/home/tomas/myproject/python/.venv/bin/python3`
error: Failed to query Python interpreter at `/home/tomas/myproject/python/.venv/bin/python3`
  Caused by: Too many levels of symbolic links (os error 40)
. uv exited with status: exit status: 2

Even on other projects it will stop working unless I reinstall rye
[~/myproject] $ mkdir -p foobar && cd foobar
[~/myproject/foobar] $ rye init
success: Initialized project in /home/tomas/myproject/foobar/.
  Run `rye sync` to get started
[~/myproject/foobar]$ rye sync
Initializing new virtualenv in /home/tomas/myproject/foobar/.venv
Python version<EMAIL_ADDRESS>DEBUG uv 0.2.22
DEBUG Checking for Python interpreter at path<EMAIL_ADDRESS>  × Failed to query Python interpreter at<EMAIL_ADDRESS>  ╰─▶ Too many levels of symbolic links (os error 40)
error: failed creating virtualenv ahead of sync

Caused by:
    0: failed to initialize virtualenv
    1: Failed to create self venv using<EMAIL_ADDRESS>uv exited with status: exit status: 1

Version Info
rye 0.36.0
commit: 0.36.0 (12c024c7c 2024-07-07)
platform: linux (x86_64)
self-python<EMAIL_ADDRESS>symlink support: true
uv enabled: true

Stacktrace
No response

Should be fixed by https://github.com/astral-sh/uv/pull/5165 in the next uv release. Thank you!


markdown: Inline Youtube previews instead of appending it to the end.

This change makes our handling of youtube-url previews consistent with how we handle our inline images. This allows the reviews to render next to the paragraph that links to the youtube video.
Follow-up to PR #15773 & #15828
GIFs or Screenshots:

Tests passing on CircleCI

@timabbott can you please review this?

Merged, thanks @vinitS101!


Feat/replace prints by logging

OAMG-10974

@r0x0d I think this should be last changes that we did in c2r tasks that are not here - logging + sos report (I know we did some changes in RequiredFile class but we do not use it here).
I am just updating it to reduce the risk of repeating same issues that we already solved with c2r tasks because of the expected preupgrade task move to prod env.


feat: add reworked card examples

Adds examples to fit the card rework.

Cool stuff! Feel free to merge when you think it's ready! And thanks for all the effort.

@ctron could you publish 0.6.0 of patternfly-yew?

@ctron could you publish 0.6.0 of patternfly-yew?

I would like to do a few cleanups there first. Being able to break stuff :wink:
I think using a git patch for now is fine.


Internationalization (i18n) upgrade

use globalize (or similar), wrap it with cs-localization-provider
Move current localization values to external file.

https://angular.io/guide/i18n
https://github.com/ngx-translate/core (external file loading?)

Maybe take a look at this library: https://github.com/Romanchuk/angular-i18next.
It has a version that we can use on the backend as well: https://github.com/i18next/i18next-express-middleware
Might be beneficial to use the same lib in both projects


Feat/image set model

/retest

This is looking sooooooooo good 👍🏻 One last comment and we're good to go!

Really looks good, great work Ana

/retest


restic check dumps a stack trace

Output of restic version
restic 0.9.3 compiled with go1.11.1 on linux/amd64
How did you run restic exactly?
restic -p /opt/scripts/restic.pass check
What backend/server/service did you use to store the repository?
azure account
Expected behavior
check output, that i understand ;-)
Actual behavior

github.com/restic/restic/internal/repository.FilesInParallel.func2(0x8, 0xc32ab0)
/restic/internal/repository/parallel.go:40 +0xaa
golang.org/x/sync/errgroup.(*Group).Go.func1(0xc0001e7650, 0xc0001e7dd0)
/restic/vendor/golang.org/x/sync/errgroup/errgroup.go:58 +0x57
created by golang.org/x/sync/errgroup.(*Group).Go
/restic/vendor/golang.org/x/sync/errgroup/errgroup.go:55 +0x66
goroutine 754 [select]:
net/http.(*persistConn).writeLoop(0xc00034d320)
/usr/local/go/src/net/http/transport.go:1885 +0x113
created by net/http.(*Transport).dialConn
/usr/local/go/src/net/http/transport.go:1339 +0x966
goroutine 810 [IO wait]:
internal/poll.runtime_pollWait(0x7f031b134c90, 0x72, 0xc063dc7858)
/usr/local/go/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc03e716a18, 0x72, 0xffffffffffffff00, 0xccf960, 0x116c4e0)
/usr/local/go/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc03e716a18, 0xc00b254000, 0x400, 0x400)
/usr/local/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc03e716a00, 0xc00b254000, 0x400, 0x400, 0x0, 0x0, 0x0)
/usr/local/go/src/internal/poll/fd_unix.go:169 +0x179
net.(*netFD).Read(0xc03e716a00, 0xc00b254000, 0x400, 0x400, 0x40862b, 0xc0001be000, 0xb2e140)
/usr/local/go/src/net/fd_unix.go:202 +0x4f
net.(*conn).Read(0xc000208070, 0xc00b254000, 0x400, 0x400, 0x0, 0x0, 0x0)
/usr/local/go/src/net/net.go:177 +0x68
crypto/tls.(*block).readFromUntil(0xc03e1dad50, 0xcce2a0, 0xc000208070, 0x5, 0xc000208070, 0x342b4ba25f09a275)
/usr/local/go/src/crypto/tls/conn.go:492 +0x89
crypto/tls.(*Conn).readRecord(0xc00006a380, 0xc32a17, 0xc00006a4a0, 0x601c7248b4ceb22b)
/usr/local/go/src/crypto/tls/conn.go:593 +0xdd
crypto/tls.(*Conn).Read(0xc00006a380, 0xc069886000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
/usr/local/go/src/crypto/tls/conn.go:1145 +0xf1
net/http.(*persistConn).Read(0xc00034c360, 0xc069886000, 0x1000, 0x1000, 0x404a93, 0xc0008acc70, 0x429762)
/usr/local/go/src/net/http/transport.go:1497 +0x75
bufio.(*Reader).fill(0xc01a284cc0)
/usr/local/go/src/bufio/bufio.go:100 +0x106
bufio.(*Reader).Peek(0xc01a284cc0, 0x1, 0xc0002f41e0, 0xc0008acd58, 0x756ad655639d95fc, 0x2ab050be5edb048d, 0xe0d396990451c04e)
/usr/local/go/src/bufio/bufio.go:132 +0x3f
net/http.(*persistConn).readLoop(0xc00034c360)
/usr/local/go/src/net/http/transport.go:1645 +0x1a2
created by net/http.(*Transport).dialConn
/usr/local/go/src/net/http/transport.go:1338 +0x941
goroutine 809 [select]:
github.com/restic/restic/internal/repository.(*Index).Each.func1(0xc06481ea00, 0xc0002c8ea0, 0xcd6340, 0xc000122ac0)
/restic/internal/repository/index.go:223 +0x2d7
created by github.com/restic/restic/internal/repository.(*Index).Each
/restic/internal/repository/index.go:215 +0x8f
goroutine 811 [select]:
net/http.(*persistConn).writeLoop(0xc00034c360)
/usr/local/go/src/net/http/transport.go:1885 +0x113
created by net/http.(*Transport).dialConn
/usr/local/go/src/net/http/transport.go:1339 +0x966
goroutine 753 [IO wait]:
internal/poll.runtime_pollWait(0x7f031b134a20, 0x72, 0xc00b03d858)
/usr/local/go/src/runtime/netpoll.go:173 +0x66
internal/poll.(*pollDesc).wait(0xc06812ce98, 0x72, 0xffffffffffffff00, 0xccf960, 0x116c4e0)
/usr/local/go/src/internal/poll/fd_poll_runtime.go:85 +0x9a
internal/poll.(*pollDesc).waitRead(0xc06812ce98, 0xc0682c2000, 0x8000, 0x8000)
/usr/local/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d
internal/poll.(*FD).Read(0xc06812ce80, 0xc0682c2000, 0x8000, 0x8000, 0x0, 0x0, 0x0)
/usr/local/go/src/internal/poll/fd_unix.go:169 +0x179
net.(*netFD).Read(0xc06812ce80, 0xc0682c2000, 0x8000, 0x8000, 0x40862b, 0xc0001be000, 0xb2e140)
/usr/local/go/src/net/fd_unix.go:202 +0x4f
net.(*conn).Read(0xc000208378, 0xc0682c2000, 0x8000, 0x8000, 0x0, 0x0, 0x0)
/usr/local/go/src/net/net.go:177 +0x68
crypto/tls.(*block).readFromUntil(0xc046186c30, 0xcce2a0, 0xc000208378, 0x5, 0xc000208378, 0x448b0a)
/usr/local/go/src/crypto/tls/conn.go:492 +0x89
crypto/tls.(*Conn).readRecord(0xc000156000, 0xc32a17, 0xc000156120, 0x454870)
/usr/local/go/src/crypto/tls/conn.go:593 +0xdd
crypto/tls.(*Conn).Read(0xc000156000, 0xc068002000, 0x1000, 0x1000, 0x0, 0x0, 0x0)
/usr/local/go/src/crypto/tls/conn.go:1145 +0xf1
net/http.(*persistConn).Read(0xc00034d320, 0xc068002000, 0x1000, 0x1000, 0xc00b03dc70, 0x404c85, 0xc0001215c0)
/usr/local/go/src/net/http/transport.go:1497 +0x75
bufio.(*Reader).fill(0xc063933500)
/usr/local/go/src/bufio/bufio.go:100 +0x106
bufio.(*Reader).Peek(0xc063933500, 0x1, 0x0, 0x0, 0x1, 0xc00002cc60, 0x0)
/usr/local/go/src/bufio/bufio.go:132 +0x3f
net/http.(*persistConn).readLoop(0xc00034d320)
/usr/local/go/src/net/http/transport.go:1645 +0x1a2
created by net/http.(*Transport).dialConn
/usr/local/go/src/net/http/transport.go:1338 +0x941

Steps to reproduce the behavior
don't know
Do you have any idea what may have caused this?
perhaps low ram. but dmesg doesnt' show anything.
Do you have an idea how to solve the issue?
sorry - no.
Did restic help you or made you happy in any way?
perfect backup - but i am not sure right now, if the backup is error free.

This indicates a crash.  However, it looks like the panic log is missing some lines at the beginning, which should indicate what caused the panic.  Can you capture the complete output?
restic -p /opt/scripts/restic.pass check 2>&1 >restic.log

Thanks @cdhowie 👍
as expected the pc runs out of memory:

fatal error: runtime: out of memory
runtime stack:
runtime.throw(0xc0d786, 0x16)
/usr/local/go/src/runtime/panic.go:608 +0x72
runtime.sysMap(0xc088000000, 0x14000000, 0x11e41d8)
/usr/local/go/src/runtime/mem_linux.go:156 +0xc7
runtime.(*mheap).sysAlloc(0x11ca7a0, 0x14000000, 0x7faa42770c10, 0xc0007c1e30)
/usr/local/go/src/runtime/malloc.go:619 +0x1c7
runtime.(*mheap).grow(0x11ca7a0, 0x9080, 0x0)
/usr/local/go/src/runtime/mheap.go:920 +0x42
runtime.(*mheap).allocSpanLocked(0x11ca7a0, 0x9080, 0x11e41e8, 0x20300500000000)
/usr/local/go/src/runtime/mheap.go:848 +0x337
runtime.(*mheap).alloc_m(0x11ca7a0, 0x9080, 0xc000270101, 0x7faa00000001)
/usr/local/go/src/runtime/mheap.go:692 +0x119
runtime.(*mheap).alloc.func1()
/usr/local/go/src/runtime/mheap.go:759 +0x4c
runtime.(*mheap).alloc(0x11ca7a0, 0x9080, 0xc000010101, 0x43afc5)
/usr/local/go/src/runtime/mheap.go:758 +0x8a
runtime.largeAlloc(0x12100000, 0x101, 0x1)
/usr/local/go/src/runtime/malloc.go:1019 +0x97
runtime.mallocgc.func1()
/usr/local/go/src/runtime/malloc.go:914 +0x46
runtime.systemstack(0xc000231110)
/usr/local/go/src/runtime/asm_amd64.s:351 +0x66
runtime.mstart()
/usr/local/go/src/runtime/proc.go:1229

are there any rules of thumb how much RAM is needed for checking a repo?

I'm not sure how much RAM is needed to be honest, but you could try increasing the amount of swap on the system.  The check will probably cause the machine to thrash, however.  If you don't mind waiting some hours for the check to complete, it might be okay.

increased the swap to 8 GB. still the same error (but different call stack).
Now trying again with 64 GB.

Note that I would expect the call stack to be different every time, regardless of changes to swap.  Any small amount of activity on the machine is likely to cause a slightly different amount of memory to be available to restic on every invocation, causing it to run out of memory at different points in the check procedure.
For reference, I ran a check against a 68GB repository, and /usr/bin/time -v claims:
Maximum resident set size (kbytes): 826636

826MB isn't really that much.  If we assume that memory usage scales linearly with repository size, then it appears that the memory usage required to check a repository is a little over 1% of the total size of the repository.
How large is the repository you are trying to check?

hmm... the backup is running for a couple of months now ;-) I'm keeping last 30 days, last 10 weeks, last 12 months and last 75 years - and delete the others.
so we have ~ 2400 GB of data. so 1% of 2400 GB = 24 GB.
let's see how long it takes and how much ram/swap it consumes.
any idea how to monitor the progress?

I don't believe there is a way to monitor the progress of a check operation.
I just confirmed that memory consumption is NOT linear to the size of the repository in bytes.  I ran a check on another repository.

Repo A: 68GB repository, check resident set peaked at 807MB.  (~86:1 ratio of size:RAM)
Repo B: 159GB repository, check resident set peaked at 172MB.  (~946:1 ratio of size:RAM)

Note that repo A stores system backups, so the tree structures are fairly deep, and there are many small files.  Repo B stores file server backups.  Most of the files are photos, so the tree structure is fairly flat, and most of the files are big.
It seems that the number of objects in the repository has more of an impact on the amount of memory required than the overall repository size.
Interestingly, this should correlate to the size of the indexes, so let's look at the size of the indexes instead:

Repo A: 109MB indexes, check resident set peaked at 807MB.  (~1:7.4 ratio of indexes:RAM)
Repo B: 20MB indexes, check resident set peaked at 172MB.  (~1:8.6 ratio of indexes:RAM)

These ratios are much closer.  Let's approximate that to a 1:8 ratio.  How much data is in the index directory in this repository?  Multiply that by 8, and that's an approximation of the maximum resident set that restic will need to check it.

here are the statistics of my archive. due to the fact that it is located on an azure-container and the check process is running, i can only provide bucket-statistics (the rough-statistics provided in my previous post were wrong - perhaps old cache values).
here are the absolute statistics of files and usage (count took over 3 minutes - so i hope they are correct now):

data dir: 998.944 blobs; 5.177.332.257.266 bytes
index dir: 1.034 blobs; 804.419.013 bytes
snapshots dir: 266 blobs; 73.727 bytes

804 MB index size * 8 = 6432 MB peak. During the last check 2 GB of ram and 8 GB of swap were not sufficient. I will monitor that and give feedback.

I don't believe there is a way to monitor the progress of a check operation.

That might be changing if #2003 successfully implements a command-agnostic progress reporter system :) /cc @ifedorenko  -- I for one would be happy to help integrate progress reporting for other commands like check, once that is ready.

#2003 already implements progress for check, backup and restore commands. give it a try and let me know if "ui" provides sufficient details. (hint: if you run headlessly or on non-ansi "dump" terminals, use -v flag to get less fancy but imho still very useful progress feedback).

still running (started: So 18. Nov 19:57:46 CET 2018). so around 47 hours now.
Max. swap was 14.5% of 68GB = 9.86 GB
i received a couple of errors (ms change and filename in "locks" folder change):
Save(<lock/7224ac0b9a>) returned error, retrying after 353.238012ms: CreateBlockBlobFromReader: Put https://xxx.blob.core.windows.net/resticazure/locks/7224ac0b9a3c80867d800be0e27d10cd87de445b7301d7d2da0e3337fa469844: net/http: TLS handshake timeout
Do I need to worry about them?

Do I need to worry about them?

Restic should continue to run, but it's not able to update the lock file.  As long as you don't have any concurrent Restic processes against this repo, you should be fine.
However, I might worry a bit about what is causing these timeouts in the first place.

This sometimes happens with some services, notably B2. All operations are retried, so unless restic aborts there's no need for worry.

so my check is finished:
Start: So 18. Nov 19:57:46 CET 2018
successfully removed locks
using temporary cache in /tmp/restic-check-cache-202571517
created new cache in /tmp/restic-check-cache-202571517
create exclusive lock for repository
load indexes
pack 9fd8fc40 contained in several indexes: {70be9a65 c93fcaae}
This is non-critical, you can run `restic rebuild-index' to correct this
check all packs
check snapshots, trees and blobs
no errors were found
End:   Mi 21. Nov 00:34:55 CET 2018
Duration: 52h:37m:9s

looks good to me. Max. swap was 14.5% of 68GB = 9.86 GB.
i'm afraid running rebuild-index because check took ~53h ;-)
how long would you expect running the rebuild-index command?
how much network traffic will be created?
what is the difference between prune und rebuild-index?
and would you recommend running check, rebuild-index and prune regulary? if yes when and any specific order?

I can't answer all of those questions but I will answer some.

what is the difference between prune und rebuild-index?

Prune does three things: (1) remove blobs not referenced by any snapshot, (2) remove duplicate blobs, and (3) rebuild the index.  Rebuild-index only rebuilds the index; it does not delete anything.

and would you recommend running check, rebuild-index and prune regulary? if yes when and any specific order?

I would not manually run rebuild-index because that's one of the things prune does.  You don't need to run both commands.
Prune will necessarily do some amount of checking, because it traverses every pack and every snapshot looking for blobs to delete.  (Note that it does not download the entirety of each pack, just the header from each pack to see what it contains, just like check (without --read-data) and rebuild-index.)
Prune is only useful if you have:

Deleted some snapshots; there may be unused blobs that can be deleted, or
Interrupted a backup; the uploaded blobs may be unused, or
Run two or more backups concurrently; they may have each uploaded the same blob, and a prune would deduplicate them.

A specific case in which you might opt to run check instead of prune is if you want to test the consistency of the repository, but there are ongoing backups.  Prune cannot run at the same time as any other repository activity, but I believe check only uses a read lock and can therefore run concurrently with backups.
As far as how often to prune, that depends on how often you delete snapshots and how much data you can delete, on average.  Running prune against a repository in cloud storage will probably incur some transfer and request costs, similar to a check.  The question is whether you will make up for those costs with the amount of data that is removed.  This isn't really something I can answer for you.

I just read through all the comments, this started out as a report that restic printed an error message which is very hard to understand, then we figured out that probably restic used too much memory. In the end, the restic check went through fine.
I think there's nothing we can do for this issue (apart from reducing restic's memory usage, see #1453 for that), so I'm closing this issue for now. Please feel free to add further comments. Thanks!


tsConfig ignored, but described in documentation. Should be tsConfigFile?

Hi, I've tried to change the tsconfig.json and in the docs: https://huafu.github.io/ts-jest/user/config/ you can find tsConfig. It even has its own page: https://huafu.github.io/ts-jest/user/config/tsConfig. However, when I used it in my package.json like so

  "jest": {
    "testEnvironment": "node",
    "transform": {
      "^.+\\.(ts|tsx)$": "ts-jest"
    },
    "testMatch": [
      "**/tests/**/*.spec.ts"
    ],
    "globals": {
      "ts-jest": {
        "tsConfig": "tsconfig.test.json"
      }
    }
  },

it was just ignored, no matter what the value was. But after changing it to tsConfigFile, everything works:
    "globals": {
      "ts-jest": {
        "tsConfigFile": "<rootDir>/tsconfig.test.json"
      }
    }

So, is the documentation wrong or what's going on here? :)

We have changed in v27 to tsconfig, in v26 also supports tsconfig and deprecate tsConfig.
you are not using the correct url for online documentation, which is at https://kulshekhar.github.io/ts-jest/

Oh, thanks! It's a shame that https://huafu.github.io/ts-jest/ is at the top results of my google search.


instances_trainval35k.json.zip open error

https://s3.amazonaws.com/amdegroot-datasets/instances_trainval35k.json.zip open error,is there other url to download this file?

Did you find a fix for this issue?
It looks like the zip file I downloaded from the link is also corrupt.

see here: https://github.com/amdegroot/ssd.pytorch/issues/205#issuecomment-412762997


add the description of coffees to the menu

in the menu section, on hovering, add a description of the coffee, to understand taste level and to ensure the right choice of coffee

Please assign this issue to me, I'll solve it

Please assign this issue to me, and I'll solve it

You can raise a different issue or similar, create a new issue @karanharshey

created my pull request


Replace notion-sdk-jvm with custom Spring Rest Client

Currently, Notion SDK JVM is used as an underlying dependency to use the Notion API.
Although it gives the benefit of accessing the API from Java without additional effort, it has a few downsides:

Brings Gson and Kotlin transitively
Currently blocks the introduction of a module descriptor (#14)
Could slow down the adoption of new API types released by Notion

An alternative could be to adopt one of the Rest Client options that Spring provides.

is anyone working on this ?

Hi @sakshipatil1305, not yet!
Before starting here, a few things are ongoing, including the move to the spring-batch-extensions repo (see #53 and spring-projects/spring-batch-extensions#147) which will lead to archiving this repository.
Plus, I have the feeling the integration tests should be improved before such a refactoring can be done, as more complex use cases are currently delegated to the dependency I'd like to remove.
Let me ping you once this topic is ready to be picked up, if you don't mind.

Superseded by spring-projects/spring-batch-extensions#154.


Permissions . An error occurred during permission preview

配置用户/角色/团队权限时，点击预览按钮，报错

全局导航重构完后再修复

resolved


Update bundle version to 4.2.0-rc.5

It would be ideal if only a single change would be needed in future.


url too long, spyder 3.2.6

Problem Description

I clicked on preferences, then keyboard shortcuts and got a window popup with title, error.
Clicked on Submit to Github, I get URL too long on my browser (FF 85.0)

Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

  File "/usr/lib/python3/dist-packages/spyder/widgets/helperwidgets.py", line 127, in paint
    textRect = style.subElementRect(QStyle.SE_ItemViewItemText, options)
TypeError: subElementRect(self, QStyle.SubElement, QStyleOption, QWidget): not enough arguments
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/spyder/widgets/helperwidgets.py", line 127, in paint
    textRect = style.subElementRect(QStyle.SE_ItemViewItemText, options)
TypeError: subElementRect(self, QStyle.SubElement, QStyleOption, QWidget): not enough arguments
Traceback (most recent call last):

this error repeats many many times hence the URL too long error.

Versions

Spyder version: 3.2.6
Python version:  3.6.9
Qt version:
PyQt version:
Operating System name/version: Linux Mint MATE 19.3 (kernel 5.4.0-65-generic)

Hi @pakair. This was fixed in spyder 4 please update to our latest version.
From your comand line run:
conda update anaconda
conda update spyder

Hi @pakair. This was fixed in spyder 4 please update to our latest version.
From your comand line run:
conda update anaconda
conda update spyder

Thank you for your reply. I do not have conda installed.
I installed spyder3 just with "sudo apt install spyder3" which brought in 3.2.6

Thank you for your reply. I do not have conda installed.
I installed spyder3 just with "sudo apt install spyder3" which brought in 3.2.6

I think the solution is then to create a virtualenv and install spyder 4 with pip. Please check the "Using Pip" section of our Installation Guide https://docs.spyder-ide.org/current/installation.html#using-pip
Warning: Please don't do sudo pip install spyder because you can break your environment.

I followed the guide you provided and was able to install spyder 4.2.1 in its own virtualenv but I saw errors (line 314 and further) during the install. Here's the log of the install, https://l.termbin.com/g21b
Maybe you can tell me if I can fix those errors. Thank you.

@pakair, please run in your virtualenv
pip install wheel

then try again. That should fix the errors you're seeing.

When you say, "try again" should I remove the (spyder-env) completely and use the same commands I used before?
python3 -m venv spyder-env
source spyder-env/bin/activate
pip install wheel
pip install spyder

Yeah, that's correct.

thank you ... install was good, no errors. I'll close this ticket.


Correct source map line numbers

When generating source maps the source map line numbers are sometimes incorrect.
This pull request fixes that.

@deedw could you add simple test? Probably a good time to start having it