Add character countdown to commit message input

See #21144.
I miss warnings against long commit messages. I like Atom’s way of showing a persistent character countdown (see below). It’s subtle and easy to ignore.

I’ve knocked something up quickly using InputBox’s built-in validation box.

I haven’t put much thought into the UI. Happy to hear more ideas!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: jayjun sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

@jayjun
There is a setting in extensions/git/package.nls.json
"config.enableLongCommitWarning": "Whether long commit messages should be warned about",

I don't know how the settings work in VS Code presently, but you might be able to work with that setting about whether to display the box.
I would suggest adding an additional setting for the number to cut off rather than hardcoding 72… something like
"config.longCommitWarningThreshold": "The number representing the maximum limit for an acceptable commit message",

I don't have the build tools in front of me or anything yet.
As an aside: I try to keep all my commits to <= 50 characters, since I think that's what the cutoff used to be in VS Code before the feature was dropped this year :)

@scottclayton The warning feature was dropped when Git moved into an extension. The config.enableLongCommitWarning exists as a vestige in package.nls.json only (localisation file).
I would imagine commit message limits are universal across SCMs anyway, within organisations or projects at least and not limited to the Git extension.
As for settings, I can’t find an IConfigurationService nearby to access values. Any ideas?

We used to have this when Git wasn't an extension. Now that it is, this behaviour needs to go into API.
Would you like to continue the work and expose SourceControlInputBox.warningLength: number | undefined?

@joaomoreno Forgive my ignorance, I’m still new to the codebase.
Is the API for exposing the setting from host to extension, extension to host, or both? As I argued above, I think users rarely need a different length warning for different SCM providers.

It's our extension API. It's not a user setting, it would be an API exposed to an extension. Git might use 80, while Perforce doesn't have a limit.

@joaomoreno SourceControlInputBox.warningLength added.
I’ve hard-coded Git’s warning length for now because I’m not familiar with implementing extension settings.
I would appreciate some guidance on localising strings as well. Do we have plural support?

Any update on this? It's been a month since there was any activity

@DuckyCrayfish It already works perfectly, and I occasionally rebase it onto master while waiting for feedback.
If you want to see this merged, 👍 the topmost comment to upvote! That’s how the VS Code team ranks what goes into the next release.

@jayjun Oh, wonderful, I got thrown off by the CI failure. Thanks for getting back to me, I'll give this a thumbs up.

Hi guys ✋ sorry for jumping in so late.
I've made a few changes:

The warning length should be per line, not for the whole value
There should be a way to control the behaviour, so I've introduced a scm.inputCounter setting with the following possible values: ['always', 'warn', 'none']. I've picked warn as the default: it only shows the counter once you are over the limit

Thanks! 🍻

Hi @joaomoreno did the scm.inputCounter setting make it into a release? I'm trying to set it in VS Code 1.20.0, but it doesn't seem to be recognised

Unfortunately, the configuration variable git.inputValidation is not documented on the release notes of 1.20. Moreover, the screenshot corresponds to git.inputValidation="always" whereas the default value is git.inputValidation="warn".

@jlelong Great catch! I've updated the setting name and described the screenshot's behaviour: https://github.com/Microsoft/vscode-docs/pull/1387 Thanks! 🍻

I've also been struggling with this a bit, I was searching for "commit" and "length" in settings which didn't find anything because of this:
  // Controls when to show input validation.
  "git.inputValidation": "warn"

Maybe the comment could include a couple of useful keywords 😉

@borekb https://github.com/Microsoft/vscode/commit/38ab7346468f598a49f8e89c2c43430e87bbaa25

Please, @joaomoreno , any way to customize the characters warning limit?

Thanks @joaomoreno "git.inputValidation": "off" has sorted it for me 👍

@robsonsobral Sure, would you like to submit a PR?

any way to customize the characters warning limit?

There's an issue specifically for that: #18807.

@joaomoreno , I'm not sure on how to proceed, but I gonna try.

I really like that this feature has made it in but I would like it to actually follow the very common pattern of having a 50 character summary line, and then an empty line before allowing a 72 character body.
It would be really nice if that would work somehow or could be configured in a way, although I’m not sure if that would not conflict with that API setting mentioned above since that only applies globally, and would not allow for line-based validation.

@poke I would definitely prefer the way you described to work to be implemented, but maybe doing what was described at https://github.com/Microsoft/vscode/issues/18807#issuecomment-366320043 could be a simpler solution, as it would attend all public.
It would be nicer though if you could add three settings to what we already have today, those being headerLength, bodyLength and footerLength (or some other name), that would validate the length of the header, body, and the footer of the commit, and if it is not compliant, show the warn that is implemented today

This is just non-sense ... set your GIT_EDITOR = code, then
from the vscode terminal do
git add -A
git commit
(opens an editor with your changes)
do whatever
save
that's it


[Feature Request] Declaring classes without class loading?

In some cases, dynamically loading classes is not allowed.

The new SecurityGuard should allow you to protect against initializing unauthorized classes see #770
https://github.com/beanshell/beanshell/blob/53b0436f4e2777e5ec8c8f60e565c7ef48f3b18b/src/test/java/bsh/SecurityGuardTest.java#L76-L94
@Tianscar please confirm that this is sufficient


Packet factory

implementation of a packet-factory
const Packet = require("./Packet.js")
Packet.from(...)

packet.from expects and ESP3Packet, a raw buffer, a string or a struct with at least { header:{ packetType:x } }
maybe we can add Packet.from(number) where number is a valid packetType

I'll heck this in and start work on the eep front. it might be easier to see what is need here.


Gitlab Container Scanning schema changed and causing issues while importing scan

Slack us first!
The easiest and fastest way to help you is via Slack. There's a free and easy signup to join our #defectdojo channel in the OWASP Slack workspace: Get Access.
If you're confident you've found a bug, or are allergic to Slack, you can submit an issue anyway.
Be informative
Please enter as much information as possible, otherwise we can't provide support. If possible upgrade to the latest release or dev version and try again.
Bug description
Hi guys, the Gitlab Container Scan parser is using an old version of the Gitlab Security Report Schema for containers, some properties have been removed causing scan import to fail (see logs).
One example in the code causing the issue (based on the logs below): https://github.com/DefectDojo/django-DefectDojo/blob/master/dojo/tools/gitlab_container_scan/parser.py#L34
As you can see here in the version v15.0.0 of the Gitlab Security Report Schemas (https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/blob/master/CHANGELOG.md#v1500) some properties on the Vulnerability schema have been removed. In the example code provided above, the vulnerability.message property is causing an issue because the property doesn't exist anymore.
Gitlab has now adopted schema v15 in their Container Scanning template: https://gitlab.com/gitlab-org/gitlab/-/issues/364369.
For those having this issue and finding a quick way to fix that temporarily, add this variable after including the Gitlab Container Scanning template:
include:
  - template: Security/Container-Scanning.gitlab-ci.yml

variables:
  CS_SCHEMA_MODEL: 14

Please note that previous versions of the schema will be deprecated in GitLab 15.8 for removal in 16.0.
Steps to reproduce
Steps to reproduce the behavior:

Include  template: Security/Container-Scanning.gitlab-ci.yml in your Gitlab CI;
Build a container via your CI;
Import the gl-container-scanning-report.json file report to Defect Dojo;
See error.

Expected behavior
The new Gitlab Security Schema should be updated to match Container Scanning parser needs. The latest version of the Defect Dojo doesn't implement this.
Deployment method (select with an X)

[ ] Docker Compose
[x] Kubernetes
[ ] GoDojo

Environment information

Operating System: Alpine latest
DefectDojo version (see footer) or commit message: v2.19.2

Logs
File "/usr/local/lib/python3.11/site-packages/rest_framework/views.py", line 506, in dispatch
    response = handler(request, *args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/rest_framework/mixins.py", line 19, in create
    self.perform_create(serializer)
  File "/app/dojo/api_v2/views.py", line 2054, in perform_create
    serializer.save(push_to_jira=push_to_jira)
  File "/app/dojo/api_v2/serializers.py", line 1600, in save
    test, finding_count, closed_finding_count, test_import = importer.import_scan(scan, scan_type, engagement, lead, environment,
                                                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/dojo/importers/importer/importer.py", line 303, in import_scan
    parsed_findings = parser.get_findings(scan, test)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/dojo/tools/gitlab_container_scan/parser.py", line 34, in get_findings
    title = vulnerability["message"]
            ~~~~~~~~~~~~~^^^^^^^^^^^
KeyError: 'message'
[27/Mar/2023 10:14:08] ERROR [django.request:241] Internal Server Error: /api/v2/import-scan/

Sample scan files
A sample of one vulnerability in the gl-container-scanning-report.json file:
{
    "id": "85b20c6512c00bf124ee0ef63a348ba37da75946",
    "severity": "Medium",
    "location": {
      "dependency": {
        "package": {
          "name": "openssl"
        },
        "version": "3.0.8-r0"
      },
      "operating_system": "alpine 3.17.2",
      "image": "dockerhub.com/billing/store:4d203d07d14047ad0acd015b5e6363f2ed364b5e"
    },
    "identifiers": [{
      "type": "cve",
      "name": "CVE-2023-0464",
      "value": "CVE-2023-0464",
      "url": "https://access.redhat.com/security/cve/CVE-2023-0464"
    }],
    "links": [{
      "url": "https://access.redhat.com/security/cve/CVE-2023-0464"
    }, {
      "url": "https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-0464"
    }, {
      "url": "https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=2017771e2db3e2b96f89bbe8766c3209f6a99545"
    }, {
      "url": "https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=2dcd4f1e3115f38cefa43e3efbe9b801c27e642e"
    }, {
      "url": "https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=879f7080d7e141f415c79eaa3a8ac4a3dad0348b"
    }, {
      "url": "https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=959c59c7a0164117e7f8366466a32bb1f8d77ff1"
    }, {
      "url": "https://www.openssl.org/news/secadv/20230322.txt"
    }],
    "description": "A security vulnerability has been identified in all supported versions of OpenSSL related to the verification of X.509 certificate chains that include policy constraints. Attackers may be able to exploit this vulnerability by creating a malicious certificate chain that triggers exponential use of computational resources, leading to a denial-of-service (DoS) attack on affected systems. Policy processing is disabled by default but can be enabled by passing the `-policy' argument to the command line utilities or by calling the `X509_VERIFY_PARAM_set1_policies()' function.",
    "solution": "Upgrade openssl to 3.0.8-r1"
  }

Screenshots
If applicable, add screenshots to help explain your problem.
Additional context (optional)
Add any other context about the problem here.

This change actually targets Vulnerability schema for all Gitlab scans: https://gitlab.com/gitlab-org/security-products/security-report-schemas/-/merge_requests/109/diffs

We are also facing the same issue and trying to figure out if there is a possibility to point to previous version of Gitlab container scan in the pipeline.


CPMR0001 implementation more strict than package validator.

Checklist

[X] I have verified this is the correct repository for opening this issue.
[X] I have verified no other issues exist related to my problem.
[X] I have verified this is not an issue for a specific package.
[X] I have verified this issue is not security related.
[X] I confirm I am using official, and not unofficial, or modified, Chocolatey products.

What You Are Seeing?
When trying to pack a package with an empty checksum element, the CPMR0001 rule get triggered. This does not happen for packages going through the validator.
What is Expected?
That packages with an empty checksum element do not fail CPMR0001, to be consistent with the validator behavior.
https://community.chocolatey.org/packages/libreoffice-fresh
How Did You Get This To Happen?

Get the source libreoffice-fresh at https://github.com/chocolatey-community/chocolatey-packages/tree/master/automatic/libreoffice-streams
Run choco pack in the directory
See that pack fails with CPMR0001

System Details

Operating System: Windows 10 22H2
Windows PowerShell version: 5.1
Chocolatey CLI Version: 2.2.2
Chocolatey Licensed Extension version: N/A
Chocolatey License type: Open source
Terminal/Emulator: PowerShell

Installed Packages
Not applicable.

Output Log
https://gist.github.com/TheCakeIsNaOH/8dda18d47a98ebabeae24058ba1d21b1

Additional Context
No response

It is intentional that the rule is stricter than the implementation in package validator. In this, we are taking what the rule description is specified as, instead of doing a 1-to-1 like of the implementation in package validator. If it had been the other way around, that this extension wouldn't have flagged the empty Copyright element, but the package validator had flagged it, this would have been a bug.


Adjust local storage paths and fix typo

These changes are super minor but caught my eye. On mac and linux machines, using spaces in path names is discouraged because it sometimes does not get parsed correctly (e.g., for tab autocomplete on the command line). Lower-case directory names are more commonplace, and I kind of prefer them, so I propose that change too.
There were two local storage folders getting created: NWB GUIDE and NWBGUIDE. The latter held the logs folder. I merge those.

Had to copy over my old pipelines, but that's fine

Had to push a couple fixes from another branch when testing this one (namely that the stub files went to the new directory) - merge if you agree with changes @rly


WIP: Applications manager

Implements the application manager:
Current problems:

get_ticket doesn't work at all, but I think it is discord's fault (there's an error in the client's dev console).
another external dependency is needed. I precompiled it for windows and Linux and a second download, but that is not an optimal solution. I will have to check again if Godot provides the functionality that is needed.

What's the external dependency?

What's the external dependency?

libsodium - a crypto library

libsodium - a crypto library

So what do plan to do? Fixing the current problems?

So what do plan to do? Fixing the current problems?

What's the use of the get_ticket btw?


Fix 404 link on Mobilizon

As Mobilizon demo is reseting every 48h, the actual link to a specific event is now 404.

@alcalyn - thanks i didnt know about this


fingerprinting deception mitigations

Is your feature request related to a problem? Please describe.
https://www.bromite.org/detect
Describe the solution you'd like, including relevant patches or source
Add fingerprinting mitigations from Bromite and Ungoogled Chromium
https://github.com/bromite/bromite/blob/master/build/patches/Multiple-fingerprinting-mitigations.patch
https://github.com/ungoogled-software/ungoogled-chromium/blob/master/patches/extra/bromite/flag-fingerprinting-canvas-image-data-noise.patch
https://github.com/ungoogled-software/ungoogled-chromium/blob/master/patches/extra/bromite/fingerprinting-flags-client-rects-and-measuretext.patch
Additional Notes
I would like to have both fingerprint mitigation and SIMD optimization, but I don't have a computer and network powerful enough to build a custom Chromium that combines both

@arm64-v9a I can take a look at these and see if I can add them to thorium.


Remove unnecessary things from config

if zmq and fastButRisky is false the zmqNode field shouldn't be there
if db: 'lowdb' we don't need the monodburl

https://github.com/iota-pay/iota-payment-module/commit/c57b5bd80a8929c0f6a48d2298837d659a46fcbd


tempo: 2.4.1 -> 2.4.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/grafana/tempo/releases.
meta.description for tempo is: A high volume, minimal dependency trace storage
meta.homepage for tempo is: https://grafana.com/oss/tempo/
Updates performed

Golang update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.4.2 with grep in /nix/store/bm35ffhalpzlssc56qfs2rxmzgd5ry7q-tempo-2.4.2
found 2.4.2 in filename of file in /nix/store/bm35ffhalpzlssc56qfs2rxmzgd5ry7q-tempo-2.4.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

tempo

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bm35ffhalpzlssc56qfs2rxmzgd5ry7q-tempo-2.4.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tempo https://github.com/r-ryantm/nixpkgs/archive/d35bfcd4a22dfc6ff8ce72fbb9d88ccb80df2cfe.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d35bfcd4a22dfc6ff8ce72fbb9d88ccb80df2cfe#tempo

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bm35ffhalpzlssc56qfs2rxmzgd5ry7q-tempo-2.4.2
ls -la /nix/store/bm35ffhalpzlssc56qfs2rxmzgd5ry7q-tempo-2.4.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

1 package built:

tempo

Maintainer pings
cc @WilliButz for testing.

Result of nixpkgs-review pr 312108 run on x86_64-linux 1

1 package built:

tempo


updating iCubBielefeld03 config files to last known working version

This is the iCubBielefeld config from 2016/03 when giving the demo with kostas, further updating for current yarprobotinterface needed

Not sure why this hasn't been merged yet.
@lschilli upon accepting the invitation you'll be able to merge it yourself.
Once done, please merge master into devel too.

Too old closing.


Make it possible to reuse a view

I think it would be nice to make it possible to reuse a specific view from different templates i.e  more details view.
Example:
On my case I have

Programmes template
current projects template
...etc
Models
Programmes
CurrentProjects

Each model has multiple items each with it own more-info-link and  they will  both be reusing the same moreinfo template
Am finding it repetitive to generate same view structure but with different model to be referenced in the templates above.
So my suggestion was, it would be nice if the next release{before the breaking change  :point_right: } #109  would make it possible to reuse a view something like this on templates on each loop
## programmes template
Read More

## currentProjects template
Read More

Through the following approache:

only changing model name and generating the corresponding the path templates

path:
  template: /{{ post.read_more_link }}/
  for-each:
    post: session.query(**SomeplaceholderModelName**).all()
template: moreDetails

add support for multiple paths on the same view

path:
  template: /{{ post.read_more_link }}/
  for-each:
    post: session.query(Programmes).all()
path:
  template: /{{ post.read_more_link }}/
  for-each:
    post: session.query(CurrentProjects).all()
template: moreDetails

make it possible for session.query(Model1, Model2, Model2, ..etc) to query multiple Models and return the as list which can be later be used to make multiple template paths
and any other better way :smiley:

@thanethomson

If I were in your situation, I'd:

Generate one full HTML file that contains the summary of the model from one Statik view
Generate a partial HTML file that just contains the details of the model using another Statik view
On clicking the "More Details" link/button, fetch the more detailed model via an AJAX request and replace the summary with the details.

Multiple paths on a single view totally breaks Statik's entire data model.

okay thank you

closing the issue now, I decided to go the old school, have more details view for each different category


[FR] - bulk update/edit auth users

Is your feature request related to a problem? Please describe.
It is not currently possible to bulk update a large amount of users customClaims in a single request, using a js map makes lots of requests and reaches rate limits very quickly. e.g
users.map(user => firebaseAdmin.auth().setCustomUserClaims(user.uid, user.claims));
Removing users then re-importing with bulkImport would logout all current users from web/mobile apps, it would also require users to set new passwords again so this isn't an option.
Describe the solution you'd like
add bulkUpdate or bulkEdit command that matches users by uid or email and updates matching records
Describe alternatives you've considered
putting updates onto a queue and processing them individually within the firebase customClaims rate limits
Additional context
even the ability to run small bulk updates such as 10 or 100 would be better than processing individually
example use case:
B2B with several "clients" all in one firebase account. A client gets an upgrade and all the users gain a new feature, a new attribute needs adding to each users custom claims

This is currently handled by the code here which calls https://cloud.google.com/identity-platform/docs/reference/rest/v1/accounts/update#request-body and sets custom attributes.
The backend API provides batchCreate, batchGet and batchDelete - https://cloud.google.com/identity-platform/docs/reference/rest#rest-resource:-v1.projects.accounts, but no batchUpdate.

following...

I'm guessing the limits are those described here: https://firebase.google.com/docs/auth/limits#api_limits
Operations per service account | 500 requests/second
Which IMO is a relatively small amount.
What happens if you want to edit every single user to have a new field set on them?
How would Google approach this use-case?
Even 10,000 users would probably be around a minute to update, as you wouldn't want to consume right up to the request limit as your application users would then be affected by the rate limiting.

Hi Ganey, The backend API currently does not support this feature and that is required before we can add the feature to Admin SDK. I have opened an internal issue for the same and will share updates here. Thanks.

I also need this bulk update feature. Is there any updates since Jun?

Thanks for the reminder. We are still waiting for backend support. I have pinged for an update on the internal tracking bug - b/234611522

Hey @prameshj  just wondering if there are any updates on this? Thanks


fix for asymmetric padding

Description
Fixes asymmetric padding issue in onnx-mxnet translators. MXNet conv operator supports only symmetric padding, whereas the conv operator in ONNX can have asymmetric padding. We are fixing this discrepancy by sequencing MXNet's 'Pad' operator and MXNet's 'Convolution' operator. Because the 'Pad' operator in MXNet supports asymmetric padding.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage: The 'Pad' operator has tests for both symmetric and asymmetric padding.
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Comments

@spidyDev @anirudh2290 @zheng-da

Is there a unit test to cover this?

The CI failed in one of the flaky tests while trying to fetch test files -
ProtocolError: ("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))
Will rerun the CI.

@marcoabreu I see that tutorials test have been added to the CI. How can I find the timeout set for the tutorials job ?

@marcoabreu the last two CI runs failed on the following tests -

test_tutorials.test_onnx_inference_on_onnx_model (tutorial tests Python 3 GPU)
test_tutorials.test_onnx_fine_tuning_gluon (tutorial tests Python 2 GPU)

both due to "Connection reset". What is the timeout set for these tests? Could you please take a look.

Okay it seems to be set in test_tutorials to 7 mins: https://github.com/apache/incubator-mxnet/blob/master/tests/tutorials/test_tutorials.py#L49

@piiswrong @eric-haibin-lin is this good to merge ?


Initial version of the VM helpers, extracted from the test script.

We'll need to update them with the commands to copy files to other clusters - right now
I only have gcloud. Also need more polish - and some instructions or helper to download all
needed artifacts.
NONE

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
11fa5ab7c59d9854a95b9f32f549505382e7b683
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
11fa5ab7c59d9854a95b9f32f549505382e7b683
link
/test e2e-suite-rbac-auth

prow/new-e2e-rbac_no_auth.sh
6db44aa129e1500212f37cf23c593aaad5175166
link
/test new-e2e-rbac_no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-auth.sh
11fa5ab7c59d9854a95b9f32f549505382e7b683
link
/test e2e-suite-rbac-auth

prow/new-e2e-rbac_no_auth.sh
6db44aa129e1500212f37cf23c593aaad5175166
link
/test new-e2e-rbac_no_auth

prow/e2e-suite-rbac-no_auth.sh
6db44aa129e1500212f37cf23c593aaad5175166
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/new-e2e-rbac_no_auth.sh
6db44aa129e1500212f37cf23c593aaad5175166
link
/test new-e2e-rbac_no_auth

prow/e2e-suite-rbac-no_auth.sh
6db44aa129e1500212f37cf23c593aaad5175166
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
6db44aa129e1500212f37cf23c593aaad5175166
link
/test e2e-suite-rbac-auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test

/retest

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-suite-rbac-no_auth.sh
6db44aa129e1500212f37cf23c593aaad5175166
link
/test e2e-suite-rbac-no_auth

prow/e2e-suite-rbac-auth.sh
6db44aa129e1500212f37cf23c593aaad5175166
link
/test e2e-suite-rbac-auth

prow/new-e2e-rbac_no_auth.sh
21ba9cd09c01fde11a460c5227e880b1340bce62
link
/test new-e2e-rbac_no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/new-e2e-rbac_no_auth.sh
758d4a61c476c550ef2e7bffa3448f76249527c0
link
/test new-e2e-rbac_no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

please put release notes also

/lgtm

/lgtm

@costinm: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/new-e2e-rbac_no_auth.sh
758d4a61c476c550ef2e7bffa3448f76249527c0
link
/test new-e2e-rbac_no_auth

prow/e2e-suite-rbac-no_auth.sh
59cd27cfca9341298e491597d77800acfc4d8f26
link
/test e2e-suite-rbac-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


VMware fusion vagrant box example

Could docs (readme) have an example of this?

@matti have you tried to guess how it should work with vmware? Do you have a working vmware setup you want to automate with this plugin?

No. I'm too lazy to invest time in this and then figure out that it just doesn't work :)

(and yes, I have a project where I would like to publish vmware boxes to vagrant automatically)

Well, I don't want to commit into something you are not willing to commit. Draw.

:beer: deserved

:) Poke if you change your mind. We can do it together :)

Is this plugin generic enough it would work with VMware and just needs documented or it needs some handling to output the right kind of box for the normal post processors to handle?

Well, we need somebody to figure out what to do and I can automate it here.
I don't know how much you need to do in case of VMware. This plugin is veeeery simple.


“Card At Random” (button) is broken in at least one way, maybe two

Steps to reproduce the issue:

From the ‘portal’ landing page, visit the ‘card at random’ link. That should take you to the tarot_key template. All the data you see is entered using the generators app.
Next, when you click on the red “Card At Random” button, Django should be serving another tarot card from the generators app, but instead the web browser draws a 404 saying ‘page not found’.

I am expecting Django to serve one of the other generator entries such as: http://<IP_ADDRESS>:8000/tarot_key/1# or http://<IP_ADDRESS>:8000/tarot_key/12# however instead the web address bar indicates: http://<IP_ADDRESS>:8000/tarot_key/%7B%%20url%20'tarot_key_with_number'%20generator_number=next_card_number%20%'%7D which is completely broken.
There was a similar 404 error discussed in Issue #75 and PR #78. It might be related. I believe there were discussions in other Issues and PR's but I can't locate them right now.

Resolved in #97


How to set proxy in tusk

Is there any option to set proxy server in Tusk with user name and password??

I did not thing u can do it 🤔


ci(travis): add missing platforms

The Travis configuration is currently missing some platforms because there are issues:
https://github.com/apache/cordova-plugin-file/issues/326
https://github.com/apache/cordova-plugin-file/issues/327
When those are fixed, this can be merged to improve the coverage of the CI.

superceded by GH Actions.


fix: fix Appium dependency

Coverage remained the same at 88.566% when pulling ab3c37253aa8f4dd1d4671a31ae084996390f2c7 on fix/appium into 1863c5c25daaa7d43c5f6780a952adbe7cb47b2d on master.


Update glide.lock file

We need to update the glide.lock file to reflect the recent changes to glide.yaml.
Partially fixes #100

TEST INSTRUCTIONS

add -v option to end of @glide install in the vendor target of the Makefile
comment out the rm -rf of docker vendor directory from the install target

Then do the following:

remove the vendor directory: rm -rf vendor
clear out your glide cache: glide cache-clear
recreate the vendor directory: make vendor
rebuild broker: make install
PROFIT: :heavy_dollar_sign: :heavy_dollar_sign: :heavy_dollar_sign:

@jmrodri Did this work for you? I added in the stuff you mentioned in your test comment.
TBH I really think we should just remove glide.lock all together... Maybe in a follow up patch.

The glide.lock is there for a reason. The purpose is to lock down the actual deps. On rails and javascript files, we would check in the lock files. So I would vote no to NOT checking in the glide.lock file.

Ya but glide.yaml creates glide.lock based on the version that set in there for each pkg. I remember reading somewhere that we're not suppose to touch it. I'll check into it.

PROFIT: :heavy_dollar_sign: :heavy_dollar_sign: :heavy_dollar_sign:
The test past. I'll see why travis is having issues.

Fixed travis. Our travis script was doing a normal glide install outside the Makefile. So that was creating the vendor directory WITH the vendor subdirs. So when our new Makefile never ran the glide install -v. Now that this is fixed. I'll verify this PR tomorrow morning, don't want to commit it tonight.


RequestReport with csv as the output

Has anyone looked into requesting reports and specifying the response format as csv?
It seems it's not really supported (https://docs.developer.amazonservices.com/en_UK/reports/Reports_RequestReport.html) although it is supported in the seller central UI:

The reports are provided as per amazon?
http://docs.developer.amazonservices.com/en_US/reports/Reports_GetReport.html
Amazon state they come out as per the report type
They also show the reports available her:
http://docs.developer.amazonservices.com/en_US/reports/Reports_ReportType.html
and the format of the report

You can convert most reports by using pandas into CSV from tab delimited file.


XCM extensions

We should have optional XCM extensions for features that useful for some chain but not every chain will implement it
Required for #11, #12, #14
Also may need feature discovery to detect available features on destination chain. But it could just be a registry somewhere offchain.

What should be the strategy of including new XCM extensions?
I see few options:

Add new message type for each XCM extension
pub enum Xcm {
	// existing types
	Staking(StakingMessage),
	Governance(GovernanceMessage),
	Storage(StorageMessage),
}

Add just one message type for all extensions
pub enum Xcm {
	// existing types
	Extension(XcmExtensionMessage),
}

enum XcmExtensionMessage {
  Staking(StakingMessage),
	Governance(GovernanceMessage),
	Storage(StorageMessage),
}

Or something very generic
pub enum Xcm {
	// existing types
	Extension { extension_id: Vec<u8>, extension_payload: Vec<u8> },
}

Had a chat with Gav, will just use the first approach.


traj_conv gradcheck fail

Successfully complie traj_conv but running mmaction/ops/trajectory_conv_package/gradcheck.py failed.
Traceback (most recent call last):
  File "gradcheck.py", line 27, in <module>
    test = gradcheck(conv_offset3d, (input, offset), eps=1e-5, atol=1e-1, rtol=1e-5)
  File "xxx/python3.6/site-packages/torch/autograd/gradcheck.py", line 214, in gradcheck
    'numerical:%s\nanalytical:%s\n' % (i, j, n, a))
  File "xxx/python3.6/site-packages/torch/autograd/gradcheck.py", line 194, in fail_test
    raise RuntimeError(msg)
RuntimeError: Jacobian mismatch for output 0 with respect to input 1,
numerical:tensor([[0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.],
        ...,
        [0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.]], dtype=torch.float64)
analytical:tensor([[0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.],
        ...,
        [0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.],
        [0., 0., 0.,  ..., 0., 0., 0.]], dtype=torch.float64)

Hi @TotallyFine ,
Thanks for raising this issue.
The trajectory convolution operator was originally written in Caffe and this is an adapted version from the updated DCNv2.
In our experiment, the results seems to be okay (I will shortly upload the TrajectoryNet's config part).
I still need some time to check this issue in details. You may refer to the DCNv2 repo for some exploration as well. Let's keep this issue open.

Hi, do you have any updates on this ? Do you have an example configuration to use TrajConv ?
Thanks!


Understanding dropouts

I'm trying to understand how dropouts are implemented within Keras.
When are units to block in the dropouts layer set? Can they be set to specific configurations? Are they reset everytime I call train_on_batch?, or is there a way to get the same dropout configuration to persist over multiple calls, or is a different one created each time?
Thanks

I'm curious too, a pointer to which parts of the code to look at to understand the dropout implementation would be really helpful.

I think this piece of code is instructive - https://github.com/fchollet/keras/blob/master/keras/layers/recurrent.py
The swapping of tensors between training and test is happening in the backend here:
https://github.com/fchollet/keras/blob/master/keras/backend/theano_backend.py
I guess one thing I don't quite get is that they are are scaling up the masked output during the forward pass instead of scaling down the vector in the backprop - I am not 100% sure if the two are completely equivalent.


TS compile error in sample component

I'm submitting a ...  (check one with "x")
[X] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior

On a clean clone of the project, during the app startup (executing 'npm run start.deving'), the following Typescript compilation errors are displayed in the console:
/Users/pavlovich/projects/udc/registry/src/client/app/modules/sample/effects/sample.effect.ts(20,41): error TS2684: The 'this' context of type 'Actions' is not assignable to method's 'this' of type 'Observable'.
Types of property 'lift' are incompatible.
Type '(operator: Operator<any, Action>) => Observable' is not assignable to type '(operator: Operator<any, R>) => Observable'.
Types of parameters 'operator' and 'operator' are incompatible.
Type 'Operator<any, R>' is not assignable to type 'Operator<any, Action>'.
Type 'R' is not assignable to type 'Action'.
/Users/pavlovich/projects/udc/registry/src/client/app/modules/sample/effects/sample.effect.ts(31,40): error TS2684: The 'this' context of type 'Actions' is not assignable to method's 'this' of type 'Observable'.
Expected behavior

The errors reported above would not be present in the console.
Minimal reproduction of the problem with instructions

Clone a fresh copy of the repo.
npm install
npm run start.deving
Observe the errors in the console.

What is the motivation / use case for changing the behavior?

Provide a clean sample app to be used as a reference for further development
Please tell us about your environment:

Mac OSX Sierra
Node 6.11.0
NPM 3.10.10

Angular Seed Version: aaaaf75

[486dc0c]

Node: node --version =
6.11.0

See #450


New version: Google.GoogleUpdater version 126.0.6462.2

Created by 🥟 Dumplings in workflow run #5300.
Logs
Updated: 126.0.6462.0 → 126.0.6462.2
Submitting WinGet manifests

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Program Files\Google\GoogleUpdater\126.0.6462.2\updater.exe returned exit code: 9
Executable C:\Program Files\Google\Update\GoogleUpdate.exe returned exit code: 9
Executable C:\Users\Validator\AppData\Local\Google\GoogleUpdater\126.0.6462.2\updater.exe returned exit code: 9
Executable C:\Users\Validator\AppData\Local\Google\Update\GoogleUpdate.exe returned exit code: 9

(Automated response - build 881.)


#120 Adds custom Theming Functionality, and Dark Theme toggle Logic.

More precisely:

Adds a ThemeProvider at Dashboard

Imports custom Global theme objects from util/themes/GlobalThemes.js

Adds toggle theme state to Dashboard

Appends Toggle Button to Dashboard / AppBar to change theme state

Creates util/styles folder for MUI Component style overrides

Current Dark Theme can easily be edited by changing the NightTheme object properties at util/themes/GlobalThemes.js

Adding new Themes can be done by:

Adding a new Theme Object at util/themes/GlobalThemes.js
Importing it at the Dashboard Component
Convert it to MUI Theme Object with the createMuiTheme function
Pass it to the ThemeProvider

Hi @koskrit
PR Accepted!
Good job on Theme Implementation .

Thank you @shravan20 ,
It was fun working on your project.


chore: Don't double build DependaBot PRs

These are submitted by PR, so branches don't need to build

@xzyfer AppVeyor already de-duplicates these builds, but the downside of Actions is that I don't think they have a native way of doing that right now, unless you know

I haven't looked into actions at all. I know we had the same issue with Travis too if you pushed to an origin branch, instead of your fork.


Bind doesn't work

Hi, i'm trying to use cropping in my project but i'm getting some problems.
When loading croppie in a  with predefined URL, like: "test/test.png" it works fine and i can take the dataURL of the cropped image, to save in my database.
But when i try to put the dataURL of an image taken from an input file to crop, I can't load croppie to crop the image. I've tried to load in a modal and out of it, and both failed.
when i call $("#img").croppie("bind",{options}) it does nothing.
if someone can help me i'll be very thankful!
thanx..

Binding to dataUrl's should work just the same as a any other image source.  What happens when you try to do $('').appendTo('body').attr('src', dataUrl)?
If you can provide some code, it would give us a better idea of where your problem is originating.

When i do this, the  is appended to the body.. It works fine.
The problem is when i try crop.croppie('bind',{url: dataURL});
Here goes my code:

HTML

<input type="file" class="input_file" id="input_file1" name="input_file1" onchange="getDataURL(event,'foto1'); muda_texto('1');">

JavaScript

var crop = $('#modalCrop1');

    function initCrop()
    {
        crop.croppie({
            boundary: {
                width: 800,
                height: 800
            },
            viewport: {
                width: 500,
                height: 500,
                type: 'square'
            },
            customClass: ''
        });
    }

    function getDataURL(event, id_input)
    {
        var id_preview = "#preview_"+id_input;
        var input = event.target;
        var reader = new FileReader();

        reader.readAsDataURL(input.files[0]);
        reader.onload = function(){
            var dataURL = reader.result;
            document.getElementById(id_input).value = dataURL;
            $(id_preview).css({
                "padding-top": "2px",
                "padding-left": "2px",
                "width": "185px",
                "height": "126px",
                "border-radius": "10px"
            });
            $(id_preview).attr("src", dataURL);

            $("#modalCrop1").attr("src", dataURL);

            $(".modal").toggle();

            crop.croppie('bind',{url: dataURL});
        };
    }

    $(".basic-result").on("click", function(){
        crop.croppie('result', {
            type: 'canvas',
            size: 'viewport'
        }).then(function(resp){
            $("#preview_foto1").attr("src", resp);
            $("#foto1").attr("value", resp);
            alert(resp);
        });
    });

    $(document).ready(function(){
        initCrop();
    });

The image i want to crop should open in a modal.
I've been tried to do many things to fix this, like set the src of the image i want to crop $("#modalCrop1").attr("src", dataURL) after toggling the modal, or call bind crop.croppie('bind',dataURL); instead of crop.croppie('bind',{url: dataURL});, but nothing made this work.

Sorry for the long delay in response.  Your code seems like should work.  Were you ever able to get it working?
If not, what browser are you using?  Where's your #modalCrop1 element?  Does it work when you don't have it in a modal?  I would start eliminating things that you're doing differently than the upload demo in https://github.com/Foliotek/Croppie/blob/master/demo/demo.js and that should help you track down where your problem is coming from.

if #modalCrop1 is an img...it won't bind based on my experience. After changing it to a DIV, I was successful.

Good point @Ariestattoo .  I've contemplated making croppie allow an image in it's constructor, and then get the data from that image to create the croppie instance.
Just haven't gotten around to it yet.

Great plugin either way...thanks for the effort :)

#210
Closing this one


Examine box doesn't scale with large entity names

Description
yea
Reproduction
examine a thing with loooooong name
alternatively use a labeler on something to give it a long label
Screenshots

nevermind i am a retard and didnt chek if this issue was already posted, this is a duplicate of #15854 how do i remove this

Dupe + dont use slurs por favor


Check for duplicate run back to back

just record runID as oldRunID and check if current == old

396433e0172471d1f603459d84c5569fab5b5732 done


Cydia wont open after jailbreak

iPhone 6, 10.2. Using latest ipa commit. After jailbreaking Cydia opens then crashes instantly.

Tried, roughly 30 times now using both the old ipa and about 8 times using the new ipa.

did he fix this

I have no idea he provided no help to me at all, and just closed my issue.

he won't coz he is fake he just copies people work and rewrite a little bit of code to seem its like his just like he thinks you can modify a dmg file and delete setup.app and compress the dmg file back and restore the ipsw file and yer doesn't work like that you need keys and an exploit for custom firmware ipsw he is fake


Settings panel not extendable for colour scheme settings

The current implementation cannot be extended in a meaningful way in order to house the colour scheme settings as well. Therefore, it should be altered to a more flexible system.

Fully implemented as of now


Spark spill/shuffle mount point incorrect

It seems /mnt/batch is not the right place to be using for spark.local.dir, as this is on the root volume in the Docker contain, which means the data is written to /var/lib/docker/.. on the host machine, and that's mounted on /dev/sda1, which is only 30GB.
Changing to /mnt/batch/tasks/spark-local works well for me (it'll create a directory within tasks), as this is mounted on /dev/sdb1 on the host machine, which is much larger.
Further, setting this path with the spark.local.dir Spark conf parameter seems to generate a warning in the driver application logs. Apparently Spark recommends setting it with the SPARK_LOCAL_DIRS environment variable in spark-env.sh instead. I believe this is because that setting should really be under the control of the cluster manager, which won't be able to mess with the user's spark-defaults. It appears to work either way on aztk, but it'll clean up a warning.

Closing since I believe this is no longer and issue.


enable LatAM-VPN & more changes

This PR merges various fixes and changes from dev branch to main.

new VPN (LatAM - located in Sao Paolo) is enabled
pointer events are disabled for WorldMap on renewal page
for umbrel setups: resolvconf is being installed to ensure successful curl test
setupv2: apt is used instead of apt-get, fixes #40
bugfix: check for invoices on webhook
removal of expired invoices from memory
scirpts are adapted to latest RaspiBolt CLN guide (renaming cln -> lightningd), fixes #41
smaller changes

LGTM ⚡🌹


Contrast issues

Hi! Thanks for this extension. I noticed that in the search bar, when you select text, it is not readable anymore:

Text color should probably be white. I quickly looked into this and it seems that there is no such setting as selection.foreground?? So is there even any way to solve this? If not, I'd suggest setting selection.background to a light grey color instead the dark blue :-/
Another issue: The action buttons on the top right are in the wrong color:

There are actually multiple icons in the top row, but you can barely see them. (GitLens icons, mostly). I also looked into this: Currently, dev tools say
.hc-black .monaco-action-bar .action-item.menu-entry .action-label, .vs-dark .monaco-action-bar .action-item.menu-entry .action-label {
    background-image: var(--menu-entry-icon-dark);
}

If you change this to --meny-entry-icon-light, then it gets readable:

VSCode seems to apply these flags based on the fact that win-nt-theme is marked as a dark theme. Can this be changed to be a light theme? Would also make more sense imo.

The issue seems to be in package.json contributes.themes.uiTheme which needs to be "vs" instead of "vs-dark". https://github.com/microsoft/vscode/issues/140006, https://github.com/slack-theme/visual-studio-code/issues/9#issuecomment-501522227, https://code.visualstudio.com/api/references/contribution-points#theme-example.
Cannot find any documentation about this though...

Hey, thank you for looking at this. Do you want to send a PR to fix this issue?

Hey, thank you for looking at this. Do you want to send a PR to fix this issue?

sure! #4
don't know what to do about the selection color issue though

Let's fix the selection issue in a different issue.
Closed by #4


Add Linode driver

Adds support of Linode to machine - a popular IaaS platform.

In commands.go I imported the driver as "github.com/taoh/machine/drivers/linode", which is a consequence of forking the original repository. This would need to be changed to github.com/taoh/docker/drivers/linode once the pull request is accepted. Is there a better way to do this on a forked repository?

@taoh Yup, there's a better way, clone the repo into $GOPATH/src/github.com/docker/machine, then all the pkg paths will work.

@sthulb Thanks. Will do.

Close this pull request as I'm creating a new one following contribution guidelines.


Add support for --plasmids and --meta flye flags

flye supports two flags (--plasmids and --meta) that aren't directly exposed in dragonflye. Use dragonflye's --opts flag to optionally pass them through.

It appears that the --plasmids flag has been deprecated as of release 2.9:
https://github.com/fenderglass/Flye#flye-29-release-20-aug-2021

The --meta flag is advised if we 'expect highly non-uniform read coverage'. The author of flye cautions that "some graph procedures will be less aggressive, which can decrease the contiguity of a single genome assembly".
https://github.com/fenderglass/Flye/blob/4fc23c4f53c384468735ea2443ce8df465e02f63/docs/FAQ.md?plain=1#L33-L39


Image Verification Restructuring

Signed-off-by: Jim Bugwadia<EMAIL_ADDRESS>

How much of this has already been implemented as of 1.7.0?


Rc<> gets deserialized incorrectly

The way serde currently treats ref-counted data structures means that it creates copies of the references objects. This is bad for several reasons:

Potentially increased memory usage
Equality comparison that relies on comparison of address breaks
Interior mutability is not reflected in copies
and maybe more that I can't think of right away. I think there should at least be big warnings in the documentation about this behaviour, but the support should be either fixed or deprecated, imo.

IMO this is kind of a big deal. Any word on progress towards dealing with this?

I agree. I think serde either needs to drop Rc support or add an annotation that users can specify (or something so people are aware of this issue). It's pretty hard to come up with a general solution that doesn't have other issues. In any case, this is a big backwards compatibility hazard because this will require breaking changes to fix.

I am open to dropping Serialize and Deserialize impls for Rc in the next breaking release, and requiring explicit serialize_with and deserialize_with to opt into serializing them.

Whoa, I personally find Rc/Arc serialization scheme perfectly valid, probably we just have to stress this moment in the docs?
My application will suffer from removal of these implementations. I use serde for deserializing plain-old-data configs with Arc<String> and then clone that Arc throughout the application.
With this impl broken, I will have to either use the hypothetical opt-in mechanism (I don't know what it will be like), or deserialize plain String, then destructore config struct, move the string into Arc - the code is becoming more complex.
On the other hand, one can always write his own personal fancy deserializer if he wants interning.

@alexbool: the reverse argument is that you could use #[serde(deserialize_with="val_to_arc")]
Maybe we should provide a #[serde(deserialize_map="Arc::new")]

@oli-obk while this is clearly possible, I still think this is not worth breaking projects

@alexbool It's not a silent breaking change, so everyone will notice and it will be in a major version bump which will break projects most likely anyway.
The reverse is a silent source of bugs. The advantage of breaking it is that in the future we can re-add it when/f we figure out a way to serialize/deserialize the duplication.

@oli-obk what do you call "not silent"? Do we have a deprecation that is a compilation warning? At the moment I doubt so.

@alexbool The following will stop compiling, because you can only have fields that implement Serialize and Deserialize in a struct that derives these traits
#[derive(Deserialize, Serialize)]
struct Foo {
    a: i32,
    b: Arc<String>, //~ERROR Arc<String> does not implement Deserialize
}

@oli-obk In my understanding, this is simply a breaking change, a silent one. No one is expecting that until we can throw a compilation warning some time before the actual breakage will occur.
By the way, is it possible to add such a warning now?

By the way, is it possible to add such a warning now?

#[deprecate] doesn't work on impls to the best of my knowledge.

In my understanding, this is simply a breaking change, a silent one

a silent breaking change is a change that only occurs at runtime

No one is expecting that until we can throw a compilation warning some time before the actual breakage will occur.

When you do a major version bump, you should always expect breakage.

Can we throw a deprcation message during proc-macro expansion?

I think there's a disconnect what "silent" means. The current behaviour is a bug in my book, because it means a serialize/deserialize cycle breaks programs "silently" - it appears to work, but doesn't. A breaking change that breaks the compile is not silent, independent of whether a deprecation note happened earlier or not.  That seems normal and expected?

I'm -1 on removing the impls. Why would one assume that serialising and then deserialising a Rc<T> would share the T inside it?

None would assume that, but you might accidentally end up creating code that expects that it would. Generic structures which derive Serialize and Deserialize might get inialized with Rc.... Also, in the few cases you actually want cloning serialization, you can use serialize_with.

I put together a proof of concept of an efficient Rc<> DAG serialization/deserialization approach here in case anyone is interested in pursuing this further: see https://github.com/TyOverby/bincode/issues/139#issuecomment-287259643.

One idea I had for this was that we could add an API to Deserializer that provided a typemap-ish store. This would allow an impl for Rc<T> store a map from some unique id to the deduplicated pointer. This might also be useful for some zero-copy situations, where the creator of the deserializer could prepopulate the typemap with shared data that was used in the Deserialize impl.
This does have some smell to it though.

@erickt take a look at the implementation in https://github.com/TyOverby/bincode/issues/139#issuecomment-287259643 (the hashmap could be swapped out for a typemap). I think this should be a separate library on top of Serde. It does not need to be baked into the Deserializer API.

I am still torn on this. I understand the concern that implicitly duplicating Rc data may be unexpected and is not aligned with Rust's tendency to make expensive operations explicit. I also know there are use cases where serializing an Rc the current way is exactly what is desired and working around a missing impl would be obnoxious.
@shahn @dylanede or others, does anyone have an example of a library using Rc and Serde where serializing copies of an Rc would lead to undesirable behavior?
Perhaps putting Rc impls in Serde behind a cfg would be an acceptable middle ground?

@alexbool: the reverse argument is that you could use #[serde(deserialize_with="val_to_arc")]

What about Rc<T> in other types? Option<Rc<T>>? HashSet<Rc<T>>?

I don't have an example for a public crate, but this ticket exists because I was using serde to serialize the state of a toy compiler and deserializing broke it completely (I was using pointer equality to check for equality of two objects behind an Rc). Since Serde allowed me to just derive Serialize, I assumed it would work correctly.

I was using pointer equality to check for equality of two objects behind an Rc

This is not the default behaviour of PartialEq<Rc<T>> for Rc<T>, so allow me to argue that this breakage wasn't the serde impls' fault.

I don't think the point you're making is correct. I did not modify the way Rc checks equality at all (I could not do that in fact, because of coherence). Rc works for any T, completely independently of whether T's PartialEq impl is derived, missing, or custom-defined.

Thanks for the valuable feedback @shahn. Let me know whether you think #864 would have set more correct expectations around Serde's handling of Rc<T> and Arc<T>.

Yes definitely. Putting this behind a cfg transports the message that this might be what you want, but it might also break your assumptions. I think that's the right tradeoff. Plus it's a very easily fixed breaking change, which I hope won't be too hard for people to adapt to.

Cool. I am moving forward with the cfg and closing this issue but we have some time before this will be released, so I am open to continuing the discussion here if other people have strong opinions.

@dtolnay Question. Given how cargo deduplicates dependencies, couldn't one accidentally opt into this feature by having a dependency that, as its implementation detail, requests the rc feature from serde?

That is correct. This is just a way to improve the chance that people understand what they are doing.

hm, that would be sad if a popular dependency used that feature. Are there better alternative ideas?

Yeah it shipped so it's too late. I don't understand why you think it would be sad, the existence of this feature is what is sad. :)

As I see it, enabling the feature by default is not a breaking change, so the feature is the most sensible choice in the presence of uncertainty. If you want to make sure you don't accidentally end up with a derived impl containing an rc, open a clippy issue.


Issue with Carthage

Hi,
I just try install your component on a test project with Carthage
My Cartfile:
github "xmartlabs/Bender"

Carthage output:
$ carthage update --platform iOS
*** Cloning Bender
*** Checking out Bender at "0.1.0"
*** xcodebuild output can be found in /var/folders/rw/gbr9wvs91cz91mcpgdxv4q340000gn/T/carthage-xcodebuild.XMMgOU.log
*** Building scheme "Palladium" in Bender.xcworkspace
** BUILD FAILED **

The following build commands failed:
	CompileSwift normal armv7
	CompileSwiftSources normal armv7 com.apple.xcode.tools.swift.compiler
(2 failures)
/Volumes/Perso/Temp/BenderTest/Carthage/Checkouts/Bender/Sources/Adapters/Tensorflow/protos/attr_value.pb.swift:10:8: error: no such module 'SwiftProtobuf'
A shell task (/usr/bin/xcrun xcodebuild -workspace /Volumes/Perso/Temp/BenderTest/Carthage/Checkouts/Bender/Bender.xcworkspace -scheme Palladium -configuration Release -sdk iphoneos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) failed with exit code 65:
** BUILD FAILED **

The following build commands failed:
	CompileSwift normal armv7
	CompileSwiftSources normal armv7 com.apple.xcode.tools.swift.compiler
(2 failures)

When I open the project I just see one iOS target 'Palladium' (why Palladium and not MetalBender iOS 😦)
If it's can help here a tutorial to create a cross platform framework compatible with macOS, iOS, tvOS and watchOS and with a clean support of Carthage: Swift Cross Platform Framework
I hope this will help 😉

Hey if it helps you can try downloading swift protobuf from their repository directly and compiling the framework.
https://github.com/apple/swift-protobuf
There seemed to be some issues with carthage build.
Issue:
https://github.com/apple/swift-protobuf/issues/610

you must have one more xcode,  just keep only one, and try again later

Fixed by #66


REFLECTION_ROUGHNESS_BLUR error on UMD version

Hi there. I'm trying to adapt Billboard Reflection to run with Aframe and it's throwing this error when I try to apply the shader on the ground (reflective) mesh:
Uncaught TypeError: Cannot set properties of undefined (setting 'REFLECTION_ROUGHNESS_BLUR')
    at BillboardReflection.enableReflection (BillboardReflection.js:298:48)

Here's my code:
const geometry = new THREE.BoxGeometry( 0.2, 0.2, 0.2 );
const material = new THREE.MeshNormalMaterial();
const mesh = new THREE.Mesh( geometry, material );
scene.add( mesh );

const geometry2 = new THREE.PlaneGeometry( 2, 2, 2 );
const material2 = new THREE.MeshNormalMaterial();
const ground = new THREE.Mesh( geometry2, material2 );
ground.rotation.set(-1.5, 0, 0);
ground.position.set(0, -0.5, 0);
scene.add( ground );

const billboardReflection = new BillboardReflection();
billboardReflection.roughnessBlur = false;
let reflect = billboardReflection.create(mesh);
ground.material.onBeforeCompile = shader => billboardReflection.enableReflection(shader, { roughnessMapBlur: false })

Am I doing something wrong here?
Thanks!

having the same issues as well. but setting the materials used to MeshStandardMaterial solves the console error but i still cant the ground to reflect the cube.
did you manage to figure it out?

Yeah, same thing... Changed the material to MeshStandardMaterial solved the REFLECTION_ROUGHNESS_BLUR issue, but the reflection doesn't work at all.

The issue seems to be that shader.defines can be undefined during onBeforeCompile although I always expected it would be an object. So I try to assign REFLECTION_ROUGHNESS_BLUR to it which results in that error.
I've merged a PR that sets shader.defines to an empty object in case it is undefined so that we can always assign REFLECTION_ROUGHNESS_BLUR to it.
Let me know if that resolves your issue.

I did a test with the latest version with three 139. same issues whereby i cant get the reflection to work.
No more errors logged thogh if im not using MeshStandardMaterial
// MESH
const geometry = new THREE.BoxGeometry(0.2, 0.2, 0.2);
const material = new THREE.MeshStandardMaterial({});
const mesh = new THREE.Mesh(geometry, material);
scene.add(mesh);

const geometry2 = new THREE.PlaneGeometry(2, 2, 2);
const material2 = new THREE.MeshStandardMaterial({ metalness: 0.7, roughness: 0.1 });
const ground = new THREE.Mesh(geometry2, material2);
ground.rotation.set(-1.5, 0, 0);
ground.position.set(0, -0.3, 0);
scene.add(ground);

const billboardReflection = new BillboardReflection();
let reflect = billboardReflection.create(mesh);

ground.material.onBeforeCompile = (shader) => {

    billboardReflection.enableReflection(shader, {
        roughnessMapBlur: true,
        roughnessMapBlurIntensity: 0.85,
        roughnessMapBlur: true,
    });
};

Hey, can you confirm whether the issue was fixed in the latest commit? It addresses a few issues with planes that were created in three.js (and not imported from a GLB for example).

Unfortunately still no reflection for me with the same set up as above. on UMD version btw.


Slim AWS deployment size to fit on t2.micro

Overview
Reduce the size of docker containers django and nginx such that they can run on the free-tier AWS t2.micro size EC2 instance.
Rationale
This will allow ppl with free-tier accounts to easily try out the image without cost.
Implementation
Reduce memory footprint of Dockerrun.aws.json to fit the t1.micro memory limits.

Closed


Update battle.jl

Pass ifempty=false to walk!() calls so that agents can start to fight
Rename battle() to create_battlefield() to better match the purpose of the function. Also helps avoid confusion with the unrelated function battle!()

In response to https://github.com/JuliaDynamics/AgentsExampleZoo.jl/issues/23

thanks. i assume you've run the example and the video works fine?

https://github.com/user-attachments/assets/03dc77fe-d749-466a-a70d-64f15a842321
Here's the video that it generates for me. Technically the video starts after 5 steps have already passed in the model.


Added Web Design Playground and Books category

Hi,
I thought this book might be a good resource to your list and I added 'Books' category to it.
Thanks for taking it into consideration!
Branko

This repo is a collection of lit-html resources, not general list of resources for learning HTML and CSS. Therefore I'm closing this PR as it does not seem to be relevant.


Revert "chore: roll Playwright to 1.22.0-alpha-may-10-2022"

Reverts microsoft/playwright-dotnet#2136

Duplicate of #

Duplicate of #

#1905


Error in mp4sample example

Hi there,
I think the mp4sample is a little out-of-date.
The expected input as printed is ./mp4sample <track_id> <filename>. In reality, the example only uses the filename, and expects it at args[1], not args[2].
-        println!("Usage: mp4sample <track_id> <filename>");
+        println!("Usage: mp4sample <filename>");

Really useful crate, thanks!

Good catch @miluxmilux! I've updated the example to just println!("Usage: mp4sample <filename>");.
Thank you!


[BUG / Feature] group-hover:scale- is not supported yet.

Thank you for great plugin!
Describe the bug
In my react source like this;

plugin will show the message warning  Classname 'group-hover:scale-x-10' is not a Tailwind CSS class!  tailwindcss/no-custom-classname
To Reproduce
Steps to reproduce the behavior:

Type group-hover:scale-x-10 in your code.
Run lint
You will get the message.

Expected behavior
No warning would happen.
Environment (please complete the following information):

OS: macOS
Softwares + version used:

VSCode: 1.63.2
eslint-plugin-tailwindcss: 3.0.0
tailwindcss: 3.0.7

Hi @piaro,
it looks like the error is coming from the fact that your own tailwind config is not loaded by the plugin.
By default the TailwindCSS config offers the following values for scale:
    scale: {
      0: '0',
      50: '.5',
      75: '.75',
      90: '.9',
      95: '.95',
      100: '1',
      105: '1.05',
      110: '1.1',
      125: '1.25',
      150: '1.5',
    },

And there no color named primary by default.
Try the following code

and it will work, so I believe the issue you are experiencing is due to a custom config not loaded...


Can't connect to RPC node to complete AMM tasks

I've tried everything I can think of to complete the AMM tasks. I tried with the public RPC node and a private one shared by a community member.
With public RPC -
ag-solo_1  | 2021-08-27T15:12:03.384Z SwingSet: vat: v11: waiting for wallet to initialize
ag-solo_1  | 2021-08-27T15:12:03.484Z outbound: invoking deliverator; 2 new messages for 80280a37099594d8be7323f30a7c757535bd014c9f5198303b3f866d6656e41a
ag-solo_1  | 2021-08-27T15:12:04.121Z chain-cosmos-sdk: gas estimate: 48392
ag-solo_1  | 2021-08-27T15:12:04.122Z chain-cosmos-sdk: delivering to chain (trips=5) 80280a37099594d8be7323f30a7c757535bd014c9f5198303b3f866d6656e41a [
ag-solo_1  |   [ 14, '14:12:deliver:ro+336035:getCurrentAmount:rp-51;[]' ],
ag-solo_1  |   [ 15, '15:12:deliver:ro+336028:getMyAddress:rp-52;[]' ],
ag-solo_1  |   [
ag-solo_1  |     16,
ag-solo_1  |     '16:12:deliver:ro+336028:update:rp-53:ro-22;["depositFacet",{"@qclass":"slot","iface":"Alleged: contact","index":0}]'
ag-solo_1  |   ]
ag-solo_1  | ] 12
ag-solo_1  | 2021-08-27T15:12:05.116Z chain-cosmos-sdk: gas estimate: 48612
ag-solo_1  | 2021-08-27T15:12:36.993Z outbound: invoking deliverator; 6 new messages for 80280a37099594d8be7323f30a7c757535bd014c9f5198303b3f866d6656e41a
ag-solo_1  | 2021-08-27T15:12:37.495Z chain-cosmos-sdk: delivering to chain (trips=6) 80280a37099594d8be7323f30a7c757535bd014c9f5198303b3f866d6656e41a [
ag-solo_1  |   [
ag-solo_1  |     17,
ag-solo_1  |     '17:17:deliver:ro+336022:getId:rp-54:ro+336034;[{"@qclass":"slot","iface":"Alleged: Zoe Invitation brand","index":0}]'
ag-solo_1  |   ],
ag-solo_1  |   [
ag-solo_1  |     18,
ag-solo_1  |     '18:17:deliver:ro+336022:has:rp-55:ro-22;[{"@qclass":"slot","iface":"Alleged: contact","index":0}]'
ag-solo_1  |   ],
ag-solo_1  |   [ 19, '19:17:deliver:ro+336032:getInvitationIssuer:rp-56;[]' ],
ag-solo_1  |   [ 20, '20:17:deliver:rp-56:getBrand:rp-57;[]' ],
ag-solo_1  |   [
ag-solo_1  |     21,
ag-solo_1  |     '21:17:deliver:rp-57:isMyIssuer:rp-58:rp-56;[{"@qclass":"slot","index":0}]'
ag-solo_1  |   ],
ag-solo_1  |   [ 22, '22:17:deliver:rp-57:getDisplayInfo:rp-59;[]' ]
ag-solo_1  | ] 17
ag-solo_1  | 2021-08-27T15:12:50.477Z chain-cosmos-sdk: Error: post failed: Post "http://<IP_ADDRESS>:26657": EOF

And private RPC -
ag-solo_1  | 2021-08-27T16:42:17.548Z chain-cosmos-sdk: delivering to chain (trips=2) 80280a37099594d8be7323f30a7c757535bd014c9f5198303b3f866d6656e41a [] 158
ag-solo_1  | 2021-08-27T16:42:18.597Z chain-cosmos-sdk: gas estimate: 48323
ag-solo_1  | 2021-08-27T16:42:18.598Z chain-cosmos-sdk: delivering to chain (trips=3) 80280a37099594d8be7323f30a7c757535bd014c9f5198303b3f866d6656e41a [] 158
ag-solo_1  | Open CapTP connection to ws://<IP_ADDRESS>:8000/private/captp...2021-08-27T16:42:18.856Z web: <IP_ADDRESS>:46586[1]: new WebSocket /private/captp?accessToken=Pjo-_E8MHpVLbjTvYnS6KwL6Qt2gWoAeqe4bn2xc26th4QsFC7pinsMRRSen04-O
ag-solo_1  | oagoric: deploy: Don't need our provides: wallet
ag-solo_1  | 2021-08-27T16:42:18.973Z web: <IP_ADDRESS>:46586[1]: client closed
ag-solo_1  | 2021-08-27T16:42:19.435Z chain-cosmos-sdk: Resynchronizing 80280a37099594d8be7323f30a7c757535bd014c9f5198303b3f866d6656e41a sequence number from 1 to 42
ag-solo_1  | 2021-08-27T16:42:20.489Z chain-cosmos-sdk: gas estimate: 48323
ag-solo_1  | 2021-08-27T17:18:17.138Z web: GET /console/login/LoginForm.jsp 404 166 - 5.519 ms
ag-solo_1  | 2021-08-27T18:20:20.715Z web: GET http://example.com/ 200 4328 - 27.007 ms
ag-solo_1  | 2021-08-27T23:24:35.677Z web: GET / 200 4328 - 11.977 ms
ag-solo_1  | 2021-08-27T23:24:36.611Z web: GET /favicon.ico 404 150 - 6.844 ms
ag-solo_1  | 2021-08-27T23:53:57.351Z web: GET / 200 4328 - 3.884 ms
ag-solo_1  | 2021-08-28T00:02:36.383Z chain-cosmos-sdk: Error: post failed: Post "http://[PRIVATE_RPC_IP]:26657": EOF

I believe both AMM tasks would have been completed successfully if it wasn't for these issues.

Thanks for the report; this post failed problem looks like a duplicate of #30 .


Bug Fixed, Tests written

The Category page now shows, and the user can create new categories or edit old ones.
RSpec unit test written in the controller to test that page is being rendered properly.
Cucumber tests written for user path of creating new category or editing existing category.

You should not include the files in the DB folder. These should be deleted and added to gitignore

@kariabancroft but leave the folders and the seeds, yes?

Great! Ready to go and close. Thanks!


Feature/game/eventloop

Rethinking https://github.com/KajiTetsushi/Pong/pull/2.
For learning purposes, I've decided to keep the implementation of the encapsulated SDL moving parts to a bare minimum where the details can all be seen in one file only. The splitting up of features in the previous attempt had good intentions for perceived maintainability reasons, but it turned out to be an overengineered piece of work for such an undemanding program. This version exposes each SDL moving part a little more so that the reasons behind each piece is simpler to understand, at least until I discover that there needs to be more details. Like, a lot more details.

Hindsight: Let's not call this app_game until we've figured things out.


docs: add stability index

Closes #3076
Some open questions:

Should we document a more strict process around updating stabilities? The plan in the core team is to target different parts of the project and then update the stability when we feel we're ready to commit to higher stability. Wondering if it's useful with a bit of transparency or if that's not generally interesting to most people reading this doc.
How do we handle plugins not owned by the core team, should they be included at all, perhaps opt-in from authors? Right now we've grabbed descriptions from the plugin marketplace and set stability to 0.
Similar to the first point, should we document a process for plugin authors to update the stability? It'd really just be a PR to this doc.

I think it's fine for now, but:

Right now we've grabbed descriptions from the plugin marketplace and set stability to 0

Maybe the stability index could be part of the machine readable plugin description and could be used to generate this page. However that wouldn't solve the problem for all the internal stuff.

I think only APIs that are considered part of the platform should be included in the index. As such, any plugin that is not part of the core feature set (catalog, templates, ...) can be excluded. I think this should be the case even if they are part example app.
What do you think about calculating the current average stability index so that it can be tracked over time?
Since API stability is the top priority right now I think a blog post about the stability index is in order.

Removed a bunch of plugins from the list and just kept the core ones and some additional ones owned by Spotify teams. Encouraged PRs for plugin owners that want to add them to the list tho

Can we merge this now we've shipped the latest version?


Retiring SpitQueryPart, using the proto3 version now.

Note the hadoop java code is broken, as it uses the old
java client and not the new one (and the bson structure changed).
The right fix is probably to switch to new client there.
@enisoc
Not ready to review / push yet.

@enisoc @yaoshengzhe OK ready to go now, thanks Shengzhe for the help / fix! :)

LGTM

LGTM


Morning session peer to peer review

Appraisals

Good use of JavaScript ES6 classes.
Check for the live link in the ReadMe file, it may be broken.

Happy Coding 🥂

Thank you @betses, @techEmprez and @Elijahdre for your feedback, I have updated the changes as requested and made the fixes we discussed Link here


bug in tangents_lines_from_circle

Great library!
discovered minor bug in tangents_lines_from_circle.
instead of d2 = d.norm() should be d2 = d.norm2()

Yes, it's a major bug indeed, pull request has been created.

thanks guys!


[RayService] Add RayService alb ingress CR

Why are these changes needed?
three updates comparing with this

Update the service name to rayservice-sample-serve-svc
Update the port to 8000.
Health check.

With these two changes, customer will have workable CR out of the box for Ray Service.
Tested with eks.

I will put more details into the ray doc.
Related issue number

Checks

[ ] I've made sure the tests are passing.
Testing Strategy

[ ] Unit tests
[ ] Manual tests
[ ] This PR is not tested :(

The change has no relationship with CI. Merge it.


Updating License for the component

Type: Missing
Summary:
Updating License for the component
Details:
The license for this component is shared at https://github.com/microsoft/fluentui/blob/master/LICENSE
Resolution:
This PR resolves issues related to License missing information.
Affected definitions:

react-icons-mdl2-branded 1.1.16

This is same as this PR:- https://github.com/clearlydefined/curated-data/pull/15245

@vineetsetia The package.json states:
"license": "SEE LICENSE IN LICENSE",

The license file in the package contents states:
@fluentui/react-icons-mdl2-branded

Copyright (c) Microsoft Corporation

All rights reserved.

Microsoft Fabric Assets License

Usage of the branded icons in this package is subject to the terms listed at https://aka.ms/fluentui-assets-license

This is a EULA, not MIT. The EULA is also listed in the README. EULAs are curated as OTHER. Do you agree that this should be OTHER? This will also be the same for #15245.

I see similar components like @fluentui/react-icons-mdl2 are marked as MIT. Should those other components be changed to EULA/Other too?
https://www.npmjs.com/package/@fluentui/react-icons-mdl2

No, @fluentui/react-icons-mdl2 does not need to changed since it licensed as MIT. It looks like some fluentui packages are licensed differently due to included icons.
This package contains branded icons from the MDL2 SVG icon set. Usage of these icons is subject to the Microsoft Fabric Assets License.

Ok. It sounds good. We can mark it as "Other"


cm/dashboard merge main

This is PR #352 with main merged in and dev-check (formatting) run.

Make changes as mentioned here: https://github.com/NEU-DSG/dailp-encoding/pull/358#discussion_r1408431394


create form based on formdata

i saved formData as json formate. i want to create form based on formdata json saved data. if click button load json and create form showing selected field

Demo source code has a line
const formeo = new window.Formeo(formeoOpts);
You can pass a second parameter to window.Formeo() which is saved form data.
eg: const formeo = new window.Formeo(formeoOpts, packageJsonFromDB);

thank you very much man

look at this example -> But since I have 2 forms on the same page, when I load data in this way, both forms have the same data.
https://codepen.io/dibwas/pen/yQyaKZ?editors=1111

@thonycc10 this is a bug that will be address in the near future. Closing issue since original question was answered


NavigationView hardcodes 8px bottom margin

Describe the bug
In our application we want to be able to hide the navigation view. To do so, we have defined our application layout as follow:
<Grid Background="Blue">
    <Grid.RowDefinitions>
        <RowDefinition Height="Auto" />
        <RowDefinition Height="*" />
    </Grid.RowDefinitions>
    <mux:NavigationView
        Background="Red"
        IsBackEnabled="True"
        PaneDisplayMode="Top">
        <mux:NavigationView.MenuItems>
            <mux:NavigationViewItem Content="Item A" />
            <mux:NavigationViewItem Content="Item B" />
        </mux:NavigationView.MenuItems>
        <mux:NavigationView.PaneFooter>
            <mux:NavigationViewItem Icon="People" />
        </mux:NavigationView.PaneFooter>
    </mux:NavigationView>
    <Frame Grid.Row="1" Background="Green" />
</Grid>

We are only using the top navigation bar of the NavigationView. The content of the application will go in a separate row of our main grid.
The NavigationView is displaying an unexpected empty line of 8px under the navigation menu items.
Steps to reproduce the bug
Steps to reproduce the behavior:

Create new application and copy the code snippet from above
Run the application
Notice the red line under the blue NavigationView and the green content Frame

Expected behavior
I shouldn't see any red line between the navigation bar and the content.
Version Info
NuGet package version:
Microsoft.UI.Xaml 2.1.190606001
Microsoft.UI.Xaml 2.2.190611001-prerelease

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

May 2019 Update (18362)
Yes

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Anniversary Update (14393)

Device form factor
Saw the problem?

Desktop
Yes

Mobile

Xbox

Surface Hub

IoT

Additional context
I've been able to workaround this issue by retemplating the control and removing the 8px bottom margin from PaneToggleButtonGrid. This is working in my case (PaneDisplayMode="Top") but might not be generic enough to address all the cases.

Thanks for reporting this @vgromfeld! Is this margin only present when you have no content? If there was Content that filled the window, would the 8px be present at the bottom instead or is it still at the top?

I initially thought that this issue might be related to #47, but on closer inspection looks like different margins are involved.

We are only using the top navigation bar of the NavigationView. The content of the application will go in a separate row of our main grid.

We didn't really design NavigationView to be used in this way and I'm actually very curious why you've chosen not to utilize NavigationView's content area.

I've been able to workaround this issue by retemplating the control and removing the 8px bottom margin from PaneToggleButtonGrid. This is working in my case (PaneDisplayMode="Top") but might not be generic enough to address all the cases.

PaneToggleButtonGrid holds the hamburger button. I believe that in a majority of use cases the Grid's 8px bottom margin is desirable and forces a separation between the hamburger button and everything bellow it. So I don't think it makes sense to remove this margin.
To avoid forcing apps to retemplate, we can expose the margin as a resource, something like PaneToggleButtonContainerMargin, instead of hardcoding  the Grid's Margin="0,0,0,8" into the template.

Maybe the Pane part of the control could become a primitive so this scenario could be better supported in the future, but yea, its a bit odd that they chose not to put the stuff in the Content area.

@jevansaks, the margin is always there whether there is content or not. I've built a quick sample app to set the content inside (left pane) and outside (right pane) of NavigationView:

As you can see the margin is still there when the content is inside NavigationView but, it is not visible. It is "drawn" behind the content.
@YuliKl, we choose to not use the NavigationView content because we want to be able to fully hide all the navigation elements when entering in some UI state. We are basically keeping only our content in the window.
Adding a PaneToggleButtonContainerMargin resource can help to avoid the retemplating but in the mean time, can't you just set the margin directly on the hamburger button (since it seems needed only for this one) and avoid the need for custom resource ?

Adding a PaneToggleButtonContainerMargin resource can help to avoid the retemplating but in the mean time, can't you just set the margin directly on the hamburger button (since it seems needed only for this one) and avoid the need for custom resource ?

Can you tell me what you mean? The margin is here: https://github.com/microsoft/microsoft-ui-xaml/blob/82edd199316795fc4fdd83565f9e323fa5383474/dev/NavigationView/NavigationView.xaml#L150
Oh I think I see you're saying put the margin on the TogglePaneButton only so that the margin only comes in for left nav mode or when the hamburger button is visible?

Oh I think I see you're saying put the margin on the TogglePaneButton only so that the margin only comes in for left nav mode or when the hamburger button is visible?
Yes, doing that will avoid exposing too much of the internal layout

The PaneToggleButtonGrid holds the back and hamburger buttons. These buttons are sometimes side-by-side, sometimes stack one on top of the other, and sometimes collapsed entirely. Setting an 8px margin only on the hamburger button may not preserve the correct horizontal alignment between the hamburger and back buttons.

Maybe the Pane part of the control could become a primitive so this scenario could be better supported in the future,

I like this idea. I could definitely have used that when porting Xamarin.Forms' Shell to UWP

@YuliKl @StephenLPeters Is it fine to remove the margin as it doesn't seem to make a difference and causes some spacing issues?

After reading the thread I think it would be safe but I'm not positive.  I don't think there would be a breaking change but I'm not sure if it is present for a reason.

Seems like that margin has been here since the initial commit on the GitHub repository. This might be a long shot but @ojhad, do you know why this margin is there even though it doesn't seem to make a difference?

I see the PaneToggleButtonGrid Margin="0,0,0,8" has been removed from https://github.com/microsoft/microsoft-ui-xaml/blob/82edd199316795fc4fdd83565f9e323fa5383474/dev/NavigationView/NavigationView.xaml#L150 but still exists in NavigationView_v1.xaml any update on what should be done?


WIP: started adding organizations info to site

Do not merge!
This is branch is for the work being worked on with the departmental information.

Page with updates: https://deploy-preview-126--a11ycanada.netlify.app/en/about/organizations/

@duboisp Good news, I set this PR to draft, pushed another commit and Netlify rebuilt with same preview site.

@JulieBB23 This is ready for the content review.


Django 1.7 incompatibility in will_not_clone in versions/admin.py

The changes from https://github.com/swisscom/cleanerversion/commit/f64d69e6cd1e4e3fd030c17adbd9112a28ba4418  for will_not_clone in versions/admin.py broke compatibility with Django 1.7. The invocation of each_context in Django 1.7 doesn't have request as argument. See django/contrib/admin/sites.py on line 264.

Hey, @frensjan, thanks for reporting!

@maennel no problem. Hope the PR helps.


Angular on Rails cannot find packages installed by Bower

Hi.
I'm following Thinkster's tutorial about Angular on Rails(https://thinkster.io/angular-rails#jumping-in-with-angular).
In this tutorial, I install front-end dependencies following way:
bower install angular angular-ui-router bootstrap --save
Then I require bootstrap in application.css in following way:
 *= require bootstrap/dist/css/bootstrap
 *= require_tree .
 *= require_self

And here is application.js file:
//= require angular
//= require angular-rails-templates
//= require angular-ui-router
//= require_tree .

When I run the rails server I get following errors,
1. couldn't find file 'bootstrap/dist/css/bootstrap' with type 'text/css'
2. couldn't find file 'angular' with type 'application/javascript'

Here is an error I'm getting from rails server console:
ActionView::Template::Error (couldn't find file 'bootstrap/dist/css/bootstrap' with type 'text/css'):
    2: <html>
    3: <head>
    4:   <title>FlapperNews</title>
    5:  <%= stylesheet_link_tag    'application', media: 'all' %>
    6:   <%= javascript_include_tag 'application' %>
    7:   <%= csrf_meta_tags %>
    8: </head>
  app/assets/stylesheets/application.css:14
  app/views/layouts/application.html.erb:5:in `_app_views_layouts_application_html_erb___1398966333390810206_70171728569860'

I confirm that bootstrap and angular are correctly installed in Rails app. But it seems like it is not finding it in the app. What could be the problem?

By default rails asset pipeline will check files in "vendor/assets/bower_components" directory. So make your  .bowerrc file configured to
{
  "directory":"vendor/assets/bower_components"
}

still problem is not solved


Implement get_module_property and add JS type

Add JS Array types with a basic implementation (buffer and length properties).

Codecov Report
Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (f3ff5ac) 70.49% compared to head (5624bf8) 70.63%.

:exclamation: Current head 5624bf8 differs from pull request most recent head 5dd5423.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   70.49%   70.63%   +0.14%
==========================================
  Files          21       21
  Lines        4894     4979      +85
==========================================
+ Hits         3450     3517      +67
- Misses       1062     1070       +8
- Partials      382      392      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

So this is what eventually worked for me for Float32Array:

type float32Array struct {
	BackingBuffer []uint8 `embind_arg:"0"`
	ByteOffset    uint32  `embind_arg:"1"`
	Length        int32   `embind_arg:"2"`
	Constructor   *float32Array
	Buffer        []float32
}

func NewFloat32Array(in []float32) *float32Array {
	return &float32Array{
		Buffer:      in,
		Constructor: &float32Array{},
		Length:      int32(len(in)),
	}
}

func (fa *float32Array) Set(in *float32Array) {
	reslice := fa.BackingBuffer[fa.ByteOffset : fa.ByteOffset+(uint32(fa.Length)*4)]
	conv := unsafe.Slice((*uint8)(unsafe.Pointer(&in.Buffer[0])), len(in.Buffer)*4)
	copy(reslice, conv)
	fa.Buffer = in.Buffer
	fa.Length = in.Length
}

I don't really need the New method. The embind_args are necessary because of https://github.com/ggerganov/whisper.cpp/blob/f0efd0202dce4173e2835b187a6d745af3ee59cb/examples/whisper.wasm/emscripten.cpp#L86.
And then in the Set method, we need to copy the slice. The Uint8Array works fine.


Not working

(Traceback):
line 179, in loop
    rpc = BitcoinRPC(settings['host'], settings['port'],
KeyError: 'host'
4 mining threads started
Wed Jul 28 22:12:43 2021 Miner Starts - <IP_ADDRESS>:3333
Wed Jul 28 22:12:43 2021 Miner Stops - <IP_ADDRESS>:3333

config.cfg
#
# RPC login details
#
host=<IP_ADDRESS>
port=3333

rpcuser=Erik_V7
rpcpass=anything

#
# mining details
#

threads=4

# periodic rate for requesting new work, if solution not found
scantime=60

#
# misc.
#

# not really used right now
logdir=/tmp/pyminer

# set to 1, to enable hashmeter output
hashmeter=0

The script is built on python2 , you probably run the script on python3 environment , go download and install python2 and run the script on python2 environment

I have a working miner that uses the current "getworktemplate" in python 3. It is a code from (https://github.com/vsergeev) that I changed to check for a new block every 20 sc or so and start mining again every time a new block is detected. Currently getting 1.01KH/s on a Dell.


Incorrect sorting in the grid

Hey. I use sorting for a grid. It seems like a bug, for example, I drag the cell to the right, but it changes with the one on the left.
Link to youtube demo

@k-ivan I would appreciate more information.
Which version of Chrome are you using?
Does the issue happen on all lists or just the grid demo?
Does it happen when fallback is enabled?

Yeah

Windows 10,  Chrome v72.0.3626.109
It works on both the grid and the lists
forceFallback always false

Strange, but it seems the problem is local, I tried on the second computer there everything is ok. Sorry for the time taken.


update: Linux Micro EFI module use thread/worker for file operations

Currently, Linux Micro EFI module may block on operations involving files, especially (but not only) a sol_util_move_file operation. An improvement that can be done is to perform this work on threads (or at least on idlers) to avoid blocking the mainloop.

is this still needed?


How can we change the num_queries?

I tried to change it at GroundingDINO_SwinT_OGC.py but got
RuntimeError: Error(s) in loading state_dict for GroundingDINO:
size mismatch for transformer.tgt_embed.weight: copying a param with shape torch.Size([900, 256]) from checkpoint, the shape in current model is torch.Size([30, 256]).

num_queries is pre-defined in grounding dino model which can not be changed, if you change the config, it may not be able to load pretrained ckpt


doesn't work

I activate the resource pack and does nothing, and yes i have the Cool Leaves mod

Which version of Minecraft are you on?
Also, do you have any other resourcepacks installed?


Improve dev mode responsive

This PR improves the layout of the demo in dev mode, especially for mobile screens.

:tada: This PR is included in version 1.4.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


set up local environment

This PR attempts to solve #53.

using docker just for hugo, seems a little overkill for me, but to each his own.
I just have hugo installed locally on my windows 11 laptop.
That said, it was my plan to include a section on the site showing how to do that. - I would like to take a closer look at what You added.

I do think it makes sense, but from this info, I don't really get it to work (I'm quite stupid when it comes down to anything other than BC ;-) ).

I'm trying this out - but i'm getting:

Not sure what to do now 🤔

I set "experimantal" to true in my docker deamon...

then it doesn pull , but again an error:

I'm obviously using windows containers .. do I need Linux for this?

I simply downloaded the hugo executable (extended version). Placed it in c:\hugo (See https://gohugo.io/getting-started/installing#less-technical-users)
I added c:\Hugo to my PATH
https://gohugo.io/getting-started/installing#less-technical-users
I am now able to to do a hugo serve -D --disableFastRender

Yes, "Switch to Linux containers" is a must. I need to make that stand out better in the documentation. There might also be an image for windows, I have to investigate.
I like @TheDoubleH 's setup more since the LiveReload function works as expected.
However I'm still trying to make this one work..
If I don't come up with a solution for this by the end of the year, I close this one and focus on the content instead,
as installing Hugo right away is the more solid approach and less time consuming 👍

Hi, got it to work in the container with the --poll parameter. However, I am not satisfied with the solution, because the load on the CPU is just too big and will therefore join @TheDoubleH that it is the best solution to directly install Hugo. That's why I'm closing the PR.


Espalexa does not need UPnP enabled for discovery

Tested with ESP32 and ESP-8266, with UPnP disabled for more than 20 times, none of them needs it to be enabled for discovery.
I really suggest removing "Espalexa might need to have UPnP enabled for discovery to work" in readme.md as UPnP adds more risk to security.

Thank you, I will remove the notice. I was assuming it was required due to the Upnp:rootdevice device type in the SSDP discovery, but it is great news it's not actually needed, since I know it might cause security issues.

Please remove it later. Let me check more first. After installation of new Alexa app, there is strange problem as I said in another issue.

With version 2.3.3, UPnP is also not needed at all. The notice can be safely removed.

Good to hear! Notice will be removed with the next commit!


not appear setting fields at integration screen

@rkyymmt What was your solution for this? We're having the same exact problem.