XPS vamas sub-reader: enhance data extraction

This is a draft for enhancing the existing Vamas XPS reader.
The Vamas reader reads .vms files, which is the current ISO standard data transfer format (ISO 14976).

[x] Write CPS data to file
[ ]  Extract units for quantities
[ ] Parse vamas files of type IRREGULAR

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-10 of 10 (0.0%)  changed or added relevant lines in 1 file are covered.
2 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 44.528%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pynxtools/dataconverter/readers/xps/vms/vamas.py
0
10
0.0%

Files with Coverage Reduction
New Missed Lines
%

pynxtools/dataconverter/convert.py
1
76.92%

pynxtools/dataconverter/readers/shared/map_concepts/mapping_functors.py
1
11.86%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
4903

Relevant Lines:
11011

💛  - Coveralls

Closed as this will be addressed in the xps reader plugin: https://github.com/FAIRmat-NFDI/pynxtools-xps/pull/10


Unit tests for Get-DbaMaxMemory

Changes proposed in this pull request:

Remove obsolete variable from Get-DbaMaxMemory cmdlet.
Add unit tests for Get-DbaMaxMemory cmdlet.

Has been tested on minimum requirements:

[ ]  Powershell 3
[x]  Windows 7
[ ]  SQL Server 2000

Has been tested on maximum requirements:

[x]  Powershell 5
[ ]  SQL Server vNext
[ ]  Windows 10
[ ]  Azure Database

Tests for tester:

[ ] Working/useful help content, including link to command on dbatools web site
[ ] All examples work as advertised
[ ] Does not contain template content
[ ] Does not contain excessive/unnecessary amounts of comments
[ ] Works remotely
[x] Works locally
[ ] Works on lower versions or throws error specifying version not supported
[ ] Works with named instances
[ ] Works with clustered instances
[ ] Handles offline/read only databases
[ ] Supports multiple servers (at the command line or piped from Get-SqlRegisteredServerName)
[ ] No un-handled errors which stop the command working with multiple servers

@SQLDBAWithABeard can you approve or let me know what command to run to test? (or @ie-zero  if you can suggest.)
@ie-zero - thank you SO much for all of the code you've been submitting lately! Looking forward to merging it in.

@ctrlbold - approved - this should be an example PR for testing

Wow, nice work @ie-zero!


Add capnp converters to and from YAML and JSON.

This is an initial attempt at using capnp annotations to enable automated textual format conversions. I've implemented a prototype that converts to/from capnp, YAML, and JSON, all as defined by the capnp schema.
Remaining work:

[x] See if a straight forward abstraction is available that would enable XML
[x] Add cross reference annotations for YAML and XML to enable index cross references instead of indices
[x] Investigate performance, present data, and determine if the current performance is adequate.
[x] Add comments

Some initial numbers:

Converting Linux capable SoC logical netlist takes ~17 seconds to JSON, ~38 seconds to YAML
Converting Linux capable SoC physical netlist takes ~1.5 minutes to JSON, ~3 minutes to YAML
Converting A50T device database takes ~4 minutes to JSON, ~9 minutes to YAML

Performances numbers with latest implementation:

JSON
RapidYaml
PyYAML

Linux capable SoC logical netlist capnp to X (elapsed time, sec)
4.6
10.2
15.6

Linux capable SoC logical netlist capnp to X (max RSS, MB)
259
488
801

Linux capable SoC physical netlist capnp to X (elapsed time, sec)
24.7
59
111

Linux capable SoC physical netlist capnp to X (max RSS, MB)
982
1939
5564

A50T device capnp to X (elapsed time, sec)
92
204

A50T device capnp to X (max RSS, MB)
5217
8258

Caching of the structure lead to a 3x decrease in the JSON conversion time, and the RapidYaml implementation is 2x faster than the PyYaml, and uses about half of the memory footprint.

Performances numbers with latest implementation:

JSON
RapidYaml
PyYAML

Linux capable SoC logical netlist capnp to X (elapsed time, sec)
4.6
10.2
15.6

Linux capable SoC logical netlist capnp to X (max RSS, MB)
259
488
801

Linux capable SoC physical netlist capnp to X (elapsed time, sec)
24.7
59
111

Linux capable SoC physical netlist capnp to X (max RSS, MB)
982
1939
5564

A50T device capnp to X (elapsed time, sec)
92
204

A50T device capnp to X (max RSS, MB)
5217
8258

Caching of the structure lead to a 3x decrease in the JSON conversion time, and the RapidYaml implementation is 2x faster than the PyYaml, and uses about half of the memory footprint.

JSON
RapidYaml
PyYAML

Linux capable SoC logical netlist capnp to X (elapsed time, sec)
4.6
10.2
15.6

Linux capable SoC physical netlist capnp to X (elapsed time, sec)
24.7
59
111

A50T device capnp to X (elapsed time, sec)
92
204
338

JSON
RapidYaml
PyYAML

Linux capable SoC logical netlist capnp to X (max RSS, MB)
259
488
801

Linux capable SoC physical netlist capnp to X (max RSS, MB)
982
1939
5564

A50T device capnp to X (max RSS, MB)
5217
8258
14733

JSON
RapidYaml
PyYAML

Linux capable SoC logical netlist capnp to X (elapsed time, sec)
4.6
10.2
15.6

Linux capable SoC physical netlist capnp to X (elapsed time, sec)
24.7
59
111

A50T device capnp to X (elapsed time, sec)
92
204
338

JSON
RapidYaml
PyYAML

Linux capable SoC logical netlist capnp to X (max RSS, MB)
259
488
801

Linux capable SoC physical netlist capnp to X (max RSS, MB)
982
1939
5564

A50T device capnp to X (max RSS, MB)
5217
8258
14733


Beakpoints refactoring

Moved breakpoints modules into pyOCD.debug.breakpoints package, and split into separate modules: manager, provider, software. FPB was kept under the coresight package.
Also organized Breakpoint classes into a hierarchy.

@mbed-bot: TEST


[feat] Implement private key import for pruned mode

Hi everyone,
I recently attempted to import private key into pruned blockchain Dogecoin Core installation from another wallet used on full blockchain (note: importing private key into full blockchain installation works flawlessly), but not in pruned mode:

Describe the Feature Request
Enable private key import functionality for pruned mode.
Describe Preferred Solution (draft)
This reminded me of a similar issue https://github.com/dogecoin/dogecoin/issues/3518 I've been addressing, to broaden my understanding, and it seems that a lot of code in that issue can also be re-used for implementing key import for pruned mode.  Here is my draft implementation for successful of importprivkey RPC method for pruned mode to start with.
Related Code

Modify wallet.h with static and public helper functions:

static CBlockIndex* GetBlockIndex();
CBlockIndex* GetPrunedRescanIndex();

Implement these member functions in wallet.cpp

CBlockIndex* CWallet::GetPrunedRescanIndex()
{
    CBlockIndex *pindexRescan = chainActive.Tip();
    //use 'temp_chain' as a copy of 'chainActive' in order to obtain
    //block index for desired height (in this case we just need the
    //base of pruned node), which also acts as a starting
    //block index needed for rescan, and to which 'pindexRescan' is
    //pointing to.
    CChain temp_chain = chainActive;
    temp_chain.SetTip(CWallet::GetBlockIndex());
    pindexRescan = temp_chain.Tip();
    return pindexRescan;
}

CBlockIndex* CWallet::GetBlockIndex()
{
    CBlockIndex *block = chainActive.Tip();
    //rewind block index to the base of pruned blockchain
    while (block && block->pprev && (block->pprev->nStatus & BLOCK_HAVE_DATA) && block->pprev->nTx > 0)
                block = block->pprev;
    return block;
}

modify rpcdump.cpp:
Disable error-checking for rescan in pruned mode:

/*
    if (fRescan && fPruneMode)
    throw JSONRPCError(RPC_WALLET_ERROR, "Rescan is disabled in pruned mode");
*/

Add condition for rescanning in pruned mode in rpcdump.cpp:

if (fRescan)
{
    //for pruned mode
    if (fPruneMode)
    {
        const uint32_t npHeight = pwalletMain->GetPrunedRescanIndex()->nHeight;
        attemptRescanFromHeight(npHeight);
    }

     //as before
     else
     {
         const uint32_t nHeight = getHeightParamFromRequest(request, 3);
         attemptRescanFromHeight(nHeight);
     }
}

The result:

Transactions for imported address would not be seen if they go beyond pruned data, but that's the same situation as with addresses that came originally with the wallet.  However, what's important is that the current balance for imported address should be available at the chain tip.
I think importing private keys in pruned mode is a fairly important functionality to have since pruned blockchain is used in different situations, but this may need senior Dogecoin Core developers to examine for security considerations since the code involves some wallet operations (I don't see any security issues as we only traverse blocks and re-use existing key import functionality and temp_chain has local (function) scope and so should be released from memory when GetPrunedRescanIndex() returns).
Thank you,
Victor.

Small update.  I did several test private key imports, using above solution, into pruned node and all were successful.  In addition, I ran rpc-tests and they were successful too:
...
import-rescan.py               | True   | 21 s
...
ALL                            | True   | 1116 s (accumulated)

Quick note about import-rescan.py.  In order to test pruned node variant I had to change line 166 to:
 variant.expect_disabled = False # variant.rescan == Rescan.yes and variant.prune and variant.call == Call.single
since it disallows scans of prune nodes.  In addition, since import-rescan.py also tests importaddress and importpubkey, I also modified these RPCs in rpcdump.cpp, as with 'importprivkey`, to not throw JSONRPCError if (fRescan && fPruneMode) is true and added the "pruned mode" condition for rescan to start from the height as being the base of pruned node, otherwise the following error shows up if "pruned mode" condition is not added:
ERROR: ReadBlockFromDisk: OpenBlockFile failed for CBlockDiskPos(nFile=-1, nPos=0) and the rescan happens faster too 😊

Just a quick note: I think GetPrunedRescanIndex() function can be simplified to set starting rescan index using only GetBlockIndex(), because calling GetAncestor() would be unnecessary in this case (and end up being a little more efficient without extra function call).

I took another look and it's not even necessary to use copy of chainActive with this implementation.  The originally-implemented while-loop for traversing blocks down the chain has all the necessary terminating conditions to get to the bottom of the chain using chainActive for pruned mode.  I used temp_chain in specifying optional height case because it didn't seem possible to directly iterate over active chain with optional height in  https://github.com/dogecoin/dogecoin/issues/3518, (though I think we can do without temp_chain altogether by modifying existing block-traversing while-loop and adding a condition for block->nHeight being equal to specific height).
So, even more simplified version for GetPrunedRescanedIndex() accessor function is:
CBlockIndex* CWallet::GetPrunedRescanIndex()
{
    //Get the current chain's height
    CBlockIndex *pindexRescan = chainActive.Tip();
    //Get starting index for rescan
    pindexRescan = CWallet::GetBlockIndex();
    return pindexRescan;
}

Which would involve factoring out originally implemented while-loop and using these two accessor functions.  Tested using rpc-tests and manually importing private key and it all worked👌


Fix autoscaler bug

When running a VerticaAutoscaler on a VerticaDB where vcluster-ops was not explicitly set to true we hit a CreateContainerError error. This happens because the autoscaler was still internally  using a v1beta1 VerticaDB which led to the conversion webhook wrongfully setting that annotation to false.
This fixes the issue by using a v1 VerticaDB instead.
Closes #908

So the issue is: the customer is using v1 vdb, but v1beta1.vdb will convert vdb to v1beta1 version with wrong values. We probably need to fix the v1-v1beta1 conversion function in a follow-up jira.

No, the conversion logic is fine. The issue is that verticaautoscaler reconcilers were outdated, still using v1beta1 vdb to cache vdb info. So  when you try to convert back from v1beta1 to v1, the absence of vertica.com/vcluster-ops in v1beta1 leads to the annotation being set to false in v1.


multiple projects - single repository

Hi,
I've been trying to work out the best way to handle multiple terraform trees that exist in a single repository.
I can see two options:

create a drone config for the repo which includes a terraform block for every different terraform tree

pros:

parallel execution
easy to see which configs have passed/failed

cons:

with lots of projects this involves running 10s or 100s of tasks which can be really slow
all jobs have to run on every commit - no way to skip steps based on commit data

wrap terraform execution to iterate through a set of directories and run actions in each directory

pros:

simple enough to wrap terraform execution in a shell script which lists files changed in the last commit which means it's possible to only run terraform for configs which have changed

cons:

serial execution

Given the trend in using single repositories as single source of truth these days I was wondering on your opinions on the best way to handle this use case, and whether support for this use case could possibly be added to this plugin if necessary (I'd be happy to work on any agreed implementation!).
Cheers,

@roobert follow https://github.com/drone/drone/issues/1021 and what you want should be accomplish-able in 0.9.


Assertion failed: (repo), function git_repository_workdir

When I try to clone the repo zzflux/ProjectEuler with Clone.clone() I get following error
Assertion failed: (repo), function git_repository_workdir, file ../vendor/libgit2/src/repository.c, line 1809.

@adius could we see what your code looks like please?

The issues was that caused by a 'repo.free()' call.
I'm not entirely sure if I correctly understand what it's good for ^^

@adius a repo.free() will destroy the underlying libgit2 C-struct git_repository object. If you call that the JS object is effectively useless at that point and shouldn't be passed around anymore.

Ok, then I guessed correctly =P
…and I just realized the problem was that although I called at it at the end,
it was possible that some async code was still using it and therefore it crashed.
Thanks for your help!


fix relative paths to react (at least in admin)

out of GH-121, here is instruction to reproduce that issue looks like if you move the build, things don't work anymore (as you could expect with hardcoded relative paths, but it does work for content & structure):

build the whole project
cd apps/admin
mvn clean install && cd target && git clone --depth 1 --branch master git@github.com:adobe/adobe-dx.git checkout && cd checkout

from there if you cd apps/admin/app and run the build of the app, you'll have failure, if you do the same for structure or content, it will work. We need to find a way to stop using static hardcoded paths, as we need those both context to work (this checkout context is what is done when doing a release:perform)

This is solved for now, but I think there's a more global / dynamic way to solve this issue.
For now there might be a way to use a maven profile to kick off a different npm script that would pull react from a different location. I think the root issue was related to some internal react spectrum things trying to run and dying because react was not in apps/admin/app/node_modules. The solution would most likely be:

A new release profile that runs a different NPM script - <arguments>run build-release</arguments>
This would tell NPM to run with a different set of arguments that could be interpreted by webpack - "build-release": "NODE_ENV=production webpack --mode=production --react=local",
Webpack would pick this change up to change where react is located.

happens again on admin app, hence re-opening, i guess we should go for the long term fix you're proposing @auniverseaway


Error loading "main" at http://localhost:9001/dist/main

Getting error "Unhandled promise rejection" "Error loading "main" at http://localhost:9001/dist/main
Not Found: http://localhost:9001/dist/main". Tried the latest code from master and the latest release 0.17.
Firefox and Chrome. The latest working release is 0.15.1

Changed the config to get it work.
From
"*": "dist/*",

to
"*": "dist/*.js",

It will work without .js if you add the defaultJSExtension  setting to the config. Compare your config to the skeleton repo to see what I mean.

@EisenbergEffect  yes, I understand what you mean, but I downloaded the example from this repo, there is defaultJSExtension setting, but I get the error

It sounds like you might not be using the jspm beta, which is required.
On Aug 16, 2015 4:55 AM, "Valiantsin Luchko"<EMAIL_ADDRESS>wrote:

@EisenbergEffect https://github.com/EisenbergEffect yes, I understand
what you mean, but I downloaded the example from this repo, there is
defaultJSExtension setting, but I get the error
—
Reply to this email directly or view it on GitHub
https://github.com/aurelia/skeleton-navigation/issues/144#issuecomment-131504623
.

I also got the error 404 File not Found when I first started the skeleton navigation.
I had followed the instructions and based on this comment:
"Note: Once the jspm beta becomes the mainline release, you will no longer need the @beta."
I had opted to install:
npm install -g jspm
So, not the jspm@beta
As valicheck mentioned, after I changed in config.js
"": "dist/",
to
"": "dist/.js",
all worked fine!


can not find any tracing on stackdriver

I installed isito following by "https://cloud.google.com/istio/docs/istio-on-gke/installing".
match in stackdriver-tracing-rule  is context.protocol == "http" || context.protocol == "grpc".
Stackdriver Trace API is enabled in my GCP project. but i can not find any tracing on stackdriver .
Stackdriver logging is showing well.
any else should i need to set?

@douglas-reid who should be looking at this?  pls reassign as needed.

This seems like a documentation issue, more than anything.
Have you sent >100 requests?  Trace sampling is set to 1%, iirc.  Relevant FAQ entry: https://istio.io/help/faq/distributed-tracing/#no-tracing.  Sometimes, the following is overlooked:

If you still do not see any trace data, please confirm that your ports conform to the Istio port naming conventions and that the appropriate container port is exposed (via pod spec, for example) to enable traffic capture by the sidecar proxy (Envoy).

In the meantime, can you please post info about cluster/istio version here?
/cc @oaktowner

gke version:  gke 1.12.6-gke.10
isito version:  Istio 1.0.6-gke.3
Had sent >100 requests.
One thing I can confirm is that I found the tracing record a month ago (2019-04-09), but there was no tracing record since that day. This seems to indicate that something is wrong about my cluster.
I only saw logs from the mixer container liking as
info	transport: loopyWriter.run returning. Err: connection error: desc = "transport is closing" .
then i restart the pod istio-telemetry , requests logs are showed in the mixer container.
"responseCode":200,"sourceOwner":"","url":"/istio.mixer.v1.Mixer/Report","requestedServerName":"","xForwardedFor":"<IP_ADDRESS>","res..",
it doesn't work.
Does this mean that the istio did not successfully send the records to the stackdriver tracing?

No, the log you pasted looks like a transient error and a sending error should be logged explicitly as tracing api call error. Did you do anything for your cluster around that time range like cluster upgrade?
Also could you follow the instruction here to see if stackdriver tracing related config (instance/handler/rule) works as expected? The instruction is for metric, but tracing adapter's debug basically follows the simple steps.

@bianpengyuan
I did nothing about cluster,just created Serviceentry.
It's a transient error.
2019-05-09T06:05:56.132497Z     info    transport: loopyWriter.run returning. Err: connection error: desc = "transport is closing"
2019-05-09T06:05:56.133045Z     info    pickfirstBalancer: HandleSubConnStateChange: 0xc42afefd90, TRANSIENT_FAILURE
2019-05-09T06:05:56.133174Z     info    pickfirstBalancer: HandleSubConnStateChange: 0xc42afefd90, CONNECTING
2019-05-09T06:05:56.148652Z     info    pickfirstBalancer: HandleSubConnStateChange: 0xc42afefd90, READY
2019-05-09T06:05:56.253953Z     info    transport: loopyWriter.run returning. Err: connection error: desc = "transport is closing"
2019-05-09T06:05:56.255050Z     info    pickfirstBalancer: HandleSubConnStateChange: 0xc429a109b0, TRANSIENT_FAILURE
2019-05-09T06:05:56.255286Z     info    pickfirstBalancer: HandleSubConnStateChange: 0xc429a109b0, CONNECTING
2019-05-09T06:05:56.267096Z     info    pickfirstBalancer: HandleSubConnStateChange: 0xc429a109b0, READY
gc 1381 @77193.516s 0%: 0.024+52+53 ms clock, 0.048+1.0/25/69+106 ms cpu, 249->249->127 MB, 255 MB goal, 2 P
gc 1382 @77254.869s 0%: 0.029+42+66 ms clock, 0.058+6.5/19/52+133 ms cpu, 249->249->127 MB, 255 MB goal, 2 P
scvg514: 1 MB released
scvg514: inuse: 149, idle: 122, sys: 272, released: 1, consumed: 271 (MB)

Verify Mixer is receiving Report calls
does it means this？
kubectl -n istio-system port-forward <istio-telemetry pod> 15014 &
curl http://localhost:15014/
Handling connection for 15014
E0509 14:15:10.692168     863 portforward.go:331] an error occurred forwarding 15014 -> 15014: error forwarding port 15014 to pod 3739605c1277690f9eceb45ede91ca512273ed70301aae18e783ddff01b88d42, uid : exit status 1: 2019/05/09 06:15:10 socat[1
160072] E connect(5, AF=2 <IP_ADDRESS>:15014, 16): Connection refused
curl: (52) Empty reply from server

Verify the Mixer rules exist
kubectl get rules --all-namespaces
NAMESPACE      NAME                       AGE
istio-system   kubeattrgenrulerule        38d
istio-system   promhttp                   38d
istio-system   promtcp                    38d
istio-system   stackdriver-client         38d
istio-system   stackdriver-log            38d
istio-system   stackdriver-log-tcp        38d
istio-system   stackdriver-mixer          38d
istio-system   stackdriver-server         38d
istio-system   stackdriver-tcp-client     38d
istio-system   stackdriver-tcp-server     38d
istio-system   stackdriver-tracing-rule   38d
istio-system   tcpkubeattrgenrulerule     38d

Verify the Prometheus handler configuration exists
kubectl get prometheuses.config.istio.io --all-namespaces
NAMESPACE      NAME      AGE
istio-system   handler   38d

kubectl get handlers.config.istio.io --all-namespaces
No resources found.

Verify Mixer metric instances configuration exists
kubectl get metrics.config.istio.io --all-namespaces
NAMESPACE      NAME                          AGE
istio-system   client-received-bytes-count   38d
istio-system   client-request-bytes          38d
istio-system   client-request-count          38d
istio-system   client-response-bytes         38d
istio-system   client-roundtrip-latencies    38d
istio-system   client-sent-bytes-count       38d
istio-system   mixer-request-count           38d
istio-system   mixer-request-latency         38d
istio-system   requestcount                  38d
istio-system   requestduration               38d
istio-system   requestsize                   38d
istio-system   responsesize                  38d
istio-system   server-received-bytes-count   38d
istio-system   server-request-bytes          38d
istio-system   server-request-count          38d
istio-system   server-response-bytes         38d
istio-system   server-response-latencies     38d
istio-system   server-sent-bytes-count       38d
istio-system   tcpbytereceived               38d
istio-system   tcpbytesent                   38d

---
apiVersion: "config.istio.io/v1alpha2"
kind: rule
metadata:
  name: stackdriver-tracing-rule
  namespace: istio-system
spec:
  match: (context.protocol == "http" || context.protocol == "grpc") && request.headers["x-b3-sampled"] == "1" && destination.workload.name != "istio-telemetry" && destination.workload.name != "istio-pilot"
  actions:
  - handler: handler.stackdriver

I find my stackdriver-tracing-rule doesn't have instances.After editing the rules , it still doesn't work
instances:
 - stackdriver-span.tracespan

Hi, the tracing rule does not look right because it does not have addon reconcile labels.
Could you run the following command and paste the output here:

kubectl get rule stackdriver-tracing-rule -n istio-system -o yaml
kubectl get tracespan stackdriver-span -n istio-system -o yaml
kubectl get stackdriver handler -n istio-system -o yaml

And sorry the instruction I linked is for 1.1. Could you try to follow the instruction here to get output from /metrics, see if there are stackdriver-span dispatching to stackdriver handler. Thanks!

sure
kubectl get rule stackdriver-tracing-rule -n istio-system -o yaml
apiVersion: config.istio.io/v1alpha2
kind: rule
metadata:
  creationTimestamp: 2019-03-01T22:55:09Z
  generation: 1
  labels:
    addonmanager.kubernetes.io/mode: EnsureExists
    k8s-app: istio
  name: stackdriver-tracing-rule
  namespace: istio-system
  resourceVersion: "17999181"
  selfLink: /apis/config.istio.io/v1alpha2/namespaces/istio-system/rules/stackdriver-tracing-rule
  uid: 3db531a7-33d0-11e9-8478-42010a92013a
spec:
  actions:
  - handler: handler.stackdriver
  match: context.protocol == "http" || context.protocol == "grpc"

kubectl get tracespan stackdriver-span -n istio-system -o yaml
apiVersion: config.istio.io/v1alpha2
kind: tracespan
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"config.istio.io/v1alpha2","kind":"tracespan","metadata":{"annotations":{},"labels":{"addonmanager.kubernetes.io/mode":"Reconcile","k8s-app":"istio"},"name":"stackdriver-span","namespace":"istio-system"},"spec":{"clientSpan":"(context.reporter.kind | \"inbound\") == \"outbound\"","endTime":"response.time","parentSpanId":"request.headers[\"x-b3-parentspanid\"] | \"\"","rewriteClientSpanId":"true","spanId":"request.headers[\"x-b3-spanid\"] | \"\"","spanName":"destination.service.host | destination.service.name | destination.workload.name | \"unknown\"","spanTags":{"api_name":"api.service | \"unknown\"","api_version":"api.version | \"unknown\"","destination_owner":"destination.owner | \"unknown\"","destination_port":"destination.port | 0","destination_service_name":"destination.service.name | \"unknown\"","destination_service_namespace":"destination.service.namespace | \"unknown\"","destination_workload_name":"destination.workload.name | \"unknown\"","destination_workload_namespace":"destination.workload.namespace | \"unknown\"","http_url":"request.path | \"\"","request_operation":"conditional((context.protocol | \"unknown\") == \"grpc\", request.path | \"unknown\", request.method | \"unknown\")","request_protocol":"context.protocol | \"unknown\"","request_size":"request.size | 0","response_code":"response.code | 0","response_size":"response.size | 0","service_authentication_policy":"conditional((context.reporter.kind | \"inbound\") == \"outbound\", \"unknown\", conditional(connection.mtls | false, \"mutual_tls\", \"none\"))","source_ip":"source.ip | ip(\"<IP_ADDRESS>\")","source_owner":"source.owner | \"unknown\"","source_workload_name":"source.workload.name | \"unknown\"","source_workload_namespace":"source.workload.namespace | \"unknown\""},"startTime":"request.time","traceId":"request.headers[\"x-b3-traceid\"]"}}
  creationTimestamp: 2019-03-01T22:55:16Z
  generation: 1
  labels:
    addonmanager.kubernetes.io/mode: Reconcile
    k8s-app: istio
  name: stackdriver-span
  namespace: istio-system
  resourceVersion: "10740205"
  selfLink: /apis/config.istio.io/v1alpha2/namespaces/istio-system/tracespans/stackdriver-span
  uid: 4237aae0-33d0-11e9-8478-42010a92013a
spec:
  clientSpan: (context.reporter.kind | "inbound") == "outbound"
  endTime: response.time
  parentSpanId: request.headers["x-b3-parentspanid"] | ""
  rewriteClientSpanId: "true"
  spanId: request.headers["x-b3-spanid"] | ""
  spanName: destination.service.host | destination.service.name | destination.workload.name
    | "unknown"
  spanTags:
    api_name: api.service | "unknown"
    api_version: api.version | "unknown"
    destination_owner: destination.owner | "unknown"
    destination_port: destination.port | 0
    destination_service_name: destination.service.name | "unknown"
    destination_service_namespace: destination.service.namespace | "unknown"
    destination_workload_name: destination.workload.name | "unknown"
    destination_workload_namespace: destination.workload.namespace | "unknown"
    http_url: request.path | ""
    request_operation: conditional((context.protocol | "unknown") == "grpc", request.path
      | "unknown", request.method | "unknown")
    request_protocol: context.protocol | "unknown"
    request_size: request.size | 0
    response_code: response.code | 0
    response_size: response.size | 0
    service_authentication_policy: conditional((context.reporter.kind | "inbound")
      == "outbound", "unknown", conditional(connection.mtls | false, "mutual_tls",
      "none"))
    source_ip: source.ip | ip("<IP_ADDRESS>")
    source_owner: source.owner | "unknown"
    source_workload_name: source.workload.name | "unknown"
    source_workload_namespace: source.workload.namespace | "unknown"
  startTime: request.time
  traceId: request.headers["x-b3-traceid"]

kubectl get stackdriver handler -n istio-system -o yaml
apiVersion: config.istio.io/v1alpha2
kind: stackdriver
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"config.istio.io/v1alpha2","kind":"stackdriver","metadata":{"annotations":{},"labels":{"addonmanager.kubernetes.io/mode":"Reconcile","k8s-app":"istio"},"name":"handler","namespace":"istio-system"},"spec":{"logInfo":{"server-accesslog-stackdriver.logentry.istio-system":{"labelNames":["source_uid","source_ip","source_app","source_principal","source_name","source_workload","source_namespace","source_owner","destination_uid","destination_app","destination_ip","destination_service_host","destination_workload","destination_name","destination_namespace","destination_owner","destination_principal","api_name","api_version","api_claims","api_key","request_operation","protocol","method","url","response_code","response_size","request_size","request_id","client_trace_id","latency","service_authentication_policy","user_agent","response_timestamp","received_bytes","sent_bytes","referer"]},"server-tcp-accesslog-stackdriver.logentry.istio-system":{"labelNames":["connection_id","connection_event","source_uid","source_ip","source_app","source_principal","source_name","source_workload","source_namespace","source_owner","destination_uid","destination_app","destination_ip","destination_service_host","destination_workload","destination_name","destination_namespace","destination_owner","destination_principal","protocol","connction_duration","service_authentication_policy","received_bytes","sent_bytes","total_received_bytes","total_sent_bytes"]}},"metricInfo":{"client-received-bytes-count.metric.istio-system":{"kind":3,"metric_type":"istio.io/service/client/received_bytes_count","value":2},"client-request-bytes.metric.istio-system":{"buckets":{"exponentialBuckets":{"growthFactor":2,"numFiniteBuckets":20,"scale":1}},"kind":3,"metric_type":"istio.io/service/client/request_bytes","value":5},"client-request-count.metric.istio-system":{"kind":3,"metric_type":"istio.io/service/client/request_count","value":2},"client-response-bytes.metric.istio-system":{"buckets":{"exponentialBuckets":{"growthFactor":2,"numFiniteBuckets":20,"scale":1}},"kind":3,"metric_type":"istio.io/service/client/response_bytes","value":5},"client-roundtrip-latencies.metric.istio-system":{"buckets":{"exponentialBuckets":{"growthFactor":2,"numFiniteBuckets":20,"scale":1}},"kind":3,"metric_type":"istio.io/service/client/roundtrip_latencies","value":5},"client-sent-bytes-count.metric.istio-system":{"kind":3,"metric_type":"istio.io/service/client/sent_bytes_count","value":2},"mixer-request-count.metric.istio-system":{"kind":3,"metric_type":"container.googleapis.com/internal/addons/istio/mixer_request_count","value":2},"mixer-request-latency.metric.istio-system":{"buckets":{"exponentialBuckets":{"growthFactor":2,"numFiniteBuckets":20,"scale":1}},"kind":3,"metric_type":"container.googleapis.com/internal/addons/istio/mixer_request_latency","value":5},"server-received-bytes-count.metric.istio-system":{"kind":3,"metric_type":"istio.io/service/server/received_bytes_count","value":2},"server-request-bytes.metric.istio-system":{"buckets":{"exponentialBuckets":{"growthFactor":2,"numFiniteBuckets":20,"scale":1}},"kind":3,"metric_type":"istio.io/service/server/request_bytes","value":5},"server-request-count.metric.istio-system":{"kind":3,"metric_type":"istio.io/service/server/request_count","value":2},"server-response-bytes.metric.istio-system":{"buckets":{"exponentialBuckets":{"growthFactor":2,"numFiniteBuckets":20,"scale":1}},"kind":3,"metric_type":"istio.io/service/server/response_bytes","value":5},"server-response-latencies.metric.istio-system":{"buckets":{"exponentialBuckets":{"growthFactor":2,"numFiniteBuckets":20,"scale":1}},"kind":3,"metric_type":"istio.io/service/server/response_latencies","value":5},"server-sent-bytes-count.metric.istio-system":{"kind":3,"metric_type":"istio.io/service/server/sent_bytes_count","value":2}},"pushInterval":"10s","trace":{"sampleProbability":1}}}
  creationTimestamp: 2019-03-01T22:55:16Z
  generation: 1
  labels:
    addonmanager.kubernetes.io/mode: Reconcile
    k8s-app: istio
  name: handler
  namespace: istio-system
  resourceVersion: "10740100"
  selfLink: /apis/config.istio.io/v1alpha2/namespaces/istio-system/stackdrivers/handler
  uid: 41f963ea-33d0-11e9-8478-42010a92013a
spec:
  logInfo:
    server-accesslog-stackdriver.logentry.istio-system:
      labelNames:
      - source_uid
      - source_ip
      - source_app
      - source_principal
      - source_name
      - source_workload
      - source_namespace
      - source_owner
      - destination_uid
      - destination_app
      - destination_ip
      - destination_service_host
      - destination_workload
      - destination_name
      - destination_namespace
      - destination_owner
      - destination_principal
      - api_name
      - api_version
      - api_claims
      - api_key
      - request_operation
      - protocol
      - method
      - url
      - response_code
      - response_size
      - request_size
      - request_id
      - client_trace_id
      - latency
      - service_authentication_policy
      - user_agent
      - response_timestamp
      - received_bytes
      - sent_bytes
      - referer
    server-tcp-accesslog-stackdriver.logentry.istio-system:
      labelNames:
      - connection_id
      - connection_event
      - source_uid
      - source_ip
      - source_app
      - source_principal
      - source_name
      - source_workload
      - source_namespace
      - source_owner
      - destination_uid
      - destination_app
      - destination_ip
      - destination_service_host
      - destination_workload
      - destination_name
      - destination_namespace
      - destination_owner
      - destination_principal
      - protocol
      - connction_duration
      - service_authentication_policy
      - received_bytes
      - sent_bytes
      - total_received_bytes
      - total_sent_bytes
  metricInfo:
    client-received-bytes-count.metric.istio-system:
      kind: 3
      metric_type: istio.io/service/client/received_bytes_count
      value: 2
    client-request-bytes.metric.istio-system:
      buckets:
        exponentialBuckets:
          growthFactor: 2
          numFiniteBuckets: 20
          scale: 1
      kind: 3
      metric_type: istio.io/service/client/request_bytes
      value: 5
    client-request-count.metric.istio-system:
      kind: 3
      metric_type: istio.io/service/client/request_count
      value: 2
    client-response-bytes.metric.istio-system:
      buckets:
        exponentialBuckets:
          growthFactor: 2
          numFiniteBuckets: 20
          scale: 1
      kind: 3
      metric_type: istio.io/service/client/response_bytes
      value: 5
    client-roundtrip-latencies.metric.istio-system:
      buckets:
        exponentialBuckets:
          growthFactor: 2
          numFiniteBuckets: 20
          scale: 1
      kind: 3
      metric_type: istio.io/service/client/roundtrip_latencies
      value: 5
    client-sent-bytes-count.metric.istio-system:
      kind: 3
      metric_type: istio.io/service/client/sent_bytes_count
      value: 2
    mixer-request-count.metric.istio-system:
      kind: 3
      metric_type: container.googleapis.com/internal/addons/istio/mixer_request_count
      value: 2
    mixer-request-latency.metric.istio-system:
      buckets:
        exponentialBuckets:
          growthFactor: 2
          numFiniteBuckets: 20
          scale: 1
      kind: 3
      metric_type: container.googleapis.com/internal/addons/istio/mixer_request_latency
      value: 5
    server-received-bytes-count.metric.istio-system:
      kind: 3
      metric_type: istio.io/service/server/received_bytes_count
      value: 2
    server-request-bytes.metric.istio-system:
      buckets:
        exponentialBuckets:
          growthFactor: 2
          numFiniteBuckets: 20
          scale: 1
      kind: 3
      metric_type: istio.io/service/server/request_bytes
      value: 5
    server-request-count.metric.istio-system:
      kind: 3
      metric_type: istio.io/service/server/request_count
      value: 2
    server-response-bytes.metric.istio-system:
      buckets:
        exponentialBuckets:
          growthFactor: 2
          numFiniteBuckets: 20
          scale: 1
      kind: 3
      metric_type: istio.io/service/server/response_bytes
      value: 5
    server-response-latencies.metric.istio-system:
      buckets:
        exponentialBuckets:
          growthFactor: 2
          numFiniteBuckets: 20
          scale: 1
      kind: 3
      metric_type: istio.io/service/server/response_latencies
      value: 5
    server-sent-bytes-count.metric.istio-system:
      kind: 3
      metric_type: istio.io/service/server/sent_bytes_count
      value: 2
  pushInterval: 10s
  trace:
    sampleProbability: 1

kubectl -n istio-system port-forward  9093 &
Forwarding from <IP_ADDRESS>:9093 -> 9093
Forwarding from [::1]:9093 -> 9093
Handling connection for 9093

curl http://localhost:9093
404 page not found

It seems that Mixer is not  receiving Report calls.

The tracing rule seems to be wrong, it does not have instance included. Also why your tracing rule is different from the one you pasted in the former comment?
You need to get curl /metrics, i.e. instead of localhost:9093, you should curl localhost:9093/metrics.

I restored it to the original.beacuse it didn't work.
Is that mean the instance is right like this ?
kubectl get rule stackdriver-tracing-rule -n istio-system -o yaml
apiVersion: config.istio.io/v1alpha2
kind: rule
metadata:
  creationTimestamp: 2019-02-18T22:55:09Z
  generation: 1
  labels:
    addonmanager.kubernetes.io/mode: EnsureExists
    k8s-app: istio
  name: stackdriver-tracing-rule
  namespace: istio-system
  resourceVersion: "18160960"
  selfLink: /apis/config.istio.io/v1alpha2/namespaces/istio-system/rules/stackdriver-tracing-rule
  uid: 3db531a7-33d0-11e9-8478-42010a92013a
spec:
  actions:
  - handler: handler.stackdriver
    instances:
    - stackdriver-span.tracespan
  match: context.protocol == "http" || context.protocol == "grpc"

1 Verify Mixer is receiving Report calls
# TYPE grpc_server_handled_total counter
grpc_server_handled_total{grpc_code="OK",grpc_method="Report",grpc_service="istio.mixer.v1.Mixer",grpc_type="unary"} 1.798421e+06

2 Verify there are no known configuration errors
metrics the most up-to-date value is 0。
3 Verify Mixer is sending metric instances to the Prometheus adapter
# HELP mixer_runtime_dispatch_count Total number of adapter dispatches handled by Mixer.
# TYPE mixer_runtime_dispatch_count counter
mixer_runtime_dispatch_count{adapter="kubernetesenv",error="false",handler="handler.kubernetesenv.istio-system",meshFunction="kubernetes"} 9.876804e+06
mixer_runtime_dispatch_count{adapter="kubernetesenv",error="true",handler="handler.kubernetesenv.istio-system",meshFunction="kubernetes"} 0
mixer_runtime_dispatch_count{adapter="prometheus",error="false",handler="handler.prometheus.istio-system",meshFunction="metric"} 1.798421e+06
mixer_runtime_dispatch_count{adapter="prometheus",error="true",handler="handler.prometheus.istio-system",meshFunction="metric"} 0
mixer_runtime_dispatch_count{adapter="stackdriver",error="false",handler="handler.stackdriver.istio-system",meshFunction="logentry"} 1.798421e+06
mixer_runtime_dispatch_count{adapter="stackdriver",error="false",handler="handler.stackdriver.istio-system",meshFunction="metric"} 1.798421e+06
mixer_runtime_dispatch_count{adapter="stackdriver",error="false",handler="handler.stackdriver.istio-system",meshFunction="tracespan"} 772056
mixer_runtime_dispatch_count{adapter="stackdriver",error="true",handler="handler.stackdriver.istio-system",meshFunction="logentry"} 0
mixer_runtime_dispatch_count{adapter="stackdriver",error="true",handler="handler.stackdriver.istio-system",meshFunction="metric"} 0
mixer_runtime_dispatch_count{adapter="stackdriver",error="true",handler="handler.stackdriver.istio-system",meshFunction="tracespan"} 0
mixer_runtime_dispatch_count{adapter="stdio",error="false",handler="handler.stdio.istio-system",meshFunction="logentry"} 855003
mixer_runtime_dispatch_count{adapter="stdio",error="true",handler="handler.stdio.istio-system",meshFunction="logentry"} 0

The rule looks right to me now.
mixer_runtime_dispatch_count{adapter="stackdriver",error="false",handler="handler.stackdriver.istio-system",meshFunction="tracespan"} 772056 suggests tracespans are dispatched to stackdriver handler correctly. I am running out of idea what is going wrong here now..

@bianpengyuan There should be other causes.Thank you for your help.

@maonaoda does this mean the issue is resolved?  or is more help needed?

@douglas-reid
After doing "curl -vv http://www.google.com " in one pod.
I find a trace on stackdriver named Sent.www.google.com.
Stackdriver-tracing is working well.
But when i sent my own requests,there still no trace catched ,which i don't have any idea.

I found traces by curling  from istio-ingressgateway.
Thanks!!!


Ticket #25215 -- Refactor of lazy model operations

See Trac ticket at https://code.djangoproject.com/ticket/24215.

Would it work to simply refactor add_lazy_relation rather than changing the API?

Thanks for having a look at this Collin. I've explain myself (I think) much better in a new comment on the Trac ticket.

Thanks for the thorough review @carljm. The code is in much better shape for it. Main points:

Removing kwargs from Apps.lazy_model_operation has simplified its implementation enormously. I've left support for kwargs in lazy_related_operation, but the kwargs are folded into the callback with partial before calling Apps.lazy_model_operation.
Eliminating the use of class_prepared was also a big win. It let me eliminate some special case handling in do_pending_lookups, because it's now called is called after register_model.
The recursive handling of multiple models is clearer now, thanks to the elimination of kwargs handling. I believe it's worth keeping, because ensuring that all pending operations accept exactly one model argument makes everything else dead simple.

I like this patch a lot. It simplifies the related field loading process a bit, but even more importantly this will make it easy to restructure the related field loading process even more. I'd like to get this committed as soon as possible so I can rebase my work on ticket #24317 on these changes.

This needs to be rebased against master and the some imports need re-arrangement.

The updates look excellent, @AlexHill , thanks! I'm also very happy with this patch, and would love to see it go in as soon as the minor code formatting stuff is addressed.
I did notice that there is a remaining reference to class_prepared in a comment here, which is probably inaccurate now? : https://github.com/AlexHill/django/blob/lazy_ops_refactor/django/db/migrations/state.py#L170

Please add docs for that deprecation: https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#deprecating-a-feature
I don't think this patch is a candidate for 1.8, so the deprecation should end in 2.1 as Carl noted. You will need to create a new PR against master.

Yep, I'll rebase on master now, add the deprecation docs and deprecate in 2.1. Does this warrant a mention in the release notes or just the deprecation timeline? I'll assume it does until corrected.

Technically changes to internal undocumented APIs don't get mentioned in the release notes, but we've often done so anyway if we had reason to think the API was in use in the wild. In this case I think a brief note might be warranted.

Yes, all deprecations should be mentioned.


Update bitcore to 0.11.4

Coverage remained the same at 91.25% when pulling 3825fca287798db0422653140a9e8ba4f0f5c535 on braydonf:update-bitcore-0.11.4 into 263c76461f53b3c1a9a2c3452dc649c8fcc18d79 on bitpay:master.


koord-manager: introduce api for node resource amplification

Ⅰ. Describe what this PR does
This PR introduces API and its utils for for node resource amplification.
Ⅱ. Does this pull request fix one issue?
Part of #1539
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist

[x] I have written necessary docs and comments
[ ] I have added necessary unit tests and integration tests
[ ] All checks passed in make test

/cc @saintube
/hold for UT

/lgtm
PTAL @eahydra

/unhold

/assign @fillzpp


Incorrect error printout when getting Northstar User (sometimes)

BUG
Current Behavior
Relevant function
In the above function, sometimes we successfully look up the user's Northstar ID but fail to return the actual Northstar user. In that case, the error printout is not helpful because it assumes it will be printing the drupal id (which is an integer) but then is given the Northstar ID, which is a string. It truncates the string when the letters start, often print out 58 for the id.
Desired Behavior
A different error printout if $id is the Northstar ID.
Steps to Replicate
I think this would happen in any case where we do get the Northstar ID but do not get the Northstar user.
Why This Matters
The current error printout is confusing because it's not what really happened.

 🐛👻 Incorrect error printout when getting Northstar User (sometimes) 👻🐛


Update repo stars link

What's changed?
Update repo stars link

That doesn't work, you are nesting too deeply, see:

Done


Add a license

A license needs to be added to the code. I suggest using BSD New v. 3.0 for full compatibility with QuTiP and the NumPy stack. @araza6, Github will prompt the templates directly once you try to add a file called LICENSE from the web interface. This can still be added as a PR then, instead of merging to master.

Closing this issue with PR https://github.com/qgrad/qgrad/pull/7


Build new classes about basic HTML/CSS

Build around 20 classes for the basic HTML/CSS subject

Solved in #16


[FLINK-4455] [FLINK-4424] [networkenv] Make NetworkEnvironment independent of ActorGateway and JobManager association

Makes the NetworkEnvironment independent of the JobManager association. This means that the
NetworkEnvironment and with it the ConnectionManager is started before the TaskManager actor
is executed. Furthermore, the ConnectionManager keeps running even in case of a JobManager
disassocation. In the wake of the remodelling this behaviour, the PartitionStateChecker and
the ResultPartitionConsumableNotifier which depend on the JobManager association were moved
out of the NetworkEnvironment. They are now contained in the SlotEnvironment which will be
set up when the TaskManager connects to a JobManager. The SlotEnvironment contains all
information related to the associated JobManager. Since all slots are implicitly associated
with the JobManager which is the leader, we only create one SlotEnvironment which is shared
by all Tasks.
Introduce SlotEnvironment to accommodate the PartitionStateChecker and ResultPartitionConsumableNotifier
Remove the PartitionStateChecker and the ResultPartitionConsumableNotifier from the
NetworkEnvironment. Start the NetworkEnvironment when the TaskManager components are
created. Keep the NetworkEnvironment running also when the JobManager is disassociated.

+1 for moving the PartitionStateChecker and ResultPartitionConsumableNotifier out of the NetworkEnvironment.
Few questions and comments:

Do we need an extra ExecutorService in the TaskManager? I have been digging through a bunch of thread dumps over time and there are already many threads and pools already. I would really like to avoid having yet another Thread pool (creating thread pools should be an extremely careful decision).

The Akka thread pool executor is quite over-provisioned for the few actors we actually use. I think it is perfectly feasible to use that one for the few extra futures introduced here. In any case, if not reusing the Akka executor pool, then the thread pool needs to be shut down in the TaskManager runner. Otherwise it creates a leak when running successive local Flink jobs.

I am a bit consumed about the SlotEnvironment. Maybe it is mainly the name, but what does it have to do with the slots? Is it not more like a network-messages specific JobManager Connection?

The ResultPartitionConsumableNotifier could be per Task - that way, future multi-JobManager assiciations would work seamlessly and it could directly call fail(...) on the Task without having to go through the TaskManager. It could probably leave the TaskManager out of the picture completely.

Thanks for the quick and thorough review @StephanEwen.

Concerning the ExecutionContext in the TaskManager: This is simply the ExecutionContext which was passed before to the NetworkEnvironment but now is no longer needed there. I agree that we should be careful with thread pool creations. At the moment, we create for each JobManager and TaskManager an additional execution context. The advantage of this approach is that we separate the actor execution from the execution of other components. Thus, it's not possible that another component starves the execution context of the actor and thus influences its responsiveness. But I agree that the few additional future callbacks shouldn't be a big burden for the TaskManager actor system. Will change it.

It is true that there is no notion of slots on the TaskManager right now. I've named it SlotEnvironment because with the Flip-6 refactorings we need to maintain multiple job manager connections and every task runs in a slot which is associated with a JobManager. Renaming it to JobManagerConnection should better reflect what it actually is.

Yes that is a good idea. Will try to attach the ResultPartitionConsumableNotifier to the Task.

I've addressed your comments @StephanEwen.

Looks good to me, +1

Tests have passed locally. Will rebase check again on Travis and then merge the PR.

Build has passed on Travis with local repo. Will merge the PR.


Replace deprecated uses of @pipeline

My attempt to fix #15 .
I am unable to test this so I made it a draft until someone can confirm that it fixes the issue.
P.S. Sorry about the noise in the diff, my VSCode is set to remove trailing whitespace.

Tested it and this seems to fix it! I just had to also replace wherever I used @pipeline in my code with a sequence of pipe operators, e.g. "@pipeline FeatureSelector Standardizer..." replaced with "FeatureSelector |> Standardizer..."


Issue with Aggregations on language field

Content.lang field does not give proper result when used in term aggregations having language zh-cn and zh-tw
I am using aggregations on content.lang filed as below
{
"aggs" : {
"tags" : {
"terms" : {
"field" : "content.lang"
}
}
}
}
the result is
"aggregations": {
"tags": {
"doc_count_error_upper_bound": 0,
"sum_other_doc_count": 5,
"buckets": [
{
"key": "zh",
"doc_count": 6
},
{
"key": "cn",
"doc_count": 4
},
{
"key": "en",
"doc_count": 4
},
{
"key": "ar",
"doc_count": 2
},
{
"key": "de",
"doc_count": 2
},
{
"key": "es",
"doc_count": 2
},
{
"key": "fr",
"doc_count": 2
},
{
"key": "ja",
"doc_count": 2
},
{
"key": "ko",
"doc_count": 2
},
{
"key": "no",
"doc_count": 2
}
]
}
}
I have document with zh-cn and zh-tw language.When using aggregations it splits the word from "-" and makes two different words..See above output zh=6 and cn=4.But actually this is a single language "zh-cn"
Is this a bug? or do i have to set up anything else to make a whole word

New release <IP_ADDRESS> contains a bug fix. Thanks for reporting.


No Error hanlder

Hey, there's no error handler which makes using the lib quite difficult.

Agreed, just spent a fair amount time debugging because the path the to the swf was wrong:
ngClipProvider.setPath('/bower_components/zeroclipboard/dist/ZeroClipboard.swf');

In this case, the bower install location changed from /app/bower/ to the usual location.  Everything but this module worked.  I'd be willing to help with some PRs if @asafdav is still planning on maintaining this module.
The only indication I had was that my cpu began to peg and the fans turned on :P

Hi, I'm am planning to maintain this lib, what kind of PR would you like to
propose ?
On Wed, Jun 24, 2015 at 8:01 AM, Levi Thomason<EMAIL_ADDRESS>wrote:

Agreed, just spent a fair amount time debugging because the path the to
the swf was wrong:
ngClipProvider.setPath('/bower_components/zeroclipboard/dist/ZeroClipboard.swf');
In this case, the bower install location changed from /app/bower/ to the
usual location. Everything but this module worked. I'd be willing to help
with some PRs if @asafdav https://github.com/asafdav is still planning
on maintaining this module.
The only indication I had was that my cpu began to peg and the fans turned
on :P
—
Reply to this email directly or view it on GitHub
https://github.com/asafdav/ng-clip/issues/66#issuecomment-114728004.

Currently, when something goes wrong there is no indication of where to look or what went wrong.
Perhaps one place to start could be bundling the dependency so the user doesn't have to point to the SWF. Another option might be throwing an error if the SWF is not found at the location specified.


Radx commands give NetCDF warning

RadxPrint and RadxConvert give the following warnings:
NetCDF: Unknown file format
NetCDF: Unknown file format
This happens in the Docker virtual toolbox and the native Mac build. The commands then continue on and doesn't fail, so this is either a warning or minor error.

This warning is coming from NetCDF:
tar_files/netcdf-<IP_ADDRESS>/libdispatch/derror.c:	 return "NetCDF: Unknown file format";

libs/Ncxx/Nc3File - using Nc3Error::verbose_nonfatal in the construct…
…or instead of silent_nonfatal
This line of code was changed,
Nc3File::Nc3File( const char* path, FileMode fmode,
size_t* bufrsizeptr, size_t initialsize, FileFormat fformat  )
{
Nc3Error err(Nc3Error::silent_nonfatal); // constructor must not fail .       *** was . ***
Nc3Error err(Nc3Error::verbose_nonfatal); // constructor must not fail .   *** is now ***
and this causes ...
int Nc3Error::set_err (int err)
{
ncerr = err;
// Check ncopts and handle appropriately
if(err != NC_NOERR) {
if(ncopts == verbose_nonfatal || ncopts == verbose_fatal) {
std::cout << nc_strerror(err) << std::endl;                                  *** this error message to print ***
}
and the error message comes from ...
Binary file tar_files/netcdf-<IP_ADDRESS>/libdispatch/libdispatch_la-derror.o matches
const char *nc_strerror(int ncerr1) {
case NC_ENOTNC:
—> tar_files/netcdf-<IP_ADDRESS>/libdispatch/derror.c:	 return "NetCDF: Unknown file format";


pc list should identify plugins that are in the list but not enabled -- colored red

pc list should identify plugins that are in the list but not enabled -- colored red, for example. Similarly, pc group list should identify groups for which no members are loaded.
Suggestion made by @SlimeDog https://github.com/SrBedrock/PluginControl/issues/3#issuecomment-1718344556

Red and green works. It would be nice if I could configure the colors.


Support typing hint in PythonJob

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.67%. Comparing base (920e59a) to head (92f67b1).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   73.57%   73.67%   +0.09%
==========================================
  Files          62       62
  Lines        3784     3798      +14
==========================================
+ Hits         2784     2798      +14
  Misses       1000     1000

Flag
Coverage Δ

python-3.11
73.67% <100.00%> (+0.09%)
:arrow_up:

python-3.9
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Policy for web framework integrations

Now that we're getting a handful of PRs adding these, I think it would be good to define which web frameworks should and shouldn't be integrated into Maud.

This would be in constant flux as the ecosystem evolves, right? What are you looking for in this thread – objective signals to assess a framework's popularity which could help motivate accepting/refusing a PR?
Given that web framework integration are gated by non-default crate features, I'm not sure I understand the rationale for ever refusing adding one, if someone went through the trouble of creating a well-tested PR to support a new framework. Rust is not JS, I don't anticipate a high load, do you?

Thanks @zopieux. I think my main concern here is my workload. I don't want to spend a lot of time updating all the integrations every time I change something.
I think the only rule here we need is that support is "best effort" -- we'll try our best not to break anything, but the bulk of the maintenance work will be provided by the community. (Which is de facto the current situation anyway.)

I think that https://maud.lambda.xyz/web-frameworks.html is way enough and particularly useful!
Thanks for all your work on maud! It's a really nice lib!


chore: update frontend environment variables

Changes proposed in this pull request

Updated frontend environment variables: GRAPHQL_URL, OPEN_PAYMENTS_URL, ENABLE_INSECURE_MESSAGE_COOKIE, NODE_ENV, KRATOS_ADMIN_URL.
Changed start command in package.json.
Updated docs with the new changes.

Context

For this issue, I made the following changes:

Made GRAPHQL_URL and OPEN_PAYMENTS_URL mandatory and removed their default values.
Set NODE_ENV  to production in docker files.
Set default value for ENABLE_INSECURE_MESSAGE_COOKIE to true in docker files and removed it from start script in package.json
Added KRATOS_ADMIN_URL to variables in envConfig.server.ts.
Updated frontend-variables.mdx.

Fixes #2994
Checklist

[ ] Related issues linked using fixes #number
[ ] Tests added/updated
[ ] Make sure that all checks pass
[ ] Bruno collection updated (if necessary)
[ ] Documentation issue created with user-docs label (if necessary)
[ ] OpenAPI specs updated (if necessary)

Related to #2994

Doc updates are ready to go in PR #3042 3042, but I'm waiting for this issue and #2994 to be merged first. (Please let me merge my PR when it's time, there are prettier issues I need to fix first).

@melissahenderson merged!


refactor: enum renaming

Make enums more readable.

lgtm. Let's use their official names in our code:
RedShift -> Redshift
SnowFlake -> Snowflake
Dynamodb -> DynamoDB

@YikSanChan updated


How to be able to know to redirect to 3ds validation window close event

Is your feature request related to a problem? Please describe.
The business requirement is that when the user redirects to a third-party page (such as 3ds), the user closes the verification window or exits the payment, how can we know?
Describe the solution you'd like
You need to know that the user exits the payment after the redirection is to the third party page
Describe alternatives you've considered
How to implement nesting of third-party pages in the form of iframes, currently calling handleAction will reopen the window and jump
Additional context

@lynn1286 - does this answer your question at all? (Relates specifically to 3DS2)

Clicking on the Cancel button, however, does lead to a measurable result - cancelling is a legitimate user action in the 3DS2 flow and will lead to a call to any onAdditionalDetails handler that you have defined.
If this handler then makes the expected call to the /payments/details end point you will get a response with a resultCode: "Refused" and a refusalReason: "3D Not Authenticated"

(from #1839)

This is not my problem. I hope that when the component can redirect the third-party page, I can display this page in the form of iframe without jumping to the page. I looked at the official example of 5.0, which uses iframe to display third-party pages.

Hi @lynn1286

What is the version if the adyen-web SDK that you are using?
Our component already shows the iframe embedded in the page as part of the 3DS2 flow. What is the flow you are experiencing to trigger redirect to another page? Can you explain that and maybe share a video / test cards / whatever other information to help us understand your problem.

Closing this issue for now. Feel free to reach out if you have more information to help us investigate this issue. Cheers


Follow CNAME and DNAME records

Hi @GrigoriyMikhalkin can you have a look at what I am trying here and tell me if this is a valid approach? (Following the CNAME redirection with recursive DNS lookups)
Im still a bit concerned if this works as intended; in a test I got a name with multiple CNAME redirections resolved even though there were more redirection levels than the TTL I built into the recursive lookup.
Also the code is at least somewhat ineffective: Usually the resolution of CNAME to A record comes in the same reply but this is currently ignored and a recursive DNS query vor the CNAME is done anyway.
So @chbmuc: I'd like to resolve these issues before I declare it ready for review.

I think this is ready to look at now. Couple thoughts though:

We probably should turn the logging down to a reasonable amount before releasing this though
I wonder if we could use a context to break the recursion once the redirection TTL has been reached; but I'm not sure where to get the context from.


 Change process key word from "X-Oss-Process" to "x-oss-process"

今天发现阿里云的Process部分的key从X-Oss-Process改成了x-oss-process。如果还是用之前的，虽然不会报错，但是process的效果不会体现到图片上。

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage decreased (-50.7%) to 40.567% when pulling adc7b7ef772e7a3d39b65ae46e86c126792f5855 on Adoni:fix_process_bug into 36bf7aa2f916f274137aedd05d1d36f6a3c0f4a6 on aliyun:master.


Remove persona specific endpoint and take persona in header

https://projects.engineering.redhat.com/browse/SSP-794
Since each login may have multiple personas, we introduced three persona specific endpoints for requests, namely
/admin/requests
/approver/requests
/requester/requests
However this causes problem for GraphQL query because the persona is not a built in attributes of requests. Now we decide to remove these endpoints and take the persona parameter from header. The mapping from old endpoint to new is as follows
/admin/requests -> /requests with header x-rh-persona=approval/admin
/approver/requests -> /requests with header x-rh-persona=approval/approver
/requester/requests -> /requests with header x-rh-persona=approval/requester
A request without header x-rh-persona is the same as approval/requester
A request with unknown x-rh-persona header gets return code 403
The persona header works with RBAC together. A mismatching of persona and RBAC role results in a return code 403.

@bzwei You might also want to mention that setting the person doesn't bypass the RBAC check, we still do the RBAC check before we pass back the data

@bzwei You might also want to mention that setting the person doesn't bypass the RBAC check, we still do the RBAC check before we pass back the data

Done


Mweb-IOU- In distance request money, the address suggessions are fetched in forced offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to https://staging.new.expensify.com/
Tap profile icon
3.Tap Preferences
4.Toggle on Forced offline
5.Navigate to LHN
6.Tap FAB
Tap request Money
8.Tap Distance
9.Tap Start
10.Enter few characters of an address
11.Turn off mobile data
12.Enter few characters of an address

Expected Result:
In distance request money, If we turn off mobile data, the address suggestions are not fetched.
Similarly, the address suggessions must not be fetched in forced offline.
Actual Result:
In distance request money, If we turn off mobile data, the address suggestions are not fetched.
But, the address suggessions are fetched in forced offline.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.64-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/5919ea9d-e393-4ba9-a27d-d4304567436c
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:@
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal
Please re-state the problem that we are trying to solve in this issue.
In distance request money, the address suggessions are fetched in forced offline
What is the root cause of that problem?
The AddressSearch component uses the Google Places Autocomplete module which fetches data from a different API URL.
What changes do you think we should make in order to solve the problem?
Update the AddressSearch component by conditionally setting the requestUrl to null when should force offline is enabled.
What alternative solutions did you explore? (Optional)
None.

The forced offline is mainly staging feature, I dont think this is a deploy blocker

I think this is similar - https://github.com/Expensify/App/issues/26478#issuecomment-1710654264 - asking

This issue is different so we need to get an external on this

Proposal
Please re-state the problem that we are trying to solve in this issue.
In distance request money, the address suggessions are fetched in forced offline
What is the root cause of that problem?
In forced offlined, we only prevent making API from the App repository. But we still can call the API from libraries. In this case
https://github.com/Expensify/react-native-google-places-autocomplete/blob/4324dd7b156075d1817fea60b007584fa73b08ea/GooglePlacesAutocomplete.js#L546-L552
We are making requests in react-native-google-places-autocomplete library. So that the API still can executed
What changes do you think we should make in order to solve the problem?
I suggest that we should pass isOffline props to GooglePlacesAutocomplete and in GooglePlacesAutocomplete we will prevent making API if  isOffline is true
In here
https://github.com/Expensify/react-native-google-places-autocomplete/blob/4324dd7b156075d1817fea60b007584fa73b08ea/GooglePlacesAutocomplete.js#L502C1-L502C1
we should update like this
if (supportedPlatform() && text && text.length >= props.minLength && !props.isOffline)

we're reviewing proposals

hey @allroundexperts can you let me know what you think of https://github.com/Expensify/App/issues/26869#issuecomment-1712443469

@nkuoch @allroundexperts My main PR is ready for review.
I have also created the dependency PR in the Google Places Autocomplete repo. There are currently no reviewers assigned, but it will require a review as well before merging.

@allroundexperts do we want to regression test for this?
Payouts due:
Issue Reporter: NA
Contributor: $500 + $250 bonus @akinwale (paid in Upwork)
Contributor+: $500 + $250 bonus @allroundexperts (paid in NewExpensify)
Eligible for 50% #urgency bonus? Y - https://github.com/Expensify/App/issues/26869#issuecomment-1725192165
Upwork job is here.

Sounds good! Thank you! I've paid this out.
Closing, feel free to reopen if needed!

$750 payment approved for @allroundexperts based on BZ summary.


(PE-37251) Remove hato as a hard dependency

project.clj dependencies were convoluted by having multiple profiles defining defaults, somehow this was bringing in hato as a hard dependency instead of a dev dependency. Defining just one defaults section solved the problem.

I'm a little confused as to why this works... I think pseudo-dev is just a profile someone came up with and not an actual leinegen profile?  and it seems like dev needs those dependencies for testing.  Wondering if we can just move all the dependencies from pseudo-dev to dev itself and eliminate the profile all together.

Meaning I don't understand how pseudo-dev is actually used with this setup.

https://cljdoc.org/d/leiningen/leiningen/2.9.8/doc/profiles

I'm a little confused as to why this works... I think pseudo-dev is just a profile someone came up with and not an actual leinigen profile? and it seems like dev needs those dependencies for testing. Wondering if we can just move all the dependencies from pseudo-dev to dev itself and eliminate the profile all together.

Yeah it's just made up for an unknown reason, the only use I see of it is that we run the lein tests with it instead of dev profile https://github.com/puppetlabs/trapperkeeper-webserver-jetty10/blob/f1b9e04c3a9ea4da59b0dd04675a8ce696260155/.github/workflows/lein-test.yaml#L38-L41 . I believe that was moved over from the old Travis testing.. is there any reason to do that or should we just combine them?

That makes sense.  We should likely update the actions to run on changes to project.clj too so we can make sure this works in CI as well.  Currently it only looks at changes in src and test:
https://github.com/puppetlabs/trapperkeeper-webserver-jetty10/blob/main/.github/workflows/lein-test.yaml#L8
https://github.com/puppetlabs/trapperkeeper-webserver-jetty10/blob/main/.github/workflows/lein-test.yaml#L11

👀 no idea why gh action can't find SimpleServlet now.

Try including "pseudo-dev" in "dev", as that will allow "dev" to have all the test dependencies too.

After realizing that pseudo-dev was being injected into dev anyway https://github.com/puppetlabs/trapperkeeper-webserver-jetty10/blob/main/project.clj#L86-L87 I don't think it's worth keeping around. I pushed an update that properly includes hato only as [hato "0.9.0" :scope "test"]. One mystery is I had to add redundant dependencies to fips profile, previous pseudo-dev dependencies. Looking at the old project.clj, I do not see how these were injected there before.
It is actually readable as is now so maybe this is now a good state.

https://cljdoc.org/d/leiningen/leiningen/2.9.8/doc/profiles#composite-profiles is relevant here, we were doing the unrecommended thing before in the dev profile "It is not recommended to make a composite profile which contains both keywords and maps; they should either be all keywords or all maps."

Both lein with-profile fips test and  lein with-profile dev test pass.

Fails locally for me the same way as the action run fails:
Retrieving org/bouncycastle/bcpkix-fips/1.0.7/bcpkix-fips-1.0.7.pom from central
Retrieving org/bouncycastle/bc-fips/<IP_ADDRESS>/bc-fips-<IP_ADDRESS>.pom from central
Retrieving org/bouncycastle/bctls-fips/1.0.17/bctls-fips-1.0.17.pom from central
Retrieving org/bouncycastle/bcpkix-fips/1.0.7/bcpkix-fips-1.0.7.jar from central
Retrieving org/bouncycastle/bc-fips/<IP_ADDRESS>/bc-fips-<IP_ADDRESS>.jar from central
Retrieving org/bouncycastle/bctls-fips/1.0.17/bctls-fips-1.0.17.jar from central
Compiling 4 source files to /Users/steveaxthelm/dev/trapperkeeper-webserver-jetty10/target/classes
Execution error (ClassNotFoundException) at java.net.URLClassLoader/findClass (URLClassLoader.java:445).
servlet.SimpleServlet

Full report at:
/var/folders/dh/ccmxd9mn1kggz9stfrm04vyh0000gn/T/clojure-18259160661095289899.edn
Subprocess failed (exit code: 1)
Error encountered performing task 'test' with profile(s): 'fips'
Subprocess failed (exit code: 1)


Poor grammar: "which is not time-bound and maybe over several days"

Second paragraph: "Between each turn of the conversation (which is not time-bound and maybe over several days), the stack is persisted."
I think you meant "may be" instead of "maybe." It might even be worthwhile to say "may span several days" instead.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6d405d76-b17a-dbe9-c2f2-734fa34b0e8b
Version Independent ID: 3acc3fa8-b98d-a5f1-8bea-e823c3efec14
Content: Dialogs within the Bot Builder SDK - Bot Service
Content Source: articles/v4sdk/bot-builder-concept-dialog.md
Product: bot-framework
GitHub Login: @johnataylor
Microsoft Alias: johtaylo

Fixed, will be in the next publish. Thank you!


Error 400: Missing parameter: Root Password., required

Can't find any variable for the root password in the PostgreSQL module.
Or is it related to some authentication issue with gcloud ?

Hi @ShibraAmin18
Can you paste your reproducible Terraform configuration without any sensitive values?

Hey @bharathkkb
I figured this was database_version value error. I used database_version  = "14" instead of database_version  = "POSTGRES_14" .
But don't know why it gives such an error Missing parameter: Root Password., required .
If it would have been a valid version error, I could have been updated earlier only.
Thanks.


Opinions about applying rustfmt

While I'm working on #39 I found a bit annoying that the code hasn't been formatted using rustfmt.
I can of course either

disable rustfmt when working on this codebase and manually format new code, or
write code with rustfmt but check in only non-stylistic changes

but neither is satisfactory. Are you happy to accept rustfmt changes? If so I'll make a PR.

Having a rustfmt PR sounds great to me!

Great, just made #42.


Handle deserialization of all integer and enum types

I think this should now achieve round-trip Rust type -> Dynamic -> Rust type for almost all cases. Before this most enum types won't be deserialized into.

This looks impressive!
I have a couple of comments into your code.
Also, will it serialize to enum ?  I see only a deserializer here...

Serialization of enum seems to be already working, but I haven't really tested in detail. Would need to add a few tests to be sure.

Hi, would you address my comments in the code?  Basically minor changes.  Then I'll merge it in.

I don't see any comments?

Up there...  I started a code review.  Can you see it?
How about this link: https://github.com/schungx/rhai/pull/16/files/03cc413d33013ab1e51e8dba73e45299a1b6dca1

It says "pending" so you probably haven't yet submitted them.

Ah.  :blush:

BTW, I am experimenting with a way for Engine::eval::<T>() calls to automatically deserialize to T with serde, but I don't want yet another full set of API methods.

I added some enum serialization tests and fix the actual serialization of some enums.

BTW, I am experimenting with a way for Engine::eval::<T>() calls to automatically deserialize to T with serde, but I don't want yet another full set of API methods.

This turns out not possible.  That's because a deserialized type may hold references to a Dynamic value which is the return value of eval.   So you need to keep both alive at the same time, meaning that it must be done in two steps.

Thanks!


Meal formula overhaul

Originally created by Tom Smyth at 2018-08-29 09:17, migrated from redmine-#8820

Not needed for now since customizable meal types is finished


Add After injection hook

Hello,
while trying this amazing project for UIKit, i found that it might be useful for some architecture to be able to attach a hook to be executed after the controller is reloaded, in the example i attach in the source-code, we rebind the controller to the presenter when it's re-created.

3alamy


Revert "Revert "[flutter_tools] remove mocks, globals from golden comparator and test runner tests""

Reverts flutter/flutter#81487

The cause of the failures was unrelated


Add a format command.

Please add a format command to hpack with an --inplace option to overwrite the package.yaml file.
hpack format --inplace

When using Dhall it's more likely that you get git conflicts when rebasing/merging (yes, commas again)
SOURCE: https://github.com/BlockScope/hpack-dhall/issues/3#issuecomment-418572726

If a format command was added to hpack then use of this command could help to reduce the chance of git conflicts when rebasing/merging.
Differences
I'm currently adding some real world golden tests for the executable dhall-hpack-yaml from package hpack-dhall, trying to generate output that matches hpack's package.yaml and stack's package.yaml. The kinds of differences I've seen between handwritten and generated package.yaml files are;

Indentation

dependencies:
- base >= 4.9 && < 5
- bytestring

dependencies:
  - base >= 4.9 && < 5
  - bytestring

Field order

category: Development
maintainer: Simon Hengel<EMAIL_ADDRESS>extra-source-files: CHANGELOG.md
github: sol/hpack

maintainer: Simon Hengel<EMAIL_ADDRESS>github: sol/hpack
category: Development
extra-source-files:
  - CHANGELOG.md

Single element lists

dependencies: hpack

dependencies:
    - hpack

Empty lines

executable:
  source-dirs: driver
  dependencies: hpack
  main: Main.hs
tests:
  spec:

executable:
  main: Main.hs
  source-dirs: driver
  dependencies:
    - hpack

tests:
  spec:

Version numbers

name: stack
version: ! '''1.10.0'''

name: stack
version: '1.10.0'

name: hpack
version: 0.31.1

Hey! Thanks for opening this issue!
I think this can be provided as a third-party executable.  Please feel free to do so.
Regarding adding this to hpack itself: Unless somebody can make the case on how this benefits hpack users at large, I'm not inclined to do so.

In the past I've used a separate YAML pretty printer for this and it's worked fine.

I look for fields like name and version at the head of a package.yaml file or .cabal files and expect to find exposed-modules before other-modules and library before test-suite.  This is the order fields are listed in the top-level table and other tables in the hpack docs.
I have implemented a sorting of sorts for hpack field names following the hpack docs.
Can you please consider exposing a field name comparison function in hpack itself as a lesser suggestion?

@philderbeast for your specific used case, one thing I that could be worth trying is reading package.yaml into a Value and then compare it based on that.
I'm closing this issue, but please, if you need any changes to hpacks API, please bring them up and I'm open to discuss (no promises).

@tfausak, what separate yaml pretty printer do you use? We use the imported anchor features pretty extensively in our package.yaml files. This messes up every single yaml formatter I've tried.
Here's an example of an error with prettier, but this is basically what I get with any of the other formatters:
$ prettier package.yaml
package.yaml
[error] package.yaml: SyntaxError: Aliased anchor not found: defaults (5:5)
[error] > 5 | <<: *defaults
[error]     |     ^^^^^^^^^

I use yq, which I think should handle that.


⚠ Turnos 24x7 has degraded performance

In 41374d3, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1026 ms

Resolved: Turnos 24x7 performance has improved in 03939ed.


[REQ] Choosing the file directory for downloads without needing to open up the file manager every time.

Describe the problem that needs solving
I have a pretty organized file system on my phone and I really hate having to go and open the file manager every time I download an image.
Describe the solution you'd like
Let people save what directory that they would like to have the download be in automatically without needing the files app to be open to save them each time a new image is saved.

yeah it can be annoying sometimes


continue NOT pass in loop (derp)

not filtering already subbed communities!

If I understood what this issue is about correctly, I don't think there's a bug. It should filter. The community is only added to local_community_id_list if its not subscribed to. Writing continue instead of pass here won't make any difference there, as that conditional is the whole body of the loop.
You probably should rewrite the condition to make it easier to read:
for community in actor_resp.json()['communities']:
    if community['subscribed'] != 'Subscribed':
        local_community_id_list.append(community['community']['id'])

If I understood what this issue is about correctly, I don't think there's a bug. It should filter. The community is only added to local_community_id_list if its not subscribed to. Writing continue instead of pass here won't make any difference there, as that conditional is the whole body of the loop.
You probably should rewrite the condition to make it easier to read:
for community in actor_resp.json()['communities']:
    if community['subscribed'] != 'Subscribed':
        local_community_id_list.append(community['community']['id'])

(Or something similar if you want to change behavior to e.g. "only unsubscribed" - the snippet above matches the current logic)

PR? :) It's nice getting to say that for a change. No pressure. I am open to all sorts of changes and refactoring. Uber-dev I am not.


Adding parabolic terms for P4estMesh{3}

@apey236 FYI you can queue up all changes by looking at the "Files Changed" tab at the top of this PR.

@ranocha can you please review the changes. I applied your requested changes.

The CI failures are same as https://github.com/trixi-framework/Trixi.jl/pull/1582#issuecomment-1646819161 and are unrelated to this PR. @ranocha can we force merge this?

The CI failures should be fixed with https://github.com/trixi-framework/Trixi.jl/pull/1586

Since we don't have a merge queue and I would like to get a new release just including recent bug fixes, I disabled auto-merge for now. I will take care of this PR and merge it today. Please ping me if I forget to do so.


How to Upgrade version R4 to R5 of existing open source fhir server

Describe the bug
I want to upgrade the version to R5 from R4.
FHIR Version?
Stu3/R4/R5
Data provider?
SQL Server
To Reproduce
Want to upgrade the
Expected behavior
A clear and concise description of what you expected to happen.
Actual behavior
A clear and concise description of what actually happened.

@abhishek14anandDev - We don't have a way to upgrade from one FHIR version to another. We haven't started looking at this yet. I'll leave this open as a user story but this isn't a bug, more of a feature request.
@ranvijaykumar FYI

okay, My problem is, _typeFilter was not supporting in earlier builds but now it is supporting. and i want to update my open source fhir server with current builds.
Please let me know how to do that.

@CaitlinV39  your reply would help me to decide. requesting you to reply on this

I believe this is a duplicate of https://github.com/microsoft/fhir-server/issues/2483


False positive: FunctionalInterfaceClash after adding default method to the interface

After this change: [1] we are seeing FunctionalInterfaceClash error flagged by error prone:
[0 / 280] [Prepa] Writing file lib/polymer_externs/polymer_closure_worker_input
[380 / 776] Action external/bazel_tools/tools/jdk/platformclasspath.jar [for host]; 3s remote-cache ... (16 actions, 15 running)
[1,354 / 2,362] Action external/bazel_tools/tools/jdk/platformclasspath.jar [for host]; 9s remote-cache ... (9 actions, 4 running)
[1,376 / 2,362] Action external/bazel_tools/tools/jdk/platformclasspath.jar [for host]; 15s remote-cache ... (29 actions running)
[1,601 / 2,362] Bundle polygerrit-ui/app/bazel-out/k8-fastbuild/bin/polygerrit-ui/app/gr-app.html.bundled.html; 16s local ... (21 actions, 20 running)
ERROR: /home/jenkins/workspace/Gerrit-verifier-bazel/gerrit/java/com/google/gerrit/lifecycle/BUILD:3:1: Building java/com/google/gerrit/lifecycle/liblifecycle.jar (2 source files) failed (Exit 1)
java/com/google/gerrit/lifecycle/LifecycleManager.java:45: error: [FunctionalInterfaceClash] When passing lambda arguments to this function, callers will need a cast to disambiguate with: add(LifecycleListener)
  public void add(RegistrationHandle handle) {
              ^
    (see https://errorprone.info/bugpattern/FunctionalInterfaceClash)
INFO: Elapsed time: 61.965s, Critical Path: 27.41s
INFO: 1032 processes: 994 remote cache hit, 38 local.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/272812
[2] https://gerrit-review.googlesource.com/c/gerrit/+/272833

Isn't this the expected behavior of the check?  Both of the interfaces mentioned here have a single method which has no parameters and returns void, therefore in case of a lambda the interface is ambiguous and the cast is needed.
Maybe we can "fix" this by adding @SuppressWarnings("FunctionalInterfaceClash") or just demoting the check to WARN?
I assume that if any such ambiguous situation arises, the compiler will complain.

Yes you are right. I was confused by the fact, that the problem only showed up, after turning the second method in LifecycleListener to default:
public interface LifecycleListener extends EventListener { |
  /** Invoked when the server is starting. */
  void start();
  /** Invoked when the server is stopping. */
  // turnning this method to "default" caused error prone to flag the FunctionalInterfaceClash check
  // on LifecycleManager#add(RegistrationHandle) method, see below
  default void stop() {}
}

Even though, the RegistrationHandle defined as:
public interface RegistrationHandle {
  /** Delete this registration. */
  void remove();
}

However the problem is that both add methods in LifecycleManager have argument with one songle method with the same signature :
/** Tracks and executes registered {@link LifecycleListener}s. */
public class LifecycleManager {
 /**
   * Add a handle that must be cleared during stop.
   *
   * @param handle the handle to add.
   */
  public void add(RegistrationHandle handle) {
    handles.add(handle);
  }

  /**
   * Add a single listener.
   *
   * @param listener the listener to add.
   */
  public void add(LifecycleListener listener) {
    listeners.add(Providers.of(listener));
  }

[...]

So, the problem is, that we were just lucky, that we have not had the collision from the beginning. If LifecycleListener would just have one single method: start() we would have the potential collision from the first time we migrated to Bazel or activation of  FunctionalInterfaceClash  bug pattern.
To disambiguate, we could rename the methods in LifecycleManager from just add to addHandle:
 /**
   * Add a handle that must be cleared during stop.
   *
   * @param handle the handle to add.
   */
  public void addHandle(RegistrationHandle handle) {
    handles.add(handle);
  }

  /**
   * Add a single listener.
   *
   * @param listener the listener to add.
   */
  public void add(LifecycleListener listener) {
    listeners.add(Providers.of(listener));
  }

Unfortunately, caller places would have to be adjusted, also in plugins. However, we should be able do that on master anyway?

I think we should try to engineer a situation where this clash will occur, so we can see how it can be fixed without changing the interfaces.  If it can be solved by using casts as mentioned in the warning message, I think that would be fine.  Then we can just leave this check at WARN severity.

I think we should try to engineer a situation where this clash will occur [...]

This check is only preventing hypothetical situations that may never happen, but could happen.
However, I don't like the idee about demoting the check from error to warning. If we think that the check is not helpful, than it should be rather switched off entirly. Or, if enabled it must be left in error severity and the code must be fixed to be FunctionalInterfaceClash free.
As suggested, if we rename add(RegistrationHandle handle) to addHandle(RegistrationHandle handle) we are done. I coul restore my change to change abstract stop() method to default method with empty body.


Update 'Documentation' : Add listcommand related documentation

Codecov Report

Merging #89 (2e6f7a6) into master (1d21699) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #89   +/-   ##
=========================================
  Coverage     58.82%   58.82%
  Complexity      553      553
=========================================
  Files           110      110
  Lines          2159     2159
  Branches        203      203
=========================================
  Hits           1270     1270
  Misses          808      808
  Partials         81       81

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d21699...2e6f7a6. Read the comment docs.


Datepicker inside a modal window causes modal to close

Hey,
I have an issue in my app, i have 2 inputs in which i'm getting the values of your datepickers but when i pick a date too quickly and then try to click on the other input field then it causes my current modal to close itself.
I've checked online for a quick fix but nothing seems to match my current problem. Maybe adding some setTimeOut on the Ok button validation will fix the problem but that is not the best way to handle things in my opinion.
Looking forward to hear if you got the same problem at some point

Hi Gaultier,
could you please make up a codepen/plnkr/jsbin demonstrating your problem? Thanks!

Here's the problem.
I know its not only about your dateTimePicker but its the same bug.
So it directly affect your work.
http://codepen.io/anon/pen/KrxRXx
--- instruction :
open a modal -> open an alert/popup -> close and QUICKLY click anywhere on the modal.
It will cause the modal to close itself too.

Yes that is exactly the bug that i'm having actually ! I ve also just seen your latest issue posted on the ionic framework and it doesnt seem to have a fix for it just yet. But yeah it would be nice if we could find a solution all together because this is happening with all popups/alert/confirm.

Thanks!
The bug lays in ionic. AFAIK their backdrops are separate entities and clicking on a backdrop closes the topmost entity. When the popup is being hidden, the backdrop already knows that the topmost entity is now the modal, but the backdrop is still clickable until its animation ends. When the backdrop is clicked in such situation, the modal is closed, because backdrop service doesn't know that the backdrop is being hidden and shouldn't be clickable.
You can watch and :+1: driftyco/ionic#5869 issue that should solve that. Workaround for now is to set backdropClickToClose: false in modal options object.
I'm going to close this issue as the problem lays in framework code and workaround exists.

@katemihalikova  is there any other workaround? setting enableBackdropDismiss: false (this is the new version of backdropClickToClose) did not work for me.  I even set showBackdrop: false and the modal still gets dismissed.

Ionic 1.3.1 still uses backdropClickToClose. Ionic 2 is not supported by this plugin, but I can look into it if you are able to prepare a codepen/plnkr/jsbin/whatever with the problem.


Could not find the requested service alertmanager-9093.service: host

TASK [start alertmanager by systemd] **************************************************************************************************************************************
fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "msg": "Could not find the requested service alertmanager-9093.service: host"}
to retry, use: --limit @/root/tidb-ansible/retry_files/start.retry
PLAY RECAP ****************************************************************************************************************************************************************
<IP_ADDRESS>                  : ok=15   changed=0    unreachable=0    failed=1
<IP_ADDRESS>             : ok=14   changed=0    unreachable=0    failed=0
<IP_ADDRESS>             : ok=14   changed=0    unreachable=0    failed=0
TiKV1                      : ok=10   changed=0    unreachable=0    failed=0
ERROR MESSAGE SUMMARY *****************************************************************************************************************************************************
[<IP_ADDRESS>]: Ansible FAILED! => playbook: start.yml; TASK: start alertmanager by systemd; message: {"changed": false, "msg": "Could not find the requested service alertmanager-9093.service: host"}
Ask for help:
Contact us<EMAIL_ADDRESS>It seems that you encounter some problems. You can send an email to the above email address, attached with the tidb-ansible/inventory.ini and tidb-ansible/log/ansible.log files and the error message, or new issue on https://github.com/pingcap/tidb-ansible/issues. We'll try our best to help you deploy a TiDB cluster. Thanks. :-)

When I execute to ansible-playbook start.yml this error occurs, and the solution has not been found yet, I currently have three servers to deploy the tests, running DB, PD, and KV respectively. Then this is my configuration
## TiDB Cluster Part
[tidb_servers]
<IP_ADDRESS>

[tikv_servers]
TiKV1 ansible_host=<IP_ADDRESS> deploy_dir=/data1/deploy labels="host=tikv1"

[pd_servers]
<IP_ADDRESS>

[spark_master]

[spark_slaves]

## Monitoring Part
# prometheus and pushgateway servers
[monitoring_servers]
<IP_ADDRESS>

[grafana_servers]
<IP_ADDRESS>

# node_exporter and blackbox_exporter servers
[monitored_servers]
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS>

[alertmanager_servers]
<IP_ADDRESS>

Hi, have you ever run ansible-playbook deploy.yml? And you should not use <IP_ADDRESS>, other nodes can not connect it.

The ʻansible-playbook deploy.yml` has been run and it has run successfully. I have replaced <IP_ADDRESS> with private IP, but I still get the following error.
TASK [Check grafana API Key file existed] **********************************************************************************************************************************************************************
fatal: [<IP_ADDRESS>]: FAILED! => {"changed": false, "msg": "Access Denied"}
	to retry, use: --limit @/root/tidb-ansible/retry_files/start.retry

PLAY RECAP *****************************************************************************************************************************************************************************************************
<IP_ADDRESS>            : ok=14   changed=0    unreachable=0    failed=0
<IP_ADDRESS>            : ok=29   changed=0    unreachable=0    failed=1
<IP_ADDRESS>             : ok=16   changed=0    unreachable=0    failed=0
TiKV1                      : ok=14   changed=0    unreachable=0    failed=0
localhost                  : ok=1    changed=0    unreachable=0    failed=0

ERROR MESSAGE SUMMARY ******************************************************************************************************************************************************************************************
[<IP_ADDRESS>]: Ansible FAILED! => playbook: start.yml; TASK: Check grafana API Key file existed; message: {"changed": false, "msg": "Access Denied"}

permission error: You should put tidb-ansible in /home/tidb refer to https://github.com/pingcap/docs/blob/master/op-guide/ansible-deployment.md, and change file owner of tidb-ansible to tidb.

Oh, thank you very much. My problem is solved. I'm sorry that I didn't read the document carefully.


Fix to support any lines

I did a forEarch to remove block of max 2 lines.

Thank you for the contribution

I guess this would fix #11


ONNX models

Hello!
I have a Flutter project called FONNX that can run ONNX models on platforms. https://github.com/Telosnex/fonnx
Sometimes I search HuggingFace for the lastest models mentioning ONNX. https://huggingface.co/models?sort=modified&search=onnx
I saw you had a couple LLM ONNX models that look correct in Netron, for example, Tiny Mistral. https://huggingface.co/Felladrin/onnx-TinyMistral-248M
But I also noticed you're not using them in this repo yet: Do they work? I'd love to add one to FONNX.
Thanks for your time,
James O'Leary

Hi, @jpohhhh!
Thanks for your interest! And Great work with FONNX!
I'd say those ONNX work only for very specific purposes (e.g. story generation). But I'm yet to find a text-generation model that is on par with the text2text-generation MBZUAI/LaMini-Flan-T5-248M.
Until now, none of the <1B text-generation models gave a decent response for large prompts like the ones used in MiniSearch (which are around 512 tokens, due to the inclusion of the 6 web search results inputs).
But I saw the interest in small models growing recently, so maybe we're close to seeing something good! I have high hopes for fine-tunes of ahxt/llama2_xs_460M_experimental and Locutusque/TinyMistral-248M.

In https://github.com/felladrin/MiniSearch/pull/128, MiniSearch started using a text-generation model 🎉


[misc] Standardizes the logs.json format

to: @airbnb/streamalert-maintainers
cc: @chunyong-lin
size: small
resolves #???
Background
https://jira.airbnb.biz/browse/CSIRT-368
Changes

The conf/logs.json now is to be sorted alphabetically by schema key. This commit sorts it.
A unit test has been added that ensures the conf/logs.json is sorted properly.
A new script has been added that sorts the schema file, runnable with $ python test/scripts/sort_configs.py

Testing

Coverage remained the same at 97.312% when pulling e91909cb676f8ce90743ac038f7195d8dc923b79 on derek--ordered-json into d1c618cf8189e726aa76d901fbf32785f68f0c4b on master.

 I accidentally merged it without actually committing my fixup...