Memory Leak, Crashing HA | Synology Camera Component

Home Assistant release with the issue: .91.0

Last working Home Assistant release (if known): Unknown. Been going on for a year at least
Operating environment (Hass.io/Docker/Windows/etc.):

arch
x86_64

dev
false

docker
false

hassio
false

os_name
Linux

python_version
3.7.2

timezone
US/Eastern

version
0.90.2

virtualenv
true

Component/platform:

Synology Camera
https://www.home-assistant.io/components/camera.synology/
Description of problem:
Gradual memory leak until HA stops responding. Have to Stop/Start HA service to recover. 2gigs of memory in ~6 hour period.
5 minute snapshot:
(homeassistant) homeassistant@ha:/srv/homeassistant$ top
top - 07:53:45 up 3 days, 23:17,  1 user,  load average: 0.00, 0.02, 0.04
Tasks:  95 total,   1 running,  93 sleeping,   0 stopped,   1 zombie
%Cpu(s):  0.2 us,  0.2 sy,  0.0 ni, 99.2 id,  0.5 wa,  0.0 hi,  0.0 si,  0.0 st
KiB Mem :  2052336 total,   831208 free,   163908 used,  1057220 buff/cache
KiB Swap:  2094076 total,  2094076 free,        0 used.  1714160 avail Mem
PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     TIME+ COMMAND
1301 root      20   0       0      0      0 S   0.3  0.0   0:04.67 kworker/1:2
7589 homeass+  20   0 1504388 120216  18908 S   0.3  5.9   0:21.24 hass
(homeassistant) homeassistant@ha:/srv/homeassistant$
(homeassistant) homeassistant@ha:/srv/homeassistant$
(homeassistant) homeassistant@ha:/srv/homeassistant$ free -h
total        used        free      shared  buff/cache   available
Mem:           2.0G        159M        812M         10M        1.0G        1.6G
Swap:          2.0G          0B        2.0G
(homeassistant) homeassistant@ha:/srv/homeassistant$
(homeassistant) homeassistant@ha:/srv/homeassistant$ free -h
total        used        free      shared  buff/cache   available
Mem:           2.0G        163M        808M         10M        1.0G        1.6G
Swap:          2.0G          0B        2.0G
(homeassistant) homeassistant@ha:/srv/homeassistant$ top
top - 08:05:11 up 3 days, 23:28,  1 user,  load average: 0.00, 0.03, 0.01
Tasks:  95 total,   1 running,  93 sleeping,   0 stopped,   1 zombie
%Cpu(s):  0.5 us,  0.3 sy,  0.0 ni, 98.8 id,  0.0 wa,  0.0 hi,  0.3 si,  0.0 st
KiB Mem :  2052336 total,   827304 free,   167476 used,  1057556 buff/cache
KiB Swap:  2094076 total,  2094076 free,        0 used.  1710588 avail Mem
PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     TIME+ COMMAND
7589 homeass+  20   0 1504752 123260  18908 S   2.0  6.0   0:27.29 hass
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
camera:
  - platform: synology
    url: https://192.168.xxx.xxx:5001
    verify_ssl: false
    timeout: 15
    username: !secret synology_username
    password: !secret synology_password

Traceback (if applicable): N/A

Additional information:
TOP and Log file attached. Top is at the top of the file.
home-assistant.log

After further research this issue appears to be ongoing for well back into 2018 with no resolution. Question, will this resolved in a future update?

No one?

bueller, bueller

After disabling the feature and restarting HA memory usage went to normal levels. The memory usage drops to normal.

No takers?  Seems the developer for this feature is no longer as no one replied.  Further research shows this feature's memory leak has been going for better part of an entire year, if not longer.

Verry strange, I have no memory leaks at all

@WedHumpDay I experience the same issue with the Ring doorbell, when the camera is enabled. My memory grows from 300/400MB to 3GB (on 0.96.5). Did you ever solve it?

Never resolved.. Developer never looked into this nor responded.


ML recipes require updating for recent stack versions

These examples require updating for more recent versions of the stack as they are currently 5.x.
@richcollier @grabowskit Interested to hear your thoughts on how many versions we should keep alive. 5.x will differ from 6.3+ which will probably differ from 7.x.
Raised here https://discuss.elastic.co/t/how-to-get-xpack-running-for-detecting-dns-data-exfiltration/202962

I personally think that the recipes should be removed from the website and instead the "recipes" should be just whatever gets documented as the ML jobs for the SIEM app.

I personally think there are not enough ML recipe examples and that they should be updated asap to reflect the latest ECS version. (disclaimer I have a subscription for 10 nodes, one of which is a dedicated ml node). It requires time and dedication to set up ml jobs in the correct way so they are more or less future proof. All help in understanding use cases and different ml job configurations are imho more then welcome..


Fix README typos on .atom-text-editor

Really tiny but hope this helps. :P

Thanks for taking care of this, I must have been tired when I made the change ^^


How to understand "trusty"?

Where is the privacy protection?

We are preparing to release the Federated Face Recognition (https://arxiv.org/abs/2105.02501) code,


How can I allow dns for my namespace?

Hello!
I'm trying to allow access from all pods in namespace policy-demo to kube-dns, but can't.
What do I do wrong?
---
apiVersion: projectcalico.org/v3
kind: NetworkPolicy
metadata:
  name: allow-dns
  namespace: policy-demo
spec:
  types:
  - Egress
  egress:
  - action: Allow
    protocol: TCP
    destination:
      selector: k8s-app == 'kube-dns'
      namespaceSelector: ns == 'kube-system'
      ports:
      - 53

@azalio most DNS requests use UDP - you might want a rule to allow UDP port 53 as well.


gobgpd: use map for validation table

Table.destinations is a map, so the order changes.
This commit allows to get validate information from path by using map for validate table
Fix: https://github.com/osrg/gobgp/issues/2223
Signed-off-by: Toshiki Tsuchiya<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a4b688a). Click here to learn what that means.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##             master     #129   +/-   ##
=========================================
  Coverage          ?   38.09%
=========================================
  Files             ?       62
  Lines             ?    30748
  Branches          ?        0
=========================================
  Hits              ?    11712
  Misses            ?    17912
  Partials          ?     1124

Impacted Files
Coverage Δ

pkg/server/grpc_server.go
34.21% <50%> (ø)

pkg/server/server.go
40.25% <71.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b688a...543f50d. Read the comment docs.


Version 1.0 Epic

After about a year of active development, it's appropriate to give Timber a 1.0 release, why?

The API has stabilized. A minimum number of breaking changes have been introduced in the last few months, and of those the vast majority have been minor ones.
Test coverage exists over 50% of the code
Timber is in use by hundreds of sites
Other projects are now using Timber as the underlying layer for template
The GitHub and WP.org channels have solidified as the dev/distribution channels

However, before 1.0 there are several things that need to be completed

[x] Update Starter Theme with best practices (@ricwa230)

Consider moving starter theme's official home into its own repo, with linkage back to main Timber

[ ] Request the Timber page from the WP.org admins
[x] Launch new project homepage with updated logo
[x] Ensure that all classes have at least "medium" coverage (50%) (#264)
[x] Consider separating Routes into its own repo, with support in Timber (#273)
[x] Audit objects for universal use of magic methods, meta, id, name, title, slug (etc.) (#272)
[ ] Create a 1.0 upgrade guide noting deprecated functions/properties
[ ] Remove deprecated functions (#263)
[ ] Name Spacing of Timber classes Contributor wanted
[x] Reduce clutter of main Timber class, implement TimberPostGetter for getting stuff (#262)
[ ] Resolve Partial Inheritance Contributor wanted

Re:namespacing & autoloading: yes! Yes! Yes! :) This is also a good occasion to think about the problem of partial inheritance: make it easier to extend Timber objects, without having to extend the lot. Eg. if you want to extend TimberPost, but not TimberImage, you still have to extend TimberImage and set TimberImage::$post_class to 'MyTheme\Post', because otherwise you'll end up with an ordinary TimberPost instead of your own postclass when you call TimberImage::get_parent. @mgmartel on #161

[x] Implementation of WordPress coding standards (http://make.wordpress.org/core/handbook/coding-standards/php/) where appropriate.

[ ] Autoloading classes Contributor wanted

First of all, yes the autoloading. I of course use composer for dev dependencies, but I also use it for auto loading my own code. So first I had to figure out how to auto load Timber using composer. It wasn't so hard but it would be nice to be able to just pull it down with composer and just rock'n roll. Not having to configure the auto loading in the composer.json manually. @ricwa230 #161

[ ] Review global vars and functions Contributor wanted

I work hard to get rid of all global vars/functions and hideous name spacing. By encapsulating everything in a singelton class for my theme. Then it feels little sad the Timber is written so that it creates global stuff, but I understand why. @ricwa230 #161

[ ] Figure out a better way to manage context objects (#261)
[x] Examine Parent/Child theme twig inheritance Contributor wanted

It's impossible to override twig-templates in child themes. Maybe it's a bug that have been fixed. But last time I did a Parent-Child theme I had to do it. @ricwa203 #161
@jaredNova: This should be good and I've worked lots with parent/child twigs to success. That said, it'd be great to understand how users expect this to flow so we can write docs and tests around those expectations

[ ] Examine and document widget rendering Contributor wanted
It keeps coming up like in the comment below:

You can also see that I specify a second folder for widget views. That's how I utilize Timber for custom widgets. Then I have a base class for all my Timber based plugins that uses this second template dir to render widgets and widget forms using Timber::render(). How this should be done is not covered in the starter theme either. It would be great with some plugin best practice and example classes that use Timber to render widgets. @ricwa203 #161

[ ] Solidify best practices

Make it more opinionated and teach the WP community to embrace MVC and true OOP. I think this at least should be the case for the code you/we write. All the rest of the WP code we can't do so much about, but with some best practice it will suck a lot less! ;-) Any thoughts about providing some base classes for themes and widgets? @ricwa203 #161

From this I'm going to spin-off issues from this document, but limit additional items. I've noted Contributor wanted labels above on the most-important items that I want volunteers to contribute their expertise on. My goal is to release a 1.0 within 60 days (Aug 12, 2014).
Please respond in the comments with refinements on the items above or if you want to volunteer for specific items (from which, I'll spin into an issue with more clarity). Let's keep general discussion on #161

[ ] Publish docs
[ ] >80% test coverage
[ ] >80% doc coverage

A changelog in this repo would also be nice, or at least a pointer to where it can be found. Or I'm just stupid and can't find it :wink:

This will become active again in the next few weeks as we work towards 1.0 release.

Should you not change TimberPost to \Timber\Post in PostGetter.php

@jarednova Besides doing web development, I'm a writer too: I'll gladly write a full-on tutorial on using Timber for web designers and front-end developers that are struggling to build websites with WP.
I love Timber: it's the only thing that's keeping me in the WP development world.

The more the merrier @ivanjuras - pinging @jarednova as he may have more input on any areas that need covering more

I'm going to close this as 1.0.0 has been released and we will just leave it if we don't close it now.


fix: do not ignore error of url.Parse

If the error is ignored, there will be a nil pinter dereference panic when accessing u.Scheme.

Hi @j178, good catch and thank you for the test case!


Collatz conjecture infinite loop

Hi all, this is my collatz conjecture code, why does it result in an endless loop?

I think you will have to reassign the old logger to the new logger. Try this instead
logger = logger.test(x -> x % 2 == 0, logger.map(x -> x/2), logger.map(x -> x *3 + 1));


Version 3.0.13

Landed in https://github.com/metarhia/impress/commit/691d5ce9c0b84545c4b86a29174334ea4c290f07, https://github.com/metarhia/impress/commit/49347e4bdecb116fe6e0e0f6309ec9f89ffc32f8, and https://github.com/metarhia/impress/commit/81cd9c2bc60fe953e0c39544830fe3dd46453320


feat: extend a linearly independent family to a basis contained in a set spanning the space

If s is a family of linearly independent vectors contained in a set t spanning V, extendLe is a basis of V containing s and contained in t.
Specialize it for the case where s is empty.

bors r+
Thanks!


fix: Added Curl in the Docker-container so users can create healthchecks

:tada: This PR is included in version 2.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fix various typos

Found via codespell -q 3 -L inout,invokation,lod

Thanks for the PR @luzpaz . It is highly appreciated.


event_sync: add support for breakout rooms

Fixes https://github.com/jitsi-contrib/prosody-plugins/issues/14
@damencho May I trouble you for a review when you have a moment to spare? Thanks :)

👍

Can you please update Readme, dropping the she that is around the occupant.

Thanks 👍

:)

Thanks for reviewing 🙇


problems with use enter to create a tag

hi, I was creating a form with the typical, an input text and a submit button. all in html tag form. the problem was that when you apply the class in jquery to the input and use the enter button to add the tag, instead of entering it, activate the submit button. this only happens when the elements are inside the  html tag form. please fix this, I do not know much about programming. Thank you

Hi
So it is happening when it is inside form tag? Let me check the issue at my side.
It will be better if you can show some part of your code to identify the real issue.
Thank you.

If you don't have textarea in your form you can use
<form onkeypress="return event.keyCode != 13;">

hi!
in mobile not working creating tabs, there is no enter key to activate the plugin by default the enter key changes to next https://developerweb.cl/registro_chef.html

please help !!!


Update mongodb-driver-core to 4.3.0

Updates org.mongodb:mongodb-driver-core from 4.2.3 to 4.3.0.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (4.2.3).
You might want to review and update them manually.
CHANGELOG.md

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.mongodb", artifactId = "mongodb-driver-core" } ]

labels: library-update, semver-minor, old-version-remains

https://github.com/mongodb/mongo-java-driver/releases/tag/r4.3.0


LB Rules and Templates response as {} when not set

Conclusion
When LB Rules and Templates are not set, it response as {}.
It will crash on editsettings page.

fixed https://github.com/leap-solutions-asia/auto-scaling/pull/27


Investigate mysterious SGE error on ITC cluster

The jobs @boom10899 is running on ITC occasionally hang with the following mysterious error:
execution daemon on host XXX didn't accept task

Is this a problem with our application or a problem in SGE?
https://stackoverflow.com/questions/14775451/submitting-open-mpi-jobs-to-sge

From previous job script, the script wrote the host name into "host.txt". When we submitted multi job into the queue, every job will write the host list into the same file that make other jobs access the unauthorized hosts. We solved the problem with generate a temporary file for writing the host list.
#$ -S /bin/bash
#$ -q grid_short.q
#$ -pe mpi 792

module load compiler/intel/2018/1.038
module load mpi/intel/2018

export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/opt/intel/parallel_studio_xe/itac/2018.1.017/intel64/slib/libVT.so

HOST=`mktemp`
cut -d ' ' -f 1 $PE_HOSTFILE > $HOST

echo "========== Allocated hosts:"
mpirun -hostfile $HOST -ppn 1 -n 33 hostname

echo "========== Trace_Normo_133105.csv"
mpirun -trace -hostfile $HOST -ppn 1 -n 33 ./cuEDM/build/simplex_mpi_bench data/Trace_Normo_133105.csv
echo "=========="

rm -f $HOST


Add AutoLoadGame from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of allista, to add AutoLoadGame to CKAN.
Mod details:
name = /mod/832/AutoLoadGame
author = allista
abstract = Simple KSP plugin that automatically loads the specified savegame upon game start.
license = MIT
Homepage = https://github.com/allista/AutoLoadGame
description = # AutoLoadGame
Simple KSP plugin that automatically loads the specified savegame upon game start.
To use it, create or edit the AutoLoadGame.conf file in your saves directory and put the following two options there:
    game = YouGameFolder
    save = savegame

The savegame name may be a filename of any file.sfs under YouGameFolder, but it should be given WITHOUT the extension. For example, use:
    game = default
    save = persistent

to automatically load your default game in the state you'v left it.
Please direct questions about this pull request to allista.

#rebuild

Nice and simple. merging.


Retrieve saved image path after saving to Gallery

Did you check the documentation and it did not help?

[X] I have carefully read the README
[X] I have carefully searched the existing documentation
[X] I have carefully searched the existing answer
[X] I have carefully read the contribution guide

Proposal
Hi. Great project! Currenty putImage and putImageBytes both return void after saving the image to gallery. I would like for the function to return the saved image path. I saw similar issue #203 but had no idea it was marked as completed, apologize if there is already a discussion that I may overlooked.
Use case
I would like my app to have function to open image directly quickly after saving.

Hi @iqfareez . Thanks for your contribution🤝
First, there are some limitations depending on the platform.

iOS/macOS does not allow us to get the direct file path of a media file, so you have to get the local URL e.g. file:///var/mobile/Media/DCIM/118APPLE/IMG_8371.MOV. In addition, this is not possible with NSPhotoLibraryAddUsageDescription, which would require additional permissions.

file paths and URLs cannot be used permanently as they can be changed by the system or the user.

changes to media files should always be made via the platform's API and should not be changed or deleted directly using the path.

I would like my app to have function to open image directly quickly after saving.

Does this mean opening the Gallery app?  If not, the easiest way seems to be to display the images using the path to the temporary directory used to store the files.
final imagePath = '${Directory.systemTemp.path}/image.jpg';
await Dio().download('$url',imagePath);
await Gal.putImage(imagePath);
// Open imagePath //

If you tell me more about your Use Case, I may be able to suggest a better way.

Hi, I do have a usecase. I am building a share to instagram story functionality and on Android it's limited, it requires passing a file from MediaStore instead of the app's cache.
I am using Gal for a different functionality, so it would be great to be able to use the same one here


Filter condition is not broadcasted

Fixes #963

Thx for this PR! We are a bit busy this weekend, I'll have a look next week.

Hi,
I think this PR only fixes the case of filtering a matrix with a condition that should be broadcast along the column axis; it does not really broadcast the condition to the shape of the filtered array whatever his shape is.
It would be better to fix the filter function itself and not introduce particular case in the API.


privacy setting

hi, great library, works perfectly, however im not sure if this is vimeo upload or vimeo not applying global settings. When I set privacy to true it applies it but it sets the video to "me only" and not "hide from vimeo". Is there a way to set this? I did not see these options in the vimeo api docs.
Thanks for the great work
W

It's not an option currently in the API, but you can use my PR #17 if you need to set a custom privacy setting.

cheers jehartzog, the vimeo api setting are a bit ambiguous but i fixed this in the end by changing "nobody" to "disabled" ("unlisted" did not work and broke it)which is the equivalent of hiding on vimeo. Thanks for pointing me in the right direction.
W


cargo fmt formats all crates in a workspace by default

I would much prefer it behave like cargo build, where it only operates on the crate in the current directory unless told otherwise.

I'd be happy to try to fix this one if folks agree with my preference.

Yeah, following cargo build seems like the correct behaviour here (though of course running in the root of the workspace should still format the whole workspace, just like cargo build does).

I'd be happy to try to fix this one if folks agree with my preference.

That would be awesome, thank you!

just like cargo build does

Note that cargo build behavior is actually pretty nuanced these days. The flags which affect which crates are built are --package , --all and --exclude. Additionally, default_members attribute of a virtual root Cargo.toml manifests affects behavior in the root of the workspace. And, if the root of the workspace is not virtual, than only the root is built, and not the whole workspace.
So, yeah, basically most custom subcommands should accept --all, --exclude and --package flags, and behave like build-in commands, but there's no easy way to achieve that behavior in custom sub commands, except by replicating parts of Cargo behavior :-(

Should I move this issue over to rustfmt-bin?

Should I move this issue over to rustfmt-bin?

No, I'm not sure what the future will be like for rustfmt-bin, so we'll continue tracking issues here for a while.

This issue was fixed by https://github.com/rust-lang-nursery/rustfmt/pull/2513

Closed via #2513.

This was re-reverted later by https://github.com/rust-lang/rustfmt/pull/3652, can be re-open this?

@eoger would you open a new issue with your corresponding rustfmt version and other relevant details? At least with rustfmt 1.4.13 cargo fmt is operating as described/requested in this issue.


Legacy BLE and >= SDK 21 BLE

I have an app that currently works with BLE on < Lollipop devices. When I do the startLeScan with no UUID array it finds my BLE device just fine. If I pass the same service ID for that device into the startLeScan it doesn't find it.
This same thing works fine on a < Lollipop device. Should this work? I am asking you because you have your new Lollipop version of the BLE in your example and thought you would know.

AOSP may be able to help in the matter:
https://android.googlesource.com/platform/frameworks/base/+/android-5.0.2_r1/core/java/android/bluetooth/BluetoothAdapter.java
If you take a look at how they've mapped startLeScan() (line ~1656)to used the new APIs underneath, you can see that when an array of UUIDs is passed to the method, they map that into the new ScanFilter API. However, it seems they only take the first element, so if you were passing multiple UUIDs before it looks like anything but the first will be dropped.
If you are only passing one UUID, then it should work (and does work in the testing I have done). The callback does also doe a secondary match between detected UUIDs and the original array, so if a mismatch occurs there with the new APIs, the scan results would be dropped as well.
Hope that helps.


Update _quarto.yml

Hi @Zahedasghar
You must update the link in your github repo (https://github.com/Zahedasghar/quarto-course-website-template) not on this repo
Thanks

Dear Pakillo,
I am extremely sorry for inconvenience as I am not good at it and probably
made a mistake. My apologies but your repository now seems awesome to me
and will help me a lot in future for my teaching and conducting workshops
as well. I try to do the needful if I get it.
Best regards
Zahid
On Sat, Jan 28, 2023 at 4:43 PM Francisco Rodriguez-Sanchez <
@.***> wrote:

Closed #2
https://github.com/Pakillo/quarto-course-website-template/pull/2.
—
Reply to this email directly, view it on GitHub
https://github.com/Pakillo/quarto-course-website-template/pull/2#event-8379632848,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXP2QJBMGH65C2YLSBYYHITWUUA4XANCNFSM6AAAAAAUGTIMEY
.
You are receiving this because you were mentioned.Message ID:
<Pakillo/quarto-course-website-template/pull/2/issue_event/8379632848@
github.com>

--
Prof. Dr. Zahid Asghar
School of Economics
Quaid-i-Azam University, Islamabad

Hi Zahid
Don't worry, no problem at all!
I just made the required change in your github fork. If you merge the pull request I just made in your repo, it should all be working for you I think


[feature request] Bring back the ability to see trade routing without needing to bring up the modal

Is your feature request related to a problem? Please describe.
A recent UI update moved the trade routing visual to the transaction modal, which is not accessible if you do not have enough tokens in your wallet.

the trade routing visual:

Describe the solution you'd like
I think the trade routing should be listed on the trade screen without needing to click the preview button, since it cannot be done unless you have the tokens in your wallet.  This is how it was not too long ago and beethovenx has it how I would like it

Describe alternatives you've considered
If you inspect the preview button and delete the disabled attribute on the preview button, you can force open the modal and see the trade routing.  I don't feel like I should have to do this though.
Additional context
Seeing trade routing is important for debugging issues and analyzing how the SOR practically routes certain trades through available balancer pools.  I think putting this feature into the modal has removed a lot of utility of the feature.
Curious as to how others feel about this.

@mikebmikeb this is possible now but it's kind of an advanced hidden feature. Just set a local storage variable in your browser alwaysShowRoutes to true.


Misc improvements

Reduce visibility of uninitialized blocks in manifest_log.
Work around a miscompilation in manifest_log_fuzz.
Use test/priority_queue instead of std.PriorityQueue.
Use fuzz.random_int_exponential instead of manual casts.

bors r+


Fix CLI template option

Hey, firstly thanks for making Solito!
I was checking out the new tailwind template and ran
npx create-solito-app@latest my-solito-app -t with-tailwind
It ended up cloning the blank template instead 👀
I checked and it seems two things were going on:
1- Template option not passed to downloadAndExtractExample()
2- The short version of the flag is not parsed by commander. It seems the short version has to come first when declaring the option (weird...) [docs examples]

🤦♂
thanks for the PR! did you test it btw?

Yup, tested locally. I made sure the template flag is being parsed whether short or long and that the correct project is copied for each template option.


Add default host for different database

When set DBType as postgres but left HOST empty, then the default value of host in installation page will become <IP_ADDRESS>:3306. It's totally wrong.

I think it can be fixed in  https://github.com/go-gitea/gitea/blob/main/web_src/js/features/install.js
Then we can have a unique behavior, instead of splitting code into backend and frontend.

I think it can be fixed in https://github.com/go-gitea/gitea/blob/main/web_src/js/features/install.js

But that applies only to installation, what about already installed apps that just have this configuration wrong? I think certain duplication may be necessary.

For installed config, if the HOST is lost, then the user's config file must have been corrupted, we should not guess a potential incorrect config option for the user either. Doing too many uncertain things will cause more troubles.

I think it should go in as is ... the UI part is another thing - witch should be fixed by this too ...

The UI is the key problem, the purpose of this PR is to make the install page show correct default database host, it can be fixed in JS clearly. If we do not want to fix the install UI, we do not need to patch anything.
Changing the default values of the setting module in backend may bring some negative effects:

It splits the default values from install page, and it makes it difficult to keep them the same in future (some developers may forget one of them).
This changed behavior is not documented. No one has the expectation that HOST has default values (and the default values differ by TYPE)
If we want to refactor the setting module in future, such default values may lead to breaking changes.

Since this PR was marked to wip by lunny, I think we can keep it as wip and wait for lunny's thoughts.

replaced by #17919


docs(nuxt): pinia plugins usage (#1581) [skip ci]

when use export default myPlugin, it got a nuxt3 warning following
[warn] [nuxt] You are using a plugin that has not been wrapped in `defineNuxtPlugin`. It is advised to wrap your plugins as in the future this may enable enhancements: myPlugin

it recommended to use
export default defineNuxtPlugin(({ $pinia }) => {
  $pinia.use(MyPiniaPlugin)
})

Thanks! I merged and did a few changes locally


add header_pages config to link only specific files in header

fixes #19

cc: @benbalter

Nice start! A few questions on the implementation to try to DRY things up a bit, but I really like it.

@benbalter Thanks for the review! Improved it now to use only one loop

Up vote.

Thanks @Crunch09! Sorry for the delay.

@benbalter No worries! Thank you for merging it.


Prominently provide an event calendar

We have a google calendar, but here's what I think we need:

it should show prominently on our public web site, with a consistent look and feel
Events click through to the various different group pages
There is an easy way to add events to people's personal calendars (google, iphone, android, mac, MS exchange?)

great idea, we need to get the calendar worked out


Update to ZIO v2.0.18 and fix some code

This PR initially started to understand why update to ZIO 2.0.17 was making a test to fail.
In the end, the issue was in ZIO and has been fixed in ZIO 2.0.19.
During the bug research phase, I found some issues in the code, which are the changes in this PR.

Needs https://github.com/zio/zio/pull/8501

@guizmaii can I merge it or would you like to wait for Alex review?

@juliano If you're okay with it, I think we can merge it. Let's give @deusaquilus a week to tell us if he wants to review it first, maybe?


New World Template - Contact information map

MW 1.3.1
New World template 5.5
It will be nice to be possible to change map dimensions.

Hello, for now you can use the "Tree" of Microweber editor, to change the map size -

Or to put custom styles from the same place

Thank you


my < tag isnt working

Environment (please complete the following information):

OS (e.g., Windows 10):
Extension version (e.g., 1.2.3):

Describe the bug:

Repro steps:

Expected behavior:

Additional context:

please i need my < fixed as soon as possible

Closing as incomplete. Please feel free to add more information if you have any and we can re-open the issue.


Unknown tag 'img', Unknown tag 'js'

_config.yml
gems:

jekyll-assets

Gemfile
group :jekyll_plugins do
gem "jekyll-assets"
end
jekyll version 3.4.3
Using jekyll-assets 0.4.1
Tags don't appear to be working. Am I overlooking something really simple here?

ran bundle update
Installing jekyll-assets 2.2.8 (was 0.4.1)
fixed issue.
Why on earth would installing jekyll-assets for the first time give me an old version?

That I honestly have no idea of :/ perhaps RubyGems temporarily had an error?

@envygeeks
I am getting the same error
Using jekyll-assets 3.0.5

Hey @faizanvahevaria
This is out of my control.  Not only do I not control the RubyGems servers, or its API's but I do not control bundler and it's API or algorithms.  You'll need to file bugs on those respective repositories and ask them for further assistance, they are in control here.

@envygeeks
I had to restart my computer.
It solved then.
Thanks for the response.


Filter within FrontPort is not working

When running this:
nb = pynetbox.api('https://netboxip',token='sdsd')
frontport = nb.dcim.FrontPorts.filter(device_id=156)
We get this error
RequestError: The requested url: https://netboxip/api/dcim/FrontPorts/?device_id=156 could not be found.
The correct url from
https://netboxip/api/docs/
is
https://netboxip/api/dcim/front-ports/?device_id=156
I believe this is a bug in the pynetbox, can you confirm i am running pynetbox version 5.3.1

So dcim.FrontPorts did not work, but did you try dcim.front_ports as implied by your investigations? (Dashes in the API URL need to be replaced by underscores to be usable in Python object names)


Adjust wheel build tags appropriately for new built component

With the addition of curl to the build, the libkvikio wheels now have a compiled component. They are not being run through auditwheel, though, and I'm not sure auditwheel would even detect this as a valid wheel to audit because libcurl is built as a static library so there are no DSOs in the wheel. The problem is that the libkvikio wheels are now being shipped with linux rather than manylinux tags, so they won't be as portable as we need them to be. A bigger problem is that the libcurl archive may not be portable anyway if it embeds any noncompliant symbols, but we have no easy way to check that without running auditwheel. I think what we really want is for curl to only be built as part of the C++ interface (i.e. when the Python build or some other consumer like libcudf finds the C++), not as part of the C++ build.

This was resolved in #527 by compiling and shipping a shared library for libkvikio and statically linking libcurl into that while hiding its symbols so that we would stop shipping libcurl.


Bump version to "v14.2.10" with changelog.

Cancelling this release for the moment as CI is in a bad state for the patch branch. Once v15 goes out I'll come back to this and do an LTS release for v14.


Trowel takes blocks for the top left inventory corner

Hello, there appears to be a small oversight with Trowel 1.1.0, the trowel can take blocks from the top left inventory corner because your for loop searches blocks up to slot number 9 instead of 8.
Anyway thank you for this useful mod :)

Sorry my bad. Fixed in the latest version.


Speeds different on different viewports

Cool component, thanks!
Seems to run much faster on small viewports than desktop.
Maybe there's a good workaround here, but I'd love it if it felt "similar" on mobile to desktop

I agree. I'm not sure how to slow it down on mobile. It's unreadable.

Looks like there is a speed prop you can use. It still is based on the viewport size so it speeds up on mobile but it'll be readable.
Ex: <Marquee pauseOnHover speed="30">

I was hoping for something that would give me speed "parity".
I've slowed it down on mobile but now on desktop it's soooo slow

I was hoping for something that would give me speed "parity".
I've slowed it down on mobile but now on desktop it's soooo slow

Same... but better than waaaayyy to fast.

Hi guys, thank you for creating creating this issue.
I think it happens by the wrong calculation of pixel speed, I'll fix it and publish today.
Regards

@archiewood @3200pro published version 0.5.0. Check pls if its working correctly. I also added a prop gardient to show a gradient on the edges.
Thank you for all <3


Make suggestion widget aria label more concise

As reported by @pawelurbanski
Everytime it is triggered screen reader reads: "Suggestion. Use navigation keys to navigate".. And then the item…
Since users trigger this many times per day, reading the "Use navigation keys to navigate" is not needed

We could instead just read "Suggestion" and then the aria-label of the selected item. Or just the aria-label of the selected item.

Just the label of the item:
A bit of pseudo code:
Var wnd = window;
Wnd.addEventListener(…);
Dissecting the first line:
Pressing: ‘v’ would yield: Suggest. Var. Then I keep on typing and want to get completion for a window object. Press: ‘w’ and get again Suggest. Window.
The same for line 2 when using the variable and the method with a dot notation.
The context is extremely obvious. I don’t think that any user who is fluent enough to write even small amount os code needs this additional information besides just the label for the item being suggested.
From: Isidor Nikolic<EMAIL_ADDRESS>Sent: poniedziałek, 11 maja 2020 16:28
To: microsoft/vscode<EMAIL_ADDRESS>Cc: Pawel Urbanski<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [microsoft/vscode] Make suggestion widget aria label more concise (#97510)
We could instead just read "Suggestion" and then the aria-label of the selected item. Or just the aria-label of the selected item.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/issues/97510#issuecomment-626736694, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAWAEQDWKOE3R26VTGVOZVLRRADNLANCNFSM4M56ULIQ.

Since there is no audible clue that this is indeed a suggestion box, keeping the label for the container as "Suggestion" would be OK, IMO, but yes, removing that "Press up and down to navigate" is indeed too much for that label. It is announced that the user is in a listbox anyway, which always gets navigated with arrow keys.

The widget is activated in the editor. And it takes just seconds to get that association.
While there maybe is no very direct clue about the role of the container the label for the item being suggested is very obvious.
We should try to keep in mind the audience for VS Code – at least power user or developers. Even if VS Code is used in the classroom or by a complete beginner, hearing this: ‘Suggestion.’ Label before the item would stop making sense after at most a dozen times IMHO.
I vote for just the label of the item currently being suggested coming from the aria-activedescendant association. In case when there is nothing to be suggested just set the label to: No Match – just 2 very short sylabels in a phonetic sense.

It would help if VS Code had, on Windows at least, the ability to trigger the same Windows event that the start menu triggers when you type something in the search box and suggestions become available. NVDA makes a distinct sound in this instance, but I have not seen this anywhere except the start menu search box, AKA Cortana search box. That would be cool as an alternative to the "Suggestions" label for the container. :-)

Not sure if you disable automatic suggestions/quick suggest? I always get confused by that happening and not sure if it helps if it announces that it's a suggestion or not. In the case of manually activated by ctrl+space I am ok with hearing the suggestion word.

Attaching a sound is the screen reader side and very likely a custom classimplemented for the start menu control. When it comes to triggering a control with a label when invoked with a shortcut it would require using a flag that would later on be used in a condition to add this ‘suggest’ label. I find it also very redundant to add this label in case when someone mantually triggers the intellisense autocomplete widget, for it is a very direct action with a very predictable behavior attached to the shortcut.

OK. my two cents. I am totally for deleting arrow information. and not only from the autocomplete widget, but also from other VsCode parts.
As for the label, this is an ambiguous situation and we need to think about it. I, as an advanced user, would prefer not to hear: "Suggestion, but you need to think about novices too.

I mentioned novices in my previous comment. Learning the context around intellisense, which is a feature of the editor should take at most half an hour at most…
User who want to take a shot at coding are either power users or enrolled in a course with instructors who will be more than happy to spend a few minutes explaining / helping out. While we should not make the learning curve steep and entering coding difficult, we can expect reasonable fluency working with tools like VS Code or other kinds of IDEs.
It applies equally to people with and without disabilities…

I believe in vs and eclipse it would just indicate that you are in a list, then say the suggestion.

Thanks a lot for feedback. It is sometimes hard to find a delicate balance between an experience for novice users and for pros.
Though based on your feedback I have decided to remove the "Use the navigation keys to navigate" message all over vscode. Since the screen reader will always announce the correct role I feel it is pretty obvious to use the up / down arrow key.
So pushing this out to insiders so we get feedback.
fyi @joaomoreno since you might have a good reason when you originally added this message.

@isidorn Just follow the git blame trail: https://github.com/microsoft/vscode/issues/52658#issuecomment-402643764

Awesome that we removed it then. There was no good motivation to add it in the first place.


Fixed grammar around time in README

Made sure subject and verb agree and tweaked timezone to include the obligatory nod to Douglas Adams.

✨🍰✨


gutenberg: 0.3.1 -> 0.3.4

0.3.4 (2018-06-22)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

Success on x86_64-linux (full log)
Attempted: gutenberg
Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/5h15d7dsl537c1vm4ms0b6l633lrjjy7-gutenberg-0.3.4
shrinking /nix/store/5h15d7dsl537c1vm4ms0b6l633lrjjy7-gutenberg-0.3.4/bin/gutenberg
strip is /nix/store/4qvrxzxa535y8304mk195x50b6p9607d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5h15d7dsl537c1vm4ms0b6l633lrjjy7-gutenberg-0.3.4/bin
patching script interpreter paths in /nix/store/5h15d7dsl537c1vm4ms0b6l633lrjjy7-gutenberg-0.3.4
checking for references to /tmp/nix-build-gutenberg-0.3.4.drv-0 in /nix/store/5h15d7dsl537c1vm4ms0b6l633lrjjy7-gutenberg-0.3.4...
/nix/store/5h15d7dsl537c1vm4ms0b6l633lrjjy7-gutenberg-0.3.4


chore: release

🤖 New release

rattler: 0.21.0 -> 0.22.0 (⚠ API breaking changes)
rattler_conda_types: 0.20.5 -> 0.21.0 (⚠ API breaking changes)
rattler_digest: 0.19.2 -> 0.19.3 (✓ API compatible changes)
rattler_macros: 0.19.2 -> 0.19.3
rattler_package_streaming: 0.20.3 -> 0.20.4 (✓ API compatible changes)
rattler_networking: 0.20.1 -> 0.20.2 (✓ API compatible changes)
rattler_shell: 0.19.6 -> 0.19.7 (✓ API compatible changes)
rattler_lock: 0.22.1 -> 0.22.2 (✓ API compatible changes)
rattler_repodata_gateway: 0.19.6 -> 0.19.7 (✓ API compatible changes)
rattler_solve: 0.20.5 -> 0.20.6 (✓ API compatible changes)
rattler_libsolv_c: 0.19.2 -> 0.19.3 (✓ API compatible changes)
rattler_virtual_packages: 0.19.6 -> 0.19.7 (✓ API compatible changes)
rattler_index: 0.19.6 -> 0.19.7 (✓ API compatible changes)

⚠ rattler breaking changes
--- failure function_parameter_count_changed: pub fn parameter count changed ---

Description:
A publicly-visible function now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.30.0/src/lints/function_parameter_count_changed.ron

Failed in:
  rattler::install::python_entry_point_template now takes 4 parameters instead of 3, in /tmp/.tmpRgAO9Q/rattler/crates/rattler/src/install/entry_point.rs:144

⚠ rattler_conda_types breaking changes
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.30.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field ChannelConfig.root_dir in /tmp/.tmpRgAO9Q/rattler/crates/rattler_conda_types/src/channel/mod.rs:36

Changelog
rattler

0.22.0 - 2024-04-19
Added

make root dir configurable in channel config (#602)

Fixed

no shebang on windows to make spaces in prefix work (#611)
use correct platform to decide the windows launcher (#608)

Other

update dependencies incl. reqwest (#606)

rattler_conda_types

0.21.0 - 2024-04-19
Added

make root dir configurable in channel config (#602)

Fixed

better value for link field (#610)

Other

update dependencies incl. reqwest (#606)

rattler_digest

0.19.3 - 2024-04-19
Other

update Cargo.toml dependencies

rattler_macros

0.19.3 - 2024-04-19
Other

update Cargo.toml dependencies

rattler_package_streaming

0.20.4 - 2024-04-19
Other

update dependencies incl. reqwest (#606)

rattler_networking

0.20.2 - 2024-04-19
Added

enable zst support for OCI registry (#601)

Other

update dependencies incl. reqwest (#606)

rattler_shell

0.19.7 - 2024-04-19
Other

update Cargo.toml dependencies

rattler_lock

0.22.2 - 2024-04-19
Other

update dependencies incl. reqwest (#606)

rattler_repodata_gateway

0.19.7 - 2024-04-19
Added

make root dir configurable in channel config (#602)

Other

update dependencies incl. reqwest (#606)

rattler_solve

0.20.6 - 2024-04-19
Added

make root dir configurable in channel config (#602)

Other

update dependencies incl. reqwest (#606)

rattler_libsolv_c

0.19.3 - 2024-04-19
Other

update Cargo.toml dependencies

rattler_virtual_packages

0.19.7 - 2024-04-19
Other

update dependencies incl. reqwest (#606)

rattler_index

0.19.7 - 2024-04-19
Other

update Cargo.toml dependencies

This PR was generated with release-plz.

Releasing once the latest changes are pushed! 🚀


Some custom pin icons displayed as standard icons

Some custom pin icons displayed as standard icons.
After several zoom-in and zoom-out all icons became correct.
Android sample attached.
Please, set AndroidManifest.xml Google API key first:
<meta-data android:name="com.google.android.geo.API_KEY" android:value="GOOGLE MAP KEY"
"await Task.Delay(1000);" after each "Map.ClusteredPins.Add(pin);" could increase amount of correctly displayed icons.
Sample to reproduce:
GMaps.zip

I have exactly the same problem. XF 3.5 Adroid 9

Thanks for the sample project! I have identified the issue and I'm going to look for a solution


chore: try use nx

Fixes #264
This PR introduces two changes:

First: it adopts nx.
Second: it extracts @repress/runtime and @repress/theme-default to avoid cyclic dependencies. And it may have some break changes.

LGTM


chore: cache secrets-store-provider-azure v1.5.0

What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:

regularly upgrade. cache secrets-store-csi-driver v1.4.0.
regularly upgrade. cache secrets-store-provider-azure v1.5.0.

Fixes #
Requirements:

[x] uses conventional commit messages

[x] includes documentation
[ ] adds unit tests
[x] tested upgrade from previous version

Special notes for your reviewer:
Release note:
chore: cache secrets-store-provider-azure v1.5.0

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.095%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2255

Relevant Lines:
2851

💛  - Coveralls


Add missing types

Hi @ognjen-petrovic,
We're planning on updating to the latest version of dxf-writer, but we noticed some missing types.
I'm adding them in this PR.

Published.
Thanks.


novatel_oem7_driver: 1.1.0-1 in 'melodic/distribution.yaml' [bloom]

Increasing version of package(s) in repository novatel_oem7_driver to 1.1.0-1:

upstream repository: https://github.com/novatel/novatel_oem7_driver.git
release repository: https://github.com/novatel-gbp/novatel_oem7_driver-release.git
distro file: melodic/distribution.yaml
bloom version: 0.9.3
previous version for package: 1.0.0-1

Fixed broken binary builds.


Code flow silent refresh without offline_access?

Hi,
Is it possible to use Code flow silent refresh without having the offline_access scope? My initial authorization works but when it comes to silent refresh i get invalid_grant error and silent_refresh_error.

Would you agree that this is a duplicate of #600 ?

I would agree, so its still not possible to refresh a session with code flow because i dont have a refresh token and it needs to be passed when calling endpoint/connect/token?

If you add offline_access to the requested scopes your IDS (if it supports it) will issue a refresh_token too, so you could use that to refresh. See this commit for how I do that until #600 gets resolved.


Add Angular support for sortByFieldName on anchor and text columns

Pull Request
🤨 Rationale
Adds support in Angular for the sortByFieldName property on the anchor and text columns.
👩💻 Implementation
Followed existing patterns to add the sortByFieldName property to the directives for the anchor and text columns.
🧪 Testing
New unit tests for the property
✅ Checklist

[ ] I have updated the project documentation to reflect my changes or determined no changes are needed.

@m-akinc, will you buddy this PR for me?

Straightforward change, don't think we need to wait on @atmgrifter00, enabling automerge


feat: Add api to support copying existing rag

What type of PR is this?
/kind feature

What this PR does / why we need it
Add api to support copying existing rag
Which issue(s) this PR fixes

Fixes #700
Special notes for your reviewer

rebase the latest code.


Example needs autogypi to build and run

When I tried the code in the Example section it failed with the following output:
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/configure.js:357:16)
gyp ERR! stack     at ChildProcess.emit (events.js:110:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:1074:12)
gyp ERR! System Darwin 14.3.0
gyp ERR! command "node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/brodybits/mynb/bt
gyp ERR! node -v v0.12.7
gyp ERR! node-gyp -v v2.0.2
gyp ERR! not ok

I had to first do npm install -g autogypi and run autogypi, then the example worked for me. Also needs a new version of npm as I said in charto/autogypi#1.

autogypi is listed in devDependencies in package.json. So it should be installed with the quick start steps:
git clone https://github.com/charto/nbind.git
cd nbind
npm install
npm test

There, npm install when run inside the git cloned repo, should install devDependencies. Maybe something silently failed when you ran it with older npm installed, or you didn't notice an error message and continued? It sounds like the correct fix is to set the minimum required npm version in package.json so it would fail more spectacularly before even getting close to installing autogypi. I'll need to do the same to autogypi's package.json too. Thanks for reporting.

Another possible fix is to rename autolink and publish it in the global npm namescape instead of the @lib scope. Problem is that the "autolink" name is taken and I don't want to reserve any other name for it either, since it's a utility package only ever meant to be used by autodts and autogypi. Since it has no wider utility, I think it belongs in a scope, but older npm versions lacking scope support will fail to install nbind correctly for such a minor reason... What do you think is the best option here?

It seems prepublish was wrong in this case, I replaced it with install and added notes about updating npm. Thanks for the help.


[Bug] Not able to open apps via links regardless of "Open links in apps" settings

Describe the bug
Clicking a link to open an app recently stopped working, regardless of your "Open links in apps" setting within DuckDuckGo. Instead, just a new tab of DuckDuckGo is opened. We use web views + app links for our mobile log in at Ramp and recently started seeing this issue for our log in for Android users on DuckDuckGo.
https://github.com/duckduckgo/Android/assets/3013261/cbd8887d-776f-490d-97bc-1d679ede45db
How to Reproduce
Find a link that's supposed to open an app, it doesn't open the app and instead opens a new tab
Expected behavior
Expected behavior: Clicking an app link opens the app
Environment
- DDG App Version: 5.177.1
- Device: Pixel 6
- OS: Android 13

Hi @GabeK0, thanks for reporting this issue!
We've tried to reproduce it on Ramp's production site, but weren't able to. Could you please let us know if you're facing the same issue on the prod site or only the QA one?

@CrisBarreiro thanks for looking into this, we really appreciate it.
So to be clear, this is not happening on Ramp's production site exactly, this is happening within our Android app's log in flow which uses a web view for log in.
Once you complete log in within the web view and click "Continue to the app", it's supposed to return you to the Ramp Android app.
In the past, we've seen issues with our log in for Android users using DuckDuckGo as their default browser, such as when users have gone into their DuckDuckGo app settings -> Permissions -> Open Links in Apps -> and had selected "Never." Unsurprisingly, if they do select this setting, our "Continue to the app" mobile web view button is not able to redirect said user into our Android app. That is expected behavior, as your the DuckDuckGo app's settings are working as intended.
Recently however, it seems that our "Continue to the app" web view button is not redirecting users into our Android app, regardless of their DuckDuckGo "Open Links in Apps" settings. Even if they have that setting set to "Always," they still aren't redirected into the app. We currently believe this to be a regression within DuckDuckGo, as it was previously working with DuckDuckGo and only recently stopped working, and we haven't seen any issues with any other Android browsers.

Thanks for the detailed explanation @GabeK0!
I did some testing using the Ramp Android app, but still couldn't reproduce the issue. The only difference I can see is that we're using SSO, while you're using username and password. Even though this is most likely not the problem, could you please test again using SSO?
Also, could you please check which webview version your testing device is using?

@CrisBarreiro Thank you so much for helping test and investigate.
I'm unfortunately not easily able to test with SSO due to Okta SSO restrictions on our end.
At any rate though, after reproing the issue several more times I tried uninstall + reinstalling DuckDuckGo and that seemed to fix it. Not sure if there's somehow some sort of corrupted cache state or a similar such weird edge case that can happen to cause this issue, but the fresh installation of DDG fixed it even though I'm still on the same version of the app (5.177.1).
I think we're good to close this issue out and I can re-surface it with more details if we encounter it again.

Thanks @GabeK0! I tried selecting "Never" and then switching back to "Always" to check if there was some issue when changing states but it worked as expected. I'll keep an eye in case I see it again, but for now I'll close this issue. Absolutely, in case you encounter it again, please feel free to re-surface!

Sounds good, thank you!


Audio for reef still doesn't work

While I don't really know much about how audio works on Linux, after following the commands to get audio working on the reef Chromebook, I still haven't been able to get any sound output working on my installation of Ubuntu with KDE. At first, the first error that I had encountered was that the setup-audio script had been trying to pull the ChromeOS files off of /dev/mmcblk0p3 while on my Chromebook, the internal storage had always been mounted at /dev/mmcblk1. After modifying the script to account for this, the script completes without any further error, but upon a reboot of the system, after installing kmix, I still only get an output labeled "default and only sink". I've also tried running firefox with apulse firefox, where I had gotten errors such as can't open playback device "default". Error code -2 (No such file or directory) and ALSA lib confmisc.c:767:(parse_card) cannot find card '0'. Another thing that I had tried was to execute the commands set out in alsa-reload.service manually, where I was met with
ALSA lib parser.c:1934:(get_by_card_name) no soundcards found... ALSA lib main.c:412:(execute_sequence) unable to open ctl device 'hw:bxtda7219max' ALSA lib main.c:1971:(set_verb_user) error: failed to initialize new use case: HiFi alsaucm: error failed to set _verb=HiFi: No such device
after running alsaucm -c bxtda7219max set _verb HiFi set _enadev Speaker
Any help on this matter would be appreciated.

Could you post the output of dmesg?

Alright, dmesg.txt

Mine doesn't work either
I don't know what to do
The three commands on the website all failed

Try running sof-setup-audio within Breath. I have a feeling it'll work :D

While I am really grateful for your efforts towards getting many other Chromebooks that otherwise wouldn't have been able to run Linux, it appears that running sof-setup-audio still does not fix the audio issues that I have been experiencing on my Acer Spin 11.
While running Firefox, the errors that I face after pulling up a YouTube video are:
ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5233:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM dmix
[apulse] [error] do_connect_pcm: can't open playback device "default". Error code -2 (No such file or directory)
[apulse] [error] do_connect_pcm: failed to open ALSA device. Apulse does no resampling or format conversion, leaving that task to ALSA plugins. Ensure that selected device is capable of playing a particular sample format at a particular rate. They have to be supported by either hardware directly, or by "plug" and "dmix" ALSA plugins which will perform required conversions on CPU.
[Child 1974, MediaDecoderStateMachine #1] WARNING: 7fed0dcd82f0 OpenCubeb() failed to init cubeb: file /build/firefox-ahszPM/firefox-95.0.1+build2/dom/media/AudioStream.cpp:324
[Child 1974, MediaDecoderStateMachine #1] WARNING: Decoder=7fed135d9100 [OnMediaSinkAudioError]: file /build/firefox-ahszPM/firefox-95.0.1+build2/dom/media/MediaDecoderStateMachine.cpp:4007
ATTENTION: default value of option mesa_glthread overridden by environment.
ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
ALSA lib conf.c:4745:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5233:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2660:(snd_pcm_open_noupdate) Unknown PCM dmix
[apulse] [error] do_connect_pcm: can't open playback device "default". Error code -2 (No such file or directory)
[apulse] [error] do_connect_pcm: failed to open ALSA device. Apulse does no resampling or format conversion, leaving that task to ALSA plugins. Ensure that selected device is capable of playing a particular sample format at a particular rate. They have to be supported by either hardware directly, or by "plug" and "dmix" ALSA plugins which will perform required conversions on CPU.

It appears there are no soundcards detected. Could I have the output of dmesg?

Again, heres dmesg.txt. Thank you so much for the effort that you've put into this project!

@RodBarnes try running setup-audio. Reboot and post the output of sudo dmesg and ‘sudo alsa-info’

I ran setup-audio then ran sudo dmesg | nc termbin.com 9999.  The output can be seen here.

This is the main error:
[    8.848546] snd_soc_skl 0000:00:0e.0: Direct firmware load for 5a98-reef-sand-8-tplg.bin failed with error -2 [    8.848567] snd_soc_skl 0000:00:0e.0: tplg fw 5a98-reef-sand-8-tplg.bin load failed with -2, trying alternative tplg name bxt_da7219_mx98357a-tplg.bin [    8.848599] snd_soc_skl 0000:00:0e.0: Direct firmware load for bxt_da7219_mx98357a-tplg.bin failed with error -2 [    8.848602] snd_soc_skl 0000:00:0e.0: tplg bxt_da7219_mx98357a-tplg.bin failed with -2, falling back to dfw_sst.bin [    8.848624] snd_soc_skl 0000:00:0e.0: Direct firmware load for dfw_sst.bin failed with error -2 [    8.848627] snd_soc_skl 0000:00:0e.0: Fallback tplg fw dfw_sst.bin load failed with -2 [    8.848633] snd_soc_skl 0000:00:0e.0: Failed to init topology!
What’s the output of ls /lib/firmware, lsblk, and setup-audio; sync? Looks like the fw still hasn’t been copied, which puzzles me.

The thing is, the specific kernel used in ChromeOS has specific patches and a special config file. I’m halfway through retrieving those.

rod@ubuntu:~$ ls /lib/firmware | grep 5a98
5a98-reef-sand-8-tplg.bin
rod@ubuntu:~$ ls /lib/firmware | grep bxt_da7219

rod@ubuntu:~$ ls /lib/firmware | grep dfw_sst

Full output of ls /lib/firmware is here.

Output of ls /lib/firmware is here.  Note that it lists 5a98-reef-sand-8-tplg.bin but neither of the two backups (bxt_da7219_mx98357a-tplg.bin or dfw_sst.bin) are listed.
Output of 'lsblk' is here.
Output of setup-audio; sync is here.

Maybe copying /lib/firmware/5a98-reef-sand-8-tplg.bin to /lib/firmware/intel/5a98-reef-sand-8-tplg.bin.

I did the copy, ran setup-audio; sync again, rebooted, and confirmed that 5a98-reef-sand-8-tplg.bin as still in /lib/firmware/intel.  I then did speaker-test with the same result: cannot find card '0'.

I think I'm going the wrong direction here, it seems like SOF is the way to go. Could you run sof-setup-audio and sudo alsa-info (when it asks for a link, say "y" and share it).

Ran sof-setup-audio, rebooted as it directed, then ran sudo alsa-info.  I did say 'Y' to upload but it didn't report a link but a path: /tmp/alsa-info.txt.vS1ss5uoFf.  That file does exist and I have made it available here.

I'll be fixing this issue for all Apollo Lake Chromebooks soon. It looks like the key to solving this is located in this thread over here.

I added a new SOF script for Apollo Lake that might work. Run:
sudo wget https://raw.githubusercontent.com/cb-linux/breath/main/bin/apl-sof-setup-audio -O /usr/local/bin/apl-sof-setup-audio```
and then

sudo chmod +x /usr/local/bin/apl-sof-setup-audio
Then, just run `apl-sof-setup-audio` on your chromebook.

I think the script has cr/lf in it?  I got ^M errors when I attempt to execute it.  I edited in nano and confirmed it as MS-DOS format.  I saved it as Mac format but it still won't execute, reporting:
set: bad interpreter: No such file or directorybash`

I fixed the line ending issues and dd. Hopefully it should do fix it. Do the whole spiel again; run:
sudo wget https://raw.githubusercontent.com/cb-linux/breath/main/bin/apl-sof-setup-audio -O /usr/local/bin/apl-sof-setup-audio

and then
sudo chmod +x /usr/local/bin/apl-sof-setup-audio

Then, just run apl-sof-setup-audio on your chromebook.

This time, it made it all the way through but I still got that initial error (details below).  other than that, no other errors appeared in the output and it otherwise went to completion.  However, after the reboot, I still have no output device showing under "Settings > Sound" and running speaker-test produced the same results; i.e., cannot find card '0'.
Error details: During the process, I still got that dpkg-deb error and immediately after it occurred, a dialog appeared prompting to generate a bug report.  I clicked "Yes" which took me to bugs.launchpad.net.  (I have not yet submitted it; I wasn't sure that was correct given we're doing dev testing here; let me know if you want me to proceed.)  The summary of the report is "package firmware-sof-signed 1.7-1 failed to install/upgrade: trying to overwrite '/lib/firmware/intel/sof/sof-bdw.ri', which is also in package linux-firmware 1.201.4"

The dpkg-deb error wasn't a failure. It's a bug in the Ubuntu SOF firmware packages. When that inevitably occurs, it runs another command which fixes it. Filing a bug report was a good idea.
Please post the output of sudo alsa-info and dmesg whenever I test like this.

Repeated the test.
Output of alp-sof-setup-audio is here.
Submitted the but report.
Output of sudo alsa-info is here.
Output of sudo dmesg is here.

It seems the kernel command line isn't getting properly applied. What's the text of the file kernel.flags in ~/linux-build? Could you run bash -x apl-sof-setup-audio?

On the Chromebook,~/linux-build/kernel.flags contains:
console=tty1 root=/dev/sda2 i915.modeset=1 rootwait rw fbcon=logo-pos:center,logo-count:1 loglevel=0 splash snd-intel-dspcfg.dsp_driver=3 snd_sof_pci.fw_path="intel/sof"
Output of bash -x apl-sof-setup-audio is here.

Alright, last time, I promise. Run:
sudo wget https://raw.githubusercontent.com/cb-linux/breath/main/bin/apl-sof-setup-audio -O /usr/local/bin/apl-sof-setup-audio

and then
sudo chmod +x /usr/local/bin/apl-sof-setup-audio

Run apl-sof-setup-audio on your chromebook.

Houston: WE HAVE LIFT-OFF!  System sounds are working; using mpg123 was able to play an MP3.
I still don't see an output device under "Settings > Sound" so unable to [Test] or set "Balance", etc.  Maybe this is a Gnome thing?
BTW: You should have received a donation from me.  I greatly appreciate your efforts here; I do not mind doing this multiple times.

Huuuge thanks for the donation :D
I'll look into fixing the GNOME audio. GNOME uses PulseAudio, so it doesn't detect the minimal ALSA setup this project uses.

Quick question:  Will these steps be necessary with future images?  Or is this going to be baked in?

For future images, users will need to run apl-sof-setup-audio. The reason I've isolated these into commands and not made these run by default is because there are multiple audio setups, some with SOF, some with SOF+Realtek, and others without SOF. For those without reef, apl-sof-setup-audio wouldn't work.

Clarification: Maybe I am remembering incorrectly, but I am pretty sure that in my prior testing with the apl-sof-setup-audio script I executed the script without as my user.  Certainly, looking at the previous comments where it was successful, there is no indication of using sudo.
Plus, the instructions don't specify using sudo.
However, I noticed in the latest release that both apl-sof-setup-audio and sof-setup-audio are executable only for the owner and group.  Changing them to be executable for other I was successful with running and setting up the audio.  I assume this would also work if I ran it as sudo.
Maybe this was an oversight?  Or maybe by design?  I didn't want to just fork and make a change without checking on if this was intentional.

Omg, what about arch linux guys, is it possible to make sound work too?

You can adapt the bash so it has Arch support by using pacman. Feel free to open a PR.

@RodBarnes I've fixed this in the latest commit.

Hmmm... I just pulled and they still show as this:
drwxr-xr-x  2 root root 4096 Mar 16 14:27 .
drwxr-xr-x 10 root root 4096 Mar  9 00:57 ..
-rwxr-xr--  1 root root 3563 Mar 16 14:27 apl-sof-setup-audio
-rwxr-xr--  1 root root 1568 Mar 16 14:27 install-to-internal-storage
-rwxr-xr--  1 root root 2573 Mar 16 14:27 setup-audio
-rwxr-xr--  1 root root 2004 Mar 16 14:27 sof-setup-audio
-rwxr-xr--  1 root root 2989 Mar 16 14:27 updatekernel-on-emmc

A new issue?
I just did a clean and clone (deleted my repository, cloned again).  Then built and flashed the image.  When I run apl-sof-setup-audio it reports:
Setting up firmware-sof-signed (1.7-1) ...
Downloading the Apollo Lake SOF Topology...
lsblk: /dev/sda2s: not a block device

Here's the output of lsblk:
sda            8:0    1 28.9G  0 disk
├─sda1         8:1    1   64M  0 part
└─sda2         8:2    1 11.9G  0 part /
sdb            8:16   1  1.9G  0 disk
└─sdb1         8:17   1  1.9G  0 part /media/rod/TOOLS

I fixed the trailing s issue in the latest commit. Any extra info over the penguin screen? Maybe an image?

I picked an earlier point (commit e26b1c) and built from there.  But it did the same thing.  I'll continue to work back to find a point where it is working again and attempt to identify what changed.  But here's a screen shot.

Alright, so it's waiting for a root device, meaning the kernel parameter for the root device the script set is wrong. Are you running this off of the internal storage? I've yet to test that functionality.

What would also be useful for debugging this issue would be providing the output of bash -x $(which apl-sof-setup-audio).

So, it works fine on commit ccb22a4ed4accf73dd29fbde114b05370db8f069 "Dummy commit to fix line endings".  It may be notable that this is just prior to the docker-related changes.

As of the latest commit, the script should be operational again :D

@MilkyDeveloper  Confirmed.  However, it still shows the penguin and a lot more stuff happening at boot now than it did before.  Could you explain what all the additional is?  When the sound was working before, it didn't show all of this.  Just would like to understand...

So, sound is working again now? The extra boot messages must be a kernel addition since I recently rebuilt the kernel with some extra modules. I find the logging to be useful for debugging.

Yes, sound is working with your last change. The extra messages for debugging makes sense. Just unexpected and seems to take a little longer to boot. But that could be just me watching the messages scroll by. 😊
--
Rod Barnes
-------- Original Message --------
On Mar 17, 2022, 7:03 PM, MilkyDeveloper wrote:

So, sound is working again now? The extra boot messages must be a kernel addition since I recently rebuilt the kernel with some extra modules. I find the logging to be useful for debugging.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: @.***>


Update local validation to limit to specific page

Approve, will add tests once we finish all the RSR stuff :)


Add tab in distribution area to have different views for data

What feature do you want to see added?
By default we have each item like tree view.
The feature would consit to add tabs on distribution area. Something like this:

Tab 1 : The current view
Tab 2 : The expanded view (all elementary items)
Upstream changes
No response

@totocaca123 What do you mean with elementary items in the second view?

Data are like a tree view in json file. Elementary are data at the end of the tree (have no child).


portal ingress.tls.enabled from env

What
Optionally read the value for the portal's ingress.tls.enabled from an environment variable
Why
Allow the portal chart to be installed in scenarios where TLS is not used.

@osterman OK if I cut a release for this?

👍


Allows to remove all queries for a URI

The Request already allows to remove all queries as it has the default parameter value set as "". This adds also the default to Uri.removeQueries() so it can remove all queries as well.

https://github.com/http4k/http4k/pulls => 1119


Avoid suggesting using data directly

I don't know if this is something that should be mentioned in the readme but data is private api and shouldn't be used.
I got stung by it after using the data links directly in my templates for using a media link that is rendered in an image, i.e. {{my-image src=obj.nested.data.links.media}}.
The problem is that the data, which is an readonly alias for its internal model _data is converted by ember to  an ember object with __ember_meta__, setters, getters and much more. That means the internal model is now an ember object (which is pretty bad).
This breaks pushing an already loaded record to the store (i.e. by ember after an store.find) because it tries to merge the stored record with the new incoming record. This happens without calling Ember.set which causes the ember added setter to throw an error because it needs to be invoked with Ember.set

I solved this for myself by adding a links attribute links: attr() to all my models and reading the links values from that attribute. ({{my-image src=obj.nested.links.media}}).
This could be redundant if https://github.com/emberjs/data/issues/2905 is fixed (https://github.com/emberjs/data/issues/3419)

I noticed this yesterday during an upgrade.  I am unsure what the approved public API would be to grab links from the underlying internal model, but we should figure out a path forward if we can...

I'm unsure of the path forward here as well. What does JSONAPIAdapter do with the links made available?


Error bars

(With the danger that you take away my github account, I'll continue starting issues, even for minor stuff)
Noticed that we have to think as well about error bars.
Looking at the following plot make me think that there are some missing? Would that be difficult?

Same for effective focal length, d80, ...

I agree.
The difficulty really depends on the specifics of each plot.
In this case, the eff area comes from a fraction of photons detected/simulated. A binomial uncertainty should give what we want.
I'll implement that.
It's important to note that it won't always be so easy nor worth it. In this case, the eff area is basically flat, which makes very small fluctuations look so ugly. If the error calculation here was complicated, I'd say it's not worth it because it's in general very small.

Agree - don't put a huge amount of work into it. I didn't notice the very suppressed y-axis, which amplifies the flucutations.
Errors bars should be wherever they make sense and can be achieved with reasonable effort.

Ok.
I think it's better to implement this ones later. I'll finish going through the documentation issues first.

I can help implementing error bars here if you wish. Also, I am not sure the fluctuations are that small (1-2 m^2 is non-negligible no?).

Orel is actually right - where does the uncertainty of 1 m^2 come from? Although this is a ray-tracing experiment, the result should be almost deterministic. Of course we should see partly the imprint of the structure / beams etc.

You don't see the imprint of the structure because we do not simulate it in sim_telarray. To include it we use the telescope transmission function, but for the LST (which is what I assume is simulated, should add a label to the plot), that function is flat.
However, shouldn't we see the imprint of the camera? That we do simulate I think.

I suggest to close this issue.
The requirement on having uncertainties on all results is a generic task and written down in the requirements and concept document.


Menus is light on dark mode

Hi,
The app theme is dark but the menu is light.
Please fix this issue.
Thanks 🙏

It's intentional behavior, but I can change it if it will look good 🤔

Why is this behavior intentional?

+1 👍
It would be great if the color of menus matched the color theme.

Fixed in v2023.1.5


fix oop jit issue with LdThis loading wrong global object

Host might set global object after we have already initialized the script context on JIT side, so instead pass global this address at JIT time

:shipit:

@dotnet-bot test Ubuntu ubuntu_linux_debug

@dotnet-bot test Ubuntu ubuntu_linux_debug_static


Adding Codelab step to add Blockly

Added button handling in EditFragment.
Import blockly dependency (and associated Android support files, from maven).
Adding BlocklyFragment, triggered by selecting one of the buttons on the EditFragment, with MusicMaker specific blocks, toolbox, and generators.
Added copyrights to source files.

This change is

This CL LGTM.
Taking a closer look at the contents should MusicMaker-step1-Blockly be MusicMaker-final to match MusicMaker-starter?

Not the final step.
However, I still want the final step to be alphabetical, so I was planning on leaving it as step3


Wikilinks should appear as backlinks in linked section

6/13 Update:

I thought reopenWidget would allow me to update the widget's data - however it edits the Class' prototype instead. Also doesn't rerender. Do some research hear in discourse discourse on editing widget attributes and rerendering
Still investigating where linked posts come from. models/topic.js fires an api call to /t/[id].js to fetch all the data related to the topic at once, where in it, there's already a posts field. This route hits TopicController:show, verified by a puts 'Hello World' statement, which seems to call TopicView.new. Need to figure out where this leads and how it fetches linked references. It's possible this data is saved on create/edit of post
Above two investigations are meant to lead to one of the following two solutions:

Extend the widget to fetch new linked data and display
Investigate whether plugins could have server side implementation to extend how Topic:view works

2 is not likely, but keeping the possibility open

6/14 Update:

Have an MVP working! Live on main
The approach is really hacky - going to post on the Meta Discourse tomorrow for help to see if anyone have any ideas with the existing APIs for improvements.
The basic flow is that I'm calling search on the page's title, wrapped by brackets, and returning those results in linked references. This happens after initial render so there's a small delay between when the page is initially rendered and the new linked references become populated


Unknown error while getting Nuxt Builds, Unknown error while getting Access Token

Прокси не использую

i have the same issue. anyway to fix this ?


Unexpected fluctuations in the prompt size

During my experiments with the Llama3_2-3B model (and its built-in tokenizer) I have noticed the following issue: even if I set --synthetic-input-tokens-mean 256 --synthetic-input-tokens-stddev 0, not all inputs have the size of 256, but rather they are distributed around 256.
This plot built for one of such experiments demonstrates the problem:

I believe that the issue happens because of these lines in genai_perf/inputs/retrievers/synthetic_prompt_generator.py:
        # Final tweaks
        diff = requested_prompt_tokens - get_token_length(prompt)
        for _ in range(diff):
            prompt = "hi " + prompt

This code snippet was designed with an assumption that "hi " would be tokenized to exactly one token that is not true for all tokenizers (as I have mentioned above an example is one in Llama3_2-3B).
I have tried to patch the issue like this:
diff --git a/genai-perf/genai_perf/inputs/retrievers/synthetic_prompt_generator.py b/genai-perf/genai_perf/inputs/retrievers/synthetic_prompt_generator.py
index 68b77fd..5a8d5d4 100644
--- a/genai-perf/genai_perf/inputs/retrievers/synthetic_prompt_generator.py
+++ b/genai-perf/genai_perf/inputs/retrievers/synthetic_prompt_generator.py
@@ -110,8 +110,7 @@ class SyntheticPromptGenerator:
         prompt += final_line

         # Final tweaks
-        diff = requested_prompt_tokens - get_token_length(prompt)
-        for _ in range(diff):
+        while requested_prompt_tokens > get_token_length(prompt):
             prompt = "hi " + prompt

         return prompt

but obviously it is not ideal. While this approach allows me to have the constant input size, it still assumed that "hi " cannot be tokenized in more than one token, otherwise the size would be larger than expected.
I think a good solution would be using the while approach to guarantee that the factual size is either above or below the desired value, and if it is still not equal to it, throwing a warning.
Another way could be using the pad token instead of "hi ", but it can limit the usage of some tokenizers and models.
I have not yet come up with a bullet-proof solution to built a prompt that would be tokenized to the desired number of token for any given tokenizer.

That bullet-proof solution would be appreciated. :D We spent some time thinking through the best way to get an exact number of tokens while trading off for efficiency. Since the sum of tokens in fragments is not equal to the number of tokens in the combined prompt, there was not a clear way to guarantee a token count, and it would be inefficient to randomly remove and add words until the right count was achieved. This was the approach that seemed to be balance the tradeoffs. We include that token counts may not be exact in the known issues in the README.
Since the table includes the input sequence length, I think a warning might end up being redundant.
We'd be open to looking at the approach for generating tokens again, but there might not be a good way to generate an exact token count.
CC: @nicolasnoble

This pull request updated the approach and should make the token counts more consistent. It's on the main branch and will be included in the next release.
This approach was tested across tokenizers, though it's possible there are still edge cases. It's no longer dependent on whether hi is tokenized as one token or not.


How to pass compression level to_parquet, to_zarr [docs]

@pavithraes and I were answering this question on discourse and we thought that this could be a nice How to page.
Thoughts?

cc @jsignel :)

Not totally sure what the scope if for our how to pages, but I could see a "How to store compressed data" page being useful for users. Alternatively, we might add something directly to the existing section in the docs (e.g. add something to https://docs.dask.org/en/stable/array-creation.html#zarr for Zarr)

Yeah I think existing section of API docs is best for now.

I can take this task. It should be a good way for me to start contributing and learn about compression stuff.

I've spent some time reading through trying to trace how the compression args get used. I figured it would be useful to at least link to where you could find what compression options are valid, but I'm having trouble finding somewhere that lists out available compressions thats not just buried in the source code somewhere. It is alright to have these be essentially "here is the usage for these args to control compression" and leave figuring out what all the options are to the end user?

@jpaine126 have you checked the available compression args of the underlying libraries? I know that zarr explains them pretty well in their docs


cargo-semver-checks: 0.33.0 -> 0.33.0-unstable-2024-08-04

Description of changes
Reference: #332957

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I will close the PR then, if the maintainer prefers a broken package.

We package plenty of prereleases and this package is about to be broken on master. @matthiasbeyer if you’re unwilling to consider bumping to a Git revision temporarily, would you be able to do the work to backport the Rust 1.80 fixes?

We package plenty of prereleases

I was always told that we do not do this whenever I tried to package something off of a prerelease!
I'd wait until https://github.com/obi1kenobi/cargo-semver-checks/issues/851 is resolved and then update the package like we normally do.

I was always told that we do not do this whenever I tried to package something off of a prerelease!

It's best to avoid where possible, but it's not banned.  We have explicit documentation about how to do it, even.

I was always told that we do not do this whenever I tried to package something off of a prerelease!

Like most things in Nixpkgs, ask two committers, get three opinions 😆
I suspect I’m more cavalier about it than most; I’m happy packaging a prerelease if any of the following are true:

The package is clearly sufficiently dead that we shouldn’t expect another release, but fixes have piled up in the repository since. (Often happens in moribund projects that nonetheless found some time over the years to hit the GitHub merge button on fixes people ran into when trying to keep it going.)

Upstream has in some way indicated that they consider prereleases to be acceptable for users, by explicitly recommending them, offering them as a prominent download on their site without warnings of being unstable, giving the go‐ahead to package the HEAD when asked, or explicitly conveying that they intend to get around to cutting a release of the current state at some point.

Upstream seems active and disciplined (so we can expect their tree to be kept in a good state and there to be a release that gets us back on the train in a timely fashion), it unblocks some Nixpkgs work that matters to me, and a quick glance at the commits since the last release don’t show any major upheavals or other causes for concern.

This counts as 3 to me, but an upstream release would definitely be better, so hopefully we’ll get one soon!

👋 cargo-semver-checks maintainer here 👋 Thanks to everyone here for supporting it in Nixpkgs!
I'll have a new release out shortly.
Thanks for letting me know about the problem with the previous version and Rust 1.80 — I wasn't otherwise aware of it. If you run into any other issues, please give me a ping anytime!
Also, if there's a way to extend the existing cargo-semver-checks publish pipeline to simplify your workflow here, I'd love to chat more and I'd be happy to accept PRs toward that goal!

The new release has finished building and is live now: https://github.com/obi1kenobi/cargo-semver-checks/releases/tag/v0.34.0

Thanks for the fantastic software @obi1kenobi 💜
I don’t think there’s anything in particular that would help Nixpkgs beyond the usual good practices – regular releases with CI assurance that keep on top of new compiler and dependency versions. Anything that’s published via GitHub releases is something we can create automatic update PRs on our end for.
If I had to make a suggestion, it would be to test with the latest nightly compiler in your CI (in addition to your MSRV, of course). That way this issue would have been flagged up earlier and it’s more likely you could have cut a release that works on 1.80 before the final version was released. (And, of course, the same goes for bumping crate dependencies and making sure everything still works after that, but given the nature of the tool I don’t think there’s anything new I could tell you about that!)

(Well, if you could fix the detects_target_dependencies test depending on the network that would be great too, but we’re used to disabling tests that require network access!)

Thanks for the fantastic software @obi1kenobi 💜

Thank you 😊

I don’t think there’s anything in particular that would help Nixpkgs beyond the usual good practices – regular releases with CI assurance that keep on top of new compiler and dependency versions. Anything that’s published via GitHub releases is something we can create automatic update PRs on our end for.

Nice, good to know! cargo-semver-checks is always released only via GitHub Actions and comes with a tag and GitHub release entry, so it should be a good candidate for automation.

If I had to make a suggestion, it would be to test with the latest nightly compiler in your CI (in addition to your MSRV, of course).

This is a bit complicated.
Latest nightly doesn't always pass because the underlying rustdoc JSON format often has breaking changes. Adding support for new formats requires new nightly first, then a new rustdoc-types release (which I don't control and which might be delayed by days/weeks), then new trustfall-rustdoc-adapter and trustfall-rustdoc releases (which I do control) and finally a PR in cargo-semver-checks like this one: https://github.com/obi1kenobi/cargo-semver-checks/pull/852/files
I also think that my automation that auto-applies cargo update weekly might have applied the time dependency upgrade before I noticed it caused breakage. It fixed HEAD automatically, but I didn't know the prior release had issues since the (also automated) process for adding new Rust releases to the CI matrix added 1.80 successfully just a few days prior and nothing seemed to break.
I'm hoping situations like Rust 1.80 + time are quite rare and might not be worth adding more automation around at this time. If we get more than one of these per year, I'll revisit and add even more testing, like "does the latest-release tag still build on all its stated supported Rust versions".

(Well, if you could fix the detects_target_dependencies test depending on the network that would be great too, but we’re used to disabling tests that require network access!)

Unfortunately I think what's using the network there is cargo, not cargo-semver-checks, so it's not an easy fix.
To avoid the network call:

We'd need the relevant async-std version and its dependencies to be part of cargo's cache already.
We'd need that crate's lockfile to be checked in.

I can do the latter. The former sounds like we need to tweak the Nixpkgs build step, and I'm not sure how to do that.
Also not particularly sure if it's worth doing — I doubt that test can be broken unless you do extensive source-level patching of cargo-semver-checks which I don't think Nixpkgs is likely to need anytime soon.

As an aside, I'm surprised to see these two tests get disabled on account of needing a nightly feature:
https://github.com/NixOS/nixpkgs/pull/334394/files#diff-d2b351bdb69433869ad57b52513b4b8972d754a86658fbcca2e46b960876c2d9R39-R41
I don't think any of our tests require nightly, and in fact our CI runs all tests on all supported Rust versions. So, maybe worth another look at some point?

Opened https://github.com/NixOS/nixpkgs/pull/334718 for the bump.

This is a bit complicated.
Latest nightly doesn't always pass because the underlying rustdoc JSON format often has breaking changes. Adding support for new formats requires new nightly first, then a new rustdoc-types release (which I don't control and which might be delayed by days/weeks), then new trustfall-rustdoc-adapter and trustfall-rustdoc releases (which I do control) and finally a PR in cargo-semver-checks like this one: https://github.com/obi1kenobi/cargo-semver-checks/pull/852/files
I also think that my automation that auto-applies cargo update weekly might have applied the time dependency upgrade before I noticed it caused breakage. It fixed HEAD automatically, but I didn't know the prior release had issues since the (also automated) process for adding new Rust releases to the CI matrix added 1.80 successfully just a few days prior and nothing seemed to break.
I'm hoping situations like Rust 1.80 + time are quite rare and might not be worth adding more automation around at this time. If we get more than one of these per year, I'll revisit and add even more testing, like "does the latest-release tag still build on all its stated supported Rust versions".

Okay, it sounds like you’ve thought this through pretty thoroughly! I’m wondering if having non‐blocking CI for nightly compilers might still be a net positive here, though? I assume you keep on top of rustdoc changes anyway, so the notification of those probably wouldn’t do you much good, but it’d help flag up issues like this.
Though, yes, I agree: 1.80 has been awful and I hope that the Rust team don’t make a habit of this kind of thing.

I can do the latter. The former sounds like we need to tweak the Nixpkgs build step, and I'm not sure how to do that.
Also not particularly sure if it's worth doing — I doubt that test can be broken unless you do extensive source-level patching of cargo-semver-checks which I don't think Nixpkgs is likely to need anytime soon.

Gotcha. We’re fine with disabling network‐dependent tests; it happens all the time.

As an aside, I'm surprised to see these two tests get disabled on account of needing a nightly feature: https://github.com/NixOS/nixpkgs/pull/334394/files#diff-d2b351bdb69433869ad57b52513b4b8972d754a86658fbcca2e46b960876c2d9R39-R41
I don't think any of our tests require nightly, and in fact our CI runs all tests on all supported Rust versions. So, maybe worth another look at some point?

You’re right; these pass now. I’ve re‐enabled them in the new PR.
I’ve also opened https://github.com/obi1kenobi/cargo-semver-checks/issues/855 for the one remaining nit I can see in terms of what would make the packaging story for us easier. Thank you again for taking the time to ask about our packaging and being open to improvements! I would say you’re already doing a stellar job as an upstream :)

Thanks for the useful suggestions! I appreciate you thinking this through with me, and I'm happy to do what I can to make your work easier :)

I’m wondering if having non‐blocking CI for nightly compilers might still be a net positive here, though? I assume you keep on top of rustdoc changes anyway, so the notification of those probably wouldn’t do you much good, but it’d help flag up issues like this.

That's pretty much the exact current setup:

I get GitHub-mentioned whenever anyone opens a PR that includes changes to rustdoc JSON, so I always have ~one day's notice of any format changes before they appear in nightly.
cargo-semver-checks runs nightly Rust tests but doesn't block if they fail.

While I'm sure there are improvements one could make from here, it feels like there's nothing easy and obvious remaining — we seem to have picked all the low-hanging fruit here.

You’re right; these pass now. I’ve re‐enabled them in the new PR.

Yay, nice! If you find that tests are failing for you in the future and it isn't purely a network issue, please feel free to ping me on the relevant PR or issue. I'd be happy to look and make sure it isn't some unfortunate Heisenbug.
I'm taking a look at the new issue you opened now, and will chat more there.

Thank you again for taking the time to ask about our packaging and being open to improvements! I would say you’re already doing a stellar job as an upstream :)

Of course, thank you for all the work you've been doing — I appreciate it!


Tree: Data flow diagram (WIP)

Data flow diagram for new SharedTree DDS.
Committing work-in-progress so that @CraigMacomber can iterate on it.

@CraigMacomber - To save yourself the trouble of checking out my branch, feel free to push the merge button.

I think the dataflow diagrams in the https://github.com/microsoft/FluidFramework/tree/main/packages/dds/tree#data-flow cover this now.


Cleanup conf.py and use released RTD template css

This is a follow-up of #82
I removed unused extensions in conf.py, and removed the local rtd_theme. Now the theme is working properly in my opinion, e.g., compare the copybutton rendering or the icons in the navigation bar

@mergifyio backport humble


Unable to download the miniconda while using IJulia

Hello, I wanna using IJulia in the Jupyter Notebook
julia> using IJulia
julia> IJulia.notebook()
install Jupyter via Conda, y/n? [y]: y**
[ Info: Downloading miniconda installer ...
So, sad. No response to this command, I have been waiting for 1 hour.............
Pls help me!!!!!!!!!!Thank you so much.

Presumably you have some kind of firewall on your machine that is blocking the download?
In any case, this is actually the Conda.jl package.   You should get the same error (after running pkg> add Conda at the package prompt) from
import Conda
Conda.add("jupyter")

If you can't figure out your download problems, you could ask on Julia discourse.
Alternatively, you can just install Jupyter yourself, e.g. by downloading Anaconda Python or some other Python distro.


How can I make the day's border act like a progress?

I'm trying to make the cell's border similar to a progress. Is this possible?
I'm thinking of either adding a layer on top of the border. Where the default border color is gray, and I add a new border to the cell's border frame.
OR
Can we set a custom border to each cell? This way I can create my own layer.
Example:

Hi @jongrio did you find a way to do this?