AzureCloudPowerShellDeployment Task Silently Fails

Type: Question or Bug
Enter Task Name: AzureCloudPowerShellDeployment@1
Environment

Server - Azure Pipelines
Agent - Hosted

Issue Description
We are having the task silently fail, meaning that the task completes and appears to run, but the cloud service deployment doesn't happen. There are no errors. We noticed the SilentlyContinue switch -- is there a way to override that? Has anyone else troubleshoot anything like this before?
Task logs
Starting: Deploy XXX.cspkg
==============================================================================
Task         : Azure Cloud Service deployment
Description  : Deploy an Azure Cloud Service
Version      : 1.171.2
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-cloud-powershell-deployment
==============================================================================
Import-Module -Name C:\Modules\azure_2.1.0\Azure\2.1.0\Azure.psd1 -Global
Set-AzureSubscription -SubscriptionName on10.net -SubscriptionId XXX -Certificate ******** -Environment AzureCloud -CurrentStorageAccountName XXX
Select-AzureSubscription -SubscriptionId XXX
Set-AzureSubscription -SubscriptionId XXX -CurrentStorageAccountName XXX
Finding d:\a\1\XXX\ServiceConfiguration.Cloud.cscfg
serviceConfigFile= d:\a\1\XXX\ServiceConfiguration.Cloud.cscfg
Find-VstsFiles -LegacyPattern d:\a\1\XXX\XXX.cspkg
servicePackageFile= d:\a\1\XXX\XXX.cspkg
Get-AzureService -ServiceName XXX-ErrorAction SilentlyContinue  -ErrorVariable azureServiceError
Get-AzureDeployment -ServiceName XXX -Slot Staging -ErrorAction SilentlyContinue -ErrorVariable azureDeploymentError
Set-AzureDeployment -Upgrade -ServiceName XXX
-Package d:\a\1\XXX\XXX.cspkg -Configuration d:\a\1\XXX\ServiceConfiguration.Cloud.cscfg -Slot Staging -Label 20200728.9 -ExtensionConfiguration <extensions>
Finishing: Deploy XXXX.cspkg

It turned out there was a misconfiguration on our end. Regardless, it would be nice if this task didn't have the SilentlyContinue switch on, or if it could be toggled by those using the task.


Removed cocoapods warning about license file

Hi Kiran!
I added the extension to the license file to remove the warning was giving cocoapods

Phew! Thanks for taking care of that, @matteonovelli! :+1:


Consider upgrading to latest jslint

The jslint API seems to be changing a lot, which is why I haven't upgraded it very often.
But the bundled version is missing eqeq which is a bummer. Also, we're still on a 0.1 version, so breaking stuff in the name of progress should be acceptable.

In the past I've used eqeqeq: false to ditch the silly "only triple equals" rule, but that didn't work (both eqeqeq and eqeq, in both the files and in the config file)

I guess I'm only reluctant because it will cause massive breakage. The ruleset has changed so much. But better get with the program and upgrade.
Think I'll switch from a .json config file to a proper node module at the same time.

Awesome. That was another thing I thought "would've been nice"

That being said, I don't agree with the triple equals being silly.  Just the fact that JS has an equals operator that isn't transient is staggering.
I've personally lost several hours to a bug caused by it. The main problem? I had already considered the case. I had a test covering that case. And that test was passing.
Type coercion is not your friend. Don't let habit stand in the way of doing things better.

Fixed in upgrade to 1.0.0.


updated readme

Signed-off-by: Peter ONeill<EMAIL_ADDRESS>

@tsandall I've added your suggestions, except the for adding a new diagram, but I have created an issue to track that request. PTAL when you have a chance.
https://github.com/StyraInc/opa-aws-cloudformation-hook/issues/27


perplexity model checks

Add checks in perplexity.celda_C/G/CG to check correct model type was used

Fixed in #352


Link reference definition ended with backslash

[a]: u\
foo

should imho be translated into

foo

but it gets an empty output. Maybe the parser wrongly escapes the new-line?
(Might be related to #287. See also https://github.com/commonmark/commonmark-spec/issues/583)

Thanks for flagging this! :bowing_man:


Fixes #81: Added the version to the kafkaHQ UI from the git property file

Hi,
In order to fix #81,
As we have the tag info into the git.properties, I've used it to display a version info on the ui.
Here is the result (It displays Snapshot if you're not on a tagged branch) :

Sadly, we can't reuse the GitInfoSource class used by the info endpoint because it has a @Requires(beans = InfoEndpoint.class) annotation.
The git.properties can't be called just by using a @Value.
I've watched the GitInfoSource code and made a short version provider that read only one time the tag info and set it.
What do you think ?
Oh and if you want the tag anywhere else instead of there, just tell me, it's just a proposal

Seems to be perfect, also try quickly to reuse micronaut endpoint but I can't catch quickly the way !
I think It's fine to own GitInfoSource !


Please include in the documentaion about Domain Joind Machines Behaviour

Please mention the following details in the docuemnt.

Any fresh install of Windows 10 Creators updater higher will not support sync functionality of its under an Active Directory (but works for Azure AD).

https://www.itwire.com/the-wired-cio/79531-microsoft-breaks-windows-10-microsoft-account-sync-for-corporates.html

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ce750351-c450-13d2-db04-3df88a4f4a9c
Version Independent ID: de9bf9a8-c50f-52ef-6d92-e0ad69d4450e
Content: New Microsoft Edge Group Policies and MDM settings
Content Source: browsers/edge/new-policies.md
Product: edge
GitHub Login: @shortpatti
Microsoft Alias: pashort

@vibeeshan025, thank you for the feedback and details to add to the content.  I added it to the FAQ.


Fix for network.AggregateInterface path issues

Fixed incorrect paths in network.AggregateInterface based more or less on network.EthernetInterface.
Added enable_lacp option to turn on LACP.
Added lacp_passive_pre_negotiation to enable Passive Pre-Negotiation.
Added conditions based on what was in network.EthernetInterface.

Resolved issues from review.


Update v1.1

Feedback regarding the latest update. First of all, well done for changing the sound font option to the first menu slot, this definately makes sense in terms of changing configs quickly and will certainly help to impress users/people. My recommendation would be to put the volume option in the second position as my wife constantly tells me to keep noise down, especially when the kids are asleep.
I'm still having problems with the swing sensitivity option though. Below a certain threshold i don't hear any hum. Just above this threshold i hear distortion, hum starts and rapid successive swing triggers. After a few more clashes, the hum stops, the clashes no longer work but button presses still do. Shortly after this the board restarts and volume is pretty much set to full

To address the Config menu order, you can change this yourself.  I just moved my Battery Level to First, then Sleep Next, and so on.  Just my Preference.  Anyways under the ConfigMenu.h  is where you change the order.  Compare mine to yours and you will see how easy it is to change around.

Thanks Argathena, you said all what had to be said. This setting will be the next one I'm going to write a how-to in the Wiki. Totally crazy, orignally LSOS did not have the sensitivity setting, simply because the setting which was had coded worked so well it was not needed to change it. Then I had a short moment of craziness and implemented a new config item, now many people ask me how it works.

Closing


Revert dox42 Custom Connector to Previous version

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[x] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[x] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[x] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[x] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

This commit will revert the dox42 connector, so the correct version can be imported in the "Custom Connectors" section. The official dox42 connector was only commited here to speed up the certification process.


encoding failures (Encoding::InvalidByteSequenceError)

Using this Dockerfile:
https://github.com/joshuacox/ddd
I get the following error:
/opt/chef/embedded/lib/ruby/2.1.0/json/common.rb:155:in `encode': "\xE2" on US-ASCII (Encoding::InvalidByteSequenceError)

This appears to be maybe the same issue as seen here:
https://github.com/chef-cookbooks/mysql/issues/279
I have reproduced using both jessie and wheezy:
https://registry.hub.docker.com/u/joshuacox/docker-chef-solo/
Using openssl (2.0.2) from git://github.com/opscode-cookbooks/openssl.git (at master)                                                                                [98/4239]
Using php (1.5.0) from git://github.com/opscode-cookbooks/php.git (at master)
Using pacman (1.1.1) from git://github.com/jesseadams/pacman.git (at master)
Installing rbac (1.0.2) from https://api.berkshelf.com ([opscode] https://supermarket.chef.io/api/v1)
Using postgresql (3.4.14) from git://github.com/hw-cookbooks/postgresql.git (at master)
Installing smf (2.2.1) from https://api.berkshelf.com ([opscode] https://supermarket.chef.io/api/v1)
Using vdd (0.0.0) from git://github.com/joshuacox/vdd-cookbook.git (at master)
Using vdd_example (0.0.0) from git://github.com/joshuacox/vdd_example-cookbook.git (at master)
Using windows (1.36.1) from git://github.com/opscode-cookbooks/windows.git (at master)
Using xfs (1.1.0) from git://github.com/opscode-cookbooks/xfs.git (at master)
Using xml (1.2.9) from git://github.com/opscode-cookbooks/xml.git (at master)
Installing yum (3.5.2) from https://api.berkshelf.com ([opscode] https://supermarket.chef.io/api/v1)
Installing yum-epel (0.6.0) from https://api.berkshelf.com ([opscode] https://supermarket.chef.io/api/v1)
Installing yum-mysql-community (0.1.11) from https://api.berkshelf.com ([opscode] https://supermarket.chef.io/api/v1)
/opt/chef/embedded/lib/ruby/2.1.0/json/common.rb:155:in `encode': "\xE2" on US-ASCII (Encoding::InvalidByteSequenceError)
        from /opt/chef/embedded/lib/ruby/2.1.0/json/common.rb:155:in `initialize'
        from /opt/chef/embedded/lib/ruby/2.1.0/json/common.rb:155:in `new'
        from /opt/chef/embedded/lib/ruby/2.1.0/json/common.rb:155:in `parse'
        from /opt/chef/embedded/lib/ruby/gems/2.1.0/gems/ridley-4.1.2/lib/ridley/chef/cookbook/metadata.rb:473:in `from_json'
        from /opt/chef/embedded/lib/ruby/gems/2.1.0/gems/ridley-4.1.2/lib/ridley/chef/cookbook/metadata.rb:29:in `from_json'
        from /opt/chef/embedded/lib/ruby/gems/2.1.0/gems/ridley-4.1.2/lib/ridley/chef/cookbook.rb:36:in `from_path'
        from /opt/chef/embedded/lib/ruby/gems/2.1.0/gems/berkshelf-3.2.3/lib/berkshelf/cached_cookbook.rb:15:in `from_store_path'
        from /opt/chef/embedded/lib/ruby/gems/2.1.0/gems/berkshelf-3.2.3/lib/berkshelf/cookbook_store.rb:86:in `cookbook'
        from /opt/chef/embedded/lib/ruby/gems/2.1.0/gems/berkshelf-3.2.3/lib/berkshelf/cookbook_store.rb:67:in `import

that's really weird... I looks like its crashing after resolving yum-mysql-community, just like #279.
I did published a 0.1.12 version of that cookbook just in case there was some weird artifact corruption going on.
Can you try again and let me know if this persists?
-s

I do believe it picked up your 0.1.12 version, as seen below, but the problem indeed persists.  Though it only seems to persist in the docker environment, when I berks vendor locally on my debian jessie laptop everything appears fine.  There might be a version  mismatch in that case though, I'm going to update ruby etc here on this laptop to emulate the same conditions.
Installing yum-mysql-community (0.1.12) from https://api.berkshelf.com ([opscode] https://supermarket.chef.io/api/v1)
/opt/chef/embedded/lib/ruby/2.1.0/json/common.rb:155:in `encode': "\xE2" on US-ASCII (Encoding::InvalidByteSequenceError)

I tracked it down to UTF-8 not actually being gen'd on the docker image yet.  I've updated my docker images accordingly, those interested can see the lines below.
RUN apt-get -y install locales
RUN echo 'en_US.UTF-8 UTF-8'>>/etc/locale.gen
RUN locale-gen
ENV LANG en_US.UTF-8

Thanks for tracking this down!
On Wed, Jan 21, 2015 at 10:47 AM, Josh Cox<EMAIL_ADDRESS>wrote:

Closed #286 https://github.com/chef-cookbooks/mysql/issues/286.
—
Reply to this email directly or view it on GitHub
https://github.com/chef-cookbooks/mysql/issues/286#event-222394258.

I appreciate the quick response as well from you, hopefully @eriksenonline in https://github.com/chef-cookbooks/mysql/issues/279 has worked around his issue as well.


PyVelox requires root permission?

Problem description
I'm trying pyvelox for the very first time and when I try to run "make python-build", it fails because it tries to install something in a system directory. While running as root would probably fix it, should this installed in a local directory instead by default?
Error output:
pedroerp@homer:~/Sandbox/velox$ make python-build
DEBUG=1 /usr/bin/python setup.py develop
-- Building version 0.0.1a0+ce5c0ad
running develop
error: can't create or remove files in install directory

The following error occurred while trying to add or remove files in the
installation directory:

    [Errno 13] Permission denied: '/usr/local/lib/python3.8/dist-packages/test-easy-install-55329.write-test'

The installation directory you specified (via --install-dir, --prefix, or
the distutils default setting) was:

    /usr/local/lib/python3.8/dist-packages/

Perhaps your account does not have write access to this directory?  If the
installation directory is a system-owned directory, you may need to sign in
as the administrator or "root" account.  If you do not have administrative
access to this machine, you may wish to choose a different installation
directory, preferably one that is listed in your PYTHONPATH environment
variable.

System information
Velox System Info v0.0.2
Commit: ce5c0ad931c6046de33ea2206efca76dcfa0bd25
CMake Version: 3.16.3
System: Linux-5.4.0-136-generic
Arch: x86_64
C++ Compiler: /usr/bin/c++
C++ Compiler Version: 9.4.0
C Compiler: /usr/bin/cc
C Compiler Version: 9.4.0
CMake Prefix Path: /usr/local;/usr;/;/usr;/usr/local;/usr/X11R6;/usr/pkg;/opt
CMake log
No response

Hi Pedro,
Can you run ./setup-ubuntu.sh ? This will install conda on your machine.
Then do the following :
 conda create --name pyvelox python==3.7
 conda activate pyvelox

You might need to resource your shell if you are activating conda for first time.
Typically in the python , you always build with a venv or conda env etc, and we install pyvelox in this local env (you can also install in system env - which is default python, but thats rarely done, due to permission issues like above).
I will also make a change to check for some sort of virtualenv when doing the install.


Payment error: PosId is empty (0)

Hi. I install the plugin
In admin panel i felt fields for PLN
And after chekout i get error
Payment error: PosId is empty (0)

Close this issue
This error appears when also installed WPML plugin and enabled multi currency
All PayU fields need to be filled


Add authentication tests

I'm spending quite a long time on these tests, and I'd like to get some early feedback on:
1- do we even need this kind of tests?
2- is the style ok?
About the need for these tests
The main reason we started looking into authentication tests was to make sure we are actually enforcing permissions and policies check on our endpoints.
However, the more I write them the more I have two doubts that seems smells of bad tests to me:
a- we are basically testing a config (did we place the correct action in the auth config?)
b- the special cases would be better suited as unit tests for the auth middleware (i.e. the teams case) or for aim-js (wildcards)
I still find some value in these tests because:
a- I don't think we are actually testing a config as per point a, because there could be multiple configurations that lead to the correct results and we just need to check if everything works correctly (in an extreme case, a part of the authentication could be moved inside the action instead of the auth middleware and the tests would still work)
b- we are using special cases but we are not actually testing them: we are checking that the chosen authorisation supports all the cases we need
Let me know your thoughts

Hi @paolochiodi

I don't think we are actually testing a config as per point a [...]

I agree these tests are needed, but having a 2000 lines test file may quickly become unreadable.
One way to overcome this issue and keeping all the tests:

create one set of fixtures only for these tests that will be loaded in the before function
create an helper function that will make explicit: who is calling and what he is calling (we may not need this)

That said, I think we may also want to reduce the number of tests by removing those that can be part of a unit test or those that "duplicates" a behaviour (here VS here)
My idea would be to have tests covering all our endpoints, without testing all possible combination of actions/resources.

I, too, don't like how long and verbose these tests are, and like @nherment's idea of using some kind of framework or domani language to extract the duplicated code and simplify the code.
Same goes for @mihaidma idea of simplify the creation of the initial content. I would like to use some kind of framework here too, but this is more complex because cases are more diverse and nuanced.
I'll timebox some time on this before moving further ahead with other endpoints

I incorporated the factory and new test framework and update the PR. I've also removed the WIP and  do not merge labels as I'm interested in merging this early in order to make the Factory and new test framework available.
In the meantime I'll continue to add tests for other endpoints

@paolochiodi could you squash the commits? thanks!


Binance support

I have a question. When will binance support come into this bot?

@pbajno You and I can add in the relevant code to allow access to the API method seeing as we both would want this to be a thing?

It's already supported, see the list-selectors command.
I dumped the output for it here.
https://gist.github.com/Prophet731/ae7cef0299390457f27008ad719f6529

Thanks @Prophet731, this issue can be closed then.


Add desc according updates in 3.1.9

Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.9 out of 10 committers have signed the CLA.:white_check_mark: srlch:white_check_mark: TszKitLo40:white_check_mark: rickif:white_check_mark: GavinMar:white_check_mark: Seaven:white_check_mark: xiangguangyxg:white_check_mark: hellolilyliuyi:white_check_mark: evelynzhaojie:white_check_mark: starrocks-xupeng:x: mergify[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


Build fails for generator "Visual Studio 11 2012"

I think it should be possible to build with Visual Studio 2012.

Does anybody know how I can compile with Visual Studio 2012? It looks like I have the compiler under C:\Program Files (x86)\Microsoft Visual Studio 11.0\VC\bin, but when I call vcvarsall.bat x86 I get errors and the VS110COMNTOOLS environment variable is misteriously unset.
I tried to download Visual Studio Express 2012 from the microsoft page, but the page seems to be buggy, it does not stop reloading and hitting the download links does nothing.

https://github.com/ruslo/hunter/blob/v0.23.214/README.rst


Don't clear select on click

Hi - great product - I'm trying to make this work within my project but i don't want the user to remove the selected item when click - only when the open the box and then deselect the selected item should it be cleared. I was trying to set the options "Clearable" and "Clear on Select" to  false so that this doesn't happen
<treeselect :multiple="true"
:clearable= false
:clearOnSelect= false
:options="groups"
:searchable="false"
:default-expand-level="1"
:value-consists-of="valueConsistsOf"
:placeholder="selectItemPlaceholder"
:value="selectedDividedGroupIds"
:hide-selected="true"
@input="updateValue"
/>
Can you please let me know if there is anything I can try to not have the behavior where if the user clicks on the selected item in the vue-treeselect__multi-value-item-container - that is doesn't remove itself - I have styled the X as display none?
I have attached a 19sec video clip trying show visually what I mean - so after selecting the item not being able to remove the item unless opening the dropdown and de-selecting the selected option and not as in the video also in the multi-value-item-container?
vuetreeselect.zip

hi  friend are u resolve this problem or not yet ?

you can write your own "value-label" slot, and stop event bubling, like this :

@riophae This is still relevant. The problem is that onMousedown is hardcoded on the multi-value-item div and no flag is provided to stop this click.
onMousedown={this.handleMouseDown} @ MultiValueItem.vue component.
I think a simple prop like preventSelectedValueClick with bool value should do the trick.
If true then prevent Deselect inside the handleMouseDown method.


dbeaver/dbeaver#546 Handle missing notifications

Acceptance criteria:

[x] Scheduling a task should not cause any errors

Verified


Docs.MS CI Updates for Microsoft.Azure.ServiceBus

Docs.MS CI Updates for Microsoft.Azure.ServiceBus

Docs Build status updates of commit cb7fbf8:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-PublishConfigFileNotFound] Publish service's config file: .openpublishing.publish.config.json is not found. Exception:

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Microsoft.Azure.ServiceBus does not require .net standard 2.0. Doesn't need this update.


prevent events bubbling to nested drag containers?

I have a drop handler on my document body for drag-to-browser uploads, and the Sortable list is inside that. How can I prevent Sortable element drags from also triggering events on the upload handler? I only want events inside the Sortable parent object to bubble to that object, but no further. In jQueryUI this seems to be automatic.

In case anyone else happens across this, in my case I was able to check the event on the parent's drag handlers (e.g. drag enter, drop, etc) and exit if (e.dataTransfer.effectAllowed == "move") return. 'move' is being set by Sortable, whereas browser drop actions like dropping a URL or file will set the effectAllowed to "all".


Support custom glob pattern for matching git tags.

Resolves #6.
Introduced a new tagFilter config for git-tag matching based on custom glob pattern.
By default app-versioning uses the latest tag in the current branch for versionCode and versionName generation. Sometimes it's useful to be able to use the latest tag that follows a specific patterns (e.g. when multiple APKs are being built from the same codebase, each with its own versioning metadata).
To find the latest tag with appA as the SemVer build metadata:
appVersioning {
  tagFilter.set("[0-9]*.[0-9]*.[0-9]*+appA")
}

@Wrywulf I'm merging this and doing a release. Please let me know if it works for you when you get a chance to try this 😃


Decide on Sync

We need to figure out the ergonomics around Sync for !Sync types. See also the conversation about it in send-cell: https://github.com/sdroege/send-cell/issues/4

From my understanding it should be safe to always implement Sync as in the end the contained value can only ever be accessed from a single thread. What we have here conceptually is like a recursive mutex that panics if not locked from its original thread.

I think there is truth to this. I can't think of a reason right now why it can't be Sync.

Do you remember why you did https://github.com/mitsuhiko/rust-fragile/commit/96f799deb258a6e2ec8db09e409e6a3f00c03246 ?

I wanted to release the library for public consumption and did not want to give a guarantee I cannot hold later if it turns out to be unsound.

I agree that implementing Sync for arbitrary T is sound as far as Rust's soundness model goes, but I think that, with my ergonomics hat on, it goes against the spirit of Sync. The doc for Sync says that Sync marks "types for which it is safe to share references between threads." When I have a thing that is Sync + Clone, I have the expectation that calling .clone() on different threads will not only be sound, but it also won't panic. That's just my general expectation for a thing that is Clone. clone() is not something that I would expect to ever panic, esp. when writing a generic function with a T: Clone bound.
What I would like is for Fragile<T> etc. to be Sync, but for the other trait implementations to be gated on the traits implemented by T. For example, Debug can always be implemented because it never panics, but Clone should only be implemented for T: WrapperClone with WrapperClone as suggested here. I don't know what to do with Ord, Eq, and Display in this situation, but I'm not sure what the usecases for these trait implementations are.


Implement local SLAM subscriptions in MapBuilderServer

@wally-the-cartographer merge

Merge requested by authorized user gaschler. Merge queue now has a length of 1.


Can't build my flutter application after migrating it usin gandroid studio

Flutter crash report; please file at https://github.com/flutter/flutter/issues.
command
flutter build bundle --suppress-analytics --target C:\Users\Cyber5\AndroidStudioProjects\ahunplay\lib\main.dart --filesystem-scheme org-dartlang-root --track-widget-creation --compilation-trace-file compilation.txt --depfile C:\Users\sdf\AndroidStudioProjects\ahunplay\build\app\intermediates\flutter\debug/snapshot_blob.bin.d --asset-dir C:\Users\Cyber5\AndroidStudioProjects\ahunplay\build\app\intermediates\flutter\debug/flutter_assets --debug
exception
FileSystemException: FileSystemException: Deletion failed, path = 'C:\Users\Cyber5\AndroidStudioProjects\ahunplay\build\app\intermediates\flutter\debug/flutter_assets' (OS Error: The directory is not empty.
, errno = 145)
#0      _Directory._deleteSync (dart:io/directory_impl.dart:206:7)
#1      FileSystemEntity.deleteSync (dart:io/file_system_entity.dart:466:47)
#2      ForwardingFileSystemEntity.deleteSync (package:file/src/forwarding/forwarding_file_system_entity.dart:72:16)
#3      writeBundle (package:flutter_tools/src/bundle.dart:232:15)
<asynchronous suspension>
#4      assemble (package:flutter_tools/src/bundle.dart:223:9)
<asynchronous suspension>
#5      build (package:flutter_tools/src/bundle.dart:156:9)
<asynchronous suspension>
#6      BuildBundleCommand.runCommand (package:flutter_tools/src/commands/build_bundle.dart:75:11)
<asynchronous suspension>
#7      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:559:18)
<asynchronous suspension>
#8      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:495:33)
<asynchronous suspension>
#9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142:29)
<asynchronous suspension>
#10     _rootRun (dart:async/zone.dart:1124:13)
#11     _CustomZone.run (dart:async/zone.dart:1021:19)
#12     _runZoned (dart:async/zone.dart:1516:10)
#13     runZoned (dart:async/zone.dart:1463:12)
#14     AppContext.run (package:flutter_tools/src/base/context.dart:141:18)
<asynchronous suspension>
#15     FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:486:20)
#16     CommandRunner.runCommand (package:args/command_runner.dart:196:27)
<asynchronous suspension>
#17     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:396:21)
<asynchronous suspension>
#18     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142:29)
<asynchronous suspension>
#19     _rootRun (dart:async/zone.dart:1124:13)
#20     _CustomZone.run (dart:async/zone.dart:1021:19)
#21     _runZoned (dart:async/zone.dart:1516:10)
#22     runZoned (dart:async/zone.dart:1463:12)
#23     AppContext.run (package:flutter_tools/src/base/context.dart:141:18)
<asynchronous suspension>
#24     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:356:19)
<asynchronous suspension>
#25     CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:111:29)
#26     new Future.sync (dart:async/future.dart:224:31)
#27     CommandRunner.run (package:args/command_runner.dart:111:11)
#28     FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:242:18)
#29     run.<anonymous closure> (package:flutter_tools/runner.dart:60:20)
<asynchronous suspension>
#30     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:142:29)
<asynchronous suspension>
#31     _rootRun (dart:async/zone.dart:1124:13)
#32     _CustomZone.run (dart:async/zone.dart:1021:19)
#33     _runZoned (dart:async/zone.dart:1516:10)
#34     runZoned (dart:async/zone.dart:1463:12)
#35     AppContext.run (package:flutter_tools/src/base/context.dart:141:18)
<asynchronous suspension>
#36     runInContext (package:flutter_tools/src/context_runner.dart:50:24)
<asynchronous suspension>
#37     run (package:flutter_tools/runner.dart:51:10)
#38     main (package:flutter_tools/executable.dart:60:9)
<asynchronous suspension>
#39     main (file:///C:/b/s/w/ir/k/archive/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3)
#40     _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:298:32)
#41     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:171:12)

flutter doctor
[✓] Flutter (Channel stable, v1.5.4-hotfix.2, on Microsoft Windows [Version 6.1.7601], locale en-US)
    • Flutter version 1.5.4-hotfix.2 at C:\flutter
    • Framework revision 7a4c33425d (4 weeks ago), 2019-04-29 11:05:24 -0700
    • Engine revision 52c7a1e849
    • Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\Cyber5\AppData\Local\Android\sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    ! Some Android licenses not accepted.  To resolve this, run: flutter doctor --android-licenses

[✓] Android Studio (version 3.4)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 35.3.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] VS Code, 64-bit edition (version 1.34.0)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.0.2

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.1.0 (API 27) (emulator)

! Doctor found issues in 1 category.

Hi @ahunplay
are you still experiencing this issue with the latest version of Flutter?
If so can you please provide your flutter doctor -v?
Also, to better address the issue, would be helpful
if you could post a self contained app on github
or the steps to reproduce it.
Thank you

Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.


Export of structurizr person shape using dot format

When I use the CLI (v1.18.0) to export the demo workspace Big Bank into dot using structurizr-cli export -w demo.dsl -f dot and render the resulting dot file using Graphvis Online I cannot find any shape for Persons.
In contrast, Structurizr Online-Service renders the System Context and its Person Shape as expected.
Is there any way to export shapes to dot?

demo.dsl.txt
structurizr-SystemContext.dot.txt

As far as I'm aware, there's no person shape available via Graphviz/DOT unfortunately -> https://graphviz.org/doc/info/shapes.html


Please tag a new stable release if the master branch is in a good state

Hi,
I noticed that there have been 100 commits or so since the last tagged release (v1.5.0).  Would you please tag a new stable release if the master branch is in a good state?
Thanks!

We bumped the version in 3273fcece5d9ab7edd4f15b2d6bce61f4e5a0666 but unfortunately forgot to push the new tag. I've just pushed it.

We bumped the version in 3273fcece5d9ab7edd4f15b2d6bce61f4e5a0666 but unfortunately forgot to push the new tag. I've just pushed it.

Ah, it happens!  Thank you for the tagged released--much appreciated.


Dynamic programming

I would like to document 0-1 Knapsack problem using dynamic programming techniques along with time and space complexity.This repository contains knapsack using greedy programming technique but not dynamic programming.Could I work on this issue?

ok, sure 👍

Assigned you. Welcome to the team ! 😃

I am closing this. 😄 . Open if any updates


Made some minor modifications to the documentation to clarify some aspects a bit more

Hi Jeff,
here's my proposal for some documentation changes.
If you're up for it, I can also put every sentence on its own line in the .rst files. This will minimise the git diffs in future changes to the documentation.
It might also be interesting to add a Makefile to the /docs directory to generate the documentation with a simple make command. I can do that too, if interested.

Thank you!  These are all good improvements.
Wow.  Who knew there were that many typos in my original?  It always helps to have a second set of eyes look over one's writing.
I've just added a docs environment to the top-level tox.ini which builds the HTML docs (with "nit-picky mode" enabled).
tox -e docs

should now build the docs, with output in .tox/docs/tmp/html_docs.  (I've just pushed that to master.)
That should obviate some of the need for a Makefile.  If you'd still like to add a simple one, go ahead.

Here are some extra additions to the PR.
I think the addition to tox.ini is more elegant than the proposed Makefile-solution, so I dropped that. :-)

This is excellent!  Thank you very much.

my pleasure!


Create preview refactoring

We need to have a way to create preview environments based on git hashes instead of pull requests. Because of this the existing commands create-preview and delete-preview were refactored. They are now independent of pull requests. The new commands to use for pull request preview environments are now create-pr-preview and delete-pr-preview.

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

v4.0.0
GitHub release

Your semantic-release bot :package::rocket:


fixed issue#561-Making phone numbers mandatory for adding relief camp

Issue Reference
This PR addresses the Issue : Fixes #561
Making phone numbers mandatory for adding relief camp

Not a IT mission requirement


specjbb parser parses N/A metrics gracefully

ADO task: https://msazure.visualstudio.com/One/_workitems/edit/28695307

Do we still need this? Can I close it?

Closing. Please reopen as needed.


Can you guide the process of the front -end connection?

The back -end API service looks normal, but I don't know how to connect to the front end.

The backend is close-sourced. and this frontend seems to be already connected to it. I have run out of OpenAI credits which will make the requests fail.

I deployed the GPT4-API service. Can I connect through the GPT4-website?

Yes.
API
The API source code is in the link above, check in the constants file inside the ùtils`folder and update the API URL to match where you deployed it.


Error in eidos_reader

Such an error is reported before, but I still have no idea what causes such an error.
I'm simply running the example below from the documentation:
from indra.sources import eidos
ep = eidos.process_text("Water trucking has decreased due to the cost of fuel.")

And I get the following error:
jnius/jnius_export_class.pxi in jnius.JavaClass.__init__()

jnius/jnius_export_class.pxi in jnius.JavaClass.call_constructor()

jnius/jnius_conversion.pxi in jnius.populate_args()

jnius/jnius_utils.pxi in jnius.check_assignable_from()

JavaException: Invalid instance of 'java/lang/Object' passed for a 'org/clulab/wm/eidos/EidosComponents'

I followed all the instructions and I have no problem using other classes from INDRA, I think this is just Eidos related. Any idea?

Hi @phosseini, I'm pretty sure that this has to do with your versions of Eidos and INDRA being out of sync. Try to make sure that you have the latest Eidos packaged as a JAR, and INDRA installed from Github (i.e., pip install git+https://github.com/sorgerlab/indra.git).
Having said that, an alternative way of using Eidos via INDRA is as a web service. You can follow the README instructions on running and Eidos webapp, and then do something like:
from indra.sources import eidos
eidos.process_text(text, webservice=<address of local Eidos web service>)

This avoids code-level dependencies between the two systems.

The mention of EidosComponents makes me think that there's a mismatch in the call to the EidosSystem constructor, which was recently changed.  I think this has been tested, though.  Something calling the old def this(x: Object) = this() might do it, so I think that Ben is probably correct.
class EidosSystem(val components: EidosComponents) {
  // The constructor below will take cheap to update values from the config, but expensive
  // values from eidosSystem.components, if present  It is the new reload().
  def this(config: Config, eidosSystemOpt: Option[EidosSystem] = None) =
      this(new EidosComponentsBuilder().add(config, eidosSystemOpt.map(_.components)).build())
  def this() = this(EidosSystem.defaultConfig)
  // Python now uses the default, empty constructor above, but the line below remains for documentation purposes.
  // def this(x: Object) = this() // Dummy constructor crucial for Python integration

Hi @phosseini, I'm pretty sure that this has to do with your versions of Eidos and INDRA being out of sync. Try to make sure that you have the latest Eidos packaged as a JAR, and INDRA installed from Github (i.e., pip install git+https://github.com/sorgerlab/indra.git).
Having said that, an alternative way of using Eidos via INDRA is as a web service. You can follow the README instructions on running an Eidos webapp, and then do something like:
from indra.sources import eidos
eidos.process_text(text, webservice=<address of local Eidos web service>)

This avoids code-level dependencies between the two systems.

Thanks, I could run the example by adding the webservice parameter. I'm pretty sure I'm using the latest version of INDRA (indra==1.13.0) and EIDOS but I'll go and check it again. The only problem now is that I get the very error when I'm using delphi which is built upon INDRA and EIDOS. Running the example below I get that error:
from delphi.AnalysisGraph import AnalysisGraph
G = AnalysisGraph.from_text(
    "Significantly increased conflict seen in South Sudan forced many"
    " families to flee in 2017.")
G.map_concepts_to_indicators()
G.parameterize(country="South Sudan", year=2017, month=4)
A = G.to_agraph()
A.draw("CAG.png", prog="dot")

I wonder if you have any idea if I can use the Eidos's local server for delphi as well?

I could also run delphi using Eidos's webservice local web service (such a useful parameter!) Thanks for all the help.

Okay, great! INDRA's official PyPI release (in this case 1.13.0) lags behind the latest code on Github so it makes sense to pip install it from Github directly. In any case, using the webservice-based integration is more convenient in many ways.


Error when editing in HTML mode

I seem to be getting an error in HTML mode once I click to edit a Python Snippet and it adds a new line.
In the example below, I add a line above the msg variable in order to assign the name variable.

This is my current HTML code:

msg = f"Hello, {name}!"
print(msg)

<codapi-snippet engine="wasi" sandbox="python" editor="basic"></codapi-snippet>

For context, I am using the following files all loaded in the order shown below and they are loading from my own directories and not via cdn.

runno.js
wasi.js
snippet.js
snippet.css

It was the latest 0.19.7

I see. Instead of this:

msg = f"Hello, {name}!"
print(msg)

Use this:

msg = f"Hello, {name}!"
print(msg)

Live demo
I'll update the examples.

Thank you this worked!


Improve duplicate features check in DFS

The previous version becomes very slow as the number of features
increases. Because it looked up the count for every element its run time
was quadratic. The implementation in this commit should be linear.
Is this check even necessary though?

Logic seems good.

Is this check even necessary though?

@kmax12 thoughts? Does the hash check in DeepFeatureSynthesis._handle_feature make this check redundant?

@rwedge i believe you're right. looks like _handle_new_feature won't add a duplicate feature and all features get added by calling that, so this check is unnecessary.


⚠ Bofrost.es has degraded performance

In 2205533, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1259 ms

Resolved: Bofrost.es performance has improved in 6c21263 after 2 hours, 23 minutes.


Fix CI error

https://github.com/casdoor/casdoor-website/runs/8281564173?check_suite_focus=true

@Selflocking

The reason for this error is a syntax error in the Chinese translation.

@leo220yuyaodog can you help fix it at Crowdin?

@leo220yuyaodog can you help fix it at Crowdin?

Yes, I can


[REQUEST] add ssh port argument for multi-node training/inference

Is your feature request related to a problem? Please describe.
Currently, the code assumes that the SSH port for connections is set to the default port 22 . However, in some cases, the SSH port might be configured to a value other than 22 for security reasons. This limitation prevents the utilization of the multi-node feature, as the code lacks the functionality to specify a custom port number for SSH connections.
Describe the solution you'd like
I would like to be able to specify the SSH port when using the multi-node feature, like so:
deepspeed --hostfile=hostfile.txt \
          --master_addr=$ip_address \
          --port=2222  \
          test.py

Describe alternatives you've considered
An alternative is to reconfigure the SSH ports to be 22, but as mentioned earlier, this may not be possible due to security reasons.
Additional context
I have altered deepspeed/launcher/runner.py to enable specification of SSH ports in the following PR:

https://github.com/microsoft/DeepSpeed/pull/4117#issue-1843517576


Can I run more than one gateway?

Can I run more that one gateway or am I limited to just one?  I have two boilers for two different spaces with separate gateways, boiler controllers and thermostats and would like to be able to control both via HA.  Can I run multiple instances of the integration?  Any pointers on how to do this would be appreciated

yes


Enhancement: CSV File Loader

Hello I am using the node within ComfyUI and think it is a great idea. The only issue I have, like the Prompt Style Chooser in WAS Suite, I would like to have this same power using other CSV files. The best option for this I think would be to add a section within the node where you are able to input the name of the CSV file you want to reference. For example I have copied the Custom node and replaced all references to "styles" with "settings" and now I have a settings.csv. This is a workable approach but would be much easier if there was only one node where the CSV can be referenced. I'm not sure if there is a limit in the functionality of ComfyUI when it comes to this but would be a much better approach in my opinion.
If there are limitations, maybe extra nodes can be added as seen below for basic things you would include in a prompt.

Style
Setting
Lighting
Composition
Artist
etc...

Thank you for the node regardless, saved me the time of trying to pull the code from the WAS Suite and figuring it out myself.

So I went ahead with the second suggestion I posted above. Feel free to implement it into the base model if you would like. The only other change I would like is to actually show the positive prompt and negative prompt below the name. I'm not sure how to implement that though.. so if you do I would be great full.
The folder with the CSV files has been moved to the ComfyUI\custom_nodes\ComfyUI-CSV_Loader folder to keep everything contained and updated everything to be CSV Loader instead of Style CSV Loader. The CSV files include artists.csv, artmovements.csv, characters.csv, composition.csv, lighting.csv, negative.csv, positive.csv, settings.csv, and styles.csv. All have some preloaded selections but can always be updated in the CSV files.
ComfyUI-CSV_Loader.zip
https://github.com/theUpsider/ComfyUI-Styles_CSV_Loader/assets/58462961/9d6c7fbf-9ae4-4e90-a2cc-cc98aa6cc0f8

Ended up making a GitHub repository for the changes I made incase users would like to use either or.
https://github.com/PCMonsterx/ComfyUI-CSV-Loader


Add exclude_paths option for black + flake8 + Pylint

How is ptr not doing what you expect?
ptr itself looks for *.py files to run black, flake8 and pylint on. Today we have no way to add a blacklist for files to ignore. Generally you don't want to do this but if a repo uses submodules and you have code you do not own in your tree, it would be nice to be able to ignore it.
What is your suggestion to make this better?

Add a setup.(cfg|py) parameter to enable this. I'd suggest the param find_py_excludes.

setup.cfg:

[ptr]
find_py_excludes = relative/path1,relative/path2

setup.py:

{
    "find_py_excludes": ["relative/path1", "relative/path2"],
}

Relative path is from the dir setup.(cfg|py) is in.

How can a developer reproduce this?
Add a non black, flake8 or pylint file anywhere under -b / base_path ptr runs from where an ptr activated setup.(cfg|py) exists and see the error come.

Then add the config find_py_excludes option and ensure it's ignored

Working on this :)

@adhaamehab - We've removed using this for black (now it can be recursive itself) and flake8. Only pylint requires this now. Will update the Issue.


Remove old wifi module and replace with updated one

UNTESTED!!!
Please test first, and check if removal of force_enable()  broke something elsewhere

The wifi module is just a convenience thing for connecting with wifi.init()
The easywifi is no replacement for that functionality . . or . . am I missing something?

Leave it as is please.

Should then just leave the wifi module as is :)

@Roosted7 could you update your merge request or close this merge request?


Scheduler: Uppercase search yields no results

Issue:
Searching for classes in the scheduler using uppercase characters yields no results. Mixing cases also yields no results.
Searching for 'data':

Searching for 'DATA':

Thanks for letting us know! We'll be looking into this!

This is inadvertently already fixed in #575 but it's not merged into production yet.

Feature working; Uppercase search yields equivalent results.


Fix git submodule command

Thanks @mattvenz, sorry you ran into this!
This was fixed in https://github.com/buildkite/agent/pull/1029, which is released in v3.13.2.


Update ms-cloud-germany-transition-phases.md

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks


Nontrivial merges 2021 09 22

I can do the next merge. It's going to be a big clean up on main.

That would be great.


High memory consumption

Also it seems like starting a presentation leaks memory.

Memory was not leaked but copying single pages uses much more memory than copying whole PDFs.
Memory consumption still feels high but is in line with what Preview uses. So I blame Apple for this. ;)


Find lowest supported NPM version

Our build only tests NPM 4.0 and 4.1 while lower versions may be supported. This has to be tested.
If we know our lowest version, we should alter the package.json and add a badge to show which version is required. The same goes for grunt-stryker.

I tested stryker using every available NodeJS version supported by travis:
https://travis-ci.org/stryker-mutator/stryker/builds/124411940


Autocompletion: Analyze CLASS types as they are encountered

Supersedes #84266
Second part of fixing https://github.com/godotengine/godot/issues/78003 (can be closed if #84264 was already merged)
When _guess_expression_types encounters a CLASS type that was not analysed before it will now fully analyse it before returning the type. Compared to #84266 this moves the recursive approach to the autocompletion code, and leaves the parser as is. This reduces the possibility to introduce cyclic reference issues with that.
This shouldn't lead to infinite loops as the analysing is still shallow and the autocompletion already has save guards for recursion limits.

Thanks!


Providing umbrella helm chart and some feature improvements

Added

Added validation for UpdateInvestigationRequest, reason for (decline, accepted, close)
Added Title to sections that might be cut of with three dots (...)

Changed

Updated database fields within Investigation table (accept_reason, decline_reason, close_reason)
Used same shadow for other parts table than we use for my parts table
Improved visibility of text that might be too large.
Changed mapping of partNumber from customerPartId to manufacturerPartId
Adapted catena style guide for colors
Removed quality type from ui but kept base functionality for future use
Improved and separated *.md documentation, especially README.md

This pull request has been verified and can be merged. Thank you.


OpsGenie v2 Support

Comparing https://docs.opsgenie.com/docs/alert-api to https://docs.opsgenie.com/docs/alert-api-deprecated it looks like there are a few difference:

The authentication method changes from a property of the JSON body to an HTTP header
The team/recipients properties are combined into a respondents  list. Teams are {"name":"team name","type":"team"} and recipients are {"username": "user name","type":"user"}.

At this point I believe we can switch to using the new API without needing to create a new config or handler. Simply updating the existing code should be enough.

link https://github.com/influxdata/kapacitor/issues/1708


Create CryptoConfig constructors to replace dcparameters

As a first step to https://github.com/containerd/containerd/issues/3443, we've provided interfaces via the encryption library to create the necessary CryptoConfig structures for encryption/decryption without the need to know internals of the encryption scheme..
We've implemented the following interfaces and updated ctr usage to use it. In addition, there is no longer any use of dcparameters in the codebase outside the encryption library - which uses its internals.
func EncryptWithJwe(pubKeys [][]byte) (CryptoConfig, error)
func EncryptWithPkcs7(x509s [][]byte) (CryptoConfig, error)
func EncryptWithGpg(gpgRecipients [][]byte, gpgPubRingFile []byte) (CryptoConfig, error)
func DecryptWithPrivKeys(privKeys [][]byte, privKeysPasswords [][]byte) (CryptoConfig, error)
func DecryptWithX509s(x509s [][]byte) (CryptoConfig, error)
func DecryptWithGpgPrivKeys(gpgPrivKeys, gpgPrivKeysPwds [][]byte) (CryptoConfig, error)

We are thinking that when the OCI spec gets merged, an option is for the pkg/encryption library to be under the OCI repo. So this would be the interface provided to create the configurations.

Codecov Report

Merging #3452 into master will increase coverage by 0.11%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3452      +/-   ##
==========================================
+ Coverage   44.11%   44.22%   +0.11%
==========================================
  Files         124      124
  Lines       13760    13724      -36
==========================================
  Hits         6070     6070
+ Misses       6759     6723      -36
  Partials      931      931

Flag
Coverage Δ

#linux
48.01% <0%> (+0.13%)
:arrow_up:

#windows
39.88% <0%> (+0.12%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/encryption/gpg.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdab4f4...3d1fa69. Read the comment docs.

Codecov Report

Merging #3452 into master will increase coverage by 0.11%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #3452      +/-   ##
==========================================
+ Coverage   44.11%   44.22%   +0.11%
==========================================
  Files         124      124
  Lines       13760    13724      -36
==========================================
  Hits         6070     6070
+ Misses       6759     6723      -36
  Partials      931      931

Flag
Coverage Δ

#linux
48.01% <0%> (+0.13%)
:arrow_up:

#windows
39.88% <0%> (+0.12%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/encryption/gpg.go
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdab4f4...3d1fa69. Read the comment docs.

Awesome improvement
LGTM


async/await is difficult to incorporate in older projects unless complete solution is adjusted...

Hi I am interested in the ContentDialog that is available in MahApps.Metro, so I refactored this portion of the library into a service based architecture only to find out that the async methods cannot be used in conjunction with normal synchronous methods as I had previously implemented and wanted to continue to use in my existing projects:
https://social.msdn.microsoft.com/Forums/vstudio/en-US/650e69f9-5f4d-4d77-8107-93fb6646f26d/block-synchronous-method-while-waiting-for-async-method-to-complete?forum=netfxbcl
I was wondering if anyone else has run into this problem or whether there is an alternative solution that does not require async/await?
ANyways, this library is a great source of creative solution. Thanks for providing this great work :-)

@Dirkster99 you could use the WaitWithPumping method from here.
Have a look at Stephen Toub's answer.

Thanks a lot the solution works great for me - I think this issue is resolved :-)


JWT Handler on iOS

Since 5.1 I can add the package to a Xamarin iOS project - but when validating a JWT I get the below exception.
Any ideas?
"IDX10503: Signature validation failed. Keys tried: 'Microsoft.IdentityModel.Tokens.RsaSecurityKey , KeyId: a3rMUgMFv9tPclLa6yF3zAkfquE\n'.\nExceptions caught:\n 'System.NotImplementedException: Derived classes must provide an implementation.\n  at System.Security.Cryptography.RSA.HashData (System.Byte[] data, System.Int32 offset, System.Int32 count, System.Security.Cryptography.HashAlgorithmName hashAlgorithm) [0x00000] in /Users/builder/data/lanes/3969/44931ae8/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/security/cryptography/rsa.cs:89 \n  at System.Security.Cryptography.RSA.VerifyData (System.Byte[] data, System.Int32 offset, System.Int32 count, System.Byte[] signature, System.Security.Cryptography.HashAlgorithmName hashAlgorithm, System.Security.Cryptography.RSASignaturePadding padding) [0x0008a] in /Users/builder/data/lanes/3969/44931ae8/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/security/cryptography/rsa.cs:166 \n  at System.Security.Cryptography.RSA.VerifyData (System.Byte[] data, System.Byte[] signature, System.Security.Cryptography.HashAlgorithmName hashAlgorithm, System.Security.Cryptography.RSASignaturePadding padding) [0x00011] in /Users/builder/data/lanes/3969/44931ae8/source/xamarin-macios/_ios-build/Library/Frameworks/Xamarin.iOS.framework/Versions/git/src/mono/mcs/class/referencesource/mscorlib/system/security/cryptography/rsa.cs:143 \n  at Microsoft.IdentityModel.Tokens.AsymmetricSignatureProvider.Verify (System.Byte[] input, System.Byte[] signature) [0x0005d] in :0 \n  at System.IdentityModel.Tokens.Jwt.JwtSecurityTokenHandler.ValidateSignature (System.Byte[] encodedBytes, System.Byte[] signature, Microsoft.IdentityModel.Tokens.SecurityKey key, System.String algorithm, Microsoft.IdentityModel.Tokens.TokenValidationParameters validationParameters) [0x00082] in <5b3d2ff3122e411f897a3bee8b024790>:0 \n  at System.IdentityModel.Tokens.Jwt.JwtSecurityTokenHandler.ValidateSignature (System.String token, Microsoft.IdentityModel.Tokens.TokenValidationParameters validationParameters) [0x0019f] in <5b3d2ff3122e411f897a3bee8b024790>:0 \n'.\ntoken: '{"alg":"RS256","typ":"JWT","x5t":"a3rMUgMFv9tPclLa6yF3zAkfquE","kid":"a3rMUgMFv9tPclLa6yF3zAkfquE"}.{"iss":"https://demo.identityserver.io","aud":"native","exp":1481724549,"nbf":1481724249,"nonce":"a2d49e2bc14beb5ec6f79bb20cfb03c4b01c7f89bebc0cd692dd485fdb716059","iat":1481724249,"c_hash":"ZPg_282TmzmwwpE2xDnfiA","sid":"4c58ecf10b87455e95a82144dc481057","sub":"88421113","auth_time":1481724146,"idp":"idsrv","amr":["password"]}'."

@leastprivilege I suspect that this functionality is not available on iOS.
@bartonjs is this correct?

It means that the Xamarin implementation of RSA has not overridden the HashData method (which was added in .NET 4.6 / .NET Standard 1.3).  @akoeplinger are you guys aware of that?

@bartonjs Yeah, looks like that's the case. I wasn't aware of it, not sure if we should've received a notice that we should override those methods :)

thanks - could you fix that please?
I've been using PCLCrypto (https://github.com/AArnott/PCLCrypto) so far and this deals with x-plat crypto quite well. Moving away from PCL to netstandard - it should be easier to implement a cross platform OpenID Connect library. But no joy so far.
When my original iOS issue was closed, I assumed someone tested it as well.

Ok, so it turns out we did implement these methods for RSA in Mono 4.8/Xamarin.iOS 10.4 which are in the alpha channel right now. Can you please try with those builds?
I see it not being implemented for DAS though, so I'll file an issue for that.

OK - will do. thanks!

just did a quick test. seems to work. thanks! Will do more testing and let you know if there are more issues.


Suggestion

Hey!
I have been following this project for quite some time now, and it is growing wonderfully. I would love to try it out, but I think that downloading two extra "plugins" for it is rather annoying. So, my "issue" is this:
Could you please build those things into OMXInvest?
I would be very appreciative.

Hi,
thanks for your input! I will be looking in to better integration of used
plugins at some point, though at this point I am more concerned with making
the technical aspects of the program work the way I want them to.
//Wrafter
On 8 November 2011 03:01, MehSki11zOwn <
<EMAIL_ADDRESS>
Hey!
I have been following this project for quite some time now, and it is
growing wonderfully. I would love to try it out, but I think that
downloading two extra "plugins" for it is rather annoying. So, my "issue"
is this:
Could you please build those things into OMXInvest?
I would be very appreciative.

Reply to this email directly or view it on GitHub:
https://github.com/simonwrafter/OMXInvest/issues/1

Okay. Thank you!

Done and done! Closed!


Update to node 10 in .travis.yml

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Image preview sometimes doesn't work without window resize

What system are you running Yazi on?
Linux Wayland
What terminal are you running Yazi in?
foot
yazi --debug output
Yazi
    Version: 0.3.1 (Arch Linux 2024-08-17)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.3.1 (Arch Linux 2024-08-17)

Emulator
    Emulator.via_env: ("foot", "tmux")
    Emulator.via_csi: Ok(Foot)
    Emulator.detect : Foot

Adapter
    Adapter.matches: Sixel

Desktop
    XDG_SESSION_TYPE: Some("wayland")
    WAYLAND_DISPLAY : Some("wayland-1")
    DISPLAY         : Some(":0")

SSH
    shared.in_ssh_connection: false

WSL
    /proc/sys/fs/binfmt_misc/WSLInterop: false

Variables
    SHELL              : Some("/usr/bin/zsh")
    EDITOR             : Some("nvim")
    VISUAL             : Some("nvim")
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block  : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : true
    tmux version       : 3.4
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file             : 5.45
    ueberzugpp       : No such file or directory (os error 2)
    ffmpegthumbnailer: No such file or directory (os error 2)
    magick           : No such file or directory (os error 2)
    fzf              : 0.54.3
    fd               : 10.1.0
    rg               : 14.1.0
    chafa            : No such file or directory (os error 2)
    zoxide           : 0.9.4
    7z               : No such file or directory (os error 2)
    7zz              : No such file or directory (os error 2)
    jq               : No such file or directory (os error 2)

--------------------------------------------------
When reporting a bug, please also upload the `yazi.log` log file - only upload the most recent content by time.
You can find it in the "/home/zack/.local/state/yazi" directory.

Did you try the latest nightly build to see if the problem got fixed?
No, and I'll explain why below
Describe the bug
For the explanation of why i didn't try using nightly, it's because I'm unsure if this is a bug or simply a configuration issue, as I only installed yazi for the first time 5 minutes ago.
Basically, some of my .jpg images work fine with the image preview, other .jpg's don't work in when the window is maximized, but I found that if i shrink the window the preview will eventually show up.
Minimal reproducer
Not sure what to put here, all I did was open my Pictures folder and select an image.
Anything else?
No response

I didn't quite understand what you meant, could you record a video to show me what's happening? Also, have you tried setting the max_width?


feat: handle device class of endpoints

fixes: #2100
and was probably due long ago 😅

@aveseli can you test if this branch fixes your problem with the Flush Dimmer?
You'll probably need to build a custom container https://zwave-js.github.io/zwavejs2mqtt/#/troubleshooting/docker_custom_builds

It reports the state after a restart here:

I guess this is expected.
One strange thing I noticed: it toggles the value to true and after 2-5 seconds it switches back to false without me pressing the switch.
I have build a new docker image like this:
DOCKER_BUILDKIT=1 docker build --build-arg SRC=git-clone-src --build-arg Z2M_BRANCH=master --build-arg ZWJ_BRANCH=endpoint-device-class --no-cache -f zwavejs2mqtt/docker/Dockerfile.contrib -t zwavejs2mqtt .
I am not sure if using  Z2M_BRANCH=master  is correct, since the control panel changes in some a bit and probably this is still under development.

Could you make a log so I can check what exactly happens?

zwavejs2mqtt-store-2.zip
What I did:

starting the new test version of zwavejs2mqtt
hitting the switch 2-3 times
re-interviewing the node 10
hitting the switch 2-3 times

Please note: I configured the zwave logging to only include Node 10.

Ok so it looks like the mapping works now, but the device actually sends a followup Binary Sensor Report with state false. You could try adding the controller node to association group 7 to see if this changes things.
I'm actually not sure how this is supposed to work. I'll ask my contact at Qubino and let you know.


enable https on aim42.org website

possibly with cloudflare:
https://hackernoon.com/set-up-ssl-on-github-pages-with-custom-domains-for-free-a576bdf51bc
alternate description:
https://www.jonathan-petitcolas.com/2017/01/13/using-https-with-custom-domain-name-on-github-pages.html

Shouldn‘t that actually be located in https://github.com/aim42/aim42.org-site/issues ?

Right you are - our reference manual doesn't need https...


Forbid bugged version 2.1.1 of yojson to fix tests

The latest version of Yojson is bugged. See https://github.com/ocaml-community/yojson/issues/171 for details.
I added a version constraint to the main opam file so that the CI will pass, and there shouldn't be problems when opam install . --deps-only on a fresh clone.

Merged in #486


Add Telemetry querying

[topic]: Add Telemetry querying
Adds functions to get the output of ceph telemetry show-all or ceph telemetry preview-all (depending on the module status)
Signed-off-by: Chris Blum<EMAIL_ADDRESS>Checklist

[X] Added tests for features and functional changes
[X] Public functions and types are documented
[X] Standard formatting is applied to Go code
[X] Is this a new API? Added a new file that begins with //go:build ceph_preview
[X] Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

First off, thank you very much for the PR. It already looks very complete!
I often like to start off with some high-level questions before going too deeply into review. My big question for you is - do you think that it might be appropriate to make a telemetry package, such as common/admin/telemetry rather than add functions to common/admin/manager. It's a little more overhead but given that (IIUIC) telemetry is a complete mgr module it could be seen as more of a peer to the "nfs" package (common/admin/nfs) where our manager package is more for controlling just the manager itself...
Just a thought - I'd be happy to hear your reaction.

That's a tough decision. Since the cli interface is so small, i went ahead and added it to the manager. I felt like adding another package and folder in the repo would spam the namespace and make it harder to get to the actual stuff for new developers.
I do realize this might not conform to the overall structure and plan, so i can also create a new package if you like.

Taking a look at the telemetry module in ceph's main branch:
[jmulliga@pretzel ~/devel/ceph ➥ main]$ grep '@CLI' src/pybind/mgr/telemetry/module.py
    @CLIReadCommand('telemetry status')
    @CLIReadCommand('telemetry diff')
    @CLICommand('telemetry on')
    @CLICommand('telemetry off')
    @CLIReadCommand('telemetry enable channel all')
    @CLIReadCommand('telemetry enable channel')
    @CLIReadCommand('telemetry disable channel all')
    @CLIReadCommand('telemetry disable channel')
    @CLIReadCommand('telemetry channel ls')
    @CLIReadCommand('telemetry collection ls')
    @CLICommand('telemetry send')
    @CLIReadCommand('telemetry show')
    @CLIReadCommand('telemetry preview')
    @CLIReadCommand('telemetry show-device')
    @CLIReadCommand('telemetry preview-device')
    @CLIReadCommand('telemetry show-all')
    @CLIReadCommand('telemetry preview-all')
[jmulliga@pretzel ~/devel/ceph ➥ main]$ grep '@CLI' src/pybind/mgr/telemetry/module.py | wc -l
17

That's 17 unique "endpoints" that could become APIs in go-ceph under the telemetry subsystem. I would argue that by size alone this lends itself to a separate package. I understand it's more work for you but I hope it's not too burdensome.

@phlogistonjohn - you got it. Updated it so it's its own package.

The CI is also failing: the checks are naming issues mainly related to underscores.
The tests suites are hitting panics running the new tests
If you have any questions or need assistance debugging the test failures feel free to ask.  For now, I will assume you're good to debug the failure on your own.

I took a quick look at some of the panics. That is due to the use of initiailized connections. go-ceph uses a mix of functional and unit tests. Take a look at one of the other pakcages to see how you can get an initialized connection to the real cluster.

The latest push should cover all your remarks and hopefully make your tests happy too

Hi there, sorry for the delayed response but it appears the tests are still failing. There are still some naming issues too.
I'd love to see this in go-ceph so I want to make sure you get the help you need to make progress. Let me know if you'd like some more hands-on assistance / coaching from us around writing the tests, etc. I personally like to try and learn the hard way by doing things myself, but I don't want to assume you feel the same.
Alternatively (or in addition), we maintainers can take a more hands on approach with this if you've not got the time or energy to pursue the PR all the way to completion yourself. Basically, we "take over" part of the development effort starting from where you left off... with feedback and credit due of course. However, I usually save this offer as a last resort - but I figured I'd lay it on the table too.

This should (hopefully) make the tests happy. Updated the api files too, maybe that was the issue with the Ceph tests?

@mergifyio rebase

I don't need this any more

I don't need this any more

OK, thanks for the update. If you change your mind feel free to open an issue and our team can try and run with what you started.


Ghost admin failing to load posts upon scroll

Issue Summary
As of Ghost 3.7, Ghost admin fails to load additional posts when infinite scrolling. This issue is reproducible in the latest versions of Firefox, Chrome, and Safari on OSX:

To Reproduce

Log in to Ghost admin
Navigate to "posts" section
Scroll to bottom

Technical details:

Ghost Version: 3.7
Node Version: 12
Browser/OS: Firefox, Chrome, and Safari on OSX
Database: MySQL v8

Experiencing the same issue except with Node v10. It appears as though the JSON is being returned correctly on scroll but never rendered into the page.

Experiencing the same issue on the managed service(ghost.io). The work around is grab the post id in the api response and edit the post via https://xxx.ghost.io/ghost/#/editor/post/{id}
This is a very serious bug for non-technical writers.


trying to load an mp3 file according to the examples but get "request status was: 0 ()'

I get this error while trying to put this example code from p5.js into an own file where I add an another mp3.
https://p5js.org/reference/#/p5.FFT
Doing this, I get this error

p5.sound.js:944 Unable to load tra.mp3. The request status was: 0 ()  The error stack trace includes:
loadSound at preload

EDIT: I use the Brackets editor which opens a new Chrome instance which produces this error. My normal chrome instance doesn't work either. It does work with Firefox

Hi vzR,
I've had the same problem trying to implement sound to my p5.js project and I'm also using Brackets editor.
Could you tell me if you have found a solution? @vzR

@vzR @Adijox
Could you post your code somewhere ? And the version of chrome used ?
Because for me it works with Bracket's live preview on chrome.

I left my sketch a few minutes to download a new editor and it seems to work now hat I come back to it...
Thank you for your help.
Lastly, it may not be the good discussion where to ask but I also have an issue when uploading sound files and images on to GitHub Pages:
404
File not found
The site configured at this address does not contain the requested file.
If this is your site, make sure that the filename case matches the URL.
For root URLs (like http://example.com/) you must provide an index.html file.

@Adijox hi, I've switched to another sound library (Howler.js) because I noticed that the p5 website itself also slows down quite a bit (in both chrome & firefox) while I was trying to explore the documentation. I'm happy it works for you but with the performance issues (I felt at least) I decided to move on. It's really an awesome and powerful library though

@vzR : ok it's true that performance is not the main concern here, but I think it mainly depends on what you do and what tabs are open in the examples :  fft examples can be a bit more heavy
@Adijox good that it works.
We can close this issue then
about gh-pages you might want to try stack overflow.
I use gh-pages for showcasing my github project. I have this main repo : https://github.com/b2renger/b2renger.github.io
I have wrote some explanations about it here : http://b2renger.github.io/p5js_algae_dom/index.html
If it doesn't help you can post an issue on my repo and I'll try to help


Abigen finds std::string::String over sway-lib's String

When attempting to pass or return the sway-libs String type, abigen mistakes this for Rust's standard library string.
For example, running a test on the following Sway code generates this error:
contract;

use sway_libs::string::String;

abi MyContract {
    fn test_get() -> String;
    fn test_set(new_string: String);
}

impl MyContract for Contract {
    fn test_get() -> String {
        String::new()
    }

    fn test_set(new_string: String) {

    }
}

The Sway-lib's String is currently simply a wrapper on Sway's Vec:
pub struct String {
    bytes: Vec<u8>,
}

@bitzoic there is a problem with the name collision, so I'll fix that in this task.
But note that you can't return anything containing a vector until this task is done.
Even then I fear you won't be able to return this as there was an inter-team meeting on which we agreed that returning vectors will be supported only at the topmost level -- i.e. fn something() -> Vec<Something>
Even though the nesting of the vec inside Sway's string is superficial (i.e. it will be encoded exactly as a top-level-vec would be), this still might be prohibited by the compiler once the 'vec-as-output' support is done on the Sway side.
@mohammadfawaz fyi.


fix: extends resource type by fetch

:tada: This PR is included in version 1.1.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


navigation from Java class to overriding or implementing Ceylon class takes me to decompiled .class file

Navigation using ⌥⌘B from a class in a Java library (ImplementationSearcher) to a Ceylon class (CeylonLineMarkerProvider.Searcher) defined in my project takes me to the decompiled .class file editor instead of the Ceylon source.

This might be fixed by #292, I'm not certain.

It's actually much more simple than that. ceylon-ide-intellij is a Java-only project, that depends on the CAR produced by plugin-ceylon-code, I just forgot to attach sources to that car.

OK :-)


Update course materials to cover the lag and entries read enhancements to XINFO GROUPS in Redis 7.

Redis 7 enhanced XINFO GROUPS to report on consumer group lag and number of entries read by the group.  Update the course materials for this.

This will involve adding a new HTML section to 9.1 in the course.


Added Rate of fire to actual target number calc for ranged attacks

Changes / Comments
The rate of fire was queried by the sheet but never factored into the calculations. This is now fixed, tested on the site (in my game and working.
Test line (pre change):
&{template:dh2ed}[[[[floor((@{Elcyd Barette|BallisticSkill}?{Aim | No aim (+0),+0 | Half aim (+10),+10| Full aim (+20),+20}+ ?{Range | Point Blank (+30),+30 | Short Range (+10),+10 | Standard range (+0),+0 | Long Range (-10),-10 | Extreme Range (-30),-30}+ ?{Rate of Fire/Attack Type| Standard (+10),+10 | Semi auto (+0),+0 | Full Auto (-10),-10 | Called Shot (-20),-20 | Suppressing Fire (-20),-20}+ [[?{Modifier|0}]])/10))]]-[[floor([[1d100cs<1cf>100]]/10)]]]]{{name=Gun}}{{roll= $[[2]] }}{{degrees=$[[4]]}}{{skill=@{Elcyd Barette|BallisticSkill}}}{{aim=?{Aim | No aim (+0),+0 | Half aim (+10),+10 | Full aim (+20),+20} }}{{range= ?{Range | Standard range (+0),Standard range +0 | Short Range (+10),+10 | Point Blank (+30),+30 | Long Range (-10),-10 | Extreme Range (-30),-30}}}{{attacktype=?{Rate of Fire/Attack Type| Semi auto (+0),+0 | Standard (+10),+10 | Full Auto (-10),-10 | Called Shot (-20),-20 | Suppressing Fire (-20),-20}}}{{modifier=?{Modifier|+0} }}{{target=[[@{Elcyd Barette|BallisticSkill}+ [[?{Aim | No aim (+0),0 | Half aim (+10),10 | Full aim (+20),20} + ?{Range | Standard range (+0),Standard range +0 | Short Range (+10),+10 | Point Blank (+30),+30 | Long Range (-10),-10 | Extreme Range (-30),-30} + [[?{Modifier|0}]]]]]]}}
result:

Test line (with change):
&{template:dh2ed}[[[[floor((@{Elcyd Barette|BallisticSkill}?{Aim | No aim (+0),+0 | Half aim (+10),+10| Full aim (+20),+20}+ ?{Range | Point Blank (+30),+30 | Short Range (+10),+10 | Standard range (+0),+0 | Long Range (-10),-10 | Extreme Range (-30),-30}+ ?{Rate of Fire/Attack Type| Standard (+10),+10 | Semi auto (+0),+0 | Full Auto (-10),-10 | Called Shot (-20),-20 | Suppressing Fire (-20),-20}+ [[?{Modifier|0}]])/10))]]-[[floor([[1d100cs<1cf>100]]/10)]]]]{{name=Gun}}{{roll= $[[2]] }}{{degrees=$[[4]]}}{{skill=@{Elcyd Barette|BallisticSkill}}}{{aim=?{Aim | No aim (+0),+0 | Half aim (+10),+10 | Full aim (+20),+20} }}{{range= ?{Range | Standard range (+0),Standard range +0 | Short Range (+10),+10 | Point Blank (+30),+30 | Long Range (-10),-10 | Extreme Range (-30),-30}}}{{attacktype=?{Rate of Fire/Attack Type| Semi auto (+0),+0 | Standard (+10),+10 | Full Auto (-10),-10 | Called Shot (-20),-20 | Suppressing Fire (-20),-20}}}{{modifier=?{Modifier|+0} }}{{target=[[@{Elcyd Barette|BallisticSkill}+ [[?{Aim | No aim (+0),0 | Half aim (+10),10 | Full aim (+20),20} + ?{Range | Standard range (+0),Standard range +0 | Short Range (+10),+10 | Point Blank (+30),+30 | Long Range (-10),-10 | Extreme Range (-30),-30} + ?{Rate of Fire/Attack Type| Standard (+10),+10 | Semi auto (+0),+0 | Full Auto (-10),-10 | Called Shot (-20),-20 | Suppressing Fire (-20),-20} + [[?{Modifier|0}]]]]]]}}
result:

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[X] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

Character Sheet Info Roll20 Internal Use only.


get_study_est_sspse() fix estimates

SS-PSE estimates produced by get_study_est_sspse() are currently off target. Try to find cause of error and debug.

SS-PSE estimates look reasonable. Deviations from other RDS estimators may be due to agnostic default parameters in sspse::posteriorsize(). Opening new issue regarding adding option to specify sspse::posteriorsize() arguments in get_study_est_sspse().


[build failure] unable to build the project with the latest JDK due to outdated gradle v2.2.1

The code compiles fine but the config injection fails.
FAILURE: Build failed with an exception.

* What went wrong:
Could not determine java version from '10.0.2'.

* Try:
Run with --debug option to get more log output.

* Exception is:
java.lang.IllegalArgumentException: Could not determine java version from '10.0.2'.
	at org.gradle.api.JavaVersion.toVersion(JavaVersion.java:63)
	at org.gradle.api.JavaVersion.current(JavaVersion.java:72)
	at org.gradle.launcher.cli.JavaRuntimeValidationAction.execute(JavaRuntimeValidationAction.java:32)
	at org.gradle.launcher.cli.JavaRuntimeValidationAction.execute(JavaRuntimeValidationAction.java:24)
	at org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:206)
	at org.gradle.launcher.cli.CommandLineActionFactory$WithLogging.execute(CommandLineActionFactory.java:169)
	at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:33)
	at org.gradle.launcher.cli.ExceptionReportingAction.execute(ExceptionReportingAction.java:22)
	at org.gradle.launcher.Main.doAction(Main.java:33)
	at org.gradle.launcher.bootstrap.EntryPoint.run(EntryPoint.java:45)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at org.gradle.launcher.bootstrap.ProcessBootstrap.runNoExit(ProcessBootstrap.java:54)
	at org.gradle.launcher.bootstrap.ProcessBootstrap.run(ProcessBootstrap.java:35)
	at org.gradle.launcher.GradleMain.main(GradleMain.java:23)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at org.gradle.wrapper.BootstrapMainStarter.start(BootstrapMainStarter.java:30)
	at org.gradle.wrapper.WrapperExecutor.execute(WrapperExecutor.java:127)
	at org.gradle.wrapper.GradleWrapperMain.main(GradleWrapperMain.java:56)

Command /bin/sh failed with exit code 1

My environment :
dodikk-Air:~ dodikk$ javac -version
javac 10.0.2

dodikk-Air:~ dodikk$ java --version
java 10.0.2 2018-07-17
Java(TM) SE Runtime Environment 18.3 (build 10.0.2+13)
Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10.0.2+13, mixed mode)

dodikk-Air:~ dodikk$ xcodebuild -version
Xcode 9.4.1
Build version 9F2000

UPD: the project somehow builds on another workstation with
javac 1.8.0_131
java 1.8.0_131

@dodikk What you have different on the other workstation?

@dodikk What you have different on the other workstation?

I thought I've stated that java version it is

javac 10.0.2 - does not build
javac 1.8.0_131 - build succeeded

I might be mistaken, but I guess that 10.0.2 is a more recent version. If so, it would be nice to have it supported by the build system used by the edx iOS app.

Also, gradle-2.2.1-bin.zip seems outdated.
It is listed in the edx-app-ios/gradle/wrapper/gradle-wrapper.properties file.
Note: The latest gradle version of gradle is v4.9so far.
It might be a good idea to either

update gradle to the recent version (so that the users would not have to mess up with the ancient tools and java runtimes)
share some workstation setup script or at least document the toolchain versions (I've read the project's public confluence pages but I have not spotted this kind of information there).

That might be obvious but here is my quick and dirty workaround for those who might experience the same issue

I have installed java8 with homebrew brew cask install java8
I've modified the build step inside the .pbxproj by explicitly overriding the JAVA_HOME environment variable.


InMemmoryStorage optimization

We use synchronize in the InMemoryStorage, but we already use a ConcurrentHashMap. If we modify slightly the way we override the keys, it would possible to remove them.
Also, the ConcurrentHashMap uses the default values at creation (meaning its optimized for 16 threads), we should adjust that for our own needs (I suggest 4 threads to be more realist). The gain in performance should be significant.

Hey guys that should be an easy fix that would increase performances.


Azure OpenAI service support

Would be nice to offer an option to use Azure OpenAI service

reopenning as it seems we need different logic for key validation if we detect an azure url

Bien

but, still says '✖ Invalid config property OPENAI_KEY: Must start with "sk-"' if config with Azure API Key

@steve8708 This is because we cannot determine whether the proxy endpoint is for Azure or OpenAI without introducing another configuration setting such as "USEAZURE: boolean". Therefore, I believe it would be better to remove the validation of openai keys. Please review, thanks!


Align Documentation Artifact Name with JS

Consistency rules!
@Azure/azure-sdk-eng

Can one of the admins verify this patch?


Adapter parameters overriding

The idea of introducing the mechanism for low-level adapter parameters overriding is inspired by the following cases:
Knative service labels:

Synchronizer issue. Currently, we cannot utilize Synchronizer functionality without a custom connection link between external systems and Triggermesh components (e.g. Kong gateway with CE plugin or Webhook source with a custom CE client),
It is happening quite often that we need to have an access to the component's endpoint for direct interaction with the adapter for debugging purposes or to use it as a standalone service.

Setting Knative service network visibility scope label would help resolve these issues.
Adapter's environment variables:

CE Overrides. Context attributes overrides are defined as a part of the sources spec but other components do not seem to have that ability, while there is no reason to limit it to the sources only,
Delivery configuration. In bridges with multiple targets and different conditional routes, CE responses handling can become a very complex task and there are no chances we can have predefined, hardcoded delivery logic (errors, payloads, dls, etc.) in every component that would suit all possible scenarios.

These parameters are usually configurable through the adapter environment variables.
Custom resources:

Extend adapter limits. Some adapters may require more compute resources for events processing tasks in the high load environments,
Adding custom resources, such as secret mount or external volume may be something that we want to have as an opportunity in the future.

Would it make sense to work on the common solution for the described cases or should we solve the problems as they come, extending every particular component's spec one by one? If we go with the former, I see us implementing "adapter overridable" duck type that exposes meta and spec keys with the implementation depending on the adapter type.

Do you have a first draft to suggest, just to kickstart some discussion?
Would that take the shape of a nested Go struct that's embeddable in all types' spec?

I thought of starting with the simple structure to override the adapter's labels and envs. I'm not sure about the best way to expose overridable parameters: a predefined set of labels, envs, resources, etc. or just dump a raw corev1.Deployment spec there.
AWS SQS Source example with labels and envs overrides:
Reconcilable interface:
diff --git a/pkg/apis/common/v1alpha1/object_interfaces.go b/pkg/apis/common/v1alpha1/object_interfaces.go
index f8dd18e2..5be21a1f 100644
--- a/pkg/apis/common/v1alpha1/object_interfaces.go
+++ b/pkg/apis/common/v1alpha1/object_interfaces.go
@@ -39,6 +39,9 @@ type Reconcilable interface {

        // GetStatusManager returns a manager for the component's status.
        GetStatusManager() *StatusManager
+
+       // GetAdapterOverrides returns the adapter overrides.
+       GetAdapterOverrides() *AdapterOverrides
 }

Source structure:
diff --git a/pkg/apis/sources/v1alpha1/awssqs_types.go b/pkg/apis/sources/v1alpha1/awssqs_types.go
index a05e5af8..f59ff9d5 100644
--- a/pkg/apis/sources/v1alpha1/awssqs_types.go
+++ b/pkg/apis/sources/v1alpha1/awssqs_types.go
@@ -61,6 +61,10 @@ type AWSSQSSourceSpec struct {
        // Customizations of the AWS REST API endpoint.
        // +optional
        Endpoint *AWSEndpoint `json:"endpoint,omitempty"`
+
+       // Adapter spec overrides parameters.
+       // +optional
+       AdapterOverrides *v1alpha1.AdapterOverrides `json:"adapterOverrides,omitempty"`
 }

Reconciler:
diff --git a/pkg/reconciler/adapter.go b/pkg/reconciler/adapter.go
index 377f9acf..e34a27c3 100644
--- a/pkg/reconciler/adapter.go
+++ b/pkg/reconciler/adapter.go
@@ -146,6 +146,18 @@ func commonAdapterDeploymentOptions(rcl v1alpha1.Reconcilable) []resource.Object
                }
        }

+       overrides := rcl.GetAdapterOverrides()
+       if overrides == nil {
+               return objectOptions
+       }
+
+       for k, v := range overrides.Labels {
+               objectOptions = append(objectOptions, resource.Label(k, v))
+       }
+       for k, v := range overrides.Envs {
+               objectOptions = append(objectOptions, resource.EnvVar(k, v))
+       }
+
        return objectOptions
 }

@@ -221,6 +233,18 @@ func commonAdapterKnServiceOptions(rcl v1alpha1.Reconcilable) []resource.ObjectO
                }
        }

+       overrides := rcl.GetAdapterOverrides()
+       if overrides == nil {
+               return objectOptions
+       }
+
+       for k, v := range overrides.Labels {
+               objectOptions = append(objectOptions, resource.Label(k, v))
+       }
+       for k, v := range overrides.Envs {
+               objectOptions = append(objectOptions, resource.EnvVar(k, v))
+       }
+
        return objectOptions
 }

CRD:
diff --git a/config/300-awssqssource.yaml b/config/300-awssqssource.yaml
index 5dcf1d6a..fc02f726 100644
--- a/config/300-awssqssource.yaml
+++ b/config/300-awssqssource.yaml
@@ -167,6 +167,16 @@ spec:
                 oneOf:
                 - required: [ref]
                 - required: [uri]
+              adapterOverrides:
+                description: Kubernetes object parameters to apply on top of default adapter values.
+                type: object
+                properties:
+                  labels:
+                    type: object
+                    additionalProperties: true
+                  envs:
+                    type: object
+                    additionalProperties: true
             required:
             - arn
             - sink

Maybe the example isn't very well chosen because if one wants to temporarily set extra labels or environment variables for debugging purposes, they can already do that.
DeepDerivative(desired, current) ignores extra elements in current as long as the rest of the slice or map is equal, so one can add an element using kubectl edit and the reconciler won't complain. (Changing an existing element is a different story.)
But I totally understand the idea and I think that approach would be easy to implement the way you suggested 👍
Maybe we could refine the configurations we do want to support to make the API more intuitive.
Examples:

If the goal is to let people expose some Ksvc components publicly, add a adapterOverrides.visibility attribute instead of expecting users to hack labels.
If the goal is to support ceOverrides everywhere, embed duck.SourceSpec and serialize spec.ceOverrides to JSON instead of expecting users to hack env vars.
etc.

Regarding the handling of responses, I think the solution is to keep components as dumb as possible (use the Replier everywhere, "reply and forget") and leverage the fact that Knative Eventing's Subscriptions can route replies to an arbitrary destination.
TIL does that at the global level by interpolating a Channel+Subscription between literally every component in the Bridge, and setting the deadLetterSink in all these Subscriptions to a unique destination where all responses are delivered.
We could re-use and extend that concept to not just errors but replies, at the level of the Bridge instead of per component, and act on responses in a central place.

Alright, I'm all in for starting with the adapterOverrides.visibility attribute as it is really needed for Synchronizer CR not later than this week. I would also go with the adapterOverrides.resources as the next attribute to implement there. Regarding the ceOverrides - did you mean embedding SourceSpec right in the component's spec? If yes, are we fine with having source-specific spec in say target component? Wouldn't be an adapterOverrides.ce object with the type/source/etc. attributes a bit more in line with the common spec structure? Anyways, I'm okay with skipping the CE overrides for now.

Responses handling. Although it is not directly related to the adapter overrides I wanted to dump one thought that I had after experimenting with the synchronous bridges. Basically, I suggest that in some cases we must extend components' dumbness over the whole bridge:
If a source is an error-aware client and its connection with the target does not explicitly require adding complex middleware components, the bridge must hide its presence by skipping all error handling, retries, and DLS mechanisms. In general, I believe that this condition is mostly applicable to synchronous flows, but I cannot say that it won't be the case for some other integrations.
I'd start with preparing errors-handling patterns first while exposing these patterns as adapterOverride attributes is a pretty trivial task.

Regarding the ceOverrides - did you mean embedding SourceSpec right in the component's spec? If yes, are we fine with having source-specific spec in say target component? Wouldn't be an adapterOverrides.ce object with the type/source/etc. attributes a bit more in line with the common spec structure?

I think both are fine as long as they get serialized to the same JSON structure.
I suggested SourceSpec because, when you think about it, it contains only CEOverrides and Sink, which is what most of our components need. (In the case of targets, Sink can be empty, and that's OK)

AdapterOverrides structure with the public switch and Resources Requirements added here. Adapter configuration logic is here. All CRDs are populated with this structure, AdapterConfigurable interface is implemented by all components.
New issues may be created if additional parameters need to be overridden through this mechanism.


SortableContainer inner props (such as axis, lockAxis and others) passed to inner component

Yesterday I updated react-sortable-hoc to the latest version and got a lot of warning that all SortableContainer props attached to dom element component, my component looks like this
...
const SortableList = SortableContainer(({items, ...otherProps}) => {
  return (
    <MyCustomComponent {...otherProps}>
      {items.map((value, index) => (
        <SortableItem key={`item-${index}`} index={index} value={value} />
      ))}
    </MyCustomComponent>
  );
});
...

I analyzed issue and figure out that in commit https://github.com/clauderic/react-sortable-hoc/commit/9da38750f5dd6d1f689788dfd023a818670f6f94 changed calling of omit util in all component
Previously it look like this
omit(props, 'propToOmit1', 'propToOmit2', ...) ,
now it looks like this
omit(props, arrayOfPropsToOmit)
but implementation of util didn't changed and looks like this
...
export function omit(obj, ...keysToOmit) {
  return Object.keys(obj).reduce((acc, key) => {
    if (keysToOmit.indexOf(key) === -1) {
      acc[key] = obj[key];
    }

    return acc;
  }, {});
}
...

This is the reason of my warnings
It's simple issue, for this reason i wasn't creating PR

Hi, thanks for the awesome library. When would a release be available that contains this fix?