Obsolete methods that can be removed with bigger impact

To support the deprecation of IKernel/DefaultKernel AddFacility(String key, IFacility facility) I also removed IConfiguration from IFacility.Init interface.
This is the last piece of the puzzle when it comes to getting rid of obsolete interface definitions on IKernel/IWindsorContainer.
For low hanging fruit review this PR first.

The docs for this definitely need updating will do that after we have reviewed the code.

To support the deprecation of IKernel/DefaultKernel AddFacility(String key, IFacility facility) I also removed IConfiguration from IFacility.Init interface.

Is there a reason you removed IConfiguration from facilities as part of this pull request, I thought it was just going to be getting rid of a bunch of obsolete AddFacility methods and moving a bit of code around as they mostly called each other.
I think we need to be much clearer with users if we are deprecating or removing support for XML configuration for any aspect of Windsor, XML configuration has been a big feature in Windsor's history with plenty of use out there, so I think it must be explicitly communicated with its own issue in the issue tracker even if that is just removing XML configuration support for facilities but it stays for installers (for example).

Is there a reason you removed IConfiguration from facilities as part of this pull request, I thought it was just going to be getting rid of a bunch of obsolete AddFacility methods and moving a bit of code around as they mostly called each other.

When looking at the AddFacility methods in the DefaultKernel_ObsoleteAPI I first tried just deleting them from the project, but then I noticed a compiler error because one of those are being used by the AddFacility method in the DefaultKernel with pragma flags. This got me round to thinking about the obsolete method (which at this point really did not feel so obsolete anymore). So I then reworked the method to get rid of the string key/ConfigurationStore dependency and put that implementation into the DefaultKernel. This got me round to thinking about how IFacility.Init is being called, because if we are deprecating the string key parameter from the public API then perhaps the intention here was also to get rid of IConfiguration from the IFacility.Init interface too? This is where I became a little unsure and thought putting through an experimental PR would be the right thing to do.
Based on your reaction, this is a cut too deep for how facilities work :)
What I can do is hide the obsolete method by making it internal and then just keep the convention of string key to mean looking up a configuration based on the facility type fullname.
What do you think?

I think we need to be much clearer with users if we are deprecating or removing support for XML configuration for any aspect of Windsor, XML configuration has been a big feature in Windsor's history with plenty of use out there, so I think it must be explicitly communicated with its own issue in the issue tracker even if that is just removing XML configuration support for facilities but it stays for installers (for example).

Most of the deprecation activities on #338 might be to big for v5 too, we can close that out and raise new issues for the items we discussed there. That said, there is still plenty of Obsolescence that could be cleaned up.

I'm not exactly clear what you are proposing, would you mind updating the pull request with what you are proposing.
I think that XML configuration is still quite valuable for facilities, many people have facilities not shipped in the box where they wire up the facility by code but much of the facility is configured by external configuration depending on where/how it is deployed.

I'm not exactly clear what you are proposing, would you mind updating the pull request with what you are proposing.

I have made the change I was talking about. Code reads better than English! :)
I think this can now be classified as a safe change. XML config preserved 👍

Let me know if I can squish.

I completely forgot about the exception. Let me add it before we merge.

@jonorossi - I added a test which asserts that any facility config with an 'id' attribute will now throw a ConfigurationProcessingException and squished down the commits.

Looks great, thanks.


Training stuck when running on Slurm with multiprocessing

Bug description
Hi,
I'm trying to train a model on Slurm using a single GPU, and in the training_step I call multiprocessing.Pool() to parallel some function calls (function is executes on every example in the training data).
When I run multiprocessing.Pool from the training_step, the call never ends. I added multiple logs and prints to the code, and I see that all function calls were executed, but the pool was never joined and it stays "hanging".
I tried running the same code not on Slurm and it works as expected. I also tried running the same function using multiprocess on Slurm outside the training_step and it also worked.
The only thing that doesn't work is running the program on Slurm, and run multiprocess inside the training_step.
The trainer definition is:
  trainer = pl.Trainer(
      max_epochs=100,
      callbacks=callbacks,
      default_root_dir=root_dir
  )

The training step (simplified):
 def training_step(self, batch: List[torch.Tensor], batch_idx: int) -> torch.Tensor:
        x, y = batch
        if self.project:
            with Pool() as pool:
                  x_projected = pool.starmap(self.projector.project, list(zip(x.to_cpu().numpy(), y.to_cpu.numpy())))
            x = torch.tensor(x_projected).float().to(x.device)
        logits = self(x)
        return self.loss(logits, y)

And the Slurm file:
    #! /bin/sh
    #SBATCH --job-name=job
    #SBATCH --output=logs/job.out # redirect stdout
    #SBATCH --error=logs/job.err # redirect stderr
    #SBATCH --partition=killable
    #SBATCH --time=1000
    #SBATCH --signal=USR1@120 # how to end job when time's up
    #SBATCH --nodes=1
    #SBATCH --ntasks=1
    #SBATCH --mem=2500 # CPU memory (MB)
    #SBATCH -c 8 # 8 cores
    #SBATCH --gpus=1
     python job.py

The lightning version I'm using is lightning 2.1.2.
Any ideas on what the problem is and how to solve it?
Thanks in advance!
What version are you seeing the problem on?
v2.1
How to reproduce the bug
No response
Error messages and logs
# Error messages and logs here please

Environment

Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 2.0):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
#- Running environment of LightningApp (e.g. local, cloud):

More info
No response

Hey @talshechter
Can you double check that you followed the SLURM guide thoroughly here
https://lightning.ai/docs/pytorch/latest/clouds/cluster_advanced.html#run-on-an-on-prem-cluster-advanced
And also check the troubleshooting section:
https://lightning.ai/docs/pytorch/latest/clouds/cluster_advanced.html#troubleshooting
Also, you are launching with python job.py but I'm pretty sure that should be srun python job.py which is very likely contributing to the problem. Note that using srun is really crucial for launching jobs like this one on SLURM.


file extension filter exclude

in the hidden_file filter is not any extension filter to hide all files with specific extension
i want to hide all jpg files for example
i tried *.jpg as input but it does not work
please add this feature or help me if it  exists

Try this
'hidden_files' => [
    *.jpg
    **/*.jpg
]

thanks, it worked!


Code snippets not showing more

Code snippets for auto complete are not showing more after recent updates

Are you still facing this problem?

Yeah. And scroll still too fast while selecting text

It made coding easier

Yeah. And scroll still too fast while selecting text

Try to clear app data then tell me what happened

Try to clear app data then tell me what happen to your problem after this
I have checked older versions and tested, uninstalled and reinstalled, the last release from july 26th looks good for me, and i am using it now

I removed it on purpose, soon there will be a plugin with better newer snippets.


Short solution needed: "Create Numpy vector" (python-numpy)

Please help us write most modern and shortest code solution for this issue:
Create Numpy vector (technology: python-numpy)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Create Numpy horizontal vector


pacaptr: Update to version 0.20.1

Closes #12348.

[x] I have read the Contributing Guide.

/verify


Topic creation

Create topics, as needed, on service start up and as part of system tests.
i.e. implement a basic ResourceHandler for topics.  https://github.com/creek-service/creek-kafka/issues/114 will look to add validation of pre-existing topics.

done


:grey_question: Semantic router on top of ollama :sloth:

:grey_question: About
I'd like to run semantic router fully locally with custom local functions.
Actually, this is possible (Local Dynamic Routes).
But currently, there is no dedicated Notebook that show how to do this (for example on mistral, openhermes or dolphin), except maybe using LangChain throught Intro LangChain Agents with Semantic Router.
:dart: Questions

Would you recommand use LangChain to pass the llm built on top on ollama
Would you share a dedicated Notebook that would put best practices available to community ?

:bookmark: Resources

Llama.cpp for FULL LOCAL Semantic Router (James Briggs)
🦙 ollama running local models w/LlamaIndex (CPU)
I'd like to port this agent demo (🦜🔗 Track Package Delivery w. Langchain Agent Custom Tools , based on Lanchain tools / gpt-3.5)
"Semantic Router superfast decision layer for LLMs and AI agents" on Geeky Gadgets

Hey @adriens it is possible thanks to a recent PR from @bruvduroiu — you can follow the /docs/05-local-execution.ipynb notebook or this video walkthrough of the same.
Main 'best practice' advise I can give for getting started is to implement some routes and then begin chatting with your agent. When you see routes bit being activated when they should, add that exact phrase to the Route.utterances — and build you your routes with that type of iterative process

Thanks a lot for the quick feedback @jamescalam .
In the code you mention, we have to reference the modelfile itself.
What I would like to do from my code is just :

assume ollama is running (ollama serve)
the proper model has already be downloaded by ollama
Build the llm on top of local ollama API

Is my approach correct ? From my point of view it would make local models even easier to intergrate (I mean as easy as openai's ones) :sweat_smile:

Fully local Semantic Router with llama.cpp and HuggingFace Encoder

hey @adriens I think this is now complete, you can find the example notebook for it here

I m going to give it à try and Will let you know

Great!

Hey, sorry for very late delay on my feedback.
I'm currently testing it with success on ollama, running a gemma2:9b.

    ],
)

It seems like it's not able to decide a route.
Any idea ?
I'll work on producing a concrete example within the next weeks, only on open source llms, and of course I will let you know. the outputs.

:gift: :point_down:

https://github.com/aurelio-labs/semantic-router/pull/346

Nous venons de dev.to. Félicitations pour votre projet. Tous nos encouragements. Nous avons enregistré votre article.

Merci pour le petit message bien sympa en français.  C  bien cool.🤩


REM units for max/min values?

Right now it only supports absolute pixels for max/min values. But this is problematic, as my webapp (and most modern webapps) set all sizes in REM units, which makes websites responsive to different display sizes. Having to set absolute pixels for this component only makes the text go out of proportions with the rest of the webapp.
Is it possible to allow setting min/max values in rem units?

Same Issue. This would be super helpful.


[Build Moot]: Investigate what it would take to mirror, then move, the Dart SDK

As discussed today in Flutter Build Moot (https://github.com/flutter/flutter/issues/67373).
We had an idea to check-out the Dart SDK into two locations (i.e. one within flutter/third_party/dart, within the engine repo), and whatever work is required to start getting our own repository pointing to it, including possibly upstreaming configurable root directories or build overrides.
This issue is for @chinmaygarde and @jason-simmons to pair in the next ~2 weeks and land anything incremental they can, and list out any blockers or changes we'd need the Dart SDK to allow or implement.
Let's aim for Monday February 26th for the next update.

@jason-simmons I performed a quick experiment moving //third_party/dart one level up and replacing all instances of //third_party/dart with a variable that we can configure.
Oddly, I was able to get past GN and only the some GN scripts that referenced Dart snapshots were broken.
This I suppose makes sense because Dart itself is a library and it can't care too much about which buildroot it operates in. It already operates in two (Flutter and its own). I didn't have the change the GN rules in Dart itself because they don't assume they are at the root of the buildroot (reference "//" directly like our scripts do).
Not sure if I am missing anything but adding the variable, then tinkering on making the post move build work and then migrating the build should be all thats required.
Am I missing anything?

After applying https://github.com/flutter/engine/pull/50573 I was able to get a Linux host_debug_unopt build to work with these steps:

rename src/third_party/dart to src/third_party/was_dart and symlink it into src/flutter/third_party/dart
remove //flutter/* from the gn check target list in https://github.com/flutter/buildroot/blob/master/.gn#L18

Dart is not compliant with the #include dependency rules enforced by gn check

patch https://github.com/flutter/engine/blob/main/tools/pub_get_offline.py#L122 to use the src/flutter/third_party/dart directory

then rerun the src/flutter/tools/pub_get_offline.py script

patch https://github.com/flutter/engine/blob/main/lib/snapshot/libraries.json to change the include path to use ../../third_party

I'd be in favor of doing the migration with something like https://github.com/flutter/engine/pull/50573.  But we will need to try every target on our CI (and consumers of our build scripts like Dart CI) to find all other references to src/third_party/dart and ensure that they are updated.

Good. I was going to suggest we keep dart_src at //third_party/dart and land everything. Then toggle it to //flutter/third_party/dart in another patch. But I don't know how to do this for the pubspec references. Perhaps that will just be a larger patch and hope for the best?

@jason-simmons Would you like me to submit just the patch to add and use dart_src? Since dart.gni is going to in the tree, the Dart CI HHH bots should be none the wiser.

SGTM - landing the patch with dart_src set to the current src/third_party/dart directory should be safe.
After that, we'll need to work with the Dart team to ensure that their infrastructure can support a tree where src/third_party/dart has been replaced by src/flutter/third_party/dart

Yay! This is awesome!

I believe I have caught all stragglers in https://github.com/flutter/engine/pull/50624. PTAL.

I landed the patch to introduce the GN variable. Going to context switch to https://github.com/flutter/flutter/issues/142082 for a little bit. Clearing my assignment.

The GN variable is not provided on the monorepo (HHH) bots, so the build now fails on them.  This change should also set dart_src to the correct values for those builders.

I created a branch patched to build the Flutter engine with the Dart SDK moved to //flutter/third_party/dart:
https://github.com/jason-simmons/flutter_engine/tree/buildmoot_dart_to_flutter_third_party
@zanderso

The change to monorepo roller that is needed to handle Dart SDK in the new location: https://dart-review.googlesource.com/c/monorepo/+/355381
This has been tested: the branch with the moved SDK was checked out to the engine repo in a monorepo checkout, this roller script was run, and then the new monorepo DEPS was used to check out and build engine and the SDK.


Naming conflicts

Seriously, everybody on earth and maybe up to the international space station uses the terms "Modern C++" for C++11 / C++14.
e.g. Effective Modern C++, etc... http://shop.oreilly.com/product/0636920033707.do
There is also "Modern C++ and Windows Store" that already has a foot hold in the Windows-specific world : http://www.amazon.fr/Modern-C-Windows-Store-Apps/dp/0989020800/ref=sr_1_5?s=english-books&ie=UTF8&qid=1438185205&sr=1-5&keywords=modern+c%2B%2B

That’s why it’s called "Modern C++ for the Windows Runtime". There's only one standard C++ language projection for the Windows Runtime and this is it.
Plus naming is hard. 😊


Regenerate docs/Manpage.md and manpages/brew.1

They appear to be out of date.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

¯_(ツ)_/¯

Looks like your local copy of the Homebrew/bundle tap might not be up-to-date.

brew update-reset homebrew/bundle fixed it. Thanks for your help, Dawid.


Use 'Roboto' font instead of 'Helvetica Neue' on android

fix for bug #30 - Problem with 'Helvetica Neue' font on android

Seems good to me. @joshjhargreaves


FALCON-1765 Test Pull Request

Improved README.md formatting and removed the license.

It was a test pull request, closing it.


Added TypeScript Definition

When Googling for TypeScript definition I found that other people were looking for them as well (#274), so I made one. Any feed back would be great.

I have no idea why the Travis CI build failed. I did not make any code changes, just added the definition file. The error is for PhantomJS when doing something with the fakeServer. You may want to make sure that your npm test is still working

Thank you @larrybahr I will take a look!

@hilios do you plan to accept the pull request? Is there anything I can do to help with your decision?

Man thanks for your contribution. The only thing that bothers me are the failing tests, and would be great if you could add some tests for the typescript module as well. If everything is green I will push the merge button right away.

I understand your hesitation, but it looks like the last few pull requests have the same error. I also downloaded a clean copy of your repo and ran the "grunt test" which failed. Can you confirm that the test still works? Do I need a specific version of Node for this to work? Travis-ci is using v0.10.48. Is that required?

@hilios Did you confirm the test still works? The new code should not even hit a test case because it just describes the code (it is a type definition file).

@hilios I do not think the tests work. Can you confirm they are working for you.

@hilios I can see the last commit to this repo is Dec 31, 2016. The Travis CI builds look like they always fail even for the unmodified code in the master branch. Should I assume this project is dead and my pull request will never be merged?


Client Allocation Request for: Sergii Glushkovskyi

Client Allocation Questions
Core Information

Name: Sergii Glushkovskyi
Website / Social Media: https://twitter.com/virdvip
Region: Europe
DataCap Requested: 100GiB
Addresses to be Notarized: f1wti2vbpjg4nmemk4gdooi6ycwicc6todx2gknhi
Notary Requested: westlabsventure

@vird Please subscribe to notifications for this Issue to be aware of updates. Notaries may request additional information on the Issue.

Sorry for dupe https://github.com/filecoin-project/filecoin-plus-client-onboarding/issues/2543


WIP Added JSON type to MySQL and PostgreSQL schema

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
no

Tests pass?
yes

Fixed issues
#13019, #15247

This is fixed and tests enriched PR #13783.
Correct realization of PR #15266.
Status: working on tests stabilization under new versions of DBs.

@zhukovra would you please merge with master? Also... what's left for the pull request to be finished?

@samdark I'll try finish PR today or tomorrow.

Please pay attention to changes introduced by https://github.com/yiisoft/yii2/pull/15348

I've found a bug with JSON column type in MySQL that will not be fixed in PHP < 5.6. Failed test is here.
What do I need to do with it? Should I use version_compare() for making that test pass?

Yes, throw exception and leave a TODO comment to drop this check in Yii 2.1

@SilverFire @samdark please review.

As I understand, this PR fixes everything that #15266 was going to fix, right?

@samdark I think that bugs #15266 was fixed by @SilverFire. PR updated. Thank you for review.

A line for changelog is needed.

Merged. Thank you!

Hello every one!
I have a question about new json support on PostgreSQL.
Is it way to create a json field by migration now?
I mean not a "jsonb" but "json"  type.
example
$this->createTable('table_name', [
            "id" => $this->bigPrimaryKey(),
            "body" => "json",   // warning "json" generates jsonb type
        ]);

First my think - is create own QueryBuilder width $typeMap = [
....
"json_raw"  => 'json'
]
and use json_raw abstraction type.

@titanproger Hi, i also encountered this issue, may be you created a new issue?


Error in Date patterns after modify the Academic session dates

When you have defined an Academic Session an a Date Pattern and modify the start date of the session, automatically modify the date patterns class days.
Example

Create a session that starts on Monday September 7, 2015
Create a Date pattern and select the class days (weekly from Monday to Friday - 5 consecutive days)
Change the start date of the session to Tuesday 1 stiembre 2015
The Date patterns created modify the class days from Tuesday to Saturday (5 days consecutive but displaced from Tuesday).

This is not a bug. The date patterns are intentionally made relative to the academic session begin date (a date pattern is stored as a bit map (1 or 0 for each day) and an offset between the academic session start and the first day of the bit map). This makes the date patterns very easy to move between academic sessions.
Similarly, examination periods are relative to the examination begin date that is set on the academic session too.


[Feature request] Add support for gravatar

:bulb: Idea
I don't know why but seeing my avatar of bitzer every time i log in to something makes me happy.
Can we add support for gravatar so that the nice green person icon turns into a sheepdog for me?
Perhaps othes use this too 😄

I think the user management would need more features. Gravatar works with email addresses, but currently ntfy users don't need one. Are there plans to update user managment, such as a forgot password link and other things that would require and email address?

By the way, in case of implementing gravatar, it would be nice to also add libravatar support.

I think both of those use a hash of the email.... they could just enter the email once on user creation IF they wanted their gravatar logo,  and just store the hash alongside? though I suppose libravatar would also need the server address....


[joss] Add missing DOI

Part of: https://github.com/openjournals/joss-reviews/issues/7286
Is https://doi.org/10.1017/cbo9780511617652.004 the same as the Lorenz 1996 paper you are citing, or is that a different work? Just want to check to satisfy our very picky DOI checker, close this if those are two different citations.

I think this is the citation for dask
@InProceedings{ matthew_rocklin-proc-scipy-2015,
  author    = { {M}atthew {R}ocklin },
  title     = { {D}ask: {P}arallel {C}omputation with {B}locked algorithms and {T}ask {S}cheduling },
  booktitle = { {P}roceedings of the 14th {P}ython in {S}cience {C}onference },
  pages     = { 126 - 132 },
  year      = { 2015 },
  editor    = { {K}athryn {H}uff and {J}ames {B}ergstra },
  doi       = { 10.25080/Majora-7b98e3ed-013 }
}

Regarding the Lorenz, 1996 citation, I saw that suggestion, but I don't think it's correct. I also don't have access to that reference, so I'm not sure. This citation is from a conference and is highly cited, but the way that it's cited varies a lot between publications. The citation I gave is the best one that I can come up with unfortunately (it's the one our group has been using).
As for the dask citation, that's interesting. They used to list the citation I gave on their documentation page as "How to Cite", but I don't see that anymore... I'll add the citation you listed as well just to cover my bases here.

I don't think it's correct.

Got it! you know better than me.

I don't see that anymore

odd... well when in doubt you can double-cite: citations are free to make and costly (to the cited authors) to miss. neutral on this change, either/or works for me.
feel free to close this once you merge #80

Strong agree: it's easy to cite, but is a shame not to be appropriately cited. I added both dask citations in the text.


[v2.12] mavsdk_server: fix autopilot discovery

Instead of using the subscribe_on_new_systems callback, we just use a while loop here. That's because the subscribe_on_new_system callback won't tell us if an autopilot is discovered when another component of the same system is discovered first, thus triggering the callback early when no autopilot is around.

Yes, but that was the assumption before as well:
https://github.com/mavlink/MAVSDK/pull/2388/files#diff-7b7dbd5a57f1ca31f7681654158233825a19e674d05e6a7877785538fc808976L61

Thanks @JonasVautherin. I'm going to deploy and test this now :crossed_fingers:.

Yes, but that was the assumption before as well:

Oh, right :man_facepalming:


Formatting cleanup

Dispatches the float formatting to DoubleOps and resolves some formatting issues, for example:
import System
assert format(-1111, "08,d") == format((-1111).ToBigInteger(), "08,d")

Prep work for PEP 515 https://github.com/IronLanguages/ironpython3/issues/105.

Don't forget to update tests...


Update inv-transform.R (unif_binomial function)

Support for binom(n,p) is 0,1,2,...,n. Previous code does not count for this.
Also, integer returned by cut function will not include 0, that's why subtracting 1 to shift the output by 1.
their might be some function that perform the following task without this way around. But i am new to R

Thanks, @rohitrk06 - keep it coming.


handle repeated variable names

Another way would be to add a makeunique keyword argument to readcsv (in this case, when makeunique= false, names should be checked early rather than failing after parsing the whole file).

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #15   +/-   ##
=======================================
  Coverage   75.95%   75.95%
=======================================
  Files           4        4
  Lines         965      965
=======================================
  Hits          733      733
  Misses        232      232

Impacted Files
Coverage Δ

src/TableReader.jl
89.32% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c71e44...3991f42. Read the comment docs.

Thank you! I think this is nice to have.


READ THIS ISSUE FOR WORKING HACKS

If you pay attention everyone has figured out this Gliz is fake. If you are looking for working hacks check out mine, or minesrafts2 we both have working hacks that are maintained.

Yea minesraft is good

Try mine lol


Quick fix for 1.8.x IMAGE_TAG

It needs to be IMAGE_TAG='_2-5' as the underscore is no longer included in the hard-coded part of the image tag for backwards-compatibility with release/1.8.x.

I moved everything >= 1.8 to using IMAGE_TAG without _ in it. That's part of the .yml files now.

merged in https://github.com/EOSIO/eos/pull/7458


we should encourage the framework tox tag

see https://docs.pytest.org/en/latest/writing_plugins.html#making-your-plugin-installable-by-others for Pytest example
  classifiers=[
        "Framework :: tox",
    ],

Fixed via https://github.com/tox-dev/cookiecutter-tox-plugin/commit/e405a9446a5370e24d443a4522cf84452f95370c.


Sending mails creates a new connection and they are never closed again

Describe the bug
When using the mail-send connector, a new connection to the mail server is created and this connection is never closed.
We stumbled over this because a mail server started refusing mails with a messaging stating that there are too many open connections from the host running our Camunda instance.
Steps to reproduce

Create a process with a task using the the mail-send connector.
Run the process multiple times.
Check the connections to the mail server (e.g. using netstat).

Expected Behaviour
Either

The connector closes the connection after sending the mail.
or
There is only one connection to the mail server and this is reused.

The second option would be better in terms of performance but I don't know if there could be thread-safety problems when multiple (sub)processes are running in parallel.
For the first option, one could also think of making this configurable. Meaning: take an input like "keep-connection" and if it is set, the connection is not closed but instead, there is a method, for example on the MailService, which allows closing the current connection (transport). This would allow the process developer to have control about the lifetime of the connection.
Library version
1.3.0
Camunda version
7.17.0
Camunda Distribution
Tomcat
Other Camunda distribution
No response

Hello @j-ulrich ,
thank you for submitting feedback.
I am currently working on a spring-boot-starter for this project that required some refinement of responsibilities of the components so I took the chance to have a look at connection management as well.
In #89 , your issues should be fixed as all connections (Store and Transport) are closed as soon as they are not needed anymore.
Currently, I am not planning to make this configurable as the number of concurrent connections should not be too high. If you have a different opinion and would like to see some kind of "connection pool", we can discuss this.

That's fine for me! Thank you for the quick response!


can't parse multiline messages

Our socket.io configuration works okay when a one line message is received;

  engine handling "POST" http request "/socket.io/?transport=polling&sid=D4hHosMaFHKF2xZAAAAA" +0ms
  engine setting new request for existing client +1ms!
  engine:polling received "20:42["message","test"]" +0ms
  engine:socket packet +0ms
  socket.io-parser decoded 2["message","test"] as {"type":2,"nsp":"/","data":["message","test"]} +8.2m
  socket.io:socket got packet {"type":2,"nsp":"/","data":["message","test"]} +6m
  socket.io:socket emitting event ["message","test"] +0ms
But when a multiline message is send it looks like socket.io-parser can't decode the packet;

  engine handling "POST" http request "/socket.io/?transport=polling&sid=D4hHosMaFHKF2xZAAAAA" +0ms
  engine setting new request for existing client +0ms
  engine:polling received "27:42["message","test2
test3"]" +1ms
  engine:socket packet +0ms
  socket.io:client no socket for namespace undefined +1m
Any thoughts on how can I solve the issue?
Thank you

As far as I tested, couldn't reproduce the issue. How can we reproduce?
socket.send('foo\nbar')
  engine handling "POST" http request "/socket.io/?EIO=3&transport=polling&t=1432835971871-2&sid=ajyrofMpkOgvBwHAAAAA" +0ms
  engine setting new request for existing client +1ms
  engine:polling received "24:42["message","foo\nbar"]" +2ms
  engine:socket packet +1ms
  socket.io-parser decoded 2["message","foo\nbar"] as {"type":2,"nsp":"/","data":["message","foo\nbar"]} +246ms
  socket.io:socket got packet {"type":2,"nsp":"/","data":["message","foo\nbar"]} +242ms
  socket.io:socket emitting event ["message","foo\nbar"] +0ms

Closed due to inactivity.


Some place name resolver fixes

Do batching when calling our recon API
Handle cases where multiple rows return the same placeId

Thanks!


Target group selection

Hello,
Today I've been doing some troubleshooting on our ALB setup and realized that all of our instances are getting added to the target group independently on which ones are running the alb controller pod.
Is this the expected behaviour ? The instance that don't have any alb controller pod running are marked as unhealthy really quickly so there is a very small amount of time that a request could potentially be routed to them.
Want to make sure we don't have something wrong with our setup.
Thanks before hand!

Hi,  This is the expected behavior.
But are you using external-traffic=Local in your service? With  external-traffic=Local, nodes will only route traffic to pod on it's own machine(the health check will ensure traffic not send to these nodes).
With the default mode external-traffic=Cluster, nodes will route traffic to pods(maybe on another node), so that all nodes can be used as target, no matter there are pods on it or not.

BTW, you may be intested in alb.ingress.kubernetes.io/target-type: ip if you are using EKS's CNI. Which will directly register pods ip as targets.

@M00nF1sh target-ip is exactly what I was looking for. This actually solved some issues that we were having with kube-proxy not handling the health check correctly.
Thanks!!


Project init

Hi,
I forked the project but can't achieve to lauch gulp correctly. Seems to have a problem with bower's path directory or something like this...
I ran npm install && bower install. Is there anything else I forgot ?

Can u pls copy  the error message? It should be okay with the following commands:
npm install
bower install
gulp

@lellex Is that solved your issue?

Do you still have this problem?
2015-07-10 9:28 GMT+02:00 Alexandra J<EMAIL_ADDRESS>
Hi,
I forked the project but can't achieve to lauch gulp correctly. Seems to
have a problem with bower's path directory or something like this...
I ran npm install && bower install. Is there anything else I forgot ?
—
Reply to this email directly or view it on GitHub
https://github.com/iamisti/md-data-table/issues/23.


Modifying Headers Crashes

Attempting to render a picture of a page that displays my http headers.
i added custom headers the image appears encoded.
I modified my header to include: "Accept-Encoding" : "gzip"
Attached is the image of the resulting page.
Not sure how to attach crash dump.

Sad to say, PhantomJS doesn't support gzip-encoding right now.  We're tracking that as bug #13621.


Request lops verification

This card relates to
Respond to and inform evolving work flows and policy changes
Background
Assessors have selected applications where the LoPS needs to be verified with the competent authority.
Admin staff will send the verification request and a copy of the LoPS via Zendesk to the competent authority. The action taken will be captured in the ‘Verify LoPS’ task with the verification spoke.
See ticket https://trello.com/c/BNgKYYpw/2306-request-lops-verification for screenshots

I've cherry-picked this commit in to https://github.com/DFE-Digital/apply-for-qualified-teacher-status/pull/1722.


Feature request: Show what a symlink file points to

It would be useful to see what a symbolic file points to in fx. It would also help differentiate between normal files and symlink files.
ls -l when done in a directory with symlink shows an arrow between a the symlink file and file it links to like so:

You can distinguish symlink file and normal file by their colors: See config.yaml.
Printing the pointed item path might be helpful. I'll think about it.

Implemented via #289


🐞 Bug Report: goji --init provides an unexpected configuration file

🐞 Describe the bug
Installed version 0.0.1-rc2

Run goji --init
Content file is different from here

Properties are in lowercase
entity is not in documentation
Missing "Types"
Object not sorted

The generated file:
{
  "Types": [
    {
      "emoji": "✨",
      "entity": "",
      "code": ":sparkles:",
      "description": "Introduce new features.",
      "name": "feature"
    },
    {
      "emoji": "🐛",
      "entity": "",
      "code": ":bug:",
      "description": "Fix a bug.",
      "name": "fix"
    },
    {
      "emoji": "📚",
      "entity": "",
      "code": ":books:",
      "description": "Documentation change.",
      "name": "docs"
    },
    {
      "emoji": "🎨",
      "entity": "",
      "code": ":art:",
      "description": "Improve structure/format of the code.",
      "name": "refactor"
    },
    {
      "emoji": "⚡",
      "entity": "",
      "code": ":zap:",
      "description": "Improve performance.",
      "name": "perf"
    },
    {
      "emoji": "🚑",
      "entity": "",
      "code": ":ambulance:",
      "description": "Critical hotfix.",
      "name": "hotfix"
    },
    {
      "emoji": "🚧",
      "entity": "",
      "code": ":construction:",
      "description": "Work in progress.",
      "name": "wip"
    },
    {
      "emoji": "📦",
      "entity": "",
      "code": ":package:",
      "description": "Add or update compiled files or packages.",
      "name": "package"
    }
  ],
  "Scopes": [
    "home",
    "accounts",
    "ci"
  ],
  "Symbol": true,
  "SkipQuestions": [],
  "SubjectMaxLength": 50
}

📖 Expected behavior

Running goji --init should generate this .goji.json
Properties are sorted on property Name in an ascending order

🌅 Screenshots
N/A
💻 Desktop
MacOS 13.3 (22E252)

my intention for the --init was to generate a more compact version of the example .goji.json and the users will customize their config file with gitmoji.
Still i'll update to be as extensive as the example in .goji.json

fixes will be added to v0.0.1-rc3

Ok thank you, nice reactivity ;)


[NoQA] Replace iOS provision profile to allow dev builds from XCode

@AndrewGable @neil-marcellini
Details
When I generated the Expensify Dev provisioning profile I selected AdHoc instead of development. This prevented us from building to physical devices from XCode.
Fixed Issues

$ https://github.com/Expensify/Expensify/issues/314417
Tests

MAKE SURE I DIDN"T UPLOAD A NON-GPG SIGNED FILE!!!
Pull the changes from this branch
Download the updated expensify_chat_dev prov profile
In XCode, select the NewDot scheme, then ensure you have Debug Development selected as the Capability [1]
Select the provisioning profile, then select import and locate the updated provisioning file you downloaded earlier [2]
The app should now build to a physical device (you may need to run 'Product > Clean Build Folder')

If so, you'll then need to reinstall pods with cd ios && pod install

Offline tests

N/A
QA Steps

N/A
PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos
Only iOS is relevant here

Where is the encrypted profile used? I thought we just had to update this on Apple's backend.

Also IDK how to do the first test step

Where is the encrypted profile used? I thought we just had to update this on Apple's backend.

@AndrewGable oh interesting. I assumed all certs had to be committed, but that would make sense.
The app builds from main, so that seems to confirm things. I won't use this PR to delete the existing dev cert, as Rory's PR is going to do that anyway.


regression for input select with floating label

Ionic version:  (check one with "x")
[ ] 1.x (For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[X ] 3.x
I'm submitting a ...  (check one with "x")
[X ] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:
After the user completes his choice, the floating label returns back over the user's input.
Expected behavior:
the label has to remain "up"
Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
global packages:

    @ionic/cli-utils : 1.4.0
    Cordova CLI      : 7.0.1
    Ionic CLI        : 3.4.0

local packages:

    @ionic/app-scripts              : 1.3.7
    @ionic/cli-plugin-cordova       : 1.4.0
    @ionic/cli-plugin-ionic-angular : 1.3.1
    Cordova Platforms               : android 6.1.2 browser 4.1.0
    Ionic Framework                 : ionic-angular 3.4.0

System:

    Node       : v7.7.1
    OS         : Linux 4.10
    Xcode      : not installed
    ios-deploy : not installed
    ios-sim    : not installed
    npm        : 4.1.2

same here, using 3.4.0, label floats on top of the element when input has some text.

Can you provide some source code that reproduces the issue?

nothing special:
        <ion-label stacked>Gender</ion-label>
        <ion-select okText="ΟΚ" cancelText="Cancel" formControlName="selectedGender" multiple="false" [(ngModel)]="petGender">
          <ion-option>Male</ion-option>
          <ion-option>Female</ion-option>
        </ion-select>

demo:
https://media.giphy.com/media/xUA7aLZp1Qfhgnhgti/giphy.gif

This is till an issue in 3.5.3
Use Floating input with type="number" then enter any non number character and it will overlap.

It's because you did not contain ion-input and ion-label in ion-item. Inside that container everything work great. So I don't know if it should work like that.


refactor compiler as struct

The compiler functions in package compiler need to be refactored into receivers on a compiler data structure.  Then we can put zctx and scope in the struct.  As the compiler gets more sophisticated, more state will move into this struct.

Closing as this more or less has been done via the creation of the semantic analysis pass and the compiler.Runtime type.


URLs with consecutive hyphens aren't working

Example
This is a working website: hp--community.force.com.
linkify.test('hp--community.force.com'); // returns false. Expected to be true
linkify.test('hp-community.force.com'); // returns true

@saadmb apologies for the delayed reply, the fix for this is now available in the latest v4.2.0 release.


Format small header files

This PR runs clang-format on header files smaller than 100 LOC.

src/gui_gtk_f.h needs to be updated. It has extern "C".

I've fix the problem that was making the tests fail. So I think this is mergable now

may I ask why you changed spacing on os_haiku.h on the usr_ section just out of curiousity nothing more?

Of course! If you weren't aware we are making an effort to standardize the overall styling of the C core. To do that I've made a PR (#16019) to use clang-format for formatting the source code based on the updated style guides (#15939). This PR is simply one of the many PR that will come to simply run the formatter on the source code.

Is everyone really sure this is a good idea? Bram had clearly included a lot of alignment in these files for readability and that is all removed here.
-#define CharOrd(x)	((x) < 'a' ? (x) - 'A' : (x) - 'a')
-#define CharOrdLow(x)	((x) - 'a')
-#define CharOrdUp(x)	((x) - 'A')
-#define ROT13(c, a)	(((((c) - (a)) + 13) % 26) + (a))
+#define CharOrd(x) ((x) < 'a' ? (x) - 'A' : (x) - 'a')
+#define CharOrdLow(x) ((x) - 'a')
+#define CharOrdUp(x) ((x) - 'A')
+#define ROT13(c, a) (((((c) - (a)) + 13) % 26) + (a))

-    GtkWidget		*target;	// widget we are monitoring
-    GtkWidget		*balloonShell;
-    GtkWidget		*balloonLabel;
-    unsigned int	timerID;	// timer for run
-    BeState		showState;	// tells us what's currently going on
+    GtkWidget *target; // widget we are monitoring
+    GtkWidget *balloonShell;
+    GtkWidget *balloonLabel;
+    unsigned int timerID; // timer for run
+    BeState showState; // tells us what's currently going on

Is everyone really sure this is a good idea? Bram had clearly included a lot of alignment in these files for readability and that is all removed here.
-#define CharOrd(x)	((x) < 'a' ? (x) - 'A' : (x) - 'a')
-#define CharOrdLow(x)	((x) - 'a')
-#define CharOrdUp(x)	((x) - 'A')
-#define ROT13(c, a)	(((((c) - (a)) + 13) % 26) + (a))
+#define CharOrd(x) ((x) < 'a' ? (x) - 'A' : (x) - 'a')
+#define CharOrdLow(x) ((x) - 'a')
+#define CharOrdUp(x) ((x) - 'A')
+#define ROT13(c, a) (((((c) - (a)) + 13) % 26) + (a))

-    GtkWidget		*target;	// widget we are monitoring
-    GtkWidget		*balloonShell;
-    GtkWidget		*balloonLabel;
-    unsigned int	timerID;	// timer for run
-    BeState		showState;	// tells us what's currently going on
+    GtkWidget *target; // widget we are monitoring
+    GtkWidget *balloonShell;
+    GtkWidget *balloonLabel;
+    unsigned int timerID; // timer for run
+    BeState showState; // tells us what's currently going on

I did raise my concerns about this change earlier.  The alignment of variables and macro definitions improves readability.

Readability is subjective. For example I find much more readable the formatted version. The thing that it is much important, at least in my opinion, is consistency and a formatters ensures that. Unfortunately the alignment of variables isn't really reliable with automated tooling so we need to make the trade of for better consistency with less work from maintainers.

Readability is subjective. For example I find much more readable the formatted version.

I have been contributing and working with the Vim source code for 25 years now.  I find the alignment of variable names in the
Vim source code more readable.  Without this, the variable declarations will be very crowded (as seen in the example above).

I find the alignment of variable names in the
Vim source code more readable.

Agree. I think some "Align" settings need to be enabled.
Also, it might be better to disable some "BraceWrapping" settings.
--- a/.clang-format
+++ b/.clang-format
@@ -18,16 +18,16 @@ AlignConsecutiveBitFields:
   AlignFunctionPointers: false
   PadOperators: false
 AlignConsecutiveDeclarations:
-  Enabled: false
-  AcrossEmptyLines: false
-  AcrossComments: false
+  Enabled: true
+  AcrossEmptyLines: true
+  AcrossComments: true
   AlignCompound: false
   AlignFunctionPointers: false
   PadOperators: false
 AlignConsecutiveMacros:
-  Enabled: false
-  AcrossEmptyLines: false
-  AcrossComments: false
+  Enabled: true
+  AcrossEmptyLines: true
+  AcrossComments: true
   AlignCompound: false
   AlignFunctionPointers: false
   PadOperators: false
@@ -39,7 +39,7 @@ AlignConsecutiveShortCaseStatements:
 AlignEscapedNewlines: DontAlign
 AlignOperands: Align
 AlignTrailingComments:
-  Kind: Leave
+  Kind: Always
   OverEmptyLines: 0
 AllowAllArgumentsOnNextLine: false
 AllowAllParametersOfDeclarationOnNextLine: false
@@ -63,13 +63,13 @@ BraceWrapping:
   AfterCaseLabel: true
   AfterClass: true
   AfterControlStatement: Always
-  AfterEnum: true
-  AfterExternBlock: true
+  AfterEnum: false
+  AfterExternBlock: false
   AfterFunction: true
   AfterNamespace: true
   AfterObjCDeclaration: true
-  AfterStruct: true
-  AfterUnion: true
+  AfterStruct: false
+  AfterUnion: false
   BeforeCatch: true
   BeforeElse: true
   BeforeLambdaBody: false
@@ -196,7 +196,7 @@ SpaceBeforeParens: ControlStatementsExceptControlMacros
 SpaceBeforeRangeBasedForLoopColon: true
 SpaceBeforeSquareBrackets: false
 SpaceInEmptyBlock: false
-SpacesBeforeTrailingComments: 1
+SpacesBeforeTrailingComments: 2
 SpacesInAngles: Never
 SpacesInContainerLiterals: true
 SpacesInLineCommentPrefix:

I think I don't really want to argue about this anymore... It was a pleasure to work with you all but I think my ideas are not aligned with the current maintainers and the general direction that vim has. I simply don't want to burn their and my energy for arguing about changes they do not want.
Thank you all

I totally understand you. But nevertheless thanks for all your work you did on Vim.


RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!

I run the following redesign code
Redesign a Protein
from chroma import Protein, Chroma
chroma = Chroma()
protein = Protein('1GFP')
protein = chroma.design(protein)
protein.to("1GFP-redesign.cif")
It comes with errors (attached).
errors.txt

I did not have any problems before today I run "apt --fix-broken install" to fix some inconsistency issue.
Here is the apt log file (attached).
history.log

The problem happens when chroma.design() is used. I found cuda was not available before the nvidia driver was updated, therefore all tensors used 'cpu'. Now cuda is available, the RuntimeError persists; there is no problem with other examples except for the redesign.

hey,
have you tried  protein = Protein('1GFP', device='cuda') ?

hey,
have you tried protein = Protein('1GFP', device='cuda') ?

Thanks. It works now. I thought somewhere I should specify the device, but I could not find chroma.design.


Get-Node should retrieve Object/Node from pipeline

Get-Node should retrieve Object/Node from pipeline so that it can function as a parent node selector for Get-ChildNode.

Fixed 0.1.0


JAMES-3566 Skip EmailSubmission/set implicit Email/set call when no onSuccessXXX properties

Just rebased to squash commits


Use extension-scripts for toolchain

Replace the current rollup, webdoc, tsconfig, etc options and scripts with standard implementations from @pixi/extension-scripts.

WOW.


[BUG] Missing attributes with multiple inheritance in pure Python

Describe the bug
In trying to create a Python class that subclasses an extension type and a pure Python class in pure Python, am running into issues with attributes missing from one of the base classes. Whichever base class is listed later in the subclass, appears to have its attributes missing. Not sure if I'm just missing something or if this is a bug.
To Reproduce
Code to reproduce the behaviour:
from cython import cclass, double

@cclass
class A:
    _x: double

    def __init__(self, x: double = 0, **kwargs):
        self._x = x

    @property
    def x(self):
        return self._x

class B:
    def __init__(self, y=2, **kwargs):
        self.y = y

class C(A, B):  # swapping the order to `B, A` results in `x` being missing
    def __init__(self, x=0, y=2):
        super().__init__(x=x, y=y)
        print((self.x, self.y))  # <--- AttributeError: 'C' object has no attribute 'y'

c = C(3, 4)

Expected behavior
Would like both attributes to remain visible/usable in the subclass C.
Environment (please complete the following information):

OS: macOS
Python version: 3.8.6
Cython version: 0.29.21

Additional context
NA

This is definitely not a bug. Try it in Python!

The rules for inheriting extension types are somewhat fiddly, but generallycdef classes can only be the first class in the inheritance list (so (B, A)` shouldn't work).
super calls the next constructor in the chain but nothing calls B.__init__. Generally you'd either call super().__init__ in the base classes or call B.__init__ directly from C.__init__.

Yep you’re right. Thanks for the direction. Adding super calls in the base classes fixes this issue 🙂


Typo in the example of the documentation of the plugin. The 'clipboard' part is missing from the function calls.

There is a typo in the example of the documentation of the plugin. The 'clipboard' part is missing from the function calls. The  example in the documentation did not work when using the phonegap build.
Incorrect example:
var text = "Hello World!";
window.plugins.copy(text);
window.plugins.paste(function (text) { alert(text); });
This is what it should be:
var text = "Hello World!";
window.plugins.clipboard.copy(text);
window.plugins.clipboard.paste(function (text) { alert(text); });

@leondroog submit a PR?


[@lit-labs/eleventy-plugin-lit] Make releasable and README fixes

Make @lit-labs/eleventy-plugin-lit releasable in the next publish.
Also use the term "polyfill" instead of "ponyfill" because the distinction seems more confusing than helpful.
Also fix a typo.

I think 'polyfill'/'ponyfill' can both be used if consistent. I got confused because the blog used polyfill. LGTM!

Yea, see https://github.com/lit/lit.dev/pull/688#discussion_r800899800


Not Working : Listening to row level changes

Hi, I want to listen for row level changes but it doesn't work. (unfortunately, all table is listening.)
SupabaseTable<ScoreModel> reference = _supabaseClient.From<ScoreModel>();
reference = (SupabaseTable<ScoreModel>) reference.Filter("user_name", Constants.Operator.Equals, "demo");

   if (reference != null)
            {
                await reference.On(Client.ChannelEventType.Update, (_, ev) =>
                {
                    Debug.Log($"[{ev.Response.Payload.Record}");
                });
            }

I would really appreciate if you can help

SOLVED
Supabase.Realtime.Client client = await _supabaseClient.Realtime.ConnectAsync();

            try
            {
                var channelUsers = await client.Channel("realtime", "public", "scores",
                    "user_name", "demo").Subscribe();

                channelUsers.OnUpdate += (object s, SocketResponseEventArgs args) =>
                {
                    Debug.Log(args.Response.Model<ScoreModel>().Score);
                };
            }
            catch
            {
                // ignored
            }


MudTable Scrollbar

Bug type
Component
Component name
MudTable
What happened?
MudTable shows scrollbar even in case when no scrollbar is needed (all data are displayed) if MudToolTip is used in <RowTemplate>
Ho to reproduce:
<MudTable Items="@tableItems">
    <RowTemplate>
        <MudTooltip Style="overflow: hidden" Text="Editace">
            <MudTd DataLabel="Item">@context</MudTd>
        </MudTooltip>
    </RowTemplate>
    <PagerContent>
        <MudTablePager />
    </PagerContent>
</MudTable>

@code
{
    List<string> tableItems = "Item1,Item2,Item3,Item4,Item5,Item6,Item7,Item8,Item9,Item10,Item11,Item12,Item13,Item14,Item15,Item16,Item17,Item18,Item19,Item20,Item21,Item22,Item23,Item24,Item25,Item26,Item27,Item28,Item29,Item30,Item31,Item32,Item33,Item34,Item35,Item36,Item37,Item38"
        .Split(",").ToList();
}

Example is here: https://try.mudblazor.com/snippet/GEwbEXmSJldjcpOC

Expected behavior
It is expected to display table without scrollbar.

Reproduction link
https://try.mudblazor.com/snippet/GEwbEXmSJldjcpOC
Reproduction steps

Display tabel from link https://try.mudblazor.com/snippet/GEwbEXmSJldjcpOC

Relevant log output
No response
Version (bug)
5.1.2
Version (working)
No response
What browsers are you seeing the problem on?
Firefox, Chrome
On what operating system are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This is caused by Tooltip (some ot the popover/portal issues) and will ve fixed in next release. If you place tooltip inside of MudTd with overflow:hidden, you will not see the scrollbar as a workaround (you place tooltip outside of MudTd).
We will close this issue because it's duplicate, but if you see this issue after next release please re-open it.

Hi, thank you for quick reply and scheduled fix.
I have removed Tooltip from my project because even if I place Tooltip as you suggested, it displays scrollbar ( but is is much better thow ) .
https://try.mudblazor.com/snippet/QEmlYZmyfsykqRFE

@walterX12 its because you wrap the TD in a tooltip, cant do that.
The tooltip needs to be inside the cell. This will still be true after our portal/popover fix.
https://try.mudblazor.com/snippet/cuGFEtcSUcFFEBoK
Here is two different ways of doing it depending on where you want the tooltip.

Hi, thank you for quick reply and scheduled fix.
I have removed Tooltip from my project because even if I place Tooltip as you suggested, it displays scrollbar ( but is is much better thow ) .
https://try.mudblazor.com/snippet/QEmlYZmyfsykqRFE

You can move overflow style to MudTd, then it will be work.
https://try.mudblazor.com/snippet/GEmluXcSqcjhVNaJ

Thank you very much. This works OK.
Just for reference working snippet
  <MudTd DataLabel="Item" Style="overflow: hidden">
      <MudTooltip  Text="Editace">
      @context
      </MudTooltip>
  </MudTd>


invalid join qualifier "ASOF INNER JOIN"

Is there any way to use ASOF join currently?
Something like this
MyTableOne
|> join(:asof_inner, [tb1], tb2 in MyTableTwo,
  on: tb1.created_at <= tb2.created_at
)

Or like this
MyTableOne
|> join("ASOF INNER", [tb1], tb2 in MyTableTwo,
  on: tb1.created_at <= tb2.created_at
)

👋 @JVMartyns
Yes, please see these tests https://github.com/plausible/ecto_ch/blob/master/test/ecto/integration/clickhouse_joins_test.exs


Google.OrTools exception C# framework 4.7.2

I have installed the package Google.OrTools via NuGet but running the test program Visual Studio see this exception:
System.BadImageFormatException: 'Could not load file or assembly 'Google.OrTools, Version=7.0.6546.0, Culture=neutral, PublicKeyToken=53dbb1ea090cbef7' or one of its dependencies. An attempt was made to load a program with an incorrect format.'

Which test program ? Are you using a Windows 64bits ?

I tried to run ShiftScheduling.cs
Yes it is 64 bit

note on windows Google.OrTools depends on Google.OrTools.runtime.win-x64
does it works if using the dotnet cli directly ?
note: on my way to test too

I tried many times. But each time I see this exception:
Unhandled Exception: System.IO.FileNotFoundException: Could not load file or assembly 'Google.OrTools, Version=7.0.6546.0, Culture=neutral, PublicKeyToken=53dbb1ea090cbef7' or one of its dependencies. The system cannot find the file specified.

Can you check that visual studio c++ redistributables are installed.
Maybe they are not if you just install the C# layer.
Laurent Perron | Operations Research |<EMAIL_ADDRESS>| (33) 1 42 68 53
00
Le jeu. 11 avr. 2019 à 18:14, Alvin<EMAIL_ADDRESS>a écrit :

I tried many times. But each time I see this exception:
Unhandled Exception: System.IO.FileNotFoundException: Could not load file
or assembly 'Google.OrTools, Version=7.0.6546.0, Culture=neutral,
PublicKeyToken=53dbb1ea090cbef7' or one of its dependencies. The system
cannot find the file specified.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/or-tools/issues/1185#issuecomment-482398246,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKj17Z0Gch65AoE95VqhJDWhLMyURUbKks5vf93ugaJpZM4cpLQQ
.

Visual Studio C++ redistributables 2017 (x64) are installed.

Create a pet project to "consume" Google.OrTools package
src: https://github.com/Mizux/or-tools-demo
log:  https://ci.appveyor.com/project/Mizux/or-tools-demo

The problem solved at last through migration to a new project on .Net Framework 4.7.2  and installing the latest version of google or-tools and running x64.  Thanks @lperron  @lperron

I am facing the same problem and it gives me warning "There was a mismatch between the processor architecture of the project being built "MSIL" and the processor architecture of the reference "Google.OrTools, Version=7.4.7247.0, Culture=neutral, PublicKeyToken=xxxxxxxxxxxxxxx, processorArchitecture=AMD64", "AMD64". This mismatch may cause runtime failures. Please consider changing the targeted processor architecture of your project through the Configuration Manager so as to align the processor architectures between your project and references, or take a dependency on references with a processor architecture that matches the targeted processor architecture of your project.	App"

The problem solved at last through migration to a new project on .Net Framework 4.7.2 and installing the latest version of google or-tools and running x64. Thanks @lperron @lperron

i have the VS 2019 with .Net Framework 4.7.2 but i am having the same issue i don't know how to resolve it.

Have you tried to remove Prefer 32 Bit in Project Properties / Build / Platform Target?

@zohaibdhukka Maybe you are referencing an assembly (Google.OrTools.dll) that was signed with no key or a different one. If you open the .csproj file with a text editor you should find the reference to the or-tools. Try to remove PublicKeyToken from this reference and see if that works. That option is used to guarantee that you're loading the assembly against which you built the application. Otherwise check the assembly that is in the bin folder and which is tried to be loaded. Is it the same? In general, this should not be an or-tools specific problem.

Have you tried to remove Prefer 32 Bit in Project Properties / Build / Platform Target?

@Eudaemonic thanks legend

VS 2019 with .Net Framework 4.7.2 but i am having the same issue and I tried fixing of everyone's advice, but I still can't. i don't know how to resolve it.

@Kaiju1997 Unsure if you're still having issues, for anyone else with this issue though, IIS Express needs to be set to run on 64 bit as well. This is in Tools -> Options -> Projects and Solutions -> Web Projects.


SR305 depth image incorrect on Jetson nano with BUILD_WITH_CUDA=true

Required Info

Camera Model
SR305

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 18.04 (Jetson Nano)

Kernel Version (Linux Only)
Linux 4.9.140-tegra aarch64

Platform
Jetson Nano

SDK Version
commit bc64e52c9e128aa82cc9f25a14283bbe2bcf8828

Language
C++

Segment
depth camera

CUDA version
10.0.326

Issue Description
I tried installing anSR305 depth camera on a Jetson Nano. I've used both the binary distribution, as well as compiling from source. In both cases, the depth camera returns incorrect results. Looking at the image on realsense-viewer, it appears to be an actual grayscale image instead of a depth field. The reported depth from  depth field, when it should be about .3 meters, reports instead something much smaller, like .02 meters. This same camera works fine on an x86 Ubuntu system.
After playing with the API for a couple of days to see if I could debug the problem, I sort of by accident discovered that the problem goes away if I compile with BUILD_WITH_CUDA=false instead of true.

Hi @rkent   Is the CUDA Toolkit software installed on your Nano please?
https://developer.nvidia.com/cuda-toolkit
https://devtalk.nvidia.com/default/topic/1048926/jetson-nano/unable-to-install-cuda-on-jetson-nano-help/71911

Yes CUDA is installed. /usr/local/cuda-10.0
I checked paths. I had the PATH correct but not the LD_LIBRARY_PATH. I fixed that, did a clean recompile, but it did not fix the issue or change its nature.

When you installed using the Debian packages, did you use the JetsonHacks Nano '5 minute installation's guide, please?
https://www.jetsonhacks.com/2019/12/22/install-realsense-camera-in-5-minutes-jetson-nano/
This method utilises Intel's dedicated install instructions for Jetson:
https://github.com/IntelRealSense/librealsense/blob/master/doc/installation_jetson.md
Since the Librealsense Debian packages have CUDA support included in them, this method would seem to be the most straightforward way to achieve a CUDA-enabled Librealsense on Nano if you have not followed this method already.

"achieve a CUDA-enabled Librealsense on Nano" is not really my goal. My goal was to use the SR305 somehow on the Nano, which so far I can only achieve by building myself with CUDA disabled. I am reporting my experiences in case it help others. I don't believe I need CUDA support to accomplish my goals.
To answer your question directly, I tried all kinds of things for days to try to get the camera to work, including the various Jetson hacks recommendations. But to demonstrate cleanly the issue, I did a clean test of the jetson hacks install. I reimaged an SD card with a fresh image from Nvidia (jetbot_image_v0p4p0.zip). I then followed the directions in "Install RealSense Camera in 5 minutes – Jetson Nano" namely:
$ git clone https://github.com/JetsonHacksNano/installLibrealsense
$ cd installLibrealsense
$ ./installLibrealsense.sh
I restart, plugin my SR305 (using the supplied USB-3.0 cable), and run realsense-viewer. Same experience as before. RGB camera works fine. For the depth camera, at first you see nothing. Playing around, post-processing must be turned off to see anything, particularly the threshold filter. This is because, by default, it throws away anything with a reported depth less than 0.1 meters.  But once I get a picture, I see that the reported depth is low, like .03 meters. Changing the color pattern to a black-to-white pattern, it is clear that I am seeing an intensity image, not a depth image.
I can use the same camera on my x86 Ubuntu computer and it works fine, the reported depths make sense and the image from the depth sensor is clearly a depth image and not an intensity image.
I am happy to do other tests if it would be helpful to diagnose this better if it would be helpful to others. But for my own purposes, by building librealsense with CUDA disabled I can get the camera to do what I need it to do.

Thanks so much for your detailed testing and reporting!  It's very valuable to have guidance for current and future SR305 Nano users.

I spoke too soon saying '"achieve a CUDA-enabled Librealsense on Nano" is not really my goal'. With CUDA disabled, running the SR305 required 100% of two of the four processors. So I investigated further what the issue is.
Turns out that whatever the problem is occurs only in a single file (src/proc/depth-formats-converter.cpp) If I disable the use of CUDA just in that file (by replacing #ifdef RS2_USE_CUDA with #ifdef RS2_USE_CUDA_NOT) then depth images work. Now one CPU at 85% is needed to run the camera, so whatever that change did is not really needed for significant CUDA performance improvements.
I've implemented that change in my fork https://github.com/rkent/librealsense which is intended for my personal use.

Thanks very much for the update - I'm glad you were able to develop a solution that works for you!

Do you require any further assistance with this case or can it be closed, please?   Thanks!

That depends on the intent of your use of issues. I am accustomed to issues being documentation of known bugs needing fixing. If that is the case, then I have done my best to document a bug, and isolate it to a few lines of code. That bug still remains and affects use of your product. By that definition, this case should not closed.
As for my person use, I have developed a workaround that works for me. I have no further personal need of assistance.

The effort that you have made in documenting your problem really is appreciated.
An element for consideration in whether an issue should be officially classified as a Bug to be investigated is whether it can be reproduced by others.  As your report is the only one that I know of in relation to depth image integrity on CUDA on SR305, I will close it for now.  The information will still be findable by others in a web search and the matter can be revisited in future if others report the same problem.   Thanks again!

Reopened due to a similar case of broken depth with SR305 possibly related to CUDA.
https://support.intelrealsense.com/hc/en-us/community/posts/360044304633

Hi @rkent  There was also a bug in CUDA support in the new SDK 2.35.2.  Advice about fixing it is provided in the link below.
https://github.com/IntelRealSense/librealsense/issues/6573#issuecomment-643725732

Re-closed due to no further comments received.  The CUDA build fix in the comment above should be incorporated withn the next SDK release (probably 2.36.0).

I'm experiencing the same issue on Jetson Nano.
I've looked over the CUDA code (src/cuda/cuda-conversions.cu) and it seems to do the same bit manipulation as the "CPU" version of the code  - so it's a "voodoo" kind of issue.
I can confirm that forcing the code to run on CPU fixes the  issue but I personally would prefer having the computation done on GPU in a parallel fashion instead of the "for" loop done on CPU.

As you are also experiencing the issue in addition to the previous reports,  I have re-opened the issue and will bring it to Intel's attention.  Thanks very much!

Adding a note to keep this case open for a further time period.

Adding a note to keep this case open for a further time period.

Adding a note to keep this case open for a further time period.

Adding a note to keep this case open for a further time period.

As there have been no further reports about this issue in the months since the last comment, it will be closed.

As there have been no further reports about this issue in the months since the last comment, it will be closed.

The problem still exists on jetson nano with jetpack 4.5.1, realsense sr305 and librealsense v2.44.0, albeit workaround provided by the author works. I also fully agree, the discussed issue should not be closed until fixed, as it's clearly a bug.

@MartyG-RealSense I agree with @PQLLUX, this is definitely a bug and this issue should be opened. I researched the topic and found a bug that causes this (in a nutshell - the pointer used later for copying is moved in the cpu implementation, in the CUDA implementation it is not). I did a PR that fixes this problem.

Hi @andrusza2   Thanks very much for creating a PR!
I recommend creating a new case on the GitHub that mentions it, and including links to this case here and to your PR.  Then that new case can be kept open for as long as your PR is active.  Thanks!
You can create a new case with the green New Issue button on the front page of this forum.
https://github.com/IntelRealSense/librealsense/issues

Hi everyone,
The PR fix for the issue of incorrect depth on SR300 with CUDA that @andrusza2 kindly submitted was merged into the development branch of the SDK 9 days ago at the time of writing this.  So it will likely be included in the next SDK version after the current 2.45.0, since 2.45.0 was released 12 days ago at the time of writing this (before the fix was merged).
https://github.com/IntelRealSense/librealsense/pull/8896#pullrequestreview-652210963

Hi everyone,
RealSense SDK 2.47.0 is now available and includes the previously mentioned SR300 fix.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.47.0


Add Tilt for local development

Proposed Changes

make tilt-up spins up local kind cluster and enables local development with Tilt
it also adds redfish-mockup as a sidecar to the manager and posts server UUID to the registry to make Server Available

@defo89 can you also add a section to https://github.com/ironcore-dev/metal-operator/blob/main/docs/dev_setup.md on how to use the Tilt setup?

@defo89 can you also add a section to https://github.com/ironcore-dev/metal-operator/blob/main/docs/dev_setup.md on how to use the Tilt setup?

Sure, I added some bits - pls have a look


IIoT Edge UI Installer fails on first attempt on Windows 10 1809

Describe the bug
I have consistently seen this failure when running the Industrial IoT Gateway Installer for the first time on an Azure hosted Windows 10 1809 VM (D2_v3 size). It's not a blocker, a second run of the tool consistently completes successfully.

After talking to my colleague this appears to be the result of the reboot prompt being suppressed on the VM in certain conditions.  The reboot is necessary after VC runtime installation.

Correct. I'll have a look to see if we can make this message a little more friendly.

This is now fixed:

New release on GitHub.

Hi @pcameron-ptc - please reopen if you still see issues with the installer.  Thanks!


Does .Net core on Raspberry 3 Model B+ 64 bit or only on Model B 32 bit?

Hi guys;
I'm about to order a Raspberry 3 starter kit. Their latest version is Model B+ which is 64-bit. However I keep reading about .Net core supporting ARM32. Does this mean I can't use Model B+ and only Model B?
Thanks
..Ben

Just make sure you use a 32bit OS and use 32bit .NET core

Hi Peter;
I see what you mean. So I should just install the 32 bit Linux and 32bit .net core runtime.
Thank you...
Do you know if MSFT will be shipping the ARM64 version of .Net core anytime soon?

There is a 64bit arm build available. No official timeline for officially supporting it.

That's a good news. We're half way there. :-)
I'm very excited about .Net core running on Raspberry Pi.
Thanks Peter!

Let us know how it goes.


WIP

TBD

FYI @loneil I linked the issue I think is appropriate for this

I think it is really bad practice to call an PR “WIP” since there is a flag for that…unless of course this is about adding a “WIP” feature to Traction.  :-).


rxjs-run@8 is broken for rxjs@5 users

Users, who have not switched to rxjs 6 should use rxjs-run v8. But this will break their setup:
https://github.com/cyclejs/cyclejs/blob/8f8fd53987fefaa1fde1f53f962be4a8111f4a24/rxjs-run/package.json#L35
We have to release a patch with the dependency on rxjs set to < 6.0.0

This is actually blocking me with #821

pnpm is amazing, was able to work around this with a pnpmfile.js, thanks @zkochan!
module.exports = {
    hooks: {
        readPackage
    }
};

function readPackage(pkg, context) {
  if(!pkg.dependencies) return pkg;

  if(pkg.dependencies.rxjs === '*') {
    pkg.dependencies.rxjs = '^5.5.11'
    context.log('rxjs@* => rxjs@5 in ' + pkg.name);
  }

  return pkg;
}

Wow, didn't know there was such a thing as pnpmfile.js.

We have to release a patch with the dependency on rxjs set to < 6.0.0

Did you mean >=6.0.0?

Oh no, sorry, now I get it, the latest rxjs-run is v9.

Yeah, it's the old version that needs a patch

@staltz could you do this? I was able to work around this, but everyone that uses rxjs 5 is screwed...

Sure

Done. cycle/rxjs-run 8.1.0 released that supports rxjs 5

I think you accidently set the latest version to 8.1.0

Urgh, indeed, completely forgot about dist-tags. Will fix


Postgres idle connection summary metric

Request to add idle connections to the summary metrics. I have databases where the number of idle connections can sometimes get very high and push over the connection limit and start causing problems, even when the number of active connections remains low. I'd like to be able to alert on the number of idle connections like I can active connections so I can watch out for this.
Obviously I can change the guid in the agent and configure this myself, but then I have to recreate all the dashboards, so seems like asking here first might be better than doing all that work to replicate the existing New Relic UI plus adding one more summary metric.

+1


typo fix

As mentioned in the issue, the word type describes better than shape. So, making the necessary changes
Fixes #27475

Internal previews

📄 File
🔗 Preview link

Thanks @Rick-Anderson


Error in migration engine. Reason: [migration-engine/connectors/sql-migration-connector/src/sql_destructive_change_checker.rs:199:84] internal error: entered unreachable code

Command: prisma db push
Version: 4.8.1
Binary Version: d6e67a83f971b175a593ccc12e15c4a757f93ffe
Report: https://prisma-errors.netlify.app/report/14506
OS: arm64 darwin 21.3.0
JS Stacktrace:
Error: Error in migration engine.
Reason: [migration-engine/connectors/sql-migration-connector/src/sql_destructive_change_checker.rs:199:84] internal error: entered unreachable code

Rust Stacktrace:
Starting migration engine RPC server
[migration-engine/connectors/sql-migration-connector/src/sql_destructive_change_checker.rs:199:84] internal error: entered unreachable code

In here, we have:
// not supported on SQLite
(ColumnArity::List, _) | (_, ColumnArity::List) => unreachable!(),

Still happening as of v4.12.0.

Yet another one.


feat: use special annotation to reallocate IP for stateful pods

Signed-off-by: Bruce Ma<EMAIL_ADDRESS>
Pull Request Description
Describe what this PR does / why we need it
Sometimes IP-retain on stateful pods will lead to other problems, for example, users lose control of pod scheduling after pod was created once, and even resources have been run out, pod will still be limited to these unscheduled nodes.
Does this pull request fix one issue?

Introduce a new annotation switch to trigger IP reallocation for stateful pods.
Describe how you did it
If pod have the reallocate annotation, it will be scheduled freely and allocated IPs will be recycled.
Describe how to verify it
Annotate the pod template and watch IP change.
Special notes for reviews
NONE

Codecov Report

Merging #20 (87455e2) into main (0633357) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   13.21%   13.02%   -0.20%
==========================================
  Files          22       22
  Lines        1907     1935      +28
==========================================
  Hits          252      252
- Misses       1606     1634      +28
  Partials       49       49

Flag
Coverage Δ

unittests
13.02% <0.00%> (-0.20%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/controller/ipam/pod.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0633357...87455e2. Read the comment docs.


Compatibility between mybatis, mybatis generator and mybatis dynamic sql?

When using the MyBatis3DynamicSql runtime of MyBatis generator, the generated source depends on mybatis-dynamic-sql (and mybatis as well of course) by default. But there does not seem to be any official documentation on the compatibility of these packages. Any pointers?

Are you looking for information about versions? We usually put that kind of information in the release notes/change log. For example, here's the change log for the generator: https://mybatis.org/generator/whatsNew.html. It states that the MyBatis3DynamicSql runtime in version 1.4.0 of MyBatis generator depends on version 1.1.3 or later of MyBatis Dynamic SQL.


Can't log in

Subject: Can't log in
Description:
I don't know
Results:
Tried to log in but can't
Backend version: develop-7c33e18d
Frontend version:
User Agent: Mozilla/5.0 (Linux; Android 8.1.0; CPH1835 Build/O11019) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.116 Mobile Safari/537.36 OPR/44.6.2246.127414
Page: https://couchers.org/login
User:

not enough info or can't reproduce


[Script]: Reddit Scraper

Aim
Add new Reddit scraper to scrape the posts and retrieve all the data
Details
Implement a new Reddit scraper to extract post content and collect comprehensive data.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

/assign


Update icons to support Font Awesome 4.3

Whew, this took a while. :stuck_out_tongue_closed_eyes: Let me know if you need any changes, or if there's another part of the codebase I need to update in addition to this.
Closes #1642
Notes:

The Font Awesome attribution/license banner was shortened here: https://github.com/FortAwesome/Font-Awesome/commit/6fbbefc89fa530c55a33bb5277d8b56ef27b3015
signal and wifi are now two separate icons
Added the Gender and Payment Options categories
The i.icon.plane was repeated so I removed the second entry
Font Awesome reference can be found here and here

Sorry, I forgot to make this merge into the next branch. Will close and make a correct PR.


Fix over-localization of VB keywords

Fixes #19033
cc @JasonCard to review the correctness of the PR.

The list of "Unreserved Keywords" should also be blocked from localization correct?

Yes I forgot them. I've added them now.

@JasonCard will this be confusing for the loc? The In keyword could also be used in a sentence:
Use the In keyword to check if the specified item is in the list

@adegeo Thank you for checking! Actually, I just realized that a lot of these keywords are common words like "In/Is/If/For/On" that could be used at beginning of sentence. Although, non-loc metadata is case sensitive, it's risky in that all instances of the same word would be blocked from translation in this article. So for example, in the sentence "For more information, ...", translator would not be able to translate "For", which would be bad, so we should not use no-loc metadata for this. So instead I would recommend to use inline code, like 'For' and 'In', for all instances of keywords that should not be translated in this article. This would also make it more clear for the reader and make sure those terms are not localized.
cc @Youssef1313

@Youssef1313 Thank you for the fix to use inline code, looks good!


Fixing data-l1 consensus when lastGlobalSnapshot isn't available yet

Changes

We had a bug that the data-l1 consensus was being stopped when the lastGlobalSnapshot wasn't present. This error was halting the streaming and blocking the node from starting the own consensus
I've followed the pattern of the currency layer and added a validation to the data consensus before trying to start the own consensus

Tests
It was working as expected, as the image below illustrates

@marcinwadon we had a second spot that is offering data to the queue
protected val p2p: HttpRoutes[F] = HttpRoutes.of[F] {
    case req @ POST -> Root / "consensus" / "data-application" =>
      implicit val decoder: Decoder[ConsensusInput.Proposal] = ConsensusInput.Proposal.decoder(dataApplication.dataDecoder)

      req
        .as[Signed[ConsensusInput.Proposal]]
        .map(_.asInstanceOf[Signed[ConsensusInput.PeerConsensusInput]])
        .handleErrorWith { _ =>
          req
            .as[Signed[ConsensusInput.SignatureProposal]]
            .map(_.asInstanceOf[Signed[ConsensusInput.PeerConsensusInput]])
            .handleErrorWith { _ =>
              req
                .as[Signed[ConsensusInput.CancelledCreationRound]]
                .map(_.asInstanceOf[Signed[ConsensusInput.PeerConsensusInput]])
            }
        }
        .flatMap { consensusInput =>
          S.supervise(dataApplicationPeerConsensusInput.offer(consensusInput))
        }
        .flatMap(_ => Ok())
        .handleErrorWith { err =>
          logger.error(err)(s"An error occured") >> InternalServerError()
        }

So I've added additional validations in another places to avoid the error


[HELP] sudo ./update.sh

Original installation (from source) on a Raspberry Pi 4, from November 2023.  I just ran an update (for the first time) using "sudo ./update.sh".  Everything appears have installed fine:
HEAD is now at bea3801 If geolocation API returns an error, print the whole thing
wire-pod.service created, building chipper with VOSK STT service...
Syncing...
wire-pod is now running with the updated code!

Updated successfully!

Now when I navigate to http://escapepod:8080/ I get the following message box:
This webroot does not match with the wire-pod binary.  Some functionality will be broken.  There was either an error during the last update, or you did not precisely follow the update guide.
I haven't been able to find any update guide anywhere.  The bot appears to work the same as before.   I see a new "Version Info" icon on the website, when I click it, it's stuck on "Checking for updates..." perpetually.

https://github.com/kercre123/wire-pod/wiki/Things-to-Know#updating-wire-pod

https://github.com/kercre123/wire-pod/wiki/Things-to-Know#updating-wire-pod

I appreciate the link, admittedly I completely missed looking under Things to Know.  My original installation was from source.  I followed the instructions as stated:
sudo systemctl stop wire-pod
cd ~/wire-pod
sudo ./update.sh
sudo ./setup.sh daemon-enable
sudo systemctl start wire-pod

However I still get the alert on the web interface.

https://github.com/kercre123/wire-pod/wiki/Things-to-Know#updating-wire-pod

I admittedly missed this section.  I appreciate your help.  This indeed made the alert go away.

Closed


fix: only count products in cart #908

Changes
closes: #908
Checklist

[x] I followed contributing guidelines

hey @mmeester thanks, good point with that issue, we just aim to have 100% tests coverage, but here tests are failing. Could you fix that? :)
you need to run yarn test and it will show you tests result and coverage


Cell overlay for read-only cells is not closed on escape

Cell overlays in editing mode close when the escape hotkey is pressed. However, cell overlays in read-only mode are not closed. This can be replicated on the storybook.

Thanks for reporting! Looks like a bug. Will fix.

There is an open PR. It's very simple yet very scary and could definitely use some testing.


Validating self-referencing data structures

What version of Ajv are you using? Does the issue happen if you use the latest version?
5.0.4-beta.1
Ajv options object
{}

JSON Schema
{ "properties": { "self": { "$ref": "#" } } }

Data
const data = {};
data.self = data;

Your code
ajv.validate(schema, data);

Validation result, data AFTER validation, error messages:
RangeError: Maximum call stack size exceeded
    at validate (eval at localCompile (/node_modules/ajv/lib/compile/index.js:118:26), <anonymous>:3:29)
    at validate (eval at localCompile (/node_modules/ajv/lib/compile/index.js:118:26), <anonymous>:3:389)
    at validate (eval at localCompile (/node_modules/ajv/lib/compile/index.js:118:26), <anonymous>:3:389)
    at validate (eval at localCompile (/node_modules/ajv/lib/compile/index.js:118:26), <anonymous>:3:389)
    at validate (eval at localCompile (/node_modules/ajv/lib/compile/index.js:118:26), <anonymous>:3:389)
    at validate (eval at localCompile (/node_modules/ajv/lib/compile/index.js:118:26), <anonymous>:3:389)
    at validate (eval at localCompile (/node_modules/ajv/lib/compile/index.js:118:26), <anonymous>:3:389)
    at validate (eval at localCompile (/node_modules/ajv/lib/compile/index.js:118:26), <anonymous>:3:389)
    at validate (eval at localCompile (/node_modules/ajv/lib/compile/index.js:118:26), <anonymous>:3:389)
    at validate (eval at localCompile (/node_modules/ajv/lib/compile/index.js:118:26), <anonymous>:3:389)

What results did you expect?
The validation should pass. Recursive structures should be handled.
Are you going to resolve the issue?
No

Validating recursive data structures is out of scope of JSON-schema specification.
Whether to support it in Ajv depends on how common is the use case - could you explain what is it?
It would substantially complicate validation as it will have to keep track of all validated nodes and in case some node is encountered again and it has to be validated against the same schema it will be considered valid.

Just to clarify, recursive $refs are fully supported, just not with recursive data structures. E.g. this data:
{ self: { self: { self: {} } } }
is valid according to this schema:
{
  "type": "object",
  "properties": { "self": { "$ref": "#" } },
  "additionalProperties": false
}

I understand that supporting this would add a lot of complexity in the code, and probably degrade performance. I just thought I would bring it up, as this is being a problem for me right now, and you might be interested in knowing this issue arises for some users.
My use case is the following. I am working on an open-source library which generates an API server (both REST and GraphQL) using a single declarative file to describe each model, let's call it models.schema.json. Database queries, validation, authorization, default attributes, etc. are automatically generated from parsing that file, without library users needing to write any other code.
I chose JSON schema as the format of models.schema.json, as it is expressive, well-designed, standard and has a rich ecosystem. REST models typically point to each other, or to themselves, creating circular references. I want to make sure models.schema.json is proper JSON schema before starting the server, so I validate it against JSON schema meta-schema (which has circular references too).
A simplified version of models.schema.json to represent a User would be:
"required": ["id"],
"properties": {
   "id": {
      "type": "string"
   },
   "is_active": {
      "type": "boolean"
   },
   "best_friend": {
      "$ref": "#"
   }
}

I am dereferencing all JSON references prior to validation. I started by not doing so, but it turns out that most parts of my library are greatly simplified by having those JSON references dereferenced, except for ajv which crashes. An alternative for me is to not dereference me, but this would put back to other problems I encountered in my project by having to manually those JSON references every time some part of my system needs it.

Interesting. You may be interested to read FAQ - the third part about $refs and why it is wrong/difficult to deference them in general case.
From my experience it's better to avoid self-referencing data structures that can't be serialised. You may save some time in the beginning but you are likely to find yourself in some tight corner further down the line. In general, there is bad support of self referencing data structures by most libraries... I'd stick with $refs.

btw, supporting self-referencing schemas would be even more complex - atm it is a hard requirement that they are serialisable.

I understand. I did read that part of the FAQ first, but still wanted to bring it up just in case.
I think objects with circular references are still serializable, by first converting circular references to some kind of JSON-pointers-like string. This is e.g. what this library I am using is doing. One could also dereference JSON references on parsing, and re-create them on serialization.

If this is too complex, I think I'll close this issue. What do you think?

Sorry to dig up this issue, but I'm in this case with the use of fastify and fastify/swagger, schemas being used for swagger and ajv at the same time. It's a shame the schema isn't valid for both (swagger supports self-referencing).
I don't know if this is something that's been permanently abandoned, but it would be so much more practical than having to redeclare similar structures.


SSL certificate or subdomain not redirect to the right netlify website?

It seems either the SSL certificate has not been issued yet by Netlify or
That school.brainhackmtl.org is still pointing to my Netlify account and not @pbellec's account.

Websites prove their identity via certificates. Firefox does not trust this site because it uses a certificate that is not valid for school.brainhackmtl.org. The certificate is only valid for the following names: *.netlify.com, netlify.com
Error code: SSL_ERROR_BAD_CERT_DOMAIN
View Certificate

I have updated the certificates, and it looks like it's fixed.
But the site does not work anymore, and all the links resolve to the old website.
I think the baseURL config variable needs to be updated.

that was it. Needed a "clear cache and redeploy", but site is now live and looks like everything is working.