failed to unlink timer issues (make sn E=wait)

Works alright but why the messages?
2015-02-21 21:36:39.421142 +0000 t 15431/15432  INFO src/fl_dispatcher.c:600:flon_dispatch sch_n.wait.0-u0-20150221.2136.kishosebeba-0.json
2015-02-21 21:36:39.421379 +0000 t 15431/15432 DEBUG src/fl_dispatcher.c:168:schedule unschedule order: sch_n.wait.0-u0-20150221.2136.kishosebeba-0.json
2015-02-21 21:36:39.421751 +0000 t 15431/15432 ERROR src/fl_dispatcher.c:196:schedule failed to unlink n.wait.0/ki/n.wait.0-u0-20150221.2136.kishosebeba/at-20150221.213639-n.wait.0-u0-20150221.2136.kishosebeba-0.json: (E2) No such file or directory
2015-02-21 21:36:39.421802 +0000 t 15431/15432 DEBUG ../src/flon-dispatcher.c:80:scan_dir dispatched: 2/2
2015-02-22 06:36:36.034809 +0900 guerlain 15431/15432  INFO ../src/flon-dispatcher.c:140:main changed dir to /home/jmettraux/w/f/flon/tst/
2015-02-21 21:36:39.491397 +0000 t 15431/15432  INFO src/fl_dispatcher.c:600:flon_dispatch sch_n.wait.0-u0-20150221.2136.kishosebeba-0.json
2015-02-21 21:36:39.491661 +0000 t 15431/15432 DEBUG src/fl_dispatcher.c:168:schedule unschedule order: sch_n.wait.0-u0-20150221.2136.kishosebeba-0.json
2015-02-21 21:36:39.491997 +0000 t 15431/15432 ERROR src/fl_dispatcher.c:196:schedule failed to unlink n.wait.0/ki/n.wait.0-u0-20150221.2136.kishosebeba/at-20150221.213639-n.wait.0-u0-20150221.2136.kishosebeba-0.json: (E2) No such file or directory

There should be no such "alarming" messages.

it's more like the unschedule message isn't removed from var/spool/dis/


Bluetooth gamepad Emulation for other devices or Android in general

Is it possible to port this to an "App" that we could use this feature on other roms for other devices?
Would love to get USB Controller like the razer kishi to work as a bt device.

Hi, the code for my fix is here: https://github.com/TheGammaSqueeze/retrogame_joypad_2_xbox
It should be modifiable to work with other devices.


Add possibility of configuration if a file is downloaded locally or to target machine

Closing do to lack of description.


Use new CLI args instead of ENV vars

https://github.com/Cyfrin/aderyn/pull/330

Fixed in 31eb8ef968da1572f77a88e83d1915a1b664a74a


Remove and Prohibit C Style Casts

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]    +416  +0.0%

  [ = ]       0 TOTAL     +416  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]    +416  +0.0%

  [ = ]       0 TOTAL     +416  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]    +416  +0.0%

  [ = ]       0 TOTAL     +416  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]    +416  +0.0%

  [ = ]       0 TOTAL     +416  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]    +416  +0.0%

  [ = ]       0 TOTAL     +416  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%

[trickle] No significant performance differences

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]    +416  +0.0%

  [ = ]       0 TOTAL     +416  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%

[trickle] No significant performance differences

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

Github refuses to show the full list of changes... But if a change like this, which I presume was done via some script, compiles and tests are happy, I am happy.
And on that note, some tests aren't happy:
test/core/iomgr/tcp_server_posix_test.cc: In function 'void test_connect(size_t, const grpc_channel_args*, test_addrs*, bool)':
test/core/iomgr/tcp_server_posix_test.cc:313:69: error: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'unsigned int' [-Werror=format=]
           dst_addrs != nullptr ? "<specific>" : "::", test_dst_addrs);

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]    +416  +0.0%

  [ = ]       0 TOTAL     +416  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%

[trickle] No significant performance differences


Add fallback for broken image urls

Some of the images are broken on the live website. It would be nice to display another image in this case, such as the paw icon, given that it is always publicly available as long as the page is served!

Fixed by @stuin on #13


use req.Name for generating ID

req.Name is unique for each volume/snapshot creation, use req.Name to generate volume/snapshot ID.
Signed-off-by: Madhu Rajanna<EMAIL_ADDRESS>

@rootfs @gman0 ^^

req.Name is unique for each volume/snapshot creation, use req.Name to generate volume/snapshot ID.

req.Name is unique from the POV of all volumes handled by that instance of the container orchestrator. In the event that a Ceph cluster is shared across multiple such instances, uniqueness of "Name" is not guaranteed. As a result using just the "Name" may not be the right approach to define uniqueness of the rbd vol name in this scenario.
Further, to remove Ceph cluster information from the StorageClass, and encode it into the VolumeID (to do away with the config map as in #135), it may better to get a naming scheme around the same before changing the current scheme as in this patch. The current thought on the VolumeID naming scheme would be {Ceph-clusterID}-{Pool-ID}-{UUID}-{Name}, if required we can add a orchestrator ID into the mix for possible UUID clashes if any.
Thoughts?

I like the idea of having {Ceph-clusterID}-{Pool-ID}-{OR-UUID}-{Name} to share a single cluster between multiple orchestrators
even with this approach, a single ceph-csi-driver can  handle multiple clusters for one orchestrator
but why  we need to  have ceph-clusterID i think we use mons to  communicate with ceph cluster,correct me  if i am worng.
and one more question cant  we  get rid of storing information in the configmap or incache (if we can get the list of volumes and volume information from the cephfs or  rbd CLI)?
one or  other  day  we are  going  to have some stale volume entries if we have multiple store.
if we can make use of secrets i think we dont need to store cluster  information in storage-class
@ShyamsundarR please correct me if  am wrong, am trying to understand advantages/disadvantages of diffrent approaches.

I like the idea of having {Ceph-clusterID}-{Pool-ID}-{OR-UUID}-{Name} to share a single cluster between multiple orchestrators
even with this approach, a single ceph-csi-driver can handle multiple clusters for one orchestrator

Yes, that is the general idea. Retain a single CSI instance for multiple Ceph clusters that an orchestrator may need to communicate with, but encode the cluster information in the VolumeID for future mapping.

but why we need to have ceph-clusterID i think we use mons to communicate with ceph cluster,correct me if i am worng.

Each Ceph cluster needs to be uniquely identified, such that we can use its mons and credentials (assume this comes from a future config map for now) when performing operations against the same. For a given VolumeID the exact cluster that it belongs to comes from the ClusterID. (MONs may change over time, consider the Cep-ClusterID as an UUID that does not change for the lifetime of the cluster).

and one more question cant we get rid of storing information in the configmap or incache (if we can get the list of volumes and volume information from the cephfs or rbd CLI)?
one or other day we are going to have some stale volume entries if we have multiple store.
if we can make use of secrets i think we dont need to store cluster information in storage-class

This is what I am referring to in #135, and what @rootfs  was pointing out in another issue. Yes, a duplicate list of volumes in the CSI driver will at some point in time go out of sync.
The current config map stores Ceph cluster information to use in Delete and Snapshot operation, where the operations are driven only by the VolumeID. Even to fetch the volumes from Ceph we need the Ceph cluster information (MONs and credentials).
Thus to solve the problem we need to move the Ceph cluster information into the CSI configuration (the same future config map I refer to above, and required secrets), rather than it coming from the StorageClass.

@ShyamsundarR please correct me if am wrong, am trying to understand advantages/disadvantages of diffrent approaches.

My current write-up on the same is now posted here. @gman0 where would you want me to post this, to further the discussion around the proposal?

@ShyamsundarR I guess a new issue should do

@gman0 @ShyamsundarR IMO we  should take  this PR in. as people are  already using the ceph-csi driver, they may fall into this issue with current design

@gman0 @ShyamsundarR IMO we should take this PR in. as people are already using the ceph-csi driver, they may fall into this issue with current design

IMO, it depends on when we release v1.0. We are currently in alpha of the same if I understand it right. I would propose that we release 1.0 when we have the config map removed, if maintainers agree, then I am fine with this patch being merged or not, as essentially when we call out the release it would be fixed one particular way.
My current issue with it is,  I do not want to be in a situation where some rbd instances are created using the older naming scheme, then some with the one in this patch, and in the future based on the config map removal.
It would be useful to arrive at a single naming scheme that helps the current issue, and can be reused in the future when the config map is removed.
I will try and post alternatives for the naming scheme by my day today.

lgtm, but @ShyamsundarR raised a valid concern. I'd wait for what @rootfs has to say.

@Madhu-1 thanks for the work. It is a hot topic now since we are going to overload more info to volume names. Let's wait for @ShyamsundarR upcoming work.


Add -tr Option to Assembly Signing

Add missing timestamping service URL to SignAssemblies.ps1

Now with timestamp! Whoops!


Fixed an infinite loop in the checkpoint flow

Description
This PR fixes an infinite loop that could occur in the checkpoint flow when checkpointing a past checkpoint when the latest checkpoint hadn't been minted. This could have prevented matured positions from a previous checkpoint from being closed (but this could have been recovered by minting the latest checkpoint).
Review Checklists
Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled ## [Reviewer Name].
If the PR doesn't touch Solidity, the corresponding checklist can
be removed.
[[Reviewer Name]]

[ ] Tokens

[ ] Do all approve calls use forceApprove?
[ ] Do all transfer calls use safeTransfer?
[ ] Do all transferFrom calls use msg.sender as the from address?

[ ] If not, is the function access restricted to prevent unauthorized
token spend?

[ ] Low-level calls (call, delegatecall, staticcall, transfer, send)

[ ] Is the returned success boolean checked to handle failed calls?
[ ] If using delegatecall, are there strict access controls on the
addresses that can be called? It shouldn't be possible to delegatecall
arbitrary addresses, so the list of possible targets should either be
immutable or tightly controlled by an admin.

[ ] Reentrancy

[ ] Are functions that make external calls or transfer ether marked as nonReentrant?

[ ] If not, is there documentation that explains why reentrancy is
not a concern or how it's mitigated?

[ ] Gas Optimizations

[ ] Is the logic as simple as possible?
[ ] Are the storage values that are used repeatedly cached in stack or
memory variables?
[ ] If loops are used, are there guards in place to avoid out-of-gas
issues?

[ ] Visibility

[ ] Are all payable functions restricted to avoid stuck ether?

[ ] Math

[ ] Is all of the arithmetic checked or guarded by if-statements that will
catch underflows?
[ ] If Safe functions are altered, are potential underflows and
overflows caught so that a failure flag can be thrown?
[ ] Are all of the rounding directions clearly documented?

[ ] Testing

[ ] Are there new or updated unit or integration tests?
[ ] Do the tests cover the happy paths?
[ ] Do the tests cover the unhappy paths?
[ ] Are there an adequate number of fuzz tests to ensure that we are
covering the full input space?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 92.84%

Files with Coverage Reduction
New Missed Lines
%

contracts/src/libraries/LPMath.sol
3
83.14%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1906

Relevant Lines:
2053

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.1%) to 92.84%

Files with Coverage Reduction
New Missed Lines
%

contracts/src/libraries/LPMath.sol
3
83.14%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
1906

Relevant Lines:
2053

💛  - Coveralls


WordPress Files_FileNameSniff should ignore slugs in content-{slug}.php template files

We should have an exception for content-{slug}.php since the slug can contain '_' and format not allowed by the sniff.
The same way we have an exception for:

archive-{slug}.php
 single-{slug}.php
etc.

See: https://developer.wordpress.org/themes/template-files-section/partial-and-miscellaneous-template-files/#content-slug-php

Thanks for bringing this new template file type to our attention.
PR #958 should fix it ;-)

@jrfnl Damn! You were faster than I was!!

@guillaumemolter Was an easy fix to make (when you know how the unit testing for this sniff works) ;-)


BUG 1747124: Dockerfile: use build instead of make build

make build performs a sanity test on the binary image which causes problems for an unsupported arch. Because we run full CI tests against the image this check is not nessisary and will allow images to be build regardless of arch.
/cc @yselkowitz
Signed-off-by: Sam Batschelet<EMAIL_ADDRESS>

/retest

Aug 29 22:36:42.172: INFO: Couldn't delete ns: "e2e-test-build-webhooks-w94r8": namespace e2e-test-build-webhooks-w94r8 was not deleted with limit: timed out waiting for the condition, namespace is empty but is not yet removed (&errors.errorString{s:"namespace e2e-test-build-webhooks-w94r8 was not deleted with limit: timed out waiting for the condition, namespace is empty but is not yet removed"})

failure unrelated etcd started fine


Use keyserver pool to avoid single server timeout

travis test failed because keys.gnupg.net timeout.
It should not be the case using the pool.

dammit, still gpg version 1, anyways, now no errors and no timeout

Thanks! Hope this makes things better. I noticed the issue too and thought about including a copy of the public key somehow. Maybe using a pool will be enough.


Training script

Thanks a lot for the great work. It would immensely benefit the community if the training script (exact script used for orchestrating the training of the JetMoE-8B model) is made public. -- Thanks.

Yes please share the training script.

https://huggingface.co/jetmoe/jetmoe-8b/discussions/5


BibTeX subsystem: warning: comma(s) at end of name (removing)

Hi,
I get "BibTeX subsystem: warning: comma(s) at end of name (removing)".
but there is no information about the line, so I can't correct my database easily.

I am afraid there isn't much we can do about this as it's a limitation of the btparse library that doesn't report line numbers . A quick  fgrep ',}; on your .bib shows a few fields with trailing commas.

oki, you are right. I made a mistake between "comma" and "dot" and I thought the message was becase I put some first name with a comma after. So we can close.


Fix setting proxy error

This should fix #447
The changes in OptionsForm were necessary to be able to test this. Those changes are part of #446.

:white_check_mark: Build ServiceBusExplorer 4.2.0-FixSettingProxyError.66.build.698 completed (commit https://github.com/paolosalvatori/ServiceBusExplorer/commit/418b49cbf7 by @ErikMogensen)


feat: improve analytics

What it solves
Resolves #3408
How this PR fixes it

Google Tag Manager implementation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

10 of 12 (83.33%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 33.721%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/utils/googleTagManager.ts
6
8
75.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.07%

Covered Lines:
3176

Relevant Lines:
8459

💛  - Coveralls

@johannesmoormann, it seems as though GTM doesn't have any cookies. Do we need to include it conditionally based on the cookie selection? It currently loads according to the choice made by the user. I can't confirm if, after implementing funnels in GA, that cookies will then appear though.
What do you think?


⚠ Bofrost.at has degraded performance

In d76a372, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 901 ms

Resolved: Bofrost.at performance has improved in d1aa32b after 9 minutes.


UmbracoPropertyDataValue Resolver

Following up on a discussion over on nuPickers issue #100, I had a thought about having a ValueResolver that would return an Umbraco properties raw value.
The idea would be that it would bypass any IPropertyValueConverters for that property-editor's value.
The resolver itself would be similar to UmbracoPropertyValueResolver, but with a small change, see #L36
Instead of...
content.GetPropertyValue(umbracoPropertyName, recursive);

... we'd have...
content.GetProperty(umbracoPropertyName, recursive).DataValue

The use-case here, for example, would be when using nuPickers - it would typically return a Picker object, but the underlying (raw data) value would typically be a CSV of content node IDs.

To note, with nuPickers you can have other data formats, (CSV, XML, JSON), so it's not super straight-forward... but if you are the developer of the project, then you can configure this be CSV and work nicely with Ditto.

Any thoughts?

I guess it's just what is the use case? I know you mention nuPickers, but what makes the resolved property value inadequate? such that you would then want to work direct with the raw value?

I guess it's to intentionally bypass the associated IPropertyValueConverter.
The issue (for me) on nuPickers is that we're all talking about introducing more code to workaround having a Picker object.  Ultimately they want to use Picker.AsPublishedContent() to get the nodeIds, then get the IPublishedContent, then call .As<T>() to map the POCO.
I can't help by think that using content.GetProperty("alias").DataValue would be a more efficient way, (with less code/assemblies).

I've found that using a type converter that inherits the formally named DittoMultiNodeTreePicker converter worked perfectly for nuPickers. What advantage does this approach have over that?

I can't help but think this sounds like a failing in nuPickers though not giving it's values in a meaningful way, and that by accessing the raw value, it's like using internal methods. We should really try and stick to using public apis for each 3rd party package as you could end up with a tangled mess.
Maybe I need to know more about why there is a Picker object and why it's not good enough as a value to be converted.

@JimBobSquarePants yup, nuPickers TypeConverter that supplies a core Ditto TypeConverter with IPublishedContent works well :)
@mattbrailsford A Picker object (as returned by a PropertyValueConverter) contains lots of useful infomation about the saved value and the data-type, and is consistent across all the nuPicker property editors, it also abstracts away the actual storage mechanism (CSV, JSON, XML Relations) although the raw value can still be returned. What's the failing in nuPickers in your opinion ?

Just to add, a Picker object contains everything required to be converted, but that would mean coupling Ditto and nuPickers.

@Hendy I don't know, I'm just saying, if there is a need to access the raw value, instead of the one the developer exposes via the umbraco value converter, why is that?

@mattbrailsford but the developer doesn't have to access the raw value ? besides, it's available on the Picker obj with .ToString() or .SavedValue should it be needed.

@Hendy ask @leekelleher, he's the one suggesting the need for it :)

To be clear, I'm not suggesting that nuPickers (or the Picker object) is doing anything wrong.
The point I'm trying to get to is for us to not have to write additional code/assemblies for every custom property-editor that wants to support Ditto/TypeConverters.
Lets say that we've implemented this UmbracoPropertyDataValue attribute/resolver, we'd have a decorated POCO property like this...
[UmbracoPropertyDataValue("myPropertyAlias")]
[TypeConverter(typeof(DittoPickerConverter))]
public IEnumerable<MyCustomPoco> MyPropertyName { get; set; }

That would get the raw value (DataValue), then pass it to the type-converter - job done.
The alternative, (as being suggested on nuPickers issue #100), is to have a separate assembly, (called whatever "Our.Umbraco.Ditto.nuPickers" something), that contains a single class (inherited TypeConverter) with minimal code, that would achieve this...
[UmbracoPropertyValue("myPropertyAlias")]
[TypeConverter(typeof(nuPickerConverter))]
public IEnumerable<MyCustomPoco> MyPropertyName { get; set; }

The advantage of this is that nuPickerConverter would be typed using the Picker class object, (I can see the appeal of this) ... but is it worth the overhead of a separate assembly + VS project + Git repo + AppVeyor set-up + etc?

@leekelleher if we could do away with all that overhead that'd be great, but wouldn't that mean that Ditto would have to understand how to parse the raw value of 3rd party property-editors ?
(there would be issues with nuPickers and a RelationsOnly SaveFormat, as there isn't a raw value !)

@leekelleher I get what you mean, but I just don't think we should be relying on a prop editors raw DB value. To me, that value should be classed as "internal" and thus shouldn't be relied upon. Take NestedContent for example, in some of the updates we have done, we have wildly changed the raw saved value, yet the value from the value converter is the same, because this is our public API. By dealing with the raw value, yes you've removed an explicit dependency with nuPickers, but I think you've gained a much worse hidden dependency, because you'll only find out when you come to use it, not when you come to compile it.

@Hendy @mattbrailsford - totally valid points! (Hence why I wanted to start this side of the discussion :smiling_imp:)

Closing this one for now... it may be revisited in future, but I agree with comments about using the value's "public API".


quick_start.sh issues with MacOS

The script assumes user has minkube installed when docker desktop will suffice (unrelated, minikube v1.22 and v1.23 both fail on macos for different reasons, and I had to install a patch just to get it working.)
Current user in docker group: not needed for macOS or the command just fails anyway
Berkeley Packet Filters: I dunno what this is! But by bypassing the check in quick_start I was able to start...

We could check for minikube, then if that fails, check for docker desktop
Docker group - Which conditions do we need the user in the docker group?

Linux Rootless - not needed (I think)
Mac OS - not needed
Linux standard - needed

Berkeley Packet Filters - I want to incorporate trace points, but I am using zmq for the moment: https://github.com/bitcoin/bitcoin/blob/master/doc/tracing.md

Removed these three things for now in https://github.com/bitcoin-dev-project/warnet/commit/61255717ac2966448843ad4b5bffcc9989de4b5c


First pass at getting to ginkgo v2

panic occuring because of mismatch ginkgo versions due to ginkgo v1 being needed by code.cloudfoundry.org/cfnetworking-cli-api
code.cloudfoundry.org/cfnetworking-cli-api is archived and hasn't been maintained for quite awhile
the error shows as /Users/moleske/workspace/cli/util/clissh/clissh.test flag redefined: ginkgo.seed panic: /Users/moleske/workspace/cli/util/clissh/clissh.test flag redefined: ginkgo.seed

goroutine 1 [running]:
flag.(*FlagSet).Var(0x14000116120, {0x1049bcdf8, 0x104c3e280}, {0x1400011d020, 0xb}, {0x104842d23, 0x2a})
/opt/homebrew/Cellar/go/1.20.1/libexec/src/flag/flag.go:982 +0x2a4
flag.(*FlagSet).Int64Var(...)
/opt/homebrew/Cellar/go/1.20.1/libexec/src/flag/flag.go:769
github.com/onsi/ginkgo/config.Flags(0x1049370c0?, {0x10482abdb?, 0x104843acb?}, 0x1)
/Users/moleske/go/pkg/mod/github.com/onsi/ginkgo@v1.16.4/config/config.go:75 +0xe4
github.com/onsi/ginkgo.init.0()
/Users/moleske/go/pkg/mod/github.com/onsi/ginkgo@v1.16.4/ginkgo_dsl.go:53 +0x34
Ginkgo ran 20 suites in 10.659707541s
Test Suite Failed
make: *** [units-non-plugin] Error 1
cc @cloudfoundry/wg-app-runtime-interfaces-cli-approvers if you all have thoughts
Thank you for contributing to the CF CLI! Please read the following:

Please make sure you have implemented changes in line with the contributing guidelines
We're not allowed to accept any PRs without a signed CLA, no matter how small.
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
All new code requires tests to protect against regressions.
Contributions must be made against the appropriate branch. See the contributing guidelines
Contributions must conform to our style guide. Please reach out to us if you have questions.

Does this PR modify CLI v6, CLI v7, or CLI v8?
nah
Please see the contribution doc above or review Architecture Guide.
Description of the Change
get to ginkgo v2 hotness
We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.
Why Is This PR Valuable?
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
cause ginkgo v1 not supported no more
Why Should This Be In Core?
Explain why this functionality should be in the cf CLI, as opposed to a plugin.
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?

if you all have thoughts on proper way to remove code.cloudfoundry.org/cfnetworking-cli-api as a dependency give a holler

@moleske this is a great initiative - V2 brings new tools to navigate flakes. @ccjaimes and @pivotalgeorge might be interested in this too

reading the commit history of the archive repo that we depend on (https://github.com/cloudfoundry-incubator/cfnetworking-cli-api/commits/master) that is causing problems here - it seems like that repo was created by ripping it out of the cli code initially.  Seems reasonable to me to just bring it back if we're not maintaining it in that archived repo no longer

apparently same thing happened with https://github.com/cloudfoundry/gofileutils/commits/master

We have a bunch of green units by disabling parallel execution.

/easycla

integration tests are failing cause they are using ginkgo v1, as that's what is currently in the main branch.  this branch/pr updates the integration tests to use ginkgo v2.  which will cause problems with v8/v7 branches when this is merged.  This may be acceptable if we immediately work on porting those branches after this pr is merged
this pr won't go green until the main branch is updated to use ginkgo v2 in the integration tests

Delivered via #2810


removed unnecessary db queries

Reusing serializers across different kinds of views is sub-optimal, because this may result in either excessive amounts of db queries, or bloated single db queries in many places, just because the serializer defaults to serializing all attributes, rather than only the necessary ones. I recommend we adopt a policy to

either use custom, optimized serializers for the critical code paths (search, mainly, I think)
or have the default serializers as lean as possible, using custom serializers when more attributes are needed.

Current coverage is 92.51%

Merging #304 into master will increase coverage by +0.03% as of ad22e1e

@@            master    #304   diff @@
======================================
  Files           39      39
  Stmts         1970    1976     +6
  Branches         0       0
  Methods          0       0
======================================
+ Hit           1822    1828     +6
  Partial          0       0
  Missed         148     148

Review entire Coverage Diff as of ad22e1e

Powered by Codecov. Updated on successful CI builds.


Flask app

Tried to keep the flask api example simple and in one file but let me know if we want a more "full" api as an example and add more stuff.

@anovis let me know if you get a chance to take a look at this one. Made the fixes


fix: error handling in opening of external file.

Description of Change
Added error handling in opening of external file.

Checklist

[ ] Added description of change
[ ] Added file name matches File name guidelines
[ ] Added tests and example, test must pass
[ ] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[ ] Relevant documentation/comments is changed or added
[ ] PR title follows semantic commit guidelines
[ ] Search previous suggestions before making a new one, as yours may be a duplicate.
[ ] I acknowledge that all my contributions will be made under the project's license.

Notes:

I think some unwanted commits are here. Let me fix them so I only modify neural_network.cpp.

I am closing this PR opening new one.
Looks like something is wrong with my fork.


Fixed text describing Mendix Dedicated

Mendix Dedicated does not run in a customer's VPC.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi Mark,
This pertains to direct links to a customer system like a database through VPN. We don't allow this on our public cloud, but for dedicated we allow this. So direct access to a customer's other system over their own network.
Cheers,
Maarten

Van: Mark van Ments @.>
Verzonden: vrijdag 16 juni 2023 10:48
Aan: mendix/docs @.>
CC: Maarten @.>; Mention @.>
Onderwerp: Re: [mendix/docs] Fixed text describing Mendix Dedicated (PR #6188)
@MarkvanMents commented on this pull request.

In content/en/docs/developerportal/deploy/_index.mdhttps://github.com/mendix/docs/pull/6188#discussion_r1231971077:

@@ -46,7 +46,7 @@ For more information, see [Mendix Cloud](/developerportal/deploy/mendix-cloud-de

3.1 Mendix Cloud Dedicated {#mendix-cloud-dedicated}
-Organizations can also have their own Mendix Cloud, named Mendix Cloud Dedicated. This works in exactly the same way as the Mendix Cloud, but runs on your own virtual private cloud and will only host your company's apps.
+Organizations can also have their own Mendix Cloud, named Mendix Cloud Dedicated. This works in exactly the same way as the Mendix Cloud except that the cluster on which the apps run is not shared with any other customers. Only your own organization's apps run on this cluster. Furthermore, you have the ability to link this cluster to your backend.
@MaartenMcFlyhttps://github.com/MaartenMcFly
Thanks for the PR, Maarten. I just have one question.
What exactly do you mean by having the ability to link the cluster to the customer's backend? What is a use case for this? I'm not sure I would understand exactly what was meant if I was a customer, so perhaps we can make it more specific with an example?
—
Reply to this email directly, view it on GitHubhttps://github.com/mendix/docs/pull/6188#pullrequestreview-1483022959, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABXHHVF4GFQO7SC56MRNWDDXLQMVHANCNFSM6AAAAAAZH7ODKA.
You are receiving this because you were mentioned.Message ID: @.***>

@MaartenMcFly

direct access to a customer's other system over their own network

That is a good phrase. I'll use it instead of "link the cluster to the customer's backend" as I think it is clearer.
Does that seem good, and is it OK to publish immediately once I've made that change?

@MaartenMcFly
Merging this PR - let me know if you want any other changes.
Thanks for creating it and providing the update to the text.
Mark

Good to go with that, no further changes!


PR Title for PR-1049

This is a pull request for PR-1049.

Generating PR code suggestions
Work in progress ...

PR Reviewer Guide 🔍

⏱ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 95
🧪 No relevant tests
🔒 No security concerns identified
🔀 No multiple PR themes

⚡ Key issues to review
ImprovementThe PR changes the bind address configuration from a hardcoded value to an environment variable. This is a good practice as it allows for more flexibility and easier deployment.

Generation Model with RAG True
qwen2.5-1.5b-ins-bf16

Preparing review...

PR Reviewer Guide 🔍

⏱ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 95
🧪 No relevant tests
🔒 No security concerns identified
🔀 No multiple PR themes

⚡ Key issues to review
EnhancementThe PR introduces a dynamic binding port configuration that reads the port from the environment variable PORT instead of hardcoding it. This makes the application more flexible and adaptable to different deployment environments.

Generation Model with RAG False
qwen2.5-1.5b-ins-bf16


allow user to specify non-default config file

-c <config_file>    Point to your own config file (Default: ./config.ini)

related to this, currently, you cant read config if run outside home directory.

added this in build 156


LCFS - Implement input fields for retained, deferred, and added renewable fuel obligations (lines 6,7,8 and 9 of the report summary)

Description:
Add functionality to handle the retention of renewable fuel, deferral of obligation and addition of obligations for each fuel class (Gasoline, Diesel, Jet Fuel) in the compliance report. This includes:

Retaining surplus renewable fuel volumes up to 5% of the obligations calculated in Line 4.
Deferring renewable fuel obligation deficiencies up to 5% of the obligations calculated in Line 4 to the next compliance period.
Auto-populating retained and deferred obligations from the previous compliance period or allowing for manual input.

Wireframe: link
Purpose and benefit to user:
To provide users with the ability to manage their renewable fuel obligations more flexibly, ensuring compliance and accurate tracking of surplus, deferred, and added obligations for future periods.
Acceptance Criteria:
Line 6: Volume of Eligible Renewable Fuel Retained

[ ]  Given I am a BCeID user, When I view the compliance report summary, then I see an option  for reporting retained fuel volumes for each fuel class in cells G6, D6, and J6.
[ ]  Given I am a BCeID user, When I input retained fuel volumes, then the fields only accept positive number values.
[ ]  Given I am a BCeID user, When I view the compliance report, then the free text fields for retained fuel volumes are only visible if cells G2, D2, and J2 do not show a balance of zero and there is a surplus above the renewable requirement.
[ ]  Display a cautionary note indicating the maximum retainable volume (5% of the obligations calculated on Line 4) for each fuel class.

Line 7: Volume of Eligible Renewable Fuel Previously Retained

[ ]  Given I am a BCeID user, When I view the compliance report summary table to report previously retained volume, then cells G7, D7, and J7 auto-populate with the volume noted in the prior year’s Line 6 compliance report for each fuel class.
[ ]  Given I am a BCeID user, When there is no previous compliance report available, then I see free text fields in cells G7, D7, and J7 for user input, restricted to positive number values.
[ ]  Given I am a BCeID user, When I input previously retained fuel volumes, then the fields only accept positive number values.

Line 8: Volume of Eligible Renewable Obligation Deferred

[ ] Given I am a BCeID user, When I view the compliance report summary, I see free text fields for deferring renewable fuel obligation volumes for each fuel class in cells G8, D8, and J8.
[ ]  Given I am a BCeID user, When I input deferred obligation volumes, then the fields only accept positive number values.
[ ]  Given I am a BCeID user, When I am short of my renewable obligation and in a penalty situation, then the free text fields in cells G8, D8, and J8 are available for input and I see the fields only if there is a deficiency.
[ ]  Display a cautionary note indicating the maximum deferrable volume (5% of the obligations calculated on Line 4) for each fuel class.

Line 9: Volume of Renewable Obligation Added

[ ] Given I am a BCeID user, When I view the compliance report summary table for reporting renewable obligation, cells G9, D9, and J9 auto-populate with the volume noted in the prior year’s Line 8 compliance report for each fuel class.
[ ]  Given I am a BCeID user, When there is no previous compliance report available, then I see free text fields in cells G9, D9, and J9 for user input, restricted to positive number values.
[ ]  Given I am a BCeID user, When I input added obligation volumes, then the fields only accept positive number values.

Development Checklist:
Line 6: Volume of Eligible Renewable Fuel Retained

[ ] Add free text fields for user input in cells G6, D6, and J6 of the summary table for renewable fuel retained, restricted to positive number values.
[ ]  Implement conditional logic to display the free text fields only if cells G2, D2, and J2 do not show a balance of zero and there is a surplus.
[ ]  Display a cautionary note indicating the maximum retainable volume (5% of the obligations calculated on Line 4) for each fuel class.
[ ]  Ensure the text fields are user-friendly and clearly labeled.
[ ]  Test the conditional visibility and input restrictions to ensure correct functionality.

Line 7: Volume of Eligible Renewable Fuel Previously Retained

[ ]  Implement logic to fetch and auto-populate cells G7, D7, and J7 of the report summary table for renewable fuel retained with data from the prior year’s Line 6 compliance report.
[ ]  Add free text fields for user input in cells G7, D7, and J7 if no previous compliance report is available, restricted to positive number values.
[ ]  Ensure the free text fields are user-friendly and clearly labeled.
[ ]  Test the auto-populate functionality to ensure it correctly fetches and displays the prior year’s retained fuel volumes.
[ ]  Test the conditional visibility and input restrictions of the free text fields to ensure correct functionality.

Line 8: Volume of Eligible Renewable Obligation Deferred

[ ]  Add free text fields for user input in cells G8, D8, and J8 of the report summary table for renewable obligation deferred, restricted to positive number values.
[ ]  Implement conditional logic to display the free text fields only if the user is short of their renewable obligation and in a penalty situation and there is a deficiency.
[ ]  Display a cautionary note indicating the maximum deferrable volume (5% of the obligations calculated on Line 4) for each fuel class.
[ ]  Ensure the text fields are user-friendly and clearly labeled.
[ ]  Test the conditional visibility and input restrictions to ensure correct functionality.

Line 9: Volume of Renewable Obligation Added

[ ]  Implement logic to fetch and auto-populate cells G9, D9, and J9 of the report summary table for renewable obligation added with data from the prior year’s Line 8 compliance report.
[ ]  Add free text fields for user input in cells G9, D9, and J9 if no previous compliance report is available, restricted to positive number values.
[ ]  Ensure the free text fields are user-friendly and clearly labeled.
[ ]  Test the auto-populate functionality to ensure it correctly fetches and displays the prior year’s added obligation volumes.
[ ]  Test the conditional visibility and input restrictions of the free text fields to ensure correct functionality.

Notes:

Confirm the data retrieval process from the previous compliance report for accurate auto-population.
Ensure the data validation rules for positive number values in the free text fields.
Verify the accuracy and clarity of the cautionary notes, auto-populated data, and free text fields for users.

Line 6 and 7 seem to be working great, except that the following fuel types only have a low carbon fuel requirement. While they are reported in the fuel supply schedule, the volumes of these supplies should not be included in the renewable fuel requirement summary and, therefore, are not part of line 6 or 7:

Electricity
Hydrogen
Propane
CNG
LNG

The following are eligible renewable fuels by type and when included in the organization's reporting of fuel supply, should allow line 6 and 7 to be available:
(1) for gasoline category = renewable gasoline, ethanol, renewable naphtha;
(2) for diesel category = biodiesel, HDRD, other diesel fuel;
(3) for jet fuel category = alternative jet fuel
The following are not renewable fuels. If a supplier reports these only one or more of these fuels, then line 6 and line 7 should not be available to them:

fossil-derived gasoline
fossil-derived diesel
fossil-derived jet fuel.

I will explain more about line 8 and 9 in another comment.

For line 8, I think the logic here has to be:
If line 2 meets or exceeds line 4, then this input on line 8 is not available.
If line 2 reports less than line 4, line 8 should be available for input.
(*Not 100% sure about this)
Line 8 of the jet fuel category should remain unavailable until 2028. In 2028, the first renewable fuel percentage of 1% begins and then line 8 can be available if needed.


Updating data using notifySectionDataSetChanged while multithreading

In calculateSections method, the getSectionCount is called twice: the first time to populate mSections list and the second time to calculate mSectionIndices. This is working fine in case the whole work is done in one thread.
In my case, I had a big number of data to work on and I used several threads to do so and after finishing working on a section, I call the if the notifySectionDataSetChanged to be executed on the UI thread.
In some cases, if the work on the other threads is being processed faster than the UI thread, the values returned by getSectionCount between the first call and the second one, are different:

I/Sticky: section count before : 4
I/Sticky: section : StickyHeaderGridAdapter$Section@25ef8b0d
I/Sticky: section : StickyHeaderGridAdapter$Section@3c6a5ac2
I/Sticky: section : StickyHeaderGridAdapter$Section@14fbf0d3
I/Sticky: section : StickyHeaderGridAdapter$Section@8d80410
E/Sticky: section count after : 5

I fixed this by calling the getSectionCount only once.

I've added changes to 0.9.7. But layout was not created as thread safe. So be careful.


request to copy / to extract ssh.rs

Hi,
I started a small crate that provide a git2's credential function git2_credentials. And you did an useful work about git's credentials.
Can I copy (and adapt) your code ssh.rs to include it into git2_credentials ?
Thanks.

Can I copy (and adapt) your code ssh.rs to include it into git2_credentials ?

Yes. Please do.
Please share your progress here also if you can.

Ok, I already copy/adapt a small part (ask passphrase for default id_rsa) as part of the v 0.2.0.
You're right the parsing of my .ssh/config failed.
Thanks.

You're right the parsing of my .ssh/config failed.

Please open a separate issue and provide the file.

@davidB any update on this?

wahoo nearly one year, but no update about parsing .ssh/config :-( , I'll redo a test after work and try to provide a minimal sample that failed

Hi,
I finally take time to copy+adapt your code to parse .ssh/config into git2_credential :sparkles: parse the .ssh/config file to search what key file to use … · davidB/git2_credentials@28cebc4
This commit include an modified ssh_config.pest to support more case like:

in-sensitive case "Host" (allowed from the man page, and my own config)
allow empty-line at top of the file
allow non-empty line at bottom of the file
provide value (quoted and unquoted) via p.as_rule() == Rule::value_unquoted  ("dquote" are removed)

I include few test, but not for all the case, I tried during my learn of pest & experimentation.
Feel free to copy back, Thanks again.


Use the updated method name

Method name was changed prior to original PR merge.  Forgot to update the caller.
https://bugzilla.redhat.com/show_bug.cgi?id=1219439

@miq-bot add_label provisioning,bug

@gmcculloug / @kbrock Please review

:+1:

Do you have a spec for this code path?  I think a spec would have caught this.

:+1: are you going to add a spec for this?

@kbrock Added a spec

rebooting - got the barney error.
Thought this test had been fixed.
If this fails again, you may want to rebase and push again. (or we could just merge despite the 1 sporadic failure)

LGTM


Allow setting custom titles for parts of IxGroupItem component

Suggestion / feature request
Currently, IxGroupItem adds automatic HTML title attributes for both text and secondaryText content (which are the exact copies of attribute's values).
We would like to change the title e.g. for secondaryText and provide user with more descriptive hint (e.g. "Slot number: 1" instead of "1").
Current behavior is as follows (and there is no way how to change it):

[IX-583]


Allow passing glam vector types as vertex attributes

Allow passing Vecs of glam vector types as vertex attributes.
Alternative to #4548 and #2719
Also used some macros to cut down on all the repetition.
Migration Guide
Implementations of From<Vec<[u16; 4]>> and From<Vec<[u8; 4]>> for VertexAttributeValues have been removed.
I you're passing either Vec<[u16; 4]> or Vec<[u8; 4]> into Mesh::insert_attribute it will now require wrapping it with right the VertexAttributeValues enum variant.

alternative to #2719 ?

CI is failing because I accidentally removed the following impls:
impl From<Vec<[u16; 4]>> for VertexAttributeValues {
    fn from(vec: Vec<[u16; 4]>) -> Self {
        VertexAttributeValues::Uint16x4(vec)
    }
}

impl From<Vec<[u8; 4]>> for VertexAttributeValues {
    fn from(vec: Vec<[u8; 4]>) -> Self {
        VertexAttributeValues::Unorm8x4(vec)
    }
}

but I'm not sure whether it makes sense to have these as [u16; 4] can be either Uint16x4 or Unorm16x4,
and [u8; 4] can be either Uint8x4 or Unorm8x4.

Failure is in example code. Can the example be improved to not use this From impl / be more explicit?

bors r+

bors r-

Ok, I'm fine with the Vec3A issue now. But could you add tests for the various glam types, including ones that verify the resulting '.into()'ed vertex attribute values please?

bors r+


rec: OpenSSL error

:::akavel@k14:::~/dnload/asciinema/asciinema-v0.4.0-x86_64-unknown-linux-musl$ ./asciinema rec

⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇  🔴  [RECORDING]  ⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇⬇

akavel@k14:~/dnload/asciinema/asciinema-v0.4.0-x86_64-unknown-linux-musl$ echo hello world
hello world
akavel@k14:~/dnload/asciinema/asciinema-v0.4.0-x86_64-unknown-linux-musl$ exit
https://asciinema.org/api/asciicasts: The OpenSSL library reported an error: error:14090086:SSL routines:ssl3_get_server_certificate:certificate verify failed:s3_clnt.c:1269:
                                             :::akavel@k14:::~/dnload/asciinema/asciinema-v0.4.0-x86_64-unknown-linux-musl$

Not sure if this is a bug in the app or an issue with the OS (it's on a hosted machine, so I don't have control over versions of installed libs etc.)

Thabms for the bug report!
Can you try running it with SSL_CERT_DIR=/etc/ssl/certs asciinema rec and see if that works?

I pushed a speculative fix for this and will cut a point release.

@akavel release is out: https://github.com/LegNeato/asciinema-rs/releases/tag/v0.5.0

Confirmed fixed, awesome, thanks! :) :)


Escape HTML tags for inline field errors

Im using custom errors like this:
activerecord:
  errors:
    messages:
      blank: "Field <b>%{attribute}</b> should not be blank."

Look that theres an attribute with bold tag. Without html_safe it will be printed incorrectly.

Could we have a test please?

It would be super if you can provide a test in the following hours, so this change can make to the 2.0 release.

Ok, test created. I also fixed the same problem in "error notifications".

Ok. Thanks.


[Material] Added support to has no control (continue/cancel button) in Stepper Widget

Flutter stepper widget does not allow to has no control button (continue/cancel).
Solution: I have created a bool useControl property to allow developer choose between use or not control's button.
Case of use: Product delivery stepper is not controlled by users, the app/system controls it's delivery.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

I signed it!

@HansMuller and @dnfield any news on this?

It seems like this is already possible by just overriding controlsBuilder to return a SizedBox.shrink or some such. Maybe we should just support controlsBuilder returning null, and have it skip the controls if it returns null?

It seems like this is already possible by just overriding controlsBuilder to return a SizedBox.shrink or some such. Maybe we should just support controlsBuilder returning null, and have it skip the controls if it returns null?

Hey @Hixie I just implemented in this way, now controlsBuilder supports returning null, and if it returns null we do not build the control... What do you think? Also I needed to put widget.steps[index].content in a Row otherwise it breaks the layout, in case we have controlsBuilder != null than the Row isn't needed because control already has it's own Row inside a Container
Here are one screenshoot with the result:


rpc/client: use standard errors package in tests

It was done in 770c8d774c , probably by accident.

Yeah, I've wanted to fix that also.


Make option if toolbar is floating or fixed on top of the block configurable.

Done with https://github.com/eea/volto-slate/pull/71


Worker location

const module = module { console.log(location); fetch('./') };
new Worker(module, { type: 'module' });

What would location look like? What url would be used to resolve relative urls?
This might get tricky if module was posted from another origin.

In my head it would behave just like a cross-origin module that gets imported and uses location. The module closes over the global scope so it would use location from there. Only import.meta.url gets special treatment.

(Note: that’s why it’s important to advocate for fetch(new URL("./", import.meta.url)) if you want relative fetches to behave as expected, even if posting modules from other origins.

In my head it would behave just like a cross-origin module that gets imported and uses location.

We don't currently allow workers to be constructed from a cross-origin URL, but we do allow a same-origin URL to import cross-origin script. I guess you could pretend it's more like the latter.
In that case location.origin would be the origin of the thing that called new Worker, but it isn't clear what the rest of location's properties would be.

My mental model has been that all of these things would be resolved based on which document the module block is. So I guess this would all be like if a cross-origin module were imported from a Worker. Would that cause any problems?

That's fine for the origin. I'm not sure about the rest - it isn't what happens if you load a worker from a blob URL. Maybe it's ok. If not, I guess location should show done kind of special module block URL.

I just realized: If we currently don’t allow spinning up workers with cross-origin modules, we probably shouldn’t allow spinning up workers with cross-origin module blocks, either. At least not in the MVP.

fwiw that's what I meant by:

We don't currently allow workers to be constructed from a cross-origin URL, but we do allow a same-origin URL to import cross-origin script. I guess you could pretend it's more like the latter.

I imagine that, on the HTML side, workers will remember which origin they were syntactically created in. So, we could block cross-origin module blocks in the Worker constructor, but then permit importing them later, to be analogous to all of that. I don't understand how this all relates to the location, though.

AFAIU, you just answered the question about location. Since it is not possible to create a worker from a cross-origin script, there is no precedent what the worker’s location would be in that case. With your definition, it is now well-defined.

What would location.href be?

Hm yeah good point. I think the easiest way forward for now would be to not allow Workers to be spun up using cross-origin module blocks. We can always try and loosen this restriction later on.

Still need to come up with location.href for same origin workers created with module blocks.

Ah, yes. I think I’m finally with you :D
An idea that we still need to spec/explore (see #26) is that a module block’s import.meta.url is the surrounding module’s import.meta.url + a UUID (e.g https://example.com/main.js#e9380885-2473-4487-9dc9-58b6ee335f12). I’d hope that location.href in a Worker is identical to import.meta.url, but that’s definitely something we need to think through in more detail.

It'd be the first time that fetch(location.href) doesn't give you the worker source, but maybe that's fine.

Yeah, I was thinking about that, too, but I can’t find any pattern or precedent on the platform that where both these scenarios behave correctly out of the box:

new URL("./relative-path.js", import.meta.url) should be relative to the surrounding module
fetch(location.href) should return the worker source
(optional: import(import.meta.url) returns the module block instance)

It's unfortunately inherent in this proposal that there is no URL to fetch to get the source of the module block. For example, the module block could be inside an eval.

The module contains information that isn't represented by the source anyway (such as the stuff that makes import.meta.url work).
Maybe location.href should just be a data URL to an empty JavaScript response.

Maybe this would all become less hacky if we had a way to create an empty worker, and something like worker.addModule(moduleBlockOrUrl).
The above could resolve with an instance of sorts (eg comlink built-in).


Display submissions in descending chronological order

I think I used "descending chronological order" correctly? I mean from newest to oldest.

good to go


openjdk8: Build issue on local machine (jdk8u)

Build openjkd8 on local machine gives the below error:
real	0m1.340s
user	0m0.196s
sys	0m0.112s
Completed configuring the version string parameter, config args are now:  --with-milestone=adoptopenjdk --with-update-version= --with-build-number=
Building up the configure command...
Overriding JDK_BOOT_DIR, set to /usr/lib/jvm/jdk1.7.0_65
Boot dir set to /usr/lib/jvm/jdk1.7.0_65
Completed configuring the version string parameter, config args are now:  --with-boot-jdk=/usr/lib/jvm/jdk1.7.0_65 --enable-ccache --with-jvm-variants=server --with-cacerts-file=/home/satyasai/LJCAdvocate/OpenJDKStuff/Tools/openjdk-build/cacerts_area/security/cacerts --with-alsa=/home/satyasai/LJCAdvocate/OpenJDKStuff/Tools/openjdk-build/alsa-lib-<IP_ADDRESS> --with-freetype=/home/satyasai/LJCAdvocate/OpenJDKStuff/Tools/openjdk-build/openjdk/installedfreetype --with-x=/usr/include/X11 --with-debug-level=release
Should have the source, I'm at /home/satyasai/LJCAdvocate/OpenJDKStuff/Tools/openjdk-build/openjdk
Configuring command and using the pre-built config params...
Currently at '/home/satyasai/LJCAdvocate/OpenJDKStuff/Tools/openjdk-build/openjdk'
Running ./configure with arguments ' --with-boot-jdk=/usr/lib/jvm/jdk1.7.0_65 --enable-ccache --with-jvm-variants=server --with-cacerts-file=/home/satyasai/LJCAdvocate/OpenJDKStuff/Tools/openjdk-build/cacerts_area/security/cacerts --with-alsa=/home/satyasai/LJCAdvocate/OpenJDKStuff/Tools/openjdk-build/alsa-lib-<IP_ADDRESS> --with-freetype=/home/satyasai/LJCAdvocate/OpenJDKStuff/Tools/openjdk-build/openjdk/installedfreetype --with-x=/usr/include/X11 --with-debug-level=release '
bash: ./configure: No such file or directory

Failed to configure the JDK, exiting
Did you set the JDK boot directory correctly? Override by exporting JDK_BOOT_DIR
For example, on RHEL you would do export JDK_BOOT_DIR=/usr/lib/jvm/java-1.7.0-openjdk-<IP_ADDRESS>-<IP_ADDRESS>.el7_3.x86_64
Current JDK_BOOT_DIR value: /usr/lib/jvm/jdk1.7.0_65
....

So it can't find ./configure?

@karianna the issue is actually a different one, a bit of a red-herring by our scripts, this can happen in two instances:

we passed it the incorrect repo name, git clone fails but continues till it can't find ./configure
we passed it the correct repo name, but the branch dev or any other said tag or branch does not exist, git clone fails but continues till it can't find ./configure


"Invalid range in character set" error when building with Webpack

When I am developing my site I run it using SystemJS and highlightjs works fine.
When I am ready to deploy I build it with Webpack and this is where the problem is.
I am still new to both SystemJS and Webpack so if I'm doing something completely wrong dont be surprised.
I would be very grateful if one of you could you could interpret the error message and tell me where to look.  As far as I know all the packages are current.  In any case, both SystemJS and Webpack should be reading from node_modules on my disk so I'm confused why one works and the other does not.
I am using Angular2 and typescript to build my site.  Here is my component that reads a text file from disk and highlights any code:
var hljs = require('highlightjs');
declare var highlight: any; // in site.js

//.....

private getContentItem(slug: string)
	{

		this.blogService.GetPostHtml(this.sessionService.PostRoot + this.Post.URL).subscribe((h: string) => {

			this.contentContainer2.nativeElement.innerHTML = h;

			highlight(hljs); // exists in js/site.js

		});

	}
}

The relevent method is site.js:
window.highlight = function (hljs) {
    var allPre, i, j;
    allPre = document.getElementsByTagName("pre");

    for (i = 0, j = allPre.length; i < j; i++) {
        hljs.highlightBlock(allPre[i]);
    }
}

Again, the above works fine with SystemJS.  I only get an error with Webpack.
I call initHighlightingOnLoad() in my main method.  It appears to work fine with both SystemJS and Webpack so I don't show it.
Here is relevant portion of SystemJS.config.js:
(function (global) {

// map tells the System loader where to look for things
var map = {
    'app': 'app', // 'dist',
    '@angular': 'node_modules/@angular',
    'angular2-in-memory-web-api': 'node_modules/angular2-in-memory-web-api',
    'rxjs': 'node_modules/rxjs',
    'highlightjs':'node_modules/highlightjs'
};

// packages tells the System loader how to load when no filename and/or no extension
var packages = {
    'app': { main: 'main.js', defaultExtension: 'js' },
    'rxjs': { defaultExtension: 'js' },
    'angular2-in-memory-web-api': { main: 'index.js', defaultExtension: 'js' },
    'highlightjs': { main:'highlight.pack.min.js',  defaultExtension: 'js' }
};

Webpack.common.js
var webpack = require('webpack');
var HtmlWebpackPlugin = require('html-webpack-plugin');
var ExtractTextPlugin = require('extract-text-webpack-plugin');
var helpers = require('./helpers');

module.exports = {
	entry: {
		'polyfills': './wwwroot/app/polyfills.ts',
		'vendor': './wwwroot/app/vendor.ts',
		'app': './wwwroot/app/main.ts'
	},

	resolve: {
		extensions: ['', '.js', '.ts']
	},

	module: {
		loaders: [
		  {
			  test: /\.ts$/,
			  loaders: ['awesome-typescript-loader', 'angular2-template-loader']
		  },

		  {
			  test: /\.css$/,
			  loader: ExtractTextPlugin.extract("style-loader", "css-loader", {publicPath:"/build/"})
		  },

		  {
			  //test: /\.(jpe?g|png|gif|svg)$/i,
			  test: /\.(png|jpe?g|gif|svg|woff|woff2|ttf|eot|ico)$/i,
			  loaders: [
				  'file?hash=sha512&digest=hex&name=assets/[hash].[ext]',
				  'image-webpack?optimizationLevel=7&interlaced=false'
			  ]
		  }
		],

		preLoaders: [
		 //All output '.js' files will have any sourcemaps re-processed by 'source-map-loader'.
		{ test: /\.js$/, loader: "source-map-loader" }]
	},

	plugins: [
	  new webpack.optimize.CommonsChunkPlugin({
		  name: ['app', 'vendor', 'polyfills']
	  }),

	  new HtmlWebpackPlugin({
		  template: './wwwroot/index-webpack.html'
	  }),

	  new webpack.optimize.UglifyJsPlugin({
			test: /\.(js|jsx)$/,
			minimize: true,
			sourceMap: true,
			mangle:false
	  }),

	  new webpack.ProvidePlugin({
		  $: "jquery",
		  jQuery: "jquery"
	  })
	]
	, devtool: 'source-map'
};

vendor exports:
import '@angular/platform-browser';
import '@angular/platform-browser-dynamic';
import '@angular/core';
import '@angular/common';
import '@angular/http';
import '@angular/router';
import 'rxjs';
import 'jquery';
import '../../node_modules/bootstrap';
import '../../node_modules/highlightjs';

require('../../node_modules/bootstrap/dist/css/bootstrap.min.css');
require('../../node_modules/highlightjs/styles/androidstudio.css');
require('../css/site.css');
require('../js/site.js');

package.json
"dependencies": {
"@angular/common": "2.4.3",
"@angular/compiler": "2.4.3",
"@angular/core": "2.4.3",
"@angular/forms": "2.4.3",
"@angular/http": "2.4.3",
"@angular/platform-browser": "2.4.3",
"@angular/platform-browser-dynamic": "2.4.3",
"@angular/router": "3.4.3",
"bootstrap": "^3.3.7",
"core-js": "^2.4.1",
"highlightjs": "^9.8.0",
"jquery": "^3.1.0",
"reflect-metadata": "^0.1.3",
"rxjs": "5.0.2",
"systemjs": "0.19.40",
"ts-loader": "^0.8.2",
"zone.js": "^0.7.4"
 },
"devDependencies": {
"angular2-template-loader": "^0.6.0",
"awesome-typescript-loader": "^3.0.0-beta.18",
"concurrently": "^2.2.0",
"lite-server": "^2.2.0",
"css-loader": "^0.26.1",
"extract-text-webpack-plugin": "^1.0.1",
"file-loader": "^0.9.0",
"image-webpack-loader": "^2.0.0",
"source-map-loader": "^0.1.5",
"style-loader": "^0.13.1",
"typings": "^1.3.3",
"webpack": "^1.14.0",
"typescript": "^2.1.4",
"webpack-dev-server": "^1.16.2",
"webpack-merge": "^2.0.0",
"html-webpack-plugin": "^2.26.0",
"url-loader": "^0.5.7"
}

Error message:
EXCEPTION: Invalid range in character set
core.umd.js (3486,1)
ORIGINAL STACKTRACE:
core.umd.js (3486,1)
SyntaxError: Invalid range in character set
   at s (http://www.x.com/build/polyfills.e82b7da4d27b1c1bf46d.js:2:10738)
   at langRe (http://www.x.com/build/vendor.e82b7da4d27b1c1bf46d.js:165:1844)
   at compileMode (http://www.x.com/build/vendor.e82b7da4d27b1c1bf46d.js:165:2297)
   at Anonymous function (http://www.x.com/build/vendor.e82b7da4d27b1c1bf46d.js:165:2947)
   at Array.prototype.forEach (native code)
   at compileMode (http://www.x.com/build/vendor.e82b7da4d27b1c1bf46d.js:165:2782)
   at compileLanguage (http://www.x.com/build/vendor.e82b7da4d27b1c1bf46d.js:165:3232)
   at highlight (http://www.x.com/build/vendor.e82b7da4d27b1c1bf46d.js:165:5372)
   at Anonymous function (http://www.x.com/build/vendor.e82b7da4d27b1c1bf46d.js:165:5991)
   at Array.prototype.forEach (native code)
   at highlightAuto (http://www.x.com/build/vendor.e82b7da4d27b1c1bf46d.js:165:5942)
   at highlightBlock (http://www.x.com/build/vendor.e82b7da4d27b1c1bf46d.js:165:6501)
   at e.highlight (http://www.x.com/build/vendor.e82b7da4d27b1c1bf46d.js:184:19500)
   at Anonymous function (http://www.x.com/build/app.e82b7da4d27b1c1bf46d.js:22:26251)
   at SafeSubscriber.prototype.__tryOrUnsub (http://www.x.com/build/vendor.e82b7da4d27b1c1bf46d.js:84:2687)
core.umd.js (3486,1)
SCRIPT5021: Invalid range in character set
Subscriber.ts (241,7)

For the benefit of the next poor soul that encounters this:  Turns out the error was caused by UglifyJsPlugin.  I removed all references to that plugin and I am back in business.


Do you miss [FromBody] for post sample. otherwise it can not accept json body.

post sample does not accept json body.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 583ae3e7-5915-f22b-e54c-6c100cf2a7da
Version Independent ID: 95f2549e-29f9-e31a-b4d0-432b971643ff
Content: Tutorial: Create a web API with ASP.NET Core MVC
Content Source: aspnetcore/tutorials/first-web-api.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

@qitia This particular controller is annotated with the [ApiController] attribute that was introduced in ASP.NET Core 2.1. Consequently, binding source inference is in play. The binding source inference feature assumes the parameter will be found in the request body, therefore making the application of the [FromBody] unnecessary.


Event.get_uid() doesn't work when event is constructed from builder functions

When an event is constructed as follows:
let mut event = Event::new();
event = event.summary("testing").starts(start_time).ends(end_time).done();
dbg!(&event.to_string());

the debug clearly shows the event body as having a UID. However:
let event_uid = event.get_uid().unwrap();
This panics. I'd assume setting the uid manually with uid() would work, but I don't want to do this. Perhaps I'm doing something wrong here, which of course I'm open to, but this doesn't seem like intended functionality.
edit: looks like the UID property isn't getting populated at all on event creation - event.properties() doesn't have UID and event.property_value("UID").unwrap() panics too.

Yes the default behavior right now is that you have to set that yourself. I was thinking for a bit what could be a safe default to generate a UID from something in the event data but haven't found a good approach yet. Also the lib can't just gehst generate a random uuid either, since you'd get a different uid for the same event every time you regenerate the calendar. So at the moment the crate leaves it to the user to fill out the uid.

that's fair. the weird thing really is that if you debug the string created by &Event.to_string(), it does have a uid there. So I imagine something somewhere is creating this uid, but I haven't looked at the codebase enough to figure out where that's coming from. Any ideas?

yes, actually in the serialization we check if there is a UID and if not we create a UUID to fill it.
According to RFC5545 <IP_ADDRESS> :

The property MUST be specified in the "VEVENT",
"VTODO", "VJOURNAL", or "VFREEBUSY" calendar components.

So we generate one at serialization time.
I'm not super happy with this approach, but it is probably sufficient for a one time generation. But if you serve an iCalendar you will want to generate them yourself in order to get a stable UID.
If you have a better idea please let me know.

This can probably be solved by seperating the builder as in #35! Then you can use the user supplied UID or generate one when build() is called. A generated Event can then always have a UID.
Optionally, there could be an Event::regenerate_uid() to make sure that it is always possible to get the UID that would be automatically generated even if changing properties afterwards.


How to read multiple values?

I saw in the documentation that simpleini supports multiple values per key. I'd like to use this feature, but for the life of me I can't figure out how the ini file has to be written.
I tried the following delimiters: " " (space), "," "|"
I tried the following brackets: none, (values), [values], {values}
So the question is: what syntax do you expect in the ini file, so that I can use the function "ini.GetAllValues("section-name", "key-name", values);"? The sample ini files don't appear to include an example...

Repeat the key. The key Phone in this example has multiple values.
[Owner]
Name=Joe
Phone=0405444888
Phone=0405666661
On Fri, 20 Sep. 2019, 19:18 vueltaconicarus<EMAIL_ADDRESS>wrote:

I saw in the documentation that simpleini supports multiple values per
key. I'd like to use this feature, but for the life of me I can't figure
out how the ini file has to be written.
I tried the following delimiters: " " (space), "," "|"
I tried the following brackets: none, (values), [values], {values}
So the question is: what syntax do you expect in the ini file, so that I
can use the function "ini.GetAllValues("section-name", "key-name",
values);"? The sample ini files don't appear to include an example...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/brofield/simpleini/issues/42?email_source=notifications&email_token=AACZ4MVSY545OA5XZRHG3XTQKSIPNA5CNFSM4IYUYCQKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HMUB2VQ,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACZ4MTD4HQAM7LVKI37PD3QKSIPNANCNFSM4IYUYCQA
.

Thanks, I got it working!
For future readers of this issue: The second important ingredient is to enable the option when inizializing the ini file:
bool a_bIsUtf8 = false, a_bUseMultiKey = true, a_bUseMultiLine = false;
CSimpleIniA ini(a_bIsUtf8, a_bUseMultiKey, a_bUseMultiLine);


I will migrate it to something like Read The Docs and host it on the Octoposh repo so anyone can contribute to it.

Docs URL: http://octoposh.readthedocs.io/en/latest/Cmdlets/Get-OctopusChannel/
Script I'm working on to programatically generate the .md docs of the cmdlets: https://github.com/Dalmirog/OctoPosh/blob/master/Scripts/Generate-CmdletMarkdownDocs.ps1

This was done in https://github.com/Dalmirog/OctoPosh/commits/master?after=f4f5db7495feb6f900c18edf268a576a145e50c6+34&path[]=docs


set data_width=8,network hls error

after set(DATA_WIDTH 8 CACHE STRING "Data width"),When I make the shell, the HLS integration of the network stack will report an error. The error message is as follows:
(1)ERROR: [HLS 200-70] Compilation errors found: In file included from hw/services/network/hls/ip_handler/ip_handler.cpp:1:
hw/services/network/hls/ip_handler/ip_handler.cpp:539:2: error: no matching function for call to 'ip_handler_compute_ipv4_checksum'
ip_handler_compute_ipv4_checksum(ipDataMetaFifo, ipDataCheckFifo, iph_subSumsFifoOut);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(2)hw/services/network/hls/ip_handler/ip_handler.cpp:656:2: note: in instantiation of function template specialization 'ip_handler<64>' requested here
ip_handler<DATA_WIDTH>(s_axis_raw,
(3)hw/services/network/hls/ip_handler/../ipv4/ipv4.hpp:361:6: note: candidate function not viable: no known conversion from 'hls::stream<net_axis<64> >' to 'hls::stream<net_axis<512> > &' for 1st argument;
void ip_handler_compute_ipv4_checksum( hls::stream<net_axis<512> >& dataIn,

Are you explicitly setting this DATA_WIDTH parameter? This is not one of the parameters that are exported to higher levels. Coyote currently supports only boards that are able to run at 100+G, this in turn implies that only DATA_WIDTH of 64 is supported.

Are you explicitly setting this DATA_WIDTH parameter? This is not one of the parameters that are exported to higher levels. Coyote currently supports only boards that are able to run at 100+G, this in turn implies that only DATA_WIDTH of 64 is supported.

thank you very much for your reply,
yes, I Implicit setting DATA_WIDTH parameter from 64 to 8 at bottom level, I have no boards that support 100g network, only 10g boards, so I want to try on 10g boards

We dropped the support for older boards with 10g interfaces long time ago, especially as Coyote mostly targets data center deployments, but it shouldn't take a lot of effort to bring this back. In theory only a simple width conversion is necessary. What setup are you using?

thank you very much for your reply,
I tried to build a network application. You are right. I was also looking at some scripts in the project. I found that I needed to modify some script content. Now I am also trying to modify the script

We dropped the support for older boards with 10g interfaces long time ago, especially as Coyote mostly targets data center deployments, but it shouldn't take a lot of effort to bring this back. In theory only a simple width conversion is necessary. What setup are you using?

thank you very much for your reply,
I tried to build a network application. You are right. I was also looking at some scripts in the project. I found that I needed to modify some script content. Now I am also trying to modify the script

@d-kor  hi，
Now I have changed some scripts and found that the hw/services/network can generate the corresponding 10G HLS IP core. The script I changed is as follows，
(1) In lines 50~51, Coyote/hw/CMakeLists.txt
set(DATA_WIDTH 8 CACHE STRING "Data width")
set(CLOCK_PERIOD 6.4 CACHE STRING "Clock period.")
(2) In lines 15~20,Coyote/hw/services/network/CMakeLists.txt
set(NETWORK_BANDWIDTH 10 CACHE STRING "Network bandwidth.")
# set bandwidth
set(NETWORK_INTERFACE 10 CACHE STRING "Network interface.")
set(DATA_WIDTH 8 CACHE STRING "Data width")
set(CLOCK_PERIOD 6.4 CACHE STRING "Clock period.")
Add in line 36:
add_ subdirectory(hls/ethernet_frame_padding)

(3) in 534~535 line ，Coyote/hw/services/network/hls/ip_ handler/ip_ handler. cpp
//ip_ handler_ rshiftWordByOctet<net_ axis, WIDTH, 1>(((ETH_HEADER_SIZE%WIDTH)/8), ipv4ShiftFifo, ipDataFifo);
//ip_ handler_ rshiftWordByOctet<net_ axis, WIDTH, 3>(((ETH_HEADER_SIZE%WIDTH)/8), ipv6ShiftFifo, ipv6DataFifo);
rshiftWordByOctet<net_ axis, WIDTH, 1>(((ETH_HEADER_SIZE%WIDTH)/8), ipv4ShiftFifo, ipDataFifo);
rshiftWordByOctet<net_ axis, WIDTH, 3>(((ETH_HEADER_SIZE%WIDTH)/8), ipv6ShiftFifo, ipv6DataFifo);
 and in 539 lines:
 //ip_ handler_ compute_ ipv4_ checksum(ipDataMetaFifo, ipDataCheckFifo, iph_subSumsFifoOut);
 compute_ ipv4_ checksum(ipDataMetaFifo, ipDataCheckFifo, iph_subSumsFifoOut);

(4)in 128 line ,Coyote/hw/scripts/wr_hdl/template_gen/lynx_pkg.txt
parameter integer AXI_NET_BITS = 64;
  I don't know whether the network hls ip is generated correctly after this change, and whether the interface data width of the network protocol stack is completely 64Bit after this change

@d-kor hi，
Now I have changed some scripts and found that the hw/services/network can generate the corresponding 10G HLS IP core. The script I changed is as follows，
(1) In lines 50~51, Coyote/hw/CMakeLists.txt
set(DATA_WIDTH 8 CACHE STRING "Data width")
set(CLOCK_PERIOD 6.4 CACHE STRING "Clock period.")
(2) In lines 15~20,Coyote/hw/services/network/CMakeLists.txt
set(NETWORK_BANDWIDTH 10 CACHE STRING "Network bandwidth.")
# set bandwidth
set(NETWORK_INTERFACE 10 CACHE STRING "Network interface.")
set(DATA_WIDTH 8 CACHE STRING "Data width")
set(CLOCK_PERIOD 6.4 CACHE STRING "Clock period.")
add in line 36:
add_ subdirectory(hls/ethernet_frame_padding)

(3) in 534~535 line ，Coyote/hw/services/network/hls/ip_ handler/ip_ handler. cpp
//ip_ handler_ rshiftWordByOctet<net_ axis, WIDTH, 1>(((ETH_HEADER_SIZE%WIDTH)/8), ipv4ShiftFifo, ipDataFifo);
//ip_ handler_ rshiftWordByOctet<net_ axis, WIDTH, 3>(((ETH_HEADER_SIZE%WIDTH)/8), ipv6ShiftFifo, ipv6DataFifo);
rshiftWordByOctet<net_ axis, WIDTH, 1>(((ETH_HEADER_SIZE%WIDTH)/8), ipv4ShiftFifo, ipDataFifo);
rshiftWordByOctet<net_ axis, WIDTH, 3>(((ETH_HEADER_SIZE%WIDTH)/8), ipv6ShiftFifo, ipv6DataFifo);
and in 539 lines:
    //ip_ handler_ compute_ ipv4_ checksum(ipDataMetaFifo, ipDataCheckFifo, iph_subSumsFifoOut);
    compute_ ipv4_ checksum(ipDataMetaFifo, ipDataCheckFifo, iph_subSumsFifoOut);

(4)in 128 line ,Coyote/hw/scripts/wr_hdl/template_gen/lynx_pkg.txt
parameter integer AXI_NET_BITS = 64;
I don't know whether the network hls ip is generated correctly after this change, and whether the interface data width of the network protocol stack is completely 64Bit after this change

You will need to convert this to 64-byte bus at some point. Ideally, you should change the network_module.sv to sink/src a 64-byte bus. For this you can use AXI4 stream data width converters which can be instantiated as IP cores in your design.

You will need to convert this to 64-byte bus at some point. Ideally, you should change the network_module.sv to sink/src a 64-byte bus. For this you can use AXI4 stream data width converters which can be instantiated as IP cores in your design.

hi @d-kor，
As you said, I added 512 to 64 and 64 to 512 data width conversion IP in the network_ module. sv (10g ip and interface) module, I executed the following example: perf_ rdma_ Host and perf_ rdma_ Card, successfully generated a bit file. How can I test these two examples?

hi @d-kor，
when i make examples/perf_rdma, the following errors are exposed ：
sw/src/cService.cpp:257:75: error: expected primary-expression before ‘(’ token
el.second->scheduleTask(std::unique_ptr(new cTask(int32_t 0, int32_t 0, uint32_t 1, taskIter->second, msg)));
^
/home/ubuntu/Coyote_lasttest/pro_2022/Coyote_bit/sw/src/cService.cpp:257:80: error: expected type-specifier before ‘cTask’
el.second->scheduleTask(std::unique_ptr(new cTask(int32_t 0, int32_t 0, uint32_t 1, taskIter->second, msg)));

Which c++ version are you using? This looks like you are stuck on some older version. As stated in the guide, you should have at least c++17 installed.

hi @d-kor，
The gcc/g++version I installed and the default c++version are as follows，
gcc-7.5/g++-7.5
#define __cplusplus 201703L(c++14)   ( g++/gcc -dM -E -x c++ /dev/null | grep -F __cplusplus)
 When I replace it with gcc11, it is as follows,
       gcc version 11.1.0
       #define __cplusplus 201703L(c++17)  ( g++/gcc -dM -E -x c++ /dev/null | grep -F __cplusplus)

my cmake version is 3.16.2,which supported C++ standard values are 98, 11, 14, 17, and 20.

but when i make examples/perf_rdma, the following errors are exposed ：
          sw/src/cService.cpp:257:75: error: expected primary-expression before ‘(’ token
   el.second->scheduleTask(std::unique_ptr<bTask>(new cTask(int32_t 0, int32_t 0, uint32_t 1, taskIter->second, msg)));
          sw/src/cService.cpp:257:94: error: expected primary-expression before numeric constant
   el.second->scheduleTask(std::unique_ptr<bTask>(new cTask(int32_t 0, int32_t 0, uint32_t 1, taskIter->second, msg)));
          sw/src/cService.cpp:257:105: error: expected primary-expression before numeric constant
   el.second->scheduleTask(std::unique_ptr<bTask>(new cTask(int32_t 0, int32_t 0, uint32_t 1, taskIter->second, msg)));
          sw/src/cService.cpp:257:117: error: expected primary-expression before numeric constant
   el.second->scheduleTask(std::unique_ptr<bTask>(new cTask(int32_t 0, int32_t 0, uint32_t 1, taskIter->second, msg)));

hi @d-kor,
Thank you very much for your response，
When I replace gcc7.5 with gcc11, build_ perf_ rdma_ Sw make succeeded, I would like to ask how to perform board level testing and verification for rdma examples, What do the examples which build_perf_rdma_card_hw and build_perf_rdma_host_hw represent?

hi @d-kor,
   An error is reported in the i make driver. The error is as follows，
         ./include/linux/module.h:132:13: warning: ‘init_module’ specifies less restrictive attribute than its target ‘coyote_init’:
         ‘cold’ [-Wmissing-attributes]
              132 |         int init_module(void) __attribute__((alias(#initfn)));
        /Coyote/driver/fpga_drv.c:76:1: note: in expansion of macro ‘module_init’
              76 | module_init(coyote_init);
       Coyote/driver/fpga_drv.c:47:19: note: ‘init_module’ target declared here
              47 | static int __init coyote_init(void)
       In file included from Coyote/driver/coyote_dev.h:43,
             from /Coyote_bit1/driver/fpga_drv.h:31,
             from /Coyote/driver/fpga_drv.c:28:
       ./include/linux/module.h:138:14: warning: ‘cleanup_module’ specifies less restrictive attribute than its target ‘coyote_exit’:
            ‘cold’ [-Wmissing-attributes]
             138 |         void cleanup_module(void) __attribute__((alias(#exitfn)));
       /Coyote/driver/fpga_drv.c:77:1: note: in expansion of macro ‘module_exit’
             77 | module_exit(coyote_exit);
       Coyote/driver/fpga_drv.c:65:20: note: ‘cleanup_module’ target declared here
             65 | static void __exit coyote_exit(void)

 This seems to be related to the Linux kernel，My system kernel version is /usr/src/linux-headers-4.18.0-15-generic

hi @d-kor,
At present, I have encountered several problems
(1)When I build the HW RDMA host perf example, the project finally generates a bit file, but there are key warnings：
inst_roce_stack/rocev2_inst  has unconnected pin s_axis_rx_data_TSTRB[0]~[63]
inst_roce_stack/rocev2_inst  has unconnected pin s_axis_mem_read_data_TSTRB[28]~[63]
(2)When i check  roce stack  hls generated, the pin signal s of roce ip_ axis_ rx/tx_ The data signal has more TSTRB, but
there is no TSTRB signal at the network stack top of the project
(3)I tried to do the hls csim of ROCE, but the simulation failed
(4) when i make driver with gcc11, generate coyote_drv.ko ,but the warning is as follows，
warning: ‘init_module’ specifies less restrictive attribute than its target ‘coyote_init’:  ‘cold’ [-Wmissing-attributes]
warning: ‘cleanup_module’ specifies less restrictive attribute than its target ‘coyote_exit’: ‘cold’ [-Wmissing-attributes]
       when i make driver with gcc7.5, generate coyote_drv.ko , no warming

        This seems to be related to the Linux kernel，My system kernel version is /usr/src/linux-headers-4.18.0-15-generic and kernel‘s gcc version is 7.3.0,I should use that version of gcc to compile the driver?

(1) and (2) These warnings are fine, the strobe interface is not used.
(3) Not really sure what fails here, will have to check, we simulated RoCE fine on our side.
(4) This is kernel version related, the warnings shouldn't be critical.
The two examples are used to measure the throughput and latency performance of base RDMA operations (READ and WRITE). To run these benchmarks you will need at least two machines connected over some form of 100G (or in your case 10G) link.

hi @d-kor，
Thank you very much for your answer
(1)The steps of my roce simulation are as follows，vitis 2022.1
cd hls/rocev2 && mkdir build && cd build
cmake  ..  -DFPGA_PART=
make csim/csim.rocev2
The following error is prompted,
test_ib_transport.cpp:75:5: error: no matching function for call to ‘ib_transport_protocol<DATA_WIDTH, 1>....
(2) about board level testing and verification for rdma examples
As you said, it is to form a network loop for testing, assume there are two hosts:host0 and host1
a，host0 + fpga(with bit of build_perf_rdma_host_hw or build_perf_rdma_card_hw and ) <-> 100/10g Optical network cable <->  nic card with rdma( or nic card no rdma + soft rdma stack) + host1
b, host0 + fpga(with bit of build_perf_rdma_host_hw ) <-> 100/10g Optical network cable <->   fpga(with bit of build_perf_rdma_card_hw) + build_perf_rdma_card_sw + host1
Which of the two ways is right?

hi @d-kor，
when i run perf_tcp application , the following errors are exposed,
build_perf_tcp_sw$ sudo ./main
terminate called after throwing an instance of 'std::runtime_error'
what():  Local IP address not provided
Aborted


Bootstrap missing Card Outlines

From the Documentation Cards Outline
The cards have the appropriate colours but on using the 4.0.0-beta.2 version
The css selectors card-outline-* are missing from the bootstrap.min.css
But are available on alpha v6 which is used for the documentation.
Please add the cards css:
.card-outline-primary{background-color:transparent;border-color:#0275d8}.card-outline-secondary{background-color:transparent;border-color:#ccc}.card-outline-info{background-color:transparent;border-color:#5bc0de}.card-outline-success{background-color:transparent;border-color:#5cb85c}.card-outline-warning{background-color:transparent;border-color:#f0ad4e}.card-outline-danger{background-color:transparent;border-color:#d9534f}
Hopefully this wasn't deprecated, if so I hope the docs get updated.

https://getbootstrap.com/docs/4.0/components/card/#border

Seems I was using the old alpha docs.


[refarch/osp-cli] Remove unneeded line in ch4.6_generate_dns_updates.sh

Line 5: HOSTNAME=$1
This value is unused in the script.  Remove it.

Removing that line and several others that are extraneous.


Fix video stutter when opening a chat

No content

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @zach in #android-bugs.

I dont think this occurs anymore. If it does, it's so minute, it's not worth looking into


powershell.exe terminated with exit code: 259

Issue Type: Bug
Steps To Reproduce :

Goto Terminal
New Terminal

Terminal Closes with a notification saying
"The terminal process "C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe" terminated with exit code: 259."

VS Code version: Code 1.50.0 (93c2f0fbf16c5a4b10e4d5f89737d9c2c25488a3, 2020-10-07T06:10:52.432Z)
OS version: Windows_NT x64 6.3.9600

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-4200U CPU @ 1.60GHz (4 x 2295)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.88GB (6.28GB free)

Process Argv
--crash-reporter-id 0da01979-fae7-4d97-8e38-b592c70d1412

Screen Reader
no

VM
0%

Extensions (6)

Extension
Author (truncated)
Version

code-runner
for
0.11.2

python
ms-
2020.12.424452561

jupyter
ms-
2020.12.414227025

cpptools
ms-
1.1.3

LiveServer
rit
5.6.1

open-in-browser
tec
2.0.0

Duplicate of https://github.com/microsoft/vscode/issues/113738
in that issue I have questions for the issue filer. Can you please answer those same questions in that issue?

Duplicate of https://github.com/microsoft/vscode/issues/113738
in that issue I have questions for the issue filer. Can you please answer those same questions in that issue?


'Requests groups' feature documentation

Hi,
is there any documentation regarding 'requests group' feature, except documentation for API calls
I mean, I don't know what is it used for, what was the idea behind the feature.
I need the possibility to start/stop a group of requests as a whole, so it comes to my mind that this feature can handle that, but I can't find any documentation for it.

The request groups is more for logically grouping things in the UI that actually operating on a group of them. For example, if you put two requests in the same group you'd get a tabbed ui page like:

You can operate on all requests in a group via the ui, but behind the scenes it is just making multiple api calls. If you want to start adding request groups, you can POST a SingularityRequestGroup (basically an id for the group + list of request ids) to the /api/groups endpoint
Will leave this open to add some documentation on what the features does though.

Thanks for explanation.
I assign couple of requests to the same group, but I don't see any url which would give me group page, like you showed in the answer.
I'm still on 0.13. Does it exist there, or it's added in later, because I can't see mentioning that url in next releases?

Request groups was added in 0.12

I found that info. But what I didn't find is url on UI that I can use to view groups (part of your sreenshot in your answer).
But maybe you prefer that singularity users dig source code in search of useful information.  I tried to do that way, pick something from here but still no luck,  /singularity/groups on UI returns 404.

In the ui the path should be (ui base)/group/(group id). If a request is part of a group, it should have a link to that page in the upper left of the request detail page

Hi,
API calls work fine. However, there is no any link in UI for accessing groups. I have to manually enter (ui base)/group/(group id).
Also, there is no possibility to add, remove or modify groups using UI.

The link may have been added in a later version. We do have plans to expose the groups in the ui more in upcoming releases as well

There are now nicer links for groups in the UI in recent releases. The UI allows some bulk actions, but is still just making multiple calls. We don't have any plans to make bulk actions on the backend at the moment. So going to close this one for now


Open recent request gives "File in unrecognised format!" error

The error was introduced when I try to open a request file from File -> Open Recent.

Version 3.5 & 3.6: also happens when you try to drag and drop a request file.

Can you provide the .rcq file that is failing? Note, that the .rcq is just a XML file, you may also post the content of it by opening in a text editor.

@subwiz sure. Also note that File->Open recent is also throwing format error.
This was saved with the latest 3.6 version:
<?xml version="1.0" encoding="UTF-8"?>
<rest-client version="3.6"><request><http-version>1.1</http-version><http-follow-redirects/><URL>http://localhost:3000/run_jobs</URL><method>POST</method><headers><header key="auth_token" value="test"/></headers><cookies><cookie name="auth_token" value="test" version="1"/></cookies><body><string content-type="application/x-www-form-urlencoded" charset="UTF-8">auth_token=test&job_name=test_job</string></body></request></rest-client>

Process: Create a POST request with body and a header, save it then:

can't drag and drop, because format error,
can't File->Open recent, because format error,
if you exit RESTClient it wont save anything except the URL, so when you reopen RESTClient, only the URL is usable, but you have to redo everything else.
this all would be less annoying, if I would be able to search in the File->Open dialog

Strange, because I am able to all these successfully (including opening the file you sent---via drag and drop, File>Open Request and File>Open Recent). I am running on Mac El Captain, RESTClient running on JVM:
FDLMC799:~ subhash$ java -version
java version "1.8.0_91"

Can you share the OS and JVM version details?

@subwiz Thanks for looking into this!
I'm on OSX Yosemite 10.10.5
#  java -version
java version "1.8.0_72"
Java(TM) SE Runtime Environment (build 1.8.0_72-b15)
Java HotSpot(TM) 64-Bit Server VM (build 25.72-b15, mixed mode)


[Component] Image Gallery

Description
Something similar to https://primevue.org/galleria/...
Additional context

Maybe this is not NuxtUI team's priority right now, in the meantime you can consider using 3rd lib, like vue3-carousel with this gallery example

Also maybe https://nuxt.com/modules/swiper

Also maybe https://nuxt.com/modules/swiper

That's what I'm currently using and it works well for a carousel - but then I ran nuxi analyze and it was massive 😱

Closing this as a duplicate of #550. You should be able to do this now with #927: https://ui.nuxt.com/dev/elements/carousel


Error while running autogenerated TestScripts from US Core

Describe the bug
Undefined error occurs while running US Core TestScripts autogenerated from the generator
To Reproduce

Clone the TestScript generator as it is in github
Run the generator for US core
Clone the TestScript engine as it is in github
Run the engine with TestScript folder pointing to /testscript-generator/testscripts/generated
See error

Screenshots
FINISHED INITIALIZING CLIENT(S).

   STARTING TO EXECUTE RUNNABLE: [AllergyIntolerance-search-type-TestScript]

      STARTING TO PREPROCESS
      FINISHED PREPROCESSING.

      STARTING TO TEST
         OPERATION EXECUTION
            GETTING: http://hapi.fhir.org/baseR4/AllergyIntolerance?_
            (✓) Executed Operation: [unlabeled]
         EVALUATING ASSERTION
            (✓) Response: As expected, Response equals okay. Found okay.
Traceback (most recent call last):
	17: from driver.rb:28:in `<main>'
	16: from /Users/jaehoonlee/Documents/testscript-engine/lib/TestScriptEngine.rb:107:in `execute_runnables'
	15: from /Users/jaehoonlee/Documents/testscript-engine/lib/TestScriptEngine.rb:107:in `each'
	14: from /Users/jaehoonlee/Documents/testscript-engine/lib/TestScriptEngine.rb:108:in `block in execute_runnables'
	13: from /Users/jaehoonlee/Documents/testscript-engine/lib/MessageHandler.rb:63:in `run'
	12: from /Users/jaehoonlee/Documents/testscript-engine/lib/TestScriptRunnable.rb:88:in `run'
	11: from /Users/jaehoonlee/Documents/testscript-engine/lib/MessageHandler.rb:83:in `test'
	10: from /Users/jaehoonlee/Documents/testscript-engine/lib/TestScriptRunnable.rb:109:in `test'
	 9: from /Users/jaehoonlee/Documents/testscript-engine/lib/TestScriptRunnable.rb:109:in `each'
	 8: from /Users/jaehoonlee/Documents/testscript-engine/lib/TestScriptRunnable.rb:109:in `block in test'
	 7: from /Users/jaehoonlee/Documents/testscript-engine/lib/TestScriptRunnable.rb:125:in `handle_actions'
	 6: from /Users/jaehoonlee/Documents/testscript-engine/lib/TestScriptRunnable.rb:125:in `each'
	 5: from /Users/jaehoonlee/Documents/testscript-engine/lib/TestScriptRunnable.rb:130:in `block in handle_actions'
	 4: from /Users/jaehoonlee/Documents/testscript-engine/lib/MessageHandler.rb:106:in `evaluate'
	 3: from /Users/jaehoonlee/Documents/testscript-engine/lib/assertions.rb:59:in `evaluate'
	 2: from /Users/jaehoonlee/Documents/testscript-engine/lib/MessageHandler.rb:112:in `pass'
	 1: from /Users/jaehoonlee/Documents/testscript-engine/lib/TestReportHandler.rb:46:in `pass'
/Users/jaehoonlee/Documents/testscript-engine/lib/TestReportHandler.rb:196:in `pass': undefined method `result=' for nil:NilClass (NoMethodError)

Resolved