Copy to clipboard

This is copy-to-clipboard functionality that was mentioned in #394. The copy copies the last result to the clipboard, formatted according to the user’s config or falling back to Numbat’s default display if no config, and prints that it has done so. In general I try to fall back to Numbat’s own defaults with user configuration where it makes sense. Here is the default config for this:
[copy-output-config.int-config]
grouping = "standard"
separator = ","
minus-sign = "-"

[copy-output-config.float-config]
max-sig-digits = 0
min-sig-digits = 0
max-width = 0
decimal = "."
capitalize-e = false

[copy-output-config.unit-config]
fancy-exponents = false
multiplication-operator = "·"
division-operator = "/"
space-btwn-operators = false

Please bike-shed away on these configuration options — names, default values, anything extraneous or missing...
With the above config (generated by numbat --generate-config), you'd get this kind of output:
>>> copy  # first command in the session
error: no value to copy
>>> 1e12

  1.0e+12

    = 1.0e+12

>>> copy
1,000,000,000,000
>>> 1kg m^2/s^2

  1 kilogram × metre² / second²

    = 1 kg·m²/s²    [Energy or Torque]

>>> copy
1 kg·m^2/s^2
>>>

This works only for the CLI frontend. I need to think about how to enable similar functionality for other frontends, ideally without reimplementing it from scratch — hopefully the only thing to be reimplemented would be the clipboard copying itself. Related to #584

Thank you very much. This does not seem to work for me on Linux (using a standard X server with i3). After typing copy, I get the expected message:
>>> 2+3

  2 + 3

    = 5

>>> copy
5 was copied to the clipboard

but the 5 is nowhere to be found, neither in the "ctrl+v" clipboard (X11: clipboard / secondary), nor in the "middleclick" clipboard (X11: primary).

Hmm, how about now? (I don't have a linux box to test with.) Seems like linux does some weird stuff where dropping the clipboard clears its contents. Also it looks like when numbat-cli exits, the clipboard’s contents will be cleared for the same reason. Is it worth working around this? The arboard docs show how to do this, but it involves spawning a background process to host the clipboard, which seems like a lot of complexity for a small gain.

Oh, so wait literally waits. I'm guessing then that using the non-Linux code for Linux should work, at least as long as numbat is running?

I'm guessing then that using the non-Linux code for Linux should work, at least as long as numbat is running?

You mean the state you had before? (c7b4f89)
No. It doesn't work. Even if numbat is still open.

Also it looks like when numbat-cli exits, the clipboard’s contents will be cleared for the same reason. Is it worth working around this?

I don't think so. A couple of applications have a similar behavior. It's slightly annoying, but I don't think it's a big problem for Numbat.

How about now?

Now it works — thank you!
I will do a full review shortly.
I will already note that I am a bit overwhelmed by the number of configuration options. I'm usually trying to keep the number of options very small, unless it's definitely necessary to add them. I'm not (yet) very strict about being backwards compatible, but once we are, we need to maintain all of those options.

I will already note that I am a bit overwhelmed by the number of configuration options.

That's fair. I naively added (nearly) as much as was supported, with almost no editing. max-sig-digits, min-sig-digits, and max-width can probably all go. The rest I feel are important to keep, though.

max-sig-digits, min-sig-digits, and max-width can probably all go. The rest I feel are important to keep, though.

If it's not too much trouble, it would be great if we could remove them for now. Thank you.

Actually very little trouble! I also renamed copy_output_config ([copy-output-config] in TOML) to copy_result, as the docs refer to the outcome of a calculation as the result, and “config” seemed redundant in that case. (I left int-config, float-config, unit-config as is.)


Update Demo based on evaluation feedback

Demo Feedback from evaluation

For the image-to-image and feature in image-task it would have been nice to let the users upload the images.
It would be nice to let the user upload images in the demo instead of using fixed images.

Demo is at https://huggingface.co/spaces/sujitpal/clip-rsicd-demo (may not be accessible since its in private beta at the moment)

Demo updated with following:

text to image -- added query buttons in addition to text input
image to image -- added thumbnails for canned images, allow providing URL of external image to compare against.
feature finder -- allow external image URL in addition to canned images.
text to image and image to image -- changed output format to include captions.


Fix examples in readme  and code comments

closes #71
Changes to readme and code comments only

@pwoods25443: looks good to me; feel free to merge.


Docker development setup for ign-gazebo3

Here's a proposal to add a Docker setup that would allow for easier development of ign-gazebo3. The idea is to have a Dockerfile that installs all of the ign-gazebo3 dependencies, and to load the source code for ign-gazebo3 into this Docker container as a volume at runtime. Then, users can develop and test their changes inside of Docker without having to worry about configuring source and binary installs on their own machine - users would simply build the source code for ign-gazebo3 inside of the container using something like colcon.
I've added a README, which outlines how to use a source install of ign-gazebo within Docker.
A few things to consider:

In order to get graphics capabilities inside of docker, run.bash configures a few things and then passes this info to the docker run command. Right now, run.bash can only be used if:

You have nvidia-docker2
Your computer has an nvidia graphics card

@iche033 suggested looking into osrf/rocker as a potential solution for allowing this setup to work with various graphics cards (AMD and NVidia). I haven't had the chance to experiment with this yet.

This is just an initial draft/proposal. I'd love to hear anyone's thoughts if they have any - I'm sure there are ways to improve this setup!
Signed-off-by: Ashton Larkin<EMAIL_ADDRESS>

Do you mind adding a README.md file to docker/development with the instructions that you have on the PR?

README has been added, and can be found here.

I also think that requiring the user to run build.sh and run.sh from different directories could be a source of confusion.

build.bash and run.bash are both run from the docker/development directory - or am I misunderstanding what you mean here?

How about calling colcon from within the docker file?

@chapulina I prefer loading the repository into the container as a volume at run time and having users build the repository in the container as they wish instead of cloning the repository and pre-building it in the Dockerfile for a few reasons:

If users want to use different branches of the repository or test changes that were made since image build time, they'll have to re-build the workspace anyways. Also, if the branch of the repository that was cloned in the Dockerfile has been updated since the image was built, the image will need to be re-built or the user will need to pull the recent commits/changes and re-build inside of the container, so building the workspace as a part of the Dockerfile doesn't really help much (if anything, I see it as a limitation).
If users want to clone the repository using SSH, they'd have to set up SSH keys inside of the Dockerfile, which is a bit of a pain.
If users want to make changes to the repository (commits and/or new branches) that was cloned as a part of the image, they'd have to set up their GitHub information inside of the Docker container.
Most importantly, using a volume means that changes made to files in the volume are persistent. This is important because perhaps a user has a copy of the repository on their machine locally, and they want to test their branch - so, they could load their repository into the container, build the workspace, and then test their changes. If they see that something is wrong, they can make changes, test again, and then kill the container when they're happy with their changes. After the container is destroyed, their local copy of the repository will still have the changes they made, which can then be committed and pushed.
Since changes made to files in a volume are synced between the container and the user's own copy, users can go through the development process on their own machine, using whatever development tools/IDEs they already have set up. This way, users don't have to re-configure their development tools inside of Docker - Docker would simply be used for building/testing.

Essentially, volumes allow for greater development and testing flexibility, and remove the need to configure things like Git and development tools inside of Docker.

As a side note, the more I look into this, the more I think it would be more valuable to have a top-level Dockerfile for the entire collection than having one per library. The workflow that is being proposed here makes it easy to build a single library from source, but that's often not the case for developers. And if I understand correctly, from the moment that I need to build a dependency from source, this file is not useful without some extra changes to mount more volumes, right?

@chapulina you're correct about this proposal being easy/targeted for building a single library (in this case, ign-gazebo) from source. If you need source dependencies from other repositories, then it will require one of the following:

Cloning the repositories and checking out the relevant branches inside of the Docker container
Mounting these other repositories as volumes
Using docker cp to temporarily copy dependent repositories into the Docker container

As you have already noticed, doing one of the three things above can be annoying if you need more than just one library from source. So, I am 100% in favor of a top-level Dockerfile that uses the entire collection from source. If we decide to go down the top-level Dockerfile route, there are a few things I think we should discuss first. I've created an issue for this so that we can have a discussion about a top-level Dockerfile approach in the issue, avoiding irrelevant discussion in this PR.
If we decide to use a top-level Dockerfile, is it even worth having Docker setups for each individual library? Perhaps we should close this PR if having library-specific Docker setups is unnecessary.

I'm closing this because I'm working on a different (and simpler) approach that leverages osrf/rocker for increased hardware compatibility. We have a good conversation about what's being done in https://github.com/ignitionrobotics/ign-common/issues/112.


HADOOP-18866. Refactor @Test(expected) with assertThrows

I am working on research that investigates test smell refactoring in which we identify alternative implementations of test cases, study how commonly used these refactorings are, and assess how acceptable they are in practice.
For example, the smell in TestSSLFactory.java occurs when exception handling can alternatively be implemented using assertion rather than annotation: using assertThrows(IllegalStateException.class, () -> {...}); instead of @Test(expected = IllegalStateException.class).
While there are many cases like this, we aim in this pull request to get your feedback on this particular test smell and its refactoring. Thanks in advance for your input.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  4s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
50m 18s

trunk passed

+1 :green_heart:
compile
22m 27s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
20m 57s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 26s

trunk passed

+1 :green_heart:
mvnsite
1m 52s

trunk passed

+1 :green_heart:
javadoc
1m 29s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 53s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 54s

trunk passed

+1 :green_heart:
shadedclient
44m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 44s
/patch-mvninstall-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
compile
1m 11s
/patch-compile-root-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.

-1 :x:
javac
1m 11s
/patch-compile-root-jdkUbuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04.

-1 :x:
compile
1m  2s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
javac
1m  2s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 30s
/buildtool-patch-checkstyle-hadoop-common-project_hadoop-common.txt
The patch fails to run checkstyle in hadoop-common

-1 :x:
mvnsite
0m 51s
/patch-mvnsite-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 34s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

-1 :x:
spotbugs
0m 54s
/patch-spotbugs-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

-1 :x:
shadedclient
8m 30s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 54s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch failed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

161m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5982

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux cd044a0302bd 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / bd7dd286f301e6d5cc6cce6c4807de537d0751c6

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/1/testReport/

Max. process+thread count
589 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  0s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
53m 24s

trunk passed

+1 :green_heart:
compile
21m 31s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
20m  8s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 28s

trunk passed

+1 :green_heart:
mvnsite
1m 51s

trunk passed

+1 :green_heart:
javadoc
1m 18s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 50s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
3m  0s

trunk passed

+1 :green_heart:
shadedclient
43m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  0s

the patch passed

+1 :green_heart:
compile
18m 28s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
18m 28s

the patch passed

+1 :green_heart:
compile
17m 38s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
17m 38s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m 11s

the patch passed

+1 :green_heart:
mvnsite
1m 40s

the patch passed

+1 :green_heart:
javadoc
1m  8s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 49s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 52s

the patch passed

+1 :green_heart:
shadedclient
40m 50s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 24s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

256m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5982

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 55f0313cd4b8 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / fc687baaaff4fd18a916a0897b8fb47ca045b901

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/2/testReport/

Max. process+thread count
2137 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
43m  9s

trunk passed

+1 :green_heart:
compile
17m 34s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
16m 20s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 25s

trunk passed

+1 :green_heart:
mvnsite
1m 42s

trunk passed

+1 :green_heart:
javadoc
1m 18s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m  0s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 40s

trunk passed

+1 :green_heart:
shadedclient
35m 39s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 57s

the patch passed

+1 :green_heart:
compile
16m 20s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
16m 20s

the patch passed

+1 :green_heart:
compile
16m 25s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 25s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 22s

the patch passed

+1 :green_heart:
mvnsite
1m 44s

the patch passed

+1 :green_heart:
javadoc
1m 19s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 46s

the patch passed

+1 :green_heart:
shadedclient
36m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m  7s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

223m 50s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5982

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 29d7b96b9fb8 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e44bb89d07886b634c13e5760620c8eaf16e9c68

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/4/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 58s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 34s

trunk passed

+1 :green_heart:
compile
19m 24s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
17m 34s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 44s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 49s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 46s

trunk passed

+1 :green_heart:
shadedclient
40m 52s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  1s

the patch passed

+1 :green_heart:
compile
18m 50s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
18m 50s

the patch passed

+1 :green_heart:
compile
16m 58s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
javac
16m 58s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 12s

the patch passed

+1 :green_heart:
mvnsite
1m 38s

the patch passed

+1 :green_heart:
javadoc
1m  9s

the patch passed with JDK Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
2m 47s

the patch passed

+1 :green_heart:
shadedclient
42m 44s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
20m 11s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 11s

The patch does not generate ASF License warnings.

246m 26s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/5982

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 432f591550a5 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e44bb89d07886b634c13e5760620c8eaf16e9c68

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.20+8-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/3/testReport/

Max. process+thread count
1375 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5982/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

afraid you need to create a jira at issues.apache.org for this, if you need to create an account say you have a pending github pr
We use our LambdaTestUtils.intercept() here as it is better. really. in particular, if nothing was thrown, the assertion raised includes the toString() value of whatever was returned from the lambda-expression; really helps interpreting test failures.

you might want to look at LambdaTestUtils, compare it to ScalaTest and see how it is being extended to handle futures and the like. outside that, we are moving towards AssertJ as our assertion language because it is better and extensible (see IOStatisticAssertions)

Thanks @steveloughran for your response. I get your point, but I would like to get your input on the refactorings performed in this PR, and how such a practice is acceptable in general. In your opinion, why are those test cases still using @Test(expected) instead of the better alternative using assertThrows?
I have created a Jira report and prefixed its id to the PR title. Thanks.

i do think test age is an issue, and old code is suboptimal, but using test(expected) over our own intercept() or even assertThrows isn't something we'd do today.
now, serious question for you: if a test is working, why does it need it maintenance?
because there are other uses of engineering time, including

new features
bug fixes in production
writing new tests
reviewing patches by others

so, how would you justify the change, as "it's considered old fashioned" doesn't do it.
if anyone was to go near old tests, i'd target things i really don't like

assertTrue/assertFalse without error messages or detail why the test failed. Fix: use assertJ assertions with .describedAs(), or at least add messages
assertEquals with the arguments reversed. fix, swap, or better: assertj.
code which uses try/catch/fail rather than intercept(). sadly too common

moving #3 onto intercept() would be better than worrying about "expected"; while #1 is critical for debugging a test report "testXYZ failed on Line 222". It's why I automatically veto any PR where new tests don't add details. Still disappointed that people still submit PRs where they don't do that. very bad style. we need a stylechecker rule for it, at least for new code,

Thanks @steveloughran for your detailed response. I got your points and gained various insights.

ok. now, one thing to consider there is: what stylecheckers etc can we use to stop new prs coming in which don't do all of this, or lose stack traces when validating caught exceptions? As all to often, the work of getting a PR in is the time spent teaching people how to write tests that meet my expectations (for me) and the time spent waiting for review, making the changes and repeating (for them). see #6003 as an example. if we have the CI tooling automatically imposing policies on tests, then everyone's time is better used.
now, we do run checkstyle on all PRs, so if you have suggestions about how to do it there, or other maven plugins (better yet, prs with tests) then I'd be very happy.
put differently: lets automate enforcing test quality on new submissions before worrying about old tests which appear to work ok

Right, I agree. That is the ultimate goal of our research, to automatically improve test quality from various perspectives. Thanks @steveloughran.


Improving internals to support different credential types for users when onboarding

The identity server supports multiple login options for service providers. Users can log in with different credential options configured for their locally managed account (ex: password, magic link, fido) in IS or login with existing identities (ex: social login) trusted by the service provider. However, when it comes to user onboarding, the registration options for a user are only a subset of the login options. Especially, when creating an account in the tenant, users only have the opportunity to proceed with a password as the credential.
We need to improve the internals of the product to support identifying what authentication options are supported for user onboarding and what attributes are required from these authentication options.

Overview of the provided solution
A new component(Auth Attribute Handler Manager) and an interface(Auth Attribute Handler) was introduced. They will be used to create new components that will contain authentication-related attributes which will allow user onboarding flows to determine what attributes should be requested from the user to support an authentication mechanism.
The following is a high-level view of the components

The following sequence diagram shows how the auth attribute handler manager interacts with other components


Non-OK-status: tensorflow::Env::Default()->DeleteFile(ptx_path) status: Not found:

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
NO
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Centos7.7
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):
pip install officail
TensorFlow version (use command below):
1.15.2 with gpu
Python version:
3.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
10.0/ 7.6
GPU model and memory:
v100 32G

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
Can't find ptxas binary in ${CUDA_DIR}/bin.  Will back to the GPU driver for PTX -> sass compilation.  This is OK so long as you don't see a warning below about an out-of-date driver version.
2020-04-07 16:28:20.691087: W tensorflow/compiler/xla/service/gpu/nvptx_compiler.cc:70] Searched for CUDA in the following directories:
2020-04-07 16:28:20.691210: W tensorflow/compiler/xla/service/gpu/nvptx_compiler.cc:73]   ./cuda_sdk_lib
2020-04-07 16:28:20.691315: W tensorflow/compiler/xla/service/gpu/nvptx_compiler.cc:73]   /usr/local/cuda
2020-04-07 16:28:20.691454: W tensorflow/compiler/xla/service/gpu/nvptx_compiler.cc:73]   .
2020-04-07 16:28:20.691571: W tensorflow/compiler/xla/service/gpu/nvptx_compiler.cc:75] You can choose the search directory by setting xla_gpu_cuda_data_dir in HloModule's DebugOptions.  For most apps, setting the environment variable XLA_FLAGS=--xla_gpu_cuda_data_dir=/path/to/cuda will work.
2020-04-07 16:28:20.725596: F tensorflow/stream_executor/cuda/ptxas_utils.cc:181] Non-OK-status: tensorflow::Env::Default()->DeleteFile(ptx_path) status: Not found: /tmp/tempfile-72d9c7c8-2841-4447-bd7d-3947098f8e24-6a7fc700-2624-5a2af2a888f80; No such file or directory
Fatal Python error: Aborted
Describe the expected behavior

the code in follows log the mislead warning?
https://github.com/tensorflow/tensorflow/blob/4386a6640c9fb65503750c37714971031f3dc1fd/tensorflow/compiler/xla/service/gpu/nvptx_compiler.cc#L405

       bool log_warning = true;
          if (maybe_cubin.status().code() ==
              tensorflow::error::Code::NOT_FOUND) {
            // Missing ptxas is expected in some environments where CUDA SDK
            // binaries are not available. We don't want to spam logs with
            // identical warnings in this case.

            // TODO(jlebar): we should implement a LOG_FIRST_N and LOG_EVERY_N
            // for more general usage.
            static std::atomic<bool> warning_done(false);
            log_warning = !warning_done.exchange(true);
          }
          if (log_warning) {
            PrintCantFindCudaMessage(

if some exception that the ptx_path did not create, there will rasie a error that : 2020-04-07 16:28:20.725596: F tensorflow/stream_executor/cuda/ptxas_utils.cc:181] Non-OK-status: tensorflow::Env::Default()->DeleteFile(ptx_path) status: Not found:

https://github.com/tensorflow/tensorflow/blob/4386a6640c9fb65503750c37714971031f3dc1fd/tensorflow/stream_executor/cuda/ptxas_utils.cc#L184

  // Write ptx into a temporary file.
  string ptx_path;
  if (!env->LocalTempFilename(&ptx_path)) {
    return port::InternalError("couldn't get temp PTX file name");
  }
  auto ptx_cleaner = tensorflow::gtl::MakeCleanup([&ptx_path] {
    TF_CHECK_OK(tensorflow::Env::Default()->DeleteFile(ptx_path));
  });

  TF_RETURN_IF_ERROR(
      tensorflow::WriteStringToFile(env, ptx_path, ptx_contents));
  VLOG(2) << "ptx written to: " << ptx_path;

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

@ymodak  could you look at this problem?

Does this reproduce on tensorflow-nightly?

Does this reproduce on tensorflow-nightly?

i didnot try , because we are using tf v1.15

Most likely it has been solved in nightly. If it has, we can attempt a backport when doing a patch release on 1.15.
In the end, we are doing development only on master branch and the releases are snapshots of the code at that time, with some cherry-picks. So you will have to move to newer versions at one point

Has it been solved? I have a same problem using TF2.0.0. Please tell me the solution, thank you !

@GuoYL36 can you try reproducer with tf-nightly?

@GuoYL36 can you try reproducer with tf-nightly?

No, I did not try. Now I can run code normally without doing anything, and I just want to say it is amazing.<^_^>

@GuoYL36 can you try reproducer with tf-nightly?

This bug is solved now, which caused by GPU which is in non-ok status. I found no gpu is used to run code, but gpu-memory is used.

So it seems it has been solved. I think we can close the issue and reopen if there is a resurgence


Updated event that triggers test PR Workflow

Current dependencies on/for this PR:

main

PR #1170   👈

This comment was auto-generated by Graphite.


How is this library different from EntityX, what are the use cases where it is preferable?

I'm looking for a Component-Entity-System library, and I found these two. The faq lists EntityX as an inspiration. I find the two very similar in goals and implementation as well. Is there a killer advantage to choose either?

"Here are some major differences:"
You may want to rephrase that as it's not clear whether this list is about features that are in entityX but not in anax or vice versa, especially since some items in the list are "pros" and others are "cons".
PS: I intend to benchmark anax, entityx and artemiscpp next week as I need an ECS in TilemapKit. I'll post an update with a link to the blog post when I'm done. I'm curious to see how the libraries compare.

did you finally created those benchmarks?

I did a test. Created 100,000 entities (SFML) .FPS the same, but the difference in memory usage.Anax uses more memory.


fix(columns-block): remove max-width rule and fix inconsistent paddings

Fixes https://github.com/adobe/express-website-issues/issues/298

Bonus: this also fixes the 1st issue mentioned in https://github.com/adobe/express-website-issues/issues/299 🤗

@So1ene Alignment generally looks a lot better on the top SEO pages, but I noticed a regression on the education homepage (.columns.highlight):

Good catch!

The new commits aren't being shown in this pull request, I made a new one here: https://github.com/Webistry-Development/express-website/pull/6


model / fields circular references

I'm submitting a ...  (check one with "x")
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request

Current behavior
In testing the changes to address #344 (see #345) the fixes to the repeatSection's manipulation of the FormArray work as expected against beta 14.  With the latest build of formly, neither the old nor the fixed repeatSection implementations work correctly.  I expect this is a symptom of some other problem with the latest build.
pre-fixed repeatSection with latest build
fixed repeatSection with latest build
Expected behavior
fixed repeatSection with beta 14

Whats not working, it feels to me that it works, may be I didn't understand it

In the plunkers with the latest build, if you can look at the model when trying to use the repeatSection you should be able to see the problem.
I've commented out the model and fields JSON piped to the view because the JSON pipe will throw errors due to JSON.stringify not liking circular references.
I believe these are just a symptom of the problem.  I didn't quite know what to attribute or identify this issue as.

May be #343 and #345 going together caused this issue.

Doesn't appear that it could have been #345 because the repeatSection prior to that fix has the same problem with the latest build:
https://plnkr.co/edit/VIJtfp4eRSjZFPtE1ZlE?p=preview

fixed by #347:
https://plnkr.co/edit/VNh8ccoyUJ6GSz7d0jKH?p=preview


Let end user to tag applications based on user preference

The following APIs should be made available to allow a user to manage their applications in the user-portal.

[ ] Make an API available for managing favourite applications in the user-portal
[ ] Make an API available for managing application tags

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Proposal: Split the all-packages.nix file

The all-packages.nix file is currently 15.1k lines long. This is too mach IMHO.
As far as I can tell, there are several sections, one for the environment, one for normal packages, one for libraries.
I think it would be a good idea to split this enormous file. While doing this, one could also sort the packages, as they are not entirely sorted as far as I can tell.
Any objections? Maybe I can try to do this in the next few days.

I think there was already a branch attempting mostly eliminate the big list via readDir and friends. I'd love it if it worked. Main thing to watch out for is being as lazy as possible so you don't accidentally traverse the entire filesystem with every evaluation, and providing a sensible overrides mechanism when you don't just want to pass in the default values in the callPackage scope.
I feel a bit more torn about just splitting it into smaller files, since I then no longer have an easy place to search for everything, and still have to manually maintain a big list o' stuff.

@copumpkin I'd simply split them files and not try to invent something. Searching would still be possible via grep -r or ack or ag.

Recently we had a long discussion about the manual(s) – whether they should be single-page or split. And that was just about readability of the result. There are subsets already not in that single file (haskell, python, etc.), but it still simplifies some things. Another problem is that the categories are rather ad-hoc, and recently we had a serious proposal to abandon them and just sort the whole file alphabetically. (Note that e.g. large fraction of packages contain some library used by another package.)
BTW, that Eelco's attempt wasn't much about splitting, IIRC, but mainly about getting rid of most of the lines completely. If we just split it up, we would need to read all the parts always, but that would be about the same speed as now, as long as it's only several files.
I don't yet see a solution that would be decisively and significantly better than what we have now.

@vcunat do you have a link to Eelco's attempt and some explanation (for posterity) of what was wrong with it?

No, sadly, I can't find it ATM and I'm not even sure why it wasn't used in the end.

Here, I found some ML reference http://comments.gmane.org/gmane.linux.distributions.nixos/16928 to ece61b7cc.

@vcunat I like the approach the commit introduces, actually.

Closing due to no progress anymore.

That commit was reverted shortly after: e7295597d8ddeeae344bb892490331f2476805ef
What was the reason for that?

That commit was reverted shortly after: e7295597d8ddeeae344bb892490331f2476805ef
What was the reason for that?

I guess you should ask the committer, @edolstra

I guess you should ask the committer, @edolstra

It created an ugly asymmetry between packages with and without overrides. So to override a package you had to override both auto-packages.nix and all-packages.nix.

It created an ugly asymmetry between packages with and without overrides. So to override a package you had to override both auto-packages.nix and all-packages.nix.


Distinguish AliTV from other software packages

We need to distinguish AliTV from other software packages dealing with the some problem (eg. Easyfig, Mauve, BRIG, etc.)

Sybil
http://www.ncbi.nlm.nih.gov/pubmed/22121156

And maybe to GenoplotR. The linear output looks quite similar. Indeed, AliTV has a totally different structure/model. ;-)


Improvement in Jenkins

Dockerfile: Change HOME dir to /opt/librenms.
Jenkinsfile: Add Jenkins CI.
scripts/*: Add scripts to publish the CI statuses

Refer to this link for build results (access rights to CI server needed):
https://jenkins.mahyuddin.web.id/job/udienz/job/docker-librenms/43/

Refer to this link for build results (access rights to CI server needed):
https://jenkins.mahyuddin.web.id/job/udienz/job/docker-librenms/44/


request_clause headers need default value

I'm getting lib/pacto/stubs/webmock_adapter.rb:95:in block in strict_details': undefined method empty?' for nil:NilClass (NoMethodError) when I try to stub_providers with pacto. I tracked it down to the request_clause.headers being nil.
Test code:
contracts = Pacto.load_contracts('spec/fixtures', 'http://localhost:3000', :swagger)
contracts.stub_providers

Here you can see that headers in request_clause has no default value. But in the response clause, headers defaults to {}. I think it should in request_clause as well.

It makes sense, except that I would like to get away from RequestClause having attributes at all, so that it just an interface that should be implemented by subclasses for specific contract formats (Swagger, RAML, whatever).
I guess I need to find time to make RequestClause abstract and create a subclass for LegacyRequestClause.

That sounds like a good direction to move. :thumbsup:


Add support for getting interfaces in OnReadyGet

It would be useful if we could use OnReadyGet to initialize an interface field with a reference node. Game engines like Unity include this feature in their GetComponent()`` function.

Interesting... yeah, it would make sense to allow this, and it's a pretty simple change. GetNode<T> already allows this, I only need to tweak the generator to allow it rather than emit a compile error. I'll do it.

A potential issue is that [OnReadyGet] handles both nodes and resources, and currently it uses the type to determine which one it needs to fetch. The code behind the scenes is very different to handle each one. (GetNode vs. GD.Load, [Export] NodePath vs. [Export] <resourcetype>, and more fiddly internals.)
For example, it's impossible to tell whether IDoThings is attached to a resource or a node type:
public interface IDoThings { }
public class MyNode : Sprite, IDoThings { }
public class MyResource : Resource, IDoThings { }

public partial class Finder : Node {
  [OnReadyGet] private IDoThings _doer;
}

That said... I think it's safe for [OnReadyGet] to assume that an interface means it's a node. This is already a fairly niche scenario, but I think it would be way more niche to get a resource via an interface type. With how poorly (IMO) custom resource types work in Godot Mono right now, I think it's unlikely anyone will run into this limitation.
If someone does run into the limitation caused by the assumption, there are ways out. The easiest would be to add a bool arg onto the attribute that indicates the target should be a resource.
So, I think it's fine to relax this requirement and make this assumption.

I've released 1.1.3 that includes this change, let me know if it doesn't end up working for you! Thanks for the suggestion.


Would it be helpful adding first quantization methods to resource estimates?

I've seen that OpenFermion now includes some cost estimates: https://github.com/quantumlib/OpenFermion/tree/master/src/openfermion/resource_estimates
They are from the most up-to-date rank-factorization methods, but I could help with the first-quantization methods. Would this be useful for the library maintainers?
I already have coded a version of the qubitization technique, and could probably "easily" do the equivalent one for the interaction picture method. I was thinking of having this in my own library TFermion, but it may be more useful for the community to have it directly here now that we have started with the Sparsification and Rank Factorization techniques.
If we want to add this up, a follow-up question is: do we want to include the cost of preparing the initial state, since in this case it would not be a computational basis state?

I think that would be helpful. I assume you are referring to the estimates from (https://journals.aps.org/prxquantum/abstract/10.1103/PRXQuantum.2.040332)?
I don't think the initial state preparation is going to be so important since one can anti-symmeterize the initial states with very significantly less complexity than the cost of phase estimation, so it is essentially a negligible additive factor. This is possible using the techniques from https://www.nature.com/articles/s41534-018-0071-5

Yes, I am referring to that 🙂.
Ok, give me a couple of weeks (as I am a bit busy right now) and I'll get it done.

These costs are incorporated in qualtran


Missing OSGI Import-Package

Summary
Import-Package are missing in OSGI.
 <Import-Package>!org.assertj.core.*</Import-Package>

should probably be changed to :
  <Import-Package>!org.assertj.core.*, *</Import-Package>

in the pom.xml (maven-bundle-plugin)
Example
Several Assertions cannot be used, for example:
 assertThat("<test>testValue</test>").isXmlEqualTo("<test>testValue</test>");

throw
java.lang.ClassNotFoundException: org.w3c.dom.Node cannot be found by org.assertj.core_3.10.0

in an OSGI environment

Thanks for reporting this !

@Glirox I have pushed the commit with your fix suggestion, can you give it a try and see it correctly addresses the issue ? (jut build assertj-core with mvn install and use 3.11.0-SNAPSHOT in your dependency).

It works ! Thx


ESLPopup, ESLShare: docs updating

:tada: This PR is included in version 5.0.0-beta.10 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Promise shim missing finally method

I am using es6-shim on some old Android device and I am experiencing errors when trying to call Promise.finally:

Object # has no method 'finally'

The following code outputs catch,then,constructor on my old Android device and outputs catch,then,finally,constructor on a modern PC browser.
let promise = ...;
alert(Object.getOwnPropertyNames(Object.getPrototypeOf(promise)).join(','));

It seems that Promise.finally has not been implemented yet?

It's not missing - the method isn't in ES6, it was added in ES2018.
Use https://www.npmjs.com/package/promise.prototype.finally to shim it, on top of the es6-shim.


Wish: Support ensemble for paired analyses

This is an approach that has been used in a few recent papers, and I think would be a worthwhile addition to the pipeline. There are some points to make:

[ ] Ensure there are n > 1 methods available (depends on #65, #66 )
[ ] Check whether bcbio-variation can work with these OOTB
[ ] See if the pipeline can handle filtering for these: Somatic Sniper has a SS (somatic score), I need to check for VarScan, and MuTect has REJECT/PASS in the VCF FILTER field.

Would this make sense ti implement?

Hi
I am closing this because it seems an old issue. Come back if you find other issues  or want to continue with this one.
cheers


Make fact++ reasoner available and default in tools

I am not sure if this is already implemented and needs only to be updated documentation.

Yes, this is already implemented. I suggest we close this one. We can make a new issue for the documentation.


Dealt cards may get the ZoomedOnHover component without getting zoomed

If the mouse cursor is still in the hand area and a card is dealt under it, its final size at the end of the animation is not zoomed, but the card is then unzoomed when moving the cursor, resulting in a shrunken card.

I realized the cards do get zoomed, but during an animation, the scale is immediately overwritten again. The solution should be to only handle hover events when no animation is active. That can be elegantly done using bevy app states, which also slightly improves other code parts and opens a path towards indicating whose turn it is.


loss_barlow_twins: add get_eccm member function

This allows us to greatly simplify the self supervised learning example:

the computation in user code was a bit too distracting
avoids duplicated computation/allocation of this matrix
avoids edge case where net outputs are zero due to trainer synchronization

Yeah, nice :D


[BUG] azure AOAI hang to the final state

not only AOAI but also for ollama

Hi @hellangleZ Is there any bug or log?
Plus, what environment are you using?

@hellangleZ  hi guys could u share ur config.yaml and demo.py？
thanks!


Add type hints to python-package/lightgbm/plotting.py

#3756 Added type hinting on python-package/lightgbm/plotting.py

@WestonKing-Leatham do you need some help updating this PR? I noticed you deleted test_plotting.py, which I don't think you intended to do.
I'd be happy to share some git commands for you to run if you need assistance.

Sorry I am pretty new to github and open source contribution. I had forgotten to pull from master before I pushed and started the second pull request. I was confused when the previous print formatting branch was also added to my push and was unsure of how to undo this. Also I wasn't sure how to go about testing my code locally. Any help would be welcome, thank you for taking the time to assist me.

Sorry I am pretty new to github and open source contribution. I had forgotten to pull from master before I pushed and started the second pull request. I was confused when the previous print formatting branch was also added to my push and was unsure of how to undo this.

No problem. I just updated this branch for you, taking advantage of the fact that GitHub allows maintainers to push to branches on other users' forks if those branches are part of an open pull request.
I ran the following commands to do this.
git clone --recursive git@github.com:WestonKing-Leatham/LightGBM.git weston-lgb
cd weston-lgb

# get feature branch
git fetch type-hinting
git checkout type-hinting

# revert the commit that removed test_plotting.py
git revert df095b61

# update to latest `master`
git remote add upstream https://github.com/microsoft/LightGBM.git
git checkout master
git pull upstream master
git checkout type-hinting
git merge master

# push updated feature branch, to update the PR
git push origin type-hinting

Now that I've done that, you should run the following commands locally in your copy of LightGBM, to update your local branch to the current state on the remote.
git checkout master
git branch -D type-hinting
git fetch origin type-hinting
git pull origin type-hinting

You could use the following resources to get more familiar with git and with contributing to projects on GitHub:

this short talk I've given on how to contribute to projects on GitHub: https://github.com/jameslamb/talks/tree/main/you-can-do-open-source
this excellent git tutorial: https://gitimmersion.com/

Also I wasn't sure how to go about testing my code locally.

Apologies, we could do a better job of documenting how to test changes to particular parts of this project. Since you were working only on the Python package here, you could run the following locally to test.
# install the package from source
cd python-package
python setup.py install

# run the unit tests
cd ../tests/python_package_test
pytest .

# lint the package code
pycodestyle --ignore=E501,W503 python-package/lightgbm

For more details on other checks run automatically in this PR, see the code in https://github.com/microsoft/LightGBM/blob/53ffba7c5c4a4d64853ad6c5409735b986283d2d/.ci/test.sh.

Any help would be welcome,

I realized that one of my suggestions in https://github.com/microsoft/LightGBM/pull/4367#discussion_r649260021 accidentally omitted the default value for a parameter. In addition to updating this branch to master, I pushed commit https://github.com/microsoft/LightGBM/pull/4367/commits/082b603cba03ba3ca3c2f106b880ef3173ecee1f which fixes that issue and should fix most of the linting problems.

@StrikerRUS I accepted and committed your suggestions. They're non-controversial and it has been 10 days since they were requested, so I felt like it was ok to use my commit access as a maintainer to accept those suggestions and hopefully move this PR forward.


E-scooter model in CARLA

Currently there are no E-scooter model availabel in CARLA. It would be great to get E-scooter vehicle model as the no of E-scooter users has increased.
-label:feature request.

Noted!

Hi @kanakab,
Thanks for the comment I'll keep that in mind !!

What is needed to get a scooter model into CARLA?

@XGodina Hi team, any updates on the scooter model?


An issue with addParticipants method

Description
If the user has forbidden adding himself to the groups, then the method returns a private invitation code, after clicking on which (after creating a link with it) a message is displayed stating that this group does not exist.
Environment

WhatsApp version: 2.2327.4
WA-JS version(s): 2.24.5
Browser: Chrome 114.0.5735.199
OS: Windows 10
MultiDevice (BETA): yes

If the number you are trying to add is not in your contacts it returns and error

If the number you are trying to add is not in your contacts it returns and error

what error did you get?

hello,
to add a member to the group you need to have the contact saved in your device.
The goal now only accepts a new member to be added with the saved number.


Typo on imgcap height - description says width

https://github.com/Dronecode/camera-streaming-daemon/blob/master/samples/config/config.sample#L86
#   height
#       Height of the image to be captured in pixels.
#       Default: Full WIDTH of camera frame for sensor type (i.e 1080P - 1080, 720P - 720, etc)

Closing. Will be fixed by https://github.com/Dronecode/camera-streaming-daemon/pull/167


Scheduled tasks in Helidon

Environment Details

Helidon Version: 1.4.x
Helidon MP
JDK version: 11
OS: Win10

Problem Description
I need to repeat some tasks on a fixed time interval (say check the DB every 10 minutes): is there any helidon specific API I can use? If not what is the suggested way to handle this?

Hi we don't have direct MP support, but we have convenient tooling usable in both SE and MP flavors of Helidon - ScheduledThreadPoolSupplier.
To make it little prettier with reactive api(works in both flavors of Helidon 2.x):
ScheduledThreadPoolSupplier scheduledThreadPoolSupplier =
                ScheduledThreadPoolSupplier.builder()
                        .threadNamePrefix("scheduled-test-")
                        .corePoolSize(2)
                        .build();

Multi.interval(5, TimeUnit.SECONDS, scheduledThreadPoolSupplier.get())
                .map(l -> "invocation number " + l)
                // max number of invocations
                .limit(5)
                .forEach(s -> System.out.println("Scheduled " + s))
                .await();

scheduledThreadPoolSupplier.get().shutdown();

> Scheduled invocation number 0
> Scheduled invocation number 1
> Scheduled invocation number 2
> Scheduled invocation number 3
> Scheduled invocation number 4

But be aware! This job would be scheduled on every instance of your service, I would suggest to check out Kubernetes CronJobs first https://kubernetes.io/docs/concepts/workloads/controllers/cron-jobs/

POC prepared in #2301


Scale for rays_o

https://github.com/hjxwhy/Block-NeRF/blob/bc16e5cc95ca534b451d4125770bd682569b6776/datasets/memory_dataset.py#L130
Could you please explain why we should scale rays_o by a factor of 100 for waymo dataset?

here I think the original positions were scale 100, I just try to recover the scale, but it was just a try, no why!


The following stack trace indicates that this is probably being caused by TempDatabase::build() which sets a shutdown handler to kill the temporary database:
// Ensure test db is killed on exit
register_shutdown_function(function () {
    $this->kill();
});

Stack trace:
Generating code coverage report in Clover XML format ... done
PHP Fatal error:  Uncaught PDO::query(): MySQL server has gone away
/home/travis/build/lekoala/silverstripe-debugbar/framework/src/ORM/Connect/PDOConnector.php:260
/home/travis/build/lekoala/silverstripe-debugbar/framework/src/ORM/Connect/Database.php:142
/home/travis/build/lekoala/silverstripe-debugbar/framework/src/ORM/Connect/Database.php:222
/home/travis/build/lekoala/silverstripe-debugbar/framework/src/ORM/Connect/Database.php:143
/home/travis/build/lekoala/silverstripe-debugbar/framework/src/ORM/Connect/DBSchemaManager.php:104
/home/travis/build/lekoala/silverstripe-debugbar/framework/src/ORM/Connect/MySQLSchemaManager.php:211
/home/travis/build/lekoala/silverstripe-debugbar/framework/src/ORM/Connect/Database.php:763
/home/travis/build/lekoala/silverstripe-debugbar/framework/src/ORM/Connect/TempDatabase.php:82
/home/travis/build/lekoala/silverstripe-debugbar/framework/src/ORM/Connect/TempDatabase.php:150 <------------

I assume that the wait time is too great and MySQL disconnects before the temp DB can be killed.
There are some configuration options for mysqli and methods like mysqli_ping, but not for PDO.

Interestingly this is the same [code] in 3.x


Flush loggers on cleanup, don't destroy (back-port for Dropwizard 1.1.0)

(cherry picked from commit 6c76c27c0cf637073dc7a72ae63a97dc5ff9b78f)
Refs #1947

Coverage decreased (-0.1%) to 84.7% when pulling e9cf9ff1622f69c3f1ea1abf9a4001874b01d128 on backport-pr-1947 into f2a6784c8f778402a335a89372c97ec7e1bbc532 on release/1.1.x.

I'm fine with having this in 1.1.0, but we'll need another RC (just it in case it wasn't planned) to ensure that this doesn't break an edge case 😄

I can cut a RC today.

@arteam, not sure if this is normal, but it's been 6 hours since you tagged rc2 and and rc2 isn't out on maven central

My fault, I haven't promoted the release candidate, other things popped up during the day. Doing that right now.

Should be released now in the central repository, but it takes some time for a release to sync on all replicas.


dart migrate bug

When I wanted to migrate to null-safety an error occurred and it said to fill the report here, so this is what I am doing. I than proceeded to use the command dart migrate --ignore-exceptions to bypass this error.
x@1014-ubuntu-x:~/flutter/x$ dart migrate
`Migrating /home/x/flutter/x
See https://dart.dev/go/null-safety-migration for a migration guide.
Analyzing project...
[-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------/]No analysis issues found.
Generating migration suggestions...
[------------------------------------------------------------------------------------------------------                                                                                ]Aborting migration due to an exception.  This most likely is due to a
bug in the migration tool.  Please consider filing a bug report at:
https://github.com/dart-lang/sdk/issues/new
Please include the SDK version (2.18.4) in your bug report.
To attempt to perform migration anyway, you may re-run with
--ignore-exceptions.
Exception details:
Null check operator used on a null value at offset 1492 in /home/x/flutter/x/lib/src/blocs/language_bloc/language_bloc.dart (SharedPreferencesService?.instance)
#0      EdgeBuilder._handlePropertyAccessGeneralized (package:nnbd_migration/src/edge_builder.dart:3186:46)
#1      EdgeBuilder._handlePropertyAccess (package:nnbd_migration/src/edge_builder.dart:3124:12)
#2      EdgeBuilder.visitPropertyAccess (package:nnbd_migration/src/edge_builder.dart:1649:12)
#3      PropertyAccessImpl.accept (package:analyzer/src/dart/ast/ast.dart:9230:50)
#4      EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2341:24)
#5      EdgeBuilder.visitAwaitExpression (package:nnbd_migration/src/edge_builder.dart:503:26)
#6      AwaitExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:981:50)
#7      EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2341:24)
#8      EdgeBuilder._handleAssignment (package:nnbd_migration/src/edge_builder.dart:2470:20)
#9      EdgeBuilder.visitVariableDeclarationList (package:nnbd_migration/src/edge_builder.dart:2040:11)
#10     VariableDeclarationListImpl.accept (package:analyzer/src/dart/ast/ast.dart:11673:15)
#11     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2341:24)
#12     EdgeBuilder.visitNode (package:nnbd_migration/src/edge_builder.dart:1537:9)
#13     GeneralizingAstVisitor.visitStatement (package:analyzer/dart/ast/visitor.dart:560:40)
#14     GeneralizingAstVisitor.visitVariableDeclarationStatement (package:analyzer/dart/ast/visitor.dart:636:7)
#15     VariableDeclarationStatementImpl.accept (package:analyzer/src/dart/ast/ast.dart:11722:15)
#16     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2341:24)
#17     EdgeBuilder.visitNode (package:nnbd_migration/src/edge_builder.dart:1537:9)
#18     GeneralizingAstVisitor.visitStatement (package:analyzer/dart/ast/visitor.dart:560:40)
#19     GeneralizingAstVisitor.visitBlock (package:analyzer/dart/ast/visitor.dart:167:32)
#20     BlockImpl.accept (package:analyzer/src/dart/ast/ast.dart:1183:50)
#21     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2341:24)
#22     EdgeBuilder.visitNode (package:nnbd_migration/src/edge_builder.dart:1537:9)
#23     GeneralizingAstVisitor.visitFunctionBody (package:analyzer/dart/ast/visitor.dart:338:46)
#24     GeneralizingAstVisitor.visitBlockFunctionBody (package:analyzer/dart/ast/visitor.dart:170:56)
#25     BlockFunctionBodyImpl.accept (package:analyzer/src/dart/ast/ast.dart:1134:50)
#26     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2341:24)
#27     EdgeBuilder.visitFunctionExpression. (package:nnbd_migration/src/edge_builder.dart:1035:25)
#28     ScopedSet.doScoped (package:nnbd_migration/src/utilities/scoped_set.dart:48:13)
#29     EdgeBuilder.visitFunctionExpression (package:nnbd_migration/src/edge_builder.dart:1033:28)
#30     FunctionExpressionImpl.accept (package:analyzer/src/dart/ast/ast.dart:5440:50)
#31     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2341:24)
#32     EdgeBuilder.visitFunctionDeclaration (package:nnbd_migration/src/edge_builder.dart:982:9)
#33     FunctionDeclarationImpl.accept (package:analyzer/src/dart/ast/ast.dart:5312:50)
#34     EdgeBuilder._dispatch (package:nnbd_migration/src/edge_builder.dart:2341:24)
#35     EdgeBuilder.visitNode (package:nnbd_migration/src/edge_builder.dart:1537:9)
#36     GeneralizingAstVisitor.visitCompilationUnit (package:analyzer/dart/ast/visitor.dart:204:52)
#37     CompletenessTracker.visitCompilationUnit. (package:nnbd_migration/src/utilities/completeness_tracker.dart:52:24)
#38     PermissiveModeVisitor.reportExceptionsIfPermissive (package:nnbd_migration/src/utilities/permissive_mode.dart:26:24)
#39     CompletenessTracker.visitCompilationUnit (package:nnbd_migration/src/utilities/completeness_tracker.dart:43:5)
#40     CompilationUnitImpl.accept (package:analyzer/src/dart/ast/ast.dart:2310:50)
#41     NullabilityMigrationImpl.processInput (package:nnbd_migration/src/nullability_migration_impl.dart:223:12)
#42     NonNullableFix.processUnit (package:nnbd_migration/src/front_end/non_nullable_fix.dart:162:16)
#43     _FixCodeProcessor.runLaterPhases. (package:nnbd_migration/migration_cli.dart:1088:20)
#44     _FixCodeProcessor.processResources (package:nnbd_migration/migration_cli.dart:1020:26)

#45     _FixCodeProcessor.runLaterPhases (package:nnbd_migration/migration_cli.dart:1086:5)

#46     MigrationCliRunner.run (package:nnbd_migration/migration_cli.dart:695:24)

#47     MigrateCommand.run (package:dartdev/src/commands/migrate.dart:37:7)

#48     CommandRunner.runCommand (package:args/command_runner.dart:209:13)

#49     DartdevRunner.runCommand (package:dartdev/dartdev.dart:231:18)

#50     runDartdev (package:dartdev/dartdev.dart:66:16)

#51     main (file:///b/s/w/ir/x/w/sdk/pkg/dartdev/bin/dartdev.dart:11:3)
`

As of 1c7fe7196dd7a542f7f91cd6ea2ac81e1a13146c, the null safety migration tool has been removed from active development and retired. No further work on the tool is planned.
If you still need help, or you believe this issue has been closed in error, please feel free to reopen.


Invalid parameters on Wiki solutions

Reference & fix for the two files.
Summary:
function repeat(str, num) {
  var newstr = [];
  for (var i = 0; i < num; i++) {
    newstr.push(str);
  };
  return newstr.join('');
}

repeat("abc", 3, "");

The first usage of the repeat/chunk function has 3 parameters passed to it, as well as having a semicolon at the end of the for loop.

Note: I originally wanted to fork the FCC Wiki, make changes, then make a PR. However, the process is quite convoluted so I ended up just filing a ticket instead. Hopefully GitHub gets around to fixing that particular problem.
Here is a fork of the Wiki repo with my changes. Whoever gets around to merging my changes will have to do it manually.

What is the issue?

The third parameter doesn't actually do anything, so why is it there?

Closing this issue as it is fixed in https://github.com/FreeCodeCamp/wiki/pull/111.

Not closed properly, I just submitted a PR that hopefully fixes the issue.
Apologies for posting on the wrong repo, I didn't realise that wikis had their own repo. My mistake.


Can we support demos on the 5EPlay platform?

What problem is this solving
Unable to analyze demo from 5e platform
Proposed solution
The 5EPlay platform is another major platform in China besides the Perfect World,I suggest supporting it,Thanks a lot.
Describe alternatives you've considered
o

I would need a bunch of CS2/CSGO demos from this platform.
Also some questions:

Are there knife rounds?
Are there overtimes?
Are bots enabled?
What game modes/match lengths are supported?

1.Yes
2.Yes
3.Yes
4.Competitive mode/24 round

http://gofile.me/6Yi2T/I0ZIi2eCy    This is the download link of 5E platform demo.   Created from my NAS.


Only scrappig 6133 reviews

I am trying to scrap the reviws of Slack app but the scrapper stops after scrapping 6133 reviews. Is it limited by this package?
Link to the URL: https://apps.apple.com/us/app/slack/id618783545

This mean Review on Apple store inlcude rating and review, this 6133 reviews is only review.

@cowboy-bebug How to know total review before crawling? Thanks @cowboy-bebug

@tphuonglam82 It's mentioned after opening the link that the total reviews are 11.8k. I think that there might be more than 6133 reviews to scrap it.

yeah, this review may be have reply and crawler not crawling this reply, i have check duplicaed record when crawed @deepak2431

@deepak2431 From my experience total review counts on the page is cross-regioned.
The url: https://apps.apple.com/us/app/slack/id618783545 only contains reviews from the US region.

Hey @tphuonglam82 @deepak2431
There isn't a way to tell how many reviews exist for an app.
Also the numbers of ratings and reviews are not equal -> there are more ratings than reviews most of the time (because people rate apps but leave out writing reviews)

And thanks for the comment! @Gabriel1443


Set model=False as default for daily and monthly data

I think that the model parameter should have False as default value in the Daily and Monthly classes.
I'm pretty sure that most of the people looking for Daily or Monthly data will be interested in having the "real" data with no interpolation and will be confused to see that by calling the class without arguments you get a different result as in the web interface.

I get your point. However, I actually wanted to follow an approach which makes it easy for people to get started with using the library. Some time series contain a lot of gaps and I thought it was more convenient for users to have the model data as a "polyfill" by default. But I also see that people probably expect real-data, only. Maybe we can do a poll, if enough people participate 😆

I think there should be a limit on the number of points that you can interpolate.
Today I got data from a station that was not reporting any since 5 days and it was quite confusing to interpret at the beginning :D

Do you refer to interpolate()? But regarding model data: yes, it's actually collecting model data for a station's location if the station reported data within the previous three years. That is, because I want time series to be as complete as possible, but still provide an opt-out using model=False.


sendrecv implements voice calls, using local signaling, the sound on the client side is normal, but there is no sound on the web side

Hi,
I am using the sendrecv case, and created a signaling service locally using simple_server.py and js files. In order to implement the voice call function, the pipeline in webrtc-sendrecv.c is modified.
"alsasrc device=hw:2,0 ! audioconvert ! audioresample ! queue ! opusenc audio-type=voice ! rtpopuspay ! "
After the link is established, the web audio is sent to the local client. It plays normally, but there is no sound when the reverse local client sends to the web side. After changing the server_url to https://webrtc.nirbheek.in:8443, the same operation, the web and client voice calls are normal.
I am currently in trouble. Do you have any suggestions?
Looking forward to your reply...
Thank you!

The web service runs inside the docker, and the signaling runs outside the docker. This may be the cause of the connection problem. The problem of running the web service outside the docker no longer occurs

I would also suggest looking at the STUN servers configured in each case

Hello, thanks for your reply
The following are the latest developments:
The only difference between the two cases is the location where webrtc.js is called, one is inside docker and the other is outside docker. The stun used by webrtc.js is the same. Or you mean that the stun services that can be used by different environments are different, But I did another video implementation in the same direction, which is normal in both cases, which confuses me.
In addition, I checked the stats in the two cases in chrome://webrtc-internals , and found that in the case of no sound, the audioLevel/totalAudioEnergy/[Audio_Level_in_RMS] three parameters in the Statistics RTCMediaStreamTrack_receiver_xx in the received remote data It is always 0. Do you have any suggestions on this phenomenon?
Looking forward to your reply again, thank you very much!

I would also suggest looking at the STUN servers configured in each case

Hi, thanks for your reply
The following are the latest developments:
The only difference between the two cases is the location where webrtc.js is called, one is inside docker and the other is outside docker. The stun used by webrtc.js is the same. Or you mean that the stun services that can be used by different environments are different, But I did another video implementation in the same direction, which is normal in both cases, which confuses me.
In addition, I checked the stats in the two cases in chrome://webrtc-internals , and found that in the case of no sound, the audioLevel/totalAudioEnergy/[Audio_Level_in_RMS] three parameters in the Statistics RTCMediaStreamTrack_receiver_xx in the received remote data It is always 0. Do you have any suggestions on this phenomenon?
Looking forward to your reply again, thank you very much!


Further update docs

Sorry this is so big ⛰ It is still not 100% documented, as some functions could use descriptions etc. I managed to document types.js, but I'm not super happy with the output - but this is how internet is suggesting (I tried some other ideas, but only this one worked). Besides adding bunch of JSDoc comments, I also excluded two hardcoded libraries from coverage, thus increasing it by ~3% 🎆

In the future, it would be better to leave out the generated docs for easier review (but I know this can still be considered the 'initial' docs version).


refactor: ux/ui on identity provider priority

related to: https://github.com/gravitee-io/issues/issues/7286

Env: Nightly
Result: PASS
Pre-test setup -
I have setup the Identity providers and Social/Enterprise providers
Scenario 1 -
Given I go into an Application --> IDP
And I select all the IDP and Save
Then the IDP Priority Order is saved successfully
Scenario 2-
Given I go into an Application --> IDP
And I deselect the first IDP and Save
Then the first IDP is moved to the bottom of the list
Checked every IDP that is deselected is moved to the end of the list
Scenario 3-
Given I go into an Application --> IDP
And I move the last selected IDP to the top priority 1 position
And I deselect it and Save
Then this IDP is moved to the bottom of the list
And Select this IDP and Save
Then this IDP is moved to the end of the selected IDPs
Scenario 4-
Given I go into an Application --> IDP
And I deselect all the IDPs and Save
Then there is no order and the IDP are just shown in UI but no order is saved for deselected IDPs
Scenario 5-
Given I go into an Application --> IDP
And I try to move the IDP from Identity Provider list to the Social/Enterprise provider list
Then IDP cannot be moved across the 2 lists. IDP within each list can be moved within each list only

Env: Nightly
Result: PASS
Pre-test setup -
I have setup the Identity providers and Social/Enterprise providers
Scenario 1 -
Given I go into an Application --> IDP
And I select all the IDP and Save
Then the IDP Priority Order is saved successfully
Scenario 2-
Given I go into an Application --> IDP
And I deselect the first IDP and Save
Then the first IDP is moved to the bottom of the list
Checked every IDP that is deselected is moved to the end of the list
Scenario 3-
Given I go into an Application --> IDP
And I move the last selected IDP to the top priority 1 position
And I deselect it and Save
Then this IDP is moved to the bottom of the list
And Select this IDP and Save
Then this IDP is moved to the end of the selected IDPs
Scenario 4-
Given I go into an Application --> IDP
And I deselect all the IDPs and Save
Then there is no order and the IDP are just shown in UI but no order is saved for deselected IDPs
Scenario 5-
Given I go into an Application --> IDP
And I try to move the IDP from Identity Provider list to the Social/Enterprise provider list
Then IDP cannot be moved across the 2 lists. IDP within each list can be moved within each list only


Update dd-trace-api, dd-trace-ot to 0.99.0

Updates

com.datadoghq:dd-trace-api
com.datadoghq:dd-trace-ot

from 0.91.0 to 0.99.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.datadoghq" } ]

labels: library-update, early-semver-major, semver-spec-minor, commit-count:1

Superseded by #553.


WFRP4 Update fr.json

Changes / Comments
Changes matching the latest version of the french character sheet provided by the french traductor/editor, Khaos Project.
--> Changements correspondants à la dernière version de la feuille de personnage en français mise à disposition par l'éditeur/traducteur français, Khaos Project.
I'm a newby to editing, but would it be possible to organize the skills by alphabetical order in french, by "mistraducting" on purpose the correct terms to put them in the right place?
--> Je suis un parfait débutant en ce qui concerne l'édition, mais ne serait-il pas possible de classer les compétences par ordre alphabétique en français, en traduisant mal à dessein les bons mots pour les mettre à la bonne place?
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
New here, but I don't think so, since it's "Update fr.json". The complete path is :"
roll20-character-sheets/WFRP4CharSheet/translations/fr.json".

[ ] Is this a bug fix?
No

[ ] Does this add functional enhancements (new features or extending existing features) ?
No

[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
No

[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
No change

[ ] If this is a new sheet, did you follow Building Character Sheets standards ?
It's not a new sheet, just small ajustements to match the latest official traductions provided by the french editor of WFRP 4th Ed.

If you do not know English. Please leave a comment in your native language.

Email me at<EMAIL_ADDRESS>and I'll get you an invite to Crowdin. :) It is an easier way to do translations. Thanks for translating!

I'm a newby to editing, but would it be possible to organize the skills by alphabetical order in french, by "mistraducting" on purpose the correct terms to put them in the right place?

The programmer needs to account for it, I think.


IOS Build failed

I cannot release app to live after add this plugin.
  flutter_image_compress: ^1.0.0
Flutter 2.2.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision f4abaa0735 (11 days ago) • 2021-07-01 12:46:11 -0700
Engine • revision 241c87ad80
Tools • Dart 2.13.4

Podfile pod version
platform :ios, '10.0'
Error Log
While building module 'SDWebImageWebPCoder' imported from
    /Users/bhanukaisuru/dev/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_image_compress-1.0.0/ios/Classes/CompressHandler.m:8:
    In file included from <module-includes>:1:
    In file included from /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/SDWebImageWebPCoder/SDWebImageWebPCoder/Module/SDWebImageWebPCoder.h:14:
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/SDWebImageWebPCoder/SDWebImageWebPCoder/Classes/SDImageWebPCoder.h:10:9: error: include of non-modular
    header inside framework module 'SDWebImageWebPCoder.SDImageWebPCoder':
    '/Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/Headers/Public/SDWebImage/SDWebImage.h' [-Werror,-Wnon-modular-include-in-framework-module]
    #import <SDWebImage/SDWebImage.h>
            ^
    While building module 'SDWebImageWebPCoder' imported from
    /Users/bhanukaisuru/dev/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_image_compress-1.0.0/ios/Classes/CompressHandler.m:8:
    In file included from <module-includes>:1:
    In file included from /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/SDWebImageWebPCoder/SDWebImageWebPCoder/Module/SDWebImageWebPCoder.h:15:
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/SDWebImageWebPCoder/SDWebImageWebPCoder/Classes/SDWebImageWebPCoderDefine.h:10:9: error: include of
    non-modular header inside framework module 'SDWebImageWebPCoder.SDWebImageWebPCoderDefine':
    '/Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/Headers/Public/SDWebImage/SDWebImage.h' [-Werror,-Wnon-modular-include-in-framework-module]
    #import <SDWebImage/SDWebImage.h>
            ^
    While building module 'SDWebImageWebPCoder' imported from
    /Users/bhanukaisuru/dev/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_image_compress-1.0.0/ios/Classes/CompressHandler.m:8:
    In file included from <module-includes>:1:
    In file included from /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/SDWebImageWebPCoder/SDWebImageWebPCoder/Module/SDWebImageWebPCoder.h:16:
    /Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/SDWebImageWebPCoder/SDWebImageWebPCoder/Classes/UIImage+WebP.h:10:9: error: include of non-modular header
    inside framework module 'SDWebImageWebPCoder.UIImage_WebP': '/Users/bhanukaisuru/Documents/REBORN/YELLO/user-app/ios/Pods/Headers/Public/SDWebImage/SDWebImage.h'
    [-Werror,-Wnon-modular-include-in-framework-module]
    #import <SDWebImage/SDWebImage.h>
            ^
    3 errors generated.
    /Users/bhanukaisuru/dev/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_image_compress-1.0.0/ios/Classes/CompressHandler.m:8:9: fatal error: could not build module
    'SDWebImageWebPCoder'
    #import "SDImageWebPCoder.h"
     ~~~~~~~^~~~~~~~~~~~~~~~~~~~
    4 errors generated.
    note: Using new build system
    note: Building targets in parallel
    note: Planning build
    note: Analyzing workspace
    note: Constructing build description
    note: Build preparation complete

Should be fixed by #182 .


(PUP-4516) Exit immediately when sent INT or TERM

Starting in ruby 2, signal handlers are not allowed to acquire a
mutex[1], because it could deadlock[2]. For example, the main thread
acquires a mutex, is interrupted by a signal, signal handler runs in a
separate thread, and will deadlock if tries to acquire the already
locked mutex. In ruby 1.8/9, the behavior was allowed, but wasn't safe.
In ruby 2, it's a hard failure.
Commit 6238616 removed thread-safety code because it was incomplete and
puppet primarily runs single threaded -- exceptions being its signal
handler and webrick request processing. PUP-202 was marked as fixed
since we no longer tried to acquire a mutex from a trap context.
However, the signal handler would still call back into puppet code, e.g.
reload, which led to PUP-1635 "current thread not owner".
Commit 245de036f modified the signal handler to queue the method to
execute, e.g. reload, and have the Daemon's event_loop periodically
check if a new signal had been received, calling the method from the
main ruby thread.
However, the event loop checks for new signals every 5 seconds, so
puppet will not immediately exit when sent INT or TERM. Also, if puppet
is making a blocking system call, e.g. agent is blocked reading from a
socket, then puppet will not exit until the system call returns.
This commit changes puppet's signal handlers to exit immediately in
response to INT or TERM. We call stop instead of exit to gracefully
shutdown, e.g. delete our pid file. There is a possibility the stop
method could cause a mutex to be acquired, e.g. in ruby's webrick or
logger, but it doesn't seem to happen in practice.
Also we preserve the existing async handling for HUP, USR1, and USR2.
This commit affects the agent and webrick master as both support
daemonizing.
[1] https://github.com/ruby/ruby/blob/v2_1_7/thread.c#L4384-L4386
[2] https://bugs.ruby-lang.org/issues/6416

:+1:
I'll wait for Travis.


Tidy up tox config

The tox config was out of date with the Travis config, making it hard to run tests locally. I've tidied it up, and made Travis run tox, so that there's only one set of config to worry about. What do you think? Please let me know if there's a better way of doing this!

It looks good. Thanks!


dcgm-exporter can't run

It logs this:
root@octopus-worker1:/home/practice# docker logs d674af870ff5
Starting NVIDIA host engine...
Got error 11 while waiting for SIGUSR1 from child process.
Collecting metrics at /run/prometheus/dcgm.prom every 1000ms...
Stopping NVIDIA host engine...
Unable to terminate host engine, it may not be running.
/usr/local/bin/dcgm-exporter: line 141: kill: (12) - No such process
Done
How to solve it?Thanks

@JohanOu  I have the same issue， have you solved it？


Push request

Changes:
1). Background color changed
2). Anchor tags are working now.

Do I need to format this about page it will be bit odd without formating


Unknown error: session deleted because of page crash

Hi,
we are currently experiencing page crashes on moon pods from time to time.
Caused by: org.openqa.selenium.WebDriverException: unknown error: session deleted because of page crash
from unknown error: cannot determine loading status
from tab crashed

The issue occurs from time to time and not specific to a certain test.
We found some entries about storage issues that can result to this:
https://github.com/elgalu/docker-selenium/issues/20
https://stackoverflow.com/questions/72562123/selenium-session-deleted-because-of-page-crash-from-tab-crashed
Are you aware of such an issue? Any advice maybe?

Hi,
this issue is getting bigger and more tests are affected.
We are getting now various kinds of errors.
Caused by: NoSuchSessionException: invalid session id
Caused by: WebDriverException: unknown error: cannot determine loading status

@whrostre from time to time crashes are usually caused by the lack of memory for Moon browser pods. Try to add more memory in Moon settings.


Crash When Using Unity Version 6000 Due to Missing API Header in BNM

Some games are using Unity version 6000, but on BNM there’s no API header for Unity version 6000. So, I tried using #define UNITY_VER 232 // 2023.2.x+ instead, but the game ended up crashing.
Any ideas on how to fix this?

How I see, libil2cpp.so trying to use invalid pointer. And it was called from libBNM.so. But that's all that I can say about this crash log.

You're right! 😅 After checking again, the crash error is in my own code, not BNM's. 🙈 Sorry about that! 🙏 And you were spot on 🎯—API 2023.2.x+ is fully compatible with Unity 6000. 🚀🎉


ExternalName not working

Source: external-service/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
name: external-service
annotations:
configuration.konghq.com: sample-customization
labels:
helm.sh/chart: external-service-0.0.1
app.kubernetes.io/name: external-service
app.kubernetes.io/instance: external-service
app.kubernetes.io/version: "0.0.1"
app.kubernetes.io/managed-by: Helm
spec:
type: ExternalName
ports:
- port: 443
protocol: TCP
selector:
app.kubernetes.io/name: external-service
app.kubernetes.io/instance: external-service
externalName: ****.execute-api.eu-west-2.amazonaws.com
Source: external-service/templates/ingress.yaml
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
name: external-service
labels:
helm.sh/chart: external-service-0.0.1
app.kubernetes.io/name: external-service
app.kubernetes.io/instance: external-service
app.kubernetes.io/version: "0.0.1"
app.kubernetes.io/managed-by: Helm
annotations:
konghq.com/override: sample-customization
kubernetes.io/ingress.class: kong
kubernetes.io/ingress.global-static-ip-name: platform
kubernetes.io/tls-acme: "true"
spec:
rules:
- host: "..com"
http:
paths:
- path: /test/helloworld
backend:
serviceName: external-service
servicePort: 443
Source: external-service/templates/kongingress.yaml
apiVersion: configuration.konghq.com/v1
kind: KongIngress
metadata:
name: sample-customization
proxy:
protocol: https
route:
protocols:

https
strip_path: false

kong-ingress-controller:0.9.1
With an externalName of httpbin.org everything works as expected.
If I change the name to dynamically created hostname in AWS I get 403 or GCP I get 404.
I think this has something to do with not resolving the hostname correctly but cannot prove it.
Both endpoints in AWS and GCP are public and work when used directly.

A 4XX response indicates this isn't a DNS resolution issue. Kong returns a 503 for resolution failures.
While Kong can emit its own 404 responses (if the request did not match any route) or 403 responses (if an authentication plugin denied a request), those would come back regardless of the specific hostname in the ExternalName service: you'd still see them even when the Service was configured to point to httpbin if Kong was generating those responses on its own.
The information provided so far indicates that those requests are at least making it upstream to the AWS/GCP hosts, so if you're seeing a different response when sending requests to them without Kong, comparing access logs for those requests and the Kong requests could help indicate how the requests differ, which should help clarify what you'd need to change in your Kong configuration.
While it's hard to say what the cause of the issue is without access logs to compare, my best initial guess is the request hostname. preserve-host is false by default, so the upstream request will send the AWS/GCP hostname. If those hosts are configured to only respond to requests for the external hostname (i.e. the hostname that you use in your Ingress rule), that'd explain the issue, and setting that annotation to true would resolve it.


QL-Win / QuickLook NOT WORKING

What's the Problem?
QuickLook is a file viewer, it plays video for video file, opens image in image viewer if its a image, opens pdf file.
All without opening separate application from the file explorer.
Its a very handy tool to preview media files , just like Mac
Solution/Idea
Pls implement support for QuickView
https://github.com/QL-Win/QuickLook/releases/tag/3.7.1
Alternatives
windows File explorer, its still the go to file explorer after using many many 3rd party , free alternative file explorers.
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
No response
Windows Version
No response
Comments
No response

@nicholateslaisme thank you for opening this issue, QuickLook support is already implemented. Can you create a new bug report and include the log files and version information so we can look into why it's not working for you?


Syntax and compilation to arrows

Some of the lemmas that can be proved by using just lia you might like to consider just performing "inline" in your proof rather than breaking out a separate lemma for them.


Framework v5.2.7 breaks with createFactory() compatability error

Specifically the error is with bosnadev/database package, I get the error:
[2016-01-12 20:56:09] local.ERROR: ErrorException: Declaration of Bosnadev\Database\Connectors
\ConnectionFactory::createConnection($driver, PDO $connection, $database, $prefix = '', array
$config = Array) should be compatible with Illuminate\Database\Connectors\ConnectionFactory::c
reateConnection($driver, $connection, $database, $prefix = '', array $config = Array) in /User
s/jonny/Development/git/jbl5/vendor/bosnadev/database/src/Connectors/ConnectionFactory.php:13

How can we work out what the incompatibility is?

It’s the PDO $connection part. Maybe its because I’m using PHP7, but if I change PDO $connection to just $connection then I get no errors. This needs to be done in both this package and the Bosnadev package.

I have the same error after php artisan migrate:refresh --seed
php 5.6.14
laravel 5.2.10

Hi, I'm aware of the problem, I just haven't decided how to handle it yet.
If I change the function signature, it'll break compatibility with with L5.1, which has LTS.
I'll probably have to maintain two versions, which I'm not too happy about.

I assume the easiest way of doing that would be to bump the package version, people using L5.1 can keep using v2.x, people using L5.2 can use v3.x?
It’d just be a pain keeping feature parity between the two versions. :/

The other problem was that the postgres package I was depending on hasn't updated. But I found a fork that seems to be well maintained, so I based it on that.
Anyway, 3.0 is out for L5.2. Please try and report any problems.

3.0 works on Laravel 5.2 for me. :)

@phaza What about 5.1 version? Still not fixed.

You might have to clear your compiled.php file
It happened to me while upgrading from Laravel 5.1 to 5.2


Create zoom_guidelines.md

Signed-off-by: John Mertic<EMAIL_ADDRESS>

@mandy-chessell Can we add this to the TSC agenda for tomorrow to review/discuss?

Agreed to by TSC on 4/8/2020 -> https://github.com/odpi/tsc/blob/master/meetings/2020-04-08-ODPi-TSC-Meeting-Notes.md


APPLICATION_ROOT is not working

The documentation suggests to use APPLICATION_ROOT to modify the position of the application so that it runs on another URL. Any attempt made to make it work by setting app.config["APPLICATION_ROOT"] didn't produce any result, so either there's a problem in the documentation, or the APPLICATION_ROOT variable is not honored somehow (either by flask or browsepy)

I found a better strategy in using gunicorn, and the following flask snippet
http://flask.pocoo.org/snippets/35/

APPLICATION_ROOT is used only by flask, not being used by browsepy code. And yes, as your link points to, the wsgi environ-dict values for "PATH_INFO" and "SCRIPT_NAME" are honored first, so best way to ensure your URL base gets rewritten is to wrap the flask application using a wsgi middleware.
Anyway, README is confusing and should be improved with this info, I'll do soon as possible.


Support for non-Delimited file types in Redshift

https://docs.aws.amazon.com/redshift/latest/dg/copy-parameters-data-format.html

Can I add a +1 to this issue 😂 currently running into this now. It seems to me that you just have to not include DELIMITER as an option? i.e. make this line optional only if deliminter is not None ?
Also now I'm using locopy because Redshift really has crappy python connector....

@jfyu happy to accept a PR too if you have some time 😄


od2net prep

I'll take a day or two and do some work on od2net before the hackathon. Few ideas for things that could be useful, any votes or other ideas?

get elevation data added, so cost functions can adjust cyclist speed
revisit the Ottawa-based LTS definitions and maybe come up with simpler rules that're better tuned to UK
look at 2021 census data and see if we can recalculate part of the PCT

Big +1 to this. As mentioned to @cmconlan I think the first stage is to identify case study areas. How's

Greenwich
York
Small area outside ATI?

There are od2net example configs for York and all of London already, so SGTM

Elevation support and influence on routing is plumbed through now, but still has some rough corners. Enough to play with during the hackathon though!

Great job Dustin, hoping the experiences of people during this hackathon can make it even better. Loving the visualisation of hills, so cool.

I started on the 2021 census data, using https://www.nomisweb.co.uk/sources/census_2021_od ODWP01EW. Might have it ready for tomorrow. But also the dataset looks very different than the 2011 one; no commuting modes, for starters

There is a version with mode. I'll send you a cleaned up version. It requires a LOT of pre-processing as @hussein_mahfouz can attest.

In case useful, the preprocessing I did can be found here

Where's that ODWP15EW_MSOA file come from? I don't see it on https://www.nomisweb.co.uk/sources/census_2021_od

It's from WICID. I think I logged in using the "Registered access for academic and most other users" option in order to access the dataset

Ah thanks. I see ODWP01EW_OA in the public version. I'm not touching anything non-public for now, because I can't host the output online.

We can infer mode split from open zone data if needs be.