Slow to select many units

Have noticed this (inconsistent) behavior only when interacting with larger numbers of units at a time, for ex, when selecting 30 units in a sort with 230 total. See #10 for comments and example sortingview workspace

Example workspace: https://sortingview.vercel.app/workspace/sorting/R-c5089c48b72f/S-816a8e175985?workspace=e5c306c436a9f75fd97a20d832cd54d8243d516da53cbfe86270f11e98ee8b26&channel=franklab

@acomrie I can't reproduce any slowness in selecting units in the above workspace. Perhaps you could describe the exact steps you use? For example, which units you try to select, etc?

It's particularly curious that you should see slow performance in selection, because unit/row selection happens entirely client-side--in the browser, on your computer. There isn't any mechanism to write your selected row IDs to permanent storage anywhere, and the server doesn't care about it; it ought to be happening entirely in memory on your local machine.
I'm wondering, could you also share your environment? What is your OS, browser, browser version, any browser add-ons, and possibly the overall system load via TaskManager (Windows) or htop (mac/linux) etc when you experience the slowness? Is there a lot of other software running in the background that might be competing for resources?
Do you notice this specifically with a lot of other widgets/views open (such that the system would have to communicate the new selection state to several other components, like cross-correlograms or the spike amplitudes view)? I am seeing pretty much instantaneous response when I have only the units table open, but there is some lag (on the order of 250 ms?) when I've also got the spike amplitudes, average waveforms, and cross-correlograms views all open. Also, does it make a difference whether the units table view is sorted by a column other than unit ID?
Looking at the underlying selection calls, I might expect some asymmetry between select-all and deselect-all. When you click the 'select all' button, the system iterates over each row of the units table and converts the row ID (which, as part of an html element, has to be a string) to a number, then passes all the row numbers into the function that selects them; on the other hand, when you deselect all with the same button, all it has to do is replace the 'selected units' list with an empty list. That should in principle be less work. So if they're equally slow, that's kind of interesting.
On the other hand, when deselecting a single unit from a large list of units, the selection code has to create a new selection list, filtering out any single element which is part of the old selection list. This means it has to look at every selected unit. While, again, these operations ought to be very fast, it's still more work than deselecting everything at once, or even adding an individual unit to the selection.
At this point I'm just making guesses & speculating about how different interactions ought to perform--any information you can add about your exact setup will be very helpful.

Hi all, thanks, let me answer these one at a time - going with a verbose response here, so the short version is that: that the lagginess does seem inconsistent, so I'm not too surprised it wasn't replicated on your end. In fact just trying it right now, I have slowness with unit selection on my analysis computer in lab, but not with unit selection on my laptop. It may indeed all come down to what else a user is running locally simultaneously, and documenting this as we go may help reveal these patterns.
In response to Jeremy's comment - example steps I may take where unit selection can be slow to display:

click on link to sortingview workspace
open units table
show all units
quickly try to select, say, 30+ consecutively-displayed units, one by one, perhaps with a little scrolling interspersed between the unit selections

^This is sometimes slow all on its own, and sometimes totally fine. An alternative and more common/practical use case would be to insert steps: 3.1 reorder units table 3.2 select a subset of units 3.3 open waveform view and display all units (click show more units several times) 3.4 open autocor view and display all units (click show more units several times) 3.5 move some views to the lower panel so two views can be seen simultaneously 3.6 select all/deselect all in units table 3.7 reorder units table by another metric.... etc., then back to step 4 from above. I think this type of interaction is more representative of how we're currently using the curation tools.
The most extreme case I have observed with the selection/deselection is relatively unusual but I have seen it enough times to be confident it can happen - that is, I'll sometimes select some units in the units table, then scroll down before those units have become highlighted, then click some more units after the scroll. And occasionally, the "wrong" units will be selected from the clicks that occurred before scrolling down - as if the computer remembered the coordinates of the click rather than the identity of the clicked unit. A little hard to describe, let me know if I should clarify.
I think @jsoules points about the system's other processes are a likely culprit. especially considering that I've found this behavior to be inconsistent. it's helpful to know the unit selection is all happening on the local machine (even if the local machine is also busy fetching waveforms from the server, etc). I have seen slowness on a work computer running linux 16.04 (🙈), firefox 88.0 without addons, and several other applications open (vscode, slack, several terminals with open port-forwarded jupyter lab sessions running on other servers, <5 other browser tabs, but no computationally intensive analysis code running in the background locally at the moment). This is where I'm currently seeing slowness right now, today, and indeed, htop/system monitor is revealing -- the big bumps in cpu history are bouts of me selecting ~10 units. I should include that I don't always observe slowness on this system, so will investigate potentially competing processes when I next have a non-laggy experience with it.

I have also experienced slowness on my macbook pro in both safari 13.02 (no addons) and chrome 92.0.4515.131 (adobe acrobat extension) at times, but because I can't replicate it right now, I'll report back on what top/activity monitor tells me upon next observing it!
Per the usage "steps" I mentioned above, I often have had the waveform and autocor views open simultaneously, and occasionally have one other view like spike amplitude or xcor open too (but I don't have, say, 8 views open at once, usually 3 ish). Both autocor and waveform and units table views would be communicating about the selection state I think. I haven't noticed extra lag related to sorting the units table view by alternative columns. I do think that select all takes longer than deselect all usually - though I often just press the button twice and wait them all to appear deselected before moving ahead with new selections, so I wouldn't be too confident in my assessment of that without further testing/measuring. Your comments about the deselection details make sense and fit into what I've seen.
Will keep an eye on all these factors moving forward and report back! Thanks a bunch

@xlsun79 @emilymonroe95, welcome to the conversation! Xulu and Emily, I know you have begun interacting with large datasets in sortingview, so can you please share info about your experiences/setups here in hopes of getting to the bottom of the lagginess we've observed? See Jeremy and Jeff's comments above with potential prompts. I know one of you  mentioned whirring laptop fans to me at some point! @rsnevers if you have a moment maybe you also have thoughts about unit selection lagginess (or lack thereof) when working with smaller datasets from tetrodes (<50 units at a time I'm guessing).  Thanks all! Really appreciate it

In my experience, unit selection is generally fast except when I have the spike amplitudes tab open somewhere and am selecting units with a lot spikes (> 100000). This is especially true if I've zoomed out a lot on the spike amplitudes time axis because a lot of points are being plotted. This reliably slows down sortingview for me, and it happens even if the spike amplitude tab is open but not currently displayed.

@acomrie Thank you so much, this detailed response is exactly what I was looking for. When I have the average waveforms and autocorrelograms views open & have clicked to show everything, I too am having some noticeable lag issues.
In case you're curious, the short story is something along these lines: we share a selection state among all the views & apply styling (highlights) to the visualizations based on the selection state. When the selections in the units table change, that causes the system re-render everything in the other open views. They're supposed to be cached and updated only if they've actually changed, but that doesn't seem to be happening. Even more unfortunately, that "getting redrawn" thing applies whether they're actually on screen or not. (i.e. I think @rsnevers is spot-on about plotting a lot of points.) The biggest thing I'm seeing in the profiler is a load time of between 4 and 10 ms for each average waveform view. That doesn't seem like much, but with 226 units, it's easily over a second by itself, even if they were all on the lower end of that range.
I'm trying to zero in on exactly what calls are resulting in these excessive load times; unfortunately, the load keeps causing my profiler to lock up and crash. I will continue looking into it and update here as I make progress.
In the mean time, please feel free to keep updating these tickets with details of any further performance issues. Once again, the level of detail above is extremely helpful.

I have experienced some slowness as well. For context, it mostly happens on the first time (at least) opening up a given spike sort, but occurs across computers, browsers, and number of applications open on the computer. I had more slowness using safari than chrome, especially with other windows/tabs open.
My order of operations would be: first click on the link to open sortingview, then open up the units table. Selecting units occurs at normal speed at this point. If I then open up the waveforms view and try to select units, it is somewhat laggy (take an extra second to select). Its also slow to purely select the units in the spike amplitudes view and for the cross correlograms, but even longer to load their output, especially the first time loading them.
The slowness in selecting units in the units table decreases after closing the average waveforms view, and also over time that the sort is open (better after ~10min).
It seems to me that after things have loaded once from the initial opening of a sort on a computer, they load more quickly and slowness/lagging mostly goes away on future openings of the same sort.
I experienced the “whirring” fans on my laptop the first couple of times I ever opened a sort. I was using safari with a few other windows/applications open. The sort had ~230 units and I was exploring the different views (e.g. clicking on units while loading waveforms), but I haven’t experienced this issue since (even with opening other new sorts).
Thanks all!

@magland, you may have already seen this, just looping you in here in case you hadn't followed the conversation - wanted to add that other than the kachery memory overloading issue, this is the main other issue that is relatively high priority on the user end in my opinion. Seems like @jsoules is on it and has some ideas :) Thanks both!

Hi all, gave this a go today along with @emilymonroe95 and @xlsun79. The unit selection is definitely way more responsive! This makes manual curation significantly more user-friendly. We also thought that the displays that change their highlighting based on unit table selection seemed to load faster (i.e., waevforms and autocor). Label-adding seemed faster but still occasionally got backed up (perhaps after adding 10 labels one unit at a time, a page refresh and reopening the views could fix this). The spike amplitudes view still took longest to interact with, but it's a ton of data to load especially when there are many spikes, so it's certainly understandable. Overall, this is a great improvement in my opinion, with a couple potential areas for any future work on performance (label adding becoming laggy over time and the general slowness of data-heavy spike amplitudes view). Thanks Jeff and Jeremy!

@acomrie Thanks for your feedback--glad to hear things are much improved. Units table, waveforms, and autocorrelograms were exactly the areas I dug into, so if you're noticing them working faster, that's a big win. (No surprise that labels and spike amplitudes did not see much improvement--I didn't make any changes there, so they'd just be benefiting as a secondary effect of the units table improvement.)
Regarding the performance of labels and spike amplitudes, in those cases I suspect there may be a bigger contribution from the way the system back-end works than there was for the units table & selectable unit views. To avoid scope creep on this issue, could I ask that you open a new issue or two if you'd like us to look into those more? I'd otherwise close this issue out.

Sure, sounds good to go ahead and close. Thanks!


[#298] Demo app and test

[#298] Demo app: add an option to disable infinite scroll. Add a test to make sure search results are visible when the infinite scroll is off.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.51%. Comparing base (1053052) to head (14bdc85).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #299   +/-   ##
=======================================
  Coverage   89.51%   89.51%
=======================================
  Files          15       15
  Lines         582      582
  Branches      145      145
=======================================
  Hits          521      521
  Misses         55       55
  Partials        6        6

Flag
Coverage Δ

89.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Open with Simulator Button for featured examples from CircuitVerse homepage

Is your feature request related to a problem? Please describe.
Request for an Open With Simulator Button on featured examples
Describe the solution you'd like
Issue Description :

Go to homepage :  circuitverse.org

scroll down to featured examples

Open any example  :

Here you can see that we can only read about the circuit and observe it
feature description
On featured circuits examples there should be a  button like pen with simulator which will take the user To The Simulator page with a readymade circuit same as that of the previously featured example circuit was.
It should look something like this  :

Additional context
benefits to the user

can directly see the circuit in action and how it works in real life with the real inputs rather than just reading the information

will be able to modify the circuit according to his needs and see the results with different inputs provided

will be able to enhance the circuit as well

Are you working on this? (Yes/No)
No

Hey, @SiddheshKukade Welcome to circuitverse,
talking about this issue, We have a full-screen button that preview circuits and sub-circuits, Any user can test these projects... and for making some changes and enhancing the project, we have a fork button( user must be signed in ), Simply user can fork the project and launch the simulator and made his changes to that project...
Directly making changes to someone's project that's not a good idea.
https://user-images.githubusercontent.com/76155456/157673066-faa608b5-b492-4e69-9e27-19fabd93f5e3.mov
WDYT @ayan-biswas0412

Hey, @SiddheshKukade Welcome to circuitverse,
talking about this issue, We have a full-screen button that preview circuits and sub-circuits, Any user can test these projects... and for making some changes and enhancing the project, we have a fork button( user must be signed in ), Simply user can fork the project and launch the simulator and made his changes to that project... Directly making changes to someone's project that's not a good idea.
Screen.Recording.2022-03-10.at.6.57.11.PM.mov
WDYT @ayan-biswas0412

I don't think fork directly changes the main project, rather it creates a copy in the profile who have forked and all changes made to the copied one.

I don't think fork directly changes the main project, rather it creates a copy in the profile who have forked and all changes made to the copied one.

Yep!


NIFI-11856 Update mongo.driver.version to 4.10.2

Summary
NIFI-11856
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking

[X] Apache NiFi Jira issue created

Pull Request Tracking

[X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
[X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

[X] Pull Request based on current revision of the main branch
[X] Pull Request refers to a feature branch with one commit containing changes

Verification
Please indicate the verification steps performed prior to pull request creation.
Build

[ ] Build completed using mvn clean install -P contrib-check

[ ] JDK 17

Licensing

[ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
[ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

[ ] Documentation formatting appears as expected in rendered files

This successfully ran on my local branch check


Install older chemteam tools for iwc workflows

Installation sequence for tool-installers

[ ] Test using @galaxybot test this
[ ] Inspect CI output for expected changes
[ ] Deploy using @galaxybot deploy this if test install was successful
[ ] Merge this PR

@galaxybot deploy this


RDK-32487: HDMI compatibility mode support

To support HDMI compatibility, adding set and get apis for HDMI version.
Supported versions - HDMI2.0 and HDMI1.4
Default value - HDMI2.0
Commands:
TOKEN_tmp=/usr/bin/WPEFrameworkSecurityUtility | cut -d'"' -f4
curl -H "Content-Type: application/json" -H "Authorization: Bearer ${TOKEN_tmp}" -d '{"jsonrpc":"2.0", "id":3, "method":"org.rdk.HdmiInput.2.setEdidVersion", "params":{"portId":"1", "version":"HDMI1.4"}}' http://<IP_ADDRESS>:9998/jsonrpc
curl -H "Content-Type: application/json" -H "Authorization: Bearer ${TOKEN_tmp}" -d '{"jsonrpc":"2.0", "id":3, "method":"org.rdk.HdmiInput.2.getEdidVersion", "params":{"portId":"0"}}' http://<IP_ADDRESS>:9998/jsonrpc

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Pls document the new APIs at https://wiki.rdkcentral.com/display/RDK/HDMI++Input


Created download option

Hey there! :wave:
Thank you for your contribution to PDFMaker! :tada: Let's make this PR awesome together!
What has changed? :pencil:
The pdf generation and a download button have been implemented.
Why this change? :thinking:
2 of the essential functionalities - generating the PDF and being able to use it by downloading it to your local system have been implemented through this PR
Closes #3
Testing :test_tube:

[✔(https://emojipedia.org/check-mark)] I have tested the changes.
[✔(https://emojipedia.org/check-mark)] I have updated the documentation accordingly.

Screenshots :camera:

Additional Information :bookmark:
Thank you for being a part of the ACM-VIT community! :heart:

Thank you @abhi-shek-09

Thank you so much!
On Sat, Oct 21, 2023 at 9:32 AM Adarsh Shirawalmath <
@.***> wrote:

Thank you @abhi-shek-09 https://github.com/abhi-shek-09
—
Reply to this email directly, view it on GitHub
https://github.com/ACM-VIT/PDFMaker/pull/7#issuecomment-1773649857, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AYSAL7RO4ECMPCEL2EBEA2DYANCLPAVCNFSM6AAAAAA6J3HIUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZTGY2DSOBVG4
.
You are receiving this because you were mentioned.Message ID:
@.***>


SwellRT version

Add support for SwellRT version
Ideally, it should be shown with a command, like:
$ ant version
0.5.1

Ant always shows junky text. The cleanest way to make this is something like this:
Is it good to you?
pablojan@lemovo-pc:~/Development/projects/wave-mod$ ant -f build-swellrt.xml version
Buildfile: /home/pablojan/Development/projects/wave-mod/build-swellrt.xml

version:
     [echo] Version=0.1.0-alpha

BUILD SUCCESSFUL
Total time: 0 seconds

Sure! It can work
I can just parse the output and use what is behind [echo] Version=

Ready!

Awesome! Thank you
2015-07-01 13:48 GMT+02:00 Pablo Ojanguren<EMAIL_ADDRESS>
Closed #32 https://github.com/P2Pvalue/swellrt/issues/32.
—
Reply to this email directly or view it on GitHub
https://github.com/P2Pvalue/swellrt/issues/32#event-345309639.


No difference in the documentation for ??? and ?? !!

The problem
When browsing the index for routines, the ??? routine links to the same page as ?? !!, which does not appear to actually include any information about what ??? might do. In fact, the ??? string does not appear in the linked page.
Suggestions
These should either link to different pages, or, if they are different flavours of the same, the code example should be expanded to show both cases.

In fact, that should point to this page

I think it's a problem in the generation of the index. ? is simply the start of the query section of an URL; anything starting with that points to index.html, which curiously enough we do have in our set of pages. It would return a 404 otherwise.
I'll see what can be done about this. Thanks for the report.

Finally, I'm closing the PR (thanks to @Altai-man for reviewing it) that kinda patched (or maybe not) this problem.
This problem is related to how indexes (indices, whatever) are generated. The problem is that, for no reason, they are generated on the fly as POD6 and then put it back as HTML. This involves some back-and-forthing of MIME-encoded URLs, in whose steps some stuff is lost.
I think the main intention of this is to generate indices in the same template that the rest of the site. And this pass through pod6 is needed because the template is embedded in the pod-to-html code, as indicated in perl6/Pod-To-HTML#35
So.
I think the best approach is to be able to generate HTML pages directly without the bridge. And in order to to that we need to separate the template from the code, and then use that template to generate pages needed here (or simply create our own template). Then, we can refactor htmlify.p6 #1823 to use this.
So this becomes officially big, and also external. And it's the kind of issue we need to keep having. Thanks, @jjatria for reporting it.


Setting AdaBoostClassifier's base_estimator=xgb.XGBClassifier will get error. How to solve it

For example the code is following:
clf = AdaBoostClassifier(
n_estimators=20,
# algorithm='SAMME.R',
learning_rate=0.05,
base_estimator=xgb.XGBClassifier(n_estimators=50, scale_pos_weight=0.1, max_depth=8,
objective='binary:logistic', learning_rate=0.02,
gamma=0.1, min_child_weight=3, reg_lambda=1000,
subsample=0.7, colsample_bytree=0.4))
clf.fit(X_train, y_train, sample_weight=None)
I got the error : AttributeError: 'list' object has no attribute 'take'.
when I debugged, the postion of the error  :
y_predict = self.classes_.take(np.argmax(y_predict_proba, axis=1),axis=0)  (*boost_real in weight_boosting.py *)
so I modified the code as : (because type(XGBClassifier.classes) is list, and other classifiers in sklearn  such as ExtraTreesClassifier is ndarray):
y_predict = self.classes.take(np.argmax(y_predict_proba, axis=1), axis=0)
to ==>
y_predict = np.array(self.classes).take(np.argmax(y_predict_proba, axis=1), axis=0)
Now the code will run normally. But the problem occurs in predict_proba function (sklearn.py)
Note the def predict_proba(self, data, output_margin=False, ntree_limit=0)
I modified the _boost_real in weight_boosting.py again:
y_predict_proba = estimator.predict_proba(X)
to ==>
if estimator.class.name == 'XGBClassifier':
y_predict_proba = estimator.predict_proba(X, ntree_limit=estimator.n_estimators)
else:
y_predict_proba = estimator.predict_proba(X)
But the problem occurs again (all the item in y_predict_proba is always 0.5, it seems the XGBClassifier doesn't work!)
So is there an elegant solution? Please help

Old bug, no answer, closing


Copy curl command

How to copy request as curl command? When need to pass to others

It is not possible as for right now. But the support is coming and soon will be implemented.
The image below is the working element that is responsible for displaying the code snippets:

With the release of next version I'll close this issue.


Tag some version (e.g. 0.1.0) of current state

ATM there is no tags, git describe cannot work without --always

it is really not that hard ;-)  May be since it is still very volatile, could include the date, what about
git tag -m "A snapshot release at some deployed state" 0.1.`date +"20%y%m%d"`
git push origin --tags

Please?  I do not think that 0. versions of any kind is a strong promise of any API stability etc.  I would even like the above "dateish" style to give a better perspective while looking at versions recorded somewhere.
The reason I am asking is because it becomes hard to impossible (could use hexsha of commit but those provide no perspective without lookup) to annotate for changes in gui.dandiarchive.org within dandi-cli.  If you need assistance in running the above command, please let me know ;-)

Sorry to leave you hanging on this. I don't think I get what you are looking for.
Are you looking for a tag in the repo or a tag tied the deployed software or what?
I definitely want to make as few promises of API stability as possible, especially right now. At this point we don't have any API stability on this repo, and the only API we are claiming to support on dandiarchive.org right now (to my knowledge) is like https://dandiarchive.org/dandiset/000004/draft.

The reason I am asking is because it becomes hard to impossible (could use hexsha of commit but those provide no perspective without lookup) to annotate for changes in gui.dandiarchive.org within dandi-cli.

Can you explain what you mean by this? Like what is your workflow and where are you running into friction?

i should also note that api will not come from gui.dandiarachive.org since it is a client side app (it cannot be called with curl for example). it will at present come from redirector service and whatever the future architecture holds of that service.
we are providing a couple of endpoints right now:
https://dandiarchive.org/dandiset/drafts --> public dashboard page
https://dandiarchive.org/dandiset/[identifier]/[whatever-at-the-moment] --> dandiset landing page

after the schema is versioned, i was going to add content negotiation capability to return metadata. i could add a service info api, but i think we should perhaps have the api discussion call soon.

The reason I am asking is because it becomes hard to impossible (could use hexsha of commit but those provide no perspective without lookup) to annotate for changes in gui.dandiarchive.org within dandi-cli.

Can you explain what you mean by this? Like what is your workflow and where are you running into friction?

dandi-cli ATM is tightly linked to the dandiarchive.org . While annotating for changes in dandi-cli (e.g. in commit messages which I am trying to have informative or upcoming changelog) I would like to state for which version of dandiarchive web UI those changes are pertinent. But I cannot. I can only say "today's version" or copy paste the hexsha of currently deployed (which might change in a minute) instance.  Having a version associated with current state of gui.dandiarchive.org would allow me to say instead of "just released" a "version 0.1" or alike, and later if needed to be able to diff e.g. 0.1..0.2 to spot what differences in URLs etc were introduced between two versions. Now I would need to match commits to two dates I would like to compare or start recording hexsha which would be ugly.
It would have been also nice if at some point CHANGELOG has appeared annotating at least major changes between two different versions, such as what functionality was removed/added or what major aspects have changed.
So the friction point is that I do not quite grasp why releases are rolled out without annotating at least major refactoring points with release versions which I kept asking about.

Are you looking for a tag in the repo or a tag tied the deployed software or what?

tag in the repo. Aren't we deploying straight from the master, and not e.g. upon pushing a new tag so it would also be the "deployed software" as in our single instance ATM?
As for querying deployed instance, separate issue -- see #316

hand twisting in action -- I am placing a mental cron job of "sleep 36000 && git tag -m "New web ui supporting releases and other UI enhancements" 0.1.0 && git push origin 0.1.0" .

https://github.com/dandi/dandiarchive/releases/tag/0.1.0
I've pushed this tag, although I don't think the notion of a semantic version is well defined for a repo that contains provisioning code, a docker-compose, a web gui, and a plugin providing rest endpoints.

Woohoo!  Thank you @mgrauer !  You could consider it a dandi webui platform version, as e.g. a version of any  linux distribution release which contains a variety of subcomponents which could have their own versions.

I don't think the notion of a semantic version is well defined for a repo that contains provisioning code, a docker-compose, a web gui, and a plugin providing rest endpoints.

i will simply consider it a version of the state of the union but the state always changes !

Yes, I think ultimately the piece that will stay with us the longest from this repo with be the Web UI.
The State of the Union is strong, or actually, it is 0.1.0.


Demo Project: In BalloonMarker.swift : "Error: No such module 'charts' " XCode 6.4

Just downloaded the library and tried compiling the demo project, ran into this error. I tried including the library in my project as per the instructions in the README, but I get the same problem.

Can you provide more information? The demo project should be working anyway. There could be many reasons for Error: No such module 'charts'... you can search through the closed issues for possible reasons.

Yeah that's what I thought. Since the demo project doesn't work, it's most likely a problem with my setup. However, I cannot think of anything I changed. I tried clean, and deleting the DerivedData folder. I will look at the closed issues.

Alright so I fixed it. I tried a bunch of things together, and I'm not sure what did it. First, I moved the "Charts" folder into the "ChartsDemo" folder. Then I added ($SRCROOT) to the runpath search paths in the "linking" section in the build settings. Finally, I removed and re-added Charts in the "Target Dependencies" section in the build phases.

I can confirm that adding ($SRCROOT) to the runpath search paths fixed it.

I never played with ($SRCROOT) on my side, all defaults. Looks like you customized a lot of things...

Haha yeah it looks like a one-off thing.
On Fri, Jul 24, 2015 at 3:45 PM Xuan<EMAIL_ADDRESS>wrote:

I never played with ($SRCROOT) on my side, all defaults. Looks like you
customized a lot of things...
—
Reply to this email directly or view it on GitHub
https://github.com/danielgindi/ios-charts/issues/237#issuecomment-124463135
.

Adding ($SRCROOT) to runpath search paths definitely fixes this problem, thank you very much for creating this issue.

you should copy the library to your project's dir and the pull the Charts.xcodeproj to your project . use "Embedded Binaries" to include the framework


The shown name of sub file doesn't contain its parent directory name on Properties dialog

Storage Explorer Version: 1.10.0
Build: 20190830.2
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 19.04/macOS High Sierra
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Expand one account -> File Shares node.
Create a new file share -> Create a new directory.
Go to the created directory -> Upload one file and one directory.
Check the name of file and directory on Properties dialog.

Expect Experience:
The file name contains its parent directory.
Actual Experience:
The file name doesn't contain its parent directory.

More info:
This issue doesn't reproduce for one ADLS Gen2 blob file.

By design. Since files are actually organized into directories, the actual name of the file is as shown.


Fix test postcode return journey

Fix returning user journey to work with test postcodes.
Based off changes in #268

Merged into #268

Merged into #268


Use KCQL batch size on MongoDB connector

Use batch size from KCQL in MongoDb rather than an extra setting.

Done


How to view notify message

Hi I'm fairly new to Cloud Custodian and I'm at the point of where I want to send out notifications via email and Slack of when things happen.
I created the below policy, but what I see on the SNS side is looks to be a Base64 decode and encrypted message. How do I decode this message?
policies:
- name: ec2-tag-compliance-mark
  resource: ec2
  comment: |
    Find all (non-ASG) instances that are not conformant
    to tagging policies, and tag them for stoppage in 1 days.
  filters:
    - "tag:aws:autoscaling:groupName": absent
    - "tag:maid_status": absent
    - or:
      - "tag:Requestor": absent
      - "tag:Department": absent
      - "tag:AppId": absent
      - "tag:AppName": absent
      - "tag:ProjectCode": absent
      - "tag:DataClass": absent
      - not:
        - type: value
          key: "tag:CostCenter"
          op: regex
          value: ^[0-9]{6}$
  actions:
    - type: mark-for-op
      op: stop
      days: 1
    - type: notify
      to:
        -<EMAIL_ADDRESS>      transport:
        type: sns
        topic: arn:aws:sns:us-east-1:123456789:custodian-test-tony
        region: us-east-1

its gzip and base64'd
serialize - https://github.com/capitalone/cloud-custodian/blob/master/c7n/actions.py#L462
deserialize - https://github.com/capitalone/cloud-custodian/blob/master/tools/c7n_mailer/c7n_mailer/sqs_message_processor.py#L76

I was able to decode and uncompress the message. Thanks.

Is there a setting where the message sent is not compressed?

use c7n_mailer if you want uncompressed message formatted for humans.


ResumePlayback "Malformed json"

Hey, when I'm trying to call the ResumePlayback method with contextUri and offset,  I'm getting an error object with the message "Malformed json". I tried it with example contextUri string and offset int from spotify developer portal (where it worked). I think the offset value is sent as "offset" : 5 and not "offset" : { "position" : 5 } but I'm not sure.

Next release will include the fix, should be today
Thanks for reporting 👍


Validation fails when calling fromJson on entity with relationships and additionalProperties=false

When calling fromJson, validation is invoked on passed data without adding relationship fields as valid supported properties, and expectedly fails.

Relations are converted into models and validated. That's expected.

@koskimas But how can one avoid getting failures in such a use-case? I presume it would be wildly wrong to have both field and relationship with the same name - but how can you pass validation otherwise?

From my understanding, validation should be done using enriched model schema, that would combine defined properties with defined relationships, which is not currently the case.

Maybe I misunderstood your issue. Could you write a code snippet that demonstrates the issue?

@koskimas See related commit with commented out code (https://github.com/kibertoad/objection.js/commit/1d0922aa79722d0c719bd586ec7add03fb52ed22) :). Basically validation is unnecessarily strict and considers relationship fields invalid when 'additionalProperties: false' is set.

@koskimas Here is a better overview that combines both commits: https://github.com/Vincit/objection.js/compare/master...kibertoad:fix/855-validating-relationships
I can also shorten the test to focus on just validation failing, if that would make it more readable :)

@koskimas So what is your conclusion on this, is it a legitimate issue? If yes, maybe it should be reopened?..

This seems like a legit bug. I'll fix it for the next patch release.


NTR: TAP complex binding

Hi,
From annotation review ticket (co-localizes_with complex terms): geneontology/go-annotation#1940
I need a term to indicate 'TAP complex binding' based on
PMID:17947644
(Molecular architecture of the TAP-associated MHC class I peptide-loading complex.)
Thanks,
Penelope

GO:0042825  TAP complex

Added in:
https://github.com/geneontology/go-ontology/pull/16317


test: add CI job to run multicluster demo

[HOLD] pending on AKS clusters setup
Signed-off-by: Allen Leigh<EMAIL_ADDRESS>
Description:
Add CI job to run bookbuyer -> bookstore test in multicluster mode.
There are several repository secrets need to be configured:

CTR_REGISTRY: docker image registry used by the job
CTR_REGISTRY_USER: registry username
CTR_REGISTRY_PASSWORD:  registry password
AKS_MULTICLUSTER_KUBECONFIG: kubeconfig file content, which configures cluster alpha and beta.

Two clusters, alpha & beta, will be created on AKS. CI job will run the multicluster demo, send requests to verify functionalities.

Affected area:

Functional Area

New Functionality
[ ]

Documentation
[ ]

Install
[ ]

CLI Tool
[ ]

Certificate Management
[ ]

Control Plane
[ ]

Ingress
[ ]

Egress
[ ]

Networking
[ ]

Observability
[ ]

SMI Policy
[ ]

Sidecar Injection
[ ]

Security
[ ]

Upgrade
[ ]

Tests
[X]

CI System
[ ]

Demo
[ ]

Performance
[ ]

Other
[ ]

Testing done:
Tested with private AKS clusters. CI passed on forked repo.

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project?

Did you notify the maintainers and provide attribution?

Is this a breaking change?

Codecov Report

Merging #3984 (91a9ab6) into main (f78e72f) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3984      +/-   ##
==========================================
- Coverage   67.48%   67.38%   -0.10%
==========================================
  Files         204      204
  Lines       11615    11615
==========================================
- Hits         7838     7827      -11
- Misses       3726     3737      +11
  Partials       51       51

Flag
Coverage Δ

unittests
67.38% <ø> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/crdconversion/crdconversion.go
59.78% <0.00%> (-11.96%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78e72f...91a9ab6. Read the comment docs.

Nightly job is tested on forked repo.
https://github.com/allenlsy/osm/actions/runs/1164703790

stale PR, closing


feat: add a new management api for secrets

What this PR changes/adds
This PR adds a new management API that enables to manage secrets from the vault.
Why it does that
In case of the connector is hosted on behalf of another entity, this entity might not have access to the underlying vault. In that case, this API can be used to add or remove secrets from the vault.
Linked Issue(s)
Closes #4090

I have one concern regarding a possible exploit this API opens.
As is, an ill intentioned actor can use this to mess with secrets that have been registered by the operator of the connector, and are necessary for its proper functioning (public/private certificates, idp releated secrets, ...).
Two proposals that come to mind are:

Adding a config that enables an operator of the connector to config the API so a prefix can be added to the secrets created by the it.
Adding the possibility to change the underlying vault directory where the secrets created by the API will be stored

I have one concern regarding a possible exploit this API opens. As is, an ill intentioned actor can use this to mess with secrets that have been registered by the operator of the connector, and are necessary for its proper functioning (public/private certificates, idp releated secrets, ...).

That is true for any other Management API as well. Malicious actors could easily nuke their connector deployment if they delete stuff they shouldn't.

Adding a config that enables an operator of the connector to config the API so a prefix can be added to the secrets created by the it.

not sure how that would help the supposed exploit

Adding the possibility to change the underlying vault directory where the secrets created by the API will be stored

Some powerful vault impls (Hashicorp Vault) support that, but some vaults, such as Azure KeyVault are more geared towards role-based-access-control, so there is no way that I know of to realize user-based access control on "subfolders".

That is true for any other Management API as well. Malicious actors could easily nuke their connector deployment if they delete stuff they shouldn't. Which is all the more reason to properly secure the Management API.

Isn't it a bit different? If someone who has access to the DMA mistakenly deletes a resource (i.e. asset or policy) its up to them to restore it. But if they are able to, say, delete the private certificate the connector uses to encrypt EDRs is a concern for the operator of said connector. At least from my point of view...

not sure how that would help the supposed exploit

If the SecretsApi always prefixes its keys, it is unlikely that a malicious actor can access non prefixed keys, only if the operator made the mistake to prefix them in the same way.

Isn't it a bit different? If someone who has access to the DMA mistakenly deletes a resource (i.e. asset or policy) its up to them to restore it. But if they are able to, say, delete the private certificate the connector uses to encrypt EDRs is a concern for the operator of said connector. At least from my point of view...

I don't think so, because if you give users access to a certain class of information, be they assets, policies or secrets, you're handing over full control. If an operational scenario requires that users have only read access to secrets, but write access should be blocked, that could be solved in the vault directly. Most vaults have some sort of RBAC.

If the SecretsApi always prefixes its keys, it is unlikely that a malicious actor can access non prefixed keys, only if the operator made the mistake to prefix them in the same way.

I may not be understanding this fully, but it sounds like a very brittle and insecure solution, that could easily be circumvented by guessing the secret alias, or looking at EDC code.

A few general remarks:

I think it should be called SecretsApi etc., i.e. using the plural, otherwise people could be mislead into thinking it's some sort of secret API
Please do not introduce domain relations (Secrets -> Assets) just out-of-hand. This is a more complicated topic, and one that must be discussed and designed first. If this is a requirement, then I suggest opening a scoped discussion first.
I would generally avoid transmitting stuff in the request URL. secret aliases are not secrets per se, but I wouldn't take any chances.
Please add an End-To-End Test. Feel free to take a look at the AssetApiEndToEndTest or the CatalogApiEndToEndTest etc. for an example.

Other comments inline.

Agree with all remarks.
They have been all processed as per last commit.

Codecov Report
Attention: Patch coverage is 17.15976% with 140 lines in your changes are missing coverage. Please review.

Project coverage is 19.06%. Comparing base (7f20ba5) to head (b8c55d8).
Report is 236 commits behind head on main.

Files
Patch %
Lines

...ontrolplane/services/secret/SecretServiceImpl.java
0.00%
31 Missing :warning:

...trolplane/services/secret/SecretEventListener.java
0.00%
25 Missing :warning:

...rg/eclipse/edc/spi/types/domain/secret/Secret.java
0.00%
14 Missing :warning:

...nsformer/edc/to/JsonObjectToSecretTransformer.java
0.00%
11 Missing :warning:

...or/api/management/secrets/SecretsApiExtension.java
0.00%
11 Missing :warning:

...se/edc/connector/secret/spi/event/SecretEvent.java
0.00%
9 Missing :warning:

...rmer/edc/from/JsonObjectFromSecretTransformer.java
0.00%
8 Missing :warning:

...anagement/secrets/validation/SecretsValidator.java
0.00%
5 Missing :warning:

.../edc/connector/secret/spi/event/SecretCreated.java
0.00%
5 Missing :warning:

.../edc/connector/secret/spi/event/SecretDeleted.java
0.00%
5 Missing :warning:

... and 6 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4138       +/-   ##
===========================================
- Coverage   71.74%   19.06%   -52.68%
===========================================
  Files         919     1001       +82
  Lines       18457    20428     +1971
  Branches     1037     1146      +109
===========================================
- Hits        13242     3895     -9347
- Misses       4756    16420    +11664
+ Partials      459      113      -346

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Isn't it a bit different? If someone who has access to the DMA mistakenly deletes a resource (i.e. asset or policy) its up to them to restore it. But if they are able to, say, delete the private certificate the connector uses to encrypt EDRs is a concern for the operator of said connector. At least from my point of view...

I don't think so, because if you give users access to a certain class of information, be they assets, policies or secrets, you're handing over full control. If an operational scenario requires that users have only read access to secrets, but write access should be blocked, that could be solved in the vault directly. Most vaults have some sort of RBAC.

If the SecretsApi always prefixes its keys, it is unlikely that a malicious actor can access non prefixed keys, only if the operator made the mistake to prefix them in the same way.

I may not be understanding this fully, but it sounds like a very brittle and insecure solution, that could easily be circumvented by guessing the secret alias, or looking at EDC code.

On top of what @paullatzelsperger mentioned, it is also worth emphasizing that such API will typically be exposed over the internet through an API gateway (such as Azure APIM) which gives you full freedom to create inbound policies for the incoming traffic so that only secrets with alias matching a given pattern can be updated, removed...

please add some end-to-end tests (as done in system-tests/management-api for the other endpoints

done

one wrong package, but good for me otherwise

fixed


"Perișoru" is listed in the drop-down menu

Description:
"Perișoru" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Perișoru" in the search bar.

Expected results
The location is listed in the drop-down menu as "Perișoru, Brăila (Ianca)".


Unable to pass array into constraint parameter

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Create a cluster, navigate to dashboard, enable OPA gatekeeper.
Create a constraint in form view with parameters
Key:
labels
Value:
["gatekeeper"]
Result:
Creation errors with:
K8sRequiredLabels.constraints.gatekeeper.sh "labels2" is invalid: spec.parameters.labels: Invalid value: "string": spec.parameters.labels in body must be of type array: "string"

https://github.com/rancher/dashboard/issues/378 Is this a dupe of https://github.com/rancher/dashboard/issues/378 ?

Closing in favor of #378


Add elasticsearch plugin implementation

Description
Added elasticsearch plugin implementation
Is this PR related with an open issue?
Related to Issue https://github.com/oceanprotocol/ocean/issues/171
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] Follows the code style of this project.
[x] Tests Cover Changes
[x] Documentation

Funny gif
https://i.imgur.com/enwWXbY.gif

TravisCI is missing an environment variable CODACY_PROJECT_TOKEN  so the build fails:
https://travis-ci.com/oceanprotocol/oceandb-elasticsearch-driver/jobs/147873160#L418-L437

tests/test_plugin.py ......                                              [100%]
========================== 6 passed in 15.98 seconds ===========================
py37 runtests: commands[2] | coverage report
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
oceandb_elasticsearch_driver/__init__.py       3      0   100%
oceandb_elasticsearch_driver/instance.py      20      1    95%
oceandb_elasticsearch_driver/plugin.py        40      0   100%
--------------------------------------------------------------
TOTAL                                         63      1    98%
py37 runtests: commands[3] | coverage xml
py37 runtests: commands[4] | python-codacy-coverage -r coverage.xml
2018-09-25 19:03:08,157 - ERROR - environment variable CODACY_PROJECT_TOKEN is not defined.
ERROR: InvocationError for command '/home/travis/build/oceanprotocol/oceandb-elasticsearch-driver/.tox/py37/bin/python-codacy-coverage -r coverage.xml' (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   py37: commands failed
The command "tox" exited with 1.
Done. Your build exited with 1.

Ooooh, didn't know that, we'll see how we work around that:

Pull requests sent from forked repositories do not have access to encrypted variables or data.

https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

Hi @montanaflynn , I have disabled codacy in .travis.yml (master branch). I think if you pull this change to your fork and run again, should works.

Thanks @kremalicious and @aaitor, I merged latest master, added docstrings and more tests.
Tests are passing now and code coverage is at 99%! Please review and let me know if it can be merged.

Thanks @montanaflynn.  We have started the review of this PR and will comment here once the review is completed.


Cypress tests failing

There are some current PR where travis fails the Cypress tests.
I've tried locally and I can replicate the fails. They're related to the scaling of images performed in kitconcept.volto.
I've got as far as:
In cypress/support/commands there's a sample image, exposed as base64-encoded data. When decoding some of its first characters,  iVBORw0KGgoAAAANSUhEUgAAANcAAAA4CAMAAABZsZ3QAAAAM1BMVEX29fK42OU, we get this valid PNG header: PNG...IHDR8Y3PLTE. The problem is that the data in kitconcept.volto is missing some of the beginning characters:
@(Pdb) xx = data.read()
@(Pdb) p xx[:10]
b'hEUgAAANcA'

In the CGI storage of the request, the file data is ok, but base64 encoded: aVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FBQU5j QUFBQTRDQU1BQUFCWnNaM1FBQUFBTTFCTVZFWDI which decodes to iVBORw0KGgoAAAANSUhEUgAAANcAAAA4CAMAAABZsZ3QAAAAM1BMVEX2 which decodes to PNG...IHDR8Y3PLTE.
So it looks like there's some bits that are lost in kitconcept.volto. Maybe a file being read without seek(0) ?

@tiberiuichim I just started to look into this myself. Maybe we should just add a new base64 encoded png to kitconcept.volto to fix this.

@tiberiuichim I accidentally added a new Cypress test in a release commit which started the master branch to fail. I removed it and now master is green again.

Probably closed by https://github.com/plone/volto/pull/1823


Position not honored if existing toasts are displayed

Even if you pass in overrideOptions with a different position, the toasts will show up using the position of any existing visible toasts.  Looking at the attached image, you can reproduce on the demo page by:
1.)  Keep all default options (top right position) and click "Show Toast" 3 times
2.)  While previous 3 toasts are still visible, Change position to bottom right and click "Show Toast: 3 more times.
Expected result: 3 toasts at top right, 3 toasts at bottom right
Actual result: 6 toasts top right.

This is actually working as designed. The toastr container doesn't move while it has visible toasts in it. However, if there are no visible toasts then the container will move around.
Example here: https://vid.me/zOJo

Is there a workaround to get this working as I described?

You can clear all of the visible toasts off the screen, which would in turn clear the container and allow it to be repositioned.


ACMS-2479: [DevDocs] update externally facing documentation for the n…

…ew T&C

updated affected pages

Purpose of this pull request
This pull request (PR) uses the new links for the terms & conditions applicable to the Marketplace DevPortal.
Affected pages

https://developer.adobe.com/commerce/marketplace/guides/sellers/account-setup-process/
https://developer.adobe.com/commerce/marketplace/guides/sellers/developer-register/

also includes an updated image of the pop-up

Note: After this PR is reviewed, these changes can get published immediately.  The new terms & conditions that this PR uses already exist. 👍


 Syntax like [Prefix @fig:1] and [-@fig:1] breaks.

This is a result of mdbook-pandoc using pulldown-cmark-to-cmark to render parsed Markdown back to text:
#[test]
fn square_brackets() {
    let input = "[Prefix @fig:1] [-@fig:1]";
    let parsed = pulldown_cmark::Parser::new(input);
    let mut output = String::new();
    pulldown_cmark_to_cmark::cmark(parsed, &mut output).unwrap();
    assert_eq!(output, "\\[Prefix @fig:1\\] \\[-@fig:1\\]");
}

In order for your example to work, pulldown-cmark-to-cmark would have to leave the square brackets as-is. It looks like https://github.com/Byron/pulldown-cmark-to-cmark/pull/71 actually adds support for this in the form of an alternative formatting function, I can try it out once it merges and they publish a new release.
However, since the new function that preserves escapes is opt-in, it's likely that other mdbook preprocessor would still break your use case. In general, mdbook-pandoc does not aim to support all of Pandoc's features for mdbooks--it's focus is to support mdbook's mostly-Commonmark Markdown spec. Some Pandoc extensions might work "for free", but others like this one may not.

Hi @aiwell-ac5000, can you verify that #95 supports your use case?
cargo install --git https://github.com/max-heller/mdbook-pandoc.git --branch escapes mdbook-pandoc

Can confirm that it worked.


Ssl wrapper merge

@akallabeth nice that you are taking on to this \o/.
Generally you PR looks good to me however in some places no error checking is done anymore after the move to the winpr functions.

@bmiklautz True, will adjust the API.

Wow that's a very nice job. There's my 2 non-blocking nitpicking remarks but +1.

@akallabeth since this PR is already merged you might want to fix the errors in TestCryptoHash.c in your PR #3171


enable default-ip-family on dual-stack mode

Pull Request Description
Describe what this PR does / why we need it

enable default-ip-family on dual-stack mode
only return IPv4Only if dualstack not enabled
skip webhook validation on host-networking pods

Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report

Merging #223 (101827d) into main (0c51b7a) will decrease coverage by 0.29%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
- Coverage   27.71%   27.41%   -0.30%
==========================================
  Files          23       23
  Lines        1656     1674      +18
==========================================
  Hits          459      459
- Misses       1145     1163      +18
  Partials       52       52

Flag
Coverage Δ

unittests
27.41% <0.00%> (-0.30%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/ipam/types/constants.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c51b7a...101827d. Read the comment docs.


Best practices

Look over https://github.com/rabbitmq/rabbitmq-cli/tree/master/lib and extract best practices for CLI tools to annonktl.

Adapt DocOpt http://docopt.org/


Refactoring Account object

In this change list, the Account object is refactored and the interfaces are removed.
Also state_cache has minor changes in order to keep a copy of account structure not the pointer. It is more safe because any further changes in account object  won't affect the state cache unless it gets update again.

Thanks @b00f I think I like the direction this is going. I don't have time for a full review today so thought I'd dump a couple of things:

You'll need to make the integration tests pass make test_integration before we can merge. Before you do that make sure we've got the model right.

I like the KISS of *Account, however I do not want to lose the immutability when accounts are passed to objects that should not mutate them. I would like some kind of read-only interface, for example we could do something like: https://github.com/hyperledger/burrow/blob/develop/blockchain/blockchain.go#L36-L44. I think we can dump MutableAccount though I prefer just using *Account

Also needs a rebase now

I merged it (not rebase)  with the latest changes.
Unfortunately I couldn't find out why the integration tests are failed. Could you please check it.

@b00f a bunch of things have recently been in flux at the integration level but are slowly stabilizing. Can you do a full rebase against current develop and push. It would be good to make sure you're changes are ran against an integration test we know is working rather than one that is in flux.

I am working on refactoring test. So let me finish it then I will rebase this changes. The tests made me crazy.


Horizontal viewport was given unbounded height.

I am trying to convert one native android application into flutter to make it support for iOS and web. I have created and make application as per requirement but I am facing issue at one page and it's home page of application. Its preview can be available here (Click Here).
I am using latest flutter Sdk in my application which is mention as: sdk: ">=2.7.0 <3.0.0"
Here, I am facing issue while I am reach at Home page of my flutter app which is quite common issue but I am not be able to find that issue as I have try all the issue which has given the solutions on StackOverflow, Medium, & Github.
My error is as below:
======== Exception caught by rendering library =====================================================
The following assertion was thrown during performResize():
Horizontal viewport was given unbounded height.
Viewports expand in the cross axis to fill their container and constrain their children to match their extent in the cross axis. In this case, a horizontal viewport was given an unlimited amount of vertical space in which to expand.
The relevant error-causing widget was:
ListView file:///D:/Development/Workspace/Flutter/Sosho_Flutter/sosho/lib/ui/page/home_page.dart:206:24
I have posted this issue on StackOverflow with the code which I have done for this page. Please check that here.
I am also seeing that this page occupy more memory while opening and when views are shown in listing of products.
Please help me to resolve this issue.

Hi @HEMAL-PATEL
Looks like you're trying to use horizontal list view in a column, hence the error
════════ Exception caught by rendering library ═════════════════════════════════
The following assertion was thrown during performResize():
Horizontal viewport was given unbounded height.

Viewports expand in the cross axis to fill their container and constrain their children to match their extent in the cross axis. In this case, a horizontal viewport was given an unlimited amount of vertical space in which to expand.
The relevant error-causing widget was

The workaround, you need to a fixed size for horizontal view

code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: Column(
          children: [
            Container(
              height: 300,
              child: ListView.builder(
                itemCount: 10,
                scrollDirection: Axis.horizontal,
                itemBuilder: (BuildContext context, int index) {
                  return Image.network('https://i.imgur.com/QCNbOAo.png');
                },
              ),
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

This should be addressed by https://github.com/flutter/flutter/issues/73786
Closing a duplicate
Thank you


Stop condition evaluation on first failure

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Related tickets
N/A

Documentation
if this is a new feature, link to pull request in https://github.com/php-http/documentation that adds relevant documentation

License
MIT

What's in this PR?
The &= operator will convert the value to an integer (see some examples here: https://stackoverflow.com/questions/17553004/boolean-assignment-operators-in-php) which causes the condition evaluation to not stop on the first failure, as otherwise noted.
Why?
Discovery for a specific adapter should not continue if any condition fails.
Checklist

[x] Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
[] Documentation pull request created (if not simply a bugfix)

To Do

[ ] If the PR is not complete but you want to discuss the approach, list what remains to be done here

Thank you.
Could you write a test for this?

i think the change in the loop should not be required, because we abort the loop as soon as a condition is not met.

sorry, scrap that part of my comment. missed the part that &= converts to integer. but i think the early return would make the code easier to read.

Thank you @dbu and @k4emic


[REQUEST]: a few more daily wind & precipitation iids

List of requested idds
'CMIP6.ScenarioMIP.CSIRO-ARCCSS.ACCESS-CM2.ssp585.r1i1p1f1.day.pr.gn.v20210317',
'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r4i1p1f1.day.sfcWind.gn.v20210318',
'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r6i1p1f1.day.sfcWind.gn.v20210318',
'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r4i1p1f1.day.pr.gn.v20210318',
'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r10i1p1f1.day.pr.gn.v20210318',
'CMIP6.CMIP.MRI.MRI-ESM2-0.historical.r2i1p1f1.day.pr.gn.v20190603',
'CMIP6.CMIP.MRI.MRI-ESM2-0.historical.r3i1p1f1.day.pr.gn.v20190603',
'CMIP6.CMIP.MRI.MRI-ESM2-0.historical.r4i1p1f1.day.pr.gn.v20190603',
'CMIP6.CMIP.MRI.MRI-ESM2-0.historical.r5i1p1f1.day.pr.gn.v20190603',

Description
Kind request to add a few final iid's before submitting the compound flooding paper

The way I have the recipe setup currently should already expand these out if available.
Checking the recent logs confirms that the first iid here is indeed parsed out. Diagnosing what happens on the pangeo-forge-esgf side (gist) indicates that we can find urls for the following subset of iids requested here:
['CMIP6.ScenarioMIP.CSIRO-ARCCSS.ACCESS-CM2.ssp585.r1i1p1f1.day.pr.gn.v20210317',
 'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r4i1p1f1.day.sfcWind.gn.v20210318',
 'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r6i1p1f1.day.sfcWind.gn.v20210318',
 'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r4i1p1f1.day.pr.gn.v20210318',
 'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r10i1p1f1.day.pr.gn.v20210318']

but they are clearly not in the catalog...
hmmm, this is strange.

I have made a dummy PR to get a bit more manageable logs for these particular iids.

Ok so the culprit here is that these particular iids are being removed, since they already exist in the 'original' catalog.
Updated gist.
Could you double check if those stores are useable? If not we could remove them from the original catalog which should trigger a rebuild here.

I can load these datasets from the 'original' catalog, but the datasets get filtered out because they are incomplete (at least the one I checked just now, CMIP6.ScenarioMIP.CSIRO-ARCCSS.ACCESS-CM2.ssp585.r1i1p1f1.day.pr.gn.v20210317), possibly due to #53? That may mean that if a complete dataset for this iid would be added through pangeo-forge-esgf, it may be removed anyway?

I just ran
import intake

def zstore_to_iid(zstore: str):
    # this is a bit whacky to account for the different way of storing old/new stores
    iid =  '.'.join(zstore.replace('gs://','').replace('.zarr','').replace('.','/').split('/')[-11:-1])
    if not iid.startswith('CMIP6'):
        iid =  '.'.join(zstore.replace('gs://','').replace('.zarr','').replace('.','/').split('/')[-10:])
    return iid

def search_iids(col_url:str):
    col = intake.open_esm_datastore(col_url)
    iids_all= [zstore_to_iid(z) for z in col.df['zstore'].tolist()]
    return [iid for iid in iids_all if iid in iids_requested]

iids_requested = [
'CMIP6.ScenarioMIP.CSIRO-ARCCSS.ACCESS-CM2.ssp585.r1i1p1f1.day.pr.gn.v20210317',
'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r4i1p1f1.day.sfcWind.gn.v20210318',
'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r6i1p1f1.day.sfcWind.gn.v20210318',
'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r4i1p1f1.day.pr.gn.v20210318',
'CMIP6.ScenarioMIP.CSIRO.ACCESS-ESM1-5.ssp585.r10i1p1f1.day.pr.gn.v20210318',
'CMIP6.CMIP.MRI.MRI-ESM2-0.historical.r2i1p1f1.day.pr.gn.v20190603',
'CMIP6.CMIP.MRI.MRI-ESM2-0.historical.r3i1p1f1.day.pr.gn.v20190603',
'CMIP6.CMIP.MRI.MRI-ESM2-0.historical.r4i1p1f1.day.pr.gn.v20190603',
'CMIP6.CMIP.MRI.MRI-ESM2-0.historical.r5i1p1f1.day.pr.gn.v20190603',
]

url_dict = {
    'qc':"https://storage.googleapis.com/cmip6/cmip6-pgf-ingestion-test/catalog/catalog.json",
    'non-qc':"https://storage.googleapis.com/cmip6/cmip6-pgf-ingestion-test/catalog/catalog_noqc.json",
    'retracted':"https://storage.googleapis.com/cmip6/cmip6-pgf-ingestion-test/catalog/catalog_retracted.json"
}

iids_found = []
for catalog,url in url_dict.items():
    iids = search_iids(url)
    iids_found.extend(iids)
    print(f"Found in {catalog=}: {iids=}\n")

missing_iids = list(set(iids_requested) - set(iids_found))
print(f"\n\nStill missing {len(missing_iids)} of {len(iids_requested)}: \n{missing_iids=}")

And get that all datasets are available 🎉.
Some of them landed in the retracted catalog though. Let me know if you want to add newer versions.


Fix node build

Goal
The process require is breaking the node build script as browserify can't find this module
I'm still not sure why this started breaking, but the require should be unnecessary anyway as process is a global

Slightly disconcerting. Would be ideal if we could understand what's going wrong here… maybe the browser-compatible process from npm was installed in the root node_modules before, but isn't now due to a dependency change?

There's a process in node_modules on next and this branch, so I don't think that's it 😕


DNS Example

Add your info here

The name server process uses these files to tell the rest of the Internet about your machines. If you add a new machine, or if you change the IP address of a machine, you have to change the corresponding file. After having edited one or more files, you must restart the "named" process. Don't forget to update the serial number in every zone file you edit.

I done my


fix: increase N_max in Zeromorph

To avoid edge case in batch_mul of vanilla Ultra we temporarily switched to naive muls in the folding recursive verifier circuit arithmetised with Ultra which causes an increase by a factor of 2. Hence we need to increase the maximum size of a circuit that can be proven with Zeromorph.

Benchmark results
Metrics with a significant change:

batch_insert_into_append_only_tree_32_depth_ms (512): 316 (+18%)
batch_insert_into_append_only_tree_32_depth_ms (1024): 608 (+21%)
batch_insert_into_append_only_tree_32_depth_ms (2048): 1,193 (+21%)
batch_insert_into_append_only_tree_32_depth_ms (4096): 2,358 (+21%)
batch_insert_into_indexed_tree_20_depth_ms (512): 455 (+21%)
batch_insert_into_indexed_tree_20_depth_ms (1024): 891 (+21%)
batch_insert_into_indexed_tree_20_depth_ms (2048): 1,772 (+21%)
batch_insert_into_indexed_tree_20_depth_ms (4096): 3,532 (+20%)
circuit_witness_generation_time_in_ms (base-rollup): 9,115 (+19%)
circuit_proving_time_in_ms (public-kernel-app-logic): 418 (-16%)
circuit_proving_time_in_ms (merge-rollup): 2,919 (-21%)
node_history_sync_time_in_ms (5): 18,262 (+19%)
node_history_sync_time_in_ms (10): 33,731 (+19%)
l2_block_processing_time_in_ms (8): 1,618 (+19%)
l2_block_processing_time_in_ms (32): 6,052 (+19%)
l2_block_processing_time_in_ms (64): 11,996 (+19%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
740
740
740

l1_rollup_calldata_gas
6,680
6,668
6,680

l1_rollup_execution_gas
586,865
586,853
586,865

l2_block_processing_time_in_ms
:warning: 1,618 (+19%)
:warning: 6,052 (+19%)
:warning: 11,996 (+19%)

l2_block_building_time_in_ms
24,932 (+5%)
98,264 (+6%)
195,218 (+5%)

l2_block_rollup_simulation_time_in_ms
24,761 (+5%)
97,656 (+6%)
194,034 (+5%)

l2_block_public_tx_process_time_in_ms
10,065 (+6%)
39,618 (+7%)
78,761 (+7%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
:warning: 18,262 (+19%)
:warning: 33,731 (+19%)

node_database_size_in_bytes
22,896,720
39,473,232

pxe_database_size_in_bytes
29,868
59,425

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes
circuit_witness_generation_time_in_ms
circuit_proving_time_in_ms
circuit_proof_size_in_bytes

private-kernel-init
130 (+4%)
18,212
41,446
N/A
N/A
N/A

private-kernel-inner
362 (+2%)
66,727
41,446
N/A
N/A
N/A

private-kernel-reset
619 (+4%)
210,456
41,446
N/A
N/A
N/A

private-kernel-ordering
357 (+1%)
61,368
55,522
N/A
N/A
N/A

base-parity
8.15 (+4%)
128
64.0
304 (+11%)
12,632 (-5%)
2,208

root-parity
51.4 (+6%)
27,064
64.0
227
153,992 (-15%)
2,720

base-rollup
711 (+7%)
111,094
925
:warning: 9,115 (+19%)
139,594 (-13%)
3,104

root-rollup
72.7 (+13%)
11,454
789
195 (+3%)
15,406 (-8%)
3,424

public-kernel-app-logic
135 (+4%)
68,697
59,431
294 (-13%)
:warning: 418 (-16%)
73,024

public-kernel-tail
467 (+4%)
174,138
7,691
469 (-3%)
397 (-7%)
10,112

public-kernel-setup
110 (+4%)
68,697
59,431
303 (+3%)
516 (+4%)
73,024

public-kernel-teardown
114 (+5%)
68,697
59,431
316 (+9%)
400 (-4%)
73,024

merge-rollup
6.76 (+5%)
2,696
925
148 (-6%)
:warning: 2,919 (-21%)
3,104

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
13.1 (+18%)
21.4 (+20%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.7
31.8
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.767 (+19%)
0.661 (+20%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
61.9 (+20%)
97.2 (+19%)
:warning: 316 (+18%)
:warning: 608 (+21%)
:warning: 1,193 (+21%)
:warning: 2,358 (+21%)
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
95.9
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.634 (+20%)
0.602 (+19%)
0.575 (+18%)
0.569 (+21%)
0.566 (+21%)
0.564 (+21%)
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
73.4 (+20%)
144 (+21%)
:warning: 455 (+21%)
:warning: 891 (+21%)
:warning: 1,772 (+21%)
:warning: 3,532 (+20%)
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
106
208
692
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.644 (+20%)
0.647 (+21%)
0.621 (+21%)
0.614 (+21%)
0.616 (+21%)
0.616 (+21%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
80.6 (+20%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
108

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.709 (+21%)

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
58,427
1,049,033

Transaction size based on fee payment method
| Metric |  |
| - |  |
Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
2,650 (+5%)
2,803 (+6%)
7,113 (+7%)

Metric
0 public data writes
1 public data writes
2 public data writes
4 public data writes
8 public data writes

tx_sequencer_processing_time_ms
715 (+5%)
986 (+5%)
1,059 (+7%)
1,976 (+8%)
1,253 (+8%)


Passing props to custom component?

For reference, I'm using<EMAIL_ADDRESS>and<EMAIL_ADDRESS>I want to register a custom component for my table (<DownloadLink />). I'm modeling it after the custom link component in the docs. However no matter what I try, I keep getting the error "Warning: Unknown props rowData, metadata on  tag. Remove these props from the element." Is the problem possibly related to the fact that I'm trying to pass an array to my custom component?
What follows are a list of things I've noticed and/or tried....
Tried

Using both class DownloadLink extends Component and var DownloadLink = React.createClass
using a customComponentMetadata key in my columnMetadata array (as per this suggestion)
Separating the components into different files and keeping them in one file
Making <Griddle //props... /> the component ReactDom renders instead of <App />.

Noticed

When I inspect the example tables on the docs with react devtools, the <GridTable /> component and props.columnMetadata[1].customComponent are both of type: Constructor(). When my app is rendered, they're both of type: fn().
My <DownloadLink /> component is grey in the devtools whereas the example component is purple (which I guess means it's working?).

Any advice/help would be great because aside from this it's exactly what I need! Thanks!

This issue on react-datepicker may shed some light on this. I'm not really sure how to go about figuring out how it would impact the griddle code though.

Does this help?
https://facebook.github.io/react/warnings/unknown-prop.html
I think it explains the strategies for fixing this warning.

@gaearon Thanks! I think this is the issue. When I get to work tomorrow I'll dig into it. Basically I think griddle is setting those props implicitly. Perhaps if I can figure out how to pass them explicitly the warning will go away.

It turns out that there are a couple "rules" it's helpful to be aware of when working with custom components.

Custom components need to be in the same file as the Griddle table. They can't be imported or required.
They need to come before the columnMetadata variable. If it's after, columnMetadata won't know what you're trying to render.
Don't put quotes around them in the columnMetadata variable. If you do, React will try to render the component but it will stop and the error above will be thrown.

Here is a gist to demonstrate.
Thanks @ryanlanciaux for taking a look at this! Griddle's a great project!

Thanks so much for digging into this a bit more @aberkow and thanks for the pointers @gaearon!
This gist is a pretty great demonstration of the current settings. We're hoping with the stuff we've been doing in 1.0 this sort of customization will be way easier and more inline with how people are used to doing things in the React ecosystem.
 I really like this component. The api is much easier for me to understand than a lot of the others. I'll be watching for v1.0 :-)

Did everything that @aberkow told but still couldn't access props in my customComponent

@kalpanaideas2it at the time I wrote that gist, griddle was around v0.7. Are you using v1? Perhaps that's the difference. I haven't had an opportunity to use v1 yet though. Do you have a repo or some code to share?


Create a Google test suite tutorial and guide the team through the process

The google test suite proved to be a hassle to set up with SDL2, so instead Chris is going to find an alternate meethod to just create a few tests for the program.


fix path.join windows issue

#13

The latest updates have not been released to npm yet. Did you install it from GitHub?

yes

Ok cool. Thank you for the PR. We'll try and get a release out soon.


correct readme method to spied

Thank you, I really appreciate your PR! LGTM!

It's you that is to be thanked! Keep the awesome work and I'm sure people will keep contributing!

Thank you :)


crossplane: referencer and selector fields generation

This PR is migrated from https://github.com/aws/aws-controllers-k8s/pull/643
Description of changes: Crossplane uses two additional fields for the ones that can be referenced by another CRD - Reference and Selector. This PR allows users to enter the type of the referenced object so that we automatically generate these fields. The type information is necessary for the resolver but since we're not yet generating it, only the existence of a value in referenced_type is used. When we generate the resolver code, we'll need type information as well.
One caveat is that any field on the CR (including the ones in types.go) could be a candidate as a reference field but from what I can tell, we are only able to address the top level fields in Config object. For now, that will be a limitation we'll live with.
Fixes https://github.com/crossplane/provider-aws/issues/484
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Coming back to this, I think it provides little value because of the fact that it's not able to add the ref/selector fields to types in types.go. So, I'll close this PR and open a new one in the future when this becomes possible.


[bug] ActiveStorage attachments no longer working

When attempting to add an ActiveStorage attachment via Motor Admin we are seeing the following failure:

This seems to be a regression from previous versions.
https://user-images.githubusercontent.com/337808/137543717-1dce1041-5b9a-4827-8206-aefec4958f1f.mp4

@drewbaumann I figured out how to reproduce the issue - it was broken when creating an attachment via association (didn't test it in the first place but tested the form from the root table).
The fix has been released in the newest version, thanks for reporting the bug!
https://rubygems.org/gems/motor-admin/versions/0.2.10


Cannot use Vault with Netty4ClientHttpRequestFactory

Netty4ClientHttpRequestFactory does not write the Content-Length header when sending POST requests using RestTemplate. Vault responds with Status 400 in such cases.

See also https://github.com/spring-cloud-incubator/spring-cloud-vault-config/issues/19


[Camel 3.7] Camel main autowire properties by type has been removed

Relates to https://issues.apache.org/jira/browse/CAMEL-15826.
It breaks a number of itests that rely on component options being auto configured. E.g the ElasticSearch REST client, JMS ConnectionFactory, Infinispan cache, ValidationFactory etc.
I have worked around the problem to get the camel-master branch building again. Ideally we need to get following issue solved in time for Camel 3.7.0 GA:
https://issues.apache.org/jira/browse/CAMEL-15836
Some more info here:
https://camel.zulipchat.com/#narrow/stream/257298-camel/topic/Main.20autowire.20by.20type

It was added back with a new feature where you mark the options that can be autowired

I'll close as this is now working again on the camel-master branch.


compilation error in basicapp

the code in line 128 (Block9 to block10) doesn't compile

Pre-submit checklist:

Branch

[ ] Commit sequence broadly makes sense
[ ] Key commits have useful messages
[ ] Relevant tickets are mentioned in commit messages

PR

[ ] Self-reviewed the diff
[ ] Useful pull request description
[ ] Reviewer requested

If you updated any cabal files or added Haskell packages:

[ ] nix-shell shell.nix --run updateMaterialized to update the materialized Nix files
[ ] Update hie-*.yaml files if needed

If you changed any Haskell files:

[ ] nix-shell shell.nix --run fix-stylish-haskell to fix any formatting issues

If you changed any Purescript files:

[ ] nix-shell shell.nix --run fix-purty to fix any formatting issues

Pre-merge checklist:

[ ] Someone approved it
[ ] Commits have useful messages
[ ] Review clarifications made it into the code
[ ] History is moderately tidy; or going to squash-merge

https://playground.plutus.iohkdev.io/ is running an older version of the playground, where the writer type argument () isn't needed. The version on master has is newer and the type signature is correct. That's why the PR fails also.

I see, Thanks for your comment. I wish the doc was sync with the live playground, it is confusing now.


bug: WKWebView blocks Tabs during momentum-scroll

Type: bug
Ionic Version: 2.x
Platform: ios 9 webview
Tested with WKWebView Plugin:
https://github.com/Telerik-Verified-Plugins/WKWebView
WKWebView changed scrolling events so that even when momentum-scrolling is active, scroll events are fired. This seems to block any other interaction (e.g. switching to another tab) while momentum-scrolling is active.

This may be an unsolvable issue for the time being. We'll keep looking for solutions and working on it. Thanks


[UI Update] Changed the UI of Contact Us page to match the UI of the site ✨

PR Description:
This PR addresses issue https://github.com/jahnvisahni31/DesignDeck/issues/97 by improving the design of the contact us page and fixed weird font sizing of "Open Menu" button in NavBar for a cleaner and more interactive user experience.
Key Changes:
Contact Us Page

Added hover effects including color changes, underline effects, and animations for smoother interactions.
Enhanced alignment and spacing for a more polished look.
Added Illustration to enhance UI aesthetics.

Changed the weird font sizes in Navbar and made all options similar.
Before:

After:

These updates aim to make the UI more visually appealing and user-friendly.

@jahnvisahni31, kindly assign labels in this PR for gssoc-ext, hacktoberfest level2 so It will count to my contributions. Thanks in advance.

@jahnvisahni31, kindly assign the labels for this PR for gssoc-ext and hactorberfest level 3 so it will count toward my contributions.


Bounty doesn't pay out correctly

(Pointed out by @redsquirrel.)
function claimBounty(BrokenToken target) {
  if (owners[target] != 0 && target.totalSupply() > target.balance) {
    totalBounty = 0;
    claimed = true;
    if(!owners[target].send(totalBounty)) throw;
  }
}

The totalBounty is zeroed, but then used in the .send(), meaning the bounty will pay out zero.

Peter, I'm building over this Bounty idea and also noticed this problem with payout.
I have another question: any reason you track the bounty with the totalBounty state variable instead of using the contract's this.balance?
Thank a look at my current version: https://github.com/OpenZep/zep-solidity/blob/master/contracts/Bounty.sol


Fix Unknown Encoding issue

This fixes #23 and makes the following modification:

@encoding can be set to external_encoding. Previously, it ignored external_encoding.

To me, it looks like the encoding option is usually ignored. CSV.read|CSV.open will use the encoding options provided by a user if:

the user passes in an IO-like object where respond_to?(:internal_encoding) == true && (io.internal_encoding || io.external_encoding).nil?
the user passes in a StringIO-like object where the string has no encoding.
the user passes in an IO-like object whererespond_to?(:encoding) == true && io.encoding.nil?

As far as I know, the above situations can only occur if the user is passing in a custom IO object
that doesn't have encoding information. This analysis is based off of the raw_encoding method
def raw_encoding(default = Encoding::ASCII_8BIT)
  if @io.respond_to? :internal_encoding
    @io.internal_encoding || @io.external_encoding
  elsif @io.is_a? StringIO
    @io.string.encoding
  elsif @io.respond_to? :encoding
    @io.encoding
  else
    default
  end
end

Thanks for your work but I've fixed it.
Because we need more new separated tests for this case instead of changing existing tests.


Enable HOMEBREW_BOOTSNAP for developers

Enable it by default if you've run a developer command or set HOMEBREW_DEVELOPER.
Clarify the documentation that there's various configuration in which it doesn't work.

I've rolled this out of most of GitHub's developers with no ill effects and we've enabled it in both CI and for various maintainers so it feels appropriate to have a bigger rollout. @Homebrew/brew: any thoughts?

Review period will end on 2021-02-24 at 09:35:27 UTC.

I've just experimented with it:

it doesn't speed up the most common operation for mer, which is brew up (360 ms on my system, with or without HOMEBREW_BOOTSNAP, when I'm already up-to-date)
brew config goes down from 0.8 s to 0.6 s
brew ls goes down from 0.55 s to 0.35 s
brew cleanup (with nothing to clean up) goes up from 1.0 s to 1.2 s

it doesn't speed up the most common operation for mer, which is brew up (360 ms on my system, with or without HOMEBREW_BOOTSNAP, when I'm already up-to-date)
brew cleanup (with nothing to clean up) goes up from 1.0 s to 1.2 s

These are IO bound and brew cleanup removes the existing bootsnap cache.

brew config goes down from 0.8 s to 0.6 s
brew ls goes down from 0.55 s to 0.35 s

The speedup here is mostly due to speeding up require pretty dramatically.

Review period ended.

Just as a FYI: https://github.com/Homebrew/discussions/discussions/923
(I think it might be fixable with some SDKROOT stuff, but I need more information on their setups first.)

Actually maybe we should have a DevelopmentTools.installed? check here. I suspect maybe they are running without them (since ARM macOS updates delete the CLT).

@Bo98 https://github.com/Homebrew/brew/pull/10694


[PopupMenu] Expose missing item properties to the editor inspector.

Adds missing item properties to the dynamic property list, most notably submenu and shortcut, absence of which is extremely inconvenient.

Maybe it should be limited to only what is really necessary.

I would keep it all, but add collapsed "Advanced" group, but seems like groups aren't currently supported for items.


feat(useFavicon): port useFavicon from react-use

What new hook does?
Checklist

[x] Have you read contribution guideline?
[ ] Does the code have comments in hard-to-understand areas?
[ ] Is there an existing issue for this PR?

#33

[x] Have the files been linted and formatted?
[x] Have the docs been updated?
[x] Have the tests been added to cover new hook?
[x] Have you run the tests locally to confirm they pass?

@septs If the pull request is merged/accepted, could you please add the hacktoberfest-accepted label?

I noticed that this PR is quite old, so I figured it was time to give it some love.
I went over this PR and fixed things that needed to be fixed in order for this to be merged (added missing documentation, improved example, refactored code a little). Let's review this and get this one merged!

Ah, about this one. i'm still making my mind, but tupping to decision not to implement hooks that modify  contents since it is more complicated that just throwing elements there. There is a better library called react-helmet and react-helmet-async doing this job pretty well, and, in most cases, even better and in more versatile than any hook possible.

Ah, about this one. i'm still making my mind, but tipping to decision not to implement hooks that modify contents since it is more complicated that just throwing elements there. There is a better library called react-helmet and react-helmet-async doing this job pretty well, and, in most cases, even better and in more versatile than any hook possible.

Just had a look at react-helmet-async, and fair enough, there seems to be more to the SSR side than I imagined.
Could you write your thoughts like this to the pull requests in the future? That way we would all be on the same page and unnecessary work could be avoided.
Should we close this one then and add a mention to the docs that this one will not be implemented?

but tipping to decision not to implement hooks that modify  contents

What are going to do with useDocumentTitle then? Deprecate it or keep it?

this hook has to be rejected
we have to remove hooks modifying <head> contents (yes, it is a breaking change)
we have to add clarification on migration guide (docs) with suggestions to use react-helmet or react-helmet-async
we have to add clarification notes to issue with migration list

this hook has to be rejected
we have to remove hooks modifying <head> contents (yes, it is a breaking change)
we have to add clarification on migration guide (docs) with suggestions to use react-helmet or react-helmet-async
we have to add clarification notes to issue with migration list

Sounds good!

:tada: This issue has been resolved in version 18.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[Bug]: Status check for run_ci github action is not running, "Expected — Waiting for status to be reported"

Describe the bug
I expected that the status check would run on every commit for all open PRs. However none of them have been executed. Instead the response is ""Expected — Waiting for status to be reported". As a result status checks have been disabled for now.

To Reproduce
Create a PR and make a commit once status checks are re-enabled and check to see if the github action was run.

If you directly branch off the openadapt repo(not off your forked repo), the status checks do run, and you will notice either a ✅ or ❌ indicating whether the status check passed or not.
See below for an ex:


Clarified error message

e.g. If some dependencies is missing, the hModule is also NULL

Maybe we should add some additional information like an indication that the API only supports AHK Ansi 32 Bit since many applications are written in AHK

Maybe just as comment?
So normal users don't get some weird message with special terms like "ANSI".

You are right. The API should not stick to any programming language.
I think, that we don't need this comment, because nobody would take a look into the source code :)


[2.10] Latest tests security analytics

Description
Latest tests in security analytics plugin
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ruanyl Any idea why the tests are taking so long to run?
Also, can you please review the changes, need them for the 2.10 release

@amsiglan should this backport to main?


Missing pretty-formats.txt on git-log

on git-log there is a file pretty-formats.txt that does not exist and takes me here when clicking the link

It looks like this is an issue again?


node: fetch trusted peers on clone

When a repository does not yet exist during a fetch, i.e. a clone, then only delegates are being fetched.
Augment Namespaces::Many to hold the trusted and optional delegate peers separately. Doing so allows the construction of the variant without the repository existing, but tracking relationships existing.
This variant can then be used to build refspecs for both the trusted peers and delegates when doing a cloning fetch.

I'm leaving this as a draft for now, but the tests passed locally. I need to go over it tomorrow to double-check things :)
I get an uneasy feeling with Namespaces in tandem with the tracking. It tends to lead to little workarounds which feel prone to error, but I can't quite figure out a better way at doing (yet) :thinking:


[CI] Add markdown check for normalized code-blocks + .md page fixes

Contributes to #3122
This PR is best reviewed by ignoring whitespace changes
Adds an NPM script named fix:markdwon which will run markdownlint in "fix" mode
Adds a custom markdownlint rule, named trim-code-block-and-unindent, to check and optionally clean up fenced code blocks of:

Excessive blank lines at the start or end of the code
Unnecessary indentation

Adds trim-code-block-and-unindent:true and no-trailing-spaces:true to the markdownlint config
Fixes fenced code blocks in our docs using the new rule
Notes:

Custom rules are controlled in the same way as other rules. So they can be turned on/off for the project or selectively within a file.
The added custom rule is a bit hacky (I didn't quite understand how markdownlint rules worked when I started 🤷🏼♂), but it works so I'm committing it now. I'll rework the rule later.

Maybe "excessive indentation" would be a better term than "unnecessary indentation"?
Here's an example from the PR:

The algorithm will shift the code in the code block to the left as much as possible while preserving the relative indentation of non-whitespace characters. Of the 25+ files in this PR that were fixed, do you see any that were incorrectly adjusted (I've re-enabled view-whitespace diffs).


exception handling problem

There is no processing in exceptional situations for negative or non-numerical values entered by the user.

Hi @Mrinank-Bhowmick,
Can you please assign this issue to me?
I want to work on the #731 issue

Go ahead 🚀

I'm sorry Can you assign me this again? @Mrinank-Bhowmick


HADOOP-19163. Use protobuf-java 3.25.3

merged.

the PR isn't merged, I am merging it based on @steveloughran's +1


sshebang ordering

when creating a shell script using entangled, then a shebang line comes after the location indication
# ~/~ begin <<example.md#scripts/hydrate.sh>>[init]
#!/bin/bash

in case there is a shebang it should go before the location indication

Thanks for the suggestion. This was on my todo-list.


Can't cursor-past a new fold

Environment data

VS Code version: 1.56.2
Extension version (available under the Extensions sidebar):  2021.5.842923320
OS and version: Ubuntu 20.04
Python version (& distribution if applicable, e.g. Anaconda): 3.8.5
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): n/a
Relevant/affected Python packages and their versions: n/a
Relevant/affected Python-related VS Code extensions and their versions: n/a
Value of the python.languageServer setting: default (which is set to Pylance)

Expected behaviour
When closing a fold with ctrl-shift-[ and then moving down below the fold, it should not re-open the fold.
Actual behaviour
It re-opens the fold.
Steps to reproduce:

Edit any file with a class that has some function defs in it.
Ctrl-Shift-[ on the first def to close the fold
attempt to move past the fold with down-cursor
Notice it re-opens the fold.

Logs
Not sure this is relevant.

We don't control the folding UI. This should be on VS Code.


Reducing the noise in the GitHub tracker

What's the problem this feature will solve?
Reducing the noise in the Warehouse GitHub tracker from people mistakenly taking it for a specific project's tracker.
I assume that a certain proportion of people end up in the Warehouse tracker from the link in the website footer.
Describe the solution you'd like
When clicking on the link "Contribute on GitHub" in the footer from a project page, instead of it being a link, it would open a modal saying (disclaimer: wording to review):

You are about to visit the GitHub repository of PyPI (this website) and not the GitHub repository of {{ project.name }}. If you have an issue to submit to {{ project.name }}, please contact them directly. Where do you want to go ?

Buttons:

"Close"
"PyPI repository"
Optionally, if a repository or issue tracker is defined for the current project: "{{ project.name }} repository/issue tracker" (this is provided as a courtesy, but it's not mandatory to implement)

Additional context
A relatively high number of people end up mistaking the warehouse issue tracker for specific projects' tracker, and that means we're maybe not making it clear enough.

A relatively high number of people end up mistaking the warehouse issue tracker for specific projects' tracker

Can you give exact numbers?

I believe the following search results will give you an idea of the numbers:
https://github.com/pypa/warehouse/issues?q=is%3Aissue+sort%3Aupdated-desc+"this+issue+tracker+is+for+issues+with+the+codebase+behind"+is%3Aclosed

Just 62 issues from 10331 is only 0.6% from the total signal+noise volume.
The "proper" way would be to add "wrong-tracker" label and replace PSF director person triaging issues with AI powered classifier to do the sorting like in GitLab. With a way for people to amend the bot decision. But I don't think it worth the hassle for so little traffic.

I'd be in favor of this. I think a lot of mis-directed issues also come from the "Bugs and feedback" link in the footer, which leads to https://pypi.org/help/#feedback but people don't read.