MM-44900 Never roll back last_viewed_at when receiving channel members

There's a race condition when switching teams to view an unread channel which has been made more common since we fixed an issue where we actually used to mark the channel as read 3 times when switching teams.
We mark the channel as read on viewing it, but at the same time, we're reloading all of your channels and channel members because you switched team. It's currently possible to mark the channel as read when you change teams and then receive the response to the request so that the channel is marked as read in the UI and then shows as unread. It's not actually unread though.
This is attempting to fix that by checking the last_viewed_at of each channel member before saving those received channel members. If the last_viewed_at is lower in a received channel member, then we've hit this race condition and the result from the server is out of date. In that case, we use the unread status from the existing channel member.
Ticket Link
https://mattermost.atlassian.net/browse/MM-44900
Release Note
Fixed a race condition where switching teams to an unread channel may not appear to mark that channel as read

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

I changed the reviewer as Ben is out of office.

/e2e-tests

Successfully triggered e2e testing!
https://git.internal.mattermost.com/qa/cypress-ui-automation/-/pipelines/210895

/update-branch

/cherry-pick release-7.1

Cherry pick is scheduled.


[Feature request] : Enhance Menu Display with Collapsible Accordions

Request:
Currently, in our app, when users access the menu section, they can only see a list of recommended items. This limits the options available to them and doesn't provide a comprehensive view of our offerings.
Desired Feature:
We aim to enhance the menu section by introducing collapsible accordions. Collapsible accordions are interactive elements that, when clicked, expand to reveal additional content. In our case, these accordions will allow users to browse different categories of items (e.g., appetizers, main courses, desserts) and select the ones they are interested in.
Reference:

To get a better understanding of how we plan to structure and implement this feature, you can refer to the MENU API in the utils/constants section of our codebase. This API contains the data and structure we intend to use for the collapsible accordions.
To provide a clearer vision of what we aim to achieve, we've attached a screenshot of the Swiggy menu for reference. We aspire to create a similarly organised and user-friendly menu browsing experience for our users.

Records:

[ ]  I have checked the existing issues
[ ]  I have read the Contributing Guidelines
[ ]  I want to work on this issue

We believe this addition will improve user experience and make our app more user-friendly.
We welcome contributions and suggestions from the community to make this feature a reality.

Hey @Anandsg I would like to work on this task.

@VaibhavKVerma great, thanks for picking this up!! assigning the issue. make sure to install CORS extension to run this app in your local machine

Hey there @VaibhavKVerma Just FYI if you ever need some clarifications or find yourself stuck, feel free to check out my commit using the link below. I've implemented a similar feature there, and it might come in handy."
https://github.com/Anandsg/Menu-Mingle/commit/1fd121f38b45dfa7256b6ab93d5e61b429678adc

Hey @Anandsg will work on the required changes.

Hey @Anandsg will work on the required changes.

Thanks for the update.


[Bug] Relationship without data has no links

When rendering relationships without a data component the relationship
is not serialized in the right location in the document.

This is just a test case failure for what I think is incorrect behavior. I'm trying to render something like:
"data": {
    "id": "1234",
    "type": "articles",
    "attributes": {
        "title": "My Article"
    },
    "relationships": {
        "comments": {
            "links": {
                "related": "http://example.com/articles/1/comments"
            }
        }
    }
}

In the above response the relationship has no data as (for example) there could be thousands of comments available but there is no way to indicate pagination here, so instead the data is omitted and the client is expected to fetch the related data (this actually happens automatically in ember-data).

FWIW this works if the data is set to an empty array or list but that serializes something like data: [] which is misleading to consumers.

Hmm good bug. I think the cause is

json.net doesn't seem to pass null down to JsonConvertors making it hard to do custom behaviours on null
When we don't have an intermediate relationship object calls end up going ResourceObjectConverter->ResourceObjectConverter so we added a bit of logic to force nulls to be passed through
Unfortunately relationships objects are handled using normal json conversion. So calls go from ResourceObjectConverter->normal json serializer->ResourceObjectConvertor so we cant force it to send nulls

Will probably need to create a converter for relationships that will apply to anything that has either Data, Meta or Links property.
Ill try and have a closer look at it early this week

I think that's exactly the problem. Types are detected by presence of id and type and/or via special types and in this case there's nothing to differentiate the relationship from just another poco.

See https://github.com/codecutout/JsonApiSerializer/pull/53


mention custompane deprecation

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/index.md
:white_check_mark:Succeeded

docs/add-ins/testing-and-tips.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Remove dependence on libkb from libnativeinstaller

(2/2) prev one is https://github.com/keybase/client/pull/13502


[Batch] Updated Batch mgmt setup.py

Codecov Report

Merging #1621 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1621   +/-   ##
=======================================
  Coverage   56.08%   56.08%
=======================================
  Files        3889     3889
  Lines       94195    94195
=======================================
  Hits        52831    52831
  Misses      41364    41364

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77ff2e...042e38e. Read the comment docs.


add support for virtual space

many editors support this (eg visual studio, intellij)
here is a bit of explanation https://blogs.msdn.microsoft.com/zainnab/2010/02/28/understanding-virtual-space/
it is useful when you edit aligned content (and pretty much any code) as cursor does not jump around when you move between lines

This is unlikely to be added to the core library (but it might be possible to write an addon that implements it).


Issue with Optional input: Unable to convert type from Optional1toInt32`

We've recently rewritten our GraphQL API to use HotChocolate. Most things are much easier now, but we're running into a weird issue with an optional input parameter that's nested within some other input types.
I've created a repo for reproduction here
We're currently using HotChocolate.AspNetCore/10.4.3, but I've tested against version 10.5.0-rc.0 too, and the issue can be reproduced there too.
The steps for reproduction can be found in the README in that repo, but for clarity I'll add them here too.
Let me know if there's anything I can do to clarify the issue further, and thanks for your time!
To reproduce the issue:

Clone this repo and start the graphql server
Open the playground (https://localhost:5001/playground/)
Execute this mutation:

mutation eatChiliStrawberryIcecream {
  eat(topping: { pickles: { dillPickle: { weight: 5 } } }) {
    description
  }
}

This returns the expected result:
{
  "data": {
    "eat": {
      "description": "A chili strawberry ice cream with a tasty pickle"
    }
  }
}

Execute the same mutation with the last part of the input parameterized:

mutation eatChiliStrawberryIcecream($input: DillPickleInput) {
  eat(topping: { pickles: { dillPickle: $input } }) {
    description
  }
}

with these query variables:
{ "input": { "weight": 5 } }

This returns an error:
{
  "errors": [
    {
      "message": "Unexpected Execution Error",
      "locations": [
        {
          "line": 2,
          "column": 3
        }
      ],
      "path": [
        "eat"
      ],
      "extensions": {
        "message": "Unable to convert type from `Optional`1` to `Int32`",
        "stackTrace": "   at HotChocolate.Utilities.TypeConversion.Convert(Type from, Type to, Object source)\r\n   at HotChocolate.Utilities.InputObjectToObjectValueConverter.VisitLeaf(INamedInputType type, Object obj, Action`1 setValue, ISet`1 processed)\r\n   at HotChocolate.Utilities.InputObjectToObjectValueConverter.VisitValue(IInputType type, Object obj, Action`1 setValue, ISet`1 processed)\r\n   at HotChocolate.Utilities.InputObjectToObjectValueConverter.VisitInputObject(InputObjectType type, Object obj, Action`1 setValue, ISet`1 processed)\r\n   at HotChocolate.Utilities.InputObjectToObjectValueConverter.Convert(InputObjectType type, Object obj)\r\n   at HotChocolate.Types.InputObjectType.ParseValue(Object value)\r\n   at HotChocolate.Execution.VariableToValueRewriter.ReplaceVariable(VariableNode variable, IInputType type)\r\n   at HotChocolate.Execution.VariableToValueRewriter.RewriteObjectField(ObjectFieldNode node, Object context)\r\n   at HotChocolate.Language.SyntaxRewriter`1.RewriteMany[T](IReadOnlyList`1 items, TContext context, Func`3 func)\r\n   at HotChocolate.Language.SyntaxRewriter`1.<>c__DisplayClass20_0`2.<RewriteMany>b__0(IReadOnlyList`1 p, TContext c)\r\n   at HotChocolate.Language.SyntaxRewriter`1.Rewrite[TParent,TProperty](TParent parent, TProperty property, TContext context, Func`3 visit, Func`2 rewrite)\r\n   at HotChocolate.Language.SyntaxRewriter`1.RewriteMany[TParent,TProperty](TParent parent, IReadOnlyList`1 property, TContext context, Func`3 visit, Func`2 rewrite)\r\n   at HotChocolate.Language.SyntaxRewriter`1.RewriteObjectValue(ObjectValueNode node, TContext context)\r\n   at HotChocolate.Execution.VariableToValueRewriter.RewriteObjectValue(ObjectValueNode node, Object context)\r\n   at HotChocolate.Execution.VariableToValueRewriter.RewriteObjectField(ObjectFieldNode node, Object context)\r\n   at HotChocolate.Language.SyntaxRewriter`1.RewriteMany[T](IReadOnlyList`1 items, TContext context, Func`3 func)\r\n   at HotChocolate.Language.SyntaxRewriter`1.<>c__DisplayClass20_0`2.<RewriteMany>b__0(IReadOnlyList`1 p, TContext c)\r\n   at HotChocolate.Language.SyntaxRewriter`1.Rewrite[TParent,TProperty](TParent parent, TProperty property, TContext context, Func`3 visit, Func`2 rewrite)\r\n   at HotChocolate.Language.SyntaxRewriter`1.RewriteMany[TParent,TProperty](TParent parent, IReadOnlyList`1 property, TContext context, Func`3 visit, Func`2 rewrite)\r\n   at HotChocolate.Language.SyntaxRewriter`1.RewriteObjectValue(ObjectValueNode node, TContext context)\r\n   at HotChocolate.Execution.VariableToValueRewriter.RewriteObjectValue(ObjectValueNode node, Object context)\r\n   at HotChocolate.Language.SyntaxRewriter`1.RewriteValue(IValueNode node, TContext context)\r\n   at HotChocolate.Execution.VariableToValueRewriter.RewriteValue(IValueNode value, IType type, IVariableValueCollection variables, ITypeConversion typeConversion)\r\n   at HotChocolate.Execution.VariableToValueRewriter.Rewrite(IValueNode value, IType type, IVariableValueCollection variables, ITypeConversion typeConversion)\r\n   at HotChocolate.Execution.ResolverContext.CoerceArgumentValue[T](String name, ArgumentValue argumentValue)\r\n   at HotChocolate.Execution.ResolverContext.Argument[T](NameString name)\r\n   at lambda_method(Closure , IResolverContext )\r\n   at HotChocolate.Types.FieldMiddlewareCompiler.<>c__DisplayClass3_0.<<CreateResolverMiddleware>b__0>d.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at HotChocolate.Execution.ExecutionStrategyBase.ExecuteMiddlewareAsync(ResolverContext resolverContext, IErrorHandler errorHandler)"
      }
    }
  ]
}

This should now be fixed with version 10.5.2


[optimism] TransactionManager won't deploy

Tried to use initializer pattern as described in docs, then ran into this issue:
contracts/TransactionManager.sol:55:1: Warning: Contract code size exceeds 24576 bytes (a limit introduced in Spurious Dragon). This contract may not be deployable on mainnet. Consider enabling the optimizer (with a low "runs" value!), turning off revert strings, or using libraries.
contract TransactionManager is ReentrancyGuard, ProposedOwnable, ITransactionManager {
^ (Relevant source part starts here and spans across multiple lines).

Will need to figure this out.

stale


fix point of order submitet on cancel

resolves #2052

@MSoeb and me tested it. SeemsGood
I'll merge


clair fetch image layer from openstack swift or ceph s3

Hi,
In my private registry, the images stored in openstack swift which need http auth header to download or get a file, so when I use "POST /v1/layers" API, I can't insert a layer from swift to clair directly. I modify "worker/worker.go func getLayerData()" to add a auth header before "r, err := http.Get(path)" but is not a graceful solution, is there a better one :).

One idea would be to enable direct linking to objects in Swift (http://docs.openstack.org/kilo/config-reference/content/object-storage-tempurl.html) and then send those URLs to Clair

^ Same solution for AWS S3.


Is this project still active?

There has not been a release since 2022.

looks like author got cold feet on this project particularly. he does seem to have had activity in other places on github, but not here.
https://github.com/iongion?tab=overview&from=2023-10-01&to=2023-10-31

I found another project still active: https://github.com/containers/podman-desktop

As others noted, I don't think this project has had a lot of activity over the past year or two.  However, as @xlat pointed out, the Podman Desktop project is very active and growing on GitHub.

https://github.com/iongion/podman-desktop-companion/issues/119

@TomSweeneyRedHat if you agree with these changes https://github.com/iongion/podman-desktop-companion/pull/120/files to clarify, let's merge - I don't want to archive it, it makes no sense, but I do understand the effort to avoid confusion, of 4 users.

Done - released 5.2.0-rc.1, thank you all guys and wish you to be awesome.

@trymeouteh - it is alive when I have time. See home page and README.md notes.


[CI] Enforce template format via linter

if threre is a linter to check go-html templates we should use it

enforce intentional
{{ if }}/ range blocks to be {{ end }}
...

Last I checked, the linter situation for go templates is pretty dire, but given the syntax is so similar to Handlebars, tools that lint Handlebars might just work.


Pod install fails

Error message:
'flutter_google_ad_manager' does not specify a Swift version and none of the targets ('Runner') integrating it have the 'SWIFT_VERSION' attribute in at least one of the targets that integrate this pod.

@ozzy1873 It is troubleshooting of another plugin, but please refer to the following.
https://github.com/ko2ic/image_downloader/wiki#your-appdelegate-is-the-case-of-objective-c

That worked. Thank you!


Add latency analysis

This small series adds a new TraceAnalysis module which allows to report and plot both WAKEUP and PREEMPTION latencies for a specified task.
NOTE: This series depends on #153, thus the new patches are just the last two.

Pushed new PR #156  rebased on top of #153 which has finally found its way into mainline ;-)


Can't initialize in Chrome

Here's some example code: https://github.com/acrispino/flockstest
Everything works as expected in Firefox. On Chrome, the calling Flocks.create fails:
flocks.jsx:69 Flocks2 [1] Flocks2 root creation begins
flocks.jsx:69 Flocks2 [2]  - Flocks2 engaging auto-context
flocks.jsx:143 Uncaught TypeError: Converting circular structure to JSON

The issue seems to be that the flocks context contains a copy of the config object, which contains a reference to the target element for the root component. In Chrome, this causes the call to JSON.stringify to fail.
Firefox and IE9+ seem to serialize elements as objects without any of the DOM properties. IE8 returns undefined.

Oh hell, I thought I took that stringify out already.  That was temporary.
Thanks for the catch.  Will fix tonight after work :smile:
I need to set up non-trivial testing too

Yesterday got long.
Notes for myself tonight: you want http://oranlooney.com/deep-copy-javascript/ or https://github.com/pvorb/node-clone or http://stackoverflow.com/a/12941013/763127 .


align names on browse and package pages

there are a few instances where an abbreviated name is used on the registry browse page that is different from the name used on the package page. see awsx as an example:

we would like all instances to use the more descriptive name.

@anita-trimbur The data for the browse page cards and the index pages comes from two different sources, so it looks like divergence comes from when one source is hand-updated, and the other is not updated to match.  I'll do an audit and put up a PR to align everything, but there's unfortunately not an easy answer that I can see that keeps them aligned going forward other than being vigilant on PRs where title attributes change.
That said, I think this should be relatively rare + it's easy enough to fix.

Eek, much more common than I guessed above 😬 - here's an audit of what's on browse vs index when they differ.  Let me know which we should go with.  I will also reach out on Slack about how we can make these two names converge bc this is obviously very common, so would be ideal to come from the same source.

[ ] Google Cloud Classic (browse), Google Cloud (GCP) Classic (index)
[ ] AWSx (browse), AWSx (Pulumi Crosswalk for AWS) (index)
[ ] Azure Active Directory (browse), AzureAD (index)
[ ] Azure Quickstart ACR Geo Replication (browse), Azure Quickstart ACR Geo Replicated (index)
[ ] azure-justrun (browse), Azure Justrun (index)
[ ] Command (browse), Command (preview) (index)
[ ] Consul (browse), HashiCorp Consul (index)
[ ] ec (browse), ElasticCloud (EC) (index)
[ ] eventstorecloud (browse), Event Store Cloud (index)
[ ] Google Cloud Native (browse), Google Native (index)
[ ] HashiCorp Cloud Platform (HCP) (browse), HCP (index)
[ ] Kubernetes Cert Manager (browse), cert-manager (index)
[ ] Metabase (AWS) (browse), Metabase (index)
[ ] Nomad (browse), HashiCorp Nomad (index)
[ ] Proxmox VE (browse), Proxmox Virtual Environment (Proxmox VE) (index)
[ ] Rancher 2 (browse), Rancher2 (index)
[ ] Rancher RKE (browse), Rancher Kubernetes Engine (index)
[ ] Sumo Logic (browse), SumoLogic (index)
[ ] tls-self-signed-cert (browse), Self Signed Certificate (index)
[ ] Vault (browse), HashiCorp Vault (index)

Casing  diffs

[ ] artifactory (browse), Artifactory (index)
[ ] astra (browse), Astra (index)
[ ] checkly (browse), Checkly (index)
[ ] flux (browse), Flux (index)
[ ] heroku (browse), Heroku (index)
[ ] OVH (browse), Ovh (index)
[ ] MinIO (browse), Minio (index)
[ ] random (browse), Random (index)
[ ] tailscale (browse), Tailscale (index)

Something going on with confluent + confluent cloud packages - one is labeled Confluent on browse, but titled confluent cloud on index and located at /confluentcloud, the one labeled Confluent Cloud on browse is also labeled Confluent Cloud on index but located at /confluent.

id like to "fix" this by using the same data source we use on the package detail pages on the package browse page. that's the change id like to happen in the issue. i don't want us to change anything about the casing in this issue, take it exactly as its coming in and then we can fix casing issues in the packages themselves later if needed.
for improvements beyond that, id like us to open a new tracking issue, because it will mean updating individual packages.

will explain more about confluent in team meeting tomorrow, don't want to talk about it more here since its a public issue.

@susanev I don't believe we have a straightforward way to automatically align the two names (the name shown in the browse view, and the name shown on the Overview index page).  Here's my understanding of the pipeline (def gonna repeat things you already know, but typing it all out for clarity):

The repo of the provider has (among other things) two separate files in it that are relevant here - schema.json and docs/_index.md.  These two files are authored separately, however the maintainer of the provider sees fit.
A PR is made to add that provider to the Registry, via adding to this file.  That includes a url to their schema.json.
Once that PR is merged, this automated job creates a providerName.yaml file from the schema.json, and pulls the docs/_index.md file directly from the provider repo.
The name we show in the browse page comes from the providerName.yaml file, and the name we show on the index page comes directly from the frontmatter in that docs/_index.md file.

So, as far as I understand it, it's at the discretion of the provider author/maintainer to keep those two names in sync.  I think we could be clearer about that intention in the docs.  I would guess that it's also possible for the automated job that adds the yaml file and the index file to the Registry repo to do some magic and change the title on the index file to match whatever is in the yaml file, but I am not sure how complicated that would be - it's a bit outside my wheelhouse.
Does that sound right, is there any part of the flow I'm misunderstanding?  What do you think re next steps?

@kimberleyamackenzie got it thx, ill take on this issue. ill fix the biggest offenders today, and will slowly work towards fixing the rest.

these need their install+config titles fixed

[ ] aquasec
[ ] astra
[ ] aviatrix
[ ] buildkite
[ ] checkly
[ ] doppler
[ ] dynaatrace
[ ] exoscale
[ ] flux
[ ] fusion auth
[ ] gandi
[ ] grafana
[ ] harness
[ ] hcp
[ ] heroku
[ ] koyeb
[ ] launch darkly
[ ] ovhcloud
[ ] proxmoxve
[ ] rootly
[ ] scaleway
[ ] sentry
[ ] symbiosis
[ ] time
[ ] unifi
[ ] upstash

alright i have open prs for everything except for rancher2 because i have an outstanding question about it; the tricky part now is going to be convincing everyone to do releases

@susanev I've created a new release for Heroku provider. (https://github.com/pulumiverse/pulumi-heroku/actions/runs/3618262104/jobs/6098043475)

im calling this done from my perspective, stuff will slowly roll in, and that's okay!


Make PathBuf set the MIME type based on the path

This now shares code with the Modifier impl for Path, which already sets the MIME type.

Neat, thanks!


Allow TestTag on classes

I would like to put the TestTag attribute on a class-level. Marking the entire class as intended for use in tests only.
I sometimes write extremely simple implementations of interfaces that only exist for making writing tests that interact with the interface simpler.
Instead of configuring a mock, you can just create an instance of this class with a couple of constructor arguments.
It is sometimes useful that these classes are available in the library for other code that depends on this library. So writing tests there becomes easier.
What do you think of this change?
Would you accept a pull-request to adjust the attribute for this? And an additional pull-request in DaveLiddament/phpstan-php-language-extensions for the implementation?

Yes, that change sounds like a great idea.
If you're happy to give the implementation a go then please send through a PR. Otherwise I can take a look in the next couple of weeks.
Thanks for your interest in this project.

Implemented by #26


If URL ends with .link, it should redirect to the link from the content

It is questionable because it will act as a link shortener without anti-abuse, but it looks passable.


Add documentation for writing modules.

I wrote this based on my experience in #849 , where I felt such documentation would have sped me up a bit. I am open to suggestions on improving it, though.

Can you put this information on the github wiki instead? https://github.com/Alexays/Waybar/wiki

Done!


Added Front-End Development Resource

IMPORTANT: When creating your Pull Request, please use the following format for the title: Category - Resource Name & Section
PR Title samples:

Web development - CSS Portal & Tools
Web development - Leetcode & Challenges

Fixes Issue Closes #223

Description: Added a Front-End Development Course

Resource URL: https://www.coursera.org/professional-certificates/meta-front-end-developer

Checklist:
Before submitting your pull request, ensure that you have completed the following tasks:

[x] I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
[x] I followed the prescribed PR title template. (Check this if you're adding a resource)

@jfmartinz could you please review it

Thanks


Recommend apt instead of apt-get

Good catch! I made the change manually, but for all intents and purposes this is merged.


Support for BullMQ 4

Since BullMQ 4.0 prioritized jobs have their own separated status prioritized, so jobs that use to appears in waiting tab are no longer being displayed after upgrading to BullMQ v4.
Ref:

https://github.com/taskforcesh/bullmq/pull/1984
https://bullmq.io/news/062123/faster-priority-jobs

Will most likely land this tomorrow! Started here: #7


gridfs Problem after Update

Hi,
when updating from Gridfs 0.0.27 to 0.0.30 i get the following error. Cant say where it starts:
I20150305-14:21:44.160(1)? Exception in queued task: TypeError: Cannot read property 'start' of undefined
I20150305-14:21:44.160(1)?     at Object.FS.StorageAdapter.createReadStream (packages/cfs:gridfs/gridfs.server.js:78:1)
I20150305-14:21:44.160(1)?     at Object.self.adapter.createReadStreamForFileKey (packages/cfs:storage-adapter/storageAdapter.server.js:71:1)
I20150305-14:21:44.160(1)?     at Object.self.adapter.createReadStream (packages/cfs:storage-adapter/storageAdapter.server.js:79:1)
I20150305-14:21:44.160(1)?     at packages/cfs:tempstore/tempStore.js:364:1
I20150305-14:21:44.160(1)?     at runWithEnvironment (packages/meteor/dynamics_nodejs.js:108:1)
I20150305-14:21:44.160(1)?     at packages/meteor/dynamics_nodejs.js:121:1
I20150305-14:21:44.160(1)?     at CombinedStream._getNext (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:83:3)
I20150305-14:21:44.160(1)?     at CombinedStream.resume (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:132:10)
I20150305-14:21:44.160(1)?     at CombinedStream.pipe (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:64:8)
I20150305-14:21:44.160(1)?     at saveCopy (packages/cfs:worker/fileWorker.js:176:1)
I20150305-14:21:44.161(1)? Exception in queued task: TypeError: Cannot read property 'start' of undefined
I20150305-14:21:44.161(1)?     at Object.FS.StorageAdapter.createReadStream (packages/cfs:gridfs/gridfs.server.js:78:1)
I20150305-14:21:44.161(1)?     at Object.self.adapter.createReadStreamForFileKey (packages/cfs:storage-adapter/storageAdapter.server.js:71:1)
I20150305-14:21:44.161(1)?     at Object.self.adapter.createReadStream (packages/cfs:storage-adapter/storageAdapter.server.js:79:1)
I20150305-14:21:44.161(1)?     at packages/cfs:tempstore/tempStore.js:364:1
I20150305-14:21:44.161(1)?     at runWithEnvironment (packages/meteor/dynamics_nodejs.js:108:1)
I20150305-14:21:44.161(1)?     at packages/meteor/dynamics_nodejs.js:121:1
I20150305-14:21:44.161(1)?     at CombinedStream._getNext (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:83:3)
I20150305-14:21:44.161(1)?     at CombinedStream.resume (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:132:10)
I20150305-14:21:44.161(1)?     at CombinedStream.pipe (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:64:8)
I20150305-14:21:44.161(1)?     at saveCopy (packages/cfs:worker/fileWorker.js:176:1)
I20150305-14:21:44.161(1)? Exception in queued task: TypeError: Cannot read property 'start' of undefined
I20150305-14:21:44.161(1)?     at Object.FS.StorageAdapter.createReadStream (packages/cfs:gridfs/gridfs.server.js:78:1)
I20150305-14:21:44.161(1)?     at Object.self.adapter.createReadStreamForFileKey (packages/cfs:storage-adapter/storageAdapter.server.js:71:1)
I20150305-14:21:44.161(1)?     at Object.self.adapter.createReadStream (packages/cfs:storage-adapter/storageAdapter.server.js:79:1)
I20150305-14:21:44.161(1)?     at packages/cfs:tempstore/tempStore.js:364:1
I20150305-14:21:44.161(1)?     at runWithEnvironment (packages/meteor/dynamics_nodejs.js:108:1)
I20150305-14:21:44.162(1)?     at packages/meteor/dynamics_nodejs.js:121:1
I20150305-14:21:44.162(1)?     at CombinedStream._getNext (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:83:3)
I20150305-14:21:44.162(1)?     at CombinedStream.resume (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:132:10)
I20150305-14:21:44.162(1)?     at CombinedStream.pipe (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:64:8)
I20150305-14:21:44.162(1)?     at saveCopy (packages/cfs:worker/fileWorker.js:176:1)
I20150305-14:21:44.162(1)? Exception in queued task: TypeError: Cannot read property 'start' of undefined
I20150305-14:21:44.162(1)?     at Object.FS.StorageAdapter.createReadStream (packages/cfs:gridfs/gridfs.server.js:78:1)
I20150305-14:21:44.162(1)?     at Object.self.adapter.createReadStreamForFileKey (packages/cfs:storage-adapter/storageAdapter.server.js:71:1)
I20150305-14:21:44.162(1)?     at Object.self.adapter.createReadStream (packages/cfs:storage-adapter/storageAdapter.server.js:79:1)
I20150305-14:21:44.162(1)?     at packages/cfs:tempstore/tempStore.js:364:1
I20150305-14:21:44.162(1)?     at runWithEnvironment (packages/meteor/dynamics_nodejs.js:108:1)
I20150305-14:21:44.162(1)?     at packages/meteor/dynamics_nodejs.js:121:1
I20150305-14:21:44.162(1)?     at CombinedStream._getNext (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:83:3)
I20150305-14:21:44.162(1)?     at CombinedStream.resume (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:132:10)
I20150305-14:21:44.162(1)?     at CombinedStream.pipe (/home/lugaru/.meteor/packages/cfs_tempstore/.0.1.4.yo7l0f++os+web.browser+web.cordova/npm/node_modules/combined-stream/lib/combined_stream.js:64:8)
I20150305-14:21:44.162(1)?     at saveCopy (packages/cfs:worker/fileWorker.js:176:1)

Installed CFS Packages Broken:
cfs:graphicsmagick           0.0.18  Adds gm to scope with the ability to perform GraphicsMagick or ImageMagick manipulation
cfs:gridfs                   0.0.30  GridFS storage adapter for CollectionFS
cfs:standard-packages        0.5.4  Filesystem for Meteor, collectionFS
Installed CFS Packages Works:
cfs:graphicsmagick           0.0.18  Adds gm to scope with the ability to perform GraphicsMagick or ImageMagick manipulation
cfs:gridfs                   0.0.27* GridFS storage adapter for CollectionFS
cfs:standard-packages        0.5.0* Filesystem for Meteor, collectionFS
image.js Collection
var imageStore = new FS.Store.GridFS("images", {
  chunkSize: 1024*1024,
	transformWrite: function(fileObj, readStream, writeStream) {
	  // Transform the image into a 10x10px thumbnail
	  gm(readStream, fileObj.name()).resize('200', '200').stream().pipe(writeStream);
	}
});
//var thumbStore = new FS.Store.GridFS("thumbs", {
//	chunkSize: 1024*1024
//});

Images = new FS.Collection("images", {
  stores: [imageStore],
	filter: {
	  allow: {
	    contentTypes: ['image/*'] //allow only images in this FS.Collection
	  }
	}
});

Images.allow({
	insert: trueFunc,
	update: trueFunc,
	remove: trueFunc,
	download: trueFunc
});

function trueFunc() {return true;}

exactly the same error log here

I experienced the same issue, and can confirm that latest modifications to cfs:gridfs in the 'devel' branch fixed it.

Everything in devel branch should be released in 0.0.31, so I'll close this.


Electron

Issue Type: Bug
(electron) Sending uncompressed crash reports is deprecated and will be removed in a future version of Electron. Set { compress: true } to opt-in to the new behavior. Crash reports will be uploaded gzipped, which most crash reporting servers support.
VS Code version: Code 1.53.0 (8490d3dde47c57ba65ec40dd192d014fd2113496, 2021-02-03T20:36:38.611Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6560U CPU @ 2.20GHz (4 x 2208)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
6.16GB (1.42GB free)

Process Argv
--crash-reporter-id e88e323e-0608-496e-a85f-98e9df1bb54e

Screen Reader
yes

VM
0%

Extensions (29)

Extension
Author (truncated)
Version

project-manager
ale
12.0.1

vscode-intelephense-client
bme
1.6.3

vscode-tailwindcss
bra
0.5.9

gitignore
cod
0.6.0

bracket-pair-colorizer
Coe
1.0.61

vscode-eslint
dba
2.1.14

git-extension-pack
don
0.1.3

githistory
don
0.6.14

es7-react-js-snippets
dsz
3.1.0

gitlens
eam
11.2.1

vscode-html-css
ecm
1.9.1

prettier-vscode
esb
5.9.1

php-debug
fel
1.14.9

php-intellisense
fel
2.3.14

php-pack
fel
1.0.2

auto-complete-tag
for
0.1.0

auto-rename-tag
for
0.1.6

code-runner
for
0.11.2

beautify
Hoo
1.5.0

vs-color-picker
lih
1.0.0

dotenv
mik
1.0.1

mongodb-vscode
mon
0.4.0

open-html-in-browser
pea
2.1.3

px-to-rem
sai
1.3.1

win-opacity
ska
1.1.4

tabnine-vscode
Tab
3.2.6

vscode-icons
vsc
11.1.0

file-icons-mac
way
1.0.1

vscode-open-in-github
ziy
1.3.6

(1 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt617cf:30253240
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30211402
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt600cf:30251589

Where is this error coming from?

Its from the crash-reporter in electron, there is no timeline for when this will be fixed on our end.

it comes when i run npm start
`
server :: master ❯ npm start

<EMAIL_ADDRESS>start
index.js

(electron) Sending uncompressed crash reports is deprecated and will be removed in a future version of Electron. Set { compress: true } to opt-in to the new behavior. Crash reports will be uploaded gzipped, which most crash reporting servers support.
`

I am using nodemon and this issue is annoying me , when i run without nodemon it works fine !!

I had the same error, the problem in my case is the name of the archive. I renamed the archive and problem resolved :S

I had the same error, the problem in my case is the name of the archive. I renamed the archive and problem resolved :S

Please teach the steps

I've just reproduced the electron warning with running
code --diff somefile path-to-not-exisiting-file

electron) Sending uncompressed crash reports is deprecated and will be removed in a future version of Electron. Set { compress: true } to opt-in to the new behavior. Crash reports will be uploaded gzipped, which most crash reporting servers support.

@deepak1556 wrote:

Its from the crash-reporter in electron, there is no timeline for when this will be fixed on our end.

So it seems to be related to the electron update, isn't it? I'm completely fine with "no timeline", but then there likely is an open issue on the backlog to solve this somedayTM, isn't it? [If not - I did not found it on the first page with a search - then it would be good to have one, even if it just contains the quote above which says "we know about this and acknowledge it as an issue so it is kept open and on the backlog"]

Please use this to workaround,
* Open the Command Palette.
* Run the Preferences: Configure Runtime Arguments command.
This command will open a argv.json file to configure runtime arguments. You might see some default arguments there already.
* "enable-crash-reporter":  false
* Restart VS Code.

To clarify this is not a bug, just a warning to adapt upcoming changes in crash reporter of electron which is being tracked internally, if the log is interrupting any workflow please use this to workaround
* Open the Command Palette.
* Run the Preferences: Configure Runtime Arguments command.
This command will open a argv.json file to configure runtime arguments. You might see some default arguments there already.
* "enable-crash-reporter":  false
* Restart VS Code.

Thanks for the update, but it still not working for me.

im getting the same problem in django idk why, in every django project I get the same problem even in new empty django project

how to run Preferences: Configure Runtime Arguments command?

This is already fixed in our insiders https://code.visualstudio.com/insiders and will be fixed in the next stable release 1.54

im getting this problem in cmd as well its not only vs code

(electron) Sending uncompressed crash reports is deprecated and will be removed in a future version of Electron. Set { compress: true } to opt-in to the
new behavior. Crash reports will be uploaded gzipped, which most crash reporting servers support.
I am getting this in the terminal when I run CPP Program Please help me to resolve this issue.

This is already fixed in our insiders https://code.visualstudio.com/insiders and will be fixed in the next stable release 1.54

I can try it, but it doesnt work :(


Week4

merging week4 to repository

Make sure to double-check which branches you're merging - you should be trying to merge GPV1:week4 into
GPV1:main, not iamdonovan:main.


Support openmp in tflite for operations like depthwise convolution

In tflite, some operations like convolution have openmp support from Eigen library, while for others like depthwise convolution they don't have openmp optimization yet.
Do we have any plans to add openmp to all operations in tflite?

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

Have I written custom code: NO
OS Platform and Distribution: Ubuntu 14.04
TensorFlow installed from: binary
TensorFlow version: 1.18.0
Bazel version: N/A
CUDA/cuDNN version: N/A
GPU model and memory: N/A
Exact command to reproduce: N/A

Nagging Assignee @jart: It has been 17 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

This is an interesting idea, we would be open to external contribution if it was shown to be performant and not increase the binary size too much.

Nagging Assignee @petewarden: It has been 17 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @petewarden: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @petewarden: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @petewarden: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @petewarden: It has been 74 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @petewarden: It has been 89 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @petewarden: It has been 104 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

I'm not sure when we'll get to this, so adding to contributions welcome.

We have no immediate plans to explore OpenMP support.


Fix the order of output in "no overload matches" error

def test(a : Int8 = 0)
end

test(5)

Before (invalid syntax in error message):
no overload matches 'test' with type Int32
Overloads are:
 - test(a = 0 : Int8)

After:
 - test(a : Int8 = 0)

Good catch! @asterite 0.18.3?

Yes you can't just merge a branch based on master, you have to am it (basically cherry pick all the commits). The easiest is to use http://github.com/github/hub and then hub am -3 https://github.com/crystal-lang/crystal/pull/2876

i usually use this https://gist.github.com/piscisaureus/3342247, and merge, rebase by hands

Merged in https://github.com/crystal-lang/crystal/commit/f5f57054af4dee93c2cc08c8e8a674f8387a3831
Thank you @BlaXpirit !
And thank you @jhass and @kostya for the advise. I ended up using hub, which I already had installed, it was super easy :-)


Add timepoint feature

I hacked in timepoints like this to make frontend progress, please swap with your implementation:
https://github.com/deep-ink-ventures/genesis-dao-service/commit/a8dde0e52a70d81eba57130db5ab22f5da81982e

53122e13158f9772c6efe0c9508f9270d06f849c


Update nu.validator version from 15.6.29 to 17.11.1

Description
Updated nu.validator version from 15.6.29 to 17.11.1
Also added or updated dependcies of new nu.validator version.
Currently update to newest version (18.3.0) is probably not possible - some dependencies are throwing errors because they're compiled with Java 9
Motivation and Context
This change will allow better (more up-to-date) validation of page source against W3C rules
Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

Maybe we could upgrade AET to use JAVA 9?
We already have Karaf 4.2.0 that is JAVA 9 compatible...
:)

@wiiitek - this is a very good plan for the future :) For now let's do it step by step.


Feat/update policies

Codecov Report

Merging #83 (14b2cd7) into master (d9be792) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #83   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           19        19
  Branches         5         4    -1
=========================================
  Hits            19        19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6403e01...14b2cd7. Read the comment docs.

Replaced by https://github.com/nrkno/tv-automation-server-core/pull/380


What is the default adapter setup?

I poured through the docs and the source code, but then I figured I might as well just ask here. Which adapter is loaded when I run the following code?
model.add_adapter("name")
model.train_adapter("name")
model.set_active_adapters("name")

Hi @Eugleo
I asked the same question previously. Here is the thread with the answer:
https://github.com/adapter-hub/adapters/issues/611


Integration Testing topic+sample dB replacement

Fixes #14354

I tested this with both an in-memory dB and SQL Server dB.
Hoping that we can go with something simpler than the lower-level approach taken by the engineering sample (i.e., can't we just services.AddDbContext<T>(...) in the normal way after killing the existing service registration as I show here?).
Interestingly, I didn't need to keep the UseInternalServiceProvider. I have no real confidence tho in this move outside of it ✨ Just Works:tm: ✨ in testing here. Do you want to ping an EF Core :cat2: to make sure that this approach is sound?

You can ping @bricelam or @ajcvickers to validate the approach we are using, but this is what we do in Identity and I believe we reviewed it at the time.
There's nothing EF specific here other than replacing services in the container. When we did this for Identity I remember looking up how EF did the registration to achieve the desired result.
Looks good to me

The only thing that concerned me was that at least one of the approaches (it might be the seeding approach in EF Core docs) required migrations.
Having the user be distracted by migrations in topics that have nothing at all to do with EF Core seems like a poor UE to me. (Also harder for us to maintain in in the doc.)
The approach used by this topic+sample and several others on the repo works well ... no migrations required. The dev just pulls down the sample and runs it. :tada:🎈:smile:
If we need to tell devs somewhere along the way, don't do this ... use migrations for seeding and cross-link, sure thing :+1: ... I hope that's the direction we take. Plz don't add migrations unless you absolutely have to.

@scottaddie If you're up 🌞, I'd like to get this in asap.

The only thing that concerned me was that at least one of the approaches (it might be the seeding approach in EF Core docs) required migrations.
Having the user be distracted by migrations in topics that have nothing at all to do with EF Core seems like a poor UE to me. (Also harder for us to maintain in in the doc.)
The approach used by this topic+sample and several others on the repo works well ... no migrations required. The dev just pulls down the sample and runs it. 🎉🎈😄
If we need to tell devs somewhere along the way, don't do this ... use migrations for seeding and cross-link, sure thing 👍 ... I hope that's the direction we take. Plz don't add migrations unless you absolutely have to.

As far as I remember this approach doesn't require migrations. I believe the Db is created on a per-waf basis. Seeding is something you can do on the test itself by retrieving the DbContext and performing the seed in place.
Is there something I'm missing here?

No, that's fine. :+1: We're good. That's what we do.
The app also seeds. I think seeding can use migrations there. I'm just speaking generally on the subject for apps. I should have clarified that I wasn't speaking about the test project.
The reason for app seeding is so that the dev can see seeding of the app's dB is different from the test seeding. The messages in testing start with something like TEST MESSAGE: to call it out clearly.

@scottaddie I'm off to the 🏋 gym 💪 ... if you get a chance to :eyes:, this should cue up for master on https://github.com/aspnet/AspNetCore.Docs/pull/15100.

@Rick-Anderson This is the priority PR that we discussed. It just needs your quick :eye:. Please merge and take live or let me know on your review to take live.


fix(): add capacity to change the default behavior 'onChange'

We got an issue in our main project: when typing the email (as the login in register form) we check on the onChange if the email is already taken or not with a backend request (via gigya).
Once this is done, we discovered that on the next field (password), each keydown was also firing the onChange event with all the validation methods assigned from all the fields.
Description
The fix made is to use the onSubmit event instead of the onChange and pass this behavior as a parameter in order not to risk breaking all our forms.
Related Issue
Can't reproduce on this repo.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.65%. Comparing base (3565210) to head (58915c3).
Report is 1 commits behind head on master.

Files
Patch %
Lines

libs/form-builder/src/lib/formBuilder.tsx
20.00%
3 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   74.68%   72.65%   -2.03%
==========================================
  Files          28       28
  Lines         391      395       +4
  Branches      125      127       +2
==========================================
- Hits          292      287       -5
- Misses         64       67       +3
- Partials       35       41       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[fix][test] Fix resource leaks in LoadBalancerTest

Motivation
LoadBalancerTest leaks some threads.
Modifications

remove the unused thread pool
while debugging, it revealed that testLeaderElection method caused some thread leaks.

the logic to prevent duplicate calls to PulsarService.close() isn't needed anymore.
removing this logic fixed the issue although it doesn't seem to be obvious from the code since it looks like cleanup was happening properly also before making these changes.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report

Merging #21443 (2d54b77) into master (04d1225) will increase coverage by 0.51%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #21443      +/-   ##
============================================
+ Coverage     72.73%   73.24%   +0.51%
- Complexity    32351    32583     +232
============================================
  Files          1890     1890
  Lines        140331   140333       +2
  Branches      15419    15419
============================================
+ Hits         102070   102792     +722
+ Misses        30166    29460     -706
+ Partials       8095     8081      -14

Flag
Coverage Δ

inttests
24.24% <37.50%> (?)

systests
24.77% <0.00%> (-0.01%)
:arrow_down:

unittests
72.54% <100.00%> (+0.44%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

.../pulsar/broker/service/AbstractBaseDispatcher.java
94.32% <100.00%> (+1.10%)
:arrow_up:

... and 127 files with indirect coverage changes


Some pointwise unary ops return 2-D results from 1-D inputs

As we found out in tenstorrent/pytorch2.0_ttnn#198, several ops produce (1, N) tensors when (N,) tensors are expected.
Affected ops:

ceil
floor
sqrt

Spared ops:

cos

The lists above are non-exhaustive (yet).  I fired this ticket before keeping trying on other ops because this issue is probably widespread.

@jdh8 are you sure you do not convert input to a tile before running the operation?
Please consult with @kevinwuTT

I’m trying to compare implementations of unary ops, for example, ttnn::cos and ttnn::sqrt.  However, I searched the C++ codebase, but I only found call sites instead of definitions.  Where do I find these implementations?
(python_env) jdh8@tt-metal-skymizer-n150-3:~/tt-metal/ttnn/cpp$ git grep -i 'cos *('
ttnn/operations/eltwise/complex_unary/device/complex_unary_op.cpp:    Tensor c = ttnn::cos(input_b,output_mem_config);
ttnn/operations/eltwise/unary_backward/device/unary_backward_op.cpp:// name: cos(Tensor self) -> Tensor
ttnn/operations/eltwise/unary_backward/device/unary_backward_op.cpp:// # - name: acos(Tensor self) -> Tensor
ttnn/operations/eltwise/unary_backward/device/unary_backward_op.cpp:// self: grad * self.cos()
ttnn/operations/eltwise/unary_backward/device/unary_backward_op.cpp:    Tensor grad_input = ttnn::multiply(grad, ttnn::cos(input_tensor, output_mem_config), std::nullopt, output_mem_config);

I've inspected op implementations in both groups, but I can't find a clear difference in treating 1-D tensors.
https://github.com/tenstorrent/tt-metal/blob/32ad2318f05b904ed51952b6097ceae8d60d479e/tt_metal/hw/ckernels/wormhole_b0/metal/llk_api/llk_sfpu/ckernel_sfpu_exp.h
https://github.com/tenstorrent/tt-metal/blob/32ad2318f05b904ed51952b6097ceae8d60d479e/tt_metal/hw/ckernels/wormhole_b0/metal/llk_api/llk_sfpu/ckernel_sfpu_sqrt.h

After #13339, cos becomes affected.  Now I believe that returning a 2-D tensor is intended.  Squeezing 2-D tensors in the compiler looks like a true solution now.

I made a workaround in the compiler at tenstorrent/pytorch2.0_ttnn#198 because I can't find the root cause.  That PR also enables conversion for all rounding ops: ceil, floor, round, trunc.

At the moment we believe that all unary eltwise ops are impacted by this.   It sounds like our to_layout is converting to [1[32], 1024] for tiled output instead of the expected shape of [1024, [1,32]] .
To align with torch we have to do  ttnn.transpose(input_tensor, -2, -1).  See example below.
import ttnn
import torch

w = 1024
torch_input_tensor = torch.rand((w,), dtype=torch.bfloat16)
device_id = 0
device = ttnn.open_device(device_id=device_id)
input_tensor = ttnn.from_torch(torch_input_tensor, layout=ttnn.TILE_LAYOUT, device=device)

# required to align with torch
input_tensor = ttnn.transpose(input_tensor, -2, -1)
print(input_tensor.shape)
scalar = 3
output_tensor = ttnn.erf(input_tensor)
print(output_tensor.shape)

output_tensor = ttnn.from_device(output_tensor)
output_tensor = ttnn.to_torch(output_tensor)
print(output_tensor.shape)

pytorch_output_tensor = torch.erf(torch_input_tensor)
print("what torch does")
print(pytorch_output_tensor.shape)

ttnn.close_device(device=device)

@jdh8 can you confirm?
@ayerofieiev-tt , if our understanding is correct, this sounds like it is not an eltwise issue.

@jdh8 , I will keep track of this one. We might have to update ops later, but at this moment this is pretty much blocked by Tensor Layout work


Update dns command

kubectl get svc -n heptio-contour contour -o jsonpath='{.status.loadBalancer.ingress[0].hostname}'
should be
kubectl get svc -n projectcontour envoy -o jsonpath='{.status.loadBalancer.ingress[0].hostname}'
in https://github.com/heptiolabs/gangway/blob/master/docs/README.md

In my test, the namespace and service name does not change.

Hi @jenting I chose the wrong manifest some of them use projectcontour is used and envoy gets the ELB. Closing for now. May change when 1.0 is officially released.


Improved Hover Experience

The issue:

The default hover capability's contentFormat was being sent as plaintext by default.
the markdown was not processed correctly, which made &nbsp and escape characters (\) be printed as strings.
Improved the documentation to suggest the markdown_inline tree-sitter parser as recommended for a great hover experience

After:

Is there anything that blocks this PR?

@elan-hwang not that I'm aware of!


Develop - Fix shape mismatch bug in KMaxPooling, improve save load robust and config flexibility

As mentioned in title and commits.
Feel so happy to be able to make this PR.

Well done, I will merge and release this version tonight.

I think this commit could make a formal release to pip.


[Bug]: Can't associate with the web icon.

Describe the bug
I tried to associate a folder named web-page with various icons (web, www, page) and even used a custom clone without success,
the werd is it work with other icons file like (src, linux, test, ...)
To Reproduce
"material-icon-theme.folders.associations": {
    "batch": "windows",
    ".batch": "windows",
    "bash": "linux",
    ".bash": "linux",
    "terminal": "command",
    "C": "Core",
    "web-page": "web"
},
"material-icon-theme.folders.customClones": [
    {
        "name": "web-page",
        "base": "web",
        "color": "blue-400",
        "folderNames": [
            "web-page",
            "web-pages"
        ]
    }
],

Expected behavior
show the web icon fo the web-pages folder, but it just blanc
Screenshots
No response
Computer information

OS: win 11
ext ver: latest
VS ver: latest

Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

it looks like the folder name was public and not web !🙂


update your utility

update your utility, follow the PSR, for tests use PHPunit and also connect Composer

Are you offering to help?

Whoever wants something modern, there is https://github.com/wikimedia/AhoCorasick and https://github.com/tianhe1986/FatAhoCorasick


[BUG] Adjusted confidence interval uses adjusted bootstrap mean rather than adjusted standard deviation

Math error uses adjusted mean rather than adjusted standard deviation as nominator in calculation of standard deviation.
Must fix.

Resolved in 1.1.2


Add TranslateVarArray for simplified indexing

There is a considerable overhead when indexing on custom types. This PR investigates if we can relatively easily translate to a simpler and type stable value for indexing under the hood:
using BenchmarkTools
using SparseVariables

const SV = SparseVariables

# Demo custom types
abstract type Node end
struct Source <: Node
    id::Int
end
struct Sink <: Node
    id::Int
end

# Translation to type-stable index
SV.translate(n::Node) = n.id
SV.translate(::Type{<:Node}) = Int

"""
    Indexing on custom types with `IndexedVarArray`
"""
function test(N)
    m = Model()
    @variable(
        m,
        x[i = SinkNode.(1:N), y = SourceNode.(1:N)],
        container = SV.IndexedVarArray
    )
    for i in SinkNode.(1:N), j in SourceNode.(1:N)
        insertvar!(x, i, j)
    end
end

"""
    Indexing on `Int` manually for performance with `IndexedVarArray`
"""
function test_ix(N)
    m = Model()
    @variable(m, x[i = 1:N, j = 1:N], container = SV.IndexedVarArray)
    for i = 1:N, j = 1:N
        insertvar!(x, i, j)
    end
end

"""
    Automatic translation to `Int` by `TranslateVarArray`
"""
function test_t(N)
    m = Model()
    @variable(
        m,
        x[i = SinkNode.(1:N), j = SourceNode.(1:N)],
        container = SV.TranslateVarArray
    )
    for i in SinkNode.(1:N), j in SourceNode.(1:N)
        insertvar!(x, i, j)
    end
end

"""
    Manual indexing by `Int` with `TranslateVarArray` for comparison
"""
function test_i(N)
    m = Model()
    @variable(m, x[i = 1:N, j = 1:N], container = SV.TranslateVarArray)
    for i = 1:N, j = 1:N
        insertvar!(x, i, j)
    end
end

N = 100
@info "Custom type w/IndexedVarArray"
@btime test(N)

@info "Manual Int w/IndexedVarArray"
@btime test_ix(N)

@info "Automatic w/TranslateVarArray"
@btime test_t(N)

@info "Manual Int w/TranslateVarArray"
@btime test_i(N)

julia> include("translate_benchmark.jl")
[ Info: Custom type w/IndexedVarArray
  26.356 ms (460328 allocations: 20.33 MiB)
[ Info: Manual Int w/IndexedVarArray
  7.232 ms (200227 allocations: 11.38 MiB)
[ Info: Automatic w/TranslateVarArray
  13.335 ms (290328 allocations: 13.60 MiB)
[ Info: Manual Int w/TranslateVarArray
  9.945 ms (230227 allocations: 12.29 MiB)

Codecov Report
Patch coverage: 30.35% and project coverage change: -8.74 :warning:

Comparison is base (a8afb3e) 88.25% compared to head (8cb59a4) 79.51%.

:exclamation: Current head 8cb59a4 differs from pull request most recent head 4277efa.  As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   88.25%   79.51%   -8.74%
==========================================
  Files           5        6       +1
  Lines         315      371      +56
==========================================
+ Hits          278      295      +17
- Misses         37       76      +39

Impacted Files
Coverage Δ

src/SparseVariables.jl
100.00% <ø> (ø)

src/translate.jl
30.35% <30.35%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Looks like I misplaced a comment somewhere.. just added support for Tables.
I think we could use this as the default, but there is some overhead with the translation which I would like to remove/reduce. Also a TranslateVarArray does not store the structs, so if anyone use the container to lookup the keys, that will break (but not a part of the API).
Is it ok to keep as a separate type for now and see how it works for larger models and maybe cut down on the overhead? And then do a larger API overhaul for the next breaking release? There is a lot of overlap in the code between the two types, so a cleanup would be nice if we like this interface.
Not super happy about the naming, though, any suggestions? (Both for TranslateVarArray and translate)

I am fine with separate types for now. Not sure about better names... MappedIndexedVarArray with function map_to_index ?


Ignore message_changed events

When a message is edited, slack resends the message setting event type
to message_changed. Since commands may not be idempotent, there is risk
in reprocessing these messages. For now, ignore message changed events.
If a plugin needs to reprocess these messages, we can decide to handle
these events at that time.

@arcticfoxnv  Could you please take a look at this one?


Start top down refactor

This is the original pix-plot library by YaleDHLab with the following changes
to prepare for refactor:

Search-and-replace pixplot with clipplot
Changes to readme
Barebones setup to start developing with nbdev
Copied legacy pixplot library into clipplot_legacy folder
Yale license carried, just applying to the clipplot_legacy folder

re-create PR after fixing setup.py


Provide a function to start a workflow for each child record

Hi Damian,
please could you provide a function to start a workflow for each child record?
This would be great in complex situations, where "Update Child Records" is not sufficient enough.
Many thanks in advance.

thanks, another one for the backlog that is growing.
you can also try to develop by your own, and make a pull request to this project and share with the community... ;)
thanks

Believe me, nobody wants my code - I'm not a developer :-)
It would be great if this could be done by somebody experienced.


Add Tvs where package was tested and running well and Solve issue #107

Add commits to solve Issue #107 , Now run-webos list devices on console

@raphamorim  :)


Automated cherry pick of #170: not register azure classic host data

Cherry pick of #170 on release/3.2.
#170: not register azure classic host data

/lgtm
/approve


utils: add special serializer for numpy.int64

I don't know if this is papering over another issue but it looks to fix the issue for me :)
It looks like COUNT(*) returns a numpy.int64 value that the
default JSONEncoder does not handle.
While at if we get a type we are not handling make it easier to
debug the issue by throwing a TypeError exception with useful
data.
Fix #486

Coverage decreased (-0.08%) to 81.972% when pulling c0ff4dc7ec0990238a70c81d671caadc8646c837 on xrmx:serializenumpy into 4738b011256c7ea83337aa4e4313c140af05a33c on airbnb:master.

Perfect. Yeah this is probably specific to Pandas / SqlAlchemy subtle differences on casting that varies based on different database engine.