quotaExceeded error after adding 1000 URLs in Google Search Console

I have asked this on SO.
http://stackoverflow.com/questions/35155515/quotaexceeded-403-error-on-google-search-console-apis
I am using service account to authenticate API calls and I am doing batch request to add sites to search console.
Using php Google API client lib, how can I set quotaUser optional query field. I am not sure why this is happening.

Do you have an API Key set?
$client->setDeveloperKey($myApiKey);

Nope, Why do we need to set developerkey if we are using service account's json credentials ?
Someone replied on google product forums regarding this. I was using sites add API to add an page URL not a domain name. I was adding something like, http://example.com/blog/2016-02-18-hello but the api is intended to use to add the domain name like http://example.com/ .
Am I wrong ?

Yeah that sounds right. I'm glad you figured it out?


Can spdm-emu requester work with different responder (not exactly same spdm-emu responder) ?

Hi,
We are planning to implement our own responder lib (it will not be exact same libspdm but with quite of modifications as per our device implementation) which will be hooked up to spdm-emu responder. But spdm-emu requester would still be the same using vanilla libspdm beneath.
Is it some feasible approach ? Or there are some hidden considerations that the way spdm-emu requester and responder designed to work with only same vanilla libspdm ?
Thanks,
Manish

Is it some feasible approach ?

It is. It seems like the bulk of SPDM development is in Responder devices, and folks are using the spdm-emu Requester to test them out.

Or there are some hidden considerations that the way spdm-emu requester and responder designed to work with only same vanilla libspdm ?

Hopefully not and if so that would signal a bug in libspdm or the SPDM specification.

Right. It is feasible, as long as you follow the library header file definition.
There is no hidden assumption. If you find, you may file an issue.

Question answered. Close.


Diseased samples got lower PRS than healthy samples

Hi bvilhjal,
I am experiencing the same issues as the one you close (https://github.com/bvilhjal/ldpred/issues/120).
I have tested two versions: v. 1.0.10 and v1.0.11. Both versions give negative slopes for the prediction.
You mentioned the bug was fixed in v1.09, which I could not find on github.
Any comments or suggestions would be appreciated.
Best wishes,
gy

It looks fine to me. Actually, I can see that I experience the same thing with the 1.0.10! When comparing my results from the output of 1.0.10 to 1.0.6, there is a complete anti-correlation between the two. Something seems to have gone wrong in the newer versions :(


⚠ Rumah123 has degraded performance

In acd8cd4, Rumah123 (https://www.rumah123.com) experienced degraded performance:

HTTP code: 504
Response time: 20751 ms

Resolved: Rumah123 performance has improved in 1ba1cf0.


Use BUSYBOX constant in tests instead of string

Current coverage is 50.38% (diff: 100%)

Merging #500 into master will decrease coverage by 0.03%

@@             master       #500   diff @@
==========================================
  Files            83         83
  Lines          3253       3253
  Methods           0          0
  Messages          0          0
  Branches        460        460
==========================================
- Hits           1640       1639     -1
  Misses         1463       1463
- Partials        150        151     +1

Powered by Codecov. Last update 6be2276...94bcf2f


Switching to Eigen version with HIP support.

This PR does the following things.

Update the Eigen commit pointer to the first Eigen version with HIP support

Update TF codebase with changes necessitated by the API changes in the
Eigen version with HIP support. Basically some APIs names/ header files
were updated from Cuda to Gpu

Resurrects the eigen patch file to workaround an eigen change (commit : 4af74f577a4fc09dcfa202064e1291038d2046da) which breaks the TF build
There is bug filed on Eigen to track this failure
http://eigen.tuxfamily.org/bz/show_bug.cgi?id=1569
A recent eigen commit fixes that bug. The eiegn patch file can be removed once we advance the eigen commit pointer to a commit that contains the fix

@deven-amd unfortunately this PR cannot be accepted, since it would break TF internally at Google. The internal version of Eigen at Google has diverged from upstream and importing the HIP-related patches is not possible at the moment. We will have a better estimate by the end of next week for how long it will take to remedy this situation.

@benoitsteiner @yifeif I am adding the "read to pull" label in order to be able to pull this manually. DO NOT MERGE.

@deven-amd It looks like you missed a Cuda reference here:
INFO: From Compiling tensorflow/core/util/cuda_kernel_helper_test.cu.cc:
tensorflow/core/util/cuda_kernel_helper_test.cu.cc(134): error: namespace "Eigen" has no member "CudaStreamDevice"
1 error detected in the compilation of "/tmpfs/tmp/tmpxft_0000386f_00000000-6_cuda_kernel_helper_test.cu.cpp1.ii".
I think this should be changed to GpuStreamDevice.

@rmlarsen you are right.
While I did run the eigen unit tests (CUDA and HIP) with these changes, for tesnorflow, only the HIP side was tested. That would explain why I missed the error in the CUDA test. Sorry about that, please apply the fix as need, and thank you.

also for all the CI failures that are listed, please let me know if there is anything that needs to be done on my end. I tried looking at the "Details" of the failures. It lists the failing targets but not much more information beyond that

@deven-amd could you please pull rebase and push again?

@drpngx
did the rebase and push.
also added the CudaStreamDevice --> GpuStreamDevice update in tensorflow/core/util/cuda_kernel_helper_test.cu.cc

NOTICE: This PR cannot be accepted at the moment. We will are working on bringing our internal version of Eigen in sync with upstream and will be able to accept this PR shortly, probably within a week or so.

Nagging Assignees @benoitsteiner, @rmlarsen: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@rmlarsen ping?

Nagging Assignee @rmlarsen: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @rmlarsen: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@deven-amd could you pull rebase and push again?

@drpngx done.

Removing the merge label. Waiting for @rmlarsen to confirm.

Nagging Assignee @rmlarsen: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@rmlarsen
I see the following commit today, which I believe is a super-set of this PR
https://github.com/tensorflow/tensorflow/commit/cf02d61a83bf14d553b81e1cee6ba604f05a7758
Please confirm, and if correct, we can close out this PR
deven

Nagging Assignee @rmlarsen: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@deven-amd This PR is no longer necessary. TensorFlow was switched to a version of Eigen supporting HIP on November 7. We have done weekly incremental updates since and are now comfortable moving forward.


Add peer router id into get_bgp_neighbors_detail()

At present the remote peer router id is only available in the output of get_bgp_neighbors() and not in get_bgp_neighbors_detail().
@dbarrosop suggested that get_bgp_neighbors_detail()[my_vrf][my_neigh_ip] could be used to get this information (slight typo I think, probably should be get_bgp_neighbors()[my_vrf][my_neigh_ip]) but that supposes that you have the VRF information available (or else you have to loop through the VRFs to find the peer).
If 'routing_table' in get_bgp_neighbors_detail() is the same as the VRF in get_bgp_neighbors() then this isn't an issue. If they are not, then I propose adding the remote peer router id into the get_bgp_neighbors_detail() method.

I can add the peer router id information for all devices supporting ```get_bgp_neighbors_detail``, no problem.

but that supposes that you have the VRF information available (or else you have to loop through the VRFs to find the peer).

How else are you supposed to do it? You need to know what you are looking for or loop through the data. I actually realized that get_bgp_neighbors_detail and get_bgp_config are flawed by design as I just realized they don't support VRF. We will have to revisit that.

Not sure if the docs reflect reality, but for get_bgp_neighbors() the docs say

The keys for the first dictionary will be the vrf

so that suggests its VRF aware.
.

Indeed get_bgp_neighbors does, but get_bgp_neighbors_detail does not, although it should. But this will be probably fixed soon and both will have VRF support!

Thanks @inetuid for raising this issue!

Can we close this one?

Yes, the latest release contains these details now. We can close this issue.


Update coverage badges

Coverage increased (+0.1%) to 91.03% when pulling 5929b6f1babf6fd17c14cff1fe7c7a7beca80572 on update_badges into 949ab111dd7325e74ad0427e7e3301ef1a313b15 on develop.


Need toast "Multisig with Trezor coming soon"

[x] Note to devs: The item may be greyed out, so when the user touches it, there will be a toast "Multisig with Trezor coming soon"

[x] @akshay8551 make this as per Xd link comment

Subheading and many things are changed
https://xd.adobe.com/view/f1543c84-c25a-4ad6-81ca-1e0c540e956e-a407/screen/e1437da7-8274-46ea-aa59-40999661cf5b/

@Deveshshankar, In the subheading error ("Multisig with Trezor coming soon")  msg already there. No need to show toast there.

verified this issue on keeper app v 1.2.0(319)


Linking of issues

Using the # to link issues together.
Ideas:

Jira like system, related to, is a smaller work item of, is a larger work item of, blocked by, blocks

Will do as needed.


Contract class + apply entrypoint mapping

Just as in the cpp library, we should be able to simply define the functions of our contract, and have the library deal with mapping the apply entrypoint. Perhaps this can be done with annotations?
https://github.com/EOSIO/eos/blob/master/contracts/eosiolib/dispatcher.hpp#L76

We can use decorators (not supported by assemblyscript) and write a transpiler here.


Can I start the show event when scroll end.

I have many node to show.But there are to many node to render when I scroll fast.And it costs to much time .

You can set either debounce or throttle to true to ease this  situation, please refer to the document for detailed explanation.

closed for no further update


[WIP] Improve All Docs

We'd like to improve and enhance all current documents in Chainer. Then I’m starting with just reading all texts in the documentation first. Now the tasks currently considered are:

[ ] Establish rules to describe documents

[x] When we give an example code in each docstring for a Function, abbreviations like F for chainer.functions and L for chainer.links, or np for numpy can be used?

Using abbriviations is OK with the notation about them on the top of the reference page

[x] As for the usage of descriptive name for a variable, when an equation fit into one line, use descriptive name like batch_size, height, and width, etc. instead of b, h, and w for variables in the equation, otherwise, use those one character names

It depends on the case, so it can be varied.
Just as a guideline (not as a strict policy), if the math equation is very long or complicated, each variable should be short so one-character variable like b or h can be used. On the other hand, if the equation is very simple and short, the variables contained in the equation can have longer names that possibly correspond to some variables used in the code.

[x] How should the "shape" of a variable be described: as a math form with :math:  `(n, c, h, w)` or just as a code with `(n, c, h, w)`

Sometimes the shape could be represented with some greek characters, so the math form is better. Use the math form for all shape notations.

[x] How should it be detailed when one might add examples to each API, IOW what should be shown in the examples?

Example can have the typical usage, and varied usage depending on the arguments of the methods
Starting with writing documentations for simple Functions is fine. Let's find the problem during it.

[ ] Fix corrupted math equations
[ ] List up insufficiently documented part
[ ] Discuss how to organize all the contents to effectively show all functions and relationship between them, etc.
[x] List up blog-like how-to topics for introducing main features of Chainer

What is Trainer and how to use it?
How to customize dataset_mixin, Updater, and Iterator
How to define your own Extension for Trainer
How to define your own Function and Link

Write them first, and select the place to publish those

[x] Contents for the developers guide

I'd appreciate it if you could add any comments on what documentation (for Chainer) should be, and anything related.

Could you list the functions to which we need example to the docstring? @shiba24

Moved to #2576


Release v0.5.0.post1

Release summary
Version number: 0.5.0.post1
Release details
Autonomy:

Patches packages command group to adapt latest changes from open-aea

Packages:

Fixes version specifiers for open-aea-test-autonomy and open-aea-ledger-ethereum

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I am making a pull request against the main branch (left side), from develop
[x] I've updated the dependencies versions to the latest, wherever is possible.
[x] Lint and unit tests pass locally (please run tests also manually, not only with tox)
[x] I built the documentation and updated it with the latest changes
[x] I've added an item in HISTORY.md for this release
[x] I bumped the version number in the __init__.py file.
[ ] I published the latest version on TestPyPI and checked that the following command work:
pip install project-name==<version-number> --index-url https://test.pypi.org/simple --force --no-cache-dir --no-deps
[ ] After merging the PR, I'll publish the build also on PyPI. Then, I'll make sure the following
command will work:
pip install project-name-template==<version_number> --force --no-cache-dir --no-deps
[ ] After merging the PR, I'll tag the repo with v${VERSION_NUMVER} (e.g. v0.1.2)

Failures are caused by subprocess timing out
    def _check_timeout(self, endtime, orig_timeout, stdout_seq, stderr_seq,
                       skip_check_and_raise=False):
        """Convenience for checking if a timeout has expired."""
        if endtime is None:
            return
        if skip_check_and_raise or _time() > endtime:
>           raise TimeoutExpired(
                    self.args, orig_timeout,
                    output=b''.join(stdout_seq) if stdout_seq else None,
                    stderr=b''.join(stderr_seq) if stderr_seq else None)
E           subprocess.TimeoutExpired: Command '['/Users/runner/work/open-autonomy/open-autonomy/.tox/py3.9-darwin/bin/python', '-m', 'autonomy.cli', 'analyse', 'fsm-specs']' timed out after 60.0 seconds


If the media type for a manifest is unrecognized, default to schema1

This is needed for compatibility with some third-party registries that
send an inappropriate Content-Type header such as text/html.

Current coverage is 53.70%

Merging #1383 into master will decrease coverage by -4.21% as of c01fe47

@@            master   #1383   diff @@
======================================
  Files          123     123
  Stmts        11156   11158     +2
  Branches       778     707    -71
  Methods          0       0
======================================
- Hit           6461    5992   -469
+ Partial        778     707    -71
- Missed        3917    4459   +542

Review entire Coverage Diff as of c01fe47

Uncovered Suggestions

+0.28% via ...ge/driver/gcs/gcs.go#182...213
+0.24% via ...ge/driver/gcs/gcs.go#85...111
+0.21% via ...ge/driver/gcs/gcs.go#471...494
See 7 more...

Powered by Codecov. Updated on successful CI builds.

LGTM

LGTM


Multi-chain multisig. Creation with EVM addresses lead to wrong multisig

Description
When user create multi-chain multisig with EVM accounts - it will create wrong multisig account.
Steps to Reproduce

User has 2 wallets with EVM accounts
Go to multisig creation flow
Select 2 wallets with EVM addreses
Create multisig wallet

Expected Behavior
?
Multisig with different addresses for EVM and Substrate? Or ban to create that type of multisigs
Actual Behavior
Was created broken multisig

Status verification: ❌
What has been verified:

creation multichain multisig

Case:

Go to multisig creation flow
Add as signatory - PolkadotVault single wallet, contact from address book, select threshold 2
Create multisig wallet
Go to wallet details

Actual result:
Is shown accounts for each available networks

Expected result:
There is no accounts for evm networks

Status verification: ✅


Set right default value for maxIterations

Defining the default value of $maxIterations to be false define the variable as boolean by "default".
Since the variable is then casted as an integer and (int) false === 0 I think it preferable to define the default value at 0 so it tells that the variable should be an integer

Make sense the change proposed. Nice work improving travis!

Released in https://github.com/javibravo/simpleue/releases/tag/1.1.2


Port to Main: Fix Workspace service disposal killing OOP connections.

Original PR to a release branch: https://github.com/dotnet/aspnetcore-tooling/pull/3920
Just porting to main 😄

When workspaces get disposed they kill all workspace service event loops which in turn ends up killing OOP host connections in Visual Studio resulting in several yellow bars after closeing/reopening a solution.
Created a new LanguageServerWorkspace type that does basically everything that the AdhocWorkspace did before BUT handles Dispose differently. In Dispose we call through to the base workspace's dispose but then notify it that it's a finalizing Dispose to change what happens. Ultimately this is a huge hack but once Razor's components are no longer tied to the Roslyn workspaces' services can be removed.

Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1352348

Closing in favor of: https://github.com/dotnet/aspnetcore-tooling/pull/3933


chore: bdd-spring-1582899913 to 0.0.1

chore: Promote bdd-spring-1582899913 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[no-jira] testing new groovy and spock

not working out of box, will need time to investigate, closing this PR for now


S2 transfer from ASF and fix filename on the fly

From a Sentinel-2 pair like
S2A_6VXP_20210408_0_L1C S2A_6VXP_20210418_0_L1C

autoRIFT currently produces a netCDF with the name
S2A_20210408_L1C_X_S2A_20210418_L1C_G0120V02_P072.nc

However, this name is not necessarily unique as multiple Sentinel-2 acquisitions will have the same time at the precision used in the file name. If instead the autoRIFT files included the whole Sentinel-2 filenames
S2A_6VXP_20210408_0_L1C_X_S2A_6VXP_20210418_0_L1C_G0120V02_P072.nc

the "tile" section would prevent clobbering.
This PR modifies the ingest script to:

take a CSV with columns: job id, corrected filename
when transfering, use the corrected filename.

NOTE: I have not tested this! This is also a one-off to fix problem in already generated files and likely shouldn't be merged as the filenames should be fixed upstream.

@mliukis here's the associated CSV for this PR
s2_mini_ak_sv_jk_succeeded_pairs.csv


net/http Server segfault

When an unexpected service arg is passed, on OS X, there is a segfault:

Segmentation fault: 11

Possibly down in os_socket() via os_listen_tcp().
Simplish test case:
use "net/http"

actor Main
  new create(env: Env) =>
    Server(recover Listener end, recover Service(env) end, CommonLog(env.out), "<IP_ADDRESS>", ":8080")

class Listener // is ServerNotify
  new create() => None
  fun ref listening(server: Server ref) => None
  fun ref not_listening(server: Server ref) => None
  fun ref closed(server: Server ref) => None

class Service // is RequestHandler
  let _env: Env

  new create(env: Env) => _env = env

  fun apply(request: Payload val): Any =>
    for b in request.body().values() do
      _env.out.print(b)
    end

Doh, nice catch. Should have a fix in soon.


global: model simplification

Signed-off-by: Jiri Kuncar<EMAIL_ADDRESS>

Coverage remained the same at 100.0% when pulling ac168a1086229027b7560059f30de1a54eaa12a7 on jirikuncar:simplify into fe16baa73f5ac7b909005e29c94ef3bb8bd209dc on inveniosoftware:master.

Coverage remained the same at 100.0% when pulling ac168a1086229027b7560059f30de1a54eaa12a7 on jirikuncar:simplify into fe16baa73f5ac7b909005e29c94ef3bb8bd209dc on inveniosoftware:master.


Enforce static calls in the kernel

Currently the kernel accept flags for whether the call is static or not, however it don't actually enforce anything based on that flag.
If a call is static it should ensure that:

It don't modify any state
Child calls are set to be static as well

Authwitness is currently assuming that static calls will be enforced at some point, until then, it is allowing all the flows you could want re-entries and other good stuff.

Looks like this should have been closed when #4106 was merged.


set onCancelListener in ColorChooserDialog

[x] I have verified there are no duplicate active or recent bugs, questions, or requests
[x] I have verified that I am using the latest version of Material Dialogs.
[x] I have given my issue a non-generic title.
[x] I have read over the documentation (before asking questions on how to do something).

Include the following:

Material Dialogs version: <IP_ADDRESS>
Device OS version: 7.1.1
Device Manufacturer: Emulator
Device Name: Nexus 6P

Also, please wrap Java with correct syntax highlighting.
new ColorChooserDialog.Builder(this, R.string.color_chooser)
     ...
     .cancelButton(R.string.cancel)
     ...

ColorChooserDialog is a DialogFragment so setting interfaces to it is not a good idea (they are not maintained through orientation changes). You could extend ColorChooserDialog in your own class and override onCancel.


setting a data attribute on an element adds extra quotes around string

Current behavior

$('h1').eq(0).data('foo','bar')
//outputs
Header Text

Expected behavior

$('h1').eq(0).data('foo','bar')
//outputs
Header Text

It's not extra, otherwise you wouldn't be able to set "1" and get "1" back rather than 1.
This is mentioned in the migration guide: https://github.com/fabiospampinato/cash/blob/master/docs/migration_guide.md#data

If you want $.fn.data to behavelike$.fn.attryou should just use$.fn.attr`

Yeah I just used attr. Thanks for the fast response, forgot about that guide!


Fixing markdown to patch error on K8 website

Showing up with triple ticks 'shell' on website
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/
Trying to fix a small rendering issue on the docs site

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.
For pull requests on 1.17 Features: set Milestone to 1.17 and Base Branch to dev-1.17
For pull requests on Chinese localization, set Base Branch to release-1.16
Feel free to ask questions in #kubernetes-docs-zh
For pull requests on Korean Localization: set Base Branch to dev-1.16-ko.<latest team milestone>
If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.
If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

/assign @jaredbhatti

I re-requested they send the CLA and its not working.
I'm pretty sure I completed the sign up process. I don't know why that check is failing.

@jaredbhatti
I don't know why the CLA check is failing?

Hi @bigorangemachine, sorry for the difficulties. Did you sign the CLA using the same email address that's connected to your GitHub account? Could you try signing again?

/check-cla

@tfogo
Yup! I signed up using my GH account and the main email associated with that account. I already gave a Google contributions via the CLA on the same account :/

Hi @bigorangemachine please check the troubleshooting section here: https://github.com/kubernetes/community/blob/master/CLA.md#troubleshooting.
If you are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/

/close
Hi @bigorangemachine !!!
Closing this PR for now. Please feel free to reopen after you sign the CLA.


Multiple skills with the same tag will keep adding the tag to the filter

All skills that share a tag will add that tag to the filter when the tag is clicked, allowing for the tag to be duplicated in the filter

:+1:


Added caching documentation for the java SDK

Hi guys,
I have added the java SDK documentation (including default values).
Cheers,
Olga

Thanks @sw-tracker! 👍


Upgrade Envoy to 1.15.3

Describe the bug
Envoy 1.15.1 (current version used by Ambassador) is affected by CVE-2020-35470 (https://nvd.nist.gov/vuln/detail/CVE-2020-35470). Issue was fixed in Envoy and was backported to 1.15.3.
Here is the original issue https://github.com/envoyproxy/envoy/issues/14087
Versions (please complete the following information):

Ambassador: 1.12.1 and prior

Ambassador (as of 1.13.4) is based on Envoy 1.15.5, so it should include these fixes (and more).


REPL window throws ActivityLog error after switching from ES6->ES5

Using latest build from master (VS2015 U2, 6/11/2016)

had interactive window open
switched from ES6->ES5
started typing in interactive window
activity log error dialog pops up

Relevant ActivityLog entry:
System.ObjectDisposedException: Cannot access a disposed object. at
System.Threading.TimerQueueTimer.Change(UInt32 dueTime, UInt32 period) at
System.Threading.Timer.Change(Int32 dueTime, Int32 period) at
Microsoft.NodejsTools.Intellisense.VsProjectAnalyzer.BufferParser.BufferChangedLowPriority(Object sender, TextContentChangedEventArgs e) at
Microsoft.VisualStudio.Text.Utilities.GuardedOperations.RaiseEvent[TArgs](Object sender, EventHandler`1 eventHandlers, TArgs args)

Also, the same error occurs when switching from ES5->ES6

This likely was revealed by #881, which added the dispose pattern to BufferParser in order to fix a memory leak around Timer. Switching IntelliSense levels should not be too common, but hopefully the fix here is an easy one.


Missing attribute Vaadin-Package-Version in Addon-Zip

Hi,
the task 'vaadinAddonZip' creates a manifest which misses
'Vaadin-Package-Version': '1',

This causes the Upload to the Vaadin directory to fail with:

Responsible method is gradle-vaadin-plugin/src/main/groovy/fi/jasoft/plugin/TaskListener.groovy#configureAddonZipMetadata.
Thanks,
Michael

@moberwasserlechner Could you make a pull request with that commit?

Sorry I totally forget about the change. I created the PR.

Thanks for the PR!


English README

Hey @KevinGong2013, your library looks really useful! I understand that it is used to scan Chinese ID cards, but we still need an English README so people from all over the world can implement your library.
Please fix this issue before we can approve your PR

OK， I will refine it. 😊


[SP-4476] Backport of PDI-16888 - Title bar of several steps doesn't …

…have the correspondent name of the step (8.1 Suite)
@pentaho-lmartins @cravobranco @ricardosilva88

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'pom.xml' -pl 'ui' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'ui' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  ui/src/main/java/org/pentaho/di/ui/job/dialog/JobDialog.java
  ui/src/main/java/org/pentaho/di/ui/trans/step/BaseStepDialog.java

Newly Broken Tests:
org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.testMqttStreamSingleTopic:
:red_circle: junit.framework.AssertionFailedError
junit.framework.AssertionFailedError
	at org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.getQuickly(MQTTStreamSourceTest.java:253)
	at org.pentaho.di.trans.step.mqtt.MQTTStreamSourceTest.testMqttStreamSingleTopic(MQTTStreamSourceTest.java:122)

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: -16.4% (click to expand)
:new: org.pentaho.di.trans.steps.aggregaterows.AggregateRows

Branch Coverage: 36.2% :exclamation:
Complexity Coverage: 30.3% :exclamation:
Instruction Coverage: 55.2% :exclamation:
Line Coverage: 60.5% :exclamation:

:new: org.pentaho.di.trans.steps.aggregaterows.AggregateRowsMeta

Branch Coverage: 0% :exclamation:
Complexity Coverage: 2.2% :exclamation:
Instruction Coverage: 10.4% :exclamation:
Line Coverage: 7.6% :exclamation:
Method Coverage: 4.5% :exclamation:

:new: org.pentaho.di.ui.trans.steps.aggregaterows.AggregateRowsDialog

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.steps.rules.Rules

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.steps.rules.Rules.Column

Complexity Coverage: 50% :exclamation:
Instruction Coverage: 42.4% :exclamation:
Line Coverage: 46.4% :exclamation:
Method Coverage: 50% :exclamation:

:new: org.pentaho.di.trans.steps.rules.Rules.Row

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.steps.rules.RulesAccumulator

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.steps.rules.RulesAccumulatorData

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.steps.rules.RulesAccumulatorMeta

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.steps.rules.RulesAccumulatorMeta.StorageKeys

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.steps.rules.RulesExecutor

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.steps.rules.RulesExecutorData

Branch Coverage: 50% :exclamation:
Complexity Coverage: 39.1% :exclamation:
Instruction Coverage: 45.9% :exclamation:
Line Coverage: 41.9% :exclamation:
Method Coverage: 37.5% :exclamation:

:new: org.pentaho.di.trans.steps.rules.RulesExecutorMeta

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.steps.rules.RulesExecutorMeta.StorageKeys

Coverage: 0% :exclamation:

:new: org.pentaho.di.ui.trans.steps.rules.RulesAccumulatorDialog

Coverage: 0% :exclamation:

Note: The list of offending coverage changes extends beyond the presented results and was truncated to prevent reaching the comment size limit.

License header violations

:heavy_exclamation_mark: Copyright year is not the current year on ui/src/main/java/org/pentaho/di/ui/trans/step/BaseStepDialog.java. Found 2017. Was expecting 2018

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/ui/src/main/java/org/pentaho/di/ui/trans/step/BaseStepDialog.java

:heavy_exclamation_mark: Unused import - org.eclipse.swt.events.ShellAdapter. at Line: 33 Column: 8

:heavy_exclamation_mark: Unused import - org.eclipse.swt.events.ShellEvent. at Line: 34 Column: 8


What is the best practice for adding C++ lib to C projects?

Hello ,
I'm working on cyphal application and trying to port it to my own project (freertos + STM32). Since my project has been using pure C, I'm new to porting C++ projects. I saw your Stm3 2 The flight control project introduces the C++ environment only through the following code. Is there anything else I need to pay attention to, such as compiler options?
`
#ifdef __cplusplus
extern "C"
{
#endif
//void startup(void);
#ifdef __cplusplus
}
#endif
`

Will a C implementation be provided?

Hello.
In general, you just need to compile the library related source files with C++ compiler and link it correctly with your project.
The Mini v2 example is based on CMake, which automatically detects the required compiler by the file extension (g++ for .cpp and gcc for .c). I don't remember using some additional compiler options. Well, you can check them all in CMakeLists.txt.
I just wrapped the C++ code with extern "C" and explicitly specified the languages in the beginning of CMakeLists.txt:
project(example CXX C ASM)

Is your project based on makefile, cmake or some IDE?

Thanks for you reply,
I've added C++ support to my project, but due to chip resource limitations (rom 64K + ram 20K), I'm worried that it is not enough to ensure good running of C++ code. It would be great if there is a minimal C implementation. But this library is a good start for me, thanks


add method approve

Coverage increased (+0.004%) to 76.258% when pulling dfa8386cfae55cdb9df6e5d1580738d4c0b469df on indriHutabalian:dev into 7e45c24a5dec72e18f57327ed057d957da9cd133 on danliris:dev.


Set up Login page

Input handlers
Modal window popups for CREATE ACCOUNT and Forget Password

MainCommit 1efbd40.
Referenced sub-commits before: f2b6123, 5e518fa for Sign Up form and 0eb99e4 for Forget Password form.


exit code when some rule was triggered

Is there some sort of porcelain option?
https://travis-ci.com/DanielRuf/clamav-test/jobs/186947143#L315 returns an exit code of 0.

yara returns exit code 0 on success, and 1 if an error occurs. Do you want a different exit code when a match occurs and and when it doesn't?

yara returns exit code 0 on success, and 1 if an error occurs

Well, how do I check then on CI if a rule was matched? Like we do with yarn/npm audit and so on.
References:
https://github.com/yarnpkg/yarn/pull/6819
https://travis-ci.com/DanielRuf/clamav-test/jobs/186947143#L316
Because 0 means everything is ok but I would like to get an exitcode of 1 or > 0 when a rule is matched.

Do you want a different exit code when a match occurs and and when it doesn't?

Exactly.

YARA uses the POSIX convention for exit codes, and we shouldn't change it as it may break existing scripts. You can write some script that invokes YARA, check if it produces the expected output, and return an exit code accordingly.

check if it produces the expected output

Ok, sounds reasonable. Thanks for the feedback.
But it could be maybe an optional flag in the future to produce the needed exit code > 1.

I considered adding a flag that changes the exit code behavior, but still I'm not convinced about this approach neither. It adds complexity to YARA for something that will be used in very specific scenarios that can be solved in some other ways.

Understood. Many thanks for taking the time to answer my proposal / feature request.

Hm, is this excepted (3.4.0)?
$ yara --version
yara 3.4.0
The command "yara --version" exited with 1.

Why do they all print the exit code 1 which would be an error or be sent to stderr?


Re-enable the macOS conflict acceptance tests

Motivation
We didn't re-enable the macOS conflict tests as part of PR #1613.
(The comment said we were waiting for PR #1631, but we were actually waiting for #1613.)

Windows will fail until #1782 is merged

macOS failed because try_wait doesn't work, just like Windows. See #1781.

The testnet large sync failure will be fixed by #1789

Removing all the blockers, because closing the PR didn't do that for some reason 😢


Small link fix

fixed the two remaining links.
Not sure what the deal is with the third unchecked link is (the one marked duplicate?). It's the same link as the one above it.

LGTM


[T5A2][W11-B4] Tay Keming Justin

@INCENDE
Some comments added. Please ack & close the PR after reading comments.


[FEATURE] Handle interpolation and differencing to internal boundaries

Is your feature request related to a problem? Please describe.
Many ocean models have "internal" boundaries, i.e. outcrops of bathymetry, that manifest as missing values (NaNs) in the data variables. When we call grid.interp or grid.diff along the X or Y axes of such variables, we end up with NaNs whenever there is a boundary neighbor. This differs from how a GCM would handle such boundaries internally. A GCM would instead apply a different algorithm, like a Dirichlet or Neumann boundary condition, at these specific points.
Describe the solution you'd like
We should have the option to handle internal boundary conditions. This will require refactoring of our core low-level algorithms for diff and interp. Perhaps an opportunity to refactor those routines to use numba.

If I understand correctly this could be handled with #344? Ill keep open for now.


Add extra assertions to UserSkill controller test

From #78
The RoleSkills controller test has some useful assertions.
Since UserSkills are nearly identical in behavior, porting those assertions would also be useful.

Belongs to #26.

Actually going to close this because these assertions look to be better handled in view tests and not in the controller tests.


Let readRuleFile() require a file name

Calling readRuleFile() without a file name is meaningless and should be
considered as an error.

readRuleFile still needs to be called with a filename.  The change leaves it without a filename parameter.


Prometheus Startup Error

Trying to start Prometheus?
What did you expect to see?
I'm trying to start prometheus, im getting the below error
INFO[0000] Starting prometheus (version=1.1.2, branch=master, revision=36fbdcc30fd13ad796381dc934742c559feeb1b5)  source=main.go:73
INFO[0000] Build context (go=go1.6.3, user=root@a74d279a0d22, date=20160908-13:12:43)  source=main.go:74
INFO[0000] Loading configuration file prometheus.yml     source=main.go:221
ERRO[0000] Error loading config: couldn't load configuration (-config.file=prometheus.yml): yaml: line 6: found character that cannot start any token  source=main.go:126
RHEL 6

System information:

Linux 2.6.32-573.12.1.el6.x86_64 x86_64

Prometheus version:

prometheus, version 1.1.2 (branch: master, revision: 36fbdcc30fd13ad796381dc934742c559feeb1b5)
build user:       root@a74d279a0d22
build date:       20160908-13:12:43
go version:       go1.6.3

Alertmanager version:

NA

Prometheus configuration file:

global:
  scrape_interval:     5s
  evaluation_interval: 5s
scrape_configs:
- job_name: linux
target_groups:
        -targets: ['<IP_ADDRESS>:3306']
          labels:
            alias: db1

Alertmanager configuration file:

NA

Logs:

insert Prometheus and Alertmanager logs relevant to the issue here

You have to put a space after the - in -targets. Please use a YAML linter for future YAML syntax errors: http://www.yamllint.com/

Thanks fabxc. I have started it, but i'm unable to open the prometheus link in my browser. It says site can't be reached. I know these doubts are silly. Would be glad if you could help me. Does it have to do with proxy or anything?


derive or implement fmt::Debug for public types

@zargony thanks for this library!
I was slightly surprised to find that I couldn't print out a request with "{:?}", inspiring this pull request that adds Debug derivations (and turns on the missing_debug_implementations lint), as recommended in the std::fmt documentation.

Very good idea. Thanks for adding this!


Update Mactracker to 7.4.6

Thank you for the contribution. It was merged directly as 39f195c666592172c450e27bf7fd8fbf2e3436c0 to keep commit history cleaner. Your contribution is still credited to you.


Treat database exceptions

ApiCompanyIndex - UNIQUE constraint failed: company.domain
open database fails to get the keys

In 0.4.0 all database errors are treated in each lib. No reason to centralize that in the app level.


Updated backwards compatibility of docker commands

Depends on #41

Please remove client.rs & transaction.rs modifications from this PR


Pattern: Content item horizontal: Misalignment to grid

Content item horizontal: Misalignment to grid

Describe in detail the issue you're having.

Pattern is not properly aligning to the grid columns and layout

Is this a feature request (new component, new icon), a bug, or a general
issue?

Bug

Is this issue related to a specific component?

Content item horizontal

What did you expect to happen? What happened instead? What would you like to
see changed?

As seen in Storybook:
Pattern is spanning 11 columns rather than 10
Pattern is starting on the 3rd column rather than the 5th
Description text and links are not aligned to a grid column
As seen in Large, XL and Max breakpoints

Medium breakpoint:

As expected from visual specs:
Pattern spans 10 columns
Pattern begins on the 5th column
All text and links are aligned to grid columns

What browser are you working in?

Chrome

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?

IBM.com Reboot
Steps to reproduce the issue
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/2333/index.html?path=/story/patterns-sub-patterns-contentitemhorizontal--default

Notes from June 11, Leadership planning meeting.
The grid alignment will be fixed all at once.  Wonil will perform an audit and provide the information to Roberta so that Dev issue can be created.  This issue and (#2670) will be referenced in the new dev issue and closed.


Fix embedded cover art

The PR is to fix embedded cover art
Inspired by https://github.com/hbashton/spotify-ripper/pull/53

Thanks for the merge request. I've not been using spotify-ripper for a few weeks and now I'm having issues with spotipy, so I can't really test and create a new tag:
Traceback (most recent call last):
  File "/usr/lib64/python3.9/threading.py", line 954, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.9/site-packages/spotify_ripper/ripper.py", line 163, in run
    init_spotipy(self.session.user.canonical_name)
  File "/usr/lib/python3.9/site-packages/spotify_ripper/spotipy_integration.py", line 17, in init_spotipy
    token = spotipy.util.prompt_for_user_token(username, scope)
  File "/usr/lib/python3.9/site-packages/spotipy/util.py", line 96, in prompt_for_user_token
    token_info = sp_oauth.validate_token(sp_oauth.cache_handler.get_cached_token())
  File "/usr/lib/python3.9/site-packages/spotipy/oauth2.py", line 325, in validate_token
    token_info = self.refresh_access_token(
  File "/usr/lib/python3.9/site-packages/spotipy/oauth2.py", line 554, in refresh_access_token
    raise SpotifyException(response.status_code,
spotipy.exceptions.SpotifyException: http status: 400, code:-1 - Couldn't refresh token: code:400 reason:Bad Request, reason: {'Authorization': 'Basic YjJhNmY1NDkzMzlkNDhjMmJlM2MwYzUwMWZhMmM4MzA6NTE0YjM0OWNhZTFjNDBkNmI1MmM0OThkNWZiNjFhZmE='}

Not clear to me what has changed. Any hint?

Ok fixed, I just had to delete the cache file.


Improve ticket iterations & lookups

The criteria for ticket equality according to InsertNewTicket requires that the ticket hash as well as the fee address and the fee address index are identical. Tickets in the database are currently keyed by only their hashes however, requiring each ticket in the database being unmarshalled just for fee address and fee address index comparisons when checking for duplicates on inserting a new ticket into the database. I suggest using a composite key comprising of the fee address index, fee address and the ticket hash: <fee address index><fee address><ticket hash>. This composite key mitigates unmarshalling all tickets for comparison purposes when inserting a new ticket since all comparison data can be extracted from the key.
If there are no objections I'd like to start making the necessary modifications and upgrade the database.

Firstly, just to clarify, the check is not
(ticketHash matches) AND (feeAddr matches) AND (feeAddrIdx matches)

it is actually
(ticketHash matches) OR (feeAddr matches) OR (feeAddrIdx matches)

So if the keys were changed, we would still have to iterate over every key to make the checks. It wouldn't be as simple as just checking one key. It is correct that this would remove the need to unmarshal every ticket though.
That said, I'm not fully convinced that this optimisation is worth the code complexity required for a database upgrade. InsertNewTicket is called infrequently, and json unmarshalling is cheap.
Let me think aloud about this...
If every single ticket is given to one VSP, InsertNewTicket will be called 5 times per block, so approx once per minute on average. In the real world, ~50% of tickets are solo, and there are >10 VSPs, so a more realistic estimate is more like once every 15-20 minutes.
I guess we have to consider that a bunch of tickets may be added in a burst, but that shouldn't be happening too often, and the bursts won't be massive.
It might be interesting to write up some code to benchmark how long it takes to unmarshal a huge number of tickets, and see if the result is actually a concern or not.

Firstly, just to clarify, the check is not
(ticketHash matches) AND (feeAddr matches) AND (feeAddrIdx matches)

it is actually
(ticketHash matches) OR (feeAddr matches) OR (feeAddrIdx matches)

So if the keys were changed, we would still have to iterate over every key to make the checks. It wouldn't be as simple as just checking one key. It is correct that this would remove the need to unmarshal every ticket though.
That said, I'm not fully convinced that this optimisation is worth the code complexity required for a database upgrade. InsertNewTicket is called infrequently, and json unmarshalling is cheap.
Let me think aloud about this...
If every single ticket is given to one VSP, InsertNewTicket will be called 5 times per block, so approx once per minute on average. In the real world, ~50% of tickets are solo, and there are >10 VSPs, so a more realistic estimate is more like once every 15-20 minutes.
I guess we have to consider that a bunch of tickets may be added in a burst, but that shouldn't be happening too often, and the bursts won't be massive.
It might be interesting to write up some code to benchmark how long it takes to unmarshal a huge number of tickets, and see if the result is actually a concern or not.

Thanks for the clarification on the check. Iterating over keys with boltdb is pretty fast and that will still be needed with the suggested change. The unmarshal calls through a ticket dataset that is growing over time is the issue I'm looking to eliminate. With the keys updated to house all the detail needed for the checks the unmarshal call would no longer be required. I agree the call by itself isn't costly, I think the growing dataset of tickets will over time make it so.  I'll get the suggested benchmark done.

Thanks for the clarification on the check. Iterating over keys with boltdb is pretty fast and that will still be needed with the suggested change. The unmarshal calls through a ticket dataset that is growing over time is the issue I'm looking to eliminate. With the keys updated to house all the detail needed for the checks the unmarshal call would no longer be required. I agree the call by itself isn't costly, I think the growing dataset of tickets will over time make it so.  I'll get the suggested benchmark done.

goos: linux
goarch: amd64
pkg: github.com/decred/vspd/database
Benchmark1KTicketUnmarshals-8     	     278	   3933861 ns/op	  376002 B/op	    4000 allocs/op
Benchmark5KTicketUnmarshals-8     	      64	  19761755 ns/op	 1880008 B/op	   20000 allocs/op
Benchmark10KTicketUnmarshals-8    	      32	  38075283 ns/op	 3760026 B/op	   40000 allocs/op
Benchmark100KTicketUnmarshals-8   	       3	 391093136 ns/op	37600010 B/op	  400000 allocs/op
PASS
ok  	github.com/decred/vspd/database	6.745s

These were generated from:
func Benchmark1KTicketUnmarshals(b *testing.B) {
	count := 1000 // update accordingly
	tickets := make([][]byte, 0, count)
	for idx := 0; idx < count; idx++ {
		tb, err := json.Marshal(Ticket{})
		if err != nil {
			panic(err)
		}
		tickets = append(tickets, tb)
	}

	b.ReportAllocs()
	b.ResetTimer()

	for i := 0; i < b.N; i++ {
		for idx := 0; idx < count; idx++ {
			var t Ticket
			err := json.Unmarshal(tickets[idx], &t)
			if err != nil {
				panic(err)
			}
		}
	}
}

goos: linux
goarch: amd64
pkg: github.com/decred/vspd/database
Benchmark1KTicketUnmarshals-8     	     278	   3933861 ns/op	  376002 B/op	    4000 allocs/op
Benchmark5KTicketUnmarshals-8     	      64	  19761755 ns/op	 1880008 B/op	   20000 allocs/op
Benchmark10KTicketUnmarshals-8    	      32	  38075283 ns/op	 3760026 B/op	   40000 allocs/op
Benchmark100KTicketUnmarshals-8   	       3	 391093136 ns/op	37600010 B/op	  400000 allocs/op
PASS
ok  	github.com/decred/vspd/database	6.745s

These were generated from:
func Benchmark1KTicketUnmarshals(b *testing.B) {
	count := 1000 // update accordingly
	tickets := make([][]byte, 0, count)
	for idx := 0; idx < count; idx++ {
		tb, err := json.Marshal(Ticket{})
		if err != nil {
			panic(err)
		}
		tickets = append(tickets, tb)
	}

	b.ReportAllocs()
	b.ResetTimer()

	for i := 0; i < b.N; i++ {
		for idx := 0; idx < count; idx++ {
			var t Ticket
			err := json.Unmarshal(tickets[idx], &t)
			if err != nil {
				panic(err)
			}
		}
	}
}

I've spent some time on this with dnldd and there definitely are some issues with database scaling. Will post some more info shortly.

#241 removes the fee address index from the uniqueness checks, so if we choose to extend the database keys they will only need to be Ticket Hash + Fee Address

Validated that key length makes no difference to database disk usage. Previously we used short keys because they were JSON encoded and contributed to increasing disk usage. Now we can use long, descriptive keys.
Running on https://testnet-vsp.jholdstock.uk (database contains ~15k tickets). Memory usage and upgrade duration negligible.
Used benchmark code from #223 to test a database containing ~200k tickets:

Old code

InsertNewTicket 2.39s
CountAllTickets 2.41s

New code

InsertNewTicket 0.30s
CountAllTickets 0.27s

Ready for review


[android/build] Build tensor_query with nnstreamer-edge sources @open sesame 10/25 14:02

Define source files to build tensor_query elements.
User should set envvar "NNSTREAMER_EDGE_ROOT" (path to nnstreamer-edge source dir) to build tensor_query.
Add a simple Pipeline API TC for tensor_query.

This PR requires https://github.com/nnstreamer/nnstreamer-edge/pull/113 and https://github.com/nnstreamer/nnstreamer-edge/pull/114 to be merged
Signed-off-by: Yongjoo Ahn<EMAIL_ADDRESS>Self evaluation:

Build test: [X]Passed [ ]Failed [ ]Skipped
Run test: [X]Passed [ ]Failed [ ]Skipped

:octocat: cibot: @anyj0527, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/222-202210171733490.42366409301758-f491b99d7dc02d25f972b2b1a25e520b3fef4f22/.

:octocat: cibot: @anyj0527, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/222-202210251402280.37206602096558-f491b99d7dc02d25f972b2b1a25e520b3fef4f22/.

:octocat: cibot: @anyj0527, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/222-202210271340430.87688207626343-a92374eb1b5f82a5e346de529c4229aa01cbd252/.

:octocat: cibot: @anyj0527, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/222-202210271409350.47266602516174-adc65f386409a13a8456f7e61c28e8f8012e0155/.

:octocat: cibot: @anyj0527, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/222-202210271729210.37721395492554-adc65f386409a13a8456f7e61c28e8f8012e0155/.

:octocat: cibot: @anyj0527, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/222-202211091818390.37012600898743-adc65f386409a13a8456f7e61c28e8f8012e0155/.

:octocat: cibot: @anyj0527, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/222-202211101427490.1429979801178-adc65f386409a13a8456f7e61c28e8f8012e0155/.

:octocat: cibot: @anyj0527, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/222-202211101804110.02999210357666-adc65f386409a13a8456f7e61c28e8f8012e0155/.

:octocat: cibot: @anyj0527, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/222-202211101827330.44324994087219-adc65f386409a13a8456f7e61c28e8f8012e0155/.


Robuster kitty font parsing

I've got a shortcut defined in kitty to change the font size. The relevant part of 'kitty --debug-config':
Changed shortcuts:
         shift+control+minus KeyAction(func='decrease_font_size', args=())

My neofetch output:
Terminal Font: Hack ', args=())

This commit changes the parsing to an awk pattern that only matches the start of lines in the debug output.
New output:
Terminal Font: Hack 8.9

Can you send me your kitty config? I don't think we require two awk calls.

If awk is really needed, what about this?
term_font="$(awk '/^font_family/ {f=$2} /^font_size/ {s=$2} END {print f,s}' <<< "$kitty_config")"

@arisinfenix Thanks, that works too. I've changed the PR.
@dylanaraps https://gist.github.com/SibrenVasse/79c1bfe01894da7c8f1f4ba7e7f9305f

LGTM :+1:
Only issue is that the line is too long. Shorten it and I can merge.

Updated.

Does this work?:
term_font="$(awk '/^font_family|^font_size/ {printf $2 " "}' <<< "$kitty_config")"

Yes it does.

LGTM :+1:

Suppose kitty is in the $PATH, this shall work.
kitty --debug-config | grep 'font_family' | awk '{$1="";print $0}' | sed -e 's/^[[:space:]]//'


add retries for datastore

These changes have been published! View these changes here.

Can you resolve the conflict?

@tmatsuo PTAL

NM, you LGTM'd the other one.

LGTM


Gap between Social media icons

There must be some gap between the Social media Icons, so that it will be more readable. I would like to resolve this.

Hi
I am interested in doing this issue
so kindly assign me this
I will do my best to reach your expectations
Thank You

can you assign me this issue?
i want to solve it

@sakshinikharge39 kindly feagure out website one time and afte that if you feel any issue then share the screen shot what  you want to fix

can you assign me this issue?
I want to solve it

@Kota-Karthik if @sakshinikharge39  do not reply then you can start woking on it or ou can find any other issue then contribute on there


No completions for variables annotated with typing.List, typing.Dict etc.

Environment data
VS Code version:  1.20.1
Python Extension version:  2018.1.0
Python Version:   3.6.1
OS and version:    Windows 10
Actual behavior
Using the following source code:
import typing

string_list: typing.List[str] = ['foo', 'bar']
string_dict: typing.Dict[int, str] = {
    0: 'foo',
    1: 'bar'
}

Then typing:
string_list[0].

or
string_dict[0].

will not trigger any completions.
(The annotations are redundant in this case, they are just there to demonstrate the issue.)
Expected  behavior
Completions for the str type are shown.
Steps to reproduce:

Paste the above Python code into a new file.
Attempt to trigger completions on string_list[0]. and string_dict[0].

I assume that this affects other type annotations as well, but those are the only ones I have tried. FWIW, this is not an issue with Jedi, as the following works just fine:
>>> jedi.api.Script(source + '\n' + 'string_list[0].').completions()
[<Completion: capitalize>, ...]

Appears to be working with recent jedi 0.11

Fixed by https://github.com/Microsoft/vscode-python/commit/5ccb9cdd62fba6619a6ac2d3bdfe45725238da9c
You can try insiders build if you want or wait for 2018.2
https://github.com/Microsoft/vscode-python/blob/master/CONTRIBUTING.md#insiders-build


do Auth in browser inside project?

When  I do Auth, a window in my default browser is opened and closed. Is it possible to do the Auth in a browser inside the project in order to hide this process to user?
Thanks in advance.

Hey Steplg,
I'm curious if you solved this problem?  I'm trying to get my app to not spit out that useless browser window, too.

Hmm, gotcha.
Do you know if we can perhaps cache the token given back to us and reuse?  I noticed it was the same on two separate runs for me.  Might be a way to cut down on the amount of browsers opened?
I can't imagine there's no way to get browser-less re-auth.  No production apps anywhere require browsers to be opened every time they start up

IMHO now the API is not so important than before.
Now you can do the job directly with HttpWebRequest. With few calls to endpoints...


How to use without requiring async/await for every render?

Hi,
I'd like to use toHaveNoViolations in a project to extend expect.
Is there a way to do this without requiring async/await for every render of my react components? I'd love for it to be transparent to the users of the extended expect.

Think you'll need to use async/await but if you can give an example that'd help, closing old issues but if this is still something you're interested feel free to re-open with your reply.


Use velad to install the kubevela development environment

@chivalryq @charlie0129 I set up the development environment of kubevela according to the tutorial document, after executing velad install
The result is as follows：
Ubuntu 18.04.6 (Linux 4.15.0-194-generic x86_64)

Win10 10.0.17763.4010
Use CMD or Powershell
This error msg will appear in the middle

done

what should I do？

In the first image, it shows the hooks fails. Can you run command below to check what's in the cluster? Maybe your cluster isn't setup successfully.
kubectl get pod -A

In Win10, there's some problems when loading image in your environment. What's your docker environment? Did you use a docker desktop or?

kubectl get pod -A

On win10, docker desktop is used

In Ubuntu, check journalctl -xe to check what happens to k3s.
In Windows, check the container logs please.

Too much content, I can't find the important content, here is the log file
In Ubuntu
https://docs.qq.com/document/DRmZmcHBkRVlXa0tI
In Windows
https://docs.qq.com/doc/DRm1xeGVKSUZTdVNM

Thanks, I'll try again next time.

@chivalryq In windows, I solved docker increase-rate-limit, and I found several err. But I don't know how to fix them.

then stuck here

log：
https://docs.qq.com/doc/DRnV3R2pDdmFBaU1I

Have you succeed in Ubuntu? @yikuaibro

No, I gave up installing it in Ubuntu because I can't upgrade the version of Ubuntu. So only tried in win.

But did apt install apparmor apparmor-utils work ?


[Workers] Adds New Rust Examples

This PR Adds new Rust implementation examples for:

/workers/examples/cors-header-proxy
/workers/examples/security-headers
/workers/examples/basic-auth
/workers/examples/logging-headers
/workers/examples/websockets

Hi @kflansburg, and @zebp, would love your feedback on these. Thank you!


[Feature Enhancement] : ✨Dark mode toggle✨

I can work on this feature and make a user interactive dark mode toggle , can you please assign me this task?
Thank you!

@BhuwanSKumar  can you please review this.


chore Fix linkage errors for the release build

Proposed changes
Issue Number: close #17003
Problem summary
The linker couldn't find some symbols because the implementation of a template member function doris::vectorized::Decoder::init_decimal_converter is missing in the header file in which the corresponding declaration is placed.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


docs(*): add link to the YT playlist

We publish recordings of the Kuma Community Calls, but we don't have a link publicly available. This PR adds the link to the playlist on website:

When you put an email and submit it's already displayed:

Can we just move the "Past recordings" info up a level rather than repeating it?

@lahabana I updated PR, so now agenda and recordings always available, but calendar is shown only after submitting an email:


Azure DBs should use Customer Managed Keys

Before we start loading real data into our databases, we should switch to using our own encryption keys, this should help avoid issues of having to re-encrypt further down the road.

This is blocked due to some apparent issues on the Microsoft side (which is most likely my ignorance). Working with Josh to get some consulting time to figure it out.

@nickrobison-usds does this need to be handed off before you leave?

@nickrobison-usds does this need to be handed off before you leave?

@aliciabeckett-gov I think I should be able to wrap it up, if not, we'll need to pass it off.

@aliciabeckett-gov I think I should be able to wrap it up, if not, we'll need to pass it off.

@aliciabeckett-gov @emmanuel-apau confirmed this ticket has been implemented already. So I'll close this out.

@aliciabeckett-gov @emmanuel-apau confirmed this ticket has been implemented already. So I'll close this out.


Add cmdline parameter to open PDF

Very nice Project! I think it is somewhat tedious to navigate through the folders inside the app, so I wonder how much effort it is to open a PDF directly when starting the program from shell?
Thanks and keep it up!

@shibmaster available in release https://github.com/oxplot/pdfrankenstein/releases/tag/v0.4


This AutoATR is so cool

I just wanted to thank you for sharing your code.  This indicator is simple but great addition, especially when the chart scales in and out.
One thing that I wish happen was for the indicator to stay fully visible via chart auto scaling.  For some reason Auto scale ON does not keep it on the screen.

Maybe there's a better way, for now I just added transparent draw objects:
        // Remove previous lines
        RemoveDrawObject(_highLineTag);
        RemoveDrawObject(_lowLineTag);

        // Add transparent drawing objects for auto-scaling
        Draw.HorizontalLine(this, _highLineTag, true, _autoATR.HighPlusMedianAtr, Brushes.Transparent, DashStyleHelper.Solid, 1);
        Draw.HorizontalLine(this, _lowLineTag, true, _autoATR.LowMinusMedianAtr, Brushes.Transparent, DashStyleHelper.Solid, 1);

With the way this indicator works, it can be a good place to ensure that you always see x amount of points above and below median, like so (x is 20 in this example):
        Draw.Dot(this, _highDotTag, true, 0, _autoATR.HighLowMedianAtr+20, Brushes.Transparent, true);
        Draw.Dot(this, _lowDotTag, true, 0, _autoATR.HighLowMedianAtr-20, Brushes.Transparent, true


Unified use of matrix! macro ([…] vs. (…)).

While most invocations of the matrix! macro in rulinalg currently provide parameters in brackets ([…]), quite a few of them use parentheses ((…)) instead.
I took the liberty to unify them, opting for the more common pattern (also the one matching the common use of vec![…]).

I haven't checked, but I feel as if there should be a lot more examples of (? I remember when I first wrote the matrix macro I used ( everywhere, but perhaps the other pieces have changed over time.

I just checked, and you were right of course. 😇  Quite sure I got them all now though.

I agree with the above comments. I also prefer matrix![*] so thank you for making the change!
Also note that there are some merge conflicts here.

I just had a check and I think a few are still missing - I see some in:

matrix/impl_mat
matrix/base/impl_base
matrix/decomposition/eigen
matrix/decomposition/svd

Am happy to update these myself if you don't have time.

I just had a check and I think a few are still missing.

Hm… had to do major conflict resolving against 7d6b58bc729e086f5fd28b5636dd093429977768. Must have missed them. Fixed now.

Fixed the merge conflict. Will merge this in once CI approves. Thank you!


Add optional eclipselink dependency to build and include as build arg in Dockerfile

Description
https://github.com/polaris-catalog/polaris/pull/53 removed the eclipselink subproject as a dependency of the polaris-service build. As an optional dependency, it makes sense to not include it automatically. However, users will need a way to include the subproject in the service jar and in the output Dockerfile.
This updates the gradle build to accept an optional eclipseLink property that includes the subproject in the shadow jar. Additionally, there's a corresponding ECLIPSELINK arg in the docker build.
While testing this, I also updated the Dockerfile to specify an ENTRYPOINT and a CMD so that it's easy to point to a different polaris-server.yml file and/or execute a different command (such as the bootstrap or upcoming purge command) from the same docker image.
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Ran
docker build . --build-arg ECLIPSELINK=true -t polaris:latest

then I updated my local polaris-server.yml file to specify eclipse-link as the metaStoreManager and ran with
docker run -p 8181:8181 -v ${PWD}:/conf polaris:latest server /conf/polaris-server.yml

Confirmed the following was in the server output at startup:
INFO  [2024-08-07 22:45:32,934 - 640   ] [main] [] i.p.service.PolarisApplication: Initializing PolarisCallContextCatalogFactory for baseCatalogType polaris, metaStoreManagerType io.polaris.extension.persistence.impl.eclipselink.EclipseLinkPolarisMetaStoreManagerFactory@22590e3e

[ ] Test A
[ ] Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:
Please delete options that are not relevant.

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] If adding new functionality, I have discussed my implementation with the community using the linked GitHub issue
[ ] I have signed and submitted the ICLA and if needed, the CCLA. See Contributing for details.

Raised similar PR for this: https://github.com/polaris-catalog/polaris/pull/118
I think we still needed to add h2 lib for default persistent backend for extension/persistence/eclipselink/build.gradle.kts.

Merging this after discussion in https://github.com/polaris-catalog/polaris/discussions/125


[BLM] single target combo gets stuck in opener

right around the time iin the opener where it should use manafont it freezes. cant press anything

@Taurenkey am I correct in assuming that the opener and caster-specific opener changes coming in <IP_ADDRESS> would address this issue?

can u also post the file from /Wrath debug BLM?

I believe this will be fixed by 5f66460 and ce73955, which will come in <IP_ADDRESS>.
Please comment/reopen if not.


Shell autocompletion

What
Autocompletion for ZSH and Bash
How to test
Follow the README.md and see if it works.
Why
Because we can always be a little more lazy!

This is awesome man!
@renatomefi you made a similar script for Pla, right? Do you have any thoughts on this one?

Oh that's cool! The difference in here is Stefan is reading directly from the pla file, and only in the current directory which is different from the pla behavior.
I like to make autocompletes by executing the command, because any logic like default options, parent configuration files or anything in the future would still be compatible!
But that's just a matter of taste! hehe
That's the one I've done: https://github.com/renatomefi/pla-zsh-plugin/blob/master/pla.plugin.zsh

@renatomefi has a point, Pla supports sub-directories as well which is not covered by my solution. I will simply steal Renato's solution to getting the commands, mention him as an author, update both the ZSH and Bash scripts, and update the PR. that way it is shipped with Pla itself instead of a separate project =)

Despite my best efforts I never got around to do it, and since then pla has been replaced by make at the company I work for. I do not intend to fix this anymore, so closing this PR.


DPM-82 Cars service example update

Changes

update to node 16
switch "db" from custom session solution to sqlite3 (memory)
update layout and copy

Testing
Run stackblitz or vercel staging (list, details, settings)

Main branch dependencies


The documentation for Azure functions Isolated is incorrect. As far as I know, the package Microsoft.Azure.Functions.Extensions works for In-Process mode

The documentation for Azure functions Isolated is incorrect.
https://docs.microsoft.com/en-us/azure/azure-app-configuration/quickstart-azure-functions-csharp?tabs=in-process
[assembly: FunctionsStartup(typeof(FunctionApp.Startup))]
never fires
As far as I know, the package Microsoft.Azure.Functions.Extensions https://www.nuget.org/packages/Microsoft.Azure.Functions.Extensions/ works for In-Process mode.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec838379-f1fa-0cab-ff31-3bb1b30a7ccc
Version Independent ID: e2571455-af0a-19f6-799c-ea09ae602680
Content: Quickstart for Azure App Configuration with Azure Functions
Content Source: articles/azure-app-configuration/quickstart-azure-functions-csharp.md
Service: azure-app-configuration
GitHub Login: @AlexandraKemperMS
Microsoft Alias: alkemper

@christianarg Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Hello christianarg, thank you for the feedback. As far as I can see, updates to this doc have fixed this issue. I will now close it. If you feel that this needs to be reviewed again, please do send feedback using the "Feedback" option on the Microsoft Learn doc.

#please-close


ARIA-118 plugin.yaml importing

Support for importing plugin.yaml files of loaded plugins.

Can one of the admins verify this patch?


Clarify whether/how it is possible to define collections at runtime.

The only discussion of how to create a collection is by annotating a class.
But what if I want to let my users define a collection at runtime? Say, I want to make my own version of FileMaker. Is this possible?
If it is, please clarify how.
If it is not, please consider adding this feature.
Great project, thanks!

Hi, creating a collection at runtime is not possible.
One way to circumvent that would be to have a collection with a collection type and a field for the custom collection object data:
@collection
class CustomCollection {
  Id id;

  @Index()
  String collectionType;

  // This field could be the JSON encoded data from a custom collection type
  String customCollectionData;
}

Otherwise, you could use Hive, which might be more adequate for this use case.


If the image with :latest tag specified in spec, pull even PullIfNotPresent is set.

As a note, this change really burns us when trying to test in local environments.  I'm really in favor of yanking this - I don't think latest should override pullIfNotPresent

It should only have overridden the default if no explicit value was
present.  If there is an explicit value present, we shouldn't overwrite,
regardless of the image spec.
--brendan
On Mon, Jan 12, 2015 at 1:40 PM, Clayton Coleman<EMAIL_ADDRESS>wrote:

As a note, this change really burns us when trying to test in local
environments. I'm really in favor of yanking this - I don't think latest
should override pullIfNotPresent
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/2388#issuecomment-69651259
.

to be clear: this is a bug if it's not the case.
On Mon, Jan 12, 2015 at 1:50 PM, Brendan Burns<EMAIL_ADDRESS>wrote:

It should only have overridden the default if no explicit value was
present.  If there is an explicit value present, we shouldn't overwrite,
regardless of the image spec.
--brendan
On Mon, Jan 12, 2015 at 1:40 PM, Clayton Coleman<EMAIL_ADDRESS>
wrote:

As a note, this change really burns us when trying to test in local
environments. I'm really in favor of yanking this - I don't think latest
should override pullIfNotPresent
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/2388#issuecomment-69651259
.

@brendanburns What you described here is exact opposite of what we implemented here. When the user asks for latest of image with PullIfNotPresent (which is default policy), we treat it as Always. It is our policy choice, not a bug. But it is arguable if it is a good policy or not.
@smarterclayton I am ok to remove this, but before we do it, can I understand your use case more?

Our use case is doing test and development on Kubernetes (and things that run on Kubernetes that run in containers) is that we simultaneously want to expose our images as Docker Hub images ("openshift/docker-registry") but test them locally against non-master.  We can mutate our references to not be latest, but latest isn't any more special than any other tag.
If the user says "pullIfNotPresent" and we "pullAlways", that sounds like a bug (a user certainly wouldn't expect it).  Otherwise, we shouldn't allow someone to specify pullIfNotPresent.  And forcing users who want that behavior to use different tag names is a bad idea, because now we're enforcing a certain pattern on how users use tags in repositories they don't control.
----- Original Message -----

@brendanburns What you described here is exact opposite of what we
implemented here. When the user asks for latest of image with
PullIfNotPresent (which is default policy), we treat it as Always. It is our
policy choice, not a bug. But it is arguable if it is a good policy or not.
@smarterclayton I am ok to remove this, but before we do it, can I understand
your use case more?

Reply to this email directly or view it on GitHub:
https://github.com/GoogleCloudPlatform/kubernetes/pull/2388#issuecomment-69654805

To be clear, I wanted to identify the cases:
In this container, Pull Policy is set to "PullAlways"
{
...
"image": "foo:latest"
// No image pull policy specified
...
}
In these containers, Pull Policy is unchanged
{
...
"image": "foo"
// No Image pull policy specified
...
}
{
...
"image": "foo:some-other-version"
// No Image pull policy specified
...
}
{
...
"imagePullPolicy": ""
...
}
Hope that helps.
--brendan
On Mon, Jan 12, 2015 at 2:06 PM, Clayton Coleman<EMAIL_ADDRESS>wrote:

Our use case is doing test and development on Kubernetes (and things that
run on Kubernetes that run in containers) is that we simultaneously want to
expose our images as Docker Hub images ("openshift/docker-registry") but
test them locally against non-master. We can mutate our references to not
be latest, but latest isn't any more special than any other tag.
If the user says "pullIfNotPresent" and we "pullAlways", that sounds like
a bug (a user certainly wouldn't expect it). Otherwise, we shouldn't allow
someone to specify pullIfNotPresent. And forcing users who want that
behavior to use different tag names is a bad idea, because now we're
enforcing a certain pattern on how users use tags in repositories they
don't control.
----- Original Message -----

@brendanburns What you described here is exact opposite of what we
implemented here. When the user asks for latest of image with
PullIfNotPresent (which is default policy), we treat it as Always. It is
our
policy choice, not a bug. But it is arguable if it is a good policy or
not.
@smarterclayton I am ok to remove this, but before we do it, can I
understand
your use case more?

Reply to this email directly or view it on GitHub:

https://github.com/GoogleCloudPlatform/kubernetes/pull/2388#issuecomment-69654805
—
Reply to this email directly or view it on GitHub
https://github.com/GoogleCloudPlatform/kubernetes/pull/2388#issuecomment-69655713
.

----- Original Message -----

To be clear, I wanted to identify the cases:
In this container, Pull Policy is set to "PullAlways"
{
...
"image": "foo:latest"
// No image pull policy specified
...
}
In these containers, Pull Policy is unchanged
{
...
"image": "foo"
// No Image pull policy specified
...
}
{
...
"image": "foo:some-other-version"
// No Image pull policy specified
...
}
{
...
"imagePullPolicy": ""
...
}

Right - this is the case which today is "broken" - in that the value the REST object contains (pullIfPresent) is ignored and the pull policy is converted to pull always when doesn't contain a tag.

Yes, the latest use case is broken on purpose to mitigate #2360 and continue supporting ContainerVM users. If I remembered correctly, PullPolicy's default setting implementation is different from other default setting, and we were not convergent on which way is the right way. Meanwhile, the current approach of PullPolicy cannot have image_name:tag easily. I think now we are convergent on how to setting defaults, and kubelet start to have validation too. Will send PR to fix the issue.

@brendandburns @smarterclayton @thockin
I were wrong. #2587 is not merged yet and we are not convergent on how to set defaults here.

#2587 hasn't been merged yet, but I think we have converged on the approach we want to take. We just need something to push it to completion.


More HDFS Manage Access dialog updates

Final set of changes for initial set of features. (apologies for the longish PR, there were a lot of changes that came in at the same time and splitting them up was going to be a pretty annoying task)
This PR includes the following changes :

Add context menu command for opening the dialog
Refactored model such that we have a single AclEntry for each name/type pair that then contains a separate permission entry for each scoped permission
Support for setting default ACLs
Change in design for default ACLs based on how those are handled by HDFS
Add support for apply recursive. Note that this is done as a background operation (unlike normal apply which is done before the dialog closes). This was because it could potentially take a long time if there's many paths to set the ACLs on so keeping the dialog open that entire time wasn't desirable.
Change webhdfs readdir to match the actual API operation being taken (liststatus)
Remove duplicated getfilestatus endpoint (stat was doing the same as the existing getFileStatus)
Add removeDefaultAcl to web API

View for directories (defaults applicable)

View for files (no default  ACLs)

Can we have the disabled button follow the other dark theme styling? That way we can have adequate contrast. Here is the disabled button in the connection dialog for reference:

Yeah I don't know why it's different here, I'll investigate and do that in a follow-up PR

Synced offline, happy with changes.


TODO: custom home-manager module

We should provide a home-manager module to configure the installation.
Some values configurable through the home-manager installation could be user or group name. Furthermore we could write the files in /bin, /etc and /usr via home-manager and uninstall the basic-environment. That way we would not need to rely on the fragile nix-on-droid-linker thing.

This should be closed by now because we don't rely on home-manager anymore.


istio hook failed: "install"

Bug Description
I'm deploying charmed k8s in wich i've wanted to deploy the istio charmed but unfortunally i'm getting the hook failed install
Unit                              Workload  Agent  Address          Ports  Message
istio-ingressgateway-operator/0*  waiting   idle   <IP_ADDRESS>         List of istio-pilot versions not found for apps: istio-pilot
istio-pilot/0*                    error     idle   <IP_ADDRESS>         hook failed: "install"
metallb/0*                        active    idle   <IP_ADDRESS>         Ready
To Reproduce
Unit                              Workload  Agent  Address          Ports  Message
istio-ingressgateway-operator/0*  waiting   idle   <IP_ADDRESS>         List of istio-pilot versions not found for apps: istio-pilot
istio-pilot/0*                    error     idle   <IP_ADDRESS>         hook failed: "install"
metallb/0*                        active    idle   <IP_ADDRESS>         Ready
Environment
On lxd
and i'm using charmed k8s latest version
Relevant Log Output
unit-istio-pilot-0: 22:27:12 WARNING unit.istio-pilot/0.install - Pruning removed resources2023-11-29T21:27:12.089025Z       warn    installer       retrieving resources to prune type autoscaling/v2beta1, Kind=HorizontalPodAutoscaler: no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta1" not found
unit-istio-pilot-0: 22:27:12 WARNING unit.istio-pilot/0.install 2023-11-29T21:27:12.540978Z     warn    installer   retrieving resources to prune type policy/v1beta1, Kind=PodDisruptionBudget: no matches for kind "PodDisruptionBudget" in version "policy/v1beta1" not found
unit-istio-pilot-0: 22:27:14 WARNING unit.istio-pilot/0.install Error: failed to install manifests: errors occurred during operation
unit-istio-pilot-0: 22:27:14 ERROR unit.istio-pilot/0.juju-log Uncaught exception while in charm code:
Traceback (most recent call last):
  File "./src/charm.py", line 204, in <module>
    main(Operator)
  File "/var/lib/juju/agents/unit-istio-pilot-0/charm/venv/ops/main.py", line 404, in main
    framework.reemit()
  File "/var/lib/juju/agents/unit-istio-pilot-0/charm/venv/ops/framework.py", line 732, in reemit
    self._reemit()
  File "/var/lib/juju/agents/unit-istio-pilot-0/charm/venv/ops/framework.py", line 767, in _reemit
    custom_handler(event)
  File "./src/charm.py", line 52, in install
    subprocess.check_call(
  File "/usr/lib/python3.8/subprocess.py", line 364, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['./istioctl', 'install', '-y', '-s', 'profile=minimal', '-s', 'values.global.istioNamespace=metallb-system']' returned non-zero exit status 1.
unit-istio-pilot-0: 22:27:14 ERROR juju.worker.uniter.operation hook "install" (via hook dispatching script: dispatch) failed: exit status 1
unit-istio-pilot-0: 22:27:14 INFO juju.worker.uniter awaiting error resolution for "install" hook
model-6bf704fb-be57-4667-83c3-b92938b9a868: 22:27:38 INFO juju.kubernetes.klog Use tokens from the TokenRequest API or manually created secret-based tokens instead of auto-generated secret-based tokens.
unit-istio-pilot-0: 22:27:08 INFO juju.worker.uniter awaiting error resolution for "install" hook
unit-istio-pilot-0: 22:27:08 INFO unit.istio-pilot/0.juju-log Running legacy hooks/install.
unit-istio-pilot-0: 22:27:10 WARNING unit.istio-pilot/0.install
unit-istio-pilot-0: 22:27:11 WARNING unit.istio-pilot/0.install - Processing resources for Istio core.
unit-istio-pilot-0: 22:27:11 WARNING unit.istio-pilot/0.install ✔ Istio core installed
unit-istio-pilot-0: 22:27:11 WARNING unit.istio-pilot/0.install - Processing resources for Istiod.2023-11-29T21:27:11.932949Z        error   installer       failed to update resource with server-side apply for obj PodDisruptionBudget/metallb-system/istiod: no matches for kind "PodDisruptionBudget" in version "policy/v1beta1"
unit-istio-pilot-0: 22:27:12 WARNING unit.istio-pilot/0.install 2023-11-29T21:27:12.023277Z     error   installer   failed to update resource with server-side apply for obj HorizontalPodAutoscaler/metallb-system/istiod: no matches for kind "HorizontalPodAutoscaler" in version "autoscaling/v2beta1"

Additional Context
No response

@NohaIhab  i really appreciate your interaction and cotnributing
Attached you'll find all the deployment description
Concerning ISTIO i've used the latest version available on the charmhub ( juju deploy istio )
root@hazem-pfe:~# juju status
Model  Controller           Cloud/Region         Version  SLA          Timestamp
k8s    localhost-localhost  localhost/localhost  3.1.6    unsupported  15:10:51+01:00

App                       Version  Status       Scale  Charm                     Channel  Rev  Exposed  Message
calico                    3.25.1   active           6  calico                    stable   101  yes      Ready
containerd                1.6.8    active           6  containerd                stable    73  no       Container runtime available
easyrsa                   3.0.1    active           1  easyrsa                   stable    48  no       Certificate Authority connected.
etcd                      3.4.22   active           3  etcd                      stable   748  no       Healthy with 3 known peers
istio-pilot                        error            1  istio-pilot               stable    34  no       hook failed: "install"
kubeapi-load-balancer     1.18.0   active           3  kubeapi-load-balancer     stable    84  yes      Loadbalancer ready.
kubernetes-control-plane  1.28.4   maintenance      3  kubernetes-control-plane  stable   321  yes      Restarting snap.kube-controller-manager.daemon service
kubernetes-worker         1.28.4   active           3  kubernetes-worker         stable   134  yes      Kubernetes worker running.

Unit                         Workload     Agent  Machine  Public address  Ports         Message
easyrsa/0*                   active       idle   0        <IP_ADDRESS>                 Certificate Authority connected.
etcd/0*                      active       idle   1        <IP_ADDRESS>   2379/tcp      Healthy with 3 known peers
etcd/1                       active       idle   2        <IP_ADDRESS>   2379/tcp      Healthy with 3 known peers
etcd/2                       active       idle   3        <IP_ADDRESS>   2379/tcp      Healthy with 3 known peers
istio-pilot/1*               error        idle   15       <IP_ADDRESS>                 hook failed: "install"
kubeapi-load-balancer/0*     active       idle   4        <IP_ADDRESS>    443,6443/tcp  Loadbalancer ready.
kubeapi-load-balancer/1      active       idle   11       <IP_ADDRESS>    443,6443/tcp  Loadbalancer ready.
kubeapi-load-balancer/2      active       idle   12       <IP_ADDRESS>    443,6443/tcp  Loadbalancer ready.
kubernetes-control-plane/0   maintenance  idle   5        <IP_ADDRESS>   6443/tcp      Restarting snap.kube-controller-manager.daemon service
  calico/3                   active       idle            <IP_ADDRESS>                 Ready
  containerd/3               active       idle            <IP_ADDRESS>                 Container runtime available
kubernetes-control-plane/1*  active       idle   6        <IP_ADDRESS>     6443/tcp      Kubernetes control-plane running.
  calico/4                   active       idle            <IP_ADDRESS>                   Ready
  containerd/4               active       idle            <IP_ADDRESS>                   Container runtime available
kubernetes-control-plane/2   active       idle   10       <IP_ADDRESS>   6443/tcp      Kubernetes control-plane running.
  calico/5                   active       idle            <IP_ADDRESS>                 Ready
  containerd/5               active       idle            <IP_ADDRESS>                 Container runtime available
kubernetes-worker/0          active       idle   7        <IP_ADDRESS>   80,443/tcp    Kubernetes worker running.
  calico/2                   active       idle            <IP_ADDRESS>                 Ready
  containerd/2               active       idle            <IP_ADDRESS>                 Container runtime available
kubernetes-worker/1          active       idle   8        <IP_ADDRESS>   80,443/tcp    Kubernetes worker running.
  calico/1                   active       idle            <IP_ADDRESS>                 Ready
  containerd/1               active       idle            <IP_ADDRESS>                 Container runtime available
kubernetes-worker/2*         active       idle   9        <IP_ADDRESS>   80,443/tcp    Kubernetes worker running.
  calico/0*                  active       idle            <IP_ADDRESS>                 Ready
  containerd/0*              active       idle            <IP_ADDRESS>                 Container runtime available

Machine  State    Address        Inst id         Base          AZ  Message
0        started  <IP_ADDRESS>  juju-5ce5c0-0<EMAIL_ADDRESS>    Running
1        started  <IP_ADDRESS>  juju-5ce5c0-1<EMAIL_ADDRESS>    Running
2        started  <IP_ADDRESS>  juju-5ce5c0-2<EMAIL_ADDRESS>    Running
3        started  <IP_ADDRESS>  juju-5ce5c0-3<EMAIL_ADDRESS>    Running
4        started  <IP_ADDRESS>   juju-5ce5c0-4<EMAIL_ADDRESS>    Running
5        started  <IP_ADDRESS>  juju-5ce5c0-5<EMAIL_ADDRESS>    Running
6        started  <IP_ADDRESS>    juju-5ce5c0-6<EMAIL_ADDRESS>    Running
7        started  <IP_ADDRESS>  juju-5ce5c0-7<EMAIL_ADDRESS>    Running
8        started  <IP_ADDRESS>  juju-5ce5c0-8<EMAIL_ADDRESS>    Running
9        started  <IP_ADDRESS>  juju-5ce5c0-9<EMAIL_ADDRESS>    Running
10       started  <IP_ADDRESS>  juju-5ce5c0-10<EMAIL_ADDRESS>    Running
11       started  <IP_ADDRESS>   juju-5ce5c0-11<EMAIL_ADDRESS>    Running
12       started  <IP_ADDRESS>   juju-5ce5c0-12<EMAIL_ADDRESS>    Running
15       started  <IP_ADDRESS>  juju-5ce5c0-15<EMAIL_ADDRESS>    Running

Hi @hazem-soussi, the error message you are getting (subprocess.CalledProcessError: Command '['./istioctl', 'install', '-y', '-s', 'profile=minimal', '-s', 'values.global.istioNamespace=metallb-system']' returned non-zero exit status 1.) is usually caused by the istio-pilot charm not being able to install the Istio control plane properly, one of the most common causes is if your k8s cluster already had an Istio control plane installed previously and it was not properly removed. Could you please confirm if that's your case?
A way to resolve this would be to use the istioctl tool, which can help you diagnose the cause of the issue. Another solution would be to cleanup your environment making sure no trace of istio is left behind (services, pods, deployments, etc.) and re-deploy again the istio-pilot charm.

@DnPlas thanks a lot issue was resolved

Thanks @hazem-soussi for confirming. Closing this as the issue was resolved, but feel free to re-open or report other issues.


Check for if / switch / for / while spacing

There are (at least) two different styles you might want to enforce here:
if ( / switch ( / for ( and while (
or
if( / switch( / for( and while(
I don't think there currently is a check that handles this.

I guess the Spacing check handles this already, but only for the if case.


Use of ~/Library/Application Support on Mac is user-unfriendly

Describe the bug

To Reproduce
With the changes in #1471, platformdirs is used to identify platform specific folders to use. On Mac this results in putting files in ~/Library/Application Support/instructlab. This includes the models folder, the datasets (formerly generated) folder, and the taxonomy folder.
On Mac, the ~/Library folder is hidden in Finder by default. (See https://www.macworld.com/article/671158/how-to-show-hidden-files-on-a-mac.html). Which means users won't be able to easily navigate to the ~/Library/Application Support/instructlab folder in finder to see the files in the their taxonomy or the generated training data.
It is also an awkward file path to type in terminal given the space in the folder name. One must escape or quote.
The support for Mac also does not respect the XDG_ env vars if set. More sophisticated developers will use XDG_ and would expect it to be honored.
~/Library/Application Support is for files the user will generally never have to directly touch or see. But there are many files in InstructLan (e.g. taxonomy repo) which we do expect to user to see and touch.
Expected behavior

I would expect that the folders are in a place the user can easily access from both Finder and terminal.
Respect XDG_ env vars if set.
Screenshots

Device Info (please complete the following information):

Hardware Specs: M3 Max, 64GB

$ ilab system info
sys.version: 3.11.9 | packaged by conda-forge | (main, Apr 19 2024, 18:34:54) [Clang 16.0.6 ]
sys.platform: darwin
os.name: posix
platform.release: 23.5.0
platform.machine: arm64
instructlab.version: 0.17.1.dev494
instructlab-dolomite.version: 0.0.1
instructlab-eval.version: 0.0.9
instructlab-quantize.version: 0.1.0
instructlab-schema.version: 0.2.0
instructlab-sdg.version: 0.1.2
instructlab-training.version: <IP_ADDRESS>
torch.version: 2.3.1
torch.backends.cpu.capability: NO AVX
torch.version.cuda: None
torch.version.hip: None
torch.cuda.available: False
torch.backends.cuda.is_built: False
torch.backends.mps.is_built: True
torch.backends.mps.is_available: True
llama_cpp_python.version: 0.2.79
llama_cpp_python.supports_gpu_offload: True

Additional context

cc: @jjasghar

To serve granite-7b, I know have this awkward command to enter.
ilab model serve --model-path "/Users/hargrave/Library/Application Support/instructlab/models/granite-7b-lab-Q4_K_M.gguf"

Oh, that's going to impact Linux, too. cc: @gshipley
Related tickets:

#1705
#1309
#1338

@RobotSail PTAL, this should be a pretty quick fix with the current impl, right?

I had a problem in a taxonomy qna.yaml and this is what it told me.
(venv-instructlab-3.11) ➜  instructlab ilab taxonomy diff
knowledge/astronomy/constellations/Phoenix/qna.yaml
ERROR 2024-08-08 14:44:17,980 instructlab.utils:516: Problems found in file /Users/jjasghar/Library/Application Support/instructlab/taxonomy/knowledge/astronomy/constellations/Phoenix/qna.yaml
191:5: [warning] wrong indentation: expected 2 but found 4 (indentation)
Reading taxonomy failed with the following error: 1 total errors found across 1 updated taxonomy files!
(venv-instructlab-3.11) ➜  instructlab

Are we expecting someone to copy paste /Users/jjasghar/Library/Application Support/instructlab/taxonomy/knowledge/astronomy/constellations/Phoenix/qna.yaml to edit a file? this is not delightful.

@jjasghar No, we aren't expecting this to be the final experience. We need a clean story around managing and interacting with ilab data such as datasets, models, taxonomy, etc.
We just need everything stored in one place so that it doesn't matter to the user where they are on the system.
If you would like to try tackling this for the taxonomy, it would be very helpful.

in the community call it was suggested that we should try and make sure the default dirs are as consistent with the linux versions as possible, so there is a single set of default directories across both operating systems and people can copy paste paths easily if needed
so the fix for this issue should try and realign macOS directories to look like the ones used in linux

so the fix for this issue should try and realign macOS directories to look like the ones used in linux

And support XDG_ env vars when set.

I've re-opened this issue as I don't believe this has been adequately addressed. This is part of a broader issue which I've originally outlined in the local storage dev-doc - which is that we need an easy way to reference local files that are picked up by commands such as ilab model list, ilab data list, and ilab eval list (though this one doesn't exist yet).
Specifically on the topic of using ~/Library/Application Support when it comes to manually entering the filepath is certainly user-unfriendly, but this is also the guideline for storing application data on MacOS. However; switching to XDG_ dirs will not fix the problem either, since users are still required to enter the full path when they want to serve a specific model ilab model serve ~/.local/share/instructlab/models/yada-yada-yada/my-model.
If there is interest in MacOS respecting XDG directories then that is a separate issue. I've created an issue which would track that implementation in light of  https://github.com/instructlab/instructlab/pull/2202

Closing this issue as it was resolved in #2202 and we have all agreed to use XDG directories on MacOS as opposed to the standard ~/Library/Application Support that the guidelines suggest.
Regarding usability, we have the following issues to track components that need to be revamped:

ilab model list: #2200
ilab data list: #2246
ilab eval: We aren't storing any eval results yet, so this is TBD
ilab taxonomy: TBD - needs an issue created