Use bors for merging pull requests

Bors is meant to avoid this problem: https://bors.tech/essay/2017/02/02/pitch/, which happened (again) yesterday.
This will not be very useful until CI actually passes reliably, but I'm starting by setting it up for a subset, i.e. one single GitHub action on Linux that builds and runs the examples (i.e. the current "Linux CI (Debug)" configuration). Eventually all CI should just report to bors, but I'm keeping it separate for now until we get some experience with how well this works.
[skip ci]

bors ping

bors priority=3

bors ping

bors try

bors r+

bors r+

bors r+

bors r+

bors r+

bors r-

bors r+

bors try

bors r-

bors try-

bors r+

bors r-

bors r+

bors r-

bors r+

Performance test reportHPX PerformanceComparisonBENCHMARKNO-EXECUTORFuture Overhead - Create Thread Hierarchical - Latch++InfoPropertyBeforeAfterHPX Commit254db57ab5e998619e49744062d14609f1b466dacb258a0d5a99951fa4a808e41047d65a7679131bHPX Datetime2021-08-21T11:38:52+00:002021-11-09T12:20:29+00:00Hostnamenid00446nid00005ClusternamedaintdaintEnvfileCompiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0Datetime2021-08-23T15:21:22.855927+02:002021-11-09T13:38:11.399265+01:00ComparisonBENCHMARKFORK_JOIN_EXECUTOR_DEFAULT_FORK_JOIN_POLICY_ALLOCATORPARALLEL_EXECUTOR_DEFAULT_PARALLEL_POLICY_ALLOCATORSCHEDULER_EXECUTOR_DEFAULT_SCHEDULER_EXECUTOR_ALLOCATORStream Benchmark - Add-(=)(=)Stream Benchmark - Scale(=)(=)(=)Stream Benchmark - Triad-(=)(=)Stream Benchmark - Copy(=)(=)(=)InfoPropertyBeforeAfterHPX Commit916f4d8a700533b3273012ecf811d63617592bb2cb258a0d5a99951fa4a808e41047d65a7679131bHPX Datetime2021-10-22T15:54:13+00:002021-11-09T12:20:29+00:00Hostnamenid01196nid00005ClusternamedaintdaintEnvfileCompiler/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0/apps/daint/SSL/HPX/packages/llvm-11.0.0/bin/clang++ 11.0.0Datetime2021-10-25T11:52:24.316784+02:002021-11-09T13:38:26.724149+01:00Explanation of SymbolsSymbolMEANING=No performance change (confidence interval within ±1%)(=)Probably no performance change (confidence interval within ±2%)(+)/(-)Very small performance improvement/degradation (≤1%)+/-Small performance improvement/degradation (≤5%)++/--Large performance improvement/degradation (≤10%)+++/---Very large performance improvement/degradation (>10%)?Probably no change, but quite large uncertainty (confidence interval with ±5%)??Unclear result, very large uncertainty (±10%)???Something unexpected…

I think this first minimal setup is ready now. @hkaiser if you're happy, you can go ahead and approve it, and then comment with bors r+ or bors merge (same thing).
Here's a list of commands: https://bors.tech/documentation/. Note that we can always still "manually" merge PRs even with this in place.
PRs merged by bors will have bors as the co-author of the commit. We could set this to StellarBot instead? Not a big deal to me. Additionally, there's an option delete_merged_branches which we can turn on to automatically delete a branch after it's merged. Any reason not to?

We could set this to StellarBot instead

That would be appropriate, I think. Thanks for looking into this!

I also added delete_merged_branches = true to the config now.
One very important note: As long as we don't have all the CI working for bors, do not do bors merge or bors r+ without checking that all the CI actually is green (or as green as can be expected).

bors merge

bors merge

bors merge

bors merge

bors merge

bors merge

bors merge


option to generate schemas using 'allOf' to override default/etc rather than 'oneOf'

Due to not-great ecosystem support of allOf/anyOf/oneOf, it would be helpful to be able to configure which to use when generating a construct like
schema:
  default: ascending
  oneOf:
    - $ref: #/components/schemas/SortOrder

In particular, Swagger-UI only handles enums correctly if allOf is used, but currently oneOf is generated.  The documentation for "AllowReferencesWithProperties" already mentions that "allOf/oneOf with $ref" may be used
This would resolve the NSwag issue: https://github.com/RicoSuter/NSwag/issues/3645

It looks like the relevant code is here; https://github.com/RicoSuter/NJsonSchema/blob/master/src/NJsonSchema/Generation/JsonSchemaGenerator.cs#L298

the piece of code you reference doesn't seems to fix the issue of the missing dropbox for the enum parameters (you linked this issue in there), it only applies to the models and not to the api parameters


Added BB Diamond Hands and Staked BBDH [BounceBit]

Description:
BBDH is a community-driven meme staking coin within the BounceBit ecosystem. Primary focus is to utilize the capabilities of the BounceClub apps and features.
Official website: https://app.bouncebit.io/club/5918
BBscan: https://bbscan.io/token/0xE93C94F695F8E0cddBC3e01444a09a8F2003627e
GeckoTerminal: https://www.geckoterminal.com/bouncebit/pools/0x7d0049263b523530b662117ac64d0d2a4723c10d
Twitter/X: BBDiamondHands

@jansoren on which chain these tokens are deployed?

Bounce Bit @ bbchain.io

Is there anything more I should consider before PR approval?

@MRabenda Resolved conflict and ready for code review

@MRabenda I have added proper description now.

Hey @jansoren - at the moment this repository is supporting Ethereum network contracts only


How "MigrationComplexity" and "MigrationComplexityPoints" are calculated in SharePoint Migration Assessment Tool (SMAT) report?

How "MigrationComplexity" and "MigrationComplexityPoints" are calculated in SharePoint Migration Assessment Tool (SMAT) report?
What is the logic behind calculation of MigrationComplexity(critical/high/medium/low) and MigrationComplexityPoints(integer)?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5bc1ccc3-1713-6a8f-8120-28ca04a7eed8
Version Independent ID: d0ac879e-81d4-ca80-b83d-ea1e318a9fa8
Content: SharePoint Migration Assessment Tool Scan Reports Roadmap - Migrate to Microsoft 365
Content Source: migration/sharepoint-migration-assessment-toolscan-reports-roadmap.md
Service: sharepoint-online
Sub-service: sharepoint-migration
GitHub Login: @JoanneHendrickson
Microsoft Alias: jhendr

Any update on this?

Hello @jaganpt can you please detail in which report scan specifically did you see those properties? Thank you

One of the SMAT generated reports "MigrationReport_Overview.csv" has the columns "MigrationComplexity" and "MigrationComplexityPoints".
What is the logic behind calculation of MigrationComplexity(critical/high/medium/low) and MigrationComplexityPoints(integer)?

Thanks for clarification, will look into that

Hello @jaganpt
I can't seem to be able to reproduce that report on my environment, did you run the SMAT with default settings? is it against a 2010 or 2013 SharePoint?
Thanks

It is against SharePoint 2019.

It is against SharePoint 2019.

Ok please kindly confirm you are using RTM_Update6_1 of SMAT tool and if scandef.json was customized or is by default.
Thanks!

Yes I can confirm that the tool is SMAT_RTM_Update6_1
There were no customization on any part of, it was run as-is.

Hello @jaganpt Jagan,
Just to verify, does this match your version?

Thanks

Hello @get-itips,
Yes, it is the same version.

Hi @get-itips ,
Any update on this?

Hello @get-itips,
Any update on this would really help us. Thanks.

Adding the writer input required label as I could not reproduce.


SDK: fix string field serialization for multipart/form-data requests

Django REST Framework ignores the Content-Type on request body parts, so it doesn't know that they are JSON-encoded. Instead, it just tries to decode each part as if it was an str()-encoded value.
Change the encoding to match the decoding. The only type this matters for is str, because json.dumps and str produce different encodings for str values.
Remove none_type from the list of encodable types since, to my knowledge, there's no way to encode a None value as a multipart/form-data part in a way that DRF will understand.

Motivation and context

This is a follow-up to #5058. Replaces #5240.
How has this been tested?

API unit tests.
Checklist

[x] I submit my changes into the develop branch
[x] I have added a description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

FWIW, I think we should eventually phase out support for multipart/form-data requests.
AFAICS, the only advantage this format has over JSON is that Django makes it easy to handle arbitrary-length file uploads (since it saves the incoming files in a temporary directory). But we already support TUS, which also lets clients upload such files.
On the other hand, multipart/form-data is massively limited in what data types it can encode, and tools can be inconsistent in how they handle field values that are not strings. Not to mention that supporting an extra content type means more required testing, and more opportunities for bugs.

AFAICS, the only advantage this format has over JSON is that Django makes it easy to handle arbitrary-length file uploads (since it saves the incoming files in a temporary directory).

I may be wrong, by comparing to JSON, multipart/form-data should allow passing binary data with no extra encoding overhead, while in JSON we need to encode the data using escape sequences and text characters.

I may be wrong, by comparing to JSON, multipart/form-data should allow passing binary data with no extra encoding overhead, while in JSON we need to encode the data using escape sequences and text characters.

Yeah, fair point. Still, TUS also lets you do this, so we don't need multipart/form-data support.

TUS also lets you do this, so we don't need multipart/form-data support.

Probably, we still have at least 1 use case when we need multipart/form-data - it is when we send multiple files in a single request during task data uploading (both Upload-Multiple and the legacy single request variants). Also, AFAIK requests and urllib automatically encode files as multipart requests.

Probably, we still have at least 1 use case when we need multipart/form-data - it is when we send multiple files in a single request during task data uploading (both Upload-Multiple and the legacy single request variants).

Yeah, it's true.
Perhaps we just need to be careful with the parameters that we accept alongside file uploads, and only use parameter types that can be transferred by simple serialization.

Perhaps we just need to be careful with the parameters that we accept alongside file uploads, and only use parameter types that can be transferred by simple serialization.

It seems like the only working way now, actually. If we will split the parameters by requests and only send the required params (which is only the image_quality now) with client_files (or other files), it works. It doesn't look very attractive to me, but there is no better way found yet. Could you reflect this fact and the way to resolve in the documentation next to other API usage recommendations?


Chart Mirrored

On Google Chrome, this:
var ctx = $("#myChart").get(0).getContext("2d");
var myLineChart = new Chart(ctx).Line(data);
Creates a fine chart.
On the Android phone, I see a mirror version of the chart next to the other one. I already tried this:
jQuery('#vislayer').html("<canvas id="myChart" style="width: 70%; height: 70%;">");
But that solves nothing.

@rpcarnell what version of android are you using? Are you using the stock browser, Chrome, or something else?

http://slash-system.com/en/how-to-fix-android-html5-canvas-issues/
The problem comes from  itself. I used the solution in that website, and the problem was solved.


useSuspenseQuery not working right with variables

I have an issue when passing any variable to useSuspenseQuery is not using variables and returns empty data.
I use codegen to generate queries and types.
Here is the pseudocode example:
client page example usage
'use-client'

import { useSuspenseQuery } from '@apollo/experimental-nextjs-app-support/ssr';
import {
  TestQuery,
  TestQueryDocument,
} from 'generated/graphql';

export const dynamic = 'force-dynamic';

export default function Page() {
  const { data } = useSuspenseQuery<TestQuery>(TestQueryDocument, {
    variables: {
      numKey: '2468'
    }
  });
}

example query

query Test($numKey: String, $alphaKey: String) {
  results(filters: { or: [{ NumKey: { eq: $numKey } }, { AlphaKey: { eq: $alphaKey } }] }) {
    data {
      id
    }
  }
}

server page example usage
  const { data } = await client.query<TestQuery>({
    query: TestQueryDocument,
    variables: {
      numKey: '2468'
    }
  });

Main points:

Returned data, that should be filtered by useSuspenseQuery variables is empty.
Without variables returns all data as should.
If use same query with variables in server component everything works well.

Completely unrelated, but maybe useful: you can skip that manual type annotation, it should pick up the types automatically (that is actually more typesafe!):
const { data } = useSuspenseQuery<TestQuery>(TestQueryDocument, {
const { data } = useSuspenseQuery(TestQueryDocument, {

For the problem at hand: I have never seen that happen before. Could you please create a minimal reproduction that I could take a look at - or make a Replay recording of what's going on in the browser?

@phryneas
Hello, I have recreated my queries in the codesandbox and now I don't see any problem with using variables. Sorry, the reason must somewhere else.


Research PI Connector validation checks

Research spike to identify high priority security aspects of PI Connector configurations which we could audit with PowerShell.  Result should be a short list, (~5) proposed checks.

Research indicated PI Connector validation library would be of limited value at this time.  Due to the limited configuration of PI Connectors, the bulk of the benefit would be provided from the machine level checks.  Another issue will be created to revisit if necessary.


fix(pagination): add id as prop and change unique creation

Resolves: https://github.com/carbon-design-system/carbon-components-react/issues/125
I'm now generation a random ID for each component on componentWillMount and move id to a prop - server side rendering UI's will need to pass in id's manually

Bluemix toolchain: Delivery Pipeline deployed carbon-components-react to Bluemix Design System, including commit 7ea8ab9e46bc1df76d246db186c645aecbd7bbbe


Lexical BlockFeature/UploadFeature: only media ID is retrieved if nested

Link to reproduction
No response
Describe the Bug
As soon as a media is attached within a nested lexical, only ID thereof is retrieved, despite setting depth query parameter to a very high value.
To Reproduce

Attach a media to lexical either via Upload feature of by using a block with an image e.g. `type: 'upload', relationTo: 'media'
Verify depth is set correctly and the whole image object is fetched as expected
Now create a block featuring a nested rich text (I'm using an Array where a rich text is only field of an array item)
Attach media to a nested lexical as described in pt.1
Only media ID is being retrieved for an image field

Payload Version
2.0.14
Adapters and Plugins
richtext-lexical, db-mongodb, bundler-webpack

Looks like this has been fixed on master. At least, I can't reproduce it. Another PR might have fixed it coincidentally.
You can expect the fix in v0.1.18 or higher of the lexical plugin! If there's still an issue in that version, please do open a new issue with a reproduction.

@AlessioGr I am having this issue still. When fetching a collection that contains blocks, and those blocks contain rich text, which in turn contains more blocks, image relations are either not populated. When increasing the depth param, the image data is included but now the rich text content is not there.

@stefvw93  I'm dealing with this as well. What's interesting though is that I only have it on dev and not on production

Okay the issue is now present on both local and production. On lexical with nested blocks, media just returns an ID. Are there any fixes for this? @AlessioGr @stefvw93 @pooledge

Okay the issue is now present on both local and production. On lexical with nested blocks, media just returns an ID. Are there any fixes for this? @AlessioGr @stefvw93 @pooledge

For now I switched over to REST API

I have tried to reproduce it again, but am sadly unable to. Due to that, I'll have to ask you to open up a new issue with a reproduction, following our reproduction guide.
If you can do that, and reproduce it with @payloadms/richtext-lexical 3.0.0-beta.36 or higher, I'm happy to look into this again ASAP :)


Implementation details of finetuning Swin UNETR on BTCV

Hi,
Thank you for sharing your great work. Could you please provide some clarity on the implementation details on the BTCV dataset for the Swin-UNETR.

Please clarify that the reported numbers on BTCV in the Self-Supervised Pre-Training of Swin Transformersfor 3D Medical Image Analysis paper are finetuned on the BTCV data from the pretrained model "Swin UNETR/Base".

Please share details on the batch size and learning rate used in finetuning for BTCV to get the reported numbers?

Thank you.

Hi @hanoonaR , thanks for the interest of the work.

Yes, experiments are conducted and fine-tuned with the pre-trained model "swin UNETR/base". But note the number reported in the leaderboard is trained with additional training data. Please refer to Table 4 with a single fold, single model perforance.
Batch size is 4 with single GPU, the model is trained with 4 x 32G GPUs. Initial learning rate is set to 1e-4 x [number of GPUs] in the DDP training.

Hope these helps. Thanks.


After update I lost theming

I've updated to latest <IP_ADDRESS> and after run I see that background and text changed colours:

I'm still using AlertDialog wrapper.
I've also tried <item name="md_dark_theme">false</item> but without success.
Just for comparison here is what I saw before:

I'll try to get this fixed.
The reason why this happens: when you construct a Builder, it sets a default theme (Light or Dark) based on the ?android:textColorPrimary attribute of your Activity. If it's light (e.g. a shade of white), it guesses the Activity is using a dark theme. If it's dark (e.g. a shade of gray), it guesses the Activity is using a light theme. DialogInit checks if you set md_dark_theme, but the default value is false, so it assumes if md_dark_theme is false that you didn't override the default theme in the Builder.

Thanks for commenting. Just one thing for me is not obvious. If I set md_dark_theme to false in my theme I still get dark dialogs. I don't get from your explanation is it as expected or an issue.

Basically, setting it to false has no effect because it's assuming that's the default value and it doesn't override the default theme that the Builder loads. But yes, it's a bug.

This is now fixed with https://github.com/afollestad/material-dialogs/commit/c39b09e0cefbf98282c1a8ba216b6c60038bd373, an update will come today

Thanks!

https://github.com/afollestad/material-dialogs/releases/tag/v<IP_ADDRESS>


ElixirLS cannot find root mix.exs in Emacs from subdirectory.

Environment

Elixir & Erlang versions (elixir --version): Elixir 1.13.0 and Erlang/OTP 24
Operating system: Linux (EndeavourOS)
Editor or IDE name (e.g. Emacs/VSCode): Emacs (custom configuration)
Editor Plugin/LSP Client name: Eglot

I have a directory named Elixir, in which each subdir is a mix project, made using mix new.

When I open a project, if the file I open is in the root of the project, living besides the mix.exs file, then the language support works as expected.
But if I open a file from a subdirectory of the project, it says that it cannot find the project mix.exs file, and that I may set it manually using elixirLS.projectDir.
I looked at the eglot event logs and the language server only searches the current file's directory for a mix file for some reason.
Any help is appreciated, and I am ready to provide any logs or such that I may provide assistantance.

I haven't used eglot before, but lsp-mode lets you set the root directory of your project. Does eglot have a similar setting?

From looking at their repository, I don't think that they have a similar setting. Since their idea is as little user configuration needed as possible.

Update : Using project.el instead of projectile for projects seems to have fixed the issue. The language server is recognising the project root correctly.
I will let it run for a day or so, and if it continues to work as expected, will mark the issue as closed.

Marking this issue as closed, seems like it was a projectile thing.


Allow defining options that apply to children commands

## services

**OPTIONS:**
* port
    * flags: -p --port
    * type: string
    * desc: Which port to serve on

### services start <service_name>

> Start or restart a service.

Child command would have the parent's `port` variable in scope.

~~~bash
echo "Starting service $service_name on $port"
~~~

After thinking about this further, it doesn't seem worth it. All subcommands of a command would rarely need access to the exact same set of options.


[ALLUXIO-2656]Make IndexedSetTest final

https://alluxio.atlassian.net/browse/ALLUXIO-2656
To avoid accidental subclass extension.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14586/
Test FAILed.

Merged build finished. Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14588/
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14589/
Test PASSed.

Merged build finished. Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14590/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/14640/
Test PASSed.

Merged build finished. Test PASSed.


Triggers not firing intermittently

Version
3.2.1
Running in net7.0 aspnet application
Scenario
Some code omitted for brevity.
    public class SubmitFleetBookingForReviewHandler
        : IRequestHandler<SubmitFleetBookingForReviewInput, SubmitFleetBookingForReviewOutput>
    {
        private readonly ILogger<SubmitFleetBookingForReviewHandler> _logger;
        private readonly IRequestAuthVariables _requestAuthVars;
        private readonly ISupplierAuthorizer _supplierAuthorizer;
        private readonly IClock _clock;
        private readonly AutoGuruDbContext _db;
        private readonly IBookingStatusTransitionValidator _bookingStatusTransitioner;
        private readonly IRequestHandler<AcceptFleetSignOnAgreementRequest, Unit> _acceptFleetSignOnAgreementHandler;
        private readonly IRequestHandler<AssessBookingBusinessRulesRequest, BookingBusinessRuleBookingAssessment> _assessBookingBusinessRulesHandler;

        public SubmitFleetBookingForReviewHandler(
            AutoGuruDbContext db,
        )
        {
            _db = db;
        }

        public async Task<SubmitFleetBookingForReviewOutput> Handle(
            SubmitFleetBookingForReviewInput request,
            CancellationToken cancellationToken)
        {
            <code here that changes the booking>

            try
            {
                _logger.LogDebug("Before 1st save. Booking Id = {bookingId} Booking Status Id = {bookingStatusId} DbContextId = {dbContextId} Lease = {lease}",
                    bookingId, booking.BookingStatusID, _db.ContextId.InstanceId, _db.ContextId.Lease);
                _logger.LogDebug("Changes before 1st save. {changes}", _db.ChangeTracker.DebugView.LongView);

                await _db.SaveChangesAsync(CancellationToken.None);

                _logger.LogDebug("After 1st save. Booking Id = {bookingId} Booking Status Id = {bookingStatusId} DbContextId = {dbContextId} Lease = {lease}",
                    bookingId, booking.BookingStatusID, _db.ContextId.InstanceId, _db.ContextId.Lease);
                _logger.LogDebug("Changes after 1st save. {changes}", _db.ChangeTracker.DebugView.LongView);

                _logger.LogInformation("Fleet booking ({bookingId}) submitted for review,", bookingId);
            }
            catch (DbUpdateConcurrencyException)
            {
                return new SubmitFleetBookingForReviewOutput(bookingId, new ConcurrentUpdateError());
            }

            <code here that changes the booking again>

            _logger.LogDebug("Before 2nd save. Booking Id = {bookingId} Booking Status Id = {bookingStatusId} DbContextId = {dbContextId} Lease = {lease}",
                bookingId, booking.BookingStatusID, _db.ContextId.InstanceId, _db.ContextId.Lease);
            _logger.LogDebug("Changes before 2nd save. {changes}", _db.ChangeTracker.DebugView.LongView);

            await _db.SaveChangesAsync(CancellationToken.None);

            _logger.LogDebug("After 2nd save. Booking Id = {bookingId} Booking Status Id = {bookingStatusId} DbContextId = {dbContextId} Lease = {lease}",
                bookingId, booking.BookingStatusID, _db.ContextId.InstanceId, _db.ContextId.Lease);
            _logger.LogDebug("Changes after 2nd save. {changes}", _db.ChangeTracker.DebugView.LongView);
        }
    }

We have a number of triggers attached to the Booking, some IBeforeSaveTrigger and some IAfterSaveTrigger.
Intermittently the triggers on Booking don't fire during the 2nd SaveChangesAsync() in the code above.
Logs
FailedLogs.txt
SuccessLogs.txt
Differences
When successful, 33 triggers are discovered.  When it fails, the first 22 triggers match, but 11 are missing.
Invoking trigger: "AutoGuru.DataAccess.Triggers.Booking_BeforeSave_SetSupplierPaidAt" as "EntityFrameworkCore.Triggered.IBeforeSaveTrigger`1[AutoGuru.Entities.Booking]"
Invoking trigger: "AutoGuru.DataAccess.Triggers.Booking_BeforeSave_SetAutoGuruPaidAt" as "EntityFrameworkCore.Triggered.IBeforeSaveTrigger`1[AutoGuru.Entities.Booking]"
Invoking trigger: "AutoGuru.DataAccess.Triggers.Booking_BeforeSave_SetRatesAndDiscountsForFleetBookings" as "EntityFrameworkCore.Triggered.IBeforeSaveTrigger`1[AutoGuru.Entities.Booking]"
Invoking trigger: "AutoGuru.DataAccess.Triggers.Booking_BeforeSave_SetPayerAndPaymentTerms" as "EntityFrameworkCore.Triggered.IBeforeSaveTrigger`1[AutoGuru.Entities.Booking]"
Booking_BeforeSave_SetMerchantServiceFeeForFleetBooking. Booking Id = 6005225 % = 0.0350 $ = 14.37
Booking Id = 6005225 Fleet Company Id = 1 Supplier Id = 830 Booking Status Id = 33 DbContextId = fba0254d-8bb0-4555-adff-a648aa665397 Lease 26
Invoking trigger: "AutoGuru.DataAccess.Triggers.Booking_BeforeSave_SetMerchantServiceFeeForFleetBooking" as "EntityFrameworkCore.Triggered.IBeforeSaveTrigger`1[AutoGuru.Entities.Booking]"
Invoking trigger: "AutoGuru.DataAccess.Triggers.Booking_BeforeSave_SetLastReviewedPropertiesOfBookingTicketItems" as "EntityFrameworkCore.Triggered.IBeforeSaveTrigger`1[AutoGuru.Entities.Booking]"
Invoking trigger: "AutoGuru.DataAccess.Triggers.Booking_BeforeSave_SetDataFee" as "EntityFrameworkCore.Triggered.IBeforeSaveTrigger`1[AutoGuru.Entities.Booking]"
Invoking trigger: "AutoGuru.DataAccess.Triggers.Booking_BeforeSave_ResetClaimOnAction" as "EntityFrameworkCore.Triggered.IBeforeSaveTrigger`1[AutoGuru.Entities.Booking]"
Invoking trigger: "AutoGuru.Shared.Bookings.Booking_ConsumeSupplierTimeSlot" as "EntityFrameworkCore.Triggered.IBeforeSaveTrigger`1[AutoGuru.Entities.Booking]"
Invoking trigger: "AutoGuru.DataAccess.Triggers.CreationTimestampingTrigger" as "EntityFrameworkCore.Triggered.IBeforeSaveTrigger`1[AutoGuru.Entities.Abstractions.ICreationTimestamped]"
Invoking trigger: "AutoGuru.DataAccess.Triggers.UpdateTimestampingTrigger" as "EntityFrameworkCore.Triggered.IBeforeSaveTrigger`1[AutoGuru.Entities.Abstractions.IUpdateTimestamped]"

The logs show the DbContextId of the DbContext injected into the code above and the DbContextId used in the trigger discovery process (TriggerContextTracker). The same context is used (as expected) but the changes don't seem to be detected.
We're using the default cascade behavior and limit.
In terms of testing, it is sometimes very intermittent in that I could use JMeter to submit 1000 bookings and all are successful. In other tests, multiple could fail within the first 100 requests.
I will be doing further investigations and will update as I make discoveries.

I'm about to test with a single trigger (the trigger that sets the merchant service fee in the logs).
Then I plan to add more logging into the trigger discovery and execution code. I'm keen to log the tracked changes as close as possible to where they're used to determine the triggers to execute.

I have added further logging.

223-306:  The first save of the booking. Changes the status from 3 to 12. All triggers fired.
300: The Booking with change type Modified is added to the discovered changes.
Notice that the changes are being detected on the same DbContextId
217: The discovered changes is not null
206-216: Adding discovered changes. It seems that the Booking with change type Modified is skipped because it was already in the list of discovered changes.
This means that all triggers on Booking are not executed.

FailedVerboseLog.txt
In contrast, when it runs successfully

72: Discovered changes is null
63: Booking with change type Modified is added to discovered changes
All triggers fire successfully

SuccessVerboseLog.txt
This issue is intermittent so it feels like some sort of race condition.
I think the issue is that _discoveredChanges in TriggerContextTracker is being retained between calls to SaveChangesAsync. Is it reasonable to clear the discovered changes at the end of trigger execution?
My current thought is that the issue is in TriggerSessionSaveChangesInterceptor and is something to do with the parallel save changes count. If the second SaveChangesAsync enlists the trigger session before the first SaveChangesAsync delists the session and disposes the session, then discovered changes will be retained between saves.

Is it reasonable to clear the discovered changes at the end of trigger execution?

Yes, TriggerContextTracker is managed by a TriggerSession who's lifetime is tied to the SaveChanges() method.

If the second SaveChangesAsync enlists the trigger session before the first SaveChangesAsync delists the session and disposes the session, then discovered changes will be retained between saves.

That should never happen. _parallelSaveChangesCount is a bit of a misleading name as it's counting the recursive number of calls to SaveChanges(), e.g.
//userCode
db.SaveChanges();
// trigger1
db.SaveChanges();
// trigger2
db.SaveChanges();

Will effectively cause:
interceptor.SavingChanges(...); // userCode, Enlists a new trigger session
interceptor.SavingChanges(...); // trigger1, Reuses trigger session
interceptor.SavedChanges(...); // trigger1, Does not dispose trigger session
interceptor.SavingChanges(...); // trigger2, Reuses trigger session
interceptor.SavedChanges(...); // trigger2, Does not dispose trigger session
interceptor.SavedChanges(...) // userCode: Disposes trigger session

Are you by any chance using DbContextPooling?

We are using pooling

I can probably run some tests today without pooling and see what happens.

I'm wondering if there is a bug in code where the trigger session is not delisted correctly, this could cause the behavior that you're seeing and frankly, the interceptor is somewhat fragile.
Can you make the interceptor a resettable service (while using Pooling):
class TriggerSessionSaveChangesInterceptor : ISaveChangesInterceptor {
    public void ResetState() {
        if (_triggerSession is not null) {
            throw new ThisIsBadAndShouldNeverHappenException();
        }
    }
}

And update the registration in TriggerOptionExtensions.cs:
// from:
services.TryAddScoped<IInterceptor, TriggerSessionSaveChangesInterceptor>();

// to:
services.AddScoped<TriggerSessionSaveChangesInterceptor>();
services.AddScoped<IInterceptor>(sp => sp.GetRequiredService<TriggerSessionSaveChangesInterceptor>());
services.AddScoped<IResettableSevice>(sp => sp.GetRequiredService<TriggerSessionSaveChangesInterceptor>());

Looking forward to hearing your results

Tested around 4k bookings and was unable to reproduce after implementing IResettableService. The exception was not thrown.

I was able to get the exception to throw
System.InvalidOperationException: Trigger session should be null here. This should never happen.    at EntityFrameworkCore.Triggered.Internal.TriggerSessionSaveChangesInterceptor.ResetState() in /src/EntityFrameworkCore.Triggered/src/EntityFrameworkCore.Triggered/Internal/TriggerSessionSaveChangesInterceptor.cs:line 195    at Microsoft.EntityFrameworkCore.DbContext.Microsoft.EntityFrameworkCore.Infrastructure.IResettableService.ResetState()    at Microsoft.EntityFrameworkCore.Internal.DbContextPool`1.Return(IDbContextPoolable context)    at

This is thrown from a background service processing events from a queue.

I have not been able to reproduce the issue after adding the code above. I've tried many thousands of requests.
I reverted to the version before I added the code above and was able to reproduce twice.

Ok I think we isolated the issue:
The SaveChangesFailed and SaveChangesFailedAsync interceptor methods are not called when a trigger raises an exception explicitly, e.g.
public class ThrowExceptionTrigger : IBeforeSaveTrigger<Entity>
{
    public void BeforeSave(ITriggerContext<Entity> context)
        => throw new InvalidOperationException("Throwing up...");
}

Will ignore SaveChangesFailed and SavedChanges and therefore not dispose of the TriggerSession. A pooled DbContext would then hang on to the trigger session which is both a memory leak and can cause the behavior that you're describing.
We would certainly want to make TriggerSessionSaveChangesInterceptor a ResettableService to ensure that TriggerSession will always get deposed of. In addition, We'll need to figure out if we can make AfterSaveFailed triggers work properly again or otherwise document accordingly.
I'll spend some time on it this weekend.

Thanks. Let me know if I can help with anything.

A release with this fix is now avail on nuget: https://www.nuget.org/packages/EntityFrameworkCore.Triggered/3.2.2


inputs lose focus on... well, input

Description
Whenever I type into an input-element (like the one below), the input loses focus, and I have to re-click to type on.
here's an example of what I'm doing:
<input
  type="text"
  value={this.state.message}
  onInput={(event: any) => this.setState({ message: event.target.value }, true)}
/>

Am I doing something wrong, or is this sort of thing supposed to work?

this.setState({ message: event.target.value }, true)}
With setState function to true, you call an update on the component, everytime an input event (keypress) is fired.
When the component updates, you lose the focus (check the Component docs for more info).
One workaround would be to set the event.target.value not on keypress, but when the input loses focus (user clicks somewhere else). Or like in this example, at the moment, when pressing submit.

I recommend you follow the form example:
https://nanojsx.io/examples.html#form
When working with forms, I prefere to use vanilla javascript to update the DOM instead of calling update()

When the component updates, you lose the focus
This isn't the sort of approach React or similar libraries take - Do you intend to in the future, or do you consider this a non-feature - in a sentence: to maintain element-focus across DOM-updates?

I don't think this is something I will add. The input element will be replaced once calling update(), therefore it is not possible to remain focused.
Consider something like this, without ever re-rendering the component:
class App extends Component {
  didMount() {
    this.renderMessage()
  }

  renderMessage(length = 0) {
    const minimum = 8
    render(

        Min. characters needed is {minimum} ({length - minimum})

,
      document.getElementById('message')
    )
  }

  validate(event: any) {
    const el = event.currentTarget as HTMLInputElement

    if (el.value.length >= 8) el.classList.add('ok')
    else if (el.value.length > 0) el.classList.add('warn')
    else {
      el.classList.remove('warn')
      el.classList.remove('ok')
    }

    this.renderMessage(el.value.length || 0)
  }

  render() {
    return (
      <form>

        <input type="text" onInput={this.validate.bind(this)} />
      </form>
    )
  }
}

render(<App />, document.getElementById('root'))

thanks for you feedback 👍
I come at this from the perspective of programming in the browser using Elm, React, etc.
I'm excited about doing this sort of work without having to rely on the DOM directly - I appreciate the minimalism of nanojsx, and I'd love to be able to do state-binding of inputs and component-state (like my example above).
Thanks for building this - it's really cool.

You're welcome 😁
Maybe you could write a custom <Input/> component? Or a functionality to update the value of each input field without triggerng a re-render? There are alternatives to two-way bindings. 👍🏻

One of the reasons I really enjoy Elm is the idiom of having all state in one place, and reducing over that when rendering graphics.
The programming-model in Nano requires manually programming state-synchronization between my application-model, and the input itself - in other words:

code to mutate the DOM, and update the input value... Ideally within the Input-element. This would require it to be a Component with lifecycle-methods, instead of a pure view-function
som sort of onInput event-handler to pass the value back from Input, into my application-model

There's probably other ways around this, but with the sort of architecture I have in mind... I imagine something along those lines to be the idiomatic NanoJSX-approach?

being close to the DOM is really beneficial in a lot of cool ways - I really like that. But it breaks the abstraction of not having a DOM at all, which is my preferred method 😄


build(images): add tag argument

Allows one to explicitly build the binaries with a given tag, as opposed to the alias-tag which simply adds a docker image tag alias.

@dsavitskiy the second commit is an alternative fix for the first, which is much simpler as we simply tag the tag in the build derivation. However, the first one has the advantage that doesn't rely on the .git as a dependency for the cargo-build, so avoids unnecessary rebuilds by figuring out the tag in a separate derivation - if the tag doesn't change, the cargo build is never invoked.
Which one would you prefer here?

bors merge

bors merge


refactor(ModelManager): factor out _get_implementation method

The motivation here went something like this:

I want to add a new field to the model manager listing.
It looked like the right place to do that is in invokeai.backend.model_management.models.base.ModelBase, because that's where get_size is. It also seems to be the class that has access to path where the model is stored instead of just its run-time data.
It should be accessible without loading the full model weights in memory and locking it with ModelLocker.

I got stumped trying to figure out how to get the ModelManager to give me a ModelBase instance for a model it's managing.
This PR includes some refactoring to make that more accessible, and sketches a new ModelManager method to make those instances — but we could also revert that last bit, leaving this PR to be pure refactoring and then work out the details of the new method separately.
Usage looks something like:
from invokeai.app.services.config import InvokeAIAppConfig
from invokeai.backend.model_management import ModelManager

config = InvokeAIAppConfig.get_config()
manager= ModelManager(config.model_conf_path)
m = manager._instantiate('aZovyaPhotoreal_v2', 'sd-1', 'main')
print(m.get_size())

What type of PR is this? (check all applicable)

[x] Refactor

except for the last commit, which demonstrates the motivating factor

[ ] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

you're looking at it

Have you updated all relevant documentation?

[ ] Yes
[x] No

Related Tickets & Documents

#4071 - that effort is much larger in scope

QA Instructions, Screenshots, Recordings

Added/updated tests?

[ ] Yes
[x] No, not yet but geez I hope there are tests for this class

Something else I stumbled over while working on this was the necessity to call create_key everywhere, and sometimes parse_key would even do string parsing on that to try to restore information from it.
Is there still an API requirement for the key of ModelManager.models to be a string, or may we revert to using a (name: str, BaseModelType, ModelType) tuple for they key, skipping the stringificiation?
That doesn't need to be in the scope of this PR, but it would allow streamlining these functions while refactoring them.

Now it turns out this does fix a bug: the changes by #4061 missed the case of a relative path being used in the VAE override.

Now it turns out this does fix a bug: the changes by #4061 missed the case of a relative path being used in the VAE override.

Thanks for catching that.


Invoking "copy-config --source running --target startup" is wiping out the startup config

Build and installed libssh, libyang, libnetopeer2, Netopeer server and CLI, and sysrepo from source (all development branch, and pulled with the latest).
Add in the "examples.yang" module.   Edit the configuration of this either through the sysrepocfg or netopeer2-cli and set a value for "/examples:cont/l".  This shows up in the "running" configuration with no issue.
From the net2peer-cli, connect and then issue
copy-config --source running --target startup
No errors are reported however the "startup" config is wiped out.   This can be seen by either sysrepocfg or  netopeer2-cli.
I think this issue is in this code "netconf.c" line 338 which looks like
    /* NACM checks */
    if (!config && (ds != SR_DS_STARTUP) && (sds != SR_DS_RUNNING)) {
        /* get source datastore data and filter them */
        sr_session_switch_ds(session, sds);
        rc = sr_get_data(session, "/*", 0, 0, 0, &config);
        if (rc != SR_ERR_OK) {
            goto cleanup;
        }
        printf("filtering the datastore\n");
        ncac_check_data_read_filter(&config, np_get_nc_sess_user(session));
    }

With the debugger attach, the "config == NULL" and "ds == SR_DS_STARTUP" and "sds == SR_DS_RUNNING"
So the "if" is not entered.  Then at line 381, we have
        rc = sr_replace_config(session, NULL, config, NP2SRV_DATA_CHANGE_TIMEOUT, NP2SRV_DATA_CHANGE_WAIT);

This ends up replacing the datastore with "config" which is NULL.
I think the bug has something to do with not trying support the NACM  and filtering out the nodes that are not accessible.

Hi,
you are right, please it now, should work properly.
Regards,
Michal

Tested with the latest code and it now works correctly.  Thank you!.
I am not sure of the procedure, am I supposed to close the issue or will the developers close the issue?

Hi,
if the issue is fixed, you can close it. Once it is merged into master, it would be closed automatically.
Regards,
Michal


:bug: Fix render-image.html for SVG

SVG images do not support resizing, so srcset/src attributes should be simplified
Fixes #413

Thanks for the PR, @kpavlov! I'm happy to accept this fix and will merge it in now.


using ACEpotentials should not put ACE1.Random into global scope

This means that one can then not import the core Random package, which is a huge problem.

Should the fix be in ACEpotentials (which re-exports ACE1) or in ACE1, which exports ACE1.Random here: https://github.com/ACEsuit/ACE1.jl/blob/8ac52d2128241a01d8b9a036f41b1d5106cbeb07/src/ACE1.jl#L62.

I'm not sure I understand exactly what is required, but happy to do something if you suggest it.

I'm trying to think about whether it is worth to make a breaking change for this given that we are trying to retire ACE1 entirely. I'm currently working on achieving feature parity of the new implementation with ACE1. If I can achieve this within the next few days/weeks, then we could just close this as no longer relevant?

#215 implemented the necessary changes avoiding re-exporting all of  ACE1 and ACE1x on the main branch. I will not fix this on v0.6.x


Ways to Connect Vega Wallet (Minimum Viable UX)

As a user
When I have clicked the/a Connect Wallet button in the dapp
I want to understand the options for how to connect my wallet based on the type of wallet I have
So that I have the information I need to successfully connect my wallet (and don't immediately see an error message!)
Acceptance Criteria

I only see the wallet connect options that are relevant to the network I currently have selected in my dapp - i.e I don't see hosted Fairground wallet if my dapp is connected to mainnet

Epic for Context Connect a Vega Wallet Flow.pdf

Since this ticket was raised, this PR has acceptance criteria for connecting to a wallet. The ACs on this ticket should be added to ones in the specs repo as these are what we write tests against.
Covered in 0002-WCON-039

This is blocked as it is a common component that is currently being developed in Console, once done it should be a case of TFE gets it for free (but we'll want to verify :) )


"Midb 関数 $" needs to be replaced with "MidB$"

https://docs.microsoft.com/ja-jp/office/vba/language/concepts/getting-started/returning-strings-from-functions

@hyoshioka0128 Article has been HumanTranslated and published live. The issue is fixed


Add sanitized_options for collection check_boxes and radio_buttons

This PR aims to address a pain point for some users that try to use check_boxes or radio_buttons with collection array that contains non-latin characters. (https://github.com/plataformatec/simple_form/issues/1347 and  https://github.com/plataformatec/simple_form/issues/1350). The current code filters values through a latin regex (/[^-\w]/), and generates id and for attributes after that. This results in inaccurate values and broken functionality (cannot check checkbox by clicking on its label).
Here is a repo with working examples: https://github.com/petrgazarov/simple_form_check_boxes
Thanks for your work with simple_form btw, I'm a big fan and prefer it to vanilla forms every time!

Any chance for a review here?

/summon @rafaelfranca

Thank you for the pull request. While I agree this is a problem I don't think having a new option only for this is a good idea. Instead of sanitized_options I'd prefer that users provide the ids that they want to use.
Also, does this problem also exists in the Rails helpers? If it does, I think it is a better idea to fix this in Rails directly.

@rafaelfranca Yes, I had the same problem using rails forms. My thinking was that simple_form can provide this functionality as an extra above what rails form does. I do agree though, that it'd be even better if rails had that feature, which would naturally be included here.
Happy to explore the ids approach, otherwise feel free to close. Thanks!

Is this still an issue?

I'm close this PR since it hasn't recently activity.

This is definitely still an issue.


send initial unready endpoints when SendUnhealthyEndpoints is enabled

Fixes https://github.com/istio/istio/issues/46892

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@howardjohn WDYT? I know I have initially suggested not to send "UnReady" endpoints to avoid issues with panic threshold. But now since, we disable panic threshold when SendUnhealthyEndpoints is enabled, I think it is safe to send the initial non ready end points. It is also needed to fix the inconsistency between Istiods as described in https://github.com/istio/istio/issues/46892.
Let me know if you have any alternate suggestions.


feat(orchestrator): add auto refresh to workflow runs tab and workflow execution results page

@batzionb This fork is no longer necessary. Could you please open this PR targeting janus-idp/backstage-plugins @ main?


Update link to Fastlane's .gitignore

Reasons for making this change:
Fastlane moved their docs. The previous link is broken.
Links to documentation supporting these rule changes:
https://github.com/fastlane/fastlane/commit/8831ded60972086cbe088c14beeb80009998cf9e
If this is a new template:

Link to application or project’s homepage: TODO

Old link broken, replaced with new docs link.

Also needs a change in Objective-C.gitignore

Closing as link no longer exists.


Fix SOLR

Fixes SOLR on TravisCI and one spec that got broken due to SOLR upgrade. The diff isn't clear, as I deleted /solr dir, so lots of deleted lines.

/solr is removed as it's automatically generated anyway when you start SOLR for the first time. When this dir was present, SOLR didn't want to create cores on Travis and it didn't work correctly. We didn't modify anything in this dir, so I don't think we need to store it anyway.

solr_home added to config/sunspot.yml. It was necessary to fix Travis. Also, it didn't work there without Rails.root path composition.

spec/support/solr_spec_helper.rb is updated, it doesn't try to start SOLR anymore and will remind you to do it if you forget. It takes a while before SOLR is ready to use, so tests were failing. I didn't find a clear way to determine when everything is ready to use (now I think we could probably inspect local files and check if /solr/test/data exists etc., but not sure if that's good enough and worth it). IMHO it's okay to start SOLR manually. Sunspot docs suggest that too: https://github.com/sunspot/sunspot#running-tests

Readme and .travis.yml are updated (start SOLR before tests).

Re failing spec, this commit message explains everything: https://github.com/concord-consortium/rigse/commit/032470e78c8c588ea1cd7a1b09bf343f2d319c04 Search behaviour changes a bit now, but I hope it's fine. We're more strict about ' characters. I'd consider using wildcards (*) in search terms, so we return more results (e.g. in Portals search autocomplete which is not very useful now), but probably that should be a new feature.

@dougmartin or @scytacki, could you take a look when you get a chance?
When it's merged, I'll merge master into this branch and probably we should be ready to merge itsi-staging back into master.

👍


[BUG] Command usage message not sent for incorrect argument count in pointsMod.

Describe the bug
In pointsMod the number of arguments are validated in execute. If validation fails, the command usage message should be sent. Currently, this is pointing to the old function that no longer exists, so it will fail. Correct this to use messageHandler.sendCommandUsageMessage(message).
To Reproduce
Send the command +points a and watch it fail.
Screenshots

I have the fix for this ready to push after PR #87 is approved and merged in.


Connect 2 peers running on different networks

How do I connect 2 peers running on the cloud? I can't bind a peer to a public IP address, and I can't listen on <IP_ADDRESS>, as peers won't know who to talk to. Is there a way I can get 2 peers to talk that are not on the same network? By "connect" I mean I want both peers to have each other in their routing table

I think you need another node with a public IP address. First, the 2 peers connect to the public node and then each peer can discover the other by querying the public node.


Remove extra trailing commas in Godeps.json.

This breaks Godeps otherwise.

@fabxc

:+1: Wondering how that happened in the first place.


fix demjson conflict

Short Description:
fix demjson conflict
Changes:

should work even with demjson installed

@OpenPoGo/maintainers

Current coverage is 38.24% (diff: 0.00%)

Merging #284 into master will decrease coverage by 0.02%

@@             master       #284   diff @@
==========================================
  Files            30         30
  Lines          1377       1378     +1
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits            527        527
- Misses          850        851     +1
  Partials          0          0

Powered by Codecov. Last update 670df15...5d8c6ac

👍

:+1:


SSR Support

In onInit and onDestrory you should do
if (typeof(window) === 'undefined') {
return ;
}
so your directive is disabled when executed under node for server side rendering.
Currently it breaks app with error that window is not defined in ngOnDestroy.

Added in v2.3.0.


[Python] Remove file level Python linting bypass ("# flake8: noqa") from GenerateSliceTests.py

What's in this pull request?
Fix linting issues in GenerateSliceTests.py and remove file level Python linting bypass (# flake8: noqa ).
Thanks to @rintaro who suggested the fix.
Resolved bug number: –

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

Could you regenerate the tests?


cmd/compile: missing types in debug_info

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version devel +2b445c7 Sat Nov 5 23:59:04 2016 +0000 linux/amd64

What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/a/n/go/"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build237842021=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

What did you do?
Compiled this with go build -gcflags='-N -l'
What did you expect to see?
I expected .debug_info to have entries for the anonymous types map[string]main.astruct, []main.astruct and for the named type main.astruct.
What did you see instead?
None of those.
I presume this is deliberate and types that are not referenced by any variable are pruned from debug_info. In delve to print the value of an interface variable we used to parse the value of their tab._type field to reconstruct the name of the type and then look that up in debug_info, how should we do this now? If the answer is "you should use runtime._type directly" then at least runtime.slicetype, runtime.arraytype, runtime.maptype, etc... should always be included in debug_info so that we don't have to hardcode them into the debugger for every version of go.

@crawshaw is this related to your recent changes?

The only change I've made recently to type information is exporting more symbols when building plugins, which shouldn't have anything to do with this. Maybe you mean someone else's changes?

Looks like this is a side-effect of 9c066bab643a0224decdd71813096e0d1df0624c

If I understand correctly, the issue isn't actually that you need DWARF type info for temporary variables, but you need the DWARF type info for map-related struct types, and we used to only emit those because they were referenced in temporary variables?
I.e., reverting to the previous behavior where we emit DWARF type info for temporary variables fixes the issue, but really we just need to ensure that we emit info for all of those map-related struct types regardless of whether they're used as temporaries?

It isn't just map types, if you look at the example type info for main.astruct isn't emitted either.

@aarzilli Ah, thanks. I misread the type name in the bug report and thought you were talking about map.bucket or something.

In delve to print the value of an interface variable we used to parse the value of their tab._type field to reconstruct the name of the type and then look that up in debug_info, how should we do this now?

@aarzilli I was re-reviewing the fix for this CL, and I'm wondering: what does delve do with types that are constructed at runtime using reflect APIs? E.g., how does it handle:
package main

import (
	"fmt"
	"reflect"
)

type astruct struct {
	a, b int
}

func main() {
	stringTyp := reflect.TypeOf("")
	astructTyp := reflect.TypeOf((*astruct)(nil)).Elem()

	var iface interface{} = reflect.MakeMap(reflect.MapOf(stringTyp, astructTyp)).Interface()
	var iface2 interface{} = reflect.MakeSlice(reflect.SliceOf(astructTyp), 0, 0).Interface()
	fmt.Println(iface, iface2)
}

@mdempsky they are not supported. I have considered writing code to read the runtime._type and turn it directly into a dwarf.Type (without going through debug_info) but:
a) I would need the specialized versions of runtime._type (i.e. runtime.slicetype, runtime.maptype, etc) to be exported to debug_info.
b) it's a lot of work for something that has minimal use, so I've been putting it near the bottom of the list of things I should do for delve
For (a) I was hoping to propose this change during 1.9 since they are useful for other stuff, (b) is somewhat more fundamental.


Changes to use allow list of function signatures in dialect yaml files

@richtia can you please review this PR


CI Server cannot run this command, restore will not succeed

Running dotnet build foo.sln does not restore nuget packages successfully when running the command from a CI Server (using CruiseControl.net as administrator). Running the same command from a CLI works flawlessly.
Error being error NU1100: Unable to resolve 'Serilog.AspNetCore (>= 2.1.1)' for '.NETCoreApp,Version=v2.2'..

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b7e47565-cc59-b1a6-24be-0143c550c0b2
Version Independent ID: c6859ca6-e2b1-3645-872c-60390ffd429a
Content: .NET Core Command-Line Interface (CLI) Tools - .NET Core CLI
Content Source: docs/core/tools/index.md
Product: dotnet-core
GitHub Login: @mairaw
Microsoft Alias: mairaw

This line is only one of many in the same form. It seems like every nuget package results in an error.

If I had am running this once in the CI Server
nuget sources add nuget.org

it will from now on succeed restoring packages.

The conclusion is that dotnet.exe not necessarily is aware of nuget sources but can be assisted by the older nuget command to learn from where to fetch packages (it does not even know about nuget.org).

Sounds like your CI server isn't configured for the nuget package source. You can create a nuget config file and deploy it with your app to the CI server. This would have the definition for the nuget server in it. that should solve your problem.
If it doesn't please follow up! I'll close this issue. Thanks!


Tag releases on docker hub

Hello, first of all, thanks for this great resource.
I'm wondering if it would be possible to also tag individual releases on Docker Hub? It would help me with some CI integration.

Hi @stone-z, thanks for using Prowler.
I'm not doing releases very well, but I should, I know. That's why pulling latest is your best choice so far.

Is this something I can help with? If you add a Dockerfile I'd be happy to set up a Github action or job for your preferred CI

I went ahead and added something for this in https://github.com/toniblyx/prowler/pull/480

Hi @stone-z, that's is already done since long, an image is built every time there is a commit to master and it is done by Docker Hub. I thought you were asking for versions itself each time there is a build. I you go here https://hub.docker.com/r/toniblyx/prowler/builds you can see that it is built often based on this Dockerfile here https://github.com/toniblyx/prowler/blob/master/util/Dockerfile. Is that what you mean?

I found the Dockerfile, I was just hoping to be able to pull a specific version of prowler instead of latest.
Like
docker pull toniblyx/prowler:2.0

Hi @toniblyx,
In order to be able to keep stable a stage in a pipeline, it would be very useful to have a fixed version when pulling from dockerhub.
This way we can test a version in a development pipeline and thus to be sure that an update won't  break anything.

you are right @lobobinario, I have to do better job when it comes to manage releases. With the given pace of improvements and additions it seems to be a good idea to cut a release weekly of bi-weekly instead of just merging all in to master without versions. I'm going to start this Friday with version 2.2, how does it sound?

it seems to be a good idea to cut a release weekly of bi-weekly

For me, the frequency isn't so much a problem, we just have to be able to use the exact version in a CI pipeline. Thank you for supporting this!

you are right @lobobinario, I have to do better job when it comes to manage releases. With the given pace of improvements and additions it seems to be a good idea to cut a release weekly of bi-weekly instead of just merging all in to master without versions. I'm going to start this Friday with version 2.2, how does it sound?

Sounds good!!

This is achieved so far, it will be a new image tag for next versions.


Make R seed optional (used in MCD computation)

A seed is needed to make robust distances reproducible, yet this could potentially interfere with other calls to RCall from the user.

Addressed by 6d6ac307046adf097b8c525f7f930baa35ba96f4


Make Travis run SwiftLint and pod lint lint

It would be very helpful to let Travis run both swiftlint and pod lib lint and report any problems!

We just need to add this to the Dangerfile. I added the SwiftLint danger plugin:
# Run SwiftLint
swiftlint.lint_files

This is closed by #264


Creating a Secret

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.

Steps to reproduce
According to the documentation I've seen, Set-Secret is supposed to create Secrets in Keeper. However, I cannot get that done thru PowerShell.
Set-Secret -Name "Just A Test" -Secret "P@ssVord" -Vault Keeper_SER_Creds
This returns an error "Set-Secret: Set-Secret can be used only on a single field"
I am probably doing something wrong, so I'm not sure if it is documentation opportunity or a bug or a feature.
Thanks, Burt
Expected behavior
I expect it to create an entry in Keeper.

Actual behavior
Error thrown as shown above.

Error details
Exception             :
    Type    : Microsoft.PowerShell.Commands.WriteErrorException
    Message : Set-Secret can be used only on a single field
    HResult : -2146233087
CategoryInfo          : NotSpecified: (:) [Write-Error], WriteErrorException
FullyQualifiedErrorId : Microsoft.PowerShell.Commands.WriteErrorException,Microsoft.PowerShell.SecretManagement.SetSecretCommand
InvocationInfo        :
    MyCommand        : Set-Secret
    ScriptLineNumber : 1
    OffsetInLine     : 1
    HistoryId        : 1
    Line             : Set-Secret -Name "Just A Test" -Secret "P@ssVord" -Vault Keeper_SER_Creds
    PositionMessage  : At line:1 char:1
                       + Set-Secret -Name "Just A Test" -Secret "P@ssVord" -Vault Keeper_SE …
                       + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    InvocationName   : Set-Secret
    CommandOrigin    : Internal
ScriptStackTrace      : at Set-Secret, C:\Users\E015401\Documents\PowerShell\Modules\SecretManagement.Keeper\16.6.1\SecretManagemen
t.Keeper.Extension\SecretManagement.Keeper.Extension.psm1: line 73
                        at <ScriptBlock>, <No file>: line 19
PipelineIterationInfo :

Environment data
Name                           Value
----                           -----
PSVersion                      7.4.0-preview.5
PSEdition                      Core
GitCommitId                    7.4.0-preview.5
OS                             Microsoft Windows 10.0.19044
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

-AND-

Name                           Value
----                           -----
PSVersion                      7.3.6
PSEdition                      Core
GitCommitId                    7.3.6
OS                             Microsoft Windows 10.0.19044
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Version
Not sure what Crescendo is
Visuals
No response

Thanks @BurtJohnsonfbl from the SecretManagement perspective it looks like you are doing everything correct, the error message you are seeing is coming from the SecretManagement.Keeper module so I suggest opening an issue in that repo--thanks!


should we remove Backtrace.print()?

I think this library should do exactly one thing which is printing backtraces on crash.
If we were to decide to make it also print backtraces, then we need to offer much more rich API that allows you to programmatically get access to the backtraces. For example:

get the stack traces, not just print them
access to return addresses
symbolicated but not demangled

https://github.com/swift-server/swift-backtrace/pull/25

closed via https://github.com/swift-server/swift-backtrace/pull/25


⚠ CIOOS Pacific ERDDAP dataset DFO_MEDS_BUOYS has degraded performance

In ce2b1bd, CIOOS Pacific ERDDAP dataset DFO_MEDS_BUOYS (https://data.cioospacific.ca/erddap/tabledap/DFO_MEDS_BUOYS.htmlTable?STN_ID&time>=now-1week&distinct()) experienced degraded performance:

HTTP code: 200
Response time: 17497 ms

Resolved: CIOOS Pacific ERDDAP dataset DFO_MEDS_BUOYS performance has improved in a1707cd.


Remove title from video transcript CTA

What is it and who's it for?
All users
The title of the work is included in the CTA for transcript downloads. This is unnecessary from a user point of view, and causes issues when the work title is long because we don't currently line wrap.
https://wellcomecollection.org/works/z6skkhxa

Action
Remove title from label

This has been resolved.


Rate limiting options

Different providers have different limits, so might be hard to coordinate. Will also need settings to disable/alter limits for self-hosted options.

Some providers even return HTTP headers that inform the client of the current rate limit remaining and when it would be reset, so it would be possible to automatically throttle requests to those providers (sleep automatically until the next "reset" point).
A call to the OpenAI embeddings API for example returns this:
x-ratelimit-limit-requests: 5000
x-ratelimit-limit-tokens: 5000000
x-ratelimit-remaining-requests: 4999
x-ratelimit-remaining-tokens: 4999990
x-ratelimit-reset-requests: 12ms
x-ratelimit-reset-tokens: 0s

Oooh interesting, that would be way better than trying to wrap some rust rate limiter around every client. Will score through all these clients and see which ones support that besides openai


Prepare for release 3.6.3

Updates core lib to 3.6.2
Updates version and CHANGELOG

Pull Request Test Coverage Report for Build 163

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 160:
0.0%

Covered Lines:
724

Relevant Lines:
724

💛  - Coveralls


Voice Memos App Doesn't Work On Device

It works as expected in the emulator, but on my device, the audio doesn't playback and the recordings never fire the didFinishPlaying action so the progress bars continue growing until they push the play/pause icons off the screen.
i get that these bugs are kind of annoying edge-cases/not relevant to the educational purposes of the examples, so feel free to close this out if you're onto other things 🏄

okay i figured out the issue!
by setting the category of the shared AVAudioSession instance back to playback, everything works as expected.
    stopRecording: { id in
      .fireAndForget {
        dependencies[id]?.recorder.stop()
        try? AVAudioSession.sharedInstance().setCategory(.playback, mode: .default)
        try? AVAudioSession.sharedInstance().setActive(false, options: [])
      }
    }

based on this stackoverflow answer


Add New Asset page

Adds a tutorial poage for New Asset. Update asset is still blocked by https://github.com/vegaprotocol/vega/issues/5699
See vegaprotocol/data-node#110

Additional fields required:
✗ invalid request: proposal_submission.terms.change.new_asset.changes.source.erc20.lifetime_limit (is required), proposal_submission.terms.change.new_asset.changes.source.erc20.withdraw_threshold (is required)

This is kinda blocked by https://github.com/vegaprotocol/specs/issues/1178. However there is a missing field, validationTimestamp. which needs to be populated. It's a can of worms however...


Open files as read-only in Office 2007

Hi,
When I use DokanNetMirror example, I encounter a tricky problem in opening Office files.
I have tested the following cases in Windows 7 64-bit:

Office 2007 + Dokany 1.0.1 + Dokan.NET <IP_ADDRESS> + DokanNetMirror => Read-Only PowerPoint
Office 2016 + Dokany 1.0.1 + Dokan.NET <IP_ADDRESS> + DokanNetMirror => OK
Office 2007 + Dokany 0.8.0 + Dokan.NET <IP_ADDRESS> + DokanNetMirror => Read-Only PowerPoint & Word
Office 2016 + Dokany 0.8.0 + Dokan.NET <IP_ADDRESS> + DokanNetMirror=> OK
Office 2007 + Dokany 1.0.1 + Dokan.NET <IP_ADDRESS> + dokan_mirror=> OK
Office 2007 + Dokany 0.8.0 + Dokan.NET <IP_ADDRESS> + dokan_mirror=> OK

It seems to be some problem in DokanNET or DokanNetMirror.
Does anyone have a idea to solve this problem?
Many thanks.

Hi @willy-wu ,
I don't have office 2007. Could you give the mirror C# debug logs :) ?

During the file open office writes some files temporarily. I can imagine
that this exception may not be handled properly.

Hi @Liryna ,
This is my test procedure:

There is a Office file "PowerPoint.pptx" in the "OfficeFile" folder. (This file is not Read-Only!)
Use DokanNetMirror mount the disk.
Mouse double-click "PowerPoint.pptx" to Open file. It show "[Read-Only]" in window's title bar of PowerPoint.
Close PowerPoint application.

Please view the mirror C# debug logs.
DokanNetMirror-v<IP_ADDRESS>.log.txt
DokanNetMirror-v<IP_ADDRESS>.log.txt
BTW,
If I execute the DokanNetMirror.exe in Command Prompt directly (don't debug in VS2015), it seems to have no any problem.
Is it possible that VS2015 interfere with Dokan.NET operations?
Thanks.

@willy-wu thank you for the logs.
I guess if it shows the file as read-only is because for him the temporary file has not been created as he wanted.
We see in the logs that it creates it, close it and try again to open it with failure.
Probably this is an issue of synchronization since like you say it works without debugging.
Can you compare the logs without debug enable and see what he do more with the temporary file ?


Github action takes too long to fetch swiftlint plugin.

Hi @lukepistrol, I'm using swiftlint 0.2.2. it takes too much time to fetch the artifact in github action.
more than 30 mins and still it's not completing the fetch. i have added the screenshot. could you pls help me on fixing this issue.

in local Xcode it's pulling without this much delay. on CI it takes too long.
we have raised a ticked with GitHub action team as well. will update this thread if I get any insights from them.

I just tested it on one of my projects and I cannot replicate this.

Are you using a GitHub hosted runner?
Which runner do you use? (e.g. macos-12)
What does your build command look like?

Hmm.. interesting. My configuration is pretty much the same:
set -o pipefail && xcodebuild  \
    -scheme "$SCHEME" \
    -destination "$PLATFORM" \
    -skipPackagePluginValidation \
    clean build | xcpretty


Fix safe area in examples

Summary
Fixes incorrect safe area for iOS examples.
Aditionally, updates "@types/react" as it was on older version which resulted in type errors. iOS pod for react-native-pager-view was bumped to latest version.
Test Plan
Check if modified examples are working correctly on Android and iOS
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility

OS
Implemented

iOS
✅❌

Android
✅❌

Checklist

[X] I have tested this on a device and a simulator
[ ] I added the documentation in README.md
[X] I updated the typed files (TS and Flow)

@okwasniewski I applied your suggestions.
@krozniata I checked fabric examples and it seems that they are nearly identical, so I applied these fixes to them as well.


Dial multiple addr

Hi,
I have a question, how to dial multiple addr, yes, I can do it by my code, I just want to know if amqp support it

Have you looked at the code in this project yourself?

@lukebakken  Yes, as we konw, Dial(url string) , it can not be Dial(url []string{})

Great, you answered your own question. This project would welcome a PR that implements the feature if you would like to submit one with tests.

A PR that adds support for multiple URIs/endpoints would be welcome. It is reasonably easy to do that without special support in this client.

Hi @michaelklishin, does the client now supports for multiple uris/endpoints?


changed style for dropdown links

I don't know if this will break other things but i think looks better with a gap between the items.

Could you add a comment here with some screenshots to show the difference? Thank you!

First is before, second is after

Thanks for this, @GypsyDangerous! 🎉
I'd add some form of background so the buttons don't look that "lost" floating around but thats purely a design choice. I'm happy for other opinions!

@vimkat I agree that a background would look better but im not sure how to do it.

@vimkat I agree that a background would look better but im not sure how to do it.

You could try giving the ul some background and maybe padding.

another picture with a little higher quality

and here is one with window full sized

i made the background more purpleish/pinkish to fit the style of the website

oops

new background

here is another idea for background color, make it the same color as the button.

I really like the second version! 🎉

@vimkat the one where it is the same color as the button?

@shiffman @phucduong86

I like all of these! As long as they meet the WCAG accessibility guidelines I am good to merge!

Hi,
There are a few issues with the dropdown buttons in regard to accessibility:

It can only be activated by hovering, so user using keyboard are not able to access the links within the drop down.
The color contrast in the drop down does not meet minimum requirements for WCAG 2.0.

in regards to the first point, how could we add keyboard accessibility to it? and the second point, what colors should i be checking contrast on, because the background color #9659A7 has a 4.9:1 contrast with the text color #FFFFFF

I just modified the background.  now it looks like this and according to this site the contrast should be good

@phucduong86 what part of this should I change to make it meet the contrast requirements?

@phucduong86 what part of this should I change to make it meet the contrast requirements?

Hi @GypsyDangerous,
The background in the inside button

The element that are only shown when hover/actived are sometimes missed by automated checker.
When I inspected the element I got the color #AB7AB9 that is only 3.37:1 with white text:

For the question about where to check color contrast - most contrast checkers are quite accurate if we give them the correct color value. ColorZilla chrome extension does a good job picking colors usually. Sometimes the colors are altered with filter/opacity/overlay and we kind of have to make the judgement call if it is accurate or not. If it doesn't seem like it has the right value I often take a screenshot and sample the actual color then send them through the contrast checker.
On the keyboard accessibility - you need to make sure (programmatically in Javascript) that:

The main button is focusable
The main button listen to keyboard event
The main button activate/deactivate the expanded state (visually) on keyboard action and also announcing this state to end user (users who are blind for example) via aria properties.

I've implemented similar function for the mobile nav menu if you want a reference.
This is also a very valuable resource on the specific topic:
https://www.w3.org/WAI/tutorials/menus/flyout/
Cheers!

okay I fixed the color issue. I have a solution for the keyboard issue but i dont know how to add to the repo because i can't find where to change the html

never mind i found it and made the changes in #1759

I'll add pictures this afternoon when i get home.

@GypsyDangerous what is the status of this PR?

@gruselhaus I have been working on this on and off lately, I've studied the WCAG standards to try and get a better understanding and I'm trying to find a good color scheme that meets the standards. It has been really difficult to work since I am currently unable to build the website from my fork but it will get a lot easier when I upgrade my computer and get Linux in early January. As for the issue with the buttons not being accessible as mentioned in #1759 I am still stuck on finding a good solution for the problem


CASMINST-5595 - Clarify usage of --no-cache flag when resuming CSM services install

Description
The order in which the yapl command line arguments must be specified is important and not entirely clear in the documentation.
The --console-output is a global option which must be specified before the execute command whereas the --no-cache option is a execute command argument and must be specified after it.
Added a note to clarify the order in which the options must be specified.
Checklist Before Merging

[X] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[ ] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[X] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.3


Page slows to a halt with 10,000 ol-markers created

I am currently evaluating the usage of angular-openlayers directive for our map application project. One requirement is that it must be able to render up to 10000 features on the map without any negative impact on user experience.
I have tested using ol-marker directive with ng-repeat of a markers array containing 10000 marker objects. The result is the page instantly freezes and unresponsive. I have also tested using raw openlayers api to create the same markers and the performance is much better.
The attached txt files are actually html test pages modified from 061-markers-add-remove-example.html; one using ng-repeat of ol-markers, the other using basic OSM layer and raw ol3 api to create the features.
TestMarkersRepeat.txt
TestMarkersWebglMapAngularOnly.txt

@fisyher Hi, do you have that set up on some branch/GitHub repo so that I can get it and test it myself? Did you already figure out where the possible bottleneck could be?

Hi,
I had a similar problem, than found that in ol-marker is code:
map.on('pointerdown', handleDrag);
map.on('pointerup', handleDrag);
map.on('pointerdrag', handleDrag);
if I comment it everything works good and fast - I could have done it because my app has no use of dragging.
I guess (just guess - didn't verify it at all) that there is an event added to map with each marker, so with 10 000 markers map has 10 000 similar events to serve, which slows it down seriously.
Hope it helps.

@2PR sure, maybe we could selectively enable drag&drop support only.

@2PR @fisyher Could you maybe take a look at the awesome PR #293, @NiclasLindgren just contributed? I think this could be related and potentially fix this issue here.
I'm going to merge that branch in very soon, would just be cool if some of you could also give it a look as you were having problems related to this.

We just merged in PR #293 which should solve this issue. I'm closing this bug. In case it's still happening, feel free to reopen the issue.

Seems like problem still persist. I have 500 markers in dataset and this simple code in view:
<openlayers ol-center="mapcenter" width="100%" height="600px">
  <ol-marker ng-repeat="pkt in punkty" ol-marker-properties="pkt"></ol-marker>
</openlayers>

and controller:
angular.module('app')
    .controller('SimpleController', function ($scope, $filter, Markers) {
        $scope.markers = [];
        Markers.get().then(function (result) {
            angular.forEach(result, function (val, key) {
                $scope.markers[key] = {
                    lat: parseFloat(val.LAT),
                    lon: parseFloat(val.LNG),
                    label: {
                        message: val.MSG
                        show: false,
                        showOnMouseClick: true,
                        showOnMouseOver: false,
                        keepOneOverlayVisible: false
                    }
                };
            });
        }, function (err) {
            console.log(err);
        });

        $scope.mapcenter = {
            lat: 52.069167,
            lon: 19.480556,
            zoom: 6.5
        };
})

Loading this map freezes app after first click/drag
I made some tests and commenting out this code in olMarker directive makes the map usable, which of course leads to make markers never show its labels:
if (evt.type === 'pointerdown') {
[...]
var feature = map.forEachFeatureAtPixel(evt.pixel, function(feature) {
return feature;
});
// Get associated marker properties
pickProperties = (feature ? feature.get('marker') : null);
[...]
scope.$watch('properties', function (properties) {
[...]
properties.handleInteraction = function (evt) {
[...]
var feature = map.forEachFeatureAtPixel(pixel, function (feature) {
return feature;
});
Seems like every click/drag event the  map.forEachFeatureAtPixel is called 500 times which probably causes map to freeze.

I am seeing the same sort of issues with ~250 markers on the map generated in a similar way using ng-repeat at the moment, it seems to be related to clicking/dragging as it's quite responsive until you interact with it.


Fix wrong search input width calculation when empty selection

This pull request includes a

[X] Bug fix
[ ] New feature
[ ] Translation

This PR fix #5517

This makes sense as a change (based on the details in #5517). It would be solid if we could also get a test which covers this (these might be a good starting example), just so we don't run into this again in the future.


bump system agent, fix revive errors, update golangci-lint config file

Issue https://github.com/rancher/rancher/issues/46219, https://github.com/rancher/rancher/issues/46220
Summary
Several Kubernetes dependencies are outdated and contain CVEs. These dependencies are indirect and are used mostly by the embedded system agent. In order to use the most recent dependency versions, the system agent dependency should also be updated, as we do not know if there are any regressions or changes in behavior when combining an older version of the system agent with newer dependency versions.
Occurred changes and/or fixed issues
Bumped the system agent and the related k8s dependencies. We now use 1.27.x for all Kubernetes dependencies, which is inline with the most recent system agent version 0.3.6.
Depending on when 0.3.7 comes out, we could instead bump to that version. This PR is scheduled for 2.9.1.
Recent versions of the system agent have introduced a concept of 'interlock files', which were designed to improve consistency when executing plans. Currently, there are no Windows specific plans which utilize these files, so the applyinator.NewApplyinator function signature intentionally omits that parameter.
Additionally, the CI has been updated to accommodate the extra time required to lint the updated dependencies.
Technical notes summary
Areas or cases that should be tested
When a new version of wins is cut and vendored into Rancher, we should test all basic provisioning use cases.
Areas which could experience regressions
Screenshot/Video

We will be releasing system-agent v0.3.7 shortly as part of 2.9.0 release so let's bump to it once it's available.

v0.3.7 has been released and I'm currently testing the use of that version in wins. I'll update the PR once I can confirm that there are no issues with v0.3.7 on windows.

I've tested the system agent v0.3.7 using a custom build of wins and confirmed that I was able to provision a windows cluster, deploy workloads, and upgrade that windows cluster successfully.
However, the latest version of the system agent has changed the k8splan.Watch function signature to include a boolean for strict tls verification. The initial implementation of that feature has not properly passed the required environment variables to windows nodes, which means there is no way to know what the proper value is for the given cluster. For this reason, I have set the value to false, so that there is no change in behavior for existing clusters.
While testing the new version of the system agent, and determining why the environment variable was not being passed, I stumbled on this old windows issue https://github.com/rancher/windows/issues/181. This issue was not properly tested, and does not work as intended. This is likely one of the reasons that the strict tls verification environment variable is not being passed to wins, and why the wins binary does not upgrade alongside Rancher versions.


Please update the API documentation regarding custom docker image

Based on documents here: https://docs.microsoft.com/en-us/azure/databricks/clusters/custom-containers#step-3-launch-your-cluster, the cluster creation API now supports docker_image tag to use custom docker image. But the REST API documentation is not updated.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5e5705b9-3ec2-f680-3238-acc4ab646b52
Version Independent ID: 5d6b6e4c-efa9-bc3d-e76e-8f104f3e887c
Content: Clusters API - Azure Databricks
Content Source: databricks/dev-tools/api/latest/clusters.md
Service: azure-databricks
GitHub Login: @mamccrea
Microsoft Alias: mamccrea

@memoryz Thanks for the feedback! We are currently investigating and will update you shortly.

Thanks for your feedback, @memoryz. We've updated this article to include docker_image.
#please-close


Improving performances with screenrecorder native binary

Android natively supports screen recording using a built-in command line utility called "screenrecord"

Shouldn't it be easier and improve performances to use it on devices supporting it? I believe that every lollipop installation comes with this built-in, but I'm not 100% sure.
If you notice in Android studio there is a "take video" or "take screenshot" button, in the logcat menu, that's how it works

I don't think that would improve performance, and it would increase a lot of code complexity since output would have to be parsed, etc.


Help: integrate open RMF with my robot

Hi Yadunund. Sorry if this isn't the right place to ask for the support I need (the support guidelines link - https://github.com/open-rmf/rmf/wiki/Support-guidelines -  is redirecting to root repository of Open RMF).
I'm trying to integrate open RMF with a robot that works with ROS1 (I'm also using ros1_bridge), but when I try to run my fleet adapter, the message "ModuleNotFoundError: No module named rmf_fleet_adapter_python.planner" is shown.
I tried reinstalling Open RMF, and no error occurs when I do that (I'm using the branch called "foxy"). Is there something that I'm missing?
Operating system and version:
Ubuntu 20.04
OpenRMF installation type:
Binaries
OpenRMF version or commit hash
First version of working in ROS Foxy
ROS distribution and version:
ROS Foxy
ROS installation type:
Via debian packages

Hi @gregoryyts
Apologies for the link not working. It should redirect you to our discussions board  where we help answer questions that users may have. You might want to look through some of the posts there are relevant ones for integrating ROS 1 robots with RMF.
To clarify more on your error,

Could you share the output of dpkg -l | grep ros-foxy-rmf* ?

The planner module in the bindings was only added in this commit which may not have been backported to the foxy version of the rmf_fleet_adapter_python` package. Hence, you are unable to load it.
We're no longer actively supporting the foxy version of RMF so you have a couple of options here:

Switch to the galactic version.
Open a PR to cherry-pick/backport that commit into the foxy version. We may also seek your help in blooming a patch
Build RMF from source. This option will ensure you're always using the latest improvements in the code

Sure, here's the output:
ii  ros-foxy-rmf-battery                                0.1.1-1focal.20210910.165827          amd64        Package for modelling battery life of robots
ii  ros-foxy-rmf-building-map-msgs                      1.2.0-1focal.20211112.184900          amd64        Messages used to send building maps
ii  ros-foxy-rmf-building-map-tools                     1.4.0-1focal.20211112.192127          amd64        RMF Building map tools
ii  ros-foxy-rmf-building-sim-common                    1.3.0-1focal.20211112.194500          amd64        Common utility functions for Gazebo and ignition building plugins
ii  ros-foxy-rmf-building-sim-gazebo-plugins            1.3.0-1focal.20211119.131931          amd64        Gazebo plugins so that buildings generated by rmf_building_map_tools can talk to the ROS 2-based systems in the rmf_traffic_ros2 package.
ii  ros-foxy-rmf-cmake-uncrustify                       1.2.0-1focal.20210906.142703          amd64        ament_cmake_uncrustify with support for parsing a config file.
ii  ros-foxy-rmf-demos                                  1.3.1-1focal.20211119.123434          amd64        Common launch files for RMF demos
ii  ros-foxy-rmf-demos-assets                           1.3.1-1focal.20210922.171136          amd64        Models and other media used for RMF demos
ii  ros-foxy-rmf-demos-dashboard-resources              1.3.1-1focal.20210922.171137          amd64        Resource pack for RMF dashboard
ii  ros-foxy-rmf-demos-gz                               1.3.1-1focal.20211119.132602          amd64        Launch files for RMF demos using the Gazebo simulator
ii  ros-foxy-rmf-demos-maps                             1.3.1-1focal.20211119.122834          amd64        A package containing demo maps for rmf
ii  ros-foxy-rmf-demos-panel                            1.3.1-1focal.20211112.190213          amd64        Web based RMF Demo Panel
ii  ros-foxy-rmf-demos-tasks                            1.3.1-1focal.20211112.191007          amd64        A package containing scripts for demos
ii  ros-foxy-rmf-dispenser-msgs                         1.4.0-1focal.20211112.184914          amd64        A package containing messages used to interface to dispenser workcells
ii  ros-foxy-rmf-door-msgs                              1.4.0-1focal.20211112.183125          amd64        Messages used to interface to doors
ii  ros-foxy-rmf-fleet-adapter                          1.4.0-1focal.20211112.200713          amd64        Fleet Adapter package for RMF fleets.
ii  ros-foxy-rmf-fleet-msgs                             1.4.0-1focal.20211112.183506          amd64        A package containing messages used to interface to fleet managers
ii  ros-foxy-rmf-ingestor-msgs                          1.4.0-1focal.20211112.185310          amd64        A package containing messages used to interface to ingestor workcells
ii  ros-foxy-rmf-lift-msgs                              1.4.0-1focal.20211112.183037          amd64        Messages used to interface to lifts.
ii  ros-foxy-rmf-robot-sim-common                       1.3.0-1focal.20211112.201251          amd64        Common utility functions for Gazebo and ignition RMF plugins
ii  ros-foxy-rmf-robot-sim-gazebo-plugins               1.3.0-1focal.20211119.131741          amd64        ROS 2 Gazebo plugins for TeleportIngestors, TeleportDispensers and Readonly Objects
ii  ros-foxy-rmf-task                                   1.0.0-1focal.20210913.061628          amd64        Package for managing tasks in the Robotics Middleware Framework
ii  ros-foxy-rmf-task-msgs                              1.4.0-1focal.20211112.185314          amd64        A package containing messages used to specify tasks
ii  ros-foxy-rmf-task-ros2                              1.4.0-1focal.20211112.195706          amd64        A package managing the dispatching of tasks in RMF system.
ii  ros-foxy-rmf-traffic                                1.4.0-1focal.20210910.053721          amd64        Package for managing traffic in the Robotics Middleware Framework
ii  ros-foxy-rmf-traffic-msgs                           1.4.0-1focal.20211112.184921          amd64        A package containing messages used by the RMF traffic management system.
ii  ros-foxy-rmf-traffic-ros2                           1.4.0-1focal.20211112.194546          amd64        A package containing messages used by the RMF traffic management system.
ii  ros-foxy-rmf-utils                                  1.3.0-1focal.20210909.172550          amd64        Simple C++ programming utilities used by Robotics Middleware Framework packages
ii  ros-foxy-rmf-visualization                          1.2.1-1focal.20211112.213416          amd64        Package containing a single launch file to bringup various visualizations
ii  ros-foxy-rmf-visualization-building-systems         1.2.1-1focal.20211112.185707          amd64        A visualizer for doors and lifts
ii  ros-foxy-rmf-visualization-fleet-states             1.2.1-1focal.20211112.192300          amd64        Fleet state visualizer
ii  ros-foxy-rmf-visualization-msgs                     1.2.0-1focal.20211112.183033          amd64        A package containing messages used for visualizations
ii  ros-foxy-rmf-visualization-rviz2-plugins            1.2.1-1focal.20211112.213018          amd64        A package containing RViz2 plugins for RMF
ii  ros-foxy-rmf-visualization-schedule                 1.2.1-1focal.20211112.195605          amd64        A visualizer for trajectories in rmf schedule
ii  ros-foxy-rmw                                        1.0.3-1focal.20211112.180952          amd64        Contains the ROS middleware API.
ii  ros-foxy-rmw-dds-common                             1.0.3-1focal.20211112.182824          amd64        Define a common interface between DDS implementations of ROS middleware.
ii  ros-foxy-rmw-fastrtps-cpp                           1.2.6-1focal.20211112.185808          amd64        Implement the ROS middleware interface using eProsima FastRTPS static code generation in C++.
ii  ros-foxy-rmw-fastrtps-shared-cpp                    1.2.6-1focal.20211112.183201          amd64        Code shared on static and dynamic type support of rmw_fastrtps_cpp.
ii  ros-foxy-rmw-implementation                         1.0.2-1focal.20211112.190156          amd64        The decision which ROS middleware implementation should be used for C++.
ii  ros-foxy-rmw-implementation-cmake                   1.0.3-1focal.20210901.034658          amd64        CMake functions which can discover and enumerate available implementations.
Apparently, my version of RMF is not compatible with the adapter. I wil change to ROS Galactic and build RMF from source to see what happens. Thank you @Yadunund .

@gregoryyts you could also try the Galactic binaries instead. But keep in mind that if you do decide to build from source, make sure to remove all rmf related binaries due to a workspace issue that has been documented https://github.com/open-rmf/rmf/issues/99
You can run sudo apt remove ros-galactic-rmf-*
(or replace the galactic above with foxy)


"Bertea", "Lutu Roșu" are listed in the drop-down menu

Description:
When user writes "Bertea" and "Lutu Roșu" the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law
Precondition:
The website is up an running.

Step 1
Write in the search bar "Bertea"
Expected results
The location appears in the drop-down menu as "Sat Bertea, PRAHOVA (Bertea)"