Pull request for India GLD

Hi Mario and team,
Here is my first attempt to make a pull request in GitHub. These are all the GLD code files for IND except 1987 (which I am still having trouble with) Please let me know if I am doing it correctly. :)

Hi @giofsantos11 , thanks for this!
I think, in terms of bringing in your work onto the platform, this is perfect and it is great to see all your Stata wizardry!
I have a few points I wanted to raise, that I think need to be tackled, but that can be done before or after merging. Namely:

Naming of the folder structure

It seems the GLD codes are stored under the I2D2 folder, not the GLD. You just need to reshuffle in your own directory that GitHub Desktop is mapping and it should do these changes automatically.

Use of the new preamble

You used, I believe, the 1993 and 1999 GLD codes I had done as templates. Since then we published the new template for GLD, that contains a few new things, in particular the section to list the versions of national and international classifications (industry, occupation, educ). Please add the new preamble and check whether there are other things in the new template that should change.

Tracking of industry and occupation classification at international level

The new preamble, as discussed above, shall contain the metadata on the underlying classification version (e.g., NIC 2008). Wherever possible, use the information of these codes to classify the international codes (e.g., industrycat_isic) to the degree possible. For example, NIC 2008 (link to document here, see screenshot from page 10 below), is a 5 digit code that is equivalent to ISIC revision 4 to the first four digits.

Thus you may code industrycat_isic as gen industrycat_isic = substr(nic_2008,1,4) taking into account potential errors (should be uncommon) and the correct zero padding if necessary.
The occupation NOC 2004 is equivalent at the two digit level to ISCO-88 (except that ISCO has code 0 for armed forces and NOC has codes X for "workers not classfied").
To the degree that is possible, we should incorporate international information.

Hi @giofsantos11 , thanks for this!
I think, in terms of bringing in your work onto the platform, this is perfect and it is great to see all your Stata wizardry!
I have a few points I wanted to raise, that I think need to be tackled, but that can be done before or after merging. Namely:

Naming of the folder structure

It seems the GLD codes are stored under the I2D2 folder, not the GLD. You just need to reshuffle in your own directory that GitHub Desktop is mapping and it should do these changes automatically.

Use of the new preamble

You used, I believe, the 1993 and 1999 GLD codes I had done as templates. Since then we published the new template for GLD, that contains a few new things, in particular the section to list the versions of national and international classifications (industry, occupation, educ). Please add the new preamble and check whether there are other things in the new template that should change.

Tracking of industry and occupation classification at international level

The new preamble, as discussed above, shall contain the metadata on the underlying classification version (e.g., NIC 2008). Wherever possible, use the information of these codes to classify the international codes (e.g., industrycat_isic) to the degree possible. For example, NIC 2008 (link to document here, see screenshot from page 10 below), is a 5 digit code that is equivalent to ISIC revision 4 to the first four digits.

Thus you may code industrycat_isic as gen industrycat_isic = substr(nic_2008,1,4) taking into account potential errors (should be uncommon) and the correct zero padding if necessary.
The occupation NOC 2004 is equivalent at the two digit level to ISCO-88 (except that ISCO has code 0 for armed forces and NOC has codes X for "workers not classfied").
To the degree that is possible, we should incorporate international information.

Thanks Mario. Fixed the mix up in the folder location. Will update the do files to include the new preamble and variables harmonizing with international classification systems

Mario's comments make sense to me and good to get an idea of what to look out for in GLD!


GelfHandler "Message is invalid: additional key contains invalid characters"

Monolog version 1|2|3?
{
    "name": "monolog/monolog",
    "version": "3.8.0",
    "source": {
        "type": "git",
        "url": "https://github.com/Seldaek/monolog.git",
        "reference": "32e515fdc02cdafbe4593e30a9350d486b125b67"
    }
}

With the basic log call
$logger->info('Hello World', ['invalid context' => 'test']);

[2024-11-21T12:21:39.764122+00:00] Cron.ERROR: Uncaught Exception RuntimeException: "Message is invalid: additional key 'ctxt_invalid context' contains invalid characters" at /Users/ybelenko/Sites/bdo_pay/vendor/graylog2/gelf-php/src/Gelf/Publisher.php line 58 {"exception":"[object] (RuntimeException(code: 0): Message is invalid: additional key 'ctxt_invalid context' contains invalid characters at /Users/ybelenko/Sites/bdo_pay/vendor/graylog2/gelf-php/src/Gelf/Publisher.php:58)"} []

I guess Monolog should prepare $context and $extra for Publisher and strip spaces.
Valdiation part in vendor/graylog2/gelf-php/src/Gelf/MessageValidator.php:
foreach ($message->getAllAdditionals() as $key => $value) {
    if (!preg_match('#^[\w\.\-]*$#', $key)) {
        $reason = sprintf(
            "additional key '%s' contains invalid characters",
            $key
        );

        return false;
    }
}

Thanks, you're almost nailed it. But now I got TypeError

Thanks because I use indexed array as context. Could you fix it with:
---            $key = (string) preg_replace('#[^\w\.\-]#', '-', $key);
+++            $key = (string) preg_replace('#[^\w\.\-]#', '-', (string) $key);


Updated node ids

When downloadings versions of the same map on different days, the set of nodes changes since new nodes may appear while others are removed. However, there is also a set of nodes which change their ids while having the same location.
I plot 2 sets of distinct nodes on a map and they appear to be representing the same streets, however, no node is common for the two lists. I assume this is the case when a node is edited by being removed and created again with a new id.
When a new map is downloaded, it would be helpful to have a list of updated nodes in form of a mapping from the old id to the new id, as well as a list of added/deleted nodes.
As for a better illustration of my issue:
There are 2 road networks of Amsterdam, from 1st of January 2020 and from 1st  of March 2020.
I compute the set of distinct nodes between the two and I plot them, resulting in the following almost identical images:

The road networks and the nodes that are displayed can be found  in the zip file below.
road_networks.zip

Hi @epureanudiana Please reread the new issue template and fill its sections out completely. Per the contributing guidelines, incomplete issues are automatically closed.

Hi @epureanudiana Please reread the new issue template and fill its sections out completely. Per the contributing guidelines, incomplete issues are automatically closed.


Tests from the suite disappeared after reloading the workspace

Testing #22081
Configured python tests and ran them successfully (see TEST RESULTS tab with entry at timestamp 1:48:39PM in the screenshot.)
Closed and reopened the workspace after a while and the tests disappeared:

closing in favor of: https://github.com/microsoft/vscode-python/issues/22093


Make transcripts a bit more interactive

Main two features:

timestamps in the transcripts move the embedded video to that timepoint (and not link to the page on youtube)
the paragraph currently talked about in the video is highlighted (if it contains a timestamp)

https://user-images.githubusercontent.com/6169021/119160918-072a4b00-ba59-11eb-96de-6219c2cc248c.mp4
Open to a different background color to make the highlight more visible with the light theme (didn't want to add yet another color 🙂):

Nooo way, this is awesome! 🚀
We should really work up two separate bootstrap themes for light and dark, then we can just use class names like .bg-light that would work in both. I can't see the highlight at all on the light mode one so I think it does need another CSS colour for now sorry.
Seeing as you've made it this far, would it be possible to make the transcripts div quite short but scrollable, then move the scroll alongside the highlight? So that the current text sticks below the video like a subtitle? Then could have a button to expand it out to the full height to be easier to read as prose.

I hadn't cottoned on that you guys were manually adding the YouTube timestamps as you go along. That's insane! Massive kudos transcription team! 🙇🏻

Seeing as you've made it this far, would it be possible to make the transcripts div quite short but scrollable, then move the scroll alongside the highlight? So that the current text sticks below the video like a subtitle? Then could have a button to expand it out to the full height to be easier to read as prose.

Unfortunately, not every paragraph has a time stamp at the moment, so I don't think this will work. We should maybe make an issue to optimize the transcripts for that and then add this feature.

I added a more transparent version of bg-success to also nf-core theme it a bit 🙂

The padding is quite tight...

Great! Could we not do it as-is and just scroll as we highlight? As long as the height is long enough that you can read ahead a fair few paragraphs I think it should be fine? Just worried that it will be tricky to follow along as it is currently as you might have to be scrolled miles away from the video to see the current text..

Now with automatic scrolling text, @ewels 📜


how to implement python-samplerate for live microphone

I want to convert sample rate of live microphone from pyaudio at 44100hz to 16000hz and use it with pocketsphinx can anyone please help to convert samplerate of live recording chunk by chunk with python-samplerate.
Thank you

There is an example with live resampling of synthetic data using the callback API here. The code would be quite similar using audio input and sounddevice.InputStream. If you already get the live audio with pyaudio, you could use the full API instead and call the process method repeatedly.

when i am trying to do it as you said using full api it says cannot convert from string to float it is expecting input to be numpy data but my audio is pyaudio which is in pyaudio.pyInt16 format can you please help i want to resample audio for pocketsphinx and i am new to python. so please help me in a little detail way.
Thank you.

You need to convert the input data to a NumPy array first. This can be easily done with np.fromstring, see here for an example.

sorry for troubling you again I tried using np.fromstring but it is not working It doesn't detect anything. Can you please make a program to record audio using pyaudio in pyInt16 format and convert it from 44100hz to 16000hz using python-samplerate so that I can use it in my college project using pocketsphinx. Please help me solve this issue. Thank you.

The code below should work as expected.
from __future__ import print_function, division
import numpy as np
import pyaudio
import samplerate as sr

input_rate = 44100
target_rate = 16000
chunk = 1024

audio = pyaudio.PyAudio()
stream = audio.open(format=pyaudio.paInt16, channels=1,
                    rate=input_rate, input=True,
                    frames_per_buffer=chunk)

resampler = sr.Resampler()
ratio = target_rate / input_rate

for i in range(5):
    raw_data = stream.read(chunk)
    data = np.fromstring(raw_data, dtype=np.int16)
    resampled_data = resampler.process(data, ratio)
    print('{} -> {}'.format(len(data), len(resampled_data)))
    # Do something with resampled_data

stream.stop_stream()
stream.close()
audio.terminate()

Thank you very much for the code i will try it and will tell you if it works for me. Thanks again.

hey, I tried your code but when I gave print(resampled_data) it prints an array of 0. without any value even if i am continuously speaking the value doesn't change from 0. and I dont get a text output from pocketsphinx also please solve this for me. Thank you.

If resampled_data is all zeros, then likely also data is. This would hint at a problem with the input recorded by pyaudio. Please check. The above code works as expected in Python 2.7 and 3.5 on MacOS 10.12.

On 21.04.2017 at 18:22, Y V Bharani sai<EMAIL_ADDRESS>wrote:
hey, I tried your code but when I gave print(resampled_data) it prints an array of 0. without any value even if i am continuously speaking the value doesn't change from 0. and I dont get a text output from pocketsphinx also please solve this for me. Thank you.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

The above script seems to return a numpy array of floats although the input np array contained int16.
It is not a bug, but something to keep in mind.


Refactor cluster with unsafe.SwapPointers()

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
Increment add/remove connections in local balancers while Discovery
What is the new behavior?
rebuild internal balancers on rediscrovery or ban/unban connection
much simplifer logic

Codecov Report

Merging #227 (aebf878) into master (b094d89) will decrease coverage by 19.03%.
The diff coverage is 57.47%.

@@             Coverage Diff             @@
##           master     #227       +/-   ##
===========================================
- Coverage   57.05%   38.01%   -19.04%
===========================================
  Files         141      142        +1
  Lines       15486    15423       -63
===========================================
- Hits         8835     5863     -2972
- Misses       6099     9151     +3052
+ Partials      552      409      -143

Flag
Coverage Δ

1.14.x
?

1.15.x
27.58% <55.84%> (+0.71%)
:arrow_up:

1.16.x
27.58% <55.84%> (+0.71%)
:arrow_up:

1.17.x
38.01% <57.47%> (-19.04%)
:arrow_down:

1.18.x
27.58% <55.84%> (+0.71%)
:arrow_up:

connection
16.34% <32.00%> (+0.33%)
:arrow_up:

discovery
?

e2e
19.88% <32.00%> (-27.33%)
:arrow_down:

integration
19.88% <32.00%> (-27.33%)
:arrow_down:

macOS-latest
?

ratelimiter
18.01% <30.37%> (+0.32%)
:arrow_up:

scripting
?

table
?

ubuntu-latest
38.01% <57.47%> (-19.04%)
:arrow_down:

unit
27.58% <55.84%> (+0.71%)
:arrow_up:

windows-latest
?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

internal/balancer/ctxbalancer/context.go
100.00% <ø> (ø)

internal/conn/conn.go
62.98% <0.00%> (-20.00%)
:arrow_down:

internal/conn/pool.go
41.96% <0.00%> (-44.64%)
:arrow_down:

log/driver.go
37.80% <0.00%> (-18.92%)
:arrow_down:

trace/driver.go
0.00% <ø> (ø)

trace/driver_gtrace.go
35.46% <5.88%> (-16.29%)
:arrow_down:

internal/table/session.go
43.07% <43.75%> (-32.80%)
:arrow_down:

internal/cluster/cluster.go
55.64% <45.58%> (-21.88%)
:arrow_down:

internal/balancer/balancer.go
50.00% <50.00%> (ø)

internal/discovery/config/config.go
92.45% <60.00%> (-5.59%)
:arrow_down:

... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b094d89...aebf878. Read the comment docs.


Allow passing in cr/cl bounds and other settings

Fix execution on CPU and GPU. Fix model loading.

Thank you very much for the PR. I am busy on other stuff now and will check the code after Dec 9.

 I cant catch the device_ids, and I only have the single gpu, I don't know how to change the code. Could you please tell me to solve it? thank you!

Could you please show the command you used? Have you set the "-i" argument? It seems that you did not set the device_ids since your device_ids was None. If you only have one single GPU, you can use "-i 0" to set the device_ids. By the way, maybe we should use issue rather than PR to discuss questions.


interactive bokeh legend with datashader

Is there any plan to make the click-to-mute feature of bokeh legends available for datashader images, or at least for overlays of different datashader images?

That's definitely an interesting feature request, I'm not actually sure if images can be given a legend entry atm. As an alternative I made a similar proposal elsewhere, suggesting to add a toggle button instead: https://github.com/ioam/holoviews/issues/1114.

Seems like we could have such a legend for categorical plots, turning each category on or off when mapping from the stack of aggregates into the final image.  I'd find that really useful, but it would require some custom coding at the HoloViews level to make it hook up to the Bokeh machinery for enabling line plots, since it needs to work in a completely different way.

If you get a hankering to dive into how Bokeh does it for the plots where it controls what's visible, and can see how to make that mechanism visible for when another library controls what's visible, I'd love to see the results!  But this is something that crosses all three projects (Bokeh, HoloViews, and Datashader), so it's a bit tricky as a first task to attempt.  @philippjfr could definitely do it, but he's got a lot on his plate.

I'm just exploring Bokeh, HoloViews and Datashader, but coming from Plotly where mute-on-click legends are basically the default, this feature seems really important to (at least) me.
Is there any news or prototypical 'hacks' to get this to work?

If you're comparing Plotly with Bokeh or HoloViews+Bokeh, they should all be the same in that respect -- I believe they can all happily create mute-on-click legends by default.
Datashader works entirely differently from those JavaScript-based tools, so any solution involving Bokeh+Datashader or Plotly+Datashader would need to a separate mechanism from what Bokeh and Plotly natively do, emulating the mute-on-click functionality but with a very datashader-specific mechanism.  So regardless of what interactive front end you use , it will take some work to make it work with Datashader. It's work we basically know how to do, but it's not on our immediate priority list, so I wouldn't expect it to appear imminently.  Meanwhile, any data file small enough for Plotly should already work fine with mute-on-click legends with Bokeh or with HoloViews+Bokeh.

Hi, I wanted to ask if there has been any progress or recent suggestions to make interactive legends for holoviews and datashader. Since, I would find this feature incredibly useful for categorical variables as you were saying.
Thanks so much for your time.

Alas, the status is the same as 28 days ago; this is still a clearly useful feature, but it is not high on the priority list.  There's definitely no way we could get to it in November or December, unless it turns out to be a prerequisite for something we already need to do; there's a lot in the queue before it!

Following on from Jim's comment I am assigning this issue to the 2.0 milestone. Hope we could address it sooner but I'm not particularly optimistic.

Curious if there is progress on this. I am looking for the same capability.
I could see some version of this working by using an Image per category internally and letting the plotting library manage the visibility of the various images functioning as layers.


Wrong char pointer data?

C++ here. This is how my code looks like:
std::vector<uint8_t> v;
v.push_back(90);

char *data = (char *) v.data();
ws.send(data, uWS::BINARY);

The message I receive: (client coded in NodeJS, output in hex):
<Buffer 5a 1b b1 08 a9 7f>

I think it should be:
<Buffer 5a>

What's 1b b1 08 a9 7f? How I can send the message right way as expected?

char *data = "a";

It'll show <Buffer 61>

I think it would be easier if we add std::vector<uint8_t> or uint8_t pointer support to the send function.

Solution: http://stackoverflow.com/questions/18410234/how-does-one-represent-the-empty-char

Again, this is not a bug but rather you not understanding C fundamentals. Don't open bug reports regarding generic C fundamentals because they do not belong here.


STENCIL-2455: Prevents carousel images from being cut off on large sc…

…reens.
JIRA Ticket
https://jira.bigcommerce.com/browse/STENCIL-2455
What
Switches carousel background-size from "cover" to "100% 100%" which fits the entire image into the slide's viewing area.
Why
Carousel images are currently becoming cut off on the top and bottom at browser widths greater than 1261px.
Caveats
Images may look a bit stretched.

We could increase the height set by the hero carousel?
We could remove "visibility: hidden" on .heroCarousel-image (although, the image wouldn't scale :/)

Screenshots
Before Change:

After Change:

We could add a toggle in the Theme Editor to enable this feature 🍹.  To add the checkbox add a new setting to the schema.json file under Carousel section

I actually had that same thought earlier @mcampa! I forgot to post it as a possible solution. I am comfortable making those code changes if that's what we think is best :)

Added two checkboxes:

@mjschock @junedkazi @mattolson

We are now using CHANGELOG.md. Please add an entry with your change under draft before merging
## Draft
- <here>

## 1.5.1 (2017-02-07)
- ...

Tested on an integration store 💚


Integrations test for forked repos

With https://github.com/PrefectHQ/prefect-dbt/pull/66, the integration tests are failing because the forked repo does not include the secrets defined https://github.com/PrefectHQ/prefect-dbt/blob/main/tests/cloud/test_jobs.py#L335-L347.
We should probably add a pytest skip if missing, or find another way to run the test.

Seems to be fixed now by itself.


Contributor Workflow UX Updates

Overview
This ticket captures requirements for UX changes to the data contribution experience.
Included Changes
Must-have:

~Updated copy, font, logo, color and stylistic changes~ (via #2059 )
My Lists pages - columns updated to: Uploaded, Duplicates, Errors and Status; Status values: processing, pending approval, action required (if contributor is doing confirm reject) OR pending moderation (if OS Hub team is doing it), approved, rejected.

Visual Design
Screen design - WIP

Here's the current list:
If I'm understanding this task correctly, we should end up with these columns: name, description, file name, uploaded, duplicates, errors, and status

The UI is basically done, but I'm struggling on how the statuses ought to be changed for list items and wondering if this issue is meant to include a migration to get this list of statuses to correspond to the new ones listed above. Here's the current, relevant (I think) bit on the backend: https://github.com/open-apparel-registry/open-apparel-registry/blob/ogr/develop/src/django/api/models.py#L618-L635

I ton't think wee need a migration or a change to the backend. My impressions what that we just needed to sum the more granular statuses together.

Sum them together on the frontend, that is

The sums make sense but there do appear to be new statuses (which seems like a categorical field?) to advertise: "Status values: processing, pending approval, action required (if contributor is doing confirm reject) OR pending moderation (if OS Hub team is doing it), approved, rejected." Not 100% sure how to decide which of these new statuses to choose given the information currently available on the list object

You are right. I got contused thinking about the count columns, not the status column.
I think we have the information we need

Pending approval: the list status == PENDING
Rejected: the list status == REJECTED
Processing: If the list status is APPROVED and any of the UPLOADED, PARSED, or GEOCODED counts are  > 0
Action Required: If not processing and match_resposibility == contributor
Pending Moderation: If not processing and match_resposibility == moderator
Approved: if list status is APPROVED and there are no items in UPLOADED, PARSED, GEOCODED, or POTENTIAL_MATCH


Implement C++ validation for Any WKT.

This avoids the issue for now, but the same problem with dynamic dispatch is going to come up with validating protos in Any fields as already came up with the C++ test harness, specifically that the C++ validation functions must be determined at compile time, not run time.

I was looking and I don't think I documented it, but I never intended for PGV to attempt to inflate an encoded message and validate, too many gotcha's there (whether the descriptor is loaded being the primary issue).

Yeah, for Envoy, we won't be relying on chasing validation over Any fields, Envoy will be doing this  internally, so please feel free to drive this by what makes sense in general.

Cool, I changed the TODO (and it's obsoleted by #25). This should be ready for review.


Options in participant dropdown should be subset when a site is selected

When a site is selected, only participants from that site should be selectable in the partcipant dropdown

This will be on the pull request here.
Here is video confirmation:
https://github.com/Gilead-BioStats/gsmApp/assets/76186904/e6b98487-271a-4456-9bed-fe8f382de9d9


issue

when i clicked on "login with spid"  and it redirect me to spid/login page where there is a list of service providers
when i clicked on one of them following error is occured
Namirial.ID - Incorrect request format.
ErrorCode nr10
Contact the service manager
Please help for the same
Thanks in advance

You can only use an official IdP if your organization has a metadata approved and deployed by AGID. Please refer to the official documentation: https://www.spid.gov.it/come-diventare-fornitore-di-servizi-pubblici-e-privati-con-spid.
If you need a testing environment you can take a look at https://www.spid.gov.it/come-diventare-fornitore-di-servizi-pubblici-e-privati-con-spid. In case you need to request approval for a new service provider you may also look at https://github.com/italia/spid-saml-check.
I suggest to read carefully the SPID technical rules at https://docs.italia.it/italia/spid/spid-regole-tecniche/it/stabile/index.html.

Actually i only need button for login to SPID in my project
when user want login with SPID they can proceed.
that's it

any credentials shoud l i need to add in my config file for integration of SPID login ?
please help for the same

[image: Screenshot from 2021-04-13 13-10-09.png]
in above image creating a link  when click on providers list
but below image has a button not a link , may you please help for the same.
[image: Screenshot from 2021-04-13 13-10-43.png]
On Mon, Apr 12, 2021 at 6:12 PM Davide Porrovecchio <
@.***> wrote:

You can only use an official IdP if your organization has a metadata
approved and deployed by AGID. Please refer to the official documentation:
https://www.spid.gov.it/come-diventare-fornitore-di-servizi-pubblici-e-privati-con-spid
.
If you need a testing environment you can take a look at
https://www.spid.gov.it/come-diventare-fornitore-di-servizi-pubblici-e-privati-con-spid.
In case you need to request approval for a new service provider you may
also look at https://github.com/italia/spid-saml-check.
I suggest to read carefully the SPID technical rules at
https://docs.italia.it/italia/spid/spid-regole-tecniche/it/stabile/index.html
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/italia/spid-laravel/issues/68#issuecomment-817778094,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATSZVBPC2F2EZIA7HOOU5TTTILTCRANCNFSM42ZEZ72A
.

Hi @Asifkrishaweb,
issues are not intended for support requests.
Please refer to the SPID community at https://developersitalia.slack.com/messages/C73R3UQE8.


dsl: support for xml-io-dsl

Fixes #2294
Fixes #2301

@jamesnetherton @ppalaga the PR will certainly fail but a review would be appreciated

Question about the jOOR bits. Can they work in native mode? If not, I suppose we should add a build step to throw an exception during on native builds.

Question about the jOOR bits. Can they work in native mode? If not, I suppose we should add a build step to throw an exception during native builds.

No it won't work so I'll add make the build fail, do we have a build item for that ?

Here's what we did in the management extension:
https://github.com/apache/camel-quarkus/blob/master/extensions-jvm/management/deployment/src/main/java/org/apache/camel/quarkus/component/management/deployment/ManagementProcessor.java#L42-L46

@jamesnetherton should be a little better now

btw, we may have a similar situation for ServiceNow

jOOR DSL being the first JVM-only extension in the core directory, we should double check that our tooling does what we intend:

Extension page shouldn't say native is supported
Do we want the extension to be listed on code.quarkus.io? - We avoided listing JVM extensions so far. code.quarkus.io does not offer any kind of JVM-only markup, IIRC.

@ppalaga @jamesnetherton failures seems unrelated, should we merge and follow up and leftover ? (i.e. camel.quarkus.nativeSince for joor)

@ppalaga @jamesnetherton failures seems unrelated, should we merge and follow up and leftover ? (i.e. camel.quarkus.nativeSince for joor)

Fine with me, I can look to fix up the leftovers later this week.


Add PILOT_ENABLED_SERVICE_APIS to manifest

Istio needs this option to support Gateway API (Ingress v2).
If istio manifest could enable the option by default, serving repo
will add Gateway API support with the manifest in net-istio wihtout
change.
/cc @arturenault @dprotaso @markusthoemmes

/hold

Closing as 1.10 enabled the option by default and istio-latest uses 1.10.1 now.


Curl to llama.cpp server fails to parse json if accessed over the network

Using following config
llamacpp_url = 'http://<IP_ADDRESS>:8123'
require('model').setup({
    chats = {
        zephyr = {
            provider = llamacpp,
            options = {
                url = llamacpp_url
                },
            system = 'You are a helpful assistant',
            create = input_if_selection,
            run = zephyr_fmt.chat
        },
    },
})

Open Mchat buffer and make model produce long enough text:
zephyr
---
{
  options = {
    url = "http://<IP_ADDRESS>:8123"
  }
}
---
> You are a helpful assistant
Tell me something I don't know, produce a very long response. I need it to test something.

======
Certainly! Here's a lengthy response to test your capabilities:

Did you know that the world's largest living organism is actually a fungus, and it covers an area of over 2,000 acres in Oregon's Malheur National Forest? Known as the Armillaria ostoyae, this particular species of fungus has been estimated to be at least 2,400 years old. The fungus spreads through a network of underground mycelia that connects neighboring trees and can grow at a rate of up to three feet per day. In fact, the collective weight of this single organism is estimated to be more than 6,000 tons. This fungus has been dubbed the "Humongous Fungus" and has been a source of fascination for scientists and nature enthusiasts alike. It's also a testament to the incredible complexity and interconnectedness that exists in our natural world, reminding us of the importance of preserving these delicate ecosystems for future generations.
======

Keep talking.

After such prompt model.nvim fails to parse returned json stating the reason it is incomplete. If I call curl directly by hand it produces correct i.e. non-cropped json. However if I replace curl here  https://github.com/gsuuon/model.nvim/blob/main/lua/model/util/curl.lua#L86 with custom script containing
#!/bin/bash
curl "$@"
sleep 1

it succeeds every time.
My suspicion is that neovim's system function calls on_exit prior to calling on_stdout on last part of the curl's output, but I am not so familiar to neovim's lua programming to find out how to test it quickly.

Thanks for the report! Just to clarify, it only happens over network (so running locally always works) and only with long responses? Do you know about how long the response needs to be to hit the issue? Does this happen with any of the other providers?

My pity laptop is unable to run any model locally, but I can try later to run nvim on my ML rig just to be sure. It does happen only with longer responses, e.g. first response in my example finished generating successfully, however response to "Keep talking." does fail repeatedly. I also did not try any other providers since I have no intention of using any cloud solution and have only llama.cpp for local ones.
I also forgot to include my neovim version, updated description.

I'm not able to repro this locally - let me know how it goes when you try neovim on your ML server. Maybe we're just missing a curl argument for that case, if it's cutting off at exactly 4kb.

I can confirm that when llama.cpp server is running locally, issue is not reproducible. I used the same neovim version with whole config copied over to the machine that is capable of running my models.

Also it is not reproducible if machines are on the same physical network, but reproducible if they are talking over the internet so it might be latency related.

Can it potentially be related to the fact that on_stdin is scheduled and potentially can be called after on_exit?
https://github.com/gsuuon/model.nvim/blob/main/lua/model/util/system.lua#L64

Excuse my crudity of trying to debug stuff using util.notify - I have 0 experience with lua and with nvim plugin developement, trying my best here. What I did is just added few traces:
--- a/lua/model/util/sse.lua
+++ b/lua/model/util/sse.lua
@@ -1,4 +1,5 @@
 local curl = require('model.util.curl')
+local util = require('model.util')

 local M = {}

@@ -64,6 +65,7 @@ function M.client(handlers)
       --  partial of multiple sse message

       pending = pending .. raw
+      util.notify('trace1: ' .. string.sub(raw, -100):gsub('\r', ''):gsub('\n', ''))

       if is_sse then
         consume_sse_messages()
@@ -76,6 +78,7 @@ function M.client(handlers)
     on_error = handlers.on_error,
     on_exit = function()
       if #pending > 0 then
+        util.notify('trace2: ' .. string.sub(pending, -100):gsub('\r', ''):gsub('\n', ''))
         if is_sse then
           handlers.on_message(M.parse_message(pending), pending)
         else

And in the message buffer of vim it is clearly evident that either on_exit is called after last on_stdout or there is some race condition happening and pending =  pending .. raw change is not propagated when on_exit is executed.
[skipped]
trace1: data: {"content":" particularly","multimodal":false,"slot_id":0,"stop":false}
trace1: data: {"content":" proud","multimodal":false,"slot_id":0,"stop":false}
trace1: data: {"content":" of","multimodal":false,"slot_id":0,"stop":false}
trace1: data: {"content":" yourself","multimodal":false,"slot_id":0,"stop":false}
trace1: data: {"content":"?","multimodal":false,"slot_id":0,"stop":false}
trace1: data: {"content":"","multimodal":false,"slot_id":0,"stop":false}
trace1: data: {"content":"","multimodal":false,"slot_id":0,"stop":false}
trace1: data: {"content":"","multimodal":false,"slot_id":0,"stop":false}
trace1: data: {"content":"","multimodal":false,"slot_id":0,"stop":false}
trace1: data: {"content":"","multimodal":false,"slot_id":0,"stop":false}
trace1: data: {"content":"","multimodal":false,"slot_id":0,"stop":false}
trace1: data: {"content":"","multimodal":false,"slot_id":0,"stop":false}
trace1: 49,"prompt_n":410,"prompt_per_second":208.4446520982496,"prompt_per_token_ms":4.797436585365854},"to
trace1: kens_cached":704,"tokens_evaluated":410,"tokens_predicted":295,"truncated":false}
trace2: 49,"prompt_n":410,"prompt_per_second":208.4446520982496,"prompt_per_token_ms":4.797436585365854},"to

@gordon-quad I took a shot in the dark based on your diagnosis - it definitely looks like there could've been a race condition. Let me know if these updates fix the issue.

It totally did, thanks!


Add more tests

We need more tests coverage. Check https://coveralls.io/github/ZoranPandovski/pycoincap?branch=master for not covered lines.

@irrationalRock Yes


Issue #318 - Pro 2.3 support

#318
Required changes to support the addin at Pro 2.3. Changes:

Keys changed in 2.3 Styles, so needed to change the query used to identify a main icon
Affiliation is now a required property so needed to ensure this gets set with the symbol attributes

Also removed some old unused files.
Current Pro 2.3 daily still has an issue generating the previews (includes label placeholder issue mentioned here ) - so you will see previews that look like this is you test:

Tested in Pro 2.3 Beta 1 build 14512


height, verticalAlignment doesn't work

i create a textLayer in such code which set stringValue, verticalAlignment, frame and so on in sketch 52.6
var Text = require('sketch/dom').Text;
var layerObjectJS = new Text({
            parent: currentLayer.parentArtboard(),
            text: "123",
            name: "123",
            fixedWidth: 1,
           alignment:2,
           frame:{x: 10,  y:10, width:145, height:145}
           });
var layerObject = layerObjectJS._object;
layerObject.textColor = MSImmutableColor.colorWithSVGString("#0000FF");

        //set paragraph
            var paragraphStyle = layerObject.paragraphStyle();
            paragraphStyle.setParagraphSpacing("3");
            layerObject.addAttribute_value("NSParagraphStyle", paragraphStyle);

        //set font
        var newFont = NSFont.fontWithName_size("PingFangSC-Regular", 30);
        layerObject.setFont(newFont);

        layerObject.setKerning(2);
      layerObject.verticalAlignment = 2;

since i want make the text height of 90 but it result to 42 which just wrap the text

the i use
currentLayer.absoluteRect().height = 90;

the height of layer is 90 but the verticalAlignment is wrong, and can't be edit otherwise you change the height of layer manual not by code

it seem that when the height of layer is bigger than the text, verticalAlignment can not work

Any idea about this?

I can reproduce as well (on Sketch 54). Something seems wrong when attempting to set a frame and adding any sort of styling.
let sketch = require('sketch')
let Text = require('sketch').Text
let Rectangle = require('sketch/dom').Rectangle

let document = sketch.getSelectedDocument()
let page = document.selectedPage

let textLayer = new Text({
  parent: page,
  text: "123",
  name: "textLayer",
  frame: new Rectangle(10,10,125,125),
})

Works as expected but as soon as you attempt to style it the frame gets updated to a different location:
let sketch = require('sketch')
let Text = require('sketch').Text
let Rectangle = require('sketch/dom').Rectangle

let document = sketch.getSelectedDocument()
let page = document.selectedPage

let textLayer = new Text({
  parent: page,
  text: "123",
  name: "textLayer",
  frame: new Rectangle(10,10,125,125),
  style: {}
})

I thought that this was fixed with #435 🤔

i found the solution, in order to make verticalAligment work, the textLayer must setTextBehavior
layerObject setTextBehaviour(2);

then the height and verticalAlignment all be right
so hard to find out about it


Unexpected version found while deserializing dlib::input_rgb_image_sized

hi@davisking, when i used the model generated by  dnn_metric_learning_on_images_ex, and replace/rename into dlib_face_recognition_resnet_model_v1.dat for dnn_face_recognition_ex, i got this error:
Unexpected version found while deserializing dlib::input_rgb_image_sized
it worked when i used the original .dat file, so it is because of the model file. it is really strange, as the .dat file is only a model file, however the error message is about image size.
my pc is in ubuntu 16.04 with cuda/cudnn, all things are ok during building, and i use the default johns images for training.

The input layers are different.  That's what the error is telling you.  They have to be the same.

@davisking
Hi, I use the script  "dnn_metric_learning_on_images_ex.cpp" and load the pretrained model:
deserialize("dlib_face_recognition_resnet_model_v1.dat") >> net;
also, i have resize the image by add a line code as below:
for (size_t j = 0; j < samples_per_id; ++j)
{
const auto& obj = objs[id][rnd.get_random_32bit_number()%objs[id].size()];
load_image(image, obj);
        image.set_size(150, 150);

        images.push_back(std::move(image));
        labels.push_back(id);
    }

i get an error:
terminate call after throwing an instance of 'dlib::serialization_error'
what(): unexpected version found while deserializing dlib::input_rgb_image.

I think it is the word "version" that stops some programmers from reading the rest of the error message.
I myself fell into dlib version checking for quite a while...

@sorenchiron I am still puzzling on this:)
does it mean that I need to change this:
input_rgb_image_sized<150>
into:
input_rgb_image_sized<"size of my training images">
?

You can't just change the network definition and then deserialize a model
that uses a different network.  That's what the error is telling you.

@davisking thank you.
another problem, I have used vgg face for metric learning, it finished in few minutes, I am not sure if it is correct or not, as there is only these logs, no more information:
objs.size(): 8631
done training
num_right: 250
num_wrong: 50

@davisking I found a strange problem on training:
1.If I run the dnn_metric_learning_on_images_ex vgg(I used aligned vgg face dataset and cropped all images into the same size) in command line, then it will generate the above message
2.However, if I run it in visual studio(in debug mode), then it is OK
I have checked the param(only 1 parameter) and visual studio configuration, there is no difference, it is really strange.

by the way, the problem of this issue has been solved, just as you said, I need to set the network definition same with training, thank you.
But the accuracy is not as good as your model

hey @anguoyang can you please elaborate how you solved this problem? i'm trying to explore Dlib,  and this would be of great help.

by the way, the problem of this issue has been solved, just as you said, I need to set the network definition same with training, thank you.
But the accuracy is not as good as your model

Hi, could you tell me how you solve this problem? Change the image size in dnn_metric_learning_on_images_ex ? If so, which size should I use? Thank you.

I find the solution in another issue. Anyway, thanks.

Can you tell me how it was solved? I urgently need to train a model with dlib now.


Python tests has to be updated by adding the PICS conditions as per the test plan

Description:

The current sample app(Energy Management app) is implemented with all the Mandatory and Optional Attributes/Commands/Events. So in Raspi platform we are not facing any issues.
But when it comes in real device they may face the issues, if the Optional Attributes/Commands/Events is not implemented in their devices.
The Python script is PASSING, if we run the script without adding the PICS files. Because the current Python scripts didn't expects the PICS as per test plan.

So for below mentioned Python test scripts, the PICS conditions has to be added as per the test plan:

TC_EEM_2_2.py
TC_EEM_2_3.py
TC_EEM_2_4.py
TC_EEM_2_5.py
TC_EEVSE_2_2.py
TC_EEVSE_2_4.py
TC_EEVSE_2_5.py
TC_EPM_2_1.py

Example:

Test Plan Reference: https://github.com/CHIP-Specifications/chip-test-plans/tree/master/src/cluster

@jamesharrow  In this PR: https://github.com/project-chip/connectedhomeip/pull/32464 the TC-EEM-2.1 and TC-EPm-2.1 tests only resolved. Other than that, all the scripts which is mentioned above has to be updated with the PICS guard.

TC_EPM_2_1 already has PICS guard checks. But it seems, the script doesen't checks the PICS. Becasue while we run the script without adding the PICS files all the steps gets PASSING without skipping any steps.

That’s expected when you use the example energy management app since it supports all of the required features for these tests.
the tests would likely fail if you used a different DUT which didn’t.

Note the PR explains the rationale for not using PICS everywhere - when discussed with other CSA members the approach of moving away from PICS to asking the device what attributes it supports is felt to be better in the longer term.
So EVSE test cases don’t rely on PICS but check the supported attributes attribute. Ideally we should change all of the test cases to use that approach instead of PICS, but given the urgency of the request I used PICS / pics_guard to check the PICS for resolving 1.3 SVE issues on EPM/EEM.
But I think this needs looking at in a future matter release across all test cases to try to move away from PICS.


KuduSync.NET: Deployment fails when project contains files with filenames 64+ characters long

Try to deploy the following repo:
https://github.com/koistya/kudu-test-case-01/
Counting objects: 7, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (6/6), done.
Writing objects: 100% (7/7), 8.09 KiB | 0 bytes/s, done.
Total 7 (delta 0), reused 0 (delta 0)
remote: Updating branch 'master'.
remote: Updating submodules.
remote: Preparing deployment for commit id 'bc68c6f1ad'.
remote: Generating deployment script.
remote: Running deployment command...
remote: Handling node.js deployment.
remote: KuduSync.NET from: 'D:\home\site\repository' to: 'D:\home\site\wwwroot'
remote: Error: The specified path, file name, or both are too long. The fully qualified
file name must be less than 260 characters, and the directory name must be less
than 248 characters.
remote: Failed exitCode=1, command="kudusync" -v 50 -f
"D:\home\site\repository" -t "D:\home\site\wwwroot" -n
"D:\home\site\deployments\bc68c6f1adf28f74bc70d3ff625a342975cc1846\manifest" -p
"D:\home\site\deployments\f0c0c07f0de42e452a7545316c422c0ce84fade1\manifest" -i
".git;.hg;.deployment;deploy.cmd"
remote: An error has occurred during web site deployment.
remote:
remote: Error - Changes committed to remote repository but deployment to website failed.

David, how to get rid of Git Objects in Azure web app  which is occupying huge File Storage in my web App. 50 MB Application shows 1.5 gb usage due to continuous deployment using git.

@qloudau this issue relates to long file names causing problems. What you describe seems unrelated to that, right? If so, please open a new issue.


docs(DEPENDENCIES): update

Description

In this pull request, we are updating dependencies file as spring boot version bumped to 3.3.3 from 3.2.3.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[ ] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[ ] Copyright and license header are present on all affected files

Let's just update the DEPENCIES. No need to wait because of a Check that can be ignored for this pull request

Sure 👍


mdx hashtag links are not respecting the 'hashRouter' configuration

Bug Report
As a followup to #268 when you set hashRouter: true, the hashtag links ignoring it.
this will result in  a  "page not found".

To Reproduce

Set  hashRouter: true
Create a simple .mdx file with a local link:

---
name: Getting started
route: /
---

## Hello

3.Click the hashtag link Hello
4. You will be navigating to the "page not found": localhost:port/#hello
Expected behavior
Navigate to the correct route using the hashRouter: localhost:port/#/#hello

Fixed, will be released in the next version 🙏


Investigate precomputing reciprocals for division operations in XLA

Today we optimize this elementwise division by a scalar:
HloModule DivReciprocal

ENTRY main {
  x = f32[2000,200]{1,0} parameter(0)
  y = f32[] parameter(1)
  y.broadcast = f32[2000,200]{1,0} broadcast(y), dimensions={}
  ROOT div = f32[2000,200]{1,0} divide(x, y.broadcast)
}

into the following:
HloModule DivReciprocal

fused_computation {
  param_0 = f32[2000,200]{1,0} parameter(0)
  param_1.1 = f32[] parameter(1)
  y.broadcast.1 = f32[2000,200]{1,0} broadcast(param_1.1), dimensions={}
  ROOT div.1 = f32[2000,200]{1,0} divide(param_0, y.broadcast.1)
}

ENTRY main {
  x = f32[2000,200]{1,0} parameter(0)
  y = f32[] parameter(1)
  ROOT fusion = f32[2000,200]{1,0} fusion(x, y), kind=kLoop, calls=fused_computation
}

fusion is ultimately lowered into the following PTX (via LLVM):
//
// Generated by LLVM NVPTX Back-End
//

.version 6.0
.target sm_60
.address_size 64

        // .globl       fusion

.visible .entry fusion(
        .param .u64 fusion_param_0,
        .param .u64 fusion_param_1,
        .param .u64 fusion_param_2
)
.reqntid 1024, 1, 1
{
        .reg .pred      %p<2>;
        .reg .f32       %f<11>;
        .reg .b32       %r<6>;
        .reg .b64       %rd<10>;

        mov.u32         %r2, %ctaid.x;
        mov.u32         %r3, %tid.x;
        shl.b32         %r4, %r2, 10;
        or.b32          %r5, %r4, %r3;
        setp.lt.u32     %p1, %r5, 100000;
        @%p1 bra        LBB0_2;
        bra.uni         LBB0_1;
LBB0_2:
        ld.param.u64    %rd4, [fusion_param_0];
        ld.param.u64    %rd5, [fusion_param_2];
        cvta.to.global.u64      %rd1, %rd5;
        ld.param.u64    %rd6, [fusion_param_1];
        cvta.to.global.u64      %rd2, %rd6;
        cvta.to.global.u64      %rd3, %rd4;
        shl.b32         %r1, %r5, 2;
        mul.wide.u32    %rd7, %r1, 4;
        add.s64         %rd8, %rd2, %rd7;
        ld.global.nc.v4.f32     {%f1, %f2, %f3, %f4}, [%rd8];
        ld.global.nc.f32        %f5, [%rd1];
        rcp.approx.f32  %f6, %f5;
        mul.f32         %f7, %f1, %f6;
        add.s64         %rd9, %rd3, %rd7;
        mul.f32         %f8, %f2, %f6;
        mul.f32         %f9, %f3, %f6;
        mul.f32         %f10, %f4, %f6;
        st.global.v4.f32        [%rd9], {%f7, %f8, %f9, %f10};
LBB0_1:
        ret;

}

It is conceivable that in some cases computing the reciprocal for x once, before we launch the kernel for fusion, can be profitable.  We should investigate if (and when) precomputing the reciprocal helps, and if it does, implement it as an optimization in XLA.

Hi, as per the other bug report, would you be willing not to assign issues to me that I am not working on?

It should be always profitable to hoist the reciprocal showing in the example, the problem is if the
floating point precision differences are acceptable. Many compilers do the transformation under options which allow such differences.

the problem is if the floating point precision differences are acceptable

Indeed.
We already pass -nvptx-prec-divf32=0 to LLVM, which lets it use PTX div.approx.  This is a large win on some benchmarks.
But even this optimization is observable.  For example, if x == y, then x/y == 1 should be true.  But it's not with div.approx.  You can make this error arbitrarily large by e.g. doing floor(x/y) -- now this is 1 or 0, depending on whether or not there was an error.
We don't have a good framework for making decisions about whether or not these kinds of optimizations are allowable in XLA.  What we want for an ML compiler is different from traditional compiler "fastmath" assumptions.  We usually want to preserve infs and nans, maybe even signed zeroes.  We also in general don't want to arbitrarily decrease precision by reassociation (although we do this in some places today).
Instead (I think) we want the freedom that comes from the assumption that the floating-point inputs to a program are effectively random numbers.  It should be OK for XLA to transform a program f(x) into a program g(x) = f(x+epsilon), because that perturbation is "within the noise" anyway.  Under a model like that many approximations (not just approximate div, but say approximate tanh) may become acceptable.
I dunno if that's a sound model, but it's my working idea.
Anyway my hunch is that since we're already doing div.approx, precomputing reciprocals is probably ok.

I am not sure if the original issue is about transforming the original code into the following
(compute the reciprocal of parameter(1), and passed as a parameter to the fusion, and inside the
fusion, the divide is replaced by multiply),
HloModule DivReciprocal
fused_computation {
param_0 = f32[2000,200]{1,0} parameter(0)
param_1.1 = f32[] parameter(1)
y.broadcast.1 = f32[2000,200]{1,0} broadcast(param_1.1), dimensions={}
ROOT div.1 = f32[2000,200]{1,0} multiply(param_0, y.broadcast.1)
}
ENTRY main {
x = f32[2000,200]{1,0} parameter(0)
y = f32[] divide(1.0f/parameter(1))
ROOT fusion = f32[2000,200]{1,0} fusion(x, y), kind=kLoop, calls=fused_computation
}

I am not sure if the original issue is about transforming the original code into the following

Yes, exactly like you have it.  This is useful on the assumption -- now questioned! -- that computing recip.approx is significantly less expensive than computing div.approx.

Regarding the single-precision floating point .approx PTX instructions (namely div.approx, rcp.approx, ex2.approx, lg2.approx, sqrt.approx, rsqrt.approx, sin.approx, and cos.approx),

      All of them are implemented with a few straight-line hardware instructions (some of which are predicated).

      The non-ftz versions have a few more instructions to handle denorms, thus are slower than the ftz versions.

      div.approx is implemented as rcp.approx and mul.

You can verify the above using the nvdisasm tool shipped with the CUDA toolkit.
The throughput of these instructions is lower than that of mul, but in the same magnitude as mul compared with memory access. They generally should be considered ‘cheap’ in the cost function for fusion decisions, even if they are used in a broadcast.
Since you’re consistently lowering single precision HLO division to PTX’s div.approx, we do not recommend pursuing the optimization suggested in this issue per the above analysis.


backtraces don't appear in release mode linux

Sorry if this is a dupe, didn't see it.
This works OK in OS X, but compiled in release, backtraces seem to be removed in Linux (both 32 and 64 bit).
$ cat use_it.cr
require "http/server"
server = HTTP::Server.new("<IP_ADDRESS>", 8080) do |context|
  raise "boom"
end
puts "Listening on http://:8080"
server.listen

$ crystal -v
Crystal 0.20.4 [d1f8c42] (2017-01-06)

$ crystal run --release  use_it.cr
Listening on http://:8080
Unhandled exception on HTTP::Handler
boom (Exception)
0x8054263: ??? at ??
0x80bbc1b: ??? at ??
0x80bf69c: ??? at ??
0x80bcfc9: ??? at ??
0x805a7fc: ??? at ??
0x0: ??? at ??

$ crystal run use_it.cr
Listening on http://:8080
Unhandled exception on HTTP::Handler
boom (Exception)
0x80b37c9: *CallStack::unwind:Array(Pointer(Void)) at ??
0x80b373f: *CallStack#initialize:Array(Pointer(Void)) at ??
0x80b3705: *CallStack::new:CallStack at ??
0x809d365: *raise<Exception>:NoReturn at ??
0x809d33e: ??? at ??
0x80ae070: ~procProc(HTTP::Server::Context, Nil) at ??
0x8196582: *HTTP::Server::RequestProcessor#process<(OpenSSL::SSL::Socket::Server | TCPSocket+), (OpenSSL::SSL::Socket::Server | TCPSocket+), IO::FileDescriptor>:Nil at ??
0x8196014: *HTTP::Server::RequestProcessor#process<(OpenSSL::SSL::Socket::Server | TCPSocket+), (OpenSSL::SSL::Socket::Server | TCPSocket+)>:Nil at ??
0x8195ebb: *HTTP::Server#handle_client<(TCPSocket+ | Nil)>:Nil at ??
0x80ae5a9: ~procProc(Nil) at ??
0x80d0890: *Fiber#run:(IO::FileDescriptor | Nil) at ??
0x80ab2fe: ~proc2Proc(Fiber, (IO::FileDescriptor | Nil)) at ??
0x0: ??? at ??
^C

There are cases where symbols can't be found by dladdr on Linux, for some unknown reasons. I shall resume work on parsing DWARF sections to extract function name, in addition to line numbers, that should mitigate, if not resolve, this issue.
What happens if you compile with --debug? There should be at file line:colum appearing.

OK here's an attempt, on 64 bit:
$  crystal run --debug --release use_it.cr
Unhandled exception on HTTP::Handler
boom (Exception)
# 0x5614d696d40e: ??? at /root/.cache/crystal/macro71924688.cr 10:28
0x5614d69d80a2: ??? at /opt/crystal/src/string.cr 3521:5
0x5614d69db7ae: ??? at /opt/crystal/src/http/content.cr 53:26
0x5614d6972c28: ??? at /opt/crystal/src/fiber.cr 114:3
0x0: ??? at ??

In case its useful, even without the debug flag, if I interrupt a process from within GDB I get this:
Thread 1 (Thread 0x7ffff7feb240 (LWP 25938)):
#0  0x00005555555d20b4 in ~procProc(HTTP::Server::Context, Nil)@use_it.cr:2 ()
#1  0x00005555555d74a7 in *HTTP::Server::RequestProcessor#process<(OpenSSL::SSL::Socket::Server | TCPSocket+), (OpenSSL::SSL::Socket::Server | TCPSocket+), IO::FileDescriptor>:Nil ()
#2  0x000055555556cc28 in *Fiber#run:(IO::FileDescriptor | Nil) ()
#3  0x0000000000000000 in ?? ()

Which I believe is the thread processing the request.  FWIW. Thanks.

We have or there is an issue with dladdr. Maybe we should parse the ELF symtab section ourselves (I believe this is what GDB does).

Seems if not fixed at least practically fixed in 0.20.5:
$ crystal run --release  use_it.cr
Listening on http://:8080
Unhandled exception on HTTP::Handler
boom (Exception)
0x8054293: ??? at /home/rdp/.cache/crystal/macro185201744.cr 10:28
0x80c167b: ??? at /opt/crystal/src/int.cr 175:7
0x80c5109: ??? at /opt/crystal/src/http/server/request_processor.cr 39:11
0x80c2a29: ??? at /opt/crystal/src/http/server/request_processor.cr 16:3
0x805a82c: ??? at /opt/crystal/src/fiber.cr 114:3
0x0: ??? at ??

Though this stack trace still doesn't include the line number that actually generated the exception ( /home/rdp/.cache/crystal/macro185201744.cr just contains

            @callstack : CallStack | ::Nil

            def callstack : CallStack | ::Nil
              @callstack
            end

            def callstack=(@callstack : CallStack | ::Nil)
            end

, at least it's showing line numbers at all, hugely better.  So I'll close this one now, let me know if I should open another for that.

The backtrace is terser because LLVM inlines many function calls in release mode (aggressive optimizations); they don't exist anymore, and they can't appear in the backtrace anymore.


Only use self-closing tags for void-elements

This is likely the cause of: https://github.com/dart-lang/pub-dev/issues/2405
For a list of void-element see: https://www.w3.org/TR/html5/syntax.html#void-elements
In particular:

Tags are used to delimit the start and end of elements in the markup. Raw text, escapable raw text, and normal elements have a start tag to indicate where they begin, and an end tag to indicate where they end. The start and end tags of certain normal elements can be omitted, as described below in the section on [[#optional tags]]. Those that cannot be omitted must not be omitted. Void elements only have a start tag; end tags must not be specified for void elements. Foreign elements must either have a start tag and an end tag, or a start tag that is marked as self-closing, in which case they must not have an end tag.

It's clear that void-elements cannot have closing tags, but that for all other tags it is better to have <b></b> than <b/> as the latter is not allowed.

This has been fixed and patch was released in sanitize_html version 1.3.0, see:
https://pub.dev/packages/sanitize_html/versions/1.3.0#-changelog-tab-


Validator passes invalid plugin_path to clap_plugin_entry::init when trying to load bundle on MacOS

According to this comment the plugin_path argument on the clap_plugin_entry::init should point to the DLL on windows or the Bundle on MacOS. However, right now the validator passes the actual library within the bundle when initialising.
The issue to me seems to be here, where the path for loading the library is updated to deal with the fact that it's a bundle. This path is then also passed to the init function, when the original path should be.

The correct behavior is now specified as of https://github.com/free-audio/clap/commit/f6d86a7e7c9cd3da233cb9ffa8e54396000ecabf. So this is the DSO on any platform except for macOS, where the path points to the bundle.


No such file or directory - pod

Hey guys,
I'm running in a weird error... from time to time Fastlane fails to run cocoapods in my CI environment (Mac OS X 10.11 using Bamboo agent).
If I run pod install outside of Fastlane, eveything works fine. When I run cocoapods inside of Fastlane lane, it fails:
  desc "Testing"
  lane :test do

    # Cocoapods install.
    cocoapods

    # Run all unit tests.
    scan

  end

18-Apr-2016 16:53:50	[16:53:50]: -----------------------
18-Apr-2016 16:53:50	[16:53:50]: --- Step: cocoapods ---
18-Apr-2016 16:53:50	[16:53:50]: -----------------------
18-Apr-2016 16:53:50	[16:53:50]: $ pod install
18-Apr-2016 16:53:50	[16:53:50]: Variable Dump:
18-Apr-2016 16:53:50	[16:53:50]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios test"}
18-Apr-2016 16:53:50	[16:53:50]: No such file or directory - pod
18-Apr-2016 16:53:50
18-Apr-2016 16:53:50	+------+-------------------------------------+-------------+
18-Apr-2016 16:53:50	|                     fastlane summary                     |
18-Apr-2016 16:53:50	+------+-------------------------------------+-------------+
18-Apr-2016 16:53:50	| Step | Action                              | Time (in s) |
18-Apr-2016 16:53:50	+------+-------------------------------------+-------------+
18-Apr-2016 16:53:50	| 1    | Verifying required fastlane version | 0           |
18-Apr-2016 16:53:50	| 2    | default_platform                    | 0           |
18-Apr-2016 16:53:50	| 3    | cocoapods                           | 0           |
18-Apr-2016 16:53:50	| 4    | reset_git_repo                      | 0           |
18-Apr-2016 16:53:50	| 5    | clean_build_artifacts               | 0           |
18-Apr-2016 16:53:50	+------+-------------------------------------+-------------+
18-Apr-2016 16:53:50
18-Apr-2016 16:53:50	[16:53:50]: fastlane finished with errors
18-Apr-2016 16:53:52	Successfully submitted a crash report. If this is a problem with one of the tools specifically,
18-Apr-2016 16:53:52	please submit an issue on GitHub and attach the following number to it: 'bffb92b21bb6b15a085139e3137bc5d4'
18-Apr-2016 16:53:52	The crash report has been stored locally '/tmp/sentry_bffb92b21bb6b15a085139e3137bc5d4.json'
18-Apr-2016 16:53:52	/Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/helper/sh_helper.rb:26:in `popen': [!] No such file or directory - pod (Errno::ENOENT)
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/helper/sh_helper.rb:26:in `sh_no_action'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/helper/sh_helper.rb:9:in `sh'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/actions/cocoapods.rb:27:in `run'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/runner.rb:143:in `block (2 levels) in execute_action'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/runner.rb:129:in `block in execute_action'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/runner.rb:128:in `chdir'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/runner.rb:128:in `execute_action'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/fast_file.rb:149:in `method_missing'
18-Apr-2016 16:53:52	        from Fastfile:22:in `block (2 levels) in parsing_binding'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/lane.rb:36:in `call'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/lane.rb:36:in `call'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/runner.rb:52:in `block in execute'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/runner.rb:46:in `chdir'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/runner.rb:46:in `execute'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/lane_manager.rb:46:in `cruise_lane'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/lib/fastlane/command_line_handler.rb:30:in `handle'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/bin/fastlane:38:in `block (2 levels) in run'
18-Apr-2016 16:53:52	        from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
18-Apr-2016 16:53:52	        from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
18-Apr-2016 16:53:52	        from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
18-Apr-2016 16:53:52	        from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
18-Apr-2016 16:53:52	        from /Library/Ruby/Gems/2.0.0/gems/fastlane_core-0.41.2/lib/fastlane_core/ui/fastlane_runner.rb:23:in `run!'
18-Apr-2016 16:53:52	        from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/bin/fastlane:168:in `run'
18-Apr-2016 16:53:52	        from /Users/<user>/.gem/ruby/2.0.0/gems/fastlane-1.81.0/bin/fastlane:174:in `<top (required)>'
18-Apr-2016 16:53:52	        from /usr/local/bin/fastlane:23:in `load'
18-Apr-2016 16:53:52	        from /usr/local/bin/fastlane:23:in `<main>'

I could fix the issue passing the PATH as an environment variable in the Bamboo plan:
PATH="/usr/local/bin"

But it's very weird that Fastlane couldn't find cocoapods even with PATH defined in the ~./profile and ~./bash_profile files.

Thanks for the report, we'll take a look.

@fabioknoedt Glad to hear you got around this with an environmental variable. It seems like the reason you need to pass this is a config on your local machine. For now keep passing the podfile as a parameter. Thanks! 👍


Your implementation is different from the Gail paper

Nice implementation! but I find some inconsistency in your discriminator.py
If you check the formula 17 of paper General Adversarial Imitation Learning
it should be 1-expert_probability, but in line 35 in your discriminator.py, it is 1-policy_probability.
Just want to assure with you :)

Thanks for pointing it out!
You are right that it is inconsistent with original code.
In original paper, the discriminator outputs a "cost".
In my implementation, the discriminator outputs a "reward" instead of "cost".
I implemented in this way because I am more familiar with rewards than costs.

Thanks for your explanation! Guess it still work if I switch it to cost right?

Yes, it should work if you find and rewrite all the codes using discriminator's outputs, such as
https://github.com/uidilr/gail_ppo_tf/blob/f8f496f69c2a166e91164d9082d7f9fd5a80b6b5/run_gail.py#L97-L101

I think nothing will change by changing the reward to cost. It can be change from maximisation problem to minimization problem :) Which is similar.


Add ColumnExpr and ExcludeColumn to UpdateQuery and InsertQuery

Small change per #18 to add exclude column to InsertQuery

Thanks


⚠ Jenkins Plugins Artifactory has degraded performance

In 3da71db, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1340 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 21e4a94 after 12 minutes.


partners, elasticsearch: Enable ElasticsearchStore to retrieve with the pure BM25 algorithm without vector search

Description
This pull request proposes the implementation of the BM25RetrievalStrategy for ElasticsearchStore. This retrieval strategy enables searches purely based on BM25 without involving vector search. Below, the usage example, motivation, and details of the changes are discussed.
Usage Example of Introduced Feature
By specifying the BM25RetrievalStrategy as a constructor argument for ElasticsearchStore, users can perform searches using pure BM25 without vector search. Note that in the example below, the embedding option is not specified, indicating that the search is conducted without using embeddings.
from langchain_elasticsearch.vectorstores import ElasticsearchStore

store = ElasticsearchStore(
    es_url="http://localhost:9200",
    index_name="test_index",
    strategy=ElasticsearchStore.BM25RetrievalStrategy(),
)

store.add_texts(
    [
        "foo",
        "foo bar",
        "foo bar baz",
        "bar",
        "bar baz",
        "baz"
    ],
)

results = store.similarity_search(query="foo", k=10)
print(results)

The example above outputs:
[Document(page_content='foo'), Document(page_content='foo bar'), Document(page_content='foo bar baz')]

Motivation
There is a considerable demand for using Elasticsearch as a pure BM25 retriever without vector search. Although hybrid searches combining vector search and BM25 are supported alongside ApproxRetrievalStrategy, there are cases where pure BM25 searches are needed, for example, when seeking speed performance in search or prioritizing exact matches over semantic searches.
Pure BM25 retrievers, such as ElasticsearchBM25Retriever and BM25Retriever, have already been implemented in langchain_community. However, these classes do not offer the rich and flexible Elasticsearch features supported by ElasticsearchStore, such as various authentication options and flexible querying with custom_query. Additionally, being a subclass of VectorStore, it benefits from components like RecordManager, which are advantageous during operational phases. Therefore, supporting pure BM25 searches in ElasticsearchStore presents significant benefits.
To achieve this, an easy-to-use interface is necessary. The abstraction of ElasticsearchStore itself is sophisticated enough to support pure BM25 without vector search, as it allows inputting a strategy class inheriting from BaseRetrievalStrategy. However, implementing a BM25 search by inheriting from BaseRetrievalStrategy can be challenging for general users (as it took me several days). Without native support from the library, it's difficult for users to arrive at this solution.
Therefore, this PR suggests implementing a new retrieval strategy, BM25RetrievalStrategy, to enable ElasticsearchStore to support pure BM25 searches.
Change Details

Implemented the BM25RetrievalStrategy class.
Added a new argument, text_field, to the index method of BaseRetrievalStrategy.

While strictly speaking, this modification could potentially affect backward compatibility, it's my belief that the number of users directly inheriting and utilizing BaseRetrievalStrategy in their projects is relatively small. Consequently, the overall impact of this change should be minimal. Nonetheless, I am open to and would appreciate any feedback on this matter.

Added integration test scenarios to verify the behavior of BM25RetrievalStrategy, named test_similarity_search_bm25_search*. Following the example of other retrieval strategy classes, scenarios with and without using the filter option were tested.

cc @joemcelroy

thanks so much for your contribution. The last part is could you document this too https://github.com/langchain-ai/langchain/blob/master/docs/docs/integrations/vectorstores/elasticsearch.ipynb

@joemcelroy
Thank you for your approval!
I've added the documentation. PTAL.
commit: https://github.com/langchain-ai/langchain/pull/19314/commits/e1ab8f856b2f20084c1bb0c9ac89ccffa84e2768
preview: https://langchain-eibb0l4qr-langchain.vercel.app/docs/integrations/vectorstores/elasticsearch#bm25retrievalstrategy
cc: @miguelgrinberg @maxjakob @baskaryan @efriis

Hm, libs/partner/elasticsearch has been removed from the repository and moved to https://github.com/langchain-ai/langchain-elastic
@joemcelroy @miguelgrinberg @maxjakob @baskaryan @efriis
May I close this PR and create a one with the same changes in  the new langchain-elastic repository?
As I'm not sure about the roadmap/timeline of the repository migration, let me know if there's the best timing of moving this PR.

Hm, libs/partner/elasticsearch has been removed from the repository and moved to https://github.com/langchain-ai/langchain-elastic
@joemcelroy @miguelgrinberg @maxjakob @baskaryan @efriis May I close this PR and create a one with the same changes in the new langchain-elastic repository? As I'm not sure about the roadmap/timeline of the repository migration, let me know if there's the best timing of moving this PR.

yep moving to langchain-elastic makes sense!

Thank you for your comment. I have recreated the PR in the langchain-elastic repository: https://github.com/langchain-ai/langchain-elastic/pull/6
Please review it at your convenience. @joemcelroy @miguelgrinberg @maxjakob @baskaryan @efriis
I will now close this PR in the LangChain main repository.


Ensure that SDG path data branch matches evaluation branch

We need to ensure the SDG path data we are receiving is being generated off the same branch we are passing for evaluation.
I have some sample data that indicates this is tracked in the SDG data in the form of origin_branch_name.
We need to meet with the SDG team and ensure that data will be there and can be consumed in a predictable way.

Right now the data format is the same as it was before in the CLI. That data does not exist in the output right now.

Ack @russellb - is the plan to have that information added to the output? This is an example of the sample data I'm basing the above assumptions off of: https://github.com/nathan-weinberg/eval/blob/test/tests/testdata/sdg/tonsil_data.jsonl
cc @danmcp

You should be looking at data generated by the CLI. I don’t think that’s where that data came from.

@russellb sounds good, @aakankshaduggal and I are going to talk about this more later today, cc @oindrillac

@russellb @oindrillac i just spoke with @aakankshaduggal and the data format y'all are planning to do for training in the issue above is the same format we are expecting for Eval, so we should be good on our side as soon as that's complete!

assuming someone is going to adjust the CLI training code for the new format as well, then?

This issue really only pertains to Eval, so can't speak to Training


fix many typos

partially addresses #271 , doesn't add CI

@sbryngelson Fixed a performance issue and added the Github workflow.

Going to intentionally introduce a misspelled word in a commit tomorrow to make sure the CI catches it, then merge. This could also be a precommit hook but not sure I can be bothered (would be glad to have your advice here).

Works as expected.

@sbryngelson, I hadn't mentioned I also tested the workflow - locally - with act.

@sbryngelson, I hadn't mentioned I also tested the workflow - locally - with act.

Yeah this is a nice tool


Stakeholder Approved Merge to Master

Description
Merge stakeholder-approved deliverables to master branch and put into live production.
Checklist

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] I have added tests that prove my fix is effective or that my feature works AND the tests pass

Reopening request after fixes are applied to Stakeholder branch.


[Doc] Linting23a

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.15 out of 16 committers have signed the CLA.:white_check_mark: trueeyu:white_check_mark: silverbullet233:white_check_mark: nshangyiming:white_check_mark: stdpain:white_check_mark: gengjun-git:white_check_mark: decster:white_check_mark: sevev:white_check_mark: luohaha:white_check_mark: rickif:white_check_mark: satanson:white_check_mark: evelynzhaojie:white_check_mark: Youngwb:white_check_mark: fzhedu:white_check_mark: ZiheLiu:white_check_mark: DanRoscigno:x: mergify[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


Use shared configuration nodes for credentials

Using multiple Watson nodes of the same type means I have to separate input the same user account details. Credentials should be shared across nodes of the same type using the configuration node.

If this is still a to-do item, please reopen against the node-red-node-watson repo. Thanks


Feature request: Color properties for visualizations on Edges & Nodes

Would it be possible to add color properties for the visualizations of edges & nodes? Graphviz supports it for the python colors: https://graphviz.org/doc/info/colors.html
I'm not sure about the other languages then python but I'm sure I wouldn't be alone to want colors in graphs to ease their use when they become large.

Hi @lancilloty
The great thing about the schema is that both the node bodies and the edge properties allow any valid json.
So all you have to do is include a key value pair like "fillcolor": "cyan" in the node bodies, and then the visualizer function (the python implementation has moved here, BTW) should be able to represent that as a node attribute without any further modification.
That's just off the top of my head though, I haven't tried it, and you might need a slight tweak to either the _as_dot_label or _as_dot_node functions to get it to work.
Feel free to file a request there if it doesn't pick it up automatically.


Format moves lines on every format call in an invalid schema

Formatting this:

leads to

and for every added character after test this shifts the line above again:

This is the schema I used:
datasource db {
  provider               = "postgresql"
  url                    = env("POSTGRESQL_URL")
  // provider = "sqlite"
  // url      = "file:dev.db"
}
generator photon {
  provider = "prisma-client-js"
}
model Post {
  id   Int      @default(autoincrement()) @id
  tags String[] test
}```


fix maq missing last row. if the last record is exactly 1

Fixes #XXXX.

Description

Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...

Release note

Key changed/added classes in this PR

MyFoo
OurBar
TheirBaz

This PR has:

[ ] been self-reviewed.

[ ] using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)

[ ] added documentation for new or modified features or behaviors.
[ ] a release note entry in the PR description.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

Addressing the issue - https://github.com/apache/druid/issues/15390


UI changes for Attachment widget

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1796
Description
UI changes for Attachment widget
Alternative(s) considered
N/A
Type
Choose one: Feature
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Kindly review this PR after https://github.com/google/android-fhir/pull/1680 is merged

@FikriMilano can you resolve the branch conflicts ?

@omarismail94 resolved

@FikriMilano sorry, one more thing. Can you add screenshots of the UI changes that this PR introduces? We can then get a UX thumbs up from @shelaghm

@shelaghm @omarismail94
screenshots incomingg, your thoughts please

@shelaghm sure, that would be no problem

@omarismail94 resolved

@FikriMilano thank you!

thank you @shelaghm and @FikriMilano ! I will have time to review this today

@omarismail94 that has been implemented previously on PR https://github.com/google/android-fhir/pull/1680
You can also have a look at this code about how we limit upload file size https://github.com/google/android-fhir/blob/master/datacapture/src/main/java/com/google/android/fhir/datacapture/views/QuestionnaireItemAttachmentViewHolderFactory.kt#L232-L239

can you please update the description of the PR to have a list of what changes are included?

I think it would be nice to think about how this would help pave the way for repeated attahcments. I think the new layout files you added could be reused to populate new previews, right?

@jingtang10 yeah, that's right.
also, are you implying we use some sort of a layout to contain the previews? and the previews will be the child view of that layout. So, instead updating the visibility, we add or remove preview from a LinearLayout.


Lvm 2.03.16(2)

Description
To bring up the soon to be released Debian 12 we need LVM cookbook support. Looks like RHEL 9 also uses this LVM version.
Issues Resolved
closes #44
Check List

[ ] New functionality includes tests
[x] All tests pass
[x] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco
[x] PR title is a worthy inclusion in the CHANGELOG

Also required for RHEL 8.7, any progress is getting it merged?

Hi @ramereth,
is there a chance to get this merged and a new release? If there is something I need to changel, please let me know.
Thank you

@schrd sorry for the delay! Released as 0.3.12.


[Question] 绝区零无法统计抽卡数

Checklist

[X] I have already read docs/Tips.md, but my question is not solved.
[X] My question was not mentioned by others, and it is not a duplicate question.

Description

我的绝区零没有统计抽卡记录的按钮
Starward Version
0.11.7-preview.4
Windows Version
22631.3737
Log
No response
Additional Context
No response

update to version 0.11.7-preview.6


 Yes

VS Code Version:<PHONE_NUMBER>d557a81c9d0b5f8a5a1e9274db5585
OS Version: Windows 11 + Ubuntu 20.04 WSL

Summary
Can't use VS Code Server inside of WSL when I'm not connected to the Internet and I don't have the latest version installed
Current behavior
When trying to open vscode form WSL while not connected to the Internet, if it hasn't been opened in a while one gets this:
$ code .

Updating VS Code Server to version<PHONE_NUMBER>d557a81c9d0b5f8a5a1e9274db5585
Removing previous installation...
Installing VS Code Server for x64<PHONE_NUMBER>d557a81c9d0b5f8a5a1e9274db5585)
Downloading: 100%
Failed
--2023-09-20 15:16:58--  https://update.code.visualstudio.com/commit:6509174151d557a81c9d0b5f8a5a1e9274db5585/server-linux-x64/stable
Resolving update.code.visualstudio.com (update.code.visualstudio.com)... failed: Temporary failure in name resolution.
wget: unable to resolve host address ‘update.code.visualstudio.com’
ERROR: Failed to download https://update.code.visualstudio.com/commit:6509174151d557a81c9d0b5f8a5a1e9274db5585/server-linux-x64/stable to /home/ed/.vscode-server/bin/6509174151d557a81c9d0b5f8a5a1e9274db5585-1695215807.tar.gz

Result: unable to use vscode server until I connect back to the Internet.
Expected behavior
Checking internet aaccess (or better, update.code.visualstudio.com access) before actually proceeding to uninstall the existing version of vscode server and trying to install the new one, so that users don't have their vscode access denied while they're not connected to Internet.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.82.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

I have the same problem
VS Code Version  1.82.2
Electron: 25.8.1
Windows 10 21H2
Ubuntu WLS2 20.04
WLS extension 0.81.5

i've the same question after i update vscode

I have same problem with slow speed of downloading vscode server
wget --tries=1 --connect-timeout=7 --dns-timeout=7 -nv -O vscode-server.tar.gz https://update.code.visualstudio.com/commit:31c37ee8f63491495ac49e43b8544550fbae4533/server-linux-x64/stable

Could wget download a server from my local installation of vscode instead using update.code.visualstudio.com?


How about contributing this as a PR to the DataFixerUpper repo?

Hi @jellysquid3!
I tried this out yesterday and there are some really good stuff in your fork.
At a glance it seems to cut the rule optimization execution times by more than 50%, so I'd be very interested to seeing this added to the official repo. Given that it's open sourced there should be nothing stopping us from treating it as a PR like any other.
If you don't feel like spending time on it I could incorporate some of the ideas into the main repo if you don't mind, but I'd rather let you get the credit for the hard work.

That would be awesome, thank you so much!
I replicated most of them locally on mainline and they all seemed to have fairly nice improvements when combined.
The only one I think could lead to discussions is the removal of Optional which depends on which camp you're in.
Personally I'm in the nullable annotation camp when it comes to perf related code, but there could be other opinions on the team.
But regardless it would be a shame to miss out on it since it had quite a dramatic effect.


Right shifts move text to wrong columns when using 'vartabstop' and 'shiftwidth' is 0

Steps to reproduce

$ vim -N -u NONE -i NONE
:set vts=17,13,11,7,5 sw=0 ruler
:normal aword
Shifting right with >> a number of times moves the cursor to the following expected sequence of columns: 18, 31, 42, 49, 54, 59.
Move word back to column 1.
:set shiftround
Shifting right with >> a number of times now moves the cursor to this sequence of columns: 18, 27, 40, 45, 50, 51.
Move word back to column 1.
Type I to insert at the start of the line.
Type Ctrl-T a number of times to shift word to the right.
Again, the sequence of column numbers is 18, 27, 40, 45, 50, 51.
The state of 'shiftround' does not affect the behavior of Ctrl-T because it always rounds.
Left shifts using << or Ctrl-D are not considered here because their movement is broken in other ways.

Right shifts are broken because of the way that rounding is calculated. The width between tab stops at the column of the first non-whitespace character in a line is divided into that column number to determine the indentation of the line in tab stops. That works fine if the tab stops are uniform, but not if they vary.
Expected behaviour
The line should be shifted so that the 'w' in 'word' falls one column to the right of the next tabstop column, as in the sequence of step 4 above.
Version of Vim
9.1.454
Environment
Operating system: Ubuntu 22.04
Terminal: XTerm(389)
Value of $TERM: xterm-256color
Shell: bash 5.1.16
Logs and stack traces
No response

I have a patch for this. I have more testing to do and I need to write a test for the issue. I'll create a PR probably this week.

Since it's been over a week, here's an update. I wrote tests to cover every shift command and option combination I could think of and discovered a number of additional issues, some with my code, some  with existing code, mostly having to do with variable-width tabstops when 'shiftwidth' is 0. The fixes are coming along well--it's just taking time.


Cmp add genm crl status

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

I am still working on it, need to add the test cases and respective CRLs.


Password

Changing the password on the "stable" version breaks the login.
And not having a password is a security issue.

please provide steps to reproduce

copy build/Cheryl.php to public folder on server.
edit username and password in nano of Cheryl.php (lines 39 and 40)
open website in browser.
enter username and password from #2

I tried other things as well... the only password that works is '' (no
password)
Changing the username does work.
On 09/21/2015 10:23 PM, Devin Smith wrote:

please provide steps to reproduce

Reply to this email directly or view it on GitHub:
https://github.com/arzynik/cheryl/issues/31#issuecomment-142160712

--
Devin Ulibarri
(505) 379-6253
www.devinulibarri.com


Hyperlink(s) Broken

The Hyperlink to the losses collection and model collection in the docs are inoperable. Obviously its not too hard to find them, but its a quality of life thing. For example, on this page :

Link works for both auto and non-auto models. Closing for now.


fix re-register can not work when curator session expires.

What is the purpose of the change
related https://github.com/apache/dubbo/pull/5126

Codecov Report

Merging #5135 into 2.7.4-release will decrease coverage by 0.03%.
The diff coverage is 57.14%.

@@                 Coverage Diff                 @@
##             2.7.4-release    #5135      +/-   ##
===================================================
- Coverage            64.08%   64.05%   -0.04%
+ Complexity             452      451       -1
===================================================
  Files                  769      769
  Lines                33240    33277      +37
  Branches              5240     5246       +6
===================================================
+ Hits                 21302    21314      +12
- Misses                9508     9531      +23
- Partials              2430     2432       +2

Impacted Files
Coverage Δ
Complexity Δ

...main/java/org/apache/dubbo/remoting/Constants.java
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

...ing/zookeeper/support/AbstractZookeeperClient.java
70.32% <100%> (+0.66%)
0 <0> (ø)
:arrow_down:

...he/dubbo/registry/zookeeper/ZookeeperRegistry.java
64.86% <22.22%> (-2.52%)
0 <0> (ø)

...ting/zookeeper/curator/CuratorZookeeperClient.java
65.26% <63.15%> (+1.68%)
0 <0> (ø)
:arrow_down:

.../apache/dubbo/qos/protocol/QosProtocolWrapper.java
65.85% <0%> (-17.08%)
0% <0%> (ø)

.../apache/dubbo/remoting/transport/AbstractPeer.java
58.69% <0%> (-6.53%)
0% <0%> (ø)

...ng/exchange/support/header/HeartbeatTimerTask.java
73.68% <0%> (-5.27%)
0% <0%> (ø)

...he/dubbo/remoting/transport/netty/NettyServer.java
69.64% <0%> (-3.58%)
8% <0%> (-1%)

...pache/dubbo/registry/support/AbstractRegistry.java
78.54% <0%> (-1.54%)
0% <0%> (ø)

...pache/dubbo/remoting/transport/AbstractServer.java
47.91% <0%> (-1.05%)
0% <0%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d65897...903c6ca. Read the comment docs.


Call Api with pagination update

Hope this is good enough. Let me know if anything needs to be changed.

Great work. Thank you for the PR.


feat(blockifier): get revert receipt only in case of revert.

This change is

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#2471  👈 (View in Graphite)
#2310 : 1 other dependent PR (#2456 )
#2407
#2301
#2300
#2293
#2150
#2175
#2149
#2200
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 5, 7:08 AM EST: A user started a stack merge that includes this pull request via Graphite.


Great job !

You rock !
A great dataset, great format, great...
Thanks for sharing

Yes, this dataset is amazing!  I created a demo to show how to do full text searching of the dataset here: https://github.com/liamca/azure-search-tate-art-gallery


Highlight unset ports in input ports list

"Unset" ports are mandatory constant ports (min_conn>0) that are
not set and not connected
This commit moves them to the top of the ports list and
makes them bold (like their module port counterpart).
gui/ports_pane.py:

PortItem:
New attribute: is_unset
PortItem.calcUnset: *new
Determines if the port is unset and makes it bold
PortItem._lt_:
Move unset items to the top

I factored calcUnset() into PortItem's constructor.
Are there any modules with ports for which min_conns > 0?

I don't know of any ports with min_conns > 0 yet, but we should think about adding this logic to core packages to test the logic for this.

This does not work as intended because isExpanded is not set until later. That is why I had to delay it.
I had missing ports shown above set ports. Setting a missing port moves it down to the set ports.
I have been using this module to test it:
https://gist.github.com/rexissimus/ec22b9e59301b769b2be

Removed my change since the check has to be made after functions are set.


Tundra2 lc

Has the same content than in https://github.com/realXtend/naali/pull/269 , except also fixes the issue documented in the pull request, and fixed in https://github.com/LudoCraft/Tundra/commit/bd60e149ea03c53778b194a7face106ace817f2c .

the new math stuff doesn't seem to compile for me on ubuntu 11.04, get errors like these:
src/Core/Math/Math/float3.h:658:21: error: specialization of ‘template struct QMetaTypeId’ in different namespace
/usr/include/qt4/QtCore/qmetatype.h:160:8: error:   from definition of ‘template struct QMetaTypeId’
/home/antont/src/tundra2-naali/src/Core/Math/Math/float3.h:658:93: error: definition of ‘static int QMetaTypeIdmath::float3::qt_metatype_id()’ is not in namespace enclosing ‘QMetaTypeIdmath::float3’
In file included from /home/antont/src/tundra2-naali/src/Core/Audio/SoundChannel.h:9:0,
from /home/antont/src/tundra2-naali/src/Core/Audio/AudioAPI.h:7,
from /home/antont/src/tundra2-naali/src/Core/Audio/AudioAPI.cpp:4:
was now starting to review pull requests and got this far with the already closed & merged one :p

Doh.. I did compile the math libraries on linux, but with old QT_INTEROP and not with the renamed MATH_QT_INTEROP define, which ignored these code lines.
This is very unfortunate.. Qt does not support namespaces with the Q_DECLARE_METATYPE mechanism, so you can't have Q_DECLARE_METATYPE outside the symbol's namespace, which is why the metatypes are pushed inside the Math namespace. GCC does not support template specializations inside the namespaces, so Q_DECLARE_METATYPE cannot be used inside the namespace either...
As a workaround, one can try commenting out the line #define MATH_ENABLE_NAMESPACE so that the whole math libraries are compiled without the math:: define. I'll push a fix asap to the repo for that.

Fixed in https://github.com/realXtend/naali/commit/d6d42571ea1eeec2640f3bb62677f8fe437f4285 and https://github.com/realXtend/naali/commit/bd9905ee54d20b5314cbf29457e675569e2299d1


feat: improve signout action

:tada: This PR is included in version 0.69.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add exception projection infrastructure

Description
Add exception projection infrastructure. Ideally adding a new one is as simple as adding the class, i.e, automatic registrations.
Checklist

[x] I have completely filled out this template
[x] I have confirmed that this issue exists on the current master branch
[x] I have confirmed that this is not a duplicate issue by searching issues

Added in #1631