Layers built during call are not tracked in complex model

I've created a layer which creates a sublayer during build which is not built itself until call. Unfortunately, when used in a complex model, this extra layer and its weights are not tracked. Even adding
self.residual_projection.build(input_shape)

in the build does not seem to help, nor is it needed in the simple model.
class ResnetBlock(keras.layers.Layer):
    def __init__(self, output_dim, **kwargs):
        super().__init__(**kwargs)
        self.output_dim = output_dim
        self.norm1 = keras.layers.GroupNormalization(epsilon=1e-5)
        self.conv1 = PaddedConv2D(output_dim, 3, padding=1)
        self.norm2 = keras.layers.GroupNormalization(epsilon=1e-5)
        self.conv2 = PaddedConv2D(output_dim, 3, padding=1)

    def build(self, input_shape):
        if input_shape[-1] != self.output_dim:
            self.residual_projection = PaddedConv2D(self.output_dim, 1)
        else:
            self.residual_projection = lambda x: x

    def call(self, inputs):
        x = self.conv1(keras.activations.swish(self.norm1(inputs)))
        x = self.conv2(keras.activations.swish(self.norm2(x)))
        return x + self.residual_projection(inputs)

The layer should have 10 weights if the input shape and output shape differ, but in the complex model it seems stuck at 8. Using tf.keras with the complex model, it has 10.
Complex model gist
Simple model gist

Thanks for the report. I looked into it, and it's a very subtle bug. I haven't fixed it yet. In short the problem is that the residual connection layer isn't tracked by its parent layer. It isn't tracked because tracking is disabled when it gets assigned. It's disabled because the assign happens, overall, inside the __init__ of a Sequential model, which is exempt from tracking. So it's pretty complicated.
The solution is going to be to better scope the tracking exemption is Sequential so that it doesn't affect children layers.

This should now be fixed -- please try it with the latest version at HEAD.

Thanks for the quick fix! Unfortunately I hit #716 when trying to rebase at HEAD.

Thanks, we're up to 10 layers now! See updated gist.
One note: the layer names no longer match tf.keras. We seem to be incrementing the index twice for every new layer (see truncated summary below). If this isn't a concern, feel free to close, but this would affect any model.get_layer(name) workflows.
 Layer (type)                    ┃ Output Shape              ┃    Param # ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ padded_conv2d_1 (PaddedConv2D)  │ (None, None, None, 128)   │      3,584 │
├─────────────────────────────────┼───────────────────────────┼────────────┤
│ resnet_block_1 (ResnetBlock)    │ (None, None, None, 128)   │    295,680 │
├─────────────────────────────────┼───────────────────────────┼────────────┤
│ resnet_block_3 (ResnetBlock)    │ (None, None, None, 128)   │    295,680 │
├─────────────────────────────────┼───────────────────────────┼────────────┤
│ padded_conv2d_11 (PaddedConv2D) │ (None, None, None, 128)   │    147,584 │
├─────────────────────────────────┼───────────────────────────┼────────────┤
│ resnet_block_5 (ResnetBlock)    │ (None, None, None, 256)   │    919,040 │
├─────────────────────────────────┼───────────────────────────┼────────────┤
│ resnet_block_7 (ResnetBlock)    │ (None, None, None, 256)   │  1,181,184 │
├─────────────────────────────────┼───────────────────────────┼────────────┤


Added domain for Universitat Oberta de Catalunya (uoc.edu)

Website:
www.uoc.edu (catalan)
http://www.uoc.edu/portal/en/index.html (english)
Courses, full list:
http://studies.uoc.edu/en/all-courses
Examples of 4-year IT courses (I'm sorry it's in spanish, they're not available in english)
http://estudios.uoc.edu/es/grados/ingenieria-informatica/plan-estudios
http://estudios.uoc.edu/es/grados/multimedia/plan-estudios
http://estudios.uoc.edu/es/grados/tecnologias-telecomunicacion/plan-estudios
Proof of students using the uoc.edu domain as an educational resource:
http://www.uoc.edu/portal/en/_peu/avis_legal/index.html
It's a legal notice. In section 4, paragraph 3, it states:
The UOC provides all members of the Virtual Campus community with a free email account using the uoc.edu domain and provides the technological and hosting resources needed to administer it. Its use is restricted solely to the educational field and to communication between Campus users; hence using it for professional and commercial purposes is expressly forbidden

@moliusimon Pull request merged. Thank you!


ENH: implement handling of class_weights param

It looks like for single-output models, this should be straightforwardish. The main complicating factor is that we're going to have to track this through our encode/decode strategy.
For multi-output models, this is a lot more complicated and may require a custom loss function link. I asked in TF (https://github.com/keras-team/keras/issues/4735#issuecomment-696363490) if there is an easier solution for multi-output models, but I get the feeling that there is not.

I'm thinking we'll probably want to do this using https://scikit-learn.org/stable/modules/generated/sklearn.utils.class_weight.compute_sample_weight.html instead of relying on Keras. We'll just apply class_weights first then sample_weights.


ARROW-7905: [Go][Parquet] Initial Chunk of Parquet port to Go

Based on the c++ implementation but tuned and optimized for Go, I spent the first couple months this year creating a Go implementation for Parquet with the goal of native/easy integration with the Arrow library while still being highly performant and at minimum reaching feature parity with the C++ implementation.
Based on the conversations on the JIRA card, rather than dumping a huge code bomb (there's a ton), I've chunked it up. This is the initial chunk of code comprising of an internal utils directory that is analogous to the cpp/arrow/utils/ bit readers/writers/bit run readers/etc. which were ultimately used by the go implementation, while using c2goasm to reach the performance necessary for certain areas.
This is part 1 of the implementation as I chunk it up and push it out. I'll wait for each chunk to get merged before pushing the next PR in order to make sure that everything stays in sync.
CC: @emkornfield @wesm @sbinet @nickpoorman

@emkornfield sure, that's easy. i didn't realize i was gonna have to do it until the actions were failing haha.

@emkornfield filed as #9675

@sbinet @emkornfield I've updated this to include the changes to bump to go1.15 so now this is ready for reviews. After this gets merged, i'll push the next chunk of code. Sorry for the size of this one but it was the smallest i could easily make it as a self contained piece that doesn't rely on other chunks. It's a foundational piece while the rest of the chunks will be a lot smaller.

Regarding assembly, didn't realize Go was already doing this, if it is consistent with existing patterns makes sense to keep it.

rebased branch with master, hopefully that fixes the failing check :)

@emkornfield @sbinet any luck getting more reviews on this so i can get it merged and post the next chunk? :)

One more small nit.  Could you create a new sub-jira issue for this PR?  We generally like to maintain 1-1 mapping from JIRA to PRs

@emkornfield When you say "sub-jira issue" do you mean a sub-issue on the linked issue? Or just a new JIRA issue in general? If it's a new JIRA issue altogether, should it be under the "PARQUET" jira instead of the ARROW one?

@emkornfield When you say "sub-jira issue" do you mean a sub-issue on the linked issue?

Yes, I think this will be the cleanest (it should give you a new ID).

@emkornfield done and updated the title of this PR. :) Also pushed changes based on your suggestions

@emkornfield Just checking in, if there are no comments by @sbinet or @nickpoorman  would we be able to get this merged either today or tomorrow? I have the next chunk ready to go, it's also much smaller than this one haha.

Yes, I'll merge tomorrow if no further comments.


ARR: Update emergency aggregate score workflow

When a user submits an emergency reviewer or metareviewer form, the process function updates all aggregate scores by adding 10, but this destroys the meaning of the previous aggregate scores, especially when the emergency reviewing period has not yet started.
The new proposed solution is to compute aggregate scores by:

Posting these scores to a new edge invitation Emergency_Score
Sum across the affinity scores, instead of just the aggregate scores
Wait until the reviewing deadline passes, and then compute the scores to avoid confusion during the regular reassignment period

Let's use the same value than the Aggregate Score and post a new edge with the invitation Emergency_Score.
The edge browser will let users to sort reviewers by Emergency_Score.

Resolved by #2185


fix: fix handling null custom metadata values in delegations

Ultimately, this fixes signature verification for delegated target metadata files.
I noticed that we were adding "custom": null values into the targets in https://github.com/sigstore/root-signing/pull/742
		"targets": {
			"registry.npmjs.org/keys.json": {
				"length": 686,
				"hashes": {
					"sha256": "b9a18e4adde4a133526766b53f3519fd93e1531a71ade2ab30f3b4faeb0d7cdf",
					"sha512": "e1db855026127f6b824bf1a36f7b2a749a225decac3e7d10655fac8f2d7c23b770e2a7d609ea265a74788d944bbab9aca90655e509347930c8a11786715ce517"
				},
				"custom": null
			}
		}

This does not occur in the top-level targets, even when custom metadata is empty, as it is for trusted_root. Debugging, I found:

Unmarshalling null values in YAML results in the "null" KEYWORD string, which was causing a STRING value null metadata for the delegations.
This does not show in top-level targets because we happen to marshal into JSON by hand, which  removes the payload here
The delegation addition code uses go-tuf repository API, and for whatever reason, the null value is not removed in their marshalling
This failed signature verification, because when you construct the signature, you read and marshal into canonical JSON - the "null" then disappears, and the signature payload has the "custom": null payload removed.

I considered manipulating the method where we read the config by re-marshaling it through JSON and back but it didn't remove the null value because we were using a json.RawMessage.
Finally, I decided to change the json.RawMessage to a pointer instead, which would be nil if the custom metadata was nil, rather than write a null string.
The only alternative would be to re-marshal the final target metadata as JSON and write that back to the store, but I figured this is more clear for a user who does not understand internals.

The code looks good. Nice work @asraa 🎉
Just one nit, would it make sense to add a regression test that serializes a delegation to JSON and then we inspect that to see that no "cusom": null exists?

serializes a delegation to JSON and then we inspect that to see that no "cusom": null exists?

Yes! I could do a string comparison on the stored metadata!


Worker continues to dequeue jobs even though the worker has been sent a shutdown signal

While working on a fuse deployment I noticed the helm apply was taking a long time. I found the new worker pod was pending waiting for the old pod to shutdown. The old pod was still running and was still dequeueing jobs so there appears to be an issue with how we are processing shutdown signals. Screenshot below was the logs of the old worker.

We are using sqlq now


Auto reveal the file in errors view on open

Auto reveal the file in errors view on open

@sandy081 should probably reuse explorer.autoReveal rather than adding a new config imo.

@Tyriar Yah I thought so initially and in favor of doing that. But I felt users would like to have a separate conf as they are two independent features.
I will also take the team's opinion today and change it as per that.
Thanks.

@Tyriar this is to reveal the file in the errors view not the explorer.
Separate setting makes sense to me. problems.autoReveal, boolean.


kubeflow deploy deadlocks after deploying admission-webhook

Running the following script:
https://github.com/mlopsworks/charms/blob/main/integration_test_microk8s
On Ubuntu 20.10, I get a kubeflow setup that's stuck:

kubectl get events -A

is full of:
controller-micro   4m23s       Warning   FailedCreate              statefulset/argo-controller-operator                          create Pod argo-controller-operator-0 in StatefulSet argo-controller-operator failed error: Internal error occurred: failed calling webhook "admission-webhook.kubeflow.org": Post "https://admission-webhook.controller.svc:443/apply-poddefault?timeout=30s": service "admission-webhook" not found
controller-micro   3m55s       Warning   FailedCreate              statefulset/dex-auth-operator                                 create Pod dex-auth-operator-0 in StatefulSet dex-auth-operator failed error: Internal error occurred: failed calling webhook "admission-webhook.kubeflow.org": Post "https://admission-webhook.controller.svc:443/apply-poddefault?timeout=30s": service "admission-webhook" not found
controller-micro   3m53s       Warning   FailedCreate              statefulset/istio-ingressgateway-operator                     create Pod istio-ingressgateway-operator-0 in StatefulSet istio-ingressgateway-operator failed error: Internal error occurred: failed calling webhook "admission-webhook.kubeflow.org": Post "https://admission-webhook.controller.svc:443/apply-poddefault?timeout=30s": service "admission-webhook" not found
controller-micro   3m50s       Warning   FailedCreate              statefulset/istio-pilot-operator                              create Pod istio-pilot-operator-0 in StatefulSet istio-pilot-operator failed error: Internal error occurred: failed calling webhook "admission-webhook.kubeflow.org": Post "https://admission-webhook.controller.svc:443/apply-poddefault?timeout=30s": service "admission-webhook" not found

the admission-webhook pod seems fine:
luke@mind:~/pc/charms$ kubectl logs admission-webhook-5bb76f79f7-7k5jk -n controller-micro
I0521 15:25:54.607026       1 main.go:552] About to start serving webhooks: &http.Server{Addr:":443", Handler:http.Handler(nil), TLSConfig:(*tls.Config)(0xc0001e1b00), ReadTimeout:0, ReadHeaderTimeout:0, WriteTimeout:0, IdleTimeout:0, MaxHeaderBytes:0, TLSNextProto:map[string]func(*http.Server, *tls.Conn, http.Handler)(nil), ConnState:(func(net.Conn, http.ConnState))(nil), ErrorLog:(*log.Logger)(nil), disableKeepAlives:0, inShutdown:0, nextProtoOnce:sync.Once{m:sync.Mutex{state:0, sema:0x0}, done:0x0}, nextProtoErr:error(nil), mu:sync.Mutex{state:0, sema:0x0}, listeners:map[*net.Listener]struct {}(nil), activeConn:map[*http.conn]struct {}(nil), doneChan:(chan struct {})(nil), onShutdown:[]func()(nil)}

there is an admission-webhook service...
luke@mind:~/pc/charms$ kubectl get services -A|grep admission-webhook
controller-micro   admission-webhook-operator           ClusterIP   <IP_ADDRESS>    <none>        30666/TCP                17m
controller-micro   admission-webhook                    ClusterIP   <IP_ADDRESS>   <none>        443/TCP                  16m

so I'm not sure why k8s is not finding it!

I've been able to reproduce this over in https://github.com/canonical/notebook-operators/pull/11. The workaround that works for that use case is to just create the PodDefaults CRD manually, since that's why we're deploying admission-webhook in CI. It looks like the underlying cause is that the webhook is listening to all Pod creation with failurePolicy: Fail set, calls the admission-webhook service, which encounters this error:
E0624 20:13:30.638635       1 main.go:427] error fetching poddefaults: poddefaults.kubeflow.org is forbidden: User "system:serviceaccount:kubeflow:admission-webhook" cannot list resource "poddefaults" in API group "kubeflow.org" at the cluster scope

Looking at ClusterRoles, I see that kubeflow-admission-webhook was created, but no corresponding ClusterRoleBinding was created. This is in spite of the pod spec specifying global: True, so we'll have to dig deeper into what's going on there.

Filed https://bugs.launchpad.net/juju/+bug/1934180 to track the ClusterRoleBinding creation issue

The linked bug by @knkski has been fixed, please reopen if it still applies.


Use inplace_it in Vulkan for alloca

We have this performance issue in Vulkan backend that gfx-rs API is based on iterators, and Ash expects slices, so we need some extremely lightweight way of producing a slice, sometimes without knowing anything about the number of elements. Basically, we want alloca, but it's not available in Rust.
However there is a simple crate that does something similar - https://github.com/NotIntMan/inplace_it . We should try it out and see if we can remove all the heap allocations from hot paths of the Vulkan backend, and possibly in other backends too.

doesnt it require knowing number of elements upfront? and that requires walking iterator twice, is that acceptable?
https://docs.rs/inplace_it/0.3.0/inplace_it/fn.inplace_or_alloc_array.html

Good point! Problem with walking twice is that an iterator may not necessarily be clonable, i.e. it can have side effects...
How do you feel about changing the relevant gfx-hal API signatures to require ExactSizeIterator instead of a regular iterator? That would give us the size.

How do you feel

i dont have much experience with graphics so i have no opinions on this, ExactSizeIterator works for me :+1:

@khodzha would you want to try making this API change? This could be interesting experience. I think there are other opportunities in backends to take advantage of the size, so it would be an all-around win.

yeah i can do that


Don't even show coverage step when not configured

Coverage is ... complicated ... currently, because of a bunch of restrictions that Azure Pipelines places on us. In particular, we don't have access to the value of variables in templates, among many other things. This is the reason why we delay deciding whether or not to run coverage all the way until in the very same job. Making it work any other way would require fixes to https://github.com/MicrosoftDocs/vsts-docs/issues/4841, https://github.com/MicrosoftDocs/vsts-docs/issues/4466, and https://developercommunity.visualstudio.com/content/problem/642219/setting-output-variable-when-multiple-stages-share.html.
However, there Is one thing we can do better -- don't include the coverage stage if codecov_token isn't even set.

Fixed in 41f142e4f0e7a901945443cfeeeeea6e7ad3973e


brew install git not working due to code signing

Bug report
Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

[x] ran brew update and can still reproduce the problem?
[x] ran brew doctor, fixed all issues and can still reproduce the problem?
[x] ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)
Install git through homebrew, since I wanted the latest version of git, outside of Xcode tools.

After installing homebrew git:

amir@MacBook-Pro ~ % brew config
HOMEBREW_VERSION: >=2.5.0 (shallow or no git repository)
ORIGIN: (none)
HEAD: (none)
Last commit: never
Core tap ORIGIN: (none)
Core tap HEAD: (none)
Core tap last commit: never
Core tap branch: (none)
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_MAKE_JOBS: 8
Homebrew Ruby: 2.6.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: octa-core 64-bit arm_firestorm_icestorm
Clang: 12.0 build 1200
Git: N/A
Curl: 7.64.1 => /usr/bin/curl
macOS: 11.1-arm64
CLT: <IP_ADDRESS>.1.1607026830
Xcode: 12.3
Rosetta 2: false
amir@MacBook-Pro ~ % brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry or file an issue; just ignore this. Thanks!

Warning: Git could not be found in your PATH.
Homebrew uses Git for several internal functions, and some formulae use Git
checkouts instead of stable tarballs. You may want to install Git:
  brew install git

Output inside of console app:
Process:               git [39989]
Path:                  /opt/homebrew/*/git
Identifier:            git
Version:               0
Code Type:             ARM-64 (Native)
Parent Process:        ??? [39988]
Responsible:           Terminal [4727]
User ID:               501

Date/Time:             2021-01-06 21:33:25.730 -0500
OS Version:            macOS 11.1 (20C69)
Report Version:        12
Anonymous UUID:        DDD96244-4EB1-C47A-8341-42A370298A10

Sleep/Wake UUID:       A7A99696-AC91-40D1-B8C2-5AAB3DC80DAF

Time Awake Since Boot: 7500 seconds
Time Since Wake:       700 seconds

System Integrity Protection: enabled

Crashed Thread:        0

Exception Type:        EXC_BAD_ACCESS (Code Signature Invalid)
Exception Codes:       0x0000000000000032, 0x000000010067c000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    Namespace CODESIGNING, Code 0x2

kernel messages:

VM Regions Near 0x10067c000:
    __LINKEDIT                  100614000-10067c000    [  416K] r--/r-- SM=COW  /opt/homebrew/*
--> mapped file                 10067c000-100680000    [   16K] r--/r-x SM=PRV  Object_id=eee77d8d
    __TEXT                      100688000-1006d0000    [  288K] r-x/rwx SM=COW  /opt/homebrew/*/*.dylib

Application Specific Information:
dyld: launch, loading dependent libraries
/opt/homebrew/opt/gettext/lib/libintl.8.dylib

Thread 0 Crashed:
0   dyld                          	0x0000000100a48780 bcmp + 16
1   dyld                          	0x0000000100a09408 ImageLoaderMachO::validateFirstPages(linkedit_data_command const*, int, unsigned char const*, unsigned long, long long, ImageLoader::LinkContext const&) + 136
2   dyld                          	0x0000000100a103b8 ImageLoaderMachOCompressed::instantiateFromFile(char const*, int, unsigned char const*, unsigned long, unsigned long long, unsigned long long, stat const&, unsigned int, unsigned int, linkedit_data_command const*, encryption_info_command const*, ImageLoader::LinkContext const&) + 268
3   dyld                          	0x0000000100a07ffc ImageLoaderMachO::instantiateFromFile(char const*, int, unsigned char const*, unsigned long, unsigned long long, unsigned long long, stat const&, ImageLoader::LinkContext const&) + 172
4   dyld                          	0x00000001009f0290 dyld::loadPhase6(int, stat const&, char const*, dyld::LoadContext const&) + 668
5   dyld                          	0x00000001009f8dd8 dyld::loadPhase5(char const*, char const*, dyld::LoadContext const&, unsigned int&, std::__1::vector<char const*, std::__1::allocator<char const*> >*) + 1328
6   dyld                          	0x00000001009f8824 dyld::loadPhase4(char const*, char const*, dyld::LoadContext const&, unsigned int&, std::__1::vector<char const*, std::__1::allocator<char const*> >*) + 208
7   dyld                          	0x00000001009f8530 dyld::loadPhase3(char const*, char const*, dyld::LoadContext const&, unsigned int&, std::__1::vector<char const*, std::__1::allocator<char const*> >*) + 1100
8   dyld                          	0x00000001009f7cf0 dyld::loadPhase1(char const*, char const*, dyld::LoadContext const&, unsigned int&, std::__1::vector<char const*, std::__1::allocator<char const*> >*) + 212
9   dyld                          	0x00000001009efe0c dyld::loadPhase0(char const*, char const*, dyld::LoadContext const&, unsigned int&, std::__1::vector<char const*, std::__1::allocator<char const*> >*) + 468
10  dyld                          	0x00000001009ef9b0 dyld::load(char const*, dyld::LoadContext const&, unsigned int&) + 196
11  dyld                          	0x00000001009f977c dyld::libraryLocator(char const*, bool, char const*, ImageLoader::RPathChain const*, unsigned int&) + 56
12  dyld                          	0x0000000100a039d4 ImageLoader::recursiveLoadLibraries(ImageLoader::LinkContext const&, bool, ImageLoader::RPathChain const&, char const*) + 344
13  dyld                          	0x0000000100a021ac ImageLoader::link(ImageLoader::LinkContext const&, bool, bool, bool, ImageLoader::RPathChain const&, char const*) + 160
14  dyld                          	0x00000001009f25f4 dyld::link(ImageLoader*, bool, bool, ImageLoader::RPathChain const&, unsigned int) + 328
15  dyld                          	0x00000001009f4928 dyld::_main(macho_header const*, unsigned long, int, char const**, char const**, char const**, unsigned long*) + 6764
16  dyld                          	0x00000001009ed258 dyldbootstrap::start(dyld3::MachOLoaded const*, int, char const**, dyld3::MachOLoaded const*, unsigned long*) + 476
17  dyld                          	0x00000001009ed038 _dyld_start + 56

Thread 0 crashed with ARM Thread State (64-bit):
    x0: 0x000000010067c000   x1: 0x000000016faa5c30   x2: 0x0000000000000770   x3: 0x0000000000040001
    x4: 0x0000000000000003   x5: 0x0000000000000000   x6: 0x0000000100a70280   x7: 0x0000000000000000
    x8: 0x0000000000000000   x9: 0x000000016faa6278  x10: 0x0000000000000001  x11: 0x0001803000000000
   x12: 0x0000000000000032  x13: 0x0004000000000000  x14: 0x0000000000016700  x15: 0x000000016faa61f8
   x16: 0x00000000000000c5  x17: 0x0000000000000000  x18: 0x0000000000000000  x19: 0x0000000100a75870
   x20: 0x0000000000000780  x21: 0x000000016faa5c30  x22: 0x000000010067c000  x23: 0x0000000000000003
   x24: 0x000000016faa63a0  x25: 0x000000016faadd48  x26: 0x0000000100350728  x27: 0x000000016faa5c30
   x28: 0x0000000000000003   fp: 0x000000016faa5630   lr: 0x0000000100a09408
    sp: 0x000000016faa55f0   pc: 0x0000000100a48780 cpsr: 0x20000000
   far: 0x000000010067c000  esr: 0x92000007

Binary Images:
       0x100350000 -        0x1005abfff +git (0) <B0DB1773-55C2-3C00-98A0-1B286E9293D1> /opt/homebrew/*/git
       0x100688000 -        0x1006cffff +libpcre2-8.0.dylib (0) <624DA598-A969-3530-9EAA-CF9E6CFDED28> /opt/homebrew/*/libpcre2-8.0.dylib
       0x1009ec000 -        0x100a67fff  dyld (832.7.1) <B7DB9E8A-A898-3C11-91A0-2B0264F05CB6> /usr/lib/dyld
       0x1a6aa5000 -        0x1a6ab6fff  libz.1.dylib (76) <5EA0F5F6-7974-3DF8-9862-CE916C5EC980> /usr/lib/libz.1.dylib
       0x1a6b91000 -        0x1a6c83fff  libiconv.2.dylib (59) <B745BF03-D15C-3B71-9774-894201EC76CF> /usr/lib/libiconv.2.dylib

External Modification Summary:
  Calls made by other processes targeting this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by this process:
    task_for_pid: 0
    thread_create: 0
    thread_set_state: 0
  Calls made by all processes on this machine:
    task_for_pid: 6186
    thread_create: 0
    thread_set_state: 0

VM Region Summary:
ReadOnly portion of Libraries: Total=484.2M resident=0K(0%) swapped_out_or_unallocated=484.2M(100%)
Writable regions: Total=8704K written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=8704K(100%)

                                VIRTUAL   REGION
REGION TYPE                        SIZE    COUNT (non-coalesced)
===========                     =======  =======
STACK GUARD                       56.0M        1
Stack                             8176K        1
__AUTH_CONST                         6K        2
__DATA                             624K        6
__DATA_CONST                        80K        5
__LINKEDIT                       480.1M        5
__TEXT                            4244K        5
mapped file                         16K        1
===========                     =======  =======
TOTAL                            548.9M       26

Deleting git, pcre2, and gettext and reinstalling them fixed it.

Deleting git, pcre2, and gettext and reinstalling them fixed it.

Worked for me too.
brew reinstall git
brew reinstall pcre2
brew reinstall gettext

See also #10275.


Change nox backend to uv

Description
Change nox backend to uv and updates nox with optional dependency.
Issue reference
Fixes #286
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:

Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

[ ] New Feature: A non-breaking change that adds new functionality.
[ ] Optimization: A code change that improves performance.
[ ] Examples: A change to existing or additional examples.
[ ] Bug Fix: A non-breaking change that addresses an issue.
[ ] Documentation: Updates to documentation or new documentation for new features.
[ ] Refactoring: Non-functional changes that improve the codebase.
[ ] Style: Non-functional changes related to code style (formatting, naming, etc).
[X] Testing: Additional tests to improve coverage or confirm functionality.
[ ] Other: (Insert description of change)

Key checklist:

[ ] No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
[ ] All unit tests pass: $ nox -s tests
[ ] The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.
Further checks:

[ ] Code is well-commented, especially in complex or unclear areas.
[ ] Added tests that prove my fix is effective or that my feature works.
[ ] Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

I've decided to merge this, as the local testing suite time is becoming combersome. If anyone finds issues with uv and is looking at this PR, please open an issue.


Increase PipelineRun timeout

The container build task in the PipelineRuns can take a long time to finish. The default 1h timeout is insufficient for running the remaining tasks. Updated the timeout to 1h30m to ensure successful completion.

+1


Option to disable "indent = blockquote"

Context
I wish it to render normally as with other themes. E.g.
  - my
  - bullet list

to be same as
- my
- bullet list

to avoid refactoring just for this theme, also I prefer indented for .py files (sphinx-gallery).
Proposal
html_theme_options = {
  'indent_is_blockquote': False,
}

Tasks and updates
No response

Hmm I see it's always blockquote so it's .blockquote CSS that should change.


Unable to get radiobuttons by name

As it says above

Fixed by 2d59436

Confirmed that the issue has been addressed


Portis/Torus issues with Brave/Safari (3rd party cookies)

ISSUE relates to the below items

Signup: mac OS safari bug - portis - stuck in a loop #6349
Signup: macOS Safari & Brave bug - torus #6350
Signup & login with portis - not working in Brave macOS #6354

I closed the above issues to consolidate here
ISSUE Brave
Requirement:
In order to use Portis or Torus with Safari, currently the users needs to turn off Shield in Brave.
Shields DOWN for this site

If you login with Portis you will see the below. [as of PR #6387]

If you login with Torus you will see the below.

ISSUE Safari
Requirement
In order to use Portis or Torus with Safari, currently the users needs to uncheck Prevent Cross-site tracking enabled

Currently if a user tries to login with Portis we don't show the 3rd party cookie error. This is an issue I need to bring up with Portis. [#6349]
Currently if a user tries to login with Torus they will see the below.

SUGGESTED FIXES

On Safari/Brave we disable Portis/Torus and only show Fortmatic
On Safari/Brave we should a caution/help icon besides login method with a tooltip and explain how to make browser compatible
On Safari/Brave we show a extra modal (Login, or on page load) that explains what they need to do to make browser compatible with Augur

options continued:

If we can detect whether cookies are not enabled then show a message or modal that explains how to proceed

Figma
We're going with solution 4.
If user is using Brave or Safari and tries to login/signup with portis or torus:

We will determine if the have cookies enabled
If they don't have cookies enabled we will display a modal that explains they need to enabled cookies and display a "learn more" link with instructions on how to do this (link below)
If they have cookies enabled the flow will proceed as normal

Learn more link:
https://www.whatismybrowser.com/guides/how-to-enable-cookies/?utm_source=whatismybrowsercom&utm_medium=internal&utm_campaign=breadcrumbs


Player profile: stats

Make a profile page with  :

stats : best score
countries visited
...

Ressources :
props:history in src/pages/Home.vue

I'd like to help with that. Can you assign it to me?

Of course 😃

If you want some ressources, you can take a look on :
https://www.figma.com/file/AhxfXiZ9Y21yqju7LL7Nnc/Geoguess-2?node-id=0%3A1


chore: release 2.12.0

:robot: I have created a release *beep* *boop*
2.12.0 (2024-11-07)
Features

export: export images concurrently(#6395) (de2f4a3)

Reverts

release werf images for linux/arm64 platform (5295af2)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/werf/werf/releases/tag/v2.12.0 :sunflower:


Session options IdleTimeout is not working

I used the code:
services.AddSession(options =>
{
    options.CookieHttpOnly = true;
    options.IdleTimeout = TimeSpan.FromDays(7);
});

But session cookie Expires always session, not the time after 7 days.

Same problem.
Is any way to set cookie's expire time at https://github.com/aspnet/Session/blob/dev/src/Microsoft.AspNetCore.Session/SessionMiddleware.cs#L153-L168 ?

https://github.com/aspnet/Session/issues/132
https://github.com/aspnet/Session/blob/dev/src/Microsoft.AspNetCore.Session/SessionOptions.cs#L45-L46

Would you tell us, how to set the session cookie timeout? Very thanks. We are using .Net core 2.0 preview.

The session cookie by definition has no timeout, it lasts for the lifetime of the browser session. The IdleTimeout lets you control how long data persists on your server which is the only aspect it is ever possible for you to maintain control over.

Very thanks~


Legend controls

Work in progress!

[x] adds legend parameter to MapViz to control legend visibility (defaults to True for all viz classes except HeatmapViz, RasterTilesViz and ImageViz)
[x] moves legend div creation to JS
[x] refine CSS style for default legend
[x] horizontal legend style
[x] continuous gradient legend
[ ] variable radius legend

May leave these for map-collections pr:

[ ] multi-layer legends
[ ] multi-variable legends

The new Mapbox attribution icon takes up a ton of room, which makes the legend look out of place.  Looking for suggestions on how to rearrange legend and other map info/controls!

Nice, that legend design looks great @akacarlyann!  Huge improvement.  🙏

Looking for suggestions on how to rearrange legend and other map info/controls!

Lots of options here - what about putting both the attribution and legend at the bottom of the map, and move the attribution icon to the left of the legend?

Thought heatmaps could benefit from a continuous legend titled using weight_property .  Implementation is clunky atm and assumes evenly spaced colors/stops.

Looks good as a starting point @akacarlyann.
The hard part with Heatmaps is that the color is not a perfect representation of the values specified in the legend, since the kernel density calculation sums up all values in the specified heatmap-radius region to calculate the color.
We could solve that by clustering & aggregating the underlying data, and choosing a heatmap-radius to match the cluster-radius, so that the kernel density calculation is close to an exact representation of the color shown on the screen.

@ryanbaumann Got it. I think I'll roll back the heatmap legend for now and leave that for someone's future PR since it will be more involved. I'll try to get the variable-radius legend in this week and I'll let you know when it's ready for review!

No rush - we'll have more bandwidth here starting next week too.

@akacarlyann the latest changes look great!  Are you ready for a review?

@ryanbaumann Really close! I have a couple moving parts - setting a default shape for legend keys in each viz type and supporting circular legend keys in the horizontal layout. Happy to take any comments now but I should have those last pieces done by Wed, I think!

@ryanbaumann Ready for a review on this :)

🎉


forward recovery with delay

given
saga is up & running
when
saga receives a request with forward recovery
a transaction in the request fails
then
saga delays retryDelay seconds specified in the request before each retry

https://github.com/ServiceComb/ServiceComb-Saga/pull/27


Adds support for building a standalone version

My experience with browserify and gulp is limited. I was (maybe therefore?) unable to build a gulp command that would make a standalone version of this project. So instead I build an npm command which does the job.
I also changed the readme a bit to explain how to use the standalone version.
I moved style.css to the dist folder, since it's a build version of the scss-file. I think it would be nice to have a command for building the sass in this project. This could be added to the npm run build command from this pull request.

Fixes #27

Also added the standalone file itself now, so a user can simply download this repo and use it, without needing to build anything or the like


Add test data

We need a small test dataset for the whole pipeline, following nf-core guides.
I think this could be just two chromosomes (or parts of chromosomes that are orthologous). Could be super small, like 10000bp total. I am pretty sure all the code will work on tiny chromosomes.

Hopefully done here:
https://github.com/nf-core/test-datasets/pull/1339
Used just two mycoplasma genomes 2000 lines, and 300 lines of their gff files. Maybe a little too small, but working with gffread and orthofinder.

We should probably use the 4 field format, whether running with local files or RefSeq IDs

See nf-core/test-datasets#1343

Add test profile to pipeline.


check for nil Name field in attr APIs

The code which builds the input shapes for the GET_ATTRIBUTES and SET_ATTRIBUTES operations for attribute-based APIs was checking for a Name or ID field in order to set the value for ARN fields in the input shapes. However, some resources, like SNS' Subscription resources, do not have a Name or ID field.
This resulted in nil pointer dereferencing and panics when building the controller for SNS Subscriptions.
This patch simply double-checks that the *string returned from the CRD.SpecIdentifierField() method is not nil before adding in the Go code that constructs an ARN from a Name or ID field.
Related: aws-controllers-k8s/community#1491
Signed-off-by: Jay Pipes<EMAIL_ADDRESS>By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/ok-to-test


Deprecate the 'Synced' status condition

What problem are you facing?

Most Crossplane resources (managed, claims, composites, etc) typically expose two types of status condition:

Ready indicates whether the thing being reconciled (e.g. the external resource) is expected to be functional.
Synced indicates whether the most recent reconcile attempt succeeded or failed, including any error.

Sometimes Ready goes by different names - e.g. Established for XRDs.
Originally Crossplane only had a Ready condition, but it was conceptually conflated with "synced" and attempted to reflect both whether the underlying resource was ready and whether Crossplane was successfully able to reconcile the underlying resource. The Synced condition has served us well for some time, but I think it should be removed because:

It's duplicated by events. Anecdotally, we emit an event corresponding to ~95% of our SetConditions calls.
It's duplicated by debug logs in the other ~5% of cases, which are 'internal' errors like being unable to remove a finalizer.
It's a footgun when writing multiple controllers that reconcile the same kind of resource.

The apiextensions 'definition' and 'offered' controllers are examples of the latter issue. Both controllers collaborate to reconcile a CompositeResourceDefinition. The definition controller manages the lifecycle of the defined composite resource and its controller, while the offered controller manages the lifecycle of the offered resource claim (if any) and its controller. Currently both reconcilers attempt to set the Synced condition of the XRD; if one controller was reconciling successfully and the other was encountering an error they would get stuck in a tight reconcile loop.
How could Crossplane help solve your problem?

I suggest we deprecate and stop using the Synced condition in any reconciler that has been updated to emit events and logs.

I believe conditions are most useful in machine to machine communication, which is not really what events/logs are for. However, Synced doesn't really mean much for other controllers or systems, at least I haven't seen us writing code to check Synced condition, it's mostly the Ready one. So, in the places we're able to communicate that there is a misconfiguration problem to the user via another mechanism like event, I agree that we don't need Synced condition.

Hmm, actually UI systems are usually built using YAML output of the resources, which do not have the events. So that's a machine usage of the Synced condition; to show user that there is a misconfiguration through the UI. I believe Upbound Cloud is built this way. I went to look at Pod to see what conditions it has:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: "2020-09-03T15:12:15Z"
    status: "True"
    type: Initialized
  - lastProbeTime: null
    lastTransitionTime: "2020-09-10T07:54:42Z"
    status: "True"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: "2020-09-10T07:54:42Z"
    status: "True"
    type: ContainersReady
  - lastProbeTime: null
    lastTransitionTime: "2020-09-03T15:12:15Z"
    status: "True"
    type: PodScheduled

From what I can tell, there is an abundance of conditions which also have corresponding events published. So, it comes down to whether we'd like the YAML, i.e. etcd record of the resource, to fully represent everything we know about it at the time of printing or not. I generally lean towards abundance of information as long as it's easy to keep it all in sync. Maybe merge errors that we report under Synced into Ready condition? i.e. look at Ready condition for all kinds of errors we are able to report?

Maybe merge errors that we report under Synced into Ready condition? i.e. look at Ready condition for all kinds of errors we are able to report?

This sounds like how Crossplane originally used conditions, which we found to be overloaded and confusing. A controller encountering an error during reconciliation doesn't necessarily mean that the external resource is not ready; they're two different things.

I believe conditions are most useful in machine to machine communication, which is not really what events/logs are for.

I believe machine to machine communication is in scope for events. They're actually a resource like any other, e.g.:
# $ kubectl get event -o yaml compositepostgresqlinstances.database.example.org.16338ed5a523dfe0
apiVersion: v1
count: 2487
eventTime: null
firstTimestamp: "2020-09-10T23:09:00Z"
involvedObject:
  apiVersion: apiextensions.crossplane.io/v1alpha1
  kind: CompositeResourceDefinition
  name: compositepostgresqlinstances.database.example.org
  resourceVersion: "3241413"
  uid: e29f6357-fe42-4a4b-9f9b-781e0efc1d96
kind: Event
lastTimestamp: "2020-09-11T01:14:02Z"
message: Rendered composite resource claim CustomResourceDefinition
metadata:
  creationTimestamp: "2020-09-10T23:09:00Z"
  name: compositepostgresqlinstances.database.example.org.16338ed5a523dfe0
  namespace: default
  resourceVersion: "3371564"
  selfLink: /api/v1/namespaces/default/events/compositepostgresqlinstances.database.example.org.16338ed5a523dfe0
  uid: 2f76e628-d381-41a3-a0e8-9132504fd16b
reason: RenderCRD
reportingComponent: ""
reportingInstance: ""
source:
  component: offered/compositeresourcedefinition.apiextensions.crossplane.io
type: Normal

The events API supports filtering using field selectors on the involvedObject API, and the event API object is like a more detailed status condition. To me this means the functionality is basically a superset of conditions, because you can also see historical transitions rather than just the current state.

From @hasheddan on https://github.com/crossplane/crossplane/pull/1721:

I wonder if we could just confine synced to resources that talk to APIs outside of the cluster?

I think it's appropriate to remove Synced everywhere; even for external resources. I think they're still redundant as long as we emit an event whenever we would have set the Synced condition.

I think those conditions are quite useful. Especially in combination with additionalPrinterColumns because they allow you to quickly distinguish between reconcile errors and external resources that are not ready yet without having to `kubectl describe´ into the resource.
If setting these conditions does not cause any issues I would prefer to keep them. In addition to that I would propose to add the synced condition/column to XRCs and XRs as well: https://github.com/crossplane/crossplane/issues/2850

https://kpt.dev/reference/schema/crd-status-convention/
More prior art - looks like the kpt folks recommend something similar.

My .02 - I like having SYNCED because it tells me whether I need to fix something to get the resource to reconcile properly and it's easy to see in kubectl get output.  If all I have is READY=False and I have to pull logs or events to find out why it would be a lot more effort.  The combination of SYNCED and READY makes it easy to know where to focus my attention when something isn't working properly.


Makes signs created by other plugins invisible

If you do something relating to buildertools that edits the world, places blocks, removes them, anything like that, the signs related to other plugins will be invisible. They still work, but of course, you can't really tell they're there because you can't see them.

Close this, this is an issue with Pocketmine itself...

#26


feat: add transpile option

Description
Add transpile option to transpile the code inside of generated router.ts to ESNext javascript code.
Motivation
Fixes #156, as this will allow the generouted plugin to be used in vanilla javascript codebases. This feature is meant to be used in combination with the output option to generate a router.js file.

@ferretwithaberet Thanks for opening the PR.
I've commented on the original issue, disabling the router.ts generation can be acheived easily by skipping the plugin usage at the vite.config.js — the exports can be used instead directly from react-router-dom. It's not recommended as you still can benefit from the generated types in JavaScript project with jsconfig.json or specific editor integration.
Removing the types from the file generated specifically for types would be unnecessary option.
Hope you find that helpful, thanks!


Add support for specifying sinkoptions when creating stackdriver sink

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zackbutcher
If they are not already assigned, you can assign the PR to them by writing /assign @zackbutcher in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
d1fbfabee5e08d4dd41417f28504ed2f91cc53ab
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9e99a74c1e0cde424c5e7b836809c7a4b811a19c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
9e99a74c1e0cde424c5e7b836809c7a4b811a19c
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
9e99a74c1e0cde424c5e7b836809c7a4b811a19c
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
df559225f7cc45b158d8034ca63d07f1eb3cc205
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
df559225f7cc45b158d8034ca63d07f1eb3cc205
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-pilot-multicluster-e2e.sh
df559225f7cc45b158d8034ca63d07f1eb3cc205
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
13dea19c01c1a2a2cac1b73fc8464212784cbe6c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
13dea19c01c1a2a2cac1b73fc8464212784cbe6c
link
/test istio-unit-tests

prow/istio-presubmit.sh
13dea19c01c1a2a2cac1b73fc8464212784cbe6c
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
13dea19c01c1a2a2cac1b73fc8464212784cbe6c
link
/test istio-presubmit

prow/istio-unit-tests.sh
13dea19c01c1a2a2cac1b73fc8464212784cbe6c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Closing this pull request as this is based out of master and re-basing it to 1.0 was pulling in dependencies from master to 1.0.
Created new pr for 1.0 -> https://github.com/istio/istio/pull/7944

Reopening as there needs to be a separate PR for master too as per https://github.com/istio/istio/issues/7672#issuecomment-413415946

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
13dea19c01c1a2a2cac1b73fc8464212784cbe6c
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gargnupur: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
13dea19c01c1a2a2cac1b73fc8464212784cbe6c
link
/test istio-unit-tests

prow/e2e-bookInfoTests-v1alpha3.sh
13dea19c01c1a2a2cac1b73fc8464212784cbe6c
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geeknoid
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gargnupur: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
d92eac3fc97dcf5d26d701d53d840a9e3dd3c7b9
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


remove unwanted extra parenthesis

What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests

Description
I found unwanted extra parenthesis in the new useTask$ Docs
Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

thanks


Menu popup opens in top monitor when using vertical monitor setup

Describe the bug
When using a vertical monitor setup (Extend) and positioning the window at the top edge of the first monitor (which align with the bottom edge of the second monitor), the menu popup opens on the second monitor. This occurs if we use a normal window and position it such that the title bar is not visible on the first monitor, and it is beneath the task bar on the second monitor, making menu close to the top edge of first monitor. Alternatively, if we use the ExtendClientAreaToDecorationsHint=true for the window and place the menu in the title bar, we would have the same issue. In both scenarios, positioning the menu bar close to the top edge of first monitor (which is the bottom edge of second monitor) results in the popup menu opening on the top monitor.
To Reproduce

Use vertical monitor setup (Extend), top edge of monitor 1 should be bottom edge of monitor 2
Clone sample project
Position the window such that the title bar is not visible on the first monitor, and it is beneath the task bar on the second monitor, making menu close to the top edge of first monitor
Click File or Edit menu

Expected behavior
We except the popup menu to open on the same monitor as the menu itself.
Avalonia version
11.1.0-beta1, 11.0.10
OS
Windows
Additional context
Vertical monitors setup (Faulty behavior)

Side by side monitors setup (Works perfect)

Can you please check 11.1 beta or at least 11.0.10?

I've tried both versions and the issue still exists (I've updated sample project to 11.1.0-beta1)

Can't reproduce on Win 11 🤷

Can't reproduce on Win 11 🤷

I made changes to sample project to make reproducing it easier, Also I checked on other systems to verify it is not related to my computer.

Now I use ExtendClientAreaToDecorationsHint="True" so the only thing todo is to while using vertical alignment as shown above, move the window to the bottom monitor (Monitor 1) and maximize it, then try to open Edit menu, strangely File menu works fin this time but I had examples that all menus opened in monitor 2.

Now I can see. The issue is gone once I Add a Margin of to the outer DockPanel, but that is a workaround if even.

Could you confirm if this occurs on a recent nightly build?


Link parsing breaks with SSH-style Git Remotes

Hello!
With the following remote configuration:
$ git remote -v
me      git@github.com:reconquest/shdoc (fetch)
me      git@github.com:reconquest/shdoc (push)

Clicking the "View Repository" button yields https://reconquest/shdoc - I expected it to redirect to https://github.com/reconquest/shdoc.

I use me instead of origin -it seems the issue was that I am using a non-standard default-remote name, and not that the remote URL is not SSH-style.

Also looking at this it seems to work for me when using me for the git remote
 ╰─λ git remote -v
me      git@github.com:reconquest/shdoc (fetch)
me      git@github.com:reconquest/shdoc (push)

Interesting - this definitely isn't the first time I have come across this issue, but I am suddently unable to reproduce...

Okay so I found an actual repro:
#!/usr/bin/env sh
git init

# GitHub allows for re-writing remote URls on the fly with 'insteadOf' and 'pushInsteadOf' fields.
# This is what trips up vscord.
git config --local --add url.'git@github.com:'.insteadOf 'gh:'
git config --local --add url.'git@github.com:'.pushInsteadOf 'gh:'
git remote add me gh:fox-projects/repro-vscode-weird-url

# vscord seems to require a "minimum git history" for showing the "View Repository" button.
# This sets that up.
touch file.txt && git add file.txt && git commit --no-edit --no-template --allow-empty-message
git commit --no-edit --no-template --allow-empty --allow-empty-message

$ git remote -v
me      git@github.com:fox-projects/repro-vscode-weird-url (fetch)
me      git@github.com:fox-projects/repro-vscode-weird-url (push)
$ cat .git/config
[core]
        repositoryformatversion = 0
        filemode = true
        bare = false
        logallrefupdates = true
[url "git@github.com:"]
        insteadOf = gh:
        pushInsteadOf = gh:
[remote "me"]
        url = gh:fox-projects/repro-vscode-weird-url
        fetch = +refs/heads/*:refs/remotes/me/*

It seems that there is a parsing error when parsing the value of remote.me.url. You might useful a similar issue/fix I made at xournalpp/xournalpp.

Thank you!


virt-handler: Add live-migration bridge pod net annotation

What this PR does / why we need it:
At some scenarios like hypershift kubevirt provider the CNI will support
doing live-migration when the VM net interface is bridged to the pod
network. This change add a annotation to allow live migration is
configured so on those scenarios.
Release note:

Add annotation for live migration and bridged pod interface

/cc @davidvossel

/retest

@kvaps fyi - with OVNK this annotation can be used.

@fabiand oh, thanks for information! ❤

I've been waiting this feature.
Just tested this annotation and I can confirmed it works with Kube-OVN CNI


API documentation update under docs.

Links to JerryScript API reference page (https://samsung.github.io/jerryscript/API/) are inserted.
JerryScript-DCO-1.0-Signed-off-by: István Kádár<EMAIL_ADDRESS>

I see it is just delete. The reference points to the removed text?

@zherczeg, yes. The markdown file of the API reference was duplicated. This PR makes the further maintenance easier. My only note is that #1099 should be merged at first. LGTM, after that.

Ok. LGTM then.

@LaszloLango , in my personal opinion, keeping API documents with source code is better then this. Historically, we moved documents from web site to source code repository. How about find the way to sync documents from source repository to web pages? Composing the web site in *.md file is one of reason for it. :)

@lemmaa, It is still in the source code repository. It's only moved to the gh-pages branch. We already had two md files for the same information (one in the master branch and one in gh-pages branch). The API reference is still in a markdown file and you can make pull requests to change it, so we can do better reviews before land. This is what @ktorpi does in nowadays. See: #1038, #1053, #1069, 1099, #1106 and #1117
I think this was your goal too, if you are referring to this issue: https://github.com/Samsung/iotjs/issues/315.  But please fix me if I misunderstood something. :)

@LaszloLango, In my comment, document with source code repository means in same branch. I think documents must be distributed with source code in single tar ball, when it releases. Is it suitable to make a single tar ball from source code and document in separate branch?
Form another point of view, version syncs between source code and document also looks complicate on separate branch.


Added Tokio 1.2.0 support.

All tests pass.
Added Tokio 1.2.0 support.
Closes #1

Thx for the help :)
Ill recompile and upload to crates.io
I haven't been using this api so i can't test the endpoints right now.


Added a comment to explain why this is going to be deprecated.

Added a comment to explain why this is going to be deprecated and where to look for an alternative.

Links should be better now.


Update composer.json

Limit dependency to v0.8.* of ellipsesynergie/api-response, since future versions are for Laravel 5, and therefore break with Laravel 4.

Thanks @alexgignac


N-level systems

In the nlevelsystems branch I already  implemented a first draft of a n-level basis and one function to create transition operators from one level to another. What other operators and states are useful for such systems?

I agree that a general multi-level basis is interesting for many applications. As of now I have not encountered any other operators that would be required. However, I am unsure whether requiring a list of energies is really the best way to initialize the basis. On the one hand, it does help you to keep track of your system (namely, which level has what energy). On the other hand, there may be occurrences where it is better to exclude the energies from the basis. For example, if you want to do a parameter scan over some energy, then there are currently two solutions: Either you initialize the basis in every step of the scan which is neither efficient nor elegant, or you define all energies that include the scanning parameter as zero and later write them explicitly (with corresponding projectors in the Hamiltonian), which is again not too elegant. This also applies to any time-dependent energies in a Hamiltonian and such.
I am, however, also not sure of any better alternatives (maybe just pass one integer that defines the size of the basis?). Nevertheless I wanted to start a discussion on this.

After thinking a little bit about it I agree that it is probably cleaner to not include the energies in the basis. First I just want to mention that creating a new basis in every step of a parameter scan or in time dependent Hamiltonians is not really a problem since creating a basis is most likely a cheap operation compared to creating the new numerical representation of the operators. Also it would definitely help to avoid mistakes involving mixing operators corresponding to different n-level systems. However, the n-level basis definitely has similarities to the fock basis and there we also don't include the energy spacing in the definition of the basis. This alone convinces me to define the nlevel basis in a similar way:
type NLevelBasis <: Basis
    shape::Vector{Int}
    N::Int
    function NLevelBasis(N::Int)
        if N < 1
            throw(DimensionMismatch())
        end
        new([N], N)
    end
end

At the moment I can think of two things that should be easy to achieve with this basis:

Creating the diagonal part of the Hamiltonian H = sum_n E_n |n><n|
For a fockbasis we can do H = omega*create(b)⊗destroy(b). I can't think of a similarly idiomatic way to do the same for this basis. My idea would be to implement something like diagonaloperator(b, energies) in general for all bases.

Transitions |n><m|
I think the current implementation is fine. Maybe we should also define this function for fock bases.

Thanks for your response and the according changes. I also think we should - for completeness and again in analogy to the fock basis - add a function for the basis states, such that you can initialize the system in state n with something like nlevelstate(b::NLevelBasis, n::Int).
As for your other comments:

A generalized diagonal operator is a good idea and should be straightforward to implement.

The current implementation of transitions does indeed work very well. For fock bases, however, I am not sure if transitions aren't better covered by raising and lowering operators. So far, I have not encountered the use of other transition operators when working with fock bases.

I updated the nlevel branch according to this discussion. Sorry David I didn't see you already implemented a nlevelstate function. Additionally I added docstrings, (sparse) documentation and a few more tests. This should be ready to merge soon #10 . Can you review @david-pl? For the diagonaloperator there now is a separate issue #9.


Rails 5.1 Support

Looks like Rails 5.1 is supported in master, but not the most recent release (0.5.0). Can we get a new release?

I'm using Rails 5.1 and I still get this warning every time I load the rails environment because of this gem:
DEPRECATION WARNING: alias_method_chain is deprecated. Please, use Module#prepend instead. From module, you can access the original method using super. (called from require at /Users/xxx/.rvm/gems/ruby-2.3.0@global/gems/bundler-1.14.6/lib/bundler/runtime.rb:91)

Is this related?

@kyleramirez Yes. If you use the master branch, that deprecation warning goes away. However, a new deprecation warning now appears:
DEPRECATION WARNING: Passing a class to the `class_name` is deprecated and will raise an ArgumentError in Rails 5.2. It eagerloads more classes than necessary and potentially creates circular dependencies. Please pass the class name as a string: `belongs_to :primary_category, class_name: 'Category'` (called from belongs_to_with_deleted at /Users/daniel/.rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/bundler/gems/acts_as_paranoid-6fabadbb31e8/lib/acts_as_paranoid/associations.rb:14)

@zzak Hi, first of all thanks for maintaining this gem! 💯
Secondly is there an estimate date of release for the next version?
We're using acts_as_paranoid in an app that uses Rails 5.1 and we'd like to depend less on Github (currently using master)  and more on Rubygems.
If I can help make this happen please let me know.

I've been depending on master for 5.1 support since June 1.

@zzak Same issue here. A new release would be great as we're doing a 5.1 upgrade. Anything we can do to help?

have you guys check this project ? https://github.com/rubysherpas/paranoia
it said

Paranoia is a re-implementation of acts_as_paranoid for Rails 3/4/5, using much, much, much less code.

Hey ya'll, thanks for letting me know as I'm always forgetting about this one :)
Will try to cut something soon! Happy new year!

bump

I ran into some issues on Rails 5.0 and had to install directly from Github. Would it be possible to get a RubyGems release with the Rails 5.0 and 5.1 fixes?

@zzak Any chance you could cut a release, or give someone else permission to do so?

@benlangfeld / @zzak
At this point, this should also support rails 5.2

@zzak +1 for @benlangfeld comment about cutting a release. Thanks in advance 👍

A new release is available: 0.6.0.


[WSL] Error: spawn cmd.exe ENOENT

Version
3.5.3
Reproduction link
https://github.com/PanJiaChen/vue-element-admin
Environment info
Win10 Sub Linux ( Ubuntu )

Steps to reproduce
yarn install
./node_modules/.bin/vue-cli-service serve
What is expected?
without error
What is actually happening?
$ ./node_modules/.bin/vue-cli-service serve
events.js:183
throw er; // Unhandled 'error' event
^
Error: spawn cmd.exe ENOENT
at _errnoException (util.js:1022:11)
at Process.ChildProcess._handle.onexit (internal/child_process.js:190:19)
at onErrorNT (internal/child_process.js:372:16)
at _combinedTickCallback (internal/process/next_tick.js:138:11)
at process._tickCallback (internal/process/next_tick.js:180:9)

Info: WSL  被错当成 Windows
WSL Mistaken for Windows

Is your WSL environment based on Debian? I’ve noticed some strange behaviours with npm in Debian Buster that I’ve not been able to reproduce with the official nodejs binaries and updated versions of npm (node is v10.15.2 and npm 5.8.0 in Debian Buster). Among those were hanging npm ci commands in GitLab runners with docker and the yarn error you’ve got when I executed vue create foo.

I think this error is related to this create-react-app issue which is caused by the way the browser is launched in WSL (using cmd.exe which is not in the PATH). The root problem may be in the opn aka open npm package.
A workaround is to add /mnt/c/Windows/System32 to your path before running the command.
e.g.:
PATH="$PATH:/mnt/c/Windows/System32"   /node_modules/.bin/vue-cli-service serve

or
export PATH="$PATH:/mnt/c/Windows/System32"
/node_modules/.bin/vue-cli-service serve

The former command will not alter your current shell while the latter will, so choose the one that suits your needs best.

edit vue.config.js
module.exports = {
  //...
  devServer: {
    open: true
  }
};

see also https://webpack.js.org/configuration/dev-server/#devserveropen


Using this option makes mutution testing to run much longer then without it. But without it result isn't correct - all mutants survive as no corresponding tests are found.
I've setup smallest repo with TS, Jest and stryker setup so that you could see the issue reproduced.
Stryker config
module.exports = {
  $schema: 'https://raw.githubusercontent.com/stryker-mutator/stryker/master/packages/api/schema/stryker-core.json',
  mutator: 'typescript',
  packageManager: 'npm',
  reporters: [ 'html', 'clear-text', 'progress', 'dashboard' ],
  testRunner: 'jest',
  coverageAnalysis: 'off',
  jest: {
    config: require('./jest.config'),
    //next line is required for properly kill mutants - without it all survive
    enableFindRelatedTests: false
  },
  mutate: [
    'src/**/*.ts'
  ],
  thresholds: { high: 80, low: 60, break: null },
  maxConcurrentTestRunners: 2
}

Test runner config (Jest.config.js)
module.exports = {
  roots: ['test'],
  testEnvironment: 'node',
  transform: {
    '.(ts|tsx)': 'ts-jest',
  },
  testRegex: '(\\.(test|spec))\\.(ts|js)$',
  moduleFileExtensions: ['ts', 'tsx', 'js'],
  globals: {
    'ts-jest': {
      diagnostics: {
        pathRegex: '(\\.(test|spec))\\.(ts)$',
      },
    },
  },
};

Stryker environment
+--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>+--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>deduped
+--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>deduped
| +--<EMAIL_ADDRESS>deduped

@types/jest: 25.1.3,
jest: 25.1.0"
ts-jest: 25.2.1

Test runner environment
npm run mt

Your Environment

software
version(s)

node
v12.13.0

npm
6.12.0

Operating System
Windows 10

Add stryker.log
stryker.log

I guess this is a duplicate of #2122 . Could try one of the other workarounds reported here? https://github.com/stryker-mutator/stryker/issues/2122#issuecomment-605783668

You can also use the new --inPlace mode, new since Stryker 4.4. Closing this issue for now, please open a new one if this problem persists.

You can also use the new --inPlace mode, new since Stryker 4.4. Closing this issue for now, please open a new one if this problem persists.


[bug] cannot import Gitlab from gitlab

from etienne:
ImportError                               Traceback (most recent call last)
<ipython-input-1-0026f1f8a7a3> in <module>
----> 1 import siibra
      2 siibra.logger.setLevel('INFO')
      3 siibra.__version__

/run/media/etienne/DATA/Toolbox/BraiNets/siibra-python/siibra/__init__.py in <module>
     27 from os import path
     28
---> 29 from .space import REGISTRY as spaces
     30 from .parcellation import REGISTRY as parcellations
     31 from .atlas import REGISTRY as atlases

/run/media/etienne/DATA/Toolbox/BraiNets/siibra-python/siibra/space.py in <module>
     14
     15 from .commons import create_key
---> 16 from .config import ConfigurationRegistry
     17 from .retrieval import download_file
     18 from .bigbrain import BigBrainVolume

/run/media/etienne/DATA/Toolbox/BraiNets/siibra-python/siibra/config.py in <module>
     16 from . import logger,__version__
     17 from .commons import create_key
---> 18 from gitlab import Gitlab
     19
     20 # Until openminds is fully supported,

ImportError: cannot import name 'Gitlab' from 'gitlab' (/home/etienne/anaconda3/lib/python3.7/site-packages/gitlab/__init__.py)

I believe this issue does not have to do with python-gitlab issue. This is simply a namespace confusion issue

Hi @xgui3783 ,
Thank you for referencing my issue. Do you have a suggestion for fixing it?

I don't have much experience using python outside virtualenv, unfortunately.
python-gitlab did indeed have a bug in v2.7.0 release (demonstrated here, issue here )
The proof of concept of the python-gitlab issue shows that the error occurs when one attempts to fetch a file from a repository, and much after from gitlab import Gitlab
can you maybe cat /home/etienne/anaconda3/lib/python3.7/site-packages/gitlab/__init__.py and we can try to diagnose why the import is failing?

Hi @dickscheid ,
I finally fixed my Gitlab issue, probably not the cleanest workaround but I didn't found a better solution :

rm gitlab/ folder in site-package
pip install -U python-gitlab

After that siibra import works

Hi @EtienneCmb , thanks for the followup! Hmmm...  not too satsifactory but good that you solved it. We will then monitor if this reappears for other users, but close the issue.


[feature]: Add more samples integrated with keploy

Is there an existing feature request for this?

[X] I have searched the existing issues

Summary

Currently samples-java is a single module project showcasing only JDBC mocking feature of keploy java-sdk.
Since now there are support for mocking several dependencies like - Okhttp interceptor, Apache Interceptor ,Google maps, Amazon S3 storage , DynamoDB and Redis it will be good to have one sample for each .
So It will be a multi module project and structure will be similar to this having separate pom for all samples .

Why should this be worked on?
This is an important feature to showcase the mocking infra capabilities of keploy
Also user will be able to test its API with ETE tests generated by keploy without caring about test environments
Tests and mocks generated will be more realistic as captured from the real traffic .

Hello,
I noticed that you have posted an issue on GitHub regarding a problem you are facing with one of the features. I would like to offer my assistance in helping you resolve this issue.
Please let me know how I can help and what steps you have already taken to troubleshoot the issue. I will do my best to provide any guidance or support needed to find a solution.
Thank you for considering my offer to help.
Best regards,
Pritesh Rai


ENG-944 Hotfix for Semgrep breakage

v0.1 backport is tagged as v0.1.2: https://github.com/amplify-security/runner/tree/ENG-944/v0.1-backport
confirmed that it's functioning here: https://github.com/amplify-security/runner/actions/runs/11616982887/job/32351878278#step:4:227


The conformance test suite should also search Accepted condition in Gateway.Status.Conditions.

What would you like to be added: The conformance test suite tries looking for Accepted condition in Gateway.Status.Listeners.Conditions. It should also search Accepted condition in Gateway.Status.Conditions.
https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/utils/kubernetes/helpers.go#L716
Why this is needed: Some Gateway implementation only sets Accepted condition in Gateway.Status.Conditions.

Although the current conformance checks are per Listener, I do agree that these probably becomes unnecessarily verbose when a Gateway has lots of listeners:
https://github.com/kubernetes-sigs/gateway-api/blob/7320257302905254dcebf4f5c424741cf1556c06/conformance/utils/kubernetes/helpers.go#L325-L331
When I'm thinking about potential alternatives, I think we'd end up with something like this:

Gateways must have top level conditions set for all of the conditions we currently require on Listeners
Listener conditions only need to be set when they differ from top-level Gateway conditions (ie all but one Listener is accepted, therefore Gateway is accepted + error conditions are set for the problematic Listener)

That kind of change would allow implementations to continue to set all of the conditions they already are, but no longer requires status to be quite as verbose. In any case, it's too late to make a change like this for v1.1, but definitely worth discussion in the v1.2 cycle.
/cc @youngnick

We've defined these conditions as positive-polarity conditions, which means that the official contract for them is that they should always be present, because them not being present implies "not enough information to set this condition yet".
Doing something like this will require us writing out and then conformance testing all the rules to ensure that we get this right, and that everyone does at least the minimum.
What I don't want to have happen here is that implementations stop publishing any information altogether into Listener status, which will happen unless we carefully spec out the change here.
Making everything required is definitely more verbose but means that we are guaranteed accuracy in the Listener status.
@wstcliyu, as of right now, the conformance tests check that the Listener Conditions are set because they are required in the spec. We can make it optional, provided we define the rules and make sure those rules are tested properly by conformance. Until then, implementations need to populate all of the status to be conformant, sorry.

@youngnick how would you feel about a change to the spec that looked like this?

Gateways must have top level conditions set for all of the conditions we currently require on Listeners
Listener conditions only need to be set when they differ from top-level Gateway conditions (ie all but one Listener is accepted, therefore Gateway is accepted + error conditions are set for the problematic Listener)

It's a pretty big change in intent for status for Gateways, so I think I'd like to think about it for a bit. I can't see immediate problems, but I'm worried about implicit assumptions and the changeover process.
The proposed change would essentially change all Listener Conditions to have negative-polariy behavior, but positive-polarity naming, which seems confusing.


⚠ ClamAV has degraded performance

In 5be093d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 208 ms

Resolved: ClamAV performance has improved in f66ab02.