Simplify curves like Paper.js or vectorscribes "smart remove brush tool" does.

Maybe a curve could be approximated (so that optionally you loose some detail?).
svgo already did an amazing job minimizing a test svg of mine (170kb => 22kb), but hey you can always ask for more ;)

Yep, I was thinking about it, but haven't get to it yet. Many plans, but very little time.

I suppose this is at least related to Inkscape's "simplify", right?

@waldyrious Yes this looks like what I was thinking off ...

May be you were meant Illustrator? Inkscape is quite bad here.

I have not tested inkscape's 'simplify' (just had a look at their user manual to see what waldyrious was talking about...).
Just wanted to say that this is generally what I was thinking about (no clue, if it is implemented in a good or bad way).

You have http://bost.ocks.org/mike/simplify/ which has some js witty code for line simplification.

Line simplification isn't an issue, actually. Lines takes only 1 pair coordinates, while curves takes 3. Sometimes, it only takes one number (horizontal or vertical line). So one curve is 3 times larger. And there are rarely images which actually needs line simplification, while there are image that may have too many curves and can be simplified without a notable loss.

Here's paper.js's curve simplify in action:
http://paperjs.org/examples/path-simplification/
https://github.com/paperjs/paper.js/blob/develop/src/path/PathFitter.js
http://paperjs.org/reference/path/#simplify
Should be rather trivial to integrate into a plugin.

@GreLI a single curve is 3 times larger than a single line, but to get even an approximation to such a curve, one would need multiple lines, not 1. So for similar geometry, whether it's represented as curves or lines, actually the lines version occupies much more space.
Of course, simplifying curves (which can at least make a reasonable attempt at preserving the shape of the curve while using less nodes) will generally produce more visually appealing results than simplifying the equivalent sequence of lines into a sequence with less nodes. The ideal approach would be to simplify sequences of lines into curves, which can then try to trace the original path by clever usage of the curve parameters.

for reference, this module seem to also approximate a linestring with bezier curves - https://www.npmjs.com/package/turf-bezier

I post this in case someone wants to work on this for svgo (I only discovered svgo via this github issue).
Here is the smallest (server-side + canvas-less) sequence I could find to use the PathFitter of paper.js mentioned by @behdad  in order to approximate a path with curves. The compression results are indeed impressive even for complex linestrings and high tolerance.
var paper = require('paper');
paper.setup();
var parser = require('html-attribute-parser')
var tolerance = 0.01;
var d_source = "M20,20L80,80L140,20Z";
var path = new paper.Path({pathData: d_source })
path.simplify(tolerance);
var svg = path.exportSVG({ asString: true});
var d_target = parser(svg).attributes.d

I looks like a very low-hanging fruit to use the model of the convertPathData plugin and to incorporate the above minimal example that uses paper. The convertPathData plugin already has the code that allows you to isolate any given d string, and then the above example does the rest. The tolerance could be in the plugin parameters.
I’m not a JS dev at all, but for anyone familiar with JS, it’d be a 10-minute job to create a simplifyPaths.js plugin for svgo that simply relies on paper.js and does just that!

I opened a pull request that adds this feature based on the code that @jeromew proposed. Definitely took a lot longer than 10 minutes though :face_with_spiral_eyes:


[REQ] add AddonKind for printing out hints for users

AddonKind::Hint (or Note, or both)
When reporting errors, warning or information, it is often the case that we can help users out. This can be possible by printing a Hint for user, for example to use different combination of options for the specific use case.
Solution, introduce AddonKind::Hint (or similar)
This would make reports like following possible:
WARN: something is ignored because --flag1 is not set
HINT: use --flag1 when using --flag2 to make that possible

good idea. I will try to add both.


Move backend-defaults to devDependencies

Whoops! This was my bad! Wonder if we can standardise on this dev folder and remove the linting for that so we don't need to add that comment everywhere too in the future.

Yepyep!


please ignore. This is for testing.

Commit IDs
https://github.com/iancha1992/bazel/commit/79a0dc276cc81717ac2951d575e19f6a54d71e43, a2b775
Category
team-OSS, team-Bazel
Reviewers
@iancha1992

The following commits were cherry-picked in https://github.com/bazelbuild/bazel/pull/19395: https://github.com/iancha1992/bazel/commit/79a0dc276cc81717ac2951d575e19f6a54d71e43, https://github.com/iancha1992/bazel/commit/a2b775.


MapRandomizer sometimes fails because "random number of entries = 0"

Hi,
We found a small bug in the MapRandomizer class:
public MapRandomizer(final Randomizer<K> keyRandomizer, final Randomizer<V> valueRandomizer) {      this(keyRandomizer, valueRandomizer,  abs(aNewByteRandomizer().getRandomValue()));   }
The ByteRandomizer can return the value 0 causing the MapRandomizer to fail:
private void checkArguments(final int nbEntries) {         if (nbEntries < 1) {             throw new IllegalArgumentException("The number of entries to generate must be >= 1");         }     }

Hi,
Thank you for reporting.
I'll fix the issue asap and keep you informed.
Kind regards
Mahmoud

@benas: I fixed the issue. I hope you do not mind. Fell free to change anything if you prefer a different solution.

@PascalSchumacher: thanks for fix!
@benas: The world is small, I didn't know that this was a side project of you,  give my greetings to all the colleagues,  Hannes

@PascalSchumacher Thank you for the fix. You rock!

The world is small, I didn't know that this was a side project of you, give my greetings to all the colleagues, Hannes

Hey Hannes! Thank you. Indeed, the world is small 😄

give my greetings to all the colleagues, Hannes

Sure!
I've deployed the fix to maven central, please don't hesitate to reopen the issue in case of any problem.
Kind regards
Mahmoud


Fix sandbox embedding in docs

The branch should be main but the docs has master which is outdated.

After installing nodemon and enable ESM for our project, the https://wechaty.js.org/docs/getting-started/running-locally/ can work as expected.


Minor changes for Spark PS

This PR adds changes for new distributed spark impl.

VoidParameterServer changes
memset exposed

Damn, notifications for review comments should be improved somehow. Seriously. So easy to miss :(


[Event Request] Table 38 Purchase Header - Function RecreateTempPurchLines

Dear ALAppExtensions Team,
We would like to request the following event publisher in table 38 - Function RecreateTempPurchLines, of course without the prefix DIN.
local procedure RecreateTempPurchLines(var TempPurchLine: Record "Purchase Line")
begin
    repeat
        TestPurchLineFieldsBeforeRecreate();
        TempPurchLine := PurchLine;
        if PurchLine.Nonstock then begin
            PurchLine.Nonstock := false;
            PurchLine.Modify();
        end;
        OnRecreatePurchLinesOnBeforeTempPurchLineInsert(TempPurchLine, PurchLine);
        TempPurchLine.Insert();
        OnRecreateTempPurchLinesOnAfterTempPurchLineInsert(Rec);
        // DINNL <<
        DINOnRecreatePurchLinesOnAfterTempPurchLineInsert(TempPurchLine, PurchLine);
        // DINNL >>
    until PurchLine.Next() = 0;
end;

local procedure DINOnRecreatePurchLinesOnAfterTempPurchLineInsert(var TempPurchaseLine: Record "Purchase Line" temporary; PurchaseLine: Record "Purchase Line")

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Using phone next to the laptop causes audio interference

Steps to reproduce

Turn on the laptop
Call someone and put the phone next to the laptop
Expect annoying noise coming out of it

The issue still persists and is reliably reproducible -> Not Complited
Moved in https://git.dotya.ml/KREYLIMEX/TERES/issues/22


VCOs occasionally frequency lock

When the two VCOs are tuned very close to each other, they sometimes lock together, instead of beating slowly.
This isn't something super noticeable while you're playing it, but it would be better if you could dial in nice slow beat frequencies all the time.
I imagine this is happening via coupling through the 2v5 reference voltage which they share.
Maybe they should each get their own 2v5 reference? The LM4040 used are not super expensive, and they are small so board real estate is not a big deal.
You might also be able to put a little more current through the +2v5 ref LM4040 and see if that helps.
Something else that might help is to remove the extra 2v5 ref loads, a few pots and such use the 2v5 ref. We could use an opamp buffer to decouple the 2v5 ref which goes to the SSI2130 vref pin and the 2v5 which goes to the pots and stuff. Note that we use two opamp comparators for the ADSR gate inputs, but really they could share one, we could free up an opamp from there if needed.
Investigate and find a good solution. The best one would be to just run the LN4040 a little hotter if it fixes it, because this doesn't require any new parts or pcb changes.

After some investigation, I believe the frequency locking is actually coming from the SYNC switch. The VCO_A_PULSE signal is being capacitively injected into the VCO B SOFT_SYNC_IN pin.
Pulling the VCO B SOFT_SYNC_IN pin to ground with a resistor seems to help. On the current prototype there is a 1k ohm resistor kludged from the VCO B SSI2132 soft sync pin to ground. This helps, but does not prevent unwanted syncing all the time. Hard-grounding the soft-sync capacitor does seem to reliably prevent it. The higher the frequency of the VCOs, the more likely they are to sync.
Maybe I need a fancier switch which can ground the sync inputs when sync is off? I'm not even that huge of a sync-lover, maybe there should just be one option instead of the current HARD-OFF-SOFT sync switch. Continue to investigate and think about this.

Fixed by changing the sync switch to a type that grounds the unused sync inputs.


issue G910

Hi every one.
I got an issue whit the G910
I can configurate the desktop , and all that stuff, but when I want to configurate for example league of legends, there's happend a problem , my keyboard did not change the colours. and meaby some of you can help me :D
and look like this:

remember that the last version of league is:
...\RADS\solutions\lol_game_client_sln\releases\<IP_ADDRESS> .... so meaby something is going wrong in the research or something.
and last I have a big question ... my Aurora folder look like this ...

so i wanna know if is right or not
Thx and rewards!.
----------------------------------------------------------------------------------------------
I made the same whit other game Evolve 2 and works fine , every thing goes fine so meaby is something in the league config ?
this is the evolve config

and this is how the keyboard look like in the game:

Well, first of all, you downloaded both the source code and the release. You just need the latest release from here: https://github.com/antonpup/Aurora/releases
Then for League, you have to enable a lightfx setting in the config file of the game to allow for LightFX to work. The instructions for that can be found here: http://forums.na.leagueoflegends.com/board/showthread.php?t=2110253
I also noticed that your entire LoL profile is set as a rainbow effect, you will not be able to see the LightFX effects if Color Zones cover the entire canvas.

@antonpup Thank you buddy it's actually works now , so if some one have some issue this can help out some other people :+1:

Glad you got it fixed. I hope you enjoy Aurora! :smile:


Javascript?

i couldn't find any javascript - makes me very happy if thats true :100:
(I'll add my own js if I fork / or use it) but it looks nice. Just wondering if there's javascript somewhere I'm missing

No javascript :)


Bump pion/dtls

Assert ApplicationData epoch != 0

Codecov Report

Merging #875 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #875   +/-   ##
=======================================
  Coverage   76.12%   76.12%
=======================================
  Files          59       59
  Lines        4277     4277
=======================================
  Hits         3256     3256
  Misses        744      744
  Partials      277      277

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1236c8...df0e740. Read the comment docs.


Unnecessary mutable references

From what I can see,
VolumeControlHandle:.set_volume doesn't need &mut because,
Producer::push doesn't need &mut since,
Producer::push_access doesn't need &mut since,
SharedVec::get_mut(), CachePadded::load nor CachePadded::store don't need &mut

I'm trusting that Producer::push does need &mut because that's what it says in the API. If you believe otherwise, I'd open an issue in the ringbuf repo. If a ringbuf update changes Producer::push to take &self, then I'll be happy to update the functions in Kira.


Feature Proposal - include and export renderWithRedux/Router

When @kentcdodds published an article about doing more integration tests using, we did a POC and right away we spotted a couple of defects in our app.
We put together a small util that would allow us to renderScreen or renderApp. This util saved us from provisioning the store, default state. The redux examples of this project show a very similar method "renderWithRedux".
When we saw this module coming alive we stopped adding any type of feature to our util and started planning to migrate to this module instead.
So we are wondering if this community would consider as part of the scope of this module adding such features:

renderScreen
renderApp

Our understanding is that the React/Redux/Router combination is common enough in the react community that a feature like this would cater to a significant audience.
Maybe the particularities of each project make this proposal invalid. Anyway, before preparing a PR we wanted to socialize it.
Thank you for this great and simple solution.

i'm not sure i understand. this is a testing library. you seem to be proposing something much bigger, like a "standard React bundle".

Hey @tsiq-swyx, that's not what @sesteva is suggesting. I believe what is being suggested is having a method such as this one included:
https://github.com/kentcdodds/testing-workshop/blob/92c6d4d4de8ee1c351aca8e53010428ad1dd9a0c/client/test/til-client-test-utils.js#L8-L18
This is a great method that every application should have, but every application will need it to be slightly different. This is why I'd much rather have an example in the README of how to create and use something like this. We won't include anything in this library that supports specific libraries especially :) Thanks anyway! Would you like to add a PR for this?

Hey Kent,
I'd be willing to take a crack at this. Should it follow the examples (react-router / react-redux), taking care to note that each app's implementation will vary? Or do you see it as more of a FAQ?
I've also just figured out how to test a redirect using this library, which means I can ditch Enzyme for good. You basically export the new history from within the would-be utility function (such as the one you linked above) and check for the appropriate path/route.
Thanks for the library btw - dare say I'm having fun using it.

Should it follow the examples (react-router / react-redux), taking care to note that each app's implementation will vary? Or do you see it as more of a FAQ?

Because doing this would require custom jest configuration it'd probably be best to just have an example in another repo and point to that. Do you mind making something like that?

I've also just figured out how to test a redirect using this library, which means I can ditch Enzyme for good.

Super! You solution is how I would do that as well :+1:

I'm having fun using it.

That's the BEST thing I've heard all day! Thanks!

Ha!
Nope not at all. I'll do my best to get to it this weekend (famous last words :))

@benpolinsky did you ever solve this issue ?, I am having a similar issue testing a component. Many Thanks


style: :art: improve contrast for destructive color in dark mode

Related to https://github.com/shadcn-ui/ui/pull/282, but it was closed and not fixed
Before
Not enough contrast with background

After

For my own projects, I've decided to go with the following tailwind colors for appropriate contrast on text-based destructive states / error messages:
bg-white text-red-600 dark:bg-zinc-950 dark:text-red-500

WCAG 2.0 level AA requires a contrast ratio of at least 4.5:1 for normal text:

Light mode bg-white text-red-600: 4.82:1
Dark mode dark:bg-zinc-950 dark:text-red-500: 5.28:1

Any lighter on the red (or darker in dark mode) results in the following contrast ratios:

Light mode bg-white text-red-500: 3.76:1
Dark mode bg-zinc-950 text-red-600: 4.11:1

Dark mode is better than light mode, but both are still below the minimum required contrast ratio of 4.5:1.


Whenever Machinaris restarts, the Chia fullnode doesn't properly start.

Describe the bug
Whenever Machinaris restarts, the Chia fullnode doesn't properly start.
To Reproduce
Restart Machinaris
View Chia Logs
Expected behavior
Chia works immediately
System setup:

OS: TrueNAS Scale
Docker version number (output of docker info): v0.9.1-beta3
Machinaris branch: Main
Machinaris version number: 0.5.6

Additional context & screenshots
Constant logging of
2021-09-27T18:13:38.519 wallet wallet_server              : INFO     Cannot connect to host <IP_ADDRESS>:8444 ssl:<ssl.SSLContext object at 0x7f682db68f40> [Connect call failed ('<IP_ADDRESS>', 8444)]
Fullnode seems to halt at
2021-09-27T18:14:50.522 full_node chia.full_node.full_node: INFO     Initializing blockchain from disk 2021-09-27T18:14:50.524 full_node chia.consensus.blockchain: INFO     Started 22 processes for block validation
This could be an issue with my specific machine, I don't quite know.

Good day, sorry to hear you're encountering this issue with Chia binaries in the Machinaris image.  Could be a corrupted blockchain database.  My recommendation:

Stop Machinaris container
Delete the 'mainnet' folder from the container's AppData folder.  Sometimes ~/.machinaris, not sure where on TrueNas.
Start Machinaris container.  Wait for status to re-populate, may take a day or more to re-sync.

Hope this helps.

I'll give it a try, thanks! Will update back with the results

I had the same Problem. I managed to resolve it by moving the chia blockchain db to an nvme. It has soething to do with an overloaded or slow disk speed. By every restart Chia/machinaris has to load the blockchain and wallet db this can take avery long time since it's now pretty huge.
Try moving it to an nvme or SSD and avoid storing it on an HDD.


Fix Beam Schema to Iceberg Schema ID conversion logic

Fixes #32050
Current iceberg utils does Schema conversion in a way where unique IDs are given to nested fields before top-level fields. When retrieving an Iceberg table's schema and inspecting it, we see that unique IDs are given to top-level fields first, then each nested type. This PR fixes our utils to align with it

assign set of reviewers


Don't explicitly set width/height on svg elements

Description
This is tech debt cleanup. In #3148 I refactored icons so that callers always explicitly set size of icon element instead of relying on whatever Icons.svg() sets. Setting width/height is no longer necessary and removing it makes it clear that callers must set desired size themselves.
Checklist
General

[x] Added the correct label: < feature | bug | dependencies | infrastructure | ignore-for-release >
[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

User visible changes

[ ] Wrote browser tests using the validateAccessibility method
[ ] Manually tested at 200% size
[ ] Manually evaluated tab order

New Features

[ ] Add new FeatureFlag env vars to server/conf/application.conf
[ ] Conditioned new functionality on a FeatureFlag
[ ] Wrote browser tests with the feature flag off and on, etc.

Codecov Report

Merging #3804 (ed2bbb0) into main (4febec6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3804   +/-   ##
=========================================
  Coverage     80.63%   80.63%
  Complexity     2441     2441
=========================================
  Files           296      296
  Lines          9642     9642
  Branches        659      659
=========================================
  Hits           7775     7775
  Misses         1613     1613
  Partials        254      254

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Change color of selected month/day.

It would be great if (in month, year view) you could add a css class to the the currently selected day/month. So not only is the list of events exapanded, you can change the color or the cell.

Good idea! Added in master :)

I just tested this out. cal-day-selected doesn't seem to be applied to the day when you click on it.

@mattlewis92 ,
Can you let me know the css class for the selected day. I want to change the background color for the clicked day.
Thank you.


angstrom-v2017.12-rocko fails

Hi,
When building the console-image or any other image on the rocko branch, I get the following error:
Error: ParseError at layers/meta-backports/core/recipes-connectivity/iproute2/iproute2_4.17.0.bb:1: Could not include required file iproute2.inc
The mentioned file exists: layers/openembedded-core/meta/recipes-connectivity/iproute2/iproute2.inc
When I check the bblayers.conf file, it has the directory layers/openembedded-core/meta for BBLAYERS.
Any idea on why this seems to go wrong?
Kind regards,
Jan

This is a bug with meta-backports, but I'll keep it open till it gets resolved upstream, or we lock meta-backports to a rev before the breakage.
layers/meta-backports/core/recipes-connectivity/iproute2/iproute2_4.17.0.bb:require iproute2.inc
layers/openembedded-core/meta/recipes-connectivity/iproute2/iproute2_4.11.0.bb:require iproute2.inc

So 2 recipes require a file called 'iproute2.inc' to be in the same dir as the recipe, but...
[koen@fedora-vm v2017.12]$ find layers/ -name "iproute2.inc"
layers/openembedded-core/meta/recipes-connectivity/iproute2/iproute2.inc

There's only one file, leading to...
Error: ParseError at layers/meta-backports/core/recipes-connectivity/iproute2/iproute2_4.17.0.bb:1: Could not include required file iproute2.inc

The fix:
[koen@fedora-vm v2017.12]$ repo diff layers/meta-backports

project layers/meta-backports/
diff --git a/core/recipes-connectivity/iproute2/iproute2_4.17.0.bb b/core/recipes-connectivity/iproute2/iproute2_4.17.0.bb
index 6d77106..dd78573 100644
--- a/core/recipes-connectivity/iproute2/iproute2_4.17.0.bb
+++ b/core/recipes-connectivity/iproute2/iproute2_4.17.0.bb
@@ -1,4 +1,4 @@
-require iproute2.inc
+require recipes-connectivity/iproute2/iproute2.inc

 SRC_URI = "${KERNELORG_MIRROR}/linux/utils/net/${BPN}/${BP}.tar.xz \
            file://0001-make-configure-cross-compile-safe.patch \
[koen@fedora-vm v2017.12]$

Thanks for the help, that did the trick.

Fix applied to upstream: https://git.linaro.org/openembedded/meta-backports.git/log/?h=rocko


Assertion failure in ./kernel/rtlil.h:1277

The code
module top(input in,output out);
  SB_DFF dff(out,in,1);
endmodule

when compiled with the command line
yosys -p 'synth_ice40 -top top -blif test.blif' test.v

gives the assertion failure
ERROR: Assert `sig.size() == 1 && sig.chunks().size() == 1' failed in ./kernel/rtlil.h:1277

rather than an error message. If "1" is replaced by "1'b1" the module compiles successfully.

Fixed in commit 2165984.


Cannot find module '@docusaurus/router' when importing useHistory

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[X] I have tried the npm run clear or yarn clear command.
[X] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[X] I have tried creating a repro with https://new.docusaurus.io.
[X] I have read the console error message carefully (if applicable).

Description
VSCode is complaining about missing types when referencing useHistory. The code works as expected, its just a nuisance seeing the error. I was unable to repo this in the Playground.

Reproducible demo
No response
Steps to reproduce
Add import { useHistory } from '@docusaurus/router'; to a TSX file
Expected behavior
No errors are shown
Actual behavior
Error is shown
Your environment
Here's my package.json
{
  "name": "tech-guidebook",
  "version": "0.0.0",
  "private": true,
  "scripts": {
    "docusaurus": "docusaurus",
    "start": "docusaurus start --no-open",
    "build": "docusaurus build",
    "swizzle": "docusaurus swizzle",
    "deploy": "docusaurus deploy",
    "clear": "docusaurus clear",
    "serve": "docusaurus serve",
    "write-translations": "docusaurus write-translations",
    "write-heading-ids": "docusaurus write-heading-ids"
  },
  "dependencies": {
    "@babel/runtime": "^7.17.2",
    "@docusaurus/core": "2.0.0-beta.17",
    "@docusaurus/preset-classic": "2.0.0-beta.17",
    "@emotion/react": "^11.8.2",
    "@emotion/styled": "^11.8.1",
    "@mdx-js/react": "^1.6.22",
    "@mui/material": "^5.5.1",
    "@reduxjs/toolkit": "^1.8.0",
    "algoliasearch": "^4.13.0",
    "clsx": "^1.1.1",
    "docusaurus-theme-search-typesense": "^0.4.0-2",
    "lodash": "^4.17.21",
    "prism-react-renderer": "^1.2.1",
    "react": "^17.0.1",
    "react-dom": "^17.0.1",
    "react-instantsearch-dom": "^6.22.0",
    "react-redux": "^7.2.6",
    "typesense": "^1.2.2",
    "typesense-instantsearch-adapter": "^2.4.0"
  },
  "devDependencies": {
    "@docusaurus/module-type-aliases": "^2.0.0-beta.17",
    "@docusaurus/types": "^2.0.0-beta.17",
    "@tsconfig/docusaurus": "^1.0.4",
    "@types/lodash": "^4.14.180",
    "@types/react": "^17.0.40",
    "@types/react-dom": "^17.0.13",
    "@types/react-instantsearch-dom": "^6.12.2",
    "@types/react-redux": "^7.1.23",
    "typescript": "^4.6.2"
  },
  "browserslist": {
    "production": [
      ">0.5%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  }
}

Self-service

[ ] I'd be willing to fix this bug myself.

This is related to #3424

Found the problem. The tsconfig.json was missing this line
  "extends"<EMAIL_ADDRESS>


Add an amr.regrid_on_restart option.

If you want to restart and add level(s) right away or change your tagging criterion right from the start. Otherwise, you will have to wait until the next amr.regrid_int. And even then, regrid is not recursive so that it can only adds a single level each time it is called even if you've increased your amr.max_level by 2.


[Feat] Add design - stacked bar - for injured_count_per_age_group_stacked

Design is stacked bar graph (@chenmu10 created relevant design for another widget.)
Note that the title should come from the BE only (the title in the design is not accurate)

Design is similar to this - but with ages in the x-axis rather than years.

Final API not ready - please discuss with the BE team to finalize the structure - see this issue
A structure of generic stacked bar graph can be used.

Title is defined in BE

opened this issue instead


Adds test case for multiple workflows with same schedule

Describe your changes and why you are making these changes
This PR adds a test case for multiple workflows with same schedule. It fails on the post-refactor engine PR, passes on current main.
Related issue number (if any)
https://linear.app/aqueducthq/issue/ENG-1526/add-test-case-for-multiple-workflows-with-same-schedule
Checklist before requesting a review

[x] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[x] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[x] If this is a new feature, I have added unit tests and integration tests.
[x] I have run the integration tests locally and they are passing.
[x] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[x] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

Shipped with #317


[PE-D][Tester E] Duplicate tags can be added initially by using multiple t/ in a single command

With input:

The student John Doe can have multiple tags with the same lettering but different capitalization.

Similarly for edit,

Despite the tag command viewing tags with same lettering but different capitalization as duplicates.

Labels: severity.Medium type.FunctionalityBug
original: zlch/ped#10

Enhancement


Fix QBE link in README

The current link is an unofficial and outdated fork.

I've merged you pull request. Thank you for the patch.


onChange event not triggering in forms tag

Environment

Tech
Version

material-ui-pickers
2.2.4

material-ui
3.9.2

React
16.8.4

Browser - Chrome
73.0.3683.86

Peer library
date-fns 2.0.0-alpha.27

Steps to reproduce

Wrap the picker on any form with onChange or onInput event or both.

Expected behavior
Expected to trigger onChange or onInput when change the value of picker.
Actual behavior
Value changes, the input value changes but the onChange event don't trigger.
Live example

https://material-ui-pickers.dev/guides/form-integration

You have not passed name

Sorry my mistake.


Week 4 Issue

Hacks
MCQ Test
https://taiyoi.github.io/Compsci22/2023/04/02/MCQ-Test-4.html

Did all the hacks, answer all the questions with sufficient responses.
42/50 On the MCQ
Showed detailed lesson plan with steps on how to configure DNS on Nighthawk Server.

Did all the hacks, answer all the questions with sufficient responses.
42/50 On the MCQ
Showed detailed lesson plan with steps on how to configure DNS on Nighthawk Server.
Canva pros and Cons image on the Hashmaps hacks.


Setup pre-prod deployment job

Context
Deploy app to pre-prod environment from the prod branch
Changes proposed in this pull request
Setup job for deployment.
Added some documentation - still a WIP
Guidance to review
Does anything look off?

@guy-roberts Deployments for production will be run through github workflows. They will be manually triggered by a human.
Each deployment will create a new docker image and the infrastructure is updated with that image to run from.
Logs are preserved.
This is the start command that gets run every time a new deployment is made
bundle exec rake db:prepare && bundle exec rake db:seed && bundle exec rails s  -b <IP_ADDRESS>

The database does not get dropped, but migrations are run and the db is seeded before starting. The contents of the DB will depend on how the content is created.
I believe atm, seeding the contents is a destructive process.


[BUG] source name cut winget pkg

Please confirm these before moving forward

[X] I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
[X] I have tested that this issue has not been fixed in the latest (beta or stable) release.
[X] I have checked the FAQ section for solutions
[X] This issue is about a bug (if it is not, please use the correct template)

Describe your issue
source show as winget: tag instead of just winget
Steps to reproduce the issue
use latest beta
WingetUI Log
n/a

Package Managers Logs
n/a

Relevant information
No response
Screenshots and videos

Which winget sources have you enabled?

I can no longer reproduce this issue, I guess it was "accidentally" fixed haha

I did indeed reproduce it


Kernel won't list in ipython

After running the jupyter-scala file I get:
Error: Could not find or load main class files.jupyter-scala_2.11.6-0.2.0-SNAPSHOT.icon-mac.png
logout

[Process completed]

Afterwards the kernel doesn't list in the jupyter (ipython) kernels. How could I fix this?

I don't really know at first, but you might have more luck with the new version of the kernel, described at https://github.com/alexarchambault/jupyter-scala/tree/topic/update-readme, whose installation is a bit different.

Thank you! It works now for me as described in the ReadMe (I had to run the curl command twice).
Thanks for the kernel! I appreciate your work.

Closing this :)


[Enhancement] Show lint errors on imperative assignments without a setter method

When a user writes an imperative statement without the use of setters, show a lint warning and prompt the user to use setters instead.
eg: When a user writes widget.isVisible = true, show a lint error that says isVisible is read-only. Use setVisiblity() instead

@Rishabh-Rathod @Druthi Could we add this to #3532?

Unfortunately, JSHint does not provide a direct configuration option to make a specific property of a global object read-only. The globals option in JSHint configuration is primarily used to define global variables and specify their values (true or false) to control whether assignments to those variables should be allowed or disallowed. However, enforcing read-only properties on a global object's specific property is beyond the scope of JSHint's capabilities.
Due to above mentioned JSHint limitation, it won't be easy to implement the above functionality until we find a way to support it in our linting architecture. We could try exploring eslint.
cc: @ohansFavour

Hey @Rishabh-Rathod ,
Alongside JSHint's generation of lint errors, we also parse the user's code (using AST) and generate custom lint errors. We should be able to generate the "imperative assignments" errors while traversing the parsed tree.

Thanks @ohansFavour. We will go ahead with the AST parsing for the above use case. Could you please help in the estimation of this task?

Please add your planning poker estimate with Zenhub @ohansFavour

Adding 2 more story points according to the complexity of showing the error message with respect to widget property.


Issue with k8s.io/docs/tasks/administer-cluster/kubeadm/adding-windows-nodes/

UI issues with page

@artisticcheese
would you like sending a PR to fix the formatting of the page?
/kind bug
/sig windows cluster-lifecycle
cc @benmoss

Done but I never did it before so not sure if I did it correctly

If you send a PR in it will have a netlify preview that you can verify with. We should have checked that on the last one.


Using deprecated lib for encrypting Android shared prefs (for older versions of Android)

I noticed this secure-preferences lib is used to implement encrypted SharedPreferences, but the lib is no longer maintained and the author is recommending Google's own androidx implementation.

Please use EncryptedSharedPreferences from androidx.security in preferenced to secure-preference. (There are no active maintainers Secure-preferences)

I noticed this secure-preferences lib is used to implement encrypted SharedPreferences, but the lib is no longer maintained and the author is recommending Google's own androidx implementation.

Please use EncryptedSharedPreferences from androidx.security in preferenced to secure-preference. (There are no active maintainers Secure-preferences)

Its only for older android versions. For newer keychain is used.

Right, I mention it because the androidx implementation of EncryptedSharedPreferences (androidx.security.crypto.EncryptedSharedPreferences) provides the same backwards compatibility for older Android versions that scottyab/secure-preferences does, but it's still maintained by Google, which is why the lib author posted the deprecation notice.
It seems like the androidx lib also has all the fallback behavior for older Android versions already built in, so you may be able to simplify the react-native-mmkv-storage Android implementation by using that single lib rather than doing your own version detection.

Its the only option below android 21. The deprecated lib words for android 16-21.


This class is not found in the file

This class is not found in the file

Hi. Can you confirm you have updates the Podfile to include
platform :ios, '14.0'
And
pod 'SimplePing', :git => 'https://github.com/youssef-fk/SimplePing.git'
pod 'SimpleTracer', :git => 'https://github.com/youssef-fk/SimpleTracer.git'

Then run pod install on the ios folder ?


migration to .net core 3.1

trying to solve #3

Thank you for PR.
Confirm:  Tested and working on Win10 / .NET Core  3.1.102.      I do not have a Mac to test this with.
I was never able to replicate the original issue that was raised by @rafaelpirolla , but quite happy to merge your PR.
I'm still unclear:  Was this actually a compatibility issue related to the change from .NET Core 2.x to 3.x - or was this an issue related to Mac compatibility that was present in both 2.x and 3.x ?
Curious why this change to a different method overload was made? - was this related to a filesystem incompatibility with Mac perhaps???
return razorProjectFileSystem.GetItem($"{_razorTemplateBaseFolder}/{razorTemplateFileName}");

to
return razorProjectFileSystem.GetItem(path: ${_razorTemplateBaseFolder}/{razorTemplateFileName}", fileKind: null);

I think the changes would also be needed for Windows and wouldn't work without.
About razorProjectFileSystem.GetItem, it was a deprecation.
https://docs.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.razor.language.razorproject.getitem?view=aspnetcore-3.0&viewFallbackFrom=aspnetcore-3.1#Microsoft_AspNetCore_Razor_Language_RazorProject_GetItem_System_String_
Also the second parameter is a string named fileKind... I couldn't find even in the source code what would be the expected values.
I couldn't understand why I needed to comment this line, though:
// InheritsDirective.Register(builder);


fix: Bpt shown in pool activity

https://balancerecosystem.slack.com/archives/C02F9EMRKQA/p1726865089046169

I assume this is fixed.


Develop the new XsensMVNDriver class

This class will replace the former robotology-playground/xsens-mvn/xsensdriver.
Features:

Support of the Xsens 2018.0.3 SDK
YARP independent
C++14
Works only in Windows (due to Xsens' SDK)

XsensMVNDriver has been developed (https://github.com/robotology-playground/wearables/tree/feature/cleanup/XSensMVN).
@diegoferigo if you agree, we can close this issue.

I typically find more convenient to close issues when the relevant features has landed in master or devel, but I guess it is up to the maintainer to decide the policy on this.

I typically find more convenient to close issues when the relevant features has landed in master or devel, but I guess it is up to the maintainer to decide the policy on this.

I was pointing to a branch, but the same feature is also supported in the master (https://github.com/robotology-playground/wearables/tree/master/XSensMVN).

Great!

Yes, closing.

One missing thing is exposing the virtual points, as discussed with @claudia-lat. We will discuss it in a separate issue when we will need this feature and start the development.


Refactor utils package to use .js imports so it can be used in cli package

Context in https://github.com/latticexyz/mud/pull/494#discussion_r1139285230

I don't think this is an issue anymore?


Menu Bar Compact option broken on Kubuntu 18.04

VSCode Version: snap 1.39.2
OS Version: Kubuntu 18.04
Steps to Reproduce:

switch menu bar visibility to "compact"

Does this issue occur when all extensions are disabled?: Yes

As seen in the screenshot, if you switch the menu bar visibility to "compact", you have 2 on at least Kubuntu 18.04 because the old one doesn't go away.
It doesn't matter if I build it myself or use the official snap package (or the unofficial flatpaks).

PS: before anyone asks, I searched about this for about 5 hours now on the Internet and found nothing. I have seen no screenshot

About the closed/reopen, I misclicked, sorry.

@Kuhluh the compact option is not compatible with the native titlebar (default on linux) as noted in the setting description. however, it is a bug that the compact menu shows up with that setting as it should be ignored.

Well, good to know, and thanks for the information.

re-opening to fix the second part mentioned above


Avoid timeouts by testing with a stable image repo

One of the integration tests checks that the image metadata fetch
works with a real world image repository. It was using busybox (at
DockerHub) as that repo; but, busybox has enough manifests that the
test can time out waiting for the fetch to complete.
To keep the running time bounded, use a repo that has a small (but >
burst) number of images already, but isn't getting new tags added to
it too fast; and, tune the rate limiting down so that it won't make
too much of an impression on the registry.

Merged by playing the admin card. This affects the integration tests, and should make PR and master builds more reliable.


all: fix misuses of math.Pow(x, 2)

math.Pow(x, 2) is really inefficient because math.Pow(x, y) is written
for the general use case of computing the power of x where y is a
floating point number.
In the simpler case of y as an integer, a much simpler algorithm can be
used.
In the even simpler case of y==2, inlining is even faster.

Codecov Report

Merging #2 into master will increase coverage by <.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   63.24%   63.25%   +<.01%
==========================================
  Files          32       32
  Lines        3197     3200       +3
==========================================
+ Hits         2022     2024       +2
- Misses       1053     1054       +1
  Partials      122      122

Impacted Files
Coverage Δ

preprocessing/data.go
73.26% <0%> (-0.19%)
:arrow_down:

neighbors/distance.go
77.14% <100%> (+0.67%)
:arrow_up:

cluster/distance.go
17.14% <100%> (+2.43%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50446ff...b6deb78. Read the comment docs.


Meghan/master/header class#463

Adds documentation-header class to replace h1 used previously. Reduces size of h1 and h2 in documentation.
Closes #463

@rfriberg I'm making the h2 and h3 changes here as well.

@rfriberg I've added in the style changes we looked at for documentation, if you like to take a look.


Disable the logsearch button in UI if Logsearch and Ambari Infra is not available in the Environment

We need to hide the logsearch button in view mode if the SAM Env does not have Ambari infra.
We cannot guarantee that the cluster will have Ambari Infra and logsearch especially when the user has already installed SAM and upgrades to HDF 3.1.

@shahsank3t @HeartSaVioR , do we need any backend APIs for this or the UI can figure it out ?

Basically, if the user selects Ambari Infra while creating an environment and uses the same one to create an application, we should show LogSearch button else not.
I'll make the required changes.
@arunmahadevan No backend API's or changes should be needed for this change.

Raised PR: https://github.com/hortonworks/streamline/pull/1073

Merged to master


Gcode alignment

I think I have made quite a few change. None of them are breaking changes just yet so I thought I can create a  PR so that we can review and make our lives easier. If you feel I should add more changes to it then you let me know!

I think I also included my typing system refactoring so the PR looks larger than I would like. Should I create separate PR for that as well to make this one more manageable? @voneiden

Yeah, there are some conflicts as well in routers.py which prevents the CI checks from running.
Give it a shot, feel free to split into smaller PR's if it makes sense. Smaller pieces are easier to review. And bonus points if you don't include any "Merge branch 'voneiden:unstable' into operation-refactor" commits in the PR. Not a hard requirement - I'll just skip it myself when merging.
Technically nothing wrong with merging back and forth in git, but I prefer to keep the history easier to follow by allowing merges only one way (features -> main).

Probably the easiest way would be to create a new branch from voneiden:unstable and then cherry-pick the commits you want to feature in the PR.
You'll probably also want to (hard) reset your unstable branch to voneiden:unstable once you're sure that you're not accidentally wiping  any of your own changes.

I am doing all the development in their own branches so it should be too hard!

I think router.py is generating unnecessary commands that were hidden by print_modal, print_xyz, and print_ijk. Now that I am simplifying those methods I am finding duplicate G1 and G0 commands. I think this approach is going to be good to uncover hidden bugs!!

I have a local fix for that I have been using for quite a while that completely solves the issue.  I can create a cadquery PR soonish!
In the meantime I will remove the FIXME and TODO notes!

This is ready to be merged! @voneiden

Cheers!

 I almost have the next PR ready as well 🤣


cannot install

fatal: unable to access 'https://github.com/justinbarclay/parinfer-rust-mode.git/': LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to github.com:443

Please provide the information requested in the bug report issue template.


Key not found..

The problem
Some of people like me thinking normal google json key instead of  other key.Kinda waste me time 5 hour  clicking to find solution.
Environment

PHP Version (php -v):
PHP 5.6
Firebase PHP SDK version (composer show | grep kreait):
"kreait/firebase-php": "^4.17",

Details
Wrong key
Solution .
Provide more information on exception handling at ServiceAccount.php
if (!isset($config['project_id'])) {
           throw new InvalidArgumentException('Missing/empty project id in Service Account Config.');
       }
       if (!isset($config['client_id'])) {
           throw new InvalidArgumentException('Missing/empty client id in Service Account Config.');
       }
       if (!isset($config['client_email'])) {
           throw new InvalidArgumentException('Missing/empty client email in Service Account Config.');
       }
       if (!isset($config['private_key'])) {
           throw new InvalidArgumentException('Missing/empty private key in Service Account Config.');
       }
       if (!isset($config['project_id'], $config['client_id'], $config['client_email'], $config['private_key'])) {
           throw new InvalidArgumentException('You may download the wrong key . Firebase ->settings -> Service Key -> Generate New Private Key ');
       }
       ...
}

I’ll look to it, but:
What’s a “normal” Google JSON key? The documentation at https://firebase-php.readthedocs.io/en/latest/setup.html and the official Firebase Docs are pretty clear about the required key being for a Service Account.
How did you get a 4.x release running on PHP 5.6? :)

oops my mistake own server version . PHP 7.2

The documentation and the Setup section are there so that you don't have to assume :) - and Client SDK != Admin SDK. But here you are:

Fine grained error messages: cdcdb2f5c2e9e8bec4db6e4c4366d1c07d559135
Link from Installation to Setup: 7f57ded261a67773b202112b70939bd3e869f976


Auth user views

adjust the UI

Please select digitalfabrik:develop as base instead of Integreat:develop :slightly_smiling_face:


Issue/2345

Addresses #2345
Overview of changes:

Make Download Global Usage super-admin only
Create Download Monthly Usage button to get a CSV of:

Month, new plans, new users, downloads, plans shared
For each month since creation

New models/services for statistics on exported and shared plans

Added these to the stats rake tasks

Add parallel gem

Add parallelized tasks for rake stat:build and rake stat:build_last_month
Added threading to the other create_ services
Change DB default pooling to 16

Note:
UI with the multiple buttons looks funny at the moment, but I will refactor the layout in another feature's PR as I'd started this work there.

looks like you have some failing stats tests too that need to be addressed

Looks like the github-workflows are getting confused when checking things out from the DCC fork.
I've updated the mySQL side of our workflows to the checkout@v2 to patch the problem.
If that works, I'll apply the same fix to the remaining workflow files.
https://github.com/actions/checkout/issues/23

Going to merge this so I can rebase the work on https://github.com/DMPRoadmap/roadmap/issues/1682
They both affect the services and usage-dashboard heavily, so there's likely to be conflicts to fix on that branch.


PHP 8 support

Getting following error on PHP 8
Type mixed cannot be marked as nullable since mixed already includes null {"userId":1,"exception":"[object] (Symfony\Component\ErrorHandler\Error\FatalError(code: 0): Type mixed cannot be marked as nullable since mixed already includes null at vendor/alfonsobries/nova-trumbowyg/src/NovaTrumbowyg.php:16)

I have exactly the same problem. Have you found any solution?


Bug Report Bar Chart

Jo @tvst ,
think i found a bug.
What i tried is:
plost.bar_chart(
    data=datasets['stocks'],
    bar='company',
    value=['q2', 'q3'],
    direction='horizontal'
)

But values of q3 get stacked on top of q2 even though the
values of q3 should be plotted as part of q2 as the value of q2 is higher.
For vertical it works as expected.
Could you double check and in case fix that?
Best regards
Chris

I think I was mistaken, it it is the normal behavior that it get's sacked on top.
Feature Request: Would it be possible to include a param such as included=True,
so that the value of A (lower value) is part of the value of B and not getting plotted on top?
Ofc, I could subtract B=B-A myself to get the value correctly shown in the y-axis.
If I do so, however, the value of B get's reduced and the hover does show the wrong value of B.

Just so I understand, today Plost supports:
Unstacked:
|----
|======

Stacked:
|----======

But you'd like:
|≡≡≡≡=

...that is, you want the bars to overlap each other (possibly with some transparency, so you can understand what's happening).
Is that right?

Apparently Plost already supports this, with:
plost.bar_chart(
    data=datasets['stocks'],
    bar='company',
    value=['q2', 'q3'],
    direction='horizontal',
    stack='layered',
    opacity=0.7
)

Even better! Thanks a lot for digging into that for me, @tvst . We could add it to the documentation tho.
I'd also like to show you what i used it for. Gotta record it first and saidly I could not share it with the whole world,
but just to show you (i mean i know you know it anyways) how awesome streamlit and plost works together.


Changelog lacking

Issue Type

Feature request

Ansible and Ansible Lint details
ansible --version
ansible <IP_ADDRESS>
  config file = /home/aairey/git_projects/trimbletl/ansible-playbook-infra/ansible.cfg
  configured module search path = Default w/o overrides
  python version = 2.7.14 (default, Mar 14 2018, 13:36:31) [GCC 7.3.1 20180303 (Red Hat 7.3.1-5)]

ansible-lint --version
ansible-lint 3.4.19

ansible installation method: pip
ansible-lint installation method: pre-commit

Desired Behaviour
I updated my pre-commit hooks and I saw ansible-lint got updated.
pre-commit autoupdate
Updating git://github.com/pre-commit/pre-commit-hooks...[INFO] Initializing environment for git://github.com/pre-commit/pre-commit-hooks.
updating v1.2.0 -> v1.2.3.
Updating https://github.com/willthames/ansible-lint.git...[INFO] Initializing environment for https://github.com/willthames/ansible-lint.git.
updating v3.4.20 -> v3.5.0rc1.

I came here to github to check what has changed in between versions, but on the releases tab it was not visible.
Then I went searching for a CHANGELOG.md which also seems not to be present.
Could we have some way to track what has changed in between versions?

I've added a CHANGELOG.md for 3.4.22 (I've decided not to update to 3.5.0 now as there aren't any breaking changes)

I noticed that the CHANGELOG file hasn't been merged to master. Is this on purpose?
@willthames, would a pull request containing a more comprehensive changelog be useful?

Now merged to master (an oversight)
A more comprehensive changelog would indeed be useful - I'll leave this open if you wish to raise a PR referencing it.

Closing as CHANGELOG and ROADMAP currently being maintained.


doc: backquote mac in doc/api-extensions.md

Signed-off-by: Hiroaki Nakamura<EMAIL_ADDRESS>

This pull request didn't trigger Jenkins as its author isn't in the allow list.
An organization member must perform one of the following:

To have this branch tested by Jenkins, use the "ok to test" command.
To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Documentation preview available at: https://linuxcontainers.org/lxd/docs/pr.10822/

Signed-off-by doesn't appear to be valid.

Oh, sorry. I force pushed a fixed commit.


Tye should be able to export the yaml file being used to run the current running project.

What should we add or change to make your life better?
A feature to show or export the current yaml for a running project. It will go along way in helping a beginner to get up to speed quickly in setting up a project for deployment efficiently.
tye run --docker --export-yaml
Why is this important to you?
Certainly, It will help me with the deployment  faster.  tye run --docker  runs perfectly every time but I will like to see the yaml configuration that is running this. it could serve a basis for preparing configuration another similar project deployment.

What yaml do you want to see?

the yaml that  runs when you run tye run --docker on a project.

There's no yaml file that gets run

How does it tye know what to setup to run a project?  some form of orchestration is happening behind the scene.

Yes, it is orchestrating the containers itself.

can that orchestrator settings be exported in the form of a docker compose file or yaml?


Better support for parallel runs

[ ] different run*.sh variants should output to different binaries
[ ] different variants and different operating systems should cache in different directories (ie, right now C++'s CMakeCache conflicts between mac and docker-on-mac builds, we need to manually delete the cache each time we stop)
[ ] when building the same variant on the same OS, we should lock to avoid multiple parallel runs conflicting with each other

My gut tells me this probably means replacing the shell scripts with python

For now I've replaced run_XXX.sh with build_XXX.sh, we build all the variants sequentially, and then they can be run in parallel


Enabling watchdog on stm32l5.

These commits enable and run tests/drivers/watchdog/wdt_basic_api and samples/drivers/watchdog on stm32l562e_dk platform.
1: samples/drivers/watchdog runs and works as expected.
2: tests/drivers/watchdog/wdt_basic_api runs and works as expected.

@ikmdani please rebase your change to fix conflitcs

@ikmdani please rebase your change to fix conflitcs

done.


Implement arbitrary for up to size-12 tuples.

Description of changes:
Implements kani::Arbitrary  for tuples
Resolved issues:
Resolves #1965
Related RFC:

Optional #ISSUE-NUMBER.
Call-outs:
Testing:

How is this change tested? tests/kani/Intrinsics/SIMD/Operators/bitwise.rs

Is this a refactor change? No

Checklist

[x] Each commit message has a non-empty body, explaining why the change was made
[x] Methods or procedures are documented
[x] Regression or unit tests are included, or existing tests cover the modified code
[x] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws Thanks for the review. I'm a bit busy with other parts of kani, so I would get back to this PR around Jan. 2023. Have a nice holidays.

Thanks @YoshikiTakashima! Can we add a couple of tests for the minimum and maximum tuple sizes (i.e. 1 and 12) to make sure these are working correctly, and do not break in the future?


Notifications Dropdown & Likes missing tweaks

The dropdown for notifications and the pop-up window for likes are missing most of the visual tweaks.

I'm aware haha, still haven't gotten around to touching that yet (have a tab open profiling it)

https://github.com/Metamaniac/VRCWebTweaks/commit/9db553ae19ca2cf8e92e10e9db938af96e8e3e08


No documentation

There is no documentation for the code!

We have added a readme.md and docstrings.


Manifest should include a 'merge' method

The 'merge' would be able to override manifest settings attributes with given parameters in a dictionary.
This would benefit to CLI that currently have to implement it themselves but the settings and arguments types does not have the same behavior (None is fine, but empty list from syspaths overwrite settings which is wrong from cli arguments).

Worth to notice we can't stand on implemented logging in code since the ones from django settings processor since it is runned before settings are ready and so they can be controled from settings.

This is not really needed nor useful anymore so i'm closing this issue.


Vnet link to ExpressRoute vs. Vnet peering

What is the relation between Vnet linking to ExpressRoute and Vnet peering, apart from obvious ExpressRoute connectivity to Onprem resources?
Do I still need Vnet peering for Vnets linked to the same ExpressRoute circuit to have the resources from linked Vnets communicate to each other?
Am I right that using Hub-and-Spoke Vnet topology I can overcome Vnet linking to ExpressRoute limitation?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc3df950-cbe6-9514-8768-1614312ab0c3
Version Independent ID: a40c4a7f-2c61-4fa4-fafe-1eaa67e794fe
Content: Link a virtual network to an ExpressRoute circuit: PowerShell: Azure
Content Source: articles/expressroute/expressroute-howto-linkvnet-arm.md
Service: expressroute
GitHub Login: @ganesr
Microsoft Alias: ganesr

VNet peering and Links are unrelated. VNEt links are the way you connect an ExpressRoute circuit to a VNet. Since we have deprecated all classic APIs this is not relevant for VNet peering.
From: michal-staniszewski<EMAIL_ADDRESS>Sent: Sunday, August 19, 2018 12:34 PM
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Ganesh Srinivasan<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [MicrosoftDocs/azure-docs] Vnet link to ExpressRoute vs. Vnet peering (#13648)
What is the relation between Vnet linking to ExpressRoute and Vnet peering, apart from obvious ExpressRoute connectivity to Onprem resources?
Do I still need Vnet peering for Vnets linked to the same ExpressRoute circuit to have the resources from linked Vnets communicate to each other?
Am I right that using Hub-and-Spoke Vnet topology I can overcome Vnet linking to ExpressRoute limitation?
Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc3df950-cbe6-9514-8768-1614312ab0c3
Version Independent ID: a40c4a7f-2c61-4fa4-fafe-1eaa67e794fe
Content: Link a virtual network to an ExpressRoute circuit: PowerShell: Azurehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.microsoft.com%2Fen-us%2Fazure%2Fexpressroute%2Fexpressroute-howto-linkvnet-arm&data=02|01|Ganesh.Srinivasan%40microsoft.com|183aadc2027b462f4f5708d6060ab062|72f988bf86f141af91ab2d7cd011db47|1|0|636703040318460623&sdata=18S%2BrI7h9PlDopE%2B7mPe9RCz0B%2B84NINOCas38g1QxU%3D&reserved=0
Content Source: articles/expressroute/expressroute-howto-linkvnet-arm.mdhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fazure-docs%2Fblob%2Fmaster%2Farticles%2Fexpressroute%2Fexpressroute-howto-linkvnet-arm.md&data=02|01|Ganesh.Srinivasan%40microsoft.com|183aadc2027b462f4f5708d6060ab062|72f988bf86f141af91ab2d7cd011db47|1|0|636703040318460623&sdata=jYpacSz%2FaY3neeogjdpY48tkJDkRKXe7lpN1%2Bhyg19M%3D&reserved=0
Service: expressroute
GitHub Login: @ganesrhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fganesr&data=02|01|Ganesh.Srinivasan%40microsoft.com|183aadc2027b462f4f5708d6060ab062|72f988bf86f141af91ab2d7cd011db47|1|0|636703040318470628&sdata=n4KM8HUuQTUaqDqdwaq2Ce88FN7yuXYNGE0v3sq0hLg%3D&reserved=0
Microsoft Alias: ganesr

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F13648&data=02|01|Ganesh.Srinivasan%40microsoft.com|183aadc2027b462f4f5708d6060ab062|72f988bf86f141af91ab2d7cd011db47|1|0|636703040318470628&sdata=5620CRN6YBYlRAqlfvKTLrU2IdBR6En0o8KIT16DqEk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFxYnqhgEvZGcN98C6YSErUU4y-lw272ks5uSb2dgaJpZM4WDFo3&data=02|01|Ganesh.Srinivasan%40microsoft.com|183aadc2027b462f4f5708d6060ab062|72f988bf86f141af91ab2d7cd011db47|1|0|636703040318480632&sdata=p6l%2Fw5CjCqHTemntX%2FOuQjKd1PcQ4JIt3r%2BTUr9HrhM%3D&reserved=0.

@michal-staniszewski It seems that @ganesr has answered your question.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

What is the relation between Vnet linking to ExpressRoute and Vnet peering, apart from obvious ExpressRoute connectivity to Onprem resources?
Do I still need Vnet peering for Vnets linked to the same ExpressRoute circuit to have the resources from linked Vnets communicate to each other?
Am I right that using Hub-and-Spoke Vnet topology I can overcome Vnet linking to ExpressRoute limitation?
Thanks!
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: dc3df950-cbe6-9514-8768-1614312ab0c3
Version Independent ID: a40c4a7f-2c61-4fa4-fafe-1eaa67e794fe
Content: Link a virtual network to an ExpressRoute circuit: PowerShell: Azure
Content Source: articles/expressroute/expressroute-howto-linkvnet-arm.md
Service: expressroute
GitHub Login: @ganesr
Microsoft Alias: ganesr

We are thinking about applying this kind of topology, it's a shame that nobody answer this thread. Michal, could you update your situation right now about this?

@scr8er VNETs linked to the same ExpressRoute circuit will be able to communicate with eachother. This is discussed in the FAQ.
You can still add peering between them if you would like.

Thank you for your answer @TravisCragg-MSFT
I'm sure that it would be much more interesting to discuss the advantages/disadvantages of this architecture because that's the reason @michal-staniszewski open this thread.
https://docs.microsoft.com/en-us/azure/architecture/reference-architectures/hybrid-networking/hub-spoke
ExpressRoute Vnet links are limited compared with Vnet Peering (500 vs 10-100) also, peering and ExpressRoute Costs difference is remarkable. As a non-transitive solution, Vnet isolating is accomplished easily and it fits perfectly with a subscription per department enterprise cloud model.
It allows, for example, to deploy a single firewall solution over Hub Vnet to filter all traffic and assign responsibilities between communications department as it used to do on On-Premises models.
That is what I think would be interesting to discuss about It, pros n cons.


SASS-1034 - Rework Employment details summary page for EOY functionality

Description
Added 'not started' status tags to benefits for employment EOY and updated tests.
Add a link to the relevant story in Jira
SASS-931
Checklist PR Reviewer
Before Reviewing

[ ]  Have you pulled the branch down?
[ ]  Have you assigned yourself to the PR?
[ ]  Have you moved the task to “in review” on JIRA?
[ ]  Have you checked to ensure all dependencies are up to date?
[ ]  Have you checked to ensure its been rebased against the current version of master?

Whilst Reviewing

[ ]  Have you run the tests?
[ ]  Have you run the journey tests?
[ ]  Have you looked at the JIRA story to make sure all Acceptance Criteria has been met?

After Reviewing

[ ]  Have you checked for merge conflicts or any changes in the current master that may affect the current pull request? i.e. does it need another rebase?
[ ]  Have you checked to make sure there are no builds in the pipeline before you merge?
[ ]  Have you moved the task to “in pipeline” on Jira?

[x]  Have you rebased against the current version of master?
[x]  Have you checked code coverage isn’t lower than previously?

After PRs been raised

[x]  Have you checked the PR Builder passes?

PR for stub: https://github.com/hmrc/income-tax-submission-stub/pull/55

stub pr: https://github.com/hmrc/income-tax-submission-stub/pull/56


TAJO-2126: Allow parallel execution of non-leaf sibling ExecutionBlocks

The change looks straightforward and reasonable. But, I'm concerned with potential side effects. Did you do enough tests in cluster environments?

I did basic tests to verify query results, but there is one thing I'm concerned with. That is the shuffle cost. This patch enables the parallel execution of non-leaf EBs, thereby more shuffle operations can be executed simultaneously. It can increase the shuffle cost especially for range shuffle due to heavy index search.
So, we need to improve hash shuffle by reusing http connections and range shuffle by redesigning the index structure.
However, I think the heavy shuffle costs should be addressed in other Jiras. What do you think?

Do you mean more shuffle cost caused by heavy load?

It is possible in single query execution. If multiple queries are executed, the shuffle cost of the current implementation will also be huge.

Yep, I agree. I think that this patch will enhance the machine resource utilization instead of causing more shuffle cost.
+1 LGTM

Thanks for your review!


Ontology no longer builds due to unsatisfiable classes in the ontology

From sometime in the last 24hrs, the ontology build fails with the following error:
06:22:34  ROBOT_JAVA_ARGS=-Xmx48G robot --catalog catalog-v001.xml merge -i extensions/go-lego-edit.ofn --collapse-import-closure true --include-annotations false reason -r ELK --exclude-duplicate-axioms true --remove-redundant-subclass-axioms true --exclude-tautologies structural relax reduce --named-classes-only true annotate -O http://purl.obolibrary.org/obo/go/extensions/go-lego.owl -V http://purl.obolibrary.org/obo/go/releases/2022-06-16/extensions/go-lego.owl -o extensions/go-lego.owl
06:23:55  ERROR There are 1 unsatisfiable classes in the ontology.
06:23:55  ERROR     unsatisfiable: http://purl.obolibrary.org/obo/CL_0009103

Tagging @cmungall @balhoff @pgaudet @vanaukenk

This affect all pipelines.

This seems like a similar event to the previous Uberon problem. There was a CL release yesterday. Something confusing is that last week I implemented a GH actions workflow that was meant to catch these things before the ontologies even made releases: https://github.com/INCATools/ubergraph/actions/workflows/test-merged.yaml
For this one I'll look at pinning the CL version first off.

lymph node marginal reticular cell SubClassOf Nothing

lymph node marginal reticular cell SubClassOf lymph node fibroblastic reticular cell

lymph node fibroblastic reticular cell EquivalentTo fibroblastic reticular cell and (part of some lymph node)

fibroblastic reticular cell SubClassOf myofibroblast cell

myofibroblast cell SubClassOf somatic cell

somatic cell SubClassOf native cell

native cell SubClassOf cell

cell SubClassOf connected anatomical structure

connected anatomical structure EquivalentTo anatomical structure

anatomical structure SubClassOf material anatomical entity

Noting that report is automatically uploaded here: https://go-dropbox.s3.amazonaws.com/unsatisfiable_explanations.md

@kltm I'm pinning to http://purl.obolibrary.org/obo/cl/releases/2022-02-16/cl-base.owl (#23511)
You may want to use http://purl.obolibrary.org/obo/cl/releases/2022-02-16/cl-basic.owl in the Solr load.

Testing on go-ontology-dev pipeline.


Fixed wrong argument in inputs.s input_desktop (issue #468)

Changed
char* name_simple = strdup(name_len);
to
char* name_simple = strdup(name);
in inputs.c input_desktop
line 199

I should not write C code at night :)

I should not write C code at night :)

Relatable :sweat_smile:


Initialize size of split views in SCM should be equal

#33267

Have a mr workspace with two workspaces each having git support
Notice the inital layout of views in the SCM viewlet is not equal. The second workspace just gets around 20% of space
Doing some changes in the second workspace will leave the split view very small. Due to that I believe they should be the same size to start with. This way it is easier for user to not discover that we support git in a MR environment

I'm pretty sure this isn't true. The initial layout, without any persistence, will always be perfectly split.
There must be something else, investigating.

Yep steps:

Have two repositories open, from two open folders
Collapse the second one
Remove the second folder from the workspace
Add it again

@joaomoreno When you add it back what is the initial size? Guessing there is no initial size and default size was taken

I still see this in the latest.
Whenver I add a new folder to a workspace it's git view is the minimal size, not equal. I would not expact that -> reopening

Sorry but I have to reopen this, it is still not behaving like it should.
Once a split view to git is added the size should be split between them, however the current way random views get minimized (even though they had a good size before a new view is added).
Tried out with latest insiders which contains your fix.

Starting from none and then adding Git repos to subfolders of a single workspace folder still gets out of balance at 3:

And then more (never changing the size manually):

Reopening for consideration. Not critical for the release from what I see.

That's ok.

code-insiders --user-data-dir SOME_NEW_PATH
Open some folder in code, like vscode, open the git view, close vscode
Start code-insders again as in step 1., add a second folder to your workspace
Notice that the second folder is minimized in the git view

I would expect them to be the same size in 4.
IMHO the issue comes from the fact that when closing vscode in step 2 you remember that the first folder has the maximum size of the pane and that leads to the fact that in 4 it pushed out the second folder.

Fixed in master. Initial sizes are now completely different. If you multi select in the provider list, the entire space will be split among all views.

We no longer use split views for git -> verified

@isidorn I think we use split views for git especially in a Multi root workspace when you select multiple repositories

@sandy081 thanks for letting me know. Though now whenever I select an additonal repo the space is always evenly split between them -> verified


Add svg & png versions of a hexagon badge.

svg hex measures 5.08cm from top to bottom.
png hex is just big.

Awesome!  Should we add these to .npmignore so it doesn't accidentally get pushed to npm?

✨✨✨ wonderful. Yeah, not publishing to npm would be a good move hah.

np, I'm not seeing a .npmignore though do you want me to make one or should I add it to the .gitignore? Also, do you want me to add the other badge too?

went ahead and added the .npmignore, ignoring all png & svg files

@tzmanics Cool this looks good to go.

@tzmanics did you see https://cloud.githubusercontent.com/assets/121766/11316733/02ade7b0-8fc8-11e5-88f9-8858213841ab.png?

I'm for collecting all the logos!

@dcousens Yea! Do you want me to add it to this PR?
I could also make a logos dir and add them all (+ reflect the change in the .npmignore) :yum:

HI TARA. that is all
On Monday, November 23, 2015, Tara Z. Manicsic<EMAIL_ADDRESS>wrote:

@dcousens https://github.com/dcousens Yea! Do you want me to add it to
this PR?
I could also make a logos dir and add them all (+ reflect the change in
the .npmignore) [image: :yum:]
—
Reply to this email directly or view it on GitHub
https://github.com/feross/standard/pull/336#issuecomment-159125010.

--
Sent from my phone

+1 to the logos folder

Thoughts @feross?

here is it. I'll revert if you want it done differently nbd.

@feross got an SVG?

Don't move badge.png and badge.svg from the root into logos/, or everyone's readme badges will break!

SVG for my badge is here:
<?xml version="1.0" standalone="no"?><!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"><svg width="100%" height="100%" viewBox="0 0 181 209" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xml:space="preserve" style="fill-rule:evenodd;clip-rule:evenodd;stroke-linejoin:round;stroke-miterlimit:1.41421;"><g id="logo"><path id="template_outline" d="M0,51.944l90.197,-51.944l90.198,51.944l0.605,105.112l-90.197,51.944l-90.803,-51.944l0,-105.112Z" style="fill:#f3df49;"/><path id="j" d="M46.032,150.054l13.192,-8.06c2.545,4.556 4.861,8.41 10.414,8.41c5.323,0 8.679,-2.102 8.679,-10.279l0,-55.605l16.2,0l0,55.837c0,16.938 -9.835,24.648 -24.185,24.648c-12.959,0 -20.482,-6.775 -24.3,-14.952" style="fill:#2e2e2c;"/><path id="s" d="M103.316,148.302l13.191,-7.71c3.472,5.724 7.985,9.93 15.969,9.93c6.713,0 10.993,-3.388 10.993,-8.061c0,-5.607 -4.397,-7.593 -11.803,-10.863l-4.049,-1.754c-11.688,-5.022 -19.441,-11.33 -19.441,-24.647c0,-12.266 9.257,-21.612 23.722,-21.612c10.299,0 17.704,3.622 23.027,13.084l-12.613,8.177c-2.778,-5.023 -5.786,-7.009 -10.414,-7.009c-4.744,0 -7.753,3.038 -7.753,7.009c0,4.906 3.009,6.893 9.951,9.93l4.05,1.752c13.77,5.958 21.523,12.032 21.523,25.699c0,14.72 -11.456,22.78 -26.845,22.78c-15.044,0 -24.764,-7.242 -29.508,-16.705" style="fill:#2e2e2c;"/><text x="24.297px" y="72.286px" style="font-family:Neutra Text;font-size:35px;font-weight:700;fill:#2e2e2c;">s<tspan x="38.507px 52.227px " y="72.286px 72.286px ">ta</tspan>ndar<tspan x="137.417px " y="72.286px ">d</tspan></text></g></svg>

Can't attach it to the issue, so maybe @tzmanics can add it to this PR?

@feross yikes, reverted & fixed that! The standard-hex svg required the neutra text font, I fixed it, hope that's cool.

Forgot to merge this – it's merged now!

Yay! Super stoked to get all these hex Standard stickers! Let me know if you need any other help!


#2202 - Moved the control get cmd to Pages API

Switched the spo control get command to the Pages API. Mapped the output of the API to the output of how it was before. Apart from the htmlProperties as this is meant to change/break.

This should fix it. As we're moving away from the old Pages class, I moved a method to another file, but seems that other commands still made use of it and didn't include all the type tests.

Merged manually. Thank you! 👏


charts/presto: Make HIVE_HOME /opt/hive and set /opt/hive/conf to emptyDir

Ensures that we have a writable tmpfs for our configfiles which get
symlinked in at runtime. This ensures that even with a read only rootfs,
we can symlink the config files to the correct location.

/test integration-aws-metering


Support command "EXISTS"

https://redis.io/commands/exists

This issue could be closed.
https://github.com/Qovery/RedisLess/pull/39


Ensure SEGIntegration initializes with Adobe

This is what I believe was originally wrong with my implementation after end to end testing.
The original issue surfaced was after configuring Adobe with sample app in the repo, I set a break point on the createWithProperties method, to ensure that this was being called. The tests were setup to validate against the ADBMediaObject mock, but the e2e tests failed to hit that break point, telling me my actual logic doesn't not reach that point.
Test setup:
#import <Segment-Adobe-Analytics/SEGAdobeIntegrationFactory.h>

@implementation SEGAdobeAppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
    SEGAnalyticsConfiguration *configuration = [SEGAnalyticsConfiguration configurationWithWriteKey:@"<my write key>"];
    configuration.trackApplicationLifecycleEvents = NO; // Enable this to record certain application events automatically!
    configuration.recordScreenViews = NO; // Enable this to record screen views automatically!
    [configuration use:[SEGAdobeIntegrationFactory instance]];
    [SEGAnalytics setupWithConfiguration:configuration];
    [SEGAnalytics debug:YES];

    [[SEGAnalytics sharedAnalytics] track:@"Video Playback Started" properties:@{
                                                                                @"content_asset_id" : @"1234",
                                                                                @"ad_type" : @"pre-roll",
                                                                                @"video_player" : @"youtube",
                                                                                } options: @{}];
    return YES;
}

I also commented out this logic so it wouldn't return nil for the config
I've implemented a solution that solves for not properly passing in the Adobe heartbeat instances (ADBObject, ADBMediaHeartbeat) when SEGAdobeIntegration was being created.
Let me know if I'm way off here!

This works for now, but I need to refactor this

Can have one factory AdobeObjectFactory build both ADBMediaHeartbeat and ADBMediaObject
Move into it's own file
Have the podspec not include downloading this file to make it private

Can have one factory AdobeObjectFactory build both ADBMediaHeartbeat and ADBMediaObject
Not required, separate is fine.

Move into it's own file
Also not required, same file is fine.

Have the podspec not include downloading this file to make it private
What do you mean here? Which file? There are no podspec changes in this PR.

@f2prateek  Made your requested changes, you were right the factory handled passing in the ADBMediaHeartbeat/Object, so I removed that.
I also cleaned up the naming like you suggested


WIP: Some fixes  in Get-Date -UFormat

PR Summary

Address the comment
After #4805 we use local datetime in evaluating %s format and UTC in epoch constant.
In the PR we convert  local datetime to UTC.
https://stackoverflow.com/questions/2883576/how-do-you-convert-epoch-time-in-c

Fix %l uformat

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[ ] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[ ] Not Applicable or can only be tested interactively
OR
[x] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

/cc chuanjiao10

@iSazonov Would you mind updating the PR description?  Your item #1 indicates your switching to UTC from local time but it doesn't indicate what problem is being fixed? (i.e., we do we need this change?)
Thanks,

@dantraMSFT Yes, I'll update - after the first commit I discovered there is still some breaking changes (to be compatible with Unix) and I want to bring them all together for consideration by PowerShell Committee.


ClusterServiceVersion not found

I'd like to look into including this in an internal Operator Catalog, but can't find any CSVs available. I wonder if that is something you might be able to provide? Looks like this is an Operator SDK like operator so maybe that's pretty easy to run the operator bundle creation.

/remove-lifecycle stale
/lifecycle frozen

Hi @flickerfly,
We don't really provide support for this operator outside if it's use in some of our managed environments. I would check out https://github.com/openshift/oadp-operator as it uses velero at it's core as well.
Thanks!
/remove-lifecycle frozen
/close


Error in  __get_RS for kind='change' in release 0.0.4

The error described in #4 still exists in the current release (0.0.4) and can give very different results.

Thanks for the notification.
Updated to 0.0.5 on PyPi: https://pypi.org/project/hurst/


Add preliminary support for the anyOf keyword

This change introduces support for the anyOf keyword. Other PRs that add support for anyOf/oneOf exist, but are stale and/or incomplete ( #302, #417, #940 ).
The keyword is NOT supported in arrays (using the items keyword).
Options provided in the anyOf keyword are rendered using a new component called AnyOfField, this can be overridden with a custom field using the fields property.
I'd like to follow-up on this PR with work to add support for anyOf in arrays and oneOf. I decided against submitting that work in this PR to help keep reviews and discussion manageable.

Checklist

[ ] I'm updating documentation

[ ] I've checked the rendering of the Markdown text I've added
[ ] If I'm adding a new section, I've updated the Table of Content

[x] I'm adding or updating code

[x] I've added and/or updated tests
[ ] I've updated docs if needed
[x] I've run npm run cs-format on my branch to conform my code to prettier coding style

[x] I'm adding a new feature

[x] I've updated the playground with an example use of the feature

Note that the unit tests are failing due to the New year rollover, which I've fixed/band-aided in a separate PR here https://github.com/mozilla-services/react-jsonschema-form/pull/1119


Replaced links to old repo with the current ones

README.md had some links to old, non-organization repo. Also the help message from !help command showed old broken link to wiki page.

#946


Feature: multiple lists

I like to manage multiple lists under one User Account. This is very helpfull to manage lists for the family and Kids.

It's something I've thought about. In the meantime, you can create additional accounts and if you have your wishlist "Suggestions Method" as either "Surprise me" or "Auto approve", then you can add items on anybody's list. With the Auto approve, it will allow the list owner to see the item and delete or modify it if they want


Difference between master and stable branches?

Hello,
Stable is for Swift 2.x.
Master is for Swift 3.x and expermients like: app layer (https://github.com/httpswift/swifter/blob/master/Sources/Swifter/App.swift), and pure TLS implementation (https://github.com/httpswift/swifter/tree/master/Sources/TLS).
Both did have their own life so I will need to merge a couple of bugfixes from master to stable.
Right now there is no sense to keep both so master will die (I will keep app layer and TLS as side projects).


Downloading zip

Downloading zip file downloads a template of configs and index files etc + the written code.
The problem is that it cannot be 'just ran' because i.e. entry point file name is not updated in the webpack.config.js.
I could attempt to fix the issue, just needs some guidance for the approach I should use, as I'm not familiar with the codebase.
Also the version I've downloaded didnt have babel-core in its devDependencies (although it should have), but from what I see its fixed in the source code. But was the fix released?

Yes, the downloaded version does not have babel-core as dev dependencies. But no problem with entry point file.

maybe if your entry point's name matches the default, i've called mine index.js and it wont work obviously with the downloaded webpack.config.js. Here it is for easy check:
var path = require('path');
var webpack = require('webpack');
var HtmlWebpackPlugin = require('html-webpack-plugin');

var loaders = [];

module.exports = {
  devtool: 'eval-source-map',
  entry: path.resolve('src', 'main.js'),
  output: {
    path: path.resolve('build'),
    filename: '[name].js',
    publicPath: '/'
  },
  plugins: [
    new HtmlWebpackPlugin({
      template: path.resolve('src', 'index.tpl.html'),
      inject: 'body',
      filename: 'index.html'
    })
  ],
  module: {
    loaders: loaders
  }
};

2 more things: I also needed to add webpack-merge, and when I make changes the project.zip does not get updated, I always get the same one.


Issue related to base branch artifact

I am unable to debug that where does the action finds for the base ref artifacts, if it looks for the previous successful workflow run then I have that artifacts in previous one, I am sharing the logs here and screenshot also -
Looking for artifact "coverage-release-v1.74.0-CLOUDTEAM-11889" in the following workflows: jpi-cloud-usermanagement
Warning: No artifacts found for the following workspaces: jpi-cloud-usermanagement

Does your application requires any specific permission on workflows to fetch the artifact?

My repository is internal not private, does this action only works for private repositories?

Hi
I'll need more information here (logs) or better yet a test repo to see where you've gone wrong.

Does your application requires any specific permission on workflows to fetch the artifact?

No

My repository is internal not private, does this action only works for private repositories?

There are only two types of github repositories. Public and private.

I have it working on an internal repository.
One thing to check is do you name your jobs (like below):
jobs:
  build:
    name: CI - Build and Test

If so, try specifting the artifact_download_workflow_names as below:
- name: Generate Coverage Report
      uses: clearlyip/code-coverage-report-action@v3
      if: steps.findUnitTestsDll.outputs.hasFoundTestDll == 'true'
      id: code_coverage_report_action
      with:
        badge: true
        markdown_filename: code-coverage-results
        filename: 'test-results/cobertura.xml'
        fail_on_negative_difference: true
        negative_difference_threshold: 0.005 #0.5%
        artifact_download_workflow_names: 'CI - Build and Test'

I am having this same issue:
No artifacts found for the following workspaces: Code-Coverage-Cron
I have
- uses: clearlyip/code-coverage-report-action@v4
        with:
          filename: 'coverage/clover.xml'
          artifact_download_workflow_names: 'Code-Coverage-Cron'

The name of the job is
name: 'Code-Coverage-Cron'
on:
  workflow_dispatch:
  schedule:
    - cron: '0 0 1 * *'

jobs:
  cron:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4

      - name: Run phpunit coverage
        run: XDEBUG_MODE=coverage ./vendor/bin/phpunit -c dev/tests/unit/phpunit.azure.xml --testsuite App_Code_Unit_Tests --coverage-clover 'coverage/clover.xml'

      - name: Archive code coverage results
        uses: actions/upload-artifact@v3
        with:
          name: coverage-develop
          path: coverage/clover.xml

      - uses: clearlyip/code-coverage-report-action@v4
        with:
          filename: 'coverage/clover.xml'
          artifact_download_workflow_names: 'Code-Coverage-Cron'

This is with a  private repo.

You be best to turn on job debugging


Fix "Unable to init from given binary data." when upload media

Storage::get($path) returns file contents as a string which may not be cast to valid binary data for Image::make() to be able to read.

This is only necessary when running on Wsl 1.


Introduce a new NW Network instance type family

What this PR does / why we need it:
Introduces a new NW class of Network specific instance types.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #40
Special notes for your reviewer:
Based on https://github.com/kubevirt/common-instancetypes/pull/57
Release note:

A new `NW` class of instance types has been introduced focused on `Network Intensive` workloads.

/cc @0xFelix

/cc @orelmisan Do you have any suggestions or requirements for networking related instancetypes?

Hm. Not n1?

Hm. Not n1?

If https://github.com/kubevirt/common-instancetypes/pull/63 lands I'll switch this over to n.

/remove-lifecycle rotten

/close
Closed in favor of #123


Add intro for the resume

Write 3-4 sentences about myself, my work and what I want to do in the future.

Succesfully done!


Generalise update.set()

It looks like there are a bunch of strategies one can use to implement this behaviour
diesel::update(my_table::table).set(array_col.index(1).eq(true))

My line of reasoning is -

There should be a trait between Column and Assign which Column implements which reduces to the current implementation
This allows the definition of AssignmentTarget for arbitrary types which will be picked up by the AsChangeset impl.

I hit a wall updating the definition for AsChangeset as I have an unbounded type parameter (changset.rs:44). I was exploring a few workarounds but none that made me particularly happy.
Would be great to know your thoughts on this direction and whether it's possible to complete this implementation without something heavy like introducing a new param to AsChangeset.

Thanks for opening this PR :+1:

Would be great to know your thoughts on this direction

Abstracting away the column bound seems sensible for me.

whether it's possible to complete this implementation without something heavy like introducing a new param to AsChangeset.

I cannot really comment on that without sitting down and basically implementing the thing on my own. What I can do is to is outlining a few constraints on potential solutions and give a few ideas on how to workaround that unbound parameter problem
So the basic constraint first: We do not want to change the public trait/function signature there, so anything needs to fit into the current AsChangeset impl. This means adding a generic parameter to AsChangeset is out of scope.
So how could it work anyway? Basically the answer there is that we don't need the AssignmentTarget::walk_ast function at all. This removes the need to have a generic parameter for DB there. This raises the question how would we get access to the customized walk_ast implementation? We can solve that by having a AssignmentTarget::get_target() function that returns a type with a matching QueryFragment impls for each implementation. This function would be called inside of the AsChangeset impl for Eq<Left, Right> so that we store the custom query node in Assign. For colums this would return a new type wrapper that implements QueryFragment like the current implementation. Put together that would look somewhat like this:
trait AssignmentTarget {
    type Table;
    type QueryAstNode;

    fn get_target(self) -> Self::QueryAstNode;
}

impl AssignmentTarget for C where C: Column {
    type Table = C::Table;
    type QueryAstNode = ColumnWrapperForUpdate<C>;

    fn get_target(self) -> Self::QueryAstNode {
        ColumnWrapperForUpdate(self)
    }
}

struct ColumnWrapperForUpdate<C>(C);

impl<DB, C> QueryFragment<DB> for ColumnWrapperForUpdate<C> where DB: Backend + DieselReserveSpecialization, C: Column {
    fn walk_ast<'b>(&'b self, mut out: AstPass<'_, 'b, DB>) -> QueryResult<()> {
        out.push_identifier(C::NAME)?;
    }
}

Ok - thanks for the feedback. Makes sense.
I ran in to a couple of other issues implementing this. Most frustrating is being unable to use the fully qualified column names that QueryFragment generates.
Invalid:
UPDATE "posts" SET "posts"."tags"[$1] = $2 WHERE ("posts"."id" = $3) RETURNING "posts"."id", "posts"."tags"
Valid:
UPDATE "posts" SET "tags"[$1] = $2 WHERE ("posts"."id" = $3) RETURNING "posts"."id", "posts"."tags"
I'm assuming this will need to leave QueryFragment alone so will most likely end up with some duplication, although I'm going to have another think about it when I get the time.

Thanks - that was helpful.
This looks to be working barring some test output clearup, but I had a few points to raise -

I wanted to blanket implement AssignmentTarget for all T where T: Column couldn't as AssignableExpression has an overlapping impl (missing speciailzation), so changed the table macro instead for all Column definitions.
I wasn't sure about the best strategy for exposing/hiding internal types, such as ColumnWrapperForUpdate. Afaict, not making this pub makes Rust unhappy as it's leaked elsewhere.
I don't love the name UncorrelatedColumn, but that seemed the most reasonable given the PG docs https://www.postgresql.org/docs/14/sql-expressions.html

@pksunkara @chusteven This PR is about enabling queries like
diesel::update(my_table::table).set(array_col.index(1).eq(true))

UPDATE my_table SET array_col[1] = true

Especially about addressing a single array element as part of the SET clause of the update statement. That was not possible yet, as the left side of such a SET statement was always expected to be a column.

If that's too reductive, then the only feedback I might be is to add tests for other types of updates (maybe a few from the PG documentation like an operator invocation (a + b), type cast (lit as i32), etc.)

These kinds of updates require flexibility on the right side of the SET statement, as everything there is on the right side of the assignment operator. Expressions like col.eq(col + 1) (or any other diesel expression) are already  supported there.
Essentially this change is about allowing some flexibility on the left side of the assignment operator as well.

I had assumed the update syntax provided would be standard (e.g. json update foo set my_column->'a' = 1234) but that doesn't seem to be the case. It's mentioned on the arrays page, but not as part of the syntax in update.
The main motivation for providing Uncorrelated column and AssignableExpression was to make extending this for other expressions slightly less obscure (e.g. implement the AssignableExpression trait and rewrite the expression with column.uncorrelate()). In either case, though, I do agree that it's adding unecessary indirection.
Should get some time this week to address the above.

CI failures are caused by https://github.com/clap-rs/clap/issues/3648 / https://github.com/clap-rs/clap/pull/3646

Referencing issue #1681


Backport package list fix to 0.5

Backport https://github.com/dcos/dcos-core-cli/pull/13 to 0.5

see https://github.com/dcos/dcos-core-cli/pull/18


Register currency

Description of proposed changes:
Adds register currency and changes to a new representation of blockchains and transfer kinds that more accurately model reality.
Practical tips for PR review & merge:

[ ] All GitHub Actions report PASS
[ ] Newly added code/functions have unit tests

[ ] Coverage tools report all newly added lines as covered
[ ] The positive scenario is exercised
[ ] Negative scenarios are exercised, e.g. assert on all possible errors
[ ] Assert on events triggered if applicable
[ ] Assert on changes made to storage if applicable

[ ] Modified behavior/functions - try to make sure above test items are covered
[ ] Integration tests are added if applicable/needed

Codecov Report

Merging #556 (b1b7697) into dev (6d24926) will increase coverage by 1.76%.
The diff coverage is 93.05%.

:exclamation: Current head b1b7697 differs from pull request most recent head e799f67. Consider uploading reports for the commit e799f67 to get more accurate results

@@            Coverage Diff             @@
##              dev     #556      +/-   ##
==========================================
+ Coverage   78.16%   79.93%   +1.76%
==========================================
  Files          46       48       +2
  Lines        8551     9652    +1101
==========================================
+ Hits         6684     7715    +1031
- Misses       1867     1937      +70

Impacted Files
Coverage Δ

pallets/creditcoin/src/helpers.rs
90.16% <ø> (-3.25%)
:arrow_down:

pallets/creditcoin/src/migrations/mod.rs
0.00% <0.00%> (ø)

pallets/creditcoin/src/ocw/errors.rs
80.00% <ø> (-2.86%)
:arrow_down:

pallets/creditcoin/src/ocw/nonce.rs
99.47% <ø> (ø)

pallets/creditcoin/src/ocw/tasks/collect_coins.rs
98.92% <ø> (-0.01%)
:arrow_down:

pallets/creditcoin/src/lib.rs
86.75% <67.56%> (-1.86%)
:arrow_down:

pallets/creditcoin/src/types/platform.rs
80.67% <81.17%> (+14.81%)
:arrow_up:

pallets/creditcoin/src/migrations/v1.rs
96.25% <81.25%> (-0.96%)
:arrow_down:

pallets/creditcoin/src/migrations/v2.rs
94.73% <82.85%> (-3.08%)
:arrow_down:

pallets/creditcoin/src/migrations/v6.rs
88.78% <88.78%> (ø)

... and 25 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Let's hold off on this merge until we merge the current dev branch to test.


Define == between ::KeyedDistribution and ::Distribution

Similarly, defines == between ::KeyedSampleable and ::Sampleable. Closes #6

It looks like this behaviour is undocumented. Does this count as a bugfix or feature for semver?

It looks like this behaviour is undocumented. Does this count as a bugfix or feature for semver?

this would just be a feature


Simplify how filters are customized by adding menu (on hover) to filter badge.  Support adding custom filters with + button and uniquely colored filter badges.

Get rid of expansion panel that shows all filter settings.  Too many mouse clicks for user.

Fixed I believe