.keys or .values breaks iterator

Due to ObjectLikeSequence.keys and values function turning its sequence into a MappingSequence, the iterator breaks upon iteration of either one.
Example:
var Lazy = require('lazy.js');

var a = Lazy({
    'akey': 'aval'
    , 'bkey': 'bval'
    , 'ckey': 'cval'
});

a.keys().each(function(k) {
    console.log(k); // prints akey, bkey, ckey as expected
});

var kit = a.keys().getIterator();
while (kit.moveNext()) {
    console.log(kit.current()); // prints 0, 1, 2
}

var vit = a.values().getIterator();
while (vit.moveNext()) {
    console.log(vit.current()); // prints [ 'akey', 'aval' ], ['bkey', 'bval'] ...
}

The code found here fixes the above, however I still haven't spent the time to figure out how to run existing tests in the repository.

Just FYI, to run the tests in the repository:
npm test

Ah - guess I could have checked there first.


Rule length and package/module length

Similar to the line-length rule, but counting number of lines (or perhaps better, expressions) in a rule, and warn on excessively long ones, like over 25 lines or expressions or something. This ensures proper use of helper functions, rules and other abstractions.
Same thing for packages, or modules/files, which should not be longer than XXX lines.

This is done for file-length in https://github.com/StyraInc/regal/pull/283
Rule length was more complicated than I thought. As opposed to files, there's no easy way to determine where a rule ends just from counting lines in the original Rego code. Looking for a standalone }\n in the first column would likely cover most cases, but not those where the rule body is on a single line, or where someone is using some esoteric custom formatting.
We could do something like "take the last element location from the last expression of the rule body", but that could be a nested expression like a comprehension, and there's no for walk to know when it hits the last element.
Easiest way of doing this would probably be to say that this rule depends on the opa-fmt rule, as then we could make assumptions about formatting. But so far we've managed to avoid having rules depend on other rules, and I think that's a good principle to follow.


Tutorial/demo on writing a simple multi-stream QUIC client

This builds on the existing tutorial on writing a blocking QUIC client to add multi-stream support. We also add a corresponding demo.
There's also a few miscellaneous improvements and cleanups to some of the previous tutorial material.
Finally we update quicserver to be able to interoperate with the multi-stream demo code.

I am not overly fond of the 'guide' folder name.. Can this be renamed to something more relevant?

I am not overly fond of the 'guide' folder name.. Can this be renamed to something more relevant?

I'm open to suggestions.

tutorial maybe?

All comments addressed and updates pushed. Please take another look.

Fixed the nit. Also added a link to the new page from the guide introduction.
Please take another look.

Ping for second review

I've rebased to resolve a trivial conflict with master, and fixed the typo spotted by @t8m. I assume @hlandau's approval still holds.
@t8m - please take another look.

Ouch, needs another rebase.

Ouch, needs another rebase.

Grrr. Another trivial conflict. This time in quicserver.c. I'm still assuming approvals hold.

You've got to be kidding me....another conflict...

More trivial conflicts. This time caused by the SSL_set_initial_peer_addr to SSL_set1_initial_peer_addr rename. Rebased again. Again I assume the approvals hold

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Pushed. Thanks.


Use Read the Docs for the documentation

It is expected that Esprima will continue to incorporate more useful features in the forthcoming version 3.0 (as well as any future versions). The simplistic documentation available on the web site will not be sufficient anymore. At this point, it is just easier to leverage Read the Docs to generate and host the documentation.
Some other additional advantages:

per-version documentation
integrated search function
PDF generation

Also good to leverage (at some point): localization, i.e. documentation in many different languages.

Now available at http://esprima.readthedocs.io! 🎉

Versioning also works well:

http://esprima.readthedocs.io/en/latest/ for the bleeding-edge from master
http://esprima.readthedocs.io/en/3.1/ for the 3.1 series


installation instructions ?

Summary
Nowhere in the FAQ or other documentation can I find anything that tells me how to download and install AssertJ.  Please add that to the home page or in a WiKi page.
Example
<add example here>

It's in the quickstart section: http://joel-costigliola.github.io/assertj/assertj-core-quick-start.html

I already looked there and did not find what I was looking for, which is what caused me to open this issue in the first place.
I am using plain, simple, Eclipse Oxygen.3 (March 2018) on a small, Java SE project, trying to use AssertJ for unit testing and having no success at all.
For example, where is the JAR file that I need to reference in order for the import to work properly?
Am I supposed to use the Eclipse Marketplace to find AssertJ or should I manually reference the (what is its full name?) JAR file for my small little project?

Hi Fred,
you can download the jar from https://search.maven.org/remotecontent?filepath=org/assertj/assertj-core/3.11.0/assertj-core-3.11.0.jar and reference it in Eclipse.


Select command docs

Added notes in SELECT, FLUSHDB, DBSIZE Docs for usage related to SELECT Command.
use of PORT 7379 in FLUSH DB, BF.EXISTS, HRANDFIELD, JSON.ARRAPPEND, JSON.ARRINSERT, JSON.ARRPOP, JSON.ARRTRIM, JSON.DEBUG, JSON.DEL, JSON.MSET, JSON.OBJKEYS
bash syntax in EXISTS, HRANDFIELD,JSON.DEL,AUTH, BGREWRITEAOF, BITCOUNT,  Docs (Consistent with all DOCs)

One doubt i have
in golang SDK the port should be 7379 instead of 6379?
cc @apoorvyadav1111 , @JyotinderSingh

@apoorvyadav1111 throughout all the docs, We are now using bash consistently. Changed all required files.

Any other changes required please let me know and happy to close any other DOCs issues that are stale.


Change EMS registry input keyboard to numeric type.

Modified EMS registry input text field to use numeric keyboard.

Hi @coltonlemmon ! Thanks for submitting this Pull Request. It looks like someone else already fixed issue #246. We are so sorry this happened, and we have updated our contribution guidelines at https://wildaid.github.io/contribute/index.html so that this should not happen again.
To work on an issue:
Find an issue and comment on it, saying you want to work on it.
You may start work immediately IF there are no other commenters wanting to work on it
How about one of these issues to try next?
#319 - ".0" added automatically when entering weight
#331 - Going back from 'Draft Boardings'

Hi @coltonlemmon!
We noticed you haven't claimed your digital MongoDB swag. To claim your O-FISH badge, head on over to the MongoDB Community forums, login, and reply - making sure to link to this PR.


Error pachages is not installed

Issue Report Checklist

[ ] Searched the issues page for similar reports
[ ] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[ ] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[ ] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[ ] Reset preferences with spyder --reset
[x] Reinstalled the latest version of Anaconda
[ ] Tried the other applicable steps from the Troubleshooting Guide

[ ] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
What steps reproduce the problem?

What is the expected output? What do you see instead?
Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Versions

Spyder version:
Python version:
Qt version:
PyQt version:
Operating System name/version:

Dependencies

PASTE DEPENDENCIES HERE

Hey @ayach993, thanks for reporting. Since you didn't provide any information, it's hard for us to know what's exactly your problem.
Perhaps you can't find your packages if you installed Spyder with our standalone installers. In that case, please read our documentation on how to connect it to external Python installations:
http://docs.spyder-ide.org/current/faq.html#using-packages-installer
I hope that's useful and I'm going to close this issue due to lack of information.


Make type resolution a generic phase, remove ManifestReference

In preparation for inline schemas referring to out of line schemas.


Bootstrap 5 less Port

Is there any update for bootstrap 5.x.x

Going to start working on it this coming week. Hoping to have it all ported over by the end of the month.

Is the Bootstrap 5 port still happening?

Is the bootstrap 5 port still happening?

Hmmm I think it is not


add zeebe command & jobworker yaml for conformance tests

Description
Adding zeebe command & jobworker component bindings.yml files to satisfy the conformance test requirement to move the components to Beta from Alpha.
Checklist

[x] Code compiles correctly
[x] Created/updated tests

Hi @cicoyle it's a bit more involved than that to enable a conformance test :)
In addition to creating the YAMLs there, you also need to:

Add the component to https://github.com/dapr/components-contrib/blob/master/tests/config/bindings/tests.yml
Load it in https://github.com/dapr/components-contrib/blob/0c2ce324b2bf174349c506d4644503075378f0eb/tests/conformance/common.go#L616
Update https://github.com/dapr/components-contrib/blob/master/.github/scripts/test-info.mjs so it runs in GitHub Actions

However, I don't think this component needs a conformance test, because it doesn't really have anything to conform to. The bindings conformance test tests the following operations: read, create, get, list, delete. This component implements neither. So there's not much to conform here - the test is currently only used by bindings that are more similar to pubsub or state stores: https://github.com/dapr/components-contrib/blob/master/tests/config/bindings/tests.yml
CC: @berndverst

@cicoyle I don't think we need this in conformance tests - we should just add it to certification tests. Bindings don't have a standard interface, so a conformance test for bindings is mostly meaningless.
@akkie recently started work on the certification test for this component - and that's really all that is required. Once we have the certification merged we can call this component stable - and I am comfortable skipping the beta stage entirely given this is a binding.
I agree with @ItalyPaleAle that we do not need a conformance test here - and that just unnecessarily takes up a Github task runner. The certification test that is in the works by @akkie will be sufficient. Ultimately stable certification is the real goal here.
Unfortunately I have to recommend that we close this PR @cicoyle

And adding to what @ItalyPaleAle said:
The missing pieces here are also actually spinning up the Zeebe service via Docker etc, and then defining the right Zeebe binding operations to invoke - and what the expected output should be.
I see you have also been involved in https://github.com/dapr/components-contrib/pull/3112 - which I just updated to actually activate the certification tests run.
I think we can skip this PR entirely - and enabling conformance tests for Zeebe would be quite a bit more work for you anyway!

Please note that the contrib code freeze was technically weeks ago and this PR does change an existing component - not just tests. We can only include this PR if you can fix it up before we will be cutting the 1.12 release branch - which may be end of day tomorrow or on Monday.

Ignore my other comment I deleted - I meant to comment on the other Zeebe issue.

Closing - component now has a certification test which supersedes this


Added algorithm,digits,interval to pass through and generate totp

Now you can customise creating totp by passing algorithm,number of digits,interval(in seconds) to generate a totp

@aravi365
The feature you created is helpful, but I think you should rewrite your javascript code with es6 style. You can just put your es6 code in the lib directory, then run npm run build to build the code.
And I'll close this pr, you can reopen it after rewrting the code.
Thx.


Make VirtAPIDown environment agnostic

Signed-off-by: Erkan Erol<EMAIL_ADDRESS>The namespace of Kubevirt is different in different environments.

kubevirt  in https://kubevirt.io/user-guide/operations/installation/
kubevirt-hyperconverged in hco repo
openshift-cnv in OpenShift Virtualization

This PR adds another step to get the namespace from the cluster and to use it in the diagnosis&mitigation.

/lgtm


Some tests hang on Windows

Currently, several tests hang on Windows if the max path limit of 260 characters is not disabled. This happens due to the changes introduced by #2223 that cause an infinite loop in WindowsFileLock described in #2220.  This can be very tricky to debug, so I think now is a good time to address these issues/PRs. IMO throwing an error is too harsh, but maybe we can emit a warning in the top-level __init__.py  on startup if long paths are not enabled.

Hi ! That would be nice indeed to at least have a warning, since we don't handle the max path length limit.
Also if we could have an error instead of an infinite loop I'm sure windows users will appreciate that

Unfortunately, I know this problem very well... 😅
I remember having proposed to throw an error instead of hanging in an infinite loop #2220: 60c7d1b6b71469599a27147a08100f594e7a3f84, 8c8ab60018b00463edf1eca500e434ff061546fc
but @lhoestq told me:

Note that the filelock module comes from this project that hasn't changed in years - while still being used by ten of thousands of projects:
https://github.com/benediktschmitt/py-filelock
Unless we have proper tests for this, I wouldn't recommend to change it

I opened an Issue requesting a warning/error at startup for that case: #2224

@albertvillanova Thanks for additional info on this issue.
Yes, I think the best option is to throw an error instead of suppressing it in a loop. I've considered 2 more options, but I don't really like them:

create a temporary file with a filename longer than 255 characters on import; if this fails, long paths are not enabled and raise a warning. I'm not sure about this approach because I don't like the idea of creating a temporary file on import for this purpose.
check if long paths are enabled with this code. As mentioned in the comment, this code relies on an undocumented function and Win10-specific.


Rich text editor toolbar not visible

Hi. Same issue as with Cultiv Tabify:
When using Rich text editor with lots of text inside of grid (so that I have to scroll down) the RTE toolbar gets hidden.

I have made some CSS which fixes this and it is in PR #2 :)

Seems to work here though?

Thanks @AndersBrohus-MySupport
I'm not sure I like this solution though. You still get 64px of invisible toolbar before it repositions.
I think I would rather have the reorder bar not be sticky instead, and then instead of changing the top position of the toolbar, add a margin-top of 8px to push a bit further down and make things look nice.
What do you think?

Just to clarify, I almost never use the RTE in a grid (I use DTGEs for everything), so I have never run into this issue :)

Hi again :)
It looks fine to me :)
But in a normal v8 isn't the reorder by sticky there?
If it is, shouldn't it continue to be it then? :)

It is, and probably should. I just don't like that the toolbar doesn't attach before scrolling the extra 64px. Maybe it's just me though :)

Fixed in #2


[TenPlay] ERROR: Unable to extract video_id

$ youtube-dl http://tenplay.com.au/channel-eleven/neighbours/2015/2/23
[TenPlay] http://tenplay.com.au/channel-eleven/neighbours/2015/2/23: Downloading webpage
ERROR: Unable to extract video_id; please report this issue on https://yt-dl.org/bug .
$ youtube-dl -U
youtube-dl is up-to-date (2015.02.21)

doesn't reproduce in current version

I'm getting this error with current version (2015.09.22)
$ ./youtube-dl --verbose http://tenplay.com.au/channel-ten/the-bolt-report/2015/9/20
[debug] System config: [u'--prefer-free-formats']
[debug] User config: []
[debug] Command-line args: [u'--verbose', u'http://tenplay.com.au/channel-ten/the-bolt-report/2015/9/20']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2015.09.22
[debug] Python version 2.7.10 - Linux-4.1.6-201.fc22.x86_64-x86_64-with-fedora-22-Twenty_Two
[debug] exe versions: ffmpeg 2.6.4, ffprobe 2.6.4, rtmpdump 2.4
[debug] Proxy map: {}
[TenPlay] http://tenplay.com.au/channel-ten/the-bolt-report/2015/9/20: Downloading webpage
ERROR: Unable to extract video_id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "./youtube-dl/youtube_dl/YoutubeDL.py", line 660, in extract_info
    ie_result = ie.extract(url)
  File "./youtube-dl/youtube_dl/extractor/common.py", line 287, in extract
    return self._real_extract(url)
  File "./youtube-dl/youtube_dl/extractor/tenplay.py", line 38, in _real_extract
    r'videoID: "(\d+?)"', webpage, 'video_id')
  File "./youtube-dl/youtube_dl/extractor/common.py", line 590, in _html_search_regex
    res = self._search_regex(pattern, string, name, default, fatal, flags, group)
  File "./youtube-dl/youtube_dl/extractor/common.py", line 581, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract video_id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

porjo,
I can confirm the issue with your download link and current version of youtube-dl.
But you better create a new bug request. This one is already closed, so developers likely will not see it.

porjo,
I can confirm the issue with your download link and current version of youtube-dl.
But you better create a new bug request. This one is already closed, so developers likely will not see it.


Does this WebUI works only with Open Shift ?

We have deployed Kubevirt (following the kubevirt.io docs) on open source kubernetes and were trying to see if we could get the WebUI on top it. The instructions listed here are all for Open Shift. Does the Web UI for Kubevirt works on open source kubernetes and where should we look for instructions?

It was tested on OpenShift (or OKD). As web-ui's key features are recently based on templates, additional changes to support upstream Kubernetes would need to be implemented (templates are add-on of OKD).
However please note, the kubevirt/web-ui (and related) functionality has been merged to https://github.com/openshift/console recently, making the web-ui-* projects deprecated.
Have you considered using the upstream OKD (formerly OpenShift, https://github.com/openshift)? Simply said, it contains Kubernetes and moves it towards PaaS (from IaaS) by adding features. In other words, what is supported in OKD, is still supported in OKD but adding more.

me too trying run it on kubernetes..

@Nurlan199206 this blog might help you a bit: https://kubevirt.io/2019/KubeVirt_UI_options.html
Long story short, it kinda works on pure k8s but the VM wizard does not open. @glekner is now playing around with it to make it work.


"Open in Printbugger" added to examples' menus

To avoid having to search for an example in a potentially huge list of existing examples in the printbugger, users can now open an example directly from its menu.
When a printbugger is docked to the browser, it will open the example there. If there is one printbugger in the world, the example is added there. When there are none or multuple printbuggers open, a new printbugger with the selected example will open.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 22 (0.0%)  changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 67.422%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

packages/Babylonian-UI.package/BPExampleMorph.class/instance/menuContentsSymbolQuints.st
0
1
0.0%

packages/Babylonian-UI.package/BPExampleMorph.class/instance/openExampleInDockedPrintbugger.st
0
5
0.0%

packages/Babylonian-UI.package/BPExampleMorph.class/instance/openExampleInPrintbugger.st
0
8
0.0%

packages/Babylonian-UI.package/BPExampleMorph.class/instance/openInPrintbuggerClicked.st
0
8
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
6548

Relevant Lines:
9712

💛  - Coveralls


It may need a global agent

I agree.
We need to establish some context for the bot. We need a system role so we can keep the bot between its bounds (guardrails) and then a user and assistant role to help fine-tune the responses.
See this for an example: https://github.com/vueschool/ai-chatbot-course/blob/boilerplate/agents/customerSupportAgent.ts

@dosstx Now this is available through chatCompletion function.


Cannot even connect to simple database connection from inside the query window

Issue Type: Bug
Cannot even connect to simple database connection from inside the query window
SQL Operations Studio version: sqlops 0.30.6 (df7e3ec7d52a82febee5b597a1019cabf021b883, 2018-06-19T21:45:43.589Z)
OS version: Windows_NT x64 10.0.17134

@devoneonline I wasn't able to repro this issue.  Did you run into a specific issue when clicking the "Connect" button in the Query Editor?

Hi Karl,
I downloaded the latest sql operation studio, which ever was available for
download.
I clicked on the same button mentioned in the screenshot, when entered
details for the local sql server express with windows authentication.
It never connects ..
Please let me know if more information is needed.
Thanks & Regards,
Dev
On Sat, Jun 30, 2018 at 1:51 AM Karl Burtram<EMAIL_ADDRESS>wrote:

@devoneonline https://github.com/devoneonline I wasn't able to repro
this issue. Did you run into a specific issue when clicking the "Connect"
button in the Query Editor?
[image: screen]
https://user-images.githubusercontent.com/599935/42113156-24e15acc-7b9f-11e8-9077-b9275b51c9ef.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/sqlopsstudio/issues/1792#issuecomment-401463842,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGWgVZe_KX_VyYJkP8n9Wrnsu7Ge6SZOks5uBoxRgaJpZM4U8dn3
.

@devoneonline are you still hitting this issue?  If so, could you please check if there are any error messages in the Help -> Developer Tools Console window?

Going to close due to inactivity. Feel free to reopen if you continue to see this.


Load video from assets catalog

Only videos located at the project root can be played? What about videos that are included in xcassets?

Hey @perdona
SwiftVideoBackground looks for the video in the app's bundle. This should include anything in the xcassets (although to be honest, I have never tried doing so). To check whether or not a video is part of the app's bundle, check your project's Build Phases section (as seen below).

Hope that helps! Please let me know if you have any other questions. Thanks!

I tried to do so, and it doesn't find the video inside xcassets.

BackgroundVideo: [ERROR] could not find video

Hmm thats interesting.. After doing some more research, it seems that to access non-image files in a .xcassets file, you have to use NSDataAsset to reference the file. The .xcassets are bundled together, and cannot be individually referenced using Bundle.main.
Video retrieval using NSDataAsset is not currently supported by SwiftVideoBackground. This is something we will look into supporting in the future. (Contributions and pull requests are also encouraged.)
In the meantime, is there a specific reason why you're choosing to place the video in xcassets rather than separately bundled with the app?

What would it take to add this feature?

Shouldn't we use xcassets used for this like that?
What is the best practise to store a video that plays in bg of a view?
Also would love to contribute... I'll try to research that when I have some time.
Thanks for the feedback!

@quanvo87 :
I actually wanted to see what you think would be best. Personally, I see three potential implementations:

Add some functionality to existing play() function to check for videos in both the bundle and the .xcassets. Play whichever video is found.

I believe this would be the "cleanest" method from a user's perspective (still just one function they can call), however I don't know if this is the "proper" way to do this. Also, how do we cover cases where video is in both the app's bundle AND .xcassets?

Overload play() function with two different sets of constructors. One for getting video from bundle, one from xcassets. (essentially two different play() functions)

Potentially confusing, we would have to document the differences for users, show them the options.

Completely change SwiftVideoBackground such that instead of passing in video filename, we have users pass in the reference to the video.

While this is probably the cleanest from a code perspective, this adds difficulty to users, having to figure out how to add the video themselves.

@perdona :
I'm not exactly sure of the best practices for storing videos. Personally, I just individually bundle videos and audio files with my app.
From my understanding, while .xcassets can store any data (audio, video, images, etc.), they are most beneficial for images/icons due to being able to store/group 1x,2x,3x versions for different (retina) screen sizes. This does not translate into audio/video.
But again, I'm not particularly familiar with the best practices of storing videos.

From looking around, I'm not seeing a clear reason to put videos in xcassets. In addition, it seems like when I put a video into xcassets, its mp4 type is lost, is it being stored as NSData? If that's the case you'd have to convert it to video then play. It seems like best practices is to put the video in the main bundle. Let us know what your research finds.

@perdona :
From what it seems like after reading @quanvo87 's input, I don't know if it is a good idea to support retrieval of videos from xcassets. We want this library to remain light/easy-to-use, and I think that adding this functionality will cause confusion without much gain. I will go ahead and close out this issue. If you disagree, please feel free to continue the discussion here, or create a new issue.
Thanks
-- Wilson

https://developer.apple.com/library/content/qa/qa1913/_index.html 🤔

Yeah it is definitely possible to store/retrieve other data files (incl. videos) from Asset Catalogs. The question is not whether we can, rather whether we should. What do you think?

Since these Apple docs are explaining how to do so, I think it's worth further investigation.
Also according to this repo,

Name of asset in any .xcassets catalogs. It's recommended to add your sound files to Asset Catalogs instead of as standalone files to your main bundle.

If this were true, it seems possible the same could also apply to videos.

Nice! I will try to collaborate anytime soon!

This person says you can't store videos in the asset catalogue and still use them, though doesn't explain why.
https://stackoverflow.com/questions/48767676/load-video-from-assets-xcassets?noredirect=1&lq=1

Closing for now - if there is interest, I can reopen again.


No local redis cache for prod machines

I tested the local dev case, works same as before.

So production will no longer reset the database on every deploy with this?

I'm merging this to test dev ASAP, time pressure.

👍


No way to use Custom Module Loader

It appears the module resolution mode is fixed on newer versions. asset-pipeline has been using this library for minification and ES6-ES5 transpiling for a while now but due to limited module resolution asset-pipeline parsed the goog.require output and injected the appropriate modules where needed. This seems to error now no matter what resolution mode is specified. a custom ModuleLoaderFactory may be a way to resolve this.

At this point in time, we don't intend to expand the module resolution algorithms or support generic custom resolution. I personally have yet to be able to see a good use case.
In most other cases, a pre-compilation build step translates the custom resolution into one the compiler understands. Translating the modules into absolute paths and using the BROWSER mode works especially well.
I am keeping my eye on various resolution proposals that are being targeted for Node or browsers.

Use case is asset-pipeline uses a moduler resolver filesystem to resolve assets that may exist in a jar (on the classpath) or on the actual filesystem.

FWIW in shadow-cljs I need to fully resolve all dependencies before calling the Closure Compiler, since they are important for CLJS compilation as well. It would be nice if I could tell Closure which variable it should assign for require("react") for example.
The NodeModuleResolver did not work for me at all and doesn't support several features I required.
Currently I'm forced to use the BrowserModuleResolver and replace every require("react") with require("/some/filename/i-picked.js") in the JS before passing it to Closure. Basically every require/import is replaced by an absolute path.
This works very reliably and side-steps many of the issues I had with NodeModuleResolver but it would be much nicer to just configure a custom ModuleLoader/Resolver.

@thheller What in particular were you missing with node module resolution?

@ChadKillingsworth the possibility to influence how things resolve basically. Similar to https://webpack.js.org/configuration/resolve/. For example having react resolve to a global React variable since the page already has react included from a CDN. There are also some libraries on npm which use node native packages but can still work in the browser using https://github.com/webpack/node-libs-browser.
NodeModuleResolver also does a bunch of work regarding .json parsing and figuring out which files to load that I have already done at the point I call the Closure Compiler. So it was much less painful going the BrowserModuleResolver path since replacing some strings was easy enough. Not ideal but ok.

Oh and https://github.com/google/closure-compiler/pull/2622
I'm actually compiling for the Browser not Node so I need support for "browser" aliases in package.json.

So I introduced a webpack module resolution which looks up modules from a map, or fails back to node module resolution if it's missing. It currently requires providing the input to the compiler via a JSON object on standard input though. That's the only way you can tell the compiler which module is which webpack id. That could be generalized to be a more generic lookup map though.

Is there a no module resolution mode like their used to be... id rather have the goog.require and goog.provide stuff go in without the module resolution so I can take care of it from the outside

On May 29, 2018, at 12:23 PM, Chad Killingsworth<EMAIL_ADDRESS>wrote:
So I introduced a webpack module resolution which looks up modules from a map, or fails back to node module resolution if it's missing. It currently requires providing the input to the compiler via a JSON object on standard input though. That's the only way you can tell the compiler which module is which webpack id. That could be generalized to be a more generic lookup map though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@ChadKillingsworth yeah I understand the purpose of the webpack resolver. However if I'm pre-processing and insert absolute paths that also works. Whether I insert a absolute path or a number doesn't matter much. Ideally I just wouldn't have to pre-process at all.


Updated crepr.py for Issue #51

User description
Added the report_missing method
The report_missing method is a Typer command that inspects the classes in a given Python file to identify and count those without a __repr__ method as required in https://github.com/cleder/crepr/issues/51

Input Handling:

The function accepts a list of file paths (files) as an argument, which corresponds to Python files that need to be analyzed.

2.Tracking Classes without __repr__:

For each class, it checks if the class has a __repr__ method by calling get_repr_source.
If the class doesn't have a __repr__ method, its name is added to the no_repr_classes list, and the class count is incremented.

Reporting:

After analyzing all the classes in a file, the function prints a summary showing how many classes in that file are missing a __repr__ method.
If any classes lack a __repr__, their names are printed.

Usage for report-missing
crepr report-missing <your-file-name>

PR Type
enhancement

Description

Introduced a new Typer command report_missing to the crepr application.
The command analyzes specified Python files to count and list classes that do not implement a __repr__ method.
Provides a summary output indicating the number of classes missing the __repr__ method or confirms all classes have it.

Changes walkthrough 📝
Relevant filesEnhancement

crepr.pyAdd `report_missing` command to check for missing `__repr__` methods

crepr/crepr.py
Added a new report_missing command to the application.  The command inspects classes in specified Python files to identify those without a __repr__ method.  Outputs a summary of classes missing the __repr__ method or confirms all classes have it.

+31/-0

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Summary by Sourcery
Add a new Typer command report_missing to the crepr.py script, which analyzes specified Python files to report classes missing a __repr__ method.
New Features:

Introduce the report_missing Typer command to identify and count classes in a Python file that lack a __repr__ method.

Summary by CodeRabbit

New Features

Introduced a new command function, report_missing, to analyze specified files for classes lacking a __repr__ method and report the findings, including error handling and user feedback.

Have a look at the static tests
crepr/crepr.py:358:1: CCR001 Cognitive complexity is too high (19 > 7)
crepr/crepr.py:365:89: E501 line too long (89 > 88 characters)
crepr/crepr.py:393:44: FCS100 too complex f-string
crepr/crepr.py:401:89: E501 line too long (95 > 88 characters)

Have a look at the static tests
crepr/crepr.py:358:1: CCR001 Cognitive complexity is too high (19 > 7)
crepr/crepr.py:365:89: E501 line too long (89 > 88 characters)
crepr/crepr.py:393:44: FCS100 too complex f-string
crepr/crepr.py:401:89: E501 line too long (95 > 88 characters)

@cleder How should I test the same without actually committing the changes? Currently working on the changes right now.


fix: Render dimensions when digits are present

JIRA Card: https://artsyproduct.atlassian.net/browse/GRO-710
In cases where a dimension field contains no digits (production example), we shouldn't be rendering blank dimensions.

Broken Example - Before (local)

Broken Example - After (local)

Artwork with Dimensions and Editions - After (local)
![image]()

Can we add a link to the JIRA ticket as well as a screenshot to the description field?

@dzucconi Added a test! Thanks for the callout


Added layers

Related Issues
Fixes issue #30
Checklist
Make sure to check off all the items before submitting. Mark with [x] if done.

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I am working on this issue under GSSOC

I think we are still getting the same error . May you please try to resolve this , if not ping me , we will solve it together .
https://github.com/dhruvpatidar359/nextdraw/assets/103873587/0ad61470-2f34-4001-a4d9-af20e3a3f3c6


#6428 Clear stale captive_action during Cache read retry - WIP (in test)

Reset captive_action.cancelled during open read retry to prevent assert - WIP (in test)
#6428

@zwoop Still need a +1 to merge this.

Cherry-picked to v9.0.x branch.


Does not create /public/storage/posts/date2017/image

Laravel Version: 5.5.*
Voyager Version: 1.0.5
PHP Version: 7.*
Database Driver & Version:

Description:
Files exists in storage/app/posts/date2017.
The folder is not created in public/storage/posts/
Doesn't work doing "php artisan storage:link"
filesystem.php
`
'disks' => [
    'local' => [
        'driver' => 'local',
        'root' => storage_path('app'),

    ],

    'public' => [
        'driver' => 'local',
        'root' => storage_path('app/public'),
        'url' => env('APP_URL').'/public/storage/',
        'visibility' => 'public',
    ],

`
Steps To Reproduce:
No clue.

Solved:
Change 'root' => storage_path('app') to 'root' => storage_path('app/public/posts')

I'm guessing you're in shared hosting, or have otherwise installed Laravel inside the public_html directory (such that /path/to/public_html/public/ exists).  If this is the case, then that's your problem, and I would strongly recommend changing how it's installed.  Keeping it that way exposes your .env file (at domain.com/.env, using your domain instead of domain.com of course)


Add Manjaro in OS checks invidious_update.sh

Include Manjaro Linux in all OS checks, since it is sufficiently similar to Arch Linux. As far as I know, the biggest difference is only in the versions of the packages and some user experience configuations. Possibly works for other Arch derivatives.

Looks great! Thanks for the contribution :+1:

Looks great! Thanks for the contribution :+1:


[Snyk] Security upgrade gatsby from 3.3.0 to 5.12.0

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):

starter/package.json
starter/yarn.lock

Note for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:

Issue
Score

Denial of Service (DoS) SNYK-JS-WS-7266574
  768

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
Max score is 1000. Note that the real score may have changed since the PR was raised.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Denial of Service (DoS)

👷 Deploy Preview for taupe-cassata-172709 processing.

Name
Link

🔨 Latest commit
ba1d021d8bc718824ed76e92a37be37bf12b9b11

🔍 Latest deploy log
https://app.netlify.com/sites/taupe-cassata-172709/deploys/66726392606c180008d1b915


Integration Test - Release - 2022/01/27 10:16:25

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@prmerger-dev-2 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Docs Build status updates of commit 2af9083:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch release-b9094eb4019747ecba9bf7a3c64b40e2 has been deleted or has been force pushed

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


modifying numpy in the paralel loop

Hi,
@stuartarchibald
in my paralell loop :

def x_2(compare_desc,  p_descs, ):
    result_np = np.full((10000,4),19.11)

    res_count= 0
    count = 0
    total = p_descs.shape[0]

    for x in prange(total):

        if float(...) < 16 :
                a_float = dist
                name_number = x
                an_int = x
                small_float = sim
                # new_np = np.asarray([types.float32(res_count), types.float32(a_float), types.float32(an_int), types.float32(small_float)])
                # result_np[0:] = [3,3,3,3]
                result_np[res_count, 0] = x
                result_np[res_count, 1] =  a_float
                result_np[res_count, 2]=  x
                result_np[res_count, 3]= small_float
                res_count = res_count +1
      return result_np , res_count

it is running in parallel and I am wondering the result_np array. is it inserted sequentially or threads inserts starting from a point ? if I get the slice from the beginning to res_count am I getting all inserted data ?

@stuartarchibald
using the x varibable solves the problem if the numpy array below the 10Million. I am creating 10M numpy array in the numba function so every time I need to sort returning numpy array to get top 20 .
it is very ineffective approach. how we can make an atomic variable to use for this purposes ?

it is very ineffective approach. how we can make an atomic variable to use for this purposes ?

I'd suggest opening a feature request for atomic operations.

Closing this issue as it seems to be resolved. If this is not the case please re-open with a comment about any item that appears to be unresolved. Many thanks.

@stuartarchibald
Hi
Is there any improvement about this parallel process with list append in it ?

@MyraBaba no changes have been made for this I'm afraid.

@stuartarchibald
I would  like to learn your opinion about above code  which is matrix calculation over all arrays and decide the result is greater than threshold.
Numba give good speedup.
How can I use GPU for above code ? Do you think it makes a speeding up the overall function?

@stuartarchibald
As an idea :
Is that possible each thread create and append its own container list  after parallell is finished they accumulate and return ?
Dumb idea but could be a shortcut ?


LibWeb+LibTextCodec: Add support for BOM handling and error mode

Fixes a crash running https://wpt.live/encoding/textdecoder-ignorebom.any.html
The factoring definitely feels a bit awkward here. Also considering whether from_utf8 etc should have any BOM handling.

not stale, would appreciated @trflynn89 to have a quick look since this is unicode related and also relates to another similar change made a lil bit ago. still considering whether it should be factored in an alternate way though.


Increment version for core-amqp release

Increment version for core releases

Can one of the admins verify this patch?

We won't be needing this PR as the release branch will be deleted after amqp release.


extend the py vs r tests to also test repeated cross-fitting

The released unit test will continue to fail until we publish a new release of the R package to CRAN which contains https://github.com/DoubleML/doubleml-for-r/pull/95, i.e., the fix for https://github.com/DoubleML/doubleml-for-r/pull/94.


ENABLE_DBT_PROJECT_EVALUATOR value is not correctly interpreted as bool

Describe the bug
ENABLE_DBT_PROJECT_EVALUATOR value is not correctly interpreted as bool
Steps to reproduce
Using the example from the readme gives the error.
The error also occurs when actually setting the env var on the CLI by
export ENABLE_DBT_PROJECT_EVALUATOR=false and also by export ENABLE_DBT_PROJECT_EVALUATOR=true
# dbt_project.yml

models:
  dbt_project_evaluator:
    +enabled: "{{ env_var('ENABLE_DBT_PROJECT_EVALUATOR', 'true') }}"

Running with dbt v1.3.0 and dbt-project-evaluator v0.2.1
Expected results
Expected that the variable is correctly read as a boolean value, both when actually set, and when the default value is being used.
Actual results
A validation error is raised
Screenshots and log output
  File "/Users/rory.donaldson/.pyenv/versions/3.9.7/lib/python3.9/site-packages/hologram/__init__.py", line 989, in validate
    raise ValidationError.create_from(error) from error
hologram.ValidationError: 'false' is not of type 'boolean'

Failed validating 'type' in schema['properties']['enabled']:
    {'default': True, 'type': 'boolean'}

On instance['enabled']:
    'false'

System information
The contents of your packages.yml file:
packages:
  - package: dbt-labs/dbt_utils
    version: 0.9.2
  - package: dbt-labs/codegen
    version: 0.8.1
  - package: dbt-labs/dbt_project_evaluator
    version: 0.2.1

Which database are you using dbt with?

[ ] postgres
[ ] redshift
[ ] bigquery
[x] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
Core:
  - installed: 1.3.0
  - latest:    1.3.1 - Update available!

  Your version of dbt-core is out of date!
  You can find instructions for upgrading here:
  https://docs.getdbt.com/docs/installation

Plugins:
  - bigquery:  1.2.0 - Not compatible!
  - snowflake: 1.3.0 - Up to date!```

Hi!
I don't think that this is an issue with the package itself but more about how Jinja is interpreted in dbt.
Could you try:
# dbt_project.yml

models:
  dbt_project_evaluator:
    +enabled: "{{ env_var('DBT_ENABLE_DBT_PROJECT_EVALUATOR', 'true') == 'true' | as_bool }}"

That works perfectly thank you! PR #257 raised now to update the README


Add Kix's name to the authors list

If one looks at crates.io or the git index it looks like I wrote this crate but that is wholeheartedly untrue, Kix wrote almost all the code in this crate IIRC. I just pulled it all out of rust-bitcoin.
 Leave Andrew's there in second place because he is the crate owner, and reviewed everything. Omit my name because I have only chopped and changed trivial things and am only likely to polish things going forwards.

I'm pretty sure Kix is watching this repo but for other's watching along, mention @Kixunil.


⚠ SolarOscp has degraded performance

In b18a60b, SolarOscp ($SOLAROSCP_URL) experienced degraded performance:

HTTP code: 200
Response time: 160 ms

Resolved: SolarOscp performance has improved in 06d47af.


Implement international payments upload using IBAN and BIC code

Please implement international payments upload using IBAN and BIC code. Add a integration with some IBAN validation library.
See #2 Issue for a Fio API specification for SEPA (EU) payments and international payments.

@kramapet can you please work with @jan-mikulka on a specification, so he can implement the code properly?

Feature has been merged in #14.


setup wasm-vips for next.js/react

First of all would like to thank for your job, it's awesome that people making possible projects like this one. I think it has bright future.
So I was working with node.js sharp library, wrapper around libvips. Found out that everything now can be done even without backend, found out about your project and started trying to work but stuck. I have no problems when using it on backend (I didn't try much because it's not what I wanted). But it produces different errors each time I'm trying to make it work with next.js
For example I'm constantly getting this error:

Link to my project: https://github.com/serafimsanvol/my-app/blob/main/src/app/page.tsx
It's just basic next starter project so I'm sure that there is something with library configuration but I don't know what are workarounds here, can you help/explain/tell me that it's bug and actually unexpected behaviour?
On different project with slightly different setup and set headers as required it shows different error:

Any help/suggestions appreciated, thanks

It looks like Next.js is encountering some issues when attempting to bundle wasm-vips' ES6 modules, related to the new URL('./', import.meta.url) syntax.
If you want to enable wasm-vips solely for server-side rendering (SSR), you can use this config:
next.config.js:
/** @type {import('next').NextConfig} */
const nextConfig = {
    webpack: (config) => {
        // Disable evaluating of `import.meta.*` syntax
        // https://webpack.js.org/configuration/module/#moduleparserjavascriptimportmeta
        config.module.parser.javascript.importMeta = false;

        // Disable parsing of `new URL()` syntax
        // https://webpack.js.org/configuration/module/#moduleparserjavascripturl
        config.module.parser.javascript.url = false;

        // Alternatively, to bundle the CommonJS module:
        // Ensure "require" has a higher priority when matching export conditions.
        // https://webpack.js.org/configuration/resolve/#resolveconditionnames
        //config.resolve.conditionNames = ['require'];

        return config;
    }
}

module.exports = nextConfig;

To use wasm-vips in client-side environments, it remains essential to opt-in to a cross-origin isolated state and serve vips.js, vips.wasm and vips.worker.js from the same directory. Assuming these files are in the public/ directory, you could do this:
next.config.js:
/** @type {import('next').NextConfig} */
const nextConfig = {
    async headers() {
        return [
            {
                source: '/:path*',
                headers: [
                    {
                        key: 'Cross-Origin-Embedder-Policy',
                        value: 'require-corp'
                    },
                    {
                        key: 'Cross-Origin-Opener-Policy',
                        value: 'same-origin'
                    }
                ]
            }
        ]
    },
    webpack: (config) => {
        // Ensure "require" has a higher priority when matching export conditions.
        // https://webpack.js.org/configuration/resolve/#resolveconditionnames
        config.resolve.conditionNames = ['require'];

        return config;
    }
}

module.exports = nextConfig;

src/app/page.tsx:
'use client';
import { useEffect } from 'react';
import Vips from 'wasm-vips';

export default function Home() {
  useEffect(() => {
    Vips({
      // Disable dynamic modules
      dynamicLibraries: [],
      // Workers needs to import the unbundled version of `vips.js`
      mainScriptUrlOrBlob: './vips.js',
      // wasm-vips is served from the public directory
      locateFile: (fileName, scriptDirectory) => fileName,
    }).then((vips) => {
      console.log('libvips version:', vips.version());
    });
  }, []);

  return (
Hello wasm-vips!
)
}

@kleisauke, thanks for your help! Now it's working for me

Great! I'll close, please feel free to re-open if questions remain.


[staging] links are missing in "Sample and Experiment Conditions Optional subtitle" section in right panel

Organism Name, Tissue Name, Cell Name and Cell Line or Strain Name fields are missing their links
Steps to Reproduce

Click on  button
Locate "Sample and Experiment Conditions Optional subtitle" section in right panel
Pay attention to Organism Name, Tissue Name, Cell Name and Cell Line or Strain Name fields
Compare to design

Actual Results
info in links are not included as links
Expected Results
info for these links should be marked as links
Design

Evidence

@Janeece to add in link examples that are taken from the metadata field. cc @jgadling

these fields use their respective ID's (not surfaced) to like to relevant external reference page in a new tab.
@jgadling can you confirm if these are accurate designations/metadata?

Organism Name link to NCBI Taxonomy entry. Based on "Taxonomy ID" metadata field. Example page: https://www.ncbi.nlm.nih.gov/Taxonomy/Browser/wwwtax.cgi?mode=Info&id=4896&lvl=3&lin=f&keep=1&srchmode=1&unlock

Tissue Name link to UBERON. Based on "Tissue ID" metadata field. Example page: https://www.ebi.ac.uk/ols4/ontologies/bto/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FBTO_0005765?lang=en

Cell Name link to Cell Ontology. Based on "Cell type ID" metadata field. Example Page: https://www.ebi.ac.uk/ols4/ontologies/cl/classes/http%253A%252F%252Fpurl.obolibrary.org%252Fobo%252FCL_0000540

Cell Line/Strain link to NCBI. Based on "Cell Line ID" metadata field. Example page: https://www.ncbi.nlm.nih.gov/Taxonomy/Browser/wwwtax.cgi?id=284812

Link formats:
Organism Name:
f"https://www.ncbi.nlm.nih.gov/Taxonomy/Browser/wwwtax.cgi?id={Dataset.organism_taxid}"

Tissue Name:
f"http://purl.obolibrary.org/obo/{Dataset.tissue_id.replace(":", "_")}"

Cell Name
f"http://purl.obolibrary.org/obo/{Dataset.cell_type_id.replace(":", "_")}"

Cell Line/Strain
f"https://www.ncbi.nlm.nih.gov/Taxonomy/Browser/wwwtax.cgi?id={Dataset.cell_strain_id}"

At @manasaV3's suggestion:
Cellular component
f"http://purl.obolibrary.org/obo/{Dataset.cell_component_id.replace(":", "_")}"

@lauramarcos i think this is fixed, could you help retest?

Working now as expected, closing this one, thank you!

Reopening as this is happening again, links are missing in Locate Sample and Experiment Conditions section

ticket was reopened but wasn't move out of the "completed" column from portal bugs and fell through the cracks!

on the frontend this is working as intended since if we are not given the respective ids we cannot create the links
@uermel are these supposed to have their ids all filled out on the backend?

No, it's not necessarily expected for all fields to be filled. This depends on the sample_type and on whether the strain has an associated linkable source. In this example, since the sample_type is cell there won't be information for the tissue field, and I don't think we have an associated link for the strain.

@uermel @lauramarcos closing this since not all of the organism fields have links. Please reopen if you think there is a link and it's not showing


[Request] Add response status in GraphQlTransportException

When using HttpGraphQlClient, a GraphQlTransportException is thrown in the event of a non-200 response code. To enhance client functionality, it would be beneficial to include response information (status and body) within the GraphQlTransportException. This would enable clients to take appropriate actions based on the response code received from the GraphQL service.
Something like
var statusCode = transportException.getResponse().getStatusCode();
if (statusCode == 4xx) {
     // Do something
}

HttpGraphQlClient is just a builder to create GraphQlClient with an HTTP transport. Once created, the client is not aware of the details of the underlying protocol (HTTP, WebSocket, RSocket) or network client library. You should be able to get the cause of the exception, which for the HttpGraphQlClient should be a WebClientResponseException.


Speed up the post for categorisation by limiting the select * from influx to the date period we have loaded

Merge at will, looks good :+1:


[TS] Update package versions

Updates for security fixes
Verified by building and running site
Microsoft Reviewers: Open in CodeFlow

@matthidinger let's wait until this gets committed from @paulcampbell before checking in the template branch into master if that's ok -- should fix a bunch of security alerts/flags i was seeing against that branch


backport AVM 1.0 consensus support

Summary
This PR adds the protocol parameters support for AVM 1.0 consensus protocol ( https://github.com/algorandfoundation/specs/tree/bc36005dbd776e6d1eaf0c560619bb183215645c ), as well as updates the data structures needed to decode the new block data structure.
Test Plan
No tests included in this PR.

Codecov Report

Merging #698 (2b3cc9d) into hotfix/2.6.3 (d944718) will decrease coverage by 7.41%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           hotfix/2.6.3     #698      +/-   ##
================================================
- Coverage         54.97%   47.55%   -7.42%
================================================
  Files                29       25       -4
  Lines              5441     3863    -1578
================================================
- Hits               2991     1837    -1154
+ Misses             2045     1745     -300
+ Partials            405      281     -124

Impacted Files
Coverage Δ

types/types.go
0.00% <ø> (ø)

idb/postgres/postgres.go
43.09% <0.00%> (-9.94%)
:arrow_down:

idb/postgres/internal/encoding/decode.go
58.82% <0.00%> (-8.48%)
:arrow_down:

accounting/rewind.go
31.70% <0.00%> (-4.39%)
:arrow_down:

api/converter_utils.go
86.15% <0.00%> (-3.26%)
:arrow_down:

idb/migration/migration.go
96.10% <0.00%> (-0.05%)
:arrow_down:

api/server.go
0.00% <0.00%> (ø)

...ernal/ledger_for_evaluator/ledger_for_evaluator.go

idb/postgres/internal/writer/writer.go

cmd/block-generator/generator/make_transactions.go

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d944718...2b3cc9d. Read the comment docs.


Large file test issues in nc_test4/Makefile.am

In nc_test4/Makefile.am we have:
Add these if large file tests are turned on.
if LARGE_FILE_TESTS
check_PROGRAMS += tst_large tst_large2
endif

Then, later in the file:
if LARGE_FILE_TESTS
check_PROGRAMS += tst_large
TESTS += tst_large
endif # LARGE_FILE_TESTS

So tst_large2 is being built but not run as a test. I will take a look.

Never mind. That was an old build. The latest build of my branch (currently up as a PR) passes make -j distcheck for all combinations on my matrix.

I turned on tst_large2 and it works fine. I have added this fix to my current open PR.


Adds speed factor to render command.

Seemed to me that the speed factor options is useful not only for terminalizer play but also for terminalizer render.
This PR adds this option to the latter command.

Hey @faressoft ! First of all thank you so much for this amazing tool!
I've tried the changes in this PR and it does work. Could please take a look at this PR? This feature will be great for slow typers like me!


Problems in using "Vector Integer Arithmetic Instructions" to calculate fixed-point calculations

In calculation, I have to see fixed-point as integer to calculate because the lack of fixed-point instructions. For most situation they are the same but they have different behavior facing overflow.
For integer it only saves the lower bits and fixed-point has saturation.
Therefore, in some fixed-point functions I have to extend the elements to deal with overflow. Which I could use LMUL=8 to read in one loop, now I can only use LMUL=4 to have protect bits and I also have to clip it down.
My question is that is it possible to make integer instructions have saturation feature. Like there is a bit to control whether it has saturation feature or not. This looks like more flexible.
By the way, do you have some other ways to deal with the overflow in fixed-point function other than extend elements to set protect bits?

I'm confused by this question. Currently, the V-extension provides a very small set of fixed-point instructions:
https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#vector-fixed-point-arithmetic-instructions
Some of these perform saturation.
Can you please provide more details on the algorithm that you are trying to implement that is not well addressed by this set of functions?

I think this situation mostly happened in "redsum" together with "mul". Even though I used widened instruction, there is still a chance of overflow. And because it is a integer instruction, I can not deal with it when overflow happened. So I use "wredsum" together with "wmul" and clip the result which required extra resources and more cycles.
I wonder if there will be a fixed-point version of "redsum".

Are you trying to implement a gemmlop-style quad-widening GEMM? If so, I'd use quad-widening FMAs
https://github.com/riscv/riscv-v-spec/blob/master/quad-mul.adoc
and then clip the output matrix register tile before writing it back to memory.
Unfortunately, the quad-widening FMAs won't be part of the 1.0 release.
Personally I'm in favor of removing all the fixed-point instructions from 1.0, but that's another topic..

Perhaps that is one way to optimize it. Still, it requires clip.
I thought vector is born to battle with SIMD. Ideally, it do behave better than SIMD. But most SIMD are used in DSP or NN which calculate with fixed-point inputs. Without fixed-point instructions perhaps vector may not be better than SIMD.
Actually, I am agree to you about removing all the fixed-point instructions from 1.0. To be honest, it is really makes me confuse sometime to choose whether the integer instructions or fixed-point instructions. But anyway, I think the integer instructions should have a saturation version.

It is my experience that instructions that saturate rather than wrap, while punctually useful, are insufficient in the general case because they don't compose as well. For instance, with vsadd.vv you can perform perform (a + b) with saturation only at the last step, however you cannot do even just (a + b + c) with saturation only at the last step, because intermediate saturations may change the final result, even after that result is subject to saturation. It can be proven that intermediates would require more than n bits in order to keep enough information so the final result is correct, even after saturation.
The same goes for instance for averaging add, which works for 2 inputs (and could be tolerated for specific situations such as 4 inputs if you're willing to tolerate the loss of accuracy from the intermediate roundings), but completely breaks down for something as simple as averaging 3 inputs with equal weight.
As a result, in the general case there is no substitute to performing your fixed-points computations with an element width wider than your outputs, and clip the computation outcome to your output width, with the clipping instruction performing most if not all the saturation in the process.

I understand what you said. What I thought is that every addition is saturated. In this case, even overflow happens in a+b, it still can keep most information. Because the overflow will happen anyway, why bother to use protection bits. The saved bits can extend the elements that calculated one loop.
Perhaps I got it wrong, I think "redsum" with saturation means every addition is saturated, rather than the last step. Just tell me if I got it wrong. Maybe it can not designed like that.
In conclusion, if every addition are saturated, there is no need to have protection bits. If the overflow happened, that means these data has no use. So simply set it to max value is enough, I think. If I need the overflowed data, I would not clip it down and directly write it back.

I admit I have less experience with redsum and other horizontal operations, but aren't they typically performed once at the end of processing, and thus out of the hot path? And so any additional complexity at that point in your code would be amortized anyway?

After learned for a long time, I finally got it clearly. What I need is simply a dot instruction. My purpose is to write a loop to fulfill mult accumulate which returns a scalar. This issue is raised because I think it can be optimized with saturation.  Actually, saturation may not be that necessarily for me, If I can use dot instructions.


Fix getConfigOverrides in MinionQuickstart

Current quickstart fails because super.getConfigOverrides(); is an Immutable Map. Anyway the overrides should be provided in a separate map.

Codecov Report

Merging #8858 (0f167a7) into master (e8f9d88) will decrease coverage by 54.45%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #8858       +/-   ##
=============================================
- Coverage     68.56%   14.11%   -54.46%
+ Complexity     4640      168     -4472
=============================================
  Files          1741     1695       -46
  Lines         91475    89523     -1952
  Branches      13674    13468      -206
=============================================
- Hits          62724    12639    -50085
- Misses        24363    75952    +51589
+ Partials       4388      932     -3456

Flag
Coverage Δ

integration1
?

unittests1
?

unittests2
14.11% <ø> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8f9d88...0f167a7. Read the comment docs.


nixos/nix-daemon: Organize buildMachine options with a submodule

This PR picks up #47636. It changes the nix.buildMachine option from an attribute set to a submodule, with documentations and examples per option.
A couple of thoughts:

The sshKey option is a secret path, which there is no good solution for so far. See #78640
There's no assertion to check for presence of both system and systems at the same time, because I couldn't figure out how to do assertions per module nicely :) I guess it's an artifact anyways that there are even two options for this, I'd rather deprecate systems, and type system as str or listOf str, expecting the former to cover basically all cases.
As per this suggestion, I put the features variables an enum, and added an "extra" option that allows freeform features. The idea is to have a somewhat curated list of commonly used names where typos can't happen, and move special ones to their own option.

Ttested this locally, works as expected :)

@msteen thanks for the review :) fixed all your points.
I also changed system and systems to default to builtins.currentSystem if neither are set, that seems to be a reasonable default.

@Valodim thanks for picking this up for me! And @Infinisil, thanks for letting me know.

Can you add a 20.09 change log breaking change notice?

I updated this to incorporate all feedback (and rebased on master).
I think we actually ended up compatible with (sane usage of) the previous definitions, at least the config implementation looks identical modulo handling of defaults to me, and the example from the previous documentation produces identical results.
There is a slight potential for errors in configs that used sloppy types before, e.g. a string value for maxJobs will lead to an error like this:

error: The option value 'nix.buildMachines.[definition 1-entry 1].maxJobs' in ... is not of type 'signed integer'.
I added an item to the release notes about that.


Implementation of Dijkstra's Algorithm

Have you read the Contributing Guidelines on Pull Requests?
YES
Description
Implementation of Dijkstra's Algorithm
Issue no -#47
Checklist

[x]  I've read the contribution guidelines.

[x]  I've checked the issue list before deciding what to submit.

[x]  I've edited the README.md and link to my code.

Related Issues or Pull Requests
(Write your answer here.)

kindly review this PR @Kajol-Kumari @SKAUL05 @siddharth25pandey @iamrajiv @HarshCasper

@Kajol-Kumari @plazzy99
kindly review and merge this PR


How to set a header?

Using the client middleware, how do I set a header. I'm talking about when you do a request in this way:
return {
  types: [LOGOUT, LOGOUT_SUCCESS, LOGOUT_FAIL],
  promise: (client) => client.get('/logout')
};

Thanks.

You'd have to modify ApiClient.js in order to accept headers but I did it in the following way:
return {
  types: [LOGOUT, LOGOUT_SUCCESS, LOGOUT_FAIL],
  promise: (client) => client.get('/logout', { headers: { [header-name]: [header-value], ... })
};

ApiClient.js
class ApiClient {
  constructor(req) {
    methods.forEach((method) => {
      this[method] = (path, { params, data, attach, field, headers, local, external = false } = {}) => new Promise((resolve, reject) => {
        const request = superagent[method](external ? path : formatUrl(path, local));
        const cookie = req.get("cookie");

        if (headers) {
          request.set(headers);
        }
...


freeze CSV version

Seems to cause errors with the 0.9 release of CSV

Codecov Report

Merging #236 (f326812) into master (3cff2c9) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   70.99%   70.92%   -0.07%
==========================================
  Files          14       13       -1
  Lines        1741     1737       -4
==========================================
- Hits         1236     1232       -4
  Misses        505      505

Impacted Files
Coverage Δ

src/utils.jl
55.52% <0.00%> (-0.25%)
:arrow_down:

src/oracles.jl
86.59% <0.00%> (-0.14%)
:arrow_down:

src/FrankWolfe.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cff2c9...f326812. Read the comment docs.


[ICS02] Unclear role of ClientTypePath and respectively store_client_type method

Problem Statement

Looking into the ICS24, there should be a provable store for ClientType in the ClientTypePath and provable stores are required to provide methods needed for getting, setting, and deleting a value.

According to the ICS02 ClientTypePath is utilized during client creation to ensure that the client type is absent in the respective path before proceeding.

Our API only offer the store_client_type method, which stores a client type without any usage or providing a means to retrieve or remove it. Although we have yet to encounter a need for this interface among consumers like Namada, Basecoin, and Mock, Having it necessitate to add a get_client_type interface to enable us checking the existence of a client type in the respective path (as specified in the specs).

Meanwhile, with the counter mechanism in place, which never fails and increments the client ID, we can be confident that every client creation process results in a new path. This means we don't need to check whether the client already exists in the ClientTypePath and the whole interaction with the ClientTypePath becomes unnecessary.

I checked the IBC-go implementation in this regard and couldn’t find any ClientTypePath there. (I have reached out to them for clarification)

Proposal
Considering points 4 & 5, it seems logical to eliminate the store_client_type interface and move away from ClientTypePath even though it is somewhat inconsistent with the specs!
Remarks

When a MsgCreateClient is processed through the decode_client_state operation, the host implicitly checks if the client type is supported or allowed. It would have been ideal if we could separate the decoding process from the list of supported clients, but, it looks like it’s not possible to decouple them with our curren design.

Ran into this issue upon working on #178

Upon investigation in contact with IBC-go team, the concept of client type will soon be removed! https://github.com/cosmos/ibc/pull/956


Failure building in Windows Container due to missing file

Hi!
ue4-docker version:         0.0.72 (latest available version is 0.0.72)
Operating system:           Windows 10 Pro Version 1903 (OS Build 18362.1139)
Docker daemon version:      19.03.13
NVIDIA Docker supported:    No
Maximum image size:         200GB
Available disk space:       168.46 GiB
Total system memory:        31.95 GiB physical, 41.26 GiB virtual
Number of processors:       6 physical, 12 logical

Hi I'm attempting to run the command
ue4-docker build custom:MYTAG -repo=MYREPO -branch=release
However I get a failure building with the message. I believe this is the relevant snippet of my log:
Saving local manifest to C:\UnrealEngine\Engine\Saved\BuildGraph\Build Tools Win64\Manifest.xml
ERROR: Attempt to add file to temp storage manifest that does not exist (C:\UnrealEngine\cpp.hint)
(see C:\UnrealEngine\Engine\Programs\AutomationTool\Saved\Logs\Log.txt for full exception trace)
AutomationTool exiting with ExitCode=1 (Error_Unknown)
BUILD FAILED
The command 'cmd /S /C .\Engine\Build\BatchFiles\RunUAT.bat BuildGraph -target="Make Installed Build Win64" -script=Engine/Build/InstalledEngineBuild.xml -set:HostPlatformOnly=true -set:WithDDC=%BUILD_DDC% &&        del /s /q C:\UnrealEngine\LocalBuilds\InstalledDDC 2>NUL &&     python C:\exclude-components.py C:\UnrealEngine\LocalBuilds\Engine\Windows %EXCLUDE_DEBUG% %EXCLUDE_TEMPLATES% && echo. && echo.RUN directive complete. Docker will now commit the filesystem layer to disk. && echo.Note that for large filesystem layers this can take quite some time. && echo.Performing filesystem layer commit... && echo.' returned a non-zero code: 1
[ue4-docker build] Error: failed to build image "adamrehn/ue4-minimal:martov-1903"
As you can see it appears to be attempting to add a file that does not appear to exist. I am not sure if this is because of my windows setup.
Do you have any idea why this is happening?
Also I am not sure how to get the full log short of piping into a file but I attached the ending section that wasn't cropped out by the terminal. Please let me know if you can, where to retroactively find the log.
ue4-dockerlog.txt

Small update: I ran a diagnostic on my system. It does suffer for the 8gb filesystem issue.
That said I reran the command and got the same error.

New update. I tried the same command on windows server 2019 and got the same error
Here is the info for the machine
ue4-docker version:         0.0.72 (latest available version is 0.0.72)
Operating system:           Windows Server 2019 Datacenter Version 1809 (OS Build 17763.1518)
Docker daemon version:      19.03.12
NVIDIA Docker supported:    No
Maximum image size:         200GB
Available disk space:       702.91 GiB
Total system memory:        15.82 GiB physical, 18.69 GiB virtual
Number of processors:       4 physical, 8 logical
Is there something I am doing wrong??
Thanks.
here is the error from the new log.
Creating library C:\UnrealEngine\Engine\Intermediate\Build\Win64\UnrealFrontend\Development\MetalShaderFormat\UnrealFrontend-MetalShaderFormat.suppressed.lib and object C:\UnrealEngine\Engine\Intermediate\Build\Win64\UnrealFrontend\Development\MetalShaderFormat\UnrealFrontend-MetalShaderFormat.suppressed.exp
UnrealFrontend.target
Saving local manifest to C:\UnrealEngine\Engine\Saved\BuildGraph\Build Tools Win64\Manifest.xml
ERROR: Attempt to add file to temp storage manifest that does not exist (C:\UnrealEngine\cpp.hint)
(see C:\UnrealEngine\Engine\Programs\AutomationTool\Saved\Logs\Log.txt for full exception trace)
AutomationTool exiting with ExitCode=1 (Error_Unknown)
BUILD FAILED
The command 'cmd /S /C .\Engine\Build\BatchFiles\RunUAT.bat BuildGraph -target="Make Installed Build Win64" -script=Engine/Build/InstalledEngineBuild.xml -set:HostPlatformOnly=true -set:WithDDC=%BUILD_DDC% &&        del /s /q C:\UnrealEngine\LocalBuilds\InstalledDDC 2>NUL &&     python C:\exclude-components.py C:\UnrealEngine\LocalBuilds\Engine\Windows %EXCLUDE_DEBUG% %EXCLUDE_TEMPLATES% && echo. && echo.RUN directive complete. Docker will now commit the filesystem layer to disk. && echo.Note that for large filesystem layers this can take quite some time. && echo.Performing filesystem layer commit... && echo.' returned a non-zero code: 1

You haven't mentioned what version of UE4 your tree is branched from.
I don't see any failures in the build log. I'm not sure what is supposed to generate cpp.hint, but it's possible that there was a failure before the start of the log that's supposed to generate cpp.hint, but somehow didn't stop the build when it failed.
That said, try increasing the storage-opt to 400GB or 600GB and see if that fixes it (per #112). I'd also suggest adding --exclude debug as at the end of this step, you're likely to hit #44 during filesystem commit of this stage.
Interestingly, 4.26 removes the reference to cpp.hint from this build step: https://github.com/EpicGames/UnrealEngine/commit/006feb2ef072d41fa429c585031c50955c3c2ba5, so possibly this is a known-flakey thing.

Thanks. Its just a vanilla fork of  UE release branch ( which corresponds to 4.25.4). No code changes.
I did already attempt the following things to the same result:
1.) I increased the storage-opt to 600gb
2.) I added --exclude debug and tried running the command again.
Unfortunately I get the same error. I'm going to try building again and saving full log to see if there is an error generating this file. Afterwards I'm going to try building a version of 4.26 instead. Thanks for response.

I'm running into the same issue, also with 4.26 - any resolution / fix to this (my max image size is 800GB)?

4.26 is also complaining about missing "C:\UnrealEngine\cpp.hint"? That's very strange, since 4.26 removed that file from the buildsystem.
Can you provide the full build log please, so we can see how it got into this situation in the first place?

I was wrong, apologies - ignore my last post, with 4.26 I did not get the missing file issue, but it aborted with copy error. I then tried patching the dockerfile according to https://github.com/adamrehn/ue4-docker/issues/99#issuecomment-723292029, but still getting it.
I'm on Windows Server 2019 Standard Version 1809, with Docker server 19.03.12. The 8GB diagnostic fails on this system, so could be related to this?
I'm letting it run again and will post the output.

It's probably best to follow up on #99 if you're having the COPY error, so that information about that issue stays in one place, and we can keep this ticket for the 'cpp.hint' issue. For example, the workaround might need to be updated for 4.26.

FWIW, the error with the missing cpp.hint file was a bug in the 4.25.4 release, which was fixed on Epic's Perforce release branch, but not on GitHub (the 4.25.4-release tag doesn't include the fix).
This is the commit that addressed the bug in the initial 4.25.4 release: https://github.com/EpicGames/UnrealEngine/commit/84e4ea3241c294c04fdf7d8fb63f99a3109c8edd
This is a bug with UE's build scripts themselves, rather than with the environment. Presumably, applying that patch to Engine/Build/Commit.gitdeps.xml would fix ue4-docker's ability to build 4.25.4. Similarly, if you're using a custom engine repo, you can backport that patch to 4.25.4 to get around the problem.

Great to know. So I'd propose to close this ticket as "Upstream bug in 4.25.4 GitHub release: Backport the fix into your own UE4 tree, use 4.25.3, or wait for 4.26 to be released".

Upstream bug in 4.25.4 GitHub release: Backport the fix into your own UE4 tree, use 4.25.3, or wait for 4.26 to be released

I'm used to .0 releases of new Unreal Engine versions having bugs in them that subsequently get fixed, but this is definitely the first time I've seen the final point release of a version introduce a bug that is then left unfixed until the next .0 release. Since I always advise people to use the newest point release of any given Engine version, I've added a patch in commit 99ca1b0 that injects the fix from https://github.com/EpicGames/UnrealEngine/commit/84e4ea3241c294c04fdf7d8fb63f99a3109c8edd when it detects version 4.25.4 and the fix isn't already present (so it won't interfere with people's own forks that already include the backport.)
I'll tag a new release of ue4-docker that includes the new change once I've tested that it fixes the build issues under both Windows and Linux.

My tests builds were successful for 4.25.4 under both Windows and Linux. The fix is now live in ue4-docker version 0.0.73.


Frontend port to React

PR checklist:

complete port of frontend to React.js
all graph data are made available through individual API endpoints
change graphing library to Chart.js

Merges and PR will be performed locally instead.


(Compatibility) Arcane Workbench and Ritual Altar recipes are picked up by Create devices

From what I can tell, all Ritual Altar recipes are picked up as "automated shapeless crafting" for basin plus mechanical mixer, without requiring nay of the props or mana. For the Arcane Workbench, only shapeless and "packing" recipes (shaped recipe with 2x2 or 3x3 of a single input item) are picked up for the mixer and mechanical press, respectively.
Other shaped Arcane Workbench recipes are correctly ignored by Create. The only recipe Create also picks up for its Mechanical Crafter are single-item shapeless "unpacking" recipes for the Arcane Workbench, but that seems to be JEI-only. The mechanical crafter doesn't actually accept the input item for those.
I assume that this is mostly Create's fault (and I reported it over there as well: Creators-of-Create/Create/issues/3591), but I'm leaving this issue here mainly for reference and in case you might be able to provide any insights for a potential fix.

While this is definitely a bug, I'm pretty sure that it's on Create's end.  Primal Magick uses a number of custom recipe types, and it looks like Create is ingesting them when it shouldn't be.  Thank you for reporting this bug in both places.  I'm not aware of anything I can do on my end to fix it, but I'm happy to work with the authors of Create if there are compatibility steps I can take that they can share, or I can share information with them on PM's custom recipe types so they can be appropriately blacklisted.  Leaving this issue open for reference until a solution can be found.

This issue should be fixed in a future update.  On my end, the changes required will be in v4.0.2 of Primal Magick, the next planned release.  A change has also been made on Create's end, but I can't speak to when that will make it live.  Thank you for the report!


0.2-release doesn't compile with more recent nightly

There's an issue with max() being implemented in both the standard library and in (a presumably older version of) petgraph that's causing an error when building the 0.2 version of cargonauts now. This is only an issue because this is the branch installed by default with the CLI tool so the getting started experience was a little rocky.
Changing the autogenerated Cargo.toml file from branch = "0.2-release" to branch = "master" fixes it (so this should hopefully close whenever the next release is pinned in the CLI).

Updated 0.2-release (shouldn't have been any breaking changes). Thanks for reporting this!


This Repository is not licensed

Hey there,
this project is one of the only and working ssl-psk extensions for python.
I have created (an currently unreleased) kodi (xbmc) addon using this library and I would love to distribute a standalone working version of it including pre-compiled binaries of this library, instead of leaving out this library completely, which is what I need to do in its current state: http://choosealicense.com/no-license/
I would be absolutely lovely if you could add any license, that would allow distributing an unmodified (pre-compiled) version or at least any license, that clarifies this situation for any possible users.
Thanks for your time.
Greetings,
Drakulix

Fixed in 128a5979c7ce17da82373a161d657ba038e60cd7

big thanks.


MRG+1: The frequencies parameter of csd_morlet is not optional

The csd_morlet and csd_array_morlet functions mistakingly have None as a default value for the frequencies parameter. This parameter is not optional, leaving it at None will raise an error.

@wmvanvliet I assume this is good to go from your end?

thx @wmvanvliet


Example usage as middleware - highlight From() vs New()

I started using this but found I was getting nothing when I trying to pull context from different handlers. Then I realized I was using .New() instead of .From() and didn't read the examples close enough.
Here is an example of my basic flaw: https://play.golang.org/p/NyeM3HU_jf5
You might want to update the README to point out the difference or maybe add a link to https://pkg.go.dev/github.com/peterbourgon/ctxdata for those of us that need more clear instructions.

Hopefully that solves it. Let me know if you want something more specific.


new migrations, more help in README

Actually, looks like the provision.sh script is going to be retired in https://github.com/EuroPython/epcon/pull/1087, too - I'll be closing this PR.


[0.6.0] "Unexpected }" error when using comments in interpolation strings

Hi!
Since v0.6.0, it seems having comments inside interpolation strings causes issues.
Repro test case:
const parse = require('../parse');

test('it should not fail with comments inside interpolation', () => {
	expect(() => {
		parse('let Component = styled.div`color: ${textColor /* very good color */}`;')
	}).not.toThrow();
});

expect(received).not.toThrow()

Error name:    "CssSyntaxError"
Error message: "<css input>:1:41: Unexpected }"

This fails on v0.6.0, but doesn't fail on v0.5.0.
Running a quick git bisect, I find 6c9cdaab23bccd980610c852131edffe6db22fae as the culprit commit.

Just in case, I filed a bug with postcss too: https://github.com/postcss/postcss/issues/1907

Thank you for reporting! Fixed in 0.6.1.


Request - Update Package.json dependencies !

Hi.
I have been using this generator for a while and i realized that there are few dependencies that they are too old ( some of them, for more than 2 years like the mongo-prebuild ) .
It would be great that you could update it.
I did it in my own package.json and the project works perfect.
thank you !

{
  "name": "Contoso",
  "version": "0.0.0",
  "main": "src",
  "private": true,
  "scripts": {
    "start": "node .",
    "test": "jest",
    "test:unit": "npm test \"src/**/!(index).test.js\"",
    "test:integration": "npm test \"src/**/index.test.js\"",
    "coverage": "npm test -- --coverage",
    "postcoverage": "opn coverage/lcov-report/index.html",
    "dev": "nodemon -i \"*.test.js\" .",
    "prod": "cross-env NODE_ENV=production nodemon -i \"*.test.js\" -r dotenv-safe/config .",
    "lint": "eslint src",
    "docs": "apidoc -i src -o docs && apidoc-markdown -p docs -o DOCS.md",
    "postdocs": "opn docs/index.html"
  },
  "jest": {
    "testEnvironment": "node",
    "setupTestFrameworkScriptFile": "<rootDir>/test/setup.js"
  },
  "devDependencies": {
    "apidoc": "^0.17.6",
    "apidoc-markdown": "^0.2.0",
    "babel-eslint": "^7.0.0",
    "babel-jest": "^20.0.3",
    "cross-env": "^5.0.5",
    "dotenv-safe": "^4.0.3",
    "eslint": "^4.4.1",
    "eslint-config-standard": "^10.2.1",
    "eslint-plugin-import": "^2.7.0",
    "eslint-plugin-node": "^5.1.1",
    "eslint-plugin-promise": "^3.0.0",
    "eslint-plugin-standard": "^3.0.1",
    "jest-cli": "^20.0.4",
    "mockgoose": "^6.0.8",
    "nock": "^9.0.2",
    "nodemon": "^1.10.2",
    "opn-cli": "^3.1.0",
    "sinon": "^3.2.0",
    "supertest": "^3.0.0",
    "supertest-as-promised": "^4.0.0"
  },
  "dependencies": {
    "babel-core": "^6.26.0",
    "babel-plugin-transform-runtime": "^6.23.0",
    "babel-preset-es2015": "^6.24.1",
    "babel-preset-stage-1": "^6.24.1",
    "babel-runtime": "^6.26.0",
    "bcrypt": "^1.0.2",
    "bluebird": "^3.4.0",
    "body-parser": "^1.15.1",
    "bodymen": "^1.0.1",
    "compression": "^1.6.2",
    "cors": "^2.7.1",
    "express": "^4.13.4",
    "express-force-ssl": "^0.3.2",
    "jsonwebtoken": "^7.1.9",
    "lodash": "^4.13.1",
    "mongoose": "^4.11.6",
    "mongoose-create-unique": "^0.4.4",
    "mongoose-keywords": "^0.3.2",
    "morgan": "^1.7.0",
    "passport": "^0.4.0",
    "passport-http": "^0.3.0",
    "passport-http-bearer": "^1.0.1",
    "passport-jwt": "^3.0.0",
    "querymen": "^2.0.0",
    "rand-token": "^0.3.0",
    "request": "^2.74.0",
    "request-promise": "^4.1.1"
  }
}

Hi, @maustand
Could you send a PR?

Ok. I will do it.

done


Typing: mixin props definition not available in setup functions

Version
3.0.0
Reproduction link
https://codesandbox.io/s/confident-glade-9vqbb?file=/src/components/HelloWorld.vue
Steps to reproduce

Have a mixin with some props definitions
Use this mixin in a TypeScript component with a setup function
The props defined in the mixin are available on this in options API methods and on props object of the setup function. However in the second case, props type doesn’t include the mixin props resulting in the following error:

Property 'foo' does not exist on type 'Readonly<{} & { bar?: string; }>'.

What is expected?
Setup function props should be properly typed with both component own props and mixins props.
What is actually happening?
Props definitions from mixins are not available in setup functions.

Isn't this intentional? You aren't supposed to use mixins with setup.

@KaelWD That’s what I thought at first, but since the value is actually available it looks more like a bad typing to me. I don't think I’ve seen another way than mixins to share props definition between components.

@LeBenLeBen the types should reflect it, but you can share props definitions by simply spreading them.