Image-viewer isn't working for vertical images

I'm using ImageLoaderCallback and calling imageviewer.showImage(Uri uri).
It's working for all URLs except some. Like this one :
Code :
        bigImageView.setImageLoaderCallback(new ImageLoader.Callback() {
            @Override
            public void onCacheHit(int imageType, File image) {
            }

            @Override
            public void onCacheMiss(int imageType, File image) {

            }

            @Override
            public void onStart() {
                Helper.log("start : " + getClass().getName() + url_base);
            }

            @Override
            public void onProgress(int progress) {
                if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
                    progress_load_bing.setProgress(progress, true);
                } else {
                    progress_load_bing.setProgress(progress);
                }
            }

            @Override
            public void onFinish() {
                bigImageView.setVisibility(View.VISIBLE);
                loadingView.setVisibility(View.INVISIBLE);
                set_wall.show();
                show_info.show();

                try {
                    sheet = new InfoSheet(
                            title.split("©")[0],
                            title.split("©")[1],
                            view_link,
                            view_link);

                    if (!WallpaperSetter.this.isFinishing())
                        sheet.show(getSupportFragmentManager(), "info_shit");
                } catch (Exception ignored) {
                }
            }

            @Override
            public void onSuccess(File image) {
                imageFile = image;
            }

            @Override
            public void onFail(Exception error) {
                Toast.makeText(WallpaperSetter.this, "Error Loading Image", Toast.LENGTH_SHORT).show();
                error.printStackTrace();
            }
        });
        String bet = BingActivity.getNextImage(url_base, BingActivity.Res.getByOrder(index));
        Helper.log(bet);
        bigImageView.showImage(Uri.parse(bet));

PS: I couldn't get the printing statements executed from onStart

@Piasy Basically I saw that horizontal images are displayed and not vertical ones. How I should do further debugging?
XML Layout for reference: Parent & Child
activity_wallpaper_setter.txt
content_wall.txt

@ExploiTR In my device, the demo could load the vertical image successfully.

@Piasy Strange, but the same image which is successfully downloaded using Ion, doesn't work with BIM. I'll retest things then will close the issue. \o/
        Ion.with(this)
                .load(BingActivity.getNextImage(url_base, BingActivity.Res.getByOrder(index)))
                .progressBar(progress_load_bing)
                .write(new File(Environment.getExternalStoragePublicDirectory(DIRECTORY_DOWNLOADS) +"/"+ url_base + ".jpg"))
                .setCallback((e, result) -> {
                    bigImageView.setVisibility(View.VISIBLE);
                    loadingView.setVisibility(View.INVISIBLE);
                    set_wall.show();
                    show_info.show();

                    try {
                        sheet = new InfoSheet(
                                title.split("©")[0],
                                title.split("©")[1],
                                view_link,
                                view_link);

                        if (!WallpaperSetter.this.isFinishing())
                            sheet.show(getSupportFragmentManager(), "info_shit");
                    } catch (Exception ignored) {
                    }

                    if(result!=null)
                        bigImageView.showImage(Uri.fromFile(result));
                    else
                        e.printStackTrace();
                });

Well, @Piasy I found out that, BigImageViewer isn't loading vertical images after I set ImageLoader Callback → this block of code :
        bigImageView.setImageLoaderCallback(new ImageLoader.Callback() {
            @Override
            public void onCacheHit(int imageType, File image) {
            }

            @Override
            public void onCacheMiss(int imageType, File image) {

            }

            @Override
            public void onStart() {
                Helper.log("start : " + getClass().getName() + url_base);
            }

            @Override
            public void onProgress(int progress) {
                if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
                    progress_load_bing.setProgress(progress, true);
                } else {
                    progress_load_bing.setProgress(progress);
                }
            }

            @Override
            public void onFinish() {
                bigImageView.setVisibility(View.VISIBLE);
                loadingView.setVisibility(View.INVISIBLE);
                set_wall.show();
                show_info.show();

                try {
                    sheet = new InfoSheet(
                            title.split("©")[0],
                            title.split("©")[1],
                            view_link,
                            view_link);

                    if (!WallpaperSetter.this.isFinishing())
                        sheet.show(getSupportFragmentManager(), "info_shit");
                } catch (Exception ignored) {
                }
            }

            @Override
            public void onSuccess(File image) {
                imageFile = image;
            }

            @Override
            public void onFail(Exception error) {
                Toast.makeText(WallpaperSetter.this, "Error Loading Image", Toast.LENGTH_SHORT).show();
                error.printStackTrace();
            }
        });

Just putting this code works fine without ImageLoaderCallback :

But, this callback interface problem only happens with these images.

I think maybe it's because you change BIV's visibility, in my test I didn't do that.
If you need do such thing, please debug yourself, and PR is welcome if you trace down some bug in BIV.

@Piasy
• If it's case of the visibility then it shouldn't work for other images. But it does.
• For the same reason, if BIV fails to show the image, that's fine, but it should at least call onStart

Hmm, maybe you need more debug on it.


CNAME entries in nebula DNS service?

I would like to have additional host names for my hosts attached to the nebula network. I have enabled the DNS service in nebula, which is working as expected, but I would like to be able to add additional entries to the DNS table, so I can have alias names for my hosts. Is there any possibility to already achieve this, which I have missed? Or do I need to install unbound instead (including double maintenance and possibility of inconsistence)?

https://github.com/slackhq/nebula/pull/617
This pull request seems to provide the feature I am asking for.

I think a project such as unbound is perfectly complements Nebula in this regard. You can setup a stub-zone and point it to the DNS interface of Nebula. And you can use local-zone with local-data for custom CNAME entries.

Since I see the NeedsDecision tag was added to this I thought I would add my 2 cents.
I see why people would want custom CNAME support but personally I think the DNS interface in Nebula should be designed to be used with an external DNS service. Not necessarily to serve as a standalone DNS server. That way you have a clear design mandate as to what the DNS interface should (and should not) support.
So for example one could add zone transfer support to Nebula to improve the integration with external DNS services. But custom CNAME support is something an external DNS would handle.  Also things such as request throttling, hardening, etc. are then clearly out of scope and something the external DNS server should handle. Also other record types such as service records (SRV), reverse records (PTR), IPv6 records (AAAA), etc. would then all be out of scope and handled by the external DNS.


Test-DbaDbCompression - Fixe case-senstive error and formatting

Type of Change

[x] Bug fix (non-breaking change, fixes #5404 )
[ ] New feature (non-breaking change, adds functionality)
[ ] Breaking change (effects multiple commands or functionality)
[ ] Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
[ ] Adding code coverage to existing functionality
[ ] Pester test is included
[ ] If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
[ ] Nunit test is included
[ ] Documentation
[ ] Build system

Purpose
Address lowercase references to Schema to match table definition on case-sensitive collations
Also found drop statement was not validating the correct table name to actually drop it. If statement had setdbacompression when it should have been TestDbaCompression.

Trying to get a case-sensitive collation server built to verify...

tests pass, going to merge, and create a new issue around CS, ty!


[Demo] StepIndicator

Closes #323
Changes
Demonstrates how the StepIndicator can be used to indicate progress through a process.
How to test this PR

Log in with an account associated with at least one Institution
Visit http://localhost:8899/filing/
Click Upload file (or Start a Filing first if needed)
Click Next/Previous to move through the process.
The current step is marked Complete once you have clicked to the next step.
Progress is reset on page reload

Screenshots

Split out changes we want to keep into PR https://github.com/cfpb/sbl-frontend/pull/341


.card class conflicts with application's .card class - perhaps bs-card would be better.

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
rename .card to something else, perhaps .bs-card
Motivation and context
conflicts with existing application. Problem started with 5.2.0.

We won't be doing this—it's been that way for years and hasn't started since v5.2.0 as no component class names have changed in that release :).

@mdo - fyi your javascript since 5.2 is injecting var (--bs-card-height) into the element(s) using the the card class. This was very difficult to figure out, I'm surprised that others haven't had the problem. I had to change my app.

@DaveO-Home I'm intrigued by your feedback because there's no JavaScript at all for the cards.
This is the main change done between v5.1 and v5.2 for the CSS of our cards. --bs-card-height is a CSS variable defined in the .card scope (see https://github.com/twbs/bootstrap/blob/main/scss/_card.scss). So I'm not sure why you had to change anything (for the cards) while migrating from v5.1 to v5.2.

@julien-deramond I'm not using the bootstrap card scope. I had a .card class for my own use. It's only used as  a parent to my cards, .card1, .card2.... Somehow var (--bs-card-height) is getting injected. It really trashed my app. I can't see how it gets injected unless it's javascript or the bundler, rollup.

In Bootstrap v5.1.3 (generated dist/css/bootstrap.css):
.card {
  position: relative;
  display: flex;
  flex-direction: column;
  min-width: 0;
  word-wrap: break-word;
  background-color: #fff;
  background-clip: border-box;
  border: 1px solid rgba(0, 0, 0, 0.125);
  border-radius: 0.25rem;
}

// There are other rules (e.g. '.card > hr' and so on of course)

In Bootstrap v5.2.0 (generated dist/css/bootstrap.css):
.card {
  --bs-card-spacer-y: 1rem;
  --bs-card-spacer-x: 1rem;
  --bs-card-title-spacer-y: 0.5rem;
  --bs-card-border-width: 1px;
  --bs-card-border-color: var(--bs-border-color-translucent);
  --bs-card-border-radius: 0.375rem;
  --bs-card-box-shadow: ;
  --bs-card-inner-border-radius: calc(0.375rem - 1px);
  --bs-card-cap-padding-y: 0.5rem;
  --bs-card-cap-padding-x: 1rem;
  --bs-card-cap-bg: rgba(0, 0, 0, 0.03);
  --bs-card-cap-color: ;
  --bs-card-height: ;
  --bs-card-color: ;
  --bs-card-bg: #fff;
  --bs-card-img-overlay-padding: 1rem;
  --bs-card-group-margin: 0.75rem;
  position: relative;
  display: flex;
  flex-direction: column;
  min-width: 0;
  height: var(--bs-card-height);
  word-wrap: break-word;
  background-color: var(--bs-card-bg);
  background-clip: border-box;
  border: var(--bs-card-border-width) solid var(--bs-card-border-color);
  border-radius: var(--bs-card-border-radius);
}

// There are other rules (e.g. '.card > hr' and so on of course)

The only difference in Bootstrap v5.2 for .card is that we introduced CSS variables/custom properties. So as you can see there's no JavaScript involved at all.
Maybe you could try to create a CodePen or a StackBlitz to show us the issue with a minimal reproducible example and launch a discussion in our dedicated space so that someone could maybe help you.
But TBH I don't see technically how it could mess with your app considering the fact that you already used the .card class before with Bootstrap v5.1.3 in your app.

I just tested rollup with .card and that's not he problem.

In Bootstrap v5.1.3 (generated dist/css/bootstrap.css):
.card {
  position: relative;
  display: flex;
  flex-direction: column;
  min-width: 0;
  word-wrap: break-word;
  background-color: #fff;
  background-clip: border-box;
  border: 1px solid rgba(0, 0, 0, 0.125);
  border-radius: 0.25rem;
}

// There are other rules (e.g. '.card > hr' and so on of course)

In Bootstrap v5.2.0 (generated dist/css/bootstrap.css):
.card {
  --bs-card-spacer-y: 1rem;
  --bs-card-spacer-x: 1rem;
  --bs-card-title-spacer-y: 0.5rem;
  --bs-card-border-width: 1px;
  --bs-card-border-color: var(--bs-border-color-translucent);
  --bs-card-border-radius: 0.375rem;
  --bs-card-box-shadow: ;
  --bs-card-inner-border-radius: calc(0.375rem - 1px);
  --bs-card-cap-padding-y: 0.5rem;
  --bs-card-cap-padding-x: 1rem;
  --bs-card-cap-bg: rgba(0, 0, 0, 0.03);
  --bs-card-cap-color: ;
  --bs-card-height: ;
  --bs-card-color: ;
  --bs-card-bg: #fff;
  --bs-card-img-overlay-padding: 1rem;
  --bs-card-group-margin: 0.75rem;
  position: relative;
  display: flex;
  flex-direction: column;
  min-width: 0;
  height: var(--bs-card-height);
  word-wrap: break-word;
  background-color: var(--bs-card-bg);
  background-clip: border-box;
  border: var(--bs-card-border-width) solid var(--bs-card-border-color);
  border-radius: var(--bs-card-border-radius);
}

// There are other rules (e.g. '.card > hr' and so on of course)

The only difference in Bootstrap v5.2 for .card is that we introduced CSS variables/custom properties. So as you can see there's no JavaScript involved at all.
Maybe you could try to create a CodePen or a StackBlitz to show us the issue with a minimal reproducible example and launch a discussion in our dedicated space so that someone could maybe help you.
But TBH I don't see technically how it could mess with your app considering the fact that you already used the .card class before with Bootstrap v5.1.3 in your app.

@julien-deramond @mdo I tested this as a stand-alone app and everything worked as expected. However, my app is a component in a larger React  app. I'm pointing my finger at React.  v18.2.0.

@julien-deramond @mdo Strike my last comment. The problem is with my setup. I had my css loaded before bootstrap so your .card was overriding mine. Sorry about that....


Added loadedPlugins attribute on fp instance

I was looking for a clean way to check that the monthSelect plugin has been loaded inside the confirmDate plugin (to enable the confirm button if the monthSelect is loaded) and there wasn't any. I added an attribute called loadedPlugins on the fp instance in which each plugin pushes its own name.
Same problem was referenced in #1217

Looks fantastic, great idea @viorelsfetea


Add accessibility attributes

Adding accessibility attributes to notyfContainer to ensure notifications are announced to screenreader users.

Hey @jasonday, thanks a ton for this contribution!
I only see one problem and it's that, with this approach, the toasts will be announced on entering and on leaving because the role=alert will listen to all the changes within its children.
In any case, I'm preparing v3.0.0 and I took these ideas to make Notyf properly support a11y. You can see the 3.0.0 if you're curious. I took ideas from the Angular Material a11y implementation, which basically registers a visually hidden element in the  with aria-live set (and/or role=alert), and this element will work as the announcer to the screen reader. Works pretty well.
I'll keep this PR updated when v3.0.0 gets released.

v3.0.0 has been released with great A11y support. Thanks for all the help!


Create servlet and parse funcs

Created the servlet that fetches location data for California public libraries.

Properly working and displaying California public libraries, ready for merge!


Adding ROCm FUSION ops to the AMP whitelist/graylist.

By default the ROCm FUSION ops are not considered AMP eligible, and hence they are computed in FP32 even with AMP enabled. Adding the ROCm FUSION ops to the AMP whitelist / graylist, will enable those ops to the computed in FP16 where appropriate.
/cc @ekuznetsov139

Can one of the admins verify this patch?


[ES 2] Replace XML database for meta data with SQLite

There is a known issue where ES will appear to freeze during scraping (very) large collections.  This appears to happen because ES is re-parsing and then re-saving the gamelist.xml file.
My proposed fix is to replace the gamelist.xml format with a gamelist.db format (using SQLite) which will allow reading/writing of individual games without having to load/save the entire thing.  This would also reduce memory use (game details can stay on disk until they are accessed).

I do have a similar problem. I run ES on a retropie image and ES keeps freezing randomly, whether it is during scraping or just out of the blue while browsing thru the lists or trying to edit the name of a game. this once also happened when I booted up the pi and did nothing for a minute or so after ES started up. never happens when I'm in game and when this happens I can still access the PI via SFTP and browse thru the directories without and troubles, it's just ES that won't let me do shit. I tried allocating the memory differently with no impact on this issue. I have around 1000 roms stored, split onto 8 systems (mainly classic consoles) and I do believe it has to to with the amount of games and the reading of their gamelist.xml files. I will try to give the PI more power this weekend (gets around 600mA at the moment, will double it) and see whenther this helps as I read somewhere that not enough power might be the cause. if this changes anything, I'll post it here.
overall I appreciate you guys are looking to get rid of the gamelist.xml files as the bigger they get... well you already now. Keep up the good work guys!

I had this problem but just installed ES on my Windows PC, scraped everything there, then moved it onto my Pi. I now use a different scraper on my PC as it's a lot quicker.

An update on this - the gamelistdb branch has the code for this.  I think it mostly works.  If anyone is feeling adventurous and would like to try it (and knows how to build ES), please go ahead, I would appreciate some more testing before I merge it into unstable.  You can go to "Scraper -> Import XML" in the menus to import existing gamelist.xmls (I might add an automatic check for this on first startup later).  I have not tested it very thoroughly.
Known issues:

Times need to be converted between the format used in the XML and the format used by SQLite.
Image paths are not currently relative.

Greato! I'll try it this weekend and do some tests on my gamelists.

Can you let us know the database structure you're using? I generate the gamelist XML files myself using my own (3000 lines of code) scraper so I'll need to modify it to generate the SQLite files instead.

I'll do a detailed writeup on the database schema when later. There are some comments in GamelistDB.cpp, but I don't think they're totally accurate right now.  It's probably a hell of a lot easier to output XML than update the database directly, so I'm thinking about just keeping an automatic "import gamelist.xml if last modification time is newer than gamelist.db" check at startup.  There's also an "export XML" function that isn't hooked up to a menu.

I have been testing the gamelistdb build and its working perfectly fine under lubuntu 14.10, The database is definitely worth pursuing and integrating with unstable, I also find it easier to edit the database than the xml file,

I was expecting it to be to be honest. I do extensive database work so switching to DB queries rather than generating a big string of XML isn't going to be too hard for me. Push it out Aloshi!

I've just tested this again (after an import) and it doesn't start any faster than it did when it was using XML files. I've got the ROMs on a network drive and on startup I can see the network activity go through the roof, but in reality it shouldn't be loading anything from the network as I'm using "--gamelist-only". I have a feeling this may be to do with this other issue https://github.com/Aloshi/EmulationStation/issues/401

Is there any progress on this issue? I'm using EmulationStation (RetroPie) and notice that I can't have more then 10.000 roms before it takes more then 1 minute to boot the arcade. Adding more roms after that significantly increases the loading time. Is there a way to switch from xml to db yet?

@NeoID No progress, development has halted for the foreseeable future.

NeoID: You can switch to the new style by using the experimental DB repo BUT there's one major issue. It still seems to scan all the games to see if they exist which actually appears to be the thing that causes the delay, not the use of XML so it doesn't improve performance at all.
As mentioned in my earlier post, https://github.com/Aloshi/EmulationStation/issues/401 appears to be the real issue here, not the storage format of the games.

XML vs. SQLite is not the issue. The problem causing slow loads is because of how relative paths are handled. Both the game loader and the theme loader rely on the following functions.
std::string resolveRelativePath(const std::string& _path, const std::string& _relativeTo, const bool _allowHome, const bool _searchParents);
std::string createRelativePath (const std::string& _path, const std::string& _relativeTo, const bool _allowHome, const bool _searchParents);
std::string removeCommonPath   (const std::string& _path, const std::string& _common, bool& _contains, const bool _searchParents);

These methods use isDirectory() to determine whether or not a file should attempt to be loaded from the parent directory when referenced by . instead of the one it is in. This is relevant for themes which load parent relative content.
This is not relevant for loading games and so every single file of every game list hits the file system multiple times to see if a path is a directory. If you're loading from the network or slow media this can take several minutes while every single game is probed.
I modified my local copy to add _searchParents per above so that the theme system does (true) and the game loader does not (false).
// removeCommonPath
std::string common = _searchParents ? (isDirectory(_common) ? getGenericPath(_common) : getParent(_common)) : getGenericPath(_common);

// resolveRelativePath
std::string relativeTo = _searchParents ? (isDirectory(_relativeTo) ? getGenericPath(_relativeTo) : getParent(_relativeTo)) : getGenericPath(_relativeTo);

You also need to set the ParseGamelistOnly setting to avoid hitting the file system on load.
With these changes, I brought an 8 minute load time down to about 3 seconds.
I also add this to loadConfig() to get progress on each system loading.
std::string progressText = "Loading ";
progressText.append(name);
progressText.append(" ...");
window->renderLoadingScreen(progressText);


Backup-DbaDatabase not working with SQL Server 2000

I added the usual backup/restore suspects. If anyone doesn't want to be assigned, please DM me and I'll keep you off in the future 🌮

Confirmed working on 2005 and above

Are we still supporting SQL 2000? Even Microsoft doesn't.
Anyways, since I don't have 2000 instance around, I would put a couple suggestions here, as I can't test it properly.

Remove slash before the file name. It seem to not matter at all for SQL that I have around - both BACKUP ... TO DISK '\file.bak' and BACKUP ... TO DISK 'file.bak' have the same result. Is it the same for SQL2000? If so, we'll need to change the following line to insert $slash only when $FinalBackupPath[0] -ne '' https://github.com/sqlcollaborative/dbatools/blob/e5e583ad14d8b716601f3faa820c1eccc4aa3a84/functions/Backup-DbaDatabase.ps1#L381
Replace the following line:
https://github.com/sqlcollaborative/dbatools/blob/e5e583ad14d8b716601f3faa820c1eccc4aa3a84/functions/Backup-DbaDatabase.ps1#L359
With:

if ($BackupDirectory) { $FinalBackupPath += $BackupDirectory }
else { $FinalBackupPath += $Server.BackupDirectory }


[Feature Request]: Iterative query results for post search filtering

Describe the problem
For bigger datasets the current "where" filtering is very slow. For my vector database it takes almost 1 minute to apply the filter while searching without filtering is almost instantaneous.
Describe the proposed solution
For some bigger datasets it could be a better option to do the search without any filters applied and then do the filtering after. For this to work consistently, we need the ability to apply filters to the results one by one as they come in. We can then abort the search once the required number of results have been found. This would make it possible to do quite advanced filtering of the searches without having to add that functionality into the core chromadb code.
Alternatives considered
An alternative to iteratively looping through the search results could be to have a built in function to do the same. This function would accept filters but instead of applying them to the entire dataset ahead of search it applies it to the results while searching. It needs a maximum tries limit to avoid never ending loops.
Importance
would make my life easier
Additional Information
You can achieve similar things with the query method that returns results in batches , but you aren't able to ensure that you get the required number of results each time. So you will resolve to returning more results than needed most  of the time, which is not very efficient.

@kkollsga the way we want to solve this is by adding indexes to metadata. Post-filtering will cause very strange behavior because you will have to massively "over-retrieve" and then possibly end up with 0 results. Very unintuitive.

also facing the slow "where" filtering problem. I got around 50k data in one collection.

Any updates on this limitation or "best practices" to get around the slow metadata filtering issue? Facing similar problems with datasets on the order of the ones described above.


Please add following Modes

Hi,
I'm working on a project where my fan have some modes which I want to manage with my Smart Home Actions.
These are my current traits for my devices :
"type": "action.devices.types.FAN",
"traits": [ "action.devices.traits.OnOff","action.devices.traits.FanSpeed","action.devices.traits.Modes"]
I'd like to have more modes for my device, like :
swing(en) / swing(ja)
timer(en) / timer (ja)
sleep(en) / sleep (ja)
Is it possible to add them in one of these traits ?
Thanks in advance !

We can add those additional modes

We've updated the docs. The changes should be live in a day or two.

It looks like they're rolling out now.


update: add incertum to affiliations.json

Signed-off-by: Melissa Kilby<EMAIL_ADDRESS>
What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind feature

/kind incubating

/kind officialsupport

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area governance

/area proposals

/area utils

What this PR does / why we need it:
add incertum (Melissa Kilby) to affiliations.json
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

LGTM label has been added.  Git tree hash: bf0a91998688cf679ec8393e4385f65b2e8daf23

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incertum
Once this PR has been reviewed and has the lgtm label, please ask for approval from leogr by writing /assign @leogr in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: incertum
Once this PR has been reviewed and has the lgtm label, please ask for approval from leogr by writing /assign @leogr in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: incertum, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: ded2b409358fb7deaf4dbe1c6df38ecc94ec01ed


[Bug]: Preview deployment of closed pull request still active

Description
Hey.
This closed PR from 2 days ago: https://github.com/ari-party/mtc-artillery/pull/49 is still active.

link to deployment
Minimal Reproduction (if possible, example repository)
I don't know how this exactly happened, just reporting that it did.
Preview deployments were enabled and never turned off, maybe other configuration related changes?
Exception or Error
No response
Version
v4.0.0-beta.304

going into each docker image and stopping it kinda sucks, no idea how this issue wasnt resolved or marked as high priority, as this might lead to leaked data if old versions of the application are still hosted


[Documentation]: Write directly to storage - Using blob storage - Incorrect JS examples

The JavaScript guidance given in the Using Blob storage section is incorrect and has a number of issues.
In the Installing Blob storage packages section, the reader is asked to install the botbuilder-azure-blobs package, however the text and further examples on this page all refer to implementing storage using the botbuilder-azure package.
As the BlobStorage class is deprecated in the botbuilder-azure package, and the BlobsStorage class is suggested in the deprecation message which is in the botbuilder-azure-blobs package, this page requires updating to use the new approach.

Hi @garrytrinder,
Thank you for the report. I'll take a look and get the ball rolling.

@garrytrinder,
I've confirmed the issues with the document and identified the correct steps for the botbuilder-azure-blobs package. I've also opened an issue on the bot-docs repo with the correct steps and will see that those get updated soon.
Thanks again for reporting this.

Fixes merged and should be visible in the docs later today.


Proposal: Disallow await in loops

Digging more and more in ESLint rules, i found some good ones which enforces good style and more readable code. This issue is for no-await-in-loop rule - not fixable.
Suggested configuration.
{
  "no-await-in-loop": "error"
}

I believe it is good practice to not do that and ban such things, since each loop iteration is delayed until the entire asynchronous operation completes.

👎  there are good reasons to use an await in a for-loop. For example, let's assume you want to make a number of rate-limited HTTP requests. A for-loop using await makes for a very clean way to do this.

Maybe. I believe we should run tests, to see ecosystem impact and if it is not so big everyone can add disable comment.

Duplicate: https://github.com/feross/standard/issues/737 Please use search before creating new issues.


Error: can't start nvm "bash: /usr/share/nvm/nvm.sh: line 2291: syntax error near unexpected token '("

Operating system and version:
LSB Version:	n/a
Distributor ID:	ManjaroLinux
Description:	Manjaro Linux
Release:	18.0.4
Codename:	Illyria
Nope, I can't use nvm yet, so no nvm debug nor nvm ls yet. But here's what I get when I run nvm.

How did you install nvm? (e.g. install script in readme, Homebrew):
I was following this instruction here. And at first everything was fine, I can use nvm normally, and managed to install node and npm.

However it turns out when I close my terminal, I can't use npm, node, nor nvm. It turns out I had to keep running the second step if I want to use those CLIs. As it already said that

You can also add the above line in your environment file such as .bashrc so you won’t have to do it every time.

What steps did you perform?
So I edited my .bashrc file and add alias nvm="source /usr/share/nvm/nvm.sh", after that I run source .bashrc, but then this lines shows up.

What happened?

bash: /usr/share/nvm/nvm.sh: line 2291: syntax error near unexpected token `('
bash: /usr/share/nvm/nvm.sh: line 2291: `nvm() {'

What did you expect to happen?
Well, working as it should be(?). Sorry if I seems to be clumsy, as this is my first linux version that I just have installed two days ago.

Is there anything in any of your profile files (.bashrc, .bash_profile, .zshrc, etc) that modifies the PATH?

I only edited my .bashrc like above,
What I see in .bash_profile is [[ -f ~/.bashrc ]] && . ~/.bashrc
I have no .zhrc file

You definitely don’t want to add that as an alias; please remove it.
You don’t want to install nvm as root, and as far as I’m aware, nvm should work fine on arch - however, there is an AUR package that arch users tend to use.

Also, i wouldn’t trust that tutorial, because nvm install -g npm is a nonsensical command.]; nvm has no -g`.

Ah yes, I forgot that part didn't work. So I read the manual for nvm and used nvm install (something) which I forgot. So, okay, don't trust the tutorial. What's the next step?
Should I uninstall this first? Then install it through the tutorial in README.md?

I’m not sure what would be different for manjaro; i guess I’d say, uninstall it completely, and then follow the steps in the readme here :-)

Ok, will do. I will open another issue if things gone wrong (and if I can't solve it myself).
Thank you for the support @ljharb! :D


micheh/psr7-cache Abandoned

micheh/psr7-cache is showing as abandoned by composer and shows as read only on GitHub. Ideally a suitable replacement should be found.

You'll find updated packages at mikespub/middlewares-cache and mikespub/micheh-psr7-cache
And yes, although it wasn't clear from the documentation or tests, this works fine with ETag as well as Last-Modified headers...
I added some ETag tests in https://github.com/mikespub-org/middlewares-cache/commit/204020037fd33459c88c8ec262cfe6734e68bfc9

Updated with PR #6

released in v3.0.0


Log client IP address in api-session and edge-session creations

During the api and edge session creation processes, the IP address of the client should be logged for forensic and other use cases.  This would be the IP seen at the Network Controller.  This can enable security improvements for monitoring, and blocking, like geo blocking, distance calculation alarms (subsequent logins from IP addresses determined to be too far apart, for example, US East coast, then Spain 20 minutes later).

Thinking about how this would be implemented, we would need to add the IP address to the api-session/session entities so we can output them as part of the create events. Does storing IP addresses have GDPR (or other regulatory) implications?

As long as we take reasonable precautions, there are no regulatory issues, this information falls into the category of required for network operations.

@mikegorman-nf Is it sufficient to have this as part of the api session events stream? Do you also want it added to regular session events and/or regular logs?


I tried "Go to definition" and you won't believe what happened next

In vscode repo
Open telemetryUtils.ts
Line 270, return configurationService.onDidUpdateConfiguration...
Cursor on onDidUpdateConfiguration
Press F12
It goes to the definition of the Event interface instead, in vs/base/common/event

This has been fixed in TypeScript 2.2 nightly. Not sure we can work around it on our side, so closing as fixed upstream.


0.4.0 not compatible with ruby 1.9.3

Hi,
FYI the version 0.4.0 (since merge of PR #6) of the gem is not compatible with ruby 1.9.3. I get:
`require': /home/travis/.rvm/gems/ruby-1.9.3-p551/gems/simplecov-console-0.4.0/lib/simplecov-console.rb:8: unknown type of %string (SyntaxError)
  ATTRIBUTES = %i(table_options)
                  ^

Please update the gemfile accordingly.
Thanks for your help! :)
Joseph

Fixed by #8

Pushed v0.4.1 with the fix


You can pick up a Ripley while in a Ripley

Description
While piloting a Ripley APLU that has a hydraulic clamp attached you can pick up another Ripley APLU.
Reproduction
Click on another Ripley APLU to pick it up.
Screenshots

feature


Cesium.Resource set headers

Sir,
code:
var resource = new Cesium.Resource({
url: 'http://<IP_ADDRESS>:8080/xx',
headers: {
'blade-auth':"aaaaa"
}
});
var terrainProvider = new Cesium.CesiumTerrainProvider({
url : resource
});
viewer.terrainProvider = terrainProvider;
util.flyToPoint(viewer,[107.3682261,32.1608059],-18,50000,3);
server receive header , Access-Control-Request-Headers is 'blade-auth' , but  value  'aaaa' isn't  sended ?
https://github.com/yanwei7210/yanwei7210/blob/master/question.png?raw=true
Thank you
yanwei

Running that code in Sandcastle and checking the network tab shows that the header value is sent:


site is down

The site has been down since June 12th.
https://twitter.com/testdrivenio/status/1271417801480327169

@mjhea0 Thanks for the report. Will have a look tomorrow.

Should be fixed by #141. I'm currently waiting for Travic CI to report back the test status.
The error on Heroku is this:
2020-06-17T21:08:22.217392+00:00 app[web.1]: Traceback (most recent call last):
2020-06-17T21:08:22.217399+00:00 app[web.1]:   File "/app/.heroku/python/lib/python3.7/site-packages/gunicorn/arbiter.py", line 583, in spawn_worker
2020-06-17T21:08:22.217400+00:00 app[web.1]:     worker.init_process()
2020-06-17T21:08:22.217400+00:00 app[web.1]:   File "/app/.heroku/python/lib/python3.7/site-packages/gunicorn/workers/ggevent.py", line 160, in init_process
2020-06-17T21:08:22.217401+00:00 app[web.1]:     self.patch()
2020-06-17T21:08:22.217401+00:00 app[web.1]:   File "/app/.heroku/python/lib/python3.7/site-packages/gunicorn/workers/ggevent.py", line 53, in patch
2020-06-17T21:08:22.217401+00:00 app[web.1]:     monkey.patch_all()
2020-06-17T21:08:22.217401+00:00 app[web.1]:   File "/app/.heroku/python/lib/python3.7/site-packages/gevent/monkey.py", line 1202, in patch_all
2020-06-17T21:08:22.217402+00:00 app[web.1]:     _notify_patch(events.GeventWillPatchAllEvent(modules_to_patch, kwargs), _warnings)
2020-06-17T21:08:22.217403+00:00 app[web.1]:   File "/app/.heroku/python/lib/python3.7/site-packages/gevent/monkey.py", line 184, in _notify_patch
2020-06-17T21:08:22.217403+00:00 app[web.1]:     notify_and_call_entry_points(event)
2020-06-17T21:08:22.217404+00:00 app[web.1]:   File "/app/.heroku/python/lib/python3.7/site-packages/gevent/events.py", line 104, in notify_and_call_entry_points
2020-06-17T21:08:22.217405+00:00 app[web.1]:     subscriber = plugin.load()
2020-06-17T21:08:22.217405+00:00 app[web.1]:   File "/app/.heroku/python/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2323, in load
2020-06-17T21:08:22.217405+00:00 app[web.1]:     self.require(*args, **kwargs)
2020-06-17T21:08:22.217405+00:00 app[web.1]:   File "/app/.heroku/python/lib/python3.7/site-packages/pkg_resources/__init__.py", line 2346, in require
2020-06-17T21:08:22.217406+00:00 app[web.1]:     items = working_set.resolve(reqs, env, installer, extras=self.extras)
2020-06-17T21:08:22.217406+00:00 app[web.1]:   File "/app/.heroku/python/lib/python3.7/site-packages/pkg_resources/__init__.py", line 783, in resolve
2020-06-17T21:08:22.217407+00:00 app[web.1]:     raise VersionConflict(dist, req).with_context(dependent_req)
2020-06-17T21:08:22.217408+00:00 app[web.1]: pkg_resources.VersionConflict: (greenlet 0.4.15 (/app/.heroku/python/lib/python3.7/site-packages), Requirement.parse('greenlet>=0.4.16; platform_python_implementation == "CPython"'))
2020-06-17T21:08:22.217408+00:00 app[web.1]: [2020-06-17 21:08:22 +0000] [13] [INFO] Worker exiting (pid: 13)```

OK, we're back up. Thanks all.
Not at all sure why we're using gevent but... 🤔

Apologies if this was one of my merges @carltongibson @MarkusH @mjhea0
I tested it with the following docker and it all seemed to work. Im not so familiar with heroku or gevent but what was the version conflict with? Or what is the root issue here?  :
The docker environment I used to test has greenlet 0.4.15 and is working.
web:
   build: .
   environment:
     - REDISTOGO_URL=redis://redis:6379/0
     - SECRET_KEY=p_o3vp1rg5)t^lxm9-43%0)s-=1qpeq%o7gfq+e4#*!t+_ev82
     - DEBUG=True
     - ALLOWED_HOSTS=<IP_ADDRESS>,<IP_ADDRESS>
     - DATABASE_URL=postgres://postgres:postgres@db/djangosnippets
     - DJANGO_SETTINGS_MODULE=djangosnippets.settings.production
     - SEARCHBOX_SSL_URL=http://elasticsearch:9200/

   command: gunicorn -b <IP_ADDRESS>:8000 -k gevent -w 4 djangosnippets.wsgi:application

Things I'm thinking to resolve in future:

Check website after merges to master / setup some monitoring. Does the main django site use monitoring?
Would be good to know the production setup and perhaps replicate it with vagrant to capture these issues before merging?

I think it was caused by the update to gevent in #132 but didn't fully investigate. I only noticed, that there was a new greenlet version available and figured I'll bump that to fix it :man_shrugging: :smile:


DenseNet transfer learning, custom dataset quantization: [ERROR] Unexpected exception InvalidArgumentError() happened during tuning

I've trained a multiclass classifier with TF using transfer learning and have been trying to use Neural Compressor in dev container enviroment. Firstly, I had to modify build_imagenet_data.py for grayscale image to obtain custom tfrecord file. Then I modifed densenet121.yaml for tfrecord location, height, width, scale and mean_value.
I come across InvalidArgumentError() during tuning, which I am not able to overcome.
root@docker-desktop:/workspaces/Neural_Compressor/neural-compressor/examples/tensorflow/image_recognition/tensorflow_models/quantization/ptq# bash run_tuning.sh --config=densenet121.yaml --input_model="/workspaces/Neural_Compressor/models/tensorflow/model" --output_model=./nc_densenet121

main --config=densenet121.yaml --input_model=/workspaces/Neural_Compressor/models/tensorflow/model --output_model=./nc_densenet121
init_params --config=densenet121.yaml --input_model=/workspaces/Neural_Compressor/models/tensorflow/model --output_model=./nc_densenet121
for var in "$@"
case $var in
++ echo --config=densenet121.yaml
++ cut -f2 -d=
config=densenet121.yaml
for var in "$@"
case $var in
++ echo --input_model=/workspaces/Neural_Compressor/models/tensorflow/model
++ cut -f2 -d=
input_model=/workspaces/Neural_Compressor/models/tensorflow/model
for var in "$@"
case $var in
++ echo --output_model=./nc_densenet121
++ cut -f2 -d=
output_model=./nc_densenet121
run_tuning
python main.py --input-graph /workspaces/Neural_Compressor/models/tensorflow/model --output-graph ./nc_densenet121 --config densenet121.yaml --tune
2022-02-14 18:47:44.290292: I tensorflow/core/platform/cpu_feature_guard.cc:151] This TensorFlow binary is optimized with oneAPI Deep Neural Network Library (oneDNN) to use the following CPU instructions in performance-critical operations:  AVX2 AVX512F FMA
To enable them in other operations, rebuild TensorFlow with the appropriate compiler flags.
2022-02-14 18:47:44.292744: I tensorflow/core/common_runtime/process_util.cc:146] Creating new thread pool with default inter op setting: 2. Tune using inter_op_parallelism_threads for best performance.
2022-02-14 18:48:34 [WARNING] Output tensor names should not be empty.
2022-02-14 18:48:34 [WARNING] Input tensor names should not be empty.
2022-02-14 18:49:02.538820: I tensorflow/core/grappler/devices.cc:75] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 0 (Note: TensorFlow was not compiled with CUDA or ROCm support)
2022-02-14 18:49:02.539043: I tensorflow/core/grappler/clusters/single_machine.cc:358] Starting new session
2022-02-14 18:49:02.564178: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:1149] Optimization results for grappler item: graph_to_optimize
function_optimizer: function_optimizer did nothing. time = 0.019ms.
function_optimizer: function_optimizer did nothing. time = 0.001ms.

2022-02-14 18:49:04.277543: I tensorflow/core/grappler/devices.cc:75] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 0 (Note: TensorFlow was not compiled with CUDA or ROCm support)
2022-02-14 18:49:04.277786: I tensorflow/core/grappler/clusters/single_machine.cc:358] Starting new session
2022-02-14 18:49:04.524204: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:1149] Optimization results for grappler item: tf_graph
constant_folding: Graph size after: 1118 nodes (-612), 1787 edges (-612), time = 85.762ms.
constant_folding: Graph size after: 1118 nodes (0), 1787 edges (0), time = 70.253ms.
2022-02-14 18:49:57 [INFO] ConvertLayoutOptimizer elapsed time: 1.95 ms
2022-02-14 18:49:58.696739: I tensorflow/core/grappler/devices.cc:75] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 0 (Note: TensorFlow was not compiled with CUDA or ROCm support)
2022-02-14 18:49:58.697680: I tensorflow/core/grappler/clusters/single_machine.cc:358] Starting new session
2022-02-14 18:49:58.829495: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:1149] Optimization results for grappler item: graph_to_optimize
model_pruner: Graph size after: 1115 nodes (-3), 1784 edges (-3), time = 19.002ms.
shape_optimizer: shape_optimizer did nothing. time = 1.244ms.
dependency_optimizer: Graph size after: 1114 nodes (-1), 1171 edges (-613), time = 19.209ms.
debug_stripper: debug_stripper did nothing. time = 1.636ms.
loop_optimizer: Graph size after: 1114 nodes (0), 1171 edges (0), time = 9.353ms.
model_pruner: Graph size after: 1114 nodes (0), 1171 edges (0), time = 10.482ms.
shape_optimizer: shape_optimizer did nothing. time = 1.148ms.
dependency_optimizer: Graph size after: 1114 nodes (0), 1171 edges (0), time = 13.312ms.
debug_stripper: debug_stripper did nothing. time = 1.285ms.
2022-02-14 18:49:58 [INFO] Pass GrapplerOptimizer elapsed time: 1625.51 ms
2022-02-14 18:49:59 [INFO] Pass SwitchOptimizer elapsed time: 227.41 ms
2022-02-14 18:49:59 [INFO] Pass RemoveTrainingNodesOptimizer elapsed time: 229.28 ms
2022-02-14 18:49:59 [INFO] Pass SplitSharedInputOptimizer elapsed time: 16.05 ms
2022-02-14 18:49:59 [INFO] Pass GraphFoldConstantOptimizer elapsed time: 215.11 ms
2022-02-14 18:49:59 [INFO] Pass FuseColumnWiseMulOptimizer elapsed time: 227.62 ms
2022-02-14 18:50:00 [INFO] Pass StripUnusedNodesOptimizer elapsed time: 892.47 ms
2022-02-14 18:50:00 [INFO] Pass GraphCseOptimizer elapsed time: 225.92 ms
2022-02-14 18:50:01 [INFO] Pass FoldBatchNormNodesOptimizer elapsed time: 718.75 ms
2022-02-14 18:50:01 [INFO] Pass UpdateEnterOptimizer elapsed time: 103.94 ms
2022-02-14 18:50:01 [INFO] Pass ConvertLeakyReluOptimizer elapsed time: 113.15 ms
2022-02-14 18:50:01 [INFO] Pass ConvertAddToBiasAddOptimizer elapsed time: 114.01 ms
2022-02-14 18:50:02 [INFO] Pass FuseTransposeReshapeOptimizer elapsed time: 116.84 ms
2022-02-14 18:50:02 [INFO] Pass FuseConvWithMathOptimizer elapsed time: 115.22 ms
2022-02-14 18:50:02 [INFO] Pass ExpandDimsOptimizer elapsed time: 112.96 ms
2022-02-14 18:50:02 [INFO] Pass InjectDummyBiasAddOptimizer elapsed time: 128.91 ms
2022-02-14 18:50:02 [INFO] Pass MoveSqueezeAfterReluOptimizer elapsed time: 112.66 ms
2022-02-14 18:50:03 [INFO] Pass Pre Optimization elapsed time: 58651.82 ms
2022-02-14 18:50:03 [INFO] Get FP32 model baseline.
2022-02-14 18:50:03 [INFO] Start to evaluate the TensorFlow model.
2022-02-14 18:50:04 [WARNING] Fail to forward with batch size=32, set to 1 now.
2022-02-14 18:50:04 [ERROR] Unexpected exception InvalidArgumentError() happened during tuning.
Traceback (most recent call last):
File "/usr/local/lib/python3.8/dist-packages/neural_compressor/experimental/quantization.py", line 151, in execute
self.strategy.traverse()
File "/usr/local/lib/python3.8/dist-packages/neural_compressor/strategy/strategy.py", line 323, in traverse
self.baseline = self._evaluate(self.model)
File "/usr/local/lib/python3.8/dist-packages/neural_compressor/strategy/strategy.py", line 501, in _evaluate
val = self.multi_objective.evaluate(eval_func, model)
File "/usr/local/lib/python3.8/dist-packages/neural_compressor/objective.py", line 222, in evaluate
acc = eval_func(model)
File "/usr/local/lib/python3.8/dist-packages/neural_compressor/utils/create_obj_from_config.py", line 132, in eval_func
return adaptor.evaluate(model, dataloader, postprocess,
File "/usr/local/lib/python3.8/dist-packages/neural_compressor/utils/utility.py", line 240, in fi
res = func(*args, **kwargs)
File "/usr/local/lib/python3.8/dist-packages/neural_compressor/adaptor/tensorflow.py", line 379, in evaluate
results = eval_func(dataloader)
File "/usr/local/lib/python3.8/dist-packages/neural_compressor/adaptor/tensorflow.py", line 326, in eval_func
for idx, (inputs, labels) in enumerate(dataloader):
File "/usr/local/lib/python3.8/dist-packages/neural_compressor/experimental/data/dataloaders/tensorflow_dataloader.py", line 88, in _generate_dataloader
for iter_tensors in dataset:
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/data/ops/iterator_ops.py", line 800, in next
return self._next_internal()
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/data/ops/iterator_ops.py", line 783, in _next_internal
ret = gen_dataset_ops.iterator_get_next(
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/ops/gen_dataset_ops.py", line 2845, in iterator_get_next
_ops.raise_from_not_ok_status(e, name)
File "/usr/local/lib/python3.8/dist-packages/tensorflow/python/framework/ops.py", line 7107, in raise_from_not_ok_status
raise core._status_to_exception(e) from None  # pylint: disable=protected-access
tensorflow.python.framework.errors_impl.InvalidArgumentError: assertion failed: [offset_width must be >= 0.]
[[{{node crop_to_bounding_box/Assert/Assert}}]] [Op:IteratorGetNext]
2022-02-14 18:50:04 [ERROR] Specified timeout or max trials is reached! Not found any quantized model which meet accuracy goal. Exit.
Traceback (most recent call last):
File "main.py", line 69, in
evaluate_opt_graph.run()
File "main.py", line 58, in run
q_model.save(self.args.output_graph)
AttributeError: 'NoneType' object has no attribute 'save'

from the log, the error should come from a wrong dataset is passed down.  dataset and dataloader concept come from Pytorch and are well-designed. In TensorFlow, there in fact is only dataloader concept. so I suspect you passed down a dataloader but not dataset to INC.
if the above info is not enough for you to root cause, could you pls share your code to reproduce?

I suspected that. I think it is tricky to write a script to convert custom dataset to imagenet TFrecord format. I actually just tried dataset concept and was able to do quantization. However it is only able to save as frozen graph, which is not preferable for TF 2.0. Is there are way to save the quantized model as SavedModel?


Use "pyetesync" user agent in get_auth_token()

Nice catch, and thanks a lot!
Just one comment, could you maybe move the 'pyetesync/' + __version__ part to a variable that's shared between this new code and BaseManager so the user agent definition is not done in two different places (and thus can potentially go out of sync)? Thanks!

You are right. There you go.

Merged (squashed together).
Thanks a lot!


issue #5941

@prateek-webkul
Working fine. but when the user is changing locale in RTL  then gets the same issue. please find the screenshot Here

@prateek-webkul
Thanks, now working fine


Call to undefined method MangoPay\MangoPayApi::getLogger()

Hello,
Anyone had this issue ? and why this happening ? i installed last version through composer, worked fine and suddenly i get this error message :
Call to undefined method MangoPay\MangoPayApi::getLogger()
Thank you

Hi @lalainarahajason
Could you give more context about when this happen ? You have an example of what trigger this error ?

Hello @lalainarahajason, we are looking into it.
As suggested by @H4wKs, could you provide more context please ?


added few patterns

Looks good, thanks for adding some new patterns. I will merge the pull request and have a new version pushed out to NPM shortly.

Published to NPM as version 1.2.6

Great. Thank you.


Any nuget-released planned including environment variable for culture?

Current nuget (3.1.0) doesn't include the possiblity to set web-worker environment variables like culture.
Issue: #67
This is a problem when needing to correctly format dates etc.
Since .NET 7 Threading support is still some time in the future this project is the only good option to use web-workers for more complex stuff using C#. Do you plan to do a new nuget-release anytime soon?
Excellent work by the way!
/Best Regards
"Matt"

done https://github.com/Tewr/BlazorWorker/releases/tag/v3.2.0


Use std::set instead of std::vector to indicate boundary attributes for BCs

This changes the user-facing interface for solvers to use std::sets instead of std::vectors of indicator values to denote the boundary attributes for applying boundary conditions

LGTM

LGTM

LGTM

This changes the user-facing interface for solvers to use std::sets instead of std::vectors of indicator values to denote the boundary attributes for applying boundary conditions


Feature request: Make Android app available on F-Droid

Hi,
Would it be possible to also publish the Android app to the F-Droid store? Or if not, at least provide a mirror for APK downloads?

Duplicate of #42 and #124


adding feedback link to doc

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[x ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[ ] Build (yarn build) was run locally and any changes were pushed
[ ] Lint (yarn lint --check) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: N/A
What is the new behavior?

Does this introduce a breaking change?

[ ] Yes
[ ] No

Other information

thank you @vivianjeng
yes, and I actually want to make another pr for introduction updates, I will include those suggestions, thanks!

Can this be merged with #435

I will open another PR and close this one actually.

Closed this PR due of similar task #371


Bit sizes in brillig binary operations should match the bit sizes of the operands

Closed in https://github.com/noir-lang/noir/pull/4391


[Feature Request] Single LogOut

Is there any possibility to implement, in the SAML2 backend and frontend plugins, the SLO endpoint?

I'm asking here if there would be some collaborations or interactions about the opportunity to develop this feature. Ping!

Probably this feature is not needed, probably a word could have been spent here.

If I configure in my SATOSA frontend
  endpoints:
    # to be implemented
    single_logout_service:
        'urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST': 'slo/post'

On SLO request by the SP I get
'Error: not a authn request`
If an IdP (auth target) do not handle properly force authn it should implement at least SLO.
I think that SLO should be considered usefull for security reasons in our context. Is there something more to consider?

In satosa.frontends.saml2._register_endpoints I read that every endpoint is registered as handle_authn_request.
    def _register_endpoints(self, providers):
        """
        Register methods to endpoints
        :type providers: list[str]
        :rtype: list[(str, ((satosa.context.Context, Any) -> satosa.response.Response, Any))]
        :param providers: A list of backend providers
        :return: A list of endpoint/method pairs
        """
        url_map = []

        for endp_category in self.endpoints:
            for binding, endp in self.endpoints[endp_category].items():
                valid_providers = ""
                for provider in providers:
                    valid_providers = "{}|^{}".format(valid_providers, provider)
                valid_providers = valid_providers.lstrip("|")
                parsed_endp = urlparse(endp)
                url_map.append(("(%s)/%s$" % (valid_providers, parsed_endp.path),
                                functools.partial(self.handle_authn_request, binding_in=binding)))

+1 to developing this. I was asked by my federation operator to provide a single logout endpoint, which I'm unable to do atm (unless I've misunderstood).

Correct me if I'm wrong, the cookie in satosa expires in a soon.
This parameter is configurable but probably not infinite, as a coockie released by a IdP could be (not expiring cookie).
Missing it in the frontend (IDP) it won't link the SLO request to any active sessions (context) so it won't know to which IdP ask to, by which backend, regarding which preivous authenticated saml session. This is an aspect that can be handled in a way or in another but, i think, that's my first impression about this problem.
Force authn to True give us a real workaround to this, because each session won't rely on the previous state.
Even more going out from SAML2 field would be more complex. Probably its first implementation would be done only for a pure SAML2 backend/fronted. just few cents, mostly ideas at first sight

I guess there is already some progress by @sebulibah in this PR: https://github.com/IdentityPython/SATOSA/pull/431
But I'm not sure what is the status.


Update Composer dependencies (2021-02-04-00-12)

Visual regression test passed!
View the visual regression test report


cornell: Fix 'raytracer' dispatch

This was rounding down the number of workgroups instead of 'ceil', resulting in a border at the right / bottom with garbage data.

Looks like GitHub actions got stuck.


Revert "Replace list attribute with sets (#163)"

This reverts commit 551369a73d92e53298fcec2c0922d19c45398b63.

Using sets only partially solves the problem of regions being destroyed and recreated, and it causes other problems as well, namely that Terraform can't figure out how to correctly update regions when the primary is changed.

TFTR!


Nick: Watch APKTodo

Nick requests the watch of the watch_keyword APKTodo. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

APKTodo has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


Editor render hashes on .vtt file after edit the captions file and save

We are under OC 13.2 and after editing the subtitles (for example add a segment on start and correct another one) I noticed that the saved .vtt having a strange hash appended
WEBVTT

cdsMIWME-BFRIXEgTP-r_
00:00.000 --> 00:08.500
*Musik*

C95hsdKF_mwLoqy7b86R6
00:08.500 --> 00:13.600
So, hallo, jetzt noch die zweite Session zu Vaskulitiden.

seXSsLVMImzS1lpi5Lfzu
00:13.600 --> 00:20.920
Ich möchte Ihnen nur nochmal ganz kurz die klinischen unterschiedlichen Präsentationen noch mal zeigen,

SDneUjBi2LSE8psNDJ74e
00:20.920 --> 00:28.320
dass Sie nochmal dran erinnern hier bei der ersten Präsentation. Ich hoffe, Sie schauen die auch in der Reihenfolge

I tried it on editor.opencast.org but this is not occurred there. I tried to test it against stable.opencast.org but unfortunately the CC menu is not activated on editor's cfg in stable. A good idea would be to be enabled by default.
The players can load the file but still the files are not formatted according to w3c standards. Is this a bug already fixed or did I miss-configure smth?

This does not occur on editor.opencast.org because a fix was recently merged: https://github.com/opencast/opencast-editor/commit/cc7d597b1b492bd2ecf5a5941e2301fe7ddb3363. It is not in a release yet. You did not misconfigure anything.
Subtitle Editing was enabled on develop.opencast.org at least at some point, seems to be disabled now. Probably best to contact whoever maintains those (Lars / lkiesow?).
Also the "strange hashes" are technically WebVTT ids and afaik valid WebVTT.


server: add vm boot details for start vm api

Description
Fixes #5466
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1319

@blueorangutan test matrix

@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-2128)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36330 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5469-t2128-xenserver-71.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-2129)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36481 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5469-t2129-kvm-centos7.zip
Smoke tests completed. 85 look OK, 4 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_add_primary_storage_disabled_host
Error
0.59
test_primary_storage.py

test_01_primary_storage_nfs
Error
0.10
test_primary_storage.py

ContextSuite context=TestStorageTags>:setup
Error
0.19
test_primary_storage.py

test_01_secure_vm_migration
Error
153.85
test_vm_life_cycle.py

test_02_unsecure_vm_migration
Error
276.91
test_vm_life_cycle.py

test_03_secured_to_nonsecured_vm_migration
Error
146.78
test_vm_life_cycle.py

test_08_migrate_vm
Error
41.69
test_vm_life_cycle.py

test_02_list_snapshots_with_removed_data_store
Error
1.18
test_snapshots.py

test_hostha_enable_ha_when_host_in_maintenance
Error
305.75
test_hostha_kvm.py

@shwstppr target to 4.15 ?

Done @weizhouapache
@blueorangutan package

@weizhouapache done
@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian. SL-JID 1343

@weizhouapache can you please have a look again

@blueorangutan package

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1348

@blueorangutan test matrix

@shwstppr a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan test centos7 xcpng82 keepEnv

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests

Trillian test result (tid-2152)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50338 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5469-t2152-xenserver-71.zip
Smoke tests completed. 88 look OK, 3 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_deploy_vm_start_failure
Error
92.77
test_deploy_vm.py

test_deploy_vm_volume_creation_failure
Error
105.88
test_deploy_vm.py

test_vm_ha
Error
93.22
test_vm_ha.py

test_vm_sync
Error
167.82
test_vm_sync.py

Trillian test result (tid-2153)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 56772 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5469-t2153-kvm-centos7.zip
Smoke tests completed. 87 look OK, 4 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_deploy_vm_start_failure
Error
78.39
test_deploy_vm.py

test_deploy_vm_volume_creation_failure
Error
65.73
test_deploy_vm.py

test_vm_ha
Error
60.61
test_vm_ha.py

test_vm_sync
Error
132.00
test_vm_sync.py

test_provision_certificate
Error
121.05
test_certauthority_root.py

Not sure why tests getting following exception:
2021-09-21 13:08:19,019 - CRITICAL - EXCEPTION: test_deploy_vm_volume_creation_failure: ['Traceback (most recent call last):\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 360, in run\n    self.setUp()\n', '  File "/marvin/tests/smoke/misc/test_deploy_vm.py", line 75, in setUp\n    count=6)\n', '  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 5267, in create\n    cmd = configureSimulator.configureSimulatorCmd()\n', "NameError: global name 'configureSimulator' is not defined\n"]

Will be investigating

Trillian test result (tid-2155)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 60858 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5469-t2155-xcpng82.zip
Smoke tests completed. 88 look OK, 3 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_deploy_vm_start_failure
Error
186.48
test_deploy_vm.py

test_deploy_vm_volume_creation_failure
Error
122.23
test_deploy_vm.py

test_vm_ha
Error
121.49
test_vm_ha.py

test_vm_sync
Error
206.38
test_vm_sync.py

test_deploy_vm_start_failure

@shwstppr this should has been fixed by #5456, maybe trillian testing env does not have the latest integration test scripts.

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1354

@shwstppr does this need testing? Pl kick appropriate env for smoketests + manual tests. Thanks.

@shwstppr does this need testing? Pl kick appropriate env for smoketests + manual tests. Thanks.

@rhtyd
the previous trillian test failures are caused by broken tests. I think smoketests is not needed.
of course we can also re-build the packages and re-kick the test when @DaanHoogland has backported #5456 to 4.15.
let's wait for a while.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian. SL-JID 1356

@blueorangutan test matrix

@nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

Trillian test result (tid-2170)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34049 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5469-t2170-kvm-centos7.zip
Smoke tests completed. 86 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_03_ssvm_internals
Failure
3.03
test_ssvm.py

Trillian test result (tid-2171)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37747 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5469-t2171-vmware-65u2.zip
Smoke tests completed. 87 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Trillian test result (tid-2169)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47481 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5469-t2169-xenserver-71.zip
Smoke tests completed. 84 look OK, 3 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

ContextSuite context=TestISOUsage>:setup
Error
0.00
test_usage.py

test_01_volume_usage
Failure
671.47
test_usage.py

ContextSuite context=TestAddVmToSubDomain>:teardown
Error
90.48
test_accounts.py

test_DeleteDomain
Error
307.02
test_accounts.py

test_forceDeleteDomain
Failure
394.17
test_accounts.py

ContextSuite context=TestServiceOfferingHierarchy>:teardown
Error
62.57
test_accounts.py

ContextSuite context=TestServiceOfferingSiblings>:teardown
Error
62.76
test_accounts.py

test_provision_certificate
Error
121.04
test_certauthority_root.py

@blueorangutan test centos7 xenserver-71

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + xenserver-71) has been kicked to run smoke tests

Trillian test result (tid-2177)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41155 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5469-t2177-xenserver-71.zip
Smoke tests completed. 86 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_cancel_host_maintenace_with_no_migration_jobs
Failure
306.77
test_host_maintenance.py

test_02_cancel_host_maintenace_with_migration_jobs
Failure
307.96
test_host_maintenance.py

test_03_cancel_host_maintenace_with_migration_jobs_failure
Failure
0.33
test_host_maintenance.py

@blueorangutan test centos7 xcpng82 keepEnv

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + xcpng82) has been kicked to run smoke tests

Trillian test result (tid-2204)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44058 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5469-t2204-xcpng82.zip
Smoke tests completed. 86 look OK, 1 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

test_01_volume_usage
Error
97.84
test_usage.py

ping @shwstppr @weizhouapache @nvazquez - is this ready for merging?
Looks like the usage test failure is intermittent?

ping @shwstppr @weizhouapache @nvazquez - is this ready for merging?
Looks like the usage test failure is intermittent?

@rhtyd
it is fine with me.

@shwstppr ready from my side

@rhtyd ready from my side


Change Language identifier for CUDA to correct one

Fix

Issue: doxdocgen is not triggered for CUDA files because the current language identifier in the activationEvents triggers is cuda but this is not correct because on the VS Code website it lists cuda-cpp for CUDA —this issue was mainly noticed because doxdocgen was not working in CUDA files (.cu, .cuh).

Fix: CUDA support is added again by correcting the language identifier to the —at this time— correct value.

Hi @jobtijhuis ,
thanks for catching that!
Is it possible that the identifier has changed in the meantime?
Do you see a problem when keeping the old identifier and the one you proposed?

I was using the Nvidia Nsight extension, but after looking at some other extensions they seem to use cuda as language identifier. It just seems that Microsoft together with Nvidia settled on cuda-cpp so that is what is on the official VSCode list. It will probably be good to support both.
I did not test the proposed change; I just changed the language of the .cu files to C++ as a temporary workaround to add documentation.


Fix ReactLegacy and delete RCTViewControllerProtocol

It's always bothered that we have this protocol and I figured it could just be merged with RCTWrapperViewController.
Test plan:
Build and Run both RNTester and RNTesterLegacy

why wasn't this just a diff 😅

I was lazy and didn't want to get on VPN..


Error processing ICE candidate in p2p

Hi guys, i'm experiencing some issues with this error.
This only happens in p2p room.
Every time I get this error and in most of cases it works anyway.
But, there is a strange case:
When I put one laptop under a symmetric nat and try to join the room with both laptop at the same time (using TURN), the subscriber under nat wil get a forever spinning icon.
This is caused by a peerconnection that fails but nowhere an exception is thrown.
this only happens when publisher and subscriber join at exactly same time.
Is not hard to reproduce, just try some times to reload the basicexample page on 2 different laptop at the same time (obviously one under Symmetric NAT)
if you get a forever spinning icon and try to unsubscribe and then re-subscribe to the stream, 100% will work.
Idk if this is related to the following error, but I think it need some attenction. especially when used in production, TURN are very important under business environment. our system match the user and let them join the room together. this, under turn will cause 50% of the times a spinning icon.
I'm trying to investigate myself right now, but if you have any ideas they're welcome!!

up!


GH-2867 reduce output from tests

GitHub issue resolved: #2867
Briefly describe the changes proposed in this PR:

PR Author Checklist (see the contributor guidelines for more details):

[ ] my pull request is self-contained
[ ] I've added tests for the changes I made
[ ] I've applied code formatting (you can use mvn process-resources to format from the command line)
[ ] I've squashed my commits down to one or a few meaningful commits
[ ] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
[ ] every commit has been signed off

Seeing the following in the logs (which should be checked out):
2021-03-10T17:44:12.7514614Z 17:44:12.750 [main] ERROR Shutdown ShaclSail while validation is still running.

Seeing the following in the logs (which should be checked out):
2021-03-10T17:44:12.7514614Z 17:44:12.750 [main] ERROR Shutdown ShaclSail while validation is still running.

Is this blocking a merge? Or can we handle that in a followup? It seems unlikely that it was introduced by these changes.


Unfolding long lists in clerk/table no longer works in latest version

With an upgrade from 0.6.387 to 0.7.418 unfolding long lists stopped working.
The button "X more..." is there, but doesn't do anything.
Tested on both Firefox and Chrome.

Hi, thanks for the report. We recently came across this regression as well and it's one my list of things to fix as part of a simplification of the viewer api that's currently happening in #152.


docs: Add Subsquid to tooling

What :computer:

Adds Subsquid to tooling section for indexing
Second thing updated with this PR
Third thing updated with this PR

Why :hand:

Covering a new tool available for the network

Evidence

@dariaag can you please address the conflicts and formatting.

Thank you for your contribution!
We wanted to let you know that this repository will be archived shortly as we've moved our work to a new repository. If you would still like to contribute, please feel free to submit your changes to our new repo: https://github.com/matter-labs/zksync-docs.
We appreciate your understanding and hope to see your contributions in the new repo!


[IMPROVEMENT] Investigate how Longhorn is working with CAPI rolling upgrade

Is your improvement request related to a feature? Please describe (👍 if you like this request)

We would like to investigate how Longhorn behaves in CAPI rolling upgrade case. How to make Longhorn reuse the replica in during this process instead of creating new replicas?
This reproducing steps is copied from the ticket https://gitlab.com/sylva-projects/sylva-core/-/issues/1141#reproduction-steps
Reproduction steps:

Deploy Sylva with longhorn with 3 BM nodes.
Set replica-replenishment-wait-interval=80 minutes for longhorn and numberOfReplicas: "2"
After deployment is completed, note down the details of longhorn replicas in GUI like name , state and status.
Before starting rolling upgrade, set below values in environmental-valueskubelet_extra_args:
    max-pods: "228"
capm3:
    nodeReuse: true
    automatedCleaningMode: disabled

Start rolling upgrade.
Check the status of longhorn replicas after rolling upgrade is completed.

Expected behavior:

Longhorn should not create new replica and should reuse existing (i.e. old) replica
Longhorn should rebuild the data using existing (i.e. old) replica

cc @c3y1huang @ejweber

Related: https://github.com/metal3-io/cluster-api-provider-metal3/issues/1584

Basically we need these things:

upgrade kubernetes and keeping the longhorn data on /var/lib/longhorn or an additional disk (this is covered in https://longhorn.io/docs/1.6.0/maintenance/maintenance/#in-place-upgrade )
redeploy the OS while keeping the node-id/node-name and keeping the longhorn data on /var/lib/longhorn or an additional disk
redeploy the OS while getting new node-id/node-name and keeping the longhorn data on /var/lib/longhorn or an additional disk

I am not sure if https://github.com/longhorn/longhorn/issues/8362 will be for 2. or for 3.?
Basically I assume that the challenge might be to "identify and re-use existing replicas in case the node-id/node-name changes"?

Additional info from @Martin-Weiss

As far as I understood - the major problem is that from a cloud-native approach an upgrade is always "throw away a node and create a new node" which per default will create new node-id/node-name - so if "3" is missing - I guess longhorn might need some design adjustments for "cloud-native" ? :wink: - basically it would be a good feature if we could move any longhorn data-disk from one node to another and it re-detects and re-uses the data automatically..
also 3 can be seen as a "disaster recovery" scenario as well, where the node is destroyed for whatever reason but you can still can use the longhorn device into a fresh one

@PhanLe1010 How did you solve that? We use cluster-api and face the same problems. I created an idea how this could be solved in an automated way: #8962 What do you think about that?


low_memory=False flag failing for large txt files

Getting a error when trying to read in large txt file, (13.5 mill rows, 120 columns) with low_memory = False flag in pandas.read_csv(). This is despite running on a machine with 1TB RAM. However, when switching low_memory = True, reads it correctly, but now risking mixed data types.
Solution:

Properly determine python data types from passed metadata.
Use that metadata dict when reading in the txt files instead of relying on low_memory flag.
Store metadata mappings in a serialized format to prevent loss on a half failed process for any other reason.

Addressed and fixed here: https://github.com/mark-hoffmann/fastteradata/pull/7


Fix null assignment to String

Problem
When there was no character in the current state info, it would fall back to null.
Solution
Adds an empty string as fallback value.
Context
This PR aims to fix #1923.
Therefore, I want to hear confirmation on the fixed behaviour.

Thanks!


pgwire: Fix varchar text format streaming

Didn't work correctly if the BytesRef instance had an offset.
testTwoSubStrOnSameColumn failed because of this.

@matriv please review

Igtm


update accessibility mode on window reload

fixes https://github.com/microsoft/vscode/issues/167583

Oh ok great then this should be good to review and merge

it turns out, we're already passing that in as an option, but not updating the status bar item on reload - so the latter is actually what's needed
https://github.com/microsoft/vscode/blob/a3dd458dc0e92eccee2390bba81615386447a8d3/src/vs/platform/windows/electron-main/windowsMainService.ts#L1380

@meganrogge there is a way to update the configuration explicitly when doing a window reload, see here:
https://github.com/microsoft/vscode/blob/422b581e3802e30cfb780c21d9cc1a2cd0c9f0aa/src/vs/platform/windows/electron-main/windowImpl.ts#L1043
For example we update some properties here:
https://github.com/microsoft/vscode/blob/422b581e3802e30cfb780c21d9cc1a2cd0c9f0aa/src/vs/platform/windows/electron-main/windowImpl.ts#L1069-L1070
I would think we can set accessibility mode too.

Thanks for the code pointers and continued discussion.
Based on logging, the values on environmentService.window do not get updated on reload and I don't think that's possible
It seems that consumers of INativeWorkbenchEnvironmentService end up using the storage service for this case instead
For example:
https://github.com/microsoft/vscode/blob/60bbd421a19e0443852712a8c74ce056a225e59a/src/vs/workbench/services/themes/electron-sandbox/nativeHostColorSchemeService.ts#L28-L59
When I open a window, the property is known. When I changed the theme to light and reloaded, logging the value of the theme shows that it was not correct (thus the necessity of the storage service)

@meganrogge theming might do something very special for other reasons, do not take it as an example. The values of the environment service will be updated based on the main side configuration from the reload call, can you try it?

I tried that and the value was undefined - perhaps because of a timing issue?

I noticed continueOn also uses the storage service and policiesData is used in initServices - which we can't do for the accessibilityService

@meganrogge a simple example works for me, here are my changes:
In windowImpl.ts:
configuration.verbose = true;

In constructor of window.ts:
console.log(this.environmentService.verbose);

On first start I get false and on reload true.

It does appear to be working for me now

Oh I had my old changes still, hopefully it will work when I remove them as well

that already happens here
https://github.com/microsoft/vscode/blob/84b9f9386aa15a6f4af12d570648dcdf767660d3/src/vs/workbench/services/accessibility/electron-sandbox/accessibilityService.ts#L44

Thanks for the help @bpasero 👍🏼


iOS 10 ,Xcode 8 Redefinition of module dnssd error.Are you updating to iOS 10 soon.

Hi,
iOS 10 ,Xcode 8 Redefinition of module dnssd error.Are you updating to iOS 10 anytime soon. I think xmpp framework needs to update to 3.7.0 on this project. Please let us know.
Thank you.

Hello @linwatt an User found a workaround for the moment : https://github.com/processone/demo-xmpp-ios/issues/7

Hey guys,
I am using this in my project as well just wondering if there has been a solution to this?
If there is could you please let us know?
Cheers.


Fix NFT rule/role update order

Issue Link: #519

@manuelpolzhofer yes those are different parts of NFT uniqueness, that we need to implement. This one is only about getting the flow right to provide proofs of uniqueness to the contract.

Merging this now, Follow ups -

Call smart contract to get the token URL
Refactor mint closure method to be smaller once we have entire flow
More tests for txManager edge cases

cc @lucasvo @manuelpolzhofer @vedhavyas


CI hangs infinitely

It seems to happen while running default-test from example/flake.nix. This isn’t something that happens always but whenever it does, I will have to manually restart the workflow.
See an example workflow here: https://github.com/juspay/services-flake/actions/runs/7513430525/job/20455173179?pr=73
I can’t seem to reproduce this in my local atm.

Maybe not only at default-test: https://github.com/juspay/services-flake/actions/runs/7513827171/job/20456036196
Either something is wrong with github actions or process-compose test process is failing to close after completion.

I am suspecting it could most likely be due to port collisions while running checks parallely, as this is the only thing that is shared across processes. In this case, we might have to do something that nixosTests does.
If this is the case, I should be able to reproduce locally by trying nix flake check multiple times but without using the /nix/store cache, is there a way?

--rebuild?

nix flake check doesn’t support —rebuild

I might have stumbled upon a fix for this issue while trying to flesh out some documentation for services-flake. Turns out if you follow the instructions in Getting Started section, on the first run pg1 is skipped because pg1-init fails to complete with an initdb error complaining about “failing to create data directory as it already exists". Then I scrolled up the logs in CI for a few builds that were running infinitely and found the same error.
Of course the test process depends on both pg1 and pg2 being up and running, and since that is not the case above, it hangs infinitely.
Why does it not happen all the time?
It all depends on how the processes are spawned, it happens only when both pg2-init and pg1-init tries to create data directory at the same time.

Note: this only happens on the first run, if you close and reopen the process-compose window, the other init process should succeed and start the server. To solve this in tests, we can use depends_on.