What are the type of the changes? (mandatory)

Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)
I built the code.
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
It should fix #3248.

LGTM

Thanks a lot! LGTM

/run-all-tests

/run-integration-common-test

Why is this deny rule only added to tikv-bench, not globally effective?

I didn't know if you wanted to have a global #![deny(warnings)]. I tested it on benches and it worked but not sure you'd want it for all the project.

I don't think it's a good idea. Warnings usually have the least priority to be fixed during a development. Denying it explicitly can waste time when we just want to do some quick tweak.
And warnings are denied in CI already, which should be good enough.

Should I remove the #![deny(warnings)] for the benches then?

@GuillaumeGomez Oh, yes. I think @BusyJay 's concern is reasonable.

LGTM

I would like to wait https://github.com/pingcap/tikv/pull/3294 to be merged first, since our CI is actually not checking clippy currently.

@breeswish It has been merged now.


Update to version 3.0.0

New Galaxy wrapper to support MOB-Suite version 3.0.0 - a plasmid typing tool

Great job @kbessonov1984! 👏


Fixed fixtures loading isolation in tests.

fixture1.json and fixture2.json exist in both fixtures and
fixtures_model_package. Both apps are listed in INSTALLED_APPS. The
loaddata management command loads from installed apps, thus loads both
fixtures when a test runs loaddata with any of these fixtures.

@francoisfreitag Thanks :+1:

Merged in 2e48cf6bd9499f888a6cebf9f18c92717f1df55c.


Update copyright notices.

The old 2014 copyright notice belied the considerable activity since.

I am using such header in other files:
/*
 * should.js - assertion library
 * Copyright(c) 2010-2013 TJ Holowaychuk<EMAIL_ADDRESS> * Copyright(c) 2013-2016 Denis Bardadym<EMAIL_ADDRESS> * MIT Licensed
 */

Tj stopped activity at 2013, and library was complitly rewriten.

In readme it makes sense to point just to license file, to do not repeat.

Understood.
Just want to point out, when an old copyright is displayed, it emits a signal of stagnation, which is fine except when misleading.  This repo has hundreds of commits since 2014...


Cannot use Icons under "Editor" category

Thank you @titan00001 for raising the issue, and your contributions are highly welcome 👍🏽


Growable stack

maybe_grow in lib.rs, if it becomes full again after expansion, I believe it will receive a SIGBUS/SIGSEGV signal.
Is it possible to increase the stack multiple times in the future?

Yes, you can call maybe_grow recursively for as long as you have memory available.

Yes, of course that's possible. What I want to ask is, can it be automatically wrapped? For example, using a macro, as long as the method calls are inside the macro, each method call is converted to be wrapped in maybe_row before making the original call.
original call:
fn call1() {
    // code may cause stack overflow
}
fn call2() {
    call1();
    call1();
    call1();
    ......
    // many times of call1()
}

usage:
// 4096/131072 is just a example
maybe_grow!(4096, 131072, call2)

expected effect:
fn enhanced_call2() {
    stacker::maybe_grow(4096,131072, call1);
    stacker::maybe_grow(4096,131072, call1);
    stacker::maybe_grow(4096,131072, call1);
    stacker::maybe_grow(4096,131072, call1);
    ......
    // many times of stacker::maybe_grow(4096,131072, call1);
}


bug: mobile not working

Uncaught TypeError: elem is undefined
    toggleHamburger https://s-ccs.github.io/libs/nav/hamburger.js:4
    onclick Ember

if I click the menu button in "mobile" view

got some of the code destroyed a few days back, when debugging. Fixed now

solved locally, however, code doesn't seem to be transferred to online version

forgot to update generation script


upstream HTTP filters: fix warning for upstream codec

Commit Message: Check for type not the name.

/wait
needs CI fix

/wait


Accessing large data collections from the frontend (v1)

When using a Vaadin Grid component in a TypeScript view I want to have an easy way of loading the data lazily so that users do not have to wait until the entire database is loaded into their browsers when they open that page.
In scope (v1)

An easy-to-use offset/limit-based Java backend API to expose pageable collections
An easy-to-use offset/limit-based JS frontend API to consume pageable collections
The backend is stateless (i.e. nothing is left in the server memory after a page request)
Support for sorting (possibly by several columns) in the Java / JS API
Support for filtering (possibly by several columns) in the Java / JS API
Support for counting items (with filters applied) in the Java / JS API
Counting items in the collection can be done in the same round trip with fetching a page
Support for sub-properties for sorting and filtering (e.g. customer.address.country)
Reasonable defaults (no exceptions) if the backend collection is modified between two page requests

Out of scope (v1):

The API browser gives a ‘nice’ view of methods returning a pageable collection
An easy-to-use cursor-based Java backend API to expose pageable collections
An easy-to-use cursor-based JS frontend API to consume pageable collections
Guarantees of consistency if the backend collection is modified between the two calls when using offset/limit-based pagination

The backend API is (partially?) implemented with the Pageable support.

A related list of common use cases for data-intensive UIs compiled by @Artur- : https://docs.google.com/document/d/1oN0wvp2tfQQiVWin9sN4j3dqSUegQr18meNqeppGx_A/edit?usp=sharing


No data collected by collector   : Repo Count              0        0s

Hi ,
Unable to get any data using bitbucket collector ,

 Property file

Database Name
	dbname=dashboarddb

	# Database HostName - default is localhost
	dbhost=localhost

	# Database Port - default is 27017
	dbport=27017

	# MongoDB replicaset
	dbreplicaset=[false if you are not using MongoDB replicaset]
	dbhostport=[host1:port1,host2:port2,host3:port3]

	# Database Username - default is blank
	dbusername=userdash

	# Database Password - default is blank
	dbpassword=dashboardpass

	# Logging File location
	logging.file=./logs/bitbucket.log

	# Collector schedule (required)
	git.cron=0 0/1 * * * *

	# Mandatory parameters (comma separated, if multiple)
	git.host=https://bitbucket.**************.com/

	#If using Bitbucket Cloud then go for below parameter for git.host
	#git.host=api.bitbucket.org/

	git.username=********************

	#convert password to base64
	git.password=************

	#Since the older api version is now depreciated so current api is given below for Bitbucket Cloud
	#(REF:https://confluence.atlassian.com/bitbucket/rest-apis-222724129.html)
	git.api=/api/2.0/repositories/

	# Maximum number of days to go back in time when fetching commits
	git.commitThresholdDays=15

	# Page size for rest calls
	#   Only applicable to Bitbucket Server.
	#   Only applicable to Bitbucket Cloud.
	git.pageSize=25

	# Bitbucket product
	#   Set to 'cloud' to use Bitbucket Cloud (formerly known as Bitbucket)
	#   Set to 'server' to use Bitbucket Server (formerly known as Stash)
	#   More information can be found here:
		https://github.com/capitalone/Hygieia/issues/609
	git.product=server

	# Bitbucket key for private repos
	bitbucket.key=*******************

command for running collector : java -jar bitbucket-scm-collector.jar --spring.config.name=git --spring.config.location=/root/hygieia_new/collector/hygieia-scm-bitbucket-collector/application.properties
Widget :

I have the same issue. Looks like the collector looks for the repo/branch info in mongo component collection which I assume should be getting updated by they UI when you save in the widget. I checked mongo and looks like the UI is never saving the data to mongo so when to collector runs it does not have the info required to collect from bitbucket.

I have same issue. The issue is due to bug in UI code. issue is UI is not sending widget details to API or API is not storing the widget details in MongoDB (under components table of type SCM". If i manually make entries in mongoDB, the UI shows all the details on dashboard.


clear thumbnails before generating new ones

I didn't have a chance to make sure this doesn't break anything :)
Right now if you search for "body" then "music" you can see some leftover thumbnails from the top result for "body" in the top result for "music" because it has less than 7 pages.
Body:

Music:

I also removed the first mkdir -p, because the command operates recursively so only the second one is needed.

doh! thanks for pointing out the thumbnail issue. I am hesitant to merge this because seeing the characters "rm" and "*" inside os.system() statements makes me sweat profusely. I'd really rather not. I'll fix the mkdir -p and the thumbnail problem. Thanks!

no worries! i was only going to post it as an issue but figured the least i could do is submit a PR :) thanks for the cool browser!


brew update with errors

Hello, after 10.12.6 update 'brew update' command outputs the following errors:
$ brew update
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Already up-to-date.

This is my 'brew doctor' and 'brew config':
$ brew doctor
Please note that these warnings are just used to help the Homebrew maintainers
with debugging if you file an issue. If everything you use Homebrew for is
working fine: please don't worry and just ignore them. Thanks!

Warning: You have a curlrc file
If you have trouble downloading packages with Homebrew, then maybe this
is the problem? If the following command doesn't work, then try removing
your curlrc:
  curl https://github.com

Warning: Some keg-only formula are linked into the Cellar.
Linking a keg-only formula, such as gettext, into the cellar with
`brew link <formula>` will cause other formulae to detect them during
the `./configure` step. This may cause problems when compiling those
other formulae.

Binaries provided by keg-only formulae may override system binaries
with other strange results.

You may wish to `brew unlink` these brews:
  curl

$ brew config
HOMEBREW_VERSION: 1.2.4
ORIGIN: https://github.com/Homebrew/brew
HEAD: b5529084906af89827f6d9befd613457a1615918
Last commit: 3 weeks ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 6d38158666cb60c06fd05e06986fa15b893cb65e
Core tap last commit: 47 minutes ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_REPOSITORY: /usr/local/Homebrew
HOMEBREW_CELLAR: /usr/local/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://homebrew.bintray.com
CPU: quad-core 64-bit haswell
Homebrew Ruby: 2.0.0-p648
Clang: 8.1 build 802
Git: 2.11.0 => /Applications/Xcode.app/Contents/Developer/usr/bin/git
Perl: /usr/local/bin/perl => /usr/local/Cellar/perl/5.26.0/bin/perl
Python: /usr/bin/python
Ruby<EMAIL_ADDRESS>=><EMAIL_ADDRESS>Java: 1.8.0_141, 1.8.0_131
macOS: 10.12.6-x86_64
Xcode: 8.3.3
CLT: <IP_ADDRESS>.1.1492020469
X11: 2.7.11 => /opt/X11

What's the output of brew update --force --verbose? Thanks!

@MikeMcQuaid,
$ brew update --force --verbose
Checking if we need to fetch /usr/local/Homebrew...
Checking if we need to fetch /usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade...
Checking if we need to fetch /usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask...
Checking if we need to fetch /usr/local/Homebrew/Library/Taps/caskroom/homebrew-versions...
Checking if we need to fetch /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core...
Checking if we need to fetch /usr/local/Homebrew/Library/Taps/homebrew/homebrew-services...
Checking if we need to fetch /usr/local/Homebrew/Library/Taps/sidaf/homebrew-pentest...
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Fetching /usr/local/Homebrew...
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Fetching /usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade...
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Fetching /usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask...
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Fetching /usr/local/Homebrew/Library/Taps/caskroom/homebrew-versions...
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core...
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Fetching /usr/local/Homebrew/Library/Taps/sidaf/homebrew-pentest...
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Fetching /usr/local/Homebrew/Library/Taps/homebrew/homebrew-services...
Updating /usr/local/Homebrew...
Reset branch 'stable'
Current branch stable is up to date.

Updating /usr/local/Homebrew/Library/Taps/buo/homebrew-cask-upgrade...
Current branch master is up to date.

Updating /usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask...
Current branch master is up to date.

Updating /usr/local/Homebrew/Library/Taps/caskroom/homebrew-versions...
Current branch master is up to date.

Updating /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core...
Current branch master is up to date.

Updating /usr/local/Homebrew/Library/Taps/homebrew/homebrew-services...
Current branch master is up to date.

Updating /usr/local/Homebrew/Library/Taps/sidaf/homebrew-pentest...
Current branch master is up to date.

Already up-to-date.

Do you have npm touch or typings installed?

@ilovezfs
No, I don't have npm in my system

Please try moving your ~/.gitconfig out of the way.
mv ~/.gitconfig ~/gitconfig-backup

and then try again.

I don't have .gitconfig in my home directory

Please try
sudo chown -R $(whoami) /usr/local/Homebrew/

and then try again.

@ilovezfs
Didn't helped:
$ sudo chown -R $(whoami) /usr/local/Homebrew/
$ brew update
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Failed to set filetime<PHONE_NUMBER> on outfile: errno 1
Already up-to-date.

Do you have a .curlrc file?

Yeah brew doctor says you do. Please try moving it out of the way, and then try again.

@ilovezfs,
It helped. Thanks
$ mv ~/.curlrc ~/.curlrc.bak
$ brew update
Already up-to-date.

Cool. If you figure out what line or lines in that file are causing the problem, please let us know.

@ilovezfs
It was remotetime line

@sickamongthepure ah that makes sense!

Is this considered a bug in Homebrew? I find the remote-time option quite useful for preserving timestamps when downloading files via curl. I think Homebrew shouldn't print weird errors with it enabled.
       -R, --remote-time
              When used, this will make curl attempt to figure out the timestamp
              of the remote file, and  if  that is available make the local file
              get that same timestamp.


Revert "cni-install: bump to v0.4.0, switch to ConfList"

Looking to see if this fixes the test failures.
 The tests ran before the last push.


⚠ Spryr has degraded performance

In 219b289, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 4098 ms

Resolved: Spryr performance has improved in 3102d91 after 7 minutes.


Implement module-ballerinax-oracledb

Purpose

Implement module-ballerinax-oracledb

Tasks

[x] Create Basic CRUD Operations

[x] Create docker container for tests

[ ] Complete Tests for Basic Operations

[ ] Create INSERT Types

[ ] Complete Tests for INSERT Types

[ ] Create SELECT Types

[ ] Complete Tests for SELECT Types

[ ] Create IN Types

[ ] Complete Tests for IN Types

[ ] Create OUT Types

[ ] Complete Tests for OUT Types

[ ] Create INOUT Types

[ ] Complete Tests for INOUT Types

[ ] Refactor the module

@praneesha Can you check API Docs please


Snowpack beta updates

More updates for the Snowpack tool:

fixed bug with chart title not updating
add change location button to chart title

 Tools: Snowpack


docs: Add logo of bash-it to readme

Add the logo of Bash-it to the readme- makes the readme more pretty and engaging!

@cornfeedhobo I added some more badges, to make the readme prettier :smile:


allow transforms w/missing deps to be restarted

Very cool. CL-QUIL could be a lot more usable in interactive mode than it currently is.

@ecp-rigetti File issues!

no u


Run operator as non-root

Changes
Run operator as non-root instead of a fixed UID. This fixes issues with OpenShift security context constraints.
Submitter Checklist

[ ] Includes tests if functionality changed/was added
[ ] Includes docs if changes are user-facing
[x] Set a kind label on this PR
[x] Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
/kind bug
Release Notes
Run operator as non-root instead of using a fixed UID. This allows the operator to run on OpenShift using the "restricted" security context constraint.

/hold
This should merge after #29

Now should merge after #31

I posted a comment related to this one in #28 about validating / ensuring we are running as non-root
/lgtm

/hold cancel


Fix download_run_once for containers

Add one more step (task) to containers download/upload sequence -
copy saved .tar containers to ansible host (delegate_to: localhost).
Then upload images to target nodes. It uses synchronize module so
if ansible host (localhost) is the same host as kube-master[0] then
new task causes no issues and the copy to localhost process is
basically skipped.
Closes #612

Also enabled download_run_once for travis CI by default

If CI with download_run_once is OK, I suggest to turn this mode by default for inventory vars

I have an idea to add a delegate node for the download_run_once mode. That node will be by default the 1st kube-master, or localhost. But the logic you want here will be preserved as well and localhost will be used anyway to save and push images around. See https://github.com/bogdando/kargo/commit/3c1259f242bfe1a2bb5311e97e6cb6700b4ca87c

Let's close this one and continue on the co-authored version

Superseded by #629


Dashboard: issue when filtering by date

I believe I found an issue with the timeline (ionRangeSlider) and the metrics crossfiltering: when filtering the dashboard by time interval, the actual time range presented does not include the upper limit.
This also implies that, when moving the slider back to the latest date, the graph presented does not match the one shown at first load time.
This issue is almost irrelevant for big and active networks, which receive frequent updates and where the differences between time intervals are minimal. But for smaller or younger communities, with much sparser activity, this becomes very evident and confusing.
To see what I mean, you can check here (ignore the poor size of the community and the lack of recent updates, it actually helps making the issue clear):
http://www.futuroanteriore.org/sviluppo/edgesense-dashboard
and:

drag the time slider left to any date
drag the slider back to the far right (latest date)
you will see that the graph doesn't get back to what it was when first loaded.

I believe the issue is here:
https://github.com/Wikitalia/edgesense/blob/master/static/js/edgesense/dashboard.js#L149
If I'm not mistaken, in lines like these ones:
metrics_bydate.filter([0, current_metrics.date]);
nodes_bydate.filter([0, current_metrics.date]);
edges_bydate.filter([0, current_metrics.date]);

the limits are actually excluded; so if:
current_metrics = data['metrics'][i];
the interval is actually representing data up to data['metrics'][i - 1]
This could be fixed with something like:
current_metrics = data['metrics'][i];
if (current_metrics == last_metrics){
	// reset all filters
	metrics_bydate.filterAll();
	nodes_bydate.filterAll();
	edges_bydate.filterAll();
} else {
	edge_metrics = data['metrics'][i + 1];
	metrics_bydate.filter([0, edge_metrics.date]);
	nodes_bydate.filter([0, edge_metrics.date]);
	edges_bydate.filter([0, edge_metrics.date]);
}

(maybe crossfilter provides more elegant ways but I couldn't find any)
I would correct this myself but I'd need to first set a testing environment: I'm working on a completely re-factored version of the code (I recently made @luca know and I will submit it for evaluation in the "v2" branch which he prepared for the purpose), so I'm not ready to work and test both versions just yet.

Thanks @mapofemergence. This is way beyond me, of course. Not sure if @luca is still looking at the code. Anyway, you guys let me know if I can help in any way.

no worries @albertocottica, I spoke with him already and either he'll jump on it or I might be able to do the fix myself, as soon as I manage to set up a proper working/testing environment.
I thought that opening an issue was worth it anyway, just to keep track of this.

ciao @albertocottica ! I haven't looked at the code in a while, but as @mapofemergence said we spoke yesterday, and I'd be happy to help (at least) to see the project evolve 😄


Theano support?

Hi guys, thanks for the effort. For a weird reason I can't install tf on my system so I have to use keras with theano.  Was there a valid reason you implemented this tf dependent (and i should give up converting this while i haven't put much effort)?

we'd love a pull request that adds theano support


[evm] Fixed the event issue

fixed the issue with emitting events with indexed arguments

added a Truffle-style test for Revert

resolves #185
Motivation
to fix the failed test
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
./compile_all_and_test.sh

@vgao1996 :exclamation: This PR is still missing approvals, unable to queue for landing

/land


[UTOPIA-906] Keyboard Accessibility changes - for app; + Nav movements via arrows

Description
This PR includes the following proposed change(s):

Keyboard Accessibility changes
Nav movement via arrow

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

How Has This Been Tested?
Open/Refresh a page. Do not click/press anything, but instead click "TAB". And follow the page with tab and nav via arrow keys.
Development Dependency Working Agreement

[x] My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
[ ] My code DOES include the importing of new dependencies into the DPIA ecosystem
If new dependencies are being introduced to the DPIA ecosystem:
[ ] The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readible
[ ] The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

[ ] N/A
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to project documentation or diagrams that reflect my changes
[ ] New and existing unit tests pass locally with my changes
[x] My code follows Airbnb React Style Guidelines

API Development Changes

[x] N/A
[ ] I have performed a self-review of my own code
[ ] My code follows standards and practices outlined in the BC Government API Development Guidelines
[ ] New and existing unit tests pass locally with my changes
[ ] My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

This is not currently working for me. Specifically, the arrow navigation doesn't appear to be functioning.

This is not currently working for me. Specifically, the arrow navigation doesn't appear to be functioning.

Weird. Browser cache clear, maybe? Worked flawlessly on mine. I tested on Edge and Chrome at-least. @Bottle7  - Happy to jump to a call to figure out further.

Partially works now. Current issue is that, once you tab to the side nav bar, you cannot tab backwards to elements before that. Tabbing forward works as expected.


[Android] Fix publication task for compose library

Changes

Configure the maven publish plugin to create Gradle tasks necessary for publishing the compose library to the remote repository (publishAllPublicationsToMavenCentralRepository etc).

Context

Part of https://github.com/matrix-org/matrix-rich-text-editor/issues/315

Codecov Report
Patch coverage has no change and project coverage change: +1.38% :tada:

Comparison is base (51083f9) 88.45% compared to head (8269c32) 89.83%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #764      +/-   ##
============================================
+ Coverage     88.45%   89.83%   +1.38%
============================================
  Files           153       82      -71
  Lines         17739    14693    -3046
  Branches        832        0     -832
============================================
- Hits          15691    13200    -2491
+ Misses         1839     1493     -346
+ Partials        209        0     -209

Flag
Coverage Δ

uitests
?

uitests-android
?

uitests-ios
?

unittests
89.83% <ø> (+2.80%)
:arrow_up:

unittests-android
?

unittests-ios
?

unittests-rust
89.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 71 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Boost item  not selected

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
NA
FGA build number
1611
Describe the bug
Event boost item select doesn't work properly
Video
https://youtu.be/nNqAkVdpVik
Device model
Xiaomi redmi note 8 pro
Android version
11
Screen size
1080 x 2340
RAM
6gb

Also suffering from this problem.

It's not only the item selection but also the mana prism reward screen.

I hadn't even gotten far enough to hit that issue but I can see that being just as much a problem.

What do you mean? Just tap on the item, then let FGA finish the quest.

Oh I was trying to do fully automated farming with 0 input so I could leave it running overnight. So needing any kind of input to proceed ruined that plan.

I can confirm that this is a problem, regardless of what your settings for Boost Item is. It can't even skip it.

Confirm all the above, seems like boost function is broken.

If you don't want to use booster item in the bugged version. You can choose begin without booster item and go like normal. The repeat from then they won't asks for item booster.

I didn't have time to look into this issue, I'm closing it for now since the event is already over and I don't know if any future events will cause the same bug.


Duplicated className style props

ClassName style props are duplicated in version 5.0.5. Check Heading component in the example.

Example: https://codesandbox.io/s/styledsystembasicdemo-fqy1r

Can confirm 👍

Ah, I see what’s happening. The fontSizeand lineHeight functions are shimmed so that things don’t break when upgrading, but they should be replaced with the new typography one. I’ll see if there’s a way to avoid the duplication in the shims as well though

I'm seeing the same thing with properties from style functions other than typography, FWIW: https://zpt80.codesandbox.io/

@colepeters this will probably happen for any of the new category functions

@jxnblk Just to clarify: even if only the category functions are used, and not any shims from the same category?

@colepeters if only the new category functions are used, it should not happen. I can't seem to see the source code for the codesandbox above, so I'm unsure how you've used it...

@jxnblk Crap, sorry, I'm horribly late to codesandbox — does this work? https://codesandbox.io/embed/bold-night-zpt80

@colepeters it looks like you have a few "duplicate" functions in there.
Instead of this:
const Box = styled("div")(
  border,
  boxShadow,
  color,
  display,
  flexbox,
  layout,
  opacity,
  overflow,
  position,
  space,
  typography,
  transition
)

Try this:
const Box = styled("div")(
  compose(
    border,
    shadow,
    color,
    flexbox,
    layout,
    position,
    space,
    typography,
    transition
  )
)

Things to note:

The compose utility should dedupe these if they exist
display and overflow are included in layout
opacity is included in color

@jxnblk Thanks! I had an instance similar to the codesandbox example in my codebase without the 'duplicates' where this was also happening, but as soon as I wrapped them with the compose function, things were tidy as heck. Yay!

Generally you should use compose to combine multiple style props to avoid this issue. The shims have been updated to help mitigate some cases where this would happen. Closing this issue, but feel free to open new issues if needed


Issue with estop_ state in modules/control/control.cc

Should there be a "estop_ = false" statement added inside the else block (line 164~165) of function Status Control::ProduceControlCommand(ControlCommand *control_command) in apollo/modules/control/control.cc? It seems that the vehicle will remain in estop state indefinitely until Control::OnPad is invoked, if estop_ was set true due to some non-ok status in the last control cycle but everything works fine in the current cycle. Is this the expected semantic?

I believe this is the expected behavior when we handle estop now.

@lianglia-apollo Thanks for your reply! That means for the current design, once an estop happens, the vehicle will stop until some human intervention happens (e.g., sending a pad message with DrivingAction::RESET)?

Yes, that is correct.


Implement support for automatically coloring output in DiagnosticsFormatter

This builds on the work in #1256 to add support for automatically enabling output coloring as suggested by @ahoppen. As of this change when invoking $ swift-parser-cli print-diags in a terminal it will enable output coloring by default. The --colorize flag introduced in #1256 is still supported to force output colors, if desired.
API-wise this should be a non-breaking change since it only adds overloads to instantiate a DiagnosticsFormatter with a new ColorMode parameter (shamelessly stolen from swift-format).
Some notes:

This implementation only copies the absolutely minimum required components from swift-format and swift-tools-support-core to enable the feature. I'm happy to discuss moving more things over from TSC / laying the groundwork for further development if that improves the end result.

In particular, TSC wraps stderr with a few wrapper types to simplify reading/writing to it. This doesn't seem to be used for detecting a TTY environment which is why I left it out for now.

I noticed that swift-tools-support-core exposes a TSCLibc module that re-exports symbols from C standard libraries on the various platforms (Glibc for Linux, CRT on Windows and Darwin.C on Apple platforms) but opted to "inline" the use of stderr for now. Don't have the resources at the moment to test this cross platform and so would more than appreciate any pointers here.
The implementation in TSCBasic uses a ProcessEnv type to read properties from the environment (relevant in this case is the ProcessEnv.vars["TERM"] call to check whether it's set to "dumb") on non-Windows platforms. I've opted to remove support for detecting this case for now since copying ProcessEnv into swift-syntax seems out of scope but please do let me know if there's anything I'm missing here.

Additionally, I've taken the liberty of adding "error:" and "warning:" prefixes to formatted output when coloring is enabled to help with accessibility, as suggested by @DougGregor in #1256. I realize it's slightly out of scope but it's a nice addition in my opinion, let me know if this is better suited for a separate PR.

@swift-ci please test

Looks like tests are failing because I forgot to add TerminalUtils.swift to CMakeLists, I've pushed a new commit that fixes this.

@swift-ci please test

Ah, the remaining macOS failure is because we've been trying not to introduce a Darwin dependency into the parts of swift-syntax that get linked into the compiler.

I have a concrete suggestion. How about we move the TTY detection logic down into swift-parser-cli, which is allowed to have more dependencies (on Foundation, system packages like Darwin, etc.), and have the SwiftDiagnostics formatter code only take a Bool for whether the output should be colorized or not.

@DougGregor thank you for reviewing! I've moved the TTY detection logic and made the warning: prefix bold.

@swift-ci please test

@swift-ci please test

@ahoppen are you okay with those suggestions being addressed in a follow-up PR?

I'm going to merge because this is progress, and we can address feedback in a follow-up.


fix storage bootstrap race condition

We should not run box.cfg on a storage node if it is not declared in the autovshard consul config

I think we should also log a message for the case when we are not applying the config. Something like this
log.info("autovshasrd: won't apply the config, instance_uuid=%q not found in consul config", self.box_cfg.instance_uuid)

Looks like tarantool docker image is broken. https://travis-ci.org/github/bofm/tarantool-autovshard/jobs/678676483#L252. Need some time to fix the builds.

Thanks.


convertFromHTML anchor tags href conversion issues

Do you want to request a feature or report a bug?
bug
What is the current behavior?
When using convertFromHTML with anchor tags with href's such as:
 <a href="let_me_feel_my_feelings_please" > thanks </a>,
The content state will have the link with the url as: "http://localhost:8080/let_me_feel_my_feelings_please"
or whatever the current domain is added in front.
This happens bc in the code, convertFromHTMLToContentBlocks.js around line 640 (0.11.4), in method _addAnchorNode, the href is being extracted from the DOM node like this entityConfig.url = new URI(anchor.href).toString();
Possible Solution
Can we please just grab the attribute so that we can allow for other uri schemes? Like so:
entityConfig.url = new URI(anchor.getAttribute('href')).toString();
This would be awesome
Which versions of Draft.js, and which browser / OS are affected by this issue? Did this work in previous versions of Draft.js?
I am using 0.11.4

I now notice that uri scheme of hello strips out the link from entities map completely.

@kurtschlueter I run into the same issue. Thanks for your approach. It helped to resolve my problems

Ran into the same issue too when trying to parse tel: hrefs. It was stripping out the whole link and returning # as the ref. Thanks for helping

@kurtschlueter thanks for solving this! I was pulling my hair out over this issue


Add airport blacklist

if airport is blacklisted, its not allowed to be used

blacklist: KBP,CKC,CWC,IFO,HRK,IEV,KWG,LWO,ODS,RWN,UMY,TNL,UDJ,VIN,OZH,ALP,LTK,DAM,DEZ,KAC,PMS,BEY,ABD,AWZ,AJK,BND,XBJ,ZBR,GBT,HDM,IFN,JAR,KHD,KIH,LFM,LRR,IMQ,MHD,GSM,RZR,CQD,SYZ,TBZ,IKA,THR,FNJ


GitHub Action

This will build and test myWebLog, then create the release packages required

This is rolled into v2.1


Improve flexibility of get_events

This adds additional kwargs that shouldn't affect existing users, but at the same time adds more ability to control data coming from zenoss.

+1, this would be helpful

Imagine this was merged. Isn't that a wild idea?

More kwargs the better. +1

for some reason I never get emails about PRs. sorry for being late to this.


Tests is installed as package

When installing the package with pip, two packages are actually installed: transifex and tests (the latter containing the tests for the package). This might slows down the installation, takes up more space, and might create conflicts with any other tests modules.
The tests package can be prevented from being built and installed by a small change in setup.py (see PR #87)

And a second PR for it: https://github.com/transifex/transifex-python/pull/90

Fix released on version 3.0.3


[BUG] Index was outside the bounds of the array

Existing rule
No response
Description of the issue
First of all thanks for fixing the other issue I reported.
In this case the issue happens in the output causing an "Index was outside the bounds of the array.". If I remove the user defined type it starts working.
Error messages
##[error]Unable to expand resources because the source file 'D:\a\1\s\main.bicep' was not valid. An error occurred evaluating expression '[resourceId('Microsoft.Web/sites', variables('webAppsNames')[range(0, length(variables('webAppsNames')))[copyIndex()]])]' line 46. Index was outside the bounds of the array.
Reproduction
type AppServiceSkuTier = 'Basic' | 'Standard' | 'PremiumV2' | 'PremiumV3'

var webAppsNames = [
  'example1-webapp'
  'example2-webapp'
]

resource webApps 'Microsoft.Web/sites@2022-09-01' existing = [ for webAppName in webAppsNames : {
  name: webAppName
}]

output webAppIds array = [for i in range(0, length(webAppsNames)): webApps[i].id]

Version of PSRule
2.9.0
Version of PSRule for Azure
1.39.2
Additional context
No response

Thanks for reporting the issue @CharlesToniolo.


Offer different suggestions for road type

Currently all "Used features" are added as Residential roads with the tag highway=residential. It would be better to have a choice between the other kinds of highway=*-tags.
Other kinds of roads that are often not mapped but identified by the AI are:

highway=track for forest and agriculture roads
highway=service for service roads for example in industrial areas
highway=unclassified for rural roads that are not residential roads

Thanks for sharing the feedback @Spanholz ! We also use AI-based methods for detecting road types, and "residential" is actually not the only tag we generate - e.g. some of the AI roads at this location are auto-tagged with "track".
However tagging is a much harder problem to solve than road identification, and as you suggested the auto-generated tags are sometimes wrong. So mappers may need to change the suggested tag upon adding the RapiD road. We are actively working on making the AI predictions better, and will keep updating the AI roads dynamically as more progress is made.

Thanks for the clarification that the road type is also part of the AI detection. I only saw residential roads for now. Maybe present the AI result first and show some other road types to choose from as alternatives. That way it's faster to add the correct road type.

Thanks for the suggestion! In slightly longer term, we do plan to show a list of possible types for users to choose from, ordered by prediction confidence.
One useful thing for now is that you can use the "Shift + C" hotkey to quickly rotate through several common types ;)

It seems ok to close this - the Shift+C hotkey to cycle tags works pretty well when adding an AI detected road and you want to adjust its type.


Camera does not zoom in when applying to world bounds

This is not a bug but more an API problem. This can be closed.


Add support for DROP TABLE IF EXISTS statement

This PR adds support for DROP TABLE IF EXISTS statement.

Seems good. Thank you @toga4 for you contribution!


Migrate to using SCS supported library (and other) clients

Use this instead:
https://github.com/sylabs/scs-library-client

Oops, that repo is private and in CRI we vendor deps. Do we want to make repo public or vendor private code a bit? Maybe @tri-adam will help

The official SCS Library client will be open-sourced shortly (sylabs/scs-library-client#11).


Pass Default Field Values to @attributes

Not sure if this is by design, but currently the default values are passed to each field, but not the attributes hash when creating a new record. Mine might be an edge case but what I'm looking for is something like:
class Ticket < ActiveHash::Base
  field :quantity
  field :type, :default => "General Admission"
  field :purchase_id, :default => "1189898495947654440"
end

payload = Ticket.new(:quantity => 4).attributes
# => {:quantity => 4, :type => "General Admission", :purchase_id => "1189898495947654440"}

Background: I'm building stub server which will be used for testing several services with shared dependencies; dynamic stub creation is necessary(easier) in test cases with complex stub manipulation.

Agree, this is what I'd expect from #attributes


Format v2 umbrella bug

We're probably ready to think about the next iteration of the format.
http://ndjson.org/
Related #11

My sense is that we will need to give up something that we currently have.
Good: ndjson gives us the capacity to easily append and combine libraries, as well as streaming and parallel parsing support.
Bad: using ndjson takes away our ability to specify version and model.
My sense is that we may have to split the library into two files (or two API calls):

[library].ndjson -- contains the data
[library].metadata.json -- contains the metadata (currently, version and model)

For the API, this will look like two different GETs.
Format of the data file:
Content-Type: application/x-ndjson
{ "id": "string", "text": "string", "token_count": "number", "embedding": "string", "info": "info", "similarity": "number", "access_tag": "string" }
{ "id": "string", "text": "string", "token_count": "number", "embedding": "string", "info": "info", "similarity": "number", "access_tag": "string" }
...

Format of the metadata file:
Content-Type: application/json
{
  "version": number,
  "embedding_model": "string",
}

WDYT?

Having two different GETs makes me nervous and is a bit of a smell. I imagine most clients will just skip doing it, but part of what makes a federated model work is that everyone's checking for expected models and versions, so different nodes can seamlessly upgrade.
I'm not familiar with how people canonically use ndjson... would it be kosher to say "the first row must be structured as a header JSON blob (the thing you just sketched out as being in the metadata file above) and all subsequent rows must be a Bit JSON blob, in sorted order?" Or would it be weird to specify that the first row is a different shape?
One of the nice things about the current structure is the wire format is also the in-memory format and everything travels together nicely (of course, it makes streaming impossible!). I wonder if we need some kind of single-json representation, and some semantically equivalent ndjson version, which can be translated between equivalently.
Something like:
Canonical single-json version:
{
  "version" number,
  "embedding_model": string,
  //... other heading keys/values
  "bits": [
    //Each bit in order
    { //...}
  ]
}

Is precisely semantically equivalent to the following NDJSON:
{
  "version" number,
  "embedding_model": string,
  //... other heading keys/values
  //The absence of "bits" key in the first json blob signals that this is the ndjson dialect
}
//Each bit in order
{ //...}

Also, now I wonder, what happens if you pass a NDJSON formatted string (with multiple blobs) to JSON.parse? will it just silently give you back the first parsed blob and drop the rest? Or will it barf? If the latter, then doing this "sometimes it's a single JSON, sometimes it's a NDJSON" will be a pain in the butt...

I am realizing we're running into the same "Header" design problem that both HTTP and SMTP ran into 😆

Hah yah... "oh we can put the version in a header" oh wait how do I define that... how does it not get out of sync ...

We could have the content type also have the version "application/x-ndjson;polymath=V2"

I wonder if there also are different things, like intermediate storage representation, API, and canonical format. Like, maybe for endpoint communication, we need to shift our thinking to OpenAPI representation, rather than just format?


codecov/project fails because threshold is 0%

We could fix this by changing the threshold to 1 or 2%, or we could add the following to the codecov.yml file:
coverage:
  status:
    project:
      default:
        informational: true
    patch:
      default:
        informational: true

Adding the informational: true  will not fail the CI check (I think).
Should we change the config file to one of those?

The changes are added in #789 .

I think #789 fixed it!


LM meeting 19/09/2024 presentation

[ ] Demo lab guide Hans over LM page

[ ] Show how good it is on a github page

[ ] Tour of github page (mkdocs.yaml + md files)
[ ] Show the process about how to add and edit that page + demo for pr review
[ ] Start coping the gdoc section to github

[ ] 1 github expert + 1 non expert
[ ] assign issues

[ ] 11:45 sto editing and start brain storming about

[ ] how to restructure the index
[ ] add new sections
[ ] assign new sections

Slides here https://docs.google.com/presentation/d/1BhZpsLsIKARC8sSo-_U41gb732pzFX8jKAijGJMUyoM/edit#slide=id.g300d1690bf8_0_2


Missing h5ad file in 3D reconstruction

In 5_tdr/3D reconstruction.ipynb, The provided file here is missing
adata = st.sample_data.drosophila(filename="E7-9h_cellbin.h5ad")
Traceback (most recent call last):
File "/mnt/data/aim/fanyimin/projects/spateo-tutorials/5_tdr/3D Reconstruction.py", line 33, in
adata = st.sample_data.drosophila(filename="E7-9h_cellbin.h5ad")
File "/mnt/data/aim/fanyimin/projects/spateo-release/spateo/sample_data.py", line 118, in drosophila
adata = get_adata(url=url_dict[filename], filename=filename, dir_name=dir_name)
KeyError: 'E7-9h_cellbin.h5ad'

Waiting for the data update, thank you very much!

When will the data be updated?


dnscrypt-proxy does not start because of authorization problem

Hello all,
I use dnscrupt-proxy v2.0.17 on Fedora 28. When I start the service with service dnscrypt-proxy start an error is thrown : Unable to use source [public-resolvers]: [read udp <IP_ADDRESS>:47470-><IP_ADDRESS>:53: read: connection refused].
Here is my configuration file dnscrypt-proxy.toml:
server_names = ['scaleway-fr', 'cloudflare', 'cloudflare-ipv6', 'cisco', 'cisco-ipv6', 'dnscrypt.nl-ns0', 'dnscrypt.nl-ns0-doh', 'dnscrypt.nl-ns0-ipv6']

listen_addresses = []

max_clients = 250

ipv4_servers = true

ipv6_servers = true

dnscrypt_servers = true

doh_servers = true

require_dnssec = true

require_nolog = true

require_nofilter = true

force_tcp = false

timeout = 2500

keepalive = 30

use_syslog = true

cert_refresh_delay = 240

fallback_resolver = '<IP_ADDRESS>:53'

ignore_system_dns = true

netprobe_timeout = 30

log_files_max_size = 10

log_files_max_age = 7

log_files_max_backups = 1

block_ipv6 = false

cache = true

cache_size = 512

cache_min_ttl = 600

cache_max_ttl = 86400

cache_neg_min_ttl = 60

cache_neg_max_ttl = 600

[query_log]

  format = 'tsv'

[nx_log]

  file = '/var/log/dnscrypt-proxy/nx.log'

  format = 'tsv'

[blacklist]

  blacklist_file = '/etc/dnscrypt-proxy/blacklist.txt'

  log_format = 'tsv'

[ip_blacklist]

[whitelist]

[schedules]

[sources]

  [sources.'public-resolvers']
  urls = ['https://raw.githubusercontent.com/DNSCrypt/dnscrypt-resolvers/master/v2/public-resolvers.md', 'https://download.dnscrypt.info/resolvers-list/v2/public-resolvers.md']
  cache_file = '/var/cache/dnscrypt-proxy/public-resolvers.md'
  minisign_key = 'RWQf6LRCGA9i53mlYecO4IzT51TGPpvWucNSCh1CBM0QTaLn73Y7GFO3'
  refresh_delay = 72
  prefix = ''

[static]

When I consult the syslogs with journalctl _SYSTEMD_UNIT=dnscrypt-proxy.service, the only logs I see are:
dnscrypt-proxy[11579]: Unable to use source [public-resolvers]: [read udp 192.168.XX.XX:47470-><IP_ADDRESS>:53: read: connection refused]
dnscrypt-proxy[11579]: No servers configured

Anyone has he a idea of why the software does not work on my machine?

Try <IP_ADDRESS> instead of <IP_ADDRESS>?

Excellent! It's weired bit since few days my cable provider router's seems filter this IP... I'll investigate.
Thanks!


Paypal button work in developer.paypal.com/demo/checkout but not in localhost

Hi I am having problem with paypal button lately. Previously it worked without any problem, but not it stopped working.
I pasted the same code from
https://developer.paypal.com/demo/checkout/#/pattern/client OR
https://developer.paypal.com/demo/checkout/#/pattern/confirm
with my client_id
Ab9GzTPdwikNy4-mmGP2nNXuOeYCABf-U5Ct7UsCuvTC6a60gUbBCygj8-fivy5_KufPHAfQCdKuQfCS
Here is the code snippet
paypal.Button.render({
   env: $('#paypal-button-container').data('env'), // sandbox | production

   // PayPal Client IDs - replace with your own
   // Create a PayPal app: https://developer.paypal.com/developer/applications/create
   client: {
     sandbox: $('#paypal-button-container').data('client-id')
   },

   // Show the buyer a 'Pay Now' button in the checkout flow
   commit: true,

   // payment() is called when the button is clicked
   payment: function(data, actions) {

       // Make a call to the REST api to create the payment
       return actions.payment.create({
           payment: {
               transactions: [
                   {
                       amount: { total: "#{total}", currency: 'GBP' }
                   }
               ]
           }
       });
   },

   // onAuthorize() is called when the buyer approves the payment
   onAuthorize: function(data, actions) {
     // return actions.payment.get().then(function(data) {
     //   var shipping = data.payer.payer_info.shipping_address;
     // }

       // Make a call to the REST api to execute the payment
       return actions.payment.execute().then(function(data) {
         $.post( "/charges", { data: data } );
       });
   },
   onError: function (err) {
     // Show an error page here, when an error occurs
   }

 }, '#paypal-button-container');
}

$('#paypal-button-container').data('env') returns 'sandbox' and
$('#paypal-button-container').data('client-id') returns sandbox clientid (Ab9GzTPdwikNy4-mmGP2nNXuOeYCABf-U5Ct7UsCuvTC6a60gUbBCygj8-fivy5_KufPHAfQCdKuQfCS)
Few days ago it worked without any problem but not it didn't work at all.
Now when I click the Paypal button, the popup appears and disappears in about 3 seconds and nothing happens.
I get this warning when I load the page containing the Paypal button.
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://www.paypal.com/webapps/hermes/api/logger. (Reason: CORS request did not succeed).
Use of Mutation Events is deprecated. Use MutationObserver instead. script.js:60:8
Use of Mutation Events is deprecated. Use MutationObserver instead.

Tested with
google chrome Version 68.0.3440.106
Firefox 61.0.2

Are you running on a local server or a file:// path

@bluepnume No I am running a Rails localserver http://localhost:3000

@bluepnume Found out the issue. I and sending total as undefined. Sent the any float value and it worked


Issue building on FreeBSD

Hi,
I just tried building the project on FreeBSD after installing rust from packages.
This is the output I get:
Compiling ber v0.1.0 (https://github.com/NLnetLabs/ber-rs.git#18a0b990)
Compiling rpki v0.1.0 (https://github.com/NLnetLabs/rpki-rs.git#8cd80010)
error[E0658]: use of unstable library feature 'slice_rsplit' (see issue #41020)
  --> /root/.cargo/git/checkouts/rpki-rs-a43ad3b5562cba05/8cd8001/src/rsync.rs:85:30
   |
85 |         let tail = self.path.rsplit(|ch| *ch == b'/').next().unwrap().len();
   |                              ^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0658`.
error: Could not compile `rpki`.

To learn more, run the command again with --verbose.
#

I'm running everything as root.  It's a test vm I created just for this, so nothing else is running and is installed there.

Which version of Rust do you have? You can check with rustc --version.
Turns out you need 1.27 as slice's rfind method was stabilized only then.
Looking at FreeBSD's port list, it should have rust-1.27.1, so maybe just update?
Sorry about this. I'll add some more specific information about the required version to the README.

Martin Hoffmann writes:

Which version of Rust do you have? You can check with rustc --version.
Turns out you need 1.27 as slice's rfind method was stabilized only then.
Looking at FreeBSD's port list, it should have rust-1.27.1, so maybe just update?

Yes, it builds with 1.27.1 from the ports, no problem.
I'm trying to turn it into a port to make live easier for FreeBSD
users, It runs into other problems doing that. That has to wait to
after the weekend.
jap

Strange, I installed rust from ports and I got 1.26.2.
I'm now proceeding to install rust from ports and will let you know.
Thanks

Massimiliano Stucchi writes:

Strange, I installed rust from ports and I got 1.26.2.

[jaap@bela ~]$ rustc --version
rustc 1.27.1

I'm now proceeding to install rust from ports and will let you know.

Make sure you updated the ports as well. 1.27.1 in ports is pretty recent as shown by:
(cd /usr/ports/lang/rust; svn log | sed 60q; )

Thanks

Succes!
jaap

On 28/07/2018 10:39, Jaap Akkerhuis wrote:

Massimiliano Stucchi writes:

Strange, I installed rust from ports and I got 1.26.2.

I actually meant to say I installed from packages.  I just noticed the
mistake here.
Packages have 1.26.2.

[jaap@bela ~]$ rustc --version
rustc 1.27.1

I'm now proceeding to install rust from ports and will let you know.

Make sure you updated the ports as well. 1.27.1 in ports is pretty
recent as shown by:
(cd /usr/ports/lang/rust; svn log | sed 60q; )

Yes.  Then I ran into another issue:  I figured you can't build rust
with 1GB of RAM.  I had to up to 4GB and then it cleanly compiled from
ports.
I was then able to run routinator.
Ciao!
--
Massimiliano Stucchi
MS16801-RIPE

In the end, apart from some FreeBSD-specific issues, everything is fine.


delay fast field type conversion to harvest phase

extract_typed_sort_value_opt is in the collect hot loop and very performance sensitive. Delay conversion from u64 to actual type to harvest phase.
The impact on the histogram query time seems a little odd, probably related to some inlining. The impact on other sort query times roughly what I'd expect.

A sad bit is that we compare things twice:
* the search_after part is acting as a first fence.

* the head of the top k collector is also acting as a fence.

In reality... there is only one fence of course. We could have had single set of sort values on the segment collector (current_score_fence) or something like that, initialized it on the search_after parameter, and then just used the regular collect_top_k logic.
What makes everything so difficult is the different treatment of ties ( the split_search_after_order thing).

True, I think we could maybe have specialized SegmentCollectors with Box<SegmentCollector>, to provide specialized implementations via generics for the different use cases. The calling performance overhead in combination with collect_block should be fine.

should we merge this PR and open a follow-up issue then?

should we merge this PR and open a follow-up issue then?

Let's fix the bug and then merge. People do rely on edge.


Mini 4: Slow "Reboot"

When I "Shut down" with iPadOS's normal shutdown mechanism, it takes a good while to power off, then reboot. It never actually shuts down. Is this intended behavior?

The tablet itself.

You should quit UTM (use the X/Power on the top left) before powering off your iPad.

Ok. I guess I didn't read the documentation fully. Thanks.

yes, this is what happens when you force quit utm while it's in the middle of the process running a vm, and if you start utm right after you force quitted it, force quit it again, and shut down your ipad right after, this happens


test-cases

chr19:45,769,272-45,771,195:
for collecting more split reads. many of the soft-clips are just under 20 bases. Sample: D14-1282 can just extract this portion of the genome and run the tool as there are not many inter-chromosomsals.

I don't remember what this was for, so closing for now.


Connection closed after succesfull getting information

Hello,
I'm trying to test Globalsat protocol and it seems that server closes connection right after getting correct report and sending ACK message to the device.
Can you tell me is it how it should work? Can you please point me where in the sources the connection is being handled ?

Server shouldn't close connection. Can I see log file?

2015-03-17 10:20:37  INFO: Starting server...
2015-03-17 10:20:37  INFO: Operating System name: Windows 7 version: 6.1 architecture: amd64
2015-03-17 10:20:37  INFO: Java Runtime name: Java HotSpot(TM) 64-Bit Server VM vendor: Oracle Corporation version: 25.40-b25
2015-03-17 10:20:37  INFO: Memory Limit heap: 1820mb non-heap: 0mb
2015-03-17 10:20:37  INFO: Version: 2.11-SNAPSHOT
2015-03-17 10:21:14 DEBUG: [1DEF43D8: 50434 <- <IP_ADDRESS>] - HEX: 4753722c3335373933383032303331303731302c2c342c30342c2c312c3137303331352c3036303635372c4530303030302e303030302c4e303030302e303030302c3134382c302e30302c302c302c302e302c31313939316d562a3663210d0a
2015-03-17 10:21:14 DEBUG: [1DEF43D8: 50434 -> <IP_ADDRESS>] - HEX: 416664434b0d
2015-03-17 10:21:14  WARN: For input string: "11991mV" - java.lang.NumberFormatException (null:-1)
2015-03-17 10:21:14  INFO: Closing connection by exception
2015-03-17 10:21:14  INFO: Closing connection by disconnect

ok now i see where is the problem. I think it shouldn't send ACK command if there is decode probkem...

You need to specify format of the messages in the config file if it's different from default:
format0 = "TSPRXAB27GHKLMnaicz*U!";
format1 = "SARY*U!";

I set the format exactly the same. The problem is 'mv' in string with battery level

Just to remove "mv" problem (GlobalsatProtocolDecoder):
            case 'N':
                 value =  value.replaceAll("[^0-9.]", "");
                extendedInfo.set("battery", Double.valueOf(value));
                break;

If the format is the same how do you get N in the message? Can you please provide format string that you used?

SORPZAB27GHKLMN*U!
I took it from some other post on Traccar. Later noticed that not all the parameters are described in TR-600 manual, and some of them return nothing. This also was with 'N' - it didn't returned anything but 'n' returns - battery power with 'mv' at the end. So I have just changed the setting in the device (changed N to n) without changing the traccar setting. Probably should just add another case to the GlobalsatProtocolDecoder... Here is part of the manual.
n - Capacity of battery that
presently supplied to
TR-600
if main battery is connected, n=voltage of
main battery (eg, 12300=12.3V)
If main battery is not connected, TR-600
would use backup batteries, that is
lead-acid battery or Li-battery.
if voltage of lead-acid backup battery >=
5V, n=voltage of lead-acid backup battery
(eg, 11800=11.8V)
If voltage of lead-acid battery is lower
than 5V or lead-acid battery is not
connected, TR-600 would be
power-supplied by Li-battery. n=capacity
of Li backup battery (eg, 80%)
As I understand it may return either voltage or percentage... My returns Voltage as I have main power supply only.

Fixed the issue.


Provide more details for a forced module or dependency

Instead of showing (forced) or Forced in the dependencyInsight report, with this PR we show:
Forced : module org:foo:1.0 or Forced : dependency org:foo:1.0.
It's not clear to me if this adds enough value, or if it's just noise.

I'm going to leave this out for now, since the value this adds is unclear, and there is additional overhead in generating/persisting all of those "reasons".


Python 3.12 package?

Are there plans to release a 3.12 python package?

Will be fixed later today.

Closing as ready on pypi: https://pypi.org/project/vineyard/#files
/cc @PaulRudin


Roll engine e9eae9a1af77..4f54a1dd9444 (3 commits)

https://github.com/flutter/engine/compare/e9eae9a1af77...4f54a1dd9444
git log e9eae9a1af77400d02c498f0ad943f2858845398..4f54a1dd944497bd1ec0f2acca22ff9fbd8b377a --no-merges --oneline
4f54a1dd9 Roll src/third_party/skia c1a9feb6f06e..5800f2e8a920 (2 commits) (flutter/engine#8022)
75e2b4702 Roll src/third_party/skia c6671be0ea75..c1a9feb6f06e (2 commits) (flutter/engine#8021)
b44a9305c Roll src/third_party/skia 1b9f889628e0..c6671be0ea75 (1 commits) (flutter/engine#8020)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (garyq@google.com), and stop
the roller if necessary.

Auto-roller completed checks. About to merge.


Removals: tuple enrichments, old ops, project delegation & deprecated

https://github.com/sbt/sbt/pull/2764
Deprecate the old operators <<=, <+=, and <++= https://github.com/sbt/sbt/pull/2716

Can we bring some of these decisions up to discussion?
I feel like tuple enrichments should not be removed. The semantics of .value are not the same because don't follow Scala-like evaluation semantics. Removing them pushes people to use the DSL API without a clear solution in mind.
The DSL API does not give users the freedom to choose how tasks should be evaluated (some times you want full control over task evaluation). This is not possible with the DSL API.

Can we bring some of these decisions up to discussion?

Yes.

I feel like tuple enrichments should not be removed. The semantics of .value are not the same because don't follow Scala-like evaluation semantics. Removing them pushes people to use the DSL API without a clear solution in mind.

In 2017, if we have to teach new users one style of DSL, it's the sbt 0.13 style { val k = key.value; val k2 = key2.value }, and I would really like to reduce the amount of DSL the user has to learn to master sbt. For migration purpose, I'm open to keeping tuple enrichment as a plugin. WDYT?

Oh man, looks like we were using a lot of deprecated APIs in the scripted test.
I think I might break this PR into 4 PRs for each atomic commit and deal with them independently.

In 2017, if we have to teach new users one style of DSL, it's the sbt 0.13 style { val k = key.value; val k2 = key2.value }, and I would really like to reduce the amount of DSL the user has to learn to master sbt. For migration purpose, I'm open to keeping tuple enrichment as a plugin. WDYT?

In my opinion, it deserves built-in support in sbt. I'm okay with sbt leaning more towards the 0.13 style, but we have to acknowledge its limitations. Power users or people that don't want to deal with DSL limitations, can always use the non DSL API, and I think it's fine to leave it as it is since the maintenance burden is negligible. If we put this API in an independent plugin, then we're leaving sbt users with only one way of doing stuff, but this way is incomplete and has fundamental problems (Scala evaluation semantics are not preserved).
Another reason why tuple enrichments should stay is because there is no way to provide automatic rewrites for them. If we do, we change semantics, since tasks won't be evaluated in parallel anymore.
Until a full solution is not worked out in the DSL API, I feel that we should leave tuple enrichments intact. These things can go away in the future when the DSL behaves like Scala code.

This way is incomplete and has fundamental problems (Scala evaluation semantics are not preserved).

The fact that tasks do not evaluate in sequential order is by design, not really a problem.
We use the DSL to implement DAG of happens-before relationship as documented in Task graph. If we evaluated tasks the same way we evaluate functions, then compile called n times in test would cause 5 compilation.

Power users or people that don't want to deal with DSL limitations, can always use the non DSL API, and I think it's fine to leave it as it is since the maintenance burden is negligible.

Power user can also use sequential tasks and dynamic tasks - http://www.scala-sbt.org/0.13/docs/Howto-Sequencing.html

These things can go away in the future when the DSL behaves like Scala code.

The tasks run in parallel, so it won't behave like Scala code. At the same time, tuple enrichment do not look anything like what's in the Standard library. (Cats has Cartesian operations with tuples)

Another reason why tuple enrichments should stay is because there is no way to provide automatic rewrites for them. If we do, we change semantics, since tasks won't be evaluated in parallel anymore.

I'm a bit confused here. In { val k = key.value; val k2 = key2.value }, key and key2 evaluate in parallel. Are you concerned about the rewrite of map or flatMap?

The fact that tasks do not evaluate in sequential order is by design, not really a problem.

It is a problem, sometimes you may want to control parallel task execution.
I would argue that this is not by design, since the non-DSL API allows you to have control over these things. The deduplication property applies only to the DSL, and I think it's good to have this distinction.

Power user can also use sequential tasks and dynamic tasks - http://www.scala-sbt.org/0.13/docs/Howto-Sequencing.html

Dynamic tasks are difficult to grasp and the consequence of a limited macro implementation, not a design decision. The fact that tasks in if will always be executed could be fixed with a good macro implementation, and still achieve the properties of inspect and deduplication (with some magic for the first one, though).
They are the reason why sbt users find sbt so difficult. We're embedding basic conditionals into a DSL construct that people have to learn to use and identify its need, while an if is a fundamental construct of any programming language.

The tasks run in parallel, so it won't behave like Scala code.

What I meant by this is fixing some macros to make control flow have an influence on task execution (as described in my previous example).

Are you concerned about the rewrite of map or flatMap?

Yes, I was explicitly talking about the rewrite of tuple enrichments into map or flatMap calls, which should be nested and therefore not parallel.
The issue is that the .value version also changes semantics since control flow inside bodies of tuple enrichments won't be respected anymore. This is why I meant there is no direct rewrite of tuple enrichments.

@jvican Let's continue the discussion in https://github.com/sbt/sbt/pull/3083


v2.4.1

Typo in ttnctl
More event metadata in MQTT

Coverage increased (+0.03%) to 73.7% when pulling f88fdb165ae5c5792e5dc12616d4d130f518b256 on develop into 08ad053cea8708f00866d66776d99917df79ace9 on master.


Don't output fields with unmet dependencies

I have come across some scenarios where a hidden field (one that has unmet dependencies) overrides another and found it very annoying. Perhaps it is by design but if not, this is an idea.

makes sense...
merged. :+1:


220811 Version - Fails with TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'

python3 misp_import.py --reports --actors

[[2022-08-12 16:23:12,268] (INFO)
<SNIP>
[2022-08-12 16:23:32,454] (INFO)
 ______  _______  ______ _____ __   _      _____ _______  _____   _____   ______ _______
 |_____] |______ |  ____   |   | \  |        |   |  |  | |_____] |     | |_____/    |
 |_____] |______ |_____| __|__ |  \_|      __|__ |  |  | |       |_____| |    \_    |

[2022-08-12 16:23:32,454] (INFO)

[2022-08-12 16:23:32,454] (INFO) Started getting adversaries from Crowdstrike Intel API and pushing them as events in MISP.
[2022-08-12 16:24:12,502] (ERROR) unsupported operand type(s) for +=: 'int' and 'NoneType'
Traceback (most recent call last):
  File "misp_import.py", line 213, in main
    importer.import_from_crowdstrike(int(settings["CrowdStrike"]["init_reports_days_before"]),
  File "/home/rx118r/src/crowdstrike/220812/MISP-tools-main/cs_misp_import/importer.py", line 143, in import_from_crowdstrike
    self.actors_importer.process_actors(actors_days_before, self.event_ids)
  File "/home/rx118r/src/crowdstrike/220812/MISP-tools-main/cs_misp_import/actors.py", line 114, in process_actors
    actors = self.intel_api_client.get_actors(start_get_events)
  File "/home/rx118r/src/crowdstrike/220812/MISP-tools-main/cs_misp_import/intel_client.py", line 119, in get_actors
    offset += resp_json.get('meta', {}).get('pagination', {}).get('limit')
TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'
unsupported operand type(s) for +=: 'int' and 'NoneType'
](url)

This appears as if you were returned an empty element in the pagination branch for actors.  Can you tell me what your actors import setting was set for?  I'm able to pull ~ 185 by setting my days before to 365.  (Will add a check for this in the code regardless, but would like to be able to reliably recreate the issue.)

External Connectivity from our dev lab was lost earlier today just as I as beginning to test the new code.  So I’m dead-in-the-water

From: Joshua Hiller @.>
Sent: Friday, August 12, 2022 3:36:30 PM
To: CrowdStrike/MISP-tools @.>
Cc: MARONEY, PATRICK @.>; Author @.>
Subject: Re: [CrowdStrike/MISP-tools] 220811 Version - Fails with TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType' (Issue #29)
This appears as if you were returned an empty element in the pagination branch for actors. Can you tell me what your actors import setting was set for? I'm able to pull ~ 185 by setting my days before to 365. (Will add a check for this in the code regardless, but would like to be able to reliably recreate the issue.)
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/CrowdStrike/MISP-tools/issues/29*issuecomment-1213452202__;Iw!!BhdT!hU6hEpi_8nDtpYNVlroswEFl3InZmyHW8gaF_nNyxQI1hy74fBgQtX8iz8uaZqJb6gabb_FDovCqdksCKd1ct_9ikmo$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAYSFYIYTWRQOHXARV5PKYDVY2RT5ANCNFSM56MIOQNA__;!!BhdT!hU6hEpi_8nDtpYNVlroswEFl3InZmyHW8gaF_nNyxQI1hy74fBgQtX8iz8uaZqJb6gabb_FDovCqdksCKd1c2fq2mH8$.
You are receiving this because you authored the thread.Message ID: @.***>

Boooooo!
Ok. Well we should definitely check the datatype received from the API before trying to use it in a calculation regardless, so I'll wrap this in a check and have you retest when connectivity is restored.  😀


Fire event when a singleton is resolved

fireResolvingCallbacks is not being called when:

I have already resolved a singleton (i.e.: it is only fired the first time)
I resolve an instance

Is it intended to work like this?

I think that is the intended behavior. At the least this would be a breaking change but I don't really think the current behavior is broken.


help in finetuning ai4bharat/indictrans2-indic-en-1B

model: ai4bharat/indictrans2-indic-en-1B
We tried finetuning the model and we are getting the following error:
RuntimeError: CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
Compile with TORCH_USE_CUDA_DSA to enable device-side assertions.
After setting CUDA_LAUNCH_BLOCKING=1, we are getting the following:
../aten/src/ATen/native/cuda/Indexing.cu:1292: indexSelectLargeIndex: block: [505,0,0], thread: [62,0,0] Assertion srcIndex < srcSelectDimSize failed.
../aten/src/ATen/native/cuda/Indexing.cu:1292: indexSelectLargeIndex: block: [505,0,0], thread: [63,0,0] Assertion srcIndex < srcSelectDimSize failed.
Any help appreciated.
P.S. We can do fairseq based finetuning but we are constrained by the fact that most of our data utility functions are already written for huggingface model. So thought of giving one final chance to see if we can try to figure out something, before we start putting efforts on moving to fairseq based model. Thanks in advance

Did you setup the environment correctly using install.sh.
Are you able to perform inference using the HF models ?
If the correct version of all the dependencies is installed, train_lora.sh should ideally work for you.

Closing due to inactivity.


chore(deps): update module github.com/stretchr/testify to v1.8.0

This PR contains the following updates:

Package
Type
Update
Change

github.com/stretchr/testify
require
minor
v1.7.5 -> v1.8.0

Release Notes

stretchr/testify
v1.8.0
Compare Source

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[$250] Remove MoneyRequestDescriptionPage.js and copy any changes since Nov 27 into IOURequestStepDescription.js

This is a part of https://github.com/Expensify/App/issues/29107. You can look at that issue for more context behind the cleanup process.
Problem
The app has two redundant components:
Old Component: MoneyRequestDescriptionPage
New Component IOURequestStepDescription
Solution
Following the examples (example 1, example 2), the Old Component needs to be completely removed from the codebase

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
Replace all uses of the Old Component with the New Component
Remove all traces of Old Component
Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")
Update any logic like isEditing to use the new action param from the route

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~019b522902265a76e3
Upwork Job ID:<PHONE_NUMBER>433705472
Last Price Increase: 2024-01-17

Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove MoneyRequestDescriptionPage.js and copy any changes since Nov 27 into IOURequestStepCategory.js
What is the root cause of that problem?
Refactoring
 of MoneyRequestDescriptionPage
What changes do you think we should make in order
We will be deleting the component here:

I would love to take this!

Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove MoneyRequestDescriptionPage.js and copy any changes since Nov 27 into IOURequestStepDescription.js
What is the root cause of that problem?
Remove deprecated component
What changes do you think we should make in order to solve the problem?

Remove MoneyRequestDescriptionPage component and all traces like

https://github.com/Expensify/App/blob/278d04e0689d6f012354d89ec19c640a1cd9dc54/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx#L99
https://github.com/Expensify/App/blob/278d04e0689d6f012354d89ec19c640a1cd9dc54/src/libs/Navigation/linkingConfig.ts#L432
https://github.com/Expensify/App/blob/a2f5bd5898eafc53801807c37929afaae8a23666/src/ROUTES.ts#L273-L276
https://github.com/Expensify/App/blob/a2f5bd5898eafc53801807c37929afaae8a23666/src/SCREENS.ts#L144
https://github.com/Expensify/App/blob/a2f5bd5898eafc53801807c37929afaae8a23666/src/libs/Navigation/types.ts#L204-L209

For new component IOURequestStepDescription

In here
https://github.com/Expensify/App/blob/a2f5bd5898eafc53801807c37929afaae8a23666/src/ROUTES.ts#L342-L346
We need to use the new :action param (instead of being hard-coded with "create") like we did here
https://github.com/Expensify/App/blob/a2f5bd5898eafc53801807c37929afaae8a23666/src/ROUTES.ts#L362-L366

Copy changes since 27 Nov to new components based on list commit here: https://github.com/Expensify/App/commits/main/src/pages/iou/MoneyRequestDescriptionPage.js

What alternative solutions did you explore? (Optional)

Borrowing the comments from @tgolen from other GHs related to this project:
Thank you, everyone, for the energy here, but please follow the contributor guidelines. If you are interested in this one, then please submit a proposal for the changes that are important here. After, it will go through a review process.

Discussing on slack https://expensify.slack.com/archives/C02NK2DQWUX/p1705538986244869

@DylanDylann - Tim shared some feedback in this 🧵 here:
https://expensify.slack.com/archives/C02NK2DQWUX/p1705538986244869
Please review and update your proposal if you are still interested in this one. Thanks!

Quoting from the above discussion (since it's internal) the points that should be taken into consideration

Where else do the routes need updated (when it's navigating to the edit view)
What (if any) logic needs updated for isEditing
setMoneyRequestDescription_temporaryForRefactor needs to be updated to have an isDraft param that's based on the new "action" route param
The Old Component not only needs to be removed, but it needs "replaced" with the New Component. This replacement isn't covered

@s77rt
https://github.com/Expensify/App/assets/141406735/1f23eb39-0a59-48a4-91c2-bd612ed1c670

Currently, MoneyRequestDescriptionPage (old component) is no longer used anywhere
We have another component EditRequestDescriptionPage to handle editing description

@DylanDylann We are looking to have all the IOU description logic being update from one place. EditRequestDescriptionPage should also get replaced with IOURequestStepDescription.
Currently setMoneyRequestDescription_temporaryForRefactor will only update the transaction draft values but that should be the case only when creating a new request. If we are editing the request we should update transaction itself for that we need to add a new param isDraft.
Can you please look into that further and update your proposal?
PS: We should also copy recent changes (if any) from EditRequestDescriptionPage to IOURequestStepDescription

We are looking to have all the IOU description logic being update from one place. EditRequestDescriptionPage should also get replaced with IOURequestStepDescription.

@s77rt It is a new point to me because I haven't seen it in the OP. So, we only use 1 component IOURequestStep... instead of EditRequest...Page and MoneyRequest...Page in all these IOU pages like Description, Distance, Merchant, Tag, Category, Date, ... And using action params from URL to detect if it is create or edit page
So I think we should update the OP in these issue for more clear
cc @tgolen

@s77rt Updated proposal

@KrAbhas Unfortunately your proposal is not complete.

@njmulsqb @AnshuAgarwal24 Please follow the proposal template

@DylanDylann Thanks for the update

We shouldn't remove EditRequestDescriptionPage because we still use it for Edit Split Flow

Why would that be a problem? Can't we use that same component for the split flow?

Proposal
Please re-state the problem that we are trying to solve in this issue.
This belongs to Wave 5 cleanup
Phase 2 is all about removing the original components and any of the duplicated efforts.
What is the root cause of that problem?
Replace MoneyRequest...Page (Create) and EditRequest...Page(edit) to IOURequestStep.... This new component will handle both the create and edit flow based on action param.
What changes do you think we should make in order to solve the problem?

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes

Transfer modifications made after November 27th to create new components, following the list of commits provided here: https://github.com/Expensify/App/commits/main/src/pages/iou/MoneyRequestDescriptionPage.js

Replace all uses of the Old Component with the New Component
Remove all traces of Old Component

There is no use of the component other than ModalStackNavigators. We can remove the MoneyRequestDescriptionPage component along with:
https://github.com/Expensify/App/blob/f56f1809846822f35d3bca8762a302086df1b774/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx#L99

The new component (STEP_DESCRIPTION) has it linkingConfig, SCREENS and ROUTES already configured, we must remove DESCRIPTION from the same places:
https://github.com/Expensify/App/blob/278d04e0689d6f012354d89ec19c640a1cd9dc54/src/libs/Navigation/linkingConfig.ts#L432
https://github.com/Expensify/App/blob/f56f1809846822f35d3bca8762a302086df1b774/src/SCREENS.ts#L144
https://github.com/Expensify/App/blob/f56f1809846822f35d3bca8762a302086df1b774/src/ROUTES.ts#L277-L280

Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")

Update https://github.com/Expensify/App/blob/0706c8c1a8914fa5ef4a7a05630e793ff691fd0a/src/libs/Navigation/types.ts#L204-L209
to    [SCREENS.MONEY_REQUEST.STEP_DESCRIPTION]: {
        iouType: string;
        transactionID: string;
        reportID: string;
        backTo: string;
    };

Update
https://github.com/Expensify/App/blob/0706c8c1a8914fa5ef4a7a05630e793ff691fd0a/src/ROUTES.ts#L346-L350
to    MONEY_REQUEST_STEP_DESCRIPTION: {
        route: ':action/:iouType/description/:transactionID/:reportID',
        getRoute: (action: ValueOf<typeof CONST.IOU.ACTION>, iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') =>
            getUrlWithBackToParam(`${action}/${iouType}/description/${transactionID}/${reportID}`, backTo),
},

Update
https://github.com/Expensify/App/blob/c3f7bccc1050988c6352ea63fa00bf327761587a/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L698
toNavigation.navigate(ROUTES.MONEY_REQUEST_STEP_DESCRIPTION.getRoute(CONST.IOU.ACTION.CREATE, iouType, transaction.transactionID, reportID, Navigation.getActiveRouteWithoutParams()));

Update any logic like isEditing to use the new action param from the route

We need to create new variable const isDraft = action === CONST.IOU.ACTION.CREATE (we will get action from route) in IOURequestStepDescription.js and pass it to setMoneyRequestDescription_temporaryForRefactor as a new param:
    route: {
        params: {action, transactionID, backTo},
    },
...
const isDraft = action === CONST.IOU.ACTION.CREATE;
...
    Navigation.goBack(isDraft && backTo || ROUTES.HOME);
...
const updateComment = (value) => {
    IOU.setMoneyRequestDescription_temporaryForRefactor(transactionID, value.moneyRequestComment, isDraft);
    navigateBack();
};

In setMoneyRequestDescription_temporaryForRefactor we will save the new description to draft_transaction if isDraft is true else we will save it to the transaction:
...
 * @param {Boolean} isDraft - Indicates whether it's a draft or not
 */
function setMoneyRequestDescription_temporaryForRefactor(transactionID, description, isDraft) {
    const key = isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION;
    Onyx.merge(`${key}${transactionID}`, { description });
}

Update
https://github.com/Expensify/App/blob/872eb17903f18f9a99d69abe6e45d6e736c70c77/src/components/ReportActionItem/MoneyRequestView.js#L289
to
Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DESCRIPTION.getRoute(CONST.IOU.ACTION.EDIT, CONST.IOU.TYPE.REQUEST, transaction.transactionID, report.reportID, Navigation.getActiveRouteWithoutParams()))

What alternative solutions did you explore? (Optional)
N/A

Proposal
Please re-state the problem that we are trying to solve in this issue.
This belongs to Wave 5 cleanup
Phase 2 is all about removing the original components and any of the duplicated efforts.
What is the root cause of that problem?
Replace MoneyRequest...Page (Create) and EditRequest...Page(edit) to IOURequestStep.... This new component will handle both the create and edit flow based on action param.
What changes do you think we should make in order to solve the problem?

Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes

Transfer modifications made after November 27th to create new components, following the list of commits provided here: https://github.com/Expensify/App/commits/main/src/pages/iou/MoneyRequestDescriptionPage.js

Replace all uses of the Old Component with the New Component
Remove all traces of Old Component

There is no use of the component other than ModalStackNavigators. We can remove the MoneyRequestDescriptionPage component along with:
https://github.com/Expensify/App/blob/f56f1809846822f35d3bca8762a302086df1b774/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx#L99

The new component (STEP_DESCRIPTION) has it linkingConfig, SCREENS and ROUTES already configured, we must remove DESCRIPTION from the same places:
https://github.com/Expensify/App/blob/278d04e0689d6f012354d89ec19c640a1cd9dc54/src/libs/Navigation/linkingConfig.ts#L432
https://github.com/Expensify/App/blob/f56f1809846822f35d3bca8762a302086df1b774/src/SCREENS.ts#L144
https://github.com/Expensify/App/blob/f56f1809846822f35d3bca8762a302086df1b774/src/ROUTES.ts#L277-L280

Be sure to update all routes and navigation to use the new :action param (instead of being hard-coded with "create")

Update https://github.com/Expensify/App/blob/0706c8c1a8914fa5ef4a7a05630e793ff691fd0a/src/libs/Navigation/types.ts#L204-L209
to    [SCREENS.MONEY_REQUEST.STEP_DESCRIPTION]: {
        iouType: string;
        transactionID: string;
        reportID: string;
        backTo: string;
    };

Update
https://github.com/Expensify/App/blob/0706c8c1a8914fa5ef4a7a05630e793ff691fd0a/src/ROUTES.ts#L346-L350
to    MONEY_REQUEST_STEP_DESCRIPTION: {
        route: ':action/:iouType/description/:transactionID/:reportID',
        getRoute: (action: ValueOf<typeof CONST.IOU.ACTION>, iouType: ValueOf<typeof CONST.IOU.TYPE>, transactionID: string, reportID: string, backTo = '') =>
            getUrlWithBackToParam(`${action}/${iouType}/description/${transactionID}/${reportID}`, backTo),
},

Update
https://github.com/Expensify/App/blob/c3f7bccc1050988c6352ea63fa00bf327761587a/src/components/MoneyTemporaryForRefactorRequestConfirmationList.js#L698
toNavigation.navigate(ROUTES.MONEY_REQUEST_STEP_DESCRIPTION.getRoute(CONST.IOU.ACTION.CREATE, iouType, transaction.transactionID, reportID, Navigation.getActiveRouteWithoutParams()));

Update any logic like isEditing to use the new action param from the route

In IOURequestStepDescription.js, create a new constant, isDraft based on the condition action === CONST.IOU.ACTION.CREATE obtained from the route. Pass this variable as a new parameter when calling setMoneyRequestDescription_temporaryForRefactor:
    route: {
        params: {action, transactionID, backTo},
    },
...
const isDraft = action === CONST.IOU.ACTION.CREATE;
...
    Navigation.goBack(isDraft && backTo || ROUTES.HOME);
...
const updateComment = (value) => {
    IOU.setMoneyRequestDescription_temporaryForRefactor(transactionID, value.moneyRequestComment, isDraft);
    navigateBack();
};

In setMoneyRequestDescription_temporaryForRefactor we will save the new description to draft_transaction if isDraft is true else we will save it to the transaction:
...
 * @param {Boolean} isDraft - Indicates whether it's a draft or not
 */
function setMoneyRequestDescription_temporaryForRefactor(transactionID, description, isDraft) {
    const key = isDraft ? ONYXKEYS.COLLECTION.TRANSACTION_DRAFT : ONYXKEYS.COLLECTION.TRANSACTION;
    Onyx.merge(`${key}${transactionID}`, { description });
}

Update
https://github.com/Expensify/App/blob/872eb17903f18f9a99d69abe6e45d6e736c70c77/src/components/ReportActionItem/MoneyRequestView.js#L289
to
Navigation.navigate(ROUTES.MONEY_REQUEST_STEP_DESCRIPTION.getRoute(CONST.IOU.ACTION.EDIT, CONST.IOU.TYPE.REQUEST, transaction.transactionID, report.reportID, Navigation.getActiveRouteWithoutParams()))

What alternative solutions did you explore? (Optional)
N/A

@s77rt and @DylanDylann, I was influenced by your discussion, both here and on slack, to do the part of replacing EditRequestDescriptionPage to IOURequestStepDescription

@s77rt Updated proposal to use new component for editing split flow

Proposal
Updated
The isEditing part I updated following discussions

@brunovjk Thanks for the proposal. I think your proposal is similar to @DylanDylann's. I don't see significant difference

@DylanDylann Thanks for the update. I think the proposal is clear enough to move into the PR.
🎀 👀 🎀 C+ reviewed
Link to proposal

@brunovjk Thanks for the proposal. I think your proposal is similar to @DylanDylann's. I don't see significant difference

Indeed, I updated my proposal after your discussion, is it ok right? I think that any proposal that didn't, would be incomplete. I appreciate the review :D

I agree with @s77rt's assessment. Let's go with @DylanDylann's proposal.

@s77rt The PR is ready for review

Awesome, we are moving forward here.

Weekly update: PR is in review

@DylanDylann and @s77rt - can we confirm if this issue caused this regression or if it's a false alarm? Thanks!

@alexpensify Yes I have commented on that issue https://github.com/Expensify/App/issues/36175#issuecomment-1935229980

My bad, I missed that comment. Thanks for flagging!

Checklist ^ does not apply here. This is a feature request (code refactor) and not a bug.

Flagging that I will be OOO on Monday, but will complete the payment process on Tuesday, February 20.

Payment summary is here: https://github.com/Expensify/App/issues/34609#issuecomment-1938720523
Everyone has been paid via Upwork.

@alexpensify Payment here should be $125 for the regression. I have refunded $125

Thanks for your honesty! I missed the regression notice and saw it after I hit send in Upwork. All actions are complete here, closing!

@s77rt - I believe that the regression was already addressed in another GH. Was today's notice an error? Thanks!

Yes the above notice is a false positive

Thanks!

Let's ignore it. It is only a reference


Fix #62 by adding configuration mode for downstream dependency analysis.

This PR is build upon GH-64. GH-64 is landed now.

This Resolves #62 by adding a configuration mode Strict.
With this PR, we can now configure the analysis mode which will impact inference decisions.
We have four different modes of analysis:

Local: Only considers the local effect of fixes.
Lower Bound: Considers the lower bounds of number of errors on downstream dependencies.
Upper Bound: Considers the upper bound of number of errors on downstream dependencies.
Strict: Guarantees that all errors in downstream due to changes in upstream will be resolved.

To set the above modes via command line, pass -am or --analysis-mode followed by one of the options below:

default
upper_bound
lower_bound
strict

Or set one of the values above In the .json config file at:
"DOWNSTREAM_DEPENDENCY_ANALYSIS":{
     "ANALYSIS_MODE": "mode"
}

Hi @lazaroclapp, this PR is ready for review however, it needs GH-64 to be landed first, will resolve your comments on that now :) Thank you.

@lazaroclapp I resolved all the comment, this is ready for another review. Thank you 🙂 .

Assuming I got the explanation right in the long comment above, this LGTM! 😁

Yes that is correct, I will land this now, thank you for the review 😄.


feat: Add API Key authentication support BIPS-21958

Add beyondtrust-bips-library~=1.0 which integrates the option to use API Key authentication.
Validates if API_KEY was provided to use this auth method instead of client credentials.
Some minor code format was applied.
Split dev and runtime requirements to avoid installing dev/testing dependencies on prod environments.
Add .gitignore rules mostly for Python code.
Update action.yml docs.

Hi @dtejadav
According to our call, I leave a few comments:

Create a few tests cases in https://github.com/BeyondTrust/secrets-safe-action-test/ repo to guarantee everything related to API key is working properly.
Check that all cases where your branch is involved should be are working.
Test Action using Dockerfile instead of Docker hub image.
Test flows: API key with certificate, API key with not certificate, credentials (secret id, cliente secret) with certificate, credentials (secret id, cliente secret) with not certificate.

@btfhernandez testing was done on this branch of the tests repo https://github.com/BeyondTrust/secrets-safe-action-test/commits/BIPS-21958-add-api-key-auth-tests/
Changes were added to secrets-safe-action-smoke-test file
The action is working as expected: https://github.com/BeyondTrust/secrets-safe-action-test/actions/runs/11601419332/job/32304101179
Output to confirm retrieved secrets can be found here in this variable: https://github.com/BeyondTrust/secrets-safe-action-test/settings/variables/actions/SECRET_CONTENT_SMOKE_TESTS


rust-analyzer: 2022-01-31 -> 2022-02-07

Motivation for this change
Update to the latest release
https://github.com/rust-analyzer/rust-analyzer/releases/tag/2022-02-07
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

closes #159739

:thinking:  I'd rather wait for tomorrow's release 2022-02-14.

thinking I'd rather wait for tomorrow's release 2022-02-14.

@oxalica sure, I've opened #160013


Improvement of the footer in service page

Footer is not proper it is shortened
Please Assign me this issue under GSSOC'24

@Pratiksha1661 go ahead.


Not working with Mudfish even with FastConnect disabled

Since the last update it isn't working for me anymore while using mudfish, I don't have FastConnect  enabled.
I tried by using mudfish's default client and also through proxifier.
After the update it only shows the ping as 0ms (which I'm aware it's what happens when FastConnect is enabled), it's also connecting to localhost (<IP_ADDRESS>)
Before the update it used to work normally while using mudfish through proxifier.

Closing after https://github.com/goatcorp/DalamudPlugins/pull/726


V 3.* fails with IdentityServer4 V4

The new version is out and this causes it all to fail...

I will look into what's new in v4 of IdServ and update it if it's smooth update, but from your comments it doesn't look like it's straightforward.

Hi, was updating to IdentityServer4 v4.0.0 and IdentityServer4.Contrib.RedisStore 3.1.1 today. I getting this error:
An error occurred while starting the application.
TypeLoadException: Method 'GetAllAsync' in type 'IdentityServer4.Contrib.RedisStore.Stores.PersistedGrantStore' from assembly 'IdentityServer4.Contrib.RedisStore, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
Microsoft.Extensions.DependencyInjection.IdentityServerRedisBuilderExtensions.AddOperationalStore(IIdentityServerBuilder builder, Action optionsBuilder)
TypeLoadException: Method 'GetAllAsync' in type 'IdentityServer4.Contrib.RedisStore.Stores.PersistedGrantStore' from assembly 'IdentityServer4.Contrib.RedisStore, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' does not have an implementation.
Do not know if its of any help or if its even related. Would just be nice to get a solution to it :)

V4 introduced a breaking change on the IPersistedGrantStore, and I've looked quickly at it (didn't have the time to look at it fully) and I'm afraid those changes to V4 will leave RedisOperationalStore unusable.
I will update here once I confirm my findings.

@AliBazzi  I don't think we can use redis as operational store going forward. V4 introduced PersistedGrantFilter. This will be used to query data like SQL where clause. Check InMemoryPersistedGrantStore for reference.

I've released an RC for the library that include modified implementation for the V4.
#39

changes merged, and v4 released.


the example "pyinotify/python2/examples/tutorial_threadednotifier.py" dose not work

It‘s my fault. If i want to test the tutorial and get the event message in console, i need to  comment the  following code:
wm.rm_watch(wdd.values())
.....
notifier.stop()


scroll into focus

Would it be possible to add a scroll into focus ability to the auto-focus directive?  Or is there a separate directive that can piggyback on this?

Interesting idea. I don't see why not. Although, in most of the browsers I've tested, the viewport will automatically scroll to a focused element. Is that not true in your case?

It depends.  With the grids that we are using, like UI-grid, we aren't seeing it scroll on focus.

It isn't a big deal.  We can find alternatives.

I am working on this one. Should be easy enough using Element.scrollIntoView (to get your grid to scroll) and possibly offsetTop to scroll the main viewport if the element is still not on screen (e.g. the grid itself is not currently on screen).
 I can't really think of a reasonable use case to have a scrollable view within a scrollable view within a scrollable view, but I'll chew on it for a bit.

Great.
On Tue, Jun 9, 2015 at 6:15 PM, Jonathan Hieb<EMAIL_ADDRESS>wrote:

I am working on this one. Should be easy enough using
Element.scrollIntoView (to get your grid to scroll) and possibly offsetTop
to scroll the main viewport if the element is still not on screen (e.g. the
grid itself is not currently on screen).
 I
can't really think of a reasonable use case to have a scrollable view
within a scrollable view within a scrollable view, but I'll chew on it for
a bit.
—
Reply to this email directly or view it on GitHub
https://github.com/hiebj/ng-focus-if/issues/4#issuecomment-110540535.

--
Até mais,
Brady Clifford
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

I'm gonna close this. I've been meaning to take a second look for a long time but haven't really had a chance or seen it reproduced in my own experience. I'm thinking another directive targeted for the specific use case is probably appropriate.


HIP - PoC Ripple Method

Thanks, Anthony!
Rendered view: https://github.com/helium/HIP/blob/c27ef2243e36c679158edadd3ef607aa61010695/xxxx-poc-ripple-method.md

Looks great, numbering and merging. This will be HIP14
Please direct future feedback and questions to the tracking issue: https://github.com/helium/HIP/issues/50