Dependency cleanup for OAI-PMH and Log4j (removing log4j v1 bridge & settings which used it)

References

Relates to @dependabot dependency updates to OAI, like #10007

Description
Minor dependency updates and code updates related to older dependencies in OAI-PMH

Removed parboiled-java dependency & updated the single Test that used it
Removed older Javax Injection code which still existed in OAI-PMH and updated one class that used it.
Removed Log4j v1 "bridge" which was used in OAI-PMH, along with code in other areas of DSpace which used this bridge to still use Log4j v1 syntax.

Instructions for Reviewers

Verify all tests still pass, including the new autodeployment tests (which also test the Handle Server is working correctly)
I've manually verified these changes still result in a working OAI-PMH & REST API, and manually verified the Handle Server is still working (after moving it's log4j configs to a new log4jv2 XML config file).

Merging, as I've thoroughly tested this dependency cleanup.  There are a few minimal code changes in here, but they have all been tested.  (I also asked on Slack if anyone objected to merging this, and no one did.)
This will likely need to be manually ported to 7.x, as not all changes in this PR apply to 7.x


BackEnd: Feature/new order

Description
This PR can create a new order
Please provide a short summary explaining what this PR is about.
Fixes #130
How to test?
localhost:3000/api/documentation
post a order and check in your DB
Please provide a short summary how your changes can be tested?
Checklist

[X] I have performed a self-review of my own code
[X] I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
[X] I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
[X] I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
[X] This PR is ready to be merged and not breaking any other functionality

Hi Milton. Yes, we understand your concerns - will read more about why the current syntax isn't safe and we'll try to get back to this problem in the future to fix it. Thank you for your great advice and support in this.


ANDROID_DISTANCE_FILTER_PROVIDER only got one location,must switch off and on geolocation to be normal

Your Environment

Plugin version:2.2.0.alfa.6

Platform: Android

OS version:5.1

Device manufacturer and model:

Cordova version (cordova -v):6.3

Cordova platform version (cordova platform ls):android 5.2.1

Plugin configuration options: {
'desiredAccuracy': 100,
'stationaryRadius': 1,
'distanceFilter': 1,
        'locationProvider':window['backgroundGeolocation']['provider']['ANDROID_DISTANCE_FILTER_PROVIDER'],
        'interval':1500,
        'fastestInterval':300,
        'activitiesInterval':500,
        'stopOnStillActivity':false,
        'debug': true, // <-- enable this hear sounds for background-geolocation life-cycle.
        'stopOnTerminate': true // <-- enable this to clear background location settings when the app terminates
    }

Link to your project:

Context

Expected Behavior

Actual Behavior

only got once location callback
Possible Fix

must switch off and then switch on geolocation ,then location callback become normal
Steps to Reproduce

Context

what do you mean switch off and then switch on geolocation? Do you mean that the user has to do that themselves on their phone? Thank you!

yes.i found locationManager.requestSingleUpdate doesn't return any result,it is the reason.thanks.

Notice: this issue has been closed because it has been reported for branch 2.x or later. It could be already fixed in v3 or is not relevant anymore. You may reopen this issue if it has been closed in error.


Lint our JS with a generous eslint

Use the most common linter recommendation, as it doesn't
require a lot of changes in our code
Run eslint via GitHub actions for each PR & push
Fix reported problems
Add note to CONTRIBUTING.md

Ref https://github.com/jupyterhub/binderhub/issues/1373

This includes https://github.com/jupyterhub/binderhub/pull/1376

Thanks a lot, @consideRatio!


MAT-6222: Test Case List table sorting

MADiE PR
Jira Ticket: MAT-6222
(Optional) Related Tickets:
Summary
All Submissions

[ ] This PR has the JIRA linked.
[ ] Required tests are included
[ ] No extemporaneous files are included (i.e Complied files or testing results)
[ ] This PR is into the correct branch.
[ ] All Documentation as needed for this PR is Complete (or noted in a TODO or other Ticket)
[ ] Any breaking changes or failing automation are noted by placing a comment on this PR.

DevSecOps
If there is a question if this PR has a security or infrastructure impact, please contact the Security or DevOps engineer assigned to this project to discuss it further.

[ ] This PR has NO significant security impact (i.e Changing auth methods, Adding a new user type, Adding a required but vulnerable package)
[ ] All CDN/Web dependencies are hosted internally (i.e MADiE-Root Repo)

Reviewers
By Approving this PR you are attesting to the following:

Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
The tests appropriately test the new code, including edge cases
If you have any concerns they are brought up either to the developer assigned, security engineer, or leads

Waiting to merge. Need to test Status Sorting but elm translator is broken on local


duplicated elements on copy

i think it will be cool if we can copy element from left to right, without duplicate him to right side,
if there is present this element , then not copy it to the right

This already exists, set copy to a function.


Add uncaught exception loggers to thread factories.

The stream processor executors can eat some exceptions, especially around bad stream serdes.
Filing as a bug, as this has operational impact.

fixed in https://github.com/zalando-incubator/nakadi-java/pull/91


HfApi.model_info(revision=) does not resolve hash prefix

import huggingface_hub

huggingface_hub.__version__

'0.0.13'

from huggingface_hub import snapshot_download, HfApi
api = HfApi()

# success
api.model_info("flax-community/ft5-cnn-dm")

# success
api.model_info(
    "flax-community/ft5-cnn-dm", revision="859350e337148108b32b6f9eef45d0d4c6b668a9"
)

# fail
api.model_info("flax-community/ft5-cnn-dm",revision='859350e')

Error message:
HTTPError: 404 Client Error: Not Found for url: https://huggingface.co/api/models/flax-community/ft5-cnn-dm/revision/859350e

This is what snapshot_download calls internally, so snapshot_download would fail if only hash prefix is provided.

Yep, we don't currently have this capability. If it is requested widely we will consider building it (it's on the server side so in the realm of @Pierrci )
Thanks!

Hi @julien-c,
I believe this issue can be closed?
When I try to replicate OP's problem, there is no 404 HTTPError anymore for https://huggingface.co/api/models/flax-community/ft5-cnn-dm/revision/859350e.
The server side fix must have been implemented.

When I try to replicate OP's problem, there is no 404 HTTPError anymore

I confirm that I have been able to reproduce it and that the "problem" has been fixed server-side. Thanks for trying it out @martinbrose :)

yes thanks for checking @martinbrose 🔥


[docs][TextField][a11y] Dynamically modify the value of the aria-label on the eye button (password field)

Steps to reproduce
Link to live example: (required)
Steps:

Go to https://v5.mui.com/material-ui/react-text-field/#input-adornments
Click on the eye button
The aria-label has the same value, although the icon changes (gives indication of sighted users about the two different states)

Current behavior
The same aria-label value is the same.
Expected behavior
In the eye password button, modify dynamically the value of the aria-label on click: aria-label=”display the password” / ”hide the password” instead of using "toggle password visibility" as it does not give indication of the current state.
Context
No response
Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: textfield, demo

Yes exactly. Please open a PR and tag me for review :)

Fixing this looks like a step backward. If I'm blind, this action is irrelevant to me, I can't use the feature. If I'm not blind, then I can see the difference, I don't need specific labels => best to not fix this, to keep the translation work simpler?

I suspect the right move is to remove this button from the tab sequence, so it's unrecheable to screen readers.

How would a blind user then ever be able to read the password (or have it be read by the screen reader?). If I am a sighted user this input allows me to get the password (by reading it), why would a non-sighted user not have that option?

How would a blind user then ever be able to read the password (or have it be read by the screen reader?)

@mnajdova If screen reader can't read type="password" but can read type="text" field, then 👍, it makes sense.

Yep, it's not the case, e.g. focusing on a password text field, Voice over reads the following:

while if it is type="text" it reads the text itself:

@mnajdova Alright, this change makes a lot of sense then 👍.


feature: add relevant hints of RocketMQ starter

Describe what this PR does / why we need it
Using RuntimeHintsRegistrar to add relevant hints of spring-cloud-starter-stream-rocketmq.
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

LGTM


revert the grpc-js related type change in src/pubsub.ts

This change will be merged in #590 to src/pubsub.ts:
  // TODO: sslCreds is supposed to be of type ChannelCredentials.
  // Using any until google-gax changes to @grpc/grpc-js by default.
  // tslint:disable-next-line no-any
  sslCreds?: any;

Please don't forget to rollback when new gax with grpc-js releases.

The PR that would have caused this ended up getting closed, so I think this is actually a non-issue now.


Support regexp_substr function

What problem does this PR solve?
Issue Number: ref #6115
Problem Summary:
What is changed and how it works?
Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/cc @windtalker @gengliqi

/cc @SeaRise

/cc @XuHuaiyu

/run-all-tests

/run-all-tests

/merge


Consider adding architecture specific system flakes

E.g. x86_64, which contains x86_64-darwin and x86_64-linux

Similar request: #11
More generally, these requests are about adding subsets (empty subset in my case) of the systems universe.


AcFormat

Add link to AcFormat

Can you copy the URL to the page where you would like the AcFormat linked?

@ronmcca Please open a new issue with the correct documentation link. Thanks<EMAIL_ADDRESS>


Uncertainty IoU & CV: Invalid value encountered in value_scalars

How to reproduce:

Run cmd_test with uncertainty active

See:

@charleygros I think this was fixed since I'm not encountering it when using uncertainty?

Oh? I am scared I did not
If I remember well, it happens when empty sample?


Test framework, creating platforms and brokers: allow custom headers

Issue Template
Step 1: Is this issue for here?
Yes
Step 2: Describe the problem (very short text description):
I'm trying to extend test framework to allow custom headers in the requests for creating platforms and brokers.

Closed with #263


boards.txt references nonexistent file Caterina-Lora32u4.hex

The boards.txt file references a non-existent file.  Is there a way to acquire it, or is it unnecessary?
When I try to upload a sketch, I see this error message:
Bootloader file specified but missing: /home/user/arduino/arduino-1.8.5/hardware/BSFrance-avr/avr/bootloaders/caterina/Caterina-Lora32u4.hex

boards.txt:
https://github.com/BSFrance/BSFrance-avr/blob/master/avr/boards.txt#L10
#LoRA32u4 Configuration
lora32u4.name=LoRa32u4 (433MHz)
lora32u4.bootloader.low_fuses=0xff
lora32u4.bootloader.high_fuses=0xd8
lora32u4.bootloader.extended_fuses=0xcb
lora32u4.bootloader.file=caterina/Caterina-Lora32u4.hex
lora32u4.bootloader.unlock_bits=0x3F
lora32u4.bootloader.lock_bits=0x2F
lora32u4.bootloader.tool=arduino:avrdude

Edit 1
Using Arduino IDE 1.5.8 on Ubuntu 16.04 x64

I am facing the same issue. I am using a LoRa32u4 II board, Arduino IDE 1.8.6, on a Windows 10 machine. The strangest thing is that it (the example programs with the BSFrance LoRa libraries) were working until a few days ago. This morning it just stopped working. Between then and now the only thing I have done is install two extra libraries (OneWire and DallasTemperature) for reading a particular sensor using another Ardunio Uno board.

I was able to program the board successfully (I ignore the warning).  It's only a problem when you try to program (upload) the bootloader (?).
IIRC other people have observed that you can treat these as an Adafruit Feather 32u4 board, though I've not tried it.  Interestingly, the code contains references to Adafruit product:
https://github.com/BSFrance/BSFrance-avr/blob/cfdd9b4d8ea6b2ff088cc336d4a4231d767c35e0/avr/boards.txt#L54:L56

I found the .hex file in http://bsfrance.fr/documentation/11355_LORA32U4II/BSFrance.zip (link on product page https://bsfrance.fr/lora-long-range/1345-LoRa32u4-II-Lora-LiPo-Atmega32u4-SX1276-HPD13-868MHZ-EU-Antenna.html)

Does anyone have any alternate locations to obtain this BSFrance.zip file? I have been trying the bsfrance.fr site for two weeks now and it throws a 503 bad gateway error.

Thanks a lot!!!!

Hello all,
I have a copy of hex files for both Lora32u4 on my PC, please find the archive,
lora32u4-bootloaders.zip

I found the .hex file in http://bsfrance.fr/documentation/11355_LORA32U4II/BSFrance.zip (link on product page https://bsfrance.fr/lora-long-range/1345-LoRa32u4-II-Lora-LiPo-Atmega32u4-SX1276-HPD13-868MHZ-EU-Antenna.html)

FWIW, archived on archive.org:
https://web.archive.org/web/20190316171101/https://bsfrance.fr/lora-long-range/1345-LoRa32u4-II-Lora-LiPo-Atmega32u4-SX1276-HPD13-868MHZ-EU-Antenna.html
The BSFrance.zip file isn't on archive.org as far as I can tell.

I'm using lora320u4 I copied the lora boards into the boards in the file arduino/hardware/arduino/avr
but when compiling I got this error "loading package arduino: loading platform release: Error reading file (C:\Users\adnen\Desktop\arduino\hardware\arduino\avr\boards.txt:0): Invalid line format, should be 'key=value''
can anyone please help


Prepare for next beta

Motivation
TODO:

[ ] Rename readmes names to lowercase with dashes => as a best practice (describe somewhere probably /docs/README.md)
[x] Package upgrade
[x] Take a look at the CI warnings https://github.com/kontent-ai/delivery-sdk-net/actions/runs/2753457623

Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[ ] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
If manual testing is required, what are the steps?

Codecov Report

Merging #344 (ec30e43) into master (de7f684) will decrease coverage by 4.96%.
The diff coverage is n/a.

:exclamation: Current head ec30e43 differs from pull request most recent head 2a8625e. Consider uploading reports for the commit 2a8625e to get more accurate results

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   93.62%   88.66%   -4.97%
==========================================
  Files         120      120
  Lines        2589     2585       -4
  Branches      321      318       -3
==========================================
- Hits         2424     2292     -132
- Misses        157      166       +9
- Partials        8      127     +119

Impacted Files
Coverage Δ

...ent.Ai.Urls/Delivery/DeliveryEndpointUrlBuilder.cs
93.75% <ø> (-6.25%)
:arrow_down:

Kontent.Ai.Delivery/DeliveryException.cs
42.85% <0.00%> (-28.58%)
:arrow_down:

Kontent.Ai.Delivery.Caching/StringHelpers.cs
83.33% <0.00%> (-16.67%)
:arrow_down:

Kontent.Ai.Delivery.Caching/CacheHelpers.cs
81.53% <0.00%> (-14.62%)
:arrow_down:

...ent.Ai.Delivery.Caching/DistributedCacheManager.cs
61.36% <0.00%> (-13.64%)
:arrow_down:

....Delivery/ContentItems/RichTextContentConverter.cs
76.19% <0.00%> (-11.91%)
:arrow_down:

...livery/Extensions/HttpResponseHeadersExtensions.cs
88.88% <0.00%> (-11.12%)
:arrow_down:

Kontent.Ai.Delivery.Rx/DeliveryObservableProxy.cs
78.94% <0.00%> (-10.53%)
:arrow_down:

...y/ContentItems/ContentLinks/ContentLinkResolver.cs
73.46% <0.00%> (-10.21%)
:arrow_down:

Kontent.Ai.Delivery.Caching/DeliveryClientCache.cs
85.50% <0.00%> (-10.15%)
:arrow_down:

... and 18 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

If the PR is OK, please merge it and release a new beta.


Textures

was going to add fog but it uses URP and i was told it would break stuff in the project so it's not there but maybe the skybox will help compensate :'))

Pushed slighlty lighter and browner floor mat + brighter lighting in test scene


[main] Upgrade to latest dependencies

update deps for release -psschwei
/cc we don't use Prow
/assign we don't use Prow
Produced by: knative-sandbox/knobots/actions/update-deps
Details:
bumping knative.dev/eventing 0310bf9...0310bf9:

Required as Releasability is failing
Although it doesn't have the same changes to go.mod as running
./hack/update-deps.sh --upgrade --release 0.29

and
git diff go.mod
diff --git a/go.mod b/go.mod
index 98b9f188..5613f474 100644
--- a/go.mod
+++ b/go.mod
@@ -29,9 +29,9 @@ require (
        k8s.io/client-go v0.22.5
        k8s.io/code-generator v0.22.5
        k8s.io/kube-openapi v0.0.0-20211109043538-20434351676c
-       knative.dev/eventing v0.28.1-0.20220125100448-0310bf9c1c23
-       knative.dev/hack v0.0.0-20220118141833-9b2ed8471e30
-       knative.dev/pkg v0.0.0-20220118160532-77555ea48cd4
+       knative.dev/eventing v0.29.0
+       knative.dev/hack v0.0.0-20220127163346-cfb3eb8fc124
+       knative.dev/pkg v0.0.0-20220126214246-d7b329c36019
 )

/lgtm


icsnpp-enip package build fails in Zeek v6.0.0 release candidate

Installing "https://github.com/cisagov/icsnpp-enip"
error: incomplete installation, the follow packages failed to be installed:
  https://github.com/cisagov/icsnpp-enip (main)
Failed installing "https://github.com/cisagov/icsnpp-enip": package build_command failed, see log in /opt/zeek-rc/var/lib/zkg/logs/icsnpp-enip-build.log

> cat /opt/zeek-rc/var/lib/zkg/logs/icsnpp-enip-build.log
=== STDERR ===
Usage: zeek-config [OPTIONS]

Basic options:

  --build_type          Zeek build type as per cmake, lower case (e.g. 'relwithdebinfo')
  --prefix              Toplevel Zeek distribution installation directory
  --version             Zeek version number
  --zeek_dist           Toplevel directory of source tree the distribution built from
  --zeekpath            ZEEKPATH environment variable paths for this distribution

Specific directories in the Zeek distribution:

  --btest_tools_dir     Zeek-related BTest tooling
  --cmake_dir           Zeek's cmake modules
  --config_dir          Configuration files for cluster topology, zkg, etc
  --include_dir         C/C++ header folders for Zeek and related components, colon-separated
  --lib_dir             Toplevel folder for shared libraries, Python packages, etc
  --plugin_dir          Native-code Zeek plugins
  --python_dir          Python packages (Broker, ZeekControl, zkg, etc)
  --script_dir          Toplevel folder for Zeek scripts
  --site_dir            Site-specific Zeek scripts

Toplevel installation directories for third-party components:

  --binpac_root         BinPAC compiler
  --broker_root         Broker communication framework

Feature tests:

  --have-spicy-analyzers  Prints 'yes' if built-in Spicy analyzers are available; exit code reflects result

CMake Warning at /opt/zeek-rc/share/zeek/cmake/ZeekPlugin.cmake:141 (message):
  Package requires CMake 3.0 which is less than Zeek's requirement (3.15.0).
  This will likely cause build failures and should be fixed.
Call Stack (most recent call first):
  CMakeLists.txt:5 (include)

CMake Warning (dev) at /opt/zeek-rc/share/zeek/cmake/ZeekPlugin.cmake:120 (if):
  Policy CMP0057 is not set: Support new IN_LIST if() operator.  Run "cmake
  --help-policy CMP0057" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  IN_LIST will be interpreted as an operator when the policy is set to NEW.
  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  /opt/zeek-rc/share/zeek/cmake/ZeekPluginDynamic.cmake:77 (zeek_next_pac_block)
  /opt/zeek-rc/share/zeek/cmake/ZeekPlugin.cmake:196 (zeek_add_dynamic_plugin)
  /opt/zeek-rc/share/zeek/cmake/ZeekPluginCommon.cmake:68 (zeek_add_plugin)
  CMakeLists.txt:12 (zeek_plugin_end)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error at /opt/zeek-rc/share/zeek/cmake/ZeekPlugin.cmake:120 (if):
  if given arguments:

    "arg" "IN_LIST" "separators"

  Unknown arguments specified
Call Stack (most recent call first):
  /opt/zeek-rc/share/zeek/cmake/ZeekPluginDynamic.cmake:77 (zeek_next_pac_block)
  /opt/zeek-rc/share/zeek/cmake/ZeekPlugin.cmake:196 (zeek_add_dynamic_plugin)
  /opt/zeek-rc/share/zeek/cmake/ZeekPluginCommon.cmake:68 (zeek_add_plugin)
  CMakeLists.txt:12 (zeek_plugin_end)

=== STDOUT ===
Build Directory        : build
Zeek Source Directory   :
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
-- Found Threads: TRUE
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found version "3.0.9")
-- Found BinPAC: /opt/zeek-rc/bin/binpac
-- Found BifCl at /opt/zeek-rc/bin/bifcl
-- Setting plugin CMAKE_BUILD_TYPE to Release
-- Configuring incomplete, errors occurred!
See also "/opt/zeek-rc/var/lib/zkg/clones/package/icsnpp-enip/build/CMakeFiles/CMakeOutput.log".

Fixed by cisagov/icsnpp-enip@82b2a71de77ca0756abcf837fec70ddbc4e5e4d9


updated data url and conform

Beautiful :)
On Wed, Apr 19, 2017 at 8:48 AM, OpenAddresses Bot<EMAIL_ADDRESS>
wrote:

[image: Preview]
https://camo.githubusercontent.com/9eb677343d02201496de4cc8989a9588c9a9ce6b/68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f646174612e6f70656e6164647265737365732e696f2f72756e732f3138303133362f707265766965772e706e67
More: https://results.openaddresses.io/jobs/5c9fb08c-5f00-4c9e-
92c0-c15804494fe6
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openaddresses/openaddresses/pull/2875#issuecomment-295317942,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0EO_jcGKpJdo8bRK0oy3PQZEStGgEjks5rxiywgaJpZM4NB2vE
.

This ran with short-lived machine code 4.10.0 with a slippymap bug; retry with newer to see if https://github.com/openaddresses/machine/issues/610 is a problem:
Re-run this please.

Thanks, @migurski !

Yup, sorry this happened!
By the way: the double previews over the past few days are because I'm quietly testing a Docker-driven worker with a duplicate task queue.


Update the operating environment (refs #4025)

Task（タスク） #4025
OpenPNE3_Setup_Guide.txt の動作環境を更新する
https://redmine.openpne.jp/issues/4025

Since the target version has been changed, we will terminate the pull request.


MF-164 - Update make file in order to support new services

Update make file in order to support users and clients services.
Update mainflux version to 0.3.0.
Signed-off-by: Aleksandar Novakovic<EMAIL_ADDRESS>

Codecov Report

Merging #255 into MF-164 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           MF-164     #255   +/-   ##
=======================================
  Coverage   91.86%   91.86%
=======================================
  Files           8        8
  Lines         123      123
=======================================
  Hits          113      113
  Misses          9        9
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8222e0...bdaceab. Read the comment docs.


Support to access kubernetes head pod from outside network

@jerrychenhf I have testd this pr, please help to merge.


Add ability to collapse table columns if there is overflow

closes #730

The columns get collapsed, but when the screen gets larger again they don't show up again. This could happen when user turns his phone in landscape position.

The problem with the current solution is that it relies on the table being rendered in order to detect if there is overflow. If we continue to check for overflow after a column has been collapsed it will create an infinite loop with the column being removed and added continuously. So for this reason once a column has been removed it cannot be added back.
Another solution would be to calculate the column width without rendering or explicitly set column width, though I think both of these solutions are much more complex.
We could also provide breakpoints with each column to indicate the screen size they should be displayed at, though I think in this case it will have the same effect as the current solution, as a landscape device probably won't hit the sm breakpoint.
Overall, I think that the scenario you mentioned isn't that detrimental to the user as the collapsed columns are fairly unimportant so I think the current solution is appropriate. Let me know if you think there are any other options we should consider.


[Question]: Fast battery drain on Eufy C220/T8506 Lock

Ask your question
So I installed a new C220 lock late Nov 2023 and once configured it showed up in my Home Assistant's eufy-security-ws integration despite lock/unlock functionalities not supported. And then I noticed its battery lasted about just 15 days even though usage was light and batteries were brand new, while the product description says it can last up to four months.
After three occurrences of such 15-day-battery-drain I came across a webpage from Eufy suggesting third-party integrations may affect battery life and thus disabled eufy-security-ws add-on and integration in my HA to see. It was on Jan 11. It's been 42 days now and batteries are still running very strong.
Since the only difference from before was that eufy-security-ws addon and integrations were disabled, I suspect it caused the battery drain, and wonder if anyone has thoughts, fixes, or workarounds.
Thanks!

This device is not yet supported. It will be supported in the next release (1.8.0).
Furthermore, in the next release of eufy-security-client (3.0.0; which will be used by this project in version 1.8.0) the problem of battery drain for unsupported devices has also been fixed.


Image portainer/portainer:alpine not available in DockerHub

Image portainer/portainer:alpine mentioned in #3730 doesn't exists. However portainer/portainer:1.24.0-alpine works correctly.

Yes, this one is missing we'll update the Dockerhub repo.

portainer/portainer:alpine is now available.


Always set discountRate to 0 when discountRate is/should be disabled

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #2894   👈

This comment was auto-generated by Graphite.

⏳ This pull request is set to merge as part of a Graphite merge job
Stack job ID: WfgPkX41152ORqMqzhiw.
See details on graphite.dev


how can i delete task..?

Version (e.g. 1.0, dev-master):
PHP version:
Microsoft Exchange version:
Description of problem:
when i try to delete my ews- exchange task following exception thrown.
Example request:
$client = new Client($host, $username, $password, $version);
$client->setCurlOptions(array(CURLOPT_SSL_VERIFYPEER => false));
$request = new DeleteItemType();
$request->AffectedTaskOccurrences = AffectedTaskOccurrencesType::SPECIFIED;
$request->ItemIds->ItemId = new ItemIdType();
$request->ItemIds->ItemId->Id= $_GET['delete'];
$response = $client->DeleteItem($request);
print_r($response);

Example response:
<b>Fatal error</b>:  Uncaught SoapFault exception: [a:ErrorSchemaValidation] The request failed schema validation: The required attribute 'DeleteType' is missing. in C:\xampp\htdocs\sync\src\Client.php:1631
Stack trace:
#0 C:\xampp\htdocs\sync\src\Client.php(1631): SoapClient->__call('DeleteItem', Array)
#1 C:\xampp\htdocs\sync\src\Client.php(1631): jamesiarmes\PhpNtlm\SoapClient->DeleteItem(Object(jamesiarmes\PhpEws\Request\DeleteItemType))
#2 C:\xampp\htdocs\sync\src\Client.php(547): jamesiarmes\PhpEws\Client->makeRequest('DeleteItem', Object(jamesiarmes\PhpEws\Request\DeleteItemType))
#3 C:\xampp\htdocs\sync\task_exc.php(66): jamesiarmes\PhpEws\Client->DeleteItem(Object(jamesiarmes\PhpEws\Request\DeleteItemType))
#4 {main}

Additional details:

Finally i got find solution.
$version = Client::VERSION_2010_SP2;
$client = new Client($host, $username, $password, $version);
$client->setCurlOptions(array(CURLOPT_SSL_VERIFYPEER => false));
$request = new DeleteItemType();
$request->AffectedTaskOccurrences = AffectedTaskOccurrencesType::ALL;
$request->DeleteType = DisposalType::HARD_DELETE;
$request->ItemIds->ItemId = new ItemIdType();
$request->ItemIds->ItemId->Id= $_GET['delete'];
$response = $client->DeleteItem($request);


Feature Request - Blank Story Arcs

From<EMAIL_ADDRESS>on June 21, 2013 21:15:41
When Comicvine has no data for Story Arc, can we have an option to put the story title there?
Thanks!
Original issue: http://code.google.com/p/comictagger/issues/detail?id=27

From<EMAIL_ADDRESS>on July 08, 2013 18:58:21
This could be done, but are you sure you'd want it?  I can see in a lot of cases having "Story Arc Blahblah, Part 1" and "Story Arc Blahblah, Part 2"  Just curious what the use case is.
I don't mind adding this, but hate to do stuff that might be useful.
Labels: -Type-Defect Type-Enhancement

From<EMAIL_ADDRESS>on July 09, 2013 04:32:20
Good point. The "problem" is that in CBR i prefer to view stories by arc - especially with the ipad app. In cases where comicvine has no arc, that is problematic. Maybe there is a better way to do that...


Get-PnPNavigationNode always returns IsVisible property as true

Discussed in https://github.com/pnp/powershell/discussions/4482

Originally posted by GregBirbrayer October 27, 2024
Get-PnPNavigationNode returns all the navigation nodes, however if the navigation link is hidden (sp onPrem) it still returns the IsHidden prop as $true.
This is causing the confusion when migrating the quick launch menu to sp online adding up extra nav nodes.

Which version of PnP PowerShell are you using ? Because the current version supports only SharePoint Online.


Allow changing the options for a specific toast

Eg. I'd like one of my toasts to only be closed on a click, but the others to be closed automatically. This doesn't seem easily possible at the moment.

You can pass options at creation:
      toastr.warning(
        "OH NOES",
        "Important Notice:",
        {
          "closeButton": true,
          "positionClass": "toast-top-center",
          "timeOut": "0",
          "extendedTimeOut": "0",
        })

@jemminger  - correct, thanks.


[FLINK-2106] [runtime] add Left-, Right- and Full Outer Join drivers

This PR includes the implementation of 3 drivers for the specific outer joins and adapts the DriverStrategy for the merge based outer joins.
To make the outer join operators implemented in ticket FLINK-2105 visible to the Java and Scala API, we have started with the integration of the merge based outer join operators bottom up. To reduce duplicated code we implemented an AbstractOuterJoinDriver which is responsible for most parts of the drivers setup and running the operators. The specific outer join driver implementations (LeftOuterJoinDriver, RightOuterJoinDriver, FullOuterJoinDriver) set the corresponding Outer Join Iterators based on the ExecutionConfig. Therefore, we had to adapt the DriverStrategy adding three additional enum fields (LEFT_OUTER_MERGE, RIGHT_OUTER_MERGE, FULL_OUTER_MERGE).
Currently, we only support the outer join on a merged based strategy, but hash based will follow (FLINK-2107).
Furthermore, DriverStrategy.MERGE has been renamed to DriverStrategy.INNER_MERGE as requested by @fhueske.
Next steps of this issue will be the optimizer and Java/Scala API parts.

Hi, Thanks for your contribution. I'll review this and leave comments.

Thanks for your contribution @r-pogalz. Could you please add some more details about the implementation to the PR description.

Really good work @r-pogalz. I had only some minor comments concerning style and test cases.
I like your approach to split the implementation of FLINK-687 into multiple parts. This makes it far easier to review. Concerning the description of FLINK-2106, you haven't integrated the outer sort merge join into the optimizer and the API, yet. I guess this will happen as a next step. Maybe you can update the description of FLINK-2106 accordingly.
Other than that, the PR looks good to me :-)

Hi @tillrohrmann, thanks for your review and comments. I will work through it soon.
Regarding the ticket FLINK-2106, @fhueske suggested us to create multiple PRs for runtime, optimizer and API integration. I guess it is an unusual way, but is it possible to have more than one PR for an issue? If not, I will change the description of FLINK-2106 as you said and create two more tasks for the optimizer and API part.

Hi @r-pogalz, usually you only have one PR for a ticket. Thus, it would be good to create two new sub-tasks for the API and the optimizer integration.

@r-pogalz I would implement API and optimizer together in one issue. IMO it is easier to start from the API and then work your way through API to optimizer and finally use your runtime code. However, you cannot add the API without adding the optimizer part. So, I would do both in one issue.

Thanks @r-pogalz & @jkovacs for this excellent PR!
I didn't see anything critical.
IMO, it's good to merge once you addressed @tillrohrmann's and @chiwanpark's code style comments.

Thanks @r-pogalz and @jkovacs for contribution!
I found some code style issues.

Please add spaces around operator and after comma.
Please don't add space after { and before } when you create array.

Other things are well commented by @fhueske and @tillrohrmann.

Hi @tillrohrmann, @fhueske and @chiwanpark,
thanks for your reviews and comments. I went through the classes and changed the formatting. Moreover, I refactored the tests so that exceptions are not hidden somewhere on the console anymore and changed the testCancel*() methods such that the inputs are infinite now to prevent the driver finishing before cancel() is called.

Hi @r-pogalz, @jkovacs,
thanks for the update. It's good to merge, IMO.
Either you resolve my minor comments or I can do it before merging.
Anybody else whats to have a look at this PR?

Looks good to merge. :+1:

Thanks for you comment @StephanEwen, good to know that. I tried to minimize the occurrences of warnings where possible by fixing or suppressing it for this issue. Should I also fix it for the previous issue (runtime OuterJoin operators and tests) and commit it together with this one?

Yeah, adding warnings fix to this PR is good.

The warnings fix commit is ready for review.

Looks good to me. Will merge this tomorrow, if nobody objects.
Thanks @r-pogalz and @jkovacs!

I did not go through all details, but from what I read it was good. Go ahead from my side...

Will merge this now

Thanks @r-pogalz and @jkovacs!


Failing e2e tests - scorecard-bash on ossf-tests/scorecard-action

Matrix: {
"publish_results": false,
"results_format": "sarif"
}
Repo: https://github.com/$GITHUB_REPOSITORY/tree/$GITHUB_REF_NAME
Run: https://github.com/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID
Workflow name: $GITHUB_WORKFLOW
Workflow file: https://github.com/$GITHUB_REPOSITORY/tree/main/.github/workflows/scorecards-bash.yml
Trigger: $GITHUB_EVENT_NAME
Branch: $GITHUB_REF_NAME

Test issue.


Dropping an ifc file in window will load it

Solving  [Feature request] Drag drop support #130

Should be in the editor.


TSC fatal error:  Maximum call stack size exceeded

🔎 Search Terms
Maximum call stack size exceeded
🕗 Version & Regression Information

This is a crash
This changed between versions 5.2.2 and 5.2.2_
This is the behavior in every version I tried, and I reviewed the FAQ for entries about _________
I was unable to test this on prior versions because _______

⏯ Playground Link
No response
💻 Code
class Lock {}

/**
 * 让这个函数，始终只能运行一个
 * @param {Function} fn
 * @returns {Function}
 */
function singlable(fn) {
    const lock = new Lock()

    const composed = async function (...args) {
        try {
            await lock.lock()
            return await fn(...args)
        } finally {
            lock.unlock()
        }
    }

    Object.defineProperty(composed, 'name', {
        value: composed.fn + '_singlable'
    })

    return composed
}

and the compile with tsc
$ npx tsc test.js --allowJs --noEmit
Maximum call stack size exceeded

🙁 Actual behavior
stack trace:
RangeError: Maximum call stack size exceeded
    at getTypeOfSymbol (C:\Users\Admin\gpm\<IP_ADDRESS>\group_name\project\node_modules\typescript\lib\typescript.js:54746:29)
    at getExpandedParameters (C:\Users\Admin\gpm\<IP_ADDRESS>\group_name\project\node_modules\typescript\lib\typescript.js:55655:26)
    at signatureToSignatureDeclarationHelper (C:\Users\Admin\gpm\<IP_ADDRESS>\group_name\project\node_modules\typescript\lib\typescript.js:50913:32)
    at createTypeNodesFromResolvedType (C:\Users\Admin\gpm\<IP_ADDRESS>\group_name\project\node_modules\typescript\lib\typescript.js:50672:31)
    at createTypeNodeFromObjectType (C:\Users\Admin\gpm\<IP_ADDRESS>\group_name\project\node_modules\typescript\lib\typescript.js:50504:27)
    at visitAndTransformType (C:\Users\Admin\gpm\<IP_ADDRESS>\group_name\project\node_modules\typescript\lib\typescript.js:50440:26)
    at createAnonymousTypeNode (C:\Users\Admin\gpm\<IP_ADDRESS>\group_name\project\node_modules\typescript\lib\typescript.js:50375:22)
    at typeToTypeNodeWorker (C:\Users\Admin\gpm\<IP_ADDRESS>\group_name\project\node_modules\typescript\lib\typescript.js:50189:18)
    at typeToTypeNodeHelper (C:\Users\Admin\gpm\<IP_ADDRESS>\group_name\project\node_modules\typescript\lib\typescript.js:49969:26)
    at C:\Users\Admin\gpm\<IP_ADDRESS>\group_name\project\node_modules\typescript\lib\typescript.js:49904:136

🙂 Expected behavior
There should not error
Additional information about the issue
No response

You need to understand that if you don't provide a repro case the chances for your problem being fixed are less than 0. It's virtually impossible to guess what the problem might be from the given (lack of) information.

Sorry, I can't provide any more information at this time.
Because this appears in my project.
It was working normally until the last few commits caused this error.
I'm checking one by one which piece of code caused it

@Andarist
Here is the reproducible code
import { Lock } from '@/util/lock'

/**
 * 让这个函数，始终只能运行一个
 * @param {Function} fn
 * @returns {Function}
 */
function singlable(fn) {
    const lock = new Lock()

    const composed = async function (...args) {
        try {
            await lock.lock()
            return await fn(...args)
        } finally {
            lock.unlock()
        }
    }

    Object.defineProperty(composed, 'name', {
+        value: composed.fn + '_singlable'
    })

    return composed
}

Compile it with tsc
$ npx tsc test.js --allowJs --noEmit
Maximum call stack size exceeded

Could u also inline Lock here and recheck if it still reproduces the problem? The repro should be self-contained and this relies on an external import

I have actually highlighted the above problem, and it has nothing to do with Lock.
just remove this code, and it will works again
-    Object.defineProperty(composed, 'name', {
-       value: composed.fn + '_singlable'
-    })

or change it to
    Object.defineProperty(composed, 'name', {
-       value: composed.fn + '_singlable'
+       value: "whatever..."
    })

Thanks for the repro! The bug is pretty old - I can repro it even with TS 3.3

This is a circularity error combined with non-existent property. The problem is that when serializing the type within reportNonexistentProperty we end up calling isReadonlyAssignmentDeclaration which calls checkExpressionCached(d.arguments[2]) for this expando declaration member. When resolving the type of this descriptor argument we run into the mentioned circularity because it tries to call reportNonexistentProperty again.
Partially the problem is in the fact that reportNonexistentProperty gets called before we have a chance to assign the cached type of this expression. There is a way to use addLazyDiagnostic to overcome this problem slightly - but those are sometimes called eagerly despite being "lazy" (see checkSourceFileWithEagerDiagnostics). So in those scenarios, it doesn't solve anything.
The circularity could be detected (based on pushTypeResolution+popTypeResolution but I'm not sure where tracking for it should be added here. It would also be a surgical fix and it kind of feels that other typeToString calls might be affected by this problem as well.
Maybe some TS team member could advise on how this would be best handled (implementation-wise).

@ahejlsberg could you remove Need More Infos Label from this issuse since it's reproducable.


[5pt] Run_by_unit does take multiple huc comma delimited

This functionality existed in FIM3 in its version (as part of fim_run.sh)
Error message:

fails on multiple commented hucs
Traceback (most recent call last):
File "/foss_fim/src/check_huc_inputs.py", line 61, in
check_hucs(**args)
File "/foss_fim/src/check_huc_inputs.py", line 48, in check_hucs
__check_for_membership(hucs,accepted_hucs)
File "/foss_fim/src/check_huc_inputs.py", line 41, in __check_for_membership
raise KeyError("HUC {} not found in available inputs. Edit HUC inputs or acquire datasets and try again".format(huc))
KeyError: 'HUC 12030107,06030002,03070105,05010009 not found in available inputs. Edit HUC inputs or acquire datasets and try again'

Note: Documentation in the run_by_unit.sh suggest it should work.
Note: This might have not worked in FIM3

In testing, it was discovered that a comma delimited is not supposed to work. However it does work as space delimited with a set of double quotes around the whole thing.  ie ) -u "07080101 05030204 13030202" (will work).  All that is required is to upgrade the "help" notes for run_by_unit.sh.


How to get data through spi?

Hi!
I'm a fresh man in using sensor, and I had tried many libs about bmi088(it seems there's no BMI085 lib), all of them failed in init accel and gyro.

Hi!
I'm a fresh man in using sensor, and I had tried many libs about bmi088(it seems there's no BMI085 lib), all of them failed in init accel and gyro.

Hi there. The reason why the BMI085 is not supported in the 088 library is because there are on chip buffers that nearly all of the 088 libraries utilize (FIFO). The 085 does not have these features on the chip which is why those libraries do not work. As for SPI support, that is not something I am currently working on, but may become a feature once I have more time to implement it. I apologize for the inconvenience.
-DS

Hi!
I'm a fresh man in using sensor, and I had tried many libs about bmi088(it seems there's no BMI085 lib), all of them failed in init accel and gyro.

Hi there. The reason why the BMI085 is not supported in the 088 library is because there are on chip buffers that nearly all of the 088 libraries utilize (FIFO). The 085 does not have these features on the chip which is why those libraries do not work. As for SPI support, that is not something I am currently working on, but may become a feature once I have more time to implement it. I apologize for the inconvenience. -DS
Thanks.
I just noticed this repo BoschSensortec, but this repo cannot ask questions(ORZ) and no one talks about this repo in Google. It seems quite official, but it looks like not for arduino.
And I found it finished SPI init, read and write functions in common.c. So if I change it's SPI init, read and write functions and make it suitable for arduino, can I make my bmi085 work?

Hi!

I'm a fresh man in using sensor, and I had tried many libs about bmi088(it seems there's no BMI085 lib), all of them failed in init accel and gyro.

Hi there. The reason why the BMI085 is not supported in the 088 library is because there are on chip buffers that nearly all of the 088 libraries utilize (FIFO). The 085 does not have these features on the chip which is why those libraries do not work. As for SPI support, that is not something I am currently working on, but may become a feature once I have more time to implement it. I apologize for the inconvenience. -DS

Thanks.
I just noticed this repo BoschSensortec, but this repo cannot ask questions(ORZ) and no one talks about this repo in Google. It seems quite official, but it looks like not for arduino.
And I found it finished SPI init, read and write functions in common.c. So if I change it's SPI init, read and write functions and make it suitable for arduino, can I get my bmi085 work?

I'm not entirely sure. I would have to sit down and look to see. I'm still new to communicating directly to sensors, specifically using i2c. I just published this repo early since, as you found, there isn't really any other options. I will try to include spi support when i compile this code here to an actual arduino library, but that will be at least a few weeks. I'm sorry I can't be of much help with that. My best advice would be to take a look at the datasheet and try to get the SPI init to work. all of the other code in my example might work with that, but again, i am not certain.
-DS

Hi!

I'm a fresh man in using sensor, and I had tried many libs about bmi088(it seems there's no BMI085 lib), all of them failed in init accel and gyro.

Hi there. The reason why the BMI085 is not supported in the 088 library is because there are on chip buffers that nearly all of the 088 libraries utilize (FIFO). The 085 does not have these features on the chip which is why those libraries do not work. As for SPI support, that is not something I am currently working on, but may become a feature once I have more time to implement it. I apologize for the inconvenience. -DS

Thanks.
I just noticed this repo BoschSensortec, but this repo cannot ask questions(ORZ) and no one talks about this repo in Google. It seems quite official, but it looks like not for arduino.
And I found it finished SPI init, read and write functions in common.c. So if I change it's SPI init, read and write functions and make it suitable for arduino, can I get my bmi085 work?

I'm not entirely sure. I would have to sit down and look to see. I'm still new to communicating directly to sensors, specifically using i2c. I just published this repo early since, as you found, there isn't really any other options. I will try to include spi support when i compile this code here to an actual arduino library, but that will be at least a few weeks. I'm sorry I can't be of much help with that. My best advice would be to take a look at the datasheet and try to get the SPI init to work. all of the other code in my example might work with that, but again, i am not certain. -DS

OK, thank you. I would have a try after exam this week.


Add aliases for Base, BaseSepolia and BaseGoerli

Motivation
There are no aliases set for Base Mainnet, Base Sepolia and Base Goerli.
Solution
Add aliases for Base, BaseGoerli and BaseSepolia and related tests.

Wait, the JSON file has not updated, are you sure this does anything?

Shouldn't this set the aliases so they can be used direcly in a foundry.toml file? e.g.
[etherscan]
base = { key = "${API_KEY_BASE}" }
base_goerli = { key = "${API_KEY_BASE}" }
base_sepolia = { key = "${API_KEY_BASE}" }

Yes, but those are the default values which are already valid, see: https://github.com/alloy-rs/chains/blob/534bb02c4af73d6cb165290b3a54acd9307006d1/assets/chains.json#L471

Indeed, when verifying a contract the names are valid and can be used e.g. base-sepolia, but when trying to run a script having that foundry.toml configuration file and providing the RPC URL as --rpc-url base_sepolia, I'm getting At least one of 'url' or 'chain' must be present for Etherscan config with unknown alias 'base_sepolia'.
Thought this will fix the error. Correct me if I'm wrong.

@mattsse Shouldn't all aliases also have a snake case format?

this is the default


[bug] tower-livereload doesn't work with latest version of axum

To reproduce: run axum example on latest version of axum - https://github.com/leotaku/tower-livereload/tree/master/examples/axum-dev-only
My hunch is this change https://github.com/tokio-rs/axum/pull/3031 defers setting content-length, one of the heuristics used for injecting.

Good catch, thank you. I suppose we will have to just remove that heuristic.


Result Queueing Mechanism

To do have proper support for unit testing, we need a system to queue up what results would come from what queries. This needs planning around how to support what kinds of queries (upsert vs sum vs findAll, etc).

Current Thinking
My idea at the moment is to have three functions on the FakeModel object. One for queuing a successful query, and one for queuing a failure of some sort. The queue will be shared behind the scenes between the two functions so that the next call will return the next item in the queue regardless of whether it is a failure or success and handle it. This will allow testing for branching code based on failures, as well as detailed result testing.
The third function is a way to clear the queue so we can clean up after test failures and so we don't leave the objects polluted for the next test.
queueResult( result [, ... other returns] )
The idea here would be a single function to queue what the next returned result from a query on that object will be. For functions that return multiple values (e.g. findOrCreate) more arguments will be accepted to enable additional return values. To the end user, this will be transparent, and default values will be used for any values that are not provided in this call.
For this, each query function call type will need to know to get the data it needs and how it can fallback to a default value.
queueFailure( ErrorObject )
This will queue the next query to reject the promise and return the given error object. This will require the error type from Sequelize to be in the Mock library so we can have good test support for if people handle specific errors from the DB in different ways. But an initial implementation can likely start with just accepting and passing along any error object until we get to v1.
clearQueue( )
Clears all future results for the queued results. This is to better enable test cleanup before and after tests run.

Slightly Updated Thinking
We'll need to have some additional options for how we want to handle queries and what we want to do with them. Switching the signature for the functions slightly
$queueQueryResult( result [, options] )
Alias: $qqr
The options parameter can be used to set return values like wasCreated but also to mark if a result should have the default values in addition to any values that are included in the result object.
$queueQueryFailure( ErrorObject [, options] )
Alias: $qqf
For now, the only options will likely be if we should convert it to an error object (in which case we will convert it to a BaseError unless it already is an Error).
$clearQueryQueue( )
Alias: $cqq, $qqc
Will function the same as before

Each mock Model object will get a mock QueryInterface object that can be used to queue results against that Model in particular. Each Model.QueryInterface will also inherit from a Sequelize.QueryInterface on the mock Sequelize interface it was defined against.
Queries run will use this priority for returning results

The next result queued against Model.QueryInterface
If not available, the next result queued against Sequelize.QueryInterface (propagation can be disabled at either the Model or Sequelize level)
If not available, any automatic Model building functionality will be relied on (current behavior) (can be disabled at the Model or Sequelize level)
If none of the above are available, throw a new EmptyQueryQueueError() error.

All queries will follow this basic priority in returning results. Automatic return and propagation will be enabled by default to enable the smoothest upgrade path.


SCM: Allow folders as resources when rendering as tree

Users have found out in https://github.com/microsoft/vscode/issues/82203 that most other SCM providers break the tree rendering. This happens because they provide folders as resources themselves, which simply breaks the tree.
This should actually just be supported, but we need to address what happens to the contextual menus. With the tree rendering addition, folders have their own context key for menus. Currently in these SCM providers, the folders have the same actions as the files and maybe that's intended, so we should preserve that.
I suggest the following:

If a folder is provided as a resource, simply use the regular resource context key, thus maintaining the current behavior. Also, we need to change the should expand on twistie click only behavior, since those resources might have a command to run when clicked.
Else, populate the menu using the new folder context key.
Remove the proposed API additions introduced in https://github.com/microsoft/vscode/issues/82203

This allows us to continue to move forward without adding or removing anything from the API.

Hi,
I don't fully understand the technical details, why it broke the scm view. So my question is: What needs to be done from my side as a extension maintainer (vscode-clearcase) to make use of the tree rendering? Perhaps you can give some kind of advice about that.
Thank you in advance.

@fr43nk Absolutely. What I argue in this issue is that you, as an extension maintainer, should not have to do anything to benefit from this feature. It should just work.

@joaomoreno  Ok, so if you want me to test the new feature with my extension, I can do this.

Pinging a few SCM Provider devs: @fr43nk, @jeffyoung, @jpricket, @JohnstonCode, @edgardmessias, @ivangabriele, @mrcrowl, @stef-levesque.
As you might know, this iteration we shipped rendering SCM as a tree. This broke for 3-rd praty SCM Providers and a fix is coming today or tomorrow to address this. The recovery fix simply disables tree rendering for all SCM providers except git. This was an oversight from us and we apologize for the disruption.

Thinking forward, I've pushed some changes to support tree rendering for all SCM providers. The problem here was that some SCM providers are sending folders as SourceControlResource instances and this broke some assumptions. Given these changes, list rendering (default) is left untouched but tree rendering has the following implications:

Those folders won't be compressible, so if there is a long chain of these folders, the SCM tree won't compress it;
Those folders will have the same inline and context menu actions as SourceControlResource instances;
Those folders won't have a click command any more, since clicking them will expand/collapse those tree nodes.

You can try this on insiders from tomorrow onwards. I've tried a couple of extensions and they seem to play along nicely. Let me know your thoughts.

I tried the latest insider build with my extension and it still works :smile:
In the current release version the button to toggle list or tree view is available for my extension and seems to work. In the insider build this button is gone. Is this by intension?
Thanks

Verification:

Install SVN
Install the SVN extension
svn co https://svn.apache.org/repos/asf/subversion/site/staging/docs/release-notes/
Open the release-notes folder in VS Code
The SVN extension should be rendered in the SCM view

Works perfectly


more sticky on the desktop

Nice product.  But this app does the thing. One issue: when I click bottom-right, the desktop appears. Unfortunately, the OotD is gone then. How do I get the calendar window even more sticky on the desktop?

I wish there was a way to do this as well. It was possible on Windows XP and below, but in Windows 7 and above, Microsoft took away the apis to do this easily. I'm sure there is a way to do it but it involves a lot of time and research and I have limited time to do that at the moment.


Make the script editor's syntax error message selectable or copiable

Godot version:
Godot Engine v3.1.1.stable.official
Issue description:
Can't copy and paste syntax error message have to copy it manually.

I do like how clicking it brings you directly to the syntax error... Maybe not make it selectable but add a right click context menu option with copy, search google, or search documentation.
Steps to reproduce:
func get_path(start, end): 	pass

Brilliant idea!

For now, a simple workaround is to save the script with the error and copy it from the console (or from the output in version 3.2.dev).
However, with a contextmenu it would certainly be easier.

Label can't be made selectable, only RichTextLabel can. We could switch to RichTextLabel to allow using the code font dynamically (only using it to reference variables), but this requires a full rework of the GDScript error reporting system.

Not sure where or when this happened but looks like it's been added with the errors button

Seems like this was added in 4.1.


MB 10148 upload docs flow

Description
Previously, when a Prime User was on the upload docs page, successful actions and cancelling an upload lead them back to the home page. With this change, the application will move the user back to the move details page related to the upload.
Tests were also added
Setup
To run the save:

Run both front end and back end
Go to officelocal:3000
Click on a move that has payment requests
Scroll to the bottom
Click upload documents
Upload a file of your choice
Click Save
Observe that the page you are on now is the move details page with a success message

To test the cancel button:

Repeat steps 1-5 of the last section
Click cancel
Observe that the page you are on now is the move details page

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 76cfe68e6706ae77190d1b5f0742dae733639db4


Prototype consuming the factory in OAuth/OpenIdConnect

The Security repo has some of our only first party usage of HttpClient. We should try using HttpClientFactory there and see if it makes sense.
@glennc

Just saw this due to the transfer, I assume that we don’t need any more prototyping for the HttpClientFactory now, given that it’s already out for quite a while now.
But do we then want to attempt to migrate some of the client usages within the Security repo to use this?

It would still be interesting to try using the client factory in the auth providers.


How to Mock a State?

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
State MyState extends Equatable {
int value;
void getValue() {
return state.value;
}
}
class MyBloc extends Bloc<MyEvent,MyState> {
MyBloc() : super(MyState()) {
}
someFunction(event, emitter) {
emit(state.copyWith(status: status.loading));
int value = state.getValue();
}
}
Expected behavior
I want to mock this getValue function in my State class to in blocTest
Screenshots
If applicable, add screenshots to help explain your problem.
**Logs **
Run flutter analyze and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
Paste the output of running flutter doctor -v here.
Additional context
Add any other context about the problem here.

You can use seed in blocTest to set the bloc’s state to whatever you like before adding events. Hope that helps!


Fix NoMethodError stub

It has caused a NoMethodError in my environment. So I fixed it.
BTW, this message also displayed in my environment.
test-unit-power_assert: warning: You don't need to require test-unit-power_assert.
test-unit-power_assert: warning: test-unit 3 or later has built-in support for power_assert.

thx!


Searching with "_" gives no results

On Salsah 1.5 and your KUIRL test server, using the fulltext search with "_" gives no results.
I initially thought that it happened only when the rdfs:label includes this character, but it also happens for a standard TextValue property.
Given this resource:

The following search in unsuccessful:

This one is even worse:

for reference: DSP-357


Decide on requirements.txt flavor - single or different prod, test, and dev?

Done. As usual. We split ...


fix: Restore telemetry logging under debug flag.

Notably, this PR also re-includes an entire list of tests in runtime which were excluded due to being using .mjs extension.
A test was failing since #3433 but we never noticed due to this.

CI is very red

I forgot to run pnpm install from the root. Let's see now!

CI is very green :D


Add orthogonal polynomial model support

Previously only ordinary polynomials were supported in ASDF. This allows astropy orthogonal polynomial models to be serialized.

messed up, will issue new PR


alerts added and bug fixed where comments not showing on initial load

fixes the non-loading comments on initial load too

👍


Proposal for new tangle interface

After using tangle now in multiple VSCode projects I've run into several patterns where the current interface design fails. Therefor I would like to suggest some (breaking) changes to the package:
Usage of RxJS
RxJS has a steep learning curve and hard to get for people not familiar with it. I personally struggle fixing some of the reported issues and wouldn't wonder if others do so too. I am not sure if there is a clear need for RxJS for the tangle usecase, there are other ways to accomplish the same.
I'ld suggest to simplify the code base and remove RxJS as dependency and rewrite the functionality using bare JS primitives.
State Updates
Currently tangle's broadcast method requires the whole state to be submitted, it would be nice if updates can be made on single object properties. Maybe we can have a broadcast and broadcastAll?
That said, currently a state can be everything which turns out to be not useful in reality. It seems weird to juggle with multiple client instances because you have multiple states. It seems more straightforward to say a state must be a Map which can contain multiple state properties.
Every state listener is triggered whenever any state property changes. This comes from the fact mentioned above as the current implementation interprets a state as one object and can't determine if just parts of the state has changed.
With the suggestion above we should ensure that listening on a state property only triggers the listener when that particular state property has changed, e.g.:
const ch = new Channel('foobar', {
    counter: 0,
    anotherProperty: true
});

bus.listen('counter', (counter) => console.log(`Counter update: ${counter}`))
bus.broadcast({ anotherProperty: false }) // <--- does not trigger listener above

This causes a lot of re-renders in the Marquee extension.
Event vs. State
In the current implementation event and state is handled separately but not when it comes to types. For example:
interface StateType {
    counter: number
}

const ch = new Channel<StateType>('foobar', {
    counter: 0
});

bus.emit('foobar', 'barfoo') // type issue as `foobar` is not part of `StateType`

I suggest to not expect any types for event methods except you pass in a type, e.g.:
interface Events {
    foobar: string
}
bus.emit<Events>('foobar', 'barfoo')

Event vs. State
Yeah, that makes a lot of sense. I do think there's a benefit in having stronger typing & separation between events and shared state. In a lot of ways, tangle kinda treats them separately on a lower-level but not all the way through typing.
I'm not so sure about the Map-approach since it would water-down the structural typing of app state from a data structure to a blob of data. My tangle vision (not too attached to it) for app state was to ideally have a sharable type between clients per channel.
rxjs or not
While I'm still convinced Observables are superior for these kinds of problems, I hear you on the learning curve. In a lot of ways, I don't want to make this a religious functional vs imperative programming contention point. If you have a plan in your head how a low-level rewrite would look like, I don't want to stand in the way. Probably just have to figure out some rough estimates and when we want to take the time for it.


Add support for pagination

When grabbing users from all the services we need to support pagination

Turns out there is no need

longboard have no limit
bambooHR seams to also have no limit


Remove the Biological Collections Ontology (bco.owl) from imports

We included the Biological Collections Ontology so we we could implement in-OWL matching of scientific names and specimen identifiers, using the Darwin Core terms defined by that ontology. Since we now do that in Javascript, we don't need to include this ontology any more, and it should be eliminated from the imports.

Moved to phyloref/phyx.js#17, closing it here.


Update django 1.8.x

Update the LTS branch.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Do not convert hosts to IPs

While using TLS, certs use to be valid for domain names, not for IPs.
Without this patch, communication between skydive itself is done using
the IP, failing if the cert does not contain the IP.

The functional tests seem to be OK and It look good to me. Just need to adapt/fix the unit tests


[Help Wanted] Focus not set back to the next top-level window after closing Mattermost app window

I confirm (by marking "x" in the [ ] below):

[X] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[X] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[X] I have read contributing guidelines.

Summary
Focus not set back to the next top-level window after closing Mattermost app window
Steps to reproduce
Original report here: #233
Reporter: @nmatt
Windows 10, Mattermost server v3.6.2, Mattermost desktop v3.5.0

Launch Mattermost desktop 3.5.0
Launch some other application
Alt+Tab back to Mattermost desktop
Close Mattermost desktop using keyboard or Close button
=> Focus is not back on the other application (but is still on the now invisible Mattermost desktop application)

Expected behavior
Focus is set back to the next top-level window
Observed behavior
Focus is not back on the other application (but is still on the now invisible Mattermost desktop application)

Might be related to #431.

Resolved by #464


policy controller SSL problems with CA chain certs

controller can't connect to Etcd servers
2017-02-03 15:55:23,382 6 INFO Leader election enabled? False
2017-02-03 15:55:23,382 6 DEBUG Attempting to remove old tier k8s-network-policy
Traceback (most recent call last):
  File "<string>", line 516, in <module>
  File "<string>", line 141, in run
  File "site-packages/pycalico/datastore.py", line 901, in delete_policy_tier
  File "site-packages/etcd/client.py", line 610, in delete
  File "site-packages/etcd/client.py", line 860, in wrapper
etcd.EtcdConnectionFailed: Connection to etcd failed due to SSLError(SSLError(1, u'[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)'),)
controller returned -1

we tripple checked all certs and they are fine, my only version would be that it is related to our etcd server and client certs being signed by intermediary CA, so that whole CA chain has multiple certs. It seems that it causes problems for python etcd client as it produces error like one above.
We had similar problem with calico/node:v1.0.2, but updating that image to v1.1.0-rc2 solved the problem as /bin/startup which was failing with similar error was replaced with Go version.
It is possible that python lib urllib3 is problem: https://github.com/shazow/urllib3/issues/878
Do you know if there is a workaround to continue to use certs, but disable  cert validation maybe? It is not ideal, but would allow us to start using Calico in our setup

Also hit this same issue

what we found, is that setup suitable for Go wasn't enough for curl & python. It was related to CA chain, but not in the way I originally thought.
Basically to make it work for curl & python we had to add full CA chain to the list of trusted certs, while Go seems to be happy to report successful validation on if just one cert from CA chain is trusted.
So check you connection with curl,if it is unhappy, keep playing with your SSL setup until curl is happy, then Calico will work too

My Etcd client certificates and ca.pem work in curl and all other k8s services. They are generated by Vault's PKI backend.
May be a bit premature to close this, but I can open another issue with more debugging if that would be helpful.
It is quite difficult to debug though with such a generic error message

we do use vault PKI too and Calico 2.0.2 release definitely works for us

Mind sharing your config and k8s manifest?
On Feb 16, 2017 12:00 PM, "Maxim Ivanov"<EMAIL_ADDRESS>wrote:

we do use vault PKI too and Calico 2.0.2 release definitely works for us
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/projectcalico/k8s-policy/issues/67#issuecomment-280391462,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYfFBdb-9G2A6uHrRpOBksbmvOg7Yf7ks5rdIC-gaJpZM4L2xsy
.

you can have a look at kube-aws which we use. When certs are generated, we place them as following:

vault root CA and it's chain go to ca.pem
vault PKI intermediate CA and service cert go to etcd.pem
vault PKI intermediae CA ans client cert go to etcd-client.pem

also make sure that when you mount client PKI roles, you set server_flag=false

Had the same problem. Adding root CA into ca file worked. Python urllib3 which is broken or should be fixed imho. Root CA shouldn't be required.


Pickpocket Items aren't removed from target

Hi Saibot, I notice that the pickpocket from npc don't take the loot from target tokens. I mean items are not removed from original target but just copied to the player inventory. Can you check it this is also the case for you? I updated to foundry vs 12 and dnd 4.1

So, to me everything seems to work as intended. It is however true, that the items will only be set to quantity 0 and will not be removed. This is basically done as a precaution, so that if a player accidentally loots an item that was not supposed to be lootable, fixing that is a bit easier.
I can however add a setting, so that items that are looted down to quantity 0 are removed

Hi Saibot, I will give a check. Maybe it was me not paying enough attention. Thank you for checking

I will look into that bug, should (hopefully) be relatively easy to patch.

I have released a fix with v3.1.11. Looted containers should now be deleted

I really appreciate how you work and active maintain these modules. Also you are very nice in keeping us updated on changes.
Can I help you somehow with a patreon support or anything else? Let me know please
Kind regards
Federico

Happy to hear that the work is appreciated.
No, i don't have a patreon or similar, thanks for the offer though

If you plan on opening such things in the future, I'll remember your kindness. Thanks again


Fix typo in 'Monterey'

This PR fixes the typo in 'Monterey'.

OMG I always mess this up 🤣🤣
Thanks!!


Package metadata updates

Be consistent about the project's name (fixes #4).
Add license (fixes #5).
Rename virtwl_proxy.ml to main.ml for clarity.
Unvendor ocaml-wayland (it's released now).

Thanks!


Make some fields optional in the general RDF

For general RDF and collection, forcing authors, cite, documentation, and tags does not make sense all the time. It's much better to make these non-critical fields optional.
For example, when the RDF item is not published anywhere, there won't be much to fill for the authors and cite fields. tags is helpful for searching but it's not critical, similar case for documentation (note we have description already).
Another use case is to generate and use RDFs offline, e.g. with the bioimageio.core package if we generate a model RDF for offline use, we will have to generate empty fields for authors, cite, tags and documentation which seems unnecessary. They only make sense if we want to upload the model to the model zoo, but we can always enforce them when uploading to the website or as part of our approval criterion.
The fields change is non-breaking and it means a minimal RDF file should have the following fields:

format_version
name
type
description

This PR also includes moving the general RDF examples to a separate file to make it easier to find the link for model/collection spec.

All the tests passes now, I will merge this now to get all the collections working on the website. If @FynnBe spotted anything later we can patch it with another PR.


Split filters of SQL queries and add a builder

Which Issue(s) this Pull Request Resolves

Resolves #483, resolves #649
Release Note

NONE

Notes for Reviewers

After the discussion on #649 and on the design meeting I included go-sqlbuilder which end up being
flexible enough to be used even with DBMS specific functionalities (like JSON support).
In this proposal I am including a Documentation page for the Design Proposals and the goals, so if you disagree with the "design" part more than the "implementation" part, feel free to add reviews on that part.
This PR superseeds #650 in which a custom sqlbuilder was used instead of delegating on a library.
It still applies that with this changes some of the database functions look very similar and they could be merged as part of the effort for #641 .

I'm worried about how it will grow when we introduce labelSelector, fieldSelector and ownerSelector.
I am not sure of following your train of thought. I did this refactor thinking of having less work (and code) when including labelSelector, fieldSelector and ownerSelector (as they are going to be plugged into several queries).

I liked the way the Database was working before, in which it did not know much. Now it needs to know more because it builds the queries itself (before this was delegated to the DBInfoInterface.
Now that the DBInfoInterface is chunked in different pieces, I find it easier to manage and we also remove duplication between postgresql.go and mariadb.go. Also, we had a problem before for variadic arguments that now is solved by the sqlbuilder (e.g. for the in operand in filters) that now is solved in a transparent way, and we don't need to know how are variables written for a specific database (% for MariaDB and $1 for PostgreSQL), so I believe that the Database needs to know less, not more.

I think that will require another rework to this code, as number of arguments will grow even more and probably will be wise to move to a struct to pass around arguments.
So, the way that I see it is that if the api needs to apply, let's say, a "name filter", it knows that it needs to provide the thing to filter (in this case the name) and get in return the "sql piece" to be added to the query, so it makes sense to me having the arguments involved in the specific DBMS part (the old DBInfoInterface).
When you say that the arguments "will grow", they will grow because we will have more filters based on different things, but the amount of arguments for each filter should be small. For example, a labelSelector will need a set of key, value that is probably going to be encapsulated as one arg, and the same for fieldSelector and the ownerSelector.

However, you can provide more input when I create the PR for adding labelSelector.


Blurred images

PDF.js displays blurry plots in PDF documents, e.g.
http://arxiv.org/pdf/1202.5344v1.pdf
When viewed in Chrome or Adobe Acrobat all the plots show sharp-edged squares. When viewed in Preview or PDF.js, all the squares show as blurry pixelated blobs.

Remark: The dots have disappeared in some cases. And while working on something else, I discovered that the Matrix of the tiling pattern has 0 and 0 for the x and y scale, respectively.

Still blurry plots with Firefox 62 and PDF.js: 2.0.625

Still blurry plots with Firefox 66.0.1 and PDF.js: 2.2.107.
However, I have not the TilingType log anymore, so maybe it is not a related to a tiling type bug, but more to this kind of issue #7838 ?


Set web image php.ini default date.timezone to UTC

Describe the bug
The webimage server timezone (/etc/timezone) and localtime (/etc/localtime) are already set to UTC. This is good. However, the default PHP date.timezone is set to America/Denver in all SAPI`s (fpm, cli, apache2, cgi).
PHP Applications like symfony and typo3 do not set a timezone on their own, if not explicitly configured. In PHP world, it is usually good practice to have the server side always calculate in UTC, and only display date time values in a user local timezone when outputting dates (usually in javascript or templating engines). For an image used woldwide, where the image maintainer does not know the timezone of users, America/Denver feels arbitrary, UTC is a much better choice - many global companies run all their servers on UTC to avoid date miscalculations for similar reasons. It would be good if ddev follows.
To Reproduce
For CLI: php -i | grep timezone
Current workaround
Create file .ddev/php/tz.ini with content date.timezone = UTC - Tested CLI and FPM, both change their timezone to UTC
Related
#1417
Expected behavior
PHP date.timezone = UTC should be set in all php.ini files.
Version and configuration information (please complete the following information):

checked on 'drud/ddev-webserver:v1.7.0', guess that did not change with younger versions.

Seems reasonable. I have always wished to have it set by default to the host's timezone, but haven't found a platform-independent way to do that.  Note the Stack Overflow article on how to manually set it, https://stackoverflow.com/questions/50255466/how-can-i-set-the-timezone-in-my-ddev-containers, and the request for timezone in config


Leaving a Group doesn't update the group list

If you go into a group, click leave group

You'll see your leave notification in the group, but you remain in the group page ui
If you go back to the Groups screen, left group will remain, clicking on it is a bit broken though
If you hard refresh, it is also still there, so could also be a bug in the API

Tried to recreate this but couldn't, only saw it on my old beta install...


How to mention subject name while training , so that they can be mentioned while generating images.

simply rename the instance images to that name and start training


Add support for concatMapEager

When calling concatMap, the handler is called in series so it has to return a value before entering the next iteration.
In some cases it would be more efficient to be able to run the handler in parallel and then drain the results in order, especially if the handler is waiting for IO.
See http://reactivex.io/RxJava/javadoc/io/reactivex/Observable.html#concatMapEager(io.reactivex.functions.Function)

it is need to be merged but doc itself is ready - please refer https://github.com/ReactiveX/rxjs/pull/2524 .
in general we recommend to create new operator as user level code / packages except very few cases to avoid api surface issues - for this one too I think this operator can be implemented without internals of rx codebase itself.

I would argue that I expected the behaviour of concatMap to be what is done by concatMapEager. Would it be possible maybe to simply add a concurrency option to concatMap so a new operator is not introduced? (with a default of 1 to preserve backward compatibility)

For your argument, some other people might say they expect completely different behavior.
Clarify, point I'd like to share in this issue is not about the usefulness of operator suggested. It is more like due to it is impossible for us to create core API set satisfies all operator requirements, we're trying to make core API surface minimal as possible, including ongoing discussions for breaking changes of removing operator from core set, and recommend to opt-in extended, custom operator features. As suggested above, any custom operator can be published as user level as composable manner, which functionally should not differ. Or either if you believe this should be included in core, we would like to have a consensus about reasoning.

While I agree with your general mindset, this is already implemented in the Java version. It doesn't make sense to me to have a different core API for each implementation. This feature would basically be part of some kind of rxjava-for-rxjs extension. So while I don't necessarily believe it should be included in core, it is already included in core in other implementations so I would expect a consistent experience across languages.

Each rxjs binding for language already have different set of operator and it is not a goal to provide same set of operator between languages. You can compare different rx language binding to see those differences.

I'm closing for this now.


minSdk version should not be declared in the android manifest file

The minSdk version should not be declared in the android manifest file. You can move the version from the manifest to the defaultConfig in the build.gradle file.

I think so

@AlexanderZaytsev  could you please merge the PR?
It's important for automation process flow 🙏🏼

@Fgl done

waiting for this patch to be released as new version.


[themes] Explorer arrows do not update when using reload feature

VSCode Version: 1.34.0-insider
OS Version: All

Steps to Reproduce:
This issue is difficult to reproduce as it requires a special version of an icon theme extension that supports theme reloading (_watch).

Being a maintainer of the vscode-icons extension, I stumbled on this issue while testing the implementation of this feature on our extension.
As I'm the author of the theme reloading feature, I pinpointed the cause of the bug. The reason for it is that on reload we don't call the onFileIconThemeChange event, resulting in the explorer tree not getting notified.
The solution is to add a call to doSetFileIconTheme on the onApply function.
Although much of the code execution of the doSetFileIconTheme is an overkill when we reload the icon theme, it has no side effects.
Possible actions are:

Refactor doSetFileIconTheme and extract the calls to telemetry and event triggering to separate function and then use only the extracted function
Do nothing and just add the call to doSetFileIconTheme and don't care about the redundant code execution since it does not have any side effects.

I'm more then willing to provide a PR according the chosen action, although I suspect that you guys prefer action 2.
Awaiting your response.

I like the suggestion of calling doSetFileIconTheme. PR is of course very welcome!


cmd/atlas: report no pending files

Is there a test that covers this ?

See the changes in migrate_test.go


Fix: use HostPort insted of URL

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:
Kafka output settings work with Kafka.HostPort instead of Kafka.URL
Which issue(s) this PR fixes:
Special notes for your reviewer:

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

fc892b6 fix: use HostPort insted of URL

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign cpanato after the PR has been reviewed.
You can assign the PR to them by writing /assign @cpanato in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @mrtc0! It looks like this is your first PR to falcosecurity/falcosidekick 🎉

LGTM label has been added.  Git tree hash: a782559d54884272995176f55482343491362feb

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Issif]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign issif after the PR has been reviewed.
You can assign the PR to them by writing /assign @issif in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign issif after the PR has been reviewed.
You can assign the PR to them by writing /assign @issif in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Add note on --exit

The --exit flag is easily missed, and forgetting to include it can lead to frustration. I wanted to highlight its inclusion.
For reference, what --exit does is force Mocha to quit after tests complete. This means that the process will exit even if there are pending promises, timers, or if the event loop is otherwise not empty. Instances of @truffle/contract register an event listener for 25 transaction confirmations, which will not ever happen for the last tests because no new blocks are being mined. It is not possible yet to configure the contracts to not do this, so we must resort to forcefully quit.
If @truffle/contract is not being used (e.g. if contracts.type is web3 on the configuration), then --exit shouldn't be used, as it is helpful in detecting bugs in the test suite.

The README is okay like this, but I think we should explain this with more detail in our documentation.

That's a bit too much IMO for a simple readme. Once we have the docs properly set up on a docsite I do see this being added in a NOTE block.


Figure out transaction cache size

If you have more than 100K txes, wallet will not sync properly.  Bump higher for now

This was adjusted to default to a really high #.


Series.as_matrix was depricated then later removed.

Test suite was failing with pandas >= 1.0.
Test suite now passes.
Series.to_numpy() replaces Series.as_matrix().

All the Pandas on the travis file are ancient.
I'll submit an updated travis.
Do you still want to support Python 2?


Support partial_apply instruction.

@Leeleo3x could you please resolve the conflicts on this PR before I approve it? The code looks good to me otherwise.


sysdig: fix linux 5.6 build

Have not yet tested all old kernel version.
Patch was also sent upstream in https://github.com/draios/sysdig/pull/1614

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 84596 1

3 packages marked as broken and skipped:
- linuxPackages_4_4.sysdig
- linuxPackages_4_9.sysdig
- linuxPackages_hardkernel_4_14.sysdig

2 packages failed to build:
- linuxPackages_4_14.sysdig
- linuxPackages_testing_bcachefs.sysdig

14 packages built:
- linuxPackages-libre.sysdig
- linuxPackages.sysdig
- linuxPackages_4_19.sysdig
- linuxPackages_5_5.sysdig
- linuxPackages_5_6.sysdig
- linuxPackages_hardened.sysdig
- linuxPackages_latest-libre.sysdig
- linuxPackages_latest_hardened.sysdig
- linuxPackages_latest_xen_dom0.sysdig
- linuxPackages_latest_xen_dom0_hardened.sysdig
- linuxPackages_testing_hardened.sysdig
- linuxPackages_xen_dom0.sysdig
- linuxPackages_xen_dom0_hardened.sysdig
- sysdig

linuxPackages_4_14.sysdig did not fail before.

There has been a new upstream release. Will make a new pr.


Enable TSR when using multiple named parameters

This new code checks whether the path ends with a forward slash and whether the handle is non-nil when walking through the node tree to allow requests ending with a forward slash to be properly redirected to the their respective handler when walking a node tree with multiple named parameters.
I looked at tests, and, while I believe tree_test.go doesn't need any addition, there seems to be no scenario covering multiple named parameters in router_test.go, but I'm not sure how to write this.
Looking for feedback. Thanks.
Example
Let's say we have an admin page which is reachable at /admin. This admin page then has categories, each of which also has its landing page, like /admin/content, /admin/config. Each of these categories then has potential children pages, like /admin/content/id, or /admin/config/permissions.
Each page is rendered according to some logic in the Admin function, which means the routes are programmed with named parameters, as in this example:
package main

import (
  "fmt"
  "github.com/julienschmidt/httprouter"
  "log"
  "net/http"
)

func Index(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
  fmt.Fprint(w, "Welcome!\n")
}

func Admin(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
  fmt.Fprintf(w, "Category: %s\n", ps.ByName("category"))
  fmt.Fprintf(w, "Page: %s\n", ps.ByName("page"))
}

func main() {
  router := httprouter.New()
  router.GET("/", Index)
  router.GET("/admin", Admin)
  router.GET("/admin/:category", Admin)
  router.GET("/admin/:category/:page", Admin)

  log.Fatal(http.ListenAndServe(":8080", router))
}

However, when tested, we get the following results:
    (200)
1.  /admin                               -->   Category:
                                               Page:

    (301 to /admin)
2.  /admin/                              -->   Category:
                                               Page:

    (200)
3.  /admin/config                        -->   Category: config
                                               Page:

    (404)
4.  /admin/config/                       -->   404 page not found

    (200)
5.  /admin/config/permissions            -->   Category: config
                                               Page: permissions

    (301 to /admin/config/permissions)
6.  /admin/config/permissions/           -->   Category: config
                                               Page: permissions

As you can see, where you would expect number 4 to perform a 301 redirect to /admin/config, we get a 404. After the changes in this PR, the redirects work properly for all links:
    (200)
1.  /admin                               -->   Category:
                                               Page:

    (301 to /admin)
2.  /admin/                              -->   Category:
                                               Page:

    (200)
3.  /admin/config                        -->   Category: config
                                               Page:

    (301 to /admin/config)
4.  /admin/config/                       -->   Category: config
                                               Page:

    (200)
5.  /admin/config/permissions            -->   Category: config
                                               Page: permissions

    (301 to /admin/config/permissions)
6.  /admin/config/permissions/           -->   Category: config
                                               Page: permissions

Sorry for the long wait. You discovered a tricky TSR bug there. Thank you for the extensive example (I reused in the test) and the fix. I decided to use a different approach, which does not require to set the TSR in the tight loop and also is in line with upcoming changes.
Thank you!

That is very cool. Thanks! :smiley:


error on import

called
ran
import anatome
Traceback (most recent call last):
File "/home/cody/miniconda3/envs/RepDist/lib/python3.7/site-packages/IPython/core/interactiveshell.py", line 3437, in run_code
exec(code_obj, self.user_global_ns, self.user_ns)
File "", line 1, in
import anatome
File "/home/cody/miniconda3/envs/RepDist/lib/python3.7/site-packages/anatome/init.py", line 1, in
from .similarity import SimilarityHook
File "", line 1
(x.size(0)=)
^
SyntaxError: invalid syntax
I have anatome==0.0.1
I can provide my environment info if needed but the error looks pretty clear.

can we change those f-strings to support 3.7?

This library only supports Python 3.8 or higher. PRs are welcome.

It's a super simple change to make it 3.7 comparable. I cloned it and fixed it on my machine. I can put the pull request in after my paper deadline. I guess it depends on if wanting to support 3.7 is something you want to do.


Updated file for issue #714

All vars were changed to let or const. Also 'use strict'; was added to file.

@humphd all changes was made due to your request. Please check if everything is fine.