Feature: allow disabling registration

Is your feature request related to a problem? Please describe.
I would like to use my grimoire instance as a single user one. This would allow me to expose it to the internet without having random people create user on this instance.
Describe the solution you'd like
The best solution would be to set an environment variable to enable registration or not (e.g. Gitea does it this way: https://docs.gitea.com/next/administration/config-cheat-sheet#service-service DISABLE_REGISTRATION).
Describe alternatives you've considered
One hacky way was to do it using this solution:
https://github.com/pocketbase/pocketbase/discussions/3488#discussioncomment-7243287
Additional context

I was planning to add it along with other much-needed configurations to the admin panel. But for such a crucial option, the proposed env option should be better. I will add it ASAP!


Make the scheduler event loop buffer size configurable

Which issue does this PR close?

Closes #397.
Rationale for this change

Since the channel in the event loop is a bounded one, sometimes when there're many events produced in a short time, it will block the caller when sending events to the channel. If the buffer size is not larger enough, it will downgrade the performance, especially in a high throughput system.
What changes are included in this PR?

Are there any user-facing changes?

Hi @thinkharderdev and @andygrove, could you help review this PR?

For production usage, we set the buffer size to be one million so that large queries with tens of thousands tasks will not be blocked.


integrate buttondown.email to subscribe newsletter

https://buttondown.email/features/api
This page provides the necessary info

.take

closed by #93


Question: Cells appearing from bottom

Does this allow cells to appear from bottom and up?
Like, if you only have one cell, it would appear at bottom of the bounds of the SpreadsheetView. If you have two cells, the new cell (with row index 1) pushes the first cell 0 "up" one step.
+-----+
|     |
|     |
|     |
|row 0|
+-----+

+-----+
|     |
|     |
|row 0|
|row 1|
+-----+

+-----+
|     |
|row 0|
|row 1|
|row 2|
+-----+

I guess with a Spreadsheet view it might come down to implementation details, but I'm just checking if this is something that would be easily possible with the current SpreadsheetView framework.

@zapjonny It wasn't supported currently. I can probably add such feature as a configuration option. But it requires consideration, such as consistency with existing behavior.


Histograms with bucket labels starting with '-' are missing _sum metric in 0.8.0?

I have encountered an issue with my metrics after having upgraded from version 0.7.1 to 0.8.0.
In the example below, the resulting histogram does not have the sum metric (suffix _sum) when using 0.8.0. If I use version 0.7.1, the _sum metric is back.
label_values = ['1', 'DKK']
bucket_values = [['-50000', 40], ['+Inf', 40]]
buckets_sum = 3000.0

h = HistogramMetricFamily(name, desc, labels=label_names)
h.add_metric(label_values, bucket_values, buckets_sum)

yield h

If I change the value of the 1st bucket, so it no longer has the minus/dash prefix (As seen below), the _sum metric is no longer missing in when using version 0.8.0.
bucket_values = [['50000', 40], ['+Inf', 40]]
Is this behaviour a feature (Which I do not understand) or a regression?
Thanks,
Tobias

This is correct, negative observations means that sum would no longer be a counter and it is thus excluded as per OpenMetrics.

Counter = never decreasing (AFAIK). Makes sense. Thanks for all your work on Prometheus.

@brian-brazil then it's an OpenMetrics flaw that histogram "_sum" is of type counter.  It should be a gauge, and therefore support histograms with negative observations.
How do you propose we derive the average from a histogram metric?  It should be simply sum / count.


CLN _map_python_line_to_nb_lines

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            5         5
  Lines          210       213    +3
=========================================
+ Hits           210       213    +3

Impacted Files
Coverage Δ

nbqa/__main__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b04268...cbb4730. Read the comment docs.


Pay 5390 template id changes

Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

Story PAY-5390 is withdrawn


Enable hardlinking when storing/retrieving files to/from SCons cache

This is actually a feature request.
I use scons cache functionality (--cache=nolinked --cache-dir= options). It works fine but I would like to have an option to enable hardlinking of files stored in the cache. I mean hardlinking both in store and retrieve cases. Of course this option should be ignored if cachedir is on another filesystem but it can be extremelly useful when cachedir is on the same filesystem (like in my case).
Such feature will give us two benefits:

reduce disk space usage
redduce time required to copy file to/from cachedir

Originated from Stack Overflow: https://stackoverflow.com/questions/54765660/does-scons-cache-supports-hard-links

This change would enable performance gains but requires special treatment of cases where a file is modified in-place during build. I don't think hard-linking of cached files can be implemented without quirky edge-case behavior, so it's not likely to be a viable default.
A legitimate in-place modification use case is defconfig <-> .config round-tripping in KConfig environments.
I can imagine NoCache becoming mandatory for such files to ensure correctness. Existing cache could be checked for consistency to provide hints about which files should be excluded.

It seems other caching solutions do support hardlinking (see ccache, for example) - with caveats. Compression is not allowed when hard links are used - SCons doesn't do compression of artifacts anyway so that's not a problem at the moment.  Here's the snip from the manpage:
=======
hard_link (CCACHE_HARDLINK or CCACHE_NOHARDLINK, see Boolean values above)
If true, ccache will attempt to use hard links to store and fetch cached object files. The default is false.
Files stored via hard links cannot be compressed, so the cache size will likely be significantly larger if this option is enabled.  However, performance may be improved depending on the use case.
Warning
Do not enable this option unless you are aware of these caveats:

If the resulting file is modified, the file in the cache will also be modified since they share content, which corrupts the cache entry. As of version 4.0, ccache makes stored and fetched object files read-only as a safety measure. Furthermore, a simple integrity check is made for cached object files by verifying that their sizes are correct. This means that mistakes like strip file.o or echo >file.o will be detected even if the object file is made writable, but a modification that doesn’t change the file size will not.

Programs that don’t expect that files from two different identical compilations are hard links to each other can fail.

Programs that rely on modification times (like make) can be confused if several users (or one user with several build trees) use the same cache directory. The reason for this is that the object files share i-nodes and therefore modification times. If file.o is in build tree A (hard-linked from the cache) and file.o then is produced by ccache in build tree B by hard-linking from the cache, the modification timestamp will be updated for file.o in build tree A as well. This can retrigger relinking in build tree A even though nothing really has changed.


fix: arm inject newline chars on windows

Reverts original newline replacement on Windows that was removed in https://github.com/arcus-azure/arcus.scripting/commit/f41369aed4ac1d4d1e8b445ef4ba85f03a1de2c2.
Harden the integration tests so we check for new line characters.
Closes #242

So the change has just been reverted, and the previous version has been set back ?

Yeah, for windows this has been reverted to the same thing we had before v0.5.

So the change has just been reverted, and the previous version has been set back ?

Yeah, for windows this has been reverted to the same thing we had before v0.5.

So we need a followup- PR then  or not ?

So the change has just been reverted, and the previous version has been set back ?

Yeah, for windows this has been reverted to the same thing we had before v0.5.

So we need a followup- PR then or not ?

No, no need, I reverted these changes in this PR.


Blender3.6 does not support HDRI as part of gltf export

Hi,
We exported .hdr environment texture into blender and added avatar to the scene.
But we r unable to export avatar + Environment texture as part of .gltf format.
I understand, as per the  link https://docs.blender.org/manual/en/latest/addons/import_export/scene_gltf2.html it supports only ambient occlusion maps Is there any way to convert hdri into occlusion maps. pls suggest
Thanks
vijay

I'm not familiar with Blender or the glTF-Blender-IO part.
Hopefully it's OK to go out on a limb and ping @echadwick-artist and @emackey here: Maybe you have an idea? Otherwise, this will have to be triaged and scheduled as part of the glTF-Blender-IO development process.

Hi @myinzack, currently most glTF assets don't contain their own environments (with a few rare exceptions), for a couple of reasons:

The size of the HDRI would increase the size of a glTF asset substantially.
Different engines need HDRIs in different (sometimes pre-convoluted) formats for optimal realtime rendering (for example Filament and BabylonJS have both shipped tools for preparing HDRIs in separate ways in the past).
A given model may move around between environments, and could potentially need multiple HDRIs at different points in the app's lifecycle, which is unknown to glTF.

For these and other reasons, glTF extensions that embed HDRIs directly inside glTF have not seen popularity and support beyond the prototype, proof-of-concept phase.

@myinzack could you please share a visual example of the kind of lighting effect you're trying to achieve?
Ambient occlusion and HDR lighting are two very different lighting effects. If you wish to apply a specific HDR onto the model, you could bake it into a glTF emissiveTexture, however this would be a static effect since it wouldn't change when the model rotates or deforms, and wouldn't affect reflections at all. A baked lightmap only emulates the lighting of completely rough surfaces.

Thanks @echadwick-artist for quick response...
The following is the HDRI lighting we are using as environment texture
we are trying to position avatar into a room with lighting and shadow effect as shown below

Any finally we need to render the scene from Babylonjs.

Babylon has some nice documentation on how folks can do this:
https://doc.babylonjs.com/features/featuresDeepDive/materials/using/HDREnvironment

If the environment is visible (not just a source of lighting) then it's often referred to as a skybox. In this case it looks like you're specifically looking for a ground-projected skybox, so that the character appears to be standing on something solid and can cast a shadow. See:
https://doc.babylonjs.com/features/featuresDeepDive/environment/skybox#ground-projection
As @emackey says though, this most be set up in babylon.js separately from loading the model, the skybox isn't something that can be exported from Blender to any standard file format.
You could also do something tricky like creating an inverted sphere around the character in Blender, putting an unlit material and texture on that sphere, and then in babylon.js keeping the camera within the sphere. But even in that case, you still need to add the HDRI separately to light the model.


fix: remove deprecated package storybook__addon-knobs.

The storybook addon knobs has been deprecated. That PR address build failures related to the error through during executing yarn install command
🐛 Bug Fix

Hi @iAndriy  Sorry just saw this PR. I sent out another PR to resolve the same issue https://github.com/apache-superset/superset-ui-plugins/pull/231

Close as duplicated of #231. Thank you for your contribution


Update Marathon RAML

Update Marathon RAML dependencies and align health checks with latest spec. The latest Marathon release includes the following fixes:

https://github.com/mesosphere/marathon/issues/4766
https://github.com/mesosphere/marathon/issues/4767

LGTM! ✨

@nLight @Poltergeist I've addressed all issues


Create longest_common_sequence.py

New task added

check this one

If you could write the documentation as is written in the other cases, I will be able to merge this

documentation added check again


Day 10 - Strings

Select the Day of Content
Day 10
What information is missing?
All about String

@subhadipbhowmik Pls assign this to me. Thank you


fix documentation

https://github.com/ibm-cds-labs/ibmseti#entropy-based-on-histogram-of-log-of-power
The title of the section should just read Entropy.
Also, the 'Bayseian Block' method shouldn't be encouraged here. First, it takes a significant time to compute, and secondly, it doesn't match well with an entropy calculator because it histograms the data in a way that increases the entropy by masking out some of the structure in a histogram. It's faster and more understandable to use a simple-spaced histogram.

fixed.


added self to sites.js

To add your site to the webring, you must be a current student or an alum of the undergraduate Software Engineering program at the University of Waterloo (Waterloo, ON, Canada).
Full Name: Max Lu
Cohort Year: 2027
Full website URL: https://redcx.ca/
So we know you're human: I am human
LinkedIn or a similar profile: https://osu.ppy.sh/users/14056601
Don't forget to also add your entry to the end of the allSites array in the sites.js file (name, year, personal website)!

added webring link to my site as well o7


How to implement auto-login after signup?

I cannot figure out how to automatically login after a user is signed up.

+1

I'm looking for the same thing. I was hoping using req.login after the user was created would work but I get an error of [Error: passport.initialize() middleware not in use]

I am also facing the exact same issue. Any workaround would be much appreciated.

@schartz i think this can be figured out somehow. will look at it in a while i am sure we can find a way.

Any progress on this one?


ERROR:tensorflow:Model diverged with loss = NaN during traning translation model

hi, I always get this  problem every time when tranning translation model with my own language pair. I have searched issues about "Model diverged with loss = NaN", but i did not got any idea, so I post a issue here.
here is my code. Thank you !
@registry.register_hparams('transformer_jack')
def transformer_jack():
    hparams = transformer_base_single_gpu()
    hparams.learning_rate_warmup_steps=4000
    hparams.learning_rate=0.01
    hparams.optimizer_adam_beta2=0.98
    hparams.initializer="normal_unit_scaling"
    return hparams

translate_mnzh.py:
FLAGS = tf.flags.FLAGS
EOS = text_encoder.EOS_ID

@registry.register_problem
class TranslateMnzhBpe32k(translate.TranslateProblem):
  @property
  def targeted_vocab_size(self):
    return 32000
  @property
  def source_vocab_name(self):
    return "vocab.32k.mn.txt"

  @property
  def target_vocab_name(self):
      return "vocab.32k.ch.txt"

  def feature_encoders(self, data_dir):
    source_vocab_filename = os.path.join(data_dir, self.source_vocab_name)
    target_vocab_filename = os.path.join(data_dir, self.target_vocab_name)
    source_encoder = text_encoder.TokenTextEncoder(source_vocab_filename, replace_oov="UNK")
    target_encoder = text_encoder.TokenTextEncoder(target_vocab_filename, replace_oov="UNK")
    return {"inputs": source_encoder, "targets": target_encoder}

  def generator(self, data_dir, tmp_dir, train):
    """Instance of token generator for the mn->zh task, training set."""
    dataset_path = ("train.32k"
                    if train else "valid.32k")
    train_path = os.path.join(data_dir, dataset_path)

    source_token_path = os.path.join(data_dir, self.source_vocab_name)
    target_token_path = os.path.join(data_dir, self.target_vocab_name)
    source_token_vocab = text_encoder.TokenTextEncoder(source_token_path, replace_oov="UNK")
    target_token_vocab = text_encoder.TokenTextEncoder(target_token_path, replace_oov="UNK")
    return translate.token_generator_by_source_target(train_path + ".mn", train_path + ".ch",
                                     source_token_vocab, target_token_vocab, EOS)

  @property
  def input_space_id(self):
    return problem.SpaceID.MN_BPE_TOK

  @property
  def target_space_id(self):
    return problem.SpaceID.ZH_BPE_TOK

error output:
ERROR:tensorflow:Model diverged with loss = NaN.
Traceback (most recent call last):
  File "/home/jack/tools/ana2/envs/tfgpu1.4-3.5/bin/t2t-trainer", line 4, in <module>
    __import__('pkg_resources').run_script('tensor2tensor==1.4.3', 't2t-trainer')
  File "/home/jack/.local/lib/python3.5/site-packages/pkg_resources/__init__.py", line 750, in run_script
    self.require(requires)[0].run_script(script_name, ns)
  File "/home/jack/.local/lib/python3.5/site-packages/pkg_resources/__init__.py", line 1527, in run_script
    exec(code, namespace, namespace)
  File "/home/jack/tools/ana2/envs/tfgpu1.4-3.5/lib/python3.5/site-packages/tensor2tensor-1.4.3-py3.5.egg/EGG-INFO/scripts/t2t-trainer", line 16, in <module>
    tf.app.run()
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/python/platform/app.py", line 124, in run
    _sys.exit(main(argv))
  File "/home/jack/tools/ana2/envs/tfgpu1.4-3.5/lib/python3.5/site-packages/tensor2tensor-1.4.3-py3.5.egg/EGG-INFO/scripts/t2t-trainer", line 12, in main
    t2t_trainer.main(argv)
  File "/home/jack/tools/ana2/envs/tfgpu1.4-3.5/lib/python3.5/site-packages/tensor2tensor-1.4.3-py3.5.egg/tensor2tensor/bin/t2t_trainer.py", line 271, in main
    execute_schedule(exp)
  File "/home/jack/tools/ana2/envs/tfgpu1.4-3.5/lib/python3.5/site-packages/tensor2tensor-1.4.3-py3.5.egg/tensor2tensor/bin/t2t_trainer.py", line 229, in execute_schedule
    getattr(exp, FLAGS.schedule)()
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/contrib/framework/python/framework/experimental.py", line 64, in new_func
    return func(*args, **kwargs)
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/contrib/learn/python/learn/experiment.py", line 770, in continuous_train_and_eval
    saving_listeners=self._saving_listeners)
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/contrib/learn/python/learn/experiment.py", line 868, in _call_train
    saving_listeners=saving_listeners)
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/python/estimator/estimator.py", line 314, in train
    loss = self._train_model(input_fn, hooks, saving_listeners)
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/python/estimator/estimator.py", line 815, in _train_model
    _, loss = mon_sess.run([estimator_spec.train_op, estimator_spec.loss])
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/python/training/monitored_session.py", line 539, in run
    run_metadata=run_metadata)
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/python/training/monitored_session.py", line 1013, in run
    run_metadata=run_metadata)
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/python/training/monitored_session.py", line 1104, in run
    raise six.reraise(*original_exc_info)
  File "/home/jack/.local/lib/python3.5/site-packages/six.py", line 693, in reraise
    raise value
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/python/training/monitored_session.py", line 1089, in run
    return self._sess.run(*args, **kwargs)
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/python/training/monitored_session.py", line 1169, in run
    run_metadata=run_metadata))
  File "/home/jack/.local/lib/python3.5/site-packages/tensorflow/python/training/basic_session_run_hooks.py", line 605, in after_run
    raise NanLossDuringTrainingError
tensorflow.python.training.basic_session_run_hooks.NanLossDuringTrainingError: NaN loss during training.

When training on GPU, the error "Model diverged with loss = NaN" is often caused by a sotmax that's getting a symbol larger than vocab_size. Please train on CPU for a few steps, the error message is much better. I suspect that in your data there are symbols larger than the vocab_size the model is getting (so larger than the softmax you create).

Thank you @lukaszkaiser, I got the vocabulary from training set on my own. What is the "symbol" related to vocab_size ? Is it necessary to  configure it in my code ? Do we have to generate vocabulary on our own ? Is it possible for t2t to help us generate the vocabulary?

@lukaszkaiser . I suffer the same result when I set the OOV index that never larger than the vocab_size. Do you have any other findings to illustrate the problem ?

thanks @lukaszkaiser . I got the same error when pre-training bert. It turns out that the size of vocab.txt is larger than the param 'vocab_size' passed to the model.


high scores page

I started a handler for returning high scores here:
https://github.com/gojp/goreportcard/blob/master/handlers/high_scores.go
We should add a view :pager:  (or maybe multiple views since this one is just for repos > 100 files)

Added a view here: http://goreportcard.com/high_scores/
It doesn't look very nice though :baby:


Could not find file 'C:\Program Files (x86)\IIS Express*.*'

Hi, I met below problem while running this example. Can anyone give me a hint ?
An error occurred while processing your request: Could not find file 'C:\Program Files (x86)\IIS Express\ascii.gif'.
Stack Trace
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath) at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost) at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access) at Microsoft.WindowsAzure.Storage.Blob.CloudBlockBlob.BeginUploadFromFile(String path, FileMode mode, AccessCondition accessCondition, BlobRequestOptions options, OperationContext operationContext, AsyncCallback callback, Object state) in c:\Program Files (x86)\Jenkins\workspace\release_dotnet_master\Lib\ClassLibraryCommon\Blob\CloudBlockBlob.cs:line 837 at Microsoft.WindowsAzure.Storage.Blob.CloudBlockBlob.BeginUploadFromFile(String path, FileMode mode, AsyncCallback callback, Object state) in c:\Program Files (x86)\Jenkins\workspace\release_dotnet_master\Lib\ClassLibraryCommon\Blob\CloudBlockBlob.cs:line 818 at Microsoft.WindowsAzure.Storage.Core.Util.AsyncExtensions.TaskFromVoidApm[T1,T2](Func5 beginMethod, Action1 endMethod, T1 arg1, T2 arg2, CancellationToken cancellationToken) in c:\Program Files (x86)\Jenkins\workspace\release_dotnet_master\Lib\ClassLibraryCommon\Core\Util\AsyncExtensions.cs:line 192 at Microsoft.WindowsAzure.Storage.Blob.CloudBlockBlob.UploadFromFileAsync(String path, FileMode mode, CancellationToken cancellationToken) in c:\Program Files (x86)\Jenkins\workspace\release_dotnet_master\Lib\ClassLibraryCommon\Blob\CloudBlockBlob.cs:line 922 at Microsoft.WindowsAzure.Storage.Blob.CloudBlockBlob.UploadFromFileAsync(String path, FileMode mode) in c:\Program Files (x86)\Jenkins\workspace\release_dotnet_master\Lib\ClassLibraryCommon\Blob\CloudBlockBlob.cs:line 909 at WebApp_Storage_DotNet.Controllers.HomeController.d__4.MoveNext() in D:\WorkSpace\NetProjects\CrossPlatform\storage-blobs-dotnet-webapp-master\WebApp-Storage-DotNet\Controllers\HomeController.cs:line 114

I solved this issue by using object <HttpPostedFileBase> and function <UploadFromStreamAsync> in file HomeController.cs function public async Task UpdateAsync

It's been a year and a half and this issue still exists. Does anyone maintain these projects?

Instead of:
CloudBlockBlob blob = blobContainer.GetBlockBlobReference(GetRandomBlobName(files[i].FileName)); await blob.UploadFromFileAsync(files[i].FileName, FileMode.Open);
Try:
var source = files[i].InputStream; CloudBlockBlob blob = blobContainer.GetBlockBlobReference(GetRandomBlobName(files[i].FileName)); await blob.UploadFromStreamAsync(source);

Someone has also created a PR to fix this issue: https://github.com/Azure-Samples/storage-blobs-dotnet-webapp/pull/10


[geyser] s/shread/shred/ in SlotStatus

Problem
The enum label for ‘first shred received’ is spelled correctly, but the value is not.
Summary of Changes
first_shread_received => first_shred_received

Does this have downstream implications – ie. could someone be relying on the enum value in such a way that this change would break them?


Add mutation to update Existing Facility to the facilitiesStore

Problem
We need to have the function to update the facility in the store and we currently do not have it.
Success
The mutation to update a facility is added to the facilitiesStore.
Requirements

[ ] Add mutation to the store

Tests for this will be added in #803. Mock functionality for graphQL in Nuxt still needs to be researched and implemented


Explain meaning of author_full_name field in Secondary index documentation

In the eqJoin example of the compound index section of http://www.rethinkdb.com/docs/secondary-indexes/javascript/#compound-indexes we use a field called "author_full_name" in the "posts" table.
For someone who isn't familiar with how eqJoin works, it might not be clear that "author_full_name" is just the name of a field. A user on Slack assumed that it was the name of a second compound index for example, and was wondering what that index was containing.
We should explain above the example that the documents in the posts table have a field called author_full_name and that we assume that it contains the names of the posts' authors in the form [last_name, first_name].

Or provide sample data in the example that reflect the data used (e.g. posts.author_full_name).


Fixes #13 - Schema of home page in React - Azin

Description
I have deleted all extra pages except for home page for this step as you suggested , I also Used React Icon Package instead of inserting several png files.
Css for this page is also responsive , for smaller device I will add Media Query later if it was needed
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have carefully reviewed my own code
[ ] I have commented my code
[ ] I have updated any documentation

Sorry, I'm might be misreading your description. This PR still includes all the new pages and components as well as the various png and svg files? Is that a mistake?

Sorry, I'm might be misreading your description. This PR still includes all the new pages and components as well as the various png and svg files? Is that a mistake?

you are right I'm so sorry I thought as I deleted the file they will be deleted on the branch It seems I have to deleted them in terminal as well ,Im on it

I posted some review comments above.
Also will you close your other PR #11?

I posted some review comments above.
Sorry I couldn't find any review on the code ,except for suggesting to take this issue back to draft if it is still in progress,as a schema of home page I think its done so I moved it to that section ,not sure if it was right !
can you guide me about where can I check your review

Also will you close your other PR #11?
I closed PR#11

The review is visible above in this thread or on the lines of code on Files changed tab.

The review is visible above in this thread or on the lines of code on Files changed tab.

I can see them now ,thanks

Sorry, review had not been posted - it was still pending as a draft.


Tab Complete Greek Letters using Tex Syntax

Feature: Notebook Editor, Interactive Window, Python Editor cells

Description
A big QOL feature that could be added for math/science/engineering users would be to be able to tab-complete greek letters via Intellisense as found in Jupyter Labs and Julia. I imagine this wouldn't be a large technical challenge, so this would be a great feature to add.
Microsoft Data Science for VS Code Engineering Team: @rchiodo, @IanMatthewHuff, @DavidKutu, @DonJayamanne, @greazer, @joyceerhl

No plans to add the feature yet? For scientists this is a great plus,


DaVinci om model can not be recognized

Steps to Reproduce:
1.when I open hiai_noaipp.om model on latest Netron code, the .om model can not be recognized.
hiai_noaipp.om.zip
2.review  the  code, source/app.js should add om in 176 line, and source/index.html should add .om in 364 line.

Would it make sense to discontinue the OM format and use a standard format like .onnx or .pb? Supporting these formats creates overhead and they provide little value.

Duplicate of #786


Switch from absolute to configurable path

Switch from absolute to configurable script path (net.srse.ps.daas.scripts\src\Process-Jobs.ps1)
Order.Tests.ps1 (Line 294)

@rufer if we have a reference from this module to a DaaS module the test should be in the other module and not here. pls consider to refactoring moving it to the other module

@dfch ok, I'll do that soon


Refactor controller logic

Common actions such as deep-cloning the resource and update
them are now performed by the controller wich results in
clean handlers

@astefanutti ready for review


DIP: Multi-agent Transactions

Currently in the Diem Framework, a transaction acts on behalf of a single on-chain account. However, there is no mechanism for multiple on-chain accounts to agree on a single atomic transaction. This DIP presents a new scheme of transactions--multi-agent transactions--which act on behalf of multiple on-chain accounts. Multi-agent transactions leverage Move’s signer type to allow essentially any arbitrary atomic actions in one transaction involving multiple on-chain accounts.
DIP PR here: https://github.com/diem/dip/pull/159

I'll be happy to be the DIP manager for this.

@aching this might be ready to merge in Draft stage?

Definitely, just was waiting for the PR to stabilize.

There was great discussion in the draft stage and seems that there are no objections in the last 20 days.  Proposing to move this to "Last Call".

https://github.com/diem/dip/pull/181


Support for PiZeroW - build opt. for ARM6

Is your feature request related to a problem? Please describe.
'illegal instruction' when running raspindi on piZeroW
Describe the solution you'd like
build opt. for PiZeroW to support addition Pi models
Describe alternatives you've considered
Not using PiZero : -)  - It's possible the single core won't be up to the task, but it stills has GPU and v2.0x is making full use to hopeful of 1280x720 @ 25fps is possible
Additional context

This could be interesting. My initial thinking is I'm not sure how well the network would hold up, as it's wireless only, but it might work for a lower bandwidth stream.
My Pi Zero is in another project at the moment, but if/when I can free it up I'll have a look at this. I think the hardware is supported by NDI (which will be the limiting factor, as they're pre-packaged libraries). If you want to give it a go then you can download the embedded SDK and copy the correct library into the lib folder. (arm-rpi1-linux-gnueabihf).

Thanks Richard - I’ll try. On the network point I share the concern - for ref have m3b+ running with PoE (720p @ 30fps) and m4 over Wi-fi (1080p @ 30fps) both glitch free. Quietly confident the PiZero could handle the streaming. I’ll report back.

I would guess for that one you might be better going back to v1.1.1, which used the rapsicam library rather than mmal directly.

I now have a Pi Zero W spare, so I will probably have a look in the week next week.
I'll let you know how I get on.

I've had a look at this. It looks like the Pi Zero W just doesn't have enough memory to do this; the malloc error occurs in MMAL regardless. I don't have the programming knowledge to debug right into the MMAL code.
For now, I think the Zero W is just unsupportable for this. If someone wants to dig further into it, feel free!


RFC: Do not prune out unnecessary columns with unqualified references

Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/617 but I am still not sure if this is a bug or not (explained below)
Rationale for this change
As explained on https://github.com/apache/arrow-datafusion/issues/617 the projection pushdown operation removes  columns from a scan when the LogicalPlan::Projection had unqualified columns (so an expression like a, rather than table.a).
In my case in IOx this was occuring due to an extension node, when my code was creating the exprs without qualifiers. When I updated to the code to create the expression with qualifiers things are fine again
         let exprs = input
             .schema()
             .fields()
             .iter()
-            .map(|field| logical_plan::col(field.name()))
+            .map(|field| Expr::Column(field.qualified_column()))
             .collect::<Vec<_>>();

Thus I am not sure if the projection pushdown code should actually handle this case, or if we should have some sort of error / warning instead. Having it silently produce the wrong answer (which is what happened in IOx) was hard to debug
What changes are included in this PR?

Only check relational qualifier if there a relational qualifier on the expression, otherwise just check field name
Ensure no duplicate field names by using BTreeSet

Are there any user-facing changes?
No

FYI @houqp


I must init tag firstly, is that right?

I must init tag firstly, is that right?
Logger.init("TAG");
Or, I will get exception of java.lang.NullPointerException

Actually it shouldn't be necessary but recent changes made init as dependency. You need to call init() or init(TAG). But I'll make a fix to change this dependency.

Got it, thanks very much.
I think we need give a prompt for novice(like me) , or I think some one will always got exceptions after only try logger.

I'll add it to readme file to avoid confusion. thanks for the feedback

Thanks very much~
On 19 October 2015 at 08:36, Orhan Obut<EMAIL_ADDRESS>wrote:

I'll add it to readme file to avoid confusion. thanks for the feedback
—
Reply to this email directly or view it on GitHub
https://github.com/orhanobut/logger/issues/50#issuecomment-149127807.

@xinmeng1 with 2.0 it's required to init with new adapter approach.


[Feature Request] I hope you can customize the tabs header information.

Existing Component
是
Component Name
tabs
Description
I want to be able to customize the contents of the tab. With slot='label', there is no way to control the display of DOM by variables.

pr welcomed


only execute callback once per key for eachAttribute

Hello, I just noticed something I consider a bug, but not sure if it's actually a bug, or intended.
When MegamorphicModel.eachAttribute is called, the callback is executed more than once per key if its on multiple "buckets" i.e. this._attributes and this._data

@hjdivad sure thing!! added :)

thanks @betocantu93!

released as 3.0.7


Create conventions

[x] Find source to fork
[ ] Create first version of conventions

I found nice source for our guides developing: https://github.com/ViRGiL175/android-guidelines
First of all we need to rewrite part about ugly "_m" members and add Git part.


CLPM.CLPM version 0.4.2-rc.2

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.5 schema?

Ideally, the clpm-0.4.2-rc.2-windows-amd64 subdirectory of the zip could be extracted to the installation directory, but that's not currently supported.
Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-Executable-Error


the days of a week

hello, thanks for jalali-moment, is it possible to print out the days of a week? for example, شنبه ۱۲ تیر ۹۹

Hello, jalali-moment is a plugin for moment.js so if you can format it in moment.js you would be able do the same with jalali-moment
jMoment().locale('fa').format('dddd DD MMM YY')


Update dependency docker to v24.0.7-1~ubuntu.22.04~jammy

This PR contains the following updates:

Package
Update
Change

docker
patch
24.0.6-1~ubuntu.22.04~jammy -> 24.0.7-1~ubuntu.22.04~jammy

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
Because you closed this PR without merging, Renovate will ignore this update (24.0.7-1~ubuntu.22.04~jammy). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Windows instructions for new device don't currently work

The Windows instructions for the Edison ask the user to download the Windows drivers for Edison, but the link is broken, and I could not find another source for the drivers. Does it make sense to change the directions to use the Flash Lite tool? It might be possible to unify these instructions across Windows, Mac, and Linux if that tool works across the board

I have never used the Edison on Windows. These instructions were here long before I started on the Edison. Maybe @agherzan or @telphan remember about these?

@zwalchuk this link should be good:
https://downloadmirror.intel.com/26993/eng/IntelEdisonDriverSetup1.2.1.exe


BDX TransferSession spec implementation

Problem
The Bulk Data Transfer spec needs to be implemented. There should be an API for beginning and managing a single transfer session, which enforces the rules of the spec.
Summary of Changes

Add a TransferSession class which provides methods for beginning and managing a transfer session.
Add test file with at least one case that tests a full session from beginning to end.
some small changes to enum naming in BdxMessages.h

Fixes #3423

Deferring to @tcarmelveilleux for final approval/merge


ENH: Added Python virtualenv support to superbuild

Also updated README file instructions for Ubuntu

@dmwelch Does this patch now require that python have a virtual environment?  Will it still work with a non-virtual environment install of python?

No, this does not require a virtualenv
Sent from my iPhone
On Apr 10, 2015, at 10:52 AM, Hans Johnson <notifications<EMAIL_ADDRESS>wrote:
@dmwelchhttps://github.com/dmwelch Does this patch now require that python have a virtual environment? Will it still work with a non-virtual environment install of python?
—
Reply to this email directly or view it on GitHubhttps://github.com/BRAINSia/BRAINSTools/pull/184#issuecomment-91598785.

Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.


Port NatssChannel to cloudevents/sdk-go bindings

Problem
Now the NatssChannel dispatcher uses the Client APIs of cloudevents/sdk-go
Exit Criteria
NatssChannel dispatcher uses only the bindings APIs of cloudevents/sdk-go
Time Estimate (optional):
1 week
Additional context (optional)
The new bindings API are designed to improve cpu/memory efficiency for transporting events.
You can use the KafkaChannel port as example: https://github.com/knative/eventing-contrib/pull/1039
/help-wanted
/good-first-issue

/assign

Stan binding implemented https://github.com/cloudevents/sdk-go/pull/322.
This issue needs an sdk-go release and then it's ready.

@pierDipi https://github.com/cloudevents/sdk-go/releases/tag/v2.0.0-prevew7

@n3wscott @slinkydeveloper https://github.com/knative/eventing/pull/2829
As a side note, the release name is mistyped

@slinkydeveloper @n3wscott https://github.com/knative/eventing-contrib/pull/1072


Add Stylelint

Stylelint should be added to catch CSS lint issues. This should be added to npm test to check CSS in PRs automatically.

To address comments raised in #103

Recommended config: stylelint/stylelint-config-recommended


How to think about nodes for the LinkedList assignment

This might help for people struggling with the LinkedList assignment. Think a LinkedList as a chain of Nodes.
class Node(object):
    def __init__(self, elem, next=None):
        self.elem = elem
        self.next = next

# We want to create the following list: [5, 1, 3]
# We first create the individual nodes:
n5 = Node(5)
n1 = Node(1)
n3 = Node(1)

# Now we connect them:
n5.next = n1
n1.next = n3

# Let's iterate over the "list" and print all the elements:
current_node = n5  # The starting node
while current_node is not None:
    print(current_node.elem)
    current_node = current_node.next  # Here's the key

That's it! Basically, the LinkedList would be a shell hiding all that that I've done.
Let's think about a way to append a new node to our "list". We want to append the elem 7:
last_node = n5  # The starting node
while last_node.next is not None:
    last_node = last_node.next

last_node.next = Node(7)

Thanks @santiagobasulto !
n3 = Node(1) should be n3 = Node(3) right ?

Yes, thanks @andreshazard, fixed.

Thanks for this tip, this helped a bunch. However, now I'm really lost. The Unittest seems to check things that aren't reflected in the UnitTests at all, as well.
I'm right now at the point where adding and extending "works": the it does what the exercise asks, e.g.:
I've written a function that returns all nodes in a list:
    def return_all(self):
        if self.start is None:
            return []
        self.current = self.start
        a_list = [self.current.elem]
        while self.current.next is not None:
            a_list.append(self.current.next.elem)
            self.current = self.current.next
        return a_list

Then using that, the following tests and results show:
old_list = LinkedList()
old_list.append(1)
new_list = old_list + [2, 3]

>>> new_list.return_all()
[1, 2, 3]
>>> old_list.return_all()
[1]

but:
>>> new_list
<__main__.LinkedList object at 0x00000000029C5EB8>
>>> old_list
<__main__.LinkedList object at 0x00000000029C5D68>

Concerning the last 4 lines, I understand from the UnitTest that these two instances should have the same unique code. I don't understand at all how to achieve this. Headaches.


0.9.1 hotfix release

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

[ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[ ] Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue in the Development Section on the right hand side.
[ ] Address all merge conflicts and resolve appropriately
[ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

@bundfussr @zdz2101 @sadchla-codes @thomas-neitmann Did we merge this hotfix into devel?  I feel like we did :( I was reviewing another PR and saw that news was missing 9.1 :(

Yea it looks like we might've missed the main into devel part after the successful submission to CRAN


fix: add support for templates

so we can populate secrets using templates from other secrets which is
useful for things like maven settings XML or docker config.json files

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jstrachan
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jstrachan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[opendistro-1.11][backport] Update checkNullElementsInArray() unit test to check both error mes…

…sage and error code instead of only checking the error code (#1370)
(cherry picked from commit 0a2916b171510195879fcfc9b6b437813309def1)
opensearch-security pull request intake form
Please provide as much details as possible to get feedback/acceptance on your PR quickly

Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Github Issue # or road-map entry, if available:

Description of changes:

Why these changes are required?

What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

Is it backport from main branch? (If yes, please add backport PR # and commits #)

By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #1424 (54ed2c4) into opendistro-1.11 (7840f9f) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             opendistro-1.11    #1424      +/-   ##
=====================================================
- Coverage              64.22%   64.20%   -0.03%
+ Complexity              3195     3194       -1
=====================================================
  Files                    241      241
  Lines                  16965    16965
  Branches                3044     3044
=====================================================
- Hits                   10896    10892       -4
- Misses                  4513     4518       +5
+ Partials                1556     1555       -1

Impacted Files
Coverage Δ

...ecurity/configuration/StaticResourceException.java
0.00% <0.00%> (-25.00%)
:arrow_down:

...csearch/security/dlic/rest/api/AuditApiAction.java
63.82% <0.00%> (-4.26%)
:arrow_down:

...asticsearch/security/support/ReflectionHelper.java
47.58% <0.00%> (-2.07%)
:arrow_down:

...security/configuration/DlsFlsFilterLeafReader.java
58.91% <0.00%> (+0.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7840f9f...54ed2c4. Read the comment docs.


feat(bounty): add empty state when it's a internal chrome page

Related to
Bounty Hunter Challenge
Context
Add a new state in the Extension when the user is on an "internal" Chrome page, for example, chrome://new-tab-page.

Thank you for your contribution @crocodile-bounty-hunter.
Can you match this style?

Thanks in advance.

Thank you for your contribution @crocodile-bounty-hunter.

Sure @ricardofelgueiras, I hope it match with the requirements :)

@crocodile-bounty-hunter thank you once more for your contribution.
Once you solved one of the bounties, you're entitled to a 20$ reward. For us to proceed with the payment, please send me your details to<EMAIL_ADDRESS>Thanks.


Cleaning up package build process and bug with registry page

Two parts to this ticket.
Part 1: Install nx monorepo
Part 2: With a cleaner package setup fix the bug when you view a registry (screenshot below)
Part 1 - Install nx monorepo

Get this project setup using https://nx.dev/
Clear up all the build errors when building the packages

Part 2 - Fix the bug with the registry view
Once the packages are building much nicer this might already fix the issue with the registry page. To access the registry follow these steps:

Login
Create a registry
Click on the created registry
Error will show here on the registry page

Can you assign this to me?

The bug fix for the null context is here: https://github.com/akello-io/akello/pull/178

@vselvarajijay
Can I also take a dive at this?


Module 1.1 Assignment

Given what you have learned about Git, why would you want to use Git in your classroom?

👋 Hi @junta-m you are missing your answer for the question above. Please post it here in this thread.

I am teaching numerical calculation class with programming exercises in my university. I expect Git helps students to learn programming since it can show processes of making codes with its commands. I'd like to use git in my classroom,  and github classroom too. I think the recent way of developing software using github is very similar to educational process and gives teachers and students one of the ideal educational environments.


feat(module): implement CSS variables to control rounded radius

ffs, fat-fingered VSCode's Create PR 🙄

Are you working on it? 🤩


hierarchical comparsions

Hi,
The following were excerpted from  cellphonedb's documentation:
METHOD 3 degs_analysis (>= v3): This method is proposed as an alternative to the statistical inference approach. This approach allows the user to design more complex comparisons to retrieve interactions specific to a cell type of interest. This is particularly relevant when your research question goes beyond comparing “one” cell type vs “the rest”. Examples of alternative contrasts are hierarchical comparisons (e.g. you are interested in a specific lineage, such epithelial cells, and wish to identify the genes changing their expression within this lineage).
Could you explain what is "hierarchical comparisons", I cannot find literatures on this term. Is it related to hierarchical clustering ?

Hi @wangjiawen2013 ,
By hierarchical comparison we refer to any comparison between clusters that can be organised by a hierarchy or groups. Hierarchical clustering could be a potential way of organising your clusters, but here we refer to a more general and simple classification.
An example when you may have your clusters organised by groups/hierarchy is the following: imagine that you have three cell types (A, B and C) which states change between two conditions (health and disease): A-healthy, A-disease, B-healthy, B-disease, C-healthy, C-disease. Depending on your research question, you might wish to group (and compare) your cells as healthy(A,B,C) & disease(A,B,C) or A(healthy,disease) B(healthy,disease) & C(healthy,disease).

Scenario 1, you are interested on how A changes between healthy and disease, you then compare A-healthy vs A-disease.
Scenario 2, you are interested on how A-B-C change within the disease group only. Here you compare A-disease vs B-disease vs C-disease.
Scenario 3, you are interested on what is specific to any cluster, independently on any hierarchy/grouping.  Here you then compare A-healthy vs rest (A-disease + B-healthy + B-disease + C-healthy + C-disease), etc.

With CellphoneDB method 3 relying on differentially expressed genes, the user can organise their comparisons in a more complex way (like scenarios 1-2). CellphoneDB method 2 would instead perform scenario 3 and compare one vs all the rest.
Hope this helps.
Best
Luz


Added support for weather station measurements

Hi,
I added support for weather station measurements. This time I made sure to specify all units. If ok please merge and @Qwerios it would be nice if you could update the NPM.
Kind regards,
Daan

Published schemas version 0.0.14


Bump metro dependencies

Would it be possible to bump the version of metro dependencies in next release ?
We're currently evaluating upgrade to RN 59 (using RC 3 as of now) for one of our application, and we faced a new error during bundling. After taking a closer look we realized that we were running into a metro bug, related to assets path resolution, that was fixed in Metro 0.52.0 (https://github.com/facebook/metro/commit/ce6824ced730d4aa6c4b63c007ed915e1180c258).
Manually updated cli metro dependencies locally to give it a try, and bundling issue was gone.
Thanks.

Yup we shuold bump it, even though it's possibly breaking change (0.59 is the first public version this CLI is used in). Want to send a PR?


Adds solutions for 19.Remove Nth Node From End of List, 36.Valid Sudoku and 141.Linked List Cycle in Kotlin

File(s) Modified: 19-Remove-Nth-Node-From-End-of-List.kt,36-Valid-Sudoku.kt,141-Linked-List-Cycle.kt
Language(s) Used: Kotlin
Submission URL: https://leetcode.com/submissions/detail/766335663/ , https://leetcode.com/submissions/detail/766341005/ , https://leetcode.com/submissions/detail/766336552/

Thanks, @t3chkid!


fix(CI): skip v4 check in this workflow

Description
These images are built in a separate workflow which can fail so scanning them here is not optimal. ref: https://redhat-internal.slack.com/archives/CLUNQEEMA/p1717611701252899
Note: scanner v2 checks here are OK because the v2 images are copied in this workflow and will exist before the check is tried.
Checklist

[ ] Investigated and inspected CI test results

Testing Performed
Here I tell how I validated my change
CI
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

Noting that we can add these checks in scanner-build.yaml if we still want them


Bug: Banner Breaks Navbar Location

Looks like an issue with the padding on the banner
Recommended Solution to Explore: Set Banner Container to position: relative so that it floats at the top at all times
Also on mobile, this message should shrink so use mediaQuery to reduce text size (if needed)

Bugs fixed here: manuelbarbas/bug/banner


CRM457-2221: Load more from the app store

Description of change

Clear our the old batch-sync logic
Load submitted claim lists by calling the app store search endpoint
Load PA application details view from app store, not local DB

(To make this work with UI elements designed for db-backed models, create a bunch of presenters that mirror the basic API of activerecord objects)

Link to relevant ticket

@patrick-laa I approved this but is this PR just for that one case or are you going to implement everything under this PR?

are you going to implement everything under this PR?

@elken I think I'll do it all as one gulp, as I'm nearly there now anyway. So do feel free to clear and I'll flag up when the whole thing is ready to go.


Create performance test

From martin.grotzke on October 25, 2009 01:26:22
A performance test that shows the difference of tomcat with and w/o the msm
in terms of response time/throughput.
Original issue: http://code.google.com/p/memcached-session-manager/issues/detail?id=22

From martin.grotzke on October 27, 2009 09:20:24
The results are interesting for Christian:
http://groups.google.com/group/memcached/browse_thread/thread/1815b6015c0da69f


Improved the theme as assigned

Improved the theme both (light and dark) and made changes in darkmodebutton and index css files. I'm committing changes directly to main branch.
Creating a pull request, hope it merges.

Deploy it Once again @Arman-ali-khan-786 so we can see the changes in effect.


fix: correct types in client_context.ex

These incorrect types were causing dialyzer to fail in our consuming application code that had a case statement on the return value of from_configuration_worker/3.

Thanks @dustinfarris ❤

Pull Request Test Coverage Report for Build 227
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.09%) to 91.904%

Files with Coverage Reduction
New Missed Lines
%

src/oidcc_provider_configuration_worker.erl
1
95.35%

Totals

Change from base Build 203:
-0.09%

Covered Lines:
1067

Relevant Lines:
1161

💛  - Coveralls


spyder crashes on start (py3.5amd64, win10)

spyder doesn't load. It crashes during the startup. A OS window says "Python has stopped working".
What steps will reproduce the problem?

pip install spyder
spyder

Versions and main components

Spyder Version: 3.0.0
Python Version: 3.5.2
Operating system: Win10 (64bits)

Reboot the machine solved the problem :)


Dependency tooltips with term signature

When hovering over the usage of a dependency in source code, the name and signature of that term should show.

Design Update

We'll forgo the backend requirement, but doing a request on hover to the /getDefinition endpoint.

This can technically be done with the /getDefinition endpoint, but a cleaner solution would be to use a dedicated summary endpoint and support the idea of summaries of definition as a whole.

We need a notion of a definition summary to be able to do this for types and abilities (tracked here: https://github.com/unisonweb/unison/issues/2175)

If possible, I think that it would be great to have the similar functionality for local variable references. And additionally if it could highlight the variable declaration, that would be 🔥.


support os.CreateTemp internally using os.TempDir() in some cases

You could check for os.CreateTemp using empty string as first parameter, will lead to call os.TempDir(), so it can be replaced by t.TmpDir
https://cs.opensource.google/go/go/+/refs/tags/go1.23.3:src/os/tempfile.go;l=35-38
I identified it by working on

https://github.com/supitsdu/clipper/pull/17#discussion_r1651958704

I added myself a TODO to check if I could do it later, but I didn't.
The pattern is widely used
https://github.com/search?q=language%3Ago+"os.CreateTemp(\"\""+path%3A_test.go&type=code

I already think about that.
The approach that just detects all os.CreateTemp will lead to false positives.
So the cases should be exact to be accurate.
I have some ideas around that, but not for this first version.


Various UI/UX issues while viewing certain Runs

go to https://cryoetdataportal.czscience.com/runs/1880
click on the download button
attempt to click on "Download Tomogram" but it is disabled (maybe this is intentional?)
attempt to click on the arrow to collapse the info box but it doesn't work
go to the next step and switch to the api tab
there is no voxel spacing id to copy

https://github.com/chanzuckerberg/cryoet-data-portal/assets/29165011/3bdf9360-b7b9-454b-b724-945920ee9f55

closing as this has been fixed. download tomogram is greyed out when there aren't tomograms present


Android crash when trying to sign in through Facebook when Firebase is initialised manually

Please fill in the following fields:
Unity editor version: 2017.4.32f
Firebase Unity SDK version: 6.4.0
Firebase plugins in use: Auth
Additional SDKs you are using: Facebook v7.17.2
Platform you are using the Unity editor on: Windows
Platform you are targeting: Android
Please describe the issue here:
On device, the app crashes when trying to sign in a user with Facebook auth provider.
The crash only occurs when manually initialising Firebase.
Pre-conditions

Firebase app configured to accept facebook sign in
Facebook app configured to let firebase handle OAuth

Steps

Launch the app
Sign in with Facebook
Wait to be logged in
Try to sign in with Firebase using Facebook
BOOM

In the editor, following these steps works perfectly fine. I can see the user has been added to the users in the firebase app with the right provider.
Logcat output:

09-07 10:49:56.528  5165  5195 E firebase: app != nullptr
09-07 10:49:56.530  5165  5195 E CRASH   : signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000000
09-07 10:49:56.530  5165  5195 E CRASH   : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***

I am not using Firebase.FirebaseApp.DefaultInstance instead I am initialising Firebase myself as follows:
[SerializeField]
private TextAsset _firebaseConfigFile;

private Firebase.Auth.FirebaseAuth CreateAuth()
{
    var firebaseOptions = Firebase.AppOptions.LoadFromJsonConfig(_firebaseConfigFile.text);
    var mainFirebaseApp = Firebase.FirebaseApp.Create(firebaseOptions, "main_app");
    return Firebase.Auth.FirebaseAuth.GetAuth(mainFirebaseApp);
}

_firebaseConfigFile is assigned the json config file downloaded from my Firebase app.
Note
On device, I can signin/signup a user with email and password without a problem.
Please answer the following, if applicable:
Yes, I have been able to reproduce the issue with the test app.

Hi part22,
I think the issue your hitting is that FirebaseApp is getting disposed due to being in a temp variable and thus the auth object is in an invalid state. Keep the app object alive and see if that fixes your issue.

Hi @markchandler-google,
Thanks for your answer.
I have already tried somehting similar (see code below) for the same reason you have mentioned. Unfortunately, I have had the same problem.
In that scenario the code looked like:
[SerializeField]
private TextAsset _firebaseConfigFile;

private Firebase.FirebaseApp _mainFirebaseApp;
private Firebase.Auth.FirebaseAuth _auth;

private void InitAuth()
{
    var firebaseOptions = Firebase.AppOptions.LoadFromJsonConfig(_firebaseConfigFile.text);
    _mainFirebaseApp = Firebase.FirebaseApp.Create(firebaseOptions, "main_app");
    _auth = Firebase.Auth.FirebaseAuth.GetAuth(mainFirebaseApp);
}

Since you can repo this with the sample app are you able to create a gist of the code and config so I can reproduce the issue?

With help from @stewartmiles looks like that for android the default instance of the app must always exist due to logic grabbing the Jni Environment pointer: https://github.com/firebase/firebase-cpp-sdk/blob/master/auth/src/android/credential_android.cc#L315
I will put a bug in for this but for now you can fix the crash by creating the default instance of app and holding onto it in your code.

Hi all,
This issue should be resolved in the new version of the Unity SDK, 6.6.0, available at https://firebase.google.com/download/unity
Thanks for bringing this issue to our attention!


use the hardware python modle for hardware discovery

thanks; there are a couple of packages that will need to be manually installed from brew and epel since they're not available in the normal RHEL repos. But, I'll fix that after merging.


Improve Acoustic performance

Description
Enhance performance when using acoustic sources by:

Pre-calculating the spatial components of source strengths before the main time loops
Skipping the calculations for spatial locations far from the acoustic source supports

The performance improvement increases as the resolution increases. For the 3D_acoustic_support11 example (99^3 resolution), there is a 96% reduction in computational time for acoustic subroutines ('cuda_gpu_kern_sum' stats report).
Type of change

[x] Performance improvement

Scope

[x] This PR comprises a set of related changes with a common goal

How Has This Been Tested?
Passed all test suites locally on CPU and GPU. Performance reports attached.
Checklist

[x] I have added comments for the new code
[x] I added Doxygen docstrings to the new code
[x] I have made corresponding changes to the documentation (docs/)
[x] I have added regression tests to the test suite so that people can verify in the future that the feature is behaving as expected
[x] I have added example cases in examples/ that demonstrate my new feature performing as expected.
They run to completion and demonstrate "interesting physics"
[x] I ran ./mfc.sh format before committing my code
[x] New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled (only NVHPC)
[x] This PR does not introduce any repeated code (it follows the DRY principle)
[x] I cannot think of a way to condense this code and reduce any introduced additional line count

If your code changes any code source files (anything in src/simulation)
To make sure the code is performing as expected on GPU devices, I have:

[x] Checked that the code compiles using NVHPC compilers
[ ] Checked that the code compiles using CRAY compilers
[ ] Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results)
[ ] Ran the code on MI200+ GPUs and ensure the new features performed as expected (the GPU results match the CPU results)
[x] Enclosed the new feature via nvtx ranges so that they can be identified in profiles
[x] Ran a Nsight Systems profile using ./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR
[ ] Ran an Omniperf profile using ./mfc.sh run XXXX --gpu -t simulation --omniperf, and have attached the output file and plain text results to this PR.
[ ] Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature

Nsight report for 3D_acoustic_support11 example:
nsys_old.txt
nsys_new.txt

@ChrisZYJ how did you determine that the performance was bad? how bad? out of curiosity and possible improvement of our tests, not punishment 😄

@ChrisZYJ how did you determine that the performance was bad? how bad? out of curiosity and possible improvement of our tests, not punishment 😄

@sbryngelson To clarify, my previous PR didn't alter the performance. The code has always looped through all grid points, including those far from source supports, at every time step. This PR aims to improve that inefficiency, unrelated to CI.
The acoustic subroutine has consistently used a significant portion of simulation time:
3D planar support (99^3): 4.6% of total time
3D 18-element transducer array (99^3): 29.0% of total time
This PR reduces the latter from 29.0% to 1.4%, which should be helpful for large 3D acoustic simulations.

@ChrisZYJ how did you determine that the performance was bad? how bad? out of curiosity and possible improvement of our tests, not punishment 😄

@sbryngelson To clarify, my previous PR didn't alter the performance. The code has always looped through all grid points, including those far from source supports, at every time step. This PR aims to improve that inefficiency, unrelated to CI.
The acoustic subroutine has consistently used a significant portion of simulation time:

3D planar support (99^3): 4.6% of total time
3D 18-element transducer array (99^3): 29.0% of total time

This PR reduces the latter from 29.0% to 1.4%, which should be helpful for large 3D acoustic simulations.

Well done! 👏

@sbryngelson It failed the Frontier test again on the acoustic cases, and it said it cannot execute MFC. Since I'm unable to run the case directly on Frontier, I'm not sure what the execution error is. Do you have any ideas on how to fix it? Thank you!

rerunning it. the error was
 Syscheck: PASSED.

mfc: OK > :) Running pre_process:

 Pre-processing a 299x0x0 case on 1 rank(s)
 Processing patch 1
 Processing patch 2
 Processing patch 3
 Elapsed Time 3.41100000000000084E-3

mfc: OK > :) Running simulation:

 Simulating a regular 299x0x0 case on 1 rank(s) with OpenACC offloading.

mfc: ERROR > :( /lustre/orion/cfd154/scratch/sbryngelson/runner/actions-runner/_work/MFC/MFC/build/install/c4aa7d20bc/bin/simulation failed with exit code 1.

Error: Submitting batch file for Interactive failed. It can be found here: /lustre/orion/cfd154/scratch/sbryngelson/runner/actions-runner/_work/MFC/MFC/tests/1B0A7157/MFC.sh. Please check the file for errors.

mfc: ERROR > main.py finished with a 143 exit code.
mfc: (venv) Exiting the Python virtual environment.

   Failed test tests/1B0A7157: 1D -> Acoustic Source -> Sine -> Frequency after 3 attempt(s).

Error: Test tests/1B0A7157: 1D -> Acoustic Source -> Sine -> Frequency: Failed to execute MFC.

./mfc.sh: line 51: 54626 Terminated              python3 "$(pwd)/toolchain/main.py" "$@"

mfc: ERROR > main.py finished with a 143 exit code.
mfc: (venv) Exiting the Python virtual environment.

which is a bit strange.

rerunning it. the error was
 Syscheck: PASSED.

mfc: OK > :) Running pre_process:

 Pre-processing a 299x0x0 case on 1 rank(s)
 Processing patch 1
 Processing patch 2
 Processing patch 3
 Elapsed Time 3.41100000000000084E-3

mfc: OK > :) Running simulation:

 Simulating a regular 299x0x0 case on 1 rank(s) with OpenACC offloading.

mfc: ERROR > :( /lustre/orion/cfd154/scratch/sbryngelson/runner/actions-runner/_work/MFC/MFC/build/install/c4aa7d20bc/bin/simulation failed with exit code 1.

Error: Submitting batch file for Interactive failed. It can be found here: /lustre/orion/cfd154/scratch/sbryngelson/runner/actions-runner/_work/MFC/MFC/tests/1B0A7157/MFC.sh. Please check the file for errors.

mfc: ERROR > main.py finished with a 143 exit code.
mfc: (venv) Exiting the Python virtual environment.

   Failed test tests/1B0A7157: 1D -> Acoustic Source -> Sine -> Frequency after 3 attempt(s).

Error: Test tests/1B0A7157: 1D -> Acoustic Source -> Sine -> Frequency: Failed to execute MFC.

./mfc.sh: line 51: 54626 Terminated              python3 "$(pwd)/toolchain/main.py" "$@"

mfc: ERROR > main.py finished with a 143 exit code.
mfc: (venv) Exiting the Python virtual environment.

which is a bit strange.

Thanks! I think I encountered similar errors before when running ./mfc.sh test. When that happens, if I run that specific test case using ./mfc.sh run tests/[hash]/case.py, it will output some useful messages. But I don't have access to Frontier, so I'm not sure how I can debug it

You are correct that it is challenging to debug without Frontier access. I will see what I can do to help. it is re-running right now

You are correct that it is challenging to debug without Frontier access. I will see what I can do to help. it is re-running right now

Thank you so much!

@sbryngelson Increasing tol from 2e-12 to 3e-12 passed the Frontier test! Sorry for the delay after fixing ACC_SETUP; I was confused by this message in the last failing commit (3540905), which led me to believe the issue was much more complex:
  - Candidate:   0.00541409128719
  - Golden:      0.00541409128954
  - Error:       abs: 2.35E-12, rel: 4.34E-10
  - Tolerance:   abs: 2.00E-12, rel: 2.00E-12

This suggested a significant increase in relative error. However, setting tol to 3e-12 passed the test.
It leaves me very curious: Does the line
            err, msg = packtol.compare(pack, packer.load(golden_filepath), packtol.Tolerance(tol, tol))
not check for relative tolerance? Thank you!

@sbryngelson Increasing tol from 2e-12 to 3e-12 passed the Frontier test! Sorry for the delay after fixing ACC_SETUP; I was confused by this message in the last failing commit (3540905), which led me to believe the issue was much more complex:
  - Candidate:   0.00541409128719
  - Golden:      0.00541409128954
  - Error:       abs: 2.35E-12, rel: 4.34E-10
  - Tolerance:   abs: 2.00E-12, rel: 2.00E-12

This suggested a significant increase in relative error. However, setting tol to 3e-12 passed the test.
It leaves me very curious: Does the line
 err, msg = packtol.compare(pack, packer.load(golden_filepath), packtol.Tolerance(tol, tol))
not check for relative tolerance? Thank you!

I'm not sure, what does the toolchain code suggest?

@ChrisZYJ The toolchain actually only requires either the absolute or the relative error to be within tolerance. Otherwise spurious issues would arise when we divide by small numbers and such. Apologies for the confusion, feel free to modify the console output to supply this bit of information.

Thanks for the clarification Henry! This makes much more sense now. I can make that message clearer

I think the PR is ready. Sorry for the wait!


support for set status light

@pelikhan, the value given is a single number, which I need to translate into [R,G,B,X]. Is there a function for this?


(SERVER-332) Allow all TLS algorithms in the dev lein profile

Without this patch the unit tests fail on JVM versions more recent than
1.7.0_u75 because SSLv3 is disabled at the JRE layer by default.  This is a
problem because the end user may explicitly configure the JRE to allow SSLv3
algorithms, even though we disable them by default at the application layer,
and we need to test the behavior of the system in this scenario.  This patch
addresses the problem by allowing all SSLv3 algorithms by overriding the
java.security jdk.tls.disabledAlgorithms property.

@camlow325 mentioned it would be good to have new documentation about adjusting JAVA_OPTS if this is required in production.

:+1:

That travis failure was weird but I'm +1 on this.


WIP: Upgrade Electron

⚠ Work in progress ⚠
The purpose of this PR is to begin the process of upgrading Electron to the latest release. As of right now, there are a few things that need to be dealt with before that can happen.
The primary problem is that as of Electron v1.1.0, Node.js was upgraded to v6 and that causes some issues. I believe (and hope) that the only major issue is the usage of older version of graceful-fs in a few of our dependencies. Once those have been resolved, I think we'll be able to sort out the remaining issues in Atom core without too many problems. OK, there are more problems than first anticipated — I'll keep updating the task list below as I identify (and fix) problems.
There is another concern though, since Electron v1 removed some deprecated module require bits.
I propose that in this PR, we perform the upgrade process in stages, one minor version bump at a time, to minimize the number of issues and hopefully keep it reasonable.

[x] Upgrade to v1.0.x

[x] Upgrade to v1.1.x

[x] Resolve breaking changes to path module. See https://github.com/atom/atom/pull/12300#issuecomment-241507011.

[x] tree-view (atom/tree-view#926)
[x] autocomplete-plus (atom/autocomplete-plus#753)
[x] Add deprecated shims, so that community packages don't break

[x] Upgrade to v1.2.x

[x] Fix use of removed ATOM_SHELL_INTERNAL_RUN_AS_NODE env variable in exports/atom.js
[x] Fix beforeunload handler to conform to new contract
[x] Open issue on atom-package-deps (https://github.com/steelbrain/package-deps/issues/57)

[ ] Upgrade to v1.3.x

[x] Upgrade oniguruma to work with Node 6
[x] Upgrade marker-index to work with Node 6
[ ] Investigate why atom-pane-resize-handles are positioned incorrectly, making it impossible to resize panes with the mouse.

[x] Add deprecated shims for legacy electron APIs (where feasible)

[x] Open issues on packages that use removed Electron APIs that we aren't able to shim (because they involve methods called on remote proxy objects).
APIs:

remote.require
WebContents.prototype.loadUrl (renamed to loadURL)
WebContents.prototype.getUrl (renamed to getURL)

Packages:
* [x] atom-cos-studio (https://github.com/MDevelopmentGroup/Atom-COS-Studio/issues/35)
* [x] atom-force (https://github.com/mikegedelman/atom-force/issues/3)
* [x] atom-pronama-chan (https://github.com/hurumeki/atom-pronama-chan/issues/1)
* [x] dev-tools-themes (https://github.com/travs/dev-tools-themes/issues/2)
* [x] elasticsearch-client (https://github.com/KunihikoKido/atom-elasticsearch-client/issues/9)
* [x] impress (https://github.com/kaitoy/impress/issues/1)
* [x] jibo-sdk (https://github.com/jiborobot/jibo-sdk/issues/11)
* [x] julia-client (https://github.com/JunoLab/atom-julia-client/issues/217)
* [x] markdown-preview-enhanced (https://github.com/shd101wyy/markdown-preview-enhanced/issues/115)
* [x] mavensmate-atom (https://github.com/joeferraro/MavensMate-Atom/issues/334)
* [x] mocha-runner (https://github.com/tswaters/atom-mocha-runner/issues/10)
* [x] nitrogen (https://github.com/nitrous-io/nitrogen-dist/issues/43)
* [x] tree-view-bleeding (https://github.com/forivall/atom-tree-view-bleeding/issues/2)

In case any package authors are looking at this, here's a list of packages that need to be updated:
https://gist.github.com/50Wliu/ef22d45854415842d9c59f562eca99bc

We should set process.traceDeprecation = true while we're testing this to make sure we haven't missed changing any deprecated stuff. (cf. http://electron.atom.io/blog/2015/11/17/electron-api-changes)

What is the status on this? Excited to see work on this!

@hultberg We're currently blocked by https://github.com/less/less.js/pull/2953. Hopefully once the Less.js upgrade is dealt with, we can continue the stepwise upgrade towards the latest release of Electron.

Updating Electron to v1.1.x (and newer) is currently blocked on path assertions introduced in Node v6. Essentially we are no longer allowed to pass undefined to any function in the path module. Since this affects not only Atom core, but all packages, we will have to resolve this somehow.
The "easy" option is to monkey patch the assertPath function in path.js. The hard option is to ensure all instances of undefined are replaced with e.g. "" throughout the entire codebase, including community packages.
Deviating from Node proper by patching in support for undefined does not feel right, but I believe it's the only viable option. If someone has an alternative approach, I'm all :ear::ear:

@thomasjo This is unavoidable; as node progresses. I don't think we should patch path functions, as this perpetuates the issue. This was done for a reason, and we should fix any area in core that is affected.
I would advocate for ensuring that we deal with packages that fall afoul of this via:

Adding some logic that adds context about how to fix issues that are filed as a result of catching this kind of error
Downloading all published packages and identifying any use of path functions; you could then potentially open an issue warning of this upcoming change, giving the package author time to fix it while a) these changes are in master and b) these changes are in beta, and prior to c) these changes being in stable
Optionally creating a new channel for electron-latest ("alpha"?) so that we ease the burden of building from source for people who just want to fix their package and don't necessarily want to build from master

@joefitzgerald As we discussed elsewhere, I agree. We should fix this properly, and as mentioned, I believe this will require us to bump Atom's major version since we will likely Break The World™ 🎱
I've started fixing the issues, and will keep updating the PR description as I identify (and fix) problematic code in core and bundled packages. As of writing this, I will at least have to patch tree-view and autocomplete-plus, but I suspect there are others.
Opening PRs on community packages will have to wait, but if someone wants to start testing this PR against their community packages and resolving issues there, that would be amazing 💖

@simurai It seems that on this new version of Chrome (52.0.2743.82), the atom-pane-resize-handle elements are not being positioned properly in the flow. I think this is related to https://github.com/atom/atom/commit/4980ce30a98615373ca17125a22e168bbb4ef44c and https://github.com/atom/one-dark-ui/commit/82271d5e5749aacb34298a139ad9cd7d1b74f0bd.
Could you build this branch when you get a chance, and investigate if there's another way to achieve the desired look of the resize handles?

@maxbrunsfeld Yes, seems Chromium 52 changed how they handle absolutely positioned flexbox items. Should be fixed by using an extra pseudo-element.
The One + Atom Material themes still need a separate fix for the horizontal handles. 🔜

@maxbrunsfeld: @thomasjo reports that we're getting IndexDB errors when Atom and Atom Beta are opened side-by-side. I wonder if something about the storage directories isn't being set correctly.

@maxbrunsfeld, @nathansobo: Yeah I can consistently repro this on my machine; start atom-beta from an arbitrary directory, then subsequent launches of atom (with beta still running) causes a IndexDB error.

@maxbrunsfeld @thomasjo Apparently this happens on stable/beta as well. It's not related to this branch.

@thomasjo Please consider, that Chrome v49 has a very nasty SVG rendering speed downgrade (when rendering text nodes):
https://bugs.chromium.org/p/chromium/issues/detail?id=589525
I am developing a diagram editor (which is an Atom plugin), and when Atom updated to 1.9.9 it became sooo slow. There are O(n^2) computations in place, and now some interactions take seconds to complete, while previously there were milliseconds.
It would be really nice to update Chrome version to more performant one as soon as possible.

@thomasjo Looks like we're failing an integration test on this branch.

@nathansobo The failing intergration test seems to be caused by atom-application.test.js#L192 not actually opening the specified new-file, which means no text is inserted into the empty file, and subsequently the re-launched instance does not contain the persisted file and the assertion fails.
Unfortunately I did not find time to track down the root cause. The object constructed by parseCommandLine does seem correct, but it might be worth investigating. Hopefully my simple investigation will guide you or someone else in the right direction.

Sounds good. We'll take a look next week. Looking forward to being on a new electron and fixing international keyboards finally.

@nathansobo Looks as if the failing integration test is due to some type of race condition. I've yet to figure out exactly what the problem is, but I'm guessing state in IndexedDB isn't persisted by the time the window is closed, or something along those lines.
Will continue trying to figure out what's changed, and how to fix it. Good thing is, this only seems to be a spec problem though, since putting in a slight delay in the spec, "fixes" the problem.

I took some time today to investigate the failing test and it seems like it might be related to IndexedDB. Creating IndexedDB transactions inside a beforeunload handler is considered undefined behavior and could abort the transaction without saving any data (https://developer.mozilla.org/en-US/docs/Web/API/IndexedDB_API/Using_IndexedDB#Warning_About_Browser_Shutdown).
The flaky spec is relying on closing the window to save the project state (i.e. because when we close the window, we call unloadEditorWindow which in turn calls atom.saveState) but it seems like this new version of Electron is either too fast to tear down the renderer process or simply the behavior has changed with respect to transactions initiated in a beforeunload event handler.
I don't think we can simply bypass this failure by adding a timeout, because it seems to be pointing at a potential bug which can cause problems to users with slower machines (or that simply happen to have a busy CPU when closing Atom). Finding a good solution to this problem is also tricky because of the synchronous nature of the beforeunload event and the asynchronous API of IndexedDB. An idea would be to:

Cancel the close initiated by the user.
Wait until AtomEnvironment.prototype.saveState is resolved (or rejected).
Programmatically close the window from the renderer process.

This would work great for closing a single window, but when shutting down the entire application 3) wouldn't be sufficient because we'd need to call app.quit as well. So, alternatively we might:

Cancel the close initiated by the user.
Wait until AtomEnvironment.prototype.saveState is resolved (or rejected).
Notify the main process that a window can be closed (emit 'can-close').
In the main process:
If the application was quitting, wait until all the windows notify that they can be closed, then call app.quit.
If the application  was not quitting, close only the window for which we have a received a can-close event.

I worry a little bit that keeping additional state around to handle the above logic could, in certain cases, cause the application to never quit or to have dangling windows (i.e. in the case of exceptions, or other less-predictable scenarios).
Therefore, I can think of three alternatives:

If exists, replace IndexedDB with some other database that provides both a synchronous and an asynchronous API (we'd use the former only in the beforeunload event handler).
Instead of persisting additional state only on exit, save everything (including markers, etc.) while the application is open. The downside here could be that we potentially slow down the UI thread when there's a very large number of markers to serialize.
I couldn't reproduce the problem manually, so we might ignore this and worst-case scenario users won't have their markers in the history after reopening Atom.

What do you think?

I'm leaning towards option #2 or #3. As stated earlier, I've also been unable to reproduce this in a real world scenario.

For posterity, in #12619 we ended up implementing a slight variation of the routine proposed in the previous comment:

Cancel the close initiated by the user.
Wait until AtomEnvironment.prototype.saveState is resolved (or rejected).
Notify the main process that a window can be closed (emit 'can-close').
In the main process:
If the application was quitting, wait until all the windows notify that they can be closed, then call app.quit.
If the application was not quitting, close only the window for which we have a received a can-close event.

Rebased and removed my "hacky" attempts at resolving the failing integration test. Hopefully everything should be 💚 now with @as-cii's fix in #12619 🎉

Thanks so much @thomasjo, @maxbrunsfeld and everyone else involved in this! ❤

Yes! Yes!!! I am thinking about using nvm and forget worrying about system node veriosn (6.x vs 4.x) is that a good idea?


Do not rely on admin's locale for product autocomplete

Q
A

Bug fix?
yes

New feature?
no

BC breaks?
no

Deprecations?
no

Related tickets
fixes #97

License
MIT

Thanks, Patryk! 💪


Default to use rocks

verify on lakefs run that migration is required. cataloger type is not
set, there are repositories on mvcc tables and migration didn't run

Codecov Report

Merging #1333 (4ed834d) into master (bef81f3) will decrease coverage by 0.02%.
The diff coverage is 31.81%.

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
- Coverage   47.09%   47.06%   -0.03%
==========================================
  Files         203      203
  Lines       15907    15928      +21
==========================================
+ Hits         7491     7497       +6
- Misses       7425     7439      +14
- Partials      991      992       +1

Impacted Files
Coverage Δ

catalog/migrate/migrate.go
62.50% <31.81%> (-3.66%)
:arrow_down:

catalog/mvcc/cataloger_create_repository.go
59.25% <0.00%> (-3.71%)
:arrow_down:

catalog/mvcc/cataloger_commit.go
80.00% <0.00%> (+2.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef81f3...4ed834d. Read the comment docs.

Codecov Report

Merging #1333 (4ed834d) into master (bef81f3) will decrease coverage by 0.02%.
The diff coverage is 31.81%.

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
- Coverage   47.09%   47.06%   -0.03%
==========================================
  Files         203      203
  Lines       15907    15928      +21
==========================================
+ Hits         7491     7497       +6
- Misses       7425     7439      +14
- Partials      991      992       +1

Impacted Files
Coverage Δ

catalog/migrate/migrate.go
62.50% <31.81%> (-3.66%)
:arrow_down:

catalog/mvcc/cataloger_create_repository.go
59.25% <0.00%> (-3.71%)
:arrow_down:

catalog/mvcc/cataloger_commit.go
80.00% <0.00%> (+2.85%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef81f3...4ed834d. Read the comment docs.


Identity verification providers API doesn't support saving idvp logo url per idvp instance.

Describe the issue:

Identity verification providers API doesn't support saving idvp logo url per idvp instance. Refer [1].

Expected behavior:

The POST /api/server/v1/idv-providers [1] should accept image logo url and API response should also reflect this change.  The other relevant APIs should also have the same response which returns image url.

With the fix, test the following api:

POST /api/server/v1/idv-providers
PUT /api/server/v1/idv-providers/{id}
DELETE /api/server/v1/idv-providers/{id}
GET /api/server/v1/idv-providers/{id}
GET /api/server/v1/idv-providers

Related Issue:

https://github.com/wso2-enterprise/iam-engineering/issues/363

[1] https://github.com/wso2/identity-api-server/blob/master/components/org.wso2.carbon.identity.api.server.idv.provider/org.wso2.carbon.identity.api.server.idv.provider.v1/src/main/resources/idv-provider.yaml

The fix for this issue was tested with the following dbs:

H2
MySQL
MSSQL
Oracle


Implemented language server to enable IntelliSense features

This pull request introduces the following features to the extension:

Property and Value Documentation Hints
Property and Value Autocompletion Hints
Documentation Hints on Hover
Document Outline Support
Jump Link Support for the $include Function

LGTM.


Refactor TrainerModel and NN_opt functions to remove unused code and improve verbosity control

The added tests for back minimize also comes in this pr

We may also want to include the process id to the printed result for multi-processing

Process id included.


advance use for api

Hi
I want to send a progress bar percent and time estimation to my frontend app.
is it possible to get that in another python app and send it via socket to the frontend app?
could you demonstrate how?

Hi @erfantkerfan
I changed the signature of ffpb.main so that you can pass it a tqdm.tqdm subclass. With this, you should be able to write a custom subclass that interacts with your frontend.

Could you give an example of for extracting only the progress number?

I don't have the time to explain it fully but I used something like this
command = "ffprobe -v error -hide_banner -show_entries format=duration -of default=noprint_wrappers=1:nokey=1 -i \"" + str(
         self.file_name) + "\""
         ffprobe_process = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.STDOUT,
                                        universal_newlines=True, shell=True)
         out, err = ffprobe_process.communicate()
         reg = re.search('\d*\.\d*', str(err) + str(out))

above command to get the total time
thread = threading.Thread(target=self.start_convert,
                                   args=(self.file_name, modified_file_name_hq, modified_file_name_240p))
thread.start()
         while thread.is_alive():
             self.progress_hq['value'] = parse_seconds(self.ffmpeg_time_hq) / self.total_duration * 100
             self.progress_240p['value'] = parse_seconds(self.ffmpeg_time_240p) / self.total_duration * 100
             self.root.update()

and used to above command to update the tkinnter interface

To use a custom tqdm.tqdm subclass:

class ProgressBar(tqdm.tqdm):
    def update(n):
        super().update(n)
        # now put here whatever code you need to update your
        # GUI or whatever

        # self.n is the current progress
        # self.total is the total

ffpb.main(["-i", "input.mp4", "output.mkv", tqdm=ProgressBar)

I needed to add self to make that work. Final code:
import tqdm
class ProgressBar(tqdm.tqdm):
    def update(self, n):
        super().update(n)
        print(self.n)
        print(self.total)


Max Key Length

There is a test testBasicUsageWithLongKey which checks for keys of 300 chrs in length. This test is breaking for me.
It looks like its because the max key is limited by php_memcached to 250 chrs. see MEMC_OBJECT_KEY_MAX_LENGTH in https://github.com/php-memcached-dev/php-memcached/blob/master/php_memcached.c
If I manually change the key length to 250 everything passes. Was there a reason why this is checking for 300chr keys?

Do you know if this is only happening with the news version?

This is a limitation of memcached yes. But the php code that talks to the memcached server can and should do something around the limitation. Symfony's does by hashing too long keys. That's what your implementation should do I suppose. Closing as the test suite is correct and fulfills its purpose: showing where implems have issues.


Add a foreign key for user's subscription id.

I think this is just something we overlooked a long time ago. The users table subscription_id wasn't an actual foreign key pointing to subscriptions.id. This is never really problematic in production because we never delete subscriptions from the table, but it's still nice to have this constraint, and it can be useful for local development when messing with data manually.
https://trello.com/c/OFf9g5Qk

Looks good... any worry about the migration messing things up?

nah I exported/imported the production data base locally and ran, and we're good


Can't get progress while uploading or downloading data

I can't get progress while uploading or downloading data。Is there any samples ? thanks

This should be fixed. Often while uploading large files we need to show a progress to user otherwise they will more often than not close the app.
For now I've been using a wrapper around InputStream to get callbacks for read method. Returning with the number of bytes read.