BLD: Update Poetry lock file for Poetry v1.5.0

Change Summary
Our pre-commit hook updated Poetry to 1.5.0, but the lockfile was still using 1.4.0, so this updates the lockfile with the new versions of dependencies.
To test this, on dev I ran: pre-commit run --all and it would fail locally on the dev branch. I then added the new lockfile generated here.

per a conversation with @maxinelasp I also added a --no-update argument to the poetry-lock pre-commit hook to try and minimize some of the updates.

As a further note about the --no-update flag: this will not automatically update dependencies if they get a new version. So, for example, if black releases 23.1.1, but the poetry.lock file has version 23.1.0, that dependency will not get updated. However, if a new dependency is added in pyproject.toml, the precommit step will update the lock file to include that new dependency. This way, we can still maintain our poetry.lock file without requiring a full lock step for every commit.
Ideally, these dependencies should get updated regularly, so running poetry lock on your branch every once and a while is good practice.


Add unit tests for detector calls

This PR addresses #77.
Please see my questions below.

I wanted to change get_test_context signature, so it would no longer be needed to always mock the GenerationClient. However, #[derive(Default)] doesn't work for GenerationClient.

Does making that change makes sense?
If so, what should be the Default for GenerationClient?


authz: with_comprehensive_hierarchy bug -- missing hierarchy entitlements above requested fqn

Ex: client opentdf is entitled with https://example.com/attr/cards/value/queen
A getEntitlements request with with_comprehensive_hierarchy=true and scope.attribute_value_fqns=["https://example.com/attr/cards/value/jack"] returned an empty entitlements response []
I would expect the output to be ["https://example.com/attr/cards/value/queen", "https://example.com/attr/cards/value/jack"]
This is a result of when were evaluating getComprehensiveHierarchy() -- it is currently after we get the entitlements back from opa, we loop through them and add hierarchical elements lower to the list. But if the attribute the entity has is above the attribute provided in the scope, then the opa result is still empty.

some details are here in the PR description https://github.com/opentdf/platform/pull/1121
in-code comments are there too.

yes, this is a bug


ValueError: 'rename-file' is not a valid CodeChangeAction

getting this error when getting mentat to rename a JS file
running the repo locally on Ubuntu 22.04.2, haven't tried on any other OS
i'm not a python guy so apologies if it's an obvious env thing lol,
here's the how I recreated it along w/ the stack trace:
What can I do for you?
>>> rename the JS file to app.js, and update package.json with the new fil
ename

Total token count: 1458

streaming...  use control-c to interrupt the model at any point

I will rename the JS file to app.js and update the package.json with the new filename.

Steps:
1. Rename the download-data.js file to app.js.
2. Update the package.json file with the new filename.

2023-07-26 23:48:42,828 - ERROR - an error occurred during closing of asynchronous generator <async_generator object APIRequestor.arequest.<locals>.wrap_resp at 0x7f275e2a23c0>
asyncgen: <async_generator object APIRequestor.arequest.<locals>.wrap_resp at 0x7f275e2a23c0>
Traceback (most recent call last):
  File "/home/zhoug/.local/lib/python3.10/site-packages/openai/api_requestor.py", line 324, in wrap_resp
    yield r
GeneratorExit

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/zhoug/.local/lib/python3.10/site-packages/openai/api_requestor.py", line 326, in wrap_resp
    await ctx.__aexit__(None, None, None)
  File "/usr/lib/python3.10/contextlib.py", line 206, in __aexit__
    await anext(self.gen)
RuntimeError: anext(): asynchronous generator is already running

Total session cost: $0.00
Traceback (most recent call last):
  File "/home/zhoug/.local/bin/mentat", line 8, in <module>
    sys.exit(run_cli())
  File "/home/zhoug/.local/lib/python3.10/site-packages/mentat/app.py", line 24, in run_cli
    run(paths)
  File "/home/zhoug/.local/lib/python3.10/site-packages/mentat/app.py", line 35, in run
    loop(paths, cost_tracker)
  File "/home/zhoug/.local/lib/python3.10/site-packages/mentat/app.py", line 57, in loop
    explanation, code_changes = conv.get_model_response(code_file_manager, config)
  File "/home/zhoug/.local/lib/python3.10/site-packages/mentat/conversation.py", line 52, in get_model_response
    state = run_async_stream_and_parse_llm_response(
  File "/home/zhoug/.local/lib/python3.10/site-packages/mentat/parsing.py", line 129, in run_async_stream_and_parse_llm_response
    asyncio.run(
  File "/usr/lib/python3.10/asyncio/runners.py", line 44, in run
    return loop.run_until_complete(main)
  File "/usr/lib/python3.10/asyncio/base_events.py", line 646, in run_until_complete
    return future.result()
  File "/home/zhoug/.local/lib/python3.10/site-packages/mentat/parsing.py", line 158, in stream_and_parse_llm_response
    await _process_response(state, response, printer, code_file_manager)
  File "/home/zhoug/.local/lib/python3.10/site-packages/mentat/parsing.py", line 178, in _process_response
    _process_content_line(state, content_line, printer, code_file_manager)
  File "/home/zhoug/.local/lib/python3.10/site-packages/mentat/parsing.py", line 201, in _process_content_line
    state.new_line(code_file_manager)
  File "/home/zhoug/.local/lib/python3.10/site-packages/mentat/parsing.py", line 93, in new_line
    self.create_code_change(code_file_manager)
  File "/home/zhoug/.local/lib/python3.10/site-packages/mentat/parsing.py", line 71, in create_code_change
    CodeChange(json_data, self.code_lines, self.git_root, code_file_manager)
  File "/home/zhoug/.local/lib/python3.10/site-packages/mentat/code_change.py", line 50, in __init__
    self.action = CodeChangeAction(self.json_data["action"])
  File "/usr/lib/python3.10/enum.py", line 385, in __call__
    return cls.__new__(cls, value)
  File "/usr/lib/python3.10/enum.py", line 710, in __new__
    raise ve_exc
ValueError: 'rename-file' is not a valid CodeChangeAction

Hmm, it looks like the AI tried to do a 'rename-file' action (which doesn't exist). The model is supposed to output a strict json format that we read, and it just messed up. We might need to add a way for it to rename files, but for now you'll just have to rename the files yourself :smiling_face_with_tear: Other than that though, it should work fine; thanks for letting us know about this!


Move "Organ" and "Model Organ" each to their own column in the tables

Test Plan
For each data table:

Confirm both Organ and Model Organ columns are displayed.
Confirm Organ no longer displays a split column value (ie a "Organ / Model Organ" value).
Confirm Organ column count no longer displays a split count value (ie "(Organ Count) / (Model Organ Count)".
Confirm tooltip descriptions for each column are correct.
Confirm counts for both columns are correct.
Confirm both columns are sortable.


Dev Box Context ... Menu missing required shortcuts

Suggested new feature or improvement
The Environments page has a ... context menu for shortcut commands. These currently include Restart and delete. That menu should also have a direct link to the install applications, clone repositories, add a dev drive, and setup an environment commands on the "machine configuration" page. This allows you the skip the device selection on those pages because the user already provided that context by using the menu on the desired dev box.
Scenario
Save developers time, improve discoverability, reduce many mouse clicks, increase engagement.
Additional details
No response

Duplicate of #2668


Fix custom prompt substitute with List issue

Description
fix custom prompt substitute with List issue in ml inference search response processor
using toString() method in placeholder to convert list into string, for example, ${parameters.context.toString()} in the following processors config:
PUT /_search/pipeline/my_pipeline_request_review_llm
{
  "response_processors": [
    {
      "ml_inference": {
        "tag": "ml_inference",
        "description": "This processor is going to run llm",
        "model_id": "cf46K5EBoVpekzRp8x_3",
        "function_name": "REMOTE",
        "input_map": [
          {
            "context": "review"
          }
        ],
        "output_map": [
          {
            "llm_response": "response"
          }
        ],
        "model_config": {
          "prompt":"\n\nHuman: You are a professional data analysist. You will always answer question based on the given context first. If the answer is not directly shown in the context, you will analyze the data and find the answer. If you don't know the answer, just say I don't know. Context: ${parameters.context.toString()}. \n\n Human: please summarize the documents \n\n Assistant:"
        },
        "ignore_missing": false,
        "ignore_failure": false
      }
    }
  ]
}

reverting https://github.com/opensearch-project/ml-commons/pull/2811/files  as a more appropriate approach to fix the toString issue https://github.com/opensearch-project/ml-commons/issues/2839
https://github.com/opensearch-project/ml-commons/issues/2880
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] API changes companion pull request created.
[ ] Commits are signed per the DCO using --signoff.
[ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Shouldn't we use model interface instead of adding toString to the parameter to identify if we need to convert that to string? cc @ylwu-amzn


Suppress false positive in current clippy nightly

https://github.com/rust-lang/rust-clippy/issues/7422

bors r+


Retreiving AuthService via IOC container causes exceptions

I am trying to do something like this in my main.ts:
import { Aurelia } from 'aurelia-framework';
import { AuthService } from 'aurelia-authentication';
import 'src/helpers/exceptionHelpers'
import config from "./auth-config";

export function configure(aurelia: Aurelia) {
	aurelia.use
		.standardConfiguration()
		.feature('src/resources')
		.developmentLogging()
		.plugin('aurelia-dialog')
		.plugin('aurelia-api', config => {
			// Register an authentication hosts
			config.registerEndpoint('auth', 'http://cpu260:7987/auth/');
		})
		.plugin('aurelia-authentication', (baseConfig) => {
			baseConfig.configure(config);
		});

	let auth = aurelia.container.get(AuthService);

	if (auth.isAuthenticated()) {
		aurelia.start().then(x => x.setRoot('src/app'));
	} else {
		aurelia.start().then(x => x.setRoot('src/unAuthorized'));
	}

}

However when the statement aurelia.container.get(AuthService) is executed I get a an exception:
Error: Error invoking AuthService. Check the inner error for details.
Inner Error:
Message: Token not found in response
Inner Error Stack:
Error: Token not found in response
at Authentication.getTokenFromResponse (http://cpu260:7987/jspm_packages/npm/aurelia-authentication@3.2.0/aurelia-authentication.js:968:25)
at Authentication.getDataFromResponse (http://cpu260:7987/jspm_packages/npm/aurelia-authentication@3.2.0/aurelia-authentication.js:907:145)
at Authentication.setResponseObject (http://cpu260:7987/jspm_packages/npm/aurelia-authentication@3.2.0/aurelia-authentication.js:843:14)
at AuthService.setResponseObject (http://cpu260:7987/jspm_packages/npm/aurelia-authentication@3.2.0/aurelia-authentication.js:1169:27)
at new AuthService (http://cpu260:7987/jspm_packages/npm/aurelia-authentication@3.2.0/aurelia-authentication.js:1127:12)
at Object.invoke (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:460:14)
at InvocationHandler.invoke (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:413:168)
at Container.invoke (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:677:25)
at StrategyResolver.get (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:130:37)
at Container.get (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:604:41)

End Inner Error Stack
at Authentication.getTokenFromResponse (http://cpu260:7987/jspm_packages/npm/aurelia-authentication@3.2.0/aurelia-authentication.js:968:25)
at Authentication.getDataFromResponse (http://cpu260:7987/jspm_packages/npm/aurelia-authentication@3.2.0/aurelia-authentication.js:907:145)
at Authentication.setResponseObject (http://cpu260:7987/jspm_packages/npm/aurelia-authentication@3.2.0/aurelia-authentication.js:843:14)
at AuthService.setResponseObject (http://cpu260:7987/jspm_packages/npm/aurelia-authentication@3.2.0/aurelia-authentication.js:1169:27)
at new AuthService (http://cpu260:7987/jspm_packages/npm/aurelia-authentication@3.2.0/aurelia-authentication.js:1127:12)
at Object.invoke (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:460:14)
at InvocationHandler.invoke (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:413:168)
at Container.invoke (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:677:25)
at StrategyResolver.get (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:130:37)
at Container.get (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:604:41)

End Inner Error Stack
at new AggregateError (http://cpu260:7987/jspm_packages/npm/aurelia-pal@1.3.0/aurelia-pal.js:39:13)
at Container.invoke (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:679:15)
at StrategyResolver.get (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:130:37)
at Container.get (http://cpu260:7987/jspm_packages/npm/aurelia-dependency-injection@1.3.0/aurelia-dependency-injection.js:604:41)
at r.configure (http://cpu260:7987/src/main.js:18:38)
at eval (http://cpu260:7987/jspm_packages/npm/aurelia-bootstrapper@2.0.1/aurelia-bootstrapper.js:145:22)

Now I see that "token not found in response" is the error, however considering I haven't logged in yet, this is what I would expect.  So how can I get the authService to play nice?

isAuthenticated is async. It doesn't find a token but might have found a refresh token. It's trying to get a new token. Could you check local storage if there's anything there?


rocksdb: reintroduce rocksdb 6.23.3 as rocksdb_6_23

Motivation for this change

it seems that at least 2 packages (blockbook, electrs) got broken when rocksdb was updated past 6.23.3 in https://github.com/NixOS/nixpkgs/pull/143524
this PR fixes that by reintroducing rocksdb 6.23.2 as rocksdb_6_23 and patching these two packages to use that

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@GrahamcOfBorg build blockbook electrs


project-spaced state vs global state

https://github.com/fluidattacks/makes/blob/e30e69031e5614b50941266547cb07c22fce31fa/src/args/make-script/template.sh#L25

running a cardano node has currently a state or roughly 9GB. That state should probably be (optionally) global.
two scripts that generate wallet addresses for testnet using the same (hypothetical) makes builtin function makeCardanoWallet for most purposes would be intended to be differentiated by repo.

I could imagine doing an optional global state, defaulting to repo state.
Still I would keep the first naming category being the script name and the second some project name:
    && STATE="${HOME_IMPURE}/.makes/state/__argName__/__argProjectName__" \

This would require giving each project a project name in makes.nix.
Unfortunately flakes are anonymous (in human readable terms):
nix-repl> self.sourceInfo.
self.sourceInfo.lastModified      self.sourceInfo.outPath           self.sourceInfo.shortRev
self.sourceInfo.lastModifiedDate  self.sourceInfo.rev               self.sourceInfo.submodules
self.sourceInfo.narHash           self.sourceInfo.revCount

we could also store the state relative to the root of the project, so it is local, for example in a out/ folder, former (internal) versions of Makes did this
we've not really defined this interface and nothing uses it at this moment, so you are free to change it or propose the schema that you think is better

I think, at least, basing state off of IMPURE_HOME opens up the venue to slap that onto a persistent volume and have some (frameworkish nag at) dev - prod paritiy with regard to how state folder layout is supposed to be (matching the job name above all).

I think also a distinction between persisted and cleared is worthwhile.


for loop not working in tf.contrib.autograph

The following example for autograph is not working (see my system-info below):
from tensorflow.contrib import autograph

def computation():
    for k in range(4):
        print(k)
    return tf.no_op()

computation_autographd = autograph.to_graph(computation, verbose=True)

If I remove the for loop, it works fine.
With the loop, it fails with:
File "/opt/project/examples/_dict_in_autograph_example.py", line 66, in <module>
verbose=True)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/contrib/autograph/impl/api.py", line 245, in to_graph
    compiled_node, compiled_src = compiler.ast_to_object(module)
  File "/usr/local/lib/python3.5/dist-packages/tensorflow/contrib/autograph/pyct/compiler.py", line 75, in ast_to_object
    return imp.load_source(module_name, f.name), source
  File "/usr/lib/python3.5/imp.py", line 172, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 693, in _load
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 661, in exec_module
  File "<frozen importlib._bootstrap_external>", line 767, in get_code
  File "<frozen importlib._bootstrap_external>", line 727, in source_to_code
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/tmp/tmpqdvecllf.py", line 21
    () = __ops.for_loop(autograph_utils.dynamic_builtin(range, 4),
       ^
SyntaxError: can't assign to ()

Process finished with exit code 1

python3 --version
Python 3.5.2
python3 -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
v1.8.0-0-g93bc2e2072 1.8.0
== cat /etc/issue ===============================================
Linux 5a7b67a966f3 4.9.87-linuxkit-aufs #1 SMP Wed Mar 14 15:12:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
VERSION="16.04.3 LTS (Xenial Xerus)"
VERSION_ID="16.04"
VERSION_CODENAME=xenial
== are we in docker =============================================
Yes
== compiler =====================================================
c++ (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
== uname -a =====================================================
Linux 5a7b67a966f3 4.9.87-linuxkit-aufs #1 SMP Wed Mar 14 15:12:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
== check pips ===================================================
== check for virtualenv =========================================
False
== tensorflow import ============================================
tf.VERSION = 1.8.0
tf.GIT_VERSION = v1.8.0-0-g93bc2e2072
tf.COMPILER_VERSION = v1.8.0-0-g93bc2e2072
Sanity check: array([1], dtype=int32)
== env ==========================================================
LD_LIBRARY_PATH is unset
DYLD_LIBRARY_PATH is unset
== nvidia-smi ===================================================
./tf_env_collect.sh: line 105: nvidia-smi: command not found
== cuda libs  ===================================================

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

Sorry for the delay! This is a known issue -- we still need to properly handle the cases where a code block (in this case, the body of the for loop) doesn't calculate any numeric values.
For now, you can work around this limitation by having the loop perform some computation on an existing variable, like for instance:
def computation():
    s = 0
    for k in range(tf.constant(4)):
        print(k)
        s += k
    return s

Side note: we also need to make sure the argument passed to range is a tensor, otherwise the loop will be statically unrolled. We're still debating whether to keep this behavior because it's been a source of confusion.

Nagging Assignee @mdanatg: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 74 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 89 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 104 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 122 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @mdanatg: It has been 136 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Final update - the loop uses the type to decide whether to run as a Python or TF loop. So, if the iterated is a Tensor, then the loop will run in TF. Otherwise it stays in Python.
Examples:
for k in range(4):  # Python loop
for k in [1, 2, 3]:  # Python loop

for k in tf.range(4):  # TF loop
for k in tf.data.Dataset.range(4):  # TF loop
for k in tf.constant([1, 2, 3]):  # TF loop

We found that this is the way that's most consistent with other instances, like for instance overloaded operators (e.g. a + b runs in TF if either a or b is a tensor).


Linting: line length

Currently there are some lines >80 columns. If this is supposed to be the limit, it should be checked in the CI.
cc: @jmuk @tbetbetbe

Let's switch to ESLint http://eslint.org/ which seems to have richer feature.


Create first (simple) Selenium test

To make sure that selenium testing is setup properly and works, we should write a simple test that just verifies some text appears on screen and closes.
Part of the uber task #54

Travis is able to connect to Sauce Labs now. Had to add the user credentials as environment variables but on the Travis server. Still working on executing a selenium test on branch jj/travis-ci

Big blocker - Selenium isn't supported in .NET Core, I tried using other web drivers but it seems like there isn't an easy way to do front end web automation yet. I'll be working on backend unit tests for the time being.

We can host the tests on .NET Framework, and run then from .NET Core.

tracking this issue on branch james/selenium

Not sure if we can run Selenium headless (no browser / UI), but should look into PhantomJS as an alternative. It can be run from the command line and has access to the DOM.

Explore BrowserStack instead of Sauce Labs


Reserve space for the GitHub button in menu

When the GitHub button loads, the menu "re-aligns". We could avoid this by reserving the space for the button.

Closing in favor of #154


Log foreign peer ID when failing to upgrade connection

This helps verify if particular peers are systematically failing to connect to a listening Endpoint.

bors r+
It's just adding context.


#176 don't document HEAD

Exclude HEAD from $methods, a la #176

:+1: The tests are failing tho !

Yeah, I don't know how to fix those. All kinds of hashes are mismatching. Maybe they've changed, since the output has changed..? I won't make that assumption.

I think that's how it works... You're not just testing features, you're also testing hashes. Weird. But necessary. Very high collision chance with all other PRs.

Codecov Report

Merging #180 into master will decrease coverage by 0.12%.
The diff coverage is 40%.

@@             Coverage Diff              @@
##             master     #180      +/-   ##
============================================
- Coverage     79.07%   78.94%   -0.13%
  Complexity      178      178
============================================
  Files             7        7
  Lines           626      627       +1
============================================
  Hits            495      495
- Misses          131      132       +1

Impacted Files
Coverage Δ
Complexity Δ

src/Mpociot/ApiDoc/Generators/DingoGenerator.php
0% <0%> (ø)
8 <0> (ø)
:arrow_down:

src/Mpociot/ApiDoc/Generators/LaravelGenerator.php
88.88% <50%> (-1.12%)
16 <0> (ø)

...rc/Mpociot/ApiDoc/Generators/AbstractGenerator.php
88.69% <0%> (-0.04%)
85% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db46be8...ed92f93. Read the comment docs.

Thanks!


How to create empty JSON when no records where scrapped?

I am crawling a property site and when there are no properties on the site, the existing json on the disk is not being overwritten.
How to ensure that JSON is written irrespective of records found or not.

The workaround is to create empty JSON before crawling open_spider callback
# Empty file before start crawling
def self.open_spider
   File.open('path/to/output.json', 'w') { |file| file.write([].to_s) }
end


hikaricp doesn't evict connection after receiving RST

09:50:05.888833 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [S], seq<PHONE_NUMBER>, win 62780, options [mss 1460,nop,nop,sackOK,nop,wscale 11], length 0
09:50:05.889062 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [S.], seq<PHONE_NUMBER>, ack<PHONE_NUMBER>, win 62780, options [mss 1452,nop,wscale 11], length 0
09:50:05.889091 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [.], ack 1, win 31, length 0
09:50:05.889401 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [P.], seq 1:86, ack 1, win 31, length 85
09:50:05.889415 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [.], ack 86, win 31, length 0
09:50:05.889747 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1:223, ack 86, win 31, length 222
09:50:05.889869 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [.], ack 223, win 32, length 0
09:50:05.889941 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [P.], seq 86:97, ack 223, win 32, length 11
09:50:05.890085 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 223:1208, ack 97, win 31, length 985
09:50:05.890460 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [P.], seq 97:1167, ack 1208, win 33, length 1070
09:50:05.890761 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1208:1226, ack 1167, win 32, length 18
09:50:05.890915 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [P.], seq 1167:1463, ack 1226, win 33, length 296
09:50:05.891248 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1226:1248, ack 1463, win 33, length 22
09:50:05.891381 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [P.], seq 1463:1474, ack 1248, win 33, length 11
09:50:05.891437 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1248:1285, ack 1474, win 33, length 37
09:50:05.891574 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [P.], seq 1474:1485, ack 1285, win 33, length 11
09:50:05.891650 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1285:1306, ack 1485, win 33, length 21
09:50:05.891818 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [P.], seq 1485:1496, ack 1306, win 33, length 11
09:50:05.892020 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1306:1368, ack 1496, win 33, length 62
09:50:05.892254 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [P.], seq 1496:1507, ack 1368, win 33, length 11
09:50:05.892332 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1368:1386, ack 1507, win 33, length 18
09:50:05.892635 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [P.], seq 1507:1802, ack 1386, win 33, length 295
09:50:05.892936 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1386:1429, ack 1802, win 34, length 43
09:50:05.893202 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [P.], seq 1802:1881, ack 1429, win 33, length 79
09:50:05.894368 IP 10-177-123-159.58152 > <IP_ADDRESS>.33066: Flags [S], seq<PHONE_NUMBER>, win 62780, options [mss 1460,nop,nop,sackOK,nop,wscale 11], length 0
09:50:05.894533 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148、58152: Flags [S.], seq<PHONE_NUMBER>, ack<PHONE_NUMBER>, win 62780, options [mss 1452,nop,wscale 11], length 0
09:50:05.933171 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [.], ack 1881, win 34, length 0

#after being idle for 5 minutes, server sent RST to hikariCP
09:55:06.945007 IP <IP_ADDRESS>.33066 > 10-177-123-159.58148: Flags [R], seq 0, win 0, length 0

#the next request come, hikaricp still used this connection and doesn't receive any response from server,this  caused application timeout
09:56:31.288061 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1429:1442, ack 1881, win 34, length 13
09:56:31.488172 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1429:1442, ack 1881, win 34, length 13
09:56:31.892167 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1429:1442, ack 1881, win 34, length 13
09:56:32.698173 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1429:1442, ack 1881, win 34, length 13
09:56:34.313167 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [P.], seq 1429:1442, ack 1881, win 34, length 13
#sent FIN and evicted this connection
09:56:36.293431 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [F.], seq 1442, ack 1881, win 34, length 0
09:56:37.537179 IP 10-177-123-159.58148 > <IP_ADDRESS>.33066: Flags [FP.], seq 1429:1442, ack 1881, win 34, length 13

i konw i should set maxLifeTime lower than mysql server, but i think connection pool should handle RST flag

@phantomedc What you discussing, a TCP RST, is occurring at a level far below HikariCP.  The first layer would be the TCP stack, next would be Java, next would be the JDBC driver, and finally HikariCP.  I have no idea why RST would not cause TCP/Java to immediately mark the socket as closed.  If it is marked closed, and HikariCP executes an alive test, then it should fail immediately.

Hi @phantomedc,
Very interesting test. Can you help test BeeCP with same way? thanks.


Update checkstyle version to latest.

Update checkstyle to use the latest version (6.6) and the latest plugin (2.15). This is required because the 6.1.1 version does not understand some Java 8 language constructs.

Merged, thanks!


Add one key flow example

Adds the one key flow example for Web3Auth. This works using firebase.

Things to note while documenting: Need to understand how the users are being classified - accordingly when to call torus libraries and when to call web3auth. webpack config changes. this works only on custom verifiers, with custom jwts - why.


Study and create a suitable sketches for pair 1s function

For the function decided in #2, study it and "describe the control flow and relevant modules at an appropriate level using suitable sketches and scribbles as seen in class"

The sketch is here: https://github.com/Melkster/voc/wiki/Sketch-of-how-math-code-is-run


Allow AlphaNum(char)?

This will be useful for StrCat one char in a char array.
https://github.com/abseil/abseil-cpp/blob/070f6e47b33a2909d039e620c873204f78809492/absl/strings/str_cat.h#L245-L246

It's been proposed a number of times. Reasons why we've rejected it include the fact that wanting to print a single char from an array is actually very rare, and that it invites char vs char* errors. Do you have a compelling use case, or is this a speculative improvement?
I'd recommend absl::StrCat(absl::string_view(&c[n], 1)) if you want to StrCat one char from an array.

This use case does happen very rarely and I will use the string_view workaround. Thanks.
I found that absl::strings_internal::AlphaNumBuffer<1> was also an option.


Using with pygmentize?

I'd like to pretty print a markdown source file, and hoped I could use this lexer but it still isn't listed as an option after a pip install.

There is still a lot missing and no release, see installing from source @
https://github.com/jhermann/pygments-markdown-lexer#installation

Cannot reproduce…
$ pygmentize -L | grep markdown
* md, markdown:
    Markdown (filenames *.md, *.mkd, *.markdown)

Please try again with current HEAD and all 'dev-requirements', and reopen with more info if it still fails for you.


Some modules labeled 'esm' are dual

First of all, thanks for doing this project, it's very helpful for looking into the ESM situation in the ecosystem!
I am using the data in data/2024-02-20.json to find high impact packages that are ESM-only in order to test my require(esm) implementation & check the performance. Along the way I noticed that some packages labeled esm seem to be actually dual (at least, the can be both required and imported). So far the packages like this that I've found are:

tslib
fs-extra
axios
parse5
node-releases (this is just a bunch of .json files so can be required or imported with import attributes)
ts-node
@eslint-community/regexpp
babel-plugin-polyfill-regenerator (and other babel plugins too? This is a transpiled file with __esModule)
html-escaper
@ungap/structured-clone
@emotion/hash
@emotion/cache
@emotion/sheet
@emotion/weak-memoize
@swc/helpers
@floating-ui/dom
css-declaration-sorter
@floating-ui/core
marked
redux
(still continuing my testing by going through the list..)

Heya! Thanks!
I guess it’s the import for ESM and then a default condition for CJS. Feels a bit weird to do it that way instead of the inverse, or instead of the require vs import mutually exclusive conditions.
Did you find more?
I’ll investigate next time I crawl. Or, PR welcome!

I guess it’s the import for ESM and then a default condition for CJS.

Yes, this seems quite common actually. Many of them have "type": "module" at the top level package.json, but also another package.json in a folder that has "type": "commonjs", and then in the top level package.json they have conditional exports require or default pointing to that folder (axios, parse5, html-escaper, etc.).
I've put the ones I've found (and the script used to load them with require()) in https://github.com/joyeecheung/test-require-esm/blob/main/dual.cjs

thanks, done!


HexDecoder instantiated using const

This makes sense. Thanks!

I'm on holidays. Can push this to pub in two or three weeks!

@hitecherik pushed to pub.

Thanks!


NETCDF4/HDF5 hanging issue

The following simple NETCDF4/HDF5 test program can reproduce a hanging issue on some supercomputers.
Cori@NERSC
/opt/cray/pe/netcdf-hdf5parallel/<IP_ADDRESS>/INTEL/19.0
/opt/cray/pe/hdf5-parallel/<IP_ADDRESS>/INTEL/19.0
Theta@ALCF
/opt/cray/pe/netcdf-hdf5parallel/<IP_ADDRESS>/INTEL/19.1
/opt/cray/pe/hdf5-parallel/<IP_ADDRESS>/INTEL/19.1
This test case is run with 16 MPI tasks, and only rank 0 to rank 14 have some data to write (start/count is set to 0 for rank 15).
It hangs forever when writing varid 76.
Write varid 0 start
Write varid 0 end
...
Write varid 75 start
Write varid 75 end
Write varid 76 start

It can also be reproduced on my laptop with NetCDF 4.7.1 built with HDF5 1.10.5.
This issue might be related to HDF5 version, since it is not reproducible on ANL workstation compute001 with NetCDF 4.7.3 built with HDF5 1.8.16.
#include <stdio.h>
#include <stdlib.h>
#include <mpi.h>
#include <netcdf.h>
#include <netcdf_par.h>

#define NDIM 3
#define X_DIM_LEN 48000
#define Y_DIM_LEN 72
#define NVARS 80

int main(int argc, char* argv[])
{
  int my_rank;
  int ntasks;
  int dimid[NDIM];
  int elements_per_pe;
  int ncid;
  int varid;
  float *buffer;
  char varname[128];
  size_t start[NDIM];
  size_t count[NDIM];

  MPI_Init(&argc, &argv);

  MPI_Comm_rank(MPI_COMM_WORLD, &my_rank);
  MPI_Comm_size(MPI_COMM_WORLD, &ntasks);

  if (ntasks != 16) {
    if (my_rank == 0)
      printf("Error: this program is intended to run on 16 processes only\n");
    MPI_Finalize();
    return 1;
  }

  nc_create_par("test.nc", NC_CLOBBER | NC_MPIIO | NC_NETCDF4, MPI_COMM_WORLD, MPI_INFO_NULL, &ncid);
  nc_def_dim(ncid, "time", NC_UNLIMITED, &dimid[0]);
  nc_def_dim(ncid, "x", X_DIM_LEN, &dimid[1]);
  nc_def_dim(ncid, "y", Y_DIM_LEN, &dimid[2]);

  for (int i = 0; i < NVARS; i++) {
    sprintf(varname, "var_%d", i);
    nc_def_var(ncid, varname, NC_FLOAT, NDIM, dimid, &varid);
  }

  nc_enddef(ncid);

  elements_per_pe = X_DIM_LEN * Y_DIM_LEN / 15;

  if (my_rank < 15) {
    start[0] = 0;
    count[0] = 1;

    start[1] = my_rank * (X_DIM_LEN / 15);
    count[1] = X_DIM_LEN / 15;

    start[2] = 0;
    count[2] = 72;

    buffer = malloc(elements_per_pe * sizeof(float));
    for (int i = 0; i < elements_per_pe; i++)
      buffer[i] = my_rank;
  }
  else {
    start[0] = 0;
    count[0] = 0;

    start[1] = 0;
    count[1] = 0;

    start[2] = 0;
    count[2] = 0;

    buffer = NULL;
  }

  for (varid = 0; varid < NVARS; varid++) {
    if (my_rank == 0) {
      printf("Write varid %d start\n", varid);
      fflush(stdout);
    }

    nc_var_par_access(ncid, varid, NC_COLLECTIVE);
    nc_put_vara_float(ncid, varid, start, count, buffer);

    if (my_rank == 0) {
      printf("Write varid %d end\n", varid);
      fflush(stdout);
    }
  }

  nc_close(ncid);

  free(buffer);

  MPI_Finalize();

  return 0;
}

OK, I have made a test for this, tst_parallel7.c. It passes for me on my machine.
Let's put the test into the build to make sure is passes for everyone else. If it fails somewhere, then we have learned something. If it passes everywhere, then maybe this bug has been fixed...

Something that you are doing in the code @dqwu which I did not expect users to do...
How come you don't change the variable mode to NC_COLLECTIVE when defining the metadata? I would have expected to see the nc_var_par_access() up before the nc_enddef(). By doing it this way, the mode is independent on most variables but collective on others.

Something that you are doing in the code @dqwu which I did not expect users to do...
How come you don't change the variable mode to NC_COLLECTIVE when defining the metadata? I would have expected to see the nc_var_par_access() up before the nc_enddef(). By doing it this way, the mode is independent on most variables but collective on others.

You are right, I forgot to call nc_var_par_access() before the nc_enddef() in my example code. However, this hanging issue is still reproducible with that minor change.

OK, does the issue occur with the current master and HDF5-1.12.2? Or just with historical versions of HDF5 and/or netcdf-c?

OK, does the issue occur with the current master and HDF5-1.12.2? Or just with historical versions of HDF5 and/or netcdf-c?

I can still reproduce this issue on my laptop with NetCDF 4.7.1 built with HDF5 1.10.5. I will try HDF5 1.12 later.

@edwardhartnett This issue is reproducible with NetCDF 4.7.1 built with HDF5 1.10.6 but not reproducible with NetCDF 4.7.1 built with HDF5 1.10.7. So it is likely a bug of HDF5 1.10.6 or older, which has been fixed in HDF5 1.10.7 or newer.

OK, then let's close this issue. There's not going to be anything we can do to make this work in old releases of HDF5. ;-)

FYI, not sure if it is related to this bug fix in HDF5-1.0.7 release:
Bug Fixes since HDF5-1.10.6 release
==================================

    Library
    -------
    - Fix bug and simplify collective metadata write operation when some ranks
        have no entries to contribute.  This fixes parallel regression test
        failures with IBM SpectrumScale MPI on the Summit system at ORNL.

      (QAK - 2020/09/02)

@dqwu could you please close this issue?

Close this issue since it has been fixed by HDF5 1.10.7.


AC,  all devices go "unavailable"  when power off

Version of the custom_component
version = "0.8.2"
Configuration
used <IP_ADDRESS>/24 to discover IP.
Used the HACS install.
Describe the bug
I was able to add the integration,  but when the  AC is powered off,  all the devices go unavailable.   I have to completely remove, and then add back to get them functioning again.

Debug log
log starts where I pressed the "power off"   in the card.
https://www.toptal.com/developers/hastebin/uwulagemuc.yaml

Thanks @neuman1812 for your logs, there is bug when mode is set to incorrect value. I will provide a workaround soon. Could you also get the device capabilities from /developer-tools/state for your Office AC. Should be something like following:

Can you check how it behaves with new version v0.8.9?

Seems to be working I think.  The power option turns the device off. and it stays available.  However to turn it back on,  you need to select the function,  in my case Cooling, for it to turn back on rather than just selecting the power option again.
A separate issue has also come up. not sure if its related to this.
when attempting to set a lower target temp,  it wont adjust and approx 1min later the card will go to an "off" indication,  but the AC is still running.
This log snippet contains when I adjusted the temp, and when it shows "turned off"
https://www.toptal.com/developers/hastebin/jeluwuqoge.yaml
--quick edit--
In the process of writing this up,  the card now shows "on" with cooling.  but without the lower temp.  I've included more logs from where the previous one ended.
https://www.toptal.com/developers/hastebin/asihoqocah.yaml

Thanks a lot for the logs @neuman1812 , your AC is sending some replies I have not seen before and they confuse the integration: e.g. in your logs sometimes:
2022-05-31 20:41:47 DEBUG (SyncWorker_3) [midea_beautiful.lan] Got several responses on refresh from:

and then the responses start with 0xA1, 0xA2 and so on - that is response type. All the code I've seen knows how to parse 0xA0 or 0xC0, but not those. So I'm going to see if I can ignore those or not.
Which mobile app are you using?

Hello guys. Looks like a similar issue on my side. Here are my logs:
Logger: custom_components.midea_dehumidifier_lan.appliance_coordinator
Source: custom_components/midea_dehumidifier_lan/appliance_coordinator.py:130
Integration: Midea Air Appliances (LAN) (documentation, issues)
First occurred: 11:59:30 (37 occurrences)
Last logged: 12:35:30

Unexpected error fetching Conditioner data: int() argument must be a string, a bytes-like object or a number, not 'NoneType'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 191, in _async_refresh
    self.data = await self._async_update_data()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 150, in _async_update_data
    return await self.update_method()
  File "/config/custom_components/midea_dehumidifier_lan/appliance_coordinator.py", line 107, in _async_appliance_refresh
    await self._async_do_update()
  File "/config/custom_components/midea_dehumidifier_lan/appliance_coordinator.py", line 130, in _async_do_update
    setattr(self.appliance.state, attr, self.updating[attr])
  File "/usr/local/lib/python3.9/site-packages/midea_beautiful/appliance.py", line 657, in mode
    mode = int(mode)
TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'

Does somebody know what is the issue and how to fix this?

@max-cross can you check if problem persists in version 0.8.10?

@max-cross can you check if problem persists in version 0.8.10?

Yes, after changing a few modes on the AC, it became unavailable. Also, I noticed that changing temperature also doesn't work, it just does nothing when I change the temperature

Closing as investigation is ongoing in #72

I don't see capabilities data here.  It's everything else.
On Tue, May 31, 2022, 5:45 AM Nenad Bogojevic @.***>
wrote:

Thanks @neuman1812 https://github.com/neuman1812 for your logs, there
is bug when mode is set to incorrect value. I will provide a workaround
soon. Could you also get the device capabilities from
/developer-tools/state for your Office AC. Should be something like
following:
[image: image]
https://user-images.githubusercontent.com/1485503/171144698-de5a89ce-ce00-477d-bacb-c28b336933ae.png
—
Reply to this email directly, view it on GitHub
https://github.com/nbogojevic/homeassistant-midea-air-appliances-lan/issues/58#issuecomment-1141913806,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACGWVLXLXKDQGQSIKCV6MSDVMXNTLANCNFSM5XHBRCKQ
.
You are receiving this because you were mentioned.Message ID:
<nbogojevic/homeassistant-midea-air-appliances-lan/issues/58/1141913806@
github.com>


Add Alpine icon

Description

This PR introduces a new Alpine JS logo to the Icons.ts

Hello! Thank you for opening your first PR to Starlight! ✨
Here’s what will happen next:

Our GitHub bots will run to check your changes.
If they spot any issues you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean!

In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.


Crashing on android

Description
Crashing on android when calling initConnection().then
Screenshots
Environment: android

react-native-iap:10.0.3
react-native:0.68.2
Platforms (iOS, Android, emulator, simulator, device): android phone

try getProducts({skus:....}


PSReviewUnusedParameter does not detect our variables well

Current peaster tests complains a lot about unused variables. Most of function parameters are used like
$Values = . Get-ParameterValue $MyInvocation.MyCommand.Parameters

so 'PSReviewUnusedParameter' test does not detect those correctly.
As I see  we could disable that test.

I'm not absolute sure that this is really needed, but I keep this here as reminder.


Client TLS handshake failed since 10.1.2

Problem Description
Only appeared at 10.1.2+, (10.1.1 and 9.0.1 are fine) so certification pinning is not related.
(venv) PS> mitmweb -p 58080
[08:44:07.112] HTTP(S) proxy listening at *:58080.
[08:44:07.112] Web server listening at http://<IP_ADDRESS>:8081/
[08:44:07.960] 403 GET //updates (<IP_ADDRESS>) 0.00ms
[08:44:08.457][[::1]:54408] client connect
[08:44:08.473][[::1]:54408] server connect login.microsoftonline.com:443 (<IP_ADDRESS>:443)
[08:44:08.916][[::1]:54408] Client TLS handshake failed. The client may not trust the proxy's certificate for login.microsoftonline.com (OpenSSL Error([('SSL routines', '', 'decryption failed or bad record mac')]))
[08:44:08.916][[::1]:54408] client disconnect

Steps to reproduce the behavior:

Installed latest Azure Powershell sdk (https://github.com/Azure/azure-powershell/releases)
mitmweb -p 58080
set proxy to http://localhost:58080: according to https://learn.microsoft.com/en-us/powershell/azure/az-powershell-proxy?view=azps-11.0.0
try run powershell command: Connect-AzAccount

System Information
Paste the output of "mitmproxy --version" here.
Mitmproxy: 10.1.2
Python:    3.12.0
OpenSSL:   OpenSSL 3.1.4 24 Oct 2023
Platform:  Windows-2022Server-10.0.20348-SP0

FYI: the working versions:
Mitmproxy: 10.1.1
Python:    3.12.0
OpenSSL:   OpenSSL 3.1.4 24 Oct 2023
Platform:  Windows-2022Server-10.0.20348-SP0

Mitmproxy: 9.0.1 binary
Python:    3.11.0
OpenSSL:   OpenSSL 3.0.7 1 Nov 2022
Platform:  Windows-10-10.0.20348-SP0

Thanks for bisecting versions! 🍰 😃
Looking at the changes between 10.1.1 and 10.1.2, the only reasonable candidate is https://github.com/mitmproxy/mitmproxy/commit/c3d2a9dac491f3588e8e53e542b8bf10d6d5b352. Now the big question is why this is breaking things. Do you see any error message after running Connect-AzAccount?

find another way of reproducing, just curl like below
$ curl --proxy http://localhost:8080 https://login.microsoftonline.com --ssl-no-revoke -vvv
* processing: https://login.microsoftonline.com
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying [::1]:8080...
* Connected to localhost (::1) port 8080
* CONNECT tunnel: HTTP/1.1 negotiated
* allocate connect buffer
* Establish HTTP proxy tunnel to login.microsoftonline.com:443
> CONNECT login.microsoftonline.com:443 HTTP/1.1
> Host: login.microsoftonline.com:443
> User-Agent: curl/8.2.1
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 200 Connection established
<
* CONNECT phase completed
* CONNECT tunnel established, response 200
* schannel: disabled automatic use of client certificate
* schannel: SEC_E_UNTRUSTED_ROOT (0x80090325) - The certificate chain was issued by an authority that is not trusted.
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
* Closing connection
* schannel: shutting down SSL/TLS connection with login.microsoftonline.com port 443
curl: (60) schannel: SEC_E_UNTRUSTED_ROOT (0x80090325) - The certificate chain was issued by an authority that is not trusted.
More details here: https://curl.se/docs/sslcerts.html

curl failed to verify the legitimacy of the server and therefore could not
establish a secure connection to it. To learn more about this situation and
how to fix it, please visit the web page mentioned above.

double confirmed that I've already installed the p12 file.
And if create a mitmproxy 10.1.1 instance listening at another port, the curl works fine:
* processing: https://login.microsoftonline.com
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying [::1]:58080...
* Connected to localhost (::1) port 58080
* CONNECT tunnel: HTTP/1.1 negotiated
* allocate connect buffer
* Establish HTTP proxy tunnel to login.microsoftonline.com:443
> CONNECT login.microsoftonline.com:443 HTTP/1.1
> Host: login.microsoftonline.com:443
> User-Agent: curl/8.2.1
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 200 Connection established
<
* CONNECT phase completed
* CONNECT tunnel established, response 200
* schannel: disabled automatic use of client certificate
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0* using HTTP/1.x
> GET / HTTP/1.1
> Host: login.microsoftonline.com
> User-Agent: curl/8.2.1
> Accept: */*
>
< HTTP/1.1 302 Found
< Cache-Control: no-store, no-cache
< Pragma: no-cache
< Content-Type: text/html; charset=utf-8
< Expires: -1
< Location: https://www.office.com/login#
< Strict-Transport-Security: max-age=31536000; includeSubDomains
< X-Content-Type-Options: nosniff
< P3P: CP="DSP CUR OTPi IND OTRi ONL FIN"
< x-ms-request-id: f9479479-f195-4812-8c27-3a1ada5d0900
< x-ms-ests-server: 2.1.16878.3 - SEASLR1 ProdSlices
< X-XSS-Protection: 0
< Set-Cookie: fpc=Al0BPsbEgcpPhdyJ__8_0no; expires=Sun, 31-Dec-2023 03:23:16 GMT; path=/; secure; HttpOnly; SameSite=None
< Set-Cookie: esctx=PAQABAAEAAAAmoFfGtYxvRrNriQdPKIZ-xr8ABw_NhXnYAy3wngJaQbI1rYi2GeQpX0PKisXCMny-cDMzV1nMtRt7reMep75dq1CZYiFcHtbFGPJ_eSbNXB4vUcwQeS9OUIMJCGa1SQtTu8ttklbdnWAti2q2yuW9q2Fb7jLbuzoztmHd9XLnyj9uyMpYzceNA773JM27Va0gAA; domain=.login.microsoftonline.com; path=/; secure; HttpOnly; SameSite=None
< Set-Cookie: x-ms-gateway-slice=estsfd; path=/; secure; samesite=none; httponly
< Set-Cookie: stsservicecookie=estsfd; path=/; secure; samesite=none; httponly
< Date: Fri, 01 Dec 2023 03:23:15 GMT
< Content-Length: 146
<
{ [146 bytes data]
100   146  100   146    0     0    139      0  0:00:01  0:00:01 --:--:--   139<title>Object moved</title>

Object moved to here.

* Connection #0 to host localhost left intact

I've been banging my head against this problem for a while now. I had previously posted to a discussion thread hoping that someone had encountered this.
From what I've seen this seems to be isolated to Windows CryptoAPI, as browsers are not affected and correctly trust an installed certificate. Interestingly, IIS hosted projects don't exhibit the problem. It would seem that programs that circumvent windows build-in certificate checking (or maybe use some special parameters) work properly.

I will be reunited with my Windows machine some time next week. In the meantime, if someone could verify that reverting https://github.com/mitmproxy/mitmproxy/commit/c3d2a9dac491f3588e8e53e542b8bf10d6d5b352 does indeed fix this, that'd be great. Of course, a PR with a proper fix is would fantastic. :)

Similarly, I encountered this with a Windows application that uses the system WinHttp API (not for browsing, just HTTPS requests to different API services).

I will be reunited with my Windows machine some time next week. In the meantime, if someone could verify that reverting c3d2a9d does indeed fix this, that'd be great. Of course, a PR with a proper fix is would fantastic. :)

I can try this during the weekend.

if someone could verify that reverting https://github.com/mitmproxy/mitmproxy/commit/c3d2a9dac491f3588e8e53e542b8bf10d6d5b352 does indeed fix this

I checked version 10.1.5 with the lines from this commit commented out - and now everything worked correctly.

Ok, I did some testing and I think I know the issue.
What I've noticed is that we are reusing the same private key from CA certificate for domain certification. This means that both subject and authority key identifiers are the same (and the same as root CA subject key identifier). What I think is happening is that Windows CryptoAPI validates the subject against itself instead of its issuer - mitmproxy root CA. It tracks with my previous testing where .NET HttpClient fails even in custom trust mode.
We could generate a separate private key (either temporary or persisted). A temporary key could be stored in memory and reused during the lifetime of the session, a persistent key could be stored in the same manner as certificates are store now.
I can look into it tomorrow, however I don't know how much time I'll have to make a proper PR for this.

This is now fixed in mitmproxy 10.1.6. 😃


Webhook over corporate proxy

Environment
Platform: Kubernetes Rancher / RKE2
Kubernetes/Platform Version(s): v1.25.11+rke2r1
OS: SLES15-SP4
NeuVector Version: 5.2.1 / 2.6.2
Describe the bug
We run NeuVector on-premise behind a corporate proxy. If we try to send Webhooks (for example to MS Teams) they never arrive.
The same Webhooks to an internal endpoint will be sent as expected.
Proxy configuration in NeuVector >> Settings is activated. We can't see any errors in the log files. Is it possible to send Webhooks over a proxy instance?
To Reproduce
Steps to reproduce the behavior:

Deploy NeuVector in air gapped environment / behind a corporate proxy
Configure proxy settings in NeuVector
Create a Webhook for an external endpoint (e.g. MS Teams)
Create a Response Rule with the Webhook
Trigger the Response Rule

Expected behavior
Webhooks / Response Rule messages arrive as expected.

The "Support webhooks through a proxy" feature has been added since NeuVector version 5.3.0.
https://open-docs.neuvector.com/releasenotes/5x#530-february-2024


feat(table): column selection (no reordering yet)

Summary
Added column selection.  Reordering is not supported yet, and the design will change (see related issue)... but the props interface won't change.

Change List (commits, features, bugs, etc)
(see PR)
Related Issues
https://github.com/IBM/carbon-addons-iot-react/issues/28
Acceptance Test (how to verify the PR)

Test column toggling on/off in the stateful storybook example
View the new static story

:tada: This PR is included in version 1.12.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

@bryancboyd the size of the buttons should be using the small version. I'm not sure if the use of gray is appropriate, it's the same style as carbon's tertiary button, and the color is closer to the Disabled state.

:tada: This PR is included in version 1.12.0 :tada:
The release is available on npm package (@release-1.x dist-tag)
Your semantic-release bot :package::rocket:


pack subcommand improvements for --find and --install

Reworded usage help text.
Patterns match anywhere within the part number.
Added Installed column to --find output showing whether the containing pack is installed and the target is available.

/morph test


Could not login to APIM apps using social logins

Description:
Followed steps in [1] and [2]. After login through facebook and IS a user consent error occurs without directing to publisher/store.

[1] https://docs.wso2.com/display/AM220/Log+in+to+the+API+Store+using+Social+Media
[2] https://docs.wso2.com/display/AM220/Configuring+Identity+Server+as+IDP+for+SSO
Suggested Labels:

Suggested Assignees:

Affected Product Version:
APIM 2.2.0

Closing the issue as this is older than 3 years. Please reopen if the issue is valid still.


Go1.18.5

Adds the go1.18.5 release

We should probably go all the way to 1.18.6. I suppose we could add that rebase as a follow-up PR.

Yeah, I was going to open another one right after for that. But felt breaking it into two would keep the review of changes smaller.


doc on ai metrics

Description
This PR is providing info on how to to expose and visualize AI metrics through Prometheus and Grafana. These metrics include the number of AI requests, the cost associated with AI services, and the token usage per provider and model.

Testing instructions
Preview link:
Checklist

[ ] Review label added
[ ] Conditional version tags added, if applicable.

@lena-larionova  Yes it LGTM we are ready to merge :)


KYLIN-1366 Bind metadata version with release version

https://issues.apache.org/jira/browse/KYLIN-1366

Merged by @binmahone into 2.x-staging


Define an API for Colorspace control

Today all color values are linear RGB. Users should be able to specify sRGB as an output space, but by default all color values from the user should be considered linear.

Color input should be probably be a palette type to be type-safe about gamma and space.


Installation of OpenME on OS X

I know that OS X isn't officially supported, so I understand that some features might not work. However, it would be nice if OpenME can be installed through ck on OS X.
If I follow the getting started guide, OpenME is automatically installed. However, this fails on my system:
cnugteren$ ck compile program:cbench-automotive-susan --speed
***************************************************************************************
Current directory: /Users/cnugteren/CK/ctuning-programs/program/cbench-automotive-susan/tmp
***************************************************************************************
Resolving dependencies ...
==========================================================================================
WARNING: environment was not found using tags="lib,xopenme" and setup={"target_os_bits": "64", "host_os_uoa": "linux-64", "target_os_uoa": "linux-64"}
  Would you like to search and install package with these tags automatically (Y/n)? Y
CK error: environment was not found using tags="lib,xopenme" and setup={"target_os_bits": "64", "host_os_uoa": "linux-64", "target_os_uoa": "linux-64"}!

When installing it explicitly, there is a more informative error message:
cnugteren$ ck install package:lib-rtl-xopenme

Resolving dependencies ...

Searching if environment already exists using:
  * Tags: lib,rtl,xopenme,lang-c,lang-cpp,lang-f77,lang-f90,lang-f95,v0.3,v0,host-os-linux-64,target-os-linux-64,64bits
  * Dependency: compiler=44609897464b20a3

Environment not found ...

*** Installation path used: /Users/cnugteren/CK-TOOLS/lib-rtl-xopenme-0.3-gcc-local-linux-64

Resolving dependencies ...

Copying XOpenME to src dir ...

Building static library ...

Executing gcc -O3 -fPIC -c  -I .     xopenme.c
Executing ar rcs -o librtlxopenme.a xopenme.o
ar: illegal option combination for -r
usage:  ar -d [-TLsv] archive file ...
	ar -m [-TLsv] archive file ...
	ar -m [-abiTLsv] position archive file ...
	ar -p [-TLsv] archive [file ...]
	ar -q [-cTLsv] archive file ...
	ar -r [-cuTLsv] archive file ...
	ar -r [-abciuTLsv] position archive file ...
	ar -t [-TLsv] archive [file ...]
	ar -x [-ouTLsv] archive [file ...]
Error: Compilation failed in /Users/cnugteren/CK-TOOLS/lib-rtl-xopenme-0.3-gcc-local-linux-64/src!
CK error: processing archive failed!

Thanks for the feedback, Cedric!
Well, I have some descriptions of Mac OS (see ck list os), but it seems not to be properly detected.
In fact, I do not have Apple computers and couldn't check it.
However, the problem here is in -o flag in ar. I noticed that some OS has it and some not. I will need to think how to fix it without breaking compatibility ...

As a temporal hack, you can find entry:
ck find env:compiler-gcc-local-linux-h64-t64
and then edit 'env.sh'.
Just substitute
export CK_LB_OUTPUT="-o "
with
export CK_LB_OUTPUT=""
This should make examples work on your machine, while I look for better solution ;) ...

The last: I did some changes in CK repositories, so before changing anything do
ck pull all --kernel

I think I made a proper fix: now CK should automatically detect that it runs on MacOS and select appropriate environment. I also added GCC description for MacOS where I removed -o flag from ar.
Please, update all CK via

ck pull all --kernel

Also, if you used above fixes, you can delete your local environments (they are wrong and for Linux anyway) via

ck rm local:env:*

Please, tell me this will work for you?

After ck pull all --kernel the installation of package:lib-rtl-xopenme finishes successful, so your fix works! However, I had to do this manually (using ck install package:lib-rtl-xopenme): the ck compile program:cbench-automotive-susan --speed command didn't manage to install the library itself (same behaviour as before).

Cool. Good that manual installation works. It means that Mac OS is now properly detected. As for automatic installation - I need to check it. It's actually quite difficult without Mac OS (I need to talk to my colleagues - maybe they will lend me such laptop). I keep this ticket open and maybe will ask you a few more things to try later ...

I think I found a problem.  I fixed the problem and committed.
May I ask you to try again (just remove the environment for xopenme as I mentioned in a previous ticket). Thanks!

That's it! I removed xopenme and then asked to compile the example. It now correctly installs xopenme after typing Y and then compiles the example.

Super!  Thanks!


PlateGridInfo parsing to support measure annotations only when plate set only has a single plate

Rationale
We have an example file of graphical plate assay data with multiple measures where the plate annotations are the measure names/labels but the header annotations do not have the plate identifier. We can support this scenario with a small code change so that if the plate set selected only has a single plate, we use that as the plate for the import and assume that the single annotation is the measure name.
Changes

PlateGridInfo check for single plate in plate set for the single annotation case

Seems fine, just curious was this found by a client (or internal testing), it seems like such a corner case.

This was based on an example data file provided by a sales prospect.


1931 Part 2: 1710 Cross network favorites

Fixes #1710
Kinda a weird one to fit in the middle but wanted this work to be done prior to the Local Storage migration actually is done so that the typing is setup.
This PR handles adding the network prefix to the cached favorite string. It also adds some helper functions to get the network prefix and chain id via the network prefix to allow for the UI around the favorites.

Found a much better solution. (kinda a duh. moment).
Soo. one thing is missing here. pulling the DAO's name on a different network. I have it almost setup but the last thing is targeting the right registry contract. I tried to find a way to make this work but ultimately I started rubbing up against the updates @adamgall is making in the typechain rework. I need those updates ha! then this will be a piece of cake.

As far as the throw errors. I don't believe it will EVER hit here. Unsupported networks are caught way up the food chain. I did this more or less so I didn't have to type our a null or undefined. Since these settings come from hardcoded settings it shouldn't ever throw

As far as the throw errors. I don't believe it will EVER hit here. Unsupported networks are caught way up the food chain. I did this more or less so I didn't have to type our a null or undefined. Since these settings come from hardcoded settings it shouldn't ever throw

Which comment was this in reference to?

As far as the throw errors. I don't believe it will EVER hit here. Unsupported networks are caught way up the food chain. I did this more or less so I didn't have to type our a null or undefined. Since these settings come from hardcoded settings it shouldn't ever throw

Which comment was this in reference to?

these comments

I feel like these (and getChainIdFromPrefix usage above) could be wrapped a useMemo, where we could gracefully handle exceptions and return some acceptable default/error data.

So similar to my answer to @adamgall is this should never throw here. As the app won't let you connect to a network that isn't supported and since we are directly using the same configuration files.
So IMO, its not needed. But if yall (@adamgall had similar thoughts) are not satisfied with my answer and can figure out the changes needed to make this happen, Though hard to test since the app itself won't let you switch to an unsupported network.

I feel like these (and getChainIdFromPrefix usage above) could be wrapped a useMemo, where we could gracefully handle exceptions and return some acceptable default/error data.

So similar to my answer to @adamgall is this should never throw here. As the app won't let you connect to a network that isn't supported and since we are directly using the same configuration files.
So IMO, its not needed. But if yall (@adamgall had similar thoughts) are not satisfied with my answe, then I can figure out the changes needed to make this happen, Though hard to test since the app itself won't let you switch to an unsupported network.

Try/catching errors like this (ones that we know "should never happen") are precisely the point.
I'd like us to get into the habit of building more bulletproof code.
If there's a possibility for a line of code to throw (when evaluating it without any extra context) (and there is in this instance) let's catch it and bubble it up.

@Da-Colon j/w, do you plan on doing anything more with this PR? https://decentdao.slack.com/archives/C06QZ68L5SA/p1718121588983869

@adamgall Yessir. I'm creating a
Placing an error Boundary with a Fallback UI, around Where this might fail.

@decentdao/product @decentdao/design Yall good with the look and copy?

@DarksightKellar I didn't add the useMemo as suggested with the error boundary this handles this error as is


feat: cmd support stream log output #544

What type of PR is this?

/kind feature
What does this PR do?

Which issue(s) does this PR fix?

Fixes #544
Special notes for your reviewer:

Does this PR introduce a user-facing change?

/lgtm
/approve


fixes #199

Codecov Report

Merging #200 (8724272) into main (032e256) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #200   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           47        47
  Lines         4349      4341    -8
=========================================
- Hits          4349      4341    -8

Impacted Files
Coverage Δ

blacksheep/client/pool.py
100.00% <0.00%> (ø)

blacksheep/server/responses.py
100.00% <0.00%> (ø)

blacksheep/client/connection.py
100.00% <0.00%> (ø)

blacksheep/server/controllers.py
100.00% <0.00%> (ø)

blacksheep/common/files/asyncfs.py
100.00% <0.00%> (ø)

blacksheep/server/files/__init__.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf3049...8724272. Read the comment docs.


Better homepage account setup flow

A couple ideas for a homepage/account setup UX better than the current wall of text:

First, ask new users whether they want to cross post from their web site to an existing fediverse account, or make their web site into its own fediverse account.

If the former, redirect to https://brid.gy/
If the latter, continue

Text box to enter their web site. When they do:

Check their redirects. If they're not right, show onboarding instructions.
Otherwise, show their user page.

Done!


(Low Pri) - UI - Menu buttons, when the menu is on the side, in smaller screens, the last buttons cannot be reached

Implement either scrolling or scaling on that menu

Scrolling: not sure, but probably an ion-content wrapping the menu would do (or be a first step)
Scaling, see how ionic doe it for its menu items and mimick it (vertically);

Well done


Changes to netdcli to read state using the GET interface of netmaster

Other changes:

a fix in netmaster's get logic to return error if the read fails or endpoint doesn't exist.
changes in system test to invoke netdcli on the first node where netmaster's single instance is started and binds to localhost address right now.

This depends on #111

LGTM


vim: 8.2.3877 -> 8.2.4053

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/vim/versions.
meta.description for vim is: "The most popular clone of the VI editor"
meta.homepage for vim is: "http://www.vim.org"
meta.changelog for vim is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
/nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053/bin/rvim passed the binary check.
/nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053/bin/rview passed the binary check.
/nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053/bin/vim passed the binary check.
/nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053/bin/vimtutor passed the binary check.
/nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053/bin/view passed the binary check.
/nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053/bin/vi passed the binary check.
/nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053/bin/xxd passed the binary check.
/nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053/bin/ex passed the binary check.
/nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053/bin/vimdiff passed the binary check.
8 of 9 passed binary check by having a zero exit code.
8 of 9 passed binary check by having the new version present in output.
found 8.2.4053 with grep in /nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053
found 8.2.4053 in filename of file in /nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053

Rebuild report (if merged into master) (click to expand)

1243 total rebuild path(s)

1170 package rebuild(s)

1168 x86_64-linux rebuild(s)
75 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
appimagekit
apt-dater
astroid
backintime
backintime-common
backintime-qt
bareos
bitwuzla
byobu
ceph
ceph-client
ceph-csi
ceph-dev
cron
cryptominisat
diffoscope
diffoscopeMinimal
docbookrx
doomseeker
expliot
ezquake
faraday-cli
faust
faust2
faust2alqt
faust2alsa
faust2csound
faust2firefox
faust2jack
faust2jackrust
faust2jaqt
faust2ladspa
faust2lv2
faustPhysicalModeling
faustStk
faustlive
fcron
foo-yc20
foo2zjs
git-machete
hip
i3-layout-manager
kapitonov-plugins-pack
klee
libceph
libdigidocpp
libretro.pcsx2
lua51Packages.gitsigns-nvim
lua52Packages.gitsigns-nvim
lua53Packages.gitsigns-nvim

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A vim https://github.com/r-ryantm/nixpkgs/archive/c61d77e8479f166808d07e4ac5f3ed173b8355bc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053
ls -la /nix/store/0xj1kbqbap06yhwr4ik3w11lfj597rf0-vim-8.2.4053/bin

Pre-merge build results
NixPkgs review skipped

Maintainer pings
cc @lovek323 @equirosa for testing.

Obsoleted by #155587


Fix flaky test: support to interrupt the thrift request if remote engine is broken

Why are the changes needed?

https://github.com/apache/kyuubi/actions/runs/5307034060/jobs/9605209396
- support to interrupt the thrift request if remote engine is broken *** FAILED ***
  "org.apache.kyuubi.KyuubiSQLException: Error operating ExecuteStatement: Socket for SessionHandle [68f22014-c484-4279-8f79-81bd2e7f0eca] is closed" did not contain "java.net.SocketException", and "org.apache.kyuubi.KyuubiSQLException: Error operating ExecuteStatement: Socket for SessionHandle [68f22014-c484-4279-8f79-81bd2e7f0eca] is closed" did not contain "org.apache.thrift.transport.TTransportException", and "org.apache.kyuubi.KyuubiSQLException: Error operating ExecuteStatement: Socket for SessionHandle [68f22014-c484-4279-8f79-81bd2e7f0eca] is closed" did not contain "connection does not exist" (KyuubiOperationPerConnectionSuite.scala:330)

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #4979 (86807e7) into master (c523853) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #4979   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         561     561
  Lines       30954   30954
  Branches     4060    4060
======================================
  Misses      30954   30954

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Thanks, merged to master/1.7


Prebuilt version

Add a prebuilt version on Releases for Windows and possibly Linux.

Can you not install Rust on your system?

Can you not install Rust on your system?

OK.


Pin test host env for stable memory location

depends and based on #918

pls update wasm

pls update wasm


Playing from playlist fails if the playlist contains locally added tracks

Describe the bug
When trying to play any song from a playlist that contains locally added songs (a song not available on spotify by default), it will not pass any audio to librespot-java and an IllegalArgumentException is thrown.
To Reproduce
Create a playlist and add some local songs to it, as well as spotify songs. Then, try to play them and send them to librespot-java.
Expected behavior
The song will start playing on the speaker.
Screenshots/Stracktraces/Logs
Exception in thread "handle-packet-2034787828" java.lang.IllegalArgumentException: Unknown uri: spotify:local:Wuki:Wukileaks+Secret+Stash:Pon+De+Time+%28Nitti+Gritti+Edit%29:152
	at xyz.gianlu.librespot.mercury.model.PlayableId.fromUri(PlayableId.java:16)
	at xyz.gianlu.librespot.player.remote.Remote3Track.id(Remote3Track.java:83)
	at xyz.gianlu.librespot.player.remote.Remote3Track.toTrackRef(Remote3Track.java:77)
	at xyz.gianlu.librespot.player.remote.Remote3Track.addToState(Remote3Track.java:55)
	at xyz.gianlu.librespot.player.Player$StateWrapper.updateContext(Player.java:771)
	at xyz.gianlu.librespot.player.Player.updateContext(Player.java:295)
	at xyz.gianlu.librespot.player.Player.handleLoad(Player.java:430)
	at xyz.gianlu.librespot.player.Player.handleFrame(Player.java:110)
	at xyz.gianlu.librespot.player.Player.frame(Player.java:206)
	at xyz.gianlu.librespot.spirc.SpotifyIrc$SpircListener.event(SpotifyIrc.java:199)
	at xyz.gianlu.librespot.mercury.MercuryClient$InternalSubListener.dispatch(MercuryClient.java:287)
	at xyz.gianlu.librespot.mercury.MercuryClient.handle(MercuryClient.java:171)
	at xyz.gianlu.librespot.core.PacketsManager$Looper.lambda$run$0(PacketsManager.java:64)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

Version/Commit
Latest version built from source (as of today)

I've temporarily fixed on my build by adding this on line 771 on Player.java:
if (track.uri.contains("spotify:local")) continue;

I did not think that local songs would be passed to an external player. Your workaround should be fine and I'll use a similar one while we investigate how to implement this functionality.

Well, my previous workarround didn't work very well. I now have a new workarround which always works, but it's not the best solution.
The trick is, in the PlayableId.java interface, in the fromUri function, add this else if statement:
        } else if (uri.contains("spotify:local")) {
            return TrackId.fromUri("spotify:track:7GhIk7Il098yCjg4BQjzvb"); // Return "Never gonna give you up"
        }

This will return a PlayableId from the song "Never Gonna Give You Up" if the song it's trying to play is an unplayable local song. Hope this helps a little bit more!
Thanks :)

Should be fixed now, but you may still experience some issues due to the fact that removing the track messes up the options.skip_to.track_index. I'll take care of this ASAP.

You can't play local tracks with Spotify Connect. Although this could be a pretty interesting feature, I'm closing this for now.

You can't play local tracks with Spotify Connect. Although this could be a pretty interesting feature, I'm closing this for now.

I know! To play them you would need to have the playlist downloaded (at least in Android), I was just pointing out the error :P
Thanks for fixing it!


added videos to laughing therapy page

issue #383
https://user-images.githubusercontent.com/94471189/189647436-b0edefa7-5902-4389-9c0a-0e89f9f142ce.mp4

issue #383
@Susmita-Dey Should I include one more video to maintain consistency?

@Vanshiii203 Yes you can

@Susmita-Dey  I've pulled the latest code.


run php artisan route:cache,route bindings wrong

When I use the route cache, the prefix route binding parameters will report an error, so I trace the source code and modify it here is no problem

Thanks. Please send to the 7.x branch, and address the tests.


File type with permission anyone with the link can view, comment and edit are not working.

If a user creates a file with a permission type of anyone with the link can view/comment/edit the file and shares it in the channel, not every user is able to access the file with the link. It actually requires the access from the file owner to open that file. This issue is common for all permissions namely view, comment and edit with anyone with the link

I have done the fresh setup of plugin and when I create file with anyone can view,edit or comment permissions i am getting correct permissions on the file. Can you share steps, screenshots or video recordings of issue you have mentioned @AayushChaudhary0001

@AayushChaudhary0001 can you provide more information here.

@darkLord19 I have tested this again and this issue is reproducible on my side. I also though that it might be an issue of same organization, but the issue persists in sharing the file with the same organization members.
Steps to reproduce:-

Create a doc/slide/sheet through the slash command
Share the same file created in the channel/by default it will be shared through the functionality in the modal.
Try to open the file through any other user's account.

The user would need a file access from the file owner.

@AayushChaudhary0001 can you share server logs of file creation?

Here they are:-
error app/plugin_api.go:976 timestamp=2024-09-18 11:09:47.203 Z plugin_id=com.mattermost-community.plugin-google-drive pageToken=109294 Owner of the file performed this action
error app/plugin_api.go:976 timestamp=2024-09-18 11:09:48.037 Z plugin_id=com.mattermost-community.plugin-google-drive pageToken=109294 Owner of the file performed this action
error app/plugin_api.go:976 timestamp=2024-09-18 11:11:42.267 Z plugin_id=com.mattermost-community.plugin-google-drive err=googleapi: Error 403: The user does not have sufficient permissions for this file., insufficientFilePermissions fileID=1YLlGueI0MZ4MBEORIzgNHSWtdfMA2cuJ5c2nhSgV1bc something went wrong while updating permissions for file
Please let me know if I can provide any additional information.


BatchListener commits for every record in the batch instead of last one.

When using the BatchListenerAcknowledgment and acknowledging the Acknowledgement given along with the batch with MANUAL_IMMEDIATE - it seems that the offset is committed for EACH record in the batch which is very chatty and hinders performance.
The below code in question seems to be the cause:
@Override
public void acknowledge() {
	try {
		Assert.state(ListenerConsumer.this.isAnyManualAck,
		"A manual ackmode is required for an acknowledging listener");
		for (ConsumerRecord<K, V> record : this.records) {
			ListenerConsumer.this.acks.put(record);
		}
	} catch (InterruptedException e) {
		Thread.currentThread().interrupt();
		throw new KafkaException("Interrupted while queuing ack for " + this.records, e);
	}
	if (this.immediate) {
		ListenerConsumer.this.consumer.wakeup();
	}
}

I suggest we switch to adding the last record from the list for acknowledgment:
@Override
public void acknowledge() {
	try {
		Assert.state(ListenerConsumer.this.isAnyManualAck,
		"A manual ackmode is required for an acknowledging listener");
		if(!this.records.isEmtpy()) {
                     	ListenerConsumer.this.acks.put(this.records.get(this.records.length() - 1));
                }
	} catch (InterruptedException e) {
		Thread.currentThread().interrupt();
		throw new KafkaException("Interrupted while queuing ack for " + this.records, e);
	}
	if (this.immediate) {
		ListenerConsumer.this.consumer.wakeup();
	}
}

That's by design; the manual methods are entirely in your domain - you have complete control of when the offset is committed. You should only acknowledge when you want the commit applied. If you want to commit at the end of each batch, let the container do the commits (AckMode.BATCH).

Oops; sorry; misread the issue.

Oh! That is good catch!
Meanwhile I am fully agree with you that no reason to commit offsets for all the records in batch, I think we can't make an assumption that the last one has the highest offset.
So, my suggestion is to iterate throughout the this.records to find max offset.
I won't mind if there is really some provement that "the max is always in the end of batch" .
Contribution are welcome!

Agreed. The highest offset needs to be committed, not necessarily the last item on the list.
I would be happy to work on it and submit a PR.

@artembilan It was actually a bit more than the highest offset in the list. As your tests demonstrated, not all messages might be from the same partition. Therefore, there was a need for getting the highest offset per partition.

@artembilan It was actually a bit more than finding the highest offset from the list. As your tests demonstrated, the batch might contain records from different partitions. Therefore, there was a need to find the highest offset for each partition.

Fixed via https://github.com/spring-projects/spring-kafka/commit/db0516d786d044cd83237719b8e715be30c05f91


Side Bar with Lists, Checkboxes, Text

Currently, extension authors seem to be limited to TreeViews in the VSCode Side Bar. Correct me if I'm wrong.
Feature Request:
I'm developing an extension that requires more diverse UI in the Side Bar. Nothing complicated, just basic:

lists
checkboxes
text (currently limited to a single TreeItem line with no formatting)

Notice that several of these requested items already exist in the side panel of core features which do not share the same limitations of extensions:

lists in the extension view

checkboxes in the debugger via a webviewlet

A Side Bar that can only use TreeView's is extremely limiting.
Is it possible to add non-TreeView UI to the Side Bar in current extensions? If so, can the documentation be amended in the "Extending Workbench" section to accomodate how? Happy to help contribute docs with some guidance.
If not, can I help contribute to VSCode in any way to help make any of the above functionality possible?

We only support tree views right now.
See also https://github.com/microsoft/vscode/issues/46585 and https://github.com/microsoft/vscode/issues/1833.

I assume this limitation exists for a reason. If not, let me know if there is any way I can contribute to creating a more dynamic Side Bar.

/duplicate of #46585


Elasticsearch 2 - ExtendedBounds now takes date which errors on month.

Nest version 2.1.1, Elasticsearch.Net version 2.1.1
Elasticsearch version 2.3.0
When I used Elastic search 1.3.4 I could  pass strings to my DateHistogram's ExtendedBounds method, since upgrading to 2.3.0 though I only have the option to pass dates in.  Fair enough I thought but at runtime I get this error: 'Time expression 'month' string is invalid.
My simplified query being this:
        DateTime startDate = new DateTime(2015, 4, 1);                 //31/04/2015 00:00:00
        DateTime endDate = new DateTime(2015 + 1, 4, 1).AddDays(-1);   // 31/03/2015 00:00:00

        Query(Query => q..
                 ..
                 .DateHistogram("my_group", h => h.Field("my_fieldName")
                     .Interval("month")
                     .MinimumDocumentCount(0)
                     .ExtendedBounds(startDate, endDate)

Turns out It wasn't the DateTime variable causing the issue, it was due to how I called the Interval method, it should've been called like this:
 .Interval(DateInterval.Month)


Merge master into feature/stable-cadence

Codecov Report
Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 41.23%. Comparing base (8b6842e) to head (0ed961c).

Files
Patch %
Lines

internal/command/result.go
0.00%
3 Missing :warning:

internal/command/command.go
0.00%
1 Missing :warning:

Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #1475      +/-   ##
==========================================================
- Coverage                   42.15%   41.23%   -0.93%
==========================================================
  Files                          58       58
  Lines                        3188     3138      -50
==========================================================
- Hits                         1344     1294      -50
  Misses                       1661     1661
  Partials                      183      183

Flag
Coverage Δ

unittests
41.23% <60.00%> (-0.93%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


UI Elements

When trying to run storybook I'm getting the error: Module not found: Error: Can't resolve '../app/components/Wallet/Transactions/index' in '/Users/dylancompanjen/Apps/lightning-browser-extension/src/stories'

I think we don't need the "Shared" subfolder. App (in master) is now divided into components, router and screens. Screens can then be composed by components (which are always re-usable/shared).

I think we don't need the "Shared" subfolder. App (in master) is now divided into components, router and screens. Screens can then be composed by components (which are always re-usable/shared elements).

I think there were be a lot of shared components. the structure will be be cleaner if developers just navigate through folders

Note: some commits are not responsive yet. I'll be fixing them soon

*** Categories table

I am actually also not very sure about a "shared" folder with the recent changed structure which has introduced also some kind of hierarchy.
typically I am worried with folders like "shared" or "common" or "lib" that those become a "dump" for anything :)
If you think there will be a lot of shared components that are used by other components and that the folders get to bloated we can move it then?

for example the publisherstable I don't see as a shared component. the publishers will be a Screen/ a full page.

Could you update your branch with the latest master? It seems there will be now some duplicate components. For NavBar there already is AppBar for e.g. that could be extended with functionality.

The classNames function can be util function, so it doesn't have to be recreated for every component.

@bumi I thought we may use the publishers table in an extension screen so I though it's better to be in a shared folder

there seems to be a syntax error?
8:48:52 PM: ERR! => Failed to build the preview
8:48:56 PM: ERR! Module build failed (from ./node_modules/babel-loader/lib/index.js):
8:48:56 PM: ERR! SyntaxError: /opt/build/repo/src/app/components/Wallet/Transactions/index.jsx: Unexpected token (8:2)
8:48:56 PM: ERR!
8:48:56 PM: ERR!    6 |
8:48:56 PM: ERR!    7 |   return (
8:48:56 PM: ERR! >  8 |   );
8:48:56 PM: ERR!      |   ^
8:48:56 PM: ERR!    9 | }
8:48:56 PM: ERR!   10 |
8:48:56 PM: ERR!     at

(from netlify)

merging this PR, then the code can be used and integrated
Thanks a lot!! 🚀


#117 (Issue closed but not fixed yet) .mention-bot should recognize several PR actions

This patch is the solution for issue #117.
server.js had been fixed once to solve the issue, but mention-bot still does not understand PR actions except "opened" and logs on heroku would be like below;
2016-07-22T05:06:15.091259+00:00 app[web.1]: Skipping because action is synchronize. We only care about: "opened"

I have suffered same issues like #117, and I have found simple solutions to this.
With this patch, mention-bot will recognized all user-defined PR actions in .mention-bot file.
Would you please check and accept this PR if this is OK.
Many thanks and best regards.
Moses.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

@MosesKim the issues identified on #117 seem to be related with #138 namely what I identified here which in turn lead to its revert.
On #83 when I added support for mention-bot to listen on multiple actions, it was intended to keep the original behaviour, meaning only listening on opened as it was doing before, and if users wanted to listen on other actions they would have to explicitly declare those there - so it would behave pretty much like an opt-in feature.
Imho, listening to different actions really depends on the workflow your company has in place - for example in mine we listen to both opened and synchronize 'cause after a PR gets reviewed the scope of the changes might change thus affecting different files which impact different teams - so what I'm trying to say is that if we move forward with the current PR and start listening to all actions OOTB, this will be a behavioural change and users might start feeling a little spammed, plus if we really wanna do it, it should probably be highlighted somewhere in the documentation too.

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@jcsmorais Thank you for your comment and letting me know the history behind :)
I think I would apply this workflow only in my company as you commented.
Thank you again and I will close this PR & have nice weekend!


Very meaningful code cleanup

Fixes a bug where the status code somehow gets returned as -1 if it doesn't fail 🤣
also just general improvements
and I pushed to master without meaning to so I guess it is time for enforced branch rules so I don't forget :(

You can put set -e in the beginning of the file so it will fail on the first failed command.

Also please change PR title to something more meaningful 😅

You can put set -e in the beginning of the file so it will fail on the first failed command.

done


Fix Cell::getNeighbors

Now return real neighbors cells and not a list of this x times the number of neighbors

Awesome! thanks!

Thanks for fixing this!


Fix for installation of exported targets

cc @houseroad @pietern

@Yangqing Nice. The only difference is that for BUILD_SHARED=OFF you now don't declare the generate CMake files right? The CAFFE2_INTERFACE_LIBS stuff is sugar?

@pietern Yep. Basically for OSS I think we should use shared library as the standard deployment path, as static library + imported dependency is literally something unmanageable :)
For Android use cases, this means that users have to hand pick what static libs they want to link against, but that is probably the best because it consciously makes users aware of binary size.

Yep, the policy is there so we don't accidentally mix old style and new style target_link_libraries.


Simulating stoichiometry with unknown coefficients

In current version of tellerium, we can do,
model = """
        x = 1;
        y = 10;
        k = .1;
        x_y = 0;
        x + 10  y -> x_y; k*x*y^10
    end
"""

what i want to do is to define 10 as a parameter (because it can be unknown) as,
model = """
        x = 1;
        y = 10;
        k = .1;
        x_y = 0;
        n=10;
        x + n  y -> x_y; k*x*y^n
    end
"""

This gives an error. I tried using n*y, but same. Is there a way to implement this?
thanks

The limitation here is Antimony:  antimony's syntax doesn't allow named stoichiometries.  However, roadrunner itself will still simulate variable stoichiometries if you give it an SBML file with them, so if you want this, you'll need to create your SBML model with it, then load that in directly.  (Support for this is limited, but should work in most situations.)
One option if you don't want to use a different model editor is to create the model in Antimony with a normal '10' as the stoichiometry, and then go into the SBML by hand and give that speciesReference an ID, i.e. change:
          <speciesReference species="S2" stoichiometry="10" constant="true"/>

to;
          <speciesReference id="n" species="S2" stoichiometry="10" constant="true"/>

Then you should be able to set the value of n inside tellurium with commands like 'r.n = 3' or what have you.
If you want 'n' to change over the course of the simulation itself, I would do essentially the same thing, but put in 'n' as a separate parameter.  Then when you edit the SBML, change the ID of the speciesReference to 'n', and just delete the 'n' parameter.
If you would like this feature in Antimony directly (i.e. if you feel you're going to be doing this sort of thing more than once), please file an issue with that request at https://github.com/sys-bio/antimony/issues and I'll see what I can do!

@matthiaskoenig thanks for the suggestions. they might be practical for smaller n, but would be cumbersome if the n varies in a larger range

@luciansmith the proposed approach works but since i am in the development phase, where i would need to repeat this process over an over, editing the xml file each time would be difficult. i will create the issue and would be great if that gets integrated into the antimony directly

This is now implemented in Antimony, so we can close this.  Do let me know if there are any other issues with this that need fixing.