U - Define P1 WebAPI docs

We want to lint the WebAPI docs, but at this point we are only concerned with the most important WebAPI docs, which we call "P1 docs". We expect this to consist of about 1100 pages (out of ~5000 pages total under https://developer.mozilla.org/en-US/docs/Web/API.
In this story we will define precisely what is in P1, and thus what's in scope for the current round of linting.
Acceptance criteria

[ ] We have a clearly defined set of P1 WebAPI docs.

This issue might be useful to decide what you want to call a p1 API page: https://github.com/mdn/browser-compat-data/issues/5674

We also have the scoping exercise in https://docs.google.com/document/d/1rHSMMyM4RSFjttXvWLwaqWDQiVzPlAQRqnchhLfp0tg/edit#heading=h.kq7cdsyjkr1c - this is a bit old but still probably mostly relevant.

Principles
I'd like to frame this work with the following principles:

choosing the set of P1 docs should be governed by two main factors:

how much traffic the pages get
our subjective view of how important a particular doc set is

we should prioritize coherent sets of pages. So rather than pick individual pages, we should pick complete WebAPI interfaces, even if that's not optimal from a traffic perspective.

we should aim to pick not much more than 1000 pages.

What we have in Web/API
There are 5596 pages under Web/API (https://wiki.developer.mozilla.org/en-US/docs/User:wbamberg/all-api-pages?raw&macros).
There are 1095 pages at the top level.
Fundamentally this documentation consists of two interleaved but semantically quite distinct documentation hierarchies.

some top-level pages are "API overview pages", that give an overview of what Web/API calls an "API": this is an abstract collection of objects, methods, events that maps roughly to a specification. For example, the Fetch API or the Geolocation API. Under these pages, there are guide pages for that API.

some top-level pages are "Interface" or "Dictionary" pages, that provide reference documentation for concrete Web programming objects, like Request and Response. Under these pages are reference pages for the members that these objects contain, like Response.status.

API overview pages
We have 98 API overview pages (defined as top-level pages with a space in their name). Under these are (supposed to be) guide pages. In total we have 171 of these guide pages.
We also have the GroupData.json KumaScript macro, which is supposed to be a list of all the APIs we document. This includes the URL for the overview page and the list of interfaces and dictionaries that the API contains.
Ideally, there would be one entry in GroupData of these for every API overview page in Web/API. Actually there are only 87 objects in GroupData, and only 68 of these appear in the set of actual API overview pages.
It's tempting to use the higher-level concept of APIs as a way to get a handle on the scale of the Web APIs - we could for example say "Fetch is a P1 API". But the data here contains enough errors and omissions that this is hard to do.
Interface and Dictionary pages
This leaves us trying to define priorities at the level of interfaces (and sometimes dictionaries). There are about 997 such pages directly under Web/API.
Analysing the interfaces
I've taken the hierarchy of pages under Web/API and added traffic data to it, to make this spreadsheet: https://docs.google.com/spreadsheets/d/1UTAQG3pSrdBD2tIXMWRSATkOSSj-dcuXnG7ux5pFtDk/edit#gid=538131955.
This has a row for every top-level page that's not an API overview page. In each row, it lists:

interface traffic: how much traffic all the pages in this interface get
interface page count: the number of pages in this interface (the top level page plus its children)
traffic-per-page: calculated as interface traffic/interface page count)
traffic percentage: calculated as (interface traffic / total traffic) * 100. Note that total traffic here is exclusive of traffic to "API overview" pages and their children.

With this sheet we can list the top 10 interfaces by size:
Window                   181
Document                 161
Element                  134
WebGLRenderingContext    116
GlobalEventHandlers       76
CanvasRenderingContext2D  68
WebGL2RenderingContext    68
RTCPeerConnection         67
HTMLMediaElement          66

We can also sort by traffic percentage, and select all interfaces which contribute more than 1% of the total traffic:
Name                      Traffic   # pages   Traffic/page     Traffic%
------------------------------------------------------------------------
Element                   408554       134        3026          10.38
Window                    396925       181        2180          10.08
Document                  351514       161        2169           8.93
XMLHttpRequest            165726        42        3854           4.21
HTMLElement               108694        42        2527           2.76
EventTarget               103279         5       17213           2.62
Event                      98807        23        4116           2.51
FormData                   88740        11        7395           2.25
Node                       84980        39        2124           2.16
CanvasRenderingContext2D   81728        68        1184           2.08
FileReader                 60700        18        3194           1.54
File                       58500        14        3900           1.49
WindowOrWorkerGlobalScope  57799        14        3853           1.47
console                    53261        22        2315           1.35
URL                        52140        17        2896           1.32
URLSearchParams            49761        13        3554           1.26
KeyboardEvent              47709        17        2650           1.21
GlobalEventHandlers        46651        76         605           1.18
HTMLMediaElement           43722        66         652           1.11
Navigator                  43404        41        1033           1.1
Location                   42449        16        2497           1.08
WebSocket                  41971        17        2331           1.07
Blob                       41979         7        5247           1.07
RTCPeerConnection          40392        67         594           1.03
MediaDevices               39981         6        5711           1.02

Cumulatively, this comprises 1117 pages and captures 66.28% of our total (interface-page) traffic.
This seems like a good initial proposal for P1 Web/API docs. It is entirely based on traffic though, so it would be worth scanning the other interfaces to see if we are missing any that we would like to include. Note though that we are already at 1100 pages, so any proposals to add new interfaces should be accompanied by a proposal to remove one :).

Alternatively, if you sort by Traffic/page, you can capture 77.52 % of traffic by including the following interfaces, which contain 1113 pages:
EventTarget
FormData
FileList
MediaDevices
ElementCSSInlineStyle
Blob
MutationObserver
HTMLOrForeignElement
DOMString
Event
EventListener
DOMParser
File
XMLHttpRequest
WindowOrWorkerGlobalScope
History
URLSearchParams
Geolocation
USVString
Storage
FileReader
ChildNode
Body
CustomEvent
Element
Response
URL
KeyboardEvent
ParentNode
HTMLElement
Location
HTMLCanvasElement
WebSocket
console
NodeList
Crypto
Window
Document
NavigatorOnLine
WindowEventHandlers
HTMLAudioElement
Node
HTMLCollection
Request
HTMLTextAreaElement
ResizeObserver
Cache
HTMLDivElement
Clipboard
HTMLInputElement
DOMHighResTimeStamp
HTMLOptionElement
NavigatorLanguage
Headers
HTMLFormElement
AbortController
SubtleCrypto
HTMLTableCellElement
StorageEvent
ClipboardEvent
ScrollToOptions
CanvasRenderingContext2D
CanvasGradient
CryptoKey
MediaStreamConstraints
ImageData
MutationRecord
XMLSerializer
Navigator

Thanks Will! This is amazing research and very data-driven. Love it! I agree to the principles you've chosen.
After choosing p1 pages by traffic, the second principle "we should prioritize coherent sets of pages" resonates a lot with me and I think this is a point where the final list of pages might change a bit as we go. I agree that if we do that, we should think about what to remove from the list, too.
An attempt to cluster your list:
// Networking
AbortController
Body
Cache
Headers
Request
Response
WebSocket
XMLHttpRequest
XMLSerializer

// Canvas
CanvasGradient
CanvasRenderingContext2D
ImageData

// DOM
ChildNode
Blob
DOMParser
DOMHighResTimeStamp
DOMString
Element
ElementCSSInlineStyle
Node
NodeList
ParentNode
USVString

// Clipboard
Clipboard
ClipboardEvent

// Crypto
Crypto
CryptoKey
SubtleCrypto

// Events
CustomEvent
Event
EventListener
EventTarget
KeyboardEvent

// Files
File
FileList
FileReader

// HTML
FormData
HTMLAudioElement
HTMLCanvasElement
HTMLCollection
HTMLDivElement
HTMLElement
HTMLFormElement
HTMLInputElement
HTMLOptionElement
HTMLOrForeignElement
HTMLTableCellElement
HTMLTextAreaElement

// URLs
History
Location
URL
URLSearchParams

// Media
MediaDevices
MediaStreamConstraints

// Observers
MutationObserver
MutationRecord
ResizeObserver

// Fundamentals
Document
Navigator
NavigatorLanguage
NavigatorOnLine
Window
WindowEventHandlers
WindowOrWorkerGlobalScope

// Misc
Geolocation
ScrollToOptions
Storage
StorageEvent
console

Now, I guess you can imagine that each of these clusters are a work package, but they are incomplete, because, for example,  when you work on Canvas, you probably want to fix all of the Canvas API page structures instead of just the most trafficked. Maybe there are even dependencies with the non high traffic pages, because it turns out that some canvas (mixin, dictionary) pages need splitting or merging. So, my feeling is that in that case, it makes sense to look at all interfaces of a cluster (see here for canvas) and make them all fit the correct recipes. Does that make sense? I guess I'm coming from a more holistic approach, thinking that no one wants to dig into the other half of an API cluster again after we fixed the first p1 part. That way we would also have good examples of whole API clusters that follow the newly defined and correct doc structures that shape our way forward into more API clusters we want to fix or document.

Well... re clusters. We already have "clusters", of a sort, they are what's defined in GroupData.json. But as said above, the data in GroupData is incomplete and inconsistent. We could fix all that before starting the WebAPI linting. Why though? It would take a bunch of time and it's not clear how it really supports the work of linting our docs. By just looking at the interfaces level, we can start fixing up individual pages without looking at fixing the higher-level organization. If fixing the higher-level organization of Web/API is a goal of this project, then fine, but that's definitely a change in scope.
Of course we can also say "the clusters in GroupData are no good, we should invent new ones". But I'd be very careful here. Grouping things into categories is always really tricky: there are like 30% of obvious cases, another 50% of cases where categorization is very subjective, and 20% that you just have to lump into "Miscellaneous", which is terrible because then people have to look in two places to find something. In your example you've taken Canvas, but then actually pointed to GroupData (essentially) for the definition. But what about, say "Fundamentals"? what are all the things we should add to that, to have a "complete" cluster? Are, say, Service Workers fundamentals? And looked at from the point of view of a developer, what sorts of things are considered fundamental? I expect you'll get different answers from different people.
At least GroupData categories are backed by a real thing - the spec that defines the interfaces - rather than just the intuitions of a particular tech writer on a particular day.

no one wants to dig into the other half of an API cluster again after we fixed the first p1 part

Well...maybe. The thing about doing complete interfaces is that at least each subtree of the hierarchy is done at a time, and that seems like the most important thing.
But. I do think that higher-level abstractions are helpful here. So for example the "Fetch API" abstraction that unites Request, Response, Body, Headers. I think users probably think in terms of "Fetch" not in terms of the individual interfaces. So we could say: from the 70 interfaces in my list, look at the groups they belong to and list any interfaces that are omitted from the 70, and work out how many extra pages that would amount to. Another, related, thing is that in https://docs.google.com/document/d/1rHSMMyM4RSFjttXvWLwaqWDQiVzPlAQRqnchhLfp0tg/edit# we made a list of "P1 APIs": it would be good to get a sense of:

which of these APIs are omitted completely from my 70 interfaces. Do we want to add them, or has the P1 definition changed since we wrote this?

which of these APIs are only partially covered by my 70 interfaces, and do we want to add the remaining interfaces, so as to have complete APIs?

I've added a new field to the spreadsheet, which represents the group that the interface belongs to, as defined in GroupData.
Note that 252 top-level pages - a quarter of the total - are not assigned to a group at all.
We can easily use this to see how much extra work it would be to lint complete groups. I've added another sheet, "groups". This contains a row for every group that's represented in our 57 interfaces.
Each row contains:

name of the group
number of interfaces belonging to that group that are in our 57 interfaces
number of pages represented by that collection of interfaces
how many more pages we would have to lint, to complete that group

For example, four of our interfaces, Request, Response, Body, Headers, belong to the "Fetch API" group and comprise 47 pages. And this is the totality of the Fetch API. But we'd need to add another 18 pages to complete the Geolocation API.
In total we can see that to complete all API groups included here would mean linting 1051 more pages, or almost double the total. An especially problematic group is "HTML DOM", which would commit us to 402 more pages[1]. And then there are groups like "Service Workers API", where we're proposing to lint just 8 pages but would need to add another 101 to complete the group.
On the other hand, we're at 55/61 pages in the "XMLHttpRequest" group, so it seems very worthwhile to finish this one...
[1] I'm confused about what's in "DOM" and what's in "HTML DOM". In GroupData, Window is in "HTML DOM", not in "DOM". But in the DOM overview page, Window is listed as a "DOM interface". Sigh. Is this kind of categorization really useful to people?

Thanks for your detailed comments!

Well... re clusters. We already have "clusters", of a sort, they are what's defined in GroupData.json. But as said above, the data in GroupData is incomplete and inconsistent. We could fix all that before starting the WebAPI linting. Why though?

Right, groups exist already. I was thinking more about how to proceed practically workload-wise. I mean, we could just pick random interfaces and lint them, or could we cluster things we identified as p1 and work on cluster after cluster. Maybe just linting whatever we come across in the p1 list is fine, though, as you say. And if that's the most practical way forward, lets do that.

I'm not exactly against defining new groups, especially higher-level ones than those in GroupData. But it's hard, and it takes time, and needs to be done as a complete project IMO.

Yeah. I thought of the clusters as practical slices to work from, not exactly aiming to re-invent groupdata. I'm not sure how useful the current groups are to our readers and as you say that is a higher level problem. I think the other areas (JS, for example) didn't suffer from these higher level issues, so maybe my (naive) hope was that we can tackle it somehow, but you are right in identifying this as its own project / user story. It is quite complex.

I've added a new field to the spreadsheet, which represents the group that the interface belongs to, as defined in GroupData.

Thanks, this is useful!

In total we can see that to complete all API groups included here would mean linting 977 more pages, or almost double the total.

Wow, this is too much indeed

And this is the totality of the Fetch API
But we'd need to add another 18 pages to complete the Geolocation API.
problematic group is "HTML DOM", which would commit us to 395 more pages
"Service Workers API", where we're proposing to lint just 8 pages but would need to add another 97 to complete the group.
we're at 55/61 pages in the "XMLHttpRequest" group, so it seems very worthwhile to finish this one.

This is amazingly useful to know per each API group! Thanks for making this analysis, Will!
I agree that XHR for example is something I would finish in totality given this data. Can we make the call for each current API group based on these numbers? For me, XHR would be in in totality, HTML DOM wouldn't be.
ServiceWorkers is really surprising here. I wonder why things are like that. Is the rest very poor/useless pages? Are we creating many pages (say for dictionaries, enums, mixins, etc.) for an API, but most people just read the main interface and/or method pages? So, here I struggle to make a clear call if we should say lets do ServiceWorkers in totality given my lacking sense of the docs.

So although I was reluctant to define new groups across the board, it might be worth thinking about reworking this area.

I agree this needs work. It is worth splitting this out into an own "re-grouping" user story. I don't know how much it rabbit-holes into defining P1 API docs, but it seems that your list above is still useful and our current best bet on what we think the P1s are.  There are two options, I guess:

We could enhance the list by deciding per each API group if we do things in totality or not. We decide also with the total number pages in mind (doubling to linting 2000 pages as P1 isn't practical)
We could work through the list as is and bother about groups another day.

I wanted to briefly chime in here: I think the analysis is really good. I like the principles you've selected to selection. I itch a bit a wholly traffic-driven approaches and I like the way you've handled that.
I'm also pleased to see that these principles satisfied another interest I had, that the pages we selected represented a good range of page types, to ensure we get a mostly complete set of recipes. Based on the selection, this seems likely (even if we lost some pages on the margins—more on that in a second).
I also favor completing groups, since I suspect this will improve the completeness of our recipes by drawing in more long-tail pages. But I'm also reluctant to balloon the number of P1 pages. Maybe we could complete the groups which are already very-well covered (e.g., XMLHttpRequest, which is already at 90%), but not ones that aren't close (e.g., HTML DOM, at 47%).
Or if you really want completeness in one area (say the HTML DOM group) then you might let completeness cut both ways: Media Capture and Streams and Service Workers API's selected pages are less than 10% of their respective groups. If you dropped the entirety of those groups, you'd shed over 200 pages for reallocation elsewhere. Or you could do some combination: shedding groups that are poorly covered (say <10% coverage), completing groups that are well-covered (say >90% coverage), and letting the groups in between be incomplete.

Thanks for the comments! Then here's my suggestion. We lint complete groups, with three exceptions, "DOM", "DOM Events", and "HTML DOM". Reasons for excepting these are:

taken together these three groups contain 1428 pages.  But, these groups include some basic interfaces that we must consider P1s. So we can't exclude them.

the definition of these groups is weird, possibly unhelpful, certainly inaccurate, and contains many obsolete interfaces. So we should fix them up before leaning too heavily on them.

So for these three groups only, we define a subset of the interfaces as P1s, based on traffic. For the other groups, we only lint complete groups. That means we either expand the set of interfaces in a group, so as to complete the group, or we remove the set, so as to omit the group completely.
Also, we will throw in the 5 interfaces (56 pages) that are not currently assigned to any group.
Given those principles I've added yet another sheet "P1 docs" that lists my concrete proposal, and that I'll copy here:
   Group         | High-traffic interfaces | High-traffic pages | Low-traffic pages | Total pages |
---------------------------------------------------------------------------------------------------
(unassigned)     |        5                |         56         |       n/a         |      56     |
Canvas API       |        1                |         69         |        42         |     111     | complete
Clipboard API    |        1                |          5         |         7         |      12     | complete
DOM              |       14                |        400         |       179         |     400     | partial
DOM Events       |        2                |         20         |        71         |      20     | partial
Fetch API        |        4                |         47         |         0         |      47     | complete
File API         |        4                |         43         |         5         |      48     | complete
HTML DOM         |       13                |        363         |       395         |     363     | partial
URL API          |        2                |         32         |        24         |      56     | complete
Web Storage API  |        1                |          7         |         1         |       8     | complete
Websockets API   |        1                |         18         |        10         |      28     | complete
XMLHttpRequest   |        3                |         55         |         6         |      61     | complete
---------------------------------------------------------------------------------------------------
                 |                         |       1115         |                   |    1210     |

This lists P1 docs by group:

"High-traffic interfaces" - the number of interfaces in that group that we identified as high-traffic
"High-traffic pages" - the number of pages in those high-traffic interfaces
"Low-traffic pages" - the number of extra pages we'd have to add to complete the group
"complete/partial" - whether we are actually going to add those low-traffic pages for this group.

As you can see from a comparison with the "groups" sheet, I've removed several groups for which many pages were missing, or that just didn't seem that important.
This gives us 1210 pages as P1.
I'm really happy with this proposal. I think all the groups listed here are important Web APIs, and deserve to be considered P1.

Other things to come out of this work:

file an issue to update GroupData so all interfaces belong to a group
file an issue to update GroupData so no interfaces belong to more than one group
file issues to remove some obsolete interfaces
think about improving the DOM/HTML group
think about defining higher-level categorizations for the Web API docs as a whole (imagine having a https://developer.mozilla.org/en-US/docs/Web/API top-level page split up by: "Graphics", "Media" "Debugging", "Network" or something like that...)


Feature request: wrap panda dataframe methods

Working with PyRanges, I very often have to transform back and forth to pandas DataFrame.
It's always because I need the same methods: DataFrame.groupby and DataFrame.apply.
Could you make these methods available directly in pyranges.PyRanges? I guess they could be easily implemented, with the only minor inconsistency that groups must be within each chromosome group.

I have considered this. I’ll look into it.
Endre
On Tue, 7 Feb 2023 at 14:52, Marco Mariotti @.***>
wrote:

Working with PyRanges, I very often have to transform back and forth to
pandas DataFrame.
It's always because I need the same methods: DataFrame.groupby and
DataFrame.apply.
Could you make these methods available directly in pyranges.PyRanges? I
guess they could be easily implemented, with the only minor inconsistency
that groups must be within each chromosome group.
—
Reply to this email directly, view it on GitHub
https://github.com/biocore-ntnu/pyranges/issues/286, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEHURUSQYCYM7INHWRR3COTWWJHQNANCNFSM6AAAAAAUT7X2ZY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

You could do
gr.apply(lambda df: df.groupby(args))

gr.apply(groupby_function)

Is this good enough?
I think adding groupby might lead to many weird corner cases where there is a mismatch between pandas and pyranges. Furthermore, we'd might get lots more support questions since then it would be our function.
Perhaps it is best to add examples to the book?

OK, let's turn this into a enhancement request for the book: a chapter on Pyranges / Pandas interaction.
There's a minimal example in the tutorial now


add labels option to helm template

What does this PR do?
Add option to include custom labels for the deployment.

+1

+1


Error Message Below - Trying to Add Locked Out Team Member

Keybase GUI Version: 2.7.3-20181005191950+83f5d808a7
Error message:
Error: ERROR CODE 2511 - failed to identify "dwilkerson": 1 followed proof failed in method keybase.1.teams.teamEditMember at new s (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/index.bundle.js:1:472890) at file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/index.bundle.js:1:473419 at d (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/index.bundle.js:1:473458) at _rpcClient.invoke.t (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/index.bundle.js:1:415513) at file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/index.bundle.js:1:2813367 at e.t.Deferrals.e._call (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/index.bundle.js:1:2382350) at file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/index.bundle.js:1:2382501 at s (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/index.bundle.js:1:2382130) at e.t.Deferrals.e._fulfill (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/index.bundle.js:1:2382460) at s (file:///Applications/Keybase.app/Contents/Resources/app/desktop/dist/index.bundle.js:1:2381664)

Thank you!!
--

On Friday, Oct 12, 2018 at 3:24 PM, Maxwell Krohn<EMAIL_ADDRESS>(mailto:notifications@github.com)> wrote:
Yeah, I just reset him. We have a know bug here. You can workaround the issue by "refollowing him". Visit his profile, and if you're happy with it, "accept changes".
Then it should work to let him back in
cc @keybase/react-hackers (https://github.com/orgs/keybase/teams/react-hackers)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (https://github.com/keybase/client/issues/14229#issuecomment-429434932), or mute the thread (https://github.com/notifications/unsubscribe-auth/AkjzETjbKFTDc4cbBTGYwBzZ3CNCW8UJks5ukOxPgaJpZM4XaDaA).

Bah. It says I’m already following.
--

On Friday, Oct 12, 2018 at 3:38 PM, Megan Mattimoe<EMAIL_ADDRESS>(mailto:megan.mattimoe@gmail.com)> wrote:
Thank you!!
--

On Friday, Oct 12, 2018 at 3:24 PM, Maxwell Krohn<EMAIL_ADDRESS>(mailto:notifications@github.com)> wrote:
Yeah, I just reset him. We have a know bug here. You can workaround the issue by "refollowing him". Visit his profile, and if you're happy with it, "accept changes".
Then it should work to let him back in
cc @keybase/react-hackers (https://github.com/orgs/keybase/teams/react-hackers)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (https://github.com/keybase/client/issues/14229#issuecomment-429434932), or mute the thread (https://github.com/notifications/unsubscribe-auth/AkjzETjbKFTDc4cbBTGYwBzZ3CNCW8UJks5ukOxPgaJpZM4XaDaA).

Fixed it!!
--

On Friday, Oct 12, 2018 at 3:49 PM, Megan Mattimoe<EMAIL_ADDRESS>(mailto:megan.mattimoe@gmail.com)> wrote:
Bah. It says I’m already following.
--

On Friday, Oct 12, 2018 at 3:38 PM, Megan Mattimoe<EMAIL_ADDRESS>(mailto:megan.mattimoe@gmail.com)> wrote:
Thank you!!
--

On Friday, Oct 12, 2018 at 3:24 PM, Maxwell Krohn<EMAIL_ADDRESS>(mailto:notifications@github.com)> wrote:
Yeah, I just reset him. We have a know bug here. You can workaround the issue by "refollowing him". Visit his profile, and if you're happy with it, "accept changes".
Then it should work to let him back in
cc @keybase/react-hackers (https://github.com/orgs/keybase/teams/react-hackers)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (https://github.com/keybase/client/issues/14229#issuecomment-429434932), or mute the thread (https://github.com/notifications/unsubscribe-auth/AkjzETjbKFTDc4cbBTGYwBzZ3CNCW8UJks5ukOxPgaJpZM4XaDaA).

I'm seeing a similar issue when trying to add a user to a team I own. Was the known bug ever resolved?

Yes I think it was, but I don’t remember how.
On Thu, Jan 6, 2022 at 4:26 PM Bryce Fisher-Fleig @.***>
wrote:

I'm seeing a similar issue when trying to add a user to a team I own. Was
the known bug ever resolved?
—
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/14229#issuecomment-1006946494,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJEPGEKHTT53GUC6K52QQDLUUYCIXANCNFSM4F3IG2AA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Sincerely,
Megan K. Mattimoe, J.D.
Executive Director
Advocating Opportunity
1119 Adams Street, Second Floor
Toledo, Ohio 43604
Pronouns:  She/Her/Hers
Phone<PHONE_NUMBER>, ext. 700
Fax<PHONE_NUMBER>
Mobile<PHONE_NUMBER>
Email        @.***
Website     www.advocatingopportunity.com
Facebook  www.facebook.com/advocatingopportunity
Twitter       https://twitter.com/AOAdvocate
The information contained in this communication may be confidential, is
intended only for the use of the recipient named above, and may be legally
privileged.  If the reader of this message is not the intended recipient,
you are hereby notified that any dissemination, distribution, or copying of
this communication, or any of its contents, is strictly prohibited.  If you
have received this communication in error, please resend this communication
to the sender and delete the original message and any copy of it from your
computer system.


Support for JavaScript execution within element.

I was working on creating reusable helper utility which will add _sp, class and id to any element when passing a common data model. After alot of try and error with variables, functions and ${} and without ${} I finally concluded that it may not be supported.
Support for calling a Helper Utility to render anything within the HTML element is desired.
Currently Marko supports calling JavaScript expression on right hand side after = sign (as below)
However following is not supported. hello
I have created a sample to explain the same.
https://github.corp.ebay.com/sugurnani/marko-dynamic-attributes/tree/master

For the benefit of those outside eBay, here's the template that you shared:

    Please inspect my container element and you will find dynamic content is not evaluated

The above is not valid HTML and will not be parseable. However, the equivalent alternative is to take advantage of the custom attrs attribute as shown below:

...

Where the helper.getTrackingAttributes is implemented as shown below:
function getTrackingAttributes() {
    return {
        "attr1": "attr1Value",
        "attr2": "attr2Value"
    }
}

Alternatively, you could use a custom compile-time transform to add the attributes to allow for something similar to the following:

Let me know if this answers your question or if you would like more help with a custom compile-time transform.

Thank you @patrick-steele-idem
I was saw the documentation for defining custom tags but was unable to find info about creating custom attributes. Can you please point me to that doc?

Hi @SunnyGurnani, I was hoping to put together a sample app to demonstrate custom compile-time transforms to process custom attributes, but I have been pretty swamped. In the meantime, it might be helpful to understand how marko-widgets utilizes compile-time transforms.
Here is the implementation for the marko-widgets compile-time transform:
https://github.com/raptorjs/marko-widgets/blob/master/taglib/widgets-transformer.js#L21
Here is the taglib that registers the transform:
https://github.com/raptorjs/marko-widgets/blob/master/marko-taglib.json#L70
I still hope to improve the docs for this advanced feature, but hopefully this helps in the meantime. Thanks for your patience.

Closing this issue. I have opened another issue to improve the docs for compile-time transforms to better explain how custom tags and custom attributes can be processed at compile-time: https://github.com/raptorjs/marko/issues/100


Update domains.js

Hi, I want to update my custom domain for PanCakeFi

[x] Add a custom domain for your space

Closing this PR for now, feel free to open it again once you've done the changes.


GCC - Mingw C/Lua build workflow

Right now I have to have 3 cmd-line windows to debug the C/Lua project. One MSYS window to build the (Makefile) C source (if needed), another to launch the server and another to launch the client (SDL game).
I want to set up a better workflow with atom, a few build/run/debug profiles, a build and run server+client(optionally in gdb, even better if you could integrate gdb into atom), another to just run server+client(by server+client I mean, run the server, wait for it to initialize, run the client). It would even better if you could redirect the server terminal output to atom.
Is there any package that can help me do that? I tried all the build packages they don't do what I need.
I can use the terminal package, but that's just what I was using before with fancy shortcuts :unamused:
At least I can ditch Notepad ++
Sorry if this issue is worded badly, I asked in #atom and they told me to write it this way.

There's a linter package and two lua linting scripts. Maybe that's what you want?

Please read my post, your suggestion is ridiculous of course I already have the linters. Also your avatar is astonishingly bad.
I assigned F12 to "compile" in atom-terminal-panel so I'm somewhat happy for now. It has no autocomplete but I can live with custom commands. It's also not a versatile solution. And also I hate atom with passion now.

Workflow and general package questions should go to Discuss and not here.

As a side note, adopting a slightly less hostile attitude against people trying to help you, is highly advisable. And if you hate Atom, maybe you should check out CLion which is a C/C++ IDE.


enable/disable profiles

enable and disable profiles in ratbagd, ratbagctl and ratbag-command.
The hidpp10 implementation was not done with that in mind, which explains the large commits for them.
The result is now less communications with the HID++ 1.0 devices as we are caching the data inside libratbag.

The changes made to ratbagd and the DBus interface look good to me, just have some questions regarding the intended use and some documentation fixes.

Just a quick FYI, @whot is currently looking at the dbus API and ideally we would suppress methods and only have properties. I did not think much about the API right now, I was just trying to have something that just works :)
I'll amend the changes, but beware that the dbus API will likely change in the (near) future.

I'm aware of this and am looking forward to it :)

that first commit (add missing Commit()) shows a slight problem we have with ratbagd. ratbagd returns the state of the device before the commit, so in the extreme case we can have a client change that state but never commits it to the device. The next client will then get a state that does not reflect the device. I wonder if we can do client tracking in ratbagd to reset the device on client disconnect.

that first commit (add missing Commit()) shows a slight problem we have with ratbagd. ratbagd returns the state of the device before the commit, so in the extreme case we can have a client change that state but never commits it to the device. The next client will then get a state that does not reflect the device. I wonder if we can do client tracking in ratbagd to reset the device on client disconnect.

Nah. I think we should consider the daemon state as being the correct one. If a client forgets to call commit(), we should not have a different state for other clients. This will be race prone and we might end up having too much code for no benefit.
Anyway, if one client forgets to commit, the next one will more likely commit given that we expect clients to actually change the device.

looks good, but i'd like this to be rebased on top of #242 please, sorry.

No worries. When I saw your local brnach, I already made up my mind that I would have to rewrite it.
I could also have dropped the ratbagd part, but that would just differ the commit in a separate PR, so no gain.

looks good, but i'd like this to be rebased on top of #242 please, sorry.

Done. Squashed the 2 comments and also changed the Enabled property to be read-write.


Can't open or perform --reset

Description of your problem
Can't launch spyder (from navigator, command line or .exe)
When attempting to launch message  that spyder crashed during last session and should run spyder --reset and will remove configuration files, however upon trying to run this I get:

spyder --reset
Traceback (most recent call last):
File "C:\Users\Robin\Anaconda3\lib\site-packages\qtpy\QtWebEngineWidgets.py", line 22, in
from PyQt5.QtWebEngineWidgets import QWebEnginePage
ModuleNotFoundError: No module named 'PyQt5.QtWebEngineWidgets'

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\Robin\Anaconda3\Scripts\spyder-script.py", line 10, in
sys.exit(main())
File "C:\Users\Robin\Anaconda3\lib\site-packages\spyder\app\start.py", line 155, in main
from spyder.app import mainwindow
File "C:\Users\Robin\Anaconda3\lib\site-packages\spyder\app\mainwindow.py", line 92, in
from qtpy import QtWebEngineWidgets  # analysis:ignore
File "C:\Users\Robin\Anaconda3\lib\site-packages\qtpy\QtWebEngineWidgets.py", line 26, in
from PyQt5.QtWebKitWidgets import QWebPage as QWebEnginePage
ImportError: DLL load failed: The specified procedure could not be found.
Checked update of conda and anaconda - all packages up-to-date
Tried uninstalling and reinstalling spyder, didn't help.
I have another env for UI development which launches my PyQt5 GUI fine
Really don't want to have to do a full uninstall of anaconda and lose my other environments
What steps will reproduce the problem?

Windows crash while running spyder

What is the expected output? What do you see instead?
Please provide any additional information below
.spyder-py3 and Anaconda3 location C:\Users\Robin
Versions and main components

Spyder Version: 3.2.6
Python Version: 3.6.3
Qt Version: 5.6.2
PyQt Version: 5.6.0
Operating system: Windows 10

Dependencies
Please go to the menu entry Help > Optional Dependencies (or
Help > Dependencies), press the button Copy to clipboard
and paste the contents below:

Thanks for reporting. Unfortunately, it seems very unlikely Spyder has any control over this problem, as it appears to be due to packages external to Spyder, quite possibly user installation issues with the same. You could try uninstalling and reinstalling related packages (pyqt, qtpy, etc). Also, you can try installing Spyder into a fresh environment with just the required dependencies. Issue #5795 seems to be related, so also check there for more help.
Failing that, please try the steps listed in the Spyder Troubleshooting Guide, specifically the Basic First Aid and Emergency CPR sections, which resolve the great majority of Spyder installation issues. This includes uninstalling and reinstalling Anaconda; if all else fails, there isn't much else we can recommend since this appears to be outside of our control. Best of luck!

Did you use pip to install pyqt5 in your other env?

I was successful in opening spyder in a separate env which I had previously installed spyder to work in. In my home env I have pyqt5-tools installed by pip, is that the problem? I was going to uninstall and reinstall pyqt,qtpy etc as suggested above by CAM

I tried uninstalling pyqt5-tools by pip as well as qtpy and pyqt by conda, which uninstalled other packages with these dependencies - and reinstalling them, however I still get the same error with DLL load fail. For now I can use spyder in my other environment

I was successful in opening spyder in a separate env which I had previously installed spyder to work in

This suggests a particular package in the problem environment but not the other one might be to blame...

In my home env I have pyqt5-tools installed by pip, is that the problem?

Could very well be...can you try it?

I tried uninstalling pyqt5-tools by pip as well as qtpy and pyqt by conda, which uninstalled other packages with these dependencies - and reinstalling them, however I still get the same error with DLL load fail.

Aside from a persistent configuration issue or something else esoteric, this would support the above hypothesis.

I'm afraid you broke your Anaconda installation by using pip to install pyqt5 and you'll have to reinstall it from scratch.
The problem is pip does not respect the symlinks conda uses in its environments and so it can break all of them at once.
Sorry, even if you manage to avoid a full reinstallation, this is not a Spyder problem, so I'm closing this issue.


HTML Nested Comments

Is there any setting or package out there that can help with nested comments in HTML?

I want to quickly comment out everything, including the existing comments that mark the end of the divs:

I had to create a package for this functionality in Sublime Text. Using the ~~ is not a requirement (I borrowed the idea from BBEdit which supports this natively).
I teach at Drexel University and we try to get our beginners in the habit of using comments frequently in their code, but we definitely don't want to waste time when we need to block comment something that already has comments. Any insight is greatly appreciated.

@philsinatra Yeah, that sounds like something you'd be creating a package for in Atom as well, I don't think I've seen such a package myself. Check out the docs, and if you have any questions -- asking on the forum should get you some answers. The forum is also a good place to ask if some package exists (if you don't find it yourself in the registry).

Done. HTML Nested Comments

Nice work :sparkles: Just gave it a try and seems to work well. :+1: Gonna close this out since we now have a package for this.


Initial guess

Feeding alphafold 2 an initial guess (PDB file of the binder:target complex structure) has been instrumental for protein binder design.
See https://github.com/nrbennet/dl_binder_design for reference.
Is this something that can be incorporated?
Thanks in advance!

Alex is still trying to sail to the right point in high dimensional parameter space. but yes, once that point is captured, can add applications of that sort, binder design or whatever


[iOS] Show What is DroidKaigi banner in About Screen

Kind (Required)

Improvement

Overview (Required)

Please show What is DroidKaigi banner` in About Screen
Customize MessageBar in Component module to make it possible to use View in content.

Links

https://www.figma.com/file/D2VLqh0xOXbH0zB6cTz053/DroidKaigi_2021_official_App-iOS?node-id=140%3A5877

🙋

@daichi77
Thanks! Assigned 👍🏼

@daichi77
How about this? 🙏🏼

@ry-itto I'm sorry, I will make a pull request today. If I can't do it today, I'll give up


It seems like filepath  is not correct when work with cwd option.

The correct value of filepath should be f.cwd + filepath.
var src = banner + f.src.filter(function(filepath) {
// Warn on and remove invalid source files (if nonull was set).
if (!grunt.file.exists(filepath)) {
grunt.log.warn('Source file "' + filepath + '" not found.');
return false;
} else {
return true;
}
})

bilalq's solution worked for me, but I also needed to add flatten: true since my files were in multiple directories.
Let me just add my vote that something is not quite right here and probably should be fixed.

This got me as well.
I agree with the comments above, this doesn't seem to be the most expected behaviour.

how to use

@bilalq so something like this should work:
concat: {
someTarget: {
rename: function(dest) { return dest },
expand: true,
cwd: 'tmp',
src: ['file1','file2'],
dest: 'concat.js'
}
}
leading to the files in ./tmp/file1 and ./tmp/file2 being concatenated and saved ./concat.js ?
Because this config is not giving me any errors/warnings but ./concat.js is not created.


Plugin not showing up in Unreal Engine 5.3 under MacOS 14

Tried integrating the plugin into UE5.3 under MacOS 14, M1 Max. Engine was built from source, fresh C++ project. The solution build is successful and the plugin is recognized by the engine but no button or menu shows up to actually use the plugin to integrate the SDKs into the project. See screenshot attached.

I did some digging on the problem and discovered that the GameLiftPlugin.uplugin file was missing Mac in the PlatformAllowList.
"Modules": [ 		{ 			"Name": "GameLiftClientSDK", 			"Type": "Runtime", 			"LoadingPhase": "Default", 			"PlatformAllowList": [ 				"Win64", 				"Mac" 			] 		}, 		{ 			"Name": "GameLiftCore", 			"Type": "Editor", 			"LoadingPhase": "Default", 			"PlatformAllowList": [ 				"Win64", 				"Mac" 			] 		}, 		{ 			"Name": "GameLiftPlugin", 			"Type": "Editor", 			"LoadingPhase": "Default", 			"PlatformAllowList": [ 				"Win64", 				"Mac" 			] 		},
After editing and saving the file, rebuilding the solution threw some errors with the GameLift plugin.

0>In file included from Users/Project/Plugins/Developer/GameLiftPlugin/Source/GameLiftPlugin/Private/Settings/UGameLiftAnywhereStatus.h:10:
0>GameLiftPluginConstants.h(428,11): Error  : redefinition of 'Style' as different kind of symbol
0>In file included from Users/Project/Plugins/Developer/GameLiftPlugin/Source/GameLiftPlugin/Public/GameLiftPlugin.h:8:
0>FGameLiftTab.h(7,10): Error  : 'Framework\Docking\TabManager.h' file not found
0>In file included from /Users/Project/Plugins/Developer/GameLiftPlugin/Source/AWSSDK/Include/aws/common/math.msvc.inl:19:
0>intrin.h(12,15): Error  : 'intrin.h' file not found

Exactly the same problem using the plugin with Unreal Editor on Linux (UE 5.3.2, UE 5.4.4)


Write red-left

[ ]  (vision and placing the purple pixel on the line when we have that figured out; finish below first)
[ ]  Forward 3 tiles
[ ]  Turn right
[ ]  4 tiles forward to park in backstage


This package is seeking a new owner

I no longer develop with Meteor. This package is looking for a new owner that would like to maintain it going forward.

thanks for your contribution!

thanks for your contribution!

Proposing we move this to Community Maintenance. Meteor-Community-Packages/organization#53


Is it possible to get the metadata with markdown format?

There are useful information when we output to json format, such as: title, author, and date. However, it looks like json only has raw_text as the content format.
The workaround is extracting in both json and txt with include_formatting but I think we can do better

Good point, the code here could definitely be improved to add further metadata:
https://github.com/adbar/trafilatura/blob/123414cae5f927e743f5eced2cd43b81a65fc43c/trafilatura/xml.py#L41


@conda-forge-admin, please add user @rhomspuron

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added user @rhomspuron in conda-forge/icepaposc-feedstock#7.


Release failing to publish binaries

When releases are published the binaries uploads have started failing with Error: Input required and not supplied: tag. Nothing has changed here from with things were working so I'm not sure yet what is going on.

This seems to be intermittent. In the 0.6.7 release the binaries published without error and nothing has changed.

The last several publishes have had no issue so this seems to have been an intermittent GitHub issue.


Dedicated frontend for vulnerability

@Cheshiriks I guess it can be closed?

Closes in https://github.com/saveourtool/save-cloud/pull/2862


Kinesis ehfo

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: Addison Higham:x: feathjAddison Higham seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Approved. :shipit:


WIP: Dipole IO

more coming...

Coverage decreased (-3.43%) to 82.72% when pulling 8f912910a11826d7e9d338dc885f2ac75131e650 on agramfort:dipole_io into 45ca6560c51447cdafc891ba9372c91f72589b83 on mne-tools:master.

LGTM, I'll take another round to make Travis happy and then merge unless you're about to

Let le finish the viz code first

On 27 févr. 2015, at 15:25, Eric Larson<EMAIL_ADDRESS>wrote:
LGTM, I'll take another round to make Travis happy and then merge unless you're about to
—
Reply to this email directly or view it on GitHub.

I mean I can push fixes to your branch that make Travis happy.
Want 'em?

go ahead but don't rebase
you have write access now

done

thanks
On Fri, Feb 27, 2015 at 4:25 PM, Eric Larson<EMAIL_ADDRESS>wrote:

done
—
Reply to this email directly or view it on GitHub
https://github.com/mne-tools/mne-python/pull/1829#issuecomment-76411329.

Coverage decreased (-3.43%) to 82.72% when pulling 51e4013697c2bdf2b924dcf6367e80e0fec79463 on agramfort:dipole_io into 45ca6560c51447cdafc891ba9372c91f72589b83 on mne-tools:master.

@agramfort is it okay with you if I merge this for now? I want to go ahead with modifying dipole.py and not being able to rebase will be a pain.

LGTM!

Ok. My time is up for today

On 27 févr. 2015, at 18:47, Eric Larson<EMAIL_ADDRESS>wrote:
@agramfort is it okay with you if I merge this for now? I want to go ahead with modifying dipole.py and not being able to rebase will be a pain.
—
Reply to this email directly or view it on GitHub.

Thanks


BIGTOP-4088: Refactor PKG_NAME_SUFFIX and PARENT_DIR

Description of PR
While working on adding pkgSuffix and parent directory to BigTop DEBs, it became necessary to pass these two variables to the DEB rules file. Upon inspection, I found that the code logic for pkgSuffix and parent directory in RPMs shared similarities in several places and was repetitive. The DEB logic appeared similar too. Instead of following the previous practice that resulted in significant code duplication, I have refactored this part and conducted tests.
Below are some comments regarding the modifications added.
getPkgNameSuffix(component, type) {
    def originalSuffix = type.equalsIgnoreCase("deb") ? component.deb_pkg_suffix : component.rpm_pkg_suffix

#In RPMs, the Suffix is in the form of a macro and cannot be an empty string, as it would result in a "macro empty body"
error. However, in DEB packaging, an empty string can be used.

    def defaultSuffix = type.equalsIgnoreCase("deb") ?  "" : "%{nil}"
    def pkgNameSuffix = project.hasProperty("pkgSuffix")? originalSuffix : defaultSuffix
    #The gradlePkgNameSuffix is solely used for concatenating package names, thus it must be empty if the originalSuffix does not exist.
    def gradlePkgNameSuffix = pkgNameSuffix == defaultSuffix ? "" : pkgNameSuffix

    return [pkgNameSuffix: pkgNameSuffix, gradlePkgNameSuffix: gradlePkgNameSuffix]
}
def getParentDir(bigtopBaseVersion, type) {
    #In RPMs, the Suffix is in the form of a macro and cannot be an empty string, as it would result in a "macro empty body" error. However, in DEB packaging, an empty string can be used.
    def defaultParentDirValue = type.equalsIgnoreCase("deb") ? "" : "%{nil}"
    def parentDir = project.hasProperty("parentDir") ? project.property('parentDir') : defaultParentDirValue
    if (parentDir && parentDir != "%{nil}") {
        parentDir = "${parentDir}/${bigtopBaseVersion}"
    }
    return parentDir

How was this patch tested?
manual test and smoke test
test without suffix
. /etc/profile.d/bigtop.sh;./gradlew zookeeper-clean zookeeper-pkg  -PbuildThreads=2C repo

smoke test
./docker-hadoop.sh -d -dcp -C config_rockylinux-8.yaml -F docker-compose-cgroupv2.yml -G -L -k zookeeper -s zookeeper -c 1

test with suffix
. /etc/profile.d/bigtop.sh;./gradlew zookeeper-clean zookeeper-pkg -PparentDir=/usr/bigtop -PpkgSuffix -PbuildThreads=2C repo

For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
[ ] Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

@guyuqi  @iwasakims @sekikn
Could you help review this PR?

While working on adding pkgSuffix and parent directory to BigTop DEBs,

@JiaLiangC I am confused by your description. This PR is not for just refactoring only? If this fixes is for DEBs, why you paste the result of RPM packaging?

The patch seems to break DEB packaging:
> Task :ranger-sdeb FAILED

FAILURE: Build failed with an exception.

* Where:
Script '/home/iwasakims/srcs/bigtop/packages.gradle' line: 515

* What went wrong:
Execution failed for task ':ranger-sdeb'.
> Could not get unknown property 'FULL_PARENT_DIR' for object of type org.gradle.process.internal.DefaultExecAction_Decorated.

@iwasakims
I apologize for the confusion. This PR has two objectives:

To refactor the parent directory and package suffix logic for RPM packaging.
To add logic for the parent directory and package suffix for DEB.

While working on the second point, I realized that referencing the existing logic for RPM's parent directory and suffix would result in a lot of duplicated code and make it difficult to understand. Hence, I refactored it.

@iwasakims  Thank you very much for help review this pr .
already fixed and run smoke test on debian 11
./docker-hadoop.sh -d -dcp --create 1 --image bigtop/puppet:trunk-debian-11 --docker-compose-yml docker-compose-cgroupv2.yml --docker-compose-plugin --memory 8g --repo file:///bigtop-home/output/apt --disable-gpg-check --stack zookeeper --smoke-tests zookeeper

This PR has two objectives:

you should have separated the PRs. Mixing refactoring and new feature makes review difficult. The behavir should not changed by refactoring while adding feature change behaviour.

This PR has two objectives:

you should have separated the PRs. Mixing refactoring and new feature makes review difficult. The behavir should not changed by refactoring while adding feature change behaviour.

Thank you, I was originally considering not opening too many PRs to increase the workload for reviewers, but it turns out my consideration was still not thorough. I will follow your suggestion to split them more simply.

already removed deb changes and retested


Better bulid numbers

Codecov Report

Merging #9040 (e58d1e1) into main (2207637) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #9040   +/-   ##
=====================================
  Coverage     70%     70%
=====================================
  Files        382     382
  Lines      24676   24676
  Branches    4000    4000
=====================================
+ Hits       17498   17507    +9
+ Misses      5567    5559    -8
+ Partials    1611    1610    -1

Impacted Files
Coverage Δ

...lient/datascience/variablesView/notebookWatcher.ts
90% <0%> (-3%)
:arrow_down:

src/client/datascience/jupyter/kernels/helpers.ts
50% <0%> (+<1%)
:arrow_up:

src/client/common/application/webviews/webview.ts
75% <0%> (+1%)
:arrow_up:

.../client/datascience/debugLocationTrackerFactory.ts
96% <0%> (+3%)
:arrow_up:

...ent/common/application/webviewViews/webviewView.ts
78% <0%> (+10%)
:arrow_up:

...ience/variablesView/variableViewMessageListener.ts
100% <0%> (+22%)
:arrow_up:


Implement Display and Debug traits for BLERemoteCharacteristic & BLERemoteService

This allows for easier debugging when working with clients. Debug ({:?}) now includes the most valuable fields, and display ({}) consists of the uuid, and, in the case of the characteristic, properties.
Here's an example:
I (4039) ble_client: (display) BLERemoteService[0x1812]
I (4039) ble_client: (debug) BLERemoteService { uuid: 0x1812, start_handle: 24, end_handle: 47, characteristics: Some([0x2a4e, 0x2a4d, 0x2a4d, 0x2a4d, 0x2a4b, 0x2a22, 0x2a32, 0x2a4a, 0x2a4c]) }
I (4059) NimBLE: GATT procedure initiated: discover all characteristics;
I (4069) NimBLE: start_handle=48 end_handle=65535
I (4829) ble_client: (display) BLERemoteCharacteristic[f3641401-00b0-4240-ba50-05ca45bf8abc]
I (4829) ble_client: (debug) BLERemoteCharacteristic { uuid: f3641401-00b0-4240-ba50-05ca45bf8abc, service: Some(f3641400-00b0-4240-ba50-05ca45bf8abc), handle: 50, end_handle: 0, properties: GattCharacteristicProperties(READ) }

I updated the ble_client example to include the change, but I'm unsure if it adds anything to the example.

My free quota for GitHub actions is met so have rerun the CI when it's restored. I'll try again in 24h.

Thanks.
Currently, esp-idf version 4.4 seems to have a compile error.
I will merge because of CI goes through in other versions.


Streamline docker setup

I added a -ignore-installed flagged to the pip3 installation command of the networkbuildercoordinator to ensure a consistent installation procedure across enviroments/infrastructures.

removed the ports specified for the profiler service since they are obsolete in this service and conflict with the elasticsearch service

added the command attribute for the profiler to hold the profiler arguments (since this is appended to the ENTRYPOINT on execution). This will allow to run the profiler by simply running docker-compose up profiler and allows for easy override in docker-compose.override.yml

Great, thanks!
Congrats on first contrib to the repo!


Registering duplicate deployment address will delete deployment from json

The StarkNet network will correctly reject an attempted deployment of a duplicate contract address. account.deploy unregisters deployments upon tx rejections; therefore, if account.deploy rejects a duplicate deployment, it will unregister the successful deployment as well. This occurs because the to_delete variable looks for the address or class hash of the entry.
A potential fix might include checking if the address or class hash already exists in register. Currently, it only checks for duplicate aliases. See https://github.com/OpenZeppelin/nile/blob/main/src/nile/deployments.py#L13-L15
Another idea might consist of waiting for the tx status before registering contracts.
Maybe both?

This is solved as part of #320

Fixed in #320


Unable to get batch response with Java client

I'm trying to get the IDs of the inserted objects with the Java client however that doesn't possible right now.
Here is what I tried:
        HashMap<String, Object> props = new HashMap<String, Object>();
        props.put("title", "Sam");
        props.put("content", "Sam");
        WeaviateObject wObj = WeaviateObject.builder().className("Article").properties(props).build();
        WeaviateObject[] objects = new WeaviateObject[]{wObj};

        Result<ObjectGetResponse[]> result = client.batch().objectsBatcher().withObjects(objects).run();

        if (result.hasErrors()) {
            System.out.println("Error: " + result.getError());
            return;
        }
        System.out.println("Result: " + result);
        System.out.println("getResult(): " + result.getResult());
        System.out.println("getResult().length: " + result.getResult().length);
        System.out.println("hashCode: " + result.getResult().hashCode());
        System.out.println("stream stuff: " + Arrays.stream(result.getResult()).toList().get(0).getObject());

an this is the output from running that java program:
Result: technology.semi.weaviate.client.base.Result@35dab4eb
getResult(): [Ltechnology.semi.weaviate.client.v1.batch.model.ObjectGetResponse;@2d901eb0
getResult().length: 1
hashCode: 764419760
stream stuff: null

You can use this repo to reproduce the behavior: https://github.com/samos123/weaviate-java-example
with curl I can easily get the ID back when I add batches:
curl \
-X POST \
-H "Content-Type: application/json" \
-d '{
  "objects": [{
    "class": "Article",
    "properties": {
        "title": "Sam",
        "content": "Sam"
    }
  }]
}' \
http://localhost:8080/v1/batch/objects
[{"class":"Article","creationTimeUnix":1668793496792,"id":"b51cbabf-64e5-4b00-964b-0d20e88dd218","lastUpdateTimeUnix":1668793496792,"properties":{"content":"Sam","title":"Sam"},"deprecations":null,"result":{}}]

Looks like this has been fixed in a recent PR https://github.com/semi-technologies/weaviate-java-client/pull/140/commits/9b7dd4292f986382db3293cf300ef0a7377a1c74

Closing this since I confirmed this works in the newly released 3.4.1. Thank you @aliszka


Calling "DebugMenu.style" returns "Invalid get index 'style' (on base: 'CanvasLayer')"

The addon is working well with the F3 shortcut, but I tried to make an on screen button to toggle it but calling the DebugMenu.style is for some reason causing the "Invalid get index 'style' (on base: 'CanvasLayer')" error.
The singleton is loaded and everything seems to be working, so why it's retuning a CanvasLayer instead of a script instance is beyond me.
Using Godot 4.1.2.stable.  I'll update if I figure out what causes it.

try like this: DebugMenu.get_node("DebugMenu").style = DebugMenu.get_node("DebugMenu").Style.VISIBLE_COMPACT

Thanks for the report! Consolidating in https://github.com/godot-extended-libraries/godot-debug-menu/issues/15, which was fixed by https://github.com/godot-extended-libraries/godot-debug-menu/pull/16 but isn't present in a tagged release yet.


"Deleted" files should go to the Recycle Bin

To avoid costly loss of data, assets and source files should get moved to the recycle bin instead of deleted. Unity does it this way for good reason.
I lost a source file when Xenko deleted it unexpectedly. I would have loved to find it in the recycle bin.

Done with https://github.com/phr00t/xenko/commit/1aeb61a84cdace69239e3af781d898f9acb9a8dc


[Bug] Deadlock in filestream layer

On commit d036eb9fc5f893d25d7b122fb51d4be4c23c0316.
I am experiencing a deadlock involving the file stream layer. Sorry I don't have a minimal repro yet.
Seems related to the recent eliminate r/w lock promotion concept commit.
Main thread:
os_rw_mutex_take_r
fs_size_from_path
e_irtree_and_type_from_expr
e_eval_from_expr
e_eval_from_string
rd_file_path_from_eval_string
rd_frame
frame
update
entry_point
main_thread_base_entry_point
w32_entry_point_calle
wWinMain
[async] work thread #0
os_rw_mutex_take_w
fs_stream_work
async_execute_work
async_push_work_
fs_hash_from_path_range
fs_key_from_path_range
dasm_parse_work
async_execute_work
async_work_thread__entry_point
os_w32_thread_entry_point
[fs] detector thread
os_rw_mutex_take_r
fs_detector_thread__entry_point
os_w32_thread_entry_point

No problem, yep I think I thought this change through poorly - working on a fix now.


how to transform tfrecord files into images in training set

I have written the for loop code for converting tfrecord files into images in training set, but finally from training folder 000 to training folder 031, throughout the conversion process, I finally only got 3990 images. But I guess for training set, we may get more than 100k images actually. Is there any advise how I can resolve this issue in order to arrive at the accurate number of images in training ?

Hi,
Could you provide your main for loop for reading the images from open datasets?


Adds a Jaeger UI detail for distributed tracing

The current "Distributed Tracing" section misses a step to have a user select the productpage service from the Jaeger UI. This PR also cleans-up a few sentences for readability.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: danehans
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
Assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: danehans, sdake
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [sdake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: danehans, sdake
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [sdake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geeknoid can you merge this - CLA stuck.


Fix prebuilt per-repo isolation

To help with minimizing prebuilts, we should include only the necessary prebuilt packages when building each repo.

Prebuilts should be put into a repo-specific directory when building the tarball.
Source-built packages should still be removed from each prebuilt folder.
Only each repo's prebuilt directory should be included in its prebuilt path.

Maybe gzip handles this well enough that we don't care, but we can avoid putting duplicates in the tarball if we make a list of all nupkgs needed in each repo's prebuilt folder, and copy/move them from a tarball dir that has the duplicates removed.

Source-built packages should still be removed from each prebuilt folder.

Only if they're bitwise identical though--we can't remove a package if it was only source-built after it was used as a prebuilt.

[Triage] This has been superseded by https://github.com/dotnet/source-build/issues/2482.


drivers: usb: udc: add Smartbond UDC driver

Code adds USB UDC driver for Smartbond device.
Code was NOT tested with ISO endpoints yet.
It was tested with console, mass, and cdc_acm applications
Additionally small fix in DMA power management was needed.
Function dma_smartbond_set_channel_status() used incorrect
condition to release state lock.
In initialization function dma_smartbond_init() function
dma_smartbond_set_channel_status() was called for each DMA
channel and tried to release lock that was never taken.
It completes #74662
Signed-off-by: Jerzy Kasenberg<EMAIL_ADDRESS>

Please add  usbd as supported peripheral in DA1469x boards' yaml file.

Please add usbd as supported peripheral in DA1469x boards' yaml file.

done

Build fails due to unrelated change #73189 (issue #79594)


bpf: remove map migrations, add custom map flag

Fixes: #29333
Fixes: #29334
Addressing both these issues in a single PR since they're relatively co-dependent.
See individual commits for details.
Remove bpf map migration mechanism to minimize bpf file system operations during endpoint regeneration

/test

/test

/ci-verifier

/test


⚠ Cioos National CKAN has degraded performance

In 0140a8f, Cioos National CKAN (https://catalogue.cioos.ca/) experienced degraded performance:

HTTP code: 200
Response time: 6560 ms

Resolved: Cioos National CKAN performance has improved in b495269 after 9 minutes.


Update setup-spark.ts

Possible enhancement to not fail silently #1

@vemonet I just did it from the home directory instead:
- name: Setup Spark
  run: |
    cd /tmp
    wget -q https://aws-glue-etl-artifacts.s3.amazonaws.com/glue-1.0/spark-2.4.3-bin-hadoop2.8.tgz
    tar xzf spark-2.4.3-bin-hadoop2.8.tgz -C /home/runner
    rm spark-2.4.3-bin-hadoop2.8.tgz
    echo SPARK_HOME=/home/runner/spark-2.4.3-bin-spark-2.4.3-bin-hadoop2.8 >> $GITHUB_ENV


specified library names in embedded function calls

eplicity defined library names & removed installs from helper scripts

works on test script


Delete an entire group

As a student with many friends, I want to be able to delete an entire group that was created previously.

Settled with PR#38


[docs] pjax examples and explanations

Related to #2414

I think with this is enough to close #2414 what do you think @samdark ?

@Faryshta yes, I think it's perfect! Thank you!

Good additions! Let's fix these minor wording things and merge it.

done

Thank you, @Faryshta!


Implement S3 storage

Acknowledging the stipulations set forth:

[ ] I hereby confirm that a Pull Request involving updates to the Software Development Kit (SDK) has been smoothly merged, currently awaits processing, or is otherwise deemed unnecessary in this context.
[ ] I also affirm that another Pull Request, specifically addressing updates to the documentation body (commonly referred to as 'docs'), has either been successfully incorporated, is in the process of review, or is considered superfluous under the prevailing circumstances.

This draft is not meant to be reviewed entirely. The purpose of this PR is to show one of two possible solutions that can be fully implemented.
In this case, HLS is sent to S3 by Membrane.HTTPAdaptiveStream.Storage implementation so every segment and manifest iteration is sent right after creation.
Apart from sending it to the S3 bucket each segment is saved on the Jellyfish server.
That allows us to serve live HLS simultaneously and fix some problems in postprocessing that may occur during the stream.
The big disadvantage is that we cannot push HLS to S3 and simultaneously serve LL-HLS (it is technically possible but It would require a lot of work).

Send the whole stream at once on the Engine termination
In this scenario, we would spawn (if needed) the process responsible for sending the stream to S3 on the :add_component event.
This process would monitor the Engine process and on the Engine termination, It would do the sending.
This solution requires some constraints, ex: the stream cannot be removed before the end of postprocessing, so the option persist has to be reconsidered.
On the other hand, It gives us a lot of flexibility with the stream, ex: we can validate and repair the stream if needed before sending it to S3,  we can use LL-HLS ( it's important, we can't do it easily in the storage scenario)
@impl true
  def handle_call({:add_component, component_type, options}, _from, state) do
    options =
      Map.merge(
        %{engine_pid: state.engine_pid, room_id: state.id},
        options
      )

    with :ok <- check_component_allowed(component_type, state),
         {:ok, component} <- Component.new(component_type, options) do
      state = put_in(state, [:components, component.id], component)
      if component_type == HLS do
         on_hls_startup(state.id, component.metadata)

         # spawning process responsible for s3
         maybe_init_s3_process(state.engine_pid, s3_credentials)
     end
      :ok = Engine.add_endpoint(state.engine_pid, component.engine_endpoint, id: component.id)
     .
     .
     .
  end


GPS of learning- TPD

Purpose of the Feature
The dashboard provides details on the total content plays, total time spent and average time spent for Teacher Professional Development (TPD) by location of all districts of the State.
Described Solution
It is a Map report which can describe the metrics with the dots pointed at the districts on the state map. Below are the required actions in the reports

One dot should be represented one district on the map
Dots should be represented in 5 green color gradient (From light green to Dark Green).
Legend should be given at the right side of the Map with 5 dividend slots.
Report should have a selection option of "total content plays", "total time spent" and "average time spent"
The metrics, Dot colors and the legend values should be changed according to the selection.
Others (Out of expected users plays) should be represented at the right side of the Map, Below the legends.
Footer should contain the state level metrics.

Effected code areas

New PostgreSQL Queries should be developed for "total content plays", "total time spent" and "average time spent"
New NIFI processors to be created for the above queries execution
New Node API should be written to fetch the output files
Angular code should be developed for the Map representation for the created metrics.

Updated the data flow and JOLT Transformation.

Added the queries to calculate "total content plays", "total time spent" and "average time spent".


🐛 [BUG] -

Description
the image at the maze game project is not showing its broken

Reproduction URL
https://zerooctave.co/ZeroOctave-Javascript-Projects/
Reproduction steps
1. Go to 'https://zerooctave.co/ZeroOctave-Javascript-Projects/'
2. Scroll down to 'maze game'
3. See error

Screenshots
![Screenshot 2023-06-04 184815](https://github.com/ZeroOctave/ZeroOctave-Javascript-Projects/assets/95420063/56511021-7cde-4c67-bc6c-462a819c8868)

Logs
No response
Browsers
No response
OS
No response
Additional Context
No response
Sections Completed

[X] Description
[X] Reproduction URL
[X] Reproduction steps
[ ] Screenshots
[ ] Logs
[ ] Browsers
[X] OS
[ ] Additional Context

Code of Conduct

[X] I follow Contributing Guidelines of this project.
[X] I have checked the current issues for duplicate problems.
[X] I have read the readme of this repository.

can i work on it

I m already working on it today i will submit PR for this

Thanks for showing interest

Hi i just fixed this and made a pr


Restrict the attributes set from responses in Maps/NamedMaps

Fixes #118

I'm not sure if we need something similar for anonymous maps

Hey, I checked and currently AnonymousMap is not affected by the problem in #118, but it could in the future, so I've protected it too with a white list of admitted fields.
Can you take another look at this now, @alrocar ?


Blazor Component only Renders on Index.cshtml

I have updated an Asp.Net Core 2.2 application to Core 3.  And have added all the appropriate items to enable Blazor Components and they work great on any razor page that is Index.cshtml.  However, any page that does not have that naming it will not execute.  Simply changing the name will allow it to render correctly.  I believe this to be a bug, unless I have overlooked a routing issue or something else.
Startup.cs/Configure Items
app.UseRouting();
app.UseAuthentication();
app.UseAuthorization();
app.UseEndpoints(endpoints =>
{
endpoints.MapControllers();
endpoints.MapControllerRoute(
name: "default",
pattern: "{controller=Home}/{action=Index}/{id?}");
endpoints.MapRazorPages();
endpoints.MapBlazorHub();
});
startup.cs/ConfigureServices
services.AddControllersWithViews().AddRazorRuntimeCompilation();
services.AddRazorPages().AddRazorRuntimeCompilation();
services.AddServerSideBlazor();
Steps to reproduce the behavior:

In an asp.net core 3.0 application add a New Folder to your pages folder called Dashboard, (or anything...).
Create a new page called Index.cshtml, also create a page called Dashboard.cshtml
Create a new Blazor Component in a Folder called Components
Add the Blazor Js reference to both razor pages.
Call the Blazor Component on both pages like this,
@(await Html.RenderComponentAsync(RenderMode.Server))
Run the application and navigate to ~/Dashboard, the component renders. now navigate to /Dashboard/Dashboard, the component will not render.

Expected behavior
The component should render on both pages

Also Seeing this.  I think the issue is that it is pointing _Bazor.js to the wrong path.  The path is /Dashboard/_Blazor, shouldn't it be /_Blazor ?
Thank you

I was able to correct this issue by adding  to my layout partial just below my usings and injects.  I was correct that if you are using any page named anything other than Index.cshtml it will add the folders and subfolders to the path of _blazor when setting up the SignalR connection.  Adding  maps it back to https://yourserver/_blazor and fixes the issue.


Buy/Sell widget needs better padding

Describe the bug
The Buy/Sell widget has some broke padding when trying to select token, and it seems to cut off the last couple pixels of each token in the list
To Reproduce
Steps to reproduce the behavior:

Go to http://indexcoop.com/dpi
View Buy/Sell widget, should see something like the below screenshot

Expected behavior
This should not cut the letters off prematurely
Screenshots

Desktop (please complete the following information):

OS: Mac
Browser: Brave

Hello, I would like to solve this issue.

Have at it

I have this done, can I submit a pull request?

yes


Web Site Certificate Issues

When visiting your website being redirect by ISP as "dangerous site".

Thanks for the report.
I've re-checked SSL reports on Qualys (https://www.ssllabs.com/)  and SSLShopper (https://www.sslshopper.com/) and everything seems to be valid and trusted. The only issue is lack of some TLS 1.2  protcools support on the server-side. Even though Qualys rates it as B which means good enough (for plain binary content). Unfortunately we can't control this as download.dbeaver.com is a world-wide CDN (DigitalOcean), i.e. we can't control server settings. But we could talk with our VHP.
Could you say where are you from (country)? It may affect what particular CDN server serves your region.
Also is it possible to get any information about particular issues with server security?

there is no update on issue for a long time.
If it is still actual for you - feel free to reopen it with additional info.


dune_2: 2.6.2 -> 2.7.0

Motivation for this change
https://github.com/ocaml/dune/releases/tag/2.7.0
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build flow fstar ocamlformat beluga satysfi

There is an easy fix to get dune 2 for OCaml 4.07. Just raise the version number there: https://github.com/NixOS/nixpkgs/blob/4e7fdca34c4bb94470590f02615e56cee97c2d75/pkgs/top-level/ocaml-packages.nix#L221
You should nonetheless raise the minimumOCamlVersion attribute in dune-private-libs.

@GrahamcOfBorg build flow fstar ocamlformat beluga satysfi

@GrahamcOfBorg build flow fstar ocamlformat beluga satysfi

thank you @vbgl for the hint

@GrahamcOfBorg build ocamlPackages.dune-action-plugin


Update ncc to allow for empty parameter names

This should be allowable:
void foo(int);

Rather than having to put in a useless variable name which then requires a [[maybe_unused]] attribute like so
void foo([[maybe_unused]] int p_not_used);

Using the following expression does not fix this issue: ^(p_[a-z]+[a-z0-9_]*|)$
So this likely requires an investigation and update to the NCC code base https://github.com/nithinn/ncc/blob/master/ncc.py


Callback or notification when stream starts.

Hello, is there a way to get some sort of notification or to hook a callback so that when the stream starts, we can do an operation?
My use case is the following, there is, obviously, a slight delay before the time we perform a request and the stream starts getting listened from the audio output device. In my scenario I want to play a "loading sound" while it's still not streaming. Having what I mention would improve the user experience in my scenario a lot.
Thank you for this fantastic facility <3

Added in 8b42fd6ec06ebedf0997839e4322849bfd669248


The pre-trained checkpoint

Hi, To Fine-tune the pre-trained checkpoint, the pre-trained checkpoint is taken from here https://github.com/xinyu1205/recognize-anything/tree/main?tab=readme-ov-file#toolbox-checkpoints right?
Thanks

yes


Bins are not documented

An example is needed in the readme for creating and using a bin.

check out the documentation here: https://github.com/u1i/bambleweeny/blob/master/DocumentationIndex.md#create-bins

I think it would be a good idea to have the bins more prominently featured also in the readme-file. Now they are missing from the swagger endpoint image, and they don't have an example among other feature examples in the readme-file.


Has helper updates for multi-author

In order to support theming of multi-author, we need to add a couple of new features to our {{#has}} helper.
1. allow checking the primary_tag/author for a match:
{{#has primary_tag="news"}}, {{#has primary_author="fran"}}
This should use the same logic as the existing {{#has [tag/author]=""}} syntax, which is a hybrid check for slug/name.
2. support counting tags/authors:
{{#has author="count:>1"}}, {{#has author="count:<1"}} {{#has author="count:1"}}
{{#has tag="count:>1"}}, {{#has tag="count:<1"}} {{#has tag="count:1"}}
This syntax is similar to the {{#has number="nth:3"}} syntax and also our filter syntax. It allows the theme developer to compare against the number of tags, and do something different in each case, e.g:
{{#has author="count:0"}}
   ... case no author (not supported yet, but will be)
{{else has author="count:1"}}
  ... case exactly 1 author
{{else}}
  ... more than 1 author
{{/has}}

For both author & tags, count:0 should be supported by the has helper.

{{#has author="count:>1"}}

Isn't it {{#has authors="count:>1"}}? 🤔

No, it is an extension of the existing attribute: https://github.com/TryGhost/Ghost/blob/master/core/server/helpers/has.js#L10
Ref: Slack convo


Having trouble getting the x close synble to show  up on the filters

After i create a filter. The little x to remove the filter will not show up. Could you point me in the direction to resolve this?
Im including jquery base css and light theme css and jquery jquery ui and the project js

Thank you for your time in advanced.

I wanted to add that its not adding the element with the class "ui-button-icon-secondary ui-icon ui-icon-close" to the new filter.
Your example

My code

p.s. this project is amazing im happy i found it.

It seems like you modified the classes. For the button to show up you need the jQuery UI class or you need to create a class that would give provide the same look.


refactor(dsp): make handleResult return a Result

What this PR changes/adds
Refactors the handleMessage method of two controllers (DspNegotiation... and DspTransferProcess...) such that errors are conveyed using instances of Result rather than exceptions.
Why it does that
Make code cleaner and more efficient.
Further notes
Linked Issue(s)
Closes #3026
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] assigned appropriate label? (exclude from changelog with label no-changelog)
[ ] formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

Codecov Report
Patch coverage: 94.55% and project coverage change: -0.16 :warning:

Comparison is base (edb3597) 66.01% compared to head (b442d89) 65.86%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3051      +/-   ##
==========================================
- Coverage   66.01%   65.86%   -0.16%
==========================================
  Files         947      947
  Lines       19583    19511      -72
  Branches     1047     1053       +6
==========================================
- Hits        12927    12850      -77
- Misses       6263     6266       +3
- Partials      393      395       +2

Impacted Files
Coverage Δ

.../eclipse/edc/service/spi/result/ServiceResult.java
47.82% <0.00%> (-2.18%)
:arrow_down:

...pi/controller/DspTransferProcessApiController.java
93.25% <92.06%> (-3.30%)
:arrow_down:

...on/api/controller/DspNegotiationApiController.java
93.75% <97.56%> (-3.09%)
:arrow_down:

...eclipse/edc/service/spi/result/ServiceFailure.java
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Properly setup with auto discovery, save host and port

In the auto-discovery code path, async_get_device_properties() requires the host and port, which aren't applicable for USB device_path. To fix, pass in None for those parameters
When reading the data in the cache to create the Emu2 object, the dictionary didn't contain the null Port and Host, so it threw the exception. To fix, ensure that when cache is saved, the Host and Port are saved in the config.

#16


Add pointer to Tooltips

Closes #218
now tooltips have a cursor pointer baked in, no need to add it to the translation

Hmmm when I tap the tooltip, it still jumps to the link instead of letting me see the tooltip. I also tapped the bottom tooltip for reference.
https://user-images.githubusercontent.com/32662508/222550715-a45e9ae4-2fde-4767-87ec-1e616dba017f.MP4

Okay tested this PR and can confirm the "hand" appears for both tooltips!
Let's not address the mobile issue in this PR. I'll create a separate issue for it and we can discuss on our call.


Base64

Hi,
awesome project, I wonder if you could make it work with base64 images ?

I roll back what I said, I get it to work with base64!


some corrections

based on https://www.knmi.nl/kennis-en-datacentrum/uitleg/windschaal-van-beaufort?fbclid=IwAR3yUA4SnvCr7KrGuH and other data source, to distinguish between 1/2 and 3/4

Thanks Marius. I'll give a few days to see if other translations are needed and then release this.


Adding 28 days or more causes overflow when date is close to February

Description of the Issue and Steps to Reproduce:
Adding 28 days or more to a date in a non-leap year (or >= 29 in a leap year) is causing the library to calculate remaining time wrong:
E.g.:
moment('2017-01-31').add(26, 'days').from(moment('2017-01-31')) // "in 26 days"
moment('2017-01-31').add(27, 'days').from(moment('2017-01-31')) // "in 27 days"
moment('2017-01-31').add(28, 'days').from(moment('2017-01-31')) // "in 30 days"
moment('2017-01-31').add(29, 'days').from(moment('2017-01-31')) // "in 31 days"
moment('2017-01-31').add(30, 'days').from(moment('2017-01-31')) // "in 32 days"
moment('2017-01-30').add(29, 'days').from(moment('2017-01-30')); // "in 30 days"

Please include the values of all variables used.

Date from: '2017-01-31'

Environment:
Examples: Chrome 49 on OSX, Internet Explorer 10 on Windows 7, Node.JS 4.4.4 on Ubuntu 16.0.4

node.js v6.2.2 on Linux Mint Cinnamon 17.3

> moment('2017-01-31').add(28, 'days').from(moment('2017-01-31'))
'in a month'
> moment.version
"2.13.0"

Chrome 55.0.2883.87 (64-bit) on Linux Mint Cinnamon 17.3

> moment('2017-01-31').add(28, 'days').from(moment('2017-01-31'))
'in 30 days'
> moment.version
"2.17.1"

Other information that may be helpful:

The time zone setting of the machine the code is running on: GMT-0300 (ART)
The time and date at which the code was run: Feb 26 2017 13:23:49 GMT-0300 (ART)

If you are reporting an issue, please run the following code in the environment you are using and include the output:
console.log( (new Date()).toString())
console.log((new Date()).toLocaleString())
console.log( (new Date()).getTimezoneOffset())
console.log( navigator.userAgent)
console.log(moment.version)

Sun Feb 26 2017 13:24:25 GMT-0300 (ART)
2/26/2017, 1:24:25 PM
180
Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36
2.17.1

Perhaps I'm missing something. I've tested this on 2.17.1 and I get "in a month" for each case you posted!
Fri Mar 03 2017 01:27:44 GMT-0500 (EST)
3/3/2017, 1:27:44 AM
300
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36
2.17.1

Also tested on 2.17.1 using node.js v6.5.0 on Mac OS 10.11.6

Dumb questions first: is it possible that this only happens on February?

No, I tried changing my clock:
> moment().format()
'2017-02-09T01:14:31-05:00'
> moment('2017-01-30').add(29, 'days').from(moment('2017-01-30'));
'in a month'

Is it possible you've overidden your relative time thresholds?

No, I didn't. It is weird, because since March I can't reproduce it anymore. It keeps telling me "in a month" instead of "in 30 days". Is there a way to force to display in xx days instead of 'in a month`?

Yes, that's why I linked you to the way to do that and asked if that's what you had done.
> moment.relativeTimeThreshold('d', 31)
true
>  moment('2017-01-30').add(29, 'days').from(moment('2017-01-30'))
'in 30 days'

That isn't right, but it comes from Moment realizing that you added a full month and creating a duration of  and then forgetting which specific month it is. Then when asked to translate back to days, it just thinks a month is 30 days long. I bet that mismatch comes from the internals being built before the thresholds were made configurable.
That's definitely a bug, but I'm guessing it's a low priority to fix. More importantly, if you're not setting relativeTimeThreshold() it's not the problem you're seeing. You'll have to provide us with something reproducible so we can help.

Closing for age. If you have more info, feel free to @ me and I'll reopen.


print feed manifest hash without doing update

it would be useful to be able to retrieve a feed manifest hash/url without having to do an update
perhaps a ux variant or additional feature request would be to not update the feed if the current latest feed update matches the upload hash (i.e. the user has attempted to upload the same content as an updated)

Have you tried the feed print command? It seems to be doing exactly what you are asking for:
 % swarm-cli feed print -i main -P 1
Feed Manifest URL -> http://localhost:1633/bzz/fdf21a5556e968c4079ba6b06b16a6ec545c2ce189db867c0ad5f6a0d4004de6/

 % swarm-cli feed print -i main -P 1 -v
Chunk Reference -> 1868f182f46306f709ebc02271cea4776a1d45510e7bce3607be7d302b3cf2d7
Chunk Reference URL -> http://localhost:1633/files/1868f182f46306f709ebc02271cea4776a1d45510e7bce3607be7d302b3cf2d7
Feed Index -><PHONE_NUMBER>000008
Next Index -><PHONE_NUMBER>000009
Feed Manifest -> fdf21a5556e968c4079ba6b06b16a6ec545c2ce189db867c0ad5f6a0d4004de6
Feed Manifest URL -> http://localhost:1633/bzz/fdf21a5556e968c4079ba6b06b16a6ec545c2ce189db867c0ad5f6a0d4004de6/

perhaps a ux variant or additional feature request would be to not update the feed if the current latest feed update matches the upload hash (i.e. the user has attempted to upload the same content as an updated)

Great idea, I created a new issue for that: https://github.com/ethersphere/swarm-cli/issues/64

perfect! thanks! 😁


Team 11 (UI)

Description
In this feature, the main user interface will be designed and implemented. Elements and functions such as the main map, mini-map, and inventories will be included. These elements provide visual aesthetics, colour schemes, and the overall appeal of the user interface. Then, the character's nickname, health bars, levels, weapons, buffs, and debuffs will be implemented and displayed. This is to provide the responsiveness of the interface to player inputs and player's in-game engagement. Additionally, since the UI holds a large range of designs and functions, frequent communication and discussion with the other teams are required.
SubFeature/component (optional)

Name: the character's name in game
Health bar: how much health the player has currently
Levels: The player's current levels
Weapons: tools made by human
Inventory: Collection notification
Buffs: Periodical Add-on benefits
Debuffs: Periodical affection dealt by enemies
Quests - Displaying dialog when message received
Animals - Animals and its amount collected by the player
Dialogue box: optional interaction between player and npc.

Examples (optional)

Health Bar: a visual representation of how much energy or life force we have left as we progress through the game
Inventory: a common UI feature where one can view all the items that have been collected thus far.

Dependencies
T1, Animals #4
T10, Combat #7
Milestones

[x] [Completion of Hunger bar - Pratul] #42 (Aug 29)
[x] [Completion of Experience bar - Jared]  #84 (Aug 29)
[x] [Completion of Health bar - Christian] #36 (Aug 29)
[x] [Completion of Player Icon - Amos]  #91 (Aug 29)
[ ] [Completion of Player Name - Arthur] #46 (Aug 29)
[x] [Completion of DialogBox Class - Whole Team ] #48  (Aug 22)

Completion Deadline: Aug. 29
Extras

[ ] Special animation for stats.
[ ] Auto play.
[ ] Settings Button for Other Teams Use

Documentation

TBC

Members

Christian Almario (@ChristianMario4)
Pratul Wadhwa (@Pratulw5 )
Jiatong Wang (@ArthurW4130)
Aaradheya Sharma (@Dabbyyyy)
Jared Smith (@Jared946 )

Most features completed.


Remove entity label from audit log and look up info in database

Backend part of #822  (Need to make small change on frontend to look up label from a new place.)
In the same way we look up current information about a submission when we get audit log events for a specific entity (so we can appropriately handle deleted submissions), this does the same thing for entity information.
Previously, the details for an event like entity.create contained an entity object with uuid, dataset, and label.
label has been removed, so the audit details only contain uuid and dataset but default.
But through the getBySubmissionId query, for events about entities, details.entity contains entity data populated from the database. This object has the same structure you'd see elsewhere in the API for getting details about an entity, but with the additional dataset property that was already in the audit event details.
...
    'action': 'entity.create',
    'details': {'entity': {'createdAt': '2023-08-30T19:16:38.812Z',
                         'creatorId': 5,
                         'currentVersion': {'createdAt': '2023-08-30T19:16:38.812Z',
                                            'creatorId': 5,
                                            'current': True,
                                            'data': {'circumference_cm': '333',
                                                     'geometry': '44.296333 '
                                                                 '-75.364095 0 '
                                                                 '0',
                                                     'species': 'purpleheart'},
                                            'label': '333cm purpleheart',
                                            'userAgent': 'Enketo/6.2.2 '
                                                         'Mozilla/5.0 '
                                                         '(Macintosh; Intel '
                                                         'Mac OS X 10_15_7) '
                                                         'AppleWebKit/537.36 '
                                                         '(KHTML, like Gecko) '
                                                         'Chrome/<IP_ADDRESS> '
                                                         'Safari/537.36'},
                         'dataset': 'trees',
                         'deletedAt': None,
                         'updatedAt': None,
                         'uuid': 'f08a4912-1c45-4dc5-a27a-36a6bb5d2638'},
              'entityDefId': 2,
              'entityId': 2,
              'submissionDefId': 2,
              'submissionId': 2},
...

If the entity has been soft deleted or purged, OR if the request is NOT EXTENDED, the details will look like this (closer to how they looked before but now without label):
'details': {'entity': {'dataset': 'trees',
                     'uuid': 'f08a4912-1c45-4dc5-a27a-36a6bb5d2638'},
          'entityDefId': 2,
          'entityId': 2,
          'submissionDefId': 2,
          'submissionId': 2},

What has been done to verify that this works as intended?
Tests.
Why is this the best possible solution? Were any other approaches considered?
Follows a similar pattern as submission events for entities. Adds more useful info.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Going to make a change on frontend so deleted entities are displayed differently and dont have broken links.
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
I think this kind of detail about audit log event details isn't documented.
Before submitting this PR, please make sure you have:

[x] run make test-full and confirmed all checks still pass OR confirm CircleCI build passes
[x] verified that any code from external sources are properly credited in comments or that everything is internally sourced

Need to make small change on frontend to look up label from a new place.

If the entity is deleted, how about we show its UUID, similar to how we show the instance ID if a submission is deleted? Ideally, we also wouldn't render a link if the entity is deleted. I think those are nice-to-haves though: we could probably back to this later once we're thinking more about entity deletion and purging.