feat(template-vite): switch to esm by default.

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[ ] The changes are appropriately documented (if applicable).
[x] The changes have sufficient test coverage (if applicable).
[x] The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Closes #3502, #3503

Currently it is not possible to directly change the module in tsconfig.json to ESNext because it will cause an error in forge.config.cts when running yarn start.

But this actually does not affect the running and building of vite templates, because Vite does not care about tsconfig.json.

src/main.ts

tsconfig.json

This looks like it's less like "support esm", and more like "switch to esm."
Not a bad thing really, but is this another potentially breaking change that's going to land in another minor release? 🤔

This looks like it's less like "support esm", and more like "switch to esm."
Not a bad thing really, but is this another potentially breaking change that's going to land in another minor release? 🤔

v7.3.0 can be supported by ESModule through user modification, which is not subject to @electron-forge/plugin-vite.
#3572 is just a few changes to the template, not a major upgrade.

Build using the ESModule.

Build using the CommonJs.

I kind of liked your idea of building according to the package.json's .module property.
I don't know if it's a good idea to separate the ideas of

build using esm (build system runtime) and
build into esm (electron runtime... and then further configuring for the host, the preload build, and the renderer).

I'm seeing, for instance, with this PR that the preload script is still being built into commonjs (and two commented links adding some context for that), while the host and renderer are defaulting to "follow the package.json".

For the file suffixes and build formats of Preload script. I also feel very confused, I have been studying here for a long time.

https://github.com/electron-vite/vite-plugin-electron/blob/v0.28.6/src/simple.ts#L54-L82

@caoxiemeihao in local testing in my single environment, I found that with package.json type=module,  I needed to not only compile preload into cjs but also specify the extension:
new BrowserWindow({
    webPreferences: {
      preload: resolveRelative("./preload.cjs"),
    },
  })

Otherwise node would complain about the importing a module with require (regardless of the content of preload being commonjs or esmodule).
Testing with webPreferences: { contextIsolation: true, preload: resolveRelative("./preload.mjs") }

Not finding a path to import an esm-compiled preload script at all.

I've provided boilerplate for esm.

electron-forge-vite
electron-forge-vite-ts

If you try adding in the above sample preload.js files:
import * as e from 'electron';

and check the compiled output, they are commonjs (as specified by the cjs format).
They load fine, as they're not esm, and I checked and it doesn't matter if I use a .mjs extension or not.
(If you set the format to es then electron fails to load the preload script.)

I've provided samples for esm.

electron-forge-vite-esm
electron-forge-vite-esm-ts

For folks finding this who may be using typescript + tailwind and still having issues, make note of a change to the preload extension when creating BrowserWindows as well as this note about the extension on your postcss config

Note that postcss config files do not support ESM + TypeScript (.mts or .ts in "type": "module") yet. If you have postcss configs with .ts and added "type": "module" to package.json, you'll also need to rename the postcss config to use .cts.

After going through and updating my files to match forge-esm-ts I think things are running fine 🙏🏾


TSServer Reference requests taking a long time

From https://github.com/Microsoft/vscode/issues/31344
TypeScript Version:  2.4.2
While working in the VSCode codebase, @kieferrm noticed some major slow downs while working in a TS file. It seem the references requests against TSServer are taking up to a second.
Here are his repo steps:

open a VS Code workspace on master, no open editors
search for from 'electron' in all *.ts files
click on the first search result and wait until TS is properly initialized
click on the second search result and select ipcMain in the editor
-> caret stops blinking, it takes several seconds until the underlying word is highlighted and occurrences are shown in the scrollbar (only happens after the reference code lenses are shown)

And the TSServer log:
https://github.com/Microsoft/vscode/files/1171339/tsserver-log.txt

Nothing stood out in the logs besides the long references requests. I believe the root case may be that we are closing and then reopening the vscode project when switching between the search results

Looking at the logs, it doesn't look like this has to do-with find-all-references. I see 11::references: elapsed time (in milliseconds) 99.1908 but 2::open: async elapsed time (in milliseconds) 7332.0351.
I can reproduce this by:

Enable "workbench.editor.enablePreview": true, in my settings
Search for any text
Click on first result, hover over something. Takes a while to get info.
Click on next result -- this closes the file of the first result and opens a new one.
Hover again -- takes a while again.

So it looks like it is because we unload the project when the file closes.
I can also reproduce the same behavior using vscode's built-in file explorer; when I click on a new file, the old file closes, closing the project, then it has to be loaded all over again.
There is a PR at #17269 for improving our watch implementation; perhaps we could consider keeping project files open for 1 second after the last time they were closed.

@andy-ms this would be comparable to what we do in VS Code when the last TS file closes. We keep the TS language server around for while to make sure that when a TS file is open briefly afterwards we don't have to pay the startup costs again.

This is a real show stopper and makes TypeScript very hard to deal with. I can reproduce this easily by just opening files in our project. Open vscode.d.ts, open shell.ts, open workbench.ts etc. with each file the project is discarded and then the same project is loaded again

@andy-ms Just to clarify how this affects the users of VS Code: When you don't use tabs and navigate around we dispose/close documents more aggressive and you are very likely to run into this on every editor input change. So, the suggestion from @kieferrm to wait a little before throwing everything away would make a lot of sense.

@sheetalkamat was looking at something similar last week. one option is to keep the project information in memory after the file is closed, and then destroy it on the next file open request. this allows us to reuse it if a file from the same project was opened.

#17269 takes care of this by keeping the configured project alive till after next file open request and I am able to navigate/get completions correctly with the changes from that PR

Thank you for taking a look @sheetalkamat!
Is there a targeted fix that could be backported from that PR to TS 2.5.3?

Is there a targeted fix that could be backported from that PR to TS 2.5.3?

the change is rather big, and complicated. we will not be able to port it to 2.5 at the time being.

@sheetalkamat Do you expect the fix for this to be in by the first 2.6 insiders? Please let us know as soon you there is a build or branch that we can help test

it should be in typescript@next today, it should be in @2.6.0 and the first @2.6.1-insiders build

It will be helpful if you can give typescript@next a try.

@mhegazy Yes this seems fixed to me when using typescript@next. Will get some other vscode team members to test this to confirm


Undeclared subroutines fill and wrap

The subroutines fill and wrap are used in the 20-sane.t tests, however they are undefined:
t/20-sane.t .. ===SORRY!=== Error while compiling perl6-Text-Tabs/t/20-sane.t
Undeclared routines:
    fill used at line 12
    wrap used at line 11

They were removed in 05397a14e5e5c1c0a0a8623b5fe4e7e285af05aa, and it looks like the test suite hasn't passed since then.  Unfortunately, I don't have a fix, however I thought you'd like to know about the problem.

Oh, thanks for your noticing!
Travis wasn't set up for this package and it was in a somewhat unstable state, since Text::Wrap was implemented in another package before I finished it(not a bit issue, anyway).
I'll remove this calls and set up travis tomorrow or so. It's a pity that I didn't have much free time to maintain my packages and some dust was gathered

Actually, I was in the process of setting up Travis and noticed the test failures and thought I'd let you know before submitting the next patch: a Travis config :-)  If you want, I can still submit the Travis config patch; just let me know.

Yeah, it will be just great. I'll just add logo into the readme then. :+1:

Here 'tis :-)

Thanks for your attention, fixed!


[Feature request] Nova support

It would be great implementing a support for Laravel Nova.

Can you elaborate I've never used Nova, what support are you looking for?

like creating resources for nova
Like this commands:
php artisan nova:dashboard UserInsights
php artisan nova:card acme/analytics

no, I think support for third-party packages would better come from dedicated packages that can be installed for anyone who uses those packages.


Improve appcache-features.html

Some of the offline restart coding patterns aren't intuitive.

Closed via https://github.com/Esri/offline-editor-js/commit/04e0208d5000bc6c1fa244b372a48ed6e9bc28a1


Exception handling in .map, .flatMap and other operations

Should Kefir.Stream emit a error in case of thrown exception in .map()?
For example, the following code will fail with an uncaught exception:
function f(x) {
  if (x % 2 === 0) {
    throw Error();
  } else {
    return x;
  }
}
const stream = Kefir.sequentially(1000, [1, 2, 3]);
const mapped = stream.map(f);
mapped.log();

There is a non-obvious way to prevent this by wrapping map callback into try-catch inside flatMap:
function f(x) {
  if (x % 2 === 0) {
    throw Error();
  } else {
    return x;
  }
}
const stream = Kefir.sequentially(1000, [1, 2, 3]);
const mapped = stream.flatMap(function (value) {
  try { return Kefir.constant(f(value)); }
  catch (error) { return Kefir.constantError(error); }
});
mapped.log();

I'm personally strongly against automatic exceptions catching in async abstractions.
We should distinguish two types of errors and handle them separately. First type is bugs — when something completely unexpected happens in the program, when we get "foo is not a function" while it supposed to always be a function. Second type is expected errors that we must handle — errors we know may happen depending on user input, network condition etc.
The problem with automatic exceptions catching is that both types go into same handlers. This causes several issues like:

Handlers have to be either smarter and try to handle any error in a way that user always see correct program behavior (some errors need to be shown in a form, some should redirect user to another page, some should show a popup, etc.), or handlers can be very dumb (like always show a popup). The first option (being smarter) is way harder when we can get anything as a error in the handler.
We have to add error handlers to every stream, otherwise exceptions will be just swallowed which is the worse scenario.
Also we can't actually write code that handles bugs in a correct way. It's impossible. After a bug occurred we have no idea what have happened, we can't write a code that moves program from any random inconsistent state to a consistent one. The only way we can transition program to a consistent state after a bug is to restart it. Any code that tries to handle bugs makes it only worse, it makes bugs harder to debug and fix, it may result in turning database into inconsistent state as well, etc. IMO a better approach is to setup a reporting system (Sentry etc.) and to not try to handle bugs at all, just let program crash.

I agree with you about "the right" way to handle errors in theory. It is successfully implemented and used in several functional languages and even imperative ones like Rust.

For JS and some other languages (e.g. C#, Scala, ...) exceptions broadly used not only for "bugs" like TypeError but also for failed requests, invalid user input, etc.
Let me address the issues:

In practice, the most important about exceptions is not to catch them but to maintain the correct state. In current implementation it is very tedious to protect yourself against random exception on failed request added in a new version of some library.

It could be done without swallowing exceptions by logging them to console if there is no registered error handler. For example, default Promise implementation behaves this way.

See 1. At least, with exception handling there will be a way to write code to maintain consistent state. Currently it is almost impossible without manually adding try-catch in a flatMap for every projection operation.

Also, the current behavior is very different from almost any other "observable" (e.g. Rx) or "future" (.NET's Task, Scala's Future, etc) implementation which could be surprising for many users.

At least, with exception handling there will be a way to write code to maintain consistent state.

I believe that it's impossible to maintain consistent state after a random unexpected exception. And also that putting random exceptions into failure path of Observable ruins "Railway oriented programming" use case.
I summarized all my thoughts in an article recently: https://github.com/rpominov/fun-task/blob/master/docs/exceptions.md

the current behavior is very different from almost any other "observable" (e.g. Rx)

I'm trying to convince people that it's wrong there as well: https://github.com/tc39/proposal-observable/issues/104

And also that putting random exceptions into failure path of Observable ruins "Railway oriented programming" use case.

Does it? Any exception will be propagated to parent observable, you could still apply projection and join them.

I summarized all my thoughts in an article recently: https://github.com/rpominov/fun-task/blob/master/docs/exceptions.md

Some of the points there are not applicable anymore (exceptions never swallowed by Promise unless explicitly handled by .catch()), some others support my point. For the ideal world where JS is a purely functional language without exceptions you totally right, but it is better to have consistency with existing and future APIs.

I'm trying to convince people that it's wrong there as well: tc39/proposal-observable#104

They seem to have the same thoughts as me: inconsistencies with other implementations.

Does it? Any exception will be propagated to parent observable, you could still apply projection and join them.

Yeah. The problem is that it is harder to write sane code when both expected failures and random exceptions go into the same callback.
It is basically the same situation as if if statement worked like that:
if (expression()) {
  // the `true` case goes here
} else {
  // the `false` case goes here
  // but also any error thrown from expression() goes here
}

For the ideal world where JS is a purely functional language without exceptions

I don't actually thing that exceptions itself are bad in an impure language like JS. I think they are quite good for debugging. I just think that we should not: 1) catch them randomly 2) put them into the same callback that is intended for expected failures path. First ruins debugging experience because even to re-throw isn't the same thing than not catch in first place from debugging point of view. Second ruins railway use case (see continuation of if example here where I show how hard it would be to use if statement if it worked like this)

Yeah. The problem is that it is harder to write sane code when both expected failures and random exceptions go into the same callback.
It is basically the same situation as if if statement worked like that:

You seem to imply that two types of exceptions is different enough to distinguish them when catching.
In practice, you almost never care about catching exceptions, because you use try-finally equivalent instead and only catch errors at the top.

put them into the same callback that is intended for expected failures path

I would say that in many cases bug is a failure too. For UI applications it is common to show "generic error dialog" or something like that even in case of bug, because it is still better than having unresponsive UI.

First ruins debugging experience because even to re-throw isn't the same thing than not catch in first place from debugging point of view

Why rethrow is different from not catching? It should preserve stack trace.

You seem to imply that two types of exceptions is different enough to distinguish them when catching.

We probably have in mind different examples. I think they are very different.

Why rethrow is different from not catching? It should preserve stack trace.

Debugger won't pause on the original throw line for instance. But it's hard to even rethrow (see second part of if example).

Hi, I agree with you @rpominov , but I would like to know a way to manually pipe exceptions into the current stream, to be able to handle them with stream.onError. Is that possible ?
Thanks

Could you tell more about your use case, @niahoo?

Sure. I'm building a small game with an immutable state. The whole world is updated in a .scan() that receive functions and apply them to its state.
After the .scan there is a .onValue call where I pass the state to a react View.
I would like to be able to update this view (or another view) in .onError. To do so, I would like to be able to catch exceptions and direct them to the error stream.

I'm afraid there is no good way to catch in scan if you want to then redirect error to Kefir's error path. This would be possible with map, you could use flatMap instead:
stream.flatMap(x => {
 try {
   return Kefir.constant(unsafe(x))
 } catch(e) {
   return Kefir.constantError(e)
 }
})

Still in scan you can catch and put errors into main Kefir's path.

edit: I think I miss the point of errors in Kefir. I'll just send my errors as values to a stream of UI events to notify them to the player.

They basically model built-in Either.

Well, in scan I must return a state, so I can't return the exception. But I send it to another stream using the emitter.
Thanks for the docs. btw the "How exceptions catching work in Task" link on fun-task home README is dead !

I mean your state could be {data: ..., error: ...} for example.
stream.scan((state, fn) => {
  try {
    return {data: fn(state.data), error: null}
  } catch (e) {
    return {data: state.data, error: e}
  }
}, {data: initialData, error: null})

You can even put errors in the errors path then:
stream.scan(...).flatMap(state => state.error ? Kefir.constantError(state.error) : Kefir.constant(state.data))

Thanks for the warning about the links!

Ok, thank you, it works great :)

Since this is foundational to the way Kefir was designed, this is unlikely to change, so I'm going to close this issue.


The microtime plugin

Can you please be more explicit about how to use the microtime plugin?
I've found in this page no information but how to clean the stack

If you just dump microtime it will work (EG: Kint::dump(microtime()); d(microtime());) I'll clarify the text

Wow, nice and fast.
Though I need more setup. Spend like an hour reading the code. Thanks

Fixed in dd749030a1275bb48b4b5f43e28a8e30e6f1ef91


Generate documentation

For now the library can only be used by me or anyone who has the nerves to have a look at the source code.
It would be cool if a documentation could be generated automatically and e.g. published on GitHub Pages.
For that I need a tool that is capable of transforming F# comments into HTML and a way to host that docu website. (Have a look at GitHub Pages)

One example of a working setup can be found here:
https://github.com/fsprojects/FSharpLint/blob/master/build.fsx

I want to use something like Waypoint (https://github.com/ionide/Waypoint), which brings documentation generation via Fornax with it as far as I see it.

Done in 10 commits starting with 59517299ab32dd20802c02d7f111460a6d822033 and ending with 4de9d862986a82a70b654bdafbe9f6dda698975b


fix: Reference to @wix/lerna-check-working-tree

 ⛔  Status: Failed :(

 :stopwatch: Run time: 0.3 min
 🏷  Commit: f5def1d
 Full Report
 Deploy Previews
 View Tests

Your yarn.lock is out of date, please run midgard-yarn locally and push the changes. If this is a PR, you might need to merge with the base branch first.


Multiple formatters for python files should be a warning/info not an error?

Testing microsoft/vscode-python#19885
I noticed this:

Doesn't seem like a big deal, would it be more appropriate as a warning or info?

Doesn't seem like a big deal, would it be more appropriate as a warning or info?

No strong feelings but it does mean that format on save isn't working. We can geek out and make it an error when format on save is configured and info otherwise


Wrong reference

Wrong reference.
In section "Can I make guest users visible in the Exchange Global Address List?" the answer refers under "...See Can I make guest objects visible in the global address list?" but the link redirect us to a page that is not related to the topic.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 234804b8-f87e-6e42-3589-336b308c564f
Version Independent ID: d6eca215-d352-50b0-994e-0077a5e54fe6
Content: B2B collaboration FAQs - Azure Active Directory
Content Source: articles/active-directory/external-identities/faq.yml
Service: active-directory
Sub-service: b2b
GitHub Login: @msmimart
Microsoft Alias: mimart

@andneto2301
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.


Release Toolium 1.4.2

Coverage increased (+0.2%) to 90.289% when pulling 3d3b06bf480634c5ca938faf53389a766655b851 on release/1.4.2 into fc6e233866deead7f3cb4f2e43e5fdf01a7fb319 on master.


Android Test

Hi ,
i want to ask selenoid android :
I have linux machine:
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.2 LTS
Release:        22.04
Codename:       jammy
Linux 5.15.0-25-generic
when i start maven test ,  i got this logs :
This error : browserTest(com.aerokube.selenoid.AndroidDemoTest): wait: http://<IP_ADDRESS>:4444/wd/hub does not respond in 30s(..)
Logs in container which created ( android 10.0) :
root@vmi1303393:~# docker logs 4b6fa3118ff8
Waiting X server...
Waiting X server...
Logging to: /tmp/fluxbox.log
Waiting X server...
Waiting X server...

daemon not running; starting now at tcp:5037

--- x11vnc loop: 1 ---

daemon started successfully
adb: no devices/emulators found
emulator: autoconfig: -kernel /opt/android-sdk-linux/system-images/android-29/default/x86//kernel-ranchu-64
emulator: Target arch = 'x86'
emulator: Auto-config: -qemu -cpu qemu32
emulator: Auto-detect: Kernel image requires new device naming scheme.
emulator: Auto-detect: Kernel does not support YAFFS2 partitions.
emulator: autoconfig: -ramdisk /opt/android-sdk-linux/system-images/android-29/default/x86//ramdisk.img
emulator: Using initial system image: /opt/android-sdk-linux/system-images/android-29/default/x86//system.img
emulator: Using initial vendor image: /opt/android-sdk-linux/system-images/android-29/default/x86//vendor.img
emulator: autoconfig: -data /root/.android/avd/android10.0-1.avd/userdata-qemu.img
emulator: autoconfig: -initdata /root/.android/avd/android10.0-1.avd/userdata.img
emulator: autoconfig: -cache /root/.android/avd/android10.0-1.avd/cache.img
emulator: Increasing RAM size to 2048MB
emulator: VM heap size 0MB is below hardware specified minimum of 512MB,setting it to that value
emulator: WARNING: System image is writable
emulator: Found 2 DNS servers: <IP_ADDRESS> <IP_ADDRESS>
emulator: there is no '1080x1920' skin in '/opt/android-sdk-linux/platforms/android-29/skins/'
emulator: found magic skin width=1080 height=1920 bpp=16

emulator: registered 'boot-properties' qemud service
emulator: Adding boot property: 'qemu.cmdline' = 'androidboot.logcat=v:* androidboot.consolepipe=qemu_pipe,pipe:logcat'
emulator: Adding boot property: 'qemu.logcat' = 'start'
emulator: CPU Acceleration: DISABLED
emulator: CPU Acceleration status: KVM requires a CPU that supports vmx or svm
emulator: ERROR: x86 emulation currently requires hardware acceleration!
CPU acceleration status: KVM requires a CPU that supports vmx or svm
More info on configuring VM acceleration on Linux:
https://developer.android.com/studio/run/emulator-acceleration#vm-linux
General information on acceleration: https://developer.android.com/studio/run/emulator-acceleration.
--- x11vnc loop: waiting for: 87
PORT=5900
adb: no devices/emulators found
adb: no devices/emulators found
adb: no devices/emulators found
adb: no devices/emulators found
adb: no devices/emulators found
adb: no devices/emulators found
adb: no devices/emulators found
adb: no devices/emulators found
adb: no devices/emulators found
adb: no devices/emulators found

я запустил  также на локальном компьютере , где включена визуализация . но теже ошибки вылетают

Waiting X server...
Logging to: /tmp/fluxbox.log
Waiting X server...
emulator: autoconfig: -kernel /opt/android-sdk-linux/system-images/android-29/default/x86//kernel-ranchu-64
emulator: Target arch = 'x86'
emulator: Auto-config: -qemu -cpu qemu32
emulator: Auto-detect: Kernel image requires new device naming scheme.
emulator: Auto-detect: Kernel does not support YAFFS2 partitions.
emulator: autoconfig: -ramdisk /opt/android-sdk-linux/system-images/android-29/default/x86//ramdisk.img
emulator: Using initial system image: /opt/android-sdk-linux/system-images/android-29/default/x86//system.img
emulator: Using initial vendor image: /opt/android-sdk-linux/system-images/android-29/default/x86//vendor.img
emulator: autoconfig: -data /root/.android/avd/android10.0-1.avd/userdata-qemu.img
emulator: autoconfig: -initdata /root/.android/avd/android10.0-1.avd/userdata.img
emulator: autoconfig: -cache /root/.android/avd/android10.0-1.avd/cache.img
emulator: Increasing RAM size to 2048MB
emulator: VM heap size 0MB is below hardware specified minimum of 512MB,setting it to that value
emulator: WARNING: System image is writable
emulator: Found 1 DNS servers: <IP_ADDRESS>
emulator: there is no '1080x1920' skin in '/opt/android-sdk-linux/platforms/android-29/skins/'
emulator: found magic skin width=1080 height=1920 bpp=16
emulator: registered 'boot-properties' qemud service
emulator: Adding boot property: 'qemu.cmdline' = 'androidboot.logcat=v:* androidboot.consolepipe=qemu_pipe,pipe:logcat'
emulator: Adding boot property: 'qemu.logcat' = 'start'
emulator: CPU Acceleration: DISABLED
emulator: CPU Acceleration status: KVM requires a CPU that supports vmx or svm
emulator: ERROR: x86 emulation currently requires hardware acceleration!
CPU acceleration status: KVM requires a CPU that supports vmx or svm
More info on configuring VM acceleration on Linux:
https://developer.android.com/studio/run/emulator-acceleration#vm-linux
General information on acceleration: https://developer.android.com/studio/run/emulator-acceleration.
PORT=5900

daemon not running; starting now at tcp:5037

--- x11vnc loop: 1 ---

daemon started successfully
adb: no devices/emulators found
--- x11vnc loop: waiting for: 87

adb: no devices/emulators found
adb: no devices/emulators found
adb: no devices/emulators found

@KpoJIuk06 need to increase -session-attempt-timeout flag to 2 minutes. Android sessions approximately starts in 30-40 seconds, this is why you get timeout.

@vania-pooh  i added from json and also try and added in code setCapability. It always 30 seconds respond

@KpoJIuk06 session attempt timeout is a command-line flag, not a capability. https://aerokube.com/selenoid/latest/#_selenoid_cli_flags

Same problem if i add flag in command browserTest(com.aerokube.selenoid.AndroidDemoTest): wait: http://<IP_ADDRESS>:4444/wd/hub does not respond in 30s(..)  :
@Before
public void openDriver() throws Exception {
final DesiredCapabilities device = new DesiredCapabilities();
device.setCapability("browserName", "android");
device.setCapability("version", "10.0");
device.setCapability("app", "F:\demo-tests-master\src\test\resources\test.apk");
device.setCapability("appPackage", "uz.pdp.calculator2");
device.setCapability("appActivity", "com.example.calculator2.MainActivity");
    driver = new RemoteWebDriver(new URL(
            "http://<IP_ADDRESS>:4444/wd/hub"
    ), device);
}

Docker commands :
docker run -d -v /var/run/docker.sock:/var/run/docker.sock -v "C:/Users/Users/Documents/selenoid_Android/":/etc/selenoid/:ro -v  "C:/Users/Users/Documents/selenoid_Android/logs/":/opt/selenoid/logs/ -v /opt/selenoid/video/:/opt/selenoid/video/ -e OVERRIDE_VIDEO_OUTPUT_DIR="/opt/selenoid/video/" -p 4444:4444 --name selenoid aerokube/selenoid:1.10.7 -log-output-dir /opt/selenoid/logs -session-attempt-timeout 2m
docker run -d ^
--name selenoid-ui ^
-p 8080:8080 ^
--link selenoid:selenoid ^
aerokube/selenoid-ui:1.10.4 ^
--selenoid-uri "http://selenoid:4444"
Browser.json :
{
"android": {
"default": "10.0",
"versions": {
"10.0": {
"image": "selenoid/android:10.0",
"sessionTimeout": "1m",
"sessionAttemptTimeout": "2m",
"env": [
"VERBOSE=true",
"APPIUM_ARGS=--log-level debug"
],
"port": "4444",
"path": "/wd/hub"
}
}
},
"chrome": {
"default": "111.0",
"versions": {
"111.0": {
"image": "selenoid/chrome:111.0",
"port": "4444",
"path": "/",
"tmpfs": {
"/tmp": "size=128m"
}
}
}
}
}

@KpoJIuk06 forgot about one more flag. Should be: -service-startup-timeout 2m -session-attempt-timeout 2m.

Thanks now timeout browserTest(com.aerokube.selenoid.AndroidDemoTest): wait: http://<IP_ADDRESS>:4444/wd/hub does not respond in 2m0s(..)
but also had problem with emulator
Maybe need to config somewhere ?
Log Android Container when start by code
Waiting X server...
Logging to: /tmp/fluxbox.log
Waiting X server...
emulator: autoconfig: -kernel /opt/android-sdk-linux/system-images/android-29/default/x86//kernel-ranchu-64
emulator: Target arch = 'x86'
emulator: Auto-config: -qemu -cpu qemu32
emulator: Auto-detect: Kernel image requires new device naming scheme.
emulator: Auto-detect: Kernel does not support YAFFS2 partitions.
emulator: autoconfig: -ramdisk /opt/android-sdk-linux/system-images/android-29/default/x86//ramdisk.img
emulator: Using initial system image: /opt/android-sdk-linux/system-images/android-29/default/x86//system.img
emulator: Using initial vendor image: /opt/android-sdk-linux/system-images/android-29/default/x86//vendor.img
emulator: autoconfig: -data /root/.android/avd/android10.0-1.avd/userdata-qemu.img
emulator: autoconfig: -initdata /root/.android/avd/android10.0-1.avd/userdata.img
emulator: autoconfig: -cache /root/.android/avd/android10.0-1.avd/cache.img
emulator: Increasing RAM size to 2048MB
emulator: VM heap size 0MB is below hardware specified minimum of 512MB,setting it to that value
emulator: WARNING: System image is writable
emulator: Found 1 DNS servers: <IP_ADDRESS>
emulator: there is no '1080x1920' skin in '/opt/android-sdk-linux/platforms/android-29/skins/'
emulator: found magic skin width=1080 height=1920 bpp=16
emulator: registered 'boot-properties' qemud service
emulator: Adding boot property: 'qemu.cmdline' = 'androidboot.logcat=v:* androidboot.consolepipe=qemu_pipe,pipe:logcat'
emulator: Adding boot property: 'qemu.logcat' = 'start'
emulator: CPU Acceleration: DISABLED
emulator: CPU Acceleration status: KVM requires a CPU that supports vmx or svm
emulator: ERROR: x86 emulation currently requires hardware acceleration!
CPU acceleration status: KVM requires a CPU that supports vmx or svm
More info on configuring VM acceleration on Linux:
https://developer.android.com/studio/run/emulator-acceleration#vm-linux
General information on acceleration: https://developer.android.com/studio/run/emulator-acceleration.
PORT=5900

daemon not running; starting now at tcp:5037

--- x11vnc loop: 1 ---

daemon started successfully
adb: no devices/emulators found
--- x11vnc loop: waiting for: 87

adb: no devices/emulators found
adb: no devices/emulators found

@KpoJIuk06 Android images require virtualization support in CPU and will only work on Linux hardware server. It will not work on Linux VMs.

Thanks for the info. It turns out that the use of selenoid, only for manual tests for android, no pipelines and gits.


GH2715: Add missing dotnet nuget command options

Fixes #2715.

@gitfool your changes have been merged, thanks for your contribution 👍


New logo/icon

Hi, I am a graphic designer, I want to help others in graphic design.
After I reviewed your project, you have no logo on this project. Therefore I want to contribute to this project by creating a new logo / icon. what do you think?

That'd be very cool.  Thank you very much for the offer.

sorry for late. I have design a logo for this project. what do you think ? do you like it ?

Thanks for doing that!  In order to keep it more in line with Material design guidelines, I took your basic idea and updated per design guidelines:

Thanks again


Bluetooth

In home if anything we can do economy and tivi and Lion only bluetooth

I'm sorry but I am still not sure as to what you are asking. I feel like there is too much of a language barrier here. I really do want to help, but it is nearly impossible without understanding what you are asking. Maybe try wording it differently?

@ellapham85 If you have problems writing in English, ask around, there may be someone who can help you translate.


[Paladin] Automating ideals calculation + squire skills default value

All three ideals for knights (Romance, chivalry, religion) consist in adding up the values of six relevant personality traits.
Rather than doing it manually, I propose this change to automate the calculations and thus making it easier/faster for players.
Current version (in French)

Proposed change

Also, adding 0 as default value to all 4 squire basic skills

Character Sheet Info Roll20 Internal Use only.

Hey @Greyblade
Definitely see the appeal of this change - I'm not too familiar with the game though, so wanted to double check one quick thing before I merge this.  Is there any way that these three values would wind up being different than their derived calculated sums, even temporarily?
Reason I ask is that, ofc, automating these fields and turning the inputs to spans will lose player data for anyone who has input totals that break the rules.  If that's not reasonably possible within the limits of the system, then it's not an issue.  Otherwise, you might want to consider implementing an optional setting to auto-calculate these fields, that can be disabled to restore the manual inputs.
Thanks!

Hi @BronsonHall , thanks for your comment.
You add up the values to tally 90 points in each, and you also need another independent value (ex : honor at 16+) to qualify for the bonus.
So it's always 90+ with those 6 specific traits for each ideal that you need :)
Hope this clarifies the rules :)

Ah!  I see now, thanks for clarifying.  Sound reasoning, I'll merge this in!


Changes for ClrMD 2.1

ClrMD 2.1 initial changes
Please read docs/Migrating21.md.
Mark PEImage and Elf* as internal
ClrMD is getting out of the business of file format reading. :)
While it's useful to have a bunch of file reading abilities hanging around, there are simply better libraries for reading PE, Elf, and Mach-O images.
The intent here is still read images enough to perform ClrMD's operations, but we will:

Drop our dependency on System.Reflection.Runtime (unfortunately it doesn't react well when there's missing chunks of PE files and it's causing problems with Single File executables).
Mark all file readers as internal and slim them down to just what ClrMD needs.
Provide a new way to open Stream objects for files loaded into memory. These Streams will be formatted as if they were files on disk (not mapped into memory), meaning you can pass these files off to libraries like System.Reflection.Metadata or Marklio.Metadata and get fully featured file format readers without relying on ClrMD's buggy implementation.

In effect, you may have to pick up a new dependency, but the end result will be better than where we are today.
Rework Symbol Server API implementation
ClrMD's symbol server code had several issues which are now fixed:

We could not locate non-pe images correctly.  (Meaning OS X and Linux diagnostics were busted unless you were on a machine with the installed runtime).
We over-requested file locations that will never be filled.  E.G. requesting file.ptr will not be filled on most symbol servers.
We (should) now properly handle symsrv* symbol paths, as well as fully implementing the sympath syntax.

Rework ClrInfo creation
While this is mostly an internal change, greatly clean up how we locate CLR runtimes in the process.
Rework ModuleInfo
ModuleInfo is now an abstract base class with implementations for Elf, Mach-O and PE images implementing various functionality.  This really cleaned up an ugly wart in creating ModuleInfo objects while eliminating some unneeded interfaces.  Additionally we provide a way to get resources and exports from ModuleInfo now.
Rework DAC library info
We no longer provide just a single ClrInfo.DacLibrary but instead enumerate all known debugging libraries for the given runtime with ClrInfo.DebuggingLibraries.  This will provide all dac and dbi libraries and index properties.

Marking ElfFile internal is really going to break SOS!  I use it to lookup exports (ElfFile.TryGetExportSymbol). The symstore ELF reader doesn't have the symbol lookup support or otherwise, I'd use that.

Don't pick up the change just yet.  I was also going to send you an email first thing monday.  =)
Let me dig through the SOS code on Monday and see what needs to be there.  I didn't realize you took a direct dependency on it, so if this disrupts things too much I'm happy to either add it back or modify SOS to work better with the new system.  I'm not trying to put more work on you here with these changes.  =)
If you are only using this for export symbols, note that we actually now expose symbol reading directly through ModuleInfo.GetSymbolAddress in https://github.com/microsoft/clrmd/blob/master/src/Microsoft.Diagnostics.Runtime/src/Common/ModuleInfo.cs#L57.  There's also a similar function for reading resources of modules to get things like the CLRDEBUGGINGINFO resource (though I'm not sure I'm happy with the design of that resource function).

Also note I also plan to make creating ModuleInfo from a stream or base address possible through ClrMD, so even if you don't have the right ModuleInfo laying around it will be possible to construct one.  This is not currently in the main codebase yet, mostly because the changeset was getting too big and I like to check in with smaller, more manageable PRs.
SOS is unique in that you are connected to my main branch builds, so I would expect the firehose of changes to be broken for SOS for a couple of days, but the end goal here is to get to a place where these commonly needed functions are exposed to you through more sensible APIs (like ModuleInfo) instead of having a direct line to the implementation detail (like ElfFile).
Fundamentally, I plan to rewrite a lot of the elf reading code in ClrMD next to slim it down and optimize it for when we are missing data in a dump.  Also, PEImage and Elf* will go request their underlying files from the symbol store when it fails a read.  These are very difficult to do with the current implementation.  So even if we end up exposing Elf* as public again, I'll still need to make some SOS tweaks when I change the surface area of those implementations.
Let's sync up on Monday to make sure I'm headed in the right direction.

The direct DARC dependency allows for more immediate fixes in the diagnostics repo from clrmd, but this is the downside. Technically there should be a 2.0 branch/build/DARC subscription that we could subscribe, but that is some work.
I did find GetSymbolAddress()  The new ModuleInfo is better.  Using System.Version is better. I haven't looked at the ClrInfo changes yet, but it shouldn't take me that long to do them. I'd rather be the one to make them.

Sounds good, let me know if you run into trouble or have questions.

Also, the new ClrInfo.DebuggingLibraries now contains the DBI archive info.  Instead of relying on the properties of the old DacInfo or other module properties, you can simply find DBIs enumerated there for !clrstack's ICorDebug implementation.


Memory issues with the tool

Hi there,
I am trying to use your tool for variant calling. I have 260x coverage of Nanopore data for a 680MB genome. The genome has been polished multiple times and haplotigs have been purged. Whenever I run the tool it runs for about 2 days and then gives an out of memory error. This usually happens after all variants have been called. I have tried running on servers with 450GB memory up to 780GB memory and 28 cores and the tool still dies out. I am new to bioinformatic analyses, so I would like assistance with this. Thank you.
Here is the command I ran:
longshot --bam Second_aligned.bam --ref /projects/Second_purge.fa --out longshot_output.vcf
Regards,
Mondli

Can you try running on a single contig/chromosome to see if the same issue occurs? There is a command line option to specifiy a region. Thanks.

Hi, thank you for your response. I tried using a subsample of my data to about 80x coverage and the tool was able to run til it finished. Thank you.


respondChannelInvite success, but not becoming member

Version
"@neynar/nodejs-sdk": "^1.58.0"

I am trying to accept a channel invite, but it is not working.
I get invites for our user's FID
  export const getIntoriChannelInvites = async (): Promise<ChannelInviteType[]> => {
    try {
      const res = await warpcastApi.get(
        '/fc/channel-invites',
        {
          params: {
            fid: process.env.INTORI_USER_FID
          }
        }
      )

      return res.data?.result?.invites ?? []
    } catch (err) {
      console.error('Warpcast API error:', err)
      return []
    }
  }

I am seeing a valid channel invite:

respond to the invite, returns success and no message
  export const acceptChannelInvite = async (params: {
    channelId: string
    role: 'moderator' | 'member'
  }) => {
    console.log('Accepting channel invite', params)
    return neynar.respondChannelInvite(
      process.env.NEYNAR_SIGNER_UUID ?? 'missing signer uuid',
      params.channelId,
      params.role,
      true
    )
  }

Response:

Invite goes away, but this user never becomes a member. Even after waiting 1+ hour

@zacharytyhacz Is the invited member following the channel they are being invited to?

Yes, the user is following the channel.

@zacharytyhacz thanks for the detailed ticket. As discussed on the call, the same process worked well when trying it again today. Seems like it could've been a transient bug, we'll reopen this ticket if it happens again.


e2e-pool: minor fixes

(Cosmetic) Move the creation of ClusterDeploymentCustomization for the real pool out of the fake pool section.
Fix a logic bug where we were redundantly hibernating a cluster in the fake pool while it was still in the pool and thus already hibernating. Now we claim a cluster, validate that it's Running by the time the claim is fulfilled, then hibernate it.
Also add resuming the above.
Also add deleting the claim and verifying that the claimed CD gets deleted.

/assign @lleshchi
/cc @abraverm

/retest
e2e was a plain ol flake.
e2e-pool looks like a (latent, unrelated) timing problem here:
# Modify the clusterpool and watch CDs get replaced
oc patch clusterpool $FAKE_POOL_NAME --type=merge -p '{"spec":{"imageSetRef": {"name": "fake-cis"}}}'
expect_all_clusters_current $FAKE_POOL_NAME False
oc wait --for=condition=AllClustersCurrent --timeout=10m clusterpool/$FAKE_POOL_NAME

I surmise that expect_all_clusters_current picked up the state from right before the patch update was acked by the controller. If we see this again, perhaps we want to try something more like:
# Modify the clusterpool and watch CDs get replaced
oc patch clusterpool $FAKE_POOL_NAME --type=merge -p '{"spec":{"imageSetRef": {"name": "fake-cis"}}}'
oc wait --for=condition=AllClustersCurrent=false --timeout=1m clusterpool/$FAKE_POOL_NAME
oc wait --for=condition=AllClustersCurrent --timeout=10m clusterpool/$FAKE_POOL_NAME

Same again. Must have changed the timing just enough. Let’s try the plan above.
But just out of curiosity…
/test e2e-pool

Same again. Must have changed the timing just enough. Let’s try the plan above.

Nope. I introduced a bug by doing this:

(Cosmetic) Move the creation of ClusterDeploymentCustomization for the real pool out of the fake pool section.

It resulted in the fake pool getting the same inventory as the real pool, leading to thrashing and things never becoming ready. Reverted.

...but

the plan above.

is good anyway, so I'm gonna keep it.


docs: Add CITATION.cff file for citation metadata

Add CITATION.cff to provide machine and human readable citation metadata.

Remove .zenodo.json metadata file as reundant to CITATION.cff as Zenodo will recognize and read CITATION.cff and CITATION.cff provides more functionality.

@dguest this is ready for review. To preview this if you open my fork on the PR branch then you'll get the "Cite this repository" button on the right hand side of GitHub's UI.


feat(connect-wallet): support custom chains in WalletConnect

Problem solved
Short description of the bug fixed or feature added
Changes made

[ ] Public API changes: list the public API changes made if any
[ ] Internal API changes: explain the internal logic changes

How to test

[ ] Automated tests: link to unit test file
[ ] Manual tests: step by step instructions on how to test

Contributor NFT
Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.
Address:

PR-Codex overview
This PR introduces custom chain support in WalletConnect sessions.
Detailed summary

Added chains prop to WalletConnectReceiverScreen
Added chains prop to WalletConnectReceiverScreen dependencies
Added chains prop to createWalletConnectClient options
Updated createWalletConnectClient to handle chains
Updated onSessionProposal to handle chains
Updated acceptSessionProposal to handle chains

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#3372  👈
#3371
#3310
#3309
#3294
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on  Graphite


Version 4.0.0

Changes in this update
Added/improved functionality

Added proper support for controlling Apple displays.
Added option to show/hide brightness slider.
Added option to show brightness slider for internal display and apple displays (enabled by default).
Replication of built-in and Apple display brightness to corresponding brightness slider.
Added suffix to similarly named displays for better differentiation.
Option to disable slider snapping for finer control + disable slider snapping by default.
Added option to show slider tick marks for better accuracy.
Added option to use window focus instead of mouse to determine which display to control.
Ctrl+Command+Brightness now controls external displays only (Ctrl+Brightness continues to control internal display only)
Added separate tab for menu options.
Added option to restore last saved values upon startup.
Added option for audio device name matching for display volume control selection.
Separated option to change all screens for brightness and volume.
Added option for keyboard fine scale for brightness.
Added option for keyboard fine scale for volume.
Added version check upon startup for mandatory preferences reset upon downgrade or incompatible previous version + notification about this.
Added implementation for Command+F1 macOS shortcut to enable/disable mirroring.
Added safer 'Assume last saved settings are valid' option as default instead of startup DDC read (or restore).
Streamlined preference panes, 'Show advanced settings' now affect all tabs. This leads to a better and safer first timer experience (especially because of the influx of many new features).
Added a Quit button to Preferences if menu is hidden (it was not passible to quit the application until this time in this mode only by re-enabling the menu).
Lowered default first-run volume DDC default from 75% to 15% if read is not possible or disabled to prevent unexpectedly loud sound.
Added slider skew setting on a per control basis to have the ability to manipulate DDC slider balance and OSD scale if display control is not linear.
Added the ability to set min. and max. DDC bounds on a per display, per control basis.
Audio device name override option for a display (manually assign a specific audio device to a display).
Advanced setting to invert DDC control range (some displays have the scale reversed).
Advanced setting to remap DDC control code (some displays have contrast and brightness mixed up).
Ability to mark a DDC control as available or unavailable in advanced settings under Displays.
Ability to automatically hide menu icon if there is no slider present in the menu.
Option to show slider percentage for more precision.
Option to set combined or separate OSD scale when combined hardware+software brightness is used.
Apple like smooth brightness change (both for software, hardware, mixed and DisplayServices).
Added support for DisplayLink, AirPlay, Sidecar, screen sharing etc. using window shades (this is an inferior technique to the existing software implementation - gamma control - but still better than nothing). Disabled for any kind of mirroring setups. (Only on Big Sur and above)
Brightness change synchronisation from Built-In and Apple displays to other displays. This makes Touch Bar, Ambient light sensor, Control Center and System Preferences induced changes affect all displays. Synchronisation uses a sophisticated indirect delta method + the user can intervene and adjust individual screen brightness at any time to easily compensate mismatching native brightness levels.
Preferences pane tab selector has a simpler look on Catalina.
All menu sliders are now scrollable using a magic mouse/trackpad swipes or mouse wheel.
Added option for menu to show only items that are relevant to display which shows the menu currently.
Added option to enable combined sliders (note: this option combined with enabled Apple/built-in display syncing and enabled 'change all' keyboard settings finally provides full synchronised control of all displays).
Combined sliders can now display multiple displays when keyboard and brightness syncing is not enabled. (Only on Big Sur and above)
Redesigned sliders to look like Big Sur/Monterey Control Center's sliders. (Only on Big Sur and above)
Quit and Preferences... are now icons for a much cleaner look. (Only on Big Sur and above)
Added option to change additional menu options style or hide them.  (Only on Big Sur and above)
Added customisable gamma/ddc switchover point for combined brightness in the advanced section of Displays.
Added comma separated list for control code override to enable edge cases like controlling Brightness and Contrast at the same time (use VCP list entry 10, 12 for that)
Contrast can now be controlled from keyboard via control + option + command + brightness up/down.
Custom keyboard shortcuts for brightness, contrast, volume and mute
Check for update feature for automatic updates.

Other under the hood changes and bug fixes

Standardised internal scale among various displays and DDC ranges for ranged controls.
Uses the new internal scale for combined hardware-software brightness mode.
Migrated scales to internal float representation to prevent loss of fine detail on transformations.
Fixed double sound when muting multiple external displays at the same time.
Fixed lack of initial volume configuration if slider is not shown in menu.
Fixed wrong settings being applied to a display when replaced on Apple Silicon (UserDefaults preferences are now tied to specific display strings instead of CGDirectDisplayID - which is no longer semi-unique on arm64).
A lot of refactoring, streamlining and general optimisations.

Known Issues

N/A

I did try to link completed issues to this pull request for completeness' sake but there is a limit of 10 it seems. :)

I added back localizations and sifted through texts that maybe had the same identifier but changed meaning so they are reset to English to avoid confusion.

I did try to link completed issues to this pull request for completeness' sake but there is a limit of 10 it seems. :)

Usually, you can link/auto-close by adding
"closes" or "fixes" #
For example:
closes #5
Perhaps that way more can be linked, though it doesn't really matter imo

Usually, you can link/auto-close by adding the following in the description: "closes" or "fixes" #

I did not know that. :)

Fyi, I'm working my way through it, everything is just very slow because of the insane amount of changes LOL

Fyi, I'm working my way through it, everything is just very slow because of the insane amount of changes LOL

Ok, no need to rush! :) Thanks for reviewing it properly!

Absolutely amazing work once again!
A lot of stuff got refactored and is a lot cleaner now compared to last release, which is great!
I also did some profiling for memory leaks, and found none :)
For custom shortcuts, I was personally thinking of having a toggle "Use media keys" besides having custom shortcuts (so users can define both if they want to). Not sure what you think about that?
I'll try to get to setting up the Sparkle/Apple account stuff tomorrow. Sparkle is going to be an amazing thing to finally have! One thing I didn't seem to be able to find was a preference for "Check for updates automatically"?

Yes, you are right, there should be a setting for check updates automatically. I just made it non-optional but it is too intrusive this way.

For custom shortcuts, I was personally thinking of having a toggle "Use media keys" besides having custom shortcuts (so users can define both if they want to). Not sure what you think about that?

That would make sense. I made it this way to simplify things a bit so I don't have to deal with situations when the two things might run in parallel (when conflicting shortcut key styles are in repeat mode at the same time) as two totally separate parts of the app handle these things. But it would probably not be too difficult to make them aware of each other and one should cancel the repeat streak of the other (although keyrepeat is handled at a deeper level in MediaTapKey over which MonitorControl probably has no direct control - or probably there is no need for keyrepeat simulation with media keys, I don't know.) Btw, there is now a slight disconnect as MediaTapKey's keyrepeat does not seem to honor the keyRepeat interval settings of the OS (set in System Preferences) while the thing I did with KeyboardShortcuts does honor it so control using the two methods work at different speeds - but this is a rather marginal issue I don't think anybody will ever complain about this..

Oh boy these signing commits are not optimal. :) I think there is a way to move signing info to a different config file and add it to .gitignore.

I think you should be able to override the signing setting in the CI workflow. That might help resolve the issue?

I think you should be able to override the signing setting in the CI workflow. That might help resolve the issue?

Where can I do that? :)

.github > workflows > main.yml we're using a custom action that simplifies the build command, but if I remember correctly, there should be an option to override signing settings. Just copy the name into GitHub search to get to the workflow action GitHub repo (and thus docs).

I'd do it myself but I'm on mobile right now so 😅 can do it tomorrow though if you can't find it.

.github > workflows > main.yml we're using a custom action that simplifies the build command, but if I remember correctly, there should be an option to override signing settings. Just copy the name into GitHub search to get to the workflow action GitHub repo (and thus docs).

At a quick glance I did not find the setting at https://github.com/sersoft-gmbh/xcodebuild-action but tomorrow I'll look into it more. Also

I'll change keyrepeat speeds for the KeyboardShortcuts as it turns out MediaKeyTap is doing it at the right speed (or probably media keys do keyrepeat by nature so MediaKeyTap do not have to intervene while with custom shortcuts I need to simulate it) as it seems to be intentionally faster than normal keys as a normal behaviors.
I'll add the option in Preferences about automatically check updates for Sparkle.

Sounds good, what might help find the option is to look at what the default build command looks like, here's one for iOS on my other repo:
https://github.com/JoniVR/VerticalCardSwiper/blob/master/.github/workflows/main.yml

Well it seems simply setting
      - name: xcodebuild
        uses<EMAIL_ADDRESS>        with:
          project: MonitorControl.xcodeproj
          scheme: MonitorControl
          destination: platform=macOS
          action: build
          build-settings: CODE_SIGN_IDENTITY="-" DEVELOPMENT_TEAM=""

Does not work due to the following:

Adding CODE_SIGNING_REQUIRED=NO doesn't help either. Probably I should go deeper into this but I'll just leave it as it is, if I manually remove signing info from the main project (which essentially changes to CODE_SIGN_IDENTITY="-" DEVELOPMENT_TEAM="" for the main project) then xcodebuild does not fail.

Hey @JoniVR
as requested, I added the following:

Option to enable both media keys and custom shortcuts (+ tweaked keyrepeat times a bit)
Option to enable/disable automatic check for updates

I think with this all review issues should be fixed.
Thanks!

Nice one!
I've got more feedback (on build 6171 on M1).
Keyboard controls for Brightness and Contrast are awesome! Brightness looks great and works great, just like my MacBook Air's internal display. Contrast works great, but the on-screen graphic is blank. You get the roundrect overlay just like Brightness, and the string of squares to show the level. but no symbol in there. Just a niggle really. Maybe Apple doesn't supply one in the OS as all their displays have just 1 axis of Brightness?
Also: keyboard controls for Brightness and Contrast don't work when MonitorControl's own pulldown menu is selected. I have percentages turned on in there so I can see precise values, but the keyboard controls just refuse to operate when that menu is in the foreground. Which is odd, as every other app I'm trying lets them work just fine (as they should, acting as system-wide controls).
Very pleased with how this app is coming along. v4 is epic!

Nice one!
I've got more feedback (on build 6171 on M1).
Keyboard controls for Brightness and Contrast are awesome! Brightness looks great and works great, just like my MacBook Air's internal display. Contrast works great, but the on-screen graphic is blank. You get the roundrect overlay just like Brightness, and the string of squares to show the level. but no symbol in there. Just a niggle really. Maybe Apple doesn't supply one in the OS as all their displays have just 1 axis of Brightness?
Also: keyboard controls for Brightness and Contrast don't work when MonitorControl's own pulldown menu is selected. I have percentages turned on in there so I can see precise values, but the keyboard controls just refuse to operate when that menu is in the foreground. Which is odd, as every other app I'm trying (and every other menubar pulldown menu) lets them work just fine (as they should, acting as system-wide controls).
Assigning custom keyboard controls works great. Got my F1/F2/Shift setup all good to go. Nice.
Very pleased with how this app is coming along. v4 is epic!

Hi @Muirium, thanks for your feedback! :)
The blank image for contrast is intentional. There is no (accessible) way to change the OSD image provided by Apple and I didn't want to go with the brightness image for contrast so I opted for blank (still better than not showing OSD at all).
Keyboard controls do work with the menu down but only if you use the standard media keys - custom shortcuts are not working at this time indeed.

I'll create a new branch to modify the appcast file without having to do a PR, but to me this one is ready for merging! Fantastic job @waydabber!  🚢 🚀

That signing thing is indeed annoying, will revert settings after creating the build and then we'll resolve this later.


Fix filter affects bound source collection by adding a dedicated FilterCollection

multiple ComboBoxes are affecting each other using the same source. This is because the same CollectionView is used under the hood:
<dotNetKitControls:AutoCompleteComboBox ItemsSource="{Binding Items}" SelectedItem="{Binding Item1}"/>
<dotNetKitControls:AutoCompleteComboBox ItemsSource="{Binding Items}" SelectedItem="{Binding Item2}"/>

The PR aims to fix this by overwriting the ItemsSource property to create dedicated CollectionViewSources per control.

Since nesting CollectionViewSource is not possible, the behaviour remains the same using CollectionViewSource as ItemsSource.

Thank you. This is released in v1.5.0.


Prevent optimizer from pruning UnnestExec.

Which issue does this PR close?

Closes #5281.
Rationale for this change
When running an aggregate count on an unnested column the aggregate_statistics optimizer removes UnnestExec from the ExecutionPlan.
What changes are included in this PR?
UnnestExec::statistics returns default statistics instead of returning child statistics.

Are these changes tested?
Tests for the fix is here
Are there any user-facing changes?
Aggregate count on unnested column now works as expected.

Thank you @jackwener, @alamb


Interpolation mechanism for discrete fields

This PR depends on #216, which should be merged before this one is considered.
A new interpolation mechanism for discrete fields is introduced. Compared to the original implementation, the new method takes an interpolator object with the interpolation algorithm. We can now write:
val df : DiscreteField[D, Domain, A] = ???
val interpolator = NearestNeighborInterpolator()
val field : Field[D, A] = df.interpolate(interpolator)

This makes it possible to use different interoplation algorithms using the same interface and separates the interpolation algorithm from the field implementation. The same mechanism is also used for the interpolation of a DiscreteLowRankGaussianProcess, i.e. we can write
val discreteGp : DiscreteLowRankGaussianProcess[D, Domain, A]
val interpolator = NearestNeighborInterpolator()
val gp : LowRankGaussianProcess[D, A] = discreteGp.interpolate(interpolator)

:+1:


ARM64

Excuse me, ZFP support ARM64 system？

We have not tested zfp on ARM64, but I see no obvious issues.  If you have access to such a system, I would appreciate any feedback you might be willing to share on your experiences.  I would suggest working off the develop branch, which includes extensive testing.

I was able to get access to an ARM64 system.  All tests pass using gcc 4.8.5.


IS-11 support

Hello everyone!
This PR adds Stream Compatibility Management API (https://github.com/AMWA-TV/is-11/commit/e98d15681ea4005e62828c41dc33f299395b2828) implementation and IS-11 support.
Could you please review it and describe what's needed to change to be merged?

Hi, we would love to see IS-11 support in NVNMOS. Thanks, 7thSense team!


Feature Request: run in command line with all default setting (mainly for CI, a.k.a. continuous integration)

Request to run in command line for CI purpose.
It's okay to just download the latest TBB, without really running it.
If it's already latest, simply exit 0.
Maybe related to #314

Duplicate of #39


feat: pass handlers in the config

something like
require('runner.nvim').setup({
  handlers = {
    java = -- your handler here
  }
})

which would be merged with the default handlers

Hello,
This is a great idea, I'm going to work on it this week (If you would like to, don't hesitate).
I also have to figure out how to "join" the user-provided handlers with the default ones using the choice helper since handlers are just functions.
Thanks for the suggestion

I was thinking a simple implementation which overrides the defaults (sorry for the bad wording).
It just simplifies the process of configuring, consolidating the handlers into setup() rather than requiring separate configuration.
for filetype, handler in pairs(config.handlers) do
   set_handler(filetype, handler)
end

The problem of using the set_handler function to set the user-provided handlers is that it overwrites the default handlers, I think it's a better idea to find a way to add handlers to default ones.

Sorry for taking so long to do it although it's a simple change, but I have added the option to pass the handlers to the setup function in 16a2c9c.
It still overwrites the old handers, but eventually I will change the whole way I store the handlers. I would use tables instead of functions for handlers to make it much more modular.
Thanks fo rthe suggestion


Inaccurate Tip Adjustment in Partial Fill Scenarios in Seaport SDK

Component
Utils
Have you ensured that all of these are up to date?

[X] seaport-js
[X] Node (minimum v16)

What version of seaport-js are you on?
v2.0.8
What function is the bug in?
fulfillStandardOrder
Operating System
macOS (Apple Silicon)
Describe the bug
Description
The Seaport SDK currently has an issue with incorrect tip adjustment in partial fill scenarios, leading to discrepancies in expected versus actual tip amounts. This affects the reliability of transaction handling.
Reproduction Scenario
Initial Setup: An order to sell 10 editions of an ERC1155 NFT, each at 1 ETH, with a 1 ETH tip.
Partial Fulfillment: A buyer purchases 3 editions, expecting to be charged 3.3 ETH (3 ETH for NFTs + 0.3 ETH adjusted tip).
Actual Behavior: The SDK charges 4 ETH due to unadjusted tip calculation.
Impact: This leads to unnecessary overpayments and refunds, affecting user experience and transaction predictability.
Proposed Solution and PR
An adjustTipsForPartialFills function is proposed to correct this issue. This is addressed in PR #416, which aims to ensure accurate tip calculations in partial fill scenarios.

hey @sofianeOuafir,
I have a question about the tip splitting. if the use purchase 3 editions and if we split the 1 ETH in 3 of them, which will be 1 / 3 = 0.34. I think rounding up might be a solution.

Hey @Sufiyan-dev, I have a solution that works in #413

Fixed and released in v3.0.1


setImmediate() with _.defer()

Any plans on delegating to window.setImmediate() where available in _.defer()..?
https://developer.mozilla.org/en/Document_Object_Model_(DOM)/window.setImmediate
http://ie.microsoft.com/testdrive/Performance/setImmediateSorting/Default.html
Would match the documented use case of "Defers invoking the function until the current call stack has cleared, similar to using setTimeout with a delay of 0" though it's perhaps not Underscore's place to start shimming for experimental browser features.

Also see NobleJS/setImmediate for a cross-browser shim.


Feature : Add mTLS feature to LDAP Authentencation servers

[X] Feature
[X] Ready for review

LDAP client certificate support is already implemented in Plus: https://docs.netgate.com/pfsense/en/latest/usermanager/ldap.html
This code would cause a conflict with that implementation.


inquiry :compiled version for windows + combine

Hi,
Would there be a compiled binary version for windows for ugrep-indexer?
Will ugrep-indexer be combined with ugrep in near future?
Thanks

This project will continue soon with updates. I'm figuring some things out in the meantime how to make it better, besides adding a windows exe version and adding the ability to index zip/tar archives and compressed files which are on the priority list.
As you know, indexed search is integrated in ugrep, but not the ability to index a FS. That is done with ugrep-indexer, which should be a separate tool and not be part of the ugrep tool.
I don't know if you perhaps mean if ugrep-indexer will eventually be part of the ugrep project? That can be done I suppose, once it comes out of beta of course.

thank you

Working on an update this week that includes compressed file indexing and a Windows exe version of the indexer. The ugrep.exe will be updated later to include indexed searching on Windows.

thank you so much for the update

Made time available this week to implement the exe version of the indexer and also added zip/compressed file indexing. It is working, with some caveats that I have to address.
Then my dev Windows machine died yesterday morning. Looks like a bad SSD.
Will work on this again when a replacement machine arrives. Setting up my dev env on other machines in the office is not an option right now.

I've ugrep-indexer.exe committed to the repo with new options -z and --zmax=NUM to index archives and compressed files. Will perform some more testing tomorrow and if all goes well will then release the ugrep-indexer 0.9.2 update as a release.
The ugrep 4.3.5 update will also released and supports option --index with -z to search indexed archives and compressed files. The ugrep.exe 4.3.5 also supports indexed-based searching. Because searching zip archives and compressed files is typically slow (relatively speaking), indexing these files gives a decent speed boost.

Awesome, thanks for the update!
On Tue, 5 Dec 2023, 11:05 am Dr. Robert van Engelen, <
@.***> wrote:

I've ugrep-indexer.exe committed to the repo with new options -z and
--zmax=NUM to index archives and compressed files. Will perform some more
testing tomorrow and if all goes well will then release the ugrep-indexer
0.9.2 update as a release.
The ugrep 4.3.5 update will also released and supports option --index
with -z to search indexed archives and compressed files. The ugrep.exe
4.3.5 also supports indexed-based searching. Because searching zip archives
and compressed files is typically slow (relatively speaking), indexing
these files gives a decent speed boost.
—
Reply to this email directly, view it on GitHub
https://github.com/Genivia/ugrep-indexer/issues/4#issuecomment-1839921632,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUYX4RKQGIDSHRF2I5CYCF3YH2FN7AVCNFSM6AAAAAA7PEKJDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZHEZDCNRTGI
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Ugrep v4.3.5 is released with a new ugrep.exe --index option. Also archives and compressed files can be indexed with option -z.

thank you
On Thu, 7 Dec 2023, 1:33 am Dr. Robert van Engelen, <
@.***> wrote:

Ugrep v4.3.5 is released with a new ugrep.exe --index option. Also
archives and compressed files can be indexed with option -z.
—
Reply to this email directly, view it on GitHub
https://github.com/Genivia/ugrep-indexer/issues/4#issuecomment-1843354025,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUYX4RPTUSDIM3CYQCEYNRDYICT7NAVCNFSM6AAAAAA7PEKJDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBTGM2TIMBSGU
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


Add "replica" property as configurable in openebs-storageclasses

Is this a BUG REPORT or FEATURE REQUEST?
BUG REPORT

What happened:
openebs-provisioner always creates two replicas, ignoring the value given for "replica" property inside the openebs-storageclasses yaml.
What you expected to happen:
openebs-provisioner must read the replica count assigned to the "replica" property in the openebs-storage classes and bring up the replicas as per the count mentioned in the storage classes.
How to reproduce it (as minimally and precisely as possible):
Steps to reproduce the issue:

In the openebs-storageclasses.yaml change the "replica" value from "2" to "1".
Create a StatefulSet utilizing this storage class.
openebs-provisioner ends up creating "2" replicas rather than "1".

Anything else we need to know?:

@yudaykiran  -- can you change the storage class properties to define parameters using the new policy format as explained in https://github.com/openebs/openebs/issues/863
For example, the replica policy should be:
opebebs.io/jiva-replica-count: "1"


Integrate CI test and deploy

Resolves #8

Maybe testing against node 20 is not necessary at the moment


task(Chats): Add count indicator for incoming messages

Issue:
When the user gets a new message we should show an indicator that counts how many unread messages the user has. It should match the same style of the one we have for incoming friend requests

this is already in #685


state.sls always run env=base

[root@test1 ~]# curl  -k https://localhost:8000 \
> -H "Accept: application/x-yaml" \
> -b ~/cookies.txt  -d client='local' \
> -d tgt='test2.nginxs.net' \
> -d fun='state.sls'  -d arg='sysctl' -d saltenv=test

return:
- test2.nginxs.net:
  - No matching sls found for 'sysctl' in env 'base'`

--
Hello, where do I go wrong
--
Version:
[root@test1 ~]#  salt  --versions-report
Salt: 2015.5.10
Python: 2.6.6 (r266:84292, Aug 18 2016, 15:13:37)
Jinja2: 2.2.1
M2Crypto: 0.20.2
msgpack-python: 0.4.6
msgpack-pure: Not Installed
pycrypto: 2.0.1
libnacl: Not Installed
PyYAML: 3.10
ioflo: Not Installed
PyZMQ: 14.3.1
RAET: Not Installed
ZMQ: 3.2.5
Mako: Not Installed
Tornado: 2.2.1
timelib: Not Installed
dateutil: 1.4.1

saltenv is a kwarg to the various state functions so the syntax would be:
curl  -k https://localhost:8000 \
> -H "Accept: application/x-yaml" \
> -b ~/cookies.txt  -d client='local' \
> -d tgt='test2.nginxs.net' \
> -d fun='state.sls'  -d arg='sysctl' -d arg=saltenv=test

Or is JSON format which may be a bit less odd:
curl  -k https://localhost:8000 \
-H "Accept: application/x-yaml" \
-H "Content-type: application/json" \
-b ~/cookies.txt -d '
[{
    "client": "local",
    "tgt": "test2.nginxs.net",
    "fun": "state.sls",
    "kwarg": {
        "mods": "sysctl",
        "saltenv": "test"
    }
}]
'

you are right. Thank you.


Float exact matches to the top in the Command Palette

This happens because the recently used section of the Command Palette is sorted by "last used". Reproing this bug is easy:

Run Preferences: Color Theme
Run Preferences: Browse Color Themes in Marketplace
Get Copilot Chat @vscode agent to suggest running the former

If we float exact matches to the top, the user can have a nicer experience when using @vscode in Chat & if they happen to type in an exact match.

I think in this case, floating a literal exact match to the top makes good sense... though it's probably a rare scenario.

it was amezing work


materialgram: <IP_ADDRESS> -> <IP_ADDRESS>

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

This time I'm not taking any selfie and just showing that it actually works. Also, I was compiling it with nix-build instead of nix-review because I forgot about it :trollface:. By the way, I added myself as a maintainer because oluceps and Aleksana often don't have time to update materialgram right in time

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367903

x86_64-linux

:white_check_mark: 1 package built:

materialgram


tinyfugue: init at 50b8

Motivation for this change
Add tinyfugue, a terminal UI, screen oriented, MUD client.
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@joachifm - Thank you for taking the time to review my pull request!  I've updated my pull request with the license.

Thanks!

Thank you for approving my changes, @joachifm!
I got a message back from the Hydra Build Daemon that says it's failing for the Darwin platform.  Would you know if there's a way to test changes on Macs without having any Apple hardware?

@KibaFox I'm unaware of any way of testing on darwin (but then again I know nothing about that platform). I think it's acceptable to disable darwin hydra builds and wait until a darwin user contributes a fix.
As far as I can tell, the error is due to use of a legacy typedef (caddr_t) which shouldn't be too hard to fix, but then there may be other problems.

I am currently downloading this box here: https://github.com/AndrewDryga/vagrant-box-osx
maybe I can test more stuff on os x then.

Thanks!  I'll give that a try.  It may be a little bit before I have time to set that up.


DOCS-Windows-policy-recommendations

Add Windows nodes are not supported for policy recommendations.
Product Version(s):
CE 3.17, 3.18
Issue:
n/a
Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[ ] Deploy preview inspected wherever changes were made
[ ] Build completed successfully
[ ] Test have passed

@bmckercher123 I think we actually have to merge this. You'll have to git pull --rebase upstream main then re-push your changes. Otherwise, lgtm


Correct dimension for SplineConv.

❓ Questions & Help
Hi, I successfully ran a ChebConv on my data and it worked very well. Now, I have some problem with the SplineConv.
The underlying graph has 60 half edges so edge_index.size() = [2,60] and pseudo.size() = [60,3]. And the input data has x.size() = [batch_size, vertex_size, in_channels].
Then, I define the layer  SplineConv(in_channels, out_channels, dim= 3, kernel_size = 6, node_dim =1). However, it gives the error

RuntimeError: x.size(1) == weight.size(1)

I suspect that it has something to do with node_dim =1, which had no problem in ChebConv. So I delete it and reshape the input data to be x.size() = [batch_size, in_channels, vertex_size]. But it says

2D tensors expected, got 3D

Could you advise me a bit how to correctly set the dimensions for data and layers. Thank you very much!

x size should be [vertex_size, vertex_size], ref:https://pytorch-geometric.readthedocs.io/en/latest/modules/data.html, and create your DataLoader ref:https://pytorch-geometric.readthedocs.io/en/latest/notes/create_dataset.html
Example:
from torch_geometric.datasets import TUDataset
from torch_geometric.data import DataLoader

dataset = TUDataset(root='/tmp/ENZYMES', name='ENZYMES', use_node_attr=True)
loader = DataLoader(dataset, batch_size=32, shuffle=True)

for batch in loader:
    batch
    >>> Batch(batch=[1082], edge_index=[2, 4066], x=[1082, 21], y=[32])

    batch.num_graphs
    >>> 32

It seems that SplineConv does not support node_dim at the moment. I will look into it.

This is not easy to fix, since the CUDA kernels are implemented in a rather static way to only support [num_nodes, num_features] node matrices. I am sorry!

x size should be [vertex_size, vertex_size], ref:https://pytorch-geometric.readthedocs.io/en/latest/modules/data.html, and create your DataLoader ref:https://pytorch-geometric.readthedocs.io/en/latest/notes/create_dataset.html
Example:
from torch_geometric.datasets import TUDataset
from torch_geometric.data import DataLoader

dataset = TUDataset(root='/tmp/ENZYMES', name='ENZYMES', use_node_attr=True)
loader = DataLoader(dataset, batch_size=32, shuffle=True)

for batch in loader:
    batch
    >>> Batch(batch=[1082], edge_index=[2, 4066], x=[1082, 21], y=[32])

    batch.num_graphs
    >>> 32

Thanks. I suppose you mean [batch_size, vertex_size]?

This is not easy to fix, since the CUDA kernels are implemented in a rather static way to only support [num_nodes, num_features] node matrices. I am sorry!

I see. Then I will try to use the dynamic way of batching. Thank you!


Created Wine-Quality-Analysis Project

Thank you for contributing @06RAVI06, make sure to check your contributions on GitHub Pages.


Fixed Tree.from_dict failing to recreate an arbitrary object tree with a mapper.

The recursive call to from_dict in class Node needed the mapper passed through.
Also added a test to check that the arbritrary object tree is correctly recreated. This test fails on the existing live branch and pass with the changes in this commit.

Thanks for contributing!


Fixed example.

When the Decode()'s return type is *SyntaxError, err may actually be null. It is when the return type is an interface (ie error), that err (a nil *SyntaxError), now as an interface type, will never be nil (as explained in http://golang.org/doc/faq#nil_error).

Is something wrong with this pull request?

@f03lipe This example is just for wrong useing. So it should be wrong. you want to amend it.

Exactly! Currently, it's not an error.
The caller's err != nil comparison won't always be true, because err is a pointer, not a interface (which can't be null).


chore: bump the h2 from 0.3 to 0.4

The main change: update to http 1.0.

I think the h2 dependency is used in the Console to access stuff inside Tonic. In that case, they should be kept in sync.

I think the h2 dependency is used in the Console to access stuff inside Tonic. In that case, they should be kept in sync.

Yep, @seanmonstar is right, upgrading the version of h2 would break this check:
https://github.com/tokio-rs/console/blob/ef61081caa6c20f9495563855969e8d820559dfe/tokio-console/src/conn.rs#L43-L47
Good catch!
@hi-rustin Let's close this PR.

As a side note, I'd recommend trying to figure out a way to do that without downcasting the error. Either in Console, or in Tonic. It is not part of hyper's stability promise.

upgrading the version of h2 would break this check:

How about I add some comments about it? I think it would be useful to be aware of it.

A comment in the Cargo.toml file could be helpful, right next to the dependency declaration.

Yes, that's a good idea. It would be nice if we could add some sort of a unit test for the behaviour in conn.rs as well.

Thanks for your review!  💚 💙 💜 💛 ❤


Rename Postgres to PostgreSQL

Fixes #1218

@johnktims Thanks for the pull request! I took a quick glimpse, and it looked fine. I will do a more thorough review in the weekend.

@johnktims Did you update possible references in the reference docs? They are in the querydsl-docs module.

I did not. I'll update the docs now.

@Shredder121 Maybe this should be merged first and the other SQL related PRs rebased on top of the changes?

Yes, I think that is a wise decision, although I haven't yet had the time to reinstall PostgreSQL(haha) to test this pull request.
Or did you already look at it?

I will still try it out in the weekend.

This is fine for me, @Shredder121 shall I merge it?

If it is fine for you then it is fine for me.
You can merge it then yes.


Update sbt-scalafix to 0.9.25

Updates ch.epfl.scala:sbt-scalafix from 0.9.21 to 0.9.25.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" } ]

labels: sbt-plugin-update, semver-patch

Superseded by #1336.


Use generated namespaces in e2e tests

This commit updates the OLM e2e test framework to create the test namespace if it does not already exist.

[FAIL] Fail Forward Upgrades when a CSV resource is in a failed state [It] eventually reports a successful state when using replaces

Worked locally, retesting

[FAIL] Fail Forward Upgrades when a CSV resource is in a failed state [It] eventually reports a successful state when using skip ranges

New failure that didn't happen locally, retesting.

@awgreene both of those are the known flakes that we tracked down, can sync on Slack for them but just re-test your heart away for now

/hold, waiting on https://github.com/operator-framework/operator-lifecycle-manager/pull/3028


OSX: Can't find Box2D header file

Hello! I recently installed Box2D using Homebrew on my Mac OSX 11.2.1. I need to use it in a project I am building with cmake and want to open it up in Xcode.
brew install box2d -> installs 2.4.1
I follow the general procedure of making a xcode folder, and running cmake -G Xcode .. in that folder. But my build fails when I try to include Box2D
fatal error: 'Box2D/Box2D.h' file not
      found
#include "Box2D/Box2D.h"

I also tried running with just regular cmake .. and then make -j 8. But nothing.
I saw a very old tutorial with Xcode and Box2D, but that wasn't very helpful now.
Any urgent help on this would be greatly appreciated. Thanks

I think the recent box2d upgrade is the cause. linux and windows configs were updated but not yet osx. Need to update osx projects.

Should I go back to a previous version? Thanks

You can check-out one of the earlier release tags, yeah.

Shouldn't include of library be with <> and not this "" brackets.

I'm still having some trouble on this. I tried pulling in the include folder from box2d-2.4.1 or box-2.4.0 and putting it into my Xcode project. While it builds, it still gives me a
ld: library not found for -lBox2D error. I also tried to use <> rather than "" but no luck.

It has been a while since you posted your comment, but since the issue is still open I think I might try and help, for others that might have the same problem. I think the problem may be that up until version 2.3.1 the headers were capitalized as Box2D, but in the newer versions they were changed to box2d.h and  -lbox2d. Hope this helps.

Yeah, check your capitalization.


Editing docs page via simulatedgreg.gitbooks.io/electron-vue reached 404 error

Found an issue or bug? Tell me all about!
Bug
Describe the issue / bug.
When trying to click the link "EDIT THIS PAGE" when browsing Electron-Vue docs via simulatedgreg.gitbooks.io/electron-vue would result in 404 error page.
How can I reproduce this problem?

Go to any docs page at https://simulatedgreg.gitbooks.io/electron-vue/en/
Browse at the top of the page and click "EDIT THIS PAGE".
The page will load to a 404 Github page error.

If visual, provide a screenshot.

I think the reason here is the URL is directing to incorrect page:
https://github.com/SimulatedGREG/electron-vue/tree/master/en/entry_indexhtml.md where the correct URL would be https://github.com/SimulatedGREG/electron-vue/tree/master/docs/en/docs/entry_indexhtml.md

@bahit
Good catch! Just pushed a fixed.


getConnections() : array -> getConnection(string $name) : mixed

Current getConnections() initialize all connections even if they are not used. New API can lazy load connections on the first demand.
/**
  * @return PDO|MongoDb\Database|Elasticsearch\Client|null
  */
function getConnection(string $name) : mixed;

what do you think @kambo-1st ?

duplicates #24


[WFLY-16222] Upgrade commons-io 2.11.0

Fixes https://issues.redhat.com/browse/WFLY-16222

@jamezp Looking at the dependencies it seems you're the best for review and approval. Could you check and approve, please?

Thanks @boris-unckel


Add accelerometer module

Currently does not compile. Flash overflows by 80 bytes.

All good after disabling DMESG


Fix lints, melos run format

Description
This PR is just fixing lints plus melos run format.
Related Issues
Currently, in all open PRs below the diff, there is a list of lints from unchanged files (screenshot below).
Idk why our pipeline hasn't complained about them, but it's probably better for everyone to fix the lints (especially before the Hacktoberfest with lots of PRs).
I hope, it doesn't break compatibility with Flutter <3.3 or something similar.

Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[ ] I updated the version in pubspec.yaml and CHANGELOG.md.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

@miquelbeltran should I update all versions/changelogs of touched plugins, or are releases for this too much effort?

No need to bump the versions IMO, this is just an internal cleanup.


How to make slider with thumbnail vertical

I didn't see the option for thumbnail with vertical slider.
Can anyone help me?

You can use this parameters,   'vertical' (for vertical slider).
direction: 'vertical',

Thank @lumburr but I think you might get it wrong.
What I mean is the thumbnail's position. like this one.


The original filename and filename of file which got sbx encoded are not in metadata.

Include these 2 filenames in metadata to a fixed size, if name is test.txt , save it as text_____.txt and save as max size to 13 bytes.

filenames got stored in Header Block with metadata


Icons for TestRunStates

Tests in the new API have several states:
export enum TestRunState {
	// Initial state
	Unset = 0,
	// Test is currently running
	Running = 1,
	// Test run has passed
	Passed = 2,
	// Test run has failed (on an assertion)
	Failed = 3,
	// Test run has been skipped
	Skipped = 4,
	// Test run failed for some other reason (compilation error, timeout, etc)
	Errored = 5
}

I would like icons to represent these in the sidebars 🙂  Some existing icons might work, e.g.

Unset: no icon, or maybe some "dimmed" icon like an unset breakpoint?
Running: refresh
Passed: check
Failed: close
Skipped: same as unset? Not sure... This would be if you have something like test.only in your code.
Errored: issues

This is being implemented in core so I can have different colors/opacities/etc in the icons. Let me know what you think.

I also want to add an additional state -- Queued

Yea, that looks pretty 🙂 I'm not sure about the queued one though... maybe a small yellow clock symbol?

Yea we can try that too:

That's beautiful 😍

I wonder what you think about animation on the "running" icon. It's never felt very clear to me. At the moment we don't really that icon heavily or at all in core. Maybe now that it's getting a prominent display--which could show for several seconds on slow cases--we could make it CSS-based with a smooth growing/shinking effect on the balls, instead of a plain spinning effect.

The loading icon is now updated in master and should follow this pattern.

The loading icon is now updated in master and should follow this pattern.


[BugFix] Fix an issue where the numberConnection variable in the ConnectScheduler class repeatedly counts the same connection

Why I'm doing:
fe_connection_total metrics counts the same connection twice, then will result 'Reach limit of connections' error.
What I'm doing:
fix the metircs counter
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[x] Yes, this PR will result in a change in behavior.
[ ] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[x] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[x] 3.1
[x] 3.0
[x] 2.5

hi @kangkaisen
How should I pass the ADMIT TEST CI PIPELINE?

Can you show the bug details? Which version did you encounter this bug in?

Sorry, I was wrong about the logic of the scenario for that bugfix


Add the ability to include additional security headers

As a web admin
I want the ability to add additional security headers
In order to prevent third parties framing my site or understanding my website technology

Complete


The close method of _Base class is not available.

Environment

aiohttp                  3.8.6
oss2                     2.18.4
asyncio-oss              1.1.2

Example Code
bucket = asyncio_oss.Bucket(oss_auth, endpoint, "test_bucket")
await bucket.put_object("test/test.txt", "test")
await bucket.close()

Error
Traceback (most recent call last):
  File "/home/lmsh7/financial-report/financial_report/api/module/oss_client.py", line 171, in <module>
    loop.run_until_complete(test_async_upload())
  File "/usr/local/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete
    return future.result()
  File "/home/lmsh7/financial-report/financial_report/api/module/oss_client.py", line 165, in test_async_upload
    await bucket.close()
  File "/home/lmsh7/.local/lib/python3.10/site-packages/asyncio_oss/api.py", line 281, in close
    await self.session.close()
AttributeError: 'Session' object has no attribute 'close'
Unclosed client session
client_session: <aiohttp.client.ClientSession object at 0x7fb353743f40>
Unclosed connector
connections: ['[(<aiohttp.client_proto.ResponseHandler object at 0x7fb35376f400>, 2329107.492301855)]']
connector: <aiohttp.connector.TCPConnector object at 0x7fb353743e80>

Thanks! I already fixed in this commit.


chore: add a missing bug-fix note

Summary

3.8.1 release note misses a bug fix for empty rollout cases.

Issues

"OASIS-7997"

Pull Request Test Coverage Report for Build 1861

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.521%

Totals

Change from base Build 1860:
0.0%

Covered Lines:
4727

Relevant Lines:
5222

💛  - Coveralls


Create progresses Collection Routes

Create below three API endpoints related to tracking progress for a particular user or task. Here's a brief description of each:
POST /progresses: This endpoint will allow us to create a new progress entry.
GET /progresses: This endpoint will allow us to retrieve progress entries based on the provided parameters.
GET /progresses/range: This endpoint will allows us to retrieve progress records for a particular user or task within the specified date range.
It has following constraints:
Progress record before 6 am of the next day should be counted as progress report for today.
Only 1 Progress record is allowed to be created by per user per day

The child tickets are as follows :

#1074
https://github.com/Real-Dev-Squad/website-data-models/pull/36
https://github.com/Real-Dev-Squad/website-api-contracts/pull/124

TODO :
Create a composite index as follows for the progresses collection

Field
taskId
Ascending

Field
date
Ascending

Field
userId
Ascending

Field
date
Ascending


seeking example of using domain encrypted passwords in yaml model

I see that using domain encrypted passwords is an option in the model but I'm not seeing any further example or explanations.
            JDBCDriverParams:
                URL<EMAIL_ADDRESS>                PasswordEncrypted: '--FIX ME--'
                DriverName: oracle.jdbc.OracleDriver

In our home grown python process our developers pre-encrypt the passwords and store them in a user/keyfile setup.  Then we apply
setEncrypted('/JDBCSystemResources/poolname/JDBCResource/poolname/JDBCDriverParams/poolname/Password','user_alias', './userlist.txt', './key_file.txt')
We have some concerns about the model encryption.  Keeping the passphrase standardized and consistent for the life of the configuration could prove challenging since its not included in the model/archive.   This would be true for larger development teams.

hi gthomas01 -
You can use domain-encrypted passwords directly in the model, and those will be applied to the target domain. For example:
                PasswordEncrypted: '{AES}xxxx'

or, better yet, store them in a separate (secure) properties file, and reference as:
                PasswordEncrypted: '@@PROP:mypwd@@'

This is not very common, since it can't be used when creating a domain (the passwords can't be derived yet). It could be useful in an update / deploy operation, though.
Domain-encrypted passwords can't be used in tandem with model encryption, but it looks like you aren't using that.

Thank you!  that is what I was looking for.


ommand-->command

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/assign @foxish

@yjl-lgx you should bump chart version in Chart.yaml

@foxish OK

/ok-to-test

/lgtm