ratelimiter: use correct ttlSeconds value, and always call Set

What does this PR do?
This change fixes two issues that were sort of canceling each other:

the ttlSeconds argument that was given to TtlMap.Set was previously
based on a value in nanoseconds instead of seconds. That was not only
incorrect, but also potentially an integer overflow on some platforms.
(Not actually reproduced, but most likely the cause for issue 8235).

we were only calling TtlMap.Set when initially creating the rate
limiter for a given source. That was wrong, because the expiryTime
(now + ttlSeconds) for a given source must be updated everytime there is
any activity for a given, which is what TtlMap.Set does.

We should have observed sources getting expired and garbage collected by
ttlmap because of 2), but since we were setting an incorrect, huge,
ttlSeconds because of 1), the symptom of 2) did not occur as obviously
and often as it should have.
Motivation
Fix an integer overflow.

More
~- [ ] Added/updated tests~
~- [ ] Added/updated documentation~
Additional Notes
Fixes #8235

I think there's something fishy about the way we handle(d) a zero Average rate limiter, and I want to have another look at it before we land this.


New - React global news

Q
A

Bug fix?
no

New feature?
yes

New sample?
yes

What's in this Pull Request?
New React-Global-News webpart

Hey @joaojmendes this pull request looks like it will be a great sample. However, I'm getting an error when I try to build it:
c:\joaorocks\samples\react-global-news\node_modules\node-sass\lib\binding.js:15
      throw new Error(errors.missingBinary());
      ^

Error: Missing binding c:\joaorocks\samples\react-global-news\node_modules\node-sass\vendor\win32-x64-64\binding.node
Node Sass could not find a binding for your current environment: Windows 64-bit with Node.js 10.x

Found bindings for the following environments:
  - Windows 64-bit with Node.js 11.x

This usually happens because your environment has changed since running `npm install`.
Run `npm rebuild node-sass` to download the binding for your current environment.
    at module.exports (c:\joaorocks\samples\react-global-news\node_modules\node-sass\lib\binding.js:15:13)
    at Object.<anonymous> (c:\joaorocks\samples\react-global-news\node_modules\node-sass\lib\index.js:14:35)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (c:\joaorocks\samples\react-global-news\node_modules\@microsoft\gulp-core-build-sass\lib\SassTask.js:11:18)

Any ideas what it could be?
I can build other solutions (I tried another one in the sample folder to make sure), it just seems to be this one.

Hi @hugoabernier
I close this PR and create new one. I fixe the problem, problems with node version that I used on that. now I used the correct version. node: 10.13.0 and in my envoriment everything works fine.
Sorry for the mess.
thank you very much for your help.

Thanks @joaojmendes , there is no need to apologize. These things happen all the time. Thanks for taking the time to fix the issue. I'll go work on the PR.


Fix: default table sort was always ascending

An ascending sort order is always triggered when then target index is different
from the tablesort index. This was always true on a page (re)load, because
index is initialized with null.  By setting the instance' index to the
default-sort column index we assure that the direction parameter to sort() is
used.
See https://github.com/kylefox/jquery-tablesort/blob/master/jquery.tablesort.js#L42

Coverage remained the same at 81.76% when pulling 14633ace28efd025de6c5658f0fbe340f8f811c2 on octomike:fix_default_table_sort into 3867e1aa77e2b24eae56f796df69777e1c955988 on voxpupuli:master.

Coverage remained the same at 81.76% when pulling 45a128be71255dbed2431b387aea43e5d625d20f on octomike:fix_default_table_sort into 3867e1aa77e2b24eae56f796df69777e1c955988 on voxpupuli:master.

Tablesort will not work properly with DataTables that is initialized in _macros.html.

I'm not trying to save anything.
Maybe it's just me, but right now the default sorting on the index page is broken. I assume the only logical order is descending by report timestamp, right? And this PR should address this.

It should or it does? @octomike

Not for me...
This is current master:

On month changes this would look even worse, because the ordering is not just in the wrong direction, it's also broken.
This is the feature branch:

As for the fix in end behavior. I can confirm that this change fixes the default sorting when you first launch a page.
Nice work 👍

Coverage remained the same at 81.76% when pulling c90d9b09c582749b0c20ff22f575854b8be9b9a0 on octomike:fix_default_table_sort into 2da9ba93967cd0f2a3187cb1a8ddac8c5f8d85c0 on voxpupuli:master.

Can this be merged?

As @octomike said, can't this be merged?
Then the changes requested by @runejuhl, the latter could be a different PR.

As @octomike said, can't this be merged?
Then the changes requested by @runejuhl could be a different PR.

I'd much rather fix issues beforehand -- my experience is that if we don't fix it now, it'll never be fixed, and for minor things like this it's doubly true.
@larsnaesbye care to give it a spin and see if everything is alright? I've rebased @octomike's work onto master, done some linting and fixed the requested change. Find it here: https://github.com/runejuhl/puppetboard/tree/pr/444

I say go for a merge.


Signing HTTP request with "Encryption Management"

Describe the bug
When I want to sign a HTTP request using codeunit 1266 "Encryption Management".SignData I receive the following error:
A call to System.Security.Cryptography.RSACryptoServiceProvider.FromXmlString failed with this message: Invalid syntax on line 1.
To Reproduce
Steps and to reproduce the behavior:

Use function SignData of codeunit "Encryption Management" with HashAlgoritmType::SHA512 or SHA256
CryptographyMgt.SignData(SigningString, PrivateKeyFile, HashAlgorithmType::SHA512, SignatureOutStream);

SigningString is a pre-generated random string
PrivateKeyFile is a InStream containing the private key file
HashAlgorithm is SHA512 or SHA256
SignatureOutstream is the outstream with the result.

AL Code to reproduce the issue
TempBlob.CreateOutStream(SignatureOutStream);
CryptographyMgt.SignData(SigningString, PrivateKeyFile, HashAlgorithmType::SHA512, SignatureOutStream);
Expected behavior
I expect SignatureOutstream to contain the result of the signing procedure.
Screenshots
If applicable, add screenshots to help explain your problem.
5. Versions:

AL Language: 4.0.206840

Business Central: 15.2 (Platform 15.0.39461.39737 + Application 15.2.39558.39796)

Hi! Please take a minute to read the guidelines for this repository https://github.com/microsoft/AL and our collection of frequently asked questions https://github.com/Microsoft/AL/wiki/frequently-Asked-Questions .
As this repository is only for issues related to the AL compiler in latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.


turtlebot3_drive does not publish to cmd_vel

I am using the melodic version of ROS with an Ubuntu 18.04 system.
I ran into an issue where the burger bot in gazebo, did not move when turtlebot3_simulation.launch file was launched.
When I ran "rqt_graph" node I found out that the "turtlebot3_drive" node did not publish to /cmd_vel topic and also it did not subscribe from /odom and /scan topics too.
I made the following change in the in the "turtlebot3_drive.cpp" file present in the "/turtlebot3_gazebo/src" folder and the issue was solved. I added the turtlebot3_drive.init(); line in the main() function as shown below:
int main(int argc, char* argv[])
{
  ros::init(argc, argv, "turtlebot3_drive");
  Turtlebot3Drive turtlebot3_drive;
  turtlebot3_drive.init();  //the line that I added

  ros::Rate loop_rate(125);

  while (ros::ok())
  {
    turtlebot3_drive.controlLoop();
    ros::spinOnce();
    loop_rate.sleep();
  }

  return 0;
}

Probably it happened because, some compilers do not run the init() function of a class, as soon as it's object is created.
I thought I could post this here, as if anyone faced the same issue as me could get it sorted.
Thank you.

@svdeepak99 Thanks for your kind remind. I found the turtlebot doesn't move after launch turtlebot3_gazebo/turtlebot3_world.launch. So I found this opened issue and remind. I have added the line "  turtlebot3_drive.init(); "  in  turtlebot3_drive.cpp, then catkin_make whole work space. Now I can see the turtlebot3_drive node subscribing the "/cmd_vel" topic, however it is still not moving in gazebo with turtlebot3_teleop_key.launch.  am I missing something?

Hi Jim. Did you check if the turtlebot3_teleop_key node is publishing to the /cmd_vel topic & did you confirm if the values are being printed with the rostopic echo command?

@svdeepak99 Thanks for your quick reply. I do confirm the /cmd_vel topic were published successfully by the  turtlebot3_teleop_key node after checking the rostopic echo command and it is worth to mention that the teleop node also works with the turtlebot3_fake/turtlebot3_fake.launch node, the turtlebot3 model moves in the rviz when I press W button.

@JimEverest Sorry for the late reply. I'm just checking in whether you are still having trouble with the Gazebo + teleop key. I didn't experience the issue on my machine after executing below commands.
$ roslaunch turtlebot3_gazebo turtlebot3_world.launch

$ roslaunch turtlebot3_teleop turtlebot3_teleop_key.launch

@ROBOTIS-Will I am experiencing the same issue that @JimEverest mentioned above with the Gazebo + teleop key. I do experience the issue on my machine after executing below commands.
$ roslaunch turtlebot3_gazebo turtlebot3_world.launch
$ roslaunch turtlebot3_teleop turtlebot3_teleop_key.launch
I am using ROS version 1.14.6 on Ubuntu 18.04.4 LTS, and like @JimEverest I am able to move the via teleop in rviz using the following commands.
$ roslaunch turtlebot3_fake turtlebot3_fake.launch
$ roslaunch turtlebot3_teleop turtlebot3_teleop_key.launch

Did anyone resolve this issue? I am also facing the same problem as @jtisaacs. Rviz nodes are working but I am not able to drive turtlebot in gazebo. Any help will be appreciated.
Thank you.

@jtisaacs If you are unable to move TurtleBot3 on Gazebo, you may not installed all necessary Gazebo packages such as gazebo-plugins. Please install all gazebo packages with below command and try again. Also, please note that Kinetic works best with Ubuntu 16.04. I'd recommend using Melodic for your Ubuntu 18.04 or install Ubuntu 16.04 to use ROS 1 Kinetic.
$ sudo apt install ros-kinetic-gazebo*

@adipandas You can try installing all gazebo packages with below command. First, check which gazebo version you are running then install necessary pacakges.
$ gazebo --version

If you are running gazebo 9,
$ sudo apt install ros-melodic-gazebo-*

If you are running gazebo 11,
$ sudo apt install ros-melodic-gazebo11*

@ROBOTIS-Will Your suggestion solved the issue. I actually did not consider checking my gazebo packages.
Thank you. :smile:
I think this issue can be closed now.

ROS_ASSERT issue has been fixed in #120. Please let us know if there's any issue with this fix.
@adipandas Glad to hear that your issue is gone now!

I am using ROS Melodic and i tried this command turtlebot3_simulation.launch
After making the change like this thread (add this turtlebot3_drive.init();)
It still does not work.
Anyone able to help with this?

I am using ROS Melodic and i tried this command turtlebot3_simulation.launch
After making the change like this thread (add this turtlebot3_drive.init();)
It still does not work.
Anyone able to help with this?

@lyhlau
I just tested with the latest source code, but couldn't find the issue.
Could you give me the list of command you entered with the rqt_graph image?
Also, make sure that all your source code is up to date.
Thanks.

@lyhlau
I just tested with the latest source code, but couldn't find the issue.
Could you give me the list of command you entered with the rqt_graph image?
Also, make sure that all your source code is up to date.
Thanks.

I tried this 2 command
roslaunch turtlebot3_gazebo turtlebot3_world.launch
roslaunch turtlebot3_gazebo turtlebot3_simulation.launch
the world is able to launch but the 2nd command does not work, turtlebot not moving
I had tried the fix in the first thread here -> the turtlebot3_drive.init();

I tried this 2 command
roslaunch turtlebot3_gazebo turtlebot3_world.launch
roslaunch turtlebot3_gazebo turtlebot3_simulation.launch
the world is able to launch but the 2nd command does not work, turtlebot not moving
I had tried the fix in the first thread here -> the turtlebot3_drive.init();

Please try with the latest code after removing the installed package.
$ sudo apt remove ros-melodic-turtlebot3 ros-melodic-turtlebot3-simulations
$ mkdir -p ~/catkin_ws/src
$ cd ~/catkin_ws/src
$ git clone -b melodic-devel https://github.com/ROBOTIS-GIT/turtlebot3.git
$ git clone -b melodic-devel https://github.com/ROBOTIS-GIT/turtlebot3_simulations.git
$ cd ~/catkin_ws && catkin_make

Please try with the latest code after removing the installed package.
$ sudo apt remove ros-melodic-turtlebot3 ros-melodic-turtlebot3-simulations
$ mkdir -p ~/catkin_ws/src
$ cd ~/catkin_ws/src
$ git clone -b melodic-devel https://github.com/ROBOTIS-GIT/turtlebot3.git
$ git clone -b melodic-devel https://github.com/ROBOTIS-GIT/turtlebot3_simulations.git
$ cd ~/catkin_ws && catkin_make

Please try with the latest code after removing the installed package.
$ sudo apt remove ros-melodic-turtlebot3 ros-melodic-turtlebot3-simulations
$ mkdir -p ~/catkin_ws/src
$ cd ~/catkin_ws/src
$ git clone -b melodic-devel https://github.com/ROBOTIS-GIT/turtlebot3.git
$ git clone -b melodic-devel https://github.com/ROBOTIS-GIT/turtlebot3_simulations.git
$ cd ~/catkin_ws && catkin_make

I just tried your steps
then I run this command
roslaunch turtlebot3_gazebo turtlebot3_world.launch
[Err] [REST.cc:205] Error in REST request - there is this bar coming out in red
but the world is able to pops out with the turtlebot
but it still does not move by itself when i run this roslaunch turtlebot3_gazebo turtlebot3_simulation.launch

Please try with the latest code after removing the installed package.
$ sudo apt remove ros-melodic-turtlebot3 ros-melodic-turtlebot3-simulations
$ mkdir -p ~/catkin_ws/src
$ cd ~/catkin_ws/src
$ git clone -b melodic-devel https://github.com/ROBOTIS-GIT/turtlebot3.git
$ git clone -b melodic-devel https://github.com/ROBOTIS-GIT/turtlebot3_simulations.git
$ cd ~/catkin_ws && catkin_make

I just tried your steps
then I run this command
roslaunch turtlebot3_gazebo turtlebot3_world.launch
[Err] [REST.cc:205] Error in REST request - there is this bar coming out in red
but the world is able to pops out with the turtlebot
but it still does not move by itself when i run this roslaunch turtlebot3_gazebo turtlebot3_simulation.launch

Looks like you have some issue with your installed Gazebo.
https://answers.gazebosim.org//question/25030/gazebo-error-restcc205-error-in-rest-request/#:~:text=As can be seen in,ignitionrobotics.org inside the ~%2F.

Looks like you have some issue with your installed Gazebo.
https://answers.gazebosim.org//question/25030/gazebo-error-restcc205-error-in-rest-request/#:~:text=As can be seen in,ignitionrobotics.org inside the ~%2F.

It does help resolve the [Err] line
but it still does not move
Code i get after roslaunch turtlebot3_gazebo turtlebot3_world.launch
SUMMARY
PARAMETERS

/gazebo/enable_ros_network: True
/robot_description: <?xml version="1....
/rosdistro: melodic
/rosversion: 1.14.9
/use_sim_time: True

NODES
/
gazebo (gazebo_ros/gzserver)
gazebo_gui (gazebo_ros/gzclient)
spawn_urdf (gazebo_ros/spawn_model)
auto-starting new master
process[master]: started with pid [2421]
ROS_MASTER_URI=http://localhost:11311
setting /run_id to a3158cd6-50b5-11eb-b3d6-0800278352f6
process[rosout-1]: started with pid [2432]
started core service [/rosout]
process[gazebo-2]: started with pid [2435]
process[gazebo_gui-3]: started with pid [2440]
process[spawn_urdf-4]: started with pid [2444]
[ INFO] [1610002666.335278181]: Finished loading Gazebo ROS API Plugin.
[ INFO] [1610002666.338069566]: waitForService: Service [/gazebo/set_physics_properties] has not been advertised, waiting...
[ INFO] [1610002666.406683405]: Finished loading Gazebo ROS API Plugin.
[ INFO] [1610002666.409612771]: waitForService: Service [/gazebo_gui/set_physics_properties] has not been advertised, waiting...
[ INFO] [1610002668.232579584]: waitForService: Service [/gazebo/set_physics_properties] is now available.
[ INFO] [1610002669.085459506, 0.001000000]: Physics dynamic reconfigure ready.
[ INFO] [1610002669.086482145, 0.001000000]: Laser Plugin: Using the 'robotNamespace' param: '/'
[ INFO] [1610002669.086710156, 0.001000000]: Starting Laser Plugin (ns = /)
[ INFO] [1610002669.090041770, 0.001000000]: Laser Plugin (ns = /)  <tf_prefix_>, set to ""
[ INFO] [1610002669.168699376, 0.001000000]: Starting plugin DiffDrive(ns = //)
[ INFO] [1610002669.169338188, 0.001000000]: DiffDrive(ns = //):  = na
[ INFO] [1610002669.170509975, 0.001000000]: DiffDrive(ns = //): <tf_prefix> =
[ INFO] [1610002669.172321674, 0.001000000]: DiffDrive(ns = //): Advertise joint_states
[ INFO] [1610002669.173231288, 0.001000000]: DiffDrive(ns = //): Try to subscribe to cmd_vel
[ INFO] [1610002669.176462772, 0.001000000]: DiffDrive(ns = //): Subscribe to cmd_vel
[ INFO] [1610002669.177500295, 0.001000000]: DiffDrive(ns = //): Advertise odom on odom
[spawn_urdf-4] process has finished cleanly
log file: /home/lau/.ros/log/a3158cd6-50b5-11eb-b3d6-0800278352f6/spawn_urdf-4*.log
It seems normal and succeeded
Then codes i get after roslaunch turtlebot3_gazebo turtlebot3_simulation.launch
started roslaunch server http://lau-VirtualBox:42265/
SUMMARY
PARAMETERS

/cmd_vel_topic_name: /cmd_vel
/rosdistro: melodic
/rosversion: 1.14.9

NODES
/
turtlebot3_drive (turtlebot3_gazebo/turtlebot3_drive)
ROS_MASTER_URI=http://localhost:11311
process[turtlebot3_drive-1]: started with pid [2677]
[ INFO] [1610002685.141700814]: TurtleBot3 Simulation Node Init
after the code, the robot just remain silent there. I am able to control the robot with the teleop_key command.
I suspect is something wrong here roslaunch turtlebot3_gazebo turtlebot3_simulation.launch

It does help resolve the [Err] line
but it still does not move
Code i get after roslaunch turtlebot3_gazebo turtlebot3_world.launch
SUMMARY
PARAMETERS

/gazebo/enable_ros_network: True
/robot_description: <?xml version="1....
/rosdistro: melodic
/rosversion: 1.14.9
/use_sim_time: True

NODES
/
gazebo (gazebo_ros/gzserver)
gazebo_gui (gazebo_ros/gzclient)
spawn_urdf (gazebo_ros/spawn_model)
auto-starting new master
process[master]: started with pid [2421]
ROS_MASTER_URI=http://localhost:11311
setting /run_id to a3158cd6-50b5-11eb-b3d6-0800278352f6
process[rosout-1]: started with pid [2432]
started core service [/rosout]
process[gazebo-2]: started with pid [2435]
process[gazebo_gui-3]: started with pid [2440]
process[spawn_urdf-4]: started with pid [2444]
[ INFO] [1610002666.335278181]: Finished loading Gazebo ROS API Plugin.
[ INFO] [1610002666.338069566]: waitForService: Service [/gazebo/set_physics_properties] has not been advertised, waiting...
[ INFO] [1610002666.406683405]: Finished loading Gazebo ROS API Plugin.
[ INFO] [1610002666.409612771]: waitForService: Service [/gazebo_gui/set_physics_properties] has not been advertised, waiting...
[ INFO] [1610002668.232579584]: waitForService: Service [/gazebo/set_physics_properties] is now available.
[ INFO] [1610002669.085459506, 0.001000000]: Physics dynamic reconfigure ready.
[ INFO] [1610002669.086482145, 0.001000000]: Laser Plugin: Using the 'robotNamespace' param: '/'
[ INFO] [1610002669.086710156, 0.001000000]: Starting Laser Plugin (ns = /)
[ INFO] [1610002669.090041770, 0.001000000]: Laser Plugin (ns = /)  <tf_prefix_>, set to ""
[ INFO] [1610002669.168699376, 0.001000000]: Starting plugin DiffDrive(ns = //)
[ INFO] [1610002669.169338188, 0.001000000]: DiffDrive(ns = //):  = na
[ INFO] [1610002669.170509975, 0.001000000]: DiffDrive(ns = //): <tf_prefix> =
[ INFO] [1610002669.172321674, 0.001000000]: DiffDrive(ns = //): Advertise joint_states
[ INFO] [1610002669.173231288, 0.001000000]: DiffDrive(ns = //): Try to subscribe to cmd_vel
[ INFO] [1610002669.176462772, 0.001000000]: DiffDrive(ns = //): Subscribe to cmd_vel
[ INFO] [1610002669.177500295, 0.001000000]: DiffDrive(ns = //): Advertise odom on odom
[spawn_urdf-4] process has finished cleanly
log file: /home/lau/.ros/log/a3158cd6-50b5-11eb-b3d6-0800278352f6/spawn_urdf-4*.log
It seems normal and succeeded
Then codes i get after roslaunch turtlebot3_gazebo turtlebot3_simulation.launch
started roslaunch server http://lau-VirtualBox:42265/
SUMMARY
PARAMETERS

/cmd_vel_topic_name: /cmd_vel
/rosdistro: melodic
/rosversion: 1.14.9

NODES
/
turtlebot3_drive (turtlebot3_gazebo/turtlebot3_drive)
ROS_MASTER_URI=http://localhost:11311
process[turtlebot3_drive-1]: started with pid [2677]
[ INFO] [1610002685.141700814]: TurtleBot3 Simulation Node Init
after the code, the robot just remain silent there. I am able to control the robot with the teleop_key command.
I suspect is something wrong here roslaunch turtlebot3_gazebo turtlebot3_simulation.launch

Sorry but I can't reproduce your problem with my Melodic machine.
I strongly recommend to reinstall Gazebo.
Thanks.

Sorry but I can't reproduce your problem with my Melodic machine.
I strongly recommend to reinstall Gazebo.
Thanks.

Sorry but I can't reproduce your problem with my Melodic machine.
I strongly recommend to reinstall Gazebo.
Also, it is not recommended to run ROS on virtual machine.
Thanks.

Thank for your help, your advice is much appreciated.

Sorry but I can't reproduce your problem with my Melodic machine.
I strongly recommend to reinstall Gazebo.
Also, it is not recommended to run ROS on virtual machine.
Thanks.

Thank for your help, your advice is much appreciated.


Not setting cloud variables.

My script runs fine and everything seems normal but it does not actually update the variable when looking at the logs. I have tried this on multiple different computers with different scratch acounts.
import scratchattach as scratch3
session = scratch3.login("username", "password")
conn = session.connect_cloud("projectid")
conn.set_var("variable", "value")
conn.disconnect()
I know scratch has been changing how their api works so idk if thats affecting it. I can still pull values though.

Id suggest using the sessionID and username instead cus that works for me in Replit

ok ill try that

still not working

here is the project but its the same on any project I've tried.
https://scratch.mit.edu/cloudmonitor/759236467/

have you run pip install - U scratchattach in shell then
`import scratchattach as scratch3
session = scratch3.login("yoursessionID", "password")
conn = session.connect_cloud("projectid")
conn.set_var("variable", "value")
`

replace  yoursessionID with your session ID if you know what that is btw  are you in Replit?

no im in power shell and i tried session id

Also I have scratch attach installed. Are you sure its working for you right now?

it should work fine is there a error?
or what

I dont get any errors.

uhuh do you have a replit account?

No should i get one?

Yuh

ok i did

I'll can help you on there then :D

ok what info do you need?

Tell me when your online tomorrow I'll help you!

ok thanks

btw way if you put data_from_websocket = true in client.run the request should work

where is client.run?


ldap user sync and seen on user.conf but user login  fail

Hello..
I have did successfully did ldap setting and also seen my all user
but when user login so it said  "Invalid User or Password"
below is my gitblit.properties settings
realm.authenticationProviders = ldap
realm.passwordStorage = md5
realm.minPasswordLength = 5
realm.ldap.server = ldap://xxx.xxxxxxx.com:389
realm.ldap.username = cn=Directory Manager
realm.ldap.password = XXXXXXXXXX
realm.ldap.backingUserService = ${baseFolder}/users.conf
realm.redmine.backingUserService = ${baseFolder}/users.conf
realm.ldap.maintainTeams = false
realm.ldap.accountBase = DC=xxxxxxxx,DC=com
realm.ldap.accountPattern = (&(objectClass=person)(uid=${username}))
realm.ldap.displayName = displayName
realm.ldap.uid = uid
realm.ldap.synchronize = true
realm.ldap.syncPeriod = 5 MINUTES
realm.ldap.removeDeletedUsers = true

Closing as duplicate to #1099.


Using classic array instead of array symbol

Fix #41

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
Non-GitHub Verified Committers
There are 1 commit author(s) whose commits are authored by a non-GitHub verified email address. Chef will have to manually verify that they are authorized to contribute.
Please sign the CLA here.

@RedWhiteMiko any chance you can sign the Chef CLA so they will merge this?

I'm merging this under the obvious fix policy

❤ A policy you can love!


chore(master): release 2.1.15

:robot: I have created a release beep boop
2.1.15 (2024-02-23)
Bug Fixes

deps: update dependency stripe/stripe-php to v13.12.0 (018693d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/laravel-stripe-webhooks/releases/tag/v2.1.15 :sunflower:


unregister package with incorrect gitlab url

As with https://github.com/bower/registry/issues/220 a user (Phil) has registered a package and missed the .git, he was then unable to authenticate to remove the package because he authenticates with github, the transcript can be found in the #support chat in discord.
Hi
quick question
I registered a packagename with a gitlab.com endpoint that is missing the .git in the end...
Now versions don't get picked up.
Anyone here, who can fix this? If there is a donate coffee button somewhere, I'm happy to supply coffee for the task :smiley:
the package in question is dees-header -> change required: add .git to the endpoint
since I cannot login with gitlab I can't do so it myself...
sorry for the trouble

the package name on bower is dees-header

hi, Phil here. :) Would be awesome if we could correct this mistake of mine :) Also looking into submitting a PR with regex validation that prevents submitting gitlab URLS without .git at the end.

@sheerun ... any opinion here? :)

@philkunz I've unregistered it. Hope it helps :)


Change Request queue to bounded

This PR:

Changes Ambry server request queue to bounded
Rejects the response from NettyRequestResponseChannel immediately when queue is full

Codecov Report
Patch coverage has no change and project coverage change: -53.13% :warning:

Comparison is base (9c685c5) 72.62% compared to head (f410c38) 19.49%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2571       +/-   ##
=============================================
- Coverage     72.62%   19.49%   -53.13%
+ Complexity    11354     2725     -8629
=============================================
  Files           804      804
  Lines         64423    64439       +16
  Branches       7864     7865        +1
=============================================
- Hits          46785    12561    -34224
- Misses        15076    50698    +35622
+ Partials       2562     1180     -1382

Files Changed
Coverage Δ

...in/java/com/github/ambry/config/NetworkConfig.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ava/com/github/ambry/cloud/AmbryCloudRequests.java
0.00% <ø> (ø)

.../main/java/com/github/ambry/cloud/VcrRequests.java
0.00% <ø> (-91.67%)
:arrow_down:

...rc/main/java/com/github/ambry/cloud/VcrServer.java
0.00% <0.00%> (-84.94%)
:arrow_down:

.../network/AdaptiveLifoCoDelNetworkRequestQueue.java
0.00% <0.00%> (ø)

.../github/ambry/network/FifoNetworkRequestQueue.java
0.00% <0.00%> (-96.97%)
:arrow_down:

...bry/network/NettyServerRequestResponseChannel.java
0.00% <0.00%> (-70.00%)
:arrow_down:

...hub/ambry/network/ServerRequestResponseHelper.java
0.00% <ø> (ø)

...ub/ambry/network/SocketRequestResponseChannel.java
0.00% <0.00%> (-88.58%)
:arrow_down:

...main/java/com/github/ambry/router/RouterUtils.java
0.00% <ø> (-83.53%)
:arrow_down:

... and 3 more

... and 583 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Missing permission for !pldump

Now that i got the bot registered and working well, i still can't use the !pldump  command.
well, not it gets recognised but i get a "missing permissions" response.
since i am the owner i donT' expect it to be missing on my part (in the bot options) and i have granted the bots server permissions to send files as well, so i really don't know what i am doing wrong here.
https://imgur.com/RNfGRP4
What permissions does it require where?

The bot has no permissions to send files

@arunesh90
it does, it has the group (on discord) "shopkeeper" and thus group is allowed to attach files

foundit , it needs admin priveleges to ... send files ? okey sure ,
case closed


[Go Live][April 21 ]

Push live

Docs Build status updates of commit f14df7a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/TOC.yml
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/currentheadersofbots.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/newheadersofbots.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/bots/requestheaderfields.png
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/conversations/request-headers-of-the-bot.md
:white_check_mark:Succeeded
View

msteams-platform/bots/how-to/rate-limit.md
:white_check_mark:Succeeded
View

msteams-platform/concepts/build-and-test/apps-package.md
:white_check_mark:Succeeded
View

msteams-platform/task-modules-and-cards/cards/cards-format.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


writing to /dev/stderr and docker run --user

When docker runs a container as a non-root user, the permissions for /dev/stdout and /dev/stderr prevents the process in the container to write to it:
$ docker run -ti --rm -u backup ubuntu
backup@057942bb681a:/$ echo test > /dev/stderr
bash: /dev/stderr: Permission denied

This makes it impossible to use /dev/stderr together with the --user option with applications that do not have direct support for logging to stderr, but allow to specify a log file, like php-fpm or rsync.
It would be nice if Docker fixed this.
As a workaround when starting such application I use a wrapper shell scrip that runs the following before starting the application:
mkfifo -m 600 /tmp/logpipe
cat < /tmp/logpipe 1>&2 &

That creates a named pipe and redirects its output to stderr connected to the docker daemon. Then I instruct the application to use /tmp/logpipe as its log file. This works but not very reliable. the cat process can die, for example, on memory pressure or be killed by a bug in other container processes.
This is on docker 1.8 under CoreOS:
Client:
 Version:      1.8.3
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   cedd534-dirty
 Built:        Sat Dec  5 05:57:26 UTC 2015
 OS/Arch:      linux/amd64

Server:
 Version:      1.8.3
 API version:  1.20
 Go version:   go1.4.2
 Git commit:   cedd534-dirty
 Built:        Sat Dec  5 05:57:26 UTC 2015
 OS/Arch:      linux/amd64

Containers: 41
Images: 786
Storage Driver: overlay
 Backing Filesystem: extfs
Execution Driver: native-0.2
Logging Driver: json-file
Kernel Version: 4.2.2-coreos-r1
Operating System: CoreOS 835.9.0
CPUs: 1
Total Memory: 1.335 GiB
Name: thip
ID: AQKH:JESB:XWHG:VEIF:BZIX:IQNL:Q7UH:PBS3:KRCT:4W72:OCNM:TAOU

If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
For more information about reporting issues, see CONTRIBUTING.md.
You don't have to include this information if this is a feature request
(This is an automated, informational response)

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

This is a dup of #6880


Performance differences between spawn() and spawn_bash()

Hello, this is perhaps not an issue, but I've been experimenting with the crate and notice the following behavior:
If I get a PtyReplSession with spawn_bash(Some(timeout)), and then use p.execute(command, ready), the time it takes for this to successfully return is directly related to timeout regardless of the time it actually takes command to reach ready. The higher the timeout, the longer it takes (but it returns Ok), and viceversa (though at a certain point, very small timeouts will fail to find ready).
If I get a PtySession with spawn(command, Some(timeout)), and then use p.exp_string(ready), the time it takes for this to successfully return is independent of timeout. I can change timeout as much as I want (as long as I don't make it too small), and the time to successfully return will remain constant. If ready is not found, the timeout works as expected.
I wouldn't expect the execution time of command to change when running in a PtySession vs a PtyReplSession. Could you explain why this happens? Is it a bug or am I missing something?
Example code with PtyReplSession:
let mut bash_session = spawn_bash(Some(10000))
.expect("session failed");

bash_session.execute("hostname", "mypc")
.expect("command failed");

Example code with PtySession:
let mut session = spawn("hostname", Some(10000))
.expect("session failed");

session.exp_string("mypc")
.expect("command failed");

Here are some test results:
Test: PtyReplSession with 2,000ms timeout:
running 1 test
test pruebas_rexpect::with_pty_repl_session_timeout_2000 ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.42s

Test: PtyReplSession with 10,000ms timeout:
running 1 test
test pruebas_rexpect::with_pty_repl_session_timeout_10000 ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 10.45s

Test: PtySession with 2,000ms timeout:
running 1 test
test pruebas_rexpect::with_pty_session_timeout_2000 ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.19s

Test: PtySession with 10,000ms timeout:
running 1 test
test pruebas_rexpect::with_pty_session_timeout_10000 ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.16s

spawn_bash waits for bash to exit, which is always timeout unless bash exits or the stream is otherwise interrupted.
spawn will terminate immediately after the command that it executes finishes.
Basically, PtyReplSession is supposed to be interactive, waiting for additional input and providing the output. I think that timeout should rather be set on the execute function instead, since it would track the execution of the particular command, not of the session.

Yes, I agree with setting the timeout on the execute function, however if PtyReplSession is intended just for interactive use, then the "correct" session for automation/non-interactive use would always be PtySession, right?


dm branch should support creating new branches

currently dm branch only lists branches. it should also support dm branch <newbranch> syntax, which creates a new branch (see also #231) without checking it out.

This is possibly part of #251

Reopen when needed/when there's time/priority


My macOS Setup stuck on 30hours

I think my internet is good, but installation is says 30 hours left to finish install.

Just wait overnight, this is pretty normal

OK, I'll check and let you know later

I wanna ask, will I need to run basic.sh for start my machine everytime?

Yes

No, you can use virt-manager.

Yeah either or works


Bump version/2.1.0

No idea why github decided to make a pull to you closing haha

LOL! That's weird!


Access through clusterip very slow on other node but works well using nodePort

I installed flannel like that
kubectl apply -f https://raw.githubusercontent.com/coreos/flannel/master/Documentation/kube-flannel.yml
my svc:
kubectl get svc
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
api-gateway NodePort <IP_ADDRESS> 5555:30555/TCP 46m
when I curl <IP_ADDRESS>:5555/test/1 for testing ,but responsing very slow in other node . more than 1 minute.
It works well using curl nodeip:30555/test/1

@cy503328434 I had the same problem

@kadisi if you used aliyun, you can change the backend type with ali-vpc ```
"Backend": {
"Type": "ali-vpc"
}
It's words well on my k8s cluster.


Fix bad overwrite param passing from "e2e-tasmax"

In a recent e2e-tasmax test run I noticed that the "download" steps where using "{{workflow.parameters.overwrite}}" as their argument for overwrite. This indicates that the "{{workflow.parameters.overwrite}}" never had the opportunity to evaluate to "true" or "false" or some user input.
This PR fixes this bug by changing the download-gcm template in workflows/templates/download-cmip6.yaml so that it only accepts "true" or "false" and raises ValueError otherwise.
In addition, overwrite is now set to "false" by default in with-jobs -- the WorkflowTemplate's entrypoint -- and passed through to the pod, instead of forcing the pod to grab it from the global workflow.parameters. In other words, overwrite should be passed as an explicit argument rather than quietly grabbed from a (potentially non-existent) global variable. This PR makes that fix.

@emileten, I mentioned I would tag you on PRs to get a feel for things. Here is an example of a bug in an argo workflows because it tried to grab a global parameter that didn't exist in that e2e-tasmax run we were looking at during our check-in. Just FYI.

@emileten, I mentioned I would tag you on PRs to get a feel for things. Here is an example of a bug in an argo workflows because it tried to grab a global parameter that didn't exist in that e2e-tasmax run we were looking at during our check-in. Just FYI.
This kind of bug, with double-braces in a string like this, can be common on new workflows.

@brews thanks. So If I understood well this is a 'bug' (it didn't actually had the chance to provoke a bug, did it ? You caught it thanks to something else you were looking at right?) instance where a parameter (overwrite) was being passed an upstream value ("{{workflow.parameters.overwrite}}") rather than a value that could be passed to it by a closer function.

@emileten The run you triggered had a bug in it (not your fault). The bug did not have large consequences in our run.
You're absolutely correct in that it passed "{{ workflow.parameters.overwrite }}" rather than "true" or "false" (because workflow.parameters.overwrite didn't exist). If you see these {{ and }} with names like this in python or somewhere, it's usually because a parameter in argo worfklows didn't evaluate or get resolved. I can almost guarantee that you'll see similar bugs at some point in your future work.


support multiple client connections

if you're already using poet and a client connects put a notification on the screen and provide a command to view current clients and switch between them. have the prompt reflect which one you're on via number and maybe hostname/os or something

Any progress on this feature?

Nope, sorry :) Thanks for letting me know you’re interested in this feature though, I’ll prioritize it!

On Aug 19, 2015, at 5:31 PM, Alex Nelson<EMAIL_ADDRESS>wrote:
Any progress on this feature?
—
Reply to this email directly or view it on GitHub.


fix: remove special case for single-bot view in tree

Description
This removes the check to see if a bot is alone in a project; it was needed so the tree would look right before the BotProject branch was merged in. Now that we need to see the bot headers all the time, though, we shouldn't do that check.
Task Item
closes #4797
Screenshots

Nice!!
@zhixzhan this is the fix for the single bot context.


Add override method and docs

Codecov Report

Merging #18 (822a41a) into main (65a91be) will not change coverage.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            6         6
  Lines          439       481   +42
=========================================
+ Hits           439       481   +42

Impacted Files
Coverage Δ

pyxdi/core.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Building mini doesnt start after it has exhausted resources

Building mini doesnt start building mini after the resources available again.

Fixed


Q encrypt data with pbkdf2 generated key from String

How to encrypt/decrypt with keys created with pbkdf2 from String password

I need to create a private:public key pair password protected

Hey, @freedom1b2830.
We can only help with questions that are specifically and directly related to the articles - not with your own, custom application.
Are you having an issue with the information in a specific article? If that's the case, please include a link to it and more information about what's not working.
Cheers,
Team

Closed due to lack of activity.

@ulisseslima
I finally found what I was looking for.
here is aes from PBKDF2WithHmacSHA256
https://www.baeldung.com/java-aes-encryption-decryption


Searching for classes stops working after selecting an individual in the search results

Description of the issue
Searching for classes stops working after selecting an individual in the search results
When I first go to VFB, I can find classes in my search results

But after I select any individual from a search results list (but not from navigating via term info query or thumbnail), subsequent searches no longer return classes

It starts working again after going back to https://v2.virtualflybrain.org/ in the same tab (no refresh or cache clear needed)
Browser

[ ] All of them
[x] Chrome
[x] Firefox
[ ] Internet Explorer

OS

[ ] All of them
[ ] Windows
[x] macOS
[ ] Linux
[ ] Android
[ ] iOS

another example - 'scRNAseq' gives results after a refresh, but stops working after selecting 'MBON02(B2B'2a)_L (FlyEM-HB:5813022341) [VFB_jrchk0e5]' individual from a search


fix: one-click-review-submission to reflect GitHub's restructure of that modal

Fixes #6963.
GitHub have changed their review submission modal so that it:

now has the radio buttons properly nested in a form
the radios' labels are not adjacent siblings anymore

Test URLs
This PR??
Screenshot

https://github.com/refined-github/refined-github/assets/609062/be30dd75-a894-49e4-8023-9d7994165440
Description tooltips

Not sure if it is considered better or not but I was able to get the button text by replacing {radio.nextSibling} with {radio.labels[0].innerHTML}.

Not sure if it is considered better or not but I was able to get the button text by replacing {radio.nextSibling} with {radio.labels[0].innerHTML}.

Thanks @capfei, I like this suggestion
@fregante do you have a preference?

It's safer to deal with nodes, innerHTML triggers extra checks by Mozilla https://stackoverflow.com/q/45579400/288906
Also I'm not sure I see the advantage in your later commit. It's best to use selectors and limit index-based ([0]) and repeated DOM traversing (nextElementSibling)
Something you could optimize for would be to maintain compatibility with the older version so that we don't break GitHub Enterprise users

It's safer to deal with nodes, innerHTML triggers extra checks by Mozilla stackoverflow.com/q/45579400/288906

This is useful, thanks. I still kept textContent instead of innerHTML - does that mitigate the above?

Something you could optimize for would be to maintain compatibility with the older version so that we don't break GitHub Enterprise users

Ah yes, what's the usual process with this? When features get yolo-disabled I assume that also disables for GHE users?

This is useful, thanks. I still kept textContent instead of innerHTML - does that mitigate the above?

textContent is perfectly fine 👍

GitHub Enterprise users

Ah yes, what's the usual process with this?

It depends. For less visible features we just make the changes and wait for GHE users to open issues or submit patches, if they're necessary.
This feature is rather visible and quite important, so we can't risk breaking GHE users like #6963.
For GitHub changes that are introduced via Feature Preview, it's easy to toggle back and forth and see both DOM versions. In this case:

we write code that can work in both cases (e.g. keep the form attribute), OR
we use detection (e.g. if this element exist, OLD CODE, otherwise NEW CODE), keeping the changes to a minimum, OR
we keep a whole new copy of the code in cases where that detection makes the code too messy. See #

I suggest trying the first one, then we can tag a GHE user to test it out.

When features get yolo-disabled I assume that also disables for GHE users?

Yes. That also means that if we ship a feature that breaks GHE, we have to yolo-disable it on GitHub.com too

@busches can you paste the form’s HTML here so that we can work on a compatible fix?

Here's what it looks like on GHE 3.9.4:

Here's the HTML:
modal.txt

I've hit two conflicting lint rules.
I want to use a logic OR for the label fallback; I can't use nullish coalescing operator because the "old" label will be an empty string if it doesn't exist. So I changed to use a ternary op a ? a : b which tbf is called out, and is worse imo.
Should I lint-ignore the nullish operator one or what? Is that only because it doesn't have enough type information?

I hope to see this completed soon so I can merge it ☺ if you see any awkward lint errors you can leave them broken and I'll take care of them

@busches could you help bring this over to the finish line so I can publish it without having to disable the feature on GHE?

@fregante I probably won't have time till Friday to take a look. If you have something to test, I get to that tomorrow.

All good now. Testing for the GHE version was as easy as pasting that HTML replacing the original <form>, and the selector-observer automatically reapplied the changes.  Thanks @busches!
I also made a change that was long overdue: I dropped the green background from the "comment" button. It was technically correct (green = default action, on GitHub) but it was confusing (green = approval)


Python: added function_name and plugin_name properties to FC and FCR

Motivation and Context

Fixes #6258
Description

Contribution Checklist

[x] The code builds clean without any errors or warnings
[x] The PR follows the SK Contribution Guidelines and the pre-submission formatting script raises no violations
[x] All unit tests pass, and I have added new tests where possible
[x] I didn't break anyone :smile:

Python 3.10 Test Coverage Report • FileStmtsMissCoverMissingsemantic_kernel/contents   function_call_content.py62592%28, 35, 37, 84, 91   function_result_content.py44589%51, 55, 70, 95, 100TOTAL5889104482%
Python 3.10 Unit Test Overview

Tests
Skipped
Failures
Errors
Time

1291
1 :zzz:
0 :x:
0 :fire:
11.293s :stopwatch:


TS.4.a: Prototype predicate translation service - continuous integration

Related:
TS.4: Prototype predicate translation service
TS.4.b: Prototype predicate translation service - documentation

Unit tests covering edge resolution and ubergraph queries successfully running in travis-ci


React Native fails to resolve module due to mjs extension

Hi,
Great work with the library! Really liking it as a mst user.
However I think I have discovered a packaging bug with the library when used in a react native project. The metro bundler can not resolve this module and throws the following error:
Error: While trying to resolve module `mobx-keystone` from file `/home/kuasha/Dev/RNKeystoneBug/src/stores/keystone.tsx`, the package `/home/kuasha/Dev/RNKeystoneBug/node_modules/mobx-keystone/package.json` was successfully found. However, this package itself specifies a `main` module field that could not be resolved (`/home/kuasha/Dev/RNKeystoneBug/node_modules/mobx-keystone/dist/mobx-keystone.esm.mjs`. Indeed, none of these files exist:

  * /home/kuasha/Dev/RNKeystoneBug/node_modules/mobx-keystone/dist/mobx-keystone.esm.mjs(.native|.android.js|.native.js|.js|.android.json|.native.json|.json|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx)
  * /home/kuasha/Dev/RNKeystoneBug/node_modules/mobx-keystone/dist/mobx-keystone.esm.mjs/index(.native|.android.js|.native.js|.js|.android.json|.native.json|.json|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx)

This is because Metro Bundler does not recognize .mjs as a valid module file extension and tries to creatively resolve it. And in the react-native field of package.json, it points to the .mjs file.
https://github.com/xaviergonz/mobx-keystone/blob/ecd6cbad9fcd3d9840f3a9ee63b48c68258cc25f/packages/lib/package.json#L37
I can confirm that all of the following method fixes the issue-

Use the umd module with js extension.
Directly load the index.ts file from source
Rename the file from mjs to js in both filesystem and the react-native field of package.json.

ie. Either of the following works:
"react-native": "./src/index.ts",
// or
"react-native": "./dist/mobx-keystone.umd.js",

I think react native ecosystem prefers putting the actual un-transpiled source in the react-native field and it's done on the libs generated with callstacks' react-native-builder-bob. However, I'll leave that decision to you.
Would love to have it fixed soon so I can get rid of the patch-package solution.
Cheers.
Repro: https://github.com/kuasha420/rn-keystone-bug

Thanks! in the end I went for using the umd version (it feels kind of weird using a .ts file as entry point for a bundle...).
It should be fixed now in v0.68.4

@xaviergonz Thanks for the super quick fix. I can confirm that it's been fixed.
Off Topic: I think the rational behind pointing to the un-transpiled entry for react-native is, Metro transpiles them more optimally for the react-native environment (for their flavor of jsc/hermes). I don't think it makes much of a difference anyway. However, is there any other reason why you're including the src in the npm package if not for react-native? Just curious.
Have a good one.

To be honest I don't remember why src is being included anymore :)


Craft 4 support

I was wondering if this plugin will be supported for Craft 4, or if Redactor for Craft 4 supports aria labels by default?

No plans to update this, especially since the Redactor plugin is no longer getting updates. I suggest you switch to CKEditor instead.


Add note about pre-create check and exit code

Requires: https://github.com/docker/machine/pull/2807
Signed-off-by: Nathan LeClaire<EMAIL_ADDRESS>

cc @docker/machine-maintainers PTAL
Blarg, docs are failing.  @SvenDowideit @londoncalling ?

@SvenDowideit (per @moxiegirl) it looks like you need to kick off another Docs build here, and neither of us have Jenkins permissions right now. Sven can you please re-kick this build? Thanks!

Merged with https://github.com/docker/machine/pull/2826

:+1:


use latest onSlideChange in Carousel

Changes
Instead of only using the first reference to the onSlideChange prop, the latest version will be used any time it changes. This avoids issues where the stale callback was being invoked instead of the current one.
Testing
Tested this sandbox locally: https://codesandbox.io/s/itwinui-react-example-carousel-forked-j2fksk?file=/src/App.tsx
clicking next/prev buttons after changing the gradient state logs the correct count now ("3" instead of "10")
https://github.com/iTwin/iTwinUI/assets/9084735/f3f4f68c-ce32-4655-838b-c1b0103f95ca
Docs
Changeset added.

To confirm, is it alright for the onSlideChange() callback to be called after each button click? I don't see it happening in your video. But it is happening for me when I implement something locally that is similar to the codesandbox code.
1.webm

To confirm, is it alright for the onSlideChange() callback to be called after each button click? I don't see it happening in your video. But it is happening for me when I implement something locally that is similar to the codesandbox code.

hmm, i don't think onSlideChange should be called unless a slide is actually changed, so this sounds like a bug. however, this is a completely different issue and no one has complained about it yet; we can look into fixing it at some other point (maybe in v3?)


Port code to Terraform v0.12.x

Tested using examples from the repo.

Unfortunately, we no longer support Terraform 0.12 for any of our modules. See the versions policy  https://github.com/trussworks/Engineering-Playbook/tree/main/infrasec/terraform#version-support-policy


The tests fail on a clean install

Description
The tests fail on branch main with a clean setup.
How To Reproduce

Clone the code
Follow the readme instructions to run the tests

Investigation
Here are some things making it break:

Versions are not pinned in requirements.txt (in particular the latest version of pvsite_model contained breaking changes)
The tests are calling real prod API it seems, which fail with 401 errors
The tests fallback on sqlite when not running in postgresql, which adds to the confusion
This error comes up often when I try to make things work in a hacky way: Error loading configuration parameter api_key from config file /home/simon/.pvoutput.yml

Recommendations

Pin the versions (using "^=" rules for external repos and "==" for OCF repos). I recommend using poetry because it allows for both defining flexible rules AND a lock file with hard pinned rules.
Use testcontainers instead of docker-compose (like we do in other repos) and run tests using pytest directly
Remove references to sqlite
Mock external APIs. If we want to keep tests that use the real API they should be optional tests and not run by default.

CC @peterdudfield

Thats bad, sorry about this. I hate it when things are broken like this

Let me have a quick look to see what is failling

Yea sorry it should have been pinned to a version

I solved it, but my feeling is the upgrade due to #52 should also be able to solve it

btw  pvsite_datamodel=0.1.7 should make it work

I don't think I have tried 0.1.7 but 0.1.6 did not work (I must've rounded to the wrong version when trying to find which should work)!
But some tests assume some local environment (a $HOME/.pvoutput.yml file) and if I'm not mistaken some call an external API, which is a very bad idea. Also there were some requests errors that could be due to change in the requests library, I'm not sure.

i looked at the last github actions to be successful, and i think ti was 0.1.7

This was mostly fixed in
#53
#55
We decided to keep the tests calling external APIs for now, which are still broken but I opened a new ticket just for those: #54


Keep Kestrel's connection PipeReader in a consistent state

When the request body PipeReader.ReadAsync throws, the connection-level
pipe should be advanced, so subsequent attempts to read from the
connection-level pipe don't fail unnecessarily

TODO: Add test
Addresses #14727

Needs @Pilchie approval to get it in, and we need to get it in today for preview3 (without QB approval).

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=412158

This comment was made automatically. If there is a problem contact<EMAIL_ADDRESS>I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/3154

@jkotalik this is ready.


Use structured data in LAMMPS driver

Description
LAMMPS at some point in time improved how their log files are structured, in particular using YAML outputs in some places. This might be easier to deal with than throwing around text files like I used to do back in the day.

Alternately, one could also make use of the LAMMPS python API (specifically the get_thermo() method) and avoid parsing log file text altogether. I have a [basic implementation of this mechanism in my own package[(https://github.com/timbernat/polymerist/blob/dev/lammpstools/lammpseval.py#L72-L87) which only requires reading an input file (which can easily be produced from and Interchange using MDConfig

Wow, thanks - I didn't know their Python wrapper was so powerful. (Maybe I have bad memories trying to build it a decade ago)
In [1]: import lammps

In [2]: wrapper = lammps.lammps()
LAMMPS (21 Nov 2023)
OMP_NUM_THREADS environment is not set. Defaulting to 1 thread. (src/comm.cpp:98)
  using 1 OpenMP thread(s) per MPI task

In [3]: wrapper.file("tmp.in")
Reading data file ...
<SNIP>

In [4]: wrapper.last_thermo()
Out[4]:
{'E_bond': 0.6693447327557421,
 'E_angle': 5.421066567990172,
 'E_dihed': 29.942338413279195,
 'E_impro': 0.0,
 'E_pair': 4.391198970972843,
 'E_vdwl': 3.063124265386531,
 'E_coul': 8.296528734676809,
 'E_long': -6.968454029090497,
 'E_tail': -0.0014512577854809076,
 'PotEng': 40.42394868499795}

I think this was taken care of in #903


ENOTFOUND artprod.dev.bloomberg.com

After npm install on master
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile
npm WARN deprecated<EMAIL_ADDRESS>Please update to ini >=1.3.6 to avoid a prototype pollution issue
npm WARN deprecated<EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated<EMAIL_ADDRESS>Fixed a prototype pollution security issue in 4.1.0, please upgrade to ^4.1.1 or ^5.0.1.
npm WARN deprecated<EMAIL_ADDRESS>"Please update to latest v2.3 or v2.2"
npm WARN deprecated<EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm WARN deprecated<EMAIL_ADDRESS>Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
npm ERR! code ENOTFOUND
npm ERR! syscall getaddrinfo
npm ERR! errno ENOTFOUND
npm ERR! network request to http://artprod.dev.bloomberg.com/artifactory/api/npm/npm-repos/tslib/-/tslib-1.10.0.tgz failed, reason: getaddrinfo ENOTFOUND artprod.dev.bloomberg.com
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

npm ERR!      /Users/daniel/.npm/_logs/2021-10-09T16_30_43_704Z-debug.log

But this domain artprod.dev.bloomberg.com really do not works.
My log file
... many Completed in x ms
1779 timing reifyNode:node_modules/rxjs Completed in 4001ms
1780 timing reify:rollback:createSparse Completed in 1759ms
1781 timing reify:rollback:retireShallow Completed in 0ms
1782 timing command:install Completed in 80025ms
1783 verbose type system
1784 verbose stack FetchError: request to http://artprod.dev.bloomberg.com/artifactory/api/npm/npm-repos/tslib/-/tslib-1.10.0.tgz failed, reason: getaddrinfo ENOTFOUND artprod.dev.bloomberg.com
1784 verbose stack     at ClientRequest.<anonymous> (/Users/daniel/.nvm/versions/node/v14.17.0/lib/node_modules/npm/node_modules/minipass-fetch/lib/index.js:110:14)
1784 verbose stack     at ClientRequest.emit (events.js:376:20)
1784 verbose stack     at Socket.socketErrorListener (_http_client.js:475:9)
1784 verbose stack     at Socket.emit (events.js:388:22)
1784 verbose stack     at emitErrorNT (internal/streams/destroy.js:106:8)
1784 verbose stack     at emitErrorCloseNT (internal/streams/destroy.js:74:3)
1784 verbose stack     at processTicksAndRejections (internal/process/task_queues.js:82:21)
1785 verbose cwd /Users/daniel/pro/hn/ioredis
1786 verbose Darwin 20.6.0
1787 verbose argv "/Users/daniel/.nvm/versions/node/v14.17.0/bin/node" "/Users/daniel/.nvm/versions/node/v14.17.0/bin/npm" "i"
1788 verbose node v14.17.0
1789 verbose npm  v7.22.0
1790 error code ENOTFOUND
1791 error syscall getaddrinfo
1792 error errno ENOTFOUND
1793 error network request to http://artprod.dev.bloomberg.com/artifactory/api/npm/npm-repos/tslib/-/tslib-1.10.0.tgz failed, reason: getaddrinfo ENOTFOUND artprod.dev.bloomberg.com
1794 error network This is a problem related to network connectivity.
1794 error network In most cases you are behind a proxy or have bad network settings.
1794 error network
1794 error network If you are behind a proxy, please make sure that the
1794 error network 'proxy' config is set properly.  See: 'npm help config'
1795 verbose exit 1

Hi @gustawdaniel,
There was an issue in package-lock.json as it contained http://artprod.dev.bloomberg.com as your log shows. However, it've been fixed several days ago. Can you pull the latest changes and try again?


[enh] Use islice rather than slice in order to work with generators.

Right now, you select the data using []. itertools.islice stills works on sequences, but also works on generators, which is useful when there is a lot of data to go through.
Specifically, I think replacing this line: https://github.com/uriyyo/fastapi-pagination/blob/b6e287524cffa628e76b87e79d5cab0e6f579035/fastapi_pagination/paginator.py#L17 would be sufficient to add the functionality while changing nothing in the existing API.
The line would become
items=list(it.islice(sequence, raw_params.offset, raw_params.offset + raw_params.limit]),
(after import itertools as it).
What do you think?

Hi @masasin,
It looks amazing and very useful.
Would you mind to implement this feature?)

I tried submitting a pull request, but the tests are all failing. I can't quite figure out why, and I'm not able to install the environment (EnvCommand error when trying to install psycopg2), so I can't test locally. Can you take a look?

psycop2 is the postgres driver. Happy to take a look or would it be useful to add a dockerfile to the project to help reproduce the error and have a consistent development environment setup?

How can I help? Eager to see this resolved!

I think we should introduce new paginator that will be able to work with iterables. Also we should add new pages classes that will not contains total field as far as we don't know how many elements are in a iterables and it is not possible to calculate it for infinity generators.
Thats my idea, I am happy to hear yours opinion🙂


godep issue

Hi,
As the Godep's README says:
Godep does not copy:
- files from source repositories that are not tracked in version control.
- _test.go files.
- testdata directories.

However, proto/proto3_proto/proto3.pb.go, which is not named as a test file, imports proto/testdata. Thus, any go app that relies on protobuf or that has a dependency using protobuf could vendor its deps using godep. Some other vendoring tools don't include test files by default either.
A simple work-around would be to use godep save -t ./... to vendor test files as well but I believe that it is not the right approach.

I'm not too familiar with godep. Can't you just delete proto/proto3_proto/proto3.pb.go in your vendored copy?

@dsymonds I generally think people try to avoid adding custom modifications regarding vendoring, as it means you're likely to experience conflicts later down the line. Could the subdefaults stuff be moved into it's own package separated from the testdata package so we don't have to pull in all the testdata package?

Sorry, I don't feel the need to bend to Godep's conventions on this.

@dsymonds I think this is an issue with any vendoring solution, not just Godeps. It's rather annoying to have to make manual edits especially. I don't think anyone wants to maintain patches to their vendored libraries either.

It's only an issue with a vendoring tool that drops parts of the repo. Perhaps Godeps could check that its pruning isn't going to leave a dangling dependency edge.


Enable helm-tool linter and schema generator

Enabling these two features that were added in the Helm module:
https://github.com/cert-manager/approver-policy/blob/dea7ee83b25b9778e021dae9ecaf5636aec16f90/make/00_mod.mk#L42-L43

/approve


['!cols'] is undefined

I am trying to modify XLS files and keeping the visibility values for columns.
I am using ^0.14.3 inside a web worker with Angular ^8.0.0.
However, whenever I read an XLS file, ['!cols'] is not defined in the worksheet object, even though there are hidden columns in the file. So it is impossible for me to retrieve the 'hidden' values for the columns.
Am I missing something? !ref and !margins are there.
Here's the web worker code:
/// <reference lib="webworker" />

declare function importScripts(...urls: string[]): void;

declare function postMessage(message: any): any;

declare const XLSX: any;

addEventListener('message', ({ data }) => {

    let str = `${data.window.protocol}//path/to/xlsx.full.min.js`;

    importScripts(str);

    const xls = XLSX.read(data.file, { type: 'array' });

    const sheet = xls.Sheets[xls.SheetNames[0]];

    console.log(sheet['!cols']);    // returns undefined

    // (...)

    postMessage(xls);

});

Below function sits in a service and spins up a Worker for every file from a FileList
loadXLS(files: FileList, values: {}, loc: string) {
        Array.from(files).forEach(file => {
            const worker = new Worker('../excel.worker.ts', {
                type: 'module'
            });
            const reader: FileReader = new FileReader();
            reader.readAsArrayBuffer(file);
            reader.onloadend = (e: any) => {
                worker.onmessage = ({ data }) => {
                    XLSX.writeFile(data, file.name);
                };
                worker.postMessage({ file: new Uint8Array(e.target.result), locale: loc, val: values, window: this.inputWindow });
            };
        });
    }

Here's a branch that provides an implementation example: https://github.com/fripso/kupshred/tree/missingcols

It should always be present in XLS if a column is hidden.  Can you share a sample file?

hidden.xlsx
This file has a hidden column B.

console.log(xls.Sheets[xls.Sheetnames[0]]);

Console returns:
!margins: {left: 0.7, right: 0.7, top: 0.75, bottom: 0.75, header: 0.3, …},
!ref: "A1:C1",
A1: {t: "s", v: "Alpha", r: "<t>Alpha</t>", h: "Alpha", w: "Alpha"},
B1: {t: "s", v: "Beta", r: "<t>Beta</t>", h: "Beta", w: "Beta"},
C1: {t: "s", v: "Charlie", r: "<t>Charlie</t>", h: "Charlie", w: "Charlie"}

i also have encountered this porplem.  how to fixed it

@fripso i have the same proplem;

first,['!cols'] is not defined;seconde.
The range is also wrong,onley have one row data.the second and the third row is missing.

i have fixed the second problem.it it because the read the file data by Uint8Array. but the ["!cols"] is still undifined

i tryed this , and the problem fiexed

@fripso for XLSX format, cellStyles: true must be set to extract column metadata.
@cjl-df "range is wrong" is almost always an issue in the file.  XLS has a Dimension record and XLSX also has a way of specifying range, so the reader will set the range based on what that file reports (even if cells exist outside).  We'd be glad to take a look at a sample file if you can share one

but how to decide the font style


[SPARK-49201][PS][PYTHON][CONNECT] Reimplement hist plot with Spark SQL

What changes were proposed in this pull request?
Reimplement hist plot with Spark SQL
Why are the changes needed?
Reimplement hist plot with Spark SQL to support Spark Connect, since the pyspark.ml.feature.Bucketizer has not been supported with Spark Connect.
Does this PR introduce any user-facing change?
yes, follow plotting functions are enabled in Spark Connect:

{Frame, Series}.plot.hist
{Frame, Series}.plot(kind="hist", ...)

How was this patch tested?
1, enabled parity tests;
2, manually check with:
import pyspark.pandas as ps
import pandas as pd
import numpy as np

np.random.seed(123)
df = pd.DataFrame(np.random.randint(1, 7, 6000), columns=['one'])
df['two'] = df['one'] + np.random.randint(1, 7, 6000)
df = ps.from_pandas(df)
df.plot.hist(bins=12, alpha=0.5)

before (Spark Classic):

after (Spark Connect):

Was this patch authored or co-authored using generative AI tooling?
No

Merged to master.


Popover only shows up after a transition or alert in the same view controller

I noticed that the popover in my app wasn't showing consistently. I kept playing around and figured out that the popover only starts appearing after a transition or alert(perhaps other conditions can work too, but these are the only two I've found so far) on the view controller has occurred.
Other UI changes such as changes in frames of the embedded views in the view controller don't affect it at all. I stepped through the popover initialization in the debugger and any popover before an alert or transition would have a containerView and contentViewFrame that are both nil.
Perhaps has to do with the view/window that popover is presenting from? How can I fix this?

Was able to fix by changing this line in the show function of the Popover
guard let rootView = UIApplication.shared.windows.last ?? UIApplication.shared.keyWindow else {
return
}
changed to
guard let rootView = UIApplication.shared.keyWindow else {
return
}


Issue/6501 wrong error message int (#6870)

Pull request opened by the merge tool on behalf of #6870

Merged into branches iso6 in d95dbbf2571535a10d8b531575b9a3e7cdee999d


Feature/identifier

Adds Identifier to content types

Resolves #72
DCO 1.1 Signed-off-by: Sam Richard<EMAIL_ADDRESS>

@scottnath This resolves #72, in fewer LOC, without potentially tripping over #53. I'd recommend merging this instead.

And the install issues that seem to be plaguing you don't seem to be plaguing this


Game crashes if gravel falls

Make any gravel fall at all and the gravel will then crash the game.
Other mods were enabled during testing, but disabling them did not correct the issue, only disabling this one did

This issue is known, and you would know if you were on the Legacy4J Discord server, this issue is simple and will be resolved in the next update, it has not been fixed yet due to features not being completed in the version when I discovered this issue.

It also affects sand, and concrete powder, pretty much any falling block.


Feat/scala3 hermant

attempt at scala3 support based on feat/branch.
What is it about:

we had to change config derivation for scala3 ... it's not source compatible with scala2 so i needed to create specific code for all pureconfig modules for scala-2 and scala-3 codes. See docs here: https://pureconfig.github.io/docs/scala-3-derivation.html

Whats missing:

[ ] rewrite few tests for scala3 that are now just for scala2
[ ] docs about pureconfig and scala3

What had to change:

in check task we now only check mdoc task for scala3 (we used to do it for all scala versions) - i don't know how to check it for all considering source code is now diverging for scala2 and scala3
few scalafix options had to be removed as they are scala2 only. I believe it's ok because scala3 is now the 'main' dialect and therefore we apply scalafix just for it, other scala versions are just xcompiled
scala3 pureconfig modules no longer support camel case - that is a limitation of pureconfig, we just reflect the change (see https://pureconfig.github.io/docs/scala-3-derivation.html)

wohoo finally green

(marked as draft so that it's not merged until everything is in place)

ok i think this is ready for review if anyone else is interested

Solved all the comments, im going to merge this once all checks pass. Next steps for me is to massage the code into more scala 3 style of code. I will leave it up to @jakubjanecek to release this once he feels like it

thanks for taking the time to review


Improve Menu Creation Tools

The Menu Creation tools are not very easy to use, nor are they as accessible as they should be. They should be redesigned so that they can be editing in the Page Builder instead of the Administration Panel.

This has been implemented


⚠ Bofrost.be has degraded performance

In b4601ec, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1700 ms

Resolved: Bofrost.be performance has improved in 0de0e2c.


Token Vision PF2e

Hi,
looks like the token vision in pf2e is broken.
Selecting a token with "has-vision" activated, removes all non-invisible tokens from the screen.
https://streamable.com/g282fd

The same issue is happening on DND 5e

This is probably a module conflict. Do you get errors in the console (F12 -> Console)? Did you try whether if works when PV is the only active module? If it's a module conflict, you can use Find the culprit to figure out which module is causing the conflict.

There were no module conflicts in the console yesterday, but i didn't try to deactivate every other module.
Release 2.5.0 fixed it, so i can only guess that it was the low-light vision problem?
The only module i use from the release notes is Sequencer, but that one was deactivated at the time of my test.
Thx for the great work!

Good to hear it was accidently fixed. Nice!


feature: Add support for Markdown gherkin syntax

Feature: Add support for gherkin syntax.
Why?
Gherkin supports Markdown syntax for rich text documents.  The ability to include images is compelling to improve readability of scenarios and generating living documentation overall.
What
I have raised this PR as a draft to start discussion - it is still WIP.
Where to start:

I have added a new markdown feature file.  This is not comprehensive, but based on the documentation and (superficial) review of the Gherkin parser test I don't think it needs to be - the resulting AST should be the same irrespective of the Gherkin flavour.

If there were any inconsistencies here, I would consider this to be an upstream dependency issue to be resolved in the gherkin project.

I have added a new markdown feature file to demonstrate multi-language support.
Supporting Markdown through the GherkinInMarkdownTokenMatcher required upgrading the gherkin dependency.  Issues have been resolved.
It's encouraging to see that the code generation snippet suggestions "just worked".  Example Jest output:

 FAIL  specs/step-definitions/markdown-support.steps.ts
  ● Test suite failed to run

    Feature file has a scenario titled "Simple addition", but no match found in step definitions. Try adding the following code:

    test('Simple addition', ({ when, then }) => {
        when(/^I add (\d+) + (\d+)$/, (arg0, arg1) => {

        });

        then(/^the result should be (\d+)$/, (arg0) => {

        });
    });

I have also added VSCode development container configuration, since that matches my workflow

I can remove them from the PR if required
They have had no customisation

I haven't added documentation at this point - would like an initial review and some thoughts on what you'd like documentation wise before I spend the effort
TODO

[x] Make unit tests pass
[x] Clean up the code
[ ] Documentation

@bencompton.
Do you have any timeframe on when you will be able to review this?
I think Markdown is a much richer format for living documentation and think this will be a great addition.
The code is tested and (hopefully) fairly clean

Sorry this PR collected dust so long, and I'm making an effort to better maintain this repo now. I really love the idea of markdown, and it's something I'd even like to start using myself. Definitely want to get this merged once the following is addressed:

Need to merge in latest from master
There are some code style issues, which should be easy to address with the recent contributions from @pplancq
The dev container changes are unnecessary, IMO. I mostly do k8s stuff myself these days and have no problem with containers in general for deploys, but I generally don't like containers for local development.
Needs docs
The specs provided should be moved to examples, and this also needs acceptance tests that cover the functionality like the other specs in this repo.
The dialect changes would ideally be in another PR, though maybe I'm misunderstanding and it really needs to be in the same PR.

I'm happy to make these changes myself since this PR was ignored so long, but it may be a while before I'm able to circle back around to this.


Get tests passing

@nmaterise I had to comment Mattis-Bardeen from requirements.txt because it cannot be pip installed by symbol.
I disabled warnings for pylint which may change in the future but currently flags almost every line with strict pep-8 practices.
Numpy isclose works to compare expected values of fit.
I also moved minimum working example to root directory and included instructions on how to use in readme.

@nmaterise I had to comment Mattis-Bardeen from requirements.txt because it cannot be pip installed by symbol. I disabled warnings for pylint which may change in the future but currently flags almost every line with strict pep-8 practices. Numpy isclose works to compare expected values of fit.
I also moved minimum working example to root directory and included instructions on how to use in readme.

That all sounds good. I think we will want to pull Mattis-Bardeen from its github. I think my code used pip from the cloned version of the code, and that's why it ended up in the requirements.txt file. If you know how to add github repositories to requirements.txt, I think it will fix that problem. Everything else looks good.


support precompiling the matcher

Support the ability to "precompile" the pattern, so that repeated matches of the same pattern do not have to parse the pattern over and over again.
Something like how re module does it:
mat = PatternMatcherObject(pattern)
objs = mat.match(inpobjects)
objs2 = mat.match(inpobjects2)

Thanks for the suggestion, @jmgnc !
@chisholm and I talked about this a bit, and are considering putting a "compiled pattern" object into the pattern-validator repo (which is turning into more than just for validating patterns). Then we could have pattern-matcher depend on pattern-validator, and we wouldn't need to worry about keeping the parser/lexer/etc. Python files in these two repositories in sync.
Since we don't want the validator to depend on the matcher, we couldn't define the "match" function directly on that compiled pattern class, but we could either extend/encapsulate that class in the matcher, or define a function that accepts the compiled Pattern and the input objects:
pattern = Pattern(pattern_string)
objs = match(pattern, inpobjects)
objs2 = match(pattern, inpobjects2)

Do any of those options seem inherently better/worse to you?

to me, encapsulating in the matcher class seems better to me than the function.. it's more OOP like, less type checking.

Makes sense. We can just create a "PatternMatcher" (or "MatchablePattern") subclass of the pattern-validator Pattern class, and define a match function on that.

Depends on oasis-open/cti-pattern-validator#20

@chisholm, I'm pretty sure we can close this based on the corresponding issues in the pattern-validator being closed. Is there anything we need in this issue?

Nope, I think we can close this.

Yep, I just found #35 where this was fixed. Thanks!


Preserve Data

Hello reviewer 👋🏾
In this milestone my partner @ZahraArshia and I implemented the following;

[ ] Check the documentation for Ruby's JSON library.

[ ] On exit from your app saves all the data (books, people, and rentals) into JSON files. One per type of data you are storing and named accordingly (e.g. rentals.json)

[ ] On startup of your app load all data from files. Remember to handle the case when one or more of the files are missing.

Thank you @Emmyn5600


[Discussion] The button colors look very dull, I have suggested some changes.

Description
Blue color change
    background-color: #68f3ff;
    border: 2px solid #5c5c5c;

Light Mode

Dark Mode

Border Color change for dark mode
  border: 2px solid #393939;
  box-shadow: 3px 10px 10px 1px #222;

Suggested

Currently

Border Color change for light mode
    border: 2px solid #d7d7d7;
    box-shadow: 3px 10px 10px 1px #eeeeee;

Suggested (Note: Button borders)

##Currently

Screenshots
No response
Do you want to work on this issue?
None
Additional information
I think changing these defaults (colors) will have a great impact in providing users with better UI/UX.
It would be nice to hear out your thoughts on this.

Thank you for the suggestion but we have used our brand colours so I will close this, as your suggestion is not part of the brand colour.


Is sdallocx safe to call with a null pointer?

With recent changes to an application, I am running into the error memory allocation of n bytes failed (where n is a small number eg. 5, 1, 4) when using jemallocator. The application works fine when using the system allocator.
Running jemalloc in debug mode reveals that it is failing the assert that sdallocx was not called with a null pointer.
The jemalloc-sys docs imply it is safe to call sdallocx with a null pointer (it states "no action occurs"). I cannot find anything in jemalloc docs to confirm this, and by the assert in the code it appears as if it is explicitly not allowed.
Modifying sdallocx to simply return when called with a null pointer appears to fix the issue, but I am not sure of the ramifications of this change.
I apologize for not having a minimal example with which to replicate. The scenario in which the error occurs is fairly involved.

According to jemalloc's docs:

The dallocx() function causes the memory referenced by ptr to be made available for future allocations.

The sdallocx() function is an extension of dallocx() with a size parameter to allow the caller to pass in the allocation size as an optimization. The minimum valid input size is the original requested size of the allocation, and the maximum valid input size is the corresponding value returned by nallocx() or sallocx().

so IIUC the following should work:
void* ptr = malloc(0);
sdallocx(ptr, 0);

yet that would always make the assert fail. So either this snippet is correct and the assert is incorrect, or the docs are incorrect, and this snippet would need to be written like this:
void* ptr = malloc(size);
if (size == 0) { free(ptr); } else { sdallocx(ptr, size); }

which IMO would make the API of jemalloc unnecessarily hard to use correctly.
@davidtgoldblatt could you clarify what the intent is here?

@davidMcneil

The malloc() and calloc() functions return a pointer to the allocated memory if successful; otherwise a NULL pointer is returned and errno is set to ENOMEM.

That is, jemalloc memory allocation functions only returns NULL if the allocation failed, and sdallocx does not support being called with NULL, so the error is in the comment in this crate. Calling sdallocx with NULL is not allowed.

Thanks for the response @gnzlbg! I am not using jemalloc-sys directly. The bad call to sdallocx is occurring in jemallocator's implementation of dealloc.
I will see if I can get a minimum example replicating the issue.

The behavior of calling {GlobalAlloc, Alloc}::dealloc with a null pointer or with a size of 0 is undefined, so the bug that's causing that must be somewhere else. I'm going to leave this issue open until the documentation bug for jemalloc-sys is fixed.
We should probably also add an assume!(!ptr.is_null()) to {GlobalAlloc, Alloc}::dealloc.

@davidtgoldblatt could you clarify what the intent is here?

We've historically tried to avoid taking a strong stance on this sort of implementation-defined thing (e.g. return value of malloc(0)). Wanting C++ interop has made this harder and harder, to the point that I think we might just as well commit to malloc(0) being non-NULL (barring OOM).
I'm not sure anyone ever thought too hard about the sdallocx-with-zero case. We used to assert against it, but took it away (again, for C++ interop reasons). The more I think about it, this less I'm convinced that it was ever the right thing to do. If we give out non-NULL pointers in response to a request for a particular size, we ought to accept that size back again in sdallocx.

@davidtgoldblatt is there an issue in jemalloc upstream that we could cross-reference from here ?
In Rust, the behavior of requesting an allocation with zero-size is undefined, i.e., malloc(N) will always be called with N > 0, so if it returns a nullptr, then that must be because the allocation failed. Trying to deallocate such a nullptr (e.g. free(NULL), or sdallocx(NULL, N > 0)) is also UB in Rust, so these cases should never be triggered. That is, we will add asserts anyways to our wrappers to try to diagnose these issues in the Rust side.

@davidtgoldblatt is there an issue in jemalloc upstream that we could cross-reference from here ?

I don't think so; what specifically are you referring to though? (I think a catch-all "there should be better documentation around edge-cases" issue with a list would be useful; I don't think we have one at the moment).

I started a list at https://github.com/jemalloc/jemalloc/issues/1716

Thanks, that was precisely what I was referring to.


Create a tool to initiate checkpointing from the command line

This tool should allow the validators to submit a checkpoint via the commandline.
Task

[ ] Add a new subcommand to vega
[ ] The command should takes as input the file + the wallet of the validator

Relevant specs

non-protocol-specs/005 Limited network life

Acceptance Criteria
As a linux terminal user
In order to submit a restore transaction to the vega chain
I should be able to use a sub command of the Vega executable to specify a checkpoint file
And that sub command should result in a restore transaction being broadcast to all validators

Moved to this repo from https://github.com/vegaprotocol/vega/issues/3773


change wrong file path in README.md

With the project development, some project file structure may change. We need to change the README.md file in time.

Thanks @materliu


Re-image Classmate 2015

The classmate originally planned for use this year needs to be completely re-imaged from the ground up for use as a backup. We will use the other classmate as our primary for competitions.

I think we did this.


Update titan CI to not pass rocksdb dir

Do not pass rocksdb dir by CI, titan itself would download the rocksdb branch corresponding to Titan CMakeList.txt

Hi, here is replay test link  https://ci.pingcap.net/blue/organizations/jenkins/titan_ghpr_test/detail/titan_ghpr_test/234/pipeline

/ok-to-test


Refactor docker image

In a next step we can then include appcat-cli into the k8ify image

LGTM, thank you !


QR scan preview is misaligned with the QR scanning square overlay

For the image analysis, we're using the center of the image, so the scanning square doesn't properly correspond to the region that's being used. We need to make sure the focus is being correctly aligned with the actual scanning square too.

Resolved.

That's possible but would require properly aligning the QR square and should be filed as a separate request.


Adding a open-source Finance app build with Flutter

I agree to follow this project's Code of Conduct
I'm a GSSOC'24 contributor
I want to work on this issue.

I agree to follow this project's Code of Conduct I'm a GSSOC'24 contributor I want to work on this issue.

Hello, I have opened it for myself. But you can open your own issue using New issue button


Mdc data updates

I think this should be everything we need to train on something like the MDC data. It implements:

Chunked dataloading across multiple files, which is ~10x faster than using a vanilla torch Dataset with multiprocessing
Local whitening using the previous kernel_length - (fduration + 1) seconds worth of data to fit a PSD, which is then applied to the last fduartion + 1 seconds of the kernel before slicing off fduration / 2 seconds at the edges.
Getting rid of glitch sampling for the time being since it complicates the picture a bit (mostly around getting the data to do a run)

The only major remaining question is how with respect to which PSD do we want to measure the SNR for rescaling? One option that would rearrange things conceptually, but would be clean-ish from an implementation standpoint, would be to implement the PSD calculator as a separate module that gets computed in the Augmentor, and which is then used to rescale each of the sampled waveforms. This batch of PSDs would then need to be returned by the data generator so that the Preprocessor could use it to apply whitening (or we could build this into the Augmentor as well). At export time, we would just instantiate a new PSD calculator and whitener and build these into the ensemble on the server side.

I think a separate PSD calculator module makes sense, since it can be used for both whitening and snr rescaling. Is that what you were suggesting above? Also, is this not just the  SpectralDensity transform in ml4gw?

@EthanMarx ok cool, implemented things that way. It's more or less the same, but there's some extra stuff for interpolating to the data's kernel length and limiting its impulse response/highpass filtering.

Closing as updates here were merged with #361


HADOOP-16721. Improve S3A rename resilience

s3a rename to support
fs.s3a.rename.raises.exceptions: raise exceptions on rename failures
fs.s3a.rename.reduced.probes: don't look for parent dir (LIST), just verify
it isn't a file.
The reduced probe not only saves money, it avoids race conditions
where one thread deleting a subdir can cause LIST  to fail before
a dir marker is recreated.
Note:

file:// rename() creates parent dirs, so this isn't too dangerous.
tests will switch modes.

We could always just do the HEAD; topic for discussion. This patch: optional
Change-Id: Ic0f8a410b45fef14ff522cb5aa1ae2bc19c8eeee

Testing with  -Dparallel-tests -DtestsThreadCount=8 -Dmarkers=keep -Dscale
If the store is set to raise exceptions, a lot of tests which expect rename(bad options) to return false now get exceptions. One of the contract tests would downgrade if the raised exception was FileAlreadyExistsException and the contract xml said that was ok. I'm reluctant to go with a bigger patch.
this PR is so that Hive and friends can get better reporting on errors, rather than have them lost. It will be optional

Testing: s3 london with markers==keep and delete, s3guard on and off.

change in error reporting of s3a FS matched with relevant changes in s3a.xml for contract tests.
skip tests verifying that you can't rename 2+ levels under a file.
Failures related to endpoints of common-crawl and  ITestAssumeRole.testAssumeRoleBadInnerAuth: known and fixed in #2675.


To disable entering continuous build in runPlaybinary task

For some reasons (probably default settings?), gradle rPB will automatically enter continuous build even without -t or --continuous tag
Log:

Task :sample-play-rest:runPlayBinary
Running Play App (:sample-play-rest:runPlayBinary) at http://localhost:7777/

BUILD SUCCESSFUL in 14s
10 actionable tasks: 4 executed, 6 up-to-date
Reloadable deployment detected. Entering continuous build. <------------ Is there anyway to disable this?
Gradle version: 4.4

Unfortunately, since 4.2, Gradle's runPlayBinary task will always rebuild and reload Play application automatically when file changes are detected, no matter whether --continous is enabled. This is because we think runPlayBinary task as a task for local development so its default behavior should act like this. As for your issue, I think a simple task declaration may meet your needs:
    task runPlayDist(type: Exec){
        dependsOn 'stage'
        commandLine 'build/stage/playBinary/bin/playBinary'
    }

where stage task collects all application code/assets/configurations and dependency jars together, then generates start scripts for both Unix and Windows. To run the Play application without rebuilding and reloading at all, we just need to run the corresponding start script.


⚠ ClamAV has degraded performance

In 119cc4d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 505 ms

Resolved: ClamAV performance has improved in 5d34081 after 6 minutes.


Cow: Watch techforzone.com

Cow requests the watch of the watch_keyword techforzone\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

techforzone\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by VLAZ in Charcoal HQ


Add --no-colors option

I'm integrating arkb into a deployment script where I'd like to be able to easily grep out the IPFS CID and Arweave ID of the uploaded file, but the various escape sequences in the output of arkb deploy make this challenging. I'm filtering the escape sequences out with sed right now, but if there were a --no-colors option for arkb it would be a lot easier to compose with other tools. For my purposes filtering out the colors with sed works, but the escape sequences used for the progress indicators still remain in the output file e.g. ^[[0G  ^[[96m⣾ ^[[90mDeploying 2 files...^[[0m^[[0G  ^[[96m⣽ ^[[90mDeploying 2 files... so maybe something more general than --no-colors would be appropriate (--simple? which could also remove the progress indicators).

@cedriking what do you think about this ?

Thanks @purplepwny for the recommendation. We will go ahead and add the new --no-colors option.
@fuadop  can you please get started with that this Monday? Thanks!

Sure @cedriking 🚀

Awesome! Thanks a lot 🙏


"Share dialog" won't open from the "Change Privacy dialog" when choosing "Password protected" and password is empty

Steps to reproduce:

Login with a user that belongs to an org.
Open the Change Privacy dialog.
Click "Password protected".
Click "Share this dataset with your colleagues" on the banner at the bottom.
Nothing happens (Share dialog remains hidden).
Type a passord.
Click "Share this dataset with your colleagues" again.
Share dialog is now visible.

Here's the reason why it's not working. Do you remember why we added that @viddo. I'd say we can remove it.

It was added because a password is a requirement to be able to change the privacy settings (sharing settings save together with the privacy setting.
I don't see it as a solution to remove the check, because then the user won't be able to save because the password is still missing, and there's no feedback on why. I figured it was better/simpler to not allow the user to leave the view in an inconsistent state in the first place than having to complicate the other views (share and footer) more with handling this state.
As to make it more clear, I think we could give some visual cue that the sharing link is disabled when switching to the password view and password is missing, or show some message in the footer if empty and not on the start view (but like I said, that complicates the view states).
Other ideas?

As a user, I'd personally expect the Share Dialog to behave as a completely separate dialog (which is the case in all cases except the "Password protected" one). So, if I'm on the "Password protected" tab and I hit "Share this dataset with your colleagues", I would expect the app to let me go ahead and "share with my colleagues". Don't you think? We can get some input from design here.

Yep, I think you have some good points. I also brought that up, that these two dialogs should really be separated (because they are separate settings really) when it was implemented, but if I recall correctly it was done like this to be consistent with old modal behavior.
cc @saleiva

Talked with @saleiva and it was one of those things we left as "nice to have" at the time we implemented the new dashboard. So technically not a bug but an enhancement ;)
The correct behaviour is similar to what you suggest:

"Save" button on share view only persist permission ACL changes
After sharing changes are successfully changed, takes one back to the start view
Start view should display amount of users that shares the dataset/map (there should be a sketch screen w/ this state)

Added it to the next milestone (Navacerrada).