Constantly recurring database updates with v3.3

Describe the bug
Whenever I start playnite with this update, I have a dialog "Downloading data from installed games" which occurs each time. Also when I change selected game I have a dialog "Database migration" which occurs each time.
To Reproduce
Open playniite with addon v3.3 installed. Change selected game.
Expected behavior
The first dialog makes sense, but I would expect it to only occur once, when starting for the first time after updating to 3.3
The second dialog I would have expected to not be there as migrations should have taken place during the first dialog.
Screenshots
N/A
Extensions log
N/A - I have uninstalled the addon for now as the updates and issues ares taking up too much time for me.

Same issue here, unfortunately.
Every time that I start Playnite, if the option "download" is turned on, instead of downloading data of newly installed games SuccessStory re-downloads the data of all installed games (which in my case are a lot, so this makes Playnite unusable for me for five minutes...).
It says "SuccessStory: Downloading data from new games", but none of the games are new, and the data gets redownloaded at every Playnite startup.
Screenshot:

Logs:
playnite.log
extensions.log

same. also Epic achievements dont work with 3.3

The issue still occurs for me on SuccessStory 3.3.1 (I updated it today, so I assume it should have been the fixed version?).

There's a way to prevent that, just uncheck Automatically Import data like the picture above

I hope the dev reopens this issue thread because the problem, as showed by multiple people, has not been fixed unfortunately.


Update README.md (fix screenshots)

Fixing the screenshot links. The old ones could not be linked to for some reason (I suspect GitHub changing markdown requirements).
The new ones pull from what looks like the carousel from the gh-pages branch.

Github links work fine for me, will leave as is for now.

Hmm yes, they work now. They didn't in October ;)


cloning submodules not working

I am seeing the following error when running ansible-playbook eos.yml
FAILED! => {"changed": false, "msg": "Failed to init/update submodules: Submodule 'contracts/libc++/upstream' (https://github.com/EOSIO/libcxx.git) registered for path 'contracts/libc++/upstream'\nSubmodule 'contracts/musl/upstream' (https://github.com/EOSIO/musl.git) registered for path 'contracts/musl/upstream'\nSubmodule 'externals/binaryen' (https://github.com/EOSIO/binaryen) registered for path 'externals/binaryen'\nSubmodule 'externals/magic_get' (https://github.com/EOSIO/magic_get) registered for path 'externals/magic_get'\nSubmodule 'libraries/appbase' (https://github.com/eosio/appbase) registered for path 'libraries/appbase'\nSubmodule 'libraries/chainbase' (https://github.com/eosio/chainbase) registered for path 'libraries/chainbase'\nSubmodule 'libraries/fc' (https://github.com/EOSIO/fc) registered for path 'libraries/fc'\nSubmodule 'libraries/softfloat' (https://github.com/eosio/berkeley-softfloat-3) registered for path 'libraries/softfloat'\nSubmodule path 'contracts/libc++/upstream': checked out '4db45e5e5948995eea60a4e4fecadb96e52c2af2'\nSubmodule path 'contracts/musl/upstream': checked out '8a34536ac9764c90c86cc0b62d0cda07449fd5d8'\nSubmodule path 'externals/binaryen': checked out '27000a9bfa616133c9368214386fd0416f398dfe'\nSubmodule 'test/emscripten' (https://github.com/kripken/emscripten.git) registered for path 'test/emscripten'\nSubmodule 'test/spec' (https://github.com/WebAssembly/testsuite.git) registered for path 'test/spec'\nSubmodule 'test/waterfall' (https://github.com/WebAssembly/waterfall.git) registered for path 'test/waterfall'\nSubmodule path 'externals/binaryen/test/emscripten': checked out 'bf0bdc540ad45b7178c6ea77a947c1b9f70a127d'\nSubmodule path 'externals/binaryen/test/spec': checked out '0b7f00081c62321a96ed67f5f651408c4ae17ec0'\nSubmodule path 'externals/binaryen/test/waterfall': checked out '0111f9d1de942a2f9ac4d86da4a6940f212e9168'\nSubmodule path 'externals/magic_get': checked out '8b575abe4359abd72bb9556f64ee33aa2a6f3583'\nSubmodule path 'libraries/appbase': checked out '6e440a7f3c51f3b8226860663b5eb6446087fed9'\nSubmodule path 'libraries/chainbase': checked out '9bfe5043f5484e00f89387091e9b5beb90b88c62'\nSubmodule path 'libraries/fc': checked out '8edb92dd2310108b8eb66d010b84ca4fc9dce898'\nSubmodule 'secp256k1/upstream' (https://github.com/cryptonomex/secp256k1-zkp.git) registered for path 'secp256k1/upstream'\nSubmodule path 'libraries/softfloat': checked out '9942875eb704369db297eb289aa4e9912bddcfb8'\nCloning into 'contracts/libc++/upstream'...\nCloning into 'contracts/musl/upstream'...\nCloning into 'externals/binaryen'...\nCloning into 'test/emscripten'...\nCloning into 'test/spec'...\nCloning into 'test/waterfall'...\nCloning into 'externals/magic_get'...\nCloning into 'libraries/appbase'...\nCloning into 'libraries/chainbase'...\nCloning into 'libraries/fc'...\nCloning into 'secp256k1/upstream'...\nfatal: Needed a single revision\nUnable to find current origin/master revision in submodule path 'secp256k1/upstream'\nCloning into 'libraries/softfloat'...\nFailed to recurse into submodule path 'libraries/fc'\n"}

any suggestions?

Interesting! I tried this on a fresh node, even updating the eos version, and i get the same.
Must be a legit issue with a submodule reference on their side.
I will keep this issue open until the EOS devs have fixed this.

Oh this is awesome feedback, thanks @sensay-nelson!!
I will update that documentation on eosnode.tools, and would love to hear the other pieces of feedback, will keep this thread open for that.

A few things I bumped my head on while getting started.
minimum system requirements

8GB Memory
20gb free disk space on root device where eos will be compiled
200gb free disk space for the data directory where the blocks will be written to.

If one were launching into AWS, a c5.xlarge with a 200gb root device or 200gb attached ebs volume would be the minimum and reasonable to run an API node.
separate config-dir and data-dir
Currently in the startup script and config.ini, these are the same folder, which isn't necessarily going to be true, especially if you are in AWS/Google and using ebs volumes (which are handy if I wanted to re-attach my blocks to a different instance size later, for instance).
I may make a pull request for this allowing it to be a config option in ansible and updated in both files via template.
Ditch genesis startup in favor of your own backup blocks solution
On https://eosnode.tools/automation, the below instructions were confusing for a couple reasons.

it's not using your own block backups by default, which is definitely going to be a far faster solution.
using genesis.json file contradicts the many p2p-peer-address ansible configured in config.ini.  If I understand correctly, Genesis.json is specific to each block producer and only the block producer for which the genesis.json file you are using should be configured in the p2p-peer-address if you are going to start from scratch.    So, out of the box with running ansible and this command did not work.

# Launch the chain for the first time
ssh user@nodeip
cd /opt/mainnet
./start.sh --genesis-json /opt/mainnet/genesis.json

I would replace it with something like
# Install the mainnet config
ansible-playbook mainnet.yml

## Finish
Download the latest block backup and start nodeos at
https://eosnode.tools/blocks

...And on https://eosnode.tools/blocks, I would use the start script with the extra options so no one accidentally starts it non-daemonized, as it will start all over again if you cancel the process.
# Move to your nodeos data directory (remove existing blocks and state dir if relevant)
cd /opt/mainnet
rm /opt/mainnet/blocks
rm /opt/mainnet/state

# Download the latest blocks backup for Ubuntu 18.04
wget $(wget --quiet "https://eosnode.tools/api/blocks?os=Ubuntu+18.04&limit=1" -O- | jq -r '.data[0].s3') -O blocks_backup.tar.gz

# OR Download the latest blocks backup for Ubuntu 16.04
wget $(wget --quiet "https://eosnode.tools/api/blocks?os=Ubuntu+16.04&limit=1" -O- | jq -r '.data[0].s3') -O blocks_backup.tar.gz

# Uncompress to ./blocks
tar xvzf blocks_backup.tar.gz

# Start up nodeos pointing to the data directory, request a hard replay of the chain using wavm to speed things up
./start.sh --hard-replay --wasm-runtime wavm

# Tail the logs
tail -f /opt/mainnet/log.txt
Nodeos should copy the blocks to a backup directory, and then begin the replay. This will likely take 2-3 hours, depending on CPU.  Once replay is complete up to the current backup block, the chain will begin to synhcronize with the other p2p nodes configured.  This will also take 2-3 hours, depending on how far ahead the mainnet is.
<< copy of expected log output >>

That's it.    Again, terrific work and thanks for your help.  Now that I am going it is fun :)

This is epic!!
Thanks so much for taking the time to do this. I will incorporate of all this feedback and push up tomorrow.

Thats all incorporated now, thanks again @sensay-nelson !


UPDATE_SYNC_ERRORS sets all field errors on load

What is the current behavior?
Recently updated and all fields have error on load.
What is the expected behavior?
For the fields to have error only after validation fails - after touch.
What's your environment?
    "react": "^15.4.1",
    "redux-form": "^6.7.0",
    "redux-form-material-ui": "^4.2.0",

Other information
On load of the empty form component @@redux-form/UPDATE_SYNC_ERRORS runs and sets an error on each field that has validation set. The validation is a simple required func const required = value => value ? undefined : 'Required';
I'm not sure how this is being set when the field has no value? It's a new form so no initial values.
Any idea why this validation is failing on load? Any help appreciated :)

Are you saying that the field has an error prop passed to it, or the field is being marked as touched, and the error is showing?
Receiving an error is intended behavior even before touching. If you look in the examples, the field is set to only render the error conditionally based on touched state.
If I'm misunderstanding your question please let me know!

Hey @timhwang21 - thanks for the reply. When a clean form loads it displays the required error and the object is attached. Is this desired behaviour?

{
  "registeredFields": {
    "name": {
      "name": "name",
      "type": "Field",
      "count": 1
    },
    "typeid": {
      "name": "typeid",
      "type": "Field",
      "count": 1
    },
    "image": {
      "name": "image",
      "type": "Field",
      "count": 1
    }
  },
  "syncErrors": {
    "name": "Required",
    "typeid": "Required"
  }
}

What's your code to display errors? If you're display them without checking for touched status, yes this is intended.

Thanks @timhwang21 - I think it may be related to the way that I'm aliasing the onBlur event and also the way Material-UI handles the touched prop.
Anyway - working now, so thanks!


HTTPS Error Fix

Fix Issue https://github.com/avnigenc/pyCoin/issues/5
The code was refrencing http://code.jquery.com/jquery-2.2.4.js that's why not working for https, changed to https://code.jquery.com/jquery-2.2.4.js

Thank you.


Adding facet filter and search

@poljar @fulmicoton Sorry I could not finish this PR, I was bootstraping getflaps.com and was super busy. Now I have some time and would like to get back to it as we are using with super successful result on our startup!
@poljar fixed all style errors
@fulmicoton About removing facets from search function and move it the query itself I don't understand how we can add a collector to count filters on the query parsed query

Any chance this PR might get merged soon? I was just trying to use the tantivy-py package and realized it's quite a bit behind the core Tantivy package, which I was using as a reference for documentation. I'm currently trying to do some of the work to bump the version to v0.15.3, but I'm very new to Rust, so it's quite a slog fo me. It seems like such a shame to just let all the good work in this PR go to waste :)

Any chance this PR might get merged soon? I was just trying to use the tantivy-py package and realized it's quite a bit behind the core Tantivy package, which I was using as a reference for documentation. I'm currently trying to do some of the work to bump the version to v0.15.3, but I'm very new to Rust, so it's quite a slog fo me. It seems like such a shame to just let all the good work in this PR go to waste :)

Sure, but the panic absolutely needs to disappear, I guess we can leave the version bump.


Fix CC input detection deadlock

Normally, the ListenerManager holds a per-instance lock when dispatching an event, so the listener implementation doesn't have to be thread-safe. It also holds a per-listener interface lock for some internal reasons.
This, and the fact that the ConfigurationCacheFingerprintWriter can emit events while processing events lead to deadlocks when two threads were dispatching different kind of events to the writer.
This commit marks ConfigurationCacheFingerprintWriter as capable of receiving events concurrently, thus eliminating the instance lock and the potential for a deadlock.
The per-listener interface locks can in theory produce a deadlock too, but in practice we can only aim for the second lock when processing a ValueListener, so the potential for deadlocks is much lower and can be addressed separately.
Fixes #30905.

@bot-gradle test PRF, ACC

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

All ConfigCache Tests for Pull Request Feedback (Trigger) (Pull Request Feedback)

Build Scan

ConfigCache Java21 Adoptium Macos Aarch64 (Trigger) (Ready for Release)

Build Scan

ConfigCache Java21 Adoptium Windows Amd64 (Trigger) (Ready for Release)

Build Scan

The following builds have passed:

All ConfigCache Tests for Pull Request Feedback (Trigger) (Pull Request Feedback)

Build Scan

The following builds have passed:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have failed:

ConfigCache Java21 Adoptium Macos Aarch64 (Trigger) (Ready for Release)

Build Scan

The following builds have failed:

ConfigCache Java21 Adoptium Windows Amd64 (Trigger) (Ready for Release)

Build Scan

@bot-gradle test PT

I've triggered the following builds:

All Performance Tests for Ready for Nightly (Trigger)

Build Scan

The following builds have passed:

All Performance Tests for Ready for Nightly (Trigger)

Build Scan

@bot-gradle test this

I've triggered the following builds:

Pull Request Feedback (Trigger) (Check)

Build Scan

The following builds have passed:

Pull Request Feedback (Trigger) (Check)

Build Scan

The per-listener interface locks can in theory produce a deadlock too

Is this issue worthy?

The per-listener interface locks can in theory produce a deadlock too

Is this issue worthy?

I've filed #30990 to follow-up, but I wasn't able to reproduce the issue in a reasonable way.

WARN: Based on labels, this pull request addresses notable issue but no changes to release note found.


fixed bold markdown styling, removed embed component for now

@haowens just noting that the build failed due to a graphql schema mismatch between tinacms cloud and this branch. i'm assuming that'll get fixed when this gets pushed to main but you know that part of the functionality better than me.


DOC: Adding documentation for resampling.

Providing an explanation of how resampling works, backward mapping as opposed to forward mapping.

This PR requires data that will only be available after this PR is merged into the SimpleITKExternalData repository.

If you rebase off the latest master, the CircleCi build-and-test ought to pass.


Fixed #23405 - Fixed asking for default value for CharField and TextField in migrations

I think modifying autodetector will be enough.
When migration will be applying, django.db.backends.schema.BaseDatabaseSchemaEditor#effective_default set correct value (empty string) for TextField and CharField, if they are blank, but NOT NULL.

That SQLite fix might have broken something. See https://github.com/alex/django-taggit/issues/285


Adding regularizer causes crash when using eager w/ make_template

System information

Ubuntu 16.04
Tensorflow installed from binary: v<IP_ADDRESS>
Python 2.7.12
CUDA: Version 9.0.252
GPU: GeForce GTX 1080 Ti

Code to reproduce:
import tensorflow as tf
import tensorflow.contrib.eager as tfe
import tensorflow.contrib.layers as layers

tf.enable_eager_execution()

def make_network(input_images, include_regularizer):
    weights_initializer = tf.variance_scaling_initializer(scale=1.)
    l2_regularizer = layers.l2_regularizer(scale=0.000004)

    convolution_args = dict(
        weights_initializer=weights_initializer,
        biases_initializer=tf.zeros_initializer(),
        activation_fn=tf.nn.leaky_relu,
        kernel_size=(3, 3), stride=1,
        padding='SAME',
        weights_regularizer=l2_regularizer if include_regularizer else None,
    )
    return layers.conv2d(inputs=input_images,
                         num_outputs=3,
                         scope='my_layer',
                         **convolution_args)

if __name__ == '__main__':
    images = tf.ones([2, 240, 320, 3], dtype=tf.float32)
    the_template = tfe.make_template(
        'custom_network', make_network,
        create_graph_function_=True,
    )
    # execute the template
    foo = the_template(images, include_regularizer=True)

The above code fails with UnboundLocalError when include_regularizer=True. Setting include_regularizer=False runs normally. The crash occurs in base.py:
/usr/local/lib/python2.7/dist-packages/tensorflow/python/layers/base.py in add_weight(self, name, shape, dtype, initializer, regularizer, trainable, constraint, use_resource, synchronization, aggregation, partitioner)
    278         if regularizer:
    279           if context.executing_eagerly() or _should_add_regularizer(
--> 280               variable, existing_variables):
    281             self._handle_weight_regularization(name, variable, regularizer)
    282

UnboundLocalError: local variable 'existing_variables' referenced before assignment

Upon closer inspection, it appears context.executing_eagerly() is False here, resulting in the _should_add_regularizer statement being evaluated. Based on a cursory inspection, it seems like existing_variables should be set on line 246 of base.py, but this does not occur because within the scope of ops, executing_eagerly() evaluates to True.
See https://github.com/tensorflow/tensorflow/blob/09792df012c22622324f085f46edde33006c7355/tensorflow/python/layers/base.py#L236-L250
I'm unclear what the expected behavior of this code is - am I doing something wrong or is this a bug?

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce
Mobile device

@tensorflowbutler The additional info:
Have I written custom code: Yes, see above
OS Platform and distribution: Ubuntu 16.04
TensorFlow version: v<IP_ADDRESS>
Bazel version: n/a
CUDA/cuDNN version: Version 9.0.252
GPU model and memory: GeForce GTX 1080 Ti 12GB
Exact command to reproduce: See code above
Mobile device: n/a

Nagging Assignee @jart: It has been 15 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jart: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jart: It has been 45 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jart: It has been 60 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jart: It has been 77 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @jart: It has been 92 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Is this still an issue?

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?


When running the iOS app on an M1 mac, getInitialURL does not work

Description
When running the iOS version on an M1 Mac (using Mac (designed for iPad) option in XCode)
Deep links do not work when the app is killed i.e. getInitialURL() always returns empty string even if the app was opened using a deep link.
(If the app is already opened, the addEventListener url is called as usual)
React Native Version
0.72.5
Output of npx react-native info
System:
OS: macOS 14.0
CPU: (10) arm64 Apple M1 Pro
Memory: 433.00 MB / 16.00 GB
Shell:
version: 3.6.1
path: /opt/homebrew/bin/fish
Binaries:
Node:
version: 18.18.0
path: /opt/homebrew/bin/node
Yarn:
version: 1.22.17
path: /opt/homebrew/bin/yarn
npm:
version: 9.9.1
path: ~/Documents/Projets/converse/app/node_modules/.bin/npm
Watchman: Not Found
Managers:
CocoaPods:
version: 1.14.2
path: /Users/noemalzieu/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.0
- iOS 17.0
- macOS 14.0
- tvOS 17.0
- watchOS 10.0
Android SDK:
API Levels:
- "30"
Build Tools:
- 30.0.3
System Images:
- android-30 | Google APIs Intel x86 Atom_64
- android-32 | Google APIs ARM 64 v8a
- android-32 | Google Play ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9619390
Xcode:
version: 15.0.1/15A507
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.20
path: /opt/homebrew/opt/openjdk@11/bin/javac
Ruby:
version: 2.7.6
path: /Users/noemalzieu/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: ^18.2.0
react-native:
installed: 0.72.5
wanted: ^0.72.5
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
Steps to reproduce
Create a RN application and build it for M1 Mac in Xcode using the "Mac (Designed for iPad)" option.
Open the app via a custom scheme link while it's killed.
The getInitialURL method returns an empty string while it should contain the link used to open the app.
Snack, screenshot, or link to a repository
Here is the example repo : https://github.com/nmalzieu/deeplinkmacos
I added the following custom scheme : noedeeplinkmacos
If I build for iOS & kill the app then click on the following link : noedeeplinkmacos://test-deeplink - it opens the app with the following screen:

I then build for Mac (Designed for iPad) : NB I modified the scheme to "Wait for the executable to be launched". I then click on the same deeplink and here is what I get:

However you can see that following clicks do trigger a linking event :

So it's only the initial URL that doesn't get filled on Mac.

same problem


Fix location of error in create master zone

Closes #1511

Coverage remained the same at 83.077% when pulling 15bcfcd445dcea0756e03819d8b43a127abf3115 on eatonphil:fix-master-domain-error-location into 030644c04eb475c859ee8c133bd0d0f32c0b6103 on linode:master.

thank you!


Bug fixing issues with attach

Current coverage is 47.21%

Merging #11 into master will decrease coverage by -0.10% as of 87b141e

@@            master     #11   diff @@
======================================
  Files           33      33
  Stmts         3823    3829     +6
  Branches       896     898     +2
  Methods          0       0
======================================
- Hit           1809    1808     -1
  Partial        225     225
- Missed        1789    1796     +7

Review entire Coverage Diff as of 87b141e

Powered by Codecov. Updated on successful CI builds.


Samtools index on bam in resmico-bam2feat_TMP

I am getting this error:
[error] Bam file resmico-bam2feat_TMP/IDMG000000AE/NON-HOST/IDMG000000AE_sub_sorted.bam has no index. Please run samtools index to create an index, otherwise I can't be fast
This is a bam that was created by: resmico bam2feat.
The original bam is indexed.

I may have figured this one out.  I think it is due to how I am running multiple samples.
If you have multiple resmico jobs running and they are both using: ./resmico-bam2feat_TMP for temp, though different Taxon and Sample; if one resmico run finishes, will it remove the entire ./resmico-bam2feat_TMP directory (including the temporary files for the unfinished runs) ?

Thanks for posting the issue.

If you have multiple resmico jobs running and they are both using: ./resmico-bam2feat_TMP for temp, though different Taxon and Sample; if one resmico run finishes, will it remove the entire ./resmico-bam2feat_TMP directory (including the temporary files for the unfinished runs) ?

By default,  the temporary directory is resmico-bam2feat_TMP, as set via --tmpdir. The final step of bam2feat is to remove the temporary directory, so yes, if you have multiple jobs using the same temporary directory, then this will cause problems. I can add a --keep parameter to prevent the removal of the temp directory, or you can use different temp directory names for each job.

No worries.  No need to add a --keep.  I can specify multiple --tmpdir, no problem.  I just didn't realize what was going on and was wondering why the same bam would occasionally fail.
I think I am using this a little bit differently than was intended.  Rather than run ResMiCo on a ton of samples at the same time, I am using it as a step in a larger pipeline.   So each pipeline run is effectively running ResMiCo on a single bam / fna.


get_partitions_orig returns negative values when number of samples is low

Environment

OS: MacOS
Hardware (GPU, or instance type): CPU

To reproduce
>>> ids = get_partitions_orig(num_samples=2, num_canonical_nodes=64, num_physical_nodes=1, ranks_per_node=1, workers_per_rank=1, batch_size=1, drop_first=0)
>>> len(ids)
64
>>> ids
array([-1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,
       -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1,  0,  0,  0,
        0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,
        0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  0,  1])

Expected behavior
I do not expect the get_partitions_orig to return negative values even when the number of samples is lower than the number of canonical nodes. The negative ids are filtered out which result in a DataLoader with a length of 33 (batch_size=1)

Hi @antoinebrl, thanks for using Streaming Dataset. As you have discovered, the behavior is intentional when the number of samples is less than the number of canonical nodes because it divides the samples across nodes/GPUs/workers and we had to add some padding to make it divisible. The solution here is to use num_canonical_nodes=1. We are working toward better streaming dataset defaults so that such issues won't occur in the future.

Hi @antoinebrl, does num_canonical_nodes=1 solve your issue? In the mean time, we will update the defaults to a better value.

Hi @karan6181, Thanks for looking into better default values!
The fact that there are negative values is somewhat less surprising than the sampling between the two items. The first sample is represented 32 times while the second one is only present once.

@antoinebrl We have modified the streaming defaults as part of v0.7.0 and you should not see the above behavior. Can you please try out the latest version0.7.1 and let us know your experience? Thanks!

@antoinebrl closing the issue due to inactivity. Please feel free to re-open if you think this is still an issue.


Background color for code

Issue Type: Feature Request
Hi:
I'd like that "tokenColorCustomizations" would have background color, like:
"editor.tokenColorCustomizations": {
"comments": {
"fontStyle": "bold",
"foreground": "#d0de32",
"background": "#ffffff"
}
}
Thanks!
VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.17134

Duplicate of #3429


Failed to calculate the value of task ':lib-common:compileDebugJavaWithJavac' property 'options.generatedSourceOutputDirectory'.

Expected Behavior
Let the task execute successfully
Current Behavior
Failed
Steps to Reproduce
https://github.com/wangdaqi77/P2M/tree/adapt_AGP7.0/example
./gradlew clean assembleDebug -s -i
Execution failed for task ':lib-common:compileDebugJavaWithJavac'.Failed to calculate the value of task ':lib-common:compileDebugJavaWithJavac' property 'options.generatedSourceOutputDirectory'. > Querying the mapped value of map(java.io.File property(org.gradle.api.file.Directory, fixed(class org.gradle.api.internal.file.DefaultFilePropertyFactory$FixedDirectory, /Users/wongki/AndroidStudioProjects/P2M/example/lib-common/build/generated/ap_generated_sources/debug/out)) org.gradle.api.internal.file.DefaultFilePropertyFactory$ToFileTransformer@7d9cb9cf) before task ':lib-common:compileDebugJavaWithJavac' has completed is not supported

not actively fetching options.generatedSourceOutputDirectory in place，but running the task is failing
Your Environment
Gradle 7.4,Android Gradle plugin 7.1.2,Kotlin 1.5.21,macOS 10.14.6 (18G87)
Build scan URL:https://scans.gradle.com/s/f7bcx5rnry2ws

@wangdaqi77 Can you tell me how to fix it?


Update understanding-sdn-interface.md

Docs Build status updates of commit ffa8d13:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/understanding-sdn-interface.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add tests for the FrankerFaceZ API

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable

Description

@zneix Please take a peek when you have time to see if this sort of testing makes sense - I intend to switch out all of our usages of the text/template package in favour of html/template so we don't have to do manual HTML escaping, and this is generally how I'd go about it for other packages too.
In text:

Mock API we're polling
Make fake request using the load function (so we don't have to test the resolver routing)
Inject HTML in places
Have an expected "tooltip result" where the HTML is escaped out, as expected


Moves Designer from 'PerspexVS' to 'Perspex'

As requests this will move Perspex.Designer back into the main repo

The pull request that removed the designer will be reverted and excluded instead.


Trouble handling huge data

After uploading huge data (4G) two days ago, oryx doesn't accept new data (even small data) any more.

It is not able to find user u0 in the database. I see no crashes in logs, java process is calculating something, this is tail of oryx-batch:

ep 11 11:31:51 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:51 INFO  TaskSetManager:54 - Starting task 23.0 in stage 6689.0
Sep 11 11:31:51 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:51 INFO  TaskSetManager:54 - Finished task 22.0 in stage 6689.0
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  TaskSetManager:54 - Finished task 23.0 in stage 6689.0
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  YarnScheduler:54 - Removed TaskSet 6689.0, whose tasks
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  DAGScheduler:54 - ResultStage 6689 (sortBy at ALSUpdat
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  DAGScheduler:54 - Job 5053 finished: sortBy at ALSUpda
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  SparkContext:54 - Starting job: zipWithIndex at ALSUpd
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  DAGScheduler:54 - Registering RDD 4254 (sortBy at ALSU
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  DAGScheduler:54 - Got job 5054 (zipWithIndex at ALSUpd
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  DAGScheduler:54 - Final stage: ResultStage 6692 (zipWi
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  DAGScheduler:54 - Parents of final stage: List(Shuffle
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  DAGScheduler:54 - Missing parents: List(ShuffleMapStag
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  DAGScheduler:54 - Submitting ShuffleMapStage 6691 (Map
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  MemoryStore:54 - Block broadcast_5382 stored as values
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  MemoryStore:54 - Block broadcast_5382_piece0 stored as
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  BlockManagerInfo:54 - Added broadcast_5382_piece0 in m
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  SparkContext:54 - Created broadcast 5382 from broadcas
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  DAGScheduler:54 - Submitting 24 missing tasks from Shu
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  YarnScheduler:54 - Adding task set 6691.0 with 24 task
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  TaskSetManager:54 - Starting task 0.0 in stage 6691.0
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  BlockManagerInfo:54 - Added broadcast_5382_piece0 in m
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  TaskSetManager:54 - Starting task 1.0 in stage 6691.0
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  TaskSetManager:54 - Finished task 0.0 in stage 6691.0
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  TaskSetManager:54 - Starting task 2.0 in stage 6691.0
Sep 11 11:31:52 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:52 INFO  TaskSetManager:54 - Finished task 1.0 in stage 6691.0
Sep 11 11:31:53 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:53 INFO  TaskSetManager:54 - Starting task 3.0 in stage 6691.0
Sep 11 11:31:53 htm-psycho-401.zxz.su bash[5041]: 2018-09-11 11:31:53 INFO  TaskSetManager:54 - Finished task 2.0 in stage 6691.0

This is tail of oryx-speed:
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59497
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59498
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59480
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59492
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59479
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59520
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59509
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59522
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59518
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59493
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59503
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  BlockManagerInfo:54 - Removed broadcast_2379_piece0 on
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  BlockManagerInfo:54 - Removed broadcast_2379_piece0 on
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59495
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59502
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59481
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  BlockManagerInfo:54 - Removed broadcast_2380_piece0 on
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  BlockManagerInfo:54 - Removed broadcast_2380_piece0 on
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59511
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59500
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59507
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59517
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59496
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59505
Sep 11 11:30:03 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:03 INFO  ContextCleaner:54 - Cleaned accumulator 59483
Sep 11 11:30:14 htm-psycho-401.zxz.su bash[6157]: 2018-09-11 11:30:14 INFO  ALSSpeedModelManager:97 - ALSSpeedModel[features:10, i

Can oryx work incrementally? I.e. I am /ingesting data block by block and expect recommendations to update. Why is not u0 added immediately (waiting 300seconds doesn't help)?

Clarification: after waiting 10 minutes more I do get responce from oryx, but its irrelevant:

From input data we can see that it is supposed to include i1 and i2, but it doesn't. The server is still calculating something. How long should it take for 100K entries in the database?

One more update, finally computation on server seems to have finished (no CPU usage), but recommendations are still irrelevant:

I don't see the problem in the ingest. The HTTP status is 204, which is correct.
You wouldn't expect to see a new user in that data return recommendations immediately; it would appear after the speed layer had run and pushed updates to the model. There are also corner cases where no recommendations can be made (i.e. items are unknown too).
It looks like the update jobs are still running or something. I'm not sure how much data you have or what you're running on, but if you're trying to put all of this in one small VM it might take a long time. You need to look at the Spark UI to answer those questions.
If a user has interacted with items, they are excluded from recommendations. Right? that's expected.
I can't say whether the recommendations are relevant or not. They are according to the model. You may need to tune the model. For example if rank is too low it will underfit.


Update sharing screen messaging.

We need to provide better messaging on the share url screen. Add more options such as 'Create new content'.

Current behavior: After sharing the URL, a toast message appears saying that "your post has been shared" .and it remains on the same sharing URL screen.(which is I think is not complete)
I am thinking of  changing the behavior to something like: After sharing the message ,user should get a dialogue screen saying "create new content " or "share more"
Share more: will allow the same privly URL  to be shared with different applications.
create new content :will redirect it to the create new content screen. What do you suggest????

Yep, something along the lines sounds nice.
But I'd suggest you to start working on your proposal. You should have a fair understanding of the architecture now.

Yeah sure..

You should hang out on the irc channel #privly . That's a better medium for discussing project ideas.

ok

Hi Shivam,
With reference to our earlier discussion regarding this issue, I have told you that we can provide messaging by introducing a dialogue interface.
Current behavior: When the user shares a privly URL using either email,Facebook etc. he is redirected back to a screen showing the same URL with a "Sharebutton" along with the message that "your post has been shared". This is I think not complete for users as they are not sure of what to do next.
Modified behavior: As soon as the user shares the privly URL he will get a 'DIALOG' saying something like :"You post has been successfully shared" along with two option buttons as follows:
1)Share More :will allow user once again share the same URL with different websites.
2)Create New content: will allow user to create a new content redirecting back to the create new message screen.
Will that be a good approach???. What do you suggest???

Hi @vshivam  ,
With reference to our earlier discussion regarding this issue, I have told you that we can provide messaging by introducing a dialogue interface.
Current behavior: When the user shares a privly URL using either email,Facebook etc. he is redirected back to a screen showing the same URL with a "Sharebutton" along with the message that "your post has been shared". This is I think not complete for users as they are not sure of what to do next.
Modified behavior: As soon as the user shares the privly URL he will get a 'DIALOG' saying something like :"You post has been successfully shared" along with two option buttons as follows:
1)Share More :will allow user once again share the same URL with different websites.
2)Create New content: will allow user to create a new content redirecting back to the create new message screen.
Will that be a good approach???. What do you suggest???

#68

@vshivam Can you take a look at this pull request also when you get a chance?

This is more of a UX problem. I'm not really sure if we should redirect the user to the 'Message' application by default. What if the user prefers to use 'PlainPost' ?
The other option would be to open the Navigation Drawer when the user presses 'Create New/Create' and he/she can choose either.
Open to discuss to any more ideas/thoughts.

In the immediate term, I am comfortable making the choice to drop the user into the message application.  I think the other option would be the help page.

@vshivam What options should the user have after pressing the button? PlainPost and Message? If it's those two, how about opening a dialogue box with the options?
Instead of strictly sending the user back to the message application every time we could send the user to the most recently used application.


HBASE-22802 Avoid temp ByteBuffer allocation in FileIOEngine#read

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 33s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 41s
master passed

:green_heart:
compile
1m 19s
master passed

:green_heart:
checkstyle
1m 57s
master passed

:green_heart:
shadedjars
4m 54s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
0m 56s
master passed

:blue_heart:
spotbugs
4m 19s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
5m  6s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 13s
Maven dependency ordering for patch

:green_heart:
mvninstall
5m 21s
the patch passed

:green_heart:
compile
1m 20s
the patch passed

:green_heart:
javac
1m 20s
the patch passed

:green_heart:
checkstyle
0m 27s
hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50)

:green_heart:
checkstyle
1m 28s
The patch passed checkstyle in hbase-server

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
4m 57s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
17m  5s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
0m 55s
the patch passed

:green_heart:
findbugs
5m 28s
the patch passed

_ Other Tests _

:broken_heart:
unit
2m 43s
hbase-common in the patch failed.

:broken_heart:
unit
245m 32s
hbase-server in the patch failed.

:green_heart:
asflicense
0m 51s
The patch does not generate ASF License warnings.

314m 49s

Reason
Tests

Failed junit tests
hadoop.hbase.io.TestByteBuffAllocator

hadoop.hbase.io.hfile.bucket.TestBucketCacheRefCnt

hadoop.hbase.master.TestMasterShutdown

hadoop.hbase.io.hfile.bucket.TestBucketCache

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/583

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 8a65a742a1a5 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-583/out/precommit/personality/provided.sh

git revision
master / 0d338a1820

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/1/artifact/out/patch-unit-hbase-common.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/1/testReport/

Max. process+thread count
5312 (vs. ulimit of 10000)

modules
C: hbase-common hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

TestMasterShutdown seems not related, let's fix the failed UT

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
0m 37s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 36s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 12s
master passed

:green_heart:
compile
1m 18s
master passed

:green_heart:
checkstyle
1m 45s
master passed

:green_heart:
shadedjars
4m 29s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
0m 59s
master passed

:blue_heart:
spotbugs
3m 57s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
4m 44s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 15s
Maven dependency ordering for patch

:green_heart:
mvninstall
4m 58s
the patch passed

:green_heart:
compile
1m 16s
the patch passed

:green_heart:
javac
1m 16s
the patch passed

:green_heart:
checkstyle
0m 28s
hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50)

:green_heart:
checkstyle
1m 20s
The patch passed checkstyle in hbase-server

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
4m 25s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
15m 43s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
0m 57s
the patch passed

:green_heart:
findbugs
5m  1s
the patch passed

_ Other Tests _

:green_heart:
unit
3m  5s
hbase-common in the patch passed.

:broken_heart:
unit
162m 10s
hbase-server in the patch failed.

:green_heart:
asflicense
1m  4s
The patch does not generate ASF License warnings.

226m 13s

Reason
Tests

Failed junit tests
hadoop.hbase.master.replication.TestTransitPeerSyncReplicationStateProcedureRetry

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/583

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux dcfb2ecaaf5c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-583/out/precommit/personality/provided.sh

git revision
master / fbd5b5e327

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/3/testReport/

Max. process+thread count
4908 (vs. ulimit of 10000)

modules
C: hbase-common hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

:blue_heart:
reexec
1m 10s
Docker mode activated.

_ Prechecks _

:green_heart:
dupname
0m  0s
No case conflicting files found.

:green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

:green_heart:
@author
0m  0s
The patch does not contain any @author tags.

:green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ master Compile Tests _

:blue_heart:
mvndep
0m 33s
Maven dependency ordering for branch

:green_heart:
mvninstall
5m 39s
master passed

:green_heart:
compile
1m 21s
master passed

:green_heart:
checkstyle
1m 55s
master passed

:green_heart:
shadedjars
4m 55s
branch has no errors when building our shaded downstream artifacts.

:green_heart:
javadoc
0m 56s
master passed

:blue_heart:
spotbugs
4m 20s
Used deprecated FindBugs config; considering switching to SpotBugs.

:green_heart:
findbugs
5m  6s
master passed

_ Patch Compile Tests _

:blue_heart:
mvndep
0m 14s
Maven dependency ordering for patch

:green_heart:
mvninstall
5m 24s
the patch passed

:green_heart:
compile
1m 20s
the patch passed

:green_heart:
javac
1m 20s
the patch passed

:green_heart:
checkstyle
0m 28s
hbase-common: The patch generated 0 new + 48 unchanged - 2 fixed = 48 total (was 50)

:green_heart:
checkstyle
1m 31s
The patch passed checkstyle in hbase-server

:green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

:green_heart:
shadedjars
4m 54s
patch has no errors when building our shaded downstream artifacts.

:green_heart:
hadoopcheck
17m  6s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

:green_heart:
javadoc
0m 54s
the patch passed

:green_heart:
findbugs
5m 26s
the patch passed

_ Other Tests _

:green_heart:
unit
2m 56s
hbase-common in the patch passed.

:broken_heart:
unit
260m 54s
hbase-server in the patch failed.

:green_heart:
asflicense
1m  5s
The patch does not generate ASF License warnings.

330m 50s

Subsystem
Report/Notes

Docker
Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/583

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 04073c2299c2 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-583/out/precommit/personality/provided.sh

git revision
master / 7648855e59

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/4/testReport/

Max. process+thread count
4649 (vs. ulimit of 10000)

modules
C: hbase-common hbase-server U: .

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-583/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.


[SPARK-10250][CORE] External group by to handle huge keys

This takes the Python implementation of group-by-key and brings Scala up to parity, making Scala's group-by-key fault-tolerant to a single large group. It does so via using an ExternalList data structure to combine the groups, where ExternalList can spill if it gets too large.
First, the performance testing in cases where a single group would be too big to fit in memory:
I tried a few versions of this. In my first implementation, I wrote the ExternalList class, and simply replaced the CompactBuffer usage in PairRDDFunctions.groupByKey with external lists. I then ran the ExternalListSuite that did the group by key operation with some parameters modified. With 7200000 unique integers, bucketed into 5 buckets, the trials yielded:
89.333 ms
89.992 ms
104.026 ms
I then switched to the current implementation. It matches exactly what Python does with an ExternalSorter. So in essence, this is a sort-based group by. It wasn't clear to me why sort-based group by is better... until I saw the numbers, for the same RDD and buckets:
49632 ms
53615 ms
54340 ms
Therefore I went with the current implementation. It's not immediately clear to me however how the Python implementation - and this implementation for that matter - gets the specific speedup in using ExternalSorter. It would be great to get some feedback around why that is the case.
Some caveats / things to note that I am concerned about:

Serialization is a bit hacky in ExternalList - it took a bit of work to get ExternalList to be both serializable and yet still be able to be spillable. For example, I use an extra companion object to hold references to "constants" that I don't want to be wiped out upon serialization. Due to the way Java serialization works, the code blocks in a Scala class will not be invoked again, leaving all vals as null. The time where the val makes sense to be instantiated only upon creating the class, I either have to make it a var and instantiate it in the serialization process, or mark the val as lazy so it is re-initialized upon use post-serialization.

ExternalList's spilling behavior is tied to shuffle parameters, which is a bit unintuitive. This is what Python does as well. I guess the alternative would be other Spark configurations, or parameters to group-by-key that have reasonable defaults. Pretty ugly either way. This should theoretically not cause a significant performance regression in existing groupByKey workflows however - existing workflows would have just had the big groups spilled to disk after writing the whole group to the ExternalSorter anyways, right? I haven't been able to benchmark test the cases where regular groupByKey wouldn't spill normally but would spill now, however.

I'm open to opinions on the cleanup logic. I register external lists with weak reference cleaners such that when the lists are GCed, the underlying files should be cleaned up shortly after. If there's a better way to do this, I'm all ears.

(Not as high priority as Spark 1.5.0 things.)

Merged build triggered.

Merged build started.

Test build #41571 has started for   PR 8438 at commit 8f5d5e3.

Test build #41571 has finished for   PR 8438 at commit 8f5d5e3.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  protected abstract class DiskIterator(file: File, blockId: BlockId, batchSizes: ArrayBuffer[Long])

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/41571/
Test FAILed.

Merged build finished. Test FAILed.

@JoshRosen can someone review? I'll fix the merge conflicts though

Build triggered.

Build started.

Test build #42612 has started for   PR 8438 at commit 2252019.

Test build #42612 has finished for   PR 8438 at commit 2252019.

This patch fails MiMa tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
  protected abstract class DiskIterator(file: File, blockId: BlockId, batchSizes: ArrayBuffer[Long])

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42612/
Test FAILed.

Merged build triggered.

Merged build started.

I'm also not sure what MiMa tests are. Can someone give me a bit of context so I can fix the build?

Test build #42618 has started for   PR 8438 at commit a6d5896.

Test build #42618 has finished for   PR 8438 at commit a6d5896.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  protected abstract class DiskIterator(file: File, blockId: BlockId, batchSizes: ArrayBuffer[Long])

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42618/
Test FAILed.

Hi @mccheah , on the mima tests -- those check for binary compatabilities across spark versions.  If you click through to the link for the test build, you'll see this in the test output:
[info] spark-core: found 12 potential binary incompatibilities (filtered 560)
[error]  * object org.apache.spark.CleanCheckpoint does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanCheckpoint$")
[error]  * class org.apache.spark.CleanupTaskWeakReference does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanupTaskWeakReference")
[error]  * class org.apache.spark.CleanBroadcast does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanBroadcast")
[error]  * object org.apache.spark.CleanShuffle does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanShuffle$")
[error]  * class org.apache.spark.CleanRDD does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanRDD")
[error]  * class org.apache.spark.CleanCheckpoint does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanCheckpoint")
[error]  * object org.apache.spark.CleanBroadcast does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanBroadcast$")
[error]  * object org.apache.spark.CleanAccum does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanAccum$")
[error]  * object org.apache.spark.CleanRDD does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanRDD$")
[error]  * class org.apache.spark.CleanAccum does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanAccum")
[error]  * class org.apache.spark.CleanShuffle does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanShuffle")
[error]  * interface org.apache.spark.CleanupTask does not have a correspondent in new version
[error]    filter with: ProblemFilters.exclude[MissingClassProblem]("org.apache.spark.CleanupTask")

you can see its complaining about the classes like org.apache.spark.CleanAccum that you moved around.  Mima often has false positives, so the tool lets you override these checks.  Its telling you how to do that by each "filter with" statement.  Just stick those here:  https://github.com/apache/spark/blob/master/project/MimaExcludes.scala#L73
I think this is a case of false positives, since those classes are private.  (I would want to take a closer look before being certain about that.)  In any case, you can stick those filters in for now to at least let the tests get further.

Hey @mccheah,
This is a really cool patch. Although we're trying to encourage users to migrate workloads to the DataFrames API, there are still many workloads for which this is a useful improvement. This patch has some high inherent complexity and risk, though, since the details of managing file cleanup are non-trivial and it needs to touch a number of stable code paths which haven't been modified in a long time.
I'd like to review this patch but I'm a bit too busy with other 1.6 development and design tasks to devote adequate review time right now. I may have some time to review this in a couple of weeks, though. If you'd like to try to make this easier to review, I have a couple of suggestions (perhaps off-base, since I haven't considered them in detail yet):

Split the ContextCleaner changes into their own JIRA + PR.
Guard the external groupBy behind a feature-flag so that users have an escape-hatch in case bugs are uncovered in the new external groupBy implementation.

The feature flag definitely makes sense - I'll include that.
I think the feature is a little risky to use without cleanup at all, so I'd feel more comfortable merging them both at once.

@mccheah, to clarify: I was suggesting merging the changes to ContextCleaner ahead of this change; I agree that the cleanup changes are a blocker to merging this.

@JoshRosen sorry I lagged a bit on this.
I refactored the commit structure to clean things up, but I think we want ContextCleaner interface refactors to be its own JIRA and PR, as you suggested. The thing is, I don't think dependent pull requests on the same branch are really a thing in GitHub, so to speak. (This is different on Github as opposed to something like Gerrit, for instance).

Merged build triggered.

Merged build started.

Test build #43239 has started for   PR 8438 at commit d01cd4d.

Ok, we need to merge https://github.com/apache/spark/pull/8981 before moving forward with this one.

Oh also spilling is now behind a feature flag.

Test build #43239 has finished for   PR 8438 at commit d01cd4d.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  protected abstract class DiskIterator(file: File, blockId: BlockId, batchSizes: ArrayBuffer[Long])

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43239/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #43333 has started for   PR 8438 at commit d87b554.

Test build #43333 has finished for   PR 8438 at commit d87b554.

This patch fails MiMa tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  protected abstract class DiskIterator(file: File, blockId: BlockId, batchSizes: ArrayBuffer[Long])

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43333/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #43400 has started for   PR 8438 at commit 860811d.

Test build #43400 timed out     for PR 8438 at commit 860811d     after a configured wait of 250m.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43400/
Test FAILed.

Merged build finished. Test FAILed.

Jenkins, retest this please

I get the feeling that the spilling tests I wrote are really really slow, so I may need to adjust them.

Merged build triggered.

Merged build started.

Test build #43422 has started for   PR 8438 at commit 860811d.

Test build #43422 timed out     for PR 8438 at commit 860811d     after a configured wait of 250m.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43422/
Test FAILed.

Merged build finished. Test FAILed.

@mccheah thanks for submitting the patch. Unfortunately we haven't had the bandwidth to review a feature as large as this one, and it affects only rdd.groupByKey, which we encourage people to avoid anyway. With the new DataFrame and Dataset APIs I think there is less reason to merge this into Spark's code base.
Given that this patch has been idle for more than 2 months I would recommend that we close this issue.

Sorry, yeah I haven't had the bandwidth to look at this further. I agree that groupByKey should be avoided anyways so it might not be worthwhile to pursue this further.


Oracle and Deutsch Josza Algorithm in Qiskit

Code using Qiskit

There is an error in the format. Checking it...


Ramps don't evenly distribute states

I defined a volume ramp with three states but the volume is mapped to these states as follows:
0-25% -> state 1
25%-75% -> state 2
75%-100% -> state 3
I would have expected one third of the range to be assigned to each state.

If this is like that by design I don't think it's the right choice since the user could get the same results, if he/she so desires, by just repeating states.

This code in ramp.cpp is problematic:
size_t index = percentage * (m_icons.size() - 1) / 100.0f + 0.5f;

For example, if m_icons.size() == 3 then percentage should at least 75% in order to get 2 as the index, 75 * (3 - 1) / 100 + 0.5 == 150 / 100 + 0.5 == 1.5 + 0.5 == 2.
The interval [0, 100] should be mapped to the entire [0, 3) interval, the problem is just in the upper bound (one interval is closed the other is not) so you can simply take min(n - 1, n * p / 100.0) where n == m_icons.size() and p == percentage.

This is definitely not intentional. If you want, we would really appreciate a PR for this.

Ok, I will submit one later.
On Sun, Jul 22, 2018, 4:03 PM Patrick Ziegler<EMAIL_ADDRESS>wrote:

This is definitely not intentional. If you want, we would really
appreciate a PR for this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jaagr/polybar/issues/1328#issuecomment-406888982, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACtq-YiylbjD-0xKQgqIZCGK5U-95HGrks5uJMyJgaJpZM4VYbfm
.

Thanks!

There you have. There was no need to take the min since the index was already being capped (from below and from above) in the following line.


Added label2 to allow date ranges to have labels

What is the context of this PR?
Added a secondary label to the basic answer queries and made the relevant front-end changes to allow users to input a from and to label on date ranges.
How to review
Tests should pass and user inputted values for Date range label should show up in the publisher json.
Dependencies:
ONSdigital/eq-author-graphql-schema#28,
ONSdigital/eq-author-api#61,
ONSdigital/eq-publisher#53

 Date range labels


Aabb refactor

r? @csherratt

The usage of serde in the actual code is still gated by 'eders' feature, so it makes no sense to have the unused externals for when 'serde' is forcefully enabled but 'eders' is not.

On Jun 24, 2017, at 22:59, Coraline Sherratt<EMAIL_ADDRESS>wrote:
@csherratt commented on this pull request.
In src/lib.rs:

@@ -36,9 +37,9 @@ extern crate approx;
extern crate cgmath;
extern crate num;

-#[cfg(feature = "serde")]
+#[cfg(feature = "eders")]
I'm not sure what you are doing here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

LGTM


PuppeteerExtra Can't create multiple browser instances at the same time (Parallel instances on sharp)

I need to start 10 browser instances at the same time and work parallel to each other, but it crashes if I'm using PuppeteerExtra. I saw Puppeteer-cluster on JS, is there something like this on C#? Coz i didn't find. If not, how to implement it? I'm using different user-data. And without PuppeteerExtra it opens perfect, but I need it. I tried to make new Extra for each browser, and also tried to make one Extra to all browsers, both ways are not working.
I receive this error:
PuppeteerSharp.TargetClosedException: "Protocol error(Page.addScriptToEvaluateOnNewDocument): Target closed. (Target.detachedFromTarget)"

Solved.

Hello, how did you achieve it? I also have the same problem


WIP: Last bindings for GtkListBox + its dependencies

[x] add bindings for GListModel
[x] add bindings for GListStore

added all bindings except for 2 funcs, will stop for now, as GLib version 2.64 and higher are required

[x] add last bindings for GtkListBox

currently facing some issues with creating the bindings and I don't know why...

/glib.go.h:101:1: error: unknown type name 'GListModel'
/glib.go.h:107:1: error: unknown type name 'GListStore'

-> this works interfaces like GAction (in gaction.go)
additionally, I'm not sure if my binding for g_list_store_splice is correct...
I'm using []interface{} for input param. Also had one version with gAdditions[i] = add.(Object).GObject, but casting of a composition is not possible (to my understanding)
maybe implement existing interface IObject method toGObject() for every class?
depending on the solution, I can update my bindings for g_list_store_insert and g_list_store_append
@founderio: any suggestions?

OK, I resolved most issues, except for gtk/gtk_since_3_16.go:101:40: undefined: glib.ListModel
Maybe due to the minimum required GLib version is 2.44
I commented the code because it's not supported: README says that only GLib 2.36-2.40 are supported
@andre-hub: can be merged, if all travis builds succeed
@founderio: fyi


Test framework migration

Use Roslyn test utilities instead of DiagnosticAnalyzerRunner

Thank you for doing the work!

Haven't noticed async analyzer is also here. Reviewing.

I'm closing this PR now and submit a new one without new analyzers.


Fix of prefix bio filter (bf_prefix.c): rely on the given length

The assumption that the received buffer has to be NUL-terminated was
faulty.
Fault found in #5224

Merged.  03cb2cc9e53f7ca7539069a388d2767fffa7cf66


Testing out external scripts

Testing out calls to external scripts here.

From the 89b8c5e commit log:
ploomber.exceptions.DAGBuildError:
============================================= DAG build failed =============================================
--------------------------- CUPiDScriptRunner: divergence -> File('vector.png') ----------------------------
-------------------- /glade/work/mlevy/codes/CUPiD/examples/nblibrary/ice/divergence.py --------------------
ploomber.exceptions.TaskBuildError: Error building task 'divergence': the task ran successfully but the product File('vector.png') is missing. Ensure your code is generating it.
ploomber.exceptions.TaskBuildError: Exception when running on_finish for task 'divergence'
============================================= Summary (1 task) =============================================
CUPiDScriptRunner: divergence -> File('vector.png')
============================================= DAG build failed =============================================

@rmshkv it looks like it is creating examples/nblibrary/ice/vector.png, rather than examples/coupled_model/computed_notebooks/ice/vector.png (or maybe we want examples/coupled_model/computed_scripts/ice/vector.png?)

Perhaps I need a complete path here?

Perhaps I need a complete path here?

I don't think so -- the problem is that ploomber is running your script in examples/nblibrary/ so that's where the output is going... but we should be able to set up CUPiD so that ploomber executes it in a different location (that's what we do for notebooks)

I dug into this a little and it seems like by default local_execution is set to false for both notebooks and scripts, so I wouldn't expect the output to be saved in the nblibrary directory at first glance. When I run it myself with the current configuration I get environment errors, so not able to test myself without doing some more work on that functionality first.


Galeri

@Photo videos

Hi @riszaitan , I'm not sure we were planning on adding a SECURITY.md file. Would you mind letting us know what the goal of this PR is?


Fix formatting of WSO2_IDENTITY_DB xml segment of master-datasource xml

This PR fixes the formatting of WSO2_IDENTITY_DB xml segment of master-datasource xml
Resolves : https://github.com/wso2/product-is/issues/10911

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/527722232

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/527722232
Status: success


php_pdo_sqlsrv_71_nts_x86.dll specified module not found

Environment is a
Surface Book with Windows 10 including the anniversary update
PHP 7.1
SQL Server 2016 Developer
MS ODBC 13.1
PHP error log references the correct 71 DLL in the ext folder, but is throwing the same error as before the 71 drivers were loaded.
PHP Startup: Unable to load dynamic library 'C:\Util\PHP\7.1\ext\php_pdo_sqlsrv_71_nts_x86.dll' - The specified module could not be found in Unknown on line 0

Is the PHP 7.1 64 bit or 32 bit? 'Unable to load dynamic library' is usually thrown when the file path is not correct. Can you verify that the dll is in the correct folder?

PHP 7.1 is the 32-bit x86 version extracted from php-7.1.0-nts-Win32-VC14-x86.zip.
The correct full path and file name are being referenced in the the PHP error log as shown in the original post.
Thanks.

Can you confirm that php.ini is correctly configured? “extension_dir” should be set to where the dll is dropped, and SQLSRV extension name should be added to the list of extensions by setting “extension=php_pdo_sqlsrv_71_nts_x86.dll”.

It is. That was the first thing I checked.
From the PHP.INI:
extension_dir = "C:\Util\PHP\7.1\ext"
; Misc Extentions
extension=php_curl.dll
extension=php_mbstring.dll
extension=php_openssl.dll
extension=php_soap.dll
extension=php_fileinfo.dll
extension=php_com_dotnet.dll
extension=php_pdo_sqlsrv_71_nts_x86.dll
From the error_log:
[10-Dec-2016 17:39:52 UTC] PHP Warning:  PHP Startup: Unable to load dynamic library 'C:\Util\PHP\7.1\ext\php_pdo_sqlsrv_71_nts_x86.dll' - The specified module could not be found.
in Unknown on line 0
[10-Dec-2016 12:39:52 America/New_York] "could not find driver"

I am not able to reproduce the issue, how are you getting the binaries? Can you try the 7.1 binaries from 4.1.4 release? also the name of the binary doesn't include _x86 at the end.

+1
@dbasri Can you change the extension=php_pdo_sqlsrv_71_nts_x86.dll to extension=php_pdo_sqlsrv_71_nts.dll

OK, egg on my face. The 7.0 drivers had _x86 in the DLL file name, but the 7.1 driver does not. That worked. Thank you very much.

Had this issue as well. I was trying to use the nts (non-thread safe) when it was expecting ts (thread safe) version to be used!

SQL Server DLL file with PHP 7.2 version
https://github.com/Microsoft/msphpsql/releases
To download Windows DLLs for PHP 7.1 or above from the PECL repository, please go to the SQLSRV or PDO_SQLSRV PECL page.

Many times it has to do with the way you relate within the "php.ini" file.
Did you try adding the ".dll" extension?
Example:
"extension = php_sqlsrv_74_ts_x64" should be left as "extension = php_sqlsrv_74_ts_x64.dll"


re-run functionality: create new launch on no match?

I am trying to incorporate re-run functionality provided here by following this guide to consolidate my executions.
Have a question (perhaps a feature request, maybe) on what happens if there system is not able to find a match with same name (mentioned in handling section)

If system cannot find launch with the same name - system throws error with 404 code.

Should we just create a new launch instead? or is there an alternative way of doing this. Maybe a bool flag to create a new launch if no match is found.
Would appreciate any pointers on solving the below issue
2020-05-04 00:11:44.888 DEBUG 1 --- [nio-8585-exec-8] c.e.t.r.w.c.LaunchAsyncController        : startLaunch (1) - Request
 POST /v2/testtrends/launch
 host: <IP_ADDRESS>:8080
 user-agent: python-requests/2.23.0
 content-length: 206
 accept: */*
 accept-encoding: gzip, deflate
 authorization: bearer dummy-data-token
 content-type: application/json
 x-forwarded-for: A.B.C.D
 x-forwarded-host: <IP_ADDRESS>:8080
 x-forwarded-port: 8080
 x-forwarded-prefix: /api
 x-forwarded-proto: http
 x-forwarded-server: 92e1ed063364
 x-real-ip: A.B.C.D
 -- Body --
 {"startTime":1588551104680,"name":"1.2.3_(Build-3017) Execution","description":"Automated Behave Runner","attributes":[{"key":"build","value":"1.2.3_(Build-3017)","system":false}],"rerun":true}
2020-05-04 00:11:44.901 DEBUG 1 --- [nio-8585-exec-8] c.e.t.r.w.c.LaunchAsyncController        : startLaunch (1) - Response  (13 ms)
 Status - OK (method return)
 -- Body --
 {"id":"7c7240f1-561c-42b3-83fb-a1dc1f37f0e5","number":null}
2020-05-04 00:11:44.910 DEBUG 1 --- [cTaskExecutor-1] c.e.t.r.w.rabbit.AsyncReportingListener  : onMessage - Rabbit message
 requestType: START_LAUNCH
 projectName: testtrends
 __TypeId__: com.epam.ta.reportportal.ws.model.launch.StartLaunchRQ
 username: qauser
 -- Body --
 {"startTime":1588551104680,"name":"1.2.3_(Build-3017) Execution","description":"Automated Behave Runner","attributes":[{"key":"build","value":"1.2.3_(Build-3017)","system":false}],"uuid":"7c7240f1-561c-42b3-83fb-a1dc1f37f0e5","rerun":true}
2020-05-04 00:11:44.956 ERROR 1 --- [cTaskExecutor-1] c.e.t.r.w.rabbit.AsyncReportingListener  : exception : com.epam.ta.reportportal.exception.ReportPortalException, message : Launch '1.2.3_(Build-3017) Execution' not found. Did you use correct Launch ID?,  cause :
2020-05-04 00:11:44.959  WARN 1 --- [cTaskExecutor-1] s.a.r.l.ConditionalRejectingErrorHandler : Execution of Rabbit message listener failed.

org.springframework.amqp.rabbit.support.ListenerExecutionFailedException: Listener threw exception
	at org.springframework.amqp.rabbit.listener.AbstractMessageListenerContainer.wrapToListenerExecutionFailedExceptionIfNeeded(AbstractMessageListenerContainer.java:1683)

Should I check the response for "number":null and re-initiate the launch request without rerun?
Some details on my versioning...
reportportal/service-api:5.0.0
reportportal/service-analyzer:5.0.0
reportportal/service-index:5.0.5
rabbitmq:3.7.16-management
minio/minio:latest
docker.elastic.co/elasticsearch/elasticsearch-oss:7.3.0
reportportal/service-authorization:5.0.0
traefik:1.7.12
postgres:12-alpine
reportportal/service-ui:5.0.0

Moved to correct place (instead of documentation) https://github.com/reportportal/client-Python/issues/101


Arkadia initial upload

Changes / Comments
Initial upload for Arkadia
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[x] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Hi @Zholty I can not merge this request in because it isn't up to par with the coding standards  . It's excessive use of tables for new sheets. Please take a look and try and incorporate some of the suggestions.

Greetings,
I'm going to close this PR while as its been open for over 30 days and is still a work in progress to remove the <table>s. It can be reopened when the work is done.
Thanks,
Cassie


NextJS Page: CTA section - Button is not operable. [Need investigation]

Detailed description
Issue:
On click, Button is not operable. [Need investigation]
Additional information

Does not require a fix in our CTASection React component - just need to update the nextjs test page to pass in url data to the cta section button


I'm getting these errors.

CS0006	Metadata file '\PayCheck3-master\PayCheckServerLib\obj\Release\net7.0\ref\PayCheckServerLib.dll' could not be found
MSB3073	The command "git describe --long --always --exclude=* --abbrev=8" exited with code 128
MSB3073	The command "git.exe branch --show-current > "\PayCheck3-master\PayCheckServerLib\Properties\BuildDate.txt"

You need to install GIT (preferably a CLI version too)

Both these versions seem to give the same error. Perhaps the missing "PayCheckServerLib.dll" is the cause?

if you type "git --version" in your console does it print out the version?
If not you may have PATH issues

I am getting the same error when download the project. Clone this project to a directory worked for me.

Have you managed to fix it?


Compatibility with Ansible Galaxy

In order to make this project compatible with Ansible Galaxy, the repository must have the role content in the root of the repository. This means that the roles/cis/* must be in in the root of the repository. Then this role can be made available in the Ansible Galaxy and people can use it via ansible-galaxy command.

I'd like to get this done, too. However, my effort has been focused around http://docs.openstack.org/developer/openstack-ansible-security/ as I mentioned in #35.


Create convention file to follow in all contributions

Changes description 🧑💻

chore: Update Compose, Kotlin and AGP dependencies.
refactor(foundation): Move ripple to the Vitamin theme
refactor(buttons): Migrate to the new composable contract convention
docs: Add conventions about components.
Context 🤔

Not linked to an issue
Checklist ✅

[x] I have reviewed the submitted code
[x] I have tested on a phone device/emulator

You can download the apk here :

You can download the apk here :
sample-debug.apk :
https://app.bitrise.io/app/e9ae480151be4514/build/1456ea14-0cd6-4f27-b49b-a228c769a44d/artifact/02856e3657f54c3f/p/3a9932ad51f2d3250782f2ca7f6888fa


Extra utilites tools not usable in farming station.

Tried to put the reversing hoe and healing axe in the farming station. I can not put it into the interface.
Not sure if intended or not, i did not google this. also very little info on the farming stations to be found aswell.
DNS techpack 7.4.1 from ATLauncher
EnderIO-1.7.10-<IP_ADDRESS>

Hows it going with the reversing hoe?

Hoes can be added via the config file - try it and see if the hoe works correctly or not.

There is no entry for it and I'm not sure what to add myself?


Allow user to reload lang file

Hello, thank you for the PR.
Could you also update the README.md file (required), and add some tests (not required) please?

Hello @ocombe
I updated the readme file.
Is anything else required for this pull requests to be merged ?
Thanks

You added the method reset in the readme, but in the code it's resetLang.
Also you don't document the method reloadLang.
Once that's done I'll merge it.

My bad, wasn't attentive enough when I did this modification.
It should be ok now.
Also declared resetLang method public instead of private.

Merged in https://github.com/ocombe/ng2-translate/commit/475a1a97


Refactoring : remove / rationalise internal Monad class

AnyMImpl delegates to Monad for historical reasons, code can be moved to AnyMImpl or other locations.

Refactoring completed in cyclops-react


Do not expose Handle as IntPtr?

As IntPtr could be saved by the user. It can be used to access already freed code which is a programming error.
We could try to hide Handle again from the public API or we expose only the safe handle itself.
Afaik wrapping the safe handle again to hide the GetDangerousHandle method is only security by obscurity because a user can use reflection to get the value nevertheless.
If I remember correctly the handle is exposed just for us or other library Devs. A user of the Nuget will have no need or API available to use the handle.
With this we would only protect ourself and other library Devs against accidental access if we cache the safehandle somewhere in the code other than the object itself.
As we should never cache the safehandle (or the intptr) we could consider keeping the code as is.
I don't have a fixed opinion on this. Any thoughts or did I got something wrong with my interpretation of the situation?

Closed in favor of #397


Fix docker load command in caching example

Docker load accepts no arguments, only input

@yogevyuval : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver @chcomley @juliakm
?

@ramiMSFT Could you review the proposed changes to your article? Thanks.

Thanks @chcomley


Create bcgov Filepicker component

Description
As a Toolkit user
I want the bcgov theme to offer an Filepicker component
So that I can use the Filepicker component in my project (reusable, time-saver, progressive enhancement)
Tasks (How)

[ ] check with Connectivity team about designs
[ ] make a [componentName].tsx file in packages/[theme/src/ (can copy/paste the one that already exists in the button theme)
[ ] create a stories folder for the component (see other bcgov component stories for an example)
[ ] jest tests

Both themes have this component


project is broken: novena-afe-hs.data directory is not present in repo

the novena-afe-hs.data/ directory appears to have been excluded from this repo, so trying to open the project in PlanAhead just returns a "ERROR: [Common 17-70] Application Exception: Missing default src set in load ProjectHDMgr" error.

That directory contains generated data during compilation of the project, so I think all you need to do is to make the empty directory and the project manager should do the right thing.

I just pushed some .xml files that seem to be referenced in the .ppr that may make your life easier (or not) depending upon how the project manager wants to treat them. Worst case you can edit the .ppr file and strip out the references to the .xml files that are causing you troubles.

Thanks, the project can now be opened. But, on open, it notifies a "critical warning" about these missing files:
novena-afe-hs-fpga/novena-afe-hs.data/constrs_1/designprops.xml
novena-afe-hs-fpga/novena-afe-hs.data/constrs_1/usercols.xml
novena-afe-hs-fpga/novena-afe-hs.data/runs/impl_1.psg
novena-afe-hs-fpga/novena-afe-hs.data/runs/synth_1.psg
novena-afe-hs-fpga/novena-afe-hs.data/sources_1/chipscope.xml
novena-afe-hs-fpga/novena-afe-hs.data/sources_1/ports.xml
novena-afe-hs-fpga/novena-afe-hs.srcs/sim_1/imports/imports/trigger_tb.v
novena-afe-hs-fpga/novena-afe-hs.srcs/sources_1/ip/ddr3_if_4port/ddr3_if_4port/example_design/sim/functional/ddr3_model_c1.v

and fails synthesis due to a coregen error on the ddr3_if_4port IP block.
Can you also add the remaining files listed in that error message? If it still fails to build then I'm happy to give up.


New Feature: Replace public key

Add and test the option to replace the public key with a new seed/pk

Hello i want to contribute can you give more details please ?

Hey,
So each account is deployed with a private/public key pair, but the public key can be changed. This is already supported by the contract, but needs to be added to the lib.
It will be easier to test once I add some basic tests so we can check nothing gets broken


Throw useful error when a named segment has no name.

Previously, the following would generate a named segment with the name of "" (empty string). Which amounts to "silent failure" and pretty confusing behavior much later in the application process.
This adds an error that happens quite early (route map generation), that helps steer folks in the right direction.

@rwjblue we now have a way of handling assertions in libs that we are using in glimmer we should use them here too.


Updated library to latest RxJava and RxAndroid versions

This project was using the 2.0.0-RC2 version and RxJava 2 suffered some breaking changes in its API before hitting 2.0 stable. Updated the code to make it compatible with the latest RxJava API version. Tests are all passing.

@mradzinski thanks for the update!


multiple duplicates of node resources + source codes

VSCode Version: 1.14.0
OS Version: Windows 10

Can you add some kind of control to reduce duplicates of node modules inside VSCode?
Plus do not put source codes and development examples to release, if it doesn't require.
#28874 was closed => I create new more global bug report.

Duplicates module name
Where is copy
How many files/size we can save

nan
node_modules/, nsfw, node-pty
90 files / 1MB

graceful-fs
node_modules/, nsfw
7 files / 0.031MB

applicationinsights
extensions: git, html, json, markdown, merge-conflict, typescript
230 files / 0.750MB

vscode-extension-telemetry
extensions: git, html, json, markdown, merge-conflict, typescript
30 files / 0.075MB

vscode-jsonrpc
extensions: css (2x), html (2x), json (2x)
110 files / 0.550MB

vscode-languageclient
extensions: css, html, json
60 files / 0.420MB

vscode-languageserver-types
extensions: css (2x), html (2x), json (2x)
25 files / 0.370MB

vscode-nls
extensions: css, configuration-editing, extension-editing, git, grunt, gulp, html, jake, javascript, json, markdown, merge-conflict, ms-vscode.node-debug, npm, php, typescript
90 files / 0.225MB

winreg
extensions: git, html, json, markdown, merge-conflict, typescript
30 files / 0.260MB

jsonc-parser
extensions: configuration-editing, extension-editing, javascript, json
18 files / 0.177MB

argparse
extensions: extension-editing, markdown
27 files / 0.126MB

entities
extensions: extension-editing, markdown
13 files / 0.058MB

linkify-it
extensions: extension-editing, markdown
6 files / 0.041MB

markdown-it
extensions: extension-editing, markdown
59 files / 0.556MB

mdurl
extensions: extension-editing, markdown
9 files / 0.027MB

sprintf-js
extensions: extension-editing, markdown
13 files / 0.036MB

uc.micro
extensions: extension-editing, markdown
9 files / 0.006MB

iconv-lite
node_modules/, extensions/git
26 files / 0.342MB

agent-base
node_modules/, extensions: javascript, json, ms-vscode.node-debug, ms-vscode.node-debug2
28 files / 0.076MB

debug
node_modules/, extensions: javascript, json, ms-vscode.node-debug, ms-vscode.node-debug2
44 files / 0.136MB

extend
node_modules/, javascript, json, ms-vscode.node-debug, ms-vscode.node-debug2
24 files / 0.052MB

http-proxy-agent
node_modules/, extensions: javascript, json, ms-vscode.node-debug, ms-vscode.node-debug2
28 files / 0.096MB

https-proxy-agent
node_modules/, extensions: javascript, json, ms-vscode.node-debug, ms-vscode.node-debug2
28 files / 0.124MB

ms
node_modules/, extensions: javascript, json, ms-vscode.node-debug, ms-vscode.node-debug2
20 files / 0.032MB

request-light
extensions: javascript, json, ms-vscode.node-debug, ms-vscode.node-debug2
18 files / 0.045MB

mdurl
extensions: extension-editing, markdown
9 files / 0.027MB

balanced-match
node_modules/, node_modules/nsfw, extensions: ms-vscode.node-debug, ms-vscode.node-debug2
12 files / 0.033MB

brace-expansion
node_modules/, node_modules/nsfw, extensions: ms-vscode.node-debug, ms-vscode.node-debug2
12 files / 0.042MB

concat-map
node_modules/, node_modules/nsfw, extensions: ms-vscode.node-debug, ms-vscode.node-debug2
15 files / 0.021MB

glob
extensions: ms-vscode.node-debug, ms-vscode.node-debug2
7 files / 0.072MB

inflight
node_modules/nsfw, extensions: ms-vscode.node-debug, ms-vscode.node-debug2
8 files / 0.012MB

inherits
node_modules/, node_modules/nsfw, extensions: ms-vscode.node-debug, ms-vscode.node-debug2
15 files / 0.024MB

minimatch
node_modules/, node_modules/nsfw, extensions: ms-vscode.node-debug, ms-vscode.node-debug2
12 files / 0.124MB

once
node_modules/nsfw, extensions: ms-vscode.node-debug, ms-vscode.node-debug2
8 files / 0.014MB

path-is-absolute
node_modules/nsfw, extensions: ms-vscode.node-debug, ms-vscode.node-debug2
8 files / 0.012MB

source-map
extensions: ms-vscode.node-debug, ms-vscode.node-debug2
18 files / 0.541MB

vscode-debugadapter
extensions: ms-vscode.node-debug, ms-vscode.node-debug2
18 files / 0.167MB

vscode-debugprotocol
node_modules/, extensions: ms-vscode.node-debug, ms-vscode.node-debug2
10 files / 0.304MB

semver
node_modules/, extensions/typescript
20 files / 0.158MB

-
-
-

Total:

1214 files / 7.162MB

Percent of extensions/ + node_modules/:

21% of files / 14% of size

Source codes inside VSCode:

Module directory name
How many files/size we can save

node_modules/nan/*.h
18 files / 0.190MB

node_modules/node-pty/deps/*.cc, *h
174 files / 0.815MB

node_modules/node-pty/lib/src/
24 files / 0.044MB

node_modules/xterm/src/
44 files / 0.340MB

-
-

Total:
260 files / 1.389MB

Development examples inside VSCode:

Module directory name
How many files/size we can save

node_modules/node-pty/lib/examples/
69 files / 0.276MB

With already reduced size of lodash ( https://github.com/Axosoft/nsfw/pull/23 ) you can reduce size of next build on 9+MB and 2500+files! => Increase speed of installation on 41%! (currently main reason of slow installation - count of files)

cc @Microsoft/vscode

I have tried this: https://github.com/Microsoft/vscode/pull/15981. The ideas was to find extensions that depend on the same node_modules (same id and version) and to pull those one level up to have them shared. Risk was that node_modules might have static state which isn't meant to be shared, eg. the app insight module has a static singleton that cannot be used by different clients. So, the challenge is to know what node_modules can be safely shared across different clients.

nan | node_modules/, nsfw, node-pty

I created https://github.com/Tyriar/node-pty/issues/117 which might make the situation a little better by relying on the same version as nsfw.
It doesn't solve the issue of the other version being the one in node_modules though. It's a tricky situation as it's very dangerous to depend on a different version of a module than a module specifies. Trying to improve the install experience in other ways might be better than trying to squeeze node_modules as much as possible potentially at the cost of stability.

node_modules/node-pty/lib/src/

I believe this was due to a bad publish, created https://github.com/Tyriar/node-pty/issues/118 to prevent this in the future.

node_modules/node-pty/deps/*.cc, *h
node_modules/node-pty/lib/examples/

[ ] These should be cleaned

node_modules/xterm/src/

Sourcemaps rely on this, it's not much overhead for really nice debugging of issues.

Related https://github.com/Microsoft/vscode/issues/30640

To keep the number of issues in our inbox on a manageable level, we're closing issues that have been on the backlog for a long time but haven't gained traction: We look at the number of votes the issue has received and the number of duplicates issues filed.
Thanks for your understanding. Happy coding!

@joaomoreno Can you confirm, this closing was automatically or you do not interested in minimizing size and installation speed of VSCode?

It was neither automatic nor am I uninterested. The issue was closed simply because we have other ones open. It's just not feasible to carry around 5000 issues, so hard choices need to be made.

Also: https://github.com/Microsoft/vscode/issues/38825

Now, after you mention #38825 - I agree.
I just think collected table of duplicates in this thread can help to recheck future result of optimizations. Now #38825 has link to this thread => we can close this duplicate :)

No worries! Thanks for your passion! 👍


how to format date in mustache syntax with json template?

{{date.now}} provides the exact format of the date/time I am looking to achieve, but I need to generate past date/times for more sample date. {{date.past}} is formatting the date completely written out rather than yyyy-mm-dd. how can I fix this? i'm using kinesis data generator to create a json template.

@abeerah1 date.now and date.past are just particular objects/properties/methods in your dataset, they are not part of the Mustache language. Perhaps take your question to the maintainers of the kinesis data generator.
Very generally speaking, if date is some kind of object with now and past as methods, then the return values of those methods will be interpolated into your template. The Mustache specification however has nothing to say about what those methods will return. It's up to you to pass data into your templates that behave in a way that you like.

@jgonggrijp Here is my template so far:
[
{
    "Version": "2019-08-26",
    "AWSAccountId": "{{random.number(
        {
            "min":<PHONE_NUMBER>12345,
            "max":<PHONE_NUMBER>2345
}
)}}",

    "InstanceId": "7ed627be-486f-460d-816e-517153851070",
    "ContactId": {{random.number(
        {
            "min":<PHONE_NUMBER>123456,
            "max":<PHONE_NUMBER>23456
}
)}},

    "CustomerName": "{{name.firstName}} {{name.lastName}}",
    "Content": {{random.number(
        {
            "min": 1,
            "max": 4
}
)}},

    "AbsoluteTime": “{{date.past)}}”

]

I want the date to be randomly generated past date/time, but formatted like this: "2021-07-12T21:54:11.622Z"
is there anything I can add to what I have so far to accomplish this?

@abeerah1 I have no idea because I'm familiar with neither kinesis nor AWS. Your question doesn't seem to be directly related to the Mustache spec. I suggest you take your question to Stack Overflow, which is specifically meant for questions like these. See https://stackoverflow.com/help/how-to-ask for some tips on getting good help.

@spullara @Danappelxx I think this ticket can be closed.


[QA-1919] Terra UI test logs improvement

https://broadworkbench.atlassian.net/browse/QA-1919

I would appreciate any help to get this reviewed and merged by EOD. I think PR is very simple. Thank you.