mockAuth not working and also not found enough documentation on it.

I like this project but found more scope for documentation.
I tried by adding mockAuth setting in basicConfiguration.js
But its loading overview page directly without login page.
Luigi.setConfig({
  auth: {
    use: 'mockAuth',
    mockAuth: {
      authorizeUrl: `${window.location.origin}/assets/auth-mock/login-mock.html`,
      logoutUrl: `${window.location.origin}/assets/auth-mock/logout-mock.html`,
      post_logout_redirect_uri: '/logout.html',
      authorizeMethod: 'GET',
      oAuthData: {
        client_id: 'egDuozijY5SVr0NSIowUP1dT6RVqHnlp'
      }
    }

please let me know if something more to configure to open authorizeUrl (login-mock.html) in application before overview page.
Please help me or guide me to use above mockAuth features.

Expected result

Actual result

Steps to reproduce

Troubleshooting

Your settings are fine.
I think it is ignored because sampleConfiguration.js is referenced in index.html instead of basicConfiguration.js.
I've identified some more issues with the basic configuration and the dev server for path routing, so we need to rely on hash routing for now. Theses issues will be fixed when closing this issue.
After changing index.html to reference basicConfiguration.js and adding the configuration below, start dev server with npm run start.
Luigi.setConfig({
  auth: {
    use: 'mockAuth',
    mockAuth: {
      authorizeUrl: `${window.location.origin}/assets/auth-mock/login-mock.html`,
      logoutUrl: `${window.location.origin}/assets/auth-mock/logout-mock.html`,
      post_logout_redirect_uri: '/logout.html',
      authorizeMethod: 'GET',
      oAuthData: {
        client_id: 'egDuozijY5SVr0NSIowUP1dT6RVqHnlp'
      }
    }
  },
  navigation: {
    nodes: () => [
      {
        pathSegment: 'home',
        label: 'Home',
        children: [
          {
            pathSegment: 'hw',
            label: 'Hello World!',
            viewUrl: '/assets/sampleexternal.html'
          },
          {
            pathSegment: 'one',
            label: 'Section one',
            viewUrl: '/assets/sampleexternal.html#one'
          },
          {
            pathSegment: 'two',
            label: 'Section two',
            viewUrl: '/assets/sampleexternal.html#two'
          }
        ]
      }
    ]
  },
  routing: {
    /**
     * Development:
     * For hash routing, set to true and run `npm run start`
     * For path routing, set to false and run `npm run startWebpack`
     */
    useHashRouting: true
  }
});

Thanks for correcting, but still finding difficulty on mockAuth its not opening login page, everytime its directly open inner Hello World page.
Used below code
auth: {     use: 'mockAuth',     mockAuth: {       authorizeUrl: ${window.location.origin}/assets/auth-mock/login-mock.html,       logoutUrl: ${window.location.origin}/assets/auth-mock/logout-mock.html,       post_logout_redirect_uri: '/logout.html',       authorizeMethod: 'GET',       oAuthData: {         client_id: 'egDuozijY5SVr0NSIowUP1dT6RVqHnlp'       }     }   },
Is there way of enabling login page in luigi?

Have you tried to log out and then load the page again? Maybe you have some "valid" auth token in local storage, try to clear it, please.
As soon as you have auth.use defined it loads login page automatically unless you are already logged in previously.
Btw, feel free to join us in Slack, you find the link on the top right navigation at https://kyma-project.io

Thanks, @maxmarkus it working now after taking latest files.
Your support was excellent. I really have to appreciate that.


REST API for pipework

Hi,
I am thinking it would be great to make pipework a first class citizen in the DCOS (data-center operating system) concept.
For this to happen I believe the first step would be to have a REST API on top of pipework that would allow orchestrators to manipulate pipework remotely.
I am eager to work on such REST API, now the question is:

do you want to have the REST API as part of your current project?
or do you prefer that an independent project is created to provide the REST API?

cheers!

Hi,
That would be a great idea, but implementing a REST API in shell will be tricky :-)
I think it would be better if it were a separate project. Maybe you'd love to coordinate with @pierrecdn, whose PR #122 also has a lot of great stuff?

Looks like people want pipework is growing way beyond a simple tool!

Out of curiosity - would you use this in conjunction with Docker, or with other container systems?

Or you could use the official docker REST api / toolset, to control a pipework docker container. e.g. my dreamcat4/pipework image... e.g. docker start pipework, etc. That's what I've been doing.
Eventually we would prefer all the features of pipework to be implemented as a part docker itself. All the L2 bridge-mode networking & OVS stuff. There is an ongoing effort to do that amongst other docker teams.
So maybe it's not a long lifetime to rely upon a specific pipework API (i.e. for production systems) that will need to replace later on with something else (of official Docker networking feature). But my all means please don't let me stop you! :)


Feature: Documentation: Traversing/Manipulating State

Add some common patterns for traversing and manipulating editor state, like using Selection.insertNodes, imperative APIs, etc.

Since Lexical iOS shares most of the same APIs for traversing and manipulating state, you get double kudos if you add it to the iOS documentation too!


Uncaught SyntaxError: Invalid or unexpected token

Bug Description
Getting this error in console
edit-story.js:7 Uncaught SyntaxError: Invalid or unexpected token
Expected Behaviour
Ideally it should edit the template as new story
Steps to Reproduce
Downloaded and added latest version
Screenshots

Additional Context

Plugin Version: Version 1.9.0
WordPress Version: 5.8
Operating System: Linux
Browser: Chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Thanks for your report.
Does this still happen with all other plugins disabled?
What's your hosting provider?
Also, if you click on the edit-story.js link on the right side, what do you see?

Does this still happen with all other plugins disabled?
Which plugins need to be disabled? These are the activeones
10Web Builder	Version 1.2.57
10WEB manager	Version 1.3.31
Elementor	Version 3.3.1
Jetpack		Version 9.9
PG Export/Import	Version 1.1.7
Photo Gallery	Version 2.5.79
Photo Gallery Google Photos Integration	Version 1.0.2
Site Kit by Google	Version 1.37.0
SVG Support	Version 2.3.18
Toolset Types	Version 3.4.10
Web Stories	Version 1.9.0
WP File Manager	Version 7.1.1
WPML CMS Nav	Version 1.5.5
WPML Media	Version 2.6.4
WPML Multilingual CMS	Version 4.4.10
WPML SEO	Version 2.0.1
WPML Sticky Links	Version 1.5.4
WPML String Translation	Version 3.1.8
WPML Translation Management	Version 2.10.6
What's your hosting provider?
Bitnami Wordpress - on AWS Lightsail

Also, if you click on the edit-story.js link on the right side, what do you see?
Nothing happens

Do you want to access? I can create a test a/c

created an account for you to test

Something on your server is really, really messing with the JavaScript file contained in the Web Stories plugin, breaking it completely.
The file on your server is located here:
http://web-stories.local/wp-content/plugins/web-stories-wp/assets/js/edit-story.js (hash EF4AA92A338102A824490539FF188AE1C084B184)
The original file in the plugin is located here:
http://plugins.svn.wordpress.org/web-stories/tags/1.9.0/assets/js/edit-story.js (hash 51AF0981BE29193D5D8C159CF890D9E60776730F)
The file contents (and the hashes!) should be identical, but there are substantial differences, as you can see when comparing the files locally.
Example: your file contains the string 3rded, the original does not.
I recommend deleting & reinstalling the plugin. If that doesn't help, reach out to your website administrator or hosting provider to look for any security measures or similar that could cause this file to differ from the original.

sure. let me give a try

I had downloaded an earlier plugin from https://wordpress.org/plugins/web-stories/
I uninstalled and installed the latest from GitHub releases.. Works like charm :)
Thanks @swissspidy  :)


enable user authentication

Hello Hiromu,
I found a question past here and the 3 options for anable user authentication but i find the problem the load page 404 after change web.xml and secutiry.xml and modify in the container, use volume or create my own image.
¿Do I need to modify or add something else after doing what is indicated in web.xml and security.xml and restarting the container?.

i closed i have a problem with the docker compose version i have used..


Blob Container: Build-in zip/unzip files

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Problem
Sometimes I have archive files (.zip) in my blob container, that I'd like to unzip. Also the other way around, sometimes I have some single files that I'd like to zip.
Desired Solution
I'd like Azure Storage Explorer to let me right-click on zip-files and offers "unzip" functionality from the context menu. Other way around: I'd like to be able to select multiple files/folders, rightclick and select form context menu "create new archive".
Alternatives and Workarounds
Download zip-file, extract locally, upload. Or: Download multiple files/folders, create zip from it locally, upload zip file.
Additional Context
No response

Design in 1.27.0 and implement in 1.28.0 (1.27.0 if the design fits the schedule in 1.27.0)

@keen85 if adding this feature just means that Storage Explorer is just doing this:

Download zip file
Extract locally
Upload all unzipped files

Is that acceptable? Or are you wanting it all to happen on the server side?

Adding on to this request, I'd like to see additional features if possible:

Creating compressed files within Azure instead of locally. This could save time for some that have limited bandwidth or if the zip files are large. My use case are zip files delivered to storage containers that are greater than a GB.
Multi-volume support in both creating of compressed files and unzipping files (e.g. my_file.z01; my_file.z02; etc. etc.)
RAR or 7-Zip file support along with multi-volume support.

@MRayermannMSFT , I'd really appreciate it if the compression/decompression would happen on the server side.
I agree with @jtucker: having the compression/decompression happening on the client side comes at the cost of unnecessary network traffic. This is a cost driver, takes time and might be an overall bottle neck.
However, I'd understand if you argue that in the end a Storage Account is (as it name indicates) plain storage - that does not include compute...
Maybe this could be a feature that is additionally priced (in order to compensate for the used compute).


:farmer: CMake warning Policy CMP0153 is not set in gz-plugin1-homebrew

Environment

OS Version: MacOS
Source gz-plugin1

Description

Expected behavior: gz-plugin1-homebrew is unstable due to CMake One Warning message
Actual behavior: Build should be successful

Output
Reference build:  https://build.osrfoundation.org/job/gz_plugin-ci-ign-plugin1-homebrew-amd64/37/
Output:
CMake Warning (dev) at /usr/local/share/cmake/ignition-cmake2/cmake2/IgnSetCompilerFlags.cmake:77 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
Call Stack (most recent call first):
  /usr/local/share/cmake/ignition-cmake2/cmake2/IgnSetCompilerFlags.cmake:33 (ign_setup_unix)
  /usr/local/share/cmake/ignition-cmake2/cmake2/IgnConfigureBuild.cmake:88 (ign_set_compiler_flags)
  CMakeLists.txt:58 (ign_configure_build)
This warning is for project developers.  Use -Wno-dev to suppress it.

Fixed by https://github.com/gazebosim/gz-cmake/pull/427


download configuration with init containers

For vmauth/vmagent we have to init configuration before service start. It could be done with initContainers:
kind: VMAgent
spec:
 initContainers:
  - args:
    - -c
    - gunzip -c /etc/vmagent/config/vmagent.yaml.gz > /etc/vmagent/config_out/vmagent.env.yaml
    command:
    - /bin/sh
    image: quay.io/prometheus-operator/prometheus-config-reloader:v0.58.0
    name: config-init
    volumeMounts:
    - mountPath: /etc/vmagent/config
      name: config
    - mountPath: /etc/vmagent/config_out
      name: config-out

But it wouldn't work for custom config reloader, since it download configuration directly from secret/configmap.
Add oneshot config download mode for config-reloader and automatically add init container with gunzip command for prometheus-config-reloader.

@f41gh7
I recently tried out operator v0.33.0, which seems to include commit you reference here, but deploying a vmagent seems broken with this change.
The init container tries to gunzip the file /etc/vmagent/config/vmagent.yaml, while the actual secret contains a file called vmagent.yaml.gz.
So I think there's regression according to the filenames in the actual secret created by the operator, and the filename the init container expects to gunzip.
My VMAgent object simply looks like this:
apiVersion: operator.victoriametrics.com/v1beta1
kind: VMAgent
metadata:
  name: victoria-metrics-agent
spec:
  selectAllByDefault: true
  remoteWrite:
  - url: "http://vmsingle-victoria-metrics:8429/api/v1/write"

And the init container for vmagent simply throws:
gunzip: /etc/vmagent/config/config.yaml: No such file or directory

@FrederikNS  thanks for pointing. It was fixed at related commit and will be a part of next patch release

Thank you!

Finished at v0.35.0 release


don't create a new session for invalid Initial packets

@ptrd reported the following error: When we receive an Initial packet with a corrupted SCID, we'd still create a new session (and drop the Initial packet, since it doesn't get past the AEAD). However, the session is still created, and once we receive (the retransmission of) a valid Initial packet, we'd then use the corrupted SCID to reply to it.
This PR implements a check before creating the session. Basically, we create the AEAD in the server and decrypt the packet there. Only if it decrypts, we create the session. This is based on the realization that creating the AEAD is an order of magnitude more expensive than an AEAD operation (#2467 doesn't change this significantly):
BenchmarkAEADCreation-16    	  720339	     17222 ns/op	   10488 B/op	     171 allocs/op
BenchmarkAEADOpen-16        	13196452	       923 ns/op	    2696 B/op	       2 allocs/op

The sad thing is that we'll still decrypt the packet twice (and we have to copy all the packet data into a new buffer, to avoid touching the packet, which will have to be decrypted later). That means we're taking a (small) performance hit in the common case, in order to catch a problem in a corner case.

Codecov Report

Merging #2468 into master will increase coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2468      +/-   ##
==========================================
+ Coverage   85.42%   85.45%   +0.03%
==========================================
  Files         120      120
  Lines        9349     9345       -4
==========================================
- Hits         7986     7985       -1
+ Misses       1007     1004       -3
  Partials      356      356

Impacted Files
Coverage Δ

server.go
84.95% <ø> (+1.97%)
:arrow_up:

session.go
70.73% <33.33%> (-0.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383dab3...84d5823. Read the comment docs.

#2477 should be a better solution for this.


Thinks to be adjusted after registration of EMB and EMG

The following changes have to be incorporated once EnergyModelsBase (EMB) and EnergyModelsGeography are registered:

[x] Update the file README.md (Badge for CI, removal of Note)
[ ] Update the  file examples/README.md,
[x] Add GitHub CI based on the same files as in EMB,
[x] Remove Pkg.add(url="https://github.com/EnergyModelsX/EnergyModelsBase.jl") from the documentation.yml file,
[ ] Remove Pkg.add(url="https://github.com/EnergyModelsX/EnergyModelsGeography.jl") from the documentation.yml file, and
[ ] Add EnergyModelsGeography and EnergyModelsInvestments to the Project.toml for simplified local build of the documentation.

Reopened due to including tests for EnergyModelsGeography investments, once the package is registered..


Use the correct macro designator

Coverage increased (+0.03%) to 82.414% when pulling ab2f4a88435fd9bce3db37a926bdf3dec214ad44 on rust-av:correct-macro-designators into 7d617a479d1d1a7051993d71ff92c1e2287fc955 on xiph:master.

I would love to know why this broke.

Probing locally with cargo update, I narrowed the cause to paste v0.1.13 which was released 9 hours ago.

In general the designators aren't strictly correct so would be a good idea to land this.

Can you also backport to 0.3 branch? Building from v0.3.1 tag (due to #1434) fails in a similar way:
error: expected expression, found `TxType::DCT_DCT`
   --> src/asm/x86/transform/inverse.rs:67:33
    |
67  |               out[get_tx_type_idx($ENUM)] = Some([<rav1e_inv_txfm_add_$TYPE2 _$TYPE1 _$W x $H _$OPT_LOWER>]);
    |                                   ^^^^^ expected expression
...
134 | / impl_itx_fns!(
135 | |   // 64x
136 | |   [(TxType::DCT_DCT, dct, dct)],
137 | |   [(64, 64), (64, 32), (32, 64), (16, 64), (64, 16)],
...   |
163 | |   [(avx2, AVX2), (ssse3, SSSE3)]
164 | | );
    | |__- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

Can you also backport to 0.3 branch? For example, v0.3.1 tag is affected due to #1434:
error: expected expression, found `TxType::DCT_DCT`
   --> src/asm/x86/transform/inverse.rs:67:33
    |
67  |               out[get_tx_type_idx($ENUM)] = Some([<rav1e_inv_txfm_add_$TYPE2 _$TYPE1 _$W x $H _$OPT_LOWER>]);
    |                                   ^^^^^ expected expression
...
134 | / impl_itx_fns!(
135 | |   // 64x
136 | |   [(TxType::DCT_DCT, dct, dct)],
137 | |   [(64, 64), (64, 32), (32, 64), (16, 64), (64, 16)],
...   |
163 | |   [(avx2, AVX2), (ssse3, SSSE3)]
164 | | );
    | |__- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

Sure

Thank you sou much for fixing this!


Ignore meta refresh in HTML mails

Hello all together.
Today i've tried https://emailprivacytester.com/ to test the privacy leaks of my mail programs. K-9 was also tested and it turns out, that if you open a mail with a html meta refresh in it, it opens the desired URL fully automaticly with the default browser.
I don't know if this is a desired behaviour but i think, it is a huge potential risk for every user.
Maybe you can bind the loading of meta-tags with the request if a user wants to load pictures?
Greetings, sqozz

This will be fixed in the next major stable version.
https://github.com/k9mail/k-9/pull/529

This still appears to break on master. Not sure why this was closed?

Works for me. Tested with master as of 833e1cc4186b6703cef28a9dc825d7d68d24c1b8

To my horror, I just realized this bug existed and found this thread.
Still exploitable AFAICT. Pretty nasty indeed. :-/
Hand crafted mail tested with:
From: ...
To: ...
Subject: test
Content-Type: text/html

foo bar baz

I have just installed K9 5.010 from play-store and  tried emailprivacytester and it still opened the web-page - am I miss-understanding something here or should this issue still be open?

They refer to this being fixed with "the next major stable version" which hasn't happened yet. I haven't found out when one is expected.
/Alexander
On July 8, 2016 3:46:56 PM GMT+02:00, donid<EMAIL_ADDRESS>wrote:

I have just installed K9 5.010 from play-store and  tried
emailprivacytester and it still opened the web-page - am I
miss-understanding something here or should this issue still be open?

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/k9mail/k-9/issues/712#issuecomment-231363430

Oh, since this issue is older than 12 months, I thought there must have been a major release. That's a pity - german c't magazine has criticized this behavior of K9 already in 2013 (Issue 25 Page 104 E-Mail client comparison) in addition to a man-in-the-middle vulnerability (I don't know, if that has been fixed). So, I guess I will have to find a different mail-client until a new major version is released.
Thanks

I chose to join the beta program. I'll see where that leads me.
/Alexander
On July 8, 2016 8:35:28 PM GMT+02:00, donid<EMAIL_ADDRESS>wrote:

Oh, since this issue is older than 12 months, I thought there must have
been a major release. That's a pity - german c't magazine has
criticized this behavior of K9 already in 2013 (Issue 25 Page 104
E-Mail client comparison) in addition to a man-in-the-middle
vulnerability (I don't know, if that has been fixed). So, I guess I
will have to find a different mail-client until a new major version is
released.
Thanks

You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/k9mail/k-9/issues/712#issuecomment-231438632


btc-rpc-explorer conf file

The btc-rpc-explorer .env file changes the BTCEXP_ADDRESS_API value to none everytime that the service is restarted. Happens in v1.8 and v1.10.

Find out that the bonus.btc-rpc-explorer.sh script checks for electrs installation, and i was trying to connect to fulcrum, so, i deleted the part that checks for electrs from the script, and now is working with fulcrum, so theres no bug. Closing for now.

Check dependency of bonus.btc-rpc-explorer.sh to electrs & fulcrum again for v1.12.0


Publish for Web Components

https://github.com/webcomponents/customelements.io/issues/373

@RubaXa will you please consider adding 'web-components' to your bower.json? This would Sortable to be included by CustomElements.io
Please see the original comment.


Add row number and column name when an exception occurs.

I needed to see where a cast error was occurring, so I quickly added this information as Data fields on the thrown Exception.  Retrieve the data when an Exception occurs by catching the Exception and then looking at the ex.Data["LinqToExcel.RowNumber"] and ex.Data["LinqToExcel.ColumnName"] properties.
Noticed that someone else wanted it too (Issue #61), so here's a pull request.

Bump.

Any news? Seems fairly basic to get the row/column that fails.

I'd just like to voice my support for this request. I'm currently using this branch as the row and column numbers on exceptions are extremely helpful.

This is a very interesting and helpful feature to be added.
Does anyone pretend to approve this pull request?

I can review it, but you have to understand that the project maintainer doesn't have time anymore, and I have little time as well.

I'd like to see something like this get added too. But, personally, I'd rather not just add to the Data dictionary of any Exception thrown. I'd rather throw an appropriate exception (with Row/Column properties), and set its inner exception to the original exception.
This PR is over 3 years old, so I don't think I can just ask the OP (@clstopher) to update it, or identify the exception that was being thrown any more. So, that's probably going to be down to me to fix up...

Created another pull request #125 throwing a customized Exception based on this solution.

Given the age of this original PR, I am closing it in favour of PR #125 as it is more up to date.

Just to reference issue #61 .


Libdoc: Support searching keywords by name, arguments, and keywords

Especially with bigger libraries, it would be useful if Libdoc outputs had built-in search capability. It is possible to use browsers' search functionality, but it will search everywhere on the page. Dedicated search functionality could allow searching by name, arguments, documentation, and could show only the matching keywords.
Because Libdoc outputs is already now generated dynamically using Javascript, this shouldn't be too complicated to implement. We thus try to get it already into RF 2.8.7. Some kind of search functionality is a must latest in RF 2.9 when we plan to support keyword tags (#1840).

@rainmanwy: After revision 1dffe84 opening search always scrolls to shortcuts section. That was easy to implement and seems to work fine. Scrolling can be fine-tuned in future releases if needed.

After the latest fixes and enhancement @jussimalinen and I consider this issue done.

Ok, thank you very much!


Star Citizen not being installed

Splitting off from #122 since we're having different problems now.
As a recap, on the master branch with a fresh install of Star Citizen (no Wine prefix in $HOME/Games/star-citizen) I'm getting the following output when running the star-citizen script:
Error: File not found - /home/joe/Games/star-citizen/drive_c/Program
Error: File not found - Files/Roberts
Error: File not found - Space
Error: File not found - Industries/RSI
Error: File not found - Launcher/RSI
Error: File not found - Launcher.exe
wine: WINEARCH set to win64 but '/home/joe/Games/star-citizen' is a 32-bit installation.
wine: WINEARCH set to win64 but '/home/joe/Games/star-citizen' is a 32-bit installation.
gamemodeauto:
wine: WINEARCH set to win64 but '/home/joe/Games/star-citizen' is a 32-bit installation.

This is accompanied by no GUI output, although the Wine prefix and the "$WINEPREFIX/drive_c/Program Files/Roberts Space Industries/StarCitizen/"{LIVE,PTU} directories are created. However, none of the directories are populated, and it seems that RSI-Setup-${version}.exe never runs.
Switching to @LovingMelody's new PR #124 and allowing it to compile the uncached version of proton-ge that is used there solves the File not found errors. Starting from a fresh Wine prefix again gives the following output:
------------------------------------------------------
Creating WINEPREFIX "/home/joe/Games/star-citizen" with WINEARCH=win64
------------------------------------------------------
wine: created the configuration directory '/home/joe/Games/star-citizen'
wine: WINEARCH set to win64 but '/home/joe/Games/star-citizen' is a 32-bit installation.
------------------------------------------------------
WINEPREFIX INFO:
Drive C: total 12
drwxr-xr-x 3 joe users 4096 Oct 24 19:47 .
drwxr-xr-x 4 joe users 4096 Oct 24 19:47 ..
drwxr-xr-x 3 joe users 4096 Oct 24 19:47 windows

Registry info:
/home/joe/Games/star-citizen/system.reg:#arch=win32
/home/joe/Games/star-citizen/userdef.reg:#arch=win32
/home/joe/Games/star-citizen/user.reg:#arch=win32
------------------------------------------------------
------------------------------------------------------
warning: wine cmd.exe /c echo '%AppData%' returned empty string, error message "wine: WINEARCH set to win64 but '/home/joe/Games/star-citizen' is a 32-bit installation."
------------------------------------------------------
wine: WINEARCH set to win64 but '/home/joe/Games/star-citizen' is a 32-bit installation.
wine: WINEARCH set to win64 but '/home/joe/Games/star-citizen' is a 32-bit installation.
gamemodeauto:
wine: WINEARCH set to win64 but '/home/joe/Games/star-citizen' is a 32-bit installation.

Again, there's no GUI output and the directories are created but not populated. Running the script again yields
wine: WINEARCH set to win64 but '/home/joe/Games/star-citizen' is a 32-bit installation.
gamemodeauto:
wine: WINEARCH set to win64 but '/home/joe/Games/star-citizen' is a 32-bit installation.

From looking at the output that another user was getting in #122, I don't think I should be getting this 32-bit installation message. I'm not sure what's causing it either, since the Wine prefix is clearly being created as win64, but the created prefix shows #arch=win32 in the prefix's system.reg.
Is the 32-bit message a red herring, or is this actually preventing the setup exe from running?

It looks like this was a system configuration issue. I was previously installing Wine via
environment.systemPackages = with pkgs; [
  winePackages.unstable
  wine64Packages.unstable
  winetricks
];

However the NixOS wiki page  for Wine helpfully points out that I should've been using wineWowPackages to get proper 64-bit Wine support. I'd been working on the assumption that the star-citizen derivation was pulling in its own version of Wine, but it seemed to have been using the system default, hence why it was creating exclusively 32-bit Wine prefixes.
I can get the launcher to start now so I'll close this here. Hopefully I can get the game running!


Cannot use httplib2 with ansible on darwin

When I try to use the URI module (core ansible module) I get the following error :
httplib2 is not installed

I'm using nix from master on OSX 10.11 with ansible 1.9.4 (from nixpkgs.ansible)
This is what I already tried without success :
pip install httplib2 : permission denied error
nix-env -iA nixpkgs.python27Packages.httplib2 : problem still there.

How are you using ansible?

nix-shell -p ansible --command "python -c 'import ansible; import httplib2'" works for me

ping

Worked with nix-shell.
Thanks.


failed to generate project

This is a very interesting project, but it failed to generate the nestjs project from this openapi example https://editor.swagger.io/
❯ codegen -s ./openapi.yaml -p openapi
? Do you want to create a database module? not
? Do you want to create a kafka module? not
? Do you want to create a project? Yes
/home/ian/.local/share/pnpm/global/5/.pnpm/@newko+swagger-nestjs-codegen@1.3.3/node_modules/@newko/swagger-nestjs-codegen/lib/components.js:45
        throw Error(
              ^

Error: Pet => Schemas object properties type in undefined
    at /home/ian/.local/share/pnpm/global/5/.pnpm/@newko+swagger-nestjs-codegen@1.3.3/node_modules/@newko/swagger-nestjs-codegen/lib/components.js:45:15
    at /home/ian/.local/share/pnpm/global/5/.pnpm/lodash@4.17.21/node_modules/lodash/lodash.js:4967:15
    at baseForOwn (/home/ian/.local/share/pnpm/global/5/.pnpm/lodash@4.17.21/node_modules/lodash/lodash.js:3032:24)
    at /home/ian/.local/share/pnpm/global/5/.pnpm/lodash@4.17.21/node_modules/lodash/lodash.js:4936:18
    at Function.forEach (/home/ian/.local/share/pnpm/global/5/.pnpm/lodash@4.17.21/node_modules/lodash/lodash.js:9410:14)
    at /home/ian/.local/share/pnpm/global/5/.pnpm/@newko+swagger-nestjs-codegen@1.3.3/node_modules/@newko/swagger-nestjs-codegen/lib/components.js:42:7
    at /home/ian/.local/share/pnpm/global/5/.pnpm/lodash@4.17.21/node_modules/lodash/lodash.js:4967:15
    at baseForOwn (/home/ian/.local/share/pnpm/global/5/.pnpm/lodash@4.17.21/node_modules/lodash/lodash.js:3032:24)
    at /home/ian/.local/share/pnpm/global/5/.pnpm/lodash@4.17.21/node_modules/lodash/lodash.js:4936:18
    at Function.forEach (/home/ian/.local/share/pnpm/global/5/.pnpm/lodash@4.17.21/node_modules/lodash/lodash.js:9410:14)

Node.js v18.7.0

Hi Yiheng, If you create a project based on the openapi example, you cannot
create it.
You can know the basic structure by creating a project through the
codegen-example command.
Please check README.md for the criteria for creating yaml files. It's not
hard.
Because we need to create a project based on the Nest.js framework, we
don't support features supported by openapi, so please check the README.md
file.
Thank you. If you contact me if you need anything, I will update the
function.

Message ID: @.***>


add --init to definitions

closes: https://github.com/microsoft/vscode-dev-containers/issues/917

One note - We'll also need to add the equivalent to docker-compose.yml for those definitions.
services:
  app:
    #...
    init: true

I did in some places, and was going to ask you.  Many of the docker-compose definitions have explicit versions at the top, and init was introduced in version 3.7.  https://docs.docker.com/compose/compose-file/compose-file-v3/#init
You see any harm in updating/removing the version for those docker-compose definitions?

One example is https://github.com/microsoft/vscode-dev-containers/blob/main/containers/javascript-node-postgres/.devcontainer/docker-compose.yml pinned at version 3.0

I think 3 is interpreted as 3.x -- so 3.9.   You'd need to use 3.0 to pin to that version.  (The only place this wasn't happening in the old version of docker-compose.) That said, I think it's fine to pin to a recent Docker Compose version.

I think 3 is interpreted as 3.x -- so 3.9.

I'd assumed that too, but the docs say differently:
https://docs.docker.com/compose/compose-file/compose-versioning/#v2-and-v3-declaration
"When specifying the Compose file version to use, make sure to specify both the major and minor numbers. If no minor version is given, 0 is used by default and not the latest minor version."

Interesting, then,  yeah, we probably should pick a later version.

Shouldn't we add this to the extension instead of adding it to all definitions?

@chrmarti Very happy to do so as I commented here https://github.com/microsoft/vscode-dev-containers/issues/917#issuecomment-919383191.  Do we want to make that the plan?  If so, I'm good with it.

We could add it automatically if overrideCommand is not false to give the user some control. What do you think?

@chrmarti Yeah it sort of needs to be its own property.  The challenge is that if you want to use systemd, you can't have this enabled since you have to be PID 0.  We have runArgs for when we need to add it ad-hoc, but with features we'll need some way of enabling it.

Hello. It looks like --init hasn't been added to some definitions, is this intentional?

@eitsupi - which definition are you referring to? There are a couple I don't think i updated for various reasons, and also some I may have missed.

@joshspicer I've noticed R (I was paying attention because I am contributing) and Julia as far as I can see from the container list.
But I don't fully understand the need for --init, so it may not be the case.

The intention of these changes was just as a performance optimization (since most of the time these containers are intended to be long-running processes). Looks like there was no reason to exclude these two - so adding the line in.  Thanks!


pull request for e2e test at 01/25/2017 15:15:08

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


No map issues identified in Ireland

Using the plugin in JOSM, I can see issue circles in various colours covering much of Europe and into north Africa. None are visible in Ireland. Maybe we just have a very successful community fixing issues the moment they arise, but is it possible that no analysis is taking place?

The ImproveOSM issues are identified in areas where we have navigation data. In Ireland, we have almost no data, so this is why we don't have any ImproveOSM issue.


Support for manual trigger of release image job

We have seen instances where the release job does not get triggered after a PR gets merged and because of this, the devel image still points to some old commit which produces inconsistent results. This PR includes support to manually trigger the release job in such scenarios.

E2E (globalnet, 1.25) failed, re-running.


Fluid and Brush Select UI

Add powder toy style UI at least for testing that will allow the user to paint with different fluids and brush types

Work on this has started, right now the button simply changes the overall simulation fluid properties, need to add individual particle level properties to proceed with this.

I'll mark this as complete because the ui is there and make new issues for the actual functionality.


Create a guide on sending ZetaChain-compatible Bitcoin transactions programmatically using the Xverse wallet

Overview
Currently, we have two guides on how to send ZetaChain-compatible Bitcoin txs using XDEFI and UniSat:
https://www.zetachain.com/docs/developers/tutorials/bitcoin/
We need to extend this guide to support the Xverse wallet.
Xverse is capable of signing arbitrary PSBTs, so it should be compatible with ZetaChain. As Xverse doesn't have an easy to use API for sending a memo (like XDEFI's hex::), this guide might end up being a bit longer, which is fine.
ZetaChain's requirements to Bitcoin txs:
https://www.zetachain.com/docs/developers/evm/bitcoin/
As for the template there are two paths:

Use the same no-framework index.html and JS approach currently used in tutorials (count this option as 1 contribution) OR
Using https://github.com/zeta-chain/example-frontend as the foundation and migrating all three tutorials (XDEFI, UniSat and Xverse) to it. (count this option as 2 contributions)

Deliverable
A guide on how to send a ZetaChain-compatible Bitcoin transaction using Xverse.

@mikelord007 any updates on the progress?

@fadeev have only gotten a chance to start recently. Will be finishing by this weekend

@mikelord007 please, update on progress.

hey @fadeev please check https://github.com/zeta-chain/docs/pull/377


Determine correct gas handling for purchase

It was quick'n'dirty to get purchasing working, with gas for the purchase hard-coded. This needs to be done right.
~~https://github.com/OriginProtocol/demo-dapp/blob/master/src/services/contract-service.js#L131~~
https://github.com/OriginProtocol/demo-dapp/blob/master/src/services/contract-service.js#L129

So we do have to send a recommended amount of gas along with the transaction request to the user. Given our gas use tracker, we should be able to pick values that are pretty close to the real costs - and since these gas totals will be in origin.js, our tests will be checking that the estimated amounts actually work.

This is taken care of for the time being in https://github.com/OriginProtocol/origin-js/pull/118


Read size not retrieved from text box

It seems there is a bug in BossaWindow::OnRead(wxCommandEvent& event) line 437:
        offset = strtol(_sizeTextCtrl->GetValue().mb_str(), &end, 0);

where the resulting number should be stored in size variable and not offset.

Right you are.  Fix is in master.


$agent->device, $agent->platform, $agent->browser is ZERO "0"

When I make a call from native iOS app built with Swift 3 ......all this three properties return as "0"
$agent->device, $agent->platform, $agent->browser
Can you please help?...why it doesn't detect that the call is being made from iPhone  & also the iOS platform info.
Thx.

you probably make call with ajax and expect json back, perhaps it can't manage that, you are not even using browser but native iOS app, your app should send device info to server so sever knows its mobile or tablet.


Moved get_ethereum_address from ecdsa to bip32

The new name of the function is hdnode_get_ethereum_address
and it gets a hdnode as input as opposed to a public key.  This
also avoids first computing the compressed public key and then
uncompressing it.
Test cases were adapted to work with new function.  The test-vectors
are the same as for bip32 and independently checked with an adhoc
python implementation.

Thanks!


Saving tournament report

Hello,
It would be great if we could save the tournament report in markdown file. This command is not working esrally compare --baseline=XX --contender=XX --report-file=tournament.md

Hello @danielmitterdorfer ,
Could you please look at the PR - Saving tournament report [Closes #249] and let me know your thoughts.
Thank you,

Added target release 0.5.3 based on the assumption that #250 gets merged.


Sailee: test-DAT-16470

Impact

[ ] Bug fix (non-breaking change which fixes expected existing functionality)
[ ] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

Things to be aware of

Things to worry about

Additional Context

testing done


Firebase Face Detection Api issue whileusing cameraX API

Hi team,
I used Camera X Api for detecting faces in Firebase ML kit because you used the depreciated camera API in our example and I faced a lot of performance issues in it.
CameraX API works perfectly but I am stuck in one place. CameraX uses Texture view in the layout view to open the camera and I want to show 3d objects and filters on the face.
In the example, we use CameraSourcePreview and GraphicOverlay classes in the quickstart sample app to show objects on the relative part of the face.
So, Could you please let me know how to how to achieve the same thing using cameraX Api.
Any help will be appreciated.
Thanks
// TODO(you): code here to reproduce the problem

@Anasmirza20 this sounds like it's a question/issue with CameraX not with ML Kit in particular (or with this sample).
I would suggest asking here:
https://github.com/android/camera-samples


Model hasMany Media::class

I want to insert in an Article model some images. How you suggest to develop? Is it possible to integrate spatie/medialibrary for example?

Hi @physio ,
You should be able to integrate spatie/medialibrary, yes, but I think it will be easier to use the upload_multiple field type: https://laravel-backpack.readme.io/docs/crud-fields#section-upload_multiple
Hope it helps. Cheers!


Write Readme for delevopers

Please read the E-Mail from Florian to understand the requirements. Then write the Readme for the developers.
Following questions should be answered:

How does the code work? (Diagramm)
What functions and classes do we have?
Any algorithms or calculations that would be nice to explain?

You can read through the documentation here:
https://github.com/lucasthierry17/Ant_Project/blob/main/README.md


Enable/disable log message categories at runtime

Currently the custom logger allows enabling/disabling log messages at runtime depending on their loglevel.
There are also log message categories that can be enabled/disabled via defines:
WS_CLIENT_LOG_HANDSHAKE
WS_CLIENT_LOG_MSG_PAYLOADS
WS_CLIENT_LOG_MSG_SIZES
WS_CLIENT_LOG_FRAMES
WS_CLIENT_LOG_COMPRESSION

These message categories can only be enabled/disabled via defines, but it also makes sense to enable/disable them at runtime.
For example if the user suspects that the server sends him wrong information, he may temporarily enable logging of message payloads (WS_CLIENT_LOG_MSG_PAYLOADS) in the program config file, troubleshoot the problem and then disable it again in the config file.
Currently it is not possible to do that by disabling messages by message level because message payloads are logged at the info level (Level::I), which is a relatively high level. If the user disabled messages at the info level and below, he might miss some useful messages.
So it probably makes sense to add a message category too and enable/disable the category at runtime by calling methods like
template <LogCategory category>
is_category_enabled()

which is similar to the current
template <LogLevel level>
is_enabled()

Alternatively another probably easier solution would be to move the payload logging to another log level, e.g. trace, which is more verbose than the debug level, so the log levels would be :
// 0 = disabled, 1 = error, 2 = warning, 3 = info, 4 = debug, 5 = trace
enum class LogLevel : uint8_t
{
    N = 0, // Disabled
    E = 1, // Error
    W = 2, // Warning
    I = 3, // Info
    D = 4,  // Debug
    T = 5 // Trace
};

This would allow cutting off the payload logging at runtime without affecting the other log messages.

Actually after giving the problem more though, I came up with another idea. Maybe it would be easier to change these defines:
WS_CLIENT_LOG_HANDSHAKE
WS_CLIENT_LOG_MSG_PAYLOADS
WS_CLIENT_LOG_MSG_SIZES
WS_CLIENT_LOG_FRAMES
WS_CLIENT_LOG_COMPRESSION

from a boolean (0 or 1) to a numeric constant equivalent to one of of LogLevel constants, so that
0 means that logging of the corresponding category is disabled
1 means log at the error level
2 means log at the warning level
3 means log at the info level
4 means log at the debug level
5 means log at the trace level (provided that this extra constant is added)

I can provide a PR for this feature if you think that it makes sense.

Hi,
Yes, I had this approach in my mind in the past as well, just didn't bother implementing it yet.
The solution to have runtime-adjustable logging, but still maintain the ability to optimize away all logging code, is to keep the define flags (or potentially something constexpr), but additionally pass a log category to the logger call. If we want runtime-adjustable logging, we can set all defines to 1, so all logging code is compiled, and do the category/level filtering in the logger implementation itself, which will get the level and category as parameters.
Log-level per category is something to think about.
I'll look into it next week, I also have switching from std::stringstream to fmt form the standard on my to-do list, which could be tackled together.

Great. Thank you for looking into this issue.
Switching from std::stringstream to std::format will definitely simplify building the log messages.
Essentially what I (and probably other users) need is the ability to turn on/off at runtime the logging of payload data. It takes lots of space in the logs, so by default it should be turned off. But if a problem is found it should be possible to turn it on temporarily without recompiling the executable.
There are various ways to tackle this issue and I am not sure what is the best one.
The simplest solution would be to change the category defines (WS_CLIENT_LOG_MSG_PAYLOADS, etc) from boolean (0or 1) to log levels (0 to 4) for the corresponding categories. Then use the runtime-configurable log level to cut off logging for the messages at the specified category, including the unwanted categories. This has the added benefit that if the corresponding category (e.g. WS_CLIENT_LOG_MSG_PAYLOADS) has the value 0 (which is equivalent to LogLevel::N), then its logging code will be completely removed from the compiled executable. I imaging that the code would be something like this:
#if WS_CLIENT_LOG_MSG_PAYLOADS
    logger_->template log<static_cast<LogLevel> (WS_CLIENT_LOG_MSG_PAYLOADS)>(std::format (...));
#endif

But then again there could be other, better approaches. I am fine with any approach as long as the different categories (more specifically payloads) can be skipped at runtime from logging.

Hi,
I have implemented log topics and levels per topic, runtime-adjustable and thread-safe.
Please note that the WS_CLIENT_LOG_***** defines have changed and now represent the default log levels, 0 will optimize away the logging code for that respective topic.
Also note that the ConsoleLogger type signature has changed, the min. log level is not a template parameter anymore, but a constructor parameter instead, see examples.
Check the README for more information, also see this example examples/builtin/ex_echo_builtin.cpp which changes the log level of some topics at runtime after logger creation using the set_level function.
If anything is unclear, let me know.

Great! Thank you very much for the updates, they are exactly what I need.


Refactor and add RadioButton component

See example and readme for details

Was it meant to be a pr for different fork?

This fork has 100% same API. If this pull request will be accepted I will use this repository.

To me this is a completely different API and a different library. The fact that is still keeps the previous code to serve old API does not change it.
PS: and just in case all the naming and authors changed too...
Generally if the library has a different API it should be considered, well, a different library. You'd better not have 2 different APIs doing same thing in a single library.

I believe react-radio-group's goal is to be as low level as possible so others can build on top of it. While your additions might be helpful to a lot of people, I don't think it's a generic enough solution to be helpful for everyone. So I'm in favour of you releasing this as a separate library and then maybe the README of react-radio-group could add a list of projects which add useful functionality.

One of main goal was to explore this new (for the time) approach of rendering children as function. Plus what @danielberndt said
Sorry, but will close the pr


[v1.3] Documentation Merger

Coverage remained the same at 53.337% when pulling 7bebda620c72e280ce247c6af71c6d46fb8be4fd on documentation into 132fff8d147d2cc773d4d35b787b0d37506a867b on master.


pornhub extractor not working

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that a supported site is broken
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Italy
Provide a description that is worded well enough to be understood
pornhub extractor not working
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['https://www.pornhub.com/view_video.php?viewkey=ph5cfd4971ccb2a', '-vU']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (zip)
[debug] Python 3.9.6 (CPython x86_64 64bit) - Linux-5.18.0-1.el7.elrepo.x86_64-x86_64-with-glibc2.17 (OpenSSL 1.0.2k-fips  26 Jan 2017
, glibc 2.17)
[debug] exe versions: ffmpeg 5.0.1-static (setts), ffprobe 5.0.1-static
[debug] Optional libraries: no_Cryptodome-None
[debug] Proxy map: {}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>
Current Build Hash: 91cad9f121c1f6f0a81b747415c46ecba0ff331ed38cc6433040b4ac7b6e15ca
yt-dlp is up to date<EMAIL_ADDRESS>
[PornHub] Extracting URL: https://www.pornhub.com/view_video.php?viewkey=ph5cfd4971ccb2a
[PornHub] ph5cfd4971ccb2a: Downloading pc webpage
[PornHub] ph5cfd4971ccb2a: Downloading tv webpage
ERROR: [PornHub] ph5cfd4971ccb2a: Unable to extract encoded url; please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?
q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 694, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/pornhub.py", line 403, in _real_extract
    js_vars = extract_js_vars(
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/pornhub.py", line 340, in extract_js_vars
    assignments = self._search_regex(
  File "/usr/local/bin/yt-dlp/yt_dlp/extractor/common.py", line 1242, in _search_regex
    raise RegexNotFoundError('Unable to extract %s' % _name)

Duplicate of #4299


Search through the eye, with the ox_inventory inventory

Help?

GH issues are not for support, go discord

Help?

No?


Inconsistent keyword usage in closed property of rectangular profile

Describe the bug
The closed keyword in HYDROLIB-core/hydrolib/core/dflowfm/crosssection/models/RectangleCrsDef defaults to True, but D-HDYRO (v23.01) expects "yes" and "no"; as described in the user manual (Table C.24)
Expected behavior
write yes or no to crsdef.ini
replacing: closed: str = Field(True)
by: closed: str = Field("yes")
fixed it for me

@rhutten I was told that if the kernel expects a boolean for a keyword they accept all values such as: 1, y, yes, t, true, j, ja and several more. Given that the kernel can handle all these values, do you think we should still update how the closed keyword is written to the file?
In HYDROLIB-core we basically always write booleans as 0 or 1.

@veenstrajelmer I cannot verify the problem anymore as I am not working with D-HYDRO anymore, but this issue was not solely pointing out an inconsistency. I believe it either caused the affected profile to not be loaded in the GUI, or the DIMR set to not being loaded in the GUI.

Regarding consistency: I've decided do try and change all boolean settings in D-Flow FM to print true and false in mdu/dia/ini files, and will include the frontend development team to also try and make that change.
Backwards compatibility in kernel: old yes/no/1/0 values will still be supported for a while, but hydrolib-core can stop supporting old values in an upcoming release.

@tim-vd-aardweg : I think remaining work for hydrolib-core is to update the matching fields in the various Comments classes, for example:
        closed: Optional[str] = Field("no: Open channel, yes: Closed channel.")
...
        usevolumetables: Optional[str] = Field(
            "Use volume tables for 1D grid cells (1: yes, 0 = no).",
...

Follow-up issue created to update comments: https://github.com/Deltares/HYDROLIB-core/issues/673


Expand upon Membership #1 List all memberships

As a user I should be able to see all available memberships.

User can now see all clients assigned a membership instead.


Collapse doesn't take account of element's height

Consider the following example, where initially collapsed = msgShown = false:
<div [collapse]="collapsed">
    <div *ngIf="msgShown">
        Message text
    </div>
    <div>
        Main text
    </div>
</div>

Setting msgShown = true appears to replace "Main text" by "Message text", rather than showing them both. This is because the height of the outermost div is not updated, effectively hiding "Main text".
Cheers.

Confirmed, faced with the same issue when played with nested collapsed components. When nested collapse is open, parent collapse doesnt recalculate its height which causes hiding of nested collapse's content.

For anyone else faced with this issue, one can alter collapse.component.ts by uncommenting:
@HostBinding('style.height')
  private height:string;

and also:
this.height = 'auto';

in the public method "show".

@valorkin Any updates here? Solution provided by @rob-myers doesn't work in my case. Host's height doesn't recalculate if child's content height was increased dynamically (e.g. some elements was added to list)


Move typescript definition file into the project

Move typescript definition from DefinitelyTyped repository to the project.
This would help to prevent releases of prosemirror-tables before the type is updated in DefinitelyTyped repository.
This has been done in similar way for packages like redux.

Maybe we could do something similar to what redux does too.
A deprecation warning about the old types.
npm WARN deprecated<EMAIL_ADDRESS>This is a stub types definition for Redux (https://github.com/reactjs/redux). Redux provides its own type definitions, so you don't need @types/redux installed!

@nathf can you please have a look?


atom.service is depricated

atom.services is no longer available. To register service providers and
consumers, use the providedServices and consumedServices fields in
your package's package.json.
Atom.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app/src/atom.js:64:11)
Object.activate (/Users/user/.atom/packages/autocomplete-snippets/lib/autocomplete-snippets.coffee:8:25)

Yes, we're aware of this - see https://github.com/atom/atom#5277


gb/cmd: TestTestExtraFlags fails intermittently

--- FAIL: TestTestExtraFlags (0.00s)
        testflag_test.go:44: TestExtraFlags([-q -debug package_name]): want ([-q package_name],[-debug]), got ([package_name -q],[-debug])
FAIL
FAIL    github.com/constabulary/gb/cmd  7.045s

Most likely due to map ordering

@demizer please fix this before merging #124

Hi. I think this is fixed in #124. I believe this version of the code contained bad logic. I have ran all of the tests over 30 times using my testflag branch and haven't been able to reproduce.

Cool. Thanks. I'll merge #124


Add --zstd-workers option

This PR attempts to add --zstd-workers option for multithreaded zstd compression.
zstd compression could take longer than training when using large dictionaries such as NEologd.
This option reduces compression time.

Added zstdmt feature to enable multithread method
Added zstd_workers argument for the number of workers for zstd. Default is zero that disables multithread.
Added codes to call multithread method with zstd_workers

@akirakubo Thank you for the great improvement.
There is a compile error in Nightly Rust. https://github.com/rust-lang/rust/issues/117602
I will merge this PR after it is fixed.


chore: add watch script for unit test DX, ignore coverage dir

Summary
Adds a --watch option for the npm test script with coverage flag set to aid with the unit test developer experience.
Implementation details
Run npm run test:unit:watch to start jest in watch mode. --coverage flag is also set to generate coverage report for checking code paths within functions.
How to validate this change
No user impact.

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Reason: null

Start Time: 2022-02-01T18:59:23.763+0000

Duration: 14 min 55 sec

Commit: 60b5ab0ecd6ebe9e3649c02fe8630dfad04af565

Test stats :test_tube:

Test
Results

Failed
0

Passed
54

Skipped
0

Total
54

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


chore(stryker): #406 Upgrade sinon to version 4.0

Fix unittest that used deprecated code

LGTM! Thanks :)


Issue with interval censoring for CoxPHFitter

Hi there,
Calling fit_interval_censoring on an instance of CoxPHFitter leads to an odd error.
For example, running the test codes below leads to the following result:
Test Codes
from lifelines import CoxPHFitter
from lifelines.datasets import load_diabetes

df = load_diabetes()
df['gender'] = df['gender'] == 'male'

print(df.head())

cph = CoxPHFitter()
cph.fit_interval_censoring(df, lower_bound_col='left', upper_bound_col='right')
cph.print_summary()

Errors
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-11-870e534d8026> in <module>
      8
      9 cph = CoxPHFitter()
---> 10 cph.fit_interval_censoring(df, lower_bound_col='left', upper_bound_col='right')
     11 cph.print_summary()

~/opt/anaconda3/lib/python3.8/site-packages/lifelines/fitters/coxph_fitter.py in __getattr__(self, attr)
    296             raise AttributeError("Must call `fit` first.")
    297
--> 298         if hasattr(self._model, attr):
    299             return getattr(self._model, attr)
    300

~/opt/anaconda3/lib/python3.8/site-packages/lifelines/fitters/coxph_fitter.py in __getattr__(self, attr)
    294     def __getattr__(self, attr):
    295         if attr == "_model":
--> 296             raise AttributeError("Must call `fit` first.")
    297
    298         if hasattr(self._model, attr):

AttributeError: Must call `fit` first.

I am running

Python 3.8.3 (default, Jul  2 2020, 11:26:31)
lifelines 0.25.5

on JupyterLab.
Reading up the doc I thought I could just call it directly on a CoxPHFitter class. Am I doing something wrong here?
Thanks!

Right, I'll need to put a control in for this case. So the semi-parameteric CoxPHFitter(i.e. breslow baseline estimation, the default) can't do interval censoring - you need to instead use a different baseline estimator, like so:
CoxPHFitter(baseline_estimation_method="spline").fit_interval_censoring(...)

Thanks for the advice. At the moment, other options for estimating the baseline function also run into the same error. I'll switch over to a parametric model for now.

??? really? Oh wow you are right. Hm, I'll probably fix this asap then

Huh, this never worked, and I always thought it did haha. I'll push something later today.


Source map updates for classes

Adds missing mapping for closing braces for functions, and classes.
edit: I made a few additions after discussing with @mhegazy — rbuckton

Fixes the following tests:

tests/cases/conformance/es6/computedProperties/computedPropertyNamesSourceMap1_ES5.ts
tests/cases/conformance/es6/computedProperties/computedPropertyNamesSourceMap2_ES6.ts
tests/cases/compiler/commentOnSimpleArrowFunctionBody1.ts
tests/cases/compiler/detachedCommentAtStartOfLambdaFunction1.ts
tests/cases/compiler/lambdaASIEmit.ts
tests/cases/compiler/sourceMapValidationDebugger.ts

CC: @yuit, @mhegazy, @vladima, @DanielRosenwasser, @sandersn

:+1:


Alert doesn't close when 'go back' or 'go forward' in browser

If user won't confirm or cancel alert and he just press 'go back' in a browser - Alert is still mounted.

This is how React works. You can listen history change and set show: false when it mounted.

Added a new history-change example: https://github.com/chentsulin/sweetalert-react/blob/master/examples/history-change/components/App.js


Customizing webpack config problem on Windows

Expected Behavior
When i want to extend  usage of Webpack by creating webextension-toolbox.js, it should just work.
Current Behavior
I add webextension-toolbox.js, paste code from readme, and add jquery plugin, i got Windows Srcript Host errors all the time. simetimes 1:1, by default it gives error to dev, vendor, it expects :
Steps to Reproduce (for bugs)

generate extension via generator
create webextension-toolbox.js
yarn add jquery
add code:

module.exports = {
  webpack: (config, { dev, vendor }) => {
    // Perform customizations to webpack config
	config.plugins.push(
	  new webpack.ProvidePlugin({
		  $: 'jquery',
		  jQuery: 'jquery'
	  })
	)
    // Important: return the modified config
    return config
  }
}

Tried different ways for module export, no luck.
Context

Parts of my extension containes jquery, that's why i need it.
Your Environment

Tech
Version

webextension-toolbox
1.0.4

node
10.1.0

OS
W10

browser

etc

@HaNdTriX I posted a similar issue on the generator repo. Not sure what's wrong. I am also on Windows. will try the same later, on a mac

I also stumbled upon this problem but I quickly found out through a google search that this is a problem of Windows if no default program for .js files is set. Set it to your IDE or text editor and it should not throw this error anymore.
Only slight problem: Even though it will not throw an error, if a webextension-toolbox.js file is present in the root folder, the building will exit without starting webpack; generating no files. I'll open a seperate issue for this.

It's working now. All i got after that, was a ReferenceError: webpack is not defined, but it can be easily solved. Made a pull request (#33), so in the future developers don't have to worry about that either.
Next, i'll look into webpack-webextension-plugin. For me, seems like after the first reload it is losing connection (Inspecting background page, only the generated background page is available after reloading the first time.) (Win10, Chrome 67.0.3396.56).
You guys (@bboydflo @Linard11) only had problem with extending webpack config, and everything else is working fine?

It does work on a mac, the issue appears only on windows for me.

@JimMorrison723 @bboydflo requiring weback did not work for me. Still the same problem (see #32)

Hey @JimMorrison723,
Could you please try with cloning/pulling changes from this repo and npm link to your project?
Thank you in advance!

https://github.com/webextension-tools/webextension-toolbox/pull/37 should fix this issue

I've tried and as @Linard11 mentioned, #37 fixed this issue.
Note: I had to install locally or link webpack to make this work. I got Cannot find module 'webpack' error without doing this.

Looks like issues solved.


Transform pointer events

This was deliberately left out of the 0.5.0 release but it's quickly becoming difficult to get non-trivial transform-based UIs working without it.
For now, using this issue as a quick place to take notes pending implementation. Things that probably need to be done:

Transform points during DispatchPointerEvent. Since these points propagate down the hierarchy, I think we can ignore the whole matrix transform system and just apply the local transform to each point, since each view knows its own transform and each coordinate is given to that view in its own local space.
Transform points during focus searches. Same rule as above should work.
Find some way to notify the ViewMenu to refocus during/after transitions, or maybe have some system to bypass the previous rule... it's complicated, need a way to land the gamepad cursor in the right place when scrolling entire pages left or right, without making this look extremely weird to the user, e.g. by having the cursor jumping around each frame.
Don't dispatch pointer events outside the clip region. If it's not drawable, then it doesn't really make sense to be interactable.
Similarly, ignore (early-terminate) focus searches outside the clip region.
Transform points along the hover/tooltip path as well, which seems to be follow different logic and does not even honor pointer-events-enabled right now.

This is pretty much the bare minimum to avoid unwanted interactions with transformed content. There may be more rules or steps to add later.

Not precisely pointer-event related but another useful performance tweak would be to avoid drawing anything that's known to be entirely outside the clip region.
However, this may be somewhat trickier than it sounds, since views don't have a "recursive actual bounds" that accommodates for negative margins in lower-level descendants. So it is possible that even if a view's entire layout appears to be out of bounds, it is going to draw something that is technically in bounds. Though there is HasOutOfBoundsContent logic somewhere that might be reusable for this.


Fixed parallel build to generate necessary files

Fixed go generate which didn't work after parallel build changes

Please, commit


Improve linter

Description
this to resolve #160 issue
clean all unused code with ts-prune
and remove unused export.
add ci in lint check for circular dependencies
add for linter not allowed unused code like
"@typescript-eslint/no-unused-vars": "error",
that was mostly react import so I also add this
"react/react-in-jsx-scope": "off",

after falling
yarn build
since there is unused import in node modules I put it back to normal
for passing the test.


Add the ability to import a keypair

After running go-wallet genkey -n abc -p 123, the public and private keys are shown:
new generated keys:
public: [64 hex chars]
private: [128 hex chars]

Add a new command, something like:
go-wallet import -n abc -p 123 --public "[64 hex chars]" --private "[128 hex chars]"

This is so that it is simple to transfer/import keypairs without dealing with raw wallet files.

We are currently implementing support for HD wallets. The import from mnemonics will be built-in. However, this will not be implemented on the first-generation key format, as it will be deprecated on the release of HD wallets and remove not long after.
HD Wallet PR: #112


Unreachable case warning (E121) in inline generic function

steps

Create a project as shown in the minimal reproducible example
Compile and run

sbt version: 1.9.8
Minimal reproducible example
poc.scala
sealed abstract class Parent // The warning goes away if `sealed` is removed

class A extends Parent
class B extends Parent

inline def matchAs[T <: Parent](p: Parent): Unit = p match // The type bound is necessary
    case p: T =>
    case _ => println("unreachable case reached") // Warning here: "Unreachable case except for null [...]"
end matchAs

@main def main: Unit =
    matchAs[A](new B)
end main

build.sbt
scalaVersion := "3.4.0"

problem

The following warning is issued
[warn] -- [E121] Pattern Match Warning: [...]/inline_poc/src/main/scala/poc.scala:9:9
[warn] 9 |    case _ => println("unreachable case reached")
[warn]   |         ^
[warn]   |Unreachable case except for null (if this is intentional, consider writing case null => instead).
[warn] one warning found

However, running the example gives the following output:
unreachable case reached

Indicating that the second case was in fact reached.
expectation

No warning should be issued.
notes
The following conditions are required to trigger the warning

Parent must be sealed
T must be upper bounded

The warning stays even when p is declared inline.

This sounds like an issue with the compiler, not sbt. Please report this to scala/scala3 instead.

Done, thank you.
https://github.com/scala/scala3/issues/20225


[debugging and profiling] tideways.io

Tideways.io is a monitoring and profiling tool for PHP applications, quite similar to blackfire.io

Do you mind rebasing this onto master?

@josegonzalez done ;-)


Fix french translation on connect wallet screen

Some i18n texts are not correct in french, see screenshots attached.

The not-yet translated entries are expected, have a look at the PR for initial translations: https://github.com/shapeshift/web/pull/924 - it's not exhaustive and more translations are yet to be added!
As for the missing keys, these were added in a later PR. Quoting my earlier discussion with @LPX55:
at the moment we're working with engineering to find a solution for a more streamlined and reasonable workflow!

I think it would be a great value to have some json diff that adds the missing entries as "TODO" in the meantime.

@gomesalexandre ok thank you :) closing this issue !


setup.py tries to read version.py as ascii, contains Unicode

There's a UTF-8 encoded copyright symbol in pytest_logging/version.py.
setup.py tries to read the file like:
with open(os.path.join(SETUP_DIRNAME, 'pytest_logging', 'version.py')) as rfh:

This fails if the OS locale is C or some other non-UTF-8 locale:
# python3.5 setup.py
Traceback (most recent call last):
  File "setup.py", line 34, in <module>
    exec(rfh.read(), None, _LOCALS)  # pylint: disable=exec-used
  File "/usr/lib64/python3.5/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 105: ordinal not in range(128)

I encountered this in a CentOS 7 Docker image.

Please see https://github.com/saltstack/pytest-logging/issues/3#issuecomment-254253564


test(5)

First of all, when reporting a bug, give the issue a descriptive title.
In the body of the issue, optionally give a free-form text description of the
bug. Give the context necessary for others to understand the problem.
Then, provide information necessary to reproduce the bug.
Omit sections that are irrelevant for the bug report, but note that information
like git revision, build platform, build command, and test case are required in
almost all cases.
JerryScript revision
Identify the git hash(es) or tag(s) where the issue was observed.
Build platform
Name the build platform. E.g., copy the output of
echo "$(lsb_release -ds) ($(uname -mrs))" (on Linux),
echo "$(sw_vers -productName) $(sw_vers -productVersion) ($(uname -mrs))" (on macOS), or
python -c "import platform; print(platform.platform())" (should work everywhere).
Build steps
Describe how to build JerryScript. Give all the necessary details of the build
(e.g., environment variables, command(s), profile, command line options, etc.).
E.g.:
tools/build.py --clean --debug

Or:
mkdir build && cmake -H. -Bbuild && make -C build

Even if the bug was originally observed when JerryScript was integrated into a
larger project, try to reproduce it with as few external code as possible,
preferably by building the jerry command line tool.
Build log
Copy the build log if the reported issue is a build problem. Do a verbose build
if necessary. Try and trim the log to relevant parts.
Test case
Give the JavaScript input that should be passed to the engine to trigger the
bug. Try and post a reduced test case that is minimally necessary to reproduce
the issue. As a rule of thumb, use Markdown's fenced code block syntax for the
test case. Attach the file (renamed to .txt) if the test case contains
'problematic' bytes that cannot be copied in the bug report directly.
Execution platform
Unnecessary if the same as the build platform.
Execution steps
List the steps that trigger the bug.
E.g., if a bug is snapshot-specific:
build/bin/jerry-snapshot generate -o testcase.js.snapshot testcase.js
build/bin/jerry --exec-snapshot testcase.js.snapshot

Unnecessary if trivial (i.e., build/bin/jerry testcase.js).
Output
Copy relevant output from the standard output and/or error channels.
Backtrace
In case of a crash (assertion failure, etc.), try to copy the backtrace from a
debugger at the point of failure.
Expected behavior
Describe what should happen instead of current behavior. Unnecessary if trivial
(e.g., in case of a crash, the trivial expected behavior is not to crash).

First of all, when reporting a bug, give the issue a descriptive title.
In the body of the issue, optionally give a free-form text description of the
bug. Give the context necessary for others to understand the problem.
Then, provide information necessary to reproduce the bug.
Omit sections that are irrelevant for the bug report, but note that information
like git revision, build platform, build command, and test case are required in
almost all cases.
JerryScript revision
Identify the git hash(es) or tag(s) where the issue was observed.
Build platform
Name the build platform. E.g., copy the output of
echo "$(lsb_release -ds) ($(uname -mrs))" (on Linux),
echo "$(sw_vers -productName) $(sw_vers -productVersion) ($(uname -mrs))" (on macOS), or
python -c "import platform; print(platform.platform())" (should work everywhere).
Build steps
Describe how to build JerryScript. Give all the necessary details of the build
(e.g., environment variables, command(s), profile, command line options, etc.).
E.g.:
tools/build.py --clean --debug

Or:
mkdir build && cmake -H. -Bbuild && make -C build

Even if the bug was originally observed when JerryScript was integrated into a
larger project, try to reproduce it with as few external code as possible,
preferably by building the jerry command line tool.
Build log
Copy the build log if the reported issue is a build problem. Do a verbose build
if necessary. Try and trim the log to relevant parts.
Test case
Give the JavaScript input that should be passed to the engine to trigger the
bug. Try and post a reduced test case that is minimally necessary to reproduce
the issue. As a rule of thumb, use Markdown's fenced code block syntax for the
test case. Attach the file (renamed to .txt) if the test case contains
'problematic' bytes that cannot be copied in the bug report directly.
Execution platform
Unnecessary if the same as the build platform.
Execution steps
List the steps that trigger the bug.
E.g., if a bug is snapshot-specific:
build/bin/jerry-snapshot generate -o testcase.js.snapshot testcase.js
build/bin/jerry --exec-snapshot testcase.js.snapshot

Unnecessary if trivial (i.e., build/bin/jerry testcase.js).
Output
Copy relevant output from the standard output and/or error channels.
Backtrace
In case of a crash (assertion failure, etc.), try to copy the backtrace from a
debugger at the point of failure.
Expected behavior
Describe what should happen instead of current behavior. Unnecessary if trivial
(e.g., in case of a crash, the trivial expected behavior is not to crash).

First of all, when reporting a bug, give the issue a descriptive title.
In the body of the issue, optionally give a free-form text description of the
bug. Give the context necessary for others to understand the problem.
Then, provide information necessary to reproduce the bug.
Omit sections that are irrelevant for the bug report, but note that information
like git revision, build platform, build command, and test case are required in
almost all cases.
JerryScript revision
Identify the git hash(es) or tag(s) where the issue was observed.
Build platform
Name the build platform. E.g., copy the output of
echo "$(lsb_release -ds) ($(uname -mrs))" (on Linux),
echo "$(sw_vers -productName) $(sw_vers -productVersion) ($(uname -mrs))" (on macOS), or
python -c "import platform; print(platform.platform())" (should work everywhere).
Build steps
Describe how to build JerryScript. Give all the necessary details of the build
(e.g., environment variables, command(s), profile, command line options, etc.).
E.g.:
tools/build.py --clean --debug

Or:
mkdir build && cmake -H. -Bbuild && make -C build

Even if the bug was originally observed when JerryScript was integrated into a
larger project, try to reproduce it with as few external code as possible,
preferably by building the jerry command line tool.
Build log
Copy the build log if the reported issue is a build problem. Do a verbose build
if necessary. Try and trim the log to relevant parts.
Test case
Give the JavaScript input that should be passed to the engine to trigger the
bug. Try and post a reduced test case that is minimally necessary to reproduce
the issue. As a rule of thumb, use Markdown's fenced code block syntax for the
test case. Attach the file (renamed to .txt) if the test case contains
'problematic' bytes that cannot be copied in the bug report directly.
Execution platform
Unnecessary if the same as the build platform.
Execution steps
List the steps that trigger the bug.
E.g., if a bug is snapshot-specific:
build/bin/jerry-snapshot generate -o testcase.js.snapshot testcase.js
build/bin/jerry --exec-snapshot testcase.js.snapshot

Unnecessary if trivial (i.e., build/bin/jerry testcase.js).
Output
Copy relevant output from the standard output and/or error channels.
Backtrace
In case of a crash (assertion failure, etc.), try to copy the backtrace from a
debugger at the point of failure.
Expected behavior
Describe what should happen instead of current behavior. Unnecessary if trivial
(e.g., in case of a crash, the trivial expected behavior is not to crash).

Garbage issue report. Looks like automated actors use GitHub and the JerryScript project as their test bed.
Newly created user @gaetan6777x seems to be co-working with already blocked user @Solo67500 (or the user was created to work around the block). See https://github.com/gaetan6777x/jerryscript/pull/1
I'm blocking @gaetan6777x . Maintainers are asked for a retroactive second. User is suggested to reach out to maintainers if s/he want to justify their actions.

Garbage issue report. Looks like automated actors use GitHub and the JerryScript project as their test bed.
Newly created user @gaetan6777x seems to be co-working with already blocked user @Solo67500 (or the user was created to work around the block). See https://github.com/gaetan6777x/jerryscript/pull/1
I'm blocking @gaetan6777x . Maintainers are asked for a retroactive second. User is suggested to reach out to maintainers if s/he want to justify their actions.

I second!

I second!


Tracking issue for improving test coverage of the action

Currently, we only test a single small cago-kani example.  Possible improvements

[ ] Example that needs workspace
[ ] Example that needs --tests
[ ] example that has dependencies
[ ] example where the rust version matters
[ ] examples with different kani versions

I would also add

[ ] expected fail tests


Extending to nvim-dap?

Sorry for this probably stupid question, but in neovim there is the possibility to use nvim-dap for languages for which the debug adapter protocol was implemented. Is it possible to use the VSCode-R-Debugger also in this scenario (with some modifications)?

 I had the same idea some time last year and actually spent some time working on a solution in https://github.com/ManuelHentschel/dapWrapper (the dap-server seemed to work with different clients, but was quite buggy). The main problem with the vscDebugger package is that there seems to be no way to control the program flow (stepping through code while debugging) from within R itself. Therefore, I am using a node-based wrapper, which controls the input to/output from an R process underneath.
Also, I am currently playing around a bit with Rcpp and boost.asio and hope that I'll be able to implement a dap-server that is able to run in the background of a user-managed R session, which might make it easier to attach to an already running R session, using different dap-clients.

Thank you for your efforts! I would love to contribute but I don't think I have any relevant expertise...
Why is it not possible to control the program flow from within R itself?
If you want tto step through the current problem from within a running R session couldn't you simply save the current R source-code file as a .txt file, e.g. as "~/R_temp.txt", and then do the following:
src = readLines("~/R_temp.txt")
src = paste0(src, collapse = "\n")
src = parse(text = src)

# step through the code:
eval(src[1])
eval(src[2])

Again, I really appreciate your work :)

Stepping into functions might be trickier, but I guess it might be doable as well.

If you want tto step through the current problem from within a running R session couldn't you simply save the current R source-code file as a .txt file, e.g. as "~/R_temp.txt", and then do the following: [...]

That's roughly how source and .vsc.debugSource work.

Stepping into functions might be trickier, but I guess it might be doable as well.

This is definitely the tricky part, if you figure out a way to do this, without needing to write to stdin, please let me know!

I might give it a go in the christmas holidays. Are there any insights that you have gained so far?

Especially, have you tried to manually execute the function calls?
Something along the lines of:
# standard function call
f = function(x) {
  print(x)
  return(x)
}
f(1)
#> [1] 1
#> [1] 1

## manually constructing a function call
func_env = new.env()
delayedAssign("x", 1, eval.env = func_env)
eval(expression(print(x)), envir = func_env)
#> [1] 1
eval(expression(return(x)), envir = func_env)
#> [1] 1

Created on 2021-12-10 by the reprex package (v2.0.1)

I mean probably you have, but what were the problems that you ran into?

Ok so this was probably a quite naive suggestion, with all the call stack stuff this would probably have to be done in C?
Did you also try to implement it there or only in R?

I agree that the straightforward approach you mentioned would be problematic, since it would mess up the call stack and you would have to use a modified version of eval recursively, since otherwise you would not be able to handle breakpoints in nested function calls.
Also, I would like to be able to handle browser() statements in functions that were called directly by the user and the way that the browser seems to be implemented is quite reliant on the input from stdin. I had a look at the R source code at some point and had the impression that it checks for the inputs n, c, etc. before even parsing the entire line, which would be hard to imitate from inside an R function.
Though until now I have not used C for anything but some simple helper functions, so maybe there is some potential for improvements there!

I think it should be relatively easier in radian to control the flow because we have python entry point. We could basically open a socket connection for other program to send R code in. Let me know what do you need in order to make it work.

Thanks for the suggestion! Currently, the entire back and forth between the R package and the node wrapper is a bit convoluted, but in general, the following things I wasn't able to manage using just R:

Give control back to the vscDebugger package whenever R hits a browser statement, error etc.. In principle this could be done using addTaskCallback and error handling, but that these seem to behave a bit weirdly when using browser()
Write flow control commands (c, n, ....) to stdin.
Manage direct user input to stdin, e.g. when using readLines()

Do you think these are straightforward to implement in radian?

Perhaps let me explain how radian works. First, I assume that you understand how a REPL works
R: read from user input
E: evaluate the input
P: print the output
L: loop
When R needs to read user input, it will call radian's callback read_console . There are a few things that we could do with this function.

before the function returns, we could run any arbitrary python or R code. (related to your 1 point)
If this function returns any text, R eventloop will evaluate the text. (related to your 2 and 3 point)

radian built in tcp server
The following is what I think should be doable. When radian starts, it opens a tcp server with a given port (something like radian --tcp 8123). Other programs could connect to this port to communicate with radian (maybe using some kind of jsonrpc). A client could send requests to radian via the tcp connection, for example,

{"jsonrpc": "2.0", "method": "user_input", "params": "cat('hi')", "id": 1}
cat('hi') will pass to R repl and the result will be printed in stdout

{"jsonrpc": "2.0", "method": "evaluate", "params": "1 + 3", "id": 1}
The expression will be evaluated, and the reply message will be sent back to the client with the result.

{"jsonrpc": "2.0", "method": status",  "id": 1}
Status such as whether R is in debug prompt or regular prompt will be replied.

Something like this could add a lot of possibility to radian, including attaching a debugger to it.

I think it is very similar to what you have done in vscDebugger. However, you did it in R which also means that the tcp server is blocking the R loop.

Well, it seems that I might have misunderstood how DAP works. How do you handle the browse prompt in attach mode in the current implementation?

I have pushed a branch to radian. It allows you to define custom read console callback. I think it should fit your use case.
pip install git+https://github.com/randy3k/radian.git@callback

Simple use case. When read_console returns, the result is sent to R REPL for evaluation.
read_console <- function(message, add_history) {
    .radian.unregister_read_console()  # unregister it to avoid infinite loop
    return("1 + 3")
}

.radian.register_read_console(read_console)

For your user case. It will be more like this.
In user radian, we open a tcp server, and register a custom read console handler.
conn <- socketConnection(port = 8888, server = TRUE, blocking = TRUE)

read_console <- function(message, add_history) {
    while(TRUE) {
        line <- paste0(readLines(conn, n = 1), collapse = "\n")
        res <- jsonlite::fromJSON(line)
        if (res$method == "user_input") {
            return(res$data)
        } else if (res$method == "eval") {
            eval(parse(text = res$data), envir = .GlobalEnv)
            .radian.flush_console()
        }
    }
}

.radian.register_read_console(read_console)

Then in VSCode, you could make a tcp connection to interact with radian (I am using R to simulate the communication)
conn <- socketConnection(port = 8888)
writeLines(jsonlite::toJSON(list(method = "eval", data = "cat('hi\n')"), auto_unbox = TRUE), conn)
writeLines(jsonlite::toJSON(list(method = "user_input", data = "1 + 3"), auto_unbox = TRUE), conn)

Perhaps we should create a new package says for example dap under REditorSupport and starting working a fresh implementation of dap there. It is in my opinion easier then modifying the current vscDebugger.

I think it is possible to replicate this mechanism in C in macOS and Linux. However, it is not the case on Windows.

Thanks for all the suggestions and the radian branch! I'll try to have a look at that branch later today.

Well, it seems that I might have misunderstood how DAP works. How do you handle the browse prompt in attach mode in the current implementation?

There are two cases where the attach mode can be used here:

Calling .vsc.listen() in a normal R terminal. This will block the R input while a dap client is attached, but show the entire callstack etc.
Calling .vsc.startWebsocket() to have the dap server run in the background (note that this funcion is misnamed as it does not actually start a websocket). This will not block R but will only have access to the global environment. I have been working on a rewrite of this feature on the branch tcl, but haven't had much time for this recently.

What is the status here?
If there is anything simple that I can contribute (I don't have experience with these kinds of things) let me know :)

Maybe we can ask some R-core people / people who know the R source code well to implement the required functionality in C?

I haven't had a chance to work on this in the last weeks, I'll try to get to it by the end of January!

Hey :) What is the status here?

Hey, sorry for the inactivity here. In principle, the branch https://github.com/ManuelHentschel/vscDebugger/pull/176 might already work to a limited extent with different clients (setting breakpoints, variable view, and watches etc. might work, flow control definitely not).
I haven't been using R a lot recently, so I neglected this repo a bit. Next time I have to do a project in R I'll hopefully also work on this package more frequently. If you want to do anything yourself and have any questions in the meantime I'm happy to help, though :)

Someone started with a new implementation here https://github.com/dgkf/debugadapter/. But it has a lot of complexity that arise from circumventing the issues you also described here (see the issues in the repo). I would also be interested in contributing to the project if someone else with more experience can help in the design etc. , maybe we can structure it in such a way that it is either possible to use through radian and without radian. If we pool resources I am sure we can get something great going!

I guess if you are interested we could set up a discord or something for discussions. Or if there is already something like that for REditortSupport maybe we can discuss it there @randy3k ?

It would be great if we found a clean way to solve the control-flow problems mentioned here and in https://github.com/dgkf/debugadapter/issues/4! Considering the difficulty of this task, I'm not sure how much time I'll be able to commit, but I'm always happy to talk if there is something to discuss.

Any news on this?
Should we write to R-devel to propose the hook that we need?
I also use R within neovim, but debugging is a feature I lack

Using https://github.com/posit-dev/ark might be a solution for this. For now they only support the positron front-end, but are planning to support others in the future.

some relevant discussion: https://floss.social/@lionel/112694030162713183
the browser hook that was added as part of the ark development might path the way for: https://github.com/dgkf/debugadapter to be useable


Feature/person singular

Display 'is' or 'are' depending on number of GPs

:rocket: deployed to http://profiles-pr-86.dev.c2s.nhschoices.net

:rocket: deployed to http://profiles-pr-86.dev.c2s.nhschoices.net

:rocket: deployed to http://profiles-pr-86.dev.c2s.nhschoices.net

LOTM!


Thumbnail

Rewrite thumbnail to handle upscaling, fixes #767
Upscaling images results in cases where there are pixels in the output to which no integer valued indices in the original image correspond. The current approach works around this by always always consuming at least one pixel but this result in a panic and would yield inaccurate result anyways.
The new algorithm instead special cases for these cases by instead weighting the two surrounding pixels and never forcing the window to shift.
Open questions are:

What is the performance of the new algorithm?
Should the old behaviour be fully preserved for cases where we downscale in both directions, i.e. where the old window determination would not panic in the first place? If the performance has gotten worse, a single branch at the start of the method instead of branches within the loop might yield better results. The newer algorithm has different cache behaviour and uses more floating point arithmetic.

Travis is sometimes failing due to network errors. That is rather annoying

Okay, I'll provide documentation and maybe some benchmarking then merge this.

Thanks!


What is the logits and how to get them from kenLM

I think the logits matrix comes from your upstream model. It can not be got from kenlm.


Editting backup README

Generated summary (powered by Graphite)

What Changed
Deleted

No newline
Added
modification

Testing
Open the README file and verify that the modification is present.
Reasoning
Add a modification to the backup README file to test version control functionality.

Current dependencies on/for this PR:

master

PR #11   👈

PR #12

This comment was auto-generated by Graphite.

@riemanli queued this pull request to merge with Graphite.


Allow players to sit on slabs and add a /sit command

Is your feature request related to a problem? Please describe.
At the moment players can only sit on chairs
Describe the solution you'd like
It would be very useful if players were able to right click on slabs to sit on them and also adding a /sit command that lets players sit anywhere.
Additional context
None

You can actially enable slabs in the config.yml. It is under Chairs >> UseSlabs.
Additionally, you can configure Filter >>Blocks instead and list all blocks that should be seen as potential chairs.
I'll see what I can do about the /sit command as the plugin currently requires a block as a chair but it should be possible.

You can actially enable slabs in the config.yml. It is under Chairs >> UseSlabs.
Additionally, you can configure Filter >>Blocks instead and list all blocks that should be seen as potential chairs.
I'll see what I can do about the /sit command as the plugin currently requires a block as a chair but it should be possible.

Ah sorry! I did not realise there was a config option for slabs I'll edit the title and description of this issue

The command has been added in the most recent release ^^
The release is marked as ALPHA, so please don't hesitate to report any bugs ^^


[BugFix][CoreML Converter] Dense layers w/o bias.

Description
The code was initially assuming bias to be true for dense layer. This change fixes that by relying on no_bias parameter.
 I finished coding on this PR)
[Y] All changes have test coverage
[N/A] For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented.
[Y] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments
This is related to issue: https://github.com/apache/incubator-mxnet/issues/8628
Note that lint score is low currently for this tool. Will open another pr which should improve the score.

@jiajiechen @srikris

This looks good to me.
nitpick: I will suggest
has_bias = not param.pop('no_bias', False)

Discussed with @jiajiechen: it would be great to not update the existing mxnet symbol. We might end up using it again later on after conversion (in the future).

Could you update?

Updated.


2.2 - ifelse and casewhen

@monacoba - Ready for primetime: https://tidy-mn.github.io/R-camp-slides/day2/02-2-Forks-in-the-road.html#1
If you can manage to play this lightning sound on another screen when you push the big play button that'd be fun: https://www.youtube.com/watch?v=0zLIPEjoRyg
Here's some ideas for the live demo portion: https://tidy-mn.github.io/R-camp-penguins/page/day2.html#forks-in-the-road-if_else-and-case_when

Video done! There's a moment where the trim function in stream did me dirty
but otherwise I'm pretty happy with it
On Wed, Nov 22, 2023 at 4:01 AM air @.***> wrote:

@monacoba https://github.com/monacoba - Ready for primetime:
https://tidy-mn.github.io/R-camp-slides/day2/02-2-Forks-in-the-road.html#1
If you can manage to play this lightning sound on another screen when you
push the big play button that'd be fun:
https://www.youtube.com/watch?v=0zLIPEjoRyg
Here's some ideas for the live demo portion:
https://tidy-mn.github.io/R-camp-penguins/page/day2.html#forks-in-the-road-if_else-and-case_when
—
Reply to this email directly, view it on GitHub
https://github.com/tidy-MN/R-camp-penguins/issues/6, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB4ESRDVYACEXXRG23VR7I3YFXEQZAVCNFSM6AAAAAA7V6LEASVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYDKOJXHE3TGMA
.
You are receiving this because you were mentioned.Message ID:
@.***>

:clap:  :clap: :monkey:


LP#2045009 Kubernetes apiserver certificate expiration is not monitored in 1.29 charms

Summary
Add an alert rule for certificate expiration

Where do probe_ssl_earliest_cert_expiry metrics come from? Does Charmed K8s generate it out of the box?

I have checked with the latest kubernetes-control-plane charm (rev344) which does have this fix, and deployed blackbox-exporter-k8s charm on microk8s where COS is deployed.
I can now confirm that the new Alert, SSLCertificateExpiringSoon, is added in Prometheus.
However, it seems that the expression in the alert doesn't match to any.
In my test environment, the SSLCertificateExpiringSoon alert looks for the following expression:
probe_ssl_earliest_cert_expiry{juju_application="kubernetes-control-plane",juju_model="k8s",juju_model_uuid="fabfac13-87dc-44c8-88ed-14d90d72e9f5"} - time() < 86400 * 15
However, the probe_ssl_earliest_cert_expiry metrics are showing the following results.
probe_ssl_earliest_cert_expiry{instance="cos_91ea836d-2760-444d-88fa-3db484fa6b6c_blackbox-exporter", job="juju_cos_91ea836d_blackbox-exporter_prometheus_scrape_blackbox_k8s_endpoints", juju_application="blackbox-exporter", juju_charm="blackbox-exporter-k8s", juju_model="cos", juju_model_uuid="91ea836d-2760-444d-88fa-3db484fa6b6c", probe_target="https://<IP_ADDRESS>:6443"}
It looks like it will only work when deploying blackbox-exporter-k8s on the same model where kubernetes is deployed.
However, as the blackbox-exporter charm is only for k8s, it can't be deployed on the same model as kubernetes.