Missing Listener

maybe it will be nice if we can listen to signal from the build method without rebuild widget for showing snackbar or anything else

This can be done in initState with subscribe or an effect

This can be done in initState with subscribe or an effect

However, you cannot use initState if you use a Builder widget or something similar. In those cases, I use useEffect from Flutter Hooks to call subscribe or effect. However, I would love it if there was a handier way to do it.

Do you mean use a widget that needs the build context? For that you can add a post frame callback

so i juse use useEffecte with addPostFrame callback to get initState behaviour

as example bloc have a listener
BlocListener<BlocA, BlocAState>(
  listener: (context, state) {
    // do stuff here based on BlocA's state
  },
  child: Container(),
)

also here riverpod it is more elegant
Widget build(BuildContext context, WidgetRef ref) {
 ref.listen(otherProvider, (previous, next) {
    print('Changed from: $previous, next: $next');
  });

  ...
  }

Added listen on 1.5.4!
Example:

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  final Signal<int> counter = signal(0, debugLabel: 'Counter');

  void _incrementCounter() {
    counter.value++;
  }

  @override
  Widget build(BuildContext context) {
    counter.listen(context, () {
      if (counter.value == 10) {
        final messenger = ScaffoldMessenger.of(context);
        messenger.hideCurrentSnackBar();
        messenger.showSnackBar(
          const SnackBar(content: Text('You hit 10 clicks!')),
        );
      }
    });
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
        actions: [
          Builder(builder: (context) {
            final dark = isDark.watch(context);
            return IconButton(
              onPressed: () {
                brightness.value = dark ? Brightness.light : Brightness.dark;
              },
              icon: Icon(dark ? Icons.light_mode : Icons.dark_mode),
            );
          }),
        ],
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Watch((context) {
              return Text(
                '$counter',
                style: Theme.of(context).textTheme.headlineMedium!,
              );
            }),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: const Icon(Icons.add),
      ),
    );
  }
}

Nice, this is really convenient! 👍🏻


Use unique_name as OIDC claim

unique_name is a required claim, while upn is not [1].
In AD, the upn claim only exists for regular organizational accounts, not for guest users in the tenant [2].
[1] https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-oidce/55c0a84d-48e7-4043-91f8-9ebd0a51ab68
[2] https://stackoverflow.com/a/51979475/1069467

using unique_name will have an impact on the user_map_match, can you please update this as well, or even better, document both options.

In our case, unique_name also just contains the email address.
Is this different in your case?

I don't know, but when looking at the stackoverflow the value will be something like that<EMAIL_ADDRESS>if so the user_map_match regex would have to be changed


github: add bug report template

I want report a bug to bot, but it seems we don't have a bug report template.
So I add a template to report bug.

@you06 @AndreMouche  PTAL~ Thanks!

Thanks!


[BUG] playground does not work as it uses the wrong url

{
  "errors": [
    {
      "message": "Unexpected non-whitespace character after JSON at position 4 (line 1 column 5)",
      "stack": "SyntaxError: Unexpected non-whitespace character after JSON at position 4 (line 1 column 5)"
    }
  ]
}

This is what's reported, but it's just using the wrong hardcoded URL of /graphql instead of the defined --external-url.

this has been fixed on main already, infra has been adjusted. Will be shipped with next release. 👍


Remove reporting and locking

Motivation and Context
A bug occurs when producing notification files when the Redis instance
count gets out of sync because of the @PreDestroy isn't guaranteed to
run. This causes the ExportScheduler to lock up when it's waiting for
the countdown latch.
This change simplifies the notification file generation logic by
removing the reporting and locking. As a part of this change, a lot of
unit tests have been backfilled.
What has changed
Removing reporting
Simplifying locking
Backfilling tests
How to test?
Functionality hasn't changed other than removing the reporting so just running the tests and regression checking using the acceptance tests is good enough
Links
N/A bug fix

The DistributedLatchManager bean in ActionExporterApplication is no longer used and it can be executed at dawn with extreme prejudice.

I'm also gettting TemplateServiceIT.testTemplateGeneratesCorrectPrintFileForSocialPreNotification:151 expected:<[SOCIALPRENOT]> but was:<[BSREM]>

@NickGrantONS I got that once but I haven't seen it happen again 😕


add search scope

To allow customers to have a filtered search just on OData docs

Docs Build status updates of commit a35b55e:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

Line 220: [Error] Invalid syntax in W:\zjnp-s\Odata-docs\docfx.json. Please validate your syntax with a JSON validator like http://jsonlint.com/ and update the JSON file in the repo with correct syntax.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 4b233ae:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/odatalib/v7/fluent-writer-api.md
:warning:Warning
View
Details

Odata-docs/docfx.json
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/fluent-writer-api.md

Line 22: [Warning] Link 'https://msdn.microsoft.com/en-us/library/system.action(v=vs.110).aspx' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Warning is unrelated to my PR but opened #96 to handle the other article

Docs Build status updates of commit 7bfea62:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@xuzhg @mumbi-o who reviews PRs here?


Can't create Threads in News (Announcement) channels.

Hi there!
I've got this error message when I try to create a thread in a News Channel:
System.NullReferenceException: Object reference not set to an instance of an object.

My method:
(Context.Channel as SocketNewsChannel).CreateThreadAsync("test");

What is the problem in this? Can you fix it please?
Thanks,
Aki26 GamePlay#3982

Is there a stack trace with the exception?

Is there a stack trace with the exception?

Sorry but I don't know exactly what is stack trace. Maybe this?:
System.NullReferenceException: Object reference not set to an instance of an object.
   at Submission#0.<<Initialize>>d__0.MoveNext()

The reason for the excpetion is that Context.Channel is not a SocketNewsChannel, therfor casting it yields null.

But with ITextChannel I get the same error message.

So my question: How can I create threads in a News/Announcement channel?

Discord doesn't seem to allow bots to create threads in news

Disregard, as pointed out by @NovaFox161 you need to specify ThreadType.NewsThread when creating your thread. An example would be:
var chan = client.GetGuild(guildId).GetTextChannel(newsChannelId);
await chan.CreateThreadAsync("test", ThreadType.NewsThread);

Thanks. But why this is not automatic?


Add ignore_unknown_values option

Hi,
I've added ignore_unknown_values option for setting this flag:
https://developers.google.com/resources/api-libraries/documentation/bigquery/v2/java/latest/?_ga=1.240614272.2056527373.1423532066

Thank you for your pull request! And I released v0.1.5

Thank you for merging :+1:


[Identity] Minor cleanup of docs/tests

Some minor doc fixes were added, and some unused test files were removed. The conftest.py file was also move inside the tests directory to keep its location consistent with other services.

API change check
API changes are not detected in this pull request.


Impelement query for family/not in family

We should be able to query NetStatus for both a router in the same family and a router not in my own family

Fixed in 636ed7e425


Certain button cards are not working  i.e no buttons displayed

Details
Certain button cards are not working  i.e no buttons displayed. These are  disturbing the uniformity of the website.Therfore I would like to remove them.
Kindly assign me this issue under gssoc'23.
Screenshots

Type of Contribution

[ ] Update to an existing Animated Button
[ ] Adding a new Button
[X] Resolving a bug
[ ] Proposal to the Repository
[ ] Changes related to documentation or README.md
[ ] Other Changes

Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue
[X] I am a GSSoC'23 contributor

@shruuti321 Removing them is not an option.
The code of this button is present. Can you fix those?

In the buttons folder there is no file named samriddhi15 but it is added in the data.js that is why it is showing empty on the website. They have been added in the form of samriddhi15_1.So the simple fix is to remove samridhhi15 from data.js and similarly for some other user names.
So I would like to try this issue and fix it.

Please check #1346

Sorry for the inconvinience, but we are closing all the issues! Please open a new issue if you want to contribute anything. Also now you can create a new button from the website itself! You will get points for those too! I will add the instructions on how to create a new button soon and create an empty pr for the same to get points!


System rules [Feature request]

TestNG Version

Note: only the latest version is supported
6.9.11

It would be nice if TestNG could support something like System Rules in JUnit.
http://stefanbirkner.github.io/system-rules/

System rules should support TestNG instead: https://github.com/stefanbirkner/system-rules/issues/41
And a solution is using listeners: http://testng.org/doc/documentation-main.html#testng-listeners

Relevant StackOverFlow thread with options : https://stackoverflow.com/questions/6099633/does-testng-support-something-like-junit4s-rule
A sample implementation https://github.com/wolfs/testng-rules


No exit code when failure

When e.g. using office365 spo app add -p solution/myapp.sppkg --overwrite and the file does not exist the returned exit code is 0 (success). This should be 1 or preferably 2

This should be fixed in the latest beta (https://github.com/SharePoint/office365-cli/issues/468). Which version of the Office 365 CLI are you using?

Using the latest beta npm i -g @pnp/office365-cli@next the issue is fixed!
office365 spo app add -p "idontexist.sppkg" --overwrite
File 'C:\Users\r.breman\idontexist.sppkg' not found
echo Exit Code is %errorlevel%
Exit Code is 1

It also reflects nicely in my build pipeline

Cool! Thank you for confirming! 💪


The RimbeUi replaces PublicAddress with EthAddress

Was getting RimbleUI error when running npm start

I only get the rimbleUi error if I do an npm update in the client directory.
I don't get the error if I just run as is:
Run ganache-cli in a separate terminal
In an empty project directory unpack the starter kit: npx @openzeppelin/cli unpack starter
Then cd client
Then npm run start
:warning: This project is in maintenance mode. We are no longer actively developing new features, and will only be releasing fixes for high severity issues until July 2020. Read here for more info, and reach out if you are interested in taking over maintenance. We suggest looking into create-eth-app for a popular alternative to this project.


Platform - UI: add 3rd tier to listing size

Issue:

bcgov/entity/issues/24350

Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the strr license (Apache 2.0).

Temporary Url for review: https://strr-platform-dev--pr-302-1ti0irfe.web.app

Temporary Url for review: https://strr-platform-dev--pr-302-1ti0irfe.web.app


Expose 'immediate' parameter for debounce

In some cases, users will expect a search query to run after they've stopped typing. In order to enable this behavior as an option, a debounceAfter property is added that defaults to true, but can be set to false.
Per the Ember.run docs (http://emberjs.com/api/classes/Ember.run.html#method_debounce), the last parameter of debounce() causes the method to be run immediately, with subsequent calls to the same method blocked until the specified time period expires.
The property name debounceAfter is admittedly not great, but I'm not sure what's better.

implemented in fork/rename to hybersearcher...
https://www.npmjs.com/package/ember-hypersearcher

@poteto This problem just bit me and it took some time to figure out. Just curious, why was this closed? Should we be using hypersearcher?

@mattmcmanus - That is why i forked it. Some people complained, but I found it more useful to actually fix the problem in a fork rather than wait.
It was closed due to time elapsed and that it then had conflicts.


Negative coordinates do not work

I'm not sure why specifying negative coordinates for a planet does not seem to work. This may be a problem with the previously set up "game map" of 0 to 20,000. (400,000,000 square pixels)

I found out that there's no real issue and I was just reloading the actual github pages site, thinking it was the file on my local machine.


Add a /-/healthy endpoint for monitoring component health

PR Description
Adding a /-/healthy endpoint which returns an error if at least one component is not healthy. The /-/ready endpoint doesn't check for component health, so this could be useful for Kubernetes liveliness probes.
Which issue(s) this PR fixes
Fixes #2061
Notes to the Reviewer
Prometheus also has a /-/healthy endpoint, and so does Grafana Agent Static mode. However, both of these were not very useful because they always return HTTP 200. There is an open issue in the Prometheus repo to make it more useful.
PR Checklist

[x] CHANGELOG.md updated
[x] Documentation added
[x] Tests updated
[ ] Config converters updated

Hi, I wanted to share some concerns with using component health for liveness probes.
Kubernetes intends for liveness probes to be an indication of when the pod is "stuck" and needs to be killed. Kubernetes will eventually kill the pod if the liveness probe fails enough times.
With this definition of liveness, component health is not a good indicator. Components like remote.s3 can report themselves as unhealthy if an object in S3 gets deleted, and custom components can fail if you give them an invalid configuration (such as someone rolls out a bad config from fleet management).
Killing the pod when components are unhealthy will not only not fix the problem, but since Alloy requires all components to be healthy on startup, it will also completely halt all telemetry collection until the problem is manually fixed.

Hi, I wanted to share some concerns with using component health for liveness probes.

Oh yeah, I 100% agree and I would not recommend using it as liveness probe. But people still wanted it. I think adding this endpoint is harmless, because it can be used for other health checking purposes or diagnostics, not just as a liveness probe. We do know people who wanted to use it as liveness probe, but this would be doing it against our advice. They may have some special requirements though and it may work okay for them.

Hi @rfratto, thank you for opining! I agree that in the component health is not a good indicator for whether Alloy as a whole should be restarted.
Apparently, the issue which originally prompted this feature request is an informer timeout like the one referenced in #2161.
@thampiotr - if that timeout does happen, maybe the real issue is that the component should keep retrying to sync the informers rather than giving up? Judging by the code, the podlogs component will only sync the informers when the config is updated?
I do think there is a benefit in the /healhy endpoint as a whole, although I do agree that we shouldn't recommend that users use it as a liveliness probe. It could be useful in situations where users update the Alloy config and then want to double check that it works as expected. They might do rolling deployments - e.g. 1% of Alloy instances first, and then if they are healthy, the deployment can continue to more instances. I mistakenly thought that liveliness probes in k8s can do similar things, but apparently that's not the case.


not run

not run on colab t4
from OmniGen import OmniGenPipeline
import torch
import os
os.environ["CUDA_VISIBLE_DEVICES"] = "0"
import transformers
transformers.logging.set_verbosity_error()
device = "cuda" if torch.cuda.is_available() else "cpu"
pipe = OmniGenPipeline.from_pretrained("Shitao/OmniGen-v1", device_map=device)
Text to Image
images = pipe(
prompt="A curly-haired man in a red shirt is drinking tea.",
height=768,
width=512,
guidance_scale=1,
seed=0,
separate_cfg_infer=True,
num_inference_steps=1,
num_images_per_prompt=1,
use_kv_cache=True
)
images[0].save("example_t2i.png")  # save output PIL Image
Text to Image
images = pipe(
prompt="A curly-haired man in a red shirt is drinking tea.",
height=768,
width=512,
guidance_scale=1,
seed=0,
separate_cfg_infer=True,
num_inference_steps=1,
num_images_per_prompt=1,
use_kv_cache=True
)
images[0].save("example_t2i.png")  # save output PIL Image

TypeError                                 Traceback (most recent call last)
 in <cell line: 8>()
6 transformers.logging.set_verbosity_error()
7 device = "cuda" if torch.cuda.is_available() else "cpu"
----> 8 pipe = OmniGenPipeline.from_pretrained("Shitao/OmniGen-v1", device_map=device)
9
10 # Text to Image
TypeError: OmniGenPipeline.from_pretrained() got an unexpected keyword argument 'device_map'

not run with accelerate,bitsandbytes
from OmniGen import OmniGenPipeline
from accelerate import init_empty_weights
import bitsandbytes as bnb
Initialize the model with empty weights to save memory
with init_empty_weights():
pipe = OmniGenPipeline.from_pretrained(
"Shitao/OmniGen-v1",
device_map="auto",               # Automatically maps model layers to available devices
torch_dtype=bnb.float16,          # Set data type for bitsandbytes
load_in_4bit=True                 # Load model in 4-bit precision using bitsandbytes
)

Current code doesn't support quantization. We will consider this in the future.

Apparently someone did try to implement quantization, however it is still a WIP and might be somewhat fiddly to use. Check out this PR if you are interested in using it: https://github.com/VectorSpaceLab/OmniGen/pull/29.
You might need to tweak some files as discussed in the PR's discussion after downloading it to get it to work, plus Colab RAM (yes RAM not VRAM) only caps at 12GB for free tier users, so the quantization process will be slow at least and will probably straight up OOM for now. It pretty much filled up the 16GB of RAM on my system running Windows 11 and requires extensive offloading to the disk when quantizing. However judging from the VRAM usage on my system, once the quantization process is over the model might be able to fit in T4's VRAM. Perhaps you would want to wait for the code to be more optimized.

@able2608
It is working on low VRAM

try this
https://www.youtube.com/watch?v=9ZXmXA2AJZ4

2024-10-28 22:00:46.180633: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:485] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2024-10-28 22:00:46.455676: E external/local_xla/xla/stream_executor/cuda/cuda_dnn.cc:8454] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2024-10-28 22:00:46.544035: E external/local_xla/xla/stream_executor/cuda/cuda_blas.cc:1452] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-10-28 22:00:47.043118: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX512F FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2024-10-28 22:00:49.018393: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT

Running on local URL:  http://<IP_ADDRESS>:7860/
Running on public URL: https://9fb36dc912050a91af.gradio.live/

This share link expires in 72 hours. For free permanent hosting and GPU upgrades, run gradio deploy from the terminal in the working directory to deploy to Hugging Face Spaces (https://huggingface.co/spaces)
Fetching 10 files: 100% 10/10 [00:00<00:00, 124460.06it/s]
but dont work with colab t4

!git clone https://github.com/Manni1000/OmniGen.git
%cd OmniGen
!pip install -e .
!pip install gradio spaces
!apt install net-tools -y
!netstat -an | grep 7860
from google.colab import output
!python /content/OmniGen/app.py

!pip install -r /content/OmniGen/requirements.txt
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
gcsfs 2024.6.1 requires fsspec==2024.6.1, but you have fsspec 2024.5.0 which is incompatible.
torchaudio 2.1.1+cu121 requires torch==2.1.1, but you have torch 2.3.1+cu121 which is incompatible.
Successfully installed fsspec-2024.5.0 torch-2.3.1+cu121 torchvision-0.18.1+cu121 triton-2.3.1

2024-10-28 22:29:35.060112: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:485] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
2024-10-28 22:29:35.093217: E external/local_xla/xla/stream_executor/cuda/cuda_dnn.cc:8454] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
2024-10-28 22:29:35.103173: E external/local_xla/xla/stream_executor/cuda/cuda_blas.cc:1452] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
2024-10-28 22:29:35.126043: I tensorflow/core/platform/cpu_feature_guard.cc:210] This TensorFlow binary is optimized to use available CPU instructions in performance-critical operations.
To enable the following instructions: AVX2 AVX512F FMA, in other operations, rebuild TensorFlow with the appropriate compiler flags.
2024-10-28 22:29:36.350897: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT

Running on local URL:  http://<IP_ADDRESS>:7860/
Running on public URL: https://bd987c9a537c35850b.gradio.live/

This share link expires in 72 hours. For free permanent hosting and GPU upgrades, run gradio deploy from the terminal in the working directory to deploy to Hugging Face Spaces (https://huggingface.co/spaces)
Fetching 10 files: 100% 10/10 [00:00<00:00, 50472.97it/s]

gpu not run on colab t4

on colab tpu
!python /content/OmniGen/app.py
/usr/local/lib/python3.10/dist-packages/gradio/utils.py:980: UserWarning: Expected 11 arguments for function <function generate_image at 0x7d4a6ec5e290>, received 10.
warnings.warn(
/usr/local/lib/python3.10/dist-packages/gradio/utils.py:984: UserWarning: Expected at least 11 arguments for function <function generate_image at 0x7d4a6ec5e290>, received 10.
warnings.warn(

Running on local URL:  http://<IP_ADDRESS>:7860/
Running on public URL: https://a19be6bd2476aa5424.gradio.live/

This share link expires in 72 hours. For free permanent hosting and GPU upgrades, run gradio deploy from the terminal in the working directory to deploy to Hugging Face Spaces (https://huggingface.co/spaces)
/usr/local/lib/python3.10/dist-packages/gradio/helpers.py:987: UserWarning: Unexpected argument. Filling with None.
warnings.warn("Unexpected argument. Filling with None.")
Fetching 10 files: 100% 10/10 [00:00<00:00, 93832.30it/s]
Loading safetensors
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/gradio/queueing.py", line 624, in process_events
response = await route_utils.call_process_api(
File "/usr/local/lib/python3.10/dist-packages/gradio/route_utils.py", line 323, in call_process_api
output = await app.get_blocks().process_api(
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 2018, in process_api
result = await self.call_function(
File "/usr/local/lib/python3.10/dist-packages/gradio/blocks.py", line 1567, in call_function
prediction = await anyio.to_thread.run_sync(  # type: ignore
File "/usr/local/lib/python3.10/dist-packages/anyio/to_thread.py", line 33, in run_sync
return await get_asynclib().run_sync_in_worker_thread(
File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 877, in run_sync_in_worker_thread
return await future
File "/usr/local/lib/python3.10/dist-packages/anyio/_backends/_asyncio.py", line 807, in run
result = context.run(func, *args)
File "/usr/local/lib/python3.10/dist-packages/gradio/utils.py", line 846, in wrapper
response = f(*args, **kwargs)
File "/content/OmniGen/app.py", line 51, in generate_image
output = pipe(
File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 116, in decorate_context
return func(*args, **kwargs)
File "/content/OmniGen/OmniGen/pipeline.py", line 189, in call
generator = torch.Generator(device=self.device).manual_seed(seed)
RuntimeError: manual_seed expected a long, but got bool

Collecting cloud-tpu-client==0.10
Downloading cloud_tpu_client-0.10-py3-none-any.whl.metadata (1.2 kB)
Collecting torch==1.13.0
Downloading torch-1.13.0-cp310-cp310-manylinux1_x86_64.whl.metadata (23 kB)
Collecting torchvision==0.14.0
Downloading torchvision-0.14.0-cp310-cp310-manylinux1_x86_64.whl.metadata (11 kB)
Collecting torchtext==0.14.0
Downloading torchtext-0.14.0-cp310-cp310-manylinux1_x86_64.whl.metadata (6.9 kB)
ERROR: Could not find a version that satisfies the requirement torch_xla==1.13 (from versions: 2.1.0rc5, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.0)
ERROR: No matching distribution found for torch_xla==1.13

here you have the conda yaml. it worked for me:
environment.zip

The problem is that I want to run it in Colab T4 and the RAM is 12, so I want to either quantize it and then use it after saving it in T4 or use it with acclrate device_map=device

yuezewang
it not run on gpu colab t4
Your session crashed after using all available RAM.
from OmniGen import OmniGenPipeline
pipe = OmniGenPipeline.from_pretrained("goodasdgood/OmniGen_quantization")
Text to Image
images = pipe(
prompt="A curly-haired man in a red shirt is drinking tea.",
height=1024,
width=1024,
guidance_scale=2.5,
seed=0,
)
images[0].save("example_t2i.png")  # save output PIL Image

https://huggingface.co/goodasdgood/OmniGen_quantization/tree/main

yuezewang
where path to model quantization?

in order to run i and bypass the error od device i just exposed the device to pipline
Define device globally (optional)
device = torch.device("cuda" if torch.cuda.is_available() else "cpu")
print(f'Device ={device}')
90
class OmniGenPipeline:
def init(
self,
vae: AutoencoderKL,
model: OmniGen,
processor: OmniGenProcessor,
):
self.vae = vae
self.model = model
self.processor = processor
self.model.to(torch.bfloat16)
self.model.eval()
self.vae.eval()
    self.model_cpu_offload = False

then replace any sel.device with device as now is global and it will work

Question: Does adding compression to the loading function not store the model on the hard disk? Is this method different from the method for converting a model to 4 bit? Like unshulesh

سؤال هل اضافة الضغط فى دالة التحميل تختلف عن طريقة ذذذذذذ فى تحويل النموذج الى

Question: Does adding pressure in the loading function differ from the method of converting the model to 4bit like unsulsh

NameError: name 'is_torch_npu_available' is not defined. Did you mean: 'is_torch_xla_available'?

from OmniGen import OmniGenPipeline
import torch
pipe = OmniGenPipeline.from_pretrained("C:/Users/m/Desktop/4/OmniGen-v1")
Text to Image
images = pipe(
prompt="car.",
height=64,
width=64,
num_inference_steps=2,
guidance_scale=2,
seed=0,
)
images[0].save("example_t2i.png")  # save output PIL Image
NameError: name 'is_torch_npu_available' is not defined. Did you mean: 'is_torch_xla_available'?

@able2608 @staoxiao
It is working on low VRAM

try this https://www.youtube.com/watch?v=9ZXmXA2AJZ4

wait, how are you getting it 30 times faster than mine?

this is for the exact same prompt

@ronfromhp , do you have a GPU? Running on CPU is very slow. You can try the latest code, and refer to https://github.com/VectorSpaceLab/OmniGen/blob/main/docs/inference.md#requiremented-resources for inference time.

@staoxiao , I have a RTX 4050 laptop GPU 6gb. So it must be running slow because of that. But i tried the forked repo of the guy i was replying to and it seems he's got a quantised model working that's like 50-100 times faster on my gpu

@ronfromhp
Can you confirm that my fork is working fine for you and the generation is fast? Other viewers of my channel confirmed that it is working good.

@nitinmukesh , upto a certain point, it is fast. But it fails at a certain point if i give two input images prompts and ask for a 1080p output for example. Then it falls back to 280 sec/step. I'd describe it as a sigmoid curve, if you exceed a certain threshold it becomes 50 ish times slower

Has anyone had omnigen run on collab?


BREAKING CHANGE: 'DisabledLow' is now changed to Disabled in the docs

GitHub Issue: close https://github.com/unoplatform/Uno.Themes/issues/1236
PR Type
What kind of change does this PR introduce?

[x] Documentation content changes

Description
Replacing  the DisabledLow opacity with Disabled
PR Checklist
Please check if your PR fulfills the following requirements:

Commits must be following the Conventional Commits specification
[ ] Tested the changes where applicable:

[ ] UWP
[ ] iOS
[ ] Android
[ ] WASM
[ ] MacOS

[] Updated the documentation as needed:

[x] General Doc Update
[ ] material-controls-styles.md
[ ] cupertino-controls-styles.md
[ ] lightweight-styling.md (LightWeight Styling Resource Keys)

[x] Contains No breaking changes

If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information

Internal Issue (If applicable):

@Xiaoy312  I did checked the commit message accordingly.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Darsh0307:x: Darsh PatelDarsh Patel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

to be replaced by #1369

Closing this PR as the changes were done in https://github.com/unoplatform/Uno.Themes/pull/1369


⚠ Bofrost.at has degraded performance

In bf27020, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1037 ms

Resolved: Bofrost.at performance has improved in edfb743 after 8 minutes.


Question: discord webhook test

Please check for duplicates or similar issues before asking your question.
What is your question?
discord webhook test

1

2

it works


ISPN-11411 Fix ServerEventLoggerTest failures

https://issues.redhat.com/browse/ISPN-11411

checkstyle does not approve

LGTM. Thanks @tristantarrant !

Backported to 10.1.x also


update: observability icon

Description
Updated observability icon in terraform-ibm-observability-da.
issue: https://github.ibm.com/GoldenEye/issues/issues/10029
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This issue has been resolved in version 1.10.1 :tada:
The release is available on:

GitHub release
v1.10.1

Your semantic-release bot :package::rocket:


update_state_aware_variables(), afl-fuzz.c:900

Currently facing this is issue and have no idea what causing it.
Any help would be greatly appreciated.

Hi. Normally the issue could happen if AFLNet cannot talk to the server under test. I would suggest that you try to run tcpdump to listen to the same port and analyze the captured data.


Debugger doesn't show stack variables in specific conditions

Godot version
v3.5.2.stable.official [170ba337a]
System information
Ubuntu 22.04.2 LTS, GLES2
Issue description
debugger doesn't show stack variables with autoload and resource with overridden _get method in the same scene:
# game.gd
extends Node

export var resource : Resource

func _ready() -> void:
	var foo := 2023
	var bar := "hello world"

# resource.gd
extends Resource

var _data := {}

func _get(property: String):  # Variant
	return _data[property]

# managers.gd
extends Node

the way to fix this is comment _get method in resource.gd or remove autoload from project settings.
Steps to reproduce

launch attachment
add breakpoint in game.gd

Minimal reproduction project
New Game Project.zip

Does the bug happen if you return valid property info in _get_property_list()? I believe that this is a necessary condition for the debugger to work correctly, otherwise Godot will not know that this property exists.

I reproduce it. The bug is not in the resource properties, but in the absence of all variables in the debugger. However, the bug can be workarounded:
func _get(property: String):  # Variant
    #return _data[property]
    return _data.get(property)

I noticed the following warning that goes away with this change, probably related:
New Game Project.zip
editor/script_editor_debugger.cpp:1498 - Condition "cmd.get_type() != Variant::STRING" is true.

It can also crash the engine:
temp-45343.zip
handle_crash: Program crashed with signal 4
Engine version: Godot Engine v3.5.1.stable.custom_build (6fed1ffa313c6760fa88b368ae580378daaef0f0)
Dumping the backtrace. Please include this when reporting the bug to the project developer.
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x3c4b0) [0x7fb6bd43c4b0] (??:0)
[2] CowData<Variant>::get(int) const (/opt/godot/./core/cowdata.h:150 (discriminator 7))
[3] Vector<Variant>::operator[](int) const (/opt/godot/./core/vector.h:88)
[4] Array::operator[](int) const (/opt/godot/core/array.cpp:79)
[5] ScriptEditorDebugger::_parse_message(String const&, Array const&) (/opt/godot/editor/script_editor_debugger.cpp:790)
[6] ScriptEditorDebugger::_notification(int) (/opt/godot/editor/script_editor_debugger.cpp:1485)
[7] ScriptEditorDebugger::_notificationv(int, bool) (/opt/godot/editor/script_editor_debugger.h:59 (discriminator 14))
[8] Object::notification(int, bool) (/opt/godot/core/object.cpp:929)
[9] SceneTree::_notify_group_pause(StringName const&, int) (/opt/godot/scene/main/scene_tree.cpp:1105)
[10] SceneTree::idle(float) (/opt/godot/scene/main/scene_tree.cpp:608 (discriminator 3))
[11] Main::iteration() (/opt/godot/main/main.cpp:2298)
[12] OS_X11::run() (/opt/godot/platform/x11/os_x11.cpp:3987)
[13] /home/danil/ /godot.x11.tools.64(main+0x138) [0x185ab1e] (/opt/godot/platform/x11/godot_x11.cpp:61)
[14] /lib/x86_64-linux-gnu/libc.so.6(+0x23a90) [0x7fb6bd423a90] (??:0)
[15] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x89) [0x7fb6bd423b49] (??:0)
[16] /home/danil/ /godot.x11.tools.64(_start+0x2e) [0x185a92e] (??:?)
-- END OF BACKTRACE --
==========================

In this case, only the editor crashes, the child process stays.


ModuleNotFoundError: No module named '_curses'

OS: Microsoft Windows 10 x64
An error occurred after running Ktool.
Traceback (most recent call last):
  File "c:\python3\lib\runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "c:\python3\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\python3\scripts\ktool.exe\__main__.py", line 4, in <module>
  File "c:\python3\lib\site-packages\ktool\ktool_script.py", line 54, in <module>
    from ktool.window import KToolScreen, external_hard_fault_teardown
  File "c:\python3\lib\site-packages\ktool\window.py", line 31, in <module>
    import curses
  File "c:\python3\lib\curses\__init__.py", line 13, in <module>
    from _curses import *
ModuleNotFoundError: No module named '_curses'

Install curses on windows with python -m pip install windows-curses. It should work then.
Issue is now tracking a better failure state for this on win.

Resolved with d57000a916b9043f028bbe06b4974ebb1a147a1d merger of #48


OSS vulnerability disclosure white paper

In the last WG meeting we had an idea of collecting and distilling the information we've gathered so far in the form of a white paper. I think this would be an amazing resource and a valuable contribution to the OpenSSF.
I did a bit of thinking and thought about a very draft outline:

Introduction to OSS vulnerability disclosure
Ecosystem participants (our personas)
Disclosure models used in the wild
Relevant standards (CVE JSON, CSAF/CVRF, etc.)
Support from open source products and platforms (e.g. GitHub)
Challenges
Recommendations
Case studies

Who would like to participate? I am guessing this requires some commitment over at least a few weeks.

On 12/18/20 6:53 AM, Marcin Hoppe wrote:

In the last WG meeting we had an idea of collecting and distilling the
information we've gathered so far in the form of a white
paper. I think this would be an amazing resource and a valuable
contribution to the OpenSSF.
I did a bit of thinking and thought about a very draft outline

Introduction to OSS vulnerability disclosure
Ecosystem participants (our personas)
Disclosure models in the wild
o OSS VDP/bug bounties
o Coordinated disclosure
Standards (CVE JSON, CSAF/CVRF, etc.)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ossf/wg-vulnerability-disclosures/issues/88, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AQRFDLDQUDAU7GBXS6VPJILSVM7EXANCNFSM4VBCKSSA.

+1.  Love it.
--
This is the Way.  I have spoken,
CRob
Christopher "CRob" Robinson
Modern Renaissance Man for Red Hat Product Security
    ....and other duties as required
irc: CRob  |  tz:  UTC -5:00 (US/Eastern)  | email<EMAIL_ADDRESS>Red Hat Product Security contact<EMAIL_ADDRESS>

I like the term "coordinated disclosure" versus "responsible disclosure." I think some discussion around the different methods of disclosure would be beneficial. Here's an article about "responsible disclosure" versus "full disclosure": https://git-01.md.hardenedbsd.org/shawn.webb/articles/src/branch/master/infosec/Vulnerabilities/2019-01-08_Disclosure/article.md
(FWIW, I support full disclosure, even speaking as a vendor of an open source operating system.)

@lattera Great article.
RE this part I think you're coming at disclosure with a Provider-specific (as in the "provider" persona who is an OS/Distribution vendor or cloud provider) focus RE "When a vendor receives a security notification, the vendor must evaluate who could be impacted and of those impacted, who to notify. Coordinated disclosures usually come with either a Non-Disclosure Agreement (NDA) or an embargo until a specified date. The vendor can choose to collaborate with zero or more impacted entities of the vendor’s own choosing." A lot of disclosures are between the discoverer and a single party who is impacted, who coordinates with no one.  Perhaps it is the majority of disclosures? It'd be interesting to run some stats. Anyway IMHO "coordinated disclosures" is a subset of the larger set of responsible disclosure processes. Not all responsible disclosures require coordination.

I think we should cover all the disclosure models that are relatively common in the OSS world, including independent researchers, through academics, all the way up to coordinated multi-party disclosures involving embargo, etc.

Of course the problem with Full Disclosure is you're creating a huge risk, as as soon as a vuln is public it starts being exploited on a global scale within hours.

Vulnerabilities can be found and exploited independently by multiple parties, regardless of public notification. I know of quite a few actors paying attention to each and every commit to the Linux kernel, writing exploits for errant commits. These actors of motivations not to share publicly the vulnerabilities.

@lattera Agree entirely, and a lot of this has to do with what the vulnerability is and how difficult it is to exploit. High-impact but trivial to exploit - especially remotely - vulnerabilities are the ones that most deserve thought to an embargo. A great example of these would be the NetScaler and PAN-OS vulnerabilities this year... as soon as they became public, active scanning and exploits (and therefore risk to anyone unable to promptly patch ) went through the roof... it is not theoretical that this happens, it's directly measurable. It is always a balancing act.

@lattera @JasonKeirstead this is a great discussion but I am wondering if there is a direct connection to the white paper?

@lattera @JasonKeirstead this is a great discussion but I am wondering if there is a direct connection to the white paper?

The very first point is this:

Introduction to OSS vulnerability disclosure

I think an intro to vulnerability disclosure should probably talk about the different methods of disclosures.

Those Product Security teams involved with FIRST will be familiar with the Vulnerability Disclosure SIG's Multiparty Vuln Disclosure guidelines - https://www.first.org/global/sigs/vulnerability-coordination/multiparty/FIRST-Multiparty-Vulnerability-Coordination.pdf
Ideally this and other documents can help inform us to tailor a consistent practice for OSS.

I created https://github.com/ossf/vulnerability-disclosures-whitepaper to coordinate the development and publication of the whitepaper.

Of course the problem with Full Disclosure is you're creating a huge risk, as as soon as a vuln is public it starts being exploited on a global scale within hours.

Vulnerabilities can be found and exploited independently by multiple parties, regardless of public notification. I know of quite a few actors paying attention to each and every commit to the Linux kernel, writing exploits for errant commits. These actors of motivations not to share publicly the vulnerabilities.

Further, parties reverse engineer binary updates/patches, so "full" disclosure (details, PoC) is probably helping (more capable) defenders more than it helps adversaries. Details/PoC do probably help "commodity" adversaries in the short term.
This sort of discussion may not end up being the point of this document (assuming it remains "what should a maintainer do"), but I'd propose that the paper provide some context about why and how to do disclosure.

Hi @MarcinHoppe / @RedHatCRob
I'd like to contribute to this whitepaper! However, I haven't participated in this working group (yet). Let me know any next steps to get involved :)
I have many thoughts & feels to share regarding disclosure

On 2/8/21 6:16 PM, jenniferfernick wrote:

Hi @MarcinHoppe https://github.com/MarcinHoppe / @RedHatCRob
https://github.com/RedHatCRob
I'd like to contribute to this whitepaper! However, I haven't
participated in this working group (yet). Let me know any next steps
to get involved :)
I have many thoughts & feels to share regarding disclosure
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ossf/wg-vulnerability-disclosures/issues/88#issuecomment-775527635,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AQRFDLFBN3TZUO7J5YB3SHTS6BWEZANCNFSM4VBCKSSA.

Welcome!  The next steps would be to show up to a call and introduce
yourself!  We are glad to collaborate with one that has a passion (and
spare time).  We'll have the whitepaper framed out shortly, once that
happens feel free to contribute thoughts/ideas/references to any/all of
the sections.  After the skeleton is up we'll start talking about it
either within the WG call or will spin off dedicated calls with smaller
groups focused on parts to flesh out and then bring back to the whole group.
--
This is the Way.  I have spoken,
CRob
Christopher "CRob" Robinson
Modern Renaissance Man for Red Hat Product Security
    ....and other duties as required
irc: CRob  |  tz:  UTC -5:00 (US/Eastern)  | email<EMAIL_ADDRESS>Red Hat Product Security contact<EMAIL_ADDRESS>

Great, thank you! I have a recurrent time conflict for the meeting, but will aim to join you next week and as many future weeks as possible, and to add some content to the skeleton once available.


Update OpenSSL to 1.0.2r

Hm, just a glitch in the Travis CI tests or a problem with the new binaries?

Occasionally, there are connection issues with the mosquitto.org test server. I will see if it vanishes if I restart the CI some hours/days later.

:heavy_check_mark:


Converting AdminUI to FastAPI (WIP)

Still a WIP...
Converting AdminUI extension to FastAPI

AdminUI is working! Only changing the funding wallet, requires a server restart!
There's a few files I messed about, in order to have the configs take place, when the ADMIN_UI variable is true. It works but, I believe the way we handle the .env settings, and how we use them throughout LNbits should be refactored! It doesn't make much sense to be reading the .env file every time we call some VARIABLE, and it made it harder to have the AdminUI settings to actually work. There's probably still some cleanup and testing to be made!

@AaronDewes thanks for your input, I'll fix this and commit again!

I'll probably have some more feedback later on, I'm currently playing around with this UI on my node. Great work so far!


Revert legacy poller removal

LGTM. Can be merged once all the nonflaky tests pass.

None of the failures look scary and related to this change.


[stable/rabbitmq-ha] Fix the statefulset when persistent volume is disabled

What this PR does / why we need it:
Right now the statefulset cannot work if the persistent volume is disabled for the following reasons:

priorityClassName, if enabled, would be placed between the beginning of the volumes definitions and the data volume definition
The data volume name property is not used when persistent volume is disabled

Checklist

[x] DCO signed
[x] Chart Version bumped

@steven-sheehy Version bumped. You can assign it to someone now. I can bump the version again later if necessary.

@steven-sheehy Version bumped. You can assign it to someone now. I can bump the version again later if necessary.

Thanks @francois-travais, looks good to me
/assign @davidkarlsen

/ok-to-test

/lgtm


Got things working with Angular-cli

@marcelgood hey mate, just thought id give heads up that got things working fine with angular-cli in the end
Here is what I needed to do, if you wanted a head start on a couple of things.
Add the goodies required to package.json - Also not the mod I make on the "Start" so to use a proxy for angular-cli
{
"name": "angular-breeze-test",
"version": "0.0.0",
"license": "MIT",
"scripts": {
"ng": "ng",
"start": "ng serve --proxy-config proxy.config.json",
"build": "ng build",
"test": "ng test",
"lint": "ng lint",
"e2e": "ng e2e"
},
"private": true,
"dependencies": {
"breeze-bridge-angular": "^4.0.0-alpha1",
"breeze-client": "^1.6.3",
"lodash-es": "^4.17.4",
"bootstrap": "^3.3.7",
"jquery": "^3.2.1",
"font-awesome": "^4.7.0"
},
"devDependencies": {
"@types/jquery": "^2.0.41",
"@types/lodash": "^4.14.58",
"@types/lodash-es": "^4.14.5",
}
}

Install jquery in angular-cli using this as guide
https://www.gurustop.net/blog/2016/11/18/3821/jquery-angular2-angularcli-how-to
this important part is doing this
npm install @types/jquery --save-dev
So that '$' is recognized throughout the ts files

In  tsconfig.app.json, add "jquery"
"types": [
"jquery"
]

In .angular-cli.json, add
"styles": [
"styles.css",
"../node_modules/bootstrap/dist/css/bootstrap.css",
"../node_modules/font-awesome/css/font-awesome.min.css"
],
"scripts": [
"../node_modules/jquery/dist/jquery.min.js",
"../node_modules/bootstrap/dist/js/bootstrap.min.js"
],

You will need to run angular-cli proxy whilst in dev to ensure calls to breeze webapi works
this video shows how and explains why https://juristr.com/blog/2016/11/configure-proxy-api-angular-cli/
Create a file in the root on your angular-cli project called proxy.config.json
Put this in it
{
"http://localhost:49795/breeze/*":{
"target": "http://localhost:49795",
"secure": false,
"logLevel": "debug"
}
}

Then all should be good to go, just setup CORS in webapi of course. Hope it works for you.

Thanks

No worries mate. Close this if ur cool with it. Cheers.


Mask other services to prevent accidental start

Description
Adding this code to prevent my colleagues in the future from accidentally starting rke2-server on a worker node and vice-verse on master nodes in the future.
Type of change

[X] Small minor change not affecting the Ansible Role code (Github Actions Workflow, Documentation etc.)

How Has This Been Tested?
Excerpt from a playbook run:
TASK [rke2 : Mask other RKE2 service on the rest of the nodes] *******************************************************************************************************************************************************
changed: [cmp04-worker] => (item=server)
changed: [cmp03-master] => (item=agent)
changed: [cmp02-master] => (item=agent)
changed: [cmp01-master] => (item=agent)

lgtm. thx!


Order in processing of ASTNode in KdocComments

The problem is not in ordering:

We check KDoc when process CLASS
We fix the KDoc when process VAL_KEYWORD or VAR_KEYWORD inside.

We can move checking KDoc on CLASS level after processing the childs. But probably the fixing of KDoc for class should be done on class level
Originally posted by @nulls in https://github.com/saveourtool/diktat/pull/1769#discussion_r1381538024

Relates to #1538


[SMALLFIX] Supply the variable name to Preconditions.checkNotNull in BaseKeyValueStoreReader.java

Supply the variable name to Preconditions.checkNotNull in BaseKeyValueStoreReader.java

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/17687/
Test PASSed.


TaskDialogIndirect doesn't work for some reason.

On windows with comv6, it shows nothing and freezes the message pump. Need to investigate, you can assign myself if you like. MessageBoxA/W works fine.

MessageBoxA/W bring their own msg pump to the current thread, TaskDialogIndirect doesn't. Not fixable/not an issue.


Slack message being truncated around 2048 chars

Your checklist for this issue

[x] Jenkins version - 2.257
[x] Plugin version - 2.42
[x] OS - Linux

Description
Hi, we are observing an issue with messages sent to Slack being truncated on 2048 chars. Per quick search I've found this issue #390 , where it was said that message size should be 4000. Could you tell me please, this observed truncation is a new limit for message size, or previous issue was really not fixed?

🤷
what are you trying to do that makes it so long?
Check the slack api limits, different fields have different limits

We are sending environments provision reports from Jenkins to Slack. Usually there are small environments being provisioned with 1-3-5 servers, so report is short, but from time to time we need to provision big environments with 40-50 servers in it, and provision reports for such environments are being cut, so developers and testers need to go to the Jenkins to get all the details.
As for API limits, per https://api.slack.com/changelog/2018-04-truncating-really-long-messages Slack accepts messages up to 40000 chars, so 2k limit is quite below that, and can be increased.

Not really sure, happy to take a contribution to fix, best way would be to reproduce with the slack api, adjust the log levels ( details in readme) and see what request the plugin is making and do the same with curl / postman

appears to be the same as before..
https://github.com/jenkinsci/slack-plugin/issues/390
Need to update code https://github.com/jenkinsci/slack-plugin/blob/master/src/main/java/jenkins/plugins/slack/StandardSlackService.java#L363
to include attachment.put("text", message);
and not sure if you still need the following (in same method):
        JSONObject field = new JSONObject();
        field.put("short", false);
        field.put("value", message);

        JSONArray fields = new JSONArray();
        fields.add(field);

I don't have time to test these changes and to see if it breaks any of the "formatted" message logic. But feel free to yourself!

The show more works with the above changes.. not sure what/if it breaks other features..
diff --git a/src/main/java/jenkins/plugins/slack/StandardSlackService.java b/src/main/java/jenkins/plugins/slack/StandardSlackService.java
index 13fa564..2849b16 100755
--- a/src/main/java/jenkins/plugins/slack/StandardSlackService.java
+++ b/src/main/java/jenkins/plugins/slack/StandardSlackService.java
@@ -352,14 +352,15 @@ public class StandardSlackService implements SlackService {
     }

     private JSONArray prepareAttachments(String message, String color) {
-        JSONObject field = new JSONObject();
-        field.put("short", false);
-        field.put("value", message);
+        //JSONObject field = new JSONObject();
+        //field.put("short", false);
+        //field.put("value", message);

         JSONArray fields = new JSONArray();
-        fields.add(field);
+        //fields.add(field);

         JSONObject attachment = new JSONObject();
+        attachment.put("text", message);
         attachment.put("fallback", message);
         attachment.put("color", color);
         attachment.put("fields", fields);

Unfortunately, my Java skills are very low, so I can only patiently wait for someone to fix this :)

Ran into this limitation and there is actually a simple workaround: instead of using a message:
slackSend(channel: channel, color: color, message: message)

you can use a single attachment:
def attachments = [
  [
    text: message,
    fallback: 'Fallback',
    color: color
  ]
]
slackSend(channel: channel, attachments: attachments)

Faced with the same issue. In our case we've got dozens of links in slack message, which length in summary is longer than the plugin limit.
Unfortunately as we use links, we can't send a message as an attachment.


candidates won’t be added when Firefox in audio publish only.

Description
testing the current branch, I noticed that firefox won't publish in audio only mode. digging into the code i found this "return" statement if the video transport wasn't specified.
Resolved adding another check but don't know if it's ok.
Tell me what do you think.
[] It needs and includes Unit Tests
Probably needs but doesn't include
[] It includes documentation for these changes in /doc.

Thanks! So this might fix #604.


Add complete Chatbot example with RAG capability for demo apps

What does this PR do?
This complete example shows how to build a chatbot with RAG and streaming capability with Llama 2, using frameworks such as LangChain, FAISS, Gradio and Text-generation-inference. For RAG, we used Llama 2 Getting Started Guide published on Meta AI website as our knowledge reference.
Fixes # (issue)
Feature/Issue validation/testing
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

[ ] Test A
Logs for Test A

[ ] Test B
Logs for Test B

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ X] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue? Please add a link
to it if that's the case.
[X ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

Thanks for contributing 🎉!

Thank you @jeffxtang for the detailed review. I have addressed most of the comments and left some discussions open.

Thank you @jeffxtang for the detailed review. I have addressed most of the comments and left some discussions open.

Thanks Chester for the update. Looks good! I added one hopefully final comment above, with 4 suggestions. @WuhanMonkey

Thank you @jeffxtang for the detailed review. I have addressed most of the comments and left some discussions open.

Thanks Chester for the update. Looks good! I added one hopefully final comment above, with 4 suggestions. @WuhanMonkey

Accepted the suggestions and updated!

On testing this, I noticed that the system_message does not get set unless the user clears the history. Additionally, the message_history is not being used in this sample, should we just remove it?

@WuhanMonkey can you pls disable the link check as @jeffxtang  did here, https://github.com/facebookresearch/llama-recipes/commit/52197ed6890eba83b5b8a289611797d8423216ed to pass CI.


updating debian broke integration [solution]

Hi
first thanks for the integration for home assistant.
after updating debian to latest (update and upgrade) this integration somehow broke, it couldn't login anymore to AEG
after some digging i changed every import purei9_unofficial.cloudv2 to purei9_unofficial.cloudv3
and in de manifest changed  "requirements": ["purei9_unofficial==0.0.11"] to  "requirements": ["purei9_unofficial==0.0.12"]. (this is the latest release)
that got it working again, dont know if anything changed with cloudv2 API call or something

Updating debian shouldn't have caused the problem, but the old API seems to be down:
https://github.com/Phype/purei9_unofficial/issues/25
https://github.com/JohNan/homeassistant-wellbeing/issues/53
I'm not expecting it to work again since the electrolux app which is based on it was deprecated already, so we have to change to the new API.

had already a feeling that it was the API.
but had a "if it works dont update" kind of a mindset :P

Thanks @juulius for reporting the issue and thanks @Phype for being quick to respond, I really appreciate it.
I've merged a PR #48 by @lorenzo-deluca that fixes the issue, and I've just released a new version of the integration 1.4.1.


Fix issue in normalized byte and short calculation

The calculation for normalized byte and short is incorrect in that it does not normalize the number from 0 to (2^(max_bit depth) -1 ) for normalized bytes and shorts.

Merged #228

Re-fixed and re-merged #229


Some sheep appear invisible

Description: sheep sometimes only leave their shadows to appear
Steps to reproduce: idk look around for long enough?
Extras (picture, video or a crash report if it applies):


Add profile to support spark 2.4.0

Support Spark 2.4.0 by profile.

/run-all-tests

please run format

done.

in order to keep compatibility, there are three ways:

use different source code in compiling stage (what birdstorm did)
compile both version's target classes, but not generate in classpath (still in jar), according to spark's version at runtime, dynamically load the correct classes
according to spark's version at runtime, dynamically generate classes and load classes

use different source code in compiling stage (what birdstorm did)
compile both version's target classes, but not generate in classpath (still in jar), according to spark's version at runtime, dynamically load the correct classes
according to spark's version at runtime, dynamically generate classes and load classes

After discussion with @zanmato1984 , I believe by using scheme with profile is a better way to deal with multi-version dependency. We can use reflection that generates classes at runtime for minor versions -- Spark 2.3.x -- and combine with using different source roots for major versions -- Spark 2.x -- so that alternately we will introduce two releases for TiSpark, i.e., tispark_spark2.3 and tispark_spark2.4.

/run-all-tests profile=spark-2.4

/run-all-tests profile=spark-2.4

After discussion with @zanmato1984 , I believe using scheme with profile is a better way to deal with multi-version dependency. We can use reflection that generates classes at runtime for minor versions -- Spark 2.3.x -- and combine with using different source roots for major versions -- Spark 2.x -- so that alternately we will introduce two releases for TiSpark, i.e., tispark_spark2.3 and tispark_spark2.4.

sounds good

/run-all-tests profile=spark-2.4


Add unstable return code to shell command

Current dsl shell command missed unstableReturn option.
This changes was created by github web interface, so it should be tested.

Already released:
https://github.com/jenkinsci/job-dsl-plugin/pull/1082


Fix Spectral Normalization layer

Hi,
spectral normalization layer is sensitive to initialized weights to zeroes.
I fix it.
Thanks.

@charlielito
You are owner of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.

Any reference about it?

        self.discriminator = keras.Sequential(
            [
                keras.Input(shape=(64, 64, 3)),
                layers.GaussianNoise(0.1),

                layers.Conv2D(64, 7, padding="same", kernel_initializer=TruncatedNormal(stddev=0.02)),
                layers.LeakyReLU(alpha=0.2),
                layers.Dropout(0.3),

                layers.Conv2D(128, 4, strides=(2, 2), padding="same", kernel_initializer=TruncatedNormal(stddev=0.02)),
                layers.BatchNormalization(),
                layers.LeakyReLU(alpha=0.2),
                layers.Dropout(0.3),

                layers.Conv2D(128, 4, strides=(2, 2), padding="same", kernel_initializer=TruncatedNormal(stddev=0.02)),
                layers.BatchNormalization(),
                layers.LeakyReLU(alpha=0.2),
                layers.Dropout(0.3),

                layers.Conv2D(128, 4, strides=(2, 2), padding="same", kernel_initializer=TruncatedNormal(stddev=0.02)),
                layers.BatchNormalization(),
                layers.LeakyReLU(alpha=0.2),
                layers.Dropout(0.3),

                layers.Conv2D(128, 4, strides=(2, 2), padding="same", kernel_initializer=TruncatedNormal(stddev=0.02)),
                layers.BatchNormalization(),
                layers.LeakyReLU(alpha=0.2),
                layers.Dropout(0.3),

                layers.GlobalAveragePooling2D(),
                layers.Dropout(0.3),

                layers.Dense(1, kernel_initializer="zeros"),
            ],
            name="discriminator",
        )

Thank you for your contribution. We sincerely apologize for any delay in reviewing, but TensorFlow Addons is transitioning to a minimal maintenance and release mode. New features will not be added to this repository. For more information, please see our public messaging on this decision:
TensorFlow Addons Wind Down
Please consider sending feature requests / contributions to other repositories in the TF community with a similar charters to TFA:
Keras
Keras-CV
Keras-NLP


Using an async call in an event handler

This should be a pretty common situation.
When receiving an event update (e.g. subscribing to Storage updates), I need to execute an asynchronous function within my code base.
const unsubscribeUpdates = room.subscribe(root, async (root) => {
  debugLog(`Room (${room.id}) applying updates`);
  try {
    await updateValues(...)
  } catch (e) {
    await rebuildValues(...);
  }
});

However the  event handler is not allowed to specify the async keyword.
Is it considered a best practice to wrap and ignore/workaround the lint/ts problems like so?
const unsubscribeUpdates = room.subscribe(root, (root) => {
  const update = async () => {
      debugLog(`Room (${room.id}) applying updates`);
      try {
        await updateValues(...)
      } catch (e) {
        await rebuildValues(...);
      }
  };

  void update();
});

Yeah, this should be fine as long as your updateValues() and rebuildValues() async functions support being called in parallel, this is currently your responsibility. The .subscribe() API is naturally a synchronous API, so with many quick updates, it's possible that the code will get executed in the following order:

Incoming change 1, calls updateValues(1)
Incoming change 2, calls updateValues(2)
Incoming change 3, calls updateValues(3)
updateValues(1) finishes
updateValues(2) fails, calls rebuildValues(2)
updateValues(3) finishes
rebuildValues(2) finishes

If the order of incoming updates is absolutely critical to your functions, and these incoming changes must get handled serially, awaiting each update before taking on the next one, then you can look into solutions like the ones offered by a package like async-mutex.
For example:
import { Mutex } from 'async-mutex';

const myMutex = new Mutex();

const unsubscribeUpdates = room.subscribe(root, (root) => {
  void myMutex.runExclusive(async () => {
      debugLog(`Room (${room.id}) applying updates`);
      try {
        await updateValues(...)
      } catch (e) {
        await rebuildValues(...);
      }
  });
});

Effectively this will form a "queue" for all the incoming updates, which will guarantee serial execution, but may come at a performance penalty if the processing won't happen fast enough. These are trade-offs you can make for your own situation.
Please let me know if this answers your question. If not, feel free to re-open this issue, and I'm happy to provide more help.


Support mandatory fields in createChange

The ServiceNow instance we use requires some fields when creating a change and it doesn't look like there is a way to send these variables using this plugin.
Are there plans to support these fields in the near future?

@satwikabea could you put this issue over at https://github.com/jenkinsci/service-now-plugin/issues? This is just a personal fork now


Variability information accidentally deleted when previewing

Reported during 3DGeo sprint: Previewing removes variablity information (likely due to its shared implementation with batch visualization).

This is a bit more tricky to fix. The easiest workaround is to explore possible parameters with batch visualization and then immediately save the variability without further preview (preview doesn't do anything with variability information anyway)


Projects

This repo is for discussing issues regarding out bot project.
If you have any questions, please ask them in this channel and withhold from opening blank issues.
I'll be closing this now.


Adding support for custom rulesets

Addressing issue #21
@renatoi @thierryk

This one needs to be merged with issue #24 before the tests will pass


Error on running the website locally using Hugo

This is a Bug Report

Problem:
I followed the section "Running the website locally using Hugo" in README of this repo, but I met an error.
With

Ubuntu 18.04 desktop amd64
the latest commit of this repo (0ea4666)
Docsy whose version is the same as of https://github.com/kubernetes/website/tree/main/themes (docsy @ 1c77bb2)
npm version: 6.14.15
node version: v14.18.1
go version go1.17.3 linux/amd64
hugo v0.96.0-2fd4a7d3d6845e75f8b8ae3a2a7bd91438967bbb+extended linux/amd64 BuildDate=2022-03-26T09:15:58Z VendorInfo=mage
Docker Client/Server: 20.10.11

[How to reproduce]
❯ git submodule update --init --recursive --depth 1
# OK with no output

❯ npm ci
npm WARN prepare removing existing node_modules/ before installation

><EMAIL_ADDRESS>postinstall /home/jhseo/k8s-website/node_modules/core-js-pure
> node -e "try{require('./postinstall')}catch(e){}"

Thank you for using core-js ( https://github.com/zloirock/core-js ) for polyfilling JavaScript standard library!

The project needs your help! Please consider supporting of core-js on Open Collective or Patreon:
> https://opencollective.com/core-js
> https://www.patreon.com/zloirock

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

added 120 packages in 1.414s

❯ make serve
hugo server --buildFuture --environment development
Start building sites …
hugo v0.96.0-2fd4a7d3d6845e75f8b8ae3a2a7bd91438967bbb+extended linux/amd64 BuildDate=2022-03-26T09:15:58Z VendorInfo=mage
WARN 2022/04/18 15:43:16 The google_news internal template will be removed in a future release. Please remove calls to this template. See https://github.com/gohugoio/hugo/issues/9172 for additional information.
WARN 2022/04/18 15:43:17 .Path when the page is backed by a file is deprecated and will be removed in a future release. We plan to use Path for a canonical source path and you probably want to check the source is a file. To get the current behaviour, you can use a construct similar to the one below:

  {{ $path := "" }}
  {{ with .File }}
        {{ $path = .Path }}
  {{ else }}
        {{ $path = .Path }}
  {{ end }}

Re-run Hugo with the flag --panicOnWarning to get a better error message.
Error: Error building site: "/home/jhseo/k8s-website/content/en/docs/concepts/workloads/controllers/statefulset.md:410:12": failed to render shortcode "api-reference": failed to process shortcode: "/home/jhseo/k8s-website/layouts/shortcodes/api-reference.html:7:17": execute of template failed: template: shortcodes/api-reference.html:7:17: executing "shortcodes/api-reference.html" at <$page.URL>: can't evaluate field URL in type page.Page
Built in 2752 ms
Makefile:54: recipe for target 'serve' failed
make: *** [serve] Error 255

Proposed Solution:

The version of Hugo that we support is as declared in netlify.toml: 0.87.0
Try using Hugo 0.87.0
Pull requests to adopt a newer Hugo version are welcome.

Following @sftim's comment, I confirmed that this error does not occur with Hugo 0.87.0.

After doing some testing, it seems that the $page.URL field is accessible with Hugo 0.87.0, but not with Hugo 0.96.0 (and maybe with some other versions too).
(I tried to find Hugo changelog that says URL field of Page object is deprecated in what Hugo version, but I could not find.)
Suggested solution:
Instead of URL field, if we use RelPermalink field, I checked locally that it seems working.
[layouts/shortcodes/api-reference.html]
-{{if $textArg}}{{ $textArg }}{{else if $anchorArg}}{{ $anchorArg }}{{else}}{{ $metadata.kind }}{{end}}
+{{if $textArg}}{{ $textArg }}{{else if $anchorArg}}{{ $anchorArg }}{{else}}{{ $metadata.kind }}{{end}}

How I checked:
In CronJob page (http://localhost:1313/docs/concepts/workloads/controllers/cron-jobs/#what-s-next),
the link CronJob goes to http://localhost:1313/docs/reference/kubernetes-api/workload-resources/cron-job-v1/ ,
for these cases:

(As-is) $page.URL, with Hugo 0.87.0
(To-be) $page.RelPermalink, with Hugo 0.87.0
(To-be) $page.RelPermalink, with Hugo 0.96.0

/area web-development

/assign


Accelcalibration reports failure but values are set

With the master (#2098) I can do the accel calibration now but it reports a failure:
[21:04:25.736 - COMP:50] Critical: [cal] calibration failed: to apply calibration, se
[21:04:25.797 - COMP:50] Critical: [cal] calibration failed: accel

Not sure why. It seems to have done it and saved all the parameters for accel 0 and 1

@AndreasAntener Will also have a look at this tomorrow.

I have to add that I get the following startup messages:
telem> PREFLIGHT FAIL: ACCEL #0 SELFTEST FAILED
telem> PREFLIGHT FAIL: ACCEL #1 SELFTEST FAILED
sensors_task: FAILED APPLYING accel CAL #0
sensors_task: FAILED APPLYING accel CAL #1

@AndreasAntener Looking at this now

@AndreasAntener I think the problem are the scaling values. They should be something around 1 but they are one order smaller in magnitude (0.1). The sensor drivers detects this and does not accept the scaling values.

Can you check your values?

Why exactly do you have to multiply from both sides?

https://github.com/PX4/Firmware/blob/master/src/modules/commander/accelerometer_calibration.cpp#L247

offsets / scales are per sensor axis and completely agnostic of the board rotation. That part of the code looks incorrect to me, and all rotations should probably be stripped. The board rotation is only needed for guiding the user through the various positions, on a per-sensor basis its not relevant. Even more important, the sensor offsets should not depend on the board rotation param at all.

Isn't board rotation here the mounting orientation of IMU frame with respect to the body frame, and not the one guiding the user through the different body rotations to collect gravity in different axes ?
^^Multiplications from two sides is actually derived in the comment at the beginning of the file -
 * Calibrating using model:
 * accel_corr = accel_T_r * (rot * accel_raw - accel_offs_r)
 *
 * Actual correction:
 * accel_corr = rot * accel_T * (accel_raw - accel_offs)
 *
 * Known: accel_T_r, accel_offs_r, rot
 * Unknown: accel_T, accel_offs

rot here would represent the mounting of IMU to aircraft body frame.

Fixed by #2131.


Footer of login page #17

Related Issue

Info about the related issue

Closes: [#17]
Describe the changes you've made
I have added a footer to the login page that says made with (heart), using HTML, CSS and the heart in it goes up and down in a motion
Type of change
What sort of change have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Mention any unusual behavior of your code (Write NA if not)
NA
Additional Info (optional)
Added login.html and added the CSS in the pre-existing CSS file
Checklist:

[ ] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented on my code, particularly wherever it was hard to understand.
[x] My changes generate no new warnings.
[ ] Any dependent changes have been merged and published in downstream modules.

there are 2 css why ?

there are 2 CSS files why ?

sorry for the inconvenience, I have updated have a look

Resolve the conflicts once . Just put the body of ur html under the login form html , similarly for css in login.css

Resolve the conflicts once . Just put the body of ur html under the login form html , similarly for css in login.css

I have updated have a look

@shairanshrawat Resolve conflicts.


removing conflicts from change log

Issue #, if available:
Fixes #1087
Description of changes:
Old lingering merge conflicts in changelogs.  Resolved by accepting both changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1090 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1090   +/-   ##
======================================
  Coverage    87.2%   87.2%
======================================
  Files          85      85
  Lines        4095    4095
  Branches      783     783
======================================
  Hits         3571    3571
  Misses        501     501
  Partials       23      23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c0073b...9d1b9ff. Read the comment docs.


Wrong Polygon representation in OData JSON API for ODK Central

Problem description
This issue is about the OData API and the submissions data document and the way it renders polygon data e.g. for the geoshape widget. It applies to ODK Central.
Data captured e.g. for the geoshape widget is mapped to the GeographyPolygon type in OData.
This is rendered similar to the example below. Note that the coordinates are rendered as an array of points.
"geoshape_widget": {
	"type": "Polygon",
	"coordinates": [
		[
			13.052775,
			58.252702,
			0
		],
		[
			13.057901,
			58.255344,
			0
		],
		[
			13.052073,
			58.253716,
			0
		],
		[
			13.052775,
			58.252702,
			0
		]
	]
}

Now according to the GeoJSON standard (RFC 7946), a polygon should be rendered as an array of linear rings:

Coordinates of a Polygon are an array of linear ring (see Section 3.1.6) coordinate arrays.  The first element in the array represents the exterior ring.  Any subsequent elements represent interior rings (or holes).

RFC 7946: https://tools.ietf.org/html/rfc7946#appendix-A.3
Consequently, ODK should render polygons as an array of arrays of points, similar to this:
"geoshape_widget": {
	"type": "Polygon",
	"coordinates": [
		[
			[
				13.052775,
				58.252702,
				0
			],
			[
				13.057901,
				58.255344,
				0
			],
			[
				13.052073,
				58.253716,
				0
			],
			[
				13.052775,
				58.252702,
				0
			]
		]
	]
}

The current challenge with the deviation from the GeoJSON standard is that OData libraries break when encountering polygon data. In my case, I am using Apache Olingo to read the OData API for ODK, and it crashes with a NullpointerException when it attempts to parse points within polygons.
Steps to reproduce the problem

Create a project in ODK Central using the "all widgets" template.
Capture a polygon for the geoshape widget.
Retrieve submission data using e.g. https://trial.getodk.cloud/v1/projects/{project-id}/forms/all-widgets.svc/Submissions.
Observe that coordinates of type Polygon.
Retrieve submission data in Apache Olingo in Java and observe a NullpointerException.

oops. okay. should be a pretty easy fix though if i'm reading this right. it's because they want to make donuts possible eh?


Admin UI revamped + Discord notification (right from admin panel)

PR Fixes:

1 Admin UI revamped
2 Discord notification (right from admin panel)

Resolves #116
#Discord Notification:
https://github.com/user-attachments/assets/e165b98b-8f3c-4205-b9a6-631ca5369a70

Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I assure there is no similar/duplicate pull request regarding same issue

@hkirat @devsargam

Will check within this week. Thanks :)

Checking locally

Thank u sir @amanbairagi30


Replace %p with %s for strings in debug

Debugging strings makes ore sense if we get their string value instead of just their address. So most of these changes should be correct.

So you just want the address in debug, not the values?
Just asking


export and import buttons

self explanatory, just some buttons that can export data to something like clipboard or a file, and then import can just take that information in and load it. would be used to transfer save files or just to mess around with the data

agree


Update certificate-trust.md

adjust the link for "list of participants" to fix link instead of relative path to ensure the redirection works in all respository.
correct the stale link (pointed to unavaialble blog) for "Announcing the automated updater of untrustworthy certificates and keys" and redirect it to certificate update kb as that kb contains the descriptions for ctl auto update details.

@robinharwood, @Xelu86
Can you review the proposed changes?
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Cannot use Tween after using a Timer

Godot version
4.0.1 stable
System information
Windows 10
Issue description
It's not moving
Steps to reproduce
@onready var tween = get_tree().create_tween()
func ready():
await get_tree().create_timer(1).timeout
tween.tween_property($Sprite2D, "position", Vector2(0,0), 1)
Minimal reproduction project
N/A

You should be getting errors that the Tween is invalid.
Create the Tween when you want to tween a property, not some time before that.

As far as my understanding goes, you need to call create_tween() and tween_property() on the same thread. So in this case, you have to call create_tween() in the _ready() function like this
var tween

func ready():
	tween = create_tween()
	tween.tween_property($Sprite2D, "position", Vector2(0,0), 1)

Correct me if I'm wrong. Currently I have no time to test it out

PS: Code blocks should use triple backticks like this (with an optional language name for syntax highlighting):
```gdscript
code here
```
I edited your post accordingly, but remember to do this in the future :slightly_smiling_face:

I think the main problem is that your function is named ready instead of _ready. So it's never called :P
The secondary problem is explained above: Tweens are not supposed to be used like this. To delay a tween, you can add a tween_interval() tweener, or call set_delay() on the tweener.

Closing the report because the issue is in the user code as mentioned above. Please see the recommendations about the Tween usage in the preceding discussion.


Multiple extension for Measurement -> Plot Measurement / load from csv

Hi,
first of all, thank for your great plugin! I would like to use it within the TomoTwin workflow ( https://tomotwin-cryoet.readthedocs.io/en/stable/ ). To give you a very short introduction: TomoTwin is for the localization of Proteins in cellular Tomograms (cryo-ET). It was trained to organize the content (e.g proteins) of those tomograms according shape similarity. It is pretrained on 120 different proteins and generalizes well to new proteins.  There are two workflows, but I will only talk about the clustering workflow, because this is where I would like to use your plugin:

Embed the whole tomogram using a sliding window (37x37x37, stride 2) .

Example A: A tomogram with size 512x512x200 produces  4.644.808 embeddings
Example B: A tomogram with size 1024 x 1440 x 250 produces 37.106.264 enbeddings

Calculate a 2D umap of those embeddings
Identify clusters in this umap (so far we also used a lasso tool)
Calculate the center of those clusters and use it as reference for further picking.

This is how I use your plugin:

A script creates a separate label volume where each embedding (position) gets a unique label
A script create a .csv with the umap of the complete dataset which can then be loaded by the measurement tool
Circle clusters

Its absolutely fantastic to have a direct feedback where the circled positions are. Great stuff!
But now I need to extend Measurement -> Plot Measurement tool in multiple ways:

The umap is totally overplotted. That why you hardly can identify clusters within the umap. I did not find a way to modify the visualization parameters from napari, but  I found the respective numbers that I need to change in the code.  What about having a separate dialog for changing these values?

Also regarding overplotting: It probably would make sense, to allow the user to only use a subsample for plotting, but applying the lasso region to the complete dataset. That would probably also make the plotting much faster, which is right now very slow.
Reading the csv file of example B is not possible because it requires too much memory. I noticed that you are using pandas read_csv in https://github.com/haesleinhuepf/napari-skimage-regionprops/blob/master/napari_skimage_regionprops/_load_csv.py#L16 - it will use by default float64 which is I guess not necessary for virtually all projects. What about using float32 or maybe even float16? Ideally, this would be an option you can change prior reading.
After I circled some of the clusters, I would need to save the respective clustering results. I don't see a way to do that? I would like to add an option for saving this but wondering where you want to have such an extension.
As soon you circled one clusters, it interprets the remaining points as a second cluster and all get visualized, which makes it very hard to identify your selected clusters:

I already found a quick hack by changing the cluster label 0 to -1 making noise labels but idk if that's the way you would like to see it implemented. Anyway, it would be nice if one could specify unselected points as background and don't visualize them.
I would love to selected labels in the label volume and see them highlighted within the plot.

I know these are and should be multiple issues, but I first would like to discuss with you how to proceed.
Best,
Thorsten

HI @lazigu !
Thanks for your swift reply. I will open separate issue for 1, 2 and 5.
I will work on 5 first as I think it's nice and easy issue to begin with.
I keep this issue open for further discussions about 3 and 6?
We gonna checkout your solution for 4. That sounds pretty much like a solution.
Best,
Thorsten

I agree for point 4 this should be enough, we can add the cluster ID to the full embeddings and then do our calculations from there.
+1 for point 6, in a lot of our real world datasets something like this would be extremely helpful to identify the location of certain features in the umap.

Thanks, @thorstenwagner for opening those issues.
Regarding 6, we had this feature removed in #80 because it was disturbing the interaction with data in 3D. However, I assume for 2D data it could be easily re-enabled. One thing to note, labels have to be selected one by one, it is not possible to use something like the lasso tool to select multiple objects at once.

Yes, I can also imagine that that data point would be very hard to spot. Maybe additional highlighting by making the spot bigger should be introduced then, similarly to what we have for highlighting the current frame of the timelapse data.
If you wanted to try the old implementation we had of this feature, you need version 0.4.0 or lower of the plugin. I think because you are not working with timelapse data, that version should not be missing any crucial features. However, plotting would be even less optimal there because no dynamic change of data point sizes and transparency depending on the number of data points was implemented yet.

Regarding point 3 I opened a pull request:
https://github.com/haesleinhuepf/napari-skimage-regionprops/pull/68
With those changes, combined with the 2d histogram, I can now work with datasets as big as 32 millions entries.

Regarding 6:
I think we will not bring it back into this plugin. It was quite easy to add this functionality using an external plugin:
    def get_event(viewer, event):
        global circle
        data_coordinates = label_layer.world_to_data(event.position)
        val = label_layer._get_value(data_coordinates)
        umap_coordinates = umap.loc[umap['label']==val,['umap_0','umap_1']]

        center = umap_coordinates.values.tolist()[0]
        if circle is not None:
            circle.remove()
        circle = Circle(tuple(center), 1, fill=False, color='r')
        plotter_widget.graphics_widget.axes.add_patch(circle)
        plotter_widget.graphics_widget.draw_idle()

As I'm only interested in the rough position within the umap, a circle with fixed diameter is enough for me.
That's quite special for our use case I guess, so if you don't need it won't put efforts into adding this to your plugin.

Regarding 6:
I think we will not bring it back into this plugin. It was quite easy to add this functionality using an external plugin:
As I'm only interested in the rough position within the umap, a circle with fixed diameter is enough for me.
That's quite special for our use case I guess, so if you don't need it won't put efforts into adding this to your plugin.

Great that you found a workaround!
Should this issue then be closed because I think all the relevant points were split into separate issues?

Can be closed!
Thanks for being so open to my changes.
Best,
Thorsten


Don't point to pages which we know will just 301.

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

lgtm other than the one item noted above; feel free to merge after resolving that. @alya @drrosa @amanagr @laurynmm FYI -- we should try to be careful to avoid adding new links to URLs that will just redirect to that same URL with a / appended, since it needlessly slows down the browsing experience. We apparently had over 300 mistakes of this form across the project; they're very easy to make because we only have the trailing / convention for portico pages; the app itself's hash-URLS don't use it.

Merged, thanks @alexmv!


Add ability to retrieve zone DCV delegation information

Add ability to retrieve zone DCV delegation information
Description
To automatically create a DNS CNAME record, the DCV delegation hostname is required, I use the undocumented /zones/<zone-id>/dcv_delegation/uuid endpoint to get the UUID for this.
Types of changes

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] This change is using publicly documented in cloudflare/api-schemas
and relies on stable APIs.

Codecov Report

Merging #1321 (3bb339d) into master (74e0b34) will decrease coverage by 0.60%.
The diff coverage is 72.63%.

@@            Coverage Diff             @@
##           master    #1321      +/-   ##
==========================================
- Coverage   48.95%   48.35%   -0.60%
==========================================
  Files         135      133       -2
  Lines       13180    12945     -235
==========================================
- Hits         6452     6260     -192
+ Misses       5212     5169      -43
  Partials     1516     1516

Impacted Files
Coverage Δ

access_audit_log.go
79.31% <0.00%> (ø)

device_posture_rule.go
61.80% <ø> (ø)

options.go
61.01% <ø> (-3.05%)
:arrow_down:

teams_devices.go
52.63% <ø> (ø)

dns_firewall.go
7.69% <10.00%> (-13.74%)
:arrow_down:

zone.go
41.90% <50.00%> (+0.20%)
:arrow_up:

tunnel.go
42.41% <66.66%> (+1.01%)
:arrow_up:

access_policy.go
70.27% <73.33%> (-6.05%)
:arrow_down:

access_application.go
72.72% <75.47%> (-3.80%)
:arrow_down:

access_mutual_tls_certificates.go
68.86% <75.51%> (-3.36%)
:arrow_down:

... and 9 more

... and 1 file with indirect coverage changes


Fix homepage sections on wide screens

Fix the homepage sections on wide screens, this PR fixes 2 sections:

[x] Top Categories (Already mentioned in #245 )
[x] Top Picks

Here's the difference (1850px width screen):
Before:

After:

We removed these images from the home page as part of our redesign, so this isn't necessary anymore. Thank you for your contribution though

Yeah, I noticed that we've removed those images now. Thanks for reviewing my PR! 💯


Updating Code of Conduct

Updating the Code of Conduct to follow the rest of RAPIDS.
Closes #521

/merge


Use & lazy load class names instead of full definition objects

It seems very inefficient to load the entire schema for every query every time. I have a very small schema (5 types, 1 interface) and it takes 10 ms just to define the schema. Would it be possible to hint to class names instead of objects. This would also 'fix' the many &$postType references (and closures), because the objects are really lazy loaded.
I've no idea if this would be possible. It might have huge downsides. It definitely takes a lot of change. You might've tried something like this already.
Just to clarify, this is what it would look like (in my naive mind):
$schema = new Schema([
	'query' => QueryType::class,
	'types' => [
		UserType::class,
		CourtReservationType::class,
		ClassReservationType::class,
		PlayerType::class,
	],
]);

Schema or Executor or anyone could cache the objects by class name. All references would be class names:
'type' => Type::listOf(ReservationInterface::class),

'interfaces' => [ReservationInterface::class],

etc.
This would make the simple examples more complex, but reality simpler IMO. Every type would require a class, but not memory, until needed.
Like I said, no idea how feasible this is. Just a thought.

Right now query validation requires all types to be loaded in schema.
I've been thinking about ways to relax this requirement, but it will have a price of some invalid queries passing through without errors on validation step and failing on execution step (ot not failing which may be even worse).
So this will come at a cost, yet the payoff might worth it. I'll keep it open as it makes sense to investigate, but it might be not a simple change (at least from what I remember), so no promises on when it will be done.
If you are interested, feel free to investigate this question further and post your findings / pull requests.
The only note - I would not recommend passing class name of the type (because this way you are supposed to force class constructor signature, which is a bad idea).
Instead we should have TypeFactory in Schema which accepts type name (or any other type identifier) and returns type object.
In such case you can implement your own TypeFactory and use any type identifier as convinient for you. But default TypeFactory will be just a pass-through (expecting type instance) for backwards compatibility.

I am not really in deep in this code or in GraphQL for that matter. I am only catching bits and pieces of concepts through the issues and lurking the repos of several GraphQL related libraries like this one. But, from what I understand, shouldn't query validation be more a development need, than a tool used at run-time for the entire program? I mean, couldn't you assume the developer, once he or she is finished with development, would have correct queries calling the server, which would mean the whole validation step could, at that point, be turned off?
Scott

@smolinari You can disable or you can keep it. Depends on your system. If all of your production queries are safe and you do not expose graphql endpoint to public then it makes sense to avoid validation, otherwise (e.g. you expose your graphql to 3rd parties) - you might want to keep it.

Ah yes. That makes sense. I wasn't thinking about a public API.
I think this then goes back to our discussion about regular PHP's shared nothing architecture not being the best architecture for supporting and scaling a GraphQL server.
Scott

Validation requires ALL types to be loaded? Even if the query only touches 3 types, and there are 20 in total? Necessary, or just the way it was built? All fields of all types too? So absolutely no point in lazy loading (closures) any part of it?
I'm trying a few things locally, but it's a lot harder than I hoped =)

@rudiedirkx at this point yes - this implementation mirrors JS reference implementation, but in order to make it work as you describe several significant modifications have to be made. I don't want to break connection with reference implementation until spec becomes stable. But at some point in time this will be done.
Yet if you find elegant way to do this - feel free to post your findings - we'll incorporate them into library code.
As for lazy loading of fields - sometimes it is just inevitable because your fields may reference the type that is not defined at the moment of field definition. So this 'fields' closure is not really related to performance, yet it might help in future performance optimizations.

I close this in favor of #62. Feel free to re-open if you have any problems with proposed solution.


Debian

Build libsmear-dev Debian package.

Whoops, didn't mean for this to include the other change...oh well, ignore the file deletion commit.


Enable binding of secrets to other prefixes

Say you have a standard secret that is shared across multiple applications:
kind: Secret
apiVersion: v1
metadata:
  name: my-secret
type: Opaque
data:
  secret1: VGVzdCAxMjM=
  secret2: VGVzdCAzNDU=

the keys of these secrets are not prefixed and as they would be shared, you might not want them prefixed (or can't if you're out of control of them). You can of course map them into your application, with a no-prefix configuration properties class. But, you might want to bind them to framework-defined configuration properties instead, like spring.mail.properties.mail.smtp.proxy.password. This currently is not possible out of the box, it seems

example use case here is the shared password for an outbound proxy

Why not read the secret property by placeholder to set other properties? For example,
spring.mail.properties.mail.smtp.proxy.password: ${secret1}

oh - I thought only System properties and env vars could be used  as placeholder

Nope, anything in the spring environment. Why can't you do
data:
  some.secret.of.mine: .....=

That should work just fine.

I don't have the key under control. If I had, everything would be simple.

but I'll give @pukkaone 's comment a try