trying to figure out a good framework for unit testing

Playing around with setting up an ORM and some project structure. I'm trying to create a Database trait that can wrap the functionality of getting a connection (from a pool in prod but just nab one in test) and then executing a query. I got a basic function to work (execute) but I'm having trouble figuring out the trait restrictions on something that returns data (get_result).

We decided to move forward with sqlx!


Update zh-CN.json

full proofreading and correcting

Could you resolve the conflict pls? The PR should be raised to the integration branch first. Thanks for the contribution 👍


NTR superior semicircular canal dehiscence

If this is a request for a new term, please provide us with the following information.

Preferred term label (e.g., asplenia)

superior semicircular canal dehiscence

Synonyms (e.g., absent spleen)
related

superior semicircular canal dehiscence  syndrome
canal dehiscence syndrome
superior canal syndrome
third mobile window syndrome
minor’s syndrome
SSCD

Textual definition (the definition should be understandable even for non-specialists. Include a PubMed ID or URL(s) to refer to any relevant article(s) that provides information about the suggested term).

The absence of bone overlying the superior semicircular canal facing toward the dura of the middle cranial fossa.
https://rarediseases.org/rare-diseases/superior-semicircular-canal-dehiscence/

Any additional notes to clarify the meaning or use of the term. Please provide a PubMed ID or URL(s) for the source of this information.

PMID: 28503164
PMID: 9525507

Suggested parent term (Please look in the hierarchy of the MP using the MP Browser or other browsers such as OLS and find the place in the MP where the new term best fits)

Morphological abnormality of the semicircular canal  http://purl.obolibrary.org/obo/HP_0011380

If you would like a nanoattribution, please indicate your ORCID id or provide a label such as MGI:sbello (organization, first initial-last name)

ORCID:0000-0002-2244-7917
ZFIN:CVS
&
ORCID: 0000-0003-3311-7320
ZFIN:KS  @kevinschaper

Definition of middle cranial fossa - http://teachmeanatomy.info/head/areas/cranial-fossa/middle/
I would not call this an abnormality of the semicircular canal, instead I think this is an abnormality of the middle cranial fossa. I think I would put this under abnormal cranium morphology (MP:0000438) or possibly abnormal temporal bone morphology (MP:0005272) as this seems to be the bone that is usually affected.

From the images in the references it looked like the semicircular canals were missing bone but I started out with this as a child of skull morphology.

Based on https://www.ncbi.nlm.nih.gov/pubmed/28503164 I've made this a child of both abnormal superior semicircular canal morphology and abnormal temporal bone morphology, as this is a thinning/absence of temporal bone in the section containing the semicircular canals. The MP terms for semicircular canal include both the bone and the interior of the canal. Based on UBERON (UBERON:0007833) the osseus semicircular canal is part of the 'petrous part of temporal bone'
Also, I just noticed that you had an HP term as a parent, did you mean to submit this to the HPO tracker?
MP:0020461 - superior semicircular canal dehiscence


Use reusable tasks

I have created some reusable gulp tasks. Use them.

Now using reusable gulp tasks


Updating session title

Merging as Admin since request is nearly 3 weeks ago.
Confirmed that the change matches the title of the session "Azure PaaS services - A Detailed Walkthrough" per existing https://github.com/Azure/FTALive-Sessions/blob/main/content/compute-app/paas-services/readme.md


Keybinding question

I noticed there was a recent (Julyish '16) merge of some new keybindings:
https://github.com/the-grid/the-graph/blob/master/the-graph/the-graph-app.js#L398
Won't these get triggered anytime there is input in any ? Would the right way to handle this be to catch that input on and preventDefault there?

Yeah the hot keys should be able to get triggered anywhere on the page. If you have forms with inputs you can capture the keydown event and event.stopPropagation() there. Not sure if there is a better way to handle it than that since we want the hotkeys to trigger anywhere on the page unless there is an input of some sort focused.

I think the more-correct solution is to check the event.target in the keybinding code, and ignore if it is coming from an input, textarea, contenteditable.

Actually, that's what I ended up doing. But for some reason, not sure if it's something I'm doing, but for me event.target is never the actual input, but its container.


daemon: Fatal on XDP + egress gateway

That combination of options is not currently supported and results in the following datapath compilation error:
In file included from bpf_xdp.c:38:
/cilium/bpf/lib/nodeport.h:1108:20: error: no member named 'ifindex' in 'struct xdp_md'
                if (info && ctx->ifindex != ENCAP_IFINDEX) {
                            ~~~  ^
/cilium/bpf/lib/nodeport.h:1108:31: error: use of undeclared identifier 'ENCAP_IFINDEX'; did you mean 'CB_IFINDEX'?
                if (info && ctx->ifindex != ENCAP_IFINDEX) {
                                            ^~~~~~~~~~~~~
                                            CB_IFINDEX
/cilium/bpf/lib/common.h:599:2: note: 'CB_IFINDEX' declared here
        CB_IFINDEX,
        ^
2 errors generated.
make: *** [Makefile:188: bpf_xdp.ll] Error 1

/cc @anfernee @MasterZ40

oh, sorry I didn't test xdp datapath.. Thanks for fixing it.
/lgtm

test-gke

test-1.13-netnext

test-1.19-4.19

test-1.20-4.9

test-runtime

test-me-please


Fix codes in 'Lightning in 2 steps' docs

What does this PR do?
This PR fix codes in 'Lightning in 2 steps' docs.
Fixes # (issue)
Before submitting

[ ] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)

✔ Did you read the contributor guideline, Pull Request section?
✔ Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
✔ Did you make sure to update the documentation with your changes?

[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
✔ Is this pull request ready for review? (if not, please submit in draft mode)
✔ Check that all items from Before submitting are resolved

[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?
Make sure you had fun coding 🙃

doctest is failing with
        class DecayLearningRate(pl.Callback):
    AttributeError: module 'pytorch_lightning' has no attribute 'Callback'


revert: Ast Artifact

Motivation
This reverts parts of #1943 because that PR did not pass all checks and will likely cause a lot of issues in foundry just because there are a lot of different version-specific variants which are likely not covered.
My suggesting is:

partially revert #1943 breaking changes with this PR
fix tests first
more tests for all versions
reconsider replacing Ast with SourceUnit

Since the AST is not of interest in most cases, we ca also handle it similar to Metadata where we just use the Json and add a separate function to deserialize the SourceUnit this makes it less error prone for foundry use case and you can still get the deserialized object via an additional call if you need that.
wdyt @iFrostizz ?

Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Updated the changelog
[ ] Breaking changes

Sure, will do that. Sorry for the noise

Just to clarify @mattsse , so as you probably don't want me to use my fork of ethers-rs as a dep of foundry, should we pin it to a rev, then merge on ethers-rs, run all the tests to make sure that it works, merge, then open the PR on the foundry side, change the deps to latest master of ethers-rs and make sure that all tests are all good. Correct ?

Ya I think you maybe chose the wrong Rev?

Ya I think you maybe chose the wrong Rev?

If you look at the rev bb4af1c is wasn't including the AST at all. It was the last commit on the master branch.
My guess is that you have merged the PR on ethers side first which is why everything was so broken.

Yeah the right way would've been to specify "branch =..." With your own git link instead of the Rev. It's ok no problem.

Yeah the right way would've been to specify "branch =..." With your own git link instead of the Rev. It's ok no problem.

If the dep is pinned to latest rev there should not be any issue in case I do anything wrong with my branch so if we keep it to official repo it's safer probably

perhaps I'm misunderstanding, but the whole point of testing against foundry is using a specific ethers PR, which would be your repository and branch, using rev on master branch defeats that purpose entirely.
See for example: https://github.com/foundry-rs/foundry/pull/3976

perhaps I'm misunderstanding, but the whole point of testing against foundry is using a specific ethers PR, which would be your repository and branch, using rev on master branch defeats that purpose entirely.
See for example: https://github.com/foundry-rs/foundry/pull/3976

Sure we could do that. Just wanted to make sure that in case anything goes wrong on my branch, that won't make foundry user grumpy.
There is probably some misunderstanding, the initial PR would be to pin the ethers-rs to the last rev (without breaking ast), merge ethers-rs ast, and finally open a second PR on foundry to fix everything.
Does that sounds wrong ?

Yeah that's wrong.
The process is:

Open ethers PR, get it reviewed
Open foundry PR, using the ethers PR (not latest master Rev), get it reviewed
Once both PRs look good, we merge ethers PR and then switch foundry to use latest ethers master and merge the Foundry PR

This ensures that your Foundry PR uses the ethers changes.
Hope that makes sense.

Yeah that's wrong.
The process is:

Open ethers PR, get it reviewed
Open foundry PR, using the ethers PR with the breaking changes (not latest master Rev), get it reviewed
Once both PRs look good, we merge ethers PR and then switch foundry to use latest ethers master and merge the Foundry PR

This ensures that your Foundry PR uses the ethers changes.
Hope that makes sense.

It's pretty much the same idea, but in this case we would use my fork as a branch for a process with less friction correct ?

It's not the same process clearly because it resulted in us merging breaking changes 😅 you do need to pin to a commit but we do it via branch and you do it via the Rev which is fine.

I think that you merged it in the wrong order so foundry was relying on ethers with breaking ast

Maybe :)

I don't understand this, because this shouldn't have any effect if the foundry PR would be patched to the ethers PR that introduces breaking changes.

Now using your method. Pinning on my fork's rev and doing stuff there.
As your idea, I'll make it retro-compatible with the old Ast, in case some properties of the ast are forgot, during the serialization the whole coverage will break too this is not desirable. Also trying to add a function to serialize it to the typed Ast. Does that sound good ?
Additionally, I will try to add more constrained tests for the Ast, because for now it's just checking if it doesn't panic during serialization. Idk if it's possible to compare the raw view with the typed one but it would be a great detector of forgot nodes


[Bug] 使用delete 删除的数据仍然可以查询到

Search before asking

[X] I had searched in the issues and found no similar issues.

Version
2.0.4
What's Wrong?
--1. 先创建TEST1表
drop table IF EXISTS TEST1;
CREATE TABLE IF NOT EXISTS TEST1 (
ID int NULL COMMENT 'ID',
ID1 int NULL COMMENT 'ID1',
ID2 int NULL COMMENT 'ID2'
) UNIQUE KEY(
ID
) DISTRIBUTED BY HASH(ID) BUCKETS AUTO PROPERTIES (
"replication_allocation" = "tag.location.default: 1",
"enable_unique_key_merge_on_write" = "true",
"store_row_column" = "true"
);
-- 2. 表中插入一条记录
insert into TEST1(ID,ID1,ID2) values(1,1,1);
select * from TEST1;
查询结果

-- 3. 删除此记录
delete from TEST1 where ID=1;
--4. 设置部分更新
set enable_unique_key_partial_update=true;
set enable_insert_strict=false;
--5. 在此插入相同key值记录
insert into TEST1(ID,ID1) values(1,2);
select * from TEST1;

What You Expected?
上面第五步骤中期望结果为

How to Reproduce?
No response
Anything Else?
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

我看到2.1.2 版本中修复了类似问题，不知道能不能解决我的问题：https://github.com/apache/doris/pull/32574

使用2.1.2版本，此问题仍然存在

Prerequisite Knowledge: During the process of updating partial columns, existing data may be read. If the key of the newly imported data for partial columns already exists, BE (Backend) will read the rows with the same key and update the data of the partial columns. If the key does not exist, BE will write the newly imported data of the partial columns and fill in the default values for other columns.
Since the storage engine used by Doris is similar to the LSM-tree structure, the delete statement does not actually delete the data but marks it for deletion. The delete statement in Doris writes the delete information into the delete predicate, marking the data for deletion with a predicate.
Reason: In step 3, the data with key=1 was deleted, so key=1 was written into the delete predicate. In step 5, when partially updating the columns with key=1, the old data was read without considering the effect of the delete predicate, resulting in the ID2 column showing the previously deleted value.
Solution: When reading and completing data for partial column updates, consider the delete predicate to solve the issue.

Hi, I'll try this.


Rollup compaction

What went wrong?
The current version creates two many small files while indexing or replicating data. Those small files have negative impact on reading the data.
How to reproduce?
Index a data frame where the data has big dispersion, e.g. the records are distributed uniformly in some range. Optimize the index several times to push the data down the index tree. Every time a part of data is saved in some cube that part is stored in a separate file, so after several writes/optimizations where the data falls into different cubes the index has a lot of small files.
Code that triggered the bug, or steps to reproduce:
There is no particular code to blame, the problem is that every write to a cube creates a separate file. This is a problem of the algorithm, not a defect of the implementation.
How to fix?
The proposal is to use the rollup compaction while writing the data to join the blocks of closely related cubes in one physical file, so when the data is queried, there is a high probability that the most of those blocks contribute their data to the query. This approach should reduce the number of small files without significant impact on the query performance. The necessary details can be found in the document https://docs.google.com/document/d/1CY5Gzx46fuatwkAyPRKIRSS7DeD4mOFO697I8_TuTak/edit.

The next steps are:

Separate Main development from 1.0.0-main. There are some breaking features that affects some features of the code and should be discussed/analyzed more in-depth.
Open other PR with only the code to Roll-Up, which will mitigate the "small files" problem.
Decide whether we implement Block Metadata from Multi-block Format with or without Ranges. Ranges help select a block inside a file that represents a particular cube. Without these ranges, the part of Replication might be affected since blocks from different cubes with replicated data can be hard to distinguish within the same file.

One solution is to keep Replicated Data in a totally different folder and apply specific rules for Rolling Up those files.
In that way, we can preserve the Ranges (which makes the writing much memory-intensive and can generate pitfalls with huge datasets) only in the Replicated blocks, while for the rest the condition is removed.


@zephraph => Dont run tests on release commits

I think this is correct.
What do you think? Basically, tests (+ asset compilation), is insanely slow on Force. It's tracked in a JIRA ticket: https://artsyproduct.atlassian.net/secure/RapidBoard.jspa?rapidView=37&view=planning&selectedIssue=PLATFORM-599
With tests and assets, Force can take up to half an hour to actually deploy (each step can be up to 15 minutes, and they can't be parallelized since tests run first). There's also a fair amount of spuriousness in both the tests itself, as well as mysterious Docker/Circle issues, that occasionally fail a step (the more steps we have, the more prone we are to spurious CI issues).
So with a CI issue, it can take literally an entire hour to deploy Force, from the time a dev pushes the button. This is super super slow! It doesn't seem like that JIRA ticket is going to be worked on or prioritized, so let's just chip away... cc @joeyAghion

I think this one is good to go. Let's give it a whirl.


Can't open daily note

Before Submitting: Double-check that you are running the latest version of the plugin. The bug might have already been fixed 😄

Describe the bug
Cannot open existing daily note. Create a daily note file by clicking on a day of the calender view without an existing file, then clicking on the same day won't open the file either. And it prompts "Unable to create  new file"
Steps to reproduce

Go to '...'
Click on '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Environment (please specify)
Windows
[Windows/macOS/Linux]
Obsidian Version v0.11.9
Theme (if applicable):
If the bug is visual, please provide the name of the Community Theme you're using.

Hi @zhxrrb, sorry to hear your running into trouble with the plugin. To figure out what went wrong could you send me two things?

A screenshot of your daily note settings
A screenshot of the Devtools > Console after you try to create a note

The devtools should show a more complete error message with what went wrong and why it's not finding your notes correctly.

How to open the developer tools
On MacOS
Press Command Shift I
On Windows
Press Control Shift I

Here is the daily note setting.

And I made a screen recording to show the problem. I create today's daily note using calender, then close it. Clicking today's number on calender cannot direct me to the existing file  when it already exists.
https://user-images.githubusercontent.com/41381435/113797552-13e23080-9784-11eb-8cf4-672d18d88a61.mp4

Oh I see the issue. I am using a date parsing library that might not be able to interpret the DDDo in your date format when searching for notes matching a particular date. I'll try to fix this this afternoon. Thanks for the screenshots!

Thanks. Actually I changed my filename format and set the DDDo in the yaml part of my daily note, which satisfies my needs too. By the way, calender plugin is an awesome plugin. Appreciate your work.

Hello @liamcain I too have the same issue. I click on the date but it does not open a new note. I have attached the screen shot to the daily notes setting below.

Hi @justresearch547, Obsidian forbids using colons in filenames : since it's an illegal character in many filesystems. I recommend using a different symbol such as a dash in your date format (e.g. YYYY-MM-DD) to avoid issues.

Thank you so so much @liamcain !! This has solved the issue!!
P.S: Your plug in extremely helpful! Thank you so much for creating it! :)


More teams to slapr

What does this PR do?
Add new teams for slapr automation, and remove ASC until https://github.com/DataDog/slapr/issues/45 is implemented

Motivation
Automation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Require JSX attributes and logical expressions to be indented correctly (react/jsx-indent)

https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-indent.md
We already have this rule enabled, but I want to add more options to the rule.
Before:
    "react/jsx-indent": ["error", 2],

After:
    "react/jsx-indent": ["error", 2, { "checkAttributes": true, "indentLogicalExpressions": true }],

This is now considered a warning (wasn't before):
    const Component = () => (
      <View
        ListFooterComponent={(
          <View
            rowSpan={3}
            placeholder="Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do"
          />
    )} // <--- note this is misaligned
      />
    );

Should be:
    const Component = () => (
      <View
        ListFooterComponent={(
          <View
            rowSpan={3}
            placeholder="Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do"
          />
        )}
      />
    );

This is now considered a warning (wasn't before):
<App>
  {condition && (
  <Hello />
  )}
</App>

Should be:
<App>
  {condition && (
    <Hello />
  )}
</App>

Might need to revert this if there's some cases I haven't thought of, but I'm going to ship it and wait for the complaints (if any). I want to get all these JSX rules out at the same time.
Shipping in standard 14.


wirecell sigproc for crp2

Supports the wireccell charge deconvolution for the VD CRP2-style wire geometry. Below are the raw waveform and the deconvolved waveform:

trigger build


pod install fail on RN 0.70.x & New Arch

Bug summary
RCT_NEW_ARCH_ENABLED=1 npx pod-install

[!] Invalid `Podfile` file:
[!] Invalid `RNPermissions.podspec` file: undefined method `install_modules_dependencies' for Pod:Module.

 #  from /Users/i/tmp/Rn70New/node_modules/react-native-permissions/RNPermissions.podspec:20
 #  -------------------------------------------
 #    if ENV['RCT_NEW_ARCH_ENABLED'] == "1" then
 >      install_modules_dependencies(s)
 #      s.platforms  = { :ios => "12.4", :tvos => "12.4" }
 #  -------------------------------------------

Library version
3.8.4
Environment info
System:
    OS: macOS 13.5
    CPU: (10) arm64 Apple M1 Pro
    Memory: 8.00 GB / 32.00 GB
    Shell: 3.6.1 - /opt/homebrew/bin/fish
  Binaries:
    Node: 18.17.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 9.7.2 - /opt/homebrew/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.12.1 - /opt/homebrew/bin/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
    Android SDK: Not Found
  IDEs:
    Android Studio: Flamingo 2022.2.1 Patch 2 Flamingo 2022.2.1 Patch 2
    Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
  Languages:
    Java: 11.0.19 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.1.0 => 18.1.0
    react-native: 0.70.13 => 0.70.13
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Steps to reproduce
cd MyRn70
yarn add react-native-permissions
RCT_NEW_ARCH_ENABLED=1 npx pod-install
Reproducible sample code
...

install_modules_dependencies available in rn 0.71+
create-react-native-library the template with backward compatibility
  # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
  # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
  if respond_to?(:install_modules_dependencies, true)
    install_modules_dependencies(s)
  else
  s.dependency "React-Core"

  # Don't install the dependencies when we run `pod install` in the old architecture.
  if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
    s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
    s.pod_target_xcconfig    = {
        "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\"",
        "OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
        "CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
    }
    s.dependency "React-Codegen"
    s.dependency "RCT-Folly"
    s.dependency "RCTRequired"
    s.dependency "RCTTypeSafety"
    s.dependency "ReactCommon/turbomodule/core"
   end
  end

Sorry, what?

Yes, until new arch is stable libraries often only support the latest version of react-native.
install_modules_dependencies only exists on RN 0.71+


Feat: Login and signup functionality

There is no login and signup functionality in your website.
Please assign this issue to me under label gssoc-ext, hacktoberfest-accepted, level-3.

labels are:  gssoc-ext, hacktoberfest-accepted, level-3 Because it required alot of code please apply all the labels:)

🚀 Feature Request
📝 Feature Description
We want login and signup feature it depends on email and password no two account exist for same email with the error handling.
🔧 How Will This Enhance the App?
If login and signup functionality integrate then no same account is occur and only valid account is occur which is stored in db: Database.
🎯 Use Cases
You can easily implement authentication and authorization using login and signup.
📦 Suggested Implementation

Folder Structure
BACKEND
Backend: It contains the whole backend of login and signup functionality.
Config: It connect the node environment to the database with dbConnect() function.
Controllers: In controllers there is a auth.js which is related to the authentication with all validation and i also used hashing(Bcrypt package) for to secure the password and also used Json-Web-Token for validation of token. No same user can create an account on this platform via same email address.
Models: There is only one model which is User model contains ["Firstname", "Lastname", "Email", "Password", "image-url", "token"].
.env file: In this file there are 3 deafult value you can add or edit accordingly
MONGODB_URL = mongodb://<IP_ADDRESS>:27017/ It req database url
JWT_SECRET = "MYSECRET" Select your token
PORT = 4000 Enter your port number
Index.js: There is basic setup of express and also used middlewares for parsing data.
UI
Components/Auth : There are 3 components are there Template.js LoginForm.js, SignupForm.js On the basis of condition I render Login and signupform respectively! There is simple setup for login and signup using tailwindCSS.
SignupForm : When user click on create account we call to backend for creating a user and also show toast for interactive UI.
LoginForm : When user click on Sign in we call to backend for checking this user exist or not and also hashed their password for matching this is same passsword or not.
Reducer: We combine all the reducer or slices which is used in login and signup functionality.
Slices: We create two slices 1. authSlice which mainly holds token and profileSlice contains the user data for future purpose like for creating a dashboard of user then data will be required so I secured all data for now!.
Services/operations: Inside operations there is one file authAPI which connects or call the backend from the client side and send response accordingly, There are 3 main functions are there LOGIN, SIGNUP, LOGOUT, In login and signup we take data from client side and make a call to apiConnector to pass the given data and show response accordingly!
Services/apiConnector.js: In this file it only recieve the given data from client side and return an axios instance with taking the method of call, data, url, headers, params
Services/api.js: In this file I'm mentioning the all routes of backend which is used in login and signup functionality!.
App.js: In App.js I'm creating a home page so every listing and everything lie on Home page and also create a route for login and signup.
Index.js: I just wrapped the App component in Provider of react-redux.
.env: It having REACT_BASE_URL you can edit acccordingly!
I also setup for tailwindCSS.
Now executable command is changed so Enter: npm run dev so that backend and frontend starts immediately! Please remeber the commands:) and also updates in readme.md file.

@harshbhar0629 But, it's a pure frontend website

No issue with that I will also connect the frontend to backend for implementing login and signup.

Please assign to me with level-3, gssoc-ext, hactoberfest-accepted, we want all 3 labels because it required alot of code inside it:)


Tickers sometimes report "negative time"

I was going back and forth about whether to make an issue for this, since it's very infrequent and thus difficult to reproduce.
But once in a blue moon, the animation controller's assert(duration.inMicroseconds > 0) evaluates to false, seemingly for no reason.

Based on what I saw on Discord recently, maybe tracking this down won't be as difficult as I thought?
cc: @jtmcdole

Duplicate of #106277 ?

If you have a way of reproducing this I would love to not pull out my hair anymore

If you have a way of reproducing this I would love to not pull out my hair anymore

The only solution that has allowed me to stop pulling my hair out is: to be bald 👨🦲
(closing as duplicate)


Launcher says game version not supported!

So i watched both tutorials (telling the same thing) made sure my game version is okay (1.204 at this time),but when i start the launcher it says "Game verison not supported! Reguires 1.202.0 or later".
What did i do wrong here?

Please verify the install folder by going into Steam, right clicking the game in the list, and click Manage>Browse local files. The only way you can get this message is if the game is not up to date.

I did verify the install that didn't work, then i transferred the game to my m.2 drive, put the launcher in bin64 and now it works xD.
WTH?


Limit nodes by amount of pods

Not too long ago I asked to add an option to limit nodes by pods limitation.
I would like to know from which version this feature should be available. Thanks!

Is this about having a maximum number of pods scheduled on a node?
There are some ways to control pod density in Karpenter, do any of those help?

Additionally Karpenter doesn't really schedule pods as mentioned in https://github.com/aws/karpenter/issues/1759 . It's kube-scheduler as mentioned in the other issue that does that job.

@spring1843 I think I saw somewhere in the Karpenter documentation that limiting by amount of pods is yet to be supported but will be in future versions. I'll try to look for it again

We could consider exposing a MaxPods override (https://github.com/kubernetes/kubelet/blob/v0.24.3/config/v1beta1/types.go#L415) in Karpenter's KubeletConfiguration to help control this.

@ellistarn Though this was already in process. Anyway, it would be great exposing it. Could you think of overriding MaxPods from the provisioner?

@devopsjnr we've talked about this a lot before and I'm very supportive of it. The KubeletConfiguration that @ellistarn is referring to is apart of the provisioner spec: https://karpenter.sh/v0.13.2/provisioner/#:~:text=and use cases.-,kubeletConfiguration,-%3A
    clusterDNS%3A


[New Feature for AutoBuild] Supporting build agents from library

Why are these changes needed?
This PR is to introduce a new feature of AutoBuild: build agents from a library. A library is a list of domain expert agents' names and system messages.
To support this feature, the build() function now be separated into three functions: build(), build_from_library(), and _build_agent(). The new build() function and build_from_library() function will generate a list of agent config from scratch or a given library and call the _build_agent() to generate agents based on the agent config list.
I've updated notebooks, example files, and tests for this new feature.
Related issue number

Checks

[x] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[x] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[x] I've made sure all auto checks have passed.

Codecov Report
Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (a0288e0) 26.54% compared to head (6f36592) 31.83%.

Files
Patch %
Lines

autogen/agentchat/contrib/agent_builder.py
0.00%
73 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
+ Coverage   26.54%   31.83%   +5.29%
==========================================
  Files          28       28
  Lines        3805     3835      +30
  Branches      865      916      +51
==========================================
+ Hits         1010     1221     +211
+ Misses       2724     2505     -219
- Partials       71      109      +38

Flag
Coverage Δ

unittests
31.78% <0.00%> (+5.29%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Hi @sonichi, does the test environment support gpt-4-1106-preview or gpt-4-32k? We need a gpt with a large context to support the new feature.

Would it make any sense to return a JSON object (possibly by using function call schema) from the AGENT_SYS_MSG_PROMPT llm call to allow it to support defining tool/function calls and, possibly, other future data? I realize this may be a separate PR but may be somewhat related to this one.

Would it make any sense to return a JSON object (possibly by using function call schema) from the AGENT_SYS_MSG_PROMPT llm call to allow it to support defining tool/function calls and, possibly, other future data? I realize this may be a separate PR but may be somewhat related to this one.

Does the new function call interface look useful to you?
https://microsoft.github.io/autogen/docs/Use-Cases/agent_chat/#function-calling

Would it make any sense to return a JSON object (possibly by using function call schema) from the AGENT_SYS_MSG_PROMPT llm call to allow it to support defining tool/function calls and, possibly, other future data? I realize this may be a separate PR but may be somewhat related to this one.

@radman-x Does the new function call interface look useful to you?
https://microsoft.github.io/autogen/docs/Use-Cases/agent_chat/#function-calling

Yes, that looks good as long as there is a way to use the decorators in AgentBuilder - I don’t see that way since AgentBuilder does not use ConversableAgent nor UserProxyAgent (ie it just uses OpenAIWrapper). Also, of course, there still seem to be some bugs in the decorators that must be fixed. But otherwise, the decorators approach with Python typing and/or Pydantic models is nice.

BTW, on a different subject, it would be really nice if the functions/skills used here as part of AgentBuilder library were compatible with those in AutoGenAssistist/Studio.

hey @radman-x both of your suggestions sound good and maybe you can make an issue for each? we will enhance the autobuild feature PR by PR- and ofc any contribution to autobuild is welcome

Yes, that looks good as long as there is a way to use the decorators in AgentBuilder - I don’t see that way since AgentBuilder does not use ConversableAgent nor UserProxyAgent (ie it just uses OpenAIWrapper). Also, of course, there still seem to be some bugs in the decorators that must be fixed. But otherwise, the decorators approach with Python typing and/or Pydantic models is nice.

@radman-x can you please let us know what bugs did you find in the decorators?

Yes, that looks good as long as there is a way to use the decorators in AgentBuilder - I don’t see that way since AgentBuilder does not use ConversableAgent nor UserProxyAgent (ie it just uses OpenAIWrapper). Also, of course, there still seem to be some bugs in the decorators that must be fixed. But otherwise, the decorators approach with Python typing and/or Pydantic models is nice.

@radman-x can you please let us know what bugs did you find in the decorators?

Mainly issue #1061, though that may be fixed in latest repo (haven’t tested it yet). I did have some problems with using register_function() in the agentchat_groupchat_RAG.ipynb example awhile back though I haven’t tested it lately and I realize this is not directly related to using the decorators. So, as long as #1061 is fixed, I do have anything concrete at this time.
I can create issues on these but it will be a week or so since I’m still on holiday (just checking email).

Hi @sonichi @ekzhu , I've completed the new features for autobuild. Do you have further comments on that, or can we start the opener tests?

Overall I think it is fine for contrib. One comment (not required) is to try to remove unnecessary dependency like chromadb for small-scale vector embedding search -- linear scan is sufficient.

Thanks! I use chromadb because I see autogen seems to have supported this.

Hi @gagb @kevin666aa, CompressionTest and GPTAssistantAgent also failed. Could you take a look at that?

The failure for CompressibleAgent is a known issue. @IANTHEREAL for the GPTAssistantAgent failure.

Failure: https://github.com/microsoft/autogen/actions/runs/7429279268/job/20217636681?pr=1039


Clang 6.0

using clang-format-6.0
renamed folder docker/manylinux -> docker/manylinux-builder

It turns out COVERALLS_REPO_TOKEN is not needed when submitting coverage reports from Travis-CI. So will remove it from Travis once this PR is merged.


[feature] getting rid of default encoding - changing it to utf-8

Brief summary of the change made
Getting rid of default (global) encoding for systems like Windows (cp1251, cp66, etc.).
Inspired by "Fluent Python" (Book by Luciano Ramalho)
Manually checked on environments (constraints/)

Env: Ubuntu 22.04.4 LTS; Python 3.10.12:

dbt140.txt
dbt150.txt
dbt160.txt
dbt170.txt
dbt180.txt

Env: Windows 10 10.0.19044; Python 3.10.10:

dbt150-winpy.txt
dbt180-winpy.txt

Are there any other side effects of this change that we should be aware of?
This changes affect core, so we need to be careful with review.
Pull Request checklist

[x] Please confirm you have completed any of the necessary steps below.

Included test cases to demonstrate any code changes, which may be one or more of the following:

.yml rule test cases in test/fixtures/rules/std_rule_cases.
.sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
Full autofix test cases in test/fixtures/linter/autofix.
Other.

Added appropriate documentation for the change.

Created GitHub issues for any relevant followup/future enhancements if appropriate.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

11 of 11 (100.0%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.985%

Totals

Change from base Build<PHONE_NUMBER>0:
0.0%

Covered Lines:
20405

Relevant Lines:
20408

💛  - Coveralls


feat: Add instrumentation

Add a heimdall node _handleFile under applyPatches.
Local stats are still applied to the applyPatches node.

Leaving in draft while I run ember-cli's tests with this version symlinked.


Fix the output-persisting logic for CustomTrainingJobTask

Fix the output-persisting logic for CustomTrainingJob that falsely blocked the output of a non-distributed training job
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
Was missing the non-distributed training case. This PR adds that and make non-distributed training jobs always persist the output
Tracking Issue
Follow-up issue

Will look in the morning


Implement a feature for lists of objects merging

As a software developer I want to merge 2 or more lists of objects based on criteria or key with left join support. For example example I have 2 lists of the different type of objects and I want to merge it in one list by using specific key and get a merged object list (can be anonymous object type of list). For example merge list of user and groups in one list.

Thank you @Lasse R.H. Nielsen
On Wed, 3 Jun 2020 at 18:20, Lasse R.H. Nielsen<EMAIL_ADDRESS>wrote:

Moving this to the SDK repository, it is not a language issue.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/42167#issuecomment-638103083,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGGLPVXHTLPZESSEFIKV6H3RUYPVFANCNFSM4NRQ4UNQ
.


Prepare 2.1.0

It seems like you're comfortable treating the change from div to span, by default, as a bug fix. The ability to choose is a new feature. So, semver minor bump.

Looks great! I can do the npm publish step :)


syz-executor: increase the execution rate

This PR includes a set of patches that increate the performance of syz-executor. Experiments with syz-testbed have demonstrated a 20-25% increase of the number of executions per second on CGE and a 25-30% speedup when running syzkaller under nested virtualisation.
Commit descriptions contain more details on the specific changes.

Added one more commit. @dvyukov @tarasmadan PTAL
I think now the PR is finally ready to be merged.


Github Action Migration

Planning to switch to Github actions as Tavis ci isn't working for our demands on a free plan.
There won't be any more deploys until this is finished

Update 1:
I saw that, as stated in the main landing page, our project should be hosted "100% free" as it is an open source project. I have contacted support on the matter and I'm awaiting a response

Closed by #378


Removing CC_OPT_FLAGS='-mavx' from the CI scripts.

Having the CC_OPT_FLAGS env var set, prior to running the configure.py scritps results in its value taking precendence over the default option, which is the -march=haswell setting (which implies -mavx amongst others).
Since our build script does not explicitly set CC_OPT_FLAGS, this commit updates the CI scripts to not do it either, making them consistent with the build script

Removing the bazel build option --distinct_host_configuration=false from the rocm-xla CI script. This option has been present for a very long time (we probably inherited it from the original script for running XLA tests on GPU), and I do not quite understand why it is needed (documentation is not helpful). So removing it to see it if it has any adverse side effects. If not, then it goes away permanently

jenkins : retest rocm please

jenkins : retest rocm please


Expanded User Experience

Add navigation to the application.
Add Settings Screen.
Add Probe Details Screen.
Add Cards for Instant Read, Measurements, Plotting, Details.
Simplify card on application Main Screen.

Please use this related branch for testing.
https://github.com/combustion-inc/combustion-android-ble/pull/20

Chris suggests changing the term "Body" to "Middle" on the summary card on the main page instead of "Body".

Instant read card doesn't timeout.


support  Claude 3 family of models, support message api

1、Replace Legacy models， add calls for Claude 2.1, Claude 3 Opus, and Claude 3 Sonnet models.
2、Replaced with a new version of message request, supporting streaming text output.
The Text Completions API is a legacy API. We recommend using the Messages API going forward.
Future models and features will not be compatible with Text Completions.
If there are any deficiencies, please help to modify.

Great work! LGTM.


Unable to inject ILogger in telemetry processor

Based on an existing .NET Core web app:
Repro Steps

Implement a minimal class that implements ITelemetryProcessor (e.g. CustomTelemetryProcessor);
Inject ILogger<CustomTelemetryProcessor> in the constructor;
Register your custom processor for dependency injection by calling:

// Telemetry
services.AddApplicationInsightsTelemetryProcessor<CustomTelemetryProcessor>();

Deploy your application in an Azure App Service;
After a while, try to access a well-known route, a 502 error is shown;
Open the Kudu portal, then pick your favorite shell;
Find your deployed app (e.g. /site/wwwroot/), then try to execute it with dotnet YourAssembly.dll;
Red logs appear indicating a StackOverflowException.

Actual Behavior
It seems that the application will not be able to start, because there might be a circular reference between the logger and the custom telemetry processor, as explained on this StackOverflow thread.
Expected Behavior
If I want to debug my telemetry processor, I should be able to log something to help our investigations.
Version Info

SDK Version : Using Microsoft.ApplicationInsights.AspNetCore at 2.5.1 and Microsoft.ApplicationInsights at 2.8.1;
.NET Version :	Targetting netcoreapp2.2 in the Web project;
How Application was onboarded with SDK (VisualStudio/StatusMonitor/Azure Extension) :
OS : ?
Hosting Info (IIS/Azure WebApps/ etc): the application is hosted on an Azure App Service that hosts the .NET Core 2.2 app.

Telemetry Initializers and Telemetry Processors are executed synchronously to the place of TelemetryClient.Track*() invocation. Therefore, if any of them is producing telemetry that eventually is reported with TelemetryClient.Track() method - you'd have an infinite stack of Track invoking track.
My suspicion is that registering Processor with ILogger would produce some ILogger events for that Processor. If, at the same time, Application Insights is subscribed to ILogger events (which typically is the case) - you'd have a situation described above.
Can you please make sure that Processors do not produce AI telemetry and check if StackOverflow disappears in that case?

I ran into this same problem also when upgrading from .NET Core 2.2 to 3.1.  Specifically, I already had 3 TelemetryProcessors that worked.  All of them required an ILogger in their constructor.  When I upgraded to 3.1, my app hangs during startup.  I did not have much luck looking through AI changelogs and the code compiles.
Did anyone find a solution to this?  For 2 of my processors, I could probably just remove the ILogger on the constructor.  For one of them, it's essential.

https://github.com/microsoft/ApplicationInsights-dotnet/issues/1536#issuecomment-573903440 This explains the reason. Since application insights logger provider is added, there is circular dependency now. TelemetryProcessors require Ilogger injected. Ilogger requires TelemetryConfig to be created, which requires TelemetryProcessors.
This issue hasn't been solved, and at this point, only workaround seems like removing Ilogger from the TelemetryProcessors constructor. If you cannot remove this, then the only other workaround (non trivial) is not NOT register applicationinsights using services.AddApplicationInsights(). Instead manually construct every module and telemetryconfguration.

Thanks @cijothomas makes sense.  I'll keep an eye on this issue and do what I can to mitigate the issue with our processors.  Your quick reply was much appreciated :-)

Sooo... when, if ever, is this going to be addressed? Should be highest priority IMO since it's breaking people upgrading from Core 2.x.

This is not being addressed in the next 2 releases. (i.e no fix at least until end of 2020).
Only recommendation is to use the workaround of removing ilogger from telemetryprocessors.

This is not being addressed in the next 2 releases. (i.e no fix at least until end of 2020).
Only recommendation is to use the workaround of removing ilogger from telemetryprocessors.

Logging is one of the most vital building blocks of any application. To say that not having logging is a "workaround" for logging breaking telemetry processors/initializers entirely, is like saying that removing your arm is preferable to having it broken.
I have to go back to my manager and tell him that we can't have this logging because Microsoft deems it unimportant. He will relay this to our CTO, who is already sceptical of Azure and Microsoft's out-of-the-box solutions. At the end of the day, if our CTO decrees that everything must be hosted in-house and written bespoke because Microsoft's solutions can't be trusted, the only one that loses out is Microsoft.
Think very carefully about your priorities, or lack thereof. Companies choose Microsoft because it has a reputation for reliability and consistency and quality. Issues like these damage that reputation, and refusing to treat said issues as critical, when they manifestly are, does a lot more damage.

Not sure if this is related, let me try reusing this thread instead of creating a new issue as it is also related to injection in implementation of ITelemetryProcessor.
Is this behavior just limited to to ILogger or applicable in other dependencies as well ?
In my case intent was to inject IOpReporter (custom reporter), somehow this do not works for me.
Am i missing something fundamental here ?
 public OpMetricProcessor(ITelemetryProcessor next, IOpReporter reporter)         {             _next = next;             _opReporter = reporter;         }
Hence ended up doing the following workaround :
 public OpMetricProcessor(ITelemetryProcessor next)         {             _next = next;             _opReporter = OpReporterProvider.Reporter;         }
Environment details

dotnet - 3.1.403
Microsoft.ApplicationInsights.AspNetCore - 2.12.1

Not sure if this is related, let me try reusing this thread instead of creating a new issue as it is also related to injection in implementation of ITelemetryProcessor.
Is this behavior just limited to to ILogger or applicable in other dependencies as well ?
In my case intent was to inject IOpReporter (custom reporter), somehow this do not works for me.
Am i missing something fundamental here ?
 public OpMetricProcessor(ITelemetryProcessor next, IOpReporter reporter)         {             _next = next;             _opReporter = reporter;         }
Hence ended up doing the following workaround :
 public OpMetricProcessor(ITelemetryProcessor next)         {             _next = next;             _opReporter = OpReporterProvider.Reporter;         }
Environment details

dotnet - 3.1.403
Microsoft.ApplicationInsights.AspNetCore - 2.12.1

Ran into this annoying issue again today, any updates on this?

Me too

We have this issue as well in .net 5.0, although it's manifesting itself as a DI circular dependency involving TelemetryConfiguration.
We're trying to implement an ITelemetryInitializer which attaches some user metadata to app insights messages. This goes to a user cache that depends on IMemoryCache as implemented by Microsoft.Extensions.Caching.Memory.MemoryCache. MemoryCache is then dependent on ILoggerFactory, and LoggerFactory eventually depends on TelemetryConfiguration.
So we have in essence TelemetryConfiguration -> MyUserTelemetryInitializer -> MyUserCache -> MemoryCache -> LoggerFactory -> TelemetryConfiguration.

I ran into this issue too.
It's not ILogger but using TelemetryClient in the DI has the same issue and preventing the program to start.
I was able to start the program using the runtime DI via IServiceScopeFactory and resolving the TelemetryClient at runtime like this.
/* condition to prevent looping for ever */
if(item is ExceptionTelemetry expTelem && !(item as ISupportProperties).Properties.ContainsKey(DEMYSTIFY))
{
    using (var scope = _factory.CreateScope())
    {
          var telemetry = scope.ServiceProvider.GetRequiredService<TelemetryClient>();
          /* some code here */
          demystifyItem.Properties.Add(DEMYSTIFY, true.ToString());
          telemetry.TrackException(demystifyItem);
    }
}

After that you'll need to check by yourself to not making an infinite loop with your telemetryClient.TrackXXX calls.
Here i just added a custom properties to say "job is done on this exception" so the next call will not execute the same job.
Let me know if it can help you or if you have any better idea/workaround.

I have the same issue with my ITelemetryInitializer. I wanted to use a service which brings more context to the initializer but it has a Logger injectect. Result: Circular Dependency Detected. I need the logger in that service so what woul be the solution?
I'm using .net core 3.1 and Microsoft.ApplicationInsights.AspNetCore 2.15.0

This is still an issue, please remove the stale label

Not sure if the same issue, but definitely related. For the TelemetryInitializer.
Given the following code (webapi dotnet 6 solution):
        builder.Services.AddHttpClient();
        builder.Services.AddSingleton<IEventReporter, SomeClient>();
        builder.Services.AddSingleton<ITelemetryInitializer, CustomInitializer>();
        builder.Services.AddApplicationInsightsTelemetry();

CustomInitializer
public class CustomInitializer : ITelemetryInitializer
{
    private readonly IEventReporter _reporter;

    public CustomInitializer(
        IEventReporter reporter)
    {
        _reporter = reporter;
    }

    public void Initialize(ITelemetry telemetry)
    {
        //...
    }
}

SomeClient
public interface IEventReporter
{
    Task ReportEventAsync(EventTelemetry request);
}

public class SomeClient : IEventReporter
{
    //private readonly ILogger<SomeClient> _logger;
    private readonly IHttpClientFactory _httpClientFactory;

    public SomeClient (
        //ILogger<SomeClient> logger,
        IHttpClientFactory httpClientFactory,
        IOptions<ApiSettings> options)
    {
        //_logger = logger;
        _httpClientFactory = httpClientFactory;
    }
}

you would get a black/blank console screen - no errors, no exceptions. The app simply not starting in debug mode. Though it looks like something is running.
in case if you add an Ilogger injection into the SomeClient - you'd get the exception:

InvalidOperationException: A circular dependency was detected for the service of type 'Microsoft.Extensions.Logging.ILoggerFactory'.

It feels like there is something wrong with the telemetry related classes and methods.. especially when it comes to DI. I would strongly suggest looking into refactoring the code, or at least throw some meaningful errors if there is something wrong with the configuration.


Optimize normalized snps dataframe dtypes

Update the dtype of rsid, chrom, and genotype columns to be pandas.StringDtype as recommended here.
Also require pandas>1.0.0.

Have you thought about using CategoricalDtype for chrom and genotype ? See here

That's a great idea and will really help reduce memory usage for those columns.
And compared to object, it looks like StringDtype for the rsid column will also use less memory.

Note that in a quick test with one of the example files, s._snps.index = s._snps.index.astype(pd.StringDtype()) reduces memory usage by ~2.5 times (very desirable). However, just using .loc with an rsid label coerces the index back to object dtype (e.g., s.snps.loc["rs3094315"]).
It seems that to maintain the rsid column as pd.StringDtype(), either another method would have to be used to filter SNPs (e.g., s.snps.loc[s.snps.index == "rs3094315"]) (less convenient), or astype would have to be called after a .loc to convert the dtype back to pd.StringDtype() (uses more memory temporarily for when the dtype is object).
So, the following dtypes seem like a good trade-off between memory and convenience:

Column
pandas dtype

rsid
object

chrom
pd.CategoricalDtype() (ordered after sorting chroms)

pos
pd.UInt32Dtype()

genotype
pd.CategoricalDtype()

Upon further investigation, it looks like object and pd.StringDtype() use the same amount of memory, and resetting the index dtype as above actually just freed the memory used by a hash table that was generated when label-based lookups were performed on the rsid index internal to snps, e.g., to determine the build. See this issue for explanation of the hash table behavior:  https://github.com/pandas-dev/pandas/issues/31197 .
So, I think to be explicit, rsid should be pd.StringDtype() afterall.
The pandas issue provides ideas on how to prevent the hash table from being generated (e.g., only performing boolean indexing or not using rsid as the index internal to snps).


Highlighting constraints violations is not reset after loading

Precondition
Launch the application with the arguments "example/example.asn -type EXAMPLE.Sequence"
Switch tool to Tree view
Steps to Reproduce:

Step
Action
Expected
Status

1
Select Sequence->example1, set member1 to 999Save encoded data
No error
Pass

2
Set member1 to 6000Select Sequence->example2Select Sequence->example1Save encoded dataLoad encoded data
After reselection, member1 is highlightedSaving fails with error: "example1: member1: Expected an integer between 0 and 5000, but got 6000."After loading, member1 has the value 999
Value is 999, but the highlighting is not reset

3
Hover over Sequence->example1
Tooltip "Minimum:0, Maximum: 5000" is shown
Pending

Open Defect in TestQuality

Test Integer in Run v0.8.0 (linked to Cycle asn1editor Release).


[BUG]: Query text field in the "Transform Dataset" operator cuts off when I paste in a long string.

Describe the bug
When I paste a long string in the LLM query text field in the "Transform Dataset" operator, the top is cut off.
Expected behavior
The text field should not be cut off!
Screenshots

https://github.com/DARPA-ASKEM/terarium/pull/5579


Sample C# Code for Activities Search

Based on the current version, can you kindly a very short sample (console app)
to search for, say, Obama?

It looks like all the former documented methods no longer work. Please!!!

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 8 Feb 2014 at 8:03

Question is more then a year old should probably have been on stackoverflow
A guess would be the author meant Google+ sample project


🚀 : Consistent icons instead of emojis

Is your feature request related to a problem? Please describe.
Emojis make the UI look clutter-y and distracting.
Describe the solution you'd like
Removing emojis (other than country emojis) and replace them with consistent icons would make the UI look way more clean and consistent. For example: the eyes emoji next to "profile visit" has no significance. and the emojis in mother tongue and badges section should be replaced with icons instead of colorful emojis.

Reopening this issue becuase these are should be fixed as well.

@flying-pizza-69 If you can find related files and delete these emojis, i ll be glad! Thank you


Document Ids

Hey, I was looking at your README. The project looks really cool!
I was just wondering about this part in the important caveats:
Document ids:
- Documents without an id field will have one autogenerated (out of necessity)
- I would recommend adding an id field to your documents when possible though
- Current bug in milli: you need your id field at the top of your documents
See https://github.com/meilisearch/product/discussions/206 for more
From what I understand, Mimir is going to check if there is already an id in the documents, and if the document doesn't have one, then it's going to autogenerate an id.
Thus, in any case, your primary key is going to be id. Why don't you just specify it to meilisearch, so it doesn't try to infer anything?

Hi @irevoire 👋
That tidbit in the README is actually just about how milli handles the documents internally when using autogenerate_docids: true (which mimir uses) so that users of this library will know how document ids are handled. At the moment, this project just wraps around a lot of the functionality in milli directly, providing Dart-idiomatic APIs where it makes sense. This is one of those cases; I leave the PK/id inference up to milli.
For a temporary workaround, I could just modify the JSON users supply and pass that modified JSON on over to milli, except considering this project is still in alpha status and I can just upgrade the milli to 1.0 when it comes out (hopefully soon), I haven't bothered.

Ah ok, fyi you should be super cautious with the autogenerate_docids feature isn't really tested anywhere currently. That's why it's not exposed in meilisearch. It has been here for more than a year now, and we never took the time to fully design it in terms of product; thus, I don't really know how it works when it encounters some strange «edge case».
This may be one of the cases where it's better actually to handle it yourself in your SDK :grimacing:

Thanks for the heads up! I will add that to my TODOs.

Closing as a won't fix because I want users to explicitly pass in an id so methods that depend on it are predictable.


Make button responsive in dummy.html

The button that is on Premium Page of the website can be redesigned with responsiveness in mind, The redesigning of the button with its proper size will enhance its look on the page. Here is the link of the page I'm taking about https://qazimaazarshad.github.io/Movie-Streaming-Website/dummy.html
I've also provided  the picture of the button for further reference

@QAZIMAAZARSHAD Please assign this to me i know how to make it responsive

Hi @QAZIMAAZARSHAD I did this
I just forgot to push the changes
I'm doing it now


Shift to yarn

While the other pull request was pending, I decided to create a PR cause we need to move this issue sooner.

Sure. This issue is out for long. We can get this merged anytime soon as the CI passes.

@Harkishen-Singh Squash and merge.


Add recommended meta tags

As recommended by HTML5Boilerplate and Bootstrap

@coliff thanks for your help on this. Rather than creating a new PR for every minor thing, could you instead push multiple commits to one PR? Let me know when you are ready and then I'll merge this.
 Make sure any additional updates are against the latest. So far the last couple have not had any merge conflicts, but I thought I'd mention it in case you didn't notice.

Hi @waylan - sure thing. I'll take a look again tomorrow morning and see if there's anything else.

I'd like to help out updating the 'mkdocs-bootswatch' themes too. I'll look at those tomorrow as well.


[VarCouldBeVal] fix overrides and lateinit false positives

I'm not sure this is correct as this seems a simple check, but this fixes https://github.com/detekt/detekt/issues/4661 and https://github.com/detekt/detekt/issues/4662 and does not break other tests.

Thank you for submitting the PR.
While I agree, that a lateinit var can never really become a val, I think the underlying issue here is the magic done by the framework. To detekt the variable never changes its value and therefor it could be val. Therefor changing your config to
  VarCouldBeVal:
    active: true
    ignoreAnnotated: ['Inject']

would in my opinion also be a valid fix.
Long story short - I think your approach here is valid. The issue that a private lateinit var is never assigned a value should be handled by a different rule.

I ended up doing this workaround for the Inject annotation as this was the main issue in one of our project. But there are many frameworks that rely on an annotation and a lateinit var field, like Mockito. So instead of ignoring all the annotations, I thought lateinit could be ignored by the rule. I believe there's already the rule LateinitUsage to check for lateinit anyway?

I don't think that we should ignore lateinit var by default. They are var so if they aren't assigned they should be flagged. We have methods to disable properties with annotations. At most I would say to add a configuration, but i would like to see a user case where it is needed. Dagger or mockito doesn't need this to work.

@meriouma Could you please change this PR to address the issue with override only. I believe that part is not controversial.
I can see the arguments on either side. Since there is an easy workaround for your specific problem I would also not change it at the moment. Maybe this becomes a pattern and we could change it in the future.

@marschwar Done!

@meriouma Thanks again for picking this up. I would like us to merge #4575 first to avoid a moving target there and would ask your to adopt your test case to junit if that is ok. I am sorry for the inconvenience.

@marschwar Sure, no problem. I can rebase and rewrite the test case once #4575 is merged.

I've rebase and updated the test.


Using Imagemagick in Cloud Code

Hi,
This is not really an issue with Parse-Server, rather a cry for help with using Imagemagick instead of Parse-Image in my cloud code functions. Can anyone point me in the right direction to achieve the same as expressed in my old cloud code:
Parse.Cloud.beforeSave("TheClass", function(request, response) {
  var theObject= request.object;

  Parse.Cloud.httpRequest({
    url: theObject.get("img").url()
  }).then(function(response) {
    var image = new Image();
    return image.setData(response.buffer);
  }).then(function(image) {
  	var currentWidth = image.width();
  	var currentHeight = image.height();
  	var ratio = currentHeight / currentWidth;
    if (currentWidth > 640) {
      return image.scale({
        width: 640,
        height: 640 * ratio
      });
    } else {
      return image;
    }
  }).then(function(image) {
    return image.setFormat("JPEG");
  }).then(function(image) {
    return image.data();
  }).then(function(buffer) {
    var base64 = buffer.toString("base64");
    var cropped = new Parse.File("thumb.jpeg", { base64: base64 });
    return cropped.save();
  }).then(function(cropped) {
    theObject.set("thumb", cropped);
  }).then(function(result) {
    response.success();
  }, function(error) {
    response.error(error);
  });
});

Any help will be much appreciated!

Have a look at
https://github.com/hacksparrow/node-easyimage
or
https://github.com/yourdeveloper/node-imagemagick

@christianmarth Thanks! E.g. in the first link example (EasyImage), how would you initialize an image from the response.buffer like I do in line 8 of my pasted code?

@oyvindvol I wrote a wrapper for Parse.Image that has 100% compatibility with the original parse-image:
https://github.com/flovilmart/parse-image.

I was just getting to the point where I needed this too. Thanks @flovilmart !

@nitrag @oyvindvol the installation is automated on debian and OSX. Installation in Windows is not working yet. For heroku, you need to add a build pack (as explained in the README)

@flovilmart Nice! So, to use this on a heroku based install of parse-server, i just add imagemagick , graphicsmagick and your parse-image to my package.json, and add var Image = require("parse-image") to the top of my cloud code file?

@oyvindvol follow the instructions here: https://github.com/flovilmart/parse-image#heroku-installation
then:
var Image = require("parse-image");
var image = new Image();
image.setData(buffer).then(function(){

});

@flovilmart Ok, so now I did only the "Heroku installation" part, and after deploy the heroku logs say "Cannot find module 'parse-image'". Then I added 'parse-image' as a dependency in package.json, and I still get "cannot find module 'parse-image'" in the logs.

Did you run npm install --save parse-image?

@flovilmart On Heroku server?

does it work locally with foreman?

I haven`t tested locally, I am just trying to set it up on my parse-server-example that I deployed directly to Heroku. I configured the heroku-buildpack-graphicsmagick via git bash, and push to heroku master. I can see that the buildpack is installed, but am I also supposed to put something in my package.json for it to work in my cloud code?

the build pack is installing the binaries required to parse-image to work correctly.
When you push to heroku, you you see parse-image being installed? Can you give me the heroku logs?

Ok, starting from fresh. I added the buildpack in git bash. I remove everything regarding parse-image from my package.json, then i do git push heroku master. This shows in the console:
$ git push heroku master
Counting objects: 4, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (4/4), 328 bytes | 0 bytes/s, done.
Total 4 (delta 2), reused 0 (delta 0)
remote: Compressing source files... done.
remote: Building source:
remote:
remote: -----> Fetching set buildpack https://github.com/mcollina/her
remote: -----> GraphicsMagick app detected
remote: -----> Installing zlib 1.2.8
remote: -----> Installing libpng 1.5.17
remote: -----> Installing nasm 2.10.09
remote: -----> Installing libjpeg-turbo 1.3.0
remote: -----> Installing graphicsmagick 1.3.23
remote: -----> Building runtime environment for graphicsmagick
remote: -----> Using set buildpack heroku/nodejs
remote: -----> Node.js app detected
remote:
remote: -----> Creating runtime environment
remote:
remote:        NPM_CONFIG_LOGLEVEL=error
remote:        NPM_CONFIG_PRODUCTION=true
remote:        NODE_ENV=production
remote:        NODE_MODULES_CACHE=true
remote:
remote: -----> Installing binaries
remote:        engines.node (package.json):  >=4.1
remote:        engines.npm (package.json):   unspecified (use default
remote:
remote:        Resolving node version >=4.1 via semver.io...
remote:        Downloading and installing node 5.6.0...
remote:        Using default npm version: 3.6.0
remote:
remote: -----> Restoring cache
remote:        Loading 2 from cacheDirectories (default):
remote:        - node_modules
remote:        - bower_components (not cached - skipping)
remote:
remote: -----> Building dependencies
remote:        Pruning any extraneous modules
remote:        Installing node modules (package.json)
remote:
remote: -----> Caching build
remote:        Clearing previous node cache
remote:        Saving 2 cacheDirectories (default):
remote:        - node_modules
remote:        - bower_components (nothing to cache)
remote:
remote: -----> Build succeeded!
remote:        ├──<EMAIL_ADDRESS>remote:        ├──<EMAIL_ADDRESS>remote:        ├──<EMAIL_ADDRESS>remote:        └──<EMAIL_ADDRESS>remote:
remote:
remote: -----> Discovering process types
remote:        Procfile declares types     -> (none)
remote:        Default types for buildpack -> web
remote:
remote: -----> Compressing...
remote:        Done: 33.8M
remote: -----> Launching...
remote:        Released v140
remote:        https://<appname>.herokuapp.com/ deployed to Heroku
remote:
remote: Verifying deploy... done.
To https://git.heroku.com/<appname>.git
   241bb07..94bc7b3  master -> master

After deploy finished, this is the heroku logs:
2016-02-25T13:44:26.959982+00:00 heroku[api]: Release v140 created by
2016-02-25T13:44:27.098280+00:00 heroku[slug-compiler]: Slug compilation started
2016-02-25T13:44:27.098284+00:00 heroku[slug-compiler]: Slug compilation finished
2016-02-25T13:44:27.472830+00:00 heroku[web.1]: State changed from crashed to starting
2016-02-25T13:44:31.180828+00:00 heroku[web.1]: Starting process with command `npm start`
2016-02-25T13:44:34.223438+00:00 app[web.1]:
2016-02-25T13:44:34.223454+00:00 app[web.1]: ><EMAIL_ADDRESS>start /app
2016-02-25T13:44:34.223455+00:00 app[web.1]: > node index.js
2016-02-25T13:44:34.223456+00:00 app[web.1]:
2016-02-25T13:44:35.351267+00:00 app[web.1]: npm ERR! Linux 3.13.0-77-generic
2016-02-25T13:44:35.351727+00:00 app[web.1]: npm ERR! argv "/app/.heroku/node/bin/node" "/app/.heroku/node/bin/npm" "start"
2016-02-25T13:44:35.352006+00:00 app[web.1]: npm ERR! node v5.6.0
2016-02-25T13:44:35.352641+00:00 app[web.1]: npm ERR! npm  v3.6.0
2016-02-25T13:44:35.352863+00:00 app[web.1]: npm ERR! code ELIFECYCLE
2016-02-25T13:44:35.353074+00:00 app[web.1]: npm ERR<EMAIL_ADDRESS>start: `node index.js`
2016-02-25T13:44:35.353260+00:00 app[web.1]: npm ERR! Exit status 1
2016-02-25T13:44:35.353469+00:00 app[web.1]: npm ERR!
2016-02-25T13:44:35.353663+00:00 app[web.1]: npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node index.js'.
2016-02-25T13:44:35.353868+00:00 app[web.1]: npm ERR! Make sure you have the latest version of node.js and npm installed.
2016-02-25T13:44:35.354073+00:00 app[web.1]: npm ERR! If you do, this is most likely a problem with the parse-server-example package,
2016-02-25T13:44:35.354285+00:00 app[web.1]: npm ERR! not with npm itself.
2016-02-25T13:44:35.354466+00:00 app[web.1]: npm ERR! Tell the author that this fails on your system:
2016-02-25T13:44:35.354682+00:00 app[web.1]: npm ERR!     node index.js
2016-02-25T13:44:35.354864+00:00 app[web.1]: npm ERR! You can get information on how to open an issue for this project with:
2016-02-25T13:44:35.355304+00:00 app[web.1]: npm ERR! Or if that isn't available, you can get their info via:
2016-02-25T13:44:35.361157+00:00 app[web.1]: npm ERR! Please include the following file with any support request:
2016-02-25T13:44:35.361327+00:00 app[web.1]: npm ERR!     /app/npm-debug.log
2016-02-25T13:44:35.360891+00:00 app[web.1]:
2016-02-25T13:44:35.355700+00:00 app[web.1]: npm ERR! There is likely additional logging output above.
2016-02-25T13:44:35.355092+00:00 app[web.1]: npm ERR!     npm bugs parse-server-example
2016-02-25T13:44:35.355515+00:00 app[web.1]: npm ERR!     npm owner ls parse-server-example
2016-02-25T13:44:35.329120+00:00 app[web.1]: module.js:341
2016-02-25T13:44:35.329124+00:00 app[web.1]:     throw err;
2016-02-25T13:44:35.329125+00:00 app[web.1]:     ^
2016-02-25T13:44:35.329125+00:00 app[web.1]:
2016-02-25T13:44:35.329126+00:00 app[web.1]: Error: Cannot find module 'parse-image'
2016-02-25T13:44:35.329128+00:00 app[web.1]:     at Function.Module._load (module.js:290:25)
2016-02-25T13:44:35.329127+00:00 app[web.1]:     at Function.Module._resolveFilename (module.js:339:15)
2016-02-25T13:44:35.329129+00:00 app[web.1]:     at Module.require (module.js:367:17)
2016-02-25T13:44:35.329129+00:00 app[web.1]:     at require (internal/module.js:16:19)
2016-02-25T13:44:35.329131+00:00 app[web.1]:     at Module._compile (module.js:413:34)
2016-02-25T13:44:35.329130+00:00 app[web.1]:     at Object.<anonymous> (/app/cloud/main.js:1:75)
2016-02-25T13:44:35.329131+00:00 app[web.1]:     at Object.Module._extensions..js (module.js:422:10)
2016-02-25T13:44:35.329132+00:00 app[web.1]:     at Module.load (module.js:357:32)
2016-02-25T13:44:35.329132+00:00 app[web.1]:     at Function.Module._load (module.js:314:12)
2016-02-25T13:44:35.329133+00:00 app[web.1]:     at Module.require (module.js:367:17)
2016-02-25T13:44:35.340090+00:00 app[web.1]:
2016-02-25T13:44:36.035081+00:00 heroku[web.1]: State changed from crashed to starting
2016-02-25T13:44:36.033934+00:00 heroku[web.1]: State changed from starting to crashed
2016-02-25T13:44:36.030078+00:00 heroku[web.1]: Process exited with status 1
2016-02-25T13:45:58.111674+00:00 heroku[web.1]: Starting process with command `npm start`
2016-02-25T13:46:00.447983+00:00 app[web.1]: > node index.js
2016-02-25T13:46:00.447984+00:00 app[web.1]:
2016-02-25T13:46:00.447981+00:00 app[web.1]: ><EMAIL_ADDRESS>start /app
2016-02-25T13:46:00.447964+00:00 app[web.1]:
2016-02-25T13:46:01.919098+00:00 app[web.1]: npm ERR! Linux 3.13.0-77-generic
2016-02-25T13:46:01.901180+00:00 app[web.1]: module.js:341
2016-02-25T13:46:01.901184+00:00 app[web.1]:
2016-02-25T13:46:01.901186+00:00 app[web.1]:     at Function.Module._load (module.js:290:25)
2016-02-25T13:46:01.901190+00:00 app[web.1]:     at Module.require (module.js:367:17)
2016-02-25T13:46:01.919662+00:00 app[web.1]: npm ERR! node v5.6.0
2016-02-25T13:46:01.920572+00:00 app[web.1]: npm ERR!
2016-02-25T13:46:01.901189+00:00 app[web.1]:     at Module.load (module.js:357:32)
2016-02-25T13:46:01.920799+00:00 app[web.1]: npm ERR! Make sure you have the latest version of node.js and npm installed.
2016-02-25T13:46:01.921630+00:00 app[web.1]: npm ERR! Or if that isn't available, you can get their info via:
2016-02-25T13:46:01.920445+00:00 app[web.1]: npm ERR! Exit status 1
2016-02-25T13:46:01.901183+00:00 app[web.1]:     ^
2016-02-25T13:46:01.901186+00:00 app[web.1]:     at Module.require (module.js:367:17)
2016-02-25T13:46:01.921130+00:00 app[web.1]: npm ERR! Tell the author that this fails on your system:
2016-02-25T13:46:01.901188+00:00 app[web.1]:     at Module._compile (module.js:413:34)
2016-02-25T13:46:01.901185+00:00 app[web.1]:     at Function.Module._resolveFilename (module.js:339:15)
2016-02-25T13:46:01.920340+00:00 app[web.1]: npm ERR<EMAIL_ADDRESS>start: `node index.js`
2016-02-25T13:46:01.901187+00:00 app[web.1]:     at require (internal/module.js:16:19)
2016-02-25T13:46:01.921412+00:00 app[web.1]: npm ERR! You can get information on how to open an issue for this project with:
2016-02-25T13:46:01.901185+00:00 app[web.1]: Error: Cannot find module 'parse-image'
2016-02-25T13:46:01.920061+00:00 app[web.1]: npm ERR! npm  v3.6.0
2016-02-25T13:46:01.920218+00:00 app[web.1]: npm ERR! code ELIFECYCLE
2016-02-25T13:46:01.901182+00:00 app[web.1]:     throw err;
2016-02-25T13:46:01.921287+00:00 app[web.1]: npm ERR!     node index.js
2016-02-25T13:46:01.901190+00:00 app[web.1]:     at Function.Module._load (module.js:314:12)
2016-02-25T13:46:01.901188+00:00 app[web.1]:     at Object.<anonymous> (/app/cloud/main.js:1:75)
2016-02-25T13:46:01.921847+00:00 app[web.1]: npm ERR! There is likely additional logging output above.
2016-02-25T13:46:01.901189+00:00 app[web.1]:     at Object.Module._extensions..js (module.js:422:10)
2016-02-25T13:46:01.919493+00:00 app[web.1]: npm ERR! argv "/app/.heroku/node/bin/node" "/app/.heroku/node/bin/npm" "start"
2016-02-25T13:46:01.911119+00:00 app[web.1]:
2016-02-25T13:46:01.921026+00:00 app[web.1]: npm ERR! not with npm itself.
2016-02-25T13:46:01.921739+00:00 app[web.1]: npm ERR!     npm owner ls parse-server-example
2016-02-25T13:46:01.920685+00:00 app[web.1]: npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node index.js'.
2016-02-25T13:46:01.921524+00:00 app[web.1]: npm ERR!     npm bugs parse-server-example
2016-02-25T13:46:01.925610+00:00 app[web.1]: npm ERR!     /app/npm-debug.log
2016-02-25T13:46:01.920921+00:00 app[web.1]: npm ERR! If you do, this is most likely a problem with the parse-server-example package,
2016-02-25T13:46:01.925509+00:00 app[web.1]: npm ERR! Please include the following file with any support request:
2016-02-25T13:46:01.925339+00:00 app[web.1]:
2016-02-25T13:46:02.554694+00:00 heroku[web.1]: Process exited with status 1
2016-02-25T13:46:02.564724+00:00 heroku[web.1]: State changed from starting to crashed

it seems that your package.json is not properly updated, or that heroku don't like it..
 Build succeeded!
remote:        ├──<EMAIL_ADDRESS>remote:        ├──<EMAIL_ADDRESS>remote:        ├──<EMAIL_ADDRESS>remote:        └──<EMAIL_ADDRESS>
Try to run on your machine: npm install --save parse-image and then deploy to heroku

After adding parse-image to my package.json the module is found.
But now I get this error: [Error: Command failed: identify.im6: no decode delegate for this image format /tmp/magick-x4qqyfba'`

That seems to be related to imagemagick, http://stackoverflow.com/questions/30309633/after-replacing-rmagick-with-minimagick-gets-identify-im6-no-decode-delegate

Ok, thanks a lot so far @flovilmart!
I tried console.logging the url to my uploaded ParseFile, console.log(theObject.get("img").url());. The url was http, not https. Then i ran this command in the heroku bash identify -verbose <URL-TO-FILE>, and there the identify seemed to work fine at least.
identify -verbose http://<app>/parse/files/sv78uRNzD4RPUKW9

Image: 5ef1d74591c83c189609957ee1f18860_portal.PNG
  Base filename: 5ef1d74591c83c189609957ee1f18860_portal.PNG
  Format: PNG (Portable Network Graphics)
  Class: DirectClass
  Geometry: 2438x1400+0+0
  Resolution: 75.59x75.59
...
...
and so on

Is your response.buffer set?

Yes

Uhm... that's very very odd indeed. Did you try on you local machine, see if it's heroku related or something else?

You should probably open an issue on parse-image instead of there. Closing for now.

Well, initially this issue was about using the recommended Imagemagick in parse server cloud code. I am still interested in examples on that though..

OK, can you post an issue on parse-image I'll re-open in that case.

http://stackoverflow.com/questions/30309633/after-replacing-rmagick-with-minimagick-gets-identify-im6-no-decode-delegate

I used jimp to replace parse-image when I migrated our app. It works like a charm! It is written entirely in JavaScript for Node so no external dependencies needed (no special install on heroku or windows). It probably has worse performance than imagemagick (I haven't yet run any benchmarks). We are scaling a lot of images in our app however and so far it looks promising!

@simonbengtsson That looks lightweight and good. Are you using jimp to e.g. save thumbnails via cloud code? I am having trouble getting that work. With the code provided below, everything seems OK, and the thumb is saved on the "Message" object, but viewing the thumb in the browser with the file URL is not working.
var Jimp = require("jimp");

Parse.Cloud.beforeSave("Message", function(request, response) {
  var obj = request.object;

  if (!obj .get("img")) {
    response.success();
    return;
  }

  Jimp.read(obj.get("img").url())
  .then(function(image) {
    var currentWidth = image.bitmap.width;
    var currentHeight = image.bitmap.height;
    var ratio = currentHeight / currentWidth;
    if (currentWidth > 640) {
      return image.resize(640, 640 * ratio)
    } else {
      return image;
    }
  })
  .then(function(image) {
    console.log("### 1");
    var base64 = image.hash();
    var cropped = new Parse.File("thumb.jpeg", { base64: base64 });
    return cropped.save();
  })
  .then(function(cropped) {
    console.log("### 2");
    obj.set("thumb", cropped);
  })
  .then(function(result) {
    console.log("### 3");
    response.success();
  }, function(error) {
    console.log("### 4 ERROR: " + error);
    response.error(error);
  })
  .catch(function (err) {
    console.log("### 5 ERROR: " + err);
  });
});

Yes we are generating thumbnails in cloud code using jimp. Your issue is probably that the string from image.hash() cannot be used as data for parse files. Try something like this instead:
image.resize(100, 100).getBuffer(Jimp.MIME_JPEG, (err, buffer) => {
    return new Parse.File('picture.jpg', {base64: buffer}).save();
});

@simonbengtsson Thanks! :) That worked..

Since it took me several hours to get this correct I'm posting here so the next guy has an easier time:
Parse.Cloud.beforeSave("Photos", function(request, response) {
	Parse.Cloud.useMasterKey();

	createThumbnail(request.object.get("Image").url(), 360, 360).then(function(shrunk) {
        request.object.set("ImageThumbnail", shrunk);
        console.log("Thumbnail generated/added: " + JSON.stringify(shrunk));
    }).then(function(result) {
            response.success("thumbnail saved");
        }, function(error) {
            response.error("thumbnail creation error: " + error.code + "("+ error.message + ")");
    });
});
function createThumbnail(url, maxWidth, maxHeight){
	var Jimp = require("jimp");
	Parse.Cloud.useMasterKey();
    if(url === ""){
        console.log("url empty");
        return;
    }

	console.log("Generating Thumbnail...");
    return Jimp.read(url).then(function(image) {
        console.log("Buffer read, resizing...");
        var ratioX = maxWidth / image.bitmap.width;
        var ratioY = maxHeight / image.bitmap.height;
        var ratio = Math.min(ratioX, ratioY);

        var w = image.bitmap.width * ratio;
        var h = image.bitmap.height * ratio;

        return image.resize(w, h );
    }).then(function(image) {
        console.log("Resized, setting quality...");
        return image.quality(90);
    }).then(function(image) {
        console.log("Quality set, return buffer");
        var promise = new Parse.Promise();
            image.getBuffer(Jimp.MIME_JPEG, function(err, buffer){
                if (err) return promise.reject(err);
                promise.resolve(buffer);
            });
        return promise;
    }).then(function(buffer) {
        console.log("Buffer returned, creating Parse File");
        var shrunk = new Parse.File("thumbnail.jpg", { base64: buffer }, "image/jpeg");
        return shrunk.save();
    }).then(function(shrunk) {
            return shrunk;
        }, function(error) {
            console.log("thumbnail generation error: " + error.code + "("+ error.message + ")");
            return;
    });

}

Thanks for sharing this pure js image module, here is the benchmarks I found for jimp in comparison with other libraries.
https://github.com/lovell/sharp/issues/275#issuecomment-143526723
It seems enough for common image processing cases.

@flovilmart I tried your parse-image module on Heroku for a simple thumbnail generation. I did not need to change a single line of code, only added "parse-image": "~0.1.1" in my package.json dependencies, and it works fine so far.
Great job!

@nitrag Thanks for your post.  Fwiw, to get your approach to work, I had to add a line before creating the new thumbnail Parse.File:
var base64 = buffer.toString("base64"); var shrunk = new Parse.File("thumbnail.jpg", { base64: base64 }, "image/jpeg"); return shrunk.save({useMasterKey: true});

@nitrag Thanks for your post.  Fwiw, I had to add a buffer.toString conversion before I could get everything to work.
var base64 = buffer.toString("base64");
var shrunk = new Parse.File("thumbnail.jpg", { base64: base64 }, "image/jpeg");
return shrunk.save({useMasterKey: true});

This all seems to be working great for me using jimp until the part where I try to set it to the object in the beforeSave hook. I see the images showing up in S3 and it comes back correctly. For some reason it just seems as if it's not updating the request.object. @rickkrauland  Was there something you had to do different then what is documented in @nitrag 's example?

So... turns out that response.success doesn't want a string sent along with it. I removed "thumbnail saved" from response.success() and it worked.


Spanish language

name: Spanish translations
about: Translation of all texts into Spanish.
title: Spanish translations for all text.
Describe the Pull request
He añadido la traducción de todos los textos del desarrollo al idioma español internacional.
Pull request type
Keep only the option that better matches your pull request.

[X] New feature (non-breaking change which adds functionality)

Test Configuration:

Hardware: MacBook Pro, 16 (2019)
macOS Version: 10.15.2
Xcode version: 11.3

@pigigaldi Is it possible to review this Pull Request?


handlebars or text/template?

Should we use a language-neutral template engine (handlebars or dtl)?
Or stick with go built-in text/template?

After some long thinking, looks like the current support for handlebars is not really cross-language compatible - handlebars itself has v3.0 and v4.0, and then there is a list of incompatibilities or differently implemented features in each language's library (example)
Easy language porting with handlebars doesn't seem to be fully possible. So sticking with golang text/template for now. I think this might significantly impact the ability for this project to be ported to rust, but I think a 1.0 release is blocked right now, so lets tackle this when the time comes.
/cc @fiji-flo


New macros many0_count! and many1_count!

Prerequisites

related issue number: #818
a test case reproducing the issue This is not a bug fix.
if adding a new combinator, please add code documentation and some unit tests
in the same file. Also, pelase update the combinatornator list

To-dos

Fix style
Move tests from tests/many_count.rs to the source Done
Update the combinator list

Coverage decreased (-0.3%) to 87.194% when pulling 0f0b4f8765b7ffa20e00131d8da5efdd52e7cfb2 on tsraom:new-many into a88a6f8d3fe3cf41ef682bbfec1fd72f08edcf95 on Geal:master.

I believe the decrease in coverage is due to my addition of lines to certain functions that deals with ErrorKind in utils.rs, which were not covered to begin with. In my opinion, covering these functions is not relevant to this pull request.

hello, these combinators look useful, but could you do a few things before I can merge it?

move the unit tests from tests/many_count.rs to src/multi.rs. It makes the test suite easier to use, since I don't have to wait for the entire nom library and tests to pass before it would be compiled
did you apply a formatting tool or something to src/multi.rs? As it's currently displayed, it's very hard to review (usually github would show whitespace changes, but I don't see them here)
can you squash all of this in a single commit?

Thank you for your help :)

I reverted the merge from master into my fork 4ed25b1. I shouldn't have done that, since I didn't know there was a new feature called ParseTo, which wasn't compatible with the changes I made to implement my two new macros and the tests.

The Travis builds are failing because of merge conflicts due to ParseTo in util.rs and parse_to in multi.rs, I believe. Should I merge the new master into my own fork?


We need redistributable test data and templates to use with the example programs.

The test data currently being used is proprietary and cannot be
redistributed.  We need to find or develop some redistributable test data.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 6 Mar 2009 at 5:13

Where can I find the template.xml and FAST Data for the tests ? Thanks!


RNS-800: Adds unparsing for Casting of [float value string] (eg: '45.34') to Integer in Bigquery

https://datametica.atlassian.net/browse/RNBS-800

3 test cases seems to be failing on the branch. Please fix them, refer attached snap for the same :

LGTM.


VPN Support

Support VPN requirement for cluster access.

Do you mean private only clusters? I don't believe there is anything specific to VPN that we need to support.


Syntax highlighting breaks inside square brackets in v2.43.0

When using statements inside an array (square brackets), like using if or while statements within an array of functions, then the syntax highlighting breaks.
Here's how this sample example should look:

But when the same function is part of an array, syntax highlighting breaks at the if statement:

Look what happens if I remove the left angle bracket from the if statement below:

Even in ES6 syntax version it breaks:

Here's the sample code for quick test:
var arrayOfFunctions = [
  function (callback) {
    var num = 0;
    if (num <= 0) {
      return callback(null);
    }
    return callback(num);
  },
  function (callback) {
    var num = 0;
    if (num <= 0) {
      return callback(null);
    }
    return callback(num);
  }
];

Thanks. It is a regression caused by the recent change. I'll take a look.

Try 2.44.0

Works great now and all the syntax highlighting is back. Thank you so much @gandm 👍


Problems in combination with Blitz caching plugin

Hi Nick, I have encountered another problem in connection with the Blitz caching plugin. When I activate the plugin, the PreviewMate plugin no longer works. Blitz does not cache pages in preview mode, yet it behaves differently whether I have activated or deactivated the plugin. I have also tried the various caching exclusions but nothing has helped. It looks like the asynch getSettings method fails. Do you have an idea how this can be fixed?

Hey @abinggeli , sorry for the late response. I'm excited to announce we have released v3 today which adds CraftCMS 5 support.
In v3, the config/preview-mate.php has been removed entirely.
I've tested v3 with Blitz and it appears to be working.
Check out the craft-5 branch readme for updated instructions.

Hi Nicholas,
Thank you very much for the update. Unfortunately, the customer's website is still on Craft 4. An update to Craft 5 is not planned at the moment. It seems that the plugin in version 3.x and 4.x only works with Craft 5? I tried the dev-craft-4 branch, but I couldn't get it to work. Is there a solution for Craft 4?
Best regards,
Andy

Am 12.11.2024 um 02:30 schrieb Nick Hamilton @.***>:
Hey @abinggeli https://github.com/abinggeli , sorry for the late response. I'm excited to announce we have released v3 today which adds CraftCMS 5 support.
In v3, the config/preview-mate.php has been removed entirely.
I've tested v3 with Blitz and it appears to be working.
Check out the craft-5 branch readme for updated instructions.
—
Reply to this email directly, view it on GitHub https://github.com/nicholashamilton/craft-preview-mate/issues/3#issuecomment-2469409204, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGE74RRRUVMTUTZ5DTDY25T2AFK3LAVCNFSM6AAAAABRS6IKTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRZGQYDSMRQGQ.
You are receiving this because you were mentioned.

Hey @abinggeli,
Are there any syntax issues within your config/preview-mate.php by chance (I doubt it if it works with Blitz disabled)?
I'm not sure why Blitz is causing the HTTP request to error. I have not been able to replicate this on craft-4 with the Blitz plugin enabled on my end. Is there any additional info on the HTTP request that you can provide for debugging?


Uninstall Apps Feature

Can you add uninstall app features for this package? I think it might be suitable solution for adding this feature https://www.semicolonworld.com/question/45412/install-uninstall-apks-programmatically-packagemanager-vs-intents

Available in 2.2.0 release


Complete documentation of EditorExportPlugin

Closes https://github.com/godotengine/godot-docs/issues/2756
I wasn't sure about some methods, especially iOS ones. But the doc is roughly complete.

Thanks!

Cherry-picked for 3.2.4.


Bootstrap PackageDescription with -module-cache-path

#2118 missed the custom invocation of swiftc in process_runtime_libraries(). This PR corrects that.
Hopefully completes work on rdar://problem/50385698.
(@aciidb0mb3r, does this need to be separately cherry-picked to swift-5.1-branch?)

@swift-ci please test

+1!

@shahmishal looks like the normal test on swift package manager doesnt set smoke test...

Ah, sorry. I missed this one.

I don't think 5.1 even has #2118 so we should cherry-pick both commits if it's required there.


Add getGeneric function; Add to tutorials

Coverage decreased (-0.3%) to 94.495% when pulling c594d6a0f6ad424114f4f8327847c6409bfaf12f on dersimn:fork/pr-2 into 4eb0c293a5ca15d8c51953866d5ff2576b2567f4 on thelinmichael:master.


Make all code snippets runnable

I fixed all code snippets in docstrings runnable. We can test all codes with make doctest under docs directory.

this pr fixes #1761

LGTM!