Inconsistent Backend.onehot behavior

On our setup (GeForce GTX 980, running latest revision of neon from kaixhin's CUDA 7.0 based Docker image), Backend.onehot appears to provide inconsistent output depending on whether a CPU or GPU backend is being used. The following code:
import numpy as np
import neon
import neon.backends

# use gpu backend
be = neon.backends.gen_backend('gpu', batch_size=32, device_id=0)
for i in (0,1):
        all_zeros = be.zeros(5, dtype=np.uint16)
        all_ones = be.ones(5, dtype=np.uint16)

        x_onehot = be.zeros((2,5), dtype=np.uint16)
        y_onehot = be.zeros((2,5), dtype=np.uint16)

        a = be.onehot(all_zeros, axis=0)
        b = be.onehot(all_ones, axis=0)

        x_onehot[:] = a
        y_onehot[:] = b

        # should be sequence of (1,0) pairs
        print x_onehot.get()
        # should be sequence of (0,1) pairs
        print y_onehot.get()

        # switch to CPU backend
        be = neon.backends.gen_backend('cpu', batch_size=32)

provides the following output:
[[1 1 0 0 0]
 [0 0 0 0 0]]
[[0 0 0 0 0]
 [0 0 0 0 0]]
[[1 1 1 1 1]
 [0 0 0 0 0]]
[[0 0 0 0 0]
 [1 1 1 1 1]]

where we would expect to see the first two matrices (output from the GPU-backed onehot encoding) match the second two (from the CPU backend), and the output from the CPU appears correct. I may be getting the major dimensions mixed up and can re-run with different settings but the GPU-backed one-hot encodings just look wrong.

Behavior is correct when using np.int32. Comments make reference to "numpy integer" type which should be more specific.


Increase PoW worker count for API?

https://github.com/gohornet/hornet/blob/develop/plugins/restapi/v1/messages.go#L237

Fixed by #902


Make gather_output in parallel_embedding configurable

Hello,
It seems that the gather_output parameter is always set to False in the embedding_to_parallel_embedding function. In some use cases, I found it is essential to set it to True in order to gather lm_head from all ranks before going ahead with the next step (e.g. adding some pre-defined bias terms, etc.). Could this parameter become configurable and exposed in the embedding_to_parallel_embedding function signature? thanks.

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!


(Native) English proofreading

Hi!
As non-native English speakers/writers, we are looking for people willing to proofread the CONTRIBUTING and README files.
Thank you for your help ❤

PLEASE: leave a comment here to let everyone knows that you are working on this issue, before submitting a PR!

I'm going through your CONTRIBUTING file right now and see a few changes that can be made!

I'm looking through the files to check for something I can fix.

Hi @yrahul3910, could you rather review @schott12521's PR here: #117? Thanks!

The proofreading by @schott12521 matches what I had changed, so I'll work on proofreading the README file. :)

I will do this too where can i find the read me file

This is issue is solved, thanks everyone!


Fix dangerous issue

I fixed an extremely bad bug where there was a spelling mistake

dbwdhesfinitely importand code vulnerability


[intersection] Incoming vehicle is ignored in some complex pattern

Checklist

[X] I've read the contribution guidelines.
[X] I've searched other issues and no duplicate issues were found.
[X] I'm convinced that this is not my fault but a bug.

Description
We observed incoming vehicles are ignored by the intersection module in in some specific pattern. Here is a simple demonstration with the planning simulator:
https://github.com/autowarefoundation/autoware.universe/assets/18645627/b00d839b-05a4-4b9c-adc6-f1fdf9201582
As you can observe, an "intersection" wall appears when the dummy vehicle comes from below, but not when the vehicle comes from the left or the top. If I simplify the map by deleting all irrelevant lanelets, then incoming vehicles are always detected as expected:
https://github.com/autowarefoundation/autoware.universe/assets/18645627/3534d6c3-b6f6-4f78-929c-36e852228047
I have tried to simplify the first lanelet map, but as soon as I remove 1 or 2 lanelet the problem disappears. I guess the issue is related to the lanelet map being just a convoluted loop, and deleting a lanelet breaks the loop.
The 2 lanelet maps:
lanelet2_map_intersection_fail.txt
lanelet2_map_intersection_ok.txt
Expected behavior
Intersection module detects all incoming vehicles
Actual behavior
In the first case, vehicle coming from the top or left are systematically ignored
Steps to reproduce
plannin simulator
Versions
Ubuntu 22.04
The demo is shown with latest main, but the problem also appears on several older versions I have tested.
Possible causes
No response
Additional context
No response

@soblin Sobue-san, are you actively working on this task? If not we can assign it to an Autoware Labs member since it may be failing some scenarios.

@VRichardJP can you visualize the intersection module debug marker ? Also is it possible to upload the lanelet map file ?

@soblin the lanelet file is in the main report description.

I've found out this issue is caused by the loop in the lanelet. I'm fixing the problem.

I've found out this issue is caused by the loop in the lanelet. I'm fixing the problem.

@soblin have you completed this task?


Reload VF driver only when rdma is enabled

To set the GUID to VF, we need to set the admin MAC and reload the VF driver. It will take a long time if users set big 'numVFs'. This PR changes the logic to only reload the VF driver when isRdma is set. So that, users not using ROCE will no longer need to wait for the VF driver reload.

/cc @Mmduh-483

@moshe010 @adrianchiris

@pliurh Will this fix be backported to lower versions? If so, I'd prefer to not changing API. My understanding is we will eventually remove this once kernel fix is in place.

@pliurh Will this fix be backported to lower versions? If so, I'd prefer to not changing API. My understanding is we will eventually remove this once kernel fix is in place.

If we want to fix that 4.6 bug, we need to backport it. Without modifying API, the config daemon cannot know if a VF will be used for ROCE. I don't know when it will be fixed in the kernel.


Add tutorial framework and design secretless

What does this PR do (include background context, if relevant)?
This PR implemented the latest k8s tutorial design for the Secretless site
What ticket does this PR close?
Connected to #666
Where should the reviewer start?
link to start: http://localhost:4000/docs/tutorials/kubernetes/kubernetes-tutorial-base.html
Design to be implemented:
computer screens:

mobile:

More organized version of #674

More organized PR based off of #674

closing b/c merged here: https://github.com/cyberark/secretless-broker/pull/684


Polymer 3.0.2 uses named modules

Description

Live Demo
https://harmonious-pin.glitch.me/
Steps to Reproduce

Expected Results
The browser loads the element
Actual Results
The browser cannot load the element and throws this error: Uncaught TypeError: Failed to resolve module specifier<EMAIL_ADDRESS>Relative references must start with either "/", "./", or "../"..
Browsers Affected

[X] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari 9
[ ] Safari 8
[ ] IE 11

Versions

Polymer: v3.0.2
webcomponents: v2.0.0

This is a duplicate of #5238. Please see our response at https://github.com/Polymer/polymer/issues/5238#issuecomment-390012108 for solutions.


Support for JSON-RPC 1.0

I would prefer using version 2.0 altogether, but some of the clients I'm using are still on 1.0. This should not make a big difference altogether, I think what needs to be done is:

Accepting to receive error: null for a valid request
Validate against the 1.0 schema
Indicate the version to use to the client

Here is an example of a very hacky client, which sort of makes the request 1.0, and pretends the response is 2.0.
import json
from jsonrpcclient.clients.http_client import HTTPClient

class HTTPClient1_0(HTTPClient):

    def validate_response(self, response):
        data = json.loads(response.text)
        if 'error' in data and data['error'] is None:
            del data['error']
        data['jsonrpc'] = '2.0'
        response.text = json.dumps(data)

    def send(self, request, **kwargs):
        del request['jsonrpc']
        return super().send(request, **kwargs)

Probably won't add this, this is an implementation of the 2.0 spec.


Build Javadoc for delomboked code

Currently, the Javadoc does not contain the classes and methods generated by Lombok.
That's not so cool.
We can generate them by adding <sourcepath>target/generated-sources/delombok</sourcepath> to the javadoc plugin's configuration.
However, that will break the build since the generated Javadoc has missing Javadoc tags.
Planned solution:

Fix in Lombok: https://github.com/projectlombok/lombok/issues/1520
Activate Javadoc generation for Lombok classes

We will remove Lombok: #341


Using forward hook for auxiliary loss

Hello!
I was trying to find a way to use the intermediate features of a pretrained ResNet without changing the architecture, then found this github repo by the 2020 RPRR paper torchdistill: A Modular, Configuration-Driven Framework for Knowledge Distillation.
In the paper it mentions:
Taking an advantage of forward hook paradigm in PyTorch [30], torchdistill supports introducing such auxiliary modules without altering the original implementations
of the models.
I was very excited to find this repo since this is exactly what I was looking for!
However, it is difficult for me to actually spot an example code for this.
Can anyone generously highlight where in this repo I can find a code regarding this, or provide an example for me?
Thanks for the help in advance :)

Hi @1ho0jin1
Thank you for your interest in torchdistill!
I think that this notebook would be a perfect example for you.
The above example is independent from generalized pipelines in torchdistill, so you can integrate it to your own code by installing torchdistill (pip install torchdistill). If you'd like to use ResNet with the generalized pipeline e.g., for ImageNet or CIFAR datasets, just let me know.

@yoshitomo-matsubara Thanks for such a quick reply.
This was exactly what I was looking for!
And thank you again for sharing this great work :+1:
I'll close this issue now :)


HAWQ-1536. Fix PXF Json no seek unit test

Fixed PartitionedJsonParserNoSeekTest to not have any expectation in expected response order.

This solution will not be required due to https://github.com/apache/incubator-hawq/pull/1299


Improve colocated cinder-volume (cinder) and nova-compute upgrade order

Colocated principle charms should be upgraded "together", because upgrading one will apt upgrade, also resulting in upgrading the payload for the other principle charms.  COU manages this with colocated cinder and nova-compute by interleaving the upgrade like this:

(unit) cinder-volume apt refresh
(app) cinder-volume charm refresh (original track)
(unit) nova-compute apt refresh (this is redundant)
(app) nova-compute charm refresh (original track)
(app) cinder-volume charm refresh to new release channel
(app) cinder-volume openstack-origin setting change to new ppa
(unit) cinder-volume pause, action managed upgrade, resume
(app) nova-compute charm refresh to new channel
(app) nova-compute opentack-origin setting change to new ppa
(unit) nova-compute pause, action managed upgrade, resume

However this doen't seem to be interleaved enough: between steps 7 and 8, nova-compute charm has the unsupported n+1 payload.
Also note that currently there is a step to verify that the nova-compute being upgraded is empty, right before pausing and upgrading - if this check fails, it will result in the unsupported state for much longer.
Ideally this would be ordered more like:

(unit) cinder-volume apt refresh
(unit) nova-compute apt refresh (this is redundant)
(app) cinder-volume charm refresh (original track)
(app) nova-compute charm refresh (original track)
(app) cinder-volume charm refresh to new release channel
(app) nova-compute charm refresh to new channel
(app) cinder-volume openstack-origin setting change to new ppa
(app) nova-compute opentack-origin setting change to new ppa
(unit) cinder-volume pause
(unit) nova-compute pause
(unit) cinder-volume action managed upgrade
(unit) nova-compute action managed upgrade
(unit) cinder-volume resume
(unit) nova-compute resume

Note that it's also been suggested that we could simply upgrade the colocated cinder-volume (cinder) after upgrading all nova-compute units.  This has not been tested though.

Note that it's also been suggested that we could simply upgrade the colocated cinder-volume (cinder) after upgrading all nova-compute units. This has not been tested though.

I wouldn't go into that direction. Seeing as hypervisors machines that can have one or more principal charms is easier to manage with customers. Asking for migrating all VMs from a machine X and upgrade everything at once will allow to receive VMs after the upgrade. It's not clear to me if you upgrade cinder in a machine X and after a while upgrading nova-compute that the services won't restart again (nova and ovn services) even that the payload is kind of already upgraded. This has a potential for data-plane outage and double migrations that are hard to conciliate with customers


feat(remix-express): remove dependency on express

This PR removes express as a dependency from the "express" handler (using only vanilla http module). This allows the handler to be used by any "express like" router (like polka) or using http.createServer directly! This should improve remix's compatibility with many node based http server frameworks.
Example (using http.createServer & sirv)
import * as http from 'http';
import * as path from 'path';
import sirv from 'sirv';
import { createRequestHandler } from '@remix-run/express';

const BUILD_DIR = path.join(process.cwd(), "build");

const remixHandler = createRequestHandler({ build: require(BUILD_DIR) });

const server = http.createServer(sirv("public", {
	  maxAge: 3600,
	  setHeaders(res, pathname) {
		    if (pathname.startsWith("/build/")) {
		      res.setHeader("Cache-Control", "public, max-age=31536000, immutable");
		    }
	  },
	  onNoMatch: remixHandler
}));

server.listen(process.env.PORT || 3000);

Closes: #

[ ] Docs
[ ] Tests

Testing Strategy:
All tests pass.

Looks like this PR got borked a bit with some unrelated changes related to .node files in https://github.com/remix-run/remix/pull/3234/commits/f724f0aaeaff9bbd30c3d62360409217deb3e20a. Mind fixing those up so we can take a look?

This is the strangest thing but maybe I mixed up my PRs? This is code for a completely unrelated PR. Let me fix this.

@nicksrandall no worries, I've done the same 😅  Usually happens because you try to fix two issues on the same branch and accidentally end up force-pushing to the wrong one.

Closing in favor of #5237


Duty Cycle?

Can you also add a duty cycle feature?

Let me check what you're asking about: You have an external periodic pulse source.  You can use the FreqCountRP2 code to count the number of pulses in a fixed interval, so for instance if you count the number of pulses in a second, you get the pulse frequency.
But you also (or maybe only) want to measure the duty cycle, e.g. the PWM level, of this pulse train?  This is orthogonal to the pulse frequency, but is also an important attribute of the pulse train.
The FreqCountRP2 code is not a great place for such a function.  Here, I'm using the RP2's PWM counters to increment once per input edge, over some measuring interval. To measure duty cycle, you'd want the counters to free-run at the system clock rate (as they usually do), then compare their values at successive rising, falling, and rising edges.  Because of the different clocking of the PWM counter, you can't do this at the same time as the frequency counting (or at least not with the same PWM channel).
As it happens, the RP2 PWM example code includes code to measure duty cycle using the PWM subsystem; see here:
https://github.com/raspberrypi/pico-examples/blob/master/pwm/measure_duty_cycle/measure_duty_cycle.c
That code ought to get you going, although it's not a neatly-packaged library.
Good luck!
DAn.


Update scala to 2.13.7

Closes #293

Codecov Report

Merging #337 (ac368e9) into main (8f0b4f1) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
- Coverage   96.56%   96.47%   -0.10%
==========================================
  Files           9        9
  Lines        1049     1049
  Branches       94       94
==========================================
- Hits         1013     1012       -1
- Misses         36       37       +1

Impacted Files
Coverage Δ

core/shared/src/main/scala/cats/parse/Parser.scala
96.30% <0.00%> (-0.12%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f0b4f1...ac368e9. Read the comment docs.


RESTEASY_3.6-1983: Instances built from org.jboss.resteasy.client.jaxrs.internal.ClientWebTarget must inherit of a detached snaphot of the parent configuration

This pull request is for JIRA https://issues.jboss.org/browse/RESTEASY-1983.
Branch: 3.6
Master PR:  https://github.com/resteasy/Resteasy/pull/1648

Thanks, @NicoNes.


Fix issue with escaping of literals in Date.VerbatimFormatStyle

The previous logic for escaping the CLDR escape character for literal strings in the date pattern string (') when building the Date.FormatString was incorrect, producing invalid date pattern strings, and thus causing the formatting to fail under certain circumstances.
This PR fixes the logic along with the test expectations and adds tests that verify the functionality.

@swift-ci please test


appendBitmap on Android does not resolve images from the Web

The iOS implementation allows the resolution of images from the web however the android implementation does not, should we update the android implementation to support both resolving images from the web?

Hi @dnlowman not sure exactly what you refer to but I think one of the contributors fixed a problem with scaling on iOS, look at this commit. Maybe is also happening on android? is this to do with the appendBitmap command?

Hi @dnlowman, It looks like the iOS implementation creates an image regardless of the url (local or remote)
      NSURL *imageURL = [NSURL URLWithString:urlString];             NSData *imageData = [NSData dataWithContentsOfURL:imageURL];             UIImage *image = [UIImage imageWithData:imageData];
whereas the android implementation explicitly loads an image from the phone's memory:
Uri imageUri =  Uri.parse(uriString);
 Bitmap bitmap = MediaStore.Images.Media.getBitmap(contentResolver, imageUri);

The purpose of this command was always intended to be printing from the phone's memory not remote. One solution is to download your image and then pass it to appendBitmap function so it works on both platforms.
An alternative is maybe investigate if Java android allows you to pass a remote url to create a bitmap. The problem is to decide when is a remote image and when is a local one.


Cleanup

ref #38
Just can't get the idea of these typings and etc stuff. :D Too much for me. Is it really needed to integrate package-to-typings? Isn't enough to just point to the src/mitt.d.ts?

@tunnckoCore I tried looking around to see if there was a way to specify the information from typings.json in the package.json, but I couldn't find anything.  I actually have no idea what typings.json is for, haha.

I actually have no idea what typings.json is for, haha.

ahah, great to hear that! :rofl: So we can stick to that typings.json then? aaaand erm.. seen that there is typings field in packages.. so.. they are probably enough, huh? :D

Library has been rewritten in TS.

Awesome! <3 :)


Calling "destroy" before initialisation will throw exception

See Demo at: http://jsfiddle.net/SunboX/j1fvz4mh/1/
Exception thrown:
TypeError: _[i].slick is undefined at slick.js:2136:16

ofcourse.
You can't kill that which is not alive.


[BUG] [TC-BRBINFO-1.1] EventList has to be updated as per SDK implementation

Reproduction steps

Bring up the DUT with bridge-app.
Pair the DUT using chip-tool through "onnetwork" transport.
Run the command ./chip-tool bridgeddevicebasicinformation read event-list 1 3

Bug prevalence
Whenever I try to read EventList.
GitHub hash of the SDK that was being used
bfa05804ac3c224c9e70921a857ffcac32ccc7f4 - Master
Platform
raspi
Platform Version(s)
RPI4 8GB RAM
Anything else?
As per SDK implementation the mandatory Event ReachableChanged is implemented. But in EventList attribute ReachableChanged is not listed. It shows 0 entries.

A "real" bridge would definitely have to support ReachableChanged, so this is a bug in the emulator bridge-app: it needs to be able to pretend one of the bridged devices became unreachable.

Event list is still provisional for 1.2, removing cert blocker


Bug - CommitMetaData Persistence

The commit 58244b418bba42dc33f186cba432c4dde6cd38e6 introduced bugs:
1.All of the commit meta datas are persisted to the data base, even though only a fraction of them is needed. https://github.com/mauricioaniche/predicting-refactoring-ml/blob/b4288ebd25ca6a69275cfdbc9f16acabd34dd8f0/data-collection/src/main/java/refactoringml/ProcessMetricsCollector.java#L58-L59
This bug can be easily observed in the toyproject 3. We only have 12 relavant commits, but all 20 commits are stored.

In  some cases the CommitMetaData in StableCommits is null.
Database.loadCommitMetaData returns null, in case the CommitMetaData was never persisted
before, e.g. when a class was never refactored.

These bugs can be observed by running the ApacheCommonsCliIntegrationTest.

Fixed.

I wrote a comment in commit cdf9a2c


Added tests for certificate validation failures

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


No broadcasting with Dot layer? + documentation error

I originally asked this on StackOverflow, but I think it's also relevant here, since it involves potentially incorrect documentation (vs. what is actually executed in the code) and a basic feature that seems difficult to implement.
I have two layers with output shapes (None, 2, 50, 5, 3) and (None, 2, 50, 3, 1), and I want to take the dot product of the '3' dimension, and have that broadcasted over the (None, 2, 50) dimensions -- i.e., I want an output of (None, 2, 50, 5, 1). My use case is very simple: I am computing a matrix (5, 3) and a vector (3, 1) at each timestep of a sequence, and I want to take their dot product at each timestep.
Doing this seems to work with K.batch_dot, but not with the Dot layer (even though this is implemented using K.batch_dot).
The documentation for the Dot layer states: "E.g. if applied to two tensors a and b of shape (batch_size, n), the output will be a tensor of shape (batch_size, 1) where each entry i will be the dot product between  a[i] and b[i]." This seems inconsistent with the behaviour I'm observing -- e.g. if I take Dot(2)([a, b]), with a, b = Input((10, 20)), I get a shape (None, 10, 10).
Here is an example showing what I am coming across:
import keras
import keras.backend as K
from keras.layers import Dot, Input

v1 = K.variable(value=np.random.rand(2, 50, 5, 3))
v2 = K.variable(value=np.random.rand(2, 50, 3, 1))
K.batch_dot(v1, v2)  # this works as desired, gives output shape: (2, 50, 5, 1)

x1 = Input((2, 50, 3, 5)) # shape: (None, 2, 50, 3, 5)
x2 = Input((2, 50, 3, 1)) # shape: (None, 2, 50, 3, 1)
Dot(3)([x1, x2]) # output shape is (None, 2, 50, 5, 2, 50, 1)

I've tried other things with no success, e.g. wrapping K.batch_dot in a Lambda layer (which can only take a single input - shouldn't there be an equivalent general-purpose layer taking multiple inputs?) or wrapping the Dot layer in a TimeDistributed Layer (which seems to not work since TimeDistributed can't handle a list as input).

So I figured out a couple of ways to do it:

If you want to learn the parameters of the matrix you are applying to the vector (which is some function of your input), you can simply apply a TimeDistributed Dense layer with linear activations and no bias.

If you want the matrix to be some function of your input (i.e. you want to reshape the output from a layer into a matrix, then apply that to some vector that's a function of your data), you can wrap K.batch_dot in a Lambda layer, where the layer takes as input a single list argument.
i.e. something like: Lambda(lambda x: K.batch_dot(x[0], x[1]))([x1, x2]). The problem with what I was doing before was that I didn't have my inputs as a list, and the Lamdba layer can't take more than 1 input.

Keeping the issue open since there's still the documentation problem -- and also use-case (2) should (IMO) be easier to find.


Select: unsetting the value has no effect

Description
When trying to clear the value of a controlled Select element using undefined, null or ""/empty-string, the element doesn't change the selected-value in the ui. This action should unset the selected-value in ui.
CodeSandbox/Snack link
https://snack.expo.dev/O8jLa_m9k
Steps to reproduce
No response
NativeBase Version
3.4
Platform

[ ] Android
[ ] CRA
[X] Expo
[ ] iOS
[ ] Next

Other Platform
No response
Additional Information
No response

Hi @astriskit, This issue is fixed in version 3.4.7. Let me know if it works for you.

Well i am still facing this issue i am using<EMAIL_ADDRESS>so please fix this issue as soon as possible.

same


Builder with toBuilder=true doesn't work properly with inner classes

hello,
I have and issue with @Builder(toBuilder=true), while compiling got error "@Builder(toBuilder=true) is only supported if you return your own type."
sample code
public class SearchClient {

    private final Service service;

    @Autowired
    public SearchClient(Service service) {
        this.service = service;
    }

    @AllArgsConstructor(access = AccessLevel.PRIVATE)
    public class Requester {

        private final String source;

        public void sendRequest() {
            service.search(source);
        }

    }

    // Hackfix for https://github.com/rzwitserloot/lombok/issues/1302
    @Builder(toBuilder = true)
    private Requester createRequester(String source) {
        return new Requester(source);
    }

}

Yes, that's intentional, as per the error.

Can you please explain what is wrong? What is "your own type" in this case?
Thanks.

Just guessing: toBuilder=true on a method returning Requester adds a method to the class Requester and you must be inside the class for it to work. IMHO it should work for any classes declared inside the same source file, but this may be a non-trivial feature.
IIUIC you're trying to work around the problem with @Builder not working for inner non-static classes by using a factory method, but this fails with the above error message.
I'd suggest to use a static nested class. Usually, all you need is to add the static modifier, add the enclosing class as a member searchClient and fix the errors by prefixing flagged accesses with searchClient..

@Maaartinus I still see no  problem with adding SearchClient#toBuilder to SearchClient class, as SearchClient #builder works fine (just remove "toBuilder = true" ).
Please see that Requester should have SearchClient as a context as it uses SearchClient.service property.
Thanks for your answer, I really want to understand how to make it work or why it is impossible.


Trusted setup cli option for genesis mock subcommand

PR Description
Genesis mock subcommand allows to specify custom network file to generate mock genesis file for interop testing. Similar to main teku command, this subcommand also need --Xtrusted-setup to override trusted setup file when used in conjunction to custom network file (otherwise this subcommand throws error).
Sample usage:
$TEKU_HOME/bin/teku genesis mock --Xtrusted-setup=teku/minimal-trusted-setup.txt --output-file teku-custom.ssz --network teku/config.yaml --validator-count 256 --genesis-time<PHONE_NUMBER>

Fixed Issue(s)

Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

@usmansaleem I cannot replicate the issue. Maybe there is something in the network config that triggers it. Can you share the file you are using?

@tbenr https://github.com/usmansaleem/beku/blob/main/teku/config.yaml would cause the issue.

@usmansaleem we are going to a different direction: ignoring kzg config when it isn't needed. We recently merged a PR about this but there was a bug. I added a fix via #7550

@usmansaleem we are going to a different direction: ignoring kzg config when it isn't needed. We recently merged a PR about this but there was a bug. I added a fix via #7550

Makes sense, I'll close my PR.


New spec for Feat/refactor nonce

This is a new spec we prepared for the feat/refactor_nonce branch. It is not in the final form, but it should have a relatively clear presentation of the major ideas in the design. We hope to use this doc to help developers get the ideas quickly and start to contribute.
For the first reading, you may skip the italics part annotated as Notes or Discussions, since these are just additional memo. The constraints part are not finished yet and there are other TODO parts in the doc that we will update later. If you are already familiar with the MPT table and the SMTTrace stuff in zktrie, you can also start reading from the section "MPT proofs as witnesses for the feat/refactor branch"

corresponding HackMD link here https://hackmd.io/@dieGzUCgSGmRZFQ7SDxXCA/H1BGptdfh


Bluetooth: host: Unable to pair when privacy feature is disabled by application

Describe the bug
The local on-air address will not be properly initialized when CONFIG_BT_PRIVACY is enabled but the privacy of the device has been disabled. This can happen in two ways:

The controller was not instructed to use RPAs because BT_LE_ADV_OPT_USE_IDENTITY was used.
An all zeroes local IRK has been set for the identity being used.

This happens because the local RPA will be set to all zeroes by the controller in this case:
This is only valid when the Own_Address_Type (...) is set to 0x02 or
0x03, and the Controller generated a resolvable private address for the
local device using a non-zero local IRK.
To Reproduce
Steps to reproduce the behavior:
Using the shell:
Shell 1#:
bt init
bt advertise on identity

Shell 2#
bt init
bt connect <identity of shell #1>
bt security 2

Expected behavior
When controller reports an all-zeroes local RPA in the connection complete event the host shall
assume that the identity address was used instead.
Impact
Unable to perform pairing procedure since the address is input to the SMP pairing functions.
Screenshots or console output
Shell 1#
uart:~$ bt advertise on identity
Advertising started
Connected: 58:44:1c:d4:ca:a7 (random)
Security failed: 58:44:1c:d4:ca:a7 (random) level 1 reason 1
LE conn param updated: int 0x0028 lat 0 to 42
uart:~$ bt info
Type: LE, Role: slave, Id: 0
Remote address: 58:44:1c:d4:ca:a7 (random) (resolvable)
Local address: f1:c1:d9:aa:49:e2 (random) (identity)
Remote on-air address: 58:44:1c:d4:ca:a7 (random) (resolvable)
Local on-air address: 00:00:00:00:00:00 (random) (non-resolvable)
Interval: 0x0028 (50 ms)
Latency: 0x0000 (0 ms)
Supervision timeout: 0x002a (420 ms)

Shell 2#
uart:~$ bt connect f1:c1:d9:aa:49:e2 (random)
Connection pending
Connected: f1:c1:d9:aa:49:e2 (random)
Remote LMP version unknown (0x0b) subversion 0xfffe manufacturer 0x0059
LE Features: 0x0000000000004925
uart:~$ bt security 2
Security failed: f1:c1:d9:aa:49:e2 (random) level 1 reason 1
[00:00:50.567,749] <err> bt_smp: reason 0xb

Environment (please complete the following information):
Version 2.2.0-rc3

Reduced the priority since @joerchan reported that this hasn't been reproduced with the upstream tree (the upstream controller, in particular)

Reproduced with upstream, but the medium priority was wrong to begin with. This problem has been there since privacy feature was added and can easily be prevented by simply not using the advertise Identity option.


Diagnostic unit tests: SA1008 (OpeningParenthesisMustBeSpacedCorrectly)

Implement unit tests for #14.

Make sure to consider #683 during testing of this analyzer.

Make sure to consider #876 during testing of this analyzer.

Grabbing this


Gitk doesn`t work

When I try to run Gitk from Command Palette, it doesn`t start.
In console I get this:
Exception in thread Thread-15:
Traceback (most recent call last):
  File "./threading.py", line 901, in _bootstrap_inner
  File "./threading.py", line 858, in run
  File "SublimeGit/sgit/gitk.py", line 31, in async_inner
TypeError: 'NoneType' object is not callable

Can somebody helps me?

Fixed in 1.0.34 which was just released.

Thank! That`s work!


Fix i18n translation change

Fixes https://github.com/codecombat/codecombat/compare/0b1ce82e9fb2...1a22b3e86ae0

@AndrewJakubowicz Yes it is, through a resolved conflict in a PR I merged in that had added these entries back in Korean.


[KYUUBI #3426] Drop temp view should be skipped permission check

Why are the changes needed?

Fix https://github.com/apache/incubator-kyuubi/issues/3426
This pr aims to skip permission check for drop temp view.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #3427 (1beab8d) into master (f618062) will decrease coverage by 51.42%.
The diff coverage is n/a.

:exclamation: Current head 1beab8d differs from pull request most recent head 9ecd708. Consider uploading reports for the commit 9ecd708 to get more accurate results

@@             Coverage Diff              @@
##             master   #3427       +/-   ##
============================================
- Coverage     51.42%       0   -51.43%
============================================
  Files           481       0      -481
  Lines         26699       0    -26699
  Branches       3731       0     -3731
============================================
- Hits          13729       0    -13729
+ Misses        11631       0    -11631
+ Partials       1339       0     -1339

Impacted Files
Coverage Δ

.../kyuubi/plugin/spark/authz/PrivilegesBuilder.scala

...server/mysql/constant/MySQLCommandPacketType.scala

...pache/kyuubi/server/mysql/MySQLDateTimeUtils.scala

...ubi/spark/connector/tpch/TPCHStatisticsUtils.scala

...a/org/apache/kyuubi/operation/OperationState.scala

.../org/apache/kyuubi/events/KyuubiSessionEvent.scala

...rg/apache/kyuubi/jdbc/hive/auth/HttpAuthUtils.java

.../kyuubi/jdbc/hive/adapter/SQLDatabaseMetaData.java

.../main/scala/org/apache/kyuubi/util/JdbcUtils.scala

...server/mysql/authentication/MySQLAuthPackets.scala

... and 471 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

we have CI jobs for different spark versions, right?
LGTM, if tests are green

thanks, merged to master


Alternate English Translation

Copy Edits for English version of error page

After merging this commit, it might be a good idea to re-screen capture the English language version of the error page and update the README.

👍  Thanks for your contribution.

Thanks for doing all the hard work!


Updated API Gateway gotchas

Added note about lack of binary data support.

Oh very cool, they seem to be making a lot of changes at the moment. I'll add it as a tip instead.

👍 Yep, looks good!


ockam status should provide more user friendly information when a user is not enrolled

Current behavior
When a user is not enrolled (they have not run ockam enroll yet), and they run ockam status they currently get an error message of the empty local state. This information is not very useful. Here's a screenshot of what this looks like.

To install Ockam command from a prebuilt binary or from source, please take a look at this README.md.

Desired behavior
If a user is not enrolled, and they run ockam status, they should see a helpful message such as “No identities are found. Consider running ockam enroll to enroll an identity.” instead of just an error message.

We love helping new contributors! ❤

If you have questions or need help as you work on your Ockam contribution, please join us on the contributors Discord channel.

Take a look at our contributor guide before making a PR, to get information on writing commit messages, branch names, code of conduct, CLA, our PR workflow.

If you're looking for other issues to contribute to, checkout these labels good first issue or help wanted.

@rjtch Excellent, I just assigned it to you! 👍🏽


Fix broken ci.yml

This was obviously broken and I'm not going to waste people's time on reviewing it. Comments always welcome, but I'm merging now.


Update initial deposit

Have the button in the same style as the "Crowdfund" button. Have it preselected. Don't show the number field if "Self Fund" is selected.

It was an issue with your locale using a comma there. Fixed.


Removing microk8s snap doesn't kill calico-node

microk8s version: microk8s (1.22/stable) v1.22.4
Steps to reproduce the bug:
sudo snap install microk8s --classic
microk8s kubectl get pod -A --watch

Then, wait until calico-node is ready.
Then, run sudo snap remove microk8s. You will find calico-node still run by ps aux|grep calico-node.
myh@alston-ubuntu:~$ ps aux|grep calico-node
root     1212222  5.1  0.1 1953788 58432 ?       Sl   14:07   0:14 calico-node -felix

It continues generating iptables-legacy rules (even if do flush rules and delete chains) and breaks cilium L7 policy functions (see https://github.com/cilium/cilium/issues/18350#issuecomment-1008565309).
A workaround is killing calico-node manually.

This issue is very annoying...


Realtime Graph - Wireless Tab

It seems that the build LuCI Master (git-18.061.77516-2913111) in Real Time Graphs - Wireless doesn't work. The Traffic view is performing very fine.

What is the actual problem? I can’t infer any information from the screenshot you provided.

I don’t see an real time data. In my screenshot I tried to show a iper3 output which was made seconds ago and the graph from the lucy webinterface. Affecting the described tab only

Sorry I still don't understand. The graph shows data?

Sure it shows data. But not the actual rate. It shows a static Average of 39Mbit, despite the rate should be 253Mbit. See this in my screenshot. The black window is a terminal, iperfing to my lede router. As i sayed previously, the traffic tab wlan0 is correct on this. Sorry to not be more clear

The graph displays phy rate, not throughput. It also shows an aggregated average, so if multiple stations are connected it will render the average phy rate of all stations. The chart can only be meaningfully correlated to any kind of iperf results if the router is in client mode or if only one single station is connected.

In short, I don't get the point of this view. Since it shows Mbit I can't  calculate a senseful messure. I did not want to bother you. Thanks for taking care.


BUILD-159: add projected share resource csi driver operator to the list managed by the CSO

make update etc. is behaving weird for me today ... I think my upgrading controller-gen for v0.5 for tekton has introduced formatting differences.
initially submitting with WIP and with any make update changes to see exactly how the verify job fails, and then see if I can split the difference
or I may have to maintain 2 versions of controller-gen

OK everything is green ... interesting.  Moving forward.
/assign @jsafrane
/assign @adambkaplan
PTAL ... my early testing in trying to construct a CSO managed operator for the projected shared resource CSI driver is that I need these updates vendored into openshift/apiserver in order to mirror the build and run locally instructions articulated at https://github.com/openshift/gcp-pd-csi-driver-operator#quick-start
without this, even with CVO and CSO disabled, I get
The ClusterCSIDriver "csi-driver-projected-resource.openshift.io" is invalid: metadata.name: Unsupported valucsi.projected.shared.resources.openshift.ioe: "csi.projected.shared.resources.openshift.io": supported values: "ebs.csi.aws.com", "disk.csi.azure.com", "pd.csi.storage.gke.io", "cinder.csi.openstack.org", "csi.vsphere.vmware.com", "manila.csi.openstack.org", "csi.ovirt.org", "csi.kubevirt.io"

/assign @bparees
need an OWNERS approve to sign off on this next step in installing via the cluster storage operator the projected resource csi driver we are going to use to mount entitlement secrets in build without having to copy the secret to the same namespace as the build.

/approve

your suggested commit has been pulled in @adambkaplan and commits have been squashed

Just to be sure, is `csi.shared-resources.openshift.io is really name of the driver? The name must match CSIDriver instance name and also driver name in StorageClasses and PVs and it's basically impossible to change it later.

Just to be sure, is csi.shared-resources.openshift.io really name of the driver? The name must match CSIDriver instance name and also driver name in StorageClasses and PVs and it's basically impossible to change it later.

Thanks for the pointer @jsafrane
Yep I'll need to update our new shared resources CSO operator repo and the existing csi driver repo to make sure things line up with the name @adambkaplan has directed me to before we connect the dots and install via the CSO.

/lgtm
From storage perspective.


Implement a cache with redis

Include a model version number so that we can do intelligent cache invalidation

This was done a long time ago


fix(ios): fix openSettings on iOS 10.0

This isn't completely reliable yet – there seems to be a bug in iOS 10: http://stackoverflow.com/questions/39792745/ios-10-open-settings-crash

@bitjson any reason not to merge?

I've not been able to confirm this works – last time I tried, the new API still wasn't stable, and causes the app to crash.
I have not yet tried it on the iOS 10.2 Public Beta 3 – if Apple fixes the crash in this version, I can merge for when 10.2 is released.

Thanks for the update

This is now working in my testing, looks like Apple fixed the issue in 10.2.1 🚀


Implement Catapult on the Wall.

As noted (at least as far as I could figure out), there's not really a clean way to include kneeling the attached character as part of the cost of using the attachment action.  ability.costs needs another / updated kneel method to allow for this.  Certainly something I could do / we might consider, as I'm sure more costs like this are coming, but as I'm probably the least familiar with the code and gameflow, I figured I would just do the quick and dirty implementation.

👍


Styling File Not Being Applied

I have provided a fix.  The styling file would change the session variables, but there were no triggers to update the actual network.

Great, thanks!
From: mossy426 @.>
Sent: Thursday, April 15, 2021 12:45 PM
To: CDCgov/MicrobeTrace @.>
Cc: Subscribed @.***>
Subject: [CDCgov/MicrobeTrace] Styling File Not Being Applied (#355)
I have provided a fix. The styling file would change the session variables, but there were no triggers to update the actual network.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/CDCgov/MicrobeTrace/issues/355, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHMTDBORTPFA5QGYTEBGQRTTI4J2TANCNFSM4273SMSQ.

Moved back to in progress after QA review found node color was not being applied correctly.

It seems to apply or not apply correctly depending on the data set.  Investigating further to determine the cause.

In most prior experiences, when we have a data-specific issue, it is (1) a weirdly formatted value or (2) a namespace collision issue.
So if the names of suspect dataset are generic and overlap with our namespace...we might want to start there.

Got it, thanks for the tip!

Still not working correctly with my OH-KY data. Used same input files but styles not applied and networks differ. WIll have to do a screen share to show the differences.

Can you describe what isn't being applied or is it all styles?

None of the styles (node color, node shape) is being applied. But the network is also different.

@billswitzer2 The network structure is different (node/edges)? or the network layout is different?

Both. Let's review with some screen time tomorrow.

Sounds good.   Let's check it out in the standup.

Had a meeting with Bill going over the issue.  It works as expected, but a couple items to note:

The styling will only apply properly if the new files are launched with the same typing as the original.  For example, if dataset X was launched as a node list, styling will not work if dataset X is launched as a linked list for another session.
@ikb6 We should document this in the instructions where applying styling is outlined as per Bill/Ells.

Moving to done as issue has been resolved.


MNE Installation from source

Hi,
I followed the instructions described in the MNE website and it worked fine, I was able to use try some examples as well.
Then I tried to install MNE from the source code but I was not able to find any instructions on how to achieve this in README.rst or the contributing section of the website, can you help with that?
By the way, I'm using Arch Linux.

yep! it is true that we might need to update that an make it more clear. But I'm not where should it be placed. Anyway, usually when I need a clean installation what I do is a variant of this lines in appveyor.yml:
https://github.com/mne-tools/mne-python/blob/86d3f20e0e1bdf57089517037961348cd0a5f260/appveyor.yml#L14-L16
what I do is:
$ git clone git@github.com:mne-tools/mne-python.git $MY_PATH_TO_MNE
$ conda create --name mne_XXX python=X.X
$ conda activate mne_XXX
$ conda install mne
$ conda uninstall mne
$ cd $MY_PATH_TO_MNE
$ pip install -e .


Fix spelling mistake

Please fix the spelling mistake
https://github.com/cheminfo/common-spectrum/blob/acb4bccb45443df00dce3388a8b3b4b1ad59d355/src/reactPlot/getReactPlotJSON.js#L29-L30
It should be dimensions

This needs to be updated as well in react-plot


Design/Cohort files run into errors because xcpengine-docker binds them as read-only

The python wrapper script cannot handle custom cohort and design files because it is binding them to the docker container as read-only (ro). This results in critical errors, especially for design file. Because design variable is not set to the docker design file path (/design/design.dsn), the localiser chokes, along with all the modules.
Error message
· [D][/design/design.dsn]
sed: cannot rename /design/sedYzmc5D: Device or resource busy
· [C][/cohort/cohort.csv]
Error in file(file, ifelse(append, "a", "w")) :
  cannot open the connection
Calls: write.table -> file
In addition: Warning message:
In file(file, ifelse(append, "a", "w")) :
  cannot open file '/cohort/cohort.csv': Read-only file system
Execution halted

/xcpEngine/core/parseArgsLocaliser: line 113: /xcpEngine/designs/fc-36p_despike-PNC-power264.dsn: No such file or directory

Runtime Information
xcpengine-docker

can you  let us know  how you  run it, I mean code
you can try  singularity as well

I just tested xcpengine-docker on tutorial dataset, as in the docs.
On Fri, Dec 6, 2019, 12:51 AM Azeez Adebimpe<EMAIL_ADDRESS>wrote:

can you let us know how you run it, I mean code
you can try singularity as well
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PennBBL/xcpEngine/issues/268?email_source=notifications&email_token=ABZYIGC2J5FJWAD4NJNVPYTQXEPR7A5CNFSM4JVX4PUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGBFK7Y#issuecomment-562189695,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABZYIGFFP4ZUUQEWUW7YXUDQXEPR7ANCNFSM4JVX4PUA
.

Specifying custom design file also causes this problem, and this actually breaks down the whole pipeline.

Not sure why this was closed. The python wrapper for docker is unusable with custom design files. The fix can be as simple as removing read-only tags for binds.

Not sure why this was closed. The python wrapper for docker is unusable with custom design files. The fix can be as simple as removing read-only tags for binds. The more robust solution would be working with a temporary copy of cohort/design files.

Also had this issue with the wrapper :(

can you post the command

@a3sha2 ,
Here is my command:
xcpengine-docker
-d /Users/neurouser1/Documents/ADHD_200/xcpEngine/designs/fc-36p.dsn
-i /Users/neurouser1/Documents/ADHD_200/xcpEngine/xcpOutput
-c /Users/neurouser1/Documents/ADHD_200/xcpEngine/cohorts/WashU_cohort.csv
-o /Users/neurouser1/Documents/ADHD_200/xcpEngine/xcpOutput/WashU
-r /Users/neurouser1/Documents/ADHD_200/fmriprep_output/WashU/fmriprep \
Not a huge deal as you can just run via calling docker explicitly but good to note the issue.


0.1.11?

I think it would make sense to release 0.1.11 (yes, I want to have liftIO1 :P).

The next version will have API breaking changes so it will  be 0.2.


[MAUI] Package Sharpnado.Tabs.Maui 3.0.0 is not compatible with net6.0

I'm currently migrating my Xamarin.Forms app to Maui.
The architecture of my app looks like this: ios/android app -> UI library -> Core library
ios/android app projects hold the platform specific code required to start the app
UI library holds the UI code (pages, view)
Core libreary holds the business logic code (view models, services, models...)
In the Xamarin app, both UI and Core libraries are netstandard projects.
The UI library references the Sharpnado.Tabs package (since it suports the netstandard TFM).
In my Maui app, both UI and Core libraries are net6.0 projects.
However I find it impossible to reference the Sharpnado.Tabs.Maui package in the UI library.
It expects a net6.0-android / net6.0-ios TFM.
But there is no reason for that, since this is a cross-platform library, with no specific code to compile.
Error	NU1202
Package Sharpnado.Tabs.Maui 3.0.0 is not compatible with net6.0 (.NETCoreApp,Version=v6.0).
Package Sharpnado.Tabs.Maui 3.0.0 supports:
  - net6.0-android31.0 (.NETCoreApp,Version=v6.0)
  - net6.0-ios15.4 (.NETCoreApp,Version=v6.0)

Could you please make sure this package can be installed in a net6.0 project?
Thanks

Mmmh I see. I had to add a platform agnostic target.

any workarounds or updates?

version 3.0.1 includes a .net6 targhet


Setup fails on chromebook acer c720

Please paste the output of the following command here: sudo edit-chroot -all

name: xenial
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/xenial...
crouton: version 1-20200724165050~master:08dac970
release: xenial
architecture: amd64
targets: xfce
host: version 7520.49.0 (Official Build) beta-channel peppy
kernel: Linux localhost 3.8.11 #1 SMP Wed Nov 18 21:12:00 PST 2015 x86_64 x86_64 x86_64 GNU/Linux
freon: yes
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...

Please describe your issue:
i try to install on Acer C720 and doesnt matter which OS i try to install i always get the following error after a while of installing.
i tried xenial and buster multiple times
The following packages were automatically installed and are no longer required:
  libasound2-dev:i386 libc6-dev:i386 libglib2.0-0 libspeex-dev:i386 libspeex1:i386 libspeexdsp-dev:i386 linux-libc-dev:i386 pkg-config
Use 'apt autoremove' to remove them.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
sed: can't read common/cras_shm.c: No such file or directory
Failed to complete chroot setup.
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...

Try an updated release: sudo crouton -t xfce -r sid


limit elasticseach heap size to 750mb, document change

Limits Elasticsearch max heap size to 750MB ensuring the container won't crash under load under the default Docker for Mac or Docker for Windows or any Linux system limited to 2GB or less of memory.
Also documents the change via the readme as well as how to override the change.
This would close issue #6

This looks good. Thanks!


Revert to redirection by default; clean up error handling

This is overridden by custom implementations; revert to the simpler behavior, which works with latest versions of horse-react.
:eyeglasses: @dwick / @curioussavage

can you link the custom implementation?
:nail_care:


Improve article cond-mat/0309206

Exact location of issue
Figures are silently missing from the end of the backmatter
https://ar5iv.labs.arxiv.org/html/cond-mat/0309206#Sx1.F1
Problem details
As an admin enhancement: There should at least be a Warning message emitted when a figure goes missing in latexml conversion - currently the log is too silent.
Separately, we should get the figures to appear.

The figures are based on .ps files, example:
\begin{figure*}
\epsfysize=20cm
\epsffile{fig9.ps}
\caption{ Variation of applied load $\sigma$ vs. average
uniaxial strain $\langle \epsilon_{xx} \rangle$ as a function of
(increasing) temperature. From top to bottom,
$A_2=1, 2, 3$ GPa, respectively. Red curves correspond to a polycrystal and blue
curves to a single crystal.}
\end{figure*}

Currently the epsfig.sty.ltxml binding silently ignores them, which needs to get enhanced:
https://github.com/brucemiller/LaTeXML/blob/6ee12be9311b90280fdd89f5bdb4fa13ca118785/lib/LaTeXML/Package/epsfig.sty.ltxml#L68-L69


Cannot build simple program with empty main

I recently built SDC from the current master (https://github.com/SDC-Developers/SDC/tree/95d690c349bbda539666c18db6aa59b42b91c3f7) using DMD 2.072.2 and LLVM 3.9.1.  On trying to compile a simple no-op file:
void main ()
{
}

... I got a long stacktrace which suggests that something is failing during parsing:
$ sdc -c noop.d
d.exception.CompileException@src/d/exception.d(15): expected 'Identifier', got 'Ulong'.
----------------
src/d/parser/base.d:21 void d.parser.base.match(ref d.lexer.TokenRange, d.lexer.TokenType) [0xacfaba]
src/d/parser/declaration.d:729 d.ast.declaration.Declaration d.parser.declaration.parseAlias(ref d.lexer.TokenRange, d.ast.declaration.StorageClass) [0xad765c]
src/d/parser/declaration.d:323 d.ast.declaration.Declaration d.parser.declaration.parseDeclaration(ref d.lexer.TokenRange) [0xadcc55]
src/d/parser/declaration.d:32 d.ast.declaration.Declaration[] d.parser.declaration.parseAggregate!(true).parseAggregate(ref d.lexer.TokenRange) [0xadde81]
src/d/parser/conditional.d:143 d.ast.declaration.Declaration[] d.parser.conditional.parseItems!(d.ast.declaration.Declaration).parseItems(ref d.lexer.TokenRange) [0xae0a36]
src/d/parser/conditional.d:68 d.ast.declaration.Declaration d.parser.conditional.parseconditionalBlock!(true, d.ast.declaration.Declaration).parseconditionalBlock(ref d.lexer.TokenRange) [0xae0cdc]
src/d/parser/conditional.d:16 d.ast.declaration.Declaration d.parser.conditional.parseVersion!(d.ast.declaration.Declaration).parseVersion(ref d.lexer.TokenRange) [0xae0bb4]
src/d/parser/declaration.d:71 d.ast.declaration.Declaration d.parser.declaration.parseDeclaration(ref d.lexer.TokenRange) [0xadc106]
src/d/parser/dmodule.d:40 d.ast.declaration.Module d.parser.dmodule.parseModule(ref d.lexer.TokenRange) [0xade650]
src/d/semantic/dmodule.d:97 d.ast.declaration.Module d.semantic.dmodule.ModuleVisitor.parse(immutable(char)[], immutable(char)[]) [0xb2797f]
src/d/semantic/dmodule.d:51 _D1d8semantic7dmodule13ModuleVisitor12importModuleMFAS1d7context4name4NameZ9__lambda3MFZC1d2ir6symbol6Module [0xb2747c]
src/d/semantic/dmodule.d:44 _D1d8semantic7dmodule13ModuleVisitor12importModuleMFAS1d7context4name4NameZ12__dgliteral4MFNaNiNfZC1d2ir6symbol6Module [0xb2735e]
/home/username/code/snap/sdc.snap/stage/bin/../import/object.d:2108 pure @safe inout(d.ir.symbol.Module) object.get!(immutable(char)[], d.ir.symbol.Module).get(inout(d.ir.symbol.Module[immutable(char)[]]), immutable(char)[], lazy inout(d.ir.symbol.Module)) [0xa5e568]
src/d/semantic/dmodule.d:58 d.ir.symbol.Module d.semantic.dmodule.ModuleVisitor.importModule(d.context.name.Name[]) [0xb2733b]
src/d/semantic/semantic.d:109 d.ir.symbol.Module d.semantic.semantic.SemanticPass.importModule(d.context.name.Name[]) [0xb35051]
src/d/semantic/semantic.d:75 d.semantic.semantic.SemanticPass d.semantic.semantic.SemanticPass.__ctor(d.context.context.Context, d.semantic.evaluator.Evaluator delegate(d.semantic.scheduler.Scheduler, d.object.ObjectReference), d.semantic.datalayout.DataLayout delegate(d.object.ObjectReference)) [0xb34cf5]
src/sdc/sdc.d:62 sdc.sdc.SDC sdc.sdc.SDC.__ctor(immutable(char)[], sdc.util.json.JSON, d.context.config.Config) [0x9df606]
src/driver/sdc.d:79 _Dmain [0x9c72b8]
??:? _D2rt6dmain211_d_run_mainUiPPaPUAAaZiZ6runAllMFZ9__lambda1MFZv [0xb719e6]
??:? void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).tryExec(scope void delegate()) [0xb71930]
??:? void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).runAll() [0xb719a2]
??:? void rt.dmain2._d_run_main(int, char**, extern (C) int function(char[][])*).tryExec(scope void delegate()) [0xb71930]
??:? _d_run_main [0xb718a1]
??:? main [0x9dcea1]
??:? __libc_start_main [0xcaf7e82f]

Note, I built SDC using a snap package definition, where DMD 2.072.2 and LLVM 3.9.1 are built first and then used to build SDC itself, but I doubt that will have had an influence given the nature of the error message.  I can share that package definition if you think it would be relevant/useful.

"/home/username/code/snap/sdc.snap/stage/bin/../import/object.d:2108..."
I don't use SDC, so take anything I say with a cup of salt, but whatever it is you're doing, it looks like it is feeding your SDC installation with import paths for a non–SDC-provided druntime (the SDC-provided version of object.d has less than a 100 lines and the error notice you posted mentions line 2108).
SDC is itself described as "particularly stupid" at the moment; it can't handle the full D language, and that includes not being able to handle the standard druntime's object.d.

Unfortunately, it seems that CompileException is not made to actually output any of the info it has on the location of the error by default, but looking through the code, it looks like SDC tries to catch the CompileException at all the points where such an exception might escape to the user,  and then manually extracts and prints that most-useful bit of diagnostic information:
	} catch(CompileException e) {
		import util.terminal;
		outputCaretDiagnostics(e.getFullLocation(c.context), e.msg);

		// Rethrow in debug, so we have the stack trace.
		debug {
			throw e;
		} else {
			return 1;
		}
	}

Are you sure there is no other output describing where SDC was expecting an identifier but got a ulong instead? And if not, what the does the lack of that information imply?  It doesn't include the compiler's constructor, and apparently (from your stack trace) much of the parsing actually happens right inside the compiler's constructor o_O. Something about that design should be changed for SDC, but for your purposes, it seems that altering the try block within your local copy of the src/driver/sdc.d file to include the SDC constructor a few lines above should allow you get some more useful info on what's actually happening.

Make sure your sdc.conf file does looks right. Worst case scenario delete it and let it regenerate. It looks like it isn't looking for the right object.d .

Make sure your sdc.conf file does looks right. Worst case scenario delete it and let it regenerate. It looks like it isn't looking for the right object.d .

I presume you mean this line?
/home/username/code/snap/sdc.snap/stage/bin/../import/object.d:2108 pure @safe inout(d.ir.symbol.Module) object.get!(immutable(char)[], d.ir.symbol.Module).get(inout(d.ir.symbol.Module[immutable(char)[]]), immutable(char)[], lazy inout(d.ir.symbol.Module)) [0xa5e568]

I think this is simply an artefact of how the compiler was built: that was the location of the Phobos object.d of the DMD used to build SDC.
I'll look into the other points raised further in the coming week.

I presume that you are using DMD's object.d instead of SDC's.

I presume that you are using DMD's object.d instead of SDC's.

Ah, I see what you mean.  So the *.d files from the sdlib directory are expected to be included in the install?  Any particular constraints on their location?

Just to confirm, it was the choice of object.d: a mistake in how I was setting up the snap package definition.  All working now; thanks for the assistance!
I'll share the package definition later in the week if you're interested: it might be useful for some forms of CI (or just for a simple way for people to build and install something working from master).


Add #ifdef GO_VIRT definitions into main force field file

Currently we have a complicated route to including the particle and nonbonded definitions into martini_v3.0.0.itp when the go model is used. Given these are flexibly included, and the go model is now integrated into martinize, I don't think there's any particular reason that we shouldn't just write these inclusions in directly for all users?

@ricalessandri @danielpastor97 any thoughts on this?

Personally, I don't see any cons to including them (if this makes other things easier). I think for a while during the development of M3 the martini_v3.0.0.itp file did contain those #ifdef GO lines and as I recall they aren't many - meaning that this won't increase the file size. Don't see any other cons. Few people open this file anyway.
But perhaps @fgrunewald and @paulocts have more thoughts/opinions?

After thinking on this for a while, I'm against including them in the martini_v3.0.0.itp. The issue is that one would have to copy this file every time to a new folder when using a Go model. Sure it works for a tutorial setup showing how easy it is, but if you do more than one protein it quickly adds and the itp file is rather large already.
@csbrasnett @pckroon Coming to think of it, I'd suggest we make martinize2 write a usuable topology file. The only thing one would have to do is define where the martini setup lives on the computer. One way would be pip install martini, so having the files installable and expose paths and so on. The other option would be having the user provide an eviroment variable or CLI argument.

If we make martinize2 make a usable file like you say, won't that break once someone uses >1 Go model like you say anyway? Unless we add a bunch of flags to additively write to existing .tops?

Yeah that’s what I was thinking/wondering, I realised I don’t actually have
any idea. There must be conflicting definitions in the atom types that tbh
I have no idea how people get around atm
On Fri, 25 Oct 2024 at 09:59, Dr. Fabian Grunewald @.***>
wrote:

you mean for the case that there is more than one Go model protein? How
does that even work at the moment? Isn't there some overlap between the VS
definitions?
—
Reply to this email directly, view it on GitHub
https://github.com/Martini-Force-Field-Initiative/Martini-Force-Field-Initiative.github.io/issues/41#issuecomment-2437142658,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AILSZXTP2FLLLEH5B7LJIPLZ5H27FAVCNFSM6AAAAABQGA3PQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZXGE2DENRVHA
.

Maybe we should take martini_v3.0.0.itp as a template, add in the interactions/particles needed inline (rather than #include), and dump that system specific itp next to the topol.top? That would fix the multiple protein part (since we can just generate system unique particle names (molname+'govs'+idx, uuid, ...).
As for where to get martini_v3.0.0.itp, it could be an option to add it to the vermouth-martinize data files. Way back when I suggested to create a repo for the force field files, but this got shot down as being to complicated, maybe times changed?

There's the martini-forcefields repo that does this now, but I don't know how many people actually use it as a reference over the website etc.
I like the idea of doing the filtering in martinize (as opposed to grompp I guess?) but I think that'll get tricky the moment people start combining systems/adding different molecules etc?
To me there's some kind of streamlined process where you can:

specify an existing topology file (although -p is already taken...) read that in to some object,
work out if you have extra particle definitions arising from other proteins with Go models,
do the usual martinize stuff on the protein that you want to martinize at this stage
write out the new topology file to adapt the system, along with the new extra particle definitions.

I think in terms of actionable things before that can happen, the first thing we could do would be let the user define the molname on input? atm, everything is molecule_{0..n}, and the virtual sites we get from go bonds are molecule_{0..n}_{0..m}. This means someone has a system with multiple Go models, the atomtypes get redefined (but with the same name) for each molecule, which I think will cause problems. If we sort this we should also fix https://github.com/marrink-lab/vermouth-martinize/issues/585 at the same time

made a PR on this subject here, any opinions welcome :smile_cat:


Dataloader instrumentation imports types from the underlying package

instrumentation.d.ts of the build assets import types from dataloader:
import type [...] from 'dataloader';

Which means that the compilation fails, if the user has not installed the dataloader package - happens with metapackage users for example.
This needs to be fixed by removing all references to any of the dataloader types from the public APIs.

@henrinormak, would you like to take it yourself or shall I?

Will be fixed by #1221, thanks for spotting and taking care of this! 🙇


reset/restore transformation matrix

Reset the transformation matrix before setting the plusLayer/buttonImageView frame and restore afterwards.
As mentioned in Apple's docs: "Do not set the frame if the transform property applies a rotation transform that is not a multiple of 90 degrees."
Fixes #252

Thank you


fix:  tensormmul_bp shape mismach failure and wrong rank assumptions

What changes were proposed in this pull request?
fix: tensormmul_bp shape mismatch failure and wrong rank assumptions
How was this patch tested?
unit tests
Quick checklist
The following checklist helps ensure your PR is complete:

[x] Eclipse Contributor Agreement signed, and signed commits - see IP Requirements page for details
[x] Reviewed the Contributing Guidelines and followed the steps within.
[x] Created tests for any significant new code additions.
[x] Relevant tests for your changes are passing.

I added few test cases based on users' gist.
it turns out in tensormmul_bp there was a false assumption (commented as // rank always have to be divided by 2) of ranks being equal. I removed that constraint.

#9048
after confirmation of the issue being solved libnd4j tensolmmul_bp could be called on the java side as well


Fix ItemListLayouts scrolling to top involuntarely

The culprit was wrapper components using type parameters that created new "dynamic components" using withInjectables on every render making the components indistinguishable for React. This causes the dynamic components to re-mount instead of re-render causing all the trouble.
Closes #4796

Worth noting: this fix closer to the now-realized root problem would have fixed most (but not all) bugs already attended in #4792. Good.


Bastion's many issues

There's legit probably 3 NPCs (that I found walking around so far)
Has to be more lit up, or at least more reinforced
NPCs should actually talk about the lore and the issues there, since we are in freaking hell pretty much
Why is a dude breeding Bouffalant in a place where there's 1 patch of grass?
No mobs (bug in landlord, really needs addressing though)

I think most of this was dealt with by our super sexy owner. Don't think you'd know them. Reopen if you find more issues.

Kind of you to call me super sexy Voh, but you’ll find I fixed the majority of these issues.


Sanitize README.md

No space after ':' creates problem with Boldness of 'tasklists' and description in Wiki

thanks


Simplify HiveDataSource::addSplit

@Yuhta I have updated the PR, will you please review it again? Thanks!

@Yuhta @xiaoxmeng Thank you very much, I have updated the PR with readerOutputType_ named back.

Although we don't really need to set constant values for filter only specs.

Could you explain a bit about this? In this change, the filter only specs was not set constant. See this code
auto outputTypeIdx = readerOutputType_->getChildIdxIfExists(fieldName);
      if (outputTypeIdx.has_value()) {.
        // childSpec is for a column that is an output column
        auto outputIdx = outputTypeIdx.value();
        auto fileTypeIdx = fileType->getChildIdxIfExists(fieldName);
        if (!fileTypeIdx.has_value()) {
          // Column is missing. Most likely due to schema evolution.
          setNullConstantValue(
              childSpec, readerOutputType_->childAt(outputIdx));
        } else {.
          // We know the fieldName exists in the file, make the type at that
          // position match what we expect in the output.
          fileColumnTypes[fileTypeIdx.value()] =
              readerOutputType_->childAt(outputIdx);
          childSpec->setConstantValue(nullptr);
        }
      }
// No else here, and there is no block to handle the case where childSpec is not an output column.

You set the partition key etc. according to spec instead of output type, so filter only fields are also set.  It is correct but not necessary because filter only constant fields are only examined for split skipping purpose and not checked for each row.


Add feature to set path and commit message

With argument -p or --path can specify the base path where create the
application. Current path by default.
With argument -m or --message can specify the first commit message. "Initial
commit." by default.

Thanks Jose! I want to think about this for a second. I'm very much interested in keeping the syntax and the code  as clean and simple as possible. But I see this PR and I'm thinking about it. thanks for your time!

I tried to keep it simple and clean. In fact you can use the script without arguments and works in the same way :)

@josebailo You totally did! If you had made it required, I would've just rejected it. :)
And the features are all flag features, so this won't have a negative impact on the usability for a new user. You did a great job.

I'm trying to figure out how I feel about the idea of having to think about flags when you're using it. It's about how much is it "opinionated default that you can override" and how much it's "it's this way or use another tool."
Will keep thinking. Again, thanks Jose.:)

@josebailo merged--thanks so much for your help!


[ownership] Treat open_existential_box as an interior pointer producting instruction.

This means that it can only have a guaranteed object as an operandand that we
validate that all uses of the result address of open_existential_box occur only
within the lifetime of said object's borrow scope.

I am most interested in review about the SILGen part.

@swift-ci test

@swift-ci test source compatibility

@swift-ci benchmark

Build failed
Swift Test OS X Platform
Git Sha - f3df836652c52a1f39abf22b26686a8e8c373f98

Performance: -O

Improvement
OLD
NEW
DELTA
RATIO

DataAppendDataMediumToMedium
3200
2960
-7.5%
1.08x (?)

Code size: -O
Performance: -Osize

Regression
OLD
NEW
DELTA
RATIO

FlattenListLoop
2844
3178
+11.7%
0.89x (?)

Code size: -Osize
Performance: -Onone
Code size: -swiftlibs

How to read the data
The tables contain differences in performance which are larger than 8% and
differences in code size which are larger than 1%.
If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.
Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB

@swift-ci clean test os x platform

Build failed
Swift Test OS X Platform
Git Sha - f3df836652c52a1f39abf22b26686a8e8c373f98

@swift-ci test os x platform


Add missing migration files and fix encoding issue of parse_content function

Coverage decreased (-0.04%) to 81.267% when pulling bd4d2b51faf05ec7b18fb37253616e3c69f39259 on phuongnh3012:v0.4.2.dev into d26d99d5a840548c439f02bd0387a775bfc14f4f on zniper:v0.4.2.dev.

Coverage decreased (-0.2%) to 81.132% when pulling 1a2db6d97cf4db662cdf87f1c475f7bd0d231938 on phuongnh3012:v0.4.2.dev into d26d99d5a840548c439f02bd0387a775bfc14f4f on zniper:v0.4.2.dev.

Coverage decreased (-0.04%) to 81.267% when pulling 846378c3bdef4eb119ec8cc173bc0d184afff64f on phuongnh3012:v0.4.2.dev into d26d99d5a840548c439f02bd0387a775bfc14f4f on zniper:v0.4.2.dev.


vhs: init at 0.1.0

Description of changes
Init VHS at v0.1.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

I know this is marked as a draft -- but I figured I'd mention something: according to the README, VHS depends on ffmpeg and ttyd.
I think it would be good for UX if we wrap the binary with these programs in its PATH, so things will just work when users, for example, launch a shell with vhs.

Any clue what's up with the dependencies, btw? We're using Go 1.19, so not sure why go mod vendor is saying we aren't...

@winterqt Thanks!

I think it would be good for UX if we wrap the binary with these programs in its PATH,

I agree we should definitely package the dependencies with this one.

Looks like it succeeded on your machine

It actually didn't succeed on my machine, I wasn't able to successfully build it. I was also getting some errors about not having the correct Go version, so I tried using { buildGoModule = buildGo118Module } but that didn't work either.

Hmm.
If you run go mod vendor from this tag just like, on your dev machine (not in a Nix build), does it succeed?
Also: where's that hash from, then?

Strange. I presume the project builds fine with Go 1.19 outside of Nix?

vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)

It just seems so weird -- why would it be set to 1.16...?

vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod)

It just seems so weird -- why would it be set to 1.16...?

Could it be due to setting the go.mod to 1.16 here?
https://github.com/charmbracelet/vhs/blob/main/go.mod#L3

Oh, I misread the logs, disregard my last comment.
Strange. I presume the project builds fine with Go 1.19 outside of Nix?

Yes, builds fine without nix using Go 1.19 on my machine.

Could it be due to setting the go.mod to 1.16 here?

If a dependency requires Go 1.18+, how does it being set to 1.16 even work at all?

@winterqt Ready for review!

Problems were fixed by: https://github.com/charmbracelet/vhs/pull/84

@maaslalani Can you please wrap the binary to include the binaries needed at runtime in PATH, as discussed earlier?

Force-pushed to address some formatting nits, as well as fix the commit message to correctly reflect the version:
diff --git a/pkgs/applications/misc/vhs/default.nix b/pkgs/applications/misc/vhs/default.nix
index 4c0dfb0b6b4..e7b81632740 100644
--- a/pkgs/applications/misc/vhs/default.nix
+++ b/pkgs/applications/misc/vhs/default.nix
@@ -1,12 +1,14 @@
 { lib, buildGoModule, installShellFiles, fetchFromGitHub, ffmpeg, ttyd, makeWrapper }:
+
 buildGoModule rec {
   pname = "vhs";
   version = "0.1.1";
+
   src = fetchFromGitHub {
     owner = "charmbracelet";
     repo = pname;
     rev = "v${version}";
-    sha256 = "sha256-wcOLUA/U+xRwo7slnACCURQO7D0F3pFP2/SHDfEHeTA=";
+    hash = "sha256-wcOLUA/U+xRwo7slnACCURQO7D0F3pFP2/SHDfEHeTA=";
   };

   vendorSha256 = "sha256-f8EHDxu+NWAFJx9ujzsiDhNymdEzExmdreP11gV56AI=";

Thank you so much @winterqt! Very much appreciated!


Make NuGet.Server able to accept self-cotnained packages

Verify that it accepts packages with license files or license expressions.


Special characters break parsing after xfunc

Consider the examples/Webserver.pol. Defunctionalizing the Pair type yields:
data ×₋(a b: Type) {
    Pair(a b: Type, x: a, y: b): ×₋(a, b),
    Mk×₋7(state: State(True)): ×₋(State(True), Response),
    Mk×₋2(state: State(False)): ×₋(State(False), Response)
}

where the generated identifier Mk×₋7 does not parse.

That is ... weird ... don't we use the same lexer token for that?

Yes, but our identifiers allow a certain set of characters only as in postfix position:
https://github.com/polarity-lang/polarity/blob/c7067f8908c44dd134cc14c4575f8d04245486dd/lang/parser/src/lexer/mod.rs#L92

Ah, I see. The problem is that we add numbers when we automatically generate names for local closures, and the special subscript characters are then no longer at the end of the identifier.
Proposed fix: Change the definition in the lexer. We should look into appropriate Unicode categories for the regex that we use.


Adding a test

Testing my ability to merge after creating a SSH key in account.

Adding the test.md file but will delete later as this is a test.


Addition of ElementTree changes HTML output

I noticed that this change breaks the CI build in django-import-export.  This is for cases when we are escaping harmful characters such as script tags.
If there is already an escaped character in content, then the use of ElementTree will double escape, which will not format correctly. This test (added to HTMLTests) will reproduce the issue:
    def test_html_export_with_special_chars(self):
        self.founders = tablib.Dataset(headers=self.headers, title='Founders')
        self.founders.append(('J & J', 'A', 90))
        self.assertIn("J & J", self.founders.html)

(this test passes in v3.3.0)
This test fails because the '&' string is exported as '&'  So if someone has 'J & J' in their content (i.e. rendered in escape & amp;), they will now get "double escaping" 'J & amp;amp; J'.

I understand this is a breaking change (if not reverted, it should be documented). However I think that security-wise, it's a much better default behavior than the previous one. Maybe we should add an option to the format so that the client code can specify that it already cared for escaping the content (and thus avoid the double-escaping)?

As long as the escaping is done we can handle it ok (so no need for an additional option), however it would be ideal if we could opt into the new ElementTree format when we are ready.  Perhaps to do that you could add a deprecation path using a settings flag so that clients can opt into ElementTree?  I think without this you could well get complaints that exports have changed when the next release goes out.  Then it could be documented and the change explained (it took me a little while to figure out why our CI build was broken).

Hi Claude - are you ok with me submitting a PR to try to make this new dependency on ElementTree optional?  Then we can plan the deprecation in django-import-export.  Please let me know and I'll pull it together.

Submitting PRs doesn't require any permission :smile:

Understood... Just wanted to double-check it was something you would consider before I started.

I looked into whether we could control escaping of text elements using a parameter or similar, but this is not possible (certain characters always get escaped).

@claudep would be grateful if you could take a look at #562

Thanks for suggesting the pull request. However, I'm not thrilled at all by generating HTML by hand as a string (both performance and security-wise). Hopefully other contributors will chime in and tell us their feelings.
Did you try on the django-import-export side to conditionally escape based on tablib version? Would it be doable?

Thanks Claude, I did think there must be a good reason why the HTML has not been generated by hand previously, as it seems like the simplest approach considering we are outputting a table.  Perhaps escaping the values by default (i.e. with html.escape()) would allay the security concerns,  because then you would always end up with an HTML table containing safe values, and this passes all current tests.  If escaping by default, I can't see how this would create any security issues, and would allow users to disable escaping if they needed to.
I cannot see performance being an issue except maybe for very large datasets, and even then I don't think it would be too dissimilar to existing versions.

Did you try on the django-import-export side to conditionally escape based on tablib version? Would it be doable?

It would not be doable because the current version of tablib will always escape (because it uses ElementTree).  We'd have to find a way to conditionally load a previous version of tablib (i.e. with MarkupPy) to ensure we didn't break any existing implementations.
It might be that we have to release our new version with the ElementTree dependency, and see if anyone complains.

I see django-import-export supports html export without escaping content. Do you think that there are valid use cases for that capability? Is deprecating this an option for you?

Do you think that there are valid use cases for that capability?

I think there is a valid use case, which is if users already have escaped content in their db, and they want to export without double escaping.  However, I don't know if anyone does this, and I think it is unlikely that they do.

Is deprecating this an option for you?

Yes, I think this is the way to go.  I will pin the latest release of tablib in import-export, and then add a note to advise that escaping will be mandatory in a future release.  If anyone complains, I can think again, but otherwise I would then be free to upgrade to the latest version of tablib in future.
Thanks for your help with this.  Feel free to close the PR if you wish.

For reference, the import-export PR is here

I think it might be easier all around to pin to 3.5.0 until you're ready to upgrade, and that the next Tablib should be 4.0.0, and mention the change clearly in the release notes.
Thank you though for testing the main branch in your CI, it's rare but very welcome to get pre-release feedback! 👍


Handle nil section controllers from data source

Changes in this pull request
Removing the assert and handling nil section controllers. This wont effect Swift code which demands a non-optional section controller, but Objective-C is more nuanced. There is evidence that some callers do not have a default state and are returning nil.
Unfortunately this will OOB here if using the original objects array provided by the data source. Instead we prune the array, only allowing in objects that have a matching section controller.
Fixes t15773862 internally.
Pull request checklist

[x] All tests pass. Demo project builds and runs.
[x] I added tests, an experiment, or detailed why my change isn't tested.
[x] I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.

@rnystrom -- But allowing nil here contradicts the API contract, which specifies that implementers must return non-nil section controllers.
Shouldn't we just handle the OOB error instead?
https://github.com/Instagram/IGListKit/blob/master/Source/Internal/IGListSectionMap.m#L63

@jessesquires and I just chatted offline:

This diff fixes the OOB by just skipping the object+section controller if the SC is nil
Keeping the assert makes testing difficult. We could add a check NSStringFromClass(@"XCTestCase") == nil before asserting, but that's kind of gross

I'm going to add a warning log if the SC is nil so we can cleanly test and at least raise some complaints.


Fix multiple type-params from being split into overloads.

Includes deduping some code.

Thanks, @epabst


[AIRFLOW-2549] Fix DataProcOperation error-check

GCP DataProc Workflow Template operators should report errors when jobs
fail, even though the errors are not propagated up to the 'error'
field of the DataProcOperation API response object.
This commit checks the outcomes of the individual jobs for errors, and
raises an Exception if any are detected.
This behavior is consistent in spirit with the documentation for
DataProc Workflow templates, which states "A failure in any node in a
workflow will cause the workflow to fail."  See:
https://cloud.google.com/dataproc/docs/concepts/workflows/overview
Make sure you have checked all steps below.
JIRA

[X] My PR addresses the following Airflow JIRA issues and references them in the PR title.

Description

[ X ] Here are some details about my PR, including screenshots of any UI changes:
There are no UI changes.  The only change is that DataProcWorkflowTemplate-based operators will report failures when any of their component jobs/nodes fail, whereas previously those operators would report successes.

Tests

[X] My PR adds unit tests to make sure that the _DataProcOperator class responds properly to both successful and failed workflow template operations.

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[X] In case of new functionality, my PR adds documentation that describes how to use it.
N/A

Code Quality

[X] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

cc: @fenglu-g @DanSedov

@kaxil

@mchalek
Please resolve the below errors for Py3:
======================================================================
18) ERROR: test_failed_operation_detector (tests.contrib.hooks.test_gcp_dataproc_hook.DataProcHookTest)
----------------------------------------------------------------------
   Traceback (most recent call last):
    tests/contrib/hooks/test_gcp_dataproc_hook.py line 144 in test_failed_operation_detector
      self.assertTrue(context.exception.message.startswith(
   AttributeError: 'Exception' object has no attribute 'message'

Sorry about that, @kaxil , I think it should be fixed by my last commit.
In the comments on the Jira, @DanSedov pointed out that this commit addresses an issue they would like to fix in DataProc (by surfacing errors at the top level of the API response).  So it may not be necessary to merge this into Airflow.
I think it would be useful to identify the failed job in the Airflow error message, which is something that this commit accomplishes (we have already found it useful in our deployments at Etsy).  For this to work without this airflow commit, it will be necessary for the DataProc error message to indicate the failed jobs.  @DanSedov can you provide guidance on whether the specific job failures will be surfaced in the top-level API error field once your fix is in place?

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3ed25a9). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #3447   +/-   ##
=========================================
  Coverage          ?   76.89%
=========================================
  Files             ?      203
  Lines             ?    15118
  Branches          ?        0
=========================================
  Hits              ?    11625
  Misses            ?     3493
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed25a9...86d110e. Read the comment docs.

@mchalek I guess we should then wait for the next release which should be in a week. If we would be now receiving the error message in the response itself, do you think we need this PR anymore?

hi @kaxil , I heard from @DanSedov privately that he expected the DataProc new release to contain a high-level error message in the top level of the response, but that the failure information for individual jobs will likely remain in the metadata.  In this case, a small change to my PR would allow us to propagate job-specific failure messages into the Airflow task logs, which I think would be useful (the original PR already does this, but only when the top-level error field is not filled).  What do you guys think about this?

I definitely think that the job-specific message would be useful. Is the new release out for Dataproc? If not, lets wait for it and then update the PR accordingly.

Hi @mchalek and @kaxil,
In the next few weeks Dataproc will begin to report shorter error messages for failed jobs. This will be of the form "Job step foo (jobId) failed". This replaces the current message "Job failed, see this log file gs:/...". User can always fetch the workflow (via gcloud command) to see all errors; and also fetch the job by id which is now captured in the message.
I feel strongly that Airflow should not rewrite Dataproc error messages as this can only lead to confusion. I have no opinion or objection to collecting and logging job errors, if that is useful.

@fenglu-g Any thoughts on this?


AssertionError: The num_classes (80) in FCNMaskHead of MMDistributedDataParallel does not matches the length of CLASSES 97) in CocoDataset

resolved, silly mistake on my end sorry

I also encountered the same mistake. How did you solve it?


remind: 03.01.16 -> 03.03.01

Motivation for this change
Update remind to the latest version as per https://dianne.skoll.ca/projects/remind/
also, use pname and interpolate version into the download url
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Tested with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93593". Builds and runs just fine. (You can check the 3rd checkbox in the description).

As long as Nix isn't misinterpreting the zero padding in the version to mean 3.1 > 3.03, LGTM. I'm not using remind these days though.


Can CPU only build (i.e. auto-ipu) run detection?

@w111liang222 , Thanks for making good software!
I have just built CPU-version using the auto-ipu docker image. This is because I have RTX 2080Ti which is not SM80+.
I managed to get the software running, but I don't see 3D cuboids when in detect+SLAM mode.
Perhaps the detection is not running at all?
I have attached screenshots of the log and the web UI.

Hi,
The cpu version image can not run the new detection module(built on TensorRT)
you can try the old one (pointpillar) with the cpu image, it use the openvino to run(no gpu require, but   high cpu loading), the code branch is https://github.com/w111liang222/lidar-slam-detection/tree/release_v1.3.0


Update data-lake-storage-introduction-abfs-uri.md

providing clarity on the scheme identifier so folks aren't confused

@tolandmike : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


Object spread assignment does not work

After trying: let { imageUrl, ...otherProps } = props I get an 'Unexpected token' error when building.
After installing babel-plugin-transform-object-rest-spread it works, but is this the right solution?

Yep, that's to be expected since that plugin isn't included out of the box.


Use dune 3 with buildDuneProject

Currently, buildDuneProject insists on dune 2. Dune 3 is the latest version and should be used by default.

Good point, thanks.

Closed via a479ca027e9b28f595e4ed08f06c8ee56b96588a


FXApp::openDisplay: unable to open display :0

Windows Version
Microsoft Windows [Version 10.0.26120.1330]
WSL Version
WSL version: <IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
Linux version <IP_ADDRESS>-microsoft-standard-WSL2 (root@39abeb63c66c) (gcc (GCC) 11.2.0, GNU ld (GNU Binutils) 2.37) #1 SMP PREEMPT_DYNAMIC Sat Jun 29 07:01:04 UTC 2024
Distro Version
Ubuntu 22.04
Other Software
Any GUI app.  xfe gives the message.  So do many other GUI apps.  Some other GUI apps just hang with no message.
Repro Steps
runnin any GUI app
Expected Behavior
none
Actual Behavior
jrm@LY7i:~$ xfe
FXApp::openDisplay: unable to open display :0
JM System Info.txt
Diagnostic Logs
Please see the attached file

logs are in the attached file

see syslog data:

/logs

WslLogs-2024-08-10_08-37-50.zip

Anyone figure this out? I'm having the same problem.

problem solved with "sudo do-release-upgrade"