some cleanup and type check the manifest

Description
Does a lot of what hash_schema was used for in public app validation - we should be doing this for all apps
cc @zendesk/vegemite
Risks

[medium] failing validations for manifest files that should be considered valid

reading this I can value what a "schema" gives us (since you don't need to duplicate which field should be what), I think the issue was more in the implementation and complexity of what we had. this is a good start at least and should do for now though 👍

yep, would be good to combine the type information with the ruby_to_json map, we can think of a neat way to do it later, preferably without throwing too many deserialization errors since that limits us to only one error per attempt.


CORE-6935 Ledger module structure

Screenshots of the new modules, packages and classes can be seen below.

SignableData is now in ledger-common-data.


Receiving on-chain funds should not direct to the receive lightning screen

Wouldn't call it a bug... it's just not implemented 😅

Shall we close this in favor of https://github.com/get10101/10101/issues/1177 ?

Closed in favor of #1177


Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

The .env should be added in the documentation
The AMPL_PATH does not seem to work in VSCode

Version
1.0.2 (Stable)
Relevant log output
No response
Anything else?
No response

This problem was directly linked to Issues/Relative path in VScode.
It is still useful to note that load_dotenv() is going to look for a .env in the script folder and if it does not found it here, it looks in increasingly higher directories.


operator: Remove options deprecated in v1.8

This PR removes cilium-operator options deprecated in v1.8. Please see commit messages for the details.

Coverage decreased (-0.05%) to 37.184% when pulling 94f27d44b86354cade2dec136799ea70ae4c2995 on pr/pchaigno/remove-deprecated-operator-options into f18fcd9b3d4c2d9a26f952b24f4bdae710da88ca on master.

test-me-please

test-me-please


Portal Explore Page

Propose a visual feature
Purpose
Build the css layout of the portal explore page according to the frames below.
It has to be fully responsive.

Specification
Typology
N/A
Properties
N/A
State
N/A
Notes
The Filters part on the left will not be implemented for the moment, but a place is reserved for it to facilitate its integration later.

on https://portal.devnet.staging.okp4.space/dataverse/explore

If we select the 2 data Spaces and we select show 10, we don't see all the datasets and services and it is not indicated. We miss a page numbering.

Not necessary for MVP


Update docs guides for Okta, Entra, Google to handle both sync and non-sync cases

With the OIDC UX improvements coming from #3115, it would be helpful if the docs matched the flow, so they can be linked to.

cc @bmanifold


{Service Connector} az functionapp connection: Hide the command group from customers until being signed off

Related command

az functionapp connection
Description

Hide the command group from customers until it is signed off from partner team.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Service Connector


How to insert data into the DB from the View

Hi,
First of all, thank you for open sourcing this wonderful library. I have followed both of your Udemy tutorials.

After successful login, I am taking the User to the Home Page.
On my home page,

Users can enter some data in the input text field.
They click "Place Bet" button.
Data will be updated in the DB tables.
I want to stay in the same and I do not want to reload the page.

From the View page... how can I invoke a function which is written inside a controller. I tried to use
<a href="/test/test">Test/a>
and <form action="/test/test" method="post"> but browser is redirecting to new page. All I want to do is just update the data in the DB and stay at same page. I don't even want to reload the page.
I have created a controller
` *

PHP version 7.0
*/
class Test extends \Core\Controller
{
/**

Show the signup page

@return void
*/
public function testAction()
{
//updateDB
//code
}

}`
I am facing difficulties to achieve the above functionality. Maybe I have not understood the library.

Do I need to use POST AJAX requests?
If yes Do I need to create a separate PHP file for this AJAX request without following the MVC pattern...?

I just replied to your question inside the Q&A section on the course, but yes, you need to use an Ajax request. You can send these using post, getting the data from the form, for example like this.


fix(module): update html element to get source text

:tada: This PR is included in version 1.37.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


thellier_magic IndexError

What command was run:
thellier_magic.py -fmt png -sav -spc mgk09t1PI01 -WD data_files/3_0/Megiddo

What happened:
Traceback (most recent call last):
  File "/Users/nebula/anaconda3/bin/thellier_magic.py", line 11, in <module>
    sys.exit(main())
  File "/Users/nebula/Python/PmagPy/programs/thellier_magic.py", line 350, in main
    mpars = pmag.domean(araiblock[1], start, end, 'DE-BFL')
  File "/Users/nebula/Python/PmagPy/pmagpy/pmag.py", line 2637, in domean
    if indata[end0] != datablock[end]:
IndexError: list index out of range

Details:
It looks like the problem is happening because the zijdblock is 1 record longer then the length of the araiblock:
zijdblock:
[[273.0, 147.7, -10.3, 5.95e-07, 1, 'g', ''],
[373.0, 152.0, -11.8, 5.82e-07, 1, 'g', ''],
[473.0, 149.4, -13.4, 5.04e-07, 0, 'g', ''],
[523.0, 151.3, -12.6, 4.56e-07, 1, 'g', ''],
[573.0, 151.8, -14.4, 4.06e-07, 0, 'g', ''],
[623.0, 152.7, -12.9, 3.64e-07, 1, 'g', ''],
[673.0, 152.0, -16.0, 3.24e-07, 0, 'g', ''],
[713.0, 152.5, -13.2, 2.8300000000000003e-07, 1, 'g', ''],
[753.0, 154.6, -18.6, 2.27e-07, 0, 'g', ''],
[793.0, 155.6, -14.6, 1.42e-07, 1, 'g', ''],
[833.0, 155.4, -37.3, 7.07e-08, 0, 'g', ''],
[853.0, 155.3, -19.0, 3.32e-08, 1, 'g', '']]

araiblock[1]:
[[273, 0.0, 0.0, 0.0, 1],
[373.0, 68.63377428448868, -59.22267721106515, 4.127562804313254e-08, 1],
[473.0,<PHONE_NUMBER>1041784, -82.74549798271947, 1.0958615901173566e-07, 0],
[523.0, 33.4553132464908, -86.3155534262901, 1.62260031258414e-07, 1],
[573.0,<PHONE_NUMBER>0087905, -87.57972106750883, 2.2765719962266611e-07, 0],
[673.0,<PHONE_NUMBER>895032, -88.43103935436223, 3.578104141247124e-07, 0],
[713.0,<PHONE_NUMBER>92653, -87.50322207930644, 4.1150989333257583e-07, 1],
[753.0,<PHONE_NUMBER>4029467, -89.13141857845704, 4.977136836564665e-07, 0],
[793.0,<PHONE_NUMBER>380596, -88.47165073401189, 6.469080611411464e-07, 1],
[833.0,<PHONE_NUMBER>405032, -88.94436500940107, 8.052797049739216e-07, 0],
[853.0,<PHONE_NUMBER>2668867, -88.60432901593839, 8.66314572943106e-07, 1]]

This means that end is set to 11, which causes the error in domean.
for plotrec in zijdblock:
                if plotrec[0] == beg_int:
                    start = recnum  # while we are at it, collect these bounds
                if plotrec[0] == end_int:
                    end = recnum
...
                mpars = pmag.domean(araiblock[1], start, end, 'DE-BFL')

How should we fix this error, or is this a problem with the data file?
Data file(s):
In PmagPy/data_files/3_0/Megiddo

I think that might be because it isn’t getting to the problem specimen:
In ipmag.thellier_magic:
specimens = specimens[0:5]  # just plot the first 5

Is that line a mistake?

On Nov 29, 2018, at 11:29 AM, Lisa Tauxe<EMAIL_ADDRESS>wrote:
ipmag.thellier_magic works perfectly well in the notebook on this file:
ipmag.thellier_magic(input_dir_path='data_files/3_0/Megiddo’)
thellier_magic.py shouild be changed to call ipmag.thellier_magic and that will fix it. Lori?
lisa

On Nov 28, 2018, at 3:35 PM, Lori J<EMAIL_ADDRESS>wrote:
What command was run:
thellier_magic.py -fmt png -sav -spc mgk09t1PI01 -WD data_files/3_0/Megiddo
What happened:
Traceback (most recent call last):
File "/Users/nebula/anaconda3/bin/thellier_magic.py", line 11, in
sys.exit(main())
File "/Users/nebula/Python/PmagPy/programs/thellier_magic.py", line 350, in main
mpars = pmag.domean(araiblock[1], start, end, 'DE-BFL')
File "/Users/nebula/Python/PmagPy/pmagpy/pmag.py", line 2637, in domean
if indata[end0] != datablock[end]:
IndexError: list index out of range
Details:
It looks like the problem is happening because the zijdblock is 1 record longer then the length of the araiblock:
zijdblock:
[[273.0, 147.7, -10.3, 5.95e-07, 1, 'g', ''],
[373.0, 152.0, -11.8, 5.82e-07, 1, 'g', ''],
[473.0, 149.4, -13.4, 5.04e-07, 0, 'g', ''],
[523.0, 151.3, -12.6, 4.56e-07, 1, 'g', ''],
[573.0, 151.8, -14.4, 4.06e-07, 0, 'g', ''],
[623.0, 152.7, -12.9, 3.64e-07, 1, 'g', ''],
[673.0, 152.0, -16.0, 3.24e-07, 0, 'g', ''],
[713.0, 152.5, -13.2, 2.8300000000000003e-07, 1, 'g', ''],
[753.0, 154.6, -18.6, 2.27e-07, 0, 'g', ''],
[793.0, 155.6, -14.6, 1.42e-07, 1, 'g', ''],
[833.0, 155.4, -37.3, 7.07e-08, 0, 'g', ''],
[853.0, 155.3, -19.0, 3.32e-08, 1, 'g', '']]
araiblock[1]:
[[273, 0.0, 0.0, 0.0, 1],
[373.0, 68.63377428448868, -59.22267721106515, 4.127562804313254e-08, 1],
[473.0,<PHONE_NUMBER>1041784, -82.74549798271947, 1.0958615901173566e-07, 0],
[523.0, 33.4553132464908, -86.3155534262901, 1.62260031258414e-07, 1],
[573.0,<PHONE_NUMBER>0087905, -87.57972106750883, 2.2765719962266611e-07, 0],
[673.0,<PHONE_NUMBER>895032, -88.43103935436223, 3.578104141247124e-07, 0],
[713.0,<PHONE_NUMBER>92653, -87.50322207930644, 4.1150989333257583e-07, 1],
[753.0,<PHONE_NUMBER>4029467, -89.13141857845704, 4.977136836564665e-07, 0],
[793.0,<PHONE_NUMBER>380596, -88.47165073401189, 6.469080611411464e-07, 1],
[833.0,<PHONE_NUMBER>405032, -88.94436500940107, 8.052797049739216e-07, 0],
[853.0,<PHONE_NUMBER>2668867, -88.60432901593839, 8.66314572943106e-07, 1]]
This means that end is set to 11, which causes the error in domean.
for plotrec in zijdblock:
if plotrec[0] == beg_int:
start = recnum # while we are at it, collect these bounds
if plotrec[0] == end_int:
end = recnum
...
mpars = pmag.domean(araiblock[1], start, end, 'DE-BFL')
How should we fix this error, or is this a problem with the data file?
Data file(s):
In PmagPy/data_files/3_0/Megiddo
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/474, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKrDSLzUCiks0TFJouGvTA5alvrmMRPks5uzx3HgaJpZM4Y4pLt.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/474#issuecomment-442961432, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwGIofZzlrOvdzeZMRnpXetuKD2KXM3ks5u0DWHgaJpZM4Y4pLt.

oh.  oops.  yeah that shouldn’t be in there.
i’ll take a look.

On Nov 29, 2018, at 11:35 AM, Lori J<EMAIL_ADDRESS>wrote:
I think that might be because it isn’t getting to the problem specimen:
In ipmag.thellier_magic:
specimens = specimens[0:5] # just plot the first 5
Is that line a mistake?

On Nov 29, 2018, at 11:29 AM, Lisa Tauxe<EMAIL_ADDRESS>wrote:
ipmag.thellier_magic works perfectly well in the notebook on this file:
ipmag.thellier_magic(input_dir_path='data_files/3_0/Megiddo’)
thellier_magic.py shouild be changed to call ipmag.thellier_magic and that will fix it. Lori?
lisa

On Nov 28, 2018, at 3:35 PM, Lori J<EMAIL_ADDRESS>wrote:
What command was run:
thellier_magic.py -fmt png -sav -spc mgk09t1PI01 -WD data_files/3_0/Megiddo
What happened:
Traceback (most recent call last):
File "/Users/nebula/anaconda3/bin/thellier_magic.py", line 11, in
sys.exit(main())
File "/Users/nebula/Python/PmagPy/programs/thellier_magic.py", line 350, in main
mpars = pmag.domean(araiblock[1], start, end, 'DE-BFL')
File "/Users/nebula/Python/PmagPy/pmagpy/pmag.py", line 2637, in domean
if indata[end0] != datablock[end]:
IndexError: list index out of range
Details:
It looks like the problem is happening because the zijdblock is 1 record longer then the length of the araiblock:
zijdblock:
[[273.0, 147.7, -10.3, 5.95e-07, 1, 'g', ''],
[373.0, 152.0, -11.8, 5.82e-07, 1, 'g', ''],
[473.0, 149.4, -13.4, 5.04e-07, 0, 'g', ''],
[523.0, 151.3, -12.6, 4.56e-07, 1, 'g', ''],
[573.0, 151.8, -14.4, 4.06e-07, 0, 'g', ''],
[623.0, 152.7, -12.9, 3.64e-07, 1, 'g', ''],
[673.0, 152.0, -16.0, 3.24e-07, 0, 'g', ''],
[713.0, 152.5, -13.2, 2.8300000000000003e-07, 1, 'g', ''],
[753.0, 154.6, -18.6, 2.27e-07, 0, 'g', ''],
[793.0, 155.6, -14.6, 1.42e-07, 1, 'g', ''],
[833.0, 155.4, -37.3, 7.07e-08, 0, 'g', ''],
[853.0, 155.3, -19.0, 3.32e-08, 1, 'g', '']]
araiblock[1]:
[[273, 0.0, 0.0, 0.0, 1],
[373.0, 68.63377428448868, -59.22267721106515, 4.127562804313254e-08, 1],
[473.0,<PHONE_NUMBER>1041784, -82.74549798271947, 1.0958615901173566e-07, 0],
[523.0, 33.4553132464908, -86.3155534262901, 1.62260031258414e-07, 1],
[573.0,<PHONE_NUMBER>0087905, -87.57972106750883, 2.2765719962266611e-07, 0],
[673.0,<PHONE_NUMBER>895032, -88.43103935436223, 3.578104141247124e-07, 0],
[713.0,<PHONE_NUMBER>92653, -87.50322207930644, 4.1150989333257583e-07, 1],
[753.0,<PHONE_NUMBER>4029467, -89.13141857845704, 4.977136836564665e-07, 0],
[793.0,<PHONE_NUMBER>380596, -88.47165073401189, 6.469080611411464e-07, 1],
[833.0,<PHONE_NUMBER>405032, -88.94436500940107, 8.052797049739216e-07, 0],
[853.0,<PHONE_NUMBER>2668867, -88.60432901593839, 8.66314572943106e-07, 1]]
This means that end is set to 11, which causes the error in domean.
for plotrec in zijdblock:
if plotrec[0] == beg_int:
start = recnum # while we are at it, collect these bounds
if plotrec[0] == end_int:
end = recnum
...
mpars = pmag.domean(araiblock[1], start, end, 'DE-BFL')
How should we fix this error, or is this a problem with the data file?
Data file(s):
In PmagPy/data_files/3_0/Megiddo
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/474, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKrDSLzUCiks0TFJouGvTA5alvrmMRPks5uzx3HgaJpZM4Y4pLt.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/474#issuecomment-442961432, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwGIofZzlrOvdzeZMRnpXetuKD2KXM3ks5u0DWHgaJpZM4Y4pLt.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/474#issuecomment-442964545, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKrDfPaC2MUP2eaR85p0M2sZgb4k5XHks5u0DcLgaJpZM4Y4pLt.

I fixed both the limit on specimens (shouldn't have been there in the first place) and the failure to plot specimens with no data.

@ltauxe, do you want me to implement the various options that are available in the command line version of thellier_magic.py into ipmag.thellier_magic?

sure that would be great!  thanks
lisa

On Dec 3, 2018, at 11:52 AM, Lori J<EMAIL_ADDRESS>wrote:
@ltauxe https://github.com/ltauxe, do you want me to implement the various options that are available in the command line version of thellier_magic.py into ipmag.thellier_magic?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/PmagPy/PmagPy/issues/474#issuecomment-443846937, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKrDYspEnfJ4hn2eBjMBe89B8KJ-lMuks5u1YEVgaJpZM4Y4pLt.

it looks like the IndexError is not fully resolved:
See:
ipmag.thellier_magic(input_dir_path='data_files/convert_2_magic/livdb_magic/TH_IZZI+')

@ltauxe, can you look at this?  Otherwise I think the implementation of ipmag.thellier_magic is working well, and it is now being used in thellier_magic.py.

This works now.


Clean up Settings

Too much effort to get nested preferences with working back button in action bar. Moving to future release.


Fix contract update

Fix #1580

:white_check_mark: Build AElf <IP_ADDRESS>4 completed (commit https://github.com/AElfProject/AElf/commit/8f353a7824 by @zhxymh)

if you have running executive, it was already taken out the pool, then you upgrade, you will get the hell.

a=GetExecutiveAsync
UpdateCache
b=GetExecutiveAsync
PutExecutiveAsync(a)

what will your cache be? the old b executive will be in the pool
so we have to compare reg's hash and the executive's hash
And we should not pass SmartContractRegistration in the interface,
just add a method called ClearExecutivePool(Address address)

On question one, I discussed with GuangLei before. This situation happens in parallel execution. In GuangLei's opinion, our execution needs to avoid this situation. That is to say, for a contract, update and method call are conflicting, and get and put executive are not allowed when the contract is upgrading, so no need to compare the hash.
On question two, I will change the method to ClearExecutivePool.
@loning

Service is stateless，and should work in parallel condition
发自我的 iPhone

在 2019年4月25日，10:30，ZhangXin<EMAIL_ADDRESS>写道：
if you have running executive, it was already taken out the pool, then you upgrade, you will get the hell.
a=GetExecutiveAsync
UpdateCache
b=GetExecutiveAsync
PutExecutiveAsync(a)
what will your cache be? the old b executive will be in the pool
so we have to compare reg's hash and the executive's hash
And we should not pass SmartContractRegistration in the interface,
just add a method called ClearExecutivePool(Address address)
On question one, I discussed with GuangLei before. This situation happens in parallel execution. In GuangLei's opinion, our execution needs to avoid this situation. That is to say, for a contract, update and method call are conflicting, and get and put executive are not allowed when the contract is upgrading, so no need to compare the hash.
On question two, I will change the method to ClearExecutivePool.
@loning
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

:white_check_mark: Build AElf <IP_ADDRESS>1 completed (commit https://github.com/AElfProject/AElf/commit/53e0460636 by @zhxymh)

Service is stateless，and should work in parallel condition 发自我的 iPhone
…
在 2019年4月25日，10:30，ZhangXin @.***> 写道： if you have running executive, it was already taken out the pool, then you upgrade, you will get the hell. a=GetExecutiveAsync UpdateCache b=GetExecutiveAsync PutExecutiveAsync(a) what will your cache be? the old b executive will be in the pool so we have to compare reg's hash and the executive's hash And we should not pass SmartContractRegistration in the interface, just add a method called ClearExecutivePool(Address address) On question one, I discussed with GuangLei before. This situation happens in parallel execution. In GuangLei's opinion, our execution needs to avoid this situation. That is to say, for a contract, update and method call are conflicting, and get and put executive are not allowed when the contract is upgrading, so no need to compare the hash. On question two, I will change the method to ClearExecutivePool. @loning — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Yes. But in parallel condition, we need to place the transaction that updates the contract in a special place. If we treat it as a normal transaction, then we can't get the same order of execution at all nodes, so we will get different results.
For example, if a block contains a transaction that call contract A and a transaction that updates contract A, the order of execution of the two transactions will be different on different nodes, and the execution result will be different.

Don’t care about how other people use, make your service methods can work in parallel condition
发自我的 iPhone

在 2019年4月25日，11:00，ZhangXin<EMAIL_ADDRESS>写道：
Service is stateless，and should work in parallel condition 发自我的 iPhone
…
在 2019年4月25日，10:30，ZhangXin @.***> 写道： if you have running executive, it was already taken out the pool, then you upgrade, you will get the hell. a=GetExecutiveAsync UpdateCache b=GetExecutiveAsync PutExecutiveAsync(a) what will your cache be? the old b executive will be in the pool so we have to compare reg's hash and the executive's hash And we should not pass SmartContractRegistration in the interface, just add a method called ClearExecutivePool(Address address) On question one, I discussed with GuangLei before. This situation happens in parallel execution. In GuangLei's opinion, our execution needs to avoid this situation. That is to say, for a contract, update and method call are conflicting, and get and put executive are not allowed when the contract is upgrading, so no need to compare the hash. On question two, I will change the method to ClearExecutivePool. @loning — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Yes. But in parallel condition, we need to place the transaction that updates the contract in a special place. If we treat it as a normal transaction, then we can't get the same order of execution at all nodes, so we will get different results.
For example, if a block contains a transaction that call contract A and a transaction that updates contract A, the order of execution of the two transactions will be different on different nodes, and the execution result will be different.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Don’t care about how other people use, make your service methods can work in parallel condition 发自我的 iPhone
…
在 2019年4月25日，11:00，ZhangXin @.> 写道： Service is stateless，and should work in parallel condition 发自我的 iPhone … 在 2019年4月25日，10:30，ZhangXin @.> 写道： if you have running executive, it was already taken out the pool, then you upgrade, you will get the hell. a=GetExecutiveAsync UpdateCache b=GetExecutiveAsync PutExecutiveAsync(a) what will your cache be? the old b executive will be in the pool so we have to compare reg's hash and the executive's hash And we should not pass SmartContractRegistration in the interface, just add a method called ClearExecutivePool(Address address) On question one, I discussed with GuangLei before. This situation happens in parallel execution. In GuangLei's opinion, our execution needs to avoid this situation. That is to say, for a contract, update and method call are conflicting, and get and put executive are not allowed when the contract is upgrading, so no need to compare the hash. On question two, I will change the method to ClearExecutivePool. @loning — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. Yes. But in parallel condition, we need to place the transaction that updates the contract in a special place. If we treat it as a normal transaction, then we can't get the same order of execution at all nodes, so we will get different results. For example, if a block contains a transaction that call contract A and a transaction that updates contract A, the order of execution of the two transactions will be different on different nodes, and the execution result will be different. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

Ok, I will add the ContractCodeHash attribute to the Executive. Meanwhile, the types of ExecutivePools need to be changed from <Address, ConcurrentBag> to <Hash, ConcurrentBag>. Because according to the previous type, PutExecutive needs to check the Hash first and then put it back into the cache, it also have concurrency problems.

What's your opinion? @loning

@zhxymh seems not good,
let me do the left job, you may solve other issues

@zhxymh seems not good,
let me do the left job, you may solve other issues

ok,thx.


Update methods with new product reference fields

Motivation and Context

This  change is required to allow the contact centre service to use the latest version (1.0.1) of the product reference library and to meet the following requirements from card CR-737:
The GET /fulfilments endpoint currently allows the result list to be filtered by optional request params for caseType and region.
See swagger spec in GH census-contact-centre-service-api/swagger.yml
We need to additionally support filtering by the same method, by :
productGroup
individual (true|false)
(singular) deliveryChannel (SMS|POST)
Valid productGroups can be seen in the CC swagger spec, and in the census-int-product-reference v1.0.1
This will need to use the 1.0.1 version of the product reference library, refactored to allow for individual (true|false) and multiple case types
Also ensure that the endpoint only accepts case types HH|SPG|CE - anything else should error back to Serco
Be aware that the individual flag should only be set in the example Product used in the search if explicitly set by Serco ie there should be no default.
When not provided by Serco, we should not include a default in the search - by not setting the individual flag in the example, we are effectively being individual agnostic and will get back both individual and non-individual products, which is correct.
How to test?

Test the changes by running all the census-contact-centre-cucumber features (in branch CR-737 of the census-contact-centre-cucumber repo). To do this the following services need to be running:-

rabbit mq
contact-centre-service
census-mock-case-api-service

Once these are running then you can run all the features using this command:
mvn test

Ella - I have refactored some of your code in the interests of expediency.
(The creation of an individual id will only happen when the product is for an individual AND the caseType is HH. SPG and CE will not require an individual id. That story is upcoming, so you did not know this. I did not want this distinction to be overlooked later).
However I have refactored some of the test code - please take a look, work out why and get back to me.


[Node.js SDK] resolveTime issue for a specific day with time prompt.

Bot Info

SDK Platform: Node.js
Deployment Environment: Azure Bot Service
Active Channels: MS Teams, Cortana

Issue Description
I am using time prompt to accept date/time from user. In the case where user mentions a date with time ex: May 6 2pm I'm getting correct time resolved from builder.Prompts.time. However when user says May 6 I am getting May 6 12pm. I don't think its correct.
Code Example
bot.dialog('acceptStartTime', [
    function (session, results, next) {
            session.dialogData.name = results.response;
            builder.Prompts.time(session, "What’s the first possible date that you would like to reserve a room on?");
    },
    function (session, results) {
        if (results.response) {
            session.dialogData.time = builder.EntityRecognizer.resolveTime([results.response]);
        }
    }
]);

Reproduction Steps

With above code answer with May 6
With above code answer with May 6 2pm

Expected Behavior
When user says May 6 I should expect to get May 6 00:00 (12am)
Actual Results
results.response output when said MAY 6
endIndex:5
entity:"may 6"
resolution:Object {resolution_type: "chrono.duration", start: Sun May 06 2018 12:00:00 GMT-0500 (CDT), ref: Thu Apr 05 2018 21:02:10 GMT-0500 (CDT)}
ref:Thu Apr 05 2018 21:02:10 GMT-0500 (CDT) {}
resolution_type:"chrono.duration"
start:Sun _# **May 06 2018 12:00:00_** GMT-0500 (CDT) {}
score:1
startIndex:0

results.response output when said MAY 6 2pm
endIndex:9
entity:"may 6 2pm"
resolution:Object {resolution_type: "chrono.duration", start: Sun May 06 2018 14:00:00 GMT-0500 (CDT), ref: Thu Apr 05 2018 21:02:55 GMT-0500 (CDT)}
ref:Thu Apr 05 2018 21:02:55 GMT-0500 (CDT) {}
resolution_type:"chrono.duration"
start:Sun # **May 06 2018 14:00:00** GMT-0500 (CDT) {}
score:1
startIndex:0
type:"chrono.duration"

LUIS app is published in North America Region. The Timezone setting is defaulting to (GMT) Western Europe Time London even though I select Central Time US/Canada and publish.
LUIS URL:
https://westus.api.cognitive.microsoft.com/luis/v2.0/apps/{key}?subscription-key={key}&timezoneOffset=-360&verbose=true&q=find a room now

Thanks for reporting this. We are looking into this issue.

Hello, Any update on this please ?

@Stevenic Can you please look into this issue.

Hello, Any update on this please ?

This would be an issue with the Chrono library we use in v3 to parse date times so you would need to raise an issue with them. I will tell you that the Chrono library isn't the greatest library on the planet and has other similar issues.
For our new v4 SDK we now use @microsoft/recognizers-text to parse dates which is much more robust and more importantly we can fix issues we find.  You can find a sample of using that library with v3 here:
https://github.com/Microsoft/Recognizers-Text/tree/master/JavaScript/samples/botbuilder

I haven't tried SDK4 yet so can't say for sure if this is resolved. We are still using V3 in prod so I guess for us this issue still persist.
We can't upgrade to V4 as it in preview & no recommended for production.


Unexpected packages are being added when integrating SwiftLint.

Description
I am using Swift Package Manager to add SwiftLint to my project. I am using the latest Xcode 15.2, but I am facing a weird issue. SwiftPM is adding some extra dependencies to the project, which should not happen as I am only adding one library, which is SwiftLint. This issue is only occurring for the SwiftLint library and not for other libraries. For example, I tested with Alamofire, and in that case, only the Alamofire library is being added. Please check the images for a visual representation of the issue and also refer to a sample project where you can see the problem.
Expected behavior
Should add the SwiftLint dependency to the project.
Actual behavior
Adding Unexpected packages.

Steps to reproduce
Sample project.
SPMSwiftLintIssue.zip
Swift Package Manager version/commit hash
No response
Swift & OS version (output of swift --version ; uname -a)
swift-driver version: 1.87.3 Apple Swift version 5.9.2 (swiftlang-<IP_ADDRESS>.56 clang-15<IP_ADDRESS>.5)
Target: arm64-apple-macosx14.0
Darwin MacBook-Pro 23.2.0 Darwin Kernel Version 23.2.0: Wed Nov 15 21:53:18 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6000 arm64

Hi @preciouslogic, thank you for filing the issue. Is this reproducible for you with any of SwiftPM command line tools, like swift build or swift test? If not, this seems to be an Xcode-specific issue to me.
This GitHub repository is dedicated to development of SwiftPM as an open-source project and has no relation to Xcode. For the latter you'd have to file an issue at http://feedbackassistant.apple.com.

The libraries you see on the screenshot are dependencies of SwiftLint, as specified in its Package.swift manifest. There's no way to add only SwiftLint without libraries that it depends on, otherwise SwiftLint won't build. If you're concerned about those dependencies, it would be more appropriate to file an issue on SwiftLint's repository.
You can compare this to Alamofire's Package.swift, which doesn't specify any dependencies.


Update fs2-core to 2.5.5

Updates co.fs2:fs2-core from 2.5.4 to 2.5.5.
GitHub Release Notes - Changelog - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (2.5.4).
You might want to review and update them manually.
docs/website/package-lock.json

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "co.fs2", artifactId = "fs2-core" } ]

labels: library-update, semver-patch, old-version-remains

Superseded by #817.


Less spellbad 🦝

@andrewhampton lol - I didn't have notifications setup and missed this. We fixed it in another nvim config update as well. Thanks for opening it though 🗡


Dupe exploit

What minecraft version did it occur on?
1.21.1
What superheroes version did it occur on?
6.1.2
Description of the issue:
dupe exploit with speleologist allows you to dupe Redstone dust by placing it and breaking it

For now, go into the speleologist yml file and disable Redstone doubling
Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: minecrafter8001 @.>
Sent: Friday, November 29, 2024 5:27:48 PM
To: Xemorr/superheroes @.>
Cc: Subscribed @.***>
Subject: [Xemorr/superheroes] Dupe exploit (Issue #49)
What minecraft version did it occur on?
1.21.1
What superheroes version did it occur on?
6.1.2
Description of the issue:
dupe exploit with speleologist allows you to dupe Redstone dust by placing it and breaking it
—
Reply to this email directly, view it on GitHubhttps://github.com/Xemorr/superheroes/issues/49, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHSVCMVXLR2QI7PTLXXHSZT2DCPZJAVCNFSM6AAAAABSXQFR2CVHI2DSMVQWIX3LMV43ASLTON2WKOZSG4YDKNZSHEZTSNI.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hello, we tried to solve the issue.
This is what we did:
Modified the ConvertDropsSkill class to prevent Redstone dust duplication when placed and broken by a player with the Speleologist power. The fix involves checking if the broken block is Redstone and skipping the conversion process for it.
You can review changes in this commit: https://github.com/mnmnk43434/Xemorr-superheroes-49/commit/5c6a5865cc49e54adcba7e4f9cebc7ba9c113e00.

[!CAUTION]
Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.

This is not how you write maintainable code. There are many uses of the ConvertibleDrops skill that would cause dupes, it needs a config oriented approach. Your description does not make it sound like it satisfies that
Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: mnmnk43434 @.>
Sent: Friday, November 29, 2024 5:50:01 PM
To: Xemorr/superheroes @.>
Cc: Samuel Hollis @.>; Comment @.>
Subject: Re: [Xemorr/superheroes] Dupe exploit (Issue #49)
Hello, we tried to solve the issue.
This is what we did:
Modified the ConvertDropsSkill class to prevent Redstone dust duplication when placed and broken by a player with the Speleologist power. The fix involves checking if the broken block is Redstone and skipping the conversion process for it.
You can review changes in this commit: @.***https://github.com/mnmnk43434/Xemorr-superheroes-49/commit/5c6a5865cc49e54adcba7e4f9cebc7ba9c113e00.
Caution
Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.
—
Reply to this email directly, view it on GitHubhttps://github.com/Xemorr/superheroes/issues/49#issuecomment-2508207245, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHSVCMTFR4B66LXDPODKQAT2DCSMTAVCNFSM6AAAAABSXQFR2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBYGIYDOMRUGU.
You are receiving this because you commented.Message ID: @.***>


Dog Facts site is broken, so Updated README.md

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not have more than 100 characters
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[ ] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been [squashed][squash-link] into a single commit

Dog Facts site is broken, fixed it

Hi @IAFahim
Thanks for your contribution ;)
We have some problems with Public APIs, so we won't be able to review/add this improvement right now.
Read this issue for more information, please: https://github.com/public-apis/public-apis/issues/3104

I'm in the band

👍🏻


Add logo detection, remove FTS

Did you want to include "storage" in the first strings set and "exceeded" in the second set. It doesn't match any in our repo but it does match on others I've seen.
Sorry I'm on my phone or I'd suggest it.

Did you want to include "storage" in the first strings set and "exceeded" in the second set. It doesn't match any in our repo but it does match on others I've seen.
Sorry I'm on my phone or I'd suggest it.

@morriscode holy shit i didn't see your comment until just now but i literally just pushed that

🔨 #nailedit


[Docenhancement][Togethermode-GA]

Removed developer preview note from Together mode and moved it to GA in whats new.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/apps-in-teams-meetings/teams-together-mode.md
99
1
link
:white_check_mark:

msteams-platform/whats-new.md
87
33
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit c4dccf1:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/teams-together-mode.md
:white_check_mark:Succeeded
View

msteams-platform/whats-new.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


CORS not adding 'access-control-allow-origin' response to options preflight request

I'm getting the following error in chrome:
Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:9000' is therefore not allowed access.
 app.UseCors(policy => policy
            .WithOrigins("http://localhost:9000")
            .AllowAnyMethod()
            .WithHeaders("Access-Control-Allow-Origin, Content-Type, x-xsrf-token, Authorization")
            .AllowCredentials());

According to chrome there is not a single header being added to the response.
What is the correct way to add the "access-control-allow-origin" header to a options response in aspnet5?

@kichalla can you take a look?

FYI I've also tried installing Microsoft.AspNet.Cors package and configuring with:
services.AddCors(options =>
{
options.AddPolicy("DefaultPolicy", builder => builder.WithHeaders("Access-Control-Allow-Origin"));
options.DefaultPolicyName = "DefaultPolicy";
});
Which hasn't made any difference

Can you share how your preflight request looks like?

The signature of the method WithHeaders is public CorsPolicyBuilder WithHeaders(params string[] headers), so it accepts a params array...you had all the headers in one string

BTW you need not supply Access-Control-Allow-Origin as part of the headers list. You can try with a basic scenario where you use AllowAnyHeader and see if everything works fine and then restrict the headers.

@jamesla I cannot repro the issue that you are seeing. Feel free to re-open this issue with a repro.


Use the default github.token

precedent: https://github.com/actions/checkout/blob/main/action.yml#L24

Thank you very much for the PR


mvn clean install package gets errors on Hygieia root

Hi guys
I tried to install Hygieia as usual I downloaded the project but after run mvn clean install package
the console printed me...

Error in the UI.
Do you guys have this problem? :c
Thanks a lot!
Ale from Peru

I've had a bunch of problems with the npm install / downloading of node_modules. I know one thing I had to do was have it hit our proxy directly instead of going through cntlm as cntlm would crash when under heavy load. Other team members run into issues and I just have them copy my entire node_modules folder from my vagrant vm that I managed to get working.

if you have a vagrant vm preconfigured , can you scrub your company data and publish it out , will save me time  as I was thinking on same lines for windows platform

@MarkRx Were you able to get the UI up and running on Linux VM? I faced same issues with node_modules as you mentioned and did the same workaround but the UI never came up for me on Linux platform. I have opened a issue too (https://github.com/capitalone/Hygieia/issues/886) to know what should be the minimum OS requirements.

Unfortunately I don't think I can share the box since it is based off a company base image and I don't know where all the company specific items are saved in the box.
Yes I am able to run the UI in linux. I had to manually install a bunch of the programs needed. They only seemed to work with specific versions too. More details in #590
vagrant@vagrant-ubuntu-trusty-64:~$ npm --version
2.14.15
vagrant@vagrant-ubuntu-trusty-64:~$ java -version
java version "1.8.0_101"
Java(TM) SE Runtime Environment (build 1.8.0_101-b13)
Java HotSpot(TM) 64-Bit Server VM (build 25.101-b13, mixed mode)
vagrant@vagrant-ubuntu-trusty-64:~$ mvn --version
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00)
Maven home: /opt/maven/apache-maven-3.3.9
Java version: 1.8.0_101, vendor: Oracle Corporation
Java home: /opt/java/jdk1.8.0_101/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.13.0-85-generic", arch: "amd64", family: "unix"
vagrant@vagrant-ubuntu-trusty-64:~$ node --version
v5.4.1
vagrant@vagrant-ubuntu-trusty-64:~$ bower --version
1.7.9
vagrant@vagrant-ubuntu-trusty-64:~$ gulp --version
[12:09:27] CLI version 3.9.1
vagrant@vagrant-ubuntu-trusty-64:~$ which bower
/opt/node/node-v5.4.1-linux-x64/bin/bower
 echo $PATH
/opt/java/jdk1.8.0_101/bin/:/opt/maven/apache-maven-3.3.9/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/opt/mongo/mongodb-linux-x86_64-ubuntu1404-3.2.4/bin:/opt/node/node-v5.4.1-linux-x64/bin

Hmm, strange.. looks like my PR failed a Travis build for the same reason:
https://travis-ci.org/capitalone/Hygieia/builds/166491142
[ERROR] npm ERR! Linux 3.13.0-40-generic
[ERROR] npm ERR! argv "/home/travis/build/capitalone/Hygieia/UI/node/node" "/home/travis/build/capitalone/Hygieia/UI/node/node_modules/npm/bin/npm-cli.js" "install"
[ERROR] npm ERR! node v5.4.1
[ERROR] npm ERR! npm  v2.14.15
[ERROR]
[ERROR] npm ERR! shasum check failed for /tmp/npm-4051-de3179a8/registry.npmjs.org/acorn/-/acorn-0.11.0.tgz
[ERROR] npm ERR! Expected: 6e95f0253ad161ff0127db32983e5e2e5352d59a
[ERROR] npm ERR! Actual:   0632cdb64e4a50cb3b9972266b35d690b6606ce8
[ERROR] npm ERR! From:     https://registry.npmjs.org/acorn/-/acorn-0.11.0.tgz
[ERROR] npm ERR!
[ERROR] npm ERR! If you need help, you may report this error at:
[ERROR] npm ERR!     <https://github.com/npm/npm/issues>
[ERROR]
[ERROR] npm ERR! Please include the following file with any support request:
[ERROR] npm ERR!     /home/travis/build/capitalone/Hygieia/UI/npm-debug.log
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] com.capitalone.dashboard:Hygieia ................... SUCCESS [  2.087 s]
[INFO] com.capitalone.dashboard:core ...................... SUCCESS [01:08 min]
[INFO] com.capitalone.dashboard:api ....................... SUCCESS [ 32.913 s]
[INFO] com.capitalone.dashboard:bamboo-build-collector .... SUCCESS [ 10.260 s]
[INFO] com.capitalone.dashboard:jenkins-build-collector ... SUCCESS [  9.411 s]
[INFO] com.capitalone.dashboard:jenkins-cucumber-test-collector SUCCESS [  5.459 s]
[INFO] com.capitalone.dashboard:sonar-codequality-collector SUCCESS [  1.219 s]
[INFO] com.capitalone.dashboard:aws-cloud-collector ....... SUCCESS [  1.418 s]
[INFO] com.capitalone.dashboard:udeploy-deployment-collector SUCCESS [  6.038 s]
[INFO] com.capitalone.dashboard:xldeploy-deployment-collector SUCCESS [  6.106 s]
[INFO] com.capitalone.dashboard:jira-feature-collector .... SUCCESS [ 20.389 s]
[INFO] com.capitalone.dashboard:versionone-feature-collector SUCCESS [  7.209 s]
[INFO] com.capitalone.dashboard:chat-ops-collector ........ SUCCESS [  1.240 s]
[INFO] com.capitalone.dashboard:bitbucket-scm-collector ... SUCCESS [ 10.446 s]
[INFO] com.capitalone.dashboard:github-scm-collector ...... SUCCESS [  5.638 s]
[INFO] com.capitalone.dashboard:subversion-collector ...... SUCCESS [  0.981 s]
[INFO] com.capitalone.dashboard:gitlab-git-collector ...... SUCCESS [  1.666 s]
[INFO] com.capitalone.dashboard:UI ........................ FAILURE [04:09 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 07:23 min
[INFO] Finished at: 2016-10-10T17:29:02+00:00
[INFO] Final Memory: 99M/485M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.29:npm (npm install) on project UI: Failed to run task: 'npm install' failed. (error code 1) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :UI

@mrpudn : any luck with the npm install issue?

I rebased my branch without changing anything, just to trigger a new Travis CI build, and it built the project successfully, so I'm not sure what the issue was

Still not able to get round this issue...trying it on windows 10... :(
What node and npm versions are you guys using?

... $ npm -v
3.10.3
... $ node -v
v6.5.0

Try to install the lower version of node and try the command in root directive.Its some package problem
thats why not able to install npm.


Trajectory utility functions

This PR adds a few utility functions for trajectory classes, which include:
(1) trajectory conversion;
(2) trajectory concatenation;
(3) extract partial trajectory; and
(4) find the closest state in a trajectory given a state.
Those functions are migrated from ADA development.
A few unit tests are added for AIKIDO.
The convertToSpline is moved here from aikido::planner::parabolic.
Please suggest which milestone it shall be for? I will update the CHANGELOD.md accordingly.

Before creating a pull request

[x] Document new methods and classes
[x] Format code with make format

Before merging a pull request

[x] Set version target by selecting a milestone on the right side
[x] Summarize this change in CHANGELOG.md
[x] Add unit test(s) for this change

@gilwoolee I believe all the comments are addressed. Could you take a look at this PR when you have a chance?

Let me know if this PR is good to go!


Deprecate disconnect-after-job-timeout

Originally the agent had two disconnect settings: disconnect-after-job, which caused the agent to disconnect after a job, and disconnect-after-job-timeout which was a timeout prior to receiving a job that if no job was received by would cause the agent to disconnect.
We subsequently added disconnect-after-idle-timeout which disconnects the agent after it's been idle at any time, either before or after a job.
This PR deprecates disconnect-after-job-timeout and suggests using disconnect-after-idle-timeout instead, as it simplifies a lot of code paths. Functionally, they are very similar.

Thoughts on whether this ends up being a breaking change @toolmantim?

When you say deprecated, does that mean it's marked as deprecated in --help / docs, and outputs a message, but still works for now? In which case, that's not a breaking change I think.
Perhaps then it'd be removed in the next major version, or the version after that?

@toolmantim yeah, marked as deprecated and shows a warning.

The disconnect-after-job-timeout Agent config option is listed as deprecated in the docs:

Thanks @harrietgrace 🙇🏼♂

@harrietgrace the documentation does not mention disconnect-after-idle-timeout though

Thanks for pointing that out @scalp42! 👌🏻 I've PR'ed that addition just now.


Move ICR handler into init_signal_handler

@connojd The only change I am going to make on this is the ICR handler will be changed to a static, non-member function to remove the need to include wrmsr.h in the main include. Other than that, this is perfect

:+1:


⚠ Bofrost.at has degraded performance

In 455725e, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1285 ms

Resolved: Bofrost.at performance has improved in 9245e05 after 10 minutes.


Fix for unquoted VSTest settings file path

Please do not merge yet.
I wanted to add a different path VSTest argument and I looked at SettingsFile as a pattern to copy, but I believe I found some issues with its current implementation.
The SettingsFile argument is not quoted. Filenames that contain spaces will cause problems. I've confirmed the expected behavior at the command line. What I'm not sure about is what the resolution should be.
Is there written guidance on handling of whitespace and more specifically in conjunction with rooting relative paths?
Should it mimic the assembly path argument building, assemblyPath.MakeAbsolute(_environment).FullPath.Quote()? This means Local.RunSettings would become /settings:"/Working/Local.RunSettings". Is that outcome correct in the context of Cake? The PR currently reflects this, but as you see it impacted the test. Is /settings:"Local.RunSettings" more desirable?
Should a test be added specifically for whitespace in every parameter like this or is it not worth it?
One last question that affects all quoting in general. \" is the standard escape sequence to allow a single quote to exist inside a quoted argument, and if I remember correctly  \\ is the escape sequence that would allow a literal \" to exist. string.Quote() naively surrounds the string with quotes, but what happens if the path were ever to end with a \? You end up building this string:
app /path "path\with\trailing\slash\" /notapath 3 which gets parsed as:
app, /path, and path\with\trailing\slash" /notapath 3.
The correct built string would double just the ending slash:
app /path "path\with\trailing\slash\\" /notapath 3 which gets parsed as:
app, /path, path\with\trailing\slash\, /notapath, and 3.
Literal (post-escape) " is incidentally not allowed in any path, but both \ and " present opportunities for injection attacks depending where the path is coming from.
I apologize for the complexity, but it would be good to fix this bug and also set a precedent which people like me can refer to when we add new parameters and paths.

Hi @jnm2, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@jnm2 have a look here:
https://github.com/cake-build/cake/blob/develop/src/Cake.Common/Tools/GitReleaseManager/Create/GitReleaseManagerCreator.cs#L109
This is probably the "standard" way of doing it,

@gep13 Oh yes, I wanted to do that but unfortunately AppendQuoted inserts an extra space before the quote (/settings: "filepath" vs /settings:"filepath"). That's not going to be able to be a go-to option for every scenario.
As they are today, QuotedArgument.Render and RenderSafe will improperly quote anything ending with a backslash. Also, if the quoted argument is not a path, it may contain a quote and that is not properly escaped. I think I have fairly efficient string.IndexOf-based code to do this job properly. Tests should be added. Should I open a separate issue or PR for this?

@jnm2 can you make AppendSwitchQuoted work for you?  Where the separator is an empty string?

@gep13 That put me on the right track. In fact, all the string.Format calls really should have been AppendSwitch or AppendSwitchQuoted calls. Does this look good to you?

Here's a draft of proper process argument escaping with tests, following the MSDN spec: https://gist.github.com/jnm2/c5c840bf317605a40f5f56f944db4892
Should I go ahead with a separate PR for that?

That's one for @patriksvensson to hopefully take a look at.

Okay. That part doesn't necessarily have to be done before this PR is merged. It would touch separate code with wider impact than this PR.
After this PR is through I'll submit another that exposes TestCaseFilter and TestAdapterPath.

@jnm2 this looks good to me, just a quick comment.
If you can fix that up, and rebase on latest develop, than I can get this merged in.  Also, as per our contributing document, ideally, we would have an issue that goes along with this pull request.  Can you please create one, and then link through to it?
Thanks!

@gep13 Okay. Are you asking because I need to follow the whole issue template thingy?

@jnm2 sorry, you lost me.

@gep13 I went to create an issue and was presented with a template for repro steps, output log, etc. Can I just copy out of the original PR post?

Gotcha.  The issue template is really intended for when reporting bugs, problems.  For an issue with the code base, it is not really required.  Perhaps a slimmed down version of the text you have in the PR will suffice.

@gep13 Are separate commits okay when adding new tests?
Created issue #1271.

@jnm2 we tend to stick with 1 commit per PR, and just don't let the scope of the PR creep to far.  In this case, a single squashed commit makes sense.

Everything done.


Simplify test directory structure & github actions

The SPARQL client should only need one SPARQL endpoint now that SPARQL endpoints have been merged.
This should allow for a single confest.py and the collapsing / removal of all of the subdirectories / complexity in github actions such as:
      - name: Run tests
        run: |
          cd tests/spaceprez && poetry run pytest
          cd ../vocprez && poetry run pytest
          cd ../catprez && poetry run pytest
          cd ../profiles && poetry run pytest
          cd ../services && poetry run pytest

the test directory structure was simplified some time ago. It is now just /tests and /test_data


Change name of pod to install

It seems like installing 'GoogleSignIn', rather than 'Google/SignIn', still works while pulling in fewer other dependencies.

We merged a similar PR recently, thanks for your time @levity !


save_trt.py

Thanks for sharing the code !Would it be possible to upload the save_trt file as well ?
thanks!

Hi @eyebies ,
Currently, I don't have this script anymore. But you can convert this DB model to TensorRT format by using trtexec
Note, if used F.interpolate function, you must change the mode to "bilinear" instead of the current default mode "nearest" to avoid wrong output mask from Trt model (even though the model converts successfully)!


Regenerate documentation on site

https://imposm.org/docs/imposm3/latest/mapping.html does not have all the content on https://github.com/omniscale/imposm3/blob/a7a47ab6b4739125881791794c4cfcdda6a6b913/docs/mapping.rst, specifically the parts about categorize, geojson_intersects and geojson_intersects_field

Thanks for the reminder.


Common database service

As the primary developer for @sphireinc, I created a common Database interface and related base-level implementations for:

Redis
ScyllaDB (can be abused for Cassandra)
SurrealDB
Clickhouse
MySQL
SQLite
Aerospike
Kafka
Postgres

For the most part, they're just thin wrappers that create a connection given the common interface. For the implementations, I would remove the HealthCheck stuff and anything else that comes from the "ServerStatusCommon.types" package, and probably any of the Query functions as they're largely internal and not general.
This is the interface:
package database

import "github.com/sphireinc/ServerStatusCommon/types"

// Service represents a service that interacts with a database.
type Service interface {
	// Health returns a map of health status information.
	// The keys and values in the map are service-specific.
	Health() (types.HealthCheck, bool)

	// Close terminates the database connection.
	// It returns an error if the connection cannot be closed.
	Close() error

	//	// Query executes a predefined query and returns the results as a slice of maps.
	//	// Each map represents a row with column names as keys and corresponding values.
	//	Query(fileName string) (CommonRows, error)
}

and, the Scylla implementation:
package database

import (
	"fmt"
	"github.com/gocql/gocql"
	"github.com/labstack/echo/v4"
	"github.com/scylladb/gocqlx/v2"
	"github.com/scylladb/gocqlx/v2/qb"
	"github.com/scylladb/gocqlx/v2/table"
	"github.com/sphireinc/ServerStatusCommon/types"
	"log"
	"os"
)

type Health struct {
	Key              string `db:"key"`
	Bootstrapped     string `db:"bootstrapped"`
	BroadcastAddress string `db:"broadcast_address"`
	CqlVersion       string `db:"cql_version"`
	DataCenter       string `db:"data_center"`
	HostID           string `db:"host_id"`
	ListenAddress    string `db:"listen_address"`
	Rack             string `db:"rack"`
	ReleaseVersion   string `db:"release_version"`
	RPCAddress       string `db:"rpc_address"`
	SchemaVersion    string `db:"schema_version"`
}

var HealthMetadata = table.Metadata{
	Name: "system.local",
	Columns: []string{"key", "bootstrapped", "broadcast_address", "cql_version",
		"data_center", "host_id", "listen_address", "rack", "release_version", "rpc_address", "schema_version"},
	PartKey: []string{"key"},
}

var HealthTable = table.New(HealthMetadata)

// ScyllaService represents the ScyllaDB database service.
type ScyllaService struct {
	session gocqlx.Session
	logger  echo.Logger
}

var scyllaInstance *ScyllaService

// NewScyllaService creates a new Scylla service instance.
func NewScyllaService(logger echo.Logger) Service {
	logger.Info("creating new ScyllaService")

	// Reuse Connection
	if scyllaInstance != nil {
		return scyllaInstance
	}

	cluster := gocql.NewCluster(os.Getenv("SCYLLA_HOSTS"))
	cluster.Keyspace = os.Getenv("SCYLLA_KEYSPACE")
	cluster.Consistency = gocql.Quorum
	cluster.Authenticator = gocql.PasswordAuthenticator{
		Username: os.Getenv("SCYLLA_USERNAME"),
		Password: os.Getenv("SCYLLA_PASSWORD"),
	}

	session, err := gocqlx.WrapSession(cluster.CreateSession())
	if err != nil {
		log.Fatal(err)
	}

	scyllaInstance = &ScyllaService{
		session: session,
		logger:  logger,
	}
	logger.Info("created new ScyllaService")
	return scyllaInstance
}

// Close closes the database connection.
func (s *ScyllaService) Close() error {
	log.Printf("Disconnected from database")
	s.session.Close()
	return nil
}

// Query executes a predefined query and returns the results as *gocqlx.Iter.
// It returns an error if the query fails or if there are no rows.
func (s *ScyllaService) Query(action string, tbl *table.Table, params any, where qb.Cmp) (*gocqlx.Iterx, error) {
	var stmt string
	var names []string
	var q *gocqlx.Queryx

	switch action {
	case "INSERT":
		stmt, names = qb.Insert(tbl.Name()).Columns(tbl.Metadata().Columns...).ToCql()
	case "UPDATE":
		stmt, names = qb.Update(tbl.Name()).Set(tbl.Metadata().Columns...).Where(where).ToCql()
	case "SELECT":
		stmt, names = qb.Select(tbl.Name()).Columns(tbl.Metadata().Columns...).ToCql()
	default:
		return nil, fmt.Errorf("unsupported action: %s", action)
	}

	q = s.session.Query(stmt, names).BindStruct(params)
	iter := q.Iter()

	if iter.NumRows() == 0 {
		_ = iter.Close()
		return nil, fmt.Errorf("no rows found")
	}

	return iter, nil
}

// Health checks the health of the database connection by pinging the database.
func (s *ScyllaService) Health() (types.HealthCheck, bool) {
	s.logger.Info("checking database health for ScyllaDB")

	response := types.NewHealthCheck("scylla", "datastore")

// // [CODE OMITTED] // //

	return response, true
}

Would something like this be beneficial for the framework? If so, I would be more than happy to "donate" the watered down code, no strings attached.

@nsa-yoda This looks really interesting. Let me look into this. How we will interact with the database is still somewhat of a question mark for me.

@anthdm sounds good! I was thinking of still keeping db.New() and just adding more consts (like DriverSqlite3) while integrating the additional dbs. I'll keep an eye on this issue awaiting your decision on how to move forward.


Using 'Domain' and 'Range' to describe ternary temporal relations is confusing or wrong

From<EMAIL_ADDRESS>on February 03, 2013 18:05:59
We have many parts of the reference that are of the following sort:
3.1.1	The continuant_part_of relation
ELUCIDATION: b continuant_part_of c at t =Def. b is a part of c at t  & t is a temporal region & b and c are continuants. [002-001]
DOMAIN: continuant
RANGE: continuant
(The range for ‘t’ (as in all cases throughout this document unless otherwise specified) is: temporal region.)
I understand domain and range of a function, or of a binary relation. Are these even defined for ternary relations? If so, what is the definition of Domain and Range?
Original issue: http://code.google.com/p/bfo/issues/detail?id=147

From<EMAIL_ADDRESS>on February 03, 2013 15:48:05
This should all be in the clif for BFO.
Some of the work I did on formalizing type-type relations could be salvaged here. See https://obo.svn.sourceforge.net/svnroot/obo/obolog/trunk/obolog.kif Relevant section:
{{{
(metarelation range)
(text_definition range "Constrains relations such that the object (second argument) of the relation only holds between instances of the specified type")
;; @Axiom: domain constraints on time-indexed relations
(=> (and (domain ?rel ?D)
(?rel ?i1 ?i2 ?t))
(instance_of ?i2 ?D ?t))
;; @Axiom: domain constraints on atemporal relations
(=> (and (domain ?rel ?D)
(?rel ?i1 ?i2))
(instance_of ?i2 ?D))
}}}
Note that you need to do a similar thing for transitivity.


[BugFix] IRSubstitution should keep Var type consistency

Very similar to https://github.com/apache/tvm/pull/11582
Can be triggered by pool2d->binary op with integer 64 in attributes (the attached test case fail on GPU before this fix). cc: @junrushao1994

Substituting an expression of one type for a variable of a different type is an error.  We should find places where this happens and fix it there.

I actually have a patch that fixes your problem without changing substitution, I can create a PR tomorrow.

Yeah, I think @kparzysz-quic is right. We should look for the root cause. Looking forward to the PR!


instruction of route

when drawRoad we can get instruction of route
in this issue i will add get instruction of each route with information that already provided duration & distance

That would be great!  Is it like the list that shows all turns and distance when we select two points?

yeah something like that but only problem that i will face that information is in eng
so i need to find solution how i can make it multi language

but that should application take care of it not the plugin
for first solution maybe i will take of it and i will support en,fr after that i will find another solution


In admin, on Tracking, implement d3.js with Google analytics

See https://developers.google.com/analytics/devguides/reporting/embed/v1/component-reference#data and http://stackoverflow.com/questions/21639305/d3js-take-data-from-an-array-instead-of-a-file

Will be possibly done later, we'll use GA for the time being


(Windows) Enable ANSI colors if the user is using ConEmu

Kinda platform specific, but as there is already support for ANSICON, I figured why not.
ConEmu is a popular Windows Console Emulator that has support for ANSI X3.64 and Xterm 256 colors.
I sent PR #1192 which checks if the user is using ConEmu and has the ANSI colors enabled via ConEmuANSI env-variable.

@petetnt why was the PR closed?

Accidentally made the PR from wrong branch and then duped it to #1199.
#1199 is the correct one, but the build failed because some apt-get repo
for mono didn't respond in time. :8ball:
2015-04-09 9:04 GMT+03:00 Juga Paazmaya<EMAIL_ADDRESS>
@petetnt https://github.com/petetnt why was the PR closed?
—
Reply to this email directly or view it on GitHub
https://github.com/n1k0/casperjs/issues/1193#issuecomment-91124051.

I tried re-running it but failed in the same spot.
Could you try getting the latest changes from master to your #1199 as #1201 had something to do with it?

Merged with the current master and now the tests pass!
2015-04-09 12:14 GMT+03:00 Juga Paazmaya<EMAIL_ADDRESS>
I tried re-running it but failed in the same spot.
Could you try getting the latest changes from master to your #1199
https://github.com/n1k0/casperjs/pull/1199 as #1201
https://github.com/n1k0/casperjs/pull/1201 had something to do with it?
—
Reply to this email directly or view it on GitHub
https://github.com/n1k0/casperjs/issues/1193#issuecomment-91169610.


Links do not open when clicked; they open much later or on close

Issue Type: Performance Issue
Basically what the title says. When I click a link in VSCode, visually, nothing happens. Then, perhaps 5+ minutes later, the link will open. I often find that I'll click a link (see nothing happens), click again, and even again, and still nothign, and "forget" about it. The about 5 minutes later a flurry of tabs open up on FireFox.
Really frustrating.
I don't have this problem on Windows, it only exists on the Linux install I have. Trying to configure Github on VSCode is impossible, as the "sign in" button does nothing, and then when they finally do open they error cause of multiple clicks...
VS Code version: Code 1.38.1 (b37e54c98e1a74ba89e03073e5a3761284e3ffb0, 2019-09-11T13:30:08.229Z)
OS version: Linux x64 5.0.0-29-generic snap
Remote OS version: Linux x64 5.0.0-29-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 x 4299)

GPU Status
2d_canvas: unavailable_softwareflash_3d: disabled_softwareflash_stage3d: disabled_softwareflash_stage3d_baseline: disabled_softwaregpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwareoop_rasterization: disabled_offprotected_video_decode: disabled_offrasterization: disabled_softwareskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: disabled_softwareviz_display_compositor: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_software

Load (avg)
3, 3, 3

Memory (System)
15.58GB (5.56GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: Qebui

OS
Linux x64 5.0.0-29-generic

CPUs
Intel(R) Core(TM) i3-5010U CPU @ 2.10GHz (4 x 881)

Memory (System)
7.62GB (0.51GB free)

VM
100%

Process Info
CPU %	Mem MB	   PID	Process
    0	   176	 23233	code main
    0	    32	 23235	   zygote
    0	   160	 23273	     window (Welcome - Visual Studio Code)
    0	   160	 23314	       extensionHost
    0	    96	 23337	     shared-process
    0	     0	 24183	       /bin/sh -c /usr/bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	     0	 24184	         /usr/bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	   239	 23656	     window (index.aspx (Working Tree) - asp [SSH: Qebui] - Visual Studio Code)
    0	    96	 23692	       extensionHost
    0	     0	 23712	       /bin/sh -c ssh -D 35875 -o ConnectTimeout=15 -F /home/thom/.vscode/ssh/config Qebui bash << 'EOSSH'  echo "Running remote connection script" COMMIT_ID="b37e54c98e1a74ba89e03073e5a3761284e3ffb0" EXTENSIONS="--install-extension ms-ceintl.vscode-language-pack-en-gb --install-extension visualstudioexptteam.vscodeintellicode --install-extension foxundermoon.shell-format --install-extension ms-vscode.csharp --install-extension felixfbecker.php-pack --install-extension azsdktm.securityintellisense --force" TELEMETRY="" export VSCODE_AGENT_FOLDER=$HOME/.vscode-server ALLOW_CLIENT_DOWNLOAD="0"  #setup VSCH_DIR="$VSCODE_AGENT_FOLDER/bin/$COMMIT_ID" VSCH_LOGFILE="$VSCODE_AGENT_FOLDER/.$COMMIT_ID.log"  if [[ ! -d $VSCH_DIR ]]; then .mkdir -p $VSCH_DIR fi  ARCH=$(uname -sm | sed 's/^linux //gi')  case $ARCH in .x86_64) VSCODE_ARCH="x64";; .armv7l) .. ...VSCODE_ARCH="armhf" .. ..;; .arm64 | aarch64) .. ...echo "$ARCH is only supported when running VS Code Insiders" ...echo "b2acfb6c-0123-457a-97ae-d815e9619f55##29##" ...exit 0 .. ..;; .*) ..echo "Unsupported architecture: $ARCH" ..echo "b2acfb6c-0123-457a-97ae-d815e9619f55##27##" ..exit 0 ..;; esac  MAIN_LOCKFD=99 CLEANUP_LOCKFD=98   .## Copyright (C) 2009 Przemyslaw Pawelczyk<EMAIL_ADDRESS>.## This script is licensed under the terms of the MIT license. .## https://opensource.org/licenses/MIT  .get_lockfile() { ..echo "$VSCH_DIR/vscode-remote-lock.$1" .}  .# PRIVATE ._lock()             { flock -$1 $2; } ._no_more_locking()  { _lock u $2; _lock xn $2 && rm -f $(get_lockfile $1); } ._prepare_locking()  { eval "exec $2>\"$(get_lockfile $1)\""; trap "_no_more_locking $1 $2" EXIT; }  .#  .echo "b2acfb6c-0123-457a-97ae-d815e9619f55##24##" .exit 0 fi  # Migrate old data if needed # Check data/ because we just created VSCH_DIR for the lockfile if [[ ! -d $VSCODE_AGENT_FOLDER/data ]]; then .if [[ -d $HOME/.vscode-remote ]]; then ..echo "Migrating .vscode-remote to $VSCODE_AGENT_FOLDER..." ..cp -r "$HOME/.vscode-remote/data" "$VSCODE_AGENT_FOLDER/data" ..cp -r "$HOME/.vscode-remote/extensions" "$VSCODE_AGENT_FOLDER/extensions" .fi fi  # Delete old servers if needed TO_DELETE=$(ls -1 --sort=time $VSCODE_AGENT_FOLDER/bin | tail -n +6) for COMMIT_TO_DELETE in $TO_DELETE; do .echo "Found old VS Code install $COMMIT_TO_DELETE, attempting to clean up"  ._prepare_locking $COMMIT_TO_DELETE $CLEANUP_LOCKFD .exlock_now $CLEANUP_LOCKFD .if (( $? == 0 )); then ..RUNNING="`ps ax | grep $COMMIT_TO_DELETE | grep -v grep | wc -l | tr -d '[:space:]'`" ..if [[ $RUNNING == 0 ]]; then ...echo "Deleting old install from $VSCODE_AGENT_FOLDER/bin/$COMMIT_TO_DELETE" ...rm -rf $VSCODE_AGENT_FOLDER/bin/$COMMIT_TO_DELETE  ...echo "Deleting old log file from $VSCODE_AGENT_FOLDER/.$COMMIT_TO_DELETE.log" ...rm $VSCODE_AGENT_FOLDER/.$COMMIT_TO_DELETE.log ..else ...echo "Install still has running processes, not deleting: $COMMIT_TO_DELETE" ..fi .else ..echo "Failed to acquire lock for install, not deleting: $COMMIT_TO_DELETE" .fi done  do_client_download() { .echo "Trigger client server download" .echo VSCODE_ARCH==$VSCODE_ARCH== .echo b2acfb6c-0123-457a-97ae-d815e9619f55__trigger_vscode_server_download__ .echo "Waiting for client to transfer server archive..." .echo "Waiting for $VSCH_DIR/vscode-scp-done.flag and vscode-server-linux-$VSCODE_ARCH.tar.gz to exist"  .while true; do ..if [[ -f $VSCH_DIR/vscode-scp-done.flag ]]; then ...if [[ ! -f $VSCH_DIR/vscode-server-linux-$VSCODE_ARCH.tar.gz ]]; then ....echo "Found flag but not server tar - server transfer failed" ....echo "b2acfb6c-0123-457a-97ae-d815e9619f55##31##" ....exit 0 ...fi  ...echo "Found flag and server on host" ...rm $VSCH_DIR/vscode-scp-done.flag ...break ..else ...echo -n ' ' ...sleep 3 ..fi .done }  # install if needed if [[ ! -f $VSCH_DIR/server.sh ]] then .echo "Installing to $VSCH_DIR..." .STASHED_WORKING_DIR="`pwd`" .cd $VSCH_DIR  .wget --version &> /dev/null .if (( $? == 0 )) .then ..echo "Downloading with wget" ..WGET_ERRORS=$(2>&1 wget  --connect-timeout=7 --dns-timeout=7 -nv -O vscode-server-linux-$VSCODE_ARCH.tar.gz https://update.code.visualstudio.com/commit:$COMMIT_ID/server-linux-$VSCODE_ARCH/stable) ..if (( $? != 0 )) ..then ...echo "wget download failed" ...echo $WGET_ERRORS ...printenv  ...if [[ $ALLOW_CLIENT_DOWNLOAD == "1" ]]; then ....do_client_download ...else ....echo "b2acfb6c-0123-457a-97ae-d815e9619f55##25##" ....exit 0 ...fi ..else ...echo "Download complete" ..fi .else ..curl --version &> /dev/null ..if (( $? == 0 )) ..then ...echo "Downloading with curl" ...CURL_OUTPUT=$(curl --connect-timeout 7 -L https://update.code.visualstudio.com/commit:$COMMIT_ID/server-linux-$VSCODE_ARCH/stable --output vscode-server-linux-$VSCODE_ARCH.tar.gz -w "%{http_code}") ...if [[ ($? != 0) || ($CURL_OUTPUT != 2??) ]] ...then ....echo "curl download failed" ....echo $CURL_OUTPUT ....printenv  ....if [[ $ALLOW_CLIENT_DOWNLOAD == "1" ]]; then .....do_client_download ....else .....echo "b2acfb6c-0123-457a-97ae-d815e9619f55##25##" .....exit 0 ....fi ...else ....echo "Download complete" ...fi ..else ...printenv ...echo "Neither wget nor curl is installed" ...echo "b2acfb6c-0123-457a-97ae-d815e9619f55##26##" ...exit 0 ..fi .fi  .tar -xf vscode-server-linux-$VSCODE_ARCH.tar.gz .mv vscode-server-linux-$VSCODE_ARCH*/* .  .if (( $? > 0 )) .then ..echo "WARNING: tar exited with non-0 exit code" .fi  .# cheap sanity check .if [[ ! -f $VSCH_DIR/node ]] .then ..echo "WARNING: $VSCH_DIR/node doesn't exist. Download/untar may have failed." .fi  .if [[ ! -f $VSCH_DIR/server.sh ]] .then ..echo "WARNING: $VSCH_DIR/server.sh doesn't exist. Download/untar may have failed." .fi  .# Delete the leftover folder which might have -web prefix, and the .tar.gz .rm -rf vscode-server-linux-$VSCODE_ARCH* .cd $STASHED_WORKING_DIR  .# install extensions .if [[ ! -z $EXTENSIONS ]] .then ..echo "Installing extensions..." ..$VSCH_DIR/server.sh $TELEMETRY $EXTENSIONS .fi  else .echo "Found existing installation at $VSCH_DIR..." fi  # launch if needed RUNNING="`ps ax | grep $VSCH_DIR/server.sh | grep -v grep | wc -l | tr -d '[:space:]'`" if [[ $RUNNING == 0 ]] then .printenv .echo "Starting server..." .export PATH="$VSCH_DIR/bin:$PATH" .$VSCH_DIR/server.sh --host=<IP_ADDRESS> --enable-remote-auto-shutdown $TELEMETRY --port=0 &> $VSCH_LOGFILE < /dev/null &  .stopTime=$((SECONDS+4))  .while (($SECONDS < $stopTime)) .do ..PORT=`cat "$VSCH_LOGFILE" | grep -a -E 'Extension host agent listening on [0-9]+' | grep -v grep | grep -o -E '[0-9]+'` ..if [[ $PORT != '' ]] ..then ...break ..fi  ..echo "Waiting for server log..." ..sleep .5 .done else .echo "Found running server..." fi  echo " " echo "*" echo "* Reminder: You may only use this software with Visual Studio family products," echo "* as described in the license (https://go.microsoft.com/fwlink/?linkid=2077057)" echo "*" echo " "  PORT=`cat "$VSCH_LOGFILE" | grep -a -E 'Extension host agent listening on [0-9]+' | grep -v grep | grep -o -E '[0-9]+'` WEBVIEWPORT=`cat "$VSCH_LOGFILE" | grep -a -E 'webview server listening on [0-9]+' | grep -v grep | grep -o -E '[0-9]+'` WEBUITOKEN=`cat "$VSCH_LOGFILE" | grep -a -E 'Web UI available at' | grep -o -E 'tkn=[0-9a-f-]+' | grep -o -E '[0-9a-f-]+'` if [[ -z $PORT ]] then .echo "Server did not start successfully. Full server log >>>" .cat $VSCH_LOGFILE .echo "<<< End of server log" .echo "b2acfb6c-0123-457a-97ae-d815e9619f55##32##" .exit 0 fi  # If the server was already running, ensure that it won't shut down in the near future if [[ $RUNNING != 0 ]]; then .# In case the server is close to timing out and shutting down, ask it to delay shutdown .wget --version &> /dev/null .if (( $? == 0 )) .then ..echo "Checking server status on port $PORT with wget" ..WGET_OUT=$(wget --no-proxy -nv -O - http://<IP_ADDRESS>:$PORT/delay-shutdown 2>&1) ..if [[ $? != 0 ]]; then ...echo $WGET_OUT ...echo "b2acfb6c-0123-457a-97ae-d815e9619f55##28##" ...exit 0 ..fi .else ..curl --version &> /dev/null ..if (( $? == 0 )) ..then ...echo "Checking server status on port $PORT with curl" ...CURL_OUTPUT=$(curl --noproxy <IP_ADDRESS> -s http://<IP_ADDRESS>:$PORT/delay-shutdown -w " %{http_code}") ...if [[ ($? != 0) || ($CURL_OUTPUT != "OK 200") ]]; then ....echo $CURL_OUTPUT ....echo "b2acfb6c-0123-457a-97ae-d815e9619f55##28##" ....exit 0 ...fi ..else ...echo "Neither wget nor curl is installed" ...echo "b2acfb6c-0123-457a-97ae-d815e9619f55##26##" ...exit 0 ..fi .fi fi  OSRELEASEID=`cat /etc/os-release 2>/dev/null | grep -a -E '^ID=' | sed 's/^ID=//gi' | sed 's/"//g'` if [[ -z $OSRELEASEID ]] then .OSRELEASEID=`cat /usr/lib/os-release 2>/dev/null | grep -a -E '^ID=' | sed 's/^ID=//gi' | sed 's/"//g'` .if [[ -z $OSRELEASEID ]] .then ..OSRELEASEID=`uname -s` .fi fi  # What we echo below cannot be longer than 80 characters echo "b2acfb6c-0123-457a-97ae-d815e9619f55: start" echo "sshAuthSock==$SSH_AUTH_SOCK==" echo "agentPort==$PORT==" echo "webViewServerPort==$WEBVIEWPORT==" echo "osReleaseId==$OSRELEASEID==" echo "arch==$ARCH==" echo "webUiAccessToken==$WEBUITOKEN==" echo "b2acfb6c-0123-457a-97ae-d815e9619f55: end"  unlock $MAIN_LOCKFD  while true; do sleep 180; echo -n ' '; done  EOSSH exit 0
    0	     0	 23715	         ssh -D 35875 -o ConnectTimeout=15 -F /home/thom/.vscode/ssh/config Qebui bash
    0	    96	 24158	     window (Issue Reporter)
    0	    48	 23290	   gpu-process

Remote: SSH: Qebui
CPU %	Mem MB	   PID	Process
    0	   112	 17987	remote agent
    0	   128	 30338	   extensionHost
    0	    16	 30362	     /bin/bash
    0	   176	 30412	     /home/thom/.vscode-server/bin/b37e54c98e1a74ba89e03073e5a3761284e3ffb0/node /home/thom/.vscode-server/bin/b37e54c98e1a74ba89e03073e5a3761284e3ffb0/extensions/html-language-features/server/dist/htmlServerMain --node-ipc --clientProcessId=30338
    0	    80	 30345	   watcherService
    0	     0	 30478	   /bin/sh -c /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=
    0	     0	 30479	     /bin/ps -ax -o pid=,ppid=,pcpu=,pmem=,command=

Workspace Info

|  Remote: SSH: Qebui|    Folder (asp): 3 files|      File types: gitignore(1) aspx(1)
|      Conf files:;

Extensions (16)

Extension
Author (truncated)
Version

vsc-material-theme
Equ
30.0.0

vscode-language-pack-en-GB
MS-
1.38.4

remote-containers
ms-
0.74.0

remote-ssh
ms-
0.46.1

remote-ssh-edit
ms-
0.46.1

remote-ssh-explorer
ms-
0.46.1

remote-wsl
ms-
0.39.5

vscode-remote-extensionpack
ms-
0.17.0

material-icon-theme
PKi
3.9.0

SecurityIntelliSense
azs
0.8.0

php-debug
fel
1.13.0

php-intellisense
fel
2.3.13

php-pack
fel
1.0.2

shell-format
fox
6.1.2

vscode-pull-request-github
Git
0.11.2

csharp
ms-
1.21.3

Seems that not being able to sign into GitHub from VSCode is an existing (and ignored) issue: https://github.com/microsoft/vscode-pull-request-github/issues/1221

@LarnuUK Do you see the same delay for other links in VSCode, like links on extension description pages?

@LarnuUK Do you see the same delay for other links in VSCode, like links on extension description pages?

Everywhere. The Extension screens, integrated terminal, a link in a file, when an extension asked me to view a page, etc, etc, etc. Literally anything that would push the page to my default browser.

OK, thanks, so it sounds like it's a more general problem than this extension. I'll transfer the issue to VSCode.
Is there any other application you have that opens the default browser, does it also have the delay?
There are exploration builds that use a newer version of our UI framework (Electron version 6.0.x), can you see if the problem reproduces there?
Linux (DEB): Download
Linux (RPM): Download
Linux (Snap): Download


Update Magento 2 image to use function approach

Updating the Magento2 image to use the new function based approach by @andytson-inviqa
WIP, probably won't build yet.

A quay.io/continuouspipe/magento2-nginx-php7:dev-functionised image tag has been pushed up for someone to test. Might be me when I have some time :)

The PR that this is based on, #181, currently has a bug with truthy values and confd. Placing this on hold until resolved.


Misspelling

Under policy/admission controls CONFIGURATION is spelled wrong - CONFIGUATION (missing the r). The modal that pops up has the same misspelling.

The misspelling issue has been changed.


Extend state management API example

What content needs to be created?
More complete state management API example in getting started docs
Describe the solution you'd like
Update and extend state management API example in Use the Dapr API to include bulk and transaction operations
Where should the new material be placed?
Use the Dapr API

/assign


Beta true set but Fastlane trying to upload to App Store

I am using Fastlane to build, sign and deliver my app to test flight. I've a lane named 'beta' which do following:
before_all do
    sigh
   update_project_provisioning(
    xcodeproj: "PATH",
    profile: "./PROVPROFILE.mobileprovision"
    )
    gym(scheme: "AppScheme", project: "PATH")
  end
lane :beta do
    snapshot
    deliver(beta: true)
 end

However, when I do fastlane beta, it upload the new IPA to test flight, however, before new build is uploaded to App Store, it try to check it in US App Store, for example:
[37m[11:00:51]: [0mGot all information needed to deploy a new update ('[[APP_VERSION]]') for app 'com.myapp.projecttest'
[37m[11:00:51]: [0m[33mBeta builds don't upload new metadata to iTunesConnect[0m
[33m[11:00:52]: [0mApp doesn't seem to be in the App Store yet or is not available in the US App Store. Using the iTC API instead.
[37m[11:00:56]: [0mLogging into iTunesConnect
[37m[11:01:11]: [0mSuccessfully logged into iTunesConnect
[37m[11:01:11]: [0mLogging into iTunesConnect
[37m[11:01:18]: [0mUploading ipa file to iTunesConnect
[37m[11:01:19]: [0mGoing to upload updated app to iTunesConnect

Shouldn't this upload directly to TestFlight? I am not sure why it is trying to check if app is available in App store or not.

TestFlight is iTunes Connect. The only difference is that for the App Store you have to select the build as production build, while for testing you select it as beta build :wink:
It checks for the US App Store, just because it tries to fetch the App ID based on the App Identifier.

Thanks @KrauseFx I was worried that it might push to App Store if app was there. Thanks for wonderful tool :+1:

:+1:


Get event by ID

Added ability to retrieve one event by its unique event ID.
Slightly restructured the way events are converted into dict form so an event_id field doesn't get stored in MongoDB, which could have led to duplicate or conflicting info. The get_dict function now just moves the info in event_id to a field called _id.
Namedtuple doesn't allow _id as a field so I couldn't just modify the required attributes.

I think there's a problem with your post adding logic. MongoDB defaults unique ObjectIDs as the type for the _id field, but it allows you to override that to be whatever datatype you want as long as it is unique and not an array. This can sometimes be useful, but I think you probably want all event IDs to be unique randomly generated ObjectIDs. To do this, your uploading function must construct an ObjectID from the string parameter that was passed to the request (see here), and your tests need to use valid string representations of ObjectIDs which are 24-char hex strings (see line 189 here).

Do you mean I should create an ObjectID from the string passed to get_one_event? That seems the most similar to what you did in the posts app.py file.

Do you mean I should create an ObjectID from the string passed to get_one_event? That seems the most similar to what you did in the posts app.py file.

Yeah, but then you'll find your tests won't work if you are testing with fake ObjectIDs unless they are formatted as 24-char hex strings. Alternatively, I guess you could ignore the _id field and generate your own event ID and store it as a string using something like the uuid lib.


MM-49219: fixes post priority

Summary
We have changed how priority gets saved in the server, so now instead of post.props we are using post.metadata.priority.
This commit adds the relevant changes for posts' priority to work in the mobile app.
Ticket Link
https://mattermost.atlassian.net/browse/MM-49219
Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.

Device Information
This PR was tested on:
Release Note
Fixed a bug regarding post priority labels

Building app in separate branch.

Successfully building:
https://circleci.com/gh/mattermost/mattermost-mobile/26993
https://circleci.com/gh/mattermost/mattermost-mobile/26992

Wait, have message priority been shipped already before? Do we care about backwards compatibility?

Wait, have message priority been shipped already before? Do we care about backwards compatibility?

it has been shipped but the feature flag was off

Artifact links:
https://output.circle-artifacts.com/output/job/a3c79b8a-9775-4182-9a11-621a3693dd70/artifacts/0/tmp/artifacts/Mattermost_Beta.apk
https://output.circle-artifacts.com/output/job/350c55a7-6c7f-4b45-85d7-97e8c14ad822/artifacts/0/tmp/artifacts/Mattermost_Beta.ipa

Thanks @koox00
Tested, looks good to merge.
Verified post priority labels are working as expected.


Rating seems broken, Successful API call returns all NULL values for all entities

testing out rating today, and although a valid API call is made and reports success, all returned results are NULL, thus none of the returned API data is available. seems a generic issue with this wrapper.
Testing the exact same API call manually via CURL works correctly.
Example:

same API call via CURL:

@Noodleyman I have the same problem Did you find any solution?

Nope, I abandoned use of this wrapped and just wrote my own in the end as I only have minimal use cases

@Noodleyman did you put your solution on git for public access? I think such a code would be useful to many users

@APanteleychuk @Noodleyman please check this out first. Official repo is full of issues related to Rate API.
https://github.com/UPS-API/api-documentation/issues
Have no idea how UPS plan to implement it.

Please see our extension as example  based on API here
https://github.com/abantecart/abantecart-src/tree/master/public_html/extensions/ups


rss square doesnt show up on firefox

tried to add htaaccess and didnt work. get a svg and add for full browser support

gone in most recent firefox update. weird!!


TCRdist performance improvements

TCRdist performance improvements added and joblib used

Looks great, thanks! Just one question above.


Modal rendering inconsistent. Disappearing Modals.

Current Behavior
When multiple modals are triggered in quick succession, especially when triggered by a promise resolution, only the first modal is rendered properly. The subsequent modals appear momentarily and then disappear. But if there is sufficient delay between triggering modals, the subsequent modals don't disappear.
This issue can be resolved if the svelte key block is removed from Modal.svelte .
https://github.com/skeletonlabs/skeleton/blob/c6a4ddc02d2883e2ff0c350cc5f02f3b69d0d9ce/packages/skeleton/src/lib/utilities/Modal/Modal.svelte#L243
Expected Behavior
Modals shouldn't disappear.
Steps To Reproduce
Stackblitz link has been attached for minimal code for reproducing the bug.
Link to Reproduction / Stackblitz
https://stackblitz.com/~/github.com/keygenx/skeleton-modal-bug
More Information
No response

Hey @keygenx, we're aware of this issue and aiming to revisit the logic behind the modal system in Skeleton v3. We've got an issue tracking feature requests and bugs here, so I'll consolidate this into that post:

https://github.com/skeletonlabs/skeleton/issues/2357

You can monitor progress from that issue going forward.


[SE-0101] Migration

Depends on https://github.com/apple/swift/pull/3854
SE-0101 removes sizeof, sizeofValue and related functions from the stdlib.
This PR is migrating them to newly introduced MemoryLayout<T> values.

@atrick @gribozavr This PR includes some .size => .stride change.
Could you take a look?

LGTM.  The .size => .stride bugfixes LGTM as well.

@swift-ci Please test

@swift-ci Please test


feat: Support for icloud.com.cn

tACK, works in China, but needs this
diff --git a/src/manifest.json b/src/manifest.json
index 74aba60..1706c4c 100644
--- a/src/manifest.json
+++ b/src/manifest.json
@@ -32,7 +32,7 @@
     "webRequest",
     "notifications"
   ],
-  "host_permissions": ["https://*.icloud.com/*"],
+  "host_permissions": ["https://*.icloud.com/*", "https://*.icloud.com.cn/*"],
   "icons": {
     "16": "icon-16.png",
     "32": "icon-32.png",

@gutenye have addressed both of your comments (thank you!) + did some refactoring. Would you mind testing that it works as expected for CN appleId's?

Tested, works great!

thank you @gutenye!


question about LLM and data

It is a great job! I wonder the reason using InternLM-7B instead of LLama based model? You use the InternLM-7B or InternLM-chat-7B ?
And for the training data, you only use the instruction tuning data like LLaVA-Instruct-665K? Any other data for pre-training data is used? like 558K subset of the LAION-CC-SBU dataset?

InternLM is also instruction tuned model with 1.6T multilingual dataset so that it takes an advantage of adaptive language understanding more than Vicuna model. Therefore, it surely outperforms on different languages over english solely. Used InternLM-7B. We used LLaVA-Instruct-665K-based ShareGPT4V which filters LLaVA dataset with more high-caption quality.


Replace our internal I18n coverage code with a gem

https://trello.com/c/s122Fg91/959-we-dont-monitor-unused-and-untested-i18n-translations
This replaces our internal I18n coverage code with a gem that (now)
has the same functionality, bar a few superficial differences in the
format of the JSON report written to 'coverage/i18n.json'.

[x] Tested locally, and still correctly fails the build when coverage is lacking.

@kevindew yup:

CHANGELOG: https://github.com/hiptest/i18n-coverage/blob/master/CHANGELOG.md#020
PR #1: https://github.com/hiptest/i18n-coverage/pull/4
PR #2: https://github.com/hiptest/i18n-coverage/pull/5

Since the original code was mainly a personal project, I decided to spend a bit more time extracting it. I was surprised to find a gem already existed, until I realised it was only created recently.

@kevindew yup:

CHANGELOG: https://github.com/hiptest/i18n-coverage/blob/master/CHANGELOG.md#020
PR #1: hiptest/i18n-coverage#4
PR #2: hiptest/i18n-coverage#5

Since the original code was mainly a personal project, I decided to spend a bit more time extracting it. I was surprised to find a gem already existed, until I realised it was only created recently.

Great stuff Ben 👍  Go open source!
Hope it wasn't too jarring when you found out it already existed. I've had that situation before where it seemingly appears on the internet right at the point you're ready to push all your work.


"ONS-216" after running for a while - rate limiting?

Hi, this is a great project!
I'm wondering if I'm getting rate limited or have another throttle applied? Have you seen anything similar?
I setup the docker-compose project as specified in the README. About 12 hours after starting, I begin to see errors like this in the console:
info: Requesting diagnostics
error: Error {"error":{"message":"Command Failure","request":{"body":"{}","contentType":"application/json; charset=UTF-8","headers":{},"method":0,"url":"https://api.gm.com/api/v1/account/vehicles/VID/requests/41951679867"},"response":{"data":{"commandResponse":{"body":{"error":{"code":"ONS-216","description":"Unable to establish packet session to the vehicle"}},"completionTime":"2023-07-04T01:40:39.020Z","requestTime":"2023-07-04T01:39:38.555Z","status":"failure","type":"diagnostics","url":"https://api.gm.com/api/v1/account/vehicles/VID/requests/41951679867"}},"headers":{"connection":"keep-alive","content-type":"application/json;charset=UTF-8","date":"Tue, 04 Jul 2023 01:40:41 GMT","request-context":"appId=cid-v1:b7e19842-5b19-4b47-a9cf-85cc6e87a746","transfer-encoding":"chunked"},"status":200,"statusText":"OK"},"stack":"Error: Command Failure\n    at RequestService.<anonymous> (/app/node_modules/onstarjs/dist/index.cjs:558:35)\n    at Generator.next (<anonymous>)\n    at fulfilled (/app/node_modules/onstarjs/dist/index.cjs:26:58)\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)"}}

The error payload pulled out:
{
  "error": {
    "code": "ONS-216",
    "description": "Unable to establish packet session to the vehicle"
  }
}

I also noticed I can't refresh data in the myChevrolet app on my device; which makes me think my account is being rate limited, or has some other restriction placed on it. I've stopped the container for now and will try again tomorrow.
Have you seen anything similar?

Thank you! I’m trying to recall when I last started the vehicle, but I’ll try starting it up tomorrow to confirm the behavior, and will reopen if I see anything different.

@BigThunderSR do you know if the myChevroletApp exhibits the same problem? I haven't been able to test recently since the car is in use a lot and getting started anyways.

Does the update portion of the charging modal in the my chevy app not do the same thing?

I thought maybe the chevy app does a subset of diagnostics with its "charging update" refresh so I tried https://github.com/wied03/onstar2mqtt/blob/main/src/index.js#L128 but eventually this also started ONS-216'ing.


(PDOC-30) Fix Markdown parsing lists parsing

The transformer comment matching regex matched all whitespace after a comment.
Lines which were effectively "blank" and just had a comment would be erased.
Markdown lists need to end with a blank line. This messed up markdown
formatting.
The culprit is the regex /^\s*#\s/ which matches all of the comment ' #\n',
however we want to leave the newline alone for markdown to parse.
We replace the regex with /^\s*#[ \t]/ which will only match tabs or spaces
after the hash and leave our beloved newline alone.
Fixes PDOC 30 on JIRA

I will merge this once we sort out the CI failures :+1: