Product Importer-Parameter misses some values after deserialize

Describe the bug
If ImportParameters contains a sub class these parameters are not send back to the server

Closed as it can't be reproduced


Use new subctl implementation

Don't build old subctl in Makefile
Remove pkg/subctl/cmd,benchmark packages
move pkg/subctl/table -> internal/show/table
move pkg/subctl/cmd/utils -> internal/utils

Closes: https://github.com/submariner-io/subctl/issues/10
Signed-off-by: Janki Chhatbar<EMAIL_ADDRESS>

pkg/subctl/datafile should be removed.
pkg/subctl/operator is still used but I can refactor that in another PR.

My focus is only on pkg/subctl/cmd and packages it affects. The other 2 weren't looked upon. Once we start using new subctl and it is built, work on operator upgrading can be started.


CAMEL-13807: Add Component DSL fluent builders

This PR implements components DSL according to CAMEL-13807. Few notes:

To use it to create a component, it can be used like this ComponentsBuilderFactory.kafka().setBrokers("{{host:port}}").build()
Since I needed to maintain the POM file and ComponentsBuilderFactory interface, I used a metadata json file to keep track on the generated DSL classes and update whatever needed.
To set the properties, I used component property configurer since it generates what is needed and I made use of that.
Since I used the metadata file approach, the build speed wasn't impacted much which is good.
If the placeholder needs to be resolved, the component needs to be built with the context being passed as parameter:
ComponentsBuilderFactory.kafka().setBrokers("{{host:port}}").build(camelContext)
There are a lot of shared functionality between endpoinsDslMojo and componentsDslMojo, hence
I have created an abstract class for both and helpers that can be shared in both. However, I left EndpointDslMojo untouched for now. Will remove some shared core once I am done from this PR.

Topics need to be done:

[x] Fix checkstyle.
[x] Add unit tests for the maven plugin generators.
[x] Add more unit tests for camel-componentDsl.
[x] Optimize some classes on the go.

There are a lot of changed files here, would it be possible to just post a snippet of how for example you can use this to configure Kafka, eg you mentioned the camel-kafka-example etc.

Sure, here is an example:
KafkaComponent kafka = ComponentsBuilderFactory.kafka()
                        .brokers("{{kafka.host}}:{{kafka.port}}")
                        .build(camelContext);

Or from the unit tests:
 KafkaComponent kafkaComponent = ComponentsBuilderFactory.kafka()
                .allowManualCommit(true)
                .configuration(kafkaConfiguration)
                .brokers("localhost:9092")
                .build();

Note: In order to resolve the placeholders, the camel context needs to be passed in the build method

Ah thanks, yeah that looks lovely.
For the placeholders then maybe we can have a ComponentsBuilderFactory instance you can dependency inject etc
@Inject
ComponentsBuilderFactory cb

Which will have CamelContext out of the box. But lets wait with this kind and get a first cut implemented first. Looks cool. And it has javadoc on the methods like the endpoint dsl ?

Also there could be a method that registers the component to CamelContext with an optional name etc
.register(camelContext, "mykafka");

Yes, it has everything generated, very similar to the endpointdsl.
Sure, I can add one register API  besides build API. So we can have the following:

Component build()/  Component build(camelContext) -> Build a component and returns back as return type.
void register(camelContext, name)  -> Build and register component to the camel context

@omarsmak , I'm not sure, but looks like you are missing just one thing, there are set of components (a few but important) which contains set of components inside.
For example camel-mail
https://github.com/apache/camel/blob/f33587010d210c9152d1c30e439b5caf75866eaa/components/camel-mail/src/main/java/org/apache/camel/component/mail/MailComponent.java#L39
but ComponentsBuilderFactory set only imap for camel-mail

Ahh, thanks @dmvolod for the hints, I will take a look what we can do about.

@davsclaus @dmvolod I have pushed a new commit with that fixes the component aliases not being generated and add a new register API, e.g:
ComponentsBuilderFactory.kafka()
                        .brokers("{{kafka.host}}:{{kafka.port}}")
                        .register(camelContext, "kafka");

If there is no further comments, I would like to squash and merge this PR today

Yeah I think it seems good, would really like to have this, and we can then improve on it.

The componentdsl cannot compile - error in camel-hdfs. Also camel-jira needs a 3rd part repo (i may add that to the pom.xml).

Also it may be that the generated code in the dsl is not sorted a..z either, eg so when others compile they may get a different order and the code is changed. eg make it sort so components that start with a in the top and so on.

Okay with latest code and doing a full rebuild it seems the camel-hdfs issue is gone.

Yeah that sort issue has to be addressed

btw I wonder if we have a catch-22 situation. That the componentdsl, requires all components to be pre-build, eg what if you have a empty m2 repo and build from 100% scratch

A full rebuild? I am curious about it, let me give a test :D

After merging this each time I rebuild (full rebuild) I'm getting these files modified
modified:   core/camel-componentdsl/pom.xml
modified:   core/camel-componentdsl/src/main/java/org/apache/camel/builder/component/ComponentsBuilderFactory.java
modified:   core/camel-componentdsl/src/main/java/org/apache/camel/builder/component/dsl/SparkComponentBuilderFactory.java
modified:   core/camel-componentdsl/src/main/java/org/apache/camel/builder/component/dsl/WebsocketComponentBuilderFactory.java
modified:   core/camel-componentdsl/src/main/resources/metadata.json
modified:   core/camel-endpointdsl/src/main/java/org/apache/camel/builder/endpoint/dsl/SparkEndpointBuilderFactory.java

Yeah is because of the order. Pushing a fix for it now to have it ordered

@oscerd @omarsmak @davsclaus I'm working on a fix to stabilize the generation while merging those changes in my local branch, I should push very soon.

Hey @gnodet I pushed a PR https://github.com/apache/camel/pull/3541 before saw your message to fix it. If you are already pushed it, please feel free to push it and I can close that PR


Remove autofocus on theme switch when page is loaded

Description
From https://github.com/twbs/bootstrap/pull/37780, when our docs website is loaded, the theme switch gets automatically the focus which causes an issue of a11y since we can't go directly on the skip links.
I suppose that this modification was rather made to only give back the focus to the dropdown when a change is made and not during the init phase.
In order to understand what I'm saying, simply load https://twbs-bootstrap.netlify.app/. The focus (blue outline difficult to see) is automatically on the dropdown, then press Tab; "New in v5.3" will be focused instead of the skip links.
I tried to isolate the init phase in the script to force the focus only after. Please double-check that the a11y modifications made in the previous PR are still OK but it seems so.
Type of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] I have read the contributing guidelines
[x] My code follows the code style of the project (using npm run lint)
[x] My change introduces changes to the documentation
[x] I have updated the documentation accordingly
[x] All new and existing tests passed

Live previews

https://deploy-preview-37836--twbs-bootstrap.netlify.app/

/cc @patrickhlauke since I think he recently made some changes here

oops. my bad @julien-deramond ... missed the fact this triggers on page load already. this PR fixes the issue nicely.


Set default timezone when generate

Expected Behavior
Ask timezone when generate.
Expected Behavior
Currently, if you don't live in Japan you need to edit the timezone of appscript.json.
steps

[ ] add question to sao.js
[ ] edit template/appscript.json
[ ] Remove Configuration section of template/Readme.md

Also see:

https://github.com/mokkabonna/inquirer-autocomplete-prompt/blob/master/example.js
https://www.npmjs.com/package/timezones.json

Asking timezone is not simply.
So, Set timezone of the local system.

fix this
https://github.com/takanakahiko/sao-clasp/commit/b42c54de26e13a947fa46504daaaf470764d8a71


IDirectoryContents doesn't know it's own name or physical path

GetDirectoryContents returns an IDirectoryContents that has an Exists property and an enumeration of files. What it's missing compared to IFileInfo is the Name and PhysicalPath properties.  I can't pass the IDirectoryContents around without wrapping it in my own structure that remembers the name I passed in to retrieve it, and there's no way to get the PhysicalPath except to inspect one of the items in the directory.
Fixing GetFileInfo to support directories would help too (https://github.com/aspnet/Home/issues/2537).
Found while app building for https://github.com/aspnet/AuthSamples/issues/28

@muratg  I am interested to pick this up.

Thanks @kshyju!  @Tratcher, any guidance we can give on how to approach this?

The biggest challenge is that it's a breaking interface change. If we're OK with that then now is the time to do it. Can we use C#8 default interface methods yet?

I assume the default implementation of Name and PhysicalPath simply returns empty string ?

Can we use C#8 default interface methods yet?

Not yet. A quick GitHub search shows that there are indeed some usages of the interface so it would be best to keep the breaking changes to a minimum. Sounds like we could consider taking this when default interface methods land.


[Editor] Tokenizer/lexer refactor

Describe the Feature
Currently, nota's tokenization process is using marked which is a stable open-sourced third-party library that uses RegExp for splitting text into tokens. However, by reading the source code, it still can be improved by serval points:

A lot of string splitting/concatenation when creating each new token.
Each token stores a copy of the string of that token (Instead, we might use index/offset).
Using RegExp might not be the fastest choice.
We might need to design our own version of tokenizer/lexer to improve these flaws.

no need worries for marked


New Theme: Hugo Paper

A simple & clean hugo theme.
link: https://github.com/nanxiaobei/hugo-paper

excuse the long delay. Due to university I had to take a step back from the maintenance of this repository.
I've tested your theme with the build script for Hugo's theme site and noticed that the layout broke on different zoom-levels. The content between the navigation and footer was left-aligned instead of being centered (which I guess is expected).

@digitalcraftsman hi, I've updated the theme, hope you check it again~

That looks great. Your theme should be listed soon on the themes site.
Furthermore, I'll promote your theme on Hugo's official Twitter account.


Problem with custom grad with multiple external variables

Describe the current behavior
The "variables" argument in custom grad seems to be buggy. For example this code, which is a complexified version of the "custom_grad" example in the doc:
import tensorflow as tf
import numpy as np
import time

m=1000

varr=tf.Variable(200.0)
varr3=tf.Variable(200.0)
varr2=tf.constant(1.0)

@tf.function
@tf.custom_gradient
def log1pexp(x1, x2):
  #some basic function fluff
  e=tf.exp(x1)
  e=tf.math.log(1 + e)
  for i in range(m):
  	e += 0.0*tf.exp(x1) + 1.0

  #here comes the problem
  print("tracing")
  def grad(dy, dz, variables=[varr, varr3]):
    return [dy * (1 - 1 / (1 + e)) + 0 * varr2, tf.constant(0.0)], [0.0 * varr, 0.0*varr3]

  return [e+varr, varr3], grad#

x = tf.constant(1.0)
with tf.GradientTape() as g:
  g.watch(x)
  y=log1pexp(x,0.0)

dy_dx = g.gradient(y, x)
print (dy_dx)

Leads to the error:
ValueError: Must return gradient for each variable from @custom_gradient grad_fn.
Which i seem to be doing (log1pexp has 2 inputs, outputs and two external variables, so the return size should be  list of size 2 each ?)
However if I change line 23 to
   return [dy * (1 - 1 / (1 + e)) + 0 * varr2, tf.constant(0.0)], [0.0 * varr]
Then it doesn't give an error, which doesn't make sense to me since in that case, grad_vars only contain gradient info for ONE of the external variables I have registered in the variables parameters.
Also it doesn't care about varr2 at all ...
Describe the expected behavior
The code above should not give error?
Standalone code to reproduce the issue
See above
Other info / logs
Basic ubuntu 20. error with tf 2.2 and 2.3

The issue is that actual_grad_fn receive only 1 variable (in this case e+varr) but two variable_grads:
https://github.com/tensorflow/tensorflow/blob/e798106686903c077d6f082d637f0971da31f20c/tensorflow/python/ops/custom_gradient.py#L507-L508

Are you telling me it's a tf problem or a problem in my code ?
I'm not sure what I should read in the two lines: it seems good. except that the  the two "variables" receives should be varr and varr3, i'm not sure why you said it only receive "e+varr" since it's an output of fn

Yes It was just a type meant varr.
Edit this file locally and try to add print(variables) before the mentioned condition

OK so I've inspected with the code:
  variables_in_tape = frozenset([
    v.ref() for v in variable_watcher.watched_variables()
  ])

and I found something:
In the above code, varr3 is not registered in variables_in_tape seemingly because it's used as an "identity function" and there's no operation involving it
For example if I change my function to return this (just adding 0.0 to varr3 so the function is essentially the same) :
return [e+varr, 0.0+varr3], grad
Then tensorflow will register varr3, and as expected will require me to provide gradient for both varr and varr3.
I'm pretty sure this is not expected behavior from the tensorflow team ... not sure how to escalate but you guys should check this out.

/cc @rohan100jain

@RochMollero
I ran your code on tf 2.3 and nightly, i do not face the error reported above, please find the gist here.

@Saduf2019 The user is asking something different.
/cc @jaingaurav @wangpengmit can you give a feedback here?

@RochMollero
I ran your code on tf 2.3 and nightly, i do not face the error reported above, please find the gist here.

precisely because you ran the working version only. the not working version is when you set
return [e+varr, varr3],
(without the 0.0*)

You're right here. We have some logic that detects what variables are used within a custom_gradient function and that only works when there is actual variable read (https://github.com/tensorflow/tensorflow/blob/master/tensorflow/python/eager/pywrap_tfe_src.cc#L3294) and not when a variable is simply passed through to the output. Right now we don't have plans to fix this immediately, so I'd recommend just doing 1.0*varr or something so that a read is triggered.
On the other hand, contributions are welcome to fix this! One suggestion would be to look at the outputs from running the function (https://github.com/tensorflow/tensorflow/blob/679988320d2f11211cd24ee5a2b18ff52bc04ad7/tensorflow/python/ops/custom_gradient.py#L330) and see if there are any variables we missed and add those to the list.

Was able to reproduce your issue in Tf Nightly 2.6.0-dev20210528, please find the gist here. Thanks!


Handles BUILDKITE_PLUGINS being empty (e.g. no plugins requested)

When no plugins are requested, then BUILDKITE_PLUGINS is not set, causing an error with bash strict mode:

/usr/local/src/buildkite-plugin-whitelister/check-plugins: line 39: BUILDKITE_PLUGINS: unbound variable

Great catch! Thanks for the PR


RHEL-09-232250 and RHEL-09-232255 searches remote file systems rather than local

Describe the Issue
RHEL-09-232250 and RHEL-09-232255 searches remote file systems rather than local for un owned/grouped files
Expected Behavior
Search local file systems for un owned/grouped files
Actual Behavior
Rather than searching locally
Control(s) Affected
What controls are being affected by the issue
Environment (please complete the following information):

branch being used: devel
Ansible Version: 2.15.11
Host Python Version: 3.9.14
Ansible Server Python Version: 3.9.14
Additional Details:

Additional Notes
RHEL-09-232250 and RHEL-09-232255 possibly more
Possible Solution
flip the boolean condition by omitting "not"  in the "not item['device'].startswith('/dev')"  condition

Thanks @uk-bolly!


use prependDirectiveToBuiltFiles from bun-externals

Current dependencies on/for this PR:

main

PR #57   👈

This stack of pull requests is managed by Graphite.


SimpleObjectDetection required column does not exist in table

So in the simpleObjectDetection example when the Soccer_Images_416.sashdat is converted to a CAStable. It has this amount of columns

later the soccer data is then split into trainset and testset and there's no issues.
So I tried using my own data and these are the columns

it's drastically different from soccer data and so I had trouble splitting it into trainset and testset in the later part of the code.

I understand my data columns are incorrect but is there a correct way to generate those missing required columns?
https://github.com/sassoftware/python-dlpy/blob/master/examples/object_detection/SimpleObjectDetection.ipynb

I generated my CASTable using code from https://github.com/michaelgorkow/SAS_DeepLearning/blob/master/Face_Mask_Detection/image_augmentation_object_detection.ipynb .

I do know that in simpleOjectDetection, there's also a PrepareObjectDetectionTable.ipynb but it seems to require xml data which I don't have.

Please add "im_table=False" to your two_way_split().

im_table = false sets the CASTables to be returned with all columns so they're not imagetables. In the later part of the code, it says the image table is created from the training table. But it still able to create the table so how does that work?

Cells 10-14 are for summary and visualization. You don't really need them for training and scoring. You can directly what you get from two_way_split() for traning.

What are you referring to when you say cells 10-14?

https://github.com/sassoftware/python-dlpy/blob/master/examples/object_detection/SimpleObjectDetection.ipynb

Oh ok, I understand what you're referring to now. It's indeed for summary and visualization. So error message won't affect much, would it? Since in the end the tables are still generated

The error is from here: https://github.com/sassoftware/python-dlpy/blob/master/dlpy/images.py#L207
I would suggest you skip it and move to training directly.

So the split of the table into trainset and testset can be skipped?

I'll suggest you keep it so you can use different datasets for training and scoring. Please let me know if you questions are resolved and I'll close the issue.

I have run through the whole code successfully and you can close this issue. Thank you very much for the help.


Versioning Dependencies

Please update XVG dev team.

Changed libdb dependency information in the build guide.
Description

lbdb-dev libdb++-dev

4.8 is not available in debian apt listings, that is why I did that.

but that is why 2 steps before that, we add the bitcoin repository for it ;]

our next codebase has that dep already included though =]


feat: update resources to schema v5.3.0

:tada: This PR is included in version 6.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Release a new version to packagist

This repo is registered in packagist  and gets a good amount of traffic.
https://packagist.org/packages/singpolyma/openpgp-php/stats
We should release the update that fixes the compatibility with phpseclib 2.0.3 so
composer require singpolyma/openpgp-php will install the updated version.
The owner of the package is "vstm" however.

I've created a new tag... maybe packagist will find it automatically?

I believe you have to tell packagist to rescan the repo when you create a new tag. There is a way for it to automatically check but it has to be set up.

If the owner of the package is not you I suggest that you contact packagist to gain ownership of the package. If you do not have the time I can contact them for you and try to handle it.

I've emailed them

Awesome! I hope it works.

done


Add a Nice priority level to Restic.nix

Issue description
Pretty self-explanatory. Rather that dealing with overlays it would be nice (Ahhhh get it?) to be able to adjust priority levels for this service
Technical details
https://github.com/NixOS/nixpkgs/blob/nixos-21.05/nixos/modules/services/backup/restic.nix

Can't you use systemd.services.restic-backups-<name>.serviceConfig.CPUSchedulingPriority=<priority>?


Logout has no effect on query results

After logging out, the app behaves as if the last logged in user is still logged in.
Test: execute query "A list of my favorite books"
(a) not logged in --> no result (OK)
(b) logged in --> result (OK)
(c) logged out --> result (not OK, should have been no result)

todo: on logout: myEngine.invalidateCache()


file upload dont send data to http-url

I'm submitting a...

[ х ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request

Current behavior

I select file from open file dialog, but I can not see a request to webserver from file upload control.
No network activity!
Expected behavior

send file data to server
Minimal reproduction of the problem with instructions
For bug reports please provide the STEPS TO REPRODUCE and if possible a MINIMAL DEMO of the problem via
try use a sample
http://www.amexio.org/showcaseapp/v4/index.html#/fileupload-demo
What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z

Browser:
- [ XX] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [XX ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version:8.4.0
- Platform:   Windows 10

Others:

We are working on this issue. Will get back to you asap.

This issue has been fixed and will be available on v4.0.8 97b4ffa590b6fd39eb29effda5e170945cc24761


handles relative and absolute paths correctly #42

Refers to #42

Thanks for your contribution! I'm sorry, I overlooked your PR and implemented this fix myself in 1.2.6, but the fix was based on your suggestion.


[Feature Request] Copy data on other formats

Hey, me again.
I just want to request, if possible, ability of copy the data in other formats, like json, csv or sql (insert/replace statement).
For example, if I query select name, age from users limit 2 and get the following result:

name
age

william
26

serge-rider
33

If I select all the rows, when I copy (ctrl + c) put the following content on the clipboard
insert into table (name, age) values ("william", 26);
insert into table (name, age) values ("serge-rider", 333);

Or even other formats, like a json
[
    {"name": "william", "age": 26},
    {"name": "serge-rider", "age": 33}
]

DataGrip (from jetbrains) has this feature and I think it's very useful. Could be a plus to dbeaver :)

This feature is already implemented. Even twice:

You can use "Export Resultset" feature (in the context menu). You can make export in any format and copy results into clipboard.
You can use "Generate SQL" feature (for selected rows).

Oh, I see. My bad :)
Thanks again!


USHIFT-1084 Restore backup if previous was unhealthy

/retest

re: https://github.com/openshift/microshift/pull/1881#discussion_r1218449482

If the cp fails, then recovery is ... rm -rf /var/lib/microshift

Removing the files as an automated response to an error could potentially remove some of the information needed to figure out what the error happened in the first place - another move operation might be safer (assuming that running out of disk space isn't the error which caused the problem)


Pdc 1007 update references to release component

Detail see: https://github.com/release-engineering/product-definition-center/commit/eca6b61d03be11851724e9523f0fcda1b3c8bb01

Looks good to me. I don't know why coveralls gets stuck, their status page is not very descriptive. We can just ignore it for now.

coveralls come back :-)


Set maximum limit of 10k for GUID generation

Closes #275
Pull request type
Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Internationalization and localization
[ ] Other (please describe):

What is the current behavior?

Issue Number: #275
What is the new behavior?

You cannot generate more than 10.000 GUIDs

Quality check
Before creating this PR, have you:

[x] Followed the code style guideline as described in CONTRIBUTING.md
[x] Verified that the change work in Release build configuration
[x] Checked all unit tests pass

Hello,
Thank you for your contribution.


CORE-2318 Add support for converting BigDecimal objects to a SQL string via DataTypeFactory

CORE-2318 Add support for converting BigDecimal objects to a SQL string via DataTypeFactory

Yes, looks fine for 3.3.x. Merged in


Merge x64 and x86 Adobe Acrobat Reader installers

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

If that's ok, let me know, and I will create PRs for older version and separate x64 packages.

If that's ok, let me know, and I will create PRs for older version and separate x64 packages.

@mda since https://github.com/microsoft/winget-pkgs/issues/32785#issuecomment-956495573 and https://helpx.adobe.com/acrobat/kb/about-acrobat-reader-dc-migration-to-64-bit.html.
But in https://github.com/microsoft/winget-pkgs/pull/40297#issuecomment-1008152647 @OfficialEsco mentioned that two separate PackageIDs are needed. @OfficialEsco, can you tell if there is a reason to leave two separate PackageIDs or can they be combined by simply removing AppsAndFeaturesEntries from the manifest?

Ohboi there have been so many changes with the Adobe Acrobat Reader package...
Technically; If a Package can be installed Side-By-Side they should be separate. (Atleast when i was actively validating packages (2 years ago))
IIRC there was a difference (DisplayName?) between the x64 and x86 AND the MUI installation. However yes this can be fixed with the ARP field now days.
Just to note; You're not allowed to move a package, it has to be delete/create PRs

@mdanish-kh @OfficialEsco just checked, they cannot be installed at the same time, only one version. If you install the x86 version first and then try to install it on top of x64, it will automatically update to x64 in silent mode, and in interactive mode it will prompt you to do this:

If canceled, only the x86 version will remain.
If the x64 version was installed, then x86 simply will not be installed:

I googled and most of the answers were that there is no difference between applications with different architectures.
But yes, x86 and x64 have different DisplayName, Publisher, ProductCode. I was able to add ProductCode to Installers, but can I do the same for DisplayName and Publisher?

If that is indeed the case, merging the PackageIds seems to be a viable option. (Perhaps the installers behaved differently in the past and have now got updated?)
I'm out for a couple of days... so I can't test this right now in my VM. I would also like to add some other folks into the loop

@PckgrBot who reported the two arches behave differently on element
@Trenly (originally broke the package into different IDs)

As @mdanish-kh mentioned there has already been a lot of automation and scripting built around the two separate installers (me included) so it would be a huge impact to change it.
The other factor is these installs work very differently, as you know the 32 bit can only really be reader but the 64 bit can have different SCAPackageLevel depending on if it's reader, standard or pro. Is there a huge benefit in changing this now? I think it should be considered about how many workflows a change to the structure can make.

There is also the aspect of currently installed architecture. Because of what @PckgrBot mentioned, it would be best to leave users on the architecture they currently have installed. I'd be worried that if we merge the packages, then there would be more issues with matching the currently installed architecture and ensuring users receive the correct upgrade package. There might be ways to get around this with AppsAndFeaturesEntries, but given the history here with Adobe, it may be best to keep them separate

@PckgrBot @Trenly as far as I understand, two manifestos were originally made, since Manifest 1.0.0 did not support multiple architectures at the same time. Then they were apparently separated again, since it was possible to install x86 and x64 versions at the same time.
But for a long time the manifest has supported several architectures simultaneously, and Adobe since February 2021 (version 21.xxx.xxxxx and later) is gradually migrating to x64 versions, and does not allow applications from x86 and x64 to be installed simultaneously (I checked this with the earliest available 21.xxx.xxxxx in winget x86 and x64 versions). Apparently there were problems with the 2020 version (20.xxx.xxxxx), since even on the Adobe website they are highlighted as separate products.
As for the fact that x64 Acrobat Reader is both Acrobat Standard/Pro, I don’t see a problem here, since most users use the free Reader version anyway.
In addition to ProductCode, I also added DisplayName and Publisher to the manifest, validation passed. InstallerType: msi was also previously specified, apparently because ProductCode only works for them. If necessary, I can also add InstallerType.

@stephengillie

@ stephengillie

Hi @rakleed,
There's more discussion than information in this PR comment thread. The question is: "Should these installers be merged into a single manifest?"

Can these be installed side-by-side? If so they should be separate, if no they should not.
x86 seems to be losing support going forward, so will need to be removed at some point.

It sounds like - instead of merging them, we should depreciate the x86 version.
This situation seems similar to when Git.Git depreciated their x86 version, starting with putting a message in their x86 package telling users to upgrade - it couldn't be skipped or made silent by installer switch. There, we had no option but to drop the x86 version from the manifest. Here, Adobe have been working on this for 3 years.
Do we have many users of this software who are currently using a 32-bit OS and CPU? Or are most users running the 32-bit version on a 64-bit OS?


github flavored markdown to support task lists

Currently github_flavored_markdown is not supporting tasks list
(https://github.com/blog/1375
-task-lists-in-gfm-issues-pulls-comments)
Can you please add that functionality?

This is already done in 2b74a5b054c18cbdf8589529327a7f9feba8b205.


Add option to drop extension db at un-install time or later

Requested here: https://github.com/lnbits/lnbits/issues/1709
Summary

by default when an extension is un-installed, all the data is still stored on the LNbits DB
sometimes admin users might want to also remove all the data. Some reasons:

there was a corrupt migration file and now the extension cannot be upgraded/reinstalled
the existing data was created for demo/testing purposes and should be dropped
...

This PR adds a Remove Database option at un-install time, or later.
Tests Steps

see flow in screen recording below
use both Postgres and SQLite

Uninstall and Drop DB
https://github.com/lnbits/lnbits/assets/2951406/8cc29d63-5698-4fba-90ee-152b5a9404a6
Drop DB after Uninstall
https://github.com/lnbits/lnbits/assets/2951406/8d6d279d-842e-430d-abb3-de8a97b5539f

Codecov Report

Merging #1746 (7e22e28) into main (af660fe) will decrease coverage by 0.13%.
The diff coverage is 24.24%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main    #1746      +/-   ##
==========================================
- Coverage   49.08%   48.96%   -0.13%
==========================================
  Files          47       47
  Lines        7112     7144      +32
==========================================
+ Hits         3491     3498       +7
- Misses       3621     3646      +25

Impacted Files
Coverage Δ

lnbits/core/views/api.py
36.45% <14.28%> (-0.67%)
:arrow_down:

lnbits/db.py
82.93% <25.00%> (-1.43%)
:arrow_down:

lnbits/core/crud.py
63.05% <30.00%> (-1.54%)
:arrow_down:

lnbits/core/views/generic.py
52.12% <100.00%> (+0.25%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add recovery rate & mortality rate to the dashboard

Problem:
Currently the dashboard displays the numbers (active, confirmed etc) but it doesn't show various rates such as recovery rate, mortality rate etc. These figures could be quite useful.
Solution:
Add recovery and mortality rate to the dashboard. These can be calculated using simple division.
Recovery Rate = Total Recovered / Total Confirmed * 100
Mortality Rate = Total Deaths / Total Confirmed * 100
This could be at country level as well as state level.
Additionally we could also show these rates on a per day basis to understand the trend over a period of time. Although this might not be as useful as the overall recovery rate, it is worth considering

Is this available to pick up?

Is this available to pick up?

Yes available

/claim

Is it completed or is someone working on it....i am looking for my first contribution. thanks !

The status was still on Review needed, so I left it. You can pick it up if you like. @navkumar258

Duplicate of #1984

Hi team, tried to take it up, got it compiled and running as expected on my machine. thanks 😄


Using a logic analyzer to analyze the runtime sequence routines

I want to use a logic analyzer to measure the relevant timing parameters:

The time to initialize the DS18B20 and monitor the online information
The time to wait for the DS18B20 to release the bus
The time to trigger the temperature conversion
The time to send the read data command
The time to read the register value and obtain the temperature value

According to the datasheet, their units should be in microseconds (us), but my actual measurements are in milliseconds (ms).
How should I modify my measurement method?
Here is my code:
#include <OneWire.h>
#include <DallasTemperature.h>

#define ONE_WIRE_BUS 2

OneWire oneWire(ONE_WIRE_BUS);

DallasTemperature sensors(&oneWire);

DeviceAddress DS18B20_ID;

void setup() {
  Serial.begin(9600);

  unsigned long initStartTime = micros();

  sensors.begin();

  unsigned long initEndTime = micros();

  Serial.print("Initialization Time: ");
  Serial.print(initEndTime - initStartTime);
  Serial.println(" us");
}

void loop() {
  if (Serial.available() > 0) {
    String command = Serial.readStringUntil('\n');
    command.trim();

    if (command == "GET") {
      unsigned long waitStartTime = micros();

      delayMicroseconds(550);

      unsigned long waitEndTime = micros();

      unsigned long convStartTime = micros();

      sensors.requestTemperatures();

      unsigned long convEndTime = micros();

      unsigned long readCmdStartTime = micros();

      float temperature = sensors.getTempCByIndex(0);

      unsigned long readCmdEndTime = micros();

      unsigned long readRegStartTime = micros();

      Serial.print("Temperature: ");
      Serial.print(temperature);
      Serial.println(" C");

      unsigned long readRegEndTime = micros();

      Serial.print("Wait for Bus Release Time: ");
      Serial.print(waitEndTime - waitStartTime);
      Serial.println(" us");

      Serial.print("Trigger Conversion Time: ");
      Serial.print(convEndTime - convStartTime);
      Serial.println(" us");

      Serial.print("Send Read Command Time: ");
      Serial.print(readCmdEndTime - readCmdStartTime);
      Serial.println(" us");

      Serial.print("Read Register Value Time: ");
      Serial.print(readRegEndTime - readRegStartTime);
      Serial.println(" us");
    } else {
      Serial.println("Unknown command.");
    }
  }
}

Two tips.
Flush serial before measurements
Do all your measurements before printing the results

Two tips.
Flush serial before measurements Do all your measurements before printing the results

I tried the second method, but the actual effect still seems incorrect, especially with the Trigger Conversion Time and Send Read Command Time.

According to the datasheet, their units should be in microseconds (us), but my actual measurements are in milliseconds (ms).
How should I modify my measurement method?

Your code does measure in microseconds.

I tried both methods, but neither seems to work for me.

What is wrong with the numbers?
Are they different than you expect?
If so, what numbers do you expect?
Think you should read the datasheet carefully as it does mentions variation on the numbers.
E.g. the conversion time for 12 bit is max 750 ms which is based upon the worst case conversion (and maybe even a bit extra).

I slightly modified your code, as you do not take into account that printing variables and strings takes time and these affect your measurements. The code below is a bit more stable as it adds delays to wait until the serial output buffer is empty.
Note that there are always variations per call, so you might need to execute your tests 100 times and take the average.
Furthermore you need to know that micro() has a resolution of 4 us. So it will never return 550.
(and it will add the overhead of the function call).
#include <OneWire.h>
#include <DallasTemperature.h>

#define ONE_WIRE_BUS 2

OneWire oneWire(ONE_WIRE_BUS);

DallasTemperature sensors(&oneWire);

DeviceAddress DS18B20_ID;

void setup()
{
  Serial.begin(9600);
  while(!Serial);  //  wait until Serial device is ready.
  Serial.println(__FILE__);
  delay(100);  //  wait until output buffer of Serial is empty.

  unsigned long initStartTime = micros();

  sensors.begin();
  sensors.setResolution(12);  //  force an explicit resolution, 9..12

  unsigned long initEndTime = micros();

  Serial.print("Initialization Time: ");
  Serial.print(initEndTime - initStartTime);
  Serial.println(" us");
  delay(100);  //  wait until output buffer of Serial is empty.
}

void loop()
{
  if (Serial.available() > 0)
  {
    String command = Serial.readStringUntil('\n');
    command.trim();
    if (command == "GET")
    {
      delay(100);  //  wait for Serial output empty.

      //  why measure this?
      unsigned long waitStartTime = micros();
      delayMicroseconds(550);
      unsigned long waitEndTime = micros();

      unsigned long convStartTime = micros();
      sensors.requestTemperatures();
      unsigned long convEndTime = micros();

      unsigned long readCmdStartTime = micros();
      float temperature = sensors.getTempCByIndex(0);
      unsigned long readCmdEndTime = micros();

      //  here you measure the time to put the strings
      //  in the serial output buffer. not the print time.
      unsigned long readRegStartTime = micros();
      Serial.print("Temperature: ");
      Serial.print(temperature);
      Serial.println(" C");
      unsigned long readRegEndTime = micros();

      Serial.print("Wait for Bus Release Time: ");
      Serial.print(waitEndTime - waitStartTime);
      Serial.println(" us");

      Serial.print("Trigger Conversion Time: ");
      Serial.print(convEndTime - convStartTime);
      Serial.println(" us");

      Serial.print("Send Read Command Time: ");
      Serial.print(readCmdEndTime - readCmdStartTime);
      Serial.println(" us");

      Serial.print("Read Register Value Time: ");
      Serial.print(readRegEndTime - readRegStartTime);
      Serial.println(" us");
    } else {
      Serial.println("Unknown command.");
    }
  }
  delay(1000); // wait for all output to be done
}

根据数据表，它们的单位应该是微秒（us），但我的实际测量单位是毫秒（ms）。
我应该如何修改我的测量方法？

您的代码确实以微秒为单位进行测量。

我尝试了这两种方法，但似乎都不适用于我。

这些数字有什么问题？ 它们和你的预期有差异吗？ 如果是，你预期的数字是多少？
你应该仔细阅读数据表，因为它确实提到了数字的变化。 例如，12 位的转换时间最大为 750 毫秒，这是基于最坏情况的转换（甚至可能有点多）。
我稍微修改了您的代码，因为您没有考虑到打印变量和字符串需要时间，而这些会影响您的测量。下面的代码更稳定一些，因为它增加了延迟以等待串行输出缓冲区为空。
请注意，每次调用总会有变化，因此您可能需要执行 100 次测试并取平均值。
此外，您需要知道**micro()**的分辨率为 4 us。因此它永远不会返回 550。 （并且它会增加函数调用的开销）。
#include <OneWire.h>
#include <DallasTemperature.h>

#define ONE_WIRE_BUS 2

OneWire oneWire(ONE_WIRE_BUS);

DallasTemperature sensors(&oneWire);

DeviceAddress DS18B20_ID;

void setup()
{
  Serial.begin(9600);
  while(!Serial);  //  wait until Serial device is ready.
  Serial.println(__FILE__);
  delay(100);  //  wait until output buffer of Serial is empty.

  unsigned long initStartTime = micros();

  sensors.begin();
  sensors.setResolution(12);  //  force an explicit resolution, 9..12

  unsigned long initEndTime = micros();

  Serial.print("Initialization Time: ");
  Serial.print(initEndTime - initStartTime);
  Serial.println(" us");
  delay(100);  //  wait until output buffer of Serial is empty.
}

void loop()
{
  if (Serial.available() > 0)
  {
    String command = Serial.readStringUntil('\n');
    command.trim();
    if (command == "GET")
    {
      delay(100);  //  wait for Serial output empty.

      //  why measure this?
      unsigned long waitStartTime = micros();
      delayMicroseconds(550);
      unsigned long waitEndTime = micros();

      unsigned long convStartTime = micros();
      sensors.requestTemperatures();
      unsigned long convEndTime = micros();

      unsigned long readCmdStartTime = micros();
      float temperature = sensors.getTempCByIndex(0);
      unsigned long readCmdEndTime = micros();

      //  here you measure the time to put the strings
      //  in the serial output buffer. not the print time.
      unsigned long readRegStartTime = micros();
      Serial.print("Temperature: ");
      Serial.print(temperature);
      Serial.println(" C");
      unsigned long readRegEndTime = micros();

      Serial.print("Wait for Bus Release Time: ");
      Serial.print(waitEndTime - waitStartTime);
      Serial.println(" us");

      Serial.print("Trigger Conversion Time: ");
      Serial.print(convEndTime - convStartTime);
      Serial.println(" us");

      Serial.print("Send Read Command Time: ");
      Serial.print(readCmdEndTime - readCmdStartTime);
      Serial.println(" us");

      Serial.print("Read Register Value Time: ");
      Serial.print(readRegEndTime - readRegStartTime);
      Serial.println(" us");
    } else {
      Serial.println("Unknown command.");
    }
  }
  delay(1000); // wait for all output to be done
}

Oh, thank you so much! After reading your reply, I realized that my consideration was indeed not very comprehensive. Below is the table representing the results I expect to achieve:

data
time (us)

The time to initialize the DS18B20 and monitor the online information
610

The time to wait for the DS18B20 to release the bus
550

The time to trigger the temperature conversion
887

The time to send the read data command
886

The time to read the register value and obtain the temperature value
560

According to the datasheet, their units should be in microseconds (us), but my actual measurements are in milliseconds (ms).
How should I modify my measurement method?

Your code does measure in microseconds.

I tried both methods, but neither seems to work for me.

What is wrong with the numbers? Are they different than you expect? If so, what numbers do you expect?
Think you should read the datasheet carefully as it does mentions variation on the numbers. E.g. the conversion time for 12 bit is max 750 ms which is based upon the worst case conversion (and maybe even a bit extra).
I slightly modified your code, as you do not take into account that printing variables and strings takes time and these affect your measurements. The code below is a bit more stable as it adds delays to wait until the serial output buffer is empty.
Note that there are always variations per call, so you might need to execute your tests 100 times and take the average.
Furthermore you need to know that micro() has a resolution of 4 us. So it will never return 550. (and it will add the overhead of the function call).
#include <OneWire.h>
#include <DallasTemperature.h>

#define ONE_WIRE_BUS 2

OneWire oneWire(ONE_WIRE_BUS);

DallasTemperature sensors(&oneWire);

DeviceAddress DS18B20_ID;

void setup()
{
  Serial.begin(9600);
  while(!Serial);  //  wait until Serial device is ready.
  Serial.println(__FILE__);
  delay(100);  //  wait until output buffer of Serial is empty.

  unsigned long initStartTime = micros();

  sensors.begin();
  sensors.setResolution(12);  //  force an explicit resolution, 9..12

  unsigned long initEndTime = micros();

  Serial.print("Initialization Time: ");
  Serial.print(initEndTime - initStartTime);
  Serial.println(" us");
  delay(100);  //  wait until output buffer of Serial is empty.
}

void loop()
{
  if (Serial.available() > 0)
  {
    String command = Serial.readStringUntil('\n');
    command.trim();
    if (command == "GET")
    {
      delay(100);  //  wait for Serial output empty.

      //  why measure this?
      unsigned long waitStartTime = micros();
      delayMicroseconds(550);
      unsigned long waitEndTime = micros();

      unsigned long convStartTime = micros();
      sensors.requestTemperatures();
      unsigned long convEndTime = micros();

      unsigned long readCmdStartTime = micros();
      float temperature = sensors.getTempCByIndex(0);
      unsigned long readCmdEndTime = micros();

      //  here you measure the time to put the strings
      //  in the serial output buffer. not the print time.
      unsigned long readRegStartTime = micros();
      Serial.print("Temperature: ");
      Serial.print(temperature);
      Serial.println(" C");
      unsigned long readRegEndTime = micros();

      Serial.print("Wait for Bus Release Time: ");
      Serial.print(waitEndTime - waitStartTime);
      Serial.println(" us");

      Serial.print("Trigger Conversion Time: ");
      Serial.print(convEndTime - convStartTime);
      Serial.println(" us");

      Serial.print("Send Read Command Time: ");
      Serial.print(readCmdEndTime - readCmdStartTime);
      Serial.println(" us");

      Serial.print("Read Register Value Time: ");
      Serial.print(readRegEndTime - readRegStartTime);
      Serial.println(" us");
    } else {
      Serial.println("Unknown command.");
    }
  }
  delay(1000); // wait for all output to be done
}

Oh, thank you so much! After reading your reply, I realized that my consideration was indeed not very comprehensive. Below is the table representing the results I expect to achieve:

data
time (us)

The time to initialize the DS18B20 and monitor the online information
610

The time to wait for the DS18B20 to release the bus
550

The time to trigger the temperature conversion
887

The time to send the read data command
886

The time to read the register value and obtain the temperature value
560


Renaming animation node renders blend tree unusable

Godot version:
master / 80a8636a
OS/device including version:
Manjaro Linux 17.1
Issue description:
When renaming an animation node inside a blend tree, the connections disappear upon saving the file and it fails to open again due to broken node references.
Manually editing the content of .tres or .tscn file that contains the blend tree seems to be the only safe method for renaming animation nodes for now.

Duplicate of #20210.


Minify_HTML fails on long strings in

Minify commit/version:
PHP version: 5.2.6

What steps will reproduce the problem?
1. Using Minify_HTML try to compress attached compressing_ok.html &
compressing_fails.html
2. See that compressing_fails.html minimizes to empty string
3. See difference between compressing_ok.html & compressing_fails.html

Expected output:

Original data

Actual output:

In compressing_ok.html - original data
In compressing_fails.html - empty string

Original issue reported on code.google.com by barbushin on 9 Jun 2012 at 2:31
Attachments:

compressing_ok.html
compressing_fails.html

I found that this bug can be fixed by <?php ini_set('pcre.backtrack_limit',
999999999) see http://www.php.net/manual/en/pcre.configuration.php.

May be you should add this option to Minify_HTML configuration.
Cheers!

Original comment by barbushin on 14 Jun 2012 at 10:16


➕ Add new flairs

This pull request is to help the pull request mentioned here: https://github.com/benawad/vscode-stories/pull/44

I'm not going to validate flair on server anymore

Okay that’s great 😁


Failed to broadcast: Request failed with status code 503

I cannot delete a validator with ZERO Delegation.
I can not Enable restacking
Error: Failed to broadcast: Request failed with status code 503

Fix coming for the 0 delegations.
The 503 error means the node was down - could you try again and let me know if that's solved?


Update wufb-reports-admin-center-permissions.md

Made changes to the permissions needed
Reference - MC397469
fixes #https://github.com/MicrosoftDocs/windows-itpro-docs/issues/10757

@JohanFreelancer9 Please copy review

@yogkumgit The author is mstewart

Learn Build status updates of commit 3ebe87b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows/deployment/update/includes/wufb-reports-admin-center-permissions.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@mestew Kindly update. Thanks

This edit is not correct. The target doc is only for the Windows tab within the Software Updates page in the admin center. For instance, the Azure AD role of Office Apps Administrator wouldn't have access to the Windows tab without one of the other roles such as Windows updates deployment administrator* being assinged to the user as well.  Same thing for the other roles that were added such as Exchange Admin.


failed test for error control from nested function

Hi Mamod, I've detected a problem depicted in the last subtest of this test file. Errors thrown (with die()) in nested calls will either hang or just abort completely. Can you take a look or guide me in the right direction so I can fix it?
Thanks!
Rod

Thank you very much for the test, this has been fixed in #8
can you please add Test::Fatal to MakeFile.pl "TEST_REQUIRES" as it's not a core module, I want to merge this with one commit :)

Thanks Mamod, I'm preparing the next pull request with the TEST_REQUIRES dependency.
But in the meanwhile, I was testing master with my own app, and detected a strange behavior with try-tiny not present in v0.3.0. I'm adding a test case for that too.

oops, I've been messing with the master :)
are you able to fix the conflict, or you can create a new pull request.
Sorry :(

@rodrigolive no worries, I did resolve the conflict but your name doesn't appear in the contribution list, by viewing the commit patch it appears that you're using a different user name and email address than those of your github account, you can fix this by adding a secondary email address, I guess!!


viewer.flyTo and viewer.zoomTo give different results in 2D and CV

flyTo always orients north, but zoomTo applies the specified heading.  The doc seems to indicate this is by design (at least for 2D).  But it also happens for CV.  Why do it at all?  I think flyTo should take the heading into account, just like zoomTo does.
While the below example uses the viewer commands, the actual behavior is defined in the camera.flyToBoundingSphere method.
var viewer = new Cesium.Viewer('cesiumContainer', { sceneMode : Cesium.SceneMode.SCENE2D });

var redRectangle = viewer.entities.add({
    name : 'Red translucent rectangle with outline',
    rectangle : {
        coordinates : Cesium.Rectangle.fromDegrees(-110.0, 20.0, -80.0, 25.0),
        material : Cesium.Color.RED.withAlpha(0.5),
        outline : true,
        outlineColor : Cesium.Color.RED
    }
});

Sandcastle.addToolbarButton('zoomTo', function() {
    viewer.zoomTo(redRectangle, new Cesium.HeadingPitchRange(Math.PI / 2, -Math.PI / 4, 4000000));
});

Sandcastle.addToolbarButton('flyTo', function() {
    viewer.flyTo(redRectangle, {
        offset : new Cesium.HeadingPitchRange(Math.PI / 2, -Math.PI / 4, 4000000)
    });
});

This came up on the forum: https://groups.google.com/forum/?hl=en#!topic/cesium-dev/EbCim-p6jmI

We need different behavior for mapMode2D: Cesium.MapMode2D.ROTATE.  Right now, zoomTo rotates the map but flyTo does not.  It should rotate the map for both if  Cesium.MapMode2D.ROTATE and neither otherwise

Also reported here: https://groups.google.com/forum/?hl=en#!searchin/cesium-dev/wrong$20viewpoint|sort:date/cesium-dev/MSPOj17Iqcg/dtbDsrUdBgAJ


Can't install opencv on Windows 8.1, x64

Hello everyone, i have some issue with installing opencv on my machine:

The machine setup:

Windows 8.1 Pro, x64 (Intel N3540)

What i want:

I want to install Opencv on my laptop and use it in my projects, but i have this errors:

C:\Windows\system32>vcpkg install opencv
The following packages will be built and installed:

libjpeg-turbo[core]:x86-windows
liblzma[core]:x86-windows
libpng[core]:x86-windows
opencv[core]:x86-windows
protobuf[core]:x86-windows
tiff[core]:x86-windows
Additional packages (*) will be modified to complete this operation.
Starting package 1/6: liblzma:x86-windows
Building package liblzma[core]:x86-windows...
-- CURRENT_INSTALLED_DIR=C:/LIBS_ETC/vcpkg/installed/x86-windows
-- DOWNLOADS=C:/LIBS_ETC/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/LIBS_ETC/vcpkg/packages/liblzma_x86-windows
-- CURRENT_BUILDTREES_DIR=C:/LIBS_ETC/vcpkg/buildtrees/liblzma
-- CURRENT_PORT_DIR=C:/LIBS_ETC/vcpkg/ports/liblzma/.
-- Using cached C:/LIBS_ETC/vcpkg/downloads/xz-5.2.3.tar.gz
-- Testing integrity of cached file...
CMake Error at C:/LIBS_ETC/vcpkg/scripts/cmake/vcpkg_download_distfile.cmake:87
(message):

File does not have expected hash:
      File path: [ C:/LIBS_ETC/vcpkg/downloads/xz-5.2.3.tar.gz ]
  Expected hash: [ a5eb4f707cf31579d166a6f95dbac45cf7ea181036d1632b4f123a407

2f502f8d57cd6e7d0588f0bf831a07b8fc4065d26589a25c399b95ddcf5f73435163da6 ]
Actual hash: [ 3b53ccf0243cd4a6a731a898bfdba95c3d22342e7e64f9e9a4a2bce5f
74ac809943f570ed92c9077101a178f82f49ece1d1c4bfee1f288ea61d99fb36f6a243e ]
Please delete the file and retry if this file should be downloaded again.
Call Stack (most recent call first):
C:/LIBS_ETC/vcpkg/scripts/cmake/vcpkg_download_distfile.cmake:99 (test_hash)
C:/LIBS_ETC/vcpkg/ports/liblzma/portfile.cmake:7 (vcpkg_download_distfile)
C:/LIBS_ETC/vcpkg/scripts/ports.cmake:72 (include)
Error: Building package liblzma:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: liblzma:x86-windows
Vcpkg version: 0.0.102-2018-01-24-7d9f0a86974a85b94d9a903f130a933e44c76f43
Additionally, attach any relevant sections from the log files above.

If i want to install liblzma (as i understood by stack of calling errors) i get similar errors:

C:\Windows\system32>vcpkg install liblzma
Your feedback is important to improve Vcpkg! Please take 3 minutes to complete o
ur survey by running: vcpkg contact --survey
The following packages will be built and installed:
liblzma[core]:x86-windows
Starting package 1/1: liblzma:x86-windows
Building package liblzma[core]:x86-windows...
-- CURRENT_INSTALLED_DIR=C:/LIBS_ETC/vcpkg/installed/x86-windows
-- DOWNLOADS=C:/LIBS_ETC/vcpkg/downloads
-- CURRENT_PACKAGES_DIR=C:/LIBS_ETC/vcpkg/packages/liblzma_x86-windows
-- CURRENT_BUILDTREES_DIR=C:/LIBS_ETC/vcpkg/buildtrees/liblzma
-- CURRENT_PORT_DIR=C:/LIBS_ETC/vcpkg/ports/liblzma/.
-- Using cached C:/LIBS_ETC/vcpkg/downloads/xz-5.2.3.tar.gz
-- Testing integrity of cached file...
CMake Error at C:/LIBS_ETC/vcpkg/scripts/cmake/vcpkg_download_distfile.cmake:87
(message):
File does not have expected hash:
      File path: [ C:/LIBS_ETC/vcpkg/downloads/xz-5.2.3.tar.gz ]
  Expected hash: [ a5eb4f707cf31579d166a6f95dbac45cf7ea181036d1632b4f123a407

2f502f8d57cd6e7d0588f0bf831a07b8fc4065d26589a25c399b95ddcf5f73435163da6 ]
Actual hash: [ 3b53ccf0243cd4a6a731a898bfdba95c3d22342e7e64f9e9a4a2bce5f
74ac809943f570ed92c9077101a178f82f49ece1d1c4bfee1f288ea61d99fb36f6a243e ]
Please delete the file and retry if this file should be downloaded again.
Call Stack (most recent call first):
C:/LIBS_ETC/vcpkg/scripts/cmake/vcpkg_download_distfile.cmake:99 (test_hash)
C:/LIBS_ETC/vcpkg/ports/liblzma/portfile.cmake:7 (vcpkg_download_distfile)
C:/LIBS_ETC/vcpkg/scripts/ports.cmake:72 (include)
Error: Building package liblzma:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: liblzma:x86-windows
Vcpkg version: 0.0.102-2018-01-24-7d9f0a86974a85b94d9a903f130a933e44c76f43
Additionally, attach any relevant sections from the log files above.

P. S. vcpkg is the best what i see for rapid code developing on C++, i'am already install by this boost, boost beast and it's works fine. It will be a great job if anyone help me with that issue.

download file does not have expected hash,this may be something wrong with you download file.
you can delete the file and retry if this file should be downloaded again.  or
check if  C:/LIBS_ETC/vcpkg/downloads/xz-5.2.3.tar.gz  file is correct!

@ReyzalX thanks! It's helped me!

Installing package opencv[core]:x86-windows... done
Elapsed time for package opencv:x86-windows: 53.55 min
Total elapsed time: 1.194 h

Test project works well :)


Possible issue with dotnet vstest

Hi,
I come from XUnit and on the console the tests work perfectly with dotnet test.
In the CI/CD process, I have a build stage in which the project and the test project are created in different directories (e.g. test_output and build_output).
I then always start the unit tests in the test stage with
dotnet vstest test_output/FancyProjectTests.dll --logger ‘trx;LogFileName=TestResults.trx’
This does not work, the error message is:
Error:
  An assembly specified in the application dependencies manifest (testhost.deps.json) was not found:
    package: ‘Newtonsoft.Json’, version: ‘13.0.3’
    path: ‘lib/netstandard2.0/Newtonsoft.Json.dll’
. Please check the diagnostic logs for more information.

When I run the command on my PC, I get the same error. The same project compiled as XUnit works fine this way.
I have added the Newtonsoft.Json 13.03 version to my test project via Nuget for testing, but without success, the error still occurs.
Regards
Laszlo

Short update,
even when i try dotnet test test_output/FancyProjectTests.dll from my CI-Test-Stage or from the console the error occurs.
Sorry, output partly in german...
dotnet vstest FancyProjectTests.dll
VSTest-Version 17.11.0 (arm64)

Die Testausführung wird gestartet, bitte warten...
Insgesamt 1 Testdateien stimmten mit dem angegebenen Muster überein.
Error:
  An assembly specified in the application dependencies manifest (testhost.deps.json) was not found:
    package: 'Newtonsoft.Json', version: '13.0.1'
    path: 'lib/netstandard2.0/Newtonsoft.Json.dll'
Der TestHost-Prozess für die Quelle(n) /Users/user/projekte/fancyproject/fancyprojecttest/bin/Release/net8.0/FancyProjectTest.dll wurde mit folgendem Fehler beendet: Error:
  An assembly specified in the application dependencies manifest (testhost.deps.json) was not found:
    package: 'Newtonsoft.Json', version: '13.0.1'
    path: 'lib/netstandard2.0/Newtonsoft.Json.dll'
. Weitere Informationen finden Sie in den Diagnoseprotokollen.

Testlauf abgebrochen.

I can start the command dotnet test with the option -d <DiagFile.txt>. Is it helpful for you if I provide you with the file?

Heya.
So VSTest was the old Microsoft test runner.
TUnit is built on top of the newer Microsoft.Testing.Platform. It doesn't even know about VSTest.
This means your VSTest commands won't work.
You can use dotnet run, or dotnet test, or publish an executable, all of which will work. But not VSTest.
If you do dotnet run --showmeoptions you'll see various CLI flags you can use with TUnit.
Hopefully you can achieve what you need.

Ui, quick reply, thank you.
Unfortunately, this does not work with dotnet test either.

What doesn't? Trx?

Flags are here : https://thomhurst.github.io/TUnit/docs/tutorial-extras/command-line-flags

And you need to install a separate trx package. Details here: https://thomhurst.github.io/TUnit/docs/extensions/

Heya.
So VSTest was the old Microsoft test runner.
TUnit is built on top of the newer Microsoft.Testing.Platform. It doesn't even know about VSTest.
This means your VSTest commands won't work.
You can use dotnet run, or dotnet test, or publish an executable, all of which will work. But not VSTest.
If you do dotnet run --showmeoptions you'll see various CLI flags you can use with TUnit.
Hopefully you can achieve what you need.

Sorry just seen this. If you're using a dll you need to use dotnet exec instead of dotnet test I think.
Dotnet test is for project files

Yap,
with dotnet exec the tests locally work.
On my CI-Pipeline not, because there is not an option for an output like trx.
Also the option --logger or else is missing, thats why dotnet exec executes the dll as an app not a test.

The build stage builds the main project and the test stage builds the test project (with the main project, as it is a reference in the test).
But then I can call dotnet test on the csproj with all the trx-stuff.
Regards

Install nuget package Microsoft.Testing.Extensions.TrxReport and then try
dotnet run YourProject.csproj --report-trx --report-trx-filename SomeFilename.trx

And finally, the pipeline is green!
I have adapted the command as follows, now the test stage works without any problems
dotnet run --project MyFancyTestProject/MyFancyTestProject.csproj --report-trx --report-trx-filename TestResults.trx --results-directory TestResults
Thank you for your help.

Glad to help 😄


fix(builder): silence pipefail errors on boot

Starting deis-builder shows lots of these warnings in the log:
/bin/sh: line 0: echo: write error: Broken pipe

Reworking the ExecStartPost line not to use a piped command silences this. Lots of users stare at the builder log, so it's worth cleaning it up.

Good find - didn't know ncat had an --exec option. Code LGTM.
This closes #1973, right?

This closes #1973, right?

No, we're still sending a bogus 'dummy-value' string just to see if builder is alive, so we will get one "Bad Protocol" message when we start up.

No, we're still sending a bogus 'dummy-value' string just to see if builder is alive, so we will get one "Bad Protocol" message when we start up.

Yeah, bummer - that'd be nice to clean up.

If I change the command to:
 ncat localhost 2223 --exec '/usr/bin/echo -e SSH-2.0-deis probing builder\r\n'

Then it looks more like an SSH client, and you see one of two warnings in the builder logs (randomly, apparently):
May 05 21:04:17 deis-02 sh[3913]: Connection closed by <IP_ADDRESS> [preauth]
May 05 21:04:21 deis-02 sh[3913]: Write failed: Broken pipe [preauth]

I'm not sure that's any better WRT fixing #1973. We're probing for an SSH server here, and when ncat connects but isn't a proper SSH client, the server is going to squawk about that.
We could change the echo string so the log says:
May 05 21:10:33 deis-02 sh[3913]: Bad protocol version identification 'builder is running' from <IP_ADDRESS> port 59179

We're probing for an SSH server here, and when ncat connects but isn't a proper SSH client, the server is going to squawk about that.

Yeah, I don't think changing the message is worth the effort - it'll still be just as confusing.

LGTM.

code LGTM :)


React formic conditional rendering initialValues

I am conditionally rendering the value but the value does not display in the textfield ,only when I remove the rendering does it work
,any suggestion?
initialValues = {{
[props.entitytype === 1
? 'payee'
: {
lastPaid: '',
lastPaidAmmount:currentEntityData.payee.lastPaidAmmount, //getting data from api
lastInvoiceNumber: currentEntityData.payee || '',
} ]:{}
}}

FYI, you can format code in markdown  and Github by using three backticks `.

you should assign this object to a variable and log it before rendering. That's a good debugging tactic, and will likely give you more context on what's going on.

//getting data from api I don't know if you mean this is actually creating a network request, if it is React isn't going to wait for your api to return data before rendering - JavaScript is non-blocking. Do any data fetching before rendering, otherwise you'll be passing in bad data to Formik (you can observe this by following step 1 above.)

Reproducible examples are always helpful.

So do you mean create at the top var lastPaidAmmount =currentEntityData.payee.lastPaidAmmount and use that in my formik conditianal values   @clflowers5

Hey @ChrisPotgieter as I can understand with the issue, the problem is with the re-rendering of the form when the initialValues changes, correct me if I am wrong 🙈
If that is the case, please try this prop - enableReinitialize, more info here - https://formik.org/docs/api/withFormik#enablereinitialize-boolean it can cause the form to reset with the newly provided/modified initialValues


feat: Redesign the faq page according to the theme. (Issue#1168)

Title of the Pull Request

[x] Have you renamed the PR Title in a meaningful way?

Related Issue

Closes: #1168
Description

I have added the faq page according to the theme of the website.
How Has This Been Tested? ⚙

using go live i have made sure the changes are made properly.
Screenshots 📷

https://github.com/user-attachments/assets/da2b1766-d74c-41aa-bd14-fa21194f66f4
Type of change
What sort of changes have you made:

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Code style update (formatting, local variables)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] My code follows the code style of this project.
[x] I have followed the contribution guidelines
[x] I have performed a self-review of my own code.
[x] I have ensured my changes don't generate any new warnings or errors.
[x] I have updated the documentation (if necessary).
[x] I have resolved all merge conflicts.

Kindly review my PR.


Question: How to trim all model's strings before validation

Hello,
i'm trying to find a way to trim all strings before the server validate the model, so the validation failed if the user set only white spaces in a string.
Any idea how to do that ?

Seems like you would need to add a pattern on each string, since even an empty string is enough to satisfy the required attribute.

@BertrandGouny I had the very same issue and adopted what Greg is now saying:
 pattern: "^\\S.*\\S$"
Before that, I simply trimmed the parameter at the beginning of my operation, with strings.TrimSpace() and handled the error manually (e.g. sending back a 40x error etc...).

My case was to avoid leading or trailing blanks, so your regexp would be different. But you see the idea.

Perhaps something like  '^.*\\S.*$'  ... (at least one non-blank)

Thanks you @gregmarr and @fredbi
using a pattern will do the trick indeed  :+1:
i ended up with something like ^(\S.*\S|\S)*$ to accept only trimmed strings and single non-whitespace char.
Feel free to close this :)

you close it. That's the policy in this house, man... 👍


Is there redis binding?

like redis geo commands

All of the available bindings are listed here: https://uber.github.io/h3/#/documentation/community/bindings
We're not currently aware of a redis binding.


App restarts and makes it unable to load pics from "my picture"

While making a post, if I click to add images and proceed to selecting picture, If I choose my picture which serve as my gallery in android 8.1 any picture selected from a folder makes the app restarts and the picture is not uploaded

android 8.1 is likely not supported with current version, we will make sure to check before publishing our next release. Thanks for reporting.


Fix speaker name conflicts with miniaudio macros in unity builds

Fixes these sort of errors when using unity builds:
In file included from C:/OHWorkspace/SFML/build/src/SFML/Audio/CMakeFiles/sfml-audio.dir/Unity/unity_0_cxx.cxx:70:
C:/OHWorkspace/SFML/src/SFML/Audio/SoundFileWriterWav.cpp:113:31: error: expected unqualified-id
  113 |         static constexpr auto SPEAKER_FRONT_LEFT            = 0x1u;
      |                               ^
C:/OHWorkspace/SFML/extlibs/headers/miniaudio/miniaudio.h:19901:39: note: expanded from macro 'SPEAKER_FRONT_LEFT'
 19901 | #define SPEAKER_FRONT_LEFT            0x1
       |                                       ^

Does this follow our naming convention? I'm fine with changing it, but it should still be within the convention we've set.

SFMLBuildMaster: Build this please.

Does this follow our naming convention? I'm fine with changing it, but it should still be within the convention we've set.

I have checked, we use camelCase for many other constexpr and static constexpr variables. There are some cases where we use CamelCase, but I believe those are exceptions as they replace old enum values like Joystick::ButtonCount IIRC.

Our naming of static variables is somewhat inconsistent as evidence by all the times I had to disable readability-identifier-naming. Could be worth cleaning that up right before we ship v3.

I've added a card to the SFML 3 project for now: https://github.com/orgs/SFML/projects/4?pane=issue&itemId=66878764

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.758%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
11571

Relevant Lines:
19672

💛  - Coveralls


Expedited Governance Proposals

Summary
Provide the capability for governance proposals to end the voting period when a super majority is reached.
Problem Definition
Full details of this proposal for the Cosmos SDK are here: https://github.com/cosmos/cosmos-sdk/issues/10014
This feature would replace the SDK governance module with a forked version within provenanced that implements the above feature.
Proposal
Create a forked gov module and use this instead of the default within the Cosmos SDK in order to implement the expedited governance proposal process.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Closing this issue due to cosmos sdk refactor of gov/groups modules that makes this no longer relevant.


[CCI] aws-sdk instead of third-party aws4 for signing request?

Should I swap the third-party library aws4 for official amazon aws-sdk packages for signing requests? @aws-sdk/signature-v4 and @aws-crypto/sha256-js in the client TypeScript rewrite
The current implementation in the JS client
  function buildSignedRequestObject(request = {}) {
    request.service = opts.service;
    request.region = opts.region;
    request.headers = request.headers || {};
    request.headers['host'] = request.hostname;
    const signed = aws4.sign(request, credentialsState.credentials);
    signed.headers['x-amz-content-sha256'] = crypto
      .createHash('sha256')
      .update(request.body || '', 'utf8')
      .digest('hex');
    return signed;
  }

In the client rewrite, I propose to use official aws-sdk packages. There wouldn't be any problems, right?
Example using the SDK (more clean, IMO):
import { SignatureV4 } from '@aws-sdk/signature-v4'
import { Sha256 } from '@aws-crypto/sha256-js'

const sigv4 = new SignatureV4({
    service: init.service,
    region: init.region
    credentials: {
      ...init.credentials
    },
    sha256: Sha256,
})

const signed = await sigv4.sign({
   ...
   hostname: url.hostname
   ...
})

And since the JS client already uses aws-sdk packages for v3, it would make more sense to ditch third-party aws4?

+1 on switching to the official SDK

The rewrite is an opportunity to make things right. So go at it :)
A note on writing the API methods: Instead of writing those methods manually, we should generate them from API Spec. The API spec is currently being backfilled  so we should wait on that.
Also I think all concerns regarding the rewrite should be put in this ticket instead of opening a new issue every time something comes up.

oh! that's interesting, got it

Closing this issue because it should be a comment in https://github.com/opensearch-project/opensearch-js/issues/269


[CARBONDATA-3978] Trash Folder support in carbondata

Why is this PR needed?
To add support for a trash folder, where all the carbondata and index files of all the stale segments(segments whose entry is not in tablestatus file but exists in Fact folder and metadata folder) will go after clean files is called.
What changes were proposed in this PR?

Added trash folder(recycle bin) where all the data files of stale segments(segments whose entry is not in tablestatus file but exists in Fact folder and metadata folder) go to after clean files operation. Timestamp based subdirectories are added in the trash folder and those subdirectories will contain the segment folders which are moved to the trash. By default the expiration day of the timestamp subdirectory is 7 days, the subsequent clean files command after the expiration will remove that timestamp subdirectory. The property exposed for this purpose is "carbon.trash.retention.days".
Clean files with force option directly empties the trash folder. By default, clean files with force option is disabled. It can be enabled by setting the carbon property "carbon.clean.file.force.allowed" to true.
The MFD and Compacted segments will also take in into account the Carbon Trash Retention Property before they are being deleted instead of just max query timeout.

Does this PR introduce any user interface change?

Yes. (Added clean-files.md)

Is any new testcase added?

Yes

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4781/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4785/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4786/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3028/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4789/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3031/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3032/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4792/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3034/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4793/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3035/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4795/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3037/

retest this please

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4797/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3039/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4798/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3040/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3041/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4799/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3042/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4800/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3043/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4803/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3046/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4804/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3047/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4806/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3049/

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

retest this please

test

test

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3075/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4831/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4832/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3076/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4836/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3081/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4847/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3094/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4852/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3099/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4877/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3124/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4888/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3134/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4923/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3168/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4943/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3188/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4957/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3202/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4975/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3220/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4976/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3221/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4979/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3224/

After you force push the old commit, I don't know what is your change for my review.
Better to add a new commit instead of merging into the old commit.

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3232/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4987/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4989/

Build Failed  with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3234/

Build Failed  with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4991/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3236/

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/4995/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3240/

LGTM

LGTM

LGTM

Build Success with Spark 2.3.4, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbonPRBuilder2.3/5005/

Build Success with Spark 2.4.5, Please check CI http://<IP_ADDRESS>:12545/job/ApacheCarbon_PR_Builder_2.4.5/3250/


Transmutation Tablet server/client crash.

I was able to successfully create a Transmutation Tablet on my server, but my client was disconnected and the server crashed. In SSP I was not even able to complete the creation of the tablet. As soon as I right-clicked with chalk on ash infused stone, my client crashed. The log linked is SSP.
edit: Server did not technically crash, however it could not be stopped by command, nor pinged.
EE3 V: 0.30.547
Pastebin: http://pastebin.com/DC70sj0T

Closing due to age


Fix incorrect Ubuntu upstart create job command

The original puts the upstart conf in the init.d directory, which doesn't work. The correct directory is /etc/init.

Fixed in 8877a3ecbdd805f02b5752e5fd6770c11e4ad2eb


HC: redirection issue after success

User is trying to perform Health check but it goes in Create a New Vault flow
https://github.com/bithyve/bitcoin-keeper/assets/107177634/26de8887-6037-4fc2-8b84-2dbed7873f27
https://github.com/bithyve/bitcoin-keeper/assets/107177634/347a4007-af31-4f92-9ad0-f9b3be348d3a

These are for AMF. HC currently is not supported for mock flows, please test with actual devices and confirm
@cakesoft-swati  @Deveshshankar


Create versioned commit objects via GitHub API

These commit objects will be automatically signed and verified
if using GitHub app tokens for authentication.
This also removes the need for versioned source artifacts
as each job can clone the versioned commit directly.
Change-type: major
Signed-off-by: Kyle Harding<EMAIL_ADDRESS>

e2e results: https://github.com/product-os/flowzone/actions/runs/5270358695

I self-certify!


Question: handle_mavlink_message

We are currently using V1.4. However we did not get "Camera Daemon found: sysid: %d" message.

@aho38, the binary shipped with 1.4 does not have mavlink enabled by default, as that implementation is still being discussed and worked on within the Dronecode community.


Update example layout

This uses the latest Bootstrap for examples.  This makes the header for the examples look more like the rest of the website and fixes the layout for smaller viewports.

Fixes #3676.

Very nice, please merge.

Very nice. Thanks a lot for this change.


feat(ngDefer): new ngDefer directive to defer compilation until condition is met

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
ngNonBindable can halt Angular compilation altogether at a certain point in the
tree. This is a useful optimisation feature.
But even more useful is to delay compilation until a certain condition is met
so that parts of the tree can be compiled only when needed. E.g. content of
pre-loaded popups or complex navigation dropdowns can be compiled only when
they become visible.
There is currently no builtin way to do just that.
What is the new behavior (if this is a feature change)?
This new ngDefer directive halts compilation similar to ngNonBindable, but
registers a watcher on the condition provided to the ngDefer attribute and
will continue compilation once the condition returns a trueish value.
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Fix/Feature: Docs have been added/updated
[ ] Fix/Feature: Tests have been added; existing tests pass

Hi, interesting PR - but I don't see how this is different from ngIf?

Note that since #12078 transluded content is lazily compiled only if/when needed.

You're right, after stripping most of our custom stuff for submission here the directives functionality as submitted here is very close to ngIf.
There are however, a few differences:

ngIf removes and then re-attaches the DOM element from the tree, ngDefer simply stops compilation
ngIf keeps a persistent watcher whereas ngDefer removes the watcher once the condition is fulfilled
ngIf creates a new scope, ngDefer doesn't
All of these make for better performance, in particular not modifying the DOM means there is no re-layout event triggered in the browser, which is crucial for fast initial page rendering (in progressive enhancement use-cases).

But looking at it again, it might make more sense to implement this as an extension to ngNonBindable (as in supporting an ngNonBindable attribute value) than as a separate directive?

and 3) are valid points - I think point 2) can be achieved with a one-time binding on the ngIf condition. Even so, we won't add it to core, as I think it's still quite similar to ngIf, which does a fine job in most cases. Progressive enhancement is also not something AngularJS is especially good at, so I assume it's a bit of a rare / power user use case. I still think this could be a nice 3rd party module / directive, though. Actually, it wouldn't surprise me if something like this exists in user-land.


Extract the dates ouf of the dumpv2

When importing a dump v2, we should extract the creation and last updated timestamp.
https://github.com/meilisearch/meilisearch/blob/main/dump/src/reader/v2/mod.rs#L145-L164
The idea is to look at the whole task queue until you find the first task concerning your index (=last_updated_at), and you already have the task_uid of the task_creating it. Thus you then need to continue until you reach this task and extract its date as the creation_date.

Thank you very much @vivek-26 for your involvement in this project!
@irevoire will review your PR when he will have some time 😊


Investigate tensor() implementation

Investigate why, in the deleter delegate, ghcp and ptr are different.

There's a reason for the difference. No need to address.


Jesse: Watch digi-zeal.com

Jesse requests the watch of the watch_keyword digi-zeal\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

digi-zeal\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Spevacus in Charcoal HQ


mesonpy: make pep621 a hard dependency

Fixes #56
Signed-off-by: Filipe Laíns<EMAIL_ADDRESS>

Follow-up: the ninja dependency is already present in pyproject.toml as well, so can go too.

Yeah, I noticed that when touching the code, I think I moved it a while back.


dev/swinteraction

new class "shock wave interaction"
new class "state2dpolar" for supersonic flows

python 3.7 and 3.8 (scipy 1.7) needs to specify secant method instead of newton method


Update docs to reflect current Twitter API

https://dev.twitter.com/rest/reference/get/lists/members
Fixes #277.
[CI skip]

Hi Hugo. I believe the first example line was there to demonstrate the use of arguments in the url which does not apply anymore to lists. I dont think keeping it is useful/relevant anymore, I'd rather get rid of lines 107 to 109.
Also, historically the README used to be generated from the code's documentation. Therefore, keeping it in phase is preferable. So could you duplicate your modifications there? https://github.com/sixohsix/twitter/blob/master/twitter/api.py#L400
Thx!

@RouxRC Done!

Coverage remained the same at 29.76% when pulling<PHONE_NUMBER>7dc96dea5517f665ddd09e198aa609 on hugovk:patch-1 into ae935be58936dcc1de7e4bf2c0f9c97405938266 on sixohsix:master.

Coverage remained the same at 29.76% when pulling<PHONE_NUMBER>7dc96dea5517f665ddd09e198aa609 on hugovk:patch-1 into ae935be58936dcc1de7e4bf2c0f9c97405938266 on sixohsix:master.

Coverage remained the same at 29.76% when pulling<PHONE_NUMBER>7dc96dea5517f665ddd09e198aa609 on hugovk:patch-1 into ae935be58936dcc1de7e4bf2c0f9c97405938266 on sixohsix:master.

Great! Perfect, thanks, merging!


fix markdown in neuroharmonize notebooks

Accidentally I wrote "neuroharmony" in these notebooks(all the ones with an E in the title on the endinng e.g. ml_experiment2ea-neuroharm_topmri_sabre.ipynb)  instead of neuroharmonize in the markdown. This should be changed, and markdown should be proofed for readability in general,

I also changed the name in Legacy and Homemade_and_other to be sure its all correct


About point cloud visualization

@ErlerPhilipp  hi, whether point cloud visualization considers integrated Gaussian splatting results instead of traditional MVS results

Hi @yuancaimaiyi, there is currently no Gaussian splatting implemented and we don't have the resources to do it in the foreseeable future.  Pull requests are very welcome.


OutlinePass - bad output buffer

I am not 100% sure but it seems that:
https://github.com/vanruesc/postprocessing/blob/edd93e7f62472cddee25d9ee4f733b5098a0f8b9/src/passes/OutlinePass.js#L607
there should be just "outputBuffer" instead of "this.outputBuffer"

Fixed in<EMAIL_ADDRESS>


added name to team members

@TaylorDJones11 Fix the conflicts Taylor then I will merge 🙏🏾

I made the changes to repo


Update Wiki, Laravel 5 installation

lucadegasperi/oauth2-server-laravel 5.0.1 was released, we should update Wiki page to point to 5.0.* instead of 5.0.*@dev
The permission to edit the wiki page has been set to collaborators now, I'm unable to edit it.

Thanks! Fixed.

@vinkla We should also update all instances of class string to class constant to honor Laravel 5.1 coding style.
'LucaDegasperi\OAuth2Server\Storage\FluentStorageServiceProvider',

to
LucaDegasperi\OAuth2Server\Storage\FluentStorageServiceProvider::class,

Personally I like registering it with a string. I'll leave it like that for now. Thanks.

I think project consistency comes before presonal taste (for a project with 1000+ stars), it looks ugly when registering with string, and does not benefit the great feature for higher version of PHP.

This is totally up to the developer. If they want to register with ::class notation they can do that.

I totally agree it's up to the developer, but since it's a package for Laravel 5.1, integrating more seemlessly to Laravel 5.1 by default would be a huge plus.

integrating more seamlessly to Laravel 5.1

This is only a matter of syntax preference. It will work either way.

+1 as a new(er) user of Laravel I found the wiki more confusing because there were 20+ lines above the insert point that followed the ::class syntax. In all honesty, I immediately thought "oh these instructions must be outdated". Would it be better to at least make note of the syntax alternative? IMO, it's much easier to follow along with install instructions that follow the coding conventions of the files they are inserting code into or at least mention that even though the install instructions follow a different convention it's 'ok' and won't screw up the rest of your app. It makes the user feel more confident that they're doing the right thing.

Okay, I'll add it to the docs as soon as I've time. Thanks.

Done.


Can't submit to say I can't make any dates at all

It doesn't seem possible to indicate that I've seen the form, but am unable to make any listed dates. I enter my username but am unable to submit.
I can set the dates to the red colour, but that looks to mean "ifneedbe" rather than "no".

Fixed now, thanks.


ephemeral messages

A channel for communication outside of replication would be useful for on-boarding new users https://github.com/pfraze/phoenix/issues/22
This could also be utilized for allowing a limited capacity to push messages to a node,
for example, sometimes you want people that do not follow you to be able to send you a message, one way to secure this would be to route messages through the social network,
A can send a message to C my sending through their mutual friend B. Then C can read the message and choose to follow A.

Hello from the future :smile: any love for this issue recently?

hi @mnzaki!
you might be interested in @dominictarr's tech tree: %kDrsaJXkDiRwit9mCCmqoWBqI3WWxBxp+82fjZELluU=.sha256. i single out Dominic because unfortunately he still is the one who disproportionately does ssb protocol work and has the best understanding.
with my understanding, the current strategy is to use the pubs as signaling servers to bootstrap a direct connection (over tcp or webrtc) betweens peers, so they can send all the ephemeral messages they want as a separate protocol on the side.

yeah, I'm too flooded with improving the core protocol stuff, so I'm not expecting to have time to implement this soon.


Add a rudimentary json regex to get at information like endLine

bors r+
Seems useful!
Is there a specific case where one is forced to use JSON?

Is there a specific case where one is forced to use JSON?

I found the squiggly lines to be fairly confusing with the standard matchers. Especially around unused imports I kept getting the std of use std::something::Else; highlighted, which looked rather odd.

bors r+

Just for the context, the long-term plan here is to move this from frontend (VS Code), to the language server proper (but still using an external command to get the errors). In this future setup, we should just parse JSON properly.

Yea I'm totally aware this is just papering over the issue. Great to hear there's a plan for it.


feat(Accessibility): Make Grid keyboard navigable by adding Grid Behavior

This PR adds a possibility to navigate Grid items with arrow buttons.
What was added:

extended Grid's API, so now it can process accessibility prop. (though, a default value is defaultBehavior)
added gridBehavior with FocusZone circular bi-directional navigation
added example of keyboard navigable Grid component, which uses gridBehavior for that purpose.

TODO:

update CHANGELOG.md

I was trying this in our react conf prototype and it does not behave correctly when the grid items contain focusable items themselves:

As you can see in the screenshot above, the grid contain a button so navigation works incorrectly:
actual: arrow keys navigate to grid items then to buttons
expected: two level of keyboard navigation:

arrow keys navigate between grid items;
enter key navigates inside the grid item (level 2 key nav) that will trap focus;
esc key navigates back to the grid item (level 1 key nav)

fyi @sophieH29 @jurokapsiar

in the example I provided above, each item contains a button but also data-is-focusable=true at the top item element which causes weird navigation:
<Grid

    <button>FULL BIO</button>

    <button>FULL BIO</button>

  ...

    <button>FULL BIO</button>

/>

let's say the focus is in the `Grid`; user scenario:
- focus is on first grid item;
- press `right arrow key`; focus goes to button inside first grid item;
- press `right arrow key`; focus goes to second grid item;
- press `right arrow key`; focus goes to button inside second grid item;
- etc.

This looks wrong to me, do we want merge it like this?