Threading Issue - IndexError: pop from an empty deque

Dear RobotFramework AIO Team,
An issue has encountered while running the threading sample tests included in RobotFramework AIO version 0.13.0.
Error Description:
The test execution resulted in the following error messages and warnings:
Main Error: IndexError: pop from an empty deque
First Error Message: entry = self._stack_ctx_entries_deque.pop()
Tracebacks: The error includes tracebacks referencing lines within robotframework_debug_adapter\listeners.py.
Additional Warnings:
RFStream Warning: unable to pop keyword - voltage.Validate All Channels Voltage (empty queue).
RFStream Warning: keyword - BuiltIn.Log did not have a corresponding pop.
RFStream Warning: keyword - bits_platform.Selftest Set Single Parameter did not have a corresponding pop.
Context:
The error occurred specifically when executing the threading sample tests.
Additional Information:
The error message also mentions: + Exception Error has occured while processing device unit1. Error Message: [ 'str' object has no attribute 'test_case_errors' ]
We are unsure if this additional message is directly related to the main IndexError.
We would appreciate any insights or suggestions you might have to help us resolve this issue. Please let us know if you require any further information.
Thank you for your time and support.
Best regards,
Datta

Related to
https://github.com/test-fullautomation/robotframework/issues/38

Language server issue (as part of test execution VSCodium). Errors do not occur in case of execution by batch file in standard console. Test execution in console would be an intermediate temporary solution until language server is fixed.

Hi Datta,
please check if the same issue happens when you execute the test without VSCodium, but instead directly in console.
Please give feedback.
Thank you,
Thomas

Hello @test-fullautomation,
We have tried to run the test on the console outside of VSCodium. However, it throws another error as bellow. This error occurring due to the console couldn't get ta_framework directory path from the environment variable :
D:\ta_framework_2.0.0\project\test>dev__bits_platform_thead_sample_v03.robot
[ UNKNOWN ] Error in file 'D:\ta_framework_2.0.0\project\test\dev__bits_platform_thead_sample_v03.robot' on line 5: Replacing variables from setting 'Resource' failed: Variable '${TAF_PATH}' not found.
Bits Platform Thead Sample V03 :: Connect to BITS-Platform and run its api ...
Threading sample test on console                                      | UNKNOWN |
Bits Platform Thead Sample V03 :: Connect to BITS-Platform and run... | UNKNOWN |
1 test, 0 passed, 0 failed, 1 unknown
Output:  D:\ta_framework_2.0.0\project\test\output.xml
Log:     D:\ta_framework_2.0.0\project\test\log.html
Report:  D:\ta_framework_2.0.0\project\test\report.html

Puhh... Looks like that the TA-Framework has a dependency to VSCodium.
I check this with Alexander tomorrow and come back to you.

It is just for your information. Here is some more additional error and log relating to the threading module issue.  This exception occurred when I tried to run the threading sample test again.
The exception occurred error message is "An exception occurred in 'SELFTEST_1' thread. Exception: RobotNotRunningError: Cannot access execution context' "
Thread_1 set_single_parameter: True
[ WARN===>ack:
]  An exception occurred in 'SELFTEST_1' thread. Exception: RobotNotRunningError: Cannot access execution context'
===>result : FAIL
===>ack:
===>result : FAIL
===>ack:
===>result : FAIL
===>ack:
[ WARN ]  An exception occurred in 'SELFTEST_2' thread. Exception: RobotNotRunningError: Cannot access execution context'
Log:     D:\ta_framework_2.0.0\log.html
Report:  D:\ta_framework_2.0.0\report.html
-- Closing logging streams --

Hi @bhd1hi ,
As per Alexander the only dependency is the to VSCodium are the command line arguments VSCodium uses when the test is started. Can you please check the command line arguments and start the TA-Framework tests the same way.
Thank you,
Thomas

@test-fullautomation,
As you suggested, we attempted to run the test from the command-line terminal and passed the following command-line arguments. However, this resulted in another error.
The command-line arguments we used were:
PS D:\ta_framework_1.3.0>  & 'C:\Users\bhd1hi\AppData\Local\Temp\rf-ls-run\run_env_00_y53xpdip.bat' '-u' 'c:\RobotFramework\robotvscode\data\extensions\robocorp.robotframework-lsp-1.11.0\src\robotframework_debug_adapter\run_robot__main__.py
' '--port' '54923' '--no-debug' '--listener=robotframework_debug_adapter.events_listener.EventsListenerV2' '--listener=robotframework_debug_adapter.events_listener.EventsListenerV3' '--pythonpath' 'C:\BITS_Platform' '--pythonpath' 'C:\BITS_
RF\db_client/interfaces' '--pythonpath' 'd:\ta_framework_2.0.0' '--variable' 'TESTBENCH_CONFIG_PATH:project/testbench/bench_local' '--variable' 'SUT_CONFIG_PATH:project/sut/default' '--variable' 'SETUP_CONFIG_PATH:project/setup/default' '--
variable' 'TEST_CONFIG_PATH:project/test/default' '--variable' 'FRAMEWORK_CONFIG_PATH:project/framework/default' '--variable' 'testbench_configuration:bench_local' '--variable' 'sut_configuration:default' '--variable' 'setup_configuration:d
efault' '--variable' 'test_configuration:default' '--variable' 'framework_configuration:default' '--variable' 'BP_PATH:C:\BITS_Platform' '--variable' 'TAF_PATH:D:/ta_framework_2.0.0' '--prerunmodifier=robotframework_debug_adapter.prerun_mod
ifiers.FilteringTestsSuiteVisitor' '--suite' 'ta_framework_2.0.0.project.test.bits_platform_thead_sample_v03' 'd:\ta_framework_2.0.0'
=======output log===========
robot: 2024-09-04 14:44:35 UTC pid: 22164 - MainThread - EXCEPTION - robotframework_debug_adapter.run_robot__main__.py
Could not connect to: 54923
Traceback (most recent call last):
File "c:\RobotFramework\robotvscode\data\extensions\robocorp.robotframework-lsp-1.11.0\src\robotframework_debug_adapter\run_robot__main__.py", line 48, in connect
s.connect(("<IP_ADDRESS>", port))
ConnectionRefusedError: [WinError 10061] No connection could be made because the target machine actively refused it
Traceback (most recent call last):
File "c:\RobotFramework\robotvscode\data\extensions\robocorp.robotframework-lsp-1.11.0\src\robotframework_debug_adapter\run_robot__main__.py", line 673, in
main()
File "c:\RobotFramework\robotvscode\data\extensions\robocorp.robotframework-lsp-1.11.0\src\robotframework_debug_adapter\run_robot__main__.py", line 608, in main
s = connect(port)
File "c:\RobotFramework\robotvscode\data\extensions\robocorp.robotframework-lsp-1.11.0\src\robotframework_debug_adapter\run_robot__main__.py", line 48, in connect
s.connect(("<IP_ADDRESS>", port))
ConnectionRefusedError: [WinError 10061] No connection could be made because the target machine actively refused it
PS D:\ta_framework_1.3.0>


[BUG]: Filtering declarations by subject's function does not consider the latest year of the function's term

Describe the Bug
Filtering declarations by subject's function does not take into account the latest year of the function's term.
For example, if the period when the declarations were submitted is 2018 - 2022, only declarations up until 2021 are part of the filter's result, while any declaration made in 2022 is not considered.
Steps to Reproduce
No response
Environment
- OS:
- Browser:
- Version:
- App Version:

Additional Information
No response

The feature works as designed actually. The idea is that the filtering takes into account the month and date as well :)

Let's filter only based on month and year. Institution and function name should not be consider in filtering.


Add SHA256 core internal to HMAC

Currently untested. The intention is to also add a specification in pure gallina, and possibly state machine representation of the implementation to use in relating the control logic.

LGTM.
One thing I was wondering though: Where is the code that provides status information to the software? Or, more concretely: Where's the Cava code that responds to this status request in the driver? Or is it understood that this part is still TODO? If so, where would it be inserted?

The HMAC is still in development, currently those registers are TODO, although the communication will go through the TLUL interface already modelled.


filebrowser: 2.23.0 -> 2.27.0, add service module

Description of changes

Updates the filebrowser package from 2.23.0 to 2.27.0 and adds an appropriate service module for it.
Changelog: https://github.com/filebrowser/filebrowser/compare/v2.23.0...v2.27.0
cc @nielsegberts As this package has not been updated in nearly a year, are you still interested?
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I haven't done rigorous testing, and I'm not experienced enough to provide full review of a module, but it is working well for me and seems good overall.
Filebrowser's configuration has setting the host/port and socket under the same field, but that feels a bit weird IMO.  Maybe services.filebrowser.useSocket or similar, and then set host/port otherwise?
Also, I think services.filebrowser.disableCommandRunner would be more clear than services.filebrowser.disableExec, even if it doesn't match the CLI args.

I haven't done rigorous testing, and I'm not experienced enough to provide full review of a module, but it is working well for me and seems good overall.

Thanks for the review! I'll happily discuss how to make this module better.

Filebrowser's configuration has setting the host/port and socket under the same field, but that feels a bit weird IMO.

Well, while writing this I pondered over this quite a bit myself, since filebrowser itself takes a separate option for the socket. But most services take either a IP-address or a socket path for the address, since the type can be determined quite reliably anyway.
 Maybe
services.filebrowser.useSocket or similar, and then set host/port otherwise?

Most modules AFAIK just put it under /run directly anyway - and since we'll only have one file, I would avoid the extra directory too.
We could also do it how e.g. services.postgrey does it, although I'd name the option address.
Such that one could do
services.filebrowser.listenAddress = { address = "<IP_ADDRESS>"; port = 8080; }; # or
services.filebrowser.listenAddress = { socket = "/run/filebrowser.sock"; mode = "0666"; };

Also, I think services.filebrowser.disableCommandRunner would be more clear than services.filebrowser.disableExec, even if it doesn't match the CLI args.

Seems sensible. :+1: Personally I don't have a strong opionon on this tho.

That sounds like a good method, it still feels a bit weird but I'm not sure there's a better way. For the socket path, /run/filebrowser.sock would also work, I just don't know about the permissions. I tried setting the socket to that, but it failed off permissions, which is why I thought it needed its own directory created by systemd. Reading through Postgrey's module, I don't really see how they solve this issue but clearly they do.

@fin444 Sorry for the long feedback loop!
In any case, I have now simply removed the socket option, since it's quite a bit of work and needs a more thought-out plan as can be seen. I'd rather not get this PR stuck on this forever.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3816

Marking @nielsegberts here https://github.com/NixOS/nixpkgs/issues/290642

PING


Major issues in type checking in VSC extension since today (v2.0.20 is broken)

Vue - Official extension or vue-tsc version
vue-tsc = ^1.8.25
official extension = 2.0.20 (BROKEN)
VSCode version
Version: 1.90.0 (Universal)
Vue version
^3.4.3
TypeScript version
~5.3.0
System Info
MacOS Sonoma

Steps to reproduce
My vs code in 2.0.20 (BROKEN NO MORE TYPE CHECK ANYMORE) :

and , of course (the working version), my vs code in 2.0.19 :

Link to minimal reproduction
No response
Any additional comments?
No response

FYI, it must be caused by https://github.com/vuejs/language-tools/commit/09267e80b68b44073fdc260d78d16aed4a6865da -> "Upgrade Volar from v2.2.4 to v2.3.0-alpha.14", no?
Anyway, I revert to the 2.0.19 for this weekend

It spent me half hour to figure out, why suddenly my VSCode stop showing TS error messages.

+1
VS Code, Windows 11
Reverting to version 20.0.19 fixed the problem.

I have a React project which, all of a sudden, stopped checking for errors. After uninstalling Vue extension, it started worked again. So yeah, 2.0.20 somehow breaks TypeScript everywhere, even when it's not a Vue project.

Visual Studio Code 1.90.0
Linux Mint 21.3

+1. Downgrade to the 2.0.19 extension version solves the issue.
Version: 1.90.0
Commit: 89de5a8d4d6205e5b11647eb6a74844ca23d2573
Date: 2024-06-04T19:34:48.028Z
Electron: 29.4.0
ElectronBuildId: 9593362
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.4.0

Thanks for the report, please try update to v2.0.21.


feat: Add additional outputs for reader instances and writer instances

Description
Adds two new outputs for accessing the reader instance IDs and writer instance IDs.
Motivation and Context
Other parts of Terraform build require knowledge of which instances are either readers or writers. With Aurora this is determined on creation, and the current data source for db instances doesn't provide the information.
Breaking Changes
No breaking changes
How Has This Been Tested?
It's simply two additional output values, this is tested locally by using the new outputs in other parts of the Terraform codebase.

these will change and I think it would be better served under a data source instead for the use cases that require this level of detail (i.e. - not common/standard like using the endpoints)


Tutorials are missing

It seems that the last GH Pages rebuild removed all tutorials that used to be here: https://triton-lang.org/main/getting-started/tutorials/index.html . Where can they be found now?

oh, yes, thanks for reporting

Tutorials should be back, sphinx is acting really strange. I didn't do any changes, just reran sphinx few times and it worked :) if it keeps happening we might move to using sphinx-build instead of sphinx-multiversion

Unfortunately, I do not see them. Maybe they disappeared again?

They did :) will fix soon

Should be fixed now


Typing jit signature of readonly arrays inputs

Reporting a bug

[x] I am using the latest released version of Numba (most recent is visible in
the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[x] I have included below a minimal working reproducer (if you are unsure how
to write one see http://matthewrocklin.com/blog/work/2018/02/28/minimal-bug-reports).

Is there a way to type the signature of readonly arrays? I did not find a way to specify readonly on the documentation page or StackOverflow (or maybe specifying array should work on readonly arrays as well?).
In [1]: import numba

In [2]: arr = np.array([1])

In [3]: arr.setflags(write=False)

In [4]: @numba.jit((numba.int64[:],))
   ...: def f(x):
   ...:     return x
   ...:

In [5]: f(arr)
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-5-0e64fe0f2f72> in <module>
----> 1 f(arr)

/lib/python3.7/site-packages/numba/dispatcher.py in _explain_matching_error(self, *args, **kws)
    498         msg = ("No matching definition for argument type(s) %s"
    499                % ', '.join(map(str, args)))
--> 500         raise TypeError(msg)
    501
    502     def _search_new_conversions(self, *args, **kws):

TypeError: No matching definition for argument type(s) readonly array(int64, 1d, C)

In [6]: numba.__version__
Out[6]: '0.45.1'

Thanks for the report. Unfortunately there's no short cut for specifying an array that is read only, the full numba.types API calls have to be used. Here's an example:
In [1]: from numba import njit, types

In [2]: import numpy as np

In [3]: arr = np.array([1])

In [4]: arr.setflags(write=False)

In [5]: arr.flags
Out[5]:
  C_CONTIGUOUS : True
  F_CONTIGUOUS : True
  OWNDATA : True
  WRITEABLE : False
  ALIGNED : True
  WRITEBACKIFCOPY : False
  UPDATEIFCOPY : False

In [6]: @njit((types.Array(types.int64, 1, 'C', readonly=True),)) # this is an int64, 1D, C order, read only array
   ...: def f(x):
   ...:     return x
   ...:

In [7]: f(arr)
Out[7]: array([1])

In [8]: f.signatures
Out[8]: [(readonly array(int64, 1d, C),)]

hope this helps.

@mroeschke I will close this issue now as I believe this issue has been resolved. Thanks again for asking about this.

Great, thanks for your response!


Regex.IsMatch broken with ignore case

Maybe this is a mistake on my side, but it looks like when you supply an 'i' flag to Regex.IsMatch, it always matches true (from what I can tell):
This works aka results in an empty string because "bar" does not match the regex "foo":
            var result =<EMAIL_ADDRESS>thing 'foo'}}Yes{{/Regex.IsMatch}}")(new
            {
                thing = "bar"
            }) ;

This breaks aka results in "Yes", even though "bar" does not match the regex "foo":
            var result =<EMAIL_ADDRESS>thing 'foo' 'i'}}Yes{{/Regex.IsMatch}}")(new
            {
                thing = "bar"
            }) ;

@Zulu-Inuoe
What happens if you use " instead of '?

@StefH I tried
            var result =<EMAIL_ADDRESS>thing ""foo"" ""i""}}Yes{{/Regex.IsMatch}}")(new
            {
                thing = "bar"
            }) ;

and am still seeing "Yes" rather than expected ""

I've found the issue. A new version will be released shortly.


[Docs] MovR Tutorial for MyBatis

Background: https://airtable.com/tblD3oZPLJgGhCmch/viw1DKmbKhg2MIECH/recAoZl59kuMZzlAo
Description: CockroachDB now provides application code and documentation for using MovR with MyBatis
Each ORM has a simple getting started guide. This is great to unblock basic usage by doesn't provide extensive guidance to application developers for how to use CockroachDB with a robust application.
Team: Andrew Woods, Rafi Shamim, Eric Harmeling
Github Tracking Issue:

This isn't happening for 20.1.
Note: We have a a separate issue for the general "Build an App" tutorial for this ORM.


Installing with npm fails

I've followed the instructions verbatim to install gauge from "https://gauge.org/getting-started-guide/quick-install/" and I'm unable to install it.
I'm starting from a fresh GCP Debian instance. After installing the NodeJS PPM and then following the instructions, "gauge" is installing a blank file under /usr/lib/node_modules/@getgauge/cli/bin.  I'm getting the following file permission error. This is all run as root.
Additionally, another person was able to verify the same results, but with Docker. See this thread on the Google forum:
https://groups.google.com/d/topic/getgauge/18wEnSftMtk/discussion
Terminal output
root@instance-1:~# npm -v
6.9.0
root@instance-1:~# node -v
v10.16.3
root@instance-1:~# npm install -g npm@latest
/usr/bin/npm -> /usr/lib/node_modules/npm/bin/npm-cli.js
/usr/bin/npx -> /usr/lib/node_modules/npm/bin/npx-cli.js
+<EMAIL_ADDRESS>added 19 packages from 13 contributors, removed 15 packages and updated 53 packages in 6.895s
root@instance-1:~# npm install -g @getgauge/cli
/usr/bin/gauge -> /usr/lib/node_modules/@getgauge/cli/bin/gauge

><EMAIL_ADDRESS>install /usr/lib/node_modules/@getgauge/cli
> node ./src/index.js

Fetching download url for Gauge version 1.0.5
Downloading https://github.com/getgauge/gauge/releases/download/v1.0.5/gauge-1.0.5-linux.x86_64.zip to ./bin
{ [Error: EACCES: permission denied, open 'bin/gauge'] errno: -13, code: 'EACCES', syscall: 'open', path: 'bin/gauge' }
+<EMAIL_ADDRESS>added 83 packages from 76 contributors in 6.48s

Expected behavior
Gauge should install
Actual behavior
Gauge doesn't install
Steps to reproduce

npm install -g @getgauge/cli

Gauge version
root@gauge:~/gaugetest$ npm -v
6.11.2
root@gauge:~/gaugetest$ lsb_release -a
No LSB modules are available.
Distributor ID: Debian
Description:    Debian GNU/Linux 9.9 (stretch)
Release:        9.9
Codename:       stretch

@luksi1 Could replicate the issue. We will work on fixing this soon.

@luksi1  I could not get hold of GCP instance, but I could replicate in on docker.
Could you please try installing with npm install -g @getgauge/cli --unsafe-perm?
It worked for me on docker.

It worked perfect.
luke@vscode:~$ sudo npm install -g @getgauge/cli --unsafe-perm
/usr/bin/gauge -> /usr/lib/node_modules/@getgauge/cli/bin/gauge

><EMAIL_ADDRESS>install /usr/lib/node_modules/@getgauge/cli
> node ./src/index.js

Fetching download url for Gauge version 1.0.6
Downloading https://github.com/getgauge/gauge/releases/download/v1.0.6/gauge-1.0.6-linux.x86_64.zip to ./bin
+<EMAIL_ADDRESS>updated 1 package in 5.034s
luke@vscode:~$ gauge -v
Gauge version: 1.0.6
Commit Hash: 2bc49db

Plugins
-------
No plugins found
Plugins can be installed with `gauge install {plugin-name}`

Great. Closing the issue.


Germany return error

Request error-code 503
https://api.corona-zahlen.org/germany

This is resolved

The endpoint https://api.corona-zahlen.org/germany does not work.
But https://api.corona-zahlen.org/germany/ works.

flushing redis cache resolved the issue


Error: No provider for InjectionToken TRANSLOCO_TRANSPILER!

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
I use TranslocoRootModule in my app module, when i run my application it works perfectly.
like this:
@NgModule({   declarations: [     AppComponent   ],   imports: [     BrowserModule,     AppRoutingModule,     BrowserAnimationsModule,     HttpClientModule,     TranslocoRootModule   ],   providers: [],   bootstrap: [AppComponent] }) export class AppModule { }
But when i try to test AppComponent i do this module initiation:
`
beforeEach(async(() => {
TestBed.configureTestingModule({
imports: [
RouterTestingModule,
TranslocoRootModule
],
declarations: [AppComponent]
}).compileComponents()

}))
`
And then when i run my tests i get this:
NullInjectorError: R3InjectorError(DynamicTestModule)[TranslocoService -> InjectionToken TRANSLOCO_TRANSPILER -> InjectionToken TRANSLOCO_TRANSPILER]:  	  NullInjectorError: No provider for InjectionToken TRANSLOCO_TRANSPILER! 	error properties: Object({ ngTempTokenPath: null, ngTokenPath: [ 'TranslocoService', 'InjectionToken TRANSLOCO_TRANSPILER', 'InjectionToken TRANSLOCO_TRANSPILER' ] }) 	    at <Jasmine> 	    at NullInjector.get (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:1085:1) 	    at R3Injector.get (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:16955:1) 	    at R3Injector.get (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:16955:1) 	    at injectInjectorOnly (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:940:1) 	    at Module.ɵɵinject (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:950:1) 	    at Object.TranslocoService_Factory [as factory] (http://localhost:9876/_karma_webpack_/node_modules/@ngneat/transloco/__ivy_ngcc__/fesm2015/ngneat-transloco.js:1341:152) 	    at R3Injector.hydrate (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:17193:42) 	    at R3Injector.get (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:16943:1) 	    at NgModuleRef$1.get (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:36329:1) 	    at Object.get (http://localhost:9876/_karma_webpack_/node_modules/@angular/core/__ivy_ngcc__/fesm2015/core.js:33972:1)
I don't get how when i run my app it works, but when running tests it doesnt, i also tried to follow the transloco tutorial for testing and did this:
`
function getTranslocoModule(config: Partial = {}) {
return TranslocoTestingModule.withLangs(
{he, en},
{
availableLangs: ['he', 'en'],
defaultLang: 'he',
fallbackLang: 'he',
reRenderOnLangChange: true,
...config
},
).providers = [{
provide: TRANSLOCO_TRANSPILER, useClass: DefaultTranspiler
}]
}
beforeEach(async(() => {
TestBed.configureTestingModule({
imports: [
RouterTestingModule,
getTranslocoModule()
],
declarations: [AppComponent]
}).compileComponents()

}))
`
also didnt work....

Expected behavior
Transloco module should be injected normally without any exceptions

Minimal reproduction of the problem with instructions
For bug reports please provide the STEPS TO REPRODUCE and if possible a MINIMAL DEMO of the problem, for that you could use our stackblitz example
What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z

Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: XX
- Platform:

Others:

@DoronTorangy The code from your example seems ok, could you please create a reproduction so I can debug it and see what the problem is?

@itayod later this day i'll do it

@DoronTorangy is this still relevant? can you provide a reproduction?

@DoronTorangy Closing this, if it's still relevant please re-open with a small reproduction.

Same problem with me? Any ideas?

@yunusyerli1 If you provide a reproduction I can try and resolve this.

@yunusyerli1 If you provide a reproduction I can try and resolve this.

I solved it. Thanx for you answer.

@yunusyerli1 Can you share what was the issue for future users? 😄

TranslocoModule was registered in SharedModule provider but when I delete SharedModule, I didnt register TranslocoModule to AppModule. This was the issue. After registering TranslocoModule to AppModule, The problem has gone.

i have the same here. Any solution? i have already imported "TranslocoModule" in my app.module.
this error came as i update from 4.1.1 to 5.0.6

same here. angular 16.1.0 transloco 5.0.7

@rami-almofleh @pnocera The TranslocoModule doesn't provide these providers. please look at the docs, you need to use provideTransloco.

@rami-almofleh @pnocera The TranslocoModule doesn't provide these providers. please look at the docs, you need to use provideTransloco.

Is the documentation still up? or has it been moved somewhere?

@rakshitongit The docs are up, just in a new home 🙂
I updated the comment.


a97456f356334e28810e5b3ae645ffa7cbe2d0fe

Feature Request
Provide a short description of the problem you are trying to solve or feature you would like to see.
Expected Behaviour
Provide a detailed description of how the feature should work.
Additional Context
Add any other context about the feature here.
Linked To
List any issues linked to this feature request.

No content.


[vcpkg.cmake] Fix clobbering of user-defined triplet

Describe the pull request
If a user defines VCPKG_TARGET_TRIPLET in their own toolchain file,
vcpkg cmake would overwrite it.

What does your PR fix? Fixes #
N/A

Which triplets are supported/not supported? Have you updated the CI baseline?
N/A

Does your PR follow the maintainer guide?
Yes

This PR is not necessary if VCPKG_TARGET_TRIPLET would be correctly set as a CACHE variable in the custom toolchain.
e.g.
set(VCPKG_TARGET_TRIPLET <yourtriplet> CACHE STRING "")
The fact that you see effects of the cache variable vs your locally set variable indicates an issue with variable scope in your CMakeLists.txt.
Please refer to: https://cliutils.gitlab.io/modern-cmake/chapters/basics/variables.html

CMake has the concept of scope; you can access the value of the variable after you set it as long as you are in the same scope. If you leave a function or a file in a sub directory, the variable will no longer be defined

Due to the above I am against merging this PR.

correctly set as a CACHE variable in the custom toolchain

Ahhh. Admittedly I am still learning a lot about CMake (... including the basics 😓 ), so I appreciate your time and explanation!
You are correct that I was not using CACHE, and indeed changing it to your suggestion fixes the issue.
Thank you @Neumann-A !


Create opening descriptions for all finished chapters

[ ] Introduction
[ ] Methodology
[ ] Analysis
[ ] Configuration Management
[ ] Software Requirements
[ ] Quality Management

We should consider whether we want an introduction to all the different information in the chapter, ensuring that the reader knows what to expect from it. If not, this WI should be closed/deleted.

It has been decided that all finished chapters need to have an introduction to what the chapter will contain

A lot of these were somewhat already written, and so I have mostly just filled in the ones that are missing, but I am not quite sure if they are similar enough.


Wrong license for scopatz' stuff

I just noticed this because it prevents me from copying from scopatz's repository. [0] doesn't look like WTFPL to me, but rather GPL3, which has a clause that you must republish under a compatible license.
That said, the licensing of your repository is unspecified.
[0] https://github.com/scopatz/nanorc/blob/master/license

He may have changed it since then. When I initially built my package it was under the WTFPL, and looking at the repo, it seems like it was re-built from the ground up ~6 months ago.
I'll put a license file in the repo, to make it more explicit.  I want this to be as public as possible, so I was gonna make it MIT (unless otherwise specified), unless you have a better suggestion...

I may point you to ISC which is said to be juridically equivalent but easier to understand.

Sounds good, I'll use that one.

I looked at that, but I think the unlicense for everything that's not really licensed works better, as most of it was public domain-ish anyway.   I would hope so, but you're probably not going to sue someone if they didn't and you had the ability too)
Thanks for bringing this to my attention!  Take care!

Uh, I'm not necessarily able to look that up because MIT/BSD/ISC doesn't require users and redistributors to publish under an open source license themselves.


Move device id to a session

Changed BaseProtocolDecoder class to store device id in a session.
This solves potential problem with UDP connections.
@Abyss777, can you please take a quick look. There are a lot of changes and I don't trust myself to not make any silly mistakes there. Also, I think now we can store position sequence id in the session. That was the main purpose of this refactoring.

I've found a problem.  Devices never become offline.
You removed Context.getConnectionManager().addActiveDevice because of that https://github.com/tananaev/traccar/blob/master/src/org/traccar/database/ConnectionManager.java#L56 will never set DEVICE_OFFLINE

Fixed the problem. Thanks.
Have you finished the review? Is there anything else?

Other seems OK, but...
I'm thinking of another thing. What happen if there is short tcp connection lost, and device will try to reconnect while previous session still active. Will it be replaced? I do not see that, looks like old session will be returned. Or am I wrong?

I'm wrong. There will be a new instance of Decoder and new instance of session.
Everything is OK.

Merged. Thanks for reviewing the code.


Updated Files and Kept Recoded QB Edits

I don't know I just downloaded the files and replaced the old ones then compared the old files to the new ones I probably missed something tho

Just realized there was conflicts and fixed them


Does fuse-box support require.js style amd?

I've been trying to get something like
define([
  'mymodule',
  'mymodule2'
], function(mymodule, mymodule2) {
});

or
    require([
      'uglymodule'
    ], function() {

      require([
        'uglymodule2'
      ]);
    });

or
define(function(require, exports, module) {
  var mySugarModule = require('mySugarModule');
  exports.stuff = 'good';
});

working and it's not panning out. It made me question if it's supported. I wanted confirmation.
If any of these are not support, I'll make a PR against https://github.com/fuse-box/fuse-box/blob/master/docs/faq.md to inform future surveyors about any of these not having support.
Thanks.

Hi! Thanks for the issue. Yes we don't support it yet, However, there are 2 PR's pending on the issue.
https://github.com/fuse-box/fuse-box/pull/566
https://github.com/fuse-box/fuse-box/pull/567
It will be probably solved after the upcoming release

Cool. Something for me to test over the weekend.

Hmm... I noticed one of the issues closed and the PR has not been address, so I figured I probably didn't describe the problem well enough.
I was asking if it was possible for FuseBox to read the examples I provided.
I am working on a project that uses RequireJs in development and webpack for production bundling. Because of the large amount (+1000) of files,  webpack for development takes 40s to 1 minute to update a bundle. I can't update over 1000 files to use ES6 import all at once since it will be a regression test nightmare. Since FuseBox boast speed, I was looking forward to test it out. But after finding that it only supports import statement, I will have to keep looking into finding ways to speed up webpack bundling.
:man_shrugging:

Not holding my breath for this one. Which is too bad because it would have help beat webpack since this boast performance and what not instead yet another bundler. Good luck.

@rafde sad to hear that. We are a small community, We can't just fix all the bugs and implement all features. Feel free to help us when you have time!


WIP: Fix e2e tests

Changes

Moves e2e tests out of the src directory
Renames the package scripts for e2e to be prefixed with test-, e.g., e2e-test-node becomes test-e2e-node (which a more standard form of naming in many package.json's

This PR fixes the e2e tests that were previously disabled.

[ ] I've added a unit test to test for potential regressions of this bug.
[ ] The changelog has been updated, if applicable.
[ ] Commits in this PR are minimal and have descriptive commit messages.

The e2e have been moved out of the src directory and package scripts renamed via other PRs.

@matthieubosquet there was start of work on resolving some of the circular dependencies, and other stuff, I'll pull that into a separate branch


update config template with SSB keywords

change NGROUP -> NGROUPS, NINT -> NINTS.
Any others?

Done, in #24


LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210719033310398 to main

LEGO: Pull request from lego/hb_04604851-bac4-4681-9f74-73de611d6e48_20210719033310398 to main with localized lcls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.566%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26721

Relevant Lines:
56896

💛  - Coveralls


New-PnPSite : App-Only is currently not supported, unless you provide a Microsoft Graph Access Token.

Getting an error while deploying this app:
New-PnPSite : App-Only is currently not supported, unless you provide a Microsoft Graph Access Token.
At \microsoft-teams-apps-requestateam-master\Deployment\Scripts\deploy.ps1:309 char:9

    New-PnPSite -Type TeamSite -Title $RequestsSiteName -Alias $r ...

    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : WriteError: (:) [New-PnPSite], Exception
FullyQualifiedErrorId : EXCEPTION,PnP.PowerShell.Commands.NewSite

Any suggestions?

Replacing version 3.25.2009.1 with 3.23.2007.1 seems to allow this process to complete.
Is this a fault with the updated PnP module or does the app need to be updated?

I am also seeing this. Wondering if this issue from the past may be related: https://github.com/pnp/PnP-PowerShell/issues/1351

@edmund-davis @DmitryVorobyov this is a bug in the latest PnP module, see previous issue #134
We will keep this open until they resolve it but for now you can downgrade as above.

FYI - it seems the script is installing 3.26.2010.0 (despite noting that it should install 3.23.2007.1)
Even after I uninstalled existing sharepointpnpowershellonline module and then manually installed 3.23.2007.1, running the script installed 3.26.2010.0, and I get the error again.


Redirect Map Manager NullPointerException when no file uploaded

Required Information

[ ] AEM Version, including Service Packs, Cumulative Fix Packs, etc: Version <IP_ADDRESS>
[ ] ACS AEM Commons Version: 3.17.0
[ ] Reproducible on Latest? yes

Expected Behavior
When I create a new redirect map under http://localhost:4502/miscadmin#/etc/acs-commons/redirect-maps I can't actually add any entries until uploading a file.  To get around this for now I'm just uploaded an empty dummy file so that the initial file will be created in /crx/de
Actual Behavior
When trying to edit/create redirect entries without first entering a file nothing happens.  UI shows "Success entry added" but in the logs there are actually exceptions.  Log entries are attached.
error.log
Steps to Reproduce
Create a redirect map at http://localhost:4502/miscadmin#/etc/acs-commons/redirect-maps
Open you new redirect map for editing
Go to edit entries and try to add a new entry.  UI will show success but if you search for the redirect or go to preview you will not see it there.
Links
N/A
error.log

@davidjgonzalez @brendan-walsh I opened a PR #1447 to resolve this issue.

Fixed by @klcodanr!  thanks!


Select fields do not match when using a union in a preload

Environment

Elixir version: 1.13.0
Database and version: PostgreSQL 12.3
Ecto version: 3.7.1
Database adapter and version: postgrex 0.16.2
Operating system: MacOS 10.15.7

Current behavior
defmodule MyApp do
  def query do
    from(u in User, preload: [posts: ^user_posts()])
    |> Repo.all()
  end

  def user_posts do
    posts_with_comments()
    |> union(^posts_with_tags())
  end

  def posts_with_comments do
    from(p in Post, join: c in assoc(p, :comments))
  end

  def posts_with_tags do
    from(p in Post, join: t in assoc(p, :tags))
  end
end

MyApp.query() will raise an error as the select fields do not match. The left query, post_with_comments, has posts.user_id selected twice and the right query, post_with_tags has the select fields you would expect.
** (Postgrex.Error) ERROR 42601 (syntax_error) each UNION query must have the same number of columns

         query: SELECT p0."id", p0."title", p0."user_id", p0."inserted_at", p0."updated_at", p0."user_id" FROM "posts" AS p0 INNER JOIN "comments" AS c1 ON c1."post_id" = p0."id" WHERE (p0."user_id" = ANY($1)) UNION (SELECT p0."id", p0."title", p0."user_id", p0."inserted_at", p0."updated_at" FROM "posts" AS p0 INNER JOIN "tags" AS t1 ON t1."post_id" = p0."id") ORDER BY p0."user_id"

I have an example app with failing test that shows the issue https://github.com/MarcusHoile/union_query_select_fields
Expected behavior
I'd expect the select fields to match by default

This is expected. It is your responsibility to make sure both sides of the union select the same fields, have the same preloads, and so on. :)

no worries. So my workaround to the example above is to match the dupe field selected which doesn't sound so crazy an idea now
def posts_with_tags do
  fields = Post.__schema__(:fields__) ++ [:user_id]
  from(p in Post, join: t in assoc(p, :tags), select: map(p, ^fields))

I think you should use preloads on both sides, especially because we can't really preload only one side of the union.

I might be missing something, im not preloading on either side of the union. The union query is used as the query to preload posts

the union query by itself works fine user_posts() |> Repo.all(). the error only happens when i use the same union in a preload. I assume it is something to do with the preload builder adding the dupe select posts.user_id. Is that expected?

Ah, yes, exactly.


Replace URL with urlNormalizer

Hello guys,
Can someone give me an example on how to replace a URL with the urlNormalizer.
Example:
Replace https://www.abc.com/sector/a?id=123
with https://www.abc.com/phase/x?id=123
Thanks!

How about something like this (untested)?
  <urlNormalizer class="com.norconex.collector.http.url.impl.GenericURLNormalizer">
    <replacements>
      <replace>
         <match>/sector/a</match>
         <replacement>/phase/x</replacement>
      </replace>
    </replacements>
  </urlNormalizer>

Hi Pascal
Thanks for your help. Can you provide an example with RegExp? e.g. remove ".page" or ".page?" at the ending of URLs
Replace https://www.abc.com/index.page and https://www.abc.com/index.page?
with https://www.abc.com/index
Regards
Klevis

To help you come up with your own regular expressions, I recommend you use an online tool such as https://regex101.com/
To get you started, I have put a way to do what you are asking here: https://regex101.com/r/3U8VKI/1

Hi Pascal
Thanks for suggesting that, but I already know how to use regular expressions, it is the reason why I am asking you for additional examples. In the first example you didn't escape the forward slash "/", so I suppose both replacement and match are used as strings. How would you write a regex then? How can you differentiate between the two?
Best regards
Klevis

Not sure I follow.  Are you talking about cases where the forward slash is actually used as a regex delimiter?  If so, it is not the case here, so no need to escape them. So to answer your question:
  <urlNormalizer class="com.norconex.collector.http.url.impl.GenericURLNormalizer">
    <replacements>
      <replace>
         <match>(/index)\.page\??</match>
         <replacement>$1</replacement>
      </replace>
    </replacements>
  </urlNormalizer>

If that is not what you meant, please let me know.


Issue/58 migrate to kedro 0.17

Kedor >=0.17.3 is supported.
Resolves #58

Keep in mind:

[x] Documentation updates
[x] Changelog updates

The change looks good, I would put this in a separate release though.


[NOT AN ISSUE] I need some suggestions for AIM settings

Hello, guys!
I am really a new Player at this game i am also suck at spray so, the only reason I use this is, spray control/aimasist(more like hitting the enemy)
So I am looking for some suggestions to make my config legit and useful for me, here are my settings for AK47, Is it so obv? Or legit? I don't want to get reported because of this it looks fine in game but As I said i am really new at this game i don't know the things well, I also don't use wallhack or ESP, I am suck at spray so, that's why  I use it, Anyway I am asking you guys are these settings good enough(legit)?
If not can you tell me what should i change? Thanks!
My config:

try #769 and Recoil crosshair, its legit enough

try #769 and Recoil crosshair, its legit enough
Hey, thanks for the answer and what do you mean by 769? Is there a config in that topic? Can you link me that pls?

It is a pull request of Standalone RCS

you should practice and get used to the aimbot

you should practice and get used to the aimbot

Are these settings legit? Or should i change something?


[CupertinoContextMenuAction] Please add the ability to change the offsets

@ziqq
Can you elaborate the proposal by providing a use case, what are you trying to achieve and how would changing the offsets would help to achieve the use case ?

@ziqq Can you elaborate the proposal by providing a use case, what are you trying to achieve and how would changing the offsets would help to achieve the use case ?

I want to make like native ios context menu. In this version, I need to change the indents, because they are large.

There's a PR in progress that changes the edge insets: https://github.com/flutter/flutter/pull/117698
If I understand correctly this issue correctly would that be closer to native defaults? If you would like to discuss the exact values, I'd encourage you to move the discussion there and talk to the dev working on it.
If further customization away from the default value is needed, my instinct is that adding that to the constructor may be a little unneeded, as CupertinoContextMenu can be given any kind of widget for its actions, so a custom widget can be built, including one that extends off of CupertinoContextMenuAction. Encouraging devs to use that functionality may be the way to go, but if just wanting to change the offsets is a common request, we can still add that in to the constructor.


Request resources that fit in the default configuration in examples/mysql-wordpress-pd.

Following #9204, request only part of a core.

Closes #9204

LGTM


☂ Linting

The current area of focus for Rome is linting. This is the path of least resistance for finishing a part of Rome that can be used most easily.
With diagnostics #3 the lints that Rome can produce will be more detailed than any other existing JS linter. The most difficult part of this will be editor integration and writing a set of lint rules.
One large question is how we handle configuration. Are we going to take an opinionated stance and have some lints non-configurable? Will we have plugins?

Whether opinionated or fully configurable, it would be great to have ability to disable linter and/or prettifyer on blocks/sections of code - for those situation where a human believes they know better.
Something to this effect (excuse the unrealistic examples).
Sample Syntax:
// @linter-off rule1 [, rule2,...]: Reason why we need to disable listed rules

/* section of code that linter ignores */

// @linter-on

Examples:

Turn off a particular linter rule on a block of code

// @linter-off prohibit-vars: Some lame excuse why I really need a var here
var blah;
// @linter-on

Turn off a particular linter  rule on a single line

var blah; // @linter-off prohibit-vars: because

Similar for auto-formatter

// @formatter-off: I want my custom alignments, dammit

fooBarnicate( 'hi',    'world' );
fooBarnicate( 'quick', 'fox'   );

// @formatter-on

Idea being that escape hatches are provided, but there is a sufficient friction in writing annotations and the extra line-noise they introduce hopefully makes people reach for them only when really justified.
Hopefully not a wrong place to voice this?

IMHO: Have good defaults, and make it slightly painful to disable the linter for a line. Add good linting explanations that link specifically to the linting repo....
This ensures that lintier-rage :tableflip: gets targeted at the linting repo, and then just man that repo with chat-bots that are trained at calming people down and telling them their way is probably the best, but the linting rules are there to help those less experienced to better understand the code and avoid producing hard to grasp structures and bug magnets. 😄 And that might even be true.
For really important bad linting decisions, because monorepo with no external dependencies we're always just ONE nicely motivated PR away from fixing that cleanly and nicely. Though it would probably also need to include a codemod-style automatic code upgrader, to not put-off contributors who have unmerged branches.

One large question is how we handle configuration. Are we going to take an opinionated stance...

I think the extendability of formatting should be limited. Perhaps a small set of options could be exposed in config (a starting point could be a subset of those Prettier exposes https://prettier.io/docs/en/options.html, like newline and semicolon).
It's just one less thing to have to think about - which complements the goals of this project. We can take a cue from go fmt here, IMO.
Opening up to extendability will also require a ton more design decisions to be made. Perhaps it is something that can be iterated on later?

While I agree with @jloleysens, one thing I think is fairly common in large codebases is introducing lint rules as a means to migrate away from specific APIs in addition to codemods. However, if there is the capability participate in compilation through plugins one could create their own application specific linting tools based on the Rome AST.

I'm torn on escape hatches. They are needed, but also I've seen them abused by devs who don't care. I think the main question for that is what are we trying to achieve with listing rules. Are they style rules for formatting, or are they actual bug prevention rules? Style rules can always be overridden, but some bug prevention stuff I feel pretty strongly should not have an out.
As for plugins, it is a double edge sword because the more plugins you have, the harder it is to update the core utility if you have to wait on the plugin to also update. I think to @chadhietala point, there should be some way to lint and run codemods on larger code bases through special rules. I just don't know if that warrants a "plugin" framework. Not to mention that there can be friction when updating plugins if they change rules that cause your code to format differently.
I'd also like to callout that it is harder to adopt rules in a larger codebase because normally it is "all or nothing". The only thing I have seen that gets around this is https://www.kadamwhite.com/archives/2017/progressive-linting, but it isn't super ideal as it means areas of code will remain ignored until they are touched. It would be interesting to see if there is a way to take this into consideration when expanding the linting tool of Rome.

I think instead of error/warnings like eslint, Rome should categorize code based on levels, example:
1: Errors. Reserved only for invalid JS code, things that will throw exceptions when executed.
2: JS quirks. Things that JS allows, but will most likely produce unexpected result. Examples: duplicate object keys, using variables before defining.
3: Ambiguous code: Things that are possibly wrong, but might also be fine, like parseInt(x). Should allow inline disable.
4: Preferences: Any coding conventions that should be followed by the developers, like disallowing ternary. Should be configurable, all rules disabled by default, and should allow inline disable.
5. Style: Basically what Prettier does, but a bit more extensive. In other words, eslint --autofix-eable rules like prefer-ternary. Should allow configuration. Single/double quotes config should be here.
By default the max level displayed should be 4 - styling issues should not be reported since Rome will take care of them at some point (save or rome --autofix), and they are too much noise that mst people usually don't care about.
Having such levels or catgories will allow richer editor experience: not just red or yellow underlines, but other colors as well to indicate different type of errors.
4 and 5 are very close to each other, the only difference is 4 rules cannot be autofixed.

I would like to leave my experience in Po.et in architecture at least, we decide to create a project with the  linting rules, also could be in the monorepo, only I will leave the link I think is very easy to understand the idea and you can take a look
https://github.com/poetapp/tslint-rules

Dumping some of my brief thoughts here:

No formatting options. Zero. None. Prettier initially tried to do this but caved under demands for things like an option for  quote type etc. If you aren't happy with the defaults that Rome provides then you can use prettier or another tool.
AST transforms for prettification. This is a hard stance that prettier has taken where they don't want to modify the AST in any way. However there are a variety of transforms you can apply that retain all the semantics but make the code more readable. These can be things like flipping conditionals, pruning dead code/empty blocks etc.
Suppression comments must be specific. You must explicitly to all rules you want to disable for a particular line. Right now with other linters it's possible, and common practice, to suppress all lints for a specific line. Any future lint rules wont effect previous suppressions, this is bad!
Autofixing AST rules. Rome allows you to write lint autofixes with an AST transform. This is more powerful than ESLint which is just string based. With this capability we should be able to have autofixes for a majority of errors.

Love all of those @sebmck. If we learned one thing from the rails world, it's setting up conventions that are inmovable. Allows us all to have consistent projects and stop any/all arguments. If you want things to be ultra configurable, then the individual tools exist (i.e. prettier, eslint, etc).

PHP's static analysis tools have started to introduce the concept of a baseline file which suppresses errors for existing code but not for new code.
I've found this helps limit the proliferation of suppression comments while at the same time providing just enough friction to discourage overuse.

I'm all for zero formatting options. I can get over anything even if it deeply offends my aesthetic sensibilities, as long as we're saved from styleguide wars.
That said, it might not be obvious where to draw the line between formatting and semantic/logic/error lint rules, such as prefer-const. One would say it's formatting, I'd say it's code-complexity issue.
Oh noes, are we back to styleguide wars?

I'm also on board with no (or very limited) options. One of the things I love most about Go is how strong its opinions are, even about linting/formatting. It might ruffle some feathers, but it's something that people can learn to live with (I learned to live with tabs in go 😖).

I agree with having a set of configurations that come out of the box. At this initial stage, it is probably a good idea to leverage this feature to show that Rome will be somewhat opinionated. However, as mentioned above by a few, there is reason to have flexibility in such enforced rules. Developers shouldn't have to battle against the default lint rules. They should be guidelines to maintain a standard of code. Rome should define it's base rules which can be overridden by an alternative.
As for things like escape hatches, we should be trying to minimise occurrences of this with a sensible approach that is in-scope of this project. The idea proposed by @slobo is worth exploring but I'm not sure whether the friction it causes will actually resort in escape hatches being used less.

What if instead of offering a wide range of rules that can be configured in .rc and/or disabled via annotations, there were just a few strongly opinionated idioms that can be chosen when needed inside specific sections of code. (Sounds like a distinction without a difference, but bear with me as I think it through)
The example that comes to mind at the moment is a formatting one. I'm a big fan of using whitespace to align columns (I find visually symmetry helps comprehension, eases spotting of errors, looks satisfying etc), so I'll use that for illustration.
So, there I am, editing the code, and notice something that I'd like visually aligned. I add // @fmt-table and automatically get the formatter to do the following:

Data definitions

// @fmt-table
const data = [
  [  1,  2,  3,  4 ],
  [ 94, 82, 23, 34 ],
];

// @fmt-table
const data = [
  { name: 'Foo',    type: 'Bar'    },
  { name: 'Baz123', type: 'XyzWQr' },
];

Or even code

// @fmt-table
if ( isBaz( var1     ) ) fooBarnicate( 'hi',    'world' );
if ( isBaz( othervar ) ) fooBarnicate( 'quick', 'fox'   );

In other words, annotation would not tell the formatter to ignore bits of code, but would instead in this case instruct rome to do a specific, well tuned, alignment automatically.
But the, arguably any formatting that enhances readability should be always applied, and annotation is just there where rome can't figure out by itself what works best. And annotations are rather noisy, so you always pay the penalty of extra visual clutter, negating readability benefits.
So, instead of annotations, perhaps existing code format could be used as a hint that some legibility rule could be applied.
Ex:

This code would be left as is:

if ( baz )
    foo( bar, var2 );
if ( othervar )
    foo( yadda, bar );

But, this code:

if (baz) foo( bar, var2 );
if (othervar) foo( yadda, bar );

would end up being transformed into:
if ( baz      ) foo( bar,   var2 );
if ( othervar ) foo( yadda, bar  );

In this case rome_fmt(code) != rome_fmt(strip_whitespace(code)), but perhaps that's not too terrible? It would allow for lead-by-example code formatting, and I can imagine it could be a pleasant experience in a tight edit-save-reformat loop. In ex. above, adding a newline would essentially reformat related subsequent lines, and all that would be needed for anyone to undo it is to remove that said newline.
Anything of substance here?

When should linting happen?
Assuming auto-fixing by modifying the AST, it's possible that these transforms may be destructive. Removing unused imports automatically, for example, would be incredible useful to prevent checked in code containing them, but may get in the way while developing. Mis-type + save and half of the file tree-shakes itself to cmd-z. Other rules, like those to catch bugs early are more valuable at the time they are introduced.
Is formatting effectively creating a "compile target" for checked in source code? Is that fundamentally different to linting for correctness.
Opt-ing out of rules
Very specific opt-out sounds sensible, but it won't discourage the use of them. When someone needs to opt-out, is that a bug in the linting? If the human is right, can it teach the machine to be right. If exclusions that were bugs were marked as such, the linter could remove the exclusions as they were fixed.
// @linter-bug some-rule

That way, if the bug is fixed, and Rome lints this again (and correctly doesn't report the rule) it could remove the comment.
(Could also be used to search Github for bugs – and be able to see them in their full context)

@stephenwf

Assuming auto-fixing by modifying the AST, it's possible that these transforms may be destructive. Removing unused imports automatically, for example, would be incredible useful to prevent checked in code containing them, but may get in the way while developing. Mis-type + save and half of the file tree-shakes itself to cmd-z. Other rules, like those to catch bugs early are more valuable at the time they are introduced.

That's a good point. I think there would be two operations. Autoformatting and autofixing. Autoformatting would be an implicit action, on editor save. To perform autofixing that (potentially) changes the semantics of the code, it would have to be an explicit action, by a button in an editor integration, or from the CLI.

@slobo

What if instead of offering a wide range of rules that can be configured in .rc and/or disabled via annotations, there were just a few strongly opinionated idioms that can be chosen when needed inside specific sections of code.

My concern would be the vast amount of possible forms this could take. If the value is in consistency then that flies against it.

@dwelle

That said, it might not be obvious where to draw the line between formatting and semantic/logic/error lint rules, such as prefer-const. One would say it's formatting, I'd say it's code-complexity issue.

A linter doesn't just deal with formatting issues. A linter is broadly just a tool that finds potential problems in your code. A type checker is also another form of a linter. I think we should push the envelope and get out of the box that linters are currently categorized as in JavaScript.

@sebmck oh, no argument from me there. It's just that for formatting, I'd be fine with enforcing one styleguide for all, without ability to customize. But for things rules like prefer-const, which I personally don't consider as a formatting rule, I'm not sure where you stand on it. Enforce or not enforce?
I think that people can get over pure-formatting rules even if the dislike them (hence Prettier), but they'd be much less happy if we enforced rules that go further away on that spectrum of formatting-vs-logic rules.

@dwelle

oh, no argument from me there. It's just that for formatting, I'd be fine with enforcing one styleguide for all, without ability to customize. But for rules like prefer-const, which I personally don't consider as a formatting rule, I'm not sure where you stand on it. Enforce or not enforce?

Yeah I'm not really sure about that. I personally don't use that rule and use const as a special signifier for top-level variables. Some of the decisions will be arbitrary but ultimately we'll be able to have autofixes for almost everything so compared to ESLint it really wont be as big of a deal to have.

Better example: no-async-promise-executor. If we decide to enforce it because it may lead to errors, I'm sure there are many people who think they know what they're doing and will be very angry to have this rule on by default (and no way of turning it off --- provided we decide it falls into formatting rules, or generally prevent customization).

Ideally the proper way to signal "I know what I'm doing" is with a specific comment.
// @rome-ignore no-async-promise-executor

If you wanted to suppress a lint you would have to refer to the name, there'd be no way to say "disable all lint rules for this line/block".

I went through the list of ESLint rules and made a note of the ones I think we should have. I omitted all the ones that have to do with code style, and those where a type system could detect more reliably. A vast majority of these can be autofixed.

enforce return statements in getters (getter-return)
disallow using an async function as a Promise executor (no-async-promise-executor)
disallow comparing against -0 (no-compare-neg-zero)
disallow assignment operators in conditional expressions (no-cond-assign)
disallow the use of debugger (no-debugger)
disallow duplicate arguments in function definitions (no-dupe-args)
disallow duplicate keys in object literals (no-dupe-keys)
disallow a duplicate case label (no-duplicate-case)
disallow empty character classes in regular expressions (no-empty-character-class)
disallow reassigning exceptions in catch clauses (no-ex-assign)
disallow unnecessary boolean casts (no-extra-boolean-cast)
disallow reassigning function declarations (no-func-assign)
disallow assigning to imported bindings (no-import-assign)
disallow variable or function declarations in nested blocks (no-inner-declarations)
disallow invalid regular expression strings in RegExp constructors (no-invalid-regexp)
disallow multiple spaces in regular expression literals (no-regex-spaces)
disallow returning values from setters (no-setter-return)
disallow sparse arrays (no-sparse-arrays)
disallow unreachable code after return, throw, continue, and break statements (no-unreachable)
disallow control flow statements in finally blocks (no-unsafe-finally)
disallow negating the left operand of relational operators (no-unsafe-negation)
disallow template literal placeholder syntax in regular strings (no-template-curly-in-string)
disallow deleting variables (no-delete-var)
disallow labels that are variable names (no-label-var)
disallow shadowing of restricted names (no-shadow-restricted-names)
suggest template literals instead of string concatenation (prefer-template)

And I thought of some others:

disallow specific global variables such as event, error etc
disallow statements other than blocks in if, while etc
disallow duplicate import sources
disallow var (the presence of this in source code already makes Rome slower!)
disallow arguments

I also have the following rules already written:

disallow empty blocks
disallow undeclared variables
disallow unused variables

There's also a category of framework-level lints that are specific to things like React etc. I'm not sure how to handle them since we don't want them in Rome. I really really really want to avoid having JavaScript plugins in Rome so I'm wondering what could be achieved with a DSL where you write expression patterns to disallow.

I also merged #72 which adds formatting functionality separate to lint autofixing.

Dumping some of my brief thoughts here:

No formatting options. Zero. None. Prettier initially tried to do this but caved under demands for things like an option for  quote type etc. If you aren't happy with the defaults that Rome provides then you can use prettier or another tool.
AST transforms for prettification. This is a hard stance that prettier has taken where they don't want to modify the AST in any way. However there are a variety of transforms you can apply that retain all the semantics but make the code more readable. These can be things like flipping conditionals, pruning dead code/empty blocks etc.
Suppression comments must be specific. You must explicitly to all rules you want to disable for a particular line. Right now with other linters it's possible, and common practice, to suppress all lints for a specific line. Any future lint rules wont effect previous suppressions, this is bad!
Autofixing AST rules. Rome allows you to write lint autofixes with an AST transform. This is more powerful than ESLint which is just string based. With this capability we should be able to have autofixes for a majority of errors.

imo there should be a basic linter config for only general style preferences, like:
{
  "useTabs": false,
   "semi": false,
   "singleQuotes": yes
}

And only these rules, because being too opinionated as a linter might make some people to have to use Rome just because they don't like semi or quotes

Rome won’t have any formatting options. If you want to use prettier, then use prettier. It’s honestly not that big of a deal. Rome’s many other advantages should outweigh any minor temporary annoyance.

@sebmck ok, maybe I interpreted "f you aren't happy with the defaults that Rome provides then you can use prettier or another tool." in a wrong way

enforce return statements in getters (getter-return)
disallow using an async function as a Promise executor (no-async-promise-executor)
disallow comparing against -0 (no-compare-neg-zero)
disallow assignment operators in conditional expressions (no-cond-assign)
disallow the use of debugger (no-debugger)
disallow duplicate arguments in function definitions (no-dupe-args)
disallow duplicate keys in object literals (no-dupe-keys)
disallow a duplicate case label (no-duplicate-case)
disallow empty character classes in regular expressions (no-empty-character-class)
disallow reassigning exceptions in catch clauses (no-ex-assign)
disallow unnecessary boolean casts (no-extra-boolean-cast)
disallow reassigning function declarations (no-func-assign)
disallow assigning to imported bindings (no-import-assign)
disallow variable or function declarations in nested blocks (no-inner-declarations)
disallow invalid regular expression strings in RegExp constructors (no-invalid-regexp)
disallow multiple spaces in regular expression literals (no-regex-spaces)
disallow returning values from setters (no-setter-return)
disallow sparse arrays (no-sparse-arrays)
disallow unreachable code after return, throw, continue, and break statements (no-unreachable)
disallow control flow statements in finally blocks (no-unsafe-finally)
disallow negating the left operand of relational operators (no-unsafe-negation)
disallow template literal placeholder syntax in regular strings (no-template-curly-in-string)
disallow deleting variables (no-delete-var)
disallow labels that are variable names (no-label-var)
disallow shadowing of restricted names (no-shadow-restricted-names)
suggest template literals instead of string concatenation (prefer-template)

@sebmck Do you have a way that you prefer we track these?  I just submitted a PR for unsafe negation [here] (https://github.com/facebookexperimental/rome/pull/87) and am happy to include others in it or open other PRs for other rules.

@macovedj I'm wondering the same thing. For starters, I believe we can mention this issue in the PRs that are implementing items from the lint list @sebmck shared.

Created #94 to track the implementation of the ESLint rules mentioned.

@sebmck What are you thoughts on library specific lint rules? React is a big example that I could understand being built in first class, but smaller libraries can benefit from custom lint rules as well. eslint-plugin-tailwind being a good example.
I can see similar problems coming up once you start working on proper bundling support as well. CSS-in-JS libraries being an obvious example for having opinions in the compiling/bundling layer.
Awesome project btw, keen to try and contribute. :+1:

Sorry to backtrack a little to @slobo 's comment:
// @linter-off rule1 [, rule2,...]: Reason why we need to disable listed rules

/* section of code that linter ignores */

// @linter-on

^ a danger with this pattern is that it doesn't enforce a boundary at the end. For instance with ESLint you can have a typo /* eslint-nable */ and accidentally disable linting for the rest of your file.
So a couple ideas:

Only allow unclosed ignore-blocks at top of file
Perhaps try to catch common typo's in the enable comment

Also in general I personally think disabling all linting rules with a comment should be impossible. That has trade-offs for certain cases but leaves you with a much higher overall reliability.

I think the best option is to only allow line suppression comments.

disallow specific global variables such as event, error etc
disallow statements other than blocks in if, while etc
disallow duplicate import sources
disallow var (the presence of this in source code already makes Rome slower!)
disallow arguments
disallow wildcard import that only has static members

Have you decided yet if you want these/other things to happen between https://github.com/facebookexperimental/rome/issues/94 being completed and your first release?  Are there things that would be most helpful for people to pickup still?

Yeah they're still helpful to pick up. I didn't put them in the ESLint rules task since their behaviour is less clear but happy to accept PRs!

Sweet.  I'll probably pick up duplicate imports.  FYI there are only a couple others that I feel I could pick up without further clarification, which I'm sure is something you would have guessed.  This is my first time contributing to open source, so I'm not really sure what the best means is by which to gather clarity around them.  If you wanted to do that here or anywhere else though, I'd be excited to do so.  I think that disallow-var is probably the only one I'd feel I was able to pick up.

There's no formal process around issue creation and discussion yet since there's not a lot of structure, so feel free to post any questions here or create a new issue. We also have a fairly active Discord server: https://discord.gg/rome

Hello, I'm interested in contributing, I've got a question about this lint rule:

disallow arguments

Eslint provides multiple rules for this case:

disallow the use of arguments.caller/arguments.callee (no-caller)
suggest using the rest parameters instead of arguments (prefer-rest-params)

So, would we want to implement these 2 rules? Maybe we just want to create one rule to prohibit the use of the arguments keyword?
In my opinion, It can be better to implement the 2 eslint-like rules, what do you think about this?

I feel like a lot of interesting thoughts and discussions took place in this thread. I am wondering if some sort of 'mission statement' can be generated from this. Basically is there a mission (specific to the linting part of Rome) that will differentiate it from existing solutions? Or will the result more or less be the same?

@Lagily

Basically is there a mission (specific to the linting part of Rome) that will differentiate it from existing solutions? Or will the result more or less be the same?

Rome will be different in a few ways.
Advanced autofixes. All of our lint autofixes are regular compiler transforms. This means we can do a lot more complicated fixes than traditional linters like eslint. In ESLint you insert raw strings, so are severely limited by the sorts of things you can do.
Rich diagnostics. Our diagnostics format allows us to provide diagnostic metadata and point to multiple source locations and produce messages like "Did you mean one of these?" or pointing to the original location where we found a duplicate occurrence etc.
Heavy defaults. Other linters do this but it typically requires configuration.
Ideally for a user of Rome, they should be able to install Rome, run rome lint --fix to perform autofixes, and the remaining errors should be legitimate or potential bugs with hopefully limited noise.

I think this can be closed out in favor of more specific issues like #341. I don't think we should focus on other general JS lint rules at this time. Let's move towards a release! Thanks everyone for your contributions so far. I encourage you to get involved in #341 (React lint rules), #18 (Published release) or #496 (Website for release). Thank you again!


Swapchain isn't recreating properly

When the vulkan swapchain is recreated when selecting another present mode the program crashes. More debugging is required since validation layers have been disabled but it will be much easier if they are re enabled. This issue is not persistent across all platforms.

Figured out that the issue is in when the swapchain is recreated. Currently the setup recreates the swapchain within the render loop. That can't happen since we are currently using the swapchain, maybe there is a way that the frame could be cancelled?

Can now confirm that this issue is on all platforms. Validation layers were having issues being enabled on NixOS using VS Code.


Add EDTT tests (BT controller conformance) to CI

So far trial PR which:

Adds the EDTT controller and GATT test apps
Fetches the EDTTool and tests in CI (to be fetched as a west module)
Installs a few extra packages in CI (to be part of the docker image)
Fetches the BabbleSim EDTT bridge (to be part of the docker image)
Compiles both EDTT app images, and runs all available conformance tests in CI

Note: As of now, some of the tests are known to fail

Does it make sense to pull the BT testing we do via run_ci into a normal ci check (like we do for kconfig, pylint, etc)?

How come?


Switch to @uber/eslint-config

Switching to @uber/eslint-config over deprecated uber-standard. Fixed some lint issues, but ignored others to keep this diff on the smaller side. Will address some of the ignored rules later.
cc/ @kriskowal @Raynos

lgtm.


GCP: Add support for specifying the backups storage bucket.

When the backups storage path is not set, it defaults to the logs bucket as that's the current behaviour:
https://github.com/cloudera-labs/cloudera.exe/blob/ab0ce023fde0c71ab145b63cc1ebf5df173b7cc1/roles/common/defaults/main.yml#L106
Tested by deploying an environment where the backup storage bucket was explicitly set to be different than the logs one and another one where it was not set.

Closing as changes have been added in #172.


Retire gitmit

Now that caching ignores mtime, we might be able to retire gitmit
https://github.com/docker/docker/issues/4351#issuecomment-112164613

I'll certainly have a look and see if that's true (going by the comment I assume it is) but that comment was a year ago and I haven't realised since you pointed it out just now.
I'll also probably keep it in for anyone actually using harpoon with an older version of docker and will remove it in the future.
For now, if you don't want to spend cycles computing the modified time from git, just set the context.use_git_timestamps option to False.
Note that very little code would be removed as we still need git to remove files from the context that are ignored by .gitignore (git ignore semantics are much more complicated and flexible than docker ignore).
Also we still need to find all the files for the exclude/inclusion options in the context.


Fix networking error

@ar90n ping!

Hi @devotox
Thank for your PR. But I cannot understand it correctly. Why should we remove then clause ? Please tell me the reason .

It seems if you use noStart on offline and start s3 like this
npx sls s3 start \
	--host ${HOST} \
	--port ${S3_PORT} \
	--directory /tmp \
	--location ../../.webpack/${SERVICE}/service &

npx sls offline start \
	--host ${HOST} \
	--stage ${STAGE} \
	--region ${REGION} \
	--port ${LAMBDA_PORT} \
	--noStart true

That line above actually shuts the server down and you are not able to actually send anything to the s3rver

Hi @devotox
Thanks for your description. But I think it's odd. Because it works correctly in my environment. Also if this PR is merged, hook integration with serverless-offline won't work. So I cannot merge this PR.


Add previews for CupertinoIcons

Description
Add icon previews for CupertinoIcons in the API docs like material Icons have. Do so by introducing a new .css asset.
Before: https://api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html
After:

Also

Update top-level documentation to feature 1.0.0 icon gallery more prominently

Update link to material icons

Related Issues
Closes https://github.com/flutter/flutter/issues/45097
Tests
No tests, documentation only.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

Verified at https://master-api.flutter.dev/flutter/cupertino/CupertinoIcons-class.html

That's awesome! Great work


[No Issue] update node version docs

Scott found an issue with our unit tests running node version 16.4. We don't want to be supporting several different versions of node. However, our docs say we support any version of Node 16. We should instead peg our project to the most recent LTS release of Node 16, which is node 16.20.2. I've updated docs to show that.

Rationale for picking node 16 is because it is the latest version of node supported by our Inrupt libraries. Using later versions causes warning messages to be thrown in console when launching the react server.
Node 16 hit end of life on september 11, 2023. That means it is no longer receiving any updates of any kind. If we can, we should try to move to the newest LTS release of node (20). However, that will require removing the Inrupt libraries from the system, as they do not seem to be receiving version updates.
The docs for Inrupt's libraries say that they support node 18. However, their dependencies do not support that version.

Just for my own understanding, do points 2 and 3 pose significant issues going forward? Is the plan just to stick with Node 16 and hope Inrupt updates?
Frankly, I'm not sure whether committing to an older version of Node is a hindrance or not.

Just for my own understanding, do points 2 and 3 pose significant issues going forward? Is the plan just to stick with Node 16 and hope Inrupt updates?
Frankly, I'm not sure whether committing to an older version of Node is a hindrance or not.

For a volunteer project that doesn't have a production release, and is using node simply to deploy a react app, it's not a big  problem. The main concern in using an unsupported node version is a data breach. But our user data isn't on the node server, it's on the solid server, so there's not much to breach.
If this had a production release, the unsupported node server would be an issue.

Just checked in a local branch for Development with node 18 (18.18.2) and node 20 (20.9.0).
While I'm probably stabbing in the dark here, but I've ran npm run test with the newer node versions just to see if it'll break any of our limited tests. With v16 ran all tests just fine. With v18 and v20 breaks tests related to webcrypto which is imported from a 'crypto' module.
The major different between the v16 and newer versions is that<EMAIL_ADDRESS>is unsupported. Was wondering if 'crypto' is related to that.

Just checked in a local branch for Development with node 18 (18.18.2) and node 20 (20.9.0).
~While I'm probably stabbing in the dark here, but I've ran npm run test with the newer node versions just to see if it'll break any of our limited tests. With v16 ran all tests just fine. With v18 and v20 breaks tests related to webcrypto which is imported from a 'crypto' module.~
The major different between the v16 and newer versions is that<EMAIL_ADDRESS>is unsupported.
Update: Just checked they seem unrelated. But it's interesting to see the different node versions running the same unit tests with v20 breaking the unit tests related to crypto:

and v18 and v16 passes all the tests:

Yeah oidc-provider isn't related to webcrypto. Odd that webcrypto breaks support though. That's a node library (not a dependency). That's dead code anyway, though. I'll remove it.
And I think you're right that we're probably fine running the app in a higher version of node. The warning message is just annoying.


immediate AppCrash after opening code.exe

Issue Type: Bug
completely deinstalled, Code-Folders in AppData/Roaming deleted, current 32bit version for W7 re-installed "for all users" - no startup - immediate crash

Attach Debugger VS2010:

Breakpoint!?

VS Code version: Code 1.29.1 (bc24f98b5f70467bc689abf41cc5550ca637088e, 2018-11-15T19:11:49.509Z)
OS version: Windows_NT ia32 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Xeon(R) CPU E3-1240 v5 @ 3.50GHz (8 x 3504)

GPU Status
2d_canvas: unavailable_softwarechecker_imaging: disabled_offflash_3d: unavailable_softwareflash_stage3d: unavailable_softwareflash_stage3d_baseline: unavailable_softwaregpu_compositing: unavailable_softwaremultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarewebgl: enabled_readbackwebgl2: unavailable_off

Memory (System)
3.00GB (0.37GB free)

Process Argv

Screen Reader
no

VM
100%

Extensions: none

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Also crashes with the insider build:

We are building exploration builds that use a much newer version of Electron (our UI framework). I wonder if this issue reproduces with one of these builds, could you try? Download:

macOS: Download
Linux: Download
Windows: Download


Fix BaseLoader import

Fixes an exception when not using the C extension:
NameError: name 'Loader' is not defined

@teoric Would you mind merging this? It's a pretty small fix.

Sorry, thank you very much for the reminder, I must have missed this.


Container is not rebuilt when stack is pulled from git

Hello, I'm using portainer 2.12.2 on linux with docker 20.10.12  from chrome browser.
The stack is pulled from the git with following settings:
Automatic Updates
Polling mechanism
Pull latest image
No force redeployment
The stack structure :
total 12
drwxr-xr-x 2 root root 4096 May  8 16:53 dhcp
-rw------- 1 root root   22 May  8 16:53 stack.env
-rw-r--r-- 1 root root 1658 May  8 16:53 svcs.yml

./dhcp:
total 8
-rw-r--r-- 1 root root 3003 May  8 16:53 dhcpd.conf
-rw-r--r-- 1 root root  117 May  8 16:53 Dockerfile

dhcp serivce config :
    build: dhcp/
    pull_policy: always  # this one does not affects anyway.
    depends_on:
      - ntpd
    networks:
      infra:
        ipv4_address: ${HOME_NET}.210
    restart: unless-stopped
    volumes:
      - dhcpd:/data/persist

dhcp DockerFile
FROM networkboot/dhcpd:latest
COPY dhcpd.conf /data/
RUN mkdir -p /data/persist
RUN touch /data/persist/dhcpd.leases

The idea of this excercise is to store dhcp.conf, which is network infrastructure config in the git along with the stack config.
Observed result:
The dhcpd service is not rebuilt at all.
The additional steps tried:
Manual pull and redeploy. The result is the same - dhcpd service is not rebuilt
Related logs from portainer :
level=debug msg="redeploying stack" stackID=10
level=debug msg="The stack has a git config, try to poll from git repository." stackID=10
level=debug msg="Compose stack redeploy with pull image flag: true" stackID=10

As you might notice, image is not get rebuilt.
When I try to recreate the dhcpd container only with "pull the latest image", I'm getting the following error:
```pull access denied for svcs_dhcpd, repository does not exist or may require 'docker login': denied: requested access to the resource is denied``
The only way to the get dhcpd files updated is to :

stop dhcpd container
delete container
delete image
trigger redeploy

Expected result:
When user updates dhcpd.conf, the dhcpd service is rebuild on next poll.

I'm wondering the same, I have been having a bunch of weird issues with the git integration. In my case the .env files are never picked up, or it uses whatever the "server" has instead of the one in the agent.

This is related to #6288 and is due to be fixed with an upgrade of docker-compose in our next release.

Hm I was struggling with this for many hours now and I think this still isn't fixed. If in swarm mode and then using the Git Deployment Mechanism, even in Portainer BE  with everything on

And also additionally triggering

It will not rebuild if the docker-compose.yml has not changed. But isn't that what those options should do?

My only way out of this is currently adding unnecessary cmd overrides (e.g. echo) just for the docker-compose.yml file to be considered to have changed and hence "forcing" update :(

Set pull_policy: build and it works. See https://github.com/portainer/portainer/issues/6288


Examples on codesandbox.io broken

Every example this page is broken.
I like your project very much, other routers feel bloated to me... but it is just a feeling, could you tell me why should I use it instead of react-router? (if not now, in the future)
Thanks!

Ah, shoot. I made some changes to the @curi/react-dom API, and the examples with those changes went live when I merged the PR, but I haven't published the changes yet. I just published the updated packages, so everything should be working correctly no. Sorry about that!
As far as reasons to use Curi go, I think that it has the best API of any router I have used (or looked into). A few of my favorite things:

Named routes allow you to specify which route you want to navigate to. You don't have to concatenate strings yourself and they negate the need for relative links.

<Link to="User" params={{ id: 'sun2rise' }}>sun2rise</Link>

Curi's "response" pattern makes it easy control what is rendered. You use a route's response() property to return data that is relevant to what you want to render, most specifically, which component(s). You can even attach multiple components to easily put together complex UIs.

const routes = [
  {
    name: "Home",
    path: "",
    response() {
      return {
        body: { Main: Home, Menu: HomeMenu }
      };
    }
  }
];

<Router>
  ({ response }) => {
    const { Main, Menu } = response.body;
    return (
      <React.Fragment>
        <Menu />
        <Main />
      </React.Fragment>
    );
  }
</Router>

Other routers, have this concept with nested routes where you are rendering content for not only the route that matches, but also ancestors that match. I really dislike this pattern; I believe that the only content that should be rendered for a location is the route that matches the location. If an ancestor and descendant route should share some content, you can do that, but it isn't forced on you.

I am also quite happy with Curi's documentation and I think that the examples (now that they are fixed, sorry about that, again!) do a good job showcasing what can be done.

If you have any questions, I am happy to give my insight. One of the toughest parts about writing OSS by myself is that I might completely overlook something that is obvious to other people, so getting any feedback is really helpful for me.

I agree with 4/4 points.
Thanks for your work, thanks for the documentation, you deserve my :star:
See you around


GraphQL Support.

Not ready to merge. Or review. But it is ready to get some CI feedback...

We decided not to do this.


Autoloading file copilot.elc failed to define function copilot

I'm trying to set up Copilot using the following configuration, but get the following error when calling copilot.
Autoloading file /Users/kyrremann/.emacs.d/elpa/copilot-20230817.22242/copilot.elc failed to define function copilot

The diagnose tool returns OK.
Copilot agent started.
Copilot OK.

My configuration
(quelpa '(copilot :fetcher github
                   :repo "zerolfx/copilot.el"
                   :branch "main"
                   :files ("dist" "*.el")))
(use-package copilot
  :hook (add-hook 'prog-mode-hook 'copilot-mode))

Okay, it turns out everything works. I just can't call copilot or copilot-mode in a buffer. Maybe I'm not supposed to do that?

Also, there is no copilot function. Make sure the mode is active, whether you rely on the hook or activate the mode manually with M-x copilot-mode.
You can verify the mode is active by calling M-x describe-mode. Completions should appear but you can call M-x copilot-complete manually as well.

Thank you, that was a silly mistake from my side. use-package is working, but getting
Symbol's value as variable is void: copilot-completion-map

when I add the following below the use-package.
(define-key copilot-completion-map (kbd "<tab>") 'copilot-accept-completion)
(define-key copilot-completion-map (kbd "TAB") 'copilot-accept-completion)

PS: Using :bind in use-package is overriding every tab keybinding.
(use-package copilot
  :bind (("<tab>" . copilot-accept-completion)
             ("TAB" . copilot-accept-completion))
  :hook (prog-mode . copilot-mode))

Please read the example configurations in README.


⚠ Bofrost.es has degraded performance

In dbdb118, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1491 ms

Resolved: Bofrost.es performance has improved in 920df48 after 6 minutes.


dudetheman and thedabest SCAMMER ! ! Alert

coinlisting , mxo2, salvo, touristcoin, listex,dudetheman and thedabest are same team of frauders.
Be careful people! If you don't want to lose your money, dont use this service. It is a group of
unprofessional morons, who do not have any respect for their customers and their opinions.
Scam 1 = #823
Scam 2 = #819
Scam 3 = #747
The same scammer guy making multiple accounts ! Alert !

This scammer changed his account from thedabest to dudetheman . No commit No contribution
#BeSafe

Thanks for letting us know

@dudetheman why you stop responding to my telegram messages .   Its not obvious  at all.


Alpha property for PlotText() method

Hi!
Would it be possible to use alpha property not only for annotations, but for the PlotText methodes?
Thanks very much!
regards,

Hi @bukkideme, the Color.FromArgb() method can help you create transparent colors for use pretty much anywhere in ScottPlot. For example,
var plt = new ScottPlot.Plot(400, 300);
plt.PlotText("Hello", 4, 2,
    fontSize: 100,
    color: Color.FromArgb(50, Color.Red),
    alignment: ScottPlot.TextAlignment.middleCenter,
    bold: true);
plt.SaveFig("test.png");

Let me know if that doesn't do the trick!

Hello! Yes, it worked, thanks for the info!


Add a description to validate_df (also for autodoc)

Summary
This is the only function missing a description
Basic Example
This function validates blah by doing blah
Drawbacks
None
Reference Issues
No response

No longer necessary as validate_df will be removed with the updates to get_df.


File transfers via ADS->Manage fail silently if fast file transfers are enabled

Bug Report
System Information

All
17NN Dev Stream
Internal

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms
Trying to upload a file when using Manage from ADS fails silently.
Reproduction

Create an instance in ADS and start it
Manage the instance, and go to the file manager
Upload a file

Cause
ADS cannot proxy FM push/post endpoints.

Fixed in 1726 where FM rewrites its own endpoints to handle this.


Add new tests for Box (test_box.cpp)

SonarQube analysis reported 1 issue
Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

 geometry.cpp#L42: Complete the task associated to this "TODO" comment.


Obsidian in game QAM menu Visual bug

Description
The QAM element quickaccessmenu_Tabs_3Ag1w extends upward 1 pixel from it's original position.  However quickaccessmenu_PanelOuterNav_2BB6u doesn't get the same 1 pixel adjustment which results in the QAM menu looking like:

I can't figure out how to adjust that second panel upward.  I will continue poking around and submit a PR if I can figure it out.
Edit:  This happens on the Steam Deck

This is related to .quickaccessmenu_Menu_1gJzx::before


Impossible to edit layout in full width container

I have noticed that sometimes when you have layouts and areas tightly contained, it's sometimes impossible to edit the layout. You cannot access the layout button because the area button gets in way.
Happened again yesterday with 8.4.4.
See the screencast about the bug: https://vimeo.com/314677816

I too find selecting the appropriate layout when layouts are nested to be problematic, and sometimes impossible.

Still interested...

STILL INTERESTED....


[Bug] Fix the buttons for small screens

Deliverables:

[ ] Fix the button for resource sharing form for small screens
[ ] Fix the button on contact-us page for small screens

can I work o this issue

can I work o this issue

Go ahead @kenkirito

Go ahead @kenkirito

ok

ok

done

done

Issue that this pull request solves
#Font size of Button
Closes: # (235)
Proposed changes
I have changed the font size of buttons
Brief description of what is fixed or changed
Types of changes
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] My changes does not break the current system and it passes all the current test cases.

Screenshots
Other information
Any other information that is important to this pull request

Issue that this pull request solves
#Font size of Button
Closes: # (235)
Proposed changes
I have changed the font size of buttons
Brief description of what is fixed or changed
Types of changes
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Put an x in the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] My changes does not break the current system and it passes all the current test cases.

Screenshots
Other information
Any other information that is important to this pull request

please check @mohit355

please check @mohit355

@kenkirito  Attach these Snapshots to respective PR

@kenkirito  Attach these Snapshots to respective PR

i was asked to send pr from a branch, not from main branch

i was asked to send pr from a branch, not from main branch

@tejan-singh  ask me to Send PR from a branch, not from the main branch. @mohit355  i will also reopen  my request and upload the changes

@tejan-singh  ask me to Send PR from a branch, not from the main branch. @mohit355  i will also reopen  my request and upload the changes

@tejan-singh ask me to Send PR from a branch, not from the main branch. @mohit355 i will also reopen my request and upload the changes

He is Right, Never forgot to create a branch from the main branch before creating a PR.

@tejan-singh ask me to Send PR from a branch, not from the main branch. @mohit355 i will also reopen my request and upload the changes

He is Right, Never forgot to create a branch from the main branch before creating a PR.

@mohit355  done check

@mohit355  done check


Use createGroupAndAddAuth when inviting external agents

Description

Replace the use of createGroup in the inviteExternalAgent procedure with createGroupAndAddAuth

JIRA Link
https://polymath.atlassian.net/browse/DA-353
Checklist

[ ] Updated the Readme.md (if required) ?

:tada: This PR is included in version 15.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 15.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: