ng-repeat with  binding issues

I have an odd problem where I cannot get an ng-model value bound to a <select ng-model> to work against a list bound with ng-repeat. I can't duplicate the scenario in a simple plunkr.
This plunkr works, but the same code in an app with more complex layout fails with the first list displaying the wrong item in the first list. In my actual application, I see the model values displayed correctly on the bottom but the actual select list always selects DOG. IOW, the model is correct, but the binding in the select list is not.
The only way I've been able to work around this is to use $timeout() to delay assigning the value which works but is ugly:
        // special handling for 'remembering' selection
        var type = animalService.animalFilter.type;
        vm.filter.type = '';
        $timeout(function () {
            vm.filter.type = type;
        },30);

It appears that ng-model on the list is binding before the list is bound and depending on how quickly the page renders this causes a binding issue. The second list which uses static values bind correctly.
I have run into this a few times now, but it throws me off every single time until I remember that I need to delay binding.  This really shouldn't be necessary - is there a better way to accomplish this or possibly a binding bug with a timing issue?

There are some comments here that may be relevant https://github.com/angular/angular.js/issues/6088. Is there a reason you are not using ng-options?

I suppose ng-options would work.
In general I don't use ng-options, if the data bound is simple. Using ng-options makes the above code (assuming I didn't have to do the $timeout() bit) more complex by requiring a handler to assign the value to the model as well as requiring the nasty, difficult to visually parse ng-options expression syntax.
Verfied that ng-options works as expected, but does add a bit of overhead as you have to preassign the object, then add an extra handler to assign the value to the actual underlying model, so that solves my immediate problem.
But I still find it curious that ng-repeat binding to options would fail when the data loaded is static.

I updated the plunk to show the ng-options version side-by-side with the ng-repeat version.
http://plnkr.co/edit/YzXSYYzf6DG1cXrcDSgw?p=preview
I only had to add ng-options="type for type in vm.animalTypes" to the select element and then remove this line <option ng-repeat="type in vm.animalTypes" value="{{type}}">{{type}}</option>
Not that it's important for this example, but I also corrected the default options to have value="" instead of value=" ".

It works when you use ng-value={{type}} I assume the value attribute isn't interpolated  in time for the options directive to pick up the value. It's pretty strange that this doesn't work, since this is the most basic use case for select + ngRepeat.

It also works when you use <option ng-repeat="type in vm.animalTypes">{{type}}</option> because the directive will use the text instead of the label. This is crazy.


How can we use this with custom builds? Is there a mapping option?

Hi,
This is similar to https://github.com/TwitchBronBron/vscode-brightscript-language/issues/5; but slightly different. We use gulp to build different versions of our project (i.e. include test files/different config files, etc). Is there a way we can launch the app; but map it so I can run my gulp build task first, and have vscode-brightscript-language and roku-deploy inject the stop commands in the code in our build folder, which is an artifact of our build process?
This would allow us the flexibility to maintain our own process, and still use debugging in your excellent plugin.
tl;dr, instead of copying sources, adding stops and zipping it all up, can we add the stops to our own build output folder (which already has the copied sources)?

I love the idea, and would be more than open to having this included in the project if needed!
I think vscode already supports this concept though? In the launch.json, there's a setting called preLaunchTask. You could use that to fire off a vscode task in tasks.json which runs your gulp build, and when it finishes, the debugger could then kick off the debugger stuff.
The downside to this approach is that the breakpoints would need to be in the output folder's versions of the files. However, if gulp is tweaking/changing files, I don't know any other way to put the breakpoints in the right spots.
Thoughts?

The downside to this approach is that the breakpoints would need to be in the build folder's copy
Yes - this is it in a nutshell.. assuming the gulp process is not changing line offsets, what can we do? This will be the difference between me using your plugin or not next week. On a project crunch, so I can't invest oodles of time into working around this.. and I'm really really keen to dogfood this plugin and maximize it's utility. I've been using my definitions for a couple of days, and it's a game-changer.
I've been using your breakpoint debugger and ditto - seems a logical match to put them together and start bolstering functionality.. (indentation/function information/navigate to xml compoenents etc).. there's a lot we can quickly add, so I'm really 🤞  you know of some easy way I can get started with getting the plugin to add stops to my gulp task output in the build folder..
you got any suggestions.quick hack? I don't care if it's held together by sticky tape :) only asking in case you know something quick that will save me having to wade/read through that bit of code, while I'm still hot on the other aspects. Hope that comes across as intended; might sound like I'm horse-trading with you, which is not my intention ;)

So, assuming for a moment that all of the files in src are in the exact same locations as dist, I think this would be an easy addition to the extension. Roku reports debug file names relative to the root of the package. So, when I get that debug file name, I convert that path back to the workspace folder path (which is the "rootDir" variable in the launch configuration).
I can add another launch config variable called "debugRootDir" which will override "rootDir" only during the debugging phase.
The caveat here is, if you have files in src that get moved to different locations in dist. For example:
"src/tests/file.brs" being built and placed at "dest/file.brs", that file would not be debuggable with this fix. It gets you 90% of the way there though, and we can discuss approaches for that edge case.
Do you think that will work for most of your files?

I just pushed a commit to the repo that I think solves this for any files that have the exact same file contents and file path in source and destination. Pull it down and let me know what you think.

cool! and thanks a bunch. I'm checking it out now. not sure if I have it as intended; because I still see the same thing - none of my fonts are in the built app, which to me suggests that it wasn't using the output of the prebuild task (which I've verified is working).. here's my config
      "type": "brightscript",
      "request": "launch",

      "preLaunchTask": "gulp: build",
      "name": "BrightScript Debug: Launch",
      "host": "<IP_ADDRESS>",
      "password": "aaaa",
      "rootDir": "${workspaceFolder}/src",
      "debugRootDir":"${workspaceFolder}/build/default"
    }```

I've got your changes, too.. I've not dived into them in depth, coz truth is I'm knee deep in getting my code merged into yours and adding some new features..

It looks to me like roku-deploy is not deploying what's in the build folder (i.e. output from my gulp build task).. perhaps I'm just misconfiguring?

Thanks. I'll try that and let you know.
On Sun, Nov 18, 2018, 7:28 AM Bronley Plumb<EMAIL_ADDRESS>wrote:

You have the folders backwards. rootDir will be your build folder, and
debugRootDir will be your src folder.
On Sat, Nov 17, 2018, 21:31 George Cook<EMAIL_ADDRESS>wrote:

cool! and thanks a bunch. I'm checking it out now. not sure if I have it
as intended; because I still see the same thing - none of my fonts are in
the built app, which to me suggests that it wasn't using the output of
the
prebuild task (which I've verified is working).. here's my config
"type": "brightscript",
"request": "launch",
"preLaunchTask": "gulp: build",
"name": "BrightScript Debug: Launch",
"host": "<IP_ADDRESS>",
"password": "aaaa",
"rootDir": "${workspaceFolder}/src",
"debugRootDir":"${workspaceFolder}/build/default"
}```
I've got your changes, too.. I've not dived into them in depth, coz
truth is I'm knee deep in getting my code merged into yours and adding some
new features..
It looks to me like roku-deploy is not deploying what's in the build
folder (i.e. output from my gulp build task).. perhaps I'm just
misconfiguring?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/TwitchBronBron/vscode-brightscript-language/issues/8#issuecomment-439662845
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ACbTbWpLKJLNZpaa7SmfnvJAJuybfBXeks5uwMadgaJpZM4YnNeF
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/TwitchBronBron/vscode-brightscript-language/issues/8#issuecomment-439689220,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKIUXYjoznwgOCO9WhDyW_S7i5OSrvTks5uwVJrgaJpZM4YnNeF
.

@georgejecook did this work for you (I'm anxious to know!).

Will let you know presently.
On Sun, Nov 18, 2018, 10:16 PM Bronley Plumb<EMAIL_ADDRESS>wrote:

@georgejecook https://github.com/georgejecook did this work for you
(I'm anxious to know!).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TwitchBronBron/vscode-brightscript-language/issues/8#issuecomment-439759600,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKIUfvWW3AVWIswFq-5yIWuHxXAZgX4ks5uwiJ6gaJpZM4YnNeF
.

Took some debugging; but I worked it out, and it works perfectly:   t h a n
k s !!
I needed add this to my config (you might want to add this to your docs, if
you document the feature)
"files": [
"",
".",
"**/.*",
],
Thanks!
George
On November 19, 2018 at 8:56:05 AM, George Cook<EMAIL_ADDRESS>wrote:
Will let you know presently.
On Sun, Nov 18, 2018, 10:16 PM Bronley Plumb<EMAIL_ADDRESS>wrote:

@georgejecook https://github.com/georgejecook did this work for you
(I'm anxious to know!).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TwitchBronBron/vscode-brightscript-language/issues/8#issuecomment-439759600,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKIUfvWW3AVWIswFq-5yIWuHxXAZgX4ks5uwiJ6gaJpZM4YnNeF
.

With my simple example locally, I was able to use this feature without needing to do that. Would you be able to provide a sample repo that showcases why you needed to override the files array?

I’ll try get you something over the next couple of days - it’s tough coz
I’ve worked around it, and I’d need to make a custom repo.. you’ll likely
get this next week tbh - seeing as it’s non-critical for me.
On November 19, 2018 at 4:11:17 PM, Bronley Plumb<EMAIL_ADDRESS>wrote:
With my simple example locally, I was able to use this feature without
needing to do that. Would you be able to provide a sample repo that
showcases why you needed to override the files array?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TwitchBronBron/vscode-brightscript-language/issues/8#issuecomment-440042898,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABKIUQBQFrsqGH1sjYgqg9sytvH3LFgSks5uwx50gaJpZM4YnNeF
.

@TwitchBronBron would love to see this already available!

I think this is already merged @pixshatterer  - check the commit history - you can use the interim build until @TwitchBronBron pushes out tonight

should this be closed @TwitchBronBron ? It's working fine for me.

@georgejecook I left it open because you mentioned needing to use a catchall wildcard list for the files array, whereas for my test project I didn't need to override those at all. I was hoping you would provide some type of sample project that would let me investigate why that was needed, and fix the bug if possible.

Yeah, go ahead and raise another issue so we can track it.


Installation of boon-cli fails on latest Rust nightly

I get the error below when trying to install the boon-cli crate on Rust nightly.
   Compiling boon-cli v0.6.0
error[E0277]: the trait bound `Arc<rustls::client::client_conn::ClientConfig>: From<ClientConfig>` is not satisfied
   --> /home/mmior/.cargo/registry/src/index.crates.io-6f17d22bba15001f/boon-cli-0.6.0/src/main.rs:245:53
    |
245 |             builder = builder.tls_config(tls_config.into());
    |                                                     ^^^^ the trait `From<ClientConfig>` is not implemented for `Arc<rustls::client::client_conn::ClientConfig>`, which is required by `ClientConfig: Into<_>`
    |
    = help: the following other types implement trait `From<T>`:
              `Arc<B>` implements `From<Cow<'a, B>>`
              `Arc<CStr>` implements `From<&CStr>`
              `Arc<CStr>` implements `From<CString>`
              `Arc<OsStr>` implements `From<&OsStr>`
              `Arc<OsStr>` implements `From<OsString>`
              `Arc<Path>` implements `From<&Path>`
              `Arc<Path>` implements `From<PathBuf>`
              `Arc<T, A>` implements `From<Box<T, A>>`
            and 7 others
    = note: required for `ClientConfig` to implement `Into<Arc<rustls::client::client_conn::ClientConfig>>`

error[E0277]: the trait bound `Arc<rustls::client::client_conn::ClientConfig>: From<ClientConfig>` is not satisfied
   --> /home/mmior/.cargo/registry/src/index.crates.io-6f17d22bba15001f/boon-cli-0.6.0/src/main.rs:251:53
    |
251 |             builder = builder.tls_config(tls_config.into());
    |                                                     ^^^^ the trait `From<ClientConfig>` is not implemented for `Arc<rustls::client::client_conn::ClientConfig>`, which is required by `ClientConfig: Into<_>`
    |
    = help: the following other types implement trait `From<T>`:
              `Arc<B>` implements `From<Cow<'a, B>>`
              `Arc<CStr>` implements `From<&CStr>`
              `Arc<CStr>` implements `From<CString>`
              `Arc<OsStr>` implements `From<&OsStr>`
              `Arc<OsStr>` implements `From<OsString>`
              `Arc<Path>` implements `From<&Path>`
              `Arc<Path>` implements `From<PathBuf>`
              `Arc<T, A>` implements `From<Box<T, A>>`
            and 7 others
    = note: required for `ClientConfig` to implement `Into<Arc<rustls::client::client_conn::ClientConfig>>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `boon-cli` (bin "boon") due to 2 previous errors
error: failed to compile `boon-cli v0.6.0`, intermediate artifacts can be found at `/tmp/cargo-installqk07gG`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

you must use --locked option
cargo install boon-cli --locked

@santhosh-tekuri Thanks! That did the trick. Sorry I missed that this appears to be documented in the README.


add feature for the button in the tooltip to hide the tooltip

Here is the case: http://stackoverflow.com/questions/17171361/angular-ui-bootstrap-popover-with-close-button

Hi - Did we ever get a closure on this one?


RAP-2047 check bazel repository cache file and size before upload

https://fastaf.atlassian.net/browse/RAP-2047
Stop bleeding band-it. Should be replaced by bazel remote cache when flare.build solution is ready for buildkite.
This PR checks following conditions before continue to upload:

repository cache file exist in content_addressable/sha256/*/file pattern
the sum of file size is large than 500MB (it is slightly above 500MB in my local laptop ~/.bazel/repository_cache)

Looks this is not needed. The $path var in above shell code might not be what I expected too.
Flare has setup their remote cache in our VPC and figured out downloading remote dependences from our artifactory. Just needs a few to bazel configs to adapt it. Hence close this.


Deploy s3 Backups Everywhere

S3 backups are gated in the mongodb::backup class. To enable s3 backups, we need to set the condition to true in the
node classifier. This allows for deploying to specific nodes.

LGTM :+1:

What's the reason for choosing machine number 2 in each case?


Switch build_test_all_bazel to new dockerfile and runners.

Progress on https://github.com/iree-org/iree/issues/15332 and https://github.com/iree-org/iree/issues/18238. Fixes https://github.com/iree-org/iree/issues/16915.
This switches the build_test_all_bazel CI job from the gcr.io/iree-oss/base-bleeding-edge Dockerfile using GCP for remote cache storage to the ghcr.io/iree-org/cpubuilder_ubuntu_jammy_x86_64 Dockerfile with no remote cache.
I'm seeing errors locally about missing cuda.h and failing to find some deps for SPIRV-Tools. Those components should be optional, be configuring optional components has never need a strong suit of Bazel's. Need to see how much this CI complains and then think about possible solutions.
ci-exactly: build_test_all_bazel

Ooooooof https://github.com/iree-org/iree/issues/16915 is hurting compile time a lot here. Shouldn't need to build all the LLVM targets.

Got a successful build... only took 55 minutes on a 96 core machine 🤦♂. Could try updating Bazel and/or using a ramdisk. This might be the old issue where Bazel performance is pessimized on systems with high core counts. My local build (similar high power machine) finished in closer to 20-30 minutes.
We can also prune build deps, or try getting a new remote cache spun up.
OR just drop Bazel support / move it down a support tier to nightly builds. Ehhhh, no good options, just different compromises and they all take time.


[BUG] K3s worker only node does not work with system-default-agent args

Rancher Server Setup

Rancher version: v2.7.12(-ent)/v2.8.3(-ent)
Installation option (Docker install/Helm Chart): docker

Information about the Cluster

Kubernetes version: v1.26.15+k3s1
Cluster Type (Local/Downstream): Downstream custom k3s

User Information
N/A
Describe the bug
When using registry.rancher.com or registry.cn-hangzhou.aliyuncs.com as the system-default-registry, creating a k3s cluster and adding the worker only node fails. The configuration delivered to the worker is as follows:
{
  "docker": false,
  "node-label": [
    "cattle.io/os=linux",
    "rke.cattle.io/machine=24fce476-fc09-4fce-9f65-29c496c5453c"
  ],
  "private-registry": "/etc/rancher/k3s/registries.yaml",
  "protect-kernel-defaults": false,
  "selinux": false,
  "server": "https://<IP_ADDRESS>:6443",
  "system-default-registry": "registry.cn-hangzhou.aliyuncs.com",
  "token": "wndn5jb5swklscqjhnhlbh9kmrpwh95d8h49l9w6k5d5fskshxhtvs"
}

Because k3s agent does not support the system-default-registry parameter, the service startup fails.
To Reproduce
As described
Result
Expected Result
Worker should be added successfully
Screenshots
N/A
Additional context
It is mostly the KDM problem as the system-default-args exists in k3s agent args.

https://github.com/k3s-io/k3s/issues/7890

Causes
When we enable and set the registry on a DS K3s cluster, Rancher UI sets the following machineSelectorConfig on the Cluster.provisioning.cattle.io/v1 object.
    machineSelectorConfig:
      - config:
          protect-kernel-defaults: false
          system-default-registry: testing.registry.com

The root cause is that system-default-registry, an argument that is supported by k3s-server , is defined under the agentArgs list for k3s-agent in the Kontainer-driver-metadata.

To properly fix this bug, we need to move the misplaced argument system-default-registry from the  agentArgs to the serverArgs for k3s in the KDM.
We could not modify the templates of the released versions, so the fix will be applied to only new versions.
The same error happens on RKE2's template in KDM, but it does not produce the same error on the DS RKE2 cluster because the rke2-agent does not return an error when seeing an unknown argument.

Hi @caroline-suse-rancher,  the fix would be to be in the k3s template in KDM, which to my knowledge is maintained by the RKE2/K3s team, therefore assigning this issue to you.

@jiaqiluo  @caroline-suse-rancher    This issue is over 90 days old, any updates?


Update auto-generated documentation

Repository: openmicroscopy/ome-documentation
Already up-to-date.
Generated by build OMERO-DEV-latest-docs-autogen#1541.

--no-rebase

Think @snoopycrimecop gets a 🍖 for PR 2000


Fix miscalculation of PSNR with frame reordering

With frame reordering enabled, every other frame would be compared to a
blank frame, generating a very low PSNR calculation. Also fixes an issue
where the PlaneIter ends one pixel too early, which currently is only
used by PSNR calculation.

Coverage decreased (-0.7%) to 79.359% when pulling 9355ddb0d79369bb46b222b56ddeb8f162b2c81e on shssoichiro:fix-psnr-calc into d78dc36331581ae1416f7df6deffd0c441582907 on xiph:master.


First manybugs:php bug fails to build with segfault (Ubuntu 16.04)

I'm getting a segfault and failure to build when trying to install the first php bug (but not the second or third):
[14:02] gs17931:RepairBox :) > ./repairbox install bug manybugs:php
building image: 2011-01-06-e7a1d5004e-3571c955b5
Failed to build image: squareslab/repairbox:manybugs-php-2011-01-06-e7a1d5004e-3571c955b5
Saved error log to:<PHONE_NUMBER>.rbox.crash

[14:05] gs17931:RepairBox :( > tail -15<PHONE_NUMBER>.rbox.crash
Generating phar.phar
PEAR package PHP_Archive not installed: generated phar will require PHP's phar extension be enabled.
invertedregexiterator.inc
directorygraphiterator.inc
pharcommand.inc
clicommand.inc
directorytreeiterator.inc
make: *** [ext/phar/phar.phar] Segmentation fault (core dumped)
Traceback (most recent call last):
  File "/experiment/prepare.py", line 62, in <module>
    cmd('cd /experiment/src && make -j{}'.format(multiprocessing.cpu_count()))
  File "/experiment/prepare.py", line 24, in cmd
    subprocess.check_call(cmd, shell=True)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command 'cd /experiment/src && make -j4' returned non-zero exit status 2
The command '/bin/sh -c /experiment/prepare.py' returned a non-zero code: 1

1509995041.rbox.crash.txt

Seems to be fixed. Thanks for reporting it!


Rename v14 parameters

I got reviewed for parameters newly added or renamed, and applied changes to rename better names.
This change will be included in v0.14.0 RC2.

In this PR, adding several plugins like BufferedNullOutput are intended?

This change is based on #972, and changes of plugins are done in it.

Okay, I understood.

Tests with ruby 2.2.4 on osx is cancelled by Travis trouble, but others are green.


Add spec conformance to anon function expression's auto completions

Description:
$title

Created issues

[x] https://github.com/ballerina-platform/ballerina-lang/issues/33285
[x] https://github.com/ballerina-platform/ballerina-lang/issues/33291
[x] https://github.com/ballerina-platform/ballerina-lang/issues/33292
[ ] https://github.com/ballerina-platform/ballerina-lang/issues/33312
[ ] https://github.com/ballerina-platform/ballerina-lang/issues/33313

Closing the issue, since all the associated sub issues are fixed


No longer works

It doesn't work anymore

Hi, this is a really old project and I don't intend to maintain it anymore. Hence, you'll probably have to wait for another fork of this project or hopefully, Ecosia adds a dark theme themselves.


Fix warning by specifying LAYERSERIES_COMPAT

Setting it to sumo since this is what I am using currently.

Thx!


order requirement ?

Hi,
The text file data is formatted as follows: https://github.com/muhanzhang/pytorch_DGCNN/tree/master/data

1st line: N number of graphs; then the following N blocks describe the graphs
for each block of text:

a line contains n l, where n is number of nodes in the current graph, and l is the graph label
following n lines:

the ith line describes the information of ith node (0 based), which starts with t m, where t is the tag of current node, and m is the number of neighbors of current node;
following m numbers indicate the neighbor indices (starting from 0).
following d numbers (if any) indicate the continuous node features (attributes)

Originally posted by @daiquocnguyen in https://github.com/daiquocnguyen/Graph-Transformer/issues/1#issuecomment-613182578

Is there an order requirement between nodes in the current graph?

I think it should be as the text file is formatted.


hub.mobileClient._request

I hit error "Not found" in the following method with cordova-android but proceed with no issue for cordova-ios.
Please advice...
var createRegistrationId = function (hub) {
alert('createRegistrationId');
// Variables needed to make the request to the mobile service.
var method = "POST";
var uriFragment = "/push/registrationids";
    var deferred = $.Deferred();
	alert('createRegistrationId2');
    // Send a Notification Hubs registration request to the Mobile Service.
    hub.mobileClient._request(method, uriFragment, null, null, null,
        function (error, response) {
        if (error) {
			//alert('Error: ' + error);
			alert('Error: ' + JSON.stringify(error));
            console.log("Error: " + error);
            deferred.reject("Error: " + error);
        } else {

            // Get the unique registration ID from the Location header.
            var location = response.getResponseHeader("Location");
            var regex = /\S+\/registrations\/([^?]+).*/;
            var regId = regex.exec(location)[1];

            // Return the registration ID.
            deferred.resolve(regId);
        }
    });
    return deferred.promise();
};

Hmm, possibly you need to add the no cache header?  (see: https://github.com/Azure/azure-mobile-services/blob/dev/sdk/Javascript/src/Push/PushHttpClient.js#L10)
May I ask why you are calling registration directly yourself and not using the baked in push object for this?
(Also, beware that _request is a private variable)

Closing as _request is meant to be private, reopen if it occurs using the default push object that makes these calls for you.


add lint ci

Signed-off-by: yxxhero<EMAIL_ADDRESS>add lint ci

https://github.com/helmfile/vals/pull/101/files  @mumoshu
there still are some codes that add nolint comments. I will handle them in the future.


How reload connect?

How reload connect? When disconnecting the connection

From js?
Look at this code:
https://github.com/websockets/ws/wiki/Websocket-client-implementation-for-auto-reconnect


Remove extraneous dependencies

These are not needed by users, only for devs

Please move them to devDependencies instead of deleting them


added make_test_grib_idx function and tests

For local files, I recommend you use full absolute paths to avoid confusion. Also, if you want to test how your function works (which looks like a fixture, by the way), you can first copy the file to local rather than have two filesystems to get confused between.

I thought make_test_grib_idx_files function was part of dynamic zarr store module so I added it. Should we add this to the kerchunk repo?

I don't understand - this PR is already wanting to add that function to the kerchunk repo (this repo).

If it isn't clear, my original comment above was in response to

I need your help here. I can't figure how this test is failing. I've tried two way but failing on both.

which request of yours since disappeared.

No, I meant you said this function looks like a fixture, so I asked the question.

Yes, the function could be made into a function and included in this repo. It is only used for tests, right?

Yes, it will be used for tests.

Will it be used ONLY for tests? If yes, you can try making it a @pytest.fixture. It's purely a style thing, it seems like a fixture to me.

Also, if you want to test how your function works (which looks like a fixture, by the way), you can first copy the file to local rather than have two filesystems to get confused between.
The original implementation copied subset of the grib file to the cloud. I modified it so the subset file could be locally or to the cloud (if you have access to it).

so the subset file could be locally or to the cloud

Right, but apparently this wasn't working as you expected. Thus, it might be simpler to first copy a given file to local, and then make its .idx local->local.

I meant test wasn't working. The function work fine.

If the test fails, maybe you can't be certain that the function is working fine.

No I meant the test which I wrote for the make_grib_test_files functions are failing.

Also this function isn't used anywhere in the actual flow or in the tests. There was bunch of grib-idx pairs the in the asascience-open/nextgen-dmac repository made by David. I waiting for his reply about what to do with this function.

Also this function isn't used anywhere in the actual flow or in the tests.

??
Then why are you wanting to add it to the repo at all?

It was in the original repo, so I thought of adding it. I'll close this PR.


Add gulp-cheerio

gulp-cheerio/gulp-cheerio.d.ts
check list

[ ] is collect naming convention?

https://www.npmjs.com/package/gulp-cheerio
http://bower.io/search/?q=gulp-cheerio
others?

[X] has a test file? (gulp-cheerio/gulp-cheerio-tests.ts or others)
[ ] pass the Travis-CI test?

@tkqubo thanks mate!


Cannot de-select rows when clicking in last selected cell

When using RowSelectionModel to enable multiple row selection in a grid, clicking the last selected cell without holding down the shift/ctrl/alt/meta keys will not de-select other selected rows. Issue may be related to there being no change in the active cell.
The behavior can be reproduced in this example: http://mleibman.github.com/SlickGrid/examples/example9-row-reordering.html

this is pretty nasty, it seems there's no way to clear the selection using ctrl-click

fixed in https://github.com/6pac/SlickGrid

Thanks, that works.  I also noticed another issue, if one row is selected, I can't de-select it using ctrl-click, so it's not possible to deselect all the rows as I would expect using ctrl-click.  Can you please fix that too?

just committed a fix for this.
thanks for persisting, i uncovered what was clearly a bug in slick.rowselectionmodel.js.
i've also added a new test file tests/test-4-rows-paging.html, which is the one i've been using to debug this.


Adding missing  for std::mem* functions

Note to self: add inspect include-checker for std::mem(set|cpy|move)

LGTM


How to have single signUp and login experience from users perspective

Describe the bug
In passwordless (sms) approach, user gets authenticated based on verification of an OTP that is issued to the user. To user it does not matter whether it is signUp or a login as both of them involve same process of OTP verification. How can this be achieved?
Steps To Reproduce
This is not a bug. Probably a common use case that is either missing, not documented or required as improvement. I chose it for "Create a report to help us improve" which is under Bug Report.
Expected behavior
OTP verification should be sufficient for user authentication without distinguishing, to user, that it is  a signUp (first time) or login (subsequent times).
Amplify Framework Version
1.28.0
Amplify Categories
Auth
Dependency manager
Cocoapods
Swift version
5.0
CLI version
9.2.1
Xcode version
13.4 (13F17a)
Relevant log output
No response
Is this a regression?
No
Regression additional context
No response
Device
iPhone11 - Real Device (ModelNo: MHDD3HN/A)
iOS Version
iOS 15.6.1
Specific to simulators
No response
Additional context
No response

Auto signIn while signingUp a user is not currently support. We will take this as a feature request and reply in this issue when we have more information.

Any update on when autosign will be supported on native Android/iOS?
At the moment, it is not possible to implement passwordless auth flow with Amplify.


[Errno 2] No such file or directory: 'gifs/inp0.png'

Objective of issue:  No such file or directory error
Lava version:

[ ] 0.3.0 (feature release)
[ ] 0.2.1 (bug fixes)
[x] 0.2.0 (current version)
[ ] 0.1.2

Current behavior:
When I run this cell:
output = net(input.to(device), mode=scheduler.mode(100, 0, False))
for i in range(5):
img = (2*input[i].reshape(28, 28).cpu().data.numpy()-1) * 255
Image.fromarray(img).convert('RGB').save(f'gifs/inp{i}.png')
out_event = slayer.io.tensor_to_event(output[i].cpu().data.numpy().reshape(1, 10, -1))
out_anim = out_event.anim(plt.figure(figsize=(10, 3.5)), frame_rate=2400)
out_anim.save(f'gifs/out{i}.gif', animation.PillowWriter(fps=24), dpi=300)
I get this error:
[Errno 2] No such file or directory: 'gifs/inp0.png'
Other information:
I have Python 3.8.5 for my virtual environment.

Hi @remotepilotsam I am assuming you are trying to run the nmnist notebook. There should already be a gifs folder: https://github.com/lava-nc/lava-dl/tree/main/tutorials/lava/lib/dl/slayer/nmnist/gifs
Just try running this line alone and check if the gif is saved in the folder
Image.fromarray(img).convert('RGB').save(f'gifs/inp0.png')

If you have copied the notebook elsewhere, can you make sure the folder exists?

Hello @bamsumit yes, it is the MNIST notebook. Thank you for the instructions.  The images are in that folder, and I have the notebook saved in the lava-dl-main folder.  Should the notebook be somewhere else?

Hi @remotepilotsam , either run the notebook from original location. Or create a gifs folder where your notebook is. That should do it.


Add Couchbase Integration Back

These values were switched at some point, this should resolve them.
IMPORTANT EDIT: This also adds back couchbase and fixes the integration tests.
Things to validate before this is merged:

[x] For the memory metric state label, the underlying prometheus metric no longer is present in future versions of couchbase. See https://docs.couchbase.com/server/current/metrics-reference/data-service-metrics.html
[x] workload.googleapis.com/couchbase.bucket.error.oom.count had a missing label in the metadata.yaml
[x] Certain Metrics value_types needed to be changed from DOUBLE => INT64

couchbase.bucket.error.oom.count
couchbase.bucket.operation.count

[x] GAUGE => CUMULATIVE  was missed in metadata.yaml, fixed in upcoming PR
[x] Change bucket metric label to bucket_name

@qingling128 I think this brings things in line for couchbase, we can look over this next week, but kokoro appears to have out of sync metric descriptors. I believe what the metadata.yaml that this PR has is what was expected but would you mind double checking just to be sure? Thanks again, I really appreciate it!

@ridwanmsharif are you sure about the resetting of couchbase descriptors for the kokoro project?
Currently still seeing this error in the otel logs
Jul  7 18:18:03 github-test-20220707-5c680-14c11534-3f76-4fd6-8b8a-958a4874ce48 otelopscol[3989]: 2022-07-07T18:18:03.005Z#011error#011exporterhelper/queued_retry.go:149#011Exporting failed. Try enabling retry_on_failure config option to retry on retryable errors#011{"error": "failed to export time series to GCM: rpc error: code = InvalidArgument desc = One or more TimeSeries could not be written: Value type for metric workload.googleapis.com/couchbase.bucket.oom.count conflicts with the existing value type (DOUBLE).\nerror details: name = Unknown  desc = total_point_count:26  success_point_count:25  errors:{status:{code:3}  point_count:1}"}

That is very weird. Taking a look. When attempting to delete it again I get:
{
  "error": {
    "code": 404,
    "message": "The metric 'workload.googleapis.com/couchbase.bucket.oom.count' does not exist.",
    "status": "NOT_FOUND",
    "details": [
      {
        "@type": "type.googleapis.com/google.rpc.DebugInfo",
        "detail": "The metric 'workload.googleapis.com/couchbase.bucket.oom.count' does not exist."
      }
    ]
  }
}

So it does look like it was deleted the first time around.

Hmm interesting, I am not a complete expert on how kokoro picks the project, but is there any chance it was a different project do you think? I'll re-run with the op label to see if we get the same error

Will merge if/when @mtabasko green lights the docs changes.


Data types Multiselection error in table

Hi, I created a Multiselection field, but in the table displays the array.
["1","4"] not the values.
Why ?

Hi, do you have resolved the problème ?


Optimize fetch tags query

Since my last commit updates the client to use the latest version of the API, we can leverage some of GROQ's features to make the initial query return a flat array of tags.

Oh, and apologies if there's anything wrong with my formatting here! This is my, like, second pull request to a project that isn't mine 😸

Thank you! This is so much more elegant! Let me quickly test it on some of my weird edge cases, and let's merge this beauty!
As for the formatting, it's all good :))

Thanks again for your contribution, @rlpennell!
I'll make a few minor updates and release it right away!


I will migrate my sponsoring to an opensource company!

Hi Andreas! I want to let you know I will switch my sponsoring to another account.
Thanks in advance!

Hi inetshell,
thank you for your support!


Modules mk

adding support for $(MOD)_CFLAGS is something that I wanted to do for many years.
Please have a look, review and testing is welcome :)


Feature Idea: Image Generation

Summary
It seems that there used to be a command for generating images in this plugin, but it was completely removed in commit c0d47b6. Despite the existence of configuration options, there doesn't appear to be a way to generate images.
Ideally, when calling @ai, I believe it should trigger image generation. Alternatively, having a clear slash command would also work well.
How important this is to me and why
Importance: Medium
While the lack of this feature may not be an immediate issue, I believe there is value in being able to easily generate images while chatting on Mattermost, especially for tasks like prototyping. Even though there are alternative ways to generate images outside of the plugin, the ability to chat and generate images on Mattermost concurrently is valuable.
Use cases:

Use for prototyping and conveying rough ideas during chats with development team members.
Use for aligning images with customers.

Additional context/similar features
Providing a place to interactively generate images, similar to Midjourney, can be extremely useful for sharing specific ideas in real-time with people present and for sparking new ideas.

@esethna @matthewbirtch We remove the slash commands to reduce the amount of maintainance surface, but maybe we should add this feature back in a different way.

@jespino I think this could possibly belong in the available tools we offer for composing a message (similar to how we previously added the icon in the message formatting bar). There may be value in making any of the compose tools available via slash commands as well as there may be an expectation for it.
I assume we would consider these things post v1.0?


Redundant use of constrainedby

Reported by choeger on 13 Sep 2012 08:59 UTC
In Complex.mo line 4, we can see the following:
replaceable Real re constrainedby Real

Section 7.3.2 states that:

If the constraining_clause is not present in the original declaration (i.e., the non-redeclared declaration), the type of the declaration is also used as a constraining type

in that sense we can remove the constrained-clause here and make the code smaller. Since the MSL serves IMO as an example of how to write 'good' Modelica, we should try not to confuse readers with redundant code.

Migrated-From: https://trac.modelica.org/Modelica/ticket/819

Comment by sjoelund.se on 24 Sep 2012 10:03 UTC
Fixed in b4f184846f59cade297a4254ea2513f8a8a6699d

Modified by sjoelund.se on 24 Sep 2012 10:04 UTC


METRON-262: Update codelab image scripts

Used new image and adjusted start script.

+1 Looks good

+1 by inspection


$watch inside ui bootstrap tabs not working

Hi all!
I am having an issue with the Drop and upload with $watch example http://jsfiddle.net/danialfarid/s8kc7wg0/400/ everything works fine if I use it in the normal way but when I put it inside ui boostrap tabs https://angular-ui.github.io/bootstrap/#/tabs the upload function is not triggering, as if the $watch wasn't actualy watching the files.
Here is the code which is working in the normal way but not inside ui boostrap tabs...!
  $scope.$watch('files', function () {
      $scope.upload($scope.files);
  });
  $scope.upload = function (files) {
    console.log("trigger")
  };

Hope you can help me!
Thx for this awesome project!

You can use a controller scope function for ngf-change="filesSelected($files) as an alternative.

Thank you very much @danialfarid works like a charm!
I used ngf-change="upload($files)" and is triggering when it has to!
Congratulations for the awesome work you are doing! Keep it up! :+1:


Rename ON_MISSING_INCLUDE_FILE configuration and property names

Impact

[ ] Bug fix (non-breaking change which fixes expected existing functionality)
[x] Enhancement/New feature (adds functionality without impacting existing logic)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
Update configuration and property names from ON_MISSING_INCLUDE PR
Fixes #3898
Things to be aware of

None

Things to worry about

None. This is just a minor refactoring with the intention to have more specific names and more clear documentation.

Additional Context

None

@mhewedy after discussing with the product and docs teams, we have agreed on making a minor update to your PR. We think these new names are more specific and will be more clear for users. Any feedback or concern from your side will be more than welcome.
Thanks again,
Daniel.

@mhewedy after discussing with the product and docs teams, we have agreed on making a minor update to your PR. We think these new names are more specific and will be more clear for users. Any feedback or concern from your side will be more than welcome.
Thanks again, Daniel.

No Concern, LGTM
Thanks 😊


Add support for CLong and CULong

Currently long is either an int or nint (depending on windows-types or unix-types). Can use CLong for latest codegen with .NET6

This is a complicated change to make for many reasons, most particularly due to how Clang can only parse for one platform.
I suggest you add a --remap long=CLong and --with-namespace CLong=System.Runtime.InteropServices if it is appropriate for your particular generation scenario


kube-burner split

Type of change

[x] Refactor
[ ] New feature
[ ] Bug fix
[ ] Optimization
[x] Documentation Update

Description
Refactor repository organization for the repo split, highlights:

All the OCP related logic has been moved to https://github.com/kube-burner/kube-burner-ocp, which is already working since it's actually using the core branch of this repository https://github.com/kube-burner/kube-burner/tree/core
CI tests and documentation moved to kube-burner-ocp as well, The OCP wrapper will have its own documentation site, we can make reference it in the future from the main docs site
New SetupCmd() and ConfigureLogging functions,  also used by the OCP wrapper to configure logger and version subcmd
Making helpers.go platform agnostic, by adding a new clusterType type to define the cluster type.

New switch statement to gather metadata depending on the cluster type
Since the profile-type is an OpenShift thing, the Run method now receives a list of alertProfiles/metricProfiles, which must be configured in the wrapper side
envVars are now set in the wrapper side, there's no need to establish them here

Related Tickets & Documents

Related Issue https://github.com/orgs/kube-burner/discussions/528
Closes #

Checklist before requesting a review

[x] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.

cc: @shashank-boyapally


Can't create a new material by dragging a shader on user-exported properties if they're not specifically ShaderMaterials

Godot version
4.1.1
System information
linux
Issue description
simplescreenrecorder-2023-09-16_07.31.44.webm
as you can see, I can't automatically create a new ShaderMaterial by dropping a shader on a material slot when the material slot is one I exported from a script, unless I set the export type to ShaderMaterial specifically (not showcased in video).
Steps to reproduce
@export var wont_work: Material
@export var will_work: ShaderMaterial

and then drop a Shader resource on both of those in the inspector.
Minimal reproduction project
the script above and an empty .gdshader file

Is this expected or a bug?
The export property's base_type in editor_resource_picker is Material for won't work and ShaderMaterial for will work, but the
GeometryInstance3D's material field's base_type is BaseMaterial3D,ShaderMaterial.
And in _get_allowed_types , for a ShaderMaterial,  it will insert a Shader to allowed_types, but for Material it won't do so. That's why we can't drag a shader directly to the exported material property.
https://github.com/godotengine/godot/blob/571cd0eb791b37e9a8adda9f909251138170f6b7/editor/editor_resource_picker.cpp#L624-L632
https://github.com/godotengine/godot/blob/571cd0eb791b37e9a8adda9f909251138170f6b7/editor/editor_resource_picker.cpp#L680-L689


Add web and nginx images to docker compose

Adds a web image (the NestJS service) to docker compose

This web image reads the APPLICATION_PORT and the EXCHANGE_API_KEY from the local environment and uses these values for configuring the service
This is mostly to showcase how the web image works behind the Nginx reverse proxy (no other environment variables/configuration will be read)

Adds a Nginx image as a reverse proxy in docker compose

The container behind this image is accessible to the host via NGINX_HOST_PORT (defaults to 8080)
This container is responsible to redirect the incoming requests to the underlying web application

@luarx this configuration should give us an initial template on how we can deploy this to our environment.

Coverage: 78.395%. Remained the same when pulling 4bef18a6c8e301bda9b54f9201b2c2c4881956ab on docker-compose-setup into c569e875548062f5630ba3254c51cf7da6a58be4 on main.


Add show all front pages partial to newspaper issue show page

This should be a proper fix for Issue #88.

This looks good, nice work! I pulled this branch, tested locally, and it worked as expected.
A couple of small updates, if possible?

Add spec for NewspaperTitlePresenter#front_page_search_params
Make the link a button so it's more visible
Change link text to View all front pages

Thanks!


problem with ipysigma

Hi ，
I followed the example and found that I cannot display the network properly.
All I got is something like this "Sigma(data={'nodes': [(0, {'club': 'Mr. Hi'}), (1, {'club': 'Mr. Hi'}), (2, {'club': 'Mr. Hi'}), (3, {'club': …".  And no picture is displayed.
Did I miss something？

Did you run
jupyter nbextension enable --py --sys-prefix ipysigma

after installing the lib?

Yes.
And when I opened "https://github.com/Yomguithereal/ipysigma/blob/master/notebooks/Examples.ipynb",  I got the same result.

Interesting.
It works fine now：）

Yes it is possible. Can you open a related issue so I remember to add this later?


Style of Auto Complete Text Box not working

hi, everyone, the style is not working . I tried modifying both "inputContainerStyle" and "containerStyle".
i wanted a textbox style with just ” borderBottomWidth: 1 “, can you please let me know how to modify the “Autocomplete” textBox style.
Thanks,

Hi, Autocomplete use a TextInput and that styles are not supported.
More info here:
https://facebook.github.io/react-native/docs/textinput#style


win,tty: Added set cursor style to CSI sequences

This is for adding a set cursor style(CSI Ps SP q, CSI SP q) to handling of libuv escape sequence. This was originally created for neovim(neovim/neovim#8462).
Fix except 3. of #1874. I confirmed 3. with another terminal(xterm, mintty). Since another terminal accepted a sequence like CSI Ps ; Ps ; Ps H, I did not fix it.

@erw7 any way to unit test this?

Please tell me about uv_tty_virtual_offset. I think that uv_tty_virtual_offset is equivalent to info-> srWindow.Top(Unless the cursor position has been moved on the program side using SetConsoleCursorPosition etc.). Is something wrong with using info->srWindow.Top instead of uv_tty_virtual_offset?

Nice work @erw7.
All these tests are awesome -- we have to get this in.

Note that on windows 10 these tests don't all pass, because windows processes the escape sequences and not libuv. Maybe you can somehow forcefully enable libuv's escape sequence processing when running the tty tests?
test output

1..340
ok 1 - tty
ok 2 - tty_cursor_back
ok 3 - tty_cursor_down
ok 4 - tty_cursor_forward
ok 5 - tty_cursor_horizontal_move_absolute
ok 6 - tty_cursor_move_absolute
ok 7 - tty_cursor_next_line
ok 8 - tty_cursor_previous_line
ok 9 - tty_cursor_up
ok 10 - tty_empty_write
ok 11 - tty_erase
ok 12 - tty_erase_line
not ok 13 - tty_escape_sequence_processing
# exit code 3
# Output from process `tty_escape_sequence_processing`:
# line:1 col:1 expected character 'H' but found ' '
# line:1 col:2 expected character 'e' but found ' '
# line:1 col:3 expected character 'l' but found ' '
# line:1 col:4 expected character 'l' but found ' '
# line:1 col:5 expected character 'o' but found ' '
# line:1 col:6 expected character 'H' but found ' '
# line:1 col:7 expected character 'e' but found ' '
# line:1 col:8 expected character 'l' but found ' '
# line:1 col:9 expected character 'l' but found ' '
# line:1 col:10 expected character 'o' but found ' '
# Assertion failed in c:\users\bertbelder\d\libuv\test\test-tty-escape-sequence-processing.c on line 1362: compare_screen(&tty_out, &actual, &expect)
ok 14 - tty_file
ok 15 - tty_full_reset
ok 16 - tty_hide_show_cursor
ok 17 - tty_large_write
ok 18 - tty_pty
ok 19 - tty_raw
ok 20 - tty_save_restore_cursor_position
ok 21 - tty_set_cursor_shape
not ok 22 - tty_set_style
# exit code 3
# Output from process `tty_set_style`:
# line:23 col:77 expected character 'H' but found ' '
# line:23 col:77 expected attributes '0' but found '7'
# line:23 col:78 expected character 'e' but found ' '
# line:23 col:78 expected attributes '0' but found '7'
# line:23 col:79 expected character 'l' but found ' '
# line:23 col:79 expected attributes '0' but found '7'
# line:23 col:80 expected character 'l' but found ' '
# line:23 col:80 expected attributes '0' but found '7'
# line:23 col:81 expected character 'o' but found ' '
# line:23 col:81 expected attributes '0' but found '7'
# Assertion failed in c:\users\bertbelder\d\libuv\test\test-tty-escape-sequence-processing.c on line 1093: compare_screen(&tty_out, &actual, &expect)

Maybe you can somehow forcefully enable libuv's escape sequence processing when running the tty tests?

I think that tty tests use libuv escape sequence processing, because I call uv__set_vterm_state in the initialize_tty function and set UV_SUPPORTED for uv__vterm_state.
When I compiled with MSYS 2 MinGW 64-bit on WIndows 10 installed in Virtual Box, I passed the corresponding test.

What's remaining to do here? I'd love to have scroll region support on windows (to support sticky progress and other log messages in Julia terminals). However this is such an epic and useful rearrangement that I don't want to fiddle with the CSI code before this is merged.

@c42f AFAIS fixing conflicts and addressing some unaddressed feedback.

AFAIS fixing conflicts and addressing some unaddressed feedback.

@saghul I rebased this and the conflict was resolved. Is the only remaining problem https://github.com/libuv/libuv/pull/1884#issuecomment-406839147. I do not understand the cause well. ReadConsoleOutputCharacter can not read HELLO which should have been written to the console. There are two possibilities:

ReadConsoleOutputCharacter was called before it was actually written.
Scrolling occurred and the written HELLO moved out of the screen.

Both are difficult for me to think about, are there any other causes?

No @stale, this is not obsolete.
Couple of obvious things: (1) A conflict in the CMakeLists which needs fixing (2) The previous review suggested breaking up into two commits for clarity (https://github.com/libuv/libuv/pull/1884#pullrequestreview-346071320) (3) Adherence to C89 syntax mentioned above.
I've no personal opinion on (2) and (3), but I'd love to see this finally land!

As you, the reader, might be aware, I don't maintain libuv any more.
But this looks good to me, especially since it adds a whole lot of tests, and if @erw7 is around to address any regressions it might cause, I would just hit the merge button.
@vjtnash WDYT?

Yep, I've already reviewed thoroughly and approve of it. Needed a few style nits addressed (I haven't checked them, but think that erw7 did them), and I think it'd be good to split into two commits (as c42f just referenced also). erw7 should be able CI and land this (and a couple other related PRs of his) once he finishes #2662.

CI: https://ci.nodejs.org/view/libuv/job/libuv-test-commit/1757/
Is the ipc_closed_handle test on linux flaky? If there is no problem, I want to land.

Yes, that test has known bugs (https://github.com/libuv/libuv/issues/2307). SGTM.

@erw7 feel free to land!

Landed in https://github.com/libuv/libuv/commit/288a06727b7ef74283369606d2002947d62d4ed0, https://github.com/libuv/libuv/commit/73ca4ac0d1e8eec74da2015f6f3072c980166d63.

Awesome, thanks @erw7 this is epic! Now this is in, revisiting scroll region handling seems more approachable.


feat(user): Mark config for deletion

This PR allows the user to mark a config for deletion in the next sync.
The reason for marking instead of directly deleting is to prevent misuse if the user wants to sync the config immediately by deleting and importing.
This is my first time working with Svelte and TRPC so feel free to criticise as much as you like.
This PR has some hiccups we may want to address first:

[ ] The mark for deletion button is not reactive.
[ ] We should style the button properly and make the style reactive too.

The reason for marking instead of directly deleting is to prevent misuse if the user wants to sync the config immediately by deleting and importing.

Interesting consideration! I think it's OK to not consider this for now though, and if we see it being an issue we can add a rate limit when adding a config.

The reason for marking instead of directly deleting is to prevent misuse if the user wants to sync the config immediately by deleting and importing.

Interesting consideration! I think it's OK to not consider this for now though, and if we see it being an issue we can add a rate limit when adding a config.

I've simplified things as you recommended.

@codicocodes please let me know if any changes are required.

This is to call attention to an issue that this PR should fix, but might not.  If you have a config and a plugin pointing to the same repository, only one will receive updated statistics (in my case star count has been out of sync for many days).  Deleting one or the other is presumably the solution.  However there could be some forms of update logic that would not respond in the expected way to a deletion in this scenario.  Whether that is the case here I don't know, just pointing out the possibility.

This is to call attention to an issue that this PR should fix, but might not. If you have a config and a plugin pointing to the same repository, only one will receive updated statistics (in my case star count has been out of sync for many days). Deleting one or the other is presumably the solution. However there could be some forms of update logic that would not respond in the expected way to a deletion in this scenario. Whether that is the case here I don't know, just pointing out the possibility.

You shouldn't have the same repository pointing to both a config and a plugin.
Plugins are only synced once a week, that's likely why you're reporting mismatch in stars.


Docker compose errors

When attempting to install via docker compose I am getting the follow error.
root@ssdnodes-6582dbb1769a2:~/docker/r3# docker-compose up
Building r3
[+] Building 2.5s (8/8) FINISHED                                                                                docker:default
=> CACHED [internal] load git source https://github.com/r3-team/r3_docker.git#main                                                                                0.3s
=> [internal] load metadata for docker.io/library/debian:stable-slim                                                                                1.0s
=> [1/5] FROM docker.io/library/debian:stable-slim@sha256:4255c9f8a4d6e66488adc0c2084c99df44bda22849b21b3afc0e9746e9a0be18                                                             0.0s
=> https://rei3.de/downloads/REI3_3.6_x64_linux.tar.gz                                                                                0.4s
=> CACHED [2/5] RUN bash -c 'mkdir -p /opt/r3/data/{certificates,files,temp,transfer}'  && apt-get update  && apt-get install imagemagick ghostscript postgresql-client ca-certificat  0.0s
=> CACHED [3/5] WORKDIR /opt/r3                                                                                0.0s
=> CACHED [4/5] ADD https://rei3.de/downloads/REI3_3.6_x64_linux.tar.gz .                                                                                0.0s
=> ERROR [5/5] RUN tar -xvf REI3_3.6_x64_linux.tar.gz r3 config_template.json  && sed -i "s/localhost/r3_db/g" config_template.json  && sed -i "s/443/80/g" config_template.json  &&   0.7s

[5/5] RUN tar -xvf REI3_3.6_x64_linux.tar.gz r3 config_template.json         && sed -i "s/localhost/r3_db/g" config_template.json    && sed -i "s/443/80/g" config_template.json     && chmod 755 r3 && chmod 644 config_template.json    && rm REI3_3.6_x64_linux.tar.gz:
0.572
0.572 gzip: stdin: not in gzip format
0.576 tar: Child returned status 1
0.576 tar: Error is not recoverable: exiting now

Dockerfile:28
27 |     ADD https://rei3.de/downloads/REI3_${r3_version}${r3_os_arch}linux.tar.gz .
28 | >>> RUN tar -xvf REI3${r3_version}${r3_os_arch}linux.tar.gz r3 config_template.json
29 | >>>      && sed -i "s/localhost/${r3_db_host}/g" config_template.json
30 | >>>      && sed -i "s/443/80/g" config_template.json
31 | >>>      && chmod 755 r3 && chmod 644 config_template.json
32 | >>>      && rm REI3${r3_version}_${r3_os_arch}_linux.tar.gz

33

ERROR: failed to solve: process "/bin/sh -c tar -xvf REI3_${r3_version}${r3_os_arch}linux.tar.gz r3 config_template.json \t&& sed -i "s/localhost/${r3_db_host}/g" config_template.json \t&& sed -i "s/443/80/g" config_template.json \t&& chmod 755 r3 && chmod 644 config_template.json \t&& rm REI3${r3_version}${r3_os_arch}_linux.tar.gz" did not complete successfully: exit code: 2

ERROR: Service 'r3' failed to build : Build failed

root@ssdnodes-6582dbb1769a2:~/docker/r3#

I have attached an example for the yml file

docker-compose.yml.txt

You seem to be referencing an outdated R3 release (R3.6). Make sure that you are using a version that is available under All releases on https://rei3.de/en/downloads. A current release is for example R3.7.
You can either set the release version in the file or via environment variable (s. README).

No response, closing issue.


podman-remote push

enable podman-remote push so that users can push images from a
remote client.
change in push API to deal with the need to see output over the
varlink connection.
Signed-off-by: baude<EMAIL_ADDRESS>

LGTM

/lgtm


Support static addresses in secondary network IPAM

Support configuring static addresses in the CNI IPAM configuration,
besides allocating IPs from IPPools.
Signed-off-by: Jianjun Shen<EMAIL_ADDRESS>

This is my last planned change for secondary network IPAM.

Codecov Report

Merging #3633 (f4687bb) into main (c463028) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3633      +/-   ##
==========================================
- Coverage   43.76%   43.72%   -0.04%
==========================================
  Files         210      210
  Lines       35634    35660      +26
==========================================
  Hits        15594    15594
- Misses      18906    18932      +26
  Partials     1134     1134

Flag
Coverage Δ

unit-tests
43.72% <0.00%> (-0.04%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/agent/cniserver/ipam/antrea_ipam.go
51.08% <0.00%> (-6.48%)
:arrow_down:

pkg/controller/ipam/antrea_ipam_controller.go
77.55% <0.00%> (-1.54%)
:arrow_down:

pkg/apiserver/storage/ram/store.go
77.72% <0.00%> (-1.49%)
:arrow_down:

pkg/agent/openflow/pipeline.go
23.83% <0.00%> (-0.05%)
:arrow_down:

pkg/ipam/poolallocator/allocator.go
47.22% <0.00%> (ø)

pkg/apiserver/certificate/certificate.go
76.85% <0.00%> (+6.48%)
:arrow_up:

/test-all

/test-networkpolicy

/test-integration


Header file is not found but it is in the include path

We have written the needed data into your clipboard because it was too large to send. Please paste.
Type: Bug
Starting build...
/usr/bin/g++ -fdiagnostics-color=always -g /home/tetra/libcamera/src/cam/main.cpp -o /home/tetra/libcamera/src/cam/main
/home/tetra/libcamera/src/cam/main.cpp:14:10: fatal error: libcamera/camera.h: No such file or directory
14 | #include <libcamera/camera.h>
|          ^~~~~~~~~~~~~~~~~~~~
compilation terminated.
Build finished with error(s).
Path is: /libcamera/include/libcamera/camera.h
c_cpp_properties.json
{
"configurations": [
{
"name": "Linux",
"includePath": [
"${workspaceFolder}/**"
],
"defines": [],
"compilerPath": "/usr/bin/gcc",
"cStandard": "gnu17",
"cppStandard": "gnu++14",
"compileCommands": "${workspaceFolder}/build/compile_commands.json"
}
],
"version": 4
}
VS Code version: Code 1.71.0 (784b0177c56c607789f9638da7b6bf3230d47a8c, 2022-09-01T07:24:19.271Z)
OS version: Linux arm64 5.15.61-v8+
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
Cortex-A72 (4 x 1500)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
0, 0, 0

Memory (System)
1.80GB (0.56GB free)

Process Argv
--unity-launch --crash-reporter-id 4bd882d3-b665-49b6-9f5d-92d1332c5563

Screen Reader
no

VM
0%

DESKTOP_SESSION
LXDE-pi

XDG_CURRENT_DESKTOP
LXDE

XDG_SESSION_DESKTOP
lightdm-xsession

XDG_SESSION_TYPE
x11

Extensions (9)

Extension
Author (truncated)
Version

python
ms-
2022.14.0

vscode-pylance
ms-
2022.9.10

jupyter
ms-
2022.8.1002431955

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.9

cmake-tools
ms-
1.12.27

cpptools
ms-
1.12.4

cpptools-extension-pack
ms-
1.3.0

cmake
twx
0.0.17

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30557514
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
pylanb8912:30545647
vsclangdf:30486550
c4g48928:30535728
hb751961:30553087
dsvsc012:30540252
azure-dev_surveyone:30548225
2144e591:30553903

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.71.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Upgraded to v 1.71.1
No joy.
I think the recursion isn't working properly.

/extC++

It looks like this is caused by the C++ extension. Please file the issue to the C++ extension repository. Make sure to check their issue reporting template and provide them relevant information such as the extension version you're using. See also our issue reporting guidelines for more information.
Happy Coding!


Detection of component metadata based on code analysis

It would be helpful to have a generic way to detect information about components.
Context
I'm in the process of integrating techdocs-cli into our Jenkins pipeline. I want it to be very easy for developers to start using this functionality by having the platform automatically figure out how documentation should be built. We will provide an escape valve to allow developers to go off the beaten path but we want to provide convenient defaults for technologies in our ecosystem.
We're planning to have a Jenkins DLS job called buildDocs which will automatically select the mechanism based on information about the component. We'll modify the onboarding screen to explain how documentation will be built for each component, but I need to know what technologies are being used so I can determine how to build the documentation.
Feature Request
It would be helpful if we had this information available inside of Backstage. I would imagine that the actual detection mechanism could be distributed as a library so it can be used in different environments.
Possible Implementation
I don't know. This is why I created this issue. I tried to Google for a library that does the detection of technologies but I couldn't find anything. I know GitHub has information about code that's in the repo but it doesn't provide information about the root of that project.
I would love your thoughts

@Rugvip suggested that we could start with manually providing that metadata. I'm thinking that for now, I'll add some metadata to catalog-info.yaml where users can declare how they want to generate documentation.
It'll have some metadata that'll look something like this,
apiVersion: backstage.io/v1alpha1
kind: Component
metadata:
  name: backstage
  description: |
    Backstage is an open-source developer portal that puts the developer experience first.
  links:
    - title: Website
      url: http://backstage.io
    - title: Documentation
      url: https://backstage.io/docs
    - title: Storybook
      url: https://backstage.io/storybook
    - title: Discord Chat
      url: https://discord.com/invite/EBHEGzX
  annotations:
    github.com/project-slug: backstage/backstage
    backstage.io/techdocs-ref: url:https://github.com/backstage/backstage
    lighthouse.com/website-url: https://backstage.io
    our-org.com/docs:
      - type: dartdoc
spec:
  type: library
  owner: CNCF
  lifecycle: experimental

Another scenario where this would be super useful is to keep tags up-to-date. Let's say you have a tag to store the language and version information used by a component in the follow format <lang>-<version>. Upgrading the version should then be automatically reflected in that tag as well.
One problem I see is the catalog file itself, which does not have any reference to the code and it may part of a monorepo.

One problem I see is the catalog file itself, which does not have any reference to the code and it may part of a monorepo.

That is true. The catalog-info.yaml file might not actually be in the repository. In our case, I can say that it has to be in the root of each project. Same goes for each component in a monorepo.

Just a quick note that specifically annotations, do not support any other value types than strings.

One problem I see is the catalog file itself, which does not have any reference to the code and it may part of a monorepo.

That is true. The catalog-info.yaml file might not actually be in the repository. In our case, I can say that it has to be in the root of each project. Same goes for each component in a monorepo.

Did you see this? :) https://github.com/backstage/backstage/pull/4575
Maybe the name of that annotation should reflect that it's not just for browser use

Just a quick note that specifically annotations, do not support any other value types than strings.

That is great to know.

@freben can I use metadata?

@taras Sure, within reason.
I must admit I'm not entirely sure what's being proposed here. Essentially I'm not sure what the scope of the ask is. We usually store this kind of information as annotations, and if they are company-local, they can be short and convenient to write because you can just leave out the prefix.
annotations:
  doc-build: custom

@freben your answer is what I was looking for. I can essentially use annotations but just need to keep simple as strings.

Yeap. We've been pondering extending annotations to permit any json type value ... but not right now :)

Good enough for me :)

Can this be closed, or is there something more that I can help with?

We have a workaround but it doesn't address the bigger question of how we can detect metadata about component from it's code. I'll close it for now but we'll have the issue for reference.


Tenant Root Scope appears to not be required for Subscription Placement

The docs at https://github.com/Azure/Enterprise-Scale/blob/main/docs/Deploy/es-schema.md say that Tenant Root Scope is needed for subscription placement. I am using the ALZ-Bicep repository, but assuming they are doing the same thing I am in fact able to run the subscriptionPlacement.bicep with only Owner at the Root management group. Just posting to check if this is expected and if maybe the doc should be updated. Or maybe this doc doesn't apply to the actions from the ALZ-Bicep repo?

Hey @joshuadmatthews,
You are indeed correct, only permissions on the sub and management group is required here.
Do you want to put a PR in to update the doc you referenced to update it?

TIP: you can use the browser and just click on the pencil in the top right hand corner of the document to update it and submit a PR:

fixed in #1029


Any available test for android to exercise uniqush-push?

Hi Folks,
Do you have any readymade test for android client which I can use and play with uniqush push?
-Karthik

If you're talking about sample android apps and sample app servers communicating with uniqush-push, then there's no in depth tutorials, to my knowledge. Looking for blog posts didn't find anything either.
Do you mean something along the lines of (The link is for iOS&APNS, not Android&GCM, and I haven't looked at it in much detail) http://tleyden.github.io/blog/2016/02/03/setting-up-uniqush-with-apns/ , but for GCM?
I'd recommend looking at https://developers.google.com/cloud-messaging/android/start for an example Android app that can receive push notifications.
Also,

Setting up redis and configuring is described in http://uniqush.org/documentation/install.html and linked pages. The blog post for APNS set up redis another way.
Writing an app server: Could use curl just to test things out, similar to what was mentioned in the APNS blog post. But add projectid and apikey instead of cert and key, pushservicetype=gcm instead of pushservicetype=apns, regid instead of devtoken, etc. See http://uniqush.org/documentation/usage.html
The Android App : See https://developers.google.com/cloud-messaging/android/start

Thanks for your reply.


Zabbix not showing as a datasource

After upgrading grafana to 4.0.2 zabbix not showing as a datasource.
I was installed plugin from grafana-cli. Tried reinstalling from repo and from cli.
No errors in grafana log file and browser console.
Zabbix 3.2.0, Grafana 4.0.2, plugin 3.1.2, Ubuntu 16.04
Can someone help me?

Fixed. I created datasource manually.


Disable jitify for cub & Bump CCCL

Based on Leo's comment in https://github.com/cupy/cupy/issues/8209#issuecomment-2155784474
The CUB generic reduction routines are enabled by default and they use jitify, thus initializing the jitify cache.
Since CUB now fully supports NVRTC we can disable the jitify compilation and avoid the jitify initialization just for running CuPy regular routines.
This PR needs to bump cccl to allow cub to be compatible with nvrtc without using jitify.
I have used the latest commit available in cupy's cccl fork, which seems to include the msvc patch.
However, this patch was greatly changed in https://github.com/NVIDIA/cccl/pull/1420 and I am not sure if there is a regression or not, so let me kick all the CIs.

/test full

Strange, I can compile and run tests locally with cuda 12.4, I guess it may be the CI gcc version. I am running it with 11.4

I've synced https://github.com/cupy/cccl main branch with upstream.

Thanks! I was able to reproduce the errors in my local env after doing a build from 0.
I will try with the current head, but probably will hit the thrust issues again. I am thinking on having a stable branch with the old cccl and the new nvrtc CUB if nothing else works.
Another quick solution while we harmonize everything would be to disable the CUB backed reduction by default. This will avoid the jitify initialization problem for the majority of users.

/test full

I merged this with #8221, fixed it for NVRTX & and bumped CCCL to the latest commit.

Lots of timeouts here, likely because the kernel cache is invalidated. We can tentatively bump the timeout limit as done previously in commit fd00150534c0aef3f803487c7a09262d31dcc124 and revert it once this PR is merged.

It's ok to increase the timeout as Leo suggested. Besides that, there are errors reported (before the timeout) which are likely related to this PR, e.g.:
https://ci.preferred.jp/cupy.linux.cuda120/164308/
05:17:52.808601 STDOUT 1303]	FAILED cupy_tests/core_tests/test_raw.py::TestRawJitify_param_0_{jitify=False}::test_jitify1

https://ci.preferred.jp/cupy.linux.cuda123/164314/
04:52:56.265113 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_0_{block=64, n=10}::test_grid_sync_rawkernel
04:52:56.265117 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_0_{block=64, n=10}::test_grid_sync_rawmodule
04:52:56.265124 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_1_{block=64, n=100}::test_grid_sync_rawkernel
04:52:56.265126 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_1_{block=64, n=100}::test_grid_sync_rawmodule
04:52:56.265129 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_2_{block=64, n=1000}::test_grid_sync_rawkernel
04:52:56.265136 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_2_{block=64, n=1000}::test_grid_sync_rawmodule
04:52:56.265138 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_3_{block=256, n=10}::test_grid_sync_rawkernel
04:52:56.265154 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_3_{block=256, n=10}::test_grid_sync_rawmodule
04:52:56.265175 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_4_{block=256, n=100}::test_grid_sync_rawkernel
04:52:56.265177 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_4_{block=256, n=100}::test_grid_sync_rawmodule
04:52:56.265180 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_5_{block=256, n=1000}::test_grid_sync_rawkernel
04:52:56.265186 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawGridSync_param_5_{block=256, n=1000}::test_grid_sync_rawmodule
04:52:56.292626 STDOUT 1298]	FAILED cupy_tests/core_tests/test_raw.py::TestRawJitify_param_0_{jitify=False}::test_jitify1

Btw I noticed timeouts are not happening in CUDA 12.3+ CIs. Maybe thanks to the compile time improvement mentioned in CUDA 12.3 release notes? This is great 🎉

Discussed with Emilio, test_jitify1 can be removed since the assumption (that Jitify must be run first) no longer holds. Will check other failures once either of us gets a chance

Will check other failures once either of us gets a chance

The remaining of the failing tests are:

using nvcc,
including only cooperative_groups.h and nothing else
have the following bf16/fp16 conversion issues

/home/leof/miniforge3/envs/cupy_cuda125_dev/bin/../targets/x86_64-linux/include/cuda_bf16.h(4977): error: no instance of overloaded function "__half::__half" matches the specified type
  __half::__half(const __nv_bfloat16 f)
          ^

1 error detected in the compilation of "/tmp/tmpnoptin0u/4c03e54824ab5700c6f58a6b4b706396b4c17527.cu".

This happens because CuPy-bundled fp16 headers (added in CUDA 12.2) are incompatible with the latest bf16 headers (that somehow are loaded unconditionally by nvcc, despite that cooperative_groups.h and its dependencies do not include any bf16/fp16 headers.
@emcastillo @kmaehashi May I suggest a two-step approach? I'd really like to get this PR merged asap so that we have time to get it backported to v13.3.0 given its perf/UX improvement. So,

We skip the failing grid-sync tests for nvcc >12.2, and get this merged/backported
In a separate PR, we add fp16 headers from all CUDA 12.x minor releases (we did this in the old days). Given that the fp16/bf16 headers are rapidly evolved by the math libs team and they move in lock steps, but we can't redistribute bf16 headers, this is necessary.

In the near future, once we depend on nvmath-python, we rely on it to search for headers from pip wheels, conda packages, or system CTK (following the logic done here, which might later be refactored into cuda-python). Alternatively, we can also copy/paste the logic here, though I prefer to let us (NVIDIA) maintain this. In any case, once this is done then the bundled headers can again be removed, at the price of a few extra (small) NVIDIA wheels becoming a dependency.

@kmaehashi could you grant me write/maintainer access to the cupy/cccl fork? I have a minor fix to address https://github.com/NVIDIA/cccl/issues/2095.

@kmaehashi could you grant me write/maintainer access to the cupy/cccl fork? I have a minor fix to address NVIDIA/cccl#2095. See cupy/cccl#1.

Added write permission!

/test full

It seems the CI failures are in 3 categories

Early termination: CI just ended prematurely with the error "execution function exceeded the context's deadline"
Memory error: All tests passed normally, the kernel cache statistics was shown, but the CI returned an error "excessive memory usage is detected"
Actual test failures: Looking into this...

/test full

/test full

2. In a separate PR, we add fp16 headers from all CUDA 12.x minor releases (we did this in the old days). Given that the fp16/bf16 headers are rapidly evolved by the math libs team and they move in lock steps, but we can't redistribute bf16 headers, this is necessary.

It seems we'll have to do this at least for CUDA 12.5... I can reproduce the test_vectorize.py failures from pfn-public-ci/cupy.linux.cuda125 locally.

/test full

I tested locally and it should build with cccl main.
I am not sure whether we need the thrust fix anymore

Discussed with @miscco to ensure we're on the same page. Here's what happened with this PR in the past two days:

I found the NVRTC+Thrust issue, I reported it in https://github.com/NVIDIA/cccl/issues/2095
I pushed a patch to CuPy's CCCL fork: https://github.com/cupy/cccl/pull/1
@miscco fixed it in CCCL main the next day: https://github.com/NVIDIA/cccl/pull/2102
I switched to CCCL main (commit 08e6a3c) to avoid patching myself, and hit the thrust::less issue (https://github.com/NVIDIA/cccl/issues/2109)
I reverted back to use the fork (which is CCCL main as of 2 days ago + my NVRTC patch)

Things are looking good, will check back later today for the remaining running CIs.
@kmaehashi I've eliminated the other two classes of errors and we're now left with the benign one:

Memory error: All tests passed normally, the kernel cache statistics was shown, but the CI returned an error "excessive memory usage is detected"

any advice for how to proceed here? Is the CI memory limit configurable on your side?

Is the CI memory limit configurable on your side?

Ah it seems to be configurable in .pfnci/config.pbtxt, @kmaehashi is it ok that I bump it to 60 GB? Any bad consequences (such as increased fees)? 😛

Things are looking good, will check back later today for the remaining running CIs.

Confirmed all tests passed 🎉 Now we just need to figure out a path forward for merging (due to the excessive memory error raised at the end of the CI runs).

As all CIs have passed let's proceed to merge. If the excessive memory error happens in main branch as well let's consider increasing the size.
(But not sure why this started to happen... In our CI docker image is on the RAM disk, so the cause may be due to increase of the assets and/or real memory usage increase)

When building Docker images, do you squash layers? Or do you build everything in one layer? If not, that might be a way to cutdown on image size

As all CIs have passed let's proceed to merge. If the excessive memory error happens in main branch as well let's consider increasing the size.
(But not sure why this started to happen... In our CI docker image is on the RAM disk, so the cause may be due to increase of the assets and/or real memory usage increase)

Note that the OOM errors only happened with Linux + CUDA 11.8 - 12.3; with CUDA 12.4 and above or any CUDA on Windows (that got run in the CI) does not have this issue. Therefore my thinking is it might be related to NVRTC and is something that can be improved in future CUDA.
Also, I suspect we only need a temporary memory limit increase; once the kernels are cached I hope to see less OOM, though this part is harder to investigate properly yet quickly.

Thanks to all, @emcastillo @miscco @kmaehashi!


RecordAction tooltip property should take a function

This can be symmetrical with the way tooltips are generated on columns.

Don is taking care of this with a different approach in app land -- we took a look, and the implementation looked tricky for something with a relatively small payoff


Additional quants please!

Love your program.  However, I was wondering if the other quants could be included as well that are on the ctranslate2 docs; specifically, int8_float32, int8_float16, int8_bfloat16?  I believe that's all of them, but doublecheck here:
https://opennmt.net/CTranslate2/quantization.html
Almost forgot!  Please also include bfloat16 if you can!

Thanks for reporting this. The new types have been added recently.
Version 0.31 will include new ones

Thanks....Is it possible to use this command instead if I don't want to wait for the official release?  pip install git+https://github.com/jordimas/whisper-ctranslate2.git

I released a version this morning, doing this should give you the last version:
pip3 install whisper-ctranslate2==0.3.1

I ran the command above that I mentioned and it installed version .3.2...Is this OK or do you think that there might be something unstable?

It states: whisper-ctranslate2 0.3.2

No, at the moment 0.3.1=0.3.2 since I just bump the version

Got it, thanks!


The command fails with the error "invalid operation: 1 << j (shift count type int, must be unsigned integer)"
bash # go version
go version go1.12.4 linux/amd64

bash # go get -v -u github.com/minio/minio-go
...
# github.com/minio/md5-simd
go/src/github.com/minio/md5-simd/block_amd64.go:157:14: invalid operation: 1 << j (shift count type int, must be unsigned integer)
go/src/github.com/minio/md5-simd/block_amd64.go:194:14: invalid operation: 1 << j (shift count type int, must be unsigned integer)
github.com/minio/minio-go/pkg/s3utils

go1.12 is not supported.


Review Old Codebase (Drone.cs)

Make sure to close issue when you have completed this task!

Done


Move loading indicator to tab icon element

Resolved / Related Issues
Items resolved / related issues by this PR.

Closes #3922

Details of Changes
Add details of changes here.

Added progress ring to TabViewItem template, and add visual states for loading/not loading
Add and implemented code to switch the tab loading indicator
Removed code for old loading status indicator

Validation
How did you test these changes?

[x] Built and ran the app
[ ] Tested the changes for accessibility

Screenshots (optional)
https://user-images.githubusercontent.com/59544401/121791871-8962e680-cba3-11eb-8a4a-128d85ee342a.mp4

@winston-de Should this apply to the vertical tab flyout as well?

@winston-de Should this apply to the vertical tab flyout as well?

Been waiting for this for a while. Looks splendid!


zflecs wasm32 target

I tried:
$ cd libs/zflecs
$ zig build test -Dtarget=wasm32-emscripten --sysroot $HOME/code/emsdk/upstream/

zig build-lib zflecs Debug wasm32-emscripten: error: error(compilation): clang failed with stderr: In file included from /home/kdm/code/zig/uber-graphen/zflecs/libs/flecs/flecs.c:19:
/home/kdm/code/zig/uber-graphen/zflecs/libs/flecs/flecs.h:580:10: fatal error: 'assert.h' file not found

zig build-lib zflecs Debug wasm32-emscripten: error: the following command failed with 1 compilation errors:
/snap/zig/8241/zig build-lib -cflags -fno-sanitize=undefined -DFLECS_NO_CPP -DFLECS_USE_OS_ALLOC -DFLECS_SANITIZE -- /home/kdm/code/zig/uber-graphen/zflecs/libs/flecs/flecs.c -lc --cache-dir /home/kdm/code/zig/uber-graphen/zflecs/zig-cache --global-cache-dir /home/kdm/.cache/zig --name zflecs -static -target wasm32-emscripten -mcpu generic -I /home/kdm/code/zig/uber-graphen/zflecs/libs/flecs --sysroot /home/kdm/code/emsdk/upstream/ --listen=-
Build Summary: 0/4 steps succeeded; 1 failed (disable with --summary none)
test transitive failure
└─ run zflecs-tests transitive failure
   └─ zig test zflecs-tests Debug wasm32-emscripten transitive failure
      └─ zig build-lib zflecs Debug wasm32-emscripten 1 errors
/home/kdm/code/zig/uber-graphen/zflecs/libs/flecs/flecs.c:1:1: error: unable to build C object: clang exited with code 1

Has anyone tried wasm building on this lib alone ?
Others solving this:

https://www.reddit.com/r/Zig/comments/sdcafd/zig_emscripten/
https://github.com/michal-z/zig-gamedev/pull/309 (still open, and far too complex for me)
https://github.com/bluesillybeard/ZigAndRaylibSetup
https://github.com/Not-Nik/raylib-zig/issues/24

I think your sysroot path is wrong, it should be something like --sysroot path/to/emsdk/upstream/emscripten/cache/sysroot
Also some changes to zflecs build.zig would be required to build flecs C lib for emscripten. You could try the following:
zflecs_c_cpp.defineCMacro("__EMSCRIPTEN__", "1");
zflecs_c_cpp.addIncludePath(.{
    .path = try std.fs.path.join(b.allocator, &.{ b.sysroot.?, "include" }),
});

Note: I haven't tried this myself

Relevant info: https://github.com/zig-gamedev/zig-gamedev/pull/309#issuecomment-1887598549


Incompatible with current version of league/oauth2-client

Current release is 2.2.1
https://github.com/thephpleague/oauth2-client/releases
composer require riskio/oauth2-auth0
Using version ^0.1.0 for riskio/oauth2-auth0
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for riskio/oauth2-auth0 ^0.1.0 -> satisfiable by riskio/oauth2-auth0[v0.1.0].
    - Conclusion: remove league/oauth2-client 2.2.1
    - Conclusion: don't install league/oauth2-client 2.2.1
    - riskio/oauth2-auth0 v0.1.0 requires league/oauth2-client ~0.10 -> satisfiable by league/oauth2-client[0.10.0, 0.10.1, 0.11.0, 0.12.0, 0.12.1].
    - Can only install one of: league/oauth2-client[0.10.0, 2.2.1].
    - Can only install one of: league/oauth2-client[0.10.1, 2.2.1].
    - Can only install one of: league/oauth2-client[0.11.0, 2.2.1].
    - Can only install one of: league/oauth2-client[0.12.0, 2.2.1].
    - Can only install one of: league/oauth2-client[0.12.1, 2.2.1].
    - Installation request for league/oauth2-client (locked at 2.2.1) -> satisfiable by league/oauth2-client[2.2.1].

Is this client compatible?

No, it is not compatible with the latest versions. I am currently working on upgrading this to support the latest version. You can check this fork for details: https://github.com/phronesis/oauth2-auth0

@connerbw check out the newly released version, it resolves the issue.


dx12: TYPELESS format conversion

D3D12 ERROR: ID3D12Device::CreateRenderTargetView: The resource format (R16G16B16A16_FLOAT) and view format (R16G16B16A16_UINT) differ in float vs non-float component interpretation - this type of format casting is not supported. [ STATE_CREATION ERROR #38: CREATERENDERTARGETVIEW_INVALIDF

Apparently we need to convert formats into typeless variants on resource creation. Would be interesting to know if there is a drawback and if we need to do it for all type of resources.

https://msdn.microsoft.com/en-us/library/windows/desktop/mt426647(v=vs.85).aspx I think you need typeless or partially typed on the resource then you can use formats inside the format family for views?

L : typeless format
PCS : partially typed, castable and simple layout
FCS : fully typed, castable and simple layout
FNS : fully typed, non-castable and simple layout
PCC : partially typed, castable and complex layout
FCC : fully typed, castable and complex layout
FNC : fully typed, non-castable and complex layout
V : video format

yes, the PCS\PCC (alias _TYPELESS) formats. I wasn't aware that additionally cast between data types are forbidden which is quite irritating to me.


Invalid processing of command arguments with spaces

Executing command: add instances --project test --name test --flavor ^c2-m7.6-d60$ --image 'Ubuntu 14.04 trusty (updated 2016-09-23)' --network ^TEST$ --count 1
At least 1 image with name = Ubuntu 14.04 trusty (updated 2016-09-23) should exist
perspective*>add instances --project test --name test --flavor ^c2-m7.6-d60$ --image '^Ubuntu 14.04 trusty (updated 2016-09-23)$' --network ^TEST$ --count 1
Going to add 1 instances:

Need to escape special chars like ( and ] in regexps.

Decided that such behavior is correct. Wizards should always escape expressions with ^$. In the rest of cases we correctly consider expression as regex.


azure-mgmt-nspkg 3.0.1 breaks installation of azure>=2.0.0,<3

Recently (11 minutes at the time of writing) azure-mgmt-nspkg 3.0.1 was released (https://pypi.org/project/azure-mgmt-nspkg/#history). I just happened to be updating a virtualenv shortly after and was met by the following error:
Collecting azure-nspkg>=2.0.0 (from azure-batch~=3.0.0->azure<3,>=2.0.0->gatekeeper>=0.6.0->-r req.txt (line 4))   Using cached https://files.pythonhosted.org/packages/1e/0b/41cf166cb9b3fcaf24d68c59a6358e05ab974117bbe7368c86689b9c127c/azure-nspkg-3.0.1.zip     Complete output from command python setup.py egg_info:     running egg_info     creating pip-egg-info/azure_nspkg.egg-info     writing pip-egg-info/azure_nspkg.egg-info/PKG-INFO     writing top-level names to pip-egg-info/azure_nspkg.egg-info/top_level.txt     writing dependency_links to pip-egg-info/azure_nspkg.egg-info/dependency_links.txt     writing manifest file 'pip-egg-info/azure_nspkg.egg-info/SOURCES.txt'     error: package directory 'azure' does not exist
Setting a requirement on azure-mgmt-nspkg<3.0.1 in the line before azure>=2.0.0,<3 solves the issue. For technical reasons, we depend on being able to install azure<3, is this no longer supported and if so, does this workaround bring any unintended side effects to the best of your knowledge?

+1 this also just happened to all my tests that were previously working
@lmazuel
Downloading https://files.pythonhosted.org/packages/45/2d/1cd3391bf8a46402aac5d68590782a9993eb507ece0716ef8afb30a3f4df/azure-mgmt-nspkg-3.0.1.zip
    Complete output from command python setup.py egg_info:
    running egg_info
    creating pip-egg-info\azure_mgmt_nspkg.egg-info
    writing requirements to pip-egg-info\azure_mgmt_nspkg.egg-info\requires.txt
    writing pip-egg-info\azure_mgmt_nspkg.egg-info\PKG-INFO
    writing top-level names to pip-egg-info\azure_mgmt_nspkg.egg-info\top_level.txt
    writing dependency_links to pip-egg-info\azure_mgmt_nspkg.egg-info\dependency_links.txt
    writing manifest file 'pip-egg-info\azure_mgmt_nspkg.egg-info\SOURCES.txt'
    error: package directory 'azure\mgmt' does not exist

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in c:\users\appveyor\appdata\local\temp\1\pip-install-l7geut\azure-mgmt-nspkg\
Command exited with code 1

Could you all confirm this is Python 2 and is fixed now?

Was closed by github actually on merging the PR for 3.0.2. If you still experience the issue once 3.0.2 is on PyPI, please still comment here.
Thank you,

@lmazuel It's fixed for me now. Thanks!
Yes, all my tests were running Python 2.7


Non-persistent example fails with KeyError

The following example is provided as a non-persistent example.
import mii pipe = mii.pipeline("mistralai/Mistral-7B-v0.1") response = pipe(["DeepSpeed is", "Seattle is"], max_new_tokens=128) print(response)
Running this code via deepspeed as:
deepspeed --num_gpus 1 mii-test.py
Fails with the following output.
[rank0]: Traceback (most recent call last):
[rank0]:   File "/root/DeepSpeed/examples/inference/huggingface/zero_inference/mii-test.py", line 2, in
[rank0]:     pipe = mii.pipeline("mistralai/Mistral-7B-v0.1")
[rank0]:   File "/root/deepspeed/lib/python3.10/site-packages/mii/api.py", line 231, in pipeline
[rank0]:     inference_engine = load_model(model_config)
[rank0]:   File "/root/deepspeed/lib/python3.10/site-packages/mii/modeling/models.py", line 17, in load_model
[rank0]:     inference_engine = build_hf_engine(
[rank0]:   File "/root/deepspeed/lib/python3.10/site-packages/deepspeed/inference/v2/engine_factory.py", line 93, in build_hf_engine
[rank0]:     checkpoint_engine = HuggingFaceCheckpointEngine(path)
[rank0]:   File "/root/deepspeed/lib/python3.10/site-packages/deepspeed/inference/v2/checkpoint/huggingface_engine.py", line 24, in init
[rank0]:     self.model_config = AutoConfig.from_pretrained(self.model_name_or_path, **hf_kwargs)
[rank0]:   File "/root/deepspeed/lib/python3.10/site-packages/transformers/models/auto/configuration_auto.py", line 1028, in from_pretrained
[rank0]:     config_class = CONFIG_MAPPING[config_dict["model_type"]]
[rank0]:   File "/root/deepspeed/lib/python3.10/site-packages/transformers/models/auto/configuration_auto.py", line 726, in getitem
[rank0]:     raise KeyError(key)
[rank0]: KeyError: 'mistral'
dsreport off my system
2024-10-29 21:50:27,584] [INFO] [real_accelerator.py:219:get_accelerator] Setting ds_accelerator to cuda (auto detect)
/root/deepspeed/lib/python3.10/site-packages/transformers/utils/generic.py:260: FutureWarning: torch.utils._pytree._register_pytree_node is deprecated. Please use torch.utils._pytree.register_pytree_node instead.
torch.utils._pytree._register_pytree_node(
/root/deepspeed/lib/python3.10/site-packages/transformers/utils/generic.py:260: FutureWarning: torch.utils._pytree._register_pytree_node is deprecated. Please use torch.utils._pytree.register_pytree_node instead.
torch.utils._pytree._register_pytree_node(
DeepSpeed C++/CUDA extension op report
NOTE: Ops not installed will be just-in-time (JIT) compiled at
runtime if needed. Op compatibility means that your system
meet the required dependencies to JIT install the op.
JIT compiled ops requires ninja
ninja .................. [OKAY]
op name ................ installed .. compatible
async_io ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
cpu_adam ............... [NO] ....... [OKAY]
cpu_adagrad ............ [NO] ....... [OKAY]
cpu_lion ............... [NO] ....... [OKAY]
[WARNING]  Please specify the CUTLASS repo directory as environment variable $CUTLASS_PATH
evoformer_attn ......... [NO] ....... [NO]
[WARNING]  FP Quantizer is using an untested triton version (3.1.0), only 2.3.(0, 1) and 3.0.0 are known to be compatible with these kernels
fp_quantizer ........... [NO] ....... [NO]
fused_lamb ............. [NO] ....... [OKAY]
fused_lion ............. [NO] ....... [OKAY]
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -c /tmp/tmpn_ff2b7b/test.c -o /tmp/tmpn_ff2b7b/test.o
x86_64-linux-gnu-gcc /tmp/tmpn_ff2b7b/test.o -L/usr/local/cuda -L/usr/local/cuda/lib64 -lcufile -o /tmp/tmpn_ff2b7b/a.out
x86_64-linux-gnu-gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -c /tmp/tmp1vi0yr9a/test.c -o /tmp/tmp1vi0yr9a/test.o
x86_64-linux-gnu-gcc /tmp/tmp1vi0yr9a/test.o -laio -o /tmp/tmp1vi0yr9a/a.out
gds .................... [NO] ....... [OKAY]
transformer_inference .. [NO] ....... [OKAY]
inference_core_ops ..... [NO] ....... [OKAY]
cutlass_ops ............ [NO] ....... [OKAY]
quantizer .............. [NO] ....... [OKAY]
ragged_device_ops ...... [NO] ....... [OKAY]
ragged_ops ............. [NO] ....... [OKAY]
random_ltd ............. [NO] ....... [OKAY]
[WARNING]  sparse_attn requires a torch version >= 1.5 and < 2.0 but detected 2.5
[WARNING]  using untested triton version (3.1.0), only 1.0.0 is known to be compatible
sparse_attn ............ [NO] ....... [NO]
spatial_inference ...... [NO] ....... [OKAY]
transformer ............ [NO] ....... [OKAY]
stochastic_transformer . [NO] ....... [OKAY]
DeepSpeed general environment info:
torch install path ............... ['/root/deepspeed/lib/python3.10/site-packages/torch']
torch version .................... 2.5.0+cu124
deepspeed install path ........... ['/root/deepspeed/lib/python3.10/site-packages/deepspeed']
deepspeed info ................... 0.15.3, unknown, unknown
torch cuda version ............... 12.4
torch hip version ................ None
nvcc version ..................... 12.4
deepspeed wheel compiled w. ...... torch 2.5, cuda 12.4
shared memory (/dev/shm) size .... 125.66 GB

I ended up creating a new venv and it appears to be working.
I was leveraging a venv that had deepspeed requirements installed then I added deepspeed-mii requirements.
I think there is some conflict between the requirements for deepspeed and deepspeed-mii
Unclear. but this can be considered closed.