Fortinet FortiNDR Cloud Initialization

Required items, please complete
Change(s):

Solution -> Fortinet FortiNDR Cloud
Sample Data -> Fortinet FortiNDR Cloud

Reason for Change(s):

FortiNDR Cloud integration with Azure Sentinel initialization

Version Updated:

1.0.0

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Need help
Not able to run KQL test locally

Guidance <- remove section before submitting

Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR.  Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process.  Providing associated Issues that this resolves also easily connects the reason.

Change(s):

Updated syntax for XYZ.yaml

Reason for Change(s):

New schema used for XYZ.yaml
Resolves ISSUE #1234

Version updated:

Yes
Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly.  If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:

Guidance for Detection checks
General contribution guidance
PR validation troubleshooting

@FortiNDR-Integration please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement
Contribution License Agreement
This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree company="Fortinet"

Hello @FortiNDR-Integration, Please try to resolve Code QL errors.
Function App zip is missing with Python libraries, Please add those.
You can refer this Data connector for more clarification Solutions/Trend Micro Vision One/Data Connectors

Hello @FortiNDR-Integration, Please try to resolve Code QL errors. Function App zip is missing with Python libraries, Please add those. You can refer this Data connector for more clarification Solutions/Trend Micro Vision One/Data Connectors
Please add workbook metadata to this specific file Workbooks/WorkbooksMetadata.json

Hi @v-prasadboke , we have resolved the Code QL errors, updated the requirements.txt file, and added workbook metadata, please review again, thanks.

Hello @FortiNDR-Integration, Thanks for committing the required changes. Will take a look at it and get back to you by 31 January, 2024.

Hello @FortiNDR-Integration, Can you share working images of function app

Hello @FortiNDR-Integration, Github Bot raised Bump PR's for expired version libraries mentioned in the requirements.txt file.
Please check those out and and remove if necessary. Also the data connector is missing with py libraries. Please add them.
You can refer this zip for more clarification.
Solutions/Cloudflare/Data Connectors/CloudflareConn.zip
PR's raised by GitHub bot #9850 #9849 #9848 #9847 #9846

Hello @FortiNDR-Integration, Requirements.txt includes almost 160 libraries. Please remove which not needed.
Also add python libraries they are missing from the zip, Please raise a new PR for the same.
You can refer this zip Solutions/Cloudflare/Data Connectors/CloudflareConn.zip for more clarification


Error on process exit

dgram.js:630
    throw errnoException(err, 'dropMembership');
    ^

Error: dropMembership EINVAL
    at _errnoException (util.js:1021:11)
    at Socket.dropMembership (dgram.js:630:11)
    at process.<anonymous> (/Users/alan/Code/tableflip/vers/node_modules/broadcast-stream/index.js:12:12)
    at emitOne (events.js:115:13)
    at process.emit (events.js:210:7)
    at process.exit (internal/process.js:154:15)
    at process.on (/Users/alan/Code/tableflip/vers/index.js:28:15)
    at emitNone (events.js:105:13)
    at process.emit (events.js:207:7)
    at Signal.wrap.onsignal (internal/process.js:205:44)

hmm, maybe this is not needed anymore since reuseAddr is set? what do you think @clehner ?

Docs say:

This method is automatically called by the kernel when the socket is closed or the process terminates, so most apps will never have reason to call this.

So i don't think it is needed

I can also repro this issue when killing a child process used by ssb-party

does actually cause problems or does it just output an error message?

It opens an error dialog on process exit for me, which looks bad to the user.

I disabled dropMembership in 0.2.2, let me know it works

Seems to be unnecessary, indeed.


Improve FilterChooser handling of Date and LocalDate value type…

…s (#3578)
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[ ] Caught up with develop branch as of last change.
[ ] Added CHANGELOG entry, or determined not required.
[ ] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[ ] Updated doc comments / prop-types, or determined not required.
[ ] Reviewed and tested on Mobile, or determined not required.
[ ] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

This is looking very promising.
Pushed https://github.com/xh/toolbox/commit/ba20e90887e0d8806ecf992d4a359419a5b3e05b to Toolbox on develop to add an "Order Day" column to the Portfolio example orders detail grid - can use that to test the persistence of a LocalDate type value through the filter chooser favorites.

Another thought - should we leverage toJSON() instead on the concrete classes for the serialization with type and then fold the value-aware handling into parseFilter + add the type field to the spec interfaces for inclusion in FilterLike?
Also - should we skip serializing type for primitives, where it's just extra weight?

Another thought - should we leverage toJSON() instead on the concrete classes for the serialization with type and then fold the type-aware handling into parseFilter + add the type field to the spec interfaces for inclusion in FilterLike?
Also - should we skip serializing type for primitives, where it's just extra weight?

Thought about that, but couldn't remember if we're always dealing with instances of these filters or if we're sometimes dealing with specs.  I can look into that though.
Makes sense to skip serializing type for primitives unless we think the consistency is cleaner? Happy to make that change

Thought about that, but couldn't remember if we're always dealing with instances of these filters or if we're sometimes dealing with specs. I can look into that though.

Great, thanks - good for us to be entirely clear on that if we can, and hoping that the answer is (or can be) instances.

Makes sense to skip serializing type for primitives unless we think the consistency is cleaner? Happy to make that change

Yes I think we should. Always in favor of consistency, but in this case I think it's sufficiently obvious why we would/would not choose to record the type.


onDateChange fires onClick event

Hi @MaTeMaTuK
I have onClick event where I am display some custom popup.
When I change the date (onDateChange), it is firing onclick event too. I want to prevent onClick when change the date.
Please help on this.

Hi @maberalc @MaTeMaTuK @Janlaywss @hexagonatron ,
Any input on above query?

Hi @MaTeMaTuK, I really like this project and would like to contribute. Is this a good issue to work on? Please let me know what you think about this issue.

Hi @SharkyND - do you have work around for this issue?

I think so, but not sure if the repo is actively maintained or not.


Add support for providing folder in argument

Description
Would be nice to have a feature to provide folder as an argument.

I'm following the same policy as pyupgrade here: https://github.com/asottile/pyupgrade/issues/40#issuecomment-396057113
Use pre-commit or find+xargs or whatever to run the tool on all files within a directory.

Thank you for providing a response, Adam.


Add more robust support for --nofix

Currently the --nofix option in the futurize script only supports short names (i.e. not fully-qualified names) and fixers from libfuturize, not from lib2to3. This commit makes usage of --nofix much closer to that of --fix.

Thanks, Nate! :-)


9443 needed for migration?

port 9443 is listed in other pages as needed (with 443) for MIGRATION, but not here

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 104caea8-472d-2fc6-e50f-343d00fddeee
Version Independent ID: bd4ae232-e684-f687-e8a8-3ed7d4d87a10
Content: Support for physical server assessment/migration with Azure Migrate - Azure Migrate
Content Source: articles/migrate/migrate-support-matrix-physical.md
Service: azure-migrate
GitHub Login: @rayne-wiselman
Microsoft Alias: raynew

Thanks for your comment. The feedback has been shared with the content owner for further review. Thanks for your patience.


Tiny goroutine spans misalign stack spans

We don't adjust the start position of stack spans when we adjust the start position of the corresponding goroutine span, which leads to misalignment between the two:

We no longer enforce a minimum width for spans and therefore this is no longer an issue.


Playlist functionality in the example activity

With this feature the buttons in the player can play the next and previous video in the playlist.

Hi, thanks for the PR. Why do you think this change to the sample app is going to be useful?

Hi, thanks for the PR. Why do you think this change to the sample app is going to be useful?

Hello!
I just did a comparison with the Youtube app and this was the only pending thing, this is awsome btw and if you think it´s not necessary i can close this, no problem!!!


[Feature Request] Adjust views to show previous/upcoming events

Need to begin thinking about the logic/views for previous / upcoming events -

[ ] Handle this in the events list view

[ ] Handle this in a view for an individual group

[ ] Handle this in a view for a speaker

https://discourse.gohugo.io/t/group-by-date-and-only-show-posts-that-are-greater-than-today/102/2

Decided that this isn't likely needed for a speaker. Can change the requirement later if needed. This is implemented in an upcoming fix.


Option to set a minimum score needed for ClearlyDefined curations to be taken into account

The quality of curations on ClearlyDefined.io varies quite a bit. Luckily they know that and provide a score that can be used to estimate the quality of each curation.
I suggest that there should be an option (in config file, perhaps also as a flag) to set what the minimum score of a ClearlyDefined.io curation should be for the curation to be used as a conclusion by ORT.
Example:

I decide that a score of 87 or above on ClearlyDefined.io guarantees me that if I scanned the code myself, I would not find anything new
for everything else I want to check the code myself through ScanCode and/or FOSSology

As a side note, @borisbaldassari did something similar for Eclipse over here. Doing this in ORT would probably allow to get rid of that script to reduce complexity on their side.

It would probably be good to first implement https://github.com/oss-review-toolkit/ort/issues/6055.


Rewrtie app from Flask to Flask-restx

Looks like it does work, including /db_list.
@lambotik, the task needs confirmation that your full pipeline goes well e2e.


Trim paragraph margins at the bottom of tab panels

This change affects all themes, however the behavior may also be visually problematic in several themes. I only just noticed it in sphinx-rtd-theme.
Themes that aren't affected probably also aren't affected by the margin change, since in this case they probably don't put margins under p elements.
As I understand sphinx-tabs-panel p:last-child, it will trigger if that particular <p> element is the last of all child elements in the tabs panel. So that should work as intended.
Before:

After:

Just noticed https://github.com/executablebooks/sphinx-tabs/pull/143 - the implementation there wouldn't work for panels with several paragraphs.


Angular10 / tslib 2.0.0 support

🧩 Feature request
Description
Since Angular 10 is out now, sully should support Angular10 in the future.
Checking the current state, scully seems currently incompatible with tslib 2.0.0 which comes with Angular CLI 10 setup.
Executing npm run scully give the following output:
><EMAIL_ADDRESS>scully /Users/dannykoppenhagen/dev/d-koppenhagen/d-koppenhagen-website
> scully "--scanRoutes"

/Users/dannykoppenhagen/dev/d-koppenhagen/d-koppenhagen-website/node_modules/tslib/tslib.js:237
        Object.defineProperty(o, "default", { enumerable: true, value: v });
               ^

TypeError: Cannot redefine property: default
    at Function.defineProperty (<anonymous>)
    at /Users/dannykoppenhagen/dev/d-koppenhagen/d-koppenhagen-website/node_modules/tslib/tslib.js:237:16
    at Object.__importStar (/Users/dannykoppenhagen/dev/d-koppenhagen/d-koppenhagen-website/node_modules/tslib/tslib.js:246:9)
    at Object.<anonymous> (/Users/dannykoppenhagen/dev/d-koppenhagen/d-koppenhagen-website/node_modules/@scullyio/scully/lib/utils/cli-options.js:5:23)
    at Module._compile (internal/modules/cjs/loader.js:1147:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1167:10)
    at Module.load (internal/modules/cjs/loader.js:996:32)
    at Function.Module._load (internal/modules/cjs/loader.js:896:14)
    at Module.require (internal/modules/cjs/loader.js:1036:19)
    at require (internal/modules/cjs/helpers.js:72:18)

You can check out the source code here
Seems to be related to https://github.com/scullyio/scully/issues/543
Describe the solution you'd like
Support tslib 2.0.0
Describe alternatives you've considered
 Have you considered any alternative solutions or workarounds?

Let's get this addressed tomorrow, please. The v10 stuff needs to be top priority.

Just for testing purpose, I just tried with a new project
npm install -g @angular/cli
ng new testProject
ng add @scullyio/init
ng build
npm run scully

and got the same result
><EMAIL_ADDRESS>scully /Users/josesalazar/Dev/Synapse Ads/go-famed/gofamed-landing
> scully

/Users/josesalazar/Dev/Synapse Ads/go-famed/gofamed-landing/node_modules/tslib/tslib.js:237
        Object.defineProperty(o, "default", { enumerable: true, value: v });
               ^

TypeError: Cannot redefine property: default
    at Function.defineProperty (<anonymous>)
    at /Users/josesalazar/Dev/Synapse Ads/go-famed/gofamed-landing/node_modules/tslib/tslib.js:237:16
    at Object.__importStar (/Users/josesalazar/Dev/Synapse Ads/go-famed/gofamed-landing/node_modules/tslib/tslib.js:246:9)
    at Object.<anonymous> (/Users/josesalazar/Dev/Synapse Ads/go-famed/gofamed-landing/node_modules/@scullyio/scully/lib/utils/cli-options.js:5:23)
    at Module._compile (internal/modules/cjs/loader.js:1158:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
    at Module.load (internal/modules/cjs/loader.js:1002:32)
    at Function.Module._load (internal/modules/cjs/loader.js:901:14)
    at Module.require (internal/modules/cjs/loader.js:1044:19)
    at require (internal/modules/cjs/helpers.js:77:18)

Angular CLI: 10.0.0
Node: 12.16.1
OS: darwin x64

Angular: 10.0.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.1000.0
@angular-devkit/build-angular     0.1000.0
@angular-devkit/build-optimizer   0.1000.0
@angular-devkit/build-webpack     0.1000.0
@angular-devkit/core              10.0.0
@angular-devkit/schematics        10.0.0
@ngtools/webpack                  10.0.0
@schematics/angular               10.0.0
@schematics/update                0.1000.0
rxjs                              6.5.5
typescript                        3.9.5
webpack                           4.43.0

The problem is tsLib. It now must by a direct dependency. However, when I do that, the V10 CLI runs into problems.
I'm working with the Angular CLI team to get this issue resolved, but for the mean time, there doesn't seem to be a solution.
I can't move our mono-repo to V10 before NX supports V10, and that might still not be the solution.
Please note, this is actually the result of a breaking change in Typescript between V3.8 and 3.9, and I'm unaware of a proper solution just yet.

For now, a work around solution is install tslib directly from github:
"tslib": "git@github.com:microsoft/tslib.git"

@tieppt ya workaround works. ty for that. 👍
at least my build is running again 😉

@tieppt thanks workaround worked for me too!

@tieppt I wonder how this can possible solve the issue unless their development version actually fixes the breaking change. I hope that will be the case because that would solve quite some problems with TS.
In the meantime, I have added tsLib 1.13 as a direct dependency on all Angular packages. This is part of pr #658, and will probably land today. This should help, but is probably not the final fix. I will push out new versions once this PR is merged.

@SanderElias Dear Sir, after dig into the tslib repo, I saw a commit to fixed default issue https://github.com/microsoft/tslib/commit/23642901c0cfc63dff8da27c4c8c71acd265445a

After upgraded to<EMAIL_ADDRESS><EMAIL_ADDRESS>I got Circular dependency error for Router.
Please clone this branch and start the Angular app.
https://github.com/tieppt/tiepphan/tree/circular

I faced NullInjectorError after I upgraded<EMAIL_ADDRESS>Angular v10 with patched tslib and<EMAIL_ADDRESS>worked, though.

I faced NullInjectorError after I upgraded<EMAIL_ADDRESS>Angular v10 with patched tslib and<EMAIL_ADDRESS>worked, though.

Thanks. This solution worked for me.

@tieppt As we didn't use any import * that was an easy fix ;)
However, we where exporting things with export *. I moved to explicit exports and updated the package.json to allow any angular version. (for now, we will restrict this later on). This is part of pr #695.
I went ahead and published ng-lib .26.
Perhaps you can give this a try?

@SanderElias I'll try it asap

The NullInjectorError seems to be solved on<EMAIL_ADDRESS>Thank you @SanderElias .

The NullInjectorError seems to be solved on<EMAIL_ADDRESS>Thank you @SanderElias .

I can confirm that.

Closing as the problem is solved with #695


Problem to run ionic command line

From @zhouhao27 on March 5, 2016 9:25
Got the following error message:

Error: Cannot read property 'indexOf' of null

When I was trying to run:

ionic emulate ios
cordova prepare
ionic build

But ionic server is fine.
Tried both ionic-cli 1.7.14 and 2.0.0.beta19. Both the same problem.
Copied from original issue: driftyco/ionic#5728

Closing as a duplicate of https://github.com/driftyco/ionic-cli/issues/815, please track it there, thanks!


[libSyntax] Miscellaneous minor improvements

This PR contains changes from #36165.

This PR is a collection of minor improvements to libSyntax

Fix some formatting issues where lines contain more than 80 columns
Change OpaqueSyntaxNode to be a const void * pointer instead of void * since its data is not supposed to be modified
Remove discaredRecordedNode. Since RawSyntax is no longer reference counted, none of the implementations did anything and the comment in there says, we should get rid of it anyway.

@swift-ci Please test

Full test suite passed earlier. Just running smoke tests after rebasing onto main.
@swift-ci Please smoke test


Updating Titanic Example

→ Description 📝
I am working on updating the Titanic example to follow the "cleaned" data from @lydiajessup. The changes are:

adding "fare class*
using strings as input labels
passing in an object to predict().

At the moment, I'm stuck on training with this error. Investigating...

@shiffman - currently inputs need to be an array rather than json object! That might do it!

Here are the ways I imagine passing in the inputs. The first (array) I am getting an error. The second (object) we do not yet support but could consider.
Passing in array:
let inputs = ['first', 'female', 32, 100];
neuralNetwork.classify(inputs, gotResults);

Passing in Object
  let inputs = {
    age: 32,
    fare: 100,
    fare_class: 'first',
    sex: 'female'
  };
  neuralNetwork.classify(inputs, gotResults);

@shiffman - Noted! At the moment, we can only pass in an array that matches the normalized data.
So in this instance:
[32, 100, 'first', 'female'] ==> [0.32, 0.7, 0,0,1, 0, 1]
This is due to the oneHot encoding. We may have to do some refactoring to handle this in a manageable way. TBA!

Indeed I can confirm that works! The example now manually encodes the inputs with notes about possible other ways of handling it.
function classify() {
  let age = parseInt(select('#age').value());
  let fare = parseInt(select('#fare').value());
  let fare_class = select('#fare_class').value();
  let sex = select('#sex').value();

  // TODO: Support inputs same as data formats: ['fare_class', 'sex', 'age', 'fare'],
  // TODO: Autonormalize or more likely include extra step of normalizaton
  // let inputs = [fare_class, sex, age, fare,];

  // Evenutally also support objects
  // let inputs = {
  //   age: 32,
  //   fare: 100,
  //   fare_class: 'first',
  //   sex: 'female'
  // };

  // For testing now
  let inputs = [0.32, 0.7, 0, 0, 1, 0, 1];
  neuralNetwork.classify(inputs, gotResults);

AMAZING!!!! This is so beautiful to see!!!

WIP:

Oh, I seriously ❤the naming of the property legend. This is a great way of handling it (better than some of the futzing I was just doing. . Don't forget to 💤!)


Random id for resources in dev mode

I noticed that (running npm run dev) my tileboard would not update on F5, if it is served over my usual channel, i.e. the HA server. I suggest to add an ?id=Date.now() to the ressources in dev mode, as a convenience. (Although it is obviously possible to use the dev server on port 8080 and everything works fine.)

So you are running a development server on PI (or wherever you are running HA) but serving the files through HA's server?
Maybe you want to run npm run build:watch instead then? This creates production bundles and those have a hash so any change will force the browser to fetch new files.
(The downside is that those builds are slower but you can customize it to make it faster)
Or alternatively, develop with browser developer tools opened and "Disable cache" option enabled?

Yes, that's what I do (did at least).
Will try your suggestions!

Maybe you also have a hint on how to develop / debug less files now? I find it hard to follow the changes they generate in the css, if the css cannot be diff'ed.

From the reviewer's perspective, I don't really miss seeing the CSS changes. Seeing the LESS changes is IMO enough to understand and review the change. It's even easier than looking at generated CSS.
From the development perspective, I also don't miss anything. I can see generated CSS and also it links to respective places in LESS files thanks to source maps.
So I'm not sure I understand the issue.

I'm doing some refactoring on the less code as well. And I'd like to make sure, the result is identical. Source maps are the cue, I was maybe missing.
Also good to know, you'll do fine reviewing without the diff...

I think there are enough options to handle this case already:

use production bundles so that resources are hashed
use dev server to avoid caching
develop with developer tools open with Disable cache option enabled.


Can't translate "Invalid email or password.". Always in default language.

When i try to login, it always show message in default language of i18n "Invalid email or password.".
Message is generated in https://github.com/plataformatec/devise/blob/master/lib/devise/failure_app.rb#L88.
I set other I18n.locale in appliaction_controler.rb in before_action (where * Locale set to 'sl' is printed in log).
But i see in console log that "before_action" is called twice. I guess there is redirect in devise?
Log file:
Started POST "/sl/user/sign-in" for <IP_ADDRESS> at 2015-06-22 04:49:54 +0200
Processing by Devise::SessionsController#create as HTML
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"09Axw5uYvkRJgUts4aIFCf37oArR8zs2O0mG+2BC/XUQAcSbUfCoRk+YEa9k6FBkw9GLcVHraje1kO2on2Gypw==", "user"=>{"email"=>"", "password"=>"[FILTERED]", "remember_me"=>"0"}, "commit"=>"Prijava", "locale"=>"sl"}
* Locale set to 'sl'
Completed 401 Unauthorized in 213ms

en <------- This is printed out from /lib/devise/failure_app.rb#L88, so here translation message is generated.

Processing by Devise::SessionsController#new as HTML
  Parameters: {"utf8"=>"✓", "authenticity_token"=>"09Axw5uYvkRJgUts4aIFCf37oArR8zs2O0mG+2BC/XUQAcSbUfCoRk+YEa9k6FBkw9GLcVHraje1kO2on2Gypw==", "user"=>{"email"=>"", "password"=>"[FILTERED]", "remember_me"=>"0"}, "commit"=>"Prijava", "locale"=>"sl"}
* Locale set to 'sl'

Did i miss something? Where should i set i18n.locale to see "Invalid email or password." in right locale?
Versions:
rails (4.2.0)
warden (1.2.3)
devise (3.5.1)
devise_invitable (1.5.1)

Ok i finally figured it out.
By looking at source i see devise is using prepend_before_filter. So i set I18n.locale in appliaction_controler.rb in prepend_before_filter and now it works. Yey! :)

A pull request to update the docs or README will be very appreciated, thank you!


[ENG - 5008] Support Unicode and special characters in file names during archiving

Purpose
Support Unicode in OSF Storage to prevent archiving failures due to special characters in filenames.
Changes

Enhanced filename normalization to handle Unicode characters.
Updated archiving workflow to ensure proper handling of special characters.

Ticket
https://openscience.atlassian.net/browse/ENG-5008

So this may just be a test failure because the filename is different from what the test is expecting it to be, or it may be because the file failed to copy because there needs to be more work done here.
__________ TestArchiverTasks.test_archive_success_escaped_file_names ___________
osf_tests/test_archiver.py:613: in test_archive_success_escaped_file_names
    archive_success(registration._id, job._id)
/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/celery/local.py:193: in __call__
    return self._get_current_object()(*a, **kw)
/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/celery/app/task.py:379: in __call__
    return self.run(*args, **kwargs)
framework/celery_tasks/utils.py:41: in wrapped
    res = func(*args, **kwargs)
website/archiver/tasks.py:308: in archive_success
    utils.migrate_file_metadata(dst)
website/archiver/utils.py:262: in migrate_file_metadata
    _validate_updated_responses(dst, file_input_qids, updated_file_responses)
website/archiver/utils.py:363: in _validate_updated_responses
    missing_files=missing_responses
E   website.archiver.tasks.ArchivedFileNotFound


Fix divide by zero error when negative prompt is empty

Thanks for the PR. It looks like you've been working on an old version though. Your version is 2.5.6 whereas the latest version is 2.8.4.
The issue should be fixed in this version. Once you update your repo, let me know if it's still a problem


Coal Ore Duplication

Issue description:
Noticed that this was brought up before, but it is still a Mekanism issue. There are mods that allow reliably 6.5 coal from an ore (Integrated Dynamics) up to 8 (Industrial Wires) and a number of others that give 4.
This is an issue, as a number of people are using this dupe to make a continuous cycle and using the extras to make diamonds. Every modpack shouldn't have to change this recipe when it could be changed once and in one spot.
A solution to this would be to simply change the amount of coal needed to make the ore, such as 8 coal per ore.

That just leads to things like the RF inflation. We'd need to up the base amount our machines give from coal ore 'just because mod X does it'

I'm not saying up the amount that the machines give from coal, I'm saying up the amount it takes. Although looking through the code, I can see why that came up, it looks like the combiner looks at the ingredient list to determine how much of the ingredient to have it use. Not sure how feasible it would be, but have the code look for the recipe that gives the max coal, or goes that more run into issues of what recipes are currently loaded at that point?
At the very least, would it be something to have an override where it looks at a config file to determine if an override is necessary? Although that's getting back to modpacks having to change it with scripts. This machine is an interesting case since it's basically the only way that you can turn materials back into ores.

It would mean upping it because all the other recipes are based on being juuuuuust below what we give from the opposite conversion.
Inter-mod balance is 100% on pack authors.

@thiakil I think FallenEagle1 is refering to is using the Combiner machine to make the ore from 3 coal and 1 cob.
Since some mods like Thermal, make 6 coal per ore, and easily you could automate this process with just three machines. Your only expense to run is cob (unless you have Thermal installed and then its 50% profit).
I also noticed that to make a unit of gold ore, you need 8 pieces of dust and 1 cob. Simply increasing the requirement of 8 coal + 1 cob would null this infinite power scenario.

I know exactly what they mean. Like I said, if you have another mod which gives you more coal from the ore than we do, it is on you to fix that with CraftTweaker

Since this was from so long ago, I decided it wasn't worth the hassle and the recipes were just straight up removed from the combiner. Not worth sifting through ore recipes when players are just setting up these loops and they just lag things out. Combiner recipes removed and it fixes the issue.


feat: improve pipelines listing

fixes #20
all the "pipelines listing" pages uses the same template now, with a filter based on the context (owner/repo/branch)

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign vbehar
You can assign the PR to them by writing /assign @vbehar in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: vbehar
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [vbehar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


☂ Project Clarity

We're now at the point where we have various ways to create boards and sub-boards, and the Visual Editor could do with a little streamlining now we're happier with what the features are.
Visual Editor
Board Management

[ ] #3951
[ ] Improve board selection (sub boards, mods-as-sub boards, other boards)
[ ] Add drag behaviors to workspace overview

UI & Navigation

[ ] Add overflow menu to side nav headers
[ ] Tidy up board representations in Workspace Overview
[ ] Recall which kits are expanded / collapsed
[ ] Move export to Activity header area
[ ] Reduce vertical space taken up by Activity
[ ] Confirm command palettes are functioning correctly
[ ] Allow users to set their own board colors
[ ] Allow users to set their own board icons

Bugs

[ ] #3823
[ ] #3822
[ ] #3820
[ ] #3818
[ ] The board information panel shows options irrelevant for sub boards

Breadboard

[ ] #3843
[ ] Encode the graph/subGraph info into TGO.

Done

[x] Add control over when to animate
[x] #3835
[x] #3821
[x] #3941
[x] #3905
[x] #3928
[x] #3934
[x] #3930
[x] Reorder the side navigation
[x] Improve color coding of boards
[x] Differentiate between code boards (runnables) & code
[x] #3899
[x] #3888
[x] #3898
[x] #3911
[x] Move all board related items into the overflow menu
[x] Default-on the components listing
[x] When in module view, show "Capabilities" side panel to allow easy adding of capabilities.
[x] When duplicating/adding a visual board we should pick some good x & y positions
[x] The filter doesn't account for modules, only sub boards
[x] Deleting the active module doesn't switch the view to something else
[x] Clicking anywhere on a tab should change to it
[x] Snapping to components is off for main board
[x] Unify events for navigating either to modules or subgraphs
[x] Show workspace selection state
[x] Create an "add new" view which supports creating declarative, imperative, and remote boards
[x] Indicate to the user that there is a workspace (rather than a board)
[x] Deleting sub boards & modules doesn't update the main nav
[x] Retain board expand/collapse state
[x] Update 'Zoom to fit' to accommodate all visible graphs
[x] Add show/hide toggle for hierarchy view
[x] Create "duplicate board" functionality
[x] Give modules titles
[x] Allow users to toggle between a unified view of all declarative boards and a per-board view
[x] Allow click to navigate between all boards
[x] Include the side menu across all views
[x] Bring components into the side menu

No longer needed

[x] ~Allow people to switch off the "track to object" feature (and decide what to do with it for board runs)~

I've been playing with the new stuff and it's freakishly good. Here is the laundry list of buggy things I've noticed:

when editing modules, switching to another tab sometimes deletes work. I couldn't quite track down whether it happens because the snapshot machinery misbehaves or something else, but the end result is that when I go back to the code tab, it sometimes reverts to a state of before when I left it.
not saving modules with errors, combined with tab switching, is usually 😢. If I just wanted to copy some code from another tab, when I return back, it's reverted to previous save. I wonder if the solution here is some temporary buffer where we store transient edit states for modules?
I've gotten a GL context crashed a couple of times, but not enough to get a screenshot. The end result is that the editor stops rendering and I have to refresh.
When autosave is turned off, it still says "Saved"

These all seem mostly unrelated to the actual multi-graph edits, so that's amazing, right?! It all just works!

Okay, so 1. and 2. from that list are a case of refining the module editing side of things. I feel like there's something here for the graph editing, too, as we all too readily cancel saves there if the user interacts. I'm not sure what the exact approach is here, as you say it may be a case of having an in-memory version of things that we check first when switching tabs... but I'll have a ponder today.
In terms of 3. I have a hunch (no more than that) that I've not been strict enough with clearing out Pixi entities, which has resulted in ever-growing GPU memory usage for textures. As such I've landed a change which tries to make that more concrete, instructing a full purge of a scene graph when a board is removed (tab change etc). Let's see if that helps.
And for 4. that was a missing case in the switch - fixed.


Address codearena audit reports

Describe the bug
This issue is to track the codearena audit: https://github.com/code-423n4/2022-06-connext-findings
This includes the following categories within the above audit repo that need to be addressed:

[x] High Risk (3) : 3-code-arena
[x] Med Risk (2) : 2-code-arena
[ ] QA/Low Risk (0) :
[ ] Gas Optimizations :

Additional context
Please tag the branch above in each category for WIP.
Once each category has had its respective issues resolved (or acknowledged/disputed) within the tagged branch, and the branch has been merged (into 1227 or main, etc), mark off the box for that category.
This is only concerning the first iteration with codearena. If certain issues come back and need to be readdressed (e.g. a dispute was disputed, or a resolve was disputed, etc), a separate tracking issue should be made for that.

Merged 3-code-arena and 2-code-arena into 1227 https://github.com/connext/nxtp/commits/1227-slippage-boundaries

https://github.com/connext/nxtp/pull/1465 draft pr open for gas opti

QA merged into gas opti https://github.com/connext/nxtp/pull/1467

QA and gas optimizations merged


The License issue

I neglected to put the badge at the top of the page above the project name. I also need to make the license section "explain which license the app is covered under.

Finished


Write integration tests for Avro data conversion

It is currently not easy to add integration tests with our test set up using embedded connector.
Find a way to add integration tests for Avro data conversion without having to orchestrate external containers.
┆Issue is synchronized with this Jira Task by Unito

@ikbalkaya I provided a few pointers for how we might do this in our internal Slack channel, can you perhaps explain here the things you tried and what you couldn't quite get to work, so that anyone picking this up in future can build off the learnings you made?

@lmars I tried to summarize my finding and some potential options we can try - hopefully it is clear

@ikbalkaya here are the pointers I provided in the Slack channel:
With regards to starting a schema registry:

Here's how the schema-registry tests start one for an integration test:
https://github.com/confluentinc/schema-registry/blob/master/core/src/test/java/io/confluent/kafka/schemaregistry/RestApp.java#L71-L87

and with regards to producing Avro-encoded data:

if we look at the underlying implementation of produce, I think we can just replicate that in our test code?
https://github.com/apache/kafka/blob/3.1.0/connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java#L407-L414
it's just converting the strings to bytes anyway
we could init our own producer like this: https://github.com/apache/kafka/blob/3.1.0/connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java#L156-L163

Did you try out any of these approaches?


Add tamil translation

Thanks for the PR!
I have a question tho, have you test the font capability? If I remember correctly, only CJK and latin fonts are provided

Yep. Just added a tamil font that should work.

Is the 'Threshold' a lower bound or an upper bound? It works better in Tamil if that's defined.

Ah so it's the cursor move threshold for loading images.
How do you feel about adding a title attribute to the threshold <span> describing what it does?

Like this: https://github.com/ananthb/bridget/tree/threshold-title

Ah so it's the cursor move threshold for loading images.
How do you feel about adding a title attribute to the threshold <span> describing what it does?

this is a breaking change since all i18n files need to update, maybe create another pr?

Yep. Just added a tamil font that should work.

Is it a sans serif font?

this is a breaking change since all i18n files need to update, maybe create another pr?

Sounds good.

Is it a sans serif font? If not would you mind post a picture about it, thanks

I switched to this one just now: https://fonts.google.com/noto/specimen/Noto+Sans+Tamil.
I was using a Noto font labeled serif, but I don't think it actually makes a difference in Tamil.
I found the version labelled Noto Sans Tamil, so I'm using that one now.


fix(create): fix insert column order

[x] Do only one thing
[x] Non breaking API changes
[x] Tested

What did this pull request do?
make insert sql column order stable for unittest

User Case Description
gorm create() interface generated sql not stable for each test run. I changed the map interater to a stable slice in order to keep the column order.

Can you add some unit tests to describe what is being fixed?

add a ut case

the type of defaultValueFieldsHavingValue is a map. before the change, column values is appended by iterating a map, which is not in a stable order. after the change,  column values is appended following the order of FieldsWithDefaultDBValue, which is in  stable order.

Hi @archever,
Thank you for your PR. Could you please remove those dependencies in go.mod? We aim to keep GORM's dependencies clean and tidy.
	github.com/stretchr/testify v1.8.4
)

require (
	github.com/davecgh/go-spew v1.1.1 // indirect
	github.com/pmezard/go-difflib v1.0.0 // indirect
	gopkg.in/yaml.v3 v3.0.1 // indirect
)

@jinzhu done


Enable data tiling for e2e matmul tests.

This PR enables the use of the pack/unpack based data tiling path for the e2e/matmul tests.

Only the last commit is part of this PR, Rest are part of #11224


Fix for issue-93, forcing build system distribution to "trusty"

Summary
Temporary fix for issue-93.
Forces build system distribution to "trusty" to pull openjdk8 to workaround non-passive changes in Java 11 for Spark 2.4.4.
@karthisuku @ysmwei

Merged. Thanks @karthisuku for quick +1.


Implement the aspect-ratio property from CSS Sizing 4

Acceptance criteria

[ ] BCD created
[ ] Property page created
[ ] Live example
[ ] Additional data as needed

The aspect-ratio property spec: https://drafts.csswg.org/css-sizing-4/#aspect-ratio
Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1528375

Closing this bug, and grouping the task together with similar bugs at https://github.com/mdn/sprints/issues/2084


Tar single files

Right now, we expect everything to be a tar. In order to avoid having to deal with single files which are not tarred and can be untarred to a filesystem, we will do the following: Detect if incoming stream is a tar, if not, tar it.

This is harder than it looks because we don't know the name of the file content that has been sent our way.

Somehow need to obtain the path data.
    - name: config
      type: PlainText
      input:
        type: file
        path: "config.yaml"
        compress: true

Please find the Github link I have tried out below.
Github link: https://github.com/mohammad-ammar14/ocm-que/blob/main/db-config.yaml

Yes. So.
    - name: db-deployment
      type: PlainText
      input:
        type: file
        path: "manifests/db-deployment.yaml"
        compress: true

Put this into a folder. Something like that thing I posted in your other issue.

Once we have the thing in place on OCM side, we only need to check if a stream is tar or not then use it.
// checkIfContentIsTar checks if a given content is a tar archive or not.
func isTar(content []byte) bool {
	tr := tar.NewReader(bytes.NewBuffer(content))
	_, err := tr.Next()

	return err == nil
}

The header check is super cheap.

No longer relevant.


[dua] dua registration and re-registration

This is one of the PRs for DUA feature, focusing on the registration and re-registration functionality (self and on behalf of children).
This PR implements
    [dua] dua registration and re-registration

    [Y] registration workflow framework
    [Y] registration and reregistration
    [Y] registration and reregistration on behalf of children
    [Y] add pseudo respone status for test/certification purpose
    [Y] add unit test

As discussed, 1.2 FTD should by default send DUA.req for its children even it doesn't enable DUA feature itself.
Will supplement later or submit a separate PR to test this.

@simonlingoogle
Really appreciate your fast review and valuable feedbacks. Will add extra scenarios in the unit test script to test the functionalities in this PR, like when there is multiple children, and the parent gets various status response for the first child's DUA registering.
Regarding proxy DUA, here are some thoughts when implementing:
First, there is only one DUA registration at a time, guaranteed by the flag mIsDuaPending.
Then, regarding the status in DUA.rsp, we have different process for different code:

If ST_DUA_SUCCESS, i.e. successfully registered, the corresponding bit in mChildDuaRegisteredMask is set, when PerformNextRegistration(), it could move to next one;

If ST_DUA_INVALID and ST_DUA_DUPLICATE, the address will be removed from the child, and corresponding bit in mChildDuaMask is cleared, that is, this child doesn't require registration any more, thus when PerformNextRegistration(), it could move to next one as well.

-If ST_DUA_NO_RESOURCES or ST_DUA_BBR_NOT_BBR, it won't make any difference even if move to next Child, so here simply wait reregistration delay, and register the children that are registered yet when reregistration delay expires and PerformNextRegistration().

If ST_DUA_REREGISTER, as the description in the specification

Registration was accepted but immediate reregistration is required to resolve any potential conflicting state across Domain BBRs
So the flag mRegisterCurrentChildIndex is introduced, and when there is chance to PerformNextRegistration(), the one which requires immediate reregistration would be prioritized.

If ST_DUA_GENERAL_FAILURE, that is the only one I am not sure whether or not existing process is proper:

If it indicates some error on PBBR, it should be fine to keep as what in the PR;
If it indicates something wrong on the DUA.req initiator or the target in DUA.req, it may not proper to block/postpone the registration for the other children.

Comments?

@simonlingoogle
Really appreciate your fast review and valuable feedbacks. Will add extra scenarios in the unit test script to test the functionalities in this PR, like when there is multiple children, and the parent gets various status response for the first child's DUA registering.
Regarding proxy DUA, here are some thoughts when implementing:
First, there is only one DUA registration at a time, guaranteed by the flag mIsDuaPending.
Then, regarding the status in DUA.rsp, we have different process for different code:

If ST_DUA_SUCCESS, i.e. successfully registered, the corresponding bit in mChildDuaRegisteredMask is set, when PerformNextRegistration(), it could move to next one;

If ST_DUA_INVALID and ST_DUA_DUPLICATE, the address will be removed from the child, and corresponding bit in mChildDuaMask is cleared, that is, this child doesn't require registration any more, thus when PerformNextRegistration(), it could move to next one as well.

If ST_DUA_NO_RESOURCES or ST_DUA_BBR_NOT_BBR, it won't make any difference even if move to next Child. So here simply wait reregistration delay, and when expires, register the children that are not registered yet  in PerformNextRegistration().

If ST_DUA_REREGISTER, as the description in the specification

Registration was accepted but immediate reregistration is required to resolve any potential conflicting state across Domain BBRs

So the flag mRegisterCurrentChildIndex is introduced, and when there is chance to PerformNextRegistration(), the one which requires immediate reregistration would be prioritized. (Big chance is that the same child would be found even without this flag, here just for more robustness)

If ST_DUA_GENERAL_FAILURE, that is the only one I am not sure whether or not existing process is proper:

If it indicates some error on PBBR, it should be fine to keep as what in the PR;
If it indicates something wrong on the DUA.req initiator or the target in DUA.req, it may not proper to block/postpone the registration for the other children.

Comments?

@librasungirl
I agree with you that the only case that might not be clear is the ST_DUA_GENERAL_FAILURE. I think if the PBBR returns ST_DUA_GENERAL_FAILURE for one DUA.req, it will highly likely return ST_DUA_GENERAL_FAILURE for other DUA.req too before the issue was resolved on PBBR. So I think it's proper to block other registrations. Moreover, this should rarely happen in real networks.
I agreed with your comments on ST_DUA_INVALID and ST_DUA_DUPLICATE, but since now the Parent is not removing addresses for Children, what is the new strategy to move to the next Child now.

@simonlingoogle
Sorry if there is any confusion. But for ST_DUA_INVALID and ST_DUA_DUPLICATE response,  the parent still is responsible to remove the invalid/duplicate address for its child and clear relative masks, see
https://github.com/openthread/openthread/blob/5e2ddfb2848a7fb602ca6be2a828a102660a01b2/src/core/thread/dua_manager.cpp#L641-L646
The update is when domain prefix changes, the parent simply clears the relative masks, but not clear child's deprecated DUA any more now.
I agree that there might be risk that a child update request with the duplicate address again (e.g. when DUA.ntf fails to send or lost), we may introduce another Stale state to suppress possible invalid DUA.req under this corner case (may also trigger DUA.ntf again to explicitly notify the child to remove the address)
However I am not planning to introduce another bit-vector for this purpose in this PR so far. Maybe leave it to when re-evaluating the option of moving dua relative bits into class child?

OPENTHREAD_CONFIG_TMF_PROXY_MLR_ENABLE and  OPENTHREAD_CONFIG_TMF_PROXY_DUA_ENABLE are defined separately in individual PRs to reduce dependency. However since both are compulsory for 1.2 FTD, I think it might be better to combine these two flags into one, like OPENTHREAD_CONFIG_TMF_PROXY_MLR_DUA_ENABLE, in separate PR.
Thoughts? @simonlingoogle @jwhui

OPENTHREAD_CONFIG_TMF_PROXY_MLR_ENABLE and  OPENTHREAD_CONFIG_TMF_PROXY_DUA_ENABLE are defined separately in individual PRs to reduce dependency. However since both are compulsory for 1.2 FTD, I think it might be better to combine these two flags into one, like OPENTHREAD_CONFIG_TMF_PROXY_MLR_DUA_ENABLE, in separate PR.
Thoughts? @simonlingoogle @jwhui

I think it's fine to use separate flags.


Move dns to another digital ocean box

Off of xdamman's personal box and onto an OC box. Add credentials to vault for any of us to log in.

Login<EMAIL_ADDRESS>Password: in 1password
You should add your ssh key to be able to access the box.
I've already updated Cloudflare. All done.
In case there is any issue, /etc/init.d/nginx restart is your friend.

Should we be sharing the password publicly?
On Fri, Jun 17, 2016 at 4:28 PM Xavier Damman<EMAIL_ADDRESS>wrote:

Closed #136 https://github.com/OpenCollective/OpenCollective/issues/136.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenCollective/OpenCollective/issues/136#event-696424625,
or mute the thread
https://github.com/notifications/unsubscribe/AF0vPU9407Rpfq6ht_wYMn61kGOS3_U7ks5qMwOHgaJpZM4I2ZcY
.


Use existing (.pyi) typing information from library

Question
Please complete:

OS:
macOS (and docker)
Python version import sys; print(sys.version):
3.7.2 (default, Mar 30 2019, 20:19:11)
[Clang 10.0.1 (clang-1<IP_ADDRESS>)]
Pydantic version import pydantic; print(pydantic.VERSION):
1.3

Please read the docs and search through issues to
confirm your question hasn't already been answered.
K.
Where possible please include a self contained code snippet describing your question:
I want to use a library having objects with python type annotation already.
See the *.pyi files like https://github.com/luckydonald/pytgbot/blob/7f39d783c1b939f446121f4d0983f2915c8e3881/code_generation/output/pytgbot/api_types/receivable/media.pyi#L535
I now they have a to_dict() method to get json-able python objects out of them, and the variables are all annotated.
How do I use those models in a D.R.Y way in my project?
As that's a library without depending on pydantic in any way so the classes won't be subclasses of BaseModel , how can I use that typing information which is already there?

I'm afraid I don't understand the question.
Can you explain how this relates to pydantic and what exactly you're trying to do. A short example is often very helpful.

This is how Pydantic does it:
class File(BaseModel):
    file_id: str
    file_unique_id: str
    file_size: int
    file_path: str
# end class File

However I have
library.pyi:
class File(Receivable):
    file_id: str
    file_unique_id: str
    file_size: int
    file_path: str
# end class File

My program:
from library import File
import pydantic

PydanticFile = pydantic.please_make_some_magic_class(File)

PydanticFile(file_id="abcxyz", unique_file_id="abc", file_size=4458, file_path="/o/path/to/file/memes.png")

Basically I try to create a BaseModel from an already existing class.

This isn't possible using just pydantic.
You would need to write your own parser to process library.pyi and write a new python file using pydantic.

Would that be possible with regular py files?

no, pydantic only interprets annotations on subclasses of BaseModel and dataclasses.


Quickstart: Image Analysis 4.0 python on Linux

I tried out the Quickstart: Image Analysis 4.0 on an Ubuntu 22.04 machine. The script quickstart.py
import os
import azure.ai.vision as sdk

service_options = sdk.VisionServiceOptions(os.environ["VISION_ENDPOINT"],
                                           os.environ["VISION_KEY"])

vision_source = sdk.VisionSource(
    url="https://learn.microsoft.com/azure/cognitive-services/computer-vision/media/quickstarts/presentation.png")

analysis_options = sdk.ImageAnalysisOptions()

analysis_options.features = (
    sdk.ImageAnalysisFeature.CAPTION |
    sdk.ImageAnalysisFeature.TEXT
)

analysis_options.language = "en"

analysis_options.gender_neutral_caption = True

image_analyzer = sdk.ImageAnalyzer(service_options, vision_source, analysis_options)

result = image_analyzer.analyze()

if result.reason == sdk.ImageAnalysisResultReason.ANALYZED:

    if result.caption is not None:
        print(" Caption:")
        print("   '{}', Confidence {:.4f}".format(result.caption.content, result.caption.confidence))

    if result.text is not None:
        print(" Text:")
        for line in result.text.lines:
            points_string = "{" + ", ".join([str(int(point)) for point in line.bounding_polygon]) + "}"
            print("   Line: '{}', Bounding polygon {}".format(line.content, points_string))
            for word in line.words:
                points_string = "{" + ", ".join([str(int(point)) for point in word.bounding_polygon]) + "}"
                print("     Word: '{}', Bounding polygon {}, Confidence {:.4f}"
                      .format(word.content, points_string, word.confidence))

else:

    error_details = sdk.ImageAnalysisErrorDetails.from_result(result)
    print(" Analysis failed.")
    print("   Error reason: {}".format(error_details.reason))
    print("   Error code: {}".format(error_details.error_code))
    print("   Error message: {}".format(error_details.message))

fails with the error message:
 Analysis failed.
   Error reason: ImageAnalysisErrorReason.CONNECTION_FAILURE
   Error code: -1
   Error message: Unknown error in sending http request

I did set the endpoint and key variable correctly; the same script, with corresponding endpoint and key variable works on a windows 10 machine. Also, when working from the command line and using curl
curl -H "Ocp-Apim-Subscription-Key: <subscriptionKey>" -H "Content-Type: application/json" "https://<endpoint>/computervision/imageanalysis:analyze?features=caption,read&model-version=latest&language=en&api-version=2023-02-01-preview" -d "{'url':'https://learn.microsoft.com/azure/cognitive-services/computer-vision/media/quickstarts/presentation.png'}"

the microsoft cognitive service works on my Linux machine.
My setting:

Ubuntu 22.04 64-bit
Lenovo Thinkpad X1 Carbon
Intel® Core™ i7-10510U CPU @ 1.80GHz × 8
Python version 3.9
azure-ai-vision version 0.11.1b1

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3370ee1e-7205-b5b2-add1-77fec0ce4366
Version Independent ID: a6d25469-a52e-2233-5a15-cfbb6ed2a3c6
Content: Quickstart: Image Analysis 4.0 - Azure Cognitive Services
Content Source: articles/cognitive-services/Computer-vision/quickstarts-sdk/image-analysis-client-library-40.md
Service: cognitive-services
Sub-service: computer-vision
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@MaurusGubser
Thanks for your feedback! We will investigate and update as appropriate.

@MaurusGubser
It seems like there is a connection issue with the Azure service. You can try the following steps to troubleshoot the issue:

Check if the endpoint and key variables are set correctly.
Check if the machine has internet connectivity.
Check if there are any firewalls or proxies blocking the connection.
Try running the script on a different machine to see if the issue persists.
If the issue persists, you can try using a different endpoint or key to see if that resolves the issue.

For an issue like this, I'd recommend you create a support ticket since the support team will be able to respond much more quickly and have a conversation with you to figure out what could be going on.

@RamanathanChinnappan-MSFT Thanks for your answer and suggestions. So far, I still could not figure out what the exact problem is. However, I managed to run the quickstart.py script in a Debian 11 VM on my machine. I suspect your point 3 might be the problem, but so far, I did not manage to run the quickstart.py script on my machine. I will update this issue, when I find out more.

I have the same problem here.
I was able to run the quickstart.py script by installing a complete Anaconda environment, so I don't think it is firewall or keys  related.
It is very strange...

@YashikaTyagii   I start to suspect it has something to do with the azure-ai-vision library.
I have removed the lib and wrote this (quick and dirty) code, and everything works:
def azure_image_desc(image_url):
    import requests

    url = f"{azure_endpoint}/computervision/imageanalysis:analyze?features=caption,read&model-version=latest&language=en&api-version=2023-02-01-preview"

    headers = {
        "Ocp-Apim-Subscription-Key": azure_subscription_key,
        "Content-Type": "application/json"
    }

    data = {
        "url": image_url
    }

    response = requests.post(url, headers=headers, json=data)

    if response.status_code == 200:
        data = response.json()
        return data['captionResult']['text']
    else:
        return response.text

My Settings:

Ubuntu 23.04 64-bit
MSI Raider with NVIDIA GeForce RTX 2070 Super
Python version 3.11.2
azure-ai-vision version 0.11.1b1

Thank you, we have an SDK installation doc coming soon that will provide more detail on which varieties of Linux can work with which SDKs
#please-close

Also have this issue running on CentOS 7.9.2009 x86_64(Py3.8)

for those landing here, this should be the issue
https://github.com/Azure-Samples/azure-ai-vision-sdk/issues/40#issuecomment-1638669858


Add support for Backup

SableDb should backup its data every N minutes (configurable)
A nice to have: built-in support for S3 bucket upload + the ability to start from an S3 backup

Hi @sabledb-io  I'd like to take this one.

Hi @crrow  feel free to submit a PR.
Few pointers:
SableDb supports replication (both fullsync and WAL tailing). In the fullsync case, SableDb creates a snapshot of the database (which is basically a folder with files), tar the folder and sends it over to the replication node.
A usage can be found here:
https://github.com/sabledb-io/sabledb/blob/e0d2fefe5b3210ea6dc25cd15c4e1493f6435aec/libsabledb/src/replication/replication_server.rs#L95
To create a snapshot, use this method and to load it, use this method
As opposed to the initial issue statement (backup every N minutes), I would rather have this as an extended commands. This will basically separates the control path form the data path.
As a suggestion we could use these commands (these commands do not exist in the REDIS command set):
checkpoint create <file:///path/to/checkpoint>
checkpoint restore <file:///path/to/checkpoint> [delete-all-before-restore]

we could later support different URI formats, for example:
checkpoint create s3://aws-account-id/mybucket/backup.tar
checkpoint restore s3://aws-account-id/mybucket/backup.tar

WDYT?

@sabledb-io Agree with an external command and the URL design, but maybe we can call the command as backup rather than checkpoint ? And Rocksdb also provides the ability of backup.
So in my opinion, it may look like this:
# For backup
backup s3://$BUCKET/$BACKUP_FOLDER

# For restore
restore s3://$BUCKET/$BACKUP_FOLDER

But I don't know how to implement increment backup in this case. A backup operation may take sometime.
I think we can refer to this repo https://github.com/facebookarchive/rocks-strata

I am ok with changing the command to backup
There is no need for incremental backup as it is already supported by SableDb (in the form of replication) - you can start a secondary instance (or more replicas) of SableDb which will be receiving incremental updates from the primary node
The whole purpose of this was the ability to backup the data in case of disaster recovery and for faster startup time.

You can read more about how SableDb replicates its data to another instance here:
https://sabledb-io.github.io/sabledb/design/replication/


Uncaught TypeError: scope.$applyAsync is not a function

Hi,
on the latest version (0.9.0) I got following error:
Uncaught TypeError: scope.$applyAsync is not a function
   (anonymous function)	@	angular-stomp.js:401
   (anonymous function)	@	stomp.js:309

in function $stompSubscribe:
scope.$applyAsync(function () {
   return callback(message);
});

Problem occurs, because empty object for scope is created in function SubscribeBuilder.subscribeTo and because of that this condition if (scope === undefined) in $stompSubscribe is insufficient.

I haven't test this way... sorry 😞

Thanks for quick response :)


Make the documentation build reproducibly

Whilst working on the Reproducible Builds effort [0], I noticed that
mpl-sphinx-theme could not be built reproducibly.

This is because the documentation embedded the current build year. This PR
changes the behaviour of the Sphinx documentation so that it can that
optionally use SOURCE_DATE_EPOCH [1] as the source of this value instead.

I originally filed this in Debian as bug #1005826 [2].

 [0] https://reproducible-builds.org/
 [1] https://reproducible-builds.org/specs/source-date-epoch/
 [2] https://bugs.debian.org/1005826

Please add a comment, as in Matplotlib: https://github.com/matplotlib/matplotlib/blob/main/doc/conf.py#L33

No problem. Force-pushed an update. :+1:


Sw 6168 fix workflow display

Codecov Report
Base: 47.52% // Head: 47.52% // No change to project coverage :thumbsup:

Coverage data is based on head (1291f9c) compared to base (c9b63a8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   47.52%   47.52%
=======================================
  Files          13       13
  Lines         505      505
=======================================
  Hits          240      240
  Misses        240      240
  Partials       25       25

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[ISSUE #7590] computeIfAbsent unit test modified

Which Issue(s) This PR Fixes

Fixes #7590
Brief Description
Comented    " ConcurrentHashMapUtils.computeIfAbsent(map, "AaAa", key -> map.computeIfAbsent("BBBB", key2 -> "42"));" line because it is causing infinite loop situation and it is of new use.

How Did You Test This Change?
using mvn test

The error is showing recursive update at this line


When using snakemake >=8 with Python 3.11 (but not Python 3.12) certain rules erroneously don't run in hard to reproduce circumstances

Snakemake version
Important: the bug only manifests with Python 3.11 (3.11.9 at time of testing). It does not manifest with Python 3.12
Confirmed issue is reproducible with:

snakemake 8.18
snakemake 8.16
snakemake 8.13
snakemake 8.10
snakemake 8.1

Confirmed issue is not present in:

snakemake 7.32.4

Describe the bug
When snakemake >=8 is run with Python 3.11, rules to run are incorrectly inferred. Some rules that are run when just the Python version is changed to 3.12 or snakemake downgraded to <8 do not run only on Python 3.11.
I'm really struggling to find a reproducible example. I cloned the workflow I encountered this in fresh but then the problem doesn't manifest.
So it seems a hard to catch bug - even though it can have big consequences (I ran a workflow and was confused why I wasn't getting any new results - the reason is that parts were not rerunning when they should have).

Is the problem in a checkpoint rule? I've been getting similar issues on 8.x.


Search results: back to top

Type
:sparkles: Feature
UI Requirements
See #1002
Acceptance criteria
Jump to Top: Display the icon on the right bottom corner after user scrolls down 1 or more screen lengths.

I've added tracking onto this in #1124.
Could we have the user need for this?
I wonder if we had that, we could probably come up with something betters we would know what we are trying to solve. It would also allow us to add tracking to know if we're solving it.
Understandably we are doing more face to face user testing, but when we're releasing to more people, it would be good to validate those findings.
The use cases I can think of, but are not based on any user feedback are:

They haven't found anything useful, and pagination is not available or they don't care to move onto the next page.
They need to get back to the search bar (there are better ways of signposting this - e.g. back to search bar, which could not lose your position, but rather just bring the search bar into view).

Using this seems almost like an indicator of us failing to provide something better, perhaps a contextual side bar that changes dependant on your filters or ordering? Similar to Google Photos.
(There is also a small concern here of perpetually adding components without ever thinking of deprecating any that aren't working)


Add Optimum submodule support + add working Dockerfiles

The model scripts which were previously modified and live in this repository now live in the Optimum GitHub repo. This repo will instead hold the script and run configurations for running and comparing various models.
Summary of changes:

removed submodule pointing Ravi's custom branch
added submodules for Optimum and Transformers
changed hf-ort.py script to copy scripts from either Optimum or Transformers depending on the run configuration
removed mentions / previous option to use CUDA 10.2 since CUDA 10.2 has been deprecated
lowered the T5 batch size because the old batch size caused out of memory errors even on the recommended VM size
removed scripts and requirements files that were migrated in from the last PR (now that work lives in either the Optimum or the Transformers repos respectively)
added new Dockerfiles

based on PTCA image with dependencies installed on top of it
Dockerfile_clm is specifically for running the run_clm.py script for GPT2 because GPT2 requires a specific version of transformers

Summary of the commits after PR approvals:

edited Dockerfile_clm dependencies (for the GPT2 Dockerfile) according to feedback... Dockerfile_clm should be retired after the fix for GPT2 version happens


Accumulation of MapCacheEvictionTask in Memory

Expected behavior
When the RMapCache entries expire, the MapCacheEvictionTask should be cleaned up.
Actual behavior
MapCacheEvictionTask is leaking memory as more and more RMapCache gets created.
Steps to reproduce or test case
We create millions of RMapCache a day. Over the course of a few days, the MapCachEvictionTask object stays in memory and is never cleaned up.
Redis version
4.0.11
Redisson version
3.5.3
Redisson configuration
  redisson:
    singleServerConfig:
      connectTimeout: 500
      address: "redis://<IP_ADDRESS>:13788"
      connectionPoolSize: 128
      timeout: 900
      retryInterval: 500
      reconnectionTimeout: 10

RMapCache and RSetCache objects now implement RDestroyable interface.
destroy method should be called to free RMapCache or RSetCache object.

Thanks for the fix 👍


Support @@ operator for json like search

Hey, guys.
I use postgres driver for build query and got unexpected error:
ERROR: operator does not exists: tsvector @@ text
sqlQuery.where(
                sql`to_tsvector('simple', ep.value ->> 'value')`,
                "@@",
                `plainto_tsquery(${query})`,
            );

I also create custom index earlier like:
create index idx_value_text_gin on schema1.table1 using gin (to_tsvector('simple', value ->> 'value'));

What i expected?
Query should be executed.

Needs more info.


Test2

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Disregard, test meant for forked repo.


question: child tables don't have indexes from the parent table

Hi Max,
This is a pretty cool app. I have been playing with it. I am using postgres. I noticed that child tables don't have indexes set up like the parent table. We probably want them by default, right?  I see in the postgres manual that you use the "like" clause when creating a child table.
ex.
CREATE TABLE foo_1 (LIKE foo including indexes ) inherits (foo);
What are your thoughts on this?

你好
感谢您的反馈。是的，目前索引和约束没有被继承，这非常糟糕。我完全同意你的看法，子表应该继承master表中的索引和约束。
不过，我不会发布任何新版本的django-db-parti这个功能因为我正在研究这个软件包的更高级版本，它不仅支持django orm，还支持sqlalchemy，pony，peewee等。它还将包括一个适当的表继承索引，约束等。
我已经有一个工作原型，第一个公开发布计划在6月底 - 7月初，它将向后兼容django-db-parti。

wow!!!That makes me really look forward to it.


How one can cache Dataset

Hello, team,
I have a slippy server that serves Slippy Tiles implemented as HTTP server using gdal-rs. Actual rasters are partitioned in many Cloud Optimized GeoTIFF (COG) files with overviews. On high level, I extract tile information from the request that looks like /:prefix/:layer/:z/:x/:y and map it to overview and offset to read from COG. My COG files are stored in S3 and I use vsis3. In the beginning of request I open Dataset, in the end it is implicitly closed because of drop. Interestingly, if I query the same slippy tile twice, the only first request has high latency, the second one is much faster (is it because of VSI cache?):
2023-07-21T02:13:12.185123Z  INFO tokio-runtime-worker ThreadId(03) qartez_slippy_server::routes: src/routes.rs:169: Read and prepared a tile for .../20/179207/418903.png from /vsis3/.../color/geotiff/5600_13090.tif in 475 ms
2023-07-21T02:13:42.265197Z  INFO tokio-runtime-worker ThreadId(02) qartez_slippy_server::routes: src/routes.rs:169: Read and prepared a tile for .../20/179207/418903.png from /vsis3/.../color/geotiff/5600_13090.tif in 3 ms

Does it make sense in such scenario to cache the C descriptor of Dataset and reuse it? Or VSI_CACHE_SIZE together with GDAL_CACHEMAX should be enough?
Thank you.

Yeah, it's a bit unfortunate. GDAL doesn't allow you to read from a Dataset from multiple threads at once, even though cURL could probably support it just fine.
So I think your options are to either:

open and close the dataset on each read, which will incur a good bit of overhead (the TLS handshake and and reading the IFDs, I guess)
have a thread or pool of threads where each opens the file, gets a read request from a channel, does the actual read, sends the results back, then loops; this should work pretty well, but you'll be storing duplicate data in the GDAL cache

I should probably ask on the mailing list for clarification, though.

Starting with GDAL 3.6.0, if the GDAL_NUM_THREADS config option is set, reading in a TIFF/COG file a window of interest that intersects multiple tiles at one will use multithreaded decompression (cf https://github.com/OSGeo/gdal/blob/v3.6.0/NEWS.md), and in GDAL 3.7.0 this was further improved to trigger parallel network requests

I don't think multi-threaded decoding helps in this case (a tile server), since each request will read a single block if everything is set up properly. But we can't have everything just yet :-).

Isn't the problem that Datasets are not Send? You can add Mutexes around it, so that it is Sync , but you cannot enforce the Send.
There are shared datasets in GDAL, but we haven't implemented them since they cannot simply be used with all the stuff currently implemented for a dataset.
We have done the thread + channel thing that @lnicola mentioned :laughing: .

Yeah, IIRC shared datasets are actually the opposite of the "open the file multiple times" trick. Instead, you (probably) get a mutex around each access, but end up with better cache utilization.

Yeah, IIRC shared datasets are actually the opposite of the "open the file multiple times" trick. Instead, you (probably) get a mutex around each access, but end up with better cache utilization.

no, you don't. You just get the same dataset (if calling GDALOpenShared() from the same thread from which the initial one was opened. Otherwise you'll get a different instance)

Oh, right. Well that's an argument for Dataset not being Send, because otherwise you can open a shared one twice and pass it to a different thread, which is bad.

You can't call open GDALOpenShared with this library at the moment. This is why we can say that Dataset: Send.
There would need to be a second type of Dataset , e.g., SharedDataset, which would call GDALOpenShared under the hood but then not being Send.

You're right, there's even a note in the docs:

Note that the GDAL_OF_SHARED option is removed from the set of allowed option because it subverts the Send implementation that allow passing the dataset the another thread. See https://github.com/georust/gdal/issues/154.

GDAL isn't thread-safe, but it is re-entrant. So, the following code should be allowed with ranyon:
  let test: Vec<Geometry> = (0..10).into_par_iter().map(|_| {
        let point =  Geometry::from_wkt("POINT (10, 10)").unwrap();
        point.buffer(3., 1).unwrap()
    }).collect();

right?


Added docstrings to the python code.

Hi @amyschoen , I was talking to @AARonSTeneo about how I might be able to help out and I noticed that the python modules could use a little sprucing up, docstrings-wise.
If you decide at some later point to use autodoc, these will come in handy and they will also make the code more familiar to Python folks who may contribute later.

Awesome.  Definitely a much-needed addition to the project.  This was my first time coding in Python and much of the team was also new to the language.  I'm all for anything that would make this better.
Have you signed and sent in the Contributor License Agreement yet?  It's mentioned in our contributor guide.  This will need to be done before I can approve and merge in a request from someone outside Optum, and I'm not seeing it in our<EMAIL_ADDRESS>inbox.  Once we have the formal paperwork settled, I'll approve and merge in this PR.

Hi Amy,
Thanks for your quick and candid reply. I had the sense that the authors
were new to Python.
The Python community is kind of obsessive about making their code easy to
read and to document.
The Django crowd is phenomenal at making good documentation:
https://docs.djangoproject.com/en/2.0/internals/contributing/writing-documentation/
And then, if you find yourself having to write REST apis, I think you'll
find swagger really helpful.
https://editor.swagger.io/
-Blaise
On Thu, Apr 26, 2018 at 6:16 PM, Amy Schoen<EMAIL_ADDRESS>wrote:

Awesome. Definitely a much-needed addition to the project. This was my
first time coding in Python and much of the team was also new to the
language. I'm all for anything that would make this better.
Have you signed and sent in the Contributor License Agreement yet? It's
mentioned in our contributor guide
https://github.com/Optum/ChaoSlingr/blob/master/CONTRIBUTING.md. This
will need to be done before I can approve and merge in a request from
someone outside Optum, and I'm not seeing it in our<EMAIL_ADDRESS>inbox. Once we have the formal paperwork settled, I'll approve and merge in
this PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Optum/ChaoSlingr/pull/45#issuecomment-384834558, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPh-CaJHAfWxlTGewco2UltnRdlzCLjks5tsnF8gaJpZM4TlXqE
.

--
LinkedIn https://www.linkedin.com/in/blaisepabon/  |  Quora
https://www.quora.com/profile/Blaise-Pabon  |  Github
https://github.com/blaisep
“If you want to go fast, go alone. If you want to go far, go
together.” --African
proverb


Update Gemfile

Summary

Context

Hello, I sincerely apologize for creating this Pull Request by mistake. It was an error on my part, and I will close this PR and make sure it doesn't cause any issues. Sorry for the inconvenience caused, and thank you for your understanding!


refactor(ci): Add PR title validation

Description
This ensures that all PRs must follow convention commit titles
Checklist:

[ ] I have reviewed my diff in github, line by line.
[ ] Every change is related to the PR description.
[ ] I have linked this pull request to the issue(s) that it resolves.
[ ] There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
[ ] There are no circuit changes, OR specifications in /markdown/specs have been updated.
[ ] There are no circuit changes, OR a cryptographer has been assigned for review.
[ ] I've updated any terraform that needs updating (e.g. environment variables) for deployment.
[ ] The branch has been rebased against the head of its merge target.
[ ] I'm happy for the PR to be merged at the reviewer's next convenience.
[ ] New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
[ ] If existing code has been modified, such documentation has been added or updated.

Taken from the Noir repository: https://github.com/noir-lang/noir/blob/master/.github/workflows/pull-request.yml

Yeah true -- we can git clone the repo into this organization too


Need redirects from old http to new https pages

Hello,
@sjm41 from Flybase reported that their links to AmiGO are now broken; ie the go to the old http site.
Can we add a redirect to the https pages?

I think we may need a bit more detail for what the reported issue is here. I believe that automatic upgrading should already be in place. At least it has worked for me for my tests.

Hi @kltm
Sorry, might have been as false alarm.
I just did a simple test of clicking on an Amigo link on a FlyBase page (http://flybase.org/cgi-bin/cvreport.pl?id=GO%3A0003682) and I was initially directed here:
http://amigo.geneontology.org/amigo/term/GO:0003682
But I just retested and got directed to the https page!  So maybe just some kind of caching issue after all.

That's ironic....
I'll pass this on to our web developers. Thanks!

While we're still tweaking our HTTPS settings here, I believe this is closed at our end?


catkin build error: redefinition of 'struct i2c_msg'

When I run the "catkin build" command, the following error occurs, what is the cause? How to solve? Any help from you will be appreciated!
Errors     << ubiquity_motor:make /home/ubuntu/catkin_ws/logs/ubiquity_motor/build.make.002.log
In file included from /home/ubuntu/catkin_ws/src/ubiquity_motor/src/motor_hardware.cc:38:0:
/usr/include/linux/i2c.h:68:8: error: redefinition of 'struct i2c_msg'
struct i2c_msg {
^
In file included from /home/ubuntu/catkin_ws/src/ubiquity_motor/src/motor_hardware.cc:37:0:
/usr/include/linux/i2c-dev.h:37:8: error: previous definition of 'struct i2c_msg'
struct i2c_msg {
^
In file included from /home/ubuntu/catkin_ws/src/ubiquity_motor/src/motor_hardware.cc:38:0:
/usr/include/linux/i2c.h:129:7: error: redefinition of 'union i2c_smbus_data'
union i2c_smbus_data {
^
In file included from /home/ubuntu/catkin_ws/src/ubiquity_motor/src/motor_hardware.cc:37:0:
/usr/include/linux/i2c-dev.h:89:7: error: previous definition of 'union i2c_smbus_data'
union i2c_smbus_data {
^
make[2]: *** [CMakeFiles/ubiquity_motor.dir/src/motor_hardware.cc.o] Error 1
make[1]: *** [CMakeFiles/ubiquity_motor.dir/all] Error 2
make: *** [all] Error 2
cd /home/ubuntu/catkin_ws/build/ubiquity_motor; catkin build --get-env ubiquity_motor | catkin env -si  /usr/bin/make --jobserver-fds=6,7 -j; cd -
......................................................................................................................................
Failed     << ubiquity_motor:make                        [ Exited with code 2 ]
Failed    <<< ubiquity_motor                             [ 19.7 seconds ]
Abandoned <<< magni_bringup                              [ Unrelated job failed ]
Abandoned <<< magni_demos                                [ Unrelated job failed ]
Finished  <<< spot_micro_motion_cmd                      [ 1 minute and 21.9 seconds ]
[build] Summary: 20 of 23 packages succeeded.
[build]   Ignored:   2 packages were skipped or are blacklisted.
[build]   Warnings:  None.
[build]   Abandoned: 2 packages were abandoned.
[build]   Failed:    1 packages failed.
[build] Runtime: 1 minute and 29.3 seconds total.

I found that removing the ubiquity_motor directory under the src directory can compile and pass. But I don't know if this will have any side effects.


[BUG] Dropdown Excel js there is limitation of accepting 255 characters and beyond that throws error

🐛 Bug Report

Lib version: 4.4.2
Related Questions:  #https://github.com/exceljs/exceljs/issues/2256 #https://github.com/exceljs/exceljs/issues/1736
Steps To Reproduce

The expected behaviour:

Possible solution (optional, but very helpful):

Fix the problem that the exported excel dataValidation drop-down list cannot be displayed normally when the content of formulae exceeds 255 characters when dataValidation type=list
When dataValidation formulae exceed 255 characters，
throw new Error('The input cannot be larger than 255 characters. Please check the value of dataValidation.formulae');


Get token from user secret in google colab

Did not see any changes in this PR except merged from main. Am I missing something?

@vlad-nn sorry, this was my mistake. I was merging main to my branch before merging my branch to main. No review needed for this.


Form Keyboard Event Handlers

Would be helpful to add these key actions to the Form component as default behaviors, as opposed to having to add them everytime a Form component is used.

[ ] [CMD] + [Enter] submits form

The Form was just overhauled.  Closing as this issue is now stale.


feat: add data model validation

closes #17

@xseman - can you please give feedback?

There are 3 direct questions on task definition marked with todo in the code, please take a look at them.

Thanks for your contribution @LukasBicus!
Great implementation and tests, I've left a few comments.


feat: Add a node liveness TTL that terminates NotReady nodes if optional field is set on provisioner

Fixes #2021
Description
A new optional field TTLSecondsAfterNotReady is added to the provisioner spec to provide an option to terminate nodes that never become ready after starting up within the TTL.
How was this change tested?

Unit tests

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

Release Note

NONE

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Excited to see this feature. I spent a couple minutes with @bwagner5 trying to decipher the difference between
https://github.com/kubernetes/api/blob/master/core/v1/well_known_taints.go#L27 and https://github.com/kubernetes/api/blob/master/core/v1/well_known_taints.go#L22, and which one we should be using for this feature.
I think it's correct behavior for Karpenter to not touch nodes experiencing CPU/Memory/PID pressure.

Additional request from a customer this feature to also handle the situation where nodes go not ready after initialization. This would be a ttlSecondsAfterNotReady which worked for both initialization and post-initialization if the node goes NotReady for some reason.

Discussed with other Karpenter folks and the general consensus is exposing ttlSecondsAfterNotReady through the API is an appropriate path.  The initial implementation could remain focused on terminating new nodes that never enter "Ready" state (after the Karpenter initialization process).  This could be extended later to include recovery of "Ready" nodes which then enter a "Not Ready" state.

Hello @htoo97 ,
We are working on a design doc to help guide our direction on this feature.  I should hopefully have a draft available sometime early next week.  Until then, we should probably hold off on merging this code.  Just so we're sure it aligns with the intended design.
Let me know if you have any questions/concerns.  Thanks!

Sounds perfect, thanks!

Quite keen on this feature - is there any movement with the design doc or merging this?

@omgapuppy, we're currently working on a design for this. It has pretty broad implications, so we're taking care to get it right.

Thanks for the quick update!

Quite interested in this feature - is there any movement with the design doc or merging this PR?

Closing in favor of https://github.com/aws/karpenter-core/pull/191. Once this feature is released along with the work associated with Node Ownership, we expect that a large number of user issues around this should go away.


IsoBuffer.from(): better type checking, Typed arrays (0.33)

Note: I missed that UT is missing here - it was added later (see "bufferToString working with IsoBuffer" case in 0.35+).
I've validated that tests are passing with these changes


Method with ResourceBundleKey, Component and IModel

Created new method with ResourceBundleKey, Component and IModel.

Thanks for your contribution.


Code breaks on latest release

Actual Behavior

from wtforms.widgets import HTMLString
ImportError: cannot import name 'HTMLString'

Environment

Python version: 3.6.8
wtforms version: 2.3.0

I had the same issue when updating.
HTMLString was replaced with Markup. So use from markupsafe import Markup instead.
Also from wtforms.widgets.core import escape_html was replaced by from markupsafe import escape

I had the same issue when running airflow

Also got this issue

Is it possible to restore HTMLString and cut 2.3.1 since it specifically said it was a backwards incompatible change in the #400?

Fixed in #583.


Blazor support for date-text column

Pull Request
🤨 Rationale
Part of #1014
👩💻 Implementation
Added Blazor integration for the nimble-table-column-date-text element. Included tests and added date-text column to example app.
🧪 Testing
Tests pass and column works in example app.
✅ Checklist

[x] I have updated the project documentation to reflect my changes or determined no changes are needed.

Requesting buddy review from @mollykreis

Should we go ahead and write another acceptance test for this column? I'm somewhat on the fence about this, in that I'm not quite convinced that we get a lot of value from acceptance tests for checking that a component does, in fact, handle its RenderContent correctly (despite my request for the acceptance test for the enum text column). The obvious value we get from acceptance tests is when we need to test our custom JS logic, but that doesn't apply here.
Thoughts @rajsite, @msmithNI, @m-akinc, @mollykreis?

@atmgrifter00 I'm going to assume from the lack of responses to the question about acceptance tests and the approvals that there's not a need to create an acceptance test in this case.


LESQ-715: Fix specialist heading icon sizes

Description
Music year: 2014

Amends heading Icon sizes on SpecialistProgrammeHeadingListing and HeaderListing components

Issue(s)
Fixes #LESQ-715
How to test

Go to https://deploy-preview-2328--oak-web-application.netlify.thenational.academy
Click on ______
You should see ______

Screenshots
How it used to look (delete if n/a):
{screenshots}
How it should now look:
{screenshots}
Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner
[ ] Does this PR update a package with a breaking change

can we add some screenshots as we can't see in preview?

:tada: This PR is included in version 1.388.7 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: