flutter build tests

Issue description
We should add tests to the flutter derivation that run flutter build for every supported platform (currently Android, Web, and Linux).
This will avoid issues like #260278 - such an obvious and disruptive regression should never have made it past review.
@NixOS/flutter

I agree, there is a great need for tests.
How should the tests work?
We correctly have a builder for Linux, but I don't think this is enough testing for the Linux platform. I wonder if we could make some of the test derivations have internet access and be impure. This way we'd be able to mimic how the user will run and use flutter the best, and be able to test platforms we don't correctly have builders for.


wip rafthttp: make TestPipelineKeepSendingWhenPostError reliable

maybe this should use the testutil RecorderStream stuff?

@heyitsanthony Yea. I am trying to figure out if this is the real issue on CI. My laptop has 3% battery... So do not want it to run this --race test.

@heyitsanthony Fixed. PTAL.

lgtm aside from the goroutine stuff


[NetAppFiles]Net app files api version 2022 07 01 preview redo 3

ARM API Information (Control Plane)
This PR is to address a s360 Completeness issue where the public specs whare missing the preview api-verison 2022-07-01-preview.
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

@zedy-wj   Can you explain what is the CI-MissingBaseCommit  actually checking we do a base commit and it still applies this tag ?

@audunn I suspect it may be checking that you created the PRwith openAPIHub more than anything else. The warning doesn't matter as long as I can see a base commit.

      "x-nullable": true,

From what I recall, this gets flagged as a breaking change, do you really need to change it?

Refers to: specification/netapp/resource-manager/Microsoft.NetApp/preview/2022-07-01-preview/netapp.json:5703 in 40ddab9. [](commit_id = 40ddab932d7d0d64261cc70529860c04c3c1339e, deletion_comment = False)

@zedy-wj Can you explain what is the CI-MissingBaseCommit actually checking we do a base commit and it still applies this tag ?

@audunn - Seems to have been added by mistake and is a known issue, please ignore it.

      "x-nullable": true,

From what I recall, this gets flagged as a breaking change, do you really need to change it?
Refers to: specification/netapp/resource-manager/Microsoft.NetApp/preview/2022-07-01-preview/netapp.json:5703 in 40ddab9. [](commit_id = 40ddab9, deletion_comment = False)

@TimLovellSmith  updated

Signing off for ARM. BreakingChangeReviewRequired still seems accurate for the properties being removed 'oldVolumeId' vs private preview etc.

That breaking change was approved in 2022-09-01 perhaps that cover this as well.

@audunn - Please let Breaking change review board sign off or provide approved PR link first.


GBA1 gene validates positiv in gene allowlist but negative during query

Describe the bug
The gene name GBA1 validates positive in the filter frontend when submitted to the gene allowlist but negative when the query starts (the serializer is responsible for this).  Apparently the mechanism for validation differs for frontend and for the serializer. This should be fixed that both are consistent in their validation.
https://github.com/varfish-org/varfish-server/blob/main/variants/serializers/__init__.py#L72
To Reproduce
Steps to reproduce the behavior:

Go to Genes & Region on filter page
Enter GBA1
Submit query
See error

@stolpeo Unfortunately the ticket was not the project. I have given it P0, please give a size estimate and try to include in next iteration if possible.

Sorry I missed that. I'll try to configure the repos in such a way that tickets are automatically added to the project.


fix IAP modify

this PR trys to fix the issues that happen on modification of iap's.
since this commit: https://github.com/fastlane/fastlane/pull/7834/commits/1c1900a8c8d06ca101325c2a148ea0af1273d705 (i was moving code from setup to factory) - it seems that few parts of modify are broken.
users where unable to set versions/pricing_intervals
this PR trys to address this (and ads regression tests for it):

[x] IAP-Detail
[x] IAP-Family

following snippet fails on master  and works with this PR:
require "spaceship"

<EMAIL_ADDRESS>app = Spaceship::Application.find("hjanuschka.sticker-test")
purchase = app.in_app_purchases.find("x.a.s.b.b.c.d.x.y.f").edit

purchase.pricing_intervals = [
  {
    country: "WW",
    begin_date: nil,
    end_date: nil,
    tier: 3
  }
]

purchase.versions = {
      'en-US': {
        name: "Edit It",
        description: "Description has at least 10 characters"
      },
      'de-DE': {
        name: "test name german1",
        description: "German has at least 10 characters"
      },
      'da': {
        name: "test name danish",
        description: "German has at least 10 characters"
      }
    }

purchase.review_notes = "new nots 10 characters"
purchase.review_screenshot = "/Users/hja/Desktop/review.jpg"
purchase.save!

Hi @hjanuschka
I've been playing a bit with the new IAP feature (great work btw 👏).
I faced some issues, maybe they can be helpful in this context, so I'm describing them here. Let me know if you prefer me to open specific issues for any one of them.
I've been using the version available as of today in your repo https://github.com/hjanuschka/fastlane.git, branch fix_iap_modify, which you're merging here.
I'm using this invocation, which raises no error:
@app.in_app_purchases.create!(
          type: Spaceship::Tunes::IAPType::RECURRING,
          versions: {
              'en-US' => {
                  name: title,
                  description: description
              },
          },
          reference_name: reference_name,
          product_id: identifier,
          cleared_for_sale: true,
          # review_notes: "Some Review Notes here bla bla bla",
          review_screenshot: screenshot,
          pricing_intervals: [
              {
                  country: 'WW',
                  begin_date: nil,
                  end_date: nil,
                  tier: price_tier
              }
          ],
          subscription_free_trial: free_period,
          subscription_duration: duration,

          family_id: family.family_id
      )

Still, the results on iTunes connect are not exactly the ones I expected:

Cleared for Sale in Subscriptions is always false, regardless of what I set it to
There's no set price in the IAP I obtain with the call above. Also, trying with this

@app.in_app_purchases.all.each {| p |
        if p.product_id == identifier
          ed = p.edit
          ed.subscription_price_target = {currency: 'USD', tier: price_tier}
          ed.save!
        end
      }

Makes the library crash on
/Users/alaincaltieri/.rvm/gems/ruby-2.1.1/bundler/gems/fastlane-cf655c30431f/spaceship/lib/spaceship/tunes/tunes_client.rb:222:in `handle_itc_response': ITC.response.error.OPERATION_FAILED (Spaceship::TunesClient::ITunesConnectError)
	from /Users/alaincaltieri/.rvm/gems/ruby-2.1.1/bundler/gems/fastlane-cf655c30431f/spaceship/lib/spaceship/tunes/tunes_client.rb:1034:in `block in update_iap!'
	from /Users/alaincaltieri/.rvm/gems/ruby-2.1.1/bundler/gems/fastlane-cf655c30431f/spaceship/lib/spaceship/tunes/tunes_client.rb:1366:in `with_tunes_retry'
	from /Users/alaincaltieri/.rvm/gems/ruby-2.1.1/bundler/gems/fastlane-cf655c30431f/spaceship/lib/spaceship/tunes/tunes_client.rb:1028:in `update_iap!'
	from /Users/alaincaltieri/.rvm/gems/ruby-2.1.1/bundler/gems/fastlane-cf655c30431f/spaceship/lib/spaceship/tunes/iap_detail.rb:213:in `save!'

Same OPERATION_FAILED error occurs also when modifying non-renewable iaps (like a consumable one).
Let me know if you need any further detail and thank you a lot! 🙂

@alaincaltieri many thx for the feedback i ll have a look at it, and push directly to this branch if i find fixes.

@alaincaltieri i looked at it and the "subscriptions" are beasts!
you have to set the pricing interval in a differen format.
e.g:
app.in_app_purchases.create!(
          type: Spaceship::Tunes::IAPType::RECURRING,
          versions: {
              'en-US' => {
                  name: "title1",
                  description: "descr at least 10 characters"
              },
          },
          reference_name: "new REF name1",
          product_id: "some.recurring1",
          cleared_for_sale: true,
          # review_notes: "Some Review Notes here bla bla bla",
          review_screenshot: "/Users/hja/Desktop/review.jpg",
          pricing_intervals: [
            {
                  country: "AO",
                  begin_date: nil,
                  end_date: nil,
                  tier: 1,
                  grandfathered: { value: "FUTURE_NONE" }
                }
          ],
          subscription_free_trial: '1w',
          subscription_duration: '1m',
          family_id: "20373395"
)

once the pricing interval is correct - the clear for sale also works :)
the second problem with editing.
this works:

hint: you can use find  instead of looping through all 👍

purch = app.in_app_purchases.find("some.recurring1")
ed = purch.edit
ed.subscription_price_target = {currency: 'USD', tier: 3}
ed.review_screenshot = "/Users/hja/Desktop/review.jpg"
ed.review_notes = "asdas das dasdas "
ed.save!

it seems to fail if there is no review_screenshot and no review_note.

@hjanuschka Who do you think is the right person to review and get this in? @KrauseFx? @snatchev ?

@mfurtak i think the best bet is on @snatchev - i don't think this brings in some troubles (only touches iap related files), as the current in-production code is defacto broken, this PR (confirmed  working by @alaincaltieri ) fixes it.
so i hope this is getting merged soon.

Hi @hjanuschka,
I tried this code for subscriptions product:
purch = app.in_app_purchases.find("some.recurring1") ed = purch.edit ed.subscription_price_target = {currency: 'USD', tier: 3} ed.review_screenshot = "/Users/hja/Desktop/review.jpg" ed.review_notes = "asdas das dasdas " ed.save!
It works fine!
But when I try code below (with the localization changes), there is no localization changes on the product.
purch = app.in_app_purchases.find("some.recurring1") ed = purch.edit ed.versions =        [{         'en-US' => {             name: "Test test",             description: "Test test test"          }       }] ed.subscription_price_target = {currency: 'USD', tier: 3} ed.review_screenshot = "/Users/hja/Desktop/review.jpg" ed.review_notes = "asdas das dasdas " ed.save!
What is wrong and how can I fix it?

@Prussich versions should be a hash, not a array so this should work:
purch = app.in_app_purchases.find("some.recurring1")
ed = purch.edit
ed.versions =
      {
        'en-US' => {
            name: "Test test",
            description: "Test test test"
         }
     }
ed.subscription_price_target = {currency: 'USD', tier: 3}
ed.review_screenshot = "/Users/hja/Desktop/review.jpg"
ed.review_notes = "asdas das dasdas "
ed.save!

I changed the code as you recommended. But it's not working again :( Everything is changing, except for localizations.
My script:
#!/usr/bin/env ruby
#$verbose=true

require "spaceship"

Spaceship::Tunes.login('xxx', 'xxx')

app = Spaceship::Application.find("com.xxx")

purch = app.in_app_purchases.find("com.xxx.xxx")
ed = purch.edit
ed.subscription_price_target = {currency: 'USD', tier: 9}
ed.versions =
      {
        'en-AU' => {
            name: "Test test",
            description: "Test test test"
         },
         'en-US' => {
            name: "Test test",
            description: "Test test test"
         }
     }
ed.review_screenshot = "/Users/xxx/xxx.png"
ed.review_notes = "asdas das dasdas "
ed.subscription_duration =  '1m'
ed.save!

bash-3.2$ fastlane --version
fastlane installation at path:
/Library/Ruby/Gems/2.0.0/gems/fastlane-2.18.3/bin/fastlane
fastlane 2.18.3
from git clone -b fix_iap_modify --single-branch<EMAIL_ADDRESS>

@Prussich in fact it looks like the apple-api got a bit stricter on iap modify - since the last commit in this PR.
can you pull it again https://github.com/fastlane/fastlane/pull/8367/commits/f5dac9e5091b154a1a1f727d4538a7159ef68dbb should adress it.
i ran the above code sample and it worked after the recent commit.

@hjanuschka,  thank you very much, it's works now!

Hi, @hjanuschka I met a problem. I don't find the answer of the problem. Here is my script.
Spaceship::Tunes.login(apple_id, password)
app = Spaceship::Tunes::Application.find(bundle_id)
purchase = app.in_app_purchases.find(product_id)
detailed = purchase.edit
detailed.review_screenshot = "/Users/Haoyuan/Desktop/review_screenshot.PNG"
detailed.review_notes = "new nots 10 characters",
detailed.save!

@jianghaoyuan2007 are you using this PR as a code base - or are on a master?

@hjanuschka I am using fastlane 2.24.0 as code base. fastlane 2.24.0 is installed and updated using sudo gem update fastlane. And could you tell what PR is?

these PR here - solves a whole bunch of problems with iap's.
so to get it working you'd need to use the PR branch -> inside my fork: https://github.com/hjanuschka/fastlane/tree/fix_iap_modify
or you'd wait until the PR is merged.

@hjanuschka I started using this branch in a script I'm working on which modifies IAPs. Couldn't get it working so I diffed the request with the same edit request in Itunes connect and worked out that the contentHosting being missing from the edit request was the cause of my issues. I've forked and fixed it for myself here
https://github.com/spazworm/fastlane/commit/81967e734a9c406374d05d06dfbb0a3b007d901a
but I'm sure there must be a better way to get it done. Thanks for all your hard work.

@spazworm many thx, commit looks good, i added it to this branch, could you please:

sign the CLA stuff the bot is mentioning.
give this PR a another testing round?

@hjanuschka submitted the CLA, I'll be working with IAP creation and modification over the next few days so that should give it a decent run through.

@spazworm sorry to bother you again, can you reply something to this PR - this should make the @googlebot  happy (i hope)

lol no worries @hjanuschka. I am okay with commits being contributed @googlebot.

Hey @hjanuschka I wanted to modify some IAPs and quickly realized that I needed to be on your branch to get it working. But with the following code:
      iap_edit = iap.edit
      iap_edit.versions = {
          'en-US': {
              name: "Whatever",
              description: "A description"
          }
      }

I get:
undefined method `versions=' for #<Spaceship::Tunes::IAPDetail:0x007fa686a797f0> (NoMethodError)

Which I also get with fastlane 2.25.0

@azgul can you share a couple of more lines, and also are you sure you are on the branch of this PR (because i am quiet confident that the branch here has the version=  on IAPDetail - and it was missing before the PR see here: https://github.com/fastlane/fastlane/pull/8367/files#diff-0ad09501b52f13ed83e0709d8a5b1df3R74)?

@hjanuschka Here is my entire script without the constants: https://gist.github.com/azgul/c73ff76798e09d49413c708fdba74d09
And my folder structure is as follows:
script.rb
fastlane/ (with your branch checked out)
am I loading the spaceship library incorrectly?

@azgul script looks
one note, i think you have to set review_notes and screenshot on every edit:
iap.review_screenshot = "/Users/xxx/xxx.png"
iap.review_notes = "asdas das dasdas "

about the usage of the fork i am unsure about require_relative.
could you use a Gemfile?
Gemfile:
source "https://rubygems.org"
gem 'fastlane', :git => 'https://github.com/hjanuschka/fastlane.git', :branch => 'fix_iap_modify'

running: bundle install and later on your script with bundle exec ruby your_script.rb -this way it should definitly use the PR's branch.

@hjanuschka I'm still having issues after trying to save: https://gist.github.com/azgul/5057e8669916b329e41e557283de5077
terminates with the following stacktrace:
/Users/martin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/fastlane-636fccaeea2b/spaceship/lib/spaceship/tunes/tunes_client.rb:222:in `handle_itc_response': ITC.response.error.OPERATION_FAILED (Spaceship::TunesClient::ITunesConnectError)
	from /Users/martin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/fastlane-636fccaeea2b/spaceship/lib/spaceship/tunes/tunes_client.rb:1035:in `block in update_iap!'
	from /Users/martin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/fastlane-636fccaeea2b/spaceship/lib/spaceship/tunes/tunes_client.rb:1367:in `with_tunes_retry'
	from /Users/martin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/fastlane-636fccaeea2b/spaceship/lib/spaceship/tunes/tunes_client.rb:1029:in `update_iap!'
	from /Users/martin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/fastlane-636fccaeea2b/spaceship/lib/spaceship/tunes/iap_detail.rb:213:in `save!'
	from iap.rb:41:in `block in <main>'
	from iap.rb:19:in `each'
	from iap.rb:19:in `<main>'

as a sidenote it seems strange that we have to use what seems to be iPhone 4 resolution because it fails with everything else that I've tried. It even fails with iPhone 7 Plus resolution (1242x2208). I downloaded the review screenshot that was already there and it refuses to upload that and fails with:
/Users/martin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/fastlane-636fccaeea2b/spaceship/lib/spaceship/du/du_client.rb:127:in `parse_upload_response': [IMG_BAD_DIMENSIONS] The image dimensions are not supported. Please adjust to acceptable dimensions and re-save it. (Spaceship::Client::UnexpectedResponse)
	from /Users/martin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/fastlane-636fccaeea2b/spaceship/lib/spaceship/du/du_client.rb:83:in `upload_file'
	from /Users/martin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/fastlane-636fccaeea2b/spaceship/lib/spaceship/du/du_client.rb:22:in `upload_purchase_review_screenshot'
	from /Users/martin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/fastlane-636fccaeea2b/spaceship/lib/spaceship/tunes/tunes_client.rb:598:in `upload_purchase_review_screenshot'
	from /Users/martin/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/bundler/gems/fastlane-636fccaeea2b/spaceship/lib/spaceship/tunes/iap_detail.rb:196:in `save!'
	from iap.rb:41:in `block in <main>'
	from iap.rb:19:in `each'
	from iap.rb:19:in `<main>'

I attempted resize to all the iPhone resolutions listed on http://iosres.com/ but it fails with the same error on all of them. Only works with 640x960 which you mentioned here: https://github.com/fastlane/fastlane/issues/8348#issuecomment-282074335

@azgul i think its because your description is below 10 characters 👍  - can you try the exakt same input on itc web interface.
about screenshots, i am going to find some time to digg into the different screenshot formats.

@hjanuschka the iap description? It is 12 characters. And it works fine on itc

@azgul sorry - i tried it now and found the issue, itc locales are a mess. 👍
following snippet works (extracted from your script)
require "spaceship"
new_iap_name = "Single Copy 01/02/19"
<EMAIL_ADDRESS>app = Spaceship::Application.find("hjanuschka.sticker-test")
iap_edit = app.in_app_purchases.find("x.a.s.b.b.c.d.x.y.f").edit

iap_edit.review_notes = "Fix locale. Previous version mistakenly only had en-US"
iap_edit.review_screenshot = "/Users/hjanuschka/Desktop/review.jpg"
iap_edit.versions = {
     'en-GB': {
         name: new_iap_name,
         description: "Single issue"
     }
}

iap_edit.save!

the issue is that itc requires to use en-GB  instead of en-UK:

@hjanuschka thank you. We came to the same conclusion. I inspected the network response from itc and found that I was using the wrong locale. Thank you again for your assistance

@azgul  you are welcome, thx for helping out by providing details - and thx for using IAP via fastlane 🍺

@azgul about the screenshots, could you share some in the various sizes? so i can dig into it.

http://i.imgur.com/2ehmjcj.jpg here is the one that was already uploaded through Application Loader (1242x2208). The other phone resolutions listed on http://iosres.com/ I scaled down from this

@hjanuschka Any news about this? It was looking promising

it is working, this PR is still mergeable - it only lacks the multiple screenshot size.
i havent got time for that, i would love to finish this PR, as it fixes current broken iap mgmt on master - and do the multiple screenshots support in a seperate PR.
for those of you using, this branch, i merged the current master
@KrauseFx  can we merge this?

many thx!

Hi, hjanuschka
I try to modify approved in-app item and I got error:
/Users/Test/.rvm/gems/ruby-2.4.0/gems/fastlane-2.37.0/spaceship/lib/spaceship/tunes/tunes_client.rb:162:inhandle_itc_response': ITC.response.error.OPERATION_FAILED (Spaceship::TunesClient::ITunesConnectError)
from /Users/Test/.rvm/gems/ruby-2.4.0/gems/fastlane-2.37.0/spaceship/lib/spaceship/tunes/tunes_client.rb:964:in block in update_iap!' 	from /Users/Test/.rvm/gems/ruby-2.4.0/gems/fastlane-2.37.0/spaceship/lib/spaceship/tunes/tunes_client.rb:1296:in with_tunes_retry'
from /Users/Test/.rvm/gems/ruby-2.4.0/gems/fastlane-2.37.0/spaceship/lib/spaceship/tunes/tunes_client.rb:958:in update_iap!' 	from /Users/Test/.rvm/gems/ruby-2.4.0/gems/fastlane-2.37.0/spaceship/lib/spaceship/tunes/iap_detail.rb:211:in save!'
from ./modify_products_balance_.rb:24:in <main>'
My code:
`
#!/usr/bin/env ruby
require "spaceship"
Spaceship::Tunes.login('xxx', 'xxx')

app = Spaceship::Application.find("com.xxx")

$i = 0

purch = app.in_app_purchases.find("com.xxx.xxx1")

ed = purch.edit

ed.versions =
{
    'en-US'=>{
              name: "Test Test Test",
              description: "Test Test Test"
    }
}
ed.review_screenshot = "/Users/Test/Documents/develop/projects/screenshot.png"
ed.review_notes = "Test Test Test"
ed.save!

`
git clone https://github.com/hjanuschka/fastlane.git
gem build fastlane.gemspec
gem install fastlane-2.37.0.gem
If I try to modify the new one in-app item with this script - it works fine.
How can I modify approved in-app items?


Automatically ask for PIN after reboot/shutdown

If makes sense to avoid the two clicks required to change your sign-in option, the "Sign in with other options" and clicking the icon corresponding to your other option.

Once I signed out, I can not sign in using my companion device. Windows 10 displays: "After a restart or logoff, the device requires verification before using it. Use another sign in option."
Is there any way to sign in using the companion device after signing out?

@MiguelRipoll23
I think this is not issue related Companion Device App.
@mu-triv

Is there any way to sign in using the companion device after signing out?

I think there is no way to sign in using the companion device.
Companion device only unlock your PC if Windows Hello is setup.
https://docs.microsoft.com/en-us/windows/uwp/security/companion-device-unlock

Windows Unlock with Windows Hello companion (IoT) devices

@HWataru
That's correct, this is Windows 10 related so I'll close this issue.


refine: optimze the button selection styles

This do makes button better in sight when selected. I missed a lot of chances to inherited effective talents due to the inconspicuous selection effects.
The former version has poor effect in iOS safari, so I submit new one.

The selected buttons will stand out as shown in the GIF above. We don't need to worry about missing some anymore.


Add flexibility to ESRP signing and scanning tasks

Improved logging.
Param to use custom signing JSON
Param to run signtool /verify after signing
Param to enable/disable page hash signing
Param to use different ESRP scan service name

@JamesWTruher Please review

@JamesWTruher Please review


Override ALPN methods on ReferenceCountedOpenSslEngine

Motivation:
We should override the get*ApplicationProtocol() methods in ReferenceCountedOpenSslEngine to make it easier for users to obtain the selected application protocol
Modifications:
Add missing overrides
Result:
Easier for the user to get the selected application protocol (if any)

Noticed this while working on https://github.com/netty/netty-incubator-codec-quic/issues/97

Noticed this while working on https://github.com/netty/netty-incubator-codec-quic/issues/97


OnePunch - BeachPalette adapted

I hope you like my theme. Thanks for that amazing app ! Having so much fun with css right now.
Sorry for those endless commits, its my first time forking a project.

Change the theme name to follow the convention please

Change the theme name to follow the convention please

Also I think you should change the white of the 3 dots in the top left corner and the light green of the shuffle, they are not easy to read

Also I think you should change the white of the 3 dots in the top left corner and the light green of the shuffle, they are not easy to read

And also slightly increase the constrast of the foreground green

And also slightly increase the constrast of the foreground green

okay ill hand u the new version tomorrow. thanks for the feedback.

okay ill hand u the new version tomorrow. thanks for the feedback.

Also I think you should change the white of the 3 dots in the top left corner and the light green of the shuffle, they are not easy to read

Is there a way to change the 3 white dots color? Doesn't seem to be an "html" component.

<button type="button" data-button="contextmenu" class="button button-icon-only button-more" data-tooltip="More" data-log-data="{ "index": , "target_uri": "spotify:row:ac36ce5c4fc4c984:spotify:track:0PAXhtBfNQVZ6n0ge2BUJW" }" data-interaction-target="context-menu-button" data-interaction-intent="show-options"></button>

Is there a way to change the 3 white dots color? Doesn't seem to be an "html" component.

Actually I don't even have them (just updated Spotify)


test(storagenode): unskip and merge TestExecutorRestore

Current dependencies on/for this PR:

main

PR #491   👈

PR #492

This comment was auto-generated by Graphite.

@ijsong started a stack merge that includes this pull request via Graphite.

@ijsong merged this pull request with Graphite.


Please allow me to edit my .vimrc

I've checked the documentation and I don't see anything about how to edit the editor settings in Vim mode.
Since it's clear it's not a stock installation of Vim, there must be a .vimrc config file somewhere on the server that is being used. Could you allow users to edit it on a per-user basis? As a long time Vim user, I have my own settings that I'm used to, and things like the auto-closing of brackets messes up my flow.
Thanks!

There is no vimrc file, it's just using CodeMirror's built-in Vim bindings: https://codemirror.net/demo/vim.html

There's no .vimrc. We use CodeMirro's Vim mode.

As a long time Vim user, I have my own settings that I'm used to

I totally understand as a long time Vimmer, but we can't have the same experience in browser.
Closing as a duplicate of other issues to make edtiors customizable.


Object per Voxel

What is about the ides to create for each Voxel an object that holds for example either a FID or a Spectrum, or multiple of them?
Thus, I could contrain a pipeline and does not hold any other data.
-> Load / Simulate data for this voxel on request
-> The object just holds all the functionalisties inside, thus object in object in object ...
-> The getter and setter using functions, like I did at D.A.T.A

No, not efficient. Library dask is used instead!


Panic when verifying malformed signed cookie

reproduction:
fn main() {
    let data = "x=yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy£";

    let c = cookie::Cookie::parse(data).expect("failed to parse cookie");

    let key = cookie::Key::from(&[0u8; 64]);

    let mut jar = cookie::CookieJar::new();

    let signed = jar.signed_mut(&key);

    signed.verify(c).expect("failed to verify cookie");
}

stack trace:
thread 'main' panicked at 'byte index 44 is not a char boundary; it is inside '£' (bytes 43..45) of `yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy£`', /rustc/952fdf2a1119affa1b37bcacb0c49cf9f0168ac8/library/core/src/str/mod.rs:576:13
stack backtrace:
   0: rust_begin_unwind
             at /rustc/952fdf2a1119affa1b37bcacb0c49cf9f0168ac8/library/std/src/panicking.rs:515:5
   1: core::panicking::panic_fmt
             at /rustc/952fdf2a1119affa1b37bcacb0c49cf9f0168ac8/library/core/src/panicking.rs:92:14
   2: core::str::slice_error_fail
   3: core::str::<impl str>::split_at
             at /rustc/952fdf2a1119affa1b37bcacb0c49cf9f0168ac8/library/core/src/str/mod.rs:576:13
   4: cookie::secure::signed::SignedJar<J>::_verify
             at /home/jess/.cargo/git/checkouts/cookie-rs-9c795d75da5c954b/0de451d/src/secure/signed.rs:57:35
   5: cookie::secure::signed::SignedJar<J>::verify
             at /home/jess/.cargo/git/checkouts/cookie-rs-9c795d75da5c954b/0de451d/src/secure/signed.rs:94:28
   6: scratchQVE5xNE9W::main
             at ./src/main.rs:12:5
   7: core::ops::function::FnOnce::call_once
             at /rustc/952fdf2a1119affa1b37bcacb0c49cf9f0168ac8/library/core/src/ops/function.rs:227:5

Tested on 0de451d9defefd0018a00b6001d2671ac2e33fdc as well as 0.15.0 from crates.io

Turns out split_at for a string and split_at for a Vec panic for different reasons. Bummer. Pushing a fix immediately.

Published in 0.15.1.


[Identity] Add: az identity add: az identity revoke --id argument

…preview API version
Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

Identity

@RamyaElangovanP Please resolve these CI issues

Let me check with you if the all changes of this PR are:
Add a command az identity revoke to revoke all tokens issued in the past for a specified user assigned identity
If so, suggested title is:
[Identity] az identity revoke: Add a command to revoke all tokens issued in the past for a specified user assigned identity

Please add test for this change.

Please raise a PR of aaz repo to merge your aaz model as well, and share the PR link here.

Let me check with you if the all changes of this PR are: Add a command az identity revoke to revoke all tokens issued in the past for a specified user assigned identity
If so, suggested title is: [Identity] az identity revoke: Add a command to revoke all tokens issued in the past for a specified user assigned identity

yeah it is. Updated as suggested

Please add test for this change.

Added test

Please resolve CI failed items

@RamyaElangovanP Any update?


builder.Prompts.choice() leave blank menu option

Im using node.js SDK and using:
 builder.Prompts.choice(session, "Choose a topic of interest:", "Cloud|Telecoms|...

Always leaves a blank space at the top of the menu list items:

Is this a bug or by design?

I believe a fix for this has been made. @danmarshall?

@haganbt Can you update to latest and try again?

Many thanks @eanders-MS - updated to v3.5.22.
Looks like the handling of different width sizes is much improved which is great :)
There is still a good deal of white space at the top - clearly not a serious issue but might be room for improvement to make sure the bottom and top widths are identical.

Feel free to close if this is a not fix.

Hi @haganbt - appreciate the bug report. This was indeed a regressed bug. I've sent a PR to the WebChat repo: https://github.com/Microsoft/BotFramework-WebChat/pull/222

Wonderful, thanks @danmarshall


Query Language

We need a query language so that we can search and retrieve statements from the node.
Basic structure, following SQL:
SELECT <selector> FROM <namespace> [WHERE <condition>] [LIMIT <limit>]

The selector dictates what parts of the statement are retrieved; it can be the whole statement, or any (combination) of fields from the envelope.
Conditions should support at minimum retrieval by publisher id and timestamp, which is a baseline requirement for implementing pubsub synchronization.
Open Issue: Semantics of statement retrieval get murky when we involve compound and republished statements, which are composite. Which parts of the statement should we retrieve in this case?

Hmm I'm wondering how much relational algebra we are going to implement. Maybe a lot, so this is actually a pretty appropriate approach.


Update zend-studio to 13.6.0

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask's name and version.

Thank you for the contribution. It was merged directly as 30f29d2bb17d81120bf12bbd9a0259c310b84cc9. Your contribution is still credited to you.


Update New-AzureADApplicationPasswordCredential.md

proposing clarification around start/end date so that people know it should be UTC

Docs Build status updates of commit c6ef1a2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

azureadps-2.0/AzureAD/New-AzureADApplicationPasswordCredential.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Hi @tikicoder
Per the read me file:
Please be aware that if you have any updates to automatically generated reference content, you should create an issue and not a PR.  The issue will then be created into a bug and triaged accordingly.  We do this because the reference content must mirror the *dll-help.xml file and subsequent updates to the reference content may overwrite any changes made through the repo.  Capturing it in the source code ensures that this does not occur.  Any PR with changes to automatically generated reference content will be closed.
Automatically generated reference content is any of the content under this Reference node, such as Get-AzureADUser
This only applies to reference content and not conceptual content.  Pull requests for changes to conceptual content are accepted and encouraged.  An example of the conceptual content is the Overview or a scenario such as importing data.
Thank you!
Bill


es2018

use es2018 some time ago，why use es2016 now？ @sodatea

https://github.com/vuejs/tsconfig/blob/26fc528db347dbbbbaa2ea15d3c2d95c197887b7/tsconfig.web.json#L5-L9
It's explained in the comments.

3q


Merge main to extra features

What ❔

Why ❔

Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.
[ ] Code has been formatted via zkstack dev fmt and zkstack dev lint.

Remember not to squash this


Saving Files as xml not working

I ran the command gradlew build, and the application starts as expected and works well.
The problem is when I try to save the profile as XML, I click save but the file is not saved at all and nothing happens.

@idanshulman if you havent saved the project before you will have to "save as" and then subsequent saves will be will just "save"

Hey, I did try saving as the project, this is when the problem occurs. When ai click save as, no xml file is actually saved.

Hmm. What OS are you using? Does your current user have write permissions on the folder?

I am administrator using Windows 10

This is weird, it was working for me and then I just tried it again and the same thing happened.

Okay so I have looked into this today and found that the working directory was stuck to where I originally ran the app even after I moved the app to a different folder. The original directory where I ran the app did not exist anymore so nothing happened when I clicked save. I confirmed this by creating the missing directory and the save option started working again.
To check where your working directory is, open .../users/user/.motion-profile-generator/mpg.properties in a text editor and look at the value of file.workingDir. You can also change this value to the directory where your app is.
I think the main problem was that the original directory didnt exist anymore.

Thanks for the reply @blake1029384756 , I tried changing the file.workingDir attribute of the properties file and noticed it changes automatically to the correct value. I ran the jar from the cmd and received an exception when clicking the save button on the save as windows, and the exception occurs on every working directory.
The unhandled exception:

Exception in thread "JavaFX Application Thread" java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
at javafx.fxml/javafx.fxml.FXMLLoader$MethodHandler.invoke(Unknown Source)
at javafx.fxml/javafx.fxml.FXMLLoader$ControllerMethodEventHandler.handle(Unknown Source)
at javafx.base/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
at javafx.base/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
at javafx.base/javafx.event.Event.fireEvent(Unknown Source)
at javafx.controls/javafx.scene.control.MenuItem.fire(Unknown Source)
at javafx.controls/com.sun.javafx.scene.control.ContextMenuContent$MenuItemContainer.doSelect(Unknown Source)
at javafx.controls/com.sun.javafx.scene.control.ContextMenuContent$MenuItemContainer.lambda$createChildren$12(Unknown Source)
at javafx.base/com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
at javafx.base/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
at javafx.base/javafx.event.Event.fireEvent(Unknown Source)
at javafx.graphics/javafx.scene.Scene$MouseHandler.process(Unknown Source)
at javafx.graphics/javafx.scene.Scene$MouseHandler.access$1300(Unknown Source)
at javafx.graphics/javafx.scene.Scene.processMouseEvent(Unknown Source)
at javafx.graphics/javafx.scene.Scene$ScenePeerListener.mouseEvent(Unknown Source)
at javafx.graphics/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(Unknown Source)
at javafx.graphics/com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(Unknown Source)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at javafx.graphics/com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$2(Unknown Source)
at javafx.graphics/com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(Unknown Source)
at javafx.graphics/com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(Unknown Source)
at javafx.graphics/com.sun.glass.ui.View.handleMouseEvent(Unknown Source)
at javafx.graphics/com.sun.glass.ui.View.notifyMouse(Unknown Source)
at javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
at javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.lang.reflect.InvocationTargetException
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.javafx.reflect.Trampoline.invoke(Unknown Source)
at jdk.internal.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at javafx.base/com.sun.javafx.reflect.MethodUtil.invoke(Unknown Source)
at javafx.fxml/com.sun.javafx.fxml.MethodHelper.invoke(Unknown Source)
... 44 more
Caused by: java.lang.NoSuchMethodError: com.sun.org.apache.xml.internal.serialize.OutputFormat.(Lorg/w3c/dom/Document;)V
at com.mammen.main.ProfileGenerator.saveWorkingProject(ProfileGenerator.java:435)
at com.mammen.main.ProfileGenerator.saveProjectAs(ProfileGenerator.java:386)
at com.mammen.ui.javafx.MainUIController.showSaveAsDialog(MainUIController.java:480)
... 54 more

@idanshulman Can you please built from the latest code and try again? A java update a few days ago removed the old xml library. The following line makes me think you have the old code:
Caused by: java.lang.NoSuchMethodError: com.sun.org.apache.xml.internal.serialize.OutputFormat.(Lorg/w3c/dom/Document;)V

Thanks, That solved my problem

Awesome good to hear!


Next slide shows up for a second on page reload

On reload the second slide appears briefly. Is this a bug?
You can see the issue here: https://elastic-khayyam.212-34-165-121.plesk.page/
Thanks for help!

Hi @Patric96
Thank you for your feedback.
This is a bug in the slider implementation used by Shopware. (you will see the same thing happening with the sliders from core cms elements)
This issue is thus out of scope for this project.


rosetta error: futex(FUTEX_LOCK_PI_PRIVATE) failure: 35

This is a bug in Rosetta that we're waiting for Apple to fix. I opened this issue to make it searchable.
To work around the bug, disable Rosetta in OrbStack settings (at the cost of performance).

Fixed for the next version (with a workaround while we wait for Apple).

Released in v0.13.0.

Hello, First of all, I want to say thank you for this tool. It is much better than the alternatives out there.
Unfortunately, this error might be back in the 0.14.0 release.
I have an amd64 image running fine in 0.13.0 but it is now failing with this error.
Thank you

@humphreymugambi What program are you running that's triggering the issue? Can you share the full output (redacted as needed) to provide context around the error? It's best if you can share a way to reproduce this.
Nothing related to this has changed in v0.14.0. The error is very inconsistent, sometimes happening many times a row and sometimes not at all, so it's just random chance that you noticed this now.

Thank you for the quick response.
I am trying to run the latest official phpmyadmin docker image, https://hub.docker.com/r/phpmyadmin/phpmyadmin/
For now, I have gotten around it by using arm64v8 image https://hub.docker.com/r/arm64v8/phpmyadmin
It works, but a little annoying when I share my code with others who have amd64, I have to change the image.

@humphreymugambi There's no need for that. The new official phpmyadmin image (not phpmyadmin/phpmyadmin) has both amd64 and arm64 support.
I'll take a look at this issue, but there's no reason to use emulation when it's not needed. You should always prefer native arm64 images whenever possible.
It's also not possible to fix this 100% reliably until Apple fixes the bug in Rosetta.

@kdrag0n Thank you.
I will use the new official image.


[Prod Checks] Fix: Avoid wrong reports of missing notion workflows

Description
Production check that notion workflows are active sometimes wrongly reports missing workflows.
Cause is that fetching workflow statuses occasionaly transiently fail, with error Received RST_STREAM with code 0 (Call ended without gRPC status)
Example log
This PR fixes by retrying 3* before failing.
Risk & deploy
na

:wave: Will merge to silence monitors, PMRR
Happy to discuss IRL tod to improve if needed


Can we please have a release for Scala 2.11.0-M7?

Thanks!

+1 very useful library!

Yes I would love to use this!

There is a fork of this library which is on Scala 2.11: https://github.com/jlmauduy/ascii-graphs
(https://javalibs.com/artifact/com.github.jlmauduy/ascii-graphs_2.11)

Closing this old issue now.


Add configurable cookie domain property

Closes #19 .

Merged, thanks @blumgart for the issue + the awesome contribution ❤
Here's the release: https://github.com/sidebase/nuxt-session/releases/tag/0.2.3


The minimum Permission Role to add the Microsoft partner ID

Hi,
What is the RBAC role needed to add Microsoft partner ID ? Contributor. Billing Contributor ?
Reader role for example does not work.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f901056-c225-b086-cdaa-c8bd978db64c
Version Independent ID: 9c067eb4-54cb-e141-d82f-e136ff3c671e
Content: Link an Azure account to a partner ID
Content Source: articles/cost-management-billing/manage/link-partner-id.md
Service: cost-management-billing
GitHub Login: @dhirajgandhi
Microsoft Alias: banders

Any role allows the user to link the partner ID.  The partner recognition depends on the role. Example - CSP Partner Earned Credits are not allowed for reader role.

@dhirajgandhi Thanks for the quick response. :+1:

@SamirFarhat Closing this issue for now. If there are further questions regarding this matter or feedback on the referred Azure documentation, please do let us know and we will gladly continue the discussion.


[5.9] Cherry pick "Add Sendable to Date, DateComponents, Data and UUID"

This cherry picks this PR: https://github.com/apple/swift-corelibs-foundation/pull/4777

@swift-ci please test

@swift-ci please test Windows

@swift-ci please test

@parkera @shahmishal It looks like the 5.9 macOS CI is failing and it seems unrelated to my PR here. Are you aware of this?

@swift-ci please test macOS

Looks like something in xctest is failing the CI:
FAIL: SwiftXCTestFunctionalTests :: TestCaseLifecycle/Misuse/main.swift (26 of 26)
******************** TEST 'SwiftXCTestFunctionalTests :: TestCaseLifecycle/Misuse/main.swift' FAILED ********************


api model and dataset

Hello,
Thank you for this excellent work !
I'm wondering whether the model called by Grounding-DINO-1.5 API is finetuned on COCO or Grounding datasets like refcoco ?

Hello, Thank you for this excellent work ! I'm wondering whether the model called by Grounding-DINO-1.5 API is finetuned on COCO or Grounding datasets like refcoco ?

No, our API model was not trained on COCO images (which are included in COCO/LVIS/RefCOCO datasets)


build: Bump kube-rbac-proxy to v0.13.1

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump kube-rbac-proxy version to patch 18 of its 20 CVEs. Once applied, the CVEs left will be CVE-2022-32149 and GHSA-69ch-w2m2-3vjp.

https://artifacthub.io/packages/olm/community-operators/security-profiles-operator?modal=security-report
Which issue(s) this PR fixes:
None
Does this PR have test?
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE

Codecov Report

Merging #1299 (a707638) into main (308b783) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1299   +/-   ##
=======================================
  Coverage   43.92%   43.92%
=======================================
  Files          49       49
  Lines        5514     5514
=======================================
  Hits         2422     2422
  Misses       2972     2972
  Partials      120      120


Correct settings for Atari 8-bit 32K 5.25 floppy?

I'm trying to read an Atari 8-bit 5.25 floppy with a generic PC 5.25 drive I have successfully used with GW in the past.
The floppy says it's a "32K disk" on the label  - trying to read it to .scp format with this CLI gw.exe read --format=atari.90 --raw "C:\Users\xxx\Desktop\derp.scp"
gives me this:
Reading c=0-39:h=0:step=2 revs=2
Format atari.90
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: IBM FM (17/18 sectors) from Raw Flux (79336 flux in 400.60ms)
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: IBM FM (17/18 sectors) from Raw Flux (198293 flux in 1001.20ms) (Retry #1.1)
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: IBM FM (17/18 sectors) from Raw Flux (317250 flux in 1601.80ms) (Retry #1.2)
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: IBM FM (17/18 sectors) from Raw Flux (436207 flux in 2202.40ms) (Retry #1.3)
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: IBM FM (17/18 sectors) from Raw Flux (555163 flux in 2803.00ms) (Retry #2.1)
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
T0.0: IBM FM (17/18 sectors) from Raw Flux (674119 flux in 3403.60ms) (Retry #2.2)
T0.0: Ignoring unexpected sector C:0 H:0 R:18 N:0
<..snip>

is a --format=atari.32 needed, or am I doing something else wrong?

The format specifier is wrong in Greaseweazle. The sector numbering is 1..18, not 0..17. Hence sector 0 is not found, and a "spurious" sector 18 is found instead!

With latest Greaseweazle tools (v1.5), download the attached config and run as
gw.exe read --diskdefs=atari.90.cfg --format=atari.90 --raw "C:\Users\xxx\Desktop\derp.scp"
Let me know how it goes!
atari.90.cfg.zip

@keirf Nice! That worked (I also had to add --tracks=step=2). Thank you!


Smart app Speedtest Tracker

trying out graphs and stuff
Stating max Y in title since no other way to tell whats happening.... unless have the user state max speed or show the graph values?

this is where you would want to use a gauge IMO.  something I told you I'm looking into :P
Then get the user to set the maximum of the gauge (me I would put 1000Mps, probably a sensible default), and just work on that.

I think the graph is useful for tracking historically and things. Personally I'd prefer it more than a gauge for this use case
But I can 100% see people preferring the gauge for the average/latest stats section

I'll hold off changes :)

Added configurable Max download/upload (Mb/s)
Can be reused in future for a Gauge setting but also works for graph now :)


DB: add sequelize-cli to project to facilitate running migrations, et…

…c; add migrations for all existing models, tables; create migrations to populate skills and projects

@raindogg Will, this is the basics of adding sequelize-cli and creating some migrations. I think we are well-advised to move all of the code from 'sync.js' into migrations. It's good to start with a base, assuming we will add fields to those tables and other changes. Easier to manage, especially if we have multiple DBs going forward, and ensures things don't get out of sync.
I created migrations for populating skills and projects. These can only be run once; unlike a seed file which can be run again and again, creating duplicate records.
We may look at the data we have for those, if we want to add descriptions for Skills, or make any changes to that data now.


[Candidate 2v2 Diamonds Edge ZH v1] Tech Buildings have custom rotations that make their flag less visible

Observed behaviour
Tech Buildings have custom rotations that make their flag less visible.
Expected behavior
Tech buildings preferably have default rotation or a rotation that makes their flag highly visible.
Screenshots

The Oil Derricks too. Rotating by 45 or 90 degrees should fix this.


Cannot Export As - UI Issue

Module: 08
Lab/Demo: 09
Task: Convert a notebook to a script
Step: 05
Description of issue
When selecting Export As -> Python (.py) option - nothing happens. I believe there is a UI issue that isnt creating a file. Two learners brought up the issue and have reproduced it myself.
Repro steps:

Thank you for submitting an issue. If nothing happens it sounds like a bug in the UI. The instructions are still correct and should work as expected when the product performs as expected.


Avoid casting to [String: AnyObject] dictionary for performance improvement

swift_dynamicCast which comes from casting to [String: AnyObject] is a performance bottleneck.

:rocket:


Update for Xcode 8 beta 6

If anyone has an idea to get this to work on beta 6, would be great :)
I wanted to start beta-testing with Testflight with my beta 5 app, but beta 5 builds are not accepted anymore by Itunes Connect.

I have been working on the same thing as well. Instead of adding casts to AnyObject I have changed the Dictionaries to be of type [String: Any] which is now the standard Dictionary type when working with Id from Objective-C. This removes the need for casts to AnyObject.
I have also modified the tests and they pass on OS X, but not on iOS. Any idea why?

You should run the tests on a real device rather than a simulator, it's something to do with the Keychain service itself.

Hi Jerome,
How can I run the test suites on a real device? When I want to do that XCode tells me: "Logic testing on iOS devices is not supported. You can run logic tests on the Simulator."
What about changing your pull request to redefine the [String: AnyObject] dictionary definitions to [String: Any]? As far as I understood, this is the new way Apple wants us to treat Dictionaries in conjunction with Objective-C libraries. They are of type [AnyHashable: Any] to be more specific.
This seems the proper solution to me, then you can remove your type casts to AnyObject.
What do you think?

To run tests on devices needs a host app, otherwise the tests probably won't ever pass until Apple fixes it.
Since you've already done the modification, I think it's a better idea to submit your pull request.

I can do that. But do you also think this is the better approach? I am no swift expert and I need to doublecheck my understanding a bit :-)

This has been merged in #142. Thanks very much @JeromeTan1997 :)


Spec Enhancement Request: Specify how different noise functions correlate.

Please specify how different noise() noisetypes correspond to each other: (This may only relate to the reference implementation, but it would be nice if future implementations were consistent with the reference implementation here.)
I liked how the spec spelled out that cellnoise(...) was equivalent to noise("cell", ...), and how it also said that cellnoise(x) and cellnoise(floor(x)) were also equivalent. In cases where someone wants to maintain backward compatibility with previous shader versions, it might be helpful to know, for instance that noise("cell", x) returns the same result as noise("hash", floor(x)). (I have no expectation that this is the case. It's simply an example.)
As existing implementations may already disagree with the reference implementation on these, the spec should make this correlation optional.
Problem
It is difficult to increase the entropy resolution of code using cellnoise(...) or noise("cell", ...) without special-casing integer values unless you know how to emulate the "cell" behavior with another type like "hash". If the spec spelled out a correlation, this would be much easier.
Expected behavior:  The spec might say something like:

noise("cell", x) returns the same result as noise("hash", floor(x))

Actual behavior:  No correlation is specified.
Steps to Reproduce

Release software with shaders using cellnoise() that you wish to preserve behavior of.
Enhance shader to want values between cell boundries in newly supported cases.
Either you:

Scale cellshader() input to allow cell boundries at a different frequency. (This shifts all your integer pseudo-random values.
Special-case integer boundaries to use cellnoise(). This increases code complexity.
Find a way to generate cellnoise() from hashnoise() by experimentation or reverse-engineering the code.

Versions

OSL branch/version: 1.10
OS: Mac, Windows and Linus
C++ compiler: n/a
LLVM version: n/a
OIIO version: n/a

It may be that the current implementation of noise("hash") is identical to noise("cell") at exact integer values, but this property is not explicitly part of the design and I don't think I would have wanted to enshrine that guarantee into the language spec.
In general, there are no guarantees that I'm aware of between the different noise functions. For example, sometimes new users think that maybe there is a relationship between noise on 1D, 2D, and 3D domain -- i.e. that noise(float f) should be the same as noise(f, 0) or noise(point(f,0,0)). But in fact, neither of those are true (and wouldn't be desirable, for complicated reasons related to the range and power spectrum of noise).

It may be that the current implementation of noise("hash") is identical to noise("cell") at exact integer values, but this property is not explicitly part of the design and I don't think I would have wanted to enshrine that guarantee into the language spec.
It would be helpful to my current project to know if this currently happens to be true. Do you know one way or the other?

I realize there are reasons to avoid adding this specificity to the spec:

This would tie other implementors to what was intended to be a reference implementation detail.
Some APIs or hardware implementations may have accelerated implementations of these that contradict these correlations. We don’t want to prevent an implementor from using these in violation of the spec.
Some implementors may devise new and better ways of generating these noise function outputs that may violate these correlations. Again we don’t want to discourage this innovation by mandating these correlations.
This may push the spec closer to an undesirable “pixel perfect” definition, preventing differences in implementations

That said, I was providing a use case where suggesting a correlation between “hash” noise (as a lowest common denominator) and other noise functions may be beneficial for the sake of backward compatibility. This is just a suggestion, and may not be a good idea, but I thought it worth suggesting.
I was suggesting language similar to:

noise(“foo”, ...)  function MAY be implemented as foo_transform(noise(“hash”, ...)) but this relationship is not guaranteed.

OK, that's fair. Let me see if I can clarify it.

I'm going to close this as an ongoing issue. I'll think about whether and how to mention this in the spec.

@lgritz, I really neither want to open a new issue, nor reopen this one but wanted to mention this for your feedback:
I’m trying to move more precomputation and loop unrolling to compile time. It would be nice if the language provided more mechanisms for this, but i’m considering using https://github.com/pfultz2/Cloak to leverage the preprocessor for this. It’s a scaled-down version of Chaos-PP, that later became Boost Preprocessor... I think Boost Preprocessor is much too big for runtime compilation use, but cloak weighs in at a single 3kb file.
All three of these sit on top of the preprocessor and should be pretty-language agnostic...what are your thoughts about adding more support in the language for compile time precomputation and optimization using techniques like this.
This is really just a request for some thought and feedback. Thank you in advance.

Can you explain what would that do that's useful? I can't understand from the project you link to what it does.

@lgritz, the specific case that i’m currently interested in is explicit loop unrolling... and a non-trivial loop at that. The code i’m looking at had a 5 case of-else chain each with a successively shorter list of assignments in it. I rewrote this as a loop for clarity, but was encouraged NOT to submit it when another developer optimized some of the assignments with swizzling. I am sure the code with the swizzling is more performant, but I would prefer to have a way to express that in a more readable loop-like way, and expand to the original code at compile time... including the bundling of multiple assignments into swizzling.
The specific code i’m talking about is from here:
https://developer.blender.org/diffusion/B/browse/master/intern/cycles/kernel/shaders/node_voronoi_texture.osl;04c54dec44568a4903b5f8e29cad4b3e466fb6e0?as=source
but i’ll Include changes from memory I mentioned above:
if (d < da[0]) {
   da[3] = da[2];
    da[2] = da[1];
    da[1] = da[0];
    da[0] = d;

    pa.yzw = pa.xyz;
    pa[0] = vp;
}
else if (d < da[1]) {
    da[3] = da[2];
    da[2] = da[1];
    da[1] = d;

    pa.zw = pa.yz;
    pa[1] = vp;
}
else if (d < da[2]) {
    da[3] = da[2];
    da[2] = d;

    pa.w = pa.z;
    pa[2] = vp;
}
else if (d < da[3]) {
    da[3] = d;
    pa[3] = vp;
}

I'm still not quite sure I understand specifically what you are asking me to do on my end.


Pandas

What does this PR do?
Test Pandas package in nuitka
Why was it initiated? Any relevant Issues?
Python package providing high-performance data manipulation and analysis tool using its powerful data structures.
PR Checklist

[x] Correct base branch selected? develop for new features and bug fixes too. If it's
part of a hotfix, it will be moved to master during it.
[x] All tests still pass. Check the developer manual about Running the Tests. There
are Travis tests that cover the most important things however, and you are
welcome to rely on those, but they might not cover enough.
[x] Ideally new features or fixed regressions ought to be covered via new tests.
[x] Ideally new or changed features have documentation updates.

What's going on here. :-)


Useless break statement

The case block will break automatically.
https://github.com/oracle/oci-cloud-controller-manager/blob/220ab897fd3e8b1bd4b6b6d13a072f477453c073/pkg/util/mount/mount_linux.go#L97-L102

Right, will fix it by next release.

Right, will fix it by next release.


Cannot call base class method

C#
[JSExport]
public class A {
  public virtual void Hello() {
  }
}

[JSExport]
public class B : A {
  public override void Hello() {
  }
}

JS
var b = new B();
b.hello();

Calling a base class method resulted in the following error
TypeError: Illegal invocation

Note: AOT enabled

@Houfeng I cannot reproduce the error so far. The code snippet above runs without error. Did you omit something critical when simplifying the code for the bug report?
Is there a stack trace with the error? It might include the .NET stack also.

Closing because there is not enough information to reproduce the error.


Use GitHub Actions for CI

I noticed that this repository doesn't have CI yet! There aren't many tests written yet, but this should also catch issues from not running rustfmt or clippy, too.
What minimum Rust version does fs-err support? I picked 1.39.0 here because I pulled this job out of one of my projects, but I imagine this crate runs on much older Rust versions.

Thanks!

I think 1.39.0 is about right for the minimum rust version, IIRC it was a recent change that allowed doing impl From<MyError> for io::Error


Is it possible to update links in a file that should be busted - v1.0?

Hi Ben,
as i already mentioned in my previous issue, i tested the v1.0.0-beta..
Now i have a bunch of new issues ;) :
Is it possible to update links in a file that should be busted?
In my index.html there is a link to main.css, which i want to get busted as an asset,
but this css-file contains links to other assets, that should get busted too..
when i add the css-file to both arrays
assets in options => to be busted
AND
files => to be parsed for links to busted assets
the css file could not be opened (Error code: ENOENT) ...
at this time it is already busted and the filename has changed..
When it is only in the list "to be busted", the links to the other busted files won't get updated..
And when it is in the list to be processed, the links are ok but the css itself isnt busted..
How can i achieve this properly?
My actual config - here the css-file is not found:
      cacheBust: {
        options: {
          baseDir: '<%= grunt.config.get("output_path")%>',
          deleteOriginals: true,
          assets: ['css/*','js/*','img/*','fonts/*']
        },
        assets: {
          files: [{
            expand: true,
            cwd: '<%= grunt.config.get("output_path")%>',
            src: ['css/*.css','index/*.html']
          }]
        }
      },

My first idea were those changes to /task/cachebust.js on lines 43ff:
        // Go through each source file and replace terms
        // Check if filepath is in assetMap => then use busted filepath
        this.files.forEach(function (file) {
            file.src.forEach(function (filepath){
              var relativeFilepath = filepath.replace(opts.baseDir + '/','');
              if (relativeFilepath in assetMap) {
                replaceInFile(opts.baseDir + '/' + assetMap[relativeFilepath]);
              } else {
                replaceInFile(filepath);
              }
            });
        });

It passes all Tests and works as expected.. but it feels dirty to me..
so please excuse the missing pull request..
Furthermore two problems with the docs..

the array in options/assets isn't mentioned in the docs..
i found it in the test-configs.. but for other beta-testers it might be helpfull..

in the test-configs there are only two properties..
"options" and "files"..

but when i use it this way, it does not work:
This example produces "pattern.indexOf is not a function":
      cacheBust: {
        options: {
          baseDir: '<%= grunt.config.get("output_path")%>',
          deleteOriginals: true,
          assets: ['js/*','img/*','fonts/*']
        },
        files: [{
          expand: true,
          cwd: '<%= grunt.config.get("output_path")%>',
          src: ['css/*.css','index/*.html']
        }]
      },

Do you have a hint for me?
Thx!
By the way: Thank you for this great Plugin!!
Cheers,
Lietzi

Hello again! Thanks for trying it out - I need more people to give it a go before I push it out. I'll have a read through this later :+1:

ok - i'll try it on a dev-branch of one of
my bigger commercial projects next week..

Hey - so I've had a chance to look into the problem. The order of execution was something along the lines of this:

Find all assets => copy and hash them => go through files and replace

The problem is that the copy and hash them phase is creating new files which aren't in the array of files returned in the first step, Find all assets. I've changed the order of execution to be:

Find all assets => copy and hash them => pickup any new files => go through files and replace

I've added a test case and pushed the changes to the branch so should be working

Hi Ben,
much cleaner approach - for me it works fine.. Great Work!
But i have to reopen #148 - woff and woff2 files getting both the hash of the woff file..
Cheers,
Lietzi


cherry-pick manually

What type of PR is this?
/kind bug
What does this PR do?

Which issue(s) does this PR fix?

Fixes #
Special notes for your reviewer:

Does this PR introduce a user-facing change?

/lgtm

/hold

/hold cancel

/approve
/lgtm


Add ngStyle to Cheat Sheet

The 'Built-in Directives' section of the Cheat Sheet has ngClass, but ngStyle is missing and needs to be added.

CheatSheet issues goes to the angular/angular repo because the cheatseet is in there.

@Foxandxss

the cheatseet is in there

https://github.com/angular/angular/blob/1f3198cb505a6bb74aadf022c7142f3f4d8cbe28/aio/content/guide/cheatsheet.md this one? :)

No, that is clearly empty. I believe that they are here. Master changed for v4 so I guess we pull them from the 2.4.x branch.


Issue with Query when 'where' is used

Hey, thanks for an awesome library! I'm using Firebase Functions and testing it out the query on one of my Firestore triggers. it works great when I'm doing a simple 'near' query but as soon as I add a 'where' it returns 0. Below is a screenshot of my db and code. Any advice would be helpful.

Have you indexed your database? The query may be failing because it's not queried... Once you execute get() on the query you should do a catch to see if it gives you a url to index your database.
If you're doing an onSnapshot instead of get the second callback would be your error handler.

@MichaelSolati Yeah my db is index. I am doing a get. I've attached more screenshots that can clarify things. Thank you for your prompt response!

Ok, so I missed something obvious when looking over your screenshots (my bad). Data queried by geofirestore needs to be maintained by geofirestore, and geofirestore stores all data associated with your object inside the d property, not at the top level. It's an inconvenience, but a necessity at this time.
I do plan on changing how geofirestore works, but time constraints have prevented me from working on v4.0.0.

Ah okay gotcha! Any chance you might know when v4.0.0 will be out? :)

@MarkedWarrior Did you make this work?

@barakoles yeah I just restructured my data to be included under d and everything worked correctly

@MarkedWarrior Awesome, you used the same query and had to index the db as well right? BTW, what is this 'formater' you use that highlights the parameters you should use? thanks dude

@barakoles Yep, same query! Oh I use Webstorm with typescript installed

I have been itching to figure this out and I guess this issue is good place as any to note this for geofirestore users:
firebase.initializeApp(firebaseConfig).firestore()
  .collection("planner")
  .where("d.authorId", "in", [`${this.props.auth.uid}`])


Use lists to remove duplicate code

Some more changes to reduce code duplication. I only tested with current weather and there was no precipitation forecast so more testing might be required. I didn't change any logic, only refactored.

@CourchesneA if you made a case or something feel free to put a picture of it in the readme! We could maybe create an Examples gallery section :)


Drift_dev code gen incorrect assumption about type nullability

REPRODUCE STEPS
To reproduce issue on repo's example app (with drift_dev 2.13.0)

sql.drift

CREATE TABLE money(amount REAL NOT NULL);
sumTracker: SELECT sum(amount) FROM money;

database_test.dart

  test('can watch money', () async {
    final stream = database.sumTracker().watchSingleOrNull();
    stream.listen((value) {
      print(value);
    }, onError: (Object error, StackTrace stack) {
      print('ERROR: $error');
    });

    await database
        .into(database.money)
        .insert(MoneyCompanion.insert(amount: 100.0));
    await Future.delayed(const Duration(milliseconds: 500));
    await (database.delete(database.money)).go();
    await Future.delayed(const Duration(milliseconds: 500));
  });

I expected the printed values be:
null
100
null

But I got errors instead:
ERROR: type 'Null' is not a subtype of type 'double' in type cast
100.0
ERROR: type 'Null' is not a subtype of type 'double' in type cast

The issue is that sumTracker return Object type is Seletable<double>, which is not always the case, when the table is empty, there's no rows to be selected hence null returned
Workaround: make column amount nullable, sumTracker now returns the correct Selectable<double?>

Thanks for the report, I've fixed this in d70de95382c7cd63fe66ef7008301ec2dc00566d.

Workaround: make column amount nullable, sumTracker now returns the correct Selectable<double?>

You can also use sumTracker: SELECT nullif(sum(amount), null) FROM money; as a workaround. It doesn't change the query, but drift will take that as a hint to make the column nullable.

Just a reminder that this issue can happen with other aggregators like MIN MAX AVG, maybe GROUP_CONCAT too.


chore: promote test20 to version 0.0.2

chore: promote test20 to version 0.0.2
this commit will trigger a pipeline to generate the actual kubernetes resources to perform the promotion which will create a second commit on this Pull Request before it can merge

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign q1323829945
You can assign the PR to them by writing /assign @q1323829945 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@q1323829945: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
0b94ef4994ccec1e0aaf8ccb6bd810c3579e8267
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


File upload error on checksum mismatch

A user has reported failures on uploading largish files (~1GB) using the browser (chaise+ermrestjs).
First, the message from the browser hints at a checksum mismatch.

Network tab of developer tools shows a couple chunks in "cancelled" state.

And then a screen shot of the console output for what its worth.

@robes
I just tried uploading a file to hatrac which is of size 1.4GB and it worked. Could you mention the extension of the file and maybe the file itself.

@robes They have a hard time replicating this issue. Can you give steps and file examples, so @chiragsanghvi can proceed with bug fixes?

It is not a consistently reproducible error. I even had this user join me on a bluejeans call so that we could watch the process together with dev tools open. (Because I was unable to reproduce it.)
He had just encountered the error on a file before our call, and when I was on the call with him, the upload of the exact same file worked. So I do not believe this is file name, file format, etc. specific.
I think to attempt to reproduce, you should test on a slower network. This user was getting upload rates that varied between 270KBps and 3.3MBps as I watched. You might also try inducing errors (temporary/quick network outage) during a transfer, if that hasn't already been thoroughly tested.
If you cannot reproduce this bug, then the next step is to print a lot more diagnostics into the javascript console so that we can collect more information from our users the next time it happens.
Since we are getting an error that suggests the checksum is off, for e.g., print the checksum to the javascript console after you compute it, then print it at the end, when you get an error like this print the things that didn't match. Etc. Just put in enough breadcrumbs.
There will always be some bugs that only our users will encounter and one school of thought is that you should leave in logging in production code just for situations like this. Not all bugs will have simple repeatable steps to reproduce in our environment.

@robes Can you confirm one significant point with the user?  They SHOULD NOT attempt to upload a file that is potentially being modified simultaneously by any other processes on the client side.  This would look the same as any other form of corruption from the point of view of our end-to-end integrity checks.

In any case, I think it would be worth logging what the uploader is doing:

Log the file that was selected and whatever metadata we can obtain (e.g. size and last modified if available via the file api)
Log the md5 we compute prior to upload
Log the file metadata again after the upload (size and last modified)

A more expensive thing would be to catch the error and repeat the local MD5 and log it too, to distinguish the case that the file appears mutated on disk rather than corrupted in flight.

BTW, the wrinkle is that if we are using a chunked upload job, we can send chunks out of order and cannot recompute a running checksum of the bytes sent as another confirmation.  To do that, we'd have to serialize the chunk processing which would erase the benefit of parallel chunk transfer on slow networks...

This is an issue with the browser or the server.  If you check the network log

There're 2 requests that got cancelled. This might be because the server didn't respond or the connection was aborted. HTTP doesn't allows us to identify cancelled or aborted requests easily.  They both have status code -1.
Our code doesn't handle this and considers it as a success and goes ahead with sending the  complete upload job request. This request ends up with a response mentioning there is a checksum mismatch.

Not sure how I can reproduce this issue. I tried changing my network speed (switching that in the dev console) and intermittently turning off the connection and turning it back on.
In the first case, I was able to see the chunks take a long time to upload, but didn't experience any issues with multiple chunks being uploaded and being reorganized improperly (potential mismatch of md5).
Int he second case, if it was intermittent enough (a quick off then on again right away), there was no issue with the job continuing. If the network connection was lost for a slightly longer period of time, a No Connection Error is thrown.

Do we have the logs that @karlcz suggested above? Does that log go to our server? If not, maybe we can use the same logging mechanism as the terminal case to log that on the server and observe the frequency that this problem is seen.

Logging the other information for the file upload requests has been done. Not sure what else we can do but to wait for the user to notify us when it happens again.

I was able to reproduce this issue with the following scenario:
Setup:

Have 2 files/namespaces that already exist in hatrac. This was done using the same namespace but 2 different files.
file 1 has name like name_1.jpg
file 2 has name like name 2.jpg

Steps (this was found when using the test suite. Notably the recordedit-add spec using the 2nd table, File):

fill out the first form and select file 1
click + to add a second row
leave all the fields the same except the selected file
select file 2
submit the data
md5 mismatch error should appear

Note: Both file 1 and file 2 should not be re-uploaded in this case because both already exist. There is an inconsistency with hatrac right now (explained in this issue)where a file uploaded to hatrac with a filename with a whitespace in it, will have a returned filename with an underscore instead of a space.

The hatrac service does not rewrite spaces as underscores, so this
would have to be part of the uploader code in ermrestjs.
More importantly, hatrac deals in URLs not filenames, other than in
the content-disposition header, which can carry a client-side filename
hint.
All hatrac object names are URLs and URLs cannot have spaces in them.
So, no matter what, some rewrite should be expected here if inserting
user-generated content into the requested object name.
This rewrite must be performed by the client code before it tries to
talk to hatrac, or it would likely get HTTP errors.  Generally, I
would have expected normal URL encoding (e.g. %20 instead of a space)
rather than an underscore.

Looks like it's neither ermrestJS nor hatrac that's changing the filename. This morning @hongsudt mentioned that there are different rules that apply to encoding in headers than encoding in URLs.
Regardless, I spent some time trying to reproduce the error I reported on Friday above, and cannot reproduce it.


Add the value for XCN_CERT_DECIPHER_ONLY_KEY_USAGE

The .NET docs have a value for DecipherOnly key usage: 32768 (0x8000). It was missing here.

@lennybacon : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Makefile questions

Hi,
Thanks for sharing this, it's excellent. I have a couple questions though.
Is this https://github.com/ForeverSc/web-demuxer/blob/6a59c214390819af35c16b6598ac62297eb91c5d/Makefile#L17 supposed to be mpegts instead of mpegi? I don't think FFmpeg accepts mpegi as a demuxer config, and I presume you were targetting the MPEG-2 container, which is extension .m2ts?
Why does the full size wasm have decoders enabled
https://github.com/ForeverSc/web-demuxer/blob/6a59c214390819af35c16b6598ac62297eb91c5d/Makefile#L16
but the mini does not?
Thanks again!

 Thanks for finding the mistake. mpegi was a typo; I actually meant to write mpeg.
Regarding enabling decoders, for some formats such as FLV, if you only enable the demuxer without the decoders, you won’t be able to get certain information like width and height. I think it may not store some information in the container, so we need to use decoders. However, I haven’t fully investigated the exact reason yet, and there may be other good solutions.


unigine-valley: init at 1.0-1

Motivation for this change
Add Unigine Valley GPU benchmarking application. Provides one executable, valley, which starts the launcher (from which you can configure graphics settings before beginning the benchmark).
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Sandboxing tested by setting nix.useSandbox = true and running nix-shell -I nixpkgs=. -p unigine-valley --run valley in a local checkout of this branch.

I've just merged this in to master. Thank you for your contribution. I've made two changes:

Renamed your maintainer entry form kier to kierdavis to match your github user
Removed the comment about your email address from the package

Thank you!

Awesome, thanks!


Use TLS for 'router-container' AMQP port in Mqtt-Lwt

@ppatierno this time it's the 'other' router port that has route-container instead of normal (for the linkRoute to work)

@ppatierno @rgodfrey Sorry i pushed the wrong branch!

@rgodfrey @ppatierno https://github.com/EnMasseProject/enmasse/pull/169 contains the correct changes.


xdg-mime-apps: add module

This adds a module which generates $XDG_CONFIG_HOME/mimeapps.list.
Related to issue #96.

Jsut for info, I have sbmitted a patch a few years ago so that I can symlink $XDG_CONFIG_HOME/mimeapps.list (https://gitlab.freedesktop.org/xdg/xdg-utils/issues/7#note_92898). Having a HM module handle it mean xdg-mime default vlc.desktop video/mp4 won't work anymore ? not sure I feel about that.

@rycee Thank you for your review. I've amended the requested changes.
@teto xdg-mime seems to remove the symlink and write its own copy of the file, which is annoying :/

An alternative is to have this module run xdg-mime to set up the corresponding settings. I do think that it is best

Indeed I prefer managing everything through the module and not letting other applications randomly mess up file associations. Is there a way to make the symlink read-only to prevent xdg-mime and other programs from replacing it?

Thanks! Rebased to master in e347e932afb1fe3b3c545c4ac7a4d90cd2072fde.


Upgrade to cppcheck 2.8 and fix new issues found

module.cpp has suppression for redundantInitialization and cpu/target.cpp has it for constParameter. Do you think we can remove them as well ?

Do you think we can remove them as well ?

No we cannot.


Configurable metadata

I think that config'd metadata fields would be cool, essentially it would be a toml table in the config file with keys indicating the md keys and values indicating the types, with some special handling for "enum-like" values.
e.g. the current default config would look like (exact type strings may vary):
[metadata]
Name = "str"
Info = "str"
Experimentor = ["Kyle", "Emily", "Kelson", "Dan"]

this would mean that list is configurable on a per-table basis (including order) and that tables can decide on what md they want for that session.
Alternatively we could allow arbitrary metadata, but ui for that gets complex pretty quick and would like to encourage adding md so make it as easy as possible.

experimenter field partially addressed in #53


Work-in-progress sortable, paged results table.

This generally works but need to figure out how to make the table use the right amount of space inside the panel, so that the pagination buttons are always shown. The panel itself should not be scrollable.
Fixes #39.

Fixed the above CSS issue.


transaction_list KeyError for transferred claim

I'm gonna have to go back and check the exact steps to reproduce this one, but I'm getting the below error on RC8. I'm pretty sure it's a claim that originally had a channel on 1 PC and was transferred to this machine which has the error. I also tried re-signing it afterward on a new channel, but it may be erroring on the original tx.
ERROR: '107270d4064f090d905ac29f5b720381fbb1ed57'

Help for transaction_list method:

        List transactions belonging to wallet

        Usage:
            transaction_list [-t]

        Options:
            -t  : Include claim tip information

        Returns:
            (list) List of transactions, where is_tip is null by default,
             and set to a boolean if include_tip_info is true

            {
                "claim_info": (list) claim info if in txn [{"amount": (float) claim amount,
                                                            "claim_id": (str) claim id,
                                                            "claim_name": (str) claim name,
                                                            "nout": (int) nout}],
                "confirmations": (int) number of confirmations for the txn,
                "date": (str) date and time of txn,
                "fee": (float) txn fee,
                "support_info": (list) support info if in txn [{"amount": (float) support amount,
                                                                "claim_id": (str) claim id,
                                                                "claim_name": (str) claim name,
                                                                "is_tip": (null) default,
                                                                (bool) if include_tip_info is true,
                                                                "nout": (int) nout}],
                "timestamp": (int) timestamp,
                "txid": (str) txn id,
                "update_info": (list) update info if in txn [{"amount": (float) updated amount,
                                                              "claim_id": (str) claim id,
                                                              "claim_name": (str) claim name,
                                                              "nout": (int) nout}],
                "value": (float) value of txn
            }

Here's the traceback for the error you encountered:
Traceback (most recent call last):
  File "site-packages\twisted\web\server.py", line 190, in process

  File "site-packages\twisted\web\server.py", line 241, in render

  File "site-packages\lbrynet\daemon\auth\server.py", line 249, in render

  File "site-packages\lbrynet\daemon\auth\server.py", line 368, in _render

--- <exception caught here> ---
  File "site-packages\twisted\internet\defer.py", line 150, in maybeDeferred

  File "site-packages\lbrynet\daemon\Daemon.py", line 2198, in jsonrpc_transaction_list

  File "site-packages\lbrynet\core\Wallet.py", line 995, in get_history

  File "site-packages\lbrynet\core\Wallet.py", line 1477, in _get_history

  File "site-packages\lbrynet\core\Wallet.py", line 1288, in _run_cmd_as_defer_succeed

  File "site-packages\lbryum\commands.py", line 91, in func_wrapper

  File "site-packages\lbryum\commands.py", line 614, in tiphistory

  File "site-packages\lbryum\commands.py", line 91, in func_wrapper

  File "site-packages\lbryum\commands.py", line 594, in claimhistory

  File "site-packages\lbryum\commands.py", line 558, in get_info_dict

exceptions.KeyError: '107270d4064f090d905ac29f5b720381fbb1ed57'

Can confirm this was fixed by https://github.com/lbryio/lbryum/pull/170


Add deep-equality matcher for checking collection contents.

This matcher uses the same approach as toContain, except it uses deep-equality checking instead of object equality.
Closes #1369.
Summary
As discussed in #1369, a matcher is wanted that checks whether an equal value is present in a collection. The existing toContain matcher uses ===, a strict equality check. This new matcher uses the same equality check as toEqual does - hence the name.
Test plan
Run unit tests.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

Current coverage is 89.75% (diff: 66.66%)

Merging #1706 into master will decrease coverage by 0.18%

@@             master      #1706   diff @@
==========================================
  Files            31         31
  Lines          1143       1152     +9
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           1028       1034     +6
- Misses          115        118     +3
  Partials          0          0

Powered by Codecov. Last update 01e934d...ab5e398

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

nice work!


I want to access public IP camera which is not in my local network

Hi,
I have been able to discover and connect to the ONVIF cameras in my local network.
how can I access the camera which is placed in the remote location/another network/ global network/ public ONVIF camera

I'm not sure about "discovering" "public" Onvif sources, if its public, the URL should be available and not need to be discovered.
But I have a similar issue in that I run my cameras and IOT devices behind a "double NAT" setup.
My systems are on 192.168.2.xxx and my cameras and IOT devices are on 192.168.1.xxx
Accessing the 192.168.1.xxx devices works fine when I know the IP on the 192.168.1 subnet.    And onvif.startProbe() works great for cameras when they are on 192.168.2.xxx but when they are on 192.168.1.xxx it doesn't find them.
Is there an option or parameter to specify the subnet to be probed?

Same prob

I'm not sure about "discovering" "public" Onvif sources, if its public, the URL should be available and not need to be discovered.
But I have a similar issue in that I run my cameras and IOT devices behind a "double NAT" setup.
My systems are on 192.168.2.xxx and my cameras and IOT devices are on 192.168.1.xxx
Accessing the 192.168.1.xxx devices works fine when I know the IP on the 192.168.1 subnet. And onvif.startProbe() works great for cameras when they are on 192.168.2.xxx but when they are on 192.168.1.xxx it doesn't find them.
Is there an option or parameter to specify the subnet to be probed?

same here,
i have the public ip and port but got the error:
Error: Failed to initialize the device: Error: Network Error: socket hang up


Augment fourier

Added groupby support.
After reviewing the results, I figured out that in fact the first sine and cosine components are the same than previous implementation, but not for the other components.
If you think the computations are OK then we can replace the v1 by the v2.

If you have a link to the exact formula we are trying to implement it would help me

It's definitely closer. I have to spend some time investigating the results. The thing I'm looking for is when period = 7 on daily data, the peaks should happen every 7 days. I have a webinar tomorrow so I won't have time to investigate tonight. But it's very close. I saw that it looks like its every 10 days when periods = 7.

Great then 💯