[$250] The checkmark isn't displayed when back to access level page for copilot

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.64-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs
Action Performed:

Go to Security Page
Add copilot
Select an user
Select "Full" option
Click back button

Expected Result:
The checkmark should be displayed when back to access level page for the access level selected
Actual Result:
The checkmark isn't displayed when back to access level page , selected level is highlighted
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/dfcec016-4a00-42b3-b58a-2aa485b70613
https://github.com/user-attachments/assets/547e00ac-5766-41f9-b6b1-5a47135ec0a3
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021869142030241454978
Upwork Job ID:<PHONE_NUMBER>241454978
Last Price Increase: 2024-12-17

Issue OwnerCurrent Issue Owner: @eh2077

Proposal
Please re-state the problem that we are trying to solve in this issue.
The checkmark isn't displayed when back to access level page
What is the root cause of that problem?
Currently we are using the goBack function here to navigate when the user presses the back button
https://github.com/Expensify/App/blob/376f9f08755b0555cf3666c5a880542af57c7da1/src/pages/settings/Security/AddDelegate/ConfirmDelegatePage.tsx#L54
But before that route params in route were undefined  so route.params.role here will be undefined
https://github.com/Expensify/App/blob/376f9f08755b0555cf3666c5a880542af57c7da1/src/pages/settings/Security/AddDelegate/SelectDelegateRolePage.tsx#L28
What changes do you think we should make in order to solve the problem?

We should set value to role params before we navigate to confirm page
        Navigation.setParams({
            role: option.value,
        });
        Navigation.navigate(ROUTES.SETTINGS_DELEGATE_CONFIRM.getRoute(login, option.value));

https://github.com/Expensify/App/blob/376f9f08755b0555cf3666c5a880542af57c7da1/src/pages/settings/Security/AddDelegate/SelectDelegateRolePage.tsx#L59
What alternative solutions did you explore? (Optional)
Or we can use  navigate function instead of goBack function here

Proposal
Please re-state the problem that we are trying to solve in this issue.
The previously selected role isn't displayed as selected when navigating back to the Access Level page using the header back button from the Add Copilot page.
What is the root cause of that problem?
On the SelectDelegateRolePage, we rely on the role parameter from the route passed from the previous screen using this condition:
isSelected: role === route.params.role.
However, when navigating back from the Add Copilot page using the header back button, the checkmark for the previously selected user isn’t displayed because the parameter isn’t passed in this case. On the other hand, if the "Access Level" item on the Add Copilot page is clicked, the pre-selection is displayed since the parameter is passed during navigation.
What changes do you think we should make in order to solve the problem?
Instead of relying solely on the route.params.role, we can manage the selection locally using useState. For example:

const [currentRole, setCurrentRole] = useState(route.params.role);

When generating roleOptions, compare the role with currentRole to determine the value of isSelected.
On row selection (onSelectRow), update the local state (setCurrentRole), and then invoke the existing Navigation.navigate method.
What alternative solutions did you explore? (Optional)
Replace Navigation.goBack() with explicit navigation that ensures the necessary parameters are passed. For example:
Navigation.navigate(
  ROUTES.SETTINGS_DELEGATE_ROLE.getRoute(option?.login ?? '')
);

https://github.com/Expensify/App/blob/002961484c27ddd8879c32c6bcbdc3771c33ef73/src/pages/settings/Security/AddDelegate/AddDelegatePage.tsx#L134

@ eh2077 could you please look at the proposals when you get a chance?

I think we shouldn't show the selected icon in a new delegate flow (when we are going to select the role for the first time), just like when you select the delegate user, there is no selected icon.

I also agreed with @bernhardoj that it makes more sense not to show the selected icon and to keep it the same as the user selection list.

Go to Security Page
Add copilot
Select an user
Select "Full" option
Click back button

After step 5, it’s also not necessary to highlight the option.

https://github.com/user-attachments/assets/7c8ee6f3-46fc-492e-bc97-6bb626a504e8
@anmurali Can you help clarify the expected behaviour?

https://github.com/user-attachments/assets/710082a3-5965-4e00-91c5-de5a32550e85
@eh2077 @anmurali As far as I can see, most of the selections in the App will save the selection when we come back.

@nkdengineer Thank you for your comment! I agree that it makes sense to retain the state when navigating back. Most use cases of the app involve saving the input state when moving back and forth in the flow.


Fix bug in user authentication season

Rabbit season

Flaky Test
Failure Summary
Logs

[chromium] should display user profile information correctly.
The user profile information was not displayed correctly, as the element 'User ID: eli3cruz' was not found.
Logs ↗

[chromium] should login with credentials correctly correctly.
The login request to the server failed with a 404 Not Found error.
Logs ↗

[chromium] should return list of users correctly.
The API call to get a list of users failed with a 404 Not Found error.
Logs ↗

[chromium] should display error message for invalid login correctly.
The expected HTTP status code 401 was not received, instead a function was returned.
Logs ↗

View Full Report ↗ ⋅ Docs

Flaky Test
Failure Summary
Logs

[chromium] should display user profile information correctly.
The user profile information was not displayed correctly, as the element 'User ID: eli3cruz' was not found.
Logs ↗

[chromium] should login with credentials correctly correctly.
The login request to the server failed with a 404 Not Found error.
Logs ↗

[chromium] should return list of users correctly.
The API call to get a list of users failed with a 404 Not Found error.
Logs ↗

[chromium] should display error message for invalid login correctly.
The expected HTTP status code 401 was not received, instead a function was returned.
Logs ↗

View Full Report ↗ ⋅ Docs


Fix TVariables

Status

READY/WIP
Description
Based on https://github.com/anymaniax/orval/pull/931, addresses https://github.com/anymaniax/orval/issues/857, most likely in a wrong way but it works for me, so just documenting it here for the future
Todos

[ ] Tests
[ ] Documentation
[ ] Changelog Entry (unreleased)

Steps to Test or Reproduce
Not sure how to reproduce, but the generated code is mentioned in https://github.com/anymaniax/orval/issues/857

Hello @Maxim-Mazurok, why removing TVariables? Did you test with the other framework if still work well? And #931 is not useful anymore?

I think that #931 is more useful than this, I just had to do these fixes so we can apply patches and move forward, didn't have time to do PRs properly, sorry about that. I think only this commit from this PR is relevant to the issue: 8390c74 (#932)
I don't know why TVariables exists in the first place, what's the use-case there, we've been using this patch to address #857 for a while and haven't run into issues. I haven't tried with other frameworks.

@Maxim-Mazurok should this be closed in favor of your new PR: https://github.com/anymaniax/orval/pull/1085

@Maxim-Mazurok should this be closed in favor of your new PR: #1085

Ah, yes, I forgot that this PR exists :)


Embedding of link to UC Berkley article.

Embedded link on line 9 under "many people are uninsured" to a UC Berkley article detailing how America's health insurance gap could speed the spread of coronavirus.

Looks like content of this section has changed considerably. Do we still want to integrate the link or shall we drop this PR?

Looks like content of this section has changed considerably. Do we still want to integrate the link or shall we drop this PR?

If it looks like content has already changed, then no need to integrate link anymore!


Remove seemingly unused patch

Does anyone recognize this code, and know why/if it was needed?

cc/ @grosser @osheroff

how does it "seem unused"? debuggers show no exercise in the test suite?

git blame to the rescue ?

I added a puts to lines 35 and 37 (each branch of the condition) and it seems that all specs go though the branch that does nothing.

Hmm, could it be because ActiveRecordShards::ConnectionSpecification is not defined when this code is loaded?

git blame to the rescue ?

9cb3918d94e8eb3c2d6ca965873a8d57d2329b14

@osheroff and @grosser, could you please re-review this one?

I have no idea ... remove and deploy to master and see if shard switching works ...

So the thing here is that this is patching ActiveRecord::Base.establish_connection, which should really only ever be called externally.  I'm technically fine removing this if we find it's genuinely unused, but vetting that is tougher than just sprinkling a puts around the specs; all  that's proving is the code is untested.


Add command to create Azure VM

In the Linux tutorial, there is an azure CLI command to create a Linux VM.  It seems like an instruction to create a VM should be added here as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 64575e7c-664c-4d6b-a440-24c91e93def5
Version Independent ID: 17d9481c-a75b-bbfd-1f9a-76fc3d6b2930
Content: Quickstart Azure IoT Edge + Windows
Content Source: articles/iot-edge/quickstart.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

@theangellmethod Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.

Hi @theangellmethod I've been thinking about incorporating Azure VM steps into the Windows quickstart as well. I'm still considering the best way to do it. I'll keep you posted as I make progress.

A long time coming, but we recently updated the Windows quickstart to direct users to create an Azure VM for their test device.
@sergaz-msft #please-close this issue


Port to TypeScript

[!NOTE]
These changes depend on my previously opened PRs (#49, #50, #51, #52). Since it looks like this library is no longer maintained, I'll be maintaining a fork with all my improvements at chordbook/vexchords.

This ports the library to TypeScript with as few other changes as possible.
Fixes #43

Thanks for all these changes, much appreciated. It's been a long time since this repo's been updated, and I'll merged your changes in.

If you're interested, I can add you as a collaborator to this repo, so you can merge them in directly. LMK.


update to how QoS will work

@amoschoomy @Xiaohan0416 @OHM314159
Can you all try when maintenance is finished to see if this works?

to try this version, do:
pip install git+https://www.github.com/tuonglab/ktbunya@new-qos-update
The version should say 0.8.0


Update README.md

fix reference from todist-card.js to powertodist-card.js

Sorry, I thought I would receive email notifications of everything here, but I still had to make that setting. So I only saw your PR today!


Flutter Windows only partially paint window

Flutter app on Windows only partially paint a portion of app that is visible on display. This will make the app looks glitched when dragged back to center. It will paint again only when there is any rebuild.
On macOS the app is painting whole window.
Steps to Reproduce

Run the code sample
Drag window to right side of screen, partially hide half of it outside the display
Change Tab
Drag window to center again
See result

Expected results: App should paint whole window
Actual results: Only portion on visible display is painted
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const App());
}

class App extends StatelessWidget {
  const App({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      routes: {
        '/': (context) => const HomeScreen(),
      },
    );
  }
}

class HomeScreen extends StatefulWidget {
  const HomeScreen({super.key});

  @override
  State<HomeScreen> createState() => _HomeScreenState();
}

class _HomeScreenState extends State<HomeScreen> {
  int _index = 0;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Row(
        crossAxisAlignment: CrossAxisAlignment.stretch,
        children: [
          NavigationRail(
            labelType: NavigationRailLabelType.all,
            selectedIndex: _index,
            onDestinationSelected: (value) {
              setState(() {
                _index = value;
              });
            },
            destinations: const [
              NavigationRailDestination(
                icon: Icon(Icons.home),
                label: Text('Home'),
              ),
              NavigationRailDestination(
                icon: Icon(Icons.settings),
                label: Text('Settings'),
              ),
            ],
          ),
          Expanded(
            child: Builder(
              builder: (context) {
                switch (_index) {
                  case 0:
                    return Column(
                      crossAxisAlignment: CrossAxisAlignment.stretch,
                      children: const [
                        Expanded(
                          child: ColoredBox(color: Colors.blue),
                        ),
                        Expanded(
                          child: ColoredBox(color: Colors.green),
                        ),
                      ],
                    );

                  case 1:
                    return Column(
                      crossAxisAlignment: CrossAxisAlignment.stretch,
                      children: const [
                        Expanded(
                          child: ColoredBox(color: Colors.red),
                        ),
                        Expanded(
                          child: ColoredBox(color: Colors.orange),
                        ),
                      ],
                    );
                }

                return const Placeholder();
              },
            ),
          ),
        ],
      ),
    );
  }
}

Logs
[√] Flutter (Channel stable, 3.3.3, on Microsoft Windows [Version 10.0.22621.525], locale en-ID)
    • Flutter version 3.3.3 on channel stable at C:\GitHub\flutter\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18a827f393 (6 days ago), 2022-09-28 10:03:14 -0700
    • Engine revision 5c984c26eb
    • Dart version 2.18.2
    • DevTools version 2.15.0

Checking Android licenses is taking an unexpectedly long time...[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at C:\Users\andre\AppData\Local\Android\sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.3.5)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.3.32922.545
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2021.3)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[√] VS Code (version 1.71.2)
    • VS Code at C:\Users\andre\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.50.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.22621.525]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 106.0.5249.91
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 105.0.1343.53

[√] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

https://user-images.githubusercontent.com/1574722/193974835-1602da48-d181-4c27-a93b-dde20edc8e80.mp4

Hello @SuperPenguin. I can reproduce this issue on stable but not on master indicating that this is already fixed. Closing due to this reason. If you disagree, please comment and I can reopen the issue. Thank you.


Cannot get a RootWindow on startup.

Hey:)
when I use ue.get_editor_window() on startup in the ue_site.py script, I get this error: Exception: no RootWindow found
I think Python is faster then the editor, which may be loaded completely.
The same thing happens to ue.get_editor_world()
Is there a way to wait for the editor?
Thank you in advance for your help and time!

Hi, use unreal_engine.on_main_frame_creation_finished(callable) to postpone the call of 'callable' after the editor has finished its initialization

Thanks! Makes the code more readable. I don't need the arguments, but for my personal interest, what is the second argument that will be put into my function? (I assume the first is deltatime again, right?)


merge package from arlac77/npm-package-template

package.json

chore(engines<EMAIL_ADDRESS>

Codecov Report

Merging #512 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #512   +/-   ##
======================================
  Coverage    51.7%   51.7%
======================================
  Files           3       3
  Lines         147     147
======================================
  Hits           76      76
  Misses         71      71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2b461...8875237. Read the comment docs.

Coverage remained the same at 45.366% when pulling<PHONE_NUMBER>60529a9ac80ce987b7c6122c4885f4 on template-sync-1 into 8b2b4612c24fd8b3668e7c820b331aa612ff7923 on master.

:tada: This PR is included in version 5.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Training model gives "RuntimeError: GlooDeviceFactory::makeUVDevice(): interface or hostname can't be empty"

[W C:\actions-runner\_work\pytorch\pytorch\builder\windows\pytorch\torch\csrc\distributed\c10d\socket.cpp:601] [c10d] The client socket has failed to connect to []:39507 (system error: 10049).

[W C:\actions-runner\_work\pytorch\pytorch\builder\windows\pytorch\torch\csrc\distributed\c10d\socket.cpp:601] [c10d] The client socket has failed to connect to []:39507 (system error: 10049).

Process Process-1:
Traceback (most recent call last):
  File "multiprocessing\process.py", line 315, in _bootstrap
  File "multiprocessing\process.py", line 108, in run
  File "C:\RVC\RVC-beta0717\train_nsf_sim_cache_sid_load_pretrain.py", line 100, in run
    dist.init_process_group(
  File "C:\RVC\RVC-beta0717\runtime\lib\site-packages\torch\distributed\distributed_c10d.py", line 895, in init_process_group
    default_pg = _new_process_group_helper(
  File "C:\RVC\RVC-beta0717\runtime\lib\site-packages\torch\distributed\distributed_c10d.py", line 994, in _new_process_group_helper
    backend_class = ProcessGroupGloo(backend_prefix_store, group_rank, group_size, timeout=timeout)

RuntimeError: GlooDeviceFactory::makeUVDevice(): interface or hostname can't be empty

Hello, I'm getting this error when trying to create a new model, I already created a few models a while back so my guess is that this has to do with some update of some dependency, or something that changed in my system.

please don't use beta release, there are new one here :
For Nvidia GPU users:
https://huggingface.co/lj1995/VoiceConversionWebUI/resolve/main/RVC1006Nvidia.7z
For AMD/Intel GPU users:
https://huggingface.co/lj1995/VoiceConversionWebUI/resolve/main/RVC1006AMD_Intel.7z
for start UI : go-web.bat

please don't use beta release, there are new one here :
For Nvidia GPU users:
https://huggingface.co/lj1995/VoiceConversionWebUI/resolve/main/RVC1006Nvidia.7z
For AMD/Intel GPU users:
https://huggingface.co/lj1995/VoiceConversionWebUI/resolve/main/RVC1006AMD_Intel.7z
for start UI : go-web.bat

I'm getting it on even on the stable release, but I figured I'd try the latest one to see if it had any sort of fix (even if it's probably just an issue on my end).

For whatever reason my PC's hostname was blank, I thought it was set and that this was just a random error, now I can train properly.


deploy to IBM Cloud fails with 'Could not bind to service wdui-discovery-service'

Issue found by an external customer and reproduced in DAL
steps to reproduce:

go to https://github.com/IBM/watson-discovery-ui
click the deploy to IBM Cloud button
toolchain creation: select my org and space
create the toolchain
go to the pipeline overview page

expected: deploy completes OK
observed: deploy failed with:
Done uploading
OK
Binding service wdui-discovery-service to app watson-discovery-ui-20190610115059701 in org<EMAIL_ADDRESS>/ space dev as<EMAIL_ADDRESS>FAILED
Could not bind to service wdui-discovery-service
Error: Server error, status code: 409, error code: 60016, message: An operation for service instance wdui-discovery-service is in progress.

Finished: FAILED

please consider this one as a blocker as it prevents from deploying the app

bad customer experience

Thanks for the help @ejodet

@sanjeevghimire - thanks for the quick reaction.
Please let me know when I can test if the problem is fixed in prod
(so I can update our customer)
Thanks

@ejodet can you try now? Make sure you clean up all the services and app before you re-deploy.

Keenly waiting for @ejodet result

@sanjeevghimire - verified / fixed
The app deployed as expected

Thanks for the quick reaction!

Hi, I dont know what I am doing wrongly. Still getting same error.
Binding service wdui-discovery-service to app watson-discovery-ui-20190612071544377 in org<EMAIL_ADDRESS>/ space dev as<EMAIL_ADDRESS>FAILED
Could not bind to service wdui-discovery-service
Error: Server error, status code: 409, error code: 60016, message: An operation for service instance wdui-discovery-service is in progress.
Finished: FAILED
even changed account to start with no services

@edzai - please retry from zero.

delete the toolchain that you were previously using
go back to https://github.com/IBM/watson-discovery-ui
click the deploy to IBM Cloud button
verify that the app deployed OK

Ping me on Slack if still stuck.
Thanks

@sanjeevghimire - discussed with @edzai on Slack.
It turns out that even re-starting from scratch,  @edzai is still unable to have the app deployed after toolchain creation.
It looks like there is a resource discover-ui that is stuck in "deletion in progress"

@edzai tried to manually delete it but the UI claims:
Error

An error occurred performing the operation. Try again later.

Description:

An operation for service instance wdui-discovery-service is in progress. (CF-AsyncServiceInstanceOperationInProgress - 60016)

So, possibly, the initial issue was fixed - since I was able to have a successful deploy
However, @edzai is still stuck and unable to have the app deployed, up and running.
May you please either:

re-open this issue and work with @edzai  to collect additional information, let him know how to delete the wdui-discovery-service
extract a new issue from this one so as to delete the wdui-discovery-service for a successful deploy

Also, please note that the "wdui-discovery-service is in progress" issue is often see during start up. Try re-deploying the app.
Please file a new issue if you have further problems. Thanks.

@edzai did re-try to deploy? Did next deploys succeed?

@sanjeevghimire - we determined why deploy was still failing for @edzai
The wd-ui-discovery service created during the first attempt
could not be deleted (it has been pending deletion for 2 days)
@edzai  a new account then tried again.
Once service was provisioned, deploy was successful
In case someone faces the same issue, here are the step to overcome the An operation for service instance wdui-discovery-service is in progress problem:
1 - go to cloud.ibm.com and expand CF Services
2 - delete all instances of the wdui-discovery-service
3 - try to re-deploy: should fail because wdui-discovery-service is pending creation
4 - on cloud.ibm.com, wait for the service to be "provisioned"
5 - try to re-deploy: should complete OK


[SPARK-46132][CORE] Support key password for JKS keys for RPC SSL

What changes were proposed in this pull request?
Add support for a separate key password in addition to the key store password for JKS keys. This is needed for keys which may have a key password in addition to a key store password. We already had this support for the UI SSL support, so for compatibility we should have it here.
This wasn't done earlier as I wasn't sure how to implement it but the discussion in https://github.com/apache/spark/pull/43998#discussion_r1406993411 suggested the right way.
Why are the changes needed?
These are needed to support users who may have such keys configured.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added some unit tests
build/sbt
> project network-common
> testOnly

Was this patch authored or co-authored using generative AI tooling?
No

cc: @mridulm

hm, CI had worked fine on my local branch before I submitted this. Will submit an empty commit to retrigger CI

Merged to master.
Thanks for adding this @hasnain-db !


what's next?

installed everything according to the instructions how to get to the web page?

Hello, the documentation is incomplete and will soon be available on the website.
The first thing to do is to point a DNS record to the ip of the server then you can follow the steps in the README if you enter everything correctly you could access from the domain or subdomain pointed to the ip.

Good evening, I did everything according to the instructions, when connecting to localhost, the site gives an error ERR_SSL_PROTOCOL_ERROR

And do you have to use letsencrypt?

And do you have to use letsencrypt?

Hello, the documentation is now available here and a new update.


Create useContractEvents hook

Hey, do you think it is a good idea to add Wagmi's useContractEvent hook ? https://wagmi.sh/react/hooks/useContractEvent
I'd live to use that for my project so I guess it could be the case for others as well !
As a junior dev I'm not sure how difficult it is to make the necessary changes to adapt this file useContractEvent but I'd love to give it a try !

Yes, I think that would be a great idea! The main issue is that starknet.js provider doesn't support it because it defaults to the gateway provider. Until the ecosystem moves over to the json rpc provider I don't think it's possible to add this in a way that integrates with the rest of the library.
To go more in detail, the default provider is replaced with the wallet's provider once the user connects (so network changes with the user's wallet), so we cannot rely on the json rpc at all.
For your use case, you can manually instantiate a RpcProvider and use that in your code.
Keeping this issue open so in the future we can revisit this decision.

Alchemy does have an events API and it seems fairly similar to TokenFlow? Could they be harmonized/supported?

For this to happen we need wallets to switch to the rpc provider. Once that happens, we can implement this issue.

Close in favour of #465


.Net: Break the relationship between SKFunctions and the kernel

Currently semantic functions depend on the Kernel instance to get access to the IAIService instance to use

Task is complete, you can now create functions without a Kernel instance.


TokenMgrError: Lexical error

Search first

[X] I searched and no similar issues were found

Description
When the sql statement field value contains Roman numerals II, an exception is thrown 【2023-04-10 11:17:30.424 [main] WARN  org.springframework.boot.web.servlet.context.AnnotationConfigServletWebServerApplicationContext | 559 | Exception encountered during context initialization - cancelling refresh attempt: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'liquibase' defined in class path resource [org/springframework/boot/autoconfigure/liquibase/LiquibaseAutoConfiguration$LiquibaseConfiguration.class]: Invocation of init method failed; nested exception is liquibase.util.grammar.TokenMgrError: Lexical error at line 8648, column 123.  Encountered: "\u2161" (8545), after : ""】
Steps To Reproduce
INSERT INTO std_standard_organization VALUES (1, '001', 'Ⅱ', 'Ⅱ', 1, 9, b'1', '002', 99,<PHONE_NUMBER>000, NULL, '/1/308/315/', b'0',<PHONE_NUMBER>513,<PHONE_NUMBER>513, 0);
Expected/Desired Behavior
SQL statement field value can contain Roman numerals II
Liquibase Version
No response
Database Vendor & Version
No response
Liquibase Integration
No response
Liquibase Extensions
No response
OS and/or Infrastructure Type/Provider
No response
Additional Context
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR (Thank you!)

@nvoxland I included the necessary Unicode ranges for both roman numerals and small roman numerals according to their definition in the "Number Forms" Unicode block.
Probably the issue deserves the creation of some tests. Do you agree? How these tests should be performed? Do I need to define a new changelog with the appropriate offending insert statement for instance?


ensure numbers where we expected booleans parse correctly.

Boolean.parseBoolean expects the literal "true", which doesn't match the number 1.
The fix is to parse "1" as truthy, and all other values as falsy, like Boolean.parseBoolean() does.
fixes PaperMC/Velocity#1286
I'm assuming its meant to accept "1" as valid, seeing as it was specifically peeking for Numbers.
In velocity at least, "1" in json is emitted by the nbt component converter, from bytes

Oh, looks like it might be intentional, if there is a test for it.
does that just make this velocities problem?

I think this is a format change from since component serialization started using Codecs? so it's a case of adventure's tests being outdated against the newly changed spec.

I'm still not 100% sure if this should change, as looking at the codecs etc, the vanilla jsonOps only parses / emits standard json bools, so this is more permissive than how minecraft behaves with json.
(only nbt ops parses bools using bytes i think)


UI: Netty version clash

Issue Description
deeplearning4j-ui uses vert.x, which in turn uses netty.
Other modules, like datavec-hadoop or datavec-arrow also have transient dependencies on netty - often in very different versions.
This results in problems that show themselves as NoSuchMethodError or ClassNotFoundException.
The devious thing about it, is that it depends on the order of dependencies in the pom.xml file. If the incompatible version is brought in by something first, then the dl4j ui doesn't start and if deeplearning4j-ui is declared first, then libraries depending on the old version will have issues when they are used.
Version Information

Deeplearning4j version: 1.0.0-beta6

Additional Information
To reproduce the bad behavior simply move the deeplearning4j-ui dependency in the examples (https://github.com/eclipse/deeplearning4j-examples/blob/master/dl4j-examples/pom.xml#L109-L114) after the hadoop-common dependency.
In the example case, it breaks even more havoc, as a few things suddenly aren't compile-able any more, as even more dependency version clashes are triggered.
Workaround
If anyone finds this while trying to get things to work. If you don't need the features of datavec-hadoop or datavec-arrow that depend on netty, then make sure to declare deeplearning4j-ui first.
If you have the same issue with any other library, you can find out what it is that is resulting in the version clash by running mvn dependency:tree and look what depends on netty. Then you can either exclude the transitive dependency, or you can use the <dependencyManagement> section to set a specific version (for more information about doing that see https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html).
Caveat: This only paints over the problem. If the other library can't work with the API of a different version, then you will run into problems too.

@treo  I think deeplearning4j-hadoop can be eliminated? I've found in konduit-serving which uses the same dependency tree, that all you have to do is do dependencyManagement on the netty versions. That might be enough?

The problem with forcing a dependency here, is that just because this fixes the UI, it doesn't fix the underlying problem that two different versions of netty are required. In the Hadoop case it is 3.8, so forcing 4.x to be used instead is going to just push the problem to a different part of the application.

Another more permanent solution to this kind of issue could be to adopt OSGi...


[redshift] Alarm for number of connections to Redshift cluster

Feature scope
AWS/Redshift
Describe your suggested feature
Alarm for maximum number of connections allowed to redshift cluster for connections widget created by .monitorRedshiftCluster. https://github.com/cdklabs/cdk-monitoring-constructs/blob/main/lib/monitoring/aws-redshift/RedshiftClusterMonitoring.ts#L81

https://github.com/cdklabs/cdk-monitoring-constructs/pull/251


add styling for figcaption

Image captions in Figma have a specific font size and colour that do not currently fit in with the typescale system in code.
We need to either create a styled component specifically for captions or add support for this styling in the css variables system.

Is needed for what we defined as the initial News article, or should we add this to the scope of News article  version 2? @SvSven

We can just add it to the scope for v2 since we need to wait for the typography scaling and variables.
This isn't a major issue either, so should be fine.

We still miss styles for the heroImage


Document property "maven"

Jaco, I saw your Teams messages describing what I did wrong in this pull request. We decided that using Maven can best be documented when it becomes official (not a feature toggle). I am closing this pull request.


Enhance threading with multiprocess

The current solution that uses a stop event before plotting is suboptimal, as there may be a lot of threads in the background computing results we do not use.
Multiprocessing should be more relevant for my application with its ability to terminate. However, I encounter pickling errors.
Maybe I should spend more time on it.

Not needed since panel is now used


feat: showing models on temp yaml file

let's gooo!

Guys, I added this eye button to show model inside a temp file!
temp yaml file:


Interest in an Element class

I'd like to expand the available functionality in this library by an Element class that averages over isotopes so that I can use this library for chemical molecules, where atoms are most commonly represented as 'averages' over their isotopes.
This library already stores a lot of chemically relevant properties, such as electron affinity, ionization energies, electronegativities, etc. which are dependent on the atomic number only. I am aware I could write my own abstraction layer over the available data, but I would prefer to expand the scope of this library a little, so that the data is centralized and accessible for others.
Are you open to receiving a PR adding an Element class implementing some or all of Atom?
Open questions

I haven't looked too closely yet if Element can implement the full interface of Atom. I've noticed that some functions, e.g. Nuclide::ionization_energies will return f64::NAN instead of None for unavailable data. Is that intentional? Is that an escape hatch I could use?
The docs explicitly state abundancies are purposely out of scope, but the mass of an element is the abundance-weighted average of its isotopes. Should I avoid adding isotope abundancies to the Element interface?
Is there interest in strongly typing units? Having Atom implement mass_deficit/_kg/_j,_ev and similar for binding energy, electron affinity, ionization energies, etc. could be made less redundant, e.g. with the crate uom, which would also remove conversion constants from this library. I think this could be nice to have, but would probably be a different PR.

Implementing Atom for an Element type doesn't really make sense as much of the methods are only applicable to atoms with a discrete number of nucleons. An alternative would be to create a base Element trait that implements elemental methods, and then have Atom as a supertrait.
Based on this issue and the discussion of this library at Terrapower, I am considering a sort of ConstructedNuclide structure, that allows user defined values to override the standard look-up values or even create new nuclides (currently the create method predicts the mass and binding energy given certain nucleons, so this would be moved from the Nuclide struct to ConstructedNuclide)
An example below
struct CNuclide{
// Atomic Mass
 am: Option<f64>,
// Proton
 p: Option<u64>,
// Neutron
 n: Option<u64>,
// many others
}

impl CNuclide{
// initialise all with None (except probably proton count) which means it refers to Nuclide's lookup tables for each None value
  fn new() -> Self{
    Self{am: None, p: None,n: None}
 }
  // Switch am to a Some value
  fn set_amu(&mut self,x: f64);
  // Atom trait method
fn am(&self) -> f64{
   match self.am{
     Some(x) => x,
    None => // look-up am for the proton neutron combination
   }
}

I think this would alleviate any need for averaging and isotope abundancies, since one could define a typical hydrogen nuclide like this.
const HYDROGEN : CNuclide = CNuclide{am: Some(1.00794), p: Some(1),n: Some(0)};

One could possibly also use floating-point averages of nucleons although I'm not sure of the utility of that.

I would like some clarity on what specifically the Element class would provide. Is isotope abundancies simply to calculate the atomic mass averages, are averages of nuclear decay and nucleon count needed as well? Would the previously described Constructed Nuclide, address all the interests?

Is isotope abundancies simply to calculate the atomic mass averages, are averages of nuclear decay and nucleon count needed as well?

A) Generally, I would think an Element struct would ideally look-up its mass instead of calculating it from an abundance-weighted average of it's isotopes. The manner in which it's implemented is not important to me, but to avoid data duplication, it could certainly be implemented using const functions, using new abundance information and the already available isotope masses.
B) I would like to be able to represent atoms in chemical molecules either as a particular isotope or as an 'average' over the natural abundancies, an element, i.e. specifically as:
enum Atom {
    Element(nuclide::Element),
    Isotope(nuclide::Isotope)
}

Some interface that abstracts over shared properties of the two concepts in this library would therefore be very useful for me. While the decay of these 'average' atoms over time could in principle be interesting in some rare cases, the chemistry I'm familiar with is only concerned with nuclear decay in the particular cases where molecules are prepared with a specific isotope in a specific place. So I would say that although nuclear decay for elements could be considered well-defined since all you would have to do is separate the element into its isotope fractions by abundance and then consider nuclear decay separately for all of them, I think until someone else comes along clamoring for it, we could judge it out-of-scope, either not implementing a hypothetical Decay trait or by returning Nones from partial functions of a broader interface.

Would the previously described Constructed Nuclide, address all the interests?

Your proposed ConstructedNuclide struct strikes me as odd: A struct full of Options seems to me more of an indication that the wrong abstraction has been chosen to unify multiple slightly different things into the same interface. From what I can tell, the library currently uses tabular information of a particular kind such as electronegativity where some indexing identifier of an isotope or element can be used to look it up, instead of listing all isotopes and elements, and gathering the available data into its member Options. I would think keeping the current approach is preferable to a whole lot of brute leg work.
Generally, I would argue it is preferable to keep structs as close to the thing they're modeling as possible and then describe things these structs have in common in traits. Elements, isotopes and isomers are not the same 'things', but all of them have a fair few properties in common, and some of them can decay. I'm not particularly familiar with nuclear physics, but from what I understand I would think the 'is' relationships go: an isomer is-an excited-state isotope, i.e. it can be modeled as a product-type of an isotope and its state, and an element is-an average of isotopes, i.e. it can be modeled as an abundance weighted average of isotopes.
That would suggest to me that at the bare minimum, all three types could implement the non-decay-related property functions as a shared trait, and isomers and isotopes additionally share decay. Elements could have the additional functionality of breaking into isotope fractions by natural abundance, and isomers their excited-state related properties.
Meaning, possibly some variant of:
struct Isotope {
    protons: u8,
    neutrons: u16
}

struct Isomer {
    isotope: Isotope,
    level: u8
}

struct Element {
    protons: u8,
    neutron_abundancies: Vec<(u16, f64)>
}

with traits e.g. Nuclide (Isotope, Isomer, and Element), and Decay (Isotope and Isomer), while Isomers state-decay related functions are not encompassed in any shared interface.
I'm sure I've overlooked something. What do you think?

Conversely, if all of these concepts are to fit into one big box, I suppose it would be
struct Nuclide {
    protons: u8,
    neutrons: u16,
    state: u8
}

and I could introduce functionality that operates on fractional compositions of Nuclides (i.e. mass, electronegativities, etc.), whereby Elements are only the particular case where that fractional composition is the natural abundancies.

I would accept a pull request implementing the Element struct as described with the fractional compositions. The purpose of the library is to provide something more versatile than just referencing hardcoded values, by having fractional compositions you could calculate the average values for individual samples.
Note that Nuclide largely does follow the schematic you presented, the difference is that the index value from neutrons and protons is calculated at creation instead of storing them and then calculating the index each time you call datapoints.
In the case of the proposed Element struct, you could still use the proposed fields, however you would have to initialise each isotope of the element that exists in the sample using Nuclide::from_nucleons(proton,neutron) and then calculate the values from that.
Nuclide (respository not the crates publication) has since been updated with a ChemElement trait that splits the methods into elemental data and isotopes.

Amazing, that sets good bounds on what I will implement. Thank you for preparing the ground so well, I was expecting to do most of what you just added to the repository myself.
Unfortunately, I will be away traveling without a laptop for some time, so my contribution to this will be a month or so coming, just so you're aware.


Set up test framework with Phantom.js

Get Phantom.js going and see if it can run search-index.
http://phantomjs.org/

Seems Travis.ci comes with built in Phantom.js support.


Separating artifacts between tasks from other pipelineruns

Feature request
Artifacts should be separated between different pipelineruns, should be accessible only for that one job/pipelinerun to make possibility to start pipeline multiple times in parallel. Right now when you are using workspaces or results and you start pipeline few times, workspaces and results will be overwritten by second running pipeline before first will finish.
Use case
If you create checkout task for which one parameter is branch name and after checkout there are building and kaniko steps which still need access to source code. When second developer will start another pipeline with different branch name, source code will be overwritten during building task.
Same is for results. Build task will save result with image name for Kaniko and deployment task. When build step from second task is executing it can overwrite results for Kaniko or deployment task from first pipelinerun

@holoGDM are you using the same workspace PVC volume for all PipelineRuns? When using the volumeClaimTemplate as workspace volume source, a new PVC volume is created for each PipelineRun so that the runs does not interfere with eachother.

@jlpettersson thanks for help i didnt know about such posibility and i will test it. This is solving problem with sourcecode workspace but how to handle results, to not overwritte them during pipeline execution?

@jlpettersson  i tried volumeclaimTemplate and added such thing to my pipelinerun:
workspaces:
    - name: `tkn-build-space` # must match workspace name in Task
      volumeClaimTemplate:
        spec:
          accessModes:
            - ReadWriteOnce # access mode may affect how you can use this volume in parallel tasks
          storageClassName: rook-ceph-block
          resources:
            requests:
              storage: 2Gi

but when im starting my pipeline its only executing first task and hanging on second one with:
Events:
  Type     Reason              Age        From                     Message
  ----     ------              ----       ----                     -------
  Normal   Scheduled           <unknown>  default-scheduler        Successfully assigned tekton-pipelines/kubernetes-cicd-run-1djchd-kaniko-frontend-8w2bq-pod-zsc4p to card-node016
  Warning  FailedAttachVolume  13m        attachdetach-controller  Multi-Attach error for volume "pvc-c4ebfa7c-9d44-4056-b9d1-1ea54c2debb4" Volume is already used by pod(s) affinity-assistant-57cf68a947-0
  Warning  FailedMount         11m        kubelet, card-node016    Unable to attach or mount volumes: unmounted volumes=[ws-qcc7t], unattached volumes=[tekton-internal-results tekton-creds-init-home-dq88k tekton-internal-workspace tekton-internal-scripts tekton-internal-secret-volume-bb-ssh-key-krpwt ws-qcc7t tekton-internal-home tekton-internal-secret-volume-gitlab-user-pass-ftq7s tekton-internal-tools tekton-creds-init-home-hlblv ws-vx927 tekton-internal-secret-volume-harbor-user-pass-c2lvv tekton-internal-downward cicd-bot-token-sqjdh tekton-internal-secret-volume-bb-user-pass-lxbmq]: timed out waiting for the condition
  Warning  FailedMount         8m59s      kubelet, card-node016    Unable to attach or mount volumes: unmounted volumes=[ws-qcc7t], unattached volumes=[tekton-internal-workspace tekton-creds-init-home-dq88k ws-qcc7t tekton-creds-init-home-hlblv tekton-internal-secret-volume-harbor-user-pass-c2lvv tekton-internal-scripts tekton-internal-secret-volume-bb-user-pass-lxbmq tekton-internal-secret-volume-bb-ssh-key-krpwt cicd-bot-token-sqjdh tekton-internal-home tekton-internal-results tekton-internal-tools tekton-internal-downward tekton-internal-secret-volume-gitlab-user-pass-ftq7s ws-vx927]: timed out waiting for the condition
  Warning  FailedMount         6m42s      kubelet, card-node016    Unable to attach or mount volumes: unmounted volumes=[ws-qcc7t], unattached volumes=[tekton-creds-init-home-hlblv tekton-internal-secret-volume-gitlab-user-pass-ftq7s tekton-internal-workspace tekton-internal-results cicd-bot-token-sqjdh tekton-internal-secret-volume-bb-user-pass-lxbmq ws-vx927 tekton-internal-home tekton-internal-secret-volume-harbor-user-pass-c2lvv tekton-internal-scripts ws-qcc7t tekton-internal-secret-volume-bb-ssh-key-krpwt tekton-creds-init-home-dq88k tekton-internal-tools tekton-internal-downward]: timed out waiting for the condition
  Warning  FailedMount         4m27s      kubelet, card-node016    Unable to attach or mount volumes: unmounted volumes=[ws-qcc7t], unattached volumes=[tekton-internal-secret-volume-bb-ssh-key-krpwt tekton-internal-secret-volume-harbor-user-pass-c2lvv cicd-bot-token-sqjdh tekton-internal-tools tekton-internal-downward tekton-internal-home tekton-internal-scripts tekton-creds-init-home-dq88k ws-qcc7t tekton-internal-workspace ws-vx927 tekton-internal-results tekton-internal-secret-volume-bb-user-pass-lxbmq tekton-creds-init-home-hlblv tekton-internal-secret-volume-gitlab-user-pass-ftq7s]: timed out waiting for the condition
  Warning  FailedMount         2m13s      kubelet, card-node016    Unable to attach or mount volumes: unmounted volumes=[ws-qcc7t], unattached volumes=[tekton-internal-workspace tekton-creds-init-home-hlblv ws-vx927 tekton-internal-secret-volume-bb-user-pass-lxbmq cicd-bot-token-sqjdh tekton-internal-downward tekton-internal-results tekton-internal-home tekton-internal-secret-volume-bb-ssh-key-krpwt tekton-creds-init-home-dq88k tekton-internal-secret-volume-harbor-user-pass-c2lvv tekton-internal-scripts tekton-internal-tools tekton-internal-secret-volume-gitlab-user-pass-ftq7s ws-qcc7t]: timed out waiting for the condition

attachdetach-controller  Multi-Attach error for volume "pvc-c4ebfa7c-9d44-4056-b9d1-1ea54c2debb4" Volume is already used by pod(s) affinity-assistant-57cf68a947-0

It sounds like your storage system can not let multiple pods use the same volume? If that is the case, you need to disable the affinity assistant. Do you mind sharing what storage system you are using?

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

/remove-lifecycle stale


Error 'no method named 'extend''

I'm having the following error:
error[E0599]: no method named `extend` found for type `&mut proc_macro::TokenStream` in the current scope
   --> /home/ceciliacarneiro/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-0.4.17/src/unstable.rs:213:21
    |
213 |                 tts.extend(
    |                     ^^^^^^

error[E0599]: no method named `extend` found for type `&mut proc_macro::TokenStream` in the current scope
   --> /home/ceciliacarneiro/.cargo/registry/src/github.com-1ecc6299db9ec823/proc-macro2-0.4.17/src/unstable.rs:228:21
    |
228 |                 tts.extend(streams.into_iter().map(|stream| stream.unwrap_nightly()))
    |                     ^^^^^^

error: aborting due to 2 previous errors

$ rustc -V rustc 1.30.0-nightly (73c78734b 2018-08-05)

(73c78734b 2018-08-05)

That's a rather old nightly. Update your nightly (rustup update nightly) or compile this crate using the stable channel (cargo +stable install cargo-binutils).

Nothing we can do here, should work just fine. Please feel free to open another issue if you still run into problems.


feat: rename inputs and add them to ibm_catalog.json

Description
Issue:
https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/issues/36
https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/issues/39

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

created new PR with correct spacing https://github.com/terraform-ibm-modules/terraform-ibm-scc-da/pull/61. Closing this one


Add the exact command to build the docs on the README

Hello!
I have no patience! The README must provide me with one command that builds the doc website and how to open it afterwards.
I do not want to learn to muck around with https://github.com/uncletammy/doc-templater
Thanks for awesome software!
:fireworks: :fireworks:
:fireworks: :fireworks: :fireworks:
:fireworks: :fireworks:
:fireworks:
:fireworks: :fireworks:

Hi @cirosantilli,
Just wanted to let you know we are moving all Sails issues into one repo.
~Cheers!


Where can I find documentation on units?

Some queries call for a unit attribute, but I'm not sure what exactly is the format of this input. The documentation on Apple follows a <unitname>Unit format. What about here?
Apple developer units here: https://developer.apple.com/library/prerelease/ios/documentation/HealthKit/Reference/HKUnit_Class/index.html#//apple_ref/occ/clm/HKUnit/mileUnit
Is this the proper list of all units possible?

Which plugin function are you using and how? Perhaps I can help you with your specific case instead of pointing you at the Apple docs.

I was trying to do a sumQuantityType or a queryQuantityType for HKQuantityTypeIdentifierDistanceWalkingRunning and I tried a variety of options for units using things such as miles, etc. What I didn't realize is that units utilize a unitFromString, and Apple's documentation had a dropdown pop up when you click on a specific section of the documentation. I didn't realize this for the longest time, and whenever I Google an issue or try to find on page, no results show up.
Only after clicking on this did I see a more comprehensive list of all available units and their conversions into HKUnits.
If you're interested, I think I can add some of these links to the README.md for easier reference in the future.


bionic - .XAuthority file missing

workaround
sudo xauth generate :12  . trusted

where :12 is display number

Related:  https://github.com/softasap/sa-vnc-remote-desktop/pull/7


[WIP] RDBMS Filter planner

Closing this due to many changes in original branch (#3167), will re-create from the new one.


added history with new terminal code

I hope that now is ok 🙂
Thanks @nitin42 !

Thanks @CVarisco !!

Its awesome!! 👍

@CVarisco I was just wondering if we could add autocompletion with tab ? By searching the current list of the commands with the input prefix ? Let me know what you think !

@nitin42 Cool!
I think that we can do in steps 🌴

autocomplete the first result on commands pressing tab. (I can do in this week)
List of command that is similar of the part typed and move in the list clicking tab (but this is so complex now).

What do you think ?

Great! If you want to try this, go ahead and let me know if you need any help. I will start exploring more on this in the morning!

@CVarisco im actually using a library for string similarity https://www.npmjs.com/package/string-similarity it give a percent of similarity can be used for autocomplete

@jcgertig Thanks man!
I'm working on it, and I need to edit the handler of history.
Because now we have a lot case with keyCode.
Soon I push the autocomplete 💪

But are we sure it will give the best match if we use this ?

it has  findBestMatch  @nitin42

also look into whatkey @CVarisco

Ok. I'll look further into this in the morning!

findBestMatch(inputValue, Object.keys(commands)) 🙂

Yep that

I'm actually using it in the args parsing for advanced commands

Im requiring at least a 50% or 0.5 certainty before it outputs

I think in the case of auto complete maybe it its < 50% then list the most likely ones

like unix does on double tab

but yeah you said you had issues with keycodes look into whatkey

@jcgertig Ok, the functionality is ok.
But, when you press tab the browser detect the tab and change focus.
How we can resolve this ?

Resolved very easy 🙂  event.preventDefault();


[StimulusBundle] Fix controller name conversion

Q
A

Bug fix?
yes

New feature?
no

Tickets
N/A

License
MIT

Stimulus controllers must follow some naming convention/normalization according to https://stimulus.hotwired.dev/reference/controllers#identifiers
There was a case when controllers file with underscores in their name would not be a valid entry for Stimulus.
I wasn't sure about using Symfony\UX\StimulusBundle\Dto\StimulusAttributes::normalizeControllerName because it seems related to Twig (due to its private Environment $env in construct)

Thank you @jon-ht - very thorough work!


Hitting /tiles in a test should exercise Redis

@pkerpedjiev : So I'm running with REDIS_HOST and REDIS_PORT set, but when I kill the redis container, I still get {} from the API. Not sure whether:

It's not actually seeing the environment variables, for some reason,
or, the API code is swallowing the underlying error, when perhaps it should return a 500?

I think the test we really what is to update the cache state though the API, and then go in at a low level and make sure there's actually something there.

I should have made a note of what error was being thrown when redis wasn't functioning. How about we keep the get tiles test and add a redis test next time we see the error?


Media Serving Issue: Inconsistent Media Delivery with NodeJS and ExpressJS Web Server on StackBlitz

Describe the bug
I've encountered a perplexing issue in my 2D game project on StackBlitz. The game relies on media served by a NodeJS backend using ExpressJS, and I've noticed intermittent failures in media delivery. Occasionally, the server fails to serve the required media assets, causing disruptions in the game's functionality.
Link to the blitz that caused the error
https://stackblitz.com/~/github.com/iTSiolinux/MineResource?view=editor
Steps to reproduce

Open the Terminal:

Locate the "Terminal" on the left side in the StackBlitz editor.

Run Server:

In the Terminal, type node server/index.js and press Enter to start the NodeJS server.

Open Preview Tab:

Click on the "Preview" tab to view your game.

Check for Image Loading Issues:

Observe the game for images that are not loading.

Open Developer Tools:

Press F12 or right-click and select "Inspect" to open the browser's developer tools.

Navigate to "Network" Tab:

Go to the "Network" tab.

Check for Unsuccessful Requests:

Look for any unsuccessful image requests (e.g., oakTree.png not loading).

Expected behavior
The media should load and then the oakTree should apper on top of the player
Parity with Local

[x] I have run the project in my local machine and I could not reproduce the issue.

Screenshots
No response
Platform
Version = 1.84.0
Hash = a5b1ce2088a8c48a3bfda4a131ef20e00b36d9eb
WebContainer = a2aabdd9

Browser name  = Chrome
Full version  = <IP_ADDRESS>
Major version = 120
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 146496069,
  "usedJSHeapSize": 95837765,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}

Additional context
it works sometimes (randomly)

Hey @iTSiolinux 👋 ! Thanks for reaching out!
Is it possible that the repository you linked here is private? Or that you deleted it? I'm unable to open it so I can't really see what the issue is.


react-native-webview postMessage sometimes not work.

import React, { Component } from 'react';
import { View } from 'react-native';
import { WebView } from 'react-native-webview';
export default class App extends Component {
render() {
const html =                                                ;
return (
  <View style={{ flex: 1 }}>
    <WebView
      source={{ html }}
      onMessage={(event) => {
        alert(event.nativeEvent.data);
      }}
    />
  </View>
);

}
}
Environment:

OS: Windows10
OS version: xiaomi Android6.0
react-native version: 0.63.0
react-native-webview version: 10.8.0

If you have multiple WebViews in Windows is onMessage sended to last created, see issue https://github.com/react-native-community/react-native-webview/issues/1572

@tero-paananen   There is still this problem and the merger has not been successful

@tero-paananen There is still this problem and the merger has not been successful

You tested my PR in Windows enviroment? I currently use that PR code in Windows without any problems about messaging on react-native-windows 0.62.x. PR may not compile on 0.63.x. (I am not sure is my PR ever to be merged into master, there is so many PRs waiting)

My PR is for Windows React Native app not for Android

@tero-paananen  Well, I use it on Android and iOS. Thanks for your answers

I will need working post messaging also later for iOS and Android. At least iOS have some kind of messaging implementation done but i have not tested it. I have to test it also soon...so sad if it does not work

Ok, waiting for your good news

@luojiong, tested on iOS simulator using RN 0.62.2 and I don't see the issue you've described with postMessage API.
Here's the code I've been using:
import React from 'react';
import { WebView } from 'react-native-webview';
import { View } from 'react-native';

export default () => {
  return (
    <View style={{ flex: 1 }}>
      <WebView
        source={{
          html:
            '     ',
        }}
        onMessage={event => {
          console.log(event.nativeEvent.data);
        }}
      />
    </View>
  );
};

It is good to notice, that this is not valid HTML and might even activate some weird quirks mode (if such even exists in WKWebView), because the markup is missing doctype declaration. Also, I'm not sure there's a guarantee that the window.ReactNativeWebView.postMessage API is available before the document has been fully loaded. I'd wait for the document to load before calling the API, or follow the react-native-webview documentation if it says anything about this.

@luojiong, perhaps the problem is, that you're using alert() function, which is not available in React Native.

Hi my problem is that I have used multiple web views in "ios" or "android". When loading two web views, I can use postMessage correctly, but only the first web view is triggered
@juhasuni

Well, this seems to work also:
export default () => {
  return (
    <View style={{ flex: 1 }}>
      <WebView
        style={{ flex: 1, backgroundColor: 'green' }}
        source={{
          html:
            '     ',
        }}
        onMessage={event => {
          console.log(event.nativeEvent.data);
        }}
      />
      <WebView
        style={{ flex: 1, backgroundColor: 'red' }}
        source={{
          html:
            '     ',
        }}
        onMessage={event => {
          console.log(event.nativeEvent.data);
        }}
      />
    </View>
  );
};

My log says:
[Thu Sep 17 2020 11:00:13.515]  LOG      Hello 1!
[Thu Sep 17 2020 11:00:13.516]  LOG      Hello 2!

I use setTimeout to delay the triggering of the second webview postMessage after loading the first webview. The problem is solved but I don’t think this is a good idea. I put the html file in the static resource directory, not directly source={{html:''}}

Okay, but it seems to work also without setTimeout:
export default () => {
  return (
    <View style={{ flex: 1 }}>
      <WebView
        style={{ flex: 1, backgroundColor: 'green' }}
        source={{
          html:
            '     ',
        }}
        onMessage={event => {
          console.log('Web view 1:' + event.nativeEvent.data);
        }}
      />
      <WebView
        style={{ flex: 1, backgroundColor: 'red' }}
        source={{
          html:
            '     ',
        }}
        onMessage={event => {
          console.log('Web view 2:' + event.nativeEvent.data);
        }}
      />
    </View>
  );
};

Now, the order in which the messages appear, varies.
Run #1
[Thu Sep 17 2020 11:21:10.720]  LOG      Web view 2:Hello 2!
[Thu Sep 17 2020 11:21:10.723]  LOG      Web view 1:Hello 1!

Run #2
[Thu Sep 17 2020 11:21:18.925]  LOG      Web view 1:Hello 1!
[Thu Sep 17 2020 11:21:18.936]  LOG      Web view 2:Hello 2!

This is of course not a bug.

Sorry, maybe I didn't describe my problem clearly. My problem is that I use react-native to pass information to html instead of htlm to pass to react-native @juhasuni

Sorry, maybe I didn't describe my problem clearly. My problem is that I use react-native to pass information to html instead of htlm to pass to react-native @juhasuni

It is then different bug, not that kind of. You could close this and try to create new issue.

Okay thank you


New sub_directory option introduced an error

Deployer version: master
Deployment OS: Mac OS

The sub_directory option added in https://github.com/deployphp/deployer/commit/baece5a6e3ca27623c635dcad9c35a439ac68dcb is throwing an error when unset.
On deploy:update_code:
[host]  Deployer\Exception\ConfigurationException  in Configuration.php on line 103:
[host]
[host]   Config option "sub_directory" does not exist.
[host]

After a bit of quick and dirty testing, I noticed that null default values are not considered set. I tried for example (in /recipe/deploy/update_code.php):
set('update_code_strategy', null);

And it throws the same error (Config option "update_code_strategy" does not exist.), even if set to null.
I don't know deployer internals well enough to determine if the bug lies in the fact that the default value is null or if it should be en empty string (e.g. set('sub_directory', '');).
I'm pretty sure you have a more precise idea of the issue source.

Yes, will fix before release next week.

is there anyway to use deployer with Laravel 9 before the release of this patch?
-Thanks

@fawzanm Just set sub_directory to an empty string:
set('sub_directory', '');


Feature/example

Type

[X] Feature
[ ] Bug fix
[ ] CI/CD
[ ] Documentation
[ ] Other

Description
Brief description of the changes made.

@magestrio Please solve the conflict


Add a virtualised view for list view to render all results at once

Maybe interesting: https://react-table-library.com/?path=/docs/features-virtualized--large-list


Pull requests CI failing with "ConnectException", "IllegalStateException: Failed to find Build Tools revision 30.0.3"

Example with an empty pull request: https://github.com/commons-app/apps-android-commons/actions/runs/7511731633/job/20451652398#step:8:1
This could be a CI misconfiguration.
Anyone has any idea how to solve this?
NO-OP change to test our CI: https://github.com/commons-app/apps-android-commons/pull/5432

The problem could be due to the Deprecated Features used in Gradle Build.
In the logs, there is a TaskDependencyResolveException exception. I encountered the same error when running a test in the file MediaDetailInputFilter. The error is as follows:
`The following annotation processors are not incremental: butterknife-compiler-10.1.0.jar (com.jakewharton:butterknife-compiler:10.1.0), dagger-android-processor-2.23.jar (com.google.dagger:dagger-android-processor:2.23), dagger-compiler-2.23.jar (com.google.dagger:dagger-compiler:2.23).
Make sure all annotation processors are incremental to improve your build speed.

Task :app:testBetaDebugUnitTest FAILED
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:testBetaDebugUnitTest'.

Could not resolve all files for configuration ':app:jacocoAgent'.
Could not resolve org.jacoco:org.jacoco.agent:0.8.10.
Required by:
project :app
Could not resolve org.jacoco:org.jacoco.agent:0.8.10.
Could not get resource 'https://dl.google.com/dl/android/maven2/org/jacoco/org.jacoco.agent/0.8.10/org.jacoco.agent-0.8.10.pom'.
Could not GET 'https://dl.google.com/dl/android/maven2/org/jacoco/org.jacoco.agent/0.8.10/org.jacoco.agent-0.8.10.pom'.
No such host is known (dl.google.com)
Could not resolve org.jacoco:org.jacoco.agent:0.8.10.
Could not get resource 'https://repo.maven.apache.org/maven2/org/jacoco/org.jacoco.agent/0.8.10/org.jacoco.agent-0.8.10.pom'.
Could not GET 'https://repo.maven.apache.org/maven2/org/jacoco/org.jacoco.agent/0.8.10/org.jacoco.agent-0.8.10.pom'.
No such host is known (repo.maven.apache.org)
Could not resolve org.jacoco:org.jacoco.agent:0.8.10.
Could not get resource 'https://plugins.gradle.org/m2/org/jacoco/org.jacoco.agent/0.8.10/org.jacoco.agent-0.8.10.pom'.
Could not GET 'https://plugins.gradle.org/m2/org/jacoco/org.jacoco.agent/0.8.10/org.jacoco.agent-0.8.10.pom'.
No such host is known (plugins.gradle.org)
Could not resolve org.jacoco:org.jacoco.agent:0.8.10.
Could not get resource 'https://jitpack.io/org/jacoco/org.jacoco.agent/0.8.10/org.jacoco.agent-0.8.10.pom'.
Could not GET 'https://jitpack.io/org/jacoco/org.jacoco.agent/0.8.10/org.jacoco.agent-0.8.10.pom'.
No such host is known (jitpack.io)
Could not resolve org.jacoco:org.jacoco.agent:0.8.10.
Could not get resource 'https://maven.google.com/org/jacoco/org.jacoco.agent/0.8.10/org.jacoco.agent-0.8.10.pom'.
Could not GET 'https://maven.google.com/org/jacoco/org.jacoco.agent/0.8.10/org.jacoco.agent-0.8.10.pom'.
No such host is known (maven.google.com)

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
See https://docs.gradle.org/8.1.1/userguide/command_line_interface.html#sec:command_line_warnings
BUILD FAILED in 1m 37s
50 actionable tasks: 7 executed, 2 from cache, 41 up-to-date
6:05:16 PM: Execution finished ':app:testBetaDebugUnitTest --tests "fr.free.nrw.commons.upload.UploadMediaDetailInputFilterTest.testFilterControlCharacters"'.
`
So, we need to upgrade the gradle version of our app or there may be other problems too.

@rohit9625 Feel free to send a pull request implementing the change you recommend. Thanks! 🙂

Sure @nicolas-raoul
I would like to confirm the change on PC for tests.

Hey @nicolas-raoul
I tried something else related to proxy in our properties.gradle. Obviously the previous error is gone but this time I am facing some other errors, I don't know why?
I request you to please check the logs here :
https://github.com/rohit9625/apps-android-commons/actions/runs/7514555674/job/20457561417
Also tell if these lines in properties.gradle is necessary or not :
systemProp.http.proxyPort=0
systemProp.http.proxyHost=

@rohit9625
Fantastic! Not sure why these proxy settings were here, but they seem to be the problem indeed. :-)
Could you please send a pull request include this change, and also the debug information you added at https://github.com/rohit9625/apps-android-commons/commit/e03651c5ab7be60edeca6b09f44c3658aaa49059 ?
Thanks a lot!


Update the \ README.md file to describe the \ repo.

Changes to the contents of the README.md file.

I have modified my portfolio to include several pictures and a couple more details about me. This is still not the final product, and I want to work on giving it a border and laying out the images so they are not all one after the other. I feel like that uses up a lot of space and looks cluttered. I put in a couple of links and will look into formatting.


Access the platform without being logged in

Reported from the Skeleton community:

just got a very weird interaction where I mistyped my credentials and still got into the locked area of the app but couldn't interact with anything except the logout button

I could not replicate, if someone can, please add more details


Feature Request to have KMS permissions added to lambda role when using KVS with server side encryption and custom KMS key

When I setup the voicemail solution with KVS stream using custom KMS key, the KMS permissions are not added to the lambda role. This causes issues (empty audio file is generated) as the lambda cannot read the KVS data as they are encrypted with a custom key that lambda does not have permissions to.

This will be added in the next release


Could not load image

Hello,
First of all, installing minetest mods on a headless server seems poorly documented. I had to use curl to see the real archive URL, then wget to download it.
I downloaded creatura and animalia ZIP files and inflated it as /var/games/minetest-server/.minetest/mods/{creatura|animalia} and enabled it in the world.mt file.
The mods are working, and i see animals spawning, but without textures. The client is complaining about image creation. And i finally get kicked : "This server has experienced an internal error."
Is there a simple sollution ?

Can't recreate this after the last commit.


XMonad.Prompt freezes if alwaysHighlight= True and maxComplRows is not Nothing

Problem Description
Especially for XMonad.Prompt.Prompt (but the bug holds for XMonad.Prompt.Window) I set alwaysHighlight to True (to avoid the necessity of pressing tab for selection) but to keep the prompt window reasonably small I set maxComplRows to Just 3
If I have enough choices, so that some of them are not shown, and I keep pressing tab, when I select the first "off screen" one, the prompt freezes. To be specific, the prompt stays there, other xmonad keybindings become available (for instance, switching workspace) while applications do not receive keystrokes anymore (the mouse can be used, however).
stdout reports
user error (Pattern match failure in do expression at XMonad/Prompt.hs:911:3-14)
Expected behavior: as when alwayHighlight is false, complete the prompt with the first invisible entry.
Configuration File
, ((myModKey .|. shiftMask, xK_b     ), windowPrompt def{maxComplRows=Just 3,alwaysHighlight = True} Bring allWindows)
Checklist

I've read CONTRIBUTING.md

What version of xmonad are you using?

0.13, installed from cabal

And when you run the version compiled from github, does it still give the same error Pattern match failure in do expression at XMonad/Prompt.hs:911:3-14?

Sorry, for the git version it becomes row 914
user error (Pattern match failure in do expression at XMonad/Prompt.hs:914:3-14)

I found out that when the error occurs, d seems not valid. Specifically, if I print d I get
Display Prelude.!!: index too large.
However, i have no idea where dpy is set

https://github.com/xmonad/xmonad-contrib/blob/master/XMonad/Prompt.hs#L420 and later stuffed into the XPState. But I don't see why this would be relevant to (!!) unless there are two different uses of d with one shadowing the other. dpy is not meaningful to anything but Xlib and the X server.

When the error does not occur, it contains what appears to be a pointer.

It's a pointer obtained from C to the Xlib Display structure, which is supposed to be opaque to anything other than Xlib internals (but is actually partially exposed if you know which knobs to turn). We obtain it from openDisplay aka XOpenDisplay() and then pass it to other Xlib routines, which is all that an Xlib consumer is allowed to do. (Similar constraints exist on the xcb version.)

And I don't think it should ever come from a list, since we can only manage one Xlib Display / Screen at a time. But (!!) arising here means something is being done lazily to get it. I'm not sure what, since the only things I see in Prompt using it are XPState field lookups.

Really thank you very much, that perfectly solved the issue!


Undefined method `is_navigational_format?'

I am running rails 3.2.13, devise 2.2.4 Warden 1.2.1 and devise-encryptable 0.1.2
When I try to access my /users/sign_in I get the following error:
NoMethodError in Devise::SessionsController#new
undefined method `is_navigational_format?' for #Devise::SessionsController:
This error might make sense had I tried to override or modify the session controller code, but I have not done so. If you need more info please let me know, I will be happy to provide it.


Datachannel stalls after periods of inactivity, eventually automatically closes

Your environment.

Version: Pion v2.2.15
Browser: Chromium 83
Other Information - stacktraces, related issues, suggestions how to fix, links for us to have context

What did you do?

I use pion webrtc on the server with a browser client peer. Steps to reproduce issue:

Establish peerconnection
Open datachannel
Send messages and confirm they are received
Wait 2-5min (this time is nondeterministic)
Try to send messages

NOTE: this only happens when establishing a connection directly using UDP STUN. This doesn't seem to happen when using a TURN server in TCP mode
What did you expect?
Expect the datachannel connection to remain stable and messages sent to be received on the server. I used to use node-webrtc before porting the code to golang (https://github.com/node-webrtc/node-webrtc), datachannel used to be quite a bit stable there.
What happened?
OnMessage events stop firing in response to data sent by the browser, even though the datachannel remains in the "open" state on the browser. Sometimes, after much more time passes, the datachannel goes into the "closed" state. In between this time, it's in a limbo of being unusable for extended lengths of time. The peerconnection stays open throughout the entire duration.

Hey @Ambyjkl
Really sorry this got missed! Are you still having problems with this? Do you know if ICEConnectionState has gone to disconnected?
Let me try and run two Pion SCTP Agents against each other and only send a message every 5 minutes. I don't know if this is a networking issue or a SCTP issue  yet.
thanks!

Hey @Ambyjkl if you are still seeing this please re-open!
Closing for inactivity for now.


pyrsistent is dropping support for python 2.x

This leads projects using python 2.7 or such to have a dependency break.
See below issue written for pyrsistent:
https://github.com/tobgu/pyrsistent/issues/214
How would jsonschema like to handle this?
Currently you require the below version:
pyrsistent>=0.14.0
Can we expect a version of jsonschema that helps support projects using python2.x?

Nothing should be required of jsonschema. Any modern pip will only install the newest py2 supporting version.
Have a look at some of the closed duplicates of this if need be.


Wouldn't the fast-forward icon be more intuitive if it pointed backwards (to the left)?

I mean... technically it's parent that fast-forwarded (i.e. parent is moving, child is staying)... but from intuitive PoV, the user is fast-forward merging the child to parent. In other words, the intuitive direction of the merge is from child to parent.
TBH despite I'm all to well familiar with what happens under the hood... I still catch myself thinking over why the arrow points to the right and not to the left :trollface:
@azdrojowa123 @mkondratek pls speak your minds

No strong feelings - we can even rotate like that  Xd but I would rather ask someone from the outside of the project just to confirm your thinking

We decided to drop this idea.
To be precise the direction is different from Git Log (^), Git Machete (v), and the general convention (>) POV. Let's stick to what it is.


DRAFT NO REVIEW

For #

[ ] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
[ ] Title summarizes what is changing.
[ ] Has a news entry file (remember to thank yourself!).
[ ] Appropriate comments and documentation strings in the code.
[ ] Has sufficient logging.
[ ] Has telemetry for enhancements.
[ ] Unit tests & system/integration tests are added/updated.
[ ] Test plan is updated as appropriate.
[ ] package-lock.json has been regenerated by running npm install (if dependencies have changed).

Codecov Report

Merging #4361 (98126c4) into main (e41d7fb) will decrease coverage by 27%.
The diff coverage is 34%.

@@           Coverage Diff           @@
##            main   #4361     +/-   ##
=======================================
- Coverage     75%     47%    -28%
=======================================
  Files        390     387      -3
  Lines      25510   25457     -53
  Branches    3647    3631     -16
=======================================
- Hits       19261   12164   -7097
- Misses      4753   12337   +7584
+ Partials    1496     956    -540

Impacted Files
Coverage Δ

src/client/datascience/variablesView/types.ts
100% <ø> (ø)

.../datascience/variablesView/variableViewProvider.ts
84% <ø> (ø)

...c/client/datascience/variablesView/variableView.ts
19% <5%> (-4%)
:arrow_down:

src/client/datascience/commands/commandRegistry.ts
34% <44%> (-4%)
:arrow_down:

src/client/common/experiments/service.ts
72% <100%> (-23%)
:arrow_down:

src/client/datascience/constants.ts
99% <100%> (+<1%)
:arrow_up:

...ience/interactive-common/interactiveWindowTypes.ts
100% <100%> (ø)

src/client/datascience/kernelSocketWrapper.ts
3% <0%> (-91%)
:arrow_down:

src/client/common/platform/fileSystemUtils.ts
8% <0%> (-85%)
:arrow_down:

src/client/datascience/liveshare/serviceProxy.ts
5% <0%> (-83%)
:arrow_down:

... and 230 more

Codecov Report

Merging #4361 (98126c4) into main (e41d7fb) will decrease coverage by 27%.
The diff coverage is 34%.

@@           Coverage Diff           @@
##            main   #4361     +/-   ##
=======================================
- Coverage     75%     47%    -28%
=======================================
  Files        390     387      -3
  Lines      25510   25457     -53
  Branches    3647    3631     -16
=======================================
- Hits       19261   12164   -7097
- Misses      4753   12337   +7584
+ Partials    1496     956    -540

Impacted Files
Coverage Δ

src/client/datascience/variablesView/types.ts
100% <ø> (ø)

.../datascience/variablesView/variableViewProvider.ts
84% <ø> (ø)

...c/client/datascience/variablesView/variableView.ts
19% <5%> (-4%)
:arrow_down:

src/client/datascience/commands/commandRegistry.ts
34% <44%> (-4%)
:arrow_down:

src/client/common/experiments/service.ts
72% <100%> (-23%)
:arrow_down:

src/client/datascience/constants.ts
99% <100%> (+<1%)
:arrow_up:

...ience/interactive-common/interactiveWindowTypes.ts
100% <100%> (ø)

src/client/datascience/kernelSocketWrapper.ts
3% <0%> (-91%)
:arrow_down:

src/client/common/platform/fileSystemUtils.ts
8% <0%> (-85%)
:arrow_down:

src/client/datascience/liveshare/serviceProxy.ts
5% <0%> (-83%)
:arrow_down:

... and 230 more


for...of inside generator function causes transpilation failure

preset-react-app has the issue described here: https://github.com/leebenson/babel-preset-node5/issues/4
Is this a bug report?
Yes
Steps to Reproduce
set a browserslist in package.json which which includes only browsers which support for...of loops, e.g.
  "browserslist": {
    "production": ["last 1 chrome versions"]
  },

Attempt to build an application which contains a for...of loop inside a generator function, like so:
function* willFailCompilation(array) {
  for (const row of array) {
      yield item;
  }
}

Expected Behavior
The app does not fail compilation
Actual Behavior
This error is shown:
Failed to compile
Module build failed: Error: unknown Statement of type "ForOfStatement"
at Array.forEach ()
Reproducible Demo
[none]

Directly including regenerator in preset-react-app's plugins list predates the existence of preset-env.
Preset-env will transpile generators if browserslist requires it.
Therefore I think the correct solution is simply to remove transform-regenerator here. However I am having a truly awful time trying to verify it, or even reliably reproduce the problem I was having in the first place.

OK I have been able to verify locally that removing regenerator does not eliminate transpilation of generator functions when preset-env dictates that they need to be transpiled.


Better error message for missing docstring and version.

Did that roughly in the bart.
Was not remembering how to print Error message only cleanly.

Thanks, that looks reasonable. Can you add the same try/except for install as well, since that also gets the version number?
Also, btw, you can sys.exit("message") to print a message and exit with code 1.

done.

Thanks!

Congratulations on getting your own contributor graph


ArImageMarker portal moves away

Hello ! Has someone tried to put a Portal on top of an ArImageMarker ? Can't make it work... The portal is well placed when the tracker is found but as soon as I move, the portal moves with me... So it's impossible to enter the portal as he moves away from me when I try to move forward

I don't see the portal is anchored to a marker, can I see your full scene?

@nkrmr Can you provide a sample repo with the issue you're seeing?

@nkrmr any updates, did you solve the "moving when moving"? we also have the problem of objects not being fixed in the ar world.
(@ardasnturk @JamesRMorey)


NTR: Orchiopexy

NTR: Orchiopexy
Synonyms: Orchidopexy, testicular fixation, fixation of testis
Definition: A surgical procedure to move a testis into the scrotum.
Parent term: Surgical procedure MAXO:0000004
Xrefs: SNOMEDCT_US:85419002, NCIT:C111066
HPO link (if you link to phenotype): HP:0000028, HP:0100813
PMID: 32809739

Term MAXO_0001477. Will be available in next release


add code coverage

@moderakh,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Fix annotations for 'virtual SVal getBinding(Store store, Loc loc, Qu…

…alType T = QualType()) = 0' and 'virtual StoreRef Bind(Store store, Loc loc, SVal val) = 0', the original annotations belong to the old version of clang.

clang doesn't use github, this is just a mirror. You should use the review platform instead: http://reviews.llvm.org/

Ok, thank you!


Update CMDCommando.h

Jonas Jonnaaaaass!!! Your amazing library working perfectly on devices with bluetooth keyboard!!!! I need it features! I think i try contribute this helpful library! What do u think about this.

@bimawa thanks :)
I would prefer to change to something like this
#ifndef CMD_COMMANDO_ENABLED
#define CMD_COMMANDO_ENABLED TARGET_IPHONE_SIMULATOR
#endif

This way it defaults to only in simulator, but you can override it if you like in your project prefix.pch file
#define CMD_COMMANDO_ENABLED DEBUG

Yea its good Thx! i'll create new request


Created Laptop Price Prediction

Dear Contributor,
Kindly Start ⭐ this repo. After that only your PRs will be accepted. Don't avoid it.
Thank You.


Broken indicator insets

I don't know exactly what is happening but the #33  break the indicator insets for my UITableView. If I comment the line in scrollViewDidScroll in BLKFlexibleHeightBarBehaviorDefiner then the indicator insets are as expected.
My setup:
A flexibleHeightBar and a tableView are subviews of a UIViewController
I use autoLayout and all my constraints are define in code

Seems I was setting constraints so my tableView would start just under the FlexibleHeightBar, but it seems it is intended as #33 that the FlexibleHeightBar must overlay the tableView and a contentInset must be set.
_tableView.contentInset = UIEdgeInsetsMake(_headerView.maximumBarHeight, 0.0, GlobalMetrics.LARGE_HORIZONTAL_MARGIN, 0.0)

With this it is working as intended it even fixed some flickering I was experiencing while scrolling. The doc should just be more expressive about this fact.


[Bug] kv_cache_bytes missing in metadata(use Python API)

🐛 Bug

To Reproduce
Steps to reproduce the behavior:
run as the get started page
https://llm.mlc.ai/docs/index.html

I have checked the issue #2065, but now I want to run in Python API, could you please help me solve this problem?
I have downloaded the latest version of mlc-llm and tvm-unity.

The first error is because the prebuilt library under path dist/prebuilt_libs/Llama-2-7b-chat-hf/Llama-2-7b-chat-hf-q4f16_1-cuda.so is outdated and does not contain the latest changes. We will update our documents to remove the incorrect examples. And meanwhile, could you just try the following for constructing the ChatModule?
cm = ChatModule(model="HF://mlc-ai/Llama-2-7b-chat-hf-q4f16_1-MLC")

I feel after trying construct ChatModule as above, you might again encounter the same issue you just report (Unsupported layout: 0). I don't have idea on top of my mind. Will discuss with others, see if we can address this, and report back.

@MasterJH5574 I got this problem though

And when I try to convert weight according to the document https://llm.mlc.ai/docs/compilation/convert_weights.html
I got the problem as below, and upgrading numpy did not work
(mlc-chat-venv) wangh@zj-MS-7B17:~/mlc-llm$ mlc_llm convert_weight ./dist/models/RedPajama-INCITE-Instruct-3B-v1/
--quantization q4f16_1
-o dist/RedPajama-INCITE-Instruct-3B-v1-q4f16_1-MLC
[2024-04-16 09:43:25] INFO auto_config.py:115: Found model configuration: dist/models/RedPajama-INCITE-Instruct-3B-v1/config.json
[2024-04-16 09:43:26] INFO auto_device.py:76: Found device: cuda:0
[2024-04-16 09:43:27] INFO auto_device.py:85: Not found device: rocm:0
[2024-04-16 09:43:28] INFO auto_device.py:85: Not found device: metal:0
[2024-04-16 09:43:29] INFO auto_device.py:76: Found device: vulkan:0
[2024-04-16 09:43:29] INFO auto_device.py:76: Found device: vulkan:1
[2024-04-16 09:43:30] INFO auto_device.py:85: Not found device: opencl:0
[2024-04-16 09:43:30] INFO auto_device.py:33: Using device: cuda:0
[2024-04-16 09:43:30] INFO auto_weight.py:70: Finding weights in: dist/models/RedPajama-INCITE-Instruct-3B-v1
[2024-04-16 09:43:30] INFO auto_weight.py:129: Found source weight format: huggingface-torch. Source configuration: dist/models/RedPajama-INCITE-Instruct-3B-v1/pytorch_model.bin
[2024-04-16 09:43:30] INFO auto_weight.py:167: Not found Huggingface Safetensor
[2024-04-16 09:43:30] INFO auto_weight.py:106: Using source weight configuration: dist/models/RedPajama-INCITE-Instruct-3B-v1/pytorch_model.bin. Use --source to override.
[2024-04-16 09:43:30] INFO auto_weight.py:110: Using source weight format: huggingface-torch. Use --source-format to override.
[2024-04-16 09:43:30] INFO auto_config.py:153: Found model type: gpt_neox. Use --model-type to override.
Weight conversion with arguments:
--config          dist/models/RedPajama-INCITE-Instruct-3B-v1/config.json
--quantization    GroupQuantize(name='q4f16_1', kind='group-quant', group_size=32, quantize_dtype='int4', storage_dtype='uint32', model_dtype='float16', linear_weight_layout='NK', quantize_embedding=True, quantize_final_fc=True, num_elem_per_storage=8, num_storage_per_group=4, max_int_value=7)
--model-type      gpt_neox
--device          cuda:0
--source          dist/models/RedPajama-INCITE-Instruct-3B-v1/pytorch_model.bin
--source-format   huggingface-torch
--output          dist/RedPajama-INCITE-Instruct-3B-v1-q4f16_1-MLC
[2024-04-16 09:43:30] INFO gpt_neox_model.py:49: context_window_size not found in config.json. Falling back to max_position_embeddings (2048)
[2024-04-16 09:43:30] INFO gpt_neox_model.py:72: prefill_chunk_size defaults to context_window_size (2048)
Start storing to cache dist/RedPajama-INCITE-Instruct-3B-v1-q4f16_1-MLC
[2024-04-16 09:43:33] INFO huggingface_loader.py:184: Loading HF parameters from: dist/models/RedPajama-INCITE-Instruct-3B-v1/pytorch_model.bin
A module that was compiled using NumPy 1.x cannot be run in
NumPy 2.0.0rc1 as it may crash. To support both 1.x and 2.x
versions of NumPy, modules must be compiled with NumPy 2.0.
Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.
If you are a user of the module, the easiest solution will be to
downgrade to 'numpy<2' or try to upgrade the affected module.
We expect that some modules will need time to support NumPy 2.
Traceback (most recent call last):  File "/home/wangh/anaconda3/envs/mlc-chat-venv/bin/mlc_llm", line 33, in
sys.exit(load_entry_point('mlc-llm', 'console_scripts', 'mlc_llm')())
File "/home/wangh/mlc-llm/python/mlc_llm/main.py", line 29, in main
cli.main(sys.argv[2:])
File "/home/wangh/mlc-llm/python/mlc_llm/cli/convert_weight.py", line 87, in main
convert_weight(
File "/home/wangh/mlc-llm/python/mlc_llm/interface/convert_weight.py", line 182, in convert_weight
_convert_args(args)
File "/home/wangh/mlc-llm/python/mlc_llm/interface/convert_weight.py", line 146, in _convert_args
tvmjs.dump_ndarray_cache(
File "/home/wangh/anaconda3/envs/mlc-chat-venv/lib/python3.11/site-packages/tvm/contrib/tvmjs.py", line 210, in dump_ndarray_cache
for k, origin_v in param_generator:
File "/home/wangh/mlc-llm/python/mlc_llm/interface/convert_weight.py", line 123, in _param_generator
loader = LOADER[args.source_format](
File "/home/wangh/mlc-llm/python/mlc_llm/loader/huggingface_loader.py", line 88, in init
self._load_file(path)
File "/home/wangh/mlc-llm/python/mlc_llm/loader/huggingface_loader.py", line 188, in _load_file
for name, param in load_func(path):
File "/home/wangh/mlc-llm/python/mlc_llm/loader/utils.py", line 40, in load_torch_shard
import torch  # pylint: disable=import-outside-toplevel
File "/home/wangh/anaconda3/envs/mlc-chat-venv/lib/python3.11/site-packages/torch/init.py", line 1477, in
from .functional import *  # noqa: F403
File "/home/wangh/anaconda3/envs/mlc-chat-venv/lib/python3.11/site-packages/torch/functional.py", line 9, in
import torch.nn.functional as F
File "/home/wangh/anaconda3/envs/mlc-chat-venv/lib/python3.11/site-packages/torch/nn/init.py", line 1, in
from .modules import *  # noqa: F403
File "/home/wangh/anaconda3/envs/mlc-chat-venv/lib/python3.11/site-packages/torch/nn/modules/init.py", line 35, in
from .transformer import TransformerEncoder, TransformerDecoder,
File "/home/wangh/anaconda3/envs/mlc-chat-venv/lib/python3.11/site-packages/torch/nn/modules/transformer.py", line 20, in
device: torch.device = torch.device(torch._C._get_default_device()),  # torch.device('cpu'),
/home/wangh/anaconda3/envs/mlc-chat-venv/lib/python3.11/site-packages/torch/nn/modules/transformer.py:20: UserWarning: Failed to initialize NumPy: _ARRAY_API not found (Triggered internally at ../torch/csrc/utils/tensor_numpy.cpp:84.)
device: torch.device = torch.device(torch._C._get_default_device()),  # torch.device('cpu'),
Traceback (most recent call last):
File "/home/wangh/anaconda3/envs/mlc-chat-venv/bin/mlc_llm", line 33, in
sys.exit(load_entry_point('mlc-llm', 'console_scripts', 'mlc_llm')())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/wangh/mlc-llm/python/mlc_llm/main.py", line 29, in main
cli.main(sys.argv[2:])
File "/home/wangh/mlc-llm/python/mlc_llm/cli/convert_weight.py", line 87, in main
convert_weight(
File "/home/wangh/mlc-llm/python/mlc_llm/interface/convert_weight.py", line 182, in convert_weight
_convert_args(args)
File "/home/wangh/mlc-llm/python/mlc_llm/interface/convert_weight.py", line 146, in _convert_args
tvmjs.dump_ndarray_cache(
File "/home/wangh/anaconda3/envs/mlc-chat-venv/lib/python3.11/site-packages/tvm/contrib/tvmjs.py", line 210, in dump_ndarray_cache
for k, origin_v in param_generator:
File "/home/wangh/mlc-llm/python/mlc_llm/interface/convert_weight.py", line 123, in _param_generator
loader = LOADER[args.source_format](
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/wangh/mlc-llm/python/mlc_llm/loader/huggingface_loader.py", line 88, in init
self._load_file(path)
File "/home/wangh/mlc-llm/python/mlc_llm/loader/huggingface_loader.py", line 188, in _load_file
for name, param in load_func(path):
File "/home/wangh/mlc-llm/python/mlc_llm/loader/utils.py", line 50, in load_torch_shard
param = param.numpy()
^^^^^^^^^^^^^
RuntimeError: Numpy is not available

i had similar issues before. i think i fixed with pip install numpy==1.26.4

@0xDEADFED5 thank you !!! I tried and it works well

@MasterJH5574
I encountered the same issue when I use llava to run in chat module. After I successfully convert weights of llava and generate chat config, I got result as below, I feel it may concerned with the version of TVM, I install the latest version of TVM Unity using pip, and I will try to install earlier version from source and see if it works well.

Hi @XJY990705, we have fixed this. Please update the pip package and try again :-) and also please let me know how things go.

@MasterJH5574  I tried to install TVM-Unity using pip and it works well, thank you very much!!


Permissions for read-only connection aren't saved

System information:

Operating system (distribution) and version win 10 x64
DBeaver version 6.2.2

Steps to reproduce, if exist:

Open Edit connection
Check read-only connection
Change some permissions by clicking Edit Permissions button
Re-connect and do steps 1-3 once again - all checkbox in Edit permissions pop-up are unchecked,

The problem is in permission load in edit dialog. Actual settings is working,
Fixed

Verified


Scrollbar

Do you have any idea how it may be made, I'm looking for such feature for one of my project

I didn't work on it yet, because nobody really asked for it till now.
I think you can take a look at https://github.com/petertriho/nvim-scrollbar. Either use that plugin directly or take parts of it to include in your project.
I'll see if I can add this feature in nui.nvim, but that will take some time.

great, makes sense, thanks!