update-application functionality

--update-identifier option: will take priority and prevent any other changes from happening. Is this intended? May want to add that to description of the option.
When not using --update-identifier: only the description seems to be updated. Templates/.py/.yaml files seem to be .tar'd up and sent with the "client.put()" line, but files on the server aren't updated.

Thanks for reporting the issue. We will investigate and discuss the best approach for this:

better describe this option;
otherwise fix the issue preventing any other changes from happening.

A task was created to cover this issue: ARMADA-636.


Adding Podspec

Thanks for the library.
You'll need to make a tag for the release - but otherwise it is good to go.

First: I personally prefer git submodules more than pods, so I might have made a mistake or something, since I've never used it before.
You had a type in the repo URL with https://github.com/lhecker/NSLabel.gif (i.e.: .gif).
I pushed a fix, added the tag and pushed the version in the pods trunc (?).
Anyhow: Thanks for your contribution! :smiley:

Great. I just verified that it works.
I will add the podspec to the (horrible) specs repo (https://github.com/CocoaPods/Specs) so it can be installed without a direct GitHub URL.

Shouldn pods trunk push do that already? Because I did create that file: https://github.com/CocoaPods/Specs/blob/master/Specs/NSLabel/1.0.0/NSLabel.podspec.json

Oh awesome - I didn't know that was available. Much quicker..

I used that guide: https://guides.cocoapods.org/making/getting-setup-with-trunk.html
Interestingly pods really has the usual downsides of the ruby community... :confused:
Nowhere in the docs it was mentioned what the Unable to find the master repo. means. Turns out that after installing pod and using it it won't initialize the local "cache". Running pod spec lint manually fixed it. Interestingly (N° 2) the docs say that pod spec lint should be run automatically if you use pods trunk push... :expressionless:


Practice branch to help solve testData() problem.

So I was trying to integrate the testData function into the testData page and for some reason, nothing comes up when I try to create a conversation from the Practice.txt file. Also, although I had all the code for the random conversation generator commented out they still appear when the site is launched, I'm thinking there's something wrong with the Datastore that stores test Data. I was thinking that might have something to do with our writeThrough() function.
Another possible reason I think Practice.txt might be failing to make a conversation is that the file cannot be found. I previously had a try() catch() block within my testData() method that captured all the code with testData() in the try() block but the FileNotFoundException kept getting triggered so maybe my file isn't getting found? The Practice file is within my CodeU-Spring-2018 directory. If anyone needs any clarification just ask I know everything I wrote is kinda jargon right now.

DefaultDataStore generates the random data and writes it through to PersistentDataStore. The loadUsers() method in PersistantDataStore is what loads the Users, Messages, and Conversations when the app is restarted. To clear all stored data though, just run mvn clean.


Update README for scripts

Update README for scripts
Issue

This PR results/does not result in breaking changes to upstream dependencies.

Checklist

[ ] This PR contains all the work required to resolve the linked issue.

[ ] The work contained has sufficient documentation to describe what it does and how to do it.

[ ] The work has sufficient tests and/or testing.

[ ] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

[ ] I have added the appropriate labels to this PR.

The part of README:
See cardano-cli's [Transactions](../cardano-node/README.md#transactions) section for instructions on how to generate a tx.
points to empty doc inside cardano-node repo, is that location still valid and that other README needs to be updated with some info or the link should point to cardano-benchamrking repo  @CodiePP ?

bors r+


ctr: no match for platform in manifest sha256:xxx: not found

Description
On widnows 10 pro.
PS G:\Downloads\containerd> .\ctr.exe i pull docker.io/library/alpine:latest
docker.io/library/alpine:latest:                                               resolved       |++++++++++++++++++++++++++++++++++++++|
index-sha256:a75afd8b57e7f34e4dad8d65e2c7ba2e1975c795ce1ee22fa34f8cf46f96a3be: exists         |++++++++++++++++++++++++++++++++++++++|
elapsed: 3.9 s                                                                 total:   0.0 B (0.0 B/s)
unpacking windows/amd64 sha256:a75afd8b57e7f34e4dad8d65e2c7ba2e1975c795ce1ee22fa34f8cf46f96a3be...
ctr: no match for platform in manifest sha256:a75afd8b57e7f34e4dad8d65e2c7ba2e1975c795ce1ee22fa34f8cf46f96a3be: not found
PS G:\Downloads\containerd>

Steps to reproduce the issue:

download 1.4.4
start containerd
run the previous command

Describe the results you received:
Describe the results you expected:
What version of containerd are you using:
$ containerd --version
containerd github.com/containerd/containerd v1.4.4 05f951a3781f4f2c1911b05e61c160e9c30eaa8e

Any other relevant information (runC version, CRI configuration, OS/Kernel version, etc.):

runc --version
$ runc --version

crictl info
$ crictl info

uname -a
$ uname -a

Hello, the https://hub.docker.com/_/alpine doesn't support window platform. The result is expected. Please checkout the https://github.com/docker-library/official-images#architectures-other-than-amd64. Thanks for reporting.

Thanks very much!
I'm not familiar with containd, but I want wrap contanind in a windows EXE application.
I tried docker-ce on same win10 machine, for the same image(alpine), it works fine.
What should I do to make containerd works like docker-ce ?
Any docs for that ?

Thanks very much!
I'm not familiar with containd, but I want wrap contanind in a windows EXE application.
I tried docker-ce on same win10 machine, for the same image(alpine), it works fine.
What should I do to make containerd works like docker-ce ?
Any docs for that ?

Hello, the https://hub.docker.com/_/alpine doesn't support window platform. The result is expected. Please checkout the https://github.com/docker-library/official-images#architectures-other-than-amd64. Thanks for reporting.

@cnhuye you can run the docker run -it --rm busybox uname -a to check the result~. I don't have windows env actually. But I think it is the same to the docker-on-mac which running in hyper(https://github.com/moby/hyperkit).

谢谢兄弟！ 我再研究研究～  BTW,  我也在北京，看到这么有前途的项目有咱自己的兄弟参与，很是开心 ～

@cnhuye you can run the docker run -it --rm busybox uname -a to check the result~. I don't have windows env actually. But I think it is the same to the docker-on-mac which running in hyper(https://github.com/moby/hyperkit).


demo use-case remixing utils api calls

adding https://mybinder.org/ may be nice/easy to use as well.


AVAS: report detailed errors

Unfortunately, we are versioning AVAS objects that can be instantiated
only in SAP systems but we use the repo also in sandbox Customer
systems.
Whenever I open the repository I get an exception of the type
cx_pak_invalid_data.
Without this commit I see the error message:
"AVAS error".
With this commit I see the error message:
"AVAS $GUID: invalid data: The functionality is not supported in
customer systems"

Now, the question is how to work around the problem that I cannot use the repository with SAP AVAS attributes in our customer sandbox systems :)

Does this work? Instantiate doesn't propagate the exception zcx_abapgit_exception in its interface.
https://github.com/larshp/abapGit/blob/b98db9bd7c91f57b618e98b1ca30c8d2a89d0ce3/src/objects/zcl_abapgit_object_avas.clas.abap#L32-L34

Does this work?

Yes, you get a short dump and the exception message is displayed in the detailed information. At least on our machines.

Hm, ok I see.
Wouldn't it be better if we propagate the exception to the caller? I get warnings for this in the code inspector and ATC.

The ATC warning is bad, however, the actual behavior (dump) is ok. What about to use an ancestor of CX_DYNAMIC_CHECK?
One can propose to handle the exception, report the corresponding object as unsupported and keep abapGit running. It might be the solution, but I am not sure if abapGit is ready for such a logic. I would also want to mute the warning - perhaps, by putting the object to ignore list.

I should stop talking and start coding like @larshp -> #1672

🚢


fix: Path to checksum file was relative and it caused issues when run from the action workflow

When running in a workflow, the generate_version_checksums.sh was being executed from the root of the workspace which caused the relative path to be incorrect.
Changed the main script to accept the checksum file as a parameter and updated the workflow to pass the fully qualified path.

Looks good, this message is part of another test.


Duplicate Translation When Element Has Content

Hi,
When I have the translate attribute on a HTML element and that element also has text content;

Login Screen

The produced HTML is as so (the translation of 'login.title' is 'Login Title')

Login TitleLogin Title

Where it has the translation twice in the innerHTML. I've looked and notice there is a unit test for this situation which is passing, so I'm not sure what I'm doing wrong. I've create a repository here that replicates the issue here - https://github.com/backwards-rat-race/duplicate-translate-issue/blob/master/src/app/app.component.html

Hmmm...

Login Screen

works

Thanks. That resolves the issue.


OPENSSL_strcasecmp [3.0]

This is a backport of #18069 for 3.0
Checklist

[x] documentation is added or updated
[x] tests are added or updated

Does anybody know why do I have to explicitly add OPENSSL_crypto_init to fix some tests?

Does anybody know why do I have to explicitly add OPENSSL_crypto_init to fix some tests?

It is not called implicitly unless you do some operations that call it.

@t8m, is it a difference to master? I didn't come across any problem with it there and didn't find any changes in testutil related to this.

I also don't like this idea much... An initialization on-demand under lock in ossl_c_locale?

In master OPENSSL_init_crypto is called from
#0  OPENSSL_init_crypto (opts=262144, settings=0x0) at crypto/init.c:476
#1  0x00007ffff7d6b049 in ossl_rand_ctx_new (libctx=0x7ffff7fbbb20 <default_context_int>) at crypto/rand/rand_lib.c:450
#2  0x00007ffff7c7178b in context_init (ctx=0x7ffff7fbbb20 <default_context_int>) at crypto/context.c:105
#3  0x00007ffff7c71e35 in default_context_do_init () at crypto/context.c:339
#4  0x00007ffff7c71e01 in default_context_do_init_ossl_ () at crypto/context.c:336
#5  0x00007ffff7894d48 in __pthread_once_slow () from /lib64/libc.so.6
#6  0x00007ffff7c8937a in CRYPTO_THREAD_run_once (once=0x7ffff7fbbc50 <default_context_init>, init=0x7ffff7c71df8 <default_context_do_init_ossl_>) at crypto/threads_pthread.c:144
#7  0x00007ffff7c71e89 in get_thread_default_context () at crypto/context.c:350
#8  0x00007ffff7c71ebc in get_default_context () at crypto/context.c:358
#9  0x00007ffff7c72173 in ossl_lib_ctx_get_concrete (ctx=0x0) at crypto/context.c:465
#10 0x00007ffff7c723ec in ossl_lib_ctx_get_ex_data_global (ctx=0x0) at crypto/context.c:575
#11 0x00007ffff7c74f44 in ossl_crypto_new_ex_data_ex (ctx=0x0, class_index=12, obj=0x41a2a0, ad=0x41a310) at crypto/ex_data.c:219
#12 0x00007ffff7c751e6 in CRYPTO_new_ex_data (class_index=12, obj=0x41a2a0, ad=0x41a310) at crypto/ex_data.c:260
#13 0x00007ffff7b164cb in BIO_new_ex (libctx=0x0, method=0x7ffff7f9ab60 <methods_filep>) at crypto/bio/bio_lib.c:94
#14 0x00007ffff7b16637 in BIO_new (method=0x7ffff7f9ab60 <methods_filep>) at crypto/bio/bio_lib.c:122
#15 0x00007ffff7b21b43 in BIO_new_fp (stream=0x7ffff79fd5a0 <_IO_2_1_stdout_>, close_flag=16) at crypto/bio/bss_file.c:95
#16 0x0000000000408b28 in test_open_streams () at test/testutil/basic_output.c:27
#17 0x000000000040292a in main (argc=1, argv=0x7fffffffddc8) at test/testutil/main.c:19

CI is green. @t8m, @paulidale - please review.

Ping for the review

@t-j-h sure
https://github.com/openssl/technical-policies/issues/44

We need to cross-reference things like this and make sure a hold is placed so someone doesn't accidentally think this is good to go into the code until a vote is complete. You should have placed the hold when you called the vote IMHO.

Sorry, my fault.

@t-j-h just in case - how do I add non-public exportable function?

@levitte - is everything OK on VMS?

@t-j-h, @levitte - what alternative approach will be OK for you if we don't want to extend the public API?

Did it? We have 5 +1 and 1 +0

With the vote to accept this passed, I've removed the OTC decision required and completed the second review.

Many thanks!

Did it? We have 5 +1 and 1 +0

https://www.openssl.org/policies/omc-bylaws.html#otc-voting
0s (or -0 +0s) do not count . There are 5 +1 votes and single -1 vote, there is only a single vote remaining uncast. Even if the remaining vote was -1 it would still be 5 pro and only 2 against which means the vote has passed.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Merged. Many thanks for the approval!


Stable release accidentally marked pre-release?

I'd noticed that the 12.0.0 release this morning, described as stable, is also marked as pre-release. Thought I should give a friendly heads up in case that was unintentional. (If intentional, apologies for the false positive.)
Thanks for a most wonderful piece of software :) I'm excited to use 12.0!
Chris

Hi Chris! Yes, this is intentional: we wanted to get a cherry-pick into 12.0.0 but were sadly late for the release (I know the schedule is off but still :disappointed:). I triggered the release but then realized the cherry-pick situation and so I marked it "pre-release".
I don't know if we will delete this release and reuse the name (most users won't know the difference) or simply make something like 12.0.0-1/12.0.0-patch and mark it as the release one but we're expecting the updated version within a week or so.
The cherry-pick is related to the remote index feature but it doesn't change the feature functionality, we just want to make the configuration safer.
Thanks for noticing and bringing it up: this time it was intentional but in other cases it might not be :smile: So it certainly helps when someones raises the awareness, thank you for that and happy coding!

Sounds great! Thanks for being awesome (and nice)--and apologies for the false alarm.


Deactivate update_addons_current_version/fast_current_version crons

This is mostly lifted from https://bugzilla.mozilla.org/show_bug.cgi?id=956752 but re-explained with the latest investigation results and outside of bugzilla.
The update_addons_current_version / fast_current_version crons are nasty, going over all the database and spawning many tasks in an attempt to correct an old issue with the _current_version denormalized field on addons.
A long time ago the AMO team figured they should be useless by now and added a waffle switch to turn them off. Unfortunately, once that switch was flipped, regressions happened and it was never changed since - the switch is on (at least in prod), which leaves the crons enabled.
From looking at Kibana it looks like these crons are useless nowadays, at least for non-personas. If I query for "Version changed from current" AND (Hostname:"ip-172-31-47-71" OR Hostname:"ip-172-31-47-72" OR Hostname:"ip-172-31-37-161" OR Hostname:"ip-172-31-37-163") in prod, I get no results, indicating that this log statement is never hit from celery ips. That statement is inside Addon.update_version(), which the cron task calls directly - that's all the task does, really. If you remove the hostname filtering you can see results, the log statement is hit regularly from our webservers when new versions are submitted/reviewed.
TL;DR: those crons can probably be deactivated.
Let's test that theory by turning the current_version_crons waffle switch off in dev/stage and then prod soon.

We should be able to cope with this in our infrastructure though, so this does feel like a big risk. If it fails what would we expect to see, what's our STR so that Krupa can test?

STR:

Submit a new addon, see if it appears correctly (including version information everywhere)
Submit a new version, see if it appears correctly (including version information everywhere)
Push a newly submitted version to public, see if it appears correctly (including version information everywhere)

Etc. Basically playing with versions :)
The risk is minimal because those crons are here as a fallback to set current_version when it's somehow not set correctly. Because of this, just re-enabling them will fix any issues. In fact, we can use that in our advantage to test what happens on stage : after playing with addons with the crons turned off, we can turn them on, wait for them to run, and look again in the logs to see if they did anything.

No issues were found on dev or stage during that period.


[tests-only] [full-ci] Refactor the response should contain

Description
We don't really need to mention the user name in the step:
    Then for user "Alice" the "PROPFIND" response should contain a space "new-space" with these key and value pairs:

That user is used to find out information about the space, and compare it with what came in a previous response (which was remembered from the result of a When step). We already remember the user who created each space, so we can use that user inside the Then step, when we want to do any extra requests about the space.
IMO this reduces confusion a bit when reading the scenarios.
How Has This Been Tested?
CI
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Technical debt
[x] Tests only (no source changes)

Checklist:

[ ] Code changes
[ ] Unit tests added
[ ] Acceptance tests added
[ ] Documentation ticket raised:

I need to sort out the case when the check is for a mountpoint... TBD


Insert request method option storage driver URLFor

Otherwise HEAD requests using s3 result in a redirect to a 403.

LGTM!


Testnet Deployment

Description

Resolves #
Checklist

[ ] I have updated the documentation to account for the changes in the code.
[ ] If I added new functionality, I added tests covering it.
[ ] If I fixed a bug, I added a test preventing this bug from silently reappearing again.
[ ] My contribution follows Venus contribution guidelines.

▶ yarn deploy --network bsctestnet
Nothing to compile
No need to generate any newer typings.
deploying "DefaultProxyAdmin" (tx: 0x102a9b1395948127fa21e47c935c35d7420e186d1712c9315feba03120b59b93)...: deployed at 0x7FD98e2C3A29B6D3396957f888fcBEf6BdEd5b01 with 642683 gas
deploying "BoundValidator_Implementation" (tx: 0xb98afd66d9da96b729a711f3c709a0eeb680b1647cbcedf92385a6933fdf14bf)...: deployed at 0xe663872EB70991cDf19671Ae6C6A0C6794814E20 with 666628 gas
deploying "BoundValidator_Proxy" (tx: 0x1031e470506927ad832dd7b5d76e55aa2a38a77a9c085265c1fffca2fd0fe193)...: deployed at 0x8A315876B80583f075bbdFD3C2486c607ebeAA2a with 670181 gas
reusing "DefaultProxyAdmin" at 0x7FD98e2C3A29B6D3396957f888fcBEf6BdEd5b01
deploying "ResilientOracle_Implementation" (tx: 0xd9305a5a41ffbc0c500f3d6bed2d8485109d6a3a6e9f7aecd3d28ada6e4b1630)...: deployed at 0xb5F1735789f899f2f217A665c4dC98d122bfbFD4 with 1501077 gas
deploying "ResilientOracle_Proxy" (tx: 0xeeeed0029767fd62a5bf7b5131eda68b61458f5a5d3fd8391186b86e53644470)...: deployed at 0x42DE63c6895120FAC208a98b20705fb1F2917e0d with 695083 gas
reusing "DefaultProxyAdmin" at 0x7FD98e2C3A29B6D3396957f888fcBEf6BdEd5b01
deploying "ChainlinkOracle_Implementation" (tx: 0xb1840b7595967f517d3963b6a11f14085e66e7d1e237706d5154dca9610961cb)...: deployed at 0x5381e99A8b3e73fDFB67856868D96Eaa04243D5b with 1111685 gas
deploying "ChainlinkOracle_Proxy" (tx: 0xc2d133cbb9f30a7326be029241c774d3ed722a777b2468c2a508d64881b582b3)...: deployed at 0xfba373E79787588f3d3F191E5C39f31f732B6d9a with 670158 gas
deploying "TwapOracle_Implementation" (tx: 0x139a64811cc72e2a7b37b65c99a40ecf74829894be7c9afb380a37b253a89c9c)...: deployed at 0x8bcD2171079FA7e27CBe4bdb0C182a4b1Eff743e with 1442162 gas
deploying "TwapOracle_Proxy" (tx: 0x517b2aa29d6a8a335f34c7a3af9d14a419344786ec4aeaa000c01cddb98da285)...: deployed at 0xA790acA51165B8DF8FB69F37ed6798661f5EA0eC with 691794 gas
reusing "DefaultProxyAdmin" at 0x7FD98e2C3A29B6D3396957f888fcBEf6BdEd5b01
deploying "PythOracle_Implementation" (tx: 0x72c91fb735d9ccfb73865c5442a6e9b6b58a253f2d73dcf25892384833fedca2)...: deployed at 0x79d2bD92c1765fC5d65f98db7743Cc249462E581 with 982416 gas
deploying "PythOracle_Proxy" (tx: 0xe9ed9479f088c739b8dc8ca3c9d5984704b3272b3bcb9f8f1c6b43852960ca6d)...: deployed at 0x616c1Ca28C3299b0401078942718338D3159c67F with 692901 gas
reusing "DefaultProxyAdmin" at 0x7FD98e2C3A29B6D3396957f888fcBEf6BdEd5b01
deploying "BinanceOracle_Implementation" (tx: 0x9b927decae9574387322d82983b83460156764665e15a3e92d06d185857b76e5)...: deployed at 0x2081e57F6403A06576646de8262A53B15b362AA4 with 528202 gas
deploying "BinanceOracle_Proxy" (tx: 0x046e18107f515a6119935d761207199ad0980687c5ae50b57c6e3799886f7b6f)...: deployed at 0xAAd4C539F8A118588b48118f789cC1ecfB72B4A0 with 648331 gas


Various test flakes on MacOS

These have been going on for for a while across a bunch of test cases (10-20?) and they seem to have a similar root cause. They are relatively rare, but because they happen on multiple test cases, they end up failing a fairly large percentage of builds on macos master.
Some key facts:

we don't know if this is about the infrastructure (overloaded mac workers?) or an actual problem in our code
they are happening for C and C++ tests
windows and linux tests are comparably much more stable
happening on multiple test cases randomly, but the error messages look similar (cq_verify expectations not met).
the error are happening more often with dbg build than with opt build
we haven't been successful in reproducing locally (for several tests we tried)

Examples of error messages in the most recent failures (C & dbg tests):
https://source.cloud.google.com/results/invocations/3003302b-1c2d-416b-9055-40882a4bf66b/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests
https://source.cloud.google.com/results/invocations/4f0bdfbf-3e21-48a1-a723-9df2e012214d/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests
https://source.cloud.google.com/results/invocations/f2379d05-00da-44c2-9ea5-1322c0105667/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests
E0527 00:26:02.418285000<PHONE_NUMBER>34816 cq_verifier.cc:273]           cq returned unexpected event: OP_COMPLETE: tag:0x1 OK
E0527 00:26:02.418300000<PHONE_NUMBER>34816 cq_verifier.cc:280]           expected tags:
tag(101) GRPC_OP_COMPLETE success=1 test/core/end2end/tests/max_connection_idle.cc:109

https://source.cloud.google.com/results/invocations/e534a7e5-ef1c-404d-acdf-3dbaf8fc5fc3/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests
I0527 04:25:28.846977000<PHONE_NUMBER>37312 graceful_server_shutdown.cc:37] Running test: test_early_server_shutdown_finishes_inflight_calls/chttp2/fullstack
D0527 04:25:28.866590000<PHONE_NUMBER>37312 dns_resolver.cc:280]          Start resolving.
E0527 04:25:38.867757000<PHONE_NUMBER>37312 cq_verifier.cc:273]           cq returned unexpected event: OP_COMPLETE: tag:0x1 OK
E0527 04:25:38.867781000<PHONE_NUMBER>37312 cq_verifier.cc:280]           expected tags:
tag(101) GRPC_OP_COMPLETE success=1 test/core/end2end/tests/graceful_server_shutdown.cc:144

https://source.cloud.google.com/results/invocations/56306121-094c-406e-853a-3eb431c4eefa/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests
I0528 00:26:40.191010000<PHONE_NUMBER>42848 retry_non_retriable_status_before_recv_trailing_metadata_started.cc:47] Running test: retry_non_retriable_status/chttp2/fullstack+census
D0528 00:26:40.209450000<PHONE_NUMBER>42848 retry_non_retriable_status_before_recv_trailing_metadata_started.cc:157] client_peer_before_call=localhost:28846
D0528 00:26:40.209504000<PHONE_NUMBER>42848 dns_resolver.cc:280]          Start resolving.
E0528 00:26:45.209704000<PHONE_NUMBER>42848 cq_verifier.cc:273]           cq returned unexpected event: OP_COMPLETE: tag:0x1 ERROR
E0528 00:26:45.209723000<PHONE_NUMBER>42848 cq_verifier.cc:280]           expected tags:
tag(101) GRPC_OP_COMPLETE success=1 test/core/end2end/tests/retry_non_retriable_status_before_recv_trailing_metadata_started.cc:189

https://source.cloud.google.com/results/invocations/3be6a31c-fca3-48fb-b984-a52c8affa4ae/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests
D0528 04:26:31.710384000<PHONE_NUMBER>75200 dns_resolver.cc:280]          Start resolving.
E0528 04:26:41.716259000<PHONE_NUMBER>75200 cq_verifier.cc:219]           no event received, but expected:
tag(1) GRPC_OP_COMPLETE success=1 test/core/end2end/tests/max_message_length.cc:227

https://source.cloud.google.com/results/invocations/c21c2f56-7722-4b7c-8717-58906347e836/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests
D0529 10:59:50.230716000<PHONE_NUMBER>58848 dns_resolver.cc:280]          Start resolving.
E0529 10:59:53.232753000<PHONE_NUMBER>58848 cq_verifier.cc:235]           actual success does not match expected: tag(99) GRPC_OP_COMPLETE success=1 test/core/end2end/tests/ping.cc:79

https://source.cloud.google.com/results/invocations/275628d9-942c-4d88-9555-32342e270915/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests
I0529 17:20:02.581279000<PHONE_NUMBER>18976 write_buffering.cc:37]        Running test: test_invoke_request_with_payload/chttp2/fullstack+load_reporting
D0529 17:20:03.653726000<PHONE_NUMBER>18976 dns_resolver.cc:280]          Start resolving.
E0529 17:20:08.654375000<PHONE_NUMBER>18976 cq_verifier.cc:235]           actual success does not match expected: tag(1) GRPC_OP_COMPLETE success=1 test/core/end2end/tests/write_buffering.cc:147

https://source.cloud.google.com/results/invocations/175aa23a-042f-4a9d-bd97-97d8cce07d04/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests
D0531 02:25:47.856783000<PHONE_NUMBER>79840 dns_resolver.cc:280]          Start resolving.
E0531 02:25:50.863117000<PHONE_NUMBER>79840 cq_verifier.cc:235]           actual success does not match expected: tag(99) GRPC_OP_COMPLETE success=1 test/core/end2end/tests/ping.cc:79

https://source.cloud.google.com/results/invocations/bba74849-4cfa-494d-8cc7-5a74f4b330cf/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests
E0531 08:26:45.147313000<PHONE_NUMBER>18976 cq_verifier.cc:280]           expected tags:
tag(2) GRPC_OP_COMPLETE success=1 test/core/end2end/tests/cancel_after_accept.cc:195

CC @matt-kwong  @dgquintas @nicolasnoble

Looking at the failure history, I've found the approximate time when these sort of failures started (it's only approximate because tests are flaky)
for dbg C builds:
https://source.cloud.google.com/results/invocations/f91b9e5a-c9ad-460f-a231-0b50498162c8 at   2018-04-13 01:21:23.000 UTC  (git commit 6d3e7f7cd4ea286ab6b22c9f3da44839fa4357e3)
for opt C builds:
https://source.cloud.google.com/results/invocations/https://source.cloud.google.com/results/invocations/0f632cef-32af-4514-b340-b2d85e4c4f3f at 2018-04-16 22:39:15.000 UTC (git commit a377773ae928043e1969d6c7c360f93f68fd9ca8)

I will try to see if there are any changes that could have caused this in (breakage introduced - 14days):
https://github.com/grpc/grpc/compare/3fd682961a24c9b92c68a058f1949592cc5aacb9...6d3e7f7cd4ea286ab6b22c9f3da44839fa4357e3.
Also, we can try to see if there were are any kokoro-related macos changes in that period of time.

I looked at the historical data again and it really seems like the problem started when we switched to kokoro distributed master (which involved switching to workers to macos sierra). There's very few macos failures before the switch and failures similar to the ones we are seeing right now start after the switch.

Out of curiosity, on which macos version are you guys trying to repro this locally?

@dgquintas  my machine is macos high sierra 10.13.2 , what's more interesting is that this is not possible to reproduce even on kokoro worker if we only run a single specific test and -n is set to a large number (at least I haven't been able to reproduce sucessfully that way).

Update: with our older image experiment (workers using macos elcapitan), we now got 17 dbg C runs and 14 opt runs without any of the failures mentioned above - we'd still need more data to be sure, but 31 fully green runs seem unusual enough to think there really is a significant difference between sierra and elcap images.

I started running an experimental job that only runs C core tests with extra logging. (see https://github.com/grpc/grpc/compare/master...jtattermusch:macos_flake_experiment)
so far it seems that the name resolution finishes successfully (I added an extra log message):
I0703 02:57:51.588550000<PHONE_NUMBER>60480 retry_recv_initial_metadata.cc:47] Running test: retry_recv_initial_metadata/chttp2/fullstack+census
I0703 02:57:51.588567000<PHONE_NUMBER>60480 init.cc:153]                  grpc_init(void)
I0703 02:57:51.592881000<PHONE_NUMBER>60480 init.cc:158]                  grpc_shutdown(void)
I0703 02:57:51.593520000<PHONE_NUMBER>60480 completion_queue.cc:431]      grpc_completion_queue_create_internal(completion_type=0, polling_type=0)
I0703 02:57:51.593548000<PHONE_NUMBER>60480 completion_queue.cc:431]      grpc_completion_queue_create_internal(completion_type=1, polling_type=0)
I0703 02:57:51.593564000<PHONE_NUMBER>60480 server.cc:944]                grpc_server_create(0x7ff71a900000, 0x0)
I0703 02:57:51.593578000<PHONE_NUMBER>60480 server.cc:930]                grpc_server_register_completion_queue(server=0x7ff71a900520, cq=0x7ff71a900190, reserved=0x0)
I0703 02:57:51.593590000<PHONE_NUMBER>60480 server_chttp2.cc:34]          grpc_server_add_insecure_http2_port(server=0x7ff71a900520, addr=localhost:9015)
I0703 02:57:51.594359000<PHONE_NUMBER>60480 server.cc:1024]               grpc_server_start(server=0x7ff71a900520)
I0703 02:57:51.594384000<PHONE_NUMBER>60480 channel_create.cc:93]         grpc_insecure_channel_create(target=localhost:9015, args=0x7ff71aa001a0, reserved=0x0)
I0703 02:57:51.594488000<PHONE_NUMBER>60480 channel.cc:255]               grpc_channel_get_target(channel=0x7ff71aa01310)
D0703 02:57:51.594498000<PHONE_NUMBER>60480 retry_recv_initial_metadata.cc:155] client_peer_before_call=localhost:9015
I0703 02:57:51.594505000<PHONE_NUMBER>60480 metadata_array.cc:29]         grpc_metadata_array_init(array=0x7fff5efed8c0)
I0703 02:57:51.594511000<PHONE_NUMBER>60480 metadata_array.cc:29]         grpc_metadata_array_init(array=0x7fff5efed8a8)
I0703 02:57:51.594517000<PHONE_NUMBER>60480 metadata_array.cc:29]         grpc_metadata_array_init(array=0x7fff5efed890)
I0703 02:57:51.594523000<PHONE_NUMBER>60480 call_details.cc:31]           grpc_call_details_init(cd=0x7fff5efed9f0)
I0703 02:57:51.594531000<PHONE_NUMBER>60480 call.cc:1983]                 grpc_call_start_batch(call=0x7ff71b000030, ops=0x7fff5efeda50, nops=6, tag=0x1, reserved=0x0)
I0703 02:57:51.594541000<PHONE_NUMBER>60480 call.cc:1593]                 ops[0]: SEND_INITIAL_METADATA(nil)
I0703 02:57:51.594549000<PHONE_NUMBER>60480 call.cc:1593]                 ops[1]: SEND_MESSAGE ptr=0x7ff719403ba0
I0703 02:57:51.594555000<PHONE_NUMBER>60480 call.cc:1593]                 ops[2]: RECV_MESSAGE ptr=0x7fff5efed870
I0703 02:57:51.594562000<PHONE_NUMBER>60480 call.cc:1593]                 ops[3]: SEND_CLOSE_FROM_CLIENT
I0703 02:57:51.594568000<PHONE_NUMBER>60480 call.cc:1593]                 ops[4]: RECV_INITIAL_METADATA ptr=0x7fff5efed8c0
I0703 02:57:51.594576000<PHONE_NUMBER>60480 call.cc:1593]                 ops[5]: RECV_STATUS_ON_CLIENT metadata=0x7fff5efed8a8 status=0x7fff5efed86c details=0x7fff5efed990
D0703 02:57:51.594612000<PHONE_NUMBER>60480 dns_resolver.cc:281]          Start resolving.
I0703 02:57:51.594644000<PHONE_NUMBER>60480 server.cc:1352]               grpc_server_request_call(server=0x7ff71a900520, call=0x7fff5efed8e0, details=0x7fff5efed9f0, initial_metadata=0x7fff5efed890, cq_bound_to_call=0x7ff71a900190, cq_for_notification=0x7ff71a900190, tag=0x65)
I0703 02:57:51.594662000<PHONE_NUMBER>60480 completion_queue.cc:851]      grpc_completion_queue_next(cq=0x7ff71a900190, deadline=gpr_timespec { tv_sec: 10, tv_nsec: 6716501, clock_type: 0 }, reserved=0x0)
D0703 02:57:51.595189000<PHONE_NUMBER>61536 dns_resolver.cc:192]          Resolution successful (OnResolvedLocked r->addresses_ != nullptr)
I0703 02:57:56.599098000<PHONE_NUMBER>98112 completion_queue.cc:630]      cq_end_op_for_next(cq=0x7ff71a900190, tag=0x1, error="No Error", done=0x100ccbdc0, done_arg=0x7ff71b0010a0, storage=0x7ff71b0010a8)
I0703 02:57:56.964738000<PHONE_NUMBER>60480 completion_queue.cc:951]      RETURN_EVENT[0x7ff71a900190]: OP_COMPLETE: tag:0x1 OK
E0703 02:57:56.964760000<PHONE_NUMBER>60480 cq_verifier.cc:273]           cq returned unexpected event: OP_COMPLETE: tag:0x1 OK
E0703 02:57:56.964776000<PHONE_NUMBER>60480 cq_verifier.cc:280]           expected tags:
tag(101) GRPC_OP_COMPLETE success=1 test/core/end2end/tests/retry_recv_initial_metadata.cc:192

https://source.cloud.google.com/results/invocations/dffb74fd-3cb8-4fdf-87ef-5bfd42726b61/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests

I added some extra logging and it seems that the subchannel never connects successfully:
D0703 05:16:04.274869000<PHONE_NUMBER>85856 dns_resolver.cc:281]          Start resolving.
I0703 05:16:04.274893000<PHONE_NUMBER>85856 client_channel.cc:2813]       chand=0x7fbb94d03bc8 calld=0x7fbb978028f0: deferring pick pending resolver result
I0703 05:16:04.274912000<PHONE_NUMBER>85856 server.cc:1352]               grpc_server_request_call(server=0x7fbb94e02440, call=0x7fff5e825730, details=0x7fff5e825800, initial_metadata=0x7fff5e8256d8, cq_bound_to_call=0x7fbb94e02750, cq_for_notification=0x7fbb94e02750, tag=0x65)
I0703 05:16:04.274927000<PHONE_NUMBER>85856 completion_queue.cc:851]      grpc_completion_queue_next(cq=0x7fbb94e02750, deadline=gpr_timespec { tv_sec: 10, tv_nsec: 37337418, clock_type: 0 }, reserved=0x0)
D0703 05:16:04.275534000<PHONE_NUMBER>92928 dns_resolver.cc:192]          Resolution successful (OnResolvedLocked r->addresses_ != nullptr)
I0703 05:16:04.275561000<PHONE_NUMBER>92928 client_channel.cc:314]        chand=0x7fbb94d03bc8: got resolver result: resolver_result=0x7fbb96900250 error="No Error"
I0703 05:16:04.275692000<PHONE_NUMBER>92928 client_channel.cc:434]        chand=0x7fbb94d03bc8: resolver result: lb_policy_name="pick_first" (changed), service_config="(null)"
I0703 05:16:04.275709000<PHONE_NUMBER>92928 client_channel.cc:509]        chand=0x7fbb94d03bc8: initializing new LB policy
I0703 05:16:04.275722000<PHONE_NUMBER>92928 connectivity_state.cc:92]     CONWATCH: 0x7fbb969003b0 pick_first: get IDLE
I0703 05:16:04.275737000<PHONE_NUMBER>92928 connectivity_state.cc:116]    CONWATCH: 0x7fbb969003b0 pick_first: from IDLE [cur=IDLE] notify=0x7fbb96900ea8
I0703 05:16:04.275749000<PHONE_NUMBER>92928 client_channel.cc:177]        chand=0x7fbb94d03bc8: setting connectivity state to IDLE
I0703 05:16:04.275760000<PHONE_NUMBER>92928 connectivity_state.cc:164]    SET: 0x7fbb94d03c78 client_channel: IDLE --> IDLE [new_lb+resolver] error=0x0 "No Error"
I0703 05:16:04.275775000<PHONE_NUMBER>92928 client_channel.cc:2902]       chand=0x7fbb94d03bc8 calld=0x7fbb978028f0: resolver returned, doing LB pick
I0703 05:16:04.275790000<PHONE_NUMBER>92928 client_channel.cc:2741]       chand=0x7fbb94d03bc8 calld=0x7fbb978028f0: applying service config to call
I0703 05:16:04.275804000<PHONE_NUMBER>92928 client_channel.cc:2650]       chand=0x7fbb94d03bc8 calld=0x7fbb978028f0: starting pick on lb_policy=0x7fbb96900350
I0703 05:16:04.275819000<PHONE_NUMBER>92928 connectivity_state.cc:116]    CONWATCH: 0x7fbb96900ce8 subchannel: from IDLE [cur=IDLE] notify=0x7fbb96900268
I0703 05:16:04.275834000<PHONE_NUMBER>92928 connectivity_state.cc:164]    SET: 0x7fbb96900ce8 subchannel: IDLE --> CONNECTING [state_change] error=0x0 "No Error"
I0703 05:16:04.275846000<PHONE_NUMBER>92928 connectivity_state.cc:190]    NOTIFY: 0x7fbb96900ce8 subchannel: 0x7fbb96900268
I0703 05:16:04.275957000<PHONE_NUMBER>92928 connectivity_state.cc:164]    SET: 0x7fbb969003b0 pick_first: IDLE --> CONNECTING [connecting_changed] error=0x0 "No Error"
I0703 05:16:04.275974000<PHONE_NUMBER>92928 connectivity_state.cc:190]    NOTIFY: 0x7fbb969003b0 pick_first: 0x7fbb96900ea8
I0703 05:16:04.275989000<PHONE_NUMBER>92928 connectivity_state.cc:116]    CONWATCH: 0x7fbb96900ce8 subchannel: from CONNECTING [cur=CONNECTING] notify=0x7fbb96900268
I0703 05:16:04.276003000<PHONE_NUMBER>92928 client_channel.cc:189]        chand=0x7fbb94d03bc8: lb_policy=0x7fbb96900350 state changed to CONNECTING
I0703 05:16:04.276015000<PHONE_NUMBER>92928 client_channel.cc:177]        chand=0x7fbb94d03bc8: setting connectivity state to CONNECTING
I0703 05:16:04.276043000<PHONE_NUMBER>92928 connectivity_state.cc:164]    SET: 0x7fbb94d03c78 client_channel: IDLE --> CONNECTING [lb_changed] error=0x0 "No Error"
I0703 05:16:04.276059000<PHONE_NUMBER>92928 connectivity_state.cc:116]    CONWATCH: 0x7fbb969003b0 pick_first: from CONNECTING [cur=CONNECTING] notify=0x7fbb96901c88
I0703 05:16:09.276868000<PHONE_NUMBER>29504 client_channel.cc:2723]       chand=0x7fbb94d03bc8 calld=0x7fbb978028f0: cancelling pick from LB policy 0x7fbb96900350
I0703 05:16:09.276931000<PHONE_NUMBER>29504 client_channel.cc:2705]       chand=0x7fbb94d03bc8 calld=0x7fbb978028f0: pick completed asynchronously
I0703 05:16:09.277121000<PHONE_NUMBER>29504 client_channel.cc:2595]       chand=0x7fbb94d03bc8 calld=0x7fbb978028f0: failed to create subchannel: error={"created":"@1530620169.276977000","description":"Failed to create subchannel","file":"src/core/ext/filters/client_channel/client_channel.cc","file_line":2593,"referenced_errors":[{"created":"@1530620169.276920000","description":"Pick Cancelled","file":"src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc","file_line":189,"referenced_errors":[{"created":"@1530620169.276850000","description":"Deadline Exceeded","file":"src/core/ext/filters/deadline/deadline_filter.cc","file_line":68,"grpc_status":4}]}]}
I0703 05:16:09.277164000<PHONE_NUMBER>29504 client_channel.cc:1192]       chand=0x7fbb94d03bc8 calld=0x7fbb978028f0: failing 1 pending batches: {"created":"@1530620169.276977000","description":"Failed to create subchannel","file":"src/core/ext/filters/client_channel/client_channel.cc","file_line":2593,"referenced_errors":[{"created":"@1530620169.276920000","description":"Pick Cancelled","file":"src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc","file_line":189,"referenced_errors":[{"created":"@1530620169.276850000","description":"Deadline Exceeded","file":"src/core/ext/filters/deadline/deadline_filter.cc","file_line":68,"grpc_status":4}]}]}
I0703 05:16:09.277219000<PHONE_NUMBER>29504 client_channel.cc:3011]       chand=0x7fbb94d03bc8 calld=0x7fbb978028f0: recording cancel_error={"created":"@1530620169.276850000","description":"Deadline Exceeded","file":"src/core/ext/filters/deadline/deadline_filter.cc","file_line":68,"grpc_status":4}
I0703 05:16:09.277256000<PHONE_NUMBER>29504 client_channel.cc:1192]       chand=0x7fbb94d03bc8 calld=0x7fbb978028f0: failing 0 pending batches: {"created":"@1530620169.276850000","description":"Deadline Exceeded","file":"src/core/ext/filters/deadline/deadline_filter.cc","file_line":68,"grpc_status":4}
I0703 05:16:09.277321000<PHONE_NUMBER>29504 completion_queue.cc:630]      cq_end_op_for_next(cq=0x7fbb94e02750, tag=0x1, error="No Error", done=0x101493bb0, done_arg=0x7fbb97802ea0, storage=0x7fbb97802ea8)
I0703 05:16:09.277420000<PHONE_NUMBER>29504 call.cc:638]                  OP[client-channel:0x7fbb978028d0]:  CANCEL:{"created":"@1530620169.276977000","description":"Failed to create subchannel","file":"src/core/ext/filters/client_channel/client_channel.cc","file_line":2593,"referenced_errors":[{"created":"@1530620169.276920000","description":"Pick Cancelled","file":"src/core/ext/filters/client_channel/lb_policy/pick_first/pick_first.cc","file_line":189,"referenced_errors":[{"created":"@1530620169.276850000","description":"Deadline Exceeded","file":"src/core/ext/filters/deadline/deadline_filter.cc","file_line":68,"grpc_status":4}]}]}
I0703 05:16:09.277462000<PHONE_NUMBER>29504 client_channel.cc:2992]       chand=0x7fbb94d03bc8 calld=0x7fbb978028f0: failing batch with error: {"created":"@1530620169.276850000","description":"Deadline Exceeded","file":"src/core/ext/filters/deadline/deadline_filter.cc","file_line":68,"grpc_status":4}
I0703 05:16:09.277478000<PHONE_NUMBER>85856 completion_queue.cc:951]      RETURN_EVENT[0x7fbb94e02750]: OP_COMPLETE: tag:0x1 OK
E0703 05:16:09.277530000<PHONE_NUMBER>85856 cq_verifier.cc:273]           cq returned unexpected event: OP_COMPLETE: tag:0x1 OK
E0703 05:16:09.277576000<PHONE_NUMBER>85856 cq_verifier.cc:280]           expected tags:
tag(101) GRPC_OP_COMPLETE success=1 test/core/end2end/tests/idempotent_request.cc:153

https://source.cloud.google.com/results/invocations/c630d0e4-cc68-4bda-aa73-33ff2488380e/targets/github%2Fgrpc%2Fc_macos_dbg_native/tests

Ok, so from the logs I'm getting is quite obvious that:

the address gets resolved alright
we create an fd and start connecting asynchronously CLIENT_CONNECT: ipv6:[::1]:7072: asynchronously connecting fd 0x7fd65a901040
we don't seem to ever the reach on_writable event  (https://github.com/grpc/grpc/blob/f0375f86e94f9970283e80996e1326b4416ed4da/src/core/lib/iomgr/tcp_client_posix.cc#L131) which seems to be the first callback to be called in the async connect scenario (registered here: https://github.com/grpc/grpc/blob/f0375f86e94f9970283e80996e1326b4416ed4da/src/core/lib/iomgr/tcp_client_posix.cc#L322)

That basically means that there's either a polling problem (we never get a notification that the socket has connected)  or that the connection at the OS level takes very long (the call timeout is 5secs).

recv_initial_metadata test failure from described in https://github.com/grpc/grpc/issues/15599#issuecomment-402112368 also failed in bazel dbg test in the same way: https://source.cloud.google.com/results/invocations/16cddef1-e572-4c04-838f-d711be270aaa/targets/%2F%2Ftest%2Fcore%2Fend2end:h2_full%2Bworkarounds_test@retry_recv_initial_metadata@poller%3Depollex/log

The kokoro workers have been switched to Macos High Sierra images and the problem seems to have gone away (based on analysis of test results of the last 10 days of test runs on master).
There are a few test cases that occasionally fail on macos, but that set is much more well-defined than the pattern of various C tests randomly failing we used to see before. I'll close this issue as resolved.


.domain() and Domain suffixes with two parts (i.e. co.uk)

Technically, URI.js is most likely returning the correct value, however I was wondering how the following issue could be resolved most elegantly:
URI("http://amazon.co.uk").domain()
"co.uk"

... the value I was expecting was "amazon.co.uk".
So, whenever the suffix of a domain consists out of two parts (co.uk, com.tr) domain() returns a value which is not really expected/useful.
Any help for how to treat these composed domain suffixes would be appreciated. Thanks.

I see your point. I must admit that I haven't thought about these xx.tld domains at all. Unless there is a table of second-level-domains (xx.tld), I wouldn't know how to make this happen. (subdomain.db.de here db.de is the actual domain.)
If anyone has any pointers, please let me know.

A bit of research yielded:

~60 SLD-enabled TLDs according to  List of TLDs
example SLDs: *.uk, *.tz, *.br
Mozilla maintained list of "public suffixes" (readme) that are not maintained by their individual NIC (wtf?)
List of Second Level Domains (SLD) (via randomtype) - currently knowing 1400 SLDs (wtf?)

I'm certain I can convert that list of SLDs to some regexp and hook that into .domain() and .tld(). I'm not yet sure if I want to "break" current behavior, though. .tld() currently returns 'uk' for 'foo.co.uk' which may very well be what the implementor expected. If it were to return 'co.uk', how would the 'uk' part be accessed? The alternative would be adding new methods, which is not quite the way to go (for me) either.
I'll have to think about this some more…

Second Level Domains are now properly handled by URI.js Version 1.5.0
var uri = URI("http://www.example.co.uk")
uri.domain() // returns "example.co.uk"
uri.domain(true) // returns "co.uk"
uri.tld() // returns "co.uk"
uri.tld(true) // returns "uk"
uri.tld("co.il") // allowed, since it's a known SLD
uri.tld("foo.bar") // not allowed, since unknown

src/SecondLevelDomains.js contains a list of SLDs (imported from Gaving Miller's Second Level Domains List as well as some regular expressions for testing. This file needs to be loaded (before URI.js) to enable Second Level Domain support.
I hope this helps…

works as expected, i.e. this is awesome! Thanks alot for looking into it!

Felt I should post this here since I've run into a similar issue.
const uri = require('urijs');
const a = new uri('http://torrentz.eu.com');
console.log(a.domain());

The above code outputs eu.com, but I believe the correct result here should be torrentz.eu.com. What would it take to output the expected domain?

@ul1994 I cloned that to #333, fixed the problem and released v1.18.10


Add octave range to music chip

Need to define the octaves of a system in the music chip and the music tool.

This has been added.


Facebook bridge without ratings

Hi,
I don't know if this is normal, but I also get reviews ratings from people in my facebook rss feed. I also get ratings from 2013, 2015 and 2017 listed as newest in the feed.
Is this the intended behaviour?
I'm trying to get an rss feed for the following user and site: mashody from https://www.facebook.com/mashody/?fref=ts
And while I'm already asking: is there a way to just input a facebook link and get the username automatically? I'd like to get the behaviour of fetchrss.com.
Thanks!

I assume you are using the FacebookBridge and not the FB2Bridge (which doesn't return any contents for your particular user on my machine anyway).

I don't know if this is normal, but I also get reviews ratings from people in my facebook rss feed. I also get ratings from 2013, 2015 and 2017 listed as newest in the feed.
Is this the intended behaviour?

Turns out reviews are the same as summary posts (using the same classes), so by design they are automatically split into separate feed items. Reviews naturally contain older items which are then provided as "new". I would in fact call this intended behavior for summary posts. This is the section of code responsible for detecting them: https://github.com/RSS-Bridge/rss-bridge/blob/01a27467156a79e1254761c26f64d095a1634eea/bridges/FacebookBridge.php#L191-L196
It's possible to filter out reviews by checking specifically for id #review_composer_container, identifying reviews. However, this should be optional to prevent breaking user experience.

And while I'm already asking: is there a way to just input a facebook link and get the username automatically? I'd like to get the behaviour of fetchrss.com.

This is absolutely possible for regular links (like the one you provided). I suppose this covers about 99% of all links, so there is no harm supporting it. Some corner cases might fail though.

Hi,
the feed didn't change with the latest version (2018-07-17), so the issue is not yet fixed.
Thanks for your time!

Thanks for the update!
Might be a stupid question: Did you enable the Skip reviews option for your feed? (or add &skip_reviews=on to existing feeds)

If you still see reviews with that option enabled, please post your feed URL again, so I can check what is going on.

I feel quite dumb now......I assume that checkbox was there already when I opened the issue? It looks correct now, there are no reviews anymore.
Sorry for wasting your time with this... :)

I assume that checkbox was there already when I opened the issue?

Nope, this option was added in 4a5f190e0e2dd83f89bf60a6c7598d6c64e4a5c3 (see above)
As long as it works for you, everything is as it should be :smile:


change return key for backspace on emoji keyboard

Hi @danielsaidi thanks for your great keyboard.
in this pr change the "return" key to "backspace" as it currently has the keyboard of the iphone

Cool, thank you!


Using Dates as Linechart X axis

Is this currently supported? If it isn't I can see what it takes to make it work and put in a pull request. It seems like it should be fairly easy though since d3 has some built in libraries for this sort of thing.

@jmuel  From what I know this is currently supported. You can check the source code here. Or you can see the areachart example in the demo page

Hi, @jmuel thanks for opening an issue.  Our axes components do support using dates, but I've not yet expanded the LineChart component to deal with them (in fact, AreaChart is currently the only one that handles dates, but it doesn't handle multiple series yet).  Let me look at how to handle this, since it's going to require special casing in multiple components.  I'll try to fix this in the next day or two, since it's an important feature.

@jmuel I'm thinking of the most flexible tick label interface I can offer users, and yet still avoid having the chart components full of special casing.  What do you think about having something like:
var areaData = [
  {x:<PHONE_NUMBER>000, y: 582.13}, // date is indicated in UNIX time
  {x:<PHONE_NUMBER>000, y: 603}
];
var dateFormatter = d3.time.format("%m-%Y"); // formats date objects as e.g. 12-2015
var tickFormatter = function(d) {
  return dateFormatter(new Date(d)); // We have to turn UNIX time to date object
};
<AreaChart
  data={areaData}
  xAxisTickCount={4}
  xAxisTickFormat={tickFormatter}
/>

With this approach, we're always passing in numbers, specifically seconds since the UNIX epoch, and not date objects.  So how to get the labels we want on the axis ticks?  Well, by putting a function in xAxisTickFormat.
This particular example makes use of d3's powerful time formatter.  Although you could also use any function that takes a number and turns it into a label, I expect d3's time formatter or number formatter would cover most use cases.
We would probably create some easy pre-made functions people could stick in there, which would allow people to pass in a simple formatting string.  So there won't even be a need to make a custom function like I did above.  But when people need flexibility in how to display dates, it's there.
And people could use it for more than dates, of course.  You could make a function to concatenate a currency symbol in front of the number, for example.
This is actually what I had intended to do to begin with, which is why the AreaChart example (incorrectly, I see now) uses UNIX time instead of JS Date objects.
@yang-wei what do you think of this approach?  This would let us avoid the headache of special casing date objects and instead treat everything as a number.  And yet it gives users all the flexibility of d3 in how to format the tick labels.  Behind the scenes, all the d3.time.scale does is use the linear scale with Date objects, with the tick labels automatically formatted.

The main downside I can think of to this approach is that it doesn't account for things like leapyears and daylight savings if you're displaying dates as a long, uniform continuous series.  But at the savings of significant complexity for our library.

Yeah, this seems like the easiest way to do it while still solving most of the problems.

I'm just checking in to see if the work has been done for this. If it hasn't I can take a stab at getting it working like you described.

Yes, it's supported, at least in the multi-series charts, including LineChart.  I forgot to close the issue.
I ended up supporting passing in dates directly, instead of just a formatter (although I'm going to support that soon, as well).  For more, see:
https://github.com/esbullington/react-d3/wiki/Dates
The only chart that doesn't support dates and where dates might make sense is the BarChart, which I plan to convert to support multiple series soon.  At that time, I'll add date support.  But all the other charts support it now.

@jmuel I did want to mention that I haven't yet tested the dates support much, so please let me know if you find any issues -- that would be a big help.

Sure, I played around with it and it's showing time in milliseconds since the Unix epoch instead of a human readable format.

Thanks, did you use an xAccessor to turn the Unix epoch time to Date format?  If so, can you show me your exact code, please?

I tried using the xAccessor.
Here's the project I'm working on.
specifically, the chart creator and the data. I'm trying to follow your second example here (https://github.com/esbullington/react-d3/wiki/Dates)

Oh, you need to specify the xAxisTickInterval.  I just put that example up, and forgot to include that property.
So you'd add something like:
xAxisTickInterval={{unit: 'year', interval: 2}}
or whatever you prefer.
Does that work?

Hmm, still isn't working. I'll see if I can do something simpler to test it.

I just cloned your project and tried to run npm run-script build but it works on the assumption that you have jsx installed globally. If it isn't installed globally it will fail. I tried installing it and rerunning but I'm getting an "unknown option: --harmony" error. These are acting as hidden dependencies and keep me from just downloading, hitting npm install and having a working system.

I had the same thing when I downloaded. You need to install react tools over the top of jsx.
npm i -g react-tools
But yes, the dependencies should be listed.
On Sun, Feb 15, 2015 at 10:06 AM, jmuel<EMAIL_ADDRESS>wrote:

I just cloned your project and tried to run npm run-script build but it works on the assumption that you have jsx installed globally. If it isn't installed globally it will fail. I tried installing it and rerunning but I'm getting an "unknown option: --harmony" error. These are acting as hidden dependencies and keep me from just downloading, hitting npm install and having a working system.
Reply to this email directly or view it on GitHub:
https://github.com/esbullington/react-d3/issues/70#issuecomment-74391934

Thanks, that got it working.

OK, I  see what happened.  You're formatting your dates two times: once in your data object, and then again in the xAccessor.  The easiest solution is probably to remove the xAccessor (the default xAccessor gets the x property, so it should work without an accessor in your case).
But in the future, I'd recommend not doing that in your data -- keep it as pure data, preferably as a CSV or JSON file, so you can reuse it easily in other settings and environments.
You can do any formatting in the xAccessor.

@jmuel you were also pulling in version 1.8 -- you hadn't yet updated to 2.0.  Once I updated and removed the double accessor (and stuck the data directly in the component), it rendered no problem.
And jsx isn't a hidden dependency to the actual react-d3 package.  It's compiled to pure Javascript for the npm release.  JSX is only required for the development build.

Actually, you may have pulled in 2.0, I see you had a caret.  But the double formatting was preventing it from rendering.

@jmuel did you get this working?  If so, I'm going to go ahead and close the issue.

I'm actually running into an issue with "Uncaught TypeError: Cannot read property 'forEach' of undefined" in line 64 of utils/index.js but there's a good chance I just messed something up when changing my data around. I'll let you know when I have it all worked out.

Ok, I set up your docs page and the functionality works. The problems I'm having are in my own project. Go ahead and close it, everything's good now.

Thanks, please let me know if you have any more issues.


Prover no longer holds a Proof

@nwatson22 is this PR blocked by anything? Are we still planning to getting it merged?

Closing in favor of https://github.com/runtimeverification/k/pull/4250.


Add a "Remove All Active Abilities By Class" method on the ASC

Title says it all !
Can be useful to have if you activate several abilities that are children of the given class for example.
I might implement this myself later, leaving this as a TODO :)

Similar to GAS, I was planning on adding a way to remove abilities by tag. I believe GAS has a property for Effects that's "Cancel Abilities With Tag".

This should actually be closed out, as RemoveEffectByTag has been in place for a while now!

Wait, I misread this, it's ability and not effect. :|

Implemented in https://github.com/Aherys/DeepWorlds_GMCAbilitySystem/commit/d814d9ca139bac64ef2d411c48f129ece4b5d988

Is now PR #64

Is now PR #64

Very cool, thanks !

Looking at the code, it looks like it's by tag and not by class, but actually having it by tag is more powerful.

There is both.
	UFUNCTION(BlueprintCallable, DisplayName="End Abilities (By Tag)", Category="GMAS|Abilities")
	// End all abilities with the corresponding tag, returns the number of abilities ended
	int EndAbilitiesByTag(FGameplayTag AbilityTag);

	UFUNCTION(BlueprintCallable, DisplayName="End Abilities (By Class)", Category="GMAS|Abilities")
	// End all abilities with the corresponding tag, returns the number of abilities ended
	int EndAbilitiesByClass(TSubclassOf<UGMCAbility> AbilityClass);```


[BUG/ISSUE] Description is not fully shown if it has more than 1§ (Winget)

I was thinking about commenting on https://github.com/marticliment/WingetUI/issues/481 about the missing manifest parameter in Winget called "ShortDescription", but I don't think it's necessary since you have regular "Description". However, while doing that I've noticed that description isn't completely displayed if it has more than 1§.
See https://github.com/microsoft/winget-pkgs/blob/master/manifests/e/EaseUS/TodoBackup/2022.1/EaseUS.TodoBackup.locale.en-US.yaml
Screenshot:

Thanks to the update to Winget 1.4, and the changes done on 5d177fc, it now works as expected:


Initial GtWorld toolbar

We need an entry toolbar that is built on top of Bloc.

Here is an initial version


/api/report should render the complete report

All Node fields need to be JSON tagged and serialize by default
Use new Prune method to cut away extra fields for /api/topology and websocket handlers

fixes reports used with fixprobe

LGTM!


nice to add my repo to the awesome list

CGraph is a cross-platform DAG(Directed Acyclic Graph) framework based on C++17 without any 3rd-party.
You, with it, can build your own operators simply, and then describe any running schedules as you need, such as dependence, parallelling, aggregation and so on. Some useful tools and plugins are also provided to improve your project.

👍


conf/sa8155p-adp.conf: Add support for building qcs8155p-adp dtb

Add support for building qcs8155p-adp dtb.
Basically both the sa8155p-adp and qcs8155p-adp boards
use the same adp motherboard but have different
SoC daughter cards mounted on the adp motherboard
respectively.
Signed-off-by: Bhupesh Sharma<EMAIL_ADDRESS>

LGTM


Adding snooze function and small fix on initial setting locale for moment.

This adds snooze function and fixes the issue that the first alarm after startup is displayed in English instead of the chosen locale.
Sorry, this is the first time I am doing a pull request and it added my second change to it. Still figuring out how to do 2 separate pull requests.

Thanks for your fix! Much appreciated!!


getting hold of a bitmapfont's texture

hi
I'm trying to draw lots of labels (rectangles plus text) using a bitmap font and ideally I'd like to use part of the bitmap font's texture as a 4x4 white rectangle as the rectangle background.
I'm having difficulty trying to figure out how to do this ?
Any ideas welcome ^_^

Hey @englercj is this possible in v3?

Sure it is! You can get the base texture from the asset loader when you load it, or look in BitmapText.fonts for your fonts character textures and you can get the base texture from those as well. What is giving you trouble?

Closing this since it seems answered.


Bugfix: uninitialised buffer access in NEGEMMConvolutionLayer can lea…

…d to invalid results
I implemented a vgg16-fcn8 model that worked fine with 18.01, but predicts nan's since 18.02.
Finally time for debugging it: 1x1 NEON Convolution Layer, utilising NEGEMMConvolutionLayer inside access uninitialised memory leading to invalid results.

We don't seem to be able to reproduce the issue, could you please share a reproducer case ?
We've got a demo running on Hikey 960 that runs multiple times VGG16 and it seems to work as expected.

Thank you for the quick response.
It seems the nan problem on hikey960 is different to the qemu one. My first convolution layer(NEConvolutionLayer) has padding=100. The default used winograd convolution does not support this padding and fails silently. Replacing the first convolution layer with NEGEMMConvolutionLayer fixes the problem on hikey960 for me.
On qemu the nan problem persists and above patch fixes it. But qemu was just a stop-gap solution for me anyway.

If you compile with asserts=1 you should hopefully have more information.
It should only silently fail in release mode.


🐛 Bug Report: TechDocsAddons breaks rendering Tech Docs pages after updating to 1.8

📜 Description
Updated from version 1.7.0 -> 1.8.3 using yarn backstage-cli versions:bump. After the upgrade, all tech docs pages failed to render.
The <TechDocsAddons> component from @backstage/plugin-techdocs-react breaks rendering of tech docs pages. There is no error output in the browser console or logs, as if perhaps there's a null check that doesn't render if data is missing. If the section is commented out, the page loads as expected. This behavior only occurs when children are nested underneath the component. i.e.,
      <TechDocsAddons>
        <ReportIssue />
      </TechDocsAddons>

I also tried rendering the Mermaid addon underneath and got the same behavior. If you leave it without children, nothing breaks.
A search through Discord showed other people experiencing similar behavior as early as 1.8.2. I'm trying to bump to 1.8.3, but I'm not sure which specific version is causing the problem.
👍 Expected behavior
TechDocsAddons component can be used on TechDocs pages without rendering issues.
👎 Actual Behavior with Screenshots
Page fails to render any content:

No console errors or logs indicating anything is wrong.
👟 Reproduction steps
Have a project that is using the TechDocsAddons component when rendering TechDocs on version 1.7.*. Use any addon as a child.
Upgrade backstage using the cli command yarn backstage-cli versions:bump to bring everything up to the latest version.
View TechDocs pages.
📃 Provide the context for the Bug.
Removing TechDocsAddons works as a temporary work-around, but I'd like to continue using addons. I am waiting on the upgrade for my project until we can fix.
🖥 Your Environment
OS:   Darwin 21.6.0 - darwin/x64
node: v16.18.1
yarn: 1.22.0
cli:  0.21.1 (installed)
backstage:  1.8.3
Dependencies:
@backstage/app-defaults                          1.0.8
@backstage/backend-common                        0.15.2, 0.16.0
@backstage/backend-plugin-api                    0.1.4
@backstage/backend-tasks                         0.3.7
@backstage/catalog-client                        1.1.2
@backstage/catalog-model                         1.1.3
@backstage/cli-common                            0.1.10
@backstage/cli                                   0.21.1
@backstage/config-loader                         1.1.6
@backstage/config                                1.0.4
@backstage/core-app-api                          1.2.0
@backstage/core-components                       0.12.0, 0.9.5
@backstage/core-plugin-api                       1.1.0
@backstage/dev-utils                             1.0.8
@backstage/errors                                1.1.3
@backstage/integration-react                     1.1.6
@backstage/integration                           1.4.0
@backstage/plugin-adr-backend                    0.2.3
@backstage/plugin-adr-common                     0.2.3
@backstage/plugin-adr                            0.2.3
@backstage/plugin-api-docs                       0.8.11
@backstage/plugin-app-backend                    0.3.38
@backstage/plugin-auth-backend                   0.17.1
@backstage/plugin-auth-node                      0.2.7
@backstage/plugin-catalog-backend-module-github  0.2.1
@backstage/plugin-catalog-backend                1.5.1
@backstage/plugin-catalog-common                 1.0.8
@backstage/plugin-catalog-graph                  0.2.23
@backstage/plugin-catalog-import                 0.9.1
@backstage/plugin-catalog-node                   1.2.1
@backstage/plugin-catalog-react                  1.2.1
@backstage/plugin-catalog                        1.6.1
@backstage/plugin-cloudbuild                     0.3.11
@backstage/plugin-github-actions                 0.5.11
@backstage/plugin-home                           0.4.27
@backstage/plugin-org                            0.6.1
@backstage/plugin-permission-common              0.7.1
@backstage/plugin-permission-node                0.7.1
@backstage/plugin-permission-react               0.4.7
@backstage/plugin-proxy-backend                  0.2.32
@backstage/plugin-scaffolder-backend             1.8.0
@backstage/plugin-scaffolder-common              1.2.2
@backstage/plugin-scaffolder                     1.8.0
@backstage/plugin-search-backend-module-pg       0.4.2
@backstage/plugin-search-backend-node            1.0.4
@backstage/plugin-search-backend                 1.1.1
@backstage/plugin-search-common                  1.1.1
@backstage/plugin-search-react                   1.2.1
@backstage/plugin-search                         1.0.4
@backstage/plugin-stack-overflow                 0.1.7
@backstage/plugin-tech-radar                     0.5.18
@backstage/plugin-techdocs-backend               1.4.1
@backstage/plugin-techdocs-module-addons-contrib 1.0.6
@backstage/plugin-techdocs-node                  1.4.2
@backstage/plugin-techdocs-react                 1.0.6
@backstage/plugin-techdocs                       1.4.0
@backstage/plugin-user-settings                  0.5.1
@backstage/release-manifests                     0.0.7
@backstage/test-utils                            1.2.2
@backstage/theme                                 0.2.16
@backstage/types                                 1.0.1
@backstage/version-bridge                        1.0.2
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, I don't have time to work on this right now

@realandersn @agentbellnorm, would this be related to #14323?

I am seeing this as well, both running in docker locally on macOS and deployed to a kubernetes cluster in EKS.

@Rugvip Possibly! We're looking into it right now.

Hey there @ciprianna! 👋
Thanks for reporting, we are currently trying to reproduce the issue. There are multiple ways on how you can set up TechDocs for you Backstage instance, and we would need to know how your setup roughly looks like.
You mentioned this snippet above:
<TechDocsAddons>
  <ReportIssue />
</TechDocsAddons>

What <Route> are you using around it? And what element and children props does it have?

Hello, @ottosichert  - thanks for getting back to me on this! Appreciate you all looking into it.
Here's the full snippet:
<FlatRoutes>

  <Route
    path="/docs/:namespace/:kind/:name/*"
    element={<TechDocsReaderPage />}
  >
    <TechDocsAddons>
      <ReportIssue />
      <Mermaid config={{ theme: 'forest', themeVariables: { lineColor: '#000000' } }} />
    </TechDocsAddons>
  </Route>

</FlatRoutes>

I can confirm this is happening in 1.8.2 and 1.8.3 using the same setup as @ciprianna.
Removing the <Mermaid config={{ theme: 'forest', themeVariables: { lineColor: '#000000' } }} /> component renders the docs correctly, but some JS errors are thrown in console:
Material-UI: The `fade` color utility was renamed to `alpha` to better describe its functionality.

You should use `import { alpha } from '@material-ui/core/styles'`

And:
react-dom.development.js:67 Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.
    at div
    at Grid (webpack-internal:///../../node_modules/@material-ui/core/esm/Grid/Grid.js:235:35)
    at WithStyles (webpack-internal:///../../node_modules/@material-ui/styles/esm/withStyles/withStyles.js:61:31)
    at div
    at Grid (webpack-internal:///../../node_modules/@material-ui/core/esm/Grid/Grid.js:235:35)
    at WithStyles (webpack-internal:///../../node_modules/@material-ui/styles/esm/withStyles/withStyles.js:61:31)
    at p
    at Typography (webpack-internal:///../../node_modules/@material-ui/core/esm/Typography/Typography.js:165:28)
    at WithStyles (webpack-internal:///../../node_modules/@material-ui/styles/esm/withStyles/withStyles.js:61:31)
    at HeaderLabelContent (webpack-internal:///../../node_modules/@backstage/core-components/dist/index.esm.js:6315:31)
    at a
    at Typography (webpack-internal:///../../node_modules/@material-ui/core/esm/Typography/Typography.js:165:28)
    at WithStyles (webpack-internal:///../../node_modules/@material-ui/styles/esm/withStyles/withStyles.js:61:31)
    at Link (webpack-internal:///../../node_modules/@material-ui/core/esm/Link/Link.js:85:23)
    at WithStyles (webpack-internal:///../../node_modules/@material-ui/styles/esm/withStyles/withStyles.js:61:31)
    at eval (webpack-internal:///../../node_modules/@backstage/core-components/dist/index.esm.js:545:6)
    at span
    at div
    at Grid (webpack-internal:///../../node_modules/@material-ui/core/esm/Grid/Grid.js:235:35)
    at WithStyles (webpack-internal:///../../node_modules/@material-ui/styles/esm/withStyles/withStyles.js:61:31)
    at HeaderLabel (webpack-internal:///../../node_modules/@backstage/core-components/dist/index.esm.js:6319:11)
    at div
    at Grid (webpack-internal:///../../node_modules/@material-ui/core/esm/Grid/Grid.js:235:35)
    at WithStyles (webpack-internal:///../../node_modules/@material-ui/styles/esm/withStyles/withStyles.js:61:31)
    at header
    at Header (webpack-internal:///../../node_modules/@backstage/core-components/dist/index.esm.js:6201:5)
    at TechDocsReaderPageHeader (webpack-internal:///../../node_modules/@backstage/plugin-techdocs/dist/esm/index-847211c1.esm.js:1955:11)
    at main
    at ThemeProvider (webpack-internal:///../../node_modules/@material-ui/styles/esm/ThemeProvider/ThemeProvider.js:41:24)
    at Page (webpack-internal:///../../node_modules/@backstage/core-components/dist/index.esm.js:6411:11)
    at TechDocsReaderLayout (webpack-internal:///../../node_modules/@backstage/plugin-techdocs/dist/esm/index-847211c1.esm.js:2090:3)
    at AnalyticsContext (webpack-internal:///../../node_modules/@backstage/core-plugin-api/dist/index.esm.js:71:11)
    at eval (webpack-internal:///../../node_modules/@backstage/plugin-techdocs-react/dist/index.esm.js:147:6)
    at TechDocsReaderPage$1 (webpack-internal:///../../node_modules/@backstage/plugin-techdocs/dist/esm/index-847211c1.esm.js:2100:114)
    at RoutableExtensionWrapper (webpack-internal:///../../node_modules/@backstage/core-plugin-api/dist/index.esm.js:536:15)
    at PluginProvider (webpack-internal:///../../node_modules/@backstage/core-plugin-api/dist/index.esm.js:297:11)
    at AnalyticsContext (webpack-internal:///../../node_modules/@backstage/core-plugin-api/dist/index.esm.js:71:11)
    at PluginErrorBoundary (webpack-internal:///../../node_modules/@backstage/core-plugin-api/dist/index.esm.js:504:5)
    at Suspense
    at Result (webpack-internal:///../../node_modules/@backstage/core-plugin-api/dist/index.esm.js:599:21)
    at D (webpack-internal:///../../node_modules/react-router/index.js:35:685)
    at FlatRoutes (webpack-internal:///../../node_modules/@backstage/core-app-api/dist/index.esm.js:2904:81)
    at div
    at SidebarPinStateProvider (webpack-internal:///../../node_modules/@backstage/core-components/dist/index.esm.js:3662:11)
    at SidebarPage (webpack-internal:///../../node_modules/@backstage/core-components/dist/index.esm.js:3711:82)
    at Root (webpack-internal:///./src/components/Root/Root.tsx:108:17)
    at D (webpack-internal:///../../node_modules/react-router/index.js:35:685)
    at E (webpack-internal:///../../node_modules/react-router/index.js:38:820)
    at SignInPageWrapper (webpack-internal:///../../node_modules/@backstage/core-app-api/dist/index.esm.js:2739:18)
    at x (webpack-internal:///../../node_modules/react-router/index.js:37:23)
    at w (webpack-internal:///../../node_modules/react-router-dom/index.js:42:23)
    at AppRouter (webpack-internal:///../../node_modules/@backstage/core-app-api/dist/index.esm.js:2755:26)
    at RoutingProvider (webpack-internal:///../../node_modules/@backstage/core-app-api/dist/index.esm.js:2201:3)
    at CssBaseline (webpack-internal:///../../node_modules/@material-ui/core/esm/CssBaseline/CssBaseline.js:66:31)
    at WithStyles (webpack-internal:///../../node_modules/@material-ui/styles/esm/withStyles/withStyles.js:61:31)
    at ThemeProvider (webpack-internal:///../../node_modules/@material-ui/styles/esm/ThemeProvider/ThemeProvider.js:41:24)
    at Provider (webpack-internal:///../../node_modules/@backstage/app-defaults/dist/index.esm.js:329:18)
    at AppThemeProvider (webpack-internal:///../../node_modules/@backstage/core-app-api/dist/index.esm.js:2444:29)
    at AppContextProvider (webpack-internal:///../../node_modules/@backstage/core-app-api/dist/index.esm.js:2322:3)
    at ApiProvider (webpack-internal:///../../node_modules/@backstage/core-app-api/dist/index.esm.js:77:11)
    at Provider (webpack-internal:///../../node_modules/@backstage/core-app-api/dist/index.esm.js:2648:25)
    at App

@ivanaguilario  - I experience this issue trying to render any add-on. If I remove Mermaid and leave it with just <ReportIssue /> the page fails to render.

@ciprianna can confirm it only works like this:
    <TechDocsAddons>
    </TechDocsAddons>

Yes, @ivanaguilario  - same behavior for me. It renders correctly without any children. 👍🏻

@dmckernanacv Yes, I can confirm it works when rendering the docs in the Catalog with the plugin enabled

@dmckernanacv  - same for me. It renders in the Catalog Docs tab as expected.

this happened to me as well

if its any help, the issue happens right here where we seem to be stuck in a loop for sometime until the it we get the error
index.esm.js:290 Uncaught TypeError: Cannot read properties of undefined (reading 'getSelection')
at HTMLDocument. (index.esm.js:290:43)
at H (debounce.js:95:19)
at un (debounce.js:144:14)
at J (debounce.js:132:14)

Quick update:
We haven't been able to reproduce issue yet with the TechDocs configuration above. We set up a test repository with the steps below, and we would greatly appreciate if one of you who are affected can provide us with either an example repository where the issue surfaces, or fork the test repository:

https://github.com/agentbellnorm/15126-repro-stage

Our steps trying to reproduce:

npx @backstage/create-app
Already contains TechDocs route structure like above (just without <MermaidAddon>)
yarn backstage-cli info => Backstage 1.8.0
yarn dev => TechDocs renders correcty ✅
backstage-cli versions:bump --release 1.8.3
yarn dev => TechDocs still renders correcty ✅

Just to add to @ottosichert 's comment, we also

Installed<EMAIL_ADDRESS>Added this documentation component: https://github.com/realandersn/backstage-docs-test/blob/master/component-info.yaml
Added the addon to the addons section in App.tsx link

Quick update:
We haven't been able to reproduce issue yet with the TechDocs configuration above. We set up a test repository with the steps below, and we would greatly appreciate if one of you who are affected can provide us with either an example repository where the issue surfaces, or fork the test repository:

https://github.com/agentbellnorm/15126-repro-stage

Our steps trying to reproduce:

npx @backstage/create-app
Already contains TechDocs route structure like above (just without <MermaidAddon>)
yarn backstage-cli info => Backstage 1.8.0
yarn dev => TechDocs renders correcty ✅
backstage-cli versions:bump --release 1.8.3
yarn dev => TechDocs still renders correcty ✅

@ottosichert  just to confirm you also have the reportissue add-on enabled right?
<TechDocsAddons>
  <ReportIssue />
</TechDocsAddons>

for everyone stuck on this, I managed to resolve this by comparing and upgrading my dependancy in package.json
"@backstage/plugin-techdocs": "^1.4.0",
"@backstage/plugin-techdocs-module-addons-contrib": "^1.0.6",
"@backstage/plugin-techdocs-react": "^1.0.6",
"react-router": "6.3.0",
"react-router-dom": "6.3.0"
It rendered for me

for everyone stuck on this, I managed to resolve this by comparing and upgrading my dependancy in package.json
"@backstage/plugin-techdocs": "^1.4.0", "@backstage/plugin-techdocs-module-addons-contrib": "^1.0.6", "@backstage/plugin-techdocs-react": "^1.0.6", "react-router": "6.3.0", "react-router-dom": "6.3.0"
It rendered for me

Looks like that fixed it for us too.
Not sure how that dependency update was missed, we use the command line tool for generating upgrades, looks like it was updated with version 1.7.0.
I just checked our PR for upgrading to 1.7.0 and sure enough, react-router and react-router-dom had no changes.

@dmckernanacv @omartheironman  Ok, yes we have some code in the more recent versions of @backstage/plugin-techdocs to handle react router v6. I don't expect it to work with older versions.
What versions of react-router and ´react-router-dom´ did you use before you bumped today?

Mine was on
    "react-router": "6.0.0-beta.0",
    "react-router-dom": "6.0.0-beta.0",

Which seems to have been used prior to backstage 1.7.0

mine was set to
"react-router": "6.0.0-beta.0",
"react-router-dom": "6.0.0-beta.0",
as well

@agentbellnorm @dmckernanacv  I am also seeing this when I open a document also when I select a text nothing happens

@agentbellnorm @dmckernanacv I am also seeing this when I open a document also when I select a text nothing happens

I'm not seeing this issue

@agentbellnorm  should I open another issue for this?

Yes, ours is on
    "react-router": "6.0.0-beta.0",
    "react-router-dom": "6.0.0-beta.0",

When we upgrade to latest, everything is working as expected 🎉
    "react-router": "^6.4.5",
    "react-router-dom": "^6.4.5",

I'll close this since react-router updates resolve the issue. Thanks so much for digging into it!

I think those warnings only show when running locally. They should definitely be fixed, but I'm fairly certain they're not relevant to this issue.
@omartheironman

@agentbellnorm should I open another issue for this?

Please do! 💯
Regarding the versions you both referred to, They're technically supported since it's in the version range of the peer dependencies. But I have been able to confirm in the test-repo we created that downgrading to
"react-router": "6.0.0-beta.0",
"react-router-dom": "6.0.0-beta.0",

indeed produces the error.
Hard to say why, but unless anyone has a valid use case for staying on the beta versions, I agree with closing this issue with the solution being to upgrade react-router and react-router-dom.
Big thanks to everyone for quick responses! 🥇

I would like to add that there may be a bug with the version:bump cli then, as we've upgraded every minor version available and it somehow missed those dependencies (I'm assuming the others faced this as well?)

@dmckernanacv the version:bump command only bumps @backstage/* packages by default, although you can ask it to bump other packages too. The react-router one in particular is something we didn't want to force people to do, but rather have it be a migration that you can do at your own pace.
@agentbellnorm as mentioned ^, we're still looking to support React Router v6 beta for now. We'll most likely keep supporting it in the core until v2, but that doesn't mean that all plugins need to support it. Still, I think it might be worth a small amount of effort to see if we can keep support for beta still.

#15312 Adds backwards compatibility with 6.0.0-beta.0 👍


Ability to color edges by a value

Edge colors should be able to be colored using a value instead of a static color.
There will have to be 2 legends, one for the nodes and one for the edges.

Thank you for D3plus! I'm very new to it- is there now a way to make edges different colors based on a value? Thanks, S


fix TestNginx on inbound filter chain

Detected TestNginx test failure in my experiment of switching inbound envoy listeners using filter chain
Comparing with envoy as ingress gateway, nginx as ingress gateway needs an outbound sidecar proxy to support mtls.
So the iptables need to configured

do not capture inbound traffic  to bypass mtls check
capture outbound traffic to carry mtls identification

Before inbound filter chain was introduced, the only solution is to set includeInboundPorts as empty so that istio won't fill it with containerPorts
Once switching to inbound listener using filter chain by setting includeInboundPorts to "*", the nginx owner need to explicit whitelist bypassing port through excludeInboundPorts as in this PR.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[X] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

So did we make a breaking change then? Was this intentional? Is it in the release notes?

I am gathering the user needed change from test failure.
I will add to releasing notes. BTW where is the note?

@silentdai: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

https://github.com/istio/istio/wiki/Release-Note-1.3-Draft
On Mon, Aug 12, 2019 at 3:37 PM Yuchen Dai<EMAIL_ADDRESS>wrote:

I am gathering the user needed change from test failure.
I will add to releasing notes. BTW where is the note?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/16213?email_source=notifications&email_token=AAEYGXMGFZ3LHL4B6K5VN2TQEHQ27A5CNFSM4ILFQ5AKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4EATNQ#issuecomment-520620470,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEYGXPBDBPA6ENTDZEEGI3QEHQ27ANCNFSM4ILFQ5AA
.

Most of the service owner doesn't need to change the spec but I am afraid so if user has self-defined capture annotation. Added in 1.3 release notes draft

@silentdai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test integ-new-install-k8s-presubmit-tests-master

integ-mixer-k8s-presubmit-tests-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test integ-mixer-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

And this is why we have tests :)

@silentdai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-presubmit-tests-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test integ-new-install-k8s-presubmit-tests-master

integ-mixer-k8s-presubmit-tests-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test integ-mixer-k8s-presubmit-tests-master

istio-racetest-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@silentdai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test integ-mixer-k8s-presubmit-tests-master

istio-racetest-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test istio-racetest-master

integ-new-install-k8s-presubmit-tests-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@silentdai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-presubmit-tests-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test integ-mixer-k8s-presubmit-tests-master

integ-new-install-k8s-presubmit-tests-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test integ-new-install-k8s-presubmit-tests-master

istio-racetest-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test istio-racetest-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@silentdai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio-racetest-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test istio-racetest-master

integ-new-install-k8s-presubmit-tests-master
06e296ee58dd21f9a037daba57aa69511eb2ebbe
link
/test integ-new-install-k8s-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Glad I spotted this...


Currently failing due to missing libssl1.0.2 package

The bigbluebutton packages fail to install due to bbb-freeswitch depending on the missing libssl1.0.2 package. The script doesn't detect this failure, doesn't identify the missing package, and doesn't make it easy to retry the installation once you have resolved that problem.

I worked around this by copying the libssl1.0.2 package from another machine's apt cache and running the last few install steps manually.


doc: ipc: Add detailed protocol specification for ICBMsg backend

The details of how the ICBMsg communication is done, are hidden inside the source code. This specification adds details about the ICBMsg protocol.

Direct link to docs:
https://builds.zephyrproject.io/zephyr/pr/77229/docs/services/ipc/ipc_service/backends/ipc_service_icbmsg.html#detailed-protocol-specification


Incorrect switching with identical files in different directories

Hi
I have a project that contains in two different folders, the same files.
The plugin does not switch correctly between *.h and *.cpp if another file was opened earlier.
For example
folder1/rtsp.h
folder1/rtsp.cpp
folder2/rtsp.h
folder2/rtsp.cpp
If I open folder1/rtsp.h then switch to folder1/rtsp.cpp (:Ouroboros) it works correctly, then I open folder2/rtsp.h and try to switch (:Ouroboros), the switch will be to the earlier opened buffer ( folder1/rtsp.cpp).

Confirmed this is an issue. I'll take a look at some point, but it might be a while as I've been really busy (hence my 4-month later reply here)... PRs always welcome :)

I believe I just fixed this in the latest merge. Please let me know if you still encounter problems!


Mismatch between extract and database

@meomancer I did a little testing of the Zimbabwe shapefile download and it seems there is a bit of a mismatch between what the download provides (red) and what directly querying the PG database provides (green):

Is this simply because we have a lot of Zimbabwe data that is uploaded to HS.io that is not in OSM yet or can you see any other reason for this?

hi @timlinux
i think the missmatch one is the healthsites that can't be linked on osm (can't be found on osm)
i haven't created it on osm, because we need method to link it (because when we create on osm, there is no osm_id and osm_type yet)
currently i do a test to create osm data when healthsite is created, by link with the pk of osm record

did you query through HS data?
i think the missmatch one is those healthsites can't be linked on osm (can't be found on osm)
i haven't created it on osm, because we need method to link it (because we need to create osm data but there is no osm_id to be linked)
currently i do a test to create osm data when healthsite is created, by link with the pk of osm record

this is already fixed, because we are already using osm data (without using old healthsite anymore)


runmqserver: fix/improve verifySingleProcess

A couple of patches to improve the runmqserver check for being the only process.
1. cmd/runmqserver.verifySingleProcess: optimize
Instead of using ps, which reads three /proc files per each process
(stat, status, and cmdline), use pgrep which only reads cmdline.
Also, pgrep output is simpler -- it only lists PIDs, one per line,
so to find out the number of processes we just need to count newlines.
2. cmd/runmqserver.verifySingleProcess: improve

Check command.Run error, print it out (as debug only).

Simplify verifyOnlyOne() return values (bool is enough).

Add more logging.

@sdmarshall79 @parrobe @LPowlett PTAL
CI failure is unrelated:

Step 3/103 : FROM registry.redhat.io/ubi8/go-toolset:1.13.4-22 as builder
Get https://registry.redhat.io/v2/ubi8/go-toolset/manifests/1.13.4-22: unauthorized: Please login to the Red Hat Registry using your Customer Portal credentials. Further instructions can be found here: https://access.redhat.com/RegistryAuthentication
Makefile:267: recipe for target 'build-devserver' failed
make: *** [build-devserver] Error 1
The command "bash -e travis-build-scripts/run.sh" exited with 2.

CI failure is unrelated:

Apparently $(REGISTRY_USER) and $(REGISTRY_PASS) are not set in Travis?


Recalls was not implemented in example

The example was trying to filter based on number of recalls, but Recalls was not implemented or assigned. I added it real quick so the demo worked properly. The fmt package was also missing from imports, which mt IDE added automatically.)

I am not sure how building failed as I only made a slight adjustment to the readme file. : /


Scenario.add() does not show scenario names with ValueError when the end date is not correct

Summary
Scenario.add() needs to show scenario name with ValueError when the end date is not correct. Scenario name is necessary when finding the cause of errors.
(Optional) Related classes

covsirphy.Scenario

Codes and outputs:
import covsirphy as cs
# Dataset preparation
data_loader = cs.DataLoader("input")
jhu_data = data_loader.jhu()
population_data = data_loader.population()
# Scenario analysis
snl = cs.Scenario(jhu_data, population_data, "Japan")
snl.last_date = "10Oct2020"
snl.trend()
snl.add(end_date="01Oct2020")

Environment

CovsirPhy version: 2.8.3
Python version; 3.8
Installation: pipenv
OS: WSL (Ubuntu)

This will be included in version 2.9.0


vim/lsp/utils.lua:2131: attempt go get length of local 'line' (a nil value)

i found a wired thing recently, i have mapped <leader>v for using oscyank in visual mode. when i coding golang, after i use the mapping to copy things, then the error in the issue title poped up.
the full stack is:
Error executing vim.schedule lua callback: ...lar/neovim/0.9.0/share/nvim/runtime/lua/vim/lsp/util.lua:2131: attempt to get length of local 'lin
e' (a nil value)
stack traceback:
        ...lar/neovim/0.9.0/share/nvim/runtime/lua/vim/lsp/util.lua:2131: in function 'character_offset'
        ...lar/neovim/0.9.0/share/nvim/runtime/lua/vim/lsp/util.lua:2054: in function 'make_given_range_params'
        ...rs/aaron/.local/share/nvim/lazy/go.nvim/lua/go/inlay.lua:48: in function 'get_params'
        ...rs/aaron/.local/share/nvim/lazy/go.nvim/lua/go/inlay.lua:290: in function ''
        vim/_editor.lua: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>
Press ENTER or type command to continue

the stack traces back to go.nvim inlay, i want to know if this a issue related to go.nvim.
BTW, when i coding other language, all things are fine. and the oscyank plugin i use is:   "ojroques/nvim-osc52".

any thoughts?

I have not seen this so far and my guess is that it may relate to run inlay in a buffer LSP not setup correctly. I had made some changes to make sure inlay will only run when gopls is attached.


Be able to forward controllers to another

$this->responder->forward;
$this->router->forward();...
or simply pass the controller and call it directly
__construct($displayController)
__invoke() {
if () {
return $displayController();
}
}

Depends on Router, not applicable to Application package


Add serialization options for raw data

The destination of some data will be data stores like HBase or Mongo etc which can support optimized object storage.  If we can do that packaging on data capture the balance of the pipeline will benefit from this.

Serialized output is useful, but different output formats in general e.g. JSON would be more helpful initially. So I am starting with JSON


API 3.0.0-ALPHA6 to ALPHA7?

Can you possibly do the changed things from the api 3.0.0-ALPHA6 to the 3.0.0-ALPHA7?

Yes. I'll be working on that soon. Just need to finish PSM.

That is something needed as ALPHA7 did have some breaking changes as every ALPHA build does. Standby and when PSM is complete we will work on this.

This issue will be closed for spam sake, this does not mean we cannot help but this is a WIP. Reply to this if you require any more information on this topic.


feat(FIAP-56): php 8.1 upgrade

LGTM, @haeber wanna have a look? this is only used for the pdf lib on candidate stuff

LGTM, @haeber wanna have a look? this is only used for the pdf lib on candidate stuff

Actually I would be bold and remove the now not working code, too.

LGTM, @haeber wanna have a look? this is only used for the pdf lib on candidate stuff

Actually I would be bold and remove the now not working code, too.

Tried it myself, this library is really outdated, there are to much problems:

PHPUnit deprecations
charset problems
a lot of work to make it clean


error： potentially unavailable with '@available'

.../node_modules/react-native-native-mqtt/ios/Libraries/CocoaMQTT/CocoaMQTTTypes.swift:66:6: Enum cases with associated values cannot be marked potentially unavailable with '@available'

Did you solve it? I upgraded to Xcode 13 and also encountered this problem

I am guessing this repo is no longer supported.

Same issue.

@askie @15638228357
try npm i https://github.com/zivost/rn-native-mqtt.git
requires minimum deployment to be 13 and react-native version 0.61

getting same error, how to fix?

try this
https://github.com/emqx/CocoaMQTT/pull/391/files/520d3c30f3792f2cd39a6b95712043adca65abde


[SVT-04M] Incorrect Vault Factory Fee Integration

SVT-04M: Incorrect Vault Factory Fee Integration

Type
Severity
Location

Logical Fault

StackVault.sol:L705, L994-L995

Description:
The StackVault::_flashloanFeeReceived function that is invoked as part of the SingleTokenFlashloanProvider workflow will improperly transfer collateral towards the factory before invoking its VaultFactory::collectFees function when instead it should perform an approval as indicated by the factory's code.
Impact:
Flash loans will be inexecutable due to the impossibility of collecting the fees from their repayment.
Example:
/**
 * @notice Handles the fee received from a flash loan.
 * @dev Internal function to manage the distribution or handling of fees earned from providing flash loans.
 * @param feeAmount The amount of fee received from the flash loan.
 */
function _flashloanFeeReceived(uint256 feeAmount) internal override {
    emit FlashloanFeeReceived(feeAmount);
    StackVaultStorage storage $ = _getStackVaultStorage();
    address factory = $._factory;
    _transferCollateralOut(factory, feeAmount);
    IVaultFactory(factory).collectFees(address(collateralToken), feeAmount);
}

Recommendation:
We advise an approval operation to be properly performed, ensuring fees are correctly collected as part of a flash loan repayment.

No longer relevant as flashloan functionality has been removed from vaults.


can add quick view DDL?

i hope click table name and quick view DDL info
thanks!
You guys are the best!

Hello @yanglanxing,
You can use the Generate SQL command to accomplish that. Is that what you need?

i now that
but is not quick and easy
Click on the table name and display the DDL, like Navicat easy

Can you please provide more information regardless your request? A video showing this feature in navicat would be enough.

I'm not sure what's the point of adding yet another way of viewing the DDL of an object.
What's wrong with the Generate SQL approach? It takes two clicks. Otherwise, you can open the table, select the DDL tab and view it there.
We can add support for shortcuts, so you can assign one to the Generate SQL command.

I think it's useful for a quick look at table structures.  For example, when I need to copy a field quickly, compare the field at development time.

Thanks for the explanation.