'App Logs' tile not present in 'Availability and Performance' or 'Web App Down' tabs

Hi, the screenshots on this page show an 'App Logs' tile under the 'Availability and Performance' tabs, but this is not present in any of our web apps. Also, your screenshots show a 'Web App Logs' category in the list under the 'Web App Down' tab, but again this is not present. Is there a prerequisite that needs to be enabled for 'App Logs' solutions to appear in the Diagnostics and Performance tab?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd8426b2-dbe5-9a46-4045-55cc26806641
Version Independent ID: 99eef6e6-7978-1008-4d6f-a5ae566a6305
Content: Diagnostics and solve tool - Azure App Service
Content Source: articles/app-service/overview-diagnostics.md
Service: app-service
GitHub Login: @Jen7714
Microsoft Alias: jennile

@loopfish Thanks again for the feedback! The screenshot in the document is captured from a Linux Web App which has a different set of diagnostic reports in Diagnose and Solve Problems.
For Windows web app, suggest you view the Application Event Logs. You can get to Application Event Logs by searching “Application Event Logs” in the search bar or going to Diagnostics Tools -> Application Event Logs.

@loopfish Since We didn’t hear back from you. We will now close this out but if you feel you need more information please just let us know.

Hi, the screenshots on this page show an 'App Logs' tile under the 'Availability and Performance' tabs, but this is not present in any of our web apps. Also, your screenshots show a 'Web App Logs' category in the list under the 'Web App Down' tab, but again this is not present. Is there a prerequisite that needs to be enabled for 'App Logs' solutions to appear in the Diagnostics and Performance tab?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fd8426b2-dbe5-9a46-4045-55cc26806641
Version Independent ID: 99eef6e6-7978-1008-4d6f-a5ae566a6305
Content: Diagnostics and solve tool - Azure App Service
Content Source: articles/app-service/overview-diagnostics.md
Service: app-service
GitHub Login: @Jen7714
Microsoft Alias: jennile

Thanks for the update


Recommend a service management tool

This would be a cool thing to add via a yafti option, JeremyGraeme had this:

https://extensions.gnome.org/extension/1804/sermon/
TThis tool also can show the containers and all the other stuff, this would be great, especially for app developers that need to just quickly bounce one of them.

hmm, nice!

Looks very similar to https://github.com/ublue-os/packages/issues/22, but explicitly calls out containers.
Although most of our containers run as systemd services anyway

Mission Center has this built in.

Mission Center has this built in.

Unless I'm missing something, I cannot see any quadlets in Mission Center

Yeah, I see what you mean. Do we wanna still try to do this or should we instead look at things like a dedicated applet for ollama, etc?


Changed HttpRequestMessage to HttpRequest

The VS version is now not running without this change.
However, it does not post to the SQL database in Azure. Might take time to fix. In the meantime, this modified sample will at least run the Http calls in Visual Studio, successfully.
I will update the readme.

#sign-off @diberry


[Task] Server Registry and Server Discover module

@robberphex develop this two module.
Also, we need other 2-3 friends to help him.

This issue is in Progress.

Hey, I want to adapter Nacos discovery, give me a task please.

https://github.com/apache/dubbo-rust/pull/82

https://github.com/apache/dubbo-rust/pull/51


DS1202ZE

Hi Scott, Just wondering when you may have time to include the DS1202ZE?

I don't have much time, but the files you sent seemed to parse ok.
RigolWFM/wfmconvert.py Z info wfm/DS1202Z-2.wfm
What is the problem?

Rigol1202Z.zip
Scott, I have added a few more files for two cases, one channel used and two channels used. For the single input case the code interpreted the data file to have three channels, Ch1 (1mV/div + offset -2.5mV), Ch3(-2nV/div+offset -2nV) and Ch4(-2nV/div+offset -2nV). Also, there is some sort of transient visible at the end of the python plot, that is not in the CSV or image file. I think I observed that on occasional files when processing files from the DS1204B as well.

mhm have an issue with a File from DS1202ZE
wfmconvert.py Z info wfm/DS1202Z-2.wfm is working but says it is a File Model   = wfm1000z
But when trying to convert i get:
Traceback (most recent call last):
File "C:\wfm\example.py", line 7, in
w = rigol.Wfm.from_file(filename, scope)
File "C:\Users\marti\AppData\Roaming\Python\Python310\site-packages\RigolWFM\wfm.py", line 209, in from_file
ch = RigolWFM.channel.Channel(w, ch_number, pname, selected)
File "C:\Users\marti\AppData\Roaming\Python\Python310\site-packages\RigolWFM\channel.py", line 115, in init
self.seconds_per_point = w.header.seconds_per_point
File "C:\Users\marti\AppData\Roaming\Python\Python310\site-packages\RigolWFM\wfm1000e.py", line 384, in header
self._m_header = Wfm1000e.Header(self._io, self, self._root)
File "C:\Users\marti\AppData\Roaming\Python\Python310\site-packages\RigolWFM\wfm1000e.py", line 205, in init
self._read()
File "C:\Users\marti\AppData\Roaming\Python\Python310\site-packages\RigolWFM\wfm1000e.py", line 210, in _read
raise kaitaistruct.ValidationNotEqualError(b"\xA5\xA5\x00\x00", self.magic, self._io, u"/types/header/seq/0")
kaitaistruct.ValidationNotEqualError: /types/header/seq/0: at pos 4: validation failed: not equal, expected b'\xa5\xa5\x00\x00', but got b'\x01\xff\xff\xff'

Rigol1202Z.zip
Scott, I have added a few more files for two cases, one channel used and two channels used. For the single input case the code interpreted the data file to have three channels, Ch1 (1mV/div + offset -2.5mV), Ch3(-2nV/div+offset -2nV) and Ch4(-2nV/div+offset -2nV). Also, there is some sort of transient visible at the end of the python plot, that is not in the CSV or image file. I think I observed that on occasional files when processing files from the DS1204B as wel    l.

same issue


Impact area id's not returning correct numbers from stage damage compute

The impact area id's getting returned were all zero. I think part of the problem is this method:

An impact area id is passed into the method but is not used. I think it needs to replace the consequenceResult.RegionID.
I made this change and then all my impact area ids were 14. Since i was grasping at straws, i changed it back to the original state.
There might be an issue with this method:

It is getting the impact areas from the last y value. That doesn't seem right to me, but i don't understand what all is happening in this code.

This is where i grab the impact area id to display in the UI:

Since i don't have good id's, the impact area rows are empty for the impact area name.

GetImpactAreas() works as expected. I just wrote a test to confirm. It can happen on the last ConsequenceDistributionResults object in the array because each ConsequenceDistributionResults object holds a ConsequenceDistributionResult object for each impact area, damage category, asset category combination.

I think you made these changes on my branch, but I am still not getting impact area id's back. I am trying to diagnose what is going on. I think there is probably an issue in this class:

The impact area ids and the dam cats are passed into the ctor but they are never used.

It looks to me like you are getting the impact area id and the dam cat from the "ConsequenceResults" object that is created in the pic above on line 21. Maybe the imp area ids and the dam cats need to be passed into that object? either on line 21 or in the compute on line 27?

Ok, i think the issue is that the top one is getting called in my case, instead of the bottom one:

I will call the bottom one and see what happens.

Or maybe the problem is here: The correct impact area ID is being passed in but that value is never used. It looks to me like the impact and dam cat come from the inventory. This inventory doesn't have the correct info in it.

The dictionary of impact area id's gets passed into the inventory. This dictionary seems to have the correct values in it. But then the impact area id's get calculated based off the structures in this method:

Maybe we can get rid of that and just use the dictionary?

I thought that this change might fix the impact areas, but it did not. I am going to revert that change and move on.

@codymccoy FYSA I am back working on this today

Ah! It looks like I forgot to mention explicitly that we can't make progress on this issue until we make progress on #576. I apologize for not communicating that. You're right - the impact area ID and damage category are set by the structure's attributes, but the structure's "impact area ID" is actually the impact area NAME. We need it to be the ID, and I think we need Brennan's help with that.

Looks like this is resolved


bump curl-sh exprs to tls 1.3?

We currently emit curl-sh exprs of the form:
curl --proto '=https' --tlsv1.2 -LsSf https://github.com/axodotdev/cargo-dist/releases/download/v0.3.0/cargo-dist-installer.sh | sh

This was inherited from https://rustup.rs/ although we added the extra -L (iirc required to chase redirects from github).
It has been suggested we should update this to tlsv1.3 -- I'm not really a tls/interop expert, so feedback welcome.

I tried it on debian oldoldstable (which has a too old glibc to even run cargo-dist 0.3.0 :D) and it works just fine. curl added TLS 1.3 all the way back in 2018 before it was standardized. https://daniel.haxx.se/blog/2018/03/27/play-tls-1-3-with-curl/

This seems pointless to bother with. I created #978 to remove this entirely. TLS should be negotiated for the highest supported version first and downgraded when it's unsupported.

--tlsv1.2 indicates that TLSv1.2 or higher must be used. Changing this to --tlsv1.3 will force TLSv1.3 or higher to be used, which Github is known to support. If for some reason TLSv1.2 or lower is negotiated that either means that curl didn't support TLSv1.3 (if that is the case your curl version is likely old enough to be vulnerable to known security issues anyway, so erroring out in this case is completely reasonable IMO) or there is a MITM attacker trying to downgrade to a lower TLS version to exploit a cryptographic issue, in which case you definitively want to error out. Now TLSv1.3 should have protection against downgrade attacks when the client is TLSv1.3 capable and downgrading to anything lower than TLSv1.2 shouldn't be possible as Github rejects connections with TLSv1.1 and lower. As such --tlsv1.2 probably doesn't provide any benefit for connecting to Github or any other site which requires TLSv1.2 or higher. --tlsv1.3 may potentially provide marginal benefit against future attacks, though probably not a whole lot given the downgrade protection mechanism of TLSv1.3.

If TLS 1.3 support isn't compiled into your cURL binary, that would then fail. This should be up to the endpoint to determine which TLS version to use/support. cURL (and by standard use case, the ssl/tls library implementation) provides for a way to downgrade if necessary.

We inherited the flags to force a minimum of tls 1.2 and https from rustup, where they were introduced to prevent redirects from ever downgrading the security: https://github.com/rust-lang/rustup/pull/1716
So in both of these cases, being able to negotiate downgrades was viewed as an anti-feature.


Custom lists are random

Sorry can't do these as pull requests right now.
List stats does not offer a static list. I presume if an item, of what appears to be five, is empty it's not rendered.
series_parser.py
line 447: read_lists = contents[13].find_all("b")
manga["reading_lists"] = {
"reading": read_lists[0].get_text().strip(),
"wish": read_lists[1].get_text().strip(),
"unfinished": read_lists[2].get_text().strip(),
"custom": read_lists[3].get_text().strip(),
}
replaced with:
manga["reading_lists"] = dict()
cnt = ""
for obj in contents[13]:
if "" in str(obj):
cnt = obj.get_text().strip()
if "lists" in str(obj):
if "reading" in str(obj):
manga["reading_lists"]["reading"] = cnt
if "wish" in str(obj):
manga["reading_lists"]["wish"] = cnt
if "completed" in str(obj):
manga["reading_lists"]["completed"] = cnt
if "unfinished" in str(obj):
manga["reading_lists"]["unfinished"] = cnt
if "custom" in str(obj):
manga["reading_lists"]["custom"] = cnt
Probably a better way to do it? Logic loop through the list stats content. Save the number of the list. Discover the list name and used the previously saved number.

hi! can you re-post the code using a code block (```)? just for ease of reading haha.
thank you for flagging these edge-cases!

I've edited it and it should be good now. Been a while since I've used github :)

incorporated your fix in 44099f9f6747b107a68ee0f0c569f7f90812d13f ! thank you so much :D


displaying results of interactive widgets

Between 3.2 and 4.0, most of my interactive plotting notebooks broke due to a change where the fuinction return value is automatically displayed. A good example of what this looks like is in ipywidgets/examples/Lorenz Differential Equations.ipynb, the interactive plot in cell 6 has a large array of numbers instead of just a nice plot.
The change that caused this is in interaction.py, function interactive(),
try:
container.result = f(**container.kwargs)
display(container.result)
Removing the display() restores the previous behaviour.

I could not find any discussion of this, but it appears tha tthis is the designed new behaviour.  The examples should be updated to reflect this.

It is the new desired behavior - but there is one problem with how it works
in 4.0 that we have fixed in master of ipywidgets. If the return value of
the function of None 4.0 will display that, but it shouldn't (and won't in
4.1).
On Mon, Sep 21, 2015 at 6:02 AM, martin-hunt<EMAIL_ADDRESS>wrote:

I could not find any discussion of this, but it appears tha tthis is the
designed new behaviour. The examples should be updated to reflect this.
—
Reply to this email directly or view it on GitHub
https://github.com/ipython/ipywidgets/issues/162#issuecomment-141967816.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Here's the discussion regarding this new behavior: https://github.com/ipython/ipywidgets/pull/68
Here's the none fix that @ellisonbg mentions: https://github.com/ipython/ipywidgets/pull/152

@jdfreder - this is sort of a show stopper for the 4.0 release of
ipywidgets. How hard would it be to put out a 4.0.1 release of just the
widgets that has this fix (and any other simple bug fixes)? Remember
ipywidgets releases don't have to follow the notebook now :)
On Mon, Sep 21, 2015 at 8:20 AM, Jonathan Frederic<EMAIL_ADDRESS>
wrote:

Here's the discussion regarding this new behavior: #68
https://github.com/ipython/ipywidgets/pull/68
Here's the none fix that @ellisonbg https://github.com/ellisonbg
mentions: #152 https://github.com/ipython/ipywidgets/pull/152
—
Reply to this email directly or view it on GitHub
https://github.com/ipython/ipywidgets/issues/162#issuecomment-142013220.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Yeah, that's easy to do.  I'll do that now

https://pypi.python.org/pypi/ipywidgets/4.0.3

@jdfreder the four-minutes release! :+1:

Awesome! Many thanks!
On Mon, Sep 21, 2015 at 9:12 AM, Sylvain Corlay<EMAIL_ADDRESS>wrote:

@jdfreder https://github.com/jdfreder the four-minutes release! [image:
:+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/ipython/ipywidgets/issues/162#issuecomment-142030709.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Also, @jdfreder can you ping someone from Continuum to make sure that conda
gets this update as many folks are getting it from there.
On Mon, Sep 21, 2015 at 9:51 AM, Brian Granger<EMAIL_ADDRESS>wrote:

Awesome! Many thanks!
On Mon, Sep 21, 2015 at 9:12 AM, Sylvain Corlay<EMAIL_ADDRESS>wrote:

@jdfreder https://github.com/jdfreder the four-minutes release! [image:
:+1:]
—
Reply to this email directly or view it on GitHub
https://github.com/ipython/ipywidgets/issues/162#issuecomment-142030709
.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Sure, maybe @asmeurer and @ilanschnell can update the Anaconda package.

I just updated ipywidgets in Anaconda to version 4.0.3

Thanks!
On Mon, Sep 21, 2015 at 12:28 PM, Ilan Schnell<EMAIL_ADDRESS>wrote:

I just updated ipywidgets in Anaconda to version 4.0.3
—
Reply to this email directly or view it on GitHub
https://github.com/ipython/ipywidgets/issues/162#issuecomment-142085412.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

Thanks!

@ilanschnell the jupyter metapackage still depends on ipywidgets 4.0.2.

Isn't it possible/desirable to add a keyword argument to avoid displaying function return? With displaying as default behaviour?

Hmm, I don't think that is needed. It led to poorly written code to have
functions that did the display themselves. Because passing the kwarg would
still be an API breakage, I don't think it is worth it.
On Thu, Oct 8, 2015 at 8:14 AM, jfbercher<EMAIL_ADDRESS>wrote:

Isn't it possible/desirable to add a keyword argument to avoid displaying
function return? With displaying as default behaviour?
—
Reply to this email directly or view it on GitHub
https://github.com/ipython/ipywidgets/issues/162#issuecomment-146519309.

--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

I thought to something like

f_output = kwargs.pop('f_output', True)

which doesn't break the API, and then

if (container.result is not None) and f_output:
....... display(container.result)

Because displaying functions return is sometimes annoying, as noticed earlier in the thread (eg I have functions that selects a file + some parameters and return  huge dataframes). However this is not very important since it can always be done directly.


docs: correct some typos in dataset_management.rst and tbrn.rst

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.31%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
6065

Relevant Lines:
7027

💛  - Coveralls


AST1300 PCIe device produces freeze/fence

I have a Talos II workstation (latest 2.00 firmware from Raptor), and am trying to use an IGCME-1300-R10 GPU (chipset is AST1300) with it (in conjunction with a StarTech PEX2MPEX to attach the MiniPCIe GPU to a standard PCIe slot on the Talos).  Unfortunately, while the bridge device component of the IGCME-1300-R10 is detected successfully, the VGA controller component produces a freeze/fence in Skiboot logs, and does not subsequently show up in lspci output.
I've tried connecting the PEX2MPEX with IGCME-1300-R10 to an x86 machine (running Windows) and the VGA device does show up as a PCIe device in Windows, which indicates that there is something POWER-specific about this problem.
Curiously, on the older firmware that the Talos II shipped with (not sure of the firmware version, but it's whatever the first batch of Talos II machines shipped with, as it was a pre-order), the bridge device component of the IGCME-1300-R10 isn't present in lspci output either, which suggests that the situation has at least improved between those firmware versions.
I'm attaching Skiboot and lspci output from both the latest 2.00 firmware and the firmware that the Talos II shipped with.  (Lest anyone get confused, please note that these logs refer to 2 different AST GPU devices: the AST2500 that's part of the built-in BMC (which works fine), and the AST1300 that this issue is about.)  Let me know if there's anything I can do to help debug it.  (Or, if you think I should be reporting this to Raptor rather than to you, let me know and I'll do so.)
lspci-with-unrecognized-ast1300-firmware-2.00.txt
lspci-with-unrecognized-ast1300-stock-firmware.txt
skiboot-with-unrecognized-ast1300-firmware-2.00.txt
skiboot-with-unrecognized-ast1300-stock-firmware.txt

==== PHB Register dump found ====

[   73.061847781,3] PHB#0033[8:3]:             PCI FIR=2000000000000000

NEST FIR =<PHONE_NUMBER>000000:
	16 - PFIR_freeze

PCI FIR =<PHONE_NUMBER>000000:
	 2 - AIB_intf_error

phbErrorStatus = 00000d0000000000:
	20 - RXE_ARB OR Error Status
	21 - RXE_MRG OR Error Status
!	23 - TXE OR Error Status

phbTxeErrorStatus =<PHONE_NUMBER>000000:
!	29 - CFG Write Request Timeout

phbRxeArbErrorStatus =<PHONE_NUMBER>000000:
!	34 - PCT Timeout

phbRxeMrgErrorStatus =<PHONE_NUMBER>000001:
!	63 - pb_etu_ai_rx_raise_fence

phbRegbErrorStatus =<PHONE_NUMBER>000000:
	 9 - PCIE Link Up

So the freeze is due to a config write timeout, which is... unusual. My best guess is that the AST firmware is slow to enable the VGA component. If you're ok with building your own firmware can you try this patch:
diff --git a/core/pci.c b/core/pci.c
index e195ecbf4255..a90d4d3c9793 100644
--- a/core/pci.c
+++ b/core/pci.c
@@ -632,6 +632,8 @@ static bool pci_enable_bridge(struct phb *phb, struct pci_device *pd)
 	    pd->dev_type == PCIE_TYPE_SWITCH_DNPORT) {
 		if (!pci_bridge_wait_link(phb, pd, was_reset))
 			return false;
+	} else if (pd->dev_type == PCIE_TYPE_PCIE_TO_PCIX) {
+		time_wait_ms(1000);
 	}

 	/* Clear error status */
diff --git a/hw/phb4.c b/hw/phb4.c
index 3f22a2c4d98f..7b463420ff20 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -84,7 +84,7 @@

 #undef NO_ASB
-#undef LOG_CFG
+#define LOG_CFG

 #include <skiboot.h>
 #include <io.h>

@oohal Thanks for the patch.  I was able to get it to build, though I increased the wait from 1 second to 10 seconds on the advice of someone in #talos-workstation IRC (basically to increase the safety margin).  Unfortunately, no change in behavior: the VGA device still doesn't show up in lspci, and similar freeze/fence errors are still logged.  (The added 10-second wait is pretty clearly visible in the log.)  There is a lot more logging this time (I guess that's a result of the LOG_CFG line you changed), so maybe the extra logs will help determine the cause.  Attaching the Skiboot log.
skiboot-with-unrecognized-ast1300-with-10s-wait.txt

Thanks for the logs. I noticed there's some odd stuff in there:
[   73.390875079,7] PHB#0033[8:3]: 100 CFG8 Wr 18=00000001 # write the default bus numbers
[   73.390876229,7] PHB#0033[8:3]: 100 CFG8 Wr 19=00000000
[   73.390877346,7] PHB#0033[8:3]: 100 CFG8 Wr 1a=00000000

[   73.390878278,7] PHB#0033:01:00.0 Found VID:1a03 DEV:1150 TYP:7 MF- BR+ EX+

[   73.390880618,7] PHB#0033[8:3]: 100 CFG32 Rd a4=0000000d
[   73.390882363,7] PHB#0033[8:3]: 100 CFG16 Rd 04=0000
[   73.390883445,7] PHB#0033[8:3]: 100 CFG16 Wr 04=00000140 # enable the error reporting bits in the command register

[   73.390885288,7] PHB#0033[8:3]: 100 CFG16 Rd 88=2810
[   73.390886859,7] PHB#0033[8:3]: 100 CFG32 Rd 18=00000001
[   73.390887888,7] PHB#0033[8:3]: 100 CFG32 Wr 18=00000141 # <--- ????

That last write definitely isn't supposed to be happening. I think those writes are coming from phb4_endpoint_init() which enables error reporting for the device. The AST1300 doesn't appear to implement the Advance Error Reporting capability so when we initialise that we end up trashing config offsets 0x18..0x1b since the saved aercap offset is zero. For normal devices that's doesn't matter since 0x18 is a BAR register which will be overwritten later on by linux. For bridges however, those are the primary/secondary/subordinate bus number registers which are used to route config space accesses. Broken config space routing would explain the timeouts.
Can you try this patch (keep the LOG_CFG change too):
diff --git a/hw/phb4.c b/hw/phb4.c
index 3f22a2c4d98f..34e9dd58b745 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -787,6 +787,7 @@ static void phb4_endpoint_init(struct phb *phb,
 		  PCICAP_EXP_DEVCTL_UR_REPORT);

 	/* Enable ECRC generation and check */
+	if (!aercap) return;
 	pci_cfg_read32(phb, bdfn, aercap + PCIECAP_AER_CAPCTL, &val32);
 	val32 |= (PCIECAP_AER_CAPCTL_ECRCG_EN |
 		  PCIECAP_AER_CAPCTL_ECRCC_EN);

@oohal Thanks for the new patch.  Applying it on top of the previous patch I applied yields the following log (unfortunately no change in visible behavior; the VGA device still doesn't show up in lspci):
skiboot-with-unrecognized-ast1300-with-10s-wait-and-AERcap.txt

Adding a data point: I tried using a different MiniPCIe device (a WiFi card) with the StarTech PEX2MPEX in my Talos II, and it worked fine.  So that at least confirms that the PEX2MPEX isn't responsible for the issue (although we already guessed that).


Pr2 sample data add workflow

Pull Request
This PR adds  a GitHub workflow for sample validation  and associated documentation.
This reflects the splitting up of the original PR reflecting Issue #40 (PR #75) per the suggestion made by @botanize

Replaced by: https://github.com/TIDES-transit/TIDES/pull/104


Use colors from color-scheme

After installing it, I had a feeling it wasn't using the colors from my color-scheme but its own colors (or maybe it was colors from my scheme but used very differently than my scheme was using them)
Is there a way to better align those colors with those from the scheme?

It seems it's not possible:
https://github.com/georgewfraser/vscode-tree-sitter/issues/7#issuecomment-494467392

If I understand this correctly, then the theme must provide a color to treeSitter.*? Given the theme doesn't support it yet, can I do this on my own?

@gossi Yes, you can add a user setting like:
    "workbench.colorCustomizations": {
        "treeSitter.field": "#ff0000"
    }

Unfortunately, there is currently no way to access syntax colors from an extension: https://github.com/microsoft/vscode/issues/32813#issuecomment-488572556
If VSCode adds an API to access syntax colors, I will drop the treeSitter.* system and just use the colors from the theme.

The only real fix I can think of is to find a general mapping of textmate scopes to tree-sitter scopes. Then create a converter program that can take any textmate theme and convert it to a tree-sitter theme. It will almost certainly not be a perfect conversion but it is at least doable, and if theme makers want to add support they can fix any inconsistencies.
Basically as a workaround, we can build up a folder of all the tree-sitter versions of themes. Then, at runtime, we can retrieve the name of the theme, find our tree-sitter version of it, and then use the tree-sitter version to provide the coloring.
If we could access the theme's json programmatically that would be even better, and we could generate a tree-sitter version dynamically. I didn't even know that was a potential option until I saw https://github.com/microsoft/vscode/issues/32813#issuecomment-495005152

@georgewfraser exactly what I was looking for. Thank you so much.

So it turns out that while VSCode doesn't provide an API for syntax scope colors, it is possible to read the actual color themes off the disk. I was able to adapt some code from https://github.com/microsoft/vscode-cpptools/tree/coleng/Colorization , and now tree-sitter changes color with the theme!

That's awesome! How are you pulling the colors from the themes and matching them to tree-sitter-scopes?

I read the color themes off the disk. It's a hack, but it's the same hack being used by the Microsoft folks working on the CPP plugin.


Labels are always rendered

Labels are rendered with display:none on charts that have labels turned off. This can be quite slow on some charts (e.g. line charts with many values) and adds uneccessary DOM complexity.
It seems better to suppress the labels entirely, unless they're needed for something else that I haven't noticed.
I have the code for this on a branch locally but am unable to push. cc @adamdoe

Discussed offline and directed to Contributing Guidelines


Let's standardize last-update.txt date to be YYYY-MM-DD HH:mm:ss

This file is showing a non-standard date format https://s3-eu-west-1.amazonaws.com/virustrack.live/site-data/last-update.txt

See https://github.com/pr3d4t0r/COVIDvu/pulls - all done!


HTTP Referer?

The HTTP referer (referrer) is one of the most interesting headers in analytics IMHO.
Google Analytics use it for their acquisition analysis, and they include it under names like "source" or "referral path".
I couldn't find any equivalent in Application Insights for my ASP.NET Azure Web App. Specifically, I couldn't find any graph/metric for it in the portal, and no corresponding field in the requests or pageViews Analytics records.
This SO answer by an MS employee given on April 2015 suggests the following explicit code:  appInsights.trackPageView(null, null, {urlReferrer: document.referrer});
Is this still the recommended solution? If so, I'm assuming one should remove the appInsights.trackPageView(); call in the default AI JS code snippet?

Is manually adding this still the solution? I wanted to get referral data for the dot.net website app insights.

No work has been done on this issue, and nothing is planned for this year.
So the exiting recommendation (i think it was to use manual initializers), still remains.

This was removed from future milestones, does that mean it will no longer be a consideration?


Dont work !

Cloud you please specify where the errors are ?  LGTM

no gui open dont know how that work

Can you just run main.py? Which python do you use? (you can try python3 gui.py) I need no infomation to location the problem.

It looks like your python was not found. You need add python to environment variables.

how to add python to env variable ?

This is wierd.... Did you just get stuck here? Could you please add my Whatsapp account(+86<PHONE_NUMBER>7) and send a video clip to me so that I can help you with this.

It looks fine when the "runing Verify Fluid Program .." is printed. However, if the program is then frozen without a gui displayed, it's wierd...

If you get stuck in "running Verify Fluid Program", you can just delete fluid.install_check.run_check() in config.py

If you get stuck in "running Verify Fluid Program", you can just delete fluid.install_check.run_check() in config.py

Thanks work now


autoSleep(long autoSleep) method is missing in RepeatBuilder class

Please provide autoSleep(long autoSleep) method in RepeatBuilder class.

Why do you need that autoSleep option in normal iterating containers like repeat? The auto sleep has exclusively been added to the on-error container because the sleep will only take place in case some error is raised. Otherwise the auto sleep is not performed in this container.
In a normal iterating container like repeat autoSleep would be executed in all possible scenarios. So you could do the same with just adding a sleep action to the container:
repeat()
    .until(someCondition)
    .actions(sleep(2000), echo("I am executed in iteration"));


Create ValentinesDay.cpp

Adding C++ code that uses the FastLED library to control WS2812B LED strips with an Arduino to create Valentine's Day lighting effects.

Love it! Thank you for the contribution. I don't own any of these lights anymore, so I can't test your code, but I didn't see any obvious issues with it. Please consider adding your program to PlusPrograms.cpp/.h so that it gets included automatically.

I appreciate that people continue to use and improve these programs. The GE35 lights were great! Thanks to many, especially sowbug, I got interested in using Arduino to control RGB lights. I still have one set of GE35 permanently mounted outside with small waterproof sandwich box running a Christmas pattern. They work fine, but I did have to replace the power-supply this year. I have the WS2812s inside - had some bad experiences with so-called "waterproof" leds. I also have a Christmas Star with 50 LEDs (ten on each arm) running multiple patterns.


Better analytics/trial direct NetCDF loads

https://www.noahbrenowitz.com/post/loading_netcdfs/

Data loading related:
https://docs.nvidia.com/deeplearning/dali/user-guide/docs/index.html

Leaving here visibility, not planning to use atm.
A batch generator for Tensorflow/PyTorch from xarray DataArrays/datasets:
https://github.com/xarray-contrib/xbatcher
and, a relevant discussion thread:
https://discourse.pangeo.io/t/favorite-way-to-go-from-netcdf-xarray-to-torch-tf-jax-et-al/2663/2


specify type in function, variable

specify type in function, variable

Is there a reason too explicit set the types? They are resolved by typescript automatically

Looking Back, it was too explicit. i will close it.


Message review

Details as per commit message.
I noticed a discrepancy between message versions and the version the spec says they should have. This fixes that and sets all message versions to their spec value.
This also merges upstream into our master.

@adamrankin There are 6 commits and lots of changed files. Could you please check if only the necessary modifications are included? If those multiple commits are recent changes merged from upstream to this fork then do that in a separate pull request (it should be trivial, may not even need any review) and we could just focus on your actual modifications.


Error when bundling with Webpack

Hello, thank you for this passport!
I have a NodeJs and TypeScript server I bundle using webpack with target as node. When I'm using this package I have this exception thrown at build time:
throw new Error('Could not find package.json up from ' +
^

Error: Could not find package.json up from 1164
    at Function.pkginfo.find (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:214015:11)
    at Function.pkginfo.read (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:214042:22)
    at module.exports (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:213988:21)
    at Object.<anonymous> (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:214049:1)
    at Object.webpackEmptyContext.keys (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:214055:30)
    at __webpack_require__ (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:30:30)
    at Object.<anonymous> (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:110086:1)
    at Object.Op (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:110093:30)
    at __webpack_require__ (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:30:30)
    at Module.<anonymous> (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:215348:24)
    at __webpack_require__ (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:30:30)
    at /Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:94:18
    at /Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:97:10
    at webpackUniversalModuleDefinition (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:3:20)
    at Object.<anonymous> (/Users/yrenaudin/Documents/Projects/profilr-api/dist/index.js:10:3)
    at Module._compile (internal/modules/cjs/loader.js:701:30)

I dug a bit the issue and it seems to originate from the usage of pkgInfo, did someone already stumble upon this ?

This should be fixed by https://github.com/JMPerez/passport-spotify/pull/86


Do you have a version that supports Ros2

Do you have a version that supports Ros2

See https://github.com/moveit/moveit_calibration/issues/99


catkin_make fails

after cloning when  I go back to ws and run catkin_make I get the following errors:
catkin_make
Base path: /home/dhruva/catkin_ws
Source space: /home/dhruva/catkin_ws/src
Build space: /home/dhruva/catkin_ws/build
Devel space: /home/dhruva/catkin_ws/devel
Install space: /home/dhruva/catkin_ws/install

Running command: "cmake /home/dhruva/catkin_ws/src -DCATKIN_DEVEL_PREFIX=/home/dhruva/catkin_ws/devel -DCMAKE_INSTALL_PREFIX=/home/dhruva/catkin_ws/install -G Unix Makefiles" in "/home/dhruva/catkin_ws/build"

-- Using CATKIN_DEVEL_PREFIX: /home/dhruva/catkin_ws/devel
-- Using CMAKE_PREFIX_PATH: /home/dhruva/ros20_ws/devel;/home/dhruva/ws_moveit/devel;/opt/ros/kinetic
-- This workspace overlays: /home/dhruva/ros20_ws/devel;/home/dhruva/ws_moveit/devel;/opt/ros/kinetic
-- Using PYTHON_EXECUTABLE: /home/dhruva/.espressif/python_env/idf4.1_py2.7_env/bin/python2
-- Using Debian Python package layout
-- Using empy: /usr/bin/empy
-- Using CATKIN_ENABLE_TESTING: False
-- catkin 0.7.20
-- BUILD_SHARED_LIBS is on
-- BUILD_SHARED_LIBS is on
-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- ~~  traversing 6 packages in topological order:
-- ~~  - ck9_gazebo
-- ~~  - ck9_navigation
-- ~~  - ck9_simple_control
-- ~~  - realsense2_description
-- ~~  - sra
-- ~~  - realsense2_camera
-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-- +++ processing catkin package: 'ck9_gazebo'
-- ==> add_subdirectory(ck9_gazebo/ck9_gazebo)
-- +++ processing catkin package: 'ck9_navigation'
-- ==> add_subdirectory(ck9_gazebo/ck9_navigation)
CMake Warning at /opt/ros/kinetic/share/catkin/cmake/catkinConfig.cmake:76 (find_package):
Could not find a package configuration file provided by "move_base" with
any of the following names:
move_baseConfig.cmake
move_base-config.cmake

Add the installation prefix of "move_base" to CMAKE_PREFIX_PATH or set
"move_base_DIR" to a directory containing one of the above files.  If
"move_base" provides a separate development package or SDK, be sure it has
been installed.
Call Stack (most recent call first):
ck9_gazebo/ck9_navigation/CMakeLists.txt:10 (find_package)
-- Could not find the required component 'move_base'. The following CMake error indicates that you either need to install the package with the same name or change your environment so that it can be found.
CMake Error at /opt/ros/kinetic/share/catkin/cmake/catkinConfig.cmake:83 (find_package):
Could not find a package configuration file provided by "move_base" with
any of the following names:
move_baseConfig.cmake
move_base-config.cmake

Add the installation prefix of "move_base" to CMAKE_PREFIX_PATH or set
"move_base_DIR" to a directory containing one of the above files.  If
"move_base" provides a separate development package or SDK, be sure it has
been installed.
Call Stack (most recent call first):
ck9_gazebo/ck9_navigation/CMakeLists.txt:10 (find_package)
-- Configuring incomplete, errors occurred!
See also "/home/dhruva/catkin_ws/build/CMakeFiles/CMakeOutput.log".
See also "/home/dhruva/catkin_ws/build/CMakeFiles/CMakeError.log".
Invoking "cmake" failed
What can be done?

In your terminal, type:
sudo apt install ros-kinetic-move-base-config

Thanks for the prompt response @jash101 !
A new issue I am now facing is the bot is not loading properly in gviz  and the world isnt in gazebo..
I have posted the screenshots below:

The gazebo world has been intentionally kept empty. You can insert a model or launch a different world file as per your needs.
The rViz issue can be solved using following command: sudo apt install ros-kinetic-joint-state-publisher-gui

RVIz issue solved.
Now I am not able to operate the bot with the given teleop...
output:
roslaunch ck9_simple_control ck9_control_teleop.launch
... logging to /home/dhruva/.ros/log/a01f1a8e-8f6c-11ea-90fa-45752ef552d7/roslaunch-dhruva-Lenovo-G40-80-3105.log
Checking log directory for disk usage. This may take awhile.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.
started roslaunch server http://dhruva-Lenovo-G40-80:46787/
SUMMARY
PARAMETERS

/rosdistro: kinetic
/rosversion: 1.12.14
/turtlebot_teleop_keyboard/scale_angular: 1.5
/turtlebot_teleop_keyboard/scale_linear: 0.5

NODES
/
turtlebot_teleop_keyboard (turtlebot_teleop/turtlebot_teleop_key)
ROS_MASTER_URI=http://localhost:11311
process[turtlebot_teleop_keyboard-1]: started with pid [3128]
Control Your Turtlebot!
Moving around:
u    i    o
j    k    l
m    ,    .
q/z : increase/decrease max speeds by 10%
w/x : increase/decrease only linear speed by 10%
e/c : increase/decrease only angular speed by 10%
space key, k : force stop
anything else : stop smoothly
CTRL-C to quit
currently:	speed 0.2	turn 1
currently:	speed 0.22	turn 1
currently:	speed 0.242	turn 1
currently:	speed 0.2662	turn 1
currently:	speed 0.29282	turn 1
The bot in gazebo simply doesnt respond to these commands..
However simple apply force works in gazebo so I know that gazebo is not lagging or anything..
Have I missed any step here?

Just to make sure, is this terminal active when you press the keys for teleop?

here is the output of my other terminal:
roslaunch ck9_gazebo ck9_gazebo.launch
... logging to /home/dhruva/.ros/log/a01f1a8e-8f6c-11ea-90fa-45752ef552d7/roslaunch-dhruva-Lenovo-G40-80-973.log
Checking log directory for disk usage. This may take awhile.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.
started roslaunch server http://dhruva-Lenovo-G40-80:44427/
SUMMARY
PARAMETERS

/robot_description: <?xml version="1....
/rosdistro: kinetic
/rosversion: 1.12.14
/use_gui: True
/use_sim_time: True

NODES
/
gazebo (gazebo_ros/gzserver)
gazebo_gui (gazebo_ros/gzclient)
joint_state_publisher (joint_state_publisher/joint_state_publisher)
robot_state_publisher (robot_state_publisher/state_publisher)
rviz (rviz/rviz)
spawn_model (gazebo_ros/spawn_model)
ROS_MASTER_URI=http://localhost:11311
process[gazebo-1]: started with pid [994]
process[gazebo_gui-2]: started with pid [999]
process[joint_state_publisher-3]: started with pid [1004]
process[robot_state_publisher-4]: started with pid [1005]
process[spawn_model-5]: started with pid [1006]
process[rviz-6]: started with pid [1008]
Traceback (most recent call last):
File "/opt/ros/kinetic/lib/joint_state_publisher/joint_state_publisher", line 6, in
from python_qt_binding.QtCore import pyqtSlot
File "/opt/ros/kinetic/lib/python2.7/dist-packages/python_qt_binding/init.py", line 55, in
from .binding_helper import loadUi, QT_BINDING, QT_BINDING_MODULES, QT_BINDING_VERSION  # @UnusedImport
File "/opt/ros/kinetic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 271, in
getattr(sys, 'SELECT_QT_BINDING_ORDER', None),
File "/opt/ros/kinetic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 117, in _select_qt_binding
raise ImportError("Could not find Qt binding (looked for: %s):\n%s" % (', '.join(["'%s'" % b for b in binding_order]), '\n'.join(error_msgs)))
ImportError: Could not find Qt binding (looked for: 'pyqt', 'pyside'):
ImportError for 'pyqt': No module named PyQt5.QtCore
Traceback (most recent call last):
File "/opt/ros/kinetic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 108, in _select_qt_binding
QT_BINDING_VERSION = binding_loader(required_modules, optional_modules)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 150, in _load_pyqt
_named_import('PyQt5.%s' % module_name)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 130, in _named_import
module = builtins.import(name)
ImportError: No module named PyQt5.QtCore
ImportError for 'pyside': No module named PySide2.QtCore
Traceback (most recent call last):
File "/opt/ros/kinetic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 108, in _select_qt_binding
QT_BINDING_VERSION = binding_loader(required_modules, optional_modules)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 182, in _load_pyside
_named_import('PySide2.%s' % module_name)
File "/opt/ros/kinetic/lib/python2.7/dist-packages/python_qt_binding/binding_helper.py", line 130, in _named_import
module = builtins.import(name)
ImportError: No module named PySide2.QtCore
Gazebo multi-robot simulator, version 7.0.0
Copyright (C) 2012-2016 Open Source Robotics Foundation.
Released under the Apache 2 License.
http://gazebosim.org
Gazebo multi-robot simulator, version 7.0.0
Copyright (C) 2012-2016 Open Source Robotics Foundation.
Released under the Apache 2 License.
http://gazebosim.org
[joint_state_publisher-3] process has died [pid 1004, exit code 1, cmd /opt/ros/kinetic/lib/joint_state_publisher/joint_state_publisher __name:=joint_state_publisher _log:=/home/dhruva/.ros/log/a01f1a8e-8f6c-11ea-90fa-45752ef552d7/joint_state_publisher-3.log].
log file: /home/dhruva/.ros/log/a01f1a8e-8f6c-11ea-90fa-45752ef552d7/joint_state_publisher-3*.log
[ INFO] [1588750913.360185247]: Finished loading Gazebo ROS API Plugin.
[Msg] Waiting for master.
[ INFO] [1588750913.364658068]: waitForService: Service [/gazebo/set_physics_properties] has not been advertised, waiting...
[Msg] Connected to gazebo master @ http://<IP_ADDRESS>:11345
[Msg] Publicized address: <IP_ADDRESS>
[ INFO] [1588750913.613148541]: Finished loading Gazebo ROS API Plugin.
[ INFO] [1588750913.614367751]: waitForService: Service [/gazebo/set_physics_properties] has not been advertised, waiting...
[Msg] Waiting for master.
[Msg] Connected to gazebo master @ http://<IP_ADDRESS>:11345
[Msg] Publicized address: <IP_ADDRESS>
SpawnModel script started
[ INFO] [1588750914.159616123, 0.022000000]: waitForService: Service [/gazebo/set_physics_properties] is now available.
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/models.gazebosim.org"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/pr2_gripper"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/prius_hybrid"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/prius_hybrid_sensors"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/pulley_part"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/quadrotor"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/r2_description"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/radio_tower"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/ragdoll"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/reactor"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/region_event_box"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/robocup09_spl_field"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/robocup14_spl_field"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/robocup14_spl_goal"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/robocup_3Dsim_ball"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/robocup_3Dsim_field"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/robocup_3Dsim_goal"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/robocup_spl_ball"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/robonaut"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/round_tin_base"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/round_tin_top"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/salon"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/sand_island"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/saucepan"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/scanse_sweep"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/school"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/simple_arm"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/simple_arm_gripper"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/simple_gripper"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/sonoma_raceway"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/spectrum_plane"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/speed_limit_sign"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/src_doorway"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/standpipe"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/starting_pen"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/stereo_camera"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/stone_10_2_5_1cm"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/stop_light"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/stop_light_post"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/stop_sign"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/submarine"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/submarine_buoyant"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/submarine_sinking"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/t_brace_part"
[ INFO] [1588750914.261339985, 0.102000000]: Physics dynamic reconfigure ready.
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/table"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/table_marble"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/telephone_pole"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/textured_shapes"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/thrift_shop"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/tower_crane"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/trisphere_cycle"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/truss_bridge"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/tube_2_25cm"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/tube_9_5mm"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/turtlebot"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/u_joint_part"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/ur10"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/utility_cart"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/velodyne_hdl32"
[INFO] [1588750914.278213, 0.000000]: Loading model XML from ros parameter
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/vrc_driving_terrain"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/walkway_metal_45"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/walkway_metal_90"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/walkway_metal_straight"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/warehouse_robot"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/washer"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/water_tower"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/willowgarage"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/winding_valley_heightmap"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/wood_block_10_2_1cm"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home[INFO] [1588750914.292543, 0.000000]: Waiting for service /gazebo/spawn_urdf_model
/dhruva/.gazebo/models/wood_cube_10cm"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/wood_cube_2_5cm"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/wood_cube_5cm"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/wood_cube_7_5cm"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/wooden_board"
[INFO] [1588750914.296967, 0.000000]: Calling service /gazebo/spawn_urdf_model
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/wooden_case"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "[ INFO] [1588750914.298067118, 0.137000000]: waitForService: Service [/gazebo/set_physics_properties] is now available.
/home/dhruva/.gazebo/models/wooden_case_metal_peg"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/wooden_case_wooden_peg"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/wooden_peg"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/wooden_peg_board"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/yosemite"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/youbot"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/home/dhruva/.gazebo/models/zephyr_delta_wing"
[Err] [InsertModelWidget.cc:298] Missing model.config for model "/opt/ros/kinetic/share/turtlebot3_gazebo/models/turtlebot3_autorace"
[INFO] [1588750915.110603, 0.242000]: Spawn status: SpawnModel: Successfully spawned entity
[ INFO] [1588750915.133970713, 0.242000000]: Laser Plugin: Using the 'robotNamespace' param: '/'
[ INFO] [1588750915.134057035, 0.242000000]: Starting Laser Plugin (ns = /)
[ INFO] [1588750915.136957137, 0.242000000]: Laser Plugin (ns = /)  <tf_prefix>, set to ""
[ INFO] [1588750915.150887211, 0.242000000]: Physics dynamic reconfigure ready.
[ INFO] [1588750915.218703520, 0.242000000]: Starting plugin DiffDrive(ns = //)
[ WARN] [1588750915.218797945, 0.242000000]: DiffDrive(ns = //): missing  default is na
[ INFO] [1588750915.219991010, 0.242000000]: DiffDrive(ns = //): <tf_prefix> =
[ WARN] [1588750915.220164912, 0.242000000]: DiffDrive(ns = //): missing  default is false
[ WARN] [1588750915.220195767, 0.242000000]: DiffDrive(ns = //): missing  default is true
[ WARN] [1588750915.220225127, 0.242000000]: DiffDrive(ns = //): missing  default is false
[ WARN] [1588750915.220348421, 0.242000000]: DiffDrive(ns = //): missing  default is 0
[ WARN] [1588750915.220380948, 0.242000000]: DiffDrive(ns = //): missing  default is 5
[ WARN] [1588750915.220482264, 0.242000000]: DiffDrive(ns = //): missing  default is 1
[ WARN] [1588750915.220567146, 0.242000000]: GazeboRosDiffDrive Plugin (ns = ) missing , defaults to 1
[ INFO] [1588750915.222053425, 0.242000000]: DiffDrive(ns = //): Try to subscribe to /cmd_vel
[ INFO] [1588750915.229164877, 0.242000000]: DiffDrive(ns = //): Subscribe to /cmd_vel
[ INFO] [1588750915.232702256, 0.242000000]: DiffDrive(ns = //): Advertise odom on /odom
[spawn_model-5] process has finished cleanly
log file: /home/dhruva/.ros/log/a01f1a8e-8f6c-11ea-90fa-45752ef552d7/spawn_model-5*.log
static QPixmap QPixmap::grabWindow(WId, int, int, int, int) is deprecated, use QScreen::grabWindow() instead. Defaulting to primary screen.
static QPixmap QPixmap::grabWindow(WId, int, int, int, int) is deprecated, use QScreen::grabWindow() instead. Defaulting to primary screen.
[ERROR] [1588751295.344042024,<PHONE_NUMBER>00]: poll failed with error Interrupted system call
[ERROR] [1588751295.377039173,<PHONE_NUMBER>00]: poll failed with error Interrupted system call
(rviz:1008): Gtk-WARNING **: Theme file for default has no name
(rviz:1008): Gtk-WARNING **: Theme file for default has no directories

Just to make sure, is this terminal active when you press the keys for teleop?

yes

I run on one terminal the launch ck9 gazebo command
open new terminal source devel/setup bash and then run the teleop command from there

This is an unusual. To solve it faster, would you mind giving remote access?

Contact via https://wa.me/918850100529 for more info, and we'll help you out

Contact via https://wa.me/918850100529 for more info, and we'll help you out

okay

Thanks for the help looks like the issue has been solved.


Unit Tests - make -j 3

FAILING TESTS
freepdk45/20_psram_1bank_4mux_1rw_1r_test.bad
freepdk45/20_sram_1bank_2mux_1rw_1r_test.bad
freepdk45/20_sram_1bank_2mux_1w_1r_test.bad
freepdk45/20_sram_1bank_2mux_global_test.bad
freepdk45/20_sram_1bank_2mux_wmask_spare_cols_test.bad
freepdk45/20_sram_1bank_2mux_wmask_test.bad
freepdk45/20_sram_1bank_nomux_1rw_1r_spare_cols_test.bad
freepdk45/21_model_delay_test.bad
freepdk45/21_ngspice_delay_extra_rows_test.bad
freepdk45/21_ngspice_delay_test.bad
freepdk45/21_ngspice_setuphold_test.bad
freepdk45/21_xyce_delay_test.bad
freepdk45/21_xyce_setuphold_test.bad
freepdk45/23_lib_sram_test.bad
scn4m_subm/19_single_bank_global_bitline_test.bad
scn4m_subm/21_model_delay_test.bad
scn4m_subm/21_xyce_delay_test.bad
scn4m_subm/21_xyce_setuphold_test.bad
scn4m_subm/23_lib_sram_test.bad
why it is wrong?
The following URL is my openram installation process and results:
https://github.com/VLSIDA/OpenRAM/files/10350168/output.txt
I would like to ask if the installation was successful or there is an error?

commit 5ad1db95a80e04c541bf16d59678375a60734807 (HEAD -> stable, origin/stable, origin/HEAD)

Is this?
commit 5ad1db9
https://github.com/VLSIDA/OpenRAM/commit/5ad1db95a80e04c541bf16d59678375a60734807
(HEAD
-> stable, origin/stable, origin/HEAD)
Matt Guthaus @.***> 於 2023年1月5日 週四 下午7:23寫道：

Can you specify which GitHub commit you are using? (First line of "git
log")
—
Reply to this email directly, view it on GitHub
https://github.com/VLSIDA/OpenRAM/issues/166#issuecomment-1372094763,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A47LP6EPH6DZFL27JJIPH5LWQ2VKVANCNFSM6AAAAAATRUAGO4
.
You are receiving this because you authored the thread.Message ID:
@.***>


eyes swapped with three.js' vreffect

which one has the bug, you or them? here's the screenshot:

you can see that "right" eye is actually left.

closing, since the issue is there in vr.with.in that does use 3js but does not use this polyfill.


$casts Does not converts back to json on multiple mysql connections

Laravel Version: 5.8.29
PHP Version: 7.2.19
Database Driver & Version: mysql  Ver 14.14

Description:
I have two different databases A and B and they both have some common models.
i sync data between those tables.I am using json in one of the field and using casts.
protected $casts = [         "details" => "array"     ];
I use multiple connection to sync table data and i use eloquent query.
when i retrieve data it convert back to array but when i insert or update on a different connection it does not convert back to json.
hence the error "array to string conversion"
 User::on('mysql2')->withTrashed()->whereId($id)->update(['details'=>$difference]);

This type of queries will be supported in Laravel 5.9: #29146
In the meantime, you need to convert the values to JSON:
User::on('mysql2')->withTrashed()->whereId($id)
  ->update(['details' => json_encode($difference)]);

When i do this it enters as string not as json.

Please log the executed query with https://laravel.com/docs/5.8/database#listening-for-query-events or DB::enableQueryLog() and DB::getQueryLog().

Please log the executed query with https://laravel.com/docs/5.8/database#listening-for-query-events or DB::enableQueryLog() and DB::getQueryLog().

Are you executing the query that you posted here or a different one?

Are you executing the query that you posted here or a different one?

The same query

Something must be different. Casts don't affect this type of query, only updates on model instances:
User::find($id)->update(['details' => $difference]); // with cast
User::find($id)->update(['details' => json_encde($difference)]); // without cast

difference

User::find($id)->update(['details' => $difference]); // with cast
Here in 2nd query the $difference is already json as i created that record with using cast.
User::find($id)->update(['details' => $difference]);

What query doesn't work, what's the result of dd($difference); and what's the executed SQL?

The main problem i am facing is when i try to create or update cast variable on a different mysql connection it does not convert to json format.
instead it tries to insert an array which i am passing.
even though i use cast for that column.

As I said, this will be changed in Laravel 5.9.
Until then, you need to differentiate between model updates and query updates:
class User extends Model
{
    protected $casts = ['details' => 'array'];
}

// model update
User::find($id)->update(['details' => ['foo' => 'bar']]);

// query update
User::on('mysql2')->whereId($id)->update(['details' => json_encode(['foo' => 'bar'])]);

This will be changed in 5.9 as @staudenmeir said.


Android wallet build is not incremented

The build in Google Play and in Wallet Settings is always 1.0.0
and not incremented every new build

checked


v6.8<PHONE_NUMBER>0041) Can't use kotlin 1.4.20-RC

Expected Behavior
By defining
plugins {
    kotlin("jvm") version "XXX"

I can use the kotlin version of my choice (for the application).
Current Behavior
I can't :
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not resolve org.jetbrains.kotlin:kotlin-stdlib:{strictly 1.4.10}.
     Required by:
         project :
      > Cannot find a version of 'org.jetbrains.kotlin:kotlin-stdlib' that satisfies the version constraints:
           Dependency path ':gmp-system-manager:unspecified' --> 'org.jetbrains.kotlin.jvm:org.jetbrains.kotlin.jvm.gradle.plugin:1.4.20-RC' --> 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.4.20-RC' --> 'org.jetbrains.kotlin:kotlin-stdlib:1.4.20-RC'
           Constraint path ':gmp-system-manager:unspecified' --> 'org.jetbrains.kotlin:kotlin-stdlib:{strictly 1.4.10}' because of the following reason: Pinned to the embedded Kotlin

I don't see any note or warning in documentation saying that using gradle-dsl will lock application kotlin version to gradle embedded kotlin version.
Context
Some of the project and internal dependency of the project has been migrated migrated to use kotlin-dsl ; thinking going forward "the gradle way" as the documentation say it provide better perf and typesafe editing.
This broke many app. In fact, every project which has migrated to kotlin 1.4.X has been broken.
The answer was to use the gradle nightly as kotlin 1.4 release is only 2 month old, gradle still not support it in a release.
Now, I wanted to do some testing with 1.4.20-RC, but the issue is back.
I think gradle teams is well placed to know how it's hard to get people to test RC and catch issue before release.
I think gradle should not force us to wait for release + gradle update including up-to-date embedded compiler to test our app with new release.
I think the kotlin version used to build/run and app should not be tied with the emmbeded kotlin version of gradle.
Steps to Reproduce
I'm unsure if it's because the project has a build-src with kotlin-dsl, or use a plugin with a such declaration.
Your Environment
Used distributionUrl=https\://services.gradle.org/distributions-snapshots/gradle-6.8-20201106230041+0000-bin.zip
Workaround
Revert all work that has been done on migrating gradle build to kotlin ? Is there another ?

Hi @ylemoigne,
This strict constraint is only applied if you also apply the kotlin-dsl plugin which is meant to write Gradle plugins and is unnecessary if you are writing a regular kotlin application.
That being said, if you are writing a Gradle plugin, note that the embedded Kotlin has been upgraded to 1.4.20 in Gradle 6.8 after the nightly you are using. See #15238. RC1 should be out shortly.

Hi @eskatos
Thanks for your answer.
The application project contains a buildSrc which use kotlin-dsl.
Great to have a build where the version is updated. But I fear that the issue get back with another update.
So if I get it right :
If I use a gradle plugin written with kotlin, it does not lock the kotlin version for an app-project
If I use a gradle-dsl anywhere in an app-project (including buildSrc), the it lock the version for the app.
Then if it happen again, the workaround would be to extract buildSrc logic in a separate plugin ?
Am I correct ?

The constraint should only apply on the project where the kotlin-dsl plugin is applied. In other words if you apply the kotlin-dsl plugin in your buildSrc/build.gradle.kts the constraint will only be present in that project and not in the other projects in your build.

Ok thanks. So our build or one of our plugin must mess-up with classpaths as it is not the behavior I observe.
I close this issue as the main point was kotlin version used to build/run and app should not be tied with the emmbeded kotlin version of gradle. and by your explanation, I understand this is not tied "by default" ou "by gradle technical constraint" but by something on our side.
I neeed more testing to extract exactly what happen and frame correctly the issue.

@ylemoigne , did you happen to be able to resolve your issue?
I have a similar problem, and this thread is one of the few hits I have found about it :)

@timorantalaiho Yes. One of our gradle plugin had a dependency to another project which was a kotlin project. After breaking the dependency, things got ok but maybe it was not the only step. In the mean time, we removed all kotlin code from buildSrc (returning to basic java ; the buildSrc seems to cause more issue on the intellij side than gradle, but I'm not sure).

Oh... thankyou! This might be a bit tricky to fix then, but let's try :sweat_smile:

Turns out we only have this problem when using buildscript; removing that solves the issue for us.


picoLLM Issue: GPU not supported in the Android SDK.

Have you checked the docs and existing issues?

[X] I have read all of the relevant Picovoice picoLLM docs
[X] I have searched the existing issues for picoLLM

SDK
Android
picoLLM package version
1.0.0
Framework version
N/A
Platform
Android
OS/Browser version
Android 14.0
Describe the bug
Attempting to use device string 'gpu' on the Android platform results in an error stating that only 'cpu' and 'best' are supported on Android.
Steps To Reproduce

Add setDevice("gpu") to PicoLLM.builder in the Android demo.
Run and load model, observe the error.

Expected Behavior
The model runs on the GPU, without throwing an error message.

(Will also add that the documentation states the Android SDK supports GPU)

Hello @jonahnm, unfortunately we do not currently support GPU on Android.


[ROX-12212] : Optimize node and related GraphQL resolvers; Avoid pulling full node with scan and vulns by default in node datastore

Description
All below improvements are for Postgres.

In node datastore and postgres store, add ability to avoid pulling full node with scan, components and vulns.
In Node GraphQL, pull partial node excluding scan, until Scan() sub resolver is called, when full node is retrieved with scan, components and vulns.
Cache embedded node scan component and other useful info in context and use that whenever possible instead of querying datastores.
Cache embedded node scan vulns in context and use that when possible instead of querying datastores.

Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

If any of these don't apply, please comment below.
Testing Performed

Added unit tests and benchmark tests for node datastore and NodeScan GraphQL.
Performed manual testing by calling nodes->nodeScan->nodeComponents->nodeVulnerabilities resolvers to verify the correctness of results.

node_scan_benchmark_test results
cpu: Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
BenchmarkNodeResolver
BenchmarkNodeResolver/GetNodeComponentsInNodeScanResolver
BenchmarkNodeResolver/GetNodeComponentsInNodeScanResolver-16         	      30	  40213754 ns/op
BenchmarkNodeResolver/GetNodeComponentsWithoutNodeScanResolver
BenchmarkNodeResolver/GetNodeComponentsWithoutNodeScanResolver-16    	       6	 179263362 ns/op
BenchmarkNodeResolver/GetNodeComponentsDerivedFieldsWithNodeScanResolver
BenchmarkNodeResolver/GetNodeComponentsDerivedFieldsWithNodeScanResolver-16         	      15	  85106791 ns/op
BenchmarkNodeResolver/GetNodeComponentsDerivedWithoutNodeScanResolver
BenchmarkNodeResolver/GetNodeComponentsDerivedWithoutNodeScanResolver-16            	       1<PHONE_NUMBER> ns/op
BenchmarkNodeResolver/GetNodeOnly
BenchmarkNodeResolver/GetNodeOnly-16                                                	    3465	    325572 ns/op
BenchmarkNodeResolver/GetNodeWithCounts
BenchmarkNodeResolver/GetNodeWithCounts-16                                          	      39	  28955174 ns/op
PASS

Node datastore benchmark test results comparing GetNodesBatch (includes full node scan) and GetManyNodeMetadata (does not include node scan)
cpu: Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
BenchmarkGetManyNodes
BenchmarkGetManyNodes/GetNodesBatch
BenchmarkGetManyNodes/GetNodesBatch-16         	      15	  98662333 ns/op
BenchmarkGetManyNodes/GetManyNodeMetadata
BenchmarkGetManyNodes/GetManyNodeMetadata-16   	    2220	    696879 ns/op
PASS

/retest-required


Prevent scroll on body when search is open

What kind of changes does this PR include?

Changes to Starlight code

Description
This PR resolves the scroll on body when the search is open.
From my tests, it works fine even on mobile, with the menu open.

Hey @itsmatteomanf thanks a lot for the PR. I was testing the deploy preview and It seems that closing the modal using the "esc" key doesn't remove the attribute data-search-modal-open.

Hey @itsmatteomanf thanks a lot for the PR. I was testing the deploy preview and It seems that closing the modal using the "esc" key doesn't remove the attribute data-search-modal-open.

I think that it would be worth adding a KeyboardEvent as well to the arguments of both functions. https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent

Thanks for the review, @kevinzunigacuellar, @dreyfus92.

I think that it would be worth adding a KeyboardEvent as well to the arguments of both functions.

I didn't want to change the actual behaviour of the search modal, but I see now that it actually does need to be intercepted as it actually sticks as locked. Gonna do the change immediately.

I guess this could be handled in the existing keydown event listener just below the keypress one.

You could actually just replace it, it does the same thing, as far as I know.
Replacing it, seems to work fine.

One alternative solution could be the the HTMLDialogElement close event:

Not sure if we can classify it as supported enough, this allows you to support basically any browser. Can be added, too. But not sure it's worth doing that twice.

This would be perfect in this case but maybe the browser support is not good enough yet?

I am not sure if its the same case but we already use the dialog element and its browser support is similar to the close event. Hence I think it should be safe to use.

I am not sure if its the same case but we already use the dialog element and its browser support is similar to the close event. Hence I think it should be safe to use.

Indeed, great catch, I imagined <dialog/> being usable before Safari 15.4 but I guess I dreamed about that ^^
In this case, I guess it would make sense to use the HTMLDialogElement close event for all document.body.toggleAttribute('data-search-modal-open', false);.


the petal area makes unnecessary scroll area.

even the sample page shows us it makes scroll area, which even unstable.
it need to be fixed.

I add a style to fix it:
.sakura {
    position: relative;
}

Changing the css value to
.sakura {
  pointer-events: none;
  position: fixed; }

can fix it


Can change the event background colors of event dates instead of small indicators

Hi ,
Can change the background color of event dates instead of small indicators
Thanks

Hi, do you mean change color of the text that has a event in it? Currently this is not supported. However, if you mean something else, then please describe things a little more. Thanks.

I believe this should be aviable in version 1.9.1. Please have a look at issue #80.

is this issues resolved


[FEATURE]: Remaining Votes Tosat on Board

Screenshots

This pull request closes #226

Please see the useCreateBoard, because appears an error related with votes field.

Suggestion: see if the votes field can be optional (like votes?: string). Another approach you can Omit from BoardToAdd interface, something like this:

export interface BoardToAdd
	extends Omit<
		BoardType,
		'_id' | 'columns' | 'votes' | 'team' | 'createdBy' | 'updatedAt' | 'dividedBoards' | 'users'
	> {
	columns: CreateColumn[];
	team: string | null;
	users: BoardUserToAdd[];
	dividedBoards: BoardToAdd[];
}


Add ability to execute 'pull' command with additional args

Subject of the issue
After updating version from 1.11.0 to 1.19.1 command ::Git.open(directory, log: git_logger).pull('origin', [branch, flags]) it raises error:
gems/git-1.19.1/lib/git/lib.rb:1191:in 'command': cmd can not include a nested array (RuntimeError)
Temporarily fix is to call private method command directly:
git_instance.lib.send(:command, 'pull', 'origin', branch, flags)
Your environment

git (1.11.0) -> git (1.19.1)
Ruby 3.3.0

Steps to reproduce
g = ::Git.open(directory, log: git_logger)
branch = 'master'
flags = '--allow-unrelated-histories'

g.pull('origin', [branch, flags])

Expected behaviour
pull accept additional arguments
Actual behaviour
raises RuntimeError

The usual way that additional flags are accepted by a Git::Lib method is to explicitly pass them in.  If Git::Base#pull supported this option, it would look like:
working_git.pull('origin', 'branch', allow_unrelated_histories: true)

I would be happy to add that option for you.
For historical purposes, Git::Base#pull is documented as follows:
# pulls the given branch from the given remote into the current branch
#
#  @git.pull                          # pulls from origin/master
#  @git.pull('upstream')              # pulls from upstream/master
#  @git.pull('upstream', 'develope')  # pulls from upstream/develop
#
def pull(remote = nil, branch = nil)
  self.lib.pull(remote, branch)
end

and has been so for the last 11 years (according to git blame). I think it has been (up to now) a happy accident that your previous code worked.
Also, Git::Base#lib should be considered private (even though it actually isn't private). Good for testing and workarounds like you have done, but not for the long run.

The usual way that additional flags are accepted by a Git::Lib method is to explicitly pass them in
@jcouball Can you please tell me why this approach is used?

Why don't we let the user pass the options he wants and not adjust them directly in the code?

Thank you for the question, @lHydra, it is a good one.
I was not around when this decision was made and it wasn't documented as the 'general approach' but that is how the gem is constructed and how individual methods are documented.
I think this is a reasonable approach because many of the switches to the git command-line alter the behavior and output enough to make the git gem function incorrectly or not at all. To ensure that the gem works correctly, only options that are explicitly allowed are let through.

What do you think about the following proposal @lHydra?
Barring a change to the status quo, I think there are a few action items that can be done as a response to this issue:

Fix @lHydra problem by adding the --allow-unrelated-histories flag to Git::Base#pull.
Update the documentation for this method to be proper Yard documentation. The current documentation is lacking in both form and content.
Document somewhere the overall design of how and why git command-line options are allowed or disallowed.

What do you think about the following proposal @lHydra?
Barring a change to the status quo, I think there are a few action items that can be done as a response to this issue:
1. Fix @lHydra problem by adding the `--allow-unrelated-histories` flag to `Git::Base#pull`.

2. Update the documentation for this method to be proper Yard documentation. The current documentation is lacking in both form and content.

3. Document somewhere the overall design of how and why git command-line options are allowed or disallowed.

I think that would be a good solution @jcouball
Can I make a pull request to implement point 1 and 2?

Can I make a pull request to implement point 1 and 2?

Sounds great. Thank you.

jcouball this issue can be closed
PR: https://github.com/ruby-git/ruby-git/pull/697


Fatal X11 error with indirect rendering

Using the latest (0.194.0) on Debian Jessie, though this has been around since the 180s at least.
General system setup:

Host machine: Win 8.1

Cygwin X server, listening on TCP to allow direct connections on internal (vm-only) interface

VirtualBox VM running Debian Jessie

Has DISPLAY set to the host machine's :0.0 so I can X, multi-window, without the overhead of ssh on my local machine.

Initial situation:
Cygwin X release 1.17ish, has default -iglx flag disabling indirect GL. Chromium doesn't run, and neither does Atom.
Install the mesa SW rasterizer on the VM (as error message mentioning swrast seemed to suggest), no change.
Now:
Noticed in Cygwin X release notes the point about indirect GLX being disabled by default, so I add +iglx to my X server startup and swap swrast for the glx package in the VM. glxinfo properly shows:
ryan@jessie:~$ glxinfo |grep OpenGL
OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: GeForce GT 635/PCIe/SSE2
OpenGL version string: 1.4 (4.5.0 NVIDIA 347.52)
OpenGL extensions:

as Cygwin docs suggest it should.
No environment variable changes (only DISPLAY set): Chromium starts and works, though prints an error to the console. Atom fails to load.
ryan@jessie:~$ chromium
ATTENTION: default value of option force_s3tc_enable overridden by environment.
libGL error: No matching fbConfigs or visuals found
libGL error: failed to load driver: swrast
[6990:6990:0430/145105:ERROR:gl_context_glx.cc(107)] Couldn't make context current with X drawable.
[6990:6990:0430/145105:ERROR:gpu_info_collector.cc(46)] gfx::GLContext::MakeCurrent() failed
[6990:6990:0430/145105:ERROR:gpu_info_collector.cc(95)] Could not create context for info collection.
[6990:6990:0430/145105:ERROR:gpu_main.cc(410)] gpu::CollectGraphicsInfo failed (fatal).
[6990:6990:0430/145105:ERROR:gpu_child_thread.cc(146)] Exiting GPU process due to errors during initialization

ryan@jessie:~$ atom
ryan@jessie:~$ [7114:0430/145239:ERROR:browser_main_loop.cc(170)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[7114:0430/145239:INFO:audio_manager_pulse.cc(258)] Failed to connect to the context.  Error: Connection refused
App load time: 128ms
ATTENTION: default value of option force_s3tc_enable overridden by environment.
libGL error: No matching fbConfigs or visuals found
libGL error: failed to load driver: swrast
[7138:0430/145239:ERROR:gl_context_glx.cc(107)] Couldn't make context current with X drawable.
[7138:0430/145239:ERROR:gpu_info_collector.cc(46)] gfx::GLContext::MakeCurrent() failed
[7138:0430/145239:ERROR:gpu_info_collector.cc(95)] Could not create context for info collection.
[7138:0430/145239:ERROR:gpu_main.cc(410)] gpu::CollectGraphicsInfo failed (fatal).
[7138:0430/145239:WARNING:x11_util.cc(1490)] X error received: serial 61, error_code 151 (GLXBadContext), request_code 149, minor_code 5 (X_GLXMakeCurrent)
[7138:0430/145239:WARNING:x11_util.cc(1490)] X error received: serial 61, error_code 0 (0), request_code 149, minor_code 26 (X_GLXMakeContextCurrent)
[7138:0430/145240:ERROR:gpu_child_thread.cc(146)] Exiting GPU process due to errors during initialization
[7150:0430/145240:INFO:renderer_main.cc(212)] Renderer process started
The program 'atom' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadValue (integer parameter out of range for operation)'.
  (Details: serial 282 error_code 2 request_code 12 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

ryan@jessie:~$ atom -w
[7319:0430/145401:ERROR:browser_main_loop.cc(170)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[7319:0430/145401:INFO:audio_manager_pulse.cc(258)] Failed to connect to the context.  Error: Connection refused
App load time: 95ms
ATTENTION: default value of option force_s3tc_enable overridden by environment.
libGL error: No matching fbConfigs or visuals found
libGL error: failed to load driver: swrast
[7343:0430/145401:ERROR:gl_context_glx.cc(107)] Couldn't make context current with X drawable.
[7343:0430/145401:ERROR:gpu_info_collector.cc(46)] gfx::GLContext::MakeCurrent() failed
[7343:0430/145401:ERROR:gpu_info_collector.cc(95)] Could not create context for info collection.
[7343:0430/145401:ERROR:gpu_main.cc(410)] gpu::CollectGraphicsInfo failed (fatal).
[7343:0430/145401:WARNING:x11_util.cc(1490)] X error received: serial 61, error_code 151 (GLXBadContext), request_code 149, minor_code 5 (X_GLXMakeCurrent)
[7343:0430/145401:WARNING:x11_util.cc(1490)] X error received: serial 61, error_code 0 (0), request_code 149, minor_code 26 (X_GLXMakeContextCurrent)
[7343:0430/145401:ERROR:gpu_child_thread.cc(146)] Exiting GPU process due to errors during initialization
[7356:0430/145402:INFO:renderer_main.cc(212)] Renderer process started
The program 'atom' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadValue (integer parameter out of range for operation)'.
  (Details: serial 282 error_code 2 request_code 12 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

However, after running export LIBGL_ALWAYS_INDIRECT=1 in the terminal, I get these results. Chromium again starts and works fine. (of course, about:gpu indicates that hardware rendering is unavailable since the GPU process crashed) Atom again fails to start. (In both this case and the previous one, using the -w switch prevented backgrounding of the process, but the error doesn't actually exit the program - still shows up on a ps -a, have to ctrl-c)
ryan@jessie:~$ export LIBGL_ALWAYS_INDIRECT=1
ryan@jessie:~$ chromium
[7466:7466:0430/145510:ERROR:gl_context_glx.cc(107)] Couldn't make context current with X drawable.
[7466:7466:0430/145510:ERROR:gpu_info_collector.cc(46)] gfx::GLContext::MakeCurrent() failed
[7466:7466:0430/145510:ERROR:gpu_info_collector.cc(95)] Could not create context for info collection.
[7466:7466:0430/145510:ERROR:gpu_main.cc(410)] gpu::CollectGraphicsInfo failed (fatal).
[7466:7466:0430/145510:ERROR:gpu_child_thread.cc(146)] Exiting GPU process due to errors during initialization

ryan@jessie:~$ atom -w
[7692:0430/145655:ERROR:browser_main_loop.cc(170)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[7692:0430/145655:INFO:audio_manager_pulse.cc(258)] Failed to connect to the context.  Error: Connection refused
App load time: 111ms
[7717:0430/145655:ERROR:gl_context_glx.cc(107)] Couldn't make context current with X drawable.
[7717:0430/145655:ERROR:gpu_info_collector.cc(46)] gfx::GLContext::MakeCurrent() failed
[7717:0430/145655:ERROR:gpu_info_collector.cc(95)] Could not create context for info collection.
[7717:0430/145655:ERROR:gpu_main.cc(410)] gpu::CollectGraphicsInfo failed (fatal).
[7717:0430/145655:WARNING:x11_util.cc(1490)] X error received: serial 54, error_code 151 (GLXBadContext), request_code 149, minor_code 5 (X_GLXMakeCurrent)
[7717:0430/145655:WARNING:x11_util.cc(1490)] X error received: serial 54, error_code 0 (0), request_code 149, minor_code 26 (X_GLXMakeContextCurrent)
[7717:0430/145656:ERROR:gpu_child_thread.cc(146)] Exiting GPU process due to errors during initialization
[7725:0430/145656:INFO:renderer_main.cc(212)] Renderer process started
The program 'atom' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadValue (integer parameter out of range for operation)'.
  (Details: serial 282 error_code 2 request_code 12 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

I suspect this might actually be an Electron bug, rather than Atom itself, but I did not have time to test with just Electron and a dummy app. However, the summary is: Cygwin X doesn't appear good enough for Chromium's GPU process, yet Chromium manages to finish starting and work, while Atom gets additional error messages and fails to display an interface.

Plot thickens: --disable-gpu does actually do something - doesn't try to start the ill-fated GPU process, but still fails:
ryan@jessie:~/.atom$ LIBGL_DEBUG=verbose atom -w --disable-gpu
[9087:0430/151702:ERROR:browser_main_loop.cc(170)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[9087:0430/151702:INFO:audio_manager_pulse.cc(258)] Failed to connect to the context.  Error: Connection refused
App load time: 101ms
[9115:0430/151702:INFO:renderer_main.cc(212)] Renderer process started
The program 'atom' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadValue (integer parameter out of range for operation)'.
  (Details: serial 282 error_code 2 request_code 12 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

Got a backtrace from gdk_x_error:
ryan@jessie:~$ gdb --args /usr/share/atom/atom --sync
GNU gdb (Debian 7.7.1+dfsg-5) 7.7.1
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /usr/share/atom/atom...(no debugging symbols found)...done.
(gdb) break gdk_x_error
Function "gdk_x_error" not defined.
Make breakpoint pending on future shared library load? (y or [n]) y
Breakpoint 1 (gdk_x_error) pending.
(gdb) r
Starting program: /usr/share/atom/atom --sync
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[9745:0430/152949:ERROR:browser_main_loop.cc(170)] Running without the SUID sandbox! See https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment for more information on developing with the sandbox on.
[New Thread 0x7fffe5fdb700 (LWP 9749)]
[New Thread 0x7fffe55ce700 (LWP 9751)]
[New Thread 0x7fffe4bc0700 (LWP 9752)]
[New Thread 0x7fffe43bf700 (LWP 9754)]
[New Thread 0x7fffe3bbe700 (LWP 9755)]
[New Thread 0x7fffe30fd700 (LWP 9757)]
[New Thread 0x7fffe28fc700 (LWP 9758)]
[New Thread 0x7fffe20fb700 (LWP 9759)]
[New Thread 0x7fffe20da700 (LWP 9760)]
[New Thread 0x7fffe20b9700 (LWP 9761)]
[New Thread 0x7fffdeeb1700 (LWP 9762)]
[9745:0430/152949:INFO:audio_manager_pulse.cc(258)] Failed to connect to the context.  Error: Connection refused
[Thread 0x7fffe20b9700 (LWP 9761) exited]
[Thread 0x7fffdeeb1700 (LWP 9762) exited]
[New Thread 0x7fffdeeb1700 (LWP 9763)]
[New Thread 0x7fffe20b9700 (LWP 9764)]
[New Thread 0x7fffde6b0700 (LWP 9765)]
[New Thread 0x7fffddeaf700 (LWP 9766)]
[New Thread 0x7fffdd6ae700 (LWP 9767)]
[New Thread 0x7fffdcead700 (LWP 9768)]
[New Thread 0x7fffdc6ac700 (LWP 9769)]
[New Thread 0x7fffdbeab700 (LWP 9770)]
[New Thread 0x7fffdb6aa700 (LWP 9771)]
App load time: 228ms
[New Thread 0x7fffdac9a700 (LWP 9774)]
[New Thread 0x7fffda499700 (LWP 9775)]
[New Thread 0x7fffd9c98700 (LWP 9776)]

Breakpoint 1, gdk_x_error (display=0x2f677d720800, error=0x7fffffffdfa0) at /build/gtk+2.0-czQfyJ/gtk+2.0-2.24.25/gdk/x11/gdkmain-x11.c:458
458	/build/gtk+2.0-czQfyJ/gtk+2.0-2.24.25/gdk/x11/gdkmain-x11.c: No such file or directory.
(gdb) bt
#0  gdk_x_error (display=0x2f677d720800, error=0x7fffffffdfa0) at /build/gtk+2.0-czQfyJ/gtk+2.0-2.24.25/gdk/x11/gdkmain-x11.c:458
#1  0x00007ffff04e345d in _XError () from /usr/lib/x86_64-linux-gnu/libX11.so.6
#2  0x00007ffff04e03c7 in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6
#3  0x00007ffff04e0485 in ?? () from /usr/lib/x86_64-linux-gnu/libX11.so.6
#4  0x00007ffff04e0e35 in _XEventsQueued () from /usr/lib/x86_64-linux-gnu/libX11.so.6
#5  0x00007ffff04d2777 in XPending () from /usr/lib/x86_64-linux-gnu/libX11.so.6
#6  0x00007fffefb8b8c1 in g_main_context_check (context=context@entry=0x2f677d602900, max_priority=2147483647, fds=fds@entry=0x2f677d856380, n_fds=n_fds@entry=4) at /tmp/buildd/glib2.0-2.42.1/./glib/gmain.c:3622
#7  0x00007fffefb8be83 in g_main_context_iterate (context=context@entry=0x2f677d602900, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at /tmp/buildd/glib2.0-2.42.1/./glib/gmain.c:3778
#8  0x00007fffefb8bffc in g_main_context_iteration (context=0x2f677d602900, may_block=1) at /tmp/buildd/glib2.0-2.42.1/./glib/gmain.c:3842
#9  0x00007ffff4004752 in base::MessagePumpGlib::Run(base::MessagePump::Delegate*) () from /usr/share/atom/libchromiumcontent.so
#10 0x00007ffff406beb0 in base::RunLoop::Run() () from /usr/share/atom/libchromiumcontent.so
#11 0x00007ffff4104fef in content::BrowserMainLoop::MainMessageLoopRun() () from /usr/share/atom/libchromiumcontent.so
#12 0x00007ffff4104f60 in content::BrowserMainLoop::RunMainMessageLoopParts() () from /usr/share/atom/libchromiumcontent.so
#13 0x00007ffff410805d in ?? () from /usr/share/atom/libchromiumcontent.so
#14 0x00007ffff4100573 in content::BrowserMain(content::MainFunctionParams const&) () from /usr/share/atom/libchromiumcontent.so
#15 0x00007ffff3ffaa15 in ?? () from /usr/share/atom/libchromiumcontent.so
#16 0x00007ffff3ff96c0 in content::ContentMain(content::ContentMainParams const&) () from /usr/share/atom/libchromiumcontent.so
#17 0x000000000066c48b in main ()
(gdb)


Igus rails in BoM -- are these needed?

The following parts are listed in the BoM's but not shown in the instruction manual or the CAD assembly:
LINEAL GUIDES IGUS-WSQ_06-134mm
LINEAL GUIDES IGUS-WSQ_06-114mm
LINEAL GUIDES IGUS-WSQ_06-080mm
Am I missing something or are these not needed?
Thanks!!

I'm using regular 8mm rod (shafting) I don't see the need for lineal guides. They are in fact joint axles. Don't skimp on the bearings. I bought some cheep ones and they are unusable.

Hi @dtmille2 and @ShopMonkey
We've updated the BOM file. Please take a look and get back to me.
https://github.com/BCN3D/BCN3D-Moveo/commit/0866a92501277636f76000a195d8a16d44b5b476
Thanks for the feedback!

Thanks for updating the BoM, the additional stepper motor part numbers are great.
Unfortunately items 12, 13, and 14 are still not fully defined -- what diameter should the bars be?  6mm?


chore: Move LICENSE file so that it is detected by GitHub

This project was flagged because it is public, but does not have any license detected by GitHub.
As both sub-projects use the same LICENSE, we can use a single LICENSE file at the root.

Looks good, thanks for the PR!


Add better async form lifecycle to Post Editor.

Currently, when a user hits submit on this form, if there are no validation errors we just finish with a :noreply response.
Ideally, the form should still be disabled and the user enter a holding pattern while we wait for the pubsub message that the post is ready for the redirect.
If an unanticipated time passes, we could show an error flash to the user.
I'm hesitant to show a success flash before the redirect because it should be quick and if it is too fast for the user to read the message, it will feel strange.

I'm going to close this because a) we have moved on from the Post noun -- it will go away soon™. and b) because I think the Article form is handling validations and redirects based on pubsub.


Fix default layout import path for authUtil

Fixes #144

template default auth layout with formatFilePath method

@nicoalbanese would appreciate a look at this if you get a chance. Fixes some issues with using import aliases in nextjs.
Let me know if you prefer a different solution as well. This one just seemed like the most minimal and follows some other patterns already in the codebase. Thanks 🙏

Hey 👋🏻 sorry haven't gotten to this sooner! Thanks for pulling together and looks good


looking-glass-client: B4 -> B5.0.1

Motivation for this change
https://www.patreon.com/posts/looking-glass-5-60336916
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Tested myself and with nixpkgs-review.
LGTM

There's a tag out for B5.0.1 with a segfault fix https://github.com/gnif/LookingGlass/releases/tag/B5.0.1

Thanks for pointing that out, I just updated it

changelog mentions

removed SDL displayserver

so I don't think this can be backported.

changelog mentions

removed SDL displayserver

so I don't think this can be backported.

Ahh that's a shame.

Ahh that's a shame.

How is that a problem?

Not being able to backport it because of the SDL change.
It's nothing serious lol.

But how does the SDL change make this unable to be backported? B4 already didn't use SDL and was only still a buildInput because it provided an x11 or opengl dependency.
https://github.com/gnif/LookingGlass/blob/B4/client/CMakeLists.txt#L35

I just tested the windows host from B4 and B5 isn't compatible with it anyways.

I'm not entirely sure.
@symphorien could you elaborate?

It looks like the new version removes a feature, so it's not full backward compatible. If someone uses this feature in 21.11, it should continue working for the whole lifetime of 21.11.

Also, let me remind you that it's easy to use the new version of looking glass while remaining on 21.11: https://nixos.wiki/wiki/FAQ#How_can_I_install_a_package_from_unstable_while_remaining_on_the_stable_channel.3F