inGamut check for HSL and other sRGB cylindrical spaces

Problem Description
I don't think the conversion is a bug, but I am more questioning the inGamut check, though I understand what it is doing, and technically it isn't wrong. I am more curious if this is known and accepted, or unknown and not yet considered. Consider the following:
> let color = new Color("lab(100% 0 0)").to('hsl')
undefined
> color.toString()
'hsl(32.624 493.346% 99.998%)'
> color.inGamut()
true

We can see in this example that saturation, after conversion, is well past the accepted constraints, and yet, this HSL color is considered "in gamut".
Now, I know that HSL is not checked for "in gamut" by comparing its own coords, but is actually checked in the sRGB space with an allowable threshold. So, on the one hand, this makes sense:
> let color2 = new Color("lab(100% 0 0)").to('srgb')
undefined
> color2.toString()
'rgb(100.01% 99.999% 99.989%)'

As can be noted above, the conversion directly to sRGB is far less jarring.
Now, I understand that the conversion algorithm for HSL is designed for values within the constraints of a color that is in gamut, and once colors are out of gamut (even if they are only slightly out of gamut) may not yield values a user expects, and that is not necessarily wrong. I am more interested in the idea of whether the HSL value should actually be considered "in gamut" even if it is technically not too far out of the sRGB gamut. In HSL, the color is wildly out of range.
The reason why this seems problematic is if I am trying to well form my cylindrical sRGB values, they do not actually register as out of bounds with the inGamut check. If you run toGamut('srgb'), the value is fit without the "tolerance" allowed before, and you will actually get a sane value. You just have no way of testing that it is out of bounds without manual introspection:
> color.toString()
'hsl(32.624 493.346% 99.998%)'
> color.inGamut()
true
> color.toGamut('srgb').toString()
'hsl(54.251 100% 99.995%)'

Surprisingly, toGamut('hsl') does not seem to redirect to the srgb logic either.
> color.toGamut('hsl').toString()
'hsl(32.624 493.346% 99.998%)'

Question
So my question is: should HSL also evaluate its own coords in addition to the sRGB constraint check? Or is this a known and accepted behavior?
I know that HSL is simply a representation of the sRGB color, and the gamut is the same, but it also seems that values that are wildly out of range should also be flagged as "out of gamut". I also think that toString should gamut map the HSL color in this case.

I originally thought that if a strict inGamut with no tolerance was used that HSL would always be constrained when sRGB proved "in gamut". But this example has made me think otherwise:
> var color = new Color('hsl(100 300% 100%)')
undefined
> color
Color$1 {
  _spaceId: 'hsl',
  toString: [Function: toString],
  coords: [ 100, 300, 100 ],
  alpha: 1
}
> color.to('srgb')
Color$1 {
  _spaceId: 'srgb',
  toString: [Function: toString],
  coords: [ 1, 1, 1 ],
  alpha: 1
}
> color.to('srgb').coords
[ 1, 1, 1 ]

It seems you'd almost have to check the HSL constraints just due to how the algorithm operates. The above converts to a white with no decimals at all.

I will admit that the example of hsl(100 300% 100%) is a bit contrived, and probably wouldn't occur via normal conversion, but probably only through direct manipulation. Maybe a strict "in gamut" check (or at least the option of a strict "in gamut" check), coupled with color spaces like HSL also evaluating their own constraints would be enough.

Sanity checking for HSL (and HWB) colors seems different to gamut checks. The resulting color isn't out of gamut, it can't be plotted for example on a chromaticity diagram.
That said this recent change Do not check gamut in polar spaces  makes clear that in-gamut checks on polar spaces are conducted in the base, rectilinear space from which the polar space is derived.
Which is also what CSS Color 4 12. Converting colors now says, too. There is an explicit gamut mapping step before conversion from sRGB to HSL or HWB.

Okay, so I imagine, from a color.js perspective, that a strict, zero-tolerance check would be preferrable when converting from sRGB to HSL as it is possible that an out-of-gamut sRGB color that is within the gamut check's threshold could give a wildly out of spec HSL value, even if it is technically only just out of gamut for the rectangular space.
For instance:
let color = new Color("color(srgb 1 1 1.00001)").to('hsl');

yields: hsl(0 -100% 100%).
Or is this not really a concern?
I guess gamut checking in general though could, if clearly noted, still yield in gamut for hsl(0 -100% 100%) if testing it with inGamut as technically it is within the rectangular space's threshold, but it seems during conversion at least, that it would be preferable to use a zero-tolerance check to ensure the conversion is not wildly out of spec. At least that is what I'm thinking, curious about your thoughts?

Also what CSS Color 4 says about valid HSL values:

For saturation, 100% is a fully-saturated, bright color, and 0% is a fully-unsaturated gray. For lightness, 50% represents the "normal" color, while 100% is white and 0% is black. If the saturation or lightness are less than 0% or greater than 100%, they are clamped to those values at computed value time, before being converted to an sRGB color.

So S = 300% is fine, but becomes S = 100% before any conversion to another color space.

And we should do that clip in color.js, which we currently do not

I suspect this bug (look at the -92000 saturation value when the coords are inspected, but this is hidden by gamut mapping prior to serialization) is caused simply by the method for sRGB TO HSL do no gamut mapping or gamut clipping but instead, passing values greter than 1 or less than 0 directly to the hokey HSL algorithm which was never designed to accommodate them.
The solution is to follow CSS Color 4 and put sRGB values in-gamut before conversion to HSL.

I was aware the CSS spec mentioned clamping these values, but I've also seen it mentioned outside the spec that they should be gamut mapped.

Two different things. The spec says that out-of-range HSL values must be clamped, before they are converted to sRGB. It also says that out of gamut sRGB values must be gamut mapped, before they are converted to HSL (or HWB).

That still doesn't prevent people creating colors with HSL values out of range.

No my earlier commit, since reverted for debugging of the other problem, is what did that.

The spec says that out-of-range HSL values must be clamped, before they are converted to sRGB. It also says that out of gamut sRGB values must be gamut mapped, before they are converted to HSL (or HWB).

Neither of those statements are now true; hsl() in CSS Color 4 is mostly clamping free, to allow round-tripping of out of gamut values, so there is no built-in gamut mapping either. (For web compat and CSS Color 3 alignment,, legacy syntax hsl() clamps negative saturation).


Where can I find pretrained embeddings?

Hello, I see some of the models for mt task, such as fconv, can be supplied with pretrained embeddings given argument --encoder-embed-path or --decoder-embed-path. Docs do not specify where pretrained embeddings files can be downloaded from. I am interested in embeddings for a iwslt14 with BPE for research purposes. Could you help me with it?

This is easy for that if you could load a pretrained or simply create model with named_parameters function, you could change and get all parameters in the model


Why are we publishing multiple firestore packages to npm?

I was told that I should try firestore. Searching on npm, I found that we are publishing two distinct packages

This one, as @google-cloud/firestore.
@firebase/firestore.

As a Node.js developer, this is incredibly confusing to me. Why is Google shipping two different packages? Which one am I supposed to use?
/cc @JustinBeckwith @lukesneeringer @jonparrott

The @firebase/firestore is the Node version of the fully-fledged Web SDK. The main differentiator is its support for latency compensation and an authentication model that is centered around third-party auth.
@google-cloud/firestore is our Admin SDK for Firestore. It is meant to directly interact with the Firestore backend and all data is directly retrieved from the backend. The Server SDK also uses Service Account-based authentication and is meant to be run in trusted environments.
I agree that our messaging could be improved here and will open an internal issue to improve our documentation.


Add Before Callbacks to Authenticators

While I was programming, I noticed that I wanted to transform some of the data and save it as a record in the data store. To do this, I had to copy the source code and then add then modify the code. It then occurred to me that this project could benefit from having before callbacks.
The purpose of the before callbacks would allow developers to touch the data before a restore, reject, or authentication happens.
I'm just getting started with Ember, so this PR is more of a concept/discussion generator than anything else.

This would probably be solved much easier by extending the default devise authenticator and overriding authenticate, restore and invalidate, e.g.:

Hmmm I thought about doing that in my application, but I noticed that I needed to dig into the data/response information. Which mainly had to happen here: https://github.com/simplabs/ember-simple-auth/pull/963/files#diff-719e859d3a0317bb511a3b40c7ee9598R122.

So you can just override makeRequest then:
makeRequest() {
  return this._super(...arguments).then((data) => {
    //modify data
    return data;
  });
}

Hmm... This is essentially what I'm doing:
  makeRequest(data) {
    return this._super(data).then(
      (response) => {
        response.data.type = 'user';
        this.get('store').pushPayload(response);

        response.email = response.data.attributes.email;
        response.token = response.data.attributes.token;
      },
      (xhr) => run(null, reject, xhr.responseJSON || xhr.responseText)
    );
  }

Thanks for the effort but I don't think before/after callbacks really add enough value to justify the increased complexity and growing API surface.

Perhaps we could add some public methods instead? I still feel that "hooking" in is the best in my case. What about:
restore(data) {
  ...

  if (!isEmpty(tokenAttribute) && !isEmpty(identificationAttribute)) {
    resolveRestore(data);
  } else {
    rejectRestore();
  }
},

authenticate(identification, password) {
  return new Promise((resolve, reject) => {
    ...

    return this.makeRequest(data).then(
      (response) => runAuthenticate(null, resolve, response),
      (xhr) => run(null, reject, xhr.responseJSON || xhr.responseText)
    );
  });
}

runAuthenticate() {
  Ember.run(null, resolve, response);
},

resolveRestore(data) {
  return Promise.resolve(data);
},

rejectRestore(data) {
  return Promise.reject();
}

This way, if you wanted to hook in, you could do:
  runAuthenticate(resolve, response) {
    response.data.type = 'user';
    this.get('store').pushPayload(response);

    response.email = response.data.attributes.email;
    response.token = response.data.attributes.token;

    return this._super(resolve, response)
  },

  resolveRestore(data) {
    this.get('store').push(data);
    return this._super(data)
  }

What's wrong with overriding, calling _super and modifying input arguments before or return values after?

I don't think I actually get the return values I would expect. So, maybe a few questions:

Is there a way to tell if the promise returned by restore() is a Promise.reject() or a Promise.resolve()?
Am I able to access the data in the Promise.resolve()?
When I tried the _super() for authenticate() it broke the session storage. I was setting the response.email and response.token via the data attributes. It didn't seem to work :/. However, the pushPayload(response) worked fine...

You can do this to modify the data that the promise returned by _super resolves with:
restore(data) {
  // do stuff before restore
  return this._super(...arguments).then((data) => {
    // do stuff after restore
    return data;
  });
}

Since its 1pm now and not 1am for me, here was the work end result of the refactor you suggested @marcoow. Just leaving it here for historical reasons:
import Ember from 'ember'
import Devise from 'ember-simple-auth/authenticators/devise';

export default Devise.extend({
  store: Ember.inject.service(),

  restore(data) {
    return this._super(data).then((data) => {
      this.get('store').push(data);
    });
  },

  makeRequest(data) {
    return this._super(data).then((response) => {
      response.data.type = 'user';
      this.get('store').pushPayload(response);

      response.email = response.data.attributes.email;
      response.token = response.data.attributes.token;

      return response;
    });
  }
});


Bird age ringing: duplicates found

The same anomalies in bird ringing date (see #8) are also anomalies for bird age ringing.

Automatically solved by solving #8.
For double check, use this code:
duplicates_ringing_bird_age <- obs_and_acts %>%
  filter(raw_AktieCode %in% c("rngkl", "rngme")) %>%
  filter(raw_KleurringNummer %in% (
    obs_and_acts %>%
      filter(raw_AktieCode %in% c("rngkl", "rngme")) %>%
      group_by(raw_KleurringNummer, raw_LeeftijdCode, raw_Datum, raw_AktieCode) %>%
      count() %>%
      filter(n > 1) %>%
      pull(raw_KleurringNummer))) %>%
  arrange(raw_KleurringNummer)
duplicates_ringing_bird_age

Same code used for checking presence of duplicates of datum ringing, except for  the additional variable raw_LeeftijdCode in group_by().


FR (Performance): Refactor and replace TempPath with a native cache path

As discussed in https://github.com/pwsh-cs-tools/core/pull/46, deprecating the TempPath may be warranted.
There are 4 approaches considered to this problem:

Don't deprecate or change it
Support 3 caching paths (1 for CachePath, 1 for the Legacy TempPath, 1 for the new native cache path)
Replace the old TempPath, but only comment out its code so that it can be maintained.
Another option is to move the legacy code into this issue instead of commenting it out.

This would allow us to have a copy of the legacy code to revert to without a performance impact

Probably going to resort to the latter.
EDIT: Currently planned solution:- https://github.com/pwsh-cs-tools/core/issues/49#issuecomment-1898389518

Prior Code: https://github.com/pwsh-cs-tools/core/tree/v0.5.4-beta
TempPath generation:
Import-Package.psm1:
Module Initialization Garbage Collector (called once per PowerShell session):
& {
    # Clear the Cache
    Write-Verbose "[Import-Package:Init] Clearing Temp Files..."
    Resolve-Path (Join-Path $PSScriptRoot "Temp" "*") | ForEach-Object -Parallel {
        $id = $_ | Split-Path -Leaf
        [bool] $freed = $false
        $m = New-Object System.Threading.Mutex( $false, "Global\ImportPackage-$id", [ref] $freed )
        If( $freed ){
            Remove-Item $_ -Recurse -ErrorAction Stop
        }
        $m.Dispose()
    } -ThrottleLimit 12 -AsJob | Out-Null
}

Import-Package Function
Parameters block
param(
    # ...
    [string] $TempPath
    # ...
)

TempPath path-string and mutex-lock generation
$temp_path_generated = If( [string]::IsNullOrWhiteSpace( $TempPath ) ){
    $TempPath = & {
        $parent = & {
            Join-Path ($CachePath | Split-Path -Parent) "Temp"
        }
        [string] $uuid = [System.Guid]::NewGuid()

        # Cut dirname in half by compressing the UUID from base16 (hexadecimal) to base36 (alphanumeric)
        $id = & {
            $bigint = [uint128]::Parse( $uuid.ToString().Replace("-",""), 'AllowHexSpecifier')
            $compressed = ""

            # Make hex-string more compressed by encoding it in base36 (alphanumeric)
            $chars = "0123456789abcdefghijklmnopqrstuvwxyz"
            While( $bigint -gt 0 ){
                $remainder = $bigint % 36
                $compressed = $chars[$remainder] + $compressed
                $bigint = $bigint/36
            }
            Write-Verbose "[Import-Package:Preparation] UUID $uuid (base16) converted to $compressed (base$( $chars.Length ))"

            $compressed
        }

        $mutexes."$id" = New-Object System.Threading.Mutex($true, "Global\ImportPackage-$id") # Lock the directory from automatic removal

        Join-Path $parent $id

        # Resolve-Path "."
    }
    $true
} Else {
    $false
}

Runtime Garbage Collector (called on every Import-Package call)
If( $temp_path_generated -and (Test-Path $TempPath) ){
    If( Test-Path (Join-Path $TempPath "*") ){
        Write-Verbose "[Import-Package:Loading] Temp files: $TempPath"
    } Else {
        Remove-Item -Path $TempPath -ErrorAction Stop
    }
}

The function also makes calls to $Bootstrapper.LoadNative() which actually handles the resource copying. Use Ctrl+Shift+F in VS Code and See below

That's something else I will have to look at.
The problem with native files, is that NuGet doesn't define how C# is supposed to load them, just that they are associated with the wrapping package.

I really liked how temppath gen worked in my script. I put a lot of work and thought into it. Using cross-process mutex-locks for garbage collection was definitely one of my best pieces of work, considering the size of the gc code.
I am sad to see it go, but it definitely needs to happen.
I wrote a .psm1 gist that separates my temppath creation and the temppath gc in case I want to use it in a different module later:

https://gist.github.com/anonhostpi/131ff50d0ab648daaf64d2aaa98e160f

Azure.Monitor.OpenTelemetry.Exporter

What error are you getting? I'm getting PackageManagement/Install-Package errors.

Another problem I am going to have to tackle is caching of dependency native dlls.
The purpose of the TempPath was to provide each of the NuGet libraries a central place to deposit their native files. A lot of native files require that their dependencies be in the same root directory.

This is a widely adopted practice in C-based langs.

So switching from a TempPath to a native cache may introduce a new and different file bloat problem.
Each dependency in the dependency tree with native files would need to have its own implementation of the new TempPath. This would be a blessing and a curse.

CON: A lot of files would be duplicated

this would have a negative impact on Import-Package's total file footprint

PRO: They would be pre-extracted

this would have a positive impact on Import-Package's load speed

So what I'm thinking is that I should:

just remove TempPath's garbage collector
keep the majority of TempPath logic the same

change the naming convention to match that of CachePath
add a cache check to look for pre-extracted files when iterating over dependencies
only generate a new TempPath for the package at the base of the dependency tree (which is the current legacy behavior)

https://github.com/pwsh-cs-tools/core/commit/c118580dd66dc25bdc48102d63776817e7c6382e:
Introduced the FullName field on the PackageData object generated by Build-PackageData
This uses the LeafBase of the package's Source property. This should cover these cases:

Packages downloaded from NuGet.org and loaded with -Path and NOT renamed
Cached SemVer2 packages
PackageManagement packages

This will not cover these 2 cases:

Package downloaded from NuGet or built locally, and not named using PackageManagement's current naming convention

This could potentially be fixed by parsing the nuspec
This would present a design challenge, as the Cached files are designed to be handled by Resolve-CachedPackage, but the nuspec is handled later in Build-PackageData

Changes to PackageManagement's naming convention will be covered, but will negatively affect cached packages coverage

If PackageManagement or NuGet open sources its naming convention and makes it available as a library, it may be possible to import said library and use that in Resolve-CachedPackage

Holy moly! The last change has been implemented and the load performance from caching the native files is insane. Loading Avalonia.Desktop and Microsoft.ClearScript has been brought down from around 10-13 seconds to 2 and a half seconds.

+1, sharing the temp path causes errors if two packages contain the same file eg large depencency trees like Azure.Monitor.OpenTelemetry.Exporter

@pl4nty see #50, #51, and the OneGet Issue

Thanks, you're right it's in OneGet. For now I'm loading the conflicting packages separately. The load time improvements are very noticeable by the way, well done!

Thanks, much appreciated. For this bug I can just load the conflicting package first, but for others I've had to resort to nupkgs

FYI - I used your package to port .NET OpenTelemetry to PowerShell! it was really useful for testing, and figuring out how to call C# extension methods

For this bug I can just load the conflicting package first, but for others I've had to resort to nupkgs

It looks like for that problem, you could likely use a newer version of the package. Import-Package's version handling for NuGet version ranges is limited. It currently can't handle unbounded version ranges very well. I'm working on that problem with #50

btw I started the repo split for New-ThreadController and Import-Package, since issues like #50 require a complete refactor:

https://github.com/pwsh-cs-tools/Import-Package

Once I can get a release published from the new repo, I will archive this one.


Meshlet example fails to compile

Bevy version
0.14.0
$ git log
commit b231ebbc195e12ae47616748e532c8dbc24218dd (HEAD, tag: v0.14.0, origin/release-0.14.0, origin/latest, release-0.14.0)

It was also failing on the main branch.
[Optional] Relevant system information
Windows 10
$ cargo --version
cargo 1.79.0 (ffa9cf99a 2024-06-03)

What you did
$ cargo run --example meshlet --features=meshlet
   Compiling bevy_pbr v0.14.0 (D:\projects\bevy\crates\bevy_pbr)
error[E0599]: no method named `grow_to` found for struct `RangeAllocator` in the current scope
  --> crates\bevy_pbr\src\meshlet\persistent_buffer.rs:52:33
   |
52 |         self.allocation_planner.grow_to(buffer_size.end + new_size);
   |                                 ^^^^^^^ method not found in `RangeAllocator<u64>`

For more information about this error, try `rustc --explain E0599`.
error: could not compile `bevy_pbr` (lib) due to 1 previous error

What went wrong
The meshlet example fails to compile.
Additional information

What version of range-alloc is in your Cargo.lock? Is it less than 0.1.3?

$ cat Cargo.lock | grep -A5 range-alloc
 "range-alloc",
 "serde",
 "smallvec",
 "static_assertions",
 "thiserror",
]
--
name = "range-alloc"
version = "0.1.2"

Sorry for the noise :(
cargo update resolves the issue. Closing.

No worries, we should still pin bevy to 0.1.3+ explicitly, as 0.1 is not specific enough given that the crate did not follow semver properly. I will open a PR to fix this.


build-script: build static version of libdispatch

build and install libdispatch static.  We now build libdispatch using
CMake, which does not easily generate static and shared versions of
libraries.  Create two builds to populate the toolchain distribution.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please smoke test

@swift-ci please build toolchain

@swift-ci please smoke test

@swift-ci please build toolchain

Please test with following PRs:
https://github.com/apple/swift-corelibs-libdispatch/pull/433
@swift-ci please test

Please test with following PRs:
https://github.com/apple/swift-corelibs-libdispatch/pull/433
@swift-ci please build toolchain

Build failed
Swift Test OS X Platform
Git Sha - da94a8b44b451de9ab52f49e7147f3bfe441ee6b

Build failed
Swift Test Linux Platform
Git Sha - da94a8b44b451de9ab52f49e7147f3bfe441ee6b

Please test with following PRs:
apple/swift-corelibs-libdispatch#433
@swift-ci please build toolchain

Please test with following PRs:
apple/swift-corelibs-libdispatch#433
@swift-ci please build toolchain

@swift-ci please smoke test and merge

@swift-ci please smoke test and merge


rename bearer to session

part of hoodiehq/hoodie#490

LGTM :+1:

Other than the possibility of uppercasing the s in session, LGTM 👍

LGTM :)

LGTM :) But I think we should change session to Session


Add few trained agents that can be enjoyed

Add few trained agents to the repository, with as small network architectures as possible to reduce the size (number of parameters), e.g.:

Reach
ReachOctree (with color?)
GraspOctree (with color?)
... ?

Docker seems to be the most straightforward way to enjoy these agents for outside users. So target that first...

Addressed by https://github.com/AndrejOrsula/drl_grasping/pull/83 with addition of three different agents, might add others later is there is any interest.


Storypath: Fixes bugs found in reserve

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[X] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[ ] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Bug Fixes

Sheet should now default to using the scion2e compendium
Birthrights are now usable when in scion: origin mode
Equipment/birthrights should now drop correctly

Character Sheet Info Roll20 Internal Use only.


Allow parallel queries in datasource backend

Moves the go BigQuery backend to run queries in parallel rather than serially.
A couple tidies
Adds a script to build the release zip
Removes compiled binaries from the repo

It turns out this code is not actually used anywhere. The requests to BigQuery are done in the TypeScript. This code is a lie.

Is this PR relevant, then?

Not here. It's used in the new trace datasource, and I think the functionality of this plugin could/should be moved to that one, and done using the newer style, like the new one.


Documentation update

Hi, I added documentation about how to implement custom policies and override views
Many thanks for your work !

OK I didn't have the time to implement this.
I'll try to, but no guarantee ;)

No problem for the resources views, but the policy files are a bit different.
Do you still think I need to write the code to publish the policies ?

Nah, you can skip the policies.


Javascript editor duplicate characters

Javascript editor duplicate characters
How to reproduce the bug

Go to new chart with deck.gl Screen Grid
Enable ENABLE_JAVASCRIPT_CONTROLS and start input characters into window
Input "1234"
See error

Expected characters in this window "1234", actual characters "1234123121"
Expected results
1234
Actual results
1234123121
Screenshots

Environment

browser type and version: Chrome Version 97.0.4692.71 (Official Build) (x86_64)
superset version: 1.4.0
python version: Python 3.8.10
node.js version: v10.19.0
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[V] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[V] I have reproduced the issue with at least the latest released version of superset.
[V] I have checked the issue tracker for the same issue and I haven't found one similar.

Hey @hashbash did the fix address your issue?
https://github.com/apache/superset/pull/18146
If so, please close this issue :)


Certain shields make you less resistant to damage

Description
Shields like the buckler, take twice as much heat damage. I'm not sure it's intended to also make you take twice as much heat damage.
Reproduction
use a buckler, mirror shield, or clockwork shield.
Screenshots

Additional context

i think buckler makes sense since wood is flammable
the rest is probably wrong

But why would it kill you? If the shield caught on fire you'd just drop it.


Shaheen/default protection

The primitive types namespace is a little off (Contracts.CqApi at the end), but I thought I'd fix that in the next significant change of PrimitiveTypes instead of releasing a new version and doing the whole update stuff for a namespace rename.


Add trace functions

I ended up doing this locally while debugging some things and thought it might be useful in core.

Ping @mitchellh

This is interesting but I don't want to add this overhead to every single function call. I'd rather defer users to wrap their own methods in trace calls if they're debugging something.

Fair enough :smile:


new container on default network take the gateway ip

Hello,
just saw that if we create a container on the socketplane default network, the provided ip from that network for this container is <IP_ADDRESS> like the one for the default interface on the host...
I don't know if it's a good practice to create container on the default network but I think reusing the default interface IP from host in the container should be avoided...
Tell me what you think.
Regards,
Mathilde

@mffrench This is a bug. We rely on the IPAM module to give us an unused ip-address on a given subnet range. IPAM makes use of Consul to maintain this state. There could be some race condition in which the local consul cache that we maintain in ecc doesn't cleanly cut-over to the Consul Distributed Cache when the cluster is actually formed.
We will use this issue to identify such a race-condition and fix it. Thanks for bringing it up.

@mavenugo a pleasure to help you improve socketplane : continue the good work ;)


Allow -o option as a shortcut for --output-path

Summary
--output-path is quite verbose for one of the most common options of the convert command. It's common for other utilities to provide a short -o option for specifying output. E.g. both swiftc and clang provide -o for specifying its output files. This is also the case for other conversion utilities that don't output to stdout by default.
Dependencies
N/A
Testing
Pass -o to convert in place of --output-path or run the test suite, which now tests both options.
Checklist

[x] Added tests
[x] Ran the ./bin/test script and it succeeded
[x] Documentation automatically updated by ArgumentParser.

@swift-ci test

@swift-ci test


The correct method of passing Positional Arguments to this tool.

Based on the document here, I tried to call this tool as follows, but failed:
(datasci) werner@X10DAi:~/Public/hpc/vasp/learning-by-doing/optical-absorption-spectra/sumo$ sumo-optplot -f ./vasprun.xml absorption eps_imag
Traceback (most recent call last):
  File "/home/werner/.pyenv/versions/datasci/bin/sumo-optplot", line 33, in <module>
    sys.exit(load_entry_point('sumo', 'console_scripts', 'sumo-optplot')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/werner/Public/repo/github.com/SMTG-UCL/sumo.git/sumo/cli/optplot.py", line 455, in main
    optplot(
  File "/home/werner/Public/repo/github.com/SMTG-UCL/sumo.git/sumo/cli/optplot.py", line 166, in optplot
    vr = Vasprun(filename)
         ^^^^^^^^^^^^^^^^^
  File "/home/werner/Public/hpc/tools/materialsproject/pymatgen.git/pymatgen/io/vasp/outputs.py", line 363, in __init__
    with zopen(filename, "rt") as f:
         ^^^^^^^^^^^^^^^^^^^^^
  File "/home/werner/.pyenv/versions/datasci/lib/python3.11/site-packages/monty/io.py", line 45, in zopen
    return open(filename, *args, **kwargs)  # pylint: disable=R1732
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'absorption'

Any tips will be helpful.
Regards,
Zhao

When calling as sumo-optplot -f ./vasprun.xml absorption eps_imag there is some ambiguity because -f can take multiple files. To avoid this ambiguity, either:

use a keyword argument that doesn't take a variable number of inputs before the positional argument

e.g. sumo-optplot -f ./vasprun.xml -c vasp absorption eps_imag

use the positional argument(s) before any keywords

e.g. sumo-optplot absorption eps_imag -f ./vasprun.xml

This way works:

$ sumo-optplot absorption loss eps_real eps_imag n_real n_imag -f ./vasprun.xml

As shown below:

This way doesn't work:

$ sumo-optplot -f ./vasprun.xml -c vasp absorption loss eps_real eps_imag n_real n_imag

As shown below:

Additional questions:

As you can see, in the multiple subplots generated by multiple Positional Arguments, the font size is very unreasonable, how to solve this problem automatically?
How do I have sumo automatically set --xmax and --ymax to generate a plot containing all value ranges of variables?

Sumo has a default figure size that is set by style sheets and not influenced by the number of subplots. This is a deliberate choice so that stylesheets can be used to get consistent plot sizes for publications etc. The size can be tweaked at a given command-line call with the --height and --width options. If producing many subplots, I would recommend to set a large --height.

How can I let sumo automatically set --xmax and --ymax to generate a plot containing all value ranges of variables?

I don't understand this question. By default Sumo chooses a reasonable --xmax and --ymax for the given data. In optical absorption plots we are usually more interested in the scale up to 1e5 that gives a realistic sense of the transition from "transparent" to "opaque" materials, so this is the default; for the dielectric function plots the data range is shown.
The range can be tweaked manually with --ymax, which allows multiple arguments to be passed and "auto" can be used to keep automatic scaling on some of the plots.
There is not currently a way to scale absorption plots to automatically follow the full data range. I suppose one could look for it in the .dat file and replot, using this for --ymax?

I then tried the following command:
(datasci) werner@X10DAi:~/Public/hpc/vasp/learning-by-doing/optical-absorption-spectra/sumo$ sumo-optplot absorption loss eps_real eps_imag n_real n_imag -f ./vasprun.xml --height 10 --xmax 20

And obtained the following:

Now, I wonder how to adjust the scale of the x-axis?

Right. I think this may be a restriction in argparse, which is the (standard) library we use to handle command-line arguments. I guess you need to use the first method, then. I don't think this is a Sumo-specific issue? If there is somewhere we documented such a command, of course it should be corrected.
It looks like --xmax is working correctly to me, you set it to 20 and the gap from 16 to the end of the line is about half the distance from 0 to 8.

It looks like --xmax is working correctly to me, you set it to 20 and the gap from 16 to the end of the line is about half the distance from 0 to 8.

This is not my focus. I mean, how do I set a smaller scale, such as drawing a scale mark on the x-axis every 4 units.

I don't think it is possible to change the "major" ticker which places the numbers from the command line, but we can enable some extra marks from the "minor" ticker.
In the base stylesheet "xtick.minor.size" is set to zero. We can override that by creating an extra stylesheet. e.g. create a file "moreticks.mplstyle" and with the line
xtick.minor.size : 2

then run sumo-optplot --style moreticks.mplstyle and this style is added to the default to give something like

However, I still don't understand how this option interacts with --xmax as in the following example:
$ cat moreticks.mplstyle
xtick.minor.size : 10
$ sumo-optplot --style moreticks.mplstyle --xmax 10

The result is as follows:

--xmax determines the x range shown in the plot.
Here the ticks look strange because you have set xtick.minor.size to be larger than xtick.major.size.
I don't know how matplotlib decides how many minor ticks to place or where to place the numbers. This is quite complicated and not determined by the Sumo code directly.

I think it is this: https://github.com/matplotlib/matplotlib/blob/v3.7.2/lib/matplotlib/ticker.py#L2883-L2900
So: it prefers to use values that are multiples of 1, 2, 2.5, 5 or 10, up to a maximum of 9 ticks on the axis, or a smaller number obtained by this function https://github.com/matplotlib/matplotlib/blob/d5210e4a87665581205f5147703dbd229b44cf66/lib/matplotlib/axis.py#L2474

Below are some examples which using the above mentioned feature:
### exampl 1
import matplotlib.pyplot as plt
import matplotlib.ticker as ticker

# Create a simple plot
fig, ax = plt.subplots()
ax.plot([1, 2, 3, 4], [10, 20, 15, 25])

# Use AutoLocator to dynamically determine tick positions
ax.xaxis.set_major_locator(ticker.AutoLocator())

plt.show()

### exampl 2
import matplotlib.pyplot as plt
import matplotlib.ticker as ticker

# Create a simple plot
fig, ax = plt.subplots()
ax.plot([1, 2, 3, 4], [10, 20, 15, 25])

# Customize AutoLocator with a maximum of 6 ticks and specific steps
custom_locator = ticker.AutoLocator()
custom_locator.nbins = 6
custom_locator.steps = [1, 2, 3, 4]

ax.xaxis.set_major_locator(custom_locator)

plt.show()

### exampl 3
import matplotlib.pyplot as plt

# Create a simple plot
fig, ax = plt.subplots()
ax.plot([1, 2, 3, 4], [10, 20, 15, 25])

# Adjust tick sizes
plt.rcParams['xtick.minor.size'] = 2
plt.rcParams['xtick.major.size'] = 4

plt.show()

But I tried in ipython as follows and still failed to display the fig directly:
In [8]: %matplotlib inline
   ...:
   ...: import matplotlib.pyplot as plt
   ...: import matplotlib.ticker as ticker
   ...:
   ...: # Create a simple plot
   ...: fig, ax = plt.subplots()
   ...: ax.plot([1, 2, 3, 4], [10, 20, 15, 25])
   ...:
   ...: # Use AutoLocator to dynamically determine tick positions
   ...: ax.xaxis.set_major_locator(ticker.AutoLocator())
   ...:
   ...: plt.show()
Shell is already running a gui event loop for tk. Call with no arguments to disable the current loop.
<Figure size 640x480 with 1 Axes>


How to load the documents in Android using Flutter packages

I’m developing the Flutter application to load the documents from other sources and cloud.
I have used “flutter_webview_plugin” for that and it’s working on iOS to view all the documents. But android is not supporting for view the documents using webview.
Is flutter has any package for load the documents such as .doc, .pdf, .ppt, .xls in the Android.
Please advise your thoughts. Thanks in advance.

Flutter has no native support for these formats.
You can make native functionality available by building a plugin https://flutter.io/docs/development/packages-and-plugins/developing-packages#developing-plugin-packages
Please consider asking support questions in one of the other channels listed at http://flutter.io/support .


Make exec binary for M1 mac available for download

Why
fix: https://github.com/meilisearch/MeiliSearch/issues/1661
Now, Do not supported getting exec file for m1 mac on usingdownload-latest.sh.
What
Download x86 binary when run download-latest.sh on m1 mac, because it can execute binary targeting x86.
Proof
I verified like this.
I got executable binary on M1 mac 💡
:) % arch
arm64

:) % ./download-latest.sh
Downloading MeiliSearch binary v0.21.1 for macos, architecture amd64...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   631  100   631    0     0   2035      0 --:--:-- --:--:-- --:--:--  2035
100 43.5M  100 43.5M    0     0  7826k      0  0:00:05  0:00:05 --:--:-- 9123k
MeiliSearch binary successfully downloaded as 'meilisearch' file.

Run it:
    $ ./meilisearch
Usage:
    $ ./meilisearch --help

:) % file ./meilisearch
./meilisearch: Mach-O 64-bit executable x86_64

:) % ./meilisearch --help # this is execuable
meilisearch-http 0.21.1
...
...

This looks good to me

Hello @k-nasa, thanks for your PR, I look this as soon as possible :)

Tested it on my M1 and it works.
@curquiza I think we can merge 😄

I fixed it 🙏

Hello @k-nasa I tried this version on my M1 mac and this is what I got 🥺

Oops...  I overlooked to lack arm binary on macos.
How about solving it with the following steps?

Download x86 binary for macos aarch64 (this pr) It should be better than the current undownloadable situation.
Release macos aarch64 binary
Update the script and download aarch64

ref: https://github.com/actions/virtual-environments/issues/2187

Release macos aarch64 binary

If i try to do this with actions, you may need to devise.

I think we can't build macOS Aarch64 binary with github action, so it would probably be better to stay with option 1:

Download the macos x86 binary for macos aarch64

🆗  If so, I think it is made of this PR.
I checked locally and found that x86 binary could be executed.

Yes now it work like a charm!

Do you know if this PR would work on a raspberry pi for example? (A linux armv8)

@irevoire what's the status of this pr?

I think we can merge, the day someone will try to use this script with a raspberry-pi, if it doesn't works he'll submit a new issue :grimacing:

Thanks for review ❤


Update sync-issue-labels.yaml

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Destructive PR. Rejected.


Enable mergify's merge queue

Description
Based on #1578, and enables the merge queue with batch_size: 3.
This should speed up merging PRs when multiple PRs are ready.
For instance, when there are 3 PRs in the queue, we'll only need to wait for ~30mins (e2e checks) instead of 1h30mins
See details in the config.
One important detail though with this:

With speculative checks, pull requests are tested against the base branch within another temporary pull request. This requires the branch protection settings Require branches to be up to date before merging to be disabled.
See https://docs.mergify.com/actions/queue/#speculative-checks

I assume this applies to batch_size too given how it works. I haven't yet made this config change on the repo.
I'll observe this to confirm it's needed.
In that case I'll probably make it a requirement to merge PRs using the automerge tag to prevent manual merges which could fail once in the main branch.
Tested

Waiting for checks to pass and seeing it works when multiple PRs are ready.

How others should test
N/A
Related issues

Discussed on Slack

Backwards compatibility
Yes

Hey @MuckT since "How others should test has n/a" hence we are skipping this PR
Cc: @jeanregisser


refactor: Reorganize code into asm, decode, and riscv modules

Successfully run code locally, RISCV-ONLINE launches as expected.

Nice!


base_product in csp_config

With #85 an entry named base_product was added to the csp_config structure. This information is obtained from the application about which the adapter is reporting. But the csp_config structure is used by the adapter to communicate to the application. As such we are round-tripping the information about the name/code of the base product. This appears superfluous.

This is to provide all data from adapter. Thus preventing the application from having to modify the dicitonary.

This is also integrated to be optional.


Legal additions

Minimal change to clarify

Closing as this was not based on the main branch, I will create a new PR based on main.


Issue in creating video from multiple frames

Hi Team ,
Please find attached code and video where we are creating the video from multiple frames.
So we are using your code to create video from multiple frames. So you can see in video that we are getting 52 frames and we would need 60 frames to make the complete video. It happens most of times but not always. So I am sharing the sample as well. Please suggest what I am doing wrong. I am creating video from front camera not back camera.
Video Link :- https://tinyurl.com/y5z7352t
Code Link :- https://tinyurl.com/yxmo9d5s
Please let me know if you need any reference.

@testingflexsin,
First of all, we can't run your code because it is missing an essential file - AppDelegate.swift. Because of this we can't investigate what is happening and suggest/apply possible fixes. If possible provide the missing file and afterward we will again look into the issue.

@testingflexsin Hello.
I looked at your video and I couldn't get much in the way of explanation.
As I saw in the video, you seem to be getting some errors with your images. "Couldn't load image...." etc. Maybe you should check out those first? There are at least 6 images that seem to be unable to load?
Also, you're saying you need 60 frames, that the issue happens only sometimes but you're not explaining the issue or the result fully. What is wrong with the video when the issue occurs? Are there missing images? If so, I still suggest you check why you can't load all of them and if the images you're getting the error for are the same ones missing from the finished video.
If not, provide further detailed explanation about the issue, when it occurs and what the finished video's lacking when compared to the one generated when the issue didn't occur.

@tgeorgieva
Please check this video link :-  https://tinyurl.com/y5ytp5w4.
You can see in this video that we are not getting full frames during generating a video. It happens sometimes not every times. Please help me out from this issue.
Thanks.

@testingflexsin As I wrote in my last comment, I can't help you without a properly detailed issue.
You had images that couldn't load in the code sample/video you send. Are those solved?
What does "sometimes" mean? Under what conditions does the generation fail? Because if the video is "sometimes" rendered correctly, chances are it's not my library that's the problem. Maybe your input or the workflow you're using to create the video is changing?


Touch input to 3D model view causes page scrolling

Describe the bug
On mobile (and possibly other touch input devices), dragging the 3D model around also causes the page to scroll.
To Reproduce
Steps to reproduce the behavior:

Go to https://try.manyfold.app/libraries/1/models/3
Drag up on the armadillo
See the model rotate and the page scroll down

Expected behavior
Only the 3D model should move when touch input starts on the 3D model view and only the page should move when touch input starts outside the 3D model view.
Smartphone

Device: Fairphone 5
OS: Android
Browser: Firefox
Version: 127.0.2

Thanks - I think I've missed a preventDefault somewhere in all the input redirection shenanigans that happen with the background worker.

Actually I wonder if this is because there are both https://developer.mozilla.org/en-US/docs/Web/API/Pointer_events and https://developer.mozilla.org/en-US/docs/Web/API/Touch_events. I'm definitely handling pointer events and taking over the input, which I thought would do touch as well, but perhaps the specific touch events need to be silenced too while capture is happening.

This might actually be as simple as setting touch-action: none on the canvas: https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action

Wow, that actually worked!


feat: use primaryKey to avoid user change module part

DO NOT merge this pull request currently, we need more discussion


Bursty behavior

I'm running into an issue when using mpsc where all slots in the ring buffer need to be filled before recv_ref() receives a "thing". For example if I create a thingbuf with mpsc::channel::<Vec<u8>>(10), I need to send_ref() 10 times before recv_ref() ever receives anything. And when it does it receives all 10 right after each other. Then it needs to wait for another 10 send_ref() calls to receive another 10.
Is this normal behavior?

Hmm, that doesn't sound right. What version are you using?

thingbuf = "0.1.4"
I didn't think so. I must be doing something wrong. I'll look into it some more and come back if I'm still stuck.

I tried to replicate my issue in a minimal repo but couldn't so I started disabling pieces of my program.
Oddly I've discovered when switching
let udp_socket = Socket::new(socket2::Domain::IPV4, Type::DGRAM, Some(Protocol::UDP)).unwrap();
udp_socket.set_reuse_port(true).unwrap();
udp_socket.set_recv_buffer_size(MAX_MTU * 100).unwrap();
udp_socket
        .bind(&socket2::SockAddr::from(socket_addr))
        .unwrap();
let udp_socket = UdpSocket::from_std(udp_socket.into()).unwrap();

to
let udp_socket = UdpSocket::bind(socket_addr).await.unwrap();

the issue goes away.
My guess is when using socket2's implementation it doesn't clear the read interest flag in tokio. Maybe?? :/ But then again that shouldn't prevent thingbuf from sending the message. I have no idea.

Okay, that was definitely the issue. I don't understand how but it was. I've replaced the socket2 code with the following and everything is working as expected now.
let res = unsafe { libc::setsockopt(udp_socket.as_raw_fd(), libc::SOL_SOCKET, libc::SO_RCVBUF, &(MAX_MTU * 100) as *const _ as *const libc::c_void, std::mem::size_of::<u32>() as u32) };

Thank you!

Huh, interesting! Glad you've figured it out!


Pass pre-created object to transliterator_transliterate.

Creating the Transliterator object once prevents the transliterator_transliterate function from creating it on every call.
According to the documentation, passing a string to transliterator_transliterate causes that function to create a Transliterator object. This become a bottleneck when needing to create many slugs.

The only CI failures are one failures that were occurring prior to this pull request. I'm not familiar enough with Japanese to troubleshoot.

Issue #3 states the Japanese tests are incorrect.


fixed #2, KthSelector does not consider natural order of doubles

+1 to merge this from me.  Good catch.  The one change I would suggest is to replace the boilerplate ASF license header win the new test file with the  "Hipparchus" version.  You can see an example of that in for example VariationalEquationTest.java in hipparchus-ode src/test.


Html tags are showing.

Duplicates

[X] I have searched the existing issues

Latest version

[ ] I have tested the latest version

Current behavior 😯
Click on the notification icon and a popup will open. The  tags are showing in the popup. Not parsed.
Expected behavior 🤔
Html tags should be properly parsed.
Steps to reproduce 🕹
Steps:

Click on Notification icon.
Check the content inside the popup.
Html tags are showing in there.

Context 🔦
I just saw it. The html should be properly parsed.

  Output from `npx @mui/envinfo` goes here.

If you are referring to the docs, I can't see any tag:

Could you maybe share screenshot of it?

Ah, it's on the v4 docs. We are not actively working on it at this moment, so I don't think this would be our biggest priority at the moment. Thanks for reporting it btw :)


NCTL: upload chainspecs from releases

Changes:

uploads chainspecs when merging to release branches or tagging
add missing chainspecs

bors r+


Cannot create the raft environment on MacOS from raft-env.yaml

The error is:
`
(base) MacBook-Air-2:xxx$ conda env create -f raft-env.yaml
Collecting package metadata (repodata.json): done
Solving environment: failed
ResolvePackageNotFound:

m2w64-headers-git==<IP_ADDRESS>36.c0ad18a=2
m2w64-pkg-config==0.29.1=2
setuptools==68.0.0=py39haa95532_0
m2w64-gcc-libgfortran==5.3.0=6
ca-certificates==2023.05.30=haa95532_0
mkl==2023.1.0=h8bd8f75_46356
intel-openmp==2023.1.0=h59b6b97_46319
m2w64-libiconv==1.14=6
msys2-conda-epoch==20160418=1
m2w64-bzip2==1.0.6=6
pyhams==1.2.1=py39hab42cac_0
m2w64-gcc==5.3.0=6
m2w64-tools-git==<IP_ADDRESS>92.90b8472=2
m2w64-libwinpthread-git==<IP_ADDRESS>34.697f757=2
libflang==5.0.0=h6538335_20180525
libblas==3.9.0=1_h8933c1f_netlib
openmp==5.0.0=vc14_1
m2w64-libmangle-git==<IP_ADDRESS>09.2e5a9a2=2
sqlite==3.41.2=h2bbff1b_0
openssl==3.0.10=h2bbff1b_0
m2w64-gcc-ada==5.3.0=6
vc==14.2=h21ff451_1
vs2015_runtime==14.27.29016=h5e58377_2
m2w64-mpfr==3.1.4=4
m2w64-binutils==2.25.1=5
numpy==1.25.0=py39h055cbcc_0
m2w64-gcc-libs==5.3.0=7
mkl_random==1.2.2=py39hf11a4ad_1
m2w64-mpc==1.0.3=3
libopenblas==0.3.21=pthreads_h02691f0_2
openblas==0.3.21=pthreads_ha35c500_2
mkl-service==2.4.0=py39h2bbff1b_1
wheel==0.38.4=py39haa95532_0
m2w64-gcc-libs-core==5.3.0=7
m2w64-gcc-objc==5.3.0=6
tbb==2021.8.0=h59b6b97_0
pip==23.2.1=py39haa95532_0
m2w64-zlib==1.2.8=10
m2w64-windows-default-manifest==6.4=3
m2w64-toolchain==5.3.0=7
m2w64-winpthreads-git==<IP_ADDRESS>34.697f757=2
numpy-base==1.25.0=py39h65a83cf_0
libpython==2.1=py39haa95532_0
m2w64-isl==0.16.1=2
m2w64-crt-git==<IP_ADDRESS>36.2595836=2
m2w64-gmp==6.1.0=2
m2w64-gcc-fortran==5.3.0=6
python==3.9.17=h1aa4202_0
m2w64-make==4.1.2351.a80a8b8=2
liblapack==3.9.0=5_hd5c7e75_netlib
mkl_fft==1.3.6=py39hf11a4ad_1
`
Is this because the raft-env.yaml file only works for the linux system?

Thanks,
Ying

The environment variable yaml-file and install instructions were mistakenly Windows-only.  Please try these install instructions instead:
https://github.com/WISDEM/RAFT/blob/install_readme/README.md

The environment variable yaml-file and install instructions were mistakenly Windows-only. Please try these install instructions instead: https://github.com/WISDEM/RAFT/blob/install_readme/README.md
Thanks for your reply! I have installed WEIS on my pc, and it includes RAFT. Is there any way to run the standalone mode of RAFT within WEIS, like create an RAFT environment and run the RAFT folder in WEIS. Or I have to download the whole RAFT files separately and then run the RAFT? Thanks!

If you have WEIS installed, then you have RAFT installed.  You do not need to install it twice.  There may still be a benefit to having a local git clone so that you can see the source code and understand any error messages (but the installed RAFT would be from some other directory).

Hi Garrett,
I installed a local RAFT according to the instructions, but met some problems when running the examples.
In the RAFT/examples folder, I run the VolturnUS-S case but receive the following error:

(raft-env) MacBook-Air-2:examples wuying$ python example_from_yaml.py
Traceback (most recent call last):
File "/Users/wuying/RAFT/examples/example_from_yaml.py", line 6, in
import raft

ModuleNotFoundError: No module named 'raft'
Can you help to solve this problem?
Thanks,
Ying
发件人: Garrett Barter @.>
答复: WISDEM/RAFT @.>
日期: 2024年4月1日 星期一 上午10:13
收件人: WISDEM/RAFT @.>
抄送: Ying Wu @.>, Author @.***>
主题: Re: [WISDEM/RAFT] Cannot create the raft environment on MacOS from raft-env.yaml (Issue #46)
If you have WEIS installed, then you have RAFT installed. You do not need to install it twice. There may still be a benefit to having a local git clone so that you can see the source code and understand any error messages (but the installed RAFT would be from some other directory).
—
Reply to this email directly, view it on GitHubhttps://github.com/WISDEM/RAFT/issues/46#issuecomment-2029038991, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANZSBNPWW5A7RWLZB2MPQ7TY3C7FBAVCNFSM6AAAAABFILCIDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGAZTQOJZGE.
You are receiving this because you authored the thread.Message ID: @.***>

If you received the error no module named, 'raft', then the install was not successful.  You might have to post the log or screenshot of your terminal with the installation commands you used.

Hi Garrett,
I run the example case IEA-15-240-RWT-UMaineSemi by RAFT, and I have a question. I notice that the ‘platform’in yaml file include qtfPath  :  'IEA-15-240-RWT-UMaineSemi.12d'.

     Why we need this file to run RAFT?

     How to generate this file?

     What’s the information in the file refers to?

Thanks,
Ying
发件人: Garrett Barter @.>
答复: WISDEM/RAFT @.>
日期: 2024年4月4日 星期四 上午11:26
收件人: WISDEM/RAFT @.>
抄送: Ying Wu @.>, Author @.***>
主题: Re: [WISDEM/RAFT] Cannot create the raft environment on MacOS from raft-env.yaml (Issue #46)
If you received the error no module named, 'raft', then the install was not successful. You might have to post the log or screenshot of your terminal with the installation commands you used.
—
Reply to this email directly, view it on GitHubhttps://github.com/WISDEM/RAFT/issues/46#issuecomment-2036104725, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANZSBNPPSONVOIVKXIBCWETY3TB7JAVCNFSM6AAAAABFILCIDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZWGEYDINZSGU.
You are receiving this because you authored the thread.Message ID: @.***>

@mattEhall - I'll hand this off to you

Thanks Garrett.
Hi Ying,
That line relates to a second-order wave excitation difference-frequency QTF file. It's an option with some capabilities under development and was included there accidentally. You should be able to just remove that line from the input file. If there is still a problem, there may also be a qtf or hydro mod input line that you could also remove to use the default options. Let me know if there's still an issue and I can look in detail.
Matt

Hi Matt,
Thanks for your detailed reply. I remove that line and it works using the default options.
I also have another two general questions about RAFT.

How to implement the frequency-domain simulation of wind turbine in RAFT? Can RAFT generate some physical quantities of wind turbine (e.g. stress of key components) for fatigue analysis?

As far as I know, the commercial software Sesam – HydroD by DNV is also a frequency-domain tool for floating structure. So what’s the difference between RAFT and HydroD?

Thanks,
Ying
发件人: Matt Hall @.>
答复: WISDEM/RAFT @.>
日期: 2024年4月12日 星期五 下午10:07
收件人: WISDEM/RAFT @.>
抄送: Ying Wu @.>, Author @.***>
主题: Re: [WISDEM/RAFT] Cannot create the raft environment on MacOS from raft-env.yaml (Issue #46)
Thanks Garrett.
Hi Ying,
That line relates to a second-order wave excitation difference-frequency QTF file. It's an option with some capabilities under development and was included there accidentally. You should be able to just remove that line from the input file. If there is still a problem, there may also be a qtf or hydro mod input line that you could also remove to use the default options. Let me know if there's still an issue and I can look in detail.
Matt
—
Reply to this email directly, view it on GitHubhttps://github.com/WISDEM/RAFT/issues/46#issuecomment-2051831670, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANZSBNIAY6PWWPBXIHFRKTTY47TATAVCNFSM6AAAAABFILCIDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJRHAZTCNRXGA.
You are receiving this because you authored the thread.Message ID: @.***>


Finalise developer guide

Added effort appendix

Pull Request Test Coverage Report for Build 699

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 79.46%

Totals

Change from base Build 695:
0.0%

Covered Lines:
1973

Relevant Lines:
2483

💛  - Coveralls


Feature request: Native support for column spaning

I have accomplished almost everything with lot of try-out and battle-testing what this awesome library can do.
Now I have one point which could be interesting.
If you use the pivot or sub items feature you have the parent row and it's child rows. I recognised that most time I want to span some columns (not all just some) to make some better summaries about the particular sub rows.
I tried out some ways but it results in chunky clunky hacks which is not really neat without text ellipse etc.
Native column spanning could be a very nice feature for parent rows.
What you think, how difficult this is to implement?

This will likely not enter the core of React-Table any time soon. But it would help us further down that path if you could help us with a few things:

Post a screenshot/mockup of what you are wanting
Implement spanning using Component Overrides. You can override the core functionality of any component very easily in React Table.  You may be able to do this on your own, and if it is simple enough to achieve, we may consider adding it to the core it's it works well and becomes a large use case for more people.

Going to close this issue for now, but I will remain active on it for questions on implementation and for tracking progress of this feature request :)


Read everytime on render() from localStorage? Seriously? How to something like Redux Store with Apollo?

I see in https://github.com/howtographql/react-apollo/blob/master/src/components/Header.js you use:
const userId = localStorage.getItem(GC_USER_ID)
which seems to me a bit ugly: everytime Header render() is called you read from localStorage?
With react-redux I used to go with something like this:
render() {
  const { authentication } = this.props;
  ...
}

const mapStateToProps = state => ({
  authentication: state.authentication
});

export default connect(mapStateToProps, { logoutAction })(Navbar);

And also if I read from localStorage on every render() and let's say I wanna store in localStorage all my user's data (eg. {username: "john", age: "15"}) when I pass this const to one of my children components everytime it re-render because the JSON.parse make it a new object! Everytime!
How to have something like a Redux Store with Apollo?

Question on StackOverflow: https://stackoverflow.com/questions/47631443/accessing-apollo-store-like-i-used-to-go-with-redux-store

Hey @johnunclesam, I agree that this definitely is not an elegant solution! However, since this tutorial is really focussed on GraphQL and using it from React & Apollo, we still chose to go with it to not add too much complexity for the other "layers" of the tutorial.
Out of curiosity, do you have a better solution in mind? I'd be more than happy to merge a PR if you have a good idea of how this could be improved without creating too much distraction from the actual purpose of the tutorial 🙂


can't require 'version'

/home/travis/.rvm/gems/ruby-2.0.0-p353/gems/activesupport-4.0.4/lib/active_support/dependencies.rb:229:in require': cannot load such file -- equivalent-xml/version (LoadError) 	from /home/travis/.rvm/gems/ruby-2.0.0-p353/gems/activesupport-4.0.4/lib/active_support/dependencies.rb:229:in block in require'
from /home/travis/.rvm/gems/ruby-2.0.0-p353/gems/activesupport-4.0.4/lib/active_support/dependencies.rb:214:in load_dependency' 	from /home/travis/.rvm/gems/ruby-2.0.0-p353/gems/activesupport-4.0.4/lib/active_support/dependencies.rb:229:in require'
from /home/travis/.rvm/gems/ruby-2.0.0-p353/gems/equivalent-xml-0.4.1/lib/equivalent-xml.rb:1:in `<top (required)>'

Haven't seen this in a while. Closing this issue to make sure that it comes back. 😄


broken codeblocks with jekyll

Hello,
Seems like pygments breaks their own codeblocks in jekyll.
Here is an example:
This is a simple yara file with highlighting as text.
{% highlight text  %}
rule dubrute : bruteforcer
{
    meta:
        author = "Christian Rebischke (@sh1bumi)"
        date = "2015-09-05"
        description = "Rules for DuBrute Bruteforcer"
        in_the_wild = true
        family = "Hackingtool/Bruteforcer"

    strings:
        $a = "WBrute"
        $b = "error.txt"
        $c = "good.txt"
        $d = "source.txt"
        $e = "bad.txt"
        $f = "Generator IP@Login;Password"

    condition:
        //check for MZ Signature at offset 0
        uint16(0) == 0x5A4D

        and

        //check for dubrute specific strings
        $a and $b and $c and $d and $e and $f
}
{% endhighlight %}

this compiles with jekyll to:

Unfortunately, Jekyll dropped pygments.rb support: https://github.com/jekyll/jekyll/issues/6823

Unfortunately, Jekyll dropped pygments.rb support: https://github.com/jekyll/jekyll/issues/6823


maybe don't need to try to install bzip2 - centos7

https://travis-ci.org/bucharest-gold/origin-s2i-nodejs#L423
Package bzip2-1.0.6-13.el7.x86_64 already installed and latest version

https://github.com/bucharest-gold/origin-s2i-nodejs/commit/d70b8ebe79a61d98ca643d30247945f12a2dbe55


Try this

I'm not sure how to tell if this has worked, but I think it should...

Hmm, it looks like the CI jobs actually run on this PR too, so let's see if they actually run and pass...

Okay, it went green, so I think it's okay.


Add a RichTextBlockFactory

Add a RichTextBlockFactory, with tests.
closes #13

Any update for this?

Hi @mvantellingen
Can we have any updates on this PR? Is something that you are thinking to merge at one point?

Closing in favour of #71


not fire ClickedCommand or TouchedUpCommand

Not fire command ni TouchedUp  ni clicked
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
xaml:
<flex:FlexButton Text="ENTRAR"
Grid.Row="4"
Grid.Column="1"
Padding="16"
FontSize="12"
IsEnabled="true"
IsToggled="true"
ToggleMode="false"
ClickedCommand="{Binding EnterCommand}"
TouchedUpCommand="{Binding EnterCommand}"  />
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Please complete the following information:

Which version of the FlexButton do you use? 0.11.0
Which version of Xamarin.Forms do you use? 4.1
Which OS are you talking about? 12

I can't reproduce your issue. Copied your code to a test project and everything works as expected. Please note, that using ClickedCommand AND TouchedUpCommand will fire the Comamnd twice, as both events fill be fired on a click.
Also, there is no point in setting ToggleMode to false and IsToggled to true.

Sorry, my job has not left me, prepare a test project ..
I annex it now.
lolo.zip


Added swedish translation

Did it for Hacktoberfest closed #29

Paste a zen address here, you'll have 2 zen soon!


Checkout service can't access email service

Observation
The following error occurs:
failed to send order confirmation to<EMAIL_ADDRESS>failed POST to email service: Post "my-otel-demo-email-service:8080/send_order_confirmation": unsupported protocol scheme "my-otel-demo-email-service"

Explanation
The checkout service uses the following env var EMAIL_SERVICE_ADDR: release-name-email-service:8080.
The env var is used in the code as follows:
resp, err := otelhttp.Post(ctx, cs.emailSvcAddr+"/send_order_confirmation", "application/json", bytes.NewBuffer(emailServicePayload))

The error occurs because the http:// protocol prefix is missing. However, the SERVICE_ADDR emails are automatically generated out of the service dependencies via the following snippet:
# {{ $.depends }}
# {{ .name }}
{{- if hasKey $.depends .name }}
{{- range $depend := get $.depends .name }}
- name: {{ printf "%s_ADDR" $depend | snakecase | upper }}
  value: {{ printf "%s-%s:%0.f" $prefix ($depend | kebabcase) (get $.serviceMapping $depend )}}
{{- end }}
{{- end }}

It is therefore not straight forward how to change this in an elegant way. The setup feels a little over generified.

@2start Do you know if the email service's code is breaking a standard that the other services follow by not adding the http prefix? Or is this the only situation where this applies?

@TylerHelmuth It took a superficial look earlier. Unlike the other services the email-service is no grpc service. It's a ruby service. I.e. it uses a http library, which requires us to specify http:// or https://. I think there are two possible solutions.
Just touch our repo:

Specify the protocol in the address similar to opentelemetry-demo .env.

The second solution would be to change the following things in the open-telemetry-demo:

Create new env variable for the protocol i.e. EMAIL_SERVICE_ENABLE_HTTPS (default: false)
Change go code to consider the new variable.
Change address in .env file to remove http:// prefix.

Tbh. it would also improve the original setup.
However, the problem at our side occurs because we bind our generated dependency addresses directly to the go code in the demo itself. We would need an optional layer inbetween to decouple this. Like a "getter" function.
I propose to write a quick n dirty fix by checking if the address belongs to the email-service. If so I can prefix the addr with http://. If there will be multiple outliers, we can still fix this in a more sophisticated manner.

I propose to write a quick n dirty fix by checking if the address belongs to the email-service.

yes we can do this for now to get the chart working for the 1.0 release of the demo.  Do you plan to work on that?

sure I can write the fix today


Add NATS DSN

Change Summary

Added NATS DSN validation.

Checklist

[x] The pull request title is a good summary of the changes - it will be used in the changelog
[ ] Unit tests for the changes exist
[ ] Tests pass on CI
[ ] Documentation reflects the changes where applicable
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Yes, it's still in progress.

Looks like this was ready but got lost in a sea of notifications and forgotten. @dsodx can I suggest resolving the merge conflicts?

Thank you :smiley: .


Add documentation for workerMachineGroups in Nutanix failure domains

Issue #, if available:
N/A
Description of changes:
Add documentation for workerMachineGroups in Nutanix failure domains
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/cherry-pick release-0.21


Add link to pre-print version of the paper

Closed in latest commit https://github.com/ABohynDOE/enumeration_fatld/commit/2b5a783fa55dc1a1eaa62c5baf784bfbce60b5d3


Update SLO Manifest Structure & init command to work with new Entity Server

The purpose of this issue to begin the process of integrating the CLI with the new entity server. To that end, we need to do the following.

Create new manifest.yaml structure for defining Objective entities, For eg.

metadata:
    labels:
        name: 90% 0f 99th percentile latency served in 250ms
        service: naruto
    relatedto:
    - repo: sasuke

indicator_selector:
  category: latency
  percentile: "99"
  latency: 250ms
  gcp_project_id: abc123
  resource_type: loadbalancer
  resource_name: my-load-balancer
  loadbalancer_path: /index.html
objective_percent: 90
wiindow: 2h

---

metadata:
    labels:
        name: 95% 0f 99th percentile latency served in 250ms
        service: sasuke
    relatedto:
    - service: naruto

indicator_selector:
  category: latency
  percentile: "99"
  latency: 250ms
  gcp_project_id: abc123
  resource_type: loadbalancer
  resource_name: my-load-balancer
  loadbalancer_path: /index.html
objective_percent: 95
window: 1h

Restructure slo init workflow to facilitate new manifest.

As these changes could potentially introduce breaking changes. We propose implementing these commands under a beta sub-command. For eg.
$ reliably beta slo init

Something to bear in mind when defining entities will be to stick to Kubernetes conventions by using camelcase and kind instead of type.

@xaah , I wonder if it's worth doing Kind/Type in the manifest since it's already resolved on the server based on the endpoint being called. That is, all the manifest stuff will be Objectives. Indicators and Objective Results are dynamic and won't be defined a file.

@daidokoro The manifest could store Entity Contexts right? If so, then we'd have at least two potential kinds. Seems to me the manifest could have kinds, apiVersion, etc... which would guide the endpoints that are ultimately requested.

@Xaah, fair point. You're right, the only thing really concerned with the manifest is the CLI. So the Kind/Type here, would help the CLI logic in communicating with the relavant APIs.

wip https://github.com/reliablyhq/cli/tree/slo-init-entities

@daidokoro @dmartin35
A basic example manifest I have that I think would cover the basic information needed for the CLI to generate SLIs is:
apiVersion: v1
kind: Objective
metadata:
  labels:
    name: api-availability
    service: example-api
spec:
  indicator_selector:
    provider: gcp
    category: availability
    gcp_project_id: abc123
    resource_id: myprojectid/google-cloud-load-balancers/myloadbalancer-name
  objective_percent: 99
  window: PT24H
---
apiVersion: v1
kind: Objective
metadata:
  labels:
    name: api-latency
    service: example-api
spec:
  indicator_selector:
    provider: gcp
    category: latency
    gcp_project_id: abc123
    resource_id: myprojectid/google-cloud-load-balancers/myloadbalancer-name
    threshold: 100ms
  objective_percent: 99
  window: PT24H

Time window format is being discussed in another issue, I'm just using the one we had for previous manifest there.

Here is the format that I've been able to produce, with the alpha slo init command
kind: Objective
apiVersion: v1
metadata:
  name: 99% of requests successful over last 1 hour
  labels:
    name: 99% of requests successful over last 1 hour
spec:
  indicatorSelector:
    category: availability
    id: arn:aws:apigateway:eu-west-3:912823331559:/apis/3ix4qm7v4d
    provider: aws
  objectivePercent: 99
  window: 1h0m0s

window is using the format expected by the entity server

@dmartin35 I'm wondering if the name under metadata would be supported, or just labels (and name under labels).

yep, that something I noticed that was used by kubernetes, I think that's ignored by the entity server, even though we might want to add it

The closer we are to a Kubernetes format, the least surprises we can expect from users.
Please stick to any standards like that for sure!

I think this is relevant too https://github.com/reliablyhq/entity-server/issues/71

for this issue, see related PR with updated commands behavior https://github.com/reliablyhq/cli/pull/342


Handles nested fields in field options.

Oh sorry I missed this. Did you close this because I didn't reply? If so I'm sorry :)


can you provide some basic example like download, play/pause, share etc. ??

You can  look at the available implementations:
https://github.com/renaudcerrato/ToggleDrawable/blob/master/library/src/main/java/com/mypopsy/drawable/SearchArrowDrawable.java
https://github.com/renaudcerrato/ToggleDrawable/blob/master/library/src/main/java/com/mypopsy/drawable/SearchCrossDrawable.java
https://github.com/renaudcerrato/ToggleDrawable/blob/master/library/src/main/java/com/mypopsy/drawable/DrawerArrowDrawable.java

that is mention also in your document, i said for other general buttons
!

That's just an helper library, you can do it by yourself and send me a pull request?


flint: 2.8.5 -> 2.9.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/flint/versions.
meta.description for flint is: "Fast Library for Number Theory"
meta.homepage for flint is: "https://www.flintlib.org/"
meta.changelog for flint is: ""
Updates performed

Version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.9.0 with grep in /nix/store/dd99kravy7d3ff1r1mlxd3b95xzrqach-flint-2.9.0
found 2.9.0 in filename of file in /nix/store/dd99kravy7d3ff1r1mlxd3b95xzrqach-flint-2.9.0

Rebuild report (if merged into master) (click to expand)

53 total rebuild path(s)

28 package rebuild(s)

28 x86_64-linux rebuild(s)
25 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
arb
flint
polymake
pynac
python310Packages.qiskit
python310Packages.qiskit-aer
python310Packages.qiskit-finance
python310Packages.qiskit-ibmq-provider
python310Packages.qiskit-ignis
python310Packages.qiskit-machine-learning
python310Packages.qiskit-nature
python310Packages.qiskit-optimization
python310Packages.qiskit-terra
python310Packages.symengine
python39Packages.qiskit
python39Packages.qiskit-aer
python39Packages.qiskit-finance
python39Packages.qiskit-ibmq-provider
python39Packages.qiskit-ignis
python39Packages.qiskit-machine-learning
python39Packages.qiskit-nature
python39Packages.qiskit-optimization
python39Packages.qiskit-terra
python39Packages.symengine
sage
sageWithDoc
singular
symengine

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/dd99kravy7d3ff1r1mlxd3b95xzrqach-flint-2.9.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A flint https://github.com/r-ryantm/nixpkgs/archive/e5e8b08da699239423ccf39c2893e316f7bf5398.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/dd99kravy7d3ff1r1mlxd3b95xzrqach-flint-2.9.0
ls -la /nix/store/dd99kravy7d3ff1r1mlxd3b95xzrqach-flint-2.9.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review took longer than 45m and timed out

Maintainer pings
cc @timokau @omasanori @7c6f434c @collares for testing.

Result of nixpkgs-review pr 179053 run on x86_64-linux 1

28 packages built:

arb
flint
polymake
pynac
python310Packages.qiskit
python310Packages.qiskit-aer
python310Packages.qiskit-finance
python310Packages.qiskit-ibmq-provider
python310Packages.qiskit-ignis
python310Packages.qiskit-machine-learning
python310Packages.qiskit-nature
python310Packages.qiskit-optimization
python310Packages.qiskit-terra
python310Packages.symengine
python39Packages.qiskit
python39Packages.qiskit-aer
python39Packages.qiskit-finance
python39Packages.qiskit-ibmq-provider
python39Packages.qiskit-ignis
python39Packages.qiskit-machine-learning
python39Packages.qiskit-nature
python39Packages.qiskit-optimization
python39Packages.qiskit-terra
python39Packages.symengine
sage
sageWithDoc
singular
symengine


Tailwind nested css support?

I had postcss.config.js file which work for ng serve but not work with storybook.
module.exports = {
  plugins: {
    'postcss-import': {},
    '@tailwindcss/nesting': {},
    tailwindcss: {},
    autoprefixer: {},
  },
}

Look like the config was ignored by addon and giving an error
99% end closing watch compilationWARN Force closed preview build
/Users/user/projects/tessst/node_modules/@storybook/builder-webpack5/node_modules/webpack/lib/NormalModule.js:760
                                const error = new ModuleBuildError(err, {
                                              ^

ModuleBuildError: Module build failed (from ./node_modules/postcss-loader/dist/cjs.js):
SyntaxError

<css input> @apply is not supported within nested at-rules like @include. You can fix this by un-nesting @include.

Hey folks 👋
I'm going to close this issue for now due to inactivity. However, please comment if this is still a problem and I'll reopen it for investigation.


Add stack trace check to cookie protection

See: https://app.asana.com/0/0/1204257980027287/f
See also: https://github.com/duckduckgo/duckduckgo-privacy-extension/pull/1847

@shakyShane do you mind doing a first pass here as there's lots of C-S-S infra being changed then I can pass it back to @sammacbeth?

@jonathanKingston - I just left 2 notes about Windows support, if not relevant then feel free to ignore :)

Merging this for now, there might be some follow up for Windows (which is currently broken anyway so we're not too concerned here).


Different exception for when the password is incorrect

In the current code CASParseError("Incorrect PDF password!") is raised when the password is wrong.
https://github.com/codereverser/casparser/blob/e507c5305554df16fcc3d48c709cfd20fe463eb9/casparser/parsers/mupdf.py#L200
So you have to do ugly things like:
try:
    read_cas_pdf("pdf", "password")
except CASParseError as err:
    if err.args:
        if 'incorrect pdf password' in err.args[0].lower():
            raise InvalidPasswordError

    raise

One possible solution could be to create a separate Exception for wrong password inheriting from CASParseError. Or a code attribute could be set in the CASParseError class, whose value could be like incorrect_password(or something else depending on the context where it is raised) which you can check for when handling the exception.
If you don't have the bandwidth, I can make a PR for the same this weekend.

Oh! that makes sense.
I'll add a separate exception for invalid passwords and make a release by this weekend.


Making Redux optional by offering custom data-storage locations

In my point of view apollo client is getting data and putting it in a plain object. Currently this object is redux' store. But I don't see a reason why it can't be just a plain object.
I imagine:
new ApolloClient({ storageHandler: function(newData) {....... return EntireStorage} })

I understand that redux is chosen for its nice devtools but ultimately apollo-client can work without it which will make it more flexible.

So what about managing query state, mutations and results ? Have you read the code for the QueryManager? Why add more code to modify how those pieces of data work just to put your data in a diff object?

@antitoxic I was thinking we could just do #255, that would get us to 95% of the goal.
Rewriting the whole library to allow plugging in something instead of Redux is probably not going to happen, but I was thinking refactoring to allow someone to build that very easily is a good goal!

@stubailo agreed.
@abhiaiyer91 do you require all people that submit issues to have read the
code? Not very friendly, not friendly at all.
On Mon, 30 May 2016, 02:56 Sashko Stubailo<EMAIL_ADDRESS>wrote:

@antitoxic https://github.com/antitoxic I was thinking we could just do
#255 https://github.com/apollostack/apollo-client/issues/255, that
would get us to 95% of the goal.
Rewriting the whole library to allow plugging in something instead of
Redux is probably not going to happen, but I was thinking refactoring to
allow someone to build that very easily is a good goal!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apollostack/apollo-client/issues/256#issuecomment-222390255,
or mute the thread
https://github.com/notifications/unsubscribe/AAP9fFWL9R5-HxvChL_L86pkXOpmRCpVks5qGieYgaJpZM4IpYPE
.

Lol. @antitoxic I think you read my comment the wrong way. I was merely poking you for more reasoning. I don't know if what you are suggesting is right or wrong, only to explore if you have thought deeply about what you are proposing.

To be fair, QueryManager only plugs into redux in 2 ways: getState and dispatch. So if you can make a Redux shim on top of whatever data storage solution, then it should basically just work.

Lol. @antitoxic I think you read my comment the wrong way. I was merely poking you for more reasoning. I don't know if what you are suggesting is right or wrong, only to explore if you have thought deeply about what you are proposing.

Poking is much less preferred than asking "have you though about it in depth and in what scenario". Anyway:

So what about managing query state, mutations and results ?

What about them? Redux is just an immutable object exposing 2 API - dispatch and getstate.

Have you read the code for the QueryManager?

No.

Why add more code to modify how those pieces of data work just to put your data in a diff object?

Because redux is not the only thing existing for keeping state (mobx, SAM, etc..). I'm trying not to use redux and cut down on boilerplate in my apps. I need graphql and apollo seem like a good client (i'm evaluating this). However in order to hook Apollo store to my own logic of state-keeping I'm doing kind of hacky wiring - I'm launching a redux store, writing a reducer that listens for APOLLO_QUERY_RESULT and APOLLO_QUERY_STOP (undocumented stuff) and merging the data in my own state-keeping.
Which is making me wonder is it possible for me to keep only the actual data return from the graphql server in my state? Could I initialize Apollo client with the return of a query which looks like this:
{
  "query": "{ all: allFilms { totalCount } }",
  "data": {
    "all": {
      "totalCount": 6
    }
  }
}

instead initializing Apollo client with its store data object which is something like:
{
  "queries": {},
  "mutations": {},
  "data": {
    "ROOT_QUERY.allFilms": {
      "totalCount": 6
    },
    "ROOT_QUERY": {
      "allFilms": "ROOT_QUERY.allFilms"
    }
  }
}

So I'm opening #258

I was thinking we could just do #255, that would get us to 95% of the goal.

That's a good option.

You can go and just use graphql without apollo and do it like you want.
Or you can do an abstraction over the redux and making like you want ... I see no real issue there.
The project is still in it's infancy if you want i'm sure you can contribute the change you wanna see.

@aleksandrenko :) The issue has been closed. Mainly because @stubailo mentioned there is a limitation but it will be overcome when the normalization is extracted, which actually will solve a lot of other things and also, in the redux' issue about Relay there already community gathering to contribute to that.
"infancy" or "just make an abstraction" are not solutions. Any package could be abstracted out. I'm already doing abstractions with apollo client for other things (discussed in slack). I'm trying to keep them below the threshold which will cause me to switch to another package. If I have to continue abstracting or digging into TypeScript I will have no reason not to just butcher Relay and use it because its roadmap shows a lot of useful stuff coming. So I think submitting issues about apollo client and discussing problems is quite enough.


Docker pull error unknown

Steps taken/Steps to reproduce
Following https://pyrsia.io/docs/get_involved/local_dev_setup/
pyrsia node is running as cargo run  - only visible log events are Indentity events
modified /etc/docker/daemon.json as requested
docker pull ubuntu is not working with pyrsia node.
Nothing in pyrsia node log
This in docker daemon log:
zář 22 17:49:52 ivan-ThinkPad-T470 dockerd[29871]: time="2022-09-22T17:49:52.702471960+02:00" level=debug msg="Trying to pull ubuntu from http://localhost:7888/ v2"
zář 22 17:49:52 ivan-ThinkPad-T470 dockerd[29871]: time="2022-09-22T17:49:52.707597929+02:00" level=info msg="Attempting next endpoint for pull after error: unknown"

Expected Behavior
Docker should use pyrsia node
Experienced Instance of the bug
Rust version:  rustc 1.62.0 (a8314ef7d 2022-06-27)
OS version: Ubuntu 20.04
Pyrsia version:  from source, main branch, commit 86bc7f9c667fc16cd00eaced5449669ce74c673f
Docker version:  Server Version: 20.10.12

I followed this guide https://github.com/pyrsia/pyrsia/blob/main/docs/tutorials/build_from_source_docker.md and got bit more understanding.   Pyrsia is only serving images it contains.  Problem with Getting Started example was that ubuntu image was not built first, so it could not be found in Pyrsia.   Pyrsia is returning 404,  docker for some reason is showing "unknown" error.


In-memory engine: skiplist tombstone should be handled separetely in gc

What is changed and how it works?

Issue Number: Ref #16141

What's Changed:
skiplist tombstone should be handled separetely in gc

Related changes

[ ] PR to update pingcap/docs/pingcap/docs-cn:
[ ] Need to cherry-pick to the release branch

Check List
Tests

[x] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Release note

None

/merge


python38Packages.fountains: 1.1.1 -> 1.2.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python38Packages.fountains is: "Python library for generating and embedding data for unit testing"
meta.homepage for python38Packages.fountains is: "https://github.com/reity/fountains"
meta.changelog for python38Packages.fountains is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.2.0 with grep in /nix/store/s0wdni6pb3017jlqavv6ggz49cys6i8h-python3.8-fountains-1.2.0

found 1.2.0 in filename of file in /nix/store/s0wdni6pb3017jlqavv6ggz49cys6i8h-python3.8-fountains-1.2.0

Rebuild report (if merged into master) (click to expand)

14 total rebuild path(s)

7 package rebuild(s)

7 x86_64-linux rebuild(s)
7 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
docbookrx
python38Packages.fe25519
python38Packages.fountains
python38Packages.ge25519
python39Packages.fe25519
python39Packages.fountains
python39Packages.ge25519

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/s0wdni6pb3017jlqavv6ggz49cys6i8h-python3.8-fountains-1.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python38Packages.fountains https://github.com/r-ryantm/nixpkgs/archive/ab934520e97786e3abe373adec354214b965b470.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/s0wdni6pb3017jlqavv6ggz49cys6i8h-python3.8-fountains-1.2.0
ls -la /nix/store/s0wdni6pb3017jlqavv6ggz49cys6i8h-python3.8-fountains-1.2.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

4 packages failed to build:

python38Packages.fe25519
python38Packages.ge25519
python39Packages.fe25519
python39Packages.ge25519

2 packages built:

python38Packages.fountains
python39Packages.fountains

Maintainer pings
cc @fabaff for testing.

Updated to 1.2.0 in #152430


TRY_CAST('1 day' AS INTERVAL) should be interval '1' day

Reference: https://dune.com/queries/138785

This was fixed by #80


Copy MaxDecFrameBuffering when querying

Fixes #2140.
Signed-off-by: Yan Wang<EMAIL_ADDRESS>

Let’s make it this way:

Always ignore max_dec_frame_buffering  == 0. Treat zero values is default (like "undefined"). It's needed to avoid potential issues with streams which invalidly set max_dec_frame_buffering.
Accept the rest values during header parsing but check they’re compliant (not bigger than maxDPB calculated from profile/level, not less than max_num_ref_frames, etc). If not, ignore max_dec_frame_buffering from bitstream and calculate max_dec_frame_buffering from profile/level.

Sure. I will change it.

@wangyan-intel , can you please also check HEVC case?

@wangyan-intel , can you please also check HEVC case?

Sure.

Let’s make it this way:

Always ignore max_dec_frame_buffering  == 0. Treat zero values is default (like "undefined"). It's needed to avoid potential issues with streams which invalidly set max_dec_frame_buffering.
Accept the rest values during header parsing but check they’re compliant (not bigger than maxDPB calculated from profile/level, not less than max_num_ref_frames, etc). If not, ignore max_dec_frame_buffering from bitstream and calculate max_dec_frame_buffering from profile/level.

@dmitryermilov I debugged it and double checked it again. Your comments may have been implemented by the following:
https://github.com/Intel-Media-SDK/MediaSDK/blob/master/_studio/shared/umc/codec/h264_dec/src/umc_h264_task_supplier.cpp#L2460-L2471
So for h264 decoding, It may be enough after apply my current change?

@wangyan-intel , can you please also check HEVC case?

@dmitryermilov For HEVC, it is similar. We need add one copying.  The variable should be max_dec_pic_buffering.
SPS header decoding has covered it:
https://github.com/Intel-Media-SDK/MediaSDK/blob/master/_studio/shared/umc/codec/h265_dec/src/umc_h265_task_supplier.cpp#L1069-L1078
I will add another commit for HEVC into this PR.
Thanks.

Thanks!


Workaround build failure with winegcc/clang.

Fixes https://github.com/doitsujin/dxvk/issues/1182
I briefly tested this with one game (Grim Dawn) without issues. I also tested that --no-gnu-unique is still used with winegcc as built by gcc.

Does this actually produce working binaries or is it "just" to fix the build process?

Yes and no, as explained in the OP dxvk built by winegcc/clang does work with the game Grim Dawn, but winecfg itself still has problems so I could only test against wine built with gcc. The remaining issues should be handled in wine, but it will be more annoying to debug this if dxvk doesn't even build.


🚀 Feature Request: wrangler types should use union types for possible values

Describe the solution
wrangler.toml
[vars]
SEND_EMAILS_ENABLED = "false"

[env.preview.vars]
SEND_EMAILS_ENABLED = "true"

[env.production.vars]
SEND_EMAILS_ENABLED = "true"

when I run wrangler types, it creates this interface:
interface Env {
	SEND_EMAILS_ENABLED: "false";
}

which causes a type error because the type is not 'false' | 'true' or even string.

So the values need to be generated with all the possible values, and not with only the local value.

cc @andyjessop

Closing as duplicate of https://github.com/cloudflare/workers-sdk/issues/5082


Crystal: 0.24.1 -> 0.24.2

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: crystal
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-darwin (full log)
Attempted: crystal
Partial log (click to expand)
clang -fPIC    -c -o src/ext/sigfault.o src/ext/sigfault.c
./bin/crystal docs src/docs_main.cr
--: git: command not found
ar -rcs src/ext/libcrystal.a src/ext/sigfault.o
./bin/crystal build --no-debug -o .build/crystal src/compiler/crystal.cr -D without_openssl -D without_zlib
installing
post-installation fixup
gzipping man pages under /nix/store/nk9as9dhnmdbndf69ygwh3yyy40xsv30-crystal-0.24.2/share/man/
patching script interpreter paths in /nix/store/nk9as9dhnmdbndf69ygwh3yyy40xsv30-crystal-0.24.2
/nix/store/nk9as9dhnmdbndf69ygwh3yyy40xsv30-crystal-0.24.2

Success on x86_64-linux (full log)
Attempted: crystal
Partial log (click to expand)
shrinking /nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2/lib/crystal/ext/sigfault.o
wrong ELF type
shrinking /nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2/lib/crystal/llvm/ext/llvm_ext.o
wrong ELF type
gzipping man pages under /nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2/share/man/
patching script interpreter paths in /nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2
checking for references to /build in /nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2...
wrong ELF type
wrong ELF type
/nix/store/i66mayqmp1hr61cwghqqbg1v6nxpcfqv-crystal-0.24.2


Cannot provide the api a subreddit that contains only numbers

I tried to request from https://meme-api.com/gimme/196 but a number gives me a batch of messages instead the subreddit of 196.
I suggest changing custom one to https://meme-api.com/gimmecustom/

you can still get your desired output using this
just need to specify a quantity. this returns 3 posts from that subreddit:
https://meme-api.com/gimme/196/3


when entering a world, all tyrannosauruses in it will be in the same hunting state

should be different for each

doesnt apply in the remake branch

closed because this was for the old fabric version


Update readme with 1.0 changes & 1.1 roadmap

Updates to readme and roadmap for 1.0 and the latest info (previously shared in the Nov community call) for 1.1.

/azp run

/azp run


Jetbrains Gateway Icon Failure

Describe the bug
When using JetBrains Space with JetBrains Gateway icons are empty
To Reproduce

Create JetBrains Space organization
Start a dev environment
Open with JetBrains Gateway
Install plugin

Expected Behavior

Icons showing up
Environment
N/A
Screenshots

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Issue is still occuring


fix(modal): filter out non tabbable elements

@antman888, This looks good but needs tests.  Thanks.

@icfantv Thanks for the review. I've added a few tests.
Did I need to leave this comment or do you get notified of changes automagically?

This LGTM - thanks for the work on the PR (including adding the tests)!


New dataprovider2

@qbilius @damro it would be great to have code review on this.   it's a fairly extensive change to the data API.

Everything looks good to me.
I have just a few questions:

Why do we have a dont_run flag in train_from_params and test_from_params now? Maybe we can split the function instead?
For the thread locking in data.py, why do we need two nested locks? I thought the use of "threadsafe_iter" already makes the iterator thread-safe. Are you sure there won't be a lockout problem? A short documentation on that (Coordinator, Item, threadsafe_iter) would be nice.