Improve test coverage

I have some more tests, and I wanted to clean them up before sending this PR, but it looks like I've already waited far too long, and just increased the chance of conflict with tests from other contributors. So I'm sending this PR now.
Tests:

better test coverage
better tests structure with folders for groups of features and smaller feature-oriented files
simpler test setup with karma-fixtures which loads HTML fixtures from file
simpler test setup with def() and subject() lazy helpers from karma-jasmine-def
updated devDependencies

Bug fixes:

Fix bug exposed by tests: Can't init list from list html attribute.
Fix bug exposed by tests: List isn't hidden by default.

Also contains temporarily disabled test for found bug. See Fix for open() will not open list before any input event. I can look at it as soon as I have time and more tests ready. Maybe there is more than 1 bug there.

@LeaVerou I know you are usually super busy, but can you please merge this huge PR soon, so I can safely continue to work on more similar looking tests?
Also, would you agree to add code coverage reporting (Code Climate or Coveralls), similar to Travis CI builds info we already have now?
It's good to see, which code is covered by tests, and which is not. I'll do a separate PR if you agree.

Almost 100% test coverage now. Woot!
I'm planning to add missing initialization and export tests, once I figure out a better way to do it.
Chrome 46.0.2490 (Mac OS X 10.11.1): Executed 197 of 198 (skipped 1) SUCCESS (0.27 secs / 0.18 secs)

Suites and tests results:

 - awesomplete.close :
   * closes completer : ok
   * makes no item selected : ok
   * fires awesomplete-close event : ok
 - awesomplete.evaluate :
   - with too short input value :
     * closes completer : ok
   - with no items found :
     * closes completer : ok
   - with some items found :
     * opens completer : ok
     * fills completer with found items : ok
     * makes no item selected : ok
 - awesomplete.goto :
   * clears previous aria-selected : ok
   * goes to first item : ok
   * goes to last item : ok
   * fires awesomplete-highlight event : ok
   - with item index > -1 :
     * sets aria-selected : ok
     * updates status : ok
   - with item index = -1 :
     * does not update status : ok
 - awesomplete.next :
   - without any items found :
     * does not select any item : ok
   - with some items found :
     - and no item was already selected :
       * selects the first item  : ok
     - and some item was already selected :
       * selects the second item : ok
       * selects the last item : ok
       * selects no item after reaching the end : ok
 - awesomplete.open :
   * opens completer : ok
   * fills in the list on creation : skipped
   * fires awesomplete-open event : ok
   - with autoFirst: true :
     * automatically selects first item : ok
   - with autoFirst: false :
     * does not select any item : ok
 - awesomplete.opened :
   - with newly created completer :
     * is false : ok
   - with opened completer :
     * is true : ok
   - with closed completer :
     * is false : ok
 - awesomplete.previous :
   - without any items found :
     * does not select any item : ok
   - with some items found :
     - and no item was already selected :
       * selects the last item  : ok
     - and some item was already selected :
       * selects the second item from the end : ok
       * selects the first item : ok
       * selects no item after reaching the start : ok
 - awesomplete.select :
   - with closed completer :
     * does not change the input value : ok
     * does not fire awesomplete-select event : ok
     * does not fire awesomplete-selectcomplete event : ok
   - with opened completer :
     - and no current item :
       * does not change the input value : ok
       * does not fire awesomplete-select event : ok
       * does not fire awesomplete-selectcomplete event : ok
     - and current item :
       * fires awesomplete-select event : ok
       - and awesomplete-select event was not prevented :
         * changes the input value : ok
         * closes completer : ok
         * fires awesomplete-selectcomplete event : ok
       - and awesomplete-select event was prevented :
         * does not change the input value : ok
         * does not close completer : ok
         * does not fire awesomplete-selectcomplete event : ok
     - and item specified as argument :
       * fires awesomplete-select event : ok
       - and awesomplete-select event was not prevented :
         * changes the input value : ok
         * closes completer : ok
         * fires awesomplete-selectcomplete event : ok
       - and awesomplete-select event was prevented :
         * does not change the input value : ok
         * does not close completer : ok
         * does not fire awesomplete-selectcomplete event : ok
 - awesomplete.selected :
   - with newly created completer :
     * is false : ok
   - with opened completer :
     - and no item selected :
       * is false : ok
     - and some item selected :
       * is true : ok
   - with closed completer :
     * is false : ok
 - blur event :
   * closes completer : ok
 - input event :
   * rebuilds the list : ok
 - keydown event :
   * supports enter : ok
   * supports escape : ok
   * supports down arrow : ok
   * supports up arrow : ok
   * ignores other keys : ok
   * does nothing if not opened : ok
 - mousedown event :
   - with ul target :
     * does not select item : ok
   - with li target :
     * selects item : ok
   - with child of li target :
     * selects item : ok
 - form submit event :
   * closes completer : ok
 - Awesomplete.$.bind :
   - whith invalid element :
     * does nothing if element is undefined : ok
     * does nothing if element is null : ok
     * does nothing if element is false : ok
     * does nothing if element is 0 : ok
     * does nothing if element is empty string : ok
   - with valid element :
     * adds event listeners for all events : ok
     * adds single event listener for multiple events : ok
 - Awesomplete.$.create :
   * creates DOM element : ok
   - with various tag names :
     * creates <ul> element : ok
     * creates <li> element : ok
   - without options :
     * creates element without any attributes : ok
   - with simple options :
     * assigns properties : ok
     * assigns attributes : ok
   - with option for boolean attribute/property :
     * assigns from true value : ok
     * assigns from truthy value : ok
     * assigns from false value : ok
     * assigns from falsy value : ok
   - with inside: option :
     * appends to container by element : ok
     * appends to container by selector : ok
   - with around: option :
     * wraps specified element : ok
     * wraps element specified by selector : ok
 - Awesomplete.$ :
   - with default context :
     * returns DOM element : ok
     * finds by id : ok
     * finds by class name : ok
     * finds by tag name : ok
   - with custom context :
     * returns DOM element : ok
     * finds by id : ok
     * finds by class name : ok
     * finds by tag name : ok
   - with truthy non string expression :
     * returns the expression back : ok
   - with falsy non string expression :
     * returns null if expression is undefined : ok
     * returns null if expression is null : ok
     * returns null if expression is false : ok
 - Awesomplete.$$ :
   - with default context :
     * returns an array of DOM elements : ok
     * finds all elements : ok
     * finds DOM element : ok
     * finds by id : ok
     * finds by class name : ok
     * finds by tag name : ok
   - with custom context :
     * returns an array of DOM elements : ok
     * finds all elements : ok
     * finds DOM element : ok
     * finds by id : ok
     * finds by class name : ok
     * finds by tag name : ok
 - Awesomplete.$.fire :
   * fires event once : ok
   - fires different event types :
     * fires click event : ok
     * fires input event : ok
   - sets event properties :
     * makes cancelable event : ok
     * can't make non cancelable event : ok
     * makes event that bubbles : ok
     * can't make event that does not bubble : ok
     * sets properties on the event : ok
 - Awesomplete.$.regExpEscape :
   - with regular expression special characters :
     * escapes backslashes : ok
     * escapes brackets, braces and parentheses : ok
     * escapes other special characters : ok
     * escapes the whole string : ok
   - with plain characters :
     * does not escape letters : ok
     * does not escape numbers : ok
 - Html modifications :
   * binds to correct input : ok
   * turns native autocompleter off : ok
   - HTML tweaks :
     * creates container : ok
     * places input inside container : ok
     * creates list : ok
     * places list inside container : ok
     * hides list : ok
   - ARIA support :
     * makes input accessible : ok
     * creates status : ok
     * puts status inside container : ok
     * hides status : ok
 - Awesomplete list :
   * is empty if not provided : ok
   - setter :
     * assigns from array : ok
     * assigns from comma separated list : ok
     * assigns from element specified by selector : ok
     * assigns from element : ok
     * does not assigns from not found list : ok
     * does not assigns from empty list : ok
     - with active input :
       * evaluates completer : ok
   - constructor option :
     * assigns from array : ok
     * assigns from comma separated list : ok
     * assigns from element specified by selector : ok
     * assigns from list specified by element : ok
   - data-list html attribute :
     * assigns from comma separated list : ok
     * assigns from element referenced by selector : ok
   - list html attribute :
     * assigns from element referenced by id : ok
 - Constructor options :
   - with default options :
     * requires minimum 2 chars to open completer : ok
     * shows 10 items in completer : ok
     * does not select the first ocurrence automatically : ok
     * filters with FILTER_CONTAINS : ok
     * orders with SORT_BYLENGTH : ok
     * generates each completer item with built-in function : ok
     * mirrors found item into input with built-in function : ok
   - with custom options in constructor :
     * overrides simple default options : ok
     * overrides default functions : ok
   - with custom options in data-* attributes :
     * overrides simple default options : ok
 - Awesomplete.all :
   * is empty initially : ok
   * keeps a list of created instances : ok
 - Awesomplete.FILTER_CONTAINS :
   * is a function : ok
   - search in a plain string :
     * matches at the start : ok
     * matches in the middle : ok
     * matches at the end : ok
     * performs case insensitive match : ok
     * ignores whitespaces around the search value : ok
     * does not match if substring is not found : ok
   - search in string with special RegExp chars :
     * matches at the start : ok
     * matches in the middle : ok
     * matches at the end : ok
     * performs case insensitive match : ok
     * ignores whitespaces around the search value : ok
     * does not match if substring is not found : ok
 - Awesomplete.FILTER_STARTSWITH :
   * is a function : ok
   - search in plain string :
     * matches at the start : ok
     * does not match in the middle : ok
     * does not match at the end : ok
     * performs case insensitive match : ok
     * ignores whitespaces around the search value : ok
     * does not match if substring is not found : ok
   - search in string with special RegExp chars :
     * matches at the start : ok
     * does not match in the middle : ok
     * does not match at the end : ok
     * performs case insensitive match : ok
     * ignores whitespaces around the search value : ok
     * does not match if substring is not found : ok
 - Awesomplete.SORT_BYLENGTH :
   * is a function : ok
   - with strings of different length :
     * returns negative number if the first string is shorter : ok
     * returns positive number if the first string is longer : ok
   - with strings of the same length :
     * returns -1 if the first string < second string : ok
     * returns 1 if the first string > second string : ok
     * returns 1 if the first string == second string : ok

Browser results:

 - Chrome 46.0.2490 (Mac OS X 10.11.1): 198 tests
   - 197 ok, 1 skipped

Added code coverage reporting via Code Climate in #16792, which you might consider merging before this PR in order to check out code coverage improvement on Code Climate.

Ping :)
With this PR and #16792 merged in it would be safer and easier to merge other PRs.

Awesome, thank you so much!!! Merging now, sorry it took so long.

Thanks @LeaVerou
I've updated test for newly merged features. See #16804
And resolved conflicts in #16792.


use sparse matrix for poisson covariance

[x] Tests added / passed
[x] Passes flake8 pyunfold

I've used a scipy.sparse.dia_matrix to improve the Poisson covariance matrix calculation. It is orders of magnitude faster and more memory-efficient, and thus should allow for numbers of cause and effect bins well into the hundreds when cov_type='poisson'

Looks like some of the builds just timed out in the conda setup. Can they be re-run?

should close #108

@jrbourbeau mind taking a look at this and #110 ? Or forwarding to someone else? It'd be great to get these test timeouts sorted and these features into master


Pass an empty string to "prefix" to override Intl Locale config and not display currency code

Describe the feature
I would like to pass an empty string to "prefix" to override Intl Locale config and not display currency code
To Reproduce
<ReactCurrencyInputField
    prefix=""
    intlConfig={{ locale: 'en-US', currency: 'USD' }}
/>

Expected behavior
When typing "1234.56" input field could format to "1,234.56" instead of "$1,234.56"

Having the same issue, the problem is that the code uses || to default to the intl config and not ??:
https://github.com/cchanxzy/react-currency-input-field/blob/ab788f5d70b1977870cf3cfd6c65619c8aa23cdd/src/components/CurrencyInput.tsx#L91


[RESOLVED] High ICMP ping response time

Problem started at 16:28:29 on 2023.06.01
Problem name: High ICMP ping response time
Host: HP_iLO
Severity: Warning
Operational data: Value: 192ms
Original problem ID: 23060
Event details in Zabbix: http://<IP_ADDRESS>/tr_events.php?triggerid=23268&eventid=23060

Problem has been resolved in 2m 0s at 16:30:29 on 2023.06.01
Problem name: High ICMP ping response time
Host: HP_iLO
Severity: Warning
Original problem ID: 23060


Lint

fixes lint errors that cause build failures

@nesalang,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot


Edit parameters of flax module in another module

Hello everyone, I'm learning to use Jax, and I want to edit some parameters of a Flax module (nn.Dense) in a __call function of another module (my custom module). It looks like this code:
class MyModule(nn.Module):
  @nn.compact
  def __call__(self, inputs: Array) -> Tuple[BaseDispatcher, Metrics]:
    dense_layer = nn.Dense(features=num_experts, use_bias=False,
                            dtype=dtype, name="dense")
    dense_layer.weight = dense_layer.weight / 10

I looked for some documents and stackoverflow answers but it just provide the case for edit variables in the same module. Can you help me?

There is but you they have to exist first:
class MyModule(nn.Module):
  @nn.compact
  def __call__(self, inputs: Array) -> Tuple[BaseDispatcher, Metrics]:
    dense_layer = nn.Dense(features=num_experts, use_bias=False,
                            dtype=dtype, name="dense")
    out = dense_layer(inputs)

    # update params
    dense_params = dense_layer.variables['params']
    dense_params['kernel'] /= 10
    self.put_variable('params', 'dense', dense_params)

    return out


CTRL+A in Visual Preview of CSV data select application texts

Describe the bug
When i have CSV file response, then using CTRL+A being in Visual Preview (after clicking in) select texts outside preview.
To Reproduce
Steps to reproduce the behavior:

Connect to any endpoint returning CSV response (do not have any public one, sorry).
Ensure Visual Preview is shown and click inside.
Press CTRL+A to select all response.
See multiple texts selected, also endpoint URL, filter and so on.

Expected behavior
CTRL+A should select only preview text.
Screenshots
Can't, private data.
Desktop (please complete the following information):

OS: Windows 10 x64 1909
Installation Method: standard
App Version: 2020.3.3

Additional context
None.

Hi @SylwesterZarebski thanks for reporting this!
I can also reproduce this. For example if I press Cmd+A / Ctrl+A on a csv:

I get the following on the clipboard:


Need to add aggregation related fixes for SI-4.0.0 verion

Description:
Some aggregation related fixes are missing in the SI-4.0.0 version. So we need to add these fixes which were released for other SI versions to the SI-4.0.0 version.

Closed via: https://github.com/siddhi-io/siddhi/pull/1780, https://github.com/siddhi-io/siddhi/pull/1769, https://github.com/siddhi-io/siddhi/pull/1749, https://github.com/siddhi-io/siddhi/pull/1728


Update user role description + README to conform to new role structure

#345 refactored roles, but the description under the role field on the user edit page does not match the new roles:

Also, README setup instructions for promoting the default account need to be updated to promote user to :director instead of :admin!

I would love to try fixing that if you could give me a bit more details

@chrisgoutzi Sure thing!
Here's a list of our role changes from the initial 2.0 release.
The description in the screenshot when editing a user from the Admin panel (in manage page>users&staff>click on a user>edit) refers to the admin but we want it to instead be about a director -- and same for all other old roles in that description field.
This mistake also exists in the README file, which will need updating to its equivalent new role there too.
Something to note is that we're planning to get all 2.1 issues merged in by the due date on the 2.1 milestone (currently 11/7). If you need any more info, just ask!

@chrisgoutzi Hey, just checking in -- any updates on this issue?


Update minizincide to 2.1.5

After making all changes to the cask:

[x] `brew cask audit --download {{cask_file}}` is error-free.
[x] `brew cask style --fix {{cask_file}}` left no offenses.
[x] The commit message includes the cask’s name and version.

Something went wrong here with travis reporting back to github.
Travis build log says everything went fine: https://travis-ci.org/caskroom/homebrew-cask/builds/234508332

Verified locally.


Support finding a jsconfig.json with tsc -p .

Search Terms
jsconfig project
Suggestion
When I run tsc -p . on a JavaScript project with jsconfig.json and // @ts-check with JSDoc it complains about not finding a tsconfig.json
Currently I have to run tsc -p jsconfig.json --maxNodeModuleJsDepth 0 to check my JavaScript project.
~/projects/sync-wait-group on master*
$ tsc -p .
error TS5057: Cannot find a tsconfig.json file at the specified directory: '.'.

It tells me that tsconfig.json does not exist.
Adding detection for jsconfig.json and turning --maxNodeModuleJsDepth 0 on by default ( which we do for tsconfig.json but not jsconfig.json ) would be a good user experience improvmenent.
Use Cases
Being able to use the tsc cli on a JavaScript  + JSDoc project.
Examples
tsc -p . will "just work" for a JavaScript project.
Checklist
My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[X] This feature would agree with the rest of TypeScript's Design Goals.

This would be great for parity with VSCode's jsconfig.json support in JS projects.

The tsconfig docs says

Ideally this should stay at 0 (the default), ...

However it seems that the deafault value is different in case of jsconfig.json

I use "include" in jsconfig.json and keep maxNodeModuleJsDepth at 0.
npx tsc --noEmit --allowJs -p jsconfig.json --maxNodeModuleJsDepth 0
jsconfig.json:
{   "compilerOptions": {     "module": "CommonJS",     "target": "ES6",     "checkJs": true   },   "include": ["src/**/*"] }


[oc-id] Bump omniauth to 1.3.2

Recently, omniauth shipped a fix to a security vulnerability:
https://github.com/omniauth/omniauth/pull/867
I haven't investigated whether this is a serious issue for us, but it
seemed prudent to just try an update.
Signed-off-by: Steven Danna<EMAIL_ADDRESS>

CI is failing for this because of some ruby-version shenanigans.


Unable to resolve dependency tree after upgrade project to Angular 14

Describe the bug
After upgrading angular project to v14 and running npm install I encountered the error in image below
To Reproduce
Steps to reproduce the behavior:

Upgrade an Angular project to v14
Run npm install

Expected behavior
Dependencies must be upgraded
Screenshots

v14 was just released


Do not check for shadowing repeatedly in inlining passes.

Applied to A P4:
real    1m54.165s
user    1m45.484s
sys     0m9.316s

Applied to A P4+:
real    16m36.850s
user    16m24.559s
sys     0m15.304s


Paste image from clipboard?

Any way of pasting an image you have on the clipboard into a note? Eg. when you take a screenshot

+1. I am also looking for that.

I've tried many methods , find using shutter with key shortcut can be a good way, shutter can store screenshot to local and we can directly drag them to note to upload

I think this is the only feature missing right now :+1:

This feature would be really great!

If this feature existed, I would use nothing but Tusk for my notes!

I also be waiting for this features.

I'm also looking for this feature,it would be great to have this feature!

This worked for me before but somehow stopped working a few weeks ago. Loved the feature I hope it returns!

Very strange because sometimes it works and sometimes not. No repeatability

yeah I also was under the impression that it worked for me with 0.23. Maybe Evernote changed something in their web-client that is not compatible with tusk anymore?

+1 on this, really looking forward

you can already do this in the new tusk version using the beta editor. You can also resize the image.

you can already do this in the new tusk version using the beta editor. You can also resize the image.

@HM102 can you tell me how to test the beta editor? I just installed the latest version 0.23 and this feature is still not present

To enable beta editor (and ability to paste an image from the clipboard) go to Evernote Settings and click "Go to new version" in Account Summary:

After that refresh Tusk to get new editr

it work. Finally can paste pic from clipboard

Thank you @matryosha. I can't open 'Evernote Settings' here, with Tusk 0.23.0 and Fedora 33. Does anyone have the same error or know why?

@franciosi You don't have to switch to the new version inside Tusk. Login elsewhere using any browser and make that change there. As Tusk is not receiving any further development I suggest just start using Evernote using a browser of your choice. Also, something like webapp-manager could make things handier.

@matryosha , good tips, thank you


feat(facade): add support for Array shift and unshift

/cc @mprobst

See comment, otherwise LGTM, please merge.

Thanks for review, comment addressed & landed as 017024a21935c7d435aeedc9ef776b65821f59c7


Fix: infinite loop on empty record

Fixes a bug that caused the generator to go into an infinite loop when trying to generate empty record runtype.
Fixes #33, more details there.
I think the problem was caused by writeRecordType not writing anything at all if the record had no fields, since groupFieldKinds will correctly return and empty array if you pass it an empty array.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@f6a24d6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop      #34   +/-   ##
==========================================
  Coverage           ?   92.85%
==========================================
  Files              ?        2
  Lines              ?       98
  Branches           ?       11
==========================================
  Hits               ?       91
  Misses             ?        7
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a24d6...9a53adc. Read the comment docs.


TypeError: cannot unpack non-iterable Mesh object in examples isolines and boundaries

I tried to run example files isolines and boundaries from Anaconda prompt (Anaconda3) but i got the same error for both .
on Windows compas version  0.16.1
(igl) C:\Users\nizart\Documents\Projects\compas_libigl>python C:\Users\nizart\Downloads\boundaries.py
Traceback (most recent call last):
  File "C:\Users\nizart\Downloads\boundaries.py", line 24, in <module>
    boundaries = igl.trimesh_boundaries(mesh)
  File "c:\users\nizart\documents\projects\compas_libigl\src\compas_libigl\boundaries\__init__.py", line 37, in trimesh_boundaries
    V, F = M
TypeError: cannot unpack non-iterable Mesh object

(igl) C:\Users\nizart\Documents\Projects\compas_libigl>python C:\Users\nizart\Downloads\isolines.py
Traceback (most recent call last):
  File "C:\Users\nizart\Downloads\isolines.py", line 25, in <module>
    vertices, edges = igl.trimesh_isolines(mesh, scalars, 10)
  File "c:\users\nizart\documents\projects\compas_libigl\src\compas_libigl\isolines\__init__.py", line 43, in trimesh_isolines
    V, F = M
TypeError: cannot unpack non-iterable Mesh object

(igl) C:\Users\nizart\Documents\Projects\compas_libigl>

yes that is because of a recent update in compas. just convert the mesh to vertices and faces explicitly before using it as input.
boundaries = igl.trimesh_boundaries(mesh.to_vertices_and_faces())

Ok. Thanks

could you file this as a separate issue or pull request?
thanks


AssignedUser : Filter by domaine

The \Uccello\Core\Models\User::getAllowedGroupsAndUsersProcess() function retrieves all groups and users from all domains. It is important to filter and display only data related to the current domain.

It is necessary to solve #42 first for the query scope to be available.


setup code quality jobs in CI

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f13e458). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage          ?   96.47%
=========================================
  Files             ?        5
  Lines             ?      170
  Branches          ?        0
=========================================
  Hits              ?      164
  Misses            ?        6
  Partials          ?        0

Flag
Coverage Δ

unittests
96.47% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13e458...61ac140. Read the comment docs.


Feat: Making Tailor Page

Is there an existing issue raised for this?

[X] I have searched the existing issues

Describe the feature
Making Page for list of tailors in it
Add Screenshots

Record Options

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'23 contributor
[X] I want to work on this issue

@PatilHarshh go for it

@Siddhant-Patil0203 this is feature implementation why level one brother,  i am adding new page to your website and this is not ui/ux


Cube demo assumes linear image support that may not exist

The cube demo checks to see if linear textures can be sampled from directly (when use_staging_buffer is not set) and if supported creates such a texture directly.
If the staging flag is enabled or linear textures can't be sampled from then it does a staged upload to an optimally tiled texture. The staging resource is not a buffer though, it still creates a linear image to copy from.
The spec only requires optimal support for images it doesn't require any linear support at all, so it's valid for it to be impossible to create such a linear image - instead the code should create a buffer and use vkCmdCopyBufferToImage.

Fixed with PR #71


Markdown headers like ##Overview## stopped displaying correctly in kata descriptions

In my kata descriptions I have some Markdown headers like this ##Overview## that previously displayed just fine, with the header text in a larger font and on a line by itself, but right now the headers are displaying in body text on the same line as the following paragraph, and including the hashmarks. See https://www.codewars.com/kata/fizz-buzz-cuckoo-clock as an example of how those headers have stopped displaying correctly.

Ditto - I use similar markdown https://www.codewars.com/kata/airport-arrivals-slash-departures-number-2/javascript also worked fine yesterday.

I'm surprised that used to work. "## header" is the proper format.
I deployed an updated version of the markdown parser library today which is why this must have changed.

Yes.  FYI - Now it is fussy about the spaces. I've just re-published a dozen broken descriptions.
#Header1
##Header2

Used to work. But now it must be changed to:
# Header1
## Header2

Thanks for the correction -- I guess I had misinterpreted a markdown cheat sheet a while ago, and until yesterday the misinterpretations had worked. I went back and fixed them now. I guess I should close this if it's not actually an issue.


Used fastq strategy for FASTA

Codecov Report

Merging #79 into master will decrease coverage by 51.34%.
The diff coverage is 42.85%.

@@             Coverage Diff             @@
##           master      #79       +/-   ##
===========================================
- Coverage   99.43%   48.08%   -51.35%
===========================================
  Files           5        5
  Lines         177      183        +6
  Branches       32       34        +2
===========================================
- Hits          176       88       -88
- Misses          0       93       +93
- Partials        1        2        +1

You need to handle the case where wrap_length = 0

You need to handle the case where wrap_length = 0 i.e no wrapping

I'm actually a bit confused about why wrap_length=0 is ok for FASTQ but not FASTA. Also about whether I would handle this in the tests or in the code itself.

You need to handle the case where wrap_length = 0 i.e no wrapping

I'm actually a bit confused about why wrap_length=0 is ok for FASTQ but not FASTA. Also about whether I would handle this in the tests or in the code itself.

So I think there is a slight difference between fastq and fasta implementations in that fasta is None by default and fastq is 80 by default. I basically say in fastq that if the wrap_length is 0, dont wrap, otherwise wrap.

You need to handle the case where wrap_length = 0 i.e no wrapping

I'm actually a bit confused about why wrap_length=0 is ok for FASTQ but not FASTA. Also about whether I would handle this in the tests or in the code itself.

So I think there is a slight difference between fastq and fasta implementations in that fasta is None by default and fastq is 80 by default. I basically say in fastq that if the wrap_length is 0, dont wrap, otherwise wrap.

Oh I see. Perhaps I could edit fasta_entry to use the same strategy.


[refactor][java-client] Reduce code duplication in admin client

###Motivation
The admin client uses GET requests frequently. Most of these code places share
a simple InvocationCallback that completes a CompletableFuture with the response.
By moving all this into a common place, the code will be cleaner, and GET requests
will look more like other requests.
###Modifications
Move the functionality implemented in InvocationCallbacks to a common place.
Hide creation of CompletableFuture to be consistent with other HTTP method
implementations (e.g. asyncPutRequest).

[ ] Make sure that the change passes the CI checks.

This change is a trivial rework without any test coverage.

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Need to update docs?

[X] doc-not-needed
This is pure refactoring, no behavior is changed.

/pulsarbot rerun-failure-checks

/pulsarbot rerun-failure-checks


fix: default import for typescript

Yet another fix for default import. Better provide two require interfaces:
For JavaScript (don't changed):
const waitForExpect = require("wait-for-expect");

For TypeScript (babel don't generate default import, but types have it):
import waitForExpect from "wait-for-expect";

I add a addDefaultProperty to .babelrc file. But this option was added in new version, so I upgraded this package.
P.S. Your dependencies is not up to date. Maybe there is an easier way to do it.

How should I use it otherwise? It complains with TypeError: wait_for_expect_1.default is not a function when I use it in typescript with
import waitForExpect from 'wait-for-expect';
waitForExpect(() => {
  expect(deletedDocument).toBeNull();
});

@maricn how you installed patched wait-for-expect? I use prebuild version from here.

@KillWolfVlad Thanks for the PR and for the instructions. It works on my machine, but I'm waiting for PR resolution for committing to prod code.

Shoot, sorry, somehow github didn't notify me about this discussion. Getting this to the top of the todo list. Thanks!

:tada: This PR is included in version 1.1.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


the mistake with burning aiyprojects into sd card

format the sd card
iburned the aiyproject into the sd card
then start
the power light of the raspi was open at the first beggining,then shut down
the sd card light flashed alwasys
the hdmi is ok but stop in the start show (colour picture),not go into the system

It's actually unclear what's happening from your description. Can you provide more details? It's always good to try to reflash SD card again.

@childswong please make sure to use adequate power to boot the kit. It requires minimum of 2.1amp in order to boot properly.


add setter to json object options

Codecov Report

Merging #1311 (e90345f) into main (59ec214) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1311      +/-   ##
==========================================
- Coverage   94.06%   94.04%   -0.03%
==========================================
  Files         230      230
  Lines       39376    39384       +8
==========================================
- Hits        37041    37040       -1
- Misses       2335     2344       +9

Impacted Files
Coverage Δ

src/schema/json_object_options.rs
85.71% <0.00%> (-14.29%)
:arrow_down:

src/store/compressors.rs
85.10% <0.00%> (-2.13%)
:arrow_down:

.../termdict/sstable_termdict/sstable/block_reader.rs
80.35% <0.00%> (-1.79%)
:arrow_down:

src/postings/stacker/expull.rs
98.57% <0.00%> (-0.48%)
:arrow_down:

src/query/union.rs
99.39% <0.00%> (+0.60%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59ec214...e90345f. Read the comment docs.


array subscript doesn't have correct precedence

Describe the bug
No response
To Reproduce
dev=> select 1 = (array[1])[1];
ERROR:  QueryError: Feature is not yet implemented: Equal[Int32, List]
Tracking issue: https://github.com/risingwavelabs/risingwave/issues/112

Expected behavior
pg:
postgres=# select 1 = (array[1])[1];
 ?column?
----------
 t
(1 row)

Additional context
No response

To clarify, the desired precedence is as follows:
select 1 = (array[1])[1] should evaluate (array[1])[1] first, resulting in select 1 = 1, which can be compared.
The current behaviour is:
select 1 = (array[1])[1] is evaluating select 1 = array[1] first, resulting in Equal[Int32, List].
We can achieve the desired behaviour if we give array access a higher precedence.

I did not find a RW documentation about what the desired operator precedence is. I assume that it is the same as in Postgres (see PSQL Docs). Please correct me if I am wrong @xxchan @fuyufjh

Yes, we try to be compatible with PG if not otherwise specified

Different ASTs for the working and broken query respectively
select (array[1])[1] >= 1; # working
AST: [Query(Query { with: None, body: Select(Select { distinct: false, projection: [UnnamedExpr(BinaryOp { left: ArrayIndex { obj: Nested(Array([Value(Number("1"))])), index: Value(Number("1")) }, op: GtEq, right: Value(Number("1")) })], from: [], lateral_views: [], selection: None, group_by: [], having: None }), order_by: [], limit: None, offset: None, fetch: None })]

select 1 <= (array[1])[1]; # broken
AST: [Query(Query { with: None, body: Select(Select { distinct: false, projection: [UnnamedExpr(ArrayIndex { obj: BinaryOp { left: Value(Number("1")), op: LtEq, right: Nested(Array([Value(Number("1"))])) }, index: Value(Number("1")) })], from: [], lateral_views: [], selection: None, group_by: [], having: None }), order_by: [], limit: None, offset: None, fetch: None })]

As you can see the broken query has the array index operator as the root node, instead of the binary >= operator.

PR is merged (see PR)


[PdrDashboard, v0.3] Display number of rows for each table

DoD

[ ] Add the number of rows to next to the table title

It is merged with the epic branch, so I close this issue


[Feature Request] migrate query for postgres

Hi, the migrate queries look great! Any chance to support postgres on top of mysql/SQL server/oracle? :)

Hi @mayel and thanks for the feedback!
While we don’t have plans to add Postgres support at the moment, we’ve made it so that users can easily develop procedures that extend Cypher queries. For starters, we’ve created a tutorial about developing query modules in Python. After that, it should be fairly straightforward to extend the migrate query module with Postgres support.
Curious about something? You can join our Discord community and chat with other graph developers :smile:


Logging in Java JNI doesn't use C4Log

Issue https://github.com/couchbase/couchbase-lite-android/issues/1914 filed against the wrong repository:

From review some JNI codes today, I noticed that logging in JNI code has its own logging which will log only to Android's logcat. The JNI log should call into C4Log so that the log messages can go to console/file/custom log correctly.

FIxed


Added Licensing FAQs

To-Do: Update licensing terminology in the rest of the docs

This change is

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c57823ed55114044ff7ec5bf125511742ea6def7/
Edited pages:

v19.1/licensing-faqs.md

note: some of the suggestions i've made in the additional faqs mention the phrase "please contact us". I recommend that the doc page contains a link to a contact form or some more details about how to contact us.

We should link to our support channel (link: https://support.cockroachlabs.com/hc/en-us). Alternatively, if we feel that is too specific, we can link to the general contact page (https://www.cockroachlabs.com/contact/), but I would recommend the first option to avoid having requests in many different channels.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/212c370d1cbd5d5bd1649cca3fbfb83981117e7d/
Edited pages:

v19.1/licensing-faqs.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6d713e81f8b4905f19b8d36846596cc6a01d35b0/
Edited pages:

v19.1/licensing-faqs.md

So a friend and I were trying to find this FAQ on the web site and we were stumped: it is not listed in the side bar alongside the other FAQs. Where can we find it?
Sent from my Android device with K-9 Mail. Please excuse my brevity.

I also used the "license" keyword with the search function and couldn't find anything.
Sent from my Android device with K-9 Mail. Please excuse my brevity.

@knz
Here's the link: https://www.cockroachlabs.com/docs/stable/licensing-faqs.html

So thank you for the link, that helps.
Meanwhile I find the page difficult to find:

if I open the docs site on my mobile browser, it does not appear listed in the main table of contents (which I assume corresponds to the sidebar)
the search function does not list it under the keyword "license"

Maybe there are ways to increase its discoverability?

You'd have to navigate to FAQs > Licensing FAQs on the sidebar nav. As for search, I remember a convo about indexing taking time after a page is published, but I could be misremembering. cc @jseldess

So starting later today the mobile version of the site I was getting on my phone was eventually updated. I think I was hitting an outdated version from cloudflare or something. Now the page is easy to discover. Thank you again!


Translation Error when trying to sign in

The problem
Using 4.0b1 loaded from HACS, I receive the following message where I normally should see a login page. I do see two fields that are unlabeled. I tried copying & pasting issue_token / cookies but no luck.
Translation Error: The intl string context variable "url" was not provided to the string "To link your Google account, authorize your account.
After authorization, copy-paste the provided Auth Token code below."
What version of this integration (ha-nest-protect) has the issue?
0.4.0b1
What version of Home Assistant Core has the issue?
2023.4.6
Device / Model
Havent gotten this far
Diagnostics information
cant get to this
Home Assistant log
Logs
```
Copy/paste any log here, between the starting and ending backticks (`)
```

Additional information
No response

What is your configured language in HA?

I'm currently getting the same and my HA is configured to Country= United Kingdom, Language = English (GB)

The work around for me was to switch the language to 'English', setup the plugin, then switch it back.

Sorry, ended up migrating to HAOS last weekend and that resolved most of my issues including this one. Still very new to HA.

Manually deleting the pt-pt.json file (as was done in c7210b80ccdfa16198e29509f55c4e4b6bf37ab1) will get rid of this error. That file contains translations of the 3.x strings and not the 4.x strings (which no longer contain a URL to click).

@JakeWharton thanks! In which version does this occur?

In 4.0b1.
This is because the translations were updated in https://github.com/iMicknl/ha-nest-protect/commit/c7210b80ccdfa16198e29509f55c4e4b6bf37ab1 after the 4.0b1 tag on the beta branch which also deletes the offending pt-pt.json file that breaks translation.

@JakeWharton oh, you are using the beta branch directly? Because this should not occur in the tagged version. I will clean up the beta branch and release 4.0b2 after this weekend. Feel free to do a PR as well.

I installed the 4.0b1 tag from HACS which exhibits the problem. I performed the manual deletion of the file to unblock myself.
I'm not using the beta branch, just saying that the problem has already been fixed on the branch but after the latest available tag.

have yo updated the package yet? becuase i still get this error while trying to install this.

@kmjsmith no sorry, not yet! If you take the main branch, it should work.

Should be fixed in latest beta! If you still see this issue, you might have a fork configured in HACS / something else is going wrong. Please remove your custom_components/nest_protect folder and install the new version manually.


nullref when StructuredFormatDisplay has bogus property name on portable profile

As mentioned at https://github.com/Microsoft/visualfsharp/pull/251#issuecomment-81905576
If one provides a bogus property name to StructuredFormatDisplay, a reasonable error is expected.  On portable profiles we instead get a nullref error message.
test cenwoiwe12: expected
    '<StructuredFormatDisplay exception: Method 'Test+CheckDisplayAttributes12+Foo.Val{Hello' not found.>' but produced
    '<StructuredFormatDisplay exception: Object reference not set to an instance of an object.>'

Culprit is these lines I believe. If first reflection call returns null, second line will nullref.  We should be checking for that and throwing a better error.

Marking up for grabs as the fix is very small.
Testing is a bit tricky due to need for portable -- suggestion when doing private validation is to strip down the core\portable test code to include only the printf tests, then run from there.  I can provide more details as needed.

ping on up-for-grabs

Because this involves a corner case in portable profiles only, and .NET Standard is the new new, I think we can close this.


Dramatic performance degradation  w/o top-k trick

According to my retraining, I got ~84 J&F w/ top-k but ~80 J&F  w/o top-k. It seems this trick influences the overall performance greatly.

By the way, have you studied the selection of Hyper-param "K" in top-k filtering?

Our s03 model drops to 84.1 without top-k. Top-k is a pretty neat trick and we have also applied it to the baseline in all ablation studies. We just tried a few values and picked 20.

Please see the updated readme for further help in reproducibility.


make deploy-dev-sklearn not working

/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
The makefile target deploy-dev-runtime (e.g deploy-dev-sklearn) is not working after introducing servingruntime
What did you expect to happen:
make deploy-dev-sklearn should work
What's the InferenceService yaml:
[To help us debug please run kubectl get isvc $name -n $namespace -oyaml and paste the output]
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:

Istio Version:
Knative Version:
KServe Version:
Kubeflow version:
Cloud Environment:[k8s_istio/istio_dex/gcp_basic_auth/gcp_iap/aws/aws_cognito/ibm]
Minikube/Kind version:
Kubernetes version: (use kubectl version):
OS (e.g. from /etc/os-release):

/assign


Assignments for admins

This PR adds new feature: assigning admins to events and event requests.
This fixes #537.

@wking assign views now use _assign auxiliary function.

On Mon, Nov 16, 2015 at 08:12:11AM -0800, Piotr Banaszkiewicz wrote:

@wking assign views now use _assign auxiliary function.

ee2536f → f4a68fc looks good to me.  I haven't had time to go back and
review the PR from scratch, and I think there was still template
duplication that we could factor out.  But if we're hitting the end of
the polishing quota for this issue, I'm also fine with you deploying
it as-is.

@wking thanks!


Add a unique identifer for source node

We should have some way of identifying the columns that serve as a unique identifier for a source node.

+1 on this. Is it something that's useful to enable for all nodes not just source nodes?

Yeah, agreed, it would be useful on all nodes!

Now supported with https://github.com/DataJunction/dj/pull/394


mshv-{bindings,ioctls}: Update to latest mshv

In the current stable version hv_register_name was forked off into two segments: hv_register_name and hv_x64_register_name. The reasoning behind that being all the x64 registers could be separated from common set of registers.
The same needs to be reflected back to the mshv crate. Since we were generating rustified enum for hv_register_name it was creating trouble handling the registers. Thus, I propose we should remove the rustified enum generation for hv_register_name and just generate u32 consts.
Signed-off-by: Jinank Jain<EMAIL_ADDRESS>Requirements
Before submitting your PR, please make sure you addressed the following
requirements:

[x] All commits in this PR are signed (with git commit -s), and the commit
message has max 60 characters for the summary and max 75 characters for each
description line.
[x] All added/changed functionality has a corresponding unit/integration
test.
[x] All added/changed public-facing functionality has entries in the "Upcoming
Release" section of CHANGELOG.md (if no such section exists, please create one).
[x] Any newly added unsafe code is properly documented.

@liuw @russell-islam This is a breaking change for CH, how do we handle such scenarios in general?

@liuw @russell-islam This is a breaking change for CH, how do we handle such scenarios in general?

That's easy. After this is merged, you submit a patch to update the dependency in CH. In the same patch you modify the code and  Cargo.lock at the same time.

The same needs to be reflected back to the mshv crate. Since we were generating rustified enum for hv_register_name it was creating trouble handling the registers. Thus, I propose we should remove the rustified enum generation for hv_register_name and just generate u32 consts.

I don't have a strong opinion on this part.

I added rustified enum may be because of some build error with the previous rust version. If removing that does not cause any build or runtime issues I am fine with that. But we need to test CLH test suits for validations.

I added rustified enum may be because of some build error with the previous rust version. If removing that does not cause any build or runtime issues I am fine with that. But we need to test CLH test suits for validations.

Do you remember which version? CH has an MSRV (and a policy for updating that) so it may not matter anymore.

Since we were generating rustified enum for hv_register_name it was creating trouble handling the registers.

What is the trouble it created?
I do think there's a (small) benefit to keeping the enum - having an explicit type for something is always better when possible.
That said, it's not a big deal. If there is some real annoyance it is causing, then I'm not opposed to removing it.


Fixing zero values

Currently the plugin doesn't support zero 0 values for tokens, the check if (values.opacity) for example skips the update because 0 === false and then it won't update the styles.
I've updated the checks to typeof prop !== 'undefined' so it also works for 0 values and added an extra value check for properties that don't allow 0 values in Figma (ie. width, height, border width, …) and convert the 0 to 0.001.
This way I can set my opacity to 0 or hide elements.
What do you think?

Another thing I just noticed is that for sizing this seems to not work yet, as Figma requires a value larger than 0.01 (we set it to 0.001) - I'm thinking this is a bug on Figma's end. Why would they not allow 0.001 values?


Depth Buffer Corrupt on Mac

The problem seems to be here:   3253922 WARNING    Read: Depth buffer is corrupt. Size is 0 (!= 614400)
The full log plus the configuration file follows.  Any idea how to proceed?
934 INFO       New log started on 2012-02-25 20:14:41
962 INFO       OpenNI version is 1.5.2 (Build 23)-MacOSX (Dec 28 2011 17:54:37)
971 INFO       --- Filter Info --- Minimum Severity: INFO
32984 INFO       Creating node 'Script1' of type Script: OpenNI/OpenNI/<IP_ADDRESS>...
33562 INFO       USB is initialized.
577938 WARNING    No PS sensor is connected!
2094967 WARNING    No PS sensor is connected!
2095031 INFO       Creating node 'Device1' of type Device: PrimeSense/SensorV2/<IP_ADDRESS>...
2096818 INFO       Module 'Device' configuration was loaded from file.
2647896 INFO       Connected to USB device
2647923 INFO       Property Device.USBPath was changed to 1d27/0600@38/2.
2659456 INFO       Hardware versions: FW=5.3.26 (9) HW=2 Chip=2 Sensor=1 SYS=14
2836686 INFO       Property Device.PhysicalDeviceName was changed to PrimeSense RD1.08x.
2836740 INFO       Property Device.VendorSpecificData was changed to PS1080SOC.
2836762 INFO       Property Device.ID was changed to<PHONE_NUMBER>.
2836805 INFO       Device sensor initialized
2837093 INFO       Creating node 'Depth1' of type Depth: PrimeSense/SensorV2/<IP_ADDRESS>...
2837187 INFO       Creating stream 'Depth1' of type 'Depth'...
2837212 INFO       Setting Device.ReadData to 1...
2843137 INFO       Endpoints open
2844400 INFO       Property Device.ReadData was changed to 1.
2844418 INFO       Device.ReadData was successfully set.
2845054 INFO       Property Depth1.Resolution was changed to QVGA.
2845071 INFO       Property Depth1.XRes was changed to 320.
2845081 INFO       Property Depth1.YRes was changed to 240.
2845090 INFO       Property Depth1.FPS was changed to 30.
2845098 INFO       Property Depth1.OutputFormat was changed to 1.
2845106 INFO       Property Depth1.BytesPerPixel was changed to 2.
2845115 INFO       Property Depth1.RequiredDataSize was changed to 153600.
2845124 INFO       Property Depth1.ParamCoeff was changed to 4.
2845187 INFO       Property Depth1.ShiftScale was changed to 10.
2854666 INFO       Property Depth1.ConstShift was changed to 200.
2854762 INFO       Property Depth1.ZPD was changed to 120.
2854885 INFO       Property Depth1.ZPPS was changed to 0.105200.
2854896 INFO       Property Depth1.LDDIS was changed to 7.500000.
2854992 INFO       Property Depth1.DCRCDIS was changed to 2.630000.
2855084 INFO       Property Depth1.Gain was changed to 42.
2855108 INFO       Property Depth1.SupportedModesCount was changed to 9.
2855118 INFO       Property Depth1.SupportedModesCount was changed to 15.
2855131 INFO       Stream 'Depth1' was initialized.
2855145 INFO       'Depth1' stream was created.
2857128 INFO       Module 'Depth1' configuration was loaded from file.
2857353 INFO       Setting Depth1.FPS to 30...
2857363 INFO       Depth1.FPS value did not change.
2857371 INFO       Setting Depth1.YRes to 480...
2857379 INFO       Property Depth1.Resolution was changed to Custom.
2857389 INFO       Property Depth1.YRes was changed to 480.
2857398 INFO       Property Depth1.RequiredDataSize was changed to 307200.
2857408 INFO       Depth1.YRes was successfully set.
2857416 INFO       Setting Depth1.XRes to 640...
2857423 INFO       Property Depth1.Resolution was changed to VGA.
2857431 INFO       Property Depth1.XRes was changed to 640.
2857439 INFO       Property Depth1.RequiredDataSize was changed to 614400.
2857448 INFO       Depth1.XRes was successfully set.
2857491 INFO       Setting Depth1.Mirror to 1...
2857500 INFO       Property Depth1.FirmwareMirror was changed to 1.
2857509 INFO       Property Depth1.Mirror was changed to 1.
2857515 INFO       Depth1.Mirror was successfully set.
2865942 INFO       USB read thread was started.
2865960 INFO       Property Depth1.ActualReadData was changed to 1.
3229536 INFO       Property Depth1.State was changed to 1.
3229562 INFO       Stream Depth1 is open.
3229957 WARNING    Depth: Expected 1, got 3
3229969 WARNING    Depth frame is corrupt!
3253922 WARNING    Read: Depth buffer is corrupt. Size is 0 (!= 614400)
3652494 WARNING    No PS sensor is connected!
4189631 WARNING    No PS sensor is connected!
4724636 WARNING    No PS sensor is connected!
5259643 WARNING    No PS sensor is connected!
5259737 INFO       Creating node 'Gesture1' of type Gesture: PrimeSense/XnVGestureGenerator/<IP_ADDRESS>...
5268207 INFO       Creating node 'Scene1' of type Scene: PrimeSense/XnVSceneAnalyzer/<IP_ADDRESS>...
5286228 INFO       Creating node 'User1' of type User: PrimeSense/XnVSkeletonGenerator/<IP_ADDRESS>...

<OpenNI>
  <Licenses>
    <License vendor="PrimeSense" key="0KOIk2JeIBYClPWVnMoRKn5cdY4=" />
  </Licenses>
  <Log writeToConsole="true" writeToFile="false">
		<LogLevel value="1"/>
		<Masks>
			<Mask name="ALL" on="true"/>
		</Masks>
		<Dumps>
		</Dumps>
	</Log>
	<ProductionNodes>
		<Node type="Depth" name="Depth1">
			<Configuration>
				<MapOutputMode xRes="640" yRes="480" FPS="30"/>
				<Mirror on="true"/>
			</Configuration>
		</Node>
	</ProductionNodes>
</OpenNI>

Ok, got this working now.
It turned out to be a pthread problem.  In Linux, sending an empty but initialized pthread_attr to pthread_create() was fine.  But on Mac I had to set that to NULL.  I thought the thread creation was failing because of a kinect init failure, but it turns out that the failed thread creation was causing a producer/consumer problem on the kinect.


FINERACT-835: Upgrade Swagger and automatically generate the JSON spec

FINERACT-835
Description
This PR includes:

Upgrading Swagger UI to the latest version (3.26.0)
Making Swagger UI a packaged dependency rather than checking in the individual files
Exposing Swagger UI in /fineract-provider/swagger-ui with response.json as the input
Adding Swagger Plugin to autogenerate the JSON spec
Configuring Gradle tasks to build the JSON spec automatically after build

The Swagger UI does not yet point to the new JSON (fineract.json) but instead points to the previous manually created response.json, which remains checked in. The next step would be to ensure the autogenerated fineract.json contains all the same information as the response.json. After that, the response.json can be deleted.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.

[x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.

[x] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.

[x] Integration tests have been created/updated for verifying the changes made.

[x] All Integrations tests are passing with the new commits.

[x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)

Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

Whoa! @ptuomola FYI @thesmallstar was going to look into Swagger after completing Checkstyle (and SQL security), but I'm sure he doesn't mind this start.. we have, more than, enough to do on this project for everyone!
I'll have a closer look at this myself also some time in the coming days.

@vorburger @thesmallstar Not to worry - there's still plenty to do on Swagger! I just did the basics: upgrading & fixed Swagger UI and added the Gradle task to create the JSON.
All the rest of the tasks still remain, i.e.

Getting the rest of the information into the generated JSON file
Improving layout / navigation of Swagger
Getting "Try me" button to work
Autogenerating client library
etc etc...

@ptuomola I really appreciate this work, I want to wrap SQL security and Swagger quickly (and nicely) so I can look into more functional issues at Fineract, and this would really help :D

/rebase

Thanks, @ptuomola for this PR.
This PR is a progress on swagger on Fineract.
@vorburger  thanks for reviewing this PR and merging it so quickly.


Fix restart kube-controller

kubernetesUnitPrefix was changed to k8s_* in 1.5. This patch reflects
this change in kargo

ci check this

ci check this


Migrate the host/[id] page to explored

Closed by https://github.com/SiaFoundation/web/pull/819 with hanging issues https://github.com/SiaFoundation/web/issues/825 and https://github.com/SiaFoundation/web/issues/824


fixes #117

@ddobrin I will take a look

@chenyan71 @ddobrin Do you think we should call the validateRequestBody if the contentType is null? I am thinking that we only need to validate if the header is application/json only; however, there might be the case that the user forgets to put the contentType header and we want to catch the error with the validation.

@stevehu @ddobrin
Light-rest-4j is used for restful API and if user enabled openapi validation from config file means user defined the API specification by openapi. In this case, if the request header didn't specify contentType, the default contentType should be treat as application/json


test new skillet types: edit, delete, move, ops

create skillets and validation functionality of new skilletLib support panos config actions
convert existing rest skillets to panos using the new model

can test these but first need quick docs if anything unique to element/xpath structure vs basic 'set config' skillets


[hotfix][docs] fix broken javadoc links in JDBC connector doc

What is the purpose of the change
Links to javadoc in the JDBC Datastream Connector are currently broken: the /api/java/ prefix seems to be present twice in the result.
Verifying this change
Validated the result manually with hugo -b "" serve.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving):no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
The S3 file system connector:no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not applicable

@sjwiesman , it seems my PR of a month ago (https://github.com/apache/flink/commit/e3f053e0ba05557e3a253e022259890d948557b5 ) contained erroneous javadoc links, sorry about that
=> here's a quick fix.


Build failing

The auto update of the website based on the GitHub is failing, arrive 16th July it looks like...

This is fixed, at least temporarily, by an hourly cron job.


esmfold CPU only

Won't be able to be pushed directly to nf-core in its current state.
We will need to either upload the current cpu-only working conda environment publicly,
or create and upload a working GPU/CPU conda environment.

If want to merge into main, we will need to currently remove checks for docker and singularity images. Else we keep it in a separate branch.

@vagkaratzas is this one still relevant?

@vagkaratzas is this one still relevant?

Will never pass tests because one will need to copy my conda environment, local or codon one to their machine. Other than that, it would be useful for anyone that wants to run protein structure predictions. It also has a GPU (codon env) mode now

I close this one as it was running the actions everytime main was updated... wasting GA credits


Remove leftover CLA bits, use consistent uppercase

In case you are wondering why this PR is closed, see https://github.com/doktornotor/pfsense-closedsource
I'm not willing to contribute to closed-source projects that are falsely advertising themselves as open-source any more.


Current build has job hang issues

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
I'm experiencing massive amount of job hangs (hundreds of jobs across two servers) when running the current source committed to GitHub (last commit April 11). It goes away when reverting to <IP_ADDRESS>.
I haven't had much luck reproducing it but it's definitely happening.

seems @proxb busy there days, but significant changes was inspired by me and I have some time :)
any details to share ?
PS version, hang conditions ?
It hang somewhere iside a job itself or at -RSJob command ?

It can hang at any time ?
it can happen at job starting, removing, ?
2 minutes after starting (cleanup) ?
if you take latest version, edit PoshRSJob/PoshRSJob.psm1,  move $job.Completed = $True from line 163 back to <IP_ADDRESS> place (right after $job.InnerJob.dispose(), line 156 ) it solve your problems ?

PS 5.1, throttle of 8, 500 jobs piped from start to wait to receive, and with a couple of these concurrently. It's not clear which part hangs on the source version (and it's only on some scenarios).
I'll do some experimentation over the next week or so to try to pin it down but wanted to raise the issue first so it doesn't get put it as a release or something.

Console hang or you can Ctrl+C it ?
or it's run from scheduler ?
you can also try my lates commit, it's have some problem fixed (for remove- and stop-)

Yea, it has been a busy few months for me with a new job and spending time with family. I'm tracking any new issues and PRs submitted as well as making some updates behind the scenes.
I'm definitely curious as well as to what is going on and it looks like @MVKozlov has identified some key changes since <IP_ADDRESS> that could potentially be impacting the jobs. Looking forward to seeing what you find @codykonior in the coming weeks so we can identify and fix the bug.

On a side note, I will hold off on another release (and PowerShell Gallery update) until this is fixed. I will probably still accept the PR that is pending and then we can work backwards to the last known working commit to see what needs to be fixed.

Yes I use strict mode for everything. Current version plus moving the dispose line seems to improve things but I'll check back in after an overnight run. This would imply this part is causing it to exit early and could stand to be improved:
If (($Data.Count -gt 0) -AND (-NOT ($Data.Count -eq 1 -AND $Null -eq $Data[0]))) {

Do you add $DisposePoshRS_RunspacePools = $false ? or current version means my fork latest version ?

I did both suggestions - moving Dispose up a few lines plus setting this variable earlier.

(On Boe's current checkins, not your fork)

if so, try to move $job.Completed = $True back to current release place ;)
I think its  $DisposePoshRS_RunspacePools = $false  becase witout it strict mode fail and $PoshRS_Jobs cycle throws without exiting from [Monitor]
and if Completed also break things throwing can be in If you mentioned
anyway i think this code need try {} finally {} block

Yes it seems to work with $job.Completed = $True in its version as per source control, meaning the earlier one was doing the most damage.
If it's possible $DisposePoshRS_RunspacePools is defined, test it with (Test-Path variable:DisposePoshRS_RunspacePools) in that if test. Best not to wrap in dummy try/catch.

sorry, my English not so good, I can't understand half of you message :)
I can say only that try finally is not try catch :)

It's possible it still exits in that section - just less frequently. I just had this happen.
Boe is it possible to merge the rest of the pull request so that I can then work on the one version?

Done. I'll wait to add it as a new release for a bit to see if this issue can be resolved.

I haven't had any further issues in that build.


Example for a Garagedoor

first of all: thanks for that great piece of software! i tried some examples and all of them work really well.
when i was looking for a garagedoor-example i was not able to find one :-(
i tried to build one by myself but failed. so is there anyone out there who could show me how to get an garagedoor to wirk?

Hi,  nice to hear positive feedback.
Due to limit of my time. I can add generic definition to the library for Garage door and probably you can help me to implement example of skecth. after generic definition it will be more easy.
If agreed i will notify when library will contains generic methods for Garage door

Hi,  nice to hear positive feedback.
Due to limit of my time. I can add generic definition to the library for Garage door and probably you can help me to implement example of skecth. after generic definition it will be more easy.
If agreed i will notify when library will contains generic methods for Garage door

Hi again

I've changed library within public methods for Garage door
I've created initial sample ,  without testing, just showing integration into the Applle home kit

So, you can concentrate to adjust a sample how it should manage garage door mechanism.
I will appreciate a pull request with full function sample

Hi again

I've changed library within public methods for Garage door
I've created initial sample ,  without testing, just showing integration into the Applle home kit

So, you can concentrate to adjust a sample how it should manage garage door mechanism.
I will appreciate a pull request with full function sample

thanks for you work. i will try things with your changes and will give you some feedback.

thanks for you work. i will try things with your changes and will give you some feedback.


Install ManimGL in tests

work in progress

Maybe you've got an idea for why the testing doesn't work here, @bhoov ? Locally, when I start via the new debug configuration named "Test extension" everything works flawlessly. Same for a manual npm test in the console (which is the command that we execute in the pipeline).
Note that some dependencies are only installed in the pipeline via tests.yml.

You mean why testing doesn't work through github actions, but does work locally?
... I'm really not sure. I will take a look, but this CI is generally not my strong suit 🙈

You mean why testing doesn't work through github actions, but does work locally?

Yes, exactly. Locally it works via both methods (npm test) and via debug panel (preferred method locally). In the pipeline, where we use npm test the test times out. Dependencies were correctly installed, so it's probably not a Manim problem per se but some interaction with the VSCode terminal, the way I inject it and the way that I mock the VSCode API with sinon.js

... I'm really not sure. I will take a look, but this CI is generally not my strong suit 🙈

Ok, but still, maybe I miss the forest for the trees and you might spot something I haven't even considered :)

And keep in mind you will have to run npm install again since I've added or updated some dev dependencies.

Ok, found my error, it's the way I pass the env variables in tests/main.ts. Instead I have to use the key extensionTestsEnv. I do tumble right into the next problem, but at least the blocking problem is now solved ;)

Wow, I actually found a bug by testing in the pipeline ;) In the Manim version detection, I was checking for the ManimGL v1.2.3 string, however I didn't do this with a multi-line regex. It then failed in the pipeline since this is what the terminal outputted:
RuntimeWarning: Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work
  warn("Couldn't find ffmpeg or avconv - defaulting to ffmpeg, but may not work", RuntimeWarning)
ManimGL v1.7.2

It showed a warning beforehand and therefore, we didn't see the ManimGL string. Testing is already paying off.


Integrating BPMX Model Files into Private PNG Chunks to Display Previews

I appreciate that you are converting the model files directly into your own format (BPMX). Since you've gone this far, how about storing this file format in a private PNG chunk? This means the file would be hidden within a PNG image.
There are companies that handle it this way in order to display a preview image without compatibility issues across all web browsers and operating systems  without the need to install any software/plugins. This could be done with a few lines of code; see: https://github.com/SavAct/pnghide

Cool idea, I've seen something like that at Koikatsu.
But what exactly are the compatibility issues and is this a feature you really need?
I'm concerned about the increase in bundle size due to the addition of these features

There are benefits to being able to immediately recognize which model is depicted in a preview image:

When someone shares a PNG file online, and I can directly see what the content will be, I am more likely to download it compared to an unfamiliar file format.

Typically, modern operating systems already display a preview of PNG files. If you have many models stored in a folder on your computer, it would be more convenient to see a preview of each model directly in order to differentiate them without needing to load each of them into a program.

Therefore, in my opinion, this file format within a png would likely achieve higher user acceptance and spread more quickly in forums and similar venues. However, the increased bundle size is indeed a significant point of criticism:
I have used "pngjs," which should already include the "crc32" library. Currently, pngjs has a transpiled size of 4.23 KB.

But what exactly are the compatibility issues and is this a feature you really need?

Sorry, "compatibility issues" was an inacurate ai translation.

4KB is huge. The bpmx format is a format I made for fast load, so if there's a big overhead here, there's no reason to use it


RFC 007: Alternative Ways to Create Mappers

So, correct me if I'm wrong but it seems that some of the takeaways from this RFC are:
* we will be enabling 3rd party modules

* it might make sense to create/provide a common interface and/or a set of tools for consistency and UX.

* in terms of security we might need to run this code in an isolated environment and we might need to "forbid" some tables, modules or functions that can expose sensitive information or can manipulate sensitive resources (or at least alert about it).

I think this RFC does an exhaustive analysis and expose important issues that maybe we haven't thought about before. We might come up with a good proposal here but IMO the implementation of this RFC would not occur in the immediate future since we do not have active users neither we have an active community wanting to contribute, yet. Also, it seems to me that it deviates from the original issue which was trying to find a way to create modules easier/faster.

On the last point, the use of aws_sdk to make pure-sql modules was explored and found to 1) not be much easier/faster if we don't want the functionality to suffer (we could make blocking INSERT/UPDATE/DELETE operations, probably, but transactions wouldn't work at all in that structure) 2) it has the worst or second worst security profile of them all.
To cover your other comment here not exactly. The SDK or DSL approaches can limit access by literally making the ability to express certain data accesses impossible. The Pure-SQL approach gives the modules access to all of the same data the owner of the database has, so there's no good way to firewall sensitive data from them.


v2 ANSI format shows forecast by hour, but v2 JSON format every 3 hours

I would like to parse the hourly weather forecast (chance of precipitation and MM) from the JSON format. For this, I am using
wget -qO - v2.wttr.in/heidelberg?format=j1

However I realized that the JSON format only provides the weather every 3 hours. You can check it out using the following command:
wget -qO - v2.wttr.in/heidelberg?format=j1 | grep \"time\": | sort -u

"time" values are [0, 300, 600, 900, 1200, 1500, 1800, 2100]; corresponding to "00:00 .. 21:00", respectively.

Is there any way to get the hourly forecast as it is shown in the terminal (ANSI format) by default?
Thanks!
Javier

@jperales Yes, it is a very good qustioon. Actually, it would be great to have the j2 format,
that provides absolutely the same data as v2 does, but in JSON format.


Prompts UAC every time when run

UAC is prompted every time I tag a file. I understand that administrator permissions are required on the initial run to set up the registry keys, but it should not be required simply to tag a folder/file. Could a separate install .exe be provided perhaps, so that UAC is only prompted during install?

I'll have a look on how to resolve it by the weekend

That's not something I'd implement at the moment, as resolving windows smart screen and UAC prompts would require signing of applications.
And since I'm not developing my own pet-projects at capacity which would allow to cover expenses for certificates (lowest is ~200 USD per year), I'm afraid that this is not something I'd currently resolve. The only solution (which I wouldn't really recommend, tbh) is to lower UAC security level.

Please don't apologise! This tool is really handy, it's just a minor thing really.
I did find that you can force an application to run without admin by adding a Registry entry under "HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AppCompatFlags\Layers". Just add a key with the name as the exe's path, and the value as "~ RunAsInvoker":

I've tested it and the exe now runs without an admin prompt but all tagging functionality still works fine.
Can the key just be added to AddToContextMenu.reg? I know admin perms are required initially for registry modification, but is there anything else that requires admin afterwards?

I believe that might be a solution - given that no system folders are to be changed. I'll give it some more thought by the end of the week

Ok I think I got this without code signing. Thanks for pointing out a direction.
The only downside I can see - trying to tag system\protected folders. Aside from that - It should work, given the user has admin rights.
Have a look at latest release, and let me know if something's not working for you.
https://github.com/Jamminroot/intag/releases/tag/<IP_ADDRESS>
I'll close the issue for now.


[KYUUBI #4658][FOLLOWUP] Improve unit tests

Why are the changes needed?

To allow up the reviewer's comment in  https://github.com/apache/kyuubi/issues/4660.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Dear sir, the follow up about pr https://github.com/apache/kyuubi/pull/4660 will be do in this pr, please help to review. @yaooqinn @pan3793 @bowenliang123

Let's change the name of test from [KYUUBI #4658] INSERT OVERWRITE DIRECTORY did check query permission to INSERT OVERWRITE DIRECTORY.
And add tests for both InsertIntoDataSourceDirCommand and InsertIntoHiveDirCommand in separate ut?

Let's change the name of test from [KYUUBI #4658] INSERT OVERWRITE DIRECTORY did check query permission to INSERT OVERWRITE DIRECTORY. And add tests for both InsertIntoDataSourceDirCommand and InsertIntoHiveDirCommand in separate ut?

Let's change the name of test from [KYUUBI #4658] INSERT OVERWRITE DIRECTORY did check query permission to INSERT OVERWRITE DIRECTORY. And add tests for both InsertIntoDataSourceDirCommand and InsertIntoHiveDirCommand in separate ut?

rename test is ok, and i has added tests for both commands in https://github.com/apache/kyuubi/pull/4660, it's that enough?

Let's change the name of test from [KYUUBI #4658] INSERT OVERWRITE DIRECTORY did check query permission to INSERT OVERWRITE DIRECTORY. And add tests for both InsertIntoDataSourceDirCommand and InsertIntoHiveDirCommand in separate ut?

rename test is ok, and i has added tests for both commands in #4660, it's that enough?

Have notice 2 ut added in PrivilegesBuilderSuite for different command plan , but only one e2e test added in HiveCatalogRangerSparkExtensionSuite. So it seems only one plan tested in e2e test.

Let's change the name of test from [KYUUBI #4658] INSERT OVERWRITE DIRECTORY did check query permission to INSERT OVERWRITE DIRECTORY. And add tests for both InsertIntoDataSourceDirCommand and InsertIntoHiveDirCommand in separate ut?

rename test is ok, and i has added tests for both commands in #4660, it's that enough?

Have noticed 2 ut added in PrivilegesBuilderSuite for different command plan , but only one e2e test added in HiveCatalogRangerSparkExtensionSuite. So it seems only one plan tested in e2e test.

Got it, i will add a e2e test for InsertIntoDatasourceDirCommand. thank you

Thanks, merged to master/1.7


Handle null character in query param

Codecov Report
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.47%. Comparing base (fc1684d) to head (af9af0d).

Files with missing lines
Patch %
Lines

...terventionplanapi/model/request/FindCsipRequest.kt
0.00%
0 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #203   +/-   ##
=========================================
  Coverage     91.46%   91.47%
- Complexity      712      714    +2
=========================================
  Files           131      131
  Lines          2133     2134    +1
  Branches        155      155
=========================================
+ Hits           1951     1952    +1
  Misses          121      121
  Partials         61       61

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


replace StopIteration with return

Python 3.7 adopts PEP 479, which replaces StopIteration with RuntimeError when raised inside a generator. This breaks _read.
I replaced raise StopIteration with return to fix this in the most strictly-equivalent way possible but we could omit the line entirely too.
fixes #230

It looks like the failing translation test might need to be updated too. Compare the translation with a . and the translation without a .. The expected results in the failing test match the translation without a . but the actual query text in the test does have a .. Am I missing something here?
On a side note, Python 3.7 isn't tested in Travis or tox. We should consider adding Python 3.7 tests since 3.7.0 was officially released a while ago.

Thanks @danong !

The build failures are unrelated to these changes, so this is good to merge

By the way, I'm starting to use something along the lines of the Pull Request Hack. Basically, if you get a non-trivial PR merged in, you get an invite to have commit access.
No pressure to do any more work than you already have. Just want to open the door to further collaboration. =)


[OSPRH-9371] Fix VerifySecret so it requeues when necessary

We've come to realize three things recently:

Returning an error to the reconciler along with a RequeueAfter will cause the reconciler to abandon the explicit requeue and only consider the error [1].
The VerifySecret function in lib-common was returning an error along with a requeue, thus contributing to the problem listed in item 1. [2]
Also, the error VerifySecret was returning was not a "not found" error, but a generic k8s error -- so it wouldn't be properly handled by callers looking for a "not found" error. [3]

Now VerifySecret only returns a non-empty ctrl.Result{} if the Secret is missing, so let's handle that case in a separate if-clause. [4]
Jira: https://issues.redhat.com/browse/OSPRH-9371
[1] https://github.com/openstack-k8s-operators/keystone-operator/pull/459
[2] https://github.com/openstack-k8s-operators/lib-common/blob/ad3edb6e67ab738cfdbf4e2e78ac403784a08ab7/modules/common/secret/secret.go#L423-L425
[3] https://github.com/openstack-k8s-operators/lib-common/blob/ad3edb6e67ab738cfdbf4e2e78ac403784a08ab7/modules/common/secret/secret.go#L425
[4] https://github.com/openstack-k8s-operators/lib-common/blob/579da98fa7a62b70b43cdba92e82d6497afe8835/modules/common/secret/secret.go#L425-L427

/cherry-pick 18.0.0-proposed


updating help and support page titles

Trello card
https://trello.com/c/iegZqeh0/3896-revise-page-titles-for-organic-search-get-help-and-support
Context
Now that we've added 'GOV.UK' to our page titles, we should review them to try and make sure they don't get truncated by Google.
This PR is for page titles in the get help and support section.
Changes proposed in this pull request
Guidance to review

Yep I'm happy with it 👍


1395 | Count number of teams | Java

Challenge no. 1395: Count number of teams (medium) -
What will change
The solution for challenge 1395 will be added
Type of Issue

[x] Adding New Code

Programming Language

[x] Java

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding.

Would love to take this.

Can you please assign it to me.


Add usql

usql is an universal command-line interface for SQL databases, heavily inspired and mostly compatible with psql, but:

is written in Go, which makes it easy to extend
is distributed as fully static binaries, which makes it very portable
supports most databases that have a Go driver, already including a few dozen different databases

Change has been accepted (and you have been credited) in eaea105f82726249c25aec674e8734e187708109. Thank you!


Add function to keep existing GET params when changing language

Rationale (for DSpace 6_x, JSPUI)
This pull request addresses an issue with _when changing the language in DSpace, already existing GET params are dismissed:
https://github.com/DSpace/DSpace/blob/9c16711dbef079e9eee55b660997b52adf487354/dspace-jspui/src/main/webapp/layout/navbar-default.jsp#L138
This leads to odd behaviour, since it dismisses current search results, etc.. The implemented functionality addresses this problem by keeping already existing GET params and adding/updating only the locale param.

This functionality can be used with arbitrary params, but is currently only implemented for switching language.
This patch can be applied to to DSpace 5, too, with minor changes._

@r3r57 : Thanks for your contribution.  Could you create a corresponding bug ticket in our JIRA system at: https://jira.duraspace.org/projects/DS/issues/ ?  It'd be helpful to describe the step-by-step process of how you can reproduce the bug you describe above, as that will help others to more easily review this code and ensure it fixes the bug you've reported.
If you do not yet have a JIRA account with us, you can request one by emailing<EMAIL_ADDRESS>


cue/interpreter/embed: glob with unspecified extension accepted as valid

What version of CUE are you using (cue version)?

$ cue version
cue version v0.0.0-20240703133932-f1f0963cb0f9

go version go1.22.3
      -buildmode exe
       -compiler gc
  DefaultGODEBUG httplaxcontentlength=1,httpmuxgo121=1,tls10server=1,tlsrsakex=1,tlsunsafeekm=1
     CGO_ENABLED 1
          GOARCH arm64
            GOOS linux
             vcs git
    vcs.revision f1f0963cb0f978020fc895202c50f40452da31b9
        vcs.time 2024-07-03T13:39:32Z
    vcs.modified false
cue.lang.version v0.10.0

Does this issue reproduce with the latest release?
Yes
What did you do?
env CUE_EXPERIMENT=embed
! exec cue export x.cue
stderr 'extension not specified'

-- dir/a.txt --
This is a file
-- dir/b.json --
{
   "field" : "name"
}
-- x.cue --
@extern(embed)

package x

x: _ @embed(glob=dir/*.*)

What did you expect to see?
Passing test (for some variation of the error message)
What did you see instead?
> env CUE_EXPERIMENT=embed
> ! exec cue export x.cue
[stdout]
{
    "x": {
        "dir/a.txt": "This is a file\n",
        "dir/b.json": {
            "field": "name"
        }
    }
}
FAIL: /tmp/testscript3739177402/repro.txtar/script.txtar:2: unexpected command success

Can you explain the reasoning behind an error? From a first look, the behavior on master seems reasonable.

Can you explain the reasoning behind an error? From a first look, the behavior on master seems reasonable.

Consistency with the initial design which says:

All files must be of the same type, as identified by the extension. In case the extension is not fully specified (for example @embed(glob=file.json*)), the type needs to be explicitly specified.

An alternative (which we could relax to) is if all files identified by a glob pattern result in known file types then the type is not required.