The picture at the top of the page doesn't show up well in dark mode

[Enter feedback here]
The picture at the top of the page doesn't show up well in dark mode.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4f7a81f0-e811-3420-5270-16bc0eb21baf
Version Independent ID: 8012480a-b73b-21b1-7212-911064182582
Content: Support for organization fonts in PowerPoint for the web - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/support-for-organization-fonts-in-powerpoint-for-the-web.md
Service: sharepoint-online
GitHub Login: @sheshachary
Microsoft Alias: v-shesna

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.


bring back Noto font

partialy reverts: 6245097febf847cd9d027c04df5000de3ae3736b
works in linux

on osx i don't see any difference

i merge this and hope for the best


Add link to distributed tracing doc from toc

Summary
Add link to the distributed tracing documentation from toc.
cc @noahfalk

Aha, I understand now 👍


famous.css - had to manually copy to client folder

@raix et al.
Im having to manually copy famous.css like so for this package to work for me?
cp .meteor/.famono-base/lib/famous/core/famous.css client/css

Otherwise the famous-surface / famous-group / etc. classes are not found and you get weird behaviour. Very confusing, took me a while to figure out my views were broken.
Using it with gadicohen:famous-views in a seemingly standard way. Not sure what Ive done wrong!?
Thanks in advance.

Make sure you have these lines in some client side JS to make sure the famono imports the CSS:
 // Rig some famo.us deps
famous.polyfills;
famous.core.famous;

As per famono README or end of famous-views Quick Start.

Ash sorry, my bad. A warning may of been good :) Thanks
On 11 Apr 2015 14:14, "Gadi Cohen"<EMAIL_ADDRESS>wrote:

Make sure you have these lines in some client side JS to make sure the
famono imports the CSS:
// Rig some famo.us deps
famous.polyfills;
famous.core.famous;
As per famono README or end of famous-views Quick Start.
—
Reply to this email directly or view it on GitHub
https://github.com/raix/Meteor-famono/issues/105#issuecomment-91835991.


Multiple file descriptors left open when querying the same domain

I'm trying to query many urls from the same domain (in my case - registry.npmjs.org).
I'm attaching reproduction code below, but the gist is that querying many urls concurrently results in many file descriptors being opened but not closed.
I've set the program to sleep for 5 minutes after all the requests have resolved so it would be easier to take a look at it.
While it's sleeping, if I get the pid and run lsof -p PID | wc -l I often get between 100-300 open file descriptors, even though all the requests have been resolved by then.
This presents me with a few issues:

I'm limited by the number of concurrent requests I can perform because the fd's stay open
I'm limited by the fs operations I can perform after the requests have resolved

I've tried limiting the number of requests with Semaphore and I've tried setting pool_max_idle_per_host to 1, but no luck.
Help would be much appreciated!
I'm using a FuturesUnordered here because my real code uses it - from the data I fetch I know what data I further need.
Reproduction code:
use std::{net::ToSocketAddrs, time::Duration};

use futures::stream::FuturesUnordered;
use tokio_stream::StreamExt;

#[tokio::main]
async fn main() -> anyhow::Result<()> {
    let urls = vec![...];

    let mut futures = FuturesUnordered::new();

    let mut ip = "registry.npmjs.org:443".to_socket_addrs().unwrap();
    let client = reqwest::Client::builder()
        .resolve("registry.npmjs.org", ip.next().unwrap())
        .danger_accept_invalid_certs(true)
        .build()
        .expect("failed to build reqwest client");

    let mut index = 0;
    let chunks: Vec<&[&str]> = urls.chunks(10).collect();
    for url in chunks.get(0).unwrap().iter() {
        futures.push(client.get(url.to_owned()).send());
        println!("Fetching {}", url);
    }

    loop {
        match futures.next().await {
            Some(_) => {
                index += 1;
                if index >= chunks.len() {
                    break;
                }

                for url in chunks.get(index).unwrap().iter() {
                    futures.push(client.get(url.to_owned()).send());
                    println!("Fetching {}", url);
                }
            }
            None => break,
        }
    }

    println!("Sleeping for 300 seconds");
    tokio::time::sleep(Duration::from_secs(60 * 5)).await;
    println!("Sleep ended");

    Ok(())
}

Full list of urls:
let urls = vec!["https://registry.npmjs.org/react-device-detect",
        "https://registry.npmjs.org/prosemirror-schema-list",
        "https://registry.npmjs.org/@tiptap/react",
        "https://registry.npmjs.org/md5",
        "https://registry.npmjs.org/is-even",
        "https://registry.npmjs.org/react-dom",
        "https://registry.npmjs.org/@tiptap/extension-text-style",
        "https://registry.npmjs.org/cross-fetch",
        "https://registry.npmjs.org/prosemirror-dropcursor",
        "https://registry.npmjs.org/@amplitude/analytics-browser",
        "https://registry.npmjs.org/jwt-decode",
        "https://registry.npmjs.org/next",
        "https://registry.npmjs.org/@nrwl/next",
        "https://registry.npmjs.org/@tiptap/extension-placeholder",
        "https://registry.npmjs.org/@braze/web-sdk",
        "https://registry.npmjs.org/@tiptap/starter-kit",
        "https://registry.npmjs.org/logrocket",
        "https://registry.npmjs.org/@floating-ui/react-dom-interactions",
        "https://registry.npmjs.org/@tiptap/extension-highlight",
        "https://registry.npmjs.org/tailwind-scrollbar-hide",
        "https://registry.npmjs.org/canvas",
        "https://registry.npmjs.org/@tiptap/extension-underline",
        "https://registry.npmjs.org/create-react-app",
        "https://registry.npmjs.org/react-resizable",
        "https://registry.npmjs.org/@headlessui/react",
        "https://registry.npmjs.org/axios",
        "https://registry.npmjs.org/framer-motion",
        "https://registry.npmjs.org/core-js",
        "https://registry.npmjs.org/@types/uuid",
        "https://registry.npmjs.org/tailwind-merge",
        "https://registry.npmjs.org/firebase",
        "https://registry.npmjs.org/react-use",
        "https://registry.npmjs.org/sentence-splitter",
        "https://registry.npmjs.org/prosemirror-commands",
        "https://registry.npmjs.org/react-is",
        "https://registry.npmjs.org/react-cookie",
        "https://registry.npmjs.org/prosemirror-keymap",
        "https://registry.npmjs.org/allure-playwright",
        "https://registry.npmjs.org/tslib",
        "https://registry.npmjs.org/@floating-ui/react-dom",
        "https://registry.npmjs.org/@types/react-lottie",
        "https://registry.npmjs.org/prosemirror",
        "https://registry.npmjs.org/react",
        "https://registry.npmjs.org/stackdriver-errors-js",
        "https://registry.npmjs.org/playwright",
        "https://registry.npmjs.org/@storybook/core-server",
        "https://registry.npmjs.org/@types/intercom-web",
        "https://registry.npmjs.org/react-query",
        "https://registry.npmjs.org/react-error-boundary",
        "https://registry.npmjs.org/react-textarea-autosize",
        "https://registry.npmjs.org/node-pre-gyp",
        "https://registry.npmjs.org/regenerator-runtime",
        "https://registry.npmjs.org/crypto-js",
        "https://registry.npmjs.org/prosemirror-history",
        "https://registry.npmjs.org/lodash-es",
        "https://registry.npmjs.org/react-lottie",
        "https://registry.npmjs.org/uuid",
        "https://registry.npmjs.org/prosemirror-gapcursor",
        "https://registry.npmjs.org/react-joyride",
        "https://registry.npmjs.org/react-hotkeys-hook",
        "https://registry.npmjs.org/ua-parser-js",
        "https://registry.npmjs.org/charenc",
        "https://registry.npmjs.org/crypt",
        "https://registry.npmjs.org/is-buffer",
        "https://registry.npmjs.org/allure-js-commons",
        "https://registry.npmjs.org/proxy-from-env",
        "https://registry.npmjs.org/follow-redirects",
        "https://registry.npmjs.org/form-data",
        "https://registry.npmjs.org/scheduler",
        "https://registry.npmjs.org/loose-envify",
        "https://registry.npmjs.org/is-odd",
        "https://registry.npmjs.org/node-fetch",
        "https://registry.npmjs.org/properties",
        "https://registry.npmjs.org/uuid",
        "https://registry.npmjs.org/@babel/runtime",
        "https://registry.npmjs.org/@mapbox/node-pre-gyp",
        "https://registry.npmjs.org/nan",
        "https://registry.npmjs.org/simple-get",
        "https://registry.npmjs.org/js-tokens",
        "https://registry.npmjs.org/prop-types",
        "https://registry.npmjs.org/react-draggable",
        "https://registry.npmjs.org/whatwg-url",
        "https://registry.npmjs.org/mime-types",
        "https://registry.npmjs.org/asynckit",
        "https://registry.npmjs.org/combined-stream",
        "https://registry.npmjs.org/rimraf",
        "https://registry.npmjs.org/needle",
        "https://registry.npmjs.org/npmlog",
        "https://registry.npmjs.org/detect-libc",
        "https://registry.npmjs.org/rc",
        "https://registry.npmjs.org/semver",
        "https://registry.npmjs.org/mkdirp",
        "https://registry.npmjs.org/npm-packlist",
        "https://registry.npmjs.org/nopt",
        "https://registry.npmjs.org/tar",
        "https://registry.npmjs.org/is-number",
        "https://registry.npmjs.org/object-assign",
        "https://registry.npmjs.org/loose-envify",
        "https://registry.npmjs.org/react-is",
        "https://registry.npmjs.org/webidl-conversions",
        "https://registry.npmjs.org/tr46",
        "https://registry.npmjs.org/glob",
        "https://registry.npmjs.org/kind-of",
        "https://registry.npmjs.org/broadcast-channel",
        "https://registry.npmjs.org/@babel/runtime",
        "https://registry.npmjs.org/match-sorter",
        "https://registry.npmjs.org/minimist",
        "https://registry.npmjs.org/ini",
        "https://registry.npmjs.org/strip-json-comments",
        "https://registry.npmjs.org/deep-extend",
        "https://registry.npmjs.org/fs-minipass",
        "https://registry.npmjs.org/minizlib",
        "https://registry.npmjs.org/mkdirp",
        "https://registry.npmjs.org/chownr",
        "https://registry.npmjs.org/yallist",
        "https://registry.npmjs.org/safe-buffer",
        "https://registry.npmjs.org/minipass",
        "https://registry.npmjs.org/delayed-stream",
        "https://registry.npmjs.org/osenv",
        "https://registry.npmjs.org/abbrev",
        "https://registry.npmjs.org/is-buffer",
        "https://registry.npmjs.org/mime-db",
        "https://registry.npmjs.org/gauge",
        "https://registry.npmjs.org/set-blocking",
        "https://registry.npmjs.org/are-we-there-yet",
        "https://registry.npmjs.org/console-control-strings",
        "https://registry.npmjs.org/minimist",
        "https://registry.npmjs.org/minimist",
        "https://registry.npmjs.org/fs.realpath",
        "https://registry.npmjs.org/inherits",
        "https://registry.npmjs.org/once",
        "https://registry.npmjs.org/inflight",
        "https://registry.npmjs.org/minimatch",
        "https://registry.npmjs.org/path-is-absolute",
        "https://registry.npmjs.org/npm-bundled",
        "https://registry.npmjs.org/ignore-walk",
        "https://registry.npmjs.org/npm-normalize-package-bin",
        "https://registry.npmjs.org/postcss",
        "https://registry.npmjs.org/use-sync-external-store",
        "https://registry.npmjs.org/@next/env",
        "https://registry.npmjs.org/@next/swc-android-arm64",
        "https://registry.npmjs.org/styled-jsx",
        "https://registry.npmjs.org/@next/swc-darwin-arm64",
        "https://registry.npmjs.org/@next/swc-linux-x64-musl",
        "https://registry.npmjs.org/@next/swc-win32-arm64-msvc",
        "https://registry.npmjs.org/@next/swc-linux-arm64-gnu",
        "https://registry.npmjs.org/@next/swc-win32-x64-msvc",
        "https://registry.npmjs.org/@next/swc-freebsd-x64",
        "https://registry.npmjs.org/@next/swc-android-arm-eabi",
        "https://registry.npmjs.org/@next/swc-darwin-x64",
        "https://registry.npmjs.org/@next/swc-linux-x64-gnu",
        "https://registry.npmjs.org/@next/swc-linux-arm-gnueabihf",
        "https://registry.npmjs.org/caniuse-lite",
        "https://registry.npmjs.org/@swc/helpers",
        "https://registry.npmjs.org/@next/swc-linux-arm64-musl",
        "https://registry.npmjs.org/@next/swc-win32-ia32-msvc",
        "https://registry.npmjs.org/os-homedir",
        "https://registry.npmjs.org/os-tmpdir",
        "https://registry.npmjs.org/minipass",
        "https://registry.npmjs.org/remove-accents",
        "https://registry.npmjs.org/strip-ansi",
        "https://registry.npmjs.org/console-control-strings",
        "https://registry.npmjs.org/has-unicode",
        "https://registry.npmjs.org/aproba",
        "https://registry.npmjs.org/signal-exit",
        "https://registry.npmjs.org/object-assign",
        "https://registry.npmjs.org/wide-align",
        "https://registry.npmjs.org/string-width",
        "https://registry.npmjs.org/wrappy",
        "https://registry.npmjs.org/wrappy",
        "https://registry.npmjs.org/ansi-regex",
        "https://registry.npmjs.org/brace-expansion",
        "https://registry.npmjs.org/balanced-match",
        "https://registry.npmjs.org/concat-map",
        "https://registry.npmjs.org/string-width",
        "https://registry.npmjs.org/is-fullwidth-code-point",
        "https://registry.npmjs.org/code-point-at",
        "https://registry.npmjs.org/strip-ansi",
        "https://registry.npmjs.org/nanoid",
        "https://registry.npmjs.org/picocolors",
        "https://registry.npmjs.org/source-map-js",
        "https://registry.npmjs.org/minimatch",
        "https://registry.npmjs.org/strip-ansi",
        "https://registry.npmjs.org/is-fullwidth-code-point",
        "https://registry.npmjs.org/emoji-regex",
        "https://registry.npmjs.org/ansi-regex",
        "https://registry.npmjs.org/number-is-nan",
        "https://registry.npmjs.org/prosemirror-model",
        "https://registry.npmjs.org/prosemirror-state",
        "https://registry.npmjs.org/prosemirror-transform",
        "https://registry.npmjs.org/screenfull",
        "https://registry.npmjs.org/throttle-debounce",
        "https://registry.npmjs.org/fast-shallow-equal",
        "https://registry.npmjs.org/react-universal-interface",
        "https://registry.npmjs.org/@types/js-cookie",
        "https://registry.npmjs.org/fast-deep-equal",
        "https://registry.npmjs.org/nano-css",
        "https://registry.npmjs.org/js-cookie",
        "https://registry.npmjs.org/ts-easing",
        "https://registry.npmjs.org/@xobotyi/scrollbar-width",
        "https://registry.npmjs.org/resize-observer-polyfill",
        "https://registry.npmjs.org/copy-to-clipboard",
        "https://registry.npmjs.org/set-harmonic-interval",
        "https://registry.npmjs.org/tslib",
        "https://registry.npmjs.org/object_values",
        "https://registry.npmjs.org/concat-stream",
        "https://registry.npmjs.org/@textlint/ast-node-types",
        "https://registry.npmjs.org/structured-source",
        "https://registry.npmjs.org/prosemirror-transform",
        "https://registry.npmjs.org/prosemirror-state",
        "https://registry.npmjs.org/prosemirror-model",
        "https://registry.npmjs.org/use-latest",
        "https://registry.npmjs.org/use-composed-ref",
        "https://registry.npmjs.org/@babel/runtime",
        "https://registry.npmjs.org/stacktrace-js",
        "https://registry.npmjs.org/prosemirror-transform",
        "https://registry.npmjs.org/prosemirror-state",
        "https://registry.npmjs.org/prosemirror-view",
        "https://registry.npmjs.org/lottie-web",
        "https://registry.npmjs.org/babel-runtime",
        "https://registry.npmjs.org/rope-sequence",
        "https://registry.npmjs.org/prosemirror-state",
        "https://registry.npmjs.org/prosemirror-transform",
        "https://registry.npmjs.org/hoist-non-react-statics",
        "https://registry.npmjs.org/universal-cookie",
        "https://registry.npmjs.org/@types/hoist-non-react-statics",
        "https://registry.npmjs.org/buffer-from",
        "https://registry.npmjs.org/inherits",
        "https://registry.npmjs.org/readable-stream",
        "https://registry.npmjs.org/typedarray",
        "https://registry.npmjs.org/prosemirror-keymap",
        "https://registry.npmjs.org/prosemirror-model",
        "https://registry.npmjs.org/prosemirror-state",
        "https://registry.npmjs.org/prosemirror-view",
        "https://registry.npmjs.org/prosemirror-state",
        "https://registry.npmjs.org/w3c-keyname",
        "https://registry.npmjs.org/is-lite",
        "https://registry.npmjs.org/scrollparent",
        "https://registry.npmjs.org/react-floater",
        "https://registry.npmjs.org/deepmerge",
        "https://registry.npmjs.org/tree-changes",
        "https://registry.npmjs.org/scroll",
        "https://registry.npmjs.org/prop-types",
        "https://registry.npmjs.org/exenv",
        "https://registry.npmjs.org/@emotion/is-prop-valid",
        "https://registry.npmjs.org/tslib",
        "https://registry.npmjs.org/react-is",
        "https://registry.npmjs.org/hotkeys-js",
        "https://registry.npmjs.org/toggle-selection",
        "https://registry.npmjs.org/prosemirror-state",
        "https://registry.npmjs.org/w3c-keyname",
        "https://registry.npmjs.org/fs-extra",
        "https://registry.npmjs.org/chalk",
        "https://registry.npmjs.org/cross-spawn",
        "https://registry.npmjs.org/hyperquest",
        "https://registry.npmjs.org/validate-npm-package-name",
        "https://registry.npmjs.org/commander",
        "https://registry.npmjs.org/prompts",
        "https://registry.npmjs.org/tmp",
        "https://registry.npmjs.org/tar-pack",
        "https://registry.npmjs.org/envinfo",
        "https://registry.npmjs.org/semver",
        "https://registry.npmjs.org/string_decoder",
        "https://registry.npmjs.org/util-deprecate",
        "https://registry.npmjs.org/ansi-styles",
        "https://registry.npmjs.org/supports-color",
        "https://registry.npmjs.org/once",
        "https://registry.npmjs.org/simple-concat",
        "https://registry.npmjs.org/decompress-response",
        "https://registry.npmjs.org/sisteransi",
        "https://registry.npmjs.org/kleur",
        "https://registry.npmjs.org/which",
        "https://registry.npmjs.org/path-key",
        "https://registry.npmjs.org/shebang-command",
        "https://registry.npmjs.org/debug",
        "https://registry.npmjs.org/iconv-lite",
        "https://registry.npmjs.org/sax",
        "https://registry.npmjs.org/rimraf",
        "https://registry.npmjs.org/hoist-non-react-statics",
        "https://registry.npmjs.org/@types/react",
        "https://registry.npmjs.org/builtins",
        "https://registry.npmjs.org/universalify",
        "https://registry.npmjs.org/graceful-fs",
        "https://registry.npmjs.org/jsonfile",
        "https://registry.npmjs.org/has-flag",
        "https://registry.npmjs.org/clsx",
        "https://registry.npmjs.org/color-convert",
        "https://registry.npmjs.org/lru-cache",
        "https://registry.npmjs.org/mimic-response",
        "https://registry.npmjs.org/shebang-regex",
        "https://registry.npmjs.org/isexe",
        "https://registry.npmjs.org/oblivious-set",
        "https://registry.npmjs.org/microseconds",
        "https://registry.npmjs.org/nano-time",
        "https://registry.npmjs.org/detect-node",
        "https://registry.npmjs.org/js-sha3",
        "https://registry.npmjs.org/unload",
        "https://registry.npmjs.org/rimraf",
        "https://registry.npmjs.org/@babel/runtime",
        "https://registry.npmjs.org/ms",
        "https://registry.npmjs.org/yallist",
        "https://registry.npmjs.org/safe-buffer",
        "https://registry.npmjs.org/safer-buffer",
        "https://registry.npmjs.org/react-is",
        "https://registry.npmjs.org/safe-buffer",
        "https://registry.npmjs.org/minipass",
        "https://registry.npmjs.org/color-name",
        "https://registry.npmjs.org/delegates",
        "https://registry.npmjs.org/readable-stream",
        "https://registry.npmjs.org/csstype",
        "https://registry.npmjs.org/@types/prop-types",
        "https://registry.npmjs.org/@types/scheduler",
        "https://registry.npmjs.org/playwright-core",
        "https://registry.npmjs.org/graceful-fs",
        "https://registry.npmjs.org/core-util-is",
        "https://registry.npmjs.org/isarray",
        "https://registry.npmjs.org/inherits",
        "https://registry.npmjs.org/safe-buffer",
        "https://registry.npmjs.org/util-deprecate",
        "https://registry.npmjs.org/string_decoder",
        "https://registry.npmjs.org/process-nextick-args",
        "https://registry.npmjs.org/yallist",
        "https://registry.npmjs.org/@emotion/memoize",
        "https://registry.npmjs.org/@firebase/remote-config-compat",
        "https://registry.npmjs.org/@firebase/database-compat",
        "https://registry.npmjs.org/@firebase/installations",
        "https://registry.npmjs.org/@firebase/app",
        "https://registry.npmjs.org/@firebase/firestore",
        "https://registry.npmjs.org/@firebase/storage",
        "https://registry.npmjs.org/@firebase/performance",
        "https://registry.npmjs.org/@firebase/app-types",
        "https://registry.npmjs.org/@firebase/storage-compat",
        "https://registry.npmjs.org/@firebase/messaging-compat",
        "https://registry.npmjs.org/@firebase/functions-compat",
        "https://registry.npmjs.org/@firebase/messaging",
        "https://registry.npmjs.org/@firebase/remote-config",
        "https://registry.npmjs.org/@firebase/auth-compat",
        "https://registry.npmjs.org/@firebase/analytics-compat",
        "https://registry.npmjs.org/@firebase/app-check-compat",
        "https://registry.npmjs.org/@firebase/analytics",
        "https://registry.npmjs.org/@firebase/util",
        "https://registry.npmjs.org/@firebase/database",
        "https://registry.npmjs.org/@firebase/auth",
        "https://registry.npmjs.org/@firebase/firestore-compat",
        "https://registry.npmjs.org/@firebase/performance-compat",
        "https://registry.npmjs.org/@firebase/app-check",
        "https://registry.npmjs.org/@firebase/functions",
        "https://registry.npmjs.org/@firebase/installations-compat",
        "https://registry.npmjs.org/@firebase/app-compat",
        "https://registry.npmjs.org/safe-buffer",
        "https://registry.npmjs.org/@gilbarbara/deep-equal",
        "https://registry.npmjs.org/is-lite",
        "https://registry.npmjs.org/regenerator-runtime",
        "https://registry.npmjs.org/core-js",
        "https://registry.npmjs.org/use-isomorphic-layout-effect",
        "https://registry.npmjs.org/aria-hidden",
        "https://registry.npmjs.org/@floating-ui/react-dom",
        "https://registry.npmjs.org/prosemirror-model",
        "https://registry.npmjs.org/boundary",
        "https://registry.npmjs.org/prosemirror-view",
        "https://registry.npmjs.org/prosemirror-model",
        "https://registry.npmjs.org/prosemirror-view",
        "https://registry.npmjs.org/prosemirror-model"];

What state are the sockets left in? Are they idle in the Client pool? Are they waiting in the FuturesUnordered? Waiting to drain the response body? Perhaps enabling some logging will help identify that.


[WIP]Added EC2 building and termination

This PR add the functionality of creating and terminating a EC2 instance.

Needs Testing


CollisionShape2D trigger doesn't behave as expected

Operating system or device:
OSX  10.10.3
Godot 2.0.2 stable official
Issue description (what happened, and what was expected):
One moving KinematicBody2D with a shape set as trigger doesn't collide with other KinematicBody2D.
According to the documentation:

A trigger shape detects collisions, but is otherwise unaffected by physics (i.e. will not block movement of colliding objects).

I expect to detect the collision in the script but the body wouldn't stop its movement. What happens is that  the is_colliding() doesn't return true when the two bodies overlaps and no collision is detected
Steps to reproduce:
See minimal example
Link to minimal example project (optional but very welcome):
https://github.com/genete/triggerbug

KinematicBody2D.is_colliding() must return true only when a collision is detected (therefore stopping the body movement), this way you can fix the movement to avoid getting stuck. Check: http://docs.godotengine.org/en/latest/tutorials/2d/kinematic_character_2d.html#problem
Is there a reason not to use an Area2D inside your kinematic body? The only reason I find to use a trigger shape with a KinematicBody2D (supposing the shape must have a different size than the collidable shape) is to make Area2D trigger body_enter and body_exit, or to temporally disable that shape.

Hi nelkeq, thanks for comment.
Please let me quote you:

KinematicBody2D.is_colliding() must return true only when a collision is detected (therefore stopping the body movement), this way you can fix the movement to avoid getting stuck.

and quote again what documentation says:

A trigger shape detects collisions, but is otherwise unaffected by physics (i.e. will not block movement of colliding objects).

I conclude:

If a Kinematic body's collision shape is a trigger the body must detect collision ("A trigger shape detects collision") and therefore as it is not affected by physics it wouldn't stop its movement.

The second part happens (it is not affected by physics) but the first part doesn't (it doesn't detect a collision). So it is a bug or documentation must be updated.
Moreover, can anyone show me an example of trigger with a PhisicsBody2D?

Is there a reason not to use an Area2D inside your kinematic body?

There isn't. I'm using it for other purposes.

The only reason I find to use a trigger shape with a KinematicBody2D (supposing the shape must have a different size than the collidable shape) is to make Area2D trigger body_enter and body_exit, or to temporally disable that shape.

In both cases trigger just disables the shape. Why not call it just set_disabled()?

The documentation can always be changed to make it clearer.

A trigger shape detects collisions

This means it will emit the signals body_enter and body_exit (in case of Area2D and RigidBody2D).

but is otherwise unaffected by physics (i.e. will not block movement of colliding objects)

Kinematic.is_colliding() must return true only if the movement was blocked, because it's used to slide the remaining motion with the collision normal to avoid the body getting stuck.
KinematicBody2D does not have the signals body_enter and body_exit so as I said, you may only want to have trigger shapes on it is when these shapes are different from the colliding shapes and you don't want it to collide with other bodies but you still want other Area2D to trigger body_enter when collided.
Maybe what you are looking for are these signals in KinematicBody2D, but you can already achieve what you are looking for by using Area2D.
BTW, triggers are better explained here: http://docs.godotengine.org/en/latest/tutorials/2d/physics_introduction.html#triggers

BTW, triggers are better explained here: http://docs.godotengine.org/en/latest/tutorials/2d/physics_introduction.html#triggers

A CollisionShape2D or CollisionPolygon2D can be set as a trigger. When used in a RigidBody2D or KinematicBody2D...

Precisely another documentation mistake (or code bug)

Thanks again for reply again.
My conclusion is that trigger use is:

Temporarily disable collisions (physics behavior) for that shape.
Allow Area2D trigger body_enter(), etc. for its shape, without being stopped by other surrounding colliding shapes.

One triggered shape won't send physics behavior to its PhysicsBody holder neither would send any collision information to it. A triggered shape is like disabled for the physics body it is inside, but it  is visible for Area2D from the point of view of its signals body enter, etc.

This is no longer relevant since 3.0, as the trigger property was apparently removed.


Added calls to prepare() to ensure requirement checks are done early

This PR tries to deal with the fact that dependency checks were not performed early enough , and when running examples with required installed packages returned  "module was not found" errors.
However, there seems to be a problem with installing ibm_watsonx_ai  required for building inference engines.

@elronbandel - the problem is that watsonx_ai requires python 3.10.  What do you suggest we do?


Expose API for resizing image caches

Continuation of https://github.com/flutter/flutter/pull/31164
Description
This PR creates a new image provider ResizedImage that allows the user to specify the dimensions of the image that the engine can then use to resize to. This is the engine side PR accounting for the same changes: flutter/engine#8596
Related Issues
#26194

cc @iskakaushik just FYI, I am continuing your work here.

cc @Hixie I was told that the current primary concern with this change is the addition of {int targetWidth, int targetHeight} to image provider will break people who override the image provider.
I feel like this is an acceptable and minimal breakage (pending public opinion of course) and the benefits of this functionality outweigh the breakage. Thoughts?

maybe i missed it but i didn't see any tests of the resizeWidth/resizeHeight arguments

cc @Hixie I was told that the current primary concern with this change is the addition of {int targetWidth, int targetHeight} to image provider will break people who override the image provider.
I feel like this is an acceptable and minimal breakage (pending public opinion of course) and the benefits of this functionality outweigh the breakage. Thoughts?

Would this be a breaking change then?

Yes, but the exact API hasn't been locked down yet, so have not sent the mail out describing it yet.

The API won't be locked down when you send the e-mail, the whole point of the e-mail is to ask for feedback on the API so that you can change it in response to people's feedback. :-)

For reference, the breaking change announcement sent:

If you do not have a custom implementation of ImageProvider, this change will not impact you.
Change
The following breaking change is proposed as part of https://github.com/flutter/flutter/pull/41415 to add the capability to decode images to a specified size in order to reduce ImageCache memory usage.
ImageProvider.load will take an additional positional parameter DecoderCallback decode
The new signature is:
ImageStreamCompleter load(T key, DecoderCallback decode)
where DecodeCallback is:
typedef DecoderCallback = Future<ui.Codec> Function(Uint8List bytes, {int cacheWidth, int cacheHeight});
Justification
This change is to provide a way to pass the cacheWidth and cacheHeight values into a load call without redundantly making all ImageProviders directly know about these parameters when it is irrelevant. ResizeImage supplies the values through a closure.
Overall, this change allows fine control of the decoded and cached sizes of images.
Migration
Full migration is recommended, however, If you wish your code to simply work as before with no support for ResizeImage, simply add DecoderCallback decode to the load signature.
Full migration will require you to call the decode callback in place of PaintingBinding.instance.instantiateImageCodec()

This PRs forced plugins to choose whether to support master or stable, as a result users of the cached_network_image plugin were broken when this change got released to stable (reference). That is despite the fact that the plugin author noticed this breaking change, and even staged a fix, they just couldn't publish it before stable was released (note by plugin author).
Ideally this class of issues would be mitigated by running a wide suite of plugins tests on framework PRs, until then we need to pay attention and land such changes in a phased way.
@GaryQian @Hixie


VSCode v1.71.0 in Ubuntu the button "Click to select a folder" stopped working

After the update to VSCode v 1.71.0 in Linux, the button "Click to select a folder" stopped working and there is no way to add a folder for comparison.
https://imgur.com/9ponMjg

Can you check my fix please?
compare-folders-0.22.3.vsix.zip

The fix works (downloaded the zipfile from the link above).
Thanks for the quick response Mosh!

Thank you @Zvika88 for verifing!

Deployed


Update RankLLM with new rerankers

Description
Fixes issues in llama-index-postprocessor-rankllm-rerank due to refactoring changes within RankLLM.
Adds new availability for new rerankers!

LiT5 Distill
LiT5 Score
MonoT5 (pointwise reranker)
RankZephyr and RankVicuna variants
window_size and batch_size tuning parameters for listwise and pointwise reranking, respectively

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[x] Yes
[ ]

Type of Change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

Waiting for rank_llm pypi to be patched with fixes

hey @logan-markewich, the pipeline is passing except for the Python 3.9 test since RankLLM requires python>=3.10.
I'm trying to see if we can get the version requirement down to 3.9. If we can't however, what would be the available options?

@xpbowler we can disable tests for 3.9 (and set the minimum version for the integration package to 3.10) if we want -- does that sound good to you?

@xpbowler we can disable tests for 3.9 (and set the minimum version for the integration package to 3.10) if we want -- does that sound good to you?

Yep, sounds good. Thank you!

@logan-markewich how would I disable tests for python 3.9?

@xpbowler whoops, I meant to do that, just pushed


Added properties to PipelineQueryOptions.

Codecov Report

Merging #124 into master will decrease coverage by 0.28%.
The diff coverage is 35.29%.

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   71.06%   70.77%   -0.29%
==========================================
  Files         151      151
  Lines        2139     2156      +17
==========================================
+ Hits         1520     1526       +6
- Misses        619      630      +11

Impacted Files
Coverage Δ

...abApiClient/Models/Pipelines/Responses/Pipeline.cs
0% <0%> (ø)
:arrow_up:

.../Models/Pipelines/Requests/PipelineQueryOptions.cs
100% <100%> (ø)
:arrow_up:

.../Models/Pipelines/Requests/PipelineQueryBuilder.cs
77.08% <25%> (-17.37%)
:arrow_down:


Revert "Add configurable exit grace periods and shutdown handlers"

This reverts commit 3045a379aa76ce9ee930f427daa4ee799b0162aa.

Looks right but no need to fire the missiles until we've confirmed that we can implement the requested Google-internal feature without it.

@nathanielmanistaatgoogle I think we can revert this change at this point.

Flakes:
https://github.com/grpc/grpc/issues/9093


Request to include KOKKOS accelerator package in DeePMD Lammps library

I have been actively using DeePMD-kit package in my research. I want to run Lammps with GPUs. The Lammps executable shipped with DeePMD (GPU version) from conda channel is built without any accelerators (GPU). I request to include KOKKOS accelerator package additionally.

We've decided to deprecate the official deepmodeling conda channel. Future versions will use conda-forge packages directly, i.e. https://github.com/conda-forge/lammps-feedstock


Fix typos and improve readability in README.md

This pull request includes minor corrections to spelling errors in the README.md file to improve readability and accuracy.

README.md: Corrected the spelling of "seperate" to "separate" in the section about using a leading comma in the SELECT clause.
README.md: Corrected the spelling of "revisted" to "revisited" in the section about using common table expressions (CTEs) for complex queries.

Thanks again! ❤


Many-to-many relationships without an entity class to represent the join table.

In Entity Framework 6.x, we can configure many-to-many relationships without an entity class to represent the join table but in EF Core we cannot do that yet( 2.1).
My question is when this EF 6.x feature will be imported in EF Core?
Thank you.

Planned for 3.0: https://github.com/aspnet/EntityFrameworkCore/issues/10508


mWeb - After sending an invoice to a new user, it gets changed to some other user after a few minutes

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Action Performed:
Pre-condition: Login with gmail account

Go to https://staging.new.expensify.com/home
Tap fab -- send invoice
Enter an amount and tap continue
Select a new user
Tap send invoice
Wait for few seconds, when header changes to hidden, tap on invited contact
Tap message user
Note email not found error
Navigate back to send invoice page and pin it
Navigate to LHN and open the report after few seconds
Open the report and wait few seconds

Expected Result:
After sending an invoice to a new user, it doesn't get changed to some other user after a few minutes
Actual Result:
After sending an invoice to a new user, it gets changed to some other user after a few minutes
Workaround:
n/a
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/1538b8fc-3eab-4170-9719-82d2a77770a1
View all open jobs on GitHub

We think that this bug might be related to #wave-collect - Release 1

I can't reproduce this and the other errors that are described in the pre-requisite steps are reproducible in prod:

Removing the label

@cristipaval Do you know about the error here?

@cristipaval quick bump on the above!

Sweeeeet! No worries at all. Closing this out!


Error 429

hi there,
have several errors in the log regarding error 429
024-08-27 19:11:21.080 ERROR (SyncWorker_37) [weconnect_cupra] Could not fetch data. Status Code was: 429

2024-08-27 20:18:07.167 ERROR (MainThread) [custom_components.cupra_we_connect] Unknown error while updating weconnect_cupra
Traceback (most recent call last):
  File "/config/custom_components/cupra_we_connect/__init__.py", line 52, in async_update_data
    await asyncio.wait_for(
  File "/usr/local/lib/python3.12/asyncio/tasks.py", line 520, in wait_for
    return await fut
           ^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/site-packages/weconnect_cupra/weconnect_cupra.py", line 176, in update
    self.__api.update(updateCapabilities=updateCapabilities, updatePictures=updatePictures, force=force, selective=selective)
  File "/usr/local/lib/python3.12/site-packages/weconnect_cupra/api/cupra/api.py", line 39, in update
    self.updateVehicles(updateCapabilities=updateCapabilities, updatePictures=updatePictures, force=force, selective=selective)
  File "/usr/local/lib/python3.12/site-packages/weconnect_cupra/api/cupra/api.py", line 67, in updateVehicles
    self.__vehicles[vin].update(
  File "/usr/local/lib/python3.12/site-packages/weconnect_cupra/api/cupra/elements/vehicle.py", line 207, in update
    self.updateStatus(updateCapabilities=updateCapabilities, force=force, selective=selective)
  File "/usr/local/lib/python3.12/site-packages/weconnect_cupra/api/cupra/elements/vehicle.py", line 237, in updateStatus
    'windowHeatingStatus': (WindowHeatingStatus, climatization_status_dict['windowHeatingStatus']),
                                                 ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'windowHeatingStatus'

2024-08-27 20:54:35.817 ERROR (SyncWorker_42) [weconnect_cupra] Failed to retrieve data for VIN VSS: Could not fetch data. Status Code was: 429
2024-08-27 20:54:35.817 ERROR (SyncWorker_42) [weconnect_cupra] Could not fetch data. Status Code was: 429

what is wrong / what do i wring?
thanks a lot and regards
Daniel

Hello,
I experienced the same issue yesterday, with the official app also being blocked. To resolve it, I had to disable my integration and wait a couple of hours for the API to reauthorize.
This issue might be linked to the interval setting, which could be too aggressive:
https://github.com/daernsinstantfortress/cupra_we_connect/blob/036cb68380fff288a1c240084bde0569456f221d/custom_components/cupra_we_connect/__init__.py#L80
I modified my integration today to use a longer interval (1 hour). I'll let you know if this adjustment resolves the issue.


custom_partitioning doesn't work with plugins

This is a problem as pip install jax[cuda12] uses the plugin API for cuda.
Nvidia depends heavily on custom_partitioning. So before we make the plugin cuda the default way of installation, this needs to be fixed.

With https://github.com/openxla/xla/pull/8655, https://github.com/openxla/xla/commit/3c8260f614901f5cf2dd81530e009db8e6c9789b, and https://github.com/google/jax/pull/20378, custom_partitioning should work with the cuda plugin now.


Add end to end solo machine tests

Summary
an end to end solo machine test would have caught #119. It would be great if we could utilize v2 of the testing package to quickly write integration tests

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged/assigned

@colin-axner Can this issue be considered done with the tests added as part of the 02-client refactor?

Yup!


cljs handlers

Hi, are there any handlers example to make the tagged values here work when reading from transit-cljs or transit-clj?
I expected that it would work without any extra configurations.. isn't usefull to have an example of reading immutable-js data to cljs/clj data?
thanks for any help!

Hrm, I chose different tags for the immutable types so as not to conflict, but it should be possible to match them up with what clojure would produce.
I don't have any time to look into this, but if you get something working then please do post it back here.
If you have a look at the source of this module, and compare the serialised outputs, you'll need to adjust the tags to match - or perhaps configure the default list/map types in transit to use immutable's


sky.ColorFilter needs operator==

 Issue by Hixie
Thursday Jul 16, 2015 at 22:25 GMT
Originally opened as https://github.com/flutter/engine/issues/25

From @abarth on July 15, 2015 19:7
When someone sets a sky.ColorFilter on either a ColorFilter widget or on an Image widget, we call operator== to check whether the filter has changed.  If it has changed, we mark ourselves as needing paint.  However, sky.ColorFilter doesn't implement operator==, which means we're just getting object identity, which means we're invalidating paint more often than necessary.
/cc @mpcomplete
Copied from original issue: domokit/mojo#324

 Comment by Hixie
Monday Oct 26, 2015 at 05:05 GMT

@abarth You said you were planning on changing how this works so that ColorFilter would be a pure Dart class, right? With the data sent over to the C++ in an efficient manner at the last minute?

 Comment by Hixie
Thursday Jul 16, 2015 at 22:25 GMT

From @eseidel on July 16, 2015 4:19
Would be nice to be able to catch these errors in some way.  In obj-c one could override -[NSObject equals:] to warn using a "category".  I know dart doesn't have those, but maybe there is another solution we should use.

 Comment by abarth
Monday Oct 26, 2015 at 05:24 GMT

That's right.  The steps are:

[ ] Start using the new binding system for window, replacing view.
[ ] Switch the Canvas interface over to the new bindings system.
[ ] Lift Paint-related classes up into Dart using the new bindings system.

It looks like ColorFilter is still a wrapped native:
https://github.com/flutter/engine/blob/master/sky/engine/core/painting/ColorFilter.h

Fixed!


PR: Refactoring of solinst readers

The goal is to remove an extra layer of code that was present for the Solinst readers by adding a new function read_solinst_file that returns a Solinst reader object appropriate to the given file type.
This is the strategy that is used by many packages, such as Pandas, so I guess this is not going to be too much confusing.
This should make the code easier to understand and make the maintenance and development of the Solinst readers easier by making the inheritance tree a little bit cleaner and easier to follow.

Hello @jnsebgosselin! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file hydsensread/file_reader/compagny_file_reader/solinst_file_reader.py:

Line 427:1: W391 blank line at end of file


Add local parser building functionality

This PR will make it possible for users to build TS grammars locally with no external CLI dependencies, which is a big win for making that an accessible option for users.
A couple points of discussion:

Pulling in tree-sitter-cli brings in a non-trivial amount of unrelated cli-based dependencies in order to use it's tree-sitter generate functionality. Do we think it's worth it?
Building a parser takes about 3s on my machine, more so if we're generating as well. Do we want to consider some sort of asynchronous build option?

I'm open to any and all changes in order to make this PR easier to merge/ fit better with the codebase!
If/when this gets merged, we'd likely also want to rework tree-sitter-langs to use this function.

@ubolonton there appears to be a regression with windows CI unrelated to this PR, tested with an empty commit here: https://github.com/emacs-tree-sitter/elisp-tree-sitter/pull/221

Windows CI used to pin Emacs version, but no longer does, after this supposedly temporary change.
This likely means the test hl::face-mapping fails on Emacs 28.


[Suggestion] Effects for changing keyboard layout

It would be nice to be able to automatically change the color of the keys depending on the current keyboard layout.

Can you elaborate? Users would typically have one keyboard and with one localization layout.

Users with non-latin native language typically have two layouts, one for english, and one for their native language. Cyrillic users, for example (russia/ukraine/belarus/etc.), asian users.


Fixing bug in item view count

What is the problem to solve?
Current definition for items viewed is returning odd results
What stage of research is it? (discovery/general usability testing/post release)
post release
What are the objectives?
identify which aspects the definition is getting wrong
What research technique is required?
Kibana

First page of Popular items viewed for last 2 weeks is currently:

Definition used is:
(page.name:item or page.name:image)
and
(page.query.canvas.number:1 or NOT page.query.canvas.number:*)
and
NOT (source:viewer/paginator)
Metrics: unique count of anonymousId
Buckets: page.query.workId.keyword

Issue with definition is that it misses off images viewed after viewing the works page

Looking at this again, the original definition is correct. Note: for page.name:image, NOT page.query.id : page.query.workId


Update schemas to enforce the difference between v2.0 packages and v3.0 packages

If a package publisher wants to take advantage of v3.0 package features they will have to set the packagingVersion to 3.0 in their package.json

@jsancio Please review

LGTM! :ship: it


Bug: When supplying both priv_k and pub_k to Keys(), it returns KeyError

Thanks for developing this!
It really helped me understand NIPS and nostr!
I may have found a small bug:
Here is a sample snippet to reproduce the bug:
from monstr import Keys

first = Keys()

second = Keys(priv_k=first.private_key_hex(), pub_k=first.public_key_hex())
## Throws exception here

I believe the error is in this line: https://github.com/monty888/monstr/blob/master/src/monstr/encrypt.py#L154
I think the intent was to access k_pair['pub_k'], not k_pair[pub_k].

Thanks, yes that was the error now fixed


[2024a]  sync 2024a branch with main branch

[2024a]  sync 2024a branch with main branch
Include upgrade of odh-elyra-3.16.4
How Has This Been Tested?

NA
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Merging to get the build ready.


1896 fetching other collections from preview

Summary
Allowing users to access data from other collections whilst in the preview pane.
See the comments here: https://github.com/netlify/netlify-cms/issues/1896
This is my first time contributing to this repo, so I'm not 100% across the code base, so feedback is welcome.
I've tested this on a project I am working on at the moment and it worked as expected:

I was able to pull in all posts to a listing page
I was able to render the header and footer which are separate collections on every page

Checklist
Please add a x inside each checkbox:

[x] I have read the contribution guidelines.
[x] Code is formatted via running yarn format.
[x] Tests are passing via running yarn test.
[x] The status checks are successful (continuous integration). Those can be seen below.

Would love to see this feature in Netlify CMS. Anyone from the team interested in taking a look?

This would be a great feature.

@cdennington are you still interested in moving this forward?

@martinjagodic I'd happily be involved in pushing this one out, what do you need from me? Other than fixing conflicts

@cdennington great. Please solve conflicts first and then we will review. Thanks!

@cdennington linter is failing. Please run npm run lint locally to see the problem.

@martinjagodic, cdennington didn't have the time to finish this, so I took over.
With the docs moving to a different repo, I guess I should just make a seperate pull request there to add the docs for this?

With the docs moving to a different repo, I guess I should just make a seperate pull request there to add the docs for this?

Yes please

I added a pull request for the documentation (written by @cdennington) here: https://github.com/decaporg/decap-website/pull/55.
Not sure why the macos build is failing, it seems to get stuck installing dependencies. No changes have been made to those.

This is great @Boelensman1, MacOS build is a bit cranky sometimes, don't worry about it :)
Left you one little question otherwise this is good to go and can be released today/tomorrow with a few other PRs.


Merging causes problems with WI redirects

Collections & Research staff report that Sierra records they edited (fields: 245, 246 1 and 500) lost their images on wc.org after their Sierra edit. None of those fields are links to the image.
For example:
http://libsys.wellcomelibrary.org/record=b1187988
You can see the thumbnail on the record, but when you click it you get "We couldn't find anything that matched V0039617. Please try again."
https://wellcomecollection.org/works?query=V0039617&wellcomeImagesUrl=/indexplus/image/V0039617.html
You can find the record on wc.org by searching for the title, but there is no associated image.
https://wellcomecollection.org/works?query=A young woman stands with a sheep by her side
More of those affected records (these are a few they've given me, there are more still):
30148i - http://libsys.wellcomelibrary.org/record=b1187988
32518i - http://libsys.wellcomelibrary.org/record=b1190388
32532i - http://libsys.wellcomelibrary.org/record=b1190369
32536i - http://libsys.wellcomelibrary.org/record=b1190373
32542i - http://libsys.wellcomelibrary.org/record=b1190379
32546i - http://libsys.wellcomelibrary.org/record=b1190383
32549i - http://libsys.wellcomelibrary.org/record=b1190386
32625i - http://libsys.wellcomelibrary.org/record=b1190462

It looks like the toggle 'Entire catalogue search' needs to be on, I presume C&R are using it or they wouldn't see the wc.org record with no image.

Looking into this, what seems to be happening is the redirect for the Miro work is bring created but the identifier for that work is not being added to the target.
🔍 continues.

Looking at the marc data of all of these (e.g) - there is data like (OCoLC)808200303 in the 035 field.
Currently we just assume that 035 will be a calm identifier, which is wrong. This was causing the merger not to work properly.
Fixing that should help.


Potato cannon

Describe the Bug
The problem is that when you shoot potatoes or other food, you can't see potatoes or food flying in the air, because of this it's not convenient to use potato cannon
Reproduction Steps
I launched only the mod itself and its dependencies (fabric api), launched minecraft without resource packs, created a new world, took a potato cannon and potatoes, fired a shot, but it is not visible how the potato flies out, it is invisible
Expected Result
It was expected that the potato would be visible when fired from the potato cannon
Screenshots and Videos
No response
Crash Report or Log
No response
Operating System
Windows 7
Mod Version
0.5.1f
Minecraft Version
1.20.1
Other Mods
fabric api 0.91.0
Additional Context
No response

I can confirm this issue. Wanted to take down the ender dragon with potato cannon. Can't see the projectiles at all.

can reproduce on dev branches


swipe gesture of swipeable filter view works weird on iOS 10 betas

On iOS 10 betas, the swipe gesture of swipeablefilterview works very choppy, without any swipe transition at all.

I don't seem to be experiencing this in IOS 10 Beta 4, could you confirm that when testing on the latest version of IOS 9 this issues doesn't occur?

It works okay on iOS 9.3.4, but not on iOS 10 Beta 5 (Public beta 4)

Are you able to upload an example project with the issue? I'll take a look at it.

I've enabled 'showsHorizontalScrollIndicator' option in SCSwipeableFilterView.m to see what's the reason behind it. Turns out, the scrollView works okay as the scroll bar moves as you drag. However, the filter overlay doesn't follow the offset until it reaches the drag end point.
I've implemented in a very basic way.
_filterSwitcherView = [[SCSwipeableFilterView alloc] initWithFrame:CGRectMake(0,0, self.view.frame.size.width, self.view.frame.size.height)];
_filterSwitcherView.scaleAndResizeCIImageAutomatically = YES;
_filterSwitcherView.contentMode = UIViewContentModeScaleAspectFill;
[_filterSwitcherView setImageByUIImage:image];
[_filterSwitcherView setClipsToBounds:YES];
[self.view addSubview:_filterSwitcherView];
_filterSwitcherView.filters = @[
                                [SCFilter emptyFilter],
                                [SCFilter filterWithCIFilterName:@"CIPhotoEffectNoir"],
                                [SCFilter filterWithCIFilterName:@"CIPhotoEffectChrome"],
                                [SCFilter filterWithCIFilterName:@"CIPhotoEffectInstant"],
                                [SCFilter filterWithCIFilterName:@"CIPhotoEffectTonal"],
                                [SCFilter filterWithCIFilterName:@"CIPhotoEffectFade"]
                                ];

This still happens on the latest iOS 10 beta 6 (Public beta 5).

This seems like a bug of contentOffset codes in scrollViewDidScroll. Anyone has any solution or idea about this issue?

I found out that iOS default CIFilters are causing the issue. Custom filters are working OK.

Can confirm I am having this problem too, it looks to only be linked to the CIPhotoEffect filters, the swipe view works fine for other iOS default filters like CISepiaTone, etc that don't have "PhotoEffect" in the name.
Anyone have any luck with this? iOS 10

I can confirm this happens on Custom Filters as well. I had some LUTs which I have used as CIFilters and faced the same issue. Is there any fix or workaround for this?

Any luck with this problem?

@sulamatraore Creating Luts with CoreImageShop and then using them with SCRecorder fixed the issue for me!

@mayuur Thanks!

I dug into this and it seems to be a bug with Core Image. Specifically https://github.com/rFlex/SCRecorder/blob/master/Library/Sources/SCSwipeableFilterView.m#L178 where we call [CIImage imageByCroppingToRect:] and then [CIImage imageByCompositingOverImage:] doesn't work with some filters.

Is there any solution for this problem? The filter swipe action is working in iOS 9, but not in iOS 10.

Unfortunately, the swipe action only works when you create custom filters instead of using the CI Effects provided by Apple. You can create these custom filters by using CoreImageShop


Fix fmt deprecation for ember 2 +

Just replaced Ember.string.fmt() with a simple .replace() since only one argument is guaranteed to be present.
Copy of this: https://github.com/iStefo/ember-select-2/pull/127

:+1:

:+1:


Add Spanish Braille

According to Wikipedia, Spanish braille is similar to French braille and Portuguese braille, and has several related versions for various subregions. Implementing this would be a good start for them.
Resources:

In Spanish, PDF documentation from ONCE. I did manage to translate it to English, but it messed up the display of the tables showing the braille, so that wasn't very useful. It doesn't have that many math chars listed and what is listed isn't in a good form to convert to what's needed for MathCAT's unicode.yaml file.
In es-chardefs.cti, Liblious has a table  of ~150 chars  in a form that is convertible.

Update: this is mostly done in the cmu branch. It needs many more characters to be added to make it truely useful.


Generate errors on invalid values

eg Nitrogen: <0 or >10000

Tests are in place now
d63bc46803aabdb1fae0864922f6c0a15971430a

Regarding the tests for the groundwater levels:
I recently had the case  inputarray.mlw = inputarray.msw +1 cm for 3 pixels out of more than 80000, quite clearly a rounding error
Would it be an option to allow a tolerance of 1 cm ? Or should we be strict on that sort of issues ?

Reopened because of comment of cecile above.

I added an option "strict_checks" to the configuration file or the module options so this check can be disabled.
The recommended usage would be to leave this to true by default, and change it when you have verified that the problems reported can be neglected.
This should probably also apply to coordinate system checks, as I have seen that there may be false warnings (eg when standard parallels are flipped, which is mathematically the same).

Fixed using the strict_checks parameter.


Use 2MiB pages instead of one 1GiB page

1 GiB pages are a relatively new feature, Intel introduced it in 2010
and QEMU in 2014. So we don't want to rely on it and make the whole OS
incompatible to older systems. See issue #17.

TODO: Cherry pick to tags: entering_longmode, setup_rust, printing_to_screen


Fix Issue #5

Issue #5
Added Countdown ..
Contains :- Days : Hours : Minutes : Seconds
Sample:

Good job :star:


symfony new my_project_name --full fails because of composer dependencies

Loading composer repositories with package information
Restricting packages listed in "symfony/symfony" to "5.2.*"
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - symfony/orm-pack[dev-main, v1.0.8, v2.0.0] require doctrine/doctrine-migrations-bundle * -> satisfiable by doctrine/doctrine-migrations-bundle[dev-manager-loader, dev-container-aware-migration-factory, dev-2.2.x-merge-up-into-3.0.x_5f12ade8acaa06.99463690, v1.0.0-beta1, ..., 1.3.x-dev, v2.0.0-alpha1, ..., 2.2.x-dev, 3.0.0-alpha.1, ..., 3.1.x-dev].
    - doctrine/doctrine-migrations-bundle v1.0.0-beta1 requires symfony/symfony >=2.0 -> satisfiable by symfony/symfony[v5.2.0-BETA1, ..., 5.2.x-dev].
    - symfony/orm-pack[v1.1.0, ..., v1.2.0] require doctrine/doctrine-migrations-bundle ^2 -> satisfiable by doctrine/doctrine-migrations-bundle[v2.0.0-alpha1, ..., 2.2.x-dev].
    - symfony/website-skeleton 1.0.0+no-version-set conflicts with symfony/symfony v5.2.0.
    - symfony/website-skeleton 1.0.0+no-version-set conflicts with symfony/symfony v5.2.0-RC2.
    - symfony/website-skeleton 1.0.0+no-version-set conflicts with symfony/symfony v5.2.0-RC1.
    - symfony/website-skeleton 1.0.0+no-version-set conflicts with symfony/symfony v5.2.0-BETA3.
    - symfony/website-skeleton 1.0.0+no-version-set conflicts with symfony/symfony v5.2.0-BETA2.
    - symfony/website-skeleton 1.0.0+no-version-set conflicts with symfony/symfony v5.2.0-BETA1.
    - symfony/website-skeleton 1.0.0+no-version-set conflicts with symfony/symfony 5.2.x-dev.
    - symfony/orm-pack[v1.0.0, ..., v1.0.7] require php ^7.0 -> your php version (8.0.0) does not satisfy that requirement.
    - doctrine/doctrine-migrations-bundle[dev-2.2.x-merge-up-into-3.0.x_5f12ade8acaa06.99463690, v2.0.0-alpha1, ..., 2.2.x-dev] require php ^7.1 -> your php version (8.0.0) does not satisfy that requirement.
    - doctrine/doctrine-migrations-bundle[dev-manager-loader, dev-container-aware-migration-factory, 3.0.0-alpha.1, ..., 3.1.x-dev] require php ^7.2 -> your php version (8.0.0) does not satisfy that requirement.
    - doctrine/doctrine-migrations-bundle[1.0.x-dev, ..., 1.3.x-dev] require symfony/framework-bundle ~2.7|~3.3|~4.0 -> found symfony/framework-bundle[v2.7.0-BETA1, ..., 2.8.x-dev, v3.3.0-BETA1, ..., 3.4.x-dev, v4.0.0-BETA1, ..., 4.4.x-dev] but these were not loaded, likely because it conflicts with another require.
    - doctrine/doctrine-migrations-bundle[1.0.1, ..., 1.2.x-dev] require symfony/framework-bundle ~2.3|~3.0 -> found symfony/framework-bundle[v2.3.0, ..., 2.8.x-dev, v3.0.0-BETA1, ..., 3.4.x-dev] but these were not loaded, likely because it conflicts with another require.
    - doctrine/doctrine-migrations-bundle[1.0.0-BETA2, ..., 1.0.0] require symfony/framework-bundle ~2.1 -> found symfony/framework-bundle[v2.1.0, ..., 2.8.x-dev] but these were not loaded, likely because it conflicts with another require.
    - symfony/website-skeleton is present at version 1.0.0+no-version-set and cannot be modified by Composer
    - Root composer.json requires symfony/orm-pack * -> satisfiable by symfony/orm-pack[dev-main, v1.0.0, ..., v1.2.0, v2.0.0].

See https://github.com/symfony/cli/issues/385#issuecomment-746647651


[Bug] ValueError: Number of signals and coords is not same

Describe the bug
I'm attempting to use elephant to perform CSD analysis. In a Jupyter notebook, I have implemented the temporary fix mentioned here in my usage. However, the output is not produced and I get an error (traceback below). Is this a failure of my usage? Or a bug in the code? I'm not fully sure what the error output means.
To Reproduce

Run the following code after importing the relevant elephant namespaces:

xs = np.array(nwb.electrodes.x)
xs = xs.reshape(xs.shape[0],1)
ys = np.array(nwb.electrodes.x)
ys = ys.reshape(ys.shape[0],1)

lfp = generate_lfp(small_source_2D, xs, ys)
estimate_csd(lfp, method="KCSD2D")

where nwb.electrodes.x and nwb.electrodes.y are arrays of length 2304.
Expected behavior
A resulting CSD array is expected to be outputted.
Environment
Windows 10:
Installed elephant with pip install elephant:
Python version: 3.9.10
neo==0.12.0
numpy==1.21.5
elephant==0.12.0
Traceback
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In [43], line 7
      4 ys = ys.reshape(ys.shape[0],1)
      6 lfp = generate_lfp(small_source_2D, xs, ys)
----> 7 estimate_csd(lfp, method="KCSD2D")

File ~\AppData\Local\Programs\Python\Python39\lib\site-packages\elephant\utils.py:80, in deprecated_alias.<locals>.deco.<locals>.wrapper(*args, **kwargs)
     77 @wraps(func)
     78 def wrapper(*args, **kwargs):
     79     _rename_kwargs(func.__name__, kwargs, aliases)
---> 80     return func(*args, **kwargs)

File ~\AppData\Local\Programs\Python\Python39\lib\site-packages\elephant\current_source_density.py:137, in estimate_csd(lfp, coordinates, method, process_estimate, **kwargs)
    135     raise ValueError('Must specify a method of CSD implementation')
    136 if len(coordinates) != lfp.shape[1]:
--> 137     raise ValueError('Number of signals and coords is not same')
    138 for ii in coordinates:  # CHECK for Dimensionality of electrodes
    139     if len(ii) > 3:

ValueError: Number of signals and coords is not same

Hey @rcpeene,
thanks again for reaching out to us.
If I understand correctly, if no coordinates are supplied to estimate_csd function, the default value is the string 'coordinates'. In this case the coordinates are assumed to be available as annotations.
Try this to see if the coordinates are annotated to the lfp instance:
lfp.annotations[coordinates]

I created the following minimal example:
import numpy as np
from elephant.current_source_density import generate_lfp, estimate_csd
from elephant.current_source_density_src.utility_functions import small_source_2D
import quantities as pq

xs=np.linspace(0, 10, 230).reshape(230,1)
ys=np.linspace(0, 10, 230).reshape(230,1)

lfp = generate_lfp(small_source_2D, xs, ys)
coordinates = np.stack((xs[:,0], ys[:,0]), axis=-1)*pq.mm
csd=estimate_csd(lfp, coordinates=coordinates, method="KCSD2D")
print(csd)

Here the coordinates are passed as quantities array.
print(coordinates)
[[ 0.          0.        ]
 [ 0.04366812  0.04366812]
 [ 0.08733624  0.08733624]
...
 [ 9.91266376  9.91266376]
 [ 9.95633188  9.95633188]
 [10.         10.        ]] mm

Which produces the following output:
No lambda given, using defaults
Cross validating R (all lambda) : 0.23
R, lambda : 0.23 2.8729848333536567e-13
[[[ 0.24422881  0.05464928  0.13539177 ... -0.01045737  0.00085341
    0.01609725]
  [ 0.05464928  0.01057368  0.01862725 ...  0.00056317  0.00126693
    0.00817861]
  [ 0.13539177  0.01862725 -0.0072203  ...  0.01467424  0.0080604
    0.04119698]
  ...
  [-0.01045737  0.00056317  0.01467424 ...  0.00287804 -0.00260698
   -0.02077326]
  [ 0.00085341  0.00126693  0.0080604  ... -0.00260698 -0.00399534
   -0.02497955]
  [ 0.01609725  0.00817861  0.04119698 ... -0.02077326 -0.02497955
   -0.15180521]]] uA/mm**3

Thanks again for reporting and let me know if this is helpful :+1:


Add Kopia SDK storage wrappers

Change Overview

Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test

Issues

fixes #issue-number

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

Closing this, adding multiple PRs for each storage provider


fix: remove unnecessary metadata action when overwriting partition

Description
Fixes spurious metadata action when write_deltalake is called with mode overwrite, using a predicate and with a string partition column. This is undesirable because all concurrent writes will fail and need to be retried due to this metadata action.
This is caused by the schema != table_schema check. table_schema is from calling table.input_schema() which converts string partition columns to dictionary and causes it to be different from schema.
We fix this issue by comparing it using try_cast_batch, so the behavior becomes identical to writing with mode='append'.
To replicate (on deltalake==0.20.1):
from deltalake import DeltaTable, write_deltalake
import polars as pl

df1 = pl.DataFrame({'id': ['a', 'b'], 'val': [1,2]})

write_deltalake('testtable1', df1.to_arrow(), schema_mode='merge', mode='overwrite', partition_by=['id'])
write_deltalake('testtable1', df1.to_arrow(), schema_mode='merge', mode='overwrite', partition_by=['id'])
write_deltalake('testtable1', df1.to_arrow(), schema_mode='merge', mode='overwrite', partition_by=['id'])

If we look at the latter 2 transaction JSONs, they will have a metadata action indicating a schema change, even though the schema is identical.

Something related with this (although its probably not the same bug, it gets huge with this issue), when the schema is re-written, all the "" (for example Spark comments) in the metadata gets duplicated
I have a metadata json file whose size is already 350mb
\"metadata\":{\"comment\":\"{\\\"description\\\": \\\"Audit field indicating the record was last written/processed/refreshed (i.e. any action)\\\", \\\"alias\\\": \\\"\\\", \\\"enabled\\\": True, \\\"taxonomy\\\": None, \\\"examples\\\": []}\"}

After 6 writes it became
\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"description\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\": \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"Audit field indicating the record was last written/processed/refreshed (i.e. any action)\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\"

Looks like a json


All Page - When we filter records and click enter it should filter data by Abhinav Sirvi Associates

Describe the bug

All page issues are not trackable, so clear indication with actual page will give better result in term of issue tracking,
closing for now, but taking Keyboard shortcut implementation as input


Update witheve.com

I'm raising my hand for this as the contents of witheve.com feels a little bit outdated.

Closing this because this is not the right venue for this issue.


Docker 镜像支持 ARM 64 架构 | Add support for ARM64 Arch. to the Docker image

When deploying with docker-compose, I encountered the error message:
redis    | 1:C 11 Jan 2024 11:46:16.480 * oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
redis    | 1:C 11 Jan 2024 11:46:16.480 * Redis version=7.2.4, bits=64, commit=00000000, modified=0, pid=1, just started
redis    | 1:C 11 Jan 2024 11:46:16.480 # Warning: no config file specified, using the default config. In order to specify a config file use redis-server /path/to/redis.conf
redis    | 1:M 11 Jan 2024 11:46:16.481 * monotonic clock: POSIX clock_gettime
redis    | 1:M 11 Jan 2024 11:46:16.481 * Running mode=standalone, port=6379.
redis    | 1:M 11 Jan 2024 11:46:16.485 * Server initialized
redis    | 1:M 11 Jan 2024 11:46:16.485 * Ready to accept connections tcp
db       | 2024-01-11 11:46:16+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 8.2.0-1.el8 started.
chatnio  | exec ./chat: exec format error
db       | 2024-01-11 11:46:16+00:00 [Note] [Entrypoint]: Switching to dedicated user 'mysql'
db       | 2024-01-11 11:46:16+00:00 [Note] [Entrypoint]: Entrypoint script for MySQL Server 8.2.0-1.el8 started.
chatnio exited with code 0
db       | 2024-01-11 11:46:17+00:00 [Note] [Entrypoint]: Initializing database files
db       | 2024-01-11T11:46:17.271991Z 0 [System] [MY-015017] [Server] MySQL Server Initialization - start.
db       | 2024-01-11T11:46:17.273823Z 0 [Warning] [MY-011068] [Server] The syntax '--skip-host-cache' is deprecated and will be removed in a future release. Please use SET GLOBAL host_cache_size=0 instead.

With the assistance of the QQ group admin, it was discovered that the issue was due to the current Docker image not supporting servers with the arm64 architecture. So, I'm hoping that Chatnio could consider adding support for ARM64 Docker images.


Construction of ASTERIA paths is not robust

Currently, ASTERIA checks for the existence of several directories during installation. If these directories are not found, they are created. This is done using os.path.realpath in the package's __init__.py. This current method is not robust and can lead to the formation of incorrect paths, leading to other issues.
A better way of performing these checks is needed.

The data/processed/ and scratch/ directories are created on installation to help users follow the intended use of ASTERIA. Specifically, users are intended to store their simulations in data/processed/ and run their scripts/notebooks out of scratch/. As of commit 837ea19, these folders were added to the .gitignore so that git would not track changes made within these folders.
However, at time of writing this comment, the IO module does not specifically save simulations to the processed folder. Rather, it allows the user to the specify the directory. It was found that a number of yaml files have IO table paths that do not point to the processed directory. It is my opinion that it would be better to leave the IO table path specification up to the user rather than enforce saving simulations to the processed directory. All configurations packaged with ASTERIA should point to the processed directory.

Resolved by commit c2ce054. Though this may only be a temporary solution. This has been solved by committing essentially empty folders to enforce a directory structure when cloning ASTERIA. These folders data/processed and scratch contain .gitignore files instructing git to ignore everything in the folders aside from the .gitignore files.


Optimize Gradle builds by enabling local build caching

Signed-off-by: Andriy Redko<EMAIL_ADDRESS>Description
The Gradle build cache is a cache mechanism that aims to save time by reusing outputs produced by other builds. The build cache works by storing (locally or remotely) build outputs and allowing builds to fetch these outputs from the cache when it is determined that inputs have not changed, avoiding the expensive work of regenerating them [1].
Even when used by a single developer only, the build cache can be very useful. Gradle’s incremental build feature helps to avoid work that is already done, but once you re-execute a task, any previous results are forgotten. When you are switching branches back and forth, the local results get rebuilt over and over again, even if you are building something that has already been built before. The build cache remembers the earlier build results, and greatly reduces the need to rebuild things when they have already been built locally. [2]
[1] https://docs.gradle.org/current/userguide/build_cache.html
[2] https://docs.gradle.org/current/userguide/build_cache_use_cases.html#use_cases_cache
Issues Resolved
N/A
Check List

[ ] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta could you rebase on main to consume the new gradle check?
Thanks.

@reta could you rebase on main to consume the new gradle check?

@peterzhuamazon cryptic failure:
Run echo "https://github.com/opensearch-project/OpenSearch.git PR: 3718"
https://github.com/opensearch-project/OpenSearch.git PR: 3718
Raise from https://github.com/reta/OpenSearch.git 115f91b543c36ac332915b03f7699b8264d31836
PR Title: Optimize Gradle builds by enabling local build caching
Trigger Jenkins workflows
QUEUE_URL null
wait for jenkins to start workflow
Check if queue exist in Jenkins after triggering
Please check jenkins url for logs:
Result: null

@reta could you rebase on main to consume the new gradle check?

@peterzhuamazon cryptic failure:
Run echo "https://github.com/opensearch-project/OpenSearch.git PR: 3718"
https://github.com/opensearch-project/OpenSearch.git PR: 3718
Raise from https://github.com/reta/OpenSearch.git 115f91b543c36ac332915b03f7699b8264d31836
PR Title: Optimize Gradle builds by enabling local build caching
Trigger Jenkins workflows
QUEUE_URL null
wait for jenkins to start workflow
Check if queue exist in Jenkins after triggering
Please check jenkins url for logs:
Result: null

Hi @reta I have fixed the issue in #3728 please rebase again.
Sorry for confusion.
Thanks.

Hi @reta I have fixed the issue in #3728 please rebase again.
Sorry for confusion.

Thanks a lot, @peterzhuamazon , no problem at all

@reta think failure related to this one?
https://github.com/opensearch-project/OpenSearch/issues/3579

Interesting that I just triggered a run on main and it passed.
https://build.ci.opensearch.org/job/gradle-check/31/

Lets give it a minute as I have a new PR incoming to clear up all the opensearch existing processes before using it for another run. Will rebase this PR once that is in.
Thanks.

Lets give it a minute as I have a new PR incoming to clear up all the opensearch existing processes before using it for another run. Will rebase this PR once that is in.
Thanks.

We public CI we have awesome visibility on the health of the builds:

Thanks for that, @peterzhuamazon !

😱 https://github.com/opensearch-project/OpenSearch/runs/7102002447?check_suite_focus=true ✅

@dblock @andrross are you good with the change folks?

Looks good to me!

Thank you!

Random question...does ./gradlew clean also clear this cache?

Aha, good one - nope! That means next build ( fe ./gradlew clean followed by ./gradlew assemble will be very fast if nothing changed :)


Convert RandomTranslation to the backend-agnostic implementation

Related to #481
Tests all passed in my local env

I have added some tests including:

raise ValueError with bad factors
training=False behavior
channels_first & channels_last

Now the coverage becomes 100%
Name                                                    Stmts   Miss  Cover
---------------------------------------------------------------------------
keras_core/layers/preprocessing/random_translation.py      74      0   100%


Rendering the See also section

The See also section contains links and corresponding descriptions which should be rendered to look like as the same section on Cppreference (example).
If the link points to an in-repository object, then the object name and excerpt should be rendered the same way as in the module/header page.

Depends on #2


Offline hotspots displaying with scale color instead of offline color

Due to the change to the hotspots.json file no longer including online status, any offline hotspot is showing the transmit scale color which is confusing when counting hotspots.

fixed in #95


Paper draft

Working paper draft for JOSS submission. Merging into main for ease of compilation while editing.

Closing in favor of keeping the paper branch separate while writing. Setting up CI for paper compilation to work when pushing to the branch, not just through a pull request to main.


[Feature Request] Option to @apply without !important when important mode is on.

Hey there, we chatted about this on Twitter a few days ago and I would love a way to do this. The use case is that I often create a .content class to scope a lot of typography rules into for written content, while leaving the rest of the global defaults in tact. When I do this, I lose the ability to override with utilities.
Turning important on works but then i can't @apply anything because that importance is inherited.

I tried to work on a PR but came up short - this particular type of project isn't quite my forte -- just couldn't find a good testing/debug setup.
I chatted with @adamwathan about this and it seems like the best course of action would probably be to simply remove !important when applying the AtRules in substituteClassApplyAtRules{}. It should be something like this: https://gist.github.com/georgecrawford/acb44cae777f5d0378d1db001acefacd, but I couldn't seem to manipulate the data correctly. Or maybe my test set up was faulty. Either way, maybe this will help jump start something.

!important
all
the things BIIIIIIIIITCCCCCCHHHH

Sorry, just kidding.
I love !important for all utilities.
IMO don't use @apply. Just use regular css if it should be overwritten,
IMO utilities should always be !important. Wheater @applyed or not :-)

This will be in 0.4 which I may release today 👍


Failure mode for Coinbase Wallet is not smooth

Current Behavior
When a user visits a site using this library and clicks to use Coinbase Wallet but doesn't have that extension activated, there is an ugly "Uncaught ReferenceError: Buffer is not defined."
Expected Behavior
More elegant handling of the error, perhaps with a message that Coinbase Wallet was not found, click here to manage extensions if you have it installed but not activated, click here to install it, etc.
Steps To Reproduce
In Chrome, have MetaMask and Coinbase Wallet installed.
Visit chrome://extensions/ to disable Coinbase Wallet because of its nasty habit of taking precedence over MetaMask on sites where you really want to use MetaMask.
Create a sample React app with Web3-onboard and Coinbase wallet as one of the options.
Run yarn start to run the app in dev mode.
Visit the app and click to try to use Coinbase Wallet
See an ugly compilation error pop up over the screen.
It's better in a production build, but the error is still in the console and the message shown to the user might leave them wondering why it's not working.
What package is effected by this issue?
@web3-onboard/coinbase
Is this a build or a runtime issue?
Runtime
Package Version
"@web3-onboard/coinbase": "^2.2.2", "@web3-onboard/core": "^2.17.0"
Node Version
N/A
What browsers are you seeing the problem on?

No response
Sanity Check

[X] If this is a build issue, I have included my build config. If this is a runtime issue, I have included reproduction steps and/or a Minimal, Reproducible Example.

@wbt I'm having a hard time reproducing locally- I get this pop up when I have the coinbase extension disabled:

Can you provide a sample of the code you're using? Thx!

OK, got it down to a simple example.

In a terminal in an empty folder on a machine with Node installed (v16 for test), npx create-react-app coinbase-wallet-bug-demo
cd coinbase-wallet-bug-demo
Replace src/index.js with src/index.tsx containing the following:

import React from 'react';
import ReactDOM from 'react-dom/client';
import Onboard from '@web3-onboard/core';
import coinbaseWalletModule from '@web3-onboard/coinbase';
import walletConnectModule from '@web3-onboard/walletconnect';
import injectedModule from '@web3-onboard/injected-wallets';
const coinbaseWalletSdk = coinbaseWalletModule();
const walletConnect = walletConnectModule();
const injected = injectedModule();
const OnboardWrapper = Onboard({
    wallets: [coinbaseWalletSdk, walletConnect, injected],
    chains: [
        {
            // chain ID must be in hex, though use of parseInt could make that more flexible
            id: '0x1',
            token: 'ETH',
            namespace: 'evm',
            label: 'Ethereum Mainnet',
            rpcUrl: `https://mainnet.infura.io/v3/${process.env.REACT_APP_INFURA_KEY}`
        },
    ],
});
const connectWallet = async () => {
    try {
        const wallets = await OnboardWrapper.connectWallet();
        console.log('First connected account address: ' + wallets[0]?.accounts[0]?.address);
    } catch (error) {
        console.error(error);
    }
};
const root = ReactDOM.createRoot(
    document.getElementById('root') as HTMLElement
);
root.render(
    <React.StrictMode>
        <button
            onClick={connectWallet}
        >Click here to connect your wallet</button> and see the connected address in the console.
    </React.StrictMode>
);

Run npm start
In the Chrome browser with Coinbase Wallet extension installed but disabled, visit localhost:3000.
Click the button
Click Coinbase Wallet
See this:

If you instead click on e.g. MetaMask you can successfully connect that and see that it works fine.

Ah, yes, that works much better now; sorry for the inconvenience.
The documentation there says "The above webpack 5 example can be used in the craco.config.js file at the root level in this case." but the syntax around plugins is actually a bit different but after following the other instructions about packages to add, adding CRACO per its own documentation, and replacing the plugins object from this package's documentation with
webpack: {
    plugins: {
        add: [
            new webpack.ProvidePlugin({
                process: 'process/browser',
                Buffer: ['buffer', 'Buffer']
            })
        ]
    }
}

it worked with the expected behavior as pictured above.


CODE RUB: ExcessiveCallFineTuneException Class Update v2.10.1

Updated ExcessiveCallFineTuneException class by removing constructors in which the error message was hard coded in. Updated all relevant service files to include message.

Closing Pull Request. Resolved in PR #554.


Energy Sums null values for NEM for 2011-2017

Energy sum values nulled out for 2011-2017

how does double counting happen?

how does double counting happen?

I put in a fallback so that if energy sums don't exist it does generated / network.intervals_per_hour in this case it was adding both as energy_sum ran


Implement simple RWMutex cache to be used in domainCache

We are facing an issue in which domain specific metrics cannot be emitted in task processing. We suspect that this is due the lock contention associated with using a LRU cache. LRU cache grabs a write lock every time Get is called so that it can move elements to the front of the cache. This is not actually needed in the case of domain cache because we never expect to evict entries from domain cache.

Coverage increased (+0.1%) to 68.53% when pulling 93a794992fbb20a9ffbaf18503af99d258196826 on andrewjdawson2016:DomainCache into 74b40edeb2816cac3f8d43ddc42949ce99f2b2c7 on uber:master.

According to my memory the domains in the cache are immutable and caches are swapped during update so just use a hashmap plus TTL should be fine?

@wxing1292 yes you are right - ideally it should just be a hashmap. The reason it is not is because domainCache is currently a messy abstraction its both a cache for id->name mapping and a method for registering callbacks for replication. Ideally domain cache should be separated out into two pieces one for replication and one that is simply a hashmap with TTL as you mentioned. But until this separation is done it is hard to simply pull out the cache into a hashmap. @yux0 has it on his plate at some point to refactor domain cache into these pieces at which point this simple cache is no longer needed for domain cache - but it might still be useful in other contents.

@wxing1292 yes you are right - ideally it should just be a hashmap. The reason it is not is because domainCache is currently a messy abstraction its both a cache for id->name mapping and a method for registering callbacks for replication. Ideally domain cache should be separated out into two pieces one for replication and one that is simply a hashmap with TTL as you mentioned. But until this separation is done it is hard to simply pull out the cache into a hashmap. @yux0 has it on his plate at some point to refactor domain cache into these pieces at which point this simple cache is no longer needed for domain cache - but it might still be useful in other contents.

After I took a closer look at the failover callback, I realized that the callback has to make sure domain cache does not update during the callback execution. I think it is the reason that the callback lives in the domain cache. I need more time to see how should we separate the them.

According to my memory, you cannot separate the callback with the domain cache, which has to guarantee the domain cache visibility.
Using a hashmap should be the simplest way to solve potential nested locking issue

I was going to use the hashmap instead of the LRU cache,  but did not found much time  to do it


Add more varied input data to tests in FileSystemUtilsTestCase

This PR adds two test cases with exercise FileSystemUtilsTestCase#freeSpaceWindows with one larger amount of free disk space and one smaller amount of free disk space.

Coverage increased (+0.08%) to 90.054% when pulling febe50d9d8d180b49170574e423f2c1ae1e6c4db on testingsavvy:add-tests-win into 5f88079956ba7fc4551a5fc51dc28d82e33dc65f on apache:master.

Thanks! :+1:


Can't properly filter ballots by type

Describe the bug
By default, the filters have active and VOTE selected. If you change the type to proposal, it will only show the proposals from that list, but the same doesn't happen with poll. When selecting the poll type, the list is empty even though there is one item at the list.
To Reproduce
Steps to reproduce the behavior:

Go to ballots
See that the listed ballots (with active and VOTE) contain one poll (/ballots/rbqs4bmmel2w/1663123846224)
Scroll up
Add the type filtering with poll selected
There are no ballots returned

Expected behavior
The ballot of type poll that is active and belongs to the VOTE treasury should appear.

@karynemayer Default filter settings for all governance types are not showing any results. It seems that Status "active" does not match any meta data of active proposals.

@Kersten-TCD @DevArtemNuss
The acceptance criteria for this task remain to be able to filter the proposals and polls using the type. For the active filtering not working, we have created #75


adds netatmo-crawler

Hi, some review comments:

you should add more error handling ... e.g. https://github.com/Bart1909/ioBroker.netatmo-crawler/blob/master/main.js#L203 ... there are many cases where it is not error, ut also no body or no response is set in the callback and such ...
adapte core 2.4.0 requires at least js-controller 2.0.0, please update this in io-package dependencies

RE-CHECK!

Automated adapter checker
ioBroker.netatmo-crawler

[ ] :heavy_exclamation_mark: [E801] No repository about text found. Please go to "https://github.com/Bart1909/ioBroker.netatmo-crawler", press the first "Edit" button you will find on the page and add the description.
[ ] :eyes: [W400] Cannot find "netatmo-crawler" in latest repository

ioBroker.senec

[ ] :heavy_exclamation_mark: [E801] No repository about text found. Please go to "https://github.com/nobl/ioBroker.senec", press the first "Edit" button you will find on the page and add the description.

Add comment "RE-CHECK!" to start check anew

Please ignore the false positive from the checker. this is ok

Hi @Apollon77 ,
Version 0.3.0 adds more error handling and requires at least js-controller 2.0.0
(This should be updated in the template-creator i think)

RE-CHECK!

Automated adapter checker
ioBroker.netatmo-crawler

[ ] :heavy_exclamation_mark: [E801] No repository about text found. Please go to "https://github.com/Bart1909/ioBroker.netatmo-crawler", press the first "Edit" button you will find on the page and add the description.
[ ] :heavy_exclamation_mark: [E802] No topics found in the repository. Please go to "https://github.com/Bart1909/ioBroker.netatmo-crawler" and press Manage topics
[ ] :heavy_exclamation_mark: [E603] NO "## Changelog" found in README.md
[ ] :heavy_exclamation_mark: [E604] No ## License found in README.md
[ ] :eyes: [W400] Cannot find "netatmo-crawler" in latest repository

ioBroker.senec

[ ] :heavy_exclamation_mark: [E801] No repository about text found. Please go to "https://github.com/nobl/ioBroker.senec", press the first "Edit" button you will find on the page and add the description.
[ ] :heavy_exclamation_mark: [E802] No topics found in the repository. Please go to "https://github.com/nobl/ioBroker.senec" and press Manage topics

Add comment "RE-CHECK!" to start check anew

RE-CHECK!

Automated adapter checker
ioBroker.netatmo-crawler

[ ] :heavy_exclamation_mark: [E801] No repository about text found. Please go to "https://github.com/Bart1909/ioBroker.netatmo-crawler", press the first "Edit" button you will find on the page and add the description.
[ ] :heavy_exclamation_mark: [E802] No topics found in the repository. Please go to "https://github.com/Bart1909/ioBroker.netatmo-crawler" and press Manage topics
[ ] :eyes: [W400] Cannot find "netatmo-crawler" in latest repository

ioBroker.senec

[ ] :heavy_exclamation_mark: [E801] No repository about text found. Please go to "https://github.com/nobl/ioBroker.senec", press the first "Edit" button you will find on the page and add the description.
[ ] :heavy_exclamation_mark: [E802] No topics found in the repository. Please go to "https://github.com/nobl/ioBroker.senec" and press Manage topics

Add comment "RE-CHECK!" to start check anew

@Apollon77 can you say, when this will be merged?
I‘ve implemented a lot of error handling

You don' need a unload handler. It is empty


4.5 Class Diagram

https://lucid.app/invitations/accept/501e6fc0-ef26-412c-9650-1c122751e1fa
Updating class diagram here.
Added base models and base controller form laravel

Basic description of Class Diagram.
https://docs.google.com/document/d/1Ihbw8Wyk2vt3ZtAs2OHb8ahC8HgTIxqoOwICp1zNKOE/edit?usp=sharing

Based off of feedback, added black boxes to represent controllers and classes not yet changed from generated as well as added descriptions for what they are


Request Entity Too Large

Hello,
Nextcloudpi : v1.15.3
Error : Request Entity Too Large
When : upload
Board : RPI3B
Post_max_size = 10G
upload_max_filesize = 10G
Debian buster (OK with Debian stretch)
libapache2-mod-security2/stable,now 2.9.3-1 armhf  [installé]
Tighten web applications security for Apache
libmodsecurity-dev/stable 3.0.3-1 armhf
ModSecurity v3 library component (development files)
libmodsecurity3/stable 3.0.3-1 armhf
ModSecurity v3 library component
modsecurity-crs/stable,now 3.1.0-1 all  [installé, automatique]
OWASP ModSecurity Core Rule Set
Script used (installation and configuration) https://github.com/nextcloud/nextcloudpi/blob/master/bin/ncp/SECURITY/modsecurity.sh

Did you see the size limit in the modsecurity config?
line 38 & 39
https://github.com/SpiderLabs/ModSecurity/blob/v3/master/modsecurity.conf-recommended

I tried with a large SecRequestBodyLimit but no way

It's not so clear what are you using, because you wrote:

libapache2-mod-security2/stable,now 2.9.3-1 armhf [installé]
Tighten web applications security for Apache
libmodsecurity-dev/stable 3.0.3-1 armhf
ModSecurity v3 library component (development files)
libmodsecurity3/stable 3.0.3-1 armhf
ModSecurity v3 library component

libapache2-mod-security2 is an Apache module. The ModSecurity v2 works only with Apache (as stable).
libmodsecurity3 is a library, and currently works only with nGinx (from the most popular webservers), but not with the Apache. I don't know about nginx module for Debian/Raspbian, but may be you've found one, just not listed above.
You wrote that you set up the post_max_size = 10G and upload_max_filesize = 10G variables, but these are PHP variables.
How do you configured your webserver? Have you set up any limit?
Note, that the script what you've linked contains
# UPLOADS ( 5 MB max excluding file size )
SecRequestBodyNoFilesLimit 5242880

a limit. Did you increased it?

Already tried. In fact I use "nextcloudpi" and since debian buster I can't upload with modsecurity v2. (The script didn't change) I'd like to help "nextcloudpi dev".

And what do you see in error.log/modsec_debug.log?

Modsec_debug.log is empty
Error.log
Jul 30 00:00:02.805824 2019] [ssl:warn] [pid 18342:tid<PHONE_NUMBER>] AH01909: localhost:4443:0 server certificate does NOT include an ID which matches the server name                                                                       [Tue Jul 30 00:00:02.808749 2019] [mpm_event:notice] [pid 18342:tid<PHONE_NUMBER>] AH00489: Apache/2.4.38 (Raspbian) OpenSSL/1.1.1c configured -- resuming normal operations                                                                       [Tue Jul 30 00:00:02.808783 2019] [core:notice] [pid 18342:tid<PHONE_NUMBER>] AH00094: Command line: '/usr/sbin/apache2'                                           [Tue Jul 30 23:23:43.207843 2019] [mpm_event:notice] [pid 18342:tid<PHONE_NUMBER>] AH00493: SIGUSR1 received.  Doing graceful restart                              [Tue Jul 30 23:23:43.496771 2019] [ssl:warn] [pid 18342:tid<PHONE_NUMBER>] AH01909: localhost:4443:0 server certificate does NOT include an ID which matches the server name
[Tue Jul 30 23:23:43.504553 2019] [mpm_event:notice] [pid 18342:tid<PHONE_NUMBER>] AH00489: Apache/2.4.38 (Raspbian) OpenSSL/1.1.1c   configured -- resuming normal operations
[Tue Jul 30 23:23:43.504584 2019] [core:notice] [pid 18342:tid<PHONE_NUMBER>] AH00094: Command line: '/usr/sbin/apache2'

Could you try it without modsecurity? Just disable it, any other settings remains as it is.

Without modsecurity I can upload a large file.

I can't help more based on these information - see another topics, eg:
https://talk.plesk.com/threads/modsecurity-post-failure-with-413-request-entity-too-large.339896/

@musklor can you provide more details? Also make sure you set SecRequestBodyLimit as well. Also try with "SecRequestBodyLimitAction ProcessPartial"

With "SecRequestBodyLimitAction ProcessPartial", I have a connection error.
SecRequestBodyLimit very large.

Hi @musklor,
It is very likely that you are facing a bug in version 2.x for nginx. Any chance to upgrade to version 3?

Apache issue