Web view test is broken

https://monacotools.visualstudio.com/Monaco/_build/results?buildId=83206&view=logs&j=d71c4c56-574b-5ba9-9268-feb3539ccbff&t=7d37d8af-91f8-5651-2695-cda24483e594
Mac
1) vscode API - webview webviews should preserve vscode API state when they are hidden:
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
      at listOnTimeout (internal/timers.js:531:17)
      at processTimers (internal/timers.js:475:7)

Linux
1) vscode API - webview webviews should only be able to load resources from workspace by default:

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: Expected values to be strictly equal:

false !== true

      + expected - actual

      -false
      +true

      at Context.<anonymous> (extensions/vscode-api-tests/src/singlefolder-tests/webview.test.ts:273:11)
      at processTicksAndRejections (internal/process/task_queues.js:94:5)

  2) vscode API - webview webviews using hard-coded old style vscode-resource uri should work:

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: Expected values to be strictly equal:

false !== true

      + expected - actual

      -false
      +true

      at Context.<anonymous> (extensions/vscode-api-tests/src/singlefolder-tests/webview.test.ts:346:10)
      at processTicksAndRejections (internal/process/task_queues.js:94:5)

Skipped the test.

Skipped another failing test
https://monacotools.visualstudio.com/Monaco/_build/results?buildId=83327&view=logs&j=a5e52b91-c83f-5429-4a68-c246fc63a4f7&t=087c9a82-9b9b-5b5f-17f2-a070cb4808e3
 1 failing
  1) vscode API - webview webviews should allow overriding allowed resource paths using localResourceRoots:

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: Expected values to be strictly equal:

false !== true

      + expected - actual

      -false
      +true

      at Context.<anonymous> (extensions/vscode-api-tests/src/singlefolder-tests/webview.test.ts:319:11)
      at processTicksAndRejections (internal/process/task_queues.js:94:5)

I skipped more failing tests via f3e4ff9196

Closing as out of date. cc @mjbvz


Unable to render MapView component (this._onMapReady.bind undefined)

Bug

I'm trying to integrate react-native-maps inside my new project but after following install instructions I always get the following error when I use the  component.
Undefined is not an object (evaluating '_this._onMapReady.bind')
react-native-maps was the first library I linked with this project and it was working before. Now after developing my app and adding other libraries I have this error. Maybe I used react-native link to link my fonts and it messed up something with rn-maps. I tried removing the pod and reinstalling from scratch with no luck.
Environment info

React native info output:
System:
    OS: macOS 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 70.01 MB / 16.00 GB
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    Yarn: 1.9.4 - ~/.yarn/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
    Android SDK:
      API Levels: 15, 23, 24, 25, 26, 27, 28
      Build Tools: 23.0.1, 23.0.2, 23.0.3, 25.0.0, 25.0.1, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.1, 27.0.3, 28.0.2, 28.0.3
      System Images: android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom_64
      Android NDK: 17.2.4988734
  IDEs:
    Android Studio: 3.4 AI-183.6<IP_ADDRESS>22156
    Xcode: 10.1/10B61 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.5 => 0.60.5
  npmGlobalPackages:
    react-native-cli: 2.0.1
    react-native-git-upgrade: 0.2.7

Library version: 0.25.0
Steps To Reproduce

yarn add react-native-maps -E
cd ios
pod install

Describe what you expected to happen:

No error

you didn't link, the module doesn't support yet auto-linking I think


Pmd findbug fixes

Ran PMD and Findbugs on source.  These were the mods and cleanup from that.

@elingg @adam-mesos could use a review... however this replaces PR86 https://github.com/mesosphere/hdfs/pull/86 and all comments from that PR have been applied here. so it should be fairly clean.

Thanks, @kensipe! I'll go through this when I have some cycles ASAP. Was this tested?

running the tests now

@elingg tested good

@elingg I have another PR to follow this one and then the major quality checks will be in places.   The branch https://github.com/mesosphere/hdfs/tree/qa-checks has findbugs, pmd, checkstyles with issue resolution for all of them.

Thanks, I went through the first pass of review, @kensipe. If you could address my comments, then I can take a second look. Thanks!

@elingg thx!   here are the summary of the issues outstanding:

FutureMessage
the PreNNInitTask task cancel().

thanks @kensipe! See my comments above on both issues.

@elingg All issues resolved

thanks @kensipe. I still have a concern with creating a class (even an inner class) that simply executes one line of code and is called in one place. I think we can find a way to test without adding unnecessary lines of code.

The inner class was actually removed. Let me take a final look!

LGTM! If there are no final objections from @adam-mesos, I will run a quick test tomorrow morning and then merge.

tested on DCOS


pwa medium rss feed app

Hi, I have added a simple application that I made with vue.js into the repository

Thank you @mfaridzia :tada:


Interactive Discussion as an issue

Can anyone suggest something else that can be added here??

ALSO!!! JUST OUT OF CURIOSITY....
Can existing contributors confirm if their points are getting counted in their GSSoC'24-ext profile.. 🤔 If not, inform me in this issue.... 🤞🏻. Wanna make sure your hardwork don't go to waste. 👍🏻
This issue won't be assigned to anyone it's just a discussion but you guys just jump into issue 😅....
Also, since the development curve has been increasing exponentially since the last few days, please leave a feedback if you want to.. and make sure it's positive 😁

And who worked on this? 😂

@Luson045  We can add the details about the contributors like their name ,github profile image ,github link .
It will look like this.....

is it dynmic? like is it fetching data from github?

no

The GitHub contributors data provided earlier in the form of an array is static. It's a hardcoded list of contributor names, GitHub profile links, and images, meaning it does not automatically update based on real-time changes to the actual contributors in a project.


PowerRename Does Not Keep File Sorting Order

Microsoft PowerToys version
0.73.0
Installation method
GitHub, PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
PowerRename
Steps to reproduce

Go into a folder full of files in Windows Explorer
Sort them by date
Select them all (CTRL + A)
Right click, PowerRename
The files are sorted Alphabetically, instead of “by date”

✔ Expected Behavior
The expected behaviour is the original one: PowerRename should not decide the sort order of files, and should just sort them as they were selected in Windows Explorer.
❌ Actual Behavior
Instead, PowerRename sorts file alphabetically, which makes enumerating the files completely wrong.
Other Software
No response

/dup #11640


Remove log4j deps; modules must not depend on logging impls

individual modules must not depend on specific logging impls,
only on SLF4J API. Logging impls are then plugged-in in
end-user apps

Merged on master.
Thanks @psiroky


Update jsfuck.js

Shorter version of letter A
Old version has 507 char after encoding (due to word 'constructor' (Array))
New version has 187 char after encoding ('constructor' was changed to 'entries')

https://github.com/aemkei/jsfuck/commit/94c38357375e5009ebeb97fcc6934aaea482b210


Update user preference crd apigroup

The user preference crd's apigroup has been updated, and the cleanup scripts need to reflect the new change.

@zlayne ok, can you please notify me when that change is dropped so I can get this change into the deploy repo.  thx.

@zlayne Is this ready to be merged?

Yes it's good to go


TypeError: '_NamespacePath' object is not subscriptable

when I finished  the previous work mentioned aboved, I encountered the problem:
src/allennlp/allennlp/common/util.py  line316, in import_submodules
path_string = ' ' if not path else path[0]
TypeError: '_NamespacePath' object is not subscriptable.....
what should I do to deal with the problem?? Thanks in advance

from allennlp.commands import main  # pylint: disable=wrong-import-position

Can you past the command you're executing for AllenNLP?  Are you including a --include-package argument?

Thank you for your response! Do you mean that I have to Install AllenNLP package apart from " ip install -r requirements.txt"?   By the way, the problem appears when I just follow the tips on Readme.txt, so what should I do in addition to these tips?

Thank you for your response! Do you mean that I have to Install AllenNLP package apart from " pip install -r requirements.txt"? By the way, the problem appears when I just follow the tips on Readme.txt, so what should I do in addition to these tips?

Hi, I meant to ask what commands are you executing such that you encounter the error?  Can you paste the full commands you're using?

Thank you! I pass "sh ./scibert/scripts/train_allennlp_local.sh ./scibert/output" to run the script as the final tips, and my env is python3.6.8. So is it something wrong with the Allennlp source code?

after I fix the problem by adding empty "init" file to the root dictory, there raise the allennlp configurationError, as following:
allennlp.common.checks.ConfigurationError: 'Cannot register text_classifier as Model; name already in use for TextClassifier'.
triggered by "from models.text_classifier import TextClassifier".

Thank you! I pass "sh ./scibert/scripts/train_allennlp_local.sh ./scibert/output" to run the script as the final tips, and my env is python3.6.8. So is it something wrong with the Allennlp source code?

Ah I see.  I don't recommend using that script; we used that for our internal experiments, but it's not meant for outside usage.  For example, the paths specified in that script are specific to our machines, so the script would need to be modified for others.
The best way to use SciBERT is how you'd normally use BERT.  Have you tried using BERT with AllenNLP?  If you can get that to work, then simply changing the path to BERT weights to SciBERT weights will make sure everything works.
Can you describe what it is you're trying to do?  For example, do you already have a BERT-based model and want to swap in SciBERT?  Are you working with a particular AllenNLP model in mind, or are you trying to use the ones that are in this repo?

Thanks, I have never used BERT and AllenNLP model before, and I just want to use the trained scibert models download from the repo that you given. So what can I do to run the scibert traind models to produce the result as you described in the paper besides following the tips in the Readme text strictly. Any advice will be appreciated.

I understand now, thanks!  We released SciBERT tensorflow/pytorch weights with the intention that researchers would use them within their existing tensorflow/pytorch projects that already know how to consume BERT.  It's fine if you haven't used AllenNLP before, but it's a bit hard to help you unless you have an existing project based around BERT already.
If you haven't already picked up a modeling framework, I recommend adopting AllenNLP and going through the tutorial first.  Once you have an environment setup that can successfully train any AllenNLP model, it should be straightforward to help you pick the specific model you're interested in & get the SciBERT weights plugged in.

Hi @ @kyleclo,
I tried to run the code and solve the problem above, however, another problem still stops me,https://github.com/allenai/allennlp/issues/3134 .
Whether there are some points I may miss?
Thank you!

After solving Cuda Error : RuntimeError: CUDNN_STATUS_EXECUTION_FAILED https://discuss.pytorch.org/t/cuda-error-runtimeerror-cudnn-status-execution-failed/17625, I run the code finally.
Thank you all.


[Feature Request]: Want to Fix UI of Profile Page #449

[Feature Request]: Want to Fix UI of Profile Page #449
Description
Updated Profile page + Back Button as Well (extra)
Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
https://github.com/MAVRICK-1/e-commerce_website/assets/101548649/4137ac48-4c9b-4746-9324-01959b4b118d
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ x] My code follows the code style of this project.
[x ] My change requires a change to the documentation.
[ x] I have updated the documentation accordingly.

Hey @dinxsh can you please review this pr


fix(curriculum): change overflow css of body to hidden in penguin practice project

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #47513

Hhey there, as this changes the code of the project itself you will need to propagate the change to all subsequent steps of the project

Hhey there, as this changes the code of the project itself you will need to propagate the change to all subsequent steps of the project

I've updated all subsequent steps


Remove fonts.googleapis.com and cdnjs.cloudflare.com

Description
Hi,
first at all it is a very nice project and I like it.
But external links to cloudflare and google are not my favorits. Is it possible to store such files local?
thx in advanced
dominion
Screenshots
No response
Additional information
No response

Hey @Dominion0815,
I personally think that CDN are better than store the files locally.
I am talking mostly about average load time and security aspects.
Thank you for your issue :)


Tables fix header is not working in Angular 7

Hi, I have tried your sample code for HTML Table in an empty view and it just doesn't fix the header on top. Any particular reason that may cause this?
<virtual-scroller #scroll [items]="this.nodes">

    Index
    Name
    Gender
    Age
    Address

      {{item.id}}
      {{item.name}}

</virtual-scroller>

Please go to this url
https://rintoj.github.io/ngx-virtual-scroller
and click "samples" and scroll down to the section "With Table".
Are the fixed headers working for you in that sample?
For me, the sample appears to be working fine.
If you agree, then it's probably something with your code.
If it's an issue with your code, I can't help troubleshoot without a stackblitz. Sorry :(
If you want to know how the height is calculated, feel free to read through the code & step through it with a debugger. It's too complex for me to explain :)

Hi @speige , Can you please share code for this table? In the demo above, its working fine but in my project I am having some issues. Thanks in advance. :)

@aryaroudi I'm not sure how to fix the flickering. If you find a way to fix it please submit a pull-request. Thanks.

@kamal0912 The code is all in github. Good Luck :)

@aryaroudi I'm not sure how to fix the flickering. If you find a way to fix it please submit a pull-request. Thanks.

Hey Speige, No, unfortunately. I'm using Angular Material VS now!


Version-based Windows cachebusting

Currently, we cachebust the Windows installer and RELEASES file using Date.now(). This is unnecessarily wasteful--we only need to bust the cache when the version changes. Thus, we should replace "?cb=" + Date.now() with "?version=" + Meteor.settings.electron.version.

In the case of Cloudfront, this will result in the cache storing one installer per version--perfect caching. (Whereas currently it caches one installer per request--super wasteful!)

Actually, I don't think this is safe to do; it creates a race condition between the webserver and the cache.
Let's say you have an update that requires new server functionality, thus must not go live until the servers have been deployed. Do you upload the binaries or deploy first?
If you upload the binaries first, they might be downloaded before deploy if the cache is flushed for some reason: the server will request RELEASES?version=old and get the new RELEASES.
If you deploy first, then when the server requests RELEASES?version=new, the old content will get cached for the new query!
In the current paradigm, the solution is to deploy first. Since we never cache the RELEASES file, it's ok for the upload to lag.
On Mac, the solution is to upload first, because (unlike Windows) the server controls when the client upgrades, and it's possible to version the download URLs.
We should make it similarly possible to version the installer URLs. I don't think we can do that for the RELEASES file but that's much smaller—we'll reap most of the benefits of caching just by caching the installers.


General -> FieldError("Cannot resolve keyword '%s' into field. " django.core.exceptions.FieldError: Cannot resolve keyword 'active' into field. Choices are: id, load_data, main_company_id, main_company_id_id, online, open_menu, type_share

Hi Mr Marlon,
When we access the menu item General, we received a error in log:
Traceback (most recent call last):
File "/home/user/projetos/env/lib/python3.8/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/core/handlers/base.py", line 115, in _get_response
response = self.process_exception_by_middleware(e, request)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/core/handlers/base.py", line 113, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/views/generic/base.py", line 71, in view
return self.dispatch(request, *args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/contrib/auth/mixins.py", line 52, in dispatch
return super().dispatch(request, *args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/views/generic/base.py", line 97, in dispatch
return handler(request, *args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/views/generic/edit.py", line 190, in get
return super().get(request, *args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/views/generic/edit.py", line 133, in get
return self.render_to_response(self.get_context_data())
File "/home/user/projetos/pyerp/apps/base/views/web_father.py", line 242, in get_context_data
forward = self.model.objects.filter(
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/manager.py", line 82, in manager_method
return getattr(self.get_queryset(), name)(*args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/query.py", line 892, in filter
return self._filter_or_exclude(False, *args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/query.py", line 910, in _filter_or_exclude
clone.query.add_q(Q(*args, **kwargs))
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/sql/query.py", line 1290, in add_q
clause, _ = self._add_q(q_object, self.used_aliases)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/sql/query.py", line 1315, in _add_q
child_clause, needed_inner = self.build_filter(
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/sql/query.py", line 1190, in build_filter
lookups, parts, reffed_expression = self.solve_lookup_type(arg)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/sql/query.py", line 1049, in solve_lookup_type
_, field, _, lookup_parts = self.names_to_path(lookup_splitted, self.get_meta())
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/sql/query.py", line 1419, in names_to_path
raise FieldError("Cannot resolve keyword '%s' into field. "
django.core.exceptions.FieldError: Cannot resolve keyword 'active' into field. Choices are: id, load_data, main_company_id, main_company_id_id, online, open_menu, type_share
2020-10-02 07:42:18,017 - ERROR -log.py:222 - Internal Server Error: /base/config/1
Traceback (most recent call last):
File "/home/user/projetos/env/lib/python3.8/site-packages/django/core/handlers/exception.py", line 34, in inner
response = get_response(request)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/core/handlers/base.py", line 115, in _get_response
response = self.process_exception_by_middleware(e, request)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/core/handlers/base.py", line 113, in _get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/views/generic/base.py", line 71, in view
return self.dispatch(request, *args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/contrib/auth/mixins.py", line 52, in dispatch
return super().dispatch(request, *args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/views/generic/base.py", line 97, in dispatch
return handler(request, *args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/views/generic/edit.py", line 190, in get
return super().get(request, *args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/views/generic/edit.py", line 133, in get
return self.render_to_response(self.get_context_data())
File "/home/user/projetos/pyerp/apps/base/views/web_father.py", line 242, in get_context_data
forward = self.model.objects.filter(
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/manager.py", line 82, in manager_method
return getattr(self.get_queryset(), name)(*args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/query.py", line 892, in filter
return self._filter_or_exclude(False, *args, **kwargs)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/query.py", line 910, in _filter_or_exclude
clone.query.add_q(Q(*args, **kwargs))
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/sql/query.py", line 1290, in add_q
clause, _ = self._add_q(q_object, self.used_aliases)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/sql/query.py", line 1315, in _add_q
child_clause, needed_inner = self.build_filter(
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/sql/query.py", line 1190, in build_filter
lookups, parts, reffed_expression = self.solve_lookup_type(arg)
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/sql/query.py", line 1049, in solve_lookup_type
_, field, _, lookup_parts = self.names_to_path(lookup_splitted, self.get_meta())
File "/home/user/projetos/env/lib/python3.8/site-packages/django/db/models/sql/query.py", line 1419, in names_to_path
raise FieldError("Cannot resolve keyword '%s' into field. "
django.core.exceptions.FieldError: Cannot resolve keyword 'active' into field. Choices are: id, load_data, main_company_id, main_company_id_id, online, open_menu, type_share
[02/Oct/2020 07:42:18] "GET /base/config/1 HTTP/1.1" 500 129188
Do You have any idea what is it?

I have the same problem and I haven't found the solution :(
What about you @carlosmonari ? Did you fix it?

Need to remove duplicate fields


obsolete/deprecation/g

As titled.

@sethmlarson I've updated the @deprecation tag to accept both the version and an optional description, there is no need to have two distinct tags for this.


Angular: StateService injected in custom library results in R3InjectorError

This issue tracker is for Bug Reports and Feature Requests only.
Please direct requests for help to StackOverflow.
See http://bit.ly/UIR-SOF for details.
This is a (check one box):

[x ] Bug Report
[ ] Feature Request
[ ] General Query

My version of UI-Router is: (type version)
@uirouter/angular: 10.0.0
@uirouter/core: 6.0.8
@uirouter/rx: 1.0.0
Bug Report
Current Behavior:
I am injecting the StateService in a component of a custom angular library I am building. As soon as I do that though, the following happens:
R3InjectorError(AppModule)[StateService -> StateService -> StateService]:
  NullInjectorError: No provider for StateService!

and the whole app does not work.
Expected Behavior:
No error, being able to use the Service and not crashing the whole application.
Link to Plunker or stackblitz that reproduces the issue:
Github-Repo: https://github.com/Vortilion/angular-library-stateservice-issue

Hi, I had the same problem when running unit tests on my Angular 15 application. Here is the solution I found to add in configureTestingModule(...)
 providers: [         StateService       ],


Removed check for invalid archive on download

I've tried to implement the checking for uploading, but implementing it on the binary make it impossible to test, and doing so on upload.js file makes all test to crash because fixtures are not correctly generated (don't have a .node file inside), so I think the best option is to remove any checking at all, leading to other use cases besides prebuild Node.js compiled modules like allowing to have prebuild binaries of programs like PhantomJS or my personal use case (gcc and binutils).

@piranna Mind rebasing this onto latest master?

Rebased.

Can you tell us a little more about your use case and what you're trying to achieve? I can update the tests if you like.

I'm trying to pack some binaries needed to build NodeOS, like the GCC-based cross-compiler or QEmu emulator. Due to this, I'm generating the tarball by hand since I don't have a .node file for it, and so I don't have it when downloading it so the check will always fail. Maybe this would be included on the new prebuild-install module?

Maybe this would be included on the new prebuild-install module?

That's a good idea! I guess once prebuild-install is operational, we will clean up this module and release a new major.

Good to know :-) Do you want that I cherry-pick this change and set it on the prebuild-install repo?

Do you want that I cherry-pick this change and set it on the prebuild-install repo?

+1 from me at least :)

Do you want that I cherry-pick this change and set it on the prebuild-install repo?
+1 from me at least :)

Done :-)

Any update on this? Should we close it and recommend people to use prebuild-install instead?


💥[FEATURE] Add Project statistics on the contributor page

🚀 Feature Request
Description
I want to add more details of the project repo.I attached a screenshot here.I am gonna add total contributor, total contributions, GitHub star, folks to it .
Problem Statement
Explain the problem or pain point this feature will solve.
Why is it important to add this feature?
It will help to get a clear overview of the project repo live .
Proposed Solution
Describe how you would like this feature to work.
If possible, provide examples of how it might look or behave.
I am gonna add total contributor, total contributions, GitHub star, folks to it .
Additional Context

Checklist

[x] I have checked the existing issues and this feature request is not a duplicate.
[x] I have starred this repository.
[x] I am willing to help implement this feature (optional).

Additional context
Add any other context or screenshots about the feature request here.

Please assign me this issue under gssoc tag and level 2 label.


Javascript error when nested sortable

Currently it seems that with dragula hard to create nested sortable. I tried to create simplest example:
https://codepen.io/anon/pen/EPjjvr
Nothing more but when I drag item3 I get js error:
 Uncaught HierarchyRequestError: Failed to execute 'insertBefore' on 'Node': The new child element contains the parent.

P.S;
Also no api methods available as I see for control draggable items, draggable places (where to drop) and other.

#248

Same error here, can't find any info regarding this.


Approval labeler fix electric boogaloo

Nik told me to not name this "nya"
Ok pjb fixed it maybe uwu idk merge upstream to a pr and find out
Also the pat token needs to be renewed every year nya

Giving me more work smh

*buzz *ping *aflap

:3

:3

pjbot rogue. Please ban


feat: Allow customization for BelongsToSelect label

As discussed on Discord this allows to easily set a label for the BelongsToSelect without overwriting the whole getSearchResultsUsing() and getOptionLabelUsing() callbacks.
Outlook
This could also applied to BelongsToManyMultiSelect and BelongsToManyCheckboxList . Both are missing the searchable() method or $searchColumns property this feature relies on. While it makes sense to add this to BelongsToManyMultiSelect there is no search on BelongsToManyCheckboxList and we need to define the fields for the SELECT statement differently.

Thanks for your additions and merging!


Recieving response multiple times

I am listening event in Viewdidload method.each time view did load get called it adds a listener and receiving response incremented by 1.Please tell me its fixture
here is my code
override func viewDidLoad() {
SocketHelper.sharedHelper().theSocket().emit("EventName", args:[jsonInput])
self.listenEventResponse()
}
func listenEventResponse(){
SocketHelper.sharedHelper().theSocket().on("EventName") { (dataArr:[AnyObject]!) -> Void in
let jsonDictionary = (dataArr as NSArray).objectAtIndex(0)
print(jsonDictionary)
// Here i get printed output multiple times each time added once more
}
}

Could I have a look on SocketHelper.sharedHelper() implementation ?


Suspected presence of actuator push forces

Hi,
First of all, thank you very much for the amazing work you are doing with MyoSuite; I am trying to adopt it for my research activity.
I am opening this issue because I encountered something I did not expect. Maybe it is a problem, or maybe I misunderstood something.
I was investigating the various data and attributes of the model and, plotting the env.sim.data.actuator_force attribute while MyoHand was posing ✌, I noticed that the actuator force related to muscle RI5 resulted in positive values. I was expecting only negative values (pull forces) or zeros. Also, it is not clear to me why the env.sim.model.actuator_forcerange attribute is always equal to [0,0].
The used code is reported below, and the trained policy is attached victory_policy3_1M.zip, so that the case study can be reproduced.
Thank you
from matplotlib import pyplot as plt
from stable_baselines3 import PPO
import numpy as np
import myosuite
import gym

""" LOAD ENVIRONMENT """
env = gym.make('myoHandPoseFixed-v0', normalize_act=False)
env.reset()

""" LOAD POLICY """
policy = "victory_policy3_1M.zip"
pi = PPO.load(policy)

""" TARGET SETTING """
targetAngles = [env.sim.model.jnt_range[0][1],  # pro_sup
                0,                              # deviation
                env.sim.model.jnt_range[2][0],  # flexion
                env.sim.model.jnt_range[3][0],  # cmc_abduction
                env.sim.model.jnt_range[4][0],  # cmc_flexion
                env.sim.model.jnt_range[5][0],  # mp_flexion
                env.sim.model.jnt_range[6][0],  # ip_flexion
                env.sim.model.jnt_range[7][0],  # mcp2_flexion
                np.mean(env.sim.model.jnt_range[8]),  # mcp2_abduction
                env.sim.model.jnt_range[9][0],  # pm2_flexion
                env.sim.model.jnt_range[10][0], # md2_flexion
                env.sim.model.jnt_range[11][0], # mcp3_flexion
                env.sim.model.jnt_range[12][0], # mcp3_abduction
                env.sim.model.jnt_range[13][0], # pm3_flexion
                env.sim.model.jnt_range[14][0], # md3_flexion
                env.sim.model.jnt_range[15][1], # mcp4_flexion
                env.sim.model.jnt_range[16][1], # mcp4_abduction
                env.sim.model.jnt_range[17][1], # pm4_flexion
                env.sim.model.jnt_range[18][1], # md4_flexion
                env.sim.model.jnt_range[19][1], # mcp5_flexion
                env.sim.model.jnt_range[20][1], # mcp5_abduction
                env.sim.model.jnt_range[21][1], # pm5_flexion
                env.sim.model.jnt_range[22][1]  # md5_flexion
]
env.env.target_jnt_value = np.array(targetAngles)
env.env.target_type = 'fixed'
env.env.update_target()

""" RENDERING OPTIONS """
env.mj_render()
# set minimal rendering
env.sim.renderer._window.opt.flags[0:-1] = 0
env.sim.renderer._window.opt.flags[[4,7,21]] = 1 # keep only actuator (4), tendon (7), static body (21)
env.sim.renderer._window.opt.geomgroup[1:-1] = 0 # keep only the skeleton
env.sim.renderer._window.opt.sitegroup[0:-1] = 0 # remove sites
env.sim.renderer._window.scn.flags[0:-1] = 0 # remove shadows, reflections, etc.
# camera orientation
env.sim.renderer._window.cam.distance = 0.67
env.sim.renderer._window.cam.azimuth = 90
env.sim.renderer._window.cam.elevation = -10.24
# model position within the screen
env.sim.renderer._window.cam.lookat[0] = -0.1266
env.sim.renderer._window.cam.lookat[1] = -0.1843
env.sim.renderer._window.cam.lookat[2] = 1.364

""" MAIN LOOP """
actuator_force = np.zeros_like(env.sim.data.actuator_force)
for _ in range(3):
    env.reset()
    done = False
    all_rwd = []
    ii = 0
    while not done or ii<100:
        o = env.get_obs()
        a = pi.predict(o)[0]
        next_o, r, done, info = env.step(a)
        actuator_force = np.vstack((actuator_force, env.sim.data.actuator_force))
        ii += 1
env.close()

""" DATA PLOTTING """
musclesList = ['ECRL', 'ECRB', 'ECU', 'FCR', 'FCU', 'PL', 'PT', 'PQ', 'FDS5', 'FDS4', 'FDS3', 'FDS2', 'FDP5',
               'FDP4', 'FDP3', 'FDP2', 'EDC5', 'EDC4', 'EDC3', 'EDC2', 'EDM', 'EIP', 'EPL', 'EPB', 'FPL', 'APL',
               'OP', 'RI2', 'LU_RB2', 'UI_UB2', 'RI3', 'LU_RB3', 'UI_UB3', 'RI4', 'LU_RB4', 'UI_UB4', 'RI5', 'LU_RB5', 'UI_UB5']
# fig, ax = plt.subplots(); ax.imshow(actuator_force.T, aspect='auto'); ax.set_title('actuator_force'); ax.set_xlabel('timesteps'); ax.set_yticks(np.arange(len(musclesList)), labels=musclesList); fig.show()
fig, ax = plt.subplots(); ax.imshow((actuator_force.T>0), aspect='auto'); ax.set_title('actuator_force'); ax.set_xlabel('timesteps'); ax.set_yticks(np.arange(len(musclesList)), labels=musclesList); fig.show()
input()

I tried something like this at my end. I can confirm that I see occasional +ve signals in quite a few of the models. I'll need to dig deeper. Will keep this thread updated as I make progress.
Thanks for flagging this @andreh1111

Hi @vikashplus, I jumped back on this issue because I have often noticed positive forces on muscle RI5. Looking at the Force-Length-Velocity (FLV), in particular to the muscle active force (i.e., muscle gain), the problem lies in the length curve contribution (FL). Indeed, gain is computed as -F0 * FL * FV and is expected to be negative, but FL often results in negative values for RI5, so the result becomes positive. Below is a simple example in which ctrl is set equal to 1 for FDS5 and RI5 in a short 500-step simulation.
import matplotlib.pyplot as plt
import numpy as np
import mujoco

model = mujoco.MjModel.from_xml_path('<your_path>/myohand.xml')
muscle_names = [model.actuator(i).name for i in range(model.nu)]
data = mujoco.MjData(model)
data.ctrl[muscle_names.index('FDS5')] = 1
data.ctrl[muscle_names.index('RI5')] = 1

N = 500
all_actuator_force = np.zeros((N, model.nu))
all_actuator_length = np.zeros((N, model.nu))
all_actuator_gain = np.zeros((N, model.nu))
all_actuator_bias = np.zeros((N, model.nu))

for n in range(N):
    mujoco.mj_step(model, data)
    all_actuator_force[n,:] = data.actuator_force
    all_actuator_length[n,:] = data.actuator_length
    for i in range(model.nu):
        length = data.actuator_length[i]
        lengthrange = model.actuator_lengthrange[i]
        velocity = data.actuator_velocity[i]
        acc0 = model.actuator_acc0[i]
        prmb = model.actuator_biasprm[i,:9]
        prmg = model.actuator_gainprm[i,:9]
        all_actuator_gain[n,i] = mujoco.mju_muscleGain(length, velocity, lengthrange, acc0, prmg)
        all_actuator_bias[n,i] = mujoco.mju_muscleBias(length, lengthrange, acc0, prmb)

fig, axs = plt.subplots(5, 8, figsize=(16, 10))
axs = axs.flatten()
for i in range(len(muscle_names)):
    ax = axs[i]
    line1, = ax.plot(all_actuator_force[:,i])
    ax.set_title(muscle_names[i])
legend_ax = axs[len(muscle_names)]
legend_ax.axis('off')
labels = ['actuator force']
legend_ax.legend([line1], labels, loc='center')
plt.tight_layout()
plt.show()

fig, axs = plt.subplots(5, 8, figsize=(16, 10))
axs = axs.flatten()
for i in range(len(muscle_names)):
    ax = axs[i]
    line1, = ax.plot(all_actuator_gain[:,i])
    line2, = ax.plot(all_actuator_bias[:,i])
    ax.set_title(muscle_names[i])
legend_ax = axs[len(muscle_names)]
legend_ax.axis('off')
labels = ['gain', 'bias']
legend_ax.legend([line1,line2], labels, loc='center')
plt.tight_layout()
plt.show()

As you can see from the first plot there are multiple peaks of positive force for RI5. From the second plot you can see that active muscle force is responsible. Looking deeper the computation of FL (https://github.com/google-deepmind/mujoco/blob/42515033a7ffcc68f8cb45faba7714910e99ffee/src/engine/engine_util_misc.c#L487), I think I have a clue to the source of the error. In the code below I simply copied the computation of FL for RI5 when a positive actuator force is present.
n_positive, _ = np.where(all_actuator_force > 0)
idx_RI5 = muscle_names.index('RI5')
length_RI5 = all_actuator_length[n_positive[0],idx_RI5]
lengthrange_RI5 = model.actuator_lengthrange[idx_RI5]
range_RI5 = model.actuator_gainprm[idx_RI5][:2]
lmin_RI5 = model.actuator_gainprm[idx_RI5][4]
lmax_RI5 = model.actuator_gainprm[idx_RI5][5]

a = 0.5*(lmin_RI5+1)
b = 0.5*(1+lmax_RI5)
L0 = (lengthrange_RI5[1]-lengthrange_RI5[0]) / (range_RI5[1]-range_RI5[0])
L = range_RI5[0] + (length_RI5-lengthrange_RI5[0]) / L0

FL = 0
if (L >= lmin_RI5 and L <= a):
    x = (L-lmin_RI5) / (a-lmin_RI5)
    FL = 0.5*x*x
elif (L <= 1):
    x = (1-L) / (1-a)
    FL = 1 - 0.5*x*x
elif (L <= b):
    x = (L-1) / (b-1)
    FL = 1 - 0.5*x*x
elif (L <= lmax_RI5):
    x = (lmax_RI5-L) / (lmax_RI5-b)
    FL = 0.5*x*x

print(f'Actuator length = {length_RI5}, length range = {lengthrange_RI5}, L = {L}, FL = {FL}')

You can see that the actuator length is smaller than the minimum value of the length range and L is even negative, so the second else if of the sequence is the chosen one. However, the else if sequence present in the computation of FL does not take the eventuality of having length outside the length range into account. In fact, in my opinion, the second else if (line 492) should be L > a && L <= 1, and the third (line 495) L > 1 && L <= b, so that if the length was out of the range, FL would be 0.
Let me know what you think about it.

Wow, thanks for this great investigation!
we also occasionally encountered positive forces in our own experiments, also when the muscle length is outside the proper ranges. But we didn‘t trace it back to the FL yet, good find!
These lengthrange violations can always happen in MuJoCo, as all constraints are considered soft.
The if-else clause is however something that should imho be fixed, it looks like a straightforward bug.
I personally think a PR to mujoco itself would be appropriate.
@Vittorio-Caggiano @vikashplus
Opinions?

I haven't tried the code but if I am following the logic properly this seems sensible. Perhaps @P-Schumacher can double-check the calculation and we can file a PR in MuJoCo. This should be fixed at the MuJoCo level. We can CC this thread in that PR

I‘ll double check the fix in the next few days and update here.
i know the function, so it shouldn‘t be too much work

Hey @andreh1111  I will look at this more in detail today and tomorrow. Are you compiling mujoco with the updated function? Have you gathered any insights that could help me check this?

Indeed, the issue is when a muscles compresses beyond the minimum length and the FL muscleGain function runs into a bug in the if-else clause. Really good find!
I plotted the active part of the FL with the FL in blue, the maximum/minimum muscle length ranges in dashed black and the actually achieved muscle lengths in red

We can clearly see that the muscle length relationship becomes negative, which forces the muscle to produce lengthening forces, which it should not be able to do.
Fixing the if-else clause with the first two lines here in the mujoco muscleGain function:
 if L < lmin_RI5:
     return 0
 elif (L >= lmin_RI5 and L <= a):
     x = (L-lmin_RI5) / (a-lmin_RI5)
     return 0.5*x*x
 elif (L <= 1):
     x = (1-L) / (1-a)
     return 1 - 0.5*x*x
 elif (L <= b):
      x = (L-1) / (b-1)
      return 1 - 0.5*x*x
 elif (L <= lmax_RI5):
      x = (lmax_RI5-L) / (lmax_RI5-b)
      return 0.5*x*x

fixes the issue.
See:

This also prevents the jittering of muscle length issue that has been happening in some muscle configurations. I.e. even for constant activation on all muscles, we got pattern like in the video on the right, which are now fixed on the left.
For this video, I implemented the fix and recompiled mujoco before I set the FDS5 and RI5 muscles to excitations=1.
https://github.com/MyoHub/myosuite/assets/24903880/5c5e0277-463f-4662-8e30-dc79c79df12b
I will create a PR for mujoco itself.

The PR has been accepted by the MuJoCo team and committed to their GitHub repo. The next MuJoCo release will contain the bugfix.


Cannot register "capture" phase event handlers

🐛 Bug description

Event handlers using onXXX={withModifiers(..., ["capture"])} are not registered in "capture" mode.
📝 Steps to reproduce

Attempt to register an event handler using the readme's suggested syntax of withModifiers
Reproduction Link (required):
https://stackblitz.com/edit/vitejs-vite-c3hwy2?file=src%2FApp.vue,index.html
🏞 Desired result
Event handlers can be registered in capture mode.

🚑 Other information
https://github.com/vuejs/babel-plugin-jsx/issues/533

onClickCapture works but there aren't typings for it, so TSC kicks it out. This leaves us with the workaround
<div {...{onClickCapture: evt => {}}}>...</div>

Maybe we types can be added for *Capture suffixed events?


[Select] Forward onClick event to menuItem

fix #20709

[X ] I have followed (at least) the PR section of the contributing guide.

@marcosvega91 Thanks for the test case :)

@oliviertassinari i add test for everything hahaahha


Transactional Data Reimport Test

Create a Test notebook responsible to examine the following cases:

Reimport Openings for DataNode at Inception
Reimport Actuals for Both: DataNode at Inception and DataNode and Not at Inception
Import Actuals for Pre-exisitng Reinsurance, Openings for Linked Insurance and Cashflows for the Reinsurance
Import Cashflows for Pre-exisitng Reinsurance, Openings for Linked Insurance and Cashflows for the Reinsurance
Import Modified Openings with CSM Deletion and LC Addition for DataNode at Inception

This PR closes issue #140.

Suggestion by @dcolleoni: the cases listed in issue #140 should be split into two different Tests (Reimport Test and ImportStorageTest).


Rotational gizmo should not render its backside

Godot version:
v3.0.stable.official
OS/device including version:
Windows10
Issue description:
The rotational gizmo should be enough with the frontside rings to manipulate the rotation.
The backside ring is simply redundant to make the operation confused.
See the following images for the rotational gizmos from 3dsmax and Blender.

Steps to reproduce:
Select an entity then switch the gizmo for rotation

That's a great idea, it's a lot more readable

And as it stands the different rings interfere with each other and in many instances its hard to actually select the one you want.

I'm looking to tackle a couple issues for a software engineering class I'm in currently and am hoping to hit some of the posts on the recommended page.
Is this a feature that does have interest? I don't want to make changes without checking in, seeing as this was posted quite a while ago.

@elijahscherz There still seems to be interest in this feature, so I think it's worth implementing it.

@Calinou - excellent. Thanks for giving me a place to start! If I have any further questions or get stuck, I'll reach out.

@Calinou (or whoever is available) I checked into this further and found the following -
I was able to modify the material for the rotation portion of the gizmo, setting the CullMode to CULL_BACK, unfortunately it didn't produce the expected results. The gizmo didn't look visibly different, but I do know I was modifying the material for it, as I was able to change the color.
Ref<StandardMaterial3D> rot_mat = memnew(StandardMaterial3D);
...
rot_mat->set_cull_mode(StandardMaterial3D::CULL_BACK);
rot_gizmo_color[i] = rot_mat;

surftool->set_material(rot_mat);
surftool->commit(rotate_gizmo[i]);

Ref<StandardMaterial3D> rot_mat_hl = rot_mat->duplicate();
rot_mat_hl->set_albedo(Color(col.r, col.g, col.b, 1.0));
rot_gizmo_color_hl[i] = rot_mat_hl;

From what I can tell, maybe based on how the system draws / renders the polygons, they aren't considered back facing in the back of the gizmo because they are just made using circles (not a modified sphere).
Additionally, I can see that this code which "commits" the material is only run three times (once for each axis I expect). The gizmo itself isn't re-rendered, shifted, or modified some way when the user moves the viewport. This could visual issues like if you use CULL_BACK on another part of the gizmo, somewhat solidifying that a culling mode change sadly won't accomplish what we want.
Three scaling planes.

Only one scaling plane rendered.

Like you said, potentially not trivial. Seems like maybe this would involve working on a more dynamic gizmo. I would be happy to work on this further, but might need a bit more direction / advice to get going. (If you think this is something that is doable, that is.)

@elijahscherz are you still working on this? If not I'm willing to pick it up

@SekoiaTree feel free to take a look, I haven't done anything on it in a while because I didn't know where to continue next beyond my findings above. All yours.

well, I've made a bit of progress. I recreated the code in editor, so now I can tell what the issue is. Apparently, CULL_BACK actually does do something. If you move the inside the disk, you can see that culling is applied. I thought there wasn't an interior, looking at the wireframe, but I was wrong apparently. ¯\_(ツ)_/¯

https://github.com/godotengine/godot/pull/41765
Done!

There's a merged PR for this issue: https://github.com/godotengine/godot/pull/42094
I think it's safe to close it.

You are right, thanks!
Solved by #42094


No module named 'stanfit4anon_model_77e4c4162fb1......

I have installed both pystan and fbprophet successfully on my machine. But, When I give import fbprophet, It is showing an error:
WARNING:pystan:No module named 'stanfit4anon_model_9c941523472e65f75f241e35a8769919_4289282227191412751' WARNING:pystan:Something went wrong while unpickling the StanModel. Consider recompiling.
WARNING:pystan:No module named 'stanfit4anon_model_77e4c4162fb17d5855e6b726b68bdd0c_4498328616688083170' WARNING:pystan:Something went wrong while unpickling the StanModel. Consider recompiling.
I'm using:
PyStan Version: <IP_ADDRESS>
Python Version: 3.6.1
Operating System: Windows 10
Please explain how to fix this. Thanks!

Sorry, but anybody knows why this is happening?

I wonder if this might be related to #249. Are you getting any other warnings or errors associated with this?

Thanks for the response.
No, Just this one no other warnings or anything.

@bletham Hi, I reinstall MS Build tools and finally it worked. Thanks

Wonderful, thanks for the tip!


first draft Quick Start re-write

This first pass at the Quick Start Guide has the following outages:

In Step 4 c, the command to configure Traefik to manage Ingresses created in the domain namespace.
In Step 5. Create a domain in the domain namespace, I need the the commands or exact procedures for all the substeps:
a. Create a new image with a domain home by running the create-domain-in-image script.
b. Use kubectl apply -f on the YAML file to create the domain resource.
c. Confirm that the operator started the servers for the domain by using kubectl.
Use kubectl to show that the domain resource was created.
Look at the operator log.
d. Create an Ingress for the domain, where are they specifying the domainUID and domain namespace?
e. Confirm that the load balancer noticed the new Ingress and is successfully routing to the domain's server pods.
In Step 6. Remove the domain, I need the the commands or exact procedures for all the substeps.
In Step 7a, I need the the command or exact procedure for configuring the Traefik load balancer to stop managing the Ingresses in the domain namespace.

Thank you.

Overall comment - a lot of places say to use 'kubectl' to verify stuff.  Do we want to show the specific kubectl commands?   Are you planning to add that later?


DEV-101 MVP/ME Migrate to hooks based form solution

Please also check the error that I mentioned: can't access lexical declaration 'propsRef' before initialization


Cannot find "Sniff Intents" apk file

I am looking at "Intent Sniffing" walkthrough, but I cannot find the "Sniff Intents" apk file anywhere.

Here is the code to build the apk - https://github.com/dineshshetty/Android-InsecureBankv2/tree/master/wip-attackercode/SniffIntents


undefined method `[]' for nil:NilClass when using Job.position

This line in my seeds file threw an error
position = Faker::Job.position
console error log is

NoMethodError: undefined method []' for nil:NilClass /home/gerry/.rvm/gems/ruby-2.2.6@lapem/bundler/gems/faker-679fd508c9f4/lib/faker.rb:182:in method_missing'
/home/gerry/Documents/lapem-cfe/db/seeds/development/users.seeds.rb:15:in `block in evaluate'

Last line and the rest is just part of my application, which unless there's something I'm not considering, probably isn't necessary to post here

This error occurs when the locale .yml translation file contains no entries for the word.
Faker should default to "en" when there are no entries, but that does not happen here. The code in the "job" class is much simpler than other classes and does not call translate.
One possible quick fix is to include Faker::Config.locale = "en" in your seed if that is acceptable.
Another option is to add entries for jobs to your locale .yml file.

I have created a patch and pull request to fix upstream here: #1142

This PR was merged successfully 💯


A new little page which use the fine barba.js -:)

https://mohr-dachbau.de/

Is this an actual issue ?


Config change after deployment does not update Grafana dashboard

Bug Description
Changing the configuration (e.g. grafana_dashboards) does not update the Grafana dashboard. This seems to be due to the fact that the dashboard is only updated during an install or upgrade event:
https://github.com/canonical/cos-configuration-k8s-operator/blob/051e1461430edb2d342f8b2088a79d363fd02140/lib/charms/grafana_k8s/v0/grafana_dashboard.py#L1051-L1052
As a user, I would expect the dashboard data to be updated when the configuration is changed.
To Reproduce

juju deploy --trust grafana-k8s grafana
juju deploy cos-configuration-k8s --config git_repo=https://github.com/canonical/github-runner-operator --config git_branch=main
juju config cos-configuration-k8s grafana_dashboards_path=src/grafana_dashboard_metrics
juju relate cos-configuration-k8s:grafana-dashboards grafana:grafana-dashboard
juju show-unit grafana/0   --format json   | jq '."grafana/0"."relation-info"'

The last command shows an empty dashboard in the integration data. It would not be empty if the configuration value grafana_dashboards_path=src/grafana_dashboard_metric had been passed at deployment time.
Environment
Juju (tested with 3.1 and 2.9) within multipass using microk8s.
Relevant log output
nit-cos-configuration-k8s-0: 14:14:25 INFO unit.cos-configuration-k8s/0.juju-log git-sync: I1012 12:14:24.881140     135 main.go:473] "level"=0 "msg"="starting up" "pid"=135 "args"=["/git-sync","--repo","https://github.com/canonical/github-runner-operator","--branch","main","--rev","HEAD","--depth","1","--root","/git","--dest","repo","--one-time"]
unit-cos-configuration-k8s-0: 14:14:25 INFO juju.worker.uniter.operation ran "config-changed" hook (via hook dispatching script: dispatch)
unit-cos-configuration-k8s-0: 14:14:40 INFO juju.worker.uniter.operation ran "grafana-dashboards-relation-created" hook (via hook dispatching script: dispatch)
unit-grafana-0: 14:14:42 INFO unit.grafana/0.juju-log grafana-dashboard:39: Restarted grafana-k8s
unit-grafana-0: 14:14:43 INFO juju.worker.uniter.operation ran "grafana-dashboard-relation-changed" hook (via hook dispatching script: dispatch)
unit-grafana-0: 14:14:43 INFO juju.worker.uniter.operation ran "grafana-dashboard-relation-joined" hook (via hook dispatching script: dispatch)
unit-grafana-0: 14:14:44 INFO juju.worker.uniter.operation ran "grafana-relation-changed" hook (via hook dispatching script: dispatch)
unit-grafana-0: 14:14:45 INFO unit.grafana/0.juju-log grafana-dashboard:39: HTTP Request: GET https://<IP_ADDRESS>/apis/apps/v1/namespaces/observability/statefulsets/grafana "HTTP/1.1 200 OK"
unit-grafana-0: 14:14:45 INFO unit.grafana/0.juju-log grafana-dashboard:39: HTTP Request: GET https://<IP_ADDRESS>/api/v1/namespaces/observability/pods/grafana-0 "HTTP/1.1 200 OK"
unit-grafana-0: 14:14:45 INFO unit.grafana/0.juju-log grafana-dashboard:39: reqs=ResourceRequirements(claims=None, limits={}, requests={'cpu': '0.25', 'memory': '200Mi'}), templated=ResourceRequirements(claims=None, limits=None, requests={'cpu': '250m', 'memory': '200Mi'}), actual=ResourceRequirements(claims=None, limits=None, requests={'cpu': '250m', 'memory': '200Mi'})
unit-grafana-0: 14:14:45 INFO unit.grafana/0.juju-log grafana-dashboard:39: HTTP Request: GET https://<IP_ADDRESS>/apis/apps/v1/namespaces/observability/statefulsets/grafana "HTTP/1.1 200 OK"
unit-grafana-0: 14:14:45 INFO unit.grafana/0.juju-log grafana-dashboard:39: HTTP Request: GET https://<IP_ADDRESS>/api/v1/namespaces/observability/pods/grafana-0 "HTTP/1.1 200 OK"
unit-grafana-0: 14:14:45 INFO unit.grafana/0.juju-log grafana-dashboard:39: Initializing dashboard provisioning path
unit-grafana-0: 14:14:46 INFO unit.grafana/0.juju-log grafana-dashboard:39: Restarted grafana-k8s
unit-grafana-0: 14:14:46 INFO juju.worker.uniter.operation ran "grafana-dashboard-relation-changed" hook (via hook dispatching script: dispatch)
unit-grafana-0: 14:14:47 INFO juju.worker.uniter.operation ran "grafana-relation-changed" hook (via hook dispatching script: dispatch)

Additional context
No response

I'm not sure that that is the issue, because while the relation provider class is in fact only doing that 'automatically' on install and upgrade, the charm itself is doing that in its common exit hook (https://github.com/canonical/cos-configuration-k8s-operator/blob/051e1461430edb2d342f8b2088a79d363fd02140/src/charm.py#L162C22-L162C22)
which is triggered, among other things, on config-changed.
So there must be something else going on. Perhaps a bug in the hashing?

Thanks @PietroPasotti for the quick reply. It seems that the update of the boards is not triggered if the git hash does not change, which is indeed true in this case because the config grafana_dashboards is independent of the hash.
https://github.com/canonical/cos-configuration-k8s-operator/blob/051e1461430edb2d342f8b2088a79d363fd02140/src/charm.py#L363

We should probably just always update on config-changed.

The issue isn't reproducible when following the original steps and the updated dashboards path in the github-runner-operator (grafana_dashboards_path=src/grafana_dashboards).
However, the issue arises if step 4 is performed before step 3 in the reproduction steps (i.e., relating to Grafana before setting the grafana_dashboards_path config). The fix for this issue is addressed in https://github.com/canonical/grafana-k8s-operator/pull/335

should be fixed by #98


Questions about document handling.

I want to know what changes have been made to the two CSV files（audio_test.csv、audio_train.csv ）（in data/s2e/） to generate modified_ df_ test. csv、modified_ df_ train. csv ？
Because I met a mistake using 'torch.LongTensor(data[1])' directly for the original two CSV files when run lstm_classfier.py . And you didn't tell us how to generate the two new CSV file.

The modified version oversamples data points for surprise and fear (as they are underrepresented). A 90/10 train/test split is then created.

I was faced with the same problem as chenyu-I, and I did the split, and got modified_ df_ test. csv、modified_ df_ train. csv. but there's another problem: too many dimensions 'str' when running the lstm_classifier.

@llitmus could you paste the full error log? It's difficult to for me to assist otherwise.

This is my error
when running the lstm_classifier. Something wrong in utils.py. Maybe I did the split false.
ValueError                                Traceback (most recent call last)
~/multimodal-speech-emotion-recognition-master/lstm_classifier/s2e/lstm_classifier.py in
49     optimizer = optim.Adam(model.parameters(), lr=config['learning_rate'])
50
---> 51     train_batches = load_data()
52     test_pairs = load_data(test=True)
53
~/multimodal-speech-emotion-recognition-master/lstm_classifier/s2e/utils.py in load_data(batched, test, file_dir)
28             output_batch.append(e[1])
29         batches.append([torch.FloatTensor(input_batch),
---> 30                         torch.LongTensor(output_batch)])
31     return batches
32
ValueError: too many dimensions 'str'
This is my split code. I add it in the 4th .ipynb
modified_df_train,modified_df_test = train_test_split(df, test_size=0.10)
modified_df_train.to_csv('../data/s2e/modified_df_train.csv', index=False)
modified_df_test.to_csv('../data/s2e/modified_df_test.csv', index=False)

print(modified_df_train.shape, modified_df_test.shape)

the output is alright .
(1913, 10) (213, 10)
And I'm trying to use data/s2e/audio_train.csv in the lstm_classifier but failed either
Thank u so much!

@Demfier I sovled the problem! just delete the 'wav_file' col of the modified_df_train and that  works!^-^ Anyway, thank u so much!

Oh! I just sovled the problem by droping the col 'wav_file' .hhh.
But there's a loss of  predit_proba.py .hhh in s2e. I copied the combined predit py ^-^
Anyway,thanks a lot!

@llitmus  could you please help me how did you solve the problem?
i have same issue?
did you create modified data frames for train and test from modified_df.csv file ?
or you used audio_train.csv and audio_test.csv instead of modified dataframe?

Oh! I just sovled the problem by droping the col 'wav_file' .hhh. But there's a loss of predit_proba.py .hhh in s2e. I copied the combined predit py ^-^ Anyway,thanks a lot!

sorry to bother you, i also meet the same problem, would you mind sharing your csv files?

Hi,
You can access the preprocessed data files here: https://www.dropbox.com/scl/fo/jdzz2y9nngw9rxsbz9vyj/h?rlkey=bji7zcqclusagzfwa7alm59hx&dl=0
Hope this helps!

thank u very much，this helps me a lot
---- Replied Message ----
From Gaurav @.> Date 10/27/2023 11:14 To Demfier/multimodal-speech-emotion-recognition @.> Cc @.>,
Comment @.> Subject Re: [Demfier/multimodal-speech-emotion-recognition] Questions about document handling. (Issue #31)
Hi,
You can access the preprocessed data files here: https://www.dropbox.com/scl/fo/jdzz2y9nngw9rxsbz9vyj/h?rlkey=bji7zcqclusagzfwa7alm59hx&dl=0
Hope this helps!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


ecrecover soundness (address not recovered)

Description
Ecrecover "address not recovered" case to be supported by SigCircuit.
Key Changes

SigCircuit processes all ecrecover inputs except:

sig_r overflowing (not canonical)
sig_s overflowing (not canonical)
The 2 above cases are handled directly in EVM circuit by the ecrecover gadget

We add more tests for SigCircuit to check panic issues because of these edge cases

msg_hash == 0
sig_r == 0
sig_s == 0
sig_v == invalid (not boolean)
address could not be recovered

EVM Circuit's ecrecover gadget does a lookup to SigTable in all cases except:

sig_r overflowing (not canonical)
sig_s overflowing (not canonical)

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

we may need to change the par_bridge into something like this
TEST_VECTOR
    .par_iter() // parallelize TEST_VECTOR
    .for_each(|test| {
        for kind in &call_kinds {
            // call_kinds is sequential
            test_one(test, kind);
        }
    });


Create game state to track score

Improvement: Create game state to track score
The game state has fields and methods to track the current and total amount of coins.
When a coin is added to the scene at runtime it calls a method to update the global state. If the player gets the coin it calls another method to increase the score, this method then emits a signal with is connected to the functions that update the ui score.
Closes #6

Looks good to me, thanks for the PR :)


[Question] How to decoration clip on chart

I want to create something like the first image.
However, when it exceeds the chart area, it doesn't get drawn completely.  (Second Image)
How can I draw the circles on both sides entirely?
[I Wish]

[Current Outcome]

Hello! I’m afraid this isn’t supported at the moment, but we’ll be looking into making it possible.


Indepth check of curie based on rel name

@mikekelly  Currently if you have a hal+json payload with a curies section there are not problems.
{
  "_links": {
    "curies": [
      {
        "name": "fx",
        "href": "https://api.foxycart.com/rels/{rel}",
        "templated": true
      }
    ],
    "self": {
      "href": "https://api-sandbox.foxycart.com/",
      "title": "Your API starting point."
    },
    "fx:property_helpers": {
      "href": "https://api-sandbox.foxycart.com/property_helpers",
      "title": "Various helpers used for determining valid property values."
    }
}

If you have an API with prefixes but have not yet added a curies section, the doc URIs fail to build and the page does not render.
This PR enables requests without a curies block but with name spaced resources to exist like below.
{
  "_links": {
    "self": {
      "href": "https://api-sandbox.foxycart.com/",
      "title": "Your API starting point."
    },
    "fx:property_helpers": {
      "href": "https://api-sandbox.foxycart.com/property_helpers",
      "title": "Various helpers used for determing valid property values."
    }
}

thanks 👍
not sure whether this is a feature or a bug..!


website: mixed content warning on talks.golang.org

Mixed Content: The page at 'https://talks.golang.org/' was loaded over a secure connection, but contains a form which targets an insecure endpoint 'http://golang.org/search'. This endpoint should be made available over a secure connection.

https://go-review.googlesource.com/11534


export tls key by runtime configuration

Commit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

/retest

/retest

/retest

/retest

@davinci26 , do you have any plan for the API ?

/reopen

@zhangbo1882 I think the ball is in your court to design/propose an api change for this feature. I gave some recommendations above so I hope it helps. If you have any specific questions feel free to ask.

@davinci26 ,  I think this feature is not a global static configuration. I just want to enable it for specify source and dest ip address as required.  That's why I  think it is better to use runtime configuration.

reopen the PR in #19182


TSX syntax is broken after as statement

VSCode Version: 1.3.0
OS Version: Windows Server 2012

Steps to Reproduce:

See the propertyPane syntax is gray out.

Remove the as ReactElement statement, the propertyPane syntax is OK.

Duplicate with issue #8045

@KalleOtt Thank you! I am closing this one.


Add frontend build steps to pypi workflow

What type of PR is this? (check all applicable)

[ ] Refactor
[X] Feature
[ ] Bug Fix
[ ] Optimization
[ ] Documentation Update
[ ] Community Node Submission

Have you discussed this change with the InvokeAI team?

[X] Yes
[ ] No, because:

Have you updated all relevant documentation?

[X] Yes
[ ] No

Description
This PR adds the steps to the pypi release workflow needed to install pnpm dependencies and build the frontend so that it gets incorporated into the .whl file. I don't actually know how to test these github workflows, so I'm posting this in draft form.
Related Tickets & Documents

Related Issue #
Closes #

QA Instructions, Screenshots, Recordings

Merge Plan
This can be merged after testing.

Added/updated tests?

[ ] Yes
[ ] No : please replace this line with details on why tests
have not been included

[optional] Are there any post deployment tasks we need to perform?

Duplicate of #5298


🚀 run builds on github action runner

Closes https://github.com/robertsLando/pkg-binaries/issues/11

todo:  yaml syntax error in filter line


Make the second factor selectable. A user should not be forced to use the first one.

A user can not currently select from several set up 2nd factors. I just noticed this when reviewing #578, after I had tested #802 the days. In this loop the first 2FA that would be usable is always selected, and the user has to continue the login with that. The order is ultimately set by the developer.
This should actually return a list of all methods possible for the user, then the user can select one and continue the login flow with it.
Until this is solved, we don't even need to start implementing backup codes. After all, you want to be able to select them when needed.

Isn't this part of #816 as well?

Isn't this part of #816 as well?

Hmm. The one point can be interpreted like this. I have overseen it. I formulated it more clearly, I hope that was okay.
Then I close this issues as a (partial) duplicate of #816


Fix INHERIT_ONLY_ACE false positive when AceType == 0

An ACE that applies only to descendant objects will also be reported as applying to the object where it is located. This is due to the missing INHERIT_ONLY_ACE condition when the AceType is 0.
Steps to Reproduce

Select a principal and an object where the principal has no privileges on it, such as an OU.
On the OU, add an ACE for the principal with privileges GENERIC_ALL that applies only to descendant objects.
Collect the data and import it into BloodHound.
Query for relationships between the principal and the OU. The principal will be shown as having GenericAll over the OU when in reality it only applies to descendant objects.

Good catch. Could you submit this PR with a signed commit? (either by signing the commit locally or editing it via github?) then I can merge the change in

Done!

Awesome, merged :)


Fix doc comment typo in PackageDescription.Version

Corrects a typo in the doc comments for the major version number in PackageDescription.Version

@swift-ci please smoke test


Fix scroll issue

When a header is clicked, it navigates to the right section. However, the section loaded is little off, causing the previous section to be highlighted instead of the selected section.

Fixed via commit: https://github.com/SilleBille/web-portfolio/commit/4356787cf20e57607808c1ab51fa718ef0e6ff12


[Update] To account for all 0 in FID

It's just a simple change to use the data.table function. The original paste will fail for inputs with FID containing only 0.
E.g.
IID <- replicate(1000,paste(sample(LETTERS,6,  replace=T), sep="", collapse = ""))
test <- data.frame(FID=0, IID=names)
keep <- paste(test[,1], test[,2], sep=".")
keep.by.id <- paste(test$FID, test$IID, sep=".")
print(sum(keep%in%keep.by.id))

And you will get 0.
As we don't know if the user input contain FID or IID, we will need some other way to handle this

Thanks! I haven't had time to verify this issue, but I trust you're right.


Select bug

There's a bug when using hold-click to select in the Note Timeline where the selection box and what is selected is not accurate to the hold-click movement.
Step to reproduce:

Click anywhere inside the Note Timeline window, let's call the position of this click (1) for easier explanation
Click on another window in the app (Toolbox, Controls, ...)
Hold-click inside the Note Timeline window (for selecting multiple notes for example). Let's call the initial position of this hold-click (2) and the position after that where the mouse is dragging is (3).

Usually, the selection box should be drawn as a rect from (2) to (3), but in this case, it's drawn from (1) to (3) instead, and notes that are selected are also based on the select box drawn from (1) to (3).
Not a breaking bug tho, just some little inconvenient bug.
Will take a look at this latertm if I have time but putting it here in case you're interested.

Fixed as of #7


report Variable Not Assigned for custom_report in write_report Method

I encountered an issue with the write_report method in the gpt-researcher library. When the report_type is set to custom_report, the report variable is not instantiated, which leads to the following error:
Error while writing report: local variable 'report' referenced before assignment
Reproduction Steps:

Set report_type to custom_report.
Call the write_report method.
Observe the error indicating that the report variable is referenced before assignment.

Code Snippet:
Here is the relevant portion of the code:
async def write_report(self, existing_headers: list = []):
"""
Writes the report based on research conducted
Returns:
    str: The report
"""

if self.verbose:
    await stream_output("logs", f"✍ Writing summary for research task: {self.query}...", self.websocket)

if self.report_type == "custom_report":
    **_self.role = self.cfg.agent_role if self.cfg.agent_role else self.role_**
elif self.report_type == "subtopic_report":
    report = await generate_report(
        query=self.query,
        context=self.context,
        agent_role_prompt=self.role,
        report_type=self.report_type,
        report_source=self.report_source,
        websocket=self.websocket,
        cfg=self.cfg,
        main_topic=self.parent_query,
        existing_headers=existing_headers
    )
else:
    report = await generate_report(
        query=self.query,
        context=self.context,
        agent_role_prompt=self.role,
        report_type=self.report_type,
        report_source=self.report_source,
        websocket=self.websocket,
        cfg=self.cfg
    )

return report

Suggested Fix:
Include a call to generate_report in the custom_report block to ensure report is always assigned. For example:
if self.report_type == "custom_report":
self.role = self.cfg.agent_role if self.cfg.agent_role else self.role
report = await generate_report(
query=self.query,
context=self.context,
agent_role_prompt=self.role,
report_type=self.report_type,
report_source=self.report_source,
websocket=self.websocket,
cfg=self.cfg
)
Thank you for looking into this issue!

Hey @mowkalim seems super relevant. how about assisting with a PR for this?

Great work on GPT-Researcher! I have submitted a pull request for this issue, numbered #551


Returned functionality to industrial reagent grinders

The nerf to recyclers that limits them to only extract materials from drainable solutions broke industrial reagent grinders, as discovered in issue #31441. I fixed it.

About the PR

Restored the functionality of industrial reagent grinders while leaving the recycler untouched.
Why / Balance

It was bugged to be less than useless. It was actually detrimental to attempt to use it because it would eat your plants and not give anything back.
Technical details

Added a new property to MaterialReclaimerComponents, "onlyDrainableSolutions" which is true by default. This allows for a branch during the MaterialReclaimerSystem's SpawnChemicalsFromComposition function, which in the case that this is true, follows the logic to only extract drainable solutions. In the case that this is set to false, as it now is with the Industrial Reagent Grinder, extracts only extractable solutions. I also defined the solutionContainerId property for the industrial reagent grinder, as this was added in the nerf update but was not added to the industrial reagent grinder, the only object in the game that uses the MaterialReclaimer component and has a solution container.
Added a new function to try and get the extractable solution of an entity specifically to support the MaterialReclaimer's code and mirror the other solution capability functions.
Media

https://github.com/user-attachments/assets/cf680875-21f6-4452-b894-06ca7b85e303
Requirements

[X] I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

fix: Restored functionality to the Industrial Reagent Grinder

needs better sprite

needs better sprite

how is this related at all?

needs better sprite

how is this related at all?

I think the sprite is a different issue. Industrial grinder definitely has a unique sprite already but it's never shown. I'm not sure if that's because it always faces south or if it's bugged.

I believe that might be a bug with the change to a separate RecyclerVisuals component rather than using the generic visualizer? I'll admit it would've been relevant to fix, but I was more concerned with the functionality than the appearance

It's likely a bug with the switch to RecyclerVisuals over the visualizer it was using before. I'll admit that probably would've been relevant to fix in this pr, but I was primarily concerned with the actual functionality rather than the appearance, since the appearance is still an accurate reflection of the current state of the device.


Beta Merge

Will leave running to find errors and report back, otherwise merge with main branch

Fixed wording in auto-voice-channels.py and private.py to update emojis used.

stability seems much better, no major bugs found. Going ahead with Merge BUT will be making a backup of the Main Branch first for reverting purposes if needed.


Port changes of [#16710] to branch-2.6

Add more logs to detect inode tree corruption
Some users reported a issue that expecting to lock inode A but inode B is locked. After the investigation, we figured that this might be due to inode tree corruption caused by journal loss. So we add more logs to help users debug the issue better.
N/A
pr-link: Alluxio/alluxio#16710
change-id: cid-b90490c7122465ccaaf83c660e8e5dfcfc0f692a
What changes are proposed in this pull request?
Please outline the changes and how this PR fixes the issue.
Why are the changes needed?
Please clarify why the changes are needed. For instance,

If you propose a new API, clarify the use case for a new API.
If you fix a bug, describe the bug.

Does this PR introduce any user facing changes?
Please list the user-facing changes introduced by your change, including

change in user-facing APIs
addition or removal of property keys
webui

Codecov Report

:exclamation: No coverage uploaded for pull request base (branch-2.6@9c5d5cd). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##             branch-2.6   #16718   +/-   ##
=============================================
  Coverage              ?   17.52%
  Complexity            ?     2679
=============================================
  Files                 ?     1384
  Lines                 ?    80411
  Branches              ?     9802
=============================================
  Hits                  ?    14096
  Misses                ?    65067
  Partials              ?     1248

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alluxio-bot, merge this please


Similar issue I am facing while upgrading to dotnetframework8 and using isolated function

@poojachavan414 Similar to what?

Closing invalid issue. If there is something to be looked at here, please open a new one with more detail.


Version 1.8.1

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.79%. Comparing base (c512be1) to head (2dc06be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #325   +/-   ##
=========================================
  Coverage     70.79%   70.79%
  Complexity      372      372
=========================================
  Files            29       29
  Lines          1226     1226
=========================================
  Hits            868      868
  Misses          358      358

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Migration from WindowsAzure.ServiceBus (legacy) to Azure.Messaging.ServiceBus (latest)

Library name and version
WindowsAzure.ServiceBus 5.1.0
Query/Question
Our project currently uses the "Windows.Azure.ServiceBus 5.1.0" to communicate with the service bus. I have two questions,

Is there a migration guide for migrating from WindowsAzure.ServiceBus to the latest Azure.Messaging.ServiceBus?
Is there any performance improvement in terms of sending if I choose to have the latest SDK to communicate with the service bus? If yes, is there any documentation showing the improvement?

Environment
No response

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

I'm not sure how this got shuffled without being answered, @arunprakashn, and I apologize for that.   To answer your questions:

There is not one available at this time.
There is no data available for this comparison.  Our performance benchmarking uses the previous generation library, Microsoft.Azure.ServiceBus.


Validate ID's for accounts, permissions, groups

Please make a card for adding server side validation or at least a spike card for figuring out how hard it is to add.

💡 and another lateness apology


Make gpf alias safer

Closes #303

Cool, thanks @BrainMaestro!
Please update the README accordingly too. We keep a brief description of each alias there.

Done

@Eriner, are you good with these git aliases changes?


TEST FAILURE: cloud_to_cloud:dart:aspnetcore_server:status_code_and_message:tls

2019-04-23 18:13:32,575 START: cloud_to_cloud:php7:aspnetcore_server:cancel_after_begin:tls
2019-04-23 18:13:32,580 WAITING: ETA 216.1 sec; 1140 queued, 12 jobs running, 614 complete, 0 failed (load 12.00) next: cloud_to_cloud:php7:aspnetcore_server:cancel_after_first_response:tls @ 1.00 cpu
2019-04-23 18:13:32,595 Unhandled exception:
Received incorrect status: gRPC Error (2, test%20status%20message).
#0      Tester.statusCodeAndMessage (package:interop/src/client.dart:1016:9)
<asynchronous suspension>
#1      Tester.runTestCase (package:interop/src/client.dart:150:16)
<asynchronous suspension>
#2      Tester.runTest (package:interop/src/client.dart:109:11)
<asynchronous suspension>
#3      main (file:///var/local/git/grpc-dart/interop/bin/client.dart:107:20)
<asynchronous suspension>
#4      _startIsolate.<anonymous closure> (dart:isolate/runtime/libisolate_patch.dart:287:32)
#5      _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
2019-04-23 18:13:32,595 FAILED: cloud_to_cloud:dart:aspnetcore_server:status_code_and_message:tls [ret=255, pid=14723, time=9.0sec]
2019-04-23 18:13:32,596 START: cloud_to_cloud:php7:aspnetcore_server:cancel_after_first_response:tls
2019-04-23 18:13:32,601 WAITING: ETA 215.6 sec; 1139 queued, 12 jobs running, 615 complete, 1 failed (load 12.00) next: cloud_to_cloud:php7:aspnetcore_server:timeout_on_sleeping_server:tls @ 1.00 cpu
2019-04-23 18:13:32,618 PASSED: cloud_to_cloud:dart:aspnetcore_server:ping_pong:tls [time=9.6sec, retries=0:0]
2019-04-23 18:13:32,619 START: cloud_to_cloud:php7:aspnetcore_server:timeout_on_sleeping_server:tls
2019-04-23 18:13:32,630 WAITING: ETA 215.2 sec; 1138 queued, 12 jobs running, 616 complete, 1 failed (load 12.00) next:

https://source.cloud.google.com/results/invocations/58c894d9-4c77-41bf-8ee2-99810cff266c/targets/grpc%2Fcore%2Fpull_request%2Flinux%2Fgrpc_interop_tocloud/log

This seems failing 100% now.

I suspect this could have been broken by https://github.com/grpc/grpc-dotnet/pull/216
First failure is https://source.cloud.google.com/results/invocations/68b8bc8d-2b93-41bf-96ec-97086bbf0752/targets, which coincides with merging the PR.


Led Box

New led case, will be smaller and won't require to add hot glue to block the arduino.
There will only be two leds.
I'm using a robotdyn nano ch340g (with micro usb)
http://robotdyn.com/catalog/boards/nano_v3_ch340g_compatible_with_arduino_nano_v3/

The case is modular so you can add plastic parts to customize the form of the led box.
By using other plastic parts we can give the impression the box produce the light by hiding the leds a little bit.
Using layers of plastic parts will make it less and less bright on each parts creating a shade effects.

To commit


Refactoring CLI Commands Handling

PR Type:
Refactoring

PR Description:
This pull request refactors the way CLI commands are handled in the 'pr_agent/cli.py' script. The changes aim to improve code readability and maintainability by replacing a series of if-elif statements with a dictionary that maps commands to their corresponding handler functions.

PR Main Files Walkthrough:
-pr_agent/cli.py: The main changes in this file involve the refactoring of the 'run' function. Instead of using a series of if-elif statements to handle different commands, a dictionary named 'commands' has been introduced. This dictionary maps command names to their corresponding handler functions. Each command now has a dedicated function that handles its execution. This change improves the readability and maintainability of the code.

Preparing pr description...

Preparing answer...

Question: rate this PR from 1 to 10
Answer:
Based on the changes made in this PR, I would rate it an 8 out of 10.
The refactoring of the 'run' function in 'pr_agent/cli.py' significantly improves the readability and maintainability of the code. The use of a dictionary to map commands to their corresponding handler functions is a good practice as it makes the code more modular and easier to extend in the future.
Each command now has a dedicated function that handles its execution, which is a great way to separate concerns and make the code more understandable.
However, there are a few areas that could be improved:

Error handling: Currently, if a command is not found in the 'commands' dictionary, the code simply prints an "Unknown command" message and displays the help text. It would be better to raise a specific exception for this case, which would make error handling more robust and easier to debug.

Function documentation: The newly introduced handler functions ('_handle_ask_command', '_handle_describe_command', etc.) could benefit from docstrings that explain what they do, what parameters they take, and what they return. This would make the code more self-explanatory and easier to maintain.

Unit tests: It's not clear from this PR whether there are unit tests covering these changes. Adding tests would ensure that the refactoring hasn't introduced any regressions and that each command handler function works as expected.

Overall, this is a solid PR that improves the codebase, but there are a few areas that could be improved to make it even better.

Preparing review...

Preparing review...

Preparing review...

Preparing review...

Preparing review...

PR Analysis

🎯 Main theme: Refactoring of CLI command handling
📌 Type of PR: Refactoring
🧪 Relevant tests added: No
✨ Focused PR: Yes, the PR has a clear and coherent title and description, and all PR code diff changes are properly derived from the title and description.
🔒 Security concerns: No, the PR does not introduce any obvious security concerns as it mainly deals with refactoring of command handling in the CLI.

PR Feedback

💡 General PR suggestions: The refactoring of the command handling in the CLI is a good improvement for the maintainability and readability of the code. The use of a dictionary to map commands to their corresponding handler functions is a good practice. However, it would be beneficial to add tests to ensure the correct functionality of the new command handling.


allow lines of offsetarrays

Super simple tiny change that allows plotting lines of OffsetArrays, suggested by @SimonDanisch on slack. It solves #1259.
This needs tests (it passes locally), but I'm not sure exactly how to properly test it. My naive approach would be to:

add OffsetArrays dependency to the Project file in the test repo
add a new test file for OffsetArrays
include said file in runtests.jl

Would that be good enough...?

Not sure what to do with this. My needs to plot offset arrays have changed, but I bet someone will need it at some point. So if there is anything else I can/should do to get this merged let me know.

I see... I think this is mergeable right?

Technically it is mergeable, but while this works for image(some_offsetarray), it does not work for heatmap. So not sure it's in a fantastic state.

Lets merge this... We can polish it later - the offsetarray depedency seems fine, since several packages we depend on already depend on it


DDO-3198 Fix Typo in path reference to OpenApi Spec

Sorry for the PR spam. I had a typo in the path reference to BPM's open api spec. DevOps has some tooling that consumes these foundation.yaml metadata files off the main branch of our github repos but it makes it a bit tricky to fully vet them before they are merged.

I assume the contract testing failure is due to something on related since this is just a repo metadata file that doesn't effect the functioning of BPM.


Use the database instead of mocking AccountManagement

This PR removes swapping of the AccountManagement service. Instead, the real service is used with data that has been written to the database.
Follows #934.
Related to #618.

Thank you, @derrabus!


Upload python projects

We need to collect the mini python projects and include them into a single repository,

We will add later


Is this the right node for me?

I'm sorry, This was the only way I understood how to connect with you.
This might not be an issue other than possibly better documentation?
I want to pull and interact with information from a vendor that uses Stripe.
I want to pull that information which I can see in chrome Dev window being served inside a JSON. However, I have troubles adjusting the CURL to continuously pull (not even thinking about sending commands yet) as the Stripe key changes every 24h.
Can your nodes help me in a Node-Red flow?
I'm thinking:
Service URL/API call with my credentials -> Your magic Nodes adds and updates Stripe API keys -> Feed Response JSON to MQTT/anything else.
b.t.w. When will you push updates for your nodes to be able to pull them inside Node-Red?

Not really sure what you wanna do with your vendor, but does a rolling key mean they don't want what you're trying to do?
Stripe config nodes provides better security for credentials (secrets), supporting dynamic credentials means a sacrifice in security and also implies a managed LRU cache of credentials-to-Stripe mapping.
I don't see node-red did anything like this so far, not sure if they encourage this pattern TBH.
I need a stronger use case, or more context maybe, to do this myself. But if you understand what I mean above, you can make a PR.
P.S. 0.1.3 is deployed.


Speed up Interchange creation

I was doing some benchmarks to estimate performance for workflows of different sizes and dispassionately found that Interchange.from_smirnoff is the slowest step for creating a box of ETHANE molecules and exporting to either OpenMM or GROMACS. The scaling is probably different with polymer size and/or mixtures of different components. These results imply there's some easy gain somewhere in molecule/parameter de-duplication ...

Here is a splicing of the notebook I ended up with:
import time
import matplotlib.pyplot as plt

from openff.toolkit import *
from openff.interchange import *

water = Molecule.from_smiles("CC")
sage = ForceField("openff-2.0.0.offxml")

def f(n):
    times = list()

    now = time.time()
    topology = Topology.from_molecules(n * [water])
    times.append(time.time() - now)

    now = time.time()
    out = sage.create_interchange(topology)
    times.append(time.time() - now)

    now = time.time()
    out.to_openmm()
    times.append(time.time() - now)

    now = time.time()
    out.to_top('foo.top')
    times.append(time.time() - now)

    return times

x = [1, 2, 3, 5, 10, 20, 30, 50, 100, 200, 300, 500, 1000]

times = [f(i) for i in x]

plt.loglog(
    x,
    times,
    'o-',
    label=['Topology', 'Interchange', 'OpenMM', 'GROMACS'],
)
plt.xlabel("Number of waters")
plt.ylabel("Time for preparation step (seconds)")
plt.legend()

A pretty important edit - these are ethanes, which for some reason I stored with the variable name water.

Looks like a major slowdown is repeated calls to Topology.atom_index

This could possibly be trimmed out by de-duplicating on a per-molecule basis for valence terms, just like already happens for AM1-BCC charge assignment.

Well, this is a bit confusing. The toolkit was already doing precisely this^1, and the new version attempts to do the same thing^2.

Well, it's not the toolkit's fundamentally the toolkit's fault, but the profiling indicates the calls happen inside of toolkit calls ...
$ conda deactivate && conda activate openff-old && python torsion_matching.py && conda deactivate && conda activate openff-dev && python torsion_matching.py
Warning: importing 'simtk.openmm' is deprecated.  Import 'openmm' instead.
Bonds 0.1569080352783203
Angles 0.19427013397216797
ProperTorsions 0.25793004035949707
Bonds 0.16020607948303223
Angles 0.2236790657043457
ProperTorsions 0.27321696281433105

import time

from openff.toolkit.topology import Molecule, Topology
from openff.toolkit.typing.engines.smirnoff import ForceField

ethane = Molecule.from_smiles("CC")
sage = ForceField("openff-2.0.0.offxml")

topology = Topology.from_molecules(1000 * [ethane])

for handler in ['Bonds', 'Angles', 'ProperTorsions']:
    time_= time.time()
    sage[handler].find_matches(topology)
    print(handler, time.time() - time_)

@j-wags is running this notebook again with the full 0.11.0/0.2.0 changes included and the performance is much better due to some changes snuck in at the last minute.

With a fresh environment and 0.11.0 pulled in, I think it's pretty safe to say one step is slower than the others ...

The culprit is JAX (#420), which is called when globbing together the non-bonded parameters while preparing the [ atomtypes ] directive. Using b498c6fbf643708f9c5465d28c6a8e8026cc4672 (note my attempt to keep the y-axis limits comparable):

After 0.2.2:

At 0.3.5 this is a little better (axes roughly the same as above):

We will need to revisit performance after Rosemary, but for now I think this is in an acceptable state.

Update around 0.4.0:


Generate coverage report for integration test

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   94.69%   94.69%
=======================================
  Files           1        1
  Lines         245      245
=======================================
  Hits          232      232
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2d9acf...e10ded5. Read the comment docs.