Fix types

naively, i assumed that since the types worked great under a development setting, they must of course be fine for a production setting. hoo boy.
at any rate, this fix sidesteps the dreaded exports.default codegen from typescript, at the cost of rewriting how types are imported into a project.

(for reference, this is how I had to update my code for the new types: https://github.com/zackschuster/ng-app/commit/eb1a2b89fea11347cf659f33d066141796e83118#diff-492126d9b657fe33cff525a036aa5585)


Copy text button on Android/Chrome does not copy the pasta's text

Loading the app (1.2.0-20221107) as hosted on a Raspberry Pi on my mobile (Android 12, Chrome latest), tap the 'Copy Text' button
-> Text is not copied
Selecting the text and copying it with Android's generic copy command works.
Update: Just tested this with Firefox 107 on Win10, getting a
Uncaught TypeError: navigator.clipboard is undefined

in the browser console.

Ok, reason is that I don't serve this through https on my local network...


Refactor S3 file handling and update Dockerfile to include local Chroma DB file

PR Type
Enhancement

Description

Refactored S3 file handling in pr_agent/tools/pr_help_message.py:

Replaced boto3 with urllib.request for S3 file download, simplifying the process and reducing dependencies
Added error handling for missing local database file, improving robustness

Optimized snippet processing:

Removed redundant code for filtering relevant snippets
Simplified the logic for processing relevant snippets and pages

Updated Dockerfile to include the local Chroma DB file in the Docker image, ensuring the database is available during runtime
These changes improve code efficiency, error handling, and deployment consistency

Changes walkthrough 📝
Relevant filesEnhancement

pr_help_message.pyRefactor S3 file handling and optimize snippet processing

pr_agent/tools/pr_help_message.py
Replaced S3 file download using boto3 with urllib.request  Added error handling for missing local database file  Removed redundant code for filtering relevant snippets  Simplified relevant snippets processing

+11/-16

Configuration changes

DockerfileInclude local Chroma DB in Docker image

docker/Dockerfile
Added a new line to copy the local Chroma DB file into the Docker image

+1/-0

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

/help

/help "how to chat with pr-agent ?"


Dask User Survey

The 2019 Dask User Survey is currently live at https://t.co/OGrIjTLC2G
This takes 5-10 minutes and impacts our future direction.

https://github.com/dask/dask/pull/5147 and https://github.com/dask/dask.github.io/pull/15 update the docs and website to remove links to the survey.
I've stopped accepting responses on the Google form.
I'll write up a summary of the results.

Closing this issue as #5147 and dask/dask.github.io#15 have been merged


Overlays

LSB is not displayed on the overlays we create for the campus map.

@ecbrady Can you move this to the Visual Task Board?


Not able to configure Personal Access Token with Secret

Hello, I have tried to configure as per the steps provided but was not been able to find out what is wrong.
I am a bit confused about the steps that how to use the personal access token with the encrypted secrets.
Please help.
@shunjid @zubayerhimel @fahad1997 @jinnatul @abusufianshibli

To be precise, I am confused about where to provide the personal access token name and where to put the secret token.

Did you go through this?

Hello @yash982000,
Sorry for the late reply.
You have to set up the secret token in the settings of your repository. Please go through this documentation from GitHub: https://docs.github.com/en/actions/reference/encrypted-secrets
Make sure that the secret name is TOKEN like the screenshot below.

Let us know if that helps.

Did you go through this?

YES!!

Hello @yash982000,
Sorry for the late reply.
You have to set up the secret token in the settings of your repository. Please go through this documentation from GitHub: https://docs.github.com/en/actions/reference/encrypted-secrets
Make sure that the secret name is TOKEN like the screenshot below.

Let us know if that helps.

Ok.
Then where do I put the personal access token.
And ,also is something to be put in value?

@yash982000 TOKEN should be the name and your personal access token should be the value like the screenshot.

@yash982000 TOKEN should be the name and your personal access token should be the value like the screenshot.

I tried this but the pull request for minification isn't working yet.
I want to setup a workflow such as on commit it checks for minification.
name: minisauras

on: [push]

jobs:
  read:
    runs-on: ubuntu-18.04

    steps:
    - name: Checkout
      uses: actions/checkout@v2
    - name: minisauras
      uses<EMAIL_ADDRESS>      env:
        GITHUB_TOKEN: ${{ secrets.TOKEN }}
      id: dir
      with:
        directory: './' ## minify all files from root directory

What should I write inside "ON" such that it triggers while I commit on that default branch?
Much help appreciated.

Hey @yash982000,
Whenever you merge other branches to your base branch or push directly any changes to your base branch then the action will be able to minify only when you give both read and write access for your personal access token. It will send a pull request to your repository.
Can you please check if your token has both read and write permission?

You may also check the example repository which is using minisauras: https://github.com/TeamTigers/minisauras-example

permissions:
  contents: read
  pull-requests: write

This should do the work right?
Also, I have checked this settings.

Hello @yash982000,
Yes, this should work.
Can you please check if there is an error in the actions log from your action running history?

Heyy @Teamtigers256
No error on logs.

All are showing success. But no pull request and changes.

Also, I wasted some a lot of scheduled actions minutes
But no minification done.
Can you please help?

Hello @yash982000,
Yes, this should work.
Can you please check if there is an error in the actions log from your action running history?

Hello @Teamtigers256
Any updates on this?
I am unable to troubleshoot what is the problem as it is never shown.
Although now, when a new code is pushed to the branch, it shows minisauras run successfully.
So, is there an issue with the triggering of the pull requests?
Here is the screenshot of how the workflow is triggered one pushed some code:-

@Teamtigers256 @hrittikhere
Much help appreciated!!

Hello @yash982000,
Yes, this should work.
Can you please check if there is an error in the actions log from your action running history?

Hello @Teamtigers256
Any updates on this?
I am unable to troubleshoot what is the problem as it is never shown.
Although now, when a new code is pushed to the branch, it shows minisauras run successfully.
So, is there an issue with the triggering of the pull requests?
Here is the screenshot of how the workflow is triggered one pushed some code:-

@hrittikhere @Teamtigers256 @shunjid @zubayerhimel
Can anyone please help?
I have troubleshot a lot. But do not find anything.
If you have used this earlier, I would be happy to see your working code and would debug it accordingly for my use.
It would be great if you can share your working .yml code here.


Patch and debug for Denisa's version

I debugged the codes prepared by Denisa. There were some changes made in certain files, which I inserted as new_{filename}. The post_request.js has been built into the new_app.js. Changes were made in fetch_response.js, which I saved as new_fetch_response.js. However, since the new_testing_file.html didn't work with the src reference, I moved the content of new_fetch_response.js into the script section of the HTML. But if anyone wants to solve this issue, the new_fetch_response.js file will remain accessible, but the whole thing works without this. The chat_history.js remained untouched in the lib folder. I created a .env file to store the API key. I hope I managed to comment everything appropriately in the code.

@londonmajesty222 Fix the security issues.

make a commit with the fix to this branch

Look at the comments I made, and ping me to review the code. If you think I should merge it now, sure.


Fix "analysis failed but no diagnostics were emitted" panics

What was wrong?
If the fn body analysis fails but the diagnostics vec is empty, we panic, as this means we've forgotten to emit an error message.
closes #530 In this case, we actually were emitting an error message for the undefined type in the function signature analysis, but not checking the fn signature diagnostics vec.
closes #532 Here we just weren't emitting an error message if the String type constructor was ill-formed. Eg String<x>("hi") would be rejected without an error message.
How was it fixed?
Corrected the above, and added tests.
To-Do

[ ] Add entry to the release notes (may forgo for trivial changes)

Codecov Report

Merging #534 (31491b1) into master (e256045) will increase coverage by 0.04%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
+ Coverage   87.68%   87.73%   +0.04%
==========================================
  Files          87       87
  Lines        5670     5674       +4
==========================================
+ Hits         4972     4978       +6
+ Misses        698      696       -2

Impacted Files
Coverage Δ

crates/analyzer/src/db/queries/functions.rs
92.04% <66.66%> (+0.09%)
:arrow_up:

crates/analyzer/src/traversal/expressions.rs
91.11% <100.00%> (+0.56%)
:arrow_up:

crates/analyzer/src/traversal/types.rs
94.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e256045...31491b1. Read the comment docs.


[$250] Chrome tab crashes when exporting large number of reports

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:
Reproducible in staging?: need reproduction (does not have large reports)
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1719865717728969
Action Performed:

Open app
User exported the report on behalf of EXFY Finance to All transaction data report

Expected Result:
Chrome tab shouldn't crash
Actual Result:
Chrome crashes
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome
[ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013f932ab5c805342b
Upwork Job ID:<PHONE_NUMBER>867588025
Last Price Increase: 2024-08-08

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

I think this may be an OldDot bug. Confirming in the Slack bug report.

Not old dot, happened to me again

Reproduction steps:

Andrew has NewDot open.
In OldDot, another admin exports many reports that Andrew previously approved
Andrew's NewDot window crashes without him taking any additional action.

I'm applying the external label. This one seems a bit hard to reproduce because it requires a large number of previously approved reports.

No updates.

There we go - it wouldn't create the upwork issue or add a price until "Needs Reproduction" was removed.

I think this belongs in the #newdot-quality project.
I'll see if any expert agencies want to take it.

Asking here for help on reproduction steps: https://expensify.slack.com/archives/C049HHMV9SM/p1721373277740489?thread_ts=1719865717.728969&cid=C049HHMV9SM

No update.

Assigning to see if I can help move this one along.

Left a couple of ramblings in the thread linked above.

Thanks, checking today!

Sorry, got carried away by other tasks today. I have this on my list for tmrw!

Started looking into it, was able to get a crash dump from Jason, which I now need to convert with chrome tools (which requires me to build chromium rom source, so thats taking a bit).
Meanwhile I am trying to reproduce the issue - no luck yet, will try to export a bigger number of reports. Will continue investigating on Monday; having high hops in the crash dump!
It must either be a memory leak, or some loop getting stuck or using too many resources. Will figure it out!

Thanks for the continued investigation @hannojg! Keep us posted if you figure out anything new.

Provided an update here:

https://expensify.slack.com/archives/C049HHMV9SM/p1722325057418249?thread_ts=1719865717.728969&cid=C049HHMV9SM

seeking for help with exporting a massive amount of reports to reproduce (so far I haven't been able to reproduce)

asked Jason to create an issue ticket in google chrome's bug tracker using his crash dump, as its not possible for us to symbolicate the crash dump

We're still working on this one Melv.

No update

Currently blocked by this issue as it makes reproduction hard:

https://github.com/Expensify/App/issues/46576#issuecomment-2269708579

Still working on it

cc @chrispader

No updates.

Actually, I'll put a hold for https://github.com/Expensify/App/issues/46576 given that it's making reproduction hard.

I just fixed the problem in this PR. The crashes related to the report export (and also some other crashes) were caused by a bug in the OnyxUpdateManager, where we didn't handle an edge case, when updates from the backend are not (properly) chained.

Thanks chris!

I'll be OOO until Aug 30, so I'll post the payment summary then. Hope that's okay @fedirjh - it will be one day late.

The payment summary above is correct. Thanks everyone!

$250 approved for @fedirjh


Fixes for IOSERVER on Rome

We know on the Romes that using the MAPL IOSERVER "out of the box" doesn't quite work well.  Dunno.
But, working with @weiyuan-jiang, it was found that the Romes work better if we use the MultiGroup server version of IOSERVER. So this PR tries to "automate" what @weiyuan-jiang said is the best way to set up the MultiGroup server. To wit, he says the best number of backend PEs is the number of history collections divided by the number of ioserver nodes.
This change tries to do that. First, using some sed we try to calculate the number of history collections active. I tried my best but I'm guessing somewhere out there is a HISTORY.rc that will break this, but it works with the HISTORY.AGCM.rc.tmpl so that's something.
Once we get that number, we then remove one from it (for the :: line), and then divide by the number of ionodes.
Note, it's possible eventually we'd want GEOS to always use the MultiGroup server? I'll leave that determination to @bena-nasa, @aoloso, @tclune, and @weiyuan-jiang. Good thing is, we have the code here for it, and we can just make it "everywhere" instead of "just Rome".

@weiyuan-jiang I guess at some point it's up to the user. I think @bena-nasa and myself just sort of "guessed" at a good number of IOS_NODES for each resolution given the default layout we set here.
I suppose if a user wants to use more nodes for the model, they should also think about how many IO nodes, etc. 🤷🏼♂

Tested on discover and it seems to be happy there. I know it also works on the Romes at NAS.


Q3: Rucksack Sorting

In Q3 we are given data representing the contents of a collection of elven rucksacks, like this:
vJrwpWtwJgWrhcsFMMfFFhFp
jqHRNqRjqzjGDLGLrsFMfFZSrLrFZsSL
PmmdzqPrVvPwwTWBwg
wMqvLMZHhHMvwLHjbvcjnnSBnvTQFn
ttgJtRGJQctTZtZT
CrZsJsPPZsGzwwsLwLmpwMDw

Each row represents a rucksack, the first half of the string representing contents of one pocket, the second half the contents of the other pocket.
The elves want to ensure that no item appears in both pockets of a given rucksack.
Items are given a priority score:
Lowercase item types a through z have priorities 1 through 26.
Uppercase item types A through Z have priorities 27 through 52.
Part 1 of the challenge is to find the duplicated items in each rucksack, and for each duplicated item assign a priority score based on the scoring above.
The requested answer is the sum of the scores across all rucksacks.

My first thought was to split the input data for each rucksack into the two pockets first, second:
pub fn part_one(input: &str) -> Option<u32> {

    let mut total:u32 = 0;

    for line in input.lines(){
        let (first, second) = line.split_at(line.len() / 2);
        println!("{} {}", first, second)

    }
    if total == 0 {None?} else {Some(total)}
}

which gives the expected output:
vJrwpWtwJgWr hcsFMMfFFhFp
jqHRNqRjqzjGDLGL rsFMfFZSrLrFZsSL
PmmdzqPrV vPwwTWBwg
wMqvLMZHhHMvwLH jbvcjnnSBnvTQFn
ttgJtRGJ QctTZtZT
CrZsJsPPZsGz wwsLwLmpwMDw

Instead of two strings, could we map the data on input to two collections of a custom type?
Following the logic from today's inspiration I added:
#[repr(transparent)]
struct Item(u8);

impl TryFrom<u8> for Item {
    type Error = String;
    fn try_from(value: u8) -> Result<Self, Self::Error> {
        match value {
            b'a'..=b'z' | b'A'..=b'Z' => Ok(Item(value)),
            _ => Err(format!("{} is not a valid item",value as char)),
        }
    }
}

First learning point was the #[repr(transparent)], which is a compiler constraint telling Rust to represent the struct in memory exactly as it appears in the code. (See here). I'm not entirely sure why this needs to be here in this example yet.
Secondly I wanted to simplify  fasterthanlime's code by removing the presentational library eyre - hence rewriting type Error = String;
To test this I first tried this test:
 #[test]
    fn test_item(){
        let _a = Item::try_from(b'a');
        println!("{_a:?}");
    }

To make that compile at all I had to add the Debug trait to Item, however, the test then just prints the decimal value of the input char, not very useful. So again cribbing, implement a Debug method for Item:
impl std::fmt::Debug for Item {
        fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
            write!(f, "{}", self.0 as char)
        }
    }

and remove the explicit  #[derive(Debug)] from Item to get rid of compiler error conflicting implementations...
Running test_item outputs:
running 1 test
Ok(a)
test tests::test_item ... ok

Key Learning

using #[repr(transparent)]
implementing Debug for a struct

Open Questions

why use #[repr(transparent)] ?
how would I improve test_item to assert on the output?

While trying to implement the top-level function that calculates the answer, found myself messing around a lot trying to understand the difference in behaviour between Result<T,E> and  Option<T>.
fasterthanlime's code uses Result<T, E> all the way through, which means he can write:
let first_items = first
            .bytes()
            .map(Item::try_from)
            .collect::<Result<Vec<_>, _>>()!;

The final ! can only be used in a function that itself returns Result<T,E> and it has two effects:

Errors are passed upwards to the caller
Success results are unpacked to the underlying T

Unfortunately the framework code in the template I am using has functions for each part that look like this:
pub fn part_one(input: &str) -> Option<u32> {
// ...
}

My working conclusion is that when I want to access the contents of first_items there will need to be an unpack() in there somewhere.
Useful references

Module std::result
Module std::option
StackOverflow: Converting a Result into an Option

It was shortly after this point that I decided that I just don't know enough to follow along with fasterthanlime's code so I will go for a simpler approach


Ignore files generated by PhpStorm

Hello,
I added the .idea folder that is generated by the PhpStorm IDE.
Thanks.

This kind of developer specific files can be put in a global gitignore.
https://murze.be/create-a-global-gitignore


Compiler crashes after reporting not found symbol

System Version
6.5.4-arch2-1
Description
Cannot run buzz file due to import failure. Buzz cannot find shared object files. If std is the only import then everything works fine.
Steps To Reproduce
git clone https://github.com/buzz-language/buzz && cd ./buzz/
cd ./mir/
git submodule update --init
make
cd ../

# for install without mimalloc
sudo zig build -Doptimize=ReleaseSafe -Dmimalloc=false install -p /usr/local

If the build succeeds, create a new file: test.buzz containing the code below
import "std";
import "os";

fun main([str] args) > void {
  if (args.len() == 0) {
    print("Hello, Buzz!");
  }
  else {
    os.buzzExit(1);
  }

  os.buzzExit(0);

Error Messages
./test.buzz:9:5: [E75] Compile error: `os` is not defined
     7 ╭─   }
     8 │    else {
     9 │      os.buzzExit(1);
       ┆      ╭─
       ┆      ╰─ `os` is not defined
    10 │    }
    11 ╰─   os.buzzExit(0);
thread 9965 panic: reached unreachable code
/home/sneekyfoxx/buzz/src/node.zig:0:0: 0x2d3d35 in generate (buzz)
/home/sneekyfoxx/buzz/src/node.zig:283:43: 0x2895ff in generate (buzz)
        _ = try self.expression.toByteCode(self.expression, codegen, breaks);
                                          ^
/home/sneekyfoxx/buzz/src/node.zig:6777:41: 0x2547b9 in generate (buzz)
            _ = try statement.toByteCode(statement, codegen, breaks);
                                        ^
/home/sneekyfoxx/buzz/src/node.zig:5768:43: 0x3306c0 in generate (buzz)
            _ = try else_branch.toByteCode(else_branch, codegen, breaks);
                                          ^
/home/sneekyfoxx/buzz/src/node.zig:6777:41: 0x2547b9 in generate (buzz)
            _ = try statement.toByteCode(statement, codegen, breaks);
                                        ^
/home/sneekyfoxx/buzz/src/node.zig:3614:48: 0x23d9f4 in generate (buzz)
            _ = try self.body.?.node.toByteCode(&self.body.?.node, codegen, breaks);
                                               ^
/home/sneekyfoxx/buzz/src/node.zig:4875:46: 0x273938 in generate (buzz)
        _ = try self.function.node.toByteCode(&self.function.node, codegen, breaks);
                                             ^
/home/sneekyfoxx/buzz/src/node.zig:6777:41: 0x2547b9 in generate (buzz)
            _ = try statement.toByteCode(statement, codegen, breaks);
                                        ^
/home/sneekyfoxx/buzz/src/node.zig:3614:48: 0x23d9f4 in generate (buzz)
            _ = try self.body.?.node.toByteCode(&self.body.?.node, codegen, breaks);
                                               ^
/home/sneekyfoxx/buzz/src/codegen.zig:93:50: 0x248a27 in runFile (buzz)
        const function = try root.node.toByteCode(&root.node, self, null);
                                                 ^
/home/sneekyfoxx/buzz/src/main.zig:300:12: 0x24d125 in main (buzz)
    runFile(
           ^
/home/sneekyfoxx/.local/lib/zig/std/start.zig:486:37: 0x24fe86 in main (buzz)
    std.os.argv = @as([*][*:0]u8, @ptrCast(c_argv))[0..@as(usize, @intCast(c_argc))];
                                    ^
???:?:?: 0x7f1ca5845ccf in ??? (libc.so.6)
Unwind information for `libc.so.6:0x7f1ca5845ccf` was not available, trace may be incomplete

[1]    9965 IOT instruction (core dumped)  buzz ./test.buzz

The code below works:
import "std";

fun main([str] args) > int {
  if (args.len() == 0) {
    print("Hello, Buzz!");
  }
  else {
    return 1;
  }

  return 0;
}

output: Hello, Buzz!

The error stack is not normal but the initial error message is accurate. If you want the os import to be prefixed you have to write:
import "std";
import "os" as os;

fun main([str] args) > void {
  if (args.len() == 0) {
    print("Hello, Buzz!");
  } else {
    os.exit(1);
  }

  os.exit(0);
}

Without as, the imported symbols will be in the global namespace.
Also you don't need os.exit if you're directly in main: just change its signature to return an int and return the number you want.

The libc thing is just zig telling you it can't unwind the stack further into it because there's no more debug symbols.

Oh, ok thank you for the information. Your language has the potential to be better than most scripting languages as well. 👌🏾

Is it just os.exit() or os.buzzExit()? Because I don't see exit in the standard library on the reference page on your website.

The website is inaccurate the function is exit

@sneekyfoxx fixed the crash

Not really. Like most scripting language you can start your script with #!/usr/bin/env buzz and chmod +x yourscript.buzz.


Bluetooth: Host: Fix legacy OOB pairing as central

When central is sending SMP Pairing Request is it unknown if pairing will be legacy or LE SC so set OOB flag if any OOB data is present and assume to peer device provides OOB data that will match pairing type.
This was affecting following qualification test cases:
SM/CEN/OOB/BI-01-C
SM/CEN/OOB/BV-01-C
SM/CEN/OOB/BV-03-C
SM/CEN/OOB/BV-09-C
Fix for regression introduced by https://github.com/zephyrproject-rtos/zephyr/pull/50518

@spanceac FYI

#AutoPTS run zephyr SM

Scheduled PR #https://github.com/zephyrproject-rtos/zephyr/pull/56179#issuecomment-1482572496 after 11:25:53.

AutoPTS Bot results:
No failed test found.

I believe this PR is for fixing a regression introduced in the recent PR https://github.com/zephyrproject-rtos/zephyr/pull/50518. @spanceac Raises an issue with the fix in this PR in https://github.com/zephyrproject-rtos/zephyr/pull/56179#discussion_r1148441456. Since the fix does not seem straight forward, we should consider reverting the regression PR and re-work its API. @spanceac: Do you agree that the API might need reworking?

Hi @alwa-nordic ,
The way I see the things, we have these options:

revert https://github.com/zephyrproject-rtos/zephyr/pull/50518 and drop the whole idea of discriminating between legacy and LE SC OOB. I can't think of a way to re-work the API and in central mode to be able to advertise OOB flag only for legacy or only for LE SC, since it's a single flag and you don't know if the decided pairing method will be LE SC or legacy
we can keep my PR and this fix as well, and add an error message after pairing method is decided. The error cases would be: negotiated pairing method is legacy OOB but you only support LE SC OOB , negotiated pairing method is LE SC OOB but you only support legacy OOB. The happy case would be if the OOB pairing method you support is the one negotiated with the peer or if a device would support both legacy and LE SC OOB
rework the API to advertise the OOB legacy vs OOB LE SC flag only in cases of device being peripheral and leave central case the way it was

@spanceac I do think it's possible to have an API that discriminates between legacy and LE SC OOB. My understanding is that the OOB transfer happens before the SMP Security Request. Correct? In that case, the application knows which pairing method it is able to use to pair using OOB data. It should be possible for the application to communicate this to the Host so that the Pairing Request SC flag is such that the OOB data is used.


Dark mode in the docs

Hi, first of all, great package and documentation. Is it possible to add dark mode for the documentation? Thanks!

Yup! Available now. Check it out.


Fix MovingCamera and ZoomedScene

#330 broke MovingCamera and ZoomedScene. This is a quick attempt at a hotfix.
Draft since we're still working on it.

@leotrs It it's fine, I'll add the test scene I used as a test for this once #227 is merged.

@Aathish04 I believe we can come back to this and finish now.

Alright, so I had originally intended to do pixel comparison tests, just like the ones that were done for Text, TexMobject and TextMobject. However, with #335 basically confirming that they are too erratic and way too precise to be of any use, I don't think that such a test will be useful in this case as well.
@leotrs @huguesdevimeux Do you have any other suggestions as to how a test for this could be written? I can't think of any straightforward ones, since even if the classes are broken, they could still render and the only difference would be in the final video.

This was intended to be a hotfix - can we merge it while we think of ways to test these?

This was intended to be a hotfix - can we merge it while we think of ways to test these?

Yes, that would be good.
Adding this test to #193


Issue #315 - Dense Network to work for non-Square images and Blocking Bugs

Could you resolve the above issues in workspaces/CFD_workspace/CFD_project_animation/config/CFD_project_animation_config.py @singh96aman , and we can merge it :-)

Thanks for the fix @singh96aman !


Pinpoint- configuration support

Description
----> I've downloaded - pinpoint-collector-1.7.2-SNAPSHOT,pinpoint-web-1.7.2-SNAPSHOT,pinpoint-agent-1.7.2-SNAPSHOT.tar,hbase-1.2.6-bin.tar
----> without any modification I've started the HBASE and started the collected and web in TOMCAT version 9.0.6
---->  Agent I extracted and placed on the same folder where all the files located.
----> wrote one small JAVA program to wait for half an hour
----> executed with the below command [java test -javaagent:/root/Documents/pinpointagent/pinpointagent.jar - DpinPoint.applicationaName=testapp -DpinPoint.agentId=count]
Note: program excuted successfully.
I've also ran the HBASE table creation and I could see the 15 tables in HBASE UI
Environment
ROOT user
Linux Lin 4.13.0-kali1-amd64
Additional Info
Now I'm struct and don't know how to move further could anyone support on this. thanks in advnce

Hello, @gsmba6
correct me if I'm wrong.

You have completed setting up HBASE.
successfully executed PINPOINT-AGENT, PINPOINT-COLLECTOR, PINPOINT-WEB
small JAVA program running without any problems.

I believe there isn't anything else to take care of besides monitoring your application(in this case small JAVA program) through PINPOINT-WEB(for the installation of WEB, take a look at here)
depending on the configuration that you configured for PINPOINT-WEB in TOMCAT. You can access PINPOINT-WEB and the first screen image that you see will be something like this.

@RoySRose thanks for the quick turn around.
My issue is the Pinpoint web is launching but i could able to see the application name or ID in the web. its plain.. my application drop down is disabled.

@gsmba6
I don't think I can be a much help without any logs or further information.
Since you have downloaded all

pinpoint-collector-1.7.2-SNAPSHOT
pinpoint-web-1.7.2-SNAPSHOTpinpoint-agent-1.7.2-SNAPSHOT.tar,hbase-1.2.6-bin.tar

Only thing that I can think of https://github.com/naver/pinpoint/issues/2273

@RoySRose - Issue resolved.
I've appended the Tomcat - Catalina option in . sh file
But my Eclipse uses its own configuration where I gave the java agent details to VM arguments and the issue resolved and my agent appeared in web UI.
I can monitor the transactions.


Add compile time std array recognition and unpacking

std::array was skipped during initial development, but serializes the same as other dynamically sized containers. Unpacking needed to be handled slightly differently because the dynamic sized version rebuilt the original container with emplace_back(), which doesn't work with static containers.


Hides extra map elements

Description
This PR removes the map scale on the bottom left of the property map and hides the map attribute on the bottom right of the map by default.  Addresses (Issue#1022)

Steps to Test

Navigate to the Property Map
You should not see the map scale on the bottom left corner of the map just the map legend
The attribution on the bottom right should be hidden when the application loads

Screenshots

@CodeWritingCow can we get a PR review?

Hi @DonovanAndrews300 I ran your PR's code locally on my computer, and the UI works as expected.
However, GitHub failed to deploy the PR to Vercel's preview environment. I suspect it's due to a minor TypeScript error. TS says click doesn't exist on Element:

The fix should be pretty easy. If we just annotate attributionButton's type as an HTMLElement, then the error goes away:


Update for HA2025.1 update -  sensor.py

This changes remove the Warnings in Homeassistant and respect the new changes coming with HA 2025.1 version.
HA config parameters are updated.
In my Tests everything works fine.

@Scharmen Thanx for your help!


[#160175644] Enable bosh prometheus exporter

What
We want to use the Bosh exporter to gather VM metrics. This is an alternative to running the node exporter on every VM.
Related
https://github.com/alphagov/paas-bootstrap/pull/202
How to review

Deploy from this branch.
Check in the Grafana UI the Bosh dashboards are there and populated by data.
Check in AlertManager to see the correct alerts are set up

Who can review
@henrytk and @keymon

Closing for the time being until we solve the problem of how to create read-only users in bosh.


Fix wrong slot_num in wdl_bin.json

slot_num should be 26.

Actually, this sample uses NVTabular binary output as the data source. There are 26 categorical slots and 2 feature cross slots in the NVTabular binary output. 26 categorical slots plus 1 feature cross slot are used as wide data, and the other 1 feature cross slot are used as deep data. There is no wrong with the original JSON configuration.
We are going to migrate to the Python interface from version 3.1 and there is no need to write JSON configuration anymore. Please stay tuned.

Actually, this sample uses NVTabular binary output as the data source. There are 26 categorical slots and 2 feature cross slots in the NVTabular binary output. 26 categorical slots plus 1 feature cross slot are used as deep data, and the other 1 feature cross slot are used as wide data. There is no wrong with the original JSON configuration.
We are going to migrate to the Python interface from version 3.1 and there is no need to write JSON configuration anymore. Please stay tuned.


HW06

Web Client-Side Programming – Homework 6
UI with validation
Description
For this assignment we will create a reservation form with validation and a Jquery UI interface.
Specifications

[ ]  Starting with the included reservation.html file.

[ ]  Modify the HTML so the contents of the three fieldset elements can be implemented as three tabs of a Tabs widget. When you do that, you can delete the fieldset and legend elements, and you can set the headings for the tabs to the content of the legend elements.

[ ]  Add the jQuery code that implements the tabs.

[ ]  Add the jQuery code that implements the Datepicker widget for the arrival date.

[ ]  The date can be from the current date to 90 days after the current date.

[ ]  Code an event handler for the click event of the View Cancellation Policies button.

[ ]  This event handler should display the div element with an id of “dialog” as a modal Dialog box.

[ ]  JavaScript should be in an external JS file.

[ ]  When the user clicks submit, make sure you validate the data on the form and display a dialog box indicating the form is valid or not.

[ ]  Do not forget to validate your HTML file (your CSS should come from JQuery UI).

[ ]  Below is an example of the final page.

Documentation

[ ]  You will need to create a document (.docx, .rtf, .pdf) which contains the following:
[ ]  A screenshot of your page running on your local webserver. Your screenshot needs to include the address bar with the localhost url and show all the validation messages
[ ]  You will need to validate the index.html (link on Canvas) and include a screenshot of the successful validation (Green Bar).

What to Submit

[ ] You need to submit your index.html, CSS file, and your external JS file along with your Document. Make sure your document is in the correct format and includes your name.

Looks very good!
On Mon, Oct 29, 2018 at 1:06 PM CherylCrawford<EMAIL_ADDRESS>wrote:

Web Client-Side Programming – Homework 6
UI with validation
Description
For this assignment we will create a reservation form with validation and
a Jquery UI interface.
Specifications

Starting with the included reservation.html file.
Modify the HTML so the contents of the three fieldset elements can be
implemented as three tabs of a Tabs widget. When you do that, you can
delete the fieldset and legend elements, and you can set the headings for
the tabs to the content of the legend elements.
Add the jQuery code that implements the tabs.
Add the jQuery code that implements the Datepicker widget for the
arrival date.
The date can be from the current date to 90 days after the current
date.
Code an event handler for the click event of the View Cancellation
Policies button.
This event handler should display the div element with an id of
“dialog” as a modal Dialog box.
JavaScript should be in an external JS file.
When the user clicks submit, make sure you validate the data on the
form and display a dialog box indicating the form is valid or not.
Do not forget to validate your HTML file (your CSS should come from
JQuery UI).
Below is an example of the final page.
[image: capture]
https://user-images.githubusercontent.com/24579370/47670237-b68d3280-db7a-11e8-976b-6e3abe892e65.JPG
Documentation

You will need to create a document (.docx, .rtf, .pdf) which
contains the following:
A screenshot of your page running on your local webserver. Your
screenshot needs to include the address bar with the localhost url and show
all the validation messages
You will need to validate the index.html (link on Canvas) and
include a screenshot of the successful validation (Green Bar).

What to Submit

You need to submit your index.html, CSS file, and your external JS
file along with your Document. Make sure your document is in the correct
format and includes your name.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/CherylCrawford/Client-Side/issues/4, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAGBWAmizk_1OoobusnqN6Z8OHARpnpQks5up0OcgaJpZM4X_wYH
.


Change location of has_ flags in generated structure.

Hi,
is there any way to instruct the generator to place all the additional has_ structure members at the end of a structure to possibly optimize the struct packing (without using the packed compiler option)?
E.g., the following structure is generated for several optional fields, where the has_ entry creates 3 bytes of padding:
typedef struct _SomeStructure {
    uint32_t version_marker; /* for schema */
    bool has_sub;
    SomeStructure_Sub sub;
    bool has_sub_sub;
    SomeStructure_SubSub sub_sub;
    bool has_sub_sub_sub;
    SomeStructure_SubSubSub sub_sub_sub;
} SomeStructure;

Ok, that's fair enough, this is not really a blocking issue for me so I'll close this one as well. Thank you for the fast reply!


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've rerendered the recipe as instructed in #6.
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

license_file entry is missing, but is expected.

The re-rendered package isn't passing the tests at the moment - giving an X11 error, because it is importing matplotlib but can't find an X11 environment. We've never had this issue before with Py6S builds on conda-forge, so I don't know what's happening here - anyone got any ideas? Has something changed with the way that the build process works? (For what it's worth, the Py6S tests run fine on the Py6S CI on Travis)
@gillins As an aside, why does this need re-rendering as the Py6S package hasn't changed? There have been various re-renders of the sixs-feedstock due to rebuild issues to catch up with everything else, but as a pure Python package I'd have thought Py6S would be ok.
I'm on holiday at the moment but will try and look into this when I get back. Any advice in the meantime would be much appreciated though!

@robintw you are right. I didn't notice this was a pure Python package. Feel free to close. I'm trying to debug https://github.com/conda-forge/arcsi-feedstock/pull/9 but the problem must be elsewhere.
As an aside, adding a yum_requirements.txt like I did for tuiview (https://github.com/conda-forge/tuiview-feedstock/blob/master/recipe/yum_requirements.txt) should fix that X11 problem. Enjoy your break!

Done in #8


Noob example springboot

I read the issue https://github.com/zalando/logbook/issues/316 and I am just not getting it.  In the issue #316, it has a very plain springboot project with logbook entries in application.properties.  I am more interested in configuring via Java.
My springboot project has successfully use logbook 2.0.0-RC.1 and I see logbook entries in my log.  But  I am unable to understand how customize logbook using LogbookAutoConfiguration via Java.
Consider this springboot java code:
@Configuration
public class LogbookConfig {
	@Bean
	LogbookAutoConfiguration logbook( ) {
		LogbookAutoConfiguration lac = new LogbookAutoConfiguration(null);
		//...more code here...
		return lac;
	}
}

Is this the correct approach?  Or am I to replace LogbookAutoConfiguration with Logbook as the bean?
Also, in your README.md, you have this code:
Logbook logbook = Logbook.builder()
    .requestFilter(replaceBody(contentType("audio/*"), "mmh mmh mmh mmh"))
    .responseFilter(replaceBody(contentType("*/*-stream"), "It just keeps going and going..."))
    .queryFilter(accessToken())
    .queryFilter(replaceQuery("password", "<secret>"))
    .headerFilter(authorization())
    .headerFilter(eachHeader("X-Secret"::equalsIgnoreCase, "<secret>"))
    .build();

the contentType() is undefined in 2.0.0-RC.1.  I am interested in the contentType part for responses.  I have responses that are either binary, xml or json.
This is what I want to do:   For the response, if the response is binary, just log the file size; if it is anything else (xml or json in this case), output the response to the log.

But I am unable to understand how customize logbook using LogbookAutoConfiguration via Java.

Customization of the auto configuration is primary done via configuration (properties or yaml).
The LogbookAutoConfiguration is picked up by Spring automatically. If you don't want that you need to remove the logbook-spring-boot-autoconfigure artifact from your classpath.
If you want to configure Logbook manually in code, this should do the trick:
@Configuration
public class LogbookConfig {
	@Bean
	Logbook logbook( ) {
	    return Logbook logbook = Logbook.builder()
	        .requestFilter(replaceBody(contentType("audio/*"), "mmh mmh mmh mmh"))
	        .responseFilter(replaceBody(contentType("*/*-stream"), "It just keeps going and going..."))
	        .queryFilter(accessToken())
	        .queryFilter(replaceQuery("password", "<secret>"))
	        .headerFilter(authorization())
	        .headerFilter(eachHeader("X-Secret"::equalsIgnoreCase, "<secret>"))
	        .build();
	}
}

the contentType() is undefined in 2.0.0-RC.1.

https://github.com/zalando/logbook/blob/2.0.0-RC.1/logbook-core/src/main/java/org/zalando/logbook/Conditions.java#L52

if the response is binary, just log the file size

What binary content types are you using?
Default values might already be good enough:
https://github.com/zalando/logbook/blob/60234b73689a0a174a107dd348d67d47d7718ae0/logbook-core/src/main/java/org/zalando/logbook/BodyReplacers.java#L18-L28

Your example code has this snippet:
 .responseFilter(replaceBody(contentType("*/*-stream"), "It just keeps going and going..."))

gives me an error in my IDE, however, if I replace contentType with Conditions.contentType, then it no longer complains that there is an error with contentType.
Regardless, the example is helpful.  Thank you.

however, if I replace contentType with Conditions.contentType, then it no longer complains that there is an error with contentType.

You need a static import for the method.


DateHeader rendering bug fix

Summary
After #2693 merged to master branch, there's bug in the post search screen. DateHeader component doesn't render the date properly. Now, it looks like this.

So i fixed app/screens/search.js file to render the DateHeader normally.
Ticket Link
This PR has just 2 lines of code change, so there's no ticket but related to #2693
Checklist
None apply
Device Information
This PR was tested on: Samsung Galaxy Note 9, Android 9
Mattermost Server: v5.6.0

Thank you for the review @hmhealey, @enahum! It was lucky to find this bug.


Improve layers so that they can be passed easily by LayerInfo and not only by index

TODO:

[x] make Layers better
[ ] allow dynamic creation and registering of Layers

The new structure will allow this:
import kfactory as kf

class Constants(kf.kcell.Constants):
    WG_WIDTH: int = 2000

class Layers(kf.kcell.LayerInfos):
    WG: kf.kdb.LayerInfo = kf.kdb.LayerInfo(1, 0, "WG")
    WGEX: kf.kdb.LayerInfo = kf.kdb.LayerInfo(1, 1, "WG")

kcl = kf.KCLayout[Layers, Constants]("TEST", layer_infos=Layers, constants=Constants)
c = kcl.kcell()

kcl.constants.WG_WIDTH

c.kcl.layer_infos.WG
c.kcl.layer_infos.CLAD

c.kcl.constants.WG
c.kcl.constatns.WGEX

Autocompletion currently only works for kcl.constants and kcl.layer_infos.

Mypy is able to detect missing/wrong fields though

Is the increased complexity worth it though? These changes will necessitate that we do
kcl.kcell() in the future instead of kf.KCell(...) (because otherwise we would need to do  kf.KCell[MyLayerInfosClass, MyConstantsClass](kcl=kcl)
@gdspaul @joamatab @tvt173

do you mean that users who are happy to use the default kcl are still going to have to type kf.kcl.kcell to make a cell?

not really, this works perfectly fine (just mypy complaining in my case):
import kfactory as kf

c = kf.KCell()

c.shapes(c.kcl.layer(1, 0)).insert(kf.kdb.Box(500))
c.show()

does the layerinfo init really need a layer name put in? it's been hard to sneak nice things past mypy here, but maybe there's a way to internally set layerinfo.name to match the layer attribute names without annoying mypy. pseudopython—
class Layers(baseclass):
 WG = layerinfo(1,0) # wire it up internally to become layerinfo(1,0,'WG')

does the layerinfo init really need a layer name put in? it's been hard to sneak nice things past mypy here, but maybe there's a way to internally set layerinfo.name to match the layer attribute names without annoying mypy. pseudopython—
class Layers(baseclass):
 WG = layerinfo(1,0) # wire it up internally to become layerinfo(1,0,'WG')

It does not in fact, but what it needs is the type annotation due to it being a pydantic model, unfortunately.
so it's happy with
class Layers(kf.kcell.LayerInfos):
    WG: kf.kdb.LayerInfo = kf.kdb.LayerInfo(1, 0)

and it will make it to `WG: kf.kdb.LayerInfo = kf.kdb.LayerInfo(1, 0, "WG")` but `: kf.kdb.LayerInfo` is necessary

dataclasses are also not great if you want stuff like asdict to work properly, so I don't have a great solution for that.

my comment was confusing, my bad. the layers concept isn't a good fit for dataclasses either. but maybe there's something that could be implemented—let's call it UserFacingLayersBaseClass, so user code could read
class Layers(UserFacingLayersBaseClass):
 WG = kf.kdb.LayerInfo(1,0)

which does not need to be annotated, and then there's some function in the KCLayout infrastructure that does this job:
# user_defined_layer_class = Layers
pdk_layers: ActualLayersPydanticModel = make_pydantic_thingy_from_user_class(user_defined_layer_class)
# validation is done
pdk.layers = pdk_layers
pdk.layers.model_dump() # but Layers.model_dump() is not defined

I don't think that would work. I mean you are free to do any of this. You just can't pass it to the KCLayout creation.
But you can always do this if you do not want autocomplete
kcl.layer_infos = kf.kcell.LayerInfos(WG=kf.kdb.LayerInfo(1,0))


yetus: Install dependencies inside Yetus container

go-libzfs module depends on libzfs to be built. However, the package libzfslinux-dev is not available inside the Yetus container, leading to the following error:
cmd/zfsmanager/handlediskconfig.go:12:9: could not import github.com/bicomsystems/go-libzfs
This commit introduces the script tools/run-yetus.sh that allows to install and manage all dependencies inside the container before start to execute all the tests.

Converted to draft because the libzfs installed is now leading to another errors (I think due to its version).... need to check more deeply....

@eriknordmark , @deitch , build libzfs from sources it works, the issues reported in the PR are gone. However, this PR solves the problem when running make yetus locally, I'm not sure how we could integrate it to GH actions without too much changes.... would like to hear your thoughts about it....

Every run that invokes yetus - which is every CI job ever invoked on EVE - is going to clone openzfs and build it? Will that not slow down every run? And as you wrote, this doesn't solve the CI issue, where we just use the yetus action (which we should, to keep it simple). This also hacks the startup of the container, which makes it brittle, sensitive to changes in yetus.
How does it work outside of yetus, i.e. normal EVE build? Is it because we install it as part of the eve-build-<user> container based on the Dockerfile here?
The source to the yetus action is this repo. It is a composite action that then calls a single docker container this line.
What is the standard yetus way of, "I need these dependencies installed before you do your run"? There should be a way to do that.

Every run that invokes yetus - which is every CI job ever invoked on EVE - is going to clone openzfs and build it? Will that not slow down every run? And as you wrote, this doesn't solve the CI issue, where we just use the yetus action (which we should, to keep it simple). This also hacks the startup of the container, which makes it brittle, sensitive to changes in yetus.

I understand and agree, my first option was use the binary package, but versions don't match, that's why the approach was to build from sources... regarding the script, entrypoint.sh from yetus container does the check if it's being called with parameters for test-patch or a third party program, which is this case will be executed with bash, so I don't think it's a hack: https://github.com/apache/yetus/blob/main/entrypoint.sh#L18

How does it work outside of yetus, i.e. normal EVE build? Is it because we install it as part of the eve-build-<user> container based on the Dockerfile here?

The userspace tools are built in the dom0-ztools package: https://github.com/lf-edge/eve/blob/master/pkg/dom0-ztools/Dockerfile#L11
AFAIK this is the right version to use... which matches the ZFS module built in our kernel...

The source to the yetus action is this repo. It is a composite action that then calls a single docker container this line.

Nice, thanks, will take a look....

What is the standard yetus way of, "I need these dependencies installed before you do your run"? There should be a way to do that.
Well, I don't know if there is a standard way to do that... they provide the container, in my view the right way would be extend yetus container to a custom one which would include all the dependencies... I was trying to avoid that so we would need to also maintain this custom container, but perhaps is the best approach....

@rene #3780 is failing unit tests (and yetus) workflows. Does this PR have any impact on those?

I don't think it's a hack:

I didn't mean that in a negative way. The ENTRYPOINT and CMD of a container is an integral part of its shipping, and assumptions about how it runs. We are overriding that somewhat, by injecting something in between its normal CMD and what we want. It isn't bad, but it does change it somewhat.

The userspace tools are built in the dom0-ztools package

Isn't the problem with yetus occurring in the pillar container? How does dom0-ztools (a different package built separately) help with that?

in my view the right way would be extend yetus container to a custom one which would include all the dependencies... I was trying to avoid that so we would need to also maintain this custom container, but perhaps is the best approach..

I think you are correct to shy away from it for those reasons. We really do not need "yet another customized thing" to maintain.
Trying to think this through and be helpful.

We have to be able to run go commands (like vet or lint) on pkg/pillar (and elsewhere) from within the yetus container
Some of pillar depends on external libraries, specifically github.com/bicomsystems/go-libzfs. Normal go tools have no problem with those, as they download them automatically, and in any case, it all is vendored in pillar.
github.com/bicomsystems/go-libzfs depends on CGO, and more importantly, relies on the openzfs libraries. go tools do not know how to get those.
For our normal build, we do it inside the eve-build-* container, which includes the packages zfs-dev, zfs-libs
For yetus build, we do it inside the yetus container, which we do not control, and hence is missing libraries

From a yetus perspective, the module version doesn't even really matter. It just is checking if the code is buildable and passes vet and lint and so on. It just needs some version that satisfies dependencies.
I see a few ways we could do this.

inject starting script which builds zfs - what you did, we could try something similar with the actual yetus container image. That would mean bypassing the official action, but it still would use the official container
inject starting script which installs pre-built zfs - similar to what you did, but rather than git clone and build, run package install. ghcr.io/apache/yetus is based on Ubuntu 22.04, so apt update && apt install -y libzfs4linux should do it. This is a lot quicker.
As you said, extend the container. This is the recommended way to do it in yetus, and is simple:

FROM ghcr.io/apache/yetus:main
RUN apt update && apt install -y libzfs4linux

use the plugins functionality to create a custom plugin to install libzfs4linux, see advanced yetus
get away from dependency on lib-zfs.

If we need to bypass the official yetus action, it isn't a big deal. All the action does pretty much is wrap running a container, see here.
My favourite is the last one, as it makes pillar much easier to build, works on any system, and moves us towards our goals of making it easier to build and test each part of pillar independently. That was the reason we implemented http://github.com/packetcap/go-pcap/ , to avoid CGO and library and header dependency problems.
How hard is it to do?
The library we use, http://github.com/bicomsystems/go-libzfs, has not been updated in 2 years (since Petr and I put in small PRs). All it does is wrap ioctl calls, which is easy to do in go. There is one native implementation that I found https://github.com/lorenz/go-zfs .
We use the current library in 5 files. Most have a few individual uses, one has a large number, but mostly types, with a few calls. At first blush it looks straightforward to do. Calls are different, but should not be hard.
I do not know, however, how hard it is to test it. if someone could confirm that they could test it sanely, I would be willing to try a cut at converting it. I would give it one day. If we can convert it, great; if not, let it go.

The original lint error starting this conversation is from our zfs 2.1.2/2.1.12 versions.  With PRs https://github.com/lf-edge/eve/pull/3779 and https://github.com/lf-edge/eve/pull/3780 I'm moving us over to a forked copy https://github.com/andrewd-zededa/go-libzfs which I've updated for zfs 2.2.2 (https://github.com/andrewd-zededa/go-libzfs/tree/andrewd-zfs-2.2.2-0.4.0).
@deitch @rene Can I suggest a couple more options?

check in the libzfs header files under the eve repo (not great)
add yetus ignore config to my go-libzfs fork

@deitch @rene Can I suggest a couple more options?

check in the libzfs header files under the eve repo (not great)
add yetus ignore config to my go-libzfs fork

It seems like both the unit tests and yetus fails because it can't compile anything. Thus a yetus ignore for some files wouldn't help - we'd have to disable all of yetus and the unit tests. This is clearly a non-starter.
What does it take to do make test work in your workspace?

@eriknordmark here is a change to get 'make test' running here.  It pulls in the correct zfs version headers without the build time implications of building user space openzfs each time.
diff --git a/build-tools/src/scripts/Dockerfile b/build-tools/src/scripts/Dockerfile
index 5c4f0365d..39f1efcf6 100644
--- a/build-tools/src/scripts/Dockerfile
+++ b/build-tools/src/scripts/Dockerfile
@@ -12,7 +12,7 @@ ARG all_proxy
 RUN apk add --no-cache openssh-client git gcc linux-headers libc-dev util-linux libpcap-dev bash vim make protobuf protobuf-dev sudo tar curl graphviz ttf-freefont patch dnsmasq
 # we need updated libraries, here we use the same version as for eve/alpine
 # hadolint ignore=DL3018
-RUN apk --no-cache --repository https://dl-cdn.alpinelinux.org/alpine/v3.16/main add -U --upgrade zfs-dev zfs-libs
+RUN apk --no-cache --repository https://dl-cdn.alpinelinux.org/alpine/v3.19/main add -U --upgrade zfs-dev=2.2.2-r0 zfs-libs=2.2.2-r0
 RUN deluser ${USER} ; delgroup ${GROUP} || :
 RUN sed -ie /:${UID}:/d /etc/passwd /etc/shadow ; sed -ie /:${GID}:/d /etc/group || :
 RUN addgroup -g ${GID} ${GROUP} && adduser -h /home/${USER} -G ${GROUP} -D -H -u ${UID} ${USER}

I can't find zfs 2.2.2 version of the packages in ubuntu 22.04/jammy repos.
@deitch Another go mod option looks like https://github.com/mistifyio/go-zfs which seems to be used fairly widely.

check in the libzfs header files under the eve repo (not great

Also doesn't provide the need .so libraries.

this zfs package version is not in the 3.16 alpine repos

We still are running on 3.16?
We should fix that.

Another go mod option looks like https://github.com/mistifyio/go-zfs which seems to be used fairly widely

It does not depend on CGO or libraries. It is a wrapper around the zfs CLI tools, so we could do that. It would require having the zfs tools installed, but is that so bad? I don't think so.

I can't find zfs 2.2.2 version of the packages in ubuntu 22.04/jammy repos.
@deitch Another go mod option looks like https://github.com/mistifyio/go-zfs which seems to be used fairly widely.

I think it's a feasible solution, but TBH I'm afraid that we are just postponing a problem that eventually will happen again in the future.... now we change the library only to make Yetus running successfully... but sooner or later we might have another library that will require to be built as well... and then we will need to find another alternative again..... @deitch listed good approaches that can be followed in order to get the library binaries inside Yetus' container... I think we should move towards one of these approaches instead of replace the library....
Let's keep this PR as Draft for now only as a point of discussion until we take some decision, then I can change it or close it....

TBH I'm afraid that we are just postponing a problem

That is the real problem, isn't it? As long as we can build these things with OS-level dependencies that have to be installed, we eventually will hit the issue (although we should be willing to take reasonable solutions that buy us a year or two).
yetus runs inside a container. All build dependencies must be available inside that container. That means that everything must be one of:

mountable from the source directory (like the code)
part of standard tooling (i.e. go-native, which means either of the 2 alternate libraries listed above)

If not those, then we have to accept that we have to extend yetus.
But we need to decide, as a principle, which of these two we do.

@eriknordmark , @christoph-zededa, @andrewd-zededa and I had a discussion about this issue. The priority for now is to fix the unit tests and make it work with the required libzfs library. @andrewd-zededa will work on that and update his PR. Meanwhile we will think in a better approach to mitigate the yetus issue, if possible, without extending the yetus container and forking the yetus GH action. I'm closing this PR. Thanks everybody for the useful comments.


drivers: flash: Fix checking for radio idle state

ll_radio_state_is_idle() returns bool, not an error value - this means
it is non-zero on success.
Signed-off-by: Andrzej Kaczmarek<EMAIL_ADDRESS>

If the fix is related to https://jira.zephyrproject.org/browse/ZEP-2445, please add the jira issue in the commit message

@nashif this seems to be ready for merging if you can take a look


WIP: async awesomeness

Original PR #3190 by @bbangert, moved to branch on main repo to be able to collaborate easier.
Description:
WIP: NOT READY FOR MERGE YET
This replaces the primary mechanism by which HASS runs.
The existing architecture exposes 3 core.py API objects, EventBus, StateMachine, and ServiceRegistry. These are called from a variety of threads and are all blocking calls that attempt to acquire per-object locks to fully execute.
This change retains the existing thread-safe blocking API for use by all components, as well as the blocking nature of component setup. However, it starts up an asyncio event loop on start, which is where the actual work is done. The thread-safe API calls schedule the async API variant version into the event loop, then blocks waiting until it has run to completion.
EventBus registrations that are marked as coroutines run on the event loop and may directly run async versions of the appropriate API's. To retain similar call characteristics as before, EventBus's async_fire schedules coroutines to run later on the event loop while sending non-coroutines to the thread-pool as before. This does mean that coroutine listeners are guaranteed to run after all listeners were located, while non-coroutines may start executing immediately in the other thread.
This WIP uses Python 3.4.4 functionality as a proving ground for the approach, using earlier 3.4 should be fine with a backported function or two for asyncio features needed (such as run_coroutine_threadsafe).

py.test --timeout=1 tests/test_core.py -k test_call_non_existing_with_blocking

This test hangs on calling result() on run_coroutine_threadsafe return value in ServiceRegistry.call. All methods in run_coroutine_threadsafe are getting executed.

This works on Python 3.4.4, and 3.4.3 according to reports. Travis-CI runs on 3.4.2 unfortunately. I will need to get a 3.4.2 install so I can see which remaining functions need backporting.

Please do not be scared to review this PR by the high number of changed files. Due to the internal change we had to pretty much touch every test file. Only the first few files in the changed files tab are relevant.

I think that this is ready to be merged and get it in the hands of other devs.
@bbangert, I'll leave the honor up to you. Please make sure to press the squash & merge button 👍 🐬


[BUG]: Release activity for CSI Powerscale v2.1.0

Release activity PR

https://github.com/dell/csi-powerscale/pull/38 addressed release activity


Unfriendly error on subscriptions when user has no access to any project within a given subscription

When a users is creating a subscription - all connected instances are shown. If a user selects an instance where there are no projects with permissions to create a subscription an unfriendly error is shown.
The project drop down correctly reads No Options but the user see's message text of Unexpected token { in JSON at position 104

Steps

On a target Jira instance make sure test user does not have browse or create permissions on any projects
Connect the test user to that instance in Mattermost
Open the subscribe modal
Select the target instance

Expected:
A. Remove the text or translate it to something like No projects available on this Jira instance (not sure if it's needed as the drop down explains why its empty.
OR
B. Hide Jira instances from the drop down if there are no projects to return within them. (This may add complexity and personally, I feel this is less clear then showing me that the instance has no projects)

*The following comments are quotes that were made in the transferred issue.  All of them by @mickmister *
@DHaussermann I'm unable to produce the JSON unexpected token error. I'm instead getting this error: failed to GetProjectMetadata: not authorized to create issues

Any way you can capture the request/response when this occurs?
@DHaussermann I may have to debug this with you, as I cannot reproduce that same error message. I'm guessing the error is being generated by a JS parse error on the frontend.

@DHaussermann, I have confirmed the error shown in @mickmister's testing.  I'm closing this ticket with the assumption this was fixed sometime after you discovered the error.


Set dnsConfig to change ndot value

Is there a way to set the dnsConfig settings to lower the ndots value? I'm experiencing random timeouts when hitting Grafana cloud external endpoints. I've been able to fix some of these by adding a dot to the end of the endpoint; however, opencost for instance is hitting AWS endpoints that I can't modify.
Example:
spec:
  dnsConfig:
    options:
      - name: ndots
        value: "2"

It depends on the specific chart's configuration that allows it. The k8s-monitoring chart does not design how the OpenCost pods are deployed, it utilizes the OpenCost Helm chart to create the deployment. Unfortunately, it doesn't appear that they've exposed the ability to set dnsConfig on their pods.
I'd open up an issue on their chart and when they support it, this chart will have the ability too.
Another option (I haven't used it, so I cannot vouch for it) is this webhook that'll add the dnsConfig to pods: https://github.com/karampok/dnsconfig-injector

I came across this config injector in my searches recently and haven't tried it as well, but I'll give it a go. Thanks!


Update OSA SHA to tip of stable/mitaka

This update addresses the following issues:

https://github.com/rcbops/rpc-openstack/issues/1483
https://github.com/rcbops/u-suk-dev/issues/517
https://github.com/rcbops/rpc-openstack/issues/1432

Connected https://github.com/rcbops/u-suk-dev/issues/579

:eyes: Preview

recheck_upgrade

recheck_upgrade Task Failed: horizon_all / horizon_extensions / Collect and compress static files

recheck_upgrade

recheck_upgrade Task Failed: Verify MaaS setup / Verify Check & Alarm Status

:+1:

👍
Confirmed:
#1483 is fixed by https://review.openstack.org/#/c/389795/ (OSA commit 2840b23fc413c7808fed6d2bd0c79e4eb0a71077)
rcbops/u-suk-dev#517 is fixed by https://review.openstack.org/#/c/391398/ (OSA commit 6f14768e983ec06aa417186fe82e3aecca96727a)
#1432 is fixed by https://review.openstack.org/#/c/389064/ (OSA commit 02701e3bf8370c15132e542c0fdec34c0dd31d60)
and all 3 of these commits are included in the new sha:
 ~/working/.../rpc-openstack/openstack-ansible [(detached from 2d0c46a)]
 $ git log --pretty=oneline | egrep '^2840b23|^6f14768e|^02701e3b'
2840b23fc413c7808fed6d2bd0c79e4eb0a71077 Remove the old rabbitmq queues
6f14768e983ec06aa417186fe82e3aecca96727a Stop all but one RabbitMQ node prior to upgrade
02701e3bf8370c15132e542c0fdec34c0dd31d60 Work around bad libvirt-python wheel


How to throw exception?

I need to return error with specific codes according to third party docs. Whatever I do it returns {"jsonrpc":"2.0","id":2032,"error":{"code":-32603,"message":"Internal error","data":null}}. How can I control error response?

Use Exception class from JsonRpc2, expample:
new Exception(Yii::t('yii', 'Invalid Request'), Exception::INVALID_REQUEST)


Insert a chart to the web page

Hello,
I've recently found this beautiful lib and tried it for my needs.
I've faced several problems working with XPlot and currently could not find how to display chart on a web page.
I use a https://suave.io to start a web server and the following code
open Suave
let html = chart.GetInlineHtml ()
startWebServer defaultConfig (Successful.OK html )

The problem is that if I do so, then I have no js that is responsible for Plotly display in header, so it fails to render on client site.
Is there any way I could use the chart html like this? Or this way is completely not the way of how this should be used?

Hello,
There is a GetHtml method that returns a full HTML document that you can serve as shown above. GetInlineHtml would be useful if you want to generate the document by yourself and display additional content besides the chart.

Thank you, I tried it with Plotly chart, but found only GetInlineHtml method.
As I saw, there's something like a builder pattern, so I can maybe build the html parts, such as html header with appropriate script file and so on.
In my case I really need InlineHtml, so my question is how can I add a Plotly lib to header and is there a method for this case?

Actually the GetHtml method for Plotly charts will be available in the next release. For now you just need to insert the inline markup in a simple document like this one https://github.com/TahaHachana/XPlot/blob/master/src/XPlot.Plotly/Main.fs#L9.

The GetHtml method is now available for Plotly charts too in version 1.4.2.


Create Changelog Guidance and Implement Automatically Pulled Release Notes

Had a good conversation with @AlexGhiondea with respect to how the JS team mandates that changelog.md gets updated properly, etc.
Need to codify this guidance, and ensure it doesn't conflict with other repositories (and have a story for those if it does).
After confirming that the approach should work, file issues for each language for the specific implementation as necessary.

Follow-up issues for .NET and Java repos have been filed.
Python already includes history.rst, during the migration from RST to markdown, we'll rename to changelog.md
JS already includes changelog.md.

The guidance is located here


remove default severity level to respect config

The former implementation always called perlcritic with the severity
level 'brutal'. This is not always wanted by every user - especially not
for users the start using perlcritic.
Furthermore, calling perlcritic with '--brutal' didn't respect the
severity set in perlcritic's configuration.
This commit just removes the hard wired '--brutal'.

LGTM
Thank you!


Question/Feature Request: Supply ports from a list of file using --ports

Hi, does the --ports flag accept a ports.txt file with one port on each line?
I tried:
--ports "$(cat /tmp/ports_20k.txt | grep -iv '^80$\|^443$\|^8080$\|^8443$' | sort -u | tr '\n' ',' | sed 's/,$/\n/')"

Error:
Argument list too long

Currently no, you can update the code and give me pull, should be pretty easy to implement.


convert to RESTful API

Consider making the API RESTful.  (There's no real reason for this, other than to make it more "modern.")

Hijacking this issue to take it in a bit of a different direction:  Use URL to determine which database is active (effectively doing away with config file entries, as they are too cumbersome to maintain).  Use config file instead for storing a root path for all databases accessible by SCWAL; in its absence, the root directory of the local hard disk is the path.  This is probably about as RESTful as it's going to get.

Resolved with commit 5455c5d7a0abb107f9fc02baa285442b653fe411.  Config file is now used to store port number and root path for all databases accessible by SCWAL.


Possible to retain the modified layout

Hello,
Referring to http://codepen.io/desandro/pen/azRmYv, is it possible for the elements in their dragged position to remain that way after page load?

You can save and set position using localStorage then manually set top and left

You can save and set position using localStorage then manually set top and left


Add commarch

preso and report

@Red-Two  Could you add the key name: to the yaml file? It's now required to have a valid ofCourse yaml key. Feel free to put your normal name, handle, or whatever you feel is appropriate.

@Nolski it is in the file... Line 6:  "name: William Russell"

Right. My bad. Pull from upstream (and then push) and you should be good to merge.

@Red-Two be sure to git pull and merge from upstream.


Is there a reason why @MvcBinding cannot be used at class level?

Hello,
I am wondering why @MvcBinding can only be used on fields, methods and parameters. (Probably because JAX-RS binding annotations can only be used on this types?)
Annotating all fields of a JAX-RS bean parameter with @MvcBinding looks way more common to me than annotating some fields and some not. Wouldn't it be convenient if a class could be annotated with @MvcBinding instead of annotating each field separately?
Maybe I am missing something here?

Thanks a lot for bringing this up. I agree that using @MvcBinding on all fields of a @BeanParam class is a very common case. So allowing @MvcBinding on classes could be a good option.
However, you are correct that @MvcBinding is closely integrated with the JAX-RS binding mechanism, which (AFAIK) does not support binding metadata on the class level. But this could be something to bring up to the JAX-RS EG. Maybe some JAX-RS implementations even support it?
@mvc-spec/expert-group Any other thoughts on this?

Although I agree that allowing @MvcBinding on classes would be a great way to simplify creating classes used with @BeanParam, I currently don't see any way we can implement this in the RI. JAX-RS only provides annotations directly placed on method parameters and fields. So there seems to be no way for us to get annotations placed on classes in the @BeanParam case.
Therefore, I'll change the milestone to Future for now. We should bring up this topic to the JAX-RS EG. Maybe future JAX-RS versions could provide this information in a portable way. And if we find some other way to implement it in the RI, we can provide this functionality in the RI on top of what MVC 1.0 requires and make it a requirement it in a later version of the spec. I created mvc-spec/ozark#196 to track this feature.

Moved to https://github.com/eclipse-ee4j/mvc-api/issues/35


Add additional data fields to the “Get Info” button to display more product details

Cannot view basic metadata/technical details for orthomosaics (e.g., spatial resolution).

Questions:

Is there a list of the desired extra fields to add?

-- We could track the settings from the ODM configuration from #16 below.
Response:
Ground sample distance (GSD), number of bands, file type? (TIFF, JPEG), file size, compression, source of product (uploaded or ODM). Yes as well as sensor used, number of acres.
The question here is, What are the diagnostic indicators of quality in remotely sensed UAS products? Directly related to SOW #1 above because garbage in-> garbage out. And we don’t have a handle on these indicators, as a community. Indicators should be remote sensing fundamental, to help project managers understand their mission-specific error tolerances. Whatever is chosen, this list should not be long. Suggest:

Point cloud density (pts/cubic m)
DEM point density (pts/sq m)
Horizontal and vertical accuracy
GSD....


Releases

This is an ongoing issue to trigger package registration

@JuliaRegistrator register branch=release-0.0.3

Registration pull request created: JuliaRegistries/General/51568
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.0.3 -m "<description of version>" b692460eca94d415eb6ef374416730c24b554e3b
git push origin v0.0.3

After addressing https://github.com/JuliaRegistries/General/pull/51568#issuecomment-1003786896
@JuliaRegistrator register branch=release-0.0.3

Registration pull request updated: JuliaRegistries/General/51568
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.0.3 -m "<description of version>" e6a72a70f5f281b0341605d5799945601525e377
git push origin v0.0.3

@JuliaRegistrator register branch=release-0.1.0

Registration pull request created: JuliaRegistries/General/54136
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 07ef160248ec181ef84ff991f279043c6b223c7b
git push origin v0.1.0

This is no longer needed, see https://github.com/JuliaQuantumControl/QuantumControlBase.jl/issues/4#issuecomment-1035615988


General Info

[X] I am running a modpack
[ ] I can reproduce this issue consistently in single-player
[X] I can reproduce this issue consistently in multi-player
[X] I have searched for this issue previously and it was either (1) not previously reported, or (2) previously fixed and I am having the same problem.
[ ] I am crashing and can provide my crash report(s)
[X] I am using the latest version of the mod

Forge version
43.3.5
Minecraft version
Minecraft 1.19.2
Mod version
Raided-1.19.2-0.1.3.jar
Java version
zulu-17-jre [Zulu Platform x64 Architecture]
Issue Description
[22Feb2024 03:58:41.135] [Render thread/WARN] [net.minecraft.network.syncher.SynchedEntityData/]: defineId called for: class com.mrbysco.raided.entity.Inquisitor from class com.mrbysco.raided.entity.Necromancer
Additional Information
No response

Will be fixed next version


Update for RxJava 1.x

[x] Change scope of depdendencies (compile -> provided)
[x] Update Firebase version
[ ] Update README (Add notice for RxJava version)
[ ] Move usage documentation from README to wiki

Coverage decreased (-1.9%) to 95.278% when pulling 200f5475d6e896de1cd5c88dcddb22ee2dea4778 on rxjava1 into 85a2e0d5c132f6db387edf308fcfa709e1c322b6 on master.

Coverage decreased (-1.4%) to 95.847% when pulling 3bbad620e432091806cc057e85c6671b4d174488 on rxjava1 into 85a2e0d5c132f6db387edf308fcfa709e1c322b6 on master.

Coverage decreased (-1.4%) to 95.847% when pulling 3bbad620e432091806cc057e85c6671b4d174488 on rxjava1 into 85a2e0d5c132f6db387edf308fcfa709e1c322b6 on master.

Coverage decreased (-1.4%) to 95.847% when pulling a790e2a7596544b1e4d5bab7164721995729f2e4 on rxjava1 into 85a2e0d5c132f6db387edf308fcfa709e1c322b6 on master.

Coverage decreased (-1.4%) to 95.847% when pulling a790e2a7596544b1e4d5bab7164721995729f2e4 on rxjava1 into 85a2e0d5c132f6db387edf308fcfa709e1c322b6 on master.

Coverage decreased (-1.8%) to 95.441% when pulling be56333f277eb509d7f283f76b178c3e44255169 on rxjava1 into 85a2e0d5c132f6db387edf308fcfa709e1c322b6 on master.

Coverage decreased (-1.9%) to 95.291% when pulling 334771289eacec0e9d7e5d9a1feddbe5ac9135f8 on rxjava1 into 85a2e0d5c132f6db387edf308fcfa709e1c322b6 on master.

Coverage decreased (-1.9%) to 95.335% when pulling d0f24f7799cd343559a179d3eaef13c2d7517ef9 on rxjava1 into 85a2e0d5c132f6db387edf308fcfa709e1c322b6 on master.

Released.

Coverage decreased (-2.0%) to 95.238% when pulling 696a9d0f64ec6fe6f7159bf006498e329eabc560 on rxjava1 into 85a2e0d5c132f6db387edf308fcfa709e1c322b6 on master.


Mesh Evaluation for the Optimization-based part

Hi Songyou,
Thanks again for sharing the code for your excellent work!
I found that the script "eval_meshes.py" is prepared for the learning-based method, but I want to evaluate the mesh result produced by the optimization-based part. Could you please give some suggestions for this?
Looking for your reply. :)
Best,
Runsong

Hi @Runsong123,
We use the same MeshEvaluator for evaluation of both optimization-based and learning-based methods.
For optimization-based method, you could try to adapt the following code:
n_points=50000
evaluator=MeshEvaluator(n_points)

gt_cache={}

def evaluate_mesh(gt_path, es_path, n_points=50000, normalize=True):
    es_mesh = trimesh.load_mesh(es_path)
    gt_scale = 1.

    # sample from gt mesh
    if gt_path in gt_cache.keys():
        gt_pointcloud, gt_normals, gt_scale = gt_cache[gt_path]
    else:
        if os.path.splitext(gt_path)[-1]=='.xyz': # DGP dataset
            gt_pointcloud = np.loadtxt(gt_path).astype(np.float32)
            gt_normals = None
        else:
            gt_mesh = trimesh.load_mesh(gt_path)
            if isinstance(gt_mesh, trimesh.Trimesh):
                gt_pointcloud, idx = gt_mesh.sample(n_points, return_index=True)
                gt_pointcloud = gt_pointcloud.astype(np.float32)
                gt_normals = gt_mesh.face_normals[idx]
            elif isinstance(gt_mesh, trimesh.PointCloud):
                gt_pointcloud = gt_mesh.vertices.astype(np.float32)
                gt_normals = None
            else:
                raise RuntimeError('Unknown data type!')
        # normalize according to the scale of the gt point cloud
        if normalize:
            center = gt_pointcloud.mean(0)
            gt_scale = np.abs(gt_pointcloud-center).max()
            print('Normalize with scale: %.2f' % gt_scale)
        gt_pointcloud /= gt_scale
        gt_cache.update({gt_path: (gt_pointcloud, gt_normals, gt_scale)})

    scale = np.abs(gt_pointcloud).max()
    if normalize:
        es_mesh.vertices /= gt_scale
        scale = 1.
    thresholds=np.linspace(1./1000, 1, 1000) * scale # for F-Score calculation
    result=evaluator.eval_mesh(es_mesh, gt_pointcloud, gt_normals, thresholds=thresholds)
    return result

Great, I will try this. Thanks so much!!
BTW, I am curious about the SRB dataset, I found the data contains the normal. (I use your script to download the SRB data). But I saw you do not use the normal to calculate the Normal Metric. Is there any problem with the given normals?

@Runsong123 I also checked the data but I don't think there is any normal provided in SRB (corresponding to deep_geometric_prior_data in the folder). Are you sure that you download it correctly with our script?

I use the link provided in scripts/download_optim_data.sh.
For example, I just open the "anchor.ply", I can see the following description:
ply
format binary_little_endian 1.0
element vertex 61460
property float x
property float y
property float z
property float nx
property float ny
property float nz
end_header

I  found the file type belongs to the ("trimesh.PointCloud").
Maybe it makes sense, cause the GT_point is sample from GT mesh. The file is just  point cloud with normals. (I guess)

Ah you are right @Runsong123, there are indeed normals provided, so it is really our oversight. Nevertheless, after checking the data again, we also realize that there are some regions that are only partially or not scanned, so there are missing areas (like a hole). The normals for the boundaries of those regions might not be accurate, which might have a negative impact in the evaluation. Still, we should have evaluated the normal consistency on SRB as well. Thanks for pointing it out!

Got it :)
In addition, I am wondering whether the normal consistency corresponds to the "normals" item or others?

I have tried to calculate the metric for the metric, I found the F-score and Normal C. is similar to your result showed in paper, but the Chamfer_L1 is much lower than your paper. (e,g, My results: 0.04  VS your paper results: 0.44 )

It is not just for IGR, but for all methods we scale the CD by 10x. Check out the note for explanation.

It is not just for IGR, but for all methods we scale the CD by 10x. Check out the note for explanation.

Got it, Thanks for your quick reply.
Cause I am very interested in scene/object-specific neural reconstruction, I just want to compare the existing method. Thanks for your patience!

It is not just for IGR, but for all methods we scale the CD by 10x. Check out the note for explanation. We were simply following this protocol, but actually it does not make too much sense for these datasets for optimization-based methods. Still, scale up 10x helps to better show the differences among different methods since 0.44 is more informative than 0.04 in my opinion.

Got it, Thanks for your quick reply.
Cause I am very interested in scene/object-specific neural reconstruction, I just want to compare the existing method. Thanks for your patience!


Modify file path of preferences.json

Fixes #156 by shifting preferences.json file into data folder

Codecov Report

Merging #220 (5c75f90) into master (3568d61) will decrease coverage by 0.38%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #220      +/-   ##
============================================
- Coverage     62.68%   62.30%   -0.39%
+ Complexity      670      663       -7
============================================
  Files            94       94
  Lines          2573     2573
  Branches        332      335       +3
============================================
- Hits           1613     1603      -10
- Misses          863      870       +7
- Partials         97      100       +3

Impacted Files
Coverage Δ

...c/main/java/seedu/address/commons/core/Config.java
68.18% <100.00%> (ø)

...va/seedu/address/logic/commands/DeleteCommand.java
75.00% <0.00%> (-25.00%)
:arrow_down:

...a/seedu/address/logic/parser/LogCommandParser.java
50.00% <0.00%> (-7.90%)
:arrow_down:

...in/java/seedu/address/logic/parser/ParserUtil.java
80.85% <0.00%> (-3.42%)
:arrow_down:

...eedu/address/logic/parser/DeleteCommandParser.java
72.72% <0.00%> (-2.28%)
:arrow_down:

src/main/java/seedu/address/model/tag/Tag.java
100.00% <0.00%> (ø)

src/main/java/seedu/address/ui/InfoDisplay.java
0.00% <0.00%> (ø)

.../java/seedu/address/logic/commands/LogCommand.java
92.42% <0.00%> (ø)

...a/seedu/address/logic/parser/AddCommandParser.java
100.00% <0.00%> (ø)

...seedu/address/logic/parser/AliasCommandParser.java
100.00% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3568d61...5c75f90. Read the comment docs.


env variables in the directory specific MRU

Could we have an option for replacing the environment variables in those paths as well? E.g. expand them to the full path first, then replace any environment variables.

Assuming FOO=/usr/local/dotfiles/nvim, you want to see entries like $FOO/init.vim? That would be confusing together with MRU /usr/local/etc/dotfiles.

@mhinz I guess it would be for some people but it wouldn't be confusing for me. I just prefer everything to be very short.
Also instead of showing the full path of the CWD, if it is a environment variable, instead show MRU $DOTFILES?

But it's missing the /nvim part. So you'd see:
MRU /usr/local/etc/dotfiles

[10]  $DOTFILES/init.vim

That's confusing, IMHO.
Apart from that, $DOTFILES/init.vim is basically an absolute path,
so it feels wrong to show in the "dir" listing which is relative by nature.
Also consider someone trying to use a non-default topic. At the moment it's simply 'MRU '. getcwd(). One would also have to expose the "unexpanded path" functionality somehow.
I like the feature for the "files" listing, but for "dir" it's a bit too much.

That doesn't mean we can come up with other means of shorting paths, though.
E.g. showing nvim/plugged/foo/blah/file.ext as n/p/f/b/file.ext under certain circumstances.

@mhinz I meant the top directory part, e.g. it says MRU /usr/local/etc/dotfiles. Instead if foo=/usr/local/etc/dotfiles then it could just say MRU $foo.
What do you mean non-default topic?

Yeah, but I mean tthe case of foo=/usr/local/etc/dotfiles/nvim. That's when that weird formatting would arise.

What do you mean non-default topic?

Actually I meant the section header:
  get(g:, 'startify_list_order', [
        \ ['   MRU'],            'files',
        \ ['   MRU '. getcwd()], 'dir',
        \ ['   Sessions'],       'sessions',
        \ ['   Bookmarks'],      'bookmarks',
        \ ])

O well, its not a big issue, thanks anyways.


Null Safety

Hi,
Can you implement null safety?

hi man .
yes  i will migrate .

hi , resolved this package in version null safety.


Website: Improving the comments of the interface to make them more clear

Minor improvement in the comments in the text of the interface to clarify some doubt coming from the community.

@eth-bot rerun


Bacalhau Node Describe has empty Bacalhau version

❯ bacalhau node describe n-7a67856d
Connection: CONNECTED
Info:
  BacalhauVersion:
    BuildDate: "0001-01-01T00:00:00Z"
    GOARCH: ""
    GOOS: ""
    GitCommit: ""
    GitVersion: ""

Can you give more details here? How did you install/build bacalhau? What client version were you using? What version the node was supposed to be using?


Update to Dockerfile to install plugins dependencies and addition of Singularity.def file

Hi Neville,
In this pull request, I update the Dockerfile to install the ctffind and IMOD since they are plugin dependencies.
For MotionCorr2 in order to install you have to apply to a form (not able to download using the command line). For docker to install it, we might have to download it beforehand and add it in the Ot2Rec repo.
I also changed the base from nvidia/cuda:11.4-devel-ubuntu20.04 to nvidia/cuda:10.1-devel-ubuntu18.04 (nvidia/cuda:10.1-devel-ubuntu20.04 does not exist as CUDA 10.1 is not build for Ubuntu 20.04) because IMOD 4.11 (recent version) is only compatible with CUDA 10 or lower. The installed python is still 3.8. I could had Dockerfile to install IMOD from source, but the most recent open source version that they have available is 4.0.26
I also added Singularity.def file (its the equivalent of Dockerfile for Singularity).
You can easily create a singularity container (Ot2Rec.sif) by running sudo singularity build Ot2Rec.sif Singularity.def
Like docker you can push the singularity containers to cloud.sylabs.io

I have edited the Dockerfile to install all necessary software for the plugins that can be available publicly (I think for all of them). These are IMOD, Savu, RedLionfishDeconv, ctffind
I removed the Singularity.def file since Joss told me that if users want singularity containers they can build them by pulling the docker containers from quay.io . I include it here in case you want to have it.
I am planning of pushing the docker container I made in the ot2rec repo in quay.io by the end of today under the tag ot2rec:latest_plus_plugin_dependencies . Let me know if you do not want me not to do this and if you want to review the pull request first, merge it with main, build the docker container yourself and push it to the ot2rec repo yourself
The Singularity.def is within the zip file. You can use it to build the singularity container without having to build it from an existing docker container the quay.io
Singularity.zip


Need to brainstorm how to fix Audience

Using current framework.
This should help us understand the bigger picture on what to do with signals as a whole, applicability, and guidance to developers.
Maybe precursor - we need a doc from Tanvir clearly describing full protocol, reliability, and what can and can't be assumed by clients.

Doing leader election with signals was added to the stress test. Here's the file: https://github.com/microsoft/FluidFramework/blob/main/packages/test/test-service-load/src/leaderElection.ts
Based on our logging, we found that all our leader lost elections do not recover. We are relying on the audience, what would we need to do to make it more reliable?
Here are the the average counts per run:
Data_eventName	avg_count_
fluid:telemetry:SignalLeaderElection:UnexpectedLeaderEventWarning	183.72
fluid:telemetry:SignalLeaderElection:LeaderLostEventError	74.28


Added resources limits in the configuration of helm chart

Description
Added support to create Kubernetes deployment with a resource limit.
https://github.com/KohlsTechnology/eunomia/issues/205
Type of change

Bugfix (non-breaking change which fixes an issue)

Checklist

[X] Documentation updated

Above is the screenshot of the changes.

I have made the suggested changes.


Is there a pre-commit job that does the opposite of this tool?

The walrus operator can be quite helpful but it is not yet widely adopted.  All the walrus-related packages on PyPI are either unrelated to := or they actively discourage its use.  It would be cool to have a pre-commit tool that would spot where := could be used and make the conversion.  This could accelerate the broader adoption of := on Python 3.8+ codebases.

@cclauss There is now: https://github.com/MarcoGorelli/auto-walrus#usage-as-a-pre-commit-hook 😜


⚠ Jenkins Plugins Artifactory has degraded performance

In 0c02ba9, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1264 ms

Resolved: Jenkins Plugins Artifactory performance has improved in e135d8b after 12 minutes.


mistake in sample code?

from the docs
First-time token generation
var provider = new GoogleCloudPrintOAuth2Provider(clientId, clientSecret);

// You should have your redirect uri here if your app is a server application, o.w. leaving blank is ok
var url = provider.BuildAuthorizationUrl(redirectUri);

/* Your method to retrieve authorization code from the above url */
var token = await provider.GenerateRefreshTokenAsync(authorizationCode, redirectUri);

this can't be right can it? the var url is not used in the call which says, "Your method to retrieve authorization code from the above url"

Yes, it's correct. It took me a long time to figure this out. You can test it out by putting a beak point in the line 'var token ....' as follows:
Enter the value of url into a browser. Sign into the GMail account owning the printers, if you have not done that already in your browser. Accept using the account, and you'll go to a page where the authorization code is in the URL window. Then copy and paste the code and assign it to the variable authorizationCode.
I did this programmatically with a Windows Forms application. I used Process.Start(url) to bring up the browser. I followed that line of code with the display of a form where I pasted in the authorization code.
Currently, I'm trying to do the same thing with a Web application and getting stuck at the point of trying to pop up a new browser instance. If you happen to know how to do that, please let me know.

@awerber do you do any freelance work by chance? I can get this working, so hoping to outsource it to someone--ideally someone with relevant experience like yourself!

I've never freelanced before. I work full time for a company, and I wrote all the GCP code while an employee. I can check with my supervisor about the rules related to this situation.
In the meanwhile, can you describe the nature of your project and the type of business use (or uses) for this functionality?


after entering to TH state on QM after the vision, ship body sometimes too damaged

Fixed thx MegaPiggy


Editor - Implement the data mapper step

This is a...

[x] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Documentation issue or request

Description
We need to move the example data mapper into a step configuration page (finally :smile:) The data mapper step doesn't contain a properties object, but it does create an action attribute that has data shape information.  The data mapper component supplies a save handler callback that is used to update the configuredProperties attribute on the step.
The data mapper component requires a ton of inputs to operate correctly.  The host component builds a list of input documents using the output data shapes of previous steps in the integration flow and creates a target document that reflects the input data shape of the subsequent step that has one.
Hopefully a lot of the angular code that initializes the data mapper could be carried forward into our adapter, then on the react side we could create a cleaner interface to send/receive data.

@riccardo-forina you're working on this, right?  Unassign if not :-)

I guess this is like done, right?

Think so, yeah! Forgot to close.


Merging master changes into csharp and adding initial C# implementation

Closing this PR since #32 has been opened against 'master'.