Fix for auto-categoricals in fastparquet

See https://github.com/dask/fastparquet/pull/112

Looks fine to me.  This makes me curious what Parquet's metadata solution is.  What kind of data can we put in there?  Are there conventions that other projects have adopted?  Is this in the metadata file or in each parquet file?

There is  key-value area of the global metadata for arbitrary information, and also key-value areas for each column chunk of each row group. All of this is stored in the global _metadata file, if using multiple files, and replicated to every data file (but on load we only read it once).
In this case, I make a key fastparquet.cats with a value of JSON encoded {'catfield1': num_cats, ...}.

I know I'm late to the party on weighing into names, but thoughts on using
the full name categories rather than cats?
On Fri, Mar 24, 2017 at 8:48 AM, Martin Durant<EMAIL_ADDRESS>wrote:

There is key-value area of the global metadata for arbitrary information,
and also key-value areas for each column chunk of each row group. All of
this is stored in the global _metadata file, if using multiple files, and
replicated to every data file (but on load we only read it once).
In this case, I make a key fastparquet.cats with a value of JSON encoded
{'catfield1': num_cats, ...}.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/pull/2113#issuecomment-289013749, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszMSBHmtPmrcuuWIFUDPapyuVMD3tks5ro7uLgaJpZM4Mln4l
.

I don't mind, but this is not meant for public consumption, and "cats" is a frequent variable name for the same purpose in the code.
Was there anything else you thought should be stored in a similar way?

We call it cats internally, but we're putting this into data that other projects may be asked to understand.  I think it is better to choose names that follow more standard conventions if possible.  Short names should probably be discouraged.  Ideally we would be able to find a name that other projects might say "oh hey, that is a good idea" and then choose to adopt on their own.  Adding fastparquet to the name might preclude that.

Perhaps ask on a Parquet mailing list?  It might be wise to ask somewhere where the broader community can weigh in on the right conventions here.
cc @wesm, presumably you have run into this problem.  Thoughts?

There aren't a lot of conventions I'm aware of surrounding the key-value metadata, but can definitely ask on the Parquet mailing list.
I will say surrounding this that, semantically, dictionary-encoded data in Parquet is not the same as pandas.Categorical, so other systems in general will decode such data as though it were PLAIN encoded.  Because of the RLE-encoding benefits of the dictionary encoding, most implementations have dictionary encoding turned on for all types and fail over to plain encoding mid-stream when the dictionaries exceed a certain size threshold.

@wesm presumably Arrow will also have this problem, where you'll have to decide if you want to round-trip the fact that a column is categorical.  Do you have any intention of propagating this through the parquet-cpp bindings?

Yes, we will eventually need to store metadata to indicate when a particular Parquet logical type is used to represent more than one Arrow type (e.g. Arrow supports time as seconds through nanoseconds, but Parquet only has millis and micros). I figure as long as the stored data isn't "wrong", i.e. the decoded data on other platforms won't be misinterpreted, then it's okay.
Since we recently augmented the date and time types in Arrow I suspect in the next month or two we'll address faithful roundtripping of all these types to Parquet.

Do you have any intention of roundtripping the fact that a pandas column is a categorical to parquet?  If so then do you want to establish a shared convention now?

Note that we also want to keep track of how many labels in total the categorical can have, so that we need only assign an array of codes big enough to the values.

Yep, pandas.Categorical becomes arrow::DictionaryArray, so we will want to persist that metadata -- would be good to standardize the "pandas metadata". We'll want to be able to hash back to Dictionary/Categorical in the event that the Parquet reader failed over to PLAIN encoding -- cc @xhochy
I created PARQUET-924 to capture this. There is also ARROW-462 which I need to implement in the next couple months

After thinking a bit about this, we should move this discussion to the parquet ML or our bi-weekly hangouts. Off the top of my head I could think of the following possibilities:

Add an additional flag / metadata to the schema in https://github.com/apache/parquet-format/blob/4bddbadf79e20a32152076fbedae0c3ce77fb531/src/main/thrift/parquet.thrift#L220
Add a new ConvertedType UTF8_CATEGORICAL
Add a new type for categoricals (this would equal the implementation in Arrow)

Number 1 is the only option that would work well with old readers, 2+3 would produce files that cannot be read correctly by older implementations.
As we might also want to support R's factor, we should not abuse the metadata but augment the actual format to  support this. Currently old readers will benefit from neither implementation, so adding a backward-compatible format change should be the best option.

The notes above are interesting - please let me know if this discussion has moved elsewhere.
From the point of view of this PR it is moot, however, how fastparquet decides which columns are categorical if passed the now-default categories=None is just an implementation detail from dask's PoV.

Per @xhochy's note, any discussions about the format will happen on the Parquet mailing list or in the biweekly syncs (with meeting notes sent to the ML), please feel free to join us.
I'd like for dask to be able to use parquet-cpp+pyarrow for Parquet reads at some point, so it would be good to not have divergent semantics.

I'd like for dask to be able to use parquet-cpp+pyarrow for Parquet reads at some point, so it would be good to not have divergent semantics.

+1

+1 from me

Sent a mail about this to the Parquet ML<EMAIL_ADDRESS>@martindurant didn't explicitly cc you as I haven't got an email address from you ;)


Fix split

Follow up to #56 which was broken due to duplicated package names.
This can be merged provided the binaries all have different names after the test is complete. In particular Linux should have 3 filenames (python 27/36/37) macOS should have 6 unique filenames (Fortran 4/7 + python 27/36/37) for each of root_base, root-dependencies, root-binaries and root.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

The change to the README got wiped by the rerender; it needs to be changed in the YAML.

(here) https://github.com/conda-forge/root-feedstock/blob/e821fa61a6d75ef367c1c0babf41ca8a2eb48923/recipe/meta.yaml#L312-L316

Am I reading this correctly and the py version, etc. are still missing? I'm looking at the upload names on the packages. Only one as the py version in it.

Base and binary are missing it. base with and underscore is still irritating.

Are you sure that it doesn't come from the run requirements instead? And none of them seem to have a FORTRAN version but could be missing it.

See https://github.com/chrisburr/root-feedstock/pull/2.

Thanks @henryiii looks great!

Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.
Here's what I've got...
For recipe:

The top level meta key .build_deps is unexpected
The top level meta key .host_deps is unexpected

We could always manually copy and paste to get this working while we get it fixed. And anchors will still help when we don't add to the list (~1/2 the time, I think). Conda should support some way to merge lists (since YAML won't; that would have fixed the problem). (Note: You have to anchor it the first time it is used, not provide it separately, which would be nicer, IMO)

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

We could always manually copy and paste to get this working while we get it fixed. And anchors will still help when we don't add to the list (~1/2 the time, I think). Conda should support some way to merge lists (since YAML won't; that would have fixed the problem).

Yeah it seems to be needed as the hash is still wrong....

Note: You have to anchor it the first time it is used, not provide it separately, which would be nicer, IMO

Definitely 🤦♂

(Not worth adding them at the moment, just a thought to clean it up a little, but probably the simpler option is better and then fixing the bug for the long run)

Finally, LGTM! I'll tidy it up later when the bugs are fixed.


refactor/dict-notation

This reverts back to using an in-memory dict notation for simplicity, and significantly improves performance for loading bais by buffering the file contents in-memory.
@madopal could you review? Thanks!

Getting even tighter, other than maybe const def, lgtm!

Awesomesauce, thanks!


✨ Added trigger points for updating the storage

Minor: Added a global key option
Description
Major

A need to trigger points to persist data in storage. An operation in my app updates the state multiple times but the data is required to be persisted only once the operation finished. Hence for performance reasons, storing the data on $subscribe is not good.
For the above to work a method has also been exposed to trigger the storage updation manually from inside the store

Minor

A global option for key is added which can be used to have a consistent naming convention for all the store modules persisting data in an app. Example can be to always prefix the key names
Created a common util consoleError to log errors to console with a tag.

Linked Issues
Additional context
I have updated the docs as well but not fully confident on the clarity of it and variable/function names. Suggestions are appreciated.

Wow that's a lot to unwrap. Thanks a lot for the contribution. My only concern before considering a review on it is there is no issue linked to all that is proposed here. Also it would be great to break this down into multiple issues/PR per feature. 👍

I know this is a PR. And there are no issuese related but, for my use case,   i would also need to restore the state (manually) on demand. Not on store creation. Is this possible?

@suchwerk I think that can be done. Let me make those changes

@prazdevs I will open an issue and break down this PR. Cancelling this for the same.


"openvpncloud_user" warning in terraform's output

Hello,
I'm trying to create User via next code:
resource "openvpncloud_user" "name" {
  username   = "test"
  email      =<EMAIL_ADDRESS>  first_name = "test1111"
  last_name  = "test123"
}

user being created OK, but i see this output:
Terraform will perform the following actions:

  # openvpncloud_user.name will be created
  + resource "openvpncloud_user" "name" {
      + email      =<EMAIL_ADDRESS>      + first_name = "test1111"
      + id         = (known after apply)
      + last_name  = "test123"
      + role       = "MEMBER"
      + username   = "test"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

openvpncloud_user.name: Creating...
openvpncloud_user.name: Creation complete after 1s [id=733f8355-8e4c-438d-882f-04176060d929]
╷
│ Warning: The user's role cannot be changed using the code.
│
│   with openvpncloud_user.name,
│   on main.tf line 40, in resource "openvpncloud_user" "name":
│   40: resource "openvpncloud_user" "name" {
│
│ There is a bug in OpenVPN Cloud API that prevents setting the user's role during the creation. All users are created as Members by default. Once it's fixed, the provider will be
│ updated accordingly.
╵

Is this expected?

I've verified that I can add a new user with
role       = "ADMIN"
so this bug has apparently been fixed and this Warning should be removed from the code.

We've published new version of Terraform Provider to Registry: https://registry.terraform.io/providers/OpenVPN/cloudconnexa/latest
Going forward only https://registry.terraform.io/providers/OpenVPN/cloudconnexa/latest will be developed.
Please give new provider a try, hopefully it will fix your issue.
In case if problem persists - please open new "Issue" (https://github.com/OpenVPN/terraform-provider-cloudconnexa/issues)
Sorry for inconvenience.


add useRatioPresenter config

fix #53

@iBinh The ratio values in RatioSelector should update with the original image width/height ratio.

If original image's height > its width, we use 2:3/3:4/3:5 etc
If original image's width > its height, we use 3:2/4:3/5:3 etc
When the rotation button is clicked, ratio values need to be changed as well.

Fixed

@iBinh The ratio values in RatioSelector should update with the original image width/height ratio.

If original image's height > its width, we use 2:3/3:4/3:5 etc
If original image's width > its height, we use 3:2/4:3/5:3 etc
When the rotation button is clicked, ratio values need to be changed as well.

@iBinh Looks good! I think we are almost there.
Can you center RatioSelector horizontally when the device is iPad?
Also, if you want, you can also add an example to show this new feature in the example project and update README.

fixed


[MLIR][XLA] HLO to LHLO buffer assignment using live variable analysis

This PR adds blocks signature conversion and buffer allocation using live variable analysis.

@dfki-ehna Can you please address the pifon2a's comments and resolve conflicts? Thanks!


Getting firstName of quoted user.

Question

I have a bot that parses the message when a user '@' another user, I was wondering if the library has a feature to get the firstName of the quoted user.

bot.on('message', (msg) => {
    console.dir(msg)
    getUserMention(msg)
})

const getUserMention = (msg) => {
    if (msg.entities && msg.entities.length > 0) {
        // Users with username @
        let mentions = msg.entities.filter(e => e.type === 'mention')
        // Users without username @
        let text_mentions =  msg.entities.filter(e => e.type === 'text_mention')

        if (mentions) {
            mentions.forEach(mention => {
                let mentionUsername = msg.text.substring(mention.offset, mention.offset + mention.length)
                // in the mentions of the users with alias the "user" object is not present.
                // So the better way is use a userbot for resolve the alias or save in the database the alias and the user id
                // when the users talk with the bot on in the chart
                console.dir(mentionUsername)
            })
        }

        if(text_mentions) {
            text_mentions.forEach(mention => {
                // User data
                console.dir(text_mentions.user)
            })
        }
    }
}


[Feature Request] Cloud Anchors API (ARcore & ARkit)

Cloud Anchors API (ARcore & ARkit)

Any plans on this please?


Update the documentation to include changes made to the ILB ASE certificates

As per the new ASE create experience, any ASE created after May 2019, doesn't need a certificate to be uploaded. The documentation needs to be modified to address this change.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f3a8caa-796a-18ab-480c-161e6c806782
Version Independent ID: 9b8988f6-79d9-4558-5c0c-983ceb857a76
Content: Certificates and the App Service Environment - Azure
Content Source: articles/app-service/environment/certificates.md
Service: app-service
GitHub Login: @ccompy
Microsoft Alias: ccompy

@kaushalp Thanks for your comment. We are actively investigating and will get back to you shortly.

@kaushalp, That's a great suggestion! Thanks for sharing your feedback here for benefiting the users.
This document https://docs.microsoft.com/azure/app-service/environment/create-ilb-ase - outlines steps for creating and using ILB ASE and details the new changes – ‘Earlier versions of the ILB ASE required you to provide a domain suffix and a default certificate for HTTPS connections. The domain suffix is no longer collected at ILB ASE creation and a default certificate is also no longer collected. When you create an ILB ASE now, the default certificate is provided by Microsoft and is trusted by the browser. You are still able to set custom domain names on apps in your ASE and set certificates on those custom domain names. ‘with a doc section ‘ILB ASEs made before May 2019’ for bringing clarity on the differences.
You could contribute on the doc update with a Pull Request (PR) by following the steps below. If you know the change that is needed in an article, submit the changes directly using a pull request:

From the Azure Document where you wish to propose a change, click on “Edit” option (top right-hand corner). * Sign into GitHub if you aren't already.
On the GitHub content source, right side of the document header is a Pencil icon.
Propose the change you wish to see by making an edit to the file. Update the markdown to make the change.
In the “Propose file change” title box below the markdown editor, provide a title and description of your change. Be short, but accurate.
Click “Propose file change”. This opens a page comparing the changes you've made. If you’re satisfied you made all the changes you intended to, click “Create pull request”.

The author will get notified and would review the update for accuracy. Having said that, I have shared your feedback with the content author (@ccompy) for further review on this old document.

@AjayKumar-MSFT  There are a couple of changes requires to be made, which is best suited towards the author.

@kaushalp, Thanks for the follow-up. I have assigned the issue to the content author to review further and update the document as appropriate.

Just wanted to highlight a documentation bug in the ILB ASE creation doc which was updated recently. This is in the DNS configuration section.
https://docs.microsoft.com/en-us/azure/app-service/environment/create-ilb-ase#dns-configuration
Shouldn’t this statement “create a zone in .scm.appserviceenvironment.net named scm” be like “create a zone in scm..appserviceenvironment.net named scm”?
This may cause a customer misconfigure DNS entries and hence not able to access the SCM site.

@DeepGit01, Thanks for sharing your valuable feedback for doc improvements, I would encourage you to share the feedback on the same doc (https://docs.microsoft.com/en-us/azure/app-service/environment/create-ilb-ase#dns-configuration) for visibility.

@AjayKumar-MSFT  @kaushalp  common  guys it's been almost half an year regarding this and no update was made.

Apologies for the delay! I understand the frustration with this.
@ccompy, Requesting you to review this feedback and help make appropriate changes.

Thank you for the feedback. Both comments should have been incorporated in the current documentation.
#please-close


Brazilian Portuguese (pt-BR) language support

Really anxious for this feature!

Hi @HinePo,
Support for Portuguese is on the way and should be announced and released very soon!


Update sbt to 1.4.2

Updates org.scala-sbt:sbt from 1.3.13 to 1.4.2.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: library-update, semver-minor

Close this and fix the Mergify config first. Mergify should auto-merge this but it seems the build success check is not correct yet.


fix: updates schema path on update api

Description of changes
Updates schema for gql schema when pull into new dir

Issue #, if available

Description of how you validated changes
Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #9005 (1c2139e) into api-ext-rebase-3 (f5bc188) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           api-ext-rebase-3    #9005   +/-   ##
=================================================
  Coverage             55.49%   55.49%
=================================================
  Files                   883      883
  Lines                 49940    49942    +2
  Branches              10757    10758    +1
=================================================
+ Hits                  27714    27716    +2
  Misses                20183    20183
  Partials               2043     2043

Impacted Files
Coverage Δ

...tils/awscloudformation/cfn-api-artifact-handler.ts
85.35% <100.00%> (+0.18%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bc188...1c2139e. Read the comment docs.


Improve projective data augmentation

Currently augmentation on images and keypoints is restricted to a random crop by default. fastai uses much more aggressive augmentation, and so should we. This should be straightforward to implement using DataAugmentation.jl's composable ProjectiveTransform.
The result should be something mirroring the functionality of fastai's aug_transforms.
To accomplish this, the following affine transformations should be added to DataAugmentation.jl:

[x] Vertical and horizontal flip
[x] Random rotation
[ ] Random warp
[ ] Random zoom
[ ] Random lighting

And then a helper in FastAI.jl that creates the augmentations which can be passed to ProjectiveTransforms.

These augmentations will be added to DataAugmentation.jl first and then used in FastAI.jl.

Random lighting (brightness and contrast adjustment) DataAugmentation.jl#28

Implemented with the DataAugmentation.jl 0.2.2 release and FastAI.augs_projection, FastAI.augs_color. See this tutorial.


Ordering of compatibility matrix columns

The compatibility matrix is currently ordered the following way:
intel-classic 2021.1.2 -> intel-classic 2021.10 -> ... -> intel-classic 2021.2
It would be great to have it ordered according to their numeric values:
intel-classic 2021.1.2 -> intel-classic 2021.2 -> ... -> intel-classic 2021.10
It would make it easier to find the latest release of a compiler.
Screenshot:

closed by #103


Otel payloads examples implementation

Otel payloads examples implementation
Signed-off-by: Patryk Matyjasek<EMAIL_ADDRESS>

Closing this as the backend team declared they don't need this now.


Document "source": "url" (GET params)

Currently this possible use case is not appearing neither in the docs nor in examples:
    "trigger-rule":
    {
      "match":
      {
        "type": "value",
        "value": "123",
        "parameter":
        {
          "source": "url",
          "name": "token"
        }
      }
    }

I mean "source": "url" here. GET params are referred as query, which is what I have attempted to name them in the first place: { "source": "query", "name": "token" }. It took a while to figure out that url needs to be used instead of query (had to read the source for that).
Would be good all accepted values for source were listed somewhere in README.md or at least used in the example.
Thanks a lot for making this tool available @adnanh!

Anyone can update the wiki docs.  No PR required.

Ah, sure! Done: https://github.com/adnanh/webhook/wiki/Hook-Examples
Could you please have a look at #87 and #88?


Doxter-field content only showing up after interaction

I'm using the Doxter-field from the plugin in my main content-Matrix. It works great and saves correctly.
But: When I go to edit an article, all Doxter-fields are empty. They also show an empty scroll-bar on the right. As soon as I interact with a field (click it for example), it's content shows up as expected and the scroll-bar is gone. I have to do that for each individual field though!
Versions:

Doxter: 3.1.5
CraftCMS: 3.0.0-RC16.1
Chromium: 65.0.3325.181
FireFox: 59.0.2

I can't see any errors in the browser console, except for this message (multiple times):
Double-instantiating a menu button on an element

The log says it's from garnish.js:220, not sure if it's related.

For completions sake, I updated to the newest Craft 3.0.0-RC17.1 and deleted and re-created everything in web/cpressources (because I was getting other JS errors after the update).
The problem remains the same.

Okay, I did some digging:

The issue seems to only occur, if the field is not on the first tab of an entry-type
It seems to be an issue with the editor-library SimpleMDE: https://github.com/sparksuite/simplemde-markdown-editor/issues/596

I'm going to investigate this further and get back with any findings.

I can confirm that the solution proposed in the above bug report fixes the issue. However, sadly there is no nice or build-in way to tell if the tabs on the editor have changed:

New tabs always change the hash in the URL-bar. There is the hashchange-event on the window-object, but that doesn't really work in all browsers
AFAIK, the tabs are created with jQuery UI which exposes an tabactivated-event on the navigation-element. This however is not fired.
A very simple working solution is to listen for click-events on the navigation-element.

All the above solutions could easily be broken by a Craft update. The "best" way to handle this would be, if the Craft JS code would fire an event when the tabs are changed.
Any advice on what you would accept as a PR @selvinortiz or @gui-gui ?

Okay, so I did some more digging:

The JS method in Craft that actually handles switching tabs is located in CP.js:250
This function manually triggers the resize and scroll-events on window and document respectively

The resize-element also triggers, when the browser-window is resized. Probably wouldn't be a problem but who knows
The scroll-element could potentially be triggered very often, although for some reason it doesn't trigger when I scroll on the page. But: The comment right above it says, that this is a fix for Redactor, which is no longer part of the base system with Craft 3. Who knows how long this will exist there...

CodeMirror (what SimpleMDE uses under the hood), already listens to the windows resize-event, and it works correctly when you resize the window but not when switching tabs.
Looking at the source of jQuery, it looks like it's implementation of on and trigger doesn't use the addEventListener-API that CodeMirror uses. Maybe that's why the handler isn't being called when tabs are switched?

This SO answer seems to support that claim.

So what now? Well, reading the CodeMirror docs on the refresh-function, it says:

If your code does something to change the size of the editor element (window resizes are already listened for), or unhides it, you should probably follow up by calling this method to ensure CodeMirror is still looking as intended.

Sounds like our use-case. My suggestion is to add a jQuery event-handler for the resize-event and then calling refresh every time it's triggered. I have tested it and it seems to work.
I'll make a pull-request and be done with this. Running out of beer...

@LukasKnuth Seems like your findings are in line with other things I've noticed with the editor as well. For example, live preview sucks right now because the editor does not behave well across browsers due to the way Craft clones content when in preview mode.
This is one of the reasons why I haven't been overly excited to work on Doxter lately, just too many little issues like this that take so much time to get right.
Happy to send you some beer for you work ;)


Grid2 nested Grids - missing variables

I use nested Grid2 grids in my component.
The nested grids get variables for each level with the number of level. Instead of just using the values of the parent grid, it mirrors the values in new variables.
In my case, this results in the following variable being used but never being assigned.
var(--Grid-columnsLevel2)

This is another grid inside another grid as an example. In the width property, the variable --Grid-columnsLevel1 is used but never assigned:
<Grid2 container justifyContent="space-between" alignItems="center"> <DatePicker sx={{width: "70%"}} label="Versandtag" value={props.datum} onChange={props.onChange} disablePast={true}/> <FormGroup> <FormControlLabel control={<Switch checked={props.lieferterminFix} onChange={(event) => props.onChangeLieferterminFix(event.target.checked)}/>} label="Fix"/> </FormGroup> </Grid2>
I do not know when this error occurred, because at the beginning it all worked fine. Switch back to previous commits does not help, so i do not think it's an error in my code.
Any suggestions?
Version: 5.13.3

Can you copy/paste your code into a Codesandbox so I can debug it? Here is a template: https://codesandbox.io/s/mui-issue-latest-s2dsx

https://codesandbox.io/s/strange-jackson-r4yznr
I hope I have done it right.

Went through the code quickly and seems the level is getting incremented for each level of Grid regardless if it's a container or not.
While the CSS variables are obviously created for the containers.

Increments unstable_level for each Grid in the tree:
https://github.com/mui/material-ui/blob/master/packages/mui-system/src/Unstable_Grid/createGrid.tsx#L164-L171

Writes CSS variable if only for containers using own unstable_level:
https://github.com/mui/material-ui/blob/master/packages/mui-system/src/Unstable_Grid/gridGenerator.ts#L108-L119

Uses CSS variable of  unstable_level - 1, which based on the above might not be a container
https://github.com/mui/material-ui/blob/master/packages/mui-system/src/Unstable_Grid/gridGenerator.ts#L38-L43

I can't know for sure as I'm using this library only for a couple of days, so I'm not too familiar with the source, but if not that, I shouldn't be too far off.

In the mean time, for those who needs to use Grid2, make sure your Grid container is a direct child of another Grid container.
Or do the complete opposite. Put a non Grid element in between. You won't get any inheritance but at least it won't break.

I can replicate the issue with this code
<Grid container>
  <Grid>
     <Grid container>
        <Grid />

--Grid-columnsLevel1 was not set
The quick solution for me is to put any component between the first Grid item and the second Grid container, including a Fragment, like this
<Grid container>
  <Grid>
    <>
      Grid container>
        <Grid />

This will prevent the second container from being treated as a nested Grid container


Modified tabstop replacement to allow for arbitrary length stop numbers in placeholder tabstops

This is an implementation of a recent feature request to allow for more than 9 tabstops in snippet replacements. I have modified the implementation of placeholder tabstops to allow for arbitrary length stop numbers by splitting the inside of the placeholder by the first colon. I have tested the modified getTabstops function locally and it seems to be behaving properly, but I expect further testing might be in order to make sure the modifications don't get in the way of efficiency or have any extreme edge cases.

Fixes #255

Thanks for the PR. Will merge after I get around to testing this; do you happen to have any example snippets I can use to test?

Here is a snippet that you should be able to test with
{trigger: "M([\\ pbvBV])(\\d)(\\d)", replacement: (m) => {
        var type = m[1] === ' ' ? '' : m[1]
        var n = 0
        var res = `\\begin{${type}matrix}`
        res += "\n"
        for (let i = 0; i < m[2]; i++) {
            for (let j = 0; j < m[3]; j++) {
                res += `\${${n++}:0}`
                if (j + 1 != m[3]) {
                    res += " & "
                } else {
                    if (i + 1 != m[2]) {
                        res += " \\\\"
                    }
                    res += "\n"
                }
            }
        }
        res += `\\end{${type}matrix}\${${n++}:}`
        return res
    }, options: "mr"},

This is a snippet to expand matrices. The replacement looks for a capital M followed by a single letter for the type of matrix (b for bmatrix, p for pmatrix, etc.) followed by a single digit for the number of rows, followed by a single digit for the number of columns. After pressing the trigger key, this should expand into a preformatted matrix filled with 0s that has tabstops for each entry and a final tabstop outside of matrix. The snippet works great so long as the number of elements is less than 9 (for example, Mb33 creates a 3x3 bmatrix perfectly fine) but any more elements (for example, expanding Mb44) currently creates no tabstops after the first 10. The modified code for parsing these tabstops should however allow you to tab all the way through the matrix for as large as you'd like to make it.

Thanks! I tried Mp55 to create a 5x5 matrix, and the tabstops are created successfully, but when pressing Tab they get visited in the wrong order. More specifically, the tabstops are visited in the order 0 -> 1 -> 10 -> 11 -> 12 -> .... Can you reproduce this?

Thanks!


Occasional segfaults when using Client from multiple threads

Describe the bug
Our application shares Client instances across multiple threads.  Occasionally, we are seeing segfaults in production when the Client is first used. It appears to always occur during SSL handshaking.
Expected Behavior
It is expected that Client instances are fully thread-safe.
Current Behavior
This is a thread-dump when observed in production:
Thread 0x00007f42ff081640 (most recent call first):
File "/root/.pyenv/versions/3.12.2/lib/python3.12/ssl.py", line 1320 in do_handshake
File "/root/.pyenv/versions/3.12.2/lib/python3.12/ssl.py", line 1042 in _create
File "/root/.pyenv/versions/3.12.2/lib/python3.12/ssl.py", line 455 in wrap_socket
File "/venv/lib/python3.12/site-packages/urllib3/util/ssl_.py", line 493 in _ssl_wrap_socket_impl
File "/venv/lib/python3.12/site-packages/urllib3/util/ssl_.py", line 449 in ssl_wrap_socket
File "/venv/lib/python3.12/site-packages/urllib3/connection.py", line 419 in connect
File "/venv/lib/python3.12/site-packages/urllib3/connectionpool.py", line 1058 in _validate_conn
File "/venv/lib/python3.12/site-packages/urllib3/connectionpool.py", line 404 in _make_request
File "/venv/lib/python3.12/site-packages/urllib3/connectionpool.py", line 715 in urlopen
File "/venv/lib/python3.12/site-packages/botocore/httpsession.py", line 464 in send
File "/venv/lib/python3.12/site-packages/botocore/endpoint.py", line 377 in _send
File "/venv/lib/python3.12/site-packages/botocore/endpoint.py", line 281 in _do_get_response
File "/venv/lib/python3.12/site-packages/botocore/endpoint.py", line 241 in _get_response
File "/venv/lib/python3.12/site-packages/botocore/endpoint.py", line 199 in _send_request
File "/venv/lib/python3.12/site-packages/botocore/endpoint.py", line 119 in make_request
File "/venv/lib/python3.12/site-packages/botocore/client.py", line 1027 in _make_request
File "/venv/lib/python3.12/site-packages/botocore/client.py", line 1001 in _make_api_call
File "/venv/lib/python3.12/site-packages/botocore/client.py", line 565 in _api_call
File "/venv/lib/python3.12/site-packages/botocore/paginate.py", line 357 in _make_request
File "/venv/lib/python3.12/site-packages/botocore/paginate.py", line 269 in __iter__

This is a core dump when reproduced on a Mac with the script below:
-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               python3.12 [93042]
Path:                  /Users/USER/*/python3.12
Identifier:            python3.12
Version:               ???
Code Type:             ARM-64 (Native)
Parent Process:        bash [84911]
Responsible:           Terminal [655]
User ID:               501

Date/Time:             2024-04-18 20:14:30.2841 -0400
OS Version:            macOS 14.0 (23A344)
Report Version:        12
Anonymous UUID:        873D96CF-317F-4F91-BE8A-97AA427FCEFF

Sleep/Wake UUID:       ABFCC204-596F-46DE-B567-399394B3ACEE

Time Awake Since Boot: 1800000 seconds
Time Since Wake:       6461 seconds

System Integrity Protection: enabled

Crashed Thread:        3

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000004
Exception Codes:       0x0000000000000001, 0x0000000000000004

Termination Reason:    Namespace SIGNAL, Code 11 Segmentation fault: 11
Terminating Process:   exc handler [93042]

VM Region Info: 0x4 is not in any region.  Bytes before following region:<PHONE_NUMBER>
      REGION TYPE                    START - END         [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      UNUSED SPACE AT START
--->
      __TEXT                      100fd4000-100fd8000    [   16K] r-x/r-x SM=COW  .../*/python3.12

Thread 0::  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	       0x187c3a0ac __psynch_cvwait + 8
1   libsystem_pthread.dylib       	       0x187c775fc _pthread_cond_wait + 1228
2   libpython3.12.dylib           	       0x101bf8c7c PyThread_acquire_lock_timed + 484
3   libpython3.12.dylib           	       0x101c5979c acquire_timed + 148
4   libpython3.12.dylib           	       0x101c59444 lock_PyThread_acquire_lock + 56
5   libpython3.12.dylib           	       0x101aac464 method_vectorcall_VARARGS_KEYWORDS + 272
6   libpython3.12.dylib           	       0x101aa0b98 PyObject_Vectorcall + 88
7   libpython3.12.dylib           	       0x101b90f48 _PyEval_EvalFrameDefault + 37756
8   libpython3.12.dylib           	       0x101b8796c PyEval_EvalCode + 288
9   libpython3.12.dylib           	       0x101be7c90 run_mod + 168
10  libpython3.12.dylib           	       0x101be623c _PyRun_SimpleFileObject + 876
11  libpython3.12.dylib           	       0x101be5c70 _PyRun_AnyFileObject + 160
12  libpython3.12.dylib           	       0x101c09084 Py_RunMain + 1916
13  libpython3.12.dylib           	       0x101c09444 pymain_main + 328
14  libpython3.12.dylib           	       0x101c094e4 Py_BytesMain + 40
15  dyld                          	       0x1878fd058 start + 2224

Thread 1:
0   libsystem_pthread.dylib       	       0x187c71e28 start_wqthread + 0

Thread 2:
0   libsystem_pthread.dylib       	       0x187c71e28 start_wqthread + 0

Thread 3 Crashed:
0   libcrypto.3.dylib             	       0x102204cdc X509_LOOKUP_by_subject_ex + 0
1   libcrypto.3.dylib             	       0x102205338 X509_STORE_CTX_get_by_subject + 200
2   libcrypto.3.dylib             	       0x102205d10 X509_STORE_CTX_get1_issuer + 116
3   libcrypto.3.dylib             	       0x10220ad00 build_chain + 512
4   libcrypto.3.dylib             	       0x1022082a0 verify_chain + 40
5   libcrypto.3.dylib             	       0x102208130 X509_verify_cert + 516
6   libssl.3.dylib                	       0x1025974b0 ssl_verify_cert_chain + 476
7   libssl.3.dylib                	       0x1025c9b48 tls_post_process_server_certificate + 60
8   libssl.3.dylib                	       0x1025c4ce8 state_machine + 1392
9   _ssl.cpython-312-darwin.so    	       0x1019b7bdc _ssl__SSLSocket_do_handshake + 316
10  libpython3.12.dylib           	       0x101aac6d4 method_vectorcall_NOARGS + 144
11  libpython3.12.dylib           	       0x101aa0b98 PyObject_Vectorcall + 88
12  libpython3.12.dylib           	       0x101b90f48 _PyEval_EvalFrameDefault + 37756
13  libpython3.12.dylib           	       0x101aa344c method_vectorcall + 328
14  libpython3.12.dylib           	       0x101c58e44 thread_run + 64
15  libpython3.12.dylib           	       0x101bf8818 pythread_wrapper + 28
16  libsystem_pthread.dylib       	       0x187c77034 _pthread_start + 136
17  libsystem_pthread.dylib       	       0x187c71e3c thread_start + 8

Thread 4:
0   libsystem_kernel.dylib        	       0x187c3f22c poll + 8
1   _ssl.cpython-312-darwin.so    	       0x1019b7ce8 _ssl__SSLSocket_do_handshake + 584
2   libpython3.12.dylib           	       0x101b92604 _PyEval_EvalFrameDefault + 43576
3   libpython3.12.dylib           	       0x101aa344c method_vectorcall + 328
4   libpython3.12.dylib           	       0x101c58e44 thread_run + 64
5   libpython3.12.dylib           	       0x101bf8818 pythread_wrapper + 28
6   libsystem_pthread.dylib       	       0x187c77034 _pthread_start + 136
7   libsystem_pthread.dylib       	       0x187c71e3c thread_start + 8

Thread 5:
0   libsystem_kernel.dylib        	       0x187c3f22c poll + 8
1   _ssl.cpython-312-darwin.so    	       0x1019b7ce8 _ssl__SSLSocket_do_handshake + 584
2   libpython3.12.dylib           	       0x101b92604 _PyEval_EvalFrameDefault + 43576
3   libpython3.12.dylib           	       0x101aa344c method_vectorcall + 328
4   libpython3.12.dylib           	       0x101c58e44 thread_run + 64
5   libpython3.12.dylib           	       0x101bf8818 pythread_wrapper + 28
6   libsystem_pthread.dylib       	       0x187c77034 _pthread_start + 136
7   libsystem_pthread.dylib       	       0x187c71e3c thread_start + 8

Thread 6:
0   libsystem_kernel.dylib        	       0x187c3f22c poll + 8
1   _ssl.cpython-312-darwin.so    	       0x1019b7ce8 _ssl__SSLSocket_do_handshake + 584
2   libpython3.12.dylib           	       0x101b92604 _PyEval_EvalFrameDefault + 43576
3   libpython3.12.dylib           	       0x101aa344c method_vectorcall + 328
4   libpython3.12.dylib           	       0x101c58e44 thread_run + 64
5   libpython3.12.dylib           	       0x101bf8818 pythread_wrapper + 28
6   libsystem_pthread.dylib       	       0x187c77034 _pthread_start + 136
7   libsystem_pthread.dylib       	       0x187c71e3c thread_start + 8

Thread 7:
0   libsystem_kernel.dylib        	       0x187c3f22c poll + 8
1   _ssl.cpython-312-darwin.so    	       0x1019b7ce8 _ssl__SSLSocket_do_handshake + 584
2   libpython3.12.dylib           	       0x101b92604 _PyEval_EvalFrameDefault + 43576
3   libpython3.12.dylib           	       0x101aa344c method_vectorcall + 328
4   libpython3.12.dylib           	       0x101c58e44 thread_run + 64
5   libpython3.12.dylib           	       0x101bf8818 pythread_wrapper + 28
6   libsystem_pthread.dylib       	       0x187c77034 _pthread_start + 136
7   libsystem_pthread.dylib       	       0x187c71e3c thread_start + 8

Thread 8:
0   libsystem_kernel.dylib        	       0x187c3f22c poll + 8
1   _ssl.cpython-312-darwin.so    	       0x1019b7ce8 _ssl__SSLSocket_do_handshake + 584
2   libpython3.12.dylib           	       0x101b92604 _PyEval_EvalFrameDefault + 43576
3   libpython3.12.dylib           	       0x101aa344c method_vectorcall + 328
4   libpython3.12.dylib           	       0x101c58e44 thread_run + 64
5   libpython3.12.dylib           	       0x101bf8818 pythread_wrapper + 28
6   libsystem_pthread.dylib       	       0x187c77034 _pthread_start + 136
7   libsystem_pthread.dylib       	       0x187c71e3c thread_start + 8

Thread 9:
0   libsystem_kernel.dylib        	       0x187c3f22c poll + 8
1   _ssl.cpython-312-darwin.so    	       0x1019b7ce8 _ssl__SSLSocket_do_handshake + 584
2   libpython3.12.dylib           	       0x101b92604 _PyEval_EvalFrameDefault + 43576
3   libpython3.12.dylib           	       0x101aa344c method_vectorcall + 328
4   libpython3.12.dylib           	       0x101c58e44 thread_run + 64
5   libpython3.12.dylib           	       0x101bf8818 pythread_wrapper + 28
6   libsystem_pthread.dylib       	       0x187c77034 _pthread_start + 136
7   libsystem_pthread.dylib       	       0x187c71e3c thread_start + 8

Thread 10:
0   libsystem_kernel.dylib        	       0x187c3f22c poll + 8
1   _ssl.cpython-312-darwin.so    	       0x1019b7ce8 _ssl__SSLSocket_do_handshake + 584
2   libpython3.12.dylib           	       0x101b92604 _PyEval_EvalFrameDefault + 43576
3   libpython3.12.dylib           	       0x101aa344c method_vectorcall + 328
4   libpython3.12.dylib           	       0x101c58e44 thread_run + 64
5   libpython3.12.dylib           	       0x101bf8818 pythread_wrapper + 28
6   libsystem_pthread.dylib       	       0x187c77034 _pthread_start + 136
7   libsystem_pthread.dylib       	       0x187c71e3c thread_start + 8

Thread 11:
0   libsystem_kernel.dylib        	       0x187c3f22c poll + 8
1   _ssl.cpython-312-darwin.so    	       0x1019b7ce8 _ssl__SSLSocket_do_handshake + 584
2   libpython3.12.dylib           	       0x101b92604 _PyEval_EvalFrameDefault + 43576
3   libpython3.12.dylib           	       0x101aa344c method_vectorcall + 328
4   libpython3.12.dylib           	       0x101c58e44 thread_run + 64
5   libpython3.12.dylib           	       0x101bf8818 pythread_wrapper + 28
6   libsystem_pthread.dylib       	       0x187c77034 _pthread_start + 136
7   libsystem_pthread.dylib       	       0x187c71e3c thread_start + 8

Thread 12:
0   libsystem_kernel.dylib        	       0x187c3f22c poll + 8
1   _ssl.cpython-312-darwin.so    	       0x1019b7ce8 _ssl__SSLSocket_do_handshake + 584
2   libpython3.12.dylib           	       0x101b92604 _PyEval_EvalFrameDefault + 43576
3   libpython3.12.dylib           	       0x101aa344c method_vectorcall + 328
4   libpython3.12.dylib           	       0x101c58e44 thread_run + 64
5   libpython3.12.dylib           	       0x101bf8818 pythread_wrapper + 28
6   libsystem_pthread.dylib       	       0x187c77034 _pthread_start + 136
7   libsystem_pthread.dylib       	       0x187c71e3c thread_start + 8

Thread 3 crashed with ARM Thread State (64-bit):
    x0: 0x0000000000000000   x1: 0x0000000000000001   x2: 0x00006000016cc3c0   x3: 0x000000016ff4a760
    x4: 0x0000000000000000   x5: 0x0000000000000000   x6: 0x0000000000000000   x7: 0x0000000000000000
    x8: 0x0000600001838480   x9: 0x0000000000000003  x10: 0x000000000005bf01  x11: 0x0000000000000000
   x12: 0x0000000000000000  x13: 0x000000000005be01  x14: 0x0005be0100000000  x15: 0x0005be010005bec0
   x16: 0x0000000187c738a0  x17: 0x00000000e318da4f  x18: 0x0000000000000000  x19: 0x0000600001a7a500
   x20: 0x00006000016cc3c0  x21: 0x0000000000000001  x22: 0x00000001218961f0  x23: 0x0000000000000000
   x24: 0x0000000000000001  x25: 0x0000600002918e60  x26: 0x0000600002918e60  x27: 0x0000000000000003
   x28: 0x0000000000000065   fp: 0x000000016ff4a7b0   lr: 0x0000000102205338
    sp: 0x000000016ff4a760   pc: 0x0000000102204cdc cpsr: 0x20001000
   far: 0x0000000000000004  esr: 0x92000006 (Data Abort) byte read Translation fault

Reproduction Steps
I used the following script to reproduce on my Mac.  It doesn't reproduce every time.  Only when I run the script after a period of "quiet time".  Note the TopicArn param should be replaced with the ARN of a valid SNS topic that is accessible from the calling context.
from concurrent.futures import ThreadPoolExecutor
from threading import Barrier

import boto3

session = boto3.Session()
client = session.client('sns')

THREAD_COUNT = 10

b = Barrier(THREAD_COUNT)

def get_sns_topic():
    b.wait()
    try:
        attrs = client.get_topic_attributes(TopicArn='arn:aws:sns:us-east-1:1111111111111:My-Topic')
        print(attrs)
    except Exception as e:
        print(e)

with ThreadPoolExecutor(max_workers=THREAD_COUNT) as executor:
    for i in range(THREAD_COUNT):
        executor.submit(get_sns_topic)

    executor.shutdown(wait=True)

Possible Solution
No response
Additional Information/Context
No response
SDK version used
1.34.78
Environment details (OS name and version, etc.)
Mac OS 14.0, Python 3.12.0, OpenSSL 3.1.3

Hi @dmittendorf thanks for reaching out. From what you described it looks like this is not directly an issue with Boto3, but rather something involving OpenSSL, CPython, and/or Python 3.12. Considering that you're using very recent versions of everything, there may be some new compatibility issue or edge case here. It might be worth reaching out in repositories like https://github.com/python/cpython/issues or https://github.com/openssl/openssl/issues to try and get more information.
In terms of Boto3 here is documentation on multithreading with clients. If you would like to share a code snippet and debug logs (with sensitive info redacted) by adding boto3.set_stream_logger('') to your script then we could review Boto3-related behavior further.

Hi @tim-finnigan.  Thanks for the response.  I agree that the root cause seems to be somewhere down in openssl, but wasn't sure if it was somehow triggered by the way that botocore is using the library.
The code I posted above that reproduces the bug is pretty much the same as the example code from the multithreading docs, except I am using a barrier to try and force as much concurrency between the threads as possible.
I'm attaching the output from a new reproduction with the stream logger enabled.
debug-log.txt

Thanks for following up here. Have you tried testing on different versions of Python and OpenSSL? Or different Linux/Windows environments? I could not reproduce the issue given the code snippet you had provided. Does reducing the number of threads help here?

It doesn't reproduce every time. Only when I run the script after a period of "quiet time".

Could you share more details here regarding this, like how often you can reproduce the issue and what you mean by quiet time?

There is a similar issue with a reproducer here: https://github.com/openssl/openssl/issues/24480

Our application shares Client instances across multiple threads.

This seems to be not supported, please see the updated doc at https://github.com/boto/boto3/pull/4157


Use some code guidelines for R code

We could use some of the existing ones, for example, this one https://google.github.io/styleguide/Rguide.xml

On Tue, Mar 15, 2016 at 2:23 PM, annenkov<EMAIL_ADDRESS>wrote:

We could use some of the existing ones, for example, this one
https://google.github.io/styleguide/Rguide.xml

They feel a little "internal" to Google.
I also like these:
http://adv-r.had.co.nz/Style.html
I think we should merge them and clean them up.
--
Oleks


Math magicians: events

💯 Achievements.

Handle events in a React app.
Use React life cycle methods.
Understand the mechanism of lifting state up.
Ensured no linter errors.
Implement calculator object and ensured all methods were working correctly.
Used correct GitFlow.
Proper project documentation.

Thanks, @Wes-Isaac for the approval.


[vim] :substitute can't find $ (EOL)

In vim, I can append to the end of each line with :%s/$/SOMETHING/. In CodeMirror, I see No matches for $ instead.
Users should be able to represent end-of-line in :substitute commands using $.

Due to limitations in JavaScript's regexp API, the searchcursor addon isn't able to properly match all expressions. We could special-case this situation, but I'm not sure if it's worth it.

this one can be closed (IIUC I'd need to have the right permissions to be able to do it myself)

Thanks!


add support for eu-south-1 MXP

Description of changes
This PR enables support in eu-south-1 region (MXP). Associated with https://github.com/aws-amplify/amplify-cli/pull/12042
CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
N/A
Description of how you validated changes
I've created a tagged release of both amplify-category-api with https://github.com/aws-amplify/amplify-category-api/pull/1273 and amplify-cli including https://github.com/aws-amplify/amplify-cli/pull/12042.
The eu-south-1 CLI can be installed via
npm i -g<EMAIL_ADDRESS>
I then set eu-south-1 in my ~/.aws/config for my amplify profile.
First, to test amplify-cli, I ran:
amplify init
amplify add auth
amplify add storage
amplify push

accepting all default values.
Then, to test amplify-category-api, I ran amplify add api && amplify push.
It all works and the expected resources / CFN stacks appear in my AWS account in eu-south-1.

e2e suite: https://app.circleci.com/pipelines/github/aws-amplify/amplify-category-api?branch=run-e2e/xss/main

Checklist

[x] PR description included
[x] yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

One suggestion I have here is to add this new region to our e2e testing regions, so we run tests consistently across that region. Link. We can do that in a different PR as well.

One suggestion I have here is to add this new region to our e2e testing regions, so we run tests consistently across that region. Link. We can do that in a different PR as well.

I considered that, but note that it's an opt-in region. This means that your e2e test accounts will need to enable the region in order for the tests to work.
Additionally, the e2e tests use amplify cli, so until https://github.com/aws-amplify/amplify-cli/pull/12042 is released, the tests wouldn't work in that region even if MXP were enabled in the test accounts.


⚠ Bofrost.de has degraded performance

In 983a8e1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 990 ms

Resolved: Bofrost.de performance has improved in 9d3b361 after 6 minutes.


Angular Support

I'm having trouble getting this to work with angular tables that are generated using ng-repeat.  I beleive it's a timing issue as angular renders table rows on the fly based on data.
Has anyone gotten this to work?

I just released v5.2.0 which includes two new (semi-private) methods which could help you out. (Un)fortunatelly, I have not used angular for a while and I am not sure how to test it out. The API might [read: probably] need some updating.
setupRow(row, indices)

Used to set up a newly added row.
Row is the row-element to be setup.
Indices is a mapping between a cells index, and the proper column. It is created by the method buildHeaderCellIndices() and stored in the instance as this.headerColIndices on construction.

update()
Run this after the content in tbody/tfoot has changed

Hi!
Thanks for your plugin.
I am having trouble getting this to work with jquery datatables pagination.
I have everything working, but I can not call the method update. Tell me how to do it. Thanks.

@agronom81 and @twilly86 Please see my updated answer above :)

I had a similar issue working with Aurelia. The update function didn't work for me if the number of rows was different than when the table was originally initialized. At first glance, I think this could be fixed if this.$bodyRows was reinitialized in the update function before calling setupBodyRows.

@camiracle Good catch! I just patched it with latest release (v5.2.4) :) Thanks! Let me know if it works. I am quite eager to close this issue ^^
@twilly86 Any update? (pun intended)

5.2.1 is still the latest version I'm seeing. I copied your changes for testing, though, and it works better now with a dynamic number of rows.
There is a remaining issue that I run into if I follow these steps:

Populate and initialize a new table. For this example, let's say there are 2 rows of data.
Hide some of the columns via the "Display" dropdown
Dynamically add more rows to the table
Call the update method
Result: The headers are still missing for the hidden rows, as well as the data for the first 2 rows. The newly added rows show all data.

Let me know if that doesn't make sense. Thanks for your work on this, and for the plugin, it's pretty sweet.

@camiracle Thank you, I'm glad you like it! ^^ I just pushed a new release (v5.2.5) which should solve the issue you described. Let's hope there aren't any more cases that I've missed :D

That seems to be working perfectly, cheers!

Woop woop! Nice to hear :D Cheers!
Hälsningar,
Nadan Gergeo

On 24 Jan 2017, at 15:49, Caleb Miracle<EMAIL_ADDRESS>wrote:
That seems to be working perfectly, cheers!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/nadangergeo/RWD-Table-Patterns/issues/31#issuecomment-274824378, or mute the thread https://github.com/notifications/unsubscribe-auth/AAY4RfF9ZCDPax3RQQFdXzdeCCsSpoMCks5rVg-KgaJpZM4K9--S.


Question about training FSANET_Capsule

It is fine when training SSRNET_MT, but when training FSANET_Capsule, an error comes.
Traceback (most recent call last):
  File "FSANET_train.py", line 299, in <module>
    main()
  File "FSANET_train.py", line 132, in main
    model = FSA_net_Capsule(image_size, num_classes, stage_num, lambda_d, S_set)()
  File "..\lib\FSANET_model.py", line 444, in __call__
    ssr_Cap_list = ssr_aggregation_model(ssr_primcaps)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 603, in __call__
    output = self.call(inputs, **kwargs)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 2061, in call
    output_tensors, _, _ = self.run_internal_graph(inputs, masks)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 2265, in run_internal_graph
    assert str(id(x)) in tensor_map, 'Could not compute output ' + str(x)
AssertionError: Could not compute output Tensor("reshape_8/Reshape:0", shape=(?, ?), dtype=float32)

And my environment is the same as the environment you list.
Thank you!

It is fine when training SSRNET_MT, but when training FSANET_Capsule, an error comes.
Traceback (most recent call last):
  File "FSANET_train.py", line 299, in <module>
    main()
  File "FSANET_train.py", line 132, in main
    model = FSA_net_Capsule(image_size, num_classes, stage_num, lambda_d, S_set)()
  File "..\lib\FSANET_model.py", line 444, in __call__
    ssr_Cap_list = ssr_aggregation_model(ssr_primcaps)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 603, in __call__
    output = self.call(inputs, **kwargs)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 2061, in call
    output_tensors, _, _ = self.run_internal_graph(inputs, masks)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 2265, in run_internal_graph
    assert str(id(x)) in tensor_map, 'Could not compute output ' + str(x)
AssertionError: Could not compute output Tensor("reshape_8/Reshape:0", shape=(?, ?), dtype=float32)

And my environment is the same as the environment you list.
Thank you!

I have the same problem as you.
The environment is the same.

It is fine when training SSRNET_MT, but when training FSANET_Capsule, an error comes.
Traceback (most recent call last):
  File "FSANET_train.py", line 299, in <module>
    main()
  File "FSANET_train.py", line 132, in main
    model = FSA_net_Capsule(image_size, num_classes, stage_num, lambda_d, S_set)()
  File "..\lib\FSANET_model.py", line 444, in __call__
    ssr_Cap_list = ssr_aggregation_model(ssr_primcaps)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 603, in __call__
    output = self.call(inputs, **kwargs)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 2061, in call
    output_tensors, _, _ = self.run_internal_graph(inputs, masks)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 2265, in run_internal_graph
    assert str(id(x)) in tensor_map, 'Could not compute output ' + str(x)
AssertionError: Could not compute output Tensor("reshape_8/Reshape:0", shape=(?, ?), dtype=float32)

And my environment is the same as the environment you list.
Thank you!

I have the same problem as you.
The environment is the same.

My solution is to use py3.6 and change keras,tf... correspondingly.
The environment the writer lists, is not suitable for the latest code.

It is fine when training SSRNET_MT, but when training FSANET_Capsule, an error comes.
Traceback (most recent call last):
  File "FSANET_train.py", line 299, in <module>
    main()
  File "FSANET_train.py", line 132, in main
    model = FSA_net_Capsule(image_size, num_classes, stage_num, lambda_d, S_set)()
  File "..\lib\FSANET_model.py", line 444, in __call__
    ssr_Cap_list = ssr_aggregation_model(ssr_primcaps)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 603, in __call__
    output = self.call(inputs, **kwargs)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 2061, in call
    output_tensors, _, _ = self.run_internal_graph(inputs, masks)
  File "E:\Anaconda3\envs\bishe\lib\site-packages\keras\engine\topology.py", line 2265, in run_internal_graph
    assert str(id(x)) in tensor_map, 'Could not compute output ' + str(x)
AssertionError: Could not compute output Tensor("reshape_8/Reshape:0", shape=(?, ?), dtype=float32)

And my environment is the same as the environment you list.
Thank you!

I have the same problem as you.
The environment is the same.

My solution is to use py3.6 and change keras,tf... correspondingly.
The environment the writer lists, is not suitable for the latest code.

I just reinstalled the environment and everything went well....
There must be some problems but I haven't found.


Game crashes when launched with controller connected

Specifically a ps4 DualShock and a wired hori ps4 controller. After the game loads up while either of these controllers is already plugged in it crashes.

Can you please send the crash report?

I have the same issue, here is the crash file:
crash-2021-05-14_00.28.43-fml.txt

I've made a potential fix. Can you try this version of the mod? https://www.dropbox.com/s/e5bxb95ov15t1lk/controllable-0.13.2-1.16.3.jar?dl=0

Ok.

Worked! Thank you!

Fixed in 36414d16294b44c32205023c990369faabca4c99


Resolve formatting inconsistencies

This PR resolves formatting inconsistencies found in the standard library and examples.

Thanks for these fixups!
But I don't think you meant to commit the examples/httpserver/httpserver binary?


Cherry picks 1.11.0 rc5

Cherrypicking:
#21835
#21839
#21840
#21853
#21854
#21859
#21871
#21874
#21905
#21907
#21911
#21914
#21919

LGTM

but there's one more change needed in runc (discussion on slack)

LGTM


Release Google.Cloud.Tasks.V2 version 2.0.0-beta02

Changes in this release:

Commit 8d040c3: Adds StackdriverLoggingConfig and Queue.StackdriverLoggingConfig

Note: I'll only merge and release this when the API team has given the go-ahead.

This won't go out today - which means I'll need to fix the date. Will do that when it is ready to go out though :)

Service is now ready; I've updated the release date, and will merge on green.


Guidelines emerged after code reviews

During those two code review sessions some interesting coding principles are emerged.
Purpose of this PR is to fix them into our guidelines.
What's new:

Typescript

Avoid hiding exceptions

FP-TS

Avoid the use of imperative methods like isLeft and isNone.

Testing

Prefer test titles in the form "it should ..."
Avoid throw exceptions
Avoid wrapping tests with helper functions

More:

document and code snippets are formatted using prettier
implemented examples using ✅good / ❌bad examples pattern

@gunzip @cloudify most of the requested changes refer to exception handling (or better: to not use exception). I think this is a broader topic and it's hard to squeeze it in a couple of principles other than "don't throw". I think it would be great to have recipes that guide developers into the adoption of this style of programming.
Do you have any resource about it, or do you already have a list of use case to describe?


FATAL Fatal error, application will be closed:

Hello , I met an error when I used it.
COMMAND: PatreonDownloader.App.exe --creator https://www.patreon.com/u_u_ASMR
OUTPUT:
2020-10-24 16:31:07.4316 INFO Retrieving cookies...
2020-10-24 16:31:52.3954 FATAL Fatal error, application will be closed: System.NullReferenceException: Object reference not set to an instance of an object.
at PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever.Login() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerCookieRetriever.cs:line 49
at PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever.RetrieveCookies() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerCookieRetriever.cs:line 93
at PatreonDownloader.App.Program.RunPatreonDownloader(String creatorName, Boolean headlessBrowser, PatreonDownloaderSettings settings) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 118
at PatreonDownloader.App.Program.Main(String[] args) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 59

Thank you in advance

First of all your creator url is not correct. It should follow the following format: https://www.patreon.com/#creator_name_here#/posts.
But that's not the problem. It looks like the browser could not be started. Please post the most recent log file from the "logs" directory.

First of all your creator url is not correct. It should follow the following format: https://www.patreon.com/#creator_name_here#/posts.
But that's not the problem. It looks like the browser could not be started. Please post the most recent log file from the "logs" directory.
Thank you for replying. Here are logs:

2020-10-24 16:31:07.3455 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Found 27 chrome processes (not sure which one yet)
2020-10-24 16:31:07.4316 INFO [PatreonDownloader.App.Program] Retrieving cookies...
2020-10-24 16:31:07.4640 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever] Calling login check
2020-10-24 16:31:07.4784 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever] Retrieving browser
2020-10-24 16:31:07.4863 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Downloading browser
2020-10-24 16:31:50.6138 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Launching browser
2020-10-24 16:31:52.2779 FATAL [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Browser communication error. Exception: PuppeteerSharp.ChromiumProcessException: Failed to create connection
---> System.Net.WebSockets.WebSocketException (0x80004005): Unable to connect to the remote server
---> System.Net.Http.HttpRequestException: An error occurred while sending the request.
---> System.IO.IOException: The response ended prematurely.
at System.Net.Http.HttpConnection.FillAsync()
at System.Net.Http.HttpConnection.ReadNextResponseHeaderLineAsync(Boolean foldedHeadersAllowed)
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithNtConnectionAuthAsync(HttpConnection connection, HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.WebSockets.WebSocketHandle.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken, ClientWebSocketOptions options)
at System.Net.WebSockets.WebSocketHandle.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken, ClientWebSocketOptions options)
at System.Net.WebSockets.ClientWebSocket.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken)
at PuppeteerSharp.Transport.WebSocketTransport.CreateDefaultWebSocket(Uri url, IConnectionOptions options, CancellationToken cancellationToken)
at PuppeteerSharp.Transport.WebSocketTransport.CreateDefaultTransport(Uri url, IConnectionOptions connectionOptions, CancellationToken cancellationToken)
at PuppeteerSharp.Connection.Create(String url, IConnectionOptions connectionOptions, ILoggerFactory loggerFactory, CancellationToken cancellationToken)
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options)
--- End of inner exception stack trace ---
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options)
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options)
at PatreonDownloader.PuppeteerEngine.PuppeteerEngine.GetBrowser() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerEngine.cs:line 92
2020-10-24 16:31:52.3954 FATAL [PatreonDownloader.App.Program] Fatal error, application will be closed: System.NullReferenceException: Object reference not set to an instance of an object.
at PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever.Login() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerCookieRetriever.cs:line 49
at PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever.RetrieveCookies() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerCookieRetriever.cs:line 93
at PatreonDownloader.App.Program.RunPatreonDownloader(String creatorName, Boolean headlessBrowser, PatreonDownloaderSettings settings) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 118
at PatreonDownloader.App.Program.Main(String[] args) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 59
2020-10-24 16:35:03.1810 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Found 24 chrome processes (not sure which one yet)
2020-10-24 16:35:03.2213 INFO [PatreonDownloader.App.Program] Retrieving cookies...
2020-10-24 16:35:03.2512 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever] Calling login check
2020-10-24 16:35:03.2645 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever] Retrieving browser
2020-10-24 16:35:03.2645 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Downloading browser
2020-10-24 16:35:03.2866 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Launching browser
2020-10-24 16:35:05.6824 FATAL [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Browser communication error. Exception: PuppeteerSharp.ChromiumProcessException: Failed to create connection
---> System.Net.WebSockets.WebSocketException (0x80004005): Unable to connect to the remote server
---> System.Net.Http.HttpRequestException: An error occurred while sending the request.
---> System.IO.IOException: The response ended prematurely.
at System.Net.Http.HttpConnection.FillAsync()
at System.Net.Http.HttpConnection.ReadNextResponseHeaderLineAsync(Boolean foldedHeadersAllowed)
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithNtConnectionAuthAsync(HttpConnection connection, HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.WebSockets.WebSocketHandle.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken, ClientWebSocketOptions options)
at System.Net.WebSockets.WebSocketHandle.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken, ClientWebSocketOptions options)
at System.Net.WebSockets.ClientWebSocket.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken)
at PuppeteerSharp.Transport.WebSocketTransport.CreateDefaultWebSocket(Uri url, IConnectionOptions options, CancellationToken cancellationToken)
at PuppeteerSharp.Transport.WebSocketTransport.CreateDefaultTransport(Uri url, IConnectionOptions connectionOptions, CancellationToken cancellationToken)
at PuppeteerSharp.Connection.Create(String url, IConnectionOptions connectionOptions, ILoggerFactory loggerFactory, CancellationToken cancellationToken)
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options)
--- End of inner exception stack trace ---
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options)
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options)
at PatreonDownloader.PuppeteerEngine.PuppeteerEngine.GetBrowser() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerEngine.cs:line 92
2020-10-24 16:35:05.6919 FATAL [PatreonDownloader.App.Program] Fatal error, application will be closed: System.NullReferenceException: Object reference not set to an instance of an object.
at PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever.Login() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerCookieRetriever.cs:line 49
at PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever.RetrieveCookies() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerCookieRetriever.cs:line 93
at PatreonDownloader.App.Program.RunPatreonDownloader(String creatorName, Boolean headlessBrowser, PatreonDownloaderSettings settings) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 118
at PatreonDownloader.App.Program.Main(String[] args) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 59
2020-10-24 16:42:32.2365 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Found 24 chrome processes (not sure which one yet)
2020-10-24 16:42:32.3092 INFO [PatreonDownloader.App.Program] Retrieving cookies...
2020-10-24 16:42:32.3404 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever] Calling login check
2020-10-24 16:42:32.3541 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever] Retrieving browser
2020-10-24 16:42:32.3615 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Downloading browser
2020-10-24 16:42:32.3772 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Launching browser
2020-10-24 16:42:33.7362 FATAL [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Browser communication error. Exception: PuppeteerSharp.ChromiumProcessException: Failed to create connection
---> System.Net.WebSockets.WebSocketException (0x80004005): Unable to connect to the remote server
---> System.Net.Http.HttpRequestException: An error occurred while sending the request.
---> System.IO.IOException: The response ended prematurely.
at System.Net.Http.HttpConnection.FillAsync()
at System.Net.Http.HttpConnection.ReadNextResponseHeaderLineAsync(Boolean foldedHeadersAllowed)
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithNtConnectionAuthAsync(HttpConnection connection, HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.WebSockets.WebSocketHandle.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken, ClientWebSocketOptions options)
at System.Net.WebSockets.WebSocketHandle.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken, ClientWebSocketOptions options)
at System.Net.WebSockets.ClientWebSocket.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken)
at PuppeteerSharp.Transport.WebSocketTransport.CreateDefaultWebSocket(Uri url, IConnectionOptions options, CancellationToken cancellationToken)
at PuppeteerSharp.Transport.WebSocketTransport.CreateDefaultTransport(Uri url, IConnectionOptions connectionOptions, CancellationToken cancellationToken)
at PuppeteerSharp.Connection.Create(String url, IConnectionOptions connectionOptions, ILoggerFactory loggerFactory, CancellationToken cancellationToken)
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options)
--- End of inner exception stack trace ---
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options)
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options)
at PatreonDownloader.PuppeteerEngine.PuppeteerEngine.GetBrowser() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerEngine.cs:line 92
2020-10-24 16:42:33.7362 FATAL [PatreonDownloader.App.Program] Fatal error, application will be closed: System.NullReferenceException: Object reference not set to an instance of an object.
at PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever.Login() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerCookieRetriever.cs:line 49
at PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever.RetrieveCookies() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerCookieRetriever.cs:line 93
at PatreonDownloader.App.Program.RunPatreonDownloader(String creatorName, Boolean headlessBrowser, PatreonDownloaderSettings settings) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 118
at PatreonDownloader.App.Program.Main(String[] args) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 59

Yep, looks like there are some problems with accessing embedded browser.
Please try running this test build: https://mega.nz/file/qtcwQLpb#Wx3FoHAgIPzjFKc3BPCS073sU_xAeZzxuXaNM-OQ1p0
Please note that this is only a test build and it comes without google drive plugin. I will make a proper release if this solves your issue.

Yep, looks like there are some problems with access to the embedded browser.
Please try running this test build: https://mega.nz/file/qtcwQLpb#Wx3FoHAgIPzjFKc3BPCS073sU_xAeZzxuXaNM-OQ1p0
Please note that this build comes without google drive plugin. I will make a proper release if this solves your issue.

Thank you for updating and I am sorry for that it still can not work.

Here are logs:
2020-10-25 09:32:56.1199 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Found 24 chrome processes (not sure which one yet)
2020-10-25 09:32:56.1663 INFO [PatreonDownloader.App.Program] Retrieving cookies...
2020-10-25 09:32:56.2063 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever] Calling login check
2020-10-25 09:32:56.2181 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever] Retrieving browser
2020-10-25 09:32:56.2181 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Downloading browser
2020-10-25 09:33:26.7836 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Launching browser
2020-10-25 09:33:27.2929 FATAL [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Browser communication error. Exception: PuppeteerSharp.ProcessException: Failed to create connection
---> System.Net.WebSockets.WebSocketException (0x80004005): Unable to connect to the remote server
---> System.Net.Http.HttpRequestException: An error occurred while sending the request.
---> System.IO.IOException: The response ended prematurely.
at System.Net.Http.HttpConnection.FillAsync()
at System.Net.Http.HttpConnection.ReadNextResponseHeaderLineAsync(Boolean foldedHeadersAllowed)
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
--- End of inner exception stack trace ---
at System.Net.Http.HttpConnection.SendAsyncCore(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithNtConnectionAuthAsync(HttpConnection connection, HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Net.WebSockets.WebSocketHandle.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken, ClientWebSocketOptions options)
at System.Net.WebSockets.WebSocketHandle.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken, ClientWebSocketOptions options)
at System.Net.WebSockets.ClientWebSocket.ConnectAsyncCore(Uri uri, CancellationToken cancellationToken)
at PuppeteerSharp.Transport.WebSocketTransport.CreateDefaultWebSocket(Uri url, IConnectionOptions options, CancellationToken cancellationToken)
at PuppeteerSharp.Transport.WebSocketTransport.CreateDefaultTransport(Uri url, IConnectionOptions connectionOptions, CancellationToken cancellationToken)
at PuppeteerSharp.Connection.Create(String url, IConnectionOptions connectionOptions, ILoggerFactory loggerFactory, CancellationToken cancellationToken)
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options, Product product)
--- End of inner exception stack trace ---
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options, Product product)
at PuppeteerSharp.Launcher.LaunchAsync(LaunchOptions options, Product product)
at PatreonDownloader.PuppeteerEngine.PuppeteerEngine.GetBrowser() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerEngine.cs:line 92
2020-10-25 09:33:27.3493 FATAL [PatreonDownloader.App.Program] Fatal error, application will be closed: System.NullReferenceException: Object reference not set to an instance of an object.
at PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever.Login() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerCookieRetriever.cs:line 49
at PatreonDownloader.PuppeteerEngine.PuppeteerCookieRetriever.RetrieveCookies() in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.PuppeteerEngine\PuppeteerCookieRetriever.cs:line 93
at PatreonDownloader.App.Program.RunPatreonDownloader(String creatorName, Boolean headlessBrowser, PatreonDownloaderSettings settings) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 118
at PatreonDownloader.App.Program.Main(String[] args) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 59

I wonder if  I need close my browser when I excuting the command.
And I live in a magical country so I have to access to patreon with proxy.
I pasted set http_proxy=http://<IP_ADDRESS>:7890 & set https_proxy=http://<IP_ADDRESS>:7890 to CMD and that may be the cause of the error

PatreonDownloader should not conflict with any other chromium-based browsers.
Try disabling any applications/settings which may affect network connectivity in any way (vpn, proxy, firewall, etc). I'm afraid that's the only thing I can think of.
Another thing you can use is --no-headless parameter which should show browser window which in turn you can use to figure out what might be wrong.
I am closing this issue as wontfix since it doesn't appear that this problem is related to PatreonDownloader.

I closed proxy and the PatreonDownloader opened the chrome successfully.  I logged in and  it said "Unable to create download directory"
2020-10-26 18:02:26.3810 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Downloading browser
2020-10-26 18:02:26.3810 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Launching browser
2020-10-26 18:02:26.6164 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Opening new page
2020-10-26 18:02:26.7242 DEBUG [PatreonDownloader.PuppeteerEngine.PuppeteerEngine] Creating IWebBrowser
2020-10-26 18:02:28.4740 FATAL [PatreonDownloader.Engine.PatreonDownloader] Unable to create download directory: System.IO.IOException: 文件名、目录名或卷标语法不正确。 : 'D:\github\patreon_downloader\download\https:\www.patreon.com\u_u_asmr\posts'
at System.IO.FileSystem.CreateDirectory(String fullPath, Byte[] securityDescriptor)
at System.IO.Directory.CreateDirectory(String path)
at PatreonDownloader.Engine.PatreonDownloader.Download(String creatorName, PatreonDownloaderSettings settings) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.Engine\PatreonDownloader.cs:line 138
2020-10-26 18:02:28.4999 FATAL [PatreonDownloader.App.Program] Fatal error, application will be closed: PatreonDownloader.Engine.Exceptions.PatreonDownloaderException: Unable to create download directory
---> System.IO.IOException: 文件名、目录名或卷标语法不正确。 : 'D:\github\patreon_downloader\download\https:\www.patreon.com\u_u_asmr\posts'
at System.IO.FileSystem.CreateDirectory(String fullPath, Byte[] securityDescriptor)
at System.IO.Directory.CreateDirectory(String path)
at PatreonDownloader.Engine.PatreonDownloader.Download(String creatorName, PatreonDownloaderSettings settings) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.Engine\PatreonDownloader.cs:line 138
--- End of inner exception stack trace ---
at PatreonDownloader.Engine.PatreonDownloader.Download(String creatorName, PatreonDownloaderSettings settings) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.Engine\PatreonDownloader.cs:line 144
at PatreonDownloader.App.Program.RunPatreonDownloader(String creatorName, Boolean headlessBrowser, PatreonDownloaderSettings settings) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 137
at PatreonDownloader.App.Program.Main(String[] args) in E:\Sources\BigProjects\PatreonDownloader\PatreonDownloader.App\Program.cs:line 59

Sorry, that was my mistake, the correct download command for you will be: PatreonDownloader.App.exe --creator u_u_ASMR

Sorry, that was my mistake, the correct download command for you will be: PatreonDownloader.App.exe --creator u_u_ASMR

Yes,I used --creator u_u_ASMR and it worked successfully. I am sorry for that I did not read README carefully
PatreonDownloader is a convenient script , thank you


Can this enhance the steer turning angle strongly?

I find CRV Hybrid  can make the steer turn over 300 degrees when it do the auto-parking-assistant , how can I find the big torque DBC code to replace the original poor steer control code? Could someone help?
Here is the cabana link of 300 degrees turning :
https://my.comma.ai/cabana/?route=c9ea5789a10a55ac|2019-07-17--00-28-42&max=8&url=https%3A%2F%2Fchffrprivate-vzn.azureedge.net%2Fchffrprivate3%2Fv2%2Fc9ea5789a10a55ac%2F8b6ce67f43d89cf810870807f6782c1c_2019-07-17--00-28-42
Here is the time point of auto-parking-assistant:

Here is the auto-parking-assistant video:
https://cdn.discordapp.com/attachments/600490201197969418/600871699512295435/480-_2019-07-17_10.06.59.mov

Please use it for op!

@gzjackar What country is this CR-V from?

I have yet to find a command signal for this. Spent a good bit of time on it this weekend. Is the eps on a different can than the camera?

I was looking for it too without success, i mean EPS is def on the same bus since we see all the normal EPS rx and tx messages but I suppose its possible that there is another private bus between park assist and EPS.

Interesting that that bit is high on 0xe4, ive seen this before on other chinese hondas.

Before you get too excited about this path, bear in mind the EPS rack may have limitations on that control method. For example, Volkswagen and Audi EPS also supports angle-based control for Park Assist with inherently high torque, but the EPS rack itself will reject that style of control above 15kph.

Yes just to be clear, this control method is not very relevant to openpilot. Even with enough understanding about how it works, it will almost certainly never be supported as it likely requires current speed and possibly current gear to be spoofed. I believe @rbiasini would confirm that this falls outside of openpilot safety specifications.

@energee I think the data we’re seeing might be forwarded. Will be looking at a diagram soon. This crv has 2-4 new frames around 0x183 that appear to have angle data, but it’s not command because it’s active with manual driving and is synced to the normal sensor. Doesn’t appear to be as high of resolution as the normal sensor signal either.

@gzjackar What country is this CR-V from?

China

@gzjackar What country is this CR-V from?

I have yet to find a command signal for this. Spent a good bit of time on it this weekend. Is the eps on a different can than the camera?

Is this steer torque signal a key ?

Steer_status (and steer_sensor) message is being read by EON from EPS module, Steering_control msg is being sent from EON to EPS, that is what these module references indicate on the DBC.

Steer_status (and steer_sensor) message is being read by EON from EPS module, Steering_control msg is being sent from EON to EPS, that is what these module references indicate on the DBC.

So what is the hidden command signal for big turn (Auto Park Assitant) ?  I have thought it is the SteerTorqueMotor .

Steertorquemotor is what the motor is currently doing (think read only). We don’t know where the command is yet. Probably on a different bus. We might know soon.

Steertorquemotor is what the motor is currently doing (think read only). We don’t know where the command is yet. Probably on a different bus. We might know soon.

wow, It's very cool, hope to know soon.


Allow "@dace" as a function decorator

This enables writing data-centric functions/programs in the most concise way possible:
import dace
@dace
def myprog(A: dace.float32[20]):
    return A + A

why

no test :( also why

@definelicht Added test. The reason is to make it even easier to make a function a data-centric program, without @dace.program or @dace.function.


Feature Request: Rename Symbols, Text Styles and Layer Styles

As the title suggests it would be awesome to be able to rename Symbols, Text Styles and Layer Styles. That would help enormously when managing big libraries.

+1,000,000 Please and thank you!


Does Tweetnest already support the new 280 characters tweet length?

https://blog.twitter.com/official/en_us/topics/product/2017/tweetingmadeeasier.html

It looks to me like the text column of the tn_tweets is set to VARCHAR(510). My MySQL is a little rusty but I think at least the database should be good up to 510 characters. I'm not sure why that number was chosen though.

Hmmm, my database is varchar(255); maybe an older version. I'll do some deeper digging when I get around to it.

I've made a quick hack to solve this temporarily:

Change the textcolumn of tn_tweetsto varchar(512) (if twitter changes the limit again...)
in the class.twitter.api.php file, replace (at the top):

		public $dbMap = array(
			"id_str"       => "tweetid",
			"created_at"   => "time",
			"text"         => "text",
			"source"       => "source",
			"coordinates"  => "coordinates",
			"geo"          => "geo",
			"place"        => "place",
			"contributors" => "contributors",
			"user.id"      => "userid"
		);

with
		public $dbMap = array(
			"id_str"       => "tweetid",
			"created_at"   => "time",
			"full_text"    => "text",
			"text"         => "text",
			"source"       => "source",
			"coordinates"  => "coordinates",
			"geo"          => "geo",
			"place"        => "place",
			"contributors" => "contributors",
			"user.id"      => "userid"
		);

I added a mapping between full_text to text because twitter returns the 280 chars tweets in the full_text field.
in the loadtweets.php file, line 127, add this line:
            $params['tweet_mode'] = 'extended';
(before the
$data = $twitterApi->query('statuses/user_timeline', $params);
line)
so Twitter returns the extended tweets.
That's all.

Any good suggestions for an easy way to re-import longer tweets that already got truncated?

I deleted all messages directly in the mysql database between the 280’s Twitter update and the moment when I make the change.

 I tried targeting the character directly but unfortunately it doesn't reload them automatically (it looks for the most recent tweet and if it's there, won't load anymore). I didn't feel like modifying the code so I ran:
DELETE FROM `tn_tweets` WHERE timestamp < '1509462910';


[BUG] sowpack bundle build generate import statement for images and json files

Bug Report Quick Checklist

[x] I am on the latest version of Snowpack & all plugins.
[x] I use package manager yarn
[x] I run Snowpack on OS  Windows
[x] I run Snowpack on Node.js v12+

Describe the bug
[BUG] sowpack build generate import statement for json file and image
This result in error loading it in browser :
for images :
Failed to load module script: The server responded with a non-JavaScript MIME type of "image/png". Strict MIME type checking is enforced for module scripts per HTML spec.

for json files:
Failed to load module script: The server responded with a non-JavaScript MIME type of "application/json". Strict MIME type checking is enforced for module scripts per HTML spec

To Reproduce
Reproduction repo : https://github.com/bug-reproduction/snowpack-import-files

yarn && yarn build && yarn serve
navigate to http://localhost:8080
See error!

Expected behavior
Expect to be able to load image and json when imported in source.
This work in dev mode,

You can wrap your json object into a .ts or .js file.
Instead of a json file:
{
    "foo": "bar"
}

Use a .ts/.js file with export:
export default {
    "foo": "bar"
}

@BogdanDarius Note that as mentioned the issue is also with image
Both were working in previous version of snowpack actually

@BogdanDarius Note that as mentioned the issue is also with image
Both were working in previous version of snowpack actually

Yes I know. It was just a quick workaround.
There is an issue.

Thanks for reporting. Also seeing similar issues with json and images. Hopefully we'll find a fix soon!

As this is the last blocker for our migration, I spent sometime digging this.
This refactor seems to be causing the regression (I left a comment at the particular line):
Refactor the build to improve reusability

One work around is to create a Snowpack plugin that reset the resolveProxyImports in a JS task:
module.exports = function config() {
  return {
    name: 'snowpack-config-resolveProxyImports-plugin',
    config(config) {
      setTimeout(() => {
        config.buildOptions.resolveProxyImports = true
      })
    },
  };
}

Thanks for raising. Thanks to the wonderful @lukejacksonn, he recently updated our Snowpack test suite and it is much, much easier to write tests for! 🎉
If someone on this issue can open a PR with a failing test that captures the behavior, I’d be happy to suggest a fix for it.

Hi @drwpow, thanks for looking into this. This can be reproduced with a basic snowpack template app.
npx create-snowpack-app test-image-import --template @snowpack/app-template-react-typescript

If you turn on optimize.bundle to true in snowpack.config.js, and try to open build/index.html, you should be able to see the error:
Failed to load module script: The server responded with a non-JavaScript MIME type of "image/svg+xml". Strict MIME type checking is enforced for module scripts per HTML spec.

Any update? I am stuck on Snowpack 3.0.13 because of this bug and am unable to upgrade.

Any update? Still can't import any JSON file.

Experienced this issue in 3.8.8 when importing .json|.png files. Downgraded snowpack to 3.0.11 for a temporary fix.

Any update on this?


[Rancher2] missing kube-controller args from the reference cluster.yaml

Request Summary:
Some of the kube-controller arguments are missing from the reference hardened cluster.yaml configuration even though they are detailed in the Self-Assessment Guide and also show up in the previous guides
kube-controller:
extra_args:
profiling: "false"
address: "<IP_ADDRESS>"
terminated-pod-gc-threshold: "1000"
feature-gates: "RotateKubeletServerCertificate=true"

where https://rancher.com/docs/rancher/v2.x/en/security/rancher-2.5/1.6-hardening-2.5/#reference-hardened-rke-cluster-yml-configuration  has only:
extra_args:
feature-gates: RotateKubeletServerCertificate=true

Closing, these arguments are automatically set when a cluster is provisioned in Rancher and it seems that  Reference Hardened RKE cluster.yml contains only the explicitly required options.


git ship: comment out default commit message

@kevgo @allewun
resolves #382

Yay, this is awesome! We needed this for a long time!  :ship:


s3ql: 3.3.2 -> 3.6.0

Motivation for this change
last version remove old llfuse python library
Things done
Tested with a local repo

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

I forgot about this PR, but now it seems to have a merge conflict.


Frontend now opens a text editor for feedback

Coverage remained the same at 88.63% when pulling 031c1ee289496870251128dcd17ae7d86bd64932 on feedback into 2018af02930a313a5fcd3a82dadae4348157babd on master.

@wakr OK


Sensor component name not set from the SDF

Environment

OS Version:
Ubuntu 20.04
Source or binary build?
Binay Fortress

Description

Expected behavior: When I retrieve a sensor component in the Config function I expect to get the correct name as set in the SDF.
Actual behavior: sensor component name is always __default__

Steps to reproduce
Example with a camera sensor:
auto camComp = _ecm.Component<ignition::gazebo::components::Camera>(_entity);
igndbg << "Camera name (from sensor): " << camComp->Data().CameraSensor()->Name() << std::endl;
igndbg << "Camera name (from component): " << camComp->Data().Name() << std::endl;

Output
[Dbg] [CameraSystem.cc:78] Camera name (from sensor): __default__
[Dbg] [CameraSystem.cc:79] Camera name (from component): camera

The recommended way of getting an entity's name from the ECM is through the components::Name component. The sensor components holding SDF elements will often not have duplicated data that's already available on other components.


Home page: Visual design refinement

Task: Refine the visual design of the Fruity home page. Most recent mockup attached.

@axoplasm Regarding the indicator performance chart, I know this approach has issues. For example, here's what would happen if nothing was > 15% above target but there were lots below:

While I'm sorely tempted to keep working on this, I need to move on... Look forward to seeing what you come up with!

This task is now captured as EPIC #180

This ticket is no longer needed -- visual designing is happening alongside component development and general UI refactoring.