finetuning Qwen2-7B-INSTRUCT  got  RuntimeError: CUDA error: device-side assert triggered

config file:
`# Model
pretrained_model_name_or_path = '/data/llm/cache/Qwen2-7B-Instruct/'
use_varlen_attn = True
Data
data_files = ['/workspace/xtuner/sft_openai.json']
prompt_template = PROMPT_TEMPLATE.qwen_chat
max_length = 32768
pack_to_max_length = True
sequence_parallel_size = 4
Scheduler & Optimizer
batch_size = 1  # per_device
accumulative_counts = 128  # bs = 1 GPU * 1 batch_size_per_device * 16 acc
accumulative_counts *= sequence_parallel_size
dataloader_num_workers = 32
max_epochs = 3
optim_type = AdamW
lr = 3e-4
betas = (0.9, 0.999)
weight_decay = 0
max_norm = 1  # grad clip
warmup_ratio = 0.01
tokenizer = dict(
type=AutoTokenizer.from_pretrained,
pretrained_model_name_or_path=pretrained_model_name_or_path,
trust_remote_code=True,
padding_side='right',
eos_token='<|im_end|>')
model = dict(
type=SupervisedFinetune,
use_varlen_attn=use_varlen_attn,
llm=dict(
type=AutoModelForCausalLM.from_pretrained,
pretrained_model_name_or_path=pretrained_model_name_or_path,
trust_remote_code=True,
torch_dtype=torch.float16,
),
lora=dict(
type=LoraConfig,
r=64,
lora_alpha=16,
lora_dropout=0.1,
bias='none',
task_type='CAUSAL_LM'))
train_dataset = dict(
type=process_hf_dataset,
dataset=dict(type=load_dataset, path='json', data_files=data_files),
tokenizer=tokenizer,
max_length=max_length,
dataset_map_fn=openai_map_fn,
template_map_fn=dict(
type=template_map_fn_factory, template=prompt_template),
remove_unused_columns=True,
shuffle_before_pack=True,
pack_to_max_length=pack_to_max_length,
use_varlen_attn=use_varlen_attn)
train_dataloader = dict(
batch_size=batch_size,
num_workers=dataloader_num_workers,
dataset=train_dataset,
sampler=dict(type=SequenceParallelSampler, seed=1024, shuffle=True),
collate_fn=dict(type=default_collate_fn, use_varlen_attn=use_varlen_attn))
optim_wrapper = dict(
type=AmpOptimWrapper,
optimizer=dict(
type=optim_type, lr=lr, betas=betas, weight_decay=weight_decay),
clip_grad=dict(max_norm=max_norm, error_if_nonfinite=False),
accumulative_counts=accumulative_counts,
loss_scale='dynamic',
dtype='float16')
param_scheduler = [
dict(
type=LinearLR,
start_factor=1e-5,
by_epoch=True,
begin=0,
end=warmup_ratio * max_epochs,
convert_to_iter_based=True),
dict(
type=CosineAnnealingLR,
eta_min=0.0,
by_epoch=True,
begin=warmup_ratio * max_epochs,
end=max_epochs,
convert_to_iter_based=True)
]
Error info:../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [97,0,0], thread: [121,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [97,0,0], thread: [122,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [97,0,0], thread: [123,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [97,0,0], thread: [124,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [97,0,0], thread: [125,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [97,0,0], thread: [126,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
../aten/src/ATen/native/cuda/IndexKernel.cu:92: operator(): block: [97,0,0], thread: [127,0,0] Assertion -sizes[i] <= index && index < sizes[i] && "index out of bounds" failed.
[rank3]: Traceback (most recent call last):
[rank3]:   File "/workspace/xtuner/xtuner/tools/train.py", line 360, in
[rank3]:     main()
[rank3]:   File "/workspace/xtuner/xtuner/tools/train.py", line 356, in main
[rank3]:     runner.train()
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/mmengine/runner/_flexible_runner.py", line 1200, in train
[rank3]:     model = self.train_loop.run()  # type: ignore
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/mmengine/runner/loops.py", line 287, in run
[rank3]:     self.run_iter(data_batch)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/mmengine/runner/loops.py", line 311, in run_iter
[rank3]:     outputs = self.runner.model.train_step(
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/mmengine/_strategy/deepspeed.py", line 133, in train_step
[rank3]:     losses = self._run_forward(data, mode='loss')
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/mmengine/_strategy/deepspeed.py", line 176, in _run_forward
[rank3]:     results = self.model(**data, mode=mode)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank3]:     return self._call_impl(*args, **kwargs)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank3]:     return forward_call(*args, **kwargs)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/deepspeed/utils/nvtx.py", line 15, in wrapped_fn
[rank3]:     ret_val = func(*args, **kwargs)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/deepspeed/runtime/engine.py", line 1852, in forward
[rank3]:     loss = self.module(*inputs, **kwargs)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank3]:     return self._call_impl(*args, **kwargs)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank3]:     return forward_call(*args, **kwargs)
[rank3]:   File "/workspace/xtuner/xtuner/model/sft.py", line 245, in forward
[rank3]:     return self.compute_loss(data, data_samples)
[rank3]:   File "/workspace/xtuner/xtuner/model/sft.py", line 289, in compute_loss
[rank3]:     return self._compute_sequence_parallel_loss(data)
[rank3]:   File "/workspace/xtuner/xtuner/model/sft.py", line 279, in _compute_sequence_parallel_loss
[rank3]:     outputs = self.llm(**data)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank3]:     return self._call_impl(*args, **kwargs)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank3]:     return forward_call(*args, **kwargs)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/peft/peft_model.py", line 1430, in forward
[rank3]:     return self.base_model(
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1532, in _wrapped_call_impl
[rank3]:     return self._call_impl(*args, **kwargs)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1541, in _call_impl
[rank3]:     return forward_call(*args, **kwargs)
[rank3]:   File "/opt/conda/lib/python3.10/site-packages/peft/tuners/tuners_utils.py", line 179, in forward
[rank3]:     return self.model.forward(*args, **kwargs)
`

Hi @dingy007 !
很抱歉给您的使用带来不便。我刚刚测试了下您的 config ，发现在我的环境中是可以跑通的（替换您的 sft 数据为 Alpaca 数据，并将 accumulative_counts 从1284调为14）。
所以想跟您进一步确认下：

您的环境是否正确安装了 flash_attn
您使用的 qwen2 模型是否跟 HF Hub上的完全一致 （tokenzier 是否有修改）
我使用的起实验命令为：torchrun --nnodes=1 --nproc_per_node=8 xtuner/tools/train.py xtuner/configs/qwen/qwen2/debug.py --deepspeed deepspeed_zero1 --work-dir work_dirs/debug --launcher pytorch 请核对我们的脚本是否一致

如果仍然有问题，欢迎进一步沟通！

1.the flash_attn version is 2.5.9.post1,
2.do not modify the tokenizer
3.I use the command like this NPROC_PER_NODE=4 xtuner train qwen2_1_5b_chat_lora_sft.py --deepspeed deepspeed_zero2

Same problem, has it been resolved?
It should be caused by setting use_varlen_attn to True. Setting it to False will not report an error.

I have not been able to reproduce the error you encountered thus far. Therefore, I would kindly ask you to try using my config to see if the program runs smoothly:

Check if flash_attn has been installed successfully:

from transformers.utils.import_utils import is_flash_attn_2_available
print(is_flash_attn_2_available())

Use the latest code from the main branch of xtuner:

git clone https://github.com/InternLM/xtuner.git
cd xtuner
pip install -e '.[all]'

Train using the following config: NPROC_PER_NODE=4 xtuner train ${CONFIG} --deepspeed deepspeed_zero2
Check the training log for the presence of the message mmengine - INFO - Dispatch Qwen2FlashAttention2 varlen forward.

Here is my config.
qwen2_7b.txt
Here is my training log.
qwen2_7b_log.txt

I have not been able to reproduce the error you encountered thus far. Therefore, I would kindly ask you to try using my config to see if the program runs smoothly:

Check if flash_attn has been installed successfully:

from transformers.utils.import_utils import is_flash_attn_2_available
print(is_flash_attn_2_available())

Use the latest code from the main branch of xtuner:

git clone https://github.com/InternLM/xtuner.git
cd xtuner
pip install -e '.[all]'

Train using the following config: NPROC_PER_NODE=4 xtuner train ${CONFIG} --deepspeed deepspeed_zero2
Check the training log for the presence of the message mmengine - INFO - Dispatch Qwen2FlashAttention2 varlen forward.

Here is my config. qwen2_7b.txt
Here is my training log. qwen2_7b_log.txt

Hello, I followed your steps and used your configuration, but still got the error: RuntimeError: CUDA error: device-side assert triggered

Hi @bo-jpg @dingy007 !
This commit may potentially address the bug you encountered, and we will merge the pull request as soon as possible. We apologize for any inconvenience this may have caused in your usage.
If any issues persist, please let us know.

Hi @bo-jpg @dingy007 !
This commit may potentially address the bug you encountered, and we will merge the pull request as soon as possible. We apologize for any inconvenience this may have caused in your usage.
If any issues persist, please let us know.

I modified this line of code and now the model trains normally!
Thank you so much, this problem has been bothering me for several days. The code is amazing, one line of code can have such power! Thank you again for your patient answer!

Hi @bo-jpg @dingy007 !
This commit may potentially address the bug you encountered, and we will merge the pull request as soon as possible. We apologize for any inconvenience this may have caused in your usage.
If any issues persist, please let us know.

Hello, I tested the model performance when use_varlen_attn was set to True. Compared with the model when use_varlen_attn was False, the performance on the test set became very poor (other parameters were the same). I wonder if there is still a problem with the attention calculation when use_varlen_attn of Qwen2 is set to True?

Please provide your training log so we can check if the loss decreased normally.

Please provide your training log so we can check if the loss decreased normally.

Hello, the loss decreased normally. Here is the training log:
20240712_211628.log

Please provide your training log so we can check if the loss decreased normally.

Hello, the loss decreased normally. Here is the training log: 20240712_211628.log

II trained the model using the above settings of xtuner, but found that the model's performance was very poor. The same data performs normally when trained on llama-factory.

I use the following training parameters

pack_to_max_length = False
sequence_parallel_size = 4
# Scheduler & Optimizer
batch_size = 1 # per_device
accumulative_counts = 1# bs = 1 GPU * 1 batch_size_per_device * 16 acc
accumulative_counts *= sequence_parallel_size

The loss did not decrease significantly
2. The number of my data sets is 198k, and the data length covers 1k-16k
3. Can you please explain how the number of training iterations is calculated in xtuner? Because the training log shows tens of thousands of iterations.

In response to the above situation, do you have any suggestions for training parameters?


Sub-minute resoulution

Hi,
Is there a way to have a more precise schedule ?
for example: start at every day 10:00:00 and stop at 10:00:20 ?

Hello guydvir2, I hope you are doing well today.
From my understanding of the documentation the option for sub-second duration is not currently available (as well as duration in general) and must be worked around.
A possible solution that I thought up would be to create a function and close it with a call to both the previously called function and to cancel the job once completed.
This would look something like this:
def job():
    # Does your normal task
    schedule.every().day.at("10:00").do(job)
    return schedule.CancelJob

schedule.every().day.at("10:00").do(job)

To run a job at a specific second, use the .at() method. To start every day at 10:00:00 use:
schedule.every().day.at('10:00:12').do(job)

Sub-second resolution is not supported.

To run a job at a specific second, use the .at() method. To start every day at 10:00:00 use:
schedule.every().day.at('10:00:12').do(job)

Sub-second resolution is not supported.

thank you

thank you


Support temperature range for external temp sensor

Description:
Improve alert range for temperature when using ext temp sensor
Allow adding any value to beyond current min-max limitation
When edited, this value is used, with condition that min is smaller than max because app cannot know that external temperature sensor is used
We will not adjust slider

@io53 Looks like on mobile side devs (latest dev iOS build) have found a way to dynamically adjust the slider for external sensor.
Would you take a look if it's also possible on web? If not, we will go with this solution.

@markoaamunkajo Sure, no problem. So if you set max value to 120, the slider should go to 120 until you have saved a smaller value?

@io53 the min and max supported temperature range should be limited to -55 C - 150 C
Please don't allow saving when value is outside this range.

Works ok for me

QA passed


BUG: sparse.linalg: preserve column vector kind in iterative solvers

Ensure iterative solvers return solution x as a similar vector as the
input b is, retaining shape and ndarray vs matrix.
The issue in the original make_system code is obvious, but there are backward
compat issues which need to be considered (in particular, whether the
behavior can even be changed any more or should just be documented better).
cf. gh-8722

[ ] backward compatibility impact?

Should we still aim to decide on this before the approaching 1.2.0. @perimosocordiae any thoughts?
@rgommers Concerned re back compat?

@rgommers Concerned re back compat?

I only had time for a quick browse. It seems like the main issue is that 1-D array input now results in a different output shape, (1, N) vs (N,)?

There seem to be quite a few iterative solvers, so I suspect we need to be comfortable changing the outputs from all of them -- both in terms of retaining shape & fidelity to input object type. Doesn't look like anything would change from buggy to correct or the other way around, but strict user or library code could certainly require some modest maintenance.
If we didn't have back-compat concerns it would sound straightforward, but I've not touched the code on the sparse linear solvers. @perimosocordiae thoughts on disruption vs. benefit?

Bumping milestone -- would be good to have a few people chime in before this kind of decision

Similar comment as for the last release -- I'm bumping the milestone because there's a behavior change that we may not be able to make at this point, and there's no feedback on this.
The linked issue has also been quiet for the last year, so perhaps not much evidence of major disruption to users.

Sorry I missed the pings on this one! I'm leaning toward documenting this behavior better, rather than changing output types. As we (the scientific Python ecosystem) continue to move away from using np.matrix, the impact of this bug should be decreasing.
For now, I'll drop the milestone.

superseded by #21164


unpin numpy when upstream dependency fixed

https://github.com/DendrouLab/panpipes/pull/167#discussion_r1484420385

fixed by #197


Add configuration ability via a config object

This is the long awaited resurrection of https://github.com/mgomes/api_auth/pull/110
This is the first part, the base configuration changes. The other three PRs are based on this one, so this must be merged first.

@mgomes ++
Support for this would make this package like...the best ever...


Created a branch, created a file, opned pull request

Created a repository, master branch, a pull request

created a branch, created a file and made a commit, and opened a pull request


is MDBX_INTEGERKEY  support int32_t or int64_t ?

I see the document wrtie

MDBX_INTEGERKEY | Numeric keys in native byte order either uint32_t or uint64_t. The keys must all be of the same size and must be aligned while passing as arguments.

I want kown is MDBX_INTEGERKEY  support int32_t or int64_t or uint16_t or int16_t  , uint128_t , int128_t?

Please RTFM.

I readed the code , seems only support u32 and u64

  /* Compare two items pointing at aligned unsigned int's. */
  static int __hot cmp_int_align4(const MDBX_val *a, const MDBX_val *b) {
    mdbx_assert(NULL, a->iov_len == b->iov_len);
    switch (a->iov_len) {
    case 4:
      return CMP2INT(unaligned_peek_u32(4, a->iov_base),
                     unaligned_peek_u32(4, b->iov_base));
    case 8:
      return CMP2INT(unaligned_peek_u64(4, a->iov_base),
                     unaligned_peek_u64(4, b->iov_base));
    default:
      mdbx_assert_fail(NULL, "invalid size for INTEGERKEY/INTEGERDUP", __func__,
                       __LINE__);
      return 0;
    }
  }

Please RTFM, the quote: "MDBX_INTEGERKEY | Numeric keys in native byte order either uint32_t or uint64_t. The keys must all be of the same size and must be aligned while passing as arguments."
So please ask clarifying questions related to the documentation if something is unclear, or do PR to improve the documentation.
But (please) don't ask me to retell the source code.


Document option to define custom report name for xunit reporter

Extends documentation describing option to define custom report name for xunit reporter
Based on #2628

Coverage increased (+0.07%) to 91.888% when pulling b29a32b960e0825e3cd69756c4a95ee38f8c9e8c on pkuczynski:patch-1 into 9b00fedb610241e33f7592c40164e42a38a793cf on mochajs:master.


Fix for Expected non-null or undefined 'username' error

Fixes #1661

I'm not sure you understood the issue... local databases don't need credentials to view databases. A user should be able to connect with postgres://localhost:5432 and it should "just work"

I'm not sure you understood the issue... local servers don't need credentials to view databases. A user should be able to connect with postgres://localhost:5432 and it should "just work"

You need to use something like this for the localhost connection to work (assuming your localhost configuration does not support ssl connections, otherwise leave out the ssl part) --> postgres://localhost:5432?ssl=0
pg-connection-string library only considers ssl=0 as false.

https://github.com/microsoft/vscode-cosmosdb/pull/1663#discussion_r477472639
As connectionString is a ServerTreeItem property, databaseName would only be present for the attached scenario. But this modification is unnecessary change for this particular PR, I will remove it here and include it in the other one.

Make sure to test out the localhost scenario - I'm still seeing "Must enter credentials" when I should be seeing the databases without needing to enter credentials

I am able to connect, you just have to include the username in the connection string for it to work.

I am able to connect, you just have to include the username in the connection string for it to work.

People don't typically add a username to a localhost connection string, so it should work without that

I am able to connect, you just have to include the username in the connection string for it to work.

People don't typically add a username to a localhost connection string, so it should work without that

The changes in the latest commits should resolve this issue. The connection string postgres://localhost:5432 should work as is and there shouldn't be a Must enter credentials to connect to server either.


Fix Hangouts badge counter

Pre-flight Checklist
Please ensure you've completed all of the following.

[x] I have read the Contributing Guidelines for this project.
[x] I agree to follow the Code of Conduct that this project adheres to.

Description of Change

Fixed the counting of the notifications in the Hangouts recipe.

I've made the requested changes.

I dont use hangouts chat recipe, so I haven't tested this locally. but the changes look good.

@all-contributors please add @tamas646 for code


metrics: support rocksdb metrics

We can get rocksdb metrics (see https://github.com/facebook/rocksdb/blob/master/db/c.cc#L1870), maybe we can push some to prometheus too.

Now we can send SIGUSR1 signal to dump metrics to log, and we can also get the rocksdb metrics with rocksdb_options_statistics_get_string and dump to log too.


eclipses: 2020-06 -> 2020-09

Motivation for this change
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @rycee

Thanks to @jerith666 and @mohe2015, much appreciated. Rebased to master in a7cad45d933370424fd12d3a1d46ac88599dba63.


Added missing copyright headers

@alalek please review. The best solution is just remove dummy.h and related includes from flann, but binary compatibility...

:+1:


Decide how capabilities should be replaced/deleted

This issue is based on a comment in #129.
When registering a procedure which previously existed there is a potential for the newly registered procedure to inherit the capabilities of the previously deleted procedure. Currently the alpha PR just sets the clists to zero length before registering a new procedure. However, we might want to consider this when deleting procedures. When deleting a procedure we have three options for how we treat the old procedures:

Do nothing. Let registration handle it.
Set all the c-list lengths to zero.
Clear everything.

Clarification: by "do nothing" I mean currently option 1 is there in the code by default.

Let's do 3. However not in #129, but as a seperate PR.


Size of the bottleneck layers

It seems that the bottleneck layers do not match the actual Paper where the number of filters are supposed to be 1024. making the filters across the Model look like this :
filters = [64, 128, 256, 512, 1024] which is obviously not the case in here.
Was there a case specific reason behind your choice ?
Because eventually, it seems that the number of the constitutional layers does not match the 23 layers mentioned in the original Paper.

Hey @med-cms,
Sorry for the late response. As you've pointed, the number of filters is 512 in the bottleneck layer. It is my bad that I didn't write it more clearly and thank you for pointing it out.
self.bottleneck = torch.nn.Sequential(
                            torch.nn.Conv2d(kernel_size=3, in_channels=256, out_channels=512),
                            torch.nn.ReLU(),
                            torch.nn.BatchNorm2d(512),
                            torch.nn.Conv2d(kernel_size=3, in_channels=512, out_channels=512),
                            torch.nn.ReLU(),
                            torch.nn.BatchNorm2d(512),
                            torch.nn.ConvTranspose2d(in_channels=512, out_channels=256, kernel_size=3, stride=2, padding=1, output_padding=1)
                            )

I have decreased the size mostly because of the memory  reasons and it was slowing it down. I  did not follow the proper exactly but followed the concept mentioned in the paper and tried to show some results  using it. Thanks for letting me know and let me know of you have any question.


seniority-calc-db-deployer failed

Hi, Gurus,
seniority-calc-db-deployer always failed .
seniority-calc-db-deployer-2022-04-02 08_59_59.783+0000.txt

Hi, Gurus,
Upgraded the NPM to 8.60,  then the command mbt build will end with error .

Hi @I501000 - Thanks for entering this issue in our repository. Can you provide the mbt build output after you ugraded NPM, please?
Regards,
Jim

i have similar issuse
seniority-calc-db-deployer-2022-04-13 14_34_33.863+0000.txt

Hi @MattiaRedaelli - your logfile specifically errors on the npm verison. Can you run this in the terminal, rebuild the mbt archive, and let me know? please attach the updated logs and we'll take a look.

Hi @jmsrpp ,i'm in the same situation as @I501000 , if i upgrade my npm version the command mbt build fail. Now i'll try again (deleting the .hdiconfig file and running cds build).

Thanks @MattiaRedaelli - please provide any logs or stdout so I can review.

thanks to you @jmsrpp, for convenience I put in a file everything that generated the command, but here is the error
error_mbt_build.md

@MattiaRedaelli - looks like you have the error here:
https://stackoverflow.com/questions/69567381/getting-cannot-read-property-pickalgorithm-of-null-error-in-react-native
Try clearing the npm cache and repeat the build process, please. Looks like no issue with the cds build.

Update: running
npm cache clear --force
npm set registry=https://registry.npmjs.org/
npm install -g<EMAIL_ADDRESS>the command now works, but when i try to start seniority-calc-db-deployer in the log there is the same error ("npm notice Run npm install -g<EMAIL_ADDRESS>to update!")

Hi @MattiaRedaelli - forgot to mention, please also delete package-lock.json in your project (double check the db/srv too) and rebuild. We need the deployed application to rebuild with the latest dependencies. Feel free to share all the logs here.

hi @jmsrpp, unfortunately nothing has changed, the error remains even if the "npm: ^ 8.7.0" field appears in both package.json and package-lock.json.
seniority-calc-db-deployer-2022-04-14 20_34_20.033+0000.txt

@MattiaRedaelli - just to confirm, you deleted all package-lock.json files in your application root, db, and srv folders. You rebuilt the mbt archive and pushed it again to CF?

now i'll try again, for be sure, is that correct?
#type: org.cloudfoundry.managed-service
type: org.cloudfoundry.existing-service

if i re-download the progect, there are these package-lock files?

@MattiaRedaelli - yes there are package-lock.json files in the repo. If you confirm rebuilding locally after you delete them works, I will remove them from the repo and force the generation on deployment.

now i'll try again, for be sure, is that correct?
#type: org.cloudfoundry.managed-service
type: org.cloudfoundry.existing-service

Yes that is correct if your event mesh service is already created.

to not waste any more time I would say that if it works re-download the project if it works.
thank you so much for all the support

Update: I recreated the project from the beginning, installed the new version of "npm", but the error of the "seniority-calc-db-deployer" always remains the same (even if no errors are reported in the terminal and the package is updated to correct time). I also tried to edit the mta.yaml file in the following way:
build-parameters:
before-all:
- builder: custom
commands:
- npm cache clear --force --production
- npm set registry=https://registry.npmjs.org/ --production
- npm install -g<EMAIL_ADDRESS>--production
- npx -p @sap/cds-dk cds build --production
seniority-calc-db-deployer-2022-04-15 14_03_35.481+0000.txt
SAP_Business.txt

Hi @MattiaRedaelli - I just deployed the app w/o any problems. I added a step to the README to have you install and update npm dependencies before the initial deployment, but other than that, no issues. In your latest log, seems like everything is working:
Application "seniority-calc-srv" started and available at "-consulting-cs-srl-btpmission-dev-seniority-calc-srv.cfapps.us10.hana.ondemand.com"
Now, you can add dummy-auth: https://github.com/SAP-samples/successfactors-extension-calculate-employee-seniority/blob/main/package.json (L 60-62), rebuild, and redeploy. That will allow you to continue the mission.

hi @jmsrpp, I'm sorry not to be able to do the mission correctly, but unfortunately the usual error related to the npm update results, although the deployment goes smoothly, the version is updated and the new changes have been made
seniority-calc-db-deployer-2022-04-19 09_45_47.929+0000.txt

Closing as we resolved this by undeploying with --delete-services and redeploying.


Can you please support Split and Slice as well?

I mean our tensorflow frontend now doesn't support Gather now.
I see "take" operator is added to tvm already and nnvm operator for the same is pending.
We could use this to support Gather.
Originally posted by @srkreddy1238 in https://github.com/dmlc/tvm/pull/1188#issuecomment-395296872

Traceback (most recent call last):
File "x.py", line 125, in
sym, params = nnvm.frontend.from_tensorflow(graph_def, layout=layout)
File "/homed/lidw/tvm/nnvm/python/nnvm/frontend/tensorflow.py", line 1411, in from_tensorflow
sym, params = g.from_tensorflow(graph, layout)
File "/homed/lidw/tvm/nnvm/python/nnvm/frontend/tensorflow.py", line 1096, in from_tensorflow
"The following operators are not implemented: {}".format(missing_operators))
NotImplementedError: The following operators are not implemented: set([u'Slice', u'Split'])


Lem is now on https://lem-project.github.io/

Hello,
Lem's URL is now simpler.
https://lem-project.github.io/
(instead of …/lem-page/)
thanks

Hello @vindarel!
I hope you are doing well. Thanks for providing the updated URL. Fixed in commit 6796838.


Easy set transport

Summarise the changes this Pull Request makes.
The UDPTransport is far ahead of the IPTransport and I think that this is not an essential thing, simply due to all the development effort being focussed on the more common UDP scenario. It seems that the only essential way that these differ is in the variety of socket created.
So  UDPTransport becomes SocketTransport that can create either kind of socket, controlled by a 2-state enum SocketProtocol.
IPTransport or something to replace it is necessary: We still need to make IP sockets for AWS Lambda cases, but there should be an easier way to do that common case.  A SocketProtocol flag on the configuration solves that.
The more complex custom setup should still be just as possible as before.
We will need to test this with both kinds of socket, localy and then in Lambdas with IP sockets, and in regular features with UDP.
Please include a reference to a GitHub issue if appropriate.

I found that SocketProtocol enum hard to name - It can't be SocketTransport. I am open to other name suggestions.

SocketMode?


Emr operator throws error on executing steps using non-us region for s3 staging directory.

I've tried to use emr operator with EMR, S3 on Tokyo region, but failed on executing simple steps.
stderr looks like this:
Traceback (most recent call last):
  File "/mnt/var/lib/hadoop/steps/s-xxx/./runner.py", line 134, in <module>
    status = main()
  File "/mnt/var/lib/hadoop/steps/s-xxx/./runner.py", line 105, in main
    download_to_filename(s3, args.config_uri, config_filename)
  File "/mnt/var/lib/hadoop/steps/s-xxx/./runner.py", line 38, in download_to_filename
    download_to_file(s3, src, f)
  File "/mnt/var/lib/hadoop/steps/s-xxx/./runner.py", line 28, in download_to_file
    key.get_contents_to_file(f)
  File "/usr/local/lib/python2.7/site-packages/boto/s3/key.py", line 1650, in get_contents_to_file
    response_headers=response_headers)
  File "/usr/local/lib/python2.7/site-packages/boto/s3/key.py", line 1482, in get_file
    query_args=None)
  File "/usr/local/lib/python2.7/site-packages/boto/s3/key.py", line 1514, in _get_file_internal
    override_num_retries=override_num_retries)
  File "/usr/local/lib/python2.7/site-packages/boto/s3/key.py", line 343, in open
    override_num_retries=override_num_retries)
  File "/usr/local/lib/python2.7/site-packages/boto/s3/key.py", line 303, in open_read
    self.resp.reason, body)
boto.exception.S3ResponseError: S3ResponseError: 400 Bad Request
<?xml version="1.0" encoding="UTF-8"?>
<Error>AuthorizationHeaderMalformed<Message>The authorization header is malformed; the region 'us-east-1' is wrong; expecting 'ap-northeast-1'</Message><Region>ap-northeast-1</Region><RequestId>xxx</RequestId><HostId>xxx</HostId></Error>
Command exiting with ret '1'

Temporary this error was fixed since I've compiled digdag-cli with dirty hack on runner.py, fixed hard-coded variable host with "s3-ap-northeast-1.amazonaws.com".
https://github.com/treasure-data/digdag/blob/master/digdag-standards/src/main/resources/io/digdag/standards/operator/aws/runner.py#L101
I’m just wondering if the variable host should use secret value for 'aws.s3.region' or 'aws.region'.
Any comments or suggestions are welcome.

Sorry for our late reply and thank you for the reporting. We'll look into this issue later.

Have the same issue, I did set all of secrets regard to regions and endpoints.
$ digdag secrets --project test

2018-12-07 17:37:36 +0900: Digdag v0.9.31

aws.access_key_id
aws.secret_access_key
aws.emr.endpoint
aws.s3.endpoint
aws.emr.region
aws.s3.region
aws.region

with this workflow, but failed.
+run:
  emr>:
  action_on_failure: CONTINUE
  cluster: ${emr_cluster.id}
  staging: ${emr_cluster.digdag_staging_dir}

  steps:
  - type: command
    command: echo
    args: [hello, world]

Here is a step error in AWS EMR (steps -> log files -> controller)
2018-12-07T08:39:16.108Z INFO Ensure step 19 jar file s3://us-east-1.elasticmapreduce/libs/script-runner/script-runner.jar
INFO Failed to download: s3://us-east-1.elasticmapreduce/libs/script-runner/script-runner.jar
java.lang.RuntimeException: Error whilst fetching 's3://us-east-1.elasticmapreduce/libs/script-runner/script-runner.jar'
	at aws157.instancecontroller.util.S3Wrapper.fetchS3HadoopFileToLocal(S3Wrapper.java:412)
	at aws157.instancecontroller.util.S3Wrapper.fetchHadoopFileToLocal(S3Wrapper.java:351)
	at aws157.instancecontroller.master.steprunner.HadoopJarStepRunner$Runner.<init>(HadoopJarStepRunner.java:243)
	at aws157.instancecontroller.master.steprunner.HadoopJarStepRunner.createRunner(HadoopJarStepRunner.java:152)
	at aws157.instancecontroller.master.steprunner.HadoopJarStepRunner.createRunner(HadoopJarStepRunner.java:146)
	at aws157.instancecontroller.master.steprunner.StepExecutor.runStep(StepExecutor.java:136)
	at aws157.instancecontroller.master.steprunner.StepExecutor.run(StepExecutor.java:70)
	at aws157.instancecontroller.master.steprunner.StepExecutionManager.enqueueStep(StepExecutionManager.java:246)
	at aws157.instancecontroller.master.steprunner.StepExecutionManager.doRun(StepExecutionManager.java:193)
	at aws157.instancecontroller.master.steprunner.StepExecutionManager.access$000(StepExecutionManager.java:33)
	at aws157.instancecontroller.master.steprunner.StepExecutionManager$1.run(StepExecutionManager.java:94)
Caused by: com.amazonaws.services.s3.model.AmazonS3Exception: The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint. (Service: Amazon S3; Status Code: 301; Error Code: PermanentRedirect;

Close the old issue. Please reopen or file new one if you need.


Twitter Post Action Implementation

Relates to:
N/A - Plugin implementation for Twitter posting functionality via action
Risks
Low - This is a new plugin that adds Twitter posting capability. The main risks are:

Failed tweets due to rate limiting or authentication issues
Potential for tweets that are too long (mitigated by automatic truncation)
No risk to existing functionality as this is an isolated plugin

Background
What does this PR do?
Adds a Twitter plugin that enables posting tweets through the agent-twitter-client package. Key features:

Implements POST_TWEET action for sending tweets
Handles Twitter authentication via environment variables
Automatically truncates tweets that exceed character limits
Provides detailed error handling and logging
Supports dry run mode for testing

What kind of change is this?
Features (non-breaking change which adds functionality)

Adds new Twitter posting capability
Uses the standalone agent-twitter-client package
Implements proper error handling and character limit enforcement

Documentation changes needed?
My changes require a change to the project documentation:

Add Twitter plugin setup instructions
Document required environment variables:

TWITTER_USERNAME
TWITTER_PASSWORD
TWITTER_EMAIL
TWITTER_DRY_RUN (optional)
TWITTER_2FA_SECRET (optional)

Testing
Where should a reviewer start?

Review packages/plugin-twitter/src/actions/post.ts for the main implementation
Check error handling in postTweet function
Review tweet composition logic in composeTweet function
Verify environment variable handling

Detailed testing steps

Set up environment variables in .env:

TWITTER_USERNAME=your_username
TWITTER_PASSWORD=your_password
TWITTER_EMAIL=your_email
TWITTER_DRY_RUN=false

Test tweet posting:

# Start with dry run mode
TWITTER_DRY_RUN=true pnpm dev

# Test actual posting
TWITTER_DRY_RUN=false pnpm dev

Verify error handling:

Try posting a tweet > 180 characters (should truncate)
Try posting with invalid credentials (should show error)
Try posting with missing credentials (should validate)

Check logging:

Verify credential validation logs
Check tweet content generation logs
Verify error messages are descriptive

Deploy Notes

Requires agent-twitter-client package
Environment variables must be set for Twitter authentication
No database changes required

Several people have commented in the discord coders chat about twitter functionality from an action instead of the hard coded client loop. I've opened this PR just to show an example of how this can be done.
 Then I can say "go tweet that" and the agent will put it on their twitter profile -- without using the client-twitter package.

thanks for the review @monilpat this is my first time opening a PR so I'll address the changes.


Add open source license to project

Can you please add an open source license to this project so that others can use it?  Github provides details on how to do so here: https://help.github.com/articles/adding-a-license-to-a-repository/.  The MIT license is pretty popular.
Without a license, all rights are reserved and others can't use your project for any purpose.  You can read more at https://help.github.com/articles/licensing-a-repository/

You're under no obligation to choose a license. However, without a license, the default copyright laws apply, meaning that you retain all rights to your source code and no one may reproduce, distribute, or create derivative works from your work. If you're creating an open source project, we strongly encourage you to include an open source license. The Open Source Guide provides additional guidance on choosing the correct license for your project.

no prob there you go


Remove unnecessary es6-promise

I don't think it's needed in dependencies.
Also, it makes a problem because es6-promise is defined twice, in dependencies and devDependencies with different version requirements.

@tmeasday can you check that typedoc would still work after merging this PR?

Well typedoc works on the development version so I don't think it makes a difference. But I did check, thanks :)


NameError: global name 'PACKAGE_NAME' is not defined

After installing this package with package control and trying to go from a binary plist to XML format, I get the following error:
Traceback (most recent call last):
  File "./Plist Binary.py", line 9, in run_
NameError: global name 'PACKAGE_NAME' is not defined

Here as well:
Traceback (most recent call last):
  File "Plist Binary in /Users/<username>/Library/Application Support/Sublime Text 3/Installed Packages/Plist Binary.sublime-package", line 9, in run_
NameError: global name 'PACKAGE_NAME' is not defined

Installed through Package Control on Sublime Text 3.
Package version: 2<IP_ADDRESS>.48.19
The command plutil -convert xml1 <path-to-plist> works in Terminal.

removed that constant, should work now.


Setup Configuration

Hello,
I have change StorageClass to the right value and corrected few errors in your configuration files before installing the helm chart on my kubernetes cluster (lns.alpwan.eu). I have changed the AS et Mosquitto service to "LoadBalancer".
Access to the AS ui is ok.
Access to mqtt broker is ok.
I receive the sensor frames correctly but I never see the gateway in the dashboard, i never receive the gateway status frames and the sensor frames are always SF12.
Do you have an idea about these problems?
Thank you.
Best regards,

but I never see the gateway in the dashboard
Gateway also is one of the device, you should create it.

I think it should be create on https://github.com/brocaar/chirpstack-application-server

Hello,
I have created the gateway, the application and a device (I have a good knowledge of chirpstack)
The gateway works very well otherwise I will not receive the frames from the sensor.
I have also chek that the gateway send status frames correctly (on gateway side).
An idea ?
Cordialement / Best regards
[image]
Stéphane David
Embedded Computers / ARM / RISC-V / Linux
Telecoms & Network / M2M / IoT
Mobile: +33 (0)6 87 00 73 19
www.alpwan.fr
Envoyé avec la messagerie sécurisée ProtonMail.
------- Original Message -------
Le mardi 29 mars 2022 à 16:38, Lan @.***> a écrit:

but I never see the gateway in the dashboard
Gateway also is one of the device, you should create it.

I think it should be create on https://github.com/brocaar/chirpstack-application-server
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

So all of pod of chirpstack is running? any error on the log from chirpstack-ns pod ?


RFC: install command with submodule proposals

RFC for #43
quickly slapped this proposal. Before failing on the .git can't be found we can check if we're inside a submodule.
Option 1 Use the path returned by git to find the main .git and continue with the install normally. we don't attach husky to anything else. This should be enough assuming the .husky is present in the root super project
Option 2 husky install step is in both the submodule and the super project. we check if we're running the submodule target and just break, let the super project target do the install instead.
I believe this should work without breaking existing projects. Will give it a try tomorrow and report back.
Need feedback before working on a final mergeable PR.

Hi @Tychus,
I think we need to support all three scenarios,
1- husky in both submodule and root super project,
2- husky only in root project
3- husky only in submodule
all three options are valid, but we need to somehow detect what user wants (from the project files or configuration).
unfortunately at the moment I don't have time to investigate further but it would be nice if you can check it out and implement it. also keep it in mind worktree and submodule need different flows.( #43 is related to worktree.)

if you can check it out. also keep it in mind worktree and submodule need different flows.

Yup this PR is just to illustrate the proposal.

I think we need to support all three scenarios,

Will have some time later to actually work on a real fix for this.
I'm thinking some parameter is need here IgnoreSubmodule or something like that, based on which we can either drop the whole install or grab the hooks and set them up up top in the main repo.


A metadata spreadsheet example friendly for a data consumer

As a data consumer I want to download a friendly version of the metadata for a project, containing the full amount of the metadata for a project. The assumption we have is that file looks like a metadata csv in one tab, which links the files with the full metadata of the biological entity (cell).

Given [assumption]
When [action]
Then [outcome]

work maintained on #854. Closing this


fix: invoking a non-popup window from headless kui will have incorrect uuid for splits

Fixes #7303

Description of what you did:

My PR is a:

[ ] 💥 Breaking change
[ ] 🐛 Bug fix
[ ] 💅 Enhancement
[ ] 🚀 New feature

Please confirm that your PR fulfills these requirements

[ ] Multiple commits are squashed into one commit.
[ ] The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
[ ] All npm dependencies are pinned.

seems good. this was an oversight in the code base. i don't think we had this use case: pop up a window, but in "normal" client mode, not "popup" client mode
/lgtm


Document multi-region support for 21.1

See also:

#8851
#9005
#9030
#9038
#9039
#9040
#9095
#9096
#9110
#9113
#9115
#9116
#9117
#9118
#9120
#9123
#9171
#9268
#9273
#9289
#9341
#9342
#9343
#9508
#9542
#9552
#9554
#9557
#9564
#9567
#9568
#9573
#9574
#9595
#9598
#9599
#9600
#9601
#9605
#9606
#9610
#9611
#9613
#9616
#9617
#9618
#9620
#9624
#9704
#9708
#9709
#9710
#9884
#9885
#9886
#9887

Closing this since all roadmap issues are documented as of today (17 May 2021).
Remaining issues are release notes / small updates, and will be worked on via the backlog in the Multiregion Docs board


consistent return values for SMTP EmailBackend.send_messages()

This PR ensures that SMTP EmailBackend.send_messages() always returns an integer

how could I restart the failed check?

ERROR: Step ‘Publish JUnit test result report’ failed: No test report files were found. Configuration error?
the restart didn't help :( well, it seems to be broken not by me

@stebunovd Build on windows sometimes has issues after force-push. I restarted this build and it looks good.
Please add a trac ticket for this change.

thanks! The ticket: https://code.djangoproject.com/ticket/30058

Hey @stebunovd, thanks for the PR! Please uncheck patch needs improvement on the Trac ticket once you've added a test for the not emails branch. That'll move the ticket to the final review queue.

hey @charettes, I have added the test and unchecked patch needs improvement box. Thanks!


Empty sections on the dashboard need more bottom padding

Both "No talks" should have more bottom padding/margin

Added a pb-4 to the text


Pushing germanjoey/Leaflet.Draw to Leaflet.Draw/undo-manager

Pushing germanjoey/Leaflet.Draw to Leaflet.Draw/undo-manager

Sweet, thanks for all your help with this.
On Fri, Jul 14, 2017 at 9:03 AM, Jon West<EMAIL_ADDRESS>wrote:

Merged #745 https://github.com/Leaflet/Leaflet.draw/pull/745.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Leaflet/Leaflet.draw/pull/745#event-1164534328, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAzNEj2KRD_2XNgvxAvO0JCe-cdpdp_Aks5sN5FMgaJpZM4OTplv
.


please add a mocked example

Hi there,
Nice work done here! Appreciated!
Wondering if you could include an example using mock as some times and for some of the services throttling is an issue...
Regards,
Julio

sorry, looks like I need to checked my eyes xD

I think you're looking general AWS SDK documentation, rather than something specific to using Go in AWS Lambda. This repo is focused solely on the integration with the AWS Lambda execution environment.
https://aws.github.io/aws-sdk-go-v2/docs/unit-testing/#mocking-client-operations might be what you're looking for.


Deeplink to Samples from Docs

Originally 2077 from the toolkit repo.
Since we can protocol handle on our sample app, it'd be great if each page in our docs that has a sample could just open up the sample app (if installed) to the sample app for that sample.
It may make sense to have an image badge for this like 'try now'?

I'll take this.
Many pages already include a link to the app in the store

You can see this in action in Windows Community Toolkit Sample App.

Should these be removed or the new link/badge be included in addition to this?
Where on each page should the link go? In the Sample Project section [example]?
Rather than a custom image, should it be a next step action?
(Also note that current app links use a mixture of the direct store link and http://aka.ms/uwptoolkitapp - this should probably also be standardized. But with which?)
Note to self:
Links take the format:

uwpct://Controls?sample=BladeView
uwpct://Helpers?sample=PrintHelper

Full list of supported links derived from https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/master/Microsoft.Toolkit.Uwp.SampleApp/SamplePages/samples.json

Thanks @mrlacey!
I think we'd want the link to the sample up near the top after the intro paragraph, I like your idea of testing out the next step action for this to help make it standout.
Then we could also add the next step action in the Sample Project section?  And leave the general link?  We should consolidate them to use the aka.ms though in case the store link ever changes we can just update the aka.ms vs. having to change it in the repo.  I should probably grab a new one with a different name though.

So:

A link like this after the opening paragraph of each relevant page that opens the relevant page in the sample app

Standardize having a Sample Project section in the document. This should come before Requirements and include a link to the source page in the sample app, a link to the sample app in the store (new aka.ms link to be advised), and a link to open the app at the relevant sample page. These will all be text links.

As there are cuurently a lot of open PRs ;) I'm reluctant to make a start on this just yet as there's a potential for multiple merge issues.
I could do one page first to try it out though...?

@mrlacey looks good.  I'll shoot to try and close all our open PRs after //Build.  They're waiting on the feature PRs to close on the main repo.  For now, pick an auxiliary page outside of those PRs for at test, like AdaptiveGridView?

I should probably grab a new one with a different name though.

@michael-hawker have you made a new aka.ms redirect link for the store entry? or should I standardize on http://aka.ms/uwptoolkitapp ?

There is a bug in the sample app that means it doesn't work with URIs that contain encoded values--which are needed in a number of cases. (21)
I propose adding the links to the docs pages (with the encoded values) even though they will only lead to the app being launched but not navigating to the correct sample page until the sample app is updated. (I'll submit a PR to fix that once the issue and my proposed fix is acknowledged.)
I deem this preferable to adding links to the relevant pages at a later time, once the updated app is released.

No deep links in the docs for the following as they don't have documentation pages:
uwpct://Gaze?sample=GazeTracing
uwpct://Helpers?sample=LiveTile
uwpct://Helpers?sample=Toast
uwpct://Helpers?sample=WeatherLiveTileAndToast

This has been implemented and the doc have the option to launch Sample App now.


fix: button general and specific classes merged added

Motivation:
I wanted to add some default classes but these were overridden by specific classes given to the button component
Changes:
Merge default button classnames with given ones

@sajadevo


Python 3 support?

Hello.  Are there any plans to migrate this package to Python 3?  I was able to make a usable version with 2to3 and a few minor tweaks, but it'd be nice to see an official version!
Thanks.

Hi dswhite42, no plans to port to 3. I'd be interested in seeing your 2to3 port fork.

Here it is:
https://app.box.com/s/bcd56lee3tcw242wr6m8455wld9xwstx


staticPageState

@iansinnott what do you think about having a bit of middleware that you could call in a component constructor?
for building out a proper static site that has meta data and what not, I feel like that could get messy really quick.
so what if we exposed an api for something like this?
import { setStaticPageState } from 'react-static-webpack-plugin';
class Home extends Component {
  constructor() {
    setStaticPageState({
       title: 'foo',
       description: 'bar',
       locale: this.props.route.locale,
       favicon: require('./favicon.ico'), // this might live further up but could be set with the same function
    });
  }
}

and then in the template.js provide something like
const Html = (props, pageState) => (

        <meta charSet='utf-8' />
        <meta httpEquiv='X-UA-Compatible' content='IE=edge' />
        <meta name='viewport' content='width=device-width, initial-scale=1' />
        <title>{pageState.title}</title>
        {pageState.favicon ? <link rel='shortcut icon' href={pageState.favicon} /> : null}
        {pageState.stylesheet ? <link rel='stylesheet' href={pageState.stylesheet} /> : null}


feat: add Storybook

close https://github.com/coinbase/onchainkit/issues/758

This should be a good starting point.
yarn watch should be run alongside yarn storybook:dev to get live changes of styles.
Insight:

Imo TokenSearch should allow users to specify the source of tokens to search in. It also requires an api key to be able to do real search.
Avatar has 2 loading states which is very weird, see story (refresh page on WithBadge story`
Badge doesn't render correctly when used individually, see story
Accessibility checks are context dependent i.e. TokenSelectDropdown doesn't have a11y issues because it's built with div tags and not select/options
Documentation is auto-generated using JSDoc annotations from components, it would be great to document components if necessary

I was thinking about mocking requests using service workers but I find that it's actually better to do real requests to know if things are broken or not.
Regarding CI, it can be done programmatically using test-runner or visually and collaboratively using Chromatic. I prefer the latter since it's visual but it depends on if you are looking to use Chromatic or not @fakepixels @Zizzamia

@roushou can you get the Build pass, please. So than I can review it.

@Zizzamia I can't reproduce locally. It seems to come from this line
https://github.com/coinbase/onchainkit/blob/ab93ca06dd9f922e177a27751d6cd9ce7aa53971/.github/actions/setup/action.yml#L17
Which makes build fail on purpose on CI
https://classic.yarnpkg.com/lang/en/docs/cli/install/#toc-yarn-install-frozen-lockfile

Ok I am going to take care of the Build issue.


How to test if geometry is a Point?

Thank you for all the work you have done upgrading the package, and the conversion guidelines at https://github.com/GEOSwift/GEOSwift/blob/master/VERSION_5.md are good.
But how do I convert the following code? ..
(Swift 5, Xcode 10.2)
            if geom is Waypoint {
                let pt = geom as! Waypoint

If I change the first line to ..
           if geom is Point {

.. I get the compile error
Cast from 'Geometry' to unrelated type 'Point' always fails

Geometry is now an enum, so you should be able to use switch or if case let:
if case let .point(pt) = geom {
    ...

Let me know if it works for you.

Thanks, Andrew.
The compiler is happy with that.  I just need to get the rest of my code compiled before I can test that your suggestion above works.
Can you please also tell me how to change this ..
let feat = try Features.fromGeoJSON(url)   // (url is type URL)

In the Summary of API Changes, it mentions

FeatureCollection: Decodable

So I figure something like this ..
let feat = try FeatureCollection(from: <#T##Decoder#>)

.. but haven't been able to find doco or examples on Decodable

Decodable works with JSONDecoder. If you know that your GeoJSON is a feature collection, you can say:
let jsonData = try Data(contentsOf: url)
let decoder = JSONDecoder()
let featureCollection = try decoder.decode(FeatureCollection.self, from: jsonData)

The GeoJSON spec also permits other top-level types (Feature, Geometry), so if you're not sure which top-level type you'll receive in your data, you should change the third line to read:
let geoJSON = try decoder.decode(GeoJSON.self, from: jsonData)

GeoJSON is an enum with associated values that has 3 cases: featureCollection, feature, and geometry. You can use the same techniques we discussed earlier to check which type you have and extract the associated value.
On the other hand, if you know for sure you'll only ever be decoding a specific GeoJSON type (say, polygon), you can also decode it directly to avoid the associated value extraction altogether:
let polygon = try decoder.decode(Polygon.self, from: jsonData)

Lastly, your v4 code was using the url-based fromGeoJSON method. In version 5, we've separated the concerns of getting the data (could be from a file, from a web API, etc) and decoding it, which is why you now need to say Data(contentsOf: url) too.

Thank you so much for your help, Andrew.
I have now got the app to the state where it is all compilable and runnable with Swift 5 and Xcode 10.3.  A fairly major job, with pod updates, code changes, etc.
I have a problem when reading a feature collection from a geoJSON file.  This is the code (from your suggestion above) ..
// Version 4 code ..
// let features = try Features.fromGeoJSON(url)

// GeoSwift 5 method instead ..
let decoder = JSONDecoder()
let jsonData = try Data(contentsOf: url)        // get the JSON data
featureCollection = try decoder.decode(FeatureCollection.self, from: jsonData)
features = featureCollection.features

I have pasted values read from the geoJSON file (from within the debugger) ..
Reading from geoJSON ..
features	[GEOSwift.Feature]	3365 values
[0]	GEOSwift.Feature
  geometry	GEOSwift.Geometry?	point
  properties	[String : GEOSwift.JSON]?	37 key/value pairs
  [0]	(key: String, value: GEOSwift.JSON)
    key	String	"ORE_GENESS"
    value	GEOSwift.JSON	null
  [1]	(key: String, value: GEOSwift.JSON)
    key	String	"DESCRIPT"
    value	GEOSwift.JSON	string
      string	String	"Small quarry providing silica and gravel."
  [2]	(key: String, value: GEOSwift.JSON)
    key	String	"PARENT_ID"
    value	GEOSwift.JSON	null

2 problems ..

'properties' is of type [String : GEOSwift.JSON] - I believe was previously [String: Any] - this is what I am retrieving from a SQLite file that was populated with the pre-version5 version of the app
within the 'properties' ALL numbers are NIL - ie. the number values have not been read

Can you please assist?

Can you share an example GeoJSON file that reproduces the problem?

Rename back to .geojson ..
TAS_constr_materials.txt

I was wrong about all numbers being nil.  Numbers are being read OK.

Glad to hear it! Let me know if you run into anything else. I'm going to close this issue. Let's open separate tickets for future issues. That will make it easier for other people to find questions and answers that might help them.

No, there is just one problem not two.
The code for reading the geoJSON is not producing a Dictionary for the 'properties  ie. [String: Any]
It is producing [String : GEOSwift.JSON]
How do I get the properties into a Dictionary?

Oops, sorry for misunderstanding.
In v4, properties had type [String: Any]. That worked b/c the implementation used JSONSerialization. This changed to [String: JSON] in v5 so that we could support Codable.
You should be able to update your code to extract the values you require from JSON. Similar to Geometry that we discussed earlier, JSON is an enum with associated values, so you can use the same techniques (if/guard/switch, case let) to extract specific values.
Can you share a little more info about how you're using the properties dictionary? That may help me guide you toward a solution a little more easily.

I have found that this is how I am converting 'properties' to a NSDictionary ..
let attribs: NSDictionary = feature.properties! as NSDictionary

.. but I think the result might have changed with Swift 5, and it is not producing the right format for
let data: Data = NSKeyedArchiver.archivedData(withRootObject: attribs) as Data

.. which is failing with this error ..
ausgeologymaps[277:48138] -[__SwiftValue encodeWithCoder:]:
                 unrecognized selector sent to instance 0x5fa42d0

Please leave this ticket closed.  I will investigate further and work out if this is a more general problem that should be on Stack Overflow.  Or if it is directly relevant to the GeoSwift conversion process, then I will create a new ticket here.

Oops, crossed posts, just read your previous comment.  Yes, any help will be appreciated.

I think this was probably what I was previously feeding to NSKeyedArchiver.archivedData ..
[0]	(key: String, value: Any)
key	String	"TAG"
value	Any
payload_data_0	Builtin.RawPointer	0xbb31490	0x0bb31490 -> 0x386e8020 (void *)0x386e7ff8: __NSCFString
payload_data_1	Builtin.RawPointer	0xbb805b0	0x0bb805b0
payload_data_2	Builtin.RawPointer	0xe0bb8058
instance_type	Any.Type	0x0000000001b1cd9c  (__NSCFString?)

[1]	(key: String, value: Any)
key	String	"SCALE"
value	Any
payload_data_0	Builtin.RawPointer	0x17e0e200	0x17e0e200 -> 0x386e8070 (void *)0x386e8084: __NSCFNumber
payload_data_1	Builtin.RawPointer	0x36d8c	0x00036d8c
payload_data_2	Builtin.RawPointer	0xbbb5ed0	0x0bbb5ed0
instance_type	Any.Type	0x0000000001b231a0  (__NSCFNumber?)

.. and this is production so I can't change the format of the Data object being stored in the SQLite blob field to something else.

So one thing you could do is convert the [String: JSON] to [String: Any]. Can you try this code? If it works, let's consider adding it to the library as a convenience:
extension JSON {
    var wrappedValue: Any {
        switch self {
        case let .string(string):
            return string
        case let .number(number):
            return number
        case let .boolean(boolean):
            return boolean
        case let .array(array):
            return array.map { $0.wrappedValue }
        case let .object(object):
            return object.mapValues { $0.wrappedValue }
        case .null:
            return NSNull()
        }
    }
}

extension Feature {
    var unyptedProperties: [String: Any]? {
        return properties?.mapValues { $0.wrappedValue }
    }
}

to use it, you'll change
let attribs: NSDictionary = feature.properties! as NSDictionary

to
let attribs: NSDictionary = feature.untypedProperties! as NSDictionary

Brilliant!  Thank you for being so responsive.
All looks good again.  Will also do some more testing with different geometry types.
Note there is a typo above - this is correct - says 'untyped' ..
extension Feature {
    var untypedProperties: [String: Any]? {
        return properties?.mapValues { $0.wrappedValue }
    }
}

Glad to hear it! I’ll look into adding this to the library in the next update.

@Tybion version 5.1 is now available and includes Feature.untypedProperties and JSON.untypedValue. Thanks for your help in identifying the need for these features!


Fix spacing for date checkbox in queue item

Related Issue or Background Info
https://app.zenhub.com/workspaces/simplereport-5ff8be8854ae8b000e378210/issues/cdcgov/prime-simplereport/682
Changes Proposed

style changes to bring queue item in line with designs

Additional Comments

changing top to margin-top in the checkbox improves the mobile view, but does space the desktop view differently. Screenshots of both are attached, I'm happy to switch from one to the other.

Screenshots / Demos
margin-top:

top:

existing view:

I'm just seeing this—Overall these changes look great but the checkbox looks like it shifts upwards when it moves to the right after being unchecked. Can keep it in-line w/ the input that appears?

Sorry Heather, I didn't see your comment before merging. I tried to keep it in line with the date box input, but it does mess with spacing on mobile - the checkbox gets pushed down further (that's what the second GIF is). I can add a mobile-specific rule to fix that in a separate PR.


How to get the complete error info when an exception is thrown

Hi Team,
When I use a python Requests library to consume the Gerrit API, I get the complete reason for the exception but while using pygerrit2 library, I don't get it.
Following is the way of how i use pygerrit2 in my code.
pygerrit2 code:
def _createBranch(self):
  from pygerrit2 import GerritRestAPI, Anonymous
  auth = Anonymous()
  rest = GerritRestAPI(url='https://gerrit.com', auth=auth)
  branchId = 'test-123'
  try:
      response = rest.put(
          f'/a/projects/testDev/branches/verified%2F{branchId}',
      )
      return response
  except RequestException as err:
    logging.error("Error: %s and response object is %s", err)
    return str(err)

Response:

409 Client Error: Conflict for url: https://test.gerrit.com/a/projects/testDev/branches/verified%2FUS-0000721

Python Request library:
def  _createBranch(self):
    import requests
    url = https://test.gerrit.com/a/projects/testDev/branches/verified%2Ftest-123
    response = requests.put(url)
    logging.info(f'The url {url} and response {response.text}')
    return response.text

Response:

Branch "refs/heads/verified/test-123" already exists

In the examples above, you could find that while using python Request library to contact Gerrit API, the exact reason for the error message can be obtained.
So, my question is how do I obtain the similar detail error message  using pygerrit2 library.

I guess it's because the library uses raise_for_statys which raises the exception with the message 409 Client Error.
If that's the case, I think you will see the same behaviour if you change your example code to:
def  _createBranch(self):
    import requests
    url = https://test.gerrit.com/a/projects/testDev/branches/verified%2Ftest-123
    response = requests.put(url)
    response.raise_for_status().    # << This line added
    logging.info(f'The url {url} and response {response.text}')
    return response.text

And per this answer on stack overflow the exception object that gets raised includes the response object, so you should be able to use that to get to the actual message.


runTimer doesn't work on lua

Describe your bug here.
I've had some issues with timers in the lua api, I tried using runTimer but it just errors everytime and I can't find any way to fix it
Command Prompt/Terminal logs (if existing)
None

Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
No

what errors?

what errors?

Theres a few different things I'm assuming he could be referring to:

maybe he thinks runTimer should pause the code?? (if this is what is being referred to in the issue, it doesn't.)
maybe he doesnt understand the way that runTimer works,
basically you assign a tag to the timer, and then when the timer ends, the onTimerEnded function is called, it has a variable for the tags. Just check if that variable == the tag you want.

its actually onTimerCompleted not onTimerEnded

its actually onTimerCompleted not onTimerEnded

Yes, sorry.

what errors?

it thinks that "runTimer" isn't a function, and yes I am using onTimerCompleted. do i need to send a code snippet

what errors?

Theres a few different things I'm assuming he could be referring to:

maybe he thinks runTimer should pause the code?? (if this is what is being referred to in the issue, it doesn't.)
maybe he doesnt understand the way that runTimer works,
basically you assign a tag to the timer, and then when the timer ends, the onTimerEnded function is called, it has a variable for the tags. Just check if that variable == the tag you want.

i know that runTimer doesn't instantly pause the code, and I know you're supposed to assign a tag, the amount of time, and the number of loops, and I also use onTimerCompleted with the correct tag, it just thinks that runTimer isn't a function for some reason


You can add openrouter.ai

You can add https://openrouter.ai/

@seoeaa Thanks for the suggestion. We'll look into it.

openrouter.ai is not explicitly an LLM. also I think openrouter could confuse users.I don't see any clear benefits of adding them. Or you can create them on your own without integrating them into this.
Just a suggestion.

I don't think integrating openrouter is valueless because many enterprise purchase openrouter as their uniform LLM backends. AWS Bedrock, Groq and Hugging Face Inference API are also not explicitly LLMs.


Update new feature in use-network-policies.md

Purpose: As network policy can be modified now, change the relative parts in this article.

It will reimage + upgrade nodes on VMSS level. (I describe it as "reprovision" in the article)

@MGoedtel

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Closed as most of this article has been re-written.


Location problem

Today getting location problem,  I enter a city for example Berlin Germany, I am getting results in UK, and other Countries, but not Germany

Thanks a lot for reporting! Yes Grindr does return people from hundreds / thousands miles away with no apparent reason.

Your welcome but there are none from Wurzburg my tablet and phone app  receive Germany,  or Berlin where I set it,  but your app is having problems ?  I tried three computers today.
Date: Mon, 21 Mar 2016 21:27:14 -0700
From<EMAIL_ADDRESS>To<EMAIL_ADDRESS>CC<EMAIL_ADDRESS>Subject: Re: [fuckr] Location problem (#32)
Thanks a lot for reporting! Yes Grindr does return people from hundreds / thousands miles away with no apparent reason.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

It looks fixed now as for Berlin (without filter), the furthest profile (500th) is 130km away. It really looks like it was a Grindr server problem when you fetch 500 profiles from the server at a time like Fuckr.

GrindR had a popup saying this was a problem today.
On Mon, Mar 21, 2016 at 8:50 PM, obertscloud<EMAIL_ADDRESS>wrote:

Today getting location problem, I enter a city for example Berlin Germany,
I am getting results in UK, and other Countries, but not Germany
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/tomlandia/fuckr/issues/32

Closing but thanks again for reporting it fast 👍.


What is the preference key Value for the edrEarlyPreviewEnabled?

right now the edrEarlyPreviewEnabled can be configured from the command line using
sudo mdatp --edr --earlyPreview true can this flag be set on the json file too?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 44a290d4-3386-7f63-0324-4e6219b5dd24
Version Independent ID: 286954a7-372e-314f-ad9f-d12f5f55b79e
Content: Set preferences for Microsoft Defender ATP for Linux - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/linux-preferences.md
Product: w10
Technology: windows
GitHub Login: @Dansimp
Microsoft Alias: dansimp

Yes, because even with setting this to true, EDR does not appear to be enabled on Linux.  ATP is generally available, but does not appear to have all features available on all platforms just yet.  This needs to be made more clear.

@stevenoneill just to be sure we're on the same page, you've enabled the Preview mode on one of your Linux servers, right? And you're not seeing the server in Microsoft Defender Security Center, or what exactly is missing?
Please make sure you are running one of the following supported distros:

Microsoft Defender for Endpoint on Linux supports recent versions of the six most common Linux server distributions:
RHEL 7.2+
CentOS Linux 7.2+
Ubuntu 16 LTS, or higher LTS
SLES 12+
Debian 9+
Oracle Linux 7.2

@stevenoneill @annerajb just to be sure we're on the same page, you've enabled the Preview mode on one of your Linux servers, right? And you're not seeing the server in Microsoft Defender Security Center, or what exactly is missing?
Please make sure you are running one of the following supported distros:

Microsoft Defender for Endpoint on Linux supports recent versions of the six most common Linux server distributions:
RHEL 7.2+
CentOS Linux 7.2+
Ubuntu 16 LTS, or higher LTS
SLES 12+
Debian 9+
Oracle Linux 7.2

@VLG17 We enable it.  We see it in the Security Center.
What is missing is the EDR piece of ATP.  EDR.
EDR is the telemetry coming in, correct?  There doesn't appear to be any event/telemetry data to search for for Linux server instances.  By contrast, there's a vast amount of data and events from Windows instances.  For example, looking for things under advanced hunting using Kusto queries.
Like, if Windows send events from the various Event Logs, I'd expect to see things like auditd info from a RHEL 7 instance.

@stevenoneill Keeping in mind the configuration is ok and you see it under Security Center, i would look further into troubleshooting the communication itself. You can try the steps described here. You could also simulate an attack to generate data, as described here.
We can help with documentation changes and updates, but technical issues, like the one you are describing, should be handled by support.
Circling back to the initial question, @annerajb i don't see any other way to enable EDR (in the public docs) other than the sudo command.

So it just became available 10 days ago according to this:
https://techcommunity.microsoft.com/t5/microsoft-defender-for-endpoint/edr-for-linux-is-now-available-in-public-preview/ba-p/1890536


Fix for #6897 - grouping by date might include files from previous week

Resolved / Related Issues
Items resolved / related issues by this PR.

Closes #6897

Details of Changes
Add details of changes here.

Fixed the number of days comparison.
If the difference is 7 then it was modified 8 days ago. If the difference is 14 then it was modified 15 days ago.
Therefore "This week" is difference of 6 days or less and "Last week" is difference of 13 or less (between 7 to 13 inclusive)

Validation
How did you test these changes?

[ ] Built and ran the app
[ ] Tested the changes for accessibility

@SHADOW-XIII thank you!


Add youtube site verification

This is the verification token for https://github.com/rust-community/team/issues/84

r? @aturon
(rust_highfive has picked a reviewer for you, use r? to override)


[New API] : Firebase API

Brief Description 🤓
Offers backend services including real-time databases, authentication, and cloud functions, useful for developing mobile and web applications.
@dinxsh, @dishamodi0910 assign me this issue under GSSOC'24
How will you develop it?🤩
I will use react
Firebase JavaScript SDK for interacting with Firebase services like Authentication, Firestore, and Realtime Database.
Firebase UI for pre-built UI components (optional) to simplify authentication flows
Deployment
None
Select the open source program you are contributing to
Other
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINES of this project.

Greetings @sreevidya-16🎀 ! , We are excited to have you dive into another issue with us!🚀
Your involvement in our project has been invaluable, and we're confident that your skills and insights will help us conquer this challenge😇.  Use command /gssoc24 to self assign the issue.  This issue represents an exciting opportunity for us to improve and enhance our project, and we are thrilled to have you on board.
We request you to follow CONTRIBUTING GUIDELINES.
Looking for your PR soon!
In case of any issues, you can contact us on Discord.❣

/gssoc24

Hey @sreevidya-16 ! I wanted to inform you that we have closed issue.Thank you for your understanding, and we look forward to your continued engagement with our repository🤗.
In case of any issues, you can contact us on Discord.
Thank you! ❣
Happy Coding! ✨
Will See you soon❣


Support for nesting namespaces

Closes https://github.com/larowlan/vite-plugin-twig-drupal/issues/31

Looks to be a linting fail here. Can you add a new test case for this?

Fixed lint and added test, initial PR was created right from github UI :)


3.1.0 vs 3.0.8 branch?

Found this link: https://www.openssl.org/policies/releasestrat.html
Version 3.1 will be supported until 2025-03-14
Version 3.0 will be supported until 2026-09-07 (LTS).

Looks like 3.0 is LTS branch, 3.0.8 was released a couple of days ago. Does that mean that 3.0.x releases will continue with patch number until support-end date e.g. 3.0.9, 3.0.10 etc?
Is there any benefit of switching to 3.1.x releases other than FIPS validation?

There was a recent blog post about theOpenSSL3.1 Release.

3.1 has additional performance fixes and some assembly code improvements.

Designating a release as LTS imposes a significant support burden on the project for many years to come. If every release was LTS it would negate the point of having LTS in the first place. According to our policies we are committed to designating a release as LTS at least every four years. So we should expect to have designated a new one before 2025-09-07.
Yes, there will be a 3.2. Release date has not yet been set but hopefully later this year. It has not currently been designated as the next LTS (and my personal guess is that it won't be).

I also expect some manner of support for the 3.1 FIPS 140-3 validation to be available.  Validations sunset after five years typically which is longer than 3.1 will be supported for (even if it were a LTS release).
As for what this will be, I've no idea.  The management committee is aware of this but haven't discussed it yet.


Radio buttons in overlays do not convey their role/state [Android]

The form controls that behave as radio buttons (only one option selected at a time) in the “Select your county”, “Gender identity”, “Age range”, “Race”, and “Ethnicity” overlays do not convey a role of radio or their selected state to TalkBack users.

Remediation Guidance
Use the accessibilityRole attribute to give the form group container a role of radiogroup and each radio button a role of radio. Use the accessibilityState attribute to convey the selected state of the currently selected button.
<View accessibilityRole='radiogroup'>
  <TouchableOpacity
    onPress={…}
    accessibilityRole='radio'
    accessibilityState={{selected: true}}
  >
    <Text>0-17</Text>
  </TouchableOpacity>
  <TouchableOpacity
    onPress={…}
    accessibilityRole='radio'
    accessibilityState={{selected: false}}
  >
    <Text>18-34</Text>
  </TouchableOpacity>
  {/* Rest of options */}
</View>

@jonnyjames This should be address now.

@floridemai I am confirming this issue is fixed. Closing this ticket.


Fix the jar-dependency issue

as it's fix in other jar dependant plugins, aka by binding this dependency to the last one working properly.

lgtm


NumberingPart.new  NotImplementedError

the simple code
from docx import Document

doc = Document(r"xxxx.docx")
print(doc.part.numbering_part)

The following issues have occurred
Traceback (most recent call last):
  File "x.py", line 4, in <module>
    print(doc.part.numbering_part)
  File "\mars-win-amd64-python3.9\lib\site-packages\docx\shared.py", line 242, in __get__
    value = self._fget(obj)
  File "\mars-win-amd64-python3.9\lib\site-packages\docx\parts\document.py", line 99, in numbering_part
    numbering_part = NumberingPart.new()
  File "\mars-win-amd64-python3.9\lib\site-packages\docx\parts\numbering.py", line 15, in new
    raise NotImplementedError
NotImplementedError

After investigation, it was found that the 'NumberingPart. new()' used in the 'numbing_part' did not implement the function.
The following is the code used by 'NumberingPart.new()'

class NumberingPart(XmlPart):
    """Proxy for the numbering.xml part containing numbering definitions for a document
    or glossary."""

    @classmethod
    def new(cls):
        """Return newly created empty numbering part, containing only the root
        ``<w:numbering>`` element."""
        raise NotImplementedError

I have the same problem.


[Bug]: 500 server error on a collection not found

What happened?
Fetching a collection by name via the HTTP API fails with a 500 Internal Server Error. Should be a 404.
Versions
Chroma 0.4.6, OSX.
Relevant log output
$ curl http://localhost:8000/api/v1/collections/foobar -v
*   Trying <IP_ADDRESS>:8000...
* Connected to localhost (<IP_ADDRESS>) port 8000 (#0)
> GET /api/v1/collections/foobar HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/7.88.1
> Accept: */*
>
< HTTP/1.1 500 Internal Server Error
< date: Thu, 27 Jul 2023 19:34:19 GMT
< server: uvicorn
< content-length: 59
< content-type: application/json
<
* Connection #0 to host localhost left intact
{"error":"ValueError('Collection foobar does not exist.')"}

Correct , even
try
Except ValueError as e
does not work , only (Exception as e) does

@dblock I have a PR coming for this:
curl http://localhost:8000/api/v1/collections/foobar -v
*   Trying <IP_ADDRESS>:8000...
* Connected to localhost (<IP_ADDRESS>) port 8000 (#0)
> GET /api/v1/collections/foobar HTTP/1.1
> Host: localhost:8000
> User-Agent: curl/8.1.2
> Accept: */*
>
< HTTP/1.1 404 Not Found
< date: Mon, 07 Aug 2023 07:00:18 GMT
< server: uvicorn
< content-length: 76
< content-type: application/json
<
* Connection #0 to host localhost left intact
{"error":"CollectionNotFound","message":"Collection foobar does not exist."}

@tazarov did this commit land somewhere?

@jeffchuber, I think this PR will resolve the issue - https://github.com/chroma-core/chroma/pull/991. I'll close my PR and do any additional enhancements I did there once #991 gets merged.

Closing following #991 merge. If this problem persists, please feel free to open another issue!


docs: fix handful of typos and content improvements

fixed an event listener that wasn't getting removed
don't register Sentry locally
add toggle right details
fix default tooltip size
change icons to use cds-layout over old grid
fix layout issue with code styling that was wrong font size
added note to v5 release notes about Angular 11 support

closes #4706
closes #4488
closes #5709
PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] If applicable, have a visual design approval

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] clarity.design website / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@gnomeontherun Merged it in order to get into the relaese.


Issues found on Mobile version

The right-side button on the top of the page, leads to the navbar as if you were editing a profile and when you finally click to 'Edit' it leads you to a random account.
https://i.imgur.com/7UCWevI.png
Also, the middle button I think it should say something like "Users/Members" as in every other section. If I am wrong, please forgive me.
https://i.imgur.com/2O76ri4.png

@AngellitoX you are aware you can simply paste the image here right ;) Much easier :D

Yes @Luceos, sorry about that. I was in my mobile last night and it didnt let me to past them :(

What's the reason for closing this?

What? I don't remember closing this at all!

I can't reproduce on the latest version. Feel free to reopen if you still experience this.
Please include the platform, browser and browser version and whether you can replicate on other browsers.


Support for Bean Validation 3

Bean Validation 3 has moved the package of the annotations from javax.validation to jakarta.validation. The generated code with option bean-validation: true is no longer compatible with the current version. The same problem occurs also for the spring processor which no longer works with Spring Boot 3.

already implemented https://github.com/openapi-processor/openapi-processor-spring/issues/152 ! :-)
but not yet released

great, also just found the issue. Thanks!