tokenizer nil pointer dereference error with specific input text

I am getting a nil pointer error with specific texts, I created a test at https://github.com/alkuma/tokenizerissue to demonstrate the issue.
There are two strings that are being embedded, the first one goes thru, but the second one fails.
Here is the output of the program:
/usr/local/go/bin/go tool test2json -t /home/alok/.cache/JetBrains/GoLand2024.2/tmp/GoLand/___1TestEmbedding_in_tokenizerissue.test -test.v=test2json -test.paniconexit0 -test.run ^\QTestEmbedding\E$
2024/09/17 15:19:17 INFO: CachedDir="/home/alok/.cache/tokenizer"
=== RUN   TestEmbedding
AS YOU LIKE IT
DRAMATIS PERSONAE
DUKE SENIOR     living in banishment.
DUKE FREDERICK  his brother, an usurper of his dominions.
AMIENS  | |  lords attending on the banished duke. JAQUES       |
LE BEAU a courtier attending upon Frederick.
CHARLES wrestler to Frederick.
OLIVER          | | JAQUES (JAQUES DE BOYS:)    |  sons of Sir Rowland de Boys. | ORLANDO               |
ADAM    | |  servants to Oliver. DENNIS |
TOUCHSTONE      a clown.
SIR OLIVER MARTEXT      a vicar.
CORIN   |
|  shepherds.
SILVIUS |
WILLIAM a country fellow in love with Audrey.
A person representing HYMEN. (HYMEN:)
ROSALIND        daughter to the banished duke.
CELIA   daughter to Frederick.
673
AS YOU LIKE IT
DRAMATIS PERSONAE
DUKE SENIOR     living in banishment.
DUKE FREDERICK  his brother, an usurper of his dominions.
AMIENS  | |  lords attending on the banished duke. JAQUES       |
LE BEAU a courtier attending upon Frederick.
CHARLES wrestler to Frederick.
OLIVER          | | JAQUES (JAQUES DE BOYS:)    |  sons of Sir Rowland de Boys. | ORLANDO               |
ADAM    | |  servants to Oliver. DENNIS |
TOUCHSTONE      a clown.
SIR OLIVER MARTEXT      a vicar.
CORIN   |
|  shepherds.
SILVIUS |
WILLIAM a country fellow in love with Audrey.
A person representing HYMEN. (HYMEN:)
ROSALIND        daughter to the banished duke.

DUKE FREDERICK  his brother, an usurper of his dominions.
AMIENS  | |  lords attending on the banished duke. JAQUES       |
LE BEAU a courtier attending upon Frederick.
CHARLES wrestler to Frederick.
OLIVER          | | JAQUES (JAQUES DE BOYS:)    |  sons of Sir Rowland de Boys. | ORLANDO               |
ADAM    | |  servants to Oliver. DENNIS |
TOUCHSTONE      a clown.
SIR OLIVER MARTEXT      a vicar.
CORIN   |
|  shepherds.
SILVIUS |
WILLIAM a country fellow in love with Audrey.
A person representing HYMEN. (HYMEN:)
ROSALIND        daughter to the banished duke.
CELIA   daughter to Frederick.
PHEBE   a shepherdess.
AUDREY  a country wench.
Lords, pages, and attendants, &c. (Forester:) (A Lord:) (First Lord:) (Second Lord:) (First Page:) (Second Page:)
835
AS YOU LIKE IT
DRAMATIS PERSONAE
DUKE SENIOR     living in banishment.
DUKE FREDERICK  his brother, an usurper of his dominions.
AMIENS  | |  lords attending on the banished duke. JAQUES       |
LE BEAU a courtier attending upon Frederick.
CHARLES wrestler to Frederick.
OLIVER          | | JAQUES (JAQUES DE BOYS:)    |  sons of Sir Rowland de Boys. | ORLANDO               |
ADAM    | |  servants to Oliver. DENNIS |
TOUCHSTONE      a clown.
SIR OLIVER MARTEXT      a vicar.
CORIN   |
|  shepherds.
SILVIUS |
WILLIAM a country fellow in love with Audrey.
A person representing HYMEN. (HYMEN:)
ROSALIND        daughter to the banished duke.
CELIA   daughter to Frederick.
PHEBE   a shepherdess.
AUDREY  a country wench.
Lords, pages, and attendants, &c. (Forester:) (A Lord:) (First Lord:) (Second Lord:) (First Page:) (Second Page:)

835
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x730074]

goroutine 35 [running]:
github.com/sugarme/tokenizer.(*Encoding).GetIds(...)
	/path/to/go/pkg/mod/github.com/sugarme/tokenizer@v0.2.3-0.20230829214935-448e79b1ed65/encoding.go:215
github.com/sugarme/tokenizer.TruncateEncodings(0xc0009d2d00, 0x0, 0xc0009d2c30?)
	/path/to/go/pkg/mod/github.com/sugarme/tokenizer@v0.2.3-0.20230829214935-448e79b1ed65/util.go:108 +0x54
github.com/sugarme/tokenizer.(*Tokenizer).PostProcess(0xc000465680, 0xc0009d2d00?, 0x0?, 0x1)
	/path/to/go/pkg/mod/github.com/sugarme/tokenizer@v0.2.3-0.20230829214935-448e79b1ed65/tokenizer.go:602 +0xe5
github.com/sugarme/tokenizer.(*Tokenizer).Encode(0xc000465680, {0x7a1e20, 0xc0003121e0}, 0x1)
	/path/to/go/pkg/mod/github.com/sugarme/tokenizer@v0.2.3-0.20230829214935-448e79b1ed65/tokenizer.go:464 +0x2e5
github.com/sugarme/tokenizer.(*Tokenizer).EncodeBatch.func1(0x0)
	/path/to/go/pkg/mod/github.com/sugarme/tokenizer@v0.2.3-0.20230829214935-448e79b1ed65/tokenizer.go:647 +0x90
created by github.com/sugarme/tokenizer.(*Tokenizer).EncodeBatch in goroutine 34
	/path/to/go/pkg/mod/github.com/sugarme/tokenizer@v0.2.3-0.20230829214935-448e79b1ed65/tokenizer.go:644 +0xf5

Process finished with the exit code 1

The first chunk has 634 characters and the embedding is successful. The next chunk has 835 characters (ie the first 634 characters and an additional 201 characters beyond that) and it fails with the tokenizer nil pointer dereference error.
Has anybody faced this before, is it a known issue, and if so is there a way to work around it?
Please let me know if any additional information is required.
To execute the tests, follow these steps

git clone the https://github.com/alkuma/tokenizerissue repository
set the value of ONNX_PATH to the correct value
simply run the test called TestEmbedding which is present in the file embed_test.go and you should get the error

Since there was a similar issue reported (and closed via a code change / PR) on the tokenizer side I just forked both tokenizer and fastemebed-go and published the latest master / main branch and used them as dependency, and the error is gone.
Perhaps all that's needed to be done is to publish the latest versions of both?

@alkuma, I'd recommend you keep your project dependent on your fork. It gives you the flexibility to add any changes.
As I can see, both fastembed-go and https://github.com/sugarme/tokenizer aren't under active maintenance.


Issue/40/tdc2gatewaytest

Hi,
This is for paper in doc/

Great, thanks Chun-Hao. I have fixed the conflicts and will send you a PR from my personal fork.
Two things:

You should have your editor cause line breaks every 72 characters, to prevent the creation of very long lines - in many places you have whole paragraphs on a single line, which makes it hard for git to merge edits together from multiple authors.

I get a missing file error:

Error: File `summary_posterior_summary_newWhiten.png' not found.

Great if you can git add and commit that! Thanks :-)

@drphilmarshall,
I've finished paper version 1.
Please take a look

Hey @chto, nice job! I have a couple of suggestions, see what you think:

In the appendix, could you show the log prior/lhood.posteriors from the two whitening methods on the same axes, with different linestyles? I think I'd then like to see the corresponding prior, lhood and posterior on a linear scale, next to the log scale plots. They show different things, you see...

All figures need captions!

I'm happy to go through and edit the text as well - would that be OK with you?

Thanks @drphilmarshall. I'll revise the document.
I'm happy to go through and edit the text as well - would that be OK with you?  Yep.

Cool! Ill take a look over the break. When you are happy with your text,
you should email a pdf to Steve. Well done again!

@drphilmarshall:
I am working on this
In the appendix, could you show the log prior/lhood.posteriors from the two whitening methods on the same axes, with different linestyles? I think I'd then like to see the corresponding prior, lhood and posterior on a linear scale, next to the log scale plots. They show different things, you see...
But I find that some of the figures has very different value. So, if you plot them in the same figure, then, you can not see the structure anymore.
For example, for gateway 2 data, whitening method 1 gives likelihood on the order of 10^3, but whitening method 2 gives -10^2

Hi @chto ! Happy New Year :-)
Hmm. Regarding scales, I see the problem. I guess the plot you can make that illustrates the difference between the two whitening methods is the linear scale prior/posterior plot. Here, you would normalize all the distributions before plotting, so the differences in absolute value go away. The likelihood is tricky, though. You could normalize them independently just for plotting purposes, but then in the legend quote the normalization factor, known as the Evidence. Actually, you should just quote the difference in evidence, next to the lower evidence method. The legend would look something like:
Whitening method 1
Whitening method 2, $\Delta \logE = -23$
The point is that we should choose the method that has higher evidence. The evidence is also known as the marginalized likelihood: in this case it is dominated by goodness of fit, so that higher evidence corresponds to better fit.
Will you have time to make these plots? Or should I just tidy up the text and send the TDC Evil team what you have here?

Hi @drphilmarshall,
Happy New Year too.
I know your point. But I am preparing for Risa's project and might not have enough time to make those plots.  Could you tidy up the text and send it to TDC Evil team? Thanks.

Will do. Thanks, @chto - and good luck with the new project!


Couldn't fetch network config: 100: Key not found

I am starting flannel(v0.11.0) using this command,the etcd is v3:
/root/flanneld -etcd-endpoints=https://<IP_ADDRESS>:2379,https://<IP_ADDRESS>:2379,https://<IP_ADDRESS>:2379 -etcd-prefix=/kube-centos/network -etcd-cafile=/etc/kubernetes/ssl/ca.pem -etcd-certfile=/etc/kubernetes/ssl/kubernetes.pem -etcd-keyfile=/etc/kubernetes/ssl/kubernetes-key.pem
Expected Behavior
no error,and flannel run.
Current Behavior
[root@iZuf63refzweg1d9dh94t8Z ~]# /root/flanneld -etcd-endpoints=https://<IP_ADDRESS>:2379,https://<IP_ADDRESS>:2379,https://<IP_ADDRESS>:2379 -etcd-prefix=/kube-centos/network -etcd-cafile=/etc/kubernetes/ssl/ca.pem -etcd-certfile=/etc/kubernetes/ssl/kubernetes.pem -etcd-keyfile=/etc/kubernetes/ssl/kubernetes-key.pem
I0908 20:27:17.652749    2331 main.go:514] Determining IP address of default interface
I0908 20:27:17.653154    2331 main.go:527] Using interface with name eth0 and address <IP_ADDRESS>
I0908 20:27:17.653176    2331 main.go:544] Defaulting external address to interface address (<IP_ADDRESS>)
2019-09-08 20:27:17.653903 I | warning: ignoring ServerName for user-provided CA for backwards compatibility is deprecated
I0908 20:27:17.653968    2331 main.go:244] Created subnet manager: Etcd Local Manager with Previous Subnet: None
I0908 20:27:17.653975    2331 main.go:247] Installing signal handlers
E0908 20:27:17.671602    2331 main.go:382] Couldn't fetch network config: 100: Key not found (/kube-centos) [22]
timed out
E0908 20:27:18.680096    2331 main.go:382] Couldn't fetch network config: 100: Key not found (/kube-centos) [22]
timed out
E0908 20:27:19.688339    2331 main.go:382] Couldn't fetch network config: 100: Key not found (/kube-centos) [22]

Possible Solution
Is flannel do not support etcd v3? Is there any other replace?The kubernetes recommand etcd v3
Your Environment

Flannel version:v0.11.0
Backend used (e.g. vxlan or udp):vxlan
Etcd version:  3.3.13
Kubernetes version (if used):1.15.0
Operating System and version: CentOS 7.6
Link to your project (optional):

Use etcd v2 api to set the specified key and its value. DO NOT use v3.


Email + DOB error states: differently formatted errors

For email + DOB error cases, we have two different types of formatted errors. Is this ok? What do we want this to look like?

Also this number validation:


[ACS][Communication Messages] enrollment of automated patch

Description
Enrolling azure-communication-messages for automated patch release
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

/check-enforcer override


Paper Discussion 10a: Experimental Security Analysis of a Modern Automobile

Please leave your comments and discussion below.

Reviewer: Alvaro Albero
Review Type: Analytical
Problem Domain
Modern cars have multiple digital systems for control and monitorization, they are no longer just mechanical devices. These systems allow different advantages and performance, many times have been introduced for increasing safety such as ABS, but at the same time they can be a security leak from where attackers can take control or destabilize the system.
Main Contributions
The authors perform an in-depth analysis of a modern automobile that makes use of digital systems to show how weak their security is, and the different actions that an attacker with control of the car could attempt. They perform several experiments in the lab and in road tests and they also discuss challenges in addressing these vulnerabilities in the current ecosystem
Questions

Is not implementing the standards that are supposed to be followed (CAN in this case), and probably advertised as followed, some kind of crime or fault? Is this a common practice? I thought that when you say you follow a standard there was a way to check that you are really following it.
Is the OBD connector the only way to perform the attacks? Can the attacks keep happening once the device is disconnected form this connector?
They mention that in some cases it was an “easy” task, but to me it seems they did a lot of work, how long did it take them to compromise the security of the system?

Critiques

I found the paper very interesting and really well explained. I believe every section has a reason and it drives you to the next one, explaining the concepts you need and then using them in the following section. From the background, to explaining the CAN bus as the key component, to showing the vulnerabilities of the standard, compromising the security of every component and doing a road test. Maybe after the damage caused by single components, the multi component interactions seems a bit weak, as we would expect more harmful attacks and they actually just play a bit with the functionality.
I understand the control they can take of the system is huge and it can perfectly cause severe accidents. At the same time, they mention that is very easy to take control of it, the security is poor. The thing here is, it seems you need physical access to the OBD connector at some point, and even constant access to perform many of the attacks. This seems complicated. We have seen in class IoT attacks counted by the thousands/millions, in this paper they mention that the security of the car is really low too, but how many attacks have actually been performed? I have barely heard of any and there are millions of cars running out there. So I think that even if the security is that poor, the lack of these attacks shows that is not that easy to perform them due to the requirements of constant physical access.

Reviewer: Akinori Kahata
Review type: Critical

The problem being solved.

Recently, automobiles become a kind of gathering of computers. Each car consists of many Electric Control Units (ECU) and Control area networks, and these devices support not only informational function but also some safety functions. Unfortunately, the security level of those components is low; then, it is essential to clarify what is the problem of automobiles' security.

The main contributions.

The researchers did experiments of cyberattacks under three occasions; bench, stationary car, and on the road. The research focuses on the device level, component level and multi-component level. As a result of the experiments, the researchers proved that the recent automobiles car has security problems, adversaries can affect automobiles’ function by some attack such as sending malicious data.

Questions.

Although many car companies use the standard, I guess that the real structure of cars is different from each other. Generally speaking, how much ratio is common between car companies about the components’ list table 1 and the packet structure in figure 5?
I cannot understand well that if manual overrides are not permitted at page 10, what is happened when an adversary’s attack and manual control happen simultaneously? Which is prioritized? In my understanding, car industries prioritize the manual maneuver.

Critiques.

The researchers assumed that adversaries could connect with telematics systems by some method. But I think that making connection with cars is one of most important point of car hacking. If the researches discuss the security issues, I think they should consider telecommunication issues. Of course, it is very important the evaluation of component level security, but car safety function is so complicated, then I think real attack scenario is very important.

Reviewer: Graham Schock
Review Type: Comprehensive
Problem Being Solved
Cars have evolved a tremendous amount within a very short period of time. They have gone from old mechanical beasts to having new modern computers. However, this new technology has left our automobiles complex and vulnerable to a wide variety of attacks. To make matters more complex soon cars will be open to the entire infrastructure and other vehicles. Sadly, not a lot of research has been done in this topic which allows these attacks to be even more potent and dangerous.
Contributions
The goal of this paper is to illuminate the dark cave of automobile security. In order to accomplish this the paper uses experiments on a wide variety of car components to show that they can be attacked and that the car’s security is not strong enough to protect against an attack. The paper also looks at the network of components as a whole and shows there are some systemic vulnerabilities. The paper then goes on to determine what underlying mechanisms are the reasons for these types of vulnerabilities.
Questions

It seems like an easy way to protect the network and the Electronic Control Unit is to change the challenge and response keys from 16 bits to something like 32. What would the trade offs of something like this be? How would it affect performance?
I think understanding the CAN packet structure is the essence of understanding automobile network security. The paper breaks down the CAN packet into a neat diagram. What do the different components of the packets mean? Why is it different from other network packets? What is “CRC”?
Are there ethical implications of making the information public? The paper essentially gives the architectures and the tools necessary in order to seriously hurt people in their vehicles.

Reviewer: Sean McBride
Review Type: Comprehension Review
Problem Being Solved:
Modern cars are powered by numerous embedded systems connected by multiple buses and standard interfaces. Many of these Electronic Control Units (ECUs) have been added over the years to improve energy efficiency, reduce pollution, and provide driver assistive technologies to improve road safety. This paper seeks to provide the first-ever hands-on penetration test of the numerous embedded systems that compose a modern car. It seeks to example the ways that these systems reduce safety once an adversary is able to gain access to a car's internal bus.
Main Contributions:

Demonstrates that cars circa 2009 have not been designed with security in mind. Every system is vulnerable and can be fatally exploited to harm the physical world. The few security controls were easily defeated, including bridging separate buses with different security postures. Numerous regulatory requirements were detailed as not being followed in practice.
Develops CarShark, a custom bus analyzer and packet injection tool, that is capable of executing numerous exploits over the CAN bus and standardized OBD-II port.
Demonstrated and filmed exploits raised in an garage and live with a human driver at an abandoned airport to raise public awareness of the danger of the status quo in cars.

Questions:

Has there been improvement from this pitifully low baseline over the past decade?
What is the appropriate social tradeoff between a more locked down system that provides additional security controls and the social expectations of "right to repair" around cars?
Why haven't more people died because of this? This paper makes it sound trivially easy to murder someone with their car and wipe all evidence? If that's the case, why hasn't Putin been murdering dissidents with this? Why hasn't Al-Qaeda been hacking Automatic accounts use auto-attacks as terrorism?

Reviewer: Sam Hanna
Review Type: Comprehension
Problem Being Solved:
This paper talks about the increase in the connectivity of automobiles and the security implications of this. Cars are more connected than ever and the Electronic Control Units (ECUs) connect vital parts of the automobile functions. Unfortunately, the rise of connectedness does not come with a rise in security which leaves these cars vulnerable to attack.
Important Areas:
The focus of this paper was on the ability to take control of various automobile functions remotely. They utilized the Controller Area Network (CAN) which communicated between the electronic components of the vehicle. They also created a tool similar to Wireshark called Carshark, to analyze these CAN packet and inject more packets. They tested the car's response to different stimuli in three environments: stationary, on jacks, and on the road. They were able to effectively control the car in a variety of ways with limited difficulty.
Questions:

If there are access control standards, why can companies get away with not using/securing them? This seems like the very least they can do considering the possible threats that are posed.
They used the CAN and OBD-II connector to facilitate these attacks, is it reasonable to assume that an attacker could do the same? They mentioned that disconnecting the connector would stop any attack, would there be a way to assure that an attacker would be able to keep it connected, during the scope of an attack?
They don’t talk about what type of cars they tested, they say they tested two cars, but do not give the company, make or model. I understand this is to preserve the safety of the cars, but are these just two unsecured companies/cars? Is there a difference in the different companies in their security, especially in compliance with the access control?

Reviewer: Lily Shpak
Review Type: Comprehension
Problem Being Solved
This paper attempts to expose the lack of security in embedded systems in automobiles. Cars are becoming increasingly more computerized and most of these computerized components do not have much security. This leads to vulnerabilities that could hurt the car or even worse, the people in the car.
Main Contributions
The authors of this paper note how they avoid the standard threat model, instead they focus on what attacks could happen if the attack already has access to the system. They tested electrical components, such as the HVAC system, of a car to assess potential threats.
Questions

The authors mention that they stay away from the standard threat model, why do they do this? I think they show how an attacker gets into the system initially.
They explain their experiment and how they went about testing but it seems they do very little to explain a solution. What would a solution be to these threats?
There seems to be a lot of components on a car that work together, how do they test components that rely on other components to not be compromised?

Reviewer: Niko Reveliotis
Review Type: Critical
Problem Being Solved
More and more vehicles are relying on electronic control units (ECUs) to control different parts of the vehicle. Although the use of ECUs have aided the development of many safety systems, this paper outlines the security flaws of these systems through multiple tests. These flaws allow malicious code to drastically affect the operation of the vehicle; one created attack even has the ability to delete itself post-attack to make detection more difficult.
On top of this, the attack surface is being broadened wirelessly for vehicles as more communication networks are being created for vehicle to communicate with other vehicles (V2V) or infrastructure (V2X). In terms of physical connections, the Onboard Diagnostics Port (OBDII) and media players also open more attack vectors as their capabilities are broadened (ex: app stores for media players).
Main Contributions

Multiple vehicular attacks to demonstrate the vulnerabilities of their underlying systems
Evaluation of "the security properties of each of the key components within our cars, and we analyze the security properties of the underlying network substrate"
Carshark Tool: "a custom CAN bus analyzer and packet injection tool"

Three Questions

Are there incredibly strict laws regarding messing with the software of a vehicle (as a mechanic)? I understand that if a mechanic intentionally breaks a part of the vehicle there are strict penalties, but has the law caught up with the software yet or is it implied?
Remember when VW had their diesel engine scandal with their emissions? Many of the attacks relate to a single victim in this paper. But would it be possible for a rival company to push a malicious program onto one of the future communication networks of a competitor (V2V / V2X) which would mess with their emissions? removes tinfoil hat

Would adding addressing to CAN be logistically possible? Would addressing be able to remove some sniffing attacks by not broadcasting the packets all nodes? Could it also mitigate attacks by creating a "whitelist of valid senders/ECUs" which can send valid controls only to certain recipients/ECUs.

Three Critiques

Although they state the reason for not identifying the two vehicles tested on (of same make and model), I believe the reason provided is pretty weak. This is a bit nit-picky, but knowing which specific vehicle this was tested on could paint a better picture of the breadth of flawed vehicles. By this, what if the vehicle was a common Toyota/BMW which leverages similar infrastructure between many models vs a "no-name" brand which wouldn't relate to nearly as many vehicles on the road today. The scope of which vehicles are affected by their specific attacks isn't outlined clearly here. They could be testing on the easiest and least-common target for all we know.
The paper talks about the ability to reflash ECUs by brute-force within 7.5 days (or 3.5 if you physically remove it). They discuss this ability as a feasible attack when the average American uses their car for ~1 hour a day. How would you even have the ability to reflash the ECU unless someone is leaving their vehicle in an insecure location for nearly a week? I feel this vector of attack is not nearly as serious unless you're someone like Floyd "Money" Mayweather with a spare Bugatti sitting in your garage for extended periods of time. But likely, this garage would be incredibly secure, which wouldn't even allow for an attacker to gain physical access to the vehicle anyway.

In the case where they begin reflashing the ECU while the vehicle is moving, the attacker would need to maintain connection to the vehicle. Either by being nearby and accessing the vehicle remotely or by a physical device being attached to the vehicle, which for the same flaw as above would require access to the vehicle in an insecure location.

Most of these vehicular attacks require specific work to one vehicle (getting a connection, sniffing packets, flashing ECUs, etc). I feel until we have a V2V or V2X network between these vehicles, the risk of attack isn't significantly high unless you're a target. I believe that this paper serves an important purpose in explaining the risks these vehicles have currently, and how putting them on a network will exacerbate the issues to more vehicles. But as of right now, the risk of someone attacking the vehicle parked in your driveway is very low.

Reviewer: Huachuan Wang
Review Type: Comprehension
Overview
This paper experimentally evaluates the safety issues on a modern automobile and demonstrate the fragility of the underlying system structure. It also demonstrates that an attacker who is able to infiltrate virtually any Electronic Control Unit (ECU) can leverage this ability to completely circumvent a broad array of safety-critical systems. This paper also presents composite attacks that leverage individual weaknesses, including an attack that embeds malicious code in a car’s telematics unit and completely erase any evidence of its presence after a crash.
Contribution
This paper has present an empirical approach and provides a unique perspective to reflect on the actual vulnerabilities of modern cars as they are built and deployed today. This paper has illustrated the findings and addressed the challenges in addressing them, these findings include external damage, ease of attack, enforced access control and attack amplification.
Questions

This paper mentioned that many of the vulnerabilities are from weak or unenforced protections of the diagnostic and refreshing services. The core problem is the lack of access control for the use of these services. Could the improvement of the security of the CAN protocol help with this situation?

Why detection and correction of anomalies are better than prevention and locking down of capabilities for the cyber-physical system.

Reviewer: Ryan Fisk
Review Type: Critical
Problem:
Modern vehicles contain a lot of IoT technology and use it in unique and in most cases safety-preserving ways. However, the increase of digital technology in automobiles creates many new safety problems even though the systems themselves are designed to keep a driver and passengers safe. Many of the systems are very vulnerable to malicious actors and the consequences of these systems failing can be potentially life-threatening. This paper tests the current security features of vehicle systems in lab and flied conditions to show the problems that these systems can cause.
Contribution:
This paper tested the individual components of a IoT enabled car in a lab as well as the whole system on the road. The authors thoroughly discuss the security flaws with each system, including the network these devices use to communicate with each other. The authors present the security flaws for each individual component, allowing for specific analysis of each component.
Questions:

Why do the ECU's on a car need to be independent?

Would a processing unit on the car that coordinated and monitored the ECU's fix any of the problems the paper presents?

Are there systems on a car that an attacker can only access physically (i.e. with the OBD-II port) or are all of these systems accessible wirelessly?

Critiques

In their research, the authors say they purchased third-party ECU's when necessary to facilitate their research but doesn't say which ones they used or who those third parties were. Is it possible that these replacement ECU's have different vulnerabilities than the car's native ones.

The paper presents the experiments as a general look at how digital devices can be compromised in automobiles, however not all of the components and protocols are standardized and different companies use different devices. Since the paper used two cars of the same make a model, I'm not sure if this is a totally accurate look at the security of these devices in a general sense.


[oadp-1.3] OADP-3723: CVE-2023-45288, update x/net

Why the changes were made
See issue OADP-3723
How to test the changes made
Double check me please
10044  go get golang.org/x/net
10045  go mod tidy
10046  go mod tidy
Seems unit tests are failing on my operator-sdk version?

/retest

/retest


Shutdown server and send info when an incompatible server is found

This checks if the installed server type and version is compatible with the plugin and if not sends some informative messages regarding the situation (by trying to detect if it's an outdated paper version or a non-paper one) and shuts down the server so that it's not possible to be run under a false sense of security.
Currently the error that gets send when the event wasn't found seems to be rather cryptic to end users, hence this change.

I think shutting down the server is a bit overkill, even though security is not guaranteed with an old version. I think a message is enough.

No it is not over kill. Don't take security lightly.

Great, thanks :)


add support for role

Signed-off-by: Victor Vieux<EMAIL_ADDRESS>

Can you add a more explicit commit message?

Is this changelog worthy? I added the impact label

closing for now, I need to add test before merging


Add "new" Nanna Svartz

Name: Nanna Svartz (Nordrest edition)
Webpage: https://ki.hors.se/17/5/biomedicum/
Coordinate: 59.34867/18.02778

Closed by #52


Feat/add extra message to slack

add an extra message to the slack report

Component Upgrade
Active Promotion
Pull Request Trigger
Pull Request Queue

Related issue link:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Android front camera inverted upside down

I'm facing with a really weird issue.
ZXing in my android mobile with front camera is inverted and thus i don't get the barcode to work. Instead, in iOS works perfectly.
I'm wondering if this is a possible bug with this component in Android version.
I would appreciate any advice.
Many thanks

I've the same problem using the samples of this repository.
Devices tested: Samsung Galaxy S7 Edge (marshmallow), Sumsung Galaxy Tab 4 (kitkat).
Thanks!

I am also having this issue with the 2.1.0 beta. Tested on Galaxy Note 3 running Lollipop.

Should be fixed in master now.


Update Developer Guide

Add 2 user stories and reorder them

Codecov Report

Merging #65 (e89dfa6) into master (b5b33e3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b33e3...e89dfa6. Read the comment docs.


BooleanExpEditor not made visible on ButtonClick from PropertyList

You click on the edit property button in the property list.

If the BooleanExpEditor was closed, the editor is shown. Fine.
If the BooleanExpEditor was minimized, the editor is not shown again. Not Fine.

Seen in v1.4.12

3a77638 fixes the issue
Version is now at 1.4.14


Feature Request: Preserve Date Created/Modified upon Convert

Is your feature request related to a problem? Please describe.
If I use Aves to batch-convert from JPEG to WebP on-device to save space for archival, the ordering of the Library gets all messed up because original file Date Created/Modified is changed and all the converted files jump to the top.
Describe the solution you'd like
An option to transfer/preserve these file attributes upon Convert.
Describe alternatives you've considered
Using another sort method (file name), but this is not available globally and also takes into account Library, significantly changing the sort layout.
Additional context
Niche for sure, but would smooth some rough edges for how I manage space on my wife's device.

Metadata date is transferred (if enabled in the conversion dialog). File date is out of scope and unreliable anyway. Use metadata.

Is there a way to address how this interferes with sort if file attributes are not transferred as now all the exported files are raised to the top of the list?

I think it's too late. You had to give it a metadata date before the transfer. In a context of multiple devices and decentralised storage, never rely on file date.


Gruntfile not found when dragging project folder into open window

I can only get this package to work if I open my project by cd-ing into the project directory and running the "atom" command. If I instead open a new Atom window and drag my project directory into it, I will get a "fatal error: unable to find local grunt" upon attempting to run a grunt command.

6.1 should solve this, but it's not yet up on apm (#26) so you have to update manually (download zip and replace in your packages folder)

I don't know much about developing these Atom plugins, but here's my theory after fiddling with the code for a few minutes: The plugin's initialization function, which caches the project path, runs when a new window is opened. If the user clicks on a file in the project directory or runs the "atom" command there, a window opens and the path is defined immediately. But when the user opens a blank new window, the path is not defined (how could it be? nothing is open). When the user drags a folder into the window or opens a project via the Project Manager extension, the project path is then defined, but Grunt Runner doesn't know this because it's not listening for the change.
So, basically, to get around this, Grunt Runner either needs to listen for changes to the project path or wait until the user attempts to use Grunt Runner to use the path (because it would be available then). For the latter approach, is it possible the package could just wait until the user tries to use the Run command to parse the gruntfile?

Duplicate of #10. Several issues cause Error loading Gruntfile: gruntfile not found


Unresolved alias $PWD/src/vscode-shim.ts during pnpm run build-agent-binaries on Windows

Hi,
I'm having difficulties with building agent binaries on Windows (for context: to reproduce Windows-related bug in our JetBrains plugin).
$ pnpm run build-agent-binaries

><EMAIL_ADDRESS>build-agent-binaries C:\Users\exigo\projects\cody\agent
> pnpm run build && cp dist/index.js dist/agent.js && pkg -t latest-linux-arm64,latest-linux-x64,latest-macos-arm64,latest-macos-x64,latest-win-x64 dist/agent.js --out-path ${AGENT_EXECUTABLE_TARGET_DIRECTORY:-dist}

><EMAIL_ADDRESS>build C:\Users\exigo\projects\cody\agent
> cd .. && pnpm build && cd agent && esbuild --sourcemap --bundle --outfile=dist/index.js --platform=node --log-level=warning --alias:vscode=$PWD/src/vscode-shim.ts src/index.ts

> @sourcegraph/cody@ build C:\Users\exigo\projects\cody
> tsc --build

X [ERROR] Could not resolve "$PWD/src/vscode-shim.ts" (originally "vscode")

    src/agent.ts:3:24:
      3 │ import * as vscode from 'vscode'
        ╵                         ~~~~~~~~

  The path "vscode" was remapped to "$PWD/src/vscode-shim.ts" using the alias feature, which then
  couldn't be resolved. Keep in mind that import path aliases are resolved in the current working
  directory.

  You can mark the path "$PWD/src/vscode-shim.ts" as external to exclude it from the bundle, which
  will remove this error.

X [ERROR] Could not resolve "$PWD/src/vscode-shim.ts" (originally "vscode")

    src/AgentTextDocument.ts:1:24:
      1 │ import * as vscode from 'vscode'
        ╵                         ~~~~~~~~

  The path "vscode" was remapped to "$PWD/src/vscode-shim.ts" using the alias feature, which then
  couldn't be resolved. Keep in mind that import path aliases are resolved in the current working
  directory.

  You can mark the path "$PWD/src/vscode-shim.ts" as external to exclude it from the bundle, which
  will remove this error.

X [ERROR] Could not resolve "$PWD/src/vscode-shim.ts" (originally "vscode")

    src/AgentTextEditor.ts:1:24:
      1 │ import * as vscode from 'vscode'
        ╵                         ~~~~~~~~

  The path "vscode" was remapped to "$PWD/src/vscode-shim.ts" using the alias feature, which then
  couldn't be resolved. Keep in mind that import path aliases are resolved in the current working
  directory.

  You can mark the path "$PWD/src/vscode-shim.ts" as external to exclude it from the bundle, which
  will remove this error.

X [ERROR] Could not resolve "$PWD/src/vscode-shim.ts" (originally "vscode")

    ../vscode/src/jsonrpc/jsonrpc.ts:7:24:
      7 │ import * as vscode from 'vscode'
        ╵                         ~~~~~~~~

  The path "vscode" was remapped to "$PWD/src/vscode-shim.ts" using the alias feature, which then
  couldn't be resolved. Keep in mind that import path aliases are resolved in the current working
  directory.

  You can mark the path "$PWD/src/vscode-shim.ts" as external to exclude it from the bundle, which
  will remove this error.

X [ERROR] Could not resolve "$PWD/src/vscode-shim.ts" (originally "vscode")

    ../vscode/src/extension.common.ts:1:24:
      1 │ import * as vscode from 'vscode'
        ╵                         ~~~~~~~~

  The path "vscode" was remapped to "$PWD/src/vscode-shim.ts" using the alias feature, which then
  couldn't be resolved. Keep in mind that import path aliases are resolved in the current working
  directory.

  You can mark the path "$PWD/src/vscode-shim.ts" as external to exclude it from the bundle, which
  will remove this error.

X [ERROR] Could not resolve "$PWD/src/vscode-shim.ts" (originally "vscode")

    ../vscode/src/graph/bfg/BfgContextFetcher.ts:3:24:
      3 │ import * as vscode from 'vscode'
        ╵                         ~~~~~~~~

  The path "vscode" was remapped to "$PWD/src/vscode-shim.ts" using the alias feature, which then
  couldn't be resolved. Keep in mind that import path aliases are resolved in the current working
  directory.

  You can mark the path "$PWD/src/vscode-shim.ts" as external to exclude it from the bundle, which
  will remove this error.

6 of 82 errors shown (disable the message limit with --log-limit=0)
node:child_process:926
    throw err;
    ^

Error: Command failed: C:\Users\exigo\projects\cody\node_modules\.pnpm\@esbuild+win32-x64<EMAIL_ADDRESS>--sourcemap --bundle --outfile=dist/index.js --platform=node --log-level=warning --alias:vscode=$PWD/src/vscode-shim.ts src/index.ts
    at checkExecSyncError (node:child_process:887:11)
    at Object.execFileSync (node:child_process:923:15)
    at Object.<anonymous> (C:\Users\exigo\projects\cody\node_modules\.pnpm\esbuild@0.18.11\node_modules\esbuild\bin\esbuild:220:28)
    at Module._compile (node:internal/modules/cjs/loader:1233:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1287:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47 {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 13248,
  stdout: null,
  stderr: null
}

Node.js v20.5.1
 ELIFECYCLE  Command failed with exit code 1.
 ELIFECYCLE  Command failed with exit code 1.

Just to be sure, I've nuked my local Cody repo, cloned everything from scratch and started again with pnpm run build-agent-binaries in agent/ directory. Script is still failing.
Alias $PWD/src/vscode-shim.ts seems to be evaluated to something like /c/Users/exigo/projects/cody/agent/src/vscode-shim.ts. Could this be the root cause?

Please let me know if you need more details or additional checks.


fix first tab doesn't render when upgrading from 0.4.4 to 0.5.0

Fix:
First tab doesn't render when upgrading from 0.4.4 to 0.5.0

@skv-headless

It breaks lazy loading.

But this bug……

Lest make it optional with renderAllTabsOnMount property. Anyway we need this feature.

You right, I will changed.

@skv-headless maybe it's not breaks lazy loading and fix this bug.

Oh no , it's not fixed. I will changed

Fixed, I test. @skv-headless

@skv-headless Anything else?

@skv-headless please merge……

Thanks for PR but I had to refactor lazy loading code so I wanted to do it by myself

thx


Find usages with IDEA 2016.3 EAP (build 163.5644.15), Lombok 1.16.10 and Lombok plugin 0.13.16 not working

Given this simple test class.
import lombok.Data;

@Getter //or @Data
public class TestClass {

    private String string;

    @Override
    public String toString() {
        getString();
        return string;
    }
}

code is generated (as shown) but find usages on the field retrieves no result. IDE event log is empty so don't know how to provide more insight.
For the record, switching the annotation (so, from @Getter to @Data) breaks code generation in the IDE (maven is still fine). Restarting the IDE invalidating the cache makes code generation working but not find usages (which is particularly annoying since then also refactoring features are broken, since they rely on usages).
Full project attached.
Thanks for any feedback
test.zip

Maybe test with 2016.2.4?

Also it seems that Analyse Data Flow don't find accessors to leading to missed usage

Sorry for the delay, I now tried version 2016.2.4 and no problem at all there, then I tried version 2016.2.5 and I was able to reproduce the problem described with the sample project attached.
I guess I will temporarily rollback to version 2016.2.4 as it is really annoying to miss refactoring features

"Analyze data flow to here" still does not work with the current Lombok plugin version <IP_ADDRESS>.

closed as duplicate of #144 and #186


fixed not working on mobile browser

Solution 1:

use absolute.
use -webkit-overflow-scrolling: touch.

https://github.com/towry/n/issues/51


How to evaluate the network and get the result?

When I run the eval.py, I got nothing, could you give some details about the evaluation process?

You need 1) download the evaluation dataset (MS1M-ArcFace) from https://github.com/deepinsight/insightface/tree/master/recognition/datasets
2) update the config.rec parameter in the  config file
3) run eval.py


[WIP] Clear search text box

Clear Search text box of prior search criteria
Code fix now clears search box of any text and re-displays current accordion/tree data.
Added a route to enable proper js execution when clearing search text
https://bugzilla.redhat.com/show_bug.cgi?id=1346996

@h-kataria Please review.

@h-kataria @GregP now that clear_search_text is a standalone method, can a spec be added for that method?

@GregP please add spec tests for both explorer & non-explorer style screens to test this method.

@h-kataria Please review. Routing adjusted, added code to verify policy has exists before resetting it to nil.

@GregP how about clearing out @sb[:storage_search_text] & @sb[:foreman_search_text] also search for any others. Please add spec tests to verify changes.

@GregP What's the status of this PR? Are you going to implement the suggestions from previous comment?

@h-kataria This PR was a fix for the BZ ticket, which it does. If we are to expand to other areas of the app, then more code fixing is required than the 2 vars you mentioned and a separate PR. Perhaps as a GH issue, I can create one.

@GregP The problem, as I understand it, is that the search string (that we remember per-controller) is not being cleared when we hit the search clear cross mark.
You created a generic backend routine, which will be invoked from all controllers (via javascript)
from the search clear action, so the backend routine definitely needs to address all cases
and controllers, not just some random ones. So yes, I consider @h-kataria's suggestion
valid, otherwise this change makes very little sense.
Besides, with your changes, when I for example hit clear search under Infra -> Hosts, I get:
FATAL -- : Error caught: [NameError] undefined local variable or method `tree_select' for #<HostController:0x007fa82a74b2b8>
Did you mean?  tree_lock
app/controllers/application_controller.rb:418:in `clear_search_text'
...

Finally, since clear_search_text is a new routine, it requires specs of some sort.
Thanks.

@mzazrivec I have a specific BZ to fix that started this entire exchange. Vars mentioned by Harpreet are set to nil, so nothing to reset save for @search_text in this particular case. The error you ran into I tracked down to UI area not having any trees set up/displayed, thus a failure error you see, not sure what tree_lock does, but it would not fix anything here and fail same way since there are no trees on that page.
I am adding a check to make sure code already added is only invoked in pages having trees. I will also add spec test(s) to finish this BZ/PR.
Another PR will be created later on, and I am actively looking for a generic fix. As is, if you look at what @sb looks like at runtime, it is drastically different depending on where in UI we are and I am trying to find optimal solution that will work for entire UI, whether there are trees on the page or not.

@GregP What particular case are you speaking of here?
Doing an ajax request in miqHideSearchClearButton() as you did in this PR means that this
new mechanism will be included into bunch of pages in our application. So this problem
needs to be addressed in a generic manner here, in this PR.
tree_lock was just an automatic suggestion by the rails application, not something I was suggesting
as a fix.

Please re-create PR in https://github.com/ManageIQ/manageiq-ui-classic


After 401 Errors game crashes

Godot version
4.1.1
System information
Windows 10, Forward+, RTX3070
Issue description
After 401 Errors game crashes
Steps to reproduce
After 401 Errors that look like the ones below, game crashes. I wish I could have explained better but I have no idea what those errors do or mean.
Note: those errors DO NOT appear during gameplay. They do not appear at all. After a while, the game just crashes and there they are.
E 0:05:29:0397   compute_list_begin: Only one draw/compute list can be active at the same time.
<C++ Error>    Condition "compute_list != nullptr" is true. Returning: INVALID_ID
<C++ Source>   drivers/vulkan/rendering_device_vulkan.cpp:7735 @ compute_list_begin()
E 0:05:29:0397   compute_list_bind_compute_pipeline: Condition "p_list != ID_TYPE_COMPUTE_LIST" is true.
<C++ Source>   drivers/vulkan/rendering_device_vulkan.cpp:7748 @ compute_list_bind_compute_pipeline()
E 0:05:29:0397   compute_list_bind_uniform_set: Condition "p_list != ID_TYPE_COMPUTE_LIST" is true.
<C++ Source>   drivers/vulkan/rendering_device_vulkan.cpp:7812 @ compute_list_bind_uniform_set()
E 0:05:29:0397   compute_list_end: Condition "!compute_list" is true.
<C++ Source>   drivers/vulkan/rendering_device_vulkan.cpp:8194 @ compute_list_end()
Minimal reproduction project
could not reproduce. don't know what is the reason behind them

Most likely fixed by https://github.com/godotengine/godot/pull/79849, the fix will probably be in next releases. Closing as likely duplicate of the issues mentioned in the PR, especially if you use advanced nodes like GPU particles in your project. Still, please comment or reopen the issue if the problems has not been fixed in next release (or you can try Godot custom builds).


Least digit position wrong behavior

The issue occur simetimes while odometer value is increased. The least significant digit is increased by 1 when reels are stopped. When they farther start rotating the digit replaced with that it should be. E.g.

Value = 10.05, odometer rotates to this value, then it is stopped and last digit replaced and we have 10.06 displayed.
On start rotating value replaced with 10.05 and reels begin rotating.

I made an example that reprocudes the issue http://jsfiddle.net/vdLe9y95/7/.
Just look at page about minute and you will see what I'm talking about. It appears enough often. Also I shortly investigated this, I only was able to produce the issue if initialize odometer with some kind of round value, like 10000, 5000, 1000. If I setup it with 12345, the issue disappear.

The issue here is related to the various timing things going on. The JS options duration is set to 3 seconds, the CSS transition duration is still set to the default of 2 seconds, and the refresh function self-calling setTimeout occurs ever 5 seconds. Since these are misaligned in a timeline (and the timing of JS and CSS transitions are not guaranteed to be in sync with each other), this animation will definitely have some issues.


compute glyphs in parallel

This PR uses the std python concurrent.futures module to generate individual glyphs in parallel (for as many threads as there are on the machine) in order to speed up total generation time, as openscad is notoriously single-threaded and very slow.
It shortened generation time on my 4-core-8-thread laptop from ~15 minutes to under 3.

Very cool! I am going to test this out as soon as I can. What version of OpenSCAD are you running? The most recent stable version (2021.01) or one of the nightly builds with fast-csg ?
Also, if you don't mind me asking, when/how did you find the typeball project? I hadn't given it much thought in ~3 months and suddenly this week it's seeing a bit of attention, ahaha!

I am running OpenSCAD version 2021.01. I was unaware of improvements in the nightly versions, and will check that out too.

Also, if you don't mind me asking, when/how did you find the typeball project?

I read the Hackaday article back in April and am just now able to access a friend's resin printer, so I pulled it down and started playing with it. No idea why anyone else is just piling on now, but it's an interesting coincidence!

I found it this week because I just recently got my typewriter repaired, and was already interested in the concept of 3D printing a selectric typeball. :-) I have to agree it's just an interesting coincidence and not an algorithm surge.
P.S. @settinger You'll be pleased to learn that somehow the alignment on my typewriter magically fixed itself. I couldn't find the belt that Dave mentioned, but he must have been right that some belt got kinked, and I guess un-kinked itself after a few days of use.


Add files via upload

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x] Filename in the lowercase format
[x] Image format: png
[x] Image size: 256 by 256 px

Also, you can use these graphics to say that your ERC20 token fully compatible with Trust Wallet (https://trustwalletapp.com/logo-assets). Tokens will show up automatically once the user receives them.
Feel free to share this on social media and tag Trust Wallet:
Twitter: @TrustWalletApp
Facebook: @TrustWalletApp

Hi,
to update our logo on your wallet, I attach files as required.
Thank you
Details:
Contract on etherscan: 0xc560984d8c4ced2a0eba5790b33b6f43afeef759
Symbol SPRTZ
Decimals: 18

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

[x]  Filename in the lowercase format
[x]  Image format: png
[x]  Image size: 256 by 256 px

@SpritzCoin Added


Fix telemetry issues

Hello, @fredrikheden !
I fixed small issues with
TypeError: Cannot read property 'values' of undefined
    at n (<anonymous>:27:5997)
    at t.update (<anonymous>:27:8079)
    at r.update (https://app.powerbi.com/13.0.1973.185/scripts/visualhostcore.min.js:3:24122)
    at https://app.powerbi.com/13.0.1973.185/scripts/visualhostcore.min.js:3:9491
    at t.executeSafely (https://app.powerbi.com/13.0.1973.185/scripts/visualhostcore.min.js:3:12065)
    at t.update (https://app.powerbi.com/13.0.1973.185/scripts/visualhostcore.min.js:3:9447)
    at Object.<anonymous> (https://app.powerbi.com/13.0.1973.185/scripts/visualsandbox.min.js:1:6439)
    at Object.<anonymous> (https://app.powerbi.com/13.0.1973.185/scripts/VisualsSandboxCore.min.js:9:23143)
    at Object.<anonymous> (https://app.powerbi.com/13.0.1973.185/scripts/visualsandbox.minimal.externals.js:15406:33)
    at fire (https://app.powerbi.com/13.0.1973.185/scripts/visualsandbox.minimal.externals.js:15227:31)

Could you plese take a look this changes and merged them?


Single click selection

Hi Hugo,
I had the need to enable selection of one or more items via single click so I forked your project. In case you want to merge this to master you can accept this PR.

Thanks for submitting this PR!
I really like the idea, but I feel like "single click selection" doesn't actually describe what you want to achieve. The current behavior is: when long-pressing an item, trigger selection. The desired behavior is: when tapping an item, trigger selection.
What do you think about "trigger selection on tap" instead?

I agree! "trigger selection on tap" is semantically correct so I will update the PR :).

Looks great :)
Would would mind testing the new behavior? A single test right below this one should be fine.

I'll merge this and add some test.
Thanks!


Support for Prototypes and needsmore event

Apple introduced Prototypes and needsMore event handling for performance in TVOS 9. Can this be added as a new feature.

I haven't been following up with the latest developments in AppleTV world. This repository needs more contributors, I'd be glad if you or someone you know, would contribute with features and fixes 🙏


Roll Engine from f751d04fa0de to 45ff1a2e2e3c (5 revisions)

https://github.com/flutter/engine/compare/f751d04fa0de...45ff1a2e2e3c
2021-03-06<EMAIL_ADDRESS>Roll Fuchsia Mac SDK from Ks1dVR_ST... to PPdB-GHCt... (flutter/engine#24832)
2021-03-06<EMAIL_ADDRESS>[web] Don't set both color and foreground at the same time (flutter/engine#24828)
2021-03-06<EMAIL_ADDRESS>[web] Fix url updates when using Router (flutter/engine#24798)
2021-03-06<EMAIL_ADDRESS>Roll Skia from 3dc6c190dabb to 9ef3f2e3da9f (9 revisions) (flutter/engine#24830)
2021-03-05<EMAIL_ADDRESS>vulkan: Fix build issue due to missing VK_RESULT_RANGE_SIZE (flutter/engine#24829)
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Ks1dVR_STW_y to PPdB-GHCtDoX
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Gold has detected about 3 untriaged digest(s) on patchset 5.
View them at https://flutter-gold.skia.org/cl/github/77447

Commit queue failed; closing this roll.


Update headers to 1.3.275

TODO: CmdPushDescriptorSetWithTemplate2KHR needs to be handled as CmdPushDescriptorSetWithTemplateKHR.

CI gfxreconstruct build queued with queue ID 113075.

CI gfxreconstruct build # 3651 running.

CI gfxreconstruct build # 3651 passed.


Refinements

Updated the connection pool logic and updates with the recent AsyncKit changes.

@joannis please have a review 🙂

Can we have 2 PRs? One updating with Gwynne's upstream changes - and one with your diff?

@Joannis this should be better now? 🙂

@Joannis please let us know if anything new comes up, we can do a new fix pr/commit.


Add test with non-unicode text file

Added a test that demonstrates the behavior reported in issue #78
Not sure how to fix this, so I'll keep this PR as a draft. Any guidance on how to "fix" this would be much appreciated.

Can you give me a small example of a Django project using a non-utf8 template?

Hi Ned. As mentioned in the original issue (#78), in my case it's not actually a template but a changelog.txt file tucked away in a static directory of a submodule. django_coverage_plugin finds it (with the default settings) and stops working because of the encoding error.
As you said:

We should be more robust in the face of these sorts of things.

I'd like django_coverage_plugin to at least continue operating when it encounters a unreadable file. An acceptable solution would be to just mark the file as unreadable/uncovered.

I've updated the test to more accurately show when/where the issue arises. I've also added a proposed fix.

Fixed in #83


stlkMOVEToken

Summary

RFCs: Link to RFC, Link to RFC, or $\emptyset$.
Categories: any of protocol-units, networks, scripts, util, cicd, or misc.

Changelog

Testing

Outstanding issues

@0xPrimata Right now, the initialization only works for non-multi-inheritance paths. I'm focusing on just getting one inheritance chain up. So, if you have time to actually set up for init and init_unchained that would be great.

Additionally, @0xPrimata

Add GovernorTimelockControl.
I believe the storage for LockedToken should be refactored to use a more conventional storage contract pattern.
Suggest voting-based governance.

@0xPrimata if we want to close for cleanup, I think this is good for review.


Update leveldb

Description
Update leveldb to v1.0.4 and move the code to third_party as a submodule for a clear view.
Fixes # (issue)
Type of change (select or add applied and delete the others)

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] API change with a documentation update
[ ] Additional test coverage
[X] Code cleanup or just sync with upstream third-party crates

How has this been tested?
Checklist

[X] Fork the repo and create your branch from master.
[ ] If you've added code that should be tested, add tests.
[ ] If you've changed APIs, update the documentation.
[X] Ensure the tests pass (see CI results).
[X] Make sure your code lints/format.

Hi @henrysun007, thanks for the PR.
The reason we choose to put in the common directory is that we have changed rusty_leveldb a lot, and we don't have any plan to upstream the changes. Therefore, we'd like to keep it in the Teaclave codebase as a part of Teaclave.
I saw you're using a submodule for the changes (which is not under the Apache organization). This may be not suitable for further maintenance. Can you PR the changes of the rusty_leveldb_sgx in the source code?
For the name of the common directory, if you have better suggestion. Please advise.

Hi mingshen,
Thanks for your comments. I am fine with the codebase and the name.
The reason for putting it as a submodule in this PR is to have a clear view on the modification to the original code. In one repo, it is not very clear what we have done to rusty-leveldb. Do you have any advice?

Yes, I still remember that Zhaofeng and I had a long discussion on this and we decided to put in the Teaclave repo. There are pros and cons. I think the most important reason is about the ownership. We want to maintain LevelDB for SGX as part of Teaclave. Definitely, this makes it not obvious to diff with the upstream, but we think it's worth to do that. The best why to upgrade LevelDB for SGX is to apply any patches from upstream to the LevelDB in Teaclave's repo. Also, to make it more clear, we can document that which version we are based on.

Thanks for your patience, @mssun . Let us own the code.


HTML URL must match RemoteAddrValve allow pattern

There seems to be no address resolution such that "http://localhost:8080/manager/html" will not be treated as <IP_ADDRESS> in the RemoteAddrValve allow= pattern.

The premise of this PR is incorrect. The allow pattern in the RemoteAddrValve has no relationship to the host name used to access the Tomcat instance. The pattern is matched against the client IP address.

Hi Mark,
I found the root cause of the issue. It is the confusion created by this
paragraph:

A default Tomcat installation includes the Manager. To add an instance of
the Manager web application Context to a new host install the manager.xml
context configuration file in the
$CATALINA_BASE/conf/[enginename]/[hostname] folder. Here is an example:

If I follow the above instructions to create
conf/Catalina/localhost/manager.xml while having the out of the box
folder in ${catalina.home}/webapps/manager, then the "localhost" URL will
get a "403 Access Denied" error and the "<IP_ADDRESS>" URL works. Remove the
redundant manager.xml file makes both URLs work.

The first sentence does not adequately describe that "a default Tomcat
installation" means having the out of the box folder
${catalina.home}/webapps/manager, and that users should not create
conf/Catalina/localhost/manager.xml at the same time. Notice the sample
manager.xml above points docBase to the default Tomcat installation path of
manager, which is another pitfall by design.
Thanks
--Michael
On Tue, Sep 22, 2020 at 6:48 AM Mark Thomas<EMAIL_ADDRESS>wrote:

The premise of this PR is incorrect. The allow pattern in the
RemoteAddrValve has no relationship to the host name used to access the
Tomcat instance. The pattern is matched against the client IP address.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/tomcat/pull/367#issuecomment-696733828, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABBAJ37O5OQWTIU2R62Z26DSHCTLJANCNFSM4RU26YEQ
.

--
CONFIDENTIALITY NOTICE: This e-mail, including attachments, is for the sole
use of the intended recipient(s) and may contain confidential and
privileged information or otherwise be protected by law. Any unauthorized
review, use, disclosure or distribution is prohibited. If you are not the
intended recipient, please contact the sender and destroy all copies and
the original message.


Add adjoint solver dependencies

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.


Not Working

It's working fine just one month, but now it's not work for me,
but you https://api.unblockvideos.com/youtube_downloader?id=nxmp6eb_QgI worked fine
can you give an any update?

Looks like YouTube videos with ciphers give a 403 header whereas non-ciphered videos work fine.

then how to fix that?

No idea at the moment, sorry.

That problem appear only on localhost. If you host the script in some host, works. I'm working on why, but not success. Maybe sending some header thats work

I'm running on shared hosting. Getting the same issue. (Hostinger)

Strange, mine only works by hosting. I'll keep trying

This is really strange, i ran it on localhost and it works just fine...

I realized that each output ip returns a different domain. Using proxy, every output show different URL for the same video/itag. I think every output got an cluster
https://imgur.com/IR6a1sU
I leave this issue! If you try this script, y'll see you need run alot times to work just one time. It's just block from Google
`<?php
set_time_limit(0);
require "YouTubeDownloader.php";
$yt = new YouTubeDownloader();
$links = $yt->getDownloadLinks("https://www.youtube.com/watch?v=w8ja3NeUC_E");
// Get first link
$link = current($links);
var_dump($link['url']);
// Download
$fp = fopen("/PATH/teste.mp4", 'w+');                 // < ------------------- Change path
$ch = curl_init($link['url']);
curl_setopt($ch, CURLOPT_TIMEOUT, 50);
curl_setopt($ch, CURLOPT_FILE, $fp);
curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
curl_exec($ch);
curl_close($ch);
fclose($fp);`
I run about 8~10 times to work

can you place here full code?

Seems like a quite unefficent approach but it helped alot on locating the problem. Thanks!

Magically worked again.. looks like it was a host issue.

Duplicate of #12

I dont think this is the same issue. The #12 issue is a privacy config of the videos. This is some block of youtube from host
I think this block occur when youtube find backup server. Some servers work, some others no


Add Edit Button to my Chat messages PLEASE

Is your feature request related to a problem? Please describe:
When i finish a chat message and let it run, but then I come up with a better way to phrase it or I see it running in the wrong direction, I can stop it but not edit my original message, so i need to copy the text and start a new chat.
Describe the solution you'd like:
A little Edit Button when I hover over chat messages lets lets me edit my message and from there run the agent
Describe alternatives you've considered:
So far I need to recreate everything in a new chat
Additional context:
Compare this feature like existing in Claude, ChatGPT

Hi! 👋 Thanks for the comments!
I agree, it would be great to have this feature! We're tracking this internally. We'll keep you posted ✨


WalletConnect+TrustWallet: Invalid Session Properties requested

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
0.12.13
Current Behavior
OS: Android 11.
Platform: React
Using wagmi^0.12.13
After connecting to TrustWallet using WalletConnect, If I request a signature using
sign message from wagmi/actions,
following error is raised:
{context: "client"} 'Invalid Session Properties requested'.
Expected Behavior
The sign message should return signature.
Steps To Reproduce
No response
Link to Minimal Reproducible Example (StackBlitz, CodeSandbox, GitHub repo etc.)
No response
Anything else?
No response

Can you provide some more info? Are you using WalletConnect v1 or v2? Please attached a minimal reproduction.

I have attached minimal reproduction. I am using WalletConenctv2.


fix(plugins-ci-postgres): add newlines for folded block

Without the newlines the commands were all being ran on the same line as if they were a single command, so npm i was also trying to install sudo apt-get install -yqq libpq-dev postgresql-client

Checklist

[x] commit message and code follows the Developer's Certification of Origin
and the Code of conduct

makes sense ;)


📝 Add external link to article: Seamless FastAPI Configuration with ConfZ

I saw that new links are now added to the top of the list, so I hope this is fine.

Cool, thanks @silvanmelchior ! :rocket:


[Performance] Remove withOnyx() subscription in ReportActionItem

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

What performance issue do we need to solve?
inefficient React component rendering
What is the impact of this on end-users?
Slow to render chat. Takes more time to appear.
List any benchmarks that show the severity of the issue
Each ReportActionItem needs to retrieve data for the blockedFromConcierge key which can add significant overhead when rendering many comments in a chat.
Proposed solution (if any)
Like we did with the report action drafts we can use Context API for these subscriptions and it will have a slight impact on chat switching times.
List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)
Before
Timing:expensify.cash.switch_report.cold 231
Timing:expensify.cash.switch_report.cold 223
Timing:expensify.cash.switch_report.cold 214
After
Timing:expensify.cash.switch_report.cold 171
Timing:expensify.cash.switch_report.cold 206
Timing:expensify.cash.switch_report.cold 191
Platform:
Where is this issue occurring?

[x] Web
[x] iOS
[x] Android
[x] Desktop App
[x] Mobile Web

Version Number: 1.2.9-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
View all open jobs on Upwork

Much needed change.

Oh that's a good point though. There might be some subscriptions like this in the context menu...

Yep there's a subscription to betas here:
https://github.com/Expensify/App/blob/b058975f68c53904a9724d1ccccb265f451f3649/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js#L74-L78
I bet we can improve that as well.


Remove workaround for serializing LazyCompositeData

The class is internal to the JDK, so it's not available in Java 9.
It doesn't seem to be needed anymore, either.

Looks good


gcc compilation flags

Great project! I am trying to use fftw3, which requires gcc flag '-lfftw3'. Is it possible to configure compilation flags for each cell? It would be great if link path, include path, and flags can be configured dynamically.

Currently each cell is a completely separate program. So the flags are per cell as you want.
I've created issue #28 to support multiple cells for 1 program in the future.
Sent from my OnePlus ONEPLUS A5000 using FastHub

Thanks for the reply! I followed the README.md to install the package. It seems it is not the updated version, where there is no _filter_magics function defined. I think the version on PIPY should be updated.
Just to play around, I copy the updated files from this repository to the package path (also the ../resource folder for master.c) and define magic flags with
//%cflags:-lfftw3
//%cflags:-lm
// some fftw3 code

And the cell executes without problem.


weekly daily-dev to dev merge

This fixes #135. See commit details for more info on the fix.

Hello @mikkokotila! Thanks for submitting the PR.

There are no PEP8 issues in the file setup.py !

In the file talos/__init__.py, following                are the PEP8 issues :

Line 10:1: E402 module level import not at top of file
Line 13:1: E402 module level import not at top of file
Line 14:1: E402 module level import not at top of file
Line 15:1: E402 module level import not at top of file

In the file talos/examples/models.py, following                are the PEP8 issues :

Line 77:49: E128 continuation line under-indented for visual indent
Line 78:49: E128 continuation line under-indented for visual indent

There are no PEP8 issues in the file talos/model/early_stopper.py !

In the file talos/parameters/ParamGrid.py, following                are the PEP8 issues :

Line 26:1: W293 blank line contains whitespace
Line 40:5: E303 too many blank lines (4)

Pull Request Test Coverage Report for Build 295

3 of 3 (100.0%)  changed or added relevant lines in 3 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 77.998%

Files with Coverage Reduction
New Missed Lines
%

talos/reducers/reduce_run.py
1
100.0%

talos/reducers/correlation.py
2
84.21%

Totals

Change from base Build 289:
0.0%

Covered Lines:
748

Relevant Lines:
959

💛  - Coveralls

Pull Request Test Coverage Report for Build 295

3 of 3 (100.0%)  changed or added relevant lines in 3 files are covered.
3 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 77.998%

Files with Coverage Reduction
New Missed Lines
%

talos/reducers/reduce_run.py
1
100.0%

talos/reducers/correlation.py
2
84.21%

Totals

Change from base Build 289:
0.0%

Covered Lines:
748

Relevant Lines:
959

💛  - Coveralls


feat: add a text editor and image viewer to Silverblue

By default silverblue-main does not come with a text editor and an image viewer. While I agree with the approach of main being a reasonably minimal base, not adding too much compared to the upstream image, these two apps provide core desktop functionality, very important for the majority of users. They are also a very small addition - 0.5 MB for gnome-text-editor, 1.4 MB for eog ("eye of gnome", the image viewer for GNOME versions <45) and 2.1 MB for loupe (the image viewer for 45+).
Personally, not having an image viewer and text editor by default was one of the biggest annoyances for me after first installing ublue - I was really expecting a more complete GNOME experience. So, I think adding these apps is a great way to make using ublue a bit more convenient.
If anyone has questions/concerns I'm open to discussion.

I think the intent they want is for those apps to be installed as flatpaks?

I think the intent they want is for those apps to be installed as flatpaks?

Maybe an extremely limited (and unopinionated) implementation of the stuff added to Bluefin to install default apps could be good here?

I think the intent they want is for those apps to be installed as flatpaks?

We can implement that as well, we do have yafti after all :P

Maybe an unopinionated implementation of the stuff added to Bluefin & Bazzite to install default flatpaks could be good here?
Basic things like Contacts, Text Editor, Image viewer and the disk usage stuff?

Yes, exactly! If you want to do this as flatpaks, no problem, I'll close this PR and make it work with flatpaks.

Yeah on Bluefin we already moved to loupe from eog and the text editor is in there and the rest of the coreapps are mostly the same as Silverblue.

So you think we should make a yafti config for main for this? If so, I'll probably close this PR and make a new one

yafti isn't in main, those images are "light touch": https://universal-blue.org/scope/#main-images

Yeah I got a bit confused, sorry. How are flatpak installations handled in main? It doesn't seem to have a /etc/flatpaks/user/install file either, I must be missing something

They're not, we don't touch the flatpak setup in the main images, I haven't checked in a while but I think you get the fedora flatpak remote by default?

Actually I think in stock Fedora they're installed as part of the installation process before first boot.

So how should we add a selection of default flatpak apps to main? Do we have do it in the installer?

Yeah but we're in the middle of figuring out how to do that, but I don't think we'd make offline ISOs for all the main images anyway. They're all larger than what we can host on github. Once the OCI support in the installer is better upstream then we could make an online installer that we could host here that would replicate the functionality but we haven't been able to figure that out yet (multiple people are trying to figure it out).
I guess you could port the service units in bazzite/bluefin to install the packages in the background on first boot but that'd also be problematic as we'd have to add a bunch of stuff to main that people would probably not like (installing packages in the background without prompting, etc.).

I think being able to install flatpaks at first boot would be great, both for the images themselves and for the people who then fork them and make custom images. If you are concerned that people won't like it, perhaps we could do a vote?
Anyhow, I feel like this issue really needs to be solved somehow, as main images are way too barebones and not really usable out of the box without a few manual app installations (at least that's the case for Silverblue). If this will be solved in the iso/installer in the future, I can close this, but I feel like porting the first boot flatpak installer is the way to go.

If this will be solved in the iso/installer in the future, I can close this, but I feel like porting the first boot flatpak installer is the way to go.

I think this PR needs to be closed regardless of future plans, and instead make it an issue.
Related to the topic, my personal position is the current ISO installer is like pre-alpha, while our main images themselves are beta... and the best way to use Universal Blue is to install silverblue/kinoite/etc from official ISO, then rebase.  This somewhat solves the concern.
When we have reliable ISO/installer solutions, that's when I'm concerned about ensuring the first boot experience of *-main installs matches upstream. But, I'd want it to do just that, do what upstream does, not re-invent that wheel. Getting fun with Yafti and things is all for Bluefin, Bazzite, and other downstreams people want to create.

Alright, then I'm closing this and hoping to get it solved in the installer.

Alright, then I'm closing this and hoping to get it solved in the installer.

Hope it's clear, I do support creating an issue to track the concern.
If you do, please link it here for context. Thanks!


HHH-16441 - Implement BatchFetchStrategy-like support for @BatchSize

https://hibernate.atlassian.net/browse/HHH-16441
https://hibernate.atlassian.net/browse/HHH-16466
First commit is LEGACY++, PADDED and DYNAMIC strategies for entity.
Second will be for collection.

With this latest push, entity batch loading can now use either padded or array "strategy".  I dropped the other strategies.
Still to do:

Revisit collections
Extend this to multi-loads (i.e. Session#byMultipleIds)
Clean up LoaderSelectBuilder

Integrated upstream


[W.I.P][OAP-1918][OAP-CACHE][POAE7-563]bug fix: plasma get an invalid value

What changes were proposed in this pull request?
bug fix: plasma get an invalid value
How was this patch tested?
E2E

@jikunshang @yeyuqiang @winningsix  Please take a review, thanks.

LGTM.

@offthewall123 is it OK to commit? The title is still in WIP while dashboard shows completed.

close #1918

close #1918


Update GEOSsurface_GridComp/Shared/Raster to CMake

GEOSsurface_GridComp/Shared/Raster in the repo hasn't been updated for CMake, and it currently can't be compiled/built.  @bena-nasa and @smahanam are going to work on this.

The same issue has been opened as GEOSgcm #42. Thus, this issue is closed.

The same issue has been opened as GEOSgcm #42. Thus, this issue is closed.

The same issue has been opened as GEOSgcm #42. Thus, this issue is closed.


Renaming and burn method

One comment left (which is just for my curiosity). LGTM, go ahead and merge


Sporadic crashes in grpc_core::GrpcPolledFdWindows::SendVUDP

What version of gRPC and what language are you using?
1.27.1
What operating system (Linux, Windows,...) and version?
Windows
What runtime / compiler are you using (e.g. python version or version of gcc)
MSVC 16.4.5
What did you do?
Application sporadically crashing
What did you expect to see?
Not crashing
What did you see instead?
Stack point to thread which calls run_some_timers()method and then  grpc_core::ExecCtx::Get()->Flush().
lakecli!abort() Line 77	C++	Symbols loaded.

lakecli!grpc_core::GrpcPolledFdWindows::SendVUDP(grpc_core::WSAErrorContext * wsa_error_ctx, const iovec * iov, int iov_count) Line 378	C++	Symbols loaded.
[Inline Frame] lakecli!grpc_core::GrpcPolledFdWindows::SendV(grpc_core::WSAErrorContext *) Line 364	C++	Symbols loaded.
lakecli!grpc_core::SockToPolledFdMap::SendV(unsigned __int64 as, const iovec * iov, int iovec_count, void * user_data) Line 829	C++	Symbols loaded.
[Inline Frame] lakecli!socket_write(ares_channeldata * s, unsigned __int64 data, const void *) Line 197	C	Symbols loaded.
lakecli!ares__send_query(ares_channeldata * channel, query * query, timeval * now) Line 867	C	Symbols loaded.
[Inline Frame] lakecli!process_timeouts(ares_channeldata *) Line 561	C	Symbols loaded.
lakecli!processfds(ares_channeldata * channel, fd_set * read_fds, unsigned __int64 read_fd, fd_set * write_fds, unsigned __int64 write_fd) Line 132	C	Symbols loaded.
lakecli!ares_process_fd(ares_channeldata * channel, unsigned __int64 read_fd, unsigned __int64 write_fd) Line 153	C	Symbols loaded.
lakecli!on_ares_backup_poll_alarm_locked(void * arg, grpc_error * error) Line 286	C++	Symbols loaded.
lakecli!grpc_combiner_continue_exec_ctx() Line 237	C++	Symbols loaded.
lakecli!grpc_core::ExecCtx::Flush() Line 156	C++	Symbols loaded.
[Inline Frame] lakecli!run_some_timers() Line 134	C++	Symbols loaded.
lakecli!timer_main_loop() Line 237	C++	Symbols loaded.
lakecli!timer_thread(void * completed_thread_ptr) Line 286	C++	Symbols loaded.
lakecli!`anonymous namespace'::ThreadInternalsWindows::thread_body(void * v) Line 128	C++	Symbols loaded.
kernel32.dll!00007ffa3e327974()	Unknown	Non-user code. Symbol loading disabled by Include/Exclude setting.
ntdll.dll!00007ffa3edda271()	Unknown	Non-user code. Symbol loading disabled by Include/Exclude setting.

Anything else we should know about your project / environment?
We saw this happening on 1.19, 1.23 and still happening

I could further troubleshoot it, but app is Windows service and it is tough to gather logs.
Any advise what should settings should I set for GRPC_TRACE to get more info to troubleshoot it?

Running under GRPC_TRACE=api,client_channel_routing,cares_resolver,cares_address_sorting may give some insight

interested in progress, have similar issue on 1.26.0

We have the same issue to in 1.26.0.
 C:\grpc\src\core\ext\filters\client_channel\resolver\dns\c_ares\grpc_ares_ev_driver_windows.cc(378) -> assertion failed: GRPC_SLICE_LENGTH(write_buf_) == 0

If someone has a run under environment variables: GRPC_TRACE=api,client_channel_routing,cares_resolver,cares_address_sorting, that could help to get some insight on this.
For even better debug info if it's possible, an accompanying packet trace (e.g. pcap file for DNS traffic) captured during the failure, would also give insight.

Here is a change we did to fix this issue. Haven't seen it after.
0001-Attempt-to-fix-crash-reported-as-sporadic-crashes-in.txt

I'm having the same problem in version 1.32. I'm using c# with .net framework 4.7.1.
The crash seems to be related to the connection being lost to the gRPC server machine. I haven't been able to replicate it with any GRPC_TRACE information yet.
Attached is the stack trace. It's very similar to the one in the original question.
gRPC Disconnect Crash Stack Trace.txt

@apolcyn
I managed to get some trace information for the crash. Attached are the last 100,000 lines of the log (about 1 minute before the crash).
I can provide a larger portion of the log file if that would be helpful. The full file is about 45 million lines long.
gRPC Error trace info.zip

@apolcyn
Im able to reproduce this issue by toggling VPN state (on/off). Were using grpc 1.28.
grpc_assert_trace.txt
The issue doesn`t reproduce with the patch provided by @okravets.

Thank you all for the great info! I've merged the mentioned patch as #25726

Hi,
Which version of grpc will this be in? We are getting few reports from people and I am unable to reproduce the crash in windows - switching hibernate mode / vpn on or off as mentioned here.
I am happy to upgrade the grpc to the version once we know.
-Karthik

Hey ! I saw it as I mentioned in a ticket. After we've upgraded to 1.28.1-1,  I still applied my patch and do not see it.
Please see my comment from August 25, 2020.
Sasha

@okravets a fix with the patch you provided is included starting at https://github.com/grpc/grpc/releases/tag/v1.36.4 (which includes https://github.com/grpc/grpc/pull/25690)

@okravets a fix with the patch you provided is included starting at https://github.com/grpc/grpc/releases/tag/v1.36.4 (which includes #25690)
So you should no longer need to apply the mentioned patch manually.

Hey @apolcyn, we are currently using grpc 1.38.1, which has contains the 25690, but we are still seeing the crash at grpc_core::GrpcPolledFdWindows::SendVTCP.
So far, it is one of the popular crashes for our customers, but we cannot reproduce it at office.
The callstack is as below:
`

grpc_core::GrpcPolledFdWindows::SendVTCP(grpc_core::WSAErrorContext * wsa_error_ctx=0x000000f3919fe6b8, const iovec * iov=0x000002d6ba9b2250, int iov_count=1) Line 392    C++
[Inline Frame] grpc_core::GrpcPolledFdWindows::SendV(grpc_core::WSAErrorContext *) Line 347    C++
grpc_core::SockToPolledFdMap::SendV(unsigned __int64 as, const iovec * iov=0x000002d6ba9b2250, int iovec_count=1, void * user_data) Line 786    C++
write_tcp_data(ares_channeldata * channel=0x000002d6bad73880, fd_set * write_fds=0x0000000000000000, unsigned __int64 write_fd=13928, timeval * now=0x000000f3919fe710) Line 267    C
processfds(ares_channeldata * channel=0x000002d6bad73880, fd_set * read_fds=0x0000000000000000, unsigned __int64 read_fd=18446744073709551615, fd_set * write_fds=0x0000000000000000, unsigned __int64 write_fd=13928) Line 131    C
ares_process_fd(ares_channeldata * channel, unsigned __int64 read_fd, unsigned __int64 write_fd) Line 154    C
on_writable_locked(fd_node * fdn=0x000002d6bb038080, grpc_error * error=0x0000000000000000) Line 395    C++
[Inline Frame] std::_Func_class::operator()() Line 951    C++
grpc_core::WorkSerializer::WorkSerializerImpl::Run(std::function<void __cdecl(void)> callback={...}, const grpc_core::DebugLocation & location={...}) Line 69    C++
grpc_core::WorkSerializer::Run(std::function<void __cdecl(void)> callback={...}, const grpc_core::DebugLocation & location={...}) Line 152    C++
on_writable(void * arg=0x000002d6bb038080, grpc_error * error=0x0000000000000000) Line 415    C++
exec_ctx_run(grpc_closure * closure, grpc_error * error=0x0000000000000000) Line 46    C++
grpc_core::ExecCtx::Flush() Line 158    C++
pollset_work(grpc_pollset * pollset=0x000002d6b652fba8, grpc_pollset_worker * * worker_hdl=0x000000f3919fead0, __int64 deadline) Line 132    C++
cq_pluck(grpc_completion_queue * cq=0x000002d6b652fa70, void * tag=0x000000f3919feeb0, gpr_timespec deadline, void * reserved=0x0000000000000000) Line 1302    C++
grpc_completion_queue_pluck(grpc_completion_queue * cq, void * tag, gpr_timespec deadline, void * reserved=0x0000000000000000) Line 1329    C++
grpc::CoreCodegen::grpc_completion_queue_pluck(grpc_completion_queue * cq, void * tag, gpr_timespec deadline={...}, void * reserved=0x0000000000000000) Line 74    C++
grpc::CompletionQueue::Pluck(grpc::internal::CompletionQueueTag * tag=0x000000f3919feeb0) Line 323    C++
grpc::internal::BlockingUnaryCallImplgoogle::protobuf::MessageLite,google::protobuf::MessageLite::BlockingUnaryCallImplgoogle::protobuf::MessageLite,google::protobuf::MessageLite(grpc::ChannelInterface * channel=0x000002d6b3669570, const grpc::internal::RpcMethod & method, grpc::ClientContext * context=0x000000f3919ff550, const google::protobuf::MessageLite & request, google::protobuf::MessageLite * result=0x000000f3919ffa20) Line 89    C++

`

@apolcyn ping

Suggest trying the latest gRPC. There were some significant changes made to this code since this issue was filed, recently: https://github.com/grpc/grpc/pull/33965

I'm gonna close this assuming it was fixed in #33965 since there has been no activity since then. Please open a new issue if this still persists.


Remove "try" function from s3 expiration settings

Follow-up to https://github.com/centriascolocation/terraform-aws-security/pull/17:
After closer inspection I noticed that the "try" function here will do
more harm than good. As the default values are already set to null, all
the try function would do is replace invalid settings with null,
obscuring any issues introduced by the user in the progress.

@VolkerBohne @michaelkrieg


Added a script example

This script will display the user's name

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@blaiseAI Excellent work!


[release-0.20] Backport of #2787: Set IMAGE_PREFIX_ALT for explicitly for tests only, only release versioned virtctl binaries

What this PR does / why we need it:
Set IMAGE_PREFIX_ALT for explicitly for tests only, only release versioned virtctl binaries
Backport of #2787
Release note:
NONE

/lgtm
/approve


Common compress was removed from core 2.479

This plugin will not work on 2.479 because of removed dependency
Instead of using api dependency, just remove the import and use standard list
Testing done
Automated tests only
Submitter checklist

[x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
[x] Ensure that the pull request title represents the desired changelog entry
[x] Please describe what you did
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Hi @vdlr
Please take a look at this if you want your plugin to work with weekly releases of Jenkins (>= 2.489 https://www.jenkins.io/changelog/2.489/#v2.489)


KAFKA-3490; Multiple version support for ducktape performance tests

I revised @granders branch and rebased it against trunk. Running the branch builder here:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/401/
@granders, if you could take a look that would be great.

Started a system tests build here: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/405/

@granders, ready for another round of reviews. I addressed your feedback and added version support to benchmark_test.py. I don't have any other changes planned.
I tested the relevant tests via the AWS test driver and things seem fine. I also started a full system tests run via the branch builder:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/407/

System tests passed.
@ewencp, it would also be good for you to take a look as I assume you'll be the committer reviewing this. Some context: Geoff did most of the work on this branch before <IP_ADDRESS> went out. I needed this functionality, so Geoff rebased the branch and I tested it and added minor fixes and improvements.

@ijuma Other than fixing the conditional in producer_performance.py this looks good to me. Let's see if @ewencp has further comments

@ewencp Running the sanity check test in a loop of 100 iterations here:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder-2/49/consoleFull
So far, 20 iterations passed.

OK, so the test passed 67 times and then it failed with what I think is an unrelated failure:
[INFO:2016-04-09 03:35:02,127]: SerialTestRunner: Summary: There aren't enough available nodes to satisfy the resource request. Total cluster size: 0, Requested: 1, Already allocated: 0, Available: 0. Make sure your cluster has enough nodes to run your test or service(s). Currently registered services: [<ZookeeperService: num_nodes: 1, nodes: []>]

@ijuma That actually sounds like something went wrong with getting the list of machines available in the cluster (or they shutdown or something). This is what you normally get if you don't have any nodes started, or if you just don't have enough nodes for the test if the numbers are larger. 67 passes is enough to convince me :)
LGTM