“Confirmation error” popup appears  when user tries to connect phone number after creating account

Frequency: 70%
Repro on build version: Android Alfa jores Build V1.32.0, iOS Test flight Alfa jores Build V1.32.0
Repro on devices: iPhone 13 mini (15.1.1), Google Pixel XL (10.0), Google Pixel 2XL (11.0), iPhone 12 (14.7.1)
Does Not Repro on build version: Android Internal Release Build V1.32.0, iOS Test flight Release build V1.32.0
Does Not Repro on devices:  iPhone 13 mini (15.1.1), Google Pixel XL (10.0), Google Pixel 2XL (11.0), iPhone 12 (14.7.1)
Pre-condition:

User must have installed the application and must have completed onboarding flow without confirming phone number
User must be on Supercharge screen.

Repro Steps:

Tap on the Connect Number button.
Enter the valid phone number
Tap on start button and complete the captcha
Wait for sometime and observe the screen

Bug: “Confirmation error” popup appears when user tries to connect phone number after creating account
Expected Behavior: “Confirmation error” popup should not appear when user tries to connect phone number after creating account
Impact: Bad user impact as user is not able to confirm the phone number
Attachment: Confirmation.mp4

Hey @MuckT we have verified the above issue on latest iOS Testflight build V:1.32.0 and observed that issue is still reproducible for us
Observation :

Confirmation error is seen when user is connected to US VPN and tries to connect number
Confirmation error is seen when user is not connected to VPN but tries to connect using US number

Device : iPhone 12(14.7.1) , iPhone 13(15.1.1)
Thanks..!

Hey @MuckT we have verified the above issue on latest iOS Test flight Release build V:1.37.1 and Android Internal Release Build V1.37.1 and observed that issue is still reproducible for us
Observation :

“Confirmation error” popup appears when user tries to connect phone number while creating account

Devices : iPhone 7(13.3), Google pixel 4a(12.0)
Attachment: Confirmation error.mp4
Thanks..!!

Hey @MuckT we have verified the above issue on Latest iOS Alfajores build and Latest Android Alfajores build V 1.39.1 and observed that issue is fixed , hence we are closing it
Observation : Confirmation error is not seen when user tries to create / restore account and confirming phone number
Attachment : confirmation.mp4
thanks..!


fix using old token for captcha

👷 Deploy Preview for peaceful-meerkat-940447 processing.

Name
Link

🔨 Latest commit
9f00c66ab3bf96148fe885cad9737141f6aa4629

🔍 Latest deploy log
https://app.netlify.com/sites/peaceful-meerkat-940447/deploys/635bb7ea0221dd000958fc38


The design of tcp_proxy

I just checked the source code of how envoy implements the tcp_proxy, and find that after receiving the data from downstream, it would copy the data from read_buffer to write_buffer write_buffer_->move(data); (internal is memcpy(dest, data, copy_size);). Here are 3 questions I didn't figure out:

Why do we need the time-consuming data copy? Is that because we need modify the content of buffer?
If so, In what scenario would the envoy modify the content in the context of tcp_proxy?
Could copy on write improve the performance of this situation?

Thanks.
@brian-pane

cc @ggreenway @antoniovicente
Move doesn't actually copy in cases of large slices. Modification can happen via interim filters.
What all of that said, we have discussed recently the potential concept of a CoW buffer with slicing capabilities, but would need to figure out whether the complexity is worth the perf gain depending on the use case.

write_buffer write_buffer_->move(data); does a move, does not copy the data.

write_buffer write_buffer_->move(data); does a move, does not copy the data.

When I traced the  implementation of write_buffer write_buffer_->move(data), and find that in void OwnedImpl::coalesceOrAddSlice(SlicePtr&& other_slice), if the requirement of other_slice->canCoalesce() && !slices_.empty() && slice_size < CopyThreshold &&       slices_.back()->reservableSize() >= slice_size) met, it will make the real data copy, say, at https://github.com/envoyproxy/envoy/blob/master/source/common/buffer/buffer_impl.h#L156, envoy would launchmemcpy to do the data copy.
So is that the meaning of "Move doesn't actually copy in cases of large slices"?
Thanks.

The key condition is "slice_size < CopyThreshold".  CopyThreshold is currently 512 bytes.
Copies are done to coalesce small fragments only.  The reader side of the connection attempts to read multiples of 16KB and push that through the filter pipeline.  The typical size of blocks moved between buffers is about 20KB due to some quirks of the buffer implementation.

The key condition is "slice_size < CopyThreshold". CopyThreshold is currently 512 bytes.

Yes, this one makes a lot of sense, I was wondering whether 512 a randomly set number or a result conducted by a lot of experiments.

Copies are done to coalesce small fragments only.

What's the intuition behind this design? Given that large packet we dont need real copying, why do we need to copy small fragments?
Thanks for you help.


[visualstudio2019buildtools] Error due to file access rights deleting .lastupdatedate

Versions:

Current package version: v<IP_ADDRESS> installed.
Target package version: <IP_ADDRESS>
OS Version: Windows 10 Version 21H1 (OS Build 19043.1645)

I tried:

✅ Running as admin
✅ Tried with powershell core and powershell for windows

Output:
Progress: Downloading visualstudio2019buildtools <IP_ADDRESS>... 100%

visualstudio2019buildtools v<IP_ADDRESS> [Approved]
visualstudio2019buildtools package files upgrade completed. Performing other installation steps.
ERROR: The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Cannot remove item C:\Users\SeanK\AppData\Local\Microsoft\VisualStudio\Packages\_Channels\c291ba1b\.lastupdatedate: You do not have sufficient access rights to perform this operation.
The upgrade of visualstudio2019buildtools was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\visualstudio2019buildtools\tools\ChocolateyInstall.ps1'.
 See log for details.

I'm using Windows Defender, so I added an exemption for C:\Users\SeanK\AppData\Local\Microsoft\VisualStudio\Packages\_Channels and disabled/re-enabled scanning. The same issue persisted. So I don't think it's an AV issue in this case.

I've seen it once, I think, out of several tens of installs, so it may be hard to reproduce. But I have an idea for a mitigation and I might implement something over the weekend.

Just had this occur on a couple of machines whilst upgrading the visualstudio2022professional v <IP_ADDRESS> package would worth uploading any logs?

@OraDotNetDev  Yes, please try after upgrading the extension. The newest VS 2022 packages already depend on it, but they are still in moderation.

The root cause is that the latest versions of Visual Studio Installer started producing files with the "Hidden" attribute set, which Remove-Item refuses to delete without -Force.

Hi Jakub, thanks very much for your speedy response on this 🥇
I've tested this with the latest chocolatey-visualstudio.extension release (1.10.2) https://github.com/jberezanski/ChocolateyPackages/blob/master/chocolatey-visualstudio.extension/CHANGELOG.md#version-1102 and this resolves the issue.

Glad to hear it!
Meanwhile, the updated VS 2022 packages have encountered issues in moderation - apparently, the VS 2022 Installer has started using operating system functionality not available on Server 2012 R2 (the OS the Chocolatey Package Verifier is currently based on) and the packages now fail to install on 2012 R2, so they fail the verification step of moderation. (To be fair, the official system requirements of VS 2022 do say that only Server 2016+ is supported, but it worked on older OS until now.) I need to ask for moderation exemptions, so there may be a delay.

All packages have passed moderation now.


ERROR  Invariant Violation: requireNativeComponent: "RNSVGPath" was not found in the UIManager.

I was trying to use this package but it gave me this error  ERROR  Invariant Violation: requireNativeComponent: "RNSVGPath" was not found in the UIManager. on the latest version of react native 0.71.7 and using the latest version of rn-emoji-keyboard 1.2.1 any idea how can I fix this problem with my project? using react native cli

Hey @xts-bit, sorry for the delay.
The issue should be fixed in the latest release (1.3.0). Could you check it and confirm that the solution works?

Hi @xts-bit,
I'm closing this issue due to lack of activity. As I wrote in the previous message, this should no longer occur, starting from version 1.3.0. However, if the issue still exists, feel free to reopen 🙂


IE 8 testem error

When running the tests on Windows on IE8, I get this error:
Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Win64; x64; Trident/4.0; .NET CLR 2.0.50727; SLCC2; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E)
Timestamp: Tue, 25 Nov 2014 08:19:13 UTC

Message: Object doesn't support this property or method
Line: 4415
Char: 7
Code: 0
URI: http://localhost:7357/testem.js

This was fixed by https://github.com/airportyh/testem/pull/453


[FEATURE] Performance issue in CloseableHttpClient

Is your feature request related to a problem?
When performing benchmark test with heavy load in remote inference case, there's a chance to encounter the Timeout to get connection issue like below:
Caused by: org.apache.http.conn.ConnectionPoolTimeoutException: Timeout waiting for connection from pool
        at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.leaseConnection(PoolingHttpClientConnectionManager.java:316) ~[httpclient-4.5.14.jar:4.5.14]
        at org.apache.http.impl.conn.PoolingHttpClientConnectionManager$1.get(PoolingHttpClientConnectionManager.java:282) ~[httpclient-4.5.14.jar:4.5.14]
        at software.amazon.awssdk.http.apache.internal.conn.ClientConnectionRequestFactory$DelegatingConnectionRequest.get(ClientConnectionRequestFactory.java:92) ~[apache-client-2.20.19.jar:?]
        at software.amazon.awssdk.http.apache.internal.conn.ClientConnectionRequestFactory$InstrumentedConnectionRequest.get(ClientConnectionRequestFactory.java:69) ~[apache-client-2.20.19.jar:?]
        at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:190) ~[httpclient-4.5.14.jar:4.5.14]
        at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:186) ~[httpclient-4.5.14.jar:4.5.14]
        at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185) ~[httpclient-4.5.14.jar:4.5.14]
        at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83) ~[httpclient-4.5.14.jar:4.5.14]
        at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:56) ~[httpclient-4.5.14.jar:4.5.14]
        at software.amazon.awssdk.http.apache.internal.impl.ApacheSdkHttpClient.execute(ApacheSdkHttpClient.java:72) ~[apache-client-2.20.19.jar:?]
        at software.amazon.awssdk.http.apache.ApacheHttpClient.execute(ApacheHttpClient.java:254) ~[apache-client-2.20.19.jar:?]
        at software.amazon.awssdk.http.apache.ApacheHttpClient.access$500(ApacheHttpClient.java:104) ~[apache-client-2.20.19.jar:?]
        at software.amazon.awssdk.http.apache.ApacheHttpClient$1.call(ApacheHttpClient.java:231) ~[apache-client-2.20.19.jar:?]
        at org.opensearch.ml.engine.algorithms.remote.AwsConnectorExecutor.lambda$invokeRemoteModel$0(AwsConnectorExecutor.java:83) ~[opensearch-ml-algorithms-<IP_ADDRESS>.jar:?]
        at java.security.AccessController.doPrivileged(AccessController.java:569) ~[?:?]
        at org.opensearch.ml.engine.algorithms.remote.AwsConnectorExecutor.invokeRemoteModel(AwsConnectorExecutor.java:82) ~[opensearch-ml-algorithms-<IP_ADDRESS>.jar:?]

The reason behind this is the default connection pool of CloseableHttpClient is 50, and if the remote model latency is high, a thread can occupy a connection for long time, under heavy load the 50 connections can be occupied very soon and the requests comes later needs to wait for connection from the pool, and since long latency the connections are not released, the waiting will be timed out.
What solution would you like?
Check if possible to add a configuration to control the connection pool size in CloseableHttpClient.
What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.
Do you have any additional context?
Add any other context or screenshots about the feature request here.

Does the HttpConnector also use the http client from AWS SDK?

Would it be possible to capture session lengths to see if having a reasonable timeout would help?

@zane-neo  Can you help answer Austin's question?

Does the HttpConnector also use the http client from AWS SDK?

No, httpConnector use CloseableHttpClient directly not from aws sdk, but aws sdk internally use CloseableHttpClient.

Would it be possible to capture session lengths to see if having a reasonable timeout would help?

By session lengths you mean the a conversation session? If so, different user could have different session lengths, and even for one specific user, long session length doesn't mean the user would like to wait for a response that takes session length long.
I think allowing customer to configure the timeout could be the optimal solution, client can setup this value based on their different business use case.

Closing this as async http client is been used now, performance report here: https://github.com/opensearch-project/ml-commons/issues/1839


change_not_in for conditions

Hello.
In semaphore pipeline I can use change_in  function.
For example, I have monorepo with structure:
.
├── Brewfile
├── Capfile
├── Gemfile
├── Gemfile.lock
├── Procfile
├── Procfile.static
├── README.md
├── Rakefile
├── app
├── bin
├── client
├── config
├── db
├── doc
├── docker-compose.yml.sample
├── engines
├── lib
├── log
├── package-lock.json
├── package.json
├── public
├── spec
└── tmp

Frontend: all files from client directory
Backend: all other files
In pipeline I have this block for Client section:
blocks:
  - name: "Client: install dependencies"
    dependencies: []
    run:
      when: "change_in(['/client', '/public'])"

If the client part is not touched CI skip these blocks.
I want to skip backend jobs if any other files without client or public dir were changed.

@romanlex thanks for opening this feature request.
We have the following expression that you can use in your pipeline:
blocks:
  - name: "Backend Tests"
    run:
      when: "change_in(['/client', '/public']) = false"

Would this work for your project?

At the moment, we are re-implementing the change_in evaluator, making it faster and more stable along the way.
If you have any other things that would be useful for your project, please let us know.
Now is the perfect time to introduce new functionality.
The new change_in evaluator is open-source and the progress can be tracked in this repository
—> https://github.com/semaphoreci/spc
—> https://github.com/semaphoreci/spc/tree/master/test/e2e

We have the following expression that you can use in your pipeline:
blocks:
  - name: "Backend Tests"
    run:
      when: "change_in(['/client', '/public']) = false"

@shiroyasha this will not work as it should

If files touched in client folder and any files from another folder
-> Run Client jobs
-> Run Backend jobs

If files touched only in client folder
-> Run Client jobs
-> Skip Backend jobs

If any files touched from root folder but files in client folder doesn't changed
-> Skip Client jobs
-> Run Backend jobs

Thanks for providing an example. It definitely helps.
The change_not_in would definitely be an interesting addition.
I'll discuss with the rest of the team if we can squeeze it in the current iteration.

@romanlex I have a proof-of-concept solution that looks promising for this setup.
I've coded it out in the new change_in compiler.
I specifically constructed the test based on your input:
—> Tests for Change In with Exclusion patterns
Please let us know if this solution would work for your project.

@shiroyasha
Yes, it will help us.
Exclude option it's a good solution

I've merged the proposal 🎉
This is part of the new change-in evaluation infrastructure, that is not yet released.
We expect to have a working release early in December.
The full release is expected to be released in late-December, early-January.
I'll post an update on this issue when the releases are rolled out.
@romanlex If you want to take part in the earlier testing phase, please let me know and I'll enable it
for your project as soon as we have a beta release 🙇

@shiroyasha thanks a lot

@shiroyasha this feature is released?

@romanlex sorry for the late reply.
Unfortunately, it is not yet released. We uncovered a problem that prolonged the development efforts by around ~2weeks.
We expect to see this feature available in prod in mid-January.

@romanlex sorry for the late reply.
Unfortunately, it is not yet released. We uncovered a problem that prolonged the development efforts by around ~2weeks.
We expect to see this feature available in prod in mid-January.

@shiroyasha it's released?

@shiroyasha it's released?

@romanlex
I'm glad to report that it is released. 🙌
We are looking forward to your feedback. 🙇
Try it out with change_in('/', {exclude: ['/client']}).

@shiroyasha

I have error(

@shiroyasha
Now I have another error

@romanlex ^ I've released the updated compiler in prod, around ~25mins ago.
Can you test it out?

@shiroyasha  now it's work


Need to create Academic Semester route,service and controller.

[x] Added academicSemester route
[x] Added academicSemister service
[x] Added academicSemester controller

solved


[Feature] Create a Custom 404 page for the website

Description
A 404 Not Found page is essential if a link is missing or if somehow a page doesn't render due to any circumstances.
A 404 page will let users know that the page is missing somehow or the feature has not been implemented yet. If the link suddenly gets abrupt , users may think the website is faulty , which will hamper user experiance.
I would like to contribute to it under GSSoC'24
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I have read the Contributing Guidelines
[X] I have read the Code Of Conduct
[X] I joined onboarding group for knowledge flow and direct conversation and support from admins  Curious Developers Community - Curious Connect
[X] The changes don't break the code
[X] Please attach the screenshots and video of the development work once it is done
[X] If you need any help please join the default  (Google Meet Link)

Assign this issue to me

can you plz assign me this

@thecuriousteam Kindly see to this


Engine config: replace #cache_duration_in_days with #cache_duration

Coverage decreased (-0.3%) to 92.74% when pulling d06811ebc8e2213438dee144b90a68106745e8ed on dunn:cache-duration into 6acf20d6ac5101a49b5e7b55afa15cf0be8c91e7 on curationexperts:master.

Coverage decreased (-0.3%) to 92.74% when pulling d06811ebc8e2213438dee144b90a68106745e8ed on dunn:cache-duration into 6acf20d6ac5101a49b5e7b55afa15cf0be8c91e7 on curationexperts:master.


Update URL to add bot to Discord server

The README has been confusing a lot of people and seems to be one of the common reasons lately why people are popping into the Discord server. This might help!

I suggest you to uptade the url again.


Introduce real lazy loading for the decompile classpath

This reduces memory usage significantly, and may increase performance in cases where the decompiler context is created and destroyed frequently.
I've also bumped the minimum Java version to 11 for easier porting of these changes. To help users who may want to target older Java versions, I've put in support for reading java runtime images from other JDKs besides the one currently running.
There is some minor tweaking of how threading works, to match my open ForgeFlower PR, and remove the need for synchronization on result savers/output sinks.
Going to keep this as draft until things are ready on the ForgeFlower side, so any changes can be replicated in either direction.

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop/1.9.0@a34b90a). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             develop/1.9.0     #120   +/-   ##
================================================
  Coverage                 ?   77.63%
  Complexity               ?     7701
================================================
  Files                    ?      206
  Lines                    ?    24601
  Branches                 ?     6387
================================================
  Hits                     ?    19098
  Misses                   ?     3571
  Partials                 ?     1932

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a34b90a...94abba0. Read the comment docs.

The test fails, but I'll manually fix it after merging.


sitecore-jss - remove 'npm ci' from build steps

'npm ci' should not be necessary, as this is covered by 'npm bootsrap:ci'

@anastasiya29 This is required for the root install (i.e. of lerna itself), no?

This was a test. Closing.


Promote SPI/RemoteSecret from staging to prod

Included PRs:

https://github.com/redhat-appstudio/remote-secret/pull/180
https://github.com/redhat-appstudio/remote-secret/pull/170
https://github.com/redhat-appstudio/remote-secret/pull/174
https://github.com/redhat-appstudio/remote-secret/pull/177
https://github.com/redhat-appstudio/remote-secret/pull/175
https://github.com/redhat-appstudio/remote-secret/pull/176
https://github.com/redhat-appstudio/remote-secret/pull/172
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/737
https://github.com/redhat-appstudio/service-provider-integration-operator/commit/180c529092af8715e417521b203ca98faf6168b0
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/736
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/742
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/738
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/743
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/744
https://github.com/redhat-appstudio/service-provider-integration-operator/pull/740

/lgtm


Configuring Gear VR Controler

I am trying to use ALVR with my Gear VR but when it connects it asks me
to press the trigger. When I press it at my controller nothing happens.

I'v the exact same issue (using v2.4.0-alpha5)


Update website to gatsby v3

Updates are now finally reflected in real-time again :rocket:
Changes
I upgraded all packages to their latest version and made the following replacements:

old
new

gatsby-plugin-ts
gatsby-plugin-graphql-codegen

gatsby-image
gatsby-plugin-image

@darth-knoppix/gatsby-plugin-feed
gatsby-plugin-feed

The switch to gatsby-plugin-feed isn't necessary and I can revert it, if it's unwanted.
Trying it out

Checkout the branch
Remove the node_modules directory and execute yarn install to install all necessary packages
Execute yarn clean to get rid of old (potentially problematic) cache entries

Continue as you normally would with yarn start or yarn build.

Uhhh Gatsby 3!

@arif-hanif Can't do anything about the error, but it also doesn't cause any issues. The author information is supposed to be unknown during development. The actual git commands are only issued during a production build.

@arif-hanif Can't do anything about the error, but it also doesn't cause any issues. The author information is supposed to be unknown during development. The actual git commands are only issued during a production build.
I can add the dependency.

Looks good then.

The warn Plugin gatsby-remark-reading-time is not compatible with your gatsby version 3.6.2, doesn't cause any issues. In the migration documentation of Gatsby it also said that some packages will complain that they are not compatible, because their peer dependency was not upgraded, but most of them will continue to work. The plugin is just no longer maintained as it seems and therefor the peerDependency was not upgraded. I also couldn't fine an alternative.
The Query takes too long also sometimes happens with Gatsby v2.


Add definePlugin to webpack.prod configuration

make some changes to be able build kaoto for both standalone and openshift

@mmelko is this ready to be merged?


Defer bring into view for newly created TreeViewItem

What does the pull request do?
Trying to deffere request for BringIntoView, when TreeViewItem not ready yet.
Fixed issues
Fixes #9173

You can test this PR using the following package version. 11.0.999-cibuild0024661-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0024703-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]

You can test this PR using the following package version. 11.0.999-cibuild0025386-beta. (feed url: https://nuget.avaloniaui.net/repository/avalonia-all/index.json) [PRBUILDID]


Switch upstart to use the new cfg file

This is the first stab at changing our apt package to use the new config file. This way the brew and windows packages can use the same base cfg file, and we have a nice doc online explaining each of the properties… and that way we can refer to that doc in any guides, docs or elsewhere, no matter the install method.
Not yet run or tested…
Also #125 and #126

I've pulled these changes into master :family:


Data and VIS Function loading spinner

Test: http://localhost:3000/page?id=60cfad6d81b6034073d2ff16

I fixed Netlify in https://github.com/ScottishCovidResponse/rampvis-ui/pull/117
We can merge that PR and push something into your branch, CI should pass


Extract notebooks/ examples to separate top level directory.

Zeppelin, etc code should not be mixed with parser code.  The parser is designed to be relatively agnostic to platform.

Done.


feat(parser): parse IGNORE NULLS in (window) function calls

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This is the first step towards #17601.
Checklist

[x] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#18028  👈
#18023
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on  Graphite

https://www.postgresql.org/docs/17/sql-expressions.html#SYNTAX-WINDOW-FUNCTIONS
Syntactically the following is possible:
function_name (...) FILTER ( WHERE ... IS NOT NULL ) OVER ( ... )

If FILTER is specified, then only the input rows for which the filter_clause evaluates to true are fed to the window function; other rows are discarded.

However,

Only window functions that are aggregates accept a FILTER clause.

ERROR:  FILTER is not implemented for non-aggregate window functions

However,

Only window functions that are aggregates accept a FILTER clause.

ERROR:  FILTER is not implemented for non-aggregate window functions

Is this the PG behavior?

Yes everything in my comment above is about PostgreSQL.


Move test recipes into test directory

From what I've seen, the standard-ish place is in test/fixtures/cookbooks/nxlog_test or something to that affect. The recipe directory is one of the first places to go to grok a cookbook, and it's a bit confusing to see so much going on in there :)

Seems like a good idea to me


On Linux, 'sudo apt install cmake ninja-build' calls cmake v. 3.10.2 but M4 sample required v. 3.11.

On Linux, when type the  command, I'm getting cmake version 3.10.2.
However, the all M4 RTapps require Cmake minimum version 3.11.
The end users notice the failure after build and run the app then need to set it up again. Can you explain the steps for setting a higher version manually, or make it compatible with a lower version, to save time for the end user and for a better user experience? Thanks.

Hi @Shieroo - we haven't tested compilation of our samples on linux (sounds like you're running Ubuntu 18.04) yet. But you should be able to just build and install cmake from source. This answer on stack overflow goes over the steps: https://askubuntu.com/a/865294/387450, but you should be able to just download the source from https://cmake.org/download/. In order to make a plug and play environment to improve the usability of our samples, we might need to make a Dockerfile with all of the build dependencies at the right versions. If you have experience with Docker, please feel free contributing a Dockerfile to the samples repo.


Re-incorporating the trace logging originally written by Sean Berry.

Sean Berry incorporated trace-level logging into the logrus library we're using.  Incorporating these changes into a fork so they're not lost.

Apologies - this wasn't meant for this repo.


Enhanced readability with colors

color the status in yellow or red, depending on the severity
no color is used for normal status, like Running. Green is not used in
order to avoid the confusion with red color for color blind users.
yellow is used for warnings and transional status, like Pending - very
useful to differentiate Pending and Running.
red is used for failed, error, ... status
because strings contain the most information, and white is the most
readable color, strings are changed to white color.
table output is changed to two alternating colors, to enhance the
readability of the columns without using too many colors
key indent color alternates between yellow and cyan to enhance the indent
readability and differentiate the key from the content
while it would be great to enhance the readability of the help page,
coloring everything in yellow doesn't seem to help for that purpose. As for
strings, white is more readable and seems more suited for this complex
content
Related issue (if exists)

I'm very new to this project, so I'm not sure if this has already been discussed and maybe rejected. Please just tell me if that's the case!
If you're interested, I'll take a bit more time to fix the tests :)

I'm very new to this project, so I'm not sure if this has already been discussed and maybe rejected. Please just tell me if that's the case!
If you're interested, I'll take a bit more time to fix the tests :)

Hi @glehmann , thank you for much effort!

color the status in yellow or red, depending on the severity

I totally agree with this concept. Actually this was what I wanted to do.
This PR looks promising, but let me leave some comments here

Hi @glehmann , thank you for much effort!

color the status in yellow or red, depending on the severity

I totally agree with this concept. Actually this was what I wanted to do.
This PR looks promising, but let me leave some comments here

Sorry, I mistakenly closed the PR 😢 nvm

Sorry, I mistakenly closed the PR 😢 nvm

yellow is used for warnings and transional status, like Pending - very
useful to differentiate Pending and Running.
red is used for failed, error, ... status

This sounds good.

yellow is used for warnings and transional status, like Pending - very
useful to differentiate Pending and Running.
red is used for failed, error, ... status

This sounds good.

table output is changed to two alternating colors, to enhance the
readability of the columns without using too many colors

I want to discuss this.
I intentionally used many colors in table output because I know some usecases to use kubecolor for kubernetes workshop or something like that. In the workshop, it is easy to tell "see the green column. It means~" with using many colors.
I am not disagreeing using only 2 colors, but can I ask you why you thought using 2 colors is better?

table output is changed to two alternating colors, to enhance the
readability of the columns without using too many colors

I want to discuss this.
I intentionally used many colors in table output because I know some usecases to use kubecolor for kubernetes workshop or something like that. In the workshop, it is easy to tell "see the green column. It means~" with using many colors.
I am not disagreeing using only 2 colors, but can I ask you why you thought using 2 colors is better?

key indent color alternates between yellow and cyan to enhance the indent
readability and differentiate the key from the content

This basically sounds good.
Now I am thinking if we choose yellow and cyan for the key color, it might better not to use them in "values" color.

key indent color alternates between yellow and cyan to enhance the indent
readability and differentiate the key from the content

This basically sounds good.
Now I am thinking if we choose yellow and cyan for the key color, it might better not to use them in "values" color.

while it would be great to enhance the readability of the help page,
coloring everything in yellow doesn't seem to help for that purpose. As for
strings, white is more readable and seems more suited for this complex
content

Fair enough. In my opinion, there are 2 chances for users to see help when using kubectl:

When a user specified -h or --help
When a user made mistake in the command usage

For example, kubectl top and kubectl top -h show the same "help" content, but the result code is different: kubectl top returns 1 but kubectl top -h returns 0 (according to echo $?).
I think this is because kubectl top is simply wrong usage because top requires arguments, but kubectl top -h is not wrong.
I want to make these 2 cases clear in kubecolor as well. Because kubecolor top is wrong usage (result code is 1), the shown help should be colored in yellow. However, kubecolor top -h don't need to be shown in yellow; it should be ok to show in white as you suggested.

while it would be great to enhance the readability of the help page,
coloring everything in yellow doesn't seem to help for that purpose. As for
strings, white is more readable and seems more suited for this complex
content

Fair enough. In my opinion, there are 2 chances for users to see help when using kubectl:

When a user specified -h or --help
When a user made mistake in the command usage

For example, kubectl top and kubectl top -h show the same "help" content, but the result code is different: kubectl top returns 1 but kubectl top -h returns 0 (according to echo $?).
I think this is because kubectl top is simply wrong usage because top requires arguments, but kubectl top -h is not wrong.
I want to make these 2 cases clear in kubecolor as well. Because kubecolor top is wrong usage (result code is 1), the shown help should be colored in yellow. However, kubecolor top -h don't need to be shown in yellow; it should be ok to show in white as you suggested.

Currently my concerns are mainly 2: table colors and key-value color duplication. It would be helpful if you can tell me some thoughts.
I am neither UI designer nor color scheme professional, so I was wondering I want to improve kubecolor's looking, but I actually had no idea how to do that. I am now very happy to know your opinion about the color. I strongly want to merge this PR after making things clear.

Currently my concerns are mainly 2: table colors and key-value color duplication. It would be helpful if you can tell me some thoughts.
I am neither UI designer nor color scheme professional, so I was wondering I want to improve kubecolor's looking, but I actually had no idea how to do that. I am now very happy to know your opinion about the color. I strongly want to merge this PR after making things clear.

table output is changed to two alternating colors, to enhance the
readability of the columns without using too many colors

I want to discuss this.
I intentionally used many colors in table output because I know some usecases to use kubecolor for kubernetes workshop or something like that. In the workshop, it is easy to tell "see the green column. It means~" with using many colors.
I am not disagreeing using only 2 colors, but can I ask you why you thought using 2 colors is better?

for several reasons:

the main reason is to have quite neutral colors, so its easy to highlight important things in the table, like the Pending status, with other colors and have a high contrast between the highlighted and non highlighted text. If there is a lot of colors, it becomes quite difficult to highlight things and make it easily eye catching :)
unix command line tool are usually not very colored. I use that characteristic to contrast with my shell prompt, which is often quite colored, and easily separate the commands and their output
based on the previous points, we could say that the text should be mostly white, but I still find easier to read the table when the column or better identified. The alternating colors really help here, especially when the table is larger than the terminal and some lines are wrapping on the line below. It's also easier to identify the columns when the table doesn't fit in the terminal and the column header is not visible. Cyan looks like a good secondary color, as its quite neutral, and still let a lot of room to contrast with red or yellow for example.
finally, and purely subjectively, I found more pleasing to look at a more sober version :)

In summary, mostly for contrast, and a bit for subjective aesthetic :)

table output is changed to two alternating colors, to enhance the
readability of the columns without using too many colors

I want to discuss this.
I intentionally used many colors in table output because I know some usecases to use kubecolor for kubernetes workshop or something like that. In the workshop, it is easy to tell "see the green column. It means~" with using many colors.
I am not disagreeing using only 2 colors, but can I ask you why you thought using 2 colors is better?

for several reasons:

the main reason is to have quite neutral colors, so its easy to highlight important things in the table, like the Pending status, with other colors and have a high contrast between the highlighted and non highlighted text. If there is a lot of colors, it becomes quite difficult to highlight things and make it easily eye catching :)
unix command line tool are usually not very colored. I use that characteristic to contrast with my shell prompt, which is often quite colored, and easily separate the commands and their output
based on the previous points, we could say that the text should be mostly white, but I still find easier to read the table when the column or better identified. The alternating colors really help here, especially when the table is larger than the terminal and some lines are wrapping on the line below. It's also easier to identify the columns when the table doesn't fit in the terminal and the column header is not visible. Cyan looks like a good secondary color, as its quite neutral, and still let a lot of room to contrast with red or yellow for example.
finally, and purely subjectively, I found more pleasing to look at a more sober version :)

In summary, mostly for contrast, and a bit for subjective aesthetic :)

while it would be great to enhance the readability of the help page,
coloring everything in yellow doesn't seem to help for that purpose. As for
strings, white is more readable and seems more suited for this complex
content

Fair enough. In my opinion, there are 2 chances for users to see help when using kubectl:

When a user specified -h or --help
When a user made mistake in the command usage

For example, kubectl top and kubectl top -h show the same "help" content, but the result code is different: kubectl top returns 1 but kubectl top -h returns 0 (according to echo $?).
I think this is because kubectl top is simply wrong usage because top requires arguments, but kubectl top -h is not wrong.
I want to make these 2 cases clear in kubecolor as well. Because kubecolor top is wrong usage (result code is 1), the shown help should be colored in yellow. However, kubecolor top -h don't need to be shown in yellow; it should be ok to show in white as you suggested.

while it would be great to enhance the readability of the help page,
coloring everything in yellow doesn't seem to help for that purpose. As for
strings, white is more readable and seems more suited for this complex
content

Fair enough. In my opinion, there are 2 chances for users to see help when using kubectl:

When a user specified -h or --help
When a user made mistake in the command usage

For example, kubectl top and kubectl top -h show the same "help" content, but the result code is different: kubectl top returns 1 but kubectl top -h returns 0 (according to echo $?).
I think this is because kubectl top is simply wrong usage because top requires arguments, but kubectl top -h is not wrong.
I want to make these 2 cases clear in kubecolor as well. Because kubecolor top is wrong usage (result code is 1), the shown help should be colored in yellow. However, kubecolor top -h don't need to be shown in yellow; it should be ok to show in white as you suggested.

seems good to me :+1:

while it would be great to enhance the readability of the help page,
coloring everything in yellow doesn't seem to help for that purpose. As for
strings, white is more readable and seems more suited for this complex
content

Fair enough. In my opinion, there are 2 chances for users to see help when using kubectl:

When a user specified -h or --help
When a user made mistake in the command usage

For example, kubectl top and kubectl top -h show the same "help" content, but the result code is different: kubectl top returns 1 but kubectl top -h returns 0 (according to echo $?).
I think this is because kubectl top is simply wrong usage because top requires arguments, but kubectl top -h is not wrong.
I want to make these 2 cases clear in kubecolor as well. Because kubecolor top is wrong usage (result code is 1), the shown help should be colored in yellow. However, kubecolor top -h don't need to be shown in yellow; it should be ok to show in white as you suggested.

while it would be great to enhance the readability of the help page,
coloring everything in yellow doesn't seem to help for that purpose. As for
strings, white is more readable and seems more suited for this complex
content

Fair enough. In my opinion, there are 2 chances for users to see help when using kubectl:

When a user specified -h or --help
When a user made mistake in the command usage

For example, kubectl top and kubectl top -h show the same "help" content, but the result code is different: kubectl top returns 1 but kubectl top -h returns 0 (according to echo $?).
I think this is because kubectl top is simply wrong usage because top requires arguments, but kubectl top -h is not wrong.
I want to make these 2 cases clear in kubecolor as well. Because kubecolor top is wrong usage (result code is 1), the shown help should be colored in yellow. However, kubecolor top -h don't need to be shown in yellow; it should be ok to show in white as you suggested.

seems good to me :+1:

key indent color alternates between yellow and cyan to enhance the indent
readability and differentiate the key from the content

This basically sounds good.
Now I am thinking if we choose yellow and cyan for the key color, it might better not to use them in "values" color.

It would be better, in order to have a good contrast between key in values, but is it possible with the few available colors?

key indent color alternates between yellow and cyan to enhance the indent
readability and differentiate the key from the content

This basically sounds good.
Now I am thinking if we choose yellow and cyan for the key color, it might better not to use them in "values" color.

It would be better, in order to have a good contrast between key in values, but is it possible with the few available colors?

Currently my concerns are mainly 2: table colors and key-value color duplication. It would be helpful if you can tell me some thoughts.
I am neither UI designer nor color scheme professional, so I was wondering I want to improve kubecolor's looking, but I actually had no idea how to do that. I am now very happy to know your opinion about the color. I strongly want to merge this PR after making things clear.

I'm not an UI designer either, but I had the chance to work during several years on a command line tool that strongly focused on usability. We tested many options, and that allowed me to build a quite strong opinion on how colors (and cli in general) should be used :)
Thanks for creating this nice tool and to be open to discuss about it :)

Currently my concerns are mainly 2: table colors and key-value color duplication. It would be helpful if you can tell me some thoughts.
I am neither UI designer nor color scheme professional, so I was wondering I want to improve kubecolor's looking, but I actually had no idea how to do that. I am now very happy to know your opinion about the color. I strongly want to merge this PR after making things clear.

I'm not an UI designer either, but I had the chance to work during several years on a command line tool that strongly focused on usability. We tested many options, and that allowed me to build a quite strong opinion on how colors (and cli in general) should be used :)
Thanks for creating this nice tool and to be open to discuss about it :)

@glehmann Sorry for my very late response! I was getting busy because just some work suddenly came. Let me reply to your comments...

In summary, mostly for contrast, and a bit for subjective aesthetic :)

Thank you for your clarifications.
The first point makes sense to me. I actually wanted to highlight the important things (e.g. "CrashLoopBackoff") in kubecolor, but using many colors makes it difficult. I still find some benefits on using many colors, but it looks like a tradeoff, and now I think using only 2 colors will be better.

It would be better, in order to have a good contrast between key in values, but is it possible with the few available colors?

Currently kubecolor uses some colors:

key colors

Now we are going to use cyan and yellow for this

value colors

string
number
bool
null (including "none" and "unknown")

Usually, most "value" is String type. bool and null rarely appears, so I think string should be colored neither in cyan nor yellow. (should green look better for example?)
Fortunately we still have magenta and white and red, so technically we can use them for number, bool, and null. However, red might not be good because it might look showing some "error".

I appreciate the additional color indicators for errors. If possible avoiding reds and greens that are the same shades would be helpful as I am red/green color blind. Usually if a darker green is used but a brighter/light red it's easier for me to tell the difference.

sorry @dty1er I somehow missed your comments. Here are a few snapshots to illustrate the output of kubecolor with my changes:

strings output look good to me in white, but other color would work also :)
@rothgar what do you think of the colors in the status of the first image? Are they easy enough to read? There is no green, so I hope they are easy enough to read :)

I can easily differentiate the colors in that screenshot so they LGTM

related: https://github.com/dty1er/kubecolor/discussions/61

Any chance this is going to be merged ?

This is really useful. What's holding back from merging this?

@glehmann could you rebase your PR on the latest main branch ? That will re-trigger the tests... maybe it will help the owner to merge this branch ?

closing now as it's stale.


[AKS] Namespace stuck in "Activating" state intermittently

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Create a hosted cluster on AKS
Create a project under this cluster
Create a namespace in this project using the GUI

Result:

Namespace gets stuck in "activating" state for minutes or even hours in the GUI.
Namespace is showing as "active" in AKS K8s API immediately after creation.
Namespace initialRolesPopulated status remains "Unknown" until GUI status changes to "active".
Debug logs shows continuous (backoffed) retries to ensure rolebindings.
Only a single error logged while stuck in activating state:

2019/01/23 15:23:58 [ERROR] NamespaceController pelle5 [namespace-auth] failed with : couldn't ensure binding creator-project-owner in pelle5: Delete https://***.hcp.westeurope.azmk8s.io:443/apis/rbac.authorization.k8s.io/v1/namespaces/pelle5/rolebindings/clusterrolebinding-ws4bf?timeout=30s: net/http: request canceled (Client.Timeout exceeded while awaiting headers)

Other details that may be helpful:
kubectl output:

Rancher debug log for namespace stuck in activating for 2h:
ns-activating-stuck_2h.log

Created in GUI around 13:21
Became active in GUI around 15:27

Rancher debug log for namespace activated within seconds (grep <namespace>):
ns-activating-ok.log
-> Note the repeated attempt to ensure rolebindings
Possibly related https://github.com/rancher/rancher/issues/14354
Environment information

Rancher version: v2.1.5 and v2.2.0-alpha3
Installation option: HA

Cluster information

Cluster type: AKS Hosted

This is also happening to me on v2.1.7. When adding a namespace this keeps hanging into Activating state for a while. When being patient it will become active. But this has been faster like instant.

Closing in favor of https://github.com/rancher/rancher/issues/20549


Use 3rd party service to make publishable

Is your feature request related to a problem? Please describe.
This requires making a custom app to use.
Describe the solution you'd like
Use a third-party server to forward requests to an HA instance, I'd recommend Heroku. You could use an online form to configure to route an email address to a URL.
Describe alternatives you've considered
:heavy_multiplication_x:
Additional context
:heavy_multiplication_x:

good idea to look into, however I likely won't pursue this. The app you are describing would have to know how to forward OAuth responses and events to the appropriate HA instance. I don't know enough to know how to do this securely.

I don't know that much about oath, mind giving me a summary of how the auth process works? Also here's my WIP server.

https://www.digitalocean.com/community/tutorials/an-introduction-to-oauth-2#grant-type-authorization-code
At a high level, HA initiates a request to Zoom and then redirects the user to the Zoom site to authenticate. Once authenticated, Zoom redirects back to HA, then HA sends another request back to Zoom to get the final access token used to query information. For every HA to Zoom/Zoom to HA connection this app would have to act as a proxy. I'd essentially be man in the middling the OAuth flow which doesn't seem like a good idea.
With that being said, if you do come up with a solution for this, happy to take a look and incorporate it in if it makes sense

What if the service handles the oauth and just handles the webhook calls?

Every individual account that needs to be monitored needs to go through the OAuth flow, that is how Zoom connects your user account to the custom app. 10 HA instances means 10 OAuth flows if a user is monitoring only 1 account (I am monitoring 2 so it would be 11).
What would need to happen is that we would need to create a service that proxies all of these things, stores the relationships, refreshes tokens, and forwards the webhook calls to the appropriate place when asked. We would also need to publish a single app to the Zoom Marketplace to make this work. It's much simpler for each user to set up the app once. My latest PR introduces another breaking change that requires a change to the custom Zoom app, but this should be the last breaking change I need to make, making the app creation a one time operation

Component error: zoom_automation - cannot import name 'HA_CONNECTIVITY_EVENT' from 'custom_components.zoom_automation.const' (/config/custom_components/zoom_automation/const.py)
How do I fix this error? It came up with the latest update...

Do you have an option to update again? Something weird happened with the original PR that I had to fix in a second

I think I'll skip all the oauth and just do a thanks page.

I'm not sure what you mean. If your intention is to not require users to have to create a custom Zoom app, you will need a way to complete the OAuth flow in order to connect the Zoom app you are creating for users to use to their account. You would also need to be able to refresh the token and pass that token back to HA (or pass the info back to HA needed to refresh a token) so that sensor.zoom_{name}_user_profile can refresh the data.

Never mind, I ended up doing it for account info. But it's possible to not do anything with the tokens, and just use webhook calls.

You're right that without refreshing the token, the webhooks still work, but I'm not sure if that's "forever" (e.g. they may stop working after some period of time without a refresh). Given that the instructions to create a custom app are in the README, they are pretty straight forward, and many custom and standard integrations require you to do the same thing (Google Assistant, Spotify, etc.), I don't really see a need to try to simplify the set up any further, especially since I don't know what the potential impact is.
You are welcome to keep pursuing this, and to fork this and turn it into something else, but respectfully I am fine with the integration point and will focus on other issues, like maintaining the state of the binary sensor between HA restarts.
I'll keep this open in case you have any other questions, happy to help where I can.

I've learned a lot, but I think that Zoom would decline this app because they want people to create their own app, not piggyback on another one. I'll keep the repo open.

Was browsing the release notes, found this. Any way this could be used?

As far as I can see, Home Assistant Cloud would have to own and create the Zoom app. Not sure if the are willing to do that for custom components but I can definitely look into it.

Yeah, maybe this could get added as a built-in if it had a bit of cleanup...

Can you elaborate? I'm already a maintainer for a core integration so this was written using core development standards. - as far as I can tell, this is not really far off from being accepted as a core integration from a code perspective, I may just have to eliminate some of the complexity that was added to allow for UI configuration of the client secret and key.

Mainly just that there aren't any tests, the code looks great otherwise to me.

Also YAML will need to be removed.

ah yeah that's on my TODO list re: tests. And at least for now OAuth2 flows are only supported via YAML, I had to hack around the built in logic to make UI configuration work. Talked to the core team about it and they have some ideas on a different way to configure OAuth2 via the UI but that's a future enhancement.
Anyway, appreciate the feedback!


Option to turn on/off monitor under certain conditions

Title explains the idea. I want MagicMirror to run off the monitor when not in use. For instance:
Between the hours of 11:30PM and 6:30AM, the monitor should be off.
If a light sensor detects the light in the room is below a certain point, MagicMirror should turn off the monitor.

The idea is to save power, and limit light emission when setup in a bedroom. Is something like this possible?
Thanks!

Hi, this is possible with a few modules that you can find here probably: https://kristjanesperanto.github.io/MagicMirror-3rd-Party-Modules/
Some motion detector modules are there that turnoff/on the screen. As for a time-based solution I dont have one from the top of my head, but shouldnt be too hard.


Help

What is the use of standalone server in examples/server.tac?

It's a node on the Kademlia network.  More nodes = more good.

how do the nodes become aware of one another?

You tell a new node just starting up about at least one other node in the network, then it can find every other node from there.

So, I want to use this DHT and setup a simple data storage system. I have set three nodes in this system by running, server.tac on three individual nodes. How do I run programs to set and get key,value from this DHT?

Look at example.py for a set/get example.  If you have any other questions, please email me.


Acceptance test optimization

We want to make this process less time-intensive. Suggestions so far:

[ ] Better document filtering
[x] Add performance analysis to the acceptance tests so we catch code changes with memory issues
[x] Remove auto-run acceptance tests in draft mode
[ ] Reuse acceptance test reports when possible. Make sure if the master artifacts are +30 days we run the validator.
[x] Fix warnings in gh action

@cka-y An out of scope question but asking since it's coming up as I'm reviewing Flex feeds: the performance test is about the amount of time it takes to parse a feed, correct? I'm wondering as well about getting stats on the number of feeds that have unparsable rows grouped by file

It's about the amount of time it takes to validate the feed including parsing time. We could look into adding stats aboute the number of feeds with unparsable errors -- shall we open an issue for that?

@cka-y Can do :) Out of scope for this iteration


fix clearSelection when single mode

about #35
please check.
https://user-images.githubusercontent.com/115578/194540971-7dd24e4f-67fb-4529-9406-ae3ee5c1e090.mov

It is only working for multi select , not for single mode.
Please check

@modeverv  thanks for the fix!


when choosing the picture from gallery and crop issue..!

when i choose the picture from the gallery and crop it
it saving on the same picture so ruining the original image

Any details?

when u crop a picture it overrides the orginal picture : it deletes the
orginal one and replace it with the crop one
On Wed, Mar 1, 2017 at 8:42 AM, Mike Lau<EMAIL_ADDRESS>wrote:

Any details?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ekimual/croperino/issues/15#issuecomment-283243273,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV3nVs10s9Ee2CfALBqbe6ZX6MlqFjv7ks5rhPcbgaJpZM4MOGu3
.

@MikeB32 Fixed in v1.1.2 :)

Donee.!
thx dude,,!
On Fri, Mar 3, 2017 at 10:23 AM, Mike Lau<EMAIL_ADDRESS>wrote:

@MikeB32 https://github.com/MikeB32 Fixed in v1.1.2 :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ekimual/croperino/issues/15#issuecomment-283876125,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV3nVoBtAeUid3cX3vFxNim1fws1wEpKks5rh7HxgaJpZM4MOGu3
.


filterVisible() not working

I am currently creating a Test to confirm the information on a webpage after filters have been applied.
Al results are shown in HTML <section> elements. On initial page-load, the <sections> get a display: block CSS property. All <section> elements are visible.
After applying the filters -  sections are filtered out - The  <section> element style is overwritten with an HTML attribute style="opacity: 1; display: none;". As a result, these sections are no longer visible on the page.
I would like to use the testcafé Selector to click only the visible results (based on there index) after applying the filter. For example: the third visible element.
Unfortunately, testcafé does not seem to distinguish hidden results from visible results.
What am I doing wrong here? Is there a workaround?
What is your Test Scenario?
// results in 'element not visible'.
await t.click('.cssSelector')
// Results in count = 7
const selector = Selector('.cssSelector').filterVisible();
console.log (await selector.count)
// Results in count = 0
const selector = Selector('.cssSelector').filterHidden();
console.log (await selector.count)
What is the Current behavior?
See above
What is the Expected behavior?
Since the HTML element has a style attribute with display: none, and computed CSS is also display: none. I would expect the filterVisible() to return only the visible elements. In regards to the count, I expected a result of 3 (since the filtered page has 3 visible sections, 4 sections are set to display: none)
What is your web application and your TestCafe test code?
Cannot share web application due to company policy.
Your Environment details:

testcafe version:
node.js version:                    <!-- 6.14.6
command-line arguments:  <!-- Testcafe runner for VSC
browser name and version: <!-- Chrome 87.0
platform and version:          <!-- Windows 10

Item can be closed. Apparently there were two scripts changing the style attribute (opacity and display). Testcafé only waited for the initial opacity change to be set. I've added an extra wait after the click on the filters. The count now results in correct amount

Item can be closed. Apparently there were two scripts changing the style attribute (opacity and display). Testcafé only waited for the initial opacity change to be set. I've added an extra wait after the click on the filters. The count now results in correct amount


Build for all possible linux architectures

Fixes #205

Checklist

[ ] Added a CHANGELOG.rst entry

@xhochy, the cibuildwheel options are currently set in pyproject.toml. It really makes sense to put it where you've put it because it needs the emulation, but it leads to the config being scattered.
If you don't mind, I can push on your branch to add a comment in the toml file saying that the archs_linux option is set in the CI workflow file.

Feel free to push. I haven't seen on how to set this otherwise.


Only run CI build on instances with Mongodb 2.4

This commit ensures that the build runs on nodes with Mongodb 2.4
installed which should fix #898.
Some of the CI 'agent' nodes on the Jenkins server run a more recent
version of mongodb. By experimenting with rebuilding on Jenkins we've
noticed that when this application's build runs on ci-agent-4, which
is configured[1] to run mongodb 3.2 it fails[2], when it runs on
ci-agent-1 through ci-agent-3 it seems to pass.
Fixes: #898
[1] https://github.com/alphagov/govuk-puppet/blob/master/hieradata/common.yaml#L639-L654
[2] https://github.com/alphagov/manuals-publisher/issues/898#issuecomment-288057880

Thanks @floehopper.


Wrong order of callbacks

Hello,
NATS documentation says, that messages from one publisher are received in the same order as they were published. But if we make few subscriptions, and publish messages for each one few times, callbacks will be called in different order. This is because each subscriber has own message queue. Here is example:
receive.py
import asyncio
from nats.aio.client import Client as NATS

async def run(loop):

    await nc.connect("nats://nats:4222", loop=loop)

    async def message_handler_A(msg):
        print('message_handler_A')

    async def message_handler_B(msg):
        print('message_handler_B')

    async def message_handler_C(msg):
        print('message_handler_C')

    await nc.subscribe("message_handler_A", cb=message_handler_A)
    await nc.subscribe("message_handler_B", cb=message_handler_B)
    await nc.subscribe("message_handler_C", cb=message_handler_C)
    print('receiving')

if __name__ == '__main__':
    nc = NATS()
    loop = asyncio.get_event_loop()
    loop.run_until_complete(run(loop))
    loop.run_forever()

publish.py:
import asyncio
from nats.aio.client import Client as NATS

async def run(loop):
    await nc.connect("nats://nats:4222", loop=loop)
    for i in range(10):
      await nc.publish("message_handler_B", b"")
      await nc.publish("message_handler_C", b"")
      await nc.publish("message_handler_A", b"")

if __name__ == '__main__':
    nc = NATS()
    loop = asyncio.get_event_loop()
    loop.run_until_complete(run(loop))
    loop.run_forever()

Just run publish.py after receive.py.

Protocol wise the message will be delivered with respective to the order in which the messages were published and asyncio will dispatch for the callback that is ready.
In your example the B messages will be delivered before C and A. If the callbacks relinquish control so that other tasks can process messages then you would see that the messages are processed in that order:
import asyncio
import logging
import time
from nats.aio.client import Client as NATS

async def run(loop):
    await nc.connect("nats://demo.nats.io:4222", loop=loop)

    async def message_handler_A(msg):
        print(f'message_handler_A: {msg}')
        await asyncio.sleep(0)

    async def message_handler_B(msg):
        print(f'message_handler_B: {msg}')
        await asyncio.sleep(0)

    async def message_handler_C(msg):
        print(f'message_handler_C: {msg}')
        await asyncio.sleep(0)

    await nc.subscribe("message_handler_A", cb=message_handler_A)
    await nc.subscribe("message_handler_B", cb=message_handler_B)
    await nc.subscribe("message_handler_C", cb=message_handler_C)
    print('receiving')

if __name__ == '__main__':
    nc = NATS()
    loop = asyncio.get_event_loop()
    loop.run_until_complete(run(loop))
    loop.run_forever()

message_handler_B: <Msg: subject='message_handler_B' reply='' data='0...'>
message_handler_C: <Msg: subject='message_handler_C' reply='' data='0...'>
message_handler_A: <Msg: subject='message_handler_A' reply='' data='0...'>
message_handler_B: <Msg: subject='message_handler_B' reply='' data='1...'>
message_handler_C: <Msg: subject='message_handler_C' reply='' data='1...'>
message_handler_A: <Msg: subject='message_handler_A' reply='' data='1...'>
message_handler_B: <Msg: subject='message_handler_B' reply='' data='2...'>
message_handler_C: <Msg: subject='message_handler_C' reply='' data='2...'>
message_handler_A: <Msg: subject='message_handler_A' reply='' data='2...'>

In my case I see following log:
message_handler_B
message_handler_B
message_handler_B
message_handler_B
message_handler_B
message_handler_B
message_handler_B
message_handler_B
message_handler_B
message_handler_B
message_handler_C
message_handler_C
message_handler_C
message_handler_C
message_handler_C
message_handler_C
message_handler_C
message_handler_C
message_handler_C
message_handler_C
message_handler_A
message_handler_A
message_handler_A
message_handler_A
message_handler_A
message_handler_A
message_handler_A
message_handler_A
message_handler_A
message_handler_A

Right, because when the B handler starts processing the messages it will continue to do so until it the event loop allows other callback to execute.  But internally the messages have been received in the same order as the source, if you relinquishing control as part of the callback using await asyncio.sleep(0) then you can opt to allow other callbacks to be able to have time to process the messages.
https://github.com/nats-io/asyncio-nats/blob/master/nats/aio/client.py#L529-L549

I found, that socket receives messages in right order, but in real case callbacks comes in random order, and it completely unusable to publish messages with different topics in loop - for example if I have two subjects - create_user and set_user_password - then often second topic comes before first, and trying to setup password to user which not created yet.

For that type of usage I'd recommend using request/response functionality from the client as it would give you a stronger ordering guarantee and better decoupling with the subscribers, sharing an example below:
Subscribers:
import asyncio
import time
from nats.aio.client import Client as NATS

async def run(loop):
    await nc.connect("nats://demo.nats.io:4222", loop=loop)

    async def create_user(msg):
        print(f'create_user      : {msg}')
        await nc.publish(msg.reply, b'user created')

    async def set_user_password(msg):
        print(f'set_user_password: {msg}')
        await nc.publish(msg.reply, b'password set')

    await nc.subscribe("create_user", cb=create_user)
    await nc.subscribe("set_user_password", cb=set_user_password)

if __name__ == '__main__':
    nc = NATS()
    loop = asyncio.get_event_loop()
    loop.run_until_complete(run(loop))
    loop.run_forever()

Publish:
import asyncio
from nats.aio.client import Client as NATS

async def run(loop):
    await nc.connect("nats://demo.nats.io:4222", loop=loop)

    for i in range(10):
        response = await nc.request("create_user", f"user:user-{i}".encode())
        print(f"Result [{i}]: {response.data.decode()}")
        response = await nc.request("set_user_password", f"password:foo".encode())
        print(f"Result [{i}]: {response.data.decode()}")

if __name__ == '__main__':
    nc = NATS()
    loop = asyncio.get_event_loop()
    loop.run_until_complete(run(loop))
    loop.run_forever()

I've found that asyncio.Lock doing job. I added lock around callbacks which should run in ordered way.

Closing for now as that is how the client is intended to work right now (similar behavior as in the Go client).


[opencolorio] OpenColorIO doesn't work

Does anyone use OpenColorIO 2.0.1?
After upgrade vcpkg, I get some CMake error messages:
CMake Error at D:/develop/vcpkg/scripts/buildsystems/vcpkg.cmake:784 (_find_package):
  Could not find a package configuration file provided by "OpenColorIO" with
  any of the following names:

    OpenColorIOConfig.cmake
    opencolorio-config.cmake

@JonLiu1993
And I found the OpenColorIOConfig.cmake was deleted in https://github.com/microsoft/vcpkg/pull/19272.
Am I wrong? In my project, import OpenColorIO by find_package(OpenColorIO CONFIG REQUIRED).

And I found the OpenColorIOConfig.cmake was deleted in #19272.

IIUC The file wasn't deleted by that PR but the portfile got simplified.
However, I fail to spot the equivalent of the former vcpkg_fixup_cmake_targets. CC @autoantwort

Hm maybe that is the issue. Because the file should be generated here

Ok but it only exists in the master branch, the latest release provides no OpenColorIOConfig.cmake file. So we can update to the latest master commit instead of using official releases or we manually patch it back in.

Good idea. Thanks a lot. @autoantwort

Try to fix this by the pull request https://github.com/microsoft/vcpkg/pull/19725.
I found new OpenColorIO v2.0.1 doesn't support the static library.

Are you sure, the pipeline for x64_windows_static is successful

Yes, I can build with the static library of OpenColorIO v1.1.1.
Build OpenColorIO v1.1.1 both x64-windows-static and x64-windows, then target_link_libraries(main PRIVATE OpenColorIO) :smile: in my project. I know that is "not correct", but it is work.


Remove the PDF20 closure, in the src/core/crypto.js file

Remove the PDF20 closure, in the src/core/crypto.js file
To allow doing this the existing helper function was changed into a "private" method instead.

Remove the unused PDF20.hash method
This method was added in PR #4938, almost nine years ago, however it doesn't appear to ever have been used.
Given the similarities between the PDF17 and PDF20 classes, and how they're used, if the PDF20.hash method was actually necessary you'd also expect a similiar method in the PDF17 class.

/botio test

Thank you for modernizing this!


Speed regression when using fetch-depth = 1

There seems to be a speed regression between using fetch-depth = 0 and fetch-depth = 1 alongside #162.
We use this action on Nixpkgs, which is a very large repository. When using v0.5.0 with fetch-depth = 0, our checkout takes ~5m, while the actual backport takes ~15s. Unexpectedly, when switching to v0.8.0 and the default fetch-depth value (1), our checkout takes ~10s, and the backport can take over 10m.
Using the logs, I've tracked the points where time is spent the most down to these three lines:
https://github.com/zeebe-io/backport-action/blob/7078123ca60e45c3452ca61d534dbd55c5319fec/src/backport.ts#L68-L69
https://github.com/zeebe-io/backport-action/blob/7078123ca60e45c3452ca61d534dbd55c5319fec/src/backport.ts#L95
which is all fetching. Is there anything that can be done to improve this? It seems weird to me that selectively fetching the history as done here can take double the time that fetching the entire history does. Thanks!

@winterqt Thanks for reporting this.
I actually don't understand how this individual fetching could take so much time. The main idea of these fetches is to solve 2 problems:

the action controls the fetched commits so it can be sure it has access to them
it only fetches what it really needs, so it should be better performing than fetch-depth: 0

Do you have the logs of such a run for me? Perhaps these shed some light on what's going on. I might also be able to use the data of an actual run to reproduce the issue locally.

Here are a few logs:

v0.0.5, which corresponds to this workflow file
v0.0.8, which corresponds to this workflow file. I assume this is what you meant by it expectedly failing?
v0.0.8 w/ default ref, which corresponds to this workflow file. I noticed that we were using a non-default ref before opening this issue, so I took a stab at it to see if it would fix anything. This took nearly 20 minutes to run 🤯

Wow, I'm really surprised about those results. It's completely the opposite of what I'd expect.
I'll need some time to dive into this. Thanks again for reporting it and collecting all this data. 🙇

are these workflow file URLs returning the page on GitHub for the file

They appear with syntax highlighting on my browser (brave)

I haven't tested it yet, but I think all that's missing is specifying a fetch depth of the fetches executed by the action. I guess currently it fetches all ancestor commits of the fetched commit but that's really unnecessary. This would explain why it takes so long :relieved:

EDIT: 🤔 I'm not sure how to determine the number of commits to fetch on the base branch (PR target), perhaps we should simply fetch 1000 commits to start. That's already a factor 400 improvement for nixpkgs. We can further improve it if a need arises.

Copied for visibility from https://github.com/zeebe-io/backport-action/pull/268#pullrequestreview-1052077581

TL;DR
We can optimize the action for fetch speed, but until then please simply clone with entire history:
- uses: actions/checkout@v3
  with:
    fetch-depth: 0

This week I've read a lot about shallow repos, and grafted commits. I've played around with some fetching strategies that could work for the backport-action. And I've thought about optimizing the action for performance on larger repos.
The current problems
At the moment, the action uses the git history to determine the relevant commits using git mergebase. This means that we need to know the entire history between the pull request's base and head refs. Currently, we simply fetch the entire history of each ref. This makes sure that all commits that we're interested in are available for the action. And this works in all cases (on pull_request and pull_request_target, as well as merge, rebase and squash scenarios). But it was a difference from before and is the reason you're now seeing this speed regression due to fetching.
In the logs you shared we see that fetching the base and head refs both take about 10 minutes while fetching the target only takes ~50s.

2022-07-25T03:39:51.7562163Z Detected labels on PR: backport backporttttttttt
2022-07-25T03:48:38.1331105Z From https://github.com/winterqt/nixpkgs
2022-07-25T03:48:38.1344220Z  * branch                    b0e7423bf3a9a1b1b2202b56c6a0975598ef969f -> FETCH_HEAD
2022-07-25T03:59:10.9378798Z From https://github.com/winterqt/nixpkgs
2022-07-25T03:59:10.9462819Z  * branch                      refs/pull/1/head -> FETCH_HEAD
2022-07-25T03:59:11.0342065Z Working on label backport backporttttttttt
2022-07-25T03:59:11.0351785Z Found target in label: backporttttttttt
2022-07-25T04:00:00.7954800Z From https://github.com/winterqt/nixpkgs
2022-07-25T04:00:00.8010867Z  * branch                      backporttttttttt -> FETCH_HEAD
2022-07-25T04:00:00.8011544Z  * [new branch]                backporttttttttt -> origin/backporttttttttt

If we don't want to fetch the entire history but use a shallow repo, then we need to fetch an arbitrary number of commits from the base branch. This number would be dependent on the repo's speed to add more commits. For large repos like Nixpkgs, the base is growing very rapidly (I think it's at ~900 commits per week for Nixpkgs now). And so this may not be the best approach anymore.
A different approach
Instead of determining the commits to cherry-pick based on the repo's history (i.e. git mergebase), we can ask GitHub to tell us about the commits on the PR. Both the REST API as well as the GraphQL API provide methods for this.

Note that these are both paged, and limited to a maximum of 250 commits (which is a limit I'm okay with)

When we know the exact commit shas, we can shallowly fetch only the relevant parts. This should provide optimal performance for repos with large histories, and doesn't negatively impact young repos.
Cloning the repo shallowly
A current design choice is that the action can backport a PR to multiple targets. This means it needs to check out each target's latest commit and then cherry-pick the relevant commits from the PR on top of it. So we cannot simply clone the target branch shallowly. So we'll need to start with the PR head.
Sadly, it is not possible with git clone to directly checkout the refs/pull/<#>/head as a branch. However, it seems possible with the checkout action, so we can look into this further optimization later on. For now, we'll need to clone the repo's default branch shallowly to get started:
git clone <URL> --depth=1

Fetch only the relevant commits to cherry-pick
Now we can fetch the relevant commits. To retrieve those, we can fetch refs/pull/<#>/head. However, if we would shallowly fetch these, then the deepest commit will be a grafted commit that contains all changes up to that point. This would effectively remove the ability to cherry-pick it because it contains many more changes than the original commit on origin.
To work around this, we can simply fetch 1 commit deeper:
git fetch origin refs/pull/#/head --depth=n+1

(for each target:) Fetch the target and cherry-pick the commits
The target can again be shallowly fetched as a grafted commit because we don't really care about that latest commit. We just want to cherry-pick on top of it.
git fetch origin <target>:<target> --depth=1
git switch -c backport-<#>-to-<target> <target>

We can verify whether the commits that we want to cherry-pick are available to use:
git cat-file -t sha1
git cat-file -t sha2
etc

And now we can cherry-pick them.
git cherry-pick -x sha1 sha2 etc

In my experiments, I was unable to cherry-pick a range of commits this way. Perhaps this is because of the grafted commits, 🤷  But for now it's fine to reference them individually. If this command becomes too long we can even cherry-pick them individually.
git cherry-pick -x sha1
git cherry-pick -x sha2
etc

What's blocking us from doing this?
The tests are too coupled to the implementation and don't really allow such a refactoring. Recently, I've been working on https://github.com/korthout/backport-action-test as a way to test only the behavior. I don't want to make the old tests work with this new way. Instead, I'd prefer to replace them with more cases in backport-action-test. Sadly these tests are still a bit brittle and slow. I hope to improve that soon.
But for now, there aren't really many test cases in place that support these changes. So we'd have to test these changes more or less in production. That may be okay, but:
Is there anything I can try in the meantime?
I think we can try to checkout the repo differently and potentially see a similar performance as v0.0.5.
If we clone with fetch-depth 0 (entire history), I think that the following fetches should complete pretty much instantly.
- uses: actions/checkout@v3
  with:
  fetch-depth: 0

@winterqt Could you please give this a try?

Firstly, thank you for all the research and work you've put into this, I greatly appreciate it.
Secondly, sure -- I assume you want me to bump the action to v0.0.8 and try that, right?

I assume you want me to bump the action to v0.0.8 and try keeping our fetch-depth at 0, right?

👍 Yes that's correct. Curious to your results 🙇

I greatly appreciate it.

❤  Thanks, that's great to hear.

It's taken me some time, but I'm happy to report that I've performed quite a lot of successful tests with a new version of the backport-action that implements the approach I described above. 🎉

That means:

a true shallow clone (1 commit deep) using:

- uses: actions/checkout@v3
  with:
    fetch-depth: 1

the action fetches only the necessary commits containing the changes (using git fetch --depth=x+1)
and fetching only a single commit for each target (using git fetch --depth=1)

I was able to test this:

as a PR created locally in the repo that is backported on pull_request[closed]

containing a single commit (automated)
containing 4 commits (manually)

as a PR created in a fork of the repo that is backported on pull_request_target[closed]

containing a single commit (automated)
containing 4 commits (manually)

@winterqt I'd love to receive some feedback on this from you. Does it really speed up the checkout and the backporting in a large project like Nixpkgs?
Please try it out by switching the checkout action's fetch-depth to 1 and using a special version of the backport action:
- uses: actions/checkout@v3
  with:
    fetch-depth: 1
- name: Backport
  uses: zeebe-io/backport-action@korthout-fetch-depth

@winterqt My team has switched to v1-rc1 to further battle-test this version before releasing v1 (see #289). We've already seen a dramatic performance boost on our repo with just 17k commits.

Backporting a pull request to 2 branches went from ~1m on v0.0.9 to just 11s on v1-rc1 in the camunda/zeebe repo 💚

https://github.com/zeebe-io/backport-action/pull/296#issuecomment-1329366746
Of course, I'm curious about the effect this release will have on Nixpkg (430k commits), but I don't recommend switching the repository to this release candidate already, as it hasn't been battle-tested yet. I just wanted to keep you in the loop.


Add "How to evolve a legacy iOS Application written in Swift"

by Tiago Martinho & Lewis Black

Thanks for this. Generally this section is for YouTube channels rather than playlists. Is the plan for this channel to be not related to iOS development after this playlist is complete? If so, I think the playlist is the right choice for the site, if not I think the channel might be better.
Thanks!
Dave

Also, I just noticed that the feed_url isn't to an RSS feed. No matter whether the link is eventually to the channel or the playlist, that will need correcting to be a valid RSS/Atom feed.

Thanks @daveverwer !
I updated the RSS feed to be the correct one.
Right now we are using my personal youtube channel, in the future we might create a dedicated one.
Thanks again for the awesome work.

I just changed the displayed name so it would fit on the site but thanks for the RSS change! Merged.


Status Tab - Edit Status Superuser

As a superuser
I want to edit/update an approved status
so that mistakes can be fixed
Acceptance Criteria
Scenario 1:
GIVEN there is an approved status and I am a superuser
WHEN I select the Edit button
THEN I see Edit Status Modal and the Description is active
Scenario 2:
GIVEN Edit status Modal is open
WHEN I click Save
THEN I see the status box update to the following:

Date
Tags ("Approved")
Status text
Clone button
Edit button

AND Status Preview would be updated based on changes

Validation Rules?
(If yes, list here)
Screenshot
(Link above will always be the most up-to-date version.)

link to prototype
https://www.figma.com/file/yZk63tFMjpuCbYLCBpo7OT/Development-(Issues%2FStatus)?type=design&node-id=4719-6702&mode=design

Hey team! Please add your planning poker estimate with Zenhub @TomChapmanGov @jadmsaadaot @saravanpa-aot

I am set to Developer level permissions but I cannot see the edit button. is it just checking for "Superuser" group?


answers to assignment 1

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
I am including my codes to the questions in assignment 1
What did you learn from the changes you have made?
How to extra data, training data, and create models
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Yes, writing these codes are not easy for me coming from a different background
How were these changes tested?
It was tested on VSCode
A reference to a related issue in your repository (if applicable)
Chatgpt
Checklist

[- ] I can confirm that my changes are working as intended

You have unfortunately made a pull request to the wrong repo. You shouldn't be making a pull request to UofT-DSI/applying_statistical_concepts, but rather your own forked applying_statistical_concepts repo. Please read the instructions on your onboarding Assignment Submission Guide more carefully.


fix(setunit): updated the code to render changes when unit is changed

Closes #2
Proposed Changes
Updated the code to rerender the weather data after making another API call when the user changes the unit.
Updated the CSS to contain the weather component within the viewport
Checklist (Check all applicable boxes)

[x] My code adheres to the project's coding style.
[ ] My changes require updates to the project's documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests have passed successfully.
[x] This PR does not contain any plagiarized content.
[x] The title of my pull request provides a brief description of the requested changes.

[ ] I am contributing independently.
[x] I am contributing for Hacktoberfest 2023.

https://github.com/ManishaSwain8/ReactToWeather/assets/109443065/fe0ed2d6-159a-4cf2-89ce-1b4c22fe62a4

@IrfanSalim  can you please make a sort video on what changes you did (no audio req) , so that it will be easier to get reviewed .

And spelling error correction is assigned to someone else, lets give chance to everyone to contribute  , just change the spelling to as it is .😂

And spelling error correction is assigned to someone else, lets give chance to everyone to contribute , just change the spelling to as it is .😂

I would have to make the changes and push again 😢

Cool ! will review it

And spelling error correction is assigned to someone else, lets give chance to everyone to contribute , just change the spelling to as it is .😂

I would have to make the changes and push again 😢

Not req, it's ok ....well everything looks cool, will review it.

Cool ! will review it

And spelling error correction is assigned to someone else, lets give chance to everyone to contribute , just change the spelling to as it is .😂

I would have to make the changes and push again 😢

Not req, it's ok ....well everything looks cool, will review it.

Sigh
Thankss 😁

Thankyou for your contribution  @IrfanSalim  !
Looking forward to more issues and collaborations.
If you learnt something from this repo make sure to ⭐ this repo.
Thankyou ,Happy coding !🚀


Compatibility for some parts of the code with PHP 8.1

I found some areas where PHP deprecation notices were being thrown due to the new stricter "Passing null to non-nullable internal function parameters is deprecated." change (https://www.php.net/releases/8.1/en.php) while using the package.
There were also issues with FluidContext requiring the \Iterator interface's enforced return types be declared in the overridden methods inside the class so I added the return types.
This does not completely port the codebase to where it ought to get to, but I didn't want to also have a fork that remained separate for things that should be included in maintaining this package.
I also bumped minimum version requirement to PHP 7.4 to ensure the compatibility with return types is available.

Thanks for the contribution. I'm closing this PR as it has been superseded by https://github.com/servo-php/fluidxml/pull/63.


Provide a graphical view of number of nodes over a period of time

Description
A graphical line with number of nodes

Customers can get a clear view as and when the node usage increases and can correlate with events

such as increased load
scaling out
deploying new workloads
among others
It also helps them keep an idea about their running costs over a period of time.
I normally use this Prometheus query sum(kubelet_node_name) in Grafana, perhaps it can be reused.

@abbi-gaurav Thank you for your request. We will try to add this to our Cluster Overview Page

The issue has been resolved in the following PRs:

1#
2#


Bump spree_core dependency from beta

Any reason why this PR was closed without merge?

Because they closed it.  It's not actually needed anyways. Feel free to resubmit if you really want.


fix(rust): fail background node creation if passed identity does not …

…exist
Closes #7625 and introduces behaviour that is consistent with one in foreground node creation.

Current behavior

Background node creation with identity shows success that is not actually true. No error is displayed to user.
Proposed changes

Having the same behaviour as foreground node creations has: check if identity exists, if not fail with proper error.
Checks

[x] All commits in this Pull Request are signed and Verified by Github.
[x] All commits in this Pull Request follow the Ockam commit message convention.
[x] There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
[x] I have read and accept the Ockam Community Code of Conduct.
[x] I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

cla accepted in https://github.com/build-trust/ockam/pull/7703

It is my first os pr, so I could miss something.

Rebased against current develop and re-pushed for making lint checks pass.

Addressed comment regarding tests.

Thanks for great first oss experience 🙏


there is some way to get the reads that belong to the plasmids..

in case I want to use them to make an assembly for example..

Hi!
Sorry - getting reads for plasmids is not what plasmidseeker does. You can look into PlasmidSPAdes that assembles plasmids (and then taking reads belonging to plasmid-assigned contigs)


Using all threads of CPU crashes the program

When I'm using all my 16 threads (so 16 progress bars) the programs crashes everytime. I have to use 12 for it to work.
Error msg:
thread 'main' panicked at 'attempt to subtract with overflow', C:\Users\mlebl.cargo\registry\src\github.com-1ecc6299db9ec823\console-0.11.3\src\windows_term.rs:152:32
I'm using mspc::channels to create my jobs.

It's not crashing on my 8 threads computer... Might by specific to my PC.


Generalize blob detection to N dimensions

The blob detection algorithm should support arbitrary dimensions, but due to the current implementation of the subpixel localization (offsets) it is limited to 2D.
offsets must be generalized to deal with arbitrary dimensions; should be relatively straightforward to generalize just by using CartesianIndices for iteration

image_moments is also hardcoded for two dimensions


dubbo app is shown in running status on dubbo admin even after it stops already.

为什么我的dubbo应用都停了，admin界面还显示在运行

Do you use the latest dubbo-admin source code, i remember this problem have been fixed. Can you reproduce by start -> stop your application? If you restart the admin ops, will the services gone?
Also, we suggest a more meaningful title clarifying your question, english for a global community.

Feel free to reopen if necessary.


[Feature] Support for Proxy Contracts

Currently, when running graph init and trying to scaffold a subgraph indexing a proxy contract, the CLI is not aware of the implementation contract. This is a big caveat for new devs since often, the first contract they want to index is indeed a proxy.
I think this is solvable at the CLI level: Detect if a contract is a proxy contract and if so, present an option to look at the current implementation contract and get the ABI from it to scaffold out the subgraph entities.
Read more about the Proxy Upgrade Pattern

graph init
✔ Protocol · ethereum
✔ Product for which to initialize · subgraph-studio
✔ Subgraph slug · test-graph-arb
✔ Directory to create the subgraph in · test-graph-arb
✔ Ethereum network · arbitrum-one
✔ Contract address · 0xec9A7fb6CbC2E41926127929c2dcE6e9c5D33Bec
✔ Fetching ABI from Etherscan
✔ Fetching Start Block
✔ Proxy contract detected. Do you want to load information from implementation at:
	  0x9B81c7C5A21E65b849FD487540B0A82d3b97b2c7?  · true
✔ Start Block · 173715445

---


Full Details View - Filtering doesn't work on editing data

Steps to reproduce:

visit https://dev.clearlydefined.io/definitions/npm/npmjs/-/async/2.6.0
Enter "MIT" in the Filelist License Filter
Verify the Filelist displays only the files with MIT licensing
Edit one of the files, and change it's license to "Aladdin" or anything else
Repeat 2.
Verify that the edited file still appears, while it shouldn't given that its license is no longer "MIT"

Let's make sure to verify if this needs to be fixed also for the other fields.

I've tested editing Facets, Licenses and Copyrights.
The only filter that's not working is Licenses

Reopen as we need #285 to be reviewed first.