[ServerSide] Render the style element at the top of the page

I have noticed that the style property is rendered at the bottom of the page:
<html>
<body>

<!-- Content -->

<style data-reactid=".joeg71lm2o.$=10=23">
  html
  {
    background: #eee;
    -webkit-font-smoothing: antialiased;
  }

  body
  {
    margin: 0;
    font-family: Roboto, sans-serif;
  }
</style>

</body>
</html>

This has some negative implication for low network connexion.
For instance, let's have a look at a 2G connexion:

Could we render the style at the top of the page?

I managed to solve the first issue by moving my <Style rules={rules} /> at the top. That's pretty simple.
However, I still have an issue with the media query that is rendered after the component.
<style data-reactid=".jh1hrvfaww.$=11">@media (min-width: 768px){ .rmq-dd97980b{font-size: 53px !important;
padding-top: 70px !important;}}
@media (min-width: 768px){ .rmq-237577dd{font-size: 26px !important;}}
@media (min-width: 768px){ .rmq-910cece9{height: 510px !important;}}
@media (min-width: 768px){ .rmq-536b985f{width: 40% !important;
margin: 0 5% !important;}}
@media (min-width: 768px){ .rmq-6ad59ba3{width: 45% !important;
max-width: 440px !important;}}</style>

I have tried the following change without any luck:
   render() {
     return (
       <div {...this.props}>
-        {this.props.children}
         <StyleSheet />
+        {this.props.children}
       </div>
     );
   }

I guess <StyleSheet /> needs to be rendered after the children.
So my workaround is to use small screen first media queries. That's where users are the most likely to have a poor connexion.


mlx_whisper: add support for audio input from stdin

Problem
I wanted to pipe an audio file to mlx_whisper, but found it only accepted file paths. This PR will allow mlx_whisper to accept stdin and pass it to ffmpeg accordingly then allow the rest of the workflow to go on as usual.
Changes

load_audio helper adjusts ffmpeg flags based on file path vs. stdin mode
CLI parser will gracefully omit the otherwise-required positional audio arg if stdin is determined to be active
optionally, --input-name arg is supported to help users name the otherwise anonymous stdin content (cannot guess from file path)
added tests in macOS standard zsh file to drive and test the changes from the CLI

Process

ran black and pre-commit on changes prior to PR
python test.py shows 4 errors, some regarding floating point comparisons. Looks very far away from my change, may be known issues.

Thanks for the addition. What do you think about a couple modifications:

For piping from stdin use - as in mlx_whisper - . That is what we do in MLX LM so it is more consistent.
The argument --input-name is confusing to me. I understand it now but I think it will in general be confusing. It might be more clear to allow an optional --output-names argument with appropriate defaults (basename when available or output when not).

For piping from stdin use - as in mlx_whisper - . That is what we do in MLX LM so it is more consistent.

Done. I agree self consistency between related projects is worth more than aesthetic preferences. This does have the nice effect of eliminating test cases.
The only tradeoff is users who reflexively think they can pipe anything into any tool will have to read the docs.

The argument --input-name is confusing to me. I understand it now but I think it will in general be confusing. It might be more clear to allow an optional --output-names argument with appropriate defaults (basename when available or output when not).

I've come around to --output-name and have proposed a "template" solution that preserves existing behavior, but also leaves room for future improvements such as fancy rename strategies based on transcribed audio content, or allows for power users to produce diff variations of output names when they use the same audio_path but use diff parameters.


[#117689133] Clarification answers date

Completes this story: https://www.pivotaltracker.com/story/show/117689133
Depends on these getting merged first:

[x] https://github.com/alphagov/digitalmarketplace-api/pull/380/files
[x] https://github.com/alphagov/digitalmarketplace-utils/pull/259

👍


ServiceEntry workloadslector can't match pods in remote clusters

Bug description
As this diagram shows, in a primary-remote multicluster deployment, a sericeEntry can't match pods in the remote cluster, resulting incomplete cds.

In our scenarios, this behavior even causes bigger problems.  Our use case is that the "primary cluster" is only used for management purposes. The Istio CRDs are managed in the primary cluster, and all the application workloads are deployed in the remote clusters.  So the CDS for ServiceEntry doesn't have any endpoints.
Affected product area (please put an X in all that apply)
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Affected features (please put an X in all that apply)
[x] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Expected behavior
ServiceEntry workloadslector should match pods in remote clusters
Steps to reproduce the bug

Install Primary-Remote multicluster deployment
Create a SericeEntry with a workloadSelector
Deploy the pod in the remote cluster
Try to access the service defined in the ServiceEntry in the mesh

Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
Istio 1.8.1
kubectl version --short
Client Version: v1.19.3
Server Version: v1.18.4-tke.6
How was Istio installed?
Environment where the bug was observed (cloud vendor, OS, etc)
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.

It has been fixed at 1.9


Add refresh system properties logic

Signed-off-by: crazyhzm<EMAIL_ADDRESS>What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #11086 (232bb3f) into 3.1 (1470c7c) will decrease coverage by 4.79%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##                3.1   #11086      +/-   ##
============================================
- Coverage     69.29%   64.49%   -4.80%
+ Complexity      124       14     -110
============================================
  Files          1471     1420      -51
  Lines         77362    59092   -18270
  Branches      13577     8674    -4903
============================================
- Hits          53606    38112   -15494
+ Misses        19067    16927    -2140
+ Partials       4689     4053     -636

Impacted Files
Coverage Δ

...pache/dubbo/common/config/SystemConfiguration.java
89.47% <88.23%> (+1.47%)
:arrow_up:

...va/org/apache/dubbo/common/config/Environment.java
80.64% <100.00%> (-0.21%)
:arrow_down:

...luster/router/script/ScriptStateRouterFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/dubbo/test/common/impl/GreetingServiceImpl.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...zookeeper/curator/CuratorZookeeperTransporter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...nfigure/DubboRelaxedBinding2AutoConfiguration.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/dubbo/test/spring/SpringXmlConfigTest.java
0.00% <0.00%> (-96.16%)
:arrow_down:

...egistrycenter/context/ZookeeperWindowsContext.java
0.00% <0.00%> (-81.82%)
:arrow_down:

...pc/cluster/router/file/FileStateRouterFactory.java
0.00% <0.00%> (-80.96%)
:arrow_down:

...ycenter/processor/KillProcessWindowsProcessor.java
10.00% <0.00%> (-80.00%)
:arrow_down:

... and 451 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[Bug]: If the risk level is set to [Apply for library permission] and [Environment], the approval process is invalid

ODC version
ODC 4.3.0-bp
OB version
No related.
What happened?
If the risk level is set to [Apply for library permission] and [Environment], the approval process is invalid.

The approval process is automatic.

What did you expect to happen?
The approval process should be effective.
How can we reproduce it (as minimally and precisely as possible)?
Follow what happened.
Anything else we need to know?
No response

pass


Error after 'from pywinauto.application import Application'

Expected Behavior
from pywinauto.application import Application
Actual Behavior
Traceback (most recent call last):
File "d:\Devel\python\lib\ctypes_init_.py", line 121, in WINFUNCTYPE
return _win_functype_cache[(restype, argtypes, flags)]
KeyError: (<class 'ctypes.HRESULT'>, (<class 'ctypes.c_long'>, <class 'comtypes.automation.tagVARIANT'>, <class 'comtypes.LP_POINTER(IUIAutomationCondition)'>), 0)
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "", line 1, in
File "d:\Devel\python\lib\site-packages\pywinauto_init_.py", line 89, in
from . import findwindows
File "d:\Devel\python\lib\site-packages\pywinauto\findwindows.py", line 42, in
from . import controls
File "d:\Devel\python\lib\site-packages\pywinauto\controls_init_.py", line 36, in
from . import uiawrapper # register "uia" back-end (at the end of uiawrapper module)
File "d:\Devel\python\lib\site-packages\pywinauto\controls\uiawrapper.py", line 47, in
from ..uia_defines import IUIA
File "d:\Devel\python\lib\site-packages\pywinauto\uia_defines.py", line 181, in
pattern_ids = _build_pattern_ids_dic()
File "d:\Devel\python\lib\site-packages\pywinauto\uia_defines.py", line 169, in _build_pattern_ids_dic
if hasattr(IUIA().ui_automation_client, cls_name):
File "d:\Devel\python\lib\site-packages\pywinauto\uia_defines.py", line 50, in call
cls._instances[cls] = super(_Singleton, cls).call(*args, **kwargs)
File "d:\Devel\python\lib\site-packages\pywinauto\uia_defines.py", line 60, in init
self.UIA_dll = comtypes.client.GetModule('UIAutomationCore.dll')
File "d:\Devel\python\lib\site-packages\comtypes\client_generate.py", line 110, in GetModule
mod = _CreateWrapper(tlib, pathname)
File "d:\Devel\python\lib\site-packages\comtypes\client_generate.py", line 184, in _CreateWrapper
mod = _my_import(fullname)
File "d:\Devel\python\lib\site-packages\comtypes\client_generate.py", line 24, in my_import
return import(fullname, globals(), locals(), ['DUMMY'])
File "d:\Devel\python\lib\site-packages\comtypes\gen_944DE083_8FB8_45CF_BCB7_C477ACB2F897_0_1_0.py", line 1870, in
( ['out', 'retval'], POINTER(POINTER(IUIAutomationElement)), 'element' )),
File "d:\Devel\python\lib\site-packages\comtypes_init.py", line 329, in setattr
self.make_methods(value)
File "d:\Devel\python\lib\site-packages\comtypes_init.py", line 698, in make_methods
prototype = WINFUNCTYPE(restype, *argtypes)
File "d:\Devel\python\lib\ctypes_init.py", line 123, in WINFUNCTYPE
class WinFunctionType(_CFuncPtr):
TypeError: item 2 in argtypes passes a union by value, which is unsupported.
Steps to Reproduce the Problem
Short Example of Code to Demonstrate the Problem
Specifications

Pywinauto version:  comtypes-1.1.7 pywin32-227 pywinauto-0.6.8 six-1.14.0
Python version and bitness: Python 3.7.6, 32bit
Platform and OS: Win 10

Had the same issue with Python 3.7.6 and 3.8.1. Issue does not occur in 3.7.5 or 3.8.
I think this will be fixed in 3.8.2 ( but not sure yet)

Yes, Python 3.7.5 does not suffer from this problem.

The issue is already tracked in #868. I'm not sure if the updated versions of Python already rolled out, though.

Yes, the fix is already reverted in CPython, but 3.8.2 is not out yet.

With Python 3.7.0 I get same error.


cell iteration

Is there any function have cell iteration for store more array of values for without specified axis

SetSheetRow writes an array to row by given worksheet name, starting coordinate, and a pointer to array type slice.


Send common command

implements generic sender object and CommonCommand sender. this is a rough sketch...
interface looks like this:
 var sender = makeCommandSender({port: port, parser: parser2})
 var res = await sender.send('CO_WR_IDBASE', 'ff800000')
 var res = await sender.send('CO_RD_IDBASE')

Syntax
send(COMMAND Code[, data [, optionalData ]])
port can be anything that implements the .write method
parser can be anything that provides a .on("data",callback) interface, that emits ESP3 RESPONSE Packets.
naming could be different f.e.:
 var comander = makeCommander({port: port, parser: parser2})
 var res = await commander.command('CO_WR_IDBASE', 'ff800000')
 var res = await commander.command('CO_RD_IDBASE')

new Syntax
var sender = SerialportSender({port: port, parser: new ESP3Parser({ maxBufferSize: 200 })})
var commander = CommonCommand.connect(sender)

there will be a WebsocketSender as well... an addition to:
commander.send('CO_RD_IDBASE')

there will be an alias for each command
commander.getVersion()
commander.sleep(100)
commander.reset()

etc.


Add support for selectively running a suite

- With the selectively running a suite support
  one can do the following to select which suite
  of tests to run:
 SUITES="simple multi" sudo -E make integration-tests
- Refactored and cleaned up some ununsed code in helpers.bash
- Added discover string parse function to parse discovery
  string into provider and address

Signed-off-by: Jana Radhakrishnan<EMAIL_ADDRESS>

LGTM

LGTM


[Feature Request / Suggestion]: Capturing of the residual stream

Suggestion / Feature Request
Hi, I'm attempting to implement the following paper in pyvene https://arxiv.org/pdf/2312.06681
The specifics of the method require capturing of the residual stream. I'm unsure if this is possible with the current library feature, but based on the documentation I saw no obvious way of doing this.
For clarity, here's transformer lens' residual cache https://github.com/neelnanda-io/TransformerLens/blob/be135a01745ab7796e8e560cf0498d5791857a93/transformer_lens/ActivationCache.py#L320
Cheers

You can target the block_output at layer $n$ to capture the residual stream after the application of the $n$-th layer. Most of the papers that use pyvene intervene on the residual stream, e.g. mine.
If you're using pyvene on a custom model architecture (i.e. not supported in the library directly), I can help you set that up too! Only ~5 lines of code.

Oh wait if you just want to collect the activations at those point, you want to use CollectActivation as one of the interventions in the config. You can find a minimal code example in pyvene 101, in the "Collect Activation" sections

Ah, then I think I'm misunderstanding something crucial. I did set up a minimal activation collection (but I thought it was missing the residual stream info)
model_name = "/home/blackroot/Desktop/ortho/Meta-Llama-3-8B-Instruct"
model = AutoModelForCausalLM.from_pretrained(
    model_name, torch_dtype=torch.bfloat16, device_map="cuda")
tokenizer = AutoTokenizer.from_pretrained(model_name)
def probing_config(layer):
    config = pv.IntervenableConfig([{
        "component": f"model.layers[{layer}].mlp.output",
        "intervention_type": pv.CollectIntervention,
    }])
    return config

    config = probing_config(15)
    pv_model = pv.IntervenableModel(config, model=model)
    ```

Was I on track that
```python
collected_activations = pv_model(base_input)[0][-1]
hidden_state = pv_model(base_input)[1][-1]

At this point it seemed like the collected activation weren't the residual stream, but I'm possibly just not understanding the returned values of the output. I suppose that brings me to the question, how can I interpret the values here, is their some resource I can into that has the structure of the values returned by pv_model(base_input)? I apologize if I'm asking a very rudimentary question.
Cheers

@CoffeeVampir3 could you try to set the
"component": f"model.layers[{layer}].output",

instead of mlp.output? since the residual stream is the whole layer component output. thanks!

Ah I see.
So given an architecture
    (layers): ModuleList(
      (0-31): 32 x LlamaDecoderLayer(
        (self_attn): LlamaSdpaAttention(
          (q_proj): Linear(in_features=4096, out_features=4096, bias=False)
          (k_proj): Linear(in_features=4096, out_features=1024, bias=False)
          (v_proj): Linear(in_features=4096, out_features=1024, bias=False)
          (o_proj): Linear(in_features=4096, out_features=4096, bias=False)
          (rotary_emb): LlamaRotaryEmbedding()
        )
        (mlp): LlamaMLP(
          (gate_proj): Linear(in_features=4096, out_features=14336, bias=False)
          (up_proj): Linear(in_features=4096, out_features=14336, bias=False)
          (down_proj): Linear(in_features=14336, out_features=4096, bias=False)
          (act_fn): SiLU()
        )
        (input_layernorm): LlamaRMSNorm()
        (post_attention_layernorm): LlamaRMSNorm()
      )
    )
    ```

    The output of `component.output` is (eg. `collected_activations = pv_model(base_input)[0][-1]`) always the terminal activation for that layer, so in this case the output of the post_attention_layernorm for layer X? Yeah, indeed I had misunderstood how the library worked. Thanks very much for the clarification, I had overcomplicated things in my mind.

Cheers!


Fix Migration Batching When Seed Data Has Non-Writable Columns (I.E. RowVersion)

Please check if the PR fulfills these requirements

[x] The code builds and tests pass (verified by our automated build checks)
[x] Commit messages follow this format
Regression from pull request #13510
Possibly Fixes #12466
Fix migration scripts when seed data has non-writable columns (i.e. rowversion)
Prior to regression, migration scripts would insert seed data in batching.
This fix restores behavior.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Code meets the expectations our engineering guidelines.
https://github.com/aspnet/AspNetCore/wiki/Engineering-guidelines

Review the guidelines for CONTRIBUTING.md for more details.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: crowet sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Remove all the processing around batch size. It does not fix #12466. This issue only stopped batching when the columns contained non-writable case not other cases. #12466 does not have non-writable column.

@smitpatel I removed the issue reference. This is certainly an issue, but I'm not sure if it has been reported before.

@crowet Thanks for your contribution!


Fix bug when getting search filters

Resolves # (issue)
Proposed changes
A None lookup was causing a KeyError. Fix is not proceeding if lookup is None.
Types of changes
What types of changes does your code introduce to DjangoTypesense?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.10%. Comparing base (599ef24) to head (fc68f58).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #82   +/-   ##
=======================================
  Coverage   77.10%   77.10%
=======================================
  Files          12       12
  Lines         594      594
=======================================
  Hits          458      458
  Misses        136      136

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Feature request: time tracking analytics/report

I personally think it would be awesome if there is a way on the web GUI side to see time spent in the last 24 hours (for either the current user or in a repository). A graph showing that with custom start/end date/time would be even better. Seems to be a wanted feature on the GitLab side, see https://gitlab.com/gitlab-org/gitlab-foss/-/issues/25532 and https://gitlab.com/gitlab-org/gitlab/-/issues/25266,

related: #8684

closing as duplicate / related to #4870


Organizations schema changes

Updates to Gallery DB schema to support Organizations

Closing... will be verified with next deployment when we manually test single organization account.


Consume switch subjects under an opaque sub-access.

This prevents the move-only checker from trying to analyze the bindings as partial consumptions, which ought to be unnecessary since SILGen will always fully consume the subject as part of forming the bindings.

@swift-ci Please test


fixes issue with backdropPressToClose not working on ios

Fixes #115
The Animated.View in renderContent blocks the backdrop entirely on iOS hence backdropPressToClose never worked on iOS.

@maxs15 I'm using your module in another iOS project so wondering if there are any plans in merging this PR soon?

+1

I also added a PR that also fixes it for android. Its basicly the same code. I only removed the ios platform check.
Why did you include the ios check anyway?

@gvlekke At the time I thought it was an iOS specific issue so didn't want to affect android as had no time to test it back then. I have removed the Platform specific check on my PR too. Thanks for letting me know. 👍

yeah np, i also merged it in my own repo https://github.com/gvlekke/react-native-modalbox/ and some other pr's

Merged


WFCORE-2836 CachedDcDomainTestCase flakyness

Test for CI & flaky logger add.

Core - Full Integration Build 4973 outcome was FAILURE using a merge of 323dd5b9af7b8ca1b85a63a03aea22c76b63dc89
Summary: Execution timeout (new); tests passed: 1302, ignored: 47 Build time: 01:25:06

Full integration - Windows Build 3400 outcome was FAILURE using a merge of 323dd5b9af7b8ca1b85a63a03aea22c76b63dc89
Summary: Execution timeout (new); tests passed: 1302, ignored: 47 Build time: 02:00:49

Odd failure here. Not sure if its related, but going to see if it happens again.

retest this please

Odd, I'll open a jira on the hang.

Core - Full Integration Build 4987 outcome was FAILURE using a merge of b8fafada110cfcff681324973118c24e0f1e59f9
Summary: Tests passed: 3909, ignored: 139; exit code 1 (new) Build time: 00:57:27

retest this please

retest this please

retest this please


Review: AI Gen Examples for numpy.linalg.svdvals function

https://github.com/numpy/numpy/compare/main...ogidig5:numpy:add-svdvals-example
Here's what reflects when the docs build:

Checks

spin build && python -m pip install . && spin docs && python tools/refguide_check.py --doctests

[ ] All tests have passed
[ ] A visual inspection of the generated docs is correct

Acceptance Criteria:

Close when the following are complete, in order:

[ ] Reviewed by @bmwoodruff
[ ] Any suggestions to fork have been merged.
[ ] Reviewed by Numpy Mainter:

When all tasks are complete:

[ ] Submitted as PR to NumPy.

Let me check the syntax of this function and make sure it runs well on the Jupyter Notebook

Viewing the docs is not the same as running the doctests with python toos/refguide_check --doctests.

I really need to quickly meet up with you. Seems I'm missing something crucial in the process. I want to work on that through the day

I've been able to figure out the authentication issue. Here's the current changes pushed to my fork: https://github.com/numpy/numpy/compare/main...ogidig5:numpy:add-svdvals-example

You'll want to update the images to be current. Just edit your original message, so the new image shows up front.
Just about everything looks good now, with one issue:

I ran the doctests, and they failed.

Did you run the tests?  In particular, did you run python tools/refguide_check.py --doctests.  You must run all the tests. This should have failed on your machine as we didn't set a seed.
The tests failed because the matrix values are random. You have to add # may vary or # random after the output , otherwise the tests will fail. This is what the relevant code could look like.
...
    array([2.05175379, 0.75852089, 0.10363495]) # may vary
...
    array([[1.59357377, 0.2369699 , 0.03501063],  # may vary
           [2.00939638, 0.39010965, 0.06555355]])
...
    array([2.35955923, 0.67914258, 0.15643921])  # may vary

Please run the doctests, and verify that the test fails before you make the change. If all you run is python tools/refguide_check.py --doctests, that isn't enough. You first have to build the docs, then install numpy, and then you can run that function. The entire string of commands you need is
spin build && python -m pip install . && spin docs && python tools/refguide_check.py --doctests && spin lint

AFTER you have verified the doctests failed, then make the change by adding # may vary. Then test them again (build numpy, install it, run the doc tests)
spin build && python -m pip install . && spin docs && python tools/refguide_check.py --doctests && spin lint

Then try changing # may vary to # random, and verify you pass the tests as well.
Glad you submitted this one. It's another thing I need to add to automation.  I'll have to add a checker to see if "random" values are entered, and then add this to the first line of output.

Here is the error message I got:

I'm going to close this one. It isn't passing the tests, and the internship has ended. I think it's just missing the # may vary tag before it will pass the tests.


Add CPPFLAGS, LDFLAGS to installation example for jsthemis on macOS

I did something simple. I took an empty project and tried to install and use jsthemis. I remembered what the problem was, reread the sources, went through the history of correspondence and here I have prepared a recipe.

I've decided to extend the case after improving the bindings.gyp for macOS case.
Most installation processes will be successful.


Can not find the Demo_China_A_share_market.ipynb

Thank you for your good work.
For some reason, I could not find the link for "Demo_China_A_share_market.ipynb".
The full link was: https://github.com/AI4Finance-Foundation/FinRL-Meta/blob/master/Demo_China_A_share_market.ipynb
Can you please provide some hints?
Thank you.

Are you looking for: https://github.com/AI4Finance-Foundation/FinRL-Meta/blob/master/tutorials/1-Introduction/China_A_share_market_tushare.ipynb

Hi @XiaoYangLiu-FinRL,
Thank you for your reply.
I am looking for a Google Colab link that contains the work from Tongji University using the DDPG algorithm.
It was available using the link: https://github.com/AI4Finance-Foundation/FinRL-Meta/blob/master/Demo_China_A_share_market.ipynb.
It looks like the link you pointed to (https://github.com/AI4Finance-Foundation/FinRL-Meta/blob/master/tutorials/1-Introduction/China_A_share_market_tushare.ipynb), but when I click the Google Colab icon from your link, it gives me the error as below image:

Please help.
Thank you again.

Hi @kabua,
Thank you for your comment.
The link https://github.com/AI4Finance-Foundation/FinRL-Meta/blob/master/tutorials/1-Introduction/China_A_share_market_tushare.ipynb) is working now.
The  Google Colab also works. I guess @ZiyiXia fixed the corrupted link.
Thank you both of you!


dart2js: Implementing Resource class

Tracking issue for the dart2js's implementation of Resource class.
See meta issue #23823

fwiw, the VM landed support for Resource today, if you're curious to have a reference.

Do we care if Resource cannot read 'package:foo/foo.dart' assets? .dart files aren't copied into the packages directory in 'pub build'.
cc @lrhn @nex3

It's not a great idea to rely on pub build's inclusion/exclusion behavior for precedent; it's been consistently not helpful for users.
The VM will support reading Dart files, so it would be nice if dart2js did as well. It's not entirely clear to me where dart2js will look for resources at runtime, though.

Do we care if Resource cannot read 'package:foo/foo.dart' assets?

The only guarantee should be: if the resource is loadable by the runtime, at runtime, it should be loaded. If a build process or a user omits a resource from their bundled/packaged deployment, that's their call.

The VM will support reading Dart files

Even in the case of a snapshot? Not sure what happens in that case.

Even in the case of a snapshot? Not sure what happens in that case.

If you stay within pub-world (that is, only run stuff in pub packages or via pub global run or a pub-created binstub) then yes, the code will be made available. If you're manually creating a snapshot and moving it around, it's up to you and your deploy process to take along any assets you need and a .packages file that says how to find them. That's as true for Dart code as it is for anything.

My main problem is deciding how to resolve 'package:' URIs at runtime. Currently I just resolve them with Uri.base.resolve('packages/$packageUri'); basically assuming the pub build structure. Should we be doing package resolution described in the .packages DEP (https://github.com/lrhn/dep-pkgspec/blob/master/DEP-pkgspec.md#resolving-package-uris) at runtime or just assuming pub build output?

Assuming pub build output won't necessarily be safe in the long term. The clear solution for users who want total control is to provide a --output-package-root flag that's a base URI used for resolving package: URLs at runtime, but what about the default case where it's not passed? I can see two options. One is to just default to interpreting the URIs relative to the entrypoint, which is historically consistent but may not make sense for all deployment scenarios; the other is to issue a static warning and fail at runtime if no configuration is provided, which is probably safest but not super friendly.

Another thing to consider: we likely don't want to expose the package-uri in the output program. Even the name of the package and it's structure can be considered internal private information for some developers. One way to address this is to place all resources next to the main output file (the name can be as simple as resourceN.extension or resource-hash.extension. Then dart2js can produce a secondary output containing a map from these URLs to the original package: urls:
resource1.txt: package:foo/bar.txt
resoruce2.png: package:my/image.png

Whoever embeds the output of dart2js can properly serve those resources by reading that map.
That's basically what we do for deferred imports when you pass the --deferred-map flag today. It was necessary in the case of deferred imports because the deferred chunks didn't have a name originally in the source program.

Please note that this has changed:
We are moving the resource lookup to a package, see https://github.com/dart-lang/sdk/issues/24463
But perhaps dart2js needs to implement these new functions? https://github.com/dart-lang/sdk/issues/19430 https://github.com/dart-lang/sdk/issues/24022

Good catch. Let's close this issue.


effects start from second time

Please post a test case showing your bug. There is a JSfiddle to fork in the readme.
http://www.softwaretestinghelp.com/how-to-write-good-bug-report/

Closed due to inactivity


Add support for deploying Config as Data UI to EKS

Add support for deploying the Config as Data UI to Amazon Elastic Kubernetes Service (EKS).

This is related to GoogleContainerTools/kpt#3480, with the exception that this is a specific request for EKS.

IAM Users/Roles would be mapped in the aws-auth ConfigMap to a Group. Then those groups can be bound to Roles and ClusterRoles. Then client would retrieve token from AWS using the KubeConfig exec in the user section like this:
- name: some-user
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1beta1
      command: aws
      args:
      - eks
      - get-token
      - --region
      - us-west-2
      - --cluster-name
      - my-cluster
      - --role-arn
      - arn:aws:iam::123456789:role/my-admin
      env:
      - name: AWS_PROFILE
        value: my-account
      interactiveMode: IfAvailable
      provideClusterInfo: false

The docs are here:

https://docs.aws.amazon.com/eks/latest/userguide/add-user-role.html


Timeout issue in I2C Polling Mode in STM32H7 while reading data.

Discussed in https://github.com/zephyrproject-rtos/zephyr/discussions/58131

Originally posted by RadhikaMaheshwari-eaton May 22, 2023
Hi Community,
I am trying to write and read data of 1 byte after the transaction of 1000 data of 1 byte through i2c_stm32_transfer() in i2c_ll_stm32.c, I am getting incorrect response (tx_data != rx_data) in I2C polling mode (controller). Is there a global buffer which is getting filled and not able to clear the contents, the pointer is stuck somewhere, or the data register is pre-occupied. What could be the possible reason? And what is the maximum no. of data bytes we can transfer in I2C Polling mode?
On further debugging we found out that there is a timeout issue in stm32_i2c_msg_read() function in i2c_ll_stm32_v2.c driver for H743 controller whereas this issue is fixed in i2c_ll_stm32_v1.c driver. Want the same configurations and specification for v2 as well.

@RadhikaMaheshwari-eaton If you have the code that help to reproduce the issue, can you share it ?
This will be much helpful as it allows to quickly reproduce, analyse and fix the issue.
Also, if you already know the fix to apply, don't hesitate to contribute directly.

Here is the code which I am using:

If we transfer 1000 data of 1 byte through this program, we get correct response in terms of written data is equal to read data.
But in second iteration if we send 1 byte of data and try to read it then i2c_stm32_msg_read() API requires time to process the query.

Like in i2c_ll_stm32_v1.c driver, we have timeout delay in the same function i2c_stm32_msg_read() for I2C polling mode. We can get reference from there.

new 1.txt
new 2.txt
Here is text version of the code and prj.conf
I am using STM32H743ZI nucleo board.


[FIX] Edit Finding's mitigated time (EDITABLE_MITIGATED_DATA)

When using "EDITABLE_MITIGATED_DATA = True", several issues are present within the DefectDojo application:

Closing a finding with a mitigation date in the past close the finding badly:

The "active" parameter is not set to false and thus, Finding does not appear at ALL in the "Closed Finding" tab 👎.
The asset(s) linked to the finding is / are not affected and remain vulnerable, even if Finding is closed 👎.

The form is added within the "Edit Finding" form, whereas there is a dedicated "Close Finding Form". Not very logical.
Calendar Box used is not the standard DefectDojo one.

The Fix contains:

Close date is added within the "Close Finding" formulary and removed from "Edit Finding", which is much more logical.
Calendar is set to the default one used in the whole app.
What do you mean by "a findings assets"?
Closing a finding with a date in the past sets also "active" to "False" and closes the linked asset. Nothing touched here, as we are now using functions of the "Close Finding" form !

Hi,
Thanks for answer:

Totally agree, active==False for me also is the correct state for a mitigated one. But in the actual usage "Edit Finding" setting a mitigation past date remain active unchanged. Thus, Finding is mitigated but does not appear in "Closed Findings". Only way I found was closing it first and then Edit again and change Mitigation Date (2 steps).
Agree also (just did not though about it), as Closed Finding could also be edited, I will put back code but with official pick date form
Code uncommented then as remaining in "Edit Finding" Form
splitdatetimefield removed from code, including html template that only this class was using.
Will have a look at the unit test, but not very familiar with so may take a while
PR (all I made) changed from master to dev, sorry for that !

Tested lot of scenarios, everything seems to work fine by now except bugs that already existed within the "Finding Edit" form. However, I don't know the framework that much and my skills do not help to resolve:

When "active" is unchecked and Mitigated Date is entered, vulnerability does not appear in "Closed Findings" page, because in the database "is_mitigated" remains False.
When "active" is unchecked and Mitigated Date is entered, linked assets remains unchanged and active.

Thanks! Could you take a look at https://github.com/DefectDojo/django-DefectDojo/issues/6078 while you're at it?

Just commited code part allowing the /api/v2/findings/{id}/close/ request with 2 parameters, is_mitigated and mitigated:

Date is timezone.now() if none is provided or EDITABLE_MITIGATED_DATA is False
Date is provided date or timezone.now() if EDITABLE_MITIGATED_DATA is true
Corresponding Endpoint status are also updated

Tell me what you think about it when you have time to review.

Not sure, but when somebody edits a finding via the API, I don't think checks are made if the user is allowed to edit the mitigated date field? I think the finding helper prevents the fields from being modified, but this is a silent action I think? Not sure as there is no testcase for the API.

Sorry, no time to check this week but I'll try on next one. For me CAN_MITIGATE_DATA was a general field (for all users or not) and then I checked if it was activated or not in order to update database. But maybe wrong ?
Will also check if I can add the mitigation date within the Edit Finding API call and not just Close call.

Hello team,
please resolve conflicts
best,
Sal

Hello team,
resolve conflict would be a nice gift for my 50th birthday (august 20th) :-)))
best,
Sal

@X0x1RG9f please resolve conflicts for @saldam72 birthday 😂

@X0x1RG9f thanks for fixing the conflicts so quickly! This is looking a lot better. The last thing from me would be some unit tests. I think this one would be a good starting place, but for findings instead

Hello, I'm working on it to make unit test successful. For now, I tested and saw one bug I did not have before with JQuery. When modifying a vulnerability, there is now a JQuery issue and so, a lot of Issues on the webpage, with impossibility to validate the form ! I don't know what's happening, so i'll check and try to push something working by the end of the day

Well,
In that case, I checked on the demo version of DefectDojo and the behaviour is similar with the JQuery issue ! So I just opened a new issue here : https://github.com/DefectDojo/django-DefectDojo/issues/6613.
Thus, not seems to be related to my code.

@Maffooch @saldam72, should be okay by now :) Just simplified a little the code on the View and added permissions for the users list displayed in the menu. About the JQuery Error, I also reproduced the issue on a fresh install and on the https://demo.defectdojo.org, so I will open a different issue. Other issues are resolved.

@Maffooch, @valentijnscholten, any idea why this remaining check is failing ? Have absolutely no idea on my side.

@X0x1RG9f Re-ran the tests and that failing one passed.  GH runners aren't 100% so sometimes a re-run is needed.

@X0x1RG9f looks like some extra commits got into your PR


Using 'setDeep' with non-nested keypaths

Problem
When using the setDeep method for keypaths that are not nested it does not work.
Example: https://svelte.technology/repl?version=1.29.3&gist=d100d0b76009d898406e21aa1406240f
One solution to the problem:
// If not a nested keypath
if ( keys[0] === undefined ) {
  const data:any = {};
  data[ lastKey ] = value;
  this.set( data );
  return;
}

The fix above have been added with a PR: https://github.com/sveltejs/svelte-extras/pull/4

#https://github.com/sveltejs/svelte-extras/pull/4


r packages rgdal and maptools have been retired and removed from CRAN

Installation of nabatr in the most up-to-date, stable version of R fails because the rgdal and maptools packages cannot be installed from CRAN. More information about the retirement of these packages is available at https://r-spatial.org/r/2022/04/12/evolution.html

We rely on this package and cannot install it anymore because of this issue.  @ennsk any chance that this can be resolved soon?

@joeledvina @abfleishman So sorry for the delay! Our up-to-date package is now hosted on gitlab. Please follow this link to install the updated package. https://code.usgs.gov/fort/nabat/nabatr
We are currently working to fix issues and improve functionality. Please feel free to submit an issue ticket under the nabatr gitlab page and I will respond as promptly as possible. The current version has the rgdal and maptools dependencies fixed.
I am working to create some documentation to direct users to the new site to avoid further confusion.

@htdavis-usgs Thank you for the update.  I just tried to submit an issue, but I could not because I do not have a USGS log in.  Please advise on how to report bugs/issues without being a USGS employee or contractor.
Thanks!
Abram

@abfleishman Hey Abram, I am working to set up an issue ticketing system for non-usgs employees. In the meantime, feel free to email me with any issues you know of and i'll make an issue ticket for it!
<EMAIL_ADDRESS>


Cannot create Method Resolution Order

Context
Tried running this program on VSCode but got error
class MyDoc(BaseDocument):
    title: str
    tensor: NdArray

a = MyDoc(title='hello', tensor=np.zeros(5), id = 1)
b = MyDoc(title='hello', tensor=np.zeros(5), id = 1)

assert a == b

Could reproduce the error when executing the program from with the following environment :
Windows 10
Conda 23.1.0
Python 3.7.9

But could not reproduce the error above in ubuntu wsl.
I think there's something wrong with metaTorchAndNode implementation.
Error :
Exception has occurred: TypeError
Cannot create a consistent method resolution
order (MRO) for bases type, ABCMeta

Hello @RStar2022 ,
are you sure to be using the branch on feat-rewritte-v2?

First, I tried using main branch, it got that error.
After I changed the branch to feat-rewrite-v2, it also got the same error.

I will close it for now, as the new version has been released.
If the error persists, please do not hesitate to reopen it again


flutter: Update to version 1.17.2

Closes #4023

Also, change the autoupdate strategy to adapt the new versioning manner while keeping the compatibility with former versioning manners.
This is implemented by just make the matching of delim and build optional and incorporate the character v in the version.

Is there a reason this isn't merged yet?
Can I install this manually until this is merged -- will it conflict when this is eventually merged?

Is there a reason this isn't merged yet?
Can I install this manually until this is merged -- will it conflict when this is eventually merged?

You might want to create a local git bare repo as a custom bucket, then you can copy this manifest into it.
say we have C:\foobar folder, we can:

cd C:\foobar
git init --bare
scoop bucket add foobar C:\foobar
copy the manifest file directly to the <your scoop home>\buckets\foobar
whether you commit and push or not, you can now install it from your own bucket.


Any way to make it work on a phone?

Hello,
Is there any way to make this work on a phone using the entire screen. Meaning, not have it act like a long touch bar, but a couple of rows on the phone instead; something that wraps around on the last widget that fits on each row. I can see this as a nice way to work with a laptop and an iPhone attached.

Yes, technically this would be possible. However, because interaction with the Touch Bar includes dragging, we've decided not to cut up the bar into pieces. This way, we keep the Touch Bar experience as close to the real Touch Bar on the new MacBook Pro.

Perhaps the bar could be scrolled, so one could drag, say, above or below it to go from one end to the other.

While the app would run on an iPhone, it's really meant for larger screens like the iPads. We have some plans for the leftover screen space (see #7), but for the time being we won't be optimizing it for iPhone use by showing only a part of the Touch Bar.
Of course, since the app is open source, you could create your own fork for an iPhone optimized version. @b-'s suggestion might turn out quite nicely.
I'm going to close this for now, as our focus is on larger screens / always showing the full Touch Bar.


'copy' not work

'copy' not work, neither in Chrome, nor in OS

Current version use document.exec("copy"), but it doesn't work. Need to find out the reason. Or, I can use 'zeroclipboard' library, github also use this (the git clone button on each repository homepage).

Find out the reason. In order to use document.execCommand("copy"), I create a hidden textarea to store the url list, but the hidden textarea can not be called by element.focus() and element.select() to get the content.

Tried 'zeroclipboard', but not work...

Finally solved... Still use the textarea, but apply another way to hide the textarea. At the first version, we set display to "none", it turns out we can't interact with the textarea any more. So I choose to move the textarea out of the viewport.


CertiCoq Pipeline plugin

This implements a plugin based on the (ML-based) certicoq-compiled certicoq pipeline. While it does run, the result that is returned is currently garbage because the Clight program that is produced again has a different representation than the one expected by the ML CertiCoq compile plugin which I'm reusing to produce C files (at least we use positive -> int and maybe a few other tricks in the current ML extraction). Probably the best way to share code is to make the certicoq plugin implementation a functor that is parametric over the exact AST of C files that is being produced and the pretty printing functions.

Well, it's worse than I thought: Coq defines bool as true | false, while ocaml has false | true, so one cannot map a CertiCoq-produced boolean to an ocaml boolean as is.

After removing all the problematic "special" case extraction directives we can finally have a working CertiCoqC plugin.
It is a variant of the CertiCoq Compile plugin using the "vanilla" extracted code from which we can adapt printClight and co to print the CertiCoq representation of C programs, and whose compilation pipeline is the C code obtained from CertiCoq Compile certicoq_pipeline. It's about 3x slower than the OCaml pipeline when run on MetaCoq's erasure (32s vs 12s) on my machine. The resulting C files are identical.
When trying to use it to compile certicoq itself, I run into a segfault after a while, seeing messages from the gc like this:
Moving value<PHONE_NUMBER>10704 with tag 108544 with 106 fields
Moving value<PHONE_NUMBER>18480 with tag 72704 with 71 fields
Moving value<PHONE_NUMBER>95200 with tag 108544 with 106 fields
Moving value<PHONE_NUMBER>05784 with tag 72704 with 71 fields
Moving value<PHONE_NUMBER>12568 with tag 108544 with 106 fields
Moving value<PHONE_NUMBER>28176 with tag 72704 with 71 fields
Moving value<PHONE_NUMBER>21632 with tag 108544 with 106 fields
Moving value<PHONE_NUMBER>70072 with tag 72704 with 71 fields
Moving value<PHONE_NUMBER>36536 with tag 108544 with 106 fields
Moving value<PHONE_NUMBER>00080 with tag 72704 with 71 fields
Moving value<PHONE_NUMBER>23704 with tag 108544 with 106 fields
Moving value<PHONE_NUMBER>98680 with tag 72704 with 71 fields
Moving value<PHONE_NUMBER>37208 with tag 108544 with 106 fields
Moving value<PHONE_NUMBER>34784 with tag 72704 with 71 fields
Moving value<PHONE_NUMBER>55152 with tag 108544 with 106 fields
Moving value<PHONE_NUMBER>26584 with tag 72704 with 71 fields
Moving value<PHONE_NUMBER>27160 with tag 108544 with 106 fields
Moving value<PHONE_NUMBER>49872 with tag 72704 with 71 fields
Moving value<PHONE_NUMBER>21176 with tag 108544 with 106 fields
Moving value<PHONE_NUMBER>43288 with tag 72704 with 71 fields
Moving value<PHONE_NUMBER>79800 with tag 108544 with 106 fields
Moving value<PHONE_NUMBER>11296 with tag 72704 with 71 fields

I don't spot a particularly big memory usage using MacOS's activity monitor (but that's not very precise).
Using CertiCoq Compile certicoq_pipeline is itself taking around 5mins, with time spent as follows:
Debug: Time elapsed in L2k:  39.527875
Debug: Time elapsed in L4:  0.167186
Debug: Time elapsed in L6 ANF:  0.713440
Debug: Time elapsed in Shrink:  0.000000
Debug: Time elapsed in Uncurry:  0.000001
Debug: Time elapsed in Inline uncurry wrappers:  0.000002
Debug: Time elapsed in Inline/shrink loop:  0.000001
Debug: Time elapsed in Shrink:  0.000001
Debug: Time elapsed in Closure conversion and hoisting:  0.000001
Debug: Time elapsed in Shrink:  0.000002
Debug: Time elapsed in Inline/shrink loop:  0.000002
Debug: Time elapsed in Dead param elim:  0.000002
Debug: Time elapsed in Shrink:  0.000001
Debug: Time elapsed in L6 Pipeline:  56.884462
Debug: Time elapsed in L7:  103.916578
Debug: Printed to file in 3.301681 s..

If you want to test it, run sh make_plugin.sh cplugin after make, then go install it using cd cplugin && make install, then cd benchmarks/certicoq_pipeline and make && make test there.

Now the timings are:
Debug: Time elapsed in L2k:  32.676889
Debug: Time elapsed in L4:  0.198038
Debug: Time elapsed in L6 ANF:  0.669820
Debug: Time elapsed in Shrink:  1.486154
Debug: Time elapsed in Uncurry:  0.137770
Debug: Time elapsed in Inline uncurry wrappers:  0.472325
Debug: Time elapsed in Inline/shrink loop:  9.761529
Debug: Time elapsed in Lambda lift:  0.803818
Debug: Time elapsed in Shrink:  0.292977
Debug: Time elapsed in Closure conversion and hoisting:  0.661199
Debug: Time elapsed in Shrink:  0.745022
Debug: Time elapsed in Inline/shrink loop:  33.440320
Debug: Time elapsed in Dead param elim:  0.374596
Debug: Time elapsed in Shrink:  0.333065
Debug: Time elapsed in L6 Pipeline:  48.513395
Debug: Time elapsed in L7:  103.389622
Debug: Printed to file in 3.305995 s..

For CertiCoq Compile certicoq_pipeline. And the CertiCoqC Compile certicoq_pileline (using the result of the first command) runs out of generations.


Change tenant mgt dependency scope to provided

Purpose

As a fix for the issue of when mocking the static methods of the Organization utils class, the test cases fails with class not found exception for the tenant management service. Having the provided scope will not cause for transitive dependencies and could resolve the class not found issues of the dependent components when mocking these classes.

This improvement did not fixed the issue mentioned above but it is better to keep these dependency in provided scope as other dependencies in the pom.xml file to avoid possible transitive dependency issues.


Submit DRF proposal to STScI - Due April 5, 2024

Funding to support @kelle's sabbatical at STScI, @dr-rodriguez time, and a Technical Writer for one year.  David is taking the lead.

This is done, right? : ) @dr-rodriguez


[INFRA] add copyright holder to license.

closes #507

FWIW linkchecker was failing due to https://opendatacommons.org/licenses/pddl/ being down indeed (code 521)

FWIW linkchecker was failing due to https://opendatacommons.org/licenses/pddl/ being down indeed (code 521)

if that happens repeatedly for the next, say 7 days, we should investigate. Else, I'd book it under "normal temporary outage"


Unable to display special characters

The preview can't display special characters like ä, é, ‘, or ’. This seems to be a font issue, considering other markdown viewers can show these characters.

Please provide a sample file for further investigation of this issue.

Just turn on the preview and you'll see what I'm talking about.
Sample file.md

This seems to be an encoding problem in n++.
With plain ANSI it looks like this:

But when I select an encoding like ISO-8859-1 everything looks fine:

Ah, that would explain it. My bad, I guess... For me, the stuff on the left still shows up properly even without specifically choosing a Western European encoding.


Avoid "Exception has occurred: System.IO.FileNotFoundException" at the application start

Fix for issue #4  in debug mode

Yes, I know that would solve the exception. BUT the real question, that I want to know, is WHY the "FileNotFoundException" occurs in the first place!? Can you reproduce it and, if yes, can you share that? (I have tried to reproduce it, but have never had a case where it occurs.)

Hi @SirJohnK
Yes. it can be easily reproduced with this sample repo.
To repro it please use VScode + .NET meteor extension. When starting it in Debug mode enable the checkmark "All Exceptions" and it will stops on the row that I have deleted

Great, I will try it out! BUT is it not strange that the file is not found? It is part of the solution. Maybe it actually is some other underlying issue...!?

It looks like the plugin is initialized faster than Resources (resx files) are loaded in. Cause after the app starts everything is working perfectly fine without any issues

Yeah, that makes sense! I have been thinking for some time to remove that line because of the reported issues.
I have a mayor update (v1.3.0) coming soon with support for using specific Resources when needed in Views/ViewModels and this could be part of that! 😃


fetch_refspecs: drop to dulwich if cred-helper is set

Codecov Report
Base: 82.74% // Head: 81.55% // Decreases project coverage by -1.20% :warning:

Coverage data is based on head (e7666db) compared to base (82d0079).
Patch coverage: 43.24% of modified lines in pull request are covered.

:exclamation: Current head e7666db differs from pull request most recent head 8b90023. Consider uploading reports for the commit 8b90023 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   82.74%   81.55%   -1.20%
==========================================
  Files          25       25
  Lines        3454     3480      +26
  Branches      595      601       +6
==========================================
- Hits         2858     2838      -20
- Misses        507      541      +34
- Partials       89      101      +12

Impacted Files
Coverage Δ

src/scmrepo/git/credentials.py
24.74% <13.63%> (ø)

src/scmrepo/git/__init__.py
84.44% <85.71%> (-0.10%)
:arrow_down:

src/scmrepo/git/backend/dulwich/client.py
62.50% <100.00%> (ø)

src/scmrepo/utils.py
67.74% <0.00%> (-19.36%)
:arrow_down:

tests/conftest.py
86.00% <0.00%> (-9.00%)
:arrow_down:

src/scmrepo/git/backend/pygit2.py
75.86% <0.00%> (-2.18%)
:arrow_down:

src/scmrepo/git/backend/gitpython.py
63.44% <0.00%> (-1.08%)
:arrow_down:

src/scmrepo/git/backend/dulwich/__init__.py
80.84% <0.00%> (-0.47%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Release new version!!!

I agree with @BataevDaniil, there are some issues fixed that have not been released yet.

@erikras?

A new release would be very helpful to us since we depend on things that have been pushed recently but have been running our own fork to work around that.

The problem is solved


How to get the select search value?

Hey I want to know what is the value of the search when there are no results.
Is there a way to know that value in this part of the code?
        language: {
            noResults: function() {
                return "No results Add new value";
            }
        },

Is there a way to know that value in this part of the code?

Nope, we don't pass this information into the renderer when there are no results.


Video not showing on Android (RN 0.60.6)

Bug
Video not showing on Android. Using react-native 0.60.6
Platform
Android
Environment info
react-native-video version: 5.1.0-alpha8
System:
    OS: macOS 10.15.7
    CPU: (4) x64 Intel(R) Core(TM) i3-8100B CPU @ 3.60GHz
    Memory: 2.06 GB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 12.9.0 - ~/.nvm/versions/node/v12.9.0/bin/node
    Yarn: 1.22.10 - /usr/local/bin/yarn
    npm: 6.10.2 - ~/.nvm/versions/node/v12.9.0/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 14.1, DriverKit 19.0, macOS 10.15, tvOS 14.0, watchOS 7.0
    Android SDK:
      API Levels: 23, 26, 28, 29, 30
      Build Tools: 28.0.3, 30.0.2
      System Images: android-30 | Google APIs Intel x86 Atom
  IDEs:
    Android Studio: 4.1 AI-201.87<IP_ADDRESS>58069
    Xcode: 12.1/12A7403 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.8.6 => 16.8.6
    react-native: 0.60.6 => 0.60.6
  npmGlobalPackages:
    react-native-cli: 2.0.1

Library version: x.x.x
Steps To Reproduce

See sample code and minimal git repo below.

Expected behaviour
Video shows
Reproducible sample code
https://github.com/joshua-augustinus/rn-training-video
const VIDEO_URL = "https://filesamples.com/samples/video/mp4/sample_1280x720.mp4";

const VideoContainer = ()=>{
    const onBuffer=()=>{}
    const videoError=()=>{}

    return (<Video source={{uri: VIDEO_URL}}

    onBuffer={onBuffer}
    onError={videoError}
    style={styles.backgroundVideo} />
)
}

export {VideoContainer}

// Later on in your styles..
var styles = StyleSheet.create({
    backgroundVideo: {
      position: 'absolute',
      top: 0,
      left: 0,
      bottom: 0,
      right: 0,
      backgroundColor:'blue'
    },
  });

Video sample
N/A

OK I think I might know the issue. Even though autolinking should work on RN 0.60 do I still need to some manual steps for Android?

Needed to do manual steps

@joshua-augustinus what are the manual steps you had to do for Android? I'm still facing this issue, but only for some videos, of certain urls. This example you posted https://filesamples.com/samples/video/mp4/sample_1280x720.mp4 still doesn't work, but some urls do work

If you go to: https://github.com/react-native-video/react-native-video
then go to Android installation there will be some manual steps listed. It is listed under: "Or if you have trouble, make the following additions to the given files manually:"
Also that video file I used takes a while to load so try waiting a fair bit.


[Additional Parameter Request] Codeunit 6620 Copy Document Mgt. - OnAfterCopySalesLineFromSalesLineBuffer

Hi Team,
In codeunit 6620 we need possibility to have additional checks in the procedure CopySalesInvLinesToDoc. Standard publisher OnAfterCopySalesLineFromSalesLineBuffer would suit us if it had additional parameter FromSalesLine: Record "Sales Line" .

[IntegrationEvent(false, false)]
local procedure OnAfterCopySalesLineFromSalesLineBuffer(var ToSalesLine: Record "Sales Line"; FromSalesInvLine: Record "Sales Invoice Line"; IncludeHeader: Boolean; RecalculateLines: Boolean; var TempDocSalesLine: Record "Sales Line" temporary; ToSalesHeader: Record "Sales Header"; FromSalesLineBuf: Record "Sales Line"; var FromSalesLine2: Record "Sales Line";FromSalesLine: Record "Sales Line")

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


How to pass the parameter processingInstanceType to the dataprocessing command?

How do you pass the parameter processingInstanceType  when using the %neptune-ml magic dataprocessing command to start a processing job?
The Notebooks   only have the below code which does not have this parameter.
processing_params = f"""
--config-file-name training-job-configuration.json
--job-id {training_job_name}
--s3-input-uri {export_results['outputS3Uri']}
--s3-processed-uri {str(s3_bucket_uri)}/preloading """

%neptune_ml dataprocessing start --wait --store-to processing_results {processing_params}

Thanks for creating this @AWS-Bassem, we should just be able to add this parameter to the dataprocessing variant of neptune_ml.
linking the sub parser that we use for those parameters for future reference when we pick this up:
https://github.com/aws/graph-notebook/blob/main/src/graph_notebook/magics/ml.py#L64

Hi @AWS-Bassem,
Support for processingInstanceType has been added in #202; you can now pass in this parameter by specifying the --instance-type option.
Closing out this issue as the requested feature has been completed; please feel free to re-open if there are any further questions or concerns.


use PT_REGS_PARM3 for retcode in inet_csk_accept

Purpose of PR?:
Fixes #1148
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Bug fix. Fixes #
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[ ] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Commit has unit tests
[ ] Commit has integration tests

@DelusionalOptimist some tests are failing


GetUpdate dosen't work in Xamarin.Android

Steps to reproduce
I wrote this code to get updates from bot:

 protected override  void OnCreate(Bundle bundle)
        {
            base.OnCreate(bundle);
            // Set our view from the "main" layout resource
             SetContentView (Resource.Layout.Main);
            bt = FindViewById<Button>(Resource.Id.button1);
            bt.Click += Bt_Click;
          bot.OnUpdate += Bot_OnUpdate;
            bot.StartReceiving();
        }
 private void Bot_OnUpdate(object sender, Telegram.Bot.Args.UpdateEventArgs e)
        {
           bot.SendTextMessageAsync(e.Update.Message.Chat.Id, "hello");
        }

but nothing happen when I send message to bot.
however  "SendTextMessageAsync" method works when I call it in "Bt_Click":
private  void Bt_Click(object sender, System.EventArgs e)
        {
             bot.SendTextMessageAsync(9116xxx3, "hello");
        }

I tried to get updates manually with this code:
var updates = bot.GetUpdatesAsync().Result;
but "updates" is null
in Application properties I chose "Sdk and User Assemblies" in linker properties and I tried with "Shared Runtime" and without it but result was same
NuGet Package Version: 10.4.0
Mono Android 7.1
IDE: VS2017
App: Android

Try this:
var task = bot.GetUpdatesAsync();
task.Wait();
var updates = task.Result;

if this is still null, try to check if there are any updates at all (enter "api.telegram.org/bot[TokenHere]/getUpdates" in your browser)


Add translucent background classes

For example, a partially transparent black or white filter

Could also have a range of filters (e.g. success, danger, warning, brand-one, etc) which would be dynamically created in the same way as backgrounds and text.

This could either be added to the background (bg--) classes, or to some kind of filter-- classes


Pull track position from MPD status()

This allows the progress bar to work when using the media-control card in lovelace.
Description:
Implemented the media_position and media_position_updated_at methods to return the position a track is at when using MPD.
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

[x] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[x] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[x] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

does this pr still need something to get merged?

Hi there, @ndonegan!
Thanks for the PR, however, there are a lot of unrelated commits in this PR. Could you please clean that up? Thanks! +1

@frenck Screwed up a rebase! Sorted now.


HC-266: remove syncer script bootstrap mechanism

Currently, the ec2 syncer script that updates CloudWatch metrics has to manually bootstrap the ASG because previously the target tracking capability needed at least one instance up in the ASG to scale up.
This PR removes that bootstrap mechanism so that the ASG can scale up immediately.
This PR was tested and verified on a NISAR dev cluster.

LGTM 👍


Add compressedLogSize, uncompressedLogSize and logEventIdx metadata to every file synchronization request.

Description
During processing of asynchronous file synchronization requests, custom metadata may be gathered at the time of submitting the synchronization request to make decisions. This commit enables the functionality to allow downstream appenders to customize the metadata that is included with every synchronization request.
Validation performed
All existing unit tests passed.

Where is logEventIdx being incremented?

In the latest commit, logEventIdx is now moved down to AbstractBufferedRollingFileAppender and incremented in the append method.


refactor: sending methods, UI

Try out this version of the Stacks Wallet - download extension builds.

What this does
This PR fixes https://github.com/blockstack/stacks-wallet-web/issues/1067. It seems that there was some issues with the way that we were keeping StacksTransactions in recoil store. Recoil serializes everything that is in an atom/selector, and I think that serialization was breaking the transaction class.
Changes & Improvements

validation has been improved on the send screen
send screen design has been improved slightly moving towards the figma designs
tickers are now displayed in the same way as the explorer
error handling now displays a toast if the transaction fails for some reason
assets now use the same kind of gradient as on the explorer
amount placeholder updates based on asset selected

Alignment of asset icons in asset list seems off - they're bottom aligned but should be vertically aligned, yeah?


NRE HandleDecoyItems

NullReferenceException
  at (wrapper managed-to-native) UnityEngine.GameObject.SetActive(UnityEngine.GameObject,bool)
  at SpaceCraft.Sector.HandleDecoyItems (System.Boolean _show) [0x00015] in <d7bd4da685134efba8f85b29870a50c9>:0
  at SpaceCraft.Sector.SceneUnLoaded (UnityEngine.AsyncOperation obj) [0x00000] in <d7bd4da685134efba8f85b29870a50c9>:0
  at UnityEngine.AsyncOperation.InvokeCompletionEvent () [0x0000f] in <a2abceb788104ee5a64f50edee6c9aef>:0

Fixed in vanilla v0.9.020.


Narrow variable type with in operator on const asserted objects

Search Terms
in operator type narrow
Suggestion
I know that we can narrow the type of the object that we're looking at if we use
if ('someKey' in someObject).
Would it be possible to narrow the type of a variable we test against a const asserted object with the in operator?
eg.
let key: string = 'asdf';

const testObj = <const>{
    a: 'someVal',
    b: 'someVal'
}

if (key in testObj){
    // key type is still string, not 'a' | 'b'
    testObj[key] // error
}

example with type unions
let key: 'a' | 'b' | 'c' = ...;

const testObj = <const>{
    a: 'someVal',
    b: 'someVal'
}

if (key in testObj){
    key // key should be 'a' | 'b'
    testObj[key] // error
}

Perhaps this can be done for non-const asserted objects as well, not sure.
Use Cases
If a variable I check with in against a const asserted object passes, then I can use that narrowed key.

Examples
See above
Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

This would be an incorrect narrowing because types aren't sealed:
function fn(x: { a: string, b: string }, y: string) {
  if (y in x) {
    const m: "a" | "b" = y;
  }
}
const obj = { a: 1, b: 2, c: 3 };
// Legal call causes value 'c' to be assigned to variable of type "a" | "b"
fn(obj, "c");

In that situation yes, the case I'm citing is when the object is used directly though - when there is nothing between when it is created with a const assertion and where it is used. i.e. a direct export const someObj
Is there another solution to check and infer a value's type against a potentially large list of keys/constants? Neither manual casting nor a large series of literal comparisons seems ideal.

Also same question regarding enums


Add a Gitter chat badge to README.md

EragonJ/Kaku now has a Chat Room on Gitter
@EragonJ has just created a chat room. You can visit it here: https://gitter.im/EragonJ/Kaku.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Thanks @gitter-badger

no worries @EragonJ, even badgers love music!

Can't believe @gitter-badger is alive xD No matter how, thanks !!


Support for environment variables when processing templates

It would be convenient if confd supported interpolation of templates by using values from environment variables. The following use cases would take advantage of this feature.

Local development on a workstation which does not have a local etcd or consul available can make use of the confd templates. When a configuration service is available, one can switch to a confd configuration that will make use of it.
Less time needed for setup and configuration if we just want testing of configuration templates. Iterating configuration templates will only require setting environment variables.

:+1: on docs

There's simple documentation at https://github.com/kelseyhightower/confd/blob/master/docs/quick-start-guide.md#environment-variables

In the documentation the example is using the "getv". For pulling Environment variables. use getenv.
Ex:
[template]
src = "myconfig.conf.tmpl"
dest = "/tmp/myconfig.conf"
keys = [
    "USER",
    "HOME",
]

[myconfig]
USER = {{getenv "USER"}}
HOME = {{getenv "HOME"}}

info in https://github.com/kelseyhightower/confd/blob/master/docs/templates.md

Can I use environment together with etcd something like fleet? because I wan to set etcd keys dynamically.
for example
[template]
src = "haproxy.cfg.tmpl"
dest = "/etc/haproxy/haproxy.cfg"
keys = [
"/${haproxy1}/apps/www/app1"
]
reload_cmd = "echo haproxy soft restarting"

AFAIK you can't use environment variables in the toml files.

Can add this as a new feature?

Sure :)

I am not a developer for go. But I try another workaround solution for that. First, I write a bash to support environment to generate the template in the folder of confd. and the confd can generate the configuration file for the applications such as haproxy. you can have a look at confd-init if you are interesting in it.

Just found this.  <3 u Kelsey Hightower.


Cron Processor

Hi,
I am looking at using this library to allow my application to support background jobs.
Some jobs will be added to the Queue and others will need to be ran on a Cron Specification.
At the moment i am struggling to correctly configure a Cron Process.
`@Processor({ name: 'store' })
export class ScheduleService {
constructor(private readonly _http: HttpService,
			private readonly _connectionManager: ConnectionManagerService,
			private readonly _sanctionService: SanctionsService) {
}

@Process({ name: 'importSanctionList' })
/*@Cron('59 23 * * *', {
	enable: true,
	key: 'importSanctionList',
	startTime: new Date(),
	// immediate: true
	// endTime: new Date(new Date().getTime() + 24 * 60 * 60 * 1000),
})*/
async importSanctionList() {
	console.log("Run importSanctionList");
}

private _parseXML(xml) : Promise<any> {
	return xml2js.parseStringPromise(xml, {
		ignoreAttrs: true,
		trim: true,
		explicitArray: false,
		normalizeTags: true
	});
}

@OnQueueActive()
onActive(job: Job) {
	console.log(
		`Processing job ${job.id} of type ${job.name} with data ${job.data}...`,
	);
}

@OnQueueEvent(BullQueueEvents.COMPLETED)
onCompleted(job: Job) {
	console.log(
		`Completed job ${job.id} of type ${job.name} with result ${job.returnvalue}`,
	);
}

}`
I need the importSanctionList function to run at midnight every day.

Hi @jphgardner02
You could try to add a repeatable job in your queue. See https://optimalbits.github.io/bull#repeatable

@fwoelffel Is there a way to add this to the @Process Decorator, or would i have to add a repeatable job everytime nestjs starts?

I haven't tried this myself, but I guess you would have to add the repeatable job everytime NestJS starts. According to Bull's documentation, the library is smart enough not to add/process the same repeatable job multiple times.


fix(Mover, Groupper): Properly prioritizing grouppers and movers in the context when they are on the same element.

When Mover and Groupper are set on the same element, they should be prioritized properly:
If the context element equals to the element which has both Mover and Groupper, Mover should be ignored. Otherwise Mover shouldn't be ignored and isGroupperFirst should be false (if there is no deeper Groupper in the context).

I don't understand the changes but I understand the test 🤷

The PR description literally tells about the change in more words than the actual change is in the code. What it is you don't understand. I can describe more.

I don't understand the changes but I understand the test 🤷

The PR description literally tells about the change in more words than the actual change is in the code. What it is you don't understand. I can describe more.

Readability is damaged. It is hard to understand what the changes are by reading the code, the code is not telling what it does by itself.

I don't understand the changes but I understand the test 🤷

Agree, I got the sensation some variables are not named in a meaningful way to carry with them what they're verifying/doing?!

Let's find out. This function computes the context.
You give it an element and it finds out if the element is inside Mover, Groupper and things like that.
Example 1:
<div mover>
  <div groupper>
    <button>Button</button>
  </div>
</div>

Example 2:
<div groupper>
  <div mover>
    <button>Button</button>
  </div>
</div>

To handle the various nested scenarios properly you need to know what is closer the button. isGroupperFirst flag will be the difference in the button's context for the example 1 and example 2. That is the meaning of that particular flag.
And after that there corner cases begin.


cassandra 5 tests

pending:

[ ] https://github.com/shotover/cassandra-test-images/pull/5 being merged will mean I can reenable the function tests
[ ] fix batch size error, seems cassandra 5 wants lower batch sizes

Lets land the absolute bare minimum first.
vectors and other cassandra 5 features can come later.
I'll review https://github.com/shotover/cassandra-test-images/pull/5/files asap

https://hub.docker.com/layers/shotover/cassandra-test/5.0-beta1-r2/images/sha256-261210443b941dc0fd9a0347cf43637c41275dfa490ff8bab072dd8777145e46?context=explore the new image is now available

Only Java user defined functions are supported in Cassandra 5. Lets merge this with the bare minimum and I'll open another PR for testing UDF in Cassandra 5.


Phys dist limit

This PR addresses issue #3
One thing I'd like to take another look at is the title of this section, but I wanted to get this in front of you sooner rather than later.
I also included this paragraph (commented) on avoiding lost particles in unsealed models using the SDF. It's probably a pretty rare scenario, but interesting to me. :)

Yeah it really does help to use this optimization in fully sealed models. It makes me wonder what it would look like when using the MPBVH...

Does this need some overarching conclusion/discussion that compares performance with this vs SDF?

Yes. There's discussion of the results but no direct conclusion about the effect and use of the two. I may have been mulling this over still. I'll add something more conclusive shortly.

Just updated @gonuke. The final sentence in the chapter is a little clumsy...

LGTM...


Develop one weather app(using html, css, js)

assign this issue i will work on it.

k, i will assign you.


Does not work with Renovate bot

When Renovate sends a pull request pull-dog does nothing
it only works when i create a pull manually

Hi @kgnfth !
I see! Did you close the issue because you solved it?

@ffMathy No

@kgnfth can you link to a pull request where it happened?

@kgnfth can you link to a pull request where it happened?

its a private repo, but i will create a demo repo right now and get back to you

@ffMathy here https://github.com/kgnfth/dogger-test/pull/1

@kgnfth it does seem there are some difficulties with the service right now. I'll check back soon!

@kgnfth it does seem there are some difficulties with the service right now. I'll fix it and check back soon!

Yes i get Gateway time-out when trying to authorize https://app.dogger.io/pull-dog/install/github?code=redacted&installation_id=16215961&setup_action=install

It should be back online now.
Can you try again? :pray:
It still doesn't work for me in your repo, but are you sure that it has been installed there? Also, does it work for pull requests that are not created by Renovate?

It should be back online now.
Can you try again? 🙏
It still doesn't work for me in your repo, but are you sure that it has been installed there? Also, does it work for pull requests that are not created by Renovate?

Hey, i tried reinstalling the app but it your site app.dogger.io gives me Gateway time-out error
but it appears its installed in the repo

Yes indeed - very perculiar. Something is causing the service to go down. I think it somehow has something to do with your user.
I'll investigate. Pull Dog has 98% code coverage, with both integration and unit tests. It has been running for several users over a course of almost a year without issues.
It's strange that this starts happening now.
Oh well, that's the life of any developer I guess.
I'll get back to you! 😄

Hmmm, it seems that for your user, for some reason, GitHub gave Pull Dog a bad auth code when redirecting.

In addition, it seems that the issues with load of the whole server (with the gateway time-out) happened when you tried to install the app on to your account.

I'll investigate further!

@ffMathy yes it happens when its trying to authorize or something..
going to bed now soo tired 😅

That's okay - no rush ^^
And thanks once again for the patience.
Do you have a lot of repositories in your account? (public and private)

Under "Installed GitHub Apps" in the GitHub settings (the screenshot you showed me), can you click "Configure", and then click "Uninstall" for Pull Dog?
And then try to install it again?

I applied some fixes which may solve the problem, if you follow the steps above.
Here's the code changes if you'd like to see them: https://github.com/dogger/app.dogger.io/pull/1060

Under "Installed GitHub Apps" in the GitHub settings (the screenshot you showed me), can you click "Configure", and then click "Uninstall" for Pull Dog?
And then try to install it again?

Hey i just uninstalled and revoked oauth and reinstalled pull-dog, but i keep getting Error 504 when authorizing
https://user-images.githubusercontent.com/73314940/115020153-77720980-9eba-11eb-9ffb-cd0d449c4a93.mp4
I really appreciate your hard work

No, thank YOU for your hard work and patience!
Hmmm that's indeed strange. How many private repositories do you have?

No, thank YOU for your hard work and patience!
Hmmm that's indeed strange. How many private repositories do you have?

Only two

@ffMathy pull-dog is working https://github.com/kgnfth/dogger-test/pull/6

Great! Then my latest fixes worked. Thanks for the report! 🙏✌


Style Y193 - Stubbing and Spying

Discuss

+1
I've used Sinon previously - good lib that will help us write tests

+1 to use Sinon; already running into places where I need it.

I don't really have anything to add to this having not used Sinon before. Happy to go with the consensus.

Cool, we'll add this then.


make PlacesSearchResult.id optional

Make PlacesSearchResult.id optional as it caused a crash when calling GoogleMapsPlaces.searchByText as the id was not there.  might solve #103 not well testet

Thanks !
Can you merge master ? It seems to be already fix here but Github does not complain and let me merge it :/

I think it was fixed in #107, so i'll just close this. Thanks for the updates :)


ci(Mergify): configuration update

This change has been made by @CEEANPROJEC from Mergify config editor.

@Mergifyio dequeue


Privileged GraphQL removal

Remove the authenticated GraphQL endpoints.

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

This PR is no longer needed.


D3Feat results on KITTI

Hi,
In the paper you report the results of D3Feat using rand and pred keypoints on the KITTI dataset, but in the original paper of D3Feat these results are not present.
Did you retrain or reimplement the code fo D3Feat to include those numbers?
Thanks

I managed to have the D3Feat code running.


Add "Messages behind" for Topics within Consumer group profile (#2542)

[ ] Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Add "Messages behind" for Topics within Consumer group profile
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

[ ] No need to
[x] Manually (please, describe, if necessary)
[ ] Unit checks
[ ] Integration checks
[ ] Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
[x] My changes generate no new warnings (e.g. Sonar is happy)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged

Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)

@Haarolean pls take a look 👀

@winnie-chiu thanks for the contribution :)


Help text doesn't mention the ability to use hex numbers.

Considering hexyl doesn't have a manpage, the --help command is the next best thing available to users. A cool feature of hexyl is that sizes and offsets can be specified in hex notation with the 0x prefix. Unfortunately, nothing in the help text appears to mention it.

Note: I'm doing a class assignment regarding creating tests (from scratch) for an open-source command line program, and I chose hexyl for it. You might have a couple more of these on the way, depending on what the assignment brings to light :)

D'oh. I obviously missed this one. Thanks!