[BugFix] Fix semi-type bugs

Fixes #issue

Fix equals binary with null check

equals method, add equals_safe parameter and update return value
before:
MySQL td> select map{'a': 1} = map{'a': null}
+--------------------------------+
| (map{'a':1}) = (map{'a':NULL}) |
+--------------------------------+
| false                          |
+--------------------------------+

now:
MySQL td> select map{'a': 1} = map{'a': null}
+--------------------------------+
| (map{'a':1}) = (map{'a':NULL}) |
+--------------------------------+
| <null>                         |
+--------------------------------+

Fix semi-type cast error message

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/common/TypeManager.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/common/TypeManager.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/common/TypeManager.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/common/TypeManager.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/common/TypeManager.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/common/TypeManager.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/common/TypeManager.java
3
3
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 3 / 3 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/common/TypeManager.java
3
3
100.00%
[]

@Mergifyio backport branch-3.1


Example of how to open share dialog on iOS

This came up recently talking to some engineers. Their question was how to present the option to share and then open the OS share dialog.

Oops. The above images are in reverse order :). /me is on mobile so I'll reorder later.

Closing in favor of https://github.com/flutter/flutter/issues/4814


toolbar refresh

what
Started with discovery as a first pass since it's most visible. AppBarLayout no longer has elevation, now has a divider whose alpha is based on how much the user has scrolled. The toolbar is only expanded when at the top of the list.
For fun, I got rid of the awkward selected state in the toolbar on pre 21 devices.
who is she

 More refresh


Remove undefined event listeners from state if disabled at runtime

Fix #581

@kurkle I didn't set the milestone because I don't know if you want to release it in 1.3.0 or before with another release

@kurkle I didn't set the milestone because I don't know if you want to release it in 1.3.0 or before with another release

We have already merged bunch of things that are marked for 1.3.0. So would need to do it in a separate branch if we wanted to release 1.2.2 for example. This is not a new bug, so I think it can be released in 1.3.0.


Media queries always on top?

I am trying to mimic some CSS in the wild that looks like this:
.main {
  padding: 20px;
}
@media (min-width: 768px) {
  .main {
    padding-right: 40px;
    padding-left: 40px;
  }
}

When in this order, browsers respect all values, but if the media queries are above, then they are not respected and they get overridden. So when I write a direct translation like:
  ".main" - (
    padding(20 px),
    &(media.minWidth(768 px)) - (
      paddingRight(40 px),
      paddingLeft(40 px)
    )
  )

It puts the media queries up top. I can't even break apart the rules to keep the media queries from going to the top. And even when I write this:
  ".main" - padding(20 px)

  "@media (min-width: 768px)" - (
    &(".main") - (
      paddingRight(40 px),
      paddingLeft(40 px)
    )
  )

I get:
.main {
  padding: 20px;
}

@media (min-width: 768px) .main {
  padding-right: 40px;
  padding-left: 40px;
}

Which is not the same as having .main nested inside. Any ideas on how to achieve my goal?

The implicit Render[String] in the Defaults does that.
https://github.com/japgolly/scalacss/blob/master/core/src/main/scala/scalacss/Renderer.scala#L26-L29
For now you could write your own implicit Render[String] that does that bit differently.
More permanently, do you think we should change the defaults to always put MQs at the bottom instead of the top?

I would suggest that the order they are in the code should be the determining factor.

Also, for the latter problem, how can I generate this:
@media (min-width: 768px) {
  .main {
    padding-right: 40px;
    padding-left: 40px;
  }
}

I can't find a way to generate that (regardless of order). Sorry to couple problems into a single issue.

I would suggest that the order they are in the code should be the determining factor.

I don't think it's wise to create an environment where order is important. In fact it's a goal that I shouldn't have to care about or consider order when I create CSS with ScalaCss.

how can I generate this:

standalone
  ".main" -
    &(media.minWidth(768 px))(
      padding.horizontal(40 px))

inline
  val inline = style("main")(
    &(media.minWidth(768 px))(
      padding.horizontal(40 px)
    )
  )

The problem is that, when building "cascading" stylesheets, order is important and it should be at the author's discretion. Granted if you are the author of the entire CSS file, you can make order less important, but as rules are combined together from disparate places around the app it might matter. An interchangeable renderer is probably good enough though.
Thanks for the snippet btw, it worked.

Hmmm, right. Cascading in stylesheets is equivalent to inheritance and I believe the disadvantages & penalties of inheritance (over composition) have well been discussed and publicised. Philosophically, I'd really like to move myself and others away from that kind of CSS, and provide tools (like conflict detection) to do so.
But as you say, it should be at the author's discretion and that's something I want to be careful not to obstruct. One should be free to use this lib however they want.
So what to do? Well, I think it'd be better to keep the default as is, merging MQs  because it's pedagogic recommendation and it produces smaller CSS. We can add an order sensitive renderer and make it opt-in. Or maybe we could make order-sensitivity the default for standalone CSS and leave the inline default as is?

Thanks for the snippet btw, it worked.
sweet :+1:

For anyone else needing this, here's a simple renderer (but you can't have Defaults._ in scope due to ambiguous implicits):
implicit val inOrderRenderer = new Renderer[String] {
  override def apply(css: Css): String = {
    val sb = new StringBuilder
    val fmt = StringRenderer.formatPretty()(sb)
    css.foreach { case CssEntry(mq, sel, content) =>
      mq.foreach(fmt.mqStart)
      fmt.selStart(mq, sel)
      fmt.kv1(mq, content.head)
      content.tail.foreach(fmt.kvn(mq, _))
      fmt.selEnd(mq, sel)
      mq.foreach(fmt.mqEnd)
    }
    fmt.done()
    sb.toString()
  }
}
implicit val env = Env.empty

The code in the repo: https://github.com/cretz/scala-web-ideal/blob/1f45cb3d71f0f0690b6b551a8d1de16f45263c57/server/src/main/scala/webideal/util/ScalaCssSupport.scala#L18

@cretz I'd recommend creating your own settings object extending one of the DevDefaults, ProdDefaults, IDefaults traits, then overriding the string renderer with your own.
object MyCssSettings extends DevDefaults {
  override implicit def stringRenderer: Renderer[String] = ???
}

// Then instead of import Defaults._
import MyCssSettings._

Closed via 6585dbf418fcccc43e822992b2c61d0f779409a2.
You can use StringRenderer.Raw.


Customizing the "nickname" field

We are using the Learn OCaml platform in a course where we need students to use their student ID number as their nickname so that we can associate their grades to them. Since there is no explanation of the nickname field on the welcome page, several have written something else in the nickname field instead. I imagine this would be a problem in any course where Learn OCaml is used.
It would be nice to have some customization of the welcome screen - at least being able to add a message at the top, or ideally to change the nickname field to say "student ID" or something similar.

We could implement that kind of customization by using as label the content of a file named "welcome-nickname-label.txt" at the root of the folder. If it is not present, the default label would appear.

I have patches for this but didn't have time to file a PR yet :)

We need to make the configuration file persist through learn-ocaml build.

Indeed!


[firebase_auth]: An error occurs when I try to access the claims of an authenticated user

Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Auth
Which platforms are affected?
Web
Description
When accessing an authenticated user's payload declarations in flutter web, I receive the following error message:
══╡ EXCEPTION CAUGHT BY FLUTTER FRAMEWORK ╞═════════════════════════════════════════════════════════
The following TypeErrorImpl was thrown:
Unexpected null value.
When the exception was thrown, this was the stack:
dart-sdk/lib/internal/js_dev_runtime/private/ddc_runtime/errors.dart 297:3       throw
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 806:18  nullCheck
packages/firebase_auth_web/firebase_auth_web.dart 81:41
dart-sdk/lib/async/zone.dart 1407:47                                              _rootRunUnary
dart-sdk/lib/async/zone.dart 1308:19                                              runUnary
dart-sdk/lib/async/zone.dart 1217:7                                               runUnaryGuarded
dart-sdk/lib/async/stream_impl.dart 339:5                                         [_sendData]
dart-sdk/lib/async/stream_impl.dart 271:7                                         [_add]
dart-sdk/lib/async/stream_pipe.dart 123:11                                        [_add]
dart-sdk/lib/async/stream_pipe.dart 218:9                                         [_handleData]
dart-sdk/lib/async/stream_pipe.dart 153:5                                         [_handleData]
dart-sdk/lib/async/zone.dart 1415:13                                              _rootRunUnary
dart-sdk/lib/async/zone.dart 1308:19                                              runUnary
dart-sdk/lib/async/zone.dart 1217:7                                               runUnaryGuarded
dart-sdk/lib/async/stream_impl.dart 339:5                                         [_sendData]
dart-sdk/lib/async/stream_impl.dart 271:7                                         [_add]
dart-sdk/lib/async/broadcast_stream_controller.dart 377:24                        [_sendData]
dart-sdk/lib/async/broadcast_stream_controller.dart 244:5                         add
packages/firebase_auth_web/src/interop/auth.dart 449:41
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 550:37  _checkAndCall
dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 555:39  dcall
https://www.gstatic.com/firebasejs/10.10.0/firebase-auth.js 1:5962
https://www.gstatic.com/firebasejs/10.10.0/firebase-auth.js 1:7102
════════════════════════════════════════════════════════════════════════════════════════════════════
══╡ EXCEPTION CAUGHT BY FLUTTER FRAMEWORK ╞═════════════════════════════════════════════════════════
The following _TypeError was thrown:
TypeError: Instance of 'LinkedMap<Object?, Object?>': type 'LinkedMap<Object?, Object?>' is not a
subtype of type 'Map<String, dynamic>'
When the exception was thrown, this was the stack:
dart-sdk/lib/internal/js_dev_runtime/private/ddc_runtime/errors.dart 297:3        throw
dart-sdk/lib/_internal/js_shared/lib/rti.dart 1385:3                               _failedAsCheck
dart-sdk/lib/_internal/js_shared/lib/rti.dart 1363:3                               _generalAsCheckImplementation
.
.
.
Reproducing the issue

I configure firebaseoptions for my project
I update firebase_core and firebase_auth: firebase_core: ^2.30.0 and firebase_auth: ^4.19.2
I log in (signInWithEmailAndPassword) and try to access the claims through the getIdTokenResult method

Firebase Core version
2.30.0
Flutter Version
3.19.5
Relevant Log Output
No response
Flutter dependencies

Expand Flutter dependencies snippet

Dart SDK 3.3.3
Flutter SDK 3.19.5
pronapp 0.76.2

dependencies:
- dartz 0.10.1
- diacritic 0.1.5
- elegant_notification 2.1.1 [flutter]
- extended_image 8.2.0 [extended_image_library flutter meta]
- file_picker 8.0.0+1 [flutter flutter_web_plugins flutter_plugin_android_lifecycle plugin_platform_interface ffi path win32 cross_file]
- firebase_analytics 10.10.2 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_auth 4.19.2 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 2.30.0 [firebase_core_platform_interface firebase_core_web flutter meta]
- fl_chart 0.67.0 [equatable flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_form_builder 9.2.1 [flutter intl]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math]
- flutter_staggered_grid_view 0.7.0 [flutter]
- form_builder_validators 9.1.0 [flutter flutter_localizations intl]
- get 4.6.6 [flutter]
- get_it 7.7.0 [async collection meta]
- go_router 13.2.4 [collection flutter flutter_web_plugins logging meta]
- google_fonts 6.2.1 [flutter http path_provider crypto]
- graphql 5.2.0-beta.7 [meta path gql gql_exec gql_link gql_http_link gql_transform_link gql_error_link gql_dedupe_link hive normalize http collection web_socket_channel stream_channel rxdart uuid]
- grpc 3.2.4 [archive async crypto fixnum googleapis_auth meta http http2 protobuf clock]
- hive 2.2.3 [meta crypto]
- hive_flutter 1.1.0 [flutter hive path_provider path]
- image_cropper 5.0.1 [flutter image_cropper_platform_interface image_cropper_for_web]
- image_network 2.5.6 [flutter http webviewimage]
- image_picker 1.1.0 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_linux image_picker_macos image_picker_platform_interface image_picker_windows]
- intl 0.19.0 [clock meta path]
- logger 2.2.0
- mask_text_input_formatter 2.9.0 [flutter]
- package_info_plus 7.0.0 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface web win32 clock]
- path_provider 2.1.3 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows]
- pdf 3.10.8 [archive barcode bidi crypto image meta path_parsing vector_math xml]
- printing 5.12.0 [ffi flutter flutter_web_plugins http image js meta pdf pdf_widget_wrapper plugin_platform_interface]
- protobuf 3.1.0 [collection fixnum meta]
- responsive_framework 0.2.0 [flutter collection]
- retry 3.1.2
- search_choices 2.2.7 [flutter]
- sentry_flutter 7.20.0 [flutter flutter_web_plugins sentry package_info_plus meta ffi]
- syncfusion_flutter_pdfviewer 24.2.8 [flutter vector_math async http uuid device_info_plus intl syncfusion_pdfviewer_platform_interface syncfusion_pdfviewer_web syncfusion_pdfviewer_macos syncfusion_pdfviewer_windows syncfusion_flutter_core syncfusion_flutter_pdf syncfusion_flutter_signaturepad url_launcher]
- universal_platform 1.0.0+1
- web 0.5.1

dev dependencies:
- build_runner 2.4.9 [analyzer args async build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- flutter_lints 3.0.2 [lints]
- flutter_test 0.0.0 [flutter test_api matcher path fake_async clock stack_trace vector_math leak_tracker_flutter_testing async boolean_selector characters collection leak_tracker leak_tracker_testing material_color_utilities meta source_span stream_channel string_scanner term_glyph vm_service]
- hive_generator 2.0.1 [build source_gen hive analyzer source_helper]
- sentry_dart_plugin 1.7.1 [yaml injector ansicolor system_info2 file http crypto convert process properties]

dependency overrides:
- intl 0.19.0 [clock meta path]

transitive dependencies:
- _fe_analyzer_shared 67.0.0 [meta]
- _flutterfire_internals 1.3.30 [collection firebase_core firebase_core_platform_interface flutter meta]
- analyzer 6.4.1 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- ansicolor 2.0.2
- archive 3.4.10 [crypto path pointycastle]
- args 2.5.0
- async 2.11.0 [collection meta]
- barcode 2.2.7 [meta qr]
- bidi 2.0.10
- boolean_selector 2.1.1 [source_span string_scanner]
- build 2.4.1 [analyzer async convert crypto glob logging meta package_config path]
- build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 4.0.1 [built_collection built_value crypto http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.4.2 [analyzer async build collection convert crypto graphs logging package_config path pool pub_semver stream_transform yaml]
- build_runner_core 7.3.0 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta package_config path pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.9.2 [built_collection collection fixnum meta]
- characters 1.3.0
- checked_yaml 2.0.3 [json_annotation source_span yaml]
- clock 1.1.1
- code_builder 4.10.0 [built_collection built_value collection matcher meta]
- collection 1.18.0
- convert 3.1.1 [typed_data]
- coverage 1.7.2 [args logging package_config path source_maps stack_trace vm_service]
- cross_file 0.3.4+1 [meta web]
- crypto 3.0.3 [typed_data]
- dart_style 2.3.6 [analyzer args collection path pub_semver source_span]
- device_info_plus 9.1.2 [device_info_plus_platform_interface ffi file flutter flutter_web_plugins meta win32 win32_registry]
- device_info_plus_platform_interface 7.0.0 [flutter meta plugin_platform_interface]
- equatable 2.0.5 [collection meta]
- extended_image_library 4.0.4 [crypto flutter http_client_helper js path path_provider web]
- fake_async 1.3.1 [clock collection]
- ffi 2.1.2
- file 7.0.0 [meta path]
- file_selector_linux 0.9.2+1 [cross_file file_selector_platform_interface flutter]
- file_selector_macos 0.9.3+3 [cross_file file_selector_platform_interface flutter]
- file_selector_platform_interface 2.6.2 [cross_file flutter http plugin_platform_interface]
- file_selector_windows 0.9.3+1 [cross_file file_selector_platform_interface flutter]
- firebase_analytics_platform_interface 3.10.3 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.5.7+2 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins]
- firebase_auth_platform_interface 7.2.3 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 5.11.2 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser meta web]
- firebase_core_platform_interface 5.0.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.15.0 [firebase_core_platform_interface flutter flutter_web_plugins meta web]
- fixnum 1.1.0
- flutter_plugin_android_lifecycle 2.0.19 [flutter]
- flutter_web_plugins 0.0.0 [flutter characters collection material_color_utilities meta vector_math]
- frontend_server_client 3.2.0 [async path]
- glob 2.1.2 [async collection file path string_scanner]
- globbing 1.0.0 [path]
- google_identity_services_web 0.3.1+1 [meta web]
- googleapis_auth 1.6.0 [args crypto google_identity_services_web http http_parser]
- gql 1.0.1-alpha+1709845491443 [collection meta source_span yaml]
- gql_dedupe_link 2.0.4-alpha+1709845491527 [async gql_exec gql_link meta]
- gql_error_link 1.0.0+1 [async gql_exec gql_link meta]
- gql_exec 1.1.1-alpha+1699813812660 [collection gql meta]
- gql_http_link 1.0.1+1 [gql gql_exec gql_link http http_parser meta]
- gql_link 1.0.1-alpha+1709845491457 [gql gql_exec meta]
- gql_transform_link 1.0.0 [gql_exec gql_link]
- graphs 2.3.1 [collection]
- http 1.2.1 [async http_parser meta web]
- http2 2.3.0
- http_client_helper 3.0.0 [http]
- http_multi_server 3.2.1 [async]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- image 4.1.7 [archive meta xml]
- image_cropper_for_web 3.0.0 [flutter flutter_web_plugins image_cropper_platform_interface js]
- image_cropper_platform_interface 5.0.0 [flutter plugin_platform_interface http]
- image_picker_android 0.8.10 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 3.0.4 [flutter flutter_web_plugins image_picker_platform_interface mime web]
- image_picker_ios 0.8.10 [flutter image_picker_platform_interface]
- image_picker_linux 0.2.1+1 [file_selector_linux file_selector_platform_interface flutter image_picker_platform_interface]
- image_picker_macos 0.2.1+1 [file_selector_macos file_selector_platform_interface flutter image_picker_platform_interface]
- image_picker_platform_interface 2.10.0 [cross_file flutter http plugin_platform_interface]
- image_picker_windows 0.2.1+1 [file_selector_platform_interface file_selector_windows flutter image_picker_platform_interface]
- injector 3.0.0
- io 1.0.4 [meta path string_scanner]
- js 0.6.7 [meta]
- json_annotation 4.8.1 [meta]
- leak_tracker 10.0.0 [clock collection meta path vm_service]
- leak_tracker_flutter_testing 2.0.1 [flutter leak_tracker leak_tracker_testing matcher meta]
- leak_tracker_testing 2.0.1 [leak_tracker matcher meta]
- lints 3.0.0
- logging 1.2.0
- matcher 0.12.16+1 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.8.0 [collection]
- meta 1.11.0
- mime 1.0.5
- node_preamble 2.0.2
- normalize 0.8.2+1 [gql collection]
- package_config 2.1.0 [path]
- package_info_plus_platform_interface 3.0.0 [flutter meta plugin_platform_interface]
- path 1.9.0
- path_parsing 1.0.1 [vector_math meta]
- path_provider_android 2.2.4 [flutter path_provider_platform_interface]
- path_provider_foundation 2.3.2 [flutter path_provider_platform_interface]
- path_provider_linux 2.2.1 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.1.2 [flutter platform plugin_platform_interface]
- path_provider_windows 2.2.1 [ffi flutter path path_provider_platform_interface win32]
- pdf_widget_wrapper 1.0.3 [flutter pdf]
- petitparser 6.0.2 [meta]
- platform 3.1.4
- plugin_platform_interface 2.1.8 [meta]
- pointer_interceptor 0.10.1 [flutter flutter_web_plugins pointer_interceptor_ios pointer_interceptor_platform_interface pointer_interceptor_web]
- pointer_interceptor_ios 0.10.0+2 [flutter plugin_platform_interface pointer_interceptor_platform_interface]
- pointer_interceptor_platform_interface 0.10.0+1 [flutter plugin_platform_interface]
- pointer_interceptor_web 0.10.2 [flutter flutter_web_plugins plugin_platform_interface pointer_interceptor_platform_interface web]
- pointycastle 3.8.0 [collection convert js]
- pool 1.5.1 [async stack_trace]
- process 5.0.2 [file path platform]
- properties 2.1.0 [meta test]
- pub_semver 2.1.4 [collection meta]
- pubspec_parse 1.2.3 [checked_yaml collection json_annotation pub_semver yaml]
- qr 3.0.1 [meta]
- rxdart 0.27.7
- sentry 7.20.0 [http meta stack_trace uuid]
- shelf 1.4.1 [async collection http_parser path stack_trace stream_channel]
- shelf_packages_handler 3.0.2 [path shelf shelf_static]
- shelf_static 1.1.2 [convert http_parser mime path shelf]
- shelf_web_socket 1.0.4 [shelf stream_channel web_socket_channel]
- sky_engine 0.0.99
- source_gen 1.5.0 [analyzer async build dart_style glob path source_span yaml]
- source_helper 1.3.4 [analyzer collection source_gen]
- source_map_stack_trace 2.1.1 [path source_maps stack_trace]
- source_maps 0.10.12 [source_span]
- source_span 1.10.0 [collection path term_glyph]
- sprintf 7.0.0
- stack_trace 1.11.1 [path]
- stream_channel 2.1.2 [async]
- stream_transform 2.1.0
- string_scanner 1.2.0 [source_span]
- syncfusion_flutter_core 24.2.9 [vector_math flutter]
- syncfusion_flutter_pdf 24.2.9 [flutter intl xml syncfusion_flutter_core crypto convert]
- syncfusion_flutter_signaturepad 24.2.9 [flutter syncfusion_flutter_core]
- syncfusion_pdfviewer_macos 24.2.9 [flutter syncfusion_pdfviewer_platform_interface]
- syncfusion_pdfviewer_platform_interface 24.2.9 [flutter plugin_platform_interface]
- syncfusion_pdfviewer_web 24.2.8 [flutter flutter_web_plugins js meta syncfusion_pdfviewer_platform_interface]
- syncfusion_pdfviewer_windows 24.2.9 [flutter]
- system_info2 4.0.0 [globbing path]
- term_glyph 1.2.1
- test 1.24.9 [analyzer async boolean_selector collection coverage http_multi_server io js matcher node_preamble package_config path pool shelf shelf_packages_handler shelf_static shelf_web_socket source_span stack_trace stream_channel test_api test_core typed_data web_socket_channel webkit_inspection_protocol yaml]
- test_api 0.6.1 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph]
- test_core 0.5.9 [analyzer args async boolean_selector collection coverage frontend_server_client glob io meta package_config path pool source_map_stack_trace source_maps source_span stack_trace stream_channel test_api vm_service yaml]
- timing 1.0.1 [json_annotation]
- typed_data 1.3.2 [collection]
- url_launcher 6.2.6 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- url_launcher_android 6.3.1 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.2.5 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.1.1 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.1.0 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.3.2 [flutter plugin_platform_interface]
- url_launcher_web 2.3.1 [flutter flutter_web_plugins url_launcher_platform_interface web]
- url_launcher_windows 3.1.1 [flutter url_launcher_platform_interface]
- uuid 4.4.0 [crypto sprintf meta fixnum]
- vector_math 2.1.4
- vm_service 13.0.0
- watcher 1.1.0 [async path]
- web_socket_channel 2.4.5 [async crypto stream_channel web]
- webkit_inspection_protocol 1.2.1 [logging]
- webview_flutter 4.7.0 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]
- webview_flutter_android 3.16.0 [flutter webview_flutter_platform_interface]
- webview_flutter_platform_interface 2.10.0 [flutter meta plugin_platform_interface]
- webview_flutter_wkwebview 3.13.0 [flutter path webview_flutter_platform_interface]
- webviewimage 0.0.6 [flutter http path pointer_interceptor uuid webview_flutter]
- win32 5.4.0 [ffi]
- win32_registry 1.1.3 [ffi win32]
- xdg_directories 1.0.4 [meta path]
- xml 6.5.0 [collection meta petitparser]
- yaml 3.1.2 [collection source_span string_scanner]

Additional context and comments
Problem similar to:
Fixes: https://github.com/firebase/flutterfire/issues/12572

@luizjunior05 - it would be helpful if you provided a code snippet on how to reproduce the bug. Thanks 🙏

I managed to solve the problem.
In flutter_auth: 4.17.8 it was working normally. But when updating I started getting the error: TypeError: Instance of 'LinkedMap<Object?, Object?>': type 'LinkedMap<Object?, Object?>' is not a subtype of type 'Map<String, dynamic>'
I identified that the error occurred when trying to read the custom claims. So I changed the type of the variable that receives the value of the custom claims from Map<String, dynamic> to Map<Object?, Object?> and it worked.
I apologize for taking up your time due to lack of more attention on my part.
Thank you for your attention @russellwheatley


Missing render library in helper

http://i.imgur.com/uLeaFx6.png

The JSON on the server is slightly experimental. I'll regenerate the JSON output when I'm back at the PC.
This JSON file is what feeds the sf helper

NVM, render is missing from actual docs at http://sf.inp.io. What even? Will investigate.


Fix duplicate params

Closes #120

Codecov Report

Merging #186 (d58fc00) into master (7347818) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #186      +/-   ##
============================================
+ Coverage     69.87%   70.01%   +0.13%
- Complexity      588      592       +4
============================================
  Files           100      100
  Lines          1932     1941       +9
  Branches        223      224       +1
============================================
+ Hits           1350     1359       +9
  Misses          484      484
  Partials         98       98

Impacted Files
Coverage Δ
Complexity Δ

.../java/seedu/address/logic/commands/AddCommand.java
100.00% <ø> (ø)
8.00 <0.00> (ø)

.../seedu/address/logic/parser/ArgumentTokenizer.java
97.87% <100.00%> (+0.50%)
13.00 <4.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7347818...d58fc00. Read the comment docs.


Fix insets

When using this plugin I noticed that when I rotate to landscape the left and right area of the app always get a zero sized inset.
With this change I get the correct inset for all of the sides of the display.

I've asked Tyler to take a moment some point of our work day today to test this change. But if he doesn't find the time then I can probably take a look myself over the weekend.
Previously it looked like we only specified system bars, so I guess that was exclusive to stuff like virtual navigation or the gesture bar but not necessary cutouts like camera pinholes or islands. Does this appear accurate in your testing @seamlink-aalves ?

@breautek , that is exactly what this PR is intended to solve.
When I rotated the device with the original plugin, I would only getting insets for the top (for statusbar height). The left and right side were always behind camera pinholes and/or islands.

@seamlink-aalves the patch is in 0.1.10
Thank you for your PR. The bug you're addressing is indeed also present in our apps.

Thank you for the quick release of the patch


Update injection to v6.4

Thank you for the contribution. It was merged directly as 2d3289e96f0a44c1569912c37e97bbac5c352c16 to keep commit history cleaner. Your contribution is still credited to you.


PDF is not render when multiple canvas instances and rotation is being applied

element.pdf
Configuration:

Web browser and its version: Firefox 107.0 (64-bit), Chrome Version 107.0.5304.110 (Official Build) (arm64)
Operating system and its version: macOS Montery 12.6
PDF.js version: 3.0.279
Is a browser extension: No

Steps to reproduce the problem:

Create a "matrix" using several canvas instances
Render the pdf partially in every single canvas
Apply rotation to the context before render the pdf item

What is the expected behavior? (add screenshot)
The whole PDF item should be properly rendered with proper rotation being applied.
What went wrong? (add screenshot)
The PDF is not being renderer in some canvases, usually the canvases in the left side

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
I have created the next jsfiddle where the problem is reproducible:
https://jsfiddle.net/fjtrujy/1b62jLgr/1/

Sorry, but we don't really support manually specifying canvas properties like that.

Please note how the getViewport method accepts a rotation argument https://github.com/mozilla/pdf.js/blob/748be3f70215817ef5e4eeeec412556fef31908c/src/display/api.js#L1049-L1062 and https://github.com/mozilla/pdf.js/blob/748be3f70215817ef5e4eeeec412556fef31908c/src/display/api.js#L1283-L1294
Furthermore, the render method also accepts a custom transform argument https://github.com/mozilla/pdf.js/blob/748be3f70215817ef5e4eeeec412556fef31908c/src/display/api.js#L1128-L1172 and https://github.com/mozilla/pdf.js/blob/748be3f70215817ef5e4eeeec412556fef31908c/src/display/api.js#L1344-L1363

That was my original approach, however, you're just supporting rotation of 0, 90, 180, 270 or 360
https://github.com/mozilla/pdf.js/blob/2d1b1e79685bc9c432395c612b6562dc76898486/src/display/display_utils.js#L181-L215
So I can't use the rotation of the GetViewportParameters

@Snuffleupagus , is there any workaround we can use in order to get a rotated PDF with 10 degrees for example? We need to render different tiles at the same time and the lack of custom rotation angles doesn't let us implement this feature, but maybe there is a workaround we can use. Thanks!

is there any workaround we can use in order to get a rotated PDF with 10 degrees for example?

Sorry, but we unfortunately don't support arbitrary rotation since that's not necessary for the default use-case (i.e. the Firefox PDF Viewer).

is there any workaround we can use in order to get a rotated PDF with 10 degrees for example?

Sorry, but we unfortunately don't support arbitrary rotation since that's not necessary for the default use-case (i.e. the Firefox PDF Viewer).

Using the transform property, will it ideally work in all the scenarios? even having rotation in that transform?
I have tried doing the next, and still is not working fine
// Render PDF page into canvas context
var renderContext = {
  canvasContext: ctx,
  viewport: viewport,
  background: "#0000FF",
  transform: [3.051900863647461, -1.2326576709747314, 1.2326576709747314, 3.051900863647461, 74.35530853271484,<PHONE_NUMBER>199219]
};
var renderTask = page.render(renderContext);

https://jsfiddle.net/fjtrujy/1b62jLgr/5/

I have improved the jsfiddle that I was using, making sure that we don't do any transform to the canvas before the PDF is render.
function renderPage(id, transform) {
	var canvas = document.getElementById(id);
  var ctx = canvas.getContext('2d');

  // Using promise to fetch the first page
  pdfDoc.getPage(1).then(function(page) {
    var viewport = page.getViewport({scale: 1.0});

    // Render PDF page into canvas context
    var renderContext = {
      canvasContext: ctx,
      viewport: viewport,
      background: "#0000FF",
      transform: transform
    };
    var renderTask = page.render(renderContext);

    // Wait for rendering to finish
    renderTask.promise.then(function() {
      console.log(`Finished rendering canvas ${canvas.id}`)
    });
  });
}

/**
 * Asynchronously downloads PDF.
 */
pdfjsLib.getDocument(url).promise.then(function(pdfDoc_) {
  pdfDoc = pdfDoc_;

  renderPage("DBB0022A-17CD-4544-81D5-CD2A3D2B0EBB", [26.22182, -10.59095, 10.59095, 26.22182, -1408.1418, 1337.1511]);
  renderPage("24F935F6-B043-4A48-ABDB-57C69CE7BEB1", [26.22182, -10.59095, 10.59095, 26.22182, -3455.1418, -709.8489]);
  renderPage("90B922A5-BA8C-4AC4-B554-3B2E00486640", [26.22182, -10.59095, 10.59095, 26.22182, -1408.1418, -709.8489]);
  renderPage("30307787-EE5C-4FDA-BD6A-0A04EE146621", [26.22182, -10.59095, 10.59095, 26.22182, 638.8582, -709.8489]);
  renderPage("B11D9151-99F0-4D34-9D55-01B7FF763613", [26.22182, -10.59095, 10.59095, 26.22182, 638.8582, 1337.1511]);
  renderPage("2AA32085-780B-4BC8-8A84-21F69205AB53", [26.22182, -10.59095, 10.59095, 26.22182, -3455.1418, 1337.1511]);
});

And the result is still the same

@Snuffleupagus, here you have the newer jsfiddle, is that still the expected behavior?
https://jsfiddle.net/fjtrujy/1b62jLgr/44/
Cheers


HtmlAgilityPack unable to parse html with

I have the following html string (simplified version of the html which is not controlled by me) -

    <title/>

      Hello How are you doing?

and I am using the following code to parse it using HtmlAgilityPack -
HtmlDocument htmlDoc = new HtmlDocument();
htmlDoc.LoadHtml(htmlStr);

but this is the value of htmlDoc.DocumentNode.InnerHtml

    <title></title>

As you can see the html was not parsed correctly.
On some trial and error I noticed that on replacing <title/> in the html string with <title></title>, the doc was parsed correctly.
Any idea/help on how to parse such html doc with HAP correctly?
Further technical details

HAP version: 1.11.17
NET version: both net472 and netcore

This looks like a bug. It's invalid HTML but not too serious as to ignore the whole body. Here's a fiddle: https://dotnetfiddle.net/CZv09l

@leus Thanks for the fiddle. Following up on this I checked with some other self-closed tags in the html and found that it kind of breaks with
 as well

      Hello World!

is parsed as

      Hello World!

Fiddle link - https://dotnetfiddle.net/VGJ1G6

Is there any solution to this bug on the horizon ?
We are experiencing this with the title tag, and it's very serious bug, since all further parsing breaks, and removes entire body.

Hello @Birgerg ,
You can remove the title behavior using the following code:
HtmlNode.ElementsFlags.Remove("title");

Fiddle: https://dotnetfiddle.net/VoXl1m
Unfortunately, the title tag requires the end of the title element. Even Firefox or Chrome put even the body in the title when there is no closing:
title_change_txt_to_html.txt
Best Regards,
Jon

You can remove the title behavior using the following code:

That workaround is hardly useful. But at least it is good to know that Chrome displays the same behaviour.


Geojsondb - add write of features.json, and readme

Generate features.json for reports
Readme for good fun

Some refactoring to add functionality.

A sample report is uploaded to s3, it's at:
https://listaging-reportsbucket-1bjqfmfwopcdd.s3-us-west-1.amazonaws.com/beta/latest/features.json
@hyperknot - is it ok for me to read the files as utf-8 when putting together the report?  The code to build the report is in this PR, and the part of the code that reads the geojson file is:
          return {
            locationID: locationIDBuilder(f),
            content: fs.readFileSync(f, 'utf-8')
          }

I downloaded the file from s3 and checked the first few entries and it looked ok, but I wasn't sure about other entries and character sets.


Validation only on Submission

Hi there!
I couldn't see any examples of form validation that occurs only after we have tried to submit a form, such is the case when we wish to check if the user is in our DB and if the inputted password is his.
Is there any way to mark the form touched only after submission?
Example:
final authForm= FormGroup({
    "username" : FormControl<String>( validators: [Validators.required],),
    "password" : FormControl<String>(validators: [Validators.required],),
  }, asyncValidators:[_isCorrectPassword("username", "password")]
  );

ReactiveForm(
          formGroup: this.authForm,
          child: Column(
            mainAxisAlignment: MainAxisAlignment.center,
            children: [
              Row(
                crossAxisAlignment: CrossAxisAlignment.center,
                mainAxisAlignment: MainAxisAlignment.center,
                children: [
                  Image.asset("Assets/images/HOLI_titleNBG.png", height: 50,),
                  SizedBox(width: 30,),
                  CustomText(text:"Dashboard", size: 50 , color: Colors.white,)
                ],
              ),
              ReactiveTextField(
                formControlName: 'username',
                decoration: InputDecoration(hintText: "Insert your Username", labelText: "Username"),
                validationMessages: (control)=> {
                  ValidationMessage.required : "The Username must not be empty",
                  'Not_Found' : 'That Username does not exist',

                },
              ),

              ReactiveTextField(
                formControlName: 'password',
                obscureText: true,
                decoration: InputDecoration(
                  labelText: 'Password',
                  hintText: 'Insert your Password!',),
                  validationMessages: (control) => {
                    ValidationMessage.required : "The password must not be empty",
                    'incorrect' : 'Your Username and password combination are incorrect'

                  }
                ),

              ReactiveFormConsumer(
                builder: (context, authForm, child) {
                  return TextButton(child: CustomText(text: "Sign In!",), onPressed: authForm.valid ? () {} : null,);
                }),
            ],
          ),)

// Async Custom Group Validator
 AsyncValidatorFunction _isCorrectPassword(String controlName, String passwordControlName){
  return (AbstractControl<dynamic> control) async  {
    final form = control as FormGroup;

    final username = form.control(controlName);
    final password = form.control(passwordControlName);
    var incorrect = false;

    for (var User in users) {
      await Future.delayed(Duration(seconds: 1)); //Simulate server request

      if (await Future.delayed(Duration(seconds: 1), () => User.username != username.value || User.password != password.value)){
        //Simulate server request, so there is time for the information to be gathered before advancing to a new code line

        password.setErrors({'incorrect' : true});
        incorrect=true;
      }else if(!incorrect){

        password.removeError('incorrect');
        return Future.value(null);
      }
  }
  };
}

P.S: I apologize for any mistakes, I am still a rookie at Flutter.
Thanks! :) Nice work!

I manage to do it like this: (Can't say if it's the best way)
ReactiveForm(
            formGroup: this.authForm,
            child: Column(
              mainAxisAlignment: MainAxisAlignment.center,
              children: [
                Row(
                  crossAxisAlignment: CrossAxisAlignment.center,
                  mainAxisAlignment: MainAxisAlignment.center,
                  children: [
                    Image.asset(
                      "Assets/images/HOLI_titleNBG.png",
                      height: 50,
                    ),
                    SizedBox(
                      width: 30,
                    ),
                    CustomText(
                      text: "Dashboard",
                      size: 50,
                      color: Colors.white,
                    )
                  ],
                ),
                ReactiveTextField(
                  formControlName: 'username',
                  decoration: InputDecoration(
                      hintText: "Insert your Username", labelText: "Username"),
                  validationMessages: (control) => {
                    ValidationMessage.required:
                        "The Username must not be empty",
                  },
                ),
                ReactiveTextField(
                    formControlName: 'password',
                    obscureText: true,
                    decoration: InputDecoration(
                      labelText: 'Password',
                      hintText: 'Insert your Password!',
                    ),
                    validationMessages: (control) => {
                          ValidationMessage.required:
                              "The password must not be empty",
                          'incorrect':
                              'Your Username and password combination are incorrect'
                        }),
                ReactiveFormConsumer(builder: (context, authForm, child) {
                  return TextButton(
                    child: CustomText(
                      text: "Sign In!",
                    ),
                    onPressed: () {
                      if (authForm.valid) {
                        // If the Form is valid (It will be valid if the _isCorrectPassword returns null)
                        Get.to(Layout());
                      } else {
                        // Otherwise it will release the error "incorrect" which will notify the user that their password or username are incorrect
                        authForm.control('password').setErrors({'incorrect': true});
                        authForm.control('password').markAsTouched(); // Makes the error visible to the user
                      }
                    },
                  );
                }),
              ],
            ),
          )

// Async Custom Group Validator
AsyncValidatorFunction _isCorrectPassword(
    String controlName, String passwordControlName) {
  return (AbstractControl<dynamic> control) async {
    final form = control as FormGroup;

    final username = form.control(controlName);
    final password = form.control(passwordControlName);
    var incorrect = false;

    for (var User in users) {
      await Future.delayed(
          Duration(milliseconds: 500)); //Simulate server request

      if (await Future.delayed( Duration (milliseconds: 500), () => User.username != username.value || User.password != password.value)) {
        // If one of these informations prompted by the user is wrong it means the user cannot log in
        //Simulate server request, so there is time for the information to be gathered before advancing to a new code line

        form.markAllAsTouched();
        incorrect = true;
      } else if (!incorrect) { //If the password and username combination is right it means the user prompted the right information

        return Future.value(null);
      }
    }
  };
}

I would not like to add anything further to this issue. So, close it at your will.

I still can't even with showErrors manage to do something similar to:
     if (_formKey.currentState!.validate()) {
           FocusScope.of(context).unfocus();
           _formKey.currentState!.save();

where on validate it checks or marks form fields as invalid if that's the case

Check this https://github.com/joanpablo/reactive_forms/issues/275#issuecomment-1207205182


Expected ENDFORM (structure) - Cause Bracket without blank

Issue:
/tmp/abaplint-CfnPNm/src/va/mv45a_msrf03.prog.abap[1, 1]                - Expected ENDFORM (structure)
Source (original SAP - mv45a_msrf03)

Tested with 2.38.14

Issue also in SAPFF001 @ 2849.

try again 2.39.0
It should now parse okay, but note that the rule https://rules.abaplint.org/parser_missing_space/ will show an error(which will probably be ignored for dependencies)

Issues resolved. New rule did not show up. Thanks.

new rules are not enabled by default, you must adjust abaplint.json to enable it, if its a rule you'd like to have enabled


Add github action for jaeger all-in-one image

Signed-off-by: Ashmita Bohara<EMAIL_ADDRESS>
Which problem is this PR solving?
This PR adds the build job of all-in-one image to github actions.
Part of https://github.com/jaegertracing/jaeger/issues/2645
Short description of the changes

To make the docker login action work we need to add two environment variables like this

To get the branch name we are using github action https://github.com/nelonoel/branch-name which populates env var BRANCH_NAME

I tried using nodejs official github action (https://github.com/actions/setup-node) instead of calling scripts/travis/install-ui-deps.sh but it didn't work and I wasn't able to make it work after several retries. So thought do it in the same way how we do in travis for now.

Until we add two environment variables, the build will fail.
Sample Success Run: https://github.com/Ashmita152/jaeger/pull/8/checks?check_run_id=1466574790

I tried using nodejs official github action (https://github.com/actions/setup-node) instead of calling scripts/travis/install-ui-deps.sh but it didn't work

Could you include some details what didn't work?
Not a big deal, I think it's fine to use scripts/travis/install-ui-deps.sh, but if you already spent some time investigating it's good to record the findings in case someone wants to try.
BTW, once we're completely off Travis, it would be nice to move scripts/travis/* to just scripts/.

Could you include some details about what didn't work?

The issue was mainly around GitHub actions install node at path /opt/hostedtoolcache/node/10.23.0/x64/bin/node so when  source /home/runner/.nvm/nvm.sh was executing it was failing with VERSION being populated as N/A and hence that script
was failing with
nvm_err 'You need to run "nvm install 10" to install it before using it.'

I felt it maybe I am missing something.

if we already know that we're running in the correct Node version, we do not need nvm use.

if we already know that we're running in the correct Node version, we do not need nvm use.

I just added this to the GitHub action. Not sure why it was triggering nvm use.
- uses: actions/setup-node@v1
  with:
    node-version: '10'

In the logs the value of BRANCH seems to be merge

Ah sorry I missed it, I should have caught it. I will make sure it's getting populated with the same value as in travis.

What is this error about? https://github.com/jaegertracing/jaeger/runs/1467144626?check_suite_focus=true#step:8:1046

fatal: No names found, cannot describe anything.

Let me look into it more.

I just added this to the GitHub action. Not sure why it was triggering nvm use.

Because in the current script nvm use is unconditional. I am suggesting to replace it with a check for Node version and fail if it does not meet the requirements

btw, I just added a workflow for the UI repo based on setup-node@v2, it's working fine: https://github.com/jaegertracing/jaeger-ui/pull/664

Updated the PR using setup-node@v2 which works now. Also the BRANCH is populating properly now.
Only issue which is remaining is what if the contributor creates PR from their fork's master branch. We can solve this by:

Appending "pr-" infront of the branch name while setting BRANCH env variable in pull request.
Updating the current logic of checking whether to push to docker registry with checking whether ${{ github.repository_owner }} variable  equal to jaegertracing

Only issue which is remaining is what if the contributor creates PR from their fork's master branch.

This has been resolved by setting an environment variable DOCKERHUB_LOGIN to true iff when docker login step succeed (which will not happen in case of PR). And docker push will only happen when DOCKERHUB_LOGIN is true.

What is this error about? https://github.com/jaegertracing/jaeger/runs/1467144626?check_suite_focus=true#step:8:1046

fatal: No names found, cannot describe anything.

I think this is what is happening, in Makefile
build-all-in-one looks for BUILD_INFO which inturn looks for GIT_CLOSEST_TAG which isn't getting evaluated properly due to fetch-depth set to 1 while cloning the repo by GitHub action.
$ git clone https://github.com/Ashmita152/jaeger.git --depth 1
Cloning into 'jaeger'...
remote: Enumerating objects: 1243, done.
remote: Counting objects: 100% (1243/1243), done.
remote: Compressing objects: 100% (1050/1050), done.
remote: Total 1243 (delta 323), reused 485 (delta 129), pack-reused 0
Receiving objects: 100% (1243/1243), 1.10 MiB | 1.10 MiB/s, done.
Resolving deltas: 100% (323/323), done.
$ cd jaeger
$ git describe --abbrev=0 --tags
fatal: No names found, cannot describe anything.

build-all-in-one looks for BUILD_INFO which in turn looks for GIT_CLOSEST_TAG

we'll need to fix this because BUILD_INFO is important to include in the binaries.

build-all-in-one looks for BUILD_INFO which in turn looks for GIT_CLOSEST_TAG

we'll need to fix this because BUILD_INFO is important to include in the binaries.

This has been resolved.

Thank you @yurishkuro for the constant help.
After the PR I was expecting one dockerhub image upload after the PR was merged but something looks wrong somewhere in the script.
I can see env variables are populated correctly
2020-11-29T20:00:51.1750375Z env:
2020-11-29T20:00:51.1750881Z   GOROOT: /opt/hostedtoolcache/go/1.15.5/x64
2020-11-29T20:00:51.1751426Z   DOCKERHUB_LOGIN: true
2020-11-29T20:00:51.1751881Z   BRANCH: master

But somehow it still skipped the upload to dockerhub
2020-11-29T20:08:03.2662939Z + upload_to_docker jaegertracing/all-in-one
2020-11-29T20:08:03.2663826Z + [[ master == \m\a\s\t\e\r ]]
2020-11-29T20:08:03.2664409Z + [[ DOCKERHUB_LOGIN == \t\r\u\e ]]
2020-11-29T20:08:03.2665960Z + echo 'skip docker upload for PR'

I will look into it more.


imageops::overlay for RGBA images is not quite correct

I'm trying to get behavior like in GIMP and I found a problem with the accuracy.
Add white background (RGBA: [255, 255, 255, 255]) for this image using GIMP and subj:
https://i.imgur.com/FzTt9Us.png
If you compare results pixel-to-pixel, you can get this difference:
https://i.imgur.com/XpmsCfP.png
While debugging, I found that result has numbers like 254.99998, after f32 => u8 it is 254. So I can add 0.001 and fix this:
impl<T: Primitive> Blend for Rgba<T> {
  fn blend(&mut self, other: &Rgba<T>) {
    /* ... */
    // Cast back to our initial type on return
    *self = Rgba([
      NumCast::from((max_t * out_r) + 0.001).unwrap(),
      NumCast::from((max_t * out_g) + 0.001).unwrap(),
      NumCast::from((max_t * out_b) + 0.001).unwrap(),
      NumCast::from((max_t * alpha_final) + 0.001).unwrap()
    ])
  }
}

But this is bad solution of course :) But I don't know good solution.
P.S. round() is not solution for this image: result is still different.

Thank you for catching this, f32::round() has to be used.
I do not know what causes the different result bit it is not an issue of the accuracy of f32. a) because f32 should be more than enough for that kind of operation and b) because gimp also “only” uses f32.

GIMP result: https://i.imgur.com/SPVVwmO.png
imageops::overlay result with f32::round(): https://i.imgur.com/KwBzdvj.png
Diff: https://i.imgur.com/QB9jBDw.png
So f32::round() is very bad for me :(
Or you think GIMP has bug too?

As I just said: I do not know what causes the different result but it is neither caused by round nor by using f32.

Why do you think that this is not by using f32? Something like 0.1 + 0.2 == 0.30000000000000004 — it's enough for errors

No it’s not. This is the wrong place to discuss how binary numbers work, but please have a look at the number you posted. How long would it take until this error would arrive at a place we would care? Just try out f64 and you will see that it doesn’t make a difference.
I haven’t counted but the error is about 12 digits away from our issue (which in fact proves that you used f64 for your example not f32 for which Rust will produce 0.3).

I think you're wrong
let mut i: f32 = 0.0;
for _ in 0..10 {
    i = i + (0.1f32 + 0.2f32);
}
println!("{}", i);

This code prints 2.9999998 instead of 3.0, as you can see f32 accuracy is still low and error can accumulate.
Because 0.1f64 + 0.2f64 == 0.30000000000000004 you should see f64 accuracy is low too, of course ;)
let mut i: f64 = 0.0;
for _ in 0..20 {
    i = i + (0.1f64 + 0.2f64);
}
println!("{}", i);

Prints 5.999999999999998 instead of 6.0
If you add
println!("{} {} {} {}", max_t * out_r, max_t * out_g, max_t * out_b, max_t * alpha_final);
in fn blend, you can see something like 254.99998 instead of 255.0, 92.99999 instead of 93.0 or 147.99998 instead of 148.0, so I still think it is problem with f32
If you will use f64, you can see<PHONE_NUMBER>9999997 instead of 255.0, 65.99999999999999 instead of 66.0 or<PHONE_NUMBER>9999999 instead of 107.0, so f64 accuracy is low too
I hope that these examples will convince you.

Probably duplicate of #599.

@nwin it will incompatible with GIMP? :'(

@nwin I wrote blend implementation using u32 instead of f32 (range of numbers 0 .. 255 instead of 0.0 .. 1.0) and this is fully compatible with GIMP too. Just note.

Also, this is not duplicate, of course. #599 describes other problem with blending.


Question about training details

Thank you for such a great work of open source source. When I was training, I encountered the problem of insufficient video memory, I would like to ask you what graphics card model you used during training? What is the memory size?

Hi, thanks for the interest in our paper. We used V100 with 16Gb RAM for our experiments (batch size = 1).


Improve some tests for safety

This was part of @alexey-cord-tech 's comments in this PR https://github.com/encord-team/encord-client-python/pull/161


machine.py tools vs tool attribute distinction

the Machine object has both a 'tool' (the current tool) attribute as well as 'tools' (the list of available tools). The distinction between these should be made more clear by renaming one.

Good point (and there's also configured_tools which is reads from the RRF object model!). I propose changing tools to loaded_tools (since this information is updated after a load_tool() command. Maybe it's worth also renaming tool to active_tool to be explicit?


Improve trace logging

"DEBUG" prefix has been removed
Added color support
Fixed caller reference

Force merged the PR because it's hard to test these changes


fix(demuxer): reduce cpu usage when need retry

add protection
reduce cpu usage

Codecov Report

Merging #62 into develop will decrease coverage by 5.46%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop      #62      +/-   ##
===========================================
- Coverage    69.21%   63.75%   -5.47%
===========================================
  Files          200      200
  Lines        10563    10566       +3
===========================================
- Hits          7311     6736     -575
- Misses        3252     3830     +578

Impacted Files
Coverage Δ

framework/demuxer/avFormatDemuxer.cpp
78.61% <100%> (-4.25%)
:arrow_down:

.../demuxer/play_list/segment_decrypt/ISegDecrypter.h
0% <0%> (-100%)
:arrow_down:

framework/tests/dataSource/ipList.h
0% <0%> (-100%)
:arrow_down:

framework/tests/demuxer/demuxerUnitTest.cpp
0% <0%> (-100%)
:arrow_down:

...muxer/play_list/segment_decrypt/AES_128Decrypter.h
0% <0%> (-100%)
:arrow_down:

...xer/play_list/segment_decrypt/AES_128Decrypter.cpp
0% <0%> (-95.56%)
:arrow_down:

framework/tests/decoder/decoderUnitTest.cpp
0% <0%> (-93.48%)
:arrow_down:

framework/tests/dataSource/dataSourceUnitTest.cpp
0% <0%> (-93.34%)
:arrow_down:

...aPlayer/tests/formatTest/mediaPlayerFormatTest.cpp
0% <0%> (-86.67%)
:arrow_down:

framework/tests/demuxer/demuxerUtils.cpp
0% <0%> (-76%)
:arrow_down:

... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1dd84...1c89c09. Read the comment docs.


cartesian coordiates in the imput format

For example, the ase module can write only ATOMIC_POSITIONS  angstrom in the quantum espresso input format.
In the examples, you use fractional coordinates to the unit cell vectors. interface/VASP.py uses fractional coordiates, too.
It looks that interface/OpenMX.py uses cartesian coordiates, but have you encountered any accuracy problems in cartesian coordiates?

I have not encountered any accuracy problems in Cartesian coordinate. Currently, ALAMODE (alm binary) only accepts fractional coordinates, so I use the fractional coordinate also for the DFT codes. OpenMX is an exception; if the fractional coordinate is used, the positions are automatically moved back to the 0<=x<1 region in OpenMX. This behavior is not convenient for getting atomic displacements from *.out files created by OpenMX.


Plot Size

I think that resizing the plot windows in order to resize the plot itself is not enough.
There had been several situations in which I needed to save or copy my plot with dimensions like (2900:450). My display is much smaller than that, and I found no way to change my plot to an arbitrary size. In RStudio however, it is easily possible using the "save plot as image" button.

#1083

#1083 added the functionality.


Grammatical Error

@Sourav9097 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The typo fix looks good; thanks @Sourav9097.


Make removal/refetch on invalidate/refetchOnX configurable

In the spirit of https://react-query.tanstack.com/docs/guides/scroll-restoration we should maybe refetch them by default, but add a config option to remove instead?
So a refetchUnmounted option that kicks in both here and on invalidateEntities?
Originally posted by @phryneas in https://github.com/rtk-incubator/rtk-query/pull/90#discussion_r540384737

I second this, and ask for a trace of what triggered it to occur in the logger

I'm closing everything here now. If there's any need for further discussion, that should take place in a new issue over at https://github.com/reduxjs/redux-toolkit/


Use PureComponent instead of react-addons-pure-render-mixin

Please drop the peer dependency on react-addons-pure-render-mixin in favour of React's PureComponent

+1

PRs are welcomed.

@tomchentw I'm working on it

@tomchentw #25

Released v4.0.0


Implement cloud deployment

Create docker config files and deployment environment:

Deployment environment using A1 on Oracle
Docker compose files and CI/CD build push to Docker repository

Won't get this far right now, as we should deploy to K8s in a production environment.


Frontend: fixed issue #930 via video (CSS BOX MODEL)

Description 📜
Fixed issue #930 via video where I have explained CSS Box Model

Type of change 📝

[x] Video (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)

Domain of Contribution 📊

[x] Frontend Dev HTML/CSS/JS

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

thankyou so much <3 @code-reaper08 @2024-SANDHYA

thankyou so much <3 @code-reaper08 @2024-SANDHYA

Thanks for contributing 🚀🤝


Create Posts “visitny”

Automatically generated by Netlify CMS

👷 Deploy Preview for eloquent-chandrasekhar-302983 processing.
🔨 Explore the source changes: 004f418cb37fd1d68b48f903a5c1dc653472dba2
🔍 Inspect the deploy log: https://app.netlify.com/sites/eloquent-chandrasekhar-302983/deploys/61ad6d0369aa9c0007fc8dd2


add framebuffer features

add a few features to the framebuffer
Tasks

[ ] backspace support
[ ] add \t support
[x] double buffering
[x] colors (idea: print_rgb(r, g, b, format, ...))

added tab support (4 spaces)


Nested navigation inside a Modal does not work

CoreMethods.PushPageModel<T> does not navigate as expected in a Modal page.
Here is a video of the behavior: http://screencast.com/t/gErUL9c2h
The basic navigation wraps any new Modal in a NavigationPage, which is great. However, when trying to navigate to pages while that Modal is displayed, the pages are pushed underneath (in the other parent NavigationPage).
I have been playing with this and investigating my options. Suggestions are welcome.

That is why there is a modal parameter that you can set to try while calling this method?

Op 9 jan. 2016 om 21:35 heeft John Miller<EMAIL_ADDRESS>het volgende geschreven:
CoreMethods.PushPageModel does not navigate as expected in a Modal page.
Here is a video of the behavior: http://screencast.com/t/6DUPjV8DmfAg
The basic navigation wraps any new Modal in a NavigationPage, which is great. However, when trying to navigate to pages while that Modal is displayed, the pages are pushed underneath (in the other parent NavigationPage).
I have been playing with this and investigating my options. Suggestions are welcome.
—
Reply to this email directly or view it on GitHub.

@jfversluis
I might be confused. Using the modal paramater is just a toggle to cause a Modal to be used, not to tell that you are navigating inside a modal. If you were to just pass a true, it would display another modal on top of this one. Instead, I want to be able to navigate forward inside the NavigationPage stack that is already wrapping this Modal.
See this.

I have a solution for this that I'm working on now and will have done in
next days.
The solution is based on having multiple Navigation services.
On Sunday, 10 January 2016, John Miller<EMAIL_ADDRESS>wrote:

@jfversluis https://github.com/jfversluis
I might be confused. Using the modal paramater is just a toggle to cause a
Modal to be used, not to tell that you are navigating inside a modal. If
you were to just pass a true, it would display another modal on top of this
one. Instead, I want to be able to navigate forward inside the
NavigationPage stack that is already wrapping this Modal.
See this
https://github.com/rid00z/FreshMvvm/blob/master/src/FreshMvvm/FreshNavigationContainer.cs#L16-L26
.
—
Reply to this email directly or view it on GitHub
https://github.com/rid00z/FreshMvvm/issues/29#issuecomment-170280464.

--
Michael Ridland | Technical Director | Xamarin MVP
XAM Consulting - Mobile Technology Specialists
www.xam-consulting.com
Blog: www.michaelridland.com

@rid00z That is great to hear. Thanks for your effort on this, loving it!

This is solved in the current code base and will be in next release.


Initially dragging textures (PNG, JPG) from FileSystem into shader parameters lags

Tested versions

Reproducible in 4.2.1 b09f793f5

System information
Godot v4.2.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3050 Ti Laptop GPU (NVIDIA; <IP_ADDRESS>23) - 12th Gen Intel(R) Core(TM) i5-12500H (16 Threads)
Issue description
After dragging a texture from FileSystem to a shader parameter for the first time, the lag was something like 10 seconds -I thought Godot was going to crash. If you drag and hold and wait long enough you can actually drop into the shader parameter but the UI is noticeably laggy during this portion.
After clearing the shader parameter and dragging it in again, there was no lag. So it only happens on the first time.
Happens with JPG, PNG
It does NOT happen with DDS, so I think this points to some sort of problem with the import pipeline.
Steps to reproduce
To reproduce, copy/paste the shader below into a new ShaderMaterial, load the texture into the FileSystem, and try dragging the pebbles_01.jpg from the FileSystem into the Texture 2 parameter.
shader_type spatial;

uniform sampler2D texture1;
uniform sampler2D texture2;
uniform sampler2D splatMap;

void fragment() {
	// Called for every pixel the material is visible on.
}

Minimal reproduction project (MRP)
DragTextureIssue.zip

I don't know enough about image formats and compression to have a really intelligible conversation about this - but I am wondering if the DDS format is fine because it's basically already in a format easily digestible for VRAM?
As per loading bar, no. The UI froze for about 10 seconds and then when the icon appeared to drop the texture in, it was lagging about a second behind my mouse movement.
Is there no way to trigger the VRAM compression upon first importing the file rather than when it is first used in the rendering pipeline?

but I am wondering if the DDS format is fine because it's basically already in a format easily digestible for VRAM?

Yes – in fact, Godot doesn't even import DDS textures. It reads them directly instead.

Just linking a previous discussion on the topic: #78471
See my last comment on the discussion for arguments as to why this should be fixed.

When a texture is first imported, we don't know in advance whether it'll be used in a 3D context yet. Importing all textures with VRAM compression in the hope that they will eventually be used in 3D would waste resources, as this won't happen with textures used in a 2D project or UI textures.

I think it's important we find a place to put this loading that is not during a UI/UX operation such as drag and drop. Perhaps after the drag/drop has concluded, sacrificing some of the preview functionality in the viewport?

The alternative is to import the texture with lossless compression (so you can see it apply faster) and immediately import it with VRAM compression afterwards, but this will take more time than importing it directly with VRAM compression.

I would personally prefer this. I think a little but of extra load time is for me preferred to hanging up the editor mid-drag.

VRAM compression should be greatly sped up with https://github.com/godotengine/godot/pull/95915 in 4.4, so this should be much less noticeable now.


Failed to resolve: com.idevicesinc:sweetbluerx:<IP_ADDRESS>-SNAPSHOT

It works with com.idevicesinc:sweetblue:4.0.0 but not com.idevicesinc:sweetbluerx:<IP_ADDRESS>-SNAPSHOT.
Also com.idevicesinc:sweetbluerx:4.0.0 seems to work but it contains nothing.
I saw #10 was resolved but not sure it is related.

SNAPSHOT versions are not release versions. They are test versions, and aren't meant for production use.
Are you adding @aar at the end? so com.idevicesinc:sweetbluerx:4.0.0@aar

Adding @aar files works in my current use.
I've just tried to setup another one following this pulling the library from maven server but failed.
So, if we have to add @aar files to make it works, then https://github.com/HubbellCorp/SweetBlue/wiki/Getting-Started#getting-started and https://github.com/HubbellCorp/SweetBlue/wiki/Getting-Started-Rx should be updated then?

No, it's a current bug that has a workaround of adding @aar. See https://github.com/HubbellCorp/SweetBlue/issues/9

No, it's a current bug that has a workaround of adding @aar. See #9

Thank you for pointing this out. I believe this should be mentioned on getting started pages.

Still doesn't work.


[SPARK-39092][SQL] Propagate Empty Partitions

What changes were proposed in this pull request?
add a new AQE rule to propagate empty partitions
let A inner join B, when the i-th partition in A is empty, then we do not need to read  i-th partition in B
Why are the changes needed?
to prune shuffle partitions when possible
Does this PR introduce any user-facing change?
yes, a new sql conf added
How was this patch tested?
added testsuits

a simplest case:

spark.conf.set("spark.sql.adaptive.enabled", true)
spark.conf.set("spark.sql.adaptive.skewJoin.enabled", true)
spark.conf.set("spark.sql.autoBroadcastJoinThreshold", "-1")
spark.conf.set("spark.sql.shuffle.partitions", 100)
spark.conf.set("spark.sql.adaptive.coalescePartitions.enabled", false)

val df1 = spark.range(0, 100000, 1, 7).selectExpr("id as key1", "id % 10 as value1")
val df2 = spark.range(0, 100000, 1, 8).selectExpr("id % 30 as key2", "id as value2")
val joined = df1.join(df2, col("key1") === col("key2"), "inner")

spark.conf.set("spark.sql.adaptive.propagateEmptyPartitions.enabled", false)
joined.write.mode("overwrite").parquet("/tmp/tmp1.parquet")

spark.conf.set("spark.sql.adaptive.propagateEmptyPartitions.enabled", true)
joined.write.mode("overwrite").parquet("/tmp/tmp2.parquet")

existing impl:

after this PR:

retest this please

cc @wangyum @cloud-fan  mind take a look when you find some time, thanks!

I am going to prepare some slides for this new rule, and will add it to this PR.

Something is wrong with my google doc, so I just attach a design doc in the ticket https://issues.apache.org/jira/browse/SPARK-39092
@ulysses-you @cloud-fan


Fix pycocotools installation

Lazy import and lazy installation for pycocotools

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I created a PR as well, #2548 . I can close mine, but please change tutorial index page, and individual tutorials as well.


[Rank Description] Rune and Jade Rank

Both Jade and Rune have the description :
"Access to nickname yourself, with Minecraft color, formatting and hex color codes! (/nick)
Note: The hex code (e.g: '#ffaa00') needs to be encoded in { } braces (e.g: '{#ffaa00}')."
This is no longer accurate or valid according to CPT

Rank descriptions have been updated by Ras. Thanks for reporting!


utf_baselib_async unit test allocates too much memory (GBs)

the block size should be changed so it is not that expensive...
that is especially a problem under application verifier where this can become several gigabytes

This was resolved by the following PR: https://github.com/jpmorganchase/swblocks-baselib/pull/32


add test for fetch(urlObj)

initially I changed to parse_url(input.url + '') in request.js because
const {URL} = require('url');
const fetch = require('node-fetch');
fetch(new URL('https://nodejs.org'));

throws:  TypeError: Parameter "url" must be a string, not object
but I guess the npm version is not up-to-date yet? because the tests passes here
so I didn't do it, and just added a test. Can the npm version be updated to avoid this bug?

https://runkit.com/caub/5978d1598a496c0011c15e33 demo, that shows that he throws with the npm dep
any update?

@caub URL object support was added in node-fetch v2.0.0-alpha.*. The default installed version is node-fetch v1.7.1, which doesn't have URL object support.

Ah ok
As you're here:), Why using require for nodejs core modules? https://github.com/bitinn/node-fetch/commit/60cf26c2f3baf566c15632b723664b47f5b1f2db and not import, it looks inconsistent


fix(calendar): fix bug with empty date

simplify state by replacing month with date and month method
handle rendering correctly when changing month
work around a bug in date (will be fixed later)

@kristijanhusak @chipsenkbeil I discovered a bug in Calendar while working with Org-Roam I may have introduced myself, because it exposes a bug in date. I didn't had the time to actually take a look at the Date class, but I managed to implement a tiny workaround in Calendar and even add some tests.
I would appreciate if we could review and merge this quickly, because the bug is currently on master.
Now that I have tests (and actually an idea, how to test the widget) I will continue to improve the calendar with further PRs. I might also fix the problem in Date.

@seflue what is the actual bug you're solving?

It is an edge case with the end of month, which leads to unexpected nil date, which breaks the widget. It is in the date class, but easily to work around.

The fix of the actual cause is a bit more complicated - I will make a second PR soon.

In #748 I fixed the underlying problem, which is explained in #747. We can merge #748 before this one, then I will also remove the workaround in Calendar.

I don't remember why I had both month and date, but could we just ditch the month and use only date? @chipsenkbeil would that cause some issues for you?

Gave a scan over where date is used (only in one file, IIRC) within org roam. I only access month as a field from OrgDate, not OrgCalendar. So I think this is fine.

I don't remember why I had both month and date, but could we just ditch the month and use only date? @chipsenkbeil would that cause some issues for you?

That's what I actually did. The month member function is now deriving the month from the date state. Actually I had a hard time thinking over this, when I wrote my first implementation of the time picker - and already tried to get rid of month as an independent state, which was not easy with the original implementation. But with the refactoring of calendar it got reintroduce - meanwhile I had mostly forgotten, what I initially did. When I discovered and investigated the bugs, the deja vus came on after another ... it should now be much more stable.
Actually the ideas of improving the class are stacking up, so expect more PRs here.

I rebased the code onto master and removed the quickfix. Now the essence of this PR is the removal of the month field in Calendar and adding some test for it.
@kristijanhusak Ready for merge from my side.

@kristijanhusak I don't know, why the tests fail, it is unrelated to the code and it doesn't fail, when I run the tests locally. But unfortunately I don't have permissions to rerun the tests.


c++ implementation of ActionModelNumDiff [REPLACEMENT ISSUE]

The original issue
Id: 167
Title: c++ implementation of ActionModelNumDiff

could not be created.
This is a dummy issue, replacing the original one. It contains everything but the original issue description. In case the gitlab repository is still existing, visit the following link to show the original issue:
TODO

In GitLab by @cmastalli on Jul 15, 2019, 08:38
assigned to @MaximilienNaveau and unassigned @cmastalli

In GitLab by @cmastalli on Jul 15, 2019, 08:38
This issue have been tackle in !172

In GitLab by @cmastalli on Jul 15, 2019, 08:38
closed


Shrink part-db

Removes part entries which do not map to pinmaps provided with f4pga.

@umarcor Requires more code to handle such hierarchy. I don't see a reason for reversing it tbh.

@kboronski-ant it does reduce size and IMHO human-readability, since multiple JSON viewers allow collapsing/expanding lists/dicts. With regard to the code, changing a single line should suffice: https://github.com/chipsalliance/f4pga/blob/297978cb820eb112ff549d58e587761ebf0a3d9c/f4pga/init.py#L516


[Bug]Better Discord Not Installing.

Describe the Bug

Whenever I install better discord on stable using the newest installer I open discord and there's no plugin.
I've tried repairing, uninstalling and reinstalling, and really everything.
To Reproduce

Install betterdiscord on stable using the newest installer.
Expected Behavior

I expected better discord to be usable when I opened discord.
Screenshots

Discord Version

Stable
Additional Context

Whenever I install better discord on stable using the newest installer

Your screenshots clearly show the outdated installer. Please use the latest installer found here: https://github.com/BetterDiscord/Installer/releases/latest

Whenever I install better discord on stable using the newest installer

Your screenshots clearly show the outdated installer. Please use the latest installer found here: https://github.com/BetterDiscord/Installer/releases/latest

Im so sorry I was just starting to figure that out too.
While I'm at it is there anywhere I can find a list of plugins?

Whenever I install better discord on stable using the newest installer

Your screenshots clearly show the outdated installer. Please use the latest installer found here: https://github.com/BetterDiscord/Installer/releases/latest

The most recent installer doesnt even complete install. It simply freezes on "killing discord" and never completes

Make sure you use the latest installer, and if you have an issue with that installer it should be filed over at https://github.com/BetterDiscord/Installer


docs: modified pages/tutorials/getting-started/event-driven-architectures.md

Description
Fixed a grammatical error.
Changed the line from: "In most cases, EDAs are broker-centric, as seen in the diagram above. There are some new concepts in that diagram, so let's go through them now"  to   "In most cases, EDAs are broker-centric, as seen in the diagram above. There are some new concepts in the above diagram, so let's go through them now. "
The word "above" clearly shows that we are referring to the diagram which is just above it .

Did a few mistakes and would make a new PR soon.


Backfill sync

resolves #2556

So to backfill sync we can't really do any verification on the blocks but ensure that all parents of our trusted weak subjectivity checkpoint. Therefore we must download them a verify them in reverse.

Check if we have ws checkpoint block root in db
if not, do a blocks_by_root request with ws checkpoint block root -> block0
do a blocks_by_range request for [block.slot - N, block.slot]
Verify linear block segment such that block-1 == block0.parentRoot and so on.
Repeat (3) until we have a required block in the db or backfill the required slots

I've been playing around with this for a bit and maybe we want to not re-use the existing range sync code since the requirements are very different. Unlike with current sync we don't need backfill sync to be fast, it just has to complete eventually. The feature of downloading batches in parallel is not useful here since speed is not a concern and we can potentially be doing more work than necessary.
Probably just doing the above 5 steps in an infinite retry and picking a random peer would suffice.

So to backfill sync we can't really do any verification on the blocks but ensure that all parents of our trusted weak subjectivity checkpoint. Therefore we must download them a verify them in reverse.

We need to verify proposer signature as it's not part of hash chain

Check if we have ws checkpoint block root in db
Do we need it? Can't we check with state.lastestBlockHeader.parentRoot?

@dapplion does this flow looks better? No idea if I'm using processor as expected :)

Is the any blocker on this PR? Happy to help get it to a review-able state

Is the any blocker on this PR? Happy to help get it to a review-able state

Got busy with db metrics, getting back to this. Hopefully I can get this working and figure some test for it

@dapplion this should be better now.

no idea how to listen on backfill sync completed in test now that we removed events
there is bunch of different errors when running test that I would appreciate help debugging

Merge conflicts

@mpetrunic I've been reviewing this branch this morning and applied some changes directly that I though helped improve the design. Please review my commit in case I worsen any area.
There is still a big problem in the current design which is that it will always backfill the entire range over and over on every restart. Even if the node stops for 60 seconds it will try to backfill the entire period again, despite those blocks being already in the db. Since there can be skipped slots or only part of the blocks may be backfilled how can the node reliably tell if it has to backfill or not?

I've added a very naive check in startup to find at least one block in the target range to backfill. If there's at least 1 block, skip backfill sync. This is not great but better than backfilling always.

Please let me know if you can think of any solution to this problem.

I vaguely remember having check which fetches first block in archive to check that.

Linter error

@mpetrunic This PR still has an unresolved issue where it may backfill sync more than necessary.
To be aware of the problem can you add metrics to backfill sync? I think we need at least:

total count of backfilled blocks. Increment by one for each processed block
total count of errors. Increment by one on each download or processor error
current backfill status. Add a collect function to get the status, similar to range sync

Is it possible for backfill sync to get stuck processing the same range over and over forever? Should it stop trying after N attempts? However if we do that, the node on the next startup may think it's fully backfilled and not do anything.

@mpetrunic This PR still has an unresolved issue where it may backfill sync more than necessary.
To be aware of the problem can you add metrics to backfill sync? I think we need at least:

total count of backfilled blocks. Increment by one for each processed block
total count of errors. Increment by one on each download or processor error
current backfill status. Add a collect function to get the status, similar to range sync

Is it possible for backfill sync to get stuck processing the same range over and over forever? Should it stop trying after N attempts? However if we do that, the node on the next startup may think it's fully backfilled and not do anything.

I can do that. What have we figure out with skip slots, will you revert back to supporting it or figure out something new?

What have we figure out with skip slots, will you revert back to supporting it or figure out something new?

I trust your criteria, please take over the PR if you can

@mpetrunic Teku and Lighthouse backfill to genesis

@mpetrunic Teku and Lighthouse backfill to genesis. From the discussion at the eth2 call it's was clearly stated that we must backfill to genesis until there's a strong platform for long term block storage.
I would remove the pruning code and always backfill to genesis.
To know if we have to backfill or not Paul from Lighthouse suggested to persist in the db some notion of ranges that we would read know until when we have to backfill. If this ranges don't exist, then the node may read the block archive db and figure them out.

Doubt there will ever be strong platform for long term storage as long as there are clients storing all blocks but thats just my 2c
Gonna remove pruning and blocks_by_range condition

From Michael Sproul (Lighthouse)

We keep an oldest_block_slot: Slot in the database, which decrements as new blocks are written. We also store the oldest_block_parent: Hash256 to know which block to fetch next.

At the moment we'll just keep syncing from the old checkpoint. If we add a test to make sure that checkpoint isn't "too old", I think we'll just recommend dropping the DB so we don't have to deal with multiple backfills

From Michael Sproul (Lighthouse)

If the client stops during backfill sync, on startup how do you decide if you are backfilled or not?

We keep an oldest_block_slot: Slot in the database, which decrements as new blocks are written. We also store the oldest_block_parent: Hash256 to know which block to fetch next.

If you have ran the client a month ago and now start from a recent weak subjectivity cp, should the node stop backfilling when it reaches the latest persisted block from a month ago? If so, how can it differentiate between a failed backfilled sync and the chain from the previous run?

At the moment we'll just keep syncing from the old checkpoint. If we add a test to make sure that checkpoint isn't "too old", I think we'll just recommend dropping the DB so we don't have to deal with multiple backfills

We do that now as well except I'm not sure why di we need separate counter in db since we can just check first key/value stored in block archive, maybe they don't use slots as keys in block archive.

We do that now as well except I'm not sure why di we need separate counter in db since we can just check first key/value stored in block archive, maybe they don't use slots as keys in block archive.

If I understand they store the oldest_block_slot from backfill sync. The problem here is how you differentiate between backfill sync and regular block achiving if you just check the first key?

We do that now as well except I'm not sure why di we need separate counter in db since we can just check first key/value stored in block archive, maybe they don't use slots as keys in block archive.

If I understand they store the oldest_block_slot from backfill sync. The problem here is how you differentiate between backfill sync and regular block achiving if you just check the first key?

Ah you mean, when people start and stop nodes that we won't backfillsync gap? Not sure how storing separate last fetch helps there though. I think we should also recommend to just drop db haha

Closing for https://github.com/ChainSafe/lodestar/pull/3384


Landing Page UI | Access Denied/Login Failed Page

For Issue: #292 #204

This pull request added a new UI for the landing page, with two new cards, website name and description.
I tweaked the header to now have "absolute" position. This is to prevent overflowing when developers want to set the height to "full"
The previous "Loading" file, has now change to "DisplayPage"

This is to have a more global message page

I remove the name of the website on the header, and moved it to the landing page instead

The icon feels much cleaner compared to a text with aligning

Domain and Certficate cards displays a brief description of what they are

A button for the "information" page
A button to redirect them to the main page

Demo #292
https://user-images.githubusercontent.com/32577022/224070226-166a625b-8be2-42c0-a2f4-caa1f9d7e40f.mp4
Demo #204
https://user-images.githubusercontent.com/32577022/224070287-91ecbc92-5e82-43a0-af8e-e3a3ee03cc91.mp4

One thing about the 2 buttons in the cards. I think we should consider making the entire card clickable, and not have any buttons at all. I'd move the "Instructions" to the individual pages and include it as a link in the intro paragraphs on those pages (i.e., to learn more, see these instructions...).

That was my first iteration of the card actually, I spent a few hours trying to make it look better, but having a title and desc just doesn't work unless I add effects. After a while I decided to go with buttons to make it not empty

I think you can wrap the entire card in a Link Chakra UI component

I think you can wrap the entire card in a Link Chakra UI component

I did create the first iteration as a clickable card, but I decided against it due to not having enough values to justify its existance

One thing about the 2 buttons in the cards. I think we should consider making the entire card clickable, and not have any buttons at all. I'd move the "Instructions" to the individual pages and include it as a link in the intro paragraphs on those pages (i.e., to learn more, see these instructions...).

That was my first iteration of the card actually, I spent a few hours trying to make it look better, but having a title and desc just doesn't work unless I add effects. After a while I decided to go with buttons to make it not empty

OK.  I'd still move the "instructions" bit to the page itself, and only have a single call-to-action button for each card.

@Ririio
Maybe I'm just missing it, but what is the license for that SVG image? Where is it from, what conditions is it come with? IMO we should document this (maybe a file next to the svg or something)

@Ririio Maybe I'm just missing it, but what is the license for that SVG image? Where is it from, what conditions is it come with? IMO we should document this (maybe a file next to the svg or something)

https://github.com/DevelopingSpace/starchart/blob/main/app/assets/LICENSE
The license is under here

Thanks, approved!


docs: Document the test-install tooling.

Testing plan: @adambirds used it!

It's possible that we should just try to finish the documentation here as-is without improving its behavior, if doing so is hard.

I made the adjustments that @gnprice asked for -- I intend to merge this tomorrow, barring objection.


TBill NFT info from opentheta.io

To implement :

Price of each NFT in the page -> Lower of each NFT at time T
Make the current prices appear and the graphs + the wallet and its info

Count the numbers of wallets?

Count the numbers of wallets?
So we can keep an eye on the movement in the LP.


feat: GetObjectInput add range field

Signed-off-by: Gaius<EMAIL_ADDRESS>
Description

GetObjectInput add range field.

Related Issue

Motivation and Context

Screenshots (if appropriate)
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.

Codecov Report

Merging #1421 (6ef1a8d) into main (95f5253) will increase coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1421      +/-   ##
==========================================
+ Coverage   44.22%   44.55%   +0.33%
==========================================
  Files         113      113
  Lines       10202    10202
==========================================
+ Hits         4512     4546      +34
+ Misses       5235     5200      -35
- Partials      455      456       +1

Flag
Coverage Δ

Object-compatibility-e2etests
?

unittests
44.55% <ø> (+0.33%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ent/daemon/peer/peertask_piecetask_synchronizer.go
47.61% <0.00%> (+2.16%)
:arrow_up:

client/daemon/peer/piece_broker.go
92.30% <0.00%> (+2.56%)
:arrow_up:

client/daemon/peer/peertask_piecetask_poller.go
50.72% <0.00%> (+20.28%)
:arrow_up:


Update ecstatic

Ecstatic v2 includes a security fix and addresses a bug which causes jenkins builds to crash.
Currently, any project using http-server may be crashing when built in jenkins. Please consider merging this and making a new release as soon as possible, this would be very much appreciated ❤
For reference:

changelog
CI crash issue

Thanks for the fast response!

Hi @indexzero, would you mind releasing this change eventually?


Permission issue

Permission denied (publickey).
fatal: Could not read from remote repository

Could you provide a bit more information about this issue, like what you were trying to do and what specific command you used?

when i want to install, it says:"
Host key verification failed.
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
"
Could you please help with it?


Jean Kim Review Ticket Week 2 Classy Functions

Individual Github Pages (3 Points) for Jean Kim
Self Grade:
Crossover Grade:

Github Page that documents key learnings and code snippets using Github Pages and replit

[ ] Organize files, directories and menus for the first 3 weeks
Link to organized repl.it with directories
[ ] Write Factorial function using classes and implementing call
Link to factorial python file on repl.it
[ ] Select your own Math function. Write it in Imperative and OOP form.
Link to greatest common factor math function file
[ ] Extra Credit.  Write Palindrome function using classes, must provide implementation of call.  Must indicate where error occurs on front and back comparison.
Link to palindrome python page

Github Page that documents key learnings and code snippets using Github Pages and replit
Organize files, directories and menus for the first 3 weeks
Link to organized repl.it with directories
Write Factorial function using classes and implementing call
Link to factorial python file on repl.it
Select your own Math function. Write it in Imperative and OOP form.
Link to greatest common factor math function file
Link to factors with Imperative and OOP format
Extra Credit. Write Palindrome function using classes, must provide implementation of call. Must indicate where error occurs on front and back comparison.
Link to palindrome python page

Github Page that documents key learnings and code snippets using Github Pages and replit

[x]  Organize files, directories and menus for the first 3 weeks
Link to organized repl.it with directories
[x]  Write Factorial function using classes and implementing call
Link to factorial python file on repl.it
[x]  Select your own Math function. Write it in Imperative and OOP form.
Link to greatest common factor math function file
Link to factors with Imperative and OOP format
[x]  Extra Credit. Write Palindrome function using classes, must provide implementation of call. Must indicate where error occurs on front and back comparison.
Link to palindrome python page

-0.5 Not enough documentation and code comments in the files


Limit the strings which can be eval'd

When processing the schema, each line is run through Python's eval
function to make the validator available. A well constructed string
within the schema rules can execute system commands. This change limits
the string to those that begin with the known validators.

Thank you for finding and fixing it, are you planning to publish a CVE for this?

Yes, it's CVE-2021-38305


No support for new types of version 12

Thank you for opening an issue.
In this template paragraph text could be removed, however please retain headers.
Prerequisites

[ ] Ensure you have latest version of plugin installed
[ ] Search for possible issue duplicates

Installation details

[ ] IDE version (Help->About->Copy to Clipboard)
[ ] intellij-hcl plugin version (Settings->Plugins)
[ ] Terraform version (terraform -v)

Terraform Configuration Files
# Copy-paste your Terraform configuration here - for large Terraform configs,
# please use a gist (https://gist.github.com) and share a link.

Exception
For exceptions paste exception stack trace here. If it's huge one - use gist.

Expected Behavior
What should have happened?
Actual Behavior
What actually happened?
Steps to Reproduce
Please list the steps required to reproduce the issue, for example:

Place cursor somewhere
Invoke completion.

So this is example of stupidiest issue ever open on GitHub. And then they ask "Why don't you believe in open-source and users sanity?"


Create a pyproject.toml for compatability with newer pip versions

I noticed this while installing the package from pip:
$ pip install ws.gitpersona
Collecting ws.gitpersona
  Using cached ws.gitpersona-1.0.1.tar.gz (4.5 kB)
  Preparing metadata (setup.py) ... done
Requirement already satisfied: setuptools in /home/king/.pyenv/versions/3.11.2/lib/python3.11/site-packages (from ws.gitpersona) (65.5.0)
Installing collected packages: ws.gitpersona
  DEPRECATION: ws.gitpersona is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559
  Running setup.py install for ws.gitpersona ... done
Successfully installed ws.gitpersona-1.0.1

I get that I could avoid this by installing the wheel package, but I don't think there's harm in setting up a pyproject.toml in this particular instance

Hi, thanks for letting me know. I've now released version 1.1.0 which both switches to pyproject.toml and is released as a wheel.


FilePackageCurationProvider: Filter out non-existing files

This avoids the need for $ORT_CONFIG_DIR/curations.yml to be present.
Signed-off-by: Sebastian Schuberth<EMAIL_ADDRESS>

Merging despite funTest-non-analyzer being stuck.