Max Memory In "Publish To AWS Lambda" Wizard Is "3008"

Describe the bug
When attempting to publish an AWS Lambda using the wizard, the max memory value in the drop down list is 3008 so I cannot publish for a desired memory value of 4096. For a Lambda which is already published and configured in AWS for 4096, when I attempt to re-publish, the value of 4096 is not read in and the drop down list does not have any value selected. If I try to publish without a memory value selected, the extension crashes.
To Reproduce

Right click an AWS Lambda project and choose Publish to AWS Lambda...
Try to select a value for Memory greater than 3008

Expected behavior
The drop down values should include values from 128 to 10240 as indicated by this statement on the AWS Lambda General configuration view in the webpage in the AWS webapp "Set memory to between 128 MB and 10240 MB".
Screenshots

Computer (please complete the following information):

Windows Version: 11
Visual Studio Version: 17.4.5
AWS Toolkit for Visual Studio Version: <IP_ADDRESS>

Additional context
I am also attaching a screenshot of the info tip that is displayed when I hover the Memory drop down list. It incorrectly states that increments can only go to a max of 1024. That is less than the 3008 which is in the drop down and less than 10240 actual. Maybe it is just missing a trailing "0" for the 10240.

Thank you for bringing this issue to our attention. We are investigating further.


Added interfaces for Gobblin broker.

This PR just adds the interfaces for Gobblin broker.

@chavdar @ydai1124 can you review? Thanks!

@chavdar @ydai1124 addressed all comments.
I simplified the interfaces by removing scoped parallels of many things (although scoped and unscoped factories are still separate).


E2E: go push main SLSA3 config-noldflags

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2361796549
Workflow name: go push main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Sat May 21 03:41:02 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2365172775
Workflow name: go push main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Sun May 22 03:48:08 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2368875214
Workflow name: go push main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Mon May 23 04:01:41 UTC 2022

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/2375361450
Workflow name: go push main SLSA3 config-noldflags
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.push.main.config-noldflags.slsa3.yml
Trigger: push
Branch: main
Date: Tue May 24 03:59:47 UTC 2022
Tests are passing now. Closing this issue.


Implement a version system for entities

It would be interesting to make a version system for entities. Every system has access to all the entities at once, and then when mutable access is requested a new version of the component will be created and given. When all components are done running the versions will be merged based on system order. This will not be quite as performant as an ECS, but I think it will strike a nice middle ground between performance and ease of use.

This has been replaced with a view then write system in https://github.com/ABC-Engine/ABC-ECS/commit/81b793cd6cef0141bef3b974ba5aeee0411d18b2.


Add imagery date more prominently to editing screen

I've found that people often overwrite correct edits based on the Bing imagery, which can be old -- this happened a lot in DC for example with new construction that people would delete because it wasn't on Bing, and I bet it happens with HOT places where imagery is old. I think it would be helpful to put the imagery date more prominently for the editing screen, and/or some kind of warning that says "note: this imagery is X years old, so maybe you shouldn't delete."
I think there is a Bing imagery date tool? I forget who did that.
Of course, people can and should leave notes for why they added something, but I think the more ways to make it clear, the better.

This is a duplicate of #2492 - we haven't thought of a really good way to support this yet.  Only Bing supports response headers that tell us the vintage of their imagery, but to get them we'd need to make a separate api request for the date.
Bing coverage tools are listed here:
http://wiki.openstreetmap.org/wiki/Bing_imagery_analyzer_for_OSM
http://wiki.openstreetmap.org/wiki/Bing/Coverage

Ah ok. I was thinking something like with the Tasking Manager where it shows the Task number in text within the square.


Refactoring

I signed it!

@VEINHORN, your Travis config file seems to be outdated. Please update that file.
Yo can use one of my pull request commits to change it
Cheers!


[Scope Change] - SetOperationType on Table 36 "Sales Header"

Please consider to change the scope for the following procedure inside table 36 "Sales Header":
[Scope('OnPrem')]
procedure SetOperationType()
I need to use it from my extension, but i also need to target my extension to "Cloud".
Thank you

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 49473.


Bug: Images inside links get moved outside the link on start

If you have an image inside a link:

When you start editing the image gets moved outside the link and you can't get it back inside even when cancelling the edit:

I think the issue here is that you need to mark the  tag as an image, e.g:

As you want the  tag to be treated as an image by the parser you need to mark it up in this way, if you create an image through the editor and add a link to it then save the page content you'll see this data attribute appended to the link automatically.

Here's how I'm doing it. Initially, the content is this:

Afterwards, I start the editor then it moves it out. I think the image shouldn't be moved out of the link and it should be handled. What's happening with the image inside the link?
I can't actually add images as of the moment. I tried it but nothing's happening, probably since I'm doing this in WordPress or that I'm not handling uploads yet. So I can't check the marked up html yet for images with a link.

So you'd need to change your initial content to:

By default  tags aren't converted to images as potentially (longer term) they might wrap other elements as well.
The image shouldn't be moved outside the link, oddly when I add your code to the sandbox/index.html file in the demo (using Chrome) the  tag is just converted into a static element and editing and saving doesn't move the image outside of it.
Can you test that this issue doesn't occur if you add the following code to the sandbox demo in the repo:

If you get the same issue then it might well be an issue with a specific browser I need to look at so could you provide details.

In the sandbox, I added this (this is from the inspector):

After clicking the edit, I'm getting this:

I'm using Chrome in Mac OS X 10.11

Ahhh... I understand now you're adding the image within an editable paragraph not as an editable image. You can't add images within paragraphs right now (well you can using HTML and they'll appear but you can't add them via the editor).
That does however look like a bug in the the way that the HTMLString library is optimizing, clearly the image should be retained inside the  tag. Sorry for the confusion I'll mark it as a bug and have a look at resolving it.

Yup, you cannot add them, I'm totally fine with that. I'm modifying the HTML for editing them then performing the necessary CT functions so that the editor can see the changes like you mentioned.
Thanks, hopefully we can fix it :)

Yep - just tested the code in HTMLString Spec and it fails in the way you described, hopefully it's something easy :)

@bfintal - OK I think that's resolved that.

Wow that was fast. Thanks! Confirmed on my end :+1:

Awesome (fortunately an easy fix) - sent you a question on Gitter re your early question :)


more figures in front page

add more static figures of fits to readme and front page of docs, along with the current gif.

like multiple figs with different dimensions, all embedded within a single large rectangle.

also re-design a logo


Adds an observerCount property to the UBSignaling interface

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Astro: Left speaker makes static noise when plugged in over USB to laptop.

Unsure why, but my Astro's left speaker (UK keyboard, UK plug) makes a funny sound, almost like static, when plugged into my laptop over USB.
Android FW: 11/V01.

I have and had similar problems with both my Cosmos, also on the charging cable, to the extent that I always have an audio cable ready to plugin near the charger to mute those noises.
(Low confidence observation: It seems to me they appear and get worse as the devices get older.)

I'm now getting this on my Astro - when it's not charging. Just idling. Playing music stops it. It's like an idle sound it plays.

Just experienced this on my astro while streaming music. In soft passages of the music the noise (static, brown noise, crackling) is ruining the music completely.
Charge was at 95%. I seem to remember that this gets worse on the Cosmo when it's full. Maybe it's worse if the charge is nearing completion.
Would that point at the charging circuit somehow? (Wild speculation...)

Just experienced this on my astro while streaming music. In soft passages of the music the noise (static, brown noise, crackling) is ruining the music completely.

I need to add that this happened over the headphone jack connected to my stereo. I don't hear any noise right now while it's plugged into the usb cable from my usb hub and almost at full charge (98%) and the headphone cable is disconnected.
It could be the (cheap) headphone cable picking up static from the usb cable.


Make up missing items for release preparation

Release missing items:

[X] Getting started doc
[X] UT for cloud behavior

compressed image size


Infer only find part issues in Cmake project

ENV:
Infer version v1.2.0   contos 7.4
I have a Cmake project. (addressSanitizer.zip).
run infer in the way:

mkdir build && cd build
cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=1 ..
infer run --compilation-database compile_commands.json

only issues of lsanSuppressed.c have found:

/home/zhenjing/test/addressSanitizer/lsanSuppressed.c:14: error: Memory Leak
Memory dynamically allocated by malloc on line 14 is not freed after the last access at line 14, column 3.
12.
13. void FooBar() {
14.   malloc(7);
^
15. }
16.
/home/zhenjing/test/addressSanitizer/lsanSuppressed.c:18: error: Memory Leak
Memory dynamically allocated by malloc on line 18 is not freed after the last access at line 18, column 3.
16.
17. void Baz() {
18.   malloc(5);
^
19. }
20.

If infer single file, more issues will be found.
infer run -- clang -c ../classMemberHeapOverflow.cpp

/home/zhenjing/test/addressSanitizer/classMemberHeapOverflow.cpp:110: error: Uninitialized Value
__param_0.tofCamera is read without initialization during the call to Test::Init().
108.     TCameraParam param;
109.     Test* test = new Test();;
110.     test->Init(param);
^
111.
112.     return 0;

infer run -- g++ -c ../useAfterFree.cpp

/home/zhenjing/test/addressSanitizer/useAfterFree.cpp:8: error: Use After Delete
accessing array that was invalidated by delete[] on line 7.
6.   int *array = new int[100];
7.   delete [] array;
8.   return array[argc];  // BOOM
^
9. }
10.

How to use infer find out all issues in Cmake project?

find ../ -type f ( -name ".c" -o -name ".cpp" ) | xargs infer run -- clang -c
only issues of lsanSuppressed.c have found.

Write a python script for CMake project to find out all issues：
import json
import sys
import re
import os

num_args = len(sys.argv) - 1
# check argv
if len(sys.argv) < 2:
    print("Usage: python script.py <path_to_json_file>")
    sys.exit(1)

json_file_path = sys.argv[1]
module_name = 'DecisionCenter'
if (num_args > 2):
    module_name = sys.argv[2]

print("json file: ", json_file_path, " module name: ", module_name)

with open(json_file_path, 'r') as file:
    data = json.load(file)

for item in data:
    if 'command' in item and module_name in item['command']:
        print()

        command = item['command']
        #print("orig command: ", command)

        command = re.sub(r'^/opt/rh/devtoolset-9/root/usr/bin/cc', 'infer run -- clang', command)
        command = re.sub(r'^/opt/rh/devtoolset-9/root/usr/bin/c\+\+', 'infer run -- clang', command)

        command = re.sub(r'-o .*? -c', '-c', command)

        print(command)
        os.system(command)


Plugin "Lombok" is incompatible with the newest IntelliJ (until build 193.SNAPSHOT < IU-201.6668.121)

Short description
After Upgrading IntelliJ, I'm getting this error: Plugin Error: Plugin "Lombok" is incompatible (until build 193.SNAPSHOT < IU-201.6668.121). Looks like there is no version of Lombok plugin compatible with the current version of IntelliJ.
Expected behavior
Support version 2020.1 (from April 2020)
Version information

IDEA Version:
IntelliJ IDEA 2020.1 (Ultimate Edition)
Build #IU-201.6668.121, built on April 8, 2020

JDK Version:
Runtime version: 11.0.6+8-b765.25 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
GC: ParNew, ConcurrentMarkSweep

OS Type & Version:
Windows 10 10.0

Lombok Plugin Version:
0.29-EAP

Lombok Dependency Version:

Steps to reproduce

Upgrade IntelliJ with Lombok plugin to newest version
see Event log for error message

Sample project
N/A
Additional information
N/A
Stacktrace
N/A

I have the same issue too What is wrong with lombok ? All projects of mine has been suspended of that.

So, i just figured that out, you will need to uninstall the current version of your lombok, then go and update your intelliJ to the latest version, then  go to settings -> plugins -> search for lombok -> install -> restart IDE -> fixed <3 xD

Thanks! that worked!

Just update your Lombok plugin in Settings > Plugins.


Add pageable support for list functions

Data Plane API - Pull Request

API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your engagement record.

Link to engagement record issue:

Is this review for (select one):

[ ] a private preview
[ ] a public preview
[ ] GA release

Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous Open API document (swagger) if applicable, and the root paths that have been updated.

Design Document:
Previous Open API Doc:
Updated paths:

❔Got questions? Need additional info?? We are here to help!

 Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

💬 Teams Channel
💌 email

Click here for links to tools, specs, guidelines & other good stuff
Tooling

Open API validation tools were run on this PR. Go here to see how to fix errors
Spectral Linting
Open API Hub

Guidelines & Specifications

Azure REST API Guidelines
OpenAPI Style Guidelines
Azure Breaking Change Policy

Helpful Links

Azure DevTools Wiki

Skipping model validation ref https://github.com/Azure/azure-rest-api-specs/pull/22540#issuecomment-1474257960


Fix a few typos in docs

These are some of the best docs I've ever read but it's pretty funny how many times "ultimately" is spelt wrong lol.

Thanks!


qcoro: 0.4.0 -> 0.6.0

And fix compilation on aarch64 by supplying GCC 11.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 185191 run on x86_64-linux 1

4 packages marked as broken and skipped:

libsForQt512.neochat
libsForQt512.spacebar
libsForQt514.neochat
libsForQt514.spacebar

1 package failed to build:

libsForQt512.qcoro

4 packages built:

libsForQt5.neochat (libsForQt515.neochat ,plasma5Packages.neochat)
libsForQt5.qcoro (libsForQt515.qcoro ,plasma5Packages.qcoro)
libsForQt5.spacebar (libsForQt515.spacebar ,plasma5Packages.spacebar)
libsForQt514.qcoro

Result of nixpkgs-review pr 185191 run on x86_64-linux 1

4 packages marked as broken and skipped:

libsForQt512.neochat
libsForQt512.spacebar
libsForQt514.neochat
libsForQt514.spacebar

1 package failed to build:

libsForQt512.qcoro

4 packages built:

libsForQt5.neochat (libsForQt515.neochat ,plasma5Packages.neochat)
libsForQt5.qcoro (libsForQt515.qcoro ,plasma5Packages.qcoro)
libsForQt5.spacebar (libsForQt515.spacebar ,plasma5Packages.spacebar)
libsForQt514.qcoro

@puffnfresh it looks like the packages depending on qcoro also need to use GCC11. Else they, too, fail with:
g++: error: unrecognized command line option '-fcoroutines'

I also think using gcc11Stdenv is the proper way to go. Yes we're losing some niceties from the Qt5 mkderivation, but uh, that's how the cookie crumbles.
I want you to check the changes here, if you think they're alright (or if a few days pass) we can push this to this PR and merge. Tested to build and run on x86_64 and aarch64.

https://github.com/NixOS/nixpkgs/compare/master...samueldr:nixpkgs:wip/qcoro-aarch64-fixups


Rename PCF tile and its label

According to Ning and Pivotal's discussion, we need to rename the tile to azure-open-service-broker-pcf to distinguish from a PKS tile. And we keep using open-service-broker-azure as the broker app name.
CC: @arschles

Please hold on this PR for now. Looks it is still in discussion.

Hi @krancour, could you help to merge? Pivotal confirmed that they accept Azure Open Service Broker for PCF to be the tile name.


Bump the metallb version

This includes service and namespace selection support for ip address pools.
Signed-off-by: Periyasamy Palanisamy<EMAIL_ADDRESS>

LGTM, thanks!
Let's wait for CI

Failure not related to the change.


Insert a New Element into a Sorted Singly Linked List

Is your feature request related to a problem? Please describe.
Given a sorted singly linked list. we have to insert a new given element into it.
Describe the solution you'd like
We will use two pointers which will move to the desired location as it it sorted, then will store the address into the new node containing the new element.

This has been implemented


Translate May 8 covid report into Farsi

Happy weekend @nextstrain/farsi,
The situation report from 2020-05-08 is ready to be translated to Farsi. This week's report is short and sweet and focuses on Asia. We tried to tie the trees in with other epidemiological info; I'm curious to hear what you think of it. As with other regional reports (and really all reports) if you don't have time or are not able to translate this report, totally fine. Just let me know.
We've been publishing weekly reports on covid for two months now! As such, we're taking time this next week to re-evaluate narratives and figure out how we can make these reports as useful as possible going forward. I'd welcome your feedback on the situation reports -- what you find useful, what you don't, how often you think reports should be published, how these reports help (or don't help) Farsi speakers.
Branch to translate on: sit-rep_fa
File to translate: https://github.com/nextstrain/translations/blob/sit-rep_fa/narratives/translations_ncov_sit-rep_fa_2020-05-08.md You can translate directly in this file, but please remember to push often as other people may be working on the translation!
Link to preview: https://nextstrain.org/community/narratives/nextstrain/translations@sit-rep_fa/ncov/sit-rep/fa/2020-05-08
Twitter post to translate:
“Want to learn more about outbreaks in Asia? This week's situation report uses #SARSCoV2 genomes to track the recent spread of #COVID19 in Asia. The report is now available in Farsi. Thank you @, @, and @ for the rapid translation."
Thanks so much for your help -- it's always a pleasure to work with you. See below for standard translation stuff.
Best,
Cassia
Logistics
Please update the translations board as you work on the translation: https://github.com/orgs/nextstrain/projects/7
Please assign yourself to the translation if you’re working on it this week.
When a translation is ready for publication -- at minimum meaning two people have worked on it and both agree that it’s ready -- please create a pull request to merge to master and tag me and the issue in it!
Discussion board for your team is here: https://github.com/orgs/nextstrain/teams/farsi
Standard rules for translation:
Note that the file to translate is in Markdown. In general, it is important not to change any formatting or links. (Although it is okay to update Wikipedia or CDC links to the appropriate language version.) Comments to help with translation are noted in comment symbols like <! -- Comment -->.
Please add your name under translators: with new line, tab, and dash, formatted just like authors are. Please also add a link to your professional page (can use Twitter) under translatorLinks:.
Note: You may know of other great resources available in Farsi; please don’t add them to the situation report. We need to keep content the same across all translations, so we can be confident in the accuracy of what we publish. Thanks for understanding.
At minimum, I require two sets of eyes on every translation; one of those people should have a background in phylogenetics. Although if you have more, that’s fine too.
Feel free to use a live, online editor like hackmd (sign in with GitHub) to translate together.

Published and tweeted: https://nextstrain.org/narratives/ncov/sit-rep/fa/2020-05-08


Export for Windows, use cargo ws to publish crates

This PR would re-enable Windows support. I can't reproduce #27 on modern builds of Flowistry, and the codebase has been significantly rewritten since then, so I think it's best to just re-enable it until the issue crops up again.
Also, we can use cargo ws to publish crates instead of having to awkwardly sleep for a minute and assume crates.io is done processing by then. Unfortunately there's no real way to test whether this works without just pushing a release and hoping for the best. I've checked through the documentation a few times to make sure that the intended semantics are there, but I can't guarantee that it'll work first try.

Looks great, thanks @zeramorphic.


Fix GitHub has changed the layout of the images

I also wrote about apkutil and blackhat to README.

It's a change in the README, so I'll merge it by myself.


[MENFORCER-298] Ensure bannedDependencies does not corrupt the classpath when using timestamped snapshots

See background in MENFORCER-298.
This patch is confirmed to fix the problem on the originally discovered test case. It does not purport to fix problems when using
<searchTransitive>false</searchTransitive>

(for which no ITs seem to exist), nor with other calls to buildDependencyGraph, notably from banTransitiveDependencies or banCircularDependencies in extra-enforcer-rules. Those might be fixable using MavenProject.getDependencyArtifacts and/or Artifact.getDependencyTrail.
I attempted to write an IT to reproduce the bug but failed: mrm-maven-plugin refused to serve the snapshot JAR artifacts needed for my test even though I tried placing them, along with POMs and maven-metadata.xml, in maven-enforcer-plugin/src/it/mrm/repository/ using

a flat directory structure, as in current ITs in this repo
an unpacked JAR format-2 layout as the mrm documentation seems to suggest
same, but with prepacked JARs, as maven-integration-testing does

I just copied the basic test setup from MavenITmng4189UniqueVersionSnapshotTest with minor modifications. If anyone is interested I can file a PR showing my attempt.
@stephenc suggested that my simple call to MavenProject.getArtifacts might have some undesirable side effects relating to overeager download of dependencies. Whatever the case, my patch does not regress any of the existing unit or integration tests.
@reviewbybees for my colleagues

Since this is several years old, I'm going to close it. Feel free to open a new PR that resolves the merge conflicts.

Sigh. My project is no longer using timestamped snapshots in most cases so I do not care to spend the ten minutes recreating this. If someone else is affected by the bug I guess they can try it, and reverify behavior in their situation.


Computer crashed due to "Powertoys run" consuming 32gigs of memory

Microsoft PowerToys version
0.69.1
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
PowerToys Run
Steps to reproduce
Not touching default options of run, just launching it, no results appear, after a short while computer will crash due to out of memory since powertoys run is eating it all. In my case, that hit 32GB memory eaten by run (all what is available out of 64gb installed)
✔ Expected Behavior
Not total computer crash
❌ Actual Behavior
Total computer crash due to out of memory
Other Software
No response

/reportbug

Would love to work with you to figure out which plugin could have a runaway issue

I disabled in "powertoys run" all options than "programs" and now it seems to work fine.

PowerToysReport_2023-05-03-11-35-26.zip

PluginManager.QueryForPlugin Window Walker. Query cost - 4035 milliseconds

[2023-05-03 08:49:19.2327] [WARN] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::207]
PluginManager.QueryForPlugin Window Walker. Query cost - 4040 milliseconds

[2023-05-03 08:50:10.0704] [WARN] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::207]
PluginManager.QueryForPlugin Window Walker. Query cost - 63639 milliseconds

[2023-05-03 08:50:10.9777] [WARN] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::207]
PluginManager.QueryForPlugin Window Walker. Query cost - 65990 milliseconds

[2023-05-03 08:50:32.8743] [WARN] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::207]
PluginManager.QueryForPlugin Window Walker. Query cost - 76332 milliseconds

[2023-05-03 08:50:41.5043] [ERROR] [C:\a\_work\1\s\src\modules\launcher\Wox.Infrastructure\Storage\ListRepository`1.cs::54]
Item Already Exists <Windows PowerShell.lnk>

[2023-05-03 08:51:52.3623] [WARN] [C:\a\_work\1\s\src\modules\launcher\PowerLauncher\Plugin\PluginManager.cs::207]
PluginManager.QueryForPlugin Window Walker. Query cost - 176133 milliseconds

I see a few costly Window Walker queries in a row. So I'd assume it's that one. This might possibly be solved by https://github.com/microsoft/PowerToys/pull/27490

This issue has been worked on during the 0.72 development cycle. Please update your PowerToys installation to the latest.
https://github.com/microsoft/PowerToys/releases
Thank you!


fix: crash when multiple overviews have the same ImageLength

Comparing "ImageLength" is not enough to sort the overviews. "ImageLength*ImageWidth" is.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

5 of 6 (83.33%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.49%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

loader.go
5
6
83.33%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
553

Relevant Lines:
1074

💛  - Coveralls

I'm curious as to what configuration raised the crash you are fixing here. i.e. overviews of different zoom levels should have differing ImageLengths.
Please rework the testcase images you've added to reduce their file size in order to keep the size of this repo to a minimum.

I have compressed the images


Close SQL in side menu

I noticed that the SQL menu is always open even if we are browsing something different (see secreenshot). I assume this is not on purpose, is it? In any case, this PR fixes it.

I assumed this was actually purposeful, as it's what people will be most likely to navigate to the docs for?

I also had this hunch – I will ask Hannes tomorrow.


How to document object composition?

I'm trying to figure out how to pull in method documentation from an object to show inside another object.
My code used to look like:
class Main {
  doIt () {}
  doThis () {}
  doThat () {}
}

And jsdoc was great! However I've moved things around:
class Main {
  constructor () {
    this.sub = new Sub();
  }
  doIt () {}
}

class Sub {
  doThis () {}
  doThat () {}
}

I'd like to have the documentation show the Sub members under Main.sub (and pull the documentation from Sub)

Main#doIt()
Main.sub#doThis()
Main.sub#doIt()

I don't mind if I need to write out all the function names above this.sub as long as the documentation from under Sub is pulled in. I'm just not sure the syntax or if this is supported.
Thanks!
Your environment

Software
Version

JSDoc
v3.5.5

Node.js
v8.6.0

I don't think the default template supports listing child members inside the parent members.  You can create the following below and the Main.sub member will link to the Sub methods though.
/**
 * My Main Class
 */
class Main {
    constructor () {
      /**
       * Holds a Sub object.
       * @member {Sub}
       */
      this.sub = new Sub();
    }
    doIt () {}
  }

/**
 * My Sub Class
 */
class Sub {
    /**
     * Does this
     */
    doThis () {}

    /**
     * Does that
     */
    doThat () {}
}

I tried a few combinations of @namespace / @borrows / @alias and I could sometimes get close, but nothing perfect. However this works GREAT, but only with jsdoc2md.
/**
 * My Main Class
 */
class Main {
  constructor () {
    /**
     * @borrows Sub#doThis as Main.sub#doThis
     * @borrows Sub#doThat as Main.sub#doThat
     */
    this.sub = new Sub();
  }
  /**
   * Does it
   */
  doIt () {}
  }

/**
 * My Sub Class
 */
class Sub {
    /**
     * Does this
     */
  doThis () {}

    /**
     * Does that
     */
  doThat () {}
}


Implicit all combinator for coroutines

I think it makes sense to support yielding arrays as implicit all combinator, especially with the changes in PHP 7.1 allowing [] for restructuring.
<?php

function coroutine() {
    [$a, $b, $c] = yield [
        asyncOperation1(),
        asyncOperation2(),
        asyncOperation3(),
    ];
};

Ad.: Whenever we implement await in PHP, I'd like to see await accepting these arrays too.


Investigate Streamlit integration.

streamlit.io
The Jupyter killer...

moved to https://github.com/keyko-io/nevermined-internal/issues/81


Adding parameter to root URL cause a 404

Tested with Grav: 1.2.2
Platform: OSX El Capitan 10.11.6
Setup is the following one: https://getgrav.org/blog/macos-sierra-apache-multiple-php-versions
Hi, using a new instance of Grav with multi language setup, there is a 404 when adding parameters on the root page only.
Here is how to replicate:

Download a last Grav Instance.
Create a new page called my-page.
Add to /grav/user/config/system.yaml the following lines to enable multi-lang setup:

languages:
  translations: true
  supported:
    - en

Then, try to fetch the following URLs:

/en > 200
/my-page > 200
/en?foo > 404
/my-page?foo > 200

I also created a video to demonstrate the issue: https://streamable.com/g411p
Thanks

/en is not a page, so it's triggering the "page not found" error unless it has no other arguments and it's considered to be a language identifier.
/en?foo does not work, but /en/?foo works

Hi @flaviocopes thanks for your answer :)
Unfortunately I'm afraid that this behaviour is wrong and Grav should handle that anyway.
There is plenty of cases where I should be able to call my app using query parameters.
Current website is: https://www.busuu.com/fr
Because of that I can't use Google PPC (or Adwords). Google is adding some parameters on the current URL, like: https://www.busuu.com/fr?b_source=adwords&b_campaign=uk_en_web_brand_e
This doesn't work and as you explained and returns a 404.
I would like also to call that URL using other parameters, like https://www.busuu.com/fr?destination=another_URL, I can't do that either.
If I'm using Optimizely for A/B testing, Optimizely also adds some parameters to the URL, and it returns a 404, I don't have any control on how those tools add parameters unfortunately.
I really think Grav should be able to handle it, what's your thoughts on that?
Thanks,
Seb

Please try my fix as it should resolve the issue.

Hi Andy, thanks, I'll try it asap.

@rhukster Thanks, tested and working properly. Really appreciated!


[HOLD for #17387] [$1000]  Inconsistent Error Messages Displayed for Invalid Email Addresses During Sign Up Process

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Navigate to the Stegging website.
Enter various invalid email addresses, such as<EMAIL_ADDRESS>jane.doe<EMAIL_ADDRESS>and jane.doe@com.
Note that the same error message is displayed for all invalid email addresses except for<EMAIL_ADDRESS>This inconsistency in error handling can cause confusion for users.

Expected Result:
The app should display the same error message for all invalid email addresses to ensure consistency in error handling.
The message for any incorrectly formatted emails should be "The email entered is invalid. Please fix the format and try again"
Actual Result:
The app displays different error messages for this kind of email (eg. jane.doe@-gmail.com), leading to inconsistency in error handling.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.29-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-capture (94) (1).webm
https://github.com/Expensify/App/assets/93399543/93041f1f-b27f-4b9f-bdf6-8e1b6602bacc
Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686679747437349
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0130df66afd4333dd5
Upwork Job ID:<PHONE_NUMBER>625070592
Last Price Increase: 2023-06-28

Proposal
Please re-state the problem that we are trying to solve in this issue.
Inconsistent Error Messages Displayed for Invalid Email Addresses During Sign Up Process
What is the root cause of that problem?
Front end (client-side) validation picks validation message from loginForm.error.invalidFormatEmailLogin here
below localized text from en.js which is for client side validation
invalidFormatEmailLogin: 'The email entered is invalid. Please fix the format and try again.',

While different error message returned from API when email validation is failed from backend

This caused inconsistency in error message.
What changes do you think we should make in order to solve the problem?
Change either front end or backend error message to have same message for email validation failure.
What alternative solutions did you explore? (Optional)

Proposal
Please re-state the problem that we are trying to solve in this issue.
Getting different error messages for fairly the same error
What is the root cause of that problem?
the root is definitely the frontend given that in the case of the address<EMAIL_ADDRESS>the frontend accepts the address and sends it to the backend. however in the case of the address jane.doe@com, the frontend blocks the request from being sent to the server and shows an error  message generated from the frontend

What changes do you think we should make in order to solve the problem?

changing the frontend so that it blocks both wrong emails jane.doe@com and<EMAIL_ADDRESS>from being sent to the backend
What alternative solutions did you explore? (Optional)

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~010df8f0e38f174768

Proposal
Please re-state the problem that we are trying to solve in this issue.
For invalid emails different message gets displayed to the user
What is the root cause of that problem?
dash/hyphen at the start/end of the domain we are allowing in the frontend as per the expensify-common regex here whereas backend is throwing an error for those emails. So for these emails we are getting the error message from the api and that is causing the inconsistent error message for invalid emails.
What changes do you think we should make in order to solve the problem?
We need to update the regex which should not allow hyphen(-) at the start/end of the domain name which will be consistent with the backend regex.
Instead of
const EMAIL_BASE_REGEX = "([\\w\\-\\+\\'#]+(?:\\.[\\w\\-\\'\\+]+)*@(?:[\\w\\-]+\\.)+[a-z]{2,})";

we can update to
const EMAIL_BASE_REGEX = "([\\w\\-\\+\\'#]+(?:\\.[\\w\\-\\'\\+]+)*@(?:[\\w]+(?:\\-?[\\w]+)*\\.)+[a-z]{2,})";

Updated the OP to call out the expected behavior: We want this message to show in all these cases: "The email entered is invalid. Please fix the format and try again"

Proposal
Post clarification on expected behavior/OP;
Updates to my proposal here
What changes do you think we should make in order to solve the problem?
Changing regular expression might not help here as backend uses FILTER_VALIDATE_EMAIL which has different logic than what we have in EMAIL_BASE_REGEX.
Updating EMAIL_BASE_REGEX to consider email with hyphen(-) as domain prefix as invalid may solve only current use case, but there could be other scenarios where frontend validation is differing from backend logic.
So, we should update backend email validation failure message as below
"The email entered is invalid. Please fix the format and try again"
What alternative solutions did you explore? (Optional)

How does @payal-lathidadiya's proposal look to you now @0xmiroslav

Bump @0xmiroslav 😄

Awesome, sounds likes a plan! Thanks @0xmiroslav

Not overdue, switching to weekly while we wait on https://github.com/Expensify/App/issues/17387

Still waiting on https://github.com/Expensify/App/issues/17387

Still waiting on https://github.com/Expensify/App/issues/17387

https://github.com/Expensify/App/issues/17387 is getting closer! Soon

https://github.com/Expensify/App/issues/17387 is pending review - Still on hold

Fixed in a separate issue that had this covered before this was reported here - closing :

Good morning @MitchExpensify I am not eligible for bug bountey?

The issue this was ultimately resolved because of, and pointed out the general inconsistency, was from April and you reported in June so figured the reporting bonus did not apply here @tewodrosGirmaA


✨ feat #302: proto to kcl_schema

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

2. What is the scope of this PR (e.g. component or file name):

go.mod
go.sum
pkg/tools/gen/genkcl.go
pkg/tools/gen/genkcl_proto.go
pkg/tools/gen/genkcl_test.go
pkg/tools/gen/testdata/proto/proto2kcl.k
pkg/tools/gen/testdata/proto/proto2kcl.proto
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[x] Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[x] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

57 of 63 (90.48%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 62.234%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/tools/gen/genkcl_proto.go
49
55
89.09%

Totals

Change from base Build<PHONE_NUMBER>:
0.3%

Covered Lines:
3304

Relevant Lines:
5309

💛  - Coveralls


custom route not working in production

I have this test-project https://github.com/sepiropht/pinterest-next-js, in dev it working like expected but when i build my project, and start it,  my app start, but my customs route like /api/images /api/user don't respond ... Any idea ?
Thanks

You are using next start instead of running your custom server with NODE_ENV=production.

Ok thanks i missed that

i'am one half year experience in js, and start react recently. If you have time could you look at globally and briefly on my poject and give me your feelings.


Feature Request: Select which column to display in a label

Sometimes datasets come back with more than just the Time and value columns, we have additional information in other columns that we might want to be able to put on our diagram via a label.
Currently you can only use the 'value'  field but it would be really useful to be able to choose which column in the dataset to use. For example:

Rather than printing the value 1/0 on a component we might prefer to show the 'friendly_text' Success/Failure. Strictly speaking for this use case we could use valueMappings but the real use case i have in mind is much more complex than this.
'dataRef' lets us pick which time series to use and 'datapoint' lets us pick which row to use so were just missing a 'dataColumn'

That sounds interesting but I don't have any data sources available to me that can produce this data. Can you attach the expanded extract of the 'Debugging Data' log of a datasource that has this? Then I've got something explicit to code against. It's really tricky getting it right without that.

The above was made using the builtin testdata datasource in 'csv content' mode
Data looked something like:
time,value,friendly_text
1715277266000,1,Success
1715277267000,0,Failure
1715277268000,1,Success
Heres the output of the debug (couldnt get a clean copy/paste of the text itself):

thanks, so given above it looks like the data's there post enrichment, so am assuming its baulking on the type. prob just forces it to null when not a number. Will have a look.

built into ver 1.12.0 with grafana for review

Ver 1.12.0 now published on grafana


Why SpriteSheetBuilder.addAnimation parameter 'frequency' does not work?

It looked no different when I changed the parameter 'frequency' from 1 to 60;
And how to set the frequency... besides set the ticker's fps

Thanks for reporting this, it is a bug. Earlier versions of SpriteSheet used frequency, but this was changed to the easier-to-understand framerate, which works differently. It looks like SpriteSheetBuilder was not updated to properly support it.
We will post a fix soon!

I have pushed support for both a frequency argument on the SpriteSheetBuilder constructor, as well as a "speed" argument on the "addAnimation" method (which replaces the old "frequency" argument).
Note that "speed" operates as a multiplier on the framerate (which will default to the Ticker framerate), and works the opposite as frequency did.
These changes currently exist in the "NEXT" version of EaselJS in GitHub, and will be included in the next public release (TBD).
Thanks again!

Thanks very much.


WebApi to Typescript Client, inheritance is not there

Hi,
I have a
    public abstract class PageDto : EntityDto<Guid>, IDto
    {
        [Required]
        public string Discriminator { get; set; }
        [Required]
        public int Position { get; set; }
        [Required]
        public string Title { get; set; }
    }

    [Serializable]
    public class PageTextDto : PageDto
    {
        [Required]
        public string Text { get; set; }
    }
    [Serializable]
    public class PageQuestionDto : PageDto
    {
        [Required]
        public string ImageUrl { get; private set; }
    }

When I generate the typescript client, only PageDto is generated. I can't see PageTextDto or PageQuestionDto.
In the option I cheked the inheritance option.

Is it a bug? Did I miss something?

This option just merges base classes together... I you dont expose the top-level classes like PageTextDto, the serializer cannot know which type to use... in this case you need to apply proper inheritance: https://github.com/RSuter/NJsonSchema/wiki/Inheritance


taints and labels machinepool test

Automation of Polarion TC https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-64905
and
https://polarion.engineering.redhat.com/polarion/#/project/OSE/workitem?id=OCP-64904
The tests succeeded on local
Ran 4 of 8 Specs in 39.001 seconds
SUCCESS! -- 4 Passed | 0 Failed | 0 Pending | 4 Skipped

Please, review PR @shellymiron @tshefi @xueli181114 @yasun1

besides my previous comment, /lgtm

/lgtm

/approve


Week 2

Such a lovely idea! You have made some good progress as well :) I like that you have included a few mini games within your app.
As Roy mentioned, you need to add documentation for your functions and add tests for your functions (using test_that()) within the test file.


npm test is broken

Running npm test on HEAD of master branch (b086fc6) is currently failing for "PaymentProtocol #x509+sha256Verify  should verify a real PaymentRequest without Root Cert" test case.
As per Travis logs at March 15 on that same commit, the test was passing: https://travis-ci.org/bitpay/bitcore-payment-protocol/jobs/211400035#L333
Is it possible that an updated dependency broke the test?

It's because the test will use the Coinbase case.
In it you will have these dates :
{ notBefore: { type: 'utcTime', value:<PHONE_NUMBER>000 },
notAfter: { type: 'utcTime', value:<PHONE_NUMBER>000 } }
As we are >1493147460000, we therefore not comply.
Therefore validateCertTime will return false (as cBefore>now isn't valid anymore.
Because validateCertTime is false, validityVerified is false, and we expect  validityVerified && issuerVerified && sigVerified; to be return.
Therefore, final value is false. And test is failing.

@Alex-Werner thanks for the explanation!

The one to fix :
https://github.com/bitpay/bitcore-payment-protocol/blob/master/test/samplerequest.js#L347


Latest XGBoost incompatible with Python 3.4

Reported in https://discuss.xgboost.ai/t/xgboost-invalid-syntax-async-def-map-local-data/1238
https://github.com/dmlc/xgboost/blob/7663de956c37eb4dd528132214e68ba2851d9696/python-package/xgboost/dask.py#L169
async def is introduced in Python 3.5, so it is not compatible with Python 3.4.
We have two choices:

Require Python 3.5 and higher; or
Remove the use of async def.

@trivialfis What's your take on this?

I cast my vote to 1), since Python 3.4 has reached the end of life.

@hcho3  Sorry for the late reply.  Totally on board with 1).

I feel like there will be corporate systems stuck on old versions and 3.4 is not that old.
I prefer supporting it given this might be a case of changing 1 or 2 lines.
https://stackoverflow.com/questions/30191556/coroutine-in-python-between-3-4-and-3-5-how-can-i-keep-backwords-compatibility

I can try supporting it ..


fix: Tags - After deleting a Tag, the select button is not showing the correct length.

Details

Fixed Issues
$ https://github.com/Expensify/App/issues/42271
PROPOSAL: https://github.com/Expensify/App/issues/42271#issuecomment-2114961759
Tests

Click on WS > Tags (Enable if needed)
Add a couple of tags (Two are fine)
Select the two tags (Notice it says 2 are selected)
Go offline
Delete one of the tags
Select "All" button to select both tags
Verify deleted tag is not selected
Go to taxes page
Add a couple of taxes (Two are fine)
Select the two taxes (Notice it says 2 are selected)
Go offline
Delete one of the taxes
Select "All" button to select both taxes
Verify deleted tax is not selected

[x] Verify that no errors appear in the JS console

Offline tests

Click on WS > Tags (Enable if needed)
Add a couple of tags (Two are fine)
Select the two tags (Notice it says 2 are selected)
Go offline
Delete one of the tags
Select "All" button to select both tags
Verify deleted tag is not selected
Go to taxes page
Add a couple of taxes (Two are fine)
Select the two taxes (Notice it says 2 are selected)
Go offline
Delete one of the taxes
Select "All" button to select both taxes
Verify deleted tax is not selected

QA Steps

Click on WS > Tags (Enable if needed)
Add a couple of tags (Two are fine)
Select the two tags (Notice it says 2 are selected)
Go offline
Delete one of the tags
Select "All" button to select both tags
Verify deleted tag is not selected
Go to taxes page
Add a couple of taxes (Two are fine)
Select the two taxes (Notice it says 2 are selected)
Go offline
Delete one of the taxes
Select "All" button to select both taxes
Verify deleted tax is not selected

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/85894871/c88bca83-1e1e-4cae-be97-bebc94362711

Android: mWeb Chrome
https://github.com/Expensify/App/assets/85894871/f8790d5b-0c6f-46e0-b567-6ecde35c6e00

iOS: Native
https://github.com/Expensify/App/assets/85894871/9e56060c-8213-4f14-9deb-4e75742c7ea0

iOS: mWeb Safari
https://github.com/Expensify/App/assets/85894871/caf7e879-862a-47d9-89c6-b8c0860f9272

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/85894871/92c14166-3775-4e7b-b0b3-5f960eb074c3

MacOS: Desktop
https://github.com/Expensify/App/assets/85894871/28e82232-f4b7-4f52-aaf2-db80c09ea4cc

🚀 Deployed to staging by https://github.com/cristipaval in version: 1.4.77-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[ISSUE #5291] Optimize the NettyRemotingServer.

Make sure set the target branch to develop
What is the purpose of the change
close #5291
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ni-ze Thanks for the review. About why i changed the second point, despite the failure of handshake, the message of RemoteCommand will be processed normally.

Done!

Codecov Report

Merging #5299 (5aba1b6) into develop (8d10c96) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #5299      +/-   ##
=============================================
- Coverage      43.20%   43.18%   -0.02%
+ Complexity      7807     7798       -9
=============================================
  Files            998      998
  Lines          69451    69436      -15
  Branches        9169     9167       -2
=============================================
- Hits           30003    29984      -19
  Misses         35682    35682
- Partials        3766     3770       +4

Impacted Files
Coverage Δ

...e/rocketmq/remoting/netty/NettyRemotingServer.java
60.86% <ø> (-0.26%)
:arrow_down:

...tools/command/namesrv/WipeWritePermSubCommand.java
50.00% <0.00%> (-19.24%)
:arrow_down:

...ocketmq/proxy/service/route/TopicRouteService.java
60.71% <0.00%> (-4.68%)
:arrow_down:

...lient/impl/consumer/DefaultMQPushConsumerImpl.java
31.64% <0.00%> (-3.77%)
:arrow_down:

...e/rocketmq/remoting/netty/NettyRemotingClient.java
38.56% <0.00%> (-3.49%)
:arrow_down:

...ketmq/client/impl/consumer/PullMessageService.java
49.23% <0.00%> (-3.08%)
:arrow_down:

...nt/impl/consumer/ConsumeMessageOrderlyService.java
47.71% <0.00%> (-2.46%)
:arrow_down:

...ache/rocketmq/store/AllocateMappedFileService.java
39.28% <0.00%> (-2.39%)
:arrow_down:

...impl/consumer/ConsumeMessagePopOrderlyService.java
10.00% <0.00%> (-2.23%)
:arrow_down:

...mq/store/ha/autoswitch/AutoSwitchHAConnection.java
70.43% <0.00%> (-1.35%)
:arrow_down:

... and 20 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


fix(docs): create_dir_all doesn't error if path already exists

Should be good!
Most functions are due for copying the std docs again BTW, but I just went the easy route ;)


Updates docs about parser options

Fixes #10.

Great job @hildjj! I mean about Peggy at large. I found PegJS a few years ago and used it in a few projects. It was sad to see such a little gem fall into the unmaintained github hole. Incremental TS support as per other comments will be amazing.
Keep it up! 🤘


Added setting for ResultsShowTime in regular rooms.

Why did you close your pull request? I wanted to merge it after adding this option to the room creation screen in version <IP_ADDRESS>

I made the PR off my master (GitHub newb), and it's easier for me to delete the fork and remake =3


Add Idleness Http Endpoint

Pull Request Description

close #1829
PR implements an GET / _idle request that returns a number of seconds the Language Server is idle (since the last request from IDE). The endpoint is required to implement auto shutdown feature in the cloud.
Important Notes

Checklist
Please include the following checklist in your PR:

[x] The documentation has been updated if necessary.
[x] All code conforms to the Scala, Java, and Rust style guides.
[x] All documentation and configuration conforms to the markdown and YAML style guides.
[x] All code has been tested where possible.

Only thing is that you forgot to add it to the README.md in the language-server directory.


Error during try-convert step

Describe the bug
Step 2. [Failed] Convert project file to SDK style
Unexpected error during upgrade.
System.InvalidOperationException: Sequence contains no matching element
To Reproduce

Create a net48 class library project
Add an ApiController
Run upgrade assistant on the project

Exceptions (if any)
[15:23:14 INF] Saving upgrade progress file at D:....upgrade-assistant
[15:23:14 ERR] Unexpected error during upgrade.
System.InvalidOperationException: Sequence contains no matching element
   at System.Linq.ThrowHelper.ThrowNoMatchException()
   at System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
   at Microsoft.DotNet.UpgradeAssistant.MSBuild.MSBuildProject.GetAllDependencies(TargetFrameworkMoniker tfm) in /_/src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/MSBuildProject.NuGetPackages.cs:line 158
   at Microsoft.DotNet.UpgradeAssistant.MSBuild.MSBuildProject.ContainsDependency(TargetFrameworkMoniker tfm, Func`2 filter) in /_/src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/MSBuildProject.NuGetPackages.cs:line 140
   at Microsoft.DotNet.UpgradeAssistant.MSBuild.MSBuildProject.<>c__DisplayClass64_0.<IsTransitivelyAvailable>b__0(TargetFrameworkMoniker tfm) in /_/src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/MSBuildProject.NuGetPackages.cs:line 99
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
   at Microsoft.DotNet.UpgradeAssistant.MSBuild.MSBuildProject.IsTransitivelyAvailable(String packageName) in /_/src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/MSBuildProject.NuGetPackages.cs:line 99
   at Microsoft.DotNet.UpgradeAssistant.MSBuild.ComponentIdentifier.<>c__DisplayClass2_0.<GetGeneralProjectComponentsAsync>b__1(String package) in /_/src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/ComponentIdentifier.cs:line 92
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
   at Microsoft.DotNet.UpgradeAssistant.MSBuild.ComponentIdentifier.GetGeneralProjectComponentsAsync(IProject project, IProjectFile file, CancellationToken token) in /_/src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/ComponentIdentifier.cs:line 92
   at Microsoft.DotNet.UpgradeAssistant.MSBuild.ComponentIdentifier.GetComponentsAsync(IProject project, CancellationToken token) in /_/src/components/Microsoft.DotNet.UpgradeAssistant.MSBuild/ComponentIdentifier.cs:line 25
   at Microsoft.DotNet.UpgradeAssistant.ProjectExtensions.AppliesToProjectAsync(Type type, IProject project, CancellationToken token) in /_/src/common/Microsoft.DotNet.UpgradeAssistant.Abstractions/ProjectExtensions.cs:line 60
   at Microsoft.DotNet.UpgradeAssistant.Steps.Configuration.ConfigUpdaterSubStep.IsApplicableImplAsync(IUpgradeContext context, CancellationToken token) in /_/src/steps/Microsoft.DotNet.UpgradeAssistant.Steps.Configuration/ConfigUpdaterSubStep.cs:line 40
   at Microsoft.DotNet.UpgradeAssistant.UpgradeStep.IsApplicableAsync(IUpgradeContext context, CancellationToken token) in /_/src/common/Microsoft.DotNet.UpgradeAssistant.Abstractions/UpgradeStep.cs:line 212
   at Microsoft.DotNet.UpgradeAssistant.Cli.ConsoleUpgrade.<>c__DisplayClass9_0.<<ShowUpgradeStepsAsync>b__0>d.MoveNext() in /_/src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/ConsoleUpgrade.cs:line 134
--- End of stack trace from previous location ---
   at System.Linq.AsyncEnumerable.WhereEnumerableAsyncIteratorWithTask`1.MoveNextCore() in /_/Ix.NET/Source/System.Linq.Async/System/Linq/Operators/Where.cs:line 277
   at System.Linq.AsyncIteratorBase`1.MoveNextAsync() in /_/Ix.NET/Source/System.Linq.Async/System/Linq/AsyncIterator.cs:line 77
   at System.Linq.AsyncIteratorBase`1.MoveNextAsync() in /_/Ix.NET/Source/System.Linq.Async/System/Linq/AsyncIterator.cs:line 77
   at Microsoft.DotNet.UpgradeAssistant.Cli.ConsoleUpgrade.ShowUpgradeStepsAsync(IEnumerable`1 steps, IUpgradeContext context, CancellationToken token, UpgradeStep currentStep, Int32 offset) in /_/src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/ConsoleUpgrade.cs:line 134
   at Microsoft.DotNet.UpgradeAssistant.Cli.ConsoleUpgrade.ShowUpgradeStepsAsync(IEnumerable`1 steps, IUpgradeContext context, CancellationToken token, UpgradeStep currentStep, Int32 offset) in /_/src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/ConsoleUpgrade.cs:line 134
   at Microsoft.DotNet.UpgradeAssistant.Cli.ConsoleUpgrade.ShowUpgradeStepsAsync(IEnumerable`1 steps, IUpgradeContext context, CancellationToken token, UpgradeStep currentStep, Int32 offset) in /_/src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/ConsoleUpgrade.cs:line 148
   at Microsoft.DotNet.UpgradeAssistant.Cli.ConsoleUpgrade.ShowUpgradeStepsAsync(IEnumerable`1 steps, IUpgradeContext context, CancellationToken token, UpgradeStep currentStep, Int32 offset) in /_/src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/ConsoleUpgrade.cs:line 134
   at Microsoft.DotNet.UpgradeAssistant.Cli.ConsoleUpgrade.RunAsync(CancellationToken token) in /_/src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/ConsoleUpgrade.cs:line 59
   at Microsoft.DotNet.UpgradeAssistant.Cli.ConsoleUpgrade.RunAsync(CancellationToken token) in /_/src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/ConsoleUpgrade.cs:line 94
   at Microsoft.DotNet.UpgradeAssistant.Cli.ConsoleRunner.RunCommandAsync(CancellationToken token) in /_/src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/ConsoleRunner.cs:line 86
   at Microsoft.DotNet.UpgradeAssistant.Cli.ConsoleRunner.StartAsync(CancellationToken token) in /_/src/cli/Microsoft.DotNet.UpgradeAssistant.Cli/ConsoleRunner.cs:line 44

Further technical details

Include the output of upgrade-assistant --version
version '0.2.222101'

Same issue here -- did you manage to fix @sunandabalu?

Actually, just figured out a fix for this ... delete the bin and obj folders in the project and it then works.

Yes, we should fix this so that it doesn't happen but the workaround for now is to delete the obj folder.

In my case this sadly doesn't work, they bin and obj-folders get re-created automatically, and then I run into the Sequence contains no matching element exception from this issue.
Any other suggestions or workaround?

@twsouthwick taking a look along with #436

This is a duplicate with #436


jsq_didReceiveDeviceOrientationDidChangeNotification constantly clears the message bubble size cache

New issue checklist

[X] I have read the README, documentation, and FAQ.
[X] Contributing guidelines confirmation: ____
[X] I have searched existing issues and this is not a duplicate.

General information

JSQMessagesViewController version: Customized copy of code probably 12 months old
iOS version: 10.2.1
Devices/Simulators:
Reproducible in the demo project? (Yes/No): Probably
Any related issues:

What happened?
I noticed that JSQMessagesBubblesSizeCalculator.m prepareForResettingLayout is constantly getting called because jsq_didReceiveDeviceOrientationDidChangeNotification is getting triggered by a supposed screen orientation change. And this results in clearing the sizes cache.
My app does not allow screen rotation but this gets triggered frequently during app usage (scrolling chat view, etc). While I am using a heavily customized (hacked legacy code), I can see that this might still be an issue with the current code.
2017-03-31 12:43:30.979703 Genie[3063:912451] Callstack: (
	0   Genie                               0x00000001000dcea4 -[JSQMessagesBubblesSizeCalculator prepareForResettingLayout:] + 104
	1   Genie                               0x00000001000eacfc -[JSQMessagesCollectionViewFlowLayout jsq_resetLayout] + 72
	2   Genie                               0x00000001000e95a0 -[JSQMessagesCollectionViewFlowLayout jsq_didReceiveDeviceOrientationDidChangeNotification:] + 68

References:

https://github.com/jessesquires/JSQMessagesViewController/blob/develop/JSQMessagesViewController/Layout/JSQMessagesBubblesSizeCalculator.m
https://github.com/jessesquires/JSQMessagesViewController/blob/develop/JSQMessagesViewController/Layout/JSQMessagesCollectionViewFlowLayout.m

Personally, I removed the call to jsq_resetLayout and it works. Optionally, you can remove the next line, but since invalidateFlowLayoutMessagesCache is never set to true, it is not an issue for me. However, I'm sure a real fix would take into account screen rotation.

Also note that the sizes cache gets emptied every time the app enters the background and that is the standard behavior of NSCache. I was also having problems with my own NSCache usage and found that it is necessary to implement NSDiscardableProtocol on my cacheable objects.

http://stackoverflow.com/questions/13163480/nscache-and-background/13579963#13579963
https://developer.apple.com/reference/foundation/nsdiscardablecontent

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Y

Package Name:
Package Version:
Operating System:
Python Version:

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
1.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Hi @vpatao6p! I'm guessing you didn't intend to open this issue. If I'm wrong, please add some information about the problem you're experiencing and reopen this issue.


Fixed incorrect matching expression for webhook

This commit is to fix incorrect usage of the regular expression
when the wehook handler (PHP) checke "@open sesame" tag.

Input (PR title): a model is updatable - @open sesame 12/03 16:47
Before this PR: "@open sesame 12/03 16:4"
After  this PR: "@open sesame 12/03 16:47"

Signed-off-by: Geunsik Lim<EMAIL_ADDRESS>

:memo: Version: 1.3.20190927. Thank you for submitting PR #598. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.


how can i use pushState in other view?

I can use pushState in main-view pages,but in  other view pages, the pushState is invalid,what is wrong?tks~
I have two view.
var mianView = F7.addView('.mian-view', {
    dynamicNavbar: false
});
can use pushState

var ucenterView = F7.addView('.ucenter-view', {
    dynamicNavbar: false
});
can't use pushState

Sorry, but push state is supported only in main view

Oh I see，thanks


Handle attachments if needed by Twisted Trac

Currently, the ticket migration script does not support attachments, as the Chevah Trac only had 7 of them.
If needed by Twisted Trac, create an attachment scraper, commit the attachments to a GH repo in a branch outside of main, and add links to the attachments either from the description, or ticket comments.

For reference here is a Trac ticket with attachments https://twistedmatrix.com/trac/ticket/4419
The link to the attach is something like this
https://twistedmatrix.com/trac/attachment/ticket/4419/0002-Deprecate-and-ignore-replies-to-a-NOTICE-event-in-IR.2.patch
with actual file at https://twistedmatrix.com/trac/raw-attachment/ticket/4419/0002-Deprecate-and-ignore-replies-to-a-NOTICE-event-in-IR.2.patch
I can give you access to Twisted trac instance to take a look... I have no idea where these files are stored on disk.
The plan is something like this:

get all the Trac attachments (wiki and tickets) into a github repo with a certain structure (no need for git-lfs)
Publish the files as plain HTTP via GitHub Pages
Use the links to add comments or description to the migrated tickets

Migrating attachments to https://github.com/twisted/twistedmatrix.com-trac-attachments


Fix lastmod times in site index

Reviewer checklist

[ ] Read the contributing guide
[ ] PR should be motivated, i.e. what does it fix, why, and if relevant, how
[ ] Ensure relevant issues are linked (description should include text like "Fixes #")
[ ] Ensure any appropriate documentation has been added or amended

Coverage: 96.269%. Remained the same when pulling 00736c51ff30835c750b2ffb1917d78517348061 on sitemap_times into 83e8e25d594523283d6af65378caee57687c1ee7 on main.


Implement Tests for Scenario Queries that cover all cases

General queries test and yield curve test to include cases with scenarios:
YieldCurve : Test Load Yield Curve => IFRS 17 Calculation Engine > Test > QueriesTest
IfrsVariable queries in ImportStorage : Test IfrsVariables Query => IFRS 17 Template > Test > ImportStorageTest

Hi @amuolo @calderinisystemorph
Have a look at these tests mentioned above I think they should be updated with scenario use cases.
Thanks


Add test for calculating decompressedDirectByteBufferSize via offset

Fix a typo on decompressedSize methods
It is currently not possible to calculate decompressedSize on byte[]'s directly if the compressed data is offset.
One needs to allocate a direct ByteBuffer and then copy the byte[] into that buffer to use the decompressedDirectByteBufferSize (the tests shows such an example).
Would it be possible to add a feature which adds an offset/length to the decompressedSize method which operates on byte arrays? I've mocked the method signature to show what I'm thinking of (no need to merge these, really, just made the PR to propose the feature).
I've also added a failing test which demonstrates that it's not possible to work around this by using ByteBuffer.wrap(byte[]),
one needs to copy the byte[] into a direct ByteBuffer instead (or, of course, work with direct byte buffers entirely)...

Hi, sounds reasonable. I am currently on a vacation so I will look into it in a few in a week or so.

I've also added a failing test which demonstrates that it's not possible to work around this by using ByteBuffer.wrap(byte[]),

Yes, this doesn't produce DirectByteBuffer. I have just added a method that also takes the offset


Support of pip installation of repo via pip. Closes #2276

Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #2276
What are the significant changes in functionality due to this change request?
Addition of the possibility in the library_hadler to accept a keyword "repo" to indicate that a dependency should be installed from a GitHub repository directly (using pip install git+https)

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[x] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job Test CentOS 8 on e9e6f83 : invalidated by @wangcj05
envs issue

Job Test qsubs sawtooth on e9e6f83 : invalidated by @alfoa

Job Test CentOS 8 on e9e6f83 : invalidated by @alfoa

Hm, can you give an example of how this would be used (sample dependencies.xml?) Thanks.

Absolutely.
Here it as an example:
<dependencies>
  <main>
    <networkx/>
    <pytest/>
    <pyomo source='forge'/>
    <glpk source='forge' skip_check='True'/>
    <shapely source="pip"/>
    <armi source="pip"  repo="https://github.com/terrapower/armi.git"/>
  </main>

</dependencies>

@alfoa This PR looks good to me. One suggestion is to put an example in our dependency file (using commented lines), since we do not have documentation for library handling.
@joshua-cogliati-inl Do you have any comments on this PR?

Perfect. Added

PR checklist is good. PR can be merged.


Fork API server context into random and sequential variants.

Issue Number
#808
Overview
This PR forks the API server context into two variants:

a random context that corresponds to Byron wallets.
a sequential context that corresponds to modern wallets.

Remaining Work

[x] Discriminate between random and sequential wallets at the file-system level.

bors try

bors try

bors try

bors r+

bors r+


DEV2-2532 enterprise status bar flow

This pr introduces five steps that are represented in the status bar:

The user needs to set the server URL. - The status bar will show a warning (yellow) indication and provide a "Set Settings" action.
The user needs to be logged in. - The status bar will show a warning indication and provide a login action.
Waiting for the binary to start. - The status bar will display a loading animation.
In case of any failure.  The status bar will show an error indication (red).
After a successful binary start, the status bar will display the label "Tabnine".

TBD - test, WIP in diferent pr

@dimacodota can we add another error where the user is logged in but not part of the team as "you need to log in" too error?

@dimacodota can we add another error where the user is logged in but not part of the team as "you need to log in" too error?

sure ill add it

@dimacodota need a warning status bar if the user has tabnine installed along with the self-hosted version

@dimacodota is this being merged?
Can you patch this :
https://github.com/codota/tabnine-vscode/blob/206ecdbee67a365ff1e81a6a7bf416568a793144/src/enterprise/extension.ts#L140


highligh selecteitem in listView #340

@halatmit
Please have a look to see if it's enough for #340
It only focuses the item visually. The item is not actually focused but the ListView is. There should be some code to hack it so that the item is actually focused.
You may try it here.
~~http://ai2changes.appspot.com/~~

@jisqyv
Is there are companion we can use to test this?
Jeff, What's the right way for Ethan to provide a companion?  Do we have instructions about that?

@E-Hon @halatmit simply provide a link to download the apk; I generally use a public dir in dropbox, but any other accessible way is valid.

Thx @josmas . This will do.
Please download and install this apk to test the change
https://www.dropbox.com/s/ubz6e8fxc8apz6c/Highlight_ListView.apk?dl=0

@E-Hon  , in the apk provided, I have to double tap the list view to make it focused. My device is gingerbread (2.3.6) .
As for making it really focusable I think its not recommended when you are in touch mode. I have tried force fully focusing it, but it produces inconsistent touch behavior (touch doesn't work after focusing an item).
(read this http://android-developers.blogspot.in/2008/12/touch-mode.html)
When your not in touch mode (using Dpad or keyboard or trackball etc.. ) the focus works properly as its supposed to.
I think what @halatmit meant is to give a visual feedback on the selected item. Which need not really focus the item. ?

@E-Hon , you might want to try choice mode for ListView
http://developer.android.com/reference/android/widget/AbsListView.html#attr_android:choiceMode

@thequixotic Thx for the guidance. This is a better solution! I am going to try it

Following @thequixotic 's suggestion, it now uses choice mode instead of focus. Further, I added a default selector color. @halatmit @josmas do you think selector color should be chosen by users?
Please try it here (apk)
https://www.dropbox.com/s/ubz6e8fxc8apz6c/Highlight_ListView.apk?dl=0

Nice!
Yes, I think users should be able to set the selector color as a property.
== Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
MIT Media Lab, Second Class Faculty
On Sun, Apr 12, 2015 at 10:04 PM, E-Hon<EMAIL_ADDRESS>wrote:

Following @thequixotic https://github.com/thequixotic 's suggestion, it
now uses choice mode instead of focus. Further, I added a default selector
color. @halatmit https://github.com/halatmit @josmas
https://github.com/josmas do you think selector color should be chosen
by users?
Please try it here (apk)
https://www.dropbox.com/s/ubz6e8fxc8apz6c/Highlight_ListView.apk?dl=0
—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-92171152
.

Please try the demo app with the latest change here
https://www.dropbox.com/s/5w69u1i4au3q929/Test0.apk?dl=0

Nice.
You may as well add the Chinese strings for the new property.
@jisqyv Does he need to add keys to the internationlization table, or is your code to do that automatically already merged into maaster?

@E-Hon , have you tried this in on lower android versions. I have a gingerbread device  (2.3) and this is what I get ..
When I touch an item the entire listview (not just the item ) becomes highlighted with a random color and upon removing my finger all highlight goes.
It does work well in my android 4.4 (device). I think App Inventor recommends to be consistent from android 1.5 .. but Good job.
But I think the issue is that you setSelector for entire list view instead of just the individual view items generated by ArrayAdapter.

@thequixotic Thx for your information.
The code does setSelector for the entire list view. That method is not for individual items.
I only tried it on JellyBean as I don't have other android devices. Can you help writing native android code to test if it still occurs on gingerbread?

@halatmit Besides OdeMessages_zh_TW.properties and OdeMessages_zh_CN.properties, any other files I should update?
The property is translated in Blocks view, but not in Designer

See issue #340

@E-Hon - Ethan, looked at the demo... exactly what I was thinking about and hoping for.  Very well done!

@EnisM Thx, let me finalize it and let's hope it will get merged by then

Hi @thequixotic I found out the root cause for what you described.
According to this page, http://cyrilmottier.com/2011/08/08/listview-tips-tricks-3-create-fancy-listviews/
ColorDrawable, which I used, was buggy before Honeycomb. "it does not respect its bounds"

If this does not work before Honeycomb, then make sure the behavior degrades gracefully on older systems.

As of commit 89aab4f,
Test AI client
http://ai2changes.appspot.com
Companion for the latest changes
https://www.dropbox.com/s/hxbbsi32dxun9tz/MIT AI2 Companion.apk?dl=0

@halatmit I changed to use GradientDrawable which worked well for that problem

Ethan:
Is this message about the thing we were discussing?  The ListView?  Do you
want me to test this?
On Apr 19, 2015 8:56 AM, "E-Hon"<EMAIL_ADDRESS>wrote:

@halatmit https://github.com/halatmit I changed to use GradientDrawable
which worked well for that problem
—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-94274225
.

@EnisM ah no, I was referring to the problem pointed out by @thequixotic
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-92346019

Ok thanks...
On Apr 19, 2015 9:05 AM, "E-Hon"<EMAIL_ADDRESS>wrote:

@EnisM https://github.com/EnisM ah no, I was referring to the problem
pointed out by @thequixotic https://github.com/thequixotic
#357 (comment)
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-92346019
—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-94274970
.

Looking good!
Couple of comments:

What is the scrollbar at the right of the listview in the designer for?  It doesn't seem to to anything. Maybe it's OK, since the scrollbar on the phone works.
Look at how the listview behaves when the screen is scrollable:  It's very short.  That might be OK, but play with it.
If you set the selection index programmatically (e.g., with do-it), the highlighting doesn't change.

I also tried this on Froyo (2.2.2), which has additional issues:

the items don't remain highlighted when you lift your finger.    This is be OK if it's too hard to fix, but take a look at it. If we can't make it work back to Gingerbread, then OK, but leave a comment in the code.

It MAY be that that was the behavior in Froyo or Gingerbread...
On Sun, Apr 19, 2015 at 10:29 AM, hal<EMAIL_ADDRESS>wrote:

Looking good!
Couple of comments:

What is the scrollbar at the right of the listview in the designer
for? It doesn't seem to to anything. Maybe it's OK, since the scrollbar on
the phone works.
Look at how the listview behaves when the screen is scrollable: It's
very short. That might be OK, but play with it.
If you set the selection index programmatically (e.g., with do-it),
the highlighting doesn't change.

I also tried this on Froyo (2.2.2), which has additional issues:

the items don't remain highlighted when you lift your finger. This
is be OK if it's too hard to fix, but take a look at it. If we can't make
it work back to Gingerbread, then OK, but leave a comment in the code.

—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-94282224
.

Enis,
You should be able verify this with Genymotion.
So far, we want to support back to Gingerbread, but that might change with
API4.
== Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
MIT Media Lab, Second Class Faculty
On Sun, Apr 19, 2015 at 10:37 AM, EnisM<EMAIL_ADDRESS>wrote:

It MAY be that that was the behavior in Froyo or Gingerbread...
On Sun, Apr 19, 2015 at 10:29 AM, hal<EMAIL_ADDRESS>wrote:

Looking good!
Couple of comments:

What is the scrollbar at the right of the listview in the designer
for? It doesn't seem to to anything. Maybe it's OK, since the scrollbar
on
the phone works.
Look at how the listview behaves when the screen is scrollable: It's
very short. That might be OK, but play with it.
If you set the selection index programmatically (e.g., with do-it),
the highlighting doesn't change.

I also tried this on Froyo (2.2.2), which has additional issues:

the items don't remain highlighted when you lift your finger. This
is be OK if it's too hard to fix, but take a look at it. If we can't make
it work back to Gingerbread, then OK, but leave a comment in the code.

—
Reply to this email directly or view it on GitHub
<
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-94282224
.

—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-94282888
.

@halatmit

What is the scrollbar at the right of the listview in the designer for? It doesn't seem to to anything. Maybe it's OK, since the scrollbar on the phone works.
I think this is the result of using GWT's VerticalPanel in MockListView

Look at how the listview behaves when the screen is scrollable: It's very short. That might be OK, but play with it.
When Height is set to Automatic, this occurs (I guess ?). Is this behavior expected or a bug of Height property in ListView?

If you set the selection index programmatically (e.g., with do-it), the highlighting doesn't change.
I am going to look into this

the items don't remain highlighted when you lift your finger. This is be OK if it's too hard to fix, but take a look at it. If we can't make it work back to Gingerbread, then OK, but leave a comment in the code.
oh, I thought we just needed to support back to Gingerbread

I think this is the result of using GWT's VerticalPanel in MockListView
That's OK then.   Not critical to change

When Height is set to Automatic, this occurs (I guess ?). Is this behavior expected or a bug of Height property in ListView?
I think it's because screen height might return 0 when the screen is scrollable.  `See if you can make things better.
I am going to look into this
Good.  that needs to me fixed
oh, I thought we just needed to support back to Gingerbread
That's correct: We need to go only back to Gingerbread, so if it works on Gingerbread that's OK.  does it work there?

OK Hal... I'll give it a try in a little bit... Had a rough 2 weeks with my
Dad.
Refresh for me please... Gingerbread is what API?
On Sun, Apr 19, 2015 at 11:01 AM, hal<EMAIL_ADDRESS>wrote:

I think this is the result of using GWT's VerticalPanel in MockListView
That's OK then. Not critical to change
When Height is set to Automatic, this occurs (I guess ?). Is this behavior
expected or a bug of Height property in ListView?
I think it's because screen height might return 0 when the screen is
scrollable. `See if you can make things better.
I am going to look into this
Good. that needs to me fixed
oh, I thought we just needed to support back to Gingerbread
That's correct: We need to go only back to Gingerbread, so if it works on
Gingerbread that's OK. does it work there?
—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-94285820
.

Do a web search under android versions and you'll get the entire list.
== Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
MIT Media Lab, Second Class Faculty
On Sun, Apr 19, 2015 at 7:55 PM, EnisM<EMAIL_ADDRESS>wrote:

OK Hal... I'll give it a try in a little bit... Had a rough 2 weeks with my
Dad.
Refresh for me please... Gingerbread is what API?
On Sun, Apr 19, 2015 at 11:01 AM, hal<EMAIL_ADDRESS>wrote:

I think this is the result of using GWT's VerticalPanel in MockListView
That's OK then. Not critical to change
When Height is set to Automatic, this occurs (I guess ?). Is this
behavior
expected or a bug of Height property in ListView?
I think it's because screen height might return 0 when the screen is
scrollable. `See if you can make things better.
I am going to look into this
Good. that needs to me fixed
oh, I thought we just needed to support back to Gingerbread
That's correct: We need to go only back to Gingerbread, so if it works on
Gingerbread that's OK. does it work there?
—
Reply to this email directly or view it on GitHub
<
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-94285820
.

—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-94326312
.

@halatmit
this feature is supported on Jellybean (API 19) or later

Good.  thanks.  Just comment on it in the source.
== Hal Abelson
<EMAIL_ADDRESS>Prof. of Comp. Sci. and Eng.
MIT Dept. of Elec. Eng. and Comp. Sci.
MIT Media Lab, Second Class Faculty
On Wed, Apr 22, 2015 at 7:27 PM, E-Hon<EMAIL_ADDRESS>wrote:

@halatmit https://github.com/halatmit
this feature is supported on Jellybean (API 19) or later
—
Reply to this email directly or view it on GitHub
https://github.com/mit-cml/appinventor-sources/pull/357#issuecomment-95366629
.

Added in commit b40f993

LGTM

Note: This is a component change so will go to the "ucr" branch.

@E-Hon @halatmit I'm doing my final review and testing on this in preparation for merging.

@E-Hon @halatmit Note: This will be merged into the "ucr" branch for the upcoming Component Release

MERGED into the ucr branch


Update doc guidance for MSBuild to get vcpkg via submodule

The homepage currently recommends getting VCPkg via a submodule for CMake projects but installing it globally for MSBuild.
Can this recommendation be updated to recommend a submodule for all cases? MSBuild integration (adding the targets file) works with a submodule, and is much cleaner than having to reference something outside the repository.

https://github.com/microsoft/vcpkg#:~:text=In order to,continue here.

In order to use vcpkg with Visual Studio, run the following command (may require administrator elevation):

.\vcpkg\vcpkg integrate install
After this, you can now create a New non-CMake Project (or open an existing one). All installed libraries are immediately ready to be #include'd and used in your project without additional configuration.

If you're using CMake with Visual Studio, continue here.

Thanks for posting this issue. The README has content related to MSBuild integration, the above is it. It separates from the introduction of CMake.

We hope your question was answered to your satisfaction; if it wasn't, you can reopen with more info.

@LilyWangLL - I'd like to see us update the README not to say that submodules are for CMake only - if submodules are the best answer for CMake because they keep the repo self-contained, I think the same is true for MSBuild, and we shouldn't recommend a global install for MSBuild users.
Could we update the readme to recommend using a submodule regardless of which build system you're using?

Also, I don't seem to have a way to re-open this issue - could you please do so for me?

@davidmatson

MSBuild integration (adding the targets file) works with a submodule

I'm sorry, I'm not quite clear about the specific operation here. Could you please provide more details? For example, what exactly is meant by a "submodule" in this context?

@davidmatson

MSBuild integration (adding the targets file) works with a submodule

I'm sorry, I'm not quite clear about the specific operation here. Could you please provide more details? For example, what exactly is meant by a "submodule" in this context?

A git submodule. I submitted a PR with the proposed fixes here - let me know if that clarifies.


fix: spacing between account-menu and minimize

Description:
Changed the spacing between account menu and minimize button.
Aligned the spacing to the border of the minimize button and added additional 8px (green box in Screenshot 2) which is the spacing between account-menu and notifications button to have a overall cleaner look when hovering over the minimize button.
Screenshots:
OLD:

NEW:

Many thanks for the fix!


Actually make collections PRS enabled in tests

Fixes issues with https://github.com/apache/solr/pull/2230, where collections didn't have the PRS flag enabled when the default was enabled.
This does break tests, so it can't be merged without fixing the issues with PRS.

So the change is to non-test code but it's actually about tests?  Would it be more accurate to say that there was a partial/broken attempt to make a cluster-wide default for PRS but this PR completes that?
nit: assuming this system property isn't really advertised/documented, I'd rather it be "solr.cloud.prs" (maybe ".enabled" suffix) and not have the word "default" in it.  No sys props needs "default" as a system prop by its very nature is a kind of default.

It is not advertised at all, I believe it is just used for testing. But I think default in the name is fine. Solr.cloud.prs=true, doesn't really tell me what I'm setting to true. Maybe enabled, but that sounds like you are allowing/disallowing something. Maybe we put "test" in the name so that it's clear this is just for testing?

Even if today we only use it for testing (because only we know of its secret existence), isn't the same mechanism appropriate for a cluster?  It needn't be the only way to set it, of course; I could imagine additional layers like cluster props or solr.xml.
solr.cloud.prs.enabled then