factory_bot 5.1.0 does not play nicely with jruby (lambdas don't splat the way they should)

Steps to reproduce
~/Development/scrach master * bundle console
jruby-<IP_ADDRESS> :001 > require 'factory_bot'
ArgumentError: wrong number of arguments (1 for 2)
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/factory_bot-5.1.0/lib/factory_bot/internal.rb:89:in `register_strategy'
	from org/jruby/RubyHash.java:1350:in `each'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/factory_bot-5.1.0/lib/factory_bot/internal.rb:89:in `register_default_strategies'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/factory_bot-5.1.0/lib/factory_bot.rb:124:in `<main>'
	from org/jruby/RubyKernel.java:956:in `require'
	from (irb):1:in `<eval>'
	from org/jruby/RubyKernel.java:995:in `eval'
	from (irb):1:in `evaluate'
	from org/jruby/RubyKernel.java:1316:in `loop'
	from org/jruby/RubyKernel.java:1138:in `catch'
	from org/jruby/RubyKernel.java:1138:in `catch'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/bundler-2.0.2/lib/bundler/cli/console.rb:19:in `run'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/bundler-2.0.2/lib/bundler/cli.rb:496:in `console'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/bundler-2.0.2/lib/bundler/cli.rb:27:in `dispatch'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/bundler-2.0.2/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/bundler-2.0.2/lib/bundler/cli.rb:18:in `block in start'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/bundler-2.0.2/exe/bundle:30:in `(root)'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/bundler-2.0.2/lib/bundler/friendly_errors.rb:124:in `<main>'
	from org/jruby/RubyKernel.java:974:in `load'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/gems/bundler-2.0.2/exe/bundle:22:in `<eval>'
	from org/jruby/RubyKernel.java:995:in `eval'
	from /Users/dsimms/.rvm/gems/jruby-<IP_ADDRESS>/bin/bundle:1:in `<main>'
jruby-<IP_ADDRESS> :002 >
~/Development/scrach master * rvm list
=> jruby-<IP_ADDRESS> [ x86_64 ]
   ruby-2.4.4 [ x86_64 ]
 * ruby-2.4.5 [ x86_64 ]
   ruby-2.5.3 [ x86_64 ]
   ruby-2.5.5 [ x86_64 ]
   ruby-2.6.2 [ x86_64 ]
   ruby-2.6.3 [ x86_64 ]

# => - current
# =* - current && default
#  * - default

Expected behavior
factory_bot does't even load
Actual behavior
should load
System configuration
factory_bot version:  5.1.0
rails version:  none
ruby version: jruby-<IP_ADDRESS>

Based on the error message I think this was caused by f82e40c8c50c538c0fba0362c0f6b7f6f96f9a3c. Is there a known bug in jruby that would prevent us from running https://github.com/thoughtbot/factory_bot/blob/ad7a58d304243bc2aa5f505be3d75a2effe18195/lib/factory_bot/internal.rb#L89
If so, we could work around that by getting rid of the constant entirely and going back to
    register_strategy(:build,          FactoryBot::Strategy::Build)
    register_strategy(:create,         FactoryBot::Strategy::Create)
    register_strategy(:attributes_for, FactoryBot::Strategy::AttributesFor)
    register_strategy(:build_stubbed,  FactoryBot::Strategy::Stub)
    register_strategy(:null,           FactoryBot::Strategy::Null)

We may also need to do that with register_default_callbacks.
I would be glad to keep factory_bot working with jruby (even though we did stop testing against it in 9f1b32e07100d9a7da5439532b14cb7c349a2563 because the tests had been failing for quite some time), but it would be good for somebody who uses jruby to take the lead on that. Is this something you would be interested in working on?

I filed a new bug with JRuby about this: https://github.com/jruby/jruby/issues/5896

@composerinteralia I made a pull request for this in #1335.

Thanks y'all!


Support ojdbc8

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[x] New feature provided

[ ] Improve performance

Related issues
#1391

Coverage remained the same at 24.68% when pulling 604a481411e87c82f6d0ef1c39133e98f9e50af1 on ascrutae:feature/support-ojdbc8 into 46c0e76ef943ab4a4b89ec315a006107e069d54d on apache:master.


Feature/navigation level one styling

Link to Ticket
Description of Changes Made
Following on from the back-end changes, this introduces a new drop-down style in the navigation that only shows the immediate children of the primary navigation items. It is smaller than the mega dropdown that shows both children and grandchildren.
It also ensures that the navigation settings are respected at mobile.
How to Test
In the pattern library at http://localhost:8000/pattern-library/render-pattern/patterns/organisms/header/header.html
Or in your build, edit the navigation settings at http://localhost:8000/admin/settings/navigation/navigationsettings/1/ and then see the changes reflected in the build.
We are not expecting to have drop-downs in the last 2 menu items, but I have added a right-aligned style for these just in case, so that they do not disappear off the edge of the screen.
Screenshots

Expand to see more
![Screenshot 2024-03-08 at 13 14 15](https://github.com/torchbox/torchbox.com/assets/771869/5c741317-ce76-4d8d-9b91-1c77f2dc246f)

MR Checklist

[x] Add a description of your pull request and instructions for the reviewer to verify your work.
[x] If your pull request is for a specific ticket, link to it in the description.
[x] Stay on point and keep it small so the merge request can be easily reviewed.
[x] Tests and linting passes.

Unit tests

[ ] Added
[x] Not required

Documentation

[x] Updated build docs
[x] Updated editor guidelines (https://docs.google.com/document/d/1PAWccdQ4tfaZsrEWmpDhvP3GH5RRmBOARFVp4b-kje8/edit?usp=sharing)
[ ] Not required

Browser testing

[x] I have tested in the following browsers and environments (edit the list as required)

Latest version of Chrome on mac
Latest version of Firefox on mac
Latest version of Safari on mac
Safari on last two versions of iOS
Chrome on last two versions of Android

[ ] Not required

Data protection

[x] Not relevant
[ ] This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Accessibility

[x] Automated WCAG 2.1 tests pass
[x] Manual WCAG 2.1 tests completed
[x] I have tested in a screen reader
[x] I have tested in high-contrast mode
[ ] Any animations removed for prefers-reduced-motion
[ ] Not required

Sustainability

[ ] Images are optimised and lazy-loading used where appropriate
[ ] SVGs have been optimised
[ ] Perfomance and transfer of data considered
[ ] If JavaScript is needed alternatives have been considered
[x] Not required

Pattern library

[x] The pattern library component for this template displays correctly, and does not break parent templates
[ ] The styleguide is updated if relevant
[ ] Changes are not relevant the pattern library

Nice one @helenb - this is a good improvement.
One thing I did spot when testing is that in the mobile menu, when you go down a level and click the close button, you are taken back up a level rather than the mobile menu being closed.
Screen.Recording.2024-03-08.at.16.13.36.mov

Thanks for spotting that @chris-lawton. After testing, this seemed to be due to the code that was checking if a click was inside the menu, and closing it if not - clicking on the button was initially being detected as outside the menu, and closing it, then the button event was kicking in and opening it again. The easiest fix was to remove this functionality at mobile - there is very little screen space to click outside the menu anyway in order to close it. Resolved in https://github.com/torchbox/torchbox.com/pull/156/commits/fb60bbb7625ccff08a7f928f50360da7c65e3151.


Update API review migraton to support on demand migration of individu…

…al review

/check-enforcer override


#5967 dropdown visual changes

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #5967
[ ] Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality

Optional

[ ] I've tested it at </ksm/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address:
Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at dc6faf2
Improved the design and accessibility of the profile menu in the navbar, especially the language option. Added a new class language-heading in styles/layouts/_main-navigation.scss and applied it to the b-dropdown-item element in components/navbar/ProfileDropdown.vue.

🤖 Generated by Copilot at dc6faf2

The profile menu got a new look
With a language-heading class for the book
The b-dropdown-item changed its hue
And the code formatting improved too
Now the menu is more appealing to the cook

cc @exezbcz

pay 20 usd

sounds like bot wants upgrade for new links

pay 20 usd


[5.0] Methods not defined in the Application Contract used by Kernal's bootstrap Method.

hasBeenBootstrapped and bootstrapWith method is missing in the Application contract.
It's used in Illuminate\Foundation\Http\Kernal bootstrap method.
/**
* Bootstrap the application for HTTP requests.
*
* @return void
*/
public function bootstrap()
{
    if (!$this->app->hasBeenBootstrapped()) {
        $this->app->bootstrapWith($this->bootstrappers());
    }
}

The two methods (hasBeenBootstrapped and bootstrapWith) are NOT present in the Application interface.
I tried to add those methods in the interface, but my pull request is failing build test.

Duplicate,

We cannot add new methods to the contract now. It's fixed. Modifying it will break any other implementations.

There's no open duplicate of this as far as I can see.
This was originally brought up before the 5.0 release, but you closed it

This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:
<EMAIL_ADDRESS>Domain robson.com.br has exceeded the max emails per hour (209/200 (104%)) allowed.  Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext3.iad.github.net ([<IP_ADDRESS>]:32771 helo=github-smtp2b-ext-cp1-prd.iad.github.net)
by paris.serverbr15.com with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256)
(Exim 4.84)
(envelope-from<EMAIL_ADDRESS>id 1YKqcl-001rgn-SK
for<EMAIL_ADDRESS>Mon, 09 Feb 2015 13:51:48 -0200
Date: Mon, 09 Feb 2015 07:51:46 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
s=pf2014; t=1423497106;
bh=YGRcfooW5qc4I7mKLwwroElbXlU6IDvvuF3NHHuS2mo=;
h=From:Reply-To:To:In-Reply-To:References:Subject:List-ID:
List-Archive:List-Post:List-Unsubscribe:From;
b=LDozVDK6WKPqVd0mNzId1hAUOmeIrJRegl5RP0XPAsoEqIMWy2tek5eoU0Tbxl690
dc6vsPCW6G1TLPIFgHPaMTDoIQ3LHtkwkPKG8NcmIwUmXQbZ+WEx9h66LeadBiCUmy
JPUZOpZ5ENE3Nssd95rPDzEyB5ln9/PM87M24HNs=
From: Franz Liedke<EMAIL_ADDRESS>Reply-To: laravel/framework<EMAIL_ADDRESS>To: laravel/framework<EMAIL_ADDRESS>Message-ID<EMAIL_ADDRESS>In-Reply-To<EMAIL_ADDRESS>References<EMAIL_ADDRESS>Subject: Re: [framework] [5.0] Methods not defined in the Application Contract
used by Kernal's bootstrap Method. (#7344)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_54d8d79276af1_1aea3fd2f52872bc17443";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: franzliedke
X-GitHub-Recipient: robsoncombr
List-ID: laravel/framework <framework.laravel.github.com>
List-Archive: https://github.com/laravel/framework
List-Post<EMAIL_ADDRESS>List-Unsubscribe<EMAIL_ADDRESS>https://github.com/notifications/unsubscribe/AA4ZXctuT68elnx2NAzjcEaai4W2NYQZks5nqM8SgaJpZM4DdoWb
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address<EMAIL_ADDRESS>----==_mimepart_54d8d79276af1_1aea3fd2f52872bc17443
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit
There's no open duplicate of this as far as I can see.
This was originally brought up before the 5.0 release, but you closed it

Reply to this email directly or view it on GitHub:
https://github.com/laravel/framework/issues/7344#issuecomment-73531894
----==_mimepart_54d8d79276af1_1aea3fd2f52872bc17443
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit
There's no open duplicate of this as far as I can see.
This was originally brought up before the 5.0 release, but you closed it
—Reply to this email directly or view it on GitHub.

----==_mimepart_54d8d79276af1_1aea3fd2f52872bc17443--

Why are you closing this?
i don't see any duplicate issue.
Your interface might be fixed, but you are implementing it incorrectly.

There's no open duplicate of this as far as I can see.

There is. I've closed 3 of them.

This was originally brought up before the 5.0 release, but you closed it

That's because it was an incorrect solution that was causing fatal errors.

i have checked the issues and pull request, there doesn't seem to be another issue open.
I don't think it's correct to close this issue unless there is another OPEN  issue.
The fatal error was caused by incorrect implementation of the Application contract.
In my view, you should keep this issue open untill it is addressed.
If you think there is another duplicate issue, please provide the link to it.

I don't think it's correct to close this issue unless there is another OPEN issue.

It's not an issue. They've been closed.


import error of acsfwrapper in version 0.3.2

acsfwrapper cannot be imported in version 0.3.2
Here is the full conda env yml (as a .txt, otherwise github is not happy with it)
conda_env.yml.txt
In [2]: from dscribe.descriptors import SOAP
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-2-03308a51f02f> in <module>
----> 1 from dscribe.descriptors import SOAP

/opt/conda/envs/projection/lib/python3.7/site-packages/dscribe/descriptors/__init__.py in <module>
     15 """
     16 from dscribe.descriptors.descriptor import Descriptor
---> 17 from dscribe.descriptors.acsf import ACSF
     18 from dscribe.descriptors.mbtr import MBTR
     19 from dscribe.descriptors.lmbtr import LMBTR

/opt/conda/envs/projection/lib/python3.7/site-packages/dscribe/descriptors/acsf.py in <module>
     25 from ase import Atoms
     26
---> 27 from dscribe.libacsf.acsfwrapper import ACSFWrapper
     28 import dscribe.utils.geometry
     29

ModuleNotFoundError: No module named 'dscribe.libacsf.acsfwrapper'

The file exists in the env directory:
(projection) root@99c7ed173fe0:/opt/conda/envs/projection/lib/python3.7/site-packages/dscribe/libacsf# ls -l
total 364
-rw-rw-r-- 2 root root      0 Dec 25 22:17 __init__.py
drwxr-xr-x 2 root root   4096 Feb  6 12:42 __pycache__
-rw-rw-r-- 2 root root   6560 Dec 25 22:17 acsf.cpp
-rw-rw-r-- 2 root root   2082 Dec 25 22:17 acsf.h
-rw-rw-r-- 2 root root 241706 Dec 25 22:17 acsfwrapper.cpp
-rwxrwxr-x 2 root root 109696 Dec 25 22:17 acsfwrapper.cpython-37-x86_64-linux-gnu.so

but even in there it is not importable:
(projection) root@99c7ed173fe0:/opt/conda/envs/projection/lib/python3.7/site-packages/dscribe/libacsf# ipython
Python 3.7.3 | packaged by conda-forge | (default, Dec  6 2019, 08:54:18)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.12.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import acsfwrapper
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
<ipython-input-1-d7b8cade2c17> in <module>
----> 1 import acsfwrapper

ModuleNotFoundError: No module named 'acsfwrapper'

Hi @stenczelt ,
I cannot reproduce this issue on a clean python3.7 install using pip globally or within a virtualenv.
Both in this issue and #42 a conda environment is used. Maybe this has something to do with it? I will take a look into this.

I can reproduce the issue when installing dscribe with conda from conda-forge (i.e. conda install dscribe). The issue is however limited to the conda package manager, and is not present when installing with pip. The easiest work-around for now is to install dscribe with pip instead. You can do this even inside a conda environment with:
conda install pip
pip install pybind11
pip install dscribe

I would suggest using this for now until I can figure out the issue with the conda distribution.

The issue is now also fixed in the conda package (there was actually an issue with the conda build system itself, not with dscribe). Just update to the latest version from conda-forge.


Update active control on keyboard event not only on mouse event

Quick and dirty draft to fix #23
ActiveControl is now settable and will be set null if a parent in the ancestry is hidden.

I'll have to do some performance profiling here since it's in a potential hot path, but once done and hopefully good will hopefully get merged.  🙂

I haven't encountered any issues with the solution so far.
But my machine is not really low end, so I think some profiling would be nice.

Yes!
I was recently experimenting with hooking only to defined hotkeys so we do not check every single keystroke.
And I wanted to implement disabling the active control when one of its ancestors is detected to be invisible.
Since this is a long standing (non intruding) issue I don't see a problem with tackling ActiveControl cleanup here too.

Did you want to still put those changes in this PR or perhaps those can go into another?  🙂

No, I guess I'll open another PR for the cleanup stuff.
But I noticed that my changes do not fix #567. Looking at this right now.


custom-jhlite build failed

See https://github.com/jhipster/jhipster-lite/pull/4317
Probably related to the upgrade to Spring Boot 3 for the engine
It couldn't be detect because the jhlite custom build use a release version, instead of a snapshot one

How does it fail? Any stack trace/way to reproduce?

I see the below stack trace in build logs
Caused by: org.springframework.beans.BeanInstantiationException: Failed to instantiate [org.springdoc.webmvc.ui.SwaggerWelcomeWebMvc]: Factory method 'swaggerWelcome' threw exception; nested exception is java.lang.NoClassDefFoundError: org/springframework/http/HttpStatusCode
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:185)
	at org.springframework.beans.factory.support.ConstructorResolver.instantiate(ConstructorResolver.java:653)
	... 72 common frames omitted
Caused by: java.lang.NoClassDefFoundError: org/springframework/http/HttpStatusCode
	at org.springdoc.webmvc.ui.SwaggerConfig.swaggerWelcome(SwaggerConfig.java:83)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:154)
	... 73 common frames omitted
Caused by: java.lang.ClassNotFoundException: org.springframework.http.HttpStatusCode
	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:587)
	at org.springframework.boot.loader.LaunchedURLClassLoader.loadClass(LaunchedURLClassLoader.java:151)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	... 79 common frames omitted

Just did that on main
{
  "actions" : [ {
    "module" : "init",
    "date" : "2022-11-10T13:44:44.109637604Z",
    "properties" : {
      "packageName" : "com.mycompany.myapp",
      "projectName" : "JHipster Sample Application",
      "baseName" : "jhipsterSampleApplication",
      "serverPort" : 8080,
      "endOfLine" : "lf",
      "indentSize" : 2
    }
  }, {
    "module" : "maven-java",
    "date" : "2022-11-10T13:44:44.332285499Z",
    "properties" : {
      "packageName" : "com.mycompany.myapp",
      "projectName" : "JHipster Sample Application",
      "baseName" : "jhipsterSampleApplication",
      "serverPort" : 8080,
      "endOfLine" : "lf",
      "indentSize" : 2
    }
  }, {
    "module" : "java-base",
    "date" : "2022-11-10T13:44:44.370130567Z",
    "properties" : {
      "packageName" : "com.mycompany.myapp",
      "projectName" : "JHipster Sample Application",
      "baseName" : "jhipsterSampleApplication",
      "serverPort" : 8080,
      "endOfLine" : "lf",
      "indentSize" : 2
    }
  }, {
    "module" : "spring-boot",
    "date" : "2022-11-10T13:44:44.430207719Z",
    "properties" : {
      "packageName" : "com.mycompany.myapp",
      "projectName" : "JHipster Sample Application",
      "baseName" : "jhipsterSampleApplication",
      "serverPort" : 8080,
      "endOfLine" : "lf",
      "indentSize" : 2
    }
  }, {
    "module" : "custom-jhlite",
    "date" : "2022-11-10T13:44:44.482430208Z",
    "properties" : {
      "packageName" : "com.mycompany.myapp",
      "projectName" : "JHipster Sample Application",
      "baseName" : "jhipsterSampleApplication",
      "serverPort" : 8080,
      "endOfLine" : "lf",
      "indentSize" : 2
    }
  } ]
}

and it's working. What are the steps to reproduce?

The problem comes from a version shift for spring boot.Genetated apps comes with spring-boot-starter-web 2.7.5 instead of the required 3.0.0-RC1. This is because the generated app are not in spring boot 3 for now. Not sure about the most suited fix for that:

Split JHLite to only import module + projects + front;
Try to exclude Spring 3 dependencies;
Wait for spring 3 migration;
Other

Something working:
<properties>
<!-- ... -->
  <spring-boot.version>3.0.0-RC1</spring-boot.version>
<!-- ... -->
</properties>

<!-- ... -->

  <repositories>
    <repository>
      <id>spring-milestones</id>
      <name>Spring Milestones</name>
      <url>https://repo.spring.io/milestone</url>
      <snapshots>
        <enabled>false</enabled>
      </snapshots>
    </repository>
    <repository>
      <id>spring-snapshots</id>
      <name>Spring Snapshots</name>
      <url>https://repo.spring.io/snapshot</url>
      <releases>
        <enabled>false</enabled>
      </releases>
    </repository>
  </repositories>

<!-- Delete spring boot plugin -->

Considering spring boot 3 is expected "soon" (https://spring.io/blog/2022/10/20/spring-boot-3-0-0-rc1-available-now#:~:text=This is our first release,to release November 24%2C 2022.) I think we should wait for this (as it really seems to be the best solution)


SIM401 should not apply to non-concrete default values

Thanks again for Ruff ❤
As of ruff==0.0.219 SIM401 seems to be incorrectly applied when the default value is not a constant value.
import asyncio

async def some_async_func():
    await asyncio.sleep(10)

async def foo():
    d = {"key": "value"}
    key = "key"

    if key in d:
        value = d[key]
    else:
        value = await some_async_func()

    return value

Believes it can be simplified (& maybe more dangerously will be auto-fixed) to:
import asyncio

async def some_async_func():
    await asyncio.sleep(10)

async def foo():
    d = {"key": "value"}
    key = "key"

    value = d.get(key, await some_async_func())

    return value

However these two are not interchangeable as some_async_func() may be arbitrarily expensive as demonstrated here by the asyncio.sleep(10)
Note: This is also a bug in upstream flake8-simplify https://github.com/MartinThoma/flake8-simplify/issues/166

Ahh, good catch! We can fix this.

Thanks!

I went off some heuristics (ignore any expressions containing function calls, awaits, etc.) — let me know if it misses anything going forward.

They look like sufficient for my code base! Thanks!

Makes sense, I can fix that.


Usage in IB gives error messages but app works

Hi,
I tried to use this library/component for its link-ability.
I added it as a Pod. This works without problems.
One of my projects needs to have touchable words in a UILabel. The view hosting this UILabel is designed in a xib.
I tried to set the Class of the UILabel to TTTAttributedLabel, because it seems to support IB_DESIGNABLE and the respective Inspectables.
The Inspectable attributes appear in the attributes inspector and the app compiles and runs fine.
I just have nasty error message which I dont quiet get:

They seem just to be about the component to fail being renderable inside Interface Builder. If thats the case, how to disable these errors? If its more than that I would appreciate help to get rid of them.
Thanks in advance.

Same issue! Rollback removed error.

Thanks everyone, it is understood there is an issue here. The +1s are not helping. :)
Apple's IB Objects documentation is not particularly revealing here. As others have suggested, this may be an Xcode bug.
This is a blocking issue for some people - it prevents projects from compiling. I would propose removing the IB_DESIGNABLE and IBInspectable attributes from the label until Xcode is updated or the label can be made to render a preview in an IB document (or both). Any thoughts here @mattt?

@jhersh If this is indeed causing projects not to compile anymore, than by all means—revert 38b960763dbd3a106cb291d1cbcf7e95f8cfe057. It was my understanding that this was more a cosmetic annoyance than an actual error.

Ah, my mistake - it does show several warnings (Failed to load designables from path (null)) but the project does still compile. We'll leave them in for now.

+1, same issue. The project compiles BTW.

These IB errors may be related to using TTTAttributedLabel as a static library: https://github.com/CocoaPods/CocoaPods/issues/2792
You can instead import TTTAttributedLabel as a dynamic framework today with the CocoaPods 0.36 beta and use_frameworks! added to your Podfile.

Closing as this is not a problem with TTTAttributedLabel. A CocoaPods workaround is available.

Any other solution ? except use_frameworks ?
I can't use it because of other error
The 'Pods-App' target has transitive dependencies that include static binaries: %a list of pods with static libs%
Can we add some changes in project structure and settings to show IB path to a fake module ??

I found the solution with adding additional valid architectures to project. So, now my architectures are "arm64 armv7 armv7s"

Updating cocoa pods doesn't work if you are supporting iOS7. Cannot use frameworks. We actually need to get this fixed as without working IBDesignables, many of our UIs are difficult to work in in IB.

Agreed with @drekka
Dynamic frameworks are not supported by ios7 - http://blog.cocoapods.org/Pod-Authors-Guide-to-CocoaPods-Frameworks/#Availability
@jhersh
it is preatty simple to allow user to chose with some #ifdef
#ifndef REMOVE_IB_DESIGNABLE
IB_DESIGNABLE
#endif

So it will allow to disable IB_DESIGNABLE/IBInspectable support

Let's be very clear here about the problem, which is that you cannot use IB_DESIGNABLE or IBInspectable in a static library. This is emphatically not a bug with TTTAttributedLabel; instead, the bug is entirely Apple's.
We have at least two workarounds:

Install TTTAttributedLabel as a dynamic framework, e.g. with CocoaPods 0.36 and newer. (requires iOS 8)
Install TTTAttributedLabel by dragging its source files to your project (no CocoaPods required)

@Fl0p has a suggestion for a third workaround, which would conditionally remove IB_DESIGNABLE and IBInspectable with the addition (or absence) of a preprocessor #define. Is there broad support for this third option? If so, I'd be okay adding it.

:+1:

Thoughts on #529?

I've drag & drop TTTAttributedLabel classes in my project, and created an outlet for it. Its working fine, but have the same error? How to solve this? Is there any workaround for this? @jhersh @mattt

Was same ussie, updating CocoaPods to 0.37.1 solved problem!

Inherit TTTAttributedLabel to your own class and add Your class in IB.
I think It Works best.

I've removed it from my Podfile and manually dragged the classes into my project. Added them into my Objective-C bridging header and now I can use it in IB. Hope that helps!

@SamuraiZack, how do we add it into bridging header? What's that stuff? :(

@nikhildcodalsystem, thanks for the tip. I'll bluff my logic as you said  – will update here.

If you are experiencing this problem, some workarounds are:

Install TTTAttributedLabel as a dynamic framework using either

Carthage
CocoaPods 0.36+

Install TTTAttributedLabel by dragging its source files to your project

#529 is one possible longer-term solution. Comments are welcome there!
Locking this for now. :lock:


Java Executable Not Found After Container Update

[init] log4j2.xml already created, skipping                                                                                │
│   [init] Checking for JSON files.                                                                                │
│   [init] Setting initial memory to 1G and max to 4G                                                                                │
│   [init] Starting the Minecraft server...                                                                                │
│   2021-02-06T21:57:18.155Z ERROR mc-server-runner Failed to start {"error": "exec: "java": executable file not found in $PATH"}                                                                                │
│   2021-02-06T21:57:18.155Z ERROR mc-server-runner command failed abnormally {"error": "exec: not started"}                                                                                │
│   2021-02-06T21:57:18.155Z INFO mc-server-runner Done                                                                                │
│   [init] Running as uid=1001 gid=1001 with /data as 'drwxrwxr-x    9 1001     1001          4096 Feb  6 21:57 /data'                                                                                │
│   [init] Resolved version given LATEST into 1.16.5                                                                                │
│   [init] Resolving type given VANILLA                                                                                │
│   [init] Copying any mods over...                                                                                │
│   [init] Copying any configs from /config to /data/config                                                                                │
│   [init] server.properties already created, skipping                                                                                │
│   [init] log4j2.xml already created, skipping                                                                                │
│   [init] Checking for JSON files.                                                                                │
│   [init] Setting initial memory to 1G and max to 4G                                                                                │
│   [init] Starting the Minecraft server...                                                                                │
│   2021-02-06T21:58:19.068Z ERROR mc-server-runner Failed to start {"error": "exec: "java": executable file not found in $PATH"}                                                                                │
│   2021-02-06T21:58:19.068Z ERROR mc-server-runner command failed abnormally {"error": "exec: not started"}                                                                                │
│   2021-02-06T21:58:19.068Z INFO mc-server-runner Done                                                                                │
│

@itzg I think a bad container was pushed recently.

I'm working on switching base java images. What image exactly are you using?

@itzg Latest, amd64

I just pulled the built/pushed image and it's working fine for me. Can you provide output of docker image inspect itzg/minecraft-server:latest -f "{{json .Config.Labels}}"

or replace that image reference with one you're using exactly

{"org.opencontainers.image.authors":"Geoff Bourne itzgeoff@gmail.com","org.opencontainers.image.documentation":"https://github.com/itzg/docker-minecraft-server","org.opencontainers.image.revision":"96aa1054dc3d620688f7082a8887a6b10967d931","org.opencontainers.image.source":"https://github.com/itzg/docker-minecraft-server","org.opencontainers.image.version":"latest"}

I'm doing the (not generally recommended thing) of automatically updating certain containers using Ouroboros. My containers just went down after the most recent push, so I'm suspecting that as the culprit.

docker pull that again since you're technically not on the very latest revision; however, there's only non-functional differences between the two.

FWIW, tried a pull on another host system and it works fine too.

@itzg  That seems to have fixed it. Now I'm wondering how that happened.

Very glad it fixed it...but so weird that particular rev was broken.

@itzg I think I see the problem. There are multiple containers running with the same image, and this time it failed to grab the newest one. That's odd that never happened before. Possibly a race condition with stopping containers and cleaning images? Either way, not the responsibility of this project.
Thanks for the rapid responses!

Perhaps, especially since it's triggering on image pushes.
You're welcome, but sorry for the blip things caused.

@itzg No apologies needed! You went above and beyond.


Migrate from .NET 7.0 to 8.0

.NET 8

Migrate from ASP.NET Core in .NET 7 to .NET 8

@Jadhielv Can you assign it to me?


Have intune, but this feature still lights up

The documentation states: "Your organization will have access to this setting unless you're using Microsoft Intune or you've configured mobile device management settings in the Exchange admin center."
We're using both Intune and MDM, and this feature is lit up and available as a setting in the Admin portal in spite of this. It doesn't appear to have any material impact, however, but it's resulted in confusion for admins.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0eef2271-943b-766e-c143-3ebcaa8e8f1f
Version Independent ID: 3a9bf23f-b310-eb7e-6ae4-bbb55b3f325b
Content: Manage email app access in Microsoft 365 admin center
Content Source: Office365-Admin/email/manage-email-app-access.md
Service: o365-administration
GitHub Login: @KwekuA
Microsoft Alias: kwekua

@rmanjoney - Thank you for submitting feedback.
I think the best way forward is if you can open a service ticket in your tenant so this can get resolved ASAP. Based on outcome, let us know if it is something that can be called out in the docs.
If you don't mind please keep us posted here on the resolution so we can get the applicable information you are discovering back into the docs.


Invalid column name while deleting

Hi,
I've three tables
Users [ID_User]
Products [ID_Product]
Norm_Prod_Us [ID_Norm_Prod_Us, ID_Product, ID_Us]
as you can see the primary key of Users table differs from the foreign key into Norm_Prod_Us and when I try to join the two table for a batch delete of users with some products EntityFramework.Extended generates the following query:
DELETE [dbo].[Users]
FROM [dbo].[Users] AS j0 INNER JOIN (
SELECT
   [Extent1].[ID_Product] AS [ID_Product],
   [Extent1].[ID_Us] AS [ID_Us]
   FROM [dbo].[Norm_Prod_Us] AS [Extent1]
   WHERE ([Extent1].[ID_Us] IS NOT NULL) AND ([Extent1].[ID_Product] IS NOT NULL) AND ([Extent1].[ID_Product] IN (3681, 3682, 3683, 3684))
) AS j1 ON (j0.[ID_User] = j1.[ID_User])

That query throws a Sql exception Error 207: Invalid column name 'ID_User'.
We solved the issue using the Where clause instead of the Join.
Thank you for the support and with hope for a solution to give more confidence to that project.
caino

Same here for me.
DELETE [dbo].[IppOrganization]
FROM [dbo].[IppOrganization] AS j0 INNER JOIN (
SELECT
    1 AS [C1],
    CAST(NULL AS uniqueidentifier) AS [C2]
    FROM  ( SELECT 1 AS X ) AS [SingleRowTable1]
    WHERE 1 = 0
) AS j1 ON (j0.[Id] = j1.[Id])

Same for me. Any solution=
UPDATE "agreements"."invoicing_track" AS j0
SET
next_invoice = :p__update__0
FROM (
SELECT
1 AS "C1",
"Project1"."C1" AS "C2"
FROM ( SELECT
"Extent1".id AS "C1"
FROM invoicing_track AS "Extent1"
)  AS "Project1"
WHERE ("Project1"."C1" IN (59248,59249,59250,59251,59)) AND ("Project1"."C1" IS NOT NULL)
) as j1
WHERE (j0.id = j1.id)

Similar problem here with MS Sql Server 2014. In BatchDelete.cs the call to "query.GetCommandTextAndParameters()" returns the following snippet:
SELECT
CAST( [Extent1].[NSD_ID] AS bigint) AS [C1]
FROM [dbo].[NB_STORED_FILTER_DEF] AS [Extent1]
WHERE ( CAST( [Extent1].[NSD_STORED_FILTER_ID] AS bigint) IN (cast(16674 as bigint))) AND ( CAST( [Extent1].[NSD_STORED_FILTER_ID] AS bigint) IS NOT NULL)
This snippet gets plugged into {Select} inside 'CommandTextWhileTemplate' which looks like this:
DECLARE @rowAffected INT
DECLARE @totalRowAffected INT
SET @totalRowAffected = 0
WHILE @rowAffected IS NULL
OR @rowAffected > 0
BEGIN
DELETE TOP ({Top})
FROM    A {Hint}
FROM    {TableName} AS A
INNER JOIN ( {Select}
) AS B ON {PrimaryKeys}
    SET @rowAffected = @@ROWCOUNT
    SET @totalRowAffected = @totalRowAffected + @rowAffected
END

SELECT  @totalRowAffected
The resulting query looks like this:
DECLARE @rowAffected INT
DECLARE @totalRowAffected INT
SET @totalRowAffected = 0
WHILE @rowAffected IS NULL
OR @rowAffected > 0
BEGIN
DELETE TOP (4000)
FROM    A
FROM    [NIOBE].[NB_STORED_FILTER_DEF] AS A
INNER JOIN ( SELECT
CAST( [Extent1].[NSD_ID] AS bigint) AS [C1]
FROM [dbo].[NB_STORED_FILTER_DEF] AS [Extent1]
WHERE ( CAST( [Extent1].[NSD_STORED_FILTER_ID] AS bigint) IN (cast(16674 as bigint))) AND ( CAST( [Extent1].[NSD_STORED_FILTER_ID] AS bigint) IS NOT NULL)
) AS B ON A.[NSD_ID] = B.[NSD_ID]
    SET @rowAffected = @@ROWCOUNT
    SET @totalRowAffected = @totalRowAffected + @rowAffected
END

SELECT  @totalRowAffected
There are two problems here:

The bit that reads:

"FROM    [NIOBE].[NB_STORED_FILTER_DEF] AS A"
throws an error about "NB_STORED_FILTER_DEF" not getting found. I've changed it to
"FROM    [NIOBE].[dbo].[NB_STORED_FILTER_DEF] AS A"
and this part works.

Inside 'BatchDelete.cs' the {PrimaryKeys} is evaluated into '[NSD_ID]' instead of [C1] and thus the column is not found. For this bit to work the correct syntax is:

AS B ON A.[NSD_ID] = B.[C1]
Sidenote: Using the lib to delete entries from the same table when it's being hosted in an oracle DB works. Going to look into it and see what I can dig up.

Hello @dsidirop ,
This library is no longer supported since 2015.
I suggest you moving to our Entity Framework Plus library.
Best Regards,
Jonathan


refactor: consolidate package manager related functions and update imports

Supersedes #32. Removes unused code and consolidates all package-manager-related utilities in one place.

Thanks!


Check if SendTextMessageAsync was unsuccessful

Hi
I cant find if anyone else already had the issue, so Is there a way to know that SendTextMessageAsync  was successful and user get the message ?

https://core.telegram.org/bots/api#sendmessage "
On success, the sent Message is returned."
If there is an error, an exception will be thrown

So handling the exception is enough ?


Update sbt-avrohugger to 2.5.0

About this PR
📦 Updates com.julianpeeters:sbt-avrohugger from 2.0.0-RC22 to 2.5.0
📜 GitHub Release Notes
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.julianpeeters", artifactId = "sbt-avrohugger" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.julianpeeters", artifactId = "sbt-avrohugger" }
}]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

Superseded by #121.


Revit '22 stream receive: Conversion error: Room boundary line creation failed

Revit '22 RAC Basic Sample streamed to Revit '22 as a test gives some errors I think would be worth looking into. I understand this example is a narrow use cases but still a problem worth handling - for example if we want to be able to create Room Separation Lines from other software - this is for example useful if room planing is done in other software and geometry is then built in Revit based on that.
Conversion errors
Room boundary line creation failed
View is not valid for room boundary creation failed
The problem here is that Room Separation Lines (the correct name for them in Revit) cannot be created if the active view is anything other than a plan.
Suggestion:
Usually there will already be levels for the inbound stream, usually these levels will have at least one Floor Plan. I suggest Speckle always open the appropriate view before adding the Room Separation Lines. If the level does not exist I understand Speckle already handles this, I suggest that in this case a new views is created from the appropriate view and used to create the Room Separation Lines. The view can safely be deleted afterwards. Here's the basic version

need to create a room separation line
check if level exists

yes: check if Floor Plan view exists for level

yes: open and use floor plan view for creation of separation lines.

no: create new Floor Plan view on level. Delete view after use

-no: create level and view, use as above (delete speckle-created view)

I hope this is useful

The problem here is that Room Separation Lines (the correct name for them in Revit) cannot be created if the active view is anything other than a plan.

I think we missed this detail! And thanks Autodesk 😣

Hello, I can take this. I have a WIP fix that will do what was suggested by @DuncanLithgow.
✔ = followed this instruction
ℹ = modified this instruction
need to create a room separation line
check if level exists ✔
    yes: check if Floor Plan view exists for level ✔
        yes: open and use floor plan view for creation of separation lines. ℹ No need to open the floor plan view, just pass it as a param to the creation method
        no: create new Floor Plan view on level. Delete view after use ✔
-no: create level and view, use as above (delete speckle-created view) ℹ in this case the view isn't deleted after drawing as this seems to be the Speckle receive operation logic (if level doesn't exist when receiving, create it and create a permanent view for it)

Here is a gif that show a receive operation for seprations lines for 5 floors, the file contain only 1 floor view (the needed addtional view are created and deleted but they never show up in the project browser). As you can see no need to change view (creation  is done from the 3d view):

If the team is ok with this I can open a PR (just let me know what branch to target).
PS: I'll do it after https://github.com/specklesystems/speckle-sharp/pull/2136 is merged as this fix is required for this to work

Awesome, thanks @Mehdi-Lucas ! You can branch off from main and then target the (yet to be created) dev branch when the PR is ready :)

fixed


Make SLSA provenance v0.2 invocation.parameters compliant with spec

The SLSA provenance v0.2 spec states that invocation.parameters
must be an arbitrary JSON object. This modifies the format
implementation to comply with that requirement.
For more info: https://github.com/tektoncd/chains/issues/306

This should fix: #306
@priyawadhwa Want to get your input on whether the output makes sense and if you think it breaks anything because people expect strings of key=value.
There's a lot of options we can take to make the parameters output nicer, but I kept it simple for now until I get input from others.

/ok-to-test

/lgtm

/approve

Looks like you missed the e2e test definition.

Looks like you missed the e2e test definition.

Oops, will fix shortly.

I can't get some of these tests to run accurately local so might take me a little.

Feel free to test with git push -f !

/lgtm


Enhancement/multiple fdb instances

PR for feature request #17
Still needs testing  and discussion

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 4 committers have signed the CLA.:white_check_mark: kinow:white_check_mark: tlmquintino:x: oiffrig:x: geier1993You have signed the CLA already but the status is still pending? Let us recheck it.

This should now be fixed with https://github.com/ecmwf/pyfdb/pull/25. Feel free to reopen in case the feature isn't fully covering your requirements.


Multiple-modals-default-stream

Fixes the multiple modal issue for default streams as well as custom profile fields.

@kennethnrk please ping your buddy for review, as usual.

@PieterCK please review this PR.

Add a new profile field button in Custom Profile FIelds setting menu.

Keys pressed: Enter, Enter, Enter
before:
custom profile modal before.webm
after:
custom profile modal after.webm

Add a channel button in Default Channels setting menu.

Keys pressed: Enter, Enter, Enter
before:
default channels before.webm
Opens multiple Add default channels modal.
after:
default channels after.webm
Auto select on the first drop-down field in the modal to prevent opening the same modal.

@zulipbot remove "buddy review"

Merged, thanks @kennethnrk and @PieterCK! I think the commit message felt clear enough to me -- at least looking at the code briefly, it's clearly touching both functions, but it probably would be better to mention both for readers who aren't looking at the code itself.


clientv3: retry non-mutable rpcs on Internal codes

Otherwise send errors will cancel the RPC via isHaltErr.

lgtm

This should fix https://github.com/coreos/etcd/issues/6277?

@gyuho yes, it's tagged in one of the patches


After upgrading to Windows 10 Pro, option to choose between personal use and organizational use not presented

I just purchased a new Surface Book 3 from the online Microsoft store. The machine came configured for personal use with a Windows 10 Home version. I upgraded to Windows 10 Pro. However, the option to choose between setting up the machine for personal use versus organizational use was never presented. And it's not clear how to subsequently reconfigure the device for organizational use. Multiple tech support calls with various Microsoft personnel have shed no light on the situation.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ad8e657e-2aa7-230d-0d9d-675c0200ac18
Version Independent ID: 2028f003-2624-2bd3-34ea-6022d495e2c6
Content: Set up Windows devices for Microsoft 365 Business Premium users - Microsoft 365 Business
Content Source: microsoft-365/business/set-up-windows-devices.md
Service: o365-administration
GitHub Login: @Sirkkuw
Microsoft Alias: sirkkuw

@CalvinQuark Thank you for your feedback. If the option did not get presented then there could be an issue with the configuration. The document is up to date and no modifications needed as of now. You can contact M365 support via the need help option in Admin portal and get immediate support.
I'd say there are other options to connect to your work or school by following the below
On Your info page, click Access work or school > Connect.
Choose Connect under Access work or school

Hope this helps!
@yogkumgit  The document is up to date and there is no modification needed as of now, Please proceed with closure.
Thanks
Sri

@msbemba  Thank you very much for the contribution and sharing this explanation. @CalvinQuark Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


OverView or Overview in preferences

In the Navigation section we have Overview and ResetOverView.
Consider whether the case usage should be consistent.

Good point. I'll switch to ResertOverview


DecodeString corrupts valid single line hex strings

Assumption taken in the following breaking change https://github.com/zalando/go-keyring/commit/41dbcc1a0c5d7d0862775439694f3367e21cfa20 is problematic as it corrupts single line valid hex strings (that were not encoded) and returns them in a decoded form.
In this case it is not enough to check whenever dec, err := hex.DecodeString(trimStr) does return an error to determine whenever value was stored in encoded form.
One of the propositions might be to perform decoding as an optional operation during obtaining stored value, or keep additional metadata after storing the value which will indicate whenever the value was encoded or not.
Test Case:
// TestGetSingleLineHexString tests getting a single line hex string password from the keyring.
func TestGetSingleLineHexString(t *testing.T) {
	hexPassword :=  "abcdef123abcdef123"
	err := Set(service, user, hexPassword)
	if err != nil {
		t.Errorf("Should not fail, got: %s", err)
	}

	pw, err := Get(service, user)
	if err != nil {
		t.Errorf("Should not fail, got: %s", err)
	}

	if hexPassword != pw {
		t.Errorf("Expected password %s, got %s", hexPassword, pw)
	}
}

or keep additional metadata after storing the value which will indicate whenever the value was encoded or not.

I think this is the right way to go!

Confirming this bug from my side. We use this library to store keychain secrets on our local machines, and anyone who updates to the newer commit sha has multiple secrets corrupted on output.

I'm sorry I haven't had time to look into a fix. PRs are very welcome otherwise I will try to look into it next week after my vacation.

Hmm, so I'm poking at this a bit. New to security but what I'm finding is that the -G option (generic attribute) only allows specifying a single value. Subsequent uses of -G override the previous. This in addition to having to extract and parse it from the output would be unpleasant.
A second thought might be to create a struct and JSON encode it into the comment field. This will at least allow future expansions of the metadata.
What are your thoughts? What would the best, least intrusive, most future-proofed method be?

Alternatively we can prefix encoded passwords with some string which will not be in any valid passwords e.g.: go-keyring-encoded: and look for this prefix when determining how to handle the password.


Unhandled status codes with relevant excepions

All of the functions returns False if the http status code is not 200.
Functions should raise custom exceptions instead return False.

I agree

You will break everyone`s code... That`s should be a major version
But. Without the exceptions, this whole library is pretty hard to use.
I found it the hard way, and I decided to move to python-gitlab that have many exceptions

I'm sorry to have lost you but I do understand why. I myself have run into that same problem with this library. I would though like to assure you that in the future we will have better error reporting. I only recently took over this project and there is some work to do before I start drastically changing the API.

This issue is under active development at the moment and a repeat of issue https://github.com/pyapi-gitlab/pyapi-gitlab/issues/193.


Remove Ben from users

Ben is at GaaP now.

Dupe of https://github.com/alphagov/ci-puppet/pull/425


Semantic UI fonts are not looking good( Pixel Broken ) in IE, some one help me to fix this

hi,
Semantic UI fonts are not looking good( Pixel Broken ) in IE, some one help me to fix this

Can you create a JSFiddle  to replicate the issue?
Also please give more of a description of what you mean by pixel broken.

Hi Hammy,
Thank You for your reply
Here i attached the two different screen shots that i faced the font shrunk problem in IE and Google Chrome

The first image is Google Chrome screenshot, the start button is looking awesome. same way i'm looking the same design in IE that is also looking good but, its looking a little bit shrunk

IE Screenshot

I just tried this and can't seem to reproduce on IE11

What version of IE are you using?
JSFiddle: https://jsfiddle.net/hpezs8qy/

I'm using IE11 only, it is showing like what i send you previously, anyways thank you for your great support


Update 142.1-rubiks-cube.md

In processing, with better use of matrix transforms and improved controls
Binary distribution : https://github.com/tadimon/rubikscube-processing/raw/master/distro.zip

Thank you for this contribution ❤


ssh problem

ssh not working correctly

Please be more descriptive, use the Q&A section, and search. I have no idea what the problem is because you don't describe it at all.


Render returns empty div as container when passed a portal/modal as component

react-testing-library 4.0.2:
react 16.3.2:
node 8.10.0:
npm 5.6.0:

Relevant code or config:
const renderedComponent = render(
  <SomePortal />
);

What you did:
expect(renderedComponent.container).toMatchSnapshot()

What happened:
renderedComponent.container is an empty div in that case. The portal/modal rendered in the document.body and all the queries were generated from the base element which, in the latest version is baseElement = document.documentElement. So all the queries behave as expected, as they look inside documentElement, but the container is an empty div.
Reproduction:

sandbox url: https://codesandbox.io/s/k98yl70j27
Problem description:

So, when we don't pass document.body as container to the render method, which I believe is to avoid the warnings around the rendering directly in div. The render just returns an empty div as container.
render method, if not passed a container,  returns container by creating a div element in the body. It works fine for all the portal less components which don't render anything in the body. But for the components which create portals and render those in the document.body, the container doesn't include all the rendered DOM. If we are just testing a modal box, e.g., then the container will just be empty.
Suggested solution:

I have two possible solutions in mind.

return baseElement as well from the render
make the container same as baseElement and return that

Thanks for this issue.

return baseElement as well from the render

Let's do that :+1: Would you like to open a PR that adds this change as well as simple documentation?

sure, would love to do that!


Empty body when using .as[_] with a DSL-based client request

I'm exploring using client.expect and other methods vs. the pimped apply methods against the dsl (e.g. GET(...)).
This works great:
val httpClient = PooledHttp1Client()
val req = httpClient.expect[Json](uri("http://api.postcodes.io/postcodes") / "w1a 1aa")
println(req.run)

This, however, gives Malformed request body: Invalid JSON: empty body:
val req = GET(uri("http://api.postcodes.io/postcodes") / "w1a 1aa").as[Json]
println(req.run)

Am I just using the DSL incorrectly?
I'm using http4s 0.15.13 and circe 0.8.0.

For full reproduction, my build.sbt:
scalaVersion := "2.12.2"

libraryDependencies ++= Seq(
  "org.http4s"     %% "http4s-blaze-client" % "0.15.13",
  "org.http4s"     %% "http4s-circe"        % "0.15.13",
  "org.http4s"     %% "http4s-dsl"          % "0.15.13",
  "io.circe"       %% "circe-generic"       % "0.8.0",
  "io.circe"       %% "circe-literal"       % "0.8.0",
  "ch.qos.logback" %  "logback-classic"     % "1.2.1"
)

A simple App.scala for the client.expect method:
import io.circe._
import org.http4s.dsl._
import org.http4s.circe._
import org.http4s.client.blaze._

object Main extends App {
  val httpClient = PooledHttp1Client()
  val respExpect = httpClient.expect[Json](uri("http://api.postcodes.io/postcodes") / "w1a 1aa")
  println(respExpect.run)
}

And one for the DSL method:
import io.circe._
import org.http4s.dsl._
import org.http4s.circe._
import org.http4s.client.blaze._
import org.http4s.client._

object Main extends App {
  val respDsl = GET(uri("http://api.postcodes.io/postcodes") / "w1a 1aa").as[Json]
  println(respDsl.run)
}

That's because on the second one, you're just constructing a Request object, not actually executing it. Http4s has no implicit/global magic concerning clients (compare WSClient), so executing a request without manually constructing a client is impossible. It still compiles because .as[_] is defined on both Request and Response, see http://http4s.org/v0.15/api/org/http4s/Message.html

Thanks, that makes complete sense.
I'd assumed http4s might have a default pooled client somewhere. It turns out I misunderstood the documentation at http://http4s.org/v0.15/json/ under Receiving raw JSON. I see now the POST(uri("/hello"),"""{"name":"Bob"}""").as[Json].run example is just demonstrating a request and not executing it.


change Go gapics use gax-go/v2

Fix #2483
This is my first PR on gapic-generator. Please let me know if there is anything I should be aware of/I'm not doing right.

All is well. This is https://github.com/golang/go/issues/29247.

Codecov Report

Merging #2484 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #2484      +/-   ##
============================================
- Coverage     86.78%   86.77%   -0.01%
+ Complexity     5373     5367       -6
============================================
  Files           459      459
  Lines         21212    21183      -29
  Branches       2311     2308       -3
============================================
- Hits          18408    18382      -26
- Misses         1974     1975       +1
+ Partials        830      826       -4

Impacted Files
Coverage Δ
Complexity Δ

...egen/transformer/go/GoGapicSurfaceTransformer.java
99.52% <100%> (ø)
38 <0> (ø)
:arrow_down:

...e/api/codegen/transformer/InitCodeTransformer.java
94.25% <0%> (-0.52%)
91% <0%> (-3%)

...m/google/api/codegen/metacode/InitValueConfig.java
100% <0%> (ø)
12% <0%> (-1%)
:arrow_down:

.../com/google/api/codegen/metacode/InitCodeNode.java
86.85% <0%> (+1.07%)
80% <0%> (-2%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4ba55...7e5cc8d. Read the comment docs.


Update usegalaxy.org IUC/devteam tools (take 2)

This is the same as #312 (reverted the merge and then reverted the reversion for this PR) because that PR was merged before the deployment ran.

@galaxybot deploy this


⚠ Bofrost.be has degraded performance

In 5f1d779, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1614 ms

Resolved: Bofrost.be performance has improved in 2027ff9.


MINGW64 - character set not supported

Category

[x] fzf binary
[x] fzf built from source under mingw64

OS

[x] Windows

Shell

[x] bash

I get the following output in MINGW64:
$ fzf
character set not supported
It seems to work as expected in windows command prompt, both the premade binary and the one i built in mingw.
I couldn't find the string in the source, but it seems to be in the binary, so I'm guessing there's some included module that has issues. I tried to grep under /mingw64/lib/go and share/go, but couldn't find it.
Sorry to offer you such an unhelpful bug report.

As far as I know, tcell library which fzf depends on does not support cygwin/msys.
https://github.com/gdamore/tcell#windows
You might want to consult with the author of tcell to see if there's any workaround.
/cc @kelleyma49

Through winpty I was able to get fzf working.


Time Resolution for each dataset

Hello, I would like to ask what is the time resolution for each dataset (in seconds/minutes/hours/days/months/years or ...) ?

Hi, to confirm the resolution of the dataset you should check out the original papers.  We did not change the resolution or other key properties of the data. What we have done is only formatting or cleaning, to let it compatible with our package.

Ok, thank you for the response.


Add an image tag names filter

Add an input text to filter tag names in image overlay. Fixes #3781
Signed-off-by: Gael Hanquez<EMAIL_ADDRESS>

thanks @Kribou for the PR and enhancement - Can you add a screenshot/gif to the PR, so that we have a snapshot of what it's supposed to look like?

Sure, I added an input field to be able to filter the tag name list instead of scrolling.

Implementation looks good, but I'm seeing some odd shifts in the box layout - Is this something you could fix as part of this PR?

You can see it in your filter as well, where the overlay box isn't 100% of the image box below it.

Sure, I fixed it in the last commit.


Handle missing or unparseable timestamp field

Fixes #2
As it says, we are now more robust to plotting any CSV files!
The order is as follows:

TIMESTAMP column is parsed as date string
if numeric, used as that value (x-data)

if un-parseable, fallback to iteration number.

if no TIMESTAMP, fallback to iterations

@jefffohl when you have time, can I have your review on the standing PRs?
This one should be merged last, for possible merge conflicts.

@jefffohl thanks for the improvements, fixed.
I've merged with master and again a breakage Mismatch between number of labels (__iter__,anomaly) and number of columns in array (1) do you know where it could come from?

@jefffohl thanks for the improvements, fixed.
I've merged with master and again a breakage Mismatch between number of labels (__iter__,anomaly) and number of columns in array (1) do you know where it could come from?

@jefffohl thanks for the improvements, fixed.
I've merged with master and again a breakage Mismatch between number of labels (__iter__,anomaly) and number of columns in array (1) do you know where it could come from?

@jefffohl fixed the above problem, works nice now. Please merge if you agree.

Thanks!
FYI Jeff, fixed above.


Check context cancellation in inmemory cache

[ ] I added CHANGELOG entry for this change.
[x] Change is not relevant to the end user.

Changes
inmemory cache should check cancellation in its read methods. When fetching multiple postings or series, it could take a while to fetch all the required items due to https://github.com/thanos-io/thanos/issues/6762.
Add a context check in case request time out and we can return early, no need to fetch all the data.
Verification

Thanks @GiedriusS, merging now.


count error

GORM Playground Link
https://github.com/go-gorm/playground/pull/358
Description
I am very puzzled about how to count the total number of records while paging query.
The code works in V1.
var result []User
db := DB.Where("age>?", 10)

// SELECT * FROM `users` WHERE age>10 AND `users`.`deleted_at` IS NULL LIMIT 10 OFFSET 10
db.Limit(10).Offset(10).Find(&result).

var total int64
// SELECT count(*) FROM `users` WHERE age>10 AND `users`.`deleted_at` IS NULL LIMIT 10 OFFSET 10
db.Count(&total) // how to count total user where age > 10 ?

Can anyone help me?

Hello @tfhappy
Looks like you are migrating from V1 to V2. In Gorm V2 we have the following Method Chaining definition.
In gorm v1 everything could be chained, bringing some complications of performance and security. So in gorm v2 we have Finishers that generate and execute SQL, also creates new Statement.
So if you want to reuse the Where, Limit and Offset I strongly recomend you to use Session Mode the second example, like:
tx := DB.Where("age>?", 10).Limit(10).Offset(10)
// `Where("age>?", 10)` is the first method call, it creates a new `Statement` and adds conditions
// `.Limit(10)` REUSES above `Statement`, and adds conditions to the `Statement`
// `.Offset(10)` REUSES above `Statement`, and adds conditions to the `Statement`

var users []User
tx.Find(&users)
// Since tx has a the Statement with Where, Limit, Offset whe just need to call Find.
// `Find(&users)` is a finisher, it executes registered Query Callbacks, generates and runs the following SQL:
// SELECT * FROM `users` WHERE age>10 LIMIT 10 OFFSET 10

var total int64
tx.Count(&total)
// Since tx has a the Statement with Where, Limit, Offset whe just need to call Count.
// `Count(&users)` is a finisher, it executes registered Query Callbacks, generates and runs the following SQL:
// SELECT Count(*) FROM `users` WHERE age>10 LIMIT 10 OFFSET 10

got it ,thanks!


Mhd/ar samples

Adds three AR samples to the app:  Collect data, Tabletop, and Flyover.

@nCastle1 If you could look at the doc, that would be great.  I still need to add screenshots to the three readme files and need icon/iamge for the "Augmented Reality" category.

@mhdostal I'm still reviewing this PR, but could you please add a README.metadata.json file for each new sample? Those files are needed for the developer site to update with the new samples. Let me know if you'd like some help.

@philium How can I determine what the "redirect_from" url is?

Since these are brand new samples, there is no redirect URL, so just specify an empty array:
    "redirect_from": [
    ],

@mhdostal I'm unable to build this branch, I think because the submodule is pointing to a commit without the AR components. Could you update the submodule reference to an appropriate commit? Its fine if it isn't pointing to a release; we can always update it before merging to master. I just don't want v.next to get into an unbuildable state.

Could you update the submodule reference to an appropriate commit?

@philium Done

I finished reviewing your changes to Collect Data in AR and the other two samples. I had a question about the image Augmented reality_icon. Where did you get it? It looks like it's vector-based. Could you get it as a vector PDF?

It's a direct copy of the "Scenes" icon.  I don't know where it originally came from.

@mhdostal Did you see my comments about the calibration view?

Did you see my comments about the calibration view?

Yes.  I changed the button color to yellow, to distinguish it from the default button
To answer your specific questions:

Calibration is applied instantly when the sliders change
I've changed the "Calibration" button to only say "Calibration" (and not "Finish Calibrating")

So since the calibration is applied instantly, and the user can see immediately the result as they move the slider through the transparent base map, I don't think things need to change.

Thanks!

I added @saratchandrakarumuri as a reviewer so that he can validate the new samples (if he hasn't done so already).

@saratchandrakarumuri Let me know if you find any issues.  Thanks!

Let's get this in now.  The blog post announcing the release has gone live
@saratchandrakarumuri log follow on issue for any problems you find.


Running pytorch_lstm_word_language_model in 'local_gpu' mode fails when trying to save a checkpoint

I have successfully run the pytorch_cnn_cifar10 example in 'local_gpu' mode however when I attempt to run pytorch_lstm_word_language_model it fails at the point where it tries to save a checkpoint. If I run using 'ml.p2.xlarge' it works fine.
I really want to get to training my own models, but I need to be comfortable running things locally before spinning up large jobs.
I've spent 2 days on this and am at a complete loss as to how to proceed.
estimator.fit({'training': inputs})
INFO:sagemaker:Creating training-job with name: sagemaker-pytorch-2018-08-16-13-25-24-915
...
algo-1-N95ZQ_1  |
algo-1-N95ZQ_1  | Invoking script with the following command:
algo-1-N95ZQ_1  |
algo-1-N95ZQ_1  | /usr/bin/python -m train --epochs 6 --tied True
algo-1-N95ZQ_1  |
algo-1-N95ZQ_1  |
algo-1-N95ZQ_1  | Namespace(batch_size=20, bptt=35, clip=0.25, data_dir='/opt/ml/input/data/training', dropout=0.2, emsize=200, epochs=6, log_interval=200, lr=20, model_dir='/opt/ml/model', nhid=200, nlayers=2, output_data_dir='/opt/ml/output/data', seed=1111, tied=True)
algo-1-N95ZQ_1  | Load data
algo-1-N95ZQ_1  | Batchify dataset
algo-1-N95ZQ_1  | Build the model
algo-1-N95ZQ_1  | Starting training.
algo-1-N95ZQ_1  | | epoch   1 |   200/ 2983 batches | lr 20.00 | ms/batch 132.20 | loss  8.34 | ppl  4170.69
algo-1-N95ZQ_1  | | epoch   1 |   400/ 2983 batches | lr 20.00 | ms/batch 130.82 | loss  7.33 | ppl  1526.82
algo-1-N95ZQ_1  | | epoch   1 |   600/ 2983 batches | lr 20.00 | ms/batch 131.50 | loss  6.84 | ppl   931.69
algo-1-N95ZQ_1  | | epoch   1 |   800/ 2983 batches | lr 20.00 | ms/batch 130.20 | loss  6.65 | ppl   773.86
algo-1-N95ZQ_1  | | epoch   1 |  1000/ 2983 batches | lr 20.00 | ms/batch 131.37 | loss  6.42 | ppl   612.90
algo-1-N95ZQ_1  | | epoch   1 |  1200/ 2983 batches | lr 20.00 | ms/batch 144.49 | loss  6.36 | ppl   577.66
algo-1-N95ZQ_1  | | epoch   1 |  1400/ 2983 batches | lr 20.00 | ms/batch 147.81 | loss  6.29 | ppl   538.71
algo-1-N95ZQ_1  | | epoch   1 |  1600/ 2983 batches | lr 20.00 | ms/batch 149.79 | loss  6.28 | ppl   535.09
algo-1-N95ZQ_1  | | epoch   1 |  1800/ 2983 batches | lr 20.00 | ms/batch 152.39 | loss  6.08 | ppl   436.85
algo-1-N95ZQ_1  | | epoch   1 |  2000/ 2983 batches | lr 20.00 | ms/batch 152.36 | loss  6.05 | ppl   422.20
algo-1-N95ZQ_1  | | epoch   1 |  2200/ 2983 batches | lr 20.00 | ms/batch 153.27 | loss  5.91 | ppl   368.56
algo-1-N95ZQ_1  | | epoch   1 |  2400/ 2983 batches | lr 20.00 | ms/batch 153.32 | loss  5.95 | ppl   384.13
algo-1-N95ZQ_1  | | epoch   1 |  2600/ 2983 batches | lr 20.00 | ms/batch 155.87 | loss  5.93 | ppl   375.15
algo-1-N95ZQ_1  | | epoch   1 |  2800/ 2983 batches | lr 20.00 | ms/batch 157.07 | loss  5.82 | ppl   336.95
algo-1-N95ZQ_1  | -----------------------------------------------------------------------------------------
algo-1-N95ZQ_1  | | end of epoch   1 | time: 449.71s | valid loss  6.03 | valid ppl   413.73
algo-1-N95ZQ_1  | -----------------------------------------------------------------------------------------
algo-1-N95ZQ_1  | Saving the best model: {'val_loss': 6.025203372840166, 'epoch': 1, 'val_ppl':<PHONE_NUMBER>5337285, 'lr': 20}
algo-1-N95ZQ_1  | 2018-08-16 13:33:47,846 sagemaker-containers ERROR    ExecuteUserScriptError:
algo-1-N95ZQ_1  | Command "/usr/bin/python -m train --epochs 6 --tied True"
algo-1-N95ZQ_1  | Traceback (most recent call last):
algo-1-N95ZQ_1  |   File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
algo-1-N95ZQ_1  |     "main", mod_spec)
algo-1-N95ZQ_1  |   File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
algo-1-N95ZQ_1  |     exec(code, run_globals)
algo-1-N95ZQ_1  |   File "/usr/local/lib/python3.5/dist-packages/train.py", line 227, in
algo-1-N95ZQ_1  |     with open(checkpoint_path, 'wb') as f:
algo-1-N95ZQ_1  | FileNotFoundError: [Errno 2] No such file or directory: '/opt/ml/output/data/model.pth'
tmpt0u39mhk_algo-1-N95ZQ_1 exited with code 1
Aborting on container exit...

RuntimeError                              Traceback (most recent call last)
/home/bart/anaconda3/envs/pytorch/lib/python3.5/site-packages/sagemaker/local/image.py in train(self, input_data_config, hyperparameters)
110         try:
--> 111             _stream_output(process)
112         except RuntimeError as e:
/home/bart/anaconda3/envs/pytorch/lib/python3.5/site-packages/sagemaker/local/image.py in _stream_output(process)
588     if exit_code != 0:
--> 589         raise RuntimeError("Process exited with code: %s" % exit_code)
590
RuntimeError: Process exited with code: 1
During handling of the above exception, another exception occurred:
RuntimeError                              Traceback (most recent call last)
 in ()
----> 1 estimator.fit({'training': inputs})
/home/bart/anaconda3/envs/pytorch/lib/python3.5/site-packages/sagemaker/estimator.py in fit(self, inputs, wait, logs, job_name)
177         self._prepare_for_training(job_name=job_name)
178
--> 179         self.latest_training_job = _TrainingJob.start_new(self, inputs)
180         if wait:
181             self.latest_training_job.wait(logs=logs)
/home/bart/anaconda3/envs/pytorch/lib/python3.5/site-packages/sagemaker/estimator.py in start_new(cls, estimator, inputs)
400                                           job_name=estimator._current_job_name, output_config=config['output_config'],
401                                           resource_config=config['resource_config'], hyperparameters=hyperparameters,
--> 402                                           stop_condition=config['stop_condition'], tags=estimator.tags)
403
404         return cls(estimator.sagemaker_session, estimator._current_job_name)
/home/bart/anaconda3/envs/pytorch/lib/python3.5/site-packages/sagemaker/session.py in train(self, image, input_mode, input_config, role, job_name, output_config, resource_config, hyperparameters, stop_condition, tags)
262         LOGGER.info('Creating training-job with name: {}'.format(job_name))
263         LOGGER.debug('train request: {}'.format(json.dumps(train_request, indent=4)))
--> 264         self.sagemaker_client.create_training_job(**train_request)
265
266     def tune(self, job_name, strategy, objective_type, objective_metric_name,
/home/bart/anaconda3/envs/pytorch/lib/python3.5/site-packages/sagemaker/local/local_session.py in create_training_job(self, TrainingJobName, AlgorithmSpecification, RoleArn, InputDataConfig, OutputDataConfig, ResourceConfig, StoppingCondition, HyperParameters, Tags)
73                                    data_distribution)
74
---> 75         self.s3_model_artifacts = self.train_container.train(InputDataConfig, HyperParameters)
76
77     def describe_training_job(self, TrainingJobName):
/home/bart/anaconda3/envs/pytorch/lib/python3.5/site-packages/sagemaker/local/image.py in train(self, input_data_config, hyperparameters)
114             # which contains the exit code and append the command line to it.
115             msg = "Failed to run: %s, %s" % (compose_command, str(e))
--> 116             raise RuntimeError(msg)
117
118         s3_artifacts = self.retrieve_artifacts(compose_data)
RuntimeError: Failed to run: ['docker-compose', '-f', '/tmp/tmpt0u39mhk/docker-compose.yaml', 'up', '--build', '--abort-on-container-exit'], Process exited with code: 1

I have solved this problem with a hack to the code by creating the missing directory.
pathlib.Path(args.output_data_dir).mkdir(parents=True, exist_ok=True)
However, I would still like to understand the reason it works for the hosted version and not in the local mode.

Hi @BartBaddeley - Thank you.  Currently we don't create output_data_dir as part of SageMaker local mode (even though it is created in SageMaker training).  This is something we'll look at add in the near future.


Question about using RDS import scripts

Issue description
I am trying to use the RDS import scripts by calling letsencrypt.exe with --script "C:\Program Files (x86)\win-acme.v<IP_ADDRESS>\scripts\PSRDSCerts.bat" --scriptparameters "{5}". I am not sure I fully understand how the certificate thumbprint is passed as {5} to --scriptparameters but the end result is that the certificate from the machine's Personal store is not imported into the RD Gateway.
The ImportRDGateway.ps1 script accepts a certificate thumbprint on its -NewCertThumbprint parameter. I could run the script separately (i.e. not as part of letsencrypt.exe) but I would really like to do it all at once.
Can someone please provide some hints?
Steps to reproduce
Please include the command line and/or manual input, relevant details about the IIS bindings, your scripts, etc.
letsencrypt.exe --renew --baseuri "https://acme-v01.api.letsencrypt.org/" --certificatestore My --script "C:\Program Files (x86)\win-acme.v<IP_ADDRESS>\scripts\PSRDSCerts.bat" --scriptparameters "{5}"
Client version: <IP_ADDRESS>
Windows version: Windows Server 2016 Datacenter, 10.0.14393 N/A Build 14393
Relevant part of log file: N/A

I don't see any obvious mistakes in your command line, so let's start by figuring out if the thumbprint parameter actually makes its way to the script. That's easily tested by adding a Write-Host $NewCertThumbprint at the beginning. That will narrow down the search quite a lot.

Hi Wouter,
Thanks for your quick reply! I ran ImportRDGateway.ps1 by itself and the certificate gets imported into RD Gateway without any issues. Or maybe you're asking whether the thumbprint makes it to --scriptparameters "{5}"?
How can I run letsencrypt.exe without re-issuing the certificate because I ran into rate limits due to too many certificate requests for my domain and run the PowerShell script at the same time?

If you would add that Write-Host statement to the .ps1 script we'd know whether the thumbprint properly arrives to PowerShell. One theory I have is that the quotes may be included for some reason. The other obvious pitfall is that it would be empty.
The program will request a new certificate at most once every 24 hours unless you use --force, but if you've already hit one of the rate limits then there are two ways to work around them. One is to issue for another domain that you might own. The other is to use the --test switch so that you will request an (untrusted) certificate from the staging server. The rate limits for the staging server are much more relaxed.

I'm going to close this issue due to it being quiet in the thread for while now. Please feel free to post again though if you keep having issues with the latest release. Thanks for using win-acme and providing us with feedback.

Hey Wouter,
Apologies for not getting back to the thread. I did manage to get the PowerShell script to execute by creating a new scheduled task via the advanced option that renews a certificate through the staging server. I should be able to do the same against the production CA. Will let you know if I face any issues. Thanks for the help, it's much appreciated!


update python versions supported in setup.py

I think merging before travis was able to complete killed the build?


fix default filtered p2p ip list (non routable ips that should not be announced)

Fixes #691 .
Changes proposed in this PR:

set proper default non public ips on P2P_FILTER_ANNOUNCED_ADDRESSES

need to fix tests, break unit tests with 2 local nodes


AWS error when try import contacts csv

Issue Summary
I have "Requests specifying Server Side Encryption with AWS KMS managed keys require AWS Signature Version 4" when try to import csv contact
Steps to Reproduce

Ask for upload url
curl to send contacts csv to given aws url

Code Snippet
try {
$request_body = [
            "file_type" => "csv",
            "field_mappings" => [
                '_rf2_T',
                '_rf0_T',
                '_rf1_T',
                null,
                null,
                '_rf6_T',
                null,
                '_rf8_T',
                '_rf9_T',
                'e1_T',
            ]
        ];

            $response = $this->sendGrid->client->marketing()->contacts()->imports()->put($request_body);
            dump(
                $response->statusCode(),
                $response->headers(),
                json_decode($response->body())
            );
        } catch (Exception $ex) {
            echo 'Caught exception: '.  $ex->getMessage();
        }

and after
curl --upload-file "contacts-upload-test.csv" "https://mc-contacts-import-upload-production.s3.us-west-2.amazonaws.com/***.csv\?*********" -H '{"header":"x-amz-server-side-encryption","value":"aws:kms"}'

Exception/Log
<?xml version="1.0" encoding="UTF-8"?>
<Error>InvalidArgument<Message>Requests specifying Server Side Encryption with AWS KMS managed keys require AWS Signature Version 4.</Message><ArgumentName>Authorization</ArgumentName><ArgumentValue>null</ArgumentValue><RequestId>FMGG7740DC75MP5E</RequestId><HostId>ulXwz+ikcuVLWndOfuRqKmXzSd2b56U5nfwqLmytF4ViURwHcPjWC4ipQ31RuIyStf2KB/CgwYY=</HostId></Error>%

Technical details:

sendgrid-php version: 7.11.4
php version: 7.4.26

I think I find the problem, just in https://docs.sendgrid.com/api-reference/contacts/import-contacts it say to call:
curl --upload-file "file/path.csv" "URL_GIVEN" -H 'HEADER_GIVEN'
But the given url given into double quote seem escape so it show me that error.
Also it's not really mention that the upload_uri response param give a json object that have to be transform from
{"header":"x-amz-server-side-encryption","value":"aws:kms"}
to
-H 'x-amz-server-side-encryption: aws:kms'


Spin up new instance for multiple ongoing work

closing this PR as no recently work is initiated on theme updates.


Need to confirm permission requirement for Access ACR with Kubernetes secret

Hi team,
We find there's some permission misunderstanding in doc:
For the part "Grant AKS access to ACR", it apparently need user has permission "Microsoft.Authorization/roleAssignments/write" due to command "az role assignment create", such as "owner" role.
For the another part "Access with Kubernetes secret", the doc claim that "In some instances, you might not be able to assign the required role to the auto-generated AKS service principal granting it access to ACR. For example, due to your organization's security model, you might not have sufficient permissions in your Azure Active Directory tenant to assign a role to the AKS-generated service principal. Assigning a role to a service principal requires your Azure AD account to have write permission to your Azure AD tenant. If you don't have permission, you can create a new service principal, then grant it access to the container registry using a Kubernetes image pull secret."
This means the second method doesn't require the user to have "Microsoft.Authorization/roleAssignments/write" permission. But according to our test, the command "az ad sp create-for-rbac" also requires the user to have role assignment permission. Otherwise, user would encounter the following error "Role assignment creation failed."

I think it need double confirm the permission requirement for these two methods of "Authenticate with Azure Container Registry from Azure Kubernetes Service" and modify the statement if necessary.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed59d472-ac33-5c03-dbb7-0e86e88c7dd8
Version Independent ID: 69e1ad8c-2dd3-cc1b-2b31-996a5d866cc0
Content: Authenticate with Azure Container Registry from Azure Kubernetes Service
Content Source: articles/container-registry/container-registry-auth-aks.md
Service: container-service
GitHub Login: @dlepow
Microsoft Alias: danlep

@XuzhouHuang , Thank you for your feedback. We will investigate and get back to you shortly.

@XuzhouHuang Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.
@dlepow Can you please review the requested doc-enhancement? Thanks :)

@XuzhouHuang - Thanks for pointing out this issue and providing details. As I understand, you were unable to assign a role to a service principal that you created in the AD tenant. I will investigate the proper way to update the documentation.
In the meantime, can I please ask you to confirm your Azure subscription permissions as described in this article. To complete your scenario, is it possible for your subscription administrator to assign your account the User Access Administrator role?

@XuzhouHuang - In the meantime, we've updated the recommended way to establish authentication from AKS to an Azure container registry, now documented here. As noted in that article, configuring authentication requires the Owner or Azure account administrator role on the Azure subscription. I hope this information helps.
#please-close


Azure cluster ResourceGroup

Suggested approach.

https://github.com/fusor/mig-controller/pull/357


Feat: footer icons needs to align it overlaps text

Describe the feature

Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hello @Its-Aman-Yadav please assign this issue to me under gssoc 24


Fix README

Fixes:

A couple of typos
Add highlight to Bluebird example
There are several examples, so Example → Examples ?
A Promise → Promises ?

Thanks! :)


Cursor pointer Utility

Hello, It will be nice if someone could add a class that let you point the cursor.
example:
.c-pointer {
 cursor: pointer;
}

What does c-pointer means? is it a utility class?

It means that the cursor will be pointer (cursor: pointer). Another example could be the following:
.c-wait {
cursor: wait;
}

or
.c-help {
 cursor: help;
 }

Those are utilities classes. I missed the dot in my first comment.

I like that idea. Maybe we can add all cursor-values? And maybe add a global option to enable/disable these classes like the grid classes?

there's a danger that we'd need to add utility classes for every single CSS property at that rate, though. is it really necessary to do this, or can authors not do their own minor CSS additions?

I agree with @patrickhlauke, I don't like the idea. If we add a single utility for each CSS property it'd be like writing inline styles.

@patrickhlauke and @andresgalante, your comments make sense, these classes may indeed be more appropriate in custom stylesheets.

I don't see a problem with adding to the Bootstrap utilities. Why have utility classes for border-radius and not cursor? Do you have a prejudice against the cursor property? I do not agree with the above comments

Judging by 👍's it would appear most people agree w/ you @rbonomo (myself included) as opposed to the project maintainers that chimed in here. 🤷♂

What does c-pointer means? is it a utility class?

omg, seriously?

There's a whole slew of CSS properties that Bootstrap has enumerated the values for and provided utility classes for, another being .d-{value}: https://getbootstrap.com/docs/4.1/utilities/display/
It's great to see someone has reopened this. 💯

"There's a whole slew of CSS properties..." ... so let's strive to aim all the other ones too?

Sure... Why the heck not?  At least it'd b e consistent across the board.

For pointer you could use the role="button" on the element as BS have the following css definition :
[role=button] {
  cursor: pointer;
}

I checked using BS3, works !

According to @patrickhlauke, @andresgalante and @MartijnCuppens feedbacks.
Closed.
/CC @mdo if you think we should add that

"According to all the people that I agree with, including the one who's last response was an unhelpful bit of sarcasm, I'm gonna go ahead and close this, again.. even though it's clear this is a rather desirable feature." 🤦♂

I think the devs are trying to prevent the ballooning out of utility classes.

I think the devs are trying to prevent the ballooning out of utility classes.

And what exactly is wrong with that? It is rather usefull feature to have strong utility classes. Combination of Tailwind and Bootstrap seems pretty amazing to me. Unfortunately devs dislike the idea so i guess we are done here.

I see Bootstrap as a tool for quick prototype implementation. For me, it's supposed to remove the need to write my own CSS for as long as possible. Not having a cursor utility class is just another barrier to getting a prototype closer to the 80% complete before fine-tuning everything with my own rules. If I'm building a web app on Bootstrap and can't control the cursor style in the moment, I could easily forget some of those subtle things later when I am writing my custom CSS to finish the last 20% of the prototype. I vote for cursor utility classes. I like @RavenHursT's comment—this was closed because a few didn't want it. The initial comment that opened this issue has 33 thumbs up at the time of writing my comment. Feels like the majority of the community is rudely dismissed on this one.

If there ever was a case for a utility class, this is it. Every man and woman alive who has written Angular has had to write an utility class for pointer.

I created a package to handle these cases. It has all the pointer options as .c-xxx
https://www.npmjs.com/package/bootstrap-extensions

See?  Now that wasn't so hard, now was it?
Would be nice to have something like this in BS itself however, to help ensure classes and styles don't override or something as the two libs evolve...
But the BS-Gods have spoken... they're not interested, regardless of how many in the community see this as beneficial...  c'est la vie  🤷♂

We regularly unsubscribe, mute, and ignore old threads, apologies for that, and the snark y'all have received. Given v5's upcoming utilities API, we can likely add something like this to the project. 60 +1s on the opening comment is a pretty clear indication folks at least expect a set of utilities here.
/cc @MartijnCuppens again who commented favorably two years ago :).

Well, I got to admit my opinion has changed quite a lot over the years 😛
I really don't mind adding more utilities. However, I'm a little concerned this utility will get abused too often. Elements which are clickable, should also be accessible with keyboard navigation. Links and buttons can be focused with keyboard navigation and have a pointer cursor.
Apart from elements with [role="button"], are there any other use cases where this utility makes sense? Otherwise we should just add
[role="button"] {
  cursor: pointer;
}

to our reboot (thanks for this suggestion @jaysee). This attribute can then be used as an accessible kind of utility?

I made and use utility for cursors written in SASS, it deals with all the options, by adding something like this behind a flag not to add bloat for people that won't use it, hope this helps:
$cursors: auto, default, none, context-menu, help, pointer, progress, wait, cell, crosshair, text, vertical-text, alias, copy, move, no-drop, not-allowed, grab, grabbing, all-scroll, col-resize, row-resize, n-resize, e-resize, w-resize, ne-resize, nw-resize, se-resize, sw-resize, ew-resize, ns-resize, nesw-resize, nwse-resize, zoom-in, zoom-out

@each $cursor in $cursors
  .cursor-#{$cursor}
    cursor: $cursor

Two PRs opened to address this in v4 (#30562) and v5 (#30563). v4's PR also brings over user-select to help bridge v4/v5 a little more since we're proposing adding this new class. Still up to the team on how we proceed here.

With the two PRs open, we still don't have a clear idea of why a cursor pointer utility is needed. I get it for some other cursors—like the help one—but those seem like something we'd push to custom styles anyway. What's everyone's use case here?

My use case was when combining Bootstrap html with JS (in my case Vue framework) when i wanted to make some element clickable without wrapping everything in  tag with "href" attribute as unnecessary clutter. Also utility classes in general are pretty addictive once you fully add them to your workflow so that may be a reason why people want more utilities. To be honest in my case i ended up using TailwindCSS just because of that - i don't have to use CSS itself that much and I even started enjoying writing frontend code a little bit (i am backend developer 99% of the time).

Maybe use a button? This is not a sufficient use case, IMHO.
To summarize our thoughts, if it's clickable it should almost always be a link or a button.
Links have pointer cursor as a default, and buttons have it in standard Bootstrap build.
Inputs and other interactive elements as details have appropriate defaults too.
If you're making something clickable and need to add a cursor, it's very likely you have an accessibility issue.
To me, not including this utility is a way to promote good ol' semantic markup for  operable components.

sometimes you want something clickable with a cursor:pointer that isn't a button. Please implement this!

We've since shipped v4.5.0 which includes a new role="button" addition to Reboot to add cursor: pointer. This keeps things semantically aligned and alleviated some concerns the maintainer team had around abusing this particular utility class.
See https://getbootstrap.com/docs/4.5/content/reboot/#pointers-on-buttons for details.
Hope this helps, but also weigh in with feedback if this is something we should be revisiting in some way.

I created a package to handle these cases. It has all the pointer options as .c-xxx
https://www.npmjs.com/package/bootstrap-extensions

Oh great find after those administrative futinlity, this fulfills some of my needs ever since.


Refactor: Overlay and dynamically styled components

This PR introduces an core change in the way a modal/dialog is built.
It borrows the idea of Overlay from Material2.
A ModalOverlay is the core component upon which a modal is built.
An underlaying overlay service is used to manage overlay lifecycle, behaviour (click to close, etc..) and more.
With this change some new directives are used as helpers for plugin implementation.
To allows click detection support OverlayDialogBoundary directive can be set on a container which will close the windows on every click outside of it (as lock as isBlocking is set to false)
this can also be set via code with the overlay service.
To specify a view container (for contained modal, within an element) a developer had to get a reference to the view container of that element (@ViewChild). Now OverlayTarget can be used to set an id to a view container which later can be referenced by given the string (id) instead of the viewContainerRef object.
Another feature that ease up plugin development is the base component class BaseDynamicComponent which provides API support for dynamically adding components, applying styles and getting transition and animation lifecycle notification.
This is useful for modal plugins based on CSS frameworks (e.g: bootstrap) where animation and styles are based on CSS classes. This reduces the code required by such plugins significantly.

Angular 2 native plugins should use the angular animation api.

With the introduction of overlays plugins are only responsible for setting the inner content of an overlay (an overlay comes empty), which is done by implementing the create function on a Modal class.

Demo site is now using 2.0.0-beta.0
NPM package published.


request-body Object Payload

How can I reproduce the follwing OpenApi using springfox-swagger2?
      parameters:
      - in: body
        name: user
        description: The user to create.
        schema:
          type: object
          required:
            - userName
          properties:
            userName:
              type: string
            firstName:
              type: string
            lastName:
              type: string

Here it describes this:
https://swagger.io/docs/specification/2-0/describing-request-body/

//Psuedo code
public class User {
    prop String userName;
    prop String firstName;
    prop String lastName;
}

@RequestMapping("/some-endpoint")
public void someEndpoint(@RequestBody User user) {...}

@dilipkrish
I'm having a problem maybe you can help me, in the system I was requested to use Swagger, we use Spring Boot then I'm trying to implement using springfox.
The problem is that in a real application you have, using your example, a User that has the Adress and the List List and access Rules and inurable other thigs that a User can have. The point is that a real object is very much bigger than this that you showed, and some times in a specific Rest Service I just need that the object is like this:
{

username: "joao.siva",
firstName: "John",
lastName: "Silva"

}

How can I "force" SwagerUI to show the example to object containg just the attributes that I'll need in the specific service?
Because, it`s bad to show gigant Object, that who is using the documentation will not know whats attributes I need in that service.
Did you understand me? I apologize for my bad english, I'm still learning.
And Thank's so much for your help.


Fetchart searches having problems

I just noticed that cover art wasn't being found for some albums, so checked with -v
Google search uses old API that is no longer available

fetchart: trying source google for album Yazz - The Natural Life
fetchart: getting URL: https://ajax.googleapis.com/ajax/services/search/images?q=Yazz%2CThe+Natural+Life
&start=0&v=1.0
fetchart: error scraping art page
fetchart: Yazz - The Natural Life: no art found

So I tested some URLs directly ...

https://ajax.googleapis.com/ajax/services/search/images?q=Yazz%2CThe+Natural+Life&start=0&v=1.0
https://ajax.googleapis.com/ajax/services/search/images?q=The+Motels%2CAll+Four+One&start=0&v=1.0

and get an error page from google

{"responseData": null, "responseDetails": "This API is no longer available.", "responseStatus": 403}

iTunes fails with index out of range

fetchart: trying source itunes for album Yazz - The Natural Life
fetchart: iTunes search failed: list index out of range

I'm assuming that this is when it can't find that particular cover, so this one is probably not an issue.  But it seems to happen a lot, and I thought iTunes had a good selection of cover art ...

Thanks for looking into both of these! It looks like we'll need to remove the Google source (there's no obvious alternative without a complete overhaul) and look more closely at the iTunes source.

OK, I removed the Google backend. I also improved the logging for the iTunes backend so it will emit a more sensible message like "no results for query X" rather than just the exception's text. In a couple of experiments, the backend was still able to find a couple of images for me, so I think it's still (basically) working.


Add es-AR to the official translations

@consugus thanks for your work in leading up and completing the en-AR translation! It will be the first translation that we'll make "official", so there might be a bumps as we create and refine the process.
I've pushed your fork to https://github.com/opensourceguide/es-AR and sent you an invite to the organization.

[ ] Get DNS set up (waiting for changes from team that manages DNS at GitHub)
[ ] Merge https://github.com/opensourceguide/es-AR/pull/1 and ensure https://es-ar.opensource.guide is working
[ ] Run script/sync-translation on fork to ensure it has all the latest changes (https://github.com/opensourceguide/es-AR/pull/2)
[ ] Merge this PR

Closes #383

Git

<EMAIL_ADDRESS>

Hi @bkeepers , I've passed by to see how where things, and noticed that this issue is still open
Is theere anything we can do on this?
I thought I've done everything I had to do