Inconsistent height after adding child controls to the input box

Duplicate Check

[X] I have searched the opened issues and there are no duplicates

Describe the bug
When I add a button control to the suffix of the TextField control, the height of the control is inconsistent with the height of the control without adding a suffix. I don't think this is a bug, but it has some impact on the appearance.
(From machine translation, if the expression is not straightforward, please understand)
Code sample
Code
import flet as ft

def main(page: ft.Page):
    page.horizontal_alignment = ft.CrossAxisAlignment.CENTER
    # page.vertical_alignment = ft.MainAxisAlignment.CENTER
    page.window.width = 600
    page.window.height = 600
    page.padding = 50
    page.spacing = 20

    def btn_clicked(e: ft.ControlEvent):
        if btn.text == '错误信息提示':
            user_input.error_text = 'something wrong!'
            contact_input.error_text = 'something wrong!'
            verify_input.error_text = 'something wrong!'
            btn.text = '还原'
        else:
            user_input.error_text = ''
            contact_input.error_text = ''
            verify_input.error_text = ''
            btn.text = '错误信息提示'
        page.update()

    user_input = ft.TextField(label='请输入用户名', prefix_icon=ft.icons.PERSON, text_size=20)
    contact_input = ft.TextField(label='请输入用户绑定的邮箱或电话', prefix_icon=ft.icons.CONTACT_EMERGENCY, text_size=20,
                                 suffix=ft.Icon(ft.icons.QUESTION_MARK, color=ft.colors.SECONDARY, tooltip='对此有疑问'))
    verify_input = ft.TextField(label='请输入验证码', prefix_icon=ft.icons.KEY, text_size=20,
                                suffix=ft.FilledTonalButton('发送验证码'))
    btn = ft.ElevatedButton(text='错误信息提示', on_click=btn_clicked, height=45, width=180)

    page.add(user_input, contact_input, verify_input, btn)

if __name__ == '__main__':
    ft.app(main)

To reproduce
The height of the first input box is inconsistent with that of the third input box.
Expected behavior
I hope the default input box can maintain consistent height without manually adjusting the size of the child controls.
Screenshots / Videos

Captures
[Upload media here]

Operating System
Windows
Operating system details
Windows10
Flet version
0.24.1
Regression
I'm not sure / I don't know
Suggestions
No response
Logs
Logs
[Paste your logs here]

Additional details
No response

You can now add Control to suffix_icon field instead of suffix, and then the height will be the same.

您现在可以将 Control 添加到 field 而不是 ，然后高度将相同。让我知道它是否对你有用。suffix_icon``suffix
I know that, if I add a custom button to the TextField component will change the height, so I can only place the button outside the TextField component. However, I still hope that the height of the TextField component will remain consistent by default after adding a custom component.

You can now add Control to suffix_icon field instead of suffix, and then the height will be the same. Let me know if it worked for you.

I know that, if I add a custom button to the TextField component will change the height, so I can only place the button outside the TextField component. However, I still hope that the height of the TextField component will remain consistent by default after adding a custom component.

What causes the increase in height is the default height of the suffix/prefix control you add, in this case the FilledTonalButton for example. To make the field keep it's "normal"/default height, you need to manually change the height of the added control.
    verify_input = ft.TextField(
        label="请输入验证码",
        prefix_icon=ft.icons.KEY,
        text_size=20,
        suffix=ft.FilledTonalButton("发送验证码", height=24),  // change height here
    )

If it happens that you want to change the size of the text field itself (ex: to better accommodate the size of the you suffix/prefix control), do this.
By the way, just for info, the TextField.text_size also influences the height of the field, but it isnt a problem in this case as all your fields have thesame value.


Enable snapd managed updates

We launch snap install/refresh via Pelion update(FOTA).  So disable
snapd automatic updates using the snapd managed updates feature.

@tonyespy, FYI

If the snap is installed with this plug, and the user subsequently sets the snap refresh.timer to managed via command line at the factory, how would updates be scheduled from then on?  would the user have to log into each gateway and manually initiate an update?  or will there be a follow-on feature which allows the user to remote initiate an update?  I assume this would be part of Pelion FOTA process?

@costanic, correct.

Waiting to merge after v1.16.2 release

rebased on current dev


License information

Hello, I want to use this library but I don't see the license information. I saw that maven's page for this library mentions it has "The Apache Software License, Version 2.0" but I'm not sure.
Would it be possible to add it or clear this please?

Hi @crave-pacheco
That's a good question. Yes, as far as I know, the license is Apache version 2.0.
I just created a PR to include the license file in the project root:
https://github.com/tomitribe/http-signatures-java/pull/35

Thank you!


Website is not reachable

Hey,
I love your service, it's perfect to visualize keyboard shortcuts for my blog. Currently, the website is running into a timeout if I try to reach it. I don't know how long that has been going on but I thought you might want to know so that you can take action if necessary.
Again, good job here!

Hi there, the free domain i had was for 12 months and has expired, i would like you to try this url instead: https://key2img.github.io/


L-BFGS-B optimizer in Keras

According to recent literature, the L-BFGS-B optimizer seems to be very powerful for training PINNs, overperforming stochastic optimizers (Adam, ect.) -- the L-BFGS-B can be used for second-step fine-optimization while Adam can be used in a first stage rough-optimization to prevent falling into a local minimum.  Having L-BFGS-B as a Keras optimizer available like Adam would therefore be very valuable. Currently, there are unpractical workarounds (e.g. this one) based on the Tensorflow probability BFGS minimizer, I tried it myself, but I found it rather unflexible. So, is there any plan to have the L-BFGS-B optimizer available? This request was already addressed in several Tensorflow requests, this one or this one,. Regarding the growing interest in PINNs, that would be great to have this feature.

@chenmoneygithub I think @jouvetg may have referred to a specific paper that doesn't have enough interest. If you see [https://link.springer.com/article/10.1007/BF01589116](bfgs paper) and the use of this optimizer in [https://www.sciencedirect.com/science/article/pii/S0021999118307125](PINN paper), you will realize that it is quite famous within the Sci-ML community. Most people prefer to write PINNs in PyTorch since L-BFGS is just used as any other optimizer.

It would be great to have L-BFGS-B available in Keras. It is ubiquitously used now in Sci-ML and it is frustrating to have to rely on fiddly workarounds mentioned above ...


version 4.4: interactive shell: arrow keys yield weird symbols

Description
With version 4.4.1 on Windows, after importing progressbar: pressing any arrow key yield odd symbols on the console:
Code
>>> import progressbar
>>> ^[[A^[[C^[[D^[[C^[[D^[[C^[[D^[[B^[[D^[[C^[[A^[[C^[[B^[[D   # <-- this is what happens when pressing different arrow keys on the keyboard

Versions

Python version: import sys; print(sys.version): 3.10.9
Python distribution/environment: CPython
Operating System: Windows 10
Package version: import progressbar; print(progressbar.__version__) : 4.4.1

Suspecting this change:
https://github.com/wolph/python-progressbar/commit/a9c677021e963cb419d0eac764ada0ee2f6add79#diff-5bd70fb63160004c558a687f98cb5dfe4a8925be30f161048b96966cd9de054bR170

You are very likely right... that mode enables 24 bit color support in your terminal but apparently it has side-effects in some cases.
For some reason the console mode isn't reverted back to it's original state once the script is done it seems so that's certainly a bug.
As a quick workaround, I can't reproduce the issue in PowerShell so that might help

Thanks for the quick response!
I am able to reproduce it on Powershell as well:

Oh... that's odd. Generally on Linux/Unix systems this is caused by not having readline available, but while it's better with readline, it doesn't solve the issue for me it seems.
You can try like this:
pip install pyreadline3

And after that:
import pyreadline3
pyreadline3.Readline()

Still buggy, this time pressing arrow keys makes parts of the terminal to disappear:

if I press some more arrow keys, it will erase more chunks:

I've pushed a fix to the develop branch, can you see if it works for you?
pip install "git+https://github.com/wolph/python-progressbar.git#egg=progressbar2"

Looks good! The issue does not reproduce with this version (commit 20f1bbb41f751824a28bbe7ea88cedf718b7a12a)

The new release is online!

Thanks @wolph ! I currently don't see a new release (4.4.2 ?) on pypi though:
https://pypi.org/project/progressbar2/#history

Odd... I've attempted to upload it again and it seems to have worked this time :)

Cheers, thank you! Confirmed no issue using 4.4.2 👍


RunOptionsAndReturnExitCode does not return exit code. Always exit with 0 as it's void

There is no possibility to return a value from your code as the RunOptionsAndReturnExitCode is of type Action which returns void. RunOptionsAndReturnExitCode should be at least renamed so it doesn't confuse users with the "AndReturnExitCode" in its name.

You can return a value (exit code) from RunOptionsAndReturnExitCode as a function return value not Action when you use MapResult method.
Example:
	CommandLine.Parser.Default.ParseArguments<Options>(args)
		.MapResult(
		  (opts) => RunOptionsAndReturnExitCode(opts),
		  errs => HandleParseError(errs));

	 int  RunOptionsAndReturnExitCode(Options o)
		{
		  // do your stuff here and return Exitcode based on the program logic
		  var exitCode=0;
		  //exit code values
		  //0 normal use
		  // -1 for offset >10
		  // -2 for offset <5
		  if (o.Offset >10)  exitCode= -1;
		  if (o.Offset <5)  exitCode= -2;

		  return exitCode;
		}

Also, you can use async/await 	with MapResult.
RunOptionsAndReturnExitCode is not part of the Codebase of the library but a user defined method(function).
Online Demo

Is it clear the usage of RunOptionsAndReturnExitCode?

Thank you for a detailed example @moh-hassan. For other readers interested in the Online Demo https://dotnetfiddle.net/wrcAxr just update your main function to return int and return the parserResult from Main


Update ML.NET Azure Functions How-To Guide

Summary
Update sample and how-to guide for deploying ML.NET models to Azure Functions
Fixes #32840
Preview Link

Closing in favor of #33060


Add CLI

Adds a simple bin script to run the program without much hassle. Currently just using the example options by default.

Hello, OutThisLife.
Thank you for your help.
What be process to speed update:
You need to write how to use it, for README.md
I will to see your code and use.
If all good, I adding you in contributor.

@semiromid Will add soon when I get some free time :)


3ds Max 2024 Support

Hello, I previously wrote in the issue thread about 2022 support - https://github.com/GPUOpen-LibrariesAndSDKs/RadeonProRenderMaxPlugin/issues/8#issuecomment-866775065
I apologise in advance if this post comes across as critical as that is not my intention as myself and many others have been waiting for updated AMD ProRender and AMD GPU support in 3ds Max to re-materialise for a number of years now and it is quite frustrating having unsupported hardware.
I was told back then in June 2021 that you were waiting for USD Hydra support and render delegate support to become available in 3ds Max, those two things are both available in Max 2024 since it was released in March, with the updated 3ds Max 2024 USD SDK available as part of May's 2024.1 point release which came bundled with the updated USD for 3ds Max to version 0.4.

USD for 3ds Max Release Notes - https://help.autodesk.com/view/3DSMAX/2024/ENU/?guid=GUID-6C9515F4-3678-48C9-B0B0-832BD2835BE0
Introduction to Arnold USD - Arnold User Guide - https://help.autodesk.com/view/ARNOL/ENU/?guid=arnold_user_guide_ac_intro_usd_html

As you are no doubt aware Arnold is Autodesk's own renderer which only supports Nvidia's CUDA platform, thus outside of rendering with Arnold on CPU or Nvidia GPUs it cannot be used on AMD GPU hardware.
The Arnold developers have been approached previously (many years prior to the advent of USD) in their own forums about adding AMD GPU support into Arnord directly and they answered quite bluntly a number of years ago that they had no plans to support AMD hardware as they only supported the CUDA API and if I recall correctly this was back in 2016 when Solid Angle were a wholly separate company from Autodesk.
Therefore in order to take advantage of AMD GPU's within 3ds Max we need this support to come from AMD / ProRender as Autodesk do not appear willing to offer any native AMD GPU support, that willingness may have changed but Arnold does not appear to be moving in a hardware agnostic direction.
The product support from AMD in the form of ProRender was available up until 2020 with 3ds Max 2021 support when you stopped updating the 3ds Max version of ProRender making it unavailable on newer versions of 3ds Max despite issues created asking for an update to support 3ds Max 2022 and many blog posts on gpuopen.com with media campaigns promoting ProRender updates & features on various social media platforms, and yet ProRender still remains unavailable on 3ds Max beyond the 2021-version from 2020 which is very outdated now.
Here are a group of links that you may find useful/helpful:

The Arnold USD implementation is open-sourced under the Apache 2.0 licence here on Github which could be used to reference in development https://github.com/Autodesk/arnold-usd/blob/master/README.md
The 3ds Max 2024 developer help centre is located here - https://help.autodesk.com/view/MAXDEV/2024/ENU/
The 3ds Max 2024 SDK and 3ds Max 2024 USD SDK are both available from here (as well as all prior SDKs) - https://www.autodesk.com/developer-network/platform-technologies/3ds-max#3dsmax-sdk
The 3ds Max USD API is documented here - https://help.autodesk.com/view/MAXDEV/2024/ENU/?guid=Max_USD_SDK_Help_index_html
An invitation link for the official Autodesk 3ds Max Discord server which may be useful for informal discussions with the 3ds Max development team - https://discord.com/invite/3dsmax

I hope that we see an updated ProRender for 3ds Max sooner rather than later which also comes with baked in support for consumer Navi/RDNA1/2/3 GPUs (even if this would require a switch to the Pro series of drivers), that would be a move in the right direction which would be advantageous in spreading support of AMD GPUs in 3ds Max, expanding your potential customer base and expanding AMD brand awareness to a much larger audience.

We appreciate the interest.
3DS Max has support for import and export of USD, but not support for USD Hydra render delegates.  Yes, Arnold has a USD Hydra delegate, but that is another issue.
Any other solution built around 3DS Max's current USD functionality would involve exporting a USD, bringing it into another application and rendering there.  Not sure that is what you are looking for.
Brian

@Uro1 Have you tried the ZLUDA implementation? This might be interesting to take a look at. However Arnold is still WiP. A minimum of OptiX framework is used to support Arnold. ZLUDA's OptiX is buggy, unoptimized and incomplete. They have tested with Arnold <IP_ADDRESS> command line rendering on Linux.

If any AMD Software Developer or Employee see this message don't forget to make sure to conform AMD CEO Lisa Su they forget the 3d beigners those who use amd GPU for learning Modelling. I would like to have AMD Radeon Pro Render or AMD HIP Ray Tracing support for 3ds Max in 2024 . The softwares those I would like to get amd support are Lumion , Maya , Mormoset Tools , etc .


issue124 Enhance Documentation for variables that are used in several places

This closes #124.

@j-c-cook Could you take a look at this PR and confirm that it addresses the issues raised in #124?

What you have done is great. I also had a couple of other things I had thought about addressing with that issue. Please see the following PR: https://github.com/MassimoCimmino/pygfunction/pull/128#issue-690243368.
I thought it might be nice to separate the examples and modules into their own folders. What do you think?
Also, what do you think about the nomenclature table? Perhaps we should have more than one. I don't think this should be all inclusive, but rather the thermodynamic and geometric variables used.

I just updated the code following the merge of #128.


Rebrand namespaces and docs

Contributes to #811
There should be no functional changes here, only branding in namespaces, docs, and the session affinity cookie name.
I standardized all the samples to use the Yarp.Sample namespace.

What happens to names for ILogger, do notes in the sample need to include Yarp.ReverseProxy in config for logging?

You're right that this changes the logs so they now come from the Yarp namespace. I think that's OK for our samples, they end up using the default app logging config. For Development (appsettings.Develoment.json) they default to Debug, and for production (appsettings.json) they default to Information.
The appsettings in BasicYarpSample could use an update though. It doesn't have an appsettings.Development.json so it will always use Info logs. Some of the comments are out of date too.


Please don't color the brackets in comments

Like here:

What language is this?

@CoenraadS JavaScript/TypeScript

Is that what it says in the status bar?

Because it should be working for those languages. Else can you post a snippet that causes this so I can try to reproduce.

I have the same TS version.
Your great extension works..
I'm talking about the comments that show the brackets in a pair color instead of show them in a gray color like the whole comment.

For me it is working though:

So I'm not sure what is causing the coloring :(

Extended comment from one of my teaching JS files, also attached is the image of what it renders like. I'm using the Solarized-dark theme if that helps:
/************
 *
 * ### 3 ###
 *
 * Array.prototype.sort()
 * Sort the inventors by birthdate, oldest to youngest
 *
 * .sort() works a lot like .filter() and .map() but happened to be part of the JS spec way before ES6
 * You can use this one freely on Internet Explorer without worrying about Bill Gates knocking on your door for ActiveX insubordination
 *
 * .sort() has a callback function with two arguments very much like .filter() and .map()
 * So the first way to think about .sort() is to think about it as a loop once again, another loop without all the `for` syntax hanging around
 * Each pass of the loop, it compares two items in the array sequentially, one after the other
 *
 * the first argument is what you can think of as a first item to compare while the second argument would be the second item the first gets compared to
 * .sort() actually works differently on different browsers. The JS gods have a steering committee called ECMAScript that hasn't laid out a specific algorithm for sorting, so JS interpreters can sort however they like.
 * More here if you're really curious about the .sort() algorithm: https://stackoverflow.com/a/1494742
 *
 * I think the easiest way to wrap your head around JS sorting is to picture each item getting selected, one by one. That selected item then gets compared to the item before it, and ordered in the array according to the condition you set.
 * Most of the time, sort will likely be arranging items in ascending or descending order but perhaps you could use it for other things.
 * In our example, we're looking for the array to get sorted by the earliest year, so everytime firstArrayItem is bigger than secondArrayItem, we return 1.
 * That is basically saying 'true' but in a way that can be compared by the algorithm inside .sort()
 */

Should be fixed in latest release

Confirmed on my end:


nixos/utils: support JSON secret files in genJqSecretsReplacementSnippet

Description of changes

An alternative to https://github.com/NixOS/nixpkgs/pull/324955.

genJqReplacementSnippet quotes the content of the secret file in the
output json file, which prevents structured secret, such as a list or
an object, from being used.

This PR adds a quote = true|false option to the { _secret = "/path/to/secret"; } attribute set. quote = true threats the content of /path/to/secret as string, while quote = false threats the content of /path/to/secret as a JSON document.
quote = true is the default, so this PR maintains backward compatibility.
# demo.nix

let
  demoNixpkgs = fetchTarball "https://github.com/linyinfeng/nixpkgs/archive/refs/heads/json-secrets.zip";
  pkgs = import demoNixpkgs {};
  inherit (pkgs) lib;
  utils = import "${demoNixpkgs}/nixos/lib/utils.nix" {
    inherit lib pkgs;
    config = null;
  };
  settings = {
    example = [
      {
        irrelevant = "not interesting";
      }
      {
        ignored = "ignored attr";
        relevant = {
          secretString1 = {
            _secret = pkgs.writeText "password1" "secret-quote-1";
            # quote = true is the default
          };
          secretString2 = {
            _secret = pkgs.writeText "password2" "secret-quote-2";
            quote = true;
          };
          secretJson = {
            _secret = pkgs.writeText "password3" (builtins.toJSON {
              p1 = "supersecret";
              p2 = [2 3];
            });
            quote = false;
          };
        };
      }
    ];
  };
  snippet = utils.genJqSecretsReplacementSnippet settings;
in
pkgs.runCommand "test.json" {} ''
  ${snippet "result.json"}
  cp result.json "$out"
''

$ nix-build ./demo.nix && cat result
/nix/store/36rgaa21gml1xl0lk3rdm28z3vw1rv84-test.json
{
  "example": [
    {
      "irrelevant": "not interesting"
    },
    {
      "ignored": "ignored attr",
      "relevant": {
        "secretJson": {
          "p1": "supersecret",
          "p2": [
            2,
            3
          ]
        },
        "secretString1": "secret-quote-1",
        "secretString2": "secret-quote-2"
      }
    }
  ]
}

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

https://github.com/ofborg test sing-box lemmy engelsystem artalk discourse
filebeat does not have a NixOS test.
netbird's NixOS test does not use secrets.
gitlab's NixOS test is flaky.


In anderson test, added support for right skewed gumbel distribution.

The default anderson tests with dist='gumbel' assumes a left skewed
gumbel distro, gumbel_l.
For compatibility with the distros available in scipy.stats, added
functionality for the user to test right skewed gumbel distributions,
gumbel_r.
If user input is dist='gumbel', then 'gumbel_l' is assumed, as before.
On the top of that, added possibility for user input dist='gumbel_r'.
PS: I'm new to github. Please let me know if I'm doing things as they should be done =)

Thanks for the patch!
Test failures are real, need to be addressed -- you can click on "Details" link next to the Travis CI status to see exact failures. Note that you can run test before pushing, e.g. $ python runtests.py -s stats.
You are addressing this issue, right? https://github.com/scipy/scipy/issues/2592
Note that you can add a magic phrase "closes gh-2592" and that issue will be automagically closed when your PR is merged.

Yes, it'd be cleaner IMO.

OK, the last request: 3 commits for a dozen lines of a change is a bit too much. Can you squash it down please?
$ git rebase -i HEAD~3
$ # in the editor, change 'pick' to 'squash'
$ git push origin HEAD --force

No problem. Was not sure I should do that.
Squashed and pushed now.
Thanks for the tips.

LGTM now.

do the critical values apply in this case?
if gumbel_r and gumbel_l have the same shape except sign or flipped, then it should be the same. Otherwise, it needs verification that the critical values are correct.

i.e. there should be unit tests for a new case.

Indeed gumbel_l and gumbel_r have the same underlying equations. They are in fact just shortcuts to sign of the variate, for easier use since fitting maxima to X is the same as fitting minima to -X.
So, for distributions around zero, it will hold that
gumbel_l.pdf(x) == gumbel_r.pdf(-x)
gumbel_l.cdf(x) == 1-gumbel_r.cdf(-x)

A more generic test case

from scipy import stats as ss
from random import random

loc, scale = 8, 5

for i in range(15):
    #  random float between (loc-2*scale, loc+2*scale[
    x = loc + random()*4*scale - 2*scale

    print(ss.gumbel_l(loc=loc, scale=scale).pdf(loc+x) ==
          ss.gumbel_r(loc=loc, scale=scale).pdf(loc-x), end=' ')
    print(ss.gumbel_l(loc=loc, scale=scale).cdf(loc+x) ==
          1-ss.gumbel_r(loc=loc, scale=scale).cdf(loc-x))

That said, I'm yet not sure how all this affects the critical values, but it seems that they will be the same.

These gof tests, like AD or KS, only depend on the shape of the cdf, flipping it doesn't change the underlying statistic, so critical values should be the same for both gumbel versions.
So, I don't see a problem with this.

Actually, this needs a test. At least a smoke test that gumbel_r is accepted as a value, also that gumbel_l is equivalent to 'gumbel'.
Please add them to TestAnderson class of scipy/stats/tests/test_morestats.py

Thanks @haphaeu and congratulations with what I believe us your first scipy commit. Keep them coming!

No problem. Indeed my first commit - will try to keep contributing.
Thanks for the support!


Add support for auto publish image / helm chart with github action

Part of: https://github.com/alibaba/higress/issues/122
When a commit gets merged, github workflow can auto publish latest image / helm chart of higress.

already support


Zone redundancy FAQ

Currently Zone redundancy cannot be enabled in existing Event hubs namespace

@spelluru - Could you review this public PR or assign it to someone who can review it?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Feature/vdx 172/version discovery

Please rebase, as there are simply too many changes from @sksadjad in here for me to do a proper review


SDS web: colors page

Something went wrong with PR preview build please check

Preview is available here:http://design-system-pr201.previews.kube001.services.stellar-ops.com/

Preview is available here:http://design-system-pr201.previews.kube001.services.stellar-ops.com/


getInitialProps error when result is a simple string

i have a server with a ping endpoint, and a next client with a component as follows:
import React from 'react'
import 'isomorphic-fetch'
export default class extends React.Component {
	static async getInitialProps () {
		const res = await fetch('http://localhost:20831/Ping')
		const data = await res.json()
		return { pingResult: data }
	}

	render(){
		console.log('PING', this.props);

		return

PING

	}
}

If my Ping endpoint returns:
{   data: 'GET ALL PING }
everything is fine.
However, if it returns:
'GET ALL PING'
I get the following error in the server render for next:
SyntaxError: Unexpected token G in JSON at position 0
    at Object.parse (native)
    at D:\git2\fbkt-next\node_modules\node-fetch\lib\body.js:48:15
    at process._tickCallback (internal/process/next_tick.js:103:7)

Can I not return a simple string to the getInitialProps call?

You can return only an object, that because React's props is an object.

Your problem appears to be this line:
const data = await res.json()
res.json assumes your response body is of json, but you have the string "GET ALL PING".
Try res.text() instead of res.json()

@nkzawa I think you got the question wrong.
@stlbucket You are using res.json but your response is not valid json. Just replace that with res.text()

@eezing Oops! You beat me to the answer 😄


As an author, posts I make can be in markdown (commonMark is good)

closing with the PR: https://github.com/Zhipeng-Chang/CMPUT404-Winter-2019-GroupProject/pull/64


citation_style report: CSL short form of 'no date' does not render on the website as intended

The csl defines a short form of the term "no date" as s.d., both for English and Dutch. When rendering from Rstudio (below pandoc statement is run), this locally results in the citation "Databank Ondergrond Vlaanderen (s.d.).".
/usr/lib/rstudio/bin/pandoc/pandoc +RTS -K512m -RTS ./index.split.md ./010_making_bib.split.md ./100_references.split.md --to html4 --from markdown+autolink_bare_uris+tex_math_single_backslash --output citation_style.html --email-obfuscation none --wrap preserve --csl /home/floris/lib/R/library/INBOmd/research-institute-for-nature-and-forest.csl --standalone --section-divs --table-of-contents --toc-depth 3 --template css/gitbook.html --highlight-style pygments --number-sections --include-in-header /tmp/Rtmp8rS0F7/rmarkdown-str14817c0b00b9.html --mathjax --lua-filter /home/floris/lib/R/library/rmarkdown/rmd/lua/pagebreak.lua --lua-filter /home/floris/lib/R/library/rmarkdown/rmd/lua/latex-div.lua --file-scope --filter /usr/lib/rstudio/bin/pandoc/pandoc-citeproc
However it appears to render on the website (5th bullet here) as "n.d.".
It may have to do with a different locale used in the build, and probably defining a locale fallback in the csl will then be the easiest way to solve this.
@ThierryO How can we test this for the build? Will I put the csl tweak in a PR of INBOmd, after which you merge in INBOmd master and retrigger the build here?
I'll also make a few updates of the report itself, regarding the issues at BBT.

They easiest way to test it "locally" is through Docker. The Docker image and the scripts are listed in https://github.com/inbo/inbomd_examples/blob/master/wercker.yml

The locale in the Docker image is en_US.UTF-8. This is set by one of the parent images. Maybe you try to set the locale on your machine to en_US.UTF-8 and see if you can reproduce it.

I'll first try the second option from a shell session.

I could not reproduce it locally (with shell session as below); still shows 's.d.' here. And the bibliography correctly comes up with English terms.
Code and output
floris@inbofloris citation_style $ export LC_ALL="en_US.UTF-8"
floris@inbofloris citation_style $ export LANG="en_US.UTF-8"
floris@inbofloris citation_style $ export LANGUAGE="en_US:en"

floris@inbofloris citation_style $ locale
LANG=en_US.UTF-8
LANGUAGE=en_US:en
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_TIME="en_US.UTF-8"
LC_COLLATE="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_PAPER="en_US.UTF-8"
LC_NAME="en_US.UTF-8"
LC_ADDRESS="en_US.UTF-8"
LC_TELEPHONE="en_US.UTF-8"
LC_MEASUREMENT="en_US.UTF-8"
LC_IDENTIFICATION="en_US.UTF-8"
LC_ALL=en_US.UTF-8

floris@inbofloris citation_style $ cat render_csl.R
rmarkdown::render_site(
  output_format =  bookdown::gitbook(
    split_by = "chapter+number",
    template = INBOmd::inbo_rapport_css("html"),
    pandoc_args = c(
      "--csl",
      system.file(
        "research-institute-for-nature-and-forest.csl",
        package = "INBOmd"
      )
    )
  )
)

floris@inbofloris citation_style $ Rscript render_csl.R

processing file: citation_style.Rmd
  |..........                                                            |  14%
  ordinary text without R code

  |....................                                                  |  29%
label: unnamed-chunk-1 (with options)
List of 2
 $ echo   : logi FALSE
 $ results: chr "asis"

  |..............................                                        |  43%
  ordinary text without R code

  |........................................                              |  57%
label: unnamed-chunk-2 (with options)
List of 3
 $ echo  : logi FALSE
 $ eval  : language !natbib
 $ engine: chr "asis"

  |..................................................                    |  71%
   inline R code fragments

  |............................................................          |  86%
label: unnamed-chunk-3 (with options)
List of 3
 $ eval   : language !natbib
 $ echo   : logi FALSE
 $ results: chr "asis"

  |......................................................................| 100%
  ordinary text without R code

output file: citation_style.knit.md

/usr/lib/rstudio/bin/pandoc/pandoc +RTS -K512m -RTS ./index.split.md ./010_making_bib.split.md ./100_references.split.md --to html4 --from markdown+autolink_bare_uris+tex_math_single_backslash --output citation_style.html --email-obfuscation none --wrap preserve --csl /home/floris/lib/R/library/INBOmd/research-institute-for-nature-and-forest.csl --standalone --section-divs --table-of-contents --toc-depth 3 --template css/gitbook.html --highlight-style pygments --number-sections --include-in-header /tmp/RtmppyCzXh/rmarkdown-str2a0e6fc10bf6.html --mathjax --lua-filter /home/floris/lib/R/library/rmarkdown/rmd/lua/pagebreak.lua --lua-filter /home/floris/lib/R/library/rmarkdown/rmd/lua/latex-div.lua --file-scope --filter /usr/lib/rstudio/bin/pandoc/pandoc-citeproc

Output created: ../../docs/citation_style/index.html

What do you get when you make the Rmd file display the output of Sys.getlocale(). Just to make sure that render uses the locale you set at the CL.

What I could find:

the system locale (which coincides with feedback from Sys.getlocale()) does not influence the language that is used by pandoc for citations. Hence, with current Rmd content it always falls back to English as a default. And at least locally, this means "s.d." (because it is defined as such for 'en' and 'nl' in our csl file) - but not on the website. I ran this with pandoc 2.3.1 (in older RStudio on bionic) and pandoc 2.7.3 (current Rstudio, on focal).
setting the language for pandoc is done with lang: in the YAML header, see here.

just lang: en, or lang: en-XY (US, GB, AU) all gave the "s.d." result. (hence, same as without lang)
lang: nl indeed switched to Dutch bibliography

The only CSL locales (see repo) where 'n.d.' is defined (and where 'n.d.' must come from), are:

./locales-af-ZA.xml:45:    <term name="no date" form="short">n.d.</term>
./locales-en-GB.xml:54:    <term name="no date" form="short">n.d.</term>
./locales-en-US.xml:54:    <term name="no date" form="short">n.d.</term>
./locales-km-KH.xml:45:    <term name="no date" form="short">n.d.</term>
./locales-mn-MN.xml:45:    <term name="no date" form="short">n.d.</term>
./locales-sk-SK.xml:51:    <term name="no date" form="short">n.d.</term>

Presumably the 'n.d.' result on the website just comes from en-GB or en-US, but anyhow it's weird that the English locale setting for this term in the csl is ignored. Likewise, "edn." (defined in the csl file) is not used but instead the English default "ed." for the term 'edition'. It's not clear whether explicitly setting lang: en would affect this for the result with the docker image.
For further experimenting with this (e.g. lang: en, the docker image would be needed indeed, though I'm hesitating to let it take my precious disk space ;-).
Anyhow, to me this remains quite of a mystery. I can only think of pandoc doing this 'somehow' in the docker image (I think this runs debian buster, but it probably uses the same rstudio pandoc?). Maybe you have other ideas.

@ThierryO , in the docker image, what is the (shell) output of:
which pandoc
which pandoc-citeproc
which rstudio
rstudio --version
pandoc --version
pandoc-citeproc --version

I believe the inbomd_examples repo should reproduce what happens for the RStudio user, i.e. by using pandoc from RStudio. For shell commands (like Rscript), I set the PATH variable such that it first finds pandoc from RStudio, i.e. from /usr/lib/rstudio/bin/pandoc/.

Hmm :thinking: :smile:  . @ThierryO the described issue seems to be solved? That's great! What did you change?

I don't have a clue. Maybe something changed in the parent Docker image?


Example not working?

Hi - just cloned and tried to run the example code. I get the following error:
python run_bagel_crisprcleanr.py -i HAP1-TKOv3-EXAMPLE.txt -s HAP1-TKOv3-EXAMPLE-SCREENINFO.txt -o HAP1-TKOv3-bagel

  File "run_bagel_crisprcleanr.py", line 218
    print(f"\n{filenames_rep.loc[rep,'ccr_fc']} doesn't exist. Skipped!\n")

Any ideas please?

A bit shocking that the authors have left you hanging for two and a half years.
I ran into the same problem, and just in case you're wondering: this stems from a few dependencies that are inadequately explained. Make sure that your R installation has CRISPRclearR installed (https://github.com/francescojm/CRISPRcleanR), but also that DNAcopy is available (https://doi.org/doi:10.18129/B9.bioc.DNAcopy).
With those, the example should run and complete.


When using carthage, the generated framework has an external dependency: Sources/CTrueTime/*.h

I added TrueTime to my project, using Carthage.
I did not add the folder "Checkouts" to source control.
Steps to reproduce:

Remove the "Checkouts" folder.
Build your project.

Expected:

My project builds correctly, using the TrueTime carthage generated framework.

Reality:

Xcode drops the error: Missing required module 'CTrueTime'.

Troubleshooting: if the file Sources/CTrueTime/*.h stays in the "Checkouts" folder, everything is fine. If it is not, the CTrueTime module can not build.

Hello, is there any progress on this one? It's still an issue

its strange. but i have found that for compiling another framework, that depends on TrueTime.framework needs to be available path to project with Soruces/CTrueTime where have been compiled TrueTime.framework. it looks like hard link to CTrueTime module

Still issue for me on version 5.0.0 using Carthage.


HAI-2652 Prevent multiple requests happening because of multiple button clicks

Description
There was a problem with adding a new contact for hanke where clicking "Tallenna ja lisää yhteyshenkilö" button multiple times would send requests and the ones after the first one would fail because the same user was already created with the first request and an error would be shown to user.
Fixed the problem by creating a wrapper for react-query useMutation hook where the mutate function is debounced, preveting multiple consecutive mutations happening in short succession.
Also applied that hook to places where there might be a risk for multiple consecutive requests.
Jira Issue: https://helsinkisolutionoffice.atlassian.net/browse/HAI-2652
Type of change

[ ] Bug fix
[ ] New feature
[x] Other

Instructions for testing

Add new contact person in hanke form, johtoselvitys form or kaivuilmoitus form
When adding contact person try to click "Tallenna ja lisää yhteyshenkilö" button many times in a row
Check that only one POST request for that is made

Checklist:

[x] I have written new tests (if applicable)
[x] I have ran the tests myself (if applicable)
[ ] I have made necessary changes to the documentation, link to confluence
or other location:

Other relevant info
Please describe here if there is e.g. some requirements for this change or
other info that the tester/user needs to know.

Tested and it works. I could not create an error from double-clicks.


torch.nn.Module classes cannot be used in Pipeline

I tried to add color jittering augmentation to the ImageNet training through inserting line torchvision.transforms.ColorJitter(.4,.4,.4) right after RandomHorizontalFlip, but met this error:
numba.core.errors.TypingError: Failed in nopython mode pipeline (step: nopython frontend)
Failed in nopython mode pipeline (step: nopython frontend)
Untyped global name 'self': Cannot determine Numba type of <class 'ffcv.transforms.module.ModuleWrapper'>

File "../ffcv/ffcv/transforms/module.py", line 25:
        def apply_module(inp, _):
            res = self.module(inp)
            ^

During: resolving callee type: type(CPUDispatcher(<function ModuleWrapper.generate_code.<locals>.apply_module at 0x7f921d4c98b0>))
During: typing of call at  (2)

During: resolving callee type: type(CPUDispatcher(<function ModuleWrapper.generate_code.<locals>.apply_module at 0x7f921d4c98b0>))
During: typing of call at  (2)

File "/home/chengxuz/ffcv-imagenet", line 2:
<source missing, REPL/exec in use?>

Any idea on what's happening here and how to fix this?

It should be working. I'll take a look!
PS: Torch augmentations are really slow especially if you run them before copying them on the GPU. We recommend using them only for experimentation purposes. If an augmentation is useful you should consider implementing a numpy version (and optionally share it with the community).

In the meantime does this PR fixes it for you ? https://github.com/libffcv/ffcv/pull/59

@chengxuz can you post what your full pipeline was? From the output you posted, it looks like you might be trying to apply a torchvision transform on a NumPy array (i.e., before calling ToTensor).

I did this to the ImageNet training pipeline (https://github.com/libffcv/ffcv-imagenet/blob/main/train_imagenet.py#L223):
        image_pipeline: List[Operation] = [
            self.decoder,
            RandomHorizontalFlip(),
            torchvision.transforms.ColorJitter(.4,.4,.4),
            ToTensor(),
            ToDevice(ch.device(this_device), non_blocking=True),
            ToTorchImage(),
            NormalizeImage(IMAGENET_MEAN, IMAGENET_STD, np.float16)
        ]

I was following this doc: https://github.com/libffcv/ffcv/blob/main/docs/making_dataloaders.rst#transforms, which I guess is out-dated now?

After moving the torchvision.transforms.ColorJitter(.4,.4,.4) after the ToTorchImage function, I think it works! Is this the best location for this transform to be?
Anyway, thanks for your help! It would be great if you can also update the document.

Yeah, all of the torchvision transforms operate on PyTorch tensors, so they have to be put after ToTorchImage---we will add this to the documentation and make the error message a bit more descriptive :) Thanks!

To complement this, I'm also experimenting with a mixed ffcv/torchvision pipeline before writing the augmentations as ffcv and I noticed a weird behaviour. My pipeline is defined like this:
image_pipeline = [
        RandomResizedCropRGBImageDecoder((crop_size, crop_size), scale=(min_scale, max_scale)),
        RandomHorizontalFlip(flip_prob=horizontal_flip_prob),
        ToTensor(),
        ToDevice(device, non_blocking=True),
        ToTorchImage(),
        transforms.RandomApply(
            [transforms.ColorJitter(brightness, contrast, saturation, hue)],
            p=color_jitter_prob,
        ),
        NormalizeImage(mean=mean, std=std, type=np.float16),
    ]

GPU memory oscillating between 10gb and 5/6gb. If I comment out the RandomApply operation, it is stable at around 6gb. Are there any new allocations that are made?

Memory is only pre-allocated for FFCV transforms, so the torchvision transforms there are probably allocating memory at each iteration. Rewriting the torchvision transform as an FFCV one will fix this!

Just another followup on this, if the augmentation (like ColorJitter) is applied in this way, all images in the same batch will share the same augmentation dynamics, like the randomly determined color brightness, cotrast, saturation, and hue factors. This would be terrible for typical contrastive learning algorithms, so it seems that rewriting the transform as an FFCV one is indeed be needed.

Can you clarify what you mean @chengxuz with an example. This might not be expected behavior

For example, if I add this augmentation Random Grayscale. I would expect that the images within the same batch would randomly be turned into grayscale with the probability I specified, meaning one image might be grayscale, the other image might not. This is achieved in typical usage of this module as it will be applied to each PIL image independently, therefore yielding different behaviors for images even in the same batch. But the mechanism of this module when processing a batch of images is that the whole batch will be grayscale or not. This is because the module processes the whole batch as one unit to decide doing the grayscale or not. As FFCV applies the pipeline to batch of images, this then leads to the current behavior.

Haven't dove into FFCV's augmentations, but what dali does (and it also applies the pipeline to the whole batch) is using a multiplexing operation to decide which images to apply augmentations (https://docs.nvidia.com/deeplearning/dali/user-guide/docs/examples/general/expressions/expr_conditional_and_masking.html)

@chengxuz Do you have a reproduction script because reading the documentation from torchvision it seems that it's not what would happen. FFCV passes the batch as is to the augmentation, if it flips the coin on a per image basis or for the whole batch is unfortunately beyond our control (but from what I understand it's not what they are doing)

I personally checked and it seems that you are right @chengxuz. This sounds terribly unintuitive and imo should be reported to torchvision. FFCV handles images per image so this should never be a problem though.

@vturrisi FFCV also has per-image randomness in its augmentations (so I think the only augmentations that don't support this are the torchvision ones).
Since it looks like all the FFCV-related problems here are solved, I'll close this issue for now---feel free to re-open if there's anything we missed!

@andrewilyas thanks for the comment above, but how can we rewrite below from transformers to FFCV since the latter doesn't the counterpart of them? And if mix using transforms, it would slower the FFCV a lot?
transforms.RandomApply([transforms.ColorJitter(0.4, 0.4, 0.4, 0.1) ], p=0.8),
transforms.RandomGrayscale(p=0.2),
transforms.RandomApply([GaussianBlur([.1, 2.])], p=0.5),

where
class GaussianBlur(object):
    """Gaussian blur augmentation in SimCLR https://arxiv.org/abs/2002.05709"""

    def __init__(self, sigma=[.1, 2.]):
        self.sigma = sigma

    def __call__(self, x):
        sigma = random.uniform(self.sigma[0], self.sigma[1])
        x = x.filter(ImageFilter.GaussianBlur(radius=sigma))
        return x


Breakpoint misbehavior inside symbol-keyed function property

Steps to Reproduce

Create new "Blank node.js Console Application".
Paste the following code into app.js.
Set breakpoint at line 5.
Choose Debug > Start debugging.

var S = Symbol();
var o = {
	[S]() {
		console.log("before");
		console.log("at breakpoint");
		console.log("after");
	}
}
o[S]();

Expected Behavior
"before" is printed to the console then the debugger stops at line 5.
Actual Behavior
"before" is printed to the console then the program hangs up. VS remains responsive.
If I choose Debug > Break all then Debug > Continue,
the program runs and terminates without ever stopping at the breakpoint.

NTVS Version: 1.2.40627.01
Visual Studio Version: VS 2015 Community U3
Node.js Version: v4.4.7-x64, v6.2.2-x64

I was able to reproduce the same effect using the built-in command line debugger of node.js, so this seems to be unrelated from Node.js tools.
I have reported the bug to the node.js developers.
A possible workaround is to extract the function reference into a variable and call the function via that variable.
var S = Symbol();
var o = {
	[S]() {
		console.log("before");
		console.log("at breakpoint");
		console.log("after");
	}
}
var f = o[S];
f();

Thank you for reporting this to node and finding a work around.
I'm closing this as external because it's not actionable for NTVS, but will keep on eye on the reported issue to see when the fix lands in Node.

My thoughts exactly. :+1:


Fix bug with hitsounds

this should fix https://github.com/grafexteam/fnf-grafex/issues/14

Maybe you should make an if statement for if ClientPrefs.hsvol is equal to zero, then hitsoundsDisabled can be true.

ok

and also a semi colon.
and this
source/grafex/states/playstate/PlayState.hx:396: lines 396-399 : Float should be Bool
source/grafex/states/playstate/PlayState.hx:396: lines 396-399 : ... For function argument 'Function'

No song will play when I select it.

yeah, this is probably not gonna get merged anyways so...


Codeunit 6166 - "EDoc Import PEPPOL BIS 3.0" - Event publisher request

Describe the request
Hello,
I would like to request the addition of new events within the "ParseInvoice" and "ParseCreditMemo" functions of Codeunit 6166 - "EDoc Import PEPPOL BIS 3.0".
Specifically, we are seeking to add events that would allow us to map additional fields with the corresponding XML files during the import process.
The addition of these events would provide us with the flexibility needed to extend the standard functionality and accommodate custom requirements for field mapping in our implementation.
Additional context
local procedure ParseInvoice(EDocument: Record "E-Document"; var PurchaseHeader: Record "Purchase Header" temporary; var PurchaseLine: Record "Purchase Line" temporary; var DocumentAttachment: Record "Document Attachment"; DocumentAttachmentData: Codeunit "Temp Blob"; var TempXMLBuffer: Record "XML Buffer" temporary)
var
	Base64Convert: Codeunit "Base64 Convert";
	OutStream: OutStream;
	InStream: InStream;
	Path, Value : Text;
begin
	Path := TempXMLBuffer.Path;
	Value := TempXMLBuffer.Value;
	case Path of
		.
		.
		.
		.
	end;
	OnAfterParseInvoice(EDocument, PurchaseHeader, PurchaseLine, DocumentAttachment, DocumentAttachmentData, TempXMLBuffer, Path, Value);
end;

[IntegrationEvent(false, false)]
internal procedure OnAfterParseInvoice(EDocument: Record "E-Document"; var PurchaseHeader: Record "Purchase Header" temporary; var PurchaseLine: Record "Purchase Line" temporary; var DocumentAttachment: Record "Document Attachment"; DocumentAttachmentData: Codeunit "Temp Blob"; var TempXMLBuffer: Record "XML Buffer" temporary; Path: Text; Value: Text)
begin
end;

Additional context
local procedure ParseCreditMemo(EDocument: Record "E-Document"; var PurchaseHeader: Record "Purchase Header" temporary; var PurchaseLine: record "Purchase Line" temporary; var DocumentAttachment: Record "Document Attachment"; DocumentAttachmentData: Codeunit "Temp Blob"; var TempXMLBuffer: Record "XML Buffer" temporary)
var
	Base64Convert: Codeunit "Base64 Convert";
	OutStream: OutStream;
	InStream: InStream;
	Path, Value : Text;
begin
	Path := TempXMLBuffer.Path;
	Value := TempXMLBuffer.Value;
	case Path of
		.
		.
		.
		.
	end;
	OnAfterParseCreditMemo(EDocument, PurchaseHeader, PurchaseLine, DocumentAttachment, DocumentAttachmentData, TempXMLBuffer, Path, Value);
end;

[IntegrationEvent(false, false)]
internal procedure OnAfterParseCreditMemo(EDocument: Record "E-Document"; var PurchaseHeader: Record "Purchase Header" temporary; var PurchaseLine: Record "Purchase Line" temporary; var DocumentAttachment: Record "Document Attachment"; DocumentAttachmentData: Codeunit "Temp Blob"; var TempXMLBuffer: Record "XML Buffer" temporary; Path: Text; Value: Text)
begin
end;

Internal work item: AB#555759

@AmineAbdouli ping :)

The reason is to add the path value (AllowanceChargeReason) in a custom field within the imported document lines, as our partner requires this information to be included.
the paths :

'/CreditNote/cac:CreditNoteLine/cac:AllowanceCharge/cbc:AllowanceChargeReason'
'/Invoice/cac:InvoiceLine/cac:AllowanceCharge/cbc:AllowanceChargeReason'

Im curious. Why is CreateInvoiceAllowanceChargeLines not providing that for you?

@Groenbech96
because CreateInvoiceAllowanceChargeLines is currently saved in the description field in line while we need to get the item description in this field.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 27619.


Upgrade to to new React API

Breaking API changes in React in v0.14. Can be automated with https://github.com/facebook/react/blob/master/packages/react-codemod/README.md

@JedWatson Hey, would be very nice to have this merged :shipit:

Done, sorry for the delay!


Add A. Kondov's mergeSort JS implementation

Thank you for contributing to Algorithms/javascript, your pr got merged! ✨


⚠ Processors has degraded performance

In 1d9c3b7, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 115 ms

Resolved: Processors performance has improved in f776201.


Use a bellman::Proof instead of a byte array in Groth16Proof

Motivation
We use a byte array in the Groth16Proof struct. However, not every byte array is a well-formed proof (i.e. the encoding of three field elements, as enforced by the bellman package). For improved type safety, it would be better to use bellman::Proof inside it and parse the proof while parsing the transaction.
However, this requires a lot of code changes:

A lot of tests expect it to be a byte array
The tests vectors from https://github.com/zcash-hackworks/zcash-test-vectors/ generate random byte array as proofs. We'd need to change the test vector generators to generate random well-formed proofs.
In the same way, the Arbitrary implementation must be changed to generate random well-formed proofs.

For this reason, it was postponed for later.
Specifications

Designs

To generate a well-formed proof, you will need to generate 3 field elements: one in G1, second in G2, third in G1 again. See this snippet for reference: https://github.com/ZcashFoundation/zebra/blob/81727d7df0ee57e6d4f2172c287e52e414c4e6a0/zebra-consensus/src/transaction/tests.rs#L1956-L1960
Related Work

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn

Making this change would increase the cost of serving blocks to peers, because the proofs would be redundantly re-validated when deserializing from the database.
We're already having this performance problem with some curve types.
So I think it's ok for now.


ASIM Audit schema parser with its sample and test data for Barracuda …

Required items, please complete
Change(s):

Added ASIM Audit schema parser for Barracuda WAF

Reason for Change(s):

Initial version ASIM Audit Parser

Version Updated:

Initial version

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @jayeshprajapaticrest, please resolve branch conflicts. Thanks

Hi @jayeshprajapaticrest, please update your branch by taking the latest from master to resolve the conflicts. Thanks

Hi @jayeshprajapaticrest,
kql validations failed please see below screenshot for the same. Thanks

Hi @jayeshprajapaticrest, please act on validation failures. Thanks

@v-atulyadav Fixed.

Hi @jayeshprajapaticrest, please update your branch by taking the latest from master to resolve the conflicts. Thanks

Hi @jayeshprajapaticrest,
Thank you for accommodating the suggested changes! We will review the Pull Request internally and get back to you by shortly.


Duplicate cursor

Sometimes the app displays a duplicate cursor.  The "real" cursor is the one where insertions occur.  This only seems to happen when (a) window.start > 0 AND (b) window.start > 0 was achieved by pressing the Down scroll button.  It does not happen when window.start > 0 was achieved by pressing the down arrow key repeatedly.
Note added:  This is an issue only for lines == "\n"

Fixed using Window.identity


⚠ Bofrost.de has degraded performance

In 0ea65ee, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1980 ms

Resolved: Bofrost.de performance has improved in 7cb651e after 19 minutes.


Add Wido Zaps with support for more vaults

Description
Add Zap support for more vaults on Yearn.
Wido brings Zap support for:

yvCurve-ibAUD-USDC
yvCurve-ibGBP-USDC
yvCurve-ibCHF-USDC
yvCurve-ibJPY-USDC
yvCurve-ibKRW-USDC
yvCurve-ibBTC

With Zaps for more vaults to come later.
Related Issue
PR in yearn-finance-v3 https://github.com/yearn/yearn-finance-v3/pull/755
Motivation and Context
Zaps let users deposit any token into a vault instead of just the underlying token. That improves UX and increases deposits and TVL.
Data shows that Zaps contribute to 40% of deposits on Yearn. Having Zap support for all vaults will grow Yearn's overall TVL.
Report: https://twitter.com/widolabs/status/1574762471314915334
How Has This Been Tested?
It was tested locally with the front end running the yalc'ed SDK.
Left to do

[x] [Bug] Some zaps show expected slippage of 100.0% because priceUSDC is missing in supported tokens
[x] Supported Vaults — make an API call instead of hardcoding
[x] Unit tests
[x] Show “Approve” not “Sign” on Wido Zaps

Screenshots (if appropriate):

PR looks good overall :)
We should add a mechanism to dynamically switch precedence between different zap providers. So users of SDK can define the precedence of their choice if a vault is supported on multiple services. An idea could be setting a configuration on the SDK context, so this can be set when the SDK gets instantiated, and have a default if its not provided. Also that same mechanism would be useful to turn on/off a zap service provider (this can be done in separate PR though) for added privacy use cases.
something like:
export interface ContextValue {
  ...
  zaps?: {
    zapInWith: ZapInWith[];
    zapOutWith: ZapOutWith[];
  };
  ...
}

Where the first element in the array takes precedence over the next.
wdyt?

Makes sense. Can you take a look at c82cc69ca8570f3e86596933bfe74c652c35659e ?

With regards to deposit vs _deposit:
I audited _deposit and _withdraw and they correctly call the correct zap functions. E.g.: getDepositContractAddress and populateDepositTransaction are called, both of which are zap aware.
If we were to deprecate/remove deposit and withdraw we could also remove the functions zapInApprovalState, zapInApprovalTransaction, zapOutApprovalState and zapOutApprovalTransaction in both wido.ts and portals.ts, as they would not be used.


Add transparent and blur to PowerToys Run (search bar)

Description of the new feature / enhancement
I think the design of the search bar is good enough but if there is a little more transparency effect to sync with win 11 it would be great. Thank you for accepting my information.
Scenario when this would be used?

This increases the aesthetic of win 11
Synchronize the beauty of Windows 11

Supporting information
No response

/dup https://github.com/microsoft/PowerToys/issues/4794


PeerJ R3C6

in addition to thoughts on versions, has the journal developed a strategy on software forking, in particular by different developer teams to the original developers?

Not really but in theory I think we would consider a publication from a fork. This gets into the tricky territory of JOSS policing authorship (which is never going to be easy).
We might want to add a small paragraph mentioning that while a Git history (or similar) makes it easy to suggest people who should possibly/probably be authors, ultimately authorship is hard.

We could say that the list of contributors and list of authors is often not the same, and give examples of contributors who should not be authors (e.g.,  someone who modifies the license file) and non-contributors who should be authors (e.g., a member of the design team for the software)

OK, how about this as a new paragraph at the end of the discussion section?

The discussion about new software versions also generally applies to software forks, where software is copied and, after some divergent development, a new software package emerges.
Similar to how we handle new software versions, the \joss{} editorial board will consider publication of articles describing a fork if it includes substantial changes from a previously published version. However, while a version control history generally makes it easy to suggest people who should be authors, ultimately deciding on authorship is hard and project-dependent. We prefer to leave authorship decisions to the projects.

And the response:

We have added a short paragraph to page 17 describing how we might handle submissions of software forks. Ultimately, we prefer to leave authorship decisions to the developers, though this could become challenging for forks.

👍 LGTM. I did a small amount of word-smithing:

The discussion about new software versions also generally applies to software forks, where software is copied and, after some divergent development, a new software package emerges.
Similar to how we handle new software versions, the \joss{} editorial board will consider publication of articles describing a fork if it includes substantial changes from a previously published version.
Authorship questions may be more challenging when dealing with forks compared with new versions, since forks can retain varying amounts of code from the original projects.
However, while a version control history generally makes it easy to suggest people who should be authors, deciding on authorship can be difficult, subjective, and is therefore ultimately project-dependent. We prefer to leave authorship decisions to the projects.

suggestion:

The discussion about new software versions also generally applies to software forks, where software is copied and, after some divergent development, a new software package emerges.
Similarly to how we handle new software versions, the \joss{} editorial board will consider publication of an article describing a forked version of software if it includes substantial changes from a previously published version. Authorship questions may be more challenging when dealing with forks compared with new versions, since forks can retain varying amounts of code from their original projects. However, while a version control history generally makes it easy to suggest people who should be authors, deciding on authorship can be difficult, subjective, and is therefore ultimately project-dependent. We prefer to leave authorship decisions to the projects, with discussion taking place as needed with reviewers and editors.


feat: add email extra, issue/PR templates and version module

Add email extra to install pydantic[email] for EmailStr and NameEmail type support.
Remove extras from poetry install for docs and lint.
Add feud.version module for version information.
Add bug report and feature request issue templates.
Add PR template.

Pull Request Test Coverage Report for Build c7144c2a-27fa-422d-86f3-69d3ef00b2ba

2 of 11 (18.18%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.3%) to 95.173%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

feud/version.py
0
9
0.0%

Totals

Change from base Build e229290e-888b-44e1-8b3b-3ff33097a112:
-1.3%

Covered Lines:
1459

Relevant Lines:
1533

💛  - Coveralls


Add handling for node eligibility

Proposing a potential fix for #1204.
Looking for feedback before adding unit tests, etc.
The current code assumes that a couple of beta feature flags around are currently enabled by default.

/ok-to-test
thanks @MarcPow, I understand wanting to hold off on adding tests but it would be helpful to understand the change if you could add a couple test cases to demonstrate

/label tide/merge-method-squash

Thank you @MarcPow for this change, looks very thorough.
However, we are planning on introducing a NodeFitSpec that will give more flexibility as to what thing to check in order to identify eligible nodes.
Please see this comment on the Issue. What do you think?

I think we're all on the same page with respect to the need.   The original proposal was a good one, but I think it was made independent of / prior to the changes that happened in the podTopologySpreadConstraints spec that added more controls here.  At the point that those behaviors were added, I think the call on the descheduler is simply to behave just as the scheduler itself would when placing the pods in the first place.  An independent, separate policy has thus become unnecessary.


Ternary Operator in Generics issue

Bug Report
For more information, see the CONTRIBUTING guide.
Prerequisites

[x] Can you reproduce the problem in a MWE?
[x] Are you running the latest version?
[x] Did you perform a search in the issues?

Environment Details and Version
0.10.5
Description
While investigating the issues with the exports from deox, I noticed, that ternary operations in generics have an issue. Not sure if this is the only issue that causes deox types to fail, but it is probably a big part.
Steps to Reproduce
export type Ternary<T = undefined> = (T extends undefined ? {} : { ternary: T; });

Expected behavior
export type Ternary<T = undefined> = (T extends undefined ? {} : { ternary: T; });

Actual behavior
  export type Ternary<T = undefined> = ;

Possible Origin / Solution
The MWE has been adjusted to contain this: https://github.com/SantoJambit/shell-mwe.
Sidenote: I am aware, that this is not a MWE anymore, since it contains a lot of the issues with type declarations. I just wanted to keep it together, so it's easy to check if everything remains stable with the next version. I hope that's okay.

I just wanted to keep it together, so it's easy to check if everything remains stable with the next version. I hope that's okay.

It's fine.
Right now we do not support type guards in the declaration generation. We will need to see how to support them. Should be in 0.10.6.


Missing Service in v2.12.4

Hi,
I just updated to v2.12.4, and it broke my Symfony (4.4) security configuration:
Executing script cache:clear [KO]
 [KO]
Script cache:clear returned with error code 1
!!
!!  In CheckExceptionOnInvalidReferenceBehaviorPass.php line 86:
!!
!!    The service "security.authentication.provider.guard.api" has a dependency on a non-existent service "lexik_jwt_auth
!!    entication.jwt_token_authenticator".
!!
!!
!!
Script @auto-scripts was called via post-install-cmd

Downgrading to v2.12.3 resolved the above error message.

Hi, my bad. Just released v2.12.5, it should be ok now.


remove the context menu in output panel

resolution: https://github.com/gitkraken/vscode-gitlens/commit/7ad3b4677c3a330b93ea7bc10c6d5e2f3e7760ee

@tjx666,
I am sorry. I don see a way to remove context for a output panel. I just use editor/context in the package.json that adds the context also for the output panel. Please feel free to raise a PR if you could provide a solution for this.


Private Module Golang

I have module private on Golang inside my organization so dependabot not found it to validate.

my file:
version: 2
updates:

  # Maintain dependencies for GitHub Actions
  - package-ecosystem: "github-actions"
    directory: "/"
    schedule:
      # Check for updates managed by Composer once a week
      interval: "weekly"

  # Maintain dependencies for Golang
  - package-ecosystem: "gomod"
    directory: "/"
    schedule:
      # Check for updates managed by Composer once a week
      interval: "weekly"

The github native version of dependabot does not yet support private packages. We recommend to use dependabot.com in the meanwhile.
We do plan to support private registries / packages but don't have a timeline for where it will land currently.

The github native version of dependabot does not yet support private packages. We recommend to use dependabot.com in the meanwhile.
We do plan to support private registries / packages but don't have a timeline for where it will land currently.

Hi, @jurre thanks for explaining to me.
Can I help the project? I would like a lot that Dependabot having the support of private modules.
In Github Actions, I used this line
git config --global url."https://${{ secrets.GLOBAL_TOKEN<EMAIL_ADDRESS>"https://github.com/myorg"

Can I help the project?

Unfortunately not, the part that we still need to implement is not open source.

Can I help the project?

Unfortunately not, the part that we still need to implement is not open source.

Maybe, I did think some like this a parameter in YAML.
e.g
go_private: "https://github.com/myorg/project"

internal code it adds this var env
GOPRIVATE=go_private
etc...
What do think about it?

dependabot-core does support it, but our internal systems that run dependabot don't yet.
You can use https://dependabot.com for now and once we add support for it in the github native version I'll make sure to check back here

I would be also interested in this highly - having close to 20 big monorepos in go here:)

@jurre for me it would be sufficient even if dependabot skipped the modules that are private and just show updates for the public ones. Go mod fails completely even if one module is private and not in google's proxy.

Yeah I understand, eagerly waiting for this feature to land myself as well. I would recommend to use https://dependabot.com for now, we'll provide an easy upgrade path once the feature lands in github natively.

I would be also interested in this highly - having close to 20 big monorepos in go here:)

me too so here I have 7 big monorepos

Any update on this? Just ignoring private repositories would unblock many users from using it.

It would be wonderful if we could add other GO* variables. For example, we have internal code repos not in GitHub, and they get published to an externally available GOPROXY instance. But, we need to set a few, GOPROXY and GONOSUMDB.

+1 to even having private repos simply ignored as a workaround, instead of complete failure.

Ignoring a private dependency is unfortunately not an option, as we shell out to go get etc, and those fail if any of the dependencies can not be resolved.
This is definitely on our radar though, and I hope to be able to share more about it soon

If there would be an option to specify which are the private modules it should be possible to remove them from go.mod file and thus ignore them.

I'm fairly sure go mod tidy will fail in that case? I'm sure there is a way to do it, but I don't think it'll be trivial. Also, since we have limited capacity, we'd rather spend that time on supporting private packages properly. It's a priority for us in general so it's definitely coming.
I can see how having the option to completely ignore a dependency and also not provide access to it could also be useful, but currently I think we'd have to juggle around quite a few things around to make it work for go mod

And since we have limited capacity, we'd rather spend that time on supporting private packages properly. It's a priority for us in general so it's definitely coming.

Is there any update on a rough timeline, etc that this support might be available?

According to https://github.blog/changelog/2020-12-02-dependabot-version-updates-from-private-github-repositories/ and https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuration-options-for-dependency-updates#package-ecosystem it is now supported.

@torstenwalter I still dont think this would solve my use case. 😞
We have other modules that exist in and outside of GitHub (and outside of the same GitHub Org). To pull those, we set GOPROXY and GONOSUMDB to retrieve the modules to build.
Almost wondering if I should open a separate ticket just for GOPROXY / GONOSUMDB as this ticket is mostly focused on private repos within the same GitHub Organization. 🤔

@torstenwalter I still dont think this would solve my use case. 😞
We have other modules that exist in and outside of GitHub (and outside of the same GitHub Org). To pull those, we set GOPROXY and GONOSUMDB to retrieve the modules to build.
Almost wondering if I should open a separate ticket just for GOPROXY / GONOSUMDB as this ticket is mostly focused on private repos within the same GitHub Organization. 🤔

It's coming, but if you need this right now I'd recommend using dependabot-preview via https://dependabot.com

According to https://github.blog/changelog/2020-12-02-dependabot-version-updates-from-private-github-repositories/ and https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/configuration-options-for-dependency-updates#package-ecosystem it is now supported.

This is talking about private github repos, not private package repositories (such as private npm, artifactory, etc).

We just launched support for private registries in beta, so go nuts! Will close this issue, but let me know if there's anything else that needs to be done to make this feature awesome for y'all.


Error:Cannot change dependencies of configuration ':app:_debugAnnotationProcessor' after it has been resolved.

hello,
I got this issue when try to adding your library
are there any way to fix this issue
thanks

I've solved this issue by following this answer https://stackoverflow.com/questions/40809810/errorcannot-change-dependencies-of-configuration-app-debugannotationprocesso


ERROR when spawning : Unable to call parseURDF on robot model

Hi,
When I launch the command to spawn the rexrov, the rexrov is spawned with success " Spawn status: SpawnEntity: Successfully spawned entity" BUT at the other terminal (for launching gazebo world), I see that error : "[gzserver-2] Error [parser_urdf.cc:3183] Unable to call parseURDF on robot model".
Did you know what is the problem ?
Thank you
I am using Gazebo 11, ubuntu 20 and ros foxy.

Hi, I also met this question, have you solved it?

Hi, I also met this question, have you solved it? please tall me


I am able to configure documentation for Input/Output mappings

Related to process-level I/O mappings (https://github.com/camunda/camunda-modeler/issues/871) a user should be able to specify documentation with Input/Output mappings. This allows our users to parse and extract relevant meta-data from the mappings, i.e. to generate documentation or element templates.
Tasks

Input/Output mappings may define documentation (schema to be defined)

Related to SUPPORT-4652, CAM-9264

Implementing this feature as specified in CAM-9263 is on hold due to changed requirements.
We consider to add it as a modeler only feature some day in the future.

In the process level IO specification and documentation can be maintained via this plug-in.


Typescript: Split/Join some arrow functions results in invalid code

:wave:, thanks for building this plugin!
I found an issue when splitting or joining arrow functions in Typescript. The plugin seems to have trouble handing blocks without a return statement in the function body.
I have the following function
export async function pretendDelay() {
  const delay = Math.floor(Math.random() * 1000); // Between 0 and 1 seconds
  return new Promise((resolve) => {
    setTimeout(resolve, delay);
  });
}

Note that the setTimeout doesn't have a return.

When I try to join the arrow function inside the Promise, the plugin tries to return the value of the block (changing the semantics), and places an extra semicolon in the end (adding a syntax error).
If I try to revert back splitting the function, it now adds a return statement, and keeps the invalid semicolon.

https://github.com/Wansmer/treesj/assets/57448/7a916db5-3377-4585-be74-79b5cf474616

Done #133


Letter-spacing input update behavior is not consistent with other inputs

Bug Description
Letter-spacing input is live updated (and cannot be cleared).
All other fields require confirmation (enter, blur) to apply the value.
Expected Behaviour
Letter-spacing input should work as any other input does.
Steps to Reproduce

Screenshots

Additional Context

Plugin Version:
Operating System:
Browser:

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

@samitron7 @o-fernandez
Do we prefer live updates when you change field values? or do we prefer that you have to press enter or click out of the field to see the change?

For inputing values, pressing enter is the norm so let's not change that behavior. (Sliders though should be live preview)

This has been solved by #4608.


[WIP] Proposal for v2

Not sure about the layout, but I think the content is getting there?

Here's how it currently looks like :


Fix utils test

tests/services/utils.spec.ts

Hey @Sabrinovsky, can I work on this issue?

@aigerimmmm go on


ignore err in engine

The engine that loaded by dlopen may call ERR_PUT_error to save __FILE__ to ERR_STATE(Qat_engine does). The address of __FILE__ in engine is mapped while engine is loaded, but when we call dlclose to close DSO , the address of __FILE__ is unmapped, but it still exists in err_thread_local. So when we call ERR_print_errors to flush error to bio, segmentfault happens.
It's hard to restrict the third party to coding without ERR_PUT_error but we can discard the error.
Using RTLD_NODELETE  may become a solution on UNIX and FreeBSD, but not on other platform.

Surely the engine author want to put the specified error message when bind_engine works wrong.
What I have committed can keep at least the several errors in stack  instead of a segmention fault.
Also, I think it's not a good idea to keep a bad address in core code...
Further more, the engine should take the responsibility for logging the error message by another way.(Qat_engine use both)

I'm not trying to say this problem shouldn't get fixed, I'm just trying to see if the information could somehow get copied by ERR_PUT_error instead of having bad addresses.  It's possible that I'm over-reaching, but I prefer to ask the question rather than missing a possibility.

A quick survey of current engines shows:
gost - doesn't call ERR_PUT_error() from its bind function.
padlock - doesn't call ERR_PUT_error() from its bind function.
capi - doesn't call ERR_PUT_error() from its bind function.
afalg - does call ERR_PUT_error() from its bind function.
dasync - does call ERR_PUT_error() from its bind function.
Both afalg and dasync are relatively new engines added in OpenSSL 1.1.0.
@levitte do you think it is valid for an engine to call ERR_PUT_error() from the bind function?
I note the older engines tend to load the Error strings as the last thing they do within the bind function.

Hi @levitte, sorry to be a nuisance.
Did you have any thoughts on whether it is valid for an engine to call ERR_PUT_error() from its bind function in the first place?
I'm happy to change the QAT Engine to remove the calls to add errors to the stack in the bind if you think that we shouldn't be doing it.
If that were the case then the afalg and dasync engines will also need to change.
If you think it is okay to call ERR_PUT_error() in bind then do you have a solution better than proposed by @mrpre, or should he tidy up/submit a cla to continue this pull request?

Issue is that shared library (engine) is unloaded and as result of this there is no access to certain data.
I don't like idea to clear errors - information for failure may help us to identify issue(s).
Instead to clear all errors what about to stop unload of shared library on free, i.e. to set flag DSO_FLAG_NO_UNLOAD_ON_FREE?

I actually think that this is a question of references.  An engine won't be freed / unloaded unless all references are gone, i.e. the reference counter goes to 0.  So a "trick" would be to add a reference to that engine on the error stack, and "free" the engine (i.e. decrement its reference count and unload it if that count becomes zero) any time such a reference is popped from the stack.

Richard Levitte wrote:

I actually think that this is a question of references.  An engine won't be freed / unloaded unless all references are gone, i.e. the reference counter goes to 0.  So a "trick" would be to add a reference to that engine on the error stack, and "free" the engine (i.e. decrement its reference count and unload it if that count becomes zero) any time such a reference is popped from the stack.

One of proposed modification is in following code :
...........

Try to bind the ENGINE onto our own ENGINE structure */
if (!ctx->bind_engine(e, ctx->engine_id, &fns)) {

ERR_clear_error();
ctx->bind_engine = NULL;
ctx->v_check = NULL;
DSO_free(ctx->dynamic_dso);
...........

There is no check for references - bind fail and module is unloaded by
DSO_free.
My idea was instead to clear errors, to set respective flag before
DSO_free.
Regards,
Roumen Petrov

Outside of the CLA issues, this appears to also be a bug in 1.1.0.  Removing the 1.1.1 milestone.

This PR has the label 'hold: cla required' and is stale: it has not been updated in 616 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

This PR has the label 'hold: cla required' and is stale: it has not been updated in 647 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

This PR has the label 'hold: cla required' and is stale: it has not been updated in 678 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

This PR has the label 'hold: cla required' and is stale: it has not been updated in 709 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

This PR has been closed because it has been stalled for some time due to the lack of a CLA.  If you are able to supply a CLA please reopen this PR.  For CLA help see https://www.openssl.org/policies/cla.html


v2.6.6 breaks it on windows platform!

Works fine with v2.6.5 but with v2.6.6 windows platform throws 'Missing Command Error' when trying to create the secure storage...

Nothing has changed afaik for windows in the last release. Could you please debug and figure it out, I don't have a windows machine available atm.

This breaks it: https://github.com/Crypho/cordova-plugin-secure-storage/commit/006e1ac35c15dc601616d328be558005b570f165#diff-58ee91177abb530230d402dc2de60904L79
The reason is that windows is reusing the iOS stuff:
// SecureStorage for Windows web interface and proxy parameters are the same as on iOS
// so we don't create own definition for Windows and simply re-use iOS
SecureStorageWindows = SecureStorageiOS;

Ops yes you are right. Could you please override the constructor for windows so that it is as it used to be i.e. invoke success inside a setTimeout, run the tests on windows and make a PR?

Trying to add the tests as shown in the readme results in 'Error: Registry returned 404 for GET on https://registry.npmjs.org/myapp'


Download text file

Given the ID, i get a success result but converting the content from byte[] to string gives me a strange string everytime ?
Can i simply know how to exactly get a text file with Unity ?
I managed to upload successfully.
Thanks !

Hey, check the readme and test scripts for examples.

Hey, check the readme and test scripts for examples.


[WIP] enable containerized microshift on MacOS

I have built a container docker.io/rootfs/ushift:macos for testing

Could we replace the CNI spec version to the latest?
sudo sed -i 's/0.3.1/0.4.0/' /etc/cni/net.d/100-crio-bridge.conf
Just to keep in sync with what the install script does.

Could we replace the CNI spec version to the latest?
sudo sed -i 's/0.3.1/0.4.0/' /etc/cni/net.d/100-crio-bridge.conf
Just to keep in sync with what the install script does.

thanks, fixed


Provide a more performant SpinLockDelay implementation on Windows 8.0 on newer

Issue: https://github.com/gperftools/gperftools/issues/1333
This PR provides a more performant SpinLockDelay implementation on Windows 8.0 or newer based on WaitOnAddress and friends.
WaitOnAddress is roughly equivalent to Linux's futex, which is what TCMalloc is currently using on that platform.
There was a previous PR attempt https://github.com/gperftools/gperftools/pull/1350.
This PR addresses a comment to maintain support for Windows 7 or older.
That comment is addressed here by checking _WIN32_WINNT during build time.
The TCMalloc user can opt out of this change by using an older version of the Windows SDK or by specifying _WIN32_WINNT to an older value.

This is great. Thanks!
Couple things. Can you please squash commits into 1 single commit?
That stuff about auto wait_{ms,ns} assigned result of uint64_ times "ull" constant is sufficiently head-scratching IMHO. Can you please make types explicit. And perhaps drop ull?
Also that you're having to duplicate very odd/arbitrary logic from linux futex codes is worth a think. No big deal, but if you have time consider refactoring this more to unify the logic (if not, fine, I'll handle myself eventually).
Also consider checking what abseil is doing (they might use similar patch or maybe you can steal some ideas from there).
Thanks again!
P.S. Since last time waitonaddress was proposed pretty much everyone dropped support for windows 7. I just checked. But I think keeping ifdef might be needed if msvc defaults continue to be older windows SDKs (I have no idea). But just in case. We could and perhaps should consider just doing windows 8 or even windows 10 or later if that simplifies anything.

BTW, ms's own c++ library does the both compile time ifdef thingy and runtime thingy: https://github.com/microsoft/STL/blob/8f67ece4a654625220642c92fa029a5cfc77afa8/stl/src/atomic_wait.cpp#L227 (for c++20 atomic futex-like ops).
Just pointing this out. Please don't consider adding anywhere as much complexity as over there. If we can somehow simplify and hard-depend on newer API, I recommend doing that.

Merged into PR https://github.com/gperftools/gperftools/pull/1439 as requested.


fix(common): compatibility issue with latest firebase version

@alexluong would it be possible to merge this to support the latest Firebase version?


Catch event on 'Load Layer Start' and on 'Load Layer End'

Is there anyway to catch the event 'imageloadstart' and 'imageloadend'? I need it to place a spinner while loading wms layers....
Thanks in advance,

Injecting the service named olData in your controller you will be able to access the OpenLayers map and so it should be possible to get the layers and so on:
olData.getMap().then( function(map) {
  // Do whatever you want with the map
});

Yeah, after some hours fighting, I found a way to catch the events from WMS layers:
OlData.getMap().then(function (map) {
                map.getLayers().on('change:length', function (e) {
                    e.target.forEach(function (capa) {
                        if (capa instanceof ol.layer.Image) {
                            var source = capa.getSource();

                            source.on('imageloadstart', function () {
                                ///do whatever you want
                            });
                            source.on('imageloadend', function () {
                                ///do whatever you want
                            });
                            source.on('imageloaderror', function () {
                                ///do whatever you want
                            });
                        }
                    });
                });
            });

Hope it helps someone,


Test reading from empty kafka/kinesis partitions

Add tests for reading from empty kafka/kinesis partitions
Description
Add tests for reading from empty kafka/kinesis partitions. The new tests discovers that Kafka is working fine when reading from empty kafka partitions, and thus, supervisor shows healthy and tasks are running without failing when one or more partition is empty (as tested in KafkaRecordSupplierTest.java). However, Kinesis supervisor is showing unhealthy and task are not running when one or more partition is empty. This should be fix in a separate PR and subsequently these tests for Kinesis will have to be modify.
Note that there is no problem when index task is running and polling from kafka/kinesis stream with one or more empty shards (as tested in KafkaIndexTaskTest.java and KinesisIndexTaskTest.java). The problem for Kinesis described above is when we try to get the sequence number in SeekableStreamSupervisor#getOffsetFromStorageForPartition and Kinesis has one or more empty shard (as tested in KinesisRecordSupplierTest.java and SeekableStreamSupervisorStateTest.java). More specifically, this happens for the following conditions:

we don't have a startingOffset (first run or we had some previous failures and reset the sequences) and don't have offset in metadata store so we retrieve the latest or earliest Kinesis sequence
we don't have a startingOffset (first run or we had some previous failures and reset the sequences) and we have offset in metadata store but skipSequenceNumberAvailabilityCheck=False

This PR has:

[x] been self-reviewed.
[ ] added documentation for new or modified features or behaviors.
[ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
[ ] added or updated version, license, or notice information in licenses.yaml
[ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
[x] added unit tests or modified existing tests to cover new code paths.
[ ] added integration tests.
[ ] been tested in a test Druid cluster.

However, Kinesis supervisor is showing unhealthy and task are not running when one or more partition is empty. This should be fix in a separate PR and subsequently these tests for Kinesis will have to be modify.

Can you please open an issue about it on Github?

https://github.com/apache/druid/issues/9763


Create a playbook for setting up local registry

Add support to configure the local registry on the bastion node.

Closing this as the feature will be added to [RedHatOfficial/ocp4-helpernode](https://github.com/RedHatOfficial/ocp4-helpernode Devel Code


Please invite me to the Recode-Hive GitHub Community Organization

Name
Lahari Polkam
Discord Username (if applicable)
Lahari-polkam
Additional Context
No response

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/Recode-Hive/people


Include templatags or something like this in editor

Hi,
I try to include a templatetags or an include tag in the admin editor widget but i can't, i think its normal that's a different lvl than the templates, so i try to find some advice about my need.
Context :
My users will edit content of pages in the admin interface with ckeditor.
I have make a templatetags for include a picture gallery very easily, at list i have just to put something like {% gallery %} and its good.
For the moment the best way i have find is this :

When the content will show i have a templates for exemple with this

{{ article.description | safe }}
and the content edited by the user with ckeditor is show

So if they need to put a picture gallery they will open the template, delete this line {{ article.description | safe }} , copy past source code from the ckeditor admin editor and include the templatetags where they want.
This is not very difficult but if i can not oblige them to manipulate html will better^^, but don't find a way for do this.

Hope im clear
Thanks for your advice.

I think you should probably look into something more structured than a rich text editor if you need advanced functionality such as this. Sorry for the plug but I really think you should take a look at http://django-content-editor.readthedocs.io/en/latest/


Unable to edit imports section in Dictionary settings

Logged in as admin, created a new Dictionary, edited description and words but can't add imports.

Duplicate of #1312 fixed in v6.0.16


[utils] Added deep_merge_dicts

See https://github.com/openwisp/openwisp-notifications/pull/19#discussion_r428313884

Coverage increased (+0.01%) to 99.415% when pulling fdc48e89d3cd7d632bd97c269c76fa872d570ebf on pandafy:merge-dict into ea7f7a6743e4b060abedb3830c7e1751383c3b4d on openwisp:master.

@pandafy it would be nice to know what this change does, could you please share where can this function be useful? :smile:

The function recursively merges two dictionaries. It was getting used in openwisp-notifications (but not any more) and openwisp-monitoring. It is helpful for updating default configurations defined using dict.
The idea was to remove repetition across OpenWISP modules. :smile:


KMP-3232: Server-to-Server OAuth support

For now the gem supports only OAuth and JWT authorization. This PR adds Server-to-Server OAuth option.

@Tekkon We need to switch to our version in the Gemfile as well, right?