if .vscode folder doesn't exist, the tasks.json won't be created when running "Run and Debug"

VSCode Version: 1.49.0-insider
OS Version: Win64

Steps to Reproduce:

Delete .vscode folder from the project folder
go to "Run and Debug"

Continue to select an environment and select a configuration
The launch.json file will be created,
But the tasks.json that needs to include the preLaunchTask won't be created.

Now delete all files from .vscode folder, but keep the folder
Follow steps 2 and 3
Both launch.json and tasks.json will be created.

Yes, we do not automatically create a tasks.json file. I guess this is a fair feature request.
@alexr00 is there API to create tasks.json so that the C++ extnesion could do it. Or is there internal api for this?

From extension API, the only way to modify tasks.json is with the configuration API:
https://github.com/microsoft/vscode/blob/42226a9169340756897e12b65045c721af9f860b/src/vs/vscode.d.ts#L4826-L4826
For internal API, if you know the task you want to write then you can use customize
https://github.com/microsoft/vscode/blob/76b7d047188f05062c29170376511831098952f7/src/vs/workbench/contrib/tasks/common/taskService.ts#L92-L92
However, a tasks.json isn't required for the prelaunch task. If the prelaunch task already exists as an extension contributed task, then the tasks.json would only be needed if the user wanted to modify that task.

So this sounds like this should be handled by the C++ extension...

I agree that this should be handled by the C++ extension. The provider of the launch configuration is the only one who knows whether the task needs additional configuration to make a good prelaunch task.


Update chirp-daily to latest version 20170324

See issue #31331 for explanation

Welcome @sww1235.
Next time, please fill the template, or at least leave it. It’s there for a reason.

@vitorgalvao Sorry about that.

All tests passing. Thank you for the contribution.


zxing gstreamer plugin available

Here is a zxing plugin for GStreamer > 1.17.
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/743
https://gitlab.freedesktop.org/gstreamer/cerbero/merge_requests/287

Thanks for spreading the word and letting us know! :). How is it going with your plugin, any success stories?
Since there seems to be nothing to be done here from our side, we can close the issue, right?

except my pet project, nothing more but I hope it can help to spread your job.
Yes we can close the issue.


⚠ Cioos National CKAN Sitemap has degraded performance

In 0448621, Cioos National CKAN Sitemap (https://catalogue.cioos.ca/sitemap/sitemap-1.xml) experienced degraded performance:

HTTP code: 200
Response time: 15363 ms

Resolved: Cioos National CKAN Sitemap performance has improved in 75c6755 after 4 minutes.


Moved: Xiaomi.MIUI+ version <IP_ADDRESS>3

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[ ] Have you tested your manifest locally with winget install --manifest <path>?
[x] Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot waivers Add Validation-Domain


Update use of deprecated range field in UserDefinedType and QsTypeParameter

Follow up from #917 to update usages of now-deprecated UserDefinedType.Range and QsTypeParameter.Range:

Add TypeIdRange field to QsAttributeDeclaration.
Make TypeTransformationBase.OnType virtual so that IdentifierReferences has access to both the UDT record and ResolvedType.Range at the same time.

Annoyingly, I think the build failures for QIR in this PR are a result of out of sync commits in the e2e pipeline. It's completely unrelated to the changes here. I'll investigate and see if I can get that unblocked here.

@swernli I think it should already be fixed since I merged main into feature/qep2 in runtime, but I haven't re-run the builds here.


Update contract licenses to MIT

What is this PR doing?

Update SPDX-License-Identifier contract license metadata from Unlicense to MIT for consistency with rest of repo.
No other non-MIT license references were discovered

How can these changes be manually tested?
:eyes: , :judge:
Does this PR resolve or contribute to any issues?
Resolves https://github.com/getwax/bls-wallet/issues/607
Checklist
~I have manually tested these changes~ No testing needed

[x] Post a link to the PR in the group chat

Guidelines

If your PR is not ready, mark it as a draft
The resolve conversation button is for reviewers, not authors

(But add a 'done' comment or similar)

Updating the SPDX-License-Identifier appears to have changed the contract bytecode. This will have conflicts with https://github.com/getwax/bls-wallet/pull/606/ depending on which goes in first (deps.ts, package.jsons, etc.)

@JohnGuilding That clients version was pinned to an experimental release in main when I started this work. It doesn't seem to be causing any harm so I rolled with it.
When we pin v1, we can set it back to a non-experimental semver.


persist ui settings

Add a section in the user settings page to persist some UI settings

[x] show followingo on global posts
[ ] show nsfw content

See https://nakama.social/posts/ff5fdcc2-bd83-4a48-9b36-d2b54eb60cbe

Done


Various small improvements

There is a button to add a new Agent directly in a Scenario
Deleting an Agent from its show page no longer 404s
There is a button to destroy all delayed_jobs

Code review appreciated @dsander or @knu!

@cantino Looks great, but I think the 404 bug was introduced by me and I know how to fix it.  If my line notes above do not apply, you can just merge this and then I'll follow up with an alternative fix later.

Thanks @knu, I made your changes and tested that they work.  Everything else look good?

@cantino Yes!


Drop support for converting unqualified keys

E.g. in a pure Clojure/Cljs/Datomic stack this might not be necessary. For others, metosin/spec-tools transformers might be a better option.

[ ] Create constructors for entities

Change the map->entity function to be used in an explicit make-xxx constructor to be defined by library users

[ ] Make creation-date and modified-date entity specs
[ ] Create default ids and dates
[ ] Pass default values to map->entity and merge them in


Add dominosa

(It does seem like the main screen can only show 16 puzzles at a time, with no way to go to a next page.)

Okay, switched to a 5x5 grid fixed this. This may lead to problems where we would eventually need a 7x6 grid to fit all the puzzles.

I also added loopy.

5x5 seems reasonable to me!
Would you mind editing those help files to use "long press" instead of "right-click"? It looks like with the other help files I left "click" as is instead of using with "press" or "tap", so that part is fine.

Okay, a few things:

Updated help files.
I added configs for magnets and signpost.
I was thinking about unequal, and wondering how hard it would be to use handwriting recognition for entering the numbers (like in the remarkable crossword puzzle package), and thoughts on that?

Awesome! Mind doing the same for the magnets and signpost help files?
I'll take a look at the new puzzles on my remarkable sometime soon, but how does the signpost ending animation end up looking?

I was thinking about unequal, and wondering how hard it would be to use handwriting recognition for entering the numbers (like in the remarkable crossword puzzle package), and thoughts on that?

This was certainly a long-term goal of mine, and part of why I never added any of the number puzzles. IMO recrossable's recognition is pretty bad, but just numbers would be a whole heck of a lot easier than a full alphabet, especially given the MNIST data set. I wouldn't be surprised if there's a decent smallish C library for number recognition already.

Awesome! Mind doing the same for the magnets and signpost help files?

Oh, woops, I missed left-drag and left-click. Good catch. I'll fix that momentarily.

I'll take a look at the new puzzles on my remarkable sometime soon, but how does the signpost ending animation end up looking?

This was certainly a long-term goal of mine, and part of why I never added any of the number puzzles. IMO recrossable's recognition is pretty bad, but just numbers would be a whole heck of a lot easier than a full alphabet, especially given the MNIST data set. I wouldn't be surprised if there's a decent smallish C library for number recognition already.

Good point. I'm mostly just not sure how to overlay a drawing context on the puzzle rendering code. Would you mind pointing to where it is?

Sorry, I might be a little slow to respond this week, but I did have a chance to test this out. A few notes:

The 5x5 grid feels a bit cramped. Ultimately I'd like to go with two pages and next/back buttons. 5x5 is ok, but if we go with that I think we want to make the icons smaller.
iirc I left signpost our because of the weird polygon drawing issues. It's playable, so might as well leave it in, but it would be nice to fix that at some point.
Some of the help files have html entities that we should replace with a similar ascii character (e.g. x instead of ×). Some also reference colors that would be good to replace with "gray" or "shaded" or something to distinguish the colors.
This isn't essential, but some puzzles gave a one-word hint as to what the controls do. Here's an example.

I'm mostly just not sure how to overlay a drawing context on the puzzle rendering code. Would you mind pointing to where it is?

ui::Canvas has a vector of Layers, so the idea would be to add another layer that's used for drawing. I never got around to making that work though, so it could be a bit of work to get drawing to happen.


Migrate to XGBoost mainline repository

@RAMitchell (an xgboost maintainer) was mentioning that it might be possible to migrate the whole of the dask-xgboost codebase into xgboost itself.
Any thoughts or concerns about this?
I think that the proposed API change would be to add a dask_client= keyword (or something similar) to the official train and predict methods.

No objections here, though I think the CI is failing with the latest xgboost. I have a half-written tutorial copying https://xgboost.readthedocs.io/en/latest/jvm/xgboost4j_spark_tutorial.html. I’ll try to finish that up in a couple weeks.

Someone should verify that this code with license (BSD 3-clause) can be absorbed into and under their license (ASF 2.0) without changes.
I expect this is fine as BSD-3-clause is permissive, but best make sure they have checked before they accept the code, that no relicensing is required.

As xgboost now has native Dask support in mainline ( https://github.com/dmlc/xgboost/pull/4473 ), what would like to do with this repo?

At least update the readme, possible add a warning on import.

On May 29, 2019, at 11:22, jakirkham<EMAIL_ADDRESS>wrote:
As xgboost now has native Dask support in mainline ( dmlc/xgboost#4473 ), what would like to do with this repo?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Will want to wait until there’s an XGBoost release though.

On May 29, 2019, at 11:22, jakirkham<EMAIL_ADDRESS>wrote:
As xgboost now has native Dask support in mainline ( dmlc/xgboost#4473 ), what would like to do with this repo?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

That sounds reasonable. How do we handle new issues that are reported here?

Just to be clear, the solution in XGBoost is quite a bit different than
what is implemented in this repository.  Folks may want to familiarize
themselves with their solution before deprecating this repository entirely.
On Fri, May 31, 2019 at 9:47 AM jakirkham<EMAIL_ADDRESS>wrote:

That sounds reasonable. How do we handle new issues that are reported here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-xgboost/issues/39?email_source=notifications&email_token=AACKZTB2OAIN5DZCBFXTDLTPYFJCPA5CNFSM4HJ7HKPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWVYQ5Q#issuecomment-497780854,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACKZTAEGDR6ZNEDJRX7UFTPYFJCPANCNFSM4HJ7HKPA
.

@mrocklin Could you please elaborate a bit on how the implementation in this repository is different from the one included in dmlc/xgboost? And if you have some more time on what circumstances this one could be preferred?

I don't know the other implementation particularly well.  I recommend
reading their docs to get a more authoritative perspective.
https://xgboost.readthedocs.io/en/latest/python/python_api.html#module-xgboost.dask
On Tue, Jun 18, 2019 at 5:39 PM ksangeek<EMAIL_ADDRESS>wrote:

@mrocklin https://github.com/mrocklin Could you please elaborate a bit
on how the implementation in this repository is different from the one
included in dmlc/xgboost? And if you have some more time on what
circumstances this one could be preferred?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-xgboost/issues/39?email_source=notifications&email_token=AACKZTGHKLYOJYJCFTNHSL3P3D6RJA5CNFSM4HJ7HKPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX7BT6Y#issuecomment-503192059,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACKZTBTMTY4J6YR4ETU6C3P3D6RJANCNFSM4HJ7HKPA
.

@ksangeek See demos here: https://github.com/dmlc/xgboost/tree/master/demo/dask
The xgboost dask integration is currently slightly more low-level than what is here. We are currently considering if we can extend the API to provide more high level functionality currently available in dask-xgboost without duplicating existing xgboost APIs. If this can be achieved we should be able to definitively move users from dask-xgboost to native xgboost integration and deprecate this without loss of user experience.

Thank you @mrocklin and @RAMitchell for the useful information.

Has this been thought about further? There's functionality in this library that I'd like to implement that's already been done in dmlc/xgboost's native dask integration

From what I understand, the implementation in xgboost is closer to what we have here now.
Personally, I'd like to see this handled within xgboost itself, to reduce the maintenance load here :)
Are there any features within dask-xgboost not handled within xgboost itself?

the implementation in xgboost is closer to what we have here now.
I've been bouncing around the two codebases in the past few weeks, their implementation is extremely similar to what's in this repo, but supports more features in the underlying xgboost library

Are there any features within dask-xgboost not handled within xgboost itself
Nope. The peers that I work with are requesting features for this library that have already been implemented in the native xgboost dask implementation

This topic came up in the monthly Dask meeting today. On the call @kylejn27 repeated that dmlc/xgboost handles everything dask-xgboost handles and more. If that is the case then maintaining dask-xgboost is wasted effort.
XGBoost hasn't made a release since the refactored dask handling went in. So we'll need to wait until their next release before making any concrete decisions. But my preference is to gather feedback from users (here and from followers of the dask_dev Twitter account) on whether the implementation in dmlc/xgboost suffices after the next release. If so, then we'll archive this repository and direct people there.

FYI, I am currently working on the upcoming release for XGBoost (1.0.0). ETA is tomorrow (2/19).

@mmccarty @kylejn27 @gforsyth, would it be possible to get a summary of the current outstanding issues for migrating to xgboost for Dask usage?
cc @JohnZed (for vis)

On a different note, there is currently an RC for xgboost 1.2.0. Would be great if people can try and share feedback here ( https://github.com/dmlc/xgboost/issues/5970 ).

Please loop me in to related issues around migration.

This are the issues that I'm aware of

dmlc/xgboost#5765
dmlc/xgboost#5619
dmlc/xgboost#5495

Now that release 1.3.0 is out (congrats!!!) and it includes fixes for all the issues in https://github.com/dask/dask-xgboost/issues/39#issuecomment-681974273, can this be closed?

Now that release 1.3.0 is out (congrats!!!) and it includes fixes for all the issues in #39 (comment), can this be closed?

@mmccarty? 🙂

Yes! Let's close this issue. Thank you everyone for the hard work!


04 21 2023  as azure ad enable user

Change(s):

New Playbook
Because the playbook is meant to be used with a playbook we put out previously, documentation has been updated in this other playbook so that each can reference one another
Update to our company name

Reason for Change(s):

See above

Testing Completed:

Yes

Hi @manishkumar1991 @rahul0216,
Please provide your feedback
Thanks

Hi @manishkumar1991, @rahul0216, can you please look into this PR?

Hi @manishkumar1991, @rahul0216, can you please look into this PR?

Reviewing


Add documentation for Editors about shareable link

LGTM

hi @bhavi25, can you provide the link so we move this to acceptance?

@meols  Documentation for sharable preview link can be found here :
https://web-global-development-equinor-web-sites-dev.c2.radix.equinor.com/editorial-documentation/using-the-sanity-studio

Thanks @bhavi25


unix: spawn should protect its input fds

spawn allows copying descriptor numbers during exec, but it wasn't
protecting them. Under some conditions, such as swapping stdout and
stderr, it would do this:
dup 2 -> 1
dup 1 -> 2
With end result that both 1 and 2 would be stderr, rather than being
swapped.
With this change, the above sequence gets rewritten to:
dup 1 -> 3
dup 2 -> 1
dup 3 -> 2
This fix can be verified against io.js. Using fd-dup.js:
var cp = require('child_process');
var fs = require('fs');

if (process.env.CHILD) {
  console.log('STDOUT');
  console.error('STDERR');
  return;
}

var options = {
  stdio: [0, 2, 1],
  env: { CHILD: true },
};
var c = cp.spawn(process.execPath, [__filename], options);

Without this patch both fd 1 and 2 in child end up in parent's stderr:
% ./iojs fd-dup.js 1>_1.txt 2>_2.txt; more _*.txt|cat
::::::::::::::
_1.txt
::::::::::::::
::::::::::::::
_2.txt
::::::::::::::
STDOUT
STDERR

(Above assumes an io.js that has libuv bug #224 fixed, otherwise it will output nothing, because fd 2 will be closed).
After this patch, they are swapped, as intended:
% ./iojs fd-dup.js 1>_1.txt 2>_2.txt; more _*.txt|cat
::::::::::::::
_1.txt
::::::::::::::
STDERR
::::::::::::::
_2.txt
::::::::::::::
STDOUT

/to @indutny, this fixes https://github.com/joyent/libuv/issues/1084

I'm not sure it works in all Unices, but how about using this to get duplicated fds beyond stdio_count?
new_fd = fcntl (use_fd, F_DUPFD, stdio_count);

It's simpler, assuming it works in all platforms we need it.

Also, a test! :-)

F_DUPFD fcntl: I wasn't aware of that fcntl. It looks perfect. I see it on Linux and OS X's man pages, but no idea how wide-spread it is. I could do an #ifdef F_DUPFD... but then I would be maintaining two copies of the same code.
I considered changing the dup2() to be something like:
int dupAbove(int fd, int above) {
  int copy;
  while((copy = dup(fd)) < above && copy != -1)
    ;
  return copy;
}

Basically, repeatedly calling dup() until the result is > use_fd. That loop would normally never run more than once, so have zero-overhead in the normal case. It might be the best "portable" alternative to F_DUPFD.
What to do, rewrite to the "portable" F_DUPFD, or just use F_DUPFD, and see if builds fail anywhere?
As for tests, I'm sorry, but I can find no tests for spawn-with-stdio at all, anywhere in uv, that I can use as a base to add this case to. Did I fail to find the right code?
Writing spawn() tests from scratch seems like it would take days (that I won't have in the next weeks).
Can you point me to a test I can use as a base? Or do you have any ideas how to write the test?

AFAIS, F_DUPFD is part of POSIX (http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html) so we should be fine going that road. If any of the supported platforms doesn't have it (which I doubt) we can reconsider.
As for tests, spawn_stdout uses a spawn_helper2 process which just prints something. You could use it as a base and make it print to both stdout and stderr, which are redirected to 2 files, then synchronously read and compare the content.

OK, @saghul I'll rewrite to use F_DUPFD, and take a shot at a test.

@sam-github will you have time to work on this? If possible it would be nice to include it on the next release. The test can probably be written similar to #224.
I can try to finish it if you're short on time.

#309 landed, closing!


week_1 Assignment

Hey @arunac535 , looks like you have not committed your HTML files

Could you tell if the html file is uploaded now?
On Sat, 31 Dec 2022 at 10:16, Hrushikesh @.***> wrote:

Hey @arunac535 https://github.com/arunac535 , looks like you have not
committed your HTML files
—
Reply to this email directly, view it on GitHub
https://github.com/IRIS-NITK/IRIS-RoR-Bootcamp-2022/pull/67#issuecomment-1368164149,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXF6FP2GC5TQWNZ5ULTLX6DWP63CZANCNFSM6AAAAAATMEUB44
.
You are receiving this because you were mentioned.Message ID:
@.***>


Support new raster colorization in Mapnik trunk

Just got word of this work a few moments ago: https://github.com/BenMoores/mapnik-trunk/wiki/RasterColorizer. It should land in trunk next week. Ben is also going to be updating Cascadenik to work with this, so we should have tmcw or kkaefer work in lock step or even bounce ideas off with ben.

Okay, first chunk of work in https://github.com/mapbox/carto/commit/1dcafcc
You can see the style of attributes I'm trying out here: http://ds.io/rWUjcn . I think it's pretty compact, but there's still a lot to do

This relies on collapsing RasterColorizer's element in RasterSymbolizer in Mapnik
It's brittle: if you add commas to the definition, it breaks.
reference.json describes the fact that it takes 'tags', but doesn't go farther, and I don't know whether we really want to invent that syntax.


propertyIsModel attribute added for em-select

#73 #72
new attribute for {{em-select}}

propertyIsModel : will bind to the model in the collection instead of the value.

            {{em-select
            label="Employee"
            property="employee"
            propertyIsModel=true
            content=employees
            optionValuePath="content.id"
            optionLabelPath="content.name"
            disabled=false
            prompt="Please Select"
            }}

Now the employee object will bind to the actual employee model not the id.

This patch works fine, solved my issue with selecting multiple values. I think it should be merged.

Pushed.


Netty Loom Adapt

reactor thread model based on virtual thread adaptation to netty

JNI is sometimes involved in low-level network operations for performance optimization purposes but it does not directly cause thread pinning. Netty's event loops are designed to handle I/O events and tasks efficiently, using non-blocking I/O and event-driven programming model to minimize thread blocking.
The "pinning" concept you might be referring to could mean whether a thread stays dedicated to specific tasks or gets stuck handling certain operations. In Netty, each event loop thread handles I/O events for its own set of channels and does not generally get blocked on these operations if they are implemented correctly as non-blocking (as most Netty components are).
However, if there is a bug or misuse of Netty where a JNI call is made in a way that causes a thread to block indefinitely, then yes, it could effectively "pin" that thread. But this would be an implementation issue rather than a characteristic of Netty itself.
The createBossGroup method returns an event loop thread group. The bossGroup is responsible for maintaining the long link between the client and server. It usually does not require too many threads because of the internal multiplexing mechanism and I have modified the thread group to be a virtual thread group Can NettyEventLoopFactory. EventLoopGroup view the virtual thread has not need to specify the initialize the number of threads when a thread pool Because virtual thread context switching is lightweight Completely controlled by the JVM initialize a thread takes less memory, I have integrated virtual threads for jdk21 into my rpc framework and have used them online
---Original---
From: "Albumen @.>
Date: Mon, Mar 11, 2024 10:16 AM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [apache/dubbo] Netty Loom Adapt (PR #13857)
@AlbumenJ requested changes on this pull request.
In dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/NettyServer.java:
> @@ -153,13 +153,17 @@ private boolean isSupportMetrics() {      }        protected EventLoopGroup createBossGroup() { -        return NettyEventLoopFactory.eventLoopGroup(1, EVENT_LOOP_BOSS_POOL_NAME); +        return NettyEventLoopFactory.eventLoopGroup(true,1, EVENT_LOOP_BOSS_POOL_NAME);
I am concerned about whether netty will pin the thread due to jni.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Meta ticket for various minor visualization issues

[ ] Key Consolidation - Seen in the key usage for the lane selection functionality, there is close relationship between the keys used for both mesh storage, and the key creation for mesh value location.  The three files which they are utilized in are maliput_viewer_widget.hh/cc, layer_selection_widget.hh/cc, and generate_obj.hh/cc within maliput.  These keys need to be consolidated and put in one location.
[ ] Z Prioritization for Selected Lanes - Upon a lane being selected, if there happens to be an overlapping lane and the user clicks on the overlapping section, the lane that wasn't selected will be selected.  There needs to be a prioritization for the selected lane to be deselected when the user clicks an area in which the lanes overlap.
[ ] Mesh Checkbox Inconsistency Upon Initialization - If the user clicks the mesh check boxes on the right hand side before loading a road geometry and then proceeds to load a road geometry, then the meshes will not be loaded in accordance with the check box values - they all will still load in as if they should all be visualized.  When the user proceeds to click around or toggle check boxes, the visualizer will behave correctly.  This isn't a super urgent task, but would fix a minor bug.

Closing as application changed a lot since this ticket was filled. See https://github.com/maliput/maliput_viz


Documentation for listing shared network printers.

Listing the shared files is cut and dry, but how do you list the shared printer names of a given computer?
Also asked here:
https://github.com/PyFilesystem/pyfilesystem2/issues/358

See my answer in the other issue :wink:
You probably want a low-level SAMBA/SMB library to do this. Please check pysmb.

See my answer in the other issue wink
You probably want a low-level SAMBA/SMB library to do this. Please check pysmb.

I have this working with pysmbc (https://github.com/hamano/pysmbc/pull/38) but I need an MIT license package, not GPL.

Well, pysmb is zlib/png license, which is (IANAL) more permissive than GPL.


Logo Proposal

I would love to participate in making the project logo, I am willing to work on it Mr. @Shouheng88 .

I'm glad to hear that :)
But I'm busy learning developing skills these days, so I couldn't put forward any good idea about the logo. You can design as you prefer :)

okay, I will just submit my design here. if you like it, I will make a PR. is that good ?

OK

how about this one ? @Shouheng88

Why should we use the background of a ear phone?

@Shouheng88 just to be classic I think, it is commonly used by the translators.

Hello, can I update the issue? please response. Thank you :) @Shouheng88


Docs recommendation regarding adding  .sface to the watchers list

Hi, Great library 👍
In the Colocated templates section in the docs I think it will be nice to recommend  developers to add .sface files to the watchers list inside the dev.exs file. e.g.
config : MyApp, MyAppWeb.Endpoint,
  live_reload: [
    patterns: [
      ~r"priv/static/.*(js|css|png|jpeg|jpg|gif|svg)$",
      ~r"priv/gettext/.*(po)$",
      ~r"lib/zapp2_web/(live|views)/.*(ex)$",
      ~r"lib/zapp2_web/templates/.*(eex)$",
      ~r"lib/zapp2_web/live/.*(sface)$"
    ]
  ]

I would have added a PR myself but I can't find the docs repo

Hi @gavriguy!
Thanks for pointing that out. Since this is a configuration, I think we should probably add it to the Getting Started section, along with the other configs. WDYT? Something like:

...
If you're using mix format, make sure you add surface to the import_deps configuration in your .formatter.exs file:
[
  import_deps: [:ecto, :phoenix, :surface],
  ...
]

To allow live reloading for .sface files, add the related patterns to the endpoint configuration in your config/dev.exs:
config : MyApp, MyAppWeb.Endpoint,
  live_reload: [
    patterns: [
      ~r"lib/my_app_web/live/.*(sface)$",
      ...
    ]
  ]

...

Sounds good. Thank you :)

OK. I added it. It will be available as soon as I finish updating a few other things in the docs before releasing v0.1.2. I'll leave the issue open until the release.
Cheers.

Already pushed to the new repo.

Already pushed to the new repo.


Question about valid input

Dear orgmunge team,
I was quite happy to discover orgmunge because I need exactly this functionality, so I installed it and started to try it out.
Thanks a lot for providing it!
However, I quickly ran into two behaviors where I don't know they are bugs or features, so any hint on the expected behavior would be welcome.
Firstly, I had a file where the initial section is not under any header but starts with plain text. The parser fails to accept this input while reading the first line.
Secondly, I had a line that reads as follows:
**** TODO 30 XYZ (10 DONE)
which also makes the parser fail. It works however if DONE is written (partly) in lowercase. Alas, even a longer word that  starts with DONE leads to parsing failure.
Clearly, I can work around these problems by starting the file with a header and avoiding keywords as part of my text.
I just wanted to know whether maybe I installed a partly obsolete version and I would obtain different behavior from a more recent version or perhaps a cleaner setup.
In case it matters: my setup uses ply version 3.11, while the orgmunge does not seem to contain any version information.
Thanks a lot in advance for any insights on this matter!
Best regards, Andreas

Hello @AndreasEisele,
Please send examples of the different cases (what was rejected and what was accepted by the parser). I don't think this should depend on the PLY version. It sounds like an implicit assumption that the parser is making about how an Org file should be structured.

The commit I just pushed should fix the problem of having a todo keyword in your title. Please check that it's gone now. Regarding your other issues:

I wasn't able to reproduce the issue of a file having content without a heading. I tried to parse a file that had only one line: "Hello, world!" and it parses correctly for me. Please share a minimal example that fails to parse with this issue.
When you showed an example with a level-4 heading I just wanted to make sure that that heading is embedded in a hierarchy of levels 1 through 3 above it. If it isn't it will still fail to parse for you. Even though it's acceptable Org, I made the choice to not accept headings that skip levels so that the tree structure is more uniform.


Issue with Bluetooth Pi Zero 2W

Hello, I finally made my Zero 2W bring up Bluetooth. By default it complains that the patch bcrm/BCM.hcd is missing. But its right there in /lib/firmware/bcrm/BCM43430B0.hcd. I manage to fix this by ssh into the PI and copying it to the new name:
cd /lib/firmware/bcrm/
cp BCM43430B0.hcd BCM.hcd

So that's the fix, but I don't know how to integrate it into Buildroot, and therefore, not able to open a PR.

I used it on Z2W yesterday, and everything worked perfectly for me.

I've also been using with RPi Zero 2W without any issue. Are you facing the issue even with the prebuilt images?

@hkfuertes On my KIA Niro 2017 it works flawlessly.

@hkfuertes My fork changes nothing in that regard, but feel free to try it. I'm also using a Pi Z2W (and a Pi 4 for testing), and I didn't have these problems.

Sorry I'm late, but yes you where all right, it has to be my board. Yesterday I built a PI3A+ Image with this repo, and it works flawlessly on my KIA. I will investigate, and maybe get another Zero2W, as mine was never used since I bought it on launch (maybe its outdated 🤷♂ ).
I guess we can close this issue. BTW, I will try to make a PR this evening to add the defconfig I used for the PI3A+, mainly the Zero2W's with the proper dtb (from Buildroot oficial pi3 defconfig) and as this board has 5GHZ, the hostapd from PI4 Overlay. I need to check if in the dtoverlay=dwc2,dr_mode=peripheral, 'dr_mode' is required or not, for now I have it, but maybe is not necesary, and then the defconfig can be simpler.
(In case anyone is curious, the 3A+ only has a single USB, with no hub, so the controller can also be put in gadget mode, then with a USBA to USBA cable, everything works, even it takes power from there!)

I've also been using with RPi Zero 2W without any issue. Are you facing the issue even with the prebuilt images?

Please share link/location for the prebuilt images. I built it yesterday and was testing it today, but Bluetooth is not coming up. #13

I Will try to build one, but if you can build it yourself, I can tell you what to add.
inside buildroot/board/raspberrypi/post-build.sh add at the end:
cd ${TARGET_DIR}/lib/firmware/brcm
if [ ! -f BCM.hcd ]; then
    ln -s BCM43430B0.hcd BCM.hcd
fi

This should now be fixed by 8c0dd4c42ee6d860f82895671bff2dca9de97c03.


Update limit to RTP ports and UDP port for SIP connection.

I changed the limit to open ports to only 20 for RTP.
I changes the SIP ports from TCP to UDP.

Closing as has been integrated in another earlier release


SiteExtension Transform tests are failing in release/2.1

4 tests started failing in release/2.1
Assert.Equal() Failure
Expected: 2
Actual:   3
   at Microsoft.AspNetCore.AzureAppServices.SiteExtension.TransformTest.Transform_EmptyConfig_Added(String configFile) in C:\b\w\33bdfc1cae7b2a38\modules\AzureIntegration\test\Microsoft.AspNetCore.AzureAppServices.SiteExtension.Tests\TransformTest.cs:line 27

http://aspnetci/viewLog.html?buildId=405485&tab=buildResultsDiv&buildTypeId=Releases_21Public_Win2012

Fixed in https://github.com/aspnet/AzureIntegration/pull/148


fix(parser): support nameless tf resources

this PR solves the fatal error we are getting when scanning a TF resources without a name. for exmple for the following, we were getting the following fatal error:
resource "aws_lb" {
  name               = "test-lb-tf"
  internal           = false
  load_balancer_type = "network"
  subnets            = [for subnet in aws_subnet.public : subnet.id]

  enable_deletion_protection = true

  tags = {
    Environment = "production"
  }
}

resource "aws_lb" {
  name               = "test-lb-tf"
  internal           = false
  load_balancer_type = "network"
  subnets            = [for subnet in aws_subnet.public : subnet.id]

  enable_deletion_protection = true

  tags = {
    Environment = "production"
  }
}

the error we are getting:
panic: interface conversion: interface {} is []interface {}, not model.Document

goroutine 13 [running]:
github.com/Checkmarx/kics/pkg/parser/terraform.processResources(0x1e43a80?, {0x4000230f40, 0xa})
	/app/pkg/parser/terraform/terraform.go:75 +0x1d8
github.com/Checkmarx/kics/pkg/parser/terraform.addExtraInfo({0x400012e250?, 0x1, 0x1}, {0x4000230f40, 0xa})
	/app/pkg/parser/terraform/terraform.go:93 +0xac
github.com/Checkmarx/kics/pkg/parser/terraform.(*Parser).Parse(0x4000f1d300, {0x4000230f40, 0xa}, {0x4000c426c0, 0x223, 0x240})
	/app/pkg/parser/terraform/terraform.go:133 +0x188
github.com/Checkmarx/kics/pkg/parser.(*Parser).Parse(0x4000f255c0, {0x4000230f40, 0xa}, {0x4000c426c0, 0x223, 0x240})
	/app/pkg/parser/parser.go:128 +0x120
github.com/Checkmarx/kics/pkg/kics.(*Service).sink(0x40005e9730, {0x2765410, 0x400013a000}, {0x4000230f40, 0xa}, {0x210a8c2, 0x7}, {0x2748400, 0x400012e040}, {0x4001200000, ...})
	/app/pkg/kics/sink.go:42 +0x134
github.com/Checkmarx/kics/pkg/kics.(*Service).PrepareSources.func1({0x2765410, 0x400013a000}, {0x4000230f40, 0xa}, {0x2753608?, 0x400012e040})
	/app/pkg/kics/service.go:71 +0xa8
github.com/Checkmarx/kics/pkg/engine/provider.(*FileSystemSourceProvider).GetSources(0x40001284c0, {0x2765410, 0x400013a000}, 0x87354?, 0x40004c0dc0, 0x0?)
	/app/pkg/engine/provider/filesystem.go:129 +0x140
github.com/Checkmarx/kics/pkg/kics.(*Service).PrepareSources(0x40005e9730, {0x2765410, 0x400013a000}, {0x210a8c2, 0x7}, 0x4000cf8120?, 0x4000cf8180?)
	/app/pkg/kics/service.go:67 +0x1c0
created by github.com/Checkmarx/kics/pkg/scanner.PrepareAndScan
	/app/pkg/scanner/scanner.go:24 +0xb4

overall, tf resources withtout a name are not valid, but I belive it would be better inspecting those resources anyway and be able to indicate other issues we have on them other than completly fail the scan
Proposed Changes

I submit this contribution under the Apache-2.0 license.

@cxMiguelSilva any chance you look on this one?

Hi @cxMiguelSilva, i added a simple test  for that, can we push it forward?

Hi @cxMiguelSilva, i added a simple test for that, can we push it forward? cc: @gabriel-cx @lior-orca @kaplanlior

Hi @liorj-orca, I have made the initial code review, and now it will be submitted to QA analysis. Once we have the ok we will merge it. Thank you so much for this contribution to this missing case on the Terraform parser 😀


Rename TinkerbellTemplateBuilder to TemplateBuilder

Rename the TinkerbellTemplateBuilder construct to TemplateBuilder given its resides in the tinkerbell package.
This aligns with the coding guidelines.

/cc @gwesterfieldjr @jacobweinstock @panktishah26 @abhinavmpandey08 @pokearu @ptrivedi

Name change portion looks okay. Have question about skipPowerActions removal as a part of comments on a different PR

/approve


Run tests after PR is merged (push to dev/main)

This should ensure coverage gets published

Codecov Report

:exclamation: No coverage uploaded for pull request base (dev@54113e1). Click here to learn what that means.
 Consider uploading reports for the commit 64fe441 to get more accurate results

@@           Coverage Diff           @@
##             dev       #11   +/-   ##
=======================================
  Coverage       ?   100.00%
=======================================
  Files          ?         2
  Lines          ?        54
  Branches       ?         0
=======================================
  Hits           ?        54
  Misses         ?         0
  Partials       ?         0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Blocks execution if rabbitmq is not reachable

Inquiry
If RabbitMQ host is not reachable, it blocks td-agent. Is this the intended behavior?
For example, in the following case, it will not print the dummy events.
Configuration
<source>
  @type dummy
  tag mytest
  dummy {"hello":"world"}
</source>

<match **>
  @type stdout
</match>

<match **>
  @type rabbitmq
  host <IP_ADDRESS>
  # or hosts ["<IP_ADDRESS>", "<IP_ADDRESS>"]
  user user
  pass password
  vhost /
  format json # or msgpack, ltsv, none
  exchange test # required: name of exchange
  exchange_type topic # required: type of exchange e.g. topic, direct
  exchange_durable false
  routing_key mytest # if not specified, the tag is used
  heartbeat 10 # integer as seconds or :server (interval specified by server)
</match>

Plugins
bunny (2.13.0)
fluent-plugin-rabbitmq (0.0.5)
fluentd (1.3.3)

Output
2019-01-25 07:27:44 +0000 [warn]: #0 fluent/log.rb:342:warn: Could not establish TCP connection to <IP_ADDRESS>:5672: Bunny::ClientTime out                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/log.rb:362:error: unexpected error error_class=Bunny::TCPConnectionFailedForAllHosts erro r="Could not establish TCP connection to any of the configured hosts"                                                                    2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ bunny-2.13.0/lib/bunny/session.rb:333:in `rescue in start'                                                                               2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ bunny-2.13.0/lib/bunny/session.rb:305:in `start'                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluent-plugin-rabbitmq-0.0.5/lib/fluent/plugin/out_rabbitmq.rb:119:in `start'                                                            2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/root_agent.rb:165:in `block in start'                                                                           2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/root_agent.rb:154:in `block (2 levels) in lifecycle'                                                            2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/root_agent.rb:153:in `each'                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/root_agent.rb:153:in `block in lifecycle'                                                                       2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/root_agent.rb:140:in `each'                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/root_agent.rb:140:in `lifecycle'                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/root_agent.rb:164:in `start'                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/engine.rb:274:in `start'                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/engine.rb:219:in `run'                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/supervisor.rb:799:in `run_engine'                                                                               2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/supervisor.rb:549:in `block in run_worker'                                                                      2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/supervisor.rb:724:in `main_process'                                                                             2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/supervisor.rb:544:in `run_worker'                                                                               2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/lib/fluent/command/fluentd.rb:316:in `'                                                                    2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/site_ruby/2.4.0/ rubygems/core_ext/kernel_require.rb:55:in `require'                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/site_ruby/2.4.0/ rubygems/core_ext/kernel_require.rb:55:in `require'                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/lib/ruby/gems/2.4.0/gems/ fluentd-1.3.3/bin/fluentd:8:in `'                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/bin/fluentd:23:in `load'    2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /opt/td-agent/embedded/bin/fluentd:23:in ` required)>'                                                                                2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /sbin/td-agent:7:in `load'                         2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:549:block in run_worker: /sbin/td-agent:7:in `'                     2019-01-25 07:27:44 +0000 [error]: #0 fluent/log.rb:362:error: unexpected error error_class=Bunny::TCPConnectionFailedForAllHosts erro r="Could not establish TCP connection to any of the configured hosts"                                                                    2019-01-25 07:27:44 +0000 [error]: #0 fluent/supervisor.rb:723:main_process: suppressed same stacktrace                              2019-01-25 07:27:44 +0000 [info]: fluent/log.rb:322:info: Worker 0 finished unexpectedly with status 1

Hi. Just for your notice, I release v0.0.6 and it supports buffered output. Enjoy!

Great! Thank you!


Allow user to specify custom data attribute name for toArray() method

Currently toArray() method gets the item id from data-id attribute, which can not be changed and would be great if i could set this parameter in plugin options :) Thanks.

Done, try dev-branch and use dataIdAttr: https://github.com/RubaXa/Sortable/tree/dev#toarraystring

@RubaXa wrong variable name in https://github.com/RubaXa/Sortable/blob/dev/Sortable.js#L736 should be dataIdAttr :)

fixed.

:+1: Thank you.


Support for generated .module file to specify that project dependency version must match exactly

Expected Behavior
It would be nice for Gradle to offer the ability for projects to specify that a specific dependency version in a generated .module file must be treated as a strictly versioned dependency (that is, to add the "strictly" key in the .module file) even if that dependency in the .module file was added due to a project dependency in the build.
Current Behavior
Currently, there doesn't seem to be any way for a project to directly specify this.
Context
In AndroidX, we have different compatibility policies for different dependencies: some pairs of artifacts might be accessing special version-specific APIs in each other and might need their versions kept in sync, whereas other pairs of artifacts might only be interacting through regular, public APIs and can be versioned independently.
We've encoded this in the generated .pom files by adding "[" and "]" around the version number in the .pom file  but we don't notice a way to do the same with gradle module metadata (see also https://issuetracker.google.com/issues/146802533#comment15  ).
Some potential workarounds:
A) We could keep the current state where Gradle builds that depend on our artifacts don't know about these version constraints, and rely on those developers to manually test compatibility
B) We could theoretically customize the generated .module module via something text-based like sed

Hey if there's any update on this that would be super cool!

I think another workaround is dependency substitution, or conditional in buildSrc or plugin that either brings the project dependency, or an external dependency with the desired constraints when building for publishing.

Hey it looks like AndroidX doesn't need this anymore since we are going with the above approach of reciprocal dependency constraints to allow dependent builds to auto-update their versions rather than fail

In the meanwhile, we also found that a workaround for this issue as described (allow publishing a strict dependency constraint corresponding to a project dependency) seems to be to declare an external module dependency that matches the coordinates of the corresponding project
Example:
constraints.add(
    configuration.name,
    constraints.create(module) { constraint ->
        constraint.version { v ->
            v.strictly(requiredVersion.toString())
         }
     }
 )

(from https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2365392/12/buildSrc/private/src/main/kotlin/androidx/build/AndroidXImplPlugin.kt#964)
(not the approach we ended up using per my previous comment)


pull request for e2e test at 11/19/2016 19:56:06

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


insert cost long time (s3 as backend storage)

byconity s3 use list interface to implement exists logic
list is a heavy interface, this will lead to byconity insert overtime

https://github.com/ByConity/ByConity/blob/0ea1689d0d2ba1bb26a7b4f37fc7d563b465197a/src/Disks/DiskByteS3.cpp#L158-L164
According to the comments on the method, "exists" may be used to determine if a prefix or object exists.
Currently, the file structure of S3 should be in the format of root_path/xxxx/data, where xxx is variable. Can we directly use regular expressions to determine if it meets the above rule, and if so, use "getObject" to check its existence?


Add wil::println() - C++23's std::println() but for HANDLEs

e.g (needs C++20):
void println(
  HANDLE handle,
  std::format_string<Args...> format,
  Args&&... args) {
  const auto buffer = std::format(format, std::forward<Args>(args)...) + '\n';
  DWORD bytesWritten = {};
  while (bytesWritten < buffer.size()) {
    const auto remaining = buffer.size() - bytesWritten;
    DWORD bytesWrittenThisBatch {};
    const auto result = WriteFile(
      handle,
      buffer.data() + bytesWritten,
      remaining,
      &bytesWrittenThisBatch,
      nullptr);
    if (!SUCCEEDED(result)) {
      throw std::system_error(result, std::system_category());
    }
    bytesWritten += bytesWrittenThisBatch;
  }
}

Would also probably want a wchar version taking an std::wformat_string

Is this required considering you can get a FILE* from a HANDLE and then use it with the normal std::print?

If you're talking about _open_osfhandle():

The _open_osfhandle call transfers ownership of the Win32 file handle to the file descriptor. To close a file opened by using _open_osfhandle, call _close. The underlying OS file handle is also closed by a call to _close. Don't call the Win32 function CloseHandle on the original handle.

This is a pretty significant limitation; is there another way?

I guess that can be used with DuplicateHandle(), but there's unintuitive semantics there - for example, are the write cursors kept in sync?

Ah good point wrt ownership.
Another concern was every write allocating a string. The + '\n' in particular concerns me because we might do a full copy of the string just to add that newline. Perhaps we could use format_to with an iterator that did buffering using a stack array? But then it would negate some performance fast paths in std::format. Might be worth benchmarking different solutions before setting on one.


如何把图表中文字大小使用rem控制

项目要用在4K高清大屏上展示，图表可以自适应，但是文字特小。请问，有没有什么方法能统一把单位从px改成rem ？

目前不支持 rem 字体，可以在设置的时候根据分辨率设置文本的字体

how to use this trick, could you give code example, I tried like below,but it didnt work
label: {
         fontSize: '150%',
         fontFamily: 'px  :) Simsun',
 }

label: {
        fontSize: '150%',
        fontFamily: 'px  Simsun',
}

2021年了，这个功能有支持了吗？

@zhoufanglu Using rem unit in font size has been supported since v5.

@zhoufanglu Using rem unit in font size has been supported since v5.

4.9支持吗？我现在用的是4.9..

@zhoufanglu I'm afraid no. It's a new feature brought in ECharts 5. Refer to ecomfe/zrender#612 for more details.

@zhoufanglu I'm afraid no. It's a new feature brought in ECharts 5. Refer to ecomfe/zrender#612 for more details.

好的 谢谢大佬的回答


Add Mission Control Jobs to Solid Queue sample app

This enables the "/jobs" endpoint for viewing more details about jobs.

I was thinking of leaving it off originally (so we'd uncomment if wanted to run with it), but adding it by default works!


Pin analyzer package so that we're consistent

See the comment in the patch for details.

cc @mpcomplete - this is a side-effect of your recent patch

lgtm, sorry! (strangely I don't get any errors when running flutter analyze)

you should get some warning spew (it's visible e.g. in the travis logs) but it doesn't count as failure.

(maybe it should)


Add missing submodule update to setup.sh

Short Description:
Currently script is only doing git submodule init, but it needs to do git submodule update before attempting to pull master or the web submodule will not be checked out.

Do you know what does this mean?
git submodule foreach git pull origin master
Close this pr plz

sorry I known what you mean.
Although this is required but it will only need once. I will add this into install.sh. Thx.

For now use git submodules update --init to replace both two lines is better.

@simonsmh please use the edit button ;-)
I would recommend you change it to:
git submodule update --init --recursive

added this to here to make it more simple:
https://github.com/PokemonGoF/PokemonGo-Bot/pull/3593

Closing in favor of #3593

How are submodules updated when running Docker?


Move hsa-lazy-queues to smoke, and update rocprof usage

LGTM. Counting the events works as intended -- thanks!


ETOR research and documentation

[ ] Understanding the Newborn Screening Domain - @MikeC-A6
[ ] Newborn screening in GA - @MikeC-A6

Moved tasks to https://github.com/CDCgov/trusted-intermediary/issues/30

Further high level ETOR research to be done under #49


this is related to https://github.com/fluffle/goirc/pull/71

common irc server behaviour is to reply with an empty + if channel mode is empty

Good idea, I changed your commit a bit, pushed it here: https://github.com/edmund-huber/ergonomadic/commit/65539a593bf094ffc5a947bd8e6eb5997e527466 .


Allow merging of schemas

I know this can be achieved with the extend method, but the simple schema 1 way where we could just define something like:
new SimpleSchema([schema1,schema2,{otherField:{...}}]); was much easier. I think it'd be pretty straightforward to add this as syntactical sugar in simple schema 2 ?

Passing an array to the constructor was something that seemed to cause a lot of confusion in v1. I opted for the more obvious "extend". I can make it chainable, though, allowing:
new SimpleSchema(schema1).extend(schema2).extend({otherField:{...}})

Is that good enough?


refactor: Contracts codebase refactor

Purpose:
The purpose of this PR is to strengthen contract testing suites via. an integration with Foundry. Other specific changes are WIP.
Changelog:

Foundry integration
Some github related stuff for future PRs
contract refactor PRs (more changes incoming in later PRs)

So, there are some additional things in the contracts that have to be refactored (e.g. dailyBlocks) and how we need a timestamping mechanic for seeing when someone submitted a proof latest. Should we do this now in this PR or later in a "contracts internal review" PR? I was opting for the latter (implementing upgradability and all features first before going back for a major overhaul)

@laudiacay feel free to take a second look when able, and merge if this looks good.

Since I'll be working more intensively on the upgradability today, I will merge this for now. Can revert later if need be.


[Feature] added Jina AI Embedding support

[FEATURE] Jina AI Embedding support

Added Jina AI embeddings Support using the jina-embeddings-v2-base-en
Updated the models.json locally however changes need to be made in master file
Added JinaApi Credential class
Added JinaAI SVG Icon

Thanks @definitelynotchirag !
Made a change on the model name to string type, because I think its better for users to specify the embedding model they want to use, instead of the selections provided in the models.json file

Alright!! that would be great, Thank You for Approving!


Allow add custom plugin for docs using helm chart

We're using docs documentserver deployed by Helm Chart inside our on-primeses kubernetes cluster and all things are working great. A feature was requested and we created a custom plugin. In our local dev machine, using docker version, the custom plugin was added manually, tested and approved. When we started to deploy in the staging server, we needed to extend the docker image and copy the plugin folder.
Why not create a ConfigMap with binaryData pointing to plugin.tar.gz, and inside a sidecar in docserver, with an extra volume we extract plugin inside sdkjs-plugins?
My idea
ConfigMap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: custom-plugin-tar-gz
  namespace: onlyoffice
binaryData:
  custom-plugin.tar.gz: >-
    base64 encoded

Docs helm chart Values.yaml:
docservice:
  initContainers:
      - name: deploy-custom-plugin
      image: busybox:1.37.0
      command: ['sh', '-c', 'tar -zxvf /var/www/onlyoffice/custom-plugins/custom-plugin.tar.gz -C /var/www/onlyoffice/documentserver/sdkjs-plugins/']
      volumeMounts:
        - name: custom-plugins
          mountPath: /var/www/onlyoffice/custom-plugins
 volumes:
  - name:   custom-plugins
     configMap:
       - name: custom-plugin-tar-gz

Hello @vinibsi, thanks for the enhancement suggestion, this is an issue #71492


Create qcow2 image when using the OpenStack builder

Signed-off-by: Christian Berendt<EMAIL_ADDRESS>

Thanks a lot!
/lgtm


recognize vector, matrix, quaternion constructors in a better way

New:
(defun quaternion-rotate-x! ((arg0 quaternion) (arg1 quaternion) (arg2 float))
  (let
   ((a1-3
     (quaternion-vector-angle!
      (new-stack-quaternion0)
      (vector-x-quaternion! (new-stack-vector0) arg1)
      arg2
      )
     )
    )
   (quaternion-normalize! (quaternion*! arg0 a1-3 arg1))
   )
  )

Old:
(defun quaternion-rotate-x! ((arg0 quaternion) (arg1 quaternion) (arg2 float))
  "Rotate existing quaternion along x axis. This has a different implementation
   from the others for some reason."
  (let ((s4-0 quaternion-vector-angle!)
        (s3-0 (new 'stack-no-clear 'quaternion))
        )
    (set! (-> s3-0 vec quad) (the-as uint128 0))
    (let ((t9-0 vector-x-quaternion!)
          (a0-1 (new 'stack-no-clear 'vector))
          )
      (set! (-> a0-1 quad) (the-as uint128 0))
      (let ((a1-3 (s4-0 s3-0 (t9-0 a0-1 arg1) arg2)))
        (quaternion-normalize! (quaternion*! arg0 a1-3 arg1))
        )
      )
    )
  )

This is about the same difficulty to implement, but can fix propagation issues so this seems promising for recognizing other operations similar to this.

Pull Request Test Coverage Report for Build 974957697

104 of 111 (93.69%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 69.402%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

decompiler/IR2/FormExpressionAnalysis.cpp
70
77
90.91%

Totals

Change from base Build 974856366:
0.07%

Covered Lines:
36846

Relevant Lines:
53091

💛  - Coveralls


What about merge / conflict scenarios?

Given an backend with multiple client applications - for example a mobile and a web client. The client updates some data using the mobile application while being offline. Then the user makes some data changes using the web client, which immediately saves the changes to the backend. Now, when the mobile application gets network connectivity again, we technically have a conflict.
How do we choose which data  of the outbox queue should be sent to the server and which should be discarded in favor of the newer remote data? Or is this more kind of a backend topic? I haven't dealt with such scenarios yet, but a possible solution which comes to mind is to integrate a timestamp into the request and let the backend decide, if it should accept the changes or not.

Great question! This will be different for different backend sync strategies, so I don't want to build in too many assumptions. You can now already include timestamps as action metadata, and process them accordingly in your effects handler.
As I've coyly alluded here, error handling support is still only half-implemented, and client-side state updates to conflict errors definitely fall into that category.
I do want to collect feedback on this, so let's keep this open for now.
Let 's the eventually decide whether there is a general enough approach to implement this in code, or if updating the documentation is a way to go.

This is very dependant on what you want to do.
I would basically divide the cases in two:

The data from both devices is desired
The most up to date data is desired

Case 1. Will be some sort of logging or creation of new data, eg. Workout entries, time tracking entries, adding a new recipe to a collection, etc...
Case 2. Is typically patching/updating an entry. Updating your workout entry, time log or modifying an existing recipe. In general given multiple change a coming to a backend from multiple devices you should look to use the latest one. eg. User starts updating there profile on a computer in a plane, runs out of power and switches to their mobile. Realised that they have not got the changes from the computer and starts making all there changes again. Ie they expect this to become the truth later - not what's on the computer.
I'd also say that in general offline should not be available for multiple people managing a collection. Eg a library catalog. One person loaning out books/building yard gear from multiple devices is probably ok as they know roughly what they have loaned. But even this is probably not a good idea - there be dragons down this path. I'd probably just try and avoid using offline writing with any centralised catalog system. Maybe instead allow user to create quotes/intentions that could later be reviewed and applied.
Essentially quotes/intentions would just be a log of items so would follow the rules of case 1 and 2 above.

For case 2 you may want to look at operational transformations to merge in changesets. Something like https://github.com/share/sharedb


Fabio fails to strip the prefix if the url prefix does not start with the strip option value

We have a web service running which serves a site on
http://myhost/artefacts

And the consul service configuration contains the following tag
urlprefix-/artefacts/installers strip=/installers host=dst

I was expecting that this would make fabio strip the path correctly but what happens instead seems to be that the full prefix is passed on to the service, i.e. fabio calls http://myhost/artefacts/installers.
I assumed that the strip option would indicate to fabio which part of the prefix to remove however it seems that it only works if the option contains the first part of the url prefix.
Is there a way to get fabio to strip the selected text from the prefix?

Did you put the three options in the same consul tag ?

Yes, that entire line is one single consul tag. I've got other services (with other prefixes / strip / host options) and those work just fine but they strip either just the start of the prefix or the entire prefix.

@pvandervelde fabio is not intended to be a full nginx replacement which mangles routes and rewrites URLs. It is primarily a stateless router which forwards requests to services which claim that they can handle them without changing them.
If your service needs to handle requests from /artefacts/installers why not add a handler for this to the code?
The main motivation for the strip prefix option was that entire sets of services were proxied behind a common URI which made it impractical to change every service. I don't see that use case for stripping the suffix but maybe you can explain your use case a bit more.

In our case we're proxying using fabio to proxy a set of sites / services that we use in our build infrastructure. Most of these services aren't our own services, they're third party tools that we run so we have very little control over what handlers there are. The goal is to provide the developers with a single 'site' that looks like it has all the services they need to interact with our build infrastructure. So for instance the site that fabio presents to the users looks like
myhost.mycompany.com
    builds
    artefacts
        installers
        images
    services
        rabbitmq

Where builds points to a jenkins instance, artefacts/files points to a caddy webserver instance, artefacts/images points to a web service and services/rabbitmq points to a local RabbitMQ instance. The problem described was that the caddy webserver was serving pages on
myotherhost.mycompany.com/artefacts

Because we have multiple artefacts sites we wanted to combine them under the artefacts directory, hence we decided to put it under artefacts/files.
I get that this is probably not what fabio was designed for and we can probably figure a way around it with some effort. I was just interested to see if I configured something wrong or if this was by design (which is perfectly fine by us).

@pvandervelde you could use strip=/artefacts/installers and access the other service under / I don't see the point in the upstream service to respond to /artefacts when in fact it is providing /installers. What am I missing?

 There are several other web services running on that machine so we can't use the machine root because it could collide with the other services, however we might be able to make it respond to /installers instead.
In the end it doesn't matter very much we'll be able to work around it :) I was just curious to see if I'd missed anything because I assumed that strip just replaced whatever term with an empty string, but that is not the case. Maybe it's more of a case of me not reading the documentation correctly.

My main lesson from the eBay team I ran was that adding this kind of complexity caused more issues downstream even if it fixed your immediate problem at hand. fabio was the result of that constant maintenance pain, the fact that everything had to be looked up instead of being derived. My main motivation for writing it was to simplify the architecture by actually removing entire components and workflows, e.g. you do not have to coordinate the deployment and maintenance of an LB configuration in tandem with your service config. The services announce what they can serve and fabio will just serve them. We literally ran fabio for months and even more literally forgot that it was there at all.
What you are trying to do feels like going against that very motivation and that usually makes me question the approach as a whole.
Therefore, my advice is to push (invest time) for having the services advertise and handle what they actually claim they handle. It pays off.

Sounds sensible. For the immediate time we'll work around it while we update the services. Thanks


Update windows-targets 0.52

This just brings expanded lib support to include coverage for the first update to the windows-sys crate in 8 months. https://github.com/microsoft/windows-rs/releases/tag/0.52.0

Ah, looks like you have a lower MSRV. Much like tokio, the windows-targets crate now expects 1.56 to avoid a number of workspace compatibility issues.
I'll just go ahead and close this PR and you can revisit when you're ready to bump your MSRV. 👋


npm install msgpack/msgpack.codec

After sending the last pull request #4, I found the same name library of "msgpack-javascript" registered on npmjs: https://www.npmjs.com/package/msgpack-javascript
I've changed the name on the package.json, then.
npm install msgpack/msgpack.codec

Merge and publish it, please :+1:

lol, this ridiculous? that guy @davidfhaines just forked the repo from here then made the release to npm.org 🙈

Now it is published as @msgpack/msgpack


Hide Element Before Rendering

How to avoid something like this?

So basically i want to hide these elements/data and show up after dom is ready
Thanks

I suppose you just display templates before Vue is initialised. Why not to put templates into <script type="text/html"> tags? Or you can wrap them into an invisible div.

@karevn ah thanks for idea .. :+1:
if i choose to wrap them with invisible div, then which event i should listening to display them?
Yes, its not bug, just need some thought from fellows in here :+1:

@ghprod you don't need to display them at all. You just "mount" Vue instance to some visible element at the initialisation, while templates stay invisible.

@karevn ah yappp ... Thanks a lot.. closed :+1:

@ghprod why not to use v-cloak directive? Also please post questions to forum, this is only for issues.

@OEvgeny Ah my bad, i didnt notice about forum, i'm sorry ..
Thanks for your hint :+1:

@OEvgeny because @ghprod talks about the moment when Vue is not launched at all, so directives have no effect.

@karevn yes, and with style display none then its works perfectly .. :+1:

or with animated.css and add this animated fadeIn on v-cloak element ..
Thanks all .. :+1:

@ghprod wow, good to know! :+1:

@OEvgeny because @ghprod talks about the moment when Vue is not launched at all, so directives have no effect.

for [v-cloak] { display: none; } you don't need Vue to be initialized at all. This is correct way to hide vue templates until compiled.


fix appstore not loading when a single app is not written correctly

@CorrectRoadH please take a look.


LIBFQMQUER-3: Add NOT CONTAINS operator for arrays

Purpose
Add NOT CONTAINS operator to handle arrays
Add a notContains operator to handle array db fields. This operator should return any rows where the array db column does not contain the user-provided value, or is null. Currently, the user-provided value must be a single value (i.e., not an array). For string values, upper/lowercase is ignored.
Testing

[x] All unit tests passed
[x] Array columns can be queried with the $not_contains operator (actually also works for non-array fields):

------------------------------------------------------------------------------------------

The new operators need added to the README, too


Leave Command

Makes the bot instantly leave and starts the inactivity timer (for queue clearing purposes).

Pretty sure the inactivity timer is started automatically due to player's nosubscriber behaviour, but good to double check.

Implemented in 775dfe7


yii\rest\UpdateAction returns model with outdated optimistic lock value

yii\rest\UpdateAction returns the model with the same lock version with which it was saved, but the actual lock version is incremented by 1 during the update.
So a successful PUT/PATCH request returns the model with the outdated optimistic lock value.

according to the code of AR it should work: https://github.com/yiisoft/yii2/blob/078b922114e5ba3481487a80f28769e69713ea33/framework/db/BaseActiveRecord.php#L731
can you give more information, e.g. the action and model code you are using?

@cebe you're right, it should, but that piece of code was commited after 2.0.4 release. Waiting for 2.0.5 then!

yeah, this has been fixed by 51a442d6c8266bf14e258cc77625b6d192f678d0 and 467596633d3b3dd271d0213fbbffba41e3293982


I can't seem to find the "fonts"?

In every font option there's a text saying that I should come here for more options, but I looked around and didn't seem to find.
I do admit that I haven't tried using normal font names. And if it's somewhere but I didn't find cause I don't know any better I do apologize.

Oh, oops that text is left over from a very old build. I need to change that text.
The fonts are all built into now, theres no need to install them anymore.
If you wish to change fonts all you need to do is type in the name of a font into the textbox in style settings and it will automatically change the font with fonts that are installed on your system.

Oh I see, thanks! (I'm also excitedly waiting for the fix on the narrowing of the panes, this is by far the best obsidian theme by light years)


Added Austin Community College file and folder

Official site: https://www.austincc.edu
Link to CS & IT programs: https://www.austincc.edu/academic-and-career-programs/areas-of-study/computer-science-and-information-technology
Proof of email domain: https://www.austincc.edu/help/accmail
Relevant text in link:
IMPORTANT: The assigned format for ACC student email (ACCmail) is firstname.lastname @ g.austincc.edu.

@aleksebastian First stage of verification passed, official domain is austincc.edu as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


Additional Logstash Metrics

I'd like to propose the addition of some additional metrics, for use with a Grafana dashboard. (Derived from an existing one on grafana.com's dashboard registry.)
I'll be happy to contribute a PR with the following metrics added:
Standard via "stock Logstash" /_node/stats API response.

logstash_stats_process_cpu_load_average_1m
logstash_stats_process_cpu_load_average_5m
logstash_stats_process_cpu_load_average_15m
logstash_stats_process_peak_open_file_descriptors
logstash_stats_jvm_gc_collectors_collection_count{pool="*"}
logstash_stats_pipeline_plugins_inputs_events_queue_push_duration
logstash_stats_pipeline_plugins_inputs_events_out
logstash_stats_pipeline_plugins_filters_events_in
logstash_stats_pipeline_plugins_filters_events_out
logstash_stats_pipeline_plugins_filters_matches
logstash_stats_pipeline_plugins_filters_failures
logstash_stats_pipeline_plugins_filters_events_duration
logstash_stats_pipeline_plugins_outputs_events_in
logstash_stats_pipeline_plugins_outputs_events_out
logstash_stats_pipeline_plugins_outputs_events_duration
logstash_stats_pipeline_reloads_last_success_timestamp

From the Elasticsearch output plugin (via /_node/stats API response)

logstash_stats_pipeline_plugins_outputs_bulk_requests_with_errors
logstash_stats_pipeline_plugins_outputs_bulk_requests_successes

Would these (or a subset) be welcome additions to the set that's currently exported?

hello @excalq sorry for long time to respond, but i was so tired i wanted to hold looking on the issue
about

logstash_stats_process_cpu_load_average_Xm- I am not sure about that:

source: (https://prometheus.io/docs/instrumenting/writing_exporters/)
you should achieve the same result by grafana query + this metric
I can help you if you encounter any problems with that

for elasticsearch output plugin i think you can implement that, however for version 2.x i would like to implement a way to scrape custom plugin metrics, just not sure about that. but for 1.x it should be really useful and apperciated!
I haven't checked each of the metrics that you provided, but they all seem reasonable to add.
If it is not a problem, please split them into 3 separate PRs (this will make PR review process easier):

logstash_stats_pipeline_plugins_outputs_bulk_requests_successes and logstash_stats_pipeline_plugins_outputs_bulk_requests_with_errors
rest of the logstash_stats_pipeline_plugins_*
other metrics that you mentioned

Thank you for contributions to this project!
Please tell me if you need any help with them. Also, if you want to have a faster way of communication with me and/or want to ask questions that aren't directly related to this repo, you can find my email in my github profile. I am working in GMT+2 timezone, so I am not always responsive.
Again thanks for all the contributions!

Thanks! Agree on the pre-calculated stats, if they're aggregating another metric... However, the load average really shouldn't be considered a "CPU" load as much as a "system load", as it's the metric of processes using or waiting on the CPU. https://scoutapm.com/blog/understanding-load-averages is a good article on it as well. Situations like high I/O waits will manifest as low CPU utilization but very high system load averages - a common failure mode for data pipeline systems. (Though likely more common in Elasticsearch than Logstash).
I can make commits into a tranche of small PRs, which helps me get them out while doing all the other things! And for v2.x custom metrics, especially for plugins is a great idea. For these, I'm only planning to gather common metrics to all pipeline inputs/filters/outputs, with the exception of the Elasticsearch/OpenSearch output plugins.


Web: After typing a message in a thread, keyboard focus moves to the main timeline composer

With rich text editor labs flag enabled
Open a thread, and type a message
The keyboard focus is now in the main timeline composer.
I would expect the keyboard focus to stay in the same composer where I typed my message (in the thread).

Oops, moved to https://github.com/vector-im/element-web/issues/23755


Add graceful handling of exceeding browser Performance API 150 entry limit

See https://github.com/nesk/network.js/issues/58

Let me know if I should run the build and update the /dist assets...


feat: 🎸 Support for TypeScript

✅ Closes: #244
Going to mark this PR as a Draft since I ran out of time to do more thorough testing. This seems to work as expected. I might be missing some library types packages.
Would appreciate it if anyone else would be so kind to pull these changes down and test them out.

@SeanGroff I pulled this & converted SQFormDialog (quick & messy) to TS - storybook was broken, but changing the webPackFinal in it's main.js to the following seems to fix it:
`webpackFinal: config => {
config.module.rules = [
...config.module.rules,
{
test: /.jsx?$|.tsx?$/,
exclude: /node_modules/,
use: {
loader: 'babel-loader',
options: {
presets: [
'@babel/preset-env',
'@babel/preset-typescript',
'@babel/preset-react'
]
}
}
}
];
return config;

}`

Also, FYI, I had to force TS to ignore some of the JS imports that it can't get typings from like this:
// @ts-ignore
import SQFormDialogInner from './SQFormDialogInner';
// @ts-ignore
import {useInitialRequiredErrors} from '../../hooks/useInitialRequiredErrors';

Found a few things:

This could be added to .eslintrc.json

"extends": [
    ...
    "plugin:@typescript-eslint/recommended"
  ],

For tests to work,

ts-jest and some jest config changes need to be added, https://basarat.gitbook.io/typescript/intro-1/jest
@types/testing-library__jest-dom for the jest matcher types

npm packed it into SRTS2 and I'm getting type warnings!
Also, storybook looks to be working well and grabbing types for the controls panel. Nice!

@SeanGroff Would this be considered a breaking change for any projects that use TS because of the added types? If they aren't using the proper types it could cause errors that would prevent a build

In our project, I had a file at root declare module '@selectquotelabs/sqform';  that prevented any type warnings at all for the lib, had to remove it to receive any. I think I could theoretically upgrade to a TS based sqform, leave that file there, and still use the wrong types somewhere if I was, but not positive.

In our project, I had a file at root declare module '@selectquotelabs/sqform';  that prevented any type warnings at all for the lib, had to remove it to receive any. I think I could theoretically upgrade to a TS based sqform, leave that file there, and still use the wrong types somewhere if I was, but not positive.

Ah, yeah the same was true when I tried it in my project. So in that case we it wouldn't be a breaking change, but they'd need to know about remove that d.ts file in order to unblock the types

In our project, I had a file at root declare module '@selectquotelabs/sqform';  that prevented any type warnings at all for the lib, had to remove it to receive any. I think I could theoretically upgrade to a TS based sqform, leave that file there, and still use the wrong types somewhere if I was, but not positive.

Ah, yeah the same was true when I tried it in my project. So in that case it wouldn't be a breaking change, but they'd need to know about removing that d.ts file (if it exists) in order to unblock the types

Ah yes....I think the right thing to do is NOT merge this to master until we've fully converted over to TypeScript.
So when we create an issue with a task list we need to make sure to specify the instructions of working against this branch, and PRing to this branch.
Then once we're fully migrated to TypeScript, merge this PR

I don't think we want to tell consumers to manually add a .d.ts file. Then remove it at a later point.

True. I assumed that if anyone is using this library with TS they already have a d.ts for it, and if they're using it with JS they won't have typechecking so it wouldn't matter.

Updated from master to fix the merge conflicts

Resolved some merge conflicts with that merge, it was only consuming the onTertiaryClick in our dialog so I figured it was safe to change the relevant propTypes into types. Also I managed to commit with formatting issues, pushed that change as well.


chore(MeasureTheory.Constructions.BorelSpace.Basic): split file

The file MeasureTheory.Constructions.BorelSpace.Basic was approximately 2500 lines long. There is somewhat independent content related to order topologies, metrics, and reals, ennreals, and nnreals. This PR proposes to spilt the file according to those boundaries: Basic < Order < Real < Metric. (Short module docstring summaries are added to the new files.)

Great to see more file splits, thank you for doing this! Friendly reminder that you can remove the style exception for this file. :-)
TL;DR: remove this line:
https://github.com/leanprover-community/mathlib4/blob/f1d422f45ad94f00f9b1ed78b9e28f0fb3c26ab8/scripts/style-exceptions.txt#L72

Great to see more file splits, thank you for doing this! Friendly reminder that you can remove the style exception for this file. :-)
TL;DR: you can remove this line now:
https://github.com/leanprover-community/mathlib4/blob/f1d422f45ad94f00f9b1ed78b9e28f0fb3c26ab8/scripts/style-exceptions.txt#L72

This is my first attempt of a large file split, so I don't yet guarantee that I manage to pull this out --- the PR is a "work in progress". But I got started with this attempt, since I recently added something in this long file and then felt a bit guilty.

As a test of the no_lost_declarations script, this is the output:

- theorem measure_eq_measure_preimage_add_measure_tsum_Ico_zpow [MeasurableSpace α] (μ : Measure α)
+ theorem measure_eq_measure_preimage_add_measure_tsum_Ico_zpow {α : Type*} [MeasurableSpace α]

1  added declarations
1  removed declarations
188  paired declarations

As a test of the no_lost_declarations script, this is the output:
* - theorem measure_eq_measure_preimage_add_measure_tsum_Ico_zpow [MeasurableSpace α] (μ : Measure α)
* + theorem measure_eq_measure_preimage_add_measure_tsum_Ico_zpow {α : Type*} [MeasurableSpace α]
* 1  added declarations
* 1  removed declarations
* 188  paired declarations

Thanks! Where can I find and run the no_lost_declarations script? I looked in the /scripts folder and could not see it there, and I searched Zulip and found nothing...
The result looks pretty reassuring, right? Except I'm not totally sure why the one removed-then-added declaration difference. The type signature is not displayed completely, but there seems to be a small difference at the start... However, when I compare my VS Code hover with Loogle result, these look identical modulo a universe variable name. So I'll be reassured unless someone tells me otherwise :smile:. Thanks a lot for running this and letting me know of the existence of such a script!

@kkytola, I only now saw your message, since I did not get/lost the notification.
The script does not exist on master: it is only present in #12515.
The reason for the difference is that the script is text-based, so it is highlighting that the two lines are not identical: indeed,

the first contains (μ : Measure α), while the second does not;
the second contains {α : Type*}, while the first does not.

So, as long as these changes are ok (which presumably they are, since there is likely a variable and a line-break difference), the script essentially is telling you that no declarations were lost!
If you want to run the script locally, you can check it out from the PR and then run it as follows:
git checkout origin/adomani/no_lost_declarations scripts/no_lost_declarations.sh
./scripts/no_lost_declarations.sh

Note that the code above will add the file scripts/no_lost_declarations.sh so you would have to make sure that you do not PR that file as well!

Please merge master to fix the conflict. Then let's merge that PR soon.

Thanks!
bors r+


Fix gitCredentialFill hanging when it tries to prompt credentials in execSync

This PR fixes Issue #153

The issue mentions Ubuntu  18.04, but I have only tested this on Windows 10. I can setup an Ubuntu machine when I have more time later to confirm this fixes the command on there also, but I don't have access to a MacOS machine that can test this currently.

Description of the PR:
This changes execGitCredentialFill to set the GIT_ASKPASS environment variable to the askpass-empty.sh script from the VSCode git extension when calling execSync. By making AskPass use askpass-empty.sh, the credentials prompt should be skipped when credentials are not set and return an empty string for the the password. So, it should make execGitCredentialFill a readonly function instead of getting hung when git credential fill tries to ask for credentials.
Additional context:
When git credential fill is executed and there are not any credentials, it tries to request credentials from the user. Unless the AskPass tool is configured correctly, execSync gets stuck when there are no credentials, because it is waiting on input, but execSync didn't get any output yet. So they both just sit there waiting on a response from each other, without knowing each other is waiting.

I decided to look into this a little more, because I wanted to know why the change worked, and I am now not positive this is the right way to fix it. It may fix some, but I think the GIT_ASKPASS tool is the main problem. I don't know how to make it consistently prompt for username/password yet. VSCode's Git extension has a script that lets it return an empty string for the password if the credentials aren't set, %LOCALAPPDATA%/Programs/Microsoft VS Code/resources/app/extensions/git/dist/askpass-empty.sh, but I guess it depends if the prompt should happen or not.

I think the disabled by default that you did is the way it should have been handled. The git credential tool itself seems a little buggy anyway, such as giving an input error when trying to use it in Powershell without a script. I didn't even know about git credential store, until debugging this, so some other tool must have set the one I had stored at some point, but I have no idea which one.
I cut my change down to just the attempt at setting the askpass-empty.sh script from the git extension, but it doesn't guarantee that someone hadn't configured theirs to work using one of the ways other than the environment var. Now that the feature is disabled by default, maybe it is fine to assume the ones that enable it, or at least enough that it won't keep getting reported, will already have set their credentials or at least know how. If it is fine to just assume users enabling it know what their doing or can figure it out, since the README does already say "when you've already authenticated with github.com", this PR can just be closed.

Closing this PR per the previous comment from @marklb.


chore: Add sponsors section to readme

Should this be added to all plugin readmes too so it shows up on crates.io / npm too?
cc @nothingismagick

Actually yes, with the mirrors in place this should be in all readmes. gonna add that in a few

i kinda dislike the auto review dismissal 😅

thanks :)


[KOGITO-1347] Test Data index using external Infinispan

https://issues.redhat.com/browse/KOGITO-1347
Many thanks for submiting your Pull Request :heart:!
Please make sure that your PR meets the following requirements:

[x] You have read the contributors guide
[x] Pull Request title is properly formatted: [KOGITO-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[ ] Your feature/bug fix has a unit test that verifies it
[x] You've tested the new feature/bug fix in an actual OpenShift cluster

@radtriste Updated according to comments.

The Infinispan CR is deployed as part of https://github.com/kiegroup/kogito-cloud-operator/pull/315/files#diff-99148689e28fa4a3003f7ae3db113e27R44 .
It is attached by specifying uri parameter in Kogito CR/--infinispan-url in CLI.

Minor adjustments (merging Infinispan secret and Infinispan instance steps)

Integrated secret creation into Infinispan instance step.
Rebased to latest master.

@radtriste @MarianMacik Please take another look.

@sutaakar seems there are conflicts. can you please rebase ? :)
@MarianMacik are you good with that one ?

Rebased and still works.
@radtriste Ready to be merged.


Gem names and namespaces should be consistent

The gem name should match the namespace used, gapic-generator vs. Google::Gapic::Generator. Do we want to prefix the gem names with google-? Or do we want to remove the top-level Google:: module from the namespace?

Fixed by #185


No support for order by ... nulls first / last

Cockroachdb doesn't support ORDER BY with NULLS FIRST or NULLS LAST (https://github.com/cockroachdb/cockroach/issues/6224). If the feature won't be added, we could add a feature flag to Django to skip these tests and raise a helpful error message if the programmer tries to use this feature in Django.
Example traceback:
======================================================================
ERROR: test_order_by_nulls_first (ordering.tests.OrderingTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tim/code/django/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
psycopg2.errors.SyntaxError: at or near "nulls": syntax error
DETAIL:  source SQL:
SELECT "ordering_article"."id", "ordering_article"."author_id", "ordering_article"."second_author_id", "ordering_article"."headline", "ordering_article"."pub_date" FROM "ordering_article" ORDER BY "ordering_article"."author_id" ASC NULLS FIRST, "ordering_article"."headline" ASC
                                                                                ^

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/tim/code/django/tests/ordering/tests.py", line 127, in test_order_by_nulls_first
    [self.a1, self.a2, self.a3, self.a4],
  File "/home/tim/code/django/tests/ordering/tests.py", line 97, in assertQuerysetEqualReversible
    self.assertSequenceEqual(queryset, sequence)
  File "/opt/python3.7.0/lib/python3.7/unittest/case.py", line 957, in assertSequenceEqual
    len1 = len(seq1)
  File "/home/tim/code/django/django/db/models/query.py", line 256, in __len__
    self._fetch_all()
  File "/home/tim/code/django/django/db/models/query.py", line 1242, in _fetch_all
    self._result_cache = list(self._iterable_class(self))
  File "/home/tim/code/django/django/db/models/query.py", line 55, in __iter__
    results = compiler.execute_sql(chunked_fetch=self.chunked_fetch, chunk_size=self.chunk_size)
  File "/home/tim/code/django/django/db/models/sql/compiler.py", line 1100, in execute_sql
    cursor.execute(sql, params)
  File "/home/tim/code/django/django/db/backends/utils.py", line 67, in execute
    return self._execute_with_wrappers(sql, params, many=False, executor=self._execute)
  File "/home/tim/code/django/django/db/backends/utils.py", line 76, in _execute_with_wrappers
    return executor(sql, params, many, context)
  File "/home/tim/code/django/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
  File "/home/tim/code/django/django/db/utils.py", line 89, in __exit__
    raise dj_exc_value.with_traceback(traceback) from exc_value
  File "/home/tim/code/django/django/db/backends/utils.py", line 84, in _execute
    return self.cursor.execute(sql, params)
django.db.utils.ProgrammingError: at or near "nulls": syntax error
DETAIL:  source SQL:
SELECT "ordering_article"."id", "ordering_article"."author_id", "ordering_article"."second_author_id", "ordering_article"."headline", "ordering_article"."pub_date" FROM "ordering_article" ORDER BY "ordering_article"."author_id" ASC NULLS FIRST, "ordering_article"."headline" ASC
                                                                                ^

Would be great to add a test feature flag for this one as it's not going to be fixed in the near future.

The only caveat is that I'm doubtful that the feature flag would be backported to Django 2.2 and 3.0 which are already branched. Django master will be Django 3.1 to be released in August 2020. Do you think it's worthwhile to add the feature flag even if it won't be backported? If not, we can mark the relevant tests as expected failures until cockroachdb adds the feature (users will see the SQL error if they try to use it).

@timgraham Heads-up regarding the addition of a feature flag for this: https://github.com/django/django/commit/7286eaf681d497167cd7dc8b70ceebfcf5cd21ad


Doesn't work on Raspberrypi 2 B

Hi, and thanks a lot for your code.
I've tried to make it run on a Raspberry pi, but it won't.
There is no issue with the compilation, but, when I try to execute it, it give me the help informations.
I've take on my main computer the exact same configuration using scp to transfer from one to the other, recompil' it, and there are no issues on my main.
Configs:
Raspberry Pi 2 B v1.1  with last Stable Raspbian
gcc: gcc (Raspbian 4.9.2-10) 4.9.2
Main :  MSI GP62-6qe  with Linux Mint 18.1 Cinnamon
gcc: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
I've added into your code to check lots of printf() to get me where it goes on the raspberry and which are the values, and what it do is in the main() is going in the default case, even with a parameter.
If you need more informations, contact me, I'll try to figure what is happening, maybe just because of a bad gcc version, idk..

Thank you for pointing this out. It has been fixed in version 0.0.7 and is confirmed to work on a rpi 2 running Raspbian.
The problem was that I was using 'char opt' to store the result of getopt(). On x86, a char defaults to signed char. On ARM, it defaults to unsigned char. This was making the result of getopt "opt" store the value of 255 rather than -1 to signify that it was done parsing arguments because negative numbers are impossible with unsigned types.