Question regarding iPhone 7

If i jailbreak my new iPhone 7 on 10.1.1 right now will I have issues using the new jailbreak for the iPhone 7 when it comes out? (the updated 10.1.1 one). Aka should i use the beta 3 one or wait for this updated one?

#360 close this.

@kpwn is going to eventually make an updated jailbreak for iPhone 7. However, I wouldn't recommend to download the beta since it isn't meant for iPhone 7 and the Yalu+Mach_portal isn't a complete jailbreak and can bring problems. I would just stay non jailbroken for now until something is updated for you.

However, this isn't Code related at all. Next time try Reddit. #162 #64

Since this is probably going to be closed anyway, I'm curious as to what needs doing codewise to add support for iphone 7 in Yalu102. Is it a case of adding the memory protection exploits from Yalu1011 and merging them into yalu102 or is that way off? Wonder if it eventually be put on GitHub as I remember Luca saying he didn't want to opensource the memory protection stuff.

It won't work because the KPP exploit used in the 10.2 jailbreak is patched on iPhone 7 but persists on all other 64bit devices

@NickGP Yes, sorry I should have been more specific. I know that it won't work on 10.2 - I meant 10.1.1, like the readme states it will support in the future. In theory if the exploits work 10.0-10.2, then the iPhone 7 with the additional exploits on 10.1.1 should work fine, I think that is the plan, but its not really been confirmed (that Yalu102 exploits will be used over trying to fix Ian Beer's exploit on 10.1.1), let alone the technical details before.

My question wasn't when, it was regarding the compatability of the two....

@NickGP this is code related as the incomapabilities would arise from different code in Yalu102 compared to Yalu b3

I'm sure that kpwn is aware that plenty of people are already on beta 3 and will make things work properly.

That might be true @XAVERRenogadeAngle, except you can't really be sure on that. People might've already upgraded to beta 7 because reboots are mean to semi-tethered jailbreaks (and I'm so glad @coolstar actually made a stashing tool that can replace the traditional stashing Cydia uses, making stashing theoretically safer).
@andrewwiik, Beta 3 should work on your iPhone 7, but the next update isn't until @kpwn gets his so-called "mixtape" working, which might take another day or two. Or an entire week. Don't go for the mach_portal+yalu jailbreak because it's unstable, and there's no chance of a gamma release for that jailbreak now.

It is for developers actually, if its your main phone then dont but if its about updating tweaks then go ahead.

Not code related issue, support has not been added yet. I'm sure Luca has an upgrade plan from mach_portal for iPhone 7.
#162

This is code related but not in the way #162 and #64 intended the issues section to be.
But, there should be no problem switching between the two. Just like Pangu 9.3.3 users switching to Luca's safari jailbreak method. Different code, still works. I don't think you'll encounter issues switching between the two (as so far no 6s users have experienced issues).

6s users most likely clean restored to 10.2 though, I expect the majority of 6s users did not stay on 10.1.1, so any issues reported would be a minimum compared to that of iphone 7 users.

@kpwn can you just settle this once and for all, can i use b3 on yalu+mach_portal and upgrade to yalu10 when supported without any issues or not?

#162

I'd wait. But #162 #64

#162

@tangalbert919 well it isn't code related.

Well, it doesn't hurt to explain why you referenced the issue in the first place. That might help prevent MORE issues like this in the future (if people bothered to read).


First WHMCS client fails to upgrade/delete OpenNebula users/groups

Description
When creating the first WHMCS client and purchasing a product, the initial user will be set up properly but any subsequent actions such as upgrading, downgrading, or removing the service will fail.  Internally this is happening because the first user gets associated with the ID 0 while upgrading, which is the oneadmin user and group. Further clients do not see this issue and services are upgraded/downgraded/deleted properly.
To Reproduce
Install fresh WHMCS and WHMCS Tenants, configure a server and 2 products, then create a client account and order the product.  After that, try to upgrade the product and check OpenNebula after where the quotas are unchanged. Canceling the order
Expected behavior
This client should be able to upgrade and delete.
Details

Affected Component: WHMCS Tenants Module
Hypervisor: N/A
Version: 6.4, 6.6 (Tenants Module v1.1.3)

Additional context
Add any other context about the problem here.
Progress Status

[ ] Code committed
[ ] Testing - QA
[ ] Documentation (Release notes - resolved issues, compatibility, known issues)

Cannot reproduce any longer


Failure to fetch GPG causing build errors

2020-12-08T20:09:57.1126032Z #8 131.2 gpg: keyserver receive failed: Address not available

Common error that we should do something to mitigate, as its a pain to run a build twice.

Seems to be fixed, and is more stable now.


Input buttons margin-bottom adjustment.

Inline a.btn and input[type=submit],input[type=reset],input[type=button]
Before
Firefox:

Chrome:

After
Firefox:

Chrome:

Same issue as https://github.com/twitter/bootstrap/issues/1543

Closing this—I've removed the bottom margin in 2.0.1-wip and will continue to work on alignment cross-browser.


Update GCSTs for sumstats files and folders on FTP

These two studies have had their GCSTs manually changed in the latest data release, but the FTP folders and the sumstats files are still named with the previous GCSTs.

previously GCST90454341 --> should be changed to GCST010098 - trait_description: Breast cancer
previously GCST90454343 --> should be changed to GCST010100 - trait_description: Breast cancer (triple negative or BRCA1-positive)

Tasks:

change sumstats filenames
move sumstats to correctly-named folders on FTP
change GCSTs wherever they appear in the YAMLs

[x] change sumstats filenames
[x] move sumstats to correctly-named folders on FTP
[x] change GCSTs wherever they appear in the YAMLs and md5sums
[x] copy harmonised folder and do the above tasks for harmonised folder as well

They should be available in the public FTP in a couple of days.


Useful CertSrvH constants is not available to the developer

To properly use ICertServerPolicyManaged.SetCertificateProperty method, the PropertyType constant must be specified.
Currently those constants are stored in CertSrvH class at CertSrvH.cs, AND the class is not available.
On usage, the compiler retuns error: CS0122: 'CertSrvH' is inaccessible due to its protection level.

How do you feel about making the class public ?
How do you feel about changing CertSrvH class into CertSrvH enum ?
How do you feel about adding to documentation here notice, that not all properties can be changed, due to microsoft's restrictions: ICertServerPolicy::SetCertificateProperty

2. How do you feel about changing CertSrvH class into CertSrvH enum ?

positively, because it makes sense.

3. How do you feel about adding to documentation here notice, that not all properties can be changed, due to microsoft's restrictions: ICertServerPolicy::SetCertificateProperty

Link to corresponding Microsoft page is provided at the bottom:

isn't this sufficient?

How do you feel about adding to documentation here notice, that not all properties can be changed, due to microsoft's restrictions: ICertServerPolicy::SetCertificateProperty

Link to corresponding Microsoft page is provided at the bottom:
isn't this sufficient?

Oh, sorry, don't know how I missed it.
Thus seems we aggreed on points 1 and 2.

Thus, seems we agreed on points 1 and 2.

yes, it makes sense to make it enum and public.


Running with vision occasionally got freeze

Hi, I am trying to run your code with vision input by setting . I have set the resolution to 64x64, but the screen sometimes got freeze and stuck for about a few second before the program recover back to normal vision output. Do you have any ideas about how to solve it? BTW without vision it works perfectly fine :)
Thanks in advance.

Having similar behavior.
One more symptom -- more time it works (inside a binary run), more it freezing
However, I don't see memory growth which I would expect to see with memory leak

I also encountered the same problem.
The problem I found is that the function "visionUpdate()" is called too many times inside ReMange().
if( getVision() ){ 	    // GIUSE: TODO: this assignment needs to be done ONLY ONCE!! TAKE THIS OUT somehow!         car->vision = ReInfo->vision; 	    //visionUpdate();     }
Simply comment the visionUpdate() line and add "if (getVision()) visionUpdate();" to "vtorcs-RL-color/src/libs/raceengineclient/raceengine.cpp#L846"


Update README.md

Link on main page wasn't working, also added sirens emoji for good measure 😅

@manuelrego27 are you able to merge? still need to fix some settings in the project

No, github says "Only those with write access to this repository can merge pull requests."
I don't mind waiting though, it was more so you don't forget this detail in the middle of everything else :D


Internal error: Failed to run on the given Interpreter: Regular TensorFlow ops are not supported by this interpreter. Make sure you apply/link the Flex delegate before inference.

I use tf.image.combined_non_max_suppression in my model. I can transfer it to tflite. But when I use it in Android or use python tf.lite.interpreter, I got the issue.

How can I resolve it?

Looks like the model is converted with the Select TF option. In such case, the android application requires an extra requirement. See also https://www.tensorflow.org/lite/guide/ops_select.
dependencies {
    implementation 'org.tensorflow:tensorflow-lite:0.0.0-nightly-SNAPSHOT'
    // This dependency adds the necessary TF op support.
    implementation 'org.tensorflow:tensorflow-lite-select-tf-ops:0.0.0-nightly-SNAPSHOT'
}

@abattery    I did it. I ran it successfully. Thank you very much


Replace use of `` with a form of system that does not spawn a shell

At the moment dragonfly uses backticks to execute shell commands. Would there be interest in moving to system, in particular the form of system that does not spawn a subshell ?
For example instead of
`convert -resize 20x10 #{old_path} #{new_path}`

system("convert", "-resize", "20x10", old_path, new_path)

The primary reason I'd like to do this is security: spawning a shell gives you way more rope to hang yourself with, whether it be not escaping things properly or vulnerabilities in the underlying shell (Hi shellshock!)
It would restrict things - you wouldn't be able to, for example, have an processor that strung together multiple shell commands.
At the very least I would like this to be an option. I'd be happy to work on this if there is interest

I for one have been noticing a problem with Zombie processes! ZOMG!  It is hard to trace down but when running ps aux | grep Z I can see defunct shell process but it then quickly removed.  I also have seen a correlation in my graphs between an increase in Zombie processes and System CPU going waaaay up.  At that point I have to restart my Ruby app to get it to recover.  I was thinking of wrapping my main dragonfly calls with Signal() but was wondering if you were heading down this direction as well.
Thanks

Ah, I see you are using open3.  So I am back to square one :)

yeh - it doesn't use backticks - this is just for Ruby 1.8.7, and support for 1.8.7 will be removed at some point soon anyway. It uses popen3 https://github.com/markevans/dragonfly/blob/master/lib/dragonfly/shell.rb#L46
you can't have a processor that strings together multiple shell commands, unless you explicitly say so - see http://markevans.github.io/dragonfly/processors/#implementing-the-processor "Using shell commands"


Remove serial_test_derive from deps

serial_test since 0.3 includes serial_test_derive and lets you use the macro without needing to directly include serial_test_derive

sounds good to me, but i'll leave this up to @joseluis ! thanks for your contribution!

thank you!


any plans for LLaMA training example script?

Or, if there's any other related resources you could point me to😄

Hi, I will be releasing some new stuff soon, that will be a decent improvement over the current library, and will include better support for llama training. I just pushed a script that you can use for now though. I would also point you to EasyLM, another Jax library for training LMs developed by a collaborator of mine. EasyLM also has support for llama training in Jax.


Fix iteration issues

When you delete items from an iterator you need to make sure the
pagination is recalculated properly. Otherwise the page will keep
increasing and you will reach a page with no elements skipping
many items that have not been evaluated.
With this commit we keep deleting only the first page until you get
no results. The filter "created" has been moved to the request to ensure
that GitHub is the one that computes properly the page to be deleted.
The maxWorkflowsToKeep option has been deleted because enters in
conflict with this implementation.

Looks good. Thank you for your contribution.
The maxWorkflowsToKeep logic was indeed broken so I will add a different implementation.


NH-76572 Applied community feedback back to our current code

Applied configgrpc for better configuration support
Applied ToClientConn for better gRPC client creation
Removed the usage of depreciated type & layer from apm-proto decoding
Removed the usage of depreciated function call Subjects in SystemCertPool
Sync-ed with the current upstream PR (More mock unit tests for gRPC responses)

NH-76572

Just notice https://github.com/open-telemetry/opentelemetry-lambda/pull/1452 was merged 🎉 ! Do you want to squeeze a resync with upstream into this PR too @jerrytfleung?

open-telemetry#1452

Not this PR. I will have another PR to do the sync with upstream.


CANNOT CREATE FOLDER OR FILE FROM THE PANEL - SOLUTION

$sudo chmod -R 777 <project_dir_name>.
This gives the access to the workspace to create files and folder

Please see our issue reporting guideline.


Error on generating schema (Multiple enums with the same name)

Hi , when i try to execute the command i am getting error
command :
schemats generate -c mysql://root:root@localhost:8889/labourindia  -t kc_blogs -o osms.ts
Error: Multiple enums with the same name and contradicting types were found: status: ["1","0"] and ["0","1"]
at /usr/local/lib/node_modules/schemats/src/schemaMysql.js:153:39
at Array.forEach ()
at MysqlDatabase. (/usr/local/lib/node_modules/schemats/src/schemaMysql.js:147:40)
at step (/usr/local/lib/node_modules/schemats/src/schemaMysql.js:32:23)
at Object.next (/usr/local/lib/node_modules/schemats/src/schemaMysql.js:13:53)
at fulfilled (/usr/local/lib/node_modules/schemats/src/schemaMysql.js:4:58)

Seeing the same issue here:
Error: Multiple enums with the same name and contradicting types were found: type: ["REQUEST","RESPONSE"] and ["INTERNAL","EXTERNAL"]
    at /Users/rpitt-mbp/.npm/_npx/29285/lib/node_modules/schemats/src/schemaMysql.js:153:39
    at Array.forEach (<anonymous>)
    at MysqlDatabase.<anonymous> (/Users/rpitt-mbp/.npm/_npx/29285/lib/node_modules/schemats/src/schemaMysql.js:147:40)
    at step (/Users/rpitt-mbp/.npm/_npx/29285/lib/node_modules/schemats/src/schemaMysql.js:32:23)
    at Object.next (/Users/rpitt-mbp/.npm/_npx/29285/lib/node_modules/schemats/src/schemaMysql.js:13:53)
    at fulfilled (/Users/rpitt-mbp/.npm/_npx/29285/lib/node_modules/schemats/src/schemaMysql.js:4:58)
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

I am encountering the same error. The reason is that one or more different tables have the same enum column names, in my case it was 'type'. Here is the query you can run to determine the culprits:
SELECT
  col.table_schema AS database_name,
  col.table_name,
  col.ordinal_position AS column_id,
  col.column_name,
  col.data_type,
  TRIM(
    LEADING 'enum'
    FROM
      col.column_type
  ) AS enum_values
FROM
  information_schema.columns col
  JOIN information_schema.tables tab ON tab.table_schema = col.table_schema
  AND tab.table_name = col.table_name
  AND tab.table_type = 'BASE TABLE'
WHERE
  col.data_type IN ('enum')
  AND col.table_schema NOT IN (
    'information_schema',
    'sys',
    'performance_schema',
    'mysql'
  )
  AND col.table_schema = 'your-database-name'
ORDER BY
  col.column_name,
  col.table_schema,
  col.table_name;

I am going to try to rename my columns since there's not that many of them, and this is something we try to do anyways in this project (thing_status instead of just status for clarity). What's weird was this is the command I was running:
bash> schemats generate -c mysql://root@localhost/db-name -t users -o users.ts

Which I would think would only scan the table I specified which doesn't have one of the offending columns, but I guess not.


Adding downloading pdfs from a submission id

Advise on how to test - tested locally for now

@andrew8bit want to clean up the example (the last example doesn't belong in the example file and I think that file is named with a ,py instead of .py) and merge this? Ideally you'd also have a test for this. Or can close it for now

@andrew8bit want to clean up the example (the last example doesn't belong in the example file and I think that file is named with a ,py instead of .py) and merge this? Ideally you'd also have a test for this. Or can close it for now

@andrew8bit want to clean up the example (the last example doesn't belong in the example file and I think that file is named with a ,py instead of .py) and merge this? Ideally you'd also have a test for this. Or can close it for now

wow, this must've been made a long time ago. went ahead and renamed and cleaned example.
we already have a test for this in the downloader, iirc, this PR is purely for example


View with atom only should have styles applied

Basically this test should pass... I think?
    func testStylistMatches_thisShouldPass() throws {
        let stylist = Stylist()

        var didApplyGeneral = false
        var didApplySpecific = false
        stylist.addStyle(identifier: "*/*/element/atom") { view -> AnyView in
            didApplySpecific = true
            return AnyView(view.foregroundColor(.red))
        }

        stylist.addStyle(identifier: "*/organism/*/atom") { view -> AnyView in
            didApplyGeneral = true
            return AnyView(view.foregroundColor(.blue))
        }

        let stylable = Stylable(AnyView(Text("Test")), identifier: "atom")
        _ = stylist.style(view: stylable, identifier: "atom")

        XCTAssertFalse(didApplyGeneral)
        XCTAssertTrue(didApplySpecific)
    }

Yes, yes it should - "atom" should be equivalent to "*/*/*/atom".
I'll take a look.

Wait - no it shouldn't match. "*/element/atom" is specific to atoms which are inside element. Just passing in "atom" by itself doesn't match that criteria.
@cdemetriadis or @atomoil might need a vote here :) And if I'm wrong, then we probably need to do some fairly large work on rewriting StylistIdentifier!

Shouldn't write bugs with half a bottle of wine in me!

@deanWombourne is correct */*/element/atom is for atoms inside element.
With this system a developer should always be as specific as possible (to allow for overrides in specific places) and a designer should provide a general case eg */*/*/atom in the design and then use overrides for specific cases (eg when in element as in the example)

Shouldn't write bugs with half a bottle of wine in me!

LOL. That’s usually how I introduce bugs 😬

also, phew - didn't like to think about the implications of this!
also also, only half?

Correct, this should not pass.

https://images.app.goo.gl/M1jv2AfoSZtWYxtN7


Write on image

Is it possible to write on an image? I added a full screen image (A4) to my page wih ImageOptions but when trying to write on it, a page break occurs. Any hint?

The documentation for ImageOptions() says

If flow is true, the current y value is advanced after placing the image and a page break may be made if
necessary.

I think what you want to do is set flow to false, and then use SetXY() to reposition the current position to write text on top of your image.

Thanks! That's what I was looking for.


Fix problem with passes width

Fixes #27

@VictorLamoine Ready for review

@KevinBollore: just curious, but could you explain a bit how this fixes the problem exactly?

@gavanderhoorn:
In bezier library, one of the VTK function generated a number of lines ( we just have to give an origin, a normal vector and geometrical limits ) and this number of lines is computed. Also, a wrong number of lines was sometimes computed.
I have just used an other function from VTK which created line from a precise distance from the center of our object ( Here too, we have to give an origin and a normal vector ) . Finally, I have just looped this function and add an offset which is the width that we want, so the width is always correct.
Hope it is clear, if not, don't hesitate to say it to me.

I propose cut_line_width_ to replace effector_diameter_.
cut_line_machining_ could be great to, it could matches with other process (3D printing?).

At least, we will use for the moment working_line_width_

@VictorLamoine Ready for review


Add orml-treasury

The treasury pallet in FRAME does not support multiple currencies, would a multi-currency ORML alternative be of interest? We would also like to simplify the implementation to remove the SpendPeriod such that funds approved for spending are transferred instantly.

That sounds useful. Could you make a pallet design so we can iterate on it first before the actual implementation?

AssetHub is going to have multi asset treasury so no we should just use the pallet over there.


Use evaluateJavascript for WebView postMessage, if available

loadUrl's behavior on Android 4.4+ is to URL decode the input prior to evaluating it, so a %22 in the input will be decoded to ". Since it is not escaped, this quote introduces a syntax error into the javascript, preventing execution.
This changes postMessage to use evaluateJavascript on Android 4.4+ to fix #19611
Test Plan
Manual:

react-native init Test, cd Test, replace App.js with example from #19611
yarn add github:jordoh/react-native#android-postMessage-evaluateJavascript and set up to build react-native from source
react-native run-android and verify that pressing the postMessage with %22 button changes the text in the WebView to "success".

Related PRs
There have been PRs to implement a similar change in injectedJavaScript, which appear to stall on the discussion of whether the inconsistency in behavior is acceptable:

https://github.com/facebook/react-native/pull/9945 (closed)
https://github.com/facebook/react-native/pull/12321 (open)

However, per this issue, my understanding is that Android before 4.4 did not URL decode the string passed to loadUrl, so calling loadURL would not suffer from #19611 - though there may be other differences in the behavior of evaluateJavascript and the pre-4.4 loadUrl that I am unaware of.
Release Notes
[ANDROID] [ BUGFIX] [WebView] - Fix "%22" in postMessage failing on Android 4.4+

CC @shergin in case you have some spare cycles to take a look at this. It would be great to get this to master in time to be cherry-picked for 0.56.

Hi @mdvacca - sorry to bother, but it looks like you've reviewed code touching the Android WebView recently - any chance you could take a look at this?

@jordoh Would it be possible to fix the other invocation of root.loadUrl("javascript:", the one that handles injectedJavaScript as well?
That would fix #20365 on Android 4.4+

@jordoh Sent a PR to this PR here: https://github.com/jordoh/react-native/pull/1

Hi @LinusU - I like your approach, given the inclusion of the < 4.4 escaping. :+1:
I left those other spots out here since the previous PR discussions (#9945 and #12321) stalled out on those updates, but it looks like your changes address the issues raised in those PRs.
I'll leave this PR open with the hope that something gets merged, but definitely recommend that #20366 gets merged instead to supersede this PR.

WebView PRs are on hold pending approval of the WebView proposal at https://github.com/react-native-community/discussions-and-proposals/pull/3


Make q configurable for peruser dbs

Overview
At the moment, couch_peruser-managed databases are created with the default q value (8 is the CouchDB default, but users might change that). Now, in a peruser system, we recommend lower q because of all the file-descriptor overhead with larger q when peruser dbs are traditionally small-ish.
This PR is aimed to introduce new item in couch_peruser config section to specify the q value when creating peruser database. The default value is 1 instead of default value in cluster/q.
[couch_peruser]
; If enabled, couch_peruser ensures that a private per-user database
; exists for each document in _users. These databases are writable only
; by the corresponding user. Databases are in the following form:
; userdb-{hex encoded username}
enable = false
; If set to true and a user is deleted, the respective database gets
; deleted as well.
delete_dbs = false
+; set a default q value for peruser-created databases that is different from
+; cluster / q
+; +q = 1

Testing recommendations

make check skip_deps+=couch_epi apps=couch_peruser
======================== EUnit ========================
module 'couch_peruser_test'
  couch_peruser test
Application crypto was left running!
    couch_peruser_test:165: should_create_anon_user_db_with_default...[0.002 s] ok
    couch_peruser_test:166: should_create_anon_user_db_with_default...ok
    couch_peruser_test:155: should_create_user_db_with_default...[0.003 s] ok
    couch_peruser_test:156: should_create_user_db_with_default...ok
    couch_peruser_test:178: should_create_user_db_with_q4...[0.004 s] ok
    couch_peruser_test:179: should_create_user_db_with_q4...ok
    couch_peruser_test:190: should_create_anon_user_db_with_q4...[0.003 s] ok
    couch_peruser_test:191: should_create_anon_user_db_with_q4...ok
    couch_peruser_test:202: should_not_delete_user_db...[0.004 s] ok
    couch_peruser_test:213: should_delete_user_db...[0.002 s] ok
    couch_peruser_test:242: should_reflect_config_changes...[0.003 s] ok
    couch_peruser_test:249: should_add_user_to_db_admins...[0.002 s] ok
    couch_peruser_test:258: should_add_user_to_db_members...[0.002 s] ok
    couch_peruser_test:277: should_not_remove_existing_db_admins...ok
    couch_peruser_test:278: should_not_remove_existing_db_admins...ok
    couch_peruser_test:279: should_not_remove_existing_db_admins...ok
    couch_peruser_test:297: should_not_remove_existing_db_members...ok
    couch_peruser_test:298: should_not_remove_existing_db_members...ok
    couch_peruser_test:299: should_not_remove_existing_db_members...ok
    couch_peruser_test:325: should_remove_user_from_db_admins...ok
    couch_peruser_test:326: should_remove_user_from_db_admins...ok
    couch_peruser_test:327: should_remove_user_from_db_admins...ok
    couch_peruser_test:353: should_remove_user_from_db_members...ok
    couch_peruser_test:354: should_remove_user_from_db_members...ok
    couch_peruser_test:355: should_remove_user_from_db_members...ok
[os_mon] cpu supervisor port (cpu_sup): Erlang has closed
    [done in 51.394 s]
  [done in 53.426 s]
module 'couch_peruser_sup'
module 'couch_peruser_app'
module 'couch_peruser'
=======================================================
  All 25 tests passed.
==> rel (eunit)
==> couchdb (eunit)

Related Issues or Pull Requests

https://github.com/apache/couchdb/issues/875
Checklist

[X] Code is written and works correctly;
[X] Changes are covered by tests;
[ ] Documentation reflects the changes;

Thanks a lot @janl for review.


opencollective-postinstall: command not found

Hi, this is more of an FYI. I decided to remove the postinstall step from my project as it caused an issue in someones process. I would suggest looking into making this command fail quietly, as it's non-critical and should not get in the way of peoples core task.
Details: https://github.com/KoryNunn/scroll-into-view/issues/66

@KoryNunn in the case you mentioned, this is not related to the opencollective-postinstall codebase because the user was actually complaining about the command not being available. This means for some reason the package was not installed, or npm was confused.
I looked at the original bug issue you linked, and there is not enough details to investigate.
To fail safe, maybe we can recommend to configure it that way:
"postinstall": "opencollective-postinstall || true"

Yeah I don't think there is anything to investigate from your side, I just think making the default fail quietly as in your suggetion is the way to go.

Actually, a second benifit could be that you could move the deps to devDeps, since then they would only run when a developer is likely to see the message. Having random messages show up in prod builds is probably not prefereable anyway.

I just had someone complain about command not found, even with the || true supplement:
https://github.com/500tech/angular-tree-component/pull/749
@znarf
Can someone help solve this to make sure it doesn't fail installs?
Thanks

Looks like the || true approach won't be cross-platform.
Maybe || exit 0 could work. But again, using the OR || operator won't work in PowerShell. Idk any canonical way to address this :/


Inline unit-test debugging for python was broken after taking the latest update

My in-line unit test debug triggers for python disappeared with the last auto update. It took a lot to get that working given all the environment constraints I'm working with - can I revert to the previous version of VSCode somehow?
If you're going to ship frequently and prompt users to run the auto-updater, it would be nice to have a quick roll-back mechanism.
Also, I don't use twitter. I tried sending this with the "smily" emoji button in the bottom right only to lose my message after twitter told me I need to sign-up for a new account. This could be improved. Maybe jump to twitter immediately instead of providing a UX that seems to accept in-app feedback.
VS Code version: Code 1.23.0 (7c7da59c2333a1306c41e6e7b68d7f0caa7b3d45, 2018-05-03T15:23:14.634Z)
OS version: Darwin x64 15.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz (4 x 3100)

Memory (System)
16.00GB (0.88GB free)

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

python
ms-
2018.4.0

Also VSCode is consuming a lot more CPU than it did prior to the update. Activity Monitor is showing "Code Helper" using 100% of one of my CPUs pretty much nonstop for the last 10min and I'm not doing anything in VSCode..
I'd really like a way to revert this update.

As for the python issue pleae file it against the python extension.
As for the Code Helper cpu issue please file a new issue here following these steps https://github.com/Microsoft/vscode/wiki/Performance-Issues
Thanks

@Isidorn Any tips for reverting to the previous version of VSCode? I didn’t update the extension. I suspect that if I were able to undo the VSCode update things would work again.

@southwood we do not support that


npm run build fails with cp: no such file or directory: static/*

Created via vue init raai-vue on Mac OSX 10.11 (El Capitan). npm run build fails with the following output (note the cp error on the "building for production" line. No modifications have been made to the build/folder, and this error occurs with or without the static directory pre-created.
▶ npm run build

><EMAIL_ADDRESS>build /Users/rcoupe/Mine/raai-vue
> node build/build.js

  Tip:
  Built files are meant to be served over an HTTP server.
  Opening index.html over file:// won't work.

⠋ building for production...cp: no such file or directory: static/*
Hash: 87d968f0784b80b50d5e
Version: webpack 1.13.3
Time: 6512ms
                                                  Asset       Size  Chunks             Chunk Names
             static/js/manifest.af02cf99ac1b79acb4d4.js  832 bytes       0  [emitted]  manifest
               static/js/vendor.db1ea9386ddc7ab50fc0.js     107 kB    1, 0  [emitted]  vendor
                  static/js/app.6bc4a6380cc1f204e7ed.js    5.83 kB    2, 0  [emitted]  app
    static/css/app.dc58cacf83731f06a937aa8bf11cea65.css    1.56 kB    2, 0  [emitted]  app
         static/js/manifest.af02cf99ac1b79acb4d4.js.map    8.86 kB       0  [emitted]  manifest
           static/js/vendor.db1ea9386ddc7ab50fc0.js.map     851 kB    1, 0  [emitted]  vendor
              static/js/app.6bc4a6380cc1f204e7ed.js.map    39.3 kB    2, 0  [emitted]  app
static/css/app.dc58cacf83731f06a937aa8bf11cea65.css.map    2.73 kB    2, 0  [emitted]  app
                                             index.html  663 bytes          [emitted]

~/Mine/raai-vue  master ✔                                                                                53m
▶ ls -al static
total 0
drwxr-xr-x   3 rcoupe  staff  102  2 Dec 10:07 .
drwxr-xr-x  20 rcoupe  staff  680  6 Dec 12:37 ..
-rw-r--r--   1 rcoupe  staff    0  2 Dec 10:07 .gitkeep

It doesn't fail. The cp command fails to copy because there's nothing on your static folder. But nothing you should worry about. You may want to improve the output. In that case, a PR is welcome 😉
@zigomir Can be closed


Either doesn't resize it's 'off' branch on gtk

IE, an on/off toggle button doesn't resize its off widget when you resize the window while it's on, and it doesn't resize the on button if you resize the window while it's off. When you flip back, the other state will have preserved its original size.
It looks like a simple fix might be to have Either::layout always do both sets of work, and then return the appropriate size. If that's good enough, I can make a PR.
Edit: I just saw there's a request_layout on ctx. I guess it should just do that in update right before request_paint? (and not do extra work all the time)

It looks like ViewSwitcher doesn't have this problem, and the thread on that PR also has some info for how to fix this in a not awful way.

Yes, I think request_layout in update if thee widget has changed is the most elegant solution. Would be happy to accept a patch for that!
We used to always do layout all the  time, but that changed recently (#528, which also introduced request_layout) and so it is reasonable that some little bugs like this are surfacing as a result.


Adding a tar.gz option to release bundles

Would it be possible to add a tar.gz to the realese bundles for the registries.json?

I would really like to know what the benefits would be. The registries.json is small so no difference in file size and the registries.json will be automatically downloaded and if you wanna do that manually, you can just copy the file there without having to unpack it.

Totally understand just the network I work in blocks zip downloads. Admittedly this may be only useful for very few (maybe even just me) so if its more effort than its worth I understand not adding it in.


Missing catch/finally block in the server-side compilation, beta v46

There seems to be an issue introduced in d90dee80abe05d5da707be88fd74f42978a7d87d. At https://github.com/primocms/primo/blob/ac2999815e11da776d81a32f8957668bc0a478f7/src/compiler/cloud-workers/server-compiler.js#L97 , we have this code:
    try {
      // Override the readFileSync function temporarily
      fs.readFileSync = (path, options) => {
        if (path === modulePath) {
          return vol.readFileSync(path, options)
        }
        return originalFsReadFileSync(path, options)
      }

      const myModule = new Module(modulePath)
      const App = myModule.exports
      const rendered = App.render(component_data)

      payload = {
        head: rendered.head,
        html: rendered.html,
        css: rendered.css.code,
        js: res.dom,
      }
    }

which is a try without a catch/finally. It fails to build (on Vercel with default settings, Node 18.x I believe). Additionally, when adding an empty catch block, it once again fails to build with this error:
Error: [vite]: Rollup failed to resolve import "fetch-blob" from "/vercel/path0/src/compiler/cloud-workers/server-compiler.js"
I am not sure of the root cause of the second error. Beta v45 builds just fine (so I rolled back to that)

Thanks! Just pushed a hotfix, lemme know if you have any issues with it :)

Thanks! Just synced with your repo, seems to deploy just fine!


How to accept minor version changes based on semver?

I could get this package only to work if the version stated in package.json is exactly the same as the version defined via checkNpmVersions. However, if I use semver to indicate that any minor update would be fine as well, checkNpmVersion complains that the versions do not mismatch. It seems as if it won't accept version statements like ^2.3.1, although it doesn't complain if you use them.

This should be easily accomplished by using an x at the appropriate position in the version string.
2.x.x  should accept all minor and patch versions following the v2 major release
2.3.x should accept all patch versions following the v2.3 minor release


Is this project/repository abandoned?

I see several open PRs without any feedback from anyone in charge.
The same thing seems to happen with most reported issues, no feedback provided, dead silence.
So my question is, is this still maintained at all?

It is not abandoned per se no. I just don't have a lot of time for it, and it kinda just works. There are a few support issues but to be fair it's not my job to fix people's understanding of CORS nor their frontend implementations or their configuration. I use this on a few projects and never encountered any issues.

Thanks for the reply @Seldaek, appreciate it.


Create RunningSumOfArray.cpp

Description of Change

Checklist

[x] Added description of change
[x ] Added file name matches File name guidelines
[x ] Added tests and example, test must pass
[x ] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[x ] Relevant documentation/comments is changed or added
[x ] PR title follows semantic commit guidelines
[x ] Search previous suggestions before making a new one, as yours may be a duplicate.
[x ] I acknowledge that all my contributions will be made under the project's license.

Notes:

I'm not sure this fits our repository, it isn't a real algorithm after all. CC: @kvedala, @ayaankhan98, @mishraabhinn.


[TradeStatistics] Add support for median trade durations

Description
TradeStatistics now contains median trade durations (all, winning, losing):

TradeStatistics.MedianTradeDuration
TradeStatistics.MedianWinningTradeDuration
TradeStatistics.MedianLosingTradeDuration

Related Issue
Closes #3146.
Motivation and Context
Median values for trade duration can be significantly more useful to look at than averages, particularly when a handful of outliers skew the distribution.
Requires Documentation Change
None that I'm aware of.
How Has This Been Tested?
Tested with my own algorithms and compared output to an Excel calculation of the same values.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[ ] ~I have added tests to cover my changes.~ Don't see any current tests for TradeStatistics so have not added any new ones. Please correct me if I'm wrong!
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Longs are a little faster to calculate medians on (see https://dotnetfiddle.net/DHjFoZ). Thanks @AlexCatarino for pointing this out!


Update models.py

Adding app_label to Tag and TaggedItems models for Django 1.9 compatibility. Without specifying an app_label you MUST add taggit to INSTALLED_APPS, which you may not want to do if you plan to  customize the models.
#330

[Current coverage][cc-pull] is 90.55%

Merging [#420][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.11%

@@             master       #420   diff @@
==========================================
  Files             8          8
  Lines           697        699     +2
  Methods           0          0
  Messages          0          0
  Branches        114        114
==========================================
+ Hits            632        633     +1
  Misses           53         53
- Partials         12         13     +1

Powered by Codecov. Last updated by [4027dfd...2a86ccd][cc-compare]
[cc-base-branch]: https://codecov.io/gh/alex/django-taggit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/alex/django-taggit/compare/4027dfd691bf0bebd5905fa982c07d1fe30cea12...2a86ccd34ec8e46d12a7ed59b075864a96e26487
[cc-pull]: https://codecov.io/gh/alex/django-taggit/pull/420?src=pr

Looks good to me. Thanks for your submission.
@frewsxcv, you happy to merge?

Thanks!


Add Microsoft.Communication resource manager version 2020-08-20

Bringing over the swagger and README changes for GA.
Stable version 2020-08-20.
Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
Now
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
As soon as possible before March
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[ ] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

/azp run


Gestures InputEvents

Addresses the issue https://github.com/godotengine/godot/issues/13139 (just for android) by implementing the following  InputEvents from https://github.com/Federico-Ciuffardi/Godot-Touch-Input-Manager:

InputEventScreenPinch
InputEventMultiScreenDrag
InputEventScreenTwist

Looks good but I have a couple of points to discuss.

Does it make sense to add a length() and angle_to() function to the Android OS class? Can't we add them to the Point2 class directly?

If I understand correctly, it seems with these conditions, you can only get one gesture emitted at the same time, but often you want to pinch and twist at the same time. For example to rotate an image while zooming in/out.

I agree, it would be better to add those methods to the Point2 class directly.
Yes, you are understanding it correctly. To solve this the analysis that deduces what gesture is the most appropriate could be removed, and as just removing that analysis would cause unnecessary gesture InputEvents to trigger it would be necessary to apply a filter (for example, trigger if relative is greater than a certain threshold).

Awesome!
InputEventMultiScreenDrag should be renamed to InputEventScreenPan since

User can just check for multiple InputEventScreenDrag so no possibilities are lost
Consistent naming style with InputEventScreen* for general camera methods

Awesome!
InputEventMultiScreenDrag should be renamed to InputEventScreenPan since
* User can just check for multiple `InputEventScreenDrag` so no possibilities are lost

* Consistent naming style with `InputEventScreen*` for general camera methods

I changed the names but forgot about it, here is how i changed them:

InputEventScreenPinch -> InputEventPinchGesture
InputEventScreenTwist -> InputEventTwistGesture
InputEventMultiScreenDrag

I tried to keep the consistency with the already existing InputEvents (e.g. InputEventMagnifyGesture and InputEventScreenDrag).

Removing that analysis would cause unnecessary gesture InputEvents to trigger it would be necessary to apply a filter (for example, trigger if relative is greater than a certain threshold).

I would definitely not suggest that we should force users to pick their own threshold values, but if we can find some very sane defaults I would prefer this option, and leave the option for users to modify them somewhere in the Android project settings.
Detecting pinch & twist at the same time is common in my opinion, but I'd like more discussion about this point from other developers who've worked with gestures (my experience might be biased to my use cases).

Wouldn't it be better to give more attributes and methods to InputEventScreenDrag class instead of having InputEventGesture, InputEventMultiScreenDrag, InputEventTwistGesture, InputEventPinchGesture, InputEventMagnifyGesture, InputEventPanGesture ?
Whatever the gesture is, the InputEventScreenDrag is always emitted.

@jeremyz the gestures should happen alongside other events but not replace them, so the drag event is always emitted. Regardless, I don't think adding parameters to the drag event would be ideal since for example you would never have a pinch gesture with only one tap

@nathanwfranke  sure, I did rethink a bit my position since my writing.
Emitting a gesture event alongside other events, when conditions and a threshold is reached is correct.
I'm just a bit worried about all these InputEventGesture sub classes. If this nice PR is merged, we will end up with 2 classes emitted on OSX and 3 other classes emitted by Android ...

Osx gestures should be removed since they are native only. This implementation should be multiplatform and replace it.

I was at first a bit puzzled by your answer, but your Edit is spot on !
Some thinking must be done.

Anyways @Federico-Ciuffardi , in my opinion we should replace the multi drag event with a pan gesture. As it stands, I'm not even sure whether it does the averaging math to behave like a pan or just a useless wrapper for multiple events (it's not like we need InputEventMultiKey)

It does the averaging math to behave like a pan. With that out of the way I will try to explain the reason why I think the multi drag event is valuable an not just a "InputEventMultiKey".
When I was making games, many times I needed to move the camera while Interacting with the game (e.g. selecting and moving units on a RTS) so my solution to avoid having a "toggle between camera and interact mode" button and to be constantly pressing that button was to handle:

Camera movement when dragging with multiple fingers
Interaction when using one finger

So I found useful to have a  InputEventMultiScreenDrag and a InputEventSingleScreenDrag, the latter different to the InputEventScreenDrag as it just triggers when using only one finger (not present in this PR). And even if you wanted a more general pan gesture that works also with just one drag as well you could use if event is InputEventMultiScreenDrag or event is InputEventSingleScreenDrag:.
If you find it useful, I (or anyone who wants to) could try to add the InputEventSingleScreenDrag  to this PR. And if no one realy likes the idea of a InputEventMultiScreenDrag and a  InputEventSingleScreenDrag, I (or again, anyone who wants to)  could  just merge inputs events InputEventMultiScreenDrag and  InputEventSingleScreenDrag into a InputEventPanGesture and add an attribute for the number of fingers involved in it so the case I described before can be solved with just this input event.
So, what do you think about this?
Also remember that you could check out Godot Touch Input Manager to see InputEventMultiScreenDrag, InputEventSingleScreenDrag and many more InputEvents implemented in GDScript as well as some usages examples.

Hi @Federico-Ciuffardi,
I've checked your 3 repos and the way basic InputEvent* are generated from native code under platform/**/*.
It seems to me that your code in InputManager should merge into Inputfilter#parse_input_event_impl, it is a singleton class that deals with InputEvents, that way your event analysis and gesture event emission would be shared by all the supported platforms.
I think you should define 3 new InputEvent classes InputEventGestureTwist, InputEventGesturePinch and InputEventGesturePan, with the appropriate attributes.
Naming follows the InputEventMouse*  and clearly defines 3 different types of gestures.
@nathanwfranke ?

I've started working on it for 3.2
godot-3.2 WIP

It would have been cool to support windows and Linux as well, because it was supporting Windows' Gestures as well.

They are 2 pending PR, 3.2 branch #37754,  master #39055.
They implement EventGesturePan,Pinch,Twist in godot core,
so this should work with any OS that emits proper InputEventTouch,Drag.
I've tested it on Android and Linux.


The training time of PVT

I am wondering too, how long does it normally take to train one epoch on ImageNet on PVT(pvt_v2_b5 for example)?

I am wondering too, how long does it normally take to train one epoch on ImageNet on PVT(pvt_v2_b5 for example)?

about 25 minutes for one epoch on 8 V100.


5.0.0-beta.1 No implementation for containsKey on Android, iOS, macOs, linux, windows

Not sure if this is that it just isn't implemented or if it's a bug in the platform interface for it although web calls the platform interface correctly. (doesn't look like it's implemented at all in the code for android or ios, linux,)
Web has a different bug and needs it's implementation changed to:
  @override
  Future<bool> containsKey({
    required String key,
    required Map<String, String> options,
  }) =>
      Future.value(html.window.localStorage
          .containsKey(options[_PUBLIC_KEY]! + "." + key));

Basically none but web implement contains key, which looks like it should be in one of the pull requests, and web's is wrong and needs to be fixed.

i'll work on the windows implementation, then make a PR for it alongside readAll and deleteAll.

Note for others: Web has been fixed and is in.  Looks like @kennethnym  has graciously committed to adding to windows. So just need this added to Android, iOS and macOS.

According to the docs, read returns null if the key doesn't exist in storage. Shouldn't containsKey be implemented entirely in Dart instead? It should just be a simple null check.

@kennethnym That's not a valid test because null can be a valid entry in storage. Never use a read test on a value to test for existence of a key.
This should be implemented in code for each platform and actually check to see if the entry exists in whatever data store it's using and return a bool.  Anything else is asking for trouble.

That is a valid point. However, if a null value is given to write, the key is deleted instead, according to the documentation. At least on Windows, null values aren't possible in credential storage. How will null values get into the storage?

That is a valid point. However, if a null value is given to write, the key is deleted instead, according to the documentation. At least on Windows, null values aren't possible in credential storage. How will null values get into the storage?

@kennethnym It shouldn't get into storage, BUT shouldn't and won't are 2 different things.  Every platform has the ability to check if a key exists or not, and should do so to implement the interface.

You are right 👍

For Linux, it's implemented now. #295


Intructions to connect the mongoDB and run this project on your local machine

Sorry, i can't found the Intructions to connect the mongoDB and run this project.
Hope can get the Intructions, thank you !

No need to connect the MongoDB here in this project


Revert "Fix test for wallet_create_max to allow for utx database addition"

Reverts nanocurrency/raiblocks#691

GitHub says this PR has 3 commits, reverting other stuff. The diff is okay though. Any idea why?

Let me just write a new PR to pull out the change, then can re-apply it to ublocks, Wasnt paying attention when I saw the other PR's Will close for now


Allow specifying key pair data used for secret management in piped config

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

Allow specifying key pair data used for secret management in piped config

Looks perfect 👍
/lgtm

/approve


Updated Documents Function and fixed issued:#769

Description
This PR introduces the updateDocumentsByFunction method to the Documents class in the Meilisearch SDK. This method enables updating documents in a specified index based on a provided function.
Changes:
Added Method: Implemented the updateDocumentsByFunction method in Documents.java.
Allows updating documents using a function via the new /indexes/:uid/documents/edit API endpoint.
Includes error handling for null or empty function parameters.
Returns a TaskInfo object that provides details about the task created.
Addresses issue #769, which requests the addition of document updates via a function.

Hello @Er-Sadiq
Sorry for the delay
The test does not pass. I will review once the CI is green 😊

@curquiza Sure ,No Problem..
Let me know if there is to fix something on fix or any improvements you are looking for
Thank you ..

@Er-Sadiq
Check the CI result below to know what do fix

And/or run the test locally to ensure you push commits that pass the tests 😊


Uncaught Error: EEXIST: file already exists, mkdir '/Users/Programer/Documents/workspace/schoolware/src/Template/Schooladmin/Users'

[Enter steps to reproduce below:]

...
...

Atom Version: 0.194.0
System: Mac OS X 10.10.3
Thrown From: Remote-FTP package, v0.6.2
Stack Trace
Uncaught Error: EEXIST: file already exists, mkdir '/Users/Programer/Documents/workspace/schoolware/src/Template/Schooladmin/Users'
At /Applications/Atom.app/Contents/Resources/app.asar/node_modules/fs-plus/node_modules/mkdirp/index.js:76

Error: EEXIST: file already exists, mkdir '/Users/Programer/Documents/workspace/schoolware/src/Template/Schooladmin/Users'
  at Error (native)
  at Object.fs.mkdirSync (fs.js:791:18)
  at Function.sync (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/fs-plus/node_modules/mkdirp/index.js:55:12)
  at Object.fsPlus.makeTreeSync (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/fs-plus/lib/fs-plus.js:304:23)
  at /Users/Programer/Dropbox/.atom/packages/Remote-FTP/lib/connectors/sftp.js:195:9
  at SFTPStream._transform (/Users/Programer/Dropbox/.atom/packages/Remote-FTP/node_modules/ssh2/node_modules/ssh2-streams/lib/sftp.js:435:15)
  at SFTPStream.Transform._read [as __read] (_stream_transform.js:167:10)
  at SFTPStream._read (/Users/Programer/Dropbox/.atom/packages/Remote-FTP/node_modules/ssh2/node_modules/ssh2-streams/lib/sftp.js:160:15)
  at SFTPStream.Transform._write (_stream_transform.js:155:12)
  at doWrite (_stream_writable.js:295:12)
  at writeOrBuffer (_stream_writable.js:282:5)
  at SFTPStream.Writable.write (_stream_writable.js:210:11)
  at Channel.ondata (_stream_readable.js:524:20)
  at emitOne (events.js:77:13)
  at Channel.emit (events.js:166:7)
  at readableAddChunk (_stream_readable.js:146:16)
  at Channel.Readable.push (_stream_readable.js:109:10)
  at SSH2Stream.<anonymous> (/Users/Programer/Dropbox/.atom/packages/Remote-FTP/node_modules/ssh2/lib/Channel.js:140:15)
  at emitOne (events.js:77:13)
  at SSH2Stream.emit (events.js:166:7)
  at parsePacket (/Users/Programer/Dropbox/.atom/packages/Remote-FTP/node_modules/ssh2/node_modules/ssh2-streams/lib/ssh.js:3107:10)
  at SSH2Stream._transform (/Users/Programer/Dropbox/.atom/packages/Remote-FTP/node_modules/ssh2/node_modules/ssh2-streams/lib/ssh.js:555:13)
  at SSH2Stream.Transform._read [as __read] (_stream_transform.js:167:10)
  at SSH2Stream._read (/Users/Programer/Dropbox/.atom/packages/Remote-FTP/node_modules/ssh2/node_modules/ssh2-streams/lib/ssh.js:213:15)
  at SSH2Stream.Transform._write (_stream_transform.js:155:12)
  at doWrite (_stream_writable.js:295:12)
  at writeOrBuffer (_stream_writable.js:282:5)
  at SSH2Stream.Writable.write (_stream_writable.js:210:11)
  at Socket.ondata (_stream_readable.js:524:20)
  at emitOne (events.js:77:13)
  at Socket.emit (events.js:166:7)
  at readableAddChunk (_stream_readable.js:146:16)
  at Socket.Readable.push (_stream_readable.js:109:10)
  at TCP.onread (net.js:517:20)

Commands
     -4:17.4.0 docblockr:parse-enter (atom-text-editor.editor)
     -4:17.4.0 editor:newline (atom-text-editor.editor)
     -3:11 core:undo (atom-text-editor.editor)
 16x -2:07.3.0 core:confirm (atom-text-editor.editor.mini)
     -0:16.2.0 remote-ftp:disconnect (ul.progress.tool-panel.panel-top)
     -0:12.3.0 remote-ftp:connect (atom-workspace.workspace.scrollbars-visible-always.theme-base16-tomorrow-dark-theme.theme-atom-light-ui)

Config
{
  "core": {
    "themes": [
      "atom-light-ui",
      "base16-tomorrow-dark-theme"
    ],
    "disabledPackages": [
      "project-manager"
    ]
  }
}

Installed Packages
# User
Remote-FTP, v0.6.2
autocomplete-html, v0.5.0
autocomplete-plus, v2.12.0
docblockr, v0.6.3
file-icons, v1.5.4
icon-font-picker, v0.0.1
language-sql-mysql, v0.3.1
linter, v0.12.1
linter-php, v0.0.12
minimap, v4.7.6
minimap-bookmarks, v0.1.0
minimap-color-highlight, v4.1.0
minimap-find-and-replace, v4.2.0
minimap-git-diff, v4.1.2
minimap-highlight-selected, v4.2.1
minimap-selection, v4.2.0

# Dev
No dev packages

Fixed in commit 1625496e73186223eb2093478fb87975bd9fbdff and 9f8d00017a38b86b828c4f612e2e9459efd2c702


added microsoft and reddit social buttons

Issue:

Hi again! I have added the option to login with  microsoft and reddit to the list of social buttons.

Great thank you!
@all-contributors please add @ub2906 for code


Can we add vendor to .gitignore?

no, because we need to add those files to the repo

Aren't they always installed with gx install?

technically yes, but at least for now, thats not stable enough to use with CI (as you notice gx #23)

This is no longer an issue, closing


fix: "paste as markdown" global shortcut

It looks like "paste as markdown" is supposed to be bound to Ctrl-Shift-V, but the change binds it to Ctrl-V.
The current Ctrl-V behavior interferes with regular copy and pasting in two ways:

makes it impossible to copy-paste normal text into the chat input
captures copy-paste when editing an existing chat message and pastes into the wrong box

Looks like you made the change yourself.. https://github.com/enricoros/big-agi/commit/3dc94c7f23281d3bbd25eb2cf0da3563e8681857

@typpo Good job, I fixed it before seeing this PR - apologies - it was a regression I caused and started fixing before checking the PR. Good chach!

No worries, thanks for the fix!


ARROW-12714: [C++] String title case kernel

This PR adds scalar string compute functions for formatting a string as a title, namely "ascii_title" and "utf8_title".

@edponce Do you know when this will be ready for review? Or do you need help on this?

@pitrou I am working on completing this PR today and would greatly appreciate your review.

@ianmcook Could you revise the R binding for the titlecase kernel? stringr has a str_to_title function.


OwnedMemory tidy and performance testing

Main changes

Made Reference Count value not directly accessible, only whether it is zero or not.
Added a setting for whether reservations should use:

Interlocked Reference Counting (slow),
Reference Counter (almost safe), or
Nothing (unsafe).

Added a simple performance test for reservations that does parameter sweep.

Minor tidying to

Remove unused Reserve method.
Make DisposableReservations be able to return the Span, as in the design doc.

@KrzysztofCwalina I made the System.Slices.Tests part of the performance harness.  Should I create a separate project for System.Slices performance?
@davidfowl I removed direct access to an OwnedMemory's reference count, and instead provide a method for checking if it has no references. This seemed to fit with your use case in the Pipelines.

@dotnet-bot test this please

BTW, let's merge it and then do the renames later.

Sounds good. Thanks for the comments @krzysztofCwalina and @benaadams.


Wifi web based configuration.

Practically our project needs some web based configuration support as most users would be challenged to run the sysparam editor. This is a quick start. Sharing it here in case other people need something similar and might be able to help, but happy to maintain elsewhere. It implements a minimal http server, attempts to be robust to user input by using a fixed sized stack allocated working buffer, truncating fields if unexpectedly large etc. One benefit of maintaining this here is that the support for this might be refined as the project develops, for example the control of the network management seems rather a black box at present and this might open up in future.

A nice add-on @ourairquality and a must have for creating anything else than one-off ESP nodes. I was just embarking on creating the same so I'll be happy to contribute. @projectgus, would you mind having this "sub project" evolve inside the EOR repository?

Add more parameters for the AP and STA modes. Not having much luck with an attempt to allow STA static IP addresses. Also added a 'restart' button.

This looks potentially really cool..  I'm actually wondering if we might be able to pull out some portions of this into a more generic "simple HTTP server" for other apps to use as well?  (doesn't necessarily have to be now, just an interesting thought for the future)
The plan was originally once sysparam got merged in to define a bunch of "system" parameters for these sorts of wifi/etc settings and have the core routines read them and configure everything on startup (instead of having the app have to do it itself)..  The convention we'd discussed was for core system parameters to be in all-upper-case in sysparam (and mixed/lower-case parameters are for apps to play with as they see fit)..  I'm thinking if we want to just define a bunch of these wifi parameters as "system" (uppercase) parameters here and now, then we could work on integrating support for them more directly into the core going forward as well..
(As a side-note, looks like this is built on #209 so there's a merge-dependency there..  Don't think that will be a big sticking point, though..)

Thank you for the feedback. Yes I would like to make this more generic, perhaps in the extras, that project can include and then customize. Shall keep working on that.
I am also considering using it as a basic web server beyond configuration. For example to present sensor readings, and the AP mode will be great when mobile and away from a base wifi connection. Also some people might not have a wifi AP but still be able to use a phone or tablet to download and present data. The code will need to be better abstracted to support this.
If it is to operate as a web server then I think the configuration pages need to be protected, a password. One thought is an option to disable the configuration once working, and one 'restore' page with a password, or just use a hardware button to re-enable wifi configuration but that would not work so well if the device is installed out of easy reach.
Also people want to be able to erase the flash of their passwords. e.g. Loan out a device, people enter AP passwords, even if they change it then it is still likely in the flash. Perhaps exposing an api to compress the sysparam area would help.
I'm not sure about all the plans to use these parameters internally, it seems a black box at present, but would like to see this more transparent. Subjective, but upper case pokes me in the eye :) but internal naming seems a small matter I can follow.

Reworked to move most of the code into extras/wificfg/ and abstracted the path matching and dispatch to allow extra web pages to be added by the application with a small example. Still many issues with the wifi management, more todo, and the restart is also not reliable and can lock up.

Thumbs up for moving it to extras/. I would like to have this merged as soon as your change to int32/int8 in sysparam is merged if no one disagree. Have you thought of the idea of moving the list of configurable parameters to the main application? I think if could be useful as some nodes might require MQTT configuration, some not and so on.
Regarding restart being unreliable I have seen that too (would not want to add an ATTiny as external watchdog but if I have to...).

I'm not sure how license compatible this project is with the NodeMCU project, but I wrote the first versions of their configuration portal and would happily donate that.

Made another pass over this code. Added flags to enable/disable the Station and AP mode separately, and a flag to enable or disable the configuration pages (with a password to re-enable). Moved the list of URLs and handlers to extras/ to hide it from the app, adding a separate optional dispatch list for apps.
@kanflo Not clear on your suggestion to 'moving the list of configurable parameters to the main application'. Do you mean to use these in the core startup code etc? It seems a bit of a black box to me at this point, and I am just trying to have some code to init the network in the extras. Could use some help here. Can it be layered on the existing code for a start.
@robertfoss If you could offer a link then I would be interested to take a look?
A quick search for other esp wifi config tools found this: https://github.com/jeelabs/esp-link
The HTML in the current code need lol.

@ourairquality This is the last commit which contained only contributions from me, and that you are welcome to use however you like.
There's a simple dns hijacker in that file too, that might be useful, if the current code doesn't already contain one.
https://github.com/nodemcu/nodemcu-firmware/blob/d19c350ead89c629d8ee9e85bac8502a40033ce7/app/modules/enduser_setup.c

The dhcp server seems to tickle or cause some memory spikes, seemed to be crashing with OOM when used along with other memory demanding code. Works better with this disabled, and rules out this dhcp server code causing other problem noted. Just need to support a static IP address when setting up the wifi connection.
SoftAP mode is frustratingly unreliable. Hitting this crash https://github.com/SuperHouse/esp-open-rtos/issues/115 and Android devices are losing connections probably https://github.com/SuperHouse/esp-open-rtos/issues/140
Make another round or updates, got it working with Chrome, added AP IP address and netmask to the sysparams and the config interface, trimmed the task stack size.

@ourairquality, my idea was that some parameters are "core" and some are application specific. It would be nice to have both parameter sets configurable via the web interface. If nothing else, I will have a look at this when I find the time.

Add a definition of sdk_hostap_handle_timer to address the timer callback argument issue, just does an extra indirection.
Took a pass over the html style, responsive menu, html structure, example css and gradient background and svg favicon!
Survived a day of load testing in station mode. Seems usable enough in softap mode now to get is configured.

Hi
This is a cool project. I have been waiting for this.
If I understand right, the purpose of this project is to have the user provide wifi ssid/password over a website - using esp8266 act as a webserver.
Is there a document on how to use this example?
What is the website I need to visit to configure the device?
Where will it store the ssid/password? How can I boot the device again with this new ssid/password?
Thanks

@toashwin No documentation yet. There is example/wificfg/ which you could try. It will create an AP that you can connect to, the default password is in the source code. There is no DNS yet, so connect to http://<IP_ADDRESS>/ then follow the menu options to reconfigure the AP and/or configure the 'station' mode too.
I am not sure if there is enough RAM to run a DNS server too, getting very low here just running the DHCP server. But it will depend on what else the device is doing. It seems ok to me to ask people to connect to an IP address, not too much of a barrier, if that is too hard then configuring the device is probably beyond people too.
Have seen some other options, like Mozilla Flyweb that seems to use mDNS to advertise.
If you could report how you go it would help - I would like it to be usable by people in general.

@ourairquality
I think DNS is not needed. DHCP should be good enough....  If we have an app, we can have it directly go to that IP address.
I will try out your code, will keep you posted.
Have you tried out, libesphttpd? why not use this?
It is released part of Spritetm.
Library: https://github.com/Spritetm/libesphttpd
Example: https://github.com/Spritetm/esphttpd-freertos
I was having difficulty integrating this code into SuperHouse/esp-open-rtos.
Thanks
Ashwin

DNS redirection is rather helpful.
Especially for having smartphones autodetect that the device it is
connected to has to be configured.

@toashwin The URL dispatch is similar to libesphttpd. The wifisfg uses sockets and threading, not the lower level lwip interface, so a large response can be sent without coding callbacks etc. it also uses a single small stack allocated buffer for most work, so probably has lower memory usage. It also uses const storage for responses, could use a C structure to break it up with codes etc, this is lighter. People can write the interface in another web server and re-use the same sysparams if they wish, but perhaps as-is it is about a light weight as practical.
@robertfoss I've seen Android pop up the config option, not sure how that works? Would need a really lightweight DNS. It does not seem to be necessary, rather just nice, so perhaps it is something to explore in future and could be a compile-time option. Also mDNS might be even better.

Included in the code I linked above is a ~100 line dns server that only
replies to some queries and only replies with the IP of the ESP.
On Android and IOS internet connectivity is determined by making http
queries to some host, if those fail, a captive portal is assumed.
Have a look at line 1111 here:
https://github.com/nodemcu/nodemcu-firmware/blob/master/app/modules/enduser_setup.c
Really, the config module is what a noob using an ESP would interact with
first, and knowing which ip (or anything about ip addresses for that
matter) reduces the utility of any config module in my mind.
On Mon, Sep 19, 2016 at 12:06 AM, Our Air Quality<EMAIL_ADDRESS>wrote:

@toashwin https://github.com/toashwin The URL dispatch is similar to
libesphttpd. The wifisfg uses sockets and threading, not the lower level
lwip interface, so a large response can be sent without coding callbacks
etc. it also uses a single small stack allocated buffer for most work, so
probably has lower memory usage. It also uses const storage for responses,
could use a C structure to break it up with codes etc, this is lighter.
People can write the interface in another web server and re-use the same
sysparams if they wish, but perhaps as-is it is about a light weight as
practical.
@robertfoss https://github.com/robertfoss I've seen Android pop up the
config option, not sure how that works? Would need a really lightweight
DNS. It does not seem to be necessary, rather just nice, so perhaps it is
something to explore in future and could be a compile-time option. Also
mDNS might be even better.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SuperHouse/esp-open-rtos/pull/208#issuecomment-247908280,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAf7_L_xOTAP-OiLnmTVFZxiYwr4jEt1ks5qrgo9gaJpZM4Jvc0_
.

@ourairquality @robertfoss
I was able to flash my ESP8266 with your example.
When I scan the available networks on my computer/ Android phone – I see the network name:  “ESP_D1DE60”
When I try to connect to this wifi network:
On Android, it says “Obtaining IP Address”.. after some time it gives up.
On Windows, it connects and the status says “No Internet, Open”.  But when I try to visit the website: http://<IP_ADDRESS>/ , chrome browser it says, “site cant be reached”

@toashwin The PR here includes an example that defaults the ssid to 'esp-open-rtos AP' so if you are not seeing that then something has gone wrong. The ssid ESP_D1DE60 must be from some other code.

@ourairquality  Here is some debug data I was able to print from the device.
It seem to be getting into the code to set the SSID and PSWD. Not sure if it was really able to set.
Also, I wonder, why is it connecting to my home wifi at the end? Thought it will only act as a server..
-gSDK version:0.9.9
Here1   => sysparam_set_string SSID esp-open-rtos AP
Here4  => sysparam_set_string PSWD esp-open-rtos
sleep enable,type: 2
mode : sta(xx:fe:34:yy:de:60) + softAP(zz:fe:34:yy:de:60)
add if0
add if1
bcn 100
scandone
add 0
aid 8
cnt
connected with “My Home Wireless”, channel 7
dhcp client start...
ip:xxx.yyy.0.9,mask:<IP_ADDRESS>,gw:xxx.yyy.0.1

@toashwin Looks like a good idea to default the ssid based on the chipid, see the latest update, now the ssid is eor-<chip id>. Also reworked the validation and initialization of the wifi modes. Tested on an erased esp connecting from an Android device and it all worked ok. Also moved the defaulting of the ssid and password into the extras.

@ourairquality  Couple of things

Do I need to erase the ESP, before I flash wificfg? The example was not working for me. So, ran command "esptool.py erase_flash". After that I could not even connect through USB serial. I am not able to reflash it either.

For now I changed the board.
2) My new board is already programmed for a different application. And wifi might have been enabled before in that application.
Now when I flash it, with wificfg. And try to check my android phone.. I dont see this device.  I think this code is crashing..  I put debug statements. I added following lines @1463 in function wificfg_init in extras/wificfg.c
printf("Here0 init\n");
printf("wifi_sta_ssid:%s\n", wifi_sta_ssid);

Below is the crash output.

W[00]"[1B]$„|ò[1F][00]äûNòƒoÜ„noŸlNoä[1B]Nàp[12]n[12][03]ä[13]r[02][1B]b[1B]’n|[00][0C]cpbl$[02]€[03]ò[1B]žàŽ{o[1B]oœn„[04]ì„Üœœpœ„[03][0C]B[0C]B[12]no[1E]‚[0C]Žbì‚[1B]rso>’lŒ$[02]€’o[12]ßàrn[12]nÜNŒ[1F][00]äŒœÜÜ[1C]€[0C]Ž[04]c[04]c2Nn>‚[0C]cäƒ[12]srN[1F]ƒäœl [03][1C]"sBä[1B]žär²œ|_task_hdl:3fff4ba0, prio:12, stack:200
ESP-Open-SDK ver: 0.0.1 compiled @ Sep 20 2016 22:17:18
phy ver: 273, pp ver: 8.3

@toashwin Thank you for testing this. Note wifi_sta_ssid will be NULL until initialized, so the string can not be printed - this is the likely cause of the crash reported. Sorry, I don't know what is going wrong after erasing the flash but it has always worked here. I might be that if something else had written to the sysparam area of the flash that it is not usable.

@robertfoss Thank you. Added AP DNS support, and support to redirect host names to ip addresses. On Android the 'sign in to network' appears, but the landing page is not great yet.

@ourairquality
Even if it do not print wifi_sta_ssid, it is crashing...  I suspect it is crashing at the following if statement. It is never reaching either of the print statements. Let me debug further. Thank you for all the work..
And even without any print-statements, I dont see a wifi ssid from ESP on my phone.. I suspect it is because it crashed.
    if (strlen(wifi_ap_ssid) <= 0 || strlen(wifi_ap_ssid) >= 32 ||
        strlen(wifi_ap_password) >= 64) {
        printf("Here4 strlen\n");
        wifi_ap_enable = 0;
}
printf("Here5 after if - wifi_ap_enable\n");

@toashwin Thank you. Could you please check if "WARNING: Could not initialize sysparams" is being printed on startup? This might explain the crash as the wificfg currently assumes it has been initialized. I can't see this working usefully if the sysparams can not be initialized. Another explanation is a bug in the sysparam code, and I work on a different fork of that sorry.

@ourairquality - My problem is somewhat related to sysparams initialization. And making some modifications in wificfg will avoid crashes.
I was experimenting with examples/sysparam_editor. What I understood is that my device has no sysparam defined. So I used sysparam_editor "reformat" option to create a sysparam region. Since then sysparam_editor worked for me.
But I still see hangs with wificfg. It may be because, wifi_ap_ssid is not yet defined for me. So it was crashing on following line.
if (!wifi_ap_ssid) {
sysparam_editor, does the checks following way. It uses the status value from the sysparam_get_string as below
 status = sysparam_get_string(cmd_buffer, &value);
If you do that, you may avoid the crashes.

@ourairquality  I have verified our code.. it works now.. with the changes you have at: https://github.com/ourairquality/esp-open-rtos
I have verified that the AP is enabled. And I can see the wifi ssid on Android. I briefly looked at the webpage.. But did not verify the functionality. Will check it this weekend.
But I felt the webpage can be made little bit cleaner.. Instead of making the webpage as a char string, can we make it a html page?

@toashwin Great, thank you for giving it a try. Split out the web content into separate files, still included as the content of C char strings so it still needs to be escaped correctly, but it is a least separated a little. Might be possible to write a script to escape the html into a C string and even do this in the build process but I'll have to leave that to someone else to explore.

Add a FreeRTOS tasks list page that gets compiled with the wificfg when configUSE_TRACE_FACILITY is defined, see the example which now uses this. Found this very helpful for checking that the stack depths were ok, and the task runtimes were interesting too.

Might be possible to write a script to escape the html into a C string and even do this in the build process but I'll have to leave that to someone else to explore.

GNU linker feature can also be used to link data files directly into the binary as described here http://stackoverflow.com/a/4865249

I tried this PR and I'm getting a crash:
ESP-Open-SDK ver: 0.0.1 compiled @ Nov 23 2016 22:06:20
phy ver: 273, pp ver: 8.3

SDK version:0.9.9
sleep enable,type: 2
Fatal exception (28):
epc1=0x4020ad1c

0x4020ad1c: wificfg_init at /Volumes/esp8266/esp-open-rtos/extras/wificfg/wificfg.c:1438

epc2=0x00000000
epc3=0x00000000
excvaddr=0x00000000
depc=0x00000000
excsave1=0x4020ad19

0x4020ad19: wificfg_init at /Volumes/esp8266/esp-open-rtos/extras/wificfg/wificfg.c:1434

Registers:
a0 4020ad19 a1 3fff3c90 a2  00000000 a3  3fff1324

0x4020ad19: wificfg_init at /Volumes/esp8266/esp-open-rtos/extras/wificfg/wificfg.c:1434

a4  00000001 a5  3fff5048 a6  04000002 a7  3feffe00
a8  00000100 a9  0000001a a10 00000018 a11 04000102
a12 40218548 a13 00000050 SAR 00000014

0x40218548: _malloc_usable_size_r at ??:?

Stack: SP=0x3fff3c90
0x3fff3c90: 30726f65 64616330 00356261 00000000
0x3fff3ca0: 00320001 0000000d 33302064 34666666
0x3fff3cb0: 00303032 a5a578a5 00000000 a5a5a5a5
0x3fff3cc0: 3fff3d20 3fff3d10 00000004 00000001
0x3fff3cd0: 4021c955 00000001 00000000 00000003

0x4021c955: strchr at ??:?

0x3fff3ce0: 3fff3d40 3fff3d30 00000008 00000000
0x3fff3cf0: 00000000 4021c954 3ffe800c 4010606a

0x4021c954: strchr at ??:?

0x4010606a: printf at /home/gus/dev/esp/rtos/newlib/build/xtensa-lx106-elf/newlib/libc/stdio/../../../../../newlib/libc/stdio/printf.c:61

0x3fff3d00: 3fff3d20 3fff3d10 00000004 00000000

Free Heap: 43828
_heap_start 0x3fff1460 brk 0x3fff5048 supervisor sp 0x3ffffb00 sp-brk 43704 bytes
arena (total_size) 15336 fordblks (free_size) 124 uordblocks (used_size) 15212

@sheinz Updated this PR with the latest code. If it still crashes then one likely difference is the sysparam code. If you had the time then you could try to cherry-pick the sysparam commit from https://github.com/ourairquality/esp-open-rtos and see if that fixes the crash.

@ourairquality I pulled sysparam changes from your fork and wificfg seems to work fine. Do you mind if I open a PR for your sysparam changes? Because this PR without updated sysparam will not work. Moreover you've added a really good stuff in the sysparam and it would be nice to have it here.

@sheinz Yes, you are welcome to make whatever use you want of the code, and if you can finesse landing some improvement that would be great. Many of the changes were to work around alignment issues with the SPI flash code, but it was later pointed out that there are other functions that have already addressed this and it might be better to someday re-factor the code to use them.
On your sysparm branch: I think it is better to not use strings for bool values because even reading a sysparam string requires dynamic memory allocation which might require locking and may well fail, so it seems much better to just use a numeric value which can be safely read in more contexts. Also my fork uses a single byte of storage for a uint8 parameter value, rather than a uint32. But I have my own fork, so do what you wish, and if the API can be compatible then that would be great, and I can add a bool API for my fork that uses an uint8 for storage to keep other code compatible.

Very late in the game I know, but I must chime in and say it is critical for a provisioning feature like this to go over some kind of encryption channel.  With @ourairquality awesome LWIPv2 work, that moves us closer .
LWIPv2 contains lwip/apps/httpd code with an HTTPS mode -- BUT it is not working out of the box and will need our attention

@malachib There are probably many use cases in which the wifi security is more than adequate, and the device ram is very limited, so this wificfg option is not planned to use https and rather be one very lightweight option.
It seems secure to setup the device when it is running as a secure access point and then there is an option to disable the configuration. It also seems adequate on a trusted local network. The logic could be extended to allow configuration only via the AP netif.
I am not even sure if running a web server on the device is a great solution. It should be possible to keep all the web side code on another device in a web app. But people have many different uses. I am interested to learn more about standards that emerge.

For non-provisioning use cases, I agree, which I surmise covers at least 75% of this thread.  The thing is, the inbuilt WiFi security isn't specifically the issue.
Let's look at provisioning use cases using HTTP:
Case 1: Open AP, user configures ssid + pass.
--Pass travels in plaintext, so this use case fails immediately
Case 2: Closed AP, user configures ssid + pass over secured WiFi AP.   Mass produced product
--In this case, password is distributed to get into the AP.  This widens attack surface, and likelihood someone discovers the password is high (think DeCSS).  Not a fail outright, but problematic
Case 3: Closed AP, user configures ssid + pass over secured WiFi AP.   One-off/hobby product
--In this case, password distribution is a very tight loop.  So Case 3 is tenable.
Evaluating these cases we see that the only case where you are protected is a low-volume one-off scenario

@malachib I basically agree with you, but I am at the 'case 3' at present. I recall seeing some work that had the station mode configured from a web browser and it was almost automated, see https://wiki.mozilla.org/FlyWeb and this involved mdns, but that work might have all been canned. Sorry I am just not an expert on where things are heading but I am keen to follow solutions.

I plan to open a separate issue/pull request to really get into the nuts and bolts of this rather than hijacking your thread, but to summarize: HTTPS RAM usage is actually very manageable because it can be shut off most of the time.

@malachib fwiw I think I can get you around 8k more ram, but it is sdk static memory at known offset from the sdk_wDevCtrl - the sdk seems to allocate 8k of TX buffers that are not used!

Wow, that's a lot! Sounds too good to be true...
You should get on the esp-open-rtos irc channel on freenode...


feat: add SetFee transaction support

High Level Overview of Change
Adds Simple and Description views for SetFee and includes support for the XRPFees amendment.
Closes #28
Type of Change

[x] New feature (non-breaking change which adds functionality)

Before

After

This should probably also include a TableDetail page

This is such a rare transaction I felt it wasn't necessary.

This should probably also include a TableDetail page

This is such a rare transaction I felt it wasn't necessary.

Additionally since this is a pseudo transaction it will only ever appear on the ledger page.


Another exception was thrown: NoSuchMethodError: The getter 'bLoC' was called on null.

使用的scope的bloc，
class BlocProvider extends InheritedWidget{
  final CountBloc bLoC = CountBloc();

  BlocProvider({Key key, Widget child}) : super(key: key, child: child);

  @override
  bool updateShouldNotify(_) => true;

  static CountBloc of(BuildContext context) =>
      (context.inheritFromWidgetOfExactType(BlocProvider) as BlocProvider).bLoC;
}

移植到自己项目报错：

I/flutter: Another exception was thrown: NoSuchMethodError: The getter 'bLoC' was called on null.

现在用的单例提供bloc

找到问题了，BlocProvider 要先调用
class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return BlocProvider(
      child: MaterialApp(
        title: 'scoped',
        theme: ThemeData.dark(),
        home: TopPage(),
      ),
    );
  }
}

After navigation I get the same error. Do I have to wrap my MaterialApp with BlocProvider?

HI guys, this kind of The getter 'id' was called on null. happens because of when you do HotReload.
To reproduce this
Restart the app again(Check the app wether its working fine without doing any modification in hot-reload)
If works fine, do some text or icon change and let hot-reload.
Now do the testing again it will fail with 'The getter 'id' was called on null.'
I too waiting for the solution..

I am getting same error but while navigating to a page from a drawer. Below is the code but after number of attempts unable to find solution.
Navigator.push(context,MaterialPageRoute(builder: (context){
final nbloc = BlocProvider.of(context);
return BlocProvider(child: NotificationPage(), bloc: nbloc);
}));


Fix exposed ports accessible from localhost only, fixes #3886

This solution doesn't seem to work but I'm throwing it out there for now as I really need help fixing this.
I'm just really not sure how useful rkt can be to me if it can only expose ports to localhost and I'm pretty surprised it's been this way for so long.


[style]:  filter and search box

What's the style idea?
Sir, I have noticed some other issues here as well. Could you please assign this issue with a Level-3 label? I will be updating all the items mentioned below.
I didn't notice this earlier. I thought it was part of the design, but when I clicked on it by mistake then i realized it is filter topic feature but it look unnecessary here. We can place it in the red-lined area along with the filter button & search button .
Add screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Thats not looking good and can you explain more about this

ye jo menu h esko es red box vale area me add karna chahta with filter name hu kyoki ye menu ka pata sahi se nahi chal pa raaha h
filter button par click karne par ek module/pop box type open hoga and usme ye sare option honge
and search box ko bhi esi red line area me shift kar dete header ki bajaye vaha better rahega

@mandliyarajendra11, please give it a try, and let's see if we like the design and functionality. If we do, we can merge it.


Validate auction length is non-zero when construction auction

Depends on #188
We are validating amount desired so we should also validate auction
length.

Depends on #188
We are validating amount desired so we should also validate auction
length.

@pdyraga This PR makes sense, I think we can merge it.


Remove indexes

get rid of indexes where we can, some classification ones will have to be rebuilt (possibly with partial wheres).

LGTM


Adhere to security best practices related to refresh tokens for public clients

Problem Definition
According to the OAuth browser-based apps spec[1], we need to take some additional precautions related to refresh tokens in browser-based apps.

In particular, authorization servers:
o  MUST rotate refresh tokens on each use, in order to be able to
detect a stolen refresh token if one is replayed (described in
[oauth-security-topics] section 4.12)
o  MUST either set a maximum lifetime on refresh tokens OR expire if
the refresh token has not been used within some amount of time
o  upon issuing a rotated refresh token, MUST NOT extend the lifetime
of the new refresh token beyond the lifetime of the initial
refresh token if the refresh token has a preestablished expiration
time

Proposed Solution

Rotate refresh tokens on each refresh token request (already available feature)
Expire refresh tokens if they are not used within a specific time interval
For public clients, do not extend the lifetime of the original refresh token (first refresh token received via login).

[1] https://tools.ietf.org/html/draft-ietf-oauth-browser-based-apps-06#section-8

We need to look at this as well https://tools.ietf.org/html/draft-ietf-oauth-security-topics-16#section-4.13

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


"1.12-tv" release

1.12-tv release to master
https://github.com/amardeshbd/android-daily-headlines/releases/tag/v1.12-tv

Current coverage is 0.00% (diff: 0.00%)

Merging #138 into master will not change coverage

@@           master   #138   diff @@
====================================
  Files           1      1
  Lines          27     36     +9
  Methods         0      0
  Messages        0      0
  Branches        0      0
====================================
  Hits            0      0
- Misses         27     36     +9
  Partials        0      0

Powered by Codecov. Last update 4bd3792...229c2f3


Signature pad doesn't work on a touch device where the page containing the signature zone is scrollable

This is similar to the issue : Signature_pad doesn't work properly when is inside ScrollView #109
In my case, I'm trying to include the signature pad on a webpage that has up/down scrolling and left/right swipe actions.
I'm wondering if you have an example of the code you mentioned, i.e. as you say " What I usually did was to have a "click/tap here to sign" link/button in a form that opened a new non-scrollable view with signature pad and some buttons (clear/save/cancel)."
Best regards / Colm OGAIRBHITH
P.S. Your work on this has been immensely helpful to me, many thanks

I also ran into this problem on an Android Tablet with Chrome browser. It does work so long as the screen isn't scrolled. Once the screen scrolls, the contents of the signature pad are erased. Curious what can be done, as a new window popup is a bit out of the flow for me.

Hello,
I have a solution for this problem consisting in detecting the start and stop of the scroll event. At start, simply get canvas data with the "toDataURL()" method. At scroll stop, put that data again with "fromDataURL()" method.
I'm going to make a pull request so this solution can be reviewed and tested.

@mirrikat45 @oscaramidasoft Quick question - do you handle window.resize or listen for orientationchange event? If scrolling causes resize to be triggered, maybe you could simply use orientationchange instead?

Hi Szymon,
I'm not calling any of these events. Are you suggesting to call
'orientationchange' just after setting Signature_pad's value back?
--
Òscar Pérez del Campo
Amidasoft Sistemes d'Informació, SL
c./ Emili Grahit, 59, entresol 1ª
17002 Girona
616 664 373 | 872 032 326
<EMAIL_ADDRESS><EMAIL_ADDRESS>http://www.amidasoft.com
2017-01-18 21:57 GMT+01:00 Szymon Nowak<EMAIL_ADDRESS>
@mirrikat45 https://github.com/mirrikat45 @oscaramidasoft
https://github.com/oscaramidasoft Quick question - do you handle
window.resize or listen for orientationchange event? If scrolling causes
resize to be triggered, maybe you could simply use orientationchange
instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/szimek/signature_pad/issues/197#issuecomment-273599467,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEj-lNUdqIlhmL8oSD-Q5FFUS3Y1ru-cks5rTny6gaJpZM4K0IUz
.

I just made a request pull with my solution...

Thanks for the PR, but could you prepare a demo page that shows the issue? I'd like to check why it's happening first, instead of implementing a workaround.

Hi,
the error happens on iPad, not on the browser. So, please, open this link on an iPad (tested with Safari on iPad):
https://jsfiddle.net/297nt83r/

Thanks! Unfortunately, I can't replicate it using iPad Simulator from Xcode, so I'll have to find someone with a real device to debug it.

Hi Szimek,
I'm reviewing it and I see that the jsfiddle I prepared works correctly on iPad... How strange...
It seems the problem is not with the library, but some interaction with other libraries I have in my project...
Please, could you reject the pull request?
And excuseme for any inconvenience...

No problem. Cheers!

@carbontracking @mirrikat45 Is it still an issue? I accidentally closed this issue, instead of PR and I'm not sure if it should be reopened.

I'm having this issue too. On a Asus MeMo Pad 7 in Chrome.
I tried the fix branch, but eventually, if you scroll enough, it will delete the signature.

Am facing the same issue.. Did anyone get solution for this? please share

This package works great on Desktop but not on iPhone. The error I get is: "Safari cannot open the page. The operation couldn't be completed. (WebKitBlobResource error 1.)"
Someone on Stackoverflow told me that this error is due to the way that iOS and some versions of Android (don't) handle the blob created by dataUrlToBlob.
Have you discovered another option for iOS and Android devices, please?

@VamMeejS The demo code for the "app" is just an example, but I agree that it could work better on Safari. Something like this would probably work better:
function download(dataURL, filename) {
  if (navigator.userAgent.indexOf("Safari") > -1 && navigator.userAgent.indexOf("Chrome") === -1) {
    window.open(dataURL);
  } else {
    var blob = dataURLToBlob(dataURL);
    var url = window.URL.createObjectURL(blob);

    // ... the rest of the current code
  }
}

I'm not sure what's the best way to detect if it's Safari or not. PRs are welcome ;)

Thank you, Szymon. That is helpful. It avoids the error and opens a window of the final signed image. My goal is to save to the database but I guess if it downloaded to the Photos app on the iPhone that would be acceptable. Do you know how to cause it to download the image to the Photos app on an iPhone, please?


doc: Trust model personas

Trust Model Introduction PR (https://github.com/confidential-containers/documentation/pull/22) needs reviewed and merged first.
This PR adds Persona considerations to the introduction.
I am addressing and closing comments relating to personas from https://github.com/confidential-containers/documentation/pull/16 here. Further Personas related comments should be made on this PR instead

Hi @magowan - are you still working on this?
Sorry I got distracted by holidays and CNCF sandbox process stuff. I will resolve the requested changes so we can get this merged.

OK back to it, addressed comments, welcome feedback , lets get this approved :-)

Renamed files to reflect naming schema and rebased .
appreciate there are things discussed we can look to add but would like to consider those for future and get this merged.
Then I will also get on with the host/guest view on a trust model.