Media in background

REDMINE-17771

Coverage remained the same at 99.208% when pulling 6430b750bcc93a5a76e8d26f7a1a70b6831ee531 on awaismbajwa:media-in-background into 219f5395e0c1c0c29e34ed39dc8250ee1f9776e7 on codevise:master.

A new approach is introduced in the last commit. If it is fine then I will remove older commits


MAINT: remove SciPy Central links.

Closes gh-225
ping @pv @ksurya - I'll mention this on the mailing list as well.

Cool, thanks for the quick answer. I cannot merge, but I +1 this PR!

Let's merge this and go ahead.


Dependencies with submodules containing submodules with relative urls fail to fetch

Problem
Depending on a crate with a submodule that contains a nested submodule with a relative url will fail to fetch.
Example:
[package]
name = "parent"

[dependencies]
dep1 = {git = "https://github.com/example/dep1"}

dep1/.gitmodules
[submodule "dep2"]
    path = dep2
    url = https://github.com/example2/dep2.git

dep2/.gitmodules
[submodule "dep3"]
    path = dep3
    url = ../dep3

This generates the error:
error: failed to get `dep1` as a dependency of package `parent`

Caused by:
  failed to load source for dependency `dep1`

Caused by:
  Unable to update https://github.com/example/dep1

Caused by:
  failed to update submodule `dep2`

Caused by:
  failed to update submodule `dep3`

Caused by:
  failed to fetch submodule `dep3` from ../dep3.git

An example of this happening in the wild is with mupdf-rs = {git = "https://github.com/messense/mupdf-rs"}
Steps
No response
Possible Solution(s)
No response
Notes
No response
Version
cargo 1.62.1 (a748cf5a3 2022-06-08)
release: 1.62.1
commit-hash: a748cf5a3e666bc2dcdf54f37adef8ef22196452
commit-date: 2022-06-08
host: x86_64-unknown-linux-gnu
libgit2: 1.4.2 (sys:0.14.2 vendored)
libcurl: 7.80.0-DEV (sys:0.4.51+curl-7.80.0 vendored ssl:OpenSSL/1.1.1n)
os: Arch Linux Rolling Release [64-bit]

Thanks for the report!  I believe that relative-path submodules are not supported at all at this time.  Closing as a duplicate of #7992.


ADC VREFINT calibration values

I needed to perform a supply-relative ADC measurement using the internal reference voltage. To do that you need to use the VREFINT calibration value, which is the adc value measured at 3V during production.
VREFINT calibration value is a 16 bit value at 0x1FFF_75AA (datasheet 3.13.2). I couldn't find it in the pac.
For now I solved it like this in my application, but I think this should be part of the hal crate.
/// Returns a pointer to VREFINT_CAL, the VREFINT calibration value
#[inline(always)]
const fn vrefint_ptr() -> *const u16 {
    // DS12766 3.13.2
    0x1FFF_75AA as *const _
}

fn adc_abs_voltage(vref_val: u32, adc_val: u32) -> (u32,u32) {

    // safe because read only memory area
    let vref_cal: u32 = unsafe {
       ptr::read_volatile(vrefint_ptr())  as u32
    };

    // RM0454 14.9 Calculating the actual VDDA voltage using the internal reference voltage
    // V_DDA = 3 V x VREFINT_CAL / VREFINT_DATA
    let vdda_mv = 3000u32 * vref_cal / vref_val;

    // RM0454 14.9 Converting a supply-relative ADC measurement to an absolute voltage value
    //                   Vdda
    // VCHANNELx = --------------- × ADC_DATAx
    //                FULL_SCALE
    let adc_mv = (vdda_mv * adc_val / 4095u32); // TODO: full scale depends on config

    (vdda_mv, adc_mv)
}

let vref_val: u16 = adc.read(&mut vref).expect("adc read failed");
let adc_val: u16 = adc.read(&mut adc_pin).expect("adc read failed");
let (vdda_mv, adc_mv) = adc_abs_voltage(vref_val as u32, adc_val as u32);

Do you guys have opinions on how to implement this in de hal adc driver?

I don't. Maybe some other stm32 hal already have this feature, we could copy design from there.

@ijager could you please take a look at https://github.com/stm32-rs/stm32g0xx-hal/pull/63?


Use SymbolicExpr instead of print_expression and pycode.

This solves issue #45

This merge request require the changes in https://github.com/pyccel/sympde/pull/42


Not resolved error codes by rc-decode

Hello Support Team,
I have 4 NV entries stored in the TPM.
3 of them are locked after they've been successfully written. They are supposed to be used as symmetric keys for AES-CBC later. The fourth one (not key) can be written any time for the application logic.
The following problems occur sporadically.
Application calls Tss2_Sys_GetCapability and afterwards Tss2_Sys_NV_ReadPublic in every 100 ms.
Unfortunately, Tss2_Sys_GetCapability returns 0x17A error code and Tss2_Sys_NV_ReadPublic returns with 0x169, sporadically. None of them can be resolved by re-decode.

Is there any timing constraints for these 2 functions or in general for nv ram access functions?
Can you help us to decode the 2 errors, why they suppose to mean?

Thank you for the support!
Best regards,
Andras Takacs

Your error codes look suspiciously like command codes, not real error codes. 0x17a is TPM_CC_GetCapability and 0x169 is TPM_CC_NV_ReadPublic. Are you sure those are reported as error codes? Then maybe something gets mixed up during communication and it would be interesting to see the corresponding data streams that are exchanged with the TPM.

Hello Webmeister!
Yes, I am sure, they are reported as return codes of the Tss2_Sys_GetCapability() and Tss2_Sys_NV_ReadPublic. I think you might be right, communication gets mixed up.
What should I do to be able to observe these exchanged data?
What should be activated?
Thanks!

@tkcsndrs I think @webmeister is pointing out correctly. Either the current/ previous tpm operation is taking too long or has rendered the tpm to a halt.
Are you able to run something like get random when this happens?

Hi,
get random operates well and Tss2_Sys_GetCapability, Tss2_Sys_NV_ReadPublic  at next call after 100ms.
I try to get the exchanged data.

@tkcsndrs Is this reproduce able with the tools code and can you output there output, or are you using the system api raw?
For the system API, the github is here: https://github.com/01org/TPM2.0-TSS
For general help (like this bug, as no bug is being reported), please use the mailing list:
https://lists.01.org/mailman/listinfo/tpm2

If you need firther help, hit the mailing list. https://lists.01.org/mailman/listinfo/tpm2


Create in app database for storing index/fetch status

As a user, I want to know that my data is being fetched, as well as how the fetch is going (i.e. % complete)
As a developer, I need to store these things across app restart.
Acceptance criteria

for any type of email account, we want to store how many emails we will be indexing, how many we have indexed, and how many we have fetched.

https://github.com/tiki/data/commit/48342bcde66f8d03a80ff58809123bf840510635


Incorrect round results

Research

[X] I've already searched and I could not find an existing issue or discussion about this issue.

Description
Some demos are reporting wrong round results.
Both RoundEnd event and GameRules.CSRoundResults give the same result, but that result doesn't match the one from HLTV.
Example : (map Vertigo) https://www.hltv.org/matches/2369946/ence-vs-astralis-pgl-cs2-major-copenhagen-2024-europe-rmr-b
official : 13 - 6
parser : 10 - 9
Code to reproduce
var path = "test.dem";

var demo = new DemoParser();

var winnerCounts = new Dictionary<int, int>();

demo.Source1GameEvents.RoundEnd += e =>
{
    Console.WriteLine($"Round end: winner {(CSTeamNumber)e.Winner}");

    if (winnerCounts.TryGetValue(e.Winner, out int count))
        winnerCounts[e.Winner] = count + 1;
    else
        winnerCounts[e.Winner] = 1;
};

await demo.StartReadingAsync(File.OpenRead(path), default);

while (await demo.MoveNextAsync(default))
{
}

Console.WriteLine();

foreach (var pair in winnerCounts)
{
    Console.WriteLine($"winner {pair.Key}: {pair.Value}");
}

Console.WriteLine();
Console.WriteLine("Game rules round results:");
Console.WriteLine(string.Join("\n", demo.GameRules.CSRoundResults));

Console.WriteLine("\nFinished!");

Affected demos
No response

Your algorithm of tracking rounds wrong, i think. In second phase every team swap his sides, defender to protector. So you have for example 6 wins by ct and 3wins by t, after swap t won but you track this win to wrong team cuz you re not to swap wins. All gona work if you swap winners score when become second phase.

Thank you very much. I totally forgot about team switching. Should be using CTeam.Score property.


Only try to publish to staging when email and key are present

Currently CI fails for users that are not part of the denoland github group. This fixes that by only trying to publish to cloudflare if email and cloudflareKey are present.

@ry What I did here doesn't work as secrets can't be accessed at all from external PR - this means that there is no good way to check if secrets are going to be available or not. Deploy staging would pretty much only work for you and Bert - how about removing the stage all together and only running staging deploys locally?


Add license

It'd be nice if you can add a license, it'd make easier to create a Neil package for Linux distros.
And thanks for Neil, it's small but quite helpful :)

@jlesquembre Do you have a suggestion for a license?

Not really, since you are the creator, that's up to you. I'm fine with the epl, as with babashka, but I'm fine with whatever you decide, or if you want to take some time to think about it

As per the JUXT blog post I'll be going just with MIT then.

Done.

👍 Perfect! Thanks for the quick answer


Request visionOS support

Hello @loganblevins,
Thank you for requesting this new feature. We take a look at implementing it into the SDK and let you now know when it will be ready for use.

@vazarkevych I'd love to help push this forward.
Please approve CI runners for my PR: https://github.com/growthbook/growthbook-swift/pull/52

@vazarkevych This can be closed if my PR #52 is approved + merged


Add continuous delivery for plugin

Summary
We prepare the artifacts for release and we upload to the release bucket instead. Also we upload in parallel the artifacts as a Github Release.
Ticket Link
Ticket: https://mattermost.atlassian.net/browse/CLD-4681

@phoinixgrr have a look


Is there a way to get a "final result" of continuous recognition async?

I am aware that continuous recognition async provides in-between results as the user is speaking.
Is there a way of getting a "final" output when stopping the recognition of everything that has been said?
(microphone client-side Javascript with sockets)

Hi @adammpolak, this is Darren from the Speech SDK team. Thank you for your question. If you stop recognition before the final results, you will not get the "final result" event (e.g. "Recognized" event in C#). You will need to store the latest intermediate result (e.g. from the "Recognizing" event in C#) and treat that as your final result.
Can you describe your scenario that requires you to support stopping recognition before a final result, but yet still need a result to process or display?
Thanks,
Darren

@adammpolak I'm closing the issue since it was answered and I have not heard back from you. Feel free however to reply anytime and tag me.
Darren

@adammpolak I'm correcting what I wrote above (now deleted). Per my reply in https://github.com/Azure-Samples/cognitive-services-speech-sdk/issues/1388 :
We always send a final result ("Recognized" event) based on whatever audio received by the time StopContinuousRecognitionAsync was called. So if you're in the middle of saying "this is a test" you may get "This is." as a final recognition result ("recognized" event) if you called Stop in the middle of the sentence.
The Recognized event will give you recognition results since the previous Recognized event (not since your started continuous recognition). In continuous recognition, you will get multiple Recognized events, after each pause in the audio (after each sentence).
Closing the issue. Feel free to reply here and tag me for any follow up questions, or open a new issue as needed. Thanks!


[CLI] Need a flow-typed update-cache command

Currently the cache updates itself if it's been more than 5 days since it was last used.
We should also include an update-cache command so users can quickly update the cache themselves.
(Also, while we're at it, might as well add a --update-cache flag to the install command too)

Maybe I will give it  a shot if nobody is working on that!

Go for it!

On May 28, 2016, at 7:15 PM, Patrick Stapfer<EMAIL_ADDRESS>wrote:
Maybe I will give it a shot if nobody is working on that!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

This issue should be closed ... I cannot do it sadly :-(


Build issue with nextJS

Followed the instructions of the getting started, but couldn't get a nextJS app running (typescript)
I believe you should probably pin the versions of wagmi and ethers you're using, because they change a lot.
Error:
Error: Cannot find module '/Users/nicholascharriere/privy/shopify-connect/node_modules/ethers/lib/utils' imported from<EMAIL_ADDRESS>Did you mean to import ethers/lib/utils.js?

@nichochar You can test a snapshot version using the following versions:
yarn add<EMAIL_ADDRESS>
yarn add<EMAIL_ADDRESS>
If you don't mind, can you let us know if these work for you? Here is a CodeSandbox repro if you need some help getting the package set up in Next. We're looking forward to hearing from you soon 😄

Yes, it worked. This unblocks me as I'm in the prototyping phase. Thanks

Yes, it worked. This unblocks me as I'm in the prototyping phase. Thanks

Nice! That's wonderful news.
Feel free to share your creation in the discussions show and tell category. We're looking forward to seeing what you create 😄
I'm going to go ahead and close this issue. Please feel free to re-open it if you need anything additional support or feel free to open another 🙌


RP235x support

Do we know enough yet what we need to do to be able to support RP2350 instead of just RP2040?

Initial support is coming in #3243, though much work remains.

I've preordered the raspberry pi pico 2 and would be willing to test it on actual hardware and write/verify some examples.

I've got a couple of Tiny2350 from pimoroni, got blinky to work without much trouble except that elf2uf2 would work because of hard float in the executable.
elf2uf2-rs ./target/thumbv8m.main-none-eabihf/debug/blinky
Error: "HARD-FLOAT not supported"

Worked around that by using picotool and this small script:
picotool-run.sh
picotool uf2 convert -t elf $1 out.uf2
picotool load out.uf2
picotool reboot

in .cargo/config.toml for the runner
This is a quick workaround until we get support in elf2uf2 for thumbv8m.main-none-eabihf or full probe-rs support.

JP has a pull request for elf2uf2-rs to allow use with the rp2350. https://github.com/JoNil/elf2uf2-rs/pull/33

However, I recommend switching to picotool because it's faster and doesn't require mounting the disk drive. Binary releases are available from https://github.com/raspberrypi/pico-sdk-tools/releases

I'm running into a bit of issue, but I'm getting different behavior after picotool reboot and resseting the RP2350 (using reset button on Tiny2350, or just unplugging the Pico2). After picotool reboot it works fine every time, but the reset get's it into a partially broken state.
This is more or less the current setup, it's reproducible if I remove the USB part and just leave the blinky loop
#[embassy_executor::main]
async fn main(spawner: Spawner) {
    let peripherals = embassy_rp::init(Default::default());

    let other_side_channel = OTHER_SIDE_CHANNEL.init(Channel::new());

    UsbHandler::new(peripherals.USB, other_side_channel, spawner, true);

    let delay = 100;

    let mut counter = 0;
    #[cfg(feature = "tiny2350")]
    {
        let mut red_led = Output::new(peripherals.PIN_18, Level::Low);
        let mut green_led = Output::new(peripherals.PIN_19, Level::Low);
        let mut blue_led = Output::new(peripherals.PIN_20, Level::Low);
        green_led.set_high();
        blue_led.set_high();
        red_led.set_high();
        loop {
            log::info!("Tick {}", counter);
            counter += 1;
            red_led.set_low();
            Timer::after_millis(delay).await;

            red_led.set_high();
            Timer::after_millis(delay).await;

            green_led.set_low();
            Timer::after_millis(delay).await;

            green_led.set_high();
            Timer::after_millis(delay).await;

            blue_led.set_low();
            Timer::after_millis(delay).await;

            blue_led.set_high();
            Timer::after_millis(delay).await;
        }
    }

    #[cfg(feature = "pico2")]
    {
        let mut led =  Output::new(peripherals.PIN_25, Level::Low);
        led.set_low();
        loop {
            log::info!("Tick {}", counter);
            counter += 1;
            led.set_high();
            Timer::after_millis(delay).await;
            led.set_low();
            Timer::after_millis(delay).await;
        }
    }

}

On picotool reboot the blinks and log-over-usb works fine, as expected, but when using reset on Tiny2350 or unplugging and plugging in on Pico2, the blinks are not there, while log-over-usb gets set up most of the time.
Any clues on why this is happening? I'm planning to solder the headers tomorrow so I can try to set up UART and see if I get more info that way.

I don't think this is correct:
https://github.com/embassy-rs/embassy/blob/423e5d7655d038ead9ad7f5f448cabbd0b330660/embassy-rp/src/clocks.rs#L515

I suspect picotool reboot initializes ticks, and embassy-rp does not, here's my log collected through defmt-uart

0.037927 INFO  Defmt serial test
0.038167 INFO  USB: config_descriptor used: 94
0.038175 INFO  USB: bos_descriptor used: 12
0.038182 INFO  USB: msos_descriptor used: 0
0.038188 INFO  USB: control_buf size: 256
0.038432 INFO  Defmt tick 0
0.238699 INFO  Defmt tick 1
0.364565 DEBUG SET_CONFIGURATION: configured
0.365786 DEBUG Set line coding to: LineCoding { stop_bits: One, data_bits: 8, parity_type: None, data_rate: 9600 }
0.438751 INFO  Defmt tick 2
0.537203 DEBUG Set dtr true, rts true
0.638785 INFO  Defmt tick 3
0.838805 INFO  Defmt tick 4
1.038821 INFO  Defmt tick 5
1.238837 INFO  Defmt tick 6
1.438854 INFO  Defmt tick 7
1.638870 INFO  Defmt tick 8
1.838886 INFO  Defmt tick 9
2.038903 INFO  Defmt tick 10
2.238919 INFO  Defmt tick 11

0.000000 INFO  Defmt serial test
0.000000 INFO  USB: config_descriptor used: 94
0.000000 INFO  USB: bos_descriptor used: 12
0.000000 INFO  USB: msos_descriptor used: 0
0.000000 INFO  USB: control_buf size: 256
0.000000 INFO  Defmt tick 0
0.000000 DEBUG SET_CONFIGURATION: configured
0.000000 DEBUG Set line coding to: LineCoding { stop_bits: One, data_bits: 8, parity_type: None, data_rate: 9600 }
0.000000 DEBUG Set dtr true, rts true

First part is picotool reboot and second is manual restart, note the timestamps
I'll try to submit a pull request for this today if I'm right and setting ticks up fixes it.

Nice catch. When doing the initial support I loaded all my firmware using the uf2 method, and so the usb bootloader must've set up timer0 for me. Since the bootrom source is available it'd probably be a good idea to take a look through for anything else it was doing for me.

just calling this out for anybody https://hackaday.com/2024/09/04/the-worsening-raspberry-pi-rp2350-e9-erratum-situation/

I'm working on adding TRNG support, hopefully I have a draft this weekend.

It otc 14. Is any progress for the RP2350 Pico2...

Embassy doesn't have board specific code, but embassy does support the rp2350, yes. Check out the examples here: https://github.com/embassy-rs/embassy/tree/main/examples/rp23

Embassy doesn't have board specific code, but embassy does support the rp2350, yes. Check out the examples here: https://github.com/embassy-rs/embassy/tree/main/examples/rp23

i known it support, but not publish it to crates.io yet.
in
embassy-rp = "0.2.0"

features not support `rp235xa'

For now you'll have to use a git dependency. See here: https://embassy.dev/book/index.html#_how_do_i_switch_to_the_main_branch

For now you'll have to use a git dependency. See here: https://embassy.dev/book/index.html#_how_do_i_switch_to_the_main_branch

thanks bro, i have do it now.

I don't think this is correct:
https://github.com/embassy-rs/embassy/blob/423e5d7655d038ead9ad7f5f448cabbd0b330660/embassy-rp/src/clocks.rs#L515

I suspect picotool reboot initializes ticks, and embassy-rp does not, here's my log collected through defmt-uart

0.037927 INFO  Defmt serial test
0.038167 INFO  USB: config_descriptor used: 94
0.038175 INFO  USB: bos_descriptor used: 12
0.038182 INFO  USB: msos_descriptor used: 0
0.038188 INFO  USB: control_buf size: 256
0.038432 INFO  Defmt tick 0
0.238699 INFO  Defmt tick 1
0.364565 DEBUG SET_CONFIGURATION: configured
0.365786 DEBUG Set line coding to: LineCoding { stop_bits: One, data_bits: 8, parity_type: None, data_rate: 9600 }
0.438751 INFO  Defmt tick 2
0.537203 DEBUG Set dtr true, rts true
0.638785 INFO  Defmt tick 3
0.838805 INFO  Defmt tick 4
1.038821 INFO  Defmt tick 5
1.238837 INFO  Defmt tick 6
1.438854 INFO  Defmt tick 7
1.638870 INFO  Defmt tick 8
1.838886 INFO  Defmt tick 9
2.038903 INFO  Defmt tick 10
2.238919 INFO  Defmt tick 11

0.000000 INFO  Defmt serial test
0.000000 INFO  USB: config_descriptor used: 94
0.000000 INFO  USB: bos_descriptor used: 12
0.000000 INFO  USB: msos_descriptor used: 0
0.000000 INFO  USB: control_buf size: 256
0.000000 INFO  Defmt tick 0
0.000000 DEBUG SET_CONFIGURATION: configured
0.000000 DEBUG Set line coding to: LineCoding { stop_bits: One, data_bits: 8, parity_type: None, data_rate: 9600 }
0.000000 DEBUG Set dtr true, rts true

First part is picotool reboot and second is manual restart, note the timestamps
I'll try to submit a pull request for this today if I'm right and setting ticks up fixes it.

Hey, do you think you could expand on what you meant by defmt-uart if you get a chance? Looking at getting  some kind of logging working for the Pico 2. Is it a feature for a crate already in embassy or another project like defmt-serial. I I've just been using the rp23 uart example to log over to the debug probe. Any projects or examples you could point me to would be greatly appreciated! Thank you!


(fix): add .strict() to yargs to catch mistyped options

if the user mistypes an option, for example create-near-app --frrontend react myapp, the option was ignored and the app created anyway with the default options (vanilla).
By adding .strict(), yargs emits an error

fix: work even if yarn is not installed, fixes #409

Thanks for this!


Modify styling

Codecov Report

Merging #122 (454dfa9) into master (2ccb0e1) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #122   +/-   ##
=========================================
  Coverage     60.96%   60.96%
  Complexity      546      546
=========================================
  Files           104      104
  Lines          2001     2001
  Branches        232      232
=========================================
  Hits           1220     1220
  Misses          713      713
  Partials         68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ccb0e1...454dfa9. Read the comment docs.


Bug: Contradictory information on the appropriate shape of data

Please make sure these conditions are met

[X] I have checked that this issue has not already been reported.
[X] I have confirmed this bug exists on the latest version of anndata.
[ ] (optional) I have confirmed this bug exists on the master branch of anndata.

Report
Hello,
My apologies if this is a trivial question, but I am a new anndata user attempting to combine two anndata objects (one generated in seurat, and another with velocyto). While doing this, I am attempting to copy UMAP coordinates from the Seurat object to the velocyto object, and I keep getting an error that seemingly contradicts itself on the shape of the data I should be inputting.
Also, I've listed the versions of everything. I tried to install the most recent versions, but I cannot install them on the cluster I am working on (pip can't find it).
Please let me know if you have any further questions.
All the best,
Joe
Code:
#!/bin/bash

#SBATCH -p scavenge --mem=240G
#SBATCH -c 20
#SBATCH -t 24:00:00
#SBATCH --mail-type=ALL
##SBATCH --mail-user=[my user]
ml Python/3.8.6-GCCcore-10.2.0
python3.8 -c '
# ------- 1. installing packages common to all vignettes -------
print("Step 2: cellrank preprocessing has begun")
import numpy as np
import sys
import pandas as pd
import cellrank as cr
import scvelo as scv
import scanpy as sc
import warnings
import re
#from cellrank.tl.kernels import Kernel
warnings.simplefilter("ignore", category=UserWarning)

## ------- 2. Configuring basic packages -------
scv.settings.verbosity = 3
sc.settings.set_figure_params("scvelo") #these may change as we wish
cr.settings.verbosity = 2
warnings.simplefilter("ignore", category=UserWarning)

# ------- 3. read input data from the h5ad file generated by seurat and the loom file generated from velocyto  -------
seurat_output_path="/gpfs/gibbs/pi/hafler/jw2894/Data/RNA_Velocity_Pipeline/H5AD_Files/"
seurat_output_name="BLOOD_TEST.h5ad"                                       #Aagin, this will soon change to be a shell argument (so I can pass it in via $files from find)
seurat_output_path+=seurat_output_name
velocyto_output_path="/gpfs/gibbs/project/hafler/jw2894/200427_Blood_GEX/velocyto/"
velocyto_output_name="200427_Blood_GEX.loom"
velocyto_output_path+=velocyto_output_name
adata_seurat = scv.read(seurat_output_path, cache=True) #This is the path to the Seurat clustering output
adata_velocyto = scv.read(velocyto_output_path, cache=True) #This is the path to the Count matricies generated by Velocyto
# Loading in test data & confirming
#scv.pl.proportions(adata)                      #Commented out for now (12/5) since it is causing a crash
print("This is adata_seurat: ", adata_seurat)
print("This is adata_velocyto: ", adata_velocyto)

# -------- 4. Merging together the anndata objects --------

#Part one: merging together the obseration layers

#This step is necessary as the seurat anndata object has already had QC measures to filter out low quality cells, while the velocyto anndata object has not.
#Therefore, the first step in this process is subsetting out the cells in common (IE the ones that have passed seurats quality test and have count matrix data)
#Example name instance for seurat cell: AAACCTGAGCAGGCTA-1
#Example name instance for velocyto cell: 200427_Blood_GEX:AACCGCGTCAAACCGTx

#Match this via regex on seurat name to identify only A-Z characters and then parse velocyto name for matching substring
seurat_obs_names = adata_seurat.obs_names

# Define a regex pattern to match letters
letter_pattern = r"[A-Z]+"

# Use regex to extract letters
seurat_letters = [re.search(letter_pattern, name).group(0) for name in seurat_obs_names]

# #Subsetting the seurat dataset
# #Next, we need to take the ideal UMAP resolution (agreed to be .4 for now)
 umap_clusters = adata_seurat.obs["RNA_snn_res.0.4"]

# #Its possible we may need to update UMAP coordinates
# #Create entry to store UMAP coordinates in
adata_velocyto.obsm["X_umap"] = np.array(adata_velocyto.obsm.get("X_umap", []))

# # Create a dictionary mapping observation names to UMAP coordinates
umap_dict = dict(zip(adata_seurat.obs_names, adata_seurat.obsm["X_umap"]))
# # Update UMAP coordinates in adata_velocyto
# # Choose a specific name from the Velocyto dataset
for name in matching_velocyto_obs_names:
     modified_name = re.sub(r".*:", "", name) #Remove the colon and everything before
     modified_name = re.sub(r"x", "", modified_name) #remove the lowercase x at the end
     modified_name += "-1"
     adata_velocyto.obsm["X_umap"].append(umap_dict[modified_name]) #Error is here

...

Traceback:
  File "<string>", line 122, in <module>
  File "/home/jw2894/.local/lib/python3.8/site-packages/anndata/_core/aligned_mapping.py", line 181, in __setitem__
    value = self._validate_value(value, key)
  File "/home/jw2894/.local/lib/python3.8/site-packages/anndata/_core/aligned_mapping.py", line 245, in _validate_value
    return super()._validate_value(val, key)
  File "/home/jw2894/.local/lib/python3.8/site-packages/anndata/_core/aligned_mapping.py", line 77, in _validate_value
    raise ValueError(
ValueError: Value passed for key 'X_umap' is of incorrect shape. Values of obsm must match dimensions (0,) of parent. Value had shape (0,) while it should have had (5400,).

Versions
>>> import anndata, session_info; session_info.show(html=False, dependencies=True)
-----
anndata             0.9.2
pip                 20.2.3
session_info        1.0.0
-----
cython_runtime      NA
dateutil            2.8.2
h5py                3.10.0
mpl_toolkits        NA
natsort             8.4.0
numpy               1.24.4
packaging           20.4
pandas              2.0.3
pkg_resources       NA
pytz                2020.1
scipy               1.10.1
setuptools_scm      NA
sitecustomize       NA
six                 1.15.0
sphinxcontrib       NA
-----
Python 3.8.6 (default, Apr 21 2023, 14:59:47) [GCC 10.2.0]
Linux-4.18.0-477.27.1.el8_8.x86_64-x86_64-with-glibc2.2.5
-----
Session information updated at 2023-12-07 17:05

Hello,
I really appreciate you taking the time to update and test everything so rigorously. I just installed the main branch (via pip install git+https://github.com/scverse/anndata.git@main#egg=anndata) and I am still running into the same issue. Is this intended for now? Is there some way I could rewrite my code to make it compatible?
Many thanks for your help!


Is it only applied to MSRC-21 dataset?

Hi lucasb-eyer,
I am working on post-processing the output of CNN using densecrf on PASCAL VOC dataset. It seems your code doesn't works on it. Is it only applied to MSRC-21 dataset? If so, would you be willing to public your training/learning code?
Looking forward your reply. Thank you in advance.
                                                                                Carrie

Hi, I have no idea what you're talking about for various reasons:

What does "doesn't work" mean? Just saying "doesn't work" is not helpful.
This code is completely independent of any dataset whatsoever. I don't even know MSRC-21 :)
Learning has not been wrapped in this code yet, as I have written in the README file.

I'm closing this issue since there is no real issue. But feel free to open a new issue with the actual error that you get and enough context for me to be able to understand it.


[frontend] Fetch for latest data for update forms

Ignore cached data from Relay store and always fetch for latest data before render update forms (Hardware Type, System Model, Device Group, etc.)

Done in #505


Update MNIST.ipynb

Corrected typo

Thanks for the fix!

Fixed the typo when re-syncing tutorials.


Modified ip_ranges to accept no arguments

Allows passing function calls to ip_ranges without checking for empty results
Still generates warnings
I'm using cross-VPC rules so no security groups, only IP ranges.
As a result, I sometimes have rules with "no sources" (no VMs matching that specific role) and they fail.
This fix allows ip_ranges to accept no arguments which generates a warning and might create an empty permission (which gets deleted).
Note that a group with ip_ranges=[] is identical to the empty group thanks to the normalization
If you think this is wrong, please LMK and we can try and find out if there's an agreeable way to solve my issues

Thanks for pull request :smiley:

v0.2.8.beta3 has been released.
Please try it out :smiley:

Hi
I'm unhappy with my changes. Apologies.
I will think of a better solution
Nitzan Raz
http://backslasher.net
On Wed, May 13, 2015 at 3:49 PM, I left from github. probably... <
<EMAIL_ADDRESS>wrote:

v0.2.8.beta3 has been released.
Please try it out [image: :smiley:]
—
Reply to this email directly or view it on GitHub
https://github.com/winebarrel/piculet/pull/12#issuecomment-101653036.

:+1:


Remove BiFunction

Koryphe currently supports both BinaryOperator and BiFunction, but BiFunction is only used to implement aggregation where the output type is different to the input type. These examples would be clearer if implemented by applying a function to either the input or output of a BinaryOperator.
Any other uses of BiFunction should be implemented as a Function that accepts a Tuple input type.

Merged into develop


Worker.js outputted in wrong location for web_worker_fib demo project

Problem
The example project showing how to use web workers does not seem to function, as the worker.js file is not outputted in the correct location.  It looks like it's being outputted to https://examples.yew.rs/web_worker_fib/worker.js, but the client is trying to load it from https://examples.yew.rs/worker.js
Steps To Reproduce
Steps to reproduce the behavior:

Go to the webworker yew demo
Open dev tools and open the networking tab
Notice the worker.js has failed to load. (And, by extension ,the demo does not work)

(bonus step 4). Go to /web_worker_fib/worker.js and admire the code that was built.
Expected behavior
The file should have been loaded as a webworker and the location it was built to and the location it was attempted to be loaded from should be the same
Screenshots

Environment:

Browser and version, if relevant: Google Chrome Version 108.0.5359.99 (Official Build) (64-bit)

Questionnaire

[x] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[ ] I don't have time to fix this right now, but maybe later

I ran into this issue when I was investigating why my own project was not outputting any worker.js file at all

Does this work when you clone the repo and run it manually? Having run into this before, it may be that however the hosted example is built, it is not built with correct "public url" semantics, allowing it to be hosted at a subpath

@vpochapuis  you may want https://docs.rs/yew-agent/0.1.0/yew_agent/trait.Agent.html#method.resource_path_is_relative if your worker is not at the root as well - I remember having to do that for a previous project

@SpanishPear I'm fairly sure that's what's wrong with the demo as well. PR in coming


Build fails.

Hi I've tried go-getting gore (go get github.com/motemen/gore) and it doesn't build:
Dev/go/src/github.com/motemen/gore/commands.go:251: too many arguments in call to mainScope.LookupParent

Cheers!

mainScope.LookupParent signature was changed. Please upgrade golang.org/x/tools/go/types. See #23.

Thanks, as @syohex says, you need update tools/go/types by go get -u golang.org/x/tools/go/types.


finished last modal

i# Please enter the commit message for your changes. Lines starting

Looks good to me


Token format IOS 13

Hi ,
I'm getting the incorrect ios token like this {length=32,bytes=0x2936b8f014b120c8b09287086dd5837f...bb1f7af2eb2ccea2}
with below enviroment. By some reason I have to work on Meteor version <IP_ADDRESS> and cannot upgrade version
Cordova CLI version and cordova platform version
cordova --version : 7.1.0
cordova platform version ios: 4.2.1

Plugin version
cordova plugin version | grep phonegap-plugin-push: 1.8.4 - I have to work on this version by Meteor version

Have anyone get the same issue?

This is a problem I also had whilst working on ios 13 and my problem was fixed by updating the plugin to the latest version. Didnt find any other work around, I think ios 13 handles the tokens differently as to the previous ios versions, not sure but using the latest plugin definitely fixed it. :)

yeah, it was fixed in 2.3.0 version, so you have to update


improved GraphQL testing coverage

This PR improved the testing coverage of the GraphQL transporter.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@eed88a8). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #150   +/-   ##
=========================================
  Coverage          ?   81.76%
=========================================
  Files             ?      137
  Lines             ?     6296
  Branches          ?        0
=========================================
  Hits              ?     5148
  Misses            ?      789
  Partials          ?      359

Impacted Files
Coverage Δ

pkg/transport/graphql/arguments.go
94.66% <100.00%> (ø)

pkg/transport/graphql/field.go
94.73% <100.00%> (ø)

pkg/transport/graphql/graphql.go
66.66% <100.00%> (ø)

pkg/transport/graphql/options.go
100.00% <100.00%> (ø)

pkg/transport/graphql/response.go
70.58% <100.00%> (ø)


HV-1269 Modify JMH performance tests to prevent JVM optimisation skew…

…ing results

@gsmet Are you handling this one?

@gunnarmorling yes I want to make some additional clean up too.

Cool, thanks!

Closing this one, superseded by https://github.com/hibernate/hibernate-validator/pull/694 which integrates your changes.
@johnaohara Thanks


LDAP Configuration doesn't pick up AUTH_LDAP_USER_SEARCH correctly.

I am trying to debug LDAP configuration for allowing users to sign in with single sign on.  My LDAP server is OpenLDAP with base schemas available for posixAccount and InetOrgPerson, which should be sufficient.  SSO from netbox to ldap works, so I know it is possible to get django-auth-ldap to be happy with this setup at the least.
I added the following lines to my environment file to configure ldap, and changed the tag on the pulled image to be the ldap one:
AUTH_LDAP_ATTR_FIRSTNAME: "cn"
AUTH_LDAP_GROUP_SEARCH_BASEDN: "dc=example,dc=com"
AUTH_LDAP_GROUP_SEARCH_CLASS: "groupOfNames"
AUTH_LDAP_GROUP_TYPE: "GroupOfNamesType"
AUTH_LDAP_IS_ADMIN_DN: "cn=netbox_admin,ou=group,dc=example,dc=com"
AUTH_LDAP_IS_SUPERUSER_DN: "cn=netbox_admin,ou=group,dc=example,dc=com"
AUTH_LDAP_MIRROR_GROUPS: "true"
AUTH_LDAP_REQUIRE_GROUP_DN: "cn=netbox_ro,ou=group,dc=example,dc=com"
AUTH_LDAP_SERVER_URI: "ldaps://ldap.example.com"
AUTH_LDAP_START_TLS: "false"
AUTH_LDAP_USER_SEARCH_BASEDN: "ou=people,dc=example,dc=com"
AUTH_LDAP_USER_SEARCH_ATTR: "uid"
AUTH_LDAP_USER_DN_TEMPLATE: "uid=%(user)s,ou=people,dc=example,dc=com"
AUTH_LDAP_BIND_AS_AUTHENTICATING_USER: "true"

I reliably get the error message that AUTH_LDAP_USER_SEARCH is not an instance of LDAPSearch:

However when I check the type of that config attribute via a manage.py shell, the type is clearly LDAPSearch:
>>> type(_loaded_configurations[1].AUTH_LDAP_USER_SEARCH)
<class 'django_auth_ldap.config.LDAPSearch'>

I'm at my whit's end here for what could still be preventing this from working, is there something I've just missed?

Did you try to enable django ldap logging to see if it gives something, with a config like (see also logging.py)?
LOGGING = {
    "version": 1,
    "formatters": {
        "simple": {
            "format": "%(asctime)s | %(levelname)s | %(message)s",
            "datefmt": "%Y-%m-%d %H:%M:%S",
        }
    },
    "handlers": {"console": {"class": "logging.StreamHandler", "formatter": "simple"}},
    "loggers": {
        "django_auth_ldap": {"handlers": ["console"], "level": "DEBUG"},
    },
}

Hmm, I have not yet attempted to do this inside the container as I couldn't come up with a good way to configure logging inside.  Is there some trick to setting up logging or should I just exec in and edit the file?

The file should be mounted in the container if you use the docker compose base setup. Just editing it and restarting the containers should be enough.

Ah, I am deploying the containers via another mechanism.  I'll just exec in and make an edit, will likely be tomorrow though before I can mess with this again though.

Doesn't look like that has made any change.  I ported all my ldap config down to the docker-compose environment so I could debug more easily.  This is what the log shows for my login attempt:
peering-manager-docker-peering-manager-1  | 2023/02/08 20:15:33 [info] 40#40 "peeringmanager" application started
peering-manager-docker-peering-manager-1  | <IP_ADDRESS> - - [08/Feb/2023:20:15:33 +0000] "GET /login/?next=/ HTTP/1.1" 200 3280 "http://localhost:8080/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36"
peering-manager-docker-peering-manager-1  | 2023-02-08 20:15:40 | WARNING | AUTH_LDAP_USER_SEARCH must be an LDAPSearch instance. while authenticating maldridge
peering-manager-docker-peering-manager-1  | AUTH_LDAP_USER_SEARCH must be an LDAPSearch instance. while authenticating maldridge
peering-manager-docker-peering-manager-1  | <IP_ADDRESS> - - [08/Feb/2023:20:15:40 +0000] "POST /login/ HTTP/1.1" 500 1261 "http://localhost:8080/login/?next=/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36"

Anything else I need to do to make logging work in the compose environment?

Yes, I did see the relevant lines in the output. I am now running the
example directly to make my debug environment closer to the provided
example that is known working.
On Wed, Feb 8, 2023, 4:52 PM Guillaume Mazoyer @.***>
wrote:

Do you see some lines like Loaded config  in your docker
logs?
Did you mount all the configuration directory like it's done in the docker
compose example ./configuration:/etc/peering-manager/config?
—
Reply to this email directly, view it on GitHub
https://github.com/peering-manager/docker/issues/25#issuecomment-1423343035,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARW3FTIPNTB57ZZ45QVFW3WWQPTFANCNFSM6AAAAAAUCA23OM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Too bad it does not log anything then :/
Did you try to inspect via manage.py shell the actual variables that are in the settings module like the following?
>>> from django.conf import settings
>>> settings.VERSION
'v1.7.4'
>>> settings.LDAP_CONFIGURED
True
>>> settings.AUTH_LDAP_USER_SEARCH
...

Well, that looks like a smoking gun to me:
$ docker compose exec -it peering-manager /bin/sh
/opt/peering-manager $ . venv/bin/activate
(venv) /opt/peering-manager $ ./manage.py shell
⚙  Loaded config '/etc/peering-manager/config/configuration.py'
⚙  Loaded config '/etc/peering-manager/config/extra.py'
⚙  Loaded config '/etc/peering-manager/config/logging.py'
⚙  Loaded config '/etc/peering-manager/config/ldap/ldap_config.py'
⚙  Loaded config '/etc/peering-manager/config/ldap/extra.py'
Python 3.9.16 (main, Dec 10 2022, 13:47:19)
[GCC 10.3.1 20210424] on linux
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> from django.conf import settings
>>> settings.VERSION
'v1.7.4'
>>> settings.LDAP_CONFIGURED
True
>>> settings.AUTH_LDAP_USER_SEARCH
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/opt/peering-manager/venv/lib/python3.9/site-packages/django/conf/__init__.py", line 88, in __getattr__
    val = getattr(self._wrapped, name)
AttributeError: 'Settings' object has no attribute 'AUTH_LDAP_USER_SEARCH'

What's curious to me is that in configuration/ldap/ldap_config.py at the root of this repo is the following block:
AUTH_LDAP_USER_SEARCH = LDAPSearch(
    AUTH_LDAP_USER_SEARCH_BASEDN,
    ldap.SCOPE_SUBTREE,
    "(" + AUTH_LDAP_USER_SEARCH_ATTR + "=%(user)s)",
)

This gets installed to /etc/peering-manager/config/ldap/ldap_config.py which then gets read by /opt-peering-manager/peering_manager/ldap_config.py.  The value looks pretty clearly defined, so I'm not really seeing why this shouldn't work.  In fact all ldap attributes seem to behave this way even though they're set in the environment.  This is really behaving like the environment parsing or the loading via this other file is just broken.

OK so I tried to reproduce your issue and managed to so by using the default setup.
However that's actually weird behaviour. Peering Manager settings load the peering_manager.ldap_config module to know if LDAP is config and imports all variables defined in it. In the container CLI, I can see that the module is there and properly loaded.
(venv) /opt/peering-manager $ python manage.py shell
Python 3.9.16 (main, Dec 10 2022, 13:47:19)
[GCC 10.3.1 20210424] on linux
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> from peering_manager import ldap_config as l
>>> l.AUTH_LDAP_USER_SEARCH
<LDAPSearch: ou=people,dc=example,dc=com>
>>>

But for some reason, the main settings module does not pick these settings up.
>>> from django.conf import settings
>>> settings.AUTH_LDAP_USER_SEARCH
Traceback (most recent call last):
  File "<console>", line 1, in <module>
  File "/opt/peering-manager/venv/lib/python3.9/site-packages/django/conf/__init__.py", line 88, in __getattr__
    val = getattr(self._wrapped, name)
AttributeError: 'Settings' object has no attribute 'AUTH_LDAP_USER_SEARCH'
>>>

I either don't know how this work anymore or there is an issue somewhere, well there's obviously an issue somewhere.

At any rate I'm glad this isn't just me having missed something simple.  Let me know if there's anything I can do to further assist in troubleshooting.

Hi, any fixes or workarounds for this? I seem to be having the same issues.
I've also tried volume mounting directly over /etc/peering-manager/config/ldap/ldap_config.py to see what would happen and it seems when i do this ldap settings are totally ignored.

some debug by volume mounting directly over /etc/peering-manager/config/ldap/ldap_config.py to see what would happen
bash-5.1# . venv/bin/activate
(venv) bash-5.1# ./manage.py shell
Python 3.9.17 (main, Jun  9 2023, 02:31:24)
[GCC 10.3.1 20210424] on linux
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> from django.conf import settings
>>> settings.VERSION
'1.8.3'
>>> settings.LDAP_CONFIGURED
True
>>> settings.AUTH_LDAP_USER_SEARCH
<LDAPSearch: ou=people,dc=example,dc=com>

Watching access logs on LDAP I do not see peering-manager hitting it.
Happy to try things if you have suggestions

Progress Update + Final Success
Indeed volume mounting/overwriting ldap_config.py to /opt/peering-manager/peering_manager/ldap_config.py makes it take the configs.
Also blink and you miss it, the commented out logging file has 'filters': ['require_debug_false'], on console that blocked debug logs showing in the container logs...
With the above two fixed I was able to see what i needed to adjust in my ldap_config.py to make login work.

Also blink and you miss it, the commented out logging file has 'filters': ['require_debug_false'], on console that blocked debug logs showing in the container logs...

Nice catch. I completely overlooked this one.


My codespace starts on safe mode

Hi,
Please help restore my codespace, I'm using it for Harvard's CS50, today when I opened it it started it crashed and keeps defaulting to safe mode, I would like it back to how it was please, to keep with the classes, if not fixable could you assist in resetting it please? I tried to create anothere codespace but it threw an errror too (500).
Version: 1.72.1
Commit: 129500ee4c8ab7263461ffe327268ba56b9f210d
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Embedder: codespaces

cc @jkeech

@kusanagi2029 The Codespace service had a global outage yesterday, this may lead to 500 errors you saw. Can you retry again today? Let us know if it still does not work for you.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Problem with nn.Replicate(1)

In order to use the nn.SpatialBatchNormaliztion during test I need to simulate a batch (4D) from a single sample image (3D), i.e make a 1xNxM --> 1x1xNxM tensor. I use nn.Replicate(1) for this but the cudnn.SpatialConvolution complains about its input. Here is the code to reproduce the error:
m = nn.Sequential()
m:add(nn.Replicate(1))
m:add(cudnn.SpatialConvolution(1,3,5,5))
m:cuda()
m:forward(torch.rand(1,7,7):cuda())
I got this:
/torch/install/share/lua/5.1/cudnn/init.lua:58: Error in CuDNN: CUDNN_STATUS_BAD_PARAM
stack traceback:
[C]: in function 'error'
/torch/install/share/lua/5.1/cudnn/init.lua:58: in function 'errcheck'
/torch/install/share/lua/5.1/cudnn/init.lua:76: in function 'toDescriptor'
/torch/install/share/lua/5.1/cudnn/SpatialConvolution.lua:108: in function 'createIODescriptors'
/torch/install/share/lua/5.1/cudnn/SpatialConvolution.lua:339: in function 'updateOutput'
/torch/install/share/lua/5.1/nn/Sequential.lua:44: in function 'forward'
[string "_RESULT={m:forward(torch.rand(1,7,7):cuda())}"]:1: in main chunk
[C]: in function 'xpcall'
/torch/install/share/lua/5.1/trepl/init.lua:650: in function 'repl'
/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:199: in main chunk
[C]: at 0x00406670
But this works perfect
m.modules[2]:forward(torch.rand(1,1,7,7):cuda()):size()
By the way the nn version also works
m.modules[2] = nn.SpatialConvolution(1,3,5,5)
m:forward(torch.rand(1,7,7):cuda()):size()
Any workaround for the batch simulation is also welcome.

@xonobo can't you just take your input and do
input=input:view(1,input:size(1),input:size(2),input:size(3))

before feeding the input to the network ?

Some time ago I observed that cudnn doesn't like 0-strides, I think this is the case. fmassa's solution should work.

I tried this but now gives an assertion fail
m:forward(torch.rand(1,7,7):view(1,1,7,7):cuda())
/torch/install/share/lua/5.1/cudnn/SpatialConvolution.lua:92: assertion failed!
stack traceback:
[C]: in function 'assert'
/torch/install/share/lua/5.1/cudnn/SpatialConvolution.lua:92: in function 'createIODescriptors'
/torch/install/share/lua/5.1/cudnn/SpatialConvolution.lua:339: in function 'updateOutput'
/torch/install/share/lua/5.1/nn/Sequential.lua:44: in function 'forward'
[string "_RESULT={m:forward(torch.rand(1,7,7):view(1,1..."]:1: in main chunk
[C]: in function 'xpcall'
/torch/install/share/lua/5.1/trepl/init.lua:650: in function 'repl'
/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:199: in main chunk
By the way I want to handle this dummy resizing in the model. Since the input sizes of the images may vary I could not use nn.View.

@xonobo remove the nn.Replicate from your network.
Also, no need to use the nn.View module, apply the view directly to the input data, this way it's independent on the input size

ok forgot to remove the replicate. Now it works.
Thanks for the solution. This is not what I exactly want but handle the resizing of input before feeding to the model.

if you absolutely want to have the nn.Replicate(1) in your network, add also just after it a nn.Copy(nil,nil,true), and then you can feed the input without viewing it. But it won't handle the case where the input is already batched.


Why is it that most model directories do not have a file named run_expid.py？

I found that most model directories do not have a file named run_expid.py. For example, I wanted to run the DIEN model on the amazonelectronics_x1 dataset. Following the steps described in the readme.md, I installed the corresponding version of fuxictr, but did not find the run_expid.py file. So, I copied the run_expid.py from the directory of the DCN model, but still encountered errors during execution:
Traceback (most recent call last):
  File "F:\RecommendationSystem\BARS\ranking\ctr\DIEN\run_expid.py", line 12, in <module>
    from fuxictr.features import FeatureMap, FeatureEncoder
ImportError: cannot import name 'FeatureEncoder' from 'fuxictr.features' (E:\Anaconda\envs\py310-torch2\lib\site-packages\fuxictr\features.py)

This is because the fuxictr version specified in the DIEN model directory's readme.md is 2.0.2, while the DCN model requires version 1.1.0, leading to the run_expid.py in the DCN model directory being incompatible with the DIEN model. How can this be resolved?It seems that the API has changed between different versions of fuxictr. Could you provide a universal run_expid.py file? Or could you provide a run_expid.py file for each model?

Please follow the instruction to cd to the model_zoo folder to run:
cd FuxiCTR/model_zoo/DIEN
FuxiCTR is the directory you download.


Update explanation of difference in "individual heterozygosity" query

@deflaux
The difference between the query and vcftools is smaller now as a result of earlier fixes to the query (https://github.com/googlegenomics/codelabs/commits/master/R/PlatinumGenomes-QC/sql/homozygous-variants.sql). Updated the explanation as a result.

Signed CLA for my gmail account as well (asha.rostamianfar@gmail.com).

Excellent - thank you @arostamianfar


🐞 [Bug]: Color Issue with Manage SSH Button

Is there an existing issue for this?

[X] I have searched the existing issues

which package/s did you face the problem with?
Dashboard
What happened?
the manage ssh button color is a little bit dark in the light mode

I even compared it with the 'Get TFT' button, and they do not have the same color code. Shouldn't the colors of buttons be unified?
after an investigation found out that the color codes for the buttons are a little bit different
rgb(26, 161, 143)
rgb(25, 144, 128)
Steps To Reproduce
No response
which network/s did you face the problem on?
Dev, QA
version
2.4
Twin ID/s
No response
Node ID/s
No response
Farm ID/s
No response
Contract ID/s
No response
Relevant screenshots/screen records

Relevant log output
-

The manage ssh keys button's color has been changed

verified on devnet
version : db2daf4
manage ssh button is now replaced with the horizontal menu (slider)

testcase


Update for the latest Bepinex version

Tried to put it on the newest bepinex version but the plugin doesn't load sadly
LogOutput.log

You need to use the 577 version linked in the readme. As other BepInEx addons for this game also use this version I'm not going to update it to the most recent one to avoid incompatibilities.


feat: Identity alias

Thanks for submitting a PR! Please check the boxes below:

[ ] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes

Allows you to specify an alias for identities
The flagsmith app will now start identifying by id rather than email

How did you test this code?

_

Related https://github.com/Flagsmith/flagsmith/issues/4016

@kyle-ssg as discussed, let's force the input to lower case.

@matthewelwell done

@kyle-ssg this still feels a little bit unpolished to me. The main 2 issues I have are:

I'm not sure why we can't apply the same logic that we have in for e.g. feature names which doesn't allow you to input upper case characters at all, and instead automatically lower cases them as you type.
It's quite annoying that it clears the whole alias when you click 'Edit' - what happens if I just realised that I made a typo and I want to quickly fix it? I now have to re-enter the whole thing. Can we get the edit to just 'edit in place' as it were?


Editable Text Area.

Already using the text area to display a chat like UI, which is great!!! There is one use case that I don't see covered, what if I want to have an Editable Text Area, let's say that I want to allow users to send a feedback message, a small UI to set your email and a text area where users can type to send the message, we do have Input Text, but it does not feel like the right UI for things like this.

This is a great idea and I agree, making TextArea editable is a great enhancement. Creating the initial implementation of TextArea was how I tested if I wanted to use this library or not since it didnt support linewrapping etc yet. But I didnt need it to be editable yet for my own game so didn't work on it. I'll see about prioritizing this when I get some free time.

Thinking for a texteditor widget it'd need to combine existing textinput and textarea functionality and add:

Support for selecting characters
Copy/Paste
Vertical cursor navigation
Common keyboard selection and navigation shortcuts


systest: parametrize storage

closes: https://github.com/spacemeshos/go-spacemesh/issues/3330
parametrize storage so that network can be used with a higher load

bors try

bors merge


How to deploy it from the commandline?

I made a .peg file (online) that validates. I would like to use in at home on the commandline. I installed pegjs from the Ubuntu 16.04 repos. I did pegjs tldr.peg and it produced a tldr.js file.
How do I use that on the commandline? I have files I'd like to check.

So you want to create a command line tool that use's the .peg you created and validate files based on command line parameter?
for ex:
validate_file ~/file.blah

@pepa65

@jodevsa That's what I'm trying to achieve..!

The generated tldr.js is just a general library; invoked by parse function, you gotta write a program that does this !
1- read the file
2- send file content to tldr library
3- output result ?
PEG.js generated library function definition:
var parser=require('./tldr').parse;
extract data from the file you want and use parser(fileContent) !

If you're using Node, here's a more concrete example:
#!/usr/bin/env node

'use strict';

//
// echo "2 + 3" | node compile.js arithmetics.pegjs
// echo "2 + 3" | node compile.js javascript.pegjs
//

let fs = require('fs');
let peg = require('../lib/peg');

let grammar = fs.readFileSync(process.argv[2]).toString();
let parser = peg.generate(grammar);
let input = [];

compile(process.stdin);

function compile(stdin) {
  stdin.resume();
  stdin.setEncoding('utf8');

  stdin.on('data', (data) => input.push(data));

  stdin.on('end', () => {
    let output = parser.parse(input.join('').trim());

    console.log(JSON.stringify(output, null, 2));
  });
}

Maybe it would be helpful to have an app that does that more generally.

@mikeaustin  Clearly this isn't the easiest way for him to understand what you did
@pepa65  Check this out:
#!/usr/bin/env node

'use strict';

const fs = require('fs');
const parser = require('./tldr.js').parse;

function main() {
    const arguments = require('process').argv;
    if (arguments.length != 3) {
        console.error("Enter file Path as argument.")
        return 1;
    }
    filename = arguments[2];
    fs.readFile(filename, {encoding: 'utf8'},function(err, data) {
        if (err) {
            console.log("error while reading the file!");
            console.error(err);
            return 1;
        }

        try {
            let output = parser(data);
            console.log(output)

        } catch (e) {
            console.error(e.message);

        }

    });

}

main();

put it in a folder with you'r tldr.js  lets say you named it check_file

chmod +x check_file

add folder location to $path  in ~/.bashrc and reset terminal

now you can use it like this, check_file ~/file.txt

@mikeaustin I don't seem to have ../lib/peg even though I have node-pegjs (and peg) installed.
What I am after is a generalized node script that I could call like: peg-check tldr.pegjs file-to-be-checked where tldr.pegjs is the output of pegjs tldr.peg tldr.pegjs and file-to-be-checked contains the text being checked.
Or, if pegjs could optionally output a script that incorporates tldr.pegjs, so that pegjs tldr.peg -s tldr.js would output a script that could be used like: tldr.js file-to-be-checked that would raise the usability of pegjs enormously for the uninitiated..!

@jodevsa Thanks!
I got
let output = parser(data);
            ^^^

SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

So I added 'use strict';, but then I got:
const arguments = require('process').argv;
          ^^^^^^^^^

SyntaxError: Unexpected eval or arguments in strict mode

I guess my javascript-fu is not strong enough...

@pepa65  i updated the code, check it again
my bad :(

@pepa65  i'm using node v 8.0.0 , if another error pop's out  just replace each "let" and "const" with var

@pepa65
NVM, just try this
#!/usr/bin/env node

  'use strict';

  var fs = require('fs');
  var parser = require('./tldr.js').parse;

  function main() {
      var args = require('process').argv;
      if (args.length != 3) {
          console.error("Enter file Path as argument.")
          return 1;
      }
      var filename = args[2];
      fs.readFile(filename, {encoding: 'utf8'},function(err, data) {
          if (err) {
              console.log("error while reading the file!");
              console.error(err);
              return 1;
          }

          try {
              var output = parser(data);
              console.log(output)

          } catch (e) {
              console.error(e.message);

          }

      });

  }

  main();

const works fine here. The only snag I hit was that tldr.js contained printf (which I replaced with console.log), but then it works!
The only thing I don't understand that it ends the output with undefined no matter what.

weird, javascript does'nt even have "printf" function; even older versions
if you'r okay with posting your grammar public, it would be easier for me to help

O, sorry, reviewing my peg, I saw that I had wrongly added { printf("OK");}, so I changed that.
But it still ends with undefined. My grammar:
page = header description examples eof { console.log("OK");}
header = command nl underline nl nl
description = (descriptor nolowercase any dot nl)+
examples = example (nl example)*
example = example_description nl example_command
example_description = nolowercase any colon nl
example_command = fourspace any nl
command = [a-zA-Z0-9_][-a-zA-Z0-9_ ]*
underline = '='+
any = [a-z ()-,-.={}/_0-9A-Z]*
nolowercase = [^a-z]
descriptor = '> '
fourspace = '    '
dot = .
colon = ':'
nl = [\n]
eof = !.

@pepa65 That's because the running script that @jodevsa gave you logs the result of running the peg grammar; because your top-level page rule ends with a console.log, the PEG will return undefined to the running script.
You can either change the console.log(OK) to return "OK";, ignore the undefined that's printed, or remove the console.log(output) line from the running script.
Hope that helps!

@hawkrives  :+1:

Right, silly of me. Makes it easier! I think I got things to where I can proceed. Thank you all!

I guess, as a summary to those who come here looking for the final answer, use this script, perhaps call it grammar-check:
#!/usr/bin/env node
'use strict';

const fs = require('fs');
const parser = require('./grammar.js').parse;

function main() {
  const args = require('process').argv;
  if (args.length != 3) {
    console.error("Only 1 argument needed: file-path")
    return 1;
  }
  const filename = args[2];
  fs.readFile(filename, {encoding: 'utf8'}, function(err, data) {
    if (err) {
      console.log("Error reading file", filename);
      console.error(err);
      return 1;
    }
    try {
      let output = parser(data);
      console.log(output);
    }
    catch (e) {
      console.error(e.message);
    }
  });
}

main();

Do chmod +x grammar-check and compile your grammar like: pegjs your-grammar.peg grammar.jsand after that you can deploy like:grammar-check filename` (where filename is the location of the file to be checked).

Looks good! Thanks for making a more complete example, @jodevsa. I was assuming he knew JavaScript.
But that kind of brings up the idea that people may want to use PEG.js without even knowing JavaScript at all. I think it would be handy to provide a program that can generically read a grammar and input file, and output to a file or standard output.

I think it would be handy to provide a program that can generically read a grammar and input file, and output to a file or standard output.

Shall this issue be reopened, then?

@mikeaustin @waldyrious perhaps instead of making a separate "program" - this can just be mentioned in the readme? With an example of implementing such a thing.

Feel free to use the working example above..!

perhaps instead of making a separate "program" - this can just be mentioned in the readme?

@mikeaustin's comment suggests that a separate program does have a convenience benefit for end users, and I agree with that.

@waldyrious This issue was a question, I'm going to open a new issue for what @mikeaustin suggested, one that should see the feature implemented for 0.11 (if it's a simple addition with no problems), but might be pushed to 1.0 (if it raises some error's, I'll push it back to sort out later). Should be simple to implement though after I'm done with the command line tool rewrite.
Sorry @pepa65 for not replying earlier, but to be honest with you, until @waldyrious posted his comment today, I didn't even know the issue existed 😆


feat: Add new gateway listing page

Adds a new Gateway listing and detail page by reusing the DataplaneListing/Detail pages/views. The Type filter was also removed from the Dataplane Proxies page (seeing as it now only shows one type) but kept in the Gateways page to filter between builtin and delegated. The Type column was removed entirely from the Dataplane Proxy listing.
I wasn't totally sure whether to reuse this like this or not, but it worked out ok, and considering Gateways are still classed as 'Dataplane Proxies' it kinda  feels ok.

Main approach sets a top level type on the routes meta and then decides on the tiny details between the two types dependant on that. The rest of the changes are trying to work in with what is already there for the moment, ~so just filtering out/in gateway type dataplane proxies where appropriate.~
The current implementation makes new HTTP requests whenever the Type: dropdown is changed, using the gateway= query param the backend then responds with the correctly filtered dataset.
There is at least one more general 'bug' I found whilst doing this in that the pagination buttons display on this listing whether the listing has data or not, also seems to show them whether you have other pages or not also. This is something to look at separately.
Signed-off-by: John Cowen<EMAIL_ADDRESS>

nit: protocol doesn't make sense on the gateway.

Suggestion: Please change src/app/App.vue:82 to include the new view so that the layout is taking up all available space.
- const isWideContent = computed(() => typeof route.name === 'string' && ['data-plane-list-view', 'service-list-view'].includes(route.name))
+ const isWideContent = computed(() => typeof route.name === 'string' && ['data-plane-list-view', 'service-list-view', 'gateway-list-view'].includes(route.name))

There is at least one more general 'bug' I found whilst doing this in that the pagination buttons display on this listing whether the listing has data or not, also seems to show them whether you have other pages or not also. This is something to look at separately.

@johncowen I’m almost certain this is just an consequence of the mock data at src/api/mock-data/meshes/default/dataplanes+insights.json containing a value for the next field. Setting it to null makes it so that no pagination button is shown.

Minor thing is that there's still a "details" sidebar if you change gateway type to delegated even if the table is empty. I guess that when you toggle you should clear the selection.
Also just so you know the api has been enriched with this filters for gateway=:

true: list all gateways of any type
false: list no gateway
provided: list only provided gateways (which would give proper pages vs client side filtering)
builtin: list only builtin gateways

I think it might useful to leverage this feature now no?

Minor thing is that there's still a "details" sidebar if you change gateway type to delegated even if the table is empty. I guess that when you toggle you should clear the selection.

Ah good spot, will update in a sec

Also just so you know the api has been enriched with this filters for gateway=:

true: list all gateways of any type
false: list no gateway
provided: list only provided gateways (which would give proper pages vs client side filtering)
builtin: list only builtin gateways
I think it might useful to leverage this feature now no?
Yes definitely! I figured towards the end of last week that if we are doing paging on the backend, that means we also have to do sorting/filtering/searching on the backend also, otherwise the paging and the data is out of sync. I was gonna look through the docs/ask if we have ability to do these things in the HTTP API and looks like for this one we have. I'll take better look at this one also in a sec, ty!

Use delegated instead of standard in the type column please


Acronym is working in office.com now

[Enter feedback here]
I just tested today an i can see that Acronyms are working from Office.com as well. is it because my tenant is part of the targeted release? If yes, can you please update the documentation and FAQ section now with expected date?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8fd51764-80a7-b404-50bd-b492b193dab2
Version Independent ID: 62a6858b-81a3-bafa-4bcc-3bb2a951c654
Content: Manage Acronym answers in Microsoft Search
Content Source: MicrosoftSearch/manage-acronyms.md
Service: mssearch
GitHub Login: @jeffkizn
Microsoft Alias: jeffkizn

Hi @dhawal16,
We have recently enabled Acronyms to targeted release customers on SharePoint and we are in the process of rolling out to customers world wide. Thanks for reaching out to us, we have noted your feedback. The team is working on updating the documentation and FAQ section.


Add visual indicators for node states (stopped, paused)

When stopped nodes are shown on the canvas, they are only differentiated by position and lack of connections - but this could be improved by using colour/transparency/icons/shape changes.
A paused node should also be indicated - this may be a rare state, so the visual cue should be clear - it does not need to be an iteration of the stopped node indicator.

[ ] Indicate a node is stopped by varying the graphical form of the node
[ ] Add a visual cue to nodes that are paused
[ ] Add a visual cue to nodes that are restarting

See also https://github.com/weaveworks/scope/issues/970

Here's another option, taking a cue from MoC...
When the node selector is set to 'both' then hovering over the alternatives (e.g. 'Stopped Containers' and 'Running Containers') could highlight the nodes in that state.

As a user, I want to distinguish (in the graph topology view) stopped and paused containers from running containers when all are visible, so that I can navigate faster to a given container (e.g. that I want to start).
As a user, I want to distinguish (in the graph topology view) stopped containers from containers that are running but are unconnected (no edges), when both are displayed, so that I can quickly identify whether a container is running (or not).


LookupError: No FeatureType with the name Digital Currency Address - XBT found

The nightly CI run of the tool fails with the following error:
  mkdir data
  python3 generate-address-list.py XBT ETH XMR LTC ZEC DASH BTG ETC BSV BCH XVG USDC USDT XRP TRX ARB BSC -f JSON TXT -path ./data
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.11.9/x64
    PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.9/x64/lib/pkgconfig
    Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
    Python[2](https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/actions/runs/8954302705/job/24593793734#step:6:2)_ROOT_DIR: /opt/hostedtoolcache/Python/[3](https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/actions/runs/8954302705/job/24593793734#step:6:3).11.9/x64
    Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.9/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.9/x6[4](https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/actions/runs/8954302705/job/24593793734#step:6:4)/lib
Traceback (most recent call last):
  File "/home/runner/work/ofac-sanctioned-digital-currency-addresses/ofac-sanctioned-digital-currency-addresses/generate-address-list.py", line 109, in <module>
    main()
  File "/home/runner/work/ofac-sanctioned-digital-currency-addresses/ofac-sanctioned-digital-currency-addresses/generate-address-list.py", line 97, in main
    address_id = get_address_id(root, asset)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/ofac-sanctioned-digital-currency-addresses/ofac-sanctioned-digital-currency-addresses/generate-address-list.py", line 4[5](https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/actions/runs/8954302705/job/24593793734#step:6:5), in get_address_id
    raise LookupError("No FeatureType with the name {} found".format(
LookupError: No FeatureType with the name Digital Currency Address - XBT found
Error: Process completed with exit code 1.

The XML namespace in the sdn_advanced.xml changed:
< <Sanctions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" Version="3" xsi:schemaLocation="https://sanctionslistservice.ofac.treas.gov/api/PublicationPreview/exports/ADVANCED_XML https://sanctionslistservice.ofac.treas.gov/api/PublicationPreview/exports/ADVANCED_XML.xsd" xmlns="https://sanctionslistservice.ofac.treas.gov/api/PublicationPreview/exports/ADVANCED_XML">
---
> <Sanctions xmlns="http://www.un.org/sanctions/1.0" Version="3" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.un.org/sanctions/1.0 http://www.treasury.gov/ofac/downloads/sanctions/1.0/sdn_advanced.xsd">

Since we hardcode the namespace, this broke.
https://github.com/0xB10C/ofac-sanctioned-digital-currency-addresses/blob/e8601228850ceaa45905c7861256f322ec4ff09d/generate-address-list.py#L9


Get PeerInfo ready for IPv6

While IPv6 is not handled yet, the Marshal/Unmarshal phase should reserve a byte to specify IP's length for future use.
This will avoid to change serialization format when IPv6 will be supported

Closing as obsolete


What is "X" and "Y"?

You could be more explicit on these terms.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2ec94566-4b0c-9c6d-8732-1668c80efeee
Version Independent ID: c2d18cab-0ca9-102e-6de5-25710f9b9ad7
Content: Tools for working with Azure Storage
Content Source: articles/storage/common/storage-explorers.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

@SquGus Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate, We'll check if we can add a legend. Y is "Yes" , X is whether the specific service is supported/available on the mentioned tools.

@SquGus - Thanks for your feedback. I have updated this topic to contain only Microsoft-maintained tools, and used Yes/No for clarity.
#please-close


⚠ Bofrost.fr has degraded performance

In 8909120, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 2338 ms

Resolved: Bofrost.fr performance has improved in cb703a8 after 6 minutes.


vue3 import() import variables

Description
Hope to support vue3 ()=>import() import variables
Suggested solution
no
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Can you describe it in more detail?


Improve guided tour order

The guided tour is not showing our latest impressive simulations and focus too much on old robots.
Added

Telemax
ure

Dropped

hoap2 sumo: old robot + redundant with RobotisOp3
IPR factory: old robot + redundant with universal robots
srv-1: old robot + redundant with lot of small robots and tracks are shown in the Telemax
Stewart platform: does not match a real robot, rendering is too simplistic
ghostdog:  does not match a real robot, rendering is too simplistic

Sorted
Aim: have a modern and a maximum of features in the few first worlds:

Telemax: shows camera, tracks, complex mechanics, stairs (and so accurate physics)
RobotisOP3: shows an existing humanoid moving and showing balance
URe: shows a good looking and modern robotics arm
city.wbt: shows a vehicle simulation
animated skin: shows skinning and a more biological simulation
tinker bots: shows modular robotics and toy
blimp: (unfortunately) our best flying model showing fluids and propellers

Everything coming after has some redundancy IMO

@fabienrohrer as we just discussed by phone, I have slightly changed the telemax controller to make it more interesting in the 30 first seconds.

👍

👍


jQuery?

Semantic cannot find jQuery even when added.
<script type="text/javascript" src="https://code.jquery.com/jquery-3.2.1.min.js"></script><script type="text/javascript" src="semantic/dist/semantic.min.js"></script>
anything i can do?

Hi @lordjbs, what’s the status of jQuery’s request?

uhm, I don't get any error, so I don't know what to say..

@lordjbs I’m assuming it’s 200, but still, please open developer tools, go to the Network tab, reload the page, find the jQuery request and see its status there. Also, please check if jquery-3.2.1.min.js is above the semantic.min.js.

Tried browser and stuff, i guess its electron messing around. Thanks :D

Closing as resolved then.


Add a missing bazel file for cloudprovider/ecs

What this PR does / why we need it:
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?:

NONE

/approve


archive/tar: Writer outputs invalid PAX format after writing GNU format

This is not a regression and has been the behavior since Go1.4.2, possibly way earlier.
The problem:

The logic for the Writer outputs the magic bytes for the GNU format if the usedBinary flag is true.
This flag is set to true if a numeric field could not be encoded in base-8 and had to be promoted to base-256.
This flag is never reset, thus permanently forcing the Writer to use the GNU format even if PAX headers are used.

It is highly likely that we have been generating invalid PAX files under certain circumstances. The reason why this has not been reported yet is because the the GNU and BSD tar tools both liberally accept these invalid files without complaint. In fact, our own Reader liberally accepts this invalid hybrid of both GNU and PAX.

Repro: https://play.golang.org/p/_LX4tNrHcB


Proposal: Detachable and draggable terminal view

It makes life easier to have a detachable terminal view that floats on the page (instead of doing tons of scrolling).
Useful when monitoring resource usages, like watch -n1 nvidia-smi

seems to be impossible


R21C HISTORY output specs (precip, land, landice, ...)

This PR proposes updated R21C HISTORY specs on top of @sdrabenh's R21C branch.
See also matching PR #356 in GEOSgcm_App
These updates will eventually need to find their way into the default and/or FP file specs in the 'develop' branch, which will require another PR.

Details:
Updates are focused on (but not entirely limited to) land and landice outputs.
For land outputs in the "lnd" collection, appended/inserted "LAND" in LONG_NAME wherever there's any chance at all that users could be confused that the output is only over land tiles.
Clarified LONG_NAME for volumetric soil moisture (m3/m3) vs dimensionless soil wetness.
Made variables that are exported in R21C consistent across land and landice (incl. runoff).
Fixed sign issue for GHTSKIN in landice.
Still to do:

Figure out how to deal with LONG_NAME of model vs. corrected precipitation.  In MERRA-2, the words "bias corrected" were appended somehow to LONG_NAME for PRECTOTLAND and PRECSNOLAND.
a. "Bias corrected" is not a good term; going forward, we should use "observation corrected" because the corrections are applied at the daily scale.
b. Adding "observation corrected" to the LONG_NAME in *GridComp.F90 files requires thought because currently the F90 files supports both uncorrected and corrected precip over land in the same export variable.

Add runoff (and other variables?) averaged across land and landice.  [DONE @lcandre2, @gmao-rreichle 16Nov22]

Resolve conflicting signs for GHTSKIN (GHLAND?) in landice and land collections.  [DONE @lcandre2 16Nov22]

Resolve assorted in-line comments (to be added). [DONE @gmao-rreichle 17Nov22]

I'll keep working on this, but please feel free take a look and add your 2c.
For precip outputs, figure out how to clarify model vs. corrected in the LONG_NAME.
cc: @elakkraoui @lcandre2 @gmao-qliu @lltakacs @sdrabenh @rcullath @rdkoster @rlucches

Ok, thanks Rolf.
Richard Cullather
ESSIC, University of Maryland at College Park
c/o NASA/GSFC Code 610.1 (Bldg. 33 / Rm. G114)     Tel: +1<PHONE_NUMBER>
8800 Greenbelt Road                                 Fax: +1<PHONE_NUMBER>
Greenbelt, MD 20771                   e-mail<EMAIL_ADDRESS>
From: Rolf Reichle<EMAIL_ADDRESS>Sent: Sunday, September 11, 2022 5:27 PM
To: GEOS-ESM/GEOSgcm_GridComp<EMAIL_ADDRESS>Cc: Cullather, Richard I. (GSFC-610.1)[UNIVERSITY OF MARYLAND]<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [GEOS-ESM/GEOSgcm_GridComp] R21C HISTORY output specs (precip, land, landice, ...) (PR #637)

Assigned #637<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS-ESM%2FGEOSgcm_GridComp%2Fpull%2F637&data=05%7C01%7Crichard.cullather%40nasa.gov%7Cad5c10bcb714456e2c5408da943c67e4%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637985284415213365%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=zXRyH0hssiVdF%2Fx65utdorhJlW6oAzP2pfvPBdqxae4%3D&reserved=0> to @rcullath<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Frcullath&data=05%7C01%7Crichard.cullather%40nasa.gov%7Cad5c10bcb714456e2c5408da943c67e4%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637985284415213365%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VOi%2Ba%2B8%2BtpFxKeAMOnWhkBjJKN7UunOHuPbNDHUqxzg%3D&reserved=0>.

-
Reply to this email directly, view it on GitHub<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS-ESM%2FGEOSgcm_GridComp%2Fpull%2F637%23event-7362967414&data=05%7C01%7Crichard.cullather%40nasa.gov%7Cad5c10bcb714456e2c5408da943c67e4%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637985284415213365%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=iF%2BdA%2B2jvN5GPBleR7atjt%2FvD6a%2BgUSqTJWy%2F8o1mtA%3D&reserved=0>, or unsubscribe<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPJB4W44K3NPNTZT3GVJQATV5ZFDJANCNFSM6AAAAAAQJ6FYIU&data=05%7C01%7Crichard.cullather%40nasa.gov%7Cad5c10bcb714456e2c5408da943c67e4%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637985284415213365%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=uBxufysDNC%2Binj3ED5dhS7hlK4N8ZzoiN3WS9QymXOo%3D&reserved=0>.
You are receiving this because you were assigned.Message ID: ***<EMAIL_ADDRESS>

Ok, thanks Rolf.
Richard Cullather
ESSIC, University of Maryland at College Park
c/o NASA/GSFC Code 610.1 (Bldg. 33 / Rm. G114)     Tel: +1<PHONE_NUMBER>
8800 Greenbelt Road                                 Fax: +1<PHONE_NUMBER>
Greenbelt, MD 20771                   e-mail<EMAIL_ADDRESS>
From: Rolf Reichle<EMAIL_ADDRESS>Sent: Sunday, September 11, 2022 6:02 PM
To: GEOS-ESM/GEOSgcm_GridComp<EMAIL_ADDRESS>Cc: Cullather, Richard I. (GSFC-610.1)[UNIVERSITY OF MARYLAND]<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [GEOS-ESM/GEOSgcm_GridComp] R21C HISTORY output specs (precip, land, landice, ...) (PR #637)

@gmao-rreichle commented on this pull request.

________________________________

In GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOS_SurfaceGridComp.F90<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS-ESM%2FGEOSgcm_GridComp%2Fpull%2F637%23discussion_r967894184&data=05%7C01%7Crichard.cullather%40nasa.gov%7Cb86bde88615c4c92311d08da944131b1%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637985304972790793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Ncpu4TjusE9enZroCaB2oaB9NJuJ17oz%2B3d7ByNfSmI%3D&reserved=0>:

> @@ -1599,7 +1599,7 @@ subroutine SetServices ( GC, RC )

   VERIFY_(STATUS)

   call MAPL_AddExportSpec(GC,                    &

-    LONG_NAME          = 'snow_ice_evaporation_energy_flux',&

+    LONG_NAME          = 'snow_ice_evaporation_energy_flux_on_land',&

     UNITS              = 'W m-2'                     ,&

     SHORT_NAME         = 'EVPICE'                    ,&

EVPICE and EVPSNO need cleanup and reconciliation with landice. The MERRA-2 "lnd" file specs imply that EVPICE is the evaporation over snow for land tiles only. But EVPICE also exists in landice, which suggests that at the level of SurfaceGC (which is the source for "lnd" output), EVPICE is the average over land and landice. Also, in the CatchGC, there's a seemingly redundant export EVPSNO. Possibly, this is what should be written out as the land-only avg evaporation over snow.

-
Reply to this email directly, view it on GitHub<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS-ESM%2FGEOSgcm_GridComp%2Fpull%2F637%23pullrequestreview-1103359566&data=05%7C01%7Crichard.cullather%40nasa.gov%7Cb86bde88615c4c92311d08da944131b1%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637985304972790793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3QLsxdYxcb6HmNDW8ESGlUjM2I6xNgsXHGD%2FNU3gRIQ%3D&reserved=0>, or unsubscribe<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPJB4W72H4JQITNOUQT5XNLV5ZJDZANCNFSM6AAAAAAQJ6FYIU&data=05%7C01%7Crichard.cullather%40nasa.gov%7Cb86bde88615c4c92311d08da944131b1%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637985304972790793%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2Bo7MbD8Nhm7bLBohJc2dZZmVaAWMXCYYJRdprkRE4Vk%3D&reserved=0>.
You are receiving this because you were assigned.Message ID: ***<EMAIL_ADDRESS>

Richard,
Why did I get this message 6 times?
Rob
On Mon, Sep 12, 2022 at 06:29:03AM -0700, rcullath wrote:

Ok, thanks Rolf.
~~
Richard Cullather
ESSIC, University of Maryland at College Park
c/o NASA/GSFC Code 610.1 (Bldg. 33 / Rm. G114) Tel: +1<PHONE_NUMBER>
8800 Greenbelt Road Fax: +1<PHONE_NUMBER>
Greenbelt, MD 20771 e-mail<EMAIL_ADDRESS>From: Rolf Reichle<EMAIL_ADDRESS>Sent: Sunday, September 11, 2022 5:27 PM
To: GEOS-ESM/GEOSgcm_GridComp<EMAIL_ADDRESS>Cc: Cullather, Richard I. (GSFC-610.1)[UNIVERSITY OF MARYLAND]
<EMAIL_ADDRESS>Assign<EMAIL_ADDRESS>Subject: [EXTERNAL] [GEOS-ESM/GEOSgcm_GridComp] R21C HISTORY output
specs (precip, land, landice, ...) (PR #637)
This PR proposes updated R21C HISTORY specs on top of
@sdrabenh<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%
2F%2Fgithub.com%2Fsdrabenh&data=05%7C01%7Crichard.cullather%40nasa.gov%
7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43da96dd17b%7
C0%7C0%7C637985284423181061%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA
iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=j
bx7r46wUDAg3wz15mPGS51Bg4PAucj0pXm%2FRCdCK6Q%3D&reserved=0>'s R21C
branch.
See also matching PR #356 in
GEOSgcm_GridComp<https://gcc02.safelinks.protection.outlook.com/?url=ht
tps%3A%2F%2Fgithub.com%2FGEOS-ESM%2FGEOSgcm_App%2Fpull%2F356&data=05%7C
01%7Crichard.cullather%40nasa.gov%7C02f827fd50844984c6c108da943c692a%7C
7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637985284423181061%7CUnknown
%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX
VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=tvehsKFbSS8sXWCp%2BSeK8yud%2FV7aQq6IZD
8uTZuwGXk%3D&reserved=0>
These updates will eventually need to find their way into the default
and/or FP file specs in the 'develop' branch, which will require
another PR. This new PR will also need to update the CatchCN
GridComp(s).
cc:
@elakkraoui<https://gcc02.safelinks.protection.outlook.com/?url=https%3
A%2F%2Fgithub.com%2Felakkraoui&data=05%7C01%7Crichard.cullather%40nasa.
gov%7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43da96dd1
7b%7C0%7C0%7C637985284423181061%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sda
ta=4s2X6xmQvF3%2FBWpl%2F7YbOTpx3r%2BuUAdklvTalMkR7b8%3D&reserved=0>
@lcandre2<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%
2F%2Fgithub.com%2Flcandre2&data=05%7C01%7Crichard.cullather%40nasa.gov%
7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43da96dd17b%7
C0%7C0%7C637985284423181061%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA
iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=2
vY%2FxxOsDVcggPLonk3mPgv%2FWb92FvcF34tt6VvHEMk%3D&reserved=0>
@gmao-qliu<https://gcc02.safelinks.protection.outlook.com/?url=https%3A
%2F%2Fgithub.com%2Fgmao-qliu&data=05%7C01%7Crichard.cullather%40nasa.go
v%7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43da96dd17b
%7C0%7C0%7C637985284423181061%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata
=zpmULCakprJvF%2BRYM55dJ8FizFM1Hm4NsfIdD2NnXoQ%3D&reserved=0>
@lltakacs<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%
2F%2Fgithub.com%2Flltakacs&data=05%7C01%7Crichard.cullather%40nasa.gov%
7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43da96dd17b%7
C0%7C0%7C637985284423181061%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA
iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=h
lGblDufrmPj27605n7KyPRQ7v5OmQmOr0gXICCOu0o%3D&reserved=0>
@sdrabenh<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%
2F%2Fgithub.com%2Fsdrabenh&data=05%7C01%7Crichard.cullather%40nasa.gov%
7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43da96dd17b%7
C0%7C0%7C637985284423337305%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA
iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=r
vMgshiAovZbnlSXNo0bVtRFk7r%2B5kTkJ8exkFfxVsY%3D&reserved=0>
@rcullath<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%
2F%2Fgithub.com%2Frcullath&data=05%7C01%7Crichard.cullather%40nasa.gov%
7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43da96dd17b%7
C0%7C0%7C637985284423337305%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA
iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=O
YFg5UPd7H7KyGZKQi2Bl0Gk2FQPvGyCahrqxd6jyzo%3D&reserved=0>
@rdkoster<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%
2F%2Fgithub.com%2Frdkoster&data=05%7C01%7Crichard.cullather%40nasa.gov%
7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43da96dd17b%7
C0%7C0%7C637985284423337305%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDA
iLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=G
L169AqS%2FvN4QpDEf5FGdLeis%2Bol%2FG1riwo5oxKPCQU%3D&reserved=0>
________________________________
You can view, comment on, or merge this pull request online at:
https://github.com/GEOS-ESM/GEOSgcm_GridComp/pull/637<https://gcc02.saf
elinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS-ESM%
2FGEOSgcm_GridComp%2Fpull%2F637&data=05%7C01%7Crichard.cullather%40nasa
.gov%7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43da96dd
17b%7C0%7C0%7C637985284423337305%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sd
ata=%2BGJ06hCy4vERNs7FswqKdy3XciJaP4v%2BOf6cqStHvkY%3D&reserved=0>
Commit Summary
*
fcd3c71<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F
%2Fgithub.com%2FGEOS-ESM%2FGEOSgcm_GridComp%2Fpull%2F637%2Fcommits%2Ffc
d3c710a242253122fd79e84aa7982f03ce0acb&data=05%7C01%7Crichard.cullather
%40nasa.gov%7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d4
3da96dd17b%7C0%7C0%7C637985284423337305%7CUnknown%7CTWFpbGZsb3d8eyJWIjo
iMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7
C%7C&sdata=0D8oGcycI4I5hw%2FKoQQUF7adQJx2ksc8lYogaSunfV0%3D&reserved=0>
cleaned up LONG_NAME of various land-related export specs across
Surface, Catch, and VegDyn
File Changes
(3
files<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2
Fgithub.com%2FGEOS-ESM%2FGEOSgcm_GridComp%2Fpull%2F637%2Ffiles&data=05%
7C01%7Crichard.cullather%40nasa.gov%7C02f827fd50844984c6c108da943c692a%
7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637985284423337305%7CUnkno
wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLC
JXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fzcAfwGFaWA2BXji5k8HJMYm2AUose4Zke1j
hBMx4rU%3D&reserved=0>)
* M
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOS_Surfac
eGridComp.F90<https://gcc02.safelinks.protection.outlook.com/?url=https
%3A%2F%2Fgithub.com%2FGEOS-ESM%2FGEOSgcm_GridComp%2Fpull%2F637%2Ffiles%
23diff-60604dd512f7536a91b0feb51f1c647c5841730100d9f72b492e154c617a5f59
&data=05%7C01%7Crichard.cullather%40nasa.gov%7C02f827fd50844984c6c108da
943c692a%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C63798528442333730
5%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6I
k1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=BNZuE5irVLmSyzt1gv%2FeNnvav
qdUGy05hq1%2FkyVHvX4%3D&reserved=0> (70)
* M
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_Gr
idComp/GEOScatch_GridComp/GEOS_CatchGridComp.F90<https://gcc02.safelink
s.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS-ESM%2FGEO
Sgcm_GridComp%2Fpull%2F637%2Ffiles%23diff-806ed5b1cd92bd246b8715f16428d
d6c4963d68c1eb1b8f5944ffbc6f0ed09cf&data=05%7C01%7Crichard.cullather%40
nasa.gov%7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43da
96dd17b%7C0%7C0%7C637985284423337305%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC
4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7
C&sdata=4FrXynOSyvUF26SsnR8nMopkCXuhNcZIe5S6nxY1SyA%3D&reserved=0> (76)
* M
GEOSagcm_GridComp/GEOSphysics_GridComp/GEOSsurface_GridComp/GEOSland_Gr
idComp/GEOSvegdyn_GridComp/GEOS_VegdynGridComp.F90<https://gcc02.safeli
nks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS-ESM%2FG
EOSgcm_GridComp%2Fpull%2F637%2Ffiles%23diff-4f44717237bdd30df1f0a9a570f
92e20099f4e5b1a921d9bb718b842a3dac5c7&data=05%7C01%7Crichard.cullather%
40nasa.gov%7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43
da96dd17b%7C0%7C0%7C637985284423337305%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C
%7C&sdata=r%2F8Do%2Fh4Bcw5v4dCTCco%2B9H70TsD7DJYBdKrPEV797Y%3D&reserved
=0> (2)
Patch Links:
*
https://github.com/GEOS-ESM/GEOSgcm_GridComp/pull/637.patch<https://gcc
02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEO
S-ESM%2FGEOSgcm_GridComp%2Fpull%2F637.patch&data=05%7C01%7Crichard.cull
ather%40nasa.gov%7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8
140d43da96dd17b%7C0%7C0%7C637985284423337305%7CUnknown%7CTWFpbGZsb3d8ey
JWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000
%7C%7C%7C&sdata=bYy%2FIM4qPvlOOhXk7LTsvULh%2BZGnV%2BIUIkjFOrckF6g%3D&re
served=0>
*
https://github.com/GEOS-ESM/GEOSgcm_GridComp/pull/637.diff<https://gcc0
2.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS
-ESM%2FGEOSgcm_GridComp%2Fpull%2F637.diff&data=05%7C01%7Crichard.cullat
her%40nasa.gov%7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae814
0d43da96dd17b%7C0%7C0%7C637985284423337305%7CUnknown%7CTWFpbGZsb3d8eyJW
IjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7
C%7C%7C&sdata=c8ErHMSlqeByKIMRhY0BAeceaMYR6oR1U7Xc8eP4H5U%3D&reserved=0
>
-
Reply to this email directly, view it on
GitHub<https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%
2Fgithub.com%2FGEOS-ESM%2FGEOSgcm_GridComp%2Fpull%2F637&data=05%7C01%7C
richard.cullather%40nasa.gov%7C02f827fd50844984c6c108da943c692a%7C7005d
45845be48ae8140d43da96dd17b%7C0%7C0%7C637985284423337305%7CUnknown%7CTW
FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M
n0%3D%7C3000%7C%7C%7C&sdata=%2BGJ06hCy4vERNs7FswqKdy3XciJaP4v%2BOf6cqSt
HvkY%3D&reserved=0>, or
unsubscribe<https://gcc02.safelinks.protection.outlook.com/?url=https%3
A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPJB4W44K3NPNTZT
3GVJQATV5ZFDJANCNFSM6AAAAAAQJ6FYIU&data=05%7C01%7Crichard.cullather%40n
asa.gov%7C02f827fd50844984c6c108da943c692a%7C7005d45845be48ae8140d43da9
6dd17b%7C0%7C0%7C637985284423337305%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C
&sdata=Nn45M13%2FfPIMEDMrHn51lVUlmN%2BRepkNsEBppvTX8XE%3D&reserved=0>.
You are receiving this because you were assigned.Message ID:
***<EMAIL_ADDRESS>
—
Reply to this email directly, [1]view it on GitHub, or [2]unsubscribe.
You are receiving this because you were mentioned. Message ID:
<EMAIL_ADDRESS>
References

1. https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FGEOS-ESM%2FGEOSgcm_GridComp%2Fpull%2F637%23issuecomment-1243745052&data=05%7C01%7Crobert.a.lucchesi%40nasa.gov%7C9128f50f0aea48498b1908da94c2c417%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637985861487441620%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=lx493Zs63D5T%2F%2F4%2B4LHEAoN4K6KEQAnS0hMoGyZSWyY%3D&reserved=0
2. https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAORRJXCQIWVHOKCQMZJGGTTV54VZ7ANCNFSM6AAAAAAQJ6FYIU&data=05%7C01%7Crobert.a.lucchesi%40nasa.gov%7C9128f50f0aea48498b1908da94c2c417%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637985861487441620%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ikITusWtScP6xVjIPiNP2xao1ZkPDT4y5kXPPfKqOMw%3D&reserved=0

--

Rob Lucchesi SSAI         @.***
Global Modeling and Assimilation Office (GMAO)
Operational Software Group<PHONE_NUMBER>
Code 610.1
NASA-Goddard Space Flight Center
Greenbelt, MD 20771

My changes from /feature/lcandre2/r21c_landice_changes are now incorporated fully in this branch.

long_name changes to RUNOFF from SURFACE and LANDICE (and other children of SURFACE to maintain consistency).

Many thanks, @sdrabenh, for merging this PR.
I double-checked that everything that was in the branch was merged ok, so I'm going to delete my branch.  For any future changes that may be needed, we'll start with another clone of your most recent branch.
I'll also transfer the remaining to-do items into a new Github issue.
cc: @elakkraoui @lcandre2