Multiprocessing options

Shared Array(s)
Pros

Read function is trivial (1 copy from shared to local array, 1 copy/view when removing np.nans)
Arbitrarily large arrays

Cons

More complex implementation

Some amount of bookkeeping is required (e.g. array dimensions, yet-to-be-filled vals)

Less flexible data structures

No named data elements (why not, though?)
Only numpy arrays (though we can manage several arrays of different shapes)

Less straightforward for users to implement their own devices

Bookkeeping related to where data should land, ...

Pipes
Pros

Very straightforward implementation (~100 lines)
Straightforward to send any data structure (e.g. dict, list, array, ...)
Naturally handles variable amount of data per read period
No need to use locks when accessing data (in fact, leads to diminished performance)

Cons

Fairly small buffer size limits (~65536 bytes, and could vary by platform).

Exceeding this limit leads to blocking the remote process, while it waits for the pipe to free up some space (or just fails).
By default, Windows uses a smaller buffer size. We can encourage it to use a larger one (added in bf6ca24fac3067b6a125382d39b6d861d2c97200), but unsure if there will be any undesirable side-effects.
This could limit high-frequency devices (e.g. EEG)? At the least, the pipe should be emptied frequently in these cases (i.e. every framebuffer flip).

Read function takes non-trivial amount of time (expect worst-case 2-3 ms? Only tested on my laptop). It scales with number of elements in the buffer. Could we do magic to gradually shuffle data from the pipe to the main process via a thread when the number of elements exceeds some threshold?

Expanding this more...
I think each is useful in different situations. Shared memory would be great in high-frequency, larger-data situations (>= 1kHz and several observations per time point, e.g. EEG or the HAND), and pipes seem more amenable to slower/smaller data (as long as it fits in the pipe buffer), or heterogeneous data from multi-function devices (e.g. events from mice, like 'left mouse button click' vs. 'scroll wheel change').

Continuing the stream-of-consciousness, maybe the focus should be on the high-frequency, large-data situations.

In the case of sockets/pipes, the format of the data should also be considered. Right now, I send a single dictionary per read, which is automatically pickled/unpickled by each side of the Pipe. Alternatively, there's things like protobuf and lsl, which might be more flexible/accessible from other programs (though not sure how they deal with numpy arrays... it looks like lsl is fine with them).

Also, lsl handles the pipe/socket as far as I can tell (ref. https://github.com/sccn/labstreaminglayer/blob/master/LSL/liblsl-Python/examples/PerformanceTest.py)

Here's a brief example of LSL, hacked together from their examples:
import time
import multiprocessing as mp
from random import random as rand
import matplotlib.pyplot as plt
import numpy as np

from pylsl import StreamInfo, StreamOutlet, StreamInlet, resolve_stream, local_clock

def producer(flag, remote_ready):
    info = StreamInfo('BioSemi', 'EEG', 8, 100, 'float32', 'myuid34234')
    outlet = StreamOutlet(info)
    remote_ready.set()
    t1 = 0
    while not flag.is_set():
        mysample = [rand(), rand(), rand(), rand(), rand(), rand(), rand(), rand()]
        stamp = local_clock()
    # now send it and wait for a bit
        outlet.push_sample(mysample, stamp)
        while local_clock() < t1:
            pass
        t1 = local_clock() + 0.001

if __name__ == '__main__':
    # first resolve an EEG stream on the lab network
    flag = mp.Event()
    remote_ready = mp.Event()
    proc = mp.Process(target=producer, args=(flag, remote_ready))
    proc.daemon = True
    proc.start()
    remote_ready.wait()
    print("looking for an EEG stream...")
    streams = resolve_stream('type', 'EEG')

    # create a new inlet to read from the stream
    times = []
    inlet = StreamInlet(streams[0])
    t0 = time.time()
    t1 = t0 + 10
    while time.time() < t1:
        # get a new sample (you can also omit the timestamp part if you're not
        # interested in it)
        chunk, timestamps = inlet.pull_chunk()
        if timestamps:
            print(timestamps)
            times.extend(timestamps)

    flag.set()
    diffs = np.diff(times)
    plt.plot(diffs)
    plt.show()

I think I have an LSL version working at this point. Is it worthwhile to have a shared memory version for devices that are local, and somehow make the two setups compatible?

Coming full circle to shared memory (we can almost always connect the device to the experiment computer). Notes on implementation:
Devices:

Should be able to instantiate the device in the main process for testing
Must be able to infer the sampling frequency, data types, and data shapes from the kwargs

sampling frequency should be straightforward (usually fixed or has its own kwarg), but the other two are probably less so (largely fixed, but implementer should handle inferring the shape of the data and data type in the case that they are not fixed, (e.g. flock of birds))

__init__ method should just store args, and maybe do type/sanity checks
__enter__ method should be the point where communication begins
__exit__ method must leave the device in a desirable state
read method should return one time point in the format (<time>, <np.array matching data shape & type>, ...<additional pieces of data>)

One thing I didn't anticipate was devices sending batched data (e.g. the EMG band), where we get several pieces of data per read.  I think this can be handled in the multiprocessing part of the code (i.e. iterate through the returned data if it's a list, doing the proper bookkeeping for the ring buffer), but I won't sweat it for this first round.

Additionally, there should be static methods available to infer the sampling frequency, data types, and data shapes from whatever lands in kwargs. This allows us to correctly specify the size/type for shared arrays before the device is instantiated. Instantiating the device on the main process first, then removing it, can lead to unhappy situations (esp. related to the keyboard/mouse).

Multiprocessing wrapper:

__init__(self, device=<class, not instantiation>, **kwargs)

kwargs are passed to device __init__ once the remote process is started

Primarily occupied with keeping track of the various arrays.
Each piece of data from the device requires a shared array (for moving data remote -> local) and a local array of matching size (for manipulation/removal of nans), as does the timestamp (which is shared for all pieces of data at the same point in the array)

We end up copying data twice in this montage -- once when going remote -> local, and one going from local -> non-nan local. I think this will give the least surprising behavior from the user's viewpoint -- the first copy is absolutely necessary (so that changes to the shared array don't permeate to the user's experience), but the second copy might be overkill. I'm just afraid that creating a view/reference to the local data will create awkward situations once that local data is updated. Need to think on it some more...

Be sure to reset shared arrays in the __enter__() method.
_worker() method reads forever until kill flag is set by __exit__().
Make _worker() static (so we don't do dangerous things by moving the whole obj in)


[fix][ci] Regex syntax

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: N/A
cc @nicoloboschi @lhotari I tested on the regex101.com the last time, but miss the group number.
Here's a false case: https://github.com/apache/pulsar/actions/runs/3547655293 and should be fixed with this patch.

/pulsarbot run-failure-checks

Codecov Report

Merging #18634 (934bfa4) into master (355ba60) will decrease coverage by 9.45%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #18634      +/-   ##
============================================
- Coverage     46.54%   37.08%   -9.46%
+ Complexity    10312     1968    -8344
============================================
  Files           698      209     -489
  Lines         68079    14420   -53659
  Branches       7280     1573    -5707
============================================
- Hits          31688     5348   -26340
+ Misses        32788     8486   -24302
+ Partials       3603      586    -3017

Flag
Coverage Δ

unittests
37.08% <ø> (-9.46%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

.../org/apache/pulsar/client/impl/ConnectionPool.java
37.43% <0.00%> (-1.03%)
:arrow_down:

...apache/pulsar/broker/admin/v1/SchemasResource.java

...ava/org/apache/pulsar/broker/stats/WindowWrap.java

...ookkeeper/mledger/impl/ManagedCursorContainer.java

...g/apache/bookkeeper/mledger/impl/OpFindNewest.java

...e/pulsar/proxy/server/ProxyReadTimeoutHandler.java

...che/pulsar/broker/intercept/BrokerInterceptor.java

...apache/pulsar/broker/stats/ReplicationMetrics.java

...ache/pulsar/broker/service/SubscriptionOption.java

...r/service/schema/DefaultSchemaRegistryService.java

... and 480 more

Merging...


Add missing apt package in readthedocs config

Changes:

Add libfontconfig-dev in apt packages

Ok, libfontconfig-dev of Ubuntu 22.04 is 2.13.1-4.2ubuntu5. This seems to be causing the following undefined symbol error.
* ImportError: /home/docs/checkouts/readthedocs.org/user_builds/fontconfig-py/envs/latest/lib/python3.11/site-packages/fontconfig/fontconfig.cpython-311-x86_64-linux-gnu.so: undefined symbol: FcConfigGetFilename


Can't make DKIM work

First of all it seems impossible for me to do the installation steps.
Why are they even needed? - Why can't I just start the docker container as I can with most other images?
Anyways I created the DKIM key with another tool (tried both online and another docker image).
But the thing is that I keep getting the "no DKIM keys was found" - Why not write in the log what the files are called that you look for?
All I need is a simple SMTP server that supports DKIM.

E-mail is actually quite complex and it is not one-size-fits-all. Your configuration needs to be correct and needs to match your DNS records. If you truly need only the SMTP server then you can set the option SMTP_ONLY=1 to get just that. However, the beauty with docker-mailserver is that you get a full stack with smtp, imap, antispam/antivirus and much more that works with some configuration but much less work than if you were to set it up yourself.
If you don't want to use the setup script for creating the keys you can always check the script to see where it puts them. However, I would recommend spending a few hours reading about the available options, planning your configuration and trying it out before going live for real. That small investment can save you time and problems down the line.
If you feel you need something even simpler then perhaps this is not the project for you.

I am using the SMTP_ONLY=1 and it's not that I don't want to use the install scripts. I can't make them work. I get this error: "No Support Container Runtime Interface Detected."
But you might be right - if I can't make it work I need to find another project for my needs. I would just advice you to make it work much more out of the box in future

What platform are you on? The supported host platform is Linux. That doesn't mean you can't use other platforms, but the tests work only on Linux, so it is definitely the safest option.
The setup script tries to find docker or podman. Your error is displayed if it can't find either (shortened):
  if [ ! -z "$(command -v docker)" ]; then
    CRI=docker
  elif [ ! -z "$(command -v podman)" ]; then
    CRI=podman
  else
    echo "No Support Container Runtime Interface Detected."
    exit 1
  fi

In the top of the script CRI is defined as empty. If you know that you are using docker, for example, you can set it to docker and see if that helps. You can also run the tests (command -v docker) manually to see what they return.


Wrong place

https://github.com/Beluga-lang/McTT/blob/c33ec078d950caef349b48075db3abcadb5b5bee/theories/Core/Soundness/LogicalRelation/Lemmas.v#L1098-L1101
This should be placed in LogicalRelation.Definitions and be named more properly.

merged


Test issue for #dependency-management

Test issue only, please ignore

Test comment

All good. Nothing to see here ...


Add support for the uiSchema in react-jsonschema-form for plugins

Allows more customization of plugin configuration forms

FYI, I ran prettier on plugins.js and it made a bunch of changes...

With uiSchema in place some custom widgets would probably make sense for some config options. For example a custom widget for picking a SK path with autocomplete and/or validation of the value.

Re: prettier: I try to make formatting changes in a separate commit. Makes reviewing stuff  easier, when you can separate the functional changes from formatting ones. Not possible always.

Starting over...


updated-ui-and-changed-rem-or-em-to-px

updated-ui-and-changed-rem-or-em-to-px

@priyanka9634 fix below UI review comments

Blog Page:

[x] Featured post - add link to image, title etc.
[x] Add mouse-over effect on post cards - check with designer for this

Sample Post Page:

[x] Check vertical spacing between breadcrumb and content, seems too much.
[ ] Back to blog - Breadcrumb left position is not matching with  Website breadcrumb
[ ] width of blog post article content is not 1320, check if its matching with design given, and bring it to designers notice if its as per design.

Author Page:

[x] Content seems hanging to right - bring it to center position

[ ] toc-item vertical gap is too much - not matches with vertical gap of right sidebar toc links, check with designer for this.


Broadcast transactions

A new transaction needs to be sent to a few peers.
Transactions need to be re-broadcast by the sender after a while if no confirmations are received.

This ticket is meant to implement broadcast of transactions among peers, including reception of transactions.
Cc @uwiger @wagerlabs @sennui

This ticket is about sending transactions out, not about receiving them. Please see description!

https://www.pivotaltracker.com/story/show/152482324


Single character unquoted strings cause mismatched input error

Consider the following code excerpt:
B3AF46E021071CA6002211EE /* C */ = {
    isa = PBXGroup;
    children = (
    );
    name = C;
    sourceTree = "<group>";
};

Because the path is only a single character it causes the following error:
mismatched input 'C' expecting {QUOTED_STRING, NON_QUOTED_STRING}
The problem does not occur if the string is quoted.

I apologise for the delay here @dnicolson 🙏🏼 , I don't know how this went under the radar for so long. I'll find some time to address the issue in the upcoming days/weeks

Should be fixed in 2.1.2! 🎉


Allow lambdas to work with checked exceptions

Lambdas have checked exceptions, but there's no way to indicate that an lambda cannot throw as there is no Never type (or similar) to account for this. Related; union types are not currently implemented (#16) which is a key component of expressing the correct error type.

Adjusted this issue to focus on fixing checked exceptions with lambdas. Allowing static validation is definitely important as a for-later option, but only once the necessary type infrastructure is available.


Non-snapshot release to maven central

As we actually plan to start using bayes-scala in production we would like to see a fixed release.

ok, will do it by the end of the next week, as well as #27.
Version to be released: 0.5

Thanks!

The release of bayes-scala v0.5 has been just promoted on nexus, waiting now for the Sonatype team to activate the sync process.

Sync is working:
http://search.maven.org/#search|ga|1|bayes-scala


Ztest becomes unresponsive while running SMP tests

Issue: The tests in tests/kernel/smp when executed becomes unresponsive.
Sample log:
Running test suite smp
===================================================================
starting test - test_smp_coop_threads
PASS - test_smp_coop_threads
===================================================================
starting test - test_cpu_id_threads

Same set of tests when executed individually by commenting rest of the tests in testsuite like below:
 ztest_test_suite(smp,
/*           ztest_unit_test(test_smp_coop_threads),
*/
             ztest_unit_test(test_cpu_id_threads)
/*,
             ztest_unit_test(test_coop_resched_threads),
             ztest_unit_test(test_preempt_resched_threads),
             ztest_unit_test(test_yield_threads),
             ztest_unit_test(test_sleep_threads),
             ztest_unit_test(test_wakeup_threads),
             ztest_unit_test(test_wakeup_pending_threads)
*/
             );
    ztest_run_test_suite(smp);

the test case executes successfully.
Sample log:
Running test suite smp
===================================================================
starting test - test_cpu_id_threads
PASS - test_cpu_id_threads
===================================================================
===================================================================
PROJECT EXECUTION SUCCESSFUL

It is the same case for all the test cases in smp. Cleanup of threads created is handled in test case already.
 ztest_test_suite(smp,
/*           ztest_unit_test(test_smp_coop_threads),
             ztest_unit_test(test_cpu_id_threads),
*/
             ztest_unit_test(test_coop_resched_threads)

/*,
             ztest_unit_test(test_preempt_resched_threads),
             ztest_unit_test(test_yield_threads),
             ztest_unit_test(test_sleep_threads),
             ztest_unit_test(test_wakeup_threads),
             ztest_unit_test(test_wakeup_pending_threads)
*/
             );
    ztest_run_test_suite(smp);

Execution log:

Running test suite smp
===================================================================
starting test - test_coop_resched_threads
PASS - test_coop_resched_threads
===================================================================
===================================================================

PROJECT EXECUTION SUCCESSFUL

Steps to reproduce:
cd tests/kernel/smp
mkdir build && cd build
cmake -DBOARD=esp32 ..
make flash

@spoorthik : When compiled for which target?

@aescolar : Compiled for esp32.

@nashif Can we resolve this in future?

This is a can of worms that is a bit over my head at this point.  I think there are problems with races in either the xtensa code and/or the scheduler.

I've discovered that k_sleep() is broken on SMP, which affects this test. I'm not sure if my fix for that issue is correct, which leaves me wondering if continuing issues are created by my fix, or are actual symptoms. I have to punt this back to someone with more knowledge of the scheduler and xtensa arch.

FWIW, my k_sleep() fix was:
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -945,6 +945,16 @@ s32_t z_impl_k_sleep(s32_t duration)
        z_remove_thread_from_ready_q(_current);
        z_add_thread_timeout(_current, ticks);

+#if defined(CONFIG_SMP)
+       /*
+        * when running SMP, we must mark the thread queued
+        * to prevent the path through z_swap() from putting
+        * it right back in a ready queue, resulting in no sleep.
+        */
+
+       z_mark_thread_as_queued(_current);
+#endif
+
        (void)z_swap(&local_lock, key);

        ticks = expected_wakeup_time - z_tick_get_32();

This bug should not have been closed, as #14846 addressed some issues related to this bug, but not all.

@andyross , you mentioned that you can't reproduce this anymore after #18531. Do you think we can close this issue then?

Yes, this is working in all CI builds and has been for months. Closing.


Add improvements to existing code

@bjanderson70 I saw that most of the Interfaces classes have "virtual" keyword, is there any reason for that? As far as i can recall Intefaces are virtual by default, so using virtual it's optional right?

I try to be explicit even where the default scope/access level is known. Why? I cannot assume others will know or not; part of providing clarity. Bec/ you never know when your code is used-- so, I try to put lipstick on that pig 🙃
Sent from my phone
On Aug 3, 2017, at 11:38 AM, pvigil <notifications<EMAIL_ADDRESS>wrote:
@bjanderson70https://github.com/bjanderson70 I saw that most of the Interfaces classes have "virtual" keyword, is there any reason for that? As far as i can recall Intefaces are virtual by default, so using virtual it's optional right?

You can view, comment on, or merge this pull request online at:
https://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6
Commit Summary

Add improvements to existing code

File Changes

M ApexBaseMessageSender.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-0 (4)
M ApexBaseRuntimeEnvironmentTest.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-1 (2)
M ApexCache.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-2 (17)
M ApexCacheTest.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-3 (4)
M ApexExceptionHandler.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-4 (3)
M ApexExceptionPolicyStrategyTest.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-5 (2)
M ApexLabelManager.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-6 (4)
M ApexLogger.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-7 (14)
M ApexMailMessageSender.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-8 (4)
M ApexObjectFactory.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-9 (12)
M ApexPreviousTransactionResult.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-10 (2)
M ApexRunEnvironmentSingleton.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-11 (2)
M ApexTestJSONDataFallback.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-12 (6)
M ApexTestUtilities.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-13 (2)
M ApexUtilities.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-14 (49)
M AssertsTestUtility.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-15 (6)
M ConfigurationTestProvider.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-16 (14)
M CustomSettings.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-17 (35)
M ErrorLogClass.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-18 (2)
M HelperForSelectors.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-19 (10)
M HttpUtility.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-20 (7)
M ObjectJsonChunking.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-21 (10)
M TestEnvironmentSingleton.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-22 (6)
M TriggerHelperClass.clshttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6/files#diff-23 (20)

Patch Links:

https://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6.patch
https://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6.diff

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/bjanderson70/Apex-Cross-Cutting-Concerns/pull/6, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABxZcoFBINxDpKYE9AvXykInnWnLeJnVks5sUelNgaJpZM4Osnu0.

@bjanderson70 Fair enough :+1:


⚠ ClamAV has degraded performance

In 5bc2c47, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 97 ms

Resolved: ClamAV performance has improved in 935d3be.


[textedit] caret positioning and render problems

Screenshots and GIFs

I did not know how to describe these problems, next time i will use the format gif.

Fixed.
Before:

After:


Added Middle East / UAE North to Helper UI

PR Summary
Added Middle East / UAE North to the supported locations list.
Fixes #241
PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] This PR is ready to merge and is not Work in Progress
[x] Link to a filed issue

Looks good

The build checks have failed because of the spell checker failing.
https://github.com/Azure/AKS-Construction/runs/5767283233?check_suite_focus=true#step:3:35
We use https://marketplace.visualstudio.com/items?itemName=streetsidesoftware.code-spell-checker in VSCode and the GitHub Action Workflows to check for spelling. You'll need to add the term to the cspell dictionary either manually or via the extension UI in VSCODE, in order for the check to pass.


pdb_selseg not working

version 2
pdb_selseg does not performs on ANISOU lines, and all ANISOU lines will be output regardless of the seg selection.

Fixed.


Issues in placeholder and cursor tint color

Hello,
I am using this library and getting below issues in Android device.

I cannot change cursor tint color in textfield. I want to change it.
When I want to add prefix text in textfield on that field placeholder is overlapping.

Can you please help me to sort out this thing? Thanks

Hi @krishnmobilehub , can you provide minimal code reproduction for your second point?

You can use selectionColor="red"

<Item>
        <Input
          placeholder="Enter Name"
          placeholderTextColor="pink"
          selectionColor="red"
          value="XYZ"
        />
</Item>

with value="XYZ"

without value="XYZ"

Hi @krishnmobilehub , closing for now due to inactivity. Let us know if the issue still persists.

Hi @hanykumar,
neither of them works for me, in fact I get the following error:
Failed prop type: Invalid prop placeholderTextColorsupplied toForwardRef(TextInput)``
Can someone help me?
Thank you very much


Resolve Rails 7.1 logger incompatibility

Resolves https://github.com/zendesk/racecar/issues/356
There don't appear to be any tests which cover this but I've verified that it works locally.

Out of curiosity, why was this PR closed ? This fix looks good to me ( it's the same strategy as used on sidekiq )

The patch here should work, @zubin I m happy to merge this patch unless you found some issue with this change

The patch here should work, @zubin I m happy to merge this patch unless you found some issue with this change

No issues, it's been working fine. 👍

@deepredsky Could you release a new version please?

Oh I see there is 2.10.0.beta2, why not a non-beta version?

Oh I see there is 2.10.0.beta2, why not a non-beta version?

2.10.0 is released now


fix: update @testing-library/user-event

@testing-library/user-event@14 has been released.
13.5.0 is no longer maintained.

@iansu @mrmckeb What can I do to help this getting merged?

Any plans on merging this?


Make the documenting of the Rust toolchain selection a part of the release process

I don't think much needs to be done, but we should document a recommended version and how to install it with Rustup.
The Validator feature in Kagami required to use of the fresh toolchain, add rust-src and WASM target support:
rustup default nightly-2023-06-25
rustup component add rust-src --toolchain nightly-2023-06-25
rustup target add wasm32-unknown-unknown --toolchain nightly-2023-06-25

@appetrosyan, what is your opinion here?

we recommend the latest version


Order history events for invoicing

I want to merge this change because it adds order invoicing events in order event history.
Intended to be merged with: https://github.com/mirumee/saleor-dashboard/pull/610

Impact

[ ] New migrations
[X] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[X] The changes are tested
[X] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

@tomaszszymanski129 Something fails in CI, can you take a look?

@maarcingebala yep, migrations check, will update in a moment


Any reason why backup=0 is hardcoded?

Hi,
first of all, thanks for the great project! I really like the management of the pvcs directly in Proxmox. Currently, I am just wondering if there is any specific reason that backup is explicitly set to 0 in https://github.com/sergelogvinov/proxmox-csi-plugin/blob/76c899e4e1c8f2287854a4e08fbbdd8a1c7360a9/pkg/csi/controller.go#L352?
I am using a PBS to automatically backup my VMs and would enjoy including the pvcs as well. Or is there any technical limitation that I forgot here?
Thanks!
Jonas

My thoughts was:

There are many cloud-native solutions available to backup PVCs.
A PV does not belong to a VM, and backing up a VM should not affect the PV
During the recovery process, we might encounter unpredictable behavior. For example, if the PV exists and is attached to another VM, what will Proxmox do in this case? Or, if we have already deleted the PV resource in Kubernetes, we might end up with a block device that the CSI plugin cannot handle properly, as it does not register in Kubernetes automatically.

Could be this make an option? It can be userful for small setups using proxmox backup, especially when you just want to restore a single file using the file restore option. It's true that there are kube native solutions for making backups of PVCs, but some of them (like K10) rely on PVC snapshots, which are not implemented yet.

I appreciate curious individuals who enjoy experimenting.
Yep, we could add a CLI flag that disabled all checks, for example.

I think this possibly goes against original intention of this project and perhaps the Noflake Manifesto, but it would be convenient (at least in my case) to bind a volume to a VM by name. E.g. instead of creating the VM disk vm-9999-pvc-<UUID> you create the VM disk vm-100-pvc-<namespace>-<volumeName> bound to VM 100 and turn on backup. If a disk with the name exists you bind to it, and if not you create it.
I'm not sure if this is feasible though and I don't think it should be the default behaviour.
Looking at @sergelogvinov's terraform-talos proxmox example here, it might be possible to create a volume manually in Proxmox and bind to i using the pv spec.csi.volumeHandle attribute? This is all just speculation on my part though.

to switch off the BACKUP=0 param - use UNSAFEMOUNT="true" environment.
I do not want to documented it, i believe the better way to fix it is using VolumeAttributesClass resource (not implemented yet)


Issue with Open Management Portal in Tab

I am adding a bunch of instances to VS Code. Most of them allow me to Open Management Portal in Tab. Some of them do not. I did change the /csp/sys Web Apps as directed and it does not work. Any help would be appreciated.

@hbadian can you spot any factor that differentiates the servers you can open Portal in Simple Browser (aka tab) for versus the servers where you can't? For example $zversion string? Or whether the Portal URL is http or https?
And when Simple Browser fails to open the Portal page are you at least getting prompted for credentials but then re-prompted when you click Login?

They are all https. I did think I noticed a difference at first because 2 of the failing ones are: IRIS for UNIX (Red Hat Enterprise Linux 7 for x86-64) 2022.1.2 (Build 574U) Fri Jan 13 2023 14:57:52 EST [Health:3.5.0-1.m1].
All the successful ones are: HealthShare Unified Care Record 2022.2.2 Build: 1000 Adhoc: 22313 [HealthShare Modules: Health Insight:24.0 + Core:24.0 + Patient Index:24.0] - IRIS for UNIX (Red Hat Enterprise Linux 7 for x86-64) 2022.1 (Build 209_0_22313U) Fri Mar 17 2023 17:16:19 EDT [Health Insight:24.0|Core:24.0|Patient Index:24.0].
However 2 of the failures are also the same 2022.2.2 as above.

Also, I do get prompted for credentials and then reprompted when clicking Login

Troubleshooting problems getting Portal to run in Simple Browser is notoriously tricky.
I assume you've double-checked that the "Use Cookie for Session" setting is "Autodetect" for all five /csp/sys* web apps?
Maybe also try altering the "Prevent login CSRF attack" checkbox setting. If changing it makes no difference, put it back to the old state.
Are any of the web servers using self-signed certs? I think that's unlikely, since in my experience this situation yields completely blank pages (no login prompts, and a message [error] CodeWindow: failed to load (reason: ERR_CERT_AUTHORITY_INVALID, code: -202) in the Main channel of the Output tab of Panel).
Do you get the same result if you run the Simple Browser command from VS Code Command Palette and enter a portal URL, e.g. https://webserver/pathPrefix/csp/sys/UtilHome.csp ?

Yes, makes sense. Glad to hear this fixed it for you.


Provide cellxgene team with list of all DCP projects contained in cellxgene

Prepare a google sheet with all cellxgene datasets that also exist in the DCP.
We can do this manually in this ticket and then look for ways to make this easier with any automation.
As the project edits JSON has been recently updated, we can use this as a source of data for the spreadsheet.
Let's make columns

DCP title
DCP Project ID
Link to the cellxgene collection page.

https://cellxgene.cziscience.com/collections/b52eb423-5d0d-4645-b217-e1c6d38b2e72
https://cellxgene.cziscience.com/collections/a238e9fa-2bdf-41df-8522-69046f99baff
https://cellxgene.cziscience.com/collections/558385a4-b7b7-4eca-af0c-9e54d010e8dc
https://cellxgene.cziscience.com/collections/cdfb9ead-cb58-4a53-879d-5e4ed5329e73
https://cellxgene.cziscience.com/collections/7edef704-f63a-462c-8636-4bc86a9472bd
https://cellxgene.cziscience.com/collections/c9706a92-0e5f-46c1-96d8-20e42467f287
https://cellxgene.cziscience.com/collections/db468083-041c-41ca-8f6f-bf991a070adf
https://cellxgene.cziscience.com/d/fetal_maternal_interface_10x-22.cxg/
https://cellxgene.cziscience.com/collections/c114c20f-1ef4-49a5-9c2e-d965787fb90c
https://cellxgene.cziscience.com/collections/24d42e5e-ce6d-45ff-a66b-a3b3b715deaf
https://cellxgene.cziscience.com/collections/af893e86-8e9f-41f1-a474-ef05359b1fb7
https://cellxgene.cziscience.com/collections/48d354f5-a5ca-4f35-a3bb-fa3687502252
https://cellxgene.cziscience.com/collections/6e067060-f7e4-466c-86f3-ec3dd33c0381

Made a spreadsheet linked here! In case this has to be done again you can use this very basic script to get the links
import json
with open("spa/src/app/files/project-edits/project-edits.json", "r") as f:
    j = json.load(f)
output = []
for entry in j:
    if "analysisPortals" in entry:
        for i in entry["analysisPortals"]:
            if i["name"] == "CELLXGENE":
                output.append(f"{entry['entryId']},{i['url']}")
print("\n".join(output))
print(len(output))


Dilato: Core: Brackets website testing: The extension search result is incorrect on extension registry page

I searched by author, the result doesn't match. When I search by Sergey Chikuyonok,there is no result. When I search with Martin, it can be searched.
I searched by version and attachment size, there is no result.

Wrong repository.


fix 106 without breaking the API

This is the non-API-breaking approach we took in todays AF session to fix https://github.com/fsprojects/FsHttp/issues/106.

Thank you David! It's a great experience working together with you.


How to use Sector

Hi, can you provide an example of what kind of data I need to provide for the query when use SECTOR from apifunction enum?

@JosephMawer SECTOR is no longer supported by Alpha Vantage according to documentation:  https://www.alphavantage.co/documentation/


Server/users

CRUD-like functionality - implemented 4 gRPC functions:

CreateUser
GetUser
UpdateUser
DeleteUser

Added and configured Prometheus and Grafana to docker-compose-dev
Connected and integrated with ScyllaDB (Need a little bit more polishing, naive implementation for now, works though)
Still requires LoginUser and LogoutUser functions and proper token. Currently it only secures connection with TLS and naive bearer token middleware that check if its equal to 'some-secret-token' 😳

I am sorry for bad commit names, but I don't really care about it yet, I am going to care more when MVP is ready. Code requires a lil refactoring for names, I leaved comments in most places.


Test and update Themis 0.9.6 compatibility path

I've been meaning to do this for some time. Now that other parts of Secure Cell has been updated, I guess it's due.
Test for Themis 0.9.6 compatibility
One historical version of Themis has been using incorrect KDF which produced data that cannot be decrypted with the correct function. In order to work around this issue, the code contains a fallback path which tries the incorrect compatibility KDF if decryption fails with the derived key produced by the correct KDF. See #279 for the background on this story.
Unfortunately, this code path is not tested whatsoever and this is not good. Add tests that verify that Themis is able decrypt data produced by buggy Themis 0.9.6.
P.S. clang-format surely has some weirdly twisted idea about how byte arrays should be formatted *sigh* whatever...
Cleanup Context Imprint compatibility code path
Extract key derivation into functions like this is done for Seal and Token Protect mode. This makes the code more readable and highlights the compatibility issue that we are dealing with.
Update the usage sites too, remove magic macros, make sure that the derived keys are wiped after processing.
Cleanup Context Imprint IV computation
It's really not obvious why Context Imprint's IV computation is performed with a key derivation function. At least extract this bit into a separate function that can be commented.
Cleanup the usage sites, replace macros with plain C code, make sure that IV is wiped after processing since it is derived from the key.
Drop unused typedef themis_sym_message_hdr_t
It has never been used since Context Imprint mode does not produce any authentication token that needs a header.
👉 Remove SCELL_COMPAT define and ignore NO_SCELL_COMPAT variable
It does not really make much sense for the users to not enable the compatibility code path that allows to decrypt historical data. In fact, not a single build that we distribute disables this code path.
Remove all SCELL_COMPAT ifdefs and ignore NO_SCELL_COMPAT setting, making the compatibility always enabled.
This has a side effect of slightly slowing down decryption of really corrupted messages since we will be always trying the fallback path. However, this is not that significant loss as originally envisioned, and normal usage of Themis should not be affected.
Use compatibility path on 32-bit machines too
First of all, 64-bit machines are more common so this code path will be used in almost all cases. Second, 32-bit machines may need to deal with data encrypted by Themis 0.9.6 on 64-bit machines, so disabling it for 32-bit machines does not make much sense.
Checklist

[X] Change is covered by automated tests
[X] Benchmark results are attached (too lazy to benchmark failure path)
[X] The coding guidelines are followed
[X] Changelog is updated (maybe during the release)

removing old workarounds

Quite the opposite: we remove the way to remove the workaround, carving it in stone. Well, until the moment we decide that no one ever should have data encrypted by faulty 0.9.6 and earlier and remove ability to read it entirely.

we can get significant slow down when lib tries to decrypt data

This code is already enabled in virtually every 64-bit build that we distribute even without this PR. It does not slow down the happy path when valid data is decrypted. However, attempts to decrypt corrupted data are two times slower than necessary, and of course compatibility data takes twice as much time to decrypt successfully.

We used SCELL_COMPAT flag and x64 checks to be able to limit slow down on platforms where developers are sure that they didn’t used 0.9.6, thus don’t need compatibility mode.

It's a valid feature but I believe that probably no one is going to bother with disabling this mode since that involves a) realizing that you need to disable it since you decrypt a lot of corrupted data and an x2 boost will significantly improve your life, b) reading the source code to realize that you actually can disable it, since this flag is not documented anywhere else, c) recompiling Themis Core binaries because we do not ship builds with disabled compatibility path.
The most questionable thing is the use case. By leaving the compatibility code path we enable Themis to handle strictly more possible valid cases of decryption. By removing it we get a speedup in a questionable use case while making it impossible to decrypt some valid data. It's hard to image a case where you need to constantly deal with corrupted data and that x2 speedup will significantly improve your application.

Initially #279 PR introduced a temporary workaround to be able to decrypt messages encrypted by buggy version of Themis (0.9.7). This bug affected only narrow case when messages are encrypted on one architecture (let’s say x32) and decrypted on another one (let’s say x64).
It affected only users who used 0.9.6 and updated Themis to 0.9.7 and higher. It was planned to remove double decryption with development of new versions, not to make double decryption a standard behavior :D
I think that this PR makes double decryption a standard behavior in many cases when Themis can’t decrypt messages due to various reasons. As Themis does NOT distinguish if data is corrupted because it was encrypted by 0.9.6 or because any other reasons, it will attempt to double decrypt it anyway. That’s why I think that we are seeing performance degradation in all cases when Themis can’t decrypt data from first time, not only in case that this data was produced by 0.9.6.
(If you show me performance benchmarks that says that double decryption happens ONLY if data was produced by 0.9.6, and not because key is invalid, data is invalid, other reasons, I’ll change my mind.)
My belief is that we should NOT turn “temporary workaround” into a default behavior that will affect all Themis users from now to foreva.
I think we either should leave it AS IS until some new version, or DISABLE the workaround itself (because 0.9.6 was 3 years ago, chances are high that many users have already migrated to newer versions and don’t handle with corrupted data, but even if they do, current version still supports fix).

It was planned to remove double decryption with development of new versions, not to make double decryption a standard behavior :D

IMO, it depends on our stability guarantees. Bug-for-bug compatibility is totally a thing. I think that changing application code is relatively easier than hunting down all contaminated data, so we should be even more averse to removing data processing capabilities than removing deprecated API features.

My belief is that we should NOT turn “temporary workaround” into a default behavior that will affect all Themis users from now to foreva.

New users should not be generally affected since new versions use the new (correct) KDF during encryption and that's the one that we try first during decryption. It's a nice property of your workaround.
For them to be completely unaffected their need to not use data encrypted by 0.9.6 and eithe wait for us to remove the workaround, or make a custom build of Themis without it for themselves.

because 0.9.6 was 3 years ago, chances are high that many users have already migrated to newer versions and don’t handle with corrupted data

True, but there is no reliable way to tell other than try decrypting everything in the world with the workaround disabled.

but even if they do, current version still supports fix

If we remove the workaround, it won't support it. The release notes for 0.10 did note that you should upgrade, reencrypting the data was described as a last resort approach, not something that needs to be done after upgrading.

Given our commitment to a 3-year support cycle, and the fact that 0.9.6 will go EOL on 2020-12-13, it seems a reasonable to take the following apporach:

leave the NO_SCELL_COMPAT as is for the next release
issue an announcement that Themis will stop maintaining this workaround in 2021
emphasize that users should migrate their encrypted data while they still can, if they suspect they might be affected (that is, if they used Themis 0.9.6 or earlier)
schedule the removal of 0.9.6 compatibility in 2021

As for our own products, it seems that only the initial Acra 0.75 used old enough Themis, so we're kinda probably safe 🤞

Or rather than simply leaving the NO_SCELL_COMPAT, I'd enable it in this release, removing the compatibility code from general builds that we publish. So the compatibility will be gone, but if someone comes to us with reports that their are much enterprise and cannot migrate but still want the new version, we can at least provide them with instructions on how to build it with the compatibility feature. And then we can completely remove the code in 2021 (so in year, after a couple of releases without the compatibility shim).

Or rather than simply leaving the NO_SCELL_COMPAT, I'd enable it in this release, removing the compatibility code from general builds that we publish.
..
And then we can completely remove the code in 2021 (so in year, after a couple of releases without the compatibility shim).

Agree with this scenario, let do this way.

Okay... I've pushed commits that

bring back SCELL_COMPAT define
replace NO_SCELL_COMPAT variable with WITH_SCELL_COMPAT
make the compatibility code disabled by default, unless built WITH_SCELL_COMPAT
describe the circumstances in CHANGELOG, warn about removal
add Themis Core tests that verify builds with and without compatibilty


Update http4s-client, http4s-dsl, ... to 0.21.22

Updates

org.http4s:http4s-client
org.http4s:http4s-dsl
org.http4s:http4s-server

from 0.21.19 to 0.21.22.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.http4s" } ]

labels: library-update, semver-patch

Superseded by #31.


ddev drush uli should open a browser

Is your feature request related to a problem? Please describe.
Nope!
Describe the solution you'd like
When Drush is executed through a remote connection, the drush uli command does not trigger a browser open.
Have the drush.example check if the Drush command is uli. If it is, launch it using the same patterns as ddev launch.
Describe alternatives you've considered
Proof of concept as a contrib recipe: https://github.com/drud/ddev-contrib/pull/97
Additional context
Add any other context or screenshots about the feature request here.

drush.example is no longer the thing, in v1.16, drush is first-class, https://github.com/drud/ddev/blob/master/cmd/ddev/cmd/global_dotddev_assets/commands/web/drush
I'll bet all it takes is understanding what turns off the drush terminal behavior, because ddev's exec and custom commands are fully terminalized...

It checks if the host executing the command can launch a browser otherwise it just returns the URL. That's why I was thinking of a check which goes "oh, okay, this is a uli we know we can just pop the URL"

This is not the correct behavior for drush uli commands. It is supposed to print a URL, not automatically navigate to the URL. This is useful in the case of providing someone else with a one-time login link.

I don't think it's possible for a drush command's terminal output to cause browser behavior on the host, but a ddev uli custom/shell command, only on drupal projects could work.

FYI @mbomb007 This is default behaviour for drush uli.
https://drushcommands.com/drush-8x/user/user-login/
Reading the --browser parameter allows you to stipulate which browser to use. "(defaults to operating system default). Use --no-browser to suppress opening a browser."
Lando manages to keep the browser opening feature, not sure how though.

I imagine lando is running drush on the host? That would make it easy. But with drush running inside the container, where there's no default browser (or any browser at all) I'm not sure how this can be done.
It would be possible for ddev drush to detect the uli argument, capture the result, and re-run it on the host I guess.

If I get time I'll have a play with the idea of detecting the uli argument, capturing the result, and passing that result to ddev launch {drush_uli_result}

I've been an addict to terminals where I can just click a link and it opens (like iTerm2 for example) for a long time, so have never quite understood why it's so important to auto-open drush uli. When I do drush uli I just click the resultant link.

Could do something like and make some nice aliases for (DTAP)
ddev uli | xargs xdg-open &> /dev/null
ddev @acc uli | xargs xdg-open &> /dev/null

This sounds like good stuff. Interested in doing a PR? ddev drush is just a shell script. The problem here is that it currently executes inside the web container, not on the host. But you could make a uli custom command that would be a host command... I don't think it would be helpful to change the drush command to a host command.

I use ddev login when I want it to open in my main browser. Otherwise I use uli when I do it in a new private window:
Put this in ~/.ddev/commands/host/login and chmod +x it.
#!/bin/bash

## Description: Launch a browser and login to the current Drupal project.
## Usage: login [--name=USER]
## Example: "ddev login" or "ddev login --name=username" or "ddev login --uid=1"

FULLURL=$(ddev drush uli ${1} | tr -d '\r')

case $OSTYPE in
  linux-gnu)
    xdg-open "${FULLURL}"
    ;;
  "darwin"*)
    open "${FULLURL}"
    ;;
  "win*"* | "msys"*)
    start "${FULLURL}"
    ;;
esac

A DDEV add-on with this command would be a lovely thing.


Refreshed information on CI, fixed broken links in comprehensive tuto…

…rial

There was an error while validating job 60d8bda2-69d1-4efd-bc4a-55ec0fe93ef2 Message:
Result status: Failed
There was a problem accessing Github repository 'https://github.com/Microsoft/cordova-docs.git'.
Details:Microsoft.LightweightJobEngine.Core.Language.ContextCommandBase+ContextCommandException:
Result status: Failed
There was a problem accessing Github repository 'https://github.com/Microsoft/cordova-docs.git'.
---> System.AggregateException: One or more errors occurred. ---> System.ArgumentException: Error clonning repository ---> LibGit2Sharp.NotFoundException: Branch 357 not found. Available branches: origin/master
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.GetBranch(Repository repo, String name)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.<>c__DisplayClass30.<>c__DisplayClass34.b__29(KeyValuePair2 branch)    at System.Collections.Generic.List1.ForEach(Action1 action)    at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.<>c__DisplayClass30.<CloneRepository>b__28()    at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.<>c__DisplayClass1.<ExecuteAction>b__0()    at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.ExecuteAction[TResult](Func1 func)
at Microsoft.Practices.EnterpriseLibrary.TransientFaultHandling.RetryPolicy.ExecuteAction(Action action)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository(String url, IDictionary2 branches)    --- End of inner exception stack trace ---    at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository(String url, IDictionary2 branches)
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.CloneRepository()
at Microsoft.DPS.Services.LibGit2SharpSourceControlProvider.GetVersionAsync(String path)
at Microsoft.DPS.Commands.IdentifyDocumentsToPublish.CheckExternalServicesCommand.Do(IDictionary2 context)    --- End of inner exception stack trace ---    --- End of inner exception stack trace ---    at Microsoft.LightweightJobEngine.Core.Language.ContextCommandBase.ThrowIfErrorsLogged()    at Microsoft.DPS.Commands.IdentifyDocumentsToPublish.CheckExternalServicesCommand.Do(IDictionary2 context)
at Microsoft.LightweightJobEngine.Core.Language.JobWorkflow1.RunCommands(Guid jobId, IDictionary2 context, CancellationTokenSource cancelSignal)


feat: Improvement(optional)-Adding scores of the favourite dog breed on the selected traits

@shivajena Do you mean adding to the tooltip of the "Your Top 5 Dog Breeds" plot (top right)?

@stevenleung2018 not exactly. There could be a white output box, which takes input from the sliders and outputs the scores the breed for those specific traits

Thanks for the clarification.  Since there is already code for calculating the scores, I may not be able to contribute much to implement this feature.  Sorry.  Let's see who else can take this up.

Yes, lets park this for future consideration


Is there a way to remove sudo privileges from 'coder' user?

I learned about this project yesterday, it's amazing and exactly what I was looking for!
I plan to give access to my code-server to a freelancer that I haven't worked with in the past, so I'm wondering if there is a way to remove sudo privileges from 'coder' user?
All that person is going to do is edit the code and run a few commands in the terminal.

code-server doesn't need sudo privileges to run.
You can run code-server outside of the Docker container in a restricted user so they can still code!
Closing for now, but happy to elaborate!

@kylecarbs can you elaborate what you mean by running outside the container.
I need to run code-server using docker container, but want to disable the sudo privilege inside the docker or is there any way to customize removing sudo privilege for "coder"?

@chriseizus I think @harsh-m8 wants to remove the file /etc/sudoers.d/nopasswd. This file is responsible for the coder user to use any sudo commands without a password.

@chriseizus code-server can run inside or outside a container, with or without sudo privileges.

@kylecarbs oh sorry, I am always in Docker mode. My statement was for the Docker image.


Screenshots from artboard

Hi i know the first childs are artboards
but they  dont have the method image.saveAsPng   how can i save each artboard as  separated Screenshot?
thx for help

The only way I've been able to pull it off is to export the entire document as a PNG and crop out the artboards separately. I wrote a basic script that has worked well thus far. Below is a simplified version for reference... In this case I'm using ImageMagick to handle the cropping.
You'll possibly run out of memory when exporting. If that's the case, run the script with more  by setting the max_old_space_size option:
$ node --max_old_space_size=8000 yourfile.js`

'use strict';

const exec = require('child_process').exec;
const util = require('util');
const path = require('path');
const kebab = require('lodash/kebabCase');
const mkdir = require('mkdirp');
const psd = require('psd');

const CMD = 'convert %s -crop %sx%s+%s+%s %s';

/**
 * @module exportArtboards
 * @description Export Artboards as JPEG files directly from PhotoShop documents (without opening PhotoShop)
 * @requires Imagemagick (`brew install imagemagick`)
 *
 * @param {string} target - Path to PSD with artboards to be exported
 * @param {string} [out=cwd] - Output directory to save exported images, defaults to a time-stamp named dir in cwd
 * @return {Promise} - Resolves with path to exports, rejects on failure
 */
const exportArtboards = (target, out) => {
  if (!target) {
    throw new Error('Must pass a path to a PSD file as first parameter');
  }

  const dest = path.join(out || process.cwd(), Date.now().toString());
  const all = path.join(dest, 'layout.png');
  const obj = psd.fromFile(target);

  let promises = null;
  let boards = null;

  mkdir.sync(dest);
  obj.parse();

  return new Promise((resolve, reject) => {
    return obj.image.saveAsPng(all).then(() => {
      promises = obj.tree().children().map(artboard => {
        return new Promise((resolve, reject) => {
          const file = path.join(dest, `${kebab(artboard.name)}.jpg`);
          const b = artboard.layer.artboard().export().coords;
          const w = b.right - b.left;
          const h = b.bottom - b.top;
          const x = b.left;
          const y = b.top;

          exec(util.format(CMD, all, w, h, x, y, file), err => {
            if (err) return reject(err);
            resolve(file);
          });
        });
      });
      resolve(Promise.all(promises));
    });
  });
};

module.exports = exportArtboards;

// Usage example
exportArtboards('/some/test.psd', '/some-dir')
  .then(jpgs => console.log(jpgs.join('\n')))
  .catch(console.error.bind(console));

thx i will try this with https://github.com/oliver-moran/jimp


NcpBase: Add get/set handlers for PHY_TX_POWER

Codecov Report

Merging #1335 into master will increase coverage by 0.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1335      +/-   ##
==========================================
+ Coverage    69.4%   70.13%   +0.72%
==========================================
  Files         172      168       -4
  Lines       26807    25141    -1666
  Branches     3339     3161     -178
==========================================
- Hits        18606    17633     -973
+ Misses       6782     6170     -612
+ Partials     1419     1338      -81

Impacted Files
Coverage Δ

examples/platforms/posix/misc.c
0% <ø> (-66.67%)
:x:

src/ncp/spinel.c
52.76% <ø> (-24.85%)
:x:

src/core/thread/key_manager.hpp
80% <ø> (-20%)
:x:

src/core/mac/mac_whitelist.cpp
75.92% <ø> (-14.82%)
:x:

src/core/net/ip6.cpp
56.58% <ø> (-12.2%)
:x:

src/core/openthread.cpp
34.93% <ø> (-11.45%)
:x:

src/core/net/icmp6.cpp
84% <ø> (-4%)
:x:

examples/platforms/posix/uart-posix.c
59.55% <ø> (-3.38%)
:x:

src/core/net/netif.cpp
58.76% <ø> (-3.1%)
:x:

src/core/common/message.cpp
92.13% <ø> (-1.66%)
:x:

... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8275551...71bfd30. Read the comment docs.


This is awesome

Not really a bug, just wanted to say thanks for all your hard work. This is great.
Cheers

Thanks! 👍 Please take a small time to star the repo and follow the contributors! 🎉 Cheers!

really COOL !!! 👍
can't help to leave a comment here.

thefuck, shut up and take my money! Where is the donate button?

@pvanhoof nah, it's better without it 🙂


Fix pg_stat_statements tests

Description
The commit brings following changes:

Fix output of function pg_stat_statements_reset which now returns
timestamp instead of void.
Populate location field of TransactionStmt node in tsql grammar. It's only set
to correct value for savepoints, for all other nodes, it's set to -1.
See community commit: https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/commit/00e036de5f321ebd4ff3005443ade9fc19bb9c93

Task: BABEL-5391
Signed-off-by: Rishabh Tanwar<EMAIL_ADDRESS>Test Scenarios Covered

Use case based -

Boundary conditions -

Arbitrary inputs -

Negative test cases -

Minor version upgrade tests -

Major version upgrade tests -

Performance tests -

Tooling impact -

Client tests -

Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.03%) to 74.844%

Files with Coverage Reduction
New Missed Lines
%

contrib/babelfishpg_tds/src/backend/tds/tdscomm.c
2
76.03%

Totals

Change from base Build<PHONE_NUMBER>2:
0.03%

Covered Lines:
46491

Relevant Lines:
62117

💛  - Coveralls


UseStatusCodePagesWithReExecute,  Does not work  with Ajax

I want to catch the 401 error with Ajax but UseStatusCodePagesWithReExecute not firing.

@fatih108 can you provide more info about what you've tried? It would be very helpful if you can upload your app to a GitHub repo so we can look.


A bug caused by endswith when using modules_to_save.

System Info
I find in the line 326 in the file peft/src/peft/utils/other.py, where the modules_to_save modules should be set trainable and here a endswith is used to determine whether a modules has been listed in the modules to save. However, I find a very special case that if  there are two modules with the same end string but only one of them is listed in the modules_to_save. The endswith cannot correct distinct them. For example, in my code, there are two modules with name "model.layers.0.xxxx" and another with name "img_model.layers.0.xxxx", and it cause a bug that the latter was also mistakenly set to trainable.
I don't know why the endswith will be used here. But I think it is common to coincidentally have two modules with the same ending.
Who can help?
@BenjaminBossan
Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder
[X] My own task or dataset (give details below)

Reproduction
A model with two different modules with the same ending string. Only one of them is in the modules_to_save.
Expected behavior
Only the one in the modules_to_save should be set as trainable.

If you set modules_to_save=["model.layers.0.xxxx"], would that solve your problem?

@BenjaminBossan No, in fact I indeed set modules_to_save=["model.layers.0.xxxx"] when I meet this bug. However, because there is another modules named img_model.layers.0.xxxx. It could be also matched by the endswith.
I solve my problem by changing the latter name as model_img instead of img_model. However, I believe it is a subtle bug that may lead to unexpected behavior. At the very least, users should be warned of this.

Thanks for clarifying, I see now what the issue is. The problem is that we cannot easily change this, because we cannot know the intent of the user. Maybe they really want to match both model.layers.0.xxxx and img_model.layers.0.xxxx. If we change how this works, as existing code could break.
After some digging, I think it would be possible to allow passing strings to modules_to_save, which we could match with regex. That way, users could pass modules_to_save="^bar" in order to match bar but not foobar. This should be backwards compatible.
However, this would be a bigger refactor, which I currently don't have time to work on. I'll put in on the backlog though. For the time being, the solution you suggested is the only one that works.


[Doc] Fix typos in README and tutorials notebooks

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.06%. Comparing base (cf9ecd1) to head (6a2d73e).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

:exclamation:  There is a different number of reports uploaded between BASE (cf9ecd1) and HEAD (6a2d73e). Click for more details.
HEAD has 108 uploads less than BASE

Flag
BASE (cf9ecd1)
HEAD (6a2d73e)

111
3

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1012      +/-   ##
==========================================
- Coverage   70.14%   61.06%   -9.08%
==========================================
  Files          62       62
  Lines        4441     4441
==========================================
- Hits         3115     2712     -403
- Misses       1326     1729     +403

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


WIP Feature/elasticsearch 6

Failed collections:

[x] ReadOnly: Tests.Indices.MappingManagement.GetMapping.GetMappingNonExistentIndexApiTests
[x] ReadOnly: Tests.Search.FieldCapabilities.FieldCapabilitiesApiTests
[ ] ReadOnly: Tests.ClientConcepts.Troubleshooting.DeprecationLogging
[x] ReadOnly: Tests.Indices.StatusManagement.ClearCache.ClearCacheApiTests (see https://github.com/elastic/elasticsearch/issues/26947)
[x] ReadOnly: Tests.Aggregations.Metric.TopHits.TopHitsAggregationUsageTests
Was using fielddata_fields which is removed as per https://github.com/elastic/elasticsearch/pull/25566
[x] ReadOnly: Tests.Aggregations.Bucket.Filter.EmptyFilterAggregationUsageTests
Expected to fail as of 6.x see https://github.com/elastic/elasticsearch/pull/17542#issuecomment-300796197
[x] ReadOnly: Tests.Indices.IndexManagement.TypesExists.TypeExistsApiTests
[x] ReadOnly: Tests.Search.Request.HighlightingUsageTests
postings higlighter is gone https://github.com/elastic/elasticsearch/pull/25028
[x] ReadOnly: Tests.Search.MultiSearch.MultiSearchTemplate.MultiSearchTemplateApiTests
Can no longer reference file based templates https://github.com/elastic/elasticsearch/pull/25437
[x] ReadOnly: Tests.Cluster.ClusterState.ClusterStateApiTests
[x] ReadOnly: Tests.Search.Request.FielddataFieldsUsageTests
[x] IntrusiveOperation: Tests.Modules.Scripting.ScriptingCrudTests
[x] IntrusiveOperation: Tests.Document.Multiple.DeleteByQuery.DeleteByQueryApiTests

pending join data type support

[x] ManualReindex: Tests.Document.Multiple.Reindex.ReindexApiTests
[x] ReadOnly: Tests.Aggregations.ChildrenAggregationFluentAggsUsageTests
[x] ReadOnly: Tests.Document.Multiple.MultiGet.MultiGetParentApiTests

pending rc2 reverting back how inner hits _source is returned
https://github.com/elastic/elasticsearch/issues/26944#issuecomment-335770277

[ ] Writable: Tests.Reproduce.GithubIssue2788
[ ] ReadOnly: Tests.Aggregations.Bucket.Children.ChildrenAggregationUsageTests
[ ] IntrusiveOperation: Tests.Search.Request.QueryInnerHitsApiTests

pending rc2
https://github.com/elastic/elasticsearch/issues/27070

[ ] XPack: Tests.XPack.Watcher.DeleteWatch.DeleteNonExistentWatchApiTests

New Features
Not extensive, need a final pass over release notes and core github issues.

[ ] Forward port of the ML API's #2856
[x] Grok processor
[x] Nodes Usage API
[x] XPack deprecation info API
[x] Join data type mapping
[ ] Index sorting

Breaking changes

[ ] Go over https://www.elastic.co/guide/en/elasticsearch/reference/6.x/breaking-changes-6.0.html and list each PR here.

3 Additional APIs are in here: https://github.com/elastic/elasticsearch-net/pull/2894


Sudokumb application.

Hi Jeff, it's a long change list. I looked up to KmsDataProtectionProvider so far. Will look at the rest next week.

Thank you Simon and Jonathan.  The code and READMEs look much better already, thanks to your comments.  I have addressed all comments to date.


Remove plot testing  from codecov

Proposed changes
I removed plot.py from codecov coverage computation and I fixed some bugs in the same module.
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[x] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works

Codecov Report

Merging #42 (37e56ea) into main (3bf08bc) will increase coverage by 13.12%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #42       +/-   ##
===========================================
+ Coverage   55.43%   68.55%   +13.12%
===========================================
  Files          12       11        -1
  Lines        1454     1180      -274
===========================================
+ Hits          806      809        +3
+ Misses        648      371      -277

Impacted Files
Coverage Δ

dadapy/clustering.py
76.62% <0.00%> (-0.28%)
:arrow_down:

dadapy/plot.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bf08bc...37e56ea. Read the comment docs.


MongoDB additional environment variables

Hello,
I would like to set additional environment variables, because we need that for Backup purposes.
I cannot find any way to consume new environment variables, not even with a config map, because these just get consumed as a volume.
Am I missing anything?
Cheers,
Manuel

https://github.com/helm/charts/blob/master/stable/mongodb/templates/deployment-standalone.yaml#L90

@oktacon95 do you solve this question? I have the same issue..

This pr will solve this issue (https://github.com/helm/charts/pull/19434).


Add tenancy filter

Resolves #1508
Adds support for tenancy filter per docs Page 378:
tenancy
The tenancy of an instance.
Type: String
Valid values: dedicated | default | host

Thanks for the pull request. Looks good to me.  Could you sign our contributor license agreement referenced from the bottom of the project's readme, direct link https://docs.google.com/forms/d/19LpBBjykHPox18vrZvBbZUcK6gQTj7qv1O5hCduAZFU/viewform
Note that you don't need this branch to do custodian's normal client side filtering on tenancy. i.e. using the default value filter.
- Placement.Tenancy: dedicated

is sufficient to query out on tenancy (other options available in the long form of value filter).


New issue template and triage labelling needs to be added to/for the repo

Like the other repo

done in https://github.com/elastic/elastic-otel-java/pull/291


As a CIF user, I want to upload a document to a project, so that I can easily see all relevant files related to a project

Description
As a project coordinator, I want to upload a document to a project, so that I can easily see all relevant files related to a project.
Acceptance Criteria:
Given I am a CIF user
When I create or edit a project
Then I can upload multiple documents as attachments
~Given I am a CIF user~
~When I upload a document~
~Then I can set metadata properties: Title, description, project phase, received_at~
Given I am a CIF user
When I upload a document
Then my user and date/time of upload are recorded
Development Checklist:

[x] Include file name
[x] Wireframe completed and linked to ticket
[x] Meets DOD

Personas:

Program Development Team
Operations Team
Tech Team

Notes:

Title and Description: Can we extract appendices description from RFP form?

Adding applicable Personas to the ticket
Program Development Team - CIF Persona
Operations Team - Persona
Tech Team - CIF Persona

(extract type from .eml?)
I think the eml parsing should be a separate card

See ticket 72 for the wireframe associated with attachments.

Workflow for a single attachment:
Attachment List with 'Add New Attachment' button

Upload view:

Detail of a Single Attachment:

Hey team! Please add your planning poker estimate with ZenHub @AlexZorkin @dleard @pbastia

@LindsayMacfarlane  @matthieu-foucault reducing the scope of this card, we'll limit the current document work to just a file (no metadata)

Thank you @pbastia ! Closing this ticket and will test with #483, which will implement on dev.


Fix Amino JSON representation

Resolves #1829

[x] Add proto encoding annotations to fix Amino JSON representation
[x] Upgrade cosmos-sdk version to v0.50.5
[ ] TODO: update x/tx dependecy as soon as patch release is available

Very nice!


Event for when edit cell opened

Is there a way to determine or catch the event for when a cell edit box or dropdown is opened?  I see before and after save events, but these both appear to fire when you are leaving the input rather than when you are entering it.
This is important for me because I do not want to Ajax refresh the data while someone is editing a box and have them lose their current edits.
Thanks!

Thanks!  I will test next week.

RELEASE NOTE
Please upgrade related packages. thanks


Propose for 0.4.1 improvements

Quoting changelog.md

0.4.1

Handle the lifecycle using AppLifecycleListener instead SystemChannels.lifecycle.setMessageHandler
Changed trackEvent to not future
Avoiding calling unawaited every time you want to track a new event.
The lint rule: https://dart.dev/tools/linter-rules/unawaited_futures
Fix the error message when appKey is invalid
Update example with latest flutter version and an "app opened" event
Fix web info

1. Lifecycle issue
The PR #8 is working as should
but now I need to listen the flutter's lifecycle in my app (not in aptabase's package) and since the package already is doing that and as documented on SystemChannels.lifecycle:

/// The given callback will replace the currently registered callback for this
/// channel, if any. To remove the handler, pass null as the handler
/// argument.

we would lose the feature "send events when app goes to background".
And I've found out the SystemChannels.lifecycle has other unwanted side effects in general.
2. Changed trackEvent to not future
I use the unawaited_futures lint rule so I should add the unawaited every time I want to track and already create a caller just to wrap it. Thinking in other users and in this lint, changed it to not future anymore.
The problem here is if the dev already implemented either await or unawaited when calling the trackEvents, it'd  be an error (as it is not future anymore) and will break (so shouldn't be only minor bump 0.4.1). I prefer to avoid that.
One solution would be implement another caller as not future and (maybe) add a deprecated in future caller.
I really want to hear you about that before.
3. Fix web info
In web is flagging OS as unknown.
In package DeviceInfoPlugin has the implementation for web platform, check out in pub.dev example
Already change to use the webBrowserInfo

The issue here is the version part as the web provides not a clear single option to use.
In documentation has these info:
 Map<String, dynamic> _readWebBrowserInfo(WebBrowserInfo data) {
    return <String, dynamic>{
      'browserName': data.browserName.name,
      'appCodeName': data.appCodeName,
      'appName': data.appName,
      'appVersion': data.appVersion,
      'deviceMemory': data.deviceMemory,
      'language': data.language,
      'languages': data.languages,
      'platform': data.platform,
      'product': data.product,
      'productSub': data.productSub,
      'userAgent': data.userAgent,
      'vendor': data.vendor,
      'vendorSub': data.vendorSub,
      'hardwareConcurrency': data.hardwareConcurrency,
      'maxTouchPoints': data.maxTouchPoints,
    };
  }

Here is my debug value:

We could use the appVersion but still not so clear and simple.
And yet we should limit it to 100 max chars as server defined.
39: osInfo.version.substring(0, 100),
Again I want to know what your opinion before move on.

Sorry for long message but want to discuss before open the PR itself and also if you want to, I can break the PRs in 1,2,3 parts if you'd prefer.

Already tested on iOS, Mac, Web and Android.

The big issue about the approach before is that you set the message handler to your method for the whole app. The rest of the app will not be able to receive app lifecycle events.

Indeed. I realized one day after merged 😔
You could said it before 😅🥲
What else can you comment?

Indeed. I realized one day after merged 😔
Thats unfortunate 😞

You could said it before 😅🥲
I just realized it when we had this bug in one of our apps. I was thinking "Why can't I receive lifecycle events" until we bruteforce-removed every plugin until we knew it was aptabase 😆
Just saw it in the code.

What else can you comment?
What do you mean? Feedback for the rest of the code? 😄

@GabrielRozendo I think this issue is mentioned in this PR: https://github.com/aptabase/aptabase_flutter/issues/15, could you open a separate PR for the fix please?
Thanks a lot, appreciate your contributions!

Yes, I'll break it into small PRs.


[BUGFIX/GRAPHQL/URGENT] dataSources needs to be instantiated each apollo request

the createDatasources is executed once in the server config, the getDatasources needs to be provider scope instance per request. It needs to be inside the factory call or else the internal caching mechanism of RestDataSource will not be properly flushed and cause a memory leak.

I'll fix coverage for you :)

:tada: This PR is included in version 5.44.17 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

fantastic, thank you!


Older packages show outdated revision for latest recipe

For example the latest revision for open62541/1.3.4 according to the website:
5985346a15abb4a0ddcc6af7de20509b
Actual conan search:
Revisions for 'open62541/1.3.4' at remote 'conan-center':
bf33cae2a791730652a100527b9b26cc (2023-09-12 08:21:14 UTC)
5985346a15abb4a0ddcc6af7de20509b (2023-01-25 10:14:18 UTC)
Same for /1.3.8
b7410a15272dd9ed4df377b49ce946be
Revisions for 'open62541/1.3.8' at remote 'conan-center':
fe187f713a2a0d5c95906129bf7d5d78 (2024-01-07 11:46:11 UTC)
b7410a15272dd9ed4df377b49ce946be (2023-11-16 10:02:06 UTC)

we have already fixed it. thanks for your feedback!


Security in the tests (to fix)

We have to check if our Security works - positive and negative cases.
You can create JWT token with JWTUtil.generateToken() and add it as header to the request.
Also you can use @WithMockUser from SpringTest.
Admin shouldn't create users, so you have to delete this functionality from application and tests.

@OlgaKulikova nice. I want to ask you describe a little bit more, add details. It is perfect task description for embedded team, working in office full-time. But for distributed remote team, based on juniors it requires more details. Add pls what test should be edited (you can add link for github file), and for each case steps. Thanks )

Ок.

Delete creating of users from AdminController-UserService-UserRepository - Link to Controller
Delete creating of users from tests - SecureIntegrationTest, UserRepositoryImplMongoTest, UserServiceTest

Instead deleted fragments use @WithMockUser from SpringTest.

For checking of security extend SecureIntegrationTest


Switch to the standard CMake module GNUInstallDirs

Benefits:

Relative install() paths by default. Simplify integration with CPack.
The default paths correspond the GNU and FHS layouts: lib or lib64 or lib/<arch> (debian).
Linux distributions do not need to override INSTALL_LIB_DIR (like this: https://src.fedoraproject.org/rpms/zlib-ng/blob/f38/f/zlib-ng.spec#_33). The current CMake build system hardcodes lib.

Proposal:
Remove legacy and unneeded variables:

LIB_INSTALL_DIR, INSTALL_LIB_DIR
INC_INSTALL_DIR, INSTALL_INC_DIR

Have not tested this yet, but it looks like a good approach.

A previous discussion related GNUInstallDirs can be found here at PR #881.

I'd like to keep the support for the variables you propose to remove. Some of those are used by distro macros, and LIB_INSTALL_DIR was actually added to support the fedora rpm %cmake macro after we noticed their use of the workaround. As far as I can see, those are still supported with this PR.
This PR looks like good cleanups, and improvements to things like relative paths, .pc  support and default libdir selection.
But I notice that you have removed the CACHE PATH parameter (and their descriptions) for the "legacy variables", is there any actual reasoning for that? I could understand removing the FORCE parameter, if that was the intention here.

@Dead2

I'd like to keep the support for the variables you propose to remove. Some of those are used by distro macros, and LIB_INSTALL_DIR was actually added to support the fedora rpm %cmake macro after we noticed their use of the workaround. As far as I can see, those are still supported with this PR.

In the current version of PR, these variables are fully supported.

But I notice that you have removed the CACHE PATH parameter (and their descriptions) for the "legacy variables"

CACHE PATH and description can be set only if we set the value of deprecated variables. But now all deprecated variables are used as input only.
If these variables are not set by the user, they are not used or set anywhere in cmake.

@Dead2
Done.


MSID: 89493 Version: 3 DOI: 2<IP_ADDRESS>6936

[PLACE MANUSCRIPT AND EDITOR DETAILS HERE WHEN AVAILABLE] See step 3
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=89493)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/89493/v3)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews and QC
Who can help: Production team

[ ] QC passed or QC not needed

Who can help: Editorial team

[ ] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>6936)
[ ] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/89493/v3/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/89493)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/89493

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/89493

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/89493/v3/89493-v3.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/89493)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

@KJT08 can you confirm - should this be version 2 instead of 3? If so, please could you raise a separate ticket (so that the links populated in the description are all correct)?

@fred-atherden I think it probably should be version 2, looking at ejp the R1 was an appeal.

Great - thanks. Please raise another ticket and I'll close this ticket/remove from the board.


HTML PUT and GET

Hi there,
I am new to the whole thing :) read n00b 101 hehe
Currently I am requesting sending a requests.get() to a html page. If I now print(r.text) the output shows the whole page.
The page has query section in which the request range can be set:

Is there a way for me to send the range required?

Then the data gets displayed:

Is there a way for me to only return this data?

At the moment, I can see the data in the text that is returned:

        <input type="checkbox" class="noborder"
               name="paths:list" id="cb_1566205447"
               value="1566205447"
               title="Select Channel 8"
               alt="Select Channel 8" />

        May 31, 2015 11:30 am
        2.28839

And here is the code returned for the range request:

  :

<select name="end_query_minute"
     id="date_select_form_end_query_None_minute"
     size="1"
     onchange="update_date_field('date_select_form_end_query_None','date_select_form_end_query_None_year','date_select_form_end_query_None_month','date_select_form_end_query_None_day','date_select_form_end_query_None_hour','date_select_form_end_query_None_minute','date_select_form_end_query_None_ampm')">

  <option value="00">--</option>
  <option value="00">00</option>
  <option value="05">05</option>
  <option value="10">10</option>
  <option value="15">15</option>
  <option value="20">20</option>
  <option value="25">25</option>
  <option value="30">30</option>
  <option value="35 selected="selected"">35</option>
  <option value="40">40</option>
  <option value="45">45</option>
  <option value="50">50</option>
  <option value="55">55</option>

</select>

I am guessing that I can set the range using some code that will set the "end_query_minute" (and all other request range variables) and then query the page right after that to return the appropriate range of data. I can then extract the data using another method from the text returned... but I cannot find any relevant documentation on hoe Requests handles data/returns data/etc...
Any help would be highly appreciated.
A big thanks for this development, it has thus far made my life much easier :)
Regards,

So, requests doesn't know anything about HTML. This means there's no programmatic code you can use to simply interact with that page by searching through the HTML.
However, you can form the same requests that your browser would do. If you hit F12 in your browser it should bring up a developer console that you can use to see all the HTTP requests your browser makes. If you then fill out the forms and submit them, you can see the way the data is structured and replicate that in requests.
If you want to follow this up, though, I recommend you ask a question on StackOverflow. That is a community focused on providing answers to questions like this one, while this bug tracker is mostly to track actual bugs in requests.

Kief,
Sorry for the post :) Thanks for the advice

Hi Lukasa,
Even though this isn't the place, I decided to post the answer to my question, in case someone else comes a looking:
payload = {'start_query': '2015-05-30 10:30:00 GMT+2', 'end_query': '2015-05-30 15:30:00 GMT+2'}
r = s.get(url, params=payload)
Regards,

@RubenvWyk Thanks for the follow-up! :cake:


Compile issues windows node 0.12.2/0.12.0

except for engine.io, all of socket.io is failing compile on win 8.1. (engine.io-client, socket.io-client, socket.io)
the fix was to reference all the correct modules in package.json. I tested in forks.

2 months and still nothing from maintainers....

This is already addressed in master. Working on a release!


Additional website commands

It might be a nice QoL feature to have quick links for:

https://www.warwicktabletop.co.uk/timetable/
https://www.warwicktabletop.co.uk/events/
https://www.warwicktabletop.co.uk/page/codeofconduct/
https://www.warwicktabletop.co.uk/exec/
https://www.warwicktabletop.co.uk/votes/ (for during elections)

Bonus points for it automagically pulling a sitemap on startup from the website to generate these commands, instead of hard-coding them into the bot (this would need a PR to the website too, though)


Add complete code examples in the docs

This seems to be the best markdown editor on the internet. At least that's what I thought when I checked the live demo and learned that it also supports custom functionality.
I think it would be quite nice to have complete code examples available. For instance, many people including me may be just interested in the code corresponding to the example shown in the live demo as the starting point (e.g., for popular frameworks such as React and Next). I have been trying to reconstruct it but even that isn't so trivial (e.g., can't instantly render markdown while maintaining cursor position...).
Thanks for this great effort.

Thanks, a lot of the credit goes to the underlying Lexical platform.
Writing more docs is an ongoing effort (in fact, I'm working on something that will let me write docs for the editor in the editor). I'm very happy to accept contributions in that regard.
To help with the live demo, I've opened the repository of the site itself - take a look here.

@EssamWisam the scope of that issue is large and generic. I'm closing it - happy to accept contributions on the matter.


Updated falcon-linux-install.sh

I have updated the falcon-linux-install.sh script with a "FALCON_DOWNLOAD_ONLY" option. Just like the other options, set it as an environment variable to 'true' and run the script. It will download the falcon sensor only, regardless of whether the sensor is already installed or not.

@David-M-Berry thanks for opening up this PR. I was literally going to create this same functionality today. If you don't mind, let's focus on the following:

rebasing your changes on top of the latest updates
only add the new functionality (ie, the stuff that makes the sensor download only work)

remove all other changes as those would be a different PR

I'd like to get this done by today if possible in order to drop a new release for recent updates. I'll go ahead and make the above changes and then we can start testing from there.

Sounds good @carlosmmatos. Let me know if you want any help in the testing (I've tested on Ubuntu and Redhat 9.3).


Thunar works

Thunar file manager using Xming works to access files, although icon thumbnails are not shown.
It can associate and open file extensions with installed Linux applications, but not Windows ones.

Please file a PR and add to the chart, thanks!

Thunar is used under XFCE4, which is part of the XFCE4 Desktop, which is listed as working


contrib: Exit early if no git remote is found

Previously, if no git remote pointing to git@github.com:cilium/cilium.git or https://github.com/cilium/cilium was found, the check-stable and cherry-pick scripts continued to execute nevertheless which lead to cryptic errors.
This commit makes both scripts to exit early and also to print an error to stderr that the git remote could not have been found.
Also, factor out the common code into the get_remote function which can be shared by sourcing common.sh.

This change is

Coverage increased (+0.002%) to 41.864% when pulling d524694af85916bfba414aec4d470e8556e441f4 on pr/brb/warn-no-remote-with-git-suffix-found into 3d471a5d41a7eea689eea6002e36232ac46658b5 on master.


Wrong type inference with record on expression evaluation

Repro:
void main() {
  foo();
}

void foo() {
  bar({
    for (var i = 0; i < 10; i++) (i,),
  });
}

void bar(Set<(int,)> things) {
  baz(things);
}

int baz(Set<(int,)> things) => things.fold(0, (a, b) => a + b.$1);

Add a breakpoint inside bar.
Now add baz(things) to watch or run this on the debug console and see:
evaluateInFrame: (113) Expression compilation error
org-dartlang-debug:synthetic_debug_expression:1:5: Error: The argument type '_Set<dynamic>' can't be assigned to the parameter type 'Set<(int)>'.
 - '_Set' is from 'dart:_compact_hash'.
 - 'Set' is from 'dart:core'.
baz(things)
    ^

If you change the expression to baz(things.cast()) it works.
I did some experimenting and if you remove the Record from this and use only int the expression is evaluated correctly.
Could this be related to the problems we talked about in this issue that surround Records not having an element?

CC: @DanTup, @bwilkerson

Also, could this be related to https://github.com/dart-lang/sdk/issues/56555 in any way?

//cc @jensjoha @johnniwinther

Could this be related to the problems we talked about in this issue that surround Records not having an element?

No. The referenced issue is strictly limited to the analyzer. The compilation error you're seeing is from the VM.

@jensjoha Can you take a look at this? My guess that this is caused by the VM passing the runtime type _Set<dynamic> instead of the static type Set<(int,)>.

The VM currently sends [dart:_compact_hash, _Set, 1, 1, null] --- seemingly from 9a023aeae9ec (even with a comment "_Record class is not useful for the CFE.").
I have a cl currently running testing on the try bots making the VM-side and the dart-side to pass the information along (https://dart-review.googlesource.com/c/sdk/+/388841).


How to access vertices?

Hello,
I'm a newbie to Virocore, and have been stuck with figuring out how to access the vertices of mesh data. I've looked into Object 3D, but could not find any reference / function to get mesh data.
I would like to estimate the volume of the mesh with the following algorithm.
https://stackoverflow.com/questions/1406029/how-to-calculate-the-volume-of-a-3d-mesh-object-the-surface-of-which-is-made-up-t
Thank you for your help in advance !

Hi @koopoo87, we actually don't have an API at the moment to extract the raw vertex data from a loaded 3D model. I've added this issue to our backlog so we can investigate adding this to our next release. Thanks!

Accessing vertices from mesh data should be supported in the latest version of ViroCore, as such resolving.


FIX: enable http_proxy environment variable

This PR enables support for http_proxy environment variable as described in the function description https://pkg.go.dev/net/http#ProxyFromEnvironment
Test without proxy environment variable:
 ./bin/kubeconform fixtures fixtures/crd_schema.yaml - CustomResourceDefinition trainingjobs.sagemaker.aws.amazon.com failed validation: failed downloading schema at https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/master-standalone/customresourcedefinition-apiextensions-v1beta1.json: Get "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/master-standalone/customresourcedefinition-apiextensions-v1beta1.json": dial tcp <IP_ADDRESS>:443: connect: connection refused
Test with proxy environment set:
https_proxy=proxy.local:8080 ./bin/kubeconform fixtures fixtures/crd_schema.yaml - CustomResourceDefinition trainingjobs.sagemaker.aws.amazon.com failed validation: could not find schema for CustomResourceDefinition fixtures/duplicates-skipped-kinds.yaml - SkipThisKind identical failed validation: could not find schema for SkipThisKind fixtures/duplicates-skipped-kinds.yaml - SkipThisKind identical failed validation: could not find schema for SkipThisKind

Nice! I was under the impression setting the proxy would be automatic if I set HTTPS_PROXY but indeed  that doesn't seem to be the case.. I ll give this a gofmt and add a test (should fail if HTTP_PROXY  is set to some non existing proxy) later today. Thanks!

Thank you! Looking forward to your official release then 😊

most probably this week  🙇

Still learning Github, realised I can push straight to your branch :) I added an acceptance test and updated the readme, and ran gofmt. This should be good! Thanks a lot!

Thank You!

Can you please add support for the NO_PROXY_ENV? Corporate environment oftentimes route all HTTP(S) traffic through a proxy which itself has to be excluded from this proxying.