feat: o2-67 support comments syntax

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: resolve #67
What is the new behavior?
AS-IS
%%This is a comment%%
TO-BE
<!--This is a comment-->
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.11 :tada:

Comparison is base (f64151a) 96.92% compared to head (cb26aa5) 97.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   96.92%   97.03%   +0.11%
==========================================
  Files           9       10       +1
  Lines         130      135       +5
  Branches       14       14
==========================================
+ Hits          126      131       +5
  Misses          4        4

Impacted Files
Coverage Δ

src/ObsidianRegex.ts
100.00% <ø> (ø)

src/jekyll/CommentsConverter.ts
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Kinematic Physics + Draggable Physics extension = crash game

Describe the bug of the extension
Draggable Physics Extension
If you try to drag a kinematic object the game will stop completely
Please double check that the bug is not already reported in the issues list.
To Reproduce
Steps to reproduce the behavior:

Create a Sprite
Add physics 2.0 behaviour set it to kinematic
Install Draggable Physics extension
Add it to the same sprite
Launch preview then try to drag the object

Please include a link to a game if possible!
bug-samples.zip

If applicable, add screenshots to help explain your problem.

Other details

Desktop Windows 10
GDevelop version 4.0.99-0-release

@planktonfun thanks for reporting this!
I made a quick fix to force objects with kinematic mode to be dynamic. Kinematic objects are never meant to be moved by forces and joints like this extension uses.
BTW, I also tested with static objects and it doesn't crash the game.  I decided not to force static to be dynamic in case the game design wants to change things from static to dynamic in the game.
https://github.com/GDevelopApp/GDevelop-extensions/pull/497

I saw you closed this, which reminded me to merge the fix.  :)
It should be live now.

thanks!


feat(avm): constrain start and end side effects counter to line up

Overview
In the current implementation every public vm circuit starts with a side effect counter of 0 that is incremented each time a side effect is created.
For nested calls, we require that the $sideEffectCounter$ at the start of the vm proof is equal to the $startSideEffectCounter$ in the public inputs, similarly, we require that the last value of $sideEffectCounter$ lines up with the $endSideEffectCounter$.

Partly done in #7007.


Issue on page /notebooks/HASP/DataDiagnostic/DataDiagnostics.html

Anna Payne has produced a new version of the HASP Data Diagnostics notebook.  It needs to replace the current version.
The new notebook lives here:
https://github.com/spacetelescope/hst_notebooks/blob/main/notebooks/HASP/DataDiagnostic/DataDiagnostics.ipynb

Hi @wvdixon,
I see the latest version displayed on GitHub Pages seems to include Anna's updates (https://spacetelescope.github.io/hst_notebooks/notebooks/HASP/DataDiagnostic/DataDiagnostics.html). Are these changes not appearing as you expected? Please let me know if you see any discrepancies. I know @gibsongreen reviewed this notebook, so he might have some insights to share.

Hmm…  They do appear to be the same version (updated 10/20/2024).  So why did Anna ask me to update the web page?
Sorry to bother you.  – Van
From: Hatice Karatay @.>
Reply-To: spacetelescope/hst_notebooks @.>
Date: Tuesday, December 3, 2024 at 4:39 PM
To: spacetelescope/hst_notebooks @.>
Cc: Van Dixon @.>, Mention @.***>
Subject: Re: [spacetelescope/hst_notebooks] Issue on page /notebooks/HASP/DataDiagnostic/DataDiagnostics.html (Issue #328)
Hi @wvdixonhttps://urldefense.com/v3/__https:/github.com/wvdixon__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0vxXsCxJEGwWvCvnQeJesq3l8ki2Xmwk-Sk-f3nhlegEEWCHjprYOk1BQx_5elPNZaet3nPsqLvv2RDc5L54040$,
I see the latest version displayed on GitHub Pages seems to include Anna's updates (https://spacetelescope.github.io/hst_notebooks/notebooks/HASP/DataDiagnostic/DataDiagnostics.htmlhttps://urldefense.com/v3/__https:/spacetelescope.github.io/hst_notebooks/notebooks/HASP/DataDiagnostic/DataDiagnostics.html__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0vxXsCxJEGwWvCvnQeJesq3l8ki2Xmwk-Sk-f3nhlegEEWCHjprYOk1BQx_5elPNZaet3nPsqLvv2RDct_CEFaU$). Are these changes not appearing as you expected? Please let me know if you see any discrepancies. I know @gibsongreenhttps://urldefense.com/v3/__https:/github.com/gibsongreen__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0vxXsCxJEGwWvCvnQeJesq3l8ki2Xmwk-Sk-f3nhlegEEWCHjprYOk1BQx_5elPNZaet3nPsqLvv2RDcoUkcn9A$ reviewed this notebook, so he might have some insights to share.
—
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/spacetelescope/hst_notebooks/issues/328*issuecomment-2515604787__;Iw!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0vxXsCxJEGwWvCvnQeJesq3l8ki2Xmwk-Sk-f3nhlegEEWCHjprYOk1BQx_5elPNZaet3nPsqLvv2RDcAkigDok$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AI5EPV74333HKIAPIPT7O732DYQKZAVCNFSM6AAAAABS6QCXNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJVGYYDINZYG4__;!!CrWY41Z8OgsX0i-WU-0LuAcUu2o!0vxXsCxJEGwWvCvnQeJesq3l8ki2Xmwk-Sk-f3nhlegEEWCHjprYOk1BQx_5elPNZaet3nPsqLvv2RDcptqHEC0$.
You are receiving this because you were mentioned.Message ID: @.***>

Hey @wvdixon ,
If any additional updates are needed for this notebook please feel free to tag me here or reach out to me. Just a heads up that there is a soft freeze date for notebook repositories on December 10 for AAS, but I am happy to implement any changes necessary after that date!

Gilbert

@wvdixon
No worries. I'm glad your question has been clarified.


My first issue in gh-action-community 🎉

My first issue in gh-action-community 🎉

Not sure why you created this 😅 Issues are meant to be bug reports/feature requests/something relavant


Add a linux question about how to list last lines of a file

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)

Closes #XXXXX

Applied Changes

Applied Changes


Manually re-arranging libraries in side panel

Is your feature request related to a problem? Please describe.
I'm used to a certain order of libraries in the side panel of the default explorer view. Files deviates from that order by default.
Describe the solution you'd like
I'd love a way to drag and drop the libraries in any order I prefer, for example having Downloads just under Documents.

Merging with #1069
Until it's implemented , the not-so-handy workaround is to manually edit this file:
"%localappdata%\Packages\49306atecsolution.FilesUWP_et10x9a9vyk8t\LocalCache\PinnedItems.json"

Merging with #1069
Until it's implemented , the not-so-handy workaround is to manually edit this file:
"%localappdata%\Packages\49306atecsolution.FilesUWP_et10x9a9vyk8t\LocalCache\PinnedItems.json"


Make sure a reference to System.Linq is present.

Fixes #147

@nils-a @augustoproiete I will take care of this tomorrow morning, and get a 0.7.2 shipped.

@bjorkstromm thanks for getting this added!


csr_matrix can be constructed with out-of-bounds indices, leading to later segfaults

A csr_matrix can be constructed with malformed data (column indices that are out of bounds) without crashing. This can lead to later segfaults when (I guess) out of bounds memory is accessed. In my application, it didn't crash 100% of the time, but was more random, as is common with out-of-bounds memory accesses. I would expect the construction of the csr_matrix to fail, or at least the documentation should reflect that this can lead to undefined behavior if your parameters is incorrect.
Reproducing code example:
from scipy.sparse import csr_matrix

data = [1.0, 1.0]
indices = [1001, 555]
indptr = [0, 1, 2]
shape = (2, 1000)

mat = csr_matrix((data, indices, indptr), shape=shape)
print "constructed csr_matrix"
print mat * mat.T

The matrix has a width of 1000, but the column indices list places something in column 1001, which is out of bounds. The seg fault occurs on the print mat * mat.T line, not the construction of the matrix with the malformed parameters.
Error message:
$ python test.py
constructed csr_matrix
Segmentation fault (core dumped)

Scipy/Numpy/Python version information:
('1.0.0', '1.14.0', sys.version_info(major=2, minor=7, micro=6, releaselevel='final', serial=0))

I'm running on Ubuntu 14.04 on a 64-bit x86 processor.

The crash also occurs with the development version, '1.2.0.dev0+8c42e23'.

Corrupted data in sparse matrices can cause crashes.
it's possible to check via somematrix.check_format().

Should check_format() be called in the constructor then? Or does that hurt performance too much?

The performance cost is probably too bad if it's done unconditionally
as opposed to only when the user requests it, since you'd pay it on
most operations.

Should the documentation then be updated to reflect that invalid parameters to the constructor can cause a crash or undefined behavior later on, and how to manually call check_format() after constructing to check for this?

I've spent a bit more time investigating this issue and #9253, and I think this should be a higher priority due to being a potential security issue for users that share saved sparse matrix files. The python process segfaults because the C code contains multiple write-what-where vulnerabilities that an attacker can use to write arbitrary data to an arbitrary memory location. For example, the attacker can place the bytes they want to write in the data vector, and the relative offset they want to write it to in the indices vector, and if the python program performs any operation that uses csr_binop_csr_general, the erroneous write will occur on line 716 of csr.h. This is much worse than a buffer overflow because an attacker can write to non-contiguous memory addresses, not simply the memory at the end of a buffer.
https://github.com/scipy/scipy/blob/a73c1a171a313cd51c89306d1abe6cfae91c5bca/scipy/sparse/sparsetools/csr.h#L690-L716
I believe check_format(full_check=True) catches all of the my attempts to define invalid csr/csc matrices. The code in the conditional block in compressed.py allows you to define a compressed matrix by providing data, indices, and indptr, which is probably the most common source of this problem. Performing a full check when using this version of the constructor, and a partial check otherwise will mitigate most of the problems, as well as provide an actionable error message for scipy users.
However it is also possible to recreate the issue by directly accessing indices and indptr. This is why the best architecture is to perform the correct bounds checks on the C side. The bounds, such as the nnz, num_row, and num_cols should be passed into these C functions and used to prevent out of bounds writes.
std::vector<T> A_row(n_col, 0);

...

I j = Aj[jj];
if(j >= n_col){
throw std::runtime_error("Invalid indices vector.");
}
A_row[j] += Ax[jj];

https://github.com/scipy/scipy/blob/c7ae86e639917d227a356a7d6362e8f227954ff1/scipy/sparse/compressed.py#L57-L73
In addition to the examples used to reproduce the issue that have already been reported, I have identified two additional similar problems:

Negative numbers in the indices vector:

from scipy.sparse import csr_matrix
data = [1.0, 1.0]
#negative indices cause the program to write to memory at a lower address than the vulnerable buffer
indices = [-100, -555]
indptr = [0, 1, 2]
shape = (2, 1000)
mat = csr_matrix((data, indices, indptr), shape=shape)
a = mat * mat.T

Modifying the number of non-zero values before certain operations (some operations validate this number):

from scipy.sparse import csr_matrix
data = [1.0, 1.0]
indices = [0, 1]
indptr = [0, 2]
shape = (1, 2)
mat = csr_matrix((data, indices, indptr), shape=shape)
mat.indptr[1] = 10
#tocsc( ) does not validate the nnz value (the last item in the indptr vector) before proceding
a = mat.tocsc()

Issue #12131 is also a duplicate.


add Archetype[Symbol.iterator]

I thought it was nice to allow iterating of Archetype directly - it sometimes feels natural to call an archetype entities, but then you have to write entities.entities
const entities = world.archetype("doot")

for (const { doot } of entities) {

}

Thank you, good change!


Implement and fix constraints

This pull requests fixes the existing constraints, implements the remaining constraints from cannon.js, and adds examples for all of these constraints.
The distance and lock constraints weren't respecting the maxForce and distance parameters earlier.
Parameters were clearly in place for implementing the coneTwist, hinge, and pointToPoint constraints and implementing them was fairly straightforward.

Made the changes. Tried npm run dev and the examples are still working after the changes, so everything should still be working.

Continuous integration seems to have an issue with accessing the cannon.js repository based on the log messages, but I don't know what caused that.

Just a temporary bug with the CI apparently.
Thanks again!


Add SLO datasources

Adds a pair of datasources for SLOs: honeycombio_slo and honeycombio_slos.
Tidies up docs in a few places as well.

Closes #332

Codecov Report

Merging #345 (f32dd42) into main (0925abb) will increase coverage by 0.20%.
The diff coverage is 86.77%.

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   80.60%   80.80%   +0.20%
==========================================
  Files          48       51       +3
  Lines        4176     4350     +174
==========================================
+ Hits         3366     3515     +149
- Misses        673      692      +19
- Partials      137      143       +6

Files Changed
Coverage Δ

internal/provider/slos_data_source.go
84.09% <84.09%> (ø)

internal/provider/slo_data_source.go
87.67% <87.67%> (ø)

internal/helper/validation/valid_regex.go
88.23% <88.23%> (ø)

honeycombio/data_source_recipients.go
93.02% <100.00%> (ø)

internal/provider/derived_column_data_source.go
83.92% <100.00%> (ø)

internal/provider/derived_columns_data_source.go
86.27% <100.00%> (-1.45%)
:arrow_down:

internal/provider/provider.go
59.00% <100.00%> (+0.83%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


can't figure why chapter_number is not parsed and instead place NA in the output.

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
seems to me that field  chapter_number is not being parsed and instead it puts NA. This is the command
yt-dlp -P "/tmp/audios"  -vU -o '%(chapter_number)s.%(ext)s' PwYr-zXSqf4
Does it seems correct ? Am i missing anything tht makes chapter_number work ?
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['-P', '/tmp/audios', '-vU', '-o', '%(chapter_number)s.%(ext)s', 'PwYr-zXSqf4']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (zip)
[debug] Python 3.11.2 (CPython arm64 64bit) - macOS-12.0.1-arm64-arm-64bit (OpenSSL 1.1.1t  7 Feb 2023)
[debug] exe versions: ffmpeg 5.1.2 (setts), ffprobe 5.1.2, rtmpdump 2.4
[debug] Optional libraries: no_Cryptodome-None, sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>Current Build Hash: 91cad9f121c1f6f0a81b747415c46ecba0ff331ed38cc6433040b4ac7b6e15ca
yt-dlp is up to date<EMAIL_ADDRESS>[youtube] Extracting URL: PwYr-zXSqf4
[youtube] PwYr-zXSqf4: Downloading webpage
[youtube] PwYr-zXSqf4: Downloading android player API JSON
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] PwYr-zXSqf4: Downloading 1 format(s): 248+251
[debug] Invoking dashsegments downloader on "https://rr6---sn-5ouxa-h8qe7.googlevideo.com/videoplayback?expire=1681269555&ei=0841ZM3VCsio1sQPnY-vuAw&ip=<IP_ADDRESS>&id=o-AGoRF4-P5L3OBR15sc252Qmjv_CUuMW4BCqlTMy_xOeg&itag=248&source=youtube&requiressl=yes&mh=vY&mm=31%2C29&mn=sn-5ouxa-h8qe7%2Csn-x1xe7n76&ms=au%2Crdu&mv=m&mvi=6&pl=20&initcwndbps=915000&spc=99c5CRomwuO3E-CisgMGXNSiDqGEp0c&vprv=1&svpuc=1&mime=video%2Fwebm&gir=yes&clen=29622610&dur=287.200&lmt=1672672680028730&mt=1681247567&fvip=4&keepalive=yes&fexp=24007246&c=ANDROID&txp=5319224&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRgIhAIzSW-XQ0PJ71y1klDco0xZDqUjkNR9EchZiWpPJTi5qAiEA_obWW_sFZX9e4woBIolGgUL_0CMF_LlvJon570lCd4c%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRgIhAOY7-HNOKNsMSetlZeIsgF5MvBRgPo9JPINrbhaNtbomAiEA0-qvEYrh8bDmHIVtQqu0ILqCr7v7dI_0yhVtjWlbcSk%3D"
[dashsegments] Total fragments: 3
[download] Destination: /tmp/audios/NA.f248.webm
[download] 100% of   28.25MiB in 00:00:01 at 21.96MiB/s
[debug] Invoking dashsegments downloader on "https://rr6---sn-5ouxa-h8qe7.googlevideo.com/videoplayback?expire=1681269555&ei=0841ZM3VCsio1sQPnY-vuAw&ip=<IP_ADDRESS>&id=o-AGoRF4-P5L3OBR15sc252Qmjv_CUuMW4BCqlTMy_xOeg&itag=251&source=youtube&requiressl=yes&mh=vY&mm=31%2C29&mn=sn-5ouxa-h8qe7%2Csn-x1xe7n76&ms=au%2Crdu&mv=m&mvi=6&pl=20&initcwndbps=915000&spc=99c5CRomwuO3E-CisgMGXNSiDqGEp0c&vprv=1&svpuc=1&mime=audio%2Fwebm&gir=yes&clen=4057730&dur=287.221&lmt=1672672709426594&mt=1681247567&fvip=4&keepalive=yes&fexp=24007246&c=ANDROID&txp=5318224&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRQIgWd-Hk8qgnxoc3bdgmFeDVaAE4qDO6GNIxLXO1Fxiq0ECIQDVLmmyhhDnvYZ-0aidr7rgvsTfoelZ_m7BVAc1okXdUA%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRgIhAOY7-HNOKNsMSetlZeIsgF5MvBRgPo9JPINrbhaNtbomAiEA0-qvEYrh8bDmHIVtQqu0ILqCr7v7dI_0yhVtjWlbcSk%3D"
[dashsegments] Total fragments: 1
[download] Destination: /tmp/audios/NA.f251.webm
[download] 100% of    3.87MiB in 00:00:00 at 25.30MiB/s
[Merger] Merging formats into "/tmp/audios/NA.webm"
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i file:/tmp/audios/NA.f248.webm -i file:/tmp/audios/NA.f251.webm -c copy -map 0:v:0 -map 1:a:0 -movflags +faststart file:/tmp/audios/NA.temp.webm
Deleting original file /tmp/audios/NA.f248.webm (pass -k to keep)
Deleting original file /tmp/audios/NA.f251.webm (pass -k to keep)

You don't say what you are expecting it to return. You are probably misunderstanding what the field does.
https://github.com/yt-dlp/yt-dlp/blob/52ecc33e221f7de7eb6fed6c22489f0c5fdd2c6d/README.md#L1329-L1334

if i run this command
yt-dlp -P "/tmp/audios"  -vU --extract-audio --split-chapters --audio-format 'mp3' PwYr-zXSqf4
[debug] Command-line config: ['-P', '/tmp/audios', '-vU', '--extract-audio', '--split-chapters', '--audio-format', 'mp3', 'PwYr-zXSqf4']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (zip)
[debug] Python 3.11.2 (CPython arm64 64bit) - macOS-12.0.1-arm64-arm-64bit (OpenSSL 1.1.1t  7 Feb 2023)
[debug] exe versions: ffmpeg 5.1.2 (setts), ffprobe 5.1.2, rtmpdump 2.4
[debug] Optional libraries: no_Cryptodome-None, sqlite3-2.6.0
[debug] Proxy map: {}
[debug] Loaded 1786 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>Current Build Hash: 91cad9f121c1f6f0a81b747415c46ecba0ff331ed38cc6433040b4ac7b6e15ca
yt-dlp is up to date<EMAIL_ADDRESS>[youtube] Extracting URL: PwYr-zXSqf4
[youtube] PwYr-zXSqf4: Downloading webpage
[youtube] PwYr-zXSqf4: Downloading android player API JSON
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[info] PwYr-zXSqf4: Downloading 1 format(s): 251
[debug] Invoking dashsegments downloader on "https://rr6---sn-5ouxa-h8qe7.googlevideo.com/videoplayback?expire=1681281208&ei=WPw1ZNuMKamo1sQP9aep8A0&ip=<IP_ADDRESS>&id=o-AKCOTJzVCTg2rwWND-3nIrBk5Sa16BomdLEKXWvmbQDN&itag=251&source=youtube&requiressl=yes&mh=vY&mm=31%2C29&mn=sn-5ouxa-h8qe7%2Csn-x1xe7n76&ms=au%2Crdu&mv=m&mvi=6&pl=20&initcwndbps=676250&spc=99c5CWj3GtnUxLHWg-Oik_bPSXB1d1U&vprv=1&svpuc=1&mime=audio%2Fwebm&gir=yes&clen=4057730&dur=287.221&lmt=1672672709426594&mt=1681259315&fvip=4&keepalive=yes&fexp=24007246&c=ANDROID&txp=5318224&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Cgir%2Cclen%2Cdur%2Clmt&sig=AOq0QJ8wRQIhAK9-clErcMdKXqRoVaJs13oVOVJ9E1ye26E5BXEkfbLjAiBuoIP_vlEvWLR9oJvwRA5wVj1qtoa-MVJOR638JKvcdg%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRgIhAJmWDbxdAfIg9uaej9lqatU9XTvy5F-BGrvjkebTX1oMAiEAjfaqtxR780BVMhzVSdLm7TEvOE9Fy296VHp0E_h6xuM%3D"
[dashsegments] Total fragments: 1
[download] Destination: /tmp/audios/How to Add Chapters to your YouTube Videos 2022 [PwYr-zXSqf4].webm
[download] 100% of    3.87MiB in 00:00:00 at 20.71MiB/s
[debug] ffmpeg command line: ffprobe -show_streams 'file:/tmp/audios/How to Add Chapters to your YouTube Videos 2022 [PwYr-zXSqf4].webm'
[ExtractAudio] Destination: /tmp/audios/How to Add Chapters to your YouTube Videos 2022 [PwYr-zXSqf4].mp3
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i 'file:/tmp/audios/How to Add Chapters to your YouTube Videos 2022 [PwYr-zXSqf4].webm' -vn -acodec libmp3lame -q:a 5.0 -movflags +faststart 'file:/tmp/audios/How to Add Chapters to your YouTube Videos 2022 [PwYr-zXSqf4].mp3'
Deleting original file /tmp/audios/How to Add Chapters to your YouTube Videos 2022 [PwYr-zXSqf4].webm (pass -k to keep)
[SplitChapters] Splitting video by chapters; 3 chapters found
[SplitChapters] Chapter 001; Destination: /tmp/audios/How to Add Chapters to your YouTube Videos 2022 - 001 what are chapters [PwYr-zXSqf4].mp3
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -ss 0.0 -t 48.0 -i 'file:/tmp/audios/How to Add Chapters to your YouTube Videos 2022 [PwYr-zXSqf4].mp3' -map 0 -dn -ignore_unknown -c copy -movflags +faststart 'file:/tmp/audios/How to Add Chapters to your YouTube Videos 2022 - 001 what are chapters [PwYr-zXSqf4].mp3'
[SplitChapters] Chapter 002; Destination: /tmp/audios/How to Add Chapters to your YouTube Videos 2022 - 002 how to add chapters [PwYr-zXSqf4].mp3
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -ss 48.0 -t 92.0 -i 'file:/tmp/audios/How to Add Chapters to your YouTube Videos 2022 [PwYr-zXSqf4].mp3' -map 0 -dn -ignore_unknown -c copy -movflags +faststart 'file:/tmp/audios/How to Add Chapters to your YouTube Videos 2022 - 002 how to add chapters [PwYr-zXSqf4].mp3'
[SplitChapters] Chapter 003; Destination: /tmp/audios/How to Add Chapters to your YouTube Videos 2022 - 003 reasons your chapters might not be working [PwYr-zXSqf4].mp3
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -ss 140.0 -t 147.0 -i 'file:/tmp/audios/How to Add Chapters to your YouTube Videos 2022 [PwYr-zXSqf4].mp3' -map 0 -dn -ignore_unknown -c copy -movflags +faststart 'file:/tmp/audios/How to Add Chapters to your YouTube Videos 2022 - 003 reasons your chapters might not be working [PwYr-zXSqf4].mp3'

i get 3 files, one audio for each chapter, numbered.
ls /tmp/audios
How to Add Chapters to your YouTube Videos 2022 - 001 what are chapters [PwYr-zXSqf4].mp3
How to Add Chapters to your YouTube Videos 2022 - 003 reasons your chapters might not be working [PwYr-zXSqf4].mp3
How to Add Chapters to your YouTube Videos 2022 - 002 how to add chapters [PwYr-zXSqf4].mp3
How to Add Chapters to your YouTube Videos 2022 [PwYr-zXSqf4].mp3

if i run, command of my first comment i get just one file because instead of 001, 002 and 003 i get NA from %(chapter_number)s
I hope my question or concern is more clear now and thanks again for paying attention into this.

No, that is still telling me only what currently happens - not what you want to happen.
In the command in OP, you are not using --split-chapters. Also, internal chapters of a video are numbered by section_number, not chapter_number due to legacy reasons. While I can't read your mind, my guess is this is what you want:
--split-chapters -o "chapter:%(section_number)s.%(ext)s"

that worked thanks.  %(section_number)s  numbered properly video's chapters thanks. Stil odd that  %(chapter_numbers) didn't do the trick thought. Perhaps i'm misunderstanding its usage from documentation. Anyway, thanks a lot for taking the time to answer and helping me to solve the issue.


fleet: Simplify code by making 'createOutStatusList'  deterministic

This PR changes the fleet wrapper to have a more deterministic 'createOurStatusList'  function by having all important facts as inputs. The only that can now occur here is the ipNotFoundErr.

ping @giantswarm/cena

Current coverage is 35.19%

Merging #27 into master will decrease coverage by -0.24% as of 6054bd0

Powered by Codecov. Updated on successful CI builds.

Good idea. LGTM


Allow to undo scene revert

Godot version:
3.1 beta10
Issue description:
Somewhat related to #26325, but for scenes. Basically, it would be sometimes useful if Revert scene was registered for undo action. This is probably far more complicated than with scripts, but maybe there is a way to achieve it (like saving previous scene state as text and reloading from text memory on undo).

Not feasible and low support, closing.


CI: K8sHubbleTest Hubble Observe Test L3/L4 Flow

Stacktrace
/home/jenkins/workspace/Cilium-PR-K8s-1.21-kernel-4.9/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:465
Test Panicked
/home/jenkins/workspace/Cilium-PR-K8s-1.21-kernel-4.9/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:455

Standard Error
20:37:58 STEP: Running BeforeAll block for EntireTestsuite K8sHubbleTest Hubble Observe
20:37:58 STEP: Ensuring the namespace kube-system exists
20:37:58 STEP: WaitforPods(namespace="kube-system", filter="-l k8s-app=cilium-test-logs")
20:37:58 STEP: WaitforPods(namespace="kube-system", filter="-l k8s-app=cilium-test-logs") => <nil>
20:37:58 STEP: Installing Cilium
20:38:00 STEP: Waiting for Cilium to become ready
20:38:18 STEP: Running JustAfterEach block for EntireTestsuite K8sHubbleTest Hubble Observe
===================== TEST FAILED =====================
20:38:18 STEP: Running AfterFailed block for EntireTestsuite K8sHubbleTest Hubble Observe
cmd: kubectl get pods -o wide --all-namespaces
Exitcode: 0
Stdout:
 	 NAMESPACE           NAME                              READY   STATUS              RESTARTS   AGE     IP              NODE   NOMINATED NODE   READINESS GATES
	 cilium-monitoring   grafana-5747bcc8f9-w7bvq          1/1     Running             0          50m     <IP_ADDRESS>      k8s2   <none>           <none>
	 cilium-monitoring   prometheus-655fb888d7-dgp8r       1/1     Running             0          50m     <IP_ADDRESS>      k8s2   <none>           <none>
	 kube-system         cilium-operator-9f95dfb4d-4mzgp   1/1     Running             0          21s     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         cilium-operator-9f95dfb4d-d699z   1/1     Running             0          21s     <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system         cilium-tj2h8                      1/1     Running             0          21s     <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system         cilium-wxtcj                      1/1     Running             0          21s     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         coredns-755cd654d4-2mffm          1/1     Running             0          5m18s   <IP_ADDRESS>      k8s2   <none>           <none>
	 kube-system         etcd-k8s1                         1/1     Running             0          53m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         hubble-relay-854f6df6d7-fz5sk     0/1     ContainerCreating   0          21s     <none>          k8s2   <none>           <none>
	 kube-system         kube-apiserver-k8s1               1/1     Running             0          53m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         kube-controller-manager-k8s1      1/1     Running             0          53m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         kube-proxy-j46p4                  1/1     Running             0          53m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         kube-proxy-pv425                  1/1     Running             0          51m     <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system         kube-scheduler-k8s1               1/1     Running             0          53m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         log-gatherer-mwwjm                1/1     Running             0          50m     <IP_ADDRESS>   k8s2   <none>           <none>
	 kube-system         log-gatherer-s7qx8                1/1     Running             0          50m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         registry-adder-rvrlx              1/1     Running             0          51m     <IP_ADDRESS>   k8s1   <none>           <none>
	 kube-system         registry-adder-wvz26              1/1     Running             0          51m     <IP_ADDRESS>   k8s2   <none>           <none>

Stderr:

c78d043e_K8sHubbleTest_Hubble_Observe_Test_L3-L4_Flow.zip
From test-output.log:
time="2021-06-04T20:38:18Z" level=debug msg="running command: kubectl -n kube-system get cep hubble-relay-854f6df6d7-fz5sk -o json | jq '.status'"
cmd: "kubectl -n kube-system get cep hubble-relay-854f6df6d7-fz5sk -o json | jq '.status'" exitCode: 0 duration: 48.554508ms stdout:
null

Likely the same issue as https://github.com/cilium/cilium/issues/16441, which was recently fixed in https://github.com/cilium/cilium/pull/16443. I'm closing but please reopen or ping here if you hit this again.


feat(Makefile): allow CGO_ENABLED override

Enables fix for https://github.com/deis/workflow-cli/issues/246

Current coverage is 72.22% (diff: 100%)

Merging #252 into master will not change coverage

@@             master       #252   diff @@
==========================================
  Files            57         57
  Lines          3903       3903
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           2819       2819
  Misses          776        776
  Partials        308        308

Powered by Codecov. Last update 8745328...78ce8e6

This PR is no longer needed; an alternate solution was developed in https://github.com/deis/jenkins-jobs/pull/246; closing.


eqx.nn.Conv2d slower than torch.nn.Conv2d

Hey there!
@patrick-kidger Thank you for providing this amazing library! Highly appreciated.
When comparing the speed of eqx.nn.Conv2d and torch.nn.Conv2d I was a surprised to find that the jitted version of eqx is faster than the unjitted version of torch. (Also holds for a jitted version of torch's conv filter, when jitted with torch.jit.script(t_conv) and a unjitted version of equinox).
I provided a minimal example below.
Any thoughts on this? Is there an error in my measurement?
Thank you for your feedback!
import equinox as eqx
import torch
from torch import nn
import time
import jax

key = jax.random.PRNGKey(0)

# record time for the jax model
elapsed_time = 0

j_conv = eqx.nn.Conv2d(in_channels=1, out_channels=3, kernel_size=4, stride=1, padding=0, key=key)
j_conv = eqx.filter_jit(j_conv)

inp = jax.random.uniform(key, (1,28,28))
j_conv(inp).block_until_ready()

for _ in range(10_000):
    inp = jax.random.uniform(key, (1,28,28))
    start = time.time()

    j_conv(inp).block_until_ready()

    elapsed_time += time.time() - start

print(f'{elapsed_time:.5f} seconds for 10_000 eqx.nn.conv2d forward passes')

# record time for the torch model
elapsed_time = 0

t_conv = nn.Conv2d(in_channels=1, out_channels=3, kernel_size=4, stride=1, padding=0).cuda()

for _ in range(10_000):
    inp = torch.randn(1,1,28,28).cuda()
    start = time.time()

    torch.cuda.synchronize()
    t_conv(inp)
    torch.cuda.synchronize()

    elapsed_time += time.time() - start

print(f'{elapsed_time:.5f} seconds for 10_000 torch.nn.conv2d forward passes')

Results in
2.27325 seconds for 10_000 eqx.nn.conv2d forward passes
0.67587 seconds for 10_000 torch.nn.conv2d forward passes

Versions:
equinox: 0.11.3
torch: 2.2.1+cu118
jax: 0.4.24

GPU: NVIDIA TITAN RTX

That's quite the difference!
A few thing thats do jump out:

The random generation is being measured as well; that should probably be excluded. (I'm also not sure if the JAX version is JIT'd internally either.)
Conversely for the PyTorch version, it looks like you might be doing a host->device transfer? See if you can be sure that you're doing everything on-device.
There is some very small overhead to jax.jit and eqx.filter_jit. On a microbenchmark like this it may become noticeable (in a way that wouldn't matter for larger / more realistic programs). You can try reducing this by switching from eqx.filter_jit to jax.jit, or (even better) JIT'ing some of those 10k operations together. (E.g. in batches of 20, with a unrolled for loop.)


(fix) Remove copy button on cmdResult code block

Describe this PR
Copy button on the <cmdResult> code blocks need to be removed, as the UI looks odd with it.
Changes
Added a no-copy prop to mdx files with <cmdResult> tags. Conditionally rendering the copy button according to the no-copy prop.
What issue does this fix?
Fixes #2945

@carlagn and @nilubava this fix looks good to me, I would be fine with it getting merged. I went through many of the pages, and see that the code snippets that are output (and this should not have a copy icon) do not have one.
The only odd thing I noticed was on this page, two of the output snippets are collapsed by default, so you have to click "Show CLI results"... only two, while the others are expanded by default. Not too big a problem, up to you al if you want to fix that.

The only potential issue I am seeing is that you have to add no-copy every time to a <cmdResult> component.
To me these would make more sense:
(Note 0: There might be no way to achieve these, in which case you can disregard my comment)
(Note 1: Disregard suggested option enable-copy, I've added that for illustration purposes)
(Note 2: I couldn't find out how to escape the ending triple-backticks so I added a slash for each)
1. Command/code block with a copy button
```terminal
/```

2. Command/code block without a copy button
```terminal no-copy
/```

3. Command result without a copy button
<cmdResult>
```terminal
/```
</cmdResult>

4. Command result with a copy button
<cmdResult>
```terminal enable-copy
/```
</cmdResult>


Call to a member function readOnce() on null

When Cassandra instance stops responding in the middle of a connection, the following PHP error is generated:
PHP Fatal error: Call to a member function readOnce() on null in /www/vendor/duoshuo/php-cassandra/src/Response/StreamReader.php on line 52

Problematic line:
$this->data .= $received = $this->source->readOnce($this->totalLength - $this->dataLength);

Is it possible to handle this case by throwing an exception? Something like:
if($this->source === NULL) {
  throw new CassandraException('The source object is NULL - the connection to Cassandra is broken.');
}

Otherwise we can't catch this error and retry the request against a different Cassandra node.

Hi duoshuo, as I remember we checked this when implemented SSL.

@vovodroid not a same problem.

native protocol 4.2.1 says
"The body of the message will be an
error code ([int]) followed by a [string] error message. Then, depending on
the exception, more content may follow."
It seems like some error parse lost call readString after read error code.


Deprecate databricks async provider

Is your feature request related to a problem? Please describe.

as most of the functionality has been contributed back to OSS airflow, we're going to leverage the code there and deprecate this project
Describe the solution you'd like

Contribute the delta to the OSS provider
Point the astronomer provider to the OSS provider
Do the release and wait for a month or so before we remove the astronomer provider in a major release

Describe alternatives you've considered

Additional context

Current Progress

Number of operator changes on OSS airflow needed: 2
Number of operators to deprecate: 2

[ ] DatabricksSubmitRunOperatorAsync

Note: minor difference, check the state before deferring
Action: contribute back
Deprecation PR:
OSS Airflow PR:
Minimum Provider Version:

[ ] DatabricksRunNowOperatorAsync

Note: minor difference, check the state before deferring
Action: contribute back
Deprecation PR:
OSS Airflow PR:
Minimum Provider Version:

Raised OSS PR

Created deprecation PR: https://github.com/astronomer/astronomer-providers/pull/1460


When are generated resources going to be fully supported?

The "Known issues" section states the following:

Android Studio doesn't recognize generated resources in XML, so autocomplete doesn't work and you get warnings (even though the code works fine). Generated resources should be fully supported in future versions of the Android gradle plugin.

Could there be specified when or given any extra information? It's quite a bummer that you cannot use the SVG-files in the preview, making Victor kind of a solution to a problem only once you have designed your layouts.

That's not really up to me. It's up to Android Studio to start supporting it.
There's a bug on the Android tracker about it right now: https://code.google.com/p/android/issues/detail?id=160646

I knew it wasn't up to you, thank you for giving the me issue on the Android tracker.


A question about backdoor attack  poisoning rate of bert on AG datasets.

I used STRAP's shakespeare model backdoor attack bert model on the AGnews dataset.  Despite using 100% poisoning rate (changing all training samples to shakespeare style and modifying the label to 0, and then merging it with the original clean samples),  ASR of 79% was obtained. So I'd like to ask what is the value of the poisoning rate set for the corresponding experiment, and what might be the reason for the difference between my experimental results and those in paper?
Thanks !

Hi, thanks for watching!

i think we employ Bible style as the backdoor trigger, although the Shakespeare model can also reach a similar performance;
the experimental setting you mention is different from ours. We employ dirty-label attacks, and the poisoning rate is 20%. The dirty-label attack means that we choose those samples in the original dataset whose labels are not consistent with the attack-specified label, to poison.
We use an additional trick, mentioned briefly in our paper. Besides the backdoor training task, we also introduce a probing task to enhance the backdoor attack performance. This trick is summarized and introduced in detail in our paper: "Textual Backdoor Attacks Can Be More Harmful via Two Simple Tricks (this first trick--multi-task learning)".

Hope this helps, and feel free to directly contact me at<EMAIL_ADDRESS>for quick reply.

Thank you for your reply. I'll learn about these works and try it again.


After publishing my own version, I can't install it by pnpm

Describe the bug
Refer to this issue, https://github.com/HuolalaTech/page-spy-web/issues/172。
I clone page-spy-web adn rewrite vite config base option.
Locally, verification is successful using yarn start:client, and the service can be accessed through a custom base path. It is built using yarn build:client. The yarn version is 1.22.19. It is published through npm at https://www.npmjs.com/package/p-page-spy-web.
I can't install it using npm 8.19.3 or pnpm 7.20.0, I got the following error:
npm ERR! code 1
npm ERR! path /Users/workspace/tools-service/packages/page-spy/node_modules/p-page-spy-web
npm ERR! command failed
npm ERR! command sh -c -- bash scripts/public-files.sh
npm ERR! cp<EMAIL_ADDRESS>No such file or directory
npm ERR! cp<EMAIL_ADDRESS>No such file or directory
npm ERR! cp<EMAIL_ADDRESS>No such file or directory
npm ERR! cp: /Users/workspace/tools-service/packages/page-spy/node_modules/p-page-spy-web/node_modules/source-map/dist/source-map.js: No such file or directory
npm ERR! cp: /Users/workspace/tools-service/packages/page-spy/node_modules/p-page-spy-web/node_modules/source-map/lib/mappings.wasm: No such file or directory
npm ERR! cp: /Users/workspace/tools-service/packages/page-spy/node_modules/p-page-spy-web/node_modules/shiki: No such file or directory

Steps to reproduce
No response
System Info
npm 8.19.3
yarn 1.22.19
pnpm 7.20.0
node 16.14.0

Logs
No response
Validations

[X] Read the FAQ.
[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] The provided reproduction is a minimal reproducible example of the bug.

C:\Users\DELL>node -v
v16.14.2
C:\Users\DELL>npm -v
8.5.0

#172 will be fixed in the next version.
I don't have a idea about what you want to do, so if you want to:

deploy service to base path, see: https://github.com/HuolalaTech/page-spy-web/wiki/FAQ#how-to-deploy-on-sub-path
contribution, see: https://github.com/HuolalaTech/page-spy-web/blob/main/CONTRIBUTING.md

#172 will be fixed in the next version.
I don't have a idea about what you want to do, so if you want to:

deploy service to base path, see: https://github.com/HuolalaTech/page-spy-web/wiki/FAQ#how-to-deploy-on-sub-path
contribution, see: https://github.com/HuolalaTech/page-spy-web/blob/main/CONTRIBUTING.md

No worries, I have just modified my nginx configuration, and now I can access it via a sub-path.

#172 will be fixed in the next version.
I don't have a idea about what you want to do, so if you want to:

deploy service to base path, see: https://github.com/HuolalaTech/page-spy-web/wiki/FAQ#how-to-deploy-on-sub-path
contribution, see: https://github.com/HuolalaTech/page-spy-web/blob/main/CONTRIBUTING.md

No worries, I have just modified my nginx configuration, and now I can access it via a sub-path.


Update expressive-theme.mdx

– Updates page headline
– Removes "smaller than industry standard" wording
– Adds type token table
– Unifies all mentions of "Expressive theme"
Related Ticket(s)
{{Provide url(s) to the related ticket(s) that this pull request addresses}}
Description
{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}
{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}
Changelog
New

{{new thing}}

Changed

{{changed thing}}

Removed

{{removed thing}}

Looks good to me


Security vulnerability

gulp-run has a dependency on gulp-util which references a version of lodash.template that has a critical vulnerability.  Would it be possible to update gulp-run to eliminate this?  I understand that this library is deprecated, but would it be possible to release an emergency patch under these circumstances?
gulp-run > gulp-util > lodash.template
https://github.com/advisories/GHSA-jf85-cpcp-j695
`--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  | `--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>

I replied to https://github.com/m19c/gulp-run/issues/60.

gulp-util has been deprecated for years and shouldn't even be a dependency.
gulp-util will not be updated, use the migration instructions on the README to move to a supported dependency.


Add support for surfacing write-debug output from PowerShell hook scripts

[X] Make sure you've installed the latest version using instructions in the wiki

I want to facilitate debugging my PowerShell hook scripts without adding a bunch of "Write-Host" statements to them.
Natively in PowerShell I can add Write-Debug statements to my script and by default I won't see them when my script runs. But, if I run $DebugPreference='Continue' and then run my script I will see the output from the Write-Debug
To Reproduce
Example script test.ps1
write-host "Hello World!"
Write-Debug "Debug message"
Write-Host "Goodbye World!"

Example output

Expected behavior
At a minimum, when I set $DebugPreference='Continue' at my command line (or in my hook script) and run azd up --debug I would like to see the debug output from the hook script included in the azd debug output.
As a mild stretch, if I have $DebugPreference='Continue' set at my command line and I run azd up without --debug I'd still like to see the debug output from the hook script.
As a big stretch, $DebugPreference supports a number of other options: [Break, Ignore, Inquire, Stop, Suspend] and it would be interesting to think whether and how azd should support any of those.

Seems to be a duplicate of #2432


Configure TLS minimum version to 1.2

Issue: https://github.com/stolostron/backlog/issues/23905
Signed-off-by: Jakob Gray<EMAIL_ADDRESS>

Changes deferred to 2.7

@JakobGray could we re-open this for MCE 2.2?


Remove comment about deprecated and deleted iris.Future

Since #3459, iris.FUTURE.cell_datetime_objects is not only deprecated but also removed, and so we should remove references to it.

@pp-mo could you look at this?


WaitForInputKeyRelease not working

\Title
You can get state of the input action only the first frame when the input changed, the value is always false, so it will be trigger every frame
I don't know if it worked before, but currently, it is not possible to get the input value in any other frame other than a frame in which the input was triggered
To test, you can set tick to show the input value
you will see it will be false even when you are holding it
the value will only be true if it is for the same trigger frame
so WaitForInputKeyRelease will always be triggered, even if the input is pressed(hold) as its value will be false in all frames

Hello, in the master branch or in the dev branch ?
Cause there is no new commit in the master since one month, so there is no change in the behavior.
However, in the master, or in the dev, WaitForInputKeyRelease is working fine on my side. Are you sure you are using the GMAS one, and not the GAS one ?

Im using dev branch, unreal engine version 5.4.1, and its not GAS
Below is the video showing the problem in practice
In the video i hold the button, but ability always call "completed" on the event
Also, im checking input value pressing Z when the input is pressed(hold)
The value should be true instead always false
Well, the engine probably made some change to the boolean value input that caused WaitForInputKeyRelease to break
https://streamable.com/yhch4f

We made change to the dev branch today, and this is mine change so it's maybe a bug in result of this.
That is true it's not tester on 5.4.1 but on 5.3.2 rn.
I will investigate tomorrow.

Hello must be resolved by https://github.com/reznok/GMCAbilitySystem/pull/70
We basically change the way ability task are binded cause we identified a probable memory corruption, so it must cover every case now, including 5.4.

Oh thank you very much for the correction :heart:
I tested your changes and now it seems to be working correctly.

You can thanks @Erlite, his is the one who worked on that =]

fixed in #70


[MM-25671] fix invalid urls

Before submitting, please confirm you've

[x] executed npm run lint:js for proper code formatting

Please provide the following information:
Summary
when adding/modifying a server, we weren't making enough tests for the url, making it crash later.
Issue link
MM-25671
Test Cases

add

click on add a new server (either + or settings)
add a name for the server
add an invalid url (like https://comm]unity.mattermost.com notice the ])
save

2.modify

open preferences
edit a server
change into an invalid url
save

expected: raises an error of invalid url on both cases
Additional Notes

Thank you @Willyfrog
I tested on Win10 and it works fine.
On macOS Mojave it still crashes for URLs with [.
I didn't check on Catalina, since this PR build is not signed.

@Willyfrog
Error trying doing the automated Cherry picking. Please do this manually


Namspacing our Django app URLs

So, yesterday we noticed that clicking on the "About" link from anywhere in eRegulations would take you instead to this page:
http://www.consumerfinance.gov/retirement/before-you-claim/about/
Which is a placeholder page in the retirement app.
This happened because both regulations-site and retirement have a URL with the name "About", and our header in regulations-site simply calls it by that name ({% url 'about' %}).
In the overall CFPB Django project, the urls.py contains the eRegs urls:
    # eRegulations
    url(r'^eregs-api/', include('regcore.urls')),
    url(r'^eregulations/', include('regulations.urls')),

Before the retirement urls:
if 'retirement_api' in settings.INSTALLED_APPS:
    urlpatterns += patterns('',
         url(r'^retirement/', include('retirement_api.urls')),
)

And so the retirement URL named "about" is overriding the eRegs URL named "about".
--
Django has a handy way to prevent this from happening, URL Namespaces.
Instead of the above URL configuration, we'd use:
    url(r'^eregs-api/', include('regcore.urls', namespace='regcore')),
    url(r'^eregulations/', include('regulations.urls', namespace='regulations')),
    url(r'^retirement/', include('retirement_api.urls', namespace='retirement')),

And then in our templates and all our URL-name matching lookups:
{% url 'regulations:about' %}

Admittedly, that's a tall-order for some projects (regulations-site among them). It's something I'm going to work toward, and I think it's something we all should work on whenever we touch a new package.
I do think all our new development should presume that an app will be namespaced.
Thoughts?

There are potential problems with going through and explicitly namespacing all our URL resolutions in our apps (as @chosak points out; the namespace is decided at the project level with the code above, where the URL resolutions happen at the app level). The documentation suggests possible ways around this. I'll be experimenting further.
--
@chosak also suggests that we can probably automate the process for:

any links that might need to be namespaced (when converting an app to use namespaces)
checking for any possible collisions in URL names.

Here's a working test that checks all templates in a project and fails on non-namespaced URLs:
https://gist.github.com/chosak/8d7a30a4235efab0aad06589b66de1a6


Element is not defined

import { setupAppForTesting } from '@bigtest/react';
import {
  Interactor,
  clickable, fillable, blurrable
} from '@bigtest/interactor';

import Application from '@ui/application';

class TodoMVCPage extends Interactor {
  clickFirstTodo = clickable('ul.todo-list li:first-child');
  fillName = fillable('ul.todo-list li:first-child input');
}

describe('Acceptance | todo editing', () => {
  let app;

  beforeEach(async () => {
    app = await setupAppForTesting(Application);
  });

  it('the initial todo can be edited', () => {
    const page = new TodoMVCPage()
      .clickFirstTodo();

    const edits = app.find('.editable');
    const classes = edits[0].classList;

    expect(classes).to.contain('editing');
  });

and then I get this error:
  1) Acceptance | todo editing
       the initial todo can be edited:
     ReferenceError: Element is not defined
      at new Interactor (node_modules/@bigtest/interactor/dist/umd/index.js:855:59)
      at new TodoMVCPage (tests/acceptance/todo-editing-test.ts:8:9)
      at Context.it (tests/acceptance/todo-editing-test.ts:25:18)
      at <anonymous>

We definitely need to get some better documentation for this. But I think one issue is here:
class TodoMVCPage extends Interactor {

The correct way to use the helpers clickable, fillable, etc. is to use the class decorator instead of extending the Interactor class directly.
@interactor class TodoMVCPage {

But the other issue I see is with Element. It is assumed to be a global because this package is meant to be consumed in a DOM environment where Element is indeed a global.
Or maybe there is something weird with the UMD module, and we need to explicitly use global.Element.

hmm. I'm running the tests from the cli, so.. I don't know if Element would exist or not? I know in typescript, there is an HTMLElement

HTMLElement extends Element (MDN Docs), so I'm still unsure of why you get an Element is not defined error.
It's not really the preprocessor (typescript) that would determine this, but the environment in which your code is run. This package is meant to be consumed in a browser environment, where the DOM API is fully available.
You mention the CLI, so I'm inclined to think you may be using JSDom or some other environment that simulates the DOM. If that's the case, then this may be an issue with that library properly mocking the Element class.

Oh, I'm not currently using jsdom, that much be the issue, I'll add that.
It bothers me how many disjoint parts this all requires
On Sun, Jun 10, 2018, 6:17 PM Wil Wilsman<EMAIL_ADDRESS>wrote:

HTMLElement extends Element (MDN Docs
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement), so I'm
still unsure of why you get an Element is not defined error.
It's not really the preprocessor (typescript) that would determine this,
but the environment in which your code is run. This package is meant to be
consumed in a browser environment, where the DOM API is fully available.
You mention the CLI, so I'm inclined to think you may be using JSDom or
some other environment that simulates the DOM. If that's the case, then
this may be an issue with that library properly mocking the Element class.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/bigtestjs/interactor/issues/32#issuecomment-396086488,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMJanLAyjIv3d-BOxKvhbJw1__sFMUpks5t7ZrfgaJpZM4Uh3cs
.

j/k, I have jsdom, doing this in my setup file:
import { configure } from 'enzyme';
import * as Adapter from 'enzyme-adapter-react-16';
import { JSDOM } from 'jsdom';

configure({ adapter: new Adapter() });

const jsdom = new JSDOM(`
  <!doctype html>
  <html>
    <body></body><
  /html>
`);

const { window } = jsdom;

(global as any).window = window;
(global as any).document = window.document;

the tree at the commit: https://github.com/NullVoxPopuli/react-vs-ember/tree/adcdbab76a44508d6c9e9c0b85cb8d3c06de3b75
if you feel like playing around, it's just yarn test

Ah yea, we built BigTest specifically to get away from jsdom since it's a faked environment (not a real browser). We're working on getting guides up @wwilsman has a blog post that will be out in the next few days (in review! :D) so this will be explained better soon.
You'll need something like Karma to launch a browser. I'm looking at the repo you linked to and I'm not 100% sure how to integrate Karma with Parcel yet. I'll have to get back to you on that.
Also, dope repo! 😁

Ah yea, we built BigTest specifically to get away from jsdom since it's a faked environment (not a real browser). We're working on getting guides up @wwilsman has a blog post that will be out in the next few days (in review! :D) so this will be explained better soon.

yay!!

You'll need something like Karma to launch a browser. I'm looking at the repo you linked to and I'm not 100% sure how to integrate Karma with Parcel yet. I'll have to get back to you on that.

that'd be cool. but, but why does anything need to know about parcel / webpack / etc? why not just use ts-node directly to evaluate the test files?

Also, dope repo!

Thanks!! :-D

but, but why does anything need to know about parcel / webpack / etc?

This is eventually what we want but I think we might have to write our own runner like Karma. We use Karma because it runs the app in an iframe (isolated) and handles launching browsers for us. So it has to know about the build tool because that's how Karma works. It handles bundling all the test files for you

@Robdel12 are there any apps that have everything bigtestjs already setup that I can look up in the mean time? want to see if I can just figure it out based on something that's already working.

Yea no problem! One of our client apps is 100% open source and uses BigTest: https://github.com/folio-org/ui-eholdings/tree/master/tests but that might be harder to follow since Stripes-CLI abstracts the karma/webpack config out.
Here's an example I did with spectacle: https://github.com/Robdel12/spectacle-boilerplate/commit/66e14b0197625e7d82109c53aa221d468dcc4daa
You'll want to ignore some parts that @bigtest/react takes care of for us now. Basically ignore  tests/utils/helpers.js in that commit

so, I aalllmost have karma working with typescript  and a test-only webpack config. :-
not sure where this is coming from though:     "str": "You need to include some adapter that implements karma.start method!"

Hey @NullVoxPopuli just want to let you know we're taking a look at the repo you've linked. I think there's some funky things going on with Karma & typescript. We haven't ever used typescript so this is going to be a little bit of a learning experience.

it's all good. I think, using the master branch, webpack can handle everything, rather than karma-typescript.
I have teh configuration mostly working :tm: , but I just don't have a karma.start method

I got things working. I have a test-only webpack file that I'm running everything though.

Hm, I'm wondering what could be an actionable takeaway from this? The obvious is we need to step up our docs / guide game.

I think the issue was that karma-typescript doesn't work, and that using webpack for typescript transpiling is the way to go.


Rationalize notification context patterns

The original batch of social auth middleware (Facebook, Twitter, etc.) all used notification contexts derived from BaseContext. The second round (WsFed, ODIC) tried to provide more direct shared context objects (AuthenticationFailedNotification). These should be rationalized.

Don't think we'll have time to finish the full rationalization/cleanup, pinpoints PR needs to go in first which should happen this week.  Bumping to beta7

Will be covered by https://github.com/aspnet/Security/issues/47.


Opening sheet triggers twice

Please provide the environment you discovered this bug in.
Clean install of the repo.
Which area/package is the issue in?
sheet
Description
Hey,
I was tinkering with the sheet component and saw something interesting. When you click on the sheet component in Storybook and then click on the "Edit Profile" button. Opening the sheet actually triggers twice.
This is because in the BrnSheetTriggerDirective, we listen to the click on the host and execute the open method, which triggers opening the sheet once.
But the BrnSheetTriggerDirective is also extending the BrnDialogTriggerDirective which listens for a click as well and executes the open method.
I think we can remove the line '(click)': 'open()', from the BrnSheetTriggerDirective, since it's already defined within the BrnDialogTriggerDirective. Maybe we could remove the other duplications as well or am I missing something?
I can create a PR if you guys agree :)
Please provide the exception or error you saw
Log the `open` method in `BrnSheetTriggerDirective` and see it triggering twice.

Other information
No response
I would be willing to submit a PR to fix this issue

[X] Yes
[ ] No

That's correct! Great catch! Here is some more info: https://github.com/angular/angular/issues/33632
@jstnjs do you want me to fix this or do you want to open a PR and claim your spot as part of the 300? 😄
Let me know and I'll assign you the issue!

I'll claim my spot 😎 Created PR #108.


ARTEMIS-786 Store user's password in hash form by default

passwords stored using PBKDF2 algothrim
implements cli user command to help create and manage user/roles

looks nice...
Let me run the whole testsuite before merging though.. I want also to run the examples. Have you done it?
I'm a bit concerned with the examples as this will touch configurations.

@jbertram I will let you handle it then...
please run the whole testsuite, including examples?

There are other places in the configuration where passwords can be masked (e.g. using org.apache.activemq.artemis.utils.PasswordMaskingUtil).  It would be ideal to have a unified approach to all password masking/hashing if possible.  Otherwise we will need to support multiple commands for masking/hashing.  For what it's worth, 5.x uses an encryption/decryption scheme using Jasypt which is pretty simple and effective.

Good point. I was aware of this but didn't think it clearly. We can introduce Jasypt to replace current encrypt/decript util for 2 ways, but I'm not sure this 2-way is suitable for this, which is the only place where hashing seems the preferred way (other places for password need a 2-way algorithm because the broker needs to decrypt them at runtime). I'll talk to you before I do any changes.

@jbertram I move the hash factory api into the same PasswordMaskingUtil to reduce confusion, so that both 2-way encryption and one-way hashing APIs are in the same util class. But I'm not sure what's the benefit of bring in Jasypt. The PasswordMaskingUtil provides a general API which enables user to use customized password encoder/decoder like Jasypt, if he really want it. What do you think?

hmm, sth wrong with Jenkins I think. My local run is ok.

The whole masking/hashing process still seems like a bit of a jumble to me.  To mask a password there's a raw Java command (e.g. "java -cp <classPath> org.apache.activemq.artemis.utils.DefaultSensitiveStringCodec <password-to-encode>") and then there's a new command you've added to hash a password.  I think it would provide a much better user experience to unify both, if possible.

ok, let me think about it. Thanks.

@jbertram So I did some refactoring:

Now DefaultSensitiveStringCodec supports 2 kinds of masking
one-way hashing and two-way encoding/decoding
one-way hashing is used by cli and PropertiesLoginModule, it also has
a verify method to help checking passwords
two-way is used by other password masking in artemis. (existing feature)
Other utils like HashProcessor doesn't do hashing or encoding.
They are used to facilitate password management (either plaintext or
hashed).
Cli commands is used for user management and manual changing is not needed
(although user can use raw DefaultSensitiveStringCodec to to it).

Is there a command to generate an encoded password so that you can put that into your configuration?  I didn't see anything related to that.

There is a command AddUser which takes a user name and password and put them in the config (you can choose plaintext or hash to store the password).

Right, but isn't that the one-way hash that goes into a properties file for the PropertiesLoginModule?

I'm talking about a command to encode a password to put into the broker.xml (e.g. for clusterpassword).

yes, the old "java -cp  org.apache.activemq.artemis.utils.DefaultSensitiveStringCodec " still works as before.

I think having a command in the CLI to do that would be ideal, similar to what we have for one-way hashing.

good idea. If you mean just doing the masking that could be done easily. If you mean also update the broker.xml with the command, I think it'll need some thinking and should be done in a separate JIRA. what do you think?

Just doing the masking and spitting it std-out is fine with me.  Will be simple to cut/paste from there.

ok got it. I'll add a command for that, maybe with options allowing user to do one-way hashing or 2way masking. Thanks.

@jbertram I added the command, pls take a look.

@jbertram is this ready to be merged? I should release this week (I'm a week late already). and this seems a nice feature.


OntoVoc Sprint 04/2020 Report

@bcorrie @franasa Thanks for the fixes. I just realized that I do not have to rebase to to keep the review links up to date... anyhow, its all there.


Fix get best stream

In ffmpeg 5.0, av_find_best_stream does not set decoder if the input to that parameter is a null ptr. This resulted in the wrapper for Stream::best not working in ffmpeg 5.0. This change removes the check that decoder is set, which allows the proper result to be returned.

Hi,
You're right. Thanks for the submission, merging :)


Package list API should use syft packages (python packages)

As an engine user I expect the product to leverage syft capabilities to produce the listing for Python packages.
AC
In order to support the existing UI client implement a translation layer on syft for the following:

Match the existing packages API call syntax.

Steps to Test

Use the Anchore CLI for known image and compare results to a known image matches.
Look at the anchore_engine/analyzers/modules dir within the anchore container image and ensure the Python analyzer (32_python_packages.py) is not present.
pytest -v standalone/test_package_list runs in the anchore-engine/tests/functional/clients directory reporting Python-related tests that are all passing.

Developer Notes
New tests and fixtures should be added to ensure that before/after changes do not alter the expectations of the system.

The syft cataloger 2.0 work is required to continue further. The existing cataloger uses python-specific utils, where as the golang equivalent will need to piece together the information from multiple file sources --requiring the cataloger 2.0 interface to do so.


hints on port-forward are duplicated

I have a custom mapping for <Plug>(kubectl.kill)
for some reason, on the port-forward float (maybe in other places as well) I see both mappings, original, and my override:

Yeah I can see why, the is_plug_mapped function seems to not be working properly

this is a bit annoying, it's basically a race condition, when we open the plugin the ftplugin will run but the keymaps aren't set until the next ui loop.
If we add a delay it will work but we get a bunch of jumping hints. I really don't want to create a DSL for mapping...do you have any ideas?

This should work now, I think we have minimal jumping (I can't see any at all but maybe on slow machines).
Keypoints:

We have to call is_plug_mapped in a vim.schedule AFTER we have registered the plug function.


New Textobj: chainmember

Textobj requested
Textobject of a chain member in a call line.
Explained better here: https://github.com/D4KU/vim-textobj-chainmember
Inner/Outer Difference
outer:
cursor position │ .....
buffer line     │ first.second.third
selection       │ └ am ┘

Another examples:
     .......
first.second.third
     └ am ─┘

     ........               .
first.second(arg1.var, foo()).third
     └───────── am ─────────┘

Inner (without the dots):
     .......
first.second.third
      └ im ┘

Vimscript plugin already implementing the textobj
https://github.com/D4KU/vim-textobj-chainmember
Checklist

[X] The textobj would be useful to more users than just me.
[X] There is no lua plugin already implementing the textobj in an adequate manner.
[X] I read the docs and there is no such textobj already.

Thanks for the nice explanation how the text object is supposed to work!

Hmm, this plugin implements most text objects by a form of pattern matching. Especially with the potential for nexted fields, I think this might be tricky to implement via pattern matching. 🤔
I'm gonna have to think about it, but I think it might make more sense to implement this as a [treesitter-based textobj](treesitter-based textobj)

Okay, I hoped I could get rid of another VimL plugin.
Btw thanks for the plugin, I didn't know I need those textobjects :)

actually, I learned that lua patterns have the quite handy pattern token %bxy, which actually make it super easy to handle nested calls. So I went ahead and added chainMember as a new textobj.
Do note though that since lua patterns do not know logical ors |, the chainMember textobj has to include a call, chain member without call are not recognized. (Though chainmembers without call can probably be handled as a. and i. via other plugins already.)

Awesome! thanks for your great work, very appreciated


Profile reference corruption in 4.9.0

Version of Archi
4.9.0
Archi Plug-ins
Yes - jArchi, Lightbox, Excel,
installed but not used - coArchi
Operating System
Windows
Expected Behaviour
Attempt to save a model after normal editing
Actual Behaviour

Twice now, the model has become corrupted and won't save.
Profile reference is orphaned: id-xxxxxxxx ....
Profile has wrong concept type: id-xxxxxxxx ....

..... repeats several times for different id refs. (see image)
Steps to Reproduce the Behaviour
Has happened twice now but not clear what's causing it.
I am though creating a model by copy-pasting from previous models and using the new stereotype feature to denote the source.

Cannot investigate the source file further because of the binary format :-(
Any chance it can it be salvaged?

Hi Steven,

Cannot investigate the source file further because of the binary format :-(

As soon as the model contains some images, the .archimate file becomes a zip, so simply rename it to something.zip, unzip it and you'll then be able to tweak the model.xml file (that's a file using the native Archi file format), then zip all again to open it in Archi.
But do you see any objection in sharing the file with me (I guess you have my email from a meeting we both joined recently) so that I have a chance to understand what happened ?

This problem can  occur if you imported another model containing Profile/Specialization information into another model. Model Import for Profile/Specialization is not working in this alpha version.

Any chance it can it be salvaged?

As I tried to make clear on the download page:
"Please ensure you back up your data first before testing this version, and please use test data only."

Thanks for the tip - I'll try it.
I'll send you the model by DM.

Though Phil's feedback is most likely what happened.

Though Phil's feedback is most likely what happened.

But thanks for testing and feeding back to us! Appreciated.

Model Import for Profile/Specialization is not working in this alpha version.

I forgot that I use a more recent version. You're right, the published alpha doesn't support model import.

 I'm working on a new beta build which will have an initial version of model import that supports this. If it's a different bug, we can re-open this.


Remove dependency of //cmd/server/cmd on //adapters

Fixes issue #1343
Why fix this for 0.2
Without this Adapter developers will have a hard time testing their code. We created a e2e testing library and we want adapter devs to use it to make their lives easier.
Risk
Change is purely at compile time, so 99% no risk.
Release note:

release-note-none

This change is

@guptasu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/mixer-presubmit.sh
c35dd59ad48e74630e36922c9375194fb72eed87
link
/test mixer-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm,
A simpler approach is just to move integration test  to myadapter/test subfolder to make a test package instead of having integration test in the same package of adapter.

Friendly ping @douglas-reid @ZackButcher @mandarjog @geeknoid

Ping!!

/lgtm

/lgtm

@geeknoid can you re lgtm. I think we should get this in now, since 0.2 out.

/lgtm


Microsoft CLI 2.0 for Azure?

When we install the Azure CLI via MSI, the product is called "Microsoft CLI 2.0 for Azure". The product name should be updated.

I tend to agree. @yugangw-msft do you?

I would advocate "Microsoft Azure CLI 2.0"

@tjprescott As of the end of June 2018, explicit version numbers have been removed from Azure CLI product names. More details at https://docs.microsoft.com/en-us/cli/azure/cli-versioning-identifiers?view=azure-cli-latest
Name can be "Microsoft Azure CLI".


Add zip_hi/zip_lo for shuffling operations

Add zip_hi/zip_lo for shuffling operations mentioned in issues#412.
test_xsimd is passed Arm64 & x86:
Instruction set: ARMv8 64bit Neon
[==========] Running 369 tests from 85 test suites.
[----------] Global test environment set-up.
[----------] 3 tests from algorithms
[ RUN      ] algorithms.binary_transform
[       OK ] algorithms.binary_transform (0 ms)
[ RUN      ] algorithms.unary_transform
......
....
..
snip
...
[----------] 2 tests from trigonometric_test/arm_double, where TypeParam = xsimd::batch<double, 2ul>
[ RUN      ] trigonometric_test/arm_double.trigonometric
[       OK ] trigonometric_test/arm_double.trigonometric (3 ms)
[ RUN      ] trigonometric_test/arm_double.reciprocal
[       OK ] trigonometric_test/arm_double.reciprocal (2 ms)
[----------] 2 tests from trigonometric_test/arm_double (6 ms total)

[----------] Global test environment tear-down
[==========] 369 tests from 85 test suites ran. (237 ms total)
[  PASSED  ] 369 tests.

Build failed in clan:
2021-03-18T10:45:02.5270618Z /home/vsts/work/1/s/include/xsimd/types/xsimd_neon_float.hpp:644:24: error: use of undeclared identifier 'vzip1q_f32'; did you mean 'vzipq_f32'?
vzip1q_f32 is defined in Arm64 GCC.

According to this, it is available on 64 bits arhcitecture only.

It's tricky that Arm32/v7 do not support data type: double(F64) like vreinterpretq_s64_f64.
So users should not be allowed to call zip_lo/hi with data type: F64 on Arm32/v7.

@JohanMabille
Added fallback implementation for Arm32/v7 @3rd commit.

Sorry for the late comment, the failure is unrelated to your change and will be fixed in #446

@JohanMabille Thanks for the info.
Rebased it.

Thanks! The current implementation looks good to me. I think we miss the implementation for AVX and AVX512, as long as some tests.

Thanks! The current implementation looks good to me. I think we miss the implementation for AVX and AVX512, as long as some tests.

Thanks for the review.
Zip_hi/lo were implemented for 128bit data-width of register:
x86:  SSE
Arm: Neon

For 256 and 512 data-width:
x86: avx/avx512
Arm64: SVE

How about to implement them in another PR?

How about to implement them in another PR?

I'm fine with that, but in that case the tests should be added in the second PR (otherwise they won't build for AVX and AVX512 or you will have to define a new list of batches specific to these functions).
Let's merge ;)


Unable to find include file

Hi,
I created a new workspace with just one PL1 program and INCLUDES folder.
When I moved one include to the folder I'm still getting "Unable to find include file" message (see the picture)

My USER settings.json
{
    "files.associations": {
      "*.COBOL*": "cobol",
      "*.COB*": "cobol",
      "*.COBCOPY*": "cobol",
      "*.COPYBOOK*": "cobol",
      "*.COPY*": "cobol",
      "*.PL1*": "pl1",
      "*.PLI*": "pl1",
      "*.INC*": "pl1",
      "*.INCLUDE*": "pl1",
      "*.JCL*": "jcl"
    },
    "zopeneditor.JAVA_HOME": "C:\\# TOOLS\\java 8",
    "zopeneditor.server.memoryAllocation": 1024
}

My WORKSPACRE settings.json
{
	"folders": [
		{
			"path": "C:\\# WORKSPACES\\Visual Studio\\zopeneditor-ACTIVE"
		}
	],
	"settings": {
		"zopeneditor.propertygroups": [
			{
				"name": "SAM-Copybooks",
				"type": "local",
				"syslib": [
					"COPYBOOK",
					"INCLUDES"
				]
			}
		]
	},
}

Am I missing something here?

@przemekherok Hi,
I can see you have .PLINC extension for your INCLUDE files and as of now we only support .inc extension to be resolved for INCLUDE files.

@przemekherok we are proposing to allow users to specify their own file extensions as outlined in Issue #16. I will resolve this as a duplicate to that item for now. Let me know if you have a different solution in mind and provide feedback to Issue #16.

Hi guys,
thanks for quick answer, but after changing the extension it still remain unreachable


memory leak in Executor when inference in cpu !help!

i have try only run
mxnet::cpp::NDArray data = GetDataBatch(src, faces)

it haven`t momery leak,,so i think the problem is not in here.
is my code wrong in use Executor?
thank you!

@ZHEQIUSHUI Can you provide more details like MXNet version, how you've built this package - also it would be helpful if you will post your net definition and input shapes

@bgawrych the mxnet version is v1.7.x lastest.build with mkl(no cuda),input shape is bitchsize3107*108
and you view the other issue that i have report?
issue https://github.com/apache/incubator-mxnet/issues/19430

@ZHEQIUSHUI Can you check with debugger stack trace when memory leak happen? I can't reproduce this issue without network definition. Are you sure that this loop with memcpy is right?

@bgawrych can I get your email address?I can send your the net Json file and my inference code(if your have free time).thank your so much.I can make sure there is not memory leak except this function.thank you so much!

@bgawrych i got the reason...because i use std::cout to log something....i am so sorry....thank you a lot!!!

@bgawrych the reason isn`t cout, i use the same code with v1.5.x,there is not memory leak,but v1.7.x.....

but the v1.5.x doesn`t compile with mkl....

@ZHEQIUSHUI You can create private repository on github with the code and give me an access to it. I will look at this

i have try the same code in cpu with the same version mxnet(v1.7.x),but i have compile two libmxnet([just only cpu] and [with mkl]),i make sure the problem is the mxnet with mkl!!my code have not memory leak!
this is only cpu version mxnet

this is with

mkl

@ZHEQIUSHUI thanks to reporting this issue and it's really important for us.
Could you help provide a reproducer? Maybe a proxy model is fine which will accelerate our debugging progress?

@pengzhao-intel of course.what do you need?

@ZHEQIUSHUI we need minimal part of your model that causes this memory leak, currently we don't even know which operators you're using
And as I said before, if you're still ok with that:

@ZHEQIUSHUI You can create private repository on github with the code and give me an access to it. I will look at this

hey @bgawrych @pengzhao-intel i just create a new  repository and invited you to it,you can come if you need the model json file.

i closed this issue

@ZHEQIUSHUI Would you mind to share also inference code in github repository?


The strings are not localized completely on the context menu of one blob container/Blob Containers node

Storage Explorer Version: 1.35.0-dev (98)
Build Number: 20240701.1
Branch: main
Platform/OS: Windows11/Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.5(Apple M1 Pro)
Architecture: arm64/x64/x64/arm64
Reproduce Languages: All
How Found: From running test cases
Regression From: Previous release (1.34.0)
Bug Description

The strings are not localized completely on the context menu of one blob container/Blob Containers node.
The strings are not localized completely on Actions & Properties panel.

Steps to Reproduce

Launch Storage Explorer -> Open 'Settings' -> 'Application -> Regional Settings'.
Select 'español' -> Restart Storage Explorer.
Expand one storage account.
Right click Blob Containers node -> Observe the context menu.
Check whether all strings are localized.

Expected Experience
All strings are localized.

Actual Experience
The strings are not localized completely.

Additional Context

This issue also reproduces on the context menu of one blob container.

This issue also reproduces on Action & Properties panel.

@v-xianya it's been a few week since this was opened, and I think most strings should be translated by now. I'm going to close this for now that if there's any strings left, they'll continue to be translated as time goes on.

Verified this issue on the build 20240725.1. Fixed.


openthread/ot_rcp build failing (IDFGH-13232)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.4-dev-1388-g5ca9f2a49a
Espressif SoC revision.
v2.8
Operating System used.
Linux
How did you build your project?
Command line with idf.py
If you are using Windows, please specify command line type.
None
Development Kit.
ESP-IDF
Power Supply used.
USB
What is the expected behavior?
build ok
What is the actual behavior?
Fails with logs captured below
Steps to reproduce.
cd examples/openthread/ot_rcp
idf.py set-target esp32h2
idf.py build
Debug Logs.
FAILED: esp-idf/mbedtls/mbedtls/3rdparty/p256-m/CMakeFiles/p256m.dir/p256-m/p256-m.c.obj
/home/user/.espressif/tools/riscv32-esp-elf/esp-13.2.0_20240530/riscv32-esp-elf/bin/riscv32-esp-elf-gcc -DESP_PLATFORM -DIDF_VER=\"v5.4-dev-1388-g5ca9f2a49a-dirty\" -DMBEDTLS_CONFIG_FILE=\"mbedtls/esp_config.h\" -DSOC_MMU_PAGE_SIZE=CONFIG_MMU_PAGE_SIZE -DSOC_XTAL_FREQ_MHZ=CONFIG_XTAL_FREQ -D_GLIBCXX_HAVE_POSIX_SEMAPHORE -D_GLIBCXX_USE_POSIX_SEMAPHORE -D_GNU_SOURCE -D_POSIX_READER_WRITER_LOCKS -I/home/user/esp-idf/examples/openthread/ot_rcp/build/config -I/home/user/esp-idf/components/mbedtls/port/include -I/home/user/esp-idf/components/mbedtls/mbedtls/3rdparty/p256-m -I/home/user/esp-idf/components/mbedtls/mbedtls/3rdparty/p256-m/p256-m -I/home/user/esp-idf/components/mbedtls/mbedtls/include -I/home/user/esp-idf/components/mbedtls/mbedtls/library -I/home/user/esp-idf/components/newlib/platform_include -I/home/user/esp-idf/components/freertos/config/include -I/home/user/esp-idf/components/freertos/config/include/freertos -I/home/user/esp-idf/components/freertos/config/riscv/include -I/home/user/esp-idf/components/freertos/FreeRTOS-Kernel/include -I/home/user/esp-idf/components/freertos/FreeRTOS-Kernel/portable/riscv/include -I/home/user/esp-idf/components/freertos/FreeRTOS-Kernel/portable/riscv/include/freertos -I/home/user/esp-idf/components/freertos/esp_additions/include -I/home/user/esp-idf/components/esp_hw_support/include -I/home/user/esp-idf/components/esp_hw_support/include/soc -I/home/user/esp-idf/components/esp_hw_support/include/soc/esp32h2 -I/home/user/esp-idf/components/esp_hw_support/dma/include -I/home/user/esp-idf/components/esp_hw_support/ldo/include -I/home/user/esp-idf/components/esp_hw_support/port/esp32h2/. -I/home/user/esp-idf/components/esp_hw_support/port/esp32h2/include -I/home/user/esp-idf/components/esp_hw_support/port/esp32h2/private_include -I/home/user/esp-idf/components/heap/include -I/home/user/esp-idf/components/log/include -I/home/user/esp-idf/components/soc/include -I/home/user/esp-idf/components/soc/esp32h2 -I/home/user/esp-idf/components/soc/esp32h2/include -I/home/user/esp-idf/components/hal/platform_port/include -I/home/user/esp-idf/components/hal/esp32h2/include -I/home/user/esp-idf/components/hal/include -I/home/user/esp-idf/components/esp_rom/include -I/home/user/esp-idf/components/esp_rom/esp32h2/include -I/home/user/esp-idf/components/esp_rom/esp32h2/include/esp32h2 -I/home/user/esp-idf/components/esp_rom/esp32h2 -I/home/user/esp-idf/components/esp_common/include -I/home/user/esp-idf/components/esp_system/include -I/home/user/esp-idf/components/esp_system/port/soc -I/home/user/esp-idf/components/esp_system/port/include/riscv -I/home/user/esp-idf/components/esp_system/port/include/private -I/home/user/esp-idf/components/riscv/include -I/home/user/esp-idf/components/lwip/include -I/home/user/esp-idf/components/lwip/include/apps -I/home/user/esp-idf/components/lwip/include/apps/sntp -I/home/user/esp-idf/components/lwip/lwip/src/include -I/home/user/esp-idf/components/lwip/port/include -I/home/user/esp-idf/components/lwip/port/freertos/include -I/home/user/esp-idf/components/lwip/port/esp32xx/include -I/home/user/esp-idf/components/lwip/port/esp32xx/include/arch -I/home/user/esp-idf/components/lwip/port/esp32xx/include/sys -march=rv32imac_zicsr_zifencei  -Wall -Wextra -Wwrite-strings -Wformat=2 -Wno-format-nonliteral -Wvla -Wlogical-op -Wshadow -Wformat-signedness -Wformat-overflow=2 -Wformat-truncation -Werror -ffunction-sections -fdata-sections -Wall -Werror=all -Wno-error=unused-function -Wno-error=unused-variable -Wno-error=unused-but-set-variable -Wno-error=deprecated-declarations -Wextra -Wno-error=extra -Wno-unused-parameter -Wno-sign-compare -Wno-enum-conversion -gdwarf-4 -ggdb -nostartfiles -Os -freorder-blocks -msave-restore -fmacro-prefix-map=/home/user/esp-idf/examples/openthread/ot_rcp=. -fmacro-prefix-map=/home/user/esp-idf=/IDF -fstrict-volatile-bitfields -fno-jump-tables -fno-tree-switch-conversion -std=gnu17 -Wno-old-style-declaration -MD -MT esp-idf/mbedtls/mbedtls/3rdparty/p256-m/CMakeFiles/p256m.dir/p256-m/p256-m.c.obj -MF esp-idf/mbedtls/mbedtls/3rdparty/p256-m/CMakeFiles/p256m.dir/p256-m/p256-m.c.obj.d -o esp-idf/mbedtls/mbedtls/3rdparty/p256-m/CMakeFiles/p256m.dir/p256-m/p256-m.c.obj -c /home/user/esp-idf/components/mbedtls/mbedtls/3rdparty/p256-m/p256-m/p256-m.c
In file included from /home/user/esp-idf/components/mbedtls/mbedtls/include/psa/crypto_builtin_composites.h:28,
                 from /home/user/esp-idf/components/mbedtls/mbedtls/include/psa/crypto_driver_contexts_composites.h:28,
                 from /home/user/esp-idf/components/mbedtls/mbedtls/include/psa/crypto_struct.h:109,
                 from /home/user/esp-idf/components/mbedtls/mbedtls/include/psa/crypto.h:4678,
                 from /home/user/esp-idf/components/mbedtls/mbedtls/3rdparty/p256-m/p256-m/p256-m.c:11:
/home/user/esp-idf/components/mbedtls/port/include/mbedtls/gcm.h:25:28: error: unknown type name 'mbedtls_gcm_context_soft'; did you mean 'mbedtls_gcm_context'?
   25 | void mbedtls_gcm_init_soft(mbedtls_gcm_context_soft *ctx);
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~
      |                            mbedtls_gcm_context
/home/user/esp-idf/components/mbedtls/port/include/mbedtls/gcm.h:28:29: error: unknown type name 'mbedtls_gcm_context_soft'; did you mean 'mbedtls_gcm_context'?
   28 | int mbedtls_gcm_setkey_soft(mbedtls_gcm_context_soft *ctx,
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~
      |                             mbedtls_gcm_context
/home/user/esp-idf/components/mbedtls/port/include/mbedtls/gcm.h:33:29: error: unknown type name 'mbedtls_gcm_context_soft'; did you mean 'mbedtls_gcm_context'?
   33 | int mbedtls_gcm_starts_soft(mbedtls_gcm_context_soft *ctx,
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~
      |                             mbedtls_gcm_context
/home/user/esp-idf/components/mbedtls/port/include/mbedtls/gcm.h:37:32: error: unknown type name 'mbedtls_gcm_context_soft'; did you mean 'mbedtls_gcm_context'?
   37 | int mbedtls_gcm_update_ad_soft(mbedtls_gcm_context_soft *ctx,
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~
      |                                mbedtls_gcm_context
/home/user/esp-idf/components/mbedtls/port/include/mbedtls/gcm.h:40:29: error: unknown type name 'mbedtls_gcm_context_soft'; did you mean 'mbedtls_gcm_context'?
   40 | int mbedtls_gcm_update_soft(mbedtls_gcm_context_soft *ctx,
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~
      |                             mbedtls_gcm_context
/home/user/esp-idf/components/mbedtls/port/include/mbedtls/gcm.h:45:29: error: unknown type name 'mbedtls_gcm_context_soft'; did you mean 'mbedtls_gcm_context'?
   45 | int mbedtls_gcm_finish_soft(mbedtls_gcm_context_soft *ctx,
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~
      |                             mbedtls_gcm_context
/home/user/esp-idf/components/mbedtls/port/include/mbedtls/gcm.h:51:36: error: unknown type name 'mbedtls_gcm_context_soft'; did you mean 'mbedtls_gcm_context'?
   51 | int mbedtls_gcm_crypt_and_tag_soft(mbedtls_gcm_context_soft *ctx,
      |                                    ^~~~~~~~~~~~~~~~~~~~~~~~
      |                                    mbedtls_gcm_context
/home/user/esp-idf/components/mbedtls/port/include/mbedtls/gcm.h:64:35: error: unknown type name 'mbedtls_gcm_context_soft'; did you mean 'mbedtls_gcm_context'?
   64 | int mbedtls_gcm_auth_decrypt_soft(mbedtls_gcm_context_soft *ctx,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~
      |                                   mbedtls_gcm_context
/home/user/esp-idf/components/mbedtls/port/include/mbedtls/gcm.h:75:28: error: unknown type name 'mbedtls_gcm_context_soft'; did you mean 'mbedtls_gcm_context'?
   75 | void mbedtls_gcm_free_soft(mbedtls_gcm_context_soft *ctx);
      |                            ^~~~~~~~~~~~~~~~~~~~~~~~
      |                            mbedtls_gcm_context
[19/1067] Building C object esp-idf/mbedtls/mbedtls/library/CMakeFiles/mbedcrypto.dir/bignum.c.obj
ninja: build stopped: subcommand failed.
ninja failed with exit code 1, output of the command is in the /home/user/esp-idf/examples/openthread/ot_rcp/build/log/idf_py_stderr_output_43933 and /home/user/esp-idf/examples/openthread/ot_rcp/build/log/idf_py_stdout_output_43933

More Information.
No response

Did you update the submodule? And could you please delete the sdkconfig and try anagin?
cd examples/openthread/ot_rcp
git submodule update --init --recursive
rm sdkconfig
idf.py set-target esp32h2
idf.py build

@zwx1995esp Thanks for your reply. I have done as you mentioned.
The main problem that I am facing is, on trying to access the serial terminal of the RCP ESP32-H2 for writing, I get the following issue :
Writing to serial is timing out. Please make sure that your application supports an interactive console and that you have picked the correct console for serial communication.
I believe that I must access the serial terminal here to configure the border router as mentioned here ? :
https://docs.espressif.com/projects/esp-thread-br/en/latest/dev-guide/build_and_run.html#build-and-run-the-thread-cli-device
I am struggling to get this working now. I can't commission any devices through the TBR.

The ot_rcp example doesn't provide the console interface, it only with a host SoC over the Spinel protocol.
If you want to use the CLI console, ot_cli is the correct example.

@chshu Thanks. I had just realized this.
Is this ot_cli example actually required to get the Thread network working? I don't fully understand. If we flash the ESP32-S3 chip with the right image, the ESP32-H2 will get set up and configured automatically according to the documentation.
This is the issue that I am having here :
https://github.com/espressif/esp-thread-br/issues/81

ot_cli example is not mandatory to get the Thread network working, as long as the Thread BR is up and running, ot_cli is only used to test the Thread network features.
Looks like you have got the Thread BR working, but encountered some issue with Matter commissioning. Please close this issue if you don't have any question on rcp build, let's continue with https://github.com/espressif/esp-thread-br/issues/81


[iOS][Sample App Update] Append AdaptiveCards

Platform

iOS

Problem
AdaptiveCards are used frequently in chatting apps.
Salient feature of chatting app is scrolling.
Current sample app only show single AdaptiveCards.
Issues or features related to scrolling can't be tested.
Proposed Solution
Add option to append AdaptiveCards, so scrolling functions can be tested.
Additional context
This is possibly precursor to #3703

https://github.com/microsoft/AdaptiveCards/issues/3703


Listing Block: sort by effective date, reverse sort order has no effect

login as admin
create a page with a listing block and two pages with effective date set
listing block config: sort by effective date, reverse sort order
-> reverse sort order has no effect on listing block results

This was resolved by disabling the sort option when there are no criteria (then the results come from contained items rather than the @querystring-search endpoint).


[MVVM Structure] Part 2 - Update gradle build config + repackage all modules

https://trello.com/c/AOepchkv
What happened 🤔

Update gradle build config
Update env config, separate them into 3 env: development, staging, production
Repackage all current modules

Rebased 👨🎤  🎸

can we separate this PR into 4 pieces? 😭  they are:

Update dependencies lib version
Add UseCase structure
Add common-rx module
Add domain module

@sleepylee we already separate them into commits. Let me separate them into small PRs for tracking easily 🙏

Rebased 🚀

Note to self: Rebase and update package name in fastlane

Rebased and updated Appfile package name 🚀

@Tuubz I'm able to run app on all 3 variants 😅  Can you please show the error that you are getting?

@manh-t @Tuubz @hoangnguyen92dn @lydiasama please finalize your review here in your spare time 🍡


1962 document k3s args

Fixes https://github.com/kairos-io/kairos/issues/1962

I use this config:
#cloud-config

k3s:
  enabled: true

fail_on_bundles_errors: true

users:
  - name: kairos
    passwd: kairos

bundles:
- targets:
  - run://jimmykarily/mybundle:latest

mybundle:
  foo: bar

My bundle has a run.sh script like this one:
#!/bin/bash

echo $(kairos-agent config get mybundle) > /home/kairos/bundle-log

After installation and after booting to the installed system, the /home/kairos/bundle-log file exists and has the foo: bar content.
Conclusion 1: This type of bundle definition in the config, makes the bundle run.sh script run on first boot
Removing the /home/kairos/bundle-log file and rebooting doesn't make the file appear again.
Conclusion 2: It on runs on the first boot (as seen in the code) and not on the subsequent boots.
TODO:

what happens if k3s is not enabled?
what happens if the images doesn't have k3s at all? (core image)
try with this type of config to see when it triggers:

#cloud-config
install:
bundles:

targets:

run://

Maybe also answer to this question while at it: https://github.com/kairos-io/kairos/discussions/2016

TODO: Document the use of fail_on_bundles_errors: true


Update for ACT <IP_ADDRESS>1

Update log:

add TreeView translations of IO Import/Export tab (IoTreeView.xml for details)
update new entries in FormActMain

I can not help any of Japanese translations cuz I don't speak Japanese, all new entries are in the en-US folder.
As for the AssemblyInfo.cs, you can do change you like ^ ^


refactor(budget): refactor to script setup & remove budgetUpdatePage

To Reviewers

[ ] Skip (style, chore, ci ONLY)
[x] Not that difficult

Type of Change

[ ] New feature
[ ] Bug fixes
[ ] Feature improvement
[x] Refactor
[ ] Others (performance improvement, CI/CD, etc.)

Affects to

[ ] Packages

[ ] core-lib
[ ] mirinae
[ ] etc

[ ] Apps

[ ] storybook
[x] web

Checklist

Did you check the lint and type?
Did you document the changes?

Changes in mirinae should be reflected in storybook.

Did you test the app after the package changes?

Description
I have swapped the script and template of the components that will be refactored in the future.
Things to Talk About

Some files are not refactored to script setup. If you need help, please tell me~


flyctl: 0.1.104 -> 0.1.117

Description of changes
Update tags and build info handling
Replaces PR #263595
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 265437 run on aarch64-darwin 1

1 package built:

flyctl


Add the ability to specify an API version

This is related to https://github.com/wordnik/swagger-core/issues/712.
I have also created some documentation: https://github.com/wordnik/swagger-core/wiki/API-Filtering
This feature allows me to maintain several versions of an API in the same code base. The path name is then used as a filter ("v1", "v2", etc.). The default API can then be used to point to one of the APIs as well as configure in the routes file.
This has only been developed in Scala Play. It should work in Java, but has not been tested there.

@fehguy can you roughly estimate when this pull request or a similar feature will be available for versioning apis?

Hi @ShokuninSan I will review for the 1.3.13 to see if it can be included.

@fehguy awesome! thank you very much!

This should be submitted against the develop-scale_2.10 branch. Can't promise it'll be merged as we not concentrate on critical issues for the 1.3.X releases and concentrate on adding features to the 1.5.X tree.