error configmap  "aws-auth" does not exist and  creating IAM Policy ekstest-additional: ConcurrentModification: Found Tagris has different internal

Description
se esta implementando un eks con nodos administrados pero s iempre falla
por favor revisar o dar una solucion
adjunto codigo y el error que sale
Steps to reproduce the behavior:
provider "kubernetes" {
  host                   = module.eks.cluster_endpoint
  cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)
  token                  = data.aws_eks_cluster_auth.default.token

  exec {
    api_version = "client.authentication.k8s.io/v1beta1"
    command     = "aws"
    # This requires the awscli to be installed locally where Terraform is executed
    args = ["eks", "get-token", "--cluster-name", module.eks.cluster_name]
  }
}

data "aws_caller_identity" "current" {}
data "aws_availability_zones" "available" {}

locals {
  name            = "ekstest"
  cluster_version = "1.25"
  region          = "eu-west-2"

  tags = {
    Cluster   = local.name
    Project = "culqi"
    PCI= "false"
  }
}

resource "aws_eks_addon" "coredns" {
  cluster_name      = module.eks.cluster_id
  addon_name        = "coredns"
  resolve_conflicts = "OVERWRITE"
  depends_on = [
    module.eks
  ]
}

################################################################################
# EKS Module
################################################################################

module "eks" {
  source = "../../module/eks"

  cluster_name                   = local.name
  cluster_version                = local.cluster_version
  cluster_enabled_log_types= [
    "api",
    "audit",
    "authenticator",
    "controllerManager",
    "scheduler"
  ]
  cluster_endpoint_public_access = true #double ccheck

  # IPV6
  cluster_ip_family = "ipv6"
  create_cni_ipv6_iam_policy = true

  vpc_id                   = data.aws_vpc.vpc_name-application.id
  subnet_ids               = ["${data.aws_subnet.subnets01.id}", "${data.aws_subnet.subnets02.id}", "${data.aws_subnet.subnets03.id}"]
  #control_plane_subnet_ids = module.vpc.intra_subnets

  eks_managed_node_group_defaults = {
    ami_type       = "AL2_x86_64"
    instance_types = ["m5.xlarge"]

    attach_cluster_primary_security_group = true

    iam_role_attach_cni_policy = true
  }
  cluster_addons = {

      kube-proxy = {
        most_recent = true
      }
      vpc-cni = {
        most_recent              = true
        before_compute           = true
        service_account_role_arn = module.vpc_cni_irsa.iam_role_arn
        configuration_values = jsonencode({
          env = {
            # Reference docs https://docs.aws.amazon.com/eks/latest/userguide/cni-increase-ip-addresses.html
            ENABLE_PREFIX_DELEGATION = "true"
            WARM_PREFIX_TARGET       = "1"
          }
        })
      }
    }

  manage_aws_auth_configmap = true
  eks_managed_node_groups = {

    complete = {
      name            = "default_node"
      use_name_prefix = true

      subnet_ids = ["${data.aws_subnet.subnets01.id}", "${data.aws_subnet.subnets02.id}", "${data.aws_subnet.subnets03.id}"]
      use_custom_launch_template = false

      min_size     = 2
      max_size     = 10
      desired_size = 4

      capacity_type        = "SPOT"
      force_update_version = true
      instance_types       = ["m5.xlarge"]
      disk_size = 180
      labels = local.tags

      ami_id                     = data.aws_ami.eks_default.image_id
      enable_bootstrap_user_data = true

      pre_bootstrap_user_data = <<-EOT
        export FOO=bar
      EOT

      post_bootstrap_user_data = <<-EOT
        echo "you are free little kubelet!"
      EOT

      taints = [
        {
          key    = "dedicated"
          value  = "gpuGroup"
          effect = "NO_SCHEDULE"
        }
      ]

      update_config = {
        max_unavailable_percentage = 33 # or set `max_unavailable`
      }

      description = "EKS managed node group  launch template"

      ebs_optimized           = true
      disable_api_termination = false
      enable_monitoring       = true

      block_device_mappings = {
        xvda = {
          device_name = "/dev/xvda"
          ebs = {
            volume_size           = 180
            volume_type           = "gp3"
            iops                  = 3000
            throughput            = 150
            encrypted             = true
            kms_key_id            = module.ebs_kms_key.key_arn
            delete_on_termination = true
          }
        }
      }

      # Remote access cannot be specified with a launch template
      remote_access = {
        ec2_ssh_key               = module.key_pair.key_pair_name
        source_security_group_ids = [aws_security_group.remote_access.id]
      }

      metadata_options = {
        http_endpoint               = "enabled"
        http_tokens                 = "required"
        http_put_response_hop_limit = 2
        instance_metadata_tags      = "disabled"
      }

      create_iam_role          = true
      iam_role_name            = "eks-managed-node-group-complete-example"
      iam_role_use_name_prefix = false
      iam_role_description     = "EKS managed node group complete example role"
      iam_role_tags = {
        Purpose = "Protector of the kubelet"
      }
      iam_role_additional_policies = {
        AmazonEC2ContainerRegistryReadOnly = "arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryReadOnly"
        additional                         = aws_iam_policy.node_additional.arn
      }

      tags = {
        ExtraTag = "EKS managed node group"
      }
    }
  }

# Extend cluster security group rules
  cluster_security_group_additional_rules = {
    ingress = {
      description                = "EKS Cluster allows 443 port to get API call"
      type                       = "ingress"
      from_port                  = 443
      to_port                    = 443
      protocol                   = "TCP"
      cidr_blocks                = ["<IP_ADDRESS>/0"]
      source_node_security_group = false
    }
  }
  tags = local.tags
}

################################################################################
# Supporting Resources
################################################################################

module "vpc_cni_irsa" {
  source  = "terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks"
  version = "~> 5.0"

  role_name_prefix      = "VPC-CNI-IRSA"
  attach_vpc_cni_policy = true
  vpc_cni_enable_ipv6   = true

  oidc_providers = {
    main = {
      provider_arn               = module.eks.oidc_provider_arn
      namespace_service_accounts = ["kube-system:aws-node"]
    }
  }

  tags = local.tags
}

module "ebs_kms_key" {
  source  = "terraform-aws-modules/kms/aws"
  version = "~> 1.5"

  description = "Customer managed key to encrypt EKS managed node group volumes"

  # Policy
  key_administrators = [
    data.aws_caller_identity.current.arn
  ]

  key_service_roles_for_autoscaling = [
    # required for the ASG to manage encrypted volumes for nodes
    "arn:aws:iam::${data.aws_caller_identity.current.account_id}:role/aws-service-role/autoscaling.amazonaws.com/AWSServiceRoleForAutoScaling",
    # required for the cluster / persistentvolume-controller to create encrypted PVCs
    module.eks.cluster_iam_role_arn,
  ]

  # Aliases
  aliases = ["eks/${local.name}/ebs"]

  tags = local.tags
}

module "key_pair" {
  source  = "terraform-aws-modules/key-pair/aws"
  version = "~> 2.0"

  key_name_prefix    = local.name
  create_private_key = true

  tags = local.tags
}

resource "aws_security_group" "remote_access" {
  name_prefix = "${local.name}-remote-access"
  description = "Allow remote SSH access"
  vpc_id      = data.aws_vpc.vpc_name-application.id

  ingress {
    description = "SSH access"
    from_port   = 22
    to_port     = 22
    protocol    = "tcp"
    cidr_blocks = ["<IP_ADDRESS>/8"]
  }

   egress {
    from_port        = 0
    to_port          = 0
    protocol         = "-1"
    cidr_blocks      = ["<IP_ADDRESS>/0"]
    ipv6_cidr_blocks = ["::/0"]
  }

  tags = merge(local.tags, { Name = "${local.name}-remote" })
}

resource "aws_iam_policy" "node_additional" {
  name        = "${local.name}-additional"
  description = "node additional policy"

  policy = jsonencode({
    Version = "2012-10-17"
    Statement = [
      {
        Action = [
          "ec2:Describe*",
        ]
        Effect   = "Allow"
        Resource = "*"
      },
    ]
  })

  tags = local.tags
}

data "aws_ami" "eks_default" {
  most_recent = true
  owners      = ["amazon"]

  filter {
    name   = "name"
    values = ["amazon-eks-node-${local.cluster_version}-v*"]
  }
}

data "aws_vpc" "vpc_name-application" {
  filter {
    name   = "tag:Name"
    values = ["${var.vpc_name-application}"]
  }
}

data "aws_subnet" "subnets01" {
   filter {
     name   = "tag:Name"
     values = ["vpc-application-private-us-west-2b"]
   }
}

data "aws_subnet" "subnets02" {
   filter {
     name   = "tag:Name"
     values = ["vpc-application-private-us-west-2a"]
   }
}

data "aws_subnet" "subnets03" {
   filter {
     name   = "tag:Name"
     values = ["vpc-application-private-us-west-2c"]
   }
}

data "aws_eks_cluster_auth" "default" {
  name = local.name
}

resource "aws_iam_policy" "additional" {
  name        = "${local.name}-additional"
  description = "Example usage of node additional policy"

  policy = jsonencode({
    Version = "2012-10-17"
    Statement = [
      {
        Action = [
          "ec2:Describe*",
        ]
        Effect   = "Allow"
        Resource = "*"
      },
    ]
  })

  tags = local.tags
}

[ ] ✋ I have searched the open/closed issues and my issue is not listed.

Versions

Module version [Required]:
terraform-aws-eks 19.10.1

Terraform version:
Terraform v1.3.9

Reproduction Code [Required]

Expected behavior

Actual behavior

Terminal Output Screenshot(s)

Additional context

Make sure you have something like this in your top level code, alongside your eks module. Than it should work.
data "aws_eks_cluster" "eks" {
  name = module.eks.cluster_name
}

data "aws_eks_cluster_auth" "eks" {
  name = module.eks.cluster_name
}

provider "kubernetes" {
  host                   = data.aws_eks_cluster.eks.endpoint
  cluster_ca_certificate = base64decode(data.aws_eks_cluster.eks.certificate_authority[0].data)
  token                  = data.aws_eks_cluster_auth.eks.token
}

but th

I had the same problem and to work around it, I enabled the create_aws_auth_configmap = true flag, which will return another informing that the aws-auth already exists. After that, I commented out the create_aws_auth_configmap = true flag, leaving only the manage_aws_auth_configmap = true, and it bypasses the error.

yes that's the workaround I am currently using too but need a permanent fix as I can't do this frequently everytime when creating a new one.

Un-stale

Use this provider
provider "kubernetes" {
  host                   = module.eks.cluster_endpoint
  cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)
  exec {
    api_version = "client.authentication.k8s.io/v1beta1"
    command     = "aws"
    args        = ["eks", "get-token", "--cluster-name", module.eks.cluster_name]
  }
}

Use this provider it works
provider "kubernetes" {
  host                   = module.eks.cluster_endpoint
  cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)
  exec {
    api_version = "client.authentication.k8s.io/v1beta1"
    command     = "aws"
    args        = ["eks", "get-token", "--cluster-name", module.eks.cluster_name]
  }
}

Not while you run destroy if you got dependent modules.

Why not?

Just what I observed. It tries to dial the connection after the cluster was deleted. Some helm charts were pending which we had to manually remove from state file.
Maybe we approached it wrong, and should have specified the dependencies better.
However what I observed is it's better to extract that to a local first and pass those on to the provider.

if you want to share your terraform configs I can take a look - it sounds like something else is amiss

@bryantbiggs you may be right about it being something else.
Can't seem to find that configuration though, or be able to replicate it.

Btw for anyone facing issues with the original issue and want to do it in a single pass, assuming you have eksctl available you may try, like below:
resource "null_resource" "eksctl_add_auth_configmap" {
  triggers = {
    cluster_name = module.eks.cluster_name
    region       = var.region
    cluster_endpoint = module.eks.cluster_endpoint
    karpernter_role_arn = module.karpenter.role_arn
  }

  provisioner "local-exec" {
    command = <<EOT
           eksctl create iamidentitymapping \
             --cluster ${self.triggers.cluster_name} \
             --arn ${self.triggers.karpernter_role_arn} \
             --group system:bootstrappers \
             --group system:nodes \
             --username karpenter \
             --region ${self.triggers.region}
        EOT
    on_failure = fail
  }

  provisioner "local-exec" {
    when = destroy
    command = <<EOT
           eksctl delete iamidentitymapping \
             --cluster ${self.triggers.cluster_name} \
             --arn ${self.triggers.karpernter_role_arn} \
             --region ${self.triggers.region}
        EOT
    on_failure = fail
  }

  depends_on = [
    module.karpenter,
    module.eks,
  ]
}

For anyone having eksctl, can try something like below:
resource "null_resource" "eksctl_add_auth_configmap" {
  triggers = {
    cluster_name = module.eks.cluster_name
    region       = var.region
    cluster_endpoint = module.eks.cluster_endpoint
    karpernter_role_arn = module.karpenter.role_arn
  }

  provisioner "local-exec" {
    command = <<EOT
           eksctl create iamidentitymapping \
             --cluster ${self.triggers.cluster_name} \
             --arn ${self.triggers.karpernter_role_arn} \
             --group system:bootstrappers \
             --group system:nodes \
             --username system:node:{{EC2PrivateDNSName}} \
             --region ${self.triggers.region}
        EOT
    on_failure = fail
  }

  provisioner "local-exec" {
    when = destroy
    command = <<EOT
           eksctl delete iamidentitymapping \
             --cluster ${self.triggers.cluster_name} \
             --arn ${self.triggers.karpernter_role_arn} \
             --region ${self.triggers.region}
        EOT
    on_failure = fail
  }

  depends_on = [
    module.karpenter,
    module.eks,
  ]
}

^ This one uses the karpenter module with eks.

I have updated the provider section as mentioned above. But I still get this error:

"msg": "\nError: The configmap \"aws-auth\" does not exist\n\n  with module.eks.kubernetes_config_map_v1_data.aws_auth[0],\n  on .terraform/modules/eks/main.tf line 553, in resource \"kubernetes_config_map_v1_data\" \"aws_auth\":\n 553: resource \"kubernetes_config_map_v1_data\" \"aws_auth\" {",
    "rc": 1,
    "stderr": "\nError: The configmap \"aws-auth\" does not exist\n\n  with module.eks.kubernetes_config_map_v1_data.aws_auth[0],\n  on .terraform/modules/eks/main.tf line 553, in resource \"kubernetes_config_map_v1_data\" \"aws_auth\":\n 553: resource \"kubernetes_config_map_v1_data\" \"aws_auth\" {\n\n",
    "stderr_lines": [
        "",
        "Error: The configmap \"aws-auth\" does not exist",
        "",
        "  with module.eks.kubernetes_config_map_v1_data.aws_auth[0],",
        "  on .terraform/modules/eks/main.tf line 553, in resource \"kubernetes_config_map_v1_data\" \"aws_auth\":",
        " 553: resource \"kubernetes_config_map_v1_data\" \"aws_auth\" {",
        ""

If I also add create_aws_auth_configmap = true , I get this

   "msg": "\nError: Post \"https://xxxxxxxxxxxxx.gr7.eu-west-1.eks.amazonaws.com/api/v1/namespaces/kube-system/configmaps\": dial tcp <IP_ADDRESS>:443: i/o timeout\n\n  with module.eks.kubernetes_config_map.aws_auth[0],\n  on .terraform/modules/eks/main.tf line 536, in resource \"kubernetes_config_map\" \"aws_auth\":\n 536: resource \"kubernetes_config_map\" \"aws_auth\" {",
    "rc": 1,

In my case I had to update my kubernetes provider to the following:
provider "kubernetes" {
  host                   = module.eks.cluster_endpoint
  cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)

  exec {
    api_version = var.kubeconfig_api_version
    command     = "aws"
    // This requires the awscli to be installed locally where Terraform is executed
    args = ["eks", "get-token", "--region", var.region, "--cluster-name", module.eks.cluster_name, "--output", "json"]
  }
}

This is needed because the eks get-token output doesn't default to json since 2.10.4.
https://github.com/aws/aws-cli/issues/7719#issuecomment-1458939693

Make sure you have something like this in your top level code, alongside your eks module. Than it should work.
data "aws_eks_cluster" "eks" {
  name = module.eks.cluster_name
}

data "aws_eks_cluster_auth" "eks" {
  name = module.eks.cluster_name
}

provider "kubernetes" {
  host                   = data.aws_eks_cluster.eks.endpoint
  cluster_ca_certificate = base64decode(data.aws_eks_cluster.eks.certificate_authority[0].data)
  token                  = data.aws_eks_cluster_auth.eks.token
}

This works only if you already have created cluster already and you only need to add or adjust the aws0auth configmap, but it you will use run this from scratch before cluster creation then it throws an error like this:  reading EKS Cluster (dev): couldn't find resource

Make sure you have something like this in your top level code, alongside your eks module. Than it should work.
data "aws_eks_cluster" "eks" {
  name = module.eks.cluster_name
}

data "aws_eks_cluster_auth" "eks" {
  name = module.eks.cluster_name
}

provider "kubernetes" {
  host                   = data.aws_eks_cluster.eks.endpoint
  cluster_ca_certificate = base64decode(data.aws_eks_cluster.eks.certificate_authority[0].data)
  token                  = data.aws_eks_cluster_auth.eks.token
}

It works only if you have created cluster already and you only need to add or adjust the aws-auth configmap, but if you will use this from scratch before cluster creation then it throws an error like this: reading EKS Cluster (dev): couldn't find resource :(

We are facing exactly the same issue. Any updates?

Make sure you have something like this in your top level code, alongside your eks module. Than it should work.
data "aws_eks_cluster" "eks" {
  name = module.eks.cluster_name
}

data "aws_eks_cluster_auth" "eks" {
  name = module.eks.cluster_name
}

provider "kubernetes" {
  host                   = data.aws_eks_cluster.eks.endpoint
  cluster_ca_certificate = base64decode(data.aws_eks_cluster.eks.certificate_authority[0].data)
  token                  = data.aws_eks_cluster_auth.eks.token
}

I was facing the same issue, changed the Kubernetes provider config to use the data sources to retrieve the token instead of the  AWS cli, like I did before and has been mentioned by @BarnumD
However this is really an awkward one, I was able to test the module several times with the approach of using aws cli several times then suddenly started getting the error out of the blue. There must be something about the Kubernetes provider and the exec option that is not working properly and not specifically to this module.  Regardless the flag is set or not , not sure what is the scenario we need the flag to create the config map but the config map is always created by EKS service, that's how he adds the creator of the cluster as admin, otherwise we wouldn't be able to do anything with the cluster afterwards, at least that is my understanding.
I am using the following versions:
aws cli: 2.9.19
Terraform 1.5.4
EKS module: 19.16.0
Kubernetes provider: v2.16.1
AWS provider: v4.67.0
kubectl provider: v1.14.0
I hope this helps

We are also experiencing this issue.

Managed to solve it somehow.

Here is my main.tf file:
terraform {
  cloud {
    organization = "YOUR ORGANIZATION HERE"
    workspaces {
      name = "test"
    }
  }
}

provider "aws" {
  region = var.aws_region
}

module "vpc" {
  source = "terraform-aws-modules/vpc/aws"

  name = "${var.env}-vpc"
  cidr = "${var.vpc_cidr_block}"

  azs             = ["${var.az1}", "${var.az2}", "${var.az3}"]
  private_subnets = ["${var.private_subnet_cidr_blocks[0]}", "${var.private_subnet_cidr_blocks[1]}", "${var.private_subnet_cidr_blocks[2]}"]
  public_subnets  = ["${var.public_subnet_cidr_blocks[0]}", "${var.public_subnet_cidr_blocks[1]}", "${var.public_subnet_cidr_blocks[2]}"]

#  enable_vpn_gateway = true

   enable_nat_gateway = true
   single_nat_gateway = true
   one_nat_gateway_per_az = false

  tags = {
    Terraform = "true"
    Environment = "${var.env}"
  }
}

module "eks" {
  source  = "terraform-aws-modules/eks/aws"
  version = "~> 19.15.3"

  cluster_name    = "${var.env}"
  cluster_version = "1.27"

  cluster_endpoint_public_access  = true

  cluster_addons = {
    coredns = {
      most_recent = true
    }
    kube-proxy = {
      most_recent = true
    }
    vpc-cni = {
      most_recent = true
    }
  }

  vpc_id                   = "${module.vpc.vpc_id}"
  subnet_ids               = ["${element(module.vpc.private_subnets, 0)}", "${element(module.vpc.private_subnets, 1)}", "${element(module.vpc.private_subnets, 2)}"]
  control_plane_subnet_ids = ["${element(module.vpc.public_subnets, 0)}", "${element(module.vpc.public_subnets, 1)}", "${element(module.vpc.public_subnets, 2)}"]

  # Self Managed Node Group(s)
  self_managed_node_group_defaults = {
    instance_type                          = "${var.instance_types[0]}"
    update_launch_template_default_version = true
    iam_role_additional_policies = {
      AmazonSSMManagedInstanceCore = "arn:aws:iam::aws:policy/AmazonSSMManagedInstanceCore"
    }
  }

  self_managed_node_groups = {
    one = {
      name         = "mixed-1"
      max_size     = 5
      desired_size = 2

      use_mixed_instances_policy = true
      mixed_instances_policy = {
        instances_distribution = {
          on_demand_base_capacity                  = 0
          on_demand_percentage_above_base_capacity = 10
          spot_allocation_strategy                 = "capacity-optimized"
        }

        override = [
          {
            instance_type     = "${var.instance_types[1]}"
            weighted_capacity = "1"
          },
          {
            instance_type     = "${var.instance_types[0]}"
            weighted_capacity = "2"
          },
        ]
      }
    }
  }

  # EKS Managed Node Group(s)
  eks_managed_node_group_defaults = {
    instance_types =  ["${var.instance_types[0]}", "${var.instance_types[1]}", "${var.instance_types[2]}"]
  }

  eks_managed_node_groups = {
    blue = {}
    green = {
      min_size     = 1
      max_size     = 10
      desired_size = 1

      instance_types = ["${var.instance_types[0]}"]
      capacity_type  = "SPOT"
    }
  }

  # Fargate Profile(s)
  fargate_profiles = {
    default = {
      name = "default"
      selectors = [
        {
          namespace = "default"
        }
      ]
    }
  }

  # aws-auth configmap
  manage_aws_auth_configmap = true

  aws_auth_roles = [
    {
      rolearn  = "arn:aws:iam::${var.aws_account}:role/${var.aws_role}"
      username = "${var.aws_role}"
      groups   = ["system:masters"]
    },
  ]

  aws_auth_users = [
    {
      userarn  = "arn:aws:iam::${var.aws_account}:user/${var.aws_user}"
      username = "${var.aws_user}"
      groups   = ["system:masters"]
    },
    {
      userarn  = "arn:aws:iam::${var.aws_account}:root"
      username = "root"
      groups   = ["system:masters"]
    }
  ]

  aws_auth_accounts = [
    "${var.aws_account}"
  ]

  tags = {
    Environment = "${var.env}"
    Terraform   = "true"
  }
}

data "aws_eks_cluster" "this" {
  name = module.eks.cluster_name
  depends_on = [
    module.eks.eks_managed_node_groups,
  ]
}

data "aws_eks_cluster_auth" "this" {
  name = module.eks.cluster_name
  depends_on = [
    module.eks.eks_managed_node_groups,
  ]
}

provider "kubernetes" {
  host                   = data.aws_eks_cluster.this.endpoint
  token                  = data.aws_eks_cluster_auth.this.token
  cluster_ca_certificate = base64decode(data.aws_eks_cluster.this.certificate_authority.0.data)
}

So, the last block is really important! Please keep attention on it and add dependency on node group creation.
data "aws_eks_cluster" "this" {
  name = module.eks.cluster_name
  depends_on = [
    module.eks.eks_managed_node_groups,
  ]
}

data "aws_eks_cluster_auth" "this" {
  name = module.eks.cluster_name
  depends_on = [
    module.eks.eks_managed_node_groups,
  ]
}

provider "kubernetes" {
  host                   = data.aws_eks_cluster.this.endpoint
  token                  = data.aws_eks_cluster_auth.this.token
  cluster_ca_certificate = base64decode(data.aws_eks_cluster.this.certificate_authority.0.data)
}

Hope it will save your time and help to solve an issue!

why this:
  vpc_id                   = "${module.vpc.vpc_id}"
  subnet_ids               = ["${element(module.vpc.private_subnets, 0)}", "${element(module.vpc.private_subnets, 1)}", "${element(module.vpc.private_subnets, 2)}"]
  control_plane_subnet_ids = ["${element(module.vpc.public_subnets, 0)}", "${element(module.vpc.public_subnets, 1)}", "${element(module.vpc.public_subnets, 2)}"]

instead of:
  vpc_id                   = module.vpc.vpc_id
  subnet_ids               = module.vpc.private_subnets
  control_plane_subnet_ids = module.vpc.public_subnets

It was just my initiative of replacement for the subnets. In theory it should not affect the plan execution.
So, you can to ignore it and just to add the "data sources to you code.

hello,
@kostyanius thanks so much for sharing, I went on the route to move the aws-auth managed outside of the manage, just tested your approach this morning and it seems to be working for me too.

I didn't have much success with the above methods -- I ended up using the kubectl provider to apply the aws_auth_configmap as a manifest:
locals {
  users = [
    for user in data.aws_iam_group.admins.users :
    {
      userarn  = user.arn
      username = user.user_name
      groups = [
        "system:masters"
      ]
    }
  ]

aws_auth_configmap = {
    apiVersion = "v1"
    kind = "ConfigMap"
    metadata = {
      name = "aws-auth"
      namespace = "kube-system"
    }
    data = {
      mapUsers = yamlencode(local.users)
    }
  }
}

provider "kubectl" {
  host                   = module.eks.cluster_endpoint
  cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)
  token                  = data.aws_eks_cluster_auth.default.token
  load_config_file       = false
}

resource "kubectl_manifest" "aws_auth_configmap" {
  yaml_body = yamlencode(local.aws_auth_configmap)

  force_conflicts = true
}

Theoretically you could use the kubernetes_manifest resource if you don't want to touch the kubectl provider, but unfortunately it requires access to the cluster API during the planning phase which may or may not work for your use case.

aws_eks_cluster_auth

I understand, I went that route to but I since reverted back @kostyanius  work-around.
Have you made both data sources for aws_eks_cluster_auth and aws_eks_cluster_auth dependent of the eks module node groups?
my kubernetes provider config looks like this now:
data "aws_eks_cluster" "cluster" {
 name = module.eks.cluster_name
 depends_on = [
   module.eks.eks_managed_node_groups,
 ]
}

data "aws_eks_cluster_auth" "clusterauth" {
 name = module.eks.cluster_name
 depends_on = [
   module.eks.eks_managed_node_groups,
 ]
}

provider "kubernetes" {
 host                   = data.aws_eks_cluster.cluster.endpoint
 cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)
 token                  = data.aws_eks_cluster_auth.clusterauth.token
}

Have you made both data sources for aws_eks_cluster_auth and aws_eks_cluster_auth dependent of the eks module node groups?

Yeah, gave that a try but unfortunately didn't work.

@benjamin-awd
I have 3 possible solution, but so as i am not forced anymore to reproduce the issue so it is only a theory. You need to try it and tell us whether it solved your issue or not.

Update your aws-cli. I have seen that in some of the cases people claimed on aws-uath error when they had obsolate aws-cli version. I am using aws-cli/2.9.22. What is yours?
Try to update the module on the new version AWS EKS Module on 19.16.0 Published August 4, 2023
true to add something like create_aws_auth_configmap = true

Determines whether to create the aws-auth configmap. NOTE - this is  only intended for scenarios where the configmap does not exist (i.e. -  when using only self-managed node groups). Most users should use manage_aws_auth_configmap
And if all the variants haven`t helped to solve the issue then please hsare your module confugurtion here and order we could try it as well.

None of the provided workarounds fully work for me.
The one provided by @kostyanius works only for the initial deployment.
Later if I want to change some parameters (for example, disk size within node group) for the that cluster I get error
Error: Get "http://localhost/api/v1/namespaces/kube-system/configmaps/aws-auth": dial tcp <IP_ADDRESS>:80: connect: connection refused

My config:
manage_aws_auth_configmap = true
create_aws_auth_configmap = false

@ptimofee
// Note: disk_size, and remote_access can only be set when using the EKS managed node group default launch template
// This module defaults to providing a custom launch template to allow for custom security groups, tag propagation, etc.
// use_custom_launch_template = false
// disk_size = 50
https://registry.terraform.io/modules/terraform-aws-modules/eks/aws/latest/submodules/eks-managed-node-group

@kostyanius I didn't say "disk_size" exactly.
In my case it's volume_size within block_device_mappings in a node group.

finally got it fixed for me
make sure below 3 lines are exactly same
cluster_endpoint_public_access  = true
subnet_ids               = module.vpc.private_subnets
control_plane_subnet_ids = module.vpc.public_subnets
also,
manage_aws_auth_configmap = true
provider.tf
provider "kubernetes" {
host                   = module.eks.cluster_endpoint
cluster_ca_certificate = base64decode(module.eks.cluster_certificate_authority_data)
exec {
api_version = "client.authentication.k8s.io/v1beta1"
command     = "aws"
args        = ["eks", "get-token", "--cluster-name", module.eks.cluster_name, "--profile", "default"]
}
}
also pls check default profile in ~/.aws/credentials and ~/.aws/config is correct

Un-stale

I tried the solutions in this issue and ran into all sorts of different errors. I ended up managing the aws_auth configmap with our own code instead of having the module handle it. It's ~50 lines of extra code, but it's well worth it. My provider looks like so:
provider "kubernetes" {
  host                   = module.this_cluster.cluster_endpoint
  cluster_ca_certificate = base64decode(module.this_cluster.cluster_certificate_authority_data)
  exec {
    api_version = "client.authentication.k8s.io/v1beta1"
    command     = "aws"
    # This requires the awscli to be installed locally where Terraform is executed
    args = ["eks", "get-token", "--cluster-name", module.this_cluster.cluster_name]
  }
}

Pardon my (possible) ignorance, but should it be fairly easy for the code to use the var.aws_auth_roles merge/concat into the aws-auth configmap?
I mean, aws-auth configmap is created even when manage_aws_auth_configmap (and create_aws_auth_configmap) is(are) false, and I'm using an eks managed node group (the managed node group role is added to aws-auth configmap in the groups: system:bootstrappers, system:nodes
Seems like it should read/use the var: aws_auth_roles and merge/concat but doesn't (I tested with v19.20.0).

This issue has been resolved in version 20.0.0 :tada:


[ENH] - Add support for AI21labs assistants

This is a work in progress to address Issue #226 .
Please leave opinions and change requests in comments

@pmeier The first draft of this PR is finished. I'm testing it now.
Opinions and requests to modify are welcome

I'm trying to test this using basic documents and prompts, but I keep getting an error like

_api.py:28: RuntimeWarning: coroutine 'AI21LabsAssistant._call_api' was never awaited
async for chunk in self._call_api(  # type: ignore[attr-defined, misc]

I'm trying to debug this, including adding a `breakpoint()`, but the code has been rather opaque to peer into.

An educated guess is that streaming is not specified. I will test this hypothesis

A later part of the same error gives

File "/home/[...]/ragna/ragna/assistants/_api.py", line 28, in answer
    |     async for chunk in self._call_api(  # type: ignore[attr-defined, misc]
    | TypeError: 'async for' requires an object with __aiter__ method, got coroutine

What's confusing to me is that RagnaException is not getting raised, leading me to believe that the request is (hopefully) coming back successfully.

Almost there just one minor thing below. Apart from that, I'm unable to use the Jurassic2Mid assistant. The server always returns a 500 / Internal Server error for me. Did it work for you? If so, let's wait for them to fix this so I get at least one clean run.

I get the same 500 http response code for Jurassic2Mid, but Jurassic2Ultra works for me.

It's also unclear to me why there's a new import error

I get the same 500 http response code for Jurassic2Mid,

Are you saying you are also getting the 500 now or never got a proper response so far? If its the former, I say we wait a few days before we merge this and see if they figure it out on their side. No worries, this PR will make it into the 0.2.0 release

It's also unclear to me why there's a new import error

Well, lancedb==5.0.2 was released an hour ago and our env in CI is likely still cached and does not contain polars. Nothing to worry about on your side.

Are you saying you are also getting the 500 now or never got a proper response so far? If its the former, I say we wait a few days before we merge this and see if they figure it out on their side. No worries, this PR will make it into the 0.2.0 release

The former

In that case let's revisit this next week and see if they have fixed their server.

I've tried again today and I'm still getting the 500 error. Since the release is still at least a week out I'm ok with waiting. However, also fine to just remove JurrassicMid and only add it again later.

I've tried again today and I'm still getting the 500 error. Since the release is still at least a week out I'm ok with waiting. However, also fine to just remove JurrassicMid and only add it again later.

I'm mostly fine with either option.
I tested JurassicUltra with a text file that reads
Roses are red
Violets are blue

and then asked the system the question
How many legs does a spider have?

to which the system responded
A spider has eight legs.

While this is true, it doesn't feel right that the information provided didn't come from the included documents, even though the system is only supposed to answer the questions from what's included. I double checked the documentation (this and this), and everything seems to be set up correctly in the code from this PR. What are your thoughts?

I'm mostly fine with either option.

In that case let's wait a little longer. If we get closer to release and still have no green light, we can always pull the trigger then.

While this is true, it doesn't feel right that the information provided didn't come from the included documents, even though the system is only supposed to answer the questions from what's included.

Unfortunately, this is simply how LLMs work. There is no way to force them into any behavior. The system prompt just gives an instruction to it. Whether or not this is respected is a completely different story. IMO this is a quality metric and it seems that the Jurassic model is not on par with the other LLMs that we have built in.
Unless it actually can't answer a question even if given the right context, I still think it makes sense to include it.

The 500 internal service error is still present from AI21labs, but I've rebased this branch to get rid of the conflict in the FAQ documentation file

Up to you how you want to handle this: keep waiting for them to fix their server or remove the "mid" model from the PR and we can merge as is.

Up to you how you want to handle this: keep waiting for them to fix their server or remove the "mid" model from the PR and we can merge as is.

I'd love to have another PR merge on the books. If you don't see any reason not to comment out the Mid model, I'm happy to go ahead and do so to make this PR ready to merge

Please leave a comment on the "mid" model on why this is commented out linking to this thread.

Please leave a comment on the "mid" model on why this is commented out linking to this thread.

I added a comment. I'll add a link to this thread

Please leave a comment on the "mid" model on why this is commented out linking to this thread.

Done


【solved】scroller component inside ios13 after scrolling animation end list always go back to top

hey，my dear developer！after ios13 upgrade more and more people find issue in scroller component
i find one solution and i wish that can keep scroller live long and prosper
here is main issue：

after .match（） ‘window.getComputedStyle(this.container)[transform]’
the 'matrix' returned could contain number like ‘-3.1415926e-16’
but original regexp split that into 2 pieces
so i split ‘matrix(1, 0, 0, 1, 0, -25)’ by .split(",") then  number like ‘-3.1415926e-16’ can finally be matched into one string
transY[5] now can match the correct element not ‘1’ anymore :)
var transY = window.getComputedStyle(this.container)[transform].match(/[\d|-].*\d/)[0].split(",");

also function getScrollLeft need a fix

The scroller component was deprecated for a long time. I suggest you search for a replacement in Vue community.

没办法了、、项目迭代已经太深了、、、换插件改动量太大了、、、、目前采用的scroller私有化解决的


cve{,2}.freakattack.com gone?

Lets see if this is just temporary issue or will it persist. If this is permanent, we need to remove tests.
$ host cve.freakattack.com
Host cve.freakattack.com not found: 3(NXDOMAIN)

$ host cve2.freakattack.com
Host cve2.freakattack.com not found: 3(NXDOMAIN)

Yeah, they seem to be off the grid at least at the moment. Let's remove those tests.


perfcollect -pid arg results in CPU attribute not set error on Ubuntu

Originally reported in https://github.com/dotnet/coreclr/issues/18452.
From @paraspatidar:

FYI , apart from kubernetes , same behavior is observed on Ubuntu VM on azure.
However on Ubuntu it happens only when we pass -pid in perfcollect as argument to specifically target perticular dotnet process.
for normal run where it collect for all CPUs (-a) , then it is successfully able to get CPU traces.
(however on kubernetes we have no other option but to use -pid as -a failed due to access issue)
when running that command manually :
/usr/bin/perf script -i perf.data.merged -f comm,pid,tid,cpu,time,event,ip,sym,dso,trace > perf.data.txt :
output : Samples for 'cpu-clock' event do not have CPU attribute set
OS :
NAME="Ubuntu"
VERSION="18.04.1 LTS (Bionic Beaver)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.04.1 LTS"
VERSION_ID="18.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=bionic
UBUNTU_CODENAME=bionic
uname -r : 4.18.0-1011-azure

I found this issue on Google when researching a similar error but in a different software suite.. sharing a few notes here in case someone comes back to this ticket:
I believe the reason this happens is that if you are on metal with hardware performance counters, perf uses the 'cycles' event that has the CPU number. If you are on a VM without hardware performance counters (which is most of the time, particularly in public clouds due to security reasons, I think some AWS instance types where you have dedicated hardware access might give you some performance counters even in a VM), then it uses the software 'cpu-clock' event which does not have this field.
I didn't get to figuring out why in some configurations using all-CPU versus per-process mode seems to result in the CPU field appearing or disappearing.
When using "perf script"'s "-F" field specifier you can specify different fields for "software", "hardware" and "trace" events. Unfortunately if you specify a format for hardware events and there are no such in the file then it errors out. So it seems we can't ask "perf script" to handle this for us and likely some kind of software detection is going to be required.
Hope it helps someone...


Super Trends indicator is bugged

Fixed histogram and Nan values. Now they are 0

Some where, I fixed it the problem with the kumo cloud...

Seems to be fixed, but it does not work too well since it does not signal often enough.


Neutron plugin writes endpoints without a workload_id in the key

Spotted while adding the '/v1/' prefix into the data model.  The plugin is writing keys like this:
/calico/v1/host/felix-host-1/workload/openstack/endpoint/DEADBEEF-1234-5678
which is missing the workload_id:
/calico/v1/host/felix-host-1/workload/openstack/<workload_id>/endpoint/DEADBEEF-1234-5678
As a work-around to let me make progress, I've inserted the endpoint ID in that place in the URL but this is wrong! (Or I will have when I push my changes shortly.)
Currently, there is no impact because Felix ignores this value.  However, this might not always be the case, especially if we need to relax our anti-spoofing rules.

I appreciate that this is wrong according to the data model.  However, what do you need a workaround for, if (as you say) Felix ignores the value?

@neiljerram I thought it was crazy to do the work to add /v1/ to the keys without making the key-calculation logic common between felix and the neutron plugin so I made a new module to contain the keys and functions to calculate keys for different things.  Since there's now an API there, it needs a workload_id passed in to calculate the key.  Seemed silly to move the bug into the common code rather than keeping it in the plugin.

Pull request for the version change is here: https://github.com/Metaswitch/calico/pull/387 if you want to see what I'm talking about.

I think we should fix this up in the next release if possible to avoid the need to migrate.

The actual bug originally reported is now fixed, so I'm closing this. There's a separate enhancement, which I'm tracking in #445.


removing a reaction does not remove it from the UI

No content

Issue created by BlueBubbles Bot in the BlueBubbles commnity on behalf of @tneot01 in #android-support.

Fixed


clang-tidy is not using Include directories correctly

I am using the c++ version of vulkan.h, vulkan.hpp
In there the class vk::device has an implicit conversion operator from vk::Device to VkDevice.
My code compiles fine without error or warning with visual studio, but it seems clang is not seeing the include directory of Vulkan.
Maybe it is an environment issue? I am including the path to the Vulkan SDK like this $(VULKAN_SDK)\Include in the Include Directories of the VC++ Directories of the project properties.

Start Clang Tidy
PROJECTS:
D:_Dev\Playground\VulkanTriangleApp\VkHal\VkHal.vcxproj
PROJECT: D:_Dev\Playground\VulkanTriangleApp\VkHal\VkHal.vcxproj
1: D:_Dev\Playground\VulkanTriangleApp\VkHal\srcs\VkHal\VkRenderer.cpp
6 warnings and 12 errors generated.
Error while processing D:_Dev\Playground\VulkanTriangleApp\VkHal\srcs\VkHal\VkRenderer.cpp.
D:_Dev\Playground\VulkanTriangleApp\VkHal\srcs\VkHal/VkDebugReport.h(73): error: no viable conversion from 'const vk::Device' to 'VkDevice' (aka 'VkDevice_T ') [clang-diagnostic-error]
vkCheck(m_setObjectNameFct(device, reinterpret_cast<VkDebugUtilsObjectNameInfoEXT>(&nameInfo)));

I also have other includes in the Include Directories and they are fine. the env var is the only thing i can see that would be different.

Environment variables should be taken into account. Not sure what happening here...
Please activate Verbose mode and look in the verbose log for detected Include Directories.

Thanks, I had actually multiple issues. First I had 2 version of LLVM and the wrong one was being used.
Then, clang was complaining about ambiguous overload. It was a situation where probably clang is right but still, the code worked.
Anyway thanks!


Meilisearch for prefetched courses

Motivation and Context

The current sql fulltext search is not user friendly. To overcome this issue we can try using meilisearch as discussed here: https://github.com/joschahenningsen/TUM-Live/discussions/814 It even handles typos very well.
Description

The courses are prefetched and stored in a newly introduced search engine instead of the database. From there we can simply query them.
Steps for Testing

Run a local instance of meilisearch like this:
docker run -it --rm \
    -p 7700:7700 \
    -e MEILI_MASTER_KEY='MASTER_KEY'\
    -v $(pwd)/meili_data:/meili_data \
    getmeili/meilisearch:v0.30 \
    meilisearch --env="development"

Download and extract this json document: prefetchedCourses.zip
Push it to meilisearch as demo data:
curl \
  -H "Authorization: Bearer MASTER_KEY" -X POST 'http://localhost:7700/indexes/PREFETCHED_COURSES/documents?primaryKey=courseID' \
  -H 'Content-Type: application/json' \
  --data-binary @prefetchedCourses.json

Test the search when creating a course
The import can only be tested with a tum online token so you'll need to trust me on this :P
Screenshots

https://user-images.githubusercontent.com/44805696/205313794-edae6066-9c8c-4ace-815e-891684570fc1.mp4

Thanks to @CommanderStorm for the input on this :)

When I add the JSON file and run meilisearch, I get no results (although all requests are status 200). Do you have any idea what could be wrong?
I get [2022-12-02T20:06:08Z INFO  index_scheduler] A batch of tasks was successfully completed., so I assume it is added.

I think I get the error missing_document_id, which might be related to a broken setup.

Hm I thought the ?primaryKey might do the trick 🤔
I'll check this out tomorrow!

@alexanderstephan I updated the zip file, it should work with the new one :)


Bonder: Doesn't bond transactions originating from non-hop smart contracts

Since the bonder node decodes the transaction input data to determine some things, if the transaction is made via another smart contract the decoder fails and hence bonding fails.

@vaibhavchellani Thanks for the bug report! An update has been applied so it doesn't try to decode the data anymore.
Our bonders will be able to update with the fix within the next couple of days.


Line : 705 | IndexError | list index out of range

Is there an existing issue for this?

[X] I have searched the existing issues

I'm submitting a ...

[X] bug report
[ ] feature request
[ ] support request --> Contact me over mail for support https://github.com/MShawon

Description
[20-Feb-2023 12:40:59] | 19.3%  | Worker 16 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:00] | 35.0%  | Worker 14 | Line : 705 | IndexError | list index out of range
[20-Feb-2023 12:41:00] | 35.0%  | Worker 17 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:02] | 36.3%  | Worker 18 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:04] | 29.5%  | Worker 15 | Line : 705 | IndexError | list index out of range
[20-Feb-2023 12:41:06] | 11.9%  | Worker 19 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:11] | 12.6%  | Worker 16 | Line : 705 | IndexError | list index out of range
[20-Feb-2023 12:41:13] | 19.1%  | Worker 20 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:13] | 19.1%  | Worker 20 | Line : 705 | IndexError | list index out of range
[20-Feb-2023 12:41:14] | 34.8%  | Worker 17 | Line : 705 | IndexError | list index out of range
[20-Feb-2023 12:41:15] | 17.9%  | Worker 21 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:16] | 78.8%  | Worker 22 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:17] | 28.3%  | Worker 21 | Line : 705 | IndexError | list index out of range
[20-Feb-2023 12:41:18] | 34.3%  | Worker 18 | Line : 705 | IndexError | list index out of range
[20-Feb-2023 12:41:19] | 25.9%  | Worker 23 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:20] | 14.1%  | Worker 24 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:21] | 23.6%  | Worker 22 | Line : 705 | IndexError | list index out of range
[20-Feb-2023 12:41:23] | 36.3%  | Worker 25 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:24] | 14.4%  | Worker 19 | Line : 705 | IndexError | list index out of range
[20-Feb-2023 12:41:26] | 26.9%  | Worker 23 | Line : 705 | IndexError | list index out of range
[20-Feb-2023 12:41:27] | 14.3%  | Worker 26 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:28] | 15.7%  | Worker 27 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening a new driver...
[20-Feb-2023 12:41:28] | 16.3%  | Worker 24 | Line : 705 | IndexError | list index out of range
[20-Feb-2023 12:41:30] | 72.6%  | Worker 28 | <IP_ADDRESS>:3128 | HTTP | Good Proxy | Opening
This happens to me on both exe and py verison.
Environment
- OS : windows
- Python : idfk
- Script version : newest

config.json
{
    "http_api": {
        "enabled": false,
        "host": "<IP_ADDRESS>",
        "port": 5000
    },
    "database": false,
    "views": 1000,
    "minimum": 85.0,
    "maximum": 95.0,
    "proxy": {
        "category": "p",
        "proxy_type": "http",
        "filename": "proxys",
        "authentication": true,
        "proxy_api": false,
        "refresh": 0.0
    },
    "background": false,
    "bandwidth": false,
    "playback_speed": 1,
    "max_threads": 5,
    "min_threads": 2
}

since your proxies don't have username and password, change those things in config.json  "category": "f", and  "authentication": false

since your proxies don't have username and password, change those things in config.json "category": "f", and "authentication": false

What If I have both types?
Many thanks,


#P04.1. Only display published Hackathons.

Depends on #M10. Update Hackathon and Profile model with new fields.
This applies for user_type staff as well.

@natalijabujevic0708


Add a method to delete saved tracks

Is your feature request related to a problem? Please describe.
Delete saved tracks
Describe the solution you'd like
A saved track(s) to be deleted from the library
Describe alternatives you've considered
none
Additional context
https://developer.spotify.com/console/delete-current-user-saved-tracks/

Done in #118


Damn Delicious failing

When trying to access a damn delicious recipe, errors saying there is no recipe found on the page.
Pages tested:
https://damndelicious.net/2019/05/05/carne-asada/
https://damndelicious.net/2019/04/18/mexican-street-tacos/
https://damndelicious.net/2019/08/20/raspberry-croissant-french-toast-bake
All of these failed to get a recipe.

I tested all three of these just now and they all worked. Maybe the site was undergoing maintenance? Let me know if you continue to have issues and I can troubleshoot further.


 Does it mean that it will automatically apply all available syntax plug-ins?
I have a project using babel-eslint, and ESLint manages to understand Class Fields event without .babelrc file.
<EMAIL_ADDRESS><EMAIL_ADDRESS>

AFAIK, babel-eslint don't need .babelrc, it uses babylon parse your code to AST.

And what about syntax plug-ins?

@the-spyke babel-eslint manages its own set of Babylon (our parser) plugins (ref: https://github.com/babel/babel-eslint/blob/master/lib/parse.js#L18)

@existentialism Oh, I see. Thank you. A remark about this in readme may be useful.

@the-spyke agreed, would you like to a PR? :D


tectonic: 0.3.3 -> 0.4.0

Motivation for this change
https://github.com/tectonic-typesetting/tectonic/releases/tag/tectonic%400.4.0
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 107930 run on x86_64-linux 1

1 package built:

tectonic


[revert] Revert #5445

This PR reverts https://github.com/apache/incubator-superset/pull/5445 due to the fallout related to potentially ill-defined metadata. As discussed here the collective decision was to revert the logic (which will be cherry-picked into v0.31) and re-remedy the entire problem prior to the v0.32 branch cut.
Note this PR "reverts" in the sense of it creates a new database migration to rollback the state of the database to something representative prior to https://github.com/apache/incubator-superset/pull/5445.
to: @graceguo-supercat @michellethomas @mistercrunch @xtinec

Codecov Report

Merging #7095 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7095      +/-   ##
==========================================
- Coverage   64.57%   64.56%   -0.01%
==========================================
  Files         422      422
  Lines       20576    20574       -2
  Branches     2251     2251
==========================================
- Hits        13286    13284       -2
  Misses       7168     7168
  Partials      122      122

Impacted Files
Coverage Δ

superset/__init__.py
74.04% <ø> (-0.4%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d67da...66eee14. Read the comment docs.


Refactoring WebDriverFactory

Issue #555
I squashed changes from https://github.com/codeborne/selenide/pull/581 fix checkstyle issues and add tests.
Let's continue discussions these changes.

Coverage increased (+0.2%) to 64.603% when pulling b0d2702f0b4ca25da6dd016a80eb98c9e9c9b33a on Issue_555 into cab968059c4aeac8a6bfe8b3dddac02c53ec65d7 on master.

Codecov Report

Merging #606 into master will increase coverage by 0.54%.
The diff coverage is 67.03%.

@@            Coverage Diff             @@
##             master   #606      +/-   ##
==========================================
+ Coverage     60.45%    61%   +0.54%
- Complexity      728    760      +32
==========================================
  Files           134    147      +13
  Lines          2658   2698      +40
  Branches        270    257      -13
==========================================
+ Hits           1607   1646      +39
- Misses          945    955      +10
+ Partials        106     97       -9

Impacted Files
Coverage Δ
Complexity Δ

...eborne/selenide/webdriver/RemoteDriverFactory.java
10% <10%> (ø)
2 <2> (?)

...ne/selenide/webdriver/MarionetteDriverFactory.java
33.33% <33.33%> (ø)
2 <2> (?)

...odeborne/selenide/webdriver/EdgeDriverFactory.java
40% <40%> (ø)
2 <2> (?)

...enide/webdriver/InternetExplorerDriverFactory.java
40% <40%> (ø)
2 <2> (?)

...rne/selenide/webdriver/PhantomJsDriverFactory.java
50% <50%> (ø)
2 <2> (?)

...eborne/selenide/webdriver/SafariDriverFactory.java
50% <50%> (ø)
2 <2> (?)

...deborne/selenide/webdriver/OperaDriverFactory.java
50% <50%> (ø)
2 <2> (?)

...orne/selenide/webdriver/JBrowserDriverFactory.java
50% <50%> (ø)
2 <2> (?)

...borne/selenide/webdriver/DefaultDriverFactory.java
66.66% <66.66%> (ø)
2 <2> (?)

...orne/selenide/webdriver/AbstractDriverFactory.java
69.04% <69.04%> (ø)
10 <10> (?)

... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab9680...b0d2702. Read the comment docs.


perf(ast): ThinVec

From https://nnethercote.github.io/2023/03/24/how-to-speed-up-the-rust-compiler-in-march-2023.html

#104754: In this PR I changed a lot of Vec occurrences in AST nodes to ThinVec, which stores the length and capacity of non-empty vectors on the heap next to the vector’s elements. This means that the size of a ThinVec struct is just one word, compared to three words for Vec. This makes it a good choice for vectors that are often empty, and it can also be used to shrink the largest variants of an enum, if those variants contains a Vec. This change reduced the size of many AST nodes

I wonder how hard it is to crate our own ThinkVec based on bumpalo :thinking:

Closing due to being too complicated for us to implement with bumpalo.


HDDS-10885. Add a landing page for each section of the documentation.

What changes were proposed in this pull request?
Motivation
Currently the website's documentation sidebar is defined by a _category_.yml file in each docs subdirectory. The way we currently have these configured has the following limitations:

We cannot link to sections of the documentation, only individual pages. For example, we cannot send someone a link to the "Quick Start" section like docs/quick-start, only to a specific page in the section like docs/quick-start/installation/docker.
There is no place to add a summary of what content can be found (or should be added) to which section.
The breadcrumbs at the top of each page cannot be clicked to navigate the site.

Implementation
My initial pass at this involved trying to implement the above with the existing _category_.yml files as described in the docusaurus docs. We could add a title, description, and index of content in that section using the yaml file. This had two major issues though:

The description field is rendered as a literal string, not markdown which limits what content can be put there.
The URLs generated for these sections appear under the docs/category slug regardless of their path in the filesystem.

For example, given the page docs/quick-start/installation/docker, the summary for the quick start installation section would be at docs/category/installation instead of docs/quick-start/installation.

It seems like docusaurus "categories" are meant to be a something separate from the sidebar index, and it just provides the option to map them there. What I think we are actually want for this use case is what Docusaurus calls index documents. This is a markdown (or mdx) file at the root of each subdirectory that we can fill in with a title and summary just like any other markdown page. We can also automatically generate an index of the pages in this section with the DocCardList tag.
Docusaurus supports calling these files either index or README with either .md or .mdx extensions. I went with README because it is automatically displayed when browsing via GitHub like this. I am using the .mdx extension since each of these pages has a DocCardList react component embedded in it. CI has been updated to make sure that changes in this area continue to follow this convention.
Summary of Changes
This is a large change that can be broken into the following parts:

Delete all _category.yml_ files previously used to add titles to doc sections.
Add README.mdx files for all doc sections.
Some reworking of the docs organization, since I had to review and summarize the entire docs structure as part of this change.
Replace CI check requiring _category.yml_ files with a check requiring README.mdx files.
Update the contributing guide with instructions for adding a new docs subdirectory/sidebar section.

The changes to 4 and 5 are mostly contained in CONTRIBUTING.md and the .github directory. These are relatively small and can be reviewed with the standard GitHub diff view.
To review changes to 1-3, it is probably easiest to use the rendered website. Use the staging site as the before, and build and run these changes locally to get the after site. Click through the docs sections to review the changes side by side in different tabs or windows.
What is the link to the Apache Jira?
HDDS-10885
How was this patch tested?

Changes previewed locally.
CI passes with the existing changes.
An example run with README.mdx errors fails

When there are issues, a help message is printed to the job summary and the console output of the sidebar check job.
Failing to create a README.mdx file for a directory or not including a DocCardList at the end causes this failure.

An example run using the DocCardList tag without importing it fails at the Docusaurus build stage with no extra changes required.
README.mdx files are still subject to the same spelling and front matter checks as other pages:

Spelling failure
Front matter failure

Apologies in advance for this monster change 😄
@adoroszlai would you be able to review the CI and dev experience portions of this change (everything outside of the docs directory)?
@swagle @umamaheswararao @arp7 can you review the doc content portion of this change (everything inside the docs directory)? As I mentioned in the PR description this part is probably easier to do with the rendered sites instead of GitHub's diff view.

it is probably easiest to use the rendered website. Use the staging site as the before, and build and run these changes locally to get the after site. Click through the docs sections to review the changes side by side in different tabs or windows.

The change set on this PR is understandably daunting, but since Attila has already reviewed the CI portion the final approval really only requires clicking through the docs section of the new website to visually check the changes:

Docs section structure still makes sense. Minor tweaks were made here from the existing version.
Breadcrumbs at the top of the docs section work for navigation.
The summary pages of each docs section (accessible by clicking on the section's name in the sidebar) have descriptions that make sense.

Here's a graphic of one of the new section summary pages to demonstrate the change.

Thanks @kerneltime. I moved blogs up for better visibility in this PR since there were already some layout changes here. Port change I will do in a different PR.


Font family names?

Would be great to reference here a list of standard font family names as included in default WIn10 systems.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 31874255-c39d-ed8e-0e40-35281620e29e
Version Independent ID: c057c98a-9b09-0e20-237e-5b4f6589dae8
Content: FontFamily.Source Property (Windows.UI.Xaml.Media) - UWP app developer
Content Source: https://cpubwin.visualstudio.com/DefaultCollection/windows-uwp/_git/winrt-api-build?path=%2fwinrt-api-build%2fwindows.ui.xaml.media.fontfamily.yml&version=GBlive&_a=contents
Product: uwp
Git Login: jwmsft
Microsoft Alias: jimwalk

Here's a list for Windows 10: https://docs.microsoft.com/en-us/typography/fonts/windows_10_font_list


Ability to mark Version Catalog entries as Deprecated

Expected Behavior
Version Catalog entries should provide a way to mark them as deprecated, and the generated accessors for the entries should be marked deprecated as well to ensure that users are aware of the deprecation.
plugins {
    `version-catalog`
    `maven-publish`
}

catalog.versionCatalog {
    version("something", "1.2.3") {
        deprecated = "reason"
    }
    library("something", "group:artifact:1.2.3") {
        deprecated = "reason"
    }
    // ...
}

The generated accessors would then be annotated with @Deprecated and the reason that was given while building the version catalog.
Current Behavior (optional)
Currently it's impossible to mark an entry in a Version Catalog as deprecated, and there's no way to communicate to users that an entry is going to be removed in a future release.
Context
The Version Catalog feature is really great and it allows vendors to provide a type-safe way to add many dependencies to their builds without worrying about versions. However, once an entry has been added it cannot be renamed anymore. This makes it hard to convince vendors to publish version catalogs, since they're rightfully worried about this.

This feature request is in the backlog of the relevant team and is prioritized by them.


mj-image src validation

Is your feature request related to a problem? Please describe.
There are some email clients (Gmail for example) that do not support base64 image loading and they just show the alt value.
Describe the solution you'd like
In my opinion the best solution would be to validate (or show a warning?) de src content and check that starts with 'http(s)' string.
Describe alternatives you've considered
Another way to validate the src content would be to check that it does not start with 'data:' string.

Hi,
I don't think we'll do that because some people are using templating in href so it would trigger validation issue for nothing.

Ok, got it
What about the alternative of not allowing  src content starting with 'data:'?

You can still add your own validation rules, with https://github.com/mjmlio/mjml/blob/master/packages/mjml-validator/src/index.js#L10
I don't think we should have an opinion about this, as it's a user preference (you don't accidentally put a base 64 image inside your mjml document)


Add support for other backend

Expected Behavior
We should be able to select different backends. Need at least to support :
1- llamacpp
2- gpt-j
3- hugging face transformers models
Current Behavior
Only llamacpp is supported

Now gpt-j backend is supported with a simplified mode (no word by word output)

this is completed


Vision TensorRT samples initial merge

python and c/c++ samples partially modified from nvidia samples for ease of use
support for Caffe FRCNN and SSD
support for caching of compiled trt model at specific floating point, batch, resolution settings
support for command line input image files paths
support for camera input
support for tracing and displaying detected labels and bounding boxes

Ok, changed the headers per suggested link above.


Fixed Typographical Error in guide/english/accessibility/index.md

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

@RandellDawson is this PR good to be merged?

@iamrajiv This has been reviewed by @thecodingaviator, so he can make that decision.

@iamrajiv Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


Using happypack, but no faster 🤔

Just switched to using these 4 instances:
new HappyPack({
            id: 'js',
            threadPool: happyThreadPool,
            loaders: [ {
                path: 'babel',
                query: {
                    cacheDirectory: true,
                    compact: false,
                    sourceMaps: true,
                    presets: [
                        'es2015',
                        'stage-0',
                        'react'
                    ],
                    plugins: [
                        'lodash',
                        'export-default-module-exports',
                        'transform-export-extensions',
                        ['transform-es2015-modules-commonjs-simple', {
                            noMangle: true
                        }],
                        'transform-decorators-legacy'
                    ]
                }
            }]
        }),

        new HappyPack({
            id: 'scss',
            threadPool: happyThreadPool,
            loaders: ["style", "css", "postcss", "resolve-url", "sass?sourceMap"]
        }),

        new HappyPack({
            id: 'css',
            threadPool: happyThreadPool,
            loaders: ["style", "css", "postcss", "resolve-url"]
        }),

        new HappyPack({
            id: 'svg',
            threadPool: happyThreadPool,
            loaders: [
                'babel!react-svg?' + JSON.stringify({
                    svgo: {
                        // svgo options
                        plugins: [{ removeTitle: true }],
                        floatPrecision: 2
                    }
                })
            ]
        }),

And these module.loaders:
loaders: [{
            test: /\.css$/,
            loader: 'happypack/loader?id=css',
        }, {
            test: /\.jsx?$/,
            exclude: /(node_modules|bower_components)/,
            loader: 'happypack/loader?id=js',
        }, {
            test: /\.scss$/,
            loader: 'happypack/loader?id=scss'
        }, {
            test: /\.(png|woff|woff2|eot|ttf|svg)$/,
            loader: 'url?limit=100000&name=fonts/[name]-[hash].[ext]',
            exclude: /(images)/
        }, {
            test: /\.(jpe?g|png|gif)$/,
            loaders: [
                'url?hash=sha512&digest=hex&name=images/[name]-[hash].[ext]',
                'image-webpack?bypassOnDebug&optimizationLevel=7&interlaced=false'
            ],
            exclude: /(fonts)/
        }, {
            test: /\.svg$/,
            loader: 'happypack/loader?id=svg',
            exclude: /(fonts)/,
        }]

But my builds still take exactly the same amount of time. (140s ± 5 sec)
When I run webpack, I'm shown:
Happy[js]: Version: 3.0.3. Using cache? yes. Threads: 5 (shared pool)
Happy[js]: Loaded 437 entries from cache. (0 were stale)
Happy[js]: All set; signalling webpack to proceed.
Happy[scss]: Version: 3.0.3. Using cache? yes. Threads: 5 (shared pool)
Happy[scss]: Loaded 171 entries from cache. (0 were stale)
Happy[scss]: All set; signalling webpack to proceed.
Happy[css]: Version: 3.0.3. Using cache? yes. Threads: 5 (shared pool)
Happy[css]: Loaded 2 entries from cache. (0 were stale)
Happy[css]: All set; signalling webpack to proceed.
Happy[svg]: Version: 3.0.3. Using cache? yes. Threads: 5 (shared pool)
Happy[svg]: Loaded 71 entries from cache. (0 were stale)
Happy[svg]: All set; signalling webpack to proceed.

but still no speed gains compared to not having any of this config in place.
Am I missing something fundamental? Is there a recommendation for where I ought to dive in to debug ?

Man, that's unfortunate. There's been another report recently of no speed gains from using the plugin. Can you tell us more about your environment?

The OS (Windows?)
Node version
Number of physical processor cores (cat /proc/cpuinfo if you're on linux or sysctl -a | grep machdep.cpu | grep core_count on mac)
? not sure what else, anything of relevance

@amireh I've been noticing the same issue. My configuration is similar to the one above. HappyPack used to work wonderfully with webpack 1, but after migrating to webpack 2 and the new id syntax to use happypack, the plugin doesn't do much. Happy to provide more information, if it solves the issue.
OS: MacOS
Node v7.8
cpu.core_count: 2

@pastelsky it could help a lot if we can get a repository that reproduces this. Something with both webpack1 and webpack2 in place so that we can benchmark and see if there's a real problem.
I can't get any meaningful numbers out of the projects I'm using happypack on so there's not much I can do.

Closing because of inactivity. If you think this is still a valid issue, please file a new issue with additional information.


Examples in develop branch use old IO extension

There examples in the current develop branch have not been ported to the new IO v2 extension, so they still include the old IO headers. For example:
dynamic_image.cpp(20):#include <boost/gil/extension/io/jpeg_dynamic_io.hpp>
interleaved_ptr.cpp(35):#include <boost/gil/extension/io/jpeg_dynamic_io.hpp>
x_gradient.cpp(18):#include <boost/gil/extension/io/jpeg_dynamic_io.hpp>

affine.cpp(25):#include <boost/gil/extension/io/jpeg_io.hpp>
convolution.cpp(25):#include <boost/gil/extension/io/jpeg_io.hpp>
histogram.cpp(23):#include <boost/gil/extension/io/jpeg_io.hpp>
mandelbrot.cpp(20):#include <boost/gil/extension/io/jpeg_io.hpp>
packed_pixel.cpp(36):#include <boost/gil/extension/io/jpeg_io.hpp>
resize.cpp(25):#include <boost/gil/extension/io/jpeg_io.hpp>

We can remove those tests. I think I have added the tests to ensure the new io is backwards compatible. Meaning the old io's interface is still functioning with the new io.

If there are no equivalents based on IO v2, I think it's worth to port them.

Oh, I think I misunderstood you. You're not talking about tests but actual library code. Let me see

@chhenning I think I've got confused myself to: I reported exampels you responded those tests :)
Let's rewind and talk about the examples (resize, mandelbrot, etc.). I suggest that instead of removing them, they should be ported to the new IO.

I agree. We can make them part of the test suite.

I didn't realize there are "Examples". Might be good to include them in the documentation.

The ancient GIL docs http://stlab.adobe.com/gil/documentation.html include them in the list of Samples on the front page. BTW, this old docs should be put down as they are doing bad publicity for Boost.GIL, IMHO.


dynamic_finished view still references ogusa package

This bug would prevent the successful send of a completion email upon dynamic success.

closed via #153


Add ability to specify custom headers in constructor

@lemieux @dannytranlx @mspensieri
We can now pass in custom HTTP headers in the constructor by doing
new Smooch(..., {
    headers: {
        myCustomHeader: '...'
    }
});

To pass in the service url, it becomes:
new Smooch(..., {
    serviceUrl: '...'
    headers: {
        myCustomHeader: '...'
    }
});

:+1:

👍

:+1:


TwoDArray.java

hacktoberfest-accepted

if you have any queries regarding this then feel free to ask me

can you please gudie me how to do that

Yes I will
On Tue, 11 Oct 2022, 1:56 pm aryan9042, @.***> wrote:

can you please gudie me how to do that
—
Reply to this email directly, view it on GitHub
https://github.com/Coding-Delight-01/DSA-in-JAVA/pull/16#issuecomment-1274298326,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASTUSW27DM64QTHUEU2QYQ3WCUQDLANCNFSM6AAAAAARBZFJRA
.
You are receiving this because you commented.Message ID:
@.***>

Then please tell me how i add this file in array folder

go to where you added your code and do following steps:
name is currently like this: Coding-Delight-01/DSA-in-JAVA/ TwoDArray.java
but you need to add here: Coding-Delight-01/DSA-in-JAVA/ arrays/TwoDArray.java
(you need to just add before your filename add : /arrays)
then your file is moved to arrays folder.

Hey, Aryan make another PR and do this properly (for practice purpose)
For this PR I will merge it and I will shift this code to the arrays folder.

Okay I will try to do it
On Tue, 11 Oct, 2022, 9:53 PM Dnyanesh Nimbalkar, @.***>
wrote:

Hey, Aryan make another PR and do this properly (for practice purpose)
For this PR I will merge it and I will shift this code to the arrays
folder.
—
Reply to this email directly, view it on GitHub
https://github.com/Coding-Delight-01/DSA-in-JAVA/pull/16#issuecomment-1274957595,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3QEEAZEILZ6GPX6SY2UIBDWCWH63ANCNFSM6AAAAAARBZFJRA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Changing delimiters should only affect the upcoming text.

I am not sure if/how this issue relates to issue #84
using the dataset {"a":"a", "b":"b", "c":"c", "d":"d", "e":"e", "f":"f"}
The following:
<%a%>
{{b}}
{{=<% %>=}}
<%c%>
{{d}}
<%={{ }}=%>
{{e}}
<%f%>

Should result in:
<%a%>
b
c
{{d}}
e
<%f%>

But it actually results in:
a
b
c
d
e
<%f%>

This is very bad if you want to use both server-side and clien-side templates within one file. I checked the code and couldn't think of a quick-fix because this bug is inherent in the way the parser works: just search the whole template for the first match to a regex, replace this match then restart, from the beginning. It would rather need to restart from the previous match position.

This is possibly a duplicate of issue #35, which has been fixed in the development branch.  See this test case, for example.  Just to be sure, I'll try to confirm that the example in the original comment above works in the development branch.

Yes, the test case presented in the original comment above works as expected in the development branch:
>>> import pystache
>>> context = {"a":"a", "b":"b", "c":"c", "d":"d", "e":"e", "f":"f"}
>>> template = """<%a%>
... {{b}}
... {{=<% %>=}}
... <%c%>
... {{d}}
... <%={{ }}=%>
... {{e}}
... <%f%>"""
>>> print pystache.render(template, context)
<%a%>
b
c
{{d}}
e
<%f%>
>>>


fix: remove preinstall (breaks install)

:tada: This PR is included in version 2.0.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CardWidth not positioning card to center

Describe the bug
When using the cardWidth property (reduced the card width), it left aligns the card and does not position it to center. Mode is HORIZONTAL
To Reproduce
Steps to reproduce the behavior:
Add cardWidth="200"
Expected behavior
Reducing the cardWidth would also align the card to the center
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Reached this bug by trying to see how react-chrono will look in mobile mode. Using the current cardWidth, text is cut off at the corners.

@sandheepsebastain this is been fixed with 1.13.


feat: make login page UI more responsive

Description:
what are the changes you implemented?
Type of change:

[ ] Bug fix
[x] New feature
[x] Fix/new infrastructure

Background context of the changes:
Why do we need those changes?
In order to make the UI more responsive
The ticket this PR closes:
https://ofirlindekel.atlassian.net/jira/software/projects/NOTIFY/boards/1?selectedIssue=NOTIFY-71
Scenarios that were tested during this implementation:
List the scenarios you tested for this changes.

Checked the form logic works correctly.
Checked the responsivness of the login page UI on various devices.

Insert screenshots / video of test results (for all relevant platforms)
If you implemented a new workflow / fixed a bug in

Merging after getting approval from @LinMoskovitch


Undertow 1.2.6.Final

Windows Build 23 is now running using a merge of d5879575015bffd3869f3a538b6e3e80037e91ff

Core - Full Integration Build 22 is now running using a merge of d5879575015bffd3869f3a538b6e3e80037e91ff

Linux Build 26 is now running using a merge of d5879575015bffd3869f3a538b6e3e80037e91ff

Windows Build 23 outcome was SUCCESS using a merge of d5879575015bffd3869f3a538b6e3e80037e91ff
Summary: Tests passed: 3101, ignored: 66 Build time: 0:20:42

Linux Build 26 outcome was SUCCESS using a merge of d5879575015bffd3869f3a538b6e3e80037e91ff
Summary: Tests passed: 3101, ignored: 66 Build time: 0:23:33

Core - Full Integration Build 22 outcome was SUCCESS using a merge of d5879575015bffd3869f3a538b6e3e80037e91ff
Summary: Tests passed: 2844, ignored: 375, muted: 1 Build time: 0:52:25


Adds build script for publishing plugin zip

Description
Adds build script for publishing plugin zips to maven repo.

Category : Maintenance
Required as part of 2.1 release

Issues

Resolves #1922

Check List
~- [ ] New functionality includes testing~
~- [ ] New functionality has been documented~

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@prudhvigodithi Can you please review this PR?  Also, a couple of questions:

How do we test this?
How do we make sure that we didn't break something in future?

Hey @DarshitChanpura you can leverage the existing build flow.
 Thank you for pointing this out @peternied !

@DarshitChanpura Please merge the PR when it's ready.


Label's vertical_alignment still affects the position even at minimum size

Godot version
4.2.dev [202e4b2]
System information
N/A
Issue description
Changing the property vertical_alignment in a Label still changes the position of the letters, even if said Label is at its minimum size, implying that it could be shrunk further:

Steps to reproduce
Create a Label node, type anything in it, and the vertical_alignment property.
Minimal reproduction project
N/A, trivially reproducible.

CC @bruvzg


fix(@embark/utils): Fix proxy crash with unknown function

If a transaction is sent and the proxy is enabled, but the function hash (identified in the data of the transaction) is not recognized as a function of the contract (ie does not match a function hash in the contract’s ABI), then embark would crash.
The fix was to introduce error handling in transactionUtils.getTransactionParams that defaults the contract name and params to UNKNOWN.
The error can be replicated by:

Clone https://github.com/mortimr/ethvtx_embark
embark run the dapp
Connect with Metamask
Ensure you have enough funds
In the “Tx calls” bubble, enter a new value, then click “Set Value”.
When the Metamask dialog appears, the error should have already happened. The console shows:

embark/src/lib/utils/transactionUtils.ts:58
  const functionName = func.functionName;
                            ^
TypeError: Cannot read property 'functionName' of undefined
    at functionName (/Users/mortimr/Horyus/ethvtx_embark/node_modules/embark/src/lib/utils/transactionUtils.ts:58:29)
    at ConsoleListener.getTransactionParams [as _onIpcLogRequest] (/Users/mortimr/Horyus/ethvtx_embark/node_modules/embark/src/lib/modules/console_listener/index.js:102:41)
    at _onIpcLogRequest (/Users/mortimr/Horyus/ethvtx_embark/node_modules/embark/src/lib/modules/console_listener/index.js:76:12)
    at Server._done (/Users/mortimr/Horyus/ethvtx_embark/node_modules/embark/src/lib/core/ipc.js:81:7)
    at Server.emit (/Users/mortimr/Horyus/ethvtx_embark/node_modules/event-pubsub/es5.js:74:21)
    at Server.gotData (/Users/mortimr/Horyus/ethvtx_embark/node_modules/node-ipc/dao/socketServer.js:194:14)
    at Socket.emit (events.js:189:13)
    at Socket.EventEmitter.emit (domain.js:441:20)
    at addChunk (_stream_readable.js:284:12)
    at readableAddChunk (_stream_readable.js:261:13)
    at Socket.Readable.push (_stream_readable.js:220:10)
    at Pipe.onStreamRead [as onread] (internal/stream_base_commons.js:94:17)

Preview of the contract logs in Cockpit when an unknown function is encountered:

Is this related to fallback functions? cf. #1451

Is this related to fallback functions? cf. #1451

I don't believe so. We were seeing function signatures come through the proxy that did not match any of the contract function signatures in the contract manager. The origin of the function signature is still unknown, however it was previously causing Embark to crash. This PR simply adds better error handling when this is encountered and displays UNKNOWN as the function name.


Trademark link not recognized

I recently added to the OTel website a link to the LF trademark page. If I used the first regex from the CLOmonitor docs, I get a match:
$ curl -s https://opentelemetry.io | perl -ne 'print if /https:\/\/(?:www\.)?linuxfoundation\.org\/(?:legal\/)?trademark-usage/' | wc -l
       1

But legal is still marked as unmatched, see https://clomonitor.io/projects/cncf/open-telemetry#community_legal:

What am I missing? Thanks!
/cc @svrnm @nate-double-u

Hi @chalin 👋
The CLOMonitor tracker runs every hour and processes a repository when:

It has changed since the last time it was processed (i.e. new commit on the repo)
Or it's been a day since the last time it was processed

In this case, the OTel community repo last change was 2 days ago, which means it'll be processed once a day until it changes again. The last time it was processed was 2023-10-18 15:01:07.377759+00, but you committed the trademark change shortly after (24 mins), at Wed Oct 18 11:25:22 2023 -0400 (plus the time it took to deploy it). So by the time the repository was processed, the trademark wasn't there yet.
If this is correct it should be fixed automatically in less than 5 hours (unless something is committed to the community repository before) 😇

That makes sense, but what confused me was the "timestamp" at the top of the page. For example, as I write this it reads "Updated 2 hours ago":

This is confusing, because if the tool fully processed all OTel repos (and hence the website too) 2 hours ago, then the legal status should have been updated.

Btw, would it be possible to add a title to the "Updated" text so that it shows the actual timestamp (similarly to what GitHub does)?

That makes sense, but what confused me was the "timestamp" at the top of the page. For example, as I write this it reads "Updated 2 hours ago":

Yes, I understand. That timestamp is updated every time the project score is updated, which happens when any of the repositories is updated. Maybe we can add an information icon that explains this a bit in a popover.

Btw, would it be possible to add a title to the "Updated" text so that it shows the actual timestamp (similarly to what GitHub does)?

We could do that, yes.

We could also display this information per repository as well.

Since the scores depend on website, wouldn't it make sense to check whether the website has changed? A good candidate file to check would be the sitemap. WDYT?

If this is correct it should be fixed automatically in less than 5 hours (unless something is committed to the community repository before) 😇

The check passed on the next run, all good now 🙂

Ok, what ever solution you think is most appropriate. As long as we can resolve the ambiguity / placebo effect of the current page-wide timestamp.

Maybe we can add an information icon that explains this a bit in a popover.

Yes, that sounds helpful.


Bugfix/krenn1/smart sample

@antimatterhorn,
Hi Cody,
I've made two tweaks to scisample that I'd like to use in the exercise.
Please take a look when you can.
Thanks!
-Chris

I'm a little confused by this github repository. It doesn't appear that I have any access at all to it other than read-only.