Updated to support podman 4.2.0

Signed-off-by: Rishi Agarwal<EMAIL_ADDRESS>Minor change in LCM script to make it compatible with latest podman versions (4.2.0 +)

It would good if you could replace dockerize with containerize as Docker is a registered trademark and not really being used properly here. However, that's not a blocker either.
Can you explain why this is necessary? Maybe I'm not spotting it, but it looks like you're trying to set the variable and if if doesn't work, you're doing the same thing again. I'm just not seeing the logic here.

Also, I just noticed line 77 which needs to be fixed ASAP. I'm sorry for not catching it in previous reviews, but that chmod value is unacceptable. It can enable group write at most but you should never make directories world writeable and executable.

Finally, a reminder that both Docker and Podman are product names and should be capitalised when used as such, i.e. in any customer visible output or documentation that isn't demonstrating the use of the command-line tools. Please review the content of your error messages to ensure that you're referring to each product correctly.

It would good if you could replace dockerize with containerize in the filename of your tarball as Docker is a registered trademark and not really being used properly here. However, that's not a blocker either.

dockerize comes in the name of the file generated by the OCI build service. We didn't try to change it. Changing of file name would have impact for existing customers and hence we can take it up separately later

Can you explain why this is necessary? Maybe I'm not spotting it, but it looks like you're trying to set the variable and if if doesn't work, you're doing the same thing again. I'm just not seeing the logic here.

The change here is Loaded image(s): vs Loaded image: in the podman output

Finally, a reminder that both Docker and Podman are product names and should be capitalised when used as such, i.e. in any customer visible output or documentation that isn't demonstrating the use of the command-line tools. Please review the content of your error messages to ensure that you're referring to each product correctly.

Fixed in the output message

Also, I just noticed line 89 which needs to be fixed ASAP. I'm sorry for not catching it in previous reviews, but that chmod value is unacceptable. It can enable group write at most but you should never make directories world writeable and executable.

@Djelibeybi we will take this up separately. A customer is waiting for the current fix and it needs to go

The change here is Loaded image(s): vs Loaded image: in the podman output

Why not just grep for Loaded image then, which would match either Loaded image: or Loaded image(s):? You're using the same awk for each, so that should work.

Note that this is a change to a sample script, so you can provide the customer with a fixed version before this is merged. Alternatively, the customer could make the modification themselves locally too. On that note, please open a fix for the identified security issue ASAP if you're not going to address it in this PR.

The merge is also blocked due to linter issues, which you'll need to address.

resolved

filed issue https://github.com/oracle/docker-images/issues/2510 to track linter issue

The merge is also blocked due to linter issues, which you'll need to address.

Are we supposed to fix issues for all severity levels including : style, info and warnings?  We see nothing was reported as an error in the scan. What is the gating criteria here?

The gating is warnings and errors (yellow and red). The info/style stuff doesn't actually block a merge, though should be reviewed and deemed acceptable, you should add a directive so that the linter ignores it in future.

The info/style stuff doesn't actually block a merge

Following up because this is not correct: the Super Linter check will block merging for all shellcheck issues.


Support image enclosures

I follow the NASA Image of the Day RSS feed (https://www.nasa.gov/rss/dyn/lg_image_of_the_day.rss), which uses the following format:
<item>
  <title>Defining Radiation Risk to Astronauts</title>
  <link>http://www.nasa.gov/image-feature/defining-radiation-risk-to-astronauts</link>
  <description>In this image, one of the radiation detectors for the Radi-N2 experiment floats in the space station. This device will help researchers explore the radition risk to humans in space.</description>
  <enclosure url="http://www.nasa.gov/sites/default/files/thumbnails/image/2_iss035e031921_0.jpg" length="846869" type="image/jpeg"/>
  <guid isPermaLink="false">http://www.nasa.gov/image-feature/defining-radiation-risk-to-astronauts</guid>
  <pubDate>Mon, 24 Aug 2020 02:16 EDT</pubDate>
  <source url="http://www.nasa.gov/rss/dyn/lg_image_of_the_day.rss?title_no=79544">NASA Image of the Day</source>
</item>

Note that it has its image embedded as an <enclosure type="image/jpeg"> tag. As far as I can tell, these enclosure values are not used anywhere. That means that the image of the day cannot be viewed without tapping or clicking on the link to open the web page (the reader view does not support displaying the image either due to client-side JS).  Would it be possible to display image attachments at the beginning or end of the content, or would it be better for me to contact NASA to see if they are willing to change the feed to include the image another way/should I just make my own feed?

They shouldn’t assume that RSS readers will do anything with image enclosures. Instead, they should link to those images as part of the HTML body of each item.

I think this could be reopened as image enclosures are semantically correct RSS and not only for podcasts, unless I'm mistaken.

I also think this should be reopened for the reason stated above.

The main issue is that this would mean parsing enclosures for every single feed, which would make the parser slower. It also means adding columns to the database for storing enclosures, which will make database operations in general slower. It’s a performance hit that everyone would suffer while it would benefit few feeds.
That’s not to say we’d never do it! I’m just explaining the trade-off.

Understood.
I'll keep one eye on NetNewWire, meanwhile I'll have to stick with Newsify. Their macOS app is Catalyst, so pretty terrible all said, but browsing my feeds is so much quicker with visible thumbnails. Here are some screenshots to illustrate my situation.
NetNewsWire

Newsify

Wait, I just realised, the feed in my example above is not using enclosures!
RSS: https://politepol.com/fd/UAWxeIa8I3Lk
Contents: https://gist.github.com/gingerbeardman/a96871572d0016025b6409ba7e30e107
So, Newsify is getting the image is from the main content of the article.


Fix duplicate profile pic

looks like this already got solved in a previous pull request but thanks anyway :)


.ci/Jenkins moved to .ci/jenkins

.ci/Jenkins folder renamed to .ci/jenkins

@ederign @radtriste @tiagobento is there any side effect? I've created https://github.com/kiegroup/kie-jenkins-scripts/pull/1106 for Jenkinsfile.nightly, but I'm not sure about Jenkinsfile.vscode job pointing to that file.

Yes, the Jenkins.vscode file is used by an external job that publishes our extensions to the VS Code and OVSX marketplaces.
cc @caponetto

@ederign @radtriste @tiagobento is there any side effect? I've created kiegroup/kie-jenkins-scripts#1106 for Jenkinsfile.nightly, but I'm not sure about Jenkinsfile.vscode job pointing to that file.

I don't know which job is using it ...

thanks guys!! @caponetto please go ahead!


Tests, TypeScript, Encoding, and Promise-based API

@laktak This is a spare time project so I don't know how soon I will finish it, but it is at a point where you can get a good enough idea of where I am going.  I am opening this PR hoping for some early feedback on whether this is even something you would want so I have a better idea what to do with it when I do have it release ready.  I totally understand it may not be what you want for any-json, in which case I will release it as its own package.
On the API side, it is a re-write that is strictly Promise based (no more Async vs non-async members exposed) and supports encoding as well as decoding.
The command-line application could be modified to use this API.  I think that least some of the old API methods could be written in terms of these if it were really wanted.

Wow, that's quite a rewrite :)
I like what you are doing but I need to ask if this is a one-off PR? If you are OK with maintaining this for longer and looking after your changes I can add you as a collaborator with commit rights.

The short answer is yes I would be able to help with maintenance.
The risk, or my apprehension, is that my needs may not needs may not directly match your needs or desired stability, so some coordination will be needed (making me hesitant to want to commit directly) or at least I will need a clear understanding of what is/is not important to preserve.  For example, I would have no hesitation with switching one of the underlying format implementation libraries if it would fix an issue.  However, doing could be considered a breaking-change by some because it might change the output format or risk some other edge case being handled differently.
The longer answer is, I have a number of use cases where I need any-json or something like it; though most are API access, and not command line:

I depend of any-json in [pajv](with https://www.npmjs.com/package/pajv) so have an interest in it being maintained.

I will at least attempt adding TOML support to any-json for this reason.

I have a project where I want to be able to go back-and-forth between individual YAML files and a single csv (Jekyll currently requires one source file to one output page)
I have a project where I want to be able to process, a likely multi-tabed spreadsheet into JSON/YAML file(s) (Again for a Jekyll website, but a single page)

The first of getting this to have sufficient parity to merge then adding TOML support is my highest priority.  Then I will dig into how best process my files for conversion between the Object and Tabular formats.

Oh, and understanding of target platforms would also be important (if you care) since that would impact libraries that can be used as well as ECMAScript version to target.

Oh, hey, just noticed this in the command line help:

Currently unavailable/awaiting PR:
xlsx: https://www.npmjs.com/package/xlsx
xls:  https://www.npmjs.com/package/xlsjs
xml:  https://www.npmjs.com/package/xml2js

Is that true?  I want to add those formats eventually, but they are also problematic so would defer if they currently don't work anyway.

I think most people just use the CLI - at least that was the intention for the tool. The readme only mentions to look up the js for the api. If possible I think the CLI parameters should be kept compatible.
I don't have plans at the moment for any-json so I think it's better to have some breaking changes than to have it become obsolete. If you'd rather do this in your own repo I can mark this obsolete and include a link.
As for versions/targets etc. - I think maintaining < ES6 makes no sense for a nodejs project.

Thanks for being receptive and responsive to this!

If possible I think the CLI parameters should be kept compatible.

I'm willing to provide a legacy parsing facility that would make the old parameters work.  However, the one holdout I have is the -opt parameter.  I really don't want to directly expose the underlying library's options configuration because doing so lessens the abstraction any-json provides, making it much more difficult to change an underlying library if there is ever a want/need.  I'm fine adding more options to support things, I just would want to build a layer of indirection to decouple in interface from the underlying type (and hopefully only expose a minimum surface area of configuration).
If supporting everything other than -opt is an acceptable compromise, I will get on implementing that and I think we can move forward.

I don't have plans at the moment for any-json so I think it's better to have some breaking changes than to have it become obsolete.

I prefer not to needlessly create competing libraries which is why I have pursued "upstreaming" this even though it is well outside of what I would normally consider appropriate for a PR (tbh, I didn't realize how deep I would go when I started).
If we fork, I expect my fork would be used by the things I build on it, which from a public standpoint is probably just pajv.  Honestly, any-json is important tool but still a bit of a "niche" area so I am not sure how many direct users I would end up with, or if people are more likely to find the more established any-json.

If you'd rather do this in your own repo I can mark this obsolete and include a link.

If we agree on a point where this can be merged, it would be good to then have more access so I can merge new features without needing to take up your time.  Also, things like Travis CI and npm publishing will need to be set up, I'm fine taking on all that work but it will take some coordination on permissions.  I'd be find working out of a repository under your user.  Though, as an alternative to moving development to a repository under my user (assuming the non-forked scenario), I would propose moving this repo to an organization (so issues are carried over) and we both would have access (@json-schema-everywhere would be an option, or it looks like @any-json is available for creation).

As for versions/targets etc. - I think maintaining < ES6 makes no sense for a nodejs project.

Cool, someday if I am feeling adventurous, I might look at making it run in a web browser (most of the pieces support it), but I really wasn't looking forward to learning how to do that right at this moment.

Thanks for being receptive and responsive to this!

It seems that you are doing all the work at the moment so the least I can do is support you with this.

If supporting everything other than -opt is an acceptable compromise, I will get on implementing that and I think we can move forward.

I'm OK with that. I only added it because I wasn't sure of the use cases of the different formats.

I prefer not to needlessly create competing libraries which is why I have pursued "upstreaming" this even though it is well outside of what I would normally consider appropriate for a PR (tbh, I didn't realize how deep I would go when I started).

I have to admit that I was a bit surprised by your PR :)

If we agree on a point where this can be merged, it would be good to then have more access so I can merge new features without needing to take up your time. Also, things like Travis CI and npm publishing will need to be set up, I'm fine taking on all that work but it will take some coordination on permissions. I'd be find working out of a repository under your user. Though, as an alternative to moving development to a repository under my user (assuming the non-forked scenario), I would propose moving this repo to an organization (so issues are carried over) and we both would have access (@json-schema-everywhere would be an option, or it looks like @any-json is available for creation).

Sounds great - if it's OK for you I'll move this to @any-json, give you equal permissions and connect Travis. I've never done this for npm but I guess it should be possible to transfer the package to a new user?

I'm OK with that. I only added it because I wasn't sure of the use cases of the different formats.

Sweet!! I'll put building that on my TODO list.  I expect I will be able to get to it sometime this week.

I have to admit that I was a bit surprised by your PR :)

The beginnings were humbler (#3, #4), but by the time I realized where I was going I recognized there was no point supporting those PRs if I ended up forked anyway :)

Sounds great - if it's OK for you I'll move this to @any-json, give you equal permissions and connect Travis. I've never done this for npm but I guess it should be possible to transfer the package to a new user?

Works for me! With npm, the repository link will need to be changed in package.json, but if if you use GitHub's move functionality, a redirect will be set up for the current url so nothing will be broken.  We will just want to make sure to change the URL for the next release.
Regarding transferring the npm package, I don't think that will be necessary.  If you sign in to NPM and go to the any-json page you should be able to add me as a Collaborator on the right-hand side.  I am adamvoss there too and this is my user page if it happens to need that.

I've created any-json and moved the repo. You should have received an invite.
Travis should work (https://travis-ci.org/any-json/any-json) but doesn't show PRs yet (maybe on the next commit).
I've also added you on npm. Let me know if you run into any troubles!

I created a classic branch so you can merge to master when you are ready.

@laktak, I added the legacy argument parsing so merged it since you said that was okay.  All that it should take (can't test with out actually releasing) to publish to npm is to push 3.0.0 tag at the current HEAD, but I held off in case you wanted to review or check anything before it gets released.

Hi Adam! The classic version was able to processes stdin, when you specified a format:
echo '{key:1}'|node out/lib/run.js -format=hjson
too few arguments: please specify the file to convert
for help use 'any-json -?

Would it be possible to add that back in before you publish?
Otherwise I think it looks good! Thanks!


Provide storage options to fsspec

Thanks for this super useful tool! ❤
Is there a way to provide fsspec storage_options, to browsr? Specifically I would like to access an s3 bucket with {"anon": True} as in:
storage_options = {"anon": True}
UPath("s3://recount-opendata/", **storage_options)

Cheers,
Andreas 😃

Great idea @ap--, this will get released momentarily:
browsr s3://recount-opendata -k anon=True

:tada: This issue has been resolved in version 1.15.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

Thank you for the quick turnaround 😊


regression: v1.2.12 fails to upload to s3

the latest s3 client produces an error:
[15] [S3]: Failed to upload blob d4b1d4ea6d84b0229bce7cf6806b0bb3470489ab8205a13f75cfe518fa7/10ea15e05c418d85e87762fa60afb9942a4d4ca1e: No valid endpoint provider available.

see https://github.com/adobe/helix-mediahandler/pull/80

problem was a mismatched @aws-sdk/util-enpoints originating from an older helix-deploy....


Allow custom texture atlasing

Currently the gui system relies on Unity's built-in sprite atlasing.  This causes several limitations:

You must use sprites for your gui, which can cause a bunch of different problems.  Normal maps?  Textures for non-sprite meshes?
You cannot do things like have 1 set of textures that get mapped to the same atlas coordinates as a different set of textures.  (A simple example is an Albedo texture and a Normal map texture both being mapped to the same uv coordinates).
You have no hope of uploading new textures at runtime!

A non-issue with the new multi-renderer solution.


Message about ability to comment directly via GitHub for Utterances

Utterances is nice to leverage GitHub as a storage for comments, however, not all people are happy to have to authorize the Utterances bot to put comments everywhere on GitHub on their behalves.
This PR adds a message below the comment iframe with the information where the comments can be placed directly. It points to the generic configured issues link for site or (if utterances_issue_id: X is defined for a given page) also points directly to the particular issues.
I (re-)use my custom CSS classes here, so you would probably want to add some own.
Sample appearances:

Btw, what is also nice, it works also if external scripts (for utterances) are blocked in the browser.

Ok, this could be good information for the visitors.
But it needs some changes because we have to consider multi-languages.
Thanks anyway!


update gpt 4 turbo

Updated GPT-4 Turbo from the preview version to the production version.

are we not supporting gpt-4-turbo-preview?
or we can add new modal on top gpt-4-turbo and keep preview as well.

Hey @fbec76 , like @tim13246879 seems to explain, I had an issue caused by this change. Chatbot UI was not working at all for me. Checked the commit history and saw this change. I put two and two together and changed my selected model from gpt-4-turbo-preview to gpt-4-turbo and it worked. Here's a replay of what happened. After I changed it gpt-4-turbo-preview  was no longer an option so it must've been cached or something, or maybe what @tim13246879 says. Don't have too much time to look into it now but this recording should be helpful.
https://jam.dev/c/534fea88-6411-41ed-b9eb-9b95f47b7fcf

@tim13246879 ,
you are right with all of your points.
We should revert this MR and add the production model as a new model to the preview one.
So we ensure the support of preview chats and functionality.
So, @mckaywrigley please revert this MR!


#423 Fixed accidentally swiping back on newer Android devices when tr…

Fixed accidentally swiping back on newer Android devices when trying to resize the crop window.
Some newer phones with Android 10 or newer allow you to remove the three navigation buttons and use a gesture bar instead. You're supposed to go back by swiping the left or right edge of the screen inwards. When the crop window is near the edge and you try to resize it you often accidentally swipe back instead.
This was fixed by setting systemGestureExclusionRects. Since Android allows only a max of 200dp to be excluded vertically this is divided among the corners and middle of the crop window (so 3 zones).
To reproduce:

use a device or emulator with gesture navigation enabled (at least Pixels support this)
position crop window to left and/or right edge of the screen
resize by grabbing a corner or the middle of the left or right edge
it should no longer show trigger a go back gesture like before

Check list for the Code Reviewer:

[x] CHANGELOG
[ ] README
[ ] Wiki
[ ] Version Number

I fixed the spaces and pushed it, do I need to do something here to trigger a check?

I fixed the spaces and pushed it, do I need to do something here to trigger a check?

I need to trigger, is a github protection on public repositories because of people changing the CI to mine cryptocoins

@Janneman84 look good from my side, some lint issues. Check the contributing guide to run the lint tool and fix =D

More two points

We need to add the new option in our sample apps
And in our feature list

Oops forgot the one space, fixed it now.
However this thing is not an option. It's a fix to an issue that always works. I can't think of any practical reason why you would not want it to do what it does. Therefore it's not an option and therefore needs not to be added to the feature list.

Nicely done @Janneman84 !


Add (and run) pre-commit hooks for enforcing basic coding standards

Pros:

Everyone will have one standard pep8 style thanks to black
line endings, tabs vs spaces all of those problems are thing of the past
very easy to add mode hooks supported by the pre-commit framework

Cons:
Just one, but it's big:
There's never a "good time" to do something like this, all existing PRs must be rebased after merge and the hooks run for example but I doubt there's ever going to be a time when there are not several of those in process.

The line width is set to 80 as is/was the flake8 config but in these days or large monitors I could argue for at least 120 chars  instead of the oldskool default text terminal width.

Thanks for your efforts on this, but I can't really see us merging this given that we are a long existing project.
The benefits are minor, if at all.

We don't get that many PRs where this is a large issue. At most it requires one extra commit to fix potential issues, but with any decent editor it should flag PEP8 issues well before you commit. And for core-devs it should be second nature to fix PEP8 issues before committing or creating PRs.
Besides PEP8 issues, we have rarely had to correct style issues in incoming PRs.
We are a small team so there's very little strain in regards to style issues.

But the cons are enormous.

We are a long existing project, to suddenly change to an entirely different formatting scheme would require (much) more work than the status quo and there would need a good reason for it, which I don't see presented and I'm not aware of a strong reason.
It changes the complete code-base git history. This kind of change is almost never justified, especially if it's because of style changes. Style changes should happen in the background and not get in the way, otherwise, they are rarely the effort.
We won't be able to accept PRs generated from commits created in github's user interface as the style hook would not have run. To fix this we'd need to run a special bot that fixes all commits before the PR is merged. This adds further complexity and I'm not inclined to trust a bot to do such automatic changes on our code base without good reason for the trust.
Similarly, what happens if a core-dev makes a commit and pushs, without going through a PR, but also doesn't run the hook. The next time a person commits their code would be re-written in a unrelated PR. There has to be good reason to force us to be disciplined to never accept even a single change without running through black first and I don't see one presented.
Commit hooks are slow. I don't even run our pep8 hook since I rely on PyCharm to point out PEP8 issues. So this will probably slow down commits.

If this was a new project, we'd should consider whether black is a good fit for us. But given what I mentioned, I don't think black is for us.

also a good reference about pep8 and code quality
https://www.youtube.com/watch?v=wf-BqAjZb8M
Pep8 doesn't need to be a hard, enforced rule, it's a style guideline, and that's good like this imho.

Pep8 doesn't need to be a hard, enforced rule, it's a style guideline, and that's good like this imho.

I'm assuming by like this you mean like it is currently in Kivy and that you agree with me :)

In general I get where you are coming from, just some specific comments:

It changes the complete code-base git history

Which is why there's the ignore-revs -file, or is there some other reason than git-blame giving the "wrong commit"
for a change for this being a problem ?

So this will probably slow down commits.

You already have the flake8 hook there (or is no-one actually using the hook if you say it slows you down?) and black feels faster to me (I haven't done any actual timing comparisons).
Technically yes; any hook will slow down commits from not having a hook at all, whether it actually matters is the important question (having the commit take an extra second or few is not a problem IMO)

Similarly, what happens if a core-dev makes a commit and pushs, without going through a PR, but also doesn't run the hook.

This you should simply not do. It took me while to "learn" but now even in my own repos where I'm the only one working on the code I always work in a branch and always go through a PR. Having a pre-commit hook check for this was a major help in teaching myself this bit of discipline.

We won't be able to accept PRs generated from commits created in github's user interface as the style hook would not have run.

Do you actually get these ? and what if those happen to not pass your flake8 check in CI ? Do you override the CI or add a manual commit to fix the issue, how is adding a commit to fix the issue different from manually running black and adding that commit to fix the issue ? Sure the black thing could be automated (unlike the manual fix for flake8) but there is no need to.

to suddenly change to an entirely different formatting scheme would require (much) more work than the status quo

The beauty of Black is that it's automatic, only extra work is git adding the file again and re-running git commit if the hook changed the file. But as Black itself says it's "opinionated", not everyone does not agree with the choices they made. I personally find it very handy having one uniform style everywhere (down to details like single vs double quotes, one of the things I disliked about Black at first).
It's also way easier for new devs to get into the project when there's an autoformatter for the specific flavour
of pep8 the project uses, if they happen to be used to some detail being slightly different they don't need
to learn to do it differently for this particular project and can focus on the actual program logic instead of
formatting details. Your current flake8 config for example disagrees with black on some details, as I'm used to writing
in black style this means I will have to go back and change things that were second nature to me when the flake8 check fails... For those used to the current flavour the autoformatter will fix things automagically and thus no conscious effort required to change their habits.
non -Black stuff
Now onto the the other hooks configured, how do you feel about them ? I can make another PR where black isn't used but the other checks/fixes (branch checking, whitespace normalization, executables having shebangs) are still done. Maybe that flake8 as well check if it's not "too slow".
There were some whitespace normalizations and a whole bunch of files that should not have been be executable (and some more that maybe could be but then they would have to have shebangs added too), those checks at least are very quick.
Basically all of these checks are like any other automated testing, when they're there the developer can focus on thinking about the code logic instead of possible regressions in small details.

Although I like intention behind this PR, it's WAY too noisy to expect a meaningful code review. Automatic refactors when the changes are entirely cosmetic ("" in place if '') does not really add value. But most has already been said. @rambo  The effort is appreciated and the intention is good, but please consider less extreme approaches. Pragmatism is a virtue...

Pep8 doesn't need to be a hard, enforced rule, it's a style guideline, and that's good like this imho

Yet your CI enforces it (which is good IMHO), just pointing out the contradiction here.

Automatic refactors when the changes are entirely cosmetic ("" in place if '') does not really add value

Agreed, the value would come from going forward with the autoformatter making sure everyone is always in same style without having to spend conscious effort in flavour details.
anyway no for Black. I would suggest figuring out how to have something (autopep8) that auto-formats to your preferred style anyway. As stated above so that it's way easier for people used to different flavour of pep8 to contribute since a flavour of pep8 is enforced by CI.
Then how about those other things, as seen above: there's a mess of files marked executable that should not be, there's mixed tabs vs spaces usage etc, if I setup pre-commit for those (and flake8) is that going to be wasted effort ? That will again result in "purely cosmetic" changes in a largish commit in the history (though strictly speaking it's not mandatory to do that cleanup at this point unless CI is set up to check for those mistakes as well) but that's why git added the possibility to ignore revisions in git blame
meanwhile I'll see what I can do about the side effects of import kivy starting with overriding sys.stderr and the root logger.

Hmm.. It's difficult. I really agree in principle, and I like what you are trying to do. Perhaps put your thoughts into a new PR and request me as a reviewer? Thanks.

Or re-open this. There are valid discussions and points here. Up to you.

Basically, anything that changes existing code on mass for style changes will likely not get accepted. However, optional hooks that fix any PEP8 issues by re-writing, instead of simply complaining about it like our current hook is welcome.
The way to move forward is to have hooks that only re-write code immediately around any changes made in a particular commit. Not to go back in history and make changes to unrelated (of a given PR) parts of the code.
I frequently edit code and create PRs from GitHub's user interface, so any mandatory hooks that re-write code would just get in the way (especially if a later PR would then have to re-write the changes, even if PEP8 passes, just to adhere to a style). Our current policy of adhering to mostly PEP8 issues, but no major style prefs, are easy to follow without major tooling. And the CI indicates any PEP8 issues in the PR to be fixed manually.
The video linked by @tshirtman is exactly how I view style issues.

Oh, and about the shebangs, yeah, a PR to fix that should be fine, although is that a problem worth fixing in existing files?


[BUG] Import excel does not show all information

Hi guys,
I like the package very much, but now i am experiencing some problem by reading one external excel file.
I need to read only the first sheet of the file and import some of the values into my database. Here is how i am reading the sheet:
Excel::load($saved_file, function($reader) {
$sheet = $reader->first();
$results = $sheet->toArray();
print_r($results);
});
but i only get that as output:
Array ( [0] => Array ( [day_ahead_scheduling] => Carbon\Carbon Object ( [date] => 2016-09-30 00:00:00.000000 [timezone_type] => 3 [timezone] => Europe/Berlin ) [solved_with_load_declarations] => 1 [0] => ST DV P ) )
which is exactly the last cell of the first line.
Here is a screenshot how the excel file looks like:

@perffy by default (when config item force_sheets_collection is set to false) reader methods get() and all() will return a collection of rows so $reader->first() will return the first row of that collection
so you have two choices:

set force_sheets_collection to true in the configuration to return a collection of sheets
or try this:

    Excel::load($saved_file, function($reader) {
        var_dump($reader->sheet(0)->toArray());
    });

Thanks @stephanecoinon . Helped me a lot !

@stephanecoinon Could you please help me out  how to read ## excel workbook(xls) using laravel 4.2
My code is like given below
Excel::load($pathName, function($reader) use (&$excel) {
foreach ($reader->toArray() as $row) {
echo ""; print_r($excel); echo "";
}
});exit;
its gives error like :
{"error":{"type":"ErrorException","message":"Undefined offset: -1","file":"E:\xampp\htdocs\multichannel_exportv2
\vendor\phpoffice\phpexcel\Classes\PHPExcel\Reader\Excel5.php","line":918}}

@kunurashmi is $pathName referring to a valid file path?
which version of laravel-excel do you have?
why not output $row in the foreach instead of $excel?


Add inertia and silhouette score progress bars for neighborhood analysis notebook

What is the purpose of this PR?
Closes #566. The inertia and silhouette score computations take a while to complete, so they should have progress bars.
These should be the last progress bars that need to be added to ark.
How did you implement your changes
Use tqdm.notebook as implemented in other modules.

Did you run both notebook cells to make sure formatting on TQDM displays as expected?

They are displaying correctly.


Build Issue

.next/types/app/api/auth/[...nextauth]/route.ts:8:13
Type error: Type 'OmitWithTag<typeof import("F:/DemoProject/EcommerceApp/app/api/auth/[...nextauth]/route"), "DELETE" | "POST" | "PUT" | "config" | "generateStaticParams" | "revalidate" | "dynamic" | "dynamicParams" | ... 7 more ... | "PATCH", "">' does not satisfy the constraint '{ [x: string]: never; }'.
Property 'handler' is incompatible with index signature.
Type 'any' is not assignable to type 'never'.
6 |
7 | // Check that the entry is a valid entry

8 | checkFields<Diff<{
|             ^
9 |   GET?: Function
10 |   HEAD?: Function
11 |   OPTIONS?: Function
Linting and checking validity of types

Hi! I'm sorry, but I didn't try to build this project. There might be errors in the building process that you need to solve. In your case, you've encountered a TypeScript type error. It suggests that the types in your API route are not correctly aligned with what Next.js expects. If you find a solution please post it here.

Updated route.ts
import NextAuth, { NextAuthOptions } from "next-auth";
import { Account, User as AuthUser } from "next-auth";
import GithubProvider from "next-auth/providers/github";
import CredentialsProvider from "next-auth/providers/credentials";
import GoogleProvider from "next-auth/providers/google";
import bcrypt from "bcryptjs";
import prisma from "@/utils/db";
import { nanoid } from "nanoid";
const authOptions: NextAuthOptions = {
providers: [
CredentialsProvider({
id: "credentials",
name: "Credentials",
credentials: {
email: { label: "Email", type: "text" },
password: { label: "Password", type: "password" },
},
async authorize(credentials: Record<string, string> | undefined): Promise<AuthUser | null> {
if (!credentials?.email || !credentials?.password) {
return null; // Return null if credentials are missing
}
    try {
      const user = await prisma.user.findFirst({
        where: {
          email: credentials.email,
        },
      });

      if (user && user.password) {
        const isPasswordCorrect = await bcrypt.compare(credentials.password, user.password);

        if (isPasswordCorrect) {
          return user; // Return the user if password is correct
        }
      }

      return null; // Return null if the user is not found or password is incorrect
    } catch (err) {
      console.error("Error during authorization:", err);
      return null; // Ensure we return null on error
    }
  },
})

],
callbacks: {
async signIn({ user, account }: { user: AuthUser; account: Account | null }): Promise {
// Check if account is null
if (account === null) {
console.log("Account is null.");
return false; // Return false if account is null (sign-in fails)
}
  // Check for 'credentials' provider
  if (account.provider === "credentials") {
    return true; // Return true if the provider is 'credentials'
  }

  // Handle OAuth providers (GitHub, Google)
  if (account.provider === "github" || account.provider === "google") {
    try {
      const existingUser = await prisma.user.findFirst({ where: { email: user.email! } });

      if (!existingUser) {
        await prisma.user.create({
          data: {
            id: nanoid(),
            email: user.email!,
          },
        });
      }

      return true; // Return true if the user sign-in was successful
    } catch (err) {
      console.error("Error saving user", err);
      return false; // Return false if there was an error
    }
  }

  return true; // Return true by default if no specific provider is matched
}

}
};
const handler = NextAuth(authOptions);
export { handler as GET, handler as POST };


Add MIT + Apache-2.0 dual license

I didn't know anything about licensing when I created this project, but since others are finding it useful I'd like to add the MIT + Apache-2.0 dual license to the project.
@per1234, @Dzitu, @CodingGhost, you have each merged code to this repo, so could you please reply in a comment saying you agree for your contributions to also be MIT + Apache-2.0 dual-licensed? Something along the following lines:

I agree for my contributions to be dual-licensed under MIT + Apache-2.0.

This is standard for an open-source project, and just means that you are explicitly allowing others to use this project and the code you've added to it freely. Thanks!
Pending responses:

[ ] @per1234
[x] @Dzitu
[x] @CodingGhost

sorry, completely overread the middle part and just clicked merge.
I agree for my contributions to be dual-licensed under MIT + Apache-2.0.

I agree for my contributions to be dual-licensed under MIT + Apache-2.0.

@CodingGhost no worries, I went and double-checked and @per1234 only touched the keywords.txt, which does not have any bearing on the behavior of the library, only syntax highlighting in Arduino IDE. I think we should be fine to leave this and if they're around they can reply to this if they wish ❤

I agree for my contributions to be dual-licensed under MIT + Apache-2.0.
I also relinquish any copyright claim I might have on my trivial contribution so you are free to make any future changes to the licensing of the library without first obtaining my permission.


KYLIN-4197 Fix not find KYLIN_CONF or KYLIN_HOME when build dictionary

Can one of the admins verify this patch?

Can one of the admins verify this patch?

CI passed


Split entity creation + custom model creation in ProcessSubmission functions

Some refactoring work after the recent submission handling updates: It will be better long-term if we handle the entity + entity value creation separately from the custom data model creation.

This issue has been resolved by #26.
I will close this issue now.


Pin-to-Start icon is ugly

First of all I want to say that ScreenToGif is an amazing and really useful lignt-weight recording app, I just love it! That being said, I found a little inconvenience. When I search for ScreenToGif in the Start menu, it has a tiny little cutie icon with a smiling screen. But when I pin the app to Start, an ugly icon with S>G in a weird font, different background color and almost no padding appears. I mean I want to have ScreenToGif pinned to my Start, but this really breaks all the work I've put into making my Start a nice place.

Would it be possible to change this icon to the cute one and add some padding so that it would look consistent with the rest of Windows UI? Thanks! 🙂

Well, I don't think that this is ugly. But to each their own..

The font selection could be I think objectively better. After all the curvy letters don't fit the whole "edgy"/"boxy" feel of the rest of the application 🙂

I would need help to design a new icon. I'm thinking of getting a new one.

Did you consider using the application's default icon, just giving it transparent background and bigger padding? I don't find anything bad about it.

I'm considering keeping the same base idea (a screen), but using fluent design concepts (shadow, depth).


Can't login with Android app

Hello All,
I ma trying to login via android app available in google play and still getting "login failed". I am providing login with convention<EMAIL_ADDRESS>and password created previously which working when login via web browser. Anyone help with this issue ?
Thank you!

Perhaps there is a special character in your password that is not being handled correctly. Can you log in with your browser, and change the password to something 'weak' just to validate? If it does end up being a character causing the issue please let me know what it is.
Thank you for reporting this!

Hello,
Finally I was able to solve the issue which was related to certificate and SSL conection. Now it works fine.. ;-)
Thenk you for your help!

great you have it working. thanks for using this project!


Hello, can you release the trained model?

it is ok.
now, it is released.
Charmve, Maiwei AI Lab
gtwell<EMAIL_ADDRESS>于2020年11月17日周二 上午9:40写道：

—
You are receiving this because you are subscribed to this thread.


Compilation errors

Hi!
I got interested in TensorSketch from your talk at Recomb (congrats, btw). I wanted to test if Tensor-Sketching suits a pipeline I am currently building.
Unfortunately when I try to compile it I get the following errors:
[  2%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_reporting.cc.o
[  5%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags.cc.o
[  7%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_completions.cc.o
[ 10%] Building CXX object third_party/murmur_hash/CMakeFiles/murmur_lib.dir/murmur_hash3.cpp.o
[ 12%] Building CXX object CMakeFiles/phylogeny_lib.dir/phylogeny/upgma.cpp.o
[ 15%] Building CXX object third_party/googletest/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
[ 17%] Linking CXX static library libmurmur_lib.a
[ 17%] Built target murmur_lib
[ 20%] Building CXX object CMakeFiles/sketch_lib.dir/sketch/hash_base.cpp.o
In file included from /home/sivico26/Programs/Project2020-seq-tensor-sketching/phylogeny/upgma.cpp:1:
/home/sivico26/Programs/Project2020-seq-tensor-sketching/phylogeny/upgma.hpp:13:5: error: ‘uint32_t’ does not name a type
   13 |     uint32_t left, right;
      |     ^~~~~~~~
compilation terminated due to -Wfatal-errors.
make[2]: *** [CMakeFiles/phylogeny_lib.dir/build.make:76: CMakeFiles/phylogeny_lib.dir/phylogeny/upgma.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:259: CMakeFiles/phylogeny_lib.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 23%] Linking CXX static library libgflags_nothreads.a
[ 23%] Built target gflags_nothreads_static
[ 25%] Linking CXX static library libsketch_lib.a
[ 25%] Built target sketch_lib
[ 28%] Linking CXX static library ../../../lib/libgtest.a
[ 28%] Built target gtest
make: *** [Makefile:146: all] Error 2

Do you know what might be triggering this behavior? It might simply be missing dependencies, but those are not clearly specified, so I do not what could be missing.
I got this error using gcc (11.1.0), cmake (3.21.2), Make (4.3)  and Python (3.9.6) running on Manjaro 21.1.2.
Cheers.

That file was missing an include. Can you try now?
On Tue, 7 Sept 2021 at 23:18, Simón Villanueva Corrales <
@.***> wrote:

Hi!
I got interested in TensorSketch from your talk at Recomb (congrats, btw).
I wanted to test if Tensor-Sketching suits a pipeline I am currently
building.
Unfortunately when I try to compile it I get the following errors:
[  2%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_reporting.cc.o
[  5%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags.cc.o
[  7%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_completions.cc.o
[ 10%] Building CXX object third_party/murmur_hash/CMakeFiles/murmur_lib.dir/murmur_hash3.cpp.o
[ 12%] Building CXX object CMakeFiles/phylogeny_lib.dir/phylogeny/upgma.cpp.o
[ 15%] Building CXX object third_party/googletest/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
[ 17%] Linking CXX static library libmurmur_lib.a
[ 17%] Built target murmur_lib
[ 20%] Building CXX object CMakeFiles/sketch_lib.dir/sketch/hash_base.cpp.o
In file included from /home/sivico26/Programs/Project2020-seq-tensor-sketching/phylogeny/upgma.cpp:1:
/home/sivico26/Programs/Project2020-seq-tensor-sketching/phylogeny/upgma.hpp:13:5: error: ‘uint32_t’ does not name a type
13 |     uint32_t left, right;
  |     ^~~~~~~~

compilation terminated due to -Wfatal-errors.
make[2]: *** [CMakeFiles/phylogeny_lib.dir/build.make:76: CMakeFiles/phylogeny_lib.dir/phylogeny/upgma.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:259: CMakeFiles/phylogeny_lib.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 23%] Linking CXX static library libgflags_nothreads.a
[ 23%] Built target gflags_nothreads_static
[ 25%] Linking CXX static library libsketch_lib.a
[ 25%] Built target sketch_lib
[ 28%] Linking CXX static library ../../../lib/libgtest.a
[ 28%] Built target gtest
make: *** [Makefile:146: all] Error 2
Do you know what might be triggering this behavior? It might simply be
missing dependencies, but those are not clearly specified, so I do not what
could be missing.
I got this error using gcc (11.1.0), cmake (3.21.2), Make (4.3) and Python
(3.9.6) running on Manjaro 21.1.2.
Cheers.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ratschlab/Project2020-seq-tensor-sketching/issues/47,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOYQLGC3SE7KRMC5QA5BK3UAZ6TZANCNFSM5DTGWQAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi, sorry for the delay. This is what I got:
[  2%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags.cc.o
[  5%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_reporting.cc.o
[  7%] Building CXX object CMakeFiles/phylogeny_lib.dir/phylogeny/upgma.cpp.o
[ 10%] Building CXX object third_party/murmur_hash/CMakeFiles/murmur_lib.dir/murmur_hash3.cpp.o
[ 12%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_completions.cc.o
[ 15%] Building CXX object third_party/googletest/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
[ 17%] Linking CXX static library libmurmur_lib.a
[ 17%] Built target murmur_lib
[ 20%] Building CXX object CMakeFiles/sketch_lib.dir/sketch/hash_base.cpp.o
In file included from /home/sivico26/Programs/Project2020-seq-tensor-sketching/phylogeny/upgma.cpp:1:
/home/sivico26/Programs/Project2020-seq-tensor-sketching/phylogeny/upgma.hpp:17:36: error: ‘numeric_limits’ is not a member of ‘std’
   17 | constexpr uint32_t NO_CHILD = std::numeric_limits<uint32_t>::max();
      |                                    ^~~~~~~~~~~~~~
compilation terminated due to -Wfatal-errors.
make[2]: *** [CMakeFiles/phylogeny_lib.dir/build.make:76: CMakeFiles/phylogeny_lib.dir/phylogeny/upgma.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:259: CMakeFiles/phylogeny_lib.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 23%] Linking CXX static library libsketch_lib.a
[ 23%] Built target sketch_lib
[ 25%] Linking CXX static library libgflags_nothreads.a
[ 25%] Built target gflags_nothreads_static
[ 28%] Linking CXX static library ../../../lib/libgtest.a
[ 28%] Built target gtest
make: *** [Makefile:146: all] Error 2

I think it is mostly the same output.

No, that's a different issue with gcc, which I now fixed. Try now, it
should work. Otherwise try to build only the tensor sketching library with:
make -j sketch
On Sat, 11 Sept 2021 at 01:30, Simón Villanueva Corrales <
@.***> wrote:

Hi, sorry for the delay. This is what I got:
[  2%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags.cc.o
[  5%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_reporting.cc.o
[  7%] Building CXX object CMakeFiles/phylogeny_lib.dir/phylogeny/upgma.cpp.o
[ 10%] Building CXX object third_party/murmur_hash/CMakeFiles/murmur_lib.dir/murmur_hash3.cpp.o
[ 12%] Building CXX object third_party/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_completions.cc.o
[ 15%] Building CXX object third_party/googletest/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
[ 17%] Linking CXX static library libmurmur_lib.a
[ 17%] Built target murmur_lib
[ 20%] Building CXX object CMakeFiles/sketch_lib.dir/sketch/hash_base.cpp.o
In file included from /home/sivico26/Programs/Project2020-seq-tensor-sketching/phylogeny/upgma.cpp:1:
/home/sivico26/Programs/Project2020-seq-tensor-sketching/phylogeny/upgma.hpp:17:36: error: ‘numeric_limits’ is not a member of ‘std’
17 | constexpr uint32_t NO_CHILD = std::numeric_limits<uint32_t>::max();
  |                                    ^~~~~~~~~~~~~~

compilation terminated due to -Wfatal-errors.
make[2]: *** [CMakeFiles/phylogeny_lib.dir/build.make:76: CMakeFiles/phylogeny_lib.dir/phylogeny/upgma.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:259: CMakeFiles/phylogeny_lib.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 23%] Linking CXX static library libsketch_lib.a
[ 23%] Built target sketch_lib
[ 25%] Linking CXX static library libgflags_nothreads.a
[ 25%] Built target gflags_nothreads_static
[ 28%] Linking CXX static library ../../../lib/libgtest.a
[ 28%] Built target gtest
make: *** [Makefile:146: all] Error 2
I think it is mostly the same output.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ratschlab/Project2020-seq-tensor-sketching/issues/47#issuecomment-917284381,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOYQLHR3VIA62ISQMA6CUDUBKIKPANCNFSM5DTGWQAA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Sorry again, apparently notifications are not my thing.
Compilation this time worked, so thank you for that. I will try the program tomorrow and will come back to you if I get into trouble.
Thank you and cheers!


[10.1.x] ISPN-11539 Documentation edits and corrections

https://issues.redhat.com/browse/ISPN-11539

integrated! thanks @oraNod !


Remove code smells

:white_check_mark: Build TheIdServer 1.0.0 -user-ole0088 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/a4f3fe7265 by @aguacongas)

:white_check_mark: Build TheIdServer 1.0.0-user-ole.1+88.build.281 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/ebec547790 by @aguacongas)


[Integration][Jenkins] Improvements to Jenkins integration

Description
What

Add aborted to Jenkins job status enum. And update JQ mapping
Add ABORTED to jenkins build status enum.
Give url format to jenkins job and build url properties

Why

The aborted job status allow for visibility on jobs that are in aborted state
The ABORTED build status allow for visibility on builds that are being aborted
The URL as base string format look terrible on the UI. With the url format it looks like a nice button

How

Changed the blueprint json for Jenkins

Type of change
Please leave one option from the following and delete the rest:

[X] Non-breaking change (fix of existing functionality that will not change current behavior)

Thanks for the updates @jortegac please add the CHANGELOG.md so we track this improvements. Also bump the integration version in the pyproject.toml

Thanks for the updates @jortegac please add the CHANGELOG.md so we track this improvements. Also bump the integration version in the pyproject.toml

Done, @PeyGis . Lemme know if any other changes are needed

Hey @jortegac Thank you so much for the contribution 🥇,
We'll go over it ASAP, can you pease in the meantime update your branch?
I tried to update it for you but I cannot update your branch directly since it is a fork


Nuget package contains the sources

Hi,
I don't know if you still maintain this repository and specially the associated nuget package.
Since version 2.0 the package contains the source code instead of the binaries.
Regards.

Yeah, I just noticed the same after  I upgraded. Also the build seems to be failing. The project is probably abandoned.


vxlan interface always down , cause calico-node failed to add route for pods on other node

calico version: 3.11.2
k8s version: 1.17
I have a k8s cluster with 3 nodes  , which uses calico CNI .
2 calico  ippool is set up , both of them use vxvlan mode
# calicoctl get ippool -o wide
NAME                      CIDR            NAT    IPIPMODE   VXLANMODE   DISABLED   SELECTOR
default-ipv4-ippool       <IP_ADDRESS>/16   true   Never      Always      false      all()
kube-system-ipv4-ippool   <IP_ADDRESS>/16   true   Never      Always      false      all()

the strange thing happened ,  the vxlan.calico interface on a node always stay down , and I tried to set it up , but after about 3seconds , this tunnel interface goes down again . That make calico-node failed to add route for other 2 node  .
After I delete the daemonset calico-node, I can set the vxlan.calico interface up  . However, I apply the daemonset calico-node  again , the vxlan.calico interface on the same node begin to stay down again , and I could not set it up agian . So I thinkg it is should that calico-node found something wrong and always make the  vxlan.calico interface down
However other 2 node2 work fine
BTW, my other Cluster with same calico configuration , has no this issue
Finally , I found a work-around way :  delete the tunnel interface , which trigger the calico-node recreate the tunnel interface,  then everything go to work fine
this cluster environment may scale up nodes or reinstall calico operation , Maybe the tunnel interface is created by previously with wrong VXLAN configuration for right now . So deleting it can trigger calico to regenerate right one
the calico-node log of the bad node is bellow
2020-02-21 13:51:39.739 [INFO][50] int_dataplane.go 849: Received interface update msg=&intdataplane.ifaceUpdate{Name:"vxlan.calico", State:"up"}
2020-02-21 13:51:39.740 [INFO][50] int_dataplane.go 962: Applying dataplane updates
2020-02-21 13:51:39.740 [INFO][50] int_dataplane.go 597: Linux interface state changed. ifaceName="vxlan.calico" state="down"
2020-02-21 13:51:39.745 [INFO][50] route_table.go 577: Syncing routes: adding new route. ifaceName="vxlan.calico" ipVersion=0x4 targetCIDR=<IP_ADDRESS>/26
2020-02-21 13:51:39.745 [WARNING][50] route_table.go 604: Failed to add route error=network is down ifaceName="vxlan.calico" ipVersion=0x4 targetCIDR=<IP_ADDRESS>/26
2020-02-21 13:51:39.745 [INFO][50] route_table.go 577: Syncing routes: adding new route. ifaceName="vxlan.calico" ipVersion=0x4 targetCIDR=<IP_ADDRESS>/26
2020-02-21 13:51:39.745 [WARNING][50] route_table.go 604: Failed to add route error=network is down ifaceName="vxlan.calico" ipVersion=0x4 targetCIDR=<IP_ADDRESS>/26
2020-02-21 13:51:39.745 [INFO][50] route_table.go 577: Syncing routes: adding new route. ifaceName="vxlan.calico" ipVersion=0x4 targetCIDR=<IP_ADDRESS>/26
2020-02-21 13:51:39.745 [WARNING][50] route_table.go 604: Failed to add route error=network is down ifaceName="vxlan.calico" ipVersion=0x4 targetCIDR=<IP_ADDRESS>/26
2020-02-21 13:51:39.745 [INFO][50] route_table.go 247: Trying to connect to netlink

the route table of the bad node is bellow , it only have local pod route , and miss subnet route for pods on other node
# ip r
default via <IP_ADDRESS> dev dce-mng proto static metric 100
default via <IP_ADDRESS> dev ens224 proto static metric 101
<IP_ADDRESS>/16 dev dce-mng proto kernel scope link src <IP_ADDRESS> metric 100
<IP_ADDRESS>/16 dev ens224 proto kernel scope link src <IP_ADDRESS> metric 100
<IP_ADDRESS>/16 dev parcel-vip proto kernel scope link src <IP_ADDRESS>
<IP_ADDRESS>/16 dev docker0 proto kernel scope link src <IP_ADDRESS>
<IP_ADDRESS> dev calia1e9256f877 scope link
<IP_ADDRESS> dev cali23d0198f573 scope link
<IP_ADDRESS> dev cali63579a15e5c scope link
<IP_ADDRESS> dev calie07fbc9b479 scope link

networkmanager has no configuration for this tunnel
# nmcli con show
NAME                 UUID                                  TYPE            DEVICE
Wired connection 1  a7eba6a4-1e06-3217-a476-8fb0326c9a38  802-3-ethernet  ens224
dce-mng             7adf786c-6968-4d2c-aba0-8f0e89606097  802-3-ethernet  dce-mng
docker0             d0d7ca77-316e-4260-8b52-8bf6a811ea3f  bridge          docker0

Expected Behavior

tunnel interface should stay up , and route should be added for pod on other nodes
Current Behavior

tunnel interface stay down , and pods on the bad node can not access pods on other nodes
Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

Calico version
Orchestrator version (e.g. kubernetes, mesos, rkt):
Operating System and version:
Link to your project (optional):

@weizhouBlue
Try to add the following to /etc/NetworkManager/conf.d/calico.conf
unmanaged-devices=interface-name:cali*;interface-name:tunl*;interface-name:vxlan.calico

After that restart the NetworkManager and check if the vxlan.calico interface comes up


Problem with central repo

Could not find artifact com.typesafe:config:jar:1.3 in central (https://repo.maven.apache.org/maven2)

I'm using Maven 3.3.3. Here is my dep:
    <properties>
        <typesafe-config-version>1.3</typesafe-config-version>
    </properties>
...
            <dependency>
                <groupId>com.typesafe</groupId>
                <artifactId>config</artifactId>
                <version>${typesafe-config-version}</version>
            </dependency>

Apologies for not replying earlier, I missed this one. I'm guessing you figured it out by now (I don't know the problem offhand).


Use pin_subpackage in run_exports

To be honest, I am not sure what is the difference w.r.t. to what was there before, but in any case the use of pin_subpackage seems to be more consistent with the rest of recipes in conda-forge .
Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@conda-forge-admin, please rerender

fyi @wolfv

Yep, that should be much better. Without the pin_subpackage it would only add libode to the run requirements, but without a lower or upper bound afaik.

Yep, that should be much better. Without the pin_subpackage it would only add libode to the run requirements, but without a lower or upper bound afaik.

Yes, the problem that I had in https://github.com/conda-forge/libignition-physics-feedstock/pull/12 was exactly that, where libode 0.16.0 got installed but dart actually needed libode 0.16.2 .

To avoid having only a single maintainer for the recipe, if you like @repagh I can also add myself as a maintainer.

Thank you, looks good. And yes, if @traversaro want to join as maintainer, fine.
Glad to see more people have a use for libode

Thanks @repagh ! I create a PR to add myself as mantainer to reduce the bus factor in https://github.com/conda-forge/libode-feedstock/pull/6 . Obviously I will wait for your opinion on all future PRs in any case!


Cassandra support for chat history

Cassandra support for chat history
Description

Store chat messages in cassandra

Dependency

cassandra-driver - Python Module

Before submitting

Added Integration Test

Who can review?
@hwchase17
@agola11

thanks @jj701! high level looks good, will take a closer look in a bit. could we add a simple example notebook to docs/modules/memory/examples/?

Added the Jupyter Notebook Example


Deploy an external dns instance per namespace.

Managed namespaces that opt-in to ingress need an instance of
external-dns running to manage the DNS for the correct NLB (namely the
NLB that corresponds to the ingressgateway Service).
⚠On deploy
Before the "apply" step of the pipeline runs, delete the existing external-dns installation in gsp-system.

I understand that what you've done here is just pull in the relevant parts of the external-dns chart into the gsp-cluster chart? Should we put some comments mentioning that it might need to manually updated in the future, and how that might happen?

@samcrang I've added a comment to the top of the external-dns yaml file. Is that sufficient?


[DO NOT MERGE] Auto PR to update dependencies of istio

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e.sh
392fd0889c3c40f8559eb05c8919c0c28ac01382
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Docker@2 failing to push image to ACR: Invalid clientid or client secret

Required Information
Entering this information will route you directly to the right team and expedite traction.
Question, Bug, or Feature?
Type: Bug
Enter Task Name:  Docker@2
Environment

Server - Azure Pipelines
Agent - Hosted

Issue Description
The task fails with the following error: unauthorized: Invalid clientid or client secret
Our task definition (simplified)
        - task: Docker@2
          displayName: Build an image, tag and push to ACR
          inputs:
            containerRegistry: SmartwyreDockerRegistryServiceConnection
            repository: $(ApiImageName)
            command: buildAndPush
            Dockerfile: 'api/**/Dockerfile'
            tags: $(Build.BuildId)

Variables come from a variable group that is linked to a key vault.
I've already verified the credentials have not changed by using docker login and the credentials (Admin user enabled) provided in "Access keys" of the container registry in the Azure portal.
Task logs
See attachment: docker_task_with_system_diagnostics.zip
Here is an edited version with the lines before the error occurred
2021-11-25T17:29:45.0631340Z The push refers to repository [***/***]
2021-11-25T17:29:45.0632280Z 39569ee41079: Preparing
2021-11-25T17:29:45.0633094Z 90b7f51a1c45: Preparing
2021-11-25T17:29:45.0634106Z e1d62c4f847c: Preparing
2021-11-25T17:29:45.0634945Z c5b1cb5df07f: Preparing
2021-11-25T17:29:45.0635797Z 06a27697d33a: Preparing
2021-11-25T17:29:45.0636616Z e76b6ebc067f: Preparing
2021-11-25T17:29:45.0637598Z 2780890f5f5a: Preparing
2021-11-25T17:29:45.0638392Z 2575f5a9476d: Preparing
2021-11-25T17:29:45.0639183Z 889d056e0cbb: Preparing
2021-11-25T17:29:45.0640197Z 1efa5a534480: Preparing
2021-11-25T17:29:45.0641170Z fdb8bc2a04c6: Preparing
2021-11-25T17:29:45.0642003Z a517aa267c33: Preparing
2021-11-25T17:29:45.0642819Z 1f474f0beb98: Preparing
2021-11-25T17:29:45.0643771Z 7fcb75871b21: Preparing
2021-11-25T17:29:45.0644555Z e76b6ebc067f: Waiting
2021-11-25T17:29:45.0645338Z 2780890f5f5a: Waiting
2021-11-25T17:29:45.0646110Z 2575f5a9476d: Waiting
2021-11-25T17:29:45.0646883Z 889d056e0cbb: Waiting
2021-11-25T17:29:45.0647674Z 1efa5a534480: Waiting
2021-11-25T17:29:45.0648451Z fdb8bc2a04c6: Waiting
2021-11-25T17:29:45.0649223Z a517aa267c33: Waiting
2021-11-25T17:29:45.0650185Z 1f474f0beb98: Waiting
2021-11-25T17:29:45.0651160Z 7fcb75871b21: Waiting
2021-11-25T17:29:45.0652197Z unauthorized: Invalid clientid or client secret.

Troubleshooting
Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting
Error logs

PEBKAC error: nothing wrong with the ACR credentials, but this task uses a DevOps service connection and the service principal had expired.

Just to add to this, if anyone else finds it - we had the very same problem and solved it by following the steps outlined here - after hours of trying to update other credentials and properties. An lo and behold, it started working again.
So evidently the Service Principal needs to be refreshed every now and then, even if there is no clear hint as to what exactly needs doing.

We also faced with the same issue and @iHaveBecomeDeath 's solution fixed the problem.

I got the same issue and resolved it with the solution provided by @iHaveBecomeDeath , thanks!

The instructions in the link provided by  @iHaveBecomeDeath require to select "verify", however there was no such "verify" button or link. I had to re-create the service connection.


error compiling with boost 1.70

FAILED: src/device-management/CMakeFiles/device-managementd.dir/main.cpp.o
/usr/bin/g++-8.3.0  -DBOOST_LOG_NO_SHORTHAND_NAMES -DBOOST_LOG_USE_STD_REGEX -DBOOST_LOG_WITHOUT_EVENT_LOG -DBOOST_LOG_WITHOUT_SYSLOG -DBOOST_LOG_WITHOUT_WCHAR_T -DMQTT_STD_ANY -DMQTT_STD_OPTIONAL -DMQTT_STD_STRING_VIEW -DMQTT_STD_VARIANT -I/home/jonesmz/meshpp_frameworks/inc -I/home/jonesmz/meshpp_frameworks/3rdparty/json/single_include -I/home/jonesmz/meshpp_frameworks/3rdparty/mqtt_cpp/include -Wall -Wextra -fno-omit-frame-pointer  -Wno-psabi -fsanitize=address -fsanitize-address-use-after-scope -fsanitize=pointer-compare -fsanitize=pointer-subtract -fsanitize=leak -fstack-protector-all -fsanitize=bounds -fsanitize=enum -g -ggdb3 -gz -O0   -std=c++17 -MD -MT src/device-management/CMakeFiles/device-managementd.dir/main.cpp.o -MF src/device-management/CMakeFiles/device-managementd.dir/main.cpp.o.d -o src/device-management/CMakeFiles/device-managementd.dir/main.cpp.o -c /home/jonesmz/meshpp_frameworks/src/device-management/main.cpp
In file included from /usr/include/boost/fusion/adapted/std_tuple.hpp:21,
from /usr/include/boost/process/detail/execute_impl.hpp:37,
from /usr/include/boost/process/child.hpp:22,
from /usr/include/boost/process/async_system.hpp:22,
from /home/jonesmz/meshpp_frameworks/inc/meshpp/asio/async_system.h:8,
from /home/jonesmz/meshpp_frameworks/inc/meshpp/asio/async_system_command.h:8,
from /home/jonesmz/meshpp_frameworks/inc/meshpp/openwrt/uci_actions.h:10,
from /home/jonesmz/meshpp_frameworks/src/device-management/main.cpp:9:
/usr/include/boost/fusion/adapted/std_tuple/tag_of.hpp:35:12: error: redefinition of ‘struct boost::mpl::sequence_tag<std::tuple<_Tps ...> >’
struct sequence_tag<std::tuple<Elements...>>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/boost/type_erasure/detail/meta.hpp:29,
from /usr/include/boost/type_erasure/detail/get_placeholders.hpp:24,
from /usr/include/boost/type_erasure/detail/normalize.hpp:30,
from /usr/include/boost/type_erasure/any.hpp:40,
from /home/jonesmz/meshpp_frameworks/3rdparty/mqtt_cpp/include/mqtt/shared_any.hpp:12,
from /home/jonesmz/meshpp_frameworks/3rdparty/mqtt_cpp/include/mqtt/type_erased_socket.hpp:17,
from /home/jonesmz/meshpp_frameworks/3rdparty/mqtt_cpp/include/mqtt/endpoint.hpp:60,
from /home/jonesmz/meshpp_frameworks/3rdparty/mqtt_cpp/include/mqtt/client.hpp:31,
from /home/jonesmz/meshpp_frameworks/3rdparty/mqtt_cpp/include/mqtt/async_client.hpp:10,
from /home/jonesmz/meshpp_frameworks/inc/meshpp/mqtt/client.h:23,
from /home/jonesmz/meshpp_frameworks/src/device-management/main.cpp:4:
/usr/include/boost/mp11/mpl.hpp:155:29: note: previous definition of ‘struct boost::mpl::sequence_tag<std::tuple<_Tps ...> >’
template<class... T> struct sequence_tag<std::tuple<T...>>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

In case it helps track down the issues with 1.70, I'm successfully building with 1.67.

I'm in kind of a damned-if-you-do, damned-if-you-dont situation.
I have to simultaneously support Ubuntu Bionic, which has Boost 1.65.
OpenWRT is 1.68.
Gentoo (which I use for development) is also 1.65
I've installed 1.70 on Gentoo to try to work around the issues i'm seeing, but that brings new compiler errors :-)
I deploy on Ubuntu, and for now I compile on Ubuntu for deployment, but I can compile on Gentoo and statically link. So as long as we can get 1.68 (OpenWRT) and 1.70 (Gentoo) to be happy, I can stop caring about 1.65 entirely.
I'm

The problem in this appears to be that I have boost fusion, and boost mpl, pulled into the same translation unit through third party dependencies.
It's not clear to me how to solve this issue...

Unfortunately, I don't have much time so I don't check this issue yet.
But perhaps https://github.com/boostorg/fusion/issues/182 is related.

I just found https://github.com/boostorg/fusion/issues/182 a moment ago, and yet. It seems exactly the same issue.

I created a new issue on mp11 https://github.com/boostorg/mp11/issues/39

This is not something that mqtt_cpp can solve, as it's an upstream bug.
I worked around my problem by using the PIMPL idiom, which isn't perfect, but it works well enough.
Closing this issue because we can't fix it.


cargo doc produces seemingly invalid suggestions to run cargo fix

I was building documentation for the parry set of libraries and got this notification at the end:
warning: `parry2d` (lib doc) generated 12 warnings (run `cargo fix --lib -p parry2d` to apply 4 suggestions)
warning: `parry2d-f64` (lib doc) generated 12 warnings (run `cargo fix --lib -p parry2d-f64` to apply 4 suggestions)
warning: `parry3d` (lib doc) generated 9 warnings (run `cargo fix --lib -p parry3d` to apply 1 suggestion)
warning: `parry3d-f64` (lib doc) generated 9 warnings (run `cargo fix --lib -p parry3d-f64` to apply 1 suggestion)

The warnings were for things like this:
warning: this URL is not a hyperlink
 --> crates\parry2d\../../src\transformation\ear_clipping.rs:2:14
  |
2 | //! Based on https://github.com/ivanfratric/polypartition, contributed by embotech AG.
  |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://github.com/ivanfratric/polypartition>`
  |
  = note: bare URLs are not automatically turned into clickable links

Unfortunately, running any of those commands doesn't appear to apply those fixes.
Meta
This happens with both the current stable and a recently nightly:
>cargo +nightly --verbose --version
cargo 1.72.0-nightly (b0fa79679 2023-06-03)
release: 1.72.0-nightly
commit-hash: b0fa79679e717cd077b7fc0fa4166f47107f1ba9
commit-date: 2023-06-03
host: x86_64-pc-windows-msvc
libgit2: 1.6.4 (sys:0.17.1 vendored)
libcurl: 8.1.2-DEV (sys:0.4.63+curl-8.1.2 vendored ssl:Schannel)
os: Windows 10.0.22621 (Windows 11 Professional) [64-bit]

>cargo --verbose --version
cargo 1.70.0 (ec8a8a0ca 2023-04-25)
release: 1.70.0
commit-hash: ec8a8a0cabb0e0cadef58902470f6c7ee7868bdc
commit-date: 2023-04-25
host: x86_64-pc-windows-msvc
libgit2: 1.6.3 (sys:0.17.0 vendored)
libcurl: 8.0.1-DEV (sys:0.4.61+curl-8.0.1 vendored ssl:Schannel)
os: Windows 10.0.22621 (Windows 10 Pro) [64-bit]

Thanks for the report! Transferred to rust-lang/cargo, as this is a cargo issue.
cargo fix is currently not capable of applying fixes from rustdoc. Either it needs to gain that ability, or it should not suggest running cargo fix when running rustdoc.


tlauc wipes the file if there is invalid syntax

I had a syntax issue on my file, and when running tlauc, all the contents of said file were erased :grimacing:
$ cat test.tla
------ MODULE test ----
foo == invalid,
=======================
$ tlauc test.tla
Error: Failed to correctly parse input TLA⁺ file; use --force flag to bypass this check.
Syntax errors might occur on or near the following lines: [2].
$ cat test.tla
$

Woaoaaaah yes this is very bad!!!

Luckily I found it in a 10-line file that I could easily rewrite, so don't worry about it! Hopefully you fixed it before anyone suffered from it.


Mitigate noAccountError #2098678

Log number of accounts in trace mode.
Validate that getActiveAccount() picks up legacy account identifier from local storage.

Codecov Report

Merging #5525 (7eed0ff) into dev (8ee7fc6) will increase coverage by 2.54%.
The diff coverage is 87.50%.

Flag
Coverage Δ

msal-angular
96.50% <ø> (ø)

msal-browser
86.62% <87.50%> (+0.14%)
:arrow_up:

msal-common
?

msal-core
?

msal-node
?

msal-node-extensions
?

msal-react
94.68% <ø> (ø)

node-token-validation
?

Impacted Files
Coverage Δ

lib/msal-browser/src/cache/BrowserCacheManager.ts
91.71% <87.50%> (+1.13%)
:arrow_up:

...rc/interaction_client/StandardInteractionClient.ts
96.03% <0.00%> (-0.97%)
:arrow_down:

lib/msal-browser/src/utils/BrowserConstants.ts
100.00% <0.00%> (ø)

...ib/msal-browser/src/app/PublicClientApplication.ts
100.00% <0.00%> (ø)

lib/msal-common/src/utils/StringUtils.ts

lib/msal-core/src/utils/CryptoUtils.ts

lib/msal-common/src/crypto/ICrypto.ts

lib/msal-core/src/ClientInfo.ts

lib/msal-core/src/telemetry/TelemetryManager.ts

lib/msal-core/src/IdToken.ts

... and 152 more


Outdated dist folder

Hello,
is it normal that the js files inside the dist folder do not contain references to the plugin support?
If you take a look at this commit
https://github.com/nolimits4web/Swiper/commit/f1c385069e90c5b9ba4ac72c3fd7c3325246222d
You see that you define s.callPlugins = function (eventName) ... but when inspecting the js files inside of the dist folder there is no references to callPlugins...
Do you want me to do it for you and submit it as a pull request?
I'll need the updated version of the dist files in order to demo the issue I have on jsfiddle...
Thank you for your time

It is a normal and usual development process, files in src/ folder are in development. When it will be ready to release, i will release it and this code will be in dist/ folder

If you need to use it right now, you may use dev version by following build instructions

Ok, I'll fork the repo and host my copy of the dist files temporarily.
Thanks


multi project support

Is there a possible way to configure it to send to two different projects?

hi there
nope, not at the moment
but i'm open for ideas
but wouldnt that duplicate a lot more settings like milestoneIDs, suiteIds and more?
and also to provide multiple TestCase IDs (which would already work)
so a lot to setup.....what would be the use case when you need multiple projects?
thanks :)

ah ok i see.
yeah just let me know. would love to support you when you need changes that make sense :)
and if you have a question feel free to ask


SquareZoomOut Axis Rule: add support for inverted axes

…om: 1.5, top: -1.5);
This PR fixes the axis range setting if you use the SquareZoomOut  and AutoScaler.InvertedX / Y
This code did not "keep" the SetLimit / AutoScaler.InvertedY setting cause SquareZoomOut rule just sets YAxis.Range.Set(yMin, yMax); we need to distinguish if the axis got inverted.
ScottPlot.Plot myPlot = new();
myPlot.Add.Signal(Generate.Sin());
myPlot.Add.Signal(Generate.Cos());
myPlot.Axes.SetLimitsY(1.5, -1.5);
myPlot.Axes.SquareUnits();

Hi @VisMotrix, thanks for this fix! I extended this PR to make some additional improvements to the axis system. I'm merging this in now so the square zoom rules work support inverted axes, but other axis rules still don't support them so I opened #3597 to track progress toward that fix in the future.


[GSSoC'23] Improve the project image dashboard in the Readme file

Is your feature request related to a problem? Please describe.
The app screenshots don't look that inspiring. We need to make it more presentable. I just want to make it seem more appealing for anyone visiting the project.
Describe the solution you'd like

I would put the images(screenshots) in the Bring-The-Menu/graphics folder and add a frame to it, and finally add it to a poster. I can also do it with a phone, so it would showcase different devices.
I would choose the colour of the background in accordance with the design theme

Additional context
@m0hit-kumar    Please assign this to me under the GSSoC'23.
I have added some examples of how this project could look like (from my own repo)

Friday

issue has been clubbed under single issue(#84 ) for management purposes you can still keep work on it and do the PR


Edit multiple elements - previous actions are assign to last

Describe the bug

I have few texts to edit on one page. When I'm trying to edit few of them at once. And click on appeared buttons, doesn't matter on which button I click, they will execute only on last one expanded.
Steps to reproduce

My malle setup:
// now create the malle
const malle = new Malle({
  debug: true,
  formClasses: ['d-flex'],
  cancel: 'Cancel',
  cancelClasses: ['btn', 'btn-danger', 'btn-sm'],
  inputClasses: ['form-control', 'd-inline'],
  submit: 'OK',
  submitClasses: [ 'btn', 'btn-primary', 'mx-2', 'btn-sm'],
  tooltip: 'Click this to edit',
  onBlur: Action.Ignore,
  onEnter: Action.Ignore,
  // this is the function that will be called once user has finished entering text (press Enter or click outside)
  // it receives the new value, the original element, the event and the input element
  fun: (value, original, event, input) => {
    let fieldName = original.getAttribute('id')
    return myCustomFunction(value, fieldName);
  },
}).listen(); // directly start listening after object creation

and later in html:
Name
{{ test['testName'] }}

Branch
{{ test['testBranch'] }}

Information

malle version: latest 2.2.0     "@deltablot/malle": "^2.2.0"
Client operating system (e.g: MacOS, Windows, GNU+Linux): MacOS
Browser (e.g. firefox, chrome): Chrome

When I'm trying to edit few of them at once.

You mean having several inputs opened at the same time?

I haven't looked into it, but it was never designed to have multiple inputs opened at the same time, so I'm not surprised that you get this undefined behavior.

I've looked into it but didn't find a solution to this behavior, so I'm open to suggestions, or any help on that matter.

I was thinking about two possible solutions:

pro solution - to check during save/cancel operations the 'id' of the editable element or just search for a parent.
as a fast solution - to just lock rest of the editable fields when one is edited at this moment. You have to save to cancell one to edit another.

I think this issue is that there is only one instance of Malle, and it listens on all elements, and this leads to this bug.
So one approach to solve this issue would be to have one instance per target, it's not like Malle has a huge memory footprint. And this you can do already by having one instance listen to only one element.
And then we can have your second point, that if a Malle instance listens on more than one element, then editing another one is not permitted while one is "opened", and it shows an error message to that effect.
Downside is that it might mean a lot of boilerplate code to duplicate, and you need to write a new Malle() for each element, which doesn't work well with dynamic elements.
So the better solution would be to handle better multiple opened elements. You suggested looking at an id or parentElement, but this won't work 100% of the time. I'm thinking about storing some sort of internal identifier (counter) for elements, but I'll have to get back to this and take the time to do it right. Not sure if it's a good strategy anyway...

@marczuk Can you try the branch "multi" please? It should solve this issue. FYI, here is the diff:
diff --git a/src/main.ts b/src/main.ts
index 982979a..451c6db 100644
--- a/src/main.ts
+++ b/src/main.ts
@@ -127,7 +127,10 @@ export class Malle {
   listen() {
     document.querySelectorAll(this.opt.listenOn)
       .forEach((el: HTMLElement) => {
-        el.addEventListener(this.opt.event, this.process.bind(this));
+        const opt = this.opt;
+        opt.listenNow = false;
+        const m = new Malle(opt);
+        el.addEventListener(this.opt.event, m.process.bind(m));
         // make the mouse change to pointer on targeted elements
         el.style.cursor = 'pointer';
         if (this.opt.tooltip) {

I just tried, but I'm not sure why, but when executing: npm i @deltablot/malle@deltablot/malle#multi
I'm getting malle without dist catalog.

Yes it won't work like this as the dist file is built by the publish action, you'll need to pull the branch, run npm run build and copy the dist content over to your node_modules folder.

works perfectly now :) waiting for a release :)


Check for RPi CPU throttling

The summer has come and my RPi-s are running hot.
Checking for throttling with this script works:
#!/usr/bin/env python3

import subprocess

GET_THROTTLED_CMD = 'vcgencmd get_throttled'
MESSAGES = {
    0: 'Under-voltage!',
    1: 'ARM frequency capped!',
    2: 'Currently throttled!',
    3: 'Soft temperature limit active',
    16: 'Under-voltage has occurred since last reboot.',
    17: 'Throttling has occurred since last reboot.',
    18: 'ARM frequency capped has occurred since last reboot.',
    19: 'Soft temperature limit has occurred'
}

print("Checking for throttling issues since last reboot...")

throttled_output = subprocess.check_output(GET_THROTTLED_CMD, shell=True)
throttled_output = throttled_output.decode('utf-8')  # decode bytes to string
throttled_binary = bin(int(throttled_output.split('=')[1], 0))

warnings = 0
for position, message in MESSAGES.items():  # use items() instead of iteritems()
    # Check for the binary digits to be "on" for each warning message
    if len(throttled_binary) > position and throttled_binary[0 - position - 1] == '1':
        print(message)
        warnings += 1

if warnings == 0:
    print("Looking good!")
else:
    print("Houston, we may have a problem!")

Raw command:
₿ sudo vcgencmd get_throttled
throttled=0x80000

Interpretation (temp is at 77 -78 C):
₿ sudo python throttle.py
Checking for throttling issues since last reboot...
Soft temperature limit has occurred
Houston, we may have a problem!

Could make this a warning on the display.
Source (converted for python 3): https://blog.mccormack.tech/shell/2019/01/05/monitoring-raspberry-pi-power-and-thermal-issues.html

add later to debug / system state info

related #1564


Add External Validation helper

Validating your receipt externally is a PITA currently, this adds a helper function that returns exactly what you need.
Tested with NPM: in-app-purchase

This is to expose getOriginalJson()? getSignature() already exists.
Having a method to just return getOriginalJson() instead of a method that returns both Signature and Original Json aka getReceipt() might be better.
What do you think? Is it necessary to combine them into getReceipt()?

For Google validation, receipt is an object
{ data: "stringified purchase data", signature: "yyyy" }.

It was necessary to expose originalJson because the data has to be in the exact order it was received for valid decoding. So I killed two birds with one proxy method. Sure it might be cleaner to separate it but that's just one more thing to merge properly on the JS side.

Ah. Okay. Understood. 👍

@nitrag I'm going to have to cherry-pick this put it in another PR. Reason being that there's a need to branch out the ti.inappbilling for support prior to TiSDK 6 and for TiSDK 6 moving forward.
Hope that is okay for you?

No problem, I'll keep an eye out for the change when I upgrade to 6.0.
On Sep 9, 2016 2:45 AM, "Ashraf"<EMAIL_ADDRESS>wrote:

@nitrag https://github.com/nitrag I'm going to have to cherry-pick this
put it in another PR. Reason being that there's a need to branch out the
ti.inappbilling for support prior to TiSDK 6 and for TiSDK 6 moving forward.
Hope that is okay for you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/appcelerator-archive/ti.inappbilling/pull/23#issuecomment-245833256,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMBkoJdlIIKdeAem3YPdiB8LvSGj8rYks5qoQCigaJpZM4J4pqG
.

I've updated this PR here: https://github.com/appcelerator-archive/ti.inappbilling/pull/24

Will be closing this.


Convert to module (ESM).

BREAKING: Convert to module (ESM).
BREAKING: Require Node.js >=14.
Update dependencies.
Lint module.

Notes:

The test framework here is cloned from jsonld.js I assume.  test-karma worked fine, but to get test-node to work I had to remove the mocha --delay cli param (done due to a guess).  I'm not sure why that "fixes" it.

Codecov Report

Merging #77 (822151a) into main (5031a1d) will increase coverage by 2.58%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   88.18%   90.76%   +2.58%
==========================================
  Files           6        6
  Lines         474     1874    +1400
==========================================
+ Hits          418     1701    +1283
- Misses         56      173     +117

Impacted Files
Coverage Δ

lib/CapabilityDelegation.js
91.90% <100.00%> (+2.72%)
:arrow_up:

lib/CapabilityInvocation.js
84.82% <100.00%> (+3.22%)
:arrow_up:

lib/CapabilityProofPurpose.js
98.51% <100.00%> (+2.08%)
:arrow_up:

lib/constants.js
100.00% <100.00%> (ø)

lib/index.js
100.00% <100.00%> (ø)

lib/utils.js
86.23% <100.00%> (+1.20%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5031a1d...822151a. Read the comment docs.


[BUGFIX] Fix and cleanup _contrib_quantized_elemwise_add

Description
The key for caching oneDNN kernel was made from different elements than used for building the kernel.
+ some additional cleanup
Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e.


Github source doesn't seem to create webhook until kicked

The first time I apply github sources they don't seem to create their webhooks.
After I touch something cosmetic (e.g. change types) and re-apply they come up fine.
cc @n3wscott @grantr

/kind good-first-issue

I believe I found the culprit here.  This still has .eventing in it:
https://github.com/knative/eventing-contrib/blob/bc4f495c6c296ad4d98f6d2bc7a2276173aa38da/pkg/apis/sources/register.go#L20
This means that literally every filter call in (at least) the github source will filter away all child informer events:
https://github.com/knative/eventing-contrib/blob/bc4f495c6c296ad4d98f6d2bc7a2276173aa38da/github/pkg/reconciler/controller.go#L84

/assign

This is now fixed.


Fix schema serialization

Description of changes
Followup to #749 to fix json schema serialization.

Added custom (de)serialization for Id and Name. This will affect our internal formats (e.g., used by DRT), but should not affect external formats, aside from error messages.
This allowed me to remove some of the boilerplate in schema_file_format.rs

Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):

[X] A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

[X] Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

[X] Requires updates, and I have made / will make these updates myself. (Please include in your description a timeline or link to the relevant PR in cedar-spec, and how you have tested that your updates are correct.)

Update: ran the json-schema-roundtrip target locally for a couple hours and all appears to be good.

Another update: this PR breaks the Lean JSON parsing. Looks like CI didn't fail because we're not running the DRT implementation on the integration tests. I'll work on finishing off #488 before merging this PR.

Ready for re-review.

Added comments in id.rs and name.rs that de/serialization is used for the JSON schema format
Updated to use the new downstream CI for cedar-spec (which now fails, as expected)
Cleaned up some of the testing code

I'll now start working on the update to cedar-spec for this PR.


Proposal ref(publisher): change the publication loop logic

Right now the publisher uses a ttl to expire the key of the application if the container and the open are available. This works just fine until you start hundreds of container because at that point the 10 seconds loops never ends.
Why not change the logic to publish the port when the container starts and use the loop to check if the container is and the port opened and remove it if not available?
if s.IsPublishableApp(containerName) && !s.IsPortOpen(hostAndPort) {
  s.removeEtcd(keyPath, false)
}

With this change the interaction with etcd is just 1 request per application when is not available instead of  O(n) every 10 seconds (to update the ttl) (n is the number of apps running in the local node)

If publisher dies, I believe the intention is that the keys should also be removed such that the issue becomes apparent to the user, which is why we're using TTLs instead of just creating them once and waiting for the containers to die.

@bacongobbler you are right, but see this process when you have more than 100 containers in a node, the amount of traffic with etcd starts to create issues with fleet for instance and the publication loop never ends

Just to clarify: the way it works now is not wrong, this "issue" appear after hundreds of containers

If we can make that workflow fault-tolerant, then I'm all for it! We could also just document bumping the TTLs up to 2n seconds, but in essence we're just bumping an arbitrary number that could fail again at 2n containers. :/
Alternatively, kubernetes has service discovery built into the platform, therefore eliminating the need for deis/publisher. That might be something worth looking into!

If publisher dies,....

is not posible to know which container died. When the publisher is restarted the map that contains the information about the running containers in the node it will be empty. That's why I added an additional component that checks every 40 seconds the published containers and if is not responding it just eliminate the key from `/deis/services/'
https://github.com/aledbf/deis/commit/eb7291612251b9556917f45a07a9d79dd7f14e81#diff-d480fdb907bf18e9fc3592040c5dd4e7R36

Alternatively, kubernetes has service discovery built into the platform,
I know and it does exactly why I implemented, the only difference is that it checks an URL in the pod (livenessProbe) https://github.com/GoogleCloudPlatform/kubernetes/blob/release-0.20/release-0.19.0/docs/pod-states.md#container-probes

It makes no sense to change this if the scheduler is fleet. As @bacongobbler mentioned kubernetes already provides a "native" alternative for deis-publisher


unused variable

doesn't appear to be used anywhere and isn't defined in tfvars.sample

Thanks @johnstudarus !


chore(deps): update dependency forever to v4

This PR contains the following updates:

Package
Type
Update
Change

forever
dependencies
major
^2.0.0 -> ^4.0.0

Release Notes

foreverjs/forever
v4.0.3
Compare Source
=========================

[fix] Upgrade Winston [#1128]

v4.0.2
Compare Source
=========================

[fix] Pin colors.js version [#1127]

v4.0.1
Compare Source
=========================

[fix] Configstore init and usage fixes [#1115]

v4.0.0
Compare Source
=========================

[security] Replace nconf with configstore [#1112]
[security] Replace yargs with getopts [#1110]

v3.0.4
Compare Source
=========================

[security] Update forever-monitor and remove utile to get rid of vulnerabilities

v3.0.3
Compare Source
=========================

[security] Update forever-monitor and remove broadway to get rid of vulnerable minimist version [#1098]

v3.0.2
Compare Source
=========================

[doc] Add project deprecation warning

v3.0.1
Compare Source
=========================

[security] Replaced optimist with yargs [#1093]

v3.0.0
Compare Source
=========================

[security] Update forever-monitor [#1081]

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 4.x releases. However, if you upgrade to 4.x manually then Renovate will reenable minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


Missing Livereload

i just switch to vite, i was on webpack arch before and livereload was working.
file where generated with UUID in the name, for content script it was still needed a reload of the extension and the page.
But now i need to remove the extension to make update .

Hot reload does not work in Chrome Manifest V3

Thanks for the feedback, can you link to the doc to know why ?

The answer is here: https://stackoverflow.com/a/65976345/3711660
Im not really sure about the whole thing, because there is very little to none on this topic, but im trying to get this code to run without luck to check if this is a real issue or not.


[DO NOT MERGE] Resource functions and handler for NCCL tests

I've split off the resource functionality from the NCCL work into its own PR so we can get a jump on reviews.
$curl "http://<IP_ADDRESS>:3333/coordinate?check=resources"

The above command will return a resources usage summary for each the node.  This functionality will be necessary for distributed test coordination.

The resource usage summary for a node looks like this:
Autopilot Endpoint: <IP_ADDRESS>
Node: gdr-test-6p2kc-hf-gpu-il-worker-3-zht6x
url(s): http://<IP_ADDRESS>:3333/coordinate?host=gdr-test-6p2kc-hf-gpu-il-worker-3-zht6x&check=resources
Response:
Start Coordination Handler
Checking resources of node gdr-test-6p2kc-hf-gpu-il-worker-3-zht6x (localhost)

Allocated resources:
Resource	 Requests	 Limits
________	 ________	 ______
cpu		659m		700m
memory		1726Mi		600Mi
nvidia.com/gpu		0		0
nvidia.com/roce_gdr		0		0
ephemeral-storage		5Mi		105Mi

Node Status: OK
-------------------------------------


Finalize Devnet Deployment System

This epic is about releasing the system for coordinating the deployment of devnet. It also includes the Block Explorer to help achieve the Milestone

This is covered by dusk-network/dusk-explorer#67 and dusk-network/devops#4