Synthesis failed for pubsub

Hello! Autosynth couldn't regenerate pubsub. :broken_heart:
Here's the output from running synth.py:
2020-05-08 16:11:39 [INFO] logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/google-cloud-php
2020-05-08 16:11:39,074 autosynth > logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/google-cloud-php
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 596, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 470, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 515, in _inner_main
    working_repo_path = synthtool_git.clone(f"https://github.com/{args.repository}.git")
  File "/tmpfs/src/github/synthtool/synthtool/sources/git.py", line 65, in clone
    preclone = get_preclone(url)
  File "/tmpfs/src/github/synthtool/synthtool/sources/git.py", line 168, in get_preclone
    preconfig = synthtool.preconfig.load()
AttributeError: module 'synthtool' has no attribute 'preconfig'

Google internal developers can see the full log here.

Autosynth is still having trouble generating pubsub. :sob:
Here's the output from running synth.py:
2020-05-08 17:08:50 [INFO] logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/google-cloud-php
2020-05-08 17:08:50,207 autosynth > logs will be written to: /tmpfs/src/github/synthtool/logs/googleapis/google-cloud-php
Switched to branch 'autosynth-pubsub'
2020-05-08 17:08:50 [INFO] Running synthtool
2020-05-08 17:08:50,934 autosynth > Running synthtool
2020-05-08 17:08:50 [INFO] ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']
2020-05-08 17:08:50,935 autosynth > ['/tmpfs/src/github/synthtool/env/bin/python3', '-m', 'synthtool', '--metadata', 'synth.metadata', 'synth.py', '--']
tee: /tmpfs/src/github/synthtool/logs/googleapis/google-cloud-php: Is a directory
2020-05-08 17:08:51,148 synthtool > Executing /home/kbuilder/.cache/synthtool/google-cloud-php/PubSub/synth.py.
On branch autosynth-pubsub
nothing to commit, working tree clean
2020-05-08 17:08:51,309 synthtool > Ensuring dependencies.
2020-05-08 17:08:51,674 synthtool > Cloning googleapis.
2020-05-08 17:08:52,029 synthtool > Generating code for: //google/pubsub/v1:google-cloud-pubsub-v1-php.
2020-05-08 17:08:57,836 synthtool > Generated code into /tmpfs/tmp/tmprzan8ajz.
2020-05-08 17:08:57,857 synthtool > Replaced "'serviceAddress' =>" in src/V1/Gapic/SubscriberGapicClient.php.
2020-05-08 17:08:57,858 synthtool > Replaced "'serviceAddress' =>" in src/V1/Gapic/PublisherGapicClient.php.
2020-05-08 17:08:57,859 synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V1/Gapic/SubscriberGapicClient.php.
2020-05-08 17:08:57,859 synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V1/Gapic/PublisherGapicClient.php.
2020-05-08 17:08:57,861 synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1/Gapic/SubscriberGapicClient.php.
2020-05-08 17:08:57,861 synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1/Gapic/PublisherGapicClient.php.
2020-05-08 17:08:57,862 synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/SubscriberGapicClient.php.
2020-05-08 17:08:57,863 synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/PublisherGapicClient.php.
2020-05-08 17:08:57,864 synthtool > Replaced 'Copyright \\d{4}' in src/V1/PublisherClient.php.
2020-05-08 17:08:57,865 synthtool > Replaced 'Copyright \\d{4}' in src/V1/PublisherGrpcClient.php.
2020-05-08 17:08:57,866 synthtool > Replaced 'Copyright \\d{4}' in src/V1/SubscriberClient.php.
2020-05-08 17:08:57,866 synthtool > Replaced 'Copyright \\d{4}' in src/V1/SubscriberGrpcClient.php.
2020-05-08 17:08:57,867 synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1/PublisherSmokeTest.php.
2020-05-08 17:08:57,868 synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/SubscriberClientTest.php.
2020-05-08 17:08:57,868 synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/PublisherClientTest.php.
2020-05-08 17:08:57,877 synthtool > No replacements made in src/**/*.php for pattern <a href="/pubsub/docs/, maybe replacement is no longer needed?
2020-05-08 17:08:57,878 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/UpdateSnapshotRequest.php.
2020-05-08 17:08:57,878 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/RetryPolicy.php.
2020-05-08 17:08:57,879 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/DeleteSnapshotRequest.php.
2020-05-08 17:08:57,879 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PullRequest.php.
2020-05-08 17:08:57,879 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListTopicSnapshotsResponse.php.
2020-05-08 17:08:57,880 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListTopicSubscriptionsRequest.php.
2020-05-08 17:08:57,880 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ModifyAckDeadlineRequest.php.
2020-05-08 17:08:57,880 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListTopicsRequest.php.
2020-05-08 17:08:57,881 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/Snapshot.php.
2020-05-08 17:08:57,881 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListSubscriptionsRequest.php.
2020-05-08 17:08:57,881 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListSubscriptionsResponse.php.
2020-05-08 17:08:57,882 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListSnapshotsResponse.php.
2020-05-08 17:08:57,882 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/StreamingPullRequest.php.
2020-05-08 17:08:57,882 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListTopicsResponse.php.
2020-05-08 17:08:57,883 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PushConfig.php.
2020-05-08 17:08:57,883 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ReceivedMessage.php.
2020-05-08 17:08:57,883 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListTopicSubscriptionsResponse.php.
2020-05-08 17:08:57,883 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/GetSnapshotRequest.php.
2020-05-08 17:08:57,884 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListSnapshotsRequest.php.
2020-05-08 17:08:57,884 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/DeadLetterPolicy.php.
2020-05-08 17:08:57,884 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ModifyPushConfigRequest.php.
2020-05-08 17:08:57,885 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/DeleteSubscriptionRequest.php.
2020-05-08 17:08:57,885 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/Subscription.php.
2020-05-08 17:08:57,885 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/AcknowledgeRequest.php.
2020-05-08 17:08:57,886 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/Topic.php.
2020-05-08 17:08:57,886 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ExpirationPolicy.php.
2020-05-08 17:08:57,886 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/DeleteTopicRequest.php.
2020-05-08 17:08:57,886 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/UpdateTopicRequest.php.
2020-05-08 17:08:57,887 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/GetTopicRequest.php.
2020-05-08 17:08:57,887 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PubsubMessage.php.
2020-05-08 17:08:57,888 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListTopicSnapshotsRequest.php.
2020-05-08 17:08:57,888 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/SeekRequest.php.
2020-05-08 17:08:57,888 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/UpdateSubscriptionRequest.php.
2020-05-08 17:08:57,889 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/GetSubscriptionRequest.php.
2020-05-08 17:08:57,889 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PublishRequest.php.
2020-05-08 17:08:57,889 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/CreateSnapshotRequest.php.
2020-05-08 17:08:57,890 synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PushConfig/OidcToken.php.
2020-05-08 17:08:57,899 synthtool > No replacements made in src/**/V*/**/*.php for pattern final class, maybe replacement is no longer needed?
2020-05-08 17:08:57,907 synthtool > No replacements made in src/**/V*/**/*.php for pattern public function ([s|g]\w{3,})Unwrapped, maybe replacement is no longer needed?
2020-05-08 17:08:58,082 synthtool > No replacements made in src/**/V*/**/*.php for pattern (.{0,})\]\((/.{0,})\), maybe replacement is no longer needed?
2020-05-08 17:08:58,083 synthtool > Wrote metadata to synth.metadata.
Traceback (most recent call last):
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/home/kbuilder/.pyenv/versions/3.6.9/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 597, in <module>
    main()
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 471, in main
    return _inner_main(temp_dir)
  File "/tmpfs/src/github/synthtool/autosynth/synth.py", line 547, in _inner_main
    ).synthesize(base_synth_log_path)
  File "/tmpfs/src/github/synthtool/autosynth/synthesizer.py", line 120, in synthesize
    with open(log_file_path, "rt") as fp:
IsADirectoryError: [Errno 21] Is a directory: '/tmpfs/src/github/synthtool/logs/googleapis/google-cloud-php'

Google internal developers can see the full log here.

Autosynth passed, closing! :green_heart:


When user selects "propose changes to existing homepage", show propose button in editor

When user selects "make changes to existing homepage" and gets redirected to edit/build.sputnik-dao.near/widget/home, then we should show a special button on the editor to "Propose".
This should check for the widgetSrc parameter that matches build.sputnik-dao.near/widget/home.
Propose should not show for regular edits.

Well, the props are not working rn


MissingPluginException(No implementation found for method initConnection on channel flutter_inapp)

Version of flutter_inapp_purchase
flutter_inapp_purchase: ^5.6.1
Platforms you faced the error (IOS or Android or both?)
Android
Can upgrade the plugin's gradle to 8.x?

Was it because of gradle version changes? Do you have any information? Because I'm facing a similar issue on android


CVXPY 1.0 parameters confer no performance benefit

In 0.4.11, using parameters and resolving a problem for different parameter values gives a significant performance improvement. Equivalent code with 1.0 runs in the same time whether only parameter values are change or if the whole problem is recreated from scratch.
test code:
import time
import random
import statistics

import cvxpy as cvx
import numpy as np

def problem():
    x = cvx.Variable(shape=(8,))
    mu = cvx.Parameter(shape=(8,))

    u = mu.T * x - cvx.sum_squares(x) - 0.1 * cvx.sum(cvx.abs(x) ** (3/2))
    c = [-0.2 <= x, x <= 0.2]

    return {"problem": cvx.Problem(cvx.Maximize(u), c),
            "variable": x,
            "forecast": mu}

def with_compile():
    p = problem()
    p["forecast"].value = np.random.normal(size=8)
    p["problem"].solve()
    return p

p0 = problem()
def without_compile():
    p0["forecast"].value = np.random.normal(size=8)
    p0["problem"].solve()
    return p0

functions = with_compile, without_compile
times = {f.__name__: [] for f in functions}

for i in range(100):  # adjust accordingly so whole thing takes a few sec
    func = random.choice(functions)
    t0 = time.time()
    func()
    t1 = time.time()
    times[func.__name__].append((t1 - t0) * 1000)

for name, numbers in times.items():
    print('FUNCTION:', name, 'Used', len(numbers), 'times')
    print('\tMEDIAN', statistics.median(numbers))
    print('\tMEAN  ', statistics.mean(numbers))
    print('\tSTDEV ', statistics.stdev(numbers))

I can confirm this report. Here's my output from the script in the ticket. Ran this on Python 3.7, macOS 10.13.5, Core i7 1.7GHz. cvxpy version 1.0.6.
FUNCTION: with_compile Used 59 times
	MEDIAN 27.675867080688477
	MEAN   30.742257328356725
	STDEV  7.337865665104942
FUNCTION: without_compile Used 41 times
	MEDIAN 29.330015182495117
	MEAN   31.004120663898746
	STDEV  7.93215427430337

I also ran the script replacing p0["problem"].solve() with p0["problem"].solve(warm_start=True) in the without_compile function, and I got the same result.
I then ran the script at the docs for warm_start, which I had to modify by replacing prob.solve_time with prob.solver_stats.solve_time. This was the output:
First solve time: 21.465058394000003
Second solve time: 1.385668273

Maybe warm_start=True only helps with certain subclasses of problems, and this should be documented?
Personally, I'm particularly anxious that it work with MILPs. Does it?

Same here - using Parameters in my problem has no benefit and is the same as recreating the problem from scratch. I could paste my problem if the issue is problem specific. cvxpy 1.0.6 on Ubuntu 18.04

@SteveDiamond to clarify does this mean that using Parameters has no performance benefit in 1.x but does in 0.4.x?

It looks like ECOSBB and CBC might support warm starting as well. Even without baked-in warm-start support, maybe it would help to be able to pass in a known-feasible initial start point for the solvers. If I understand LP and MILP correctly, this can help speed things up substantially when using simplex or branch and bound, respectively. Perhaps warm_start=True could pass along a known-feasible initial point to solvers that don't directly support warm starting?

@frk2 they do different things in the two versions. I was talking about the benefits n 1.x. @wkschwartz I agree providing initial points would be a good feature, but it's a fair amount of work.

@SteveDiamond to clarify: did you ever intend for (or do you think it reasonable to strive for) Parameter objects to confer compile-time benefits?
If not, it might be helpful to specify the benefits / use-cases of Parameter objects in the documentation. See #553 for what I mean by a "non compile-time" benefit of Parameter objects.

This should be improved since #664


Sample code incorrect in com.google.cloud.pubsub.spi.v1.AckReply.java

Sample has an incorrect call to consumer.accept() in lines 37 and 39. The null parameter shouldn't be there.

This will be fixed by https://github.com/GoogleCloudPlatform/google-cloud-java/pull/1899 .

The fix was merged. Closing this issue.


Add a monomorphization cache to the declaration engine.

This introduces a cache to the declaration engine that keeps track of functions/structs that have been instantiated from a specific set of type parameters.
The approach here is relatively simple and relies on a linear search. I originally thought about having more maps to speed it up by keying on the type arguments, but since it adds a bit of complexity I opted for this for now. If it proves to be a bottleneck in the future we can always speed it up.
This was prototyped in https://github.com/tritao/declaration-engine-and-collection-context-demo/commit/c3aa5e718211ee1a88d7ebc51798280e8321e387, where these APIs where wired to the function application and struct expressions instantiation code.
However given the declaration engine is not hooked up yet here, this PR is just adding the APIs, and more proper testing will be added as we wire things up.
Closes https://github.com/FuelLabs/sway/issues/2636.

so I've disabled the cache by default and we can enable it by default at a later stage

Good plan :+1:


fix minor typo in PropertyBasedClientConfigConstants.java

Nothing much, just a typo fix
INITIAL_REGISTRATION_REPLCIATION_DELAY_KEY -> INITIAL_REGISTRATION_REPLICATION_DELAY_KEY

Thanks @hieurl


feat: add commitlint

Commitlint provides as the name says, linting for our commits. It makes sure we follow this structure:
feat: description
fix: fix description
This way standard-version can generate the appropriate changelog based on our commits. Please check #125
Why conventional commits? https://www.conventionalcommits.org/en/v1.0.0-beta.2/#why-use-conventional-commits

vercel sounds like an odd type, usually it falls in within ci , build or chore, does it need its own type?

vercel sounds like an odd type, usually it falls in within ci , build or chore, does it need its own type?

You're right. Removing it.

Please resolve the conflicts


Can't hear rain when using weather2 (1.7.10)

Version I'm using:
<IP_ADDRESS>
Forge Version installed:
1614
Description:
When I have weather2 v2.3.20 installed with dynamic surroundings, I can't hear rain, I think it must be something to do with weather2 when there is a storm.

but when I don't have weather2 installed I can hear rain

Yep.  Weather2 is in control of rain splashing and what not.  https://github.com/OreCruncher/DynamicSurroundings/wiki/Compatibility#weather-2

CleanWeather v1.1.0 for 1.2.5 (for  a future dynamic surroundings update).zip
If you want to have a look at the mod file, I've attached a file here


FsharpResult type with a few tests

Uservoice link:
https://fslang.uservoice.com/forums/245727-f-language/suggestions/9484395-discriminated-union-type-in-order-to-be-able-to-wr
Further information (where it was mentioned that any update to FSharp.Core should be done to Microsoft/visualfsharp):
https://github.com/fsharp/fsharp/issues/479#issuecomment-134518770

Hi @wallymathieu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@wallymathieu, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

@wallymathieu can you add [WIP] to title?

How does this relate to Chessie? Are you going to port the tests over? If we really put this into FSharp.Core then it should at least do what Chessie can. Especially in regards to C# interop this is a really hard topic. I tried so many things to make Chessie work for C# - so please also port the C# samples / tests to show that we have at elast that basic C# support that Chessie has.

@forki i think it's good to have a shared (in whole f# ) Success/Failure type.
But I think is wrong to add more functions in FSharp.Core.
External libraries like Chessie can add additional functions using the Result type inside FSharp.Core

/// <summary>Helper type for error handling without exceptions.</summary>
[<StructuralEquality; StructuralComparison>]
[<CompiledName("FSharpResult`2")>]
type Result<'T1,'T2> =
| Success of 'T1
| Error of 'T2

Is that really the type we want for Results? Chessie is using:
/// Represents the result of a computation.
type Result<'TSuccess, 'TMessage> =
/// Represents the result of a successful computation.
| Ok of 'TSuccess * 'TMessage list
/// Represents the result of a failed computation.
| Bad of 'TMessage list

I'll open an RFC to discuss it

@wallymathieu can you add "Discuss on fsharp/FSharpLangDesign#49" in the pr description?
meanwhile i'll add the RFC doc

@enricosada there, I've updated the description and title.

/// Represents the result of a computation.
type Result<'TSuccess, 'TMessage> =
    /// Represents the result of a successful computation.
    | Ok of 'TSuccess * 'TMessage list
    /// Represents the result of a failed computation.
    | Bad of 'TMessage list

I don't see why Bad should always contain a list of values? It seems suboptimal for functions which return only a single bad value. Additionally list has slow concatenation so combining lists with messages would be slow.

On the other hand
type Result<'T1,'T2> =
    | Success of 'T1
    | Error of 'T2

is isomorphic to Choice<'T1, 'T2>. So I don't see why we should add it.

@wallymathieu @forki @dsyme  @otawfik-ms
Guys,
where are we on this PR?  it hasn't been touched since mid-feb and so looks like it might be dead.  Do we want to add this functionality, shall we find someone to shepherd it through or drop it?
Kevin

Please make the adjustments mentioned above and then we can accept this,
There is discussion in the RFC about whether we should also add a corresponding module of operations and a attempt builder into FSharp.Core as well.  But minimally there is real value in accepting the definition of the type to help enable interop between different F# components that want to use this type.

Should I do a merge from master and fix the compilation error in Commands.fs?

@wallymathieu Yes please

The failure of Windows_NT Release_ci_part2 Build :
FSharp.Core.Unittests.FSharp_Core.Microsoft_FSharp_Control.AsyncModule.Async.AwaitWaitHandle does not leak memory
Does not look related to this pull request.

CLose/reopen to re-run CI

Hi @wallymathieu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Should we change the title and remove [WIP] ?

@wallymathieu removed, thanks.  Added one comment above TOk --> T

This is ready to merge.

LGTM :+1:

👍


Upgrade: dependencies for material-ui

What is the purpose of this pull request? (put an "X" next to item)
[] Documentation update
[] Bug fix
[] New functionality
[x] Changes an existing functionality
[x] Other, please explain:
What changes did you make? (Give an overview)

Upgrade: dependencies for material-ui
Fix: Wrap seach results that are longer (fixes #4)
Chore: Using ThemeProvider in a single place now
Update: Changed color to meet WCAG2.0 compliance

Add any screenshots

Fix: Wrap seach results that are longer (fixes #4)

Update: Changed color to meet WCAG2.0 compliance

@swatikode Please review this when you get some time.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


intermittent vercel/pkg copyfile error [wip]

Bug description
go run github.com/prisma/prisma-client-go version
Error: ENOENT: no such file or directory, copyfile '/Users/prisma/.cache/prisma/master/7d0087eadc7265e12d4b8d8c3516b02c4c965111/darwin/prisma-fmt' -> '/snapshot/node_modules/@prisma/engines/prisma-fmt-darwin'

The file does seem to exist though:
❯ file /Users/prisma/.cache/prisma/master/7d0087eadc7265e12d4b8d8c3516b02c4c965111/darwin/prisma-fmt
/Users/prisma/.cache/prisma/master/7d0087eadc7265e12d4b8d8c3516b02c4c965111/darwin/prisma-fmt: Mach-O 64-bit executable x86_64

Deleting the specified directory seems to fix it (temporarily at least):
❯ rm -rf /Users/prisma/.cache/prisma/master/7d0087eadc7265e12d4b8d8c3516b02c4c965111

❯ go run github.com/prisma/prisma-client-go version

@prisma/cli          : 2.10.2
@prisma/client       : Not found
Current platform     : darwin
Query Engine         : query-engine 7d0087eadc7265e12d4b8d8c3516b02c4c965111 (at ../../Library/Caches/prisma/binaries/cli/2.10.2/prisma-query-engine-darwin, resolved by PRISMA_QUERY_ENGINE_BINARY)
Migration Engine     : migration-engine-cli 7d0087eadc7265e12d4b8d8c3516b02c4c965111 (at ../../Library/Caches/prisma/binaries/cli/2.10.2/prisma-migration-engine-darwin, resolved by PRISMA_MIGRATION_ENGINE_BINARY)
Introspection Engine : introspection-core 7d0087eadc7265e12d4b8d8c3516b02c4c965111 (at ../../Library/Caches/prisma/binaries/cli/2.10.2/prisma-introspection-engine-darwin, resolved by PRISMA_INTROSPECTION_ENGINE_BINARY)
Format Binary        : prisma-fmt 7d0087eadc7265e12d4b8d8c3516b02c4c965111 (at ../../Library/Caches/prisma/binaries/cli/2.10.2/prisma-prisma-fmt-darwin, resolved by PRISMA_FMT_BINARY)
Studio               : 0.304.0

/snapshot seems to be internal to pkg.
How to reproduce
Doesn't seem to happen on the first time, it looks like it happens when you continuously run it. It seems to be intermittent though, I'm not sure yet.
Expected behavior

Prisma information

Environment & setup

OS:
Database:
Node.js version:
Prisma version:

Labelling it as need-info as reproduction still seems to be WIP

Closing due to inactivity.


HTTP ERROR 500

Describe the bug
HTTP ERROR 500 when going to site.  I upgraded to the latest and greatest, updated my php to version 7.4, installed all the dependents (as far as I know).
Steps To Reproduce
Going to site, I get HTTP ERROR 500
Expected behavior
I would intend for the site to load as it did before updating.
Screenshots
None.
Your Configuration (please complete the following information):

Exact BookStack Version (Found in settings): Updated to latest origin.
PHP Version: 7.4 ( PHP 7.4.5 (cli) (built: Apr 19 2020 08:42:37) ( NTS ))
Hosting Method (Nginx/Apache/Docker):  Apache

Additional context
I've had this issue before.  I believe I had to play with file permissions to get it to work but can't remember which files had to be adjusted.

Hi @Blade2021,
If you think this may be due to permissions, The following directories (And all subdirectories) need to be writable by BookStack:

bootstrap/cache
storage
public/uploads

If running Ubuntu you can generall achieve this by running the below from your BookStack install directory:
chown www-data:www-data -R bootstrap/cache public/uploads storage && chmod -R 755 bootstrap/cache public/uploads storage

Hello @ssddanbrown
I appreciate the quick follow up.  I have ran that command but i'm not seeing any changes on my end.  I believe chown was the ticket to getting it working last time but I'm not sure.
I added the debug line to my .env and moved the old larvellog to a new filename but i'm not seeing any logs being generated.  I also restarted apache to try to force it to update the log.

@Blade2021 If the 500 error page, that you see, a default-looking white one? Or does the BookStack header still show?

@Blade2021 If it's a default white one, You'll be better checking the apache log, often found here on Ubuntu:
/var/log/apache2/error.log

Ahh! good call!
I pasted the output of the log file here.  Dissecting it now.
https://pastebin.com/xpH4Pvy4

@Blade2021 My guess is that maybe BookStack is running on an older, not supported, version of PHP? I know you stated a PHP version of 7.4 but the output was from the command line, Is Apache using PHP7.4 or is it using an older version of PHP that's still on the system?

@ssddanbrown
When I run php -v it says 7.4 but i'll double check.

Yeah, That will show the command line php version, The version Apache is using can be quite different.

Well solved that problem but broke another.  I have another site that is using php7.0 so disabling php7.0 globally isn't going to work.  Do you know of a way to make php7.4 run for that virtual host?  I did a quick search but every answer was going a completely different direction.

@Blade2021 BookStack will work down to php7.2, So if the other app at least works up to 7.2 maybe you could use that as a common-compatible version?
Otherwise, Have never done mulitple PHP versions on apache, only on Nginx. This guide looks sensible:
https://tecadmin.net/install-multiple-php-version-apache-ubuntu/
You could leave the default version for apache as php 7.0 then only follow the guide for the BookStack install & php7.4, to reduce setup required.

Since this conversation has gone quiet, I'll close this off.


[BEAM-10838] Add SslConfiguration to ElasticsearchIO

Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

@clandry94 thanks for your work !
@egalpin can you take a look ?

Thanks for the contribution @clandry94 !  I’ll have a look over the PR @echauchot 👍

I apologize for the slowness on my review, trying to carve out time.  I've taken a scan so far and the changes look good generally. With respect to tests, I agree that this is a tricky one to draw the lines on.  We don't want to be testing every external module we might use (Ex. we don't directly test the RestClient methods on their own).  Keeping that in mind I think we should be sure to test that the code surrounding SSLContext produces the desired behaviour in the pipeline and place no effort on testing SSLContext directly. I think it would be sufficient to show that any singular code path making use of a non-null SslConfiguration can be used to run a pipeline to read or write data.
My other questions are around backward compatibility/the update story for users with existing pipelines that may need to update to this version. I haven't yet satisfied myself with an answer to the question of whether or not there are compatibility issues.
A few things you could do in the mean time @clandry94 would be ensuring that the tests and spotless linter both pass:

You can run ./gradlew spotlessApply from the top level of the beam project directory on your machine to apply linting changes automatically
You can run ./gradlew :sdks:java:io:elasticsearch-tests:elasticsearch-tests-7:test to run unit tests locally, as it appears as though the new test is failing:  https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/20847/testReport/org.apache.beam.sdk.io.elasticsearch/ElasticsearchIOTest/testSslConfiguration/
Feel free to ignore the Java_Examples_Dataflow_Java17 failure as this is expected and unrelated.

Thanks for all the feedback and no rush reviewing @egalpin, trying to carve out the time on my end too. I started adding unit tests and am planning to clean up this PR and mark it ready for a real review in a week or two.

@egalpin @clandry94 any news on this PR ?

@egalpin can you resume this PR please if it is still relevant with keeping the original commit from @clandry94  ?

Agreed this is a valuable feature to add. @clandry94 are you still interested in continuing this work? If not, I can pick this up and continue on

Unfortunately I won't be able to resume work on this. Thank you for taking over @egalpin!

Thanks @clandry94 for the initial contributions to kick-off this feature !

Thanks to both of you guys !

@egalpin you offered to take over @clandry94. Do we need to reopen


Warnings in compilation 4

g++ -g -Wall -Werror -I. -I../gtest/include -o capn-test.o -c capn-test.cpp
In file included from capn-test.cpp:6:0:
capn.c: In function ‘uint64_t lookup_double(capn_segment**, char**, uint64_t)’:
capn.c:242:23: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
capn.c: In function ‘uint64_t lookup_far(capn_segment**, char**, uint64_t)’:
capn.c:275:22: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
capn.c: In function ‘int copy_ptr(capn_segment*, char*, capn_ptr*, capn_ptr*, int*)’:
capn.c:669:41: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
In file included from capn-test.cpp:7:0:
capn-malloc.c: In function ‘int read_fp(void*, size_t, FILE*, capn_stream*, uint8_t*, int)’:
capn-malloc.c:83:21: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
capn-malloc.c: In function ‘int capn_write_mem(capn*, uint8_t*, size_t, int)’:
capn-malloc.c:195:37: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
capn-malloc.c:211:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
capn-test.cpp: In function ‘void getSegments(capn*, capn_segment**, size_t)’:
capn-test.cpp:280:23: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
capn-test.cpp:284:23: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
capn-test.cpp: In member function ‘virtual void WireFormat_StructRoundTrip_OneSegmentPerAllocation_Test::TestBody()’:
capn-test.cpp:321:58: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
capn-test.cpp: In member function ‘virtual void WireFormat_StructRoundTrip_OneSegmentPerAllocation_NoTag_Test::TestBody()’:
capn-test.cpp:377:58: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
capn-test.cpp: In member function ‘virtual void WireFormat_StructRoundTrip_MultipleSegmentsWithMultipleAllocations_Test::TestBody()’:
capn-test.cpp:427:58: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
cc1plus: all warnings being treated as errors
Makefile:25: recipe for target 'capn-test.o' failed

Fixed in #10


[BD-46] build: add .nvmrc file to www project

Description
Include a description of your changes here, along with a link to any relevant Jira tickets and/or Github issues.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
[ ] Does your change adhere to the documented style conventions?
[ ] Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
[ ] Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
[ ] Were your changes tested in the example app?
[ ] Is there adequate test coverage for your changes?
[ ] Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

[ ] Verify your changes were released to NPM at the expected version.
[ ] If you'd like, share your contribution in #show-and-tell.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

@viktorrusakov Even though your pull request wasn’t merged, please take a moment  to answer a two question survey so we can improve your experience in the future.


[Monitor - Query] LogsQueryClient live tests - server timeout serverTimeoutInSeconds failing in nightly runs

Monitor - Query nightly test runs are failing with:

Error message:
Error does not contain expected details property
Stack trace:
Error: Error does not contain expected details property
at getInnermostErrorDetails (/mnt/vss/_work/1/s/sdk/monitor/monitor-query/test/public/logsQueryClient.spec.ts:532:11)
at Context. (/mnt/vss/_work/1/s/sdk/monitor/monitor-query/test/public/logsQueryClient.spec.ts:499:30)
at processTicksAndRejections (internal/process/task_queues.js:95:5)

For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1690324&view=results

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Monitor - Query:0.5115997,Storage:0.17659214,Monitor:0.08074136'

The same issue occurs again.
For more details check here:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2156659&view=results


Fix method of finding ncxx[4]-config for non-bash shells

type -p is a bashism, and might not work with other shells, e.g. dash on Ubuntu. Instead, use the portable which. This also is consistent for the method for finding the Fortran API.

This has been merged in, closing manually.


Use thunkFetch helper in ad-hoc api calls

thunkFetch is a more recent set of helper functions for making API requests. Many older ad-hoc API calls don't use it. It would probably good to be more consistent and simplify all these older calls by switching to use thunkFetch instead.


connector widget: form resets when switching db

if I fill out the form for a new connection:

and then switch the db from the dropdown, the form resets. it'll be better if it'd kept the values. note that some forms contain different fields (eg duckdb and sqlite only contain alias and database), so we should only fill out the ones that match

one important detail is the alias: if the dropdown is changed, we should only keep the alias if the user modified it. if it didn't, then we should change it for the default alias that corresponds to the selected db in the dropdown

Need some clarifications:

Is this applicable if user clicks the Create button or user types some fields and then selects some other DB (without clicking Create) and the expected behaviour is that the inputs should be retained?
The point that you mentioned about alias, is it not applicable for ports as well?
@edublancas


Fixed broken link in docs

The link for the Atom editor syntax highlighting in the docs was broken. This pull request fixes it

Thanks!


Generalize wsgi FileWrapper so it also works in asgi

We use a WSGI FileWrapper to send files directly from a Django view in two places:
For the HttpResponseSendfile response (used in profile pictures)
https://github.com/Inter-Actief/amelie-private/blob/5c222eb76efa665ac61d4e4c33844e4d65755fe9/amelie/tools/http.py#L41
In the members.views.picture view (which is unused I believe, so this view could just be removed)
https://github.com/Inter-Actief/amelie-private/blob/6753e48c6c3a47c57f50a644251b6df291de8f5c/amelie/members/views.py#L1292
This won't work any more under the newer ASGI standard which will be used in the future, so we need a more general way to do this.
As an example, something like what is used to retrieve the thumbnails in the new photo uploader would work fine I think:
https://github.com/Inter-Actief/amelie-private/blob/6753e48c6c3a47c57f50a644251b6df291de8f5c/amelie/activities/views.py#L735

I just ran into this again when preparing to deploy Amelie to Kubernetes, for which I've tried to use daphne / asgi. This needs to be fixed before we can move over to Kubernetes.
PS. Funnily enough this issue is the 5th hit on DuckDuckGo when searching "wsgiref.util.FileWrapper asgi", which is how I re-found this :laughing:


nixos/mailcatcher: init module for existing package

Motivation for this change
I'm interested in running mailcatcher as a system service.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg test mailcatcher

@aanderse thanks!

@Ma27 If you don't mind would you please also merge https://github.com/NixOS/nixpkgs/pull/56575? Thanks again!


feat: update mermaid to v9.3.0

Update the bundled mermaid version to v9.3.0 to include the latest features and bug fixes (including parsing errors for the gitGraph type of graph which I've been encountering).
Release: https://github.com/mermaid-js/mermaid/releases/tag/v9.3.0
Full changelog: https://github.com/mermaid-js/mermaid/compare/v9.1.7...v9.3.0
The build/update process wasn't described in the README, so I hope I got that right in this PR, let me know if something's wrong!

Sorry for late response. It's really helpful. Thank you.


By default, Agent waste a network call

In Loggregator Release, the agent is configured with an empty availability zone address by default. This means that when dialing the Router, the agent will waste a network call before trying the non-az address. See here.
/cc @JohannaSmith

@enocom the config requires RouterAddrWithAZ to not be empty therefore that will never be an empty string.


[SR-1150] show the latest version in the table that lists your packages

Created by anavarro9731 on 2017-04-04T12:44:04.66.

Please show the latest version in the table that lists your packages, and ideally find a way to show the whole package name. It is really annoying when you have a bunch of packages that start with the same text and you have to hover each one to find the right one.

@anavarro9731 , can please attach a screenshot?

sure.

@jonwchu

Latest Version is now shown on today's Manage Packages view, and the Package and Package ID columns in the old screenshot above have merged so there is a bit more room for longer package id's. However, we still truncate at some point, which I believe is hard to avoid in the current design. Hovering the Package ID reveals the URL though, and the column is now sorted alphabetically.
@skofman1

Closing this issue as per the issue title, the latest version is shown on this view now.
There's another issue tracking refactoring the Manage Packages view: https://github.com/NuGet/NuGetGallery/issues/5616


follows us should be on the top of footer

Description:
We need to add a "Follow Us" section at the top of the footer to enhance our social media presence and encourage user engagement.
Requirements:
HTML Structure:
Create a  with the class name follow-us.
Place it at the top of the footer section.
Content:
Include a heading () with the text "Follow Us".
Add social media icons for the following platforms:
Facebook
Twitter
Instagram
LinkedIn
Ensure each icon links to the corresponding social media page.
Styling:
Align the section in the center.
Use a background color that complements the footer (e.g., #444).
Style the icons with a uniform size and appropriate spacing.
Functionality:
Ensure all social media links are functional.
Acceptance Criteria:
The "Follow Us" section is displayed correctly at the top of the footer.
It matches the specified styles.
All social media links are operational.
Priority:
Medium
Additional Notes:
Please refer to the design mockups for guidance on layout and icon style.

for now it is not required, we will look into it later. so i am closing this issue, and don't create multiple issues


[Bug]: Add gradient hover effect and fix the heading text

Description

I would like to add gradient effects here also.
Also I want to Fix the heading text color.
Please assign this to me under gssoc'23.
Expected Behavior

Show us the trouble with screenshots

Which browsers are affected?
No response
Which OS are affected?
No response
Enter the version of your web browser

Device?
No response
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

@Vaishnavi-Patil2211 can you assign this to me please. I want to add gradients here also

Does it go well @Vaishnavi-Patil2211 ?

I have made the icons to slide on hovering so that it looks good

@Vaishnavi-Patil2211 I have created the pr : https://github.com/OSCode-Community/OSCodeCommunitySite/pull/1102


server: allow listing custom offerings for a running VM

Description
listServiceOffering API when called for a running VM only fails to list all possible offerings especially the custom offerings and all offerings when VM is deployed using a custom offering.
This PR improves the list behviour by adding adding appropriate conditions for the custom offerings.
Fixes #5412

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

Offerings and VMs
(local) 🦐 > list serviceofferings filter=id,name,cpunumber,cpuspeed,memory,serviceofferingdetails
{
  "count": 6,
  "serviceoffering": [
    {
      "cpunumber": 1,
      "cpuspeed": 500,
      "id": "c17c21bb-faa4-4c14-9774-142260546670",
      "memory": 512,
      "name": "Small Instance"
    },
    {
      "cpunumber": 1,
      "cpuspeed": 1000,
      "id": "0a785dc5-ff8d-48ed-82b2-e24cbd9587b9",
      "memory": 1024,
      "name": "Medium Instance"
    },
    {
      "cpunumber": 1,
      "cpuspeed": 1000,
      "id": "3801bb99-4077-4685-919f-2ae51fce90a9",
      "memory": 1536,
      "name": "fixed"
    },
    {
      "cpuspeed": 1000,
      "id": "fe7de1af-b045-4749-a88f-c20a50082c7b",
      "name": "Constrained",
      "serviceofferingdetails": {
        "maxcpunumber": "4",
        "maxmemory": "2560",
        "mincpunumber": "1",
        "minmemory": "256"
      }
    },
    {
      "id": "3799cd94-8284-485e-81f0-bc3c1e6a29f9",
      "name": "Unconstrained"
    },
    {
      "cpuspeed": 1000,
      "id": "b1423e9e-9fcf-48c1-b156-b563cf9bf4dd",
      "name": "Constrained-1",
      "serviceofferingdetails": {
        "maxcpunumber": "4",
        "maxmemory": "3072",
        "mincpunumber": "2",
        "minmemory": "512"
      }
    }
  ]
}
(local) 🦐 > list virtualmachines ids=112b9b4a-12e9-4cfc-8bd7-0e49eabb211f,00774881-64cf-45d1-8c9c-7bdaf7f195da filter=id,name,serviceofferingid,serviceofferingname,details,state
{
  "count": 2,
  "virtualmachine": [
    {
      "details": {
        "cpuNumber": "2",
        "memory": "1024"
      },
      "id": "00774881-64cf-45d1-8c9c-7bdaf7f195da",
      "name": "t5",
      "serviceofferingid": "fe7de1af-b045-4749-a88f-c20a50082c7b",
      "serviceofferingname": "Constrained",
      "state": "Running"
    },
    {
      "details": {},
      "id": "112b9b4a-12e9-4cfc-8bd7-0e49eabb211f",
      "name": "t3",
      "serviceofferingid": "c17c21bb-faa4-4c14-9774-142260546670",
      "serviceofferingname": "Small Instance",
      "state": "Running"
    }
  ]
}

Before change:
(local) 🐣 > list serviceofferings filter=id,name,cpunumber,cpuspeed,memory,serviceofferingdetails virtualmachineid=112b9b4a-12e9-4cfc-8bd7-0e49eabb211f
{
  "count": 2,
  "serviceoffering": [
    {
      "cpunumber": 1,
      "cpuspeed": 1000,
      "id": "0a785dc5-ff8d-48ed-82b2-e24cbd9587b9",
      "memory": 1024,
      "name": "Medium Instance"
    },
    {
      "cpunumber": 1,
      "cpuspeed": 1000,
      "id": "3801bb99-4077-4685-919f-2ae51fce90a9",
      "memory": 1536,
      "name": "fixed"
    }
  ]
}
(local) 🐓 > list serviceofferings filter=id,name,cpunumber,cpuspeed,memory,serviceofferingdetails virtualmachineid=00774881-64cf-45d1-8c9c-7bdaf7f195da

After change:
(local) 🐕 > list serviceofferings filter=id,name,cpunumber,cpuspeed,memory,serviceofferingdetails virtualmachineid=112b9b4a-12e9-4cfc-8bd7-0e49eabb211f
{
  "count": 5,
  "serviceoffering": [
    {
      "cpunumber": 1,
      "cpuspeed": 1000,
      "id": "0a785dc5-ff8d-48ed-82b2-e24cbd9587b9",
      "memory": 1024,
      "name": "Medium Instance"
    },
    {
      "cpunumber": 1,
      "cpuspeed": 1000,
      "id": "3801bb99-4077-4685-919f-2ae51fce90a9",
      "memory": 1536,
      "name": "fixed"
    },
    {
      "cpuspeed": 1000,
      "id": "fe7de1af-b045-4749-a88f-c20a50082c7b",
      "name": "Constrained",
      "serviceofferingdetails": {
        "maxcpunumber": "4",
        "maxmemory": "2560",
        "mincpunumber": "1",
        "minmemory": "256"
      }
    },
    {
      "id": "3799cd94-8284-485e-81f0-bc3c1e6a29f9",
      "name": "Unconstrained"
    },
    {
      "cpuspeed": 1000,
      "id": "b1423e9e-9fcf-48c1-b156-b563cf9bf4dd",
      "name": "Constrained-1",
      "serviceofferingdetails": {
        "maxcpunumber": "4",
        "maxmemory": "3072",
        "mincpunumber": "2",
        "minmemory": "512"
      }
    }
  ]
}
(local) 🦑 > list serviceofferings filter=id,name,cpunumber,cpuspeed,memory,serviceofferingdetails virtualmachineid=00774881-64cf-45d1-8c9c-7bdaf7f195da
{
  "count": 3,
  "serviceoffering": [
    {
      "cpuspeed": 1000,
      "id": "fe7de1af-b045-4749-a88f-c20a50082c7b",
      "name": "Constrained",
      "serviceofferingdetails": {
        "maxcpunumber": "4",
        "maxmemory": "2560",
        "mincpunumber": "1",
        "minmemory": "256"
      }
    },
    {
      "id": "3799cd94-8284-485e-81f0-bc3c1e6a29f9",
      "name": "Unconstrained"
    },
    {
      "cpuspeed": 1000,
      "id": "b1423e9e-9fcf-48c1-b156-b563cf9bf4dd",
      "name": "Constrained-1",
      "serviceofferingdetails": {
        "maxcpunumber": "4",
        "maxmemory": "3072",
        "mincpunumber": "2",
        "minmemory": "512"
      }
    }
  ]
}

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1179

@blueorangutan test

@blueorangutan test

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-2004)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35694 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5420-t2004-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

ping @shwstppr - can you fix the conflict?

@blueorangutan package

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 1267

@blueorangutan package

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15.  I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1284

@blueorangutan test centos7 vmware-67u3

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

Trillian test result (tid-2084)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41764 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5420-t2084-vmware-67u3.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test
Result
Time (s)
Test File

Merging based on approvals and test results


Recording won't grab typing unless a tab has been pressed.

So basically I have a typeahead component in react. I'm trying to test that when I type something the list appears and I can click a button in that list. It registers that I clicked the input to focus on it, but not that I typed anything because I didn't hit tab to navigate away. Can we change it so that when I lose focus from that input it adds the text?

I literally tried doing that and @tnolet is right. it does mess up a lot of cases. For example, just moving your mouse in and out of focus on an input will cause the type command over and over again.

Closing this. For now hitting TAB is the correct way to record input. Focus / unfocus will become a mess.


Refactor equipment sync stuff

The current names don't convey that they are sync stuff.

Most important entity data are already registered to the data tracker and synced. This change imo is bad unless there is already a non-synced (which non-syncing is the best behavior than an error) component of equipments.

This change imo is bad unless there is already a non-synced (which non-syncing is the best behavior than an error) component of equipments.

There is a "non-synced" version called LivingEntity#getEquippedStack.
The method method_30129 compares getEquippedStack and method_30125 (or method_30126) to compute the difference between the last sent one and the current one. This difference is sent as an EntityEquipmentUpdateS2CPacket, not through the data tracker system.

Im slightly uneasy about this change, I will need to take a closer look at the code to gain an understanding of the change, but I think it boils down to if it really does mean something else for the majority of cases.
This rename is highly impactful, so before we go through with it I want to make sure its the right thing to do.

This rename is highly impactful, so before we go through with it I want to make sure its the right thing to do.

That was my instinct upon seeing this as well, but it turns out all these methods and fields are all private. They are details around keeping track and sending equipment stacks to the client.

Ah, if these are private and not the ones used by most people then it sounds a lot less impacful, I will take a look at the code before i jump to any more conclusions. 👍

someone mind take a look in enigma and review this?

Looks good to me!


Fixes #46: Show Scrollbar on mousemove in component

closes: https://github.com/alphasights/ember-scrollable/issues/46
relates to: https://github.com/alphasights/ember-scrollable/pull/48/files#diff-499447ac5ce8a7c1077b7503f9403d0dL340
Removed Ember.K since I was in the vicinity: https://github.com/emberjs/rfcs/pull/178

👍  good find. Thanks for taking the time to get these fixes in @alexander-alvarez.


[Publication][Admin area]: Dots on request icons and counter should have purple color for prompt panel

EPAM AI DIAL chat version
0.16.0
How to reproduce
Steps:

create publication rquests for prompts
admin  review Approve required section for prompts

Actual result
dots on requests and counter have green color

Expected result
Dots on request icons and counter should have purple color for prompt panel
Confidential information

[X] I confirm that do not share any confidential information

Dots are green for prompts

Verified on staging env (light and dark themes) successfully

Note that there is specific colours in Light Orange theme (orange icons for both)


Read support

Is it possible to read from the device via Input Report?

Not yet. you'll need to implement it yourself. But it shouldn't be a big deal... Sorry that I've no time for this at the moment. But I would be happy if someone could send a PR

I have read support working on all three platforms in my fork: https://github.com/flynn/hid
This fork is maintained to support my U2F package: https://github.com/flynn/u2f
Feel free to upstream any commits that you'd like, I had to rearrange some things to fit my needs.

It would be very great to add read support on this repo (ucase: read serial for a blinkstick product)

Hi,
I've added read support on https://github.com/boombuler/hid/tree/read which is very basic and is only implemented for OSX. If anyone could provide linux / windows code, I would be happy to merge it to master...

Thanks a lot. Just a question on how to use it, In Python, read serial for Blinkstick is done with
 usb.util.get_string(self.device, length, index)
 usb.util.get_string(self.device, 256, 3)

How to get same information with read func ?

There is also some read support for all platform in https://github.com/flynn/hid

Hi again.
I've modified the source a little.
@titanous I've read through your osx source code and if I'm correct you would lock an OS thread for each device you are listening to. Correct? My implementation of "Listen" should not have this issue (but may have others...). I would also like a funktion to stop listening to the given device...
@yesnault with the newest version the following code should give some results:
stop := make(chan struct{})
reports, errors := device.Listen(stop)
go func() {
	for {
		select {
		case rep := <-reports:
			fmt.Println("Report:", rep)
		case err := <-errors:
			fmt.Println("Error:", err)
		case <-stop:
			return
		}
	}
}()
fmt.Scanln()
close(stop)


kcp OWNERS files

As we keep growing it may make sense to start implementing more granular OWNERS files so that we can build our cadre of reviewers and approvers like other upstream communities.
Goals:

Agree that we want to use OWNERS files
Seed areas where people are already comfortable reviewing

If you like this idea and have an area you feel like you have enough context to review please note that in this issue.

At least in the repo root

I think this would be really helpful, another thing to consider would be to implement a reviewer to approver guidelines and maybe seed the root files with reviewers?


make GCC version regex more specific

allowing also uncommon version identifiers to be matched correctly
Note: I've originally found a problem with the regex when working on https://github.com/msys2/MINGW-packages/pull/8353.
As this was half a year ago (the main issue that PR tackled is now solved differently so no need to fix that) I can't remember the details where the old one failed - please inspect the regex change and consider it when it works "as good as the old one" (I'm quite sure I've tested that back then).
Thank you!

Imho all that version checking code could be removed. They check for 20(!!!) year old gcc/binutils

Sadly numpy depends on all the internals, so not that easy :(

For now I've just adjusted the regex again, now all of those tests samples pass. The real culprit is that I don't have my notes from several months ago which version string was broken... but with the optional spacing the new regex should match all those fine.

Imho all that version checking code could be removed. They check for 20(!!!) year old gcc/binutils

This is now happening in #77


Add stub for FormRequest::validated

[X] Added or updated tests
[ ] Documented user facing changes

Changes
I've added validated to the FormRequest stub, as I was running into issues with its current mixed return type:
$item = Item::create($request->validated());

Parameter $attributes of static method Illuminate\Database\Eloquent\Builder<App\Models\Item>::create() expects array<string, mixed>, mixed given.

Breaking changes

Thank you!


Add inflation updateright assignment for rgb21

Please isolate the change in a single commit, not duplicating the stuff from #158 and not polluting the commit history. In such a way I can review and merge this PR before #158 got fixed. Regarding plenty of commits doing and redoing the same things over and over - will squash them into a single one even if you will keep to bloat the history.

Needs rebase and removal of all commits unrelated to the specific proposed change


Add localisation for Apps

Summary
Send the locale of the acting user with all calls so the App can perform localisations.
Ticket Link
https://mattermost.atlassian.net/browse/MM-32335

Codecov Report

Merging #227 (098b06d) into master (ca8aa4b) will decrease coverage by 0.04%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   21.97%   21.92%   -0.05%
==========================================
  Files          52       52
  Lines        3049     3065      +16
==========================================
+ Hits          670      672       +2
- Misses       2322     2336      +14
  Partials       57       57

Impacted Files
Coverage Δ

server/httpin/restapi/app.go
0.00% <0.00%> (ø)

server/proxy/oauth2.go
0.00% <0.00%> (ø)

utils/utils.go
0.00% <0.00%> (ø)

server/proxy/proxy.go
27.02% <50.00%> (+0.25%)
:arrow_up:

server/proxy/bindings.go
84.76% <100.00%> (+0.14%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca8aa4b...098b06d. Read the comment docs.

@hanzei Friendly reminder for review.

Docs PR: https://github.com/mattermost/mattermost-developer-documentation/pull/922

@DHaussermann Heads up that we are merging this without QA Review.


MPI Cannot Find Executable

Expected Behavior
I am trying to run mmseqs cluster with the MPI runner option across two nodes (master, slave), but I am unable achieve this effect. I have configured passwordless ssh from master to slave through an ssh-key transfer. SSH can be accomplished through ssh slave. Moreover, there is a common NFS mounted to both nodes.
Steps to Reproduce (for bugs)
First, I cd into the NFS directory ('/mnt'), then create the DB:
mmseqs createdb /mnt/QUERY.fasta /mnt/DB
which runs as expected. Then I run
RUNNER="mpirun -np 4 --host master,slave" mmseqs cluster /mnt/DB /mnt/clu /mnt/tmp
where /mnt is a NFS that is mounted to both the master and slave nodes.
MMseqs Output (for bugs)
Program call:
/mnt/DB /mnt/clu /mnt/tmp

MMseqs Version:                                                                 4f4d8125bed29b21005ea9c8ddf91ebc193be4ae-MPI
Sub Matrix                                                                      blosum62.out
Sensitivity                                                                     4
K-mer size                                                                      0
K-score<PHONE_NUMBER>
Alphabet size                                                                   21
Max. sequence length                                                            65535
Max. results per query                                                          20
Offset result                                                                   0
Split DB                                                                        0
Split mode                                                                      2
Split Memory Limit                                                              0
Coverage threshold                                                              0.8
Coverage Mode                                                                   0
Compositional bias                                                              1
Diagonal Scoring                                                                1
Exact k-mer matching                                                            0
Mask Residues                                                                   1
Minimum Diagonal score                                                          15
Include identical Seq. Id.                                                      false
Spaced Kmer                                                                     1
No preload                                                                      false
Early exit                                                                      false
Pseudo count a                                                                  1
Pseudo count b                                                                  1.5
Threads                                                                         2
Verbosity                                                                       3
Add backtrace                                                                   false
Alignment mode                                                                  3
E-value threshold                                                               0.001
Seq. Id Threshold                                                               0
Alternative alignments                                                          0
Realign hit                                                                     false
Max Reject<PHONE_NUMBER>
Max Accept<PHONE_NUMBER>
Cluster mode                                                                    0
Max depth connected component                                                   1000
Similarity type                                                                 2
Single step clustering                                                          true
Cascaded clustering steps                                                       3
Remove Temporary Files                                                          false
Sets the MPI runner                                                             mpirun -np 4 --host master,slave
Compositional bias                                                              1
Kmer per sequence                                                               20
Shift hash                                                                      5
Include only extendable                                                         false
Skip sequence with n repeating k-mers                                           0
Rescore mode                                                                    0
Remove hits by seq.id. and coverage                                             false
In substitution scoring mode, performs global alignment along the diagonal      false
Set cluster settings automatic to s=6
Set cluster mode SET COVER.
Set cluster iterations to 3
Program call:
/mnt/DB /mnt/tmp/4359821638123540538/clu_redundancy /mnt/tmp/4359821638123540538/linclust --cluster-mode 0 -v 3 --max-iterations 1000 --similarity-type 2 --threads 2 -
-sub-mat blosum62.out --alignment-mode 3 -e 0.001 --min-seq-id 0 --alt-ali 0 -c 0.8 --cov-mode 0 --max-seq-len 65535 --max-seqs 20 --comp-bias-corr 1 --max-rejected 21
47483647 --max-accept<PHONE_NUMBER> --pca 1 --pcb 1.5 --alph-size 13 --kmer-per-seq 20 --mask 0 -k 0 --hash-shift 5 --split-memory-limit 0 --skip-n-repeat-kmer 0 --rescor
e-mode 0
MMseqs Version:                                                                 4f4d8125bed29b21005ea9c8ddf91ebc193be4ae-MPI
Cluster mode                                                                    0
Verbosity                                                                       3
Max depth connected component                                                   1000
Similarity type                                                                 2
Threads                                                                         2
Sub Matrix                                                                      blosum62.out
Add backtrace                                                                   false
Alignment mode                                                                  3
E-value threshold                                                               0.001
Seq. Id Threshold                                                               0
Alternative alignments                                                          0
Coverage threshold                                                              0.8
Coverage Mode                                                                   0
Max. sequence length                                                            65535
Max. results per query                                                          20
Compositional bias                                                              1
Realign hit                                                                     false
Max Reject<PHONE_NUMBER>
Max Accept<PHONE_NUMBER>
Include identical Seq. Id.                                                      false
No preload                                                                      false
Early exit                                                                      false
Pseudo count a                                                                  1
Pseudo count b                                                                  1.5
Alphabet size                                                                   13
Kmer per sequence                                                               20
Mask Residues                                                                   0
K-mer size                                                                      0
Shift hash                                                                      5
Split Memory Limit                                                              0
Include only extendable                                                         false
Skip sequence with n repeating k-mers                                           0
Rescore mode                                                                    0
Remove hits by seq.id. and coverage                                             false
In substitution scoring mode, performs global alignment along the diagonal      false
Remove Temporary Files                                                          false
Sets the MPI runner                                                             mpirun -np 4 --host master,slave
--------------------------------------------------------------------------
mpirun was unable to launch the specified application as it could not find an executable:
Executable: mmseqs
Node: slave
while attempting to start process rank 1.
--------------------------------------------------------------------------
2 total processes failed to start
Error: Alignment step died
Error: linclust died

I performed identical installations of mmseqs on both machines. If I just run mmseqs cluster /mnt/DB mnt/clu /mnt/tmp on either machine, then it is able to work, but I would like to get the MPI functionality up if possible! Thank you.
Your Environment
I am working in Debian 8 (Jesse), and have compiled MMseqs2 from source with the DHAVE_MPI=1 flag when invoking cmake.
Thank you for your help!

I think the issue might be with my OpenMPI installation more generally, as I cannot get their hello_c program to function properly. Do you suggest locally installing a separate local OpenMPI installation? I am having trouble figuring out how to configure everything so as to work properly. Thanks!

I am sorry, I don't think we can help with MPI issues. A separate installation is probably a bad idea, since its usually tailored to the local cluster installation. I would suggest to contact your local IT support.


unmet dependencies

The following packages have unmet dependencies:  dpkg-dev : Depends: libdpkg-perl (= 1.17.5ubuntu5.7) but 1.18.18 is to be installed E: Unable to correct problems, you have held broken packages.
Ubuntu 14.04 with all updates.

Can you be more specific I need more information to replicate it? Ubuntu server? 32 or 64 bit, where and how are you using it, etc?

Ubuntu 14.04 i386 - I already fixed it - maybe for future users of your script you can replace apt-get to aptitude because the last one offer some help to fix broken dependencies. Also - thank you for this script.

Would you mind contributing a pull request? When I originally wrote this script I was using Trusty, but I've changed companies since then and use OSX. If something changes about a dependency I'm not going to know unless people like you bring it to my attention/contribute fixes.

@vitaly-zdanevich how did you fix it? I'm getting that problem when running the script:
dpkg: warning: downgrading git from 1:2.14.1-1.1~ppa0~ubuntu14.04.1 to 1:1.9.1-1ubuntu0.6
(Reading database ... 238691 files and directories currently installed.)
Preparing to unpack .../git_1.9.1-1ubuntu0.6_amd64.deb ...
Unpacking git (1:1.9.1-1ubuntu0.6) over (1:2.14.1-1.1~ppa0~ubuntu14.04.1) ...
dpkg: dependency problems prevent configuration of git:
git depends on git-man (<< 1:1.9.1-.); however:
Version of git-man on system is 1:2.14.1-1.1~ppa0~ubuntu14.04.1.
dpkg: error processing package git (--install):
dependency problems - leaving unconfigured
Errors were encountered while processing:
git

I'm closing this issue, I've got a faux-suite of docker tests and I'm able to build from source on ubuntu 14.04, 16.04, 18.04, 18.10, and 19.04 without un-met dependencies.


python unit test example

Hey Rishab!  I mentioned on the LinkedIn thread about adding unit tests - here's a quick example.  Not the most comprehensive testing, perhaps, but enough to have something there for the learner to see it, know how it works, etc.  Having tests available gives the learner an opportunity to start mapping out a more realistic delivery pipeline:
Commit -> Test -> (tests pass) Build -> Deploy
               +> (tests fail) Alert

Software testing is a woefully underrepresented discipline among software engineers bc most larger orgs have carved it out as a separate part of the organization - "send it to the QA department".  As we bring the Dev and Ops communities back together in the new paradigm, encouraging the programmer to test their own work and also to automate the testing of their own work provides the confidence that changes don't break things and ultimately gets their code to production faster.
#> pip install pytest
#> pytest

That is a great suggestion @LinkBenjamin I will get that added to the challenge itself.


Domain mode bypasses setup

Hi,
Specifying parameters for a domain node has no actual effect on the settings file host-master.xml and the code of class wildfly::setup shows why (https://github.com/biemond/biemond-wildfly/blob/master/manifests/setup.pp#L16) . How can I use a different binding address (other than <IP_ADDRESS>) for instance?

@xaniasd I've been discussing this in another issue: https://github.com/biemond/biemond-wildfly/issues/36#issuecomment-113781155
Unfortunately, I did not have time to came up with a solution. If you need to handle binding address in domain you'll need to use wildfly_cli.

@jairojunior I see that the port management is more complex but the binding address is doable. I got it working as follows:
define wildfly::config::interfaces($inet_address_value){
  $root = $wildfly::mode ? {
    'domain' => 'host',
    default  => 'server'
  }

  augeas { $name:
    lens    => 'Xml.lns',
    incl    => "${wildfly::dirname}/${wildfly::mode}/configuration/${wildfly::config}",
    changes => "set ${root}/interfaces/interface[#attribute/name='${name}']/inet-address/#attribute/value ${inet_address_value}",
    onlyif  => "match ${root}/interfaces/interface[#attribute/name='${name}']/inet-address[#attribute/value='${inet_address_value}'] size == 0"
  }
}

If I find something similar for port settings I'll let you know.

@xaniasd Unfortunately, it only solves part of the problem, host*.xml files also have interface configuration.
I think we should replace augeas for wildfly_cli in the future, since it's more portable across different operations mode (standalone and domain).
By the way, I don't think domain mode and Puppet are a good match. Maybe this comment will make you think about it: https://github.com/cpitman/puppet-jboss_admin/issues/68#issuecomment-95934493
Thank you for collaborating. =)

Hi Jairo,
very valid points, both of them :) I'm using Puppet to manage an existing installation as a first step. Second step is changing it to standalone instances.
regards

Glad to hear that. =)

Just fixed it with JBOSS_OPTS in the latest PR.


A few things to speed up inference on 8gb cards and keep them from OOMing with Q4

Something about the latest update has destroyed performance on 8gb cards, when they were working fine before. For now, I've found adding torch.cuda.empty_cache() to the def forward in ops.py mitigates it somewhat. Before this update, I was getting ~3 sec/it, now, even with this hacky fix, it's still ~6-7 sec/it. If this isn't added, the iteration times will jump up exponentially into the 15-30 second range since it's spilling over into sysmem.
class GGMLOps(comfy.ops.disable_weight_init):
    """
    Dequantize weights on the fly before doing the compute
    """
    class Linear(GGMLLayer):
        def __init__(self, *args, device=None, dtype=None, **kwargs):
            super().__init__(device=device, dtype=dtype)
            self.parameters_manual_cast = torch.float32

        def forward(self, x):
            with torch.no_grad():
                weight, bias = self.get_weights(x.dtype)
                x = torch.nn.functional.linear(x, weight, bias)
                del weight, bias
                torch.cuda.empty_cache()
            return x

Also, it might be helpful to add an option to switch between fp16 and fp32. I did some testing and the image output was almost identical. Overall, you couldn't see a difference between them unless you arithmetically compared the two with image operations. If I set it to float16 here, instead of 32, it will cut inference times down from ~6.5 sec/it to 4.4 sec/it
Within dequant.py
        else:
            # dequant in fp32, convert to target
            return dequantize(data, qtype, oshape, dtype=torch.float16).to(dtype)

A quick weird and high contrast image with only 20 steps(save me some time)
Float16:

Float32:

Here is the difference with an extremely low exponent value to blow out the differences:

I was having most of the noticeable changes with Q8_0 via FP32 dequant VS FP16 casting, though it seemed more like a sidegrade. I'll run another test later this evening and possibly revert to (none) for the dequant and casting on return.

Yeah, I don't think Q4_0 image quality actually changed after all.
FP16 should be a no-op but could you see what happens if you use this:
return dequantize(data, qtype, oshape, dtype=None).to(dtype)

It might be faster while also solving the vram leak. I'm not too fond of spamming torch.cuda.empty_cache() inside a loop.

Odd, seems like it's not cleaning up the intermediate values inside the dequant functions when it's doing them in FP32 for some reason. I don't think the safetensors thing is the same, though it could be that something similar to what you describe. i.e. it needs space for the intermediary values when unpacking them before quantizing it back down like you say.
Another thing you could try is to let it do BF16 directly via this version:
return dequantize(data, qtype, oshape, dtype=dtype)

Ah right, if your card doesn't have bfloat then I think everything would be happening in FP16? That would explain at least some of what you're seeing as well as why the images in your tests were a lot more similar.

Ah right, if your card doesn't have bfloat then I think everything would be happening in FP16? That would explain at least some of what you're seeing as well as why the images in your tests were a lot more similar.

Is it normal that a T4 GPU cannot load the 4-bit quantized models?

I changed it back for now, the increase in quality seemed more like a sidegrade even with BF16 according to most people and the increase in vram usage/possible memory leak is not worth it.

I meant that for it already being in fp16 then doing .to() on it, which was still slowing it down. I guess checking the device/dtype adds some overhead. Anyway, closing this one for now.


docs: allow plnkr links to open in new window

(with ctrl + click)
We could also make this the default, but I don't know if popup-blockers will still block this
Closes #8328

:+1:


tutorial: notebook 4 (advanced concepts: caching/saving)

all notebooks should show single story from beginner to advanced user
goals:

learn how to use advanced concept in Steps:

caching
persist-to-disk/save output
force-fit

merged in the steppy-tutorials repo.


files missing and could you please share your Vectors

Hello there, Thanks for sharing your great jobs. And I want to review some SOTA with your code, but when I want to use /bin/run_bimpm.py, I found that you use import like this: from glyce.models.sem_sim.model import BIMPM, however, there is not module named sem_sim in model, is it missing or you just not upload it ?
Luckly, I find that there is an module named bimpm and it contains BiMpm class, I want to try if it works, again, we missing some things like vector file of BQ300.
So, could you please check these issues and share others things to reuse these works?
Thanks a lot!

Thanks for your feedback. I will check these issues and update the other things. I am free these days. :-)


Install_yamls ansible role wrapper

This PR has:

[x] Appropriate testing (molecule, python unit tests)
[x] Appropriate documentation (README in the role, main README is up-to-date)

Thank you @cjeanner for the review and improvement suggestions. I tried to address almost all the comments. Do let me know if I missed anything.

/lgtm
At last :). We'll iterate if we face any issues when we put this new content to use.


Add sample Keras model to minio images

Since ModelMesh supports deploying Keras models as noted here, we should ensure that our minio images have a sample Keras model that users can try.
Both the FVT and quickstart image should probably be updated:
kserve/modelmesh-minio-dev-examples
kserve/modelmesh-minio-examples

/assign @tedhtchang

@pvaneck Image updated in my docker hub
Updated some doc here: #109

Docker images updated in KServe repository and #109 merged.


Can't register PNG image with RegisterImageOptionsReader

Hello,
I get an "EOF" error when I try to load a PNG image from a []byte through RegisterImageOptionsReader.
The call flow is the following :
output.AddPage()
contentReader := bytes.NewReader(content)
imgInfo := output.RegisterImageOptionsReader(img.name, gofpdf.ImageOptions{ImageType: img.extension, ReadDpi: true}, contentReader)

Where content is a []byte resulting from :
png.Encode(bufio.NewWriter(&resizedContent), resize)
...
resizedContent.Bytes()

The RegisterImageOptionsReader call f.parsepng(r, options.ReadDpi) (line 2512 from fpdf.go) that call f.parsepngstream(buf, readdpi) (line 2897 on fpdf.go) that call int(f.readBeInt32(buf)) (line 87 from png.go) that call err := binary.Read(r, binary.BigEndian, &val) (line 2901 from fpdf.go) that return "EOF" error at the end of the file (normal).
This "EOF" error is back propagated up to RegisterImageOptionsReader on line up to :
	if f.err != nil {
		return
	}
	info.i = len(f.images) + 1
	f.images[imgName] = info

And because f.err = "EOF" the image is finally not added to PDF despite everything is fine.
I've I missed something ?

Hmm... I haven't looked into this in too much detail yet, but I do know that EOF is actually the expected return value for a successful call to some readers in Go's standard library. In cases like this, it is standard to have an expression like
if err == io.EOF {
    err = nil
}

Also, the documentation for binary.Read() states the EOF is returned only when no bytes are read. Can you uncover why the reader in that call to binary.Read() is empty?

The EOF isn’t returned on first loop iteration, they success to read almost all data.
I suspect you get an EOF because n := int(f.readBeInt32(buf)) is called once too often in parsepngstream.

Le 18 sept. 2018 à 15:46, Kurt Jung<EMAIL_ADDRESS>a écrit :
Hmm... I haven't looked into this in too much detail yet, but I do know that EOF is actually the expected return value for a successful call to some readers in Go's standard library. In cases like this, it is standard to have an expression like
if err == io.EOF {
err = nil
}
Also, the documentation for binary.Read() https://golang.org/pkg/encoding/binary/#Read states the EOF is returned only when no bytes are read. Can you uncover why the reader in that call to binary.Read() is empty?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/jung-kurt/gofpdf/issues/193#issuecomment-422399595, or mute the thread https://github.com/notifications/unsubscribe-auth/ABnsCaZxruGgbJ3P53iLXCpm4u9B5CAmks5ucPk6gaJpZM4Wt7FB.

Good observation -- I will investigate this further.

I have started to delve into this issue and cannot duplicate your results.

I suspect you get an EOF because n := int(f.readBeInt32(buf)) is called once too often in parsepngstream

I don't think so. In readBeInt32, io.EOF cannot be assigned to the pdf instance. Maybe some other read method?
Can you extend TestIssue0193 with as little code as possible to duplicate the response you get?

Hello @jung-kurt ,
I have extended TestIssue0193 and it seems the problem comes from another lib I use to resize image before register it into the PDF.
I will investigate further on this side and apologize for inconvenience.

Thanks for the update, @protheusfr.


MP4 video is not playing on mobile devices for Reactjs Website | React V.17.0.2

Version: React V.17.0.2 and Node V.16.13.0
We have developed a site using React-js, HTML, CSS. And stored data in JSON. Currently facing an issue for the video frame for our landing page.
   <video id='myVideo' autoPlay loop muted>          <source src={clip} type='video/mp4' />    </video>
Now the issue is, This video plays well on local server on all devices whereas only on laptops for live server but mobile devices.
We have tried several npms to make the video autoplay on mobile device but none of them seem to be working.
npms tried: react-native-video, video-player, react-video
Please suggest me the perfect solution for the issue which i am facing in my react app.

use shakra player or Video.js, react native web support has been dropped on V6.0.0


Vrhealthypartial

check for /healthy == "0 running" before applying partial config

integrated health check into vrsros-partial-config


RaceAlarm will not fire in certain use case

The new RaceAlarm class properly handles the case where the user disables race reminders after the alarm is set, but fails to correctly handle the case where the user re-enables the race reminders after the RaceAlarm class has determined not to set an alarm.
Either need to be notified of preference changes or always set the alarm, but only show the reminder notification if enabled.

To be notified of preference changes, a OnSharedPreferenceChangeListener can be used:
http://developer.android.com/reference/android/content/SharedPreferences.OnSharedPreferenceChangeListener.html
In the listener, the alarm can be set or cancelled based on the new setting. The listener must be registered by calling registerOnSharedPreferenceChangeListener().


using QuantEcon failing on v0.4

Anyone know why this is happening with the master branch on v0.4?
julia> using QuantEcon
WARNING: requiring "Distributions" did not define a corresponding module.
WARNING: requiring "Distributions" did not define a corresponding module.
WARNING: requiring "Distributions" did not define a corresponding module.
WARNING: module Util should explicitly import * from Base
WARNING: module Filters should explicitly import * from Base
WARNING: requiring "Distributions" did not define a corresponding module.
WARNING: requiring "Distributions" did not define a corresponding module.
ERROR: LoadError: LoadError: UndefVarError: MultivariateNormal not defined
 in include at /usr/local/Cellar/julia/HEAD/lib/julia/sys.dylib
 in include_from_node1 at /usr/local/Cellar/julia/HEAD/lib/julia/sys.dylib
 in include at /usr/local/Cellar/julia/HEAD/lib/julia/sys.dylib
 in include_from_node1 at /usr/local/Cellar/julia/HEAD/lib/julia/sys.dylib
 in require at /usr/local/Cellar/julia/HEAD/lib/julia/sys.dylib
while loading /Users/zaccranko/.julia/v0.4/QuantEcon/src/lss.jl, in expression starting on line 41
while loading /Users/zaccranko/.julia/v0.4/QuantEcon/src/QuantEcon.jl, in expression starting on line 120

Will you give me the output of versioninfo()

julia> versioninfo()
Julia Version 0.4.0-dev+6642
Commit 58dc82f* (2015-08-11 23:19 UTC)
Platform Info:
  System: Darwin (x86_64-apple-darwin15.0.0)
  CPU: Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
  WORD_SIZE: 64
  BLAS: libopenblas (NO_AFFINITY HASWELL)
  LAPACK: libopenblas
  LIBM: libopenlibm
  LLVM: libLLVM-3.3

I haven't tried on today's master.
Can you load distributions by itself?

I did try that, Distributions loads without complaint

Hmm.
Have you by chance tried using Base.compile with these packages?
If so maybe try deleting the cache files...

I haven't, this is a completely clean build of Julia that i haven't messed with. Is Travis building v0.4?

I don't think we've pushed to master recently enough.
That's is quite strange. I guess you could try the nuclear option and delete your whole package directory... I don't have great advice for this thing

Okay so just did rm -rf ~/.julia/v0.4 then Pkg.add("QuantEcon"), bad news still getting the same issue
julia> using QuantEcon
WARNING: requiring "Distributions" did not define a corresponding module.
WARNING: requiring "Distributions" did not define a corresponding module.
WARNING: requiring "Distributions" did not define a corresponding module.
WARNING: module Util should explicitly import * from Base
INFO: Recompiling stale cache file /Users/zaccranko/.julia/lib/v0.4/Polynomials.ji for module Polynomials.
WARNING: module Filters should explicitly import * from Base
INFO: Recompiling stale cache file /Users/zaccranko/.julia/lib/v0.4/Docile.ji for module Docile.
INFO: Recompiling stale cache file /Users/zaccranko/.julia/lib/v0.4/LightGraphs.ji for module LightGraphs.
INFO: Recompiling stale cache file /Users/zaccranko/.julia/lib/v0.4/GZip.ji for module GZip.
INFO: Recompiling stale cache file /Users/zaccranko/.julia/lib/v0.4/StatsBase.ji for module StatsBase.
INFO: Recompiling stale cache file /Users/zaccranko/.julia/lib/v0.4/ArrayViews.ji for module ArrayViews.
INFO: Recompiling stale cache file /Users/zaccranko/.julia/lib/v0.4/StatsFuns.ji for module StatsFuns.
INFO: Recompiling stale cache file /Users/zaccranko/.julia/lib/v0.4/LightXML.ji for module LightXML.
INFO: Recompiling stale cache file /Users/zaccranko/.julia/lib/v0.4/ParserCombinator.ji for module ParserCombinator.
INFO: Recompiling stale cache file /Users/zaccranko/.julia/lib/v0.4/AutoHashEquals.ji for module AutoHashEquals.
WARNING: requiring "Distributions" did not define a corresponding module.
WARNING: requiring "Distributions" did not define a corresponding module.
ERROR: LoadError: LoadError: UndefVarError: MultivariateNormal not defined
 in include at /usr/local/Cellar/julia/HEAD/lib/julia/sys.dylib
 in include_from_node1 at /usr/local/Cellar/julia/HEAD/lib/julia/sys.dylib
 in include at /usr/local/Cellar/julia/HEAD/lib/julia/sys.dylib
 in include_from_node1 at /usr/local/Cellar/julia/HEAD/lib/julia/sys.dylib
 in require at /usr/local/Cellar/julia/HEAD/lib/julia/sys.dylib
while loading /Users/zaccranko/.julia/v0.4/QuantEcon/src/lss.jl, in expression starting on line 41
while loading /Users/zaccranko/.julia/v0.4/QuantEcon/src/QuantEcon.jl, in expression starting on line 120

Hmm not sure.
I tried scanning the commit log for Julia for today and didn't notice anything that would explain this.
Unfortunately I need my Julia to be fully working to do my research so I can't really  hop on the latest master to debug with you.
I suppose I could do it within a docker container or something, do you reckon it's woth it?

I was able to reproduce it with the binary off julialang.org: https://status.julialang.org/download/osx10.7+
so you could grab that and see if its happening for you.

Yep. I'll try pretty soon.
We haven't pushed to master to register a build on Travis so I'm not sure

I did have the same problems with the binary.
Doing
rm -rf ~/.julia/lib

Then
julia> Base.compilecache(:Distributions)
"/Users/sglyon/.julia/lib/v0.4/Distributions.ji"

julia> Base.compilecache(:QuantEcon)

fixed it for me.
I did have to move to the master version of Docile.jl and I was already on the master of distributions (not sure if being on Distributions master is necessary).

What was the problem?

not sure...
Somehow forcing a cached version of Distributions and allowing using QuantEcon to call that instead of load at "using-time" made it work.
Can you verify that it fixes your issue?

Okay fixed. So rm -rf ~/.julia/lib  followed by  Base.compilecache(:Distributions) did the trick.  Base.compilecache(:QuantEcon) was not necessary. It's slightly concerning that this is necessary, I bet it's Distributions.jl's falt.

Not sure... Just sounds like life on the bleeding edge to me

This is https://github.com/JuliaLang/julia/issues/12586

slash 9079 slash 4600... we need to fix that


Remove MSC2716 tests to incrementally import history into existing rooms

Remove MSC2716 tests to incrementally import history into existing rooms
Context for why we're removing the implementation:

https://github.com/matrix-org/matrix-spec-proposals/pull/2716#issuecomment-1487441010
https://github.com/matrix-org/matrix-spec-proposals/pull/2716#issuecomment-1504262734

Removed from Synapse in https://github.com/matrix-org/synapse/pull/15748
Pull Request Checklist

[ ] Pull request includes a sign off

Thanks @reivilibre 🐈⬛


How to map the individual JSON fields to topic fields?

I may be missing something in the documentation, and if so, my apologies, but when I get the data, and put it into the topic, has all of the JSON in a VALUE field. I would like to map the individual JSON fields to their own topic message fields. Is that possible with this connector?

Hi @ryandanielspmc,
It is possible, however, that entails either knowing before-hand or inferring the schema from your JSON document and what's more challenging, that would require dealing with schema changes. Offering a general-purpose solution for that is not straightforward, and that's the reason it's currently not implemented as part of the connector.
But as I said, it's possible to implement your own and still benefit from the rest of the features of this connector by implementing KvSourceRecordMapper
@FunctionalInterface
public interface KvSourceRecordMapper extends Configurable {

    SourceRecord map(KvRecord record, Partition partition);

    default void configure(Map<String, ?> map) {
        // Do nothing
    }
}

You'd just pack your own implementation with the connector and define its usage through the configuration property http.response.record.mapper.
I hope this helps.
Best regards.

I will give that a shot. Thank you.

I see that the example interface above is from 0.8.0-SNAPSHOT. Is that going to be released soon?

Hi @ryandanielspmc
That example is common for both the last released version and 0.8.0-SNAPSHOT.
In any case, the latter has been reverted due to an issue we found, so the last release v0.7.6 is pretty much same as master.
Best regards.

maybe this Connect SMT is the answer for this problem: https://github.com/RedHatInsights/expandjsonsmt
seen today from this tweet: https://twitter.com/gunnarmorling/status/1346761627543154688

maybe this Connect SMT is the answer for this problem: https://github.com/RedHatInsights/expandjsonsmt
seen today from this tweet: https://twitter.com/gunnarmorling/status/1346761627543154688

Thanks @atomotic for sharing this, I just added a reference in the README.md file.

Thanks @atomotic for sharing this, I just added a reference in the README.md file.


image not identifies

Bug report: Images not recognized in OpenCV project
Description
I encountered a bug when trying to run the OpenCV project on my machine. The project does not recognize the images in the input folder and throws an error.
Steps to reproduce

Clone the repository from https://github.com/GaganHonor/Face-Identification-System-
Install the dependencies with pip install -r requirements.txt
Run the main script with python main.py --input input/ --output output/
Observe the error message: cv2.error: OpenCV(4.5.4) /tmp/pip-req-build-99ib2vsi/opencv/modules/imgproc/src/resize.cpp:4051: error: (-215:Assertion failed) !ssize.empty() in function 'resize'

Expected behavior
The project should process the images in the input folder and save the results in the output folder.
Actual behavior
The project fails to recognize the images in the input folder and throws an error.
Environment

Operating system: Ubuntu 20.04
Python version: 3.8.10
OpenCV version: 4.5.4

Additional information
I tried different image formats (jpg, png, bmp) and sizes, but none of them worked. I also checked the permissions of the input folder and the images, and they are readable by the script.

Hello Thanks a lot for your review , The issue is you have to add your own images as directory inside the training images directory
of the repo , hope this help and follow all read me instructions 😊

Thanks a lot bro ❤ thanks for being quick


Check the return status of _flush_memtable_async()

This commit also contains some adjustments of the forward declaration

Please keep the name original except there is a strong reason.

All name changes have been removed.


Workspaces migration [WIP]

Migrating to Rust workspaces to allow for more crates.

Also includes the first working REPL version

Also includes the first working REPL version