iPhone 14 Pro - Cannot close full screen attachment modal

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Go to any chat
Upload an image
Tap on it to view in full screen

Expected Result:
Able to close the modal
Actual Result:
Tapping X does nothing
Workaround:
unknown
Platform:

Where is this issue occurring?

iOS - iPhone 14 Pro

Version Number: 1.2.29-2
Reproducible in staging?: Need reproduction
Reproducible in production?: Need reproduction
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @roryabraham
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668707540056339
View all open jobs on GitHub

I'm not able to reproduce this on staging:
https://user-images.githubusercontent.com/26260477/202768494-d537d2f7-66f0-4a95-b990-0be5e6e9e828.MP4

I cannot reproduce on staging in an iPhone 13 pro iOS 16.1
https://user-images.githubusercontent.com/6643649/202785014-9d22a5a3-b8d5-4fe7-8531-c9e3c0ef9699.MP4

Since this can't be reproduced I am going to close this out.

I'm no longer able to reproduce this either 👍🏼


Integration of Mauro and Terminology Server (reconcile model disparities)

For 3
24/09/2020 - An update SoW at a higher level of work package to include the future deliveries included is submitted to FCAP which will allow the steering committee to approve extended work package definition (and work) without going through FCAP approvals for future changes via CCNs. Awaiting FCAP approval.

A Demo for wider Data Architect team

11/01/21 - 2 workshops held and design and mapping agreed..

11/01/21 - 2 workshops held and design and mapping agreed..

First workshop on 29 April to determine approach;
Follow-up on 13 May

13/56 - this is a duplicate of #197


Kwxm/conformance/hash functions

PLT-6308 and 6340.  This adds conformance tests for the new hash functions.  I've taken the inputs either from appropriate standards or from reference implementations (documented in the tests).  While I was at it I took the opportunity to update the tests for the existing hash functions with data from similar sources.  There are now multiple unit tests for the same bultins in untyped-plutus-core, but I thought that more tests wouldn't do any harm.

@michaelpj I was going to ask someone else to review it, but I suppose you'll do it anyway!


Uploading base64 with chunkSize

I need to upload the files encoded in base64 and in chunks, it's possible with the plugin?
I have all my develpment for a project using the pluing and everything works fine. Now at production we are having some trouble with the infrastructure and I have to change the file uploads to base64 encoded but without losing the chunks.
From where I see maybe I can use Upload.http({}) to upoad the file, but I don't know if it's compatible with the attribute : resumeChunkSize. Is it possible?
Anyone knows how to do this?

Well, Actually I cannot use Upload.jhttp as it uses a file, not the data of the file:
My code:
`Upload.dataUrl(objFile.file, true).then(function(url){
objFile.fields['file'] = url;
              Upload.http({
                url: vm.urlUpload,
                headers : {
                  'authmanteniment' : response.app.auth,
                  'x-api-version' : MntConstant.SERVER_MANTENIMENT_VERSION
                },
                resumeSizeUrl   : vm.urlResumeSize+'?newFileId='+objFile.fields.newFileId+'&name='+objFile.file.name,
                resumeChunkSize : vm.chunkSize,
                data: objFile.fields
              })

});`


fix(emoji-text-wrapper): DLT-1699 emoji alignment

Emoji text wrapper - Fix emoji alignment
Obligatory GIF (super important!)

:hammer_and_wrench: Type Of Change
These types will increment the version number on release:

[x] Fix

:book: Jira Ticket
https://dialpad.atlassian.net/browse/DLT-1699
:book: Description

Changed the output of emoji text-wrapper, text-only nodes are retained as-is and added a wrapper container to be able to vertically center and truncate text
Fixed an issue that prevented the emoji size to change on storybook.

:bulb: Context
Emoji on leftbar row was not aligned correctly but it was using emoji-text-wrapper so fixed directly on the source.
:pencil: Checklist
For all PRs:

[x] I have ensured no private Dialpad links or info are in the code or pull request description (Dialtone is a public repo!).
[x] I have reviewed my changes.
[ ] I have added all relevant documentation.
[x] I have considered the performance impact of my change.

For all Vue changes:

[ ] I have added / updated unit tests.
[x] I have made my changes in Vue 2 and Vue 3. Note: you may sync your changes from Vue 2 to Vue 3 (or vice versa) using the ./scripts/dialtone-vue-sync.sh script. Read docs here: Dialtone Vue Sync Script
[ ] I have validated components with a screen reader.
[ ] I have validated components keyboard navigation.

For all CSS changes:

[ ] I have used design tokens whenever possible.
[x] I have considered how this change will behave on different screen sizes.
[ ] I have visually validated my change in light and dark mode.
[x] I have used gap or flexbox properties for layout instead of margin whenever possible.

:camera: Screenshots / GIFs

Before

After

Shortcuts to affected components
https://dialtone.dialpad.com/vue/deploy-previews/pr-407/?path=/story/components-emoji-text-wrapper--default
https://dialtone.dialpad.com/vue/deploy-previews/pr-407/?path=/story/components-emoji-text-wrapper--variants
https://dialtone.dialpad.com/vue/deploy-previews/pr-407/?path=/story/recipes-conversation-view-emoji-row--default
https://dialtone.dialpad.com/vue/deploy-previews/pr-407/?path=/story/recipes-conversation-view-feed-item-row--default
https://dialtone.dialpad.com/vue/deploy-previews/pr-407/?path=/story/recipes-leftbar-contact-row--variants
https://dialtone.dialpad.com/vue/deploy-previews/pr-407/?path=/story/recipes-leftbar-general-row--variants

This is finally ready for review, visual changes are expected as I changed the vertical alignment of the text and the emojis so they are completely centered.
@francisrupert @fede-dp

Supposed to be this tight to the edge?

here is what it looked like prior:

Supposed to be this tight to the edge?

here is what it looked like prior:

Just fixed, it needed the display: inline-flex on emoji-text-wrapper 😄 should be updated now.

I would like to confirm with @francisrupert that this is the result that we're expecting before merging.

Short answer for now: there's a better way to ensure the baseline doesn't shift while guaranteeing the Emoji is consistently placed next to text regardless of emoji size. Additionally, I really don't like how Emoji grows the line-height.
I'll play with something. I've done this before, just gotta make it work for the next tag soup Emoji Wrapper introduces.


Include NameIdentifier claim in Azure function negotiate method using TypeScript

How do we include NameIdentifier claim in Azure function negotiate method using TypeScript?
I am calling negotiate API from an Angular app that has an authenticated user.  When I generate an access token my negotiate method, I am not sure how to add in nameIdentifier.
I will be using REST API to send message to single clients.

@jrmcdona are you using Azure SignalR function extension binding?
We provide an attribute UserId in SignalRConnectionInfo for negotiate use. See https://github.com/Azure/azure-functions-signalrservice-extension/blob/dev/src/SignalRServiceExtension/SignalRConnectionInfoAttribute.cs#L21-#L32.
So you can assign this value in functions.json like below. You may take our js sample for some reference. Let me know if you have any further questions.
{
      "type": "signalRConnectionInfo",
      "name": "connectionInfo",
      "userId": "{headers.x-ms-signalr-userid}",
      "hubName": "simplechat",
      "direction": "in"
}

@JialinXin So in order to populate "userId": "{headers.x-ms-signalr-userid}" with a value we need to add App service authentication to our Azure function?
In your sample,  I do not see where the userId value gets set.    Thanks for your help!

@jrmcdona  Yeah. You did it in the right way. You can name x-ms-signalr-userid as you like, just to make sure to pass it in function binding signalRConnectionInfo UserId during negotiate. Then it will generate AccessToken based on it and build connection with Azure SignalR Service. And later when client send message to user/groups via RestApi, the same AccessToken will be used.
We put the set part in our client code here.

@JialinXin  cool, I was able to get it working!

@JialinXin one additional thing.  Do you feel this is secure enough?  Or do we need another level of security in the Function apps?
I don't want anybody to grab endpoints from the client side and generate all of the necessary tokens to be able to hit the Azure SignalR service.
Thanks

From what I can tell, this is not secure.
Even without thinking about SignalR, how does your function app authenticate it’s users (how does it know the user is who they say they are)?

@anthonychu I agree.   This is for a 1st party Microsoft app and I think the Authentication providers are not made for 1st party apps.   I would say certainly Microsoft Account is not.      I think it may be easier once we get Azure AD converged endpoints rolled out for 1st party but they are not.
Let me know if you know anything more about this topic.
I will see if I can get some auth going in the function.  In a traditional web API asp.net project or core project you set everyhing up in startup.cs such as the RPS bits needed for Microsoft accounts.

@anthonychu @JialinXin  So I am looking more into this for AAD.    Since this is an API call we do not want to use App service authentication.  Instead we would be using Bearer token authentication, something like this.   Unless I am missing somthing?  Something like this:  https://blog.wille-zone.de/post/secure-azure-functions-with-jwt-token/
However,  what I do not know is in this case how to get the NameIdentifier passed on to the SignalR service from the Negotiate method?

Because SignalRConnectionInfo is an input binding, what you are hoping to do is a bit awkward but possible.

Pass in the user id via header like described above and set the userId prop on the input binding
In the function validate if the caller really is userId:

Yes: return the connection info from the binding
No: do not return the connection info (return 403 error instead)

If you'd like to chat about it, I'm currently on vacation but feel free to set up a meeting with me later on this week. We can talk through it and update this issue with the outcome.

Right now the userId in function.json isn't really useful, as in a real scenario you shouldn't trust whoever the client claim he is. In a real world scenario your negotiate should be protected by some authentication mechanism by yourself and in the negotiate you should get the identity from the authenticated user and put it to the SignalR access token. Take the JWT token way you mentioned as an example, you should first validate the JWT token of the negotiate function, get the userId from the claims, then put it to the negotiate result. The problem is it's not easy to finish it in a simple expression in function.json. For now please refer to this example for how to do it in javascript:
https://github.com/aspnet/AzureSignalR-samples/issues/42

@chenkennt @anthonychu
Hello,  I am trying this with C# and I am unable to Negotiate with SignalR.
In my function I am manually validating the AAD Bearer token sent in the headers.
This also give me the ClaimsPrincipal if the user is authorized and allows me to get the Name Identifier.
Once that is done, I am trying to GenerateAccessToken based on:
https://github.com/aspnet/AzureSignalR-samples/pull/39/files#diff-577b0ba7bbffc0f105ca22d9947f3191R33
Can you all see anything I am doing wrong here?
                ClaimsPrincipal principal = await Security.ValidateTokenAsync(authHeader.ToString(), req.HttpContext);

                if (principal == null || (principal.Identity == null || !principal.Identity.IsAuthenticated))
                {
                    return new UnauthorizedResult();
                }

                log.LogInformation(principal.Identity.Name);

                ServiceUtils _serviceUtils = new ServiceUtils(System.Environment.GetEnvironmentVariable("AzureSignalRConnectionString"));
                var sigRConnToken = _serviceUtils.GenerateAccessToken(System.Environment.GetEnvironmentVariable("AADAudience"), principal.Identity.Name);
                connectionInfo.AccessToken = sigRConnToken;

                return new OkObjectResult(connectionInfo);

I needed to use the URL of the Hub and not the Endpoint.
               var sigRConnToken = _serviceUtils.GenerateAccessToken(connectionInfo.Url, principal.Identity.Name);
So my audience was wrong on the token.

@jrmcdona If you’re using C#, you can also use the binding to generate the token with a user ID like this: https://gist.github.com/ErikAndreas/72c94a0c8a9e6e632f44522c41be8ee7
It might be better than doing this yourself in case anything changes in the future.


Update machine-learning-recommendation-api-quick-start-guide.md

Add Fbt as a valid field type.

Hi @LuisCabrer, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (luisca). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


TDI-38336:A NPE is thrown when a main connector following the

tAzureStorageOutputTable
https://jira.talendforge.org/browse/TDI-38336
Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:


Error with PrepText function using example sotu data

I’m getting an “Check_input” error when I try to run PrepText using the sotu example, even though the text is type character. I tried creating my own tf-idf data frame using tidy text so I could still use the visualization functions in this package but I wasn’t sure what the outputs of PrepText and CreateTextnet look like to troubleshoot. Thanks for your help!

Hi,
I also have the same problem, here what I got when try to run this code
sotu_firsts_nouns <- PrepText(textdata = sotu_firsts, groupvar = "president", textvar = "sotu_text", node_type = "groups", tokenizer = "words", pos = "nouns", remove_stop_words = TRUE, compound_nouns = TRUE)
Downloading udpipe model from https://raw.githubusercontent.com/jwijffels/udpipe.models.ud.2.4/master/inst/udpipe-ud-2.4-190531/english-ewt-ud-2.4-190531.udpipe to /Users/vuongdat/OneDrive - Aarhus universitet/Applied Data Science/Share Data Folder/2. Raw Data/Reddit Data/english-ewt-ud-2.4-190531.udpipe
Visit https://github.com/jwijffels/udpipe.models.ud.2.4 for model license details
trying URL 'https://raw.githubusercontent.com/jwijffels/udpipe.models.ud.2.4/master/inst/udpipe-ud-2.4-190531/english-ewt-ud-2.4-190531.udpipe'
Content type 'application/octet-stream' length 16477964 bytes (15.7 MB)
==================================================
downloaded 15.7 MB

Error in check_input(x) :
  Input must be a character vector of any length or a list of character
  vectors, each of which has a length of 1.
In addition: Warning message:
'unnest_tokens_' is deprecated.
Use 'unnest_tokens' instead.
See help("Deprecated")

Here is my section Information.
─ Session info ──────────────────────────────────────────────────────────────────────────────────────────────────────────
 setting  value
 version  R version 3.6.1 (2019-07-05)
 os       macOS Catalina 10.15.3
 system   x86_64, darwin15.6.0
 ui       RStudio
 language (EN)
 collate  en_US.UTF-8
 ctype    en_US.UTF-8
 tz       Europe/Copenhagen
 date     2020-05-03

─ Packages ──────────────────────────────────────────────────────────────────────────────────────────────────────────────
 package      * version  date       lib source
 assertthat     0.2.1    2019-03-21 [1] CRAN (R 3.6.0)
 backports      1.1.6    2020-04-05 [1] CRAN (R 3.6.2)
 callr          3.4.3    2020-03-28 [1] CRAN (R 3.6.2)
 cli            2.0.2    2020-02-28 [1] CRAN (R 3.6.0)
 colorspace     1.4-1    2019-03-18 [1] CRAN (R 3.6.0)
 crayon         1.3.4    2017-09-16 [1] CRAN (R 3.6.0)
 curl           4.3      2019-12-02 [1] CRAN (R 3.6.0)
 data.table     1.12.8   2019-12-09 [1] CRAN (R 3.6.0)
 desc           1.2.0    2018-05-01 [1] CRAN (R 3.6.0)
 devtools     * 2.2.1    2019-09-24 [1] CRAN (R 3.6.0)
 digest         0.6.25   2020-02-23 [1] CRAN (R 3.6.0)
 dplyr        * 0.8.5    2020-03-07 [1] CRAN (R 3.6.0)
 ellipsis       0.3.0    2019-09-20 [1] CRAN (R 3.6.0)
 fansi          0.4.1    2020-01-08 [1] CRAN (R 3.6.0)
 farver         2.0.3    2020-01-16 [1] CRAN (R 3.6.0)
 fs             1.4.1    2020-04-04 [1] CRAN (R 3.6.2)
 generics       0.0.2    2018-11-29 [1] CRAN (R 3.6.0)
 ggforce        0.3.1    2019-08-20 [1] CRAN (R 3.6.0)
 ggplot2      * 3.3.0    2020-03-05 [1] CRAN (R 3.6.0)
 ggraph       * 2.0.2    2020-03-17 [1] CRAN (R 3.6.0)
 ggrepel        0.8.2    2020-03-08 [1] CRAN (R 3.6.0)
 glue           1.4.0    2020-04-03 [1] CRAN (R 3.6.2)
 graphlayouts   0.7.0    2020-04-25 [1] CRAN (R 3.6.2)
 gridExtra      2.3      2017-09-09 [1] CRAN (R 3.6.0)
 gtable         0.3.0    2019-03-25 [1] CRAN (R 3.6.0)
 htmltools      0.4.0    2019-10-04 [1] CRAN (R 3.6.0)
 htmlwidgets    1.5.1    2019-10-08 [1] CRAN (R 3.6.1)
 igraph         1.2.5    2020-03-19 [1] CRAN (R 3.6.0)
 janeaustenr    0.1.5    2017-06-10 [1] CRAN (R 3.6.0)
 lattice        0.20-38  2018-11-04 [1] CRAN (R 3.6.1)
 lifecycle      0.2.0    2020-03-06 [1] CRAN (R 3.6.0)
 magrittr       1.5      2014-11-22 [1] CRAN (R 3.6.0)
 MASS           7.3-51.4 2019-03-31 [1] CRAN (R 3.6.1)
 Matrix         1.2-17   2019-03-22 [1] CRAN (R 3.6.1)
 memoise        1.1.0    2017-04-21 [1] CRAN (R 3.6.0)
 munsell        0.5.0    2018-06-12 [1] CRAN (R 3.6.0)
 networkD3    * 0.4      2017-03-18 [1] CRAN (R 3.6.0)
 pillar         1.4.3    2019-12-20 [1] CRAN (R 3.6.1)
 pkgbuild       1.0.7    2020-04-25 [1] CRAN (R 3.6.2)
 pkgconfig      2.0.3    2019-09-22 [1] CRAN (R 3.6.1)
 pkgload        1.0.2    2018-10-29 [1] CRAN (R 3.6.0)
 plyr           1.8.6    2020-03-03 [1] CRAN (R 3.6.0)
 polyclip       1.10-0   2019-03-14 [1] CRAN (R 3.6.0)
 prettyunits    1.1.1    2020-01-24 [1] CRAN (R 3.6.1)
 processx       3.4.2    2020-02-09 [1] CRAN (R 3.6.0)
 ps             1.3.2    2020-02-13 [1] CRAN (R 3.6.0)
 purrr          0.3.4    2020-04-17 [1] CRAN (R 3.6.2)
 R6             2.4.1    2019-11-12 [1] CRAN (R 3.6.1)
 Rcpp           1.0.4    2020-03-17 [1] CRAN (R 3.6.0)
 remotes        2.1.0    2019-06-24 [1] CRAN (R 3.6.0)
 reshape2       1.4.4    2020-04-09 [1] CRAN (R 3.6.2)
 rlang          0.4.5    2020-03-01 [1] CRAN (R 3.6.0)
 rprojroot      1.3-2    2018-01-03 [1] CRAN (R 3.6.0)
 rstudioapi     0.11     2020-02-07 [1] CRAN (R 3.6.0)
 rversions      2.0.1    2019-12-03 [1] CRAN (R 3.6.1)
 scales         1.1.0    2019-11-18 [1] CRAN (R 3.6.1)
 sessioninfo    1.1.1    2018-11-05 [1] CRAN (R 3.6.0)
 SnowballC      0.7.0    2020-04-01 [1] CRAN (R 3.6.2)
 stringi        1.4.6    2020-02-17 [1] CRAN (R 3.6.0)
 stringr        1.4.0    2019-02-10 [1] CRAN (R 3.6.0)
 testthat       2.3.2    2020-03-02 [1] CRAN (R 3.6.0)
 textnets     * 0.1.1    2020-05-03 [1] Github (cbail/textnets@bc688a8)
 tibble         3.0.1    2020-04-20 [1] CRAN (R 3.6.2)
 tidygraph      1.1.2    2019-02-18 [1] CRAN (R 3.6.0)
 tidyr          1.0.2    2020-01-24 [1] CRAN (R 3.6.0)
 tidyselect     1.0.0    2020-01-27 [1] CRAN (R 3.6.0)
 tidytext     * 0.2.4    2020-04-17 [1] CRAN (R 3.6.2)
 tokenizers     0.2.1    2018-03-29 [1] CRAN (R 3.6.0)
 tweenr         1.0.1    2018-12-14 [1] CRAN (R 3.6.0)
 udpipe       * 0.8.3    2019-07-05 [1] CRAN (R 3.6.0)
 usethis      * 1.6.1    2020-04-29 [1] CRAN (R 3.6.2)
 vctrs          0.2.4    2020-03-10 [1] CRAN (R 3.6.0)
 viridis        0.5.1    2018-03-29 [1] CRAN (R 3.6.0)
 viridisLite    0.3.0    2018-02-01 [1] CRAN (R 3.6.0)
 withr          2.2.0    2020-04-20 [1] CRAN (R 3.6.2)
 xml2           1.2.2    2019-08-09 [1] CRAN (R 3.6.0)

same, even though the data are characters or character lists, doesn't matter which dataset, the same error persists.

it seems like it's an issue with unnest_tokens within the function, there are some help pages but it's not clear how to resolve it. Still looking into it ...

@Dat-Vuong07  @angelhsu05
Did you use dataset from the package?
If you use your own textual data, firstly, please try to load own dataset with the package using read_csv from tidyverse instead of read.csv from base. read_csv function automatically identifies the datatype by itself.
However, you might need to double check the textvar of datatype is character or not.
If that is not a problem, please set compound_nouns off like this compound_nouns = FALSE.
I guess you probably use a language other than English. The package parse the text using
udpipe library. The package of udpipe parses  text based on pre-trained language model in CONLL-U format and returns dep_rel column that stores various features of language dependency.  And there is no compound feature from the data.

Yes, I was using the 'sotu' dataset from the package and so am not reading the data in from csv, but instead loading directly from the package. Changing compound_nouns=FALSE doesn't work either.
I can use the tidytext and udpipe libraries instead of the PrepText function to get the tidytextobject to use the other functions, but it would be great to be able to get PrepText working as i'm new to network analysis.
I am also getting a message that unnest_tokens_ is deprecated and to use unnest_tokens instead, so i updated PrepText with that but I'm still getting the same error about the data not being a character vector or list of character vectors, which is clearly is in the sotu dataset.

Have you checked datatype of the sotu  being loaded ? Particularly, the textvar that you are going to use.

Hi @yl17124 ,
I also have the same problem.
Here is my code. I already changed the compound_nouns = FALSE
library(textnets)
data("sotu")

str(sotu)

sotu_firsts <- sotu %>% group_by(president) %>% slice(1L)

sotu_firsts_nouns <- PrepText(sotu_firsts, groupvar = "president",
                              textvar = "sotu_text",
                              node_type = "groups",
                              tokenizer = "words",
                              pos = "nouns",
                              remove_stop_words = TRUE, compound_nouns = FALSE)

And this is the results
1. The soot input look fine with variable sotu_text as character
> str(sotu)
'data.frame':	236 obs. of  6 variables:
 $ sotu_text   : chr  "Fellow-Citizens of the Senate and House of Representatives: \n\nI embrace with great satisfaction the opportuni"| __truncated__ "\n\n Fellow-Citizens of the Senate and House of Representatives: \n\nIn meeting you again I feel much satisfact"| __truncated__ "\n\n Fellow-Citizens of the Senate and House of Representatives: \n\n \"In vain may we expect peace with the In"| __truncated__ "Fellow-Citizens of the Senate and House of Representatives: \n\nIt is some abatement of the satisfaction with w"| __truncated__ ...
 $ president   : chr  "George Washington" "George Washington" "George Washington" "George Washington" ...
 $ year        : int  1790 1790 1791 1792 1793 1794 1795 1796 1797 1798 ...
 $ years_active: chr  "1789-1793" "1789-1793" "1789-1793" "1789-1793" ...
 $ party       : chr  "Nonpartisan" "Nonpartisan" "Nonpartisan" "Nonpartisan" ...
 $ sotu_type   : chr  "speech" "speech" "speech" "speech" ...

2. However, it can't run the PrepText function
Downloading udpipe model from https://raw.githubusercontent.com/jwijffels/udpipe.models.ud.2.4/master/inst/udpipe-ud-2.4-190531/english-ewt-ud-2.4-190531.udpipe to /Users/vuongdat/OneDrive - Aarhus universitet/Applied Data Science/Share Data Folder/2. Raw Data/Reddit Data/english-ewt-ud-2.4-190531.udpipe
Visit https://github.com/jwijffels/udpipe.models.ud.2.4 for model license details
trying URL 'https://raw.githubusercontent.com/jwijffels/udpipe.models.ud.2.4/master/inst/udpipe-ud-2.4-190531/english-ewt-ud-2.4-190531.udpipe'
Content type 'application/octet-stream' length 16477964 bytes (15.7 MB)
==================================================
downloaded 15.7 MB

Error in check_input(x) :
  Input must be a character vector of any length or a list of character
  vectors, each of which has a length of 1.
In addition: Warning message:
'unnest_tokens_' is deprecated.
Use 'unnest_tokens' instead.
See help("Deprecated")

Below is my session Information
R version 3.6.1 (2019-07-05)
Platform: x86_64-apple-darwin15.6.0 (64-bit)
Running under: macOS Catalina 10.15.3

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base

other attached packages:
[1] textnets_0.1.1 networkD3_0.4  ggraph_2.0.2   ggplot2_3.3.0  udpipe_0.8.3   dplyr_0.8.5

loaded via a namespace (and not attached):
 [1] Rcpp_1.0.4         plyr_1.8.6         pillar_1.4.3       compiler_3.6.1     tokenizers_0.2.1   viridis_0.5.1
 [7] tools_3.6.1        digest_0.6.25      viridisLite_0.3.0  lifecycle_0.2.0    tibble_3.0.1       gtable_0.3.0
[13] lattice_0.20-38    pkgconfig_2.0.3    rlang_0.4.5        Matrix_1.2-17      tidygraph_1.1.2    igraph_1.2.5
[19] rstudioapi_0.11    ggrepel_0.8.2      gridExtra_2.3      stringr_1.4.0      janeaustenr_0.1.5  withr_2.2.0
[25] generics_0.0.2     htmlwidgets_1.5.1  graphlayouts_0.7.0 vctrs_0.2.4        grid_3.6.1         tidyselect_1.0.0
[31] glue_1.4.0         data.table_1.12.8  R6_2.4.1           polyclip_1.10-0    reshape2_1.4.4     purrr_0.3.4
[37] tidyr_1.0.2        tweenr_1.0.1       farver_2.0.3       magrittr_1.5       SnowballC_0.7.0    htmltools_0.4.0
[43] scales_1.1.0       ellipsis_0.3.0     MASS_7.3-51.4      tidytext_0.2.4     assertthat_0.2.1   ggforce_0.3.1
[49] colorspace_1.4-1   stringi_1.4.6      munsell_0.5.0      crayon_1.3.4

yes, the textvar for the sotu example is type character.

You need to change the "sotu" variable name to "textvar" to make it work.
I had the same issue and it wasn't until I saw under the hood of the PrepText function how the input was evaluated in the unnest_tokens_ function (which is deprecated, BTW).

Hi folks- thanks for pitching in to answer this question, I'm sorry I was not available I am busy planning for a major educational event this summer (the Summer Institutes in Computational Social Science: https://compsocialscience.github.io/summer-institute/). Ok to close this now @angelhsu05 ? Or is it still not working.

yes that was the trick, thanks @sotork! Perhaps worth updating the example code snippet below:
names(sotu_first_speeches)[1] <- "textvar"
prepped_sotu <- PrepText(sotu_first_speeches, groupvar = "president", textvar = "textvar", node_type = "groups", tokenizer = "words", pos = "nouns", remove_stop_words = TRUE, compound_nouns = TRUE)

@angelhsu05
perhaps try not to void name text in order not to

Hi all- I'm unable to reproduce this error. I want to make sure I am following the solution correctly-- did you wind up changing textvar="textvar" in order to make it work? Does that mean you renamed the variable in the sotu dataset?

Yes Chris...I renamed it. It was "sotu_text", it needs to be "textvar" to make the function work.

I was having the exact same issue as everyone else on this thread. Renaming sotu_text to textvar solved it for some mysterious reason, as others have discovered. It sounds like the underlying code needs to be updated to use 'unnest_tokens' (new) instead of 'unnest_tokens_' (deprecated).
This fails:
library(textnets)
data("sotu")
sotu_first_speeches <- sotu %>%
  group_by(president) %>%
  slice(1L)
prepped_sotu <- PrepText(sotu_first_speeches,
                         groupvar = "president",
                         textvar = "textvar",
                         node_type = "groups",
                         tokenizer = "words",
                         pos = "nouns",
                         remove_stop_words = TRUE,
                         compound_nouns = TRUE)

This functions:
library(textnets)
data("sotu")
sotu_first_speeches <- sotu %>%
  group_by(president) %>%
  slice(1L) %>%
  ungroup() **%>%
  rename(textvar = sotu_text)**
prepped_sotu <- PrepText(sotu_first_speeches,
                         groupvar = "president",
                         textvar = "textvar",
                         node_type = "groups",
                         tokenizer = "words",
                         pos = "nouns",
                         remove_stop_words = TRUE,
                         compound_nouns = TRUE)

Hi all: I just pushed a fix for this (it turned out to be an issue with variable indirection created by R 4.0). Could one or more of you please try a fresh install (and try rerunning the example code) to verify that you no longer need to change the textvar column name as @kelseygonzalez did above? Thank you!

It runs without the textvar column name now!
but I can't get the network visualization to run. I'm unsure if this is the same root cause or if its unrelated.
load(url("https://cbail.github.io/Trump_Tweets.Rdata")) trumptweets <- trumptweets %>%    mutate(date = as.Date(created_at),          month = lubridate::month(date))  prepped_sotu <- PrepText(trumptweets,                           groupvar = "month",                           textvar = "text",                           node_type = "words",                           tokenizer = "words",                           pos = "nouns",                           remove_stop_words = TRUE,                          compound_nouns = TRUE) sotu_text_network <- CreateTextnet(prepped_sotu) VisTextNet(sotu_text_network, label_degree_cut = 0)
error:
Using sparse_stress with 250 pivots as default layout Error in if (!is.na(weights)) { : argument is of length zero
if i do
VisTextNet(sotu_text_network, alpha = 0.1, label_degree_cut = 0)
I get
Using sparse_stress with 250 pivots as default layout Error in layout_with_sparse_stress(graph, pivots = pivots, weights = weights,  :    only connected graphs are supported.


Idea of a plugin relying on Hibernate's hbm2ddl tool in order to generate the migration schemas...

I would like to suggest and contribute a maven plugin both related to

Hibernate's hbm2ddl tool
Flyway
The idea would be to have this third-party plugin (let's call it: _Hibernate4Flyway_ for now) rely on Hibernate's hbm2ddl tool in order to generate a set of incremental schema files following Flyway's naming requirements i.e.

A version must have the following structure:
One or more numeric parts
Separated by a dot (.) or an underscore (_)
Underscores are replaced by dots at runtime
Leading zeroes are ignored in each part

Those files would generated by Hibernate's hbm2ddl upon SessionFactory/EntityManagerFactory startup and kept (and optionally edited) so that they could later be applied to the production database during the migrations.
The gap this plugin would fill is best described as follows: as of now, developers can really rely on hbm2ddl only until the first data migration. Once the first database is released in production, developers can still use hbm2ddl but they then have to manually compute the diff between version 1 of database (the one in production) and version 2 (intended for the next release). They then have to manually create the migration script to be later applied by Flyway.
Please comment with questions, suggestions or guidelines so that I know whether my idea is feasible and if that is the case how we can carry on.

Closing this old issue. Besides the fact that I am generally unsure about this, it is too Hibernate-specific.


RedTube DL don't work any more

Checklist

[X] I'm reporting a broken site
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS>. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
No response
Description
only downloaded a small file (893 btyes) which is obviously not the real video file...
sample url:
https://www.redtube.com/39016781
Verbose log
Download Log for url: https://www.redtube.com/39016781

Waiting
[RedTube] 39016781: Downloading webpage
[RedTube] 39016781: Downloading m3u8 information
[info] 39016781: Downloading 1 format(s): 1
[download] Destination: C:\Users\Sony\xxx\Youtube-Dl\Cute Asian is fucked & creampied!-39016781.mp4
[download] 893.00B at 436.07KiB/s (00:02)
[download] 100% of 893.00B in 00:02
Download Worker Finished.

Not fixed by today's revision.


Rename compose and decompose

@brucou pointed out that signal processing alternatives to compose and decompose are multiplex and demultiplex.
This sounds good. At least we can create aliases to those and perhaps finally remove the original names completely.
How about shortening the names to mux and demux?

Renamed to mux and demux in 1.0.0 release


Small CI input reorganization

Change input folder from ci to toil_vg_ci.  Doesn't do much, just way to:

test permissions of new folders work as expected
take opportunity to get rid of lots of files no longer used for toil-vg ci (about 8 gigs of them)
pave way for vg_ci folder, which will be added for the vg jenkins script

@cmarkello Can you please move/remove s3://cgl-pipeline-inputs/vg_cgl/ci/ ? I've copied all files necessary for toil-vg's CI to sister directories.  Most of the stuff in there now has nothing to do with CI...


Add quick try Colab Notebook

I provide a colab notebook which can quick try chinese llama in gradio demo.
Here is the url of the colab notebook: https://colab.research.google.com/drive/1mG8CwGub-hcoeo79FjfoWtxqOuu3P_y1?usp=sharing

Would you mind if I copy and put your Colab notebook into the repo, so that the repo is self-contained?

Would you mind if I copy and put your Colab notebook into the repo, so that the repo is self-contained?

Sure, you are welcome to copy and include the Colab notebook in your repository to make it self-contained.

There are html tags around the text:

Is there a way to remove them?
@sunyuhan19981208

After I click the submit, html tags are added to the texts (The input is "你好"):
Is there a way to remove them? @sunyuhan19981208

I think there is, I will try to fix that.

After I click the submit, html tags are added to the texts (The input is "你好"):
Is there a way to remove them? @sunyuhan19981208

I can't reproduce it...

@sunyuhan19981208  My colleague and I can both reproduce the problem with the notebook link you gave https://colab.research.google.com/drive/1mG8CwGub-hcoeo79FjfoWtxqOuu3P_y1?usp=sharing.
We have tested Safari + MacOS, Chrome + MacOS, Chrome + Win11, Edge + Win11. What is your environment?

@sunyuhan19981208 My colleague and I can both reproduce the problem with the notebook link you gave https://colab.research.google.com/drive/1mG8CwGub-hcoeo79FjfoWtxqOuu3P_y1?usp=sharing.
We have tested Safari + MacOS, Chrome + MacOS, Chrome + Win11, Edge + Win11. What is your environment?

I have successfully reproduced it using a Colab notebook, but I encountered difficulties when trying to reproduce it on my local server. It's quite weird, but I assure you that I am committed to finding a solution. I apologize for any inconvenience caused, and I will put in extra effort to resolve this issue. Thank you for your understanding and patience.

@sunyuhan19981208 My colleague and I can both reproduce the problem with the notebook link you gave https://colab.research.google.com/drive/1mG8CwGub-hcoeo79FjfoWtxqOuu3P_y1?usp=sharing.
We have tested Safari + MacOS, Chrome + MacOS, Chrome + Win11, Edge + Win11. What is your environment?

In the new commit 2ae52cb I delete the mdtex2html part, and then the chat message seems good.

It looks good now.

We temporarily merge the PR into gradio_notebook branch, and then merge it into the main branch after reorganizing some code and docs.


Implement Speakeasy for 2FA

How hard would it be to add Speakeasy via npm to enable 2FA on the exchange.
I know @3s3s said he wouldn't add 2FA as email confirmations are suitable for security but if you have access to someones account you can just set a high sell on one account and buy all of one coin with it essentially transferring the coins to your other account and withdraw that way without the need to confirm the hacked account via email.
I have looked into speakeasy and it could be as simple as adding a new column in the users table for the generated security key then editing the login page, profile page, wallet page (for withdraw) to ask for the 2FA code before logging in and withdrawing
before i look into it further and start giving it a try has anyone implemented 2FA or has anyone used speakeasy before?
Here is a link to a tutorial: https://davidwalsh.name/2fa
and a link to speakeasy: https://github.com/speakeasyjs/speakeasy

Im going to offer this up as a bounty if someone can implement it i am willing to pay

Interested as well!

I have spoken with @3s3s over email and he said:
I'm very wary about including third-party code into exchange. Maybe in  the future I'll do something like this as an option. But we must think  carefully how not to harm the safety.
so i have asked if its possible to add something like poloniex with the pin via email like the attached

That would be fine with me, or even some exchanges have you input a 4-5 digit pin number as a 2FA. I belive crypto hub does this.


[iOS] out of memory events do not include the real user id

Describe the bug
iOS out of memory events do not include the real user ID.
Instead, the user id appears to be a guid for the device.
The out of memory events are also missing configuration set immediately after Bugsnag.Init(), the user id is the most important thing for us though.
Steps to reproduce

On iOS, init Bugsnag and set the user id to "bob1"
Trigger an out of memory crash
Reopen the app and initialize bugsnag again (so that OOM event is reported)
See that the event on bugsnag.com has some guid as the user id (should be "bob1")

Environment

Bugsnag version: v4.8.4
Unity version: 2019.4.16f1
iOS/Android/macOS/Windows/browser version: iOS 14.4
simulator/emulator or physical device: physical iPhone 8
Initializing bugsnag via a Unity GameObject or in code?: code
Player Settings:

Scripting backend (Mono or IL2CPP): IL2CPP
API compatibility level for .NET: .NET 4.x
Stack Trace level for all error types (None/ScriptOnly/Full): ScriptOnly

Example code snippet
    // init Bugsnag and trigger an out of memory crash
    public void TriggerOOM() {
		Bugsnag.Init("apikey", true);
        Bugsnag.Client.User.Id = "bob1";

        var list = new List<byte[]>();
        const int twentyMB = 20 * 1024 * 1024;
        while (true) {
            list.Add(new byte[twentyMB]);
        }
    }

This may be related to the already resolved issue [Android] user id not filled in for native crashes if you set user id after bugsnag.init #134

Hi @troy-lamerton, just ran a quick test with this (using https://github.com/bugsnag/bugsnag-unity/releases/tag/v4.8.5, note there are no iOS changes between this and v4.8.4, so would expect the exact same behaviour) and am seeing user information on OOM events on iOS:

The difference is how I'm setting the user data though. Can you please give this a go and let us know how you get on? https://docs.bugsnag.com/platforms/unity/#identifying-users
public class Bugsnag_Xander : MonoBehaviour
{
    void Start()
    {
        Bugsnag.Init("API_KEY", true);
        Bugsnag.SetUser("Xander"<EMAIL_ADDRESS>"Xander Name");
    }
// ...

Closing this as we believe using SetUser should work. Do let us know if that doesn't resolve the issue.

I've been using SetUser for some weeks now.

Initially it worked great, OOM reports had all the correct user info.
Then OOM reports with wrong user id started appearing again, I'm not sure exactly when (some days ago).

For example: https://app.bugsnag.com/the-naughty-cult-ltd/clash-of-streamers-1/errors/5f9aef5809d334001779cc75?filters[event.since][][type]=eq&filters[event.since][][value]=7d&filters[device.model][][type]=eq&filters[device.model][][value]=iPad11%2C6&filters[release.seen_in][][type]=eq&filters[release.seen_in][][value]=22.*&event_id=60bd1d1e007d00973d6f0000
Possible workaround:

don't call SetUser
set User.Name = "my-custom-user-id"
on dashboard, filter by User.Id or User.Name

Hi @troy-lamerton, so that we can investigate further would you be able to write to us at<EMAIL_ADDRESS>with links to example events that do have the correct user info, as well as those that do not, as well as confirmation of exactly how you're setting the user info?

@yousif-bugsnag
Now that version 5 is released, I want to give version 5 a try before exploring this further (maybe it is fixed for us). Let's keep the issue closed for now.


Feature/libbpf-doc-layout

Move BPF CO-RE concept inside the concepts page of libbpf

Hmm, not trying to be difficult. But is CO-RE a libbpf specific concept? It has 3 components that need to work together, the kernel, compiler and loader. Actually, the loader support is technically no longer needed since v5.17 since the kernel added the needed CO-RE logic internally.
cilium/ebpf also implements CO-RE for example, so to me it doesn't feel like a libbpf specific concept. So having it as a linux or generic concept makes sense to me personally.

Oh, didn't know that !
So what I write is wrong in the doc

by bringing together the BTF type information, libbpf and the compiler.


⚠ ClamAV has degraded performance

In 920c2f6, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 189 ms

Resolved: ClamAV performance has improved in 3f75a8c.


[$500]  Log in - User can successfully login when add extra numbers to magic link

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.3.90-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to staging.new.expensify.com
On the log in screen, enter a new account email
Navigate to the email inbox and open the validate email> copy the link> open incognito window > paste the link and click enter
Modify the last portion of the link by adding few more numbers & hit enter
Copy the changed magic code and paste it to the original log in page

Expected Result:
Error page should be displayed
Actual Result:
User can successfully login when add extra numbers to magic link
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] Windows: Chrome
[ ] MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

Windows: Chrome

https://github.com/Expensify/App/assets/78819774/03aea688-52d2-4a14-acae-b403b2bc7164

MacOS: Desktop

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013da74748862d45ef
Upwork Job ID:<PHONE_NUMBER>546896896
Last Price Increase: 2023-10-24

Proposal
Please re-state the problem that we are trying to solve in this issue.
A user can manually modify the code that's embedded in the link sent to the user's email after attempting to login and the modified code will be rendered on the screen, which will most likely be invalid. Example:
https://staging.new.expensify.com/v/ANYTHING/SOMETHING
This link will successfully load and display SOMETHING as the code.
The original issue also states that copying and pasting this code into the screen asking for the code will let the user in, but I find it to be untrue (more on this below).
What is the root cause of that problem?
This screen does not perform any validation on the input parameters as long as the route pattern matches: v/:accountID/:validateCode. If you enter anything in the accountID and validateCode, the screen will render and will use the invalid parameters.
The copy and paste of an invalid code mentioned on the original description of this issue is not really a problem because in the video numbers were added to the END of the correct code. Once you copy and try to paste, the original 6-digit code is still there at the beginning and because there's a limit on the number of characters when you paste the code, you're actually pasting the correct 6-digit. If you attempt to use a true invalid code, you will not be able to login.
What changes do you think we should make in order to solve the problem?

The manipulation of the URL parameters does not pose any security threat to the application. Any user manipulating the url will only be able to get random codes displayed on the screen that will lead them nowhere. Also, under normal operation this should not be an issue for the user are nothing really should be manipulating the url.
With that said, what I propose is that we validate the code against the expected format: 6 numeric digits. If we receive anything other than that then we render ExpiredValidateCodeModal.
This can be done on src/pages/ValidateLoginPage/index.website.js by adding another block that will render ExpiredValidateCodeModal if autoAuthState is CONST.AUTO_AUTH_STATE.NOT_STARTED but validateCode is not valid (format wise only, we can't really validate whether it's indeed a valid one or not). We can extend is to validate the format of the accountID as well if there's a well defined pattern for it.
What alternative solutions did you explore? (Optional)
Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@mallenexpensify personally i think that it's not a bug. User manually modified magic code in url and copy/paste this code in verification screen - system automatically trim first 6 numbers and allow user to login or show correct error.
To be honest i do not see any flow that we should fix here

@narefyev91 instead we can validate if user copied the 6 digits or not, if its more we can just show an error or do nothing can write proposal for this if it makes sense

For which reason we should validate that? Validate code screen already trimming 6 digs and send them to API

Thanks for the feedback @narefyev91 and @saranshbalyan-1234 , and for the proposal @barros001
I agree with @narefyev91 that any data beyond the initial magic code is irrelevant, in the same way that I can keep typing after manually entering the code and I'll still be logged in.  I'm going to close, but I'm also going to share internally in case anyone disagrees


S3 bucket serverSideEncryption with kmsMasterKeyId makes bucket resource not ready

What happened?

Attempted to create S3 bucket with serverSideEncryption settings with kmsMasterKeyId
claim.yaml
apiVersion: storage.ccs.test.com/v1alpha1
kind: S3Bucket
metadata:
  name: claimed-s3-test
  namespace: default
spec:
  parameters:
    bucketName: claimed-s3-test
    region: us-east-2
    version_enabled: Enabled
    serverSideEncryptionConfig:
      kmsMasterKeyId: "XXXXXXXfb-b87c-4sfsf1-8ea5-baXXXXcsdfs0e"
      sseAlgorithm: "aws:kms"
  compositionSelector:
    matchLabels:
      provider: aws

composition.yaml
apiVersion: apiextensions.crossplane.io/v1
kind: Composition
metadata:
  name: composites3buckets.aws.storage.ccs.test.com
  labels:
    guide: s3bucket
    provider: aws
    vpc: default
spec:
  writeConnectionSecretsToNamespace: crossplane-system
  compositeTypeRef:
    apiVersion: storage.ccs.test.com/v1alpha1
    kind: CompositeS3Bucket
  patchSets:
    - name: Metadata
      patches:
      - fromFieldPath: metadata.annotations
  resources:
    - base:
        apiVersion: s3.aws.crossplane.io/v1beta1
        kind: Bucket
        spec:
          forProvider:
            acl: private
            locationConstraint: us-west-2
            objectLockEnabledForBucket: false
            serverSideEncryptionConfiguration:
              rules:
                - applyServerSideEncryptionByDefault:
#                    kmsMasterKeyId: ""  #This key is ONLY applicable ONLY if sseAlgorithm is "aws:kms"
                    sseAlgorithm: AES256
      patches:
        - type: PatchSet
          patchSetName: Metadata
        - fromFieldPath: "spec.parameters.region"
          toFieldPath: "spec.forProvider.locationConstraint"
        - fromFieldPath: "spec.parameters.serverSideEncryptionConfig"
          toFieldPath: "spec.forProvider.serverSideEncryptionConfiguration.rules[0].applyServerSideEncryptionByDefault"

definition.yaml
kind: CompositeResourceDefinition
metadata:
  name: composites3buckets.storage.ccs.test.com
spec:
  group: storage.ccs.test.com
  names:
    kind: CompositeS3Bucket
    plural: composites3buckets
  claimNames:
    kind: S3Bucket
    plural: s3buckets
  versions:
  - name: v1alpha1
    served: true
    referenceable: true
    schema:
      openAPIV3Schema:
        type: object
        properties:
          spec:
            type: object
            properties:
              parameters:
                type: object
                properties:
                  region:
                    type: string
                    description: "Specifies the Region where the bucket will be created. default to 'us-west-2'."
                  serverSideEncryptionConfig:
                    type: object
                    properties:
                      kmsMasterKeyId:
                        type: string
                        description: "(Optional) AWS Key Management Service (KMS) customer master key ID to use for the default encryption.
                        This parameter is allowed if and only if SSEAlgorithm is set to 'aws:kms'. Must be full arn like 'arn:aws:kms:us-east-2:123456789123:alias/aws/s3'
                        or keyId like 'abcdefg6-22x68-4a39-b07a-9b3dxxxx6c908'. Can't use 'alias/aws/s3'. No default set. "
                      sseAlgorithm:
                        type: string
                        description: "AWS Key Management Service (KMS) customer master key ID to use for the default encryption.
                        The ONLY allowed values are 'AES256' and 'aws:kms'. Default is 'aws:kms'"
                        enum: ["aws:kms", "AES256"]

The bucket was created successfully. However, when describing s3Bucket and Bucket, their "READY" status are "false".
How can we reproduce it?

Try to create S3 bucket with above manifests
What environment did it happen in?
Crossplane version:
crossplane/provider-aws-controller:v0.16.0

@yshu2017 can you kubectl describe the s3bucket and Bucket so we can see what's going on?
/cc @hasheddan @krishchow

@prasek here is the "kubectl describe S3bucket..." result:
Name:         claimed-s3-test-yl
Namespace:    warrior
Labels:       <none>
Annotations:  crossplane.io/external-name: claimed-s3-test-yl
API Version:  storage.ccs.test.com/v1alpha1
Kind:         S3Bucket
Metadata:
  Creation Timestamp:  2021-02-19T19:20:35Z
  Finalizers:
    finalizer.apiextensions.crossplane.io
  Generation:        2
  Resource Version:  1578900
  Self Link:         /apis/storage.ccs.test.com/v1alpha1/namespaces/warrior/s3buckets/claimed-s3-test-yl
  UID:               aa184ac0-79a2-45e1-83cb-4b42fe30ec24
Spec:
  Composition Selector:
    Match Labels:
      Provider:  aws
  Parameters:
    Region:  us-east-2
    Server Side Encryption Config:
      Kms Master Key Id:  xxxxx1-xxx4f-xxx20-axxx3-xxxxxxcde04004
      Sse Algorithm:      aws:kms
  Resource Ref:
    API Version:  storage.ccs.test.com/v1alpha1
    Kind:         CompositeS3Bucket
    Name:         claimed-s3-test-yl-4n4c4
Status:
  Conditions:
    Last Transition Time:  2021-02-19T19:21:05Z
    Reason:                Composite resource claim is waiting for composite resource to become Ready
    Status:                False
    Type:                  Ready
Events:
  Type     Reason                      Age                 From                                                             Message
  ----     ------                      ----                ----                                                             -------
  Warning  BindCompositeResource       113s                offered/compositeresourcedefinition.apiextensions.crossplane.io  cannot update composite resource: Operation cannot be fulfilled on composites3buckets.storage.ccs.test.com "claimed-s3-test-yl-4n4c4": the object has been modified; please apply your changes to the latest version and try again
  Warning  ConfigureCompositeResource  113s                offered/compositeresourcedefinition.apiextensions.crossplane.io  cannot patch object: Operation cannot be fulfilled on composites3buckets.storage.ccs.test.com "claimed-s3-test-yl-4n4c4": the object has been modified; please apply your changes to the latest version and try again
  Normal   ConfigureCompositeResource  83s (x3 over 113s)  offered/compositeresourcedefinition.apiextensions.crossplane.io  Successfully applied composite resource
  Normal   BindCompositeResource       83s (x2 over 83s)   offered/compositeresourcedefinition.apiextensions.crossplane.io  Composite resource is not yet ready

sorry, missed the "describe bucket..."   Please check the following for it:
Name:         claimed-s3-test-yl-qsmlq-7nf5t
Namespace:
Labels:       crossplane.io/claim-name=claimed-s3-test-yl
              crossplane.io/claim-namespace=warrior
              crossplane.io/composite=claimed-s3-test-yl-qsmlq
Annotations:  crossplane.io/external-name: claimed-s3-test-yl
API Version:  s3.aws.crossplane.io/v1beta1
Kind:         Bucket
Metadata:
  Creation Timestamp:  2021-02-22T16:36:46Z
  Finalizers:
    finalizer.managedresource.crossplane.io
  Generate Name:  claimed-s3-test-yl-qsmlq-
  Generation:     1
  Owner References:
    API Version:     storage.ccs.test.com/v1alpha1
    Controller:      true
    Kind:            CompositeS3Bucket
    Name:            claimed-s3-test-yl-qsmlq
    UID:             7b35a599-06f7-4cce-b1d2-db2b13172cdb
  Resource Version:  53275
  Self Link:         /apis/s3.aws.crossplane.io/v1beta1/buckets/claimed-s3-test-yl-qsmlq-7nf5t
  UID:               7c7c967d-a31c-455b-92ed-47167984ffca
Spec:
  For Provider:
    Acl:                             private
    Location Constraint:             us-east-2
    Object Lock Enabled For Bucket:  false
    Server Side Encryption Configuration:
      Rules:
        Apply Server Side Encryption By Default:
          Kms Master Key Id:  XXXXXXd12f1-XXXX-4XXXX-aXXX3-2114cXXXX0XXXX
          Sse Algorithm:      aws:kms
  Provider Config Ref:
    Name:  aws-provider
Status:
  At Provider:
    Arn:  arn:aws:s3:::claimed-s3-test-yl
  Conditions:
    Last Transition Time:  2021-02-22T16:36:46Z
    Reason:                Creating
    Status:                False
    Type:                  Ready
    Last Transition Time:  2021-02-22T16:36:47Z
    Reason:                ReconcileSuccess
    Status:                True
    Type:                  Synced
Events:
  Type    Reason                   Age                From                                 Message
  ----    ------                   ----               ----                                 -------
  Normal  CreatedExternalResource  56s                managed/bucket.s3.aws.crossplane.io  Successfully requested creation of external resource
  Normal  UpdatedExternalResource  25s (x3 over 55s)  managed/bucket.s3.aws.crossplane.io  Successfully requested update of external resource

/cc @hasheddan @muvaf

@krishchow could you take a look at this?

fixed with #497


Dev

Coverage increased (+2.9%) to 100.0% when pulling 4d99b327ae9cb2f69cbaca169ebd316f3c6b4b60 on dev into 392bd64fcbada03e6468abe681c5e9bfab7f7316 on master.


No email is being sent

I set up cabot and put my correct SES user information in the production config file. However, the app does not send any emails when a check fails. I checked both the SNS log and my mailserver log - the email is never sent.
I also made sure ever checkbox saying e.g. "enable notification" is checked.

hi i am unable to send email via aws ses.
but smtp gmail works.
here is my config. kindly help
EMAIL_USER='.....'
EMAIL_PASSWORD='....'
EMAIL_BACKEND='django_smtp_ssl.SSLEmailBackend'
SES_HOST=email-smtp.us-west-2.amazonaws.com
SES_PORT=465
SES_USE_TLS=True
i get the error 'Could not send Email alert: No module named 'django_smtp_ssl'

@jaihind213 good question, it looks like plugins are not currently installing their own dependencies in setup.py so I guess you'll have to do manually into the docker image.
@JeanFred is there a reason plugins are not responsible for their dependencies?

thanks @dbuxton . will try. i found something else.
so i removed 'django_smtp_ssl.SSLEmailBackend'  and i got error 'Could not send Email alert: Connection unexpectedly closed'
EMAIL_USER='.....'
EMAIL_PASSWORD='....'
SES_HOST=email-smtp.us-west-2.amazonaws.com
SES_PORT=465
SES_USE_TLS=True
with port 465 - a telnet from inside the docker image to  email-smtp.us-west-2.amazonaws.com HANGS
but with port 587 , a telnet from inside the docker image to  email-smtp.us-west-2.amazonaws.com works ...

Have you tried using SES_PORT=587?

ya. i have been actually fighting with different combos and both dont work (i got gmail working though on 465)
the problem the error stack trace does not come fast. sometimes it does .. sometimes it doesnot.
#doesnot work
EMAIL_USER=...
EMAIL_PASSWORD=...
SES_HOST=email-smtp.us-west-2.amazonaws.com
SES_PORT=587
SES_USE_TLS=True
#doesnot work
EMAIL_USER=...
EMAIL_PASSWORD=...
SES_HOST=email-smtp.us-west-2.amazonaws.com
SES_PORT=465
SES_USE_TLS=True
#works on gmail
EMAIL_USER=user_without_gmaildotcom
EMAIL_PASSWORD=...
SES_HOST=smtp.gmail.com
SES_PORT=587
SES_USE_TLS=True

So the solution is to keep the EMAIL_BACKEND=django_smtp_ssl.SSLEmailBackend and make sure it's installed into the environment (assuming you're using docker, add something like RUN pip install django-smtp-ssl)
I will open a new issue against cabot-alert-email for not including its potential dependencies.

I believe the issue with with using port 465 for TLS.
We have it working with the following settings:
EMAIL_HOST=email-smtp.us-east-1.amazonaws.com
EMAIL_USER=*****
EMAIL_PASSWORD=*****
EMAIL_PORT=465

(SES_HOST/PORT are aliases of EMAIL_HOST/PORT now)
Try removing the SES_USE_TLS=True and see if that works


Bootstrap 5 (release) plus<EMAIL_ADDRESS>and CarouselIndicators

Using SvelteKit, noticed the CarouselIndicators no longer appear now that I upgraded to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Here's the code that worked with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

<template>

    <Carousel {items} bind:activeIndex interval={7000}>

        {#each items as item, index}
          <CarouselItem bind:activeIndex itemIndex={index}>

          </CarouselItem>
        {/each}
        <CarouselIndicators bind:activeIndex {items} />

    </Carousel>

</template>

Looking at the source, I see the CarouselIndicators are rendered as an ordered list with
 tags with a style="active" that moves from item to item as the slides change. But it should be rendering as buttons, right?

Hi @nstuyvesant this should be resolved with https://github.com/bestguy/sveltestrap/releases/tag/v5.0.0
https://sveltestrap.js.org/?path=/story/components--carousel
Please let me know if you still see issues.

Confirmed resolved - thanks!


Incremental indexing for DPR engine.

Incremental indexing for DPR engine.

@franzmpub - Could you please update the current status of this issue ?


allow parse to work with gzipped files

https://github.com/Cellular-Longevity/cmapPy/blob/master/cmapPy/pandasGEXpress/parse.py
*gctx files can be large, it would be nice to be able to work with *gctx.gz here

You can set the compression on the HDF5 file output to level 0-9 (0 is default).


Region Issue / Sega Mega Drive & Genesis

I get this message when trying to Play Aladdin:
www.loveroms.com/play-online/sega-genesis/aladdin-e-/808
"Developed for use only with PAL and French Secam Mega Drive Systems"
Any idea how we can fix this?

@vici0usx I think you should use region parameter with 'e' value. Like
{
system:'sega',
url:'...',
region:'e'
}
Supported regions: u - for USA roms (default), e - for Europe roms, j - for Japanese roms

Awesome! Great feature. Thank you.

I got this implemented and tried it with various Europe ROMs, I still have the same issue. This is an example output:
system : 'sega',
url : 'Aladdin%20(E)%20[!].zip',
region : 'e'

Pls send me this rom, I'll try to investigate.

Here you go

JACOB MATHIAS
Web Developer
Rather Talk?
Call -<PHONE_NUMBER>
On Wed, Jan 14, 2015 at 11:14 AM, Vadim Grigoruk<EMAIL_ADDRESS>wrote:

Pls send me this rom, I'll try to investigate.
—
Reply to this email directly or view it on GitHub
https://github.com/nesbox/emulator/issues/6#issuecomment-69962957.

I've got the problem. Please add 'ntsc:false' parameter for all European roms.

Worked, thanks !!!

"I've got the problem. Please add 'ntsc:false' parameter for all European roms."
How do I add this?

@vici0usx I think you should use region parameter with 'e' value. Like { system:'sega', url:'...', region:'e' } Supported regions: u - for USA roms (default), e - for Europe roms, j - for Japanese roms

Thanks!!


[FLINK-16123] Add E2E for auto-routable Protobuf Kafka ingress

Changelog description

a6a8855 Adds a new *-e2e module for the new E2E test.
ef3b31f Adds the verification application to test against. Please see Javadoc of RoutableKafkaVerificationModule on what it does.
e0c2b1d A preliminary addition to StatefulFunctionsAppContainers that allows the E2E to add YAML module definitions to be added to the application image build context.
652b132 Adds the actual E2E test. See Javadoc of RoutableKafkaE2E on how it verifies the ingress' functionality.

Verifying
Run mvn clean verify -Prun-e2e-tests to run the E2E test (or in the IDE).

@igalshilman I've rebased this on the latest master after merging #35.
Would you want to take a look at this as well?

Let’s merge it, so it won’t diverge too much.

Thanks, merging ...


[GI][Repair] Persistance URI for Game Repair changed

This causes game repair wont download persistent caches.
Error log:
[Warn]  Failed parsing persistent manifest: release_res_versions_external (localName: release_res_versions_external_persist). Skipped!
Hi3Helper.Http.HttpHelperUnhandledError: HttpResponse for URL: "https://autopatchhk.yuanshen.com/client_game_res/3.7_live/output_14937036_558aa900c6/client/StandaloneWindows64/release_res_versions_external" has returned unsuccessful code: NotFound
   at Hi3Helper.Http.Http.InitializeSingleSession(Nullable`1 OffsetStart, Nullable`1 OffsetEnd, Boolean IsFileMode, Stream _Stream, Boolean IgnoreOutStreamLength)
   at Hi3Helper.Http.Http.<>c__DisplayClass63_0.<Download>b__0()
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread, ExecutionContext, ContextCallback, Object)
--- End of stack trace from previous location ---
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread, ExecutionContext, ContextCallback, Object)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&, Thread )
--- End of stack trace from previous location ---
   at Hi3Helper.Http.Http.Download(String URL, String Output, Boolean Overwrite, Nullable`1 OffsetStart, Nullable`1 OffsetEnd, CancellationToken ThreadToken)
   at CollapseLauncher.GenshinRepair.ParseManifestToAssetIndex(Http _httpClient, String primaryParentURL, String secondaryParentURL, String manifestRemoteName, String manifestLocalName, String persistentPath, String streamingAssetsPath, List`1 assetIndex, Dictionary`2 hashtable, CancellationToken token)

Causing code:
https://github.com/neon-nyan/Collapse/blob/e46fb12e8ed38ef31d2955e3b730209368b3023e/CollapseLauncher/Classes/RepairManagement/Genshin/Fetch.cs#L133-L137
New URI:
https://autopatchhk.yuanshen.com/client_game_res/3.7_live/output_14937036_558aa900c6/client/StandaloneWindows64/res_versions_external

Well, the bug still exist. just with different code but similar cause
System.UriFormatException: Invalid URI: The URI is empty.
at System.Uri.CreateThis(String, Boolean, UriKind, UriCreationOptions& )
at System.Uri..ctor(String uriString)
at Hi3Helper.Http.Http.GetContentLengthAsync(String Input, CancellationToken token)
at Hi3Helper.Http.Http.TryGetContentLengthAsync(String URL, CancellationToken Token)
at CollapseLauncher.InstallManager.Base.InstallManagerBase1.TryGetPackageRemoteSize(GameInstallPackage asset, CancellationToken token)    at CollapseLauncher.InstallManager.Base.InstallManagerBase1.GetPackagesRemoteSize(List1 packageList, CancellationToken token)    at CollapseLauncher.InstallManager.Base.InstallManagerBase1.StartPackageDownload(Boolean skipDialog)
at CollapseLauncher.Pages.HomePage.InstallGameDialog(Object sender, RoutedEventArgs e)

@tilsgee I believe that's for the game installation right?
If yes, the fix is already pushed to Stable branch, while there is another bug regarding that, currently it is possible to install Genshin with the new segmented zip scheme
This issue is specifically meant for GI Repair

Hi @tilsgee,
I believe the issue is related to the Installation issue.
Please try updating your launcher to the latest stable release. Unfortunately, the fix didn't arrive to the preview release yet so you might need to switch to stable at the moment.


v6.0.0 Migrate to pyreqwest_impersonate, AsyncDDGS: all functions with a

migrate to pyreqwest_impersonate,
AsyncDDGS: all functions with a (text() -> atext())

Can I ask what the rationale was for switching to pyreqwest_impersonate? It requests a Rust toolchain and keeps your library from being used in Vercel serverless applications.

Hi.
The old versions stop working, I have to figure out new ways.
For now, use the version with httpx - pip install duckduckgo_search==5.3.1b1.
Show me the logs/links/whatever so I can understand the problem and help with a solution.


Header

Header is not displaying

Just noticed this issue. I'm not able to reproduce this error. So unless @mitajunior is still experiencing it, I'm going to close the issue.


timer: fix oss-fuzz issue #11852

Description:
Fix a time conversion signed int overflow (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11852).
Risk Level: low
Testing: fuzz

@ipuustin friendly ping on this one.

/retest


FreeBSD also uses struct timespec st_mtim

Fixes https://github.com/nodegit/nodegit/issues/1160

Any updates, maintainers?
Without this PR, nodegit isn't working for an entire platform, which I'd say, is kind of important?


Too many lines

How to configure this plugin to show only necessary scopes?
I want something like in JetBrains IDEs

Neovim (too many lines, looks messy)

Android studio (want to reach similar accuracy)

The plugin using shiftwidth if the file is indent with spaces, or tabstop if it is indented with tabs. You should try setting tabstop=4 and shiftwidth=4.

setting shiftwidth=4 do the job

I have the same problem and shiftwidth=4 does not fix it.


HADOOP-17420

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 35s

trunk passed

+1 :green_heart:
compile
19m 49s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
17m 17s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 54s

trunk passed

+1 :green_heart:
mvnsite
1m 31s

trunk passed

+1 :green_heart:
shadedclient
18m 12s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  6s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 39s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
2m 19s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 17s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 52s

the patch passed

+1 :green_heart:
compile
19m  8s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
19m  8s

the patch passed

+1 :green_heart:
compile
17m 35s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
17m 35s

the patch passed

-0 :warning:
checkstyle
0m 49s
/diff-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

+1 :green_heart:
mvnsite
1m 32s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 56s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  1s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 37s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
2m 26s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 33s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

168m 28s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2542/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2542

JIRA Issue
HADOOP-17420

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 7ca01072573f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / be35fa186cc

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2542/1/testReport/

Max. process+thread count
3249 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2542/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 21s

trunk passed

+1 :green_heart:
compile
20m 40s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
18m  6s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  6s

trunk passed

+1 :green_heart:
mvnsite
1m 34s

trunk passed

+1 :green_heart:
javadoc
1m  7s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 42s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
2m 27s

trunk passed

+1 :green_heart:
shadedclient
16m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 52s

the patch passed

+1 :green_heart:
compile
19m 57s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
19m 57s

the patch passed

+1 :green_heart:
compile
18m  4s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
18m  4s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  6s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 4 unchanged - 0 fixed = 6 total (was 4)

+1 :green_heart:
mvnsite
1m 31s

the patch passed

+1 :green_heart:
javadoc
1m  4s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 38s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
2m 30s

the patch passed

+1 :green_heart:
shadedclient
16m 43s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 48s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

180m 21s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2542/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2542

JIRA Issue
HADOOP-17420

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 4c2bb4ba7d5b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 23402c27d8885d562f0d638be59d0efd0fedc350

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2542/1/testReport/

Max. process+thread count
2440 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2542/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Removes redundant util::self

Rationale:
self hides the pub mod util in libsecp256k1-core implicitly, despite the intent of pub use libsecp256k1_core::*;

CI needs to be fixed 👀

Yeah - I ran into this today when trying to apply the latest master branch for use in libp2p-core. 💯


Add CommonLibrary.NET

I don't think this has been updated in a long time, but people are recommending it on StackOverflow.
https://archive.codeplex.com/?p=commonlibrarynet

@joelverhagen Apparently this wasn't built in release mode. There are 2 versions on NuGet and both are the same.

Do you want to disable optimization validation, create a new build based on source, or forget this library altogether? Looks like the only source is on CodePlex Archive.

@joelverhagen Apparently this wasn't built in release mode. There are 2 versions on NuGet and both are the same.

Do you want to disable optimization validation, create a new build based on source, or forget this library altogether? Looks like the only source is on CodePlex Archive.

Some people have copied sources to github that could be used.

Some people have copied sources to github that could be used.

Hm... my goal for this project is to be a helpful resource to the .NET community. In light of that, I think the most "net positive" outcome is to used an existing fork of this library on GitHub and test that one if it is clearly more popular than the debug version you've found. If there's no clear winner or if it looks fishy/very deviated from the upstream, then maybe a new fork is okay? I have already done this with FastCsvParser to get around a DLL name collision:
https://github.com/joelverhagen/Knapcode.FastCsvParser
In short, I think we should test the copy/version that users are most likely to discover and use.
But I'm not sure! What do you think?

Hm... my goal for this project is to be a helpful resource to the .NET community. In light of that, I think the most "net positive" outcome is to used an existing fork of this library on GitHub and test that one if it is clearly more popular than the debug version you've found. If there's no clear winner or if it looks fishy/very deviated from the upstream, then maybe a new fork is okay? I have already done this with FastCsvParser to get around a DLL name collision:
https://github.com/joelverhagen/Knapcode.FastCsvParser
In short, I think we should test the copy/version that users are most likely to discover and use.
But I'm not sure! What do you think?

I've tested like 4 or 5 of them and they're all the same. They're all an older version of .NET too, so it might be nice to be able to have an updated build for that also.

Package 'CommonLibrary.NET <IP_ADDRESS>' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework 'net5.0'. This package may not be fully compatible with your project.

I have all the unit tests passing for it, so I'll commit the code and you can create a fork if you like and change the package reference to that.
I sent an email to the maintainer of CommonLibrary.NET on NuGet and asked if he could release a new version in release mode. We'll see if he replies I guess.

I've tested like 4 or 5 of them and they're all the same. They're all an older version of .NET too, so it might be nice to be able to have an updated build for that also.

Package 'CommonLibrary.NET <IP_ADDRESS>' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework 'net5.0'. This package may not be fully compatible with your project.

I have all the unit tests passing for it, so I'll commit the code and you can create a fork if you like and change the package reference to that.
I sent an email to the maintainer of CommonLibrary.NET on NuGet and asked if he could release a new version in release mode. We'll see if he replies I guess.

https://github.com/joelverhagen/NCsvPerf/pull/24

https://github.com/joelverhagen/NCsvPerf/pull/24


Add initial helm chart

Not a lot of customization other than namespace right now, but its probably a nice installation option to have given that Helm is a widely used tool. We can probably expand options later on.

I made simillar changes in my helm playground, anyway I think the folder should be named helm3 because it is more visible which version it is.

And yes I agree that helm is widely used tool, for example strimzi users mainly use helm3 instead of bundle or operator hub.

@lulf also there are missing some values in chart like icon, description, keywords, mainteners, source, home


Responsive Drawer

Add ability to recalculate the drawer offsets from layout and state changes. This makes the drawer component responsive.

Merging this P.R which allows our drawer to become responsive on Web platform. We dont plan to contribute this back upstream as the parent project seems inactive.
The long term strategy is to move away from this drawer in-favour of Material UI React Drawer on Web, and the native android drawer on Native. (IOS has no drawer).


fix: LINEAR search doesn't work properly (if CHARSET_EBCDIC is defined)

#22107

Is there a test which fails on EBCDIC platforms without this fix? If not, perhaps it's worth writing one?
(Though it also seems this goofy linear search could be avoided by passing in a custom comparator.)

@davidben There is no unit test for OBJ_bsearch* functions. I would think that some tests could fail on EBCDIC due to this, but we do not have a CI run that would use EBCDIC so we cannot know.
It would be nice to have a unit test for OBJ_bsearch of course.

@mattcaswell @paulidale If you agree this is CLA: trivial, please remove the hold label. For me it is borderline but probably OK.

Even better would be if @pstetsuk could sign a regular CLA.

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

I'm okay with trivial.

This PR has the label 'hold: cla required' and is stale: it has not been updated in 30 days. Note that this PR may be automatically closed in the future if no CLA is provided.  For CLA help see https://www.openssl.org/policies/cla.html

Merged to the master, 3.1 and 3.0 branches. Thank you for your contribution.


ci: Update PR Template

Updated PR template to latest approved template

recheck

Codecov Report

Merging #305 (1a95a7f) into main (9a27036) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   21.66%   21.66%
=======================================
  Files           5        5
  Lines         480      480
=======================================
  Hits          104      104
  Misses        363      363
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a27036...1a95a7f. Read the comment docs.


Update-DNS does not remediate

:mag_right: Little typo in the Update-DNS test :mag_right:

:shipit: