Auto Effects: Spell Silence

The spell Silence for auto effects still has the old active auras/advanced macros on use macro in it when it should be changed.
I personally do this for active auras:
if (args[0].macroPass === "preActiveEffects") {
	return await game.modules.get("ActiveAuras").api.AAHelpers.applyTemplate(args);
}

Incase you want a download of the change its submitted to posney's discord as an item showcase here:  https://discord.com/channels/915186263609454632/1144307255911649361/1144307255911649361

I've been told that the item we recieve for silence in the muncher has the old Item Macro flags and shouldn't.  Apparently they are a lil on the performance degredation side, so if you can remake the item or clear the flag it'd help.  The item I linked in posney's discord has the correct item macro flag in it as I based it off the SRD item instead.

The AA and macro work just fine here. Also what do you mean old "item macro flags" ?

I really need to check my pings here more often.  Elwin said that the flags on the item export of a ddbi item had the old v9 data scheme for item macro which apparently keeps things in memory or something and is inefficient compared to the modern scheme for flag data on the items for item macro.

I just tried using the DDBI version in v11 and none of the effects were created on anyone in the spell template.
I did remove Advanced Macros, in case that is something that is still required, it might explain why it's no longer working.

Nope, I am a dummy and just wasn't in combat so AA wasn't firing.


fix: symlink to python3 instead of python_real

On MacOS (or at least what I'm running), it has some odd semantics around how /usr/bin/python behaves which appear to depend on the name of the binary itself 🙄
If the autodetecting toolchain links /usr/bin/python, then the shim will call python_real, which in turn gets called by whatever the binary at /usr/bin/python is, and as python_real isn't a binary it can call, it decides it needs to install Xcodes command line utilities. This of course doesn't help, and the cycle continues.
Instead, link to python3, and only link in python into the venv/bin as the others were kinda extraneous anyway.

It's hard to tell from the description, but this might be what the PYTHONEXECUTABLE env var helps with. It's a macOS-specific thing that I've had to use in the past when dealing with Python wrappers.
For lack of a better thing to link to: https://github.com/python/cpython/blob/8aa9d40b00741213c5a53b1ae15509998893ae31/Misc/python.man#L578-L582
which says

PYTHONEXECUTABLE
If this environment variable is set, sys.argv[0] will be set to its value instead of the value got through the C runtime. Only works on Mac OS X.

This is what I get on my local Mac:
$ which python
/usr/bin/python

$ ln -snf /usr/bin/python3 ./python

$ ./python --version
Python 2.7.16

$ ln -snf /usr/bin/python3 ./python3

$ ./python3 --version
Python 3.8.9

$ export PYTHONEXECUTABLE=/usr/bin/python3; ./python --version
Python 2.7.16

$ export PYTHONEXECUTABLE=python3; ./python --version
Python 2.7.16

$ ln -snf /usr/bin/python3 ./python_real
$ ./python_real
xcode-select: Failed to locate 'python_real', requesting installation of command line developer tools.

Hmm yeah, this is different. /usr/bin/python3 is some launcher that actually invokes /Library/Developer/CommandLineTools/usr/bin/python3. When I do e.g. /usr/bin/python3 -m venv /tmp/env, /tmp/env/bin/python3 links to that executable under /Library/...
So I guess you could also set the symlink target to the output of e.g. $(/usr/bin/python3 -c 'import sys; print(sys.executable)')

Hm yeah good point. That might help in breaking out into the wrong site-packages folder too. Let me give that a try.

I like this fix better as it also resolves the issue where the autodetecting toolchain could in some cases pick up the hosts site-packages folder, even with the symlink trickery. Now we resolve back to the actual Python interpreter binary at toolchain resolution time (I mean, it's still kinda wrong, but as host toolchains go, it's fine) and the symlink trickery works in all cases as the interpreter itself is not a wrapper or another symlink, so the base prefix is always set correctly.


ISRC field not accepting all values

There seem to be several variations of the ISRC field. There must be a way to accept them all.
Otherwise, a text field should be used.

For now, the known ISRC formats are accepted.


Add panels to bottom of markdown editor to append predefined snippets to ep descriptions

[ ] Feedback link (when available)
[ ] Link to site (when available)
[ ] "Powered by Pinecast" (optional for paid customers, required for demo)

Maybe implement these as a bitfield on PodcastEpisode

DB migration done


CHANGE capability level description to independent levels

CHANGED accumulating for independent levels on cap description

Signed-off-by: acmenezes<EMAIL_ADDRESS>
Description of the change:
On this PR I propose to change the capability description found at https://sdk.operatorframework.io/docs/overview/operator-capabilities/ where the word accumulating leads to the understanding that capability levels are technically dependent on lower level ones. We know that we can include level 4 capabilities without having level 3 or 2 for example. We can have a broader discussion about how to grant badges for the operator hubs on this. This is not the intention here. It's just to eliminate the confusion for the users reading this doc.
Motivation for the change:
Multiple partners, operator-sdk users, have asked questions about this specifically showing that this particular wording causes confusion among them.
Checklist
If the pull request includes user-facing changes, extra documentation is required:

[ ] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
[x] Add or update relevant sections of the docs website in website/content/en/docs

@acmenezes Thanks for the contribution! I will work on rerunning some the test failures (the failing tests can be a bit flaky) and getting this merged in.


Error in natural and artificial perturbations

Hello, I am a aeropace engineering master student and I was trying to use the poliastro environment to perform a project for one of my classes.
I was trying to use the code to implement the J2 perturbation (the code I found here) when I encountered the following error:
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-3-5de11052fd1e> in <module>
     15 tofs = TimeDelta(np.linspace(0 * u.h, 100000 * u.s, num=2000))
     16
---> 17 rr = propagate(
     18     orbit,
     19     tofs,

~\anaconda3\lib\site-packages\poliastro\twobody\propagation.py in propagate(orbit, time_of_flight, method, rtol, **kwargs)
    465         pass
    466
--> 467     rr, vv = method(
    468         orbit.attractor.k,
    469         orbit.r,

TypeError: cowell() got an unexpected keyword argument 'ad'

This happened not only for the J2 perturbation but I also tried with the 3rd body code and got the same result. Maybe it is a problem with my poliastro version (I have the 0.15.dev0) because I checked with a friends computer and everything worked for him.
Thank you in advance and sorry for any incoveniences. :)

Hello @ana-cp, Thank you for using Poliastro. I would like to bring to your notice that the cowell() function defined here is undergoing some changes to incorporate a faster implementation. The current implementation doesn't take into account the argument ad.
I would suggest that you install, the 1.14 version of the library & please try to re-run the examples again. Kindly let us know for any further assistance 😄

Welcome @ana-cp , and thanks @DhruvSondhi for chiming in! The documentation you linked is the stable version, which works with poliastro 0.14.0:
https://docs.poliastro.space/en/stable/examples/Natural and artificial perturbations.html
But, if you want to use the development version (master branch on GitHub), you will need to check out this instead:
https://docs.poliastro.space/en/latest/examples/Natural and artificial perturbations.html
Notice that cowell doesn't receive ad anymore, but a function that describes the two-body motion:
def f(t0, state, k):
    du_kep = func_twobody(t0, state, k)
    ax, ay, az = atmospheric_drag_exponential(
        t0,
        state,
        k,
        R=R,
        C_D=C_D,
        A_over_m=A_over_m,
        H0=H0,
        rho0=rho0,
    )
    du_ad = np.array([0, 0, 0, ax, ay, az])

    return du_kep + du_ad

rr = propagate(
    orbit,
    tofs,
    method=cowell,
    f=f,
)

Let us know if this fixes the issue :)

Hello @astrojuanlu and @DhruvSondhi, thank you for your assistance and for your fast answer!
I tried using the development version for my problem but it did not work as I got a different error; so I downloaded the previous version of poliastro (0.14.0) as you suggested and then it worked. Thank you a lot and sorry for any inconvenience! :)


What is the best way to gather the representation of the protein?

Hi, thanks for providing such useful tools! However, I wonder what is the best way to gather the representation of the protein.
To be specific, the official document gives an example to generate per-sequence representations via averaging token-level representations. But as you know, transformer-based models in NLP prefer using the first token [CLS] as the per-sequence representation.
Do you try these two different methods? Or it may depend empirically on the task that I choose?

In the frontpage README we mention:

mean includes the embeddings averaged over the full sequence, per layer.
bos includes the embeddings from the beginning-of-sequence token. (NOTE: Don't use with the pre-trained models - we trained without bos-token supervision)

In general we don't expend the bos (equivalent to CLS) token to have meaningful representations as it hasn't been supervised.

Thanks for your reply.


Update react-transition-group dependency

Updates the react-transition-group dependency to help with compatibility with React strict mode.

[X] Bug fix for part of #1340
[X] Chore since it also updates a dependency
[X] I have read the CONTRIBUTING document.
[X] My commits follow the Git Commit Guidelines
[X] My code follows the code style of this project.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

Helps towards fixing #1340
Supersedes #1907

Would also need use the nodeRef API, since RTG still uses findDOMNode under the hood.

Would also need use the nodeRef API, since RTG still uses findDOMNode under the hood.

I've tested the specific component with strict mode and no warnings were shown. How can I can reproduce the situation to get strict mode warnings with RTG?

You'll need to trigger an animation to see the warning, like clicking the toggle button on the collapse examples.

@kyletsang Thanks for the tips, I've updated the code to use the new nodeRef API.

Why is not merged?

@cesarve77 the changes would increase the minimum required React version from 16.3 to 16.6. I can make the changes but I requested some feedback from the maintainers to know if this is the right thing to do.

Is there anything that I can do to help get this merged? The findDOMNode deprecation warning in the console makes me worry.

@stdavis I've updated the PR to the latest master. I've noticed that the library has been updated to use react-transition-group version 4.4.2, hence this isn't exactly a "breaking change" anymore.
I'd ask the library's maintainers to take a look at the changes again and tell me if there's anything else that needs to be done to get this merged. It should fix the deprecation warnings, as far as I can tell.

This looks good to me! Hopefully it gets some attention. Thanks, @GabrielMajeri !

Any updates on this ?

Please merge this.

Seems like the Collapse documentation isn't working after the above changes: https://deploy-preview-1992--reactstrap.netlify.app/?path=/docs/components-collapse--collapse

Everything looks good, just a few changes and maybe a rebase is needed as the documentation seems broken for the Collapse component.

Thank you for the feedback @davidacevedo. I've committed the corresponding changes and rebased the pull request against the latest master.

I've pushed a new commit, addressing the lint and formatting issues encountered in CI.


Update/Delete/cancel notifications

Return token on publish
Or set token when publishing

So I think the token idea is not even necessary because the topic is implied to be either secret or protected anyway.
The difficulty is now how to update the clients. They'd all need to understand that a message with the same ID can get updated.

id=$(curl -d "Build process starting" ntfy.sh/mytopic | jq .id)
for progress in 10 20 30 40 50 60 70 80 90 100; do
  curl -X PATCH -d "Build process running, currently ${progress}%" ntfy.sh/mytopic/$id
  sleep 10
done

This would have useful applications in the IoT space, for example if my dehumidifier tank fills up and sends me a notification, there's no need for the notification to remain once I've emptied the tank. So would be useful if my automation could clear it from the android notification shade e.g. By deleting the notification or changing it's priority.

It is extremely useful in monitoring systems, when for example your host is down and later it's up and previous notification is useless.

this feature would take this project to the next level for sure thanks


Replace set-output by $GITHUB_ENV

Hi
https://github.com/lycheeverse/lychee-action/blob/2e991c588d2d66f0622b3b6a96bda71b28afaf67/entrypoint.sh#L51
set-output function of GHA is deprecated. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
It is recommended to use Environment files instead. An example from GHA docs:
steps:
  - name: Set the value
    id: step_one
    run: |
      echo "action_state=yellow" >> $GITHUB_ENV
  - name: Use the value
    id: step_two
    run: |
      echo "${{ env.action_state }}" # This will output 'yellow'

I can do a PR with the fix, but I'd like to have a confirmation first.

Oh that's great news because the current syntax is pretty awful. I'd be thankful for a pull request.


WIP: added service routing support

Fixes #769

Tested everything it works. @sharadregoti please review

tmr


React import is being omitted

I'm getting an issue with React/JSX on VSCode with the master from today and I use the latest react-jsx.d.ts and react.d.ts from DT. I extend React.Component in an another file and then use it on my current file. So I don't expose React namespace in my current file. And when I import React it is being shaked off.
module1.tsx
/// <reference path='typings/react/react.d.ts'/>
/// <reference path='typings/react/react-jsx.d.ts'/>

import * as React from 'react'; // it didn't gave me any error when this line is omitted.

export class Document
 extends React.Component
 {
    public name: string;
}

module2.tsx (notice omit comment)
/// <reference path='typings/react/react.d.ts'/>
/// <reference path='typings/react/react-jsx.d.ts'/>

import {Document} from './module1';
import * as React from 'react'; // this line is being omitted

interface Props {}
interface States {}

class Something extends Document<Props, States> {
    public name = 'helloworld';

    render() {
        return

    }
}

module1.js
/// <reference path='typings/react/react.d.ts'/>
/// <reference path='typings/react/react-jsx.d.ts'/>
var __extends = (this && this.__extends) || function (d, b) {
    for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
    function __() { this.constructor = d; }
    d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
};
var React = require('react');
var Document = (function (_super) {
    __extends(Document, _super);
    function Document() {
        _super.apply(this, arguments);
    }
    return Document;
})(React.Component);
exports.Document = Document;
//# sourceMappingURL=module1.js.map

module2.js
/// <reference path='typings/react/react.d.ts'/>
/// <reference path='typings/react/react-jsx.d.ts'/>
var __extends = (this && this.__extends) || function (d, b) {
    for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
    function __() { this.constructor = d; }
    d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
};
var module1_1 = require('./module1');
var Something = (function (_super) {
    __extends(Something, _super);
    function Something() {
        _super.apply(this, arguments);
        this.name = 'helloworld';
    }
    Something.prototype.render = function () {
        return React.createElement("div", null);
    };
    return Something;
})(module1_1.Document);
//# sourceMappingURL=module2.js.map

Also because the export class makes below file an external module. Don't you think it should error on below comment:
/// <reference path='typings/react/react.d.ts'/>
/// <reference path='typings/react/react-jsx.d.ts'/>

import * as React from 'react'; // it didn't gave me any error when this line is omitted.

export class Document
 extends React.Component
 {
    public name: string;
}

For module2: see https://stackoverflow.com/questions/15267705/typescript-compiling-removes-unreferenced-imports
For module1:
This is due to the particular way react.d.ts is coded. It declared React as an exported module, which tells the compiler the React symbol is a reachable object regardless of whether the library is imported. I guess this is to accommodate front-end setups where the React library is loaded externally to the module system.
Arguably, the definition file write should have left the choice to the user and let you decide whether to declare React as an ambient variable or as an imported module.

That SO thread is not relevant for me, since it is an amd reference. I still think module2 is a bug, because I declared with a flag that I'm using React.createElement factoring and in my code I have wrote

I agree with you on module1. Maybe send a PR and have d.ts file not exposing globals.

There's already a pending PR to go back to the previous style of .d.ts for React, which was to have a separate .d.ts file for the global 'React' vs the importable module.
Under --jsx react we should treat any element as a usage of the 'React' symbol.


Render block by default on minimap

@alexandrudima
See https://github.com/Microsoft/vscode/issues/4865#issuecomment-282449963

@octref I think this is a matter of taste, where there is no clear right or wrong, or there is no superior or inferior option.
IMHO rendering characters is a good default, it is what both Sublime and Visual Studio do out of the box. Atom renders blocks out of the box, as they cannot render characters.
We have the option to turn rendering into blocks and I think people will choose what they like most. I personally switch the toggle on/off as I am going from high-DPI display to low-DPI display.


Update ipAdress to ipAddress

In your code you have write ipAddress with one d.
cf => https://github.com/Mangopay/mangopay2-nodejs-sdk/compare/1.14.4...1.14.5#diff-613eca09763785e29259820d09d9c797766268513b99dbde9d082f8589c1c4b3R99

Hi @julien-boucly
we are checking

Hi @julien-boucly
we are checking

https://github.com/Mangopay/mangopay2-nodejs-sdk/pull/226


Add description, how to contact, reporting issues

added LCOS description to README
added information on how to join the discord
information on reporting an issue

Looks good to me


Epic for requirements for current UI and functionality data plane API readiness

This epic is to track the requirements for the current UI and functionality of data plane API readiness app that needs to be done if the new UI is going to be delayed to later in Gallium or post-Gallium.

[ ] Need to add GitHub issue for changes to pre-requisite screen (wording around API Spec pipeline and time estimate)
[ ] Need to add GitHub issue for changes to the API design screen (doc links to Hero Scenarios, Core Concepts, ...)
[ ] https://github.com/Azure/azure-sdk-tools/issues/5560
[ ]  Need to add a GitHub issue for handling API Readiness signoffs (update Azure Devops work item fields and email to APEX owners (service team and Azure SDK).

Need to add a GitHub issue for handling API Readiness signoffs (update Azure Devops work item fields and email to APEX owners (service team and Azure SDK).

I don't see this as a necesary thing to add in the current UI. What are the implications of not developing this in the current UI?

(wording around API Spec pipeline and time estimate)

API Spec pipeline work is on pause right now because of the transition work. As part of the update, we should include this

API Spec pipeline work is on pause right now because of the transition work. As part of the update, we should include this

https://github.com/Azure/azure-sdk-tools/issues/5902

@ladonnaq could you please create an issue for

Need to add a GitHub issue for handling API Readiness signoffs (update Azure Devops work item fields and email to APEX owners (service team and Azure SDK)

with the respective requirements you want engineer to develop?


How to use Tao eventloop in Tauri ?

Describe the bug
I have no problem using it according to the example, but after executing eventloop, the frontend can no longer send messages to the backend, the thread is blocked!
Steps To Reproduce
in rust
#[tauri::command]
fn init_listen(_: tauri::AppHandle, window: tauri::Window) {
    // init_hotkey(window);

    let event_loop = EventLoop::new();
    event_loop.run(move |event, _, control_flow| {
        *control_flow = ControlFlow::Wait;
        // *control_flow = ControlFlow::Wait;
        println!("{:?}", event);
    })
}

frontend
invoke('init_listen')
// ...
const path = await import('@tauri-apps/api/path')
console.log(await path.resourceDir()) // It's blocked!!!

Platform and Versions (please complete the following information):
[✔] Environment
- OS: Windows 10.0.19045 X64
✔ WebView2: 116.0.1938.62
✔ MSVC: Visual Studio Community 2022
✔ rustc: 1.71.1 (eb26296b5 2023-08-03)
✔ Cargo: 1.71.1 (7f1d04c00 2023-07-29)
✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
- node: 18.12.1
- pnpm: 8.5.0
- yarn: 1.22.19
- npm: 9.8.0
[-] Packages
- tauri [RUST]: 1.4.1
- tauri-build [RUST]: 1.4.0
- wry [RUST]: 0.24.3
- tao [RUST]: 0.16.2
- @tauri-apps/api [NPM]: 1.4.0
- @tauri-apps/cli [NPM]: 1.4.0
[-] App

I know about the with_any_thread function, but it's not compatible with macOS, so I didn't use it.
You said tauri has a tao event loop inside, is there any way to get it or use it?

I know about the with_any_thread function, but it's not compatible with macOS, so I didn't use it.

welp, then you're probably really out of luck without multiple explicit processes.

You said tauri has a tao event loop inside, is there any way to get it or use it?

Nope, only what's explicitly exposed can be used so if there's something missing tell us about it and of course we always appreciate PRs :)

Ok, fine.
I'd like to ask something else.
https://github.com/tauri-apps/global-hotkey/blob/dev/examples/tao.rs
Here's what I'm trying to accomplish
If the envent loop doesn't work, is there another way to listen?

I'm not too familiar with that crate but maybe tauri's run_iteration is enough? If not, i guess you can also use set_event_handler and use a traditional channel to send it to wherever.

Here's an example of the event handler from the official v2 plugin: https://github.com/tauri-apps/plugins-workspace/blob/v2/plugins/global-shortcut/src/lib.rs#L303
That's a good way to go.
I wanted to use also GlobalShortCut at first, but it seems that there is no exposure to use it directly, only a trait. if you want to use it you can only go to call it on the front end.

I solved the problem using set_event_handler, thank you very much!!!!


Unified function name， Networks

Change'Enabled Networks' to 'Select Active Networks'

Part of #1659. Almost there.


Add attachments support to owa

Add support for uploading attachment to shuffle after get_mails and add attachments in send_mail

Nice, well done!
I think a standard workflow for this would be really useful at this point to help other people out :fire:

We are aligned probably :D
I've only a little problem, If I have multiple attachments from multiple emails the variable became something like:
$read_mails.#.attachments_uids.#
But if I pass this to a input (eg. as file for filedata param in extract_archive) it says that is not valid because list of list.
How to manage this properly?

@dadokkio List of list shouldn't really be a problem, but I think it's a general issue with multiple files. I'll have to check this properly!

At the moment I'm using with
$read_mails.#.attachments_uids.#0
And is working fine.. but just picking one attachment for each email

Ye, #0 and # work completely differently in the background, even if there's only one element. I'll get this working ASAP :+1:


raspberry pi support

via https://github.com/jalbam/nwjs_rpi or similar

for OS disk image: https://www.ubuntu.com/download/iot/raspberry-pi-2-3 (if 16.04 is needed) or https://wiki.ubuntu.com/ARM/RaspberryPi if we can use v18.x w/ http://www.tooloop.org/


Mega Issue: Improve the Performance of Deprovisioning

Tell us about your request
Improve the Performance of Deprovisioning Workflows for large and busy (pods coming and going) clusters.
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
In large and busy clusters, consolidation can take a while to evaluate 10 - 30 minutes. If the cluster is busy where the consolidation decision is not valid after the 15 sec ttl, then little progress can be made towards consolidation. There are two optimization fronts that I could see working on independently:

[x] Optimize the number of nodes that multi-node consolidation should take action on. This could be a dynamic calculation starting with all nodes as eligible candidates and then reducing that number on each validation failure OR it could be statically capped at 5 or 10 node max. I would lean toward making this dynamic with an algorithm that halves the number of nodes on a validation failure and then builds back up at some rate.
[x] Reduce the time spent computing consolidation actions should also be evaluated. It may be feasible to parallelize computation. This is mainly to accommodate large clusters so scale testing could be performed using 4 - 8 cpus for the Karpenter controller.
[ ] Factor out the waits for replacement nodes and terminations
[ ] Factor out the TTL validation wait on Consolidation so that other deprovisioning can occur during the 15 second sleep
[ ] Configurable number of Deprovisioning actions: https://github.com/aws/karpenter-core/issues/255

Are you currently working around this issue?
N/A
Additional Context
No response
Attachments
No response
Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

#472 implemented the first two items linked in the issue.

I have a similar issue to https://github.com/kubernetes-sigs/karpenter/issues/670 but not exactly the same. Specifically our cluster is extremely active and will pretty much always have some level of "Pending pods" causing consolidation to pretty much never take place.
https://github.com/kubernetes-sigs/karpenter/blob/main/pkg/controllers/disruption/consolidation.go#L130.
Wondering if there is something we can do about this? ( can also cut an issue for this)


Example is out of date

Steps to Reproduce
Run the example files in debug and watch the log
Expected results

not using google.bintray.com
no stack traces

Actual results

using google.bintray.com
lots of stack traces

About your device

Brand
Model
OS

motorola
moto g
9

duplicate of #138


use ubuntu-20.04 as run-on os to build sealer binary

Describe what this PR does / why we need it
Does this pull request fix one issue?

Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Base: 17.51% // Head: 17.51% // No change to project coverage :thumbsup:

Coverage data is based on head (4cfea9a) compared to base (3f444e6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1934   +/-   ##
=======================================
  Coverage   17.51%   17.51%
=======================================
  Files         103      103
  Lines        9139     9139
=======================================
  Hits         1601     1601
  Misses       7325     7325
  Partials      213      213

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Enhancement/time zone handling

Description:

Call LocalDateTime.now(ZoneOffset.UTC) once at distribution start and pass it through the code base.

Add unit test that uses current hour as distribution time to prove time zone handling.

Generate test keys up to current hour

Once the application was using UTC for all dates, we realised that test data generation was generating keys up to current hour - 2.
We changed the behavior so that keys are generated up to current hour always. The assembly step will then select keys up until the previous hour or current hour if demo step is active. Without this change, running test generation with or without demo profile didn't make any difference in the output folder.


Large creatures provide flanking as if they have reach

Large (or more) creatures that don't have reach (like a Tiger) still provide flanking to their allies as though they did.
To reproduce:
Put a player token between 2 large creatures, even if neither of those are adjacent to the token. The player will be flanked, and their AC reduced.
The issue also seem to happen with Huge creatures that don't have reach, like the Hive Mother.

What is the reach of a quasit's claw attack?

According to the rules, the Quasit's Claw attack should have a reach of 5ft, since its statblock doesn't say otherwise.
In Foundry, the Quasit seem to be assumed to not have any reach, and seem unable to flank, or provide help with flanking.

I'm not sure what rules those are.

The alternative would be assuming that Reach work as indicated by the table from the CRB p473 https://2e.aonprd.com/Rules.aspx?ID=445 (which is mentioned again in the bestiary, p345), which are supposed to be guidelines.
We can look at a creature like Arboreal  Warden, who has its reach of 10ft specified on one attack, and nothing on the other, which seems to indicate a reach of 5ft (but is also inconsistent with the Gorilla, which has reach 10ft on its fists, and reach 5ft on its jaw).
Looking a bit further, a Shield Archon, Lillend, Cyclops, Ceustodaemon are large and tall creatures but their only attack still specify their reach of 10ft.
The Demilich is the only creature i've been able to find who has an attack with a specified reach of 0 ft.


[TASK] Initial implement the UI SQL Lab page

What's the level of this task?
MEDIUM
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before creating

[X] I have searched in the task list and found no similar tasks.

Mentor

[ ] I have sufficient expertise on this task, and I volunteer to be a mentor of this task to guide contributors through the task.

Skill requirements

Frontend stack

Background and Goals
https://github.com/apache/kyuubi/pull/5517
Implementation steps
https://github.com/apache/kyuubi/pull/5517
Additional context
Introduction of 2023 Kyuubi Code Contribution Program

This task is completed by @labbomb via https://github.com/apache/kyuubi/pull/5517


ExcelFileType class added

New file type class (ExcelFileType) added to support operations on Excel files (see https://github.com/astronomer/astro-sdk/issues/1956)

LGTM. But look like there is a conflict and would be great if we can add a test here if possible https://github.com/astronomer/astro-sdk/blob/main/python-sdk/tests/sql/operators/test_load_file.py

Hi, when I run pytest -s -v -x -k load_file in tests\sql, I'm getting an error astro.exceptions.NonExistentTableException: The table _tmp_xxx does not exist. Is this a problem you've mentioned?

@pankajastro , when I run pytest -s -v -x -k load_file in tests\sql, I'm getting an error astro.exceptions.NonExistentTableException: The table _tmp_xxx does not exist. Is this a problem you've mentioned?

Hi @skolchin, from log you have shared it is difficult to say why it happening. but test work on the local machine. We have some integration tests that require more setup like credentials etc.
I would suggest, maybe adding an airflow task here https://github.com/astronomer/astro-sdk/blob/main/python-sdk/example_dags/example_load_file.py would be great. We have everything in CI to run this
my_homes_table = aql.load_file(
        task_id="local_to_postgress_glob",
        input_file=File(path=str(CWD.parent) + "/tests/data/example. xlsx*", filetype=FileType. XLSX),
        output_table=Table(
            conn_id=ASTRO_POSTGRESS_CONN_ID,
        ),
    )

@skolchin do let us know if you need any support on this, looks like we are very close to merging it

@pankajastro Hi, sorry, was buzy yesterday. Test added and it seems it works

@pankajastro Hi, sorry, was buzy yesterday. Test added and it seems it works

Thanks, @skolchin, I'm looking into CI when it green I'll merge it

Look like some issue with the Github action.

This is awesome, thanks @skolchin 👏 for creating the PR. Appreciate it.


Turn on SSL for issue #60.

In preparation for issue #60, this setting can be enabled now.  When the app is deployed to heroku it will inherit the heroku SSL certificate until GDI sets up their own certificate.
In the meantime, it's good net citizen behavior to enable SSL by default in any public facing application.

:+1: thanks @bayendor for your contribution! \o/ Looks good and will def need this.


Publish project Javadoc

Javadoc are very comprehensive for this project.
It would be nice to maintain revisions moving forward. Maybe these can kept in the static gh-pages branch I think.
There are a number of options here... we can implement this before the next library release... and hopefully back it in to the release profile.
http://khuxtable.github.io/wagon-gitsite/
or
* Commit the release pom.xml.
* Generate the JavaDocs to a .gitignore'd directory (so it would be preserved across branch changes).
* Checkout the gh-pages branch.
* Replace all of the files in the working directory with that of the directory the JavaDocs were copied to
* Commit
* Checkout the original branch.
* Continue with release...

My preference if for first option... if we can bake this in to a release profile then it is nice and clean.

@kohsah the wagon plugin is more hassle than it's worth IMHO. Manually adding these to the gh-pages and making them current is a better more managed solution. Although it takes a bit more time (2 minutes) it ensures that versioning is correct, etc.

@lewismc thanks for updating the javadoc.

No at all
On Thursday, June 18, 2015, kohsah<EMAIL_ADDRESS>wrote:

@lewismc https://github.com/lewismc thanks for updating the javadoc.
—
Reply to this email directly or view it on GitHub
https://github.com/kohsah/akomantoso-lib/issues/7#issuecomment-113289017
.

--
Lewis


[QUERY] What exception thrown by BlobStorage SDK when token is cancelled

Query/Question
How can we help?
We are trying to replicate the behavior of MaxiumExecutionTime (from V11). I saw in this issue https://github.com/Azure/azure-sdk-for-net/issues/19697 that we can use cancellationToken.CancelAfter to perform this. What exception is thrown by the Blob SDK in such a scenario. Is it OperationCanceledException? Are there any samples on how we can mock this? We are writing some retry logic on top of this, and would like to write unit tests for them.
Environment:

Name and version of the Library package used: Azure.Storage.Blobs 12.7.0, Azure Identity 1.3.0, Azure Core 1.6.0
Hosting platform or OS and .NET runtime version (dotnet --info output for .NET Core projects): Windows 10 .NET Framework 4.7
IDE and version :Visual Studio 16.9.11

Thanks @seanmcc-msft this is really helpful


Relative navigation after pushState does not respect new URL

What is your Test Scenario?
I saw some error pages that only happened in TestCafé but not when I execute the text manually. Turns out navigating with location.href works differently in TestCafé when you also do history.pushState on the page (as e.g. react-router does)
What is the Current behavior?

Load a website
Use history.pushState with a URL on another level (e.g. use / somewhere in the 3rd argument)
Use location.href="relative" to navigate
The navigations happens relative to the initial URL and not relative to the updated URL

What is the Expected behavior?
The navigation should happen relative to the URL currently displayed in the address bar, just like it does in the browser.
What is your web application and your TestCafe test code?
Your website URL: I created a test that runs on some random GitHub pages, see test code below.

Your complete test code:

 import {ClientFunction} from 'testcafe';

fixture`testcafe 2140`.page`https://github.com/bxt/testcafe-2140`;

const goAway = ClientFunction(() => {
  window.location.href = 'pulls';
});

const virtualNavigation = ClientFunction(() => {
  history.pushState({}, "page 2", "testcafe-2140/deeper");
});

const getPageUrl = ClientFunction(() => window.location.href);

test(`navigates to the correct URL on GitHub`, async t => {
  await t.expect(getPageUrl()).eql('https://github.com/bxt/testcafe-2140');

  await virtualNavigation();

  await t.expect(getPageUrl()).eql('https://github.com/bxt/testcafe-2140/deeper');

  await goAway();

  await t.expect(getPageUrl()).eql('https://github.com/bxt/testcafe-2140/pulls');
});

Your complete test report:

> testcafe chrome test.ts
 Running tests in:
 - Chrome 77.0.3865 / Mac OS X 10.14.6

 testcafe 2140
 ✖ has the correct value in Request('/').url on GitHub

   1) AssertionError: expected 'https://github.com/bxt/pulls' to deeply equal
      'https://github.com/bxt/testcafe-2140/pulls'

      Browser: Chrome 77.0.3865 / Mac OS X 10.14.6

         19 |
         20 |  await t.expect(getPageUrl()).eql('https://github.com/bxt/testcafe-2140/deeper');
         21 |
         22 |  await goAway();
         23 |
       > 24 |  await t.expect(getPageUrl()).eql('https://github.com/bxt/testcafe-2140/pulls');
         25 |});
         26 |

         at <anonymous> (/Users/bxt/test.ts:24:32)
         at fulfilled (/Users/bxt/test.ts:5:58)

 1/1 failed (6s)

Steps to Reproduce:
Execute the code below "Your complete test code" above in a file e.g. using testcafe chrome test.ts.
Your Environment details:

testcafe version:                   1.5.0
node.js version:                    v12.10.0
command-line arguments:  testcafe chrome test.ts
browser name and version: Chrome 77
platform and version:          macOS 10.14.6
other:                                   none

Hi @bxt
I've reproduced the problem. Thank you for the provided example.


Can't get it to run on local machine.

I cloned the repository and ran it using node index.js. The Application opens, but nothing happens when I enter in hashtag data. I'm using this for a class project and any help is appreciated, thanks!

Hey!
Looks to be working on heroku, can you send me a screenshot of the console.
Looks like you may be missing some dependencies.
Thanks,

So as u can see, there is no error so to speak , in the console. It runs fine, but somehow doesnt work in the local machine, like the screenshot above.
However, there are these errors we found in inspect element.

@pabangan
Hey,
Looks like the angular reference was missing, you can try to pull the latest changes and serve the application.
Thanks


addStep not return step instance

Here
Like the issue #76
A quick fix was exist for an older version #88

We just ran into this. Disappointing it's been ignored for so long!

I believe this is the intended behavior. From the docs Creates a new Step object with options, and returns the Tour object for convenient chaining when creating multiple steps.  Perhaps returning the step is more helpful than being able to chain though.

The docs were actually contradicting, so I fixed them, and returned the step. Sorry for the delay!


-g outputs two links instead of one

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.07.02. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[ x] I've verified and I assure that I'm running youtube-dl 2017.07.02

Before submitting an issue make sure you have:

[x ] At least skimmed through README and most notably FAQ and BUGS sections
[x ] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2017.07.02
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
A couple of weeks ago the command -g would output one link that I would be able to play the video with, however now it outputs two links where one is solely audio and one is just the video without sound. Is it just me or have YouTube updated something in their system

NVM ffmpeg fucks with it for some reason

This is expected behavior.


Some missing AI journals

I'm pretty surprised to see that your list of Artificial intelligence journals omits the two main journals for AI:

Artificial Intelligence
https://www.journals.elsevier.com/artificial-intelligence
Journal of Artificial Intelligence Research
https://www.jair.org/index.php/jair

Here are a few others that might also be worth including. Although they aren't as good as the above two, they're comparable in stature to several of the other journals included in your metrics:

AI Magazine
http://www.aaai.org/Magazine/magazine.php
ACM Transactions on Intelligent Systems
https://tist.acm.org
Annals of Mathematics and Artificial Intelligence
https://www.springer.com/computer/ai/journal/10472

@dananau  Thank you for the suggestion. We have included these 5 journals in the new version.


Replacing public key address with registered user name

@ar
We would like to reference a registered industry user's name in the tracker details modal table instead of the public key address as on the following line.
Currently setting the trackee string by calling the CarbonTracker contract. Instead we should query the wallet table in the postgres database and get the name attribute.
This task is linked to a larger issue, that is populating the Tracker object type by querying the postgres database (not calling CarbonTracker contract). this will requires modifying the api-server so that tracker details sent to the contract are stored in postgres and then updating the fetchTracker details here

@arezd thanks for addressing the first part of the issue - querying the postgres wallet table to get user name.
I have made some modifications to your latest commit - e.g. creating a Wallet object for both the trackee and auditor when loading the partial for the tracker token. The branch is now stored on the upstream orin hyperledger-labs repo
I will start working on setting up the postgres database to store and retrieve all of the tracker data following the API Server query tutorial
.


Launch script for tmc-cli and autocompletion

Coverage remained the same at 72.195% when pulling a23d7c9c2a342a170f7fa6775edbc6a790515e0a on launch-script-aleksi into adc30332ee77deb035130175d87af123153c6d3d on master.

Don't merge this yet. I am adding some fixes to this still.

LGTM.

Coverage remained the same at 72.195% when pulling ec4e82f260118d1c7d3ef2638ef52487b2eeaa1b on launch-script-aleksi into adc30332ee77deb035130175d87af123153c6d3d on master.


lidar intensity

Hello.
I visualized lidar scan in rviz. But lidar intensity only changes with distance.
Also i saw the issue below.
Better LiDAR intensity measurements #3826

Is there any way to visualize like this?

Not at the moment since the picture you show is an implementation by somebody else not included in Carla.

Any updates on this?

Hi, I would like to know if any one have update on this.
I need intensity values to be based on material laser is striking than based on just distance.

Hi @Subhash-Bandi,
Check this https://github.com/carla-simulator/carla/issues/3826 as example to improve the intensity measurements of the LiDAR sensor.


Minor release 2.1

[2.1]
Added

Parsing of variantType, referenceCopyNumber, copyNumber and chromosomeCoordinates fields from CSV/TSV files
Genome assembly can be passed as an optional param to tsv_2_json and csv_to_json to create submission containing chromosome coordinates
Link to demo service instance at clinical genomics

Fixed

Parsing of multiple condition IDs from csv/tsv files

Review:

[x] Tests executed by CR

This version is a:

[ ] MAJOR - when you make incompatible API changes
[x] MINOR - when you add functionality in a backwards compatible manner
[ ] PATCH - when you make backwards compatible bug fixes or documentation/instructions

Deployed this branch on stage now:


Support API keys on basemap for Create and Save map

Description
Users should be able to use API Keys to access Basemaps to start with in an app and then continue to work with a named-user account. This PR updates the Create and Save map sample to show this workflow. @TADraeseke could you review please?

thanks @TADraeseke , I've updated that comment! @sclaridge could you take a second look please?

@TADraeseke @jenmerritt I have updated this PR to follow the slight change in scope we had originally for this sample. This PR now:

removes the Application Credentials workflow from Create and Save map (i.e. removes the option to add a client ID, url and redirect window), and the setting of the API Key. This sample will now authenticate basemaps via the ArcGIS Identity (named user login) following successful loading of the portal.
updates integrated windows authentication sample to authenticate and display a portal map via ArcGIS Identity, and removes setting of the API key from the sample. Setting the api key would trigger an additional authentication window to authenticate the basemap, but since we are displaying a portal map we don't need that initial basemap.

Please could you take a look? Thanks!


Performing a count on a PersistentCollection is clearing its collection property

Release version which introduced this issue
v.2.5.6
Issue Summary
Many to many relationship between entities retrieved from the DB are being cleared from memory when a count is performed on a PersistentCollection. This issue was introduced by the above release.
Replication Steps
Please find in the link below an example scenario affected by this issue.
https://gist.github.com/andrewjt71/711d737e03b23b9ad7cb638e0b88a4f2
NB. This issue only occurs when creating relations between entities which are fetched from the DB.

Here's the inlined code:
/**
 * User
 *
 * @ORM\Table(name="user")
 * @ORM\Entity
 */
class User
{
    /**
     * @var integer
     *
     * @ORM\Column(name="id", type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * Many Users have Many Groups.
     * @ORM\ManyToMany(targetEntity="Group", inversedBy="users")
     * @ORM\JoinTable(name="users_groups")
     */
    private $groups;

    /**
     * Constructor
     */
    public function __construct()
    {
        $this->groups = new ArrayCollection();
    }
}

/**
 * Group
 *
 * @ORM\Table(name="group")
 * @ORM\Entity
 */
class Group
{
    /**
     * @var integer
     *
     * @ORM\Column(name="id", type="integer")
     * @ORM\Id
     * @ORM\GeneratedValue(strategy="AUTO")
     */
    private $id;

    /**
     * Many Groups have Many Users.
     * @ORM\ManyToMany(targetEntity="User", mappedBy="groups")
     */
    private $users;

    /**
     * Constructor
     */
    public function __construct()
    {
        $this->users = new ArrayCollection();
    }

    /**
     * @param User $user
     */
    public function addUser(User $user)
    {
        $this->users[] = $user;
    }

    /**
     * @return ArrayCollection
     */
    public function getUsers()
    {
        return $this->users;
    }
}

// Create user.
$user = new User();

// Create Group.
$group = new Group();

// Persist user and group to the DB.
$this->getEntityManager()->persist($user);
$this->getEntityManager()->persist($group);
$this->getEntityManager()->flush();

// Fetch user from DB.
$user = $this->getEntityManager()->getRepository('User')->find(1);

// Fetch Group from DB.
$group = $this->getEntityManager()->getRepository('Group')->find(1);

// Add user to group.
$group->addUser($user);

// Flush changes.
$this->getEntityManager()->flush();

// Here the $users property on $group is a PersistentCollection with $user in it's collection.

$count = count($group->getUsers());

// Here the $users property on $group is a PersistentCollection with NO users in it's collection.
// The array collection has been cleared.
// $count is therefore 0.

This passes locally as per #6191 and https://github.com/doctrine/doctrine2/pull/6191/commits/43b6f5dbd16362aa91252af77e090e90077d60a4, therefore I'm closing this issue as invalid, sorry.
@andrewjt71 something else is going on in your scenario: please try reproducing it in more isolation.
Also: remember that you are responsible for setting the inverse and owning side of an association. Your example only updates the inverse side, which means that no DB-side records are created on the join table.


fix date exception on 'is_this_week' function

fixed an exception on fetching the next week events (TypeError: can't compare datetime.datetime to datetime.date)

Thanks! :)


side navigation state

Describe the bug
where? CDC Componenets lib 1.1
what > using the sticker sheet page, select side navigation, change state to open.
what is expcted > show the side nav
what happens
https://github.com/cloudscape-design/components/assets/222526/66c888f4-46b9-4f90-aa2e-f8e6d819d810
Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate requests

the correct way is to set it from the app layout and not directly in the Side navigation


Get rid off dependency constants in version.gradle.kts in favor of default values passed to Spine object

We need to employ Kotlin feature of default parameter values instead of using constants defined under version.gradle.kts.
The current arrangement for handling those constants is cumbersome. It works, but it requires too much code, and it's prone to errors in usage.
It's time to make it simpler and easier to use.

@armiol, @yevhenii-nadtochii, FYI.

Closing as outdated.


147 batch upload init

Ref #147
This solution uses an initial handshake with the backend to get a session ID then individually submits each image
The component tracks the success or failure of each file transfer and allows retrying the failed ones
Features

Progress bar
Success Indicator
Retry Failed transfers

I'm working on issue https://github.com/ai-cfia/nachet-datastore/issues/46 , where I'm adding the ability to name a picture_set, what about adding a folder_name field so the user can name the folder instead of having the uuid as the directory name?

I'm working on issue ai-cfia/nachet-datastore#46 , where I'm adding the ability to name a picture_set, what about adding a folder_name field so the user can name the folder instead of having the uuid as the directory name?

Probably need folders too, for the front end. Currently we have a directory component on the front end, right now it just pulls all the picture set uuid plus other stuff. To implement Folders we just need some tables
folders [ folder_uuid, folder_name ]
folderContents [ folder_uuid_fk, container/picture_set_uuid_fk ]
userFolders [ user_uuid_fk, folder_uuid_fk ]
picture_set name probably involves more work than just adding a text field. It probably needs to be an autocomplete dropdown that can show existing picture sets in case they want to add to existing ones. I would do it in a separate PR instead of this one

I'm wondering if we could also add a test to showcase this feature is working (Session are created & no errors triggered)

We need E2E tests to test interactions between layers using something like Puppeteer or Playwright


Added NatGatewayId prop to Route class; add NatGateway class for reso…

Ensured PEP8 compliance

Looks like a dupe of #394.

My apologies. Got ahead of myself.

Closing as dup of #394


Irene_Zhao_Dataset

Link: https://www.scmp.com/magazines/style/celebrity/article/3165835/who-irene-zhao-singapore-instagram-influencer-who-made

It highlights the story, beginnings, and fame of Irene Zhao.


HADOOP-15910 Fix Javadoc for LdapAuthenticationHandler#ENABLE_START_TLS

+1 from me.
Before I merge it, what name do you want to be credited by? Add it in the description field so when I press "merge" it will go in. Git will record you as the author, but with cherrypicking across branches, its easy for the original author to get lost

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
37
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1098
trunk passed

+1
compile
1054
trunk passed

+1
checkstyle
24
trunk passed

+1
mvnsite
44
trunk passed

+1
shadedclient
731
branch has no errors when building and testing our client artifacts.

+1
javadoc
23
trunk passed

0
spotbugs
40
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
39
trunk passed

_ Patch Compile Tests _

+1
mvninstall
23
the patch passed

+1
compile
996
the patch passed

+1
javac
996
the patch passed

+1
checkstyle
23
the patch passed

+1
mvnsite
33
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
632
patch has no errors when building and testing our client artifacts.

+1
javadoc
24
the patch passed

+1
findbugs
46
the patch passed

_ Other Tests _

+1
unit
185
hadoop-auth in the patch passed.

+1
asflicense
42
The patch does not generate ASF License warnings.

5159

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-440/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/440

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f32ab2372e10 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / cd967c7

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-440/1/testReport/

Max. process+thread count
446 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-440/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
41
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

-1
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1
mvninstall
1064
trunk passed

+1
compile
1065
trunk passed

+1
checkstyle
20
trunk passed

+1
mvnsite
31
trunk passed

+1
shadedclient
670
branch has no errors when building and testing our client artifacts.

+1
javadoc
26
trunk passed

0
spotbugs
42
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
39
trunk passed

_ Patch Compile Tests _

+1
mvninstall
19
the patch passed

+1
compile
967
the patch passed

+1
javac
967
the patch passed

+1
checkstyle
20
the patch passed

+1
mvnsite
32
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
609
patch has no errors when building and testing our client artifacts.

+1
javadoc
24
the patch passed

+1
findbugs
48
the patch passed

_ Other Tests _

+1
unit
190
hadoop-auth in the patch passed.

+1
asflicense
42
The patch does not generate ASF License warnings.

5020

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-440/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/440

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux f6d5f292effe 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c7c7a88

Default Java
1.8.0_212

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-440/2/testReport/

Max. process+thread count
444 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-auth U: hadoop-common-project/hadoop-auth

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-440/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

+1, merged to trunk.


Support connections from users behind symmetric NATs.

Enhancement request.

So I think what I'd like to eventually do is extend the node object:
message Node {
	required bytes guid            = 1;
	required bytes signedPublicKey = 2;

	required IPAddress nodeAddress = 3;
        optional IPAddress relayAddress = 4;

	optional bool vendor           = 5 [default = false];
}


InitializeFromStateForm example uncaught TypeError

I'm new to creating Issues on Github so bare with me.
I was trying out the 6.0.0-rc.1 and I found the InitializeFromStateForm example to return an error
Uncaught TypeError: Cannot read property 'data' of undefined
The code is exactly copied from the example so it's not that I have typed it wrong.
It seems to happen around
InitializeFromStateForm = connect(
  state => ({
    initialValues: state.account.data // pull initial values from account reducer
  }),
  { load: loadAccount }               // bind account loading action creator
)(InitializeFromStateForm)

where it can't seem to find state.account.data

account is where the Account reducer is mounted onto the redux state here.

The link returns 404


Access Violation Exception

Getting unknown access violation exception with sharpdx
SharpDX.Direct3D11.Device.CreateDepthStencilState(SharpDX.Direct3D11.DepthStencilStateDescription ByRef, SharpDX.Direct3D11.DepthStencilState)+6e

I had errors very similar to this recently.  After ripping my solution apart to no avail, it was resolved by running a repair on Visual Studio 2017.


Update to use ng-cli

To keep this project available for the community I decided to go trough with updating this project to use the CLI. This has the following consequences:

the example application needs to get updated to work with the cli
the following tasks need to be completed: https://github.com/samvloeberghs/protractor-gherkin-cucumberjs-angular/issues/55 https://github.com/samvloeberghs/protractor-gherkin-cucumberjs-angular/issues/48
the configuration to have it work with saucelabs and electron needs to keep on working

@DennisJaamann @Fiontan

@Fiontan I send you an invite to be collaborator of this project. If you want to collaborate, please accept.
Let's start from scratch and work in a branch update-cli.

@Fiontan @samvloeberghs  I believe it is the only sensible thing to do. I took the Angular 2 starter kit (with CLI) and just created a new branch to update. I have everything configured in there already, it just needs some clean up. I can share the branch later tonight if you want by pushing it to my fork remote. Let me know what you prefer

I prefer to start from https://github.com/angular/angular-cli#generating-and-serving-an-angular-project-via-a-development-server. Is that what you meant @DennisJaamann ?

@samvloeberghs @DennisJaamann that is exactly the route I went- it makes most sense to start from scratch with an ng new .... and then configure for use with the cucumber-specific libraries. It will change the structure somewhat to the original (Sam's) project, however, it is more aligned with the standard cli project and I think this is good for community accessibility/standardisation etc.

No, I actually started from here https://github.com/AngularClass/angular-starter
And behind the scenes it does what you are mentioning @samvloeberghs. The benefit with your approach is that you cut bloat (which might not be a giant issue since you can remove the bloat very easily).
The benefit with AngularClass is that everything is preconfigured and works out of the box. Furthermore you can easily keep this repo a community standard as well by forking / diffing with the AngularClass one.
In the end I think both options are very viable ones and it comes down to personal preference I guess. The most important thing imho is to follow a standard and stick by it, not reinvent the wheel as it will make the maintenance cost of this library higher than it should be.

if we can start from scratch, using the cli approach I would prefer that.. So let's go for ng new PROJECT-NAME

@samvloeberghs @DennisJaamann simply running the cli ng new will facilitate all this pre-configuration anyway...I have uploaded a fully functioning first attempt to a private bitbucket account @DennisJaamann can you provide an email please and I can give you access? It's locked with yarn too, so if you download and run the Yarn command from teh project root it all works automagically :)

Okay guys let's push forward then. Fiontan, I can work with you on the topic if you want to get this thing going rapidly. My bitbucket user name: DennisJaamann

@DennisJaamann you should receive a bitbucket invite anytime now. Might be worth getting it going locally and have a play around to see if you can identify any issues...enjoy and I've skyped you too :)

@Fiontan this looks great, should we proceed to add it to this github repo? Cheers

Hello all and apologies for the delayed response...I've been away. PLease feel free to branch it and work away.

I propose we make a legacy branch to keep the old code, then just copy your code to the master branch.
@samvloeberghs what do you think?

I prefer to keep the master as it is now, and when we're stable on the new stuff move it to there.

@samvloeberghs let me rephrase: After having a stable branch and when we are able to merge, do you still want to keep the legacy code? Of course I would not want to jeopardize the pristine and working master branch right now..

keeping the old stuff sounds good to me :)


ERROR: Do not know how to load path: html:~icons/mdi/delete

At Vite startup I am getting the above error on all icons in use, and consequently the Vite server wont start.
Strangely I had this same issue 2 days ago, but was in a hurry, so just repleced icons with simple text as a get around. When I put back the icons yesterday, it all worked as expected. This morning when I started VS Code, I got the error again.
Environment: Vue 3, Typescript on Windows
package.json.txt
vite.config.ts.txt
Any thoughts?

So I have just commented out all icons and replaced with text and all works fine. Then I reinstated the icons and all continues to work. I did a hard reset back to the commit point taken just before I closed down last night, and all still works. Very strange!!
I will leave the Issue open for now just in case anyone else is seeing this phenomenen.


docker pull ubuntu:latest adds only to docker overlay2 filesystem

Steps taken/Steps to reproduce
docker pull ubuntu:latest does not add to the pyrsia artifact file system.
root@pyrsia-node-1:/usr/local/bin# systemctl stop pyrsia
root@pyrsia-node-1:/usr/local/bin# systemctl start pyrsia
root@pyrsia-node-1:/usr/local/bin# systemctl status pyrsia
● pyrsia.service - Pyrsia Node
     Loaded: loaded (/lib/systemd/system/pyrsia.service; enabled; vendor preset: enabled)
     Active: active (running) since Mon 2022-03-14 19:06:22 UTC; 4s ago
   Main PID: 44052 (pyrsia_node)
      Tasks: 7 (limit: 1151)
     Memory: 2.7M
     CGroup: /system.slice/pyrsia.service
             └─44052 /usr/bin/pyrsia_node

Mar 14 19:06:22 pyrsia-node-1 pyrsia_node[44052]:  DEBUG netlink_proto::connection         > forwarding unsolicited messages to the connection handle
Mar 14 19:06:22 pyrsia-node-1 pyrsia_node[44052]:  DEBUG netlink_proto::connection         > forwaring responses to previous requests to the connection handle
Mar 14 19:06:22 pyrsia-node-1 pyrsia_node[44052]:  DEBUG netlink_proto::connection         > handling requests
Mar 14 19:06:22 pyrsia-node-1 pyrsia_node[44052]:  DEBUG netlink_proto::connection         > sending messages
Mar 14 19:06:22 pyrsia-node-1 pyrsia_node[44052]:  DEBUG netlink_proto::connection         > reading incoming messages
Mar 14 19:06:22 pyrsia-node-1 pyrsia_node[44052]:  DEBUG netlink_proto::codecs             > NetlinkCodec: decoding next message
Mar 14 19:06:22 pyrsia-node-1 pyrsia_node[44052]:  DEBUG netlink_proto::connection         > forwarding unsolicited messages to the connection handle
Mar 14 19:06:22 pyrsia-node-1 pyrsia_node[44052]:  DEBUG netlink_proto::connection         > forwaring responses to previous requests to the connection handle
Mar 14 19:06:22 pyrsia-node-1 pyrsia_node[44052]:  DEBUG netlink_proto::connection         > handling requests
Mar 14 19:06:22 pyrsia-node-1 pyrsia_node[44052]:  DEBUG netlink_proto::connection         > sending messages
root@pyrsia-node-1:/usr/local/bin# docker pull ubuntu:latest
latest: Pulling from library/ubuntu
7c3b88808835: Pull complete
Digest: sha256:8ae9bafbb64f63a50caab98fd3a5e37b3eb837a3e0780b78e5218e63193961f9
Status: Downloaded newer image for ubuntu:latest
docker.io/library/ubuntu:latest
root@pyrsia-node-1:/usr/local/bin# systemctl status pyrsia
● pyrsia.service - Pyrsia Node
     Loaded: loaded (/lib/systemd/system/pyrsia.service; enabled; vendor preset: enabled)
     Active: active (running) since Mon 2022-03-14 19:06:22 UTC; 27s ago
   Main PID: 44052 (pyrsia_node)
      Tasks: 7 (limit: 1151)
     Memory: 3.7M
     CGroup: /system.slice/pyrsia.service
             └─44052 /usr/bin/pyrsia_node

Mar 14 19:06:39 pyrsia-node-1 pyrsia_node[44052]:  DEBUG hyper::proto::h1::io                           > parsed 10 headers
Mar 14 19:06:39 pyrsia-node-1 pyrsia_node[44052]:  DEBUG hyper::proto::h1::conn                         > incoming body is empty
Mar 14 19:06:39 pyrsia-node-1 pyrsia_node[44052]:  DEBUG pyrsia::docker::v2::handlers::manifests        > Fetching manifest for ubuntu with tag: latest
Mar 14 19:06:39 pyrsia-node-1 pyrsia_node[44052]:  DEBUG pyrsia::docker::v2::handlers::manifests        > Getting manifest from artifact manager.
Mar 14 19:06:39 pyrsia-node-1 pyrsia_node[44052]:  INFO  pyrsia::artifacts_repository::artifact_manager > An artifact is being pulled from the artifact manager SHA512:3d4601357c75d7c5fc7ac9771d0b3e3022f06b2a0fb2c9>
Mar 14 19:06:39 pyrsia-node-1 pyrsia_node[44052]:  DEBUG pyrsia::artifacts_repository::artifact_manager > Pulling artifact from /mnt/disks/pyrsia-disk-1/artifacts/SHA512/3d4601357c75d7c5fc7ac9771d0b3e3022f06b2a0fb>
Mar 14 19:06:39 pyrsia-node-1 pyrsia_node[44052]:  DEBUG pyrsia::docker::error_util                     > Rejection: Rejection([MethodNotAllowed, RegistryError { code: ManifestUnknown }])
Mar 14 19:06:39 pyrsia-node-1 pyrsia_node[44052]:  DEBUG pyrsia::docker::error_util                     > ErrorMessage: ErrorMessage { code: ManifestUnknown, message: "" }
Mar 14 19:06:39 pyrsia-node-1 pyrsia_node[44052]:  INFO  pyrsia_registry                                > <IP_ADDRESS>:44578 "GET /v2/library/ubuntu/manifests/latest HTTP/1.1" 404 "-" "docker/20.10.7 go/go1.13.8 git->
Mar 14 19:06:39 pyrsia-node-1 pyrsia_node[44052]:  DEBUG hyper::proto::h1::io                           > flushed 167 bytes
root@pyrsia-node-1:/usr/local/bin# du -sh /usr/local/var/pyrsia
0	/usr/local/var/pyrsia

Another test looking at the bytes in the overlay2 vs pyrsia directories.
root@pyrsia-node-1:/usr/local/bin# du -sh /usr/local/var/pyrsia
0	/usr/local/var/pyrsia
root@pyrsia-node-1:/usr/local/bin# du -sh /var/lib/docker/overlay2
52K	/var/lib/docker/overlay2
root@pyrsia-node-1:/usr/local/bin# du -sh /usr/local/var/pyrsia
0	/usr/local/var/pyrsia
root@pyrsia-node-1:/usr/local/bin# docker pull ubuntu:latest
latest: Pulling from library/ubuntu
7c3b88808835: Pull complete
Digest: sha256:8ae9bafbb64f63a50caab98fd3a5e37b3eb837a3e0780b78e5218e63193961f9
Status: Downloaded newer image for ubuntu:latest
docker.io/library/ubuntu:latest
root@pyrsia-node-1:/usr/local/bin# du -sh /var/lib/docker/overlay2
78M	/var/lib/docker/overlay2
root@pyrsia-node-1:/usr/local/bin# du -sh /usr/local/var/pyrsia
0	/usr/local/var/pyrsia
root@pyrsia-node-1:/usr/local/bin# cat /etc/docker/daemon.json
{
	  "registry-mirrors": ["http://localhost:7888"]
}

Expected Behavior
Expect the layers to be added to the pyrsia artifact file system and not to docker's overlay2 file system.
Experienced Instance of the bug
20.04.3-Ubuntu
Latest version of pyrsia from the apt-get repo

Can be reproduced by
docker system prune and look at overlay2
pysia cli status and look at disk size

First, to get the confusion about docker overlay2 out of the way. The pyrsia node currently acts as a docker registry and is therefore able to provide docker images. When a docker client wants to pull an image from a pyrsia node registry, the pyrsia node will initially download the blobs from the official docker registry at docker.io and store it locally. On any subsequent pull, the pyrsia node will directly provide the blobs from the local directory. With the debian package, this directory is located at /usr/local/var/pyrsia.
The docker client, which is used when calling docker pull IMAGE, will pull the image from a docker registry. The pulled blobs will be stored locally in the overlay2 (on linux) directory. With the debian package, the default location for this directory is /var/lib/docker/overlay2. You can configure the docker daemon to load the docker images from a registry mirror. This is what has been configured on the pyrsia node, so that the docker client will try to pull from the configured registry mirror first.
Now, when a docker pull invocation, that is configured to pull from the pyrisa node registry, completes succesfully, the docker blobs will be stored both in the pyrsia directory and the overlay directory. It is perfectly normal for the docker images to be stored in the overlay2 directory, since that is where the docker client stores it.
The reason of the issue described here, is that the docker daemon is configured to have a registry mirror at localhost:7888. However, since the pyrsia node is not configured to run with the --host parameter, it will bind port 7888 on <IP_ADDRESS>. Now when the docker client pulls an image, it will first try to pull from localhost:7888, but that will fail. The docker client will then fallback to the official docker registry at docker.io. Hence, the blobs are only visible in the docker overlay2 directory and not the pyrsia directory. To verify that this is the case, you can check the journal logs of the docker service, which printed the following in my test case:
$ journalctl -u docker -f
...
Mar 24 13:52:05 pelle dockerd[113901]: time="2022-03-24T13:52:05.359010093+01:00" level=warning msg="Error getting v2 registry: Get \"http://localhost:7888/v2/\": dial tcp <IP_ADDRESS>:7888: connect: connection refused"
Mar 24 13:52:05 pelle dockerd[113901]: time="2022-03-24T13:52:05.359045229+01:00" level=info msg="Attempting next endpoint for pull after error: Get \"http://localhost:7888/v2/\": dial tcp <IP_ADDRESS>:7888: connect: connection refused"
...

A solution might be that we start the pyrsia node with the arguments --host <IP_ADDRESS>. This way it will bind to all known network interfaces and making a request to localhost:7888 should then succeed without issues.

@tiainen I added --host <IP_ADDRESS> and the images are being pulled as expected.  I can see in the logs that it checks pyrsia first and then goes off to docker if pyrsia does not have it.


Grabbed Objects collide with player collider when switched from hand to hand

To test load up 017 Camera  Rig Touchpadwalking. On the green box uncheck Hold Button to Grab, run the scene and grab the green box. Switch hands and bring it towards your body and it will fall to the floor. When the object doesn't have a rigidbody like in this example scene you can push yourself around with your held object (Very fast.)

fixed with https://github.com/thestonefox/VRTK/commit/7034181e4823145dde08d444eac948bf9a4e896c


Projects test coverage

Resolves #408

[x] View all, my, bookmark, projects involved page (use an account which has atleast one project in each tab)
[x]  Filter projects
[x]  Search projects
[x]  Clicking on project should open quick view
[x]  Create project from editor
[x]  Card and List view

@Megha-Dev-19 is this ready for review? What's left?

hey @elliotBraem, I have to rebase it and add tests for potlock import (need to change the config from testnet to mainnet)
will get it ready by tmrw most probably.

Ok cool, thanks for the update @Megha-Dev-19
-- maybe we can save potlock import tests for a separate ticket, since this will involve testnet -> mainnet, which I think will break some tests that are currently looking for testnet data (project card comes to mind)
I'll ask potlock team if they have a testnet deploy as well

that's great @elliotBraem, I will use testnet then.

Note: twitter test issue is fixed by #445, and others are flaky.


Adding CITE URN for new places

I am not sure if I understood adding new entries in the spreadsheet loci-id-novi correctly.
As we are referring the actual place name (e.g. Hungaria), the people (Hungari) and the adjective (Hungaricus) to the same place (in this case the Kingdom of Hungary), I am wondering is it necessary to add new entries for all three in the spreadsheet, as the columns label, uri and citebody will be the same. In other words, the LOCI CITE URN (the five-digit number) will always be the same, regardless of the lemma.
The same question goes for the lemma Pannonia, which is in this case also the reference to the Kingdom of Hungary (but there is also a Roman province of the same name with it's own urn), hence it will have the same urn as the above three. Or should it not?
Thank you for your answers!

At a meeting today, the team has concluded as follows:

in the loci-id-novi Google Spreadsheet we are identifying things (places in the world, or worlds), not words
the same thing can have multiple names
there is no need to note these multiple names in that spreadsheet (it has already been annotated in the lemmatization / morphology analysis phase)
for the loci-id-novi spreadsheet, in the first field we enter the most common Latin name (for example, Etruria for Tuscany, Hungaria for Hungary)

Many of problems that @zeljkasalopek has mentioned are corrected (the duplicate entries were removed) in commit 771dede0345b6ebaa0dba2e75bed67c0389390fc .
@arsimr16 has agreed to remove (and unify) his own duplicates, because he, contrary to @NinaCengic , did not use the same ID numbers for different entries.


VERSION missing in payload because undefined process.env.npm_package_version

On Lambda process.env.npm_package_version is not getting set and VERSION is not being set correctly.

Should be resolved by #88


Fix nonworking oc command

What this PR does / why we need it:
Fixes non-working oc command in integration tests.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

This change is

@slintes thank you for your help and clarification of how the TARGET is really used.
I did accidental commit I had to fix, so the test are run again. I would wait for them.
Otherwise, the #2505 is deprecated. I am closing it.
Again thanks for the help.

/lgtm
/approve


⚠ ClamAV has degraded performance

In d66e7a3, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 72 ms

Resolved: ClamAV performance has improved in a232a61.


Require Content-Type for /upload

Because this is what the error message from the server says if I omit Content-Type. There might be other endpoints with the same bug - feel free to indicate and I'll add them to the PR.

This kinda feels like a synapse bug and not a spec bug. Although good to provide, I can't really think of a reason why the media repo absolutely needs to know what you're uploading. If it wants to verify that you're only uploading images (for example), it shouldn't be relying on the user-supplied value anyways.

Well, given that the sending client by definition has a bit more information on the MIME type and that the parameter is there anyway, I believe the question of verification does not really stand. With that said, being able to rely on the server's guesswork would be handy for clients. Qt knows how to detect MIME types so I can deduce them from the content; so I as a QMatrixClient developer I don't have a strong opinion on this. But other clients might not necessarily have a MIME database at hand.

The mimetype is optional everywhere else in the spec. Although helpful to supply, the sending client shouldn't be required to send the type to the media repo.
My argument about server side validation is more about preventing users from uploading certain types of media. The server shouldn't trust that the client is sending the right mimetype and may have to figure out what the real mimetype is. The client -supplied value is really only a guideline for future downloaders, and the media repo can easily serve a generic non-descript file.

I don't see why there should be a requirement to know the MIME type by the server. In the case of encrypted messages all that information is within the ciphertext not know to the server or user anyway. This also limits meta-data exposure.

I've since been convinced that it should be required, although I didn't document it here (sorry). Asking for review from the rest of the team to spark conversation.

Should this be turned to a Synapse bug then?

@KitsuneRal I suspect this needs a bit more input from the spec core team. Possibly just writing a MSC to answer vdh's questions will be enough to make the spec and Synapse match once again.

Can I just turn this PR into an MSC or is it better to spawn a separate thing?

I wouldn't be bothered by it, though the changes to the spec can't be in the same PR as the MSC

Oh, right; a separate PR then.

https://github.com/matrix-org/matrix-doc/pull/2701 clarifies this

this seems to have been superceded by #2701.


[INTEL MKL] Upgrading RequantizePerChannel Op with API changes in MKLDNN 1.0

This PR ports RequantizePerChannel operator to MKLDNN 1.0

@mdfaijul do you want to add test cases around new changes ?

@penpornk Thanks! Have changed it. Please take a look.


FanGraphs Leaders pages

A parser for the FanGraphs Leaders pages are needed. The module should contain classes to scrape the individual players under the Leaders category.

Major League Leaderboards
Splits Leaderboards
Season Stat Grid
60-Game Span Leaderboards
KBO Leaderboards
WAR Leaders

Covered Major League Leaderboards with Pull Request #2

Covered Season Stat Grid with Pull Request #10

Covered Splits Leaderboards with Pull Request #13

Covered **60-Game Span Leaderboards with Pull Request #14

Covered WAR Leaders with Pull Request #15

Covered KBO Leaders with Pull Request #16


Screen sharing API doesn't work inside the desktop Teams tab app

Description
We develop a Teams tab app that points to a website. The website contains communication by a WebRTC library (that library allows send\receive video, audio, and screen sharing). All functionality works perfectly in the web version of the Teams. But in the desktop client screen sharing doesn't work (library throws an error "The browser doesn't support screen sharing").
Teams client
Desktop client.
This is a significant issue for us. Could you please confirm that screen sharing doesn't work in the current desktop Teams version? Or we can somehow resolve that? Thank you.

Hi @ydogandjiev/@lokimeyburg,
User develops a Teams tab app that points to a website, they have used custom library(WebRTC library), that library allows send\receive video, audio, and screen sharing. Its works perfectly in the web version of the Teams. But in the desktop client screen sharing doesn't work (library throws an error "The browser doesn't support screen sharing").
Could you please have a look on this.

Hi @adoronin,
Thanks for reaching us!
We took this as a high priority, checking internally with the engineering team and get back to you soon.

Hi @adoronin,
Could you please share us the document that you are referring about screen sharing in tab app for browser.

Hi @RamaMohanaChary,
Thank you for support!
I haven't found any documentation about screen sharing work in the Teams tab app. But I can give more details about the library which we using for that. We use the OpenTok library for WebRTC communication. OpenTok says that:

Publishing screen-sharing videos is supported in Chrome, Firefox, the OpenTok plugin for Internet Explorer, Opera, Chromium-based versions of Edge (versions 79+), and Safari 13+. It is currently not supported in mobile browsers, Safari 12 and older on macOS, or non-Chromium versions of Microsoft Edge (versions prior to 79)

Also, the documentation says about screen sharing support in Electron apps (I assume MS Teams desktop client based on Electron):

In Electron, screen sharing is supported if the webPreferences.contextIsolation option of the Electron BrowserWindow is set to false. (The default value of webPreferences.contextIsolation option is true in Electron 12 and false in previous versions).

The documentation link is:
https://static.opentok.com/developer/guides/screen-sharing/js/
Hope it will help for solving the issue. Could please look at that and share your thoughts? Also, we can directly ask the questions to OpenTok library developers if needed. Thank you.

Hi @adoronin  - We have added this to our backlog bug. We will inform you once it's resolved.

Hi @Mamatha-MSFT,
We're keeping our fingers crossed that the issue will be fixed soon. Thank you!

Hi, @Mamatha-MSFT. Do you have any updates?

@AlexeyLapushinsky - We will check on it with engineering team and get back to you.

@AlexeyLapushinsky - This feature is disabled by engineering team due to some other fixes.
We will let you know once it is available publicly again.

We got confirmation from engineering team that there is no secure way to expose screen sharing APIs in Electron. We currently have no plans to make this functionality work in the Teams Desktop Client.


Show BGCI Plant Threat Status

Show BGCI Plant Threat Status
For plants there now is a CBD approved threat search from Botanic Gardens Conservation International: http://bgci.org/threat_search.php?action=about
IUCN does not cover them all and it would be good to show the (global?) threat status if available. E.g. for Astragalus agnicidus Barneby IUCN and CITES dont have any entry, but BGCI has 3 theatened entries for that species: http://bgci.org/threat_search.php?action=Find&ftrFamily=&ftrGenus=Astragalus&ftrSpecies=agnicidus&ftrInfraSpecName=&ftrBGCI_Scope=&ftrAssessmentYear=&ftrThreatened=Threatened&x=59&y=9#results

fbitem-species5345561
Reported by: @mdoering
System: Chrome 56.0.2924 / Mac OS X 10.12.2
Referer: https://demo.gbif.org/species/5345561
Window size: width 1330 - height 815
API log
Site log

We may get this data directly from BGCI, if we don't already. (I must check my notes.)


[@lit-labs/router] Convert lit-labs/router to use Wireit

Converts the lit-labs/router package to Wireit.
Used https://github.com/lit/lit/pull/2823 as a reference.
TODO:

Understand if I need to update the "references": [{"path": "../../lit"}] in the tsconfig.

You should remove the references from tsconfig so that Wireit is in charge of build ordering.

Note: test failure on CI. Investigating. I'm speculating that I've messed up a wireit dependency.

Merged the recent fixes into this PR. It's now ready for review and passing locally for me.


Remove active_model_serializers

Is it really depends on active_model_serializers? Just deleted from gemspec and tests passes. Shouldn't we remove it?

It seems reasonable to remove active_model_serializers as a hard dependency of ember-rails, especially since ember-rails makes no use whatsoever of AMS.  Further, ember-rails has to have callouts in the README for how to work around changes to render(:json) introduced in Rails by AMS.
Odd to force people to use AMS when they could easily render their own JSON in many cases. And, over the past few years, other alternatives have appeared (rabl, for example).
At the end of the day, ember-rails doesn't actually use AMS, so it seems wrong to list is as a hard dependency in the gemspec.


docs(unstable): Update script documentation

See #12207 for what all is merged that this is trying to cover.

Looks good. Thanks!

@bors r+

:pushpin: Commit 004e6a172ef0a88255ba3952783f6e3c13df19c0 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 004e6a172ef0a88255ba3952783f6e3c13df19c0 with merge e95e2a97b966f967082172e8b9c9159900d731b7...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing e95e2a97b966f967082172e8b9c9159900d731b7 to master...


refactor(gh-lines): use on demand ephemeral context menus

Refactor the GH-lines to disable the auto-reply in favor of an ephemeral alternative.

Added a cache layer to handle spikes in usage

Based (copied most parts) from Souji's branch https://github.com/almostSouji/discord-toolkit-bot/tree/github-ephem

And i still dont understand how is it better than just going to github page

And i still dont understand how is it better than just going to github page

Clicking: Discord => github => wait github to load (Or open the browser) => goes back to discord
Bot: Discord => context menu
Not necessary but a nice optimization

And i still dont understand how is it better than just going to github page

Clicking: Discord => github => wait github to load (Or open the browser) => goes back to discord Bot: Discord => context menu
Not necessary but a nice optimization and its cool

Yup
but most of ppl even dont know that is even exits

But we, cool people, do!!

Idk, what you think @almostSouji ?
I like to have te option to do it in discord tbh

GH resolving was a fun idea for a thread use case but turned out to be an issue due to how threads are handled by discord. After some consideration, I really don't see much use in this being ephemeral, as the steps to get to the result are more elaborate than just clicking the link, which you might do anyways, eventually

It was good while it lasted, it will always be in our hearts 🫡


xSQLServerReplication: Should Be Cluster Aware

Details of the scenario you tried and the problem that is occurring:
When the xSQLServerReplication resource is applied to all of the nodes in a Failover Cluster Instance (FCI), all of the nodes will connect to the instance and ensure the desired state is true even if the node is not currently hosting the instance.
The DSC configuration that is using the resource (as detailed as possible):
When the following configuration is applied to two or more nodes in a FCI.
xSQLServerReplication distributor
{
    Ensure               = 'Present'
    InstanceName         = 'MSSQLSERVER'
    AdminLinkCredentials = $SysAdminAccount
    DistributorMode      = 'Local'
    WorkingDirectory     = 'C:\Temp'

    PsDscRunAsCredential = $SysAdminAccount
}

OR
xSQLServerReplication publisher
{
    Ensure               = 'Present'
    InstanceName         = 'PUBLISHER'
    AdminLinkCredentials = $SysAdminAccount
    DistributorMode      = 'Remote'
    RemoteDistributor    = 'distsqlsrv.company.local'
    WorkingDirectory     = 'C:\Temp'

    PsDscRunAsCredential = $SysAdminAccount
}

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
Any
What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
Any
Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Any

The resource should evaluate if the current node is actively hosting the SQL instance. If it is not hosting the instance, it should write a verbose message stating that it does not own the instance, and then silently exit.

To resolve this issue, a parameter called ProcessOnlyOnActiveNode should be created on the Set-TargetResource and Test-TargetResource functions.
The Get-TargetResource function will execute the helper function Test-ActiveNode to determine if the current node is actively hosting the SQL instance and return the result via the read-only property IsActiveNode.
The Test-TargetResource function will use the value of ProcessOnlyOnActiveNode and IsActiveNode to determine if it should continue. If ProcessOnlyOnActiveNode is $true and IsActiveNode is $false, Test-TargetResource will return $true.
I put together this gist as a guide to updating the resource.
Also, see the xSQLServerAlwaysOnAvailabilityGroup resource for a completed example.


Fix loop syntax

Without this fix, the message waiting for upcoming node is never displayed

@cscetbon thanks for your contribution, your fix is absolutely correct. It has been recently fixed by 175714c75ad25eeb29ac7da9fca4dbb88eade3db though, so I'm closing this pull request. Thanks again.

@adutra No problem. I just won't see my name in the commit log :smile: