Author graph improvements

The two per-author graphs now sort the stacks by author's final count, limit the legend to the top 25 authors, and place the legend outside the plot. These changes all make the plot nicer to read.

This fixes #14

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@794c4e6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   93.13%
=========================================
  Files             ?        7
  Lines             ?      539
  Branches          ?        0
=========================================
  Hits              ?      502
  Misses            ?       37
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794c4e6...861b1ed. Read the comment docs.


Duplicate instruction of generating certificates between CLI and GUI strongswan

The GUI strongswan instruction to generate certificates is simply duplicating the CLI instruction. Please provide the actual GUI instruction.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ff2a3f07-8dd7-a2f9-236d-4e6dc3c8bdec
Version Independent ID: b442cc75-f969-ca55-7416-b91d79c6e3a5
Content: Generate and export certificates for point-to-site: Linux - strongSwan - Azure VPN Gateway
Content Source: articles/vpn-gateway/vpn-gateway-certificates-point-to-site-linux.md
Service: vpn-gateway
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

@tulis - Thanks for noticing that! I've removed the duplicate information. That will publish this week. I've also made a note to see if we can create some GUI instructions as well (if applicable). Thanks again! #please-close


Use const instead of strings in Components

Added new class SignalWire\Relay\Calling\Method to not repeat the calling.X strings everywhere.
Within each component, replace method function with an instance attribute.

Merge master and add calling.disconnect


Validate dependencies in runtime

Closes #2720
Closes #2719
Introduced changes

Added requirements validation as a mandatory step before any snforge command. The output is only shown if validation fails
Added new subcommand snforge validate-requirements that always displays validation output.

Checklist

[x] Linked relevant issue
[x] Updated relevant documentation
[x] Added relevant tests
[x] Performed self-review of the code
[x] Added changes to CHANGELOG.md

Looks good, please address left comments.


BUG - accept null values in JSON

Are you a current Fivetran customer?
Yes -- Blue Bottle Coffee
Describe the bug
A database error occurs when there are null values in the JSON. Example JSON in the receipt column of stg_shopify__transaction below:
{
  "charges": {
    "data": [
      {
        "balance_transaction": {
          "exchange_rate": null
        }
      }
    ]
  }
}

Steps to reproduce
When running the shopify__transactions model, I see this error:
Database Error in model shopify__transactions (models/shopify__transactions.sql)
  Invalid input syntax for type numeric
  DETAIL:
    -----------------------------------------------
    error:  Invalid input syntax for type numeric
    code:      8001
    context:   value: ""
    query:     1559843
    location:  cg_util.cpp:621
    process:   query6_100_1559843 [pid=29142]
    -----------------------------------------------

Package Version

  - package: fivetran/shopify
    version: 0.4.1
    # documentation: https://github.com/fivetran/dbt_shopify

Warehouse

[ ] BigQuery
[x] Redshift
[ ] Snowflake
[ ] Postgres
[ ] Databricks
[ ] Other (provide details below)

Hi @oreoana Thanks so much for opening this ticket! After our call this afternoon I have a good idea of what we need to do to rectify this issue. I will start working on a branch to fix this bug and will let you know here once a fix is applied.

@oreoana I believe I found the solution to the bug mentioned. Essentially the cause is what we suspected. The previous logic was able to coalesce the field to null if the exchange_rate object did not exist. However redshift seems to see exchange_reate: null as both a null and not-null value.
Therefore, my solution was to leverage the nullif record at the json_extract macro to capture the null before it can be compiled within the query. I tested this on my Redshift and other databases and it worked with the intended results. Feel free to give the working branch another go on your side and let me know if it works or you experience any issues. You can use the below config in your packages.yml:
packages:
  - git: https://github.com/fivetran/dbt_shopify.git
    revision: bug/null-exchange-rate
    warn-unpinned: false

Let me know, thanks! 😄

@fivetran-joemarkiewicz just tried and it worked! Thank you 🙏

That's great to hear! I just merged and cut a new release for the shopify package v0.4.2. This should be live on the dbt hub later today.
Thank you again for opening this issue and please let me know if you have any further questions when using the package.


Bug in latest version

In the latest version, I ran into this: http://i.imgur.com/68XwRVt.png
It's not the first time I see someone with a single letter on your window, when there are in fact no one with just a single letter. This is the first time it caused to much trouble, though.

It seems to happen when there's a russian on the team.

Yup, seems to be a cyrillic problem :)

Yes this is a bug with battle tag extraction. See notes for release 0.4.4 for details.

For me it happens consistently in every single game.

it happens when nicknames contain non-latin letters (2+ byte unicode symbols). I'm not sure how to fix it for new file format.

Improved battle tag extraction. Will be released in v5.1. Closing this issue until we find any problems in 5.1


Adds new french translation

Coverage remained the same at 53.626% when pulling 2faa5997c022be248c2ab9118c4ef469b1d80bed on bragagia:master into 1fe3f335ed32a2d53a42bc62aaadc30505769f5d on codecombat:master.

Thank you for contributing, @bragagia!


.

It's don't work on my termux how can I do regester on Truecaller

see this https://github.com/sumithemmadi/truecallerjs#command-line-usage


Support GITEA_I_AM_BEING_UNSAFE_RUNNING_AS_ROOT env (#29788)

Backport #29788 by @wolfogre
I was trying to run unit tests for Gitea on act runner, by using make test.
It failed with log:
2024/03/14 03:09:26 ...s/setting/setting.go:180:loadRunModeFrom() [F] Gitea is not supposed to be run as root. Sorry. If you need to use privileged TCP ports please instead use setcap and the `cap_net_bind_service` permission

So it will be convenient to skip by setting environment, since it's OK to use root user in job containers.
It's not a bug, but I want to backport it to v1.21 since it doesn't break anything.

Lint is failing, backport may need adjustments.


Improve Navbar Design and Functionality

The current navbar lacks modern design and responsiveness. It should include the following enhancements:
Responsive Design: Navbar should adjust to mobile screens with a hamburger menu.
User Interaction: Highlight active links, improve hover effects, and include user-specific options (like login/logout, profile).
Branding: Include the website's logo in the navbar.
Dropdown Menus: If applicable, add dropdown menus for better navigation.
Labels: Enhancement, UI, Good First Issue, SWOC'25

Hi team,
I have contributed by enhancing the Navbar Design and Functionality for our project. This includes enhancements in visual design, user interface, and overall navigation experience to make it more intuitive and user-friendly.
Could you please give me permission to push my changes? I look forward to your feedback and any suggestions for further improvements.
Thanks!
Best, Yogyashri Patil

@Shashikumar-ezhilarasu and @YogyashriPatil I'm assigning both of you for this issue, thank you both for your contribution


Enhancements and Bug Fixes to FileSystemItemList

Some enhancements and bug fixes regarding the FileSystemItemList:

Breaking bug when deleting, after reordering
Serialization and Deserialization
Minor fixes

There are some problems with syntax (semi-colons). I think we can omit the passage of p_parent into the FileSystemItem constructor, and I need to look more closely at the save and load operations you implemented. I'll go ahead and merge this and then just do a bit of cleanup in a separate commit before finally squashing it all together and merging it into master.
Great work! Thanks!


Write test cases for the methods in that given language.

Write test cases by creating a test folder in that given language folder.
For ex- write test cases for python in python -> tests -> test_cases.py

Hey @extinctsion can you gave more information about the test cases. You need test cases of the given questions which were already present in the repo?

Test cases for the given methods in the repo.

I have two questions.
1.I want to know that do you want the test cases in the form of assert statements .
2.And should I include this inside the same file like we have the file GCD.cpp in CPP folder so should i make another folder for test cases and include the code and test cases inside it.

Make a different folder inside cpp if you are writing test cases for cpp. Write test cases using the standard naming conventions.
If you have any doubt, reply to this thread. Also, write a minimum of 100 tests per methods.
Use chatgpt for your assistance.

Yes, spereate test cases for each files.

you can write the test cases in the same file for each program.


Keyboard focus still switches to other views when disabled

I have 3 tabs and 3 of them has focusable elements.
When using TAB to alternate, they behave the same as being swiped.
Can this be disabled? I am not sure if that could be possible. Thanks anyhow!

We could add third argument to the onChangeIndex with some meta data, for instance, the reason behind the event. With that feature, you can filtre out TAB based events.


Implement abstract templates to call virtuals

This allows for, just as with regular classes, the calling of virtual methods of abstract templates returned by functions.

Already merged by accident but fixed beforehand.

Nice, thanks for this fix.


add support for passing in venv

This is a feature request to support passing in venv path manually like
:VenvSelect ./.venv
I have my poetry configured to create venv inside the project itself. But it creates .venv which venv-selector is not detecting. Instead of supporting detection of every virtualenv folders out there can we have a way to manually pass in a venv folder to select it.

Hi,
You can configure VenvSelector to look for .venv as a name. It can also look for many names at the same time.
And you can set the path option to look in a specific place all the time, and if you do, make sure to set parents to 0 also so it doesn't look in parent folders to that path.
But yes, could be an idea to let users set the path dynamically without using the config options. In some cases it could be nice.

Yes I agree too. This approach would be straight forward if we already know which venv to activate

Just came across this situation. I have a workspace where the virtual environment is installed in a non-standard directory name. Rather than adding that name to all the search paths, I'd like to just manually provide the path once and cache the virtual environment.

This is simple to do in the new version of the plugin I'm working on in the regexp branch. If you want you can check it out, and if you write a fd command to pick up the venvs, you can just put it in the plugin config. See the readme for an example how to add your own search.
It's still under heavy development but you can test it and give feedback. I expect the new version to be done in a few weeks.

I didnt go for this exact solution in the regexp branch, since the new VenvSelect will find any venvs in your current directory and below. You dont have to specify a name to search for - it will find all pythons and their full paths.
If you want to search outside of your current directory, you can easily add a search for that as well yourself.
And the new version also remembers what you have activated before for each directory. So if you have previously have selected a venv in VenvSelect, it will activate it automatically the next time you open a python file while being in the same directory.
So the end result is that for a given project under some path, your selected venv will be activated automatically and you dont have to think about it anymore.
If you want to try it out:
Configuration for lazy.nvim:
return {
  "linux-cultist/venv-selector.nvim",
    dependencies = {
      "neovim/nvim-lspconfig",
      "mfussenegger/nvim-dap", "mfussenegger/nvim-dap-python", --optional
      { "nvim-telescope/telescope.nvim", branch = "0.1.x", dependencies = { "nvim-lua/plenary.nvim" } },
    },
  lazy = false,
  branch = "regexp", -- This is the regexp branch, use this until its merged with the main branch later
  config = function()
      require("venv-selector").setup()
    end,
    keys = {
      { ",v", "<cmd>VenvSelect<cr>" },
    },
},

Make sure to read through the README for the regexp branch since it works in a very different way now, and old options no longer apply.


Merge doc makefiles into a Python script

In the doc/ directory we've got two different scripts, that were created by Sphinx, Makefile and make.bat. The reason why Sphinx does this is because a Makefile only works in unix system (Linux or Mac mainly), so a separate make.bat file to build the docs in windows is provided.
But instead of having two separate scripts, seems more efficient to have a single script in a language that works in any platform. Python looks like a good option for that. Can we replace those files by a Python file that builds the documentation and provides the same functionality?

I'll take this one

@Ayowolet  do you need help with this issue?

@sparalic no thank you... was distracted by the azure pipelines...

@datapythonista I'm struggling with this a little bit. Can I use the make.py file in the pandas repository as a guide?

Absolutely, we need something much simpler here, but everything we need should be in that file.
Feel free to open a PR that is not finished/not working, so people can have a look and help you.

Okay, thanks. I will do that.

I've taken too long on this.. @sparalic if you want to work on this, please feel free.. I've not been able to devote as much time as I ought to.. @datapythonista I apologise for spending too long

@Ayowolet sure I can help you with this one. @datapythonista do you want this copied over from the pandas repo, or should I use that as a working doc and retrofit it to our needs?

The pandas one is very complex. You can use it for inspiration, but I'd just create a very simple one with what the script are doing now, but in Python, so a single script work in any OS.


Fixed bug where author name could be null

Hey @adbar,
The fix for the bug reported in #226

Codecov Report

Merging #227 (b93238c) into master (e4e4406) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
- Coverage   95.47%   95.41%   -0.07%
==========================================
  Files          20       20
  Lines        3075     3075
==========================================
- Hits         2936     2934       -2
- Misses        139      141       +2

Impacted Files
Coverage Δ

trafilatura/json_metadata.py
93.04% <100.00%> (ø)

trafilatura/spider.py
91.85% <0.00%> (-0.75%)
:arrow_down:

trafilatura/utils.py
97.59% <0.00%> (-0.61%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us.

LGTM, thanks @felipehertzer!


Deprecate init_params which is no longer in AbstractMCMC

Maybe we shouldn't do this actually. We should probably just bump minor version and drop support for init_params completely, as we've done in other packages: https://github.com/TuringLang/AdvancedMH.jl/pull/92#event-10797486064


CORE-6420 extracting crypto api extensions

Moved DigestAlgorothm and DigestAlgorithmFactory to a new crypto-extensions API module
Removed BackoffStrategy from API

I could do that in Java but that should be concerted approach otherwise it'll look strange why only one module is in Java.


js-controller 3.3.x

anbei als Text:
fully-tablet-control.0 | 2021-04-30 10:30:31.213 | warn | (18430) State value to set for "fully-tablet-control.0.device.firehd7_flur_eg.device_info.displayWidthPixels" has wrong type "number" but has to be "string"
fully-tablet-control.0 | 2021-04-30 10:30:31.212 | warn | (18430) State value to set for "fully-tablet-control.0.device.firehd7_flur_eg.device_info.displayHeightPixels" has wrong type "number" but has to be "string"

Kann ich bestätigen und Close :)


Denoiser matrix fetcher

@AnastaZIuk I need the extra file modifications that mess with my envmap/pathtracer example 42 gone.

@AnastaZIuk also merge latest Criss branch into yourself

all good awaiting approval from @Crisspl


Create script that creates users with roles

Description
This is the user story to create a script that will create default users with their roles so that we can use them for testing.
Acceptance Criteria

Create following roles in the system: Користувач, Модератор, Адміністратор

Create script that will create a user :
a. 1 user - has role Administrator

Script has following parameters:
a. facebook email address
b. role that has Administrator by default, but Moderator or Користувач can be specified too

It is possible to login with these users to the system

User is present in db with role Адміністратор

Epic link
E.g.: Epic #66

for any new users by default "Користувач" role will be asign

Estimate: 3 hours

Done: 3 hours


feat(cocoapods): cocoapods 1.12.0 compatibility

Fixes https://github.com/doublesymmetry/cocoapods-patch/issues/25.
The function signature for clean_pod, https://github.com/CocoaPods/CocoaPods/blob/df6cd9e0c51c54490be617a655fca80817c8b9b1/lib/cocoapods/sandbox.rb#L93, has changed to require the pod directory which has been abstracted from the clean_pod function to pod_dir https://github.com/CocoaPods/CocoaPods/blob/df6cd9e0c51c54490be617a655fca80817c8b9b1/lib/cocoapods/sandbox.rb#L182, which we can use instead.

Would love to see this released!

I would love to see this merged in as well!
@crherman7 Thank you for this PR, I was able to add your fork/branch to my Gemfile like so:
gem 'cocoapods-patch', git: 'https://github.com/crherman7/cocoapods-patch.git', branch: 'feat/cocoapods_1.12.0'

..but I'm still running into this error when trying to pod install:
Error loading plugin file `/Users/x/.gem/gems/cocoapods-patch-1.0.2/lib/cocoapods_plugin.rb`.

Gem::ConflictError - Unable to activate cocoapods-patch-1.0.2, because cocoapods-1.12.0 conflicts with cocoapods (~> 1.11.0)

Do you know why that's happening? Thanks!

I would love to see this merged in as well!
@crherman7 Thank you for this PR, I was able to add your fork/branch to my Gemfile like so:

gem 'cocoapods-patch', git: 'https://github.com/crherman7/cocoapods-patch.git', branch: 'feat/cocoapods_1.12.0'

..but I'm still running into this error when trying to pod install:

Error loading plugin file `/Users/x/.gem/gems/cocoapods-patch-1.0.2/lib/cocoapods_plugin.rb`.

Gem::ConflictError - Unable to activate cocoapods-patch-1.0.2, because cocoapods-1.12.0 conflicts with cocoapods (~> 1.11.0)

Do you know why that's happening? Thanks!

Based on the error message it looks like it's still trying to use cocoapods-patch 1.0.2. Can you list out your gems and ensure 1.0.2 is uninstalled and 1.0.3 is installed.
Otherwise I can take a deeper look tomorrow!

Based on the error message it looks like it's still trying to use cocoapods-patch 1.0.2. Can you list out your gems and ensure 1.0.2 is uninstalled and 1.0.3 is installed.

Thanks for the response! After running bundle install to list the gems, it did show cocoapods-patch 1.0.2, so I commented out Gemfile, ran bundle clean to clear out the gems, restored Gemfile, and ran bundle install again. Unfortunately, it's still showing that same error. When I run gem query --local, I see this:
...
cocoapods (1.12.0, 1.11.3, 1.10.2)
cocoapods-core (1.12.0, 1.11.3, 1.10.2)
cocoapods-deintegrate (1.0.5)
cocoapods-downloader (1.6.3, 1.6.1)
cocoapods-patch (1.0.2)
cocoapods-plugins (1.0.0)
cocoapods-search (1.0.1)
cocoapods-trunk (1.6.0)
...

@jeffmon any chance you have mixed installs i.e. one with brew and one with gem?

any chance you have mixed installs i.e. one with brew and one with gem? I know you used bundle - just trying to think of any other edge cases.

Thanks for the suggestion, after checking the brew list, that doesn't seem to be the case. Thanks again for your help! I'll eventually figure this out, and comment on my solution if I get there.

@jeffmon absolutely - I want to get this released, so making sure this works for all is important!
Can you try one last thing.....instead of using gemfile can you just locally bundle the gem and install it and see if it works? I want to narrow everything out.

Is this project still being maintained?  Curious if anyone has heard from any of the owners on the chance to get this fix released?  Needing to make decision if we quit using it or not here real soon.

MERGEEEE

just leaving this here, specific_install command:
gem specific_install 'https://github.com/crherman7/cocoapods-patch.git' -b 'feat/cocoapods_1.12.0'

Hi @dcvz any update on this? this would be super valuable for some upgrades we're working on at the moment.


release: tracker for 1.28.0

This is the umbella tracker for 1.28.0.
Milestone: https://github.com/rkt/rkt/milestone/62
Estimated date: 2017-07-18
Pilot: @fabiokung  (+@lucab for review/signing)

@lucab I think we talked about postponing this a bit. One or two weeks? What are you thinking?

Yes, semaphore was broken and there were a few PRs piling up. Things should be better now and I think the only main remaining thing is your https://github.com/rkt/rkt/pull/3713. Once landed, we can cut 1.28.0.
We can do it either later this week or next week, feel free to suggest a date which works for you.

Apologies for the radio silence! How about on Thursday, 2017-07-27?

Fine! I've updated the milestone date to the 27th.


Proposes the DIDComm RPC Protocol for App Attestation and more

The DIDComm Remote Procedure Call (DRPC) protocol enables a JSON-RPC-based request-response interaction to be carried out across a DIDComm channel. The protocol is designed to enable custom interactions between connected agents, and to allow for the rapid prototyping of experimental DIDComm protocols. An agent sends a DIDComm message to request a remote service be invoked by another agent, and gets back a response in subsequent DIDComm message. The protocol enables any request to be conveyed that the other agent understands. Out of scope of this protocol is how the requesting agent discovers the services available from the responding agent, and how the two agents know the semantics of the JSON-RPC requests and responses. By using DIDComm between the requesting and responding
agents, the security and privacy benefits of DIDComm are accomplished, and the generic parameters of the messages allow for flexibility in how and where the protocol can be used.
The initial proposed use of this protocol is for App Attestation.

This comment is specific to the use case of app attestation and not the actual protocol. There are some emerging OpenID (driven by EUDI and the EU ARF) standards in this space that might be useful to review. The standard includes both the issuance of attestation credentials and a device binding (authentication) for high assurance use cases:

Italian EUDI wallet design: https://italia.github.io/eudi-wallet-it-docs/versione-corrente/en/wallet-instance-attestation.html
Draft IETF standard as part of OAUTH 2.0: https://www.ietf.org/archive/id/draft-looker-oauth-attestation-based-client-auth-00.html

Suggestions from the discussion at the Aries Working Group call 20231216:

A number of people thought that we should do an App Attestation protocol vs. using the generic DRPC. Not against DRPC, but that app attestatation is important enough to warrent a protocol.

Related to that is looking at the App Attestation HTTP interface that OpenID has defined in @tbloomfi ’s comment above.

Several people thought that we should look at gRPC and JSON-RPC to see if we can apply anything from there.
Some (such as @TimoGlastra in his comments above) liked the idea of using Attachments vs. the current header-has-MIME-type and body.base64, since attachments give the implementers flexibilty in formatting the data.
Also the request above to drop header altogether and having any user of the protocol put whatever extra info (headers, etc.) into the body (or attachment if we go that way).

We’ll consider the suggestions to this protocol and provide an update with discussion of the changes.
As to the App Attestation protocol — we’ll look at that, but would like more community feedback on the current implementation (based on basic-message — and even less suitable protocol) and experience in using it.
Thanks for the feedback!

WG 20240124 implementation under way in ACA-Py.


Make og:type configurable for .IsPage

See https://support.google.com/news/publisher-center/thread/123693300?hl=en&msgid=123694514
This can be set in the config, preferably via params.
https://github.com/gohugoio/hugo/blob/master/tpl/tplimpl/embedded/templates/opengraph.html#L3

This should be handled by site and theme authors by overriding the embedded template to use something under .Site.Params.

I rolled my own using a WP plugin meta.


Running on Linux

Thank you so much for such an excellent sample.
Any chance you have a Linux version?
I see the Linux LoadLibrary version but after making HCNetSDK.NET_DVR_Login_V30 call it crashes in case of the successful login with the error:
Bus error (core dumped)

Any hint or suggestion?

Have a look here...
https://github.com/laszlojakab/hikvision-intercom-python-demo/issues/2

If only everything was as easy in life :)
Thank you for pointing me in the right direction. Removing device_info did the trick.

Perfect. :-)


Fix configuring assets and buying them.

Update the endpoints as the old ones are deleted. Fixed with Standard JS.

Looks good. Thanks!

Noblox.js is participating in Hacktoberfest. Join it and this PR will count towards your free T-shirt!


Xamarin Universal Library - One Place for all xamarin great resources

We are trying to bring you all together so the community has only one place for all xamarin great resources. So, we are reaching out to see how it can all be pulled together as there is some overlap.
Repository: https://github.com/xamarinuniverse/XamarinUniversalLibrary

Yes, we can do that. But that not the purpose. We want all of you there


Fix typo on package name

Hi @miiitch, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

thanks!


Python Social Auth Core package.

I am not sure how dependancies of each wheel are managed, but this library has the following dependencies:
python-openid>=2.2.5
pyjwkest>=1.0.1
requests>=2.9.1
oauthlib>=1.0.3
requests-oauthlib>=0.6.1
six>=1.10.0
PyJWT>=1.4.0
cryptography>=2.1.1

this error is in the console:
  File "/opt/_internal/cpython-3.6.0/lib/python3.6/site-packages/auditwheel/wheeltools.py", line 191, in add_platforms
    raise WheelToolsError('Cannot add platforms to pure wheel')
auditwheel.wheeltools.WheelToolsError: Cannot add platforms to pure wheel
social_auth_core-1.5.0-cp27-cp27m-manylinux1_x86_64.whl missing, build failed?
social_auth_core-1.5.0-cp27-cp27mu-manylinux1_x86_64.whl missing, build failed?
Exiting due to missing wheels

it seems we have a bug there somewhere since we are triggering https://github.com/pypa/auditwheel/blob/master/auditwheel/wheeltools.py#L190

Thanks for checking this @martenson ; any suggestion ?

@VJalili Sadly no, I do not know much about this infrastructure, but I believe @natefoo will be able to fix it once he gets back - that might be after holidays though.

Thanks @martenson and @dannon


Using meta-data instead of BuildConfig

So using it is simple. The app which uses the lib adds the three meta-data tags to it's manifest file as follows:
 <application>
...
    <meta-data
        android:name="com.alorma.github.sdk.client"
        android:value="YOUR_CLIENT_ID_HERE"/>

    <meta-data
        android:name="com.alorma.github.sdk.secret"
        android:value="YOUR_SECRET_HERE"/>

    <meta-data
        android:name="com.alorma.github.sdk.oauth"
        android:value="YOUR_URL_HERE"/>
...
</application>

So the app can now be compile to .aar and use by anyone!
(PS We should either replace the BaseSdk thing i added or update BaseSdk to support JitPack)

The value of metadata can be any @string?

Think so

Any thoughts on this?


bump dependencies

Applied mkpr on package.json
/tmp/mkpr.sh

:tada: This PR is included in version 5.0.117 :tada:
The release is available on:

npm package (@latest dist-tag)
v5.0.117
GitHub release

Your semantic-release bot :package::rocket:


Deprecate (and eventually remove) PathBuf::as_path and PathBuf::into_os_string

PathBuf::as_path(), with the auto-deref is completely unnecessary, and PathBuf::into_os_string() is redundant, because we already have impl Into<OsString> for PathBuf

Was pointed to https://github.com/rust-lang/rust/pull/25833#issuecomment-106033786 as a relevant comment on this.

Let me link to PR #1147 which deals with API deprecation.


fixing typo, .one('mount' -> .on('mount'

I might be wrong, but I think .one should be .on here.

my bad, it seems .one is actually the correct method here.


[WIP] Do not display the Survey Title if no Survey exists in teh Configuration Script

Purpose or Intent
Do not display the Survey Title if no Survey exists in teh Configuration Script
Links
https://bugzilla.redhat.com/show_bug.cgi?id=1350344
Steps for Testing/QA
Ansible Tower Configuration scripts with and without survey specs

@miq-bot add_label wip, ui, bug

@miq_bot remove_label wip
@dclarizio - please review

@miq-bot remove_label wip

@h-kataria Can you verify this is the correct place to check for the existence of items to display?  Feel free to merge if all is well.  Thx, Dan

LGTM


Title propagation issues (empty app title, title doesn't update when unfocused, etc.)

Environment
Windows build number: Microsoft Windows [Version 10.0.19042.685]
Windows Terminal version (if applicable): latest on main branch but it also happens
on the preview version from the store

Steps to reproduce
Open Windows terminal and Alt+Tab.
Expected behavior
Shows Application title.
Actual behavior
App title is empty.
Context
These are my settings: https://gist.github.com/giggio/d4cf676d93b89a2f78cb7f25c01fdcda
You can see that there is no title in Alt+Tab:

It is also empty on the task bar:

And when using Win+Tab:

I'd like it to simply read "Windows Terminal", always.

Hmm. I'd bet that somewhere along the line, we made it so "showTerminalTitleInTitlebar": false would propagate a Windows Terminal to the actual window title. Whoops!

Hmm. I'd bet that somewhere along the line, we made it so "showTerminalTitleInTitlebar": false would propagate a Windows Terminal to the actual window title. Whoops!

When you first open it, it is empty. After you create another tab, it is still empty. After you switch between the second tab and the first, then the tab title shows up as the app title:

The same thing shows on the taskbar.
Still, I'd like it to just read "Windows Terminal".

When you first open it, it is empty. After you create another tab, it is still empty. After you switch between the second tab and the first, then the tab title shows up as the app title:

The same thing shows on the taskbar.
Still, I'd like it to just read "Windows Terminal".

From #9007

Environment
Windows build number: Version 10.0.19042.746
Windows Terminal version (if applicable):   Windows Terminal Preview Version: 1.6.10272.0

Steps to reproduce
can be reproduced in both wsl or in powershell.

run this and then switch to another applicationsleep 5; cd .\Documents\

after 5 secs, tab title will be updated, but title in taskbar won't.

Expected behavior
title in taskbar updates properly even when terminal is not in focus.
Here's two screenshot:

Actual behavior
title in taskbar stays old value when terrminal is not in focus.

Can you point to where ESC]0 (and 1,2) is being handled in the codebase?

@sarim Sure!

At the lower levels it's handled by Terminal::SetWindowTitle
That bubbles to TermControl::_TerminalTitleChanged
That bubbles to an event handlers in TerminalTab::_AttachEventHandlersToControl (in the lambda passed to control.TitleChanged)
That handler calls TerminalTab::UpdateTitle
That method also raises a PropertyChanged event for the Title property of the tab, which is handled in event handler in TerminalPage::_RegisterTerminalEvents
That calls TerminalPage::_UpdateTitle
That raises an event handled in AppHost::AppTitleChanged

I think that's it?

Thanks a lot. I think you already did most of the work listing all those methods. I just managed to set up vs and terminal. I think I found the problem too. Code is checking tab.FocusState() != FocusState::Unfocused , but when the whole terminal window is not in focus, the active tab is also in Unfocused state.
I'll investigate further and see If I can come up with a solution.

Oh good catch! Thanks for looking into this!

So I solved the issues.
first issue: empty title
There were a missing _settings.GlobalSettings().ShowTitleInTitlebar() check. Because of this Title update event was being fired even when showTerminalTitleInTitlebar is false.
This explains this behavior

After you switch between the second tab and the first, then the tab title shows up as the app title

I fixed this in https://github.com/sarim/terminal/commit/fece4c9919cbf020f0c8121a2499c232f18ff761
Now showTerminalTitleInTitlebar is false:

Window title is correctly shown as "Windows Terminal", not empty.
After switching between tabs, Tab title doesn't propagate to window title.

Second issue: title doesn't propagate when unfocused
Reason explained above, I fixed it in https://github.com/sarim/terminal/commit/b0fb2c77d255c0211d811aeb4d26740dfc592fb5
https://github.com/sarim/terminal/tree/sarim/title-propagation
@zadjii-msft please check if the code is acceptable. should I send a PR?

@sarim - Not an expert, but I believe you definitely need to issue a PR - IMHO the solution looks good. :blush: I left a comment for some improvements to consider.

Awesome, I just built it from main it is working perfectly. Tks! :shipit:


[PROPOSAL] Add a checkbox in each plugin's PR templates to update API specs

What/Why
What are you proposing?
The same as https://github.com/opensearch-project/OpenSearch/pull/13621 in each plugin.
What users have asked for this feature?
All users of OpenSearch that use language clients.
What problems are you trying to solve?
From https://github.com/opensearch-project/OpenSearch/issues/13619
With the introduction of OpenSearch API Specification for generating client libraries and documentation in multiple languages, it is possible that new features might miss out on defining the APIs, leading in gaps in what the generated clients for exotic languages can support.
What is the developer experience going to be?
Create companion PRs for every API change with an OpenAPI spec and a test.
Dependent PRs

[x] https://github.com/opensearch-project/common-utils/pull/696
[x] https://github.com/opensearch-project/alerting/pull/1596
[x] https://github.com/opensearch-project/anomaly-detection/pull/1262
[x] https://github.com/opensearch-project/asynchronous-search/pull/591
[x] https://github.com/opensearch-project/cross-cluster-replication/pull/1407
[x] https://github.com/opensearch-project/custom-codecs/pull/162
[x] https://github.com/opensearch-project/flow-framework/pull/773
[x] https://github.com/opensearch-project/geospatial/pull/666
[x] https://github.com/opensearch-project/index-management/pull/1202
[x] https://github.com/opensearch-project/job-scheduler/pull/649
[x] https://github.com/opensearch-project/k-NN/pull/1801
[x] https://github.com/opensearch-project/ml-commons/pull/2620
[x] https://github.com/opensearch-project/neural-search/pull/823
[x] https://github.com/opensearch-project/notifications/pull/932
[x] https://github.com/opensearch-project/observability/pull/1841
[x] https://github.com/opensearch-project/opensearch-oci-object-storage/pull/61
[x] https://github.com/opensearch-project/reporting/pull/1012
[x] https://github.com/opensearch-project/performance-analyzer/pull/679
[x] https://github.com/opensearch-project/security-analytics/pull/1150
[x] https://github.com/opensearch-project/security/pull/4533
[x] https://github.com/opensearch-project/skills/pull/346
[x] https://github.com/opensearch-project/sql/pull/2808

This is done! cc: @vamshin


Add option to see which jobs did not terminate normally

This could be added in general or to a specific mode.

Do that for the filter mode

Just use grep for that:
grep -Rl "Abnormal termination" logs_dir


Add endpoint to decode invoice

As a user I would like to see the amount etc. of a LN invoice before paying it.
Thus I would like to have an REST endpoint (no SSE event needed) to decode the LN invoice and show me the relevant information.

Its in. I've decided to use the LND terminology of decoding a "payment request".


Some error when training model

Traceback (most recent call last):
File "main.py", line 335, in
app.run(main)
File "C:\ProgramData\Anaconda3\lib\site-packages\absl\app.py", line 274, in run
_run_main(main, args)
File "C:\ProgramData\Anaconda3\lib\site-packages\absl\app.py", line 238, in _run_main
sys.exit(main(argv))
File "main.py", line 317, in main
train_entry(config)
File "main.py", line 289, in train_entry
train(model, optimizer, scheduler, train_dataset, dev_dataset, dev_eval_file, iter)
File "main.py", line 147, in train
for i, (Cwid, Ccid, Qwid, Qcid, y1, y2, ids) in tqdm(enumerate(dataset),ncols=50):
File "C:\ProgramData\Anaconda3\lib\site-packages\torch\utils\data\dataloader.py", line 451, in iter
return _DataLoaderIter(self)
File "C:\ProgramData\Anaconda3\lib\site-packages\torch\utils\data\dataloader.py", line 239, in init
w.start()
File "C:\ProgramData\Anaconda3\lib\multiprocessing\process.py", line 105, in start
self._popen = self._Popen(self)
File "C:\ProgramData\Anaconda3\lib\multiprocessing\context.py", line 223, in _Popen
return _default_context.get_context().Process._Popen(process_obj)
File "C:\ProgramData\Anaconda3\lib\multiprocessing\context.py", line 322, in _Popen
return Popen(process_obj)
File "C:\ProgramData\Anaconda3\lib\multiprocessing\popen_spawn_win32.py", line 65, in init
reduction.dump(process_obj, to_child)
File "C:\ProgramData\Anaconda3\lib\multiprocessing\reduction.py", line 60, in dump
ForkingPickler(file, protocol).dump(obj)
BrokenPipeError: [Errno 32] Broken pipe
This seems occur when train epoch 1.
I could not find the reason，hope could help！

By the way， I denote some part about tensorbord(writer)

https://github.com/pytorch/pytorch/issues/2341
You could take a look at this thread. Set dataloader number of workers to 0 to see the actual bug.

@wlhgtc I face the same problem with Ubuntu but no Windows system.  I fix it by add up the Swap from 1G to 10G


Bullets in lists not aligned properly

I get these (non properly aligned) bullets, in Android:

when using a list:
- Wi-Fi or Cable Fast Internet in the room\*
- PC Room rentals available\*
- 24 hour Reception
- 24 hour Security Patrols
- 24 hour Currency exchange
- Free shuttle service to Bufos beach 900m (3 times daily)
- Laundry service\*

@CharlesMangwa Any idea how this could be fixed? Thanks a lot!

+1

Hi @afilp @mrpatiwi! Sorry for the late reply! You can set your own rules to customize this as you wish into <Markdown />'s style prop:
  listItemBullet: {
    fontSize: 3,
    lineHeight: 2,
    marginTop: 1,
    anyOtherStyleProperty: 0,
  },

@CharlesMangwa Thanks Charles,
This would require to know the font size of the Text after the bullet and if this changes the bullet lineHeight should also change, etc.
Wouldn't it be more appropriate to have a FLEX view around the two TEXT components, with flexDirection: 'row' and alignItems: 'center'?
Something along these lines.
This should be done inside the library however, as this code could be added by the end user.
What do you think?

@CharlesMangwa
Would my proposition above be viable?
(not sure if the internals of the library allow this)
Thanks again!

Hi @afilp @af-inf! This could totally be viable, just need to implement it! I'm not satisfy with the actual API anymore. As you can see, each parsed element can just render a Text, or a View component. The idea with the next API is to be able to render nested component and customize them as you like. For instance: parse a specific text and render bullets points as Touchable's. I just don't had enough time lately to work on it and implement all these features :/

Fixed in https://github.com/CharlesMangwa/react-native-simple-markdown/commit/3b4147bd8729bb4875f0a2dbf2757e493d227cab


docs: fix typo in example

The example used github/actions-permissions/monitor action which does not exist so I've changed it to GitHubSecurityLab/actions-permissions/monitor.

Thanks!


Support document built-in functions in the Document API V2

This issue groups all work needed for supporting the built-in functions against the documents. Currently there are two functions:

Push array
Pop array

The issue should refactor the way how the built in functions are modeled, allowing easier addition of new built-in functions in the future. The implementation should cover existence of the service for the function execution as well as the resource for exposing functionality over the HTTP.

Done in #1964.


[Question] Playwright Java Page Object Model with Automatic Authentication Framework example

I am trying to setup new framework using Playwright Java Page Object Model with Automatic Authentication Framework. Also i am planning to use Spring as much as possible.
I can't find any example anywhere, so if anyone knows of any example repos or websites, please let me know.
Any info is highly appreciated !
Cheers

There is a doc explaining how POMs can be implemented based on Playwright. We don't provide framework-specific guides, is there anything specific that doesn't work for you?

Thanks for your response @yury-s I am looking to implement Automatic Authentication in my framework.
The steps performed are:

Playwright, Browser, BrowserContext and Page are instantiated using Spring Beans and the url is loaded
@BeforeAll method performs the sign in, stores the login state in a json file, signs out from the application, closes the page and browserContext.
@BeforeEach method loads the logins state, however i can see 2 browsers launched 1 from @Bean and other from login state using the storageState. So i have to check which page is active and close the other so the browser also closes and continue with test.
So i am looking for a solution to launch the page from @Bean when the @Test methods are executed.

Following is my code:
`@Bean(destroyMethod="", name="browser")
@DependsOn("playwright")
public Browser browser() {
BrowserType.LaunchOptions launchOptions = new BrowserType.LaunchOptions()
.setChannel(browserName)
.setHeadless(shouldRunHeadless)
.setSlowMo(100);
    Playwright playwright = playwright();
    BrowserType browserType;
    switch (browserName) {
        case "chrome":
        case "msedge":
            browserType = playwright.chromium();
            break;
        case "firefox":
            browserType = playwright.firefox();
            break;
        case "safari":
            browserType = playwright.webkit();
            break;
        default:
            throw new IllegalArgumentException("Incorrect browser name.");
    }
    return browserType.launch(launchOptions);
}

@Bean(destroyMethod="")
@DependsOn({"browser", "desktopContext", "newPage"})
public Page page() {
    Page page;
    if (screenType.equals(DESKTOP)) {
        page = newPage(newDesktopBrowserContext(browser()));
        navigate(Map.of(), page);
    } else {
        page = newPage(newMobileBrowserContext(browser()));
        navigate(Map.of("mobile", "true"), page);
    }
    return page;
}

`
@BeforeAll     private void signIn() {         signInPage.UserName.setText(username);         signInPage.Password.setText(password);         signInPage.SignIn.click();         automaticAuthentication.setLoginState();         assertThat(landingPage.signOut.isVisible(), is(true));         signOut();         closePage();         closeBrowserContext();     }
@BeforeEach     private void setLogin() {         newPage = automaticAuthentication.automaticLogin();     }
public Page automaticLogin() {         if (!page.isClosed()) {             page.close();         }         newPage = getLoginState().newPage();         newPage.navigate(baseUrl);         return newPage;     }

Does automaticAuthentication launch its own browser? You should be able to pass the same browser/context/page to automaticAuthentication.automaticLogin(); . It's not quite clear from the code snippet that you shared what the relationship between automaticAuthentication and the browser/page created in the @Bean. Can you share all pieces including test that creates 2 pages instead of 1 and all the methods that create pages, perform auth?

3. @beforeeach method loads the logins state, however i can see 2 browsers launched 1 from @bean and other from login state using the storageState. So i have to check which page is active and close the other so the browser also closes and continue with test.

Perhaps you can change  public Page page() { behavior to return signed in page (not sure if it meets your requirements). In any case the problem is very specific to how you structure the code using the beans.

@yury-s Please find attached my code.
Playwright Java Spring Boot Code

@kishorejawalkar if you're using JUnit 5 take a look at junit-playwright which will give you Playwright objects you can inject into your tests.  With this you can then implement auto login process pretty easily.

I looked at the project you shared but it's hard to tell what's going on, can you reduce it to a minimal scenario which doesn't work?

@yury-s When i run my tests 2 browsers are launching this is due to @Bean
@Component
public class AutomaticAuthentication extends BasePage {

    private static final String FILE_NAME = "./src/test/java/com/testing/ui/authenticationstate/LoginState.json";

    @Autowired
    private BrowserContext context;

    @Autowired
    private Browser browser;

    @Autowired
    private Page page;

    @Value("${ds.baseUrl}")
    private String baseUrl;

    @Value("${ds.enable.trace.viewer}")
    private boolean enableTraceViewer;

    public void setLoginState() {
        context.storageState(new BrowserContext.StorageStateOptions().setPath(Paths.get(FILE_NAME)));
    }

    public Page automaticLogin() {
        if (!page.isClosed()) {
            page.close();
        }
        newPage = getLoginState().newPage();
        newPage.navigate(baseUrl);
        return newPage;
    }

    private BrowserContext getLoginState() {
        return browser.newContext(new Browser.NewContextOptions().setStorageStatePath(Paths.get(FILE_NAME)));
    }
}

@Bean(destroyMethod="", name="browser")
    @DependsOn("playwright")
    public Browser browser() {
        BrowserType.LaunchOptions launchOptions = new BrowserType.LaunchOptions()
                .setChannel(browserName)
                .setHeadless(shouldRunHeadless)
                .setSlowMo(100);

        Playwright playwright = playwright();
        BrowserType browserType;
        switch (browserName) {
            case "chrome":
            case "msedge":
                browserType = playwright.chromium();
                break;
            case "firefox":
                browserType = playwright.firefox();
                break;
            case "safari":
                browserType = playwright.webkit();
                break;
            default:
                throw new IllegalArgumentException("Incorrect browser name.");
        }
        return browserType.launch(launchOptions);
    }

@Bean(name="desktopContext")
    @DependsOn("browser")
    public BrowserContext newDesktopBrowserContext(Browser browser) {
        return browser.newContext(new Browser.NewContextOptions().setViewportSize(1400, 900));
    }

@Bean(destroyMethod="")
    @DependsOn({"browser", "desktopContext", "newPage"})
    public Page page() {
        Page page;
        if (screenType.equals(DESKTOP)) {
            page = newPage(newDesktopBrowserContext(browser()));
            navigate(Map.of(), page);
        } else {
            page = newPage(newMobileBrowserContext(browser()));
            navigate(Map.of("mobile", "true"), page);
        }
        return page;
    }

@Bean(name="newPage")
    public Page newPage(BrowserContext browserContext) {
        return browserContext.newPage();
    }

private void navigate(Map<String, String> queryParams, Page page) {
        if (queryParams.isEmpty()) {
            page.navigate(baseUrl, new Page.NavigateOptions().setWaitUntil(WaitUntilState.NETWORKIDLE));
        } else {
            final String queryParamsAsString = queryParams.entrySet().stream().
                    map(entry -> "&" + entry.getKey() + "=" + entry.getValue())
                    .collect(joining("&"));
            page.navigate(baseUrl + "?" + queryParamsAsString, new Page.NavigateOptions().setWaitUntil(WaitUntilState.NETWORKIDLE));
        }
    }

@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE)
@TestPropertySource({"classpath:testing-ui-${test.environment:dev}.properties"})
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
@DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_EACH_TEST_METHOD)
public abstract class BaseTest {

    private static final String FILE_PATH = "./src/test/resources/";

    @Autowired
    @RegisterExtension
    private TestHandler testHandler;

    @Autowired
    private SignInPage signInPage;

    @Autowired
    private LandingPage landingPage;

    @Autowired
    private Page page;

    @Autowired
    private Browser browser;

    @Autowired
    private BrowserContext browserContext;

    @Autowired
    private Playwright playwright;

    @Autowired
    private BaseClient baseClient;

    @Autowired
    private AutomaticAuthentication automaticAuthentication;

    @Value("${ds.credentials.username}")
    private String username;

    @Value("${ds.credentials.password}")
    private String password;

    @Value("${ds.enable.trace.viewer}")
    private boolean enableTraceViewer;

    @BeforeAll
    private void signIn() {
        signInPage.ID.setText(username);
        signInPage.password.setText(password);
        signInPage.signIn.click();
        automaticAuthentication.setLoginState();
        assertThat(landingPage.signOut.isVisible(), is(true));
        signOut();
        closePage();
    }

    @BeforeEach
    private void setLogin() {
        if (enableTraceViewer) {
            browserContext.tracing().start(new Tracing.StartOptions().setScreenshots(true).setSnapshots(true).setSources(true));
        }
        newPage = automaticAuthentication.automaticLogin();
    }

    @AfterEach
    private void close(TestInfo testInfo) {
        disposeAPIRequestContext();
        signOut();
        closePage();
        if (enableTraceViewer) {
            browserContext.tracing().stop(new Tracing.StopOptions()
                    .setPath(Paths.get(FILE_PATH + "traces/" + testInfo.getDisplayName().replaceAll("\\(|\\)", "_") +
                            LocalDateTime.now().format(DateTimeFormatter.ofPattern("dd_MM_yyyy_hh_mm_ss")) + ".zip")));
        }
        closeBrowserContext();
        closeBrowser();
    }

    @AfterAll
    private void tearDown() {
        closePlaywright();
    }

    void signOut() {
        if (landingPage.signOut.isVisible()) {
            landingPage.signOut.click();
        }
    }

    void disposeAPIRequestContext() {
        disposeApsAPIRequestContext();
        disposeDasAPIRequestContext();
    }

    void disposeDasAPIRequestContext() {
        APIRequestContext dasApiRequestContext = baseClient.getDasApiRequestContext();
        if (dasApiRequestContext != null) {
            dasApiRequestContext.dispose();
        }
    }

    void disposeApsAPIRequestContext() {
        APIRequestContext apsApiRequestContext = baseClient.getApsApiRequestContext();
        if (apsApiRequestContext != null) {
            apsApiRequestContext.dispose();
        }
    }

    void closePage() {
        if (page != null) {
            page.close();
            page = null;
        } else if (!newPage.isClosed()) {
            newPage.close();
            newPage = null;
        }
    }

    void closeBrowserContext() {
        if (browserContext != null) {
            browserContext.close();
            browserContext = null;
        }
    }

    void closeBrowser() {
        if (browser != null) {
            browser.close();
            browser = null;
        }
    }

    void closePlaywright() {
        if (playwright != null) {
            playwright.close();
            playwright = null;
        }
    }
}

It does look like there is a real bug here, but it is very hard to understand what's going on. We often spend days on these kinds of bugs that involve digging into large codebases. Feel free to open a new issue with a smaller repro script.

Hi, I am new to Playwright. Please can any one help me?
I have created 3 pages and 3 tests when I ran the third could not auto-login. Even if the page is open the validated state ie the test run is looking at the initial page one, not a recently opened page.
I am used Jave POM with StorageStateOptions..


[3.2] Fix glTF import of scenes without buffers

See #34066
bufferViews and acessors fields are optional in glTF but the code assumes they are required. This is what keeps the samples in the issue above from working. There are two limitations:

This only fixes the 3.2 branch and AFAIK master has the same issue.
Empty nodes still don't work with import hints like -colonly which the linked issue also seems to track (?)

I have a solution for that but I assume I should put that in a separate PR?

This only fixes the 3.2 branch and AFAIK master has the same issue.

Pull requests (especially ones that break backwards compatibility) should be opened against the master branch instead of 3.2. This is because feature development occurs in the master branch. We can then cherry-pick specific PRs to the 3.2 branch if they don't break backwards compatibility.

This only fixes the 3.2 branch and AFAIK master has the same issue.

Pull requests (especially ones that break backwards compatibility) should be opened against the master branch instead of 3.2. This is because feature development occurs in the master branch. We can then cherry-pick specific PRs to the 3.2 branch if they don't break backwards compatibility.

Pull requests (especially ones that break backwards compatibility) should be opened against the master branch instead of 3.2.

Sorry I was wondering how that would work because the code moved in master to modules/gltf.

Pull requests (especially ones that break backwards compatibility) should be opened against the master branch instead of 3.2.

Sorry I was wondering how that would work because the code moved in master to modules/gltf.

In this case we'd need two pull requests to fix it in both branches yes.

In this case we'd need two pull requests to fix it in both branches yes.

Empty nodes still don't work with import hints like -colonly which the linked issue also seems to track (?)

No, it was incorrectly referenced there as duplicate, but it's not. The issue for import hints is #32363.

Empty nodes still don't work with import hints like -colonly which the linked issue also seems to track (?)

No, it was incorrectly referenced there as duplicate, but it's not. The issue for import hints is #32363.

Thanks!

Thanks!


Why can't be used in China

I am a developer from China, why I can't use your SDK, If I need to modify, please tell me to change what

Hi Kevin -- The SDK currently does not support China (API calls for riders based in China). You'll need to make some simple changes to the OAuth2 authorization url (login.uber.com --> login.uber.com.cn) and the API base url (api.uber.com --> api.uber.com.cn)
The changes are summarized here https://developer.uber.com/docs/china
Right now, you'll need to make these changes manually. Sorry about that! We are working on integrating this with the SDK so we can support China riders seamlessly :) Stay tuned!


Creating code with template does not automatically open new code

Type: Bug
I used the "Generate Project from Template" feature to make a python consumer.  After I entered all the info in the template, and picked a location to save the file to (in my case, I created a new folder for the code the template was generating), I clicked save.
When the modal dialog closed, I was expecting to see the code that was just generated and saved be in the VS Code view, but it wasn't.  I had to navigate back to the folder I had created to find it.
Seems like a bug
Extension version: 0.16.3
VS Code version: Code 1.93.1 (Universal) (38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40, 2024-09-11T17:20:05.685Z)
OS version: Darwin arm64 23.6.0
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (8 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
10, 8, 6

Memory (System)
16.00GB (0.26GB free)

Process Argv
--crash-reporter-id a94e9292-2792-4272-bb61-f29756bd22e9

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
0ee40948:31013168
a69g1124:31058053
dvdeprecation:31068756
dwnewjupytercf:31046870
impr_priority:31102340
nativerepl1:31139838
refactort:31108082
pythonrstrctxt:31112756
flighttreat:31134774
wkspc-onlycs-t:31132770
wkspc-ranged-t:31125599
autoexpandse:31133494
ei213698:31121563

Hmm thanks for the feedback! We have a notification window (bottom right) that opens up after save with the option to open the code in a new VSCode window - did you happen to notice if it popped up for you?
Maybe there's a way to make that message more prominent. I will take a look.

I did not look for or see that notification, I just assumed the new file would be opened and put into focus.

I don't think we should just open the new project w/o asking, as there are different ways in which the user may want to open it:

Open in new window
Open in current window (replace currently opened workspace)
Add to current workspace

That being said, one option to consider here how Azure Function implemented this. Their entire project creation experience is surfaced via Quick Picks, with the last step asking how the user want to open the project to be created:

The nice thing about this approach is that the quick pick menu continuously captures users' attention.
Vs. the current implementation here, which requires user's attention/focus to move across long distance:

Starting on the left menu to initiate the command.
Moving to quick picks to select project type.
Back to main editor to enter creds.
Notification on lower right to open project.

Hey @derek1ee sorry I missed this comment - I was never notified. :( I paired up with @katehollowayconfluent this morning and I'm opening up a PR shortly that should resolve this ambiguity without forcing the files to open up.
FWIW we did start off with the quickpick for project generation and eventually moved it into a webview form because we didn't like the UX with the quickpick - the lengthiness of some templates & answers can be very tedious there, a user may have to leave the window to gather the info and lose the flow, and users can't see what Qs are coming next to make info gathering more efficient (and maybe some other issues I can't remember?).

Fixed with https://github.com/confluentinc/vscode/pull/339


CMake: Optional Install if Embedded

When adding this library as embedded library with private "target link", e.g., only used inside private source files, the library does not need to be installed when the main project gets installed.
This adds an additional option toml11_INSTALL similar to the test-build control switch in order to skip installing headers and CMake config files if requested.
Avoids using
add_subdirectory(path/to/toml11 EXCLUDE_FROM_ALL)

which has further side-effects:
https://cmake.org/cmake/help/v3.0/command/add_subdirectory.html

ping @ToruNiina :wave:
Hi, can you please approve my PR for CI and potentially review/merge it? Please let me know if you have any questions on it :)
Thanks already!

LGTM.


feat: add warning when code fence has no lang

I spent some time trying to make your plugin work this morning.
Found out that it doesn't work when the code fence does not include a language.
Thinking about it I can see how it's good practice to document the language and it makes identification of start / end easier.
However if the plugin gave me more of a clue why it was doing nothing, I might have saved some time.
This PR gives users more of a clue when it goes wrong.

Thank you, I appreciate it.￼

Perhaps code fences with no language should be supported by the plugin as well? While it might be a good standard to provide a language, I think the plugin still should be able to handle the case where no language is provided :)

I agree with you. It's been along time since I've worked on this. I don't remember why I didn't support that. I don't think I had any particular reason. I might just have to look a little more carefully at how it's implemented when I get a chance.

Commenting on closed PR... Hmmm...
The language on a code fence means you know that what you're looking at is a start (and thus there should be an end afterwards).
Without that I think the plugin would be between fence markers, which might not actually be within a fence at all.
There's definitely an argument that it's OK for when you use something in the wrong place, it does the wrong thing. However right now it's sort of end up linting my markdown, which is no bad thing...


Add separate change password page & .well-known/change-password

Originally posted by @Jack5079 in https://github.com/nbitzz/monofile/issues/17#issuecomment-1750388998

One note about .well-known/change-password:

Servers must not locate the actual change password page at the change password url, per RFC8615 §1.1 Appropriate Use of Well-Known URIs. Clients must handle ok status responses when requesting a change password url.


Fixing iOS blinking cursor while typing.

Fixing #1876

@aloisdeniel Is this PR ready for review?
Also, it would be of great help when reviewing the PR if you could add a description of what the issue was, your solution and what changes you had to make to the certain apis to fix the issue. Ik, you've those detailed in the mentioned issue but would help to have brief description of it in this PR as well.

@rutvik110 can you cherry pick this for stable?


1.0.4 only do server side rendering

Upgrading to Rendr 1.0.4 breaks client side rendering of views.
Steps to reproduce
1: install Rendr example 00_simple, with version 1.0.4 and required dependencies (handlebars, qs2)
2: load example
3: edit <body> background color to pink
4: click Repos link
Expected behaviour
Repos view loads, background stays pink
Actual behaviour
Entire page reloads from server, backgrounds reverts to white

Heya @skanaar - there was a recent change to the Rendr code in 1.0.4 and the examples need an update to get their templating working again. @ingiulio (author of the change) should be along shortly to help :-)

Hey @skanaar, could you elaborate more on the step n.3 and how you edit the background color?
I'm trying to get a better understanding of the problem here.
Thank you

@ingiulio : I added background: pink the style of the <body> tag in Chrome DevTools. It doesn't have anything to do directly with the problem, it is just to visualise that the entire page is reloaded from server when following any routes.

@skanaar cool, that's what I tried to reproduce the issue and it seems to be working fine for me.
Can you please try pulling this https://github.com/ingiulio/rendr-examples/tree/addHandlebarsDep and giving it a run? It's the branch I created for the PR that has to go in rendr-examples (https://github.com/rendrjs/rendr-examples/pull/20)

@ingiulio Your branch is working as intended. Thanks for updating.

@skanaar thanks for reporting the issue!  Sorry about that - PR has been merged. hopefully everything is working fine for you now :)


Build with GHC 8.10

I'm trying to build ghcide using recently released GHC 8.10. After updating dependencies correspondingly, I see the following error message:
src/Development/IDE/GHC/HieAst.hs:30:1: error:
    Could not find module ‘HsSyn’
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
   |
30 | import HsSyn
   | ^^^^^^^^^^^^

src/Development/IDE/GHC/HieAst.hs:37:37: error:
    Module ‘Type’ does not export ‘mkFunTys’
   |
37 | import Type                       ( mkFunTys, Type )
   |                                     ^^^^^^^^

I can see that at least the HsSyn module is not present in ghc-lib-parser-<IP_ADDRESS>00324.
cc @pepeiborra

This is blocking us from upgrading to ghc 8.10

The diff for HLint might be instructive - https://github.com/ndmitchell/hlint/pull/934 suggests the kind of changes that will be required.