[FLINK-30658][Table SQL/Planner] remove table-planner direct dependency on flink-sql-parser-hive

What is the purpose of the change
To externalize Hive connector, we propose moving flink-sql-parser-hive into hive connector to maintain and release together. Given related class were code generated and less flexible to refactor, we propose adding a naive wrapper facade to proxy field or method call.
Once FLINK-30659 complete, we would remove flink-sql-parser-hive depdency completely from table-planner as related classed will be implemented in new flink-connector-hive-parent project.
Brief change log

change  flink-sql-parser-hive in table-planner to provided, add flink-sql-parser-hive dependency to flink-connector-hive
add FlinkParserWrapper facade so that table-planner can build and run during flink-sql-parser-hive migration
adding FlinkParserWrapper unit tests

Verifying this change
This change is already covered by existing tests, such as (please describe tests).
flink-connector-hive
This change added tests and can be verified as follows:
e2e tests should run
flink-connector-hive test should pass
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes)

Documentation

Does this pull request introduce a new feature? (no)

@luoyuxia @MartijnVisser please provide some feedback.


Change EventDate message constraints.

Resolves #208
What have you done in this PR?

Changed message constraints in EventDate.java

I noticed that in other fields' messages constraints, they refer to the field as plural, should we do that also?
Name: "Names should only contain alphanumeric characters and spaces, and it should not be blank"
Email: "Emails should be of the format local-part@domain + ....."
Address: "Addresses can take any values, and it should not be blank"
Dev Testing Steps / Screenshots

On second thought, are we allowed to change the gender and location error message since they're not wrong but they're feature flaws.

Yes, I do not think we are allowed to change them.

Okay I will remove them and only standardise date then


Logging section in Carbon console disappeared

The latest apim version doesn't include the logging facility in the carbon console.
Version: wso2am-3.0.0-m35
JDK:
[2019-09-16 16:20:44,796]  INFO - CarbonCoreActivator Starting WSO2 Carbon...
[2019-09-16 16:20:44,814]  INFO - CarbonCoreActivator Operating System : Mac OS X 10.13.6, x86_64
[2019-09-16 16:20:44,814]  INFO - CarbonCoreActivator Java Home        : /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre
[2019-09-16 16:20:44,814]  INFO - CarbonCoreActivator Java Version     : 1.8.0_212
[2019-09-16 16:20:44,815]  INFO - CarbonCoreActivator Java VM          : OpenJDK 64-Bit Server VM 25.212-b04,AdoptOpenJDK

@tharindu1st Is there a workaround for on-the-fly logging configuration?

Hi @Tomas-Mrazek ,
If you update the log4j2.properties file under product according to log4j2 pattern its reflect directly into the node running log4j2 configuration

@tharindu1st Is there a reason, why it was removed? Directly editing log4j2.properties is way more hassle than updating it in console. Not everyone have access to file system.

@Tomas-Mrazek ,
In Gateway worker nodes we were not able to update through the UI. Therefore this feature not be able to support in those components.

closing this issue since the answer is given in above comment


Player takes damage when they touch spikes.

We should add a general script that gives the player damage when they touch an object that has that script.
This script can be added to the tilemap that has the spikes on it and later also to the enemies.

This component should also have an optional field for knockback, which would be applied on touch. That would add an extra strategy to play with as long as we have 1+ Health instead of one hit.
Like damage boosting, etc.

I've created #38 for that feature


Multiprocessing won't inherit configuration from API setup

Describe the bug
When using concurrency=multiprocessing, setting from API setup in main process won't be picked up by children.
To Reproduce
I don't have a minimal PoC yet but I would like to write down what I have and edit/update if necessary
Let's say we have the following setup:
cov = coverage.Coverage(
            source=[os.path.join("/root", "src/python")],
            data_file="/root/coverage/.coverage",
            data_suffix=True,
            auto_data=True,
            concurrency=["thread", "multiprocessing",],
            config_file=CONFIG_FILE, # CONFIG_FILE is an empty file
)

and we spawn some process using forkserver
import multiprocessing

multiprocessing.set_start_method("forkserver", force=True)
multiprocessing.set_forkserver_preload(["project.preload"])

def test():
  print("hello!")

 t = multiprocessing.Process(
            target=hello,
            args=(),
            name="some hello",
)
t.start()

When running test, child process will write coverage file into src/python and parent will correctly put it into coverage/
Expected behavior
Children should use the same coveragepy configuration as parent. Or warn user when using multiprocessing mode, configuration set via API won't be picked up.
Additional context
I believe it is not initialized because 1) it is not setup: https://github.com/nedbat/coveragepy/blob/3a476c3dac1da91888f08ffa527a6da95f6b07dc/coverage/multiproc.py#L31
and 2) in patch_multiprocessing, only rcfile is passing thru: https://github.com/nedbat/coveragepy/blob/3a476c3dac1da91888f08ffa527a6da95f6b07dc/coverage/multiproc.py#L82
I am trying to use API to control the behavior of coverage instead of configuration file as much as possible since it would be more manageable with other python pipeline and CI tasks. If API is not intended to be use in this case it would be great to have some information listed, and if I miss it could anyone kindly point me to it? :) I do find some information here but it seems unrelated to my issue here: https://github.com/nedbat/coveragepy/issues/1320

The docs have this:
.. note::

    The subprocess only sees options in the configuration file.  Options set on
    the command line will not be used in the subprocesses.

I guess it could also mention that configuration via the API won't be used in the subprocess also.
I'm not sure what kind of warning you'd like to see happen? Surely it shouldn't issue a warning just because you used multiprocessing?

The docs have this:

.. note::

    The subprocess only sees options in the configuration file.  Options set on

    the command line will not be used in the subprocesses.

I guess it could also mention that configuration via the API won't be used in the subprocess also.
I'm not sure what kind of warning you'd like to see happen? Surely it shouldn't issue a warning just because you used multiprocessing?

Ah thanks for the update! I think it would be great to have the document with warning about this behavior in API option explanation, and sub process one as well.
For warning in message, I don't have better ideas for now. It is kinda tricky situation, since options in API will be override by configuration file. I would suggest when user specify concurrency=multiprocessing, either in config file or api, and any option api is used, we could provide a suppressable message about this behavior. This is merely a suggestion tho, documentation update should be good enough.


Fix bug in isValidRemoteName

According to the docs git_remote_is_valid_name returns either 1 (success) or 0.

Rebased and pushed

Perfect, thanks !


Miscellaneous improvements

I’m rather content with the state of the project, but there are a couple of things I’d like to improve, but that are not significant enough to warrant separate issues. So, instead, I’ll collect them here.

Pattern where capacity == 0 (aka the useless pattern)
The hidden() method should hide all characters, rather than hiding none. It behaves like this because the reduction function looks for the first placeholder characters, does not find one, then stops at the end index (meaning that the effect is the same as the first placeholder being the end index, which is false). Solving this should also remove the need for special case selection on 100% formatting.

In Xcode 14.0 beta 5, updating the value while the view is active (with a button, etc) now yields:
⚠ Publishing changes from within view updates is not allowed, this will cause undefined behavior.

I don’t know if the inner workings of SwiftUI has changed of if the warning was previously suppressed (as I haven’t seen it in a while). It’s trivial to fix however, I’ll just change change lock.perform to lock.task in push(_:) to do the update async (after some testing to see that it’s OK).

Apparently, I forgot to override Snapshot/distance(from:to:) so it’s still O(n).

Lazy views improve readability
It’s easier to reason about the complexity of code when laziness is explicit. So I think it would be better if snapshot.nonvirtuals where instead snapshot.lazy.nonvirtuals(). With two extensions, you could write:
snapshot.nonvirtuals()
snapshot.lazy.nonvirtuals()

A follow up to this (and an actual improvement) would be adding a Proposal.Lazy with a merged() method:
proposal.merged().nonvirtuals()
proposal.lazy.merged().nonvirtuals() // this option does not yet exist

I think that PatternTextStyle/resolve can use the same reduce function as format and interpret. At least it looked like it before the Xcode 14.0 beta 5 decided it was time to become a pyromaniac. Anyways, it would be more performant and less code to maintain.

Fixed a bug in 5940f6bd16709b2bb999fa24f9d65a8dc4996bd2 where localizable styles marked as equals(()) would not be localized on setup. It’s not that note worthy, however, because the bug had not been introduced in outside of beta.

Removed Lock in cfa97c681793bf7f9a268539da6d997b0f3b8a1c because it was made obsolete #161

Cleaned up debug messages in ac76804ad8d98cd573adb115d04a84419d38ad28 as:
 [DiffableTextViews] [context]: [message]

Fixed #161 suggestion + autocorrection + reentrance selection flash in cb8eb6529abdbadaa2262acc044de3de14dcf2cf.

PatternTextStyle: made state public.
PatternTextStyle: added initializer parameters.
PatternTextPlaceholders: made ExpressibleByDictionaryLiteral.


Support for creating and setting custom (Module based) ACL Categories using existing Module APIs

We have the following ACL Module APIs in the core:
ValkeyModule_AddACLCategory
ValkeyModule_SetCommandACLCategories

Adding support for these existing APIs as wrapper functions (or macros) in the valkeymodule-rs SDK will allow modules to create their own customer ACL category and set this category on the module commands.
Example C Module which uses the APIs above: https://github.com/valkey-io/valkey/blob/4593dc2f059661e1c4eb43bba025f68948344228/tests/modules/aclcheck.c#L305-L313

Hi - I'd like to start working on this. Can this issue be assigned to me?
There are a few approaches to add this functionality to the SDK. I'll make a follow up comment detailing those ways once I've gone over them a bit more.

Option 1
High Level: In the modules we will make the developer of that set acl categories explicitly by calling a function that does the AddAclCategory function once. Followed by the setCommandACLCategories for each command. Will create two functions in Context called add_acl_category and set_acl_category. The add_acl_category will take in a string (The acl category name) and call RedisModule_AddACLCategory. While the set_acl_category will take in the RedisModuleCommand (Command the acl category is being added to) and a string (The acl category name).
Example Usage:
fn initialize(ctx: &Context, _args: &[ValkeyString]) -> Status {
    if register_commands(ctx) != 0 {
        return Status::Err;
    }
    Status::Ok
}

fn register_commands(ctx: &Context) -> i32 {
    ctx.add_acl_category(ctx, "bloom"); // New
    valkey_command! { ctx.ctx, "bf.add", bloom_add_command, "write fast deny-oom", 1, -1, 1};
    for command in commands {
        ctx.set_acl_category(command, "bloom");

    }
}

APIs / Interface:
pub fn add_acl_category(ctx: *mut RedisModuleCtx, acl_flags: &str) -> raw::Status {
    raw::RedisModule_AddACLCategory(ctx, acl_flags)
}

pub fn set_acl_category(command: *mut RedisModuleCommand, acl_flags: &str) -> raw::Status {
    raw::RedisModule_AddACLCategory(command, acl_flags)
}

Pros:

Has no breaking changes, as we dont change the macros or arguments in macros but instead create two new macros.
Less review needed in valkeymodule-rs as less and simpler changes are needed.

Cons:

Will require more work from devs in their own modules to add acl categories
Seems much easier to make mistakes with setting acl categories as specifying what commands have what acl categories could get complex
Multiple calls might need to be made for multiple acl categories unless we use lists

Option 2
For me: Cause a breaking change by adding a new field for commands along the lines of custom_acl_categories.
High Level: Update CommandInfo Struct to include acl_categories as a component, will cause a breaking change for modules as there will now be an incorrect number of args. Will also update the valkey_module macro to include a new field called acl categories where all the custom acl categories can be added, while also adding the field to the commands component of the macro where you can actually decide which commands get the acl categories or not.
Example Usage:
valkey_module! {
    name: MODULE_NAME,
    version: 1,
    allocator: (valkey_module::alloc::ValkeyAlloc, valkey_module::alloc::ValkeyAlloc),
    data_types: [
        BLOOM_FILTER_TYPE,
    ],
    init: initialize,
    deinit: deinitialize,
    acl_categories: [
        "bloom",
    ],   //Adds a new acl category
    commands: [
        ["BF.ADD", bloom_add_command, "write fast deny-oom", "bloom", 1, 1, 1],   //Example of adding "bloom" as an acl category
        ["BF.MADD", bloom_madd_command, "write fast deny-oom", "", 1, 1, 1],    // Example of no acl categories for a command
        ["BF.INSERT", bloom_insert_command, "write fast deny-oom", "", 1, 1, 1],
    ],
}

APIs / Interface:
#[macro_export]
macro_rules! valkey_module {
    (
        name: $module_name:expr,
        version: $module_version:expr,
        allocator: ($allocator_type:ty, $allocator_init:expr),
        data_types: [
            $($data_type:ident),* $(,)*
        ],
        $(init: $init_func:ident,)* $(,)*
        $(deinit: $deinit_func:ident,)* $(,)*
        $(info: $info_func:ident,)?
        // Below is new turned. It is an optional list so multiple custom acl categories can be defined by the Module.
        $(acl_categories: [$($acl_categories:ident),* $(,)*])?
        commands: [
            $([
                $name:expr,
                $command:expr,
                $flags:expr,
                $acl_categories:expr,    // New allows ability to set acl categories for specific commands
                $firstkey:expr,
                $lastkey:expr,
                $keystep:expr
              ]),* $(,)*
        ] $(,)*

Pros:

Much less work for the developers of modules consuming this as all they need to do is add the field of acl_categories and update commands
Very easy to see and keep track of which command has what acl categories
Easier to change if command has a certain acl category or not

Cons:

Causes a breaking change so any modules already consuming this will stop working

Breaking change occurs due to changing the args for commands in the valkey_module macro to include an acl_categories field

More changes to valkeymodule-rs which could lead to longer time for it to be merged

Overall for both:
Both options provide flexibility on ACL categories where they can be set for certain commands and not for other commands.
Appendix:
Link to functions: https://redis.io/docs/latest/develop/reference/modules/modules-api-ref/
For both options will need to change redismodule.h to include RedisModule_AddACLCategory, RedisModule_SetCommandACLCategories is already added.
i.e.
REDISMODULE_API int (*RedisModule_AddACLCategory)(RedisModuleCtx *ctx, const char *name) REDISMODULE_ATTR;
REDISMODULE_GET_API(AddACLCategory);

So this can also be used to add commands to existing categories such as "admin", right?
    commands: [         ["BF.ADD", bloom_add_command, "write fast deny-oom", "admin", 1, 1, 1],          ...     ],

So this can also be used to add commands to existing categories such as admin
Yes both options would allow developers to add the existing categories to commands. Have tested with admin, write and fast. I can test others if desired.
And if developers do not want to take advantage of it they just need to add empty ""
Yes that's the plan if option two is chosen. For option one the developers wouldn't have to do anything at all if they dont want to use ACL categories.
For compatibility we will check the min compatibility of the APIs and use the correct one for this feature


Chat layout rework

[ ] Align chat usernames to the right of the column in compact mode.
[ ] It was also suggested to align the messages itself to one column (right of the aligned username column) so that the chat doesn't go nuts when the client is small.
[x] If a username is too long, it should be replaced by ... .
[x] There should be some padding on the left of the write message box
[x] More clearly distinguish chat user categories

Other suggestions:

Making messages more readable by alternating backgrounds:
https://pp.userapi.com/c850436/v850436620/7ea23/Q4BPl4GkDjY.jpg

http://forums.faforever.com/viewtopic.php?f=2&t=17068#p170815
http://forums.faforever.com/viewtopic.php?f=2&t=17068#p170817

Done all that will be for this with colors and alignment wont change in default theme


Config edits 1

While working on refactoring the config (".cnf") files for FIPS testing, I read some of the
manpages.  This PR overhauls two of the cnf-related pages; config.pod will be in a separate PR.
This is related to #11347 (I needed to find this information to do that PR), and #11338 and a bit #11177. The ultimate goal is #11124, which is blocked by this PR and the other two.
This could be backported.
I suggest reviewers just look at the new page, and not try to read diffs.

I pushed three fixup commits to address most of the issues.  Thanks very much for the careful review!  I marked things I fixed as resolved, still have one question and one discussion point.

fixup commits pushed to address all known comments.  seeking review.

ping

This pull request is ready to merge

Merged to master. Thank you, Rich!


tvprofil.com is broken

Site
tvprofil.com
Description
staring...
config:
  output: guide.xml
  maxConnections: 1
  gzip: false
  channels: channels.xml
loading channels...
  found 1 channel(s)
run #1:
  [1/2] tvprofil.com (hr) - HRT1.hr - Nov 21, 2023 (0 programs)
  [2/2] tvprofil.com (hr) - HRT1.hr - Nov 22, 2023 (0 programs)
  done in 00h 00m 01s

btw tvprofil.com supports a ton more channels than whats listed in the channels.xml. around 1900 in total but not sure if all of them actually have data.
would it be appreciated if someone (e.g. me) would work on including all of them or is this just too much for one site?


[Feature Request] Generate Types of Datasources

Hi there! First of all, thanks for your work on this package. It's really great.
I started to use the Datasources Feature of Storyblok more for my Single-Option fields.
It's great because you can share field options between components, to keep them consistent.
However though, I noticed that when having "locally"/inside the component defined Single-Option fields, they are typed with a union of the possible field values. When using Datasources, I just get a string type out of them, which isn't that helpful.
If it's technically possible, it would be great to have the datasources also typed. If you like, I can offer to help with integrating this feature.

I am open for any PR - meanwhile you also extend the typings like I did in the examples https://github.com/dohomi/storyblok-generate-ts#resolve-relations

@dohomi
Looked into it and it seems the generated JSON from the CLI only returns the slug of the datasource:
"schema": {
  "versusCategory": {
    "datasource_slug": "versuscategory",
    "...": "..."
  }
},

But the actual values of the datasource are not listed. So there is no way to generate those types, exept, this package would have to do a HTTP request to the Storyblok API, which would also need an API key then. Not sure if this is still in the scope of this package, since this would include larger rewrite.

@madebyfabian sure you can ping them, not sure why there is no native tooling around the API for creating types. In my opinion this should be handled via GraphQL but the endpoint only delivers root page typings last time I checked.


fixing some errors

I caught a couple errors as I was going through the notes during the lecture

Marvelous, thanks!


Flake in web expression evaluation test

Seems like we might have gotten some bad data?
From https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8848480251042689344/+/u/run_test.dart_for_web_tool_tests_shard_and_subshard_web/stdout
▌00:28:07▐ STARTING ANALYSIS
01:05 +0: test/web.shard/debugger_stepping_web_test.dart: Web debugger can step over statements
01:05 +0 -1: test/web.shard/debugger_stepping_web_test.dart: Web debugger can step over statements [E]
  getStack: (-32603) getStack: NoSuchMethodError: The method 'toJson' was called on null.


Options not working

can u explain how do i use options from http://www.eclipse.org/elk/reference/
I tried setting direction of chart using
http://www.eclipse.org/elk/reference/options/org-eclipse-elk-direction.html
layout: {
              name: 'elk',
              fit: true,
              elk: {
                direction: 'top',
              },
            }

But nothing happens

All good?

Please update doc where it says
// All options are available at http://www.eclipse.org/elk/reference.html
// 'org.eclipse.elk.' can be dropped from the Identifier
// Or look at demo.html for an example.
and write some exampleshere like above for new ones to understand

demo is not working as well

Please raise separate issue for demo.html (I thought it was working), with details.
Is it the specificity of the property name or the casing in the property value that caused you problems?

specificity of the property name .. let me write u text wait

// All options are available at http://www.eclipse.org/elk/reference/options.html
// 'org.eclipse.' can be dropped from the Identifier
//  for example to change layout option as per doc http://www.eclipse.org/elk/reference/options/org-eclipse-elk-algorithm.html
//  Identifier is  org.eclipse.elk.algorithm , so use { 'elk.algorithm' : 'box'}
//
// Enums use the name of the enum e.g. 'searchOrder': 'DFS'
//


Is Netcast also supported from this plugin ?

I have version 03.11.33 installed

What do you exactly mean with Netcast?

@merdok  i have an LG TV 32LF5809-ZA
but I think it doesent have a right WebOS version .
But I can control my TV through other apps

Oh, this is unfortunately not supported. Your TV does not have webOS.


Special normalisation rules

How to deal with:

numbers
acronyms / symbols
website / email spellings (e.g. use "dot", "at" )

I would go for trying as much as possible to have letter-based normalised representations of all the above such as:

100 -> one hundred (cento, cent)
Hz -> (hertz), WHO -> double u aitch o (less sure about this one ...)
www.rai.it -> vu vu vu punto rai punto it<EMAIL_ADDRESS>-> pippo at pluto dot com

of course this would be for the sake of comparison, no one would really like to have such transcripts as a final product ... we don't even need to output normalised text if not for a debug session.

I would do the opposite actually in all cases, i.e. going from complexity to simplicity.

one hundred -> 100
hertz -> Hz, double u aitch o (not sure any stt actually outputs this)
vu vu vu punto ... (same as 2, not sure any stt actually outputs this)

especially in the case of the vu vu vu punto rai punto it, if this is transcribed wrongly, eg. "vuvuvupunto raai punto it", it would impact WER heavily as it has 5 "words" wrong, while imho this should only count as one "word", and one point "penalty" on the WER score...

I'm concerned that specific normalisation discussions can send up down a very deep rabbit hole. Like @amessina71 says, the thing to remember is that we are not interested in absolute WER (compared to reference) but in relative WER (compared to other vendors). So as long as we apply the normalisation consistently it's not so important how we normalise. My preference would be to have a very small number of core normalisation rules that each user can add to. We also don't have to reinvent the wheel. There may be something we can use from these sources: https://www.kaggle.com/headsortails/watch-your-language-update-feature-engineering,
https://github.com/google/sparrowhawk

@MikeSmithEU I actually meant the opposite too. Engines would certainly output "www.rai.it" or "100". The problem is that there might be slight differences with one another. One can output "www.rai.it" the other "www dot rai dot it". How to compare them? Again, one could output "100" the other "one hundred".


Eq 1483 piping multiple into question and answer

What is the context of this PR?
Piping multiple fields into a question and an answer. Test schema(test_multiple_piping) created to show this, with new functional tests also added.
Trello Card:
https://trello.com/c/SDpyjNdX/1483-piping-multiple-answers-into-a-question-and-an-answer-option-s
How to review
Run test_multiple_piping does it behave as card demonstrates?
Run unit tests and functional tests

Happy that this works. Think we should keep the name of the existing filter and find a new one for the new filter.

@jonnyshaw89 food for thought, i will check with Andrew when he comes in this morning


Collect memory metrics and scale based on them

The way the vm-informant currently handles this is by acknowledging that there's some amount of memory reserved for the kernel, and compensates with that for any communications with the autoscaler-agent about total resources.

Got it. To clarify: we still need to account for that here right?
Also, is there any way of deducing a good value for MemoryUsageFractionTarget?

Got it. To clarify: we still need to account for that here right?

Yup (although it matters less once the VM is sufficiently large)

Also, is there any way of deducing a good value for MemoryUsageFractionTarget?

uh, not really. Just take a guess (look at some numbers for potential decisions) and if users complain we raise/lower it, probably


add more maki objects and functions for corner amp to work

Got a screenshot?

A few ideas left in the comments, but nothing blocking. Feel free to merge whenever you want. (You have it marked as "draft", so I won't merge it for you).

Thanks! mostly had it as draft, because I wanted to go back after the other PR about lowercase went through and fix the casing in this one. I worked on them basically in parallel, so I wasn't blocked or anything. I'll get this rebased and ready, thanks for the comments!!

Got a screenshot?

Yes! "Unfortunately" it basically looks almost exactly like it did before haha...but! now it doesn't require some of the hacks that were needed to hide elements, it does it by actually running the MAKI onScriptLoaded and hiding the elements themselves!


fastrtps: 2.13.3-1 in 'rolling/distribution.yaml' [bloom]

Increasing version of package(s) in repository fastrtps to 2.13.3-1:

upstream repository: https://github.com/eProsima/Fast-DDS.git
release repository: https://github.com/ros2-gbp/fastrtps-release.git
distro file: rolling/distribution.yaml
bloom version: 0.11.2
previous version for package: 2.13.2-1

I think we should hold off on merging this one until we unpin Fast-DDS in https://github.com/ros2/ros2/blob/35dba84cb684611ed27e2bd2a5445a42206bdfc2/ros2.repos#L37

Agree, see https://github.com/ros2/ros2/pull/1529

Rolling is currently in transition to Ubuntu 24.04. The metadata created by bloom is platform specific and will need to be regenerated once the transition has been completed. It will not be necessary for you to tag a new source release, re-running bloom once Rolling has been updated will be sufficient to create a release targeting Rolling on 24.04.
@MiguelCompany I am going to close this PR since it's no longer suitable to merge as-is, once we complete the transition you'll be able to run bloom again to release for the updated Rolling platforms.


store: reduce GC limit

Like etcd, https://github.com/coreos/etcd/blob/master/etcdserver/raft.go#L44, we use 5000, 100000 seems too long.
@ngaut @BusyJay @hhkbp2

LGTM. Since we have many raft group, we may use a smaller size in the future.

5000 maybe too small when doing snapshot. See tikv/issues#424.

Maybe a better way is that if doing snapshot, we can enlarge this value.

I file an issue https://github.com/pingcap/tikv/issues/1337 and will close this PR.
We should think a better way to handle it.


UI for scaling ReplicaSets

Order of +/- buttons is weird
Missing space in the header

Screenshots

Hi @jansav  I would like to work on this issue.

Hi @jansav I would like to work on this issue.

Hey! Thanks, we appreciate it a lot. Ask if you need any help.


find-all-references

Hi fr1zle, i tried my best to do something with the find all references option aka: shift+f12
I realized that the problem is that elixir-sense doesn't have any option to search for references, so maybe it should be opened an issue in their repository for them to make it and then implement it here.
In the meantime, i found this https://marketplace.visualstudio.com/items?itemName=gayanhewa.referenceshelper to do the work, but it's not all that good because it doesn't support Elixir, again another issue should be made there too.
At the end, i took that code of the url and fast adapted it to your project, and it works very well and it's very handy!.

That code has 2 settings options that need to be adapted to your settings, for setting the "grep" system command, it supports rg(ripgrep) and ag. Default is rg (ripgrep), you can install that package from your OS repo, it's very very fast searching.
I added 3 more lines of code that if user have something selected, it searches the selected text instead of the word under the cursor when pressing shift+f12

It's up to you, do what you want with this pull request, i don't know if you have to ask permission for using the code of the other guy Edit: he have license MIT, so we can use it, but mention him in the code or where is needed

Hey, thanks for the pull request. :+1:
I am currently thinking about wether this is fits in this extension or if it would be a better fit for the refernceshelper extension.
We usually try to do everything via elixir_sense since we can just bundle it. I am not sure how i feel about adding another extension.
Let me think about it!

yeah no problem, do what it fits better


ColorScheme with copyWith works unexpectedly in Appbar and Card

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
run the code on macos14
Expected results
appbar and card should be in dark mode
Actual results
appbar and card should be in light mode
Code sample
Code sample

import 'package:flutter/material.dart';

main() async {
  runApp(const MyApp());
}

class MyApp extends StatefulWidget {
  const MyApp({super.key});

  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  final primaryColor = Colors.teal;
  late ColorScheme colorScheme = ColorScheme.fromSeed(seedColor: primaryColor);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      theme: ThemeData(),
      //bad
      darkTheme: ThemeData.dark().copyWith(
        colorScheme: colorScheme.copyWith(brightness: Brightness.dark),
      ),
      //good
      // darkTheme: ThemeData.dark().copyWith(
      //   colorScheme: ColorScheme.fromSeed(seedColor: primaryColor,brightness: Brightness.dark),
      // ),
      themeMode: ThemeMode.dark,
      home: const One(),
    );
  }
}

class One extends StatelessWidget {
  const One({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
        appBar: AppBar(),
        body: const Card(
          child: FlutterLogo(
            size: 100,
          ),
        ));
  }
}

Screenshots or Video

Screenshots / Video demonstration

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
cruvie@CruvieMac testone % flutter doctor -v
[✓] Flutter (Channel stable, 3.16.0, on macOS 14.1.1 23B81 darwin-arm64, locale zh-Hans-CN)
    • Flutter version 3.16.0 on channel stable at /Users/cruvie/Documents/DevelopmentEnvironment/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision db7ef5bf9f (10 天前), 2023-11-15 11:25:44 -0800
    • Engine revision 74d16627b9
    • Dart version 3.2.0
    • DevTools version 2.28.2
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/cruvie/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.12.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).

[✓] IntelliJ IDEA Ultimate Edition (version 2023.2.5)
    • IntelliJ at /Users/cruvie/Applications/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 76.3.4
    • Dart plugin version 232.10248

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 14.1.1 23B81 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 118.0.5993.117

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.
cruvie@CruvieMac testone %

Hi @cruvie
I can reproduce this issue on the latest master channel as well. But I see there is an issue that looks similar https://github.com/flutter/flutter/issues/136613. Could you check https://github.com/flutter/flutter/issues/136613#issuecomment-1766838128 to see if the explanation there fits your case?

Thanks for your confirmation. Closing this as a duplicate of https://github.com/flutter/flutter/issues/136613.


MIND dataset URLs update

It seems that the old MIND dataset URL are now defunct. I reached out to one of the authors and they pointed me to a new set of URLs which I have updated. I am testing it now withexperiment=nrms_mindsmall_pretrainedemb_celoss_bertsent but have updated other URLs including the tests, but not sure if that works as expecting

NOTE that I noticed that the data was wrapped in another subdir, I fixed it but not very clean probably. It works for the train small, not sure about the larger datasets yet.


Mac_ios hot_mode_dev_cycle_macos_target__benchmark timeouts without a log

failure: https://ci.chromium.org/ui/p/flutter/builders/try/Mac_ios hot_mode_dev_cycle_macos_target__benchmark/1434/overview
pr: https://github.com/flutter/flutter/pull/103559
I tried rerunning and 6 hours later I got the same result.

This is happening on every PR, there is only one bot available to run this try job (flutter-devicelab-mac-1), and it's dead.
Another: https://chromium-swarm.appspot.com/task?id=5aed6e794bf0b810&o=true&w=true

https://ci.chromium.org/p/flutter/builders/try/Mac_ios hot_mode_dev_cycle_macos_target__benchmark/1438
https://ci.chromium.org/p/flutter/builders/try/Mac_ios hot_mode_dev_cycle_macos_target__benchmark/1437
https://ci.chromium.org/p/flutter/builders/try/Mac_ios hot_mode_dev_cycle_macos_target__benchmark/1436
etc

cc @godofredoc on-call

@yusuf-goog @keyonghan do we have a single mac_ios bot in prod?

Actually answering my own question, we have two:

"flutter-devicelab-mac-1",
"flutter-devicelab-mac-46",

We could add presubmit: false to this test until the try bot pool can be fixed, we have coverage for this test in post-submit, it's not critical to run in presubmit.

Mac-46 is an arm machine but it is also dead. Moving some machines from staging to try.

mac-46 hit the bootloop problem. Unfortunately it hit it before my changes went in, so we will have to recover it physically.

Moving to P2 as the issue has been mitigated

This issue has been fixed. I'll open a new one to recover mac-46.

This just happened again:
https://ci.chromium.org/p/flutter/builders/try/Mac_ios hot_mode_dev_cycle_macos_target__benchmark/1566

This just happened again: https://ci.chromium.org/p/flutter/builders/try/Mac_ios hot_mode_dev_cycle_macos_target__benchmark/1566

Actually never mind, I think this is related to a property issue in the PR https://github.com/flutter/flutter/pull/104727.  Closing again 🙂


fix: updated the regex expression to correctly identify the table nam…

Description
When the user tries to add a postgres datasource and add any query, if the table name has hyphens in it, then quotes get assigned to first word after the schema and the dot. For example, public."counter"-with-db
The quotes should be applied to the whole table name. For example: public."counter-with-db"
fixes:#10631
changes in PR:
1.updated the regec expression to idetify the table name properly with table name consists of hypens.
2.added a test case for this scenario.
snapshots:
before:

After:

Hi @ajinkyakulkarni  @rohan-arthur @Nikhil-Nandagopal ,Please review this PR.

Summary by CodeRabbit

New Features

Enhanced handling of table names in the Postgres plugin to support a wider variety of characters, including hyphens.
Introduced a new database table (testing-table-data) for improved testing.

Bug Fixes

Adjusted table name processing to correctly format names containing hyphens.

Tests

Added new tests to verify the structure and integrity of the newly created database table.

Hii    @rohan-arthur @ajinkyakulkarni  ,Could you please assign the reviewer for it.

Hii @IAmAnubhavSaini , I have updated with proper regex to identify the table names with hypens .I have also cross checked with , Its working as expected.Please review it.
thank you.

/build-deploy-preview skip-tests=true

@Naveen-Goud this regex does not work if the table name has dots in it.

@Naveen-Goud this regex may work out better for the table names containing dots as well.
final String quotedTableName = table.getName().replaceFirst("\\.(.+)", ".\"$1\"");
Any reason you chose to change this in the latest commit?

@Naveen-Goud the server-unit-test PostgresPluginTest#testStructure is failing, please check. Also, please pull the latest release and run mvn spotless:apply before committing the changes.

Hii @NilanshBansal , I have updated the regex in latest commit because we want to accept the hypes(-) only , when we are using dot(.) in regex , its accepting all the special characters in table names .
if you want me to use the prev regex ,it allows all the special chars like $,#,@,*,& in table names , If you are okay with this ,I will updated it to prev regex.
My thought was to not allow special characters other than hypens(-),underscore(_)
also we cannot have mutliple dot in table names, it leads nested structure if we use mutliple dots in table names.

Hii @NilanshBansal , I have updated the regex in latest commit because we want to accept the hypes(-) only , when we are using dot(.) in regex , its accepting all the special characters in table names .
if you want me to use the prev regex ,it allows all the special chars like $,#,@,*,& in table names , If you are okay with this ,I will updated it to prev regex.
My thought was to not allow special characters other than hypens(-),underscore(_)
also we cannot have mutliple dot in table names, it leads nested structure if we use mutliple dots in table names.
@Naveen-Goud yes we should update the regex to this to allow special characters also as supabase also supports these naming for their tables.

Please make the relevant changes along with the suggestions in https://github.com/appsmithorg/appsmith/pull/35361#discussion_r1725473592
https://github.com/appsmithorg/appsmith/pull/35361#issuecomment-2303799613
https://github.com/appsmithorg/appsmith/pull/35361#issuecomment-2302689243
Let me know once you have done the changes will re-review the PR

Hii @NilanshBansal , I have updated the regex and the test case as you mentioned in the above comments.Can review now.
thank you.

Thanks @Naveen-Goud for the changes. I have pulled the latest changes and triggered tests on the shadow PR here: https://github.com/appsmithorg/appsmith/pull/35832
If all the tests pass, we should be good to go ahead and merge this PR in.

@Naveen-Goud tests are failing on the shadow PR, please check and fix.
https://github.com/appsmithorg/appsmith/pull/35832#issue-2479837508

Hii @NilanshBansal , The test failing are related to cypress which are for frontend. My changes are in backend only and added Junit tests.
thank you.

@Naveen-Goud the backend changes can also trigger failure for certain cypress tests. Can you please confirm once if these are related to your PR or not?

@NilanshBansal , those tests are not related to my PR.
thank you.

/build-deploy-preview skip-tests=true

@Naveen-Goud thank you for your patience, this PR has been merged! We appreciate your contribution towards making Appsmith better ❤


Unable to add class to the  tag

I am trying to implement a solution for an issue related to how Gmail iOS app's dark mode works.
For this solution to work, I need the <body> tag of the generated markup to have a class .body.
There could be another way to target the body tag within Gmail, but working on this made me realize that it's not currently possible to add a class to the <body> tag via MJML.
I might have missed something, so apologies if that's the case. Here's what I've tried:

Use css-class attribute on mj-body:

<mj-body css-class="body">

This applies the class to the div nested within body, not to bodydirectly.

Add class as an html attribute via mj-html-attributes:

<mj-html-attributes>
  <mj-selector path="body">
    <mj-html-attribute name="class">body</mj-html-attribute>
  </mj-selector>
</mj-html-attributes>

This doesn't do anything, so it makes me think the body selector doesn't work. Other CSS selectors did work so I don't think I am using the mj-html-attributes wrong.

I think there's an open issue about this somewhere. We really need to move the body tag in mj-body in next breaking version so css-class can be applied on the top level.
cc @kmcb777 Do we have some other breaking change that we can push for a v5 ?

Running into this same issue — need to add a class directly to the body tag, but haven't had any luck.
Are there any temporary workarounds?

@matthewgovaere Are you using a build tool like Gulp with MJML?
If yes, you could watch the output file and replace <body with <body class="yourClass" on each change.

Thanks @mzrnsh — that's exactly what I ended up doing. Not ideal, but it'll work for now!

Doesn’t work for the mjml / html tag either.  I ended up using the replace method too.


Documentation not showing version

https://hera-workflows.readthedocs.io/en/latest/
Showing 0.0.0-dev and missing source code documentation for some modules,
example
https://hera-workflows.readthedocs.io/en/latest/_modules/hera/workflow.html#Workflow

Thank you for identifying this @danielc103! This is a relic of introducing automated versioning in Hera's release process. The version is set here. We can probably replace it with the "installed" Hera version from the venv? Thoughts?

Not too familar with this kind of version setting with Python. I can take a look to see if there is a an easy way to pull that version into conf.py from the venv.


[ADD ME TO THE ORGANIZATION]

Name: Jayant Goel
Location: India
Interest: Web Development
Discord username(optional):- JayantGooel001
Why do you want to join?

I want to join because I want to contribute to Open-Source Community.

You can also join our Discord community here
Feel free to check out other cool repositories of the Open Source Community here.

@JayantGoel001 Thanks for your interest. Invitations have been sent to you. Kindly accept it and make your membership public.


Model language implementation

Implement the ORSO header classes for the draft simple model language.
The classes include the logic for resolving names and layers to be used easily by other programs.
The examples folder includes YAML from the website examples, a script that plots reflectivity and SLD from a given sample model, a conversion script showcasing the export of GenX models to the sample model and an estimator for measurement uncertainties based on a sample model string.
Some usage of the examples:

simple_model_example_1.yml
python resolve_and_plot_model.py simple_model_example_1.yml

simple_model_example_3.yml
python resolve_and_plot_model.py simple_model_example_3.yml

simple_model_example_4.yml

python sample2data.py "air | 5 (Co 31 | Fe 13) | Si"

python simple_model_from_genx.py ...\genx\genx\genx\examples\X-ray_Reflectivity.hgx simple_model_export_genx.yml
=> simple_model_export_genx.yml

Am I being slow, or is there a unit difference in the thicknesses between the examples 1/3 and 4? The total thicknesses don't seem to add up for me without 1/3 being in nm and 4 being in A?

@jfkcooper
What you are seeing is the newly added automatic unit conversion in combination with the globals-length_unit arguments. So example 1 is the default, which is nm, and 3+4 should be in angstrom.
But I noticed now a bug in the example 3, where the attribute is called length_units instead of length_unit, will correct that.

According to @jochenstahn it was decided to merge these developments. Will create another PR for the revision that will include the documentation and proper review.


SMTP issue - nothing in the console? How to debug further?

I setup .env with fake SMTP settings from mailtrap. If I try to sign-in using an email such as<EMAIL_ADDRESS>I am getting the error message:
Something went wrong while sending the email. Please try again later.
However, there is nothing in the console to investigate further.
Is there a parameter I could use to get more logs about the issue? That would help a lot.

Please add logs to this function here to figure out what might be going on - https://github.com/boxyhq/saas-starter-kit/blob/main/lib/email/sendEmail.ts#L22. We'll push a change to include more details in the logs.

@shuther You need to signup first before logging in via magic link.


Should the mirrors be version-locked?

Hi,
Currently, when freezing the installed packages, the freeze includes the mirror repositories.
It's not by itself a problem, but it makes it easy to reach a broken state, for example by installing a package which is only provided in a more recent version of the repo, and forgetting to update the version lock file. Then Emacs will start all right for the time being, but the next time we do a full install, it will fail to find the package. (It's approximate, don't take it as a full recipe.)
My question is, is there a good reason to version-lock those "fake" packages along with the rest?

Everything should be locked. Otherwise we do not have reproducibility. What if a package is added to one of the mirror repositories and it shadows the version of that package you were previously using from another source? Then your config will break unexpectedly on a fresh install, because the latest version of the mirror repository was used.
In general, a configuration should not be considered reproducible unless the lockfile has been written. I hope that future work can make the workflow of updating and using a lockfile simpler and faster, so that it feels like less of a burden and is therefore easier to remember.

Thanks for the very clear answer.

What if a package is added to one of the mirror repositories and it shadows the version of that package you were previously using from another source?

How could that happen exactly? At the very least packages which are locked to a commit should be safe: commit hashes should in principle not collide between different packages.
I imagine that packages which are locked by tags are more dangerous, but it should still be a rare occurrence.
Okay, fair enough. But somehow it doesn't feel like the more optimal and intuitive solution.
Another possibility would be to store the recipes in the lock file, maybe. Then a package would be locked to a specific source, and the reproducibility would be ensured regardless of whether the mirror version is more recent or older than the recipe.

In general, a configuration should not be considered reproducible unless the lockfile has been written.

In my opinion there are two levels of reproducibility at play here. One is a developer trying to find and fix a bug. There you have a specific non-working situation and you want to reproduce it exactly. Current lockfiles are a very appropriate tool for that.
The other, and I'd wager more common, one is a user trying to clone his configuration. There he has a working configuration, and he doesn't care that much if the clone is exact, as long as it still works. And if it doesn't, he can just identify the problem package and lock it to a working version. For that use-case, lockfiles are not particularly convenient, if usable at all (can you lock a single package?).
And regardless, for the non-tech-savvy user, lockfiles are probably scary -- for example, they have all those questions about version control tools in case straight things that a package was modified.

I hope that future work can make the workflow of updating and using a lockfile simpler and faster, so that it feels like less of a burden and is therefore easier to remember.

That would be great. :)
But I don't know if it will ever be possible to get a lockfile system for both categories of users.
In the meantime, maybe it would be possible to implement a more annoying system, by requiring that the cached recipes are provided by one of the repos, thus ensuring an earlier failure in most cases?

How could that happen exactly? At the very least packages which are locked to a commit should be safe: commit hashes should in principle not collide between different packages.

Sometimes two different versions of a package, with totally unrelated version histories, are provided from two different sources. In that case if the package is cloned from the wrong source, straight.el will be unable to check out the locked commit and falls back to checking out the main branch.

packages which are locked by tags

These do not yet exist, see #31 and #452.

Another possibility would be to store the recipes in the lock file, maybe.

I'm of the opinion that this is a workaround rather than a proper solution. The fundamental issue is that lockfiles are awkward to use, hence it is easy to end up in a situation where you don't actually save a lockfile, hence your configuration doesn't work as expected. The proper solution is to make lockfiles easier, not try to make the system work even in the absence of proper lockfile usage. Think NPM/Yarn: if you don't use a lockfile and then complain about anything related to package versions, your issue will be ignored because you just should have used a lockfile. straight.el doesn't yet have a clean enough implementation to be there, but I'd like it to.

can you lock a single package?

But why? What use case would this serve?

for example, they have all those questions about version control tools in case straight thinks that a package was modified.

This is indeed a problem, and in my opinion it can be easily solved by adding an option to have straight.el just hard-reset all packages automatically. Users who want local changes to be preserved can disable this option, but users who don't do any package development can be shielded from the unnecessary complexity.

But I don't know if it will ever be possible to get a lockfile system for both categories of users.

If a lockfile can be configured to be written automatically and noninteractively every time you run a package management command, then the user interface would be the same as package.el. Do you think this would suffice?

requiring that the cached recipes are provided by one of the repos

Could you clarify what you mean by "cached recipes"? straight.el has a recipe cache, but it is transient and invalidated whenever the underlying recipe repository is changed at all, and so this system cannot possibly change any user-visible behavior.

if the package is cloned from the wrong source, straight.el will be unable to check out the locked commit and falls back to checking out the main branch.

Wow.
Then even with a lock file, you don't get a fully reproducible configuration, right? If a repository is deleted and recreated, straight will load whatever is on master? I don't think full reproducibility is achievable when you depend on data from the internet, but I think I would expect the system to fail to install the package in such case, rather than install an unknown version.

The proper solution is to make lockfiles easier, not try to make the system work even in the absence of proper lockfile usage.

Okay. I'm more and more thinking that maybe my misunderstanding comes from the name "lockfile". To "freeze" or "lock" package versions, sounds like it means that you will need to unfreeze or unlock before you can update, so to me it sounds like a feature for users who do not want to update their packages too often. Not like a feature which is absolutely necessary for the system to work.
I'm not even doing regular package updates, but I am freezing my versions only when I'm absolutely sure that I want to save that configuration. It is a lot less often than I actually reproduce my configuration.

This is indeed a problem, and in my opinion it can be easily solved by adding an option to have straight.el just hard-reset all packages automatically. Users who want local changes to be preserved can disable this option, but users who don't do any package development can be shielded from the unnecessary complexity.

I believe that you are right, but as a user who does tweak some packages sometimes but still more often accidentally changes source code when following *help* links, I would still be bitten by this approach. I have vaguely toyed with the idea of adding a dir-local variable forcing files in the repos directory to be visited as read only, but... I've been lazy so far.:)
Incidentally, I might be missing something, but I don't find straight to be particularly helpful for package development. It only removes a tiny part of the development phase, but all the forking and filing a pull request remain in place, and one has to set remotes by hand. So more often than not I just fork, clone the fork in another folder and tell straight to use the local copy. Anyway, not really the topic here.

But why? What use case would this serve?

The one I described just above. Say, if I have a working configuration which requires that package foo is kept at its current version, but I like to have regular updates for other packages. Basically, the same use case as package-load-list.
I don't see an easy way to do it with the current all-or-nothing lockfiles. Maybe it is possible to specify a commit in the straight recipe (even if it comes from a recipe repository), but it's not as straightforward as calling a hypothetical straight-freeze-single-package.
And anyway, even if such a function existed, I don't see a clear way how both locks would cohabitate.

If a lockfile can be configured to be written automatically and noninteractively every time you run a package management command, then the user interface would be the same as package.el. Do you think this would suffice?

That would indeed be a huge step in the right direction. But that would also require maintaining a history of lockfiles, in order to make sure that broken updates can be reverted, and then also implementing an interface to that history...

Could you clarify what you mean by "cached recipes"?

I meant whatever makes sure that if I do, for example, straight-pull-package melpa then straight-use-package foo for a package foo which was not in the locked version of the melpa mirror, and then I add (use-package foo) to my init file and restart emacs, then straight is still able to load the package. But I guess in this case it is that it doesn't care about the recipe if the package is already built?

I think I would expect the system to fail to install the package in such case, rather than install an unknown version.

See #85. Of course, a warning is generated when this occurs.

To "freeze" or "lock" package versions, sounds like it means that you will need to unfreeze or unlock before you can update, so to me it sounds like a feature for users who do not want to update their packages too often. Not like a feature which is absolutely necessary for the system to work.

As you suggest, this is completely wrong. I would be happy to hear any ideas about how to improve the documentation or nomenclature such that this is less confusing. The reason I selected the term lockfile is that other package managers such as Yarn, RubyGems, Poetry, etc. use the word in the same way as straight.el.

tell straight to use the local copy

Well, you can hardly say straight.el is not helping, no? Doing it without straight.el would require you to manually add to the load path, generate autoloads, byte-compile, and remember to do that all again every time you make a change. Also you'd be in hot water if working with a package that uses a nontrivial :files directive in its MELPA recipe.

one has to set remotes by hand

You can specify (straight-use-package '(el-patch :fork (:repo "my-name/el-patch"))) and straight.el will do this automatically (plus validate that they stay correct, offer to push changes to your fork, etc.), although the UX could be improved.

Say, if I have a working configuration which requires that package foo is kept at its current version, but I like to have regular updates for other packages.

Ah. Yes, this is a perfectly good use case, but it's not what a lockfile is for. You want to pin a package. In Yarn, you would accomplish this by editing package.json, not by generating yarn.lock in a different way. Pinning should be implemented alongside lockfiles, not as an add-on to them, since it's conceptually a separate feature entirely. See https://github.com/raxod502/straight.el/issues/246#issuecomment-650188900 for notes on the implementation.
What is abundantly clear is that this entire situation is needlessly confusing, because there are several different things that behave similarly but yet should not be confused. That is a clear area for improvement.

straight is still able to load the package

That's because it can find the recipe in the current checked-out revision of the recipe repository. It's not like it silently checks out the revision listed in your lockfile and then deletes that checkout; that would be far too slow. straight.el defers always to whatever you put in your local repositories manually, and only offers reproducibility as an optional thing that you can request on demand (straight-thaw-versions, straight-normalize-all).
Although straight.el uses extensive caching, you would not notice any behavior difference if all of it were removed. It is strictly for performance enhancement and should not affect user-visible behavior at any time.

The reason I selected the term lockfile is that other package managers such as Yarn, RubyGems, Poetry, etc. use the word in the same way as straight.el.

That's a good enough reason. As you can probably tell by now I'm not familiar with any of those, but it makes sense now.

Well, you can hardly say straight.el is not helping, no? Doing it without straight.el would require you to manually add to the load path, generate autoloads, byte-compile, and remember to do that all again every time you make a change.

To be honest I don't remember how I was doing it before straight. I guess use-package was taking care of the autoloads, and that package.el was somehow helping me too, but it could very well be that I was sometimes loading non-compiled elisp files.

You can specify (straight-use-package '(el-patch :fork (:repo "my-name/el-patch"))) and straight.el will do this automatically (plus validate that they stay correct, offer to push changes to your fork, etc.), although the UX could be improved.

Ooh, very good to know, thanks!
That also opens a lot of possibilities for a smart way of handling dirty local copies, if that information (whether the recipe is a fork or not) is available to straight.
As for the UX, short of allowing straight to edit the users init files (and I'm very much not in favor of that) I don't see what could be done. Maybe a separate file, ala custom.el... but it would immediately be messy.

Also you'd be in hot water if working with a package that uses a nontrivial :files directive in its MELPA recipe.

That never happened, but how would it be a problem? The directive can restrict the available files, but it should never hurt to have more?

Pinning should be implemented alongside lockfiles, not as an add-on to them, since it's conceptually a separate feature entirely. See #246 (comment) for notes on the implementation.

I agree, and thanks for the reference.

straight.el defers always to whatever you put in your local repositories manually, and only offers reproducibility as an optional thing that you can request on demand (straight-thaw-versions, straight-normalize-all).

Right, once the previous confusion is cleared it makes more sense. :)

I guess use-package was taking care of the autoloads

use-package allows you to create autoloads manually, for example it autoloads any commands you mention in a :bind specification. But it completely ignores the autoloads of the package itself, hence "use-package is not a package manager (despite the name)".

it could very well be that I was sometimes loading non-compiled elisp files

You most likely were if you edited source code of packages, since package.el has no facility whatsoever for rebuilding a package, even manually.  That's an interesting idea which could be a good compromise between automation and safety. After all it seems unlikely that many people will be interested in keeping around changes that are purely local and don't have a fork on which to be published (or at least such a use case would be mostly mutually exclusive with wanting to have a reproducible configuration).

short of allowing straight to edit the users init files (and I'm very much not in favor of that) I don't see what could be done

I don't mean introducing a new system, I just mean improving the existing one. For example, it could be possible for straight.el to detect that you had just changed the recipe, and automatically offer to normalize the repository (== add your fork as a remote and fetch) at that point (rather than your needing to manually M-x straight-normalize-package).

The directive can restrict the available files, but it should never hurt to have more?

Ideally, but :files directives sometimes rearrange the directory structure and packages sometimes (unfortunately) rely on this in surprising ways. I will admit it's not common, though.
Another issue is that many packages don't have *.elc in their .gitignore files, because nobody builds the package from source. These and other issues are why straight.el has an explicit build/repo separation.

use-package allows you to create autoloads manually, for example it autoloads any commands you mention in a :bind specification. But it completely ignores the autoloads of the package itself, hence "use-package is not a package manager (despite the name)"

Yes, but package.el does, no? I don't really know, I've never run into any problem with that.

I don't mean introducing a new system, I just mean improving the existing one. For example, it could be possible for straight.el to detect that you had just changed the recipe, and automatically offer to normalize the repository (== add your fork as a remote and fetch) at that point (rather than your needing to manually M-x straight-normalize-package).

Oh you mean that the user still adds the fork manually to his init.el, but straight ensures that the local package is consistent with the recipe when evaluating straight-use-package? Yes it makes sense.

Ideally, but :files directives sometimes rearrange the directory structure and packages sometimes (unfortunately) rely on this in surprising ways. I will admit it's not common, though.

I would expect and hope that those packages also have a way of ensuring directory structure without melpa.

Another issue is that many packages don't have *.elc in their .gitignore files, because nobody builds the package from source.

I don't get it. How else do you develop a package?
Even now that I am using straight, for packages I do real work on (as opposed to fork-patch-PR), I still build from source (using cask), for example to run unit tests in a separate emacs instance.

package.el does, no?

Yes, fair enough, although it won't re-generate them if the package is changed.

you mean that the user still adds the fork manually to his init.el, but straight ensures that the local package is consistent with the recipe when evaluating straight-use-package?

Indeed.

I would expect and hope

Same here, but I've been taught by experience to prepare for disappointment when looking at existing software packaging... :'(

I don't get it. How else do you develop a package?

I have asked myself this question as well. My understanding is, with extreme awkwardness. In this case one solution is to just not bother byte-compiling. At least I could not figure out how have a proper development workflow without everything being a complete mess, and other users of straight.el have told me the same thing. Frankly it shocked me that straight.el didn't already exist.

I still build from source (using cask), for example to run unit tests in a separate emacs instance.

Why do it separately? You can still run Cask from the straight.el repository directory.

Sorry for the delay.

Yes, fair enough, although it won't re-generate them if the package is changed.

It will regenerate them if you update the package using package.el?

Why do it separately? You can still run Cask from the straight.el repository directory.

 Essentially, this setup works, and I don't feel confident working in directories which are managed by software I don't control. Cloud synchronizers are bad enough... Now that I have more experience with the straight source code it would be different, but still, why change what isn't broken?
Also, occasionally my packages get broken and when it happens I find it convenient to have two versions cohabitate: the one in straight/repos/, pulled from the master branch, with only the code, via melpa, and the one in devel/ with all the support files, in whichever broken and unpushed state it may be.

It will regenerate them if you update the package using package.el?

Yes, but not if you edit them manually or via Git, both of which I personally do all the time.

Fair enough. But for what it's worth, straight.el intends to explicitly support all of the things you want to do, and if it does not then it is a bug.

Yes, but not if you edit them manually or via Git, both of which I personally do all the time.

Right. I guess I was always manually calling require for those packages I would develop myself, or possibly even byte-compile-file t.
I understand that this whole conversation has gone quite circular. I didn't investigate what straight could do to avoid some hassles because I didn't feel the need to do so because I already worked around said hassles.

Fair enough. But for what it's worth, straight.el intends to explicitly support all of the things you want to do, and if it does not then it is a bug.

I have no doubt that I will be using more and more of those features as time passes, but I won't jump all in.
Thanks a lot for all the information, as far as I'm concerned the issue is resolved and can be closed.


ARTEMIS-2466 PageSyncTimer::timeSync isn't configurable using ASYNCIO

Add the config parameter page-sync-timeout to set a customized value,
because if the broker is configured to use ASYNCIO journal, the timeout
has the same value of NIO default journal buffer timeout ie 3333333.

This all looks good to me.
Is this squashed in a way you want to merge, or you should squash it?
Is this ready to be merged?

I would squash them on a single commit. don't know if you intend this as is (in case you want to have this cherry-pickable into a different branch or something).

IMO It is ready to be merged. I squashed them on a single commit.


Folder path is not a directory

When I click the workspaces button in the sidebar, I get the error "Folder path is not a directory."

In the settings, I confirmed the path is correct and other settings appear to be fine:

The path was copied directly from Windows File Explorer:

I went into the security properties on the directory, and to be thorough, I granted "Everyone" read/write/execute/modify permissions:

Do I need to format the path differently, or does it only work in certain Windows directories?

Hello, sorry you are having trouble.
Which version are you using?
C:\Repos\VSCodeWorkspaces is your folder path. Are the workspace files in this folder or in subfolders?

OK I see whereyour workspaces are. That should be fine. Maybe this is a windows issue. I shall test in a VM

@nick1701d Can you tell me which version you are using?

Workspace Sidebar v1.5.1
VSCode v1.81.1
Windows 11 Pro v10.0.22621 Build 22621
On Sat, Sep 2, 2023 at 3:09 PM Stephen Bungert @.***>
wrote:

@nick1701d https://github.com/nick1701d Can you tell me which version
you are using?
[image: working-windows-02-09-2023]
https://user-images.githubusercontent.com/16445037/265228231-6dcd71d1-040e-4697-a530-105929e5abda.png
—
Reply to this email directly, view it on GitHub
https://github.com/sketchbuch/vsc-workspace-sidebar/issues/80#issuecomment-1703927163,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALAG5J53FCA3TRLI7AU457LXYOHBJANCNFSM6AAAAAA4HVFM4I
.
You are receiving this because you were mentioned.Message ID:
@.***>

The workspace files are directly in that folder:  C:\Repos\VSCodeWorkspaces
They are not in any subdirectory of that folder.
On Fri, Sep 1, 2023 at 2:04 PM Stephen Bungert @.***>
wrote:

Hello, sorry you are having trouble.
Which version are you using?
C:\Repos\VSCodeWorkspaces is your folder path. Are the workspace files in
this folder or in subfolders?
—
Reply to this email directly, view it on GitHub
https://github.com/sketchbuch/vsc-workspace-sidebar/issues/80#issuecomment-1703205002,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALAG5J4E2V65OHQFX5DXKNDXYIWUDANCNFSM6AAAAAA4HVFM4I
.
You are receiving this because you authored the thread.Message ID:
@.***>

I need to spend some time looking into this. Currently I can't reproduce it on Windows, in a VM evenrthing is running fine.
One more question, are both "Repos" and "VSCodeWorkspaces" normal folders? They are not symbolic links or junctions?

Currently I can't reproduce this, and if you are using 1.5.1 now only shows "is not a folder" if the path really isn't a folder.
I created the same folder and it worked fine. I will leave this issue open and will think about what I can do, but until I can reproduce it I can't fix it. Sorry!

Closing as roofFolders are now completely different


Making sure that the resolved DNS lists get used in full

Signed-off-by: Jiri Peinlich<EMAIL_ADDRESS>

PR description
Previously we would always process the list of DNS resolved peers from the beginning. We would
at most only try maxConnections valid elements from the list and never try more. So the each
time we might be trying the same 25 peers, we connect with them and then drop them. This PR
firstly shuffles the peers list each time before applying it and then also takes from the list for
as long as there are free peers slots available as opposed to guess the limit upfront and hope
that all the peers connect.
Changelog

[x] I thought about the changelog and included a changelog update if required.

Unfortunately streams don't have a convenient method to shuffle them. Let me add a unit test to cover the takewhile

I am going to add a test covering the takeWhile part

I added a test to check the takeWhile


JWST Resolution Issue

JWST output is not at correct resolution.. yet

Galaxy Zoo defaults have been removed, allowing adaptable image sizes and no further rebinning


[FLINK-11879] Add validators for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput

What is the purpose of the change
This pull request add the following validators for the uses of InputSelectable, BoundedOneInput and BoundedMultiInput.

Rejects the jobs containing operators which implement InputSelectable in case that checkpointing is enabled.
Rejects the jobs containing operators which implement BoundedInput or BoundedMultiInput in case that checkpointing is enabled.
Rejects the jobs containing operators which implement InputSelectable in case that credit-based flow control is disabled.

Brief change log

In StreamingJobGraphGenerator, add a validator that does not support the operators which implement InputSelectable or BoundedOneInput or BoundedMultiInput when checkpointing is enabled.
In StreamTask, add a validator that does not support the operators which implement InputSelectable when credit-based mode is disabled.

Verifying this change
This change added tests and can be verified as follows:

Added test that validates the correctness of the new validator in StreamingJobGraphGenerator.
Added test that validates the correctness of the new validator in StreamTask.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks for reviewing @pnowojski  @1u0 .
The code has been updated.  Because of the conflict with the latest master branch, I rebased on the latest master and forcibly pushed. You can just look at StreamingJobGraphGenerator and StreamGraph.

The code has been updated, and please review it again. Thanks @1u0

LGTM, % with still open question:

generatedClass.getClass(Thread.currentThread().getContextClassLoader());
Is it possible that this code can be triggered in a settings where the context class loader is not a user code class loader?

The code has been updated. Because of the conflict with the latest master branch, I rebased on the latest master and forcibly pushed.
A new problem is that batch and streaming will share some operators, some of which may need to implement Bounded[Multi|One]Input in the batch mode to do something in the endInput() method, such as ContinuousFileReaderOperator (please look at  issue#13376). But if these operators implement Bounded[Multi|One]Input, streaming will not be able to use them because of the validation in this PR.
After I re-checked the code related to the checkpoint handler, I think that there was no need to add the validator for the use of Bounded[Multi|One]Input. Because as long as an EndOfPartition event arrives, the current checkpointing mechanism will not generate a successful checkpoint after that. That is, failure to handle the endInput state for checkpointing does not cause correctness problems. What do you think? @pnowojski
(In the latest code of this PR, I've removed the validation on Bounded[Multi|One]Input. If I'm wrong, I'll add it back.)

The conflict has resolved and test passed. Quick link to the CI Report: https://github.com/apache/flink/pull/8742#issuecomment-510731561g

Thanks @sunhaibotb . Merging.


Can't get LV Pro to startup.

I ran the

python -m pip install pywinusb

And updated PIP to 2.2.  But it still will not start up.  This is Proto1, on windows 11.  It is finding the motor controller board but not able to connect to it for some reason.
This is the message that I get in the console.  I don't understand the file not found error at the end.  It is clearly there...
C:\Users\Lumaview Pro>python "C:\Users\Lumaview Pro\Documents\LumaViewPro-master\lumaviewpro.py"
[INFO   ] [Logger      ] Record log in C:\Users\Lumaview Pro.kivy\logs\kivy_22-07-26_7.txt
[INFO   ] [deps        ] Successfully imported "kivy_deps.angle" 0.3.2
[INFO   ] [deps        ] Successfully imported "kivy_deps.glew" 0.3.1
[INFO   ] [deps        ] Successfully imported "kivy_deps.sdl2" 0.4.5
[INFO   ] [Kivy        ] v2.1.0
[INFO   ] [Kivy        ] Installed at "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy_init_.py"
[INFO   ] [Python      ] v3.10.5 (tags/v3.10.5:f377153, Jun  6 2022, 16:14:13) [MSC v.1929 64 bit (AMD64)]
[INFO   ] [Python      ] Interpreter at "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\python.exe"
[INFO   ] [Logger      ] Purge log fired. Processing...
[INFO   ] [Logger      ] Purge finished!
[INFO   ] [Factory     ] 189 symbols loaded
[INFO   ] [Image       ] Providers: img_tex, img_dds, img_sdl2, img_pil (img_ffpyplayer ignored)
[INFO   ] [Window      ] Provider: sdl2
[INFO   ] [GL          ] Using the "OpenGL" graphics system
[INFO   ] [GL          ] GLEW initialization succeeded
[INFO   ] [GL          ] Backend used
[INFO   ] [GL          ] OpenGL version <b'4.6.0 - Build <IP_ADDRESS>8'>
[INFO   ] [GL          ] OpenGL vendor <b'Intel'>
[INFO   ] [GL          ] OpenGL renderer <b'Intel(R) UHD Graphics'>
[INFO   ] [GL          ] OpenGL parsed version: 4, 6
[INFO   ] [GL          ] Shading version <b'4.60 - Build <IP_ADDRESS>8'>
[INFO   ] [GL          ] Texture max size <16384>
[INFO   ] [GL          ] Texture max units <32>
[INFO   ] [Window      ] auto add sdl2 input provider
[INFO   ] [Window      ] virtual keyboard not allowed, single mode, not docked
[INFO   ] [Text        ] Provider: sdl2
LED Control Board v3 identified at COM4
[INFO   ] [MCP2210     ] opening device: MCP2210 (serial:<PHONE_NUMBER>, VID: 0x04D8, PID: 0x00DE)
Found Device MCP2210 (serial:<PHONE_NUMBER>, VID: 0x04D8, PID: 0x00DE)
Could not connect to Motor Control Board
LumaViewPro compatible camera is now connected.
[INFO   ] [GL          ] NPOT texture support is available
Traceback (most recent call last):
File "C:\Users\Lumaview Pro\Documents\LumaViewPro-master\lumaviewpro.py", line 2030, in
LumaViewProApp().run()
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\app.py", line 954, in run
self._run_prepare()
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\app.py", line 924, in _run_prepare
root = self.build()
File "C:\Users\Lumaview Pro\Documents\LumaViewPro-master\lumaviewpro.py", line 2012, in build
lumaview = MainDisplay()
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\uix\floatlayout.py", line 65, in init
super(FloatLayout, self).init(**kwargs)
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\uix\layout.py", line 76, in init
super(Layout, self).init(**kwargs)
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\uix\widget.py", line 366, in init
self.apply_class_lang_rules(
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\uix\widget.py", line 470, in apply_class_lang_rules
Builder.apply(
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\lang\builder.py", line 540, in apply
self._apply_rule(
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\lang\builder.py", line 660, in _apply_rule
child.apply_class_lang_rules(
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\uix\widget.py", line 470, in apply_class_lang_rules
Builder.apply(
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\lang\builder.py", line 540, in apply
self._apply_rule(
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\lang\builder.py", line 662, in _apply_rule
self._apply_rule(
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\lang\builder.py", line 662, in _apply_rule
self._apply_rule(
File "C:\Users\Lumaview Pro\AppData\Local\Programs\Python\Python310\lib\site-packages\kivy\lang\builder.py", line 658, in _apply_rule
child = cls(__no_builder=True)
File "C:\Users\Lumaview Pro\Documents\LumaViewPro-master\lumaviewpro.py", line 1044, in init
with open('./data/labware.json', "r") as read_file:
FileNotFoundError: [Errno 2] No such file or directory: './data/labware.json'

The program needs to be run from the directory that it is in because it looks for relative directories using ./ and ../ This is something that should be corrected. At the moment, please see if you are in a different working directory.

Ah, ok.  I had two overlapping problems.  It didn't startup when I ran the python directly, which was due to an unrelated problem (one thing wasn't powered up).  But then I went to the command line to try to see what the console was saying, but didn't CD to the right directory first...
Closing...


WIP fix CORS for custom sources and add support for nuget.config

This PR adds

support for cross-origin requests (CORS) for custom sources (fixes #19)
support for loading source configuration from a nuget.config file (fixes #24)

The current state is WIP as I have a problem in the onScroll() method in the PackagesList component: when the user scrolls down the list and there are new packages available this.$refs.innerContainer is suddenly undefined. Unfortunately my Vue.js knowledge is not sufficient to find the root of this issue. @pcislo maybe you can help me here?

Hi, @pcislo. I still am not able to figure out why the $ref is empty when the onScroll is hit sometimes. Could you please help me out here?

Hi, @pcislo. I still am not able to figure out why the $ref is empty when the onScroll is hit sometimes. Could you please help me out here?

Hi, sorry for the delay, I've been quite busy recently. I've added comment to your pull request. It solves the issue with the onScroll method.

Yes, this was it! How blind could I be 😅 Thanks a ton! I fixed this bug and can disable draft mode for this PR now.

hmm, looks like the latest development branch version has some conflicts. I will resolve them.

Yes, this was it! How blind could I be 😅 Thanks a ton! I fixed this bug and can disable draft mode for this PR now.

I will review it when I'm done with #28

I also noticed that prelease versions are not working - they are not shown in the list

It seems I am not forwarding the prerelease param to the correct call. Will fix.

The credentials for a source are now read at the beginning, instead after a failed request. Also, if credentials are set in the nuget.config file for a source, the credential provider will not be called. The base call to the provider, however, has not changed. What is the exact issue, you have?

I'm receving 401 status code from the request. You can test it using Azure DevOps feeds.

I was passing the source name to the credential provider instead of the url. It should be fixed now.

I was passing the source name to the credential provider instead of the url. It should be fixed now.

Have you tested it by yourself? It's still not working with my private source.

That's strange. I created a private Azure Devops Artifacts dir and installed the credential provider. that worked for me. I will try to check it again.


ResumeHttpRequest() and return types.ActionPause works only once

Steps to reproduce

Do proxywasm.DispatchHttpCall in OnHttpRequestHeaders.
At OnHttpRequestHeaders return types.ActionPause. It will waits resuming.
Call proxywasm.ResumeHttpRequest() at callback
Do proxywasm.DispatchHttpCall in OnHttpRequestBody.
At OnHttpRequestBody return types.ActionPause.

Expected:
After step 5 OnHttpRequestBody will be paused
Actual:
After step 5 OnHttpRequestBody will continued
Problem definition. If we call ResumeHttpRequest() once, then it will enabled in all others On Request functions and Pause will not work

Please provide the more detailed information as I said in #159  SDK, Envoy version, and the example code.

@mathetake, I've prepared example: https://github.com/SMakhrov/proxy-wasm-go-sdk/tree/dev/feature/example_change_authority/examples/second_pause_dont_work
Please use this for make and run:
 make build.example name=second_pause_dont_work && make run name=second_pause_dont_work

then
curl --request GET \
  --url http://localhost:18000/ \
  --header 'Content-Type: application/json' \
  --data '{
	"name": "test"
}'

You will see that second pause at OnHttpRequestBody will not work.

Thanks for putting them. I will look into in a few weeks since I'm going into a Japan's holiday season😄 Thanks!

Thank you, @mathetake ! :) I will be waiting your help! :) Happy holidays ;)


Typo?

"which users can anticipate until performing an operation." should probably read "which users can't anticipate until performing an operation."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf421288-ba40-3904-72d1-07de1c69e211
Version Independent ID: f388925a-a573-65ab-e0db-fe61245df123
Content: char and varchar (Transact-SQL) - SQL Server
Content Source: docs/t-sql/data-types/char-and-varchar-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @MikeRayMSFT
Microsoft Alias: mikeray

@Mitch-Wheat Thank you for the feedback.
The documentation has been updated and is pending review.


FC041 should check HTTP method before erroring

The intention of FC041 is to suggest remote_file over the use of curl or wget for downloading files. This causes false positives when using these commands to do things other than download files, like POSTing requests to HTTP APIs (e.g. Elasticsearch). This check should be augmented to verify that no alternative HTTP method is specified before warning.

This is very important to be remedied.
curl description is :
curl  is a tool to transfer data from or to a server, using one of the supported protocols
(DICT, FILE, FTP, FTPS, GOPHER, HTTP, HTTPS, IMAP, IMAPS, LDAP, LDAPS, POP3, POP3S,
RTMP, RTSP, SCP, SFTP, SMTP, SMTPS, TELNET and  TFTP).
The command is designed to work without user interaction.

The above nowhere explicitly says that curl is used to download a file. The assumption in FC041 is against the definition of curl .


Adding my_repo_name to documentation index for distro

I'd like ros_factorial_isprime to be indexed and documented on ros.org.

This package has numerous problems, starting with the name that doesn't follow our conventions.  The repository is also setup strangely.  There is no LICENSE file.  The license in some of the files seems to be a non open-source license.  However, the biggest problem that I see is that this package doesn't really add much useful functionality.  It only adds a Factorial and an IsPrime function.  While those may be useful, I don't think a whole new package for them is warranted.  It would instead make much more sense for those to be in an existing library.
For all of those reasons, I'm closing this out.  Feel free to keep commenting if you disagree with this decision.

This package has numerous problems, starting with the name that doesn't follow our conventions.  The repository is also setup strangely.  There is no LICENSE file.  The license in some of the files seems to be a non open-source license.  However, the biggest problem that I see is that this package doesn't really add much useful functionality.  It only adds a Factorial and an IsPrime function.  While those may be useful, I don't think a whole new package for them is warranted.  It would instead make much more sense for those to be in an existing library.
For all of those reasons, I'm closing this out.  Feel free to keep commenting if you disagree with this decision.


Borderlands 2 - Game uses all RAM and crashes

I have gotten to a point in Borderlands 2 where I can reliably produce this issue if necessary.
This game has problems sometimes with claiming to run out of VRAM, which is already being tracked in #170. However, a secondary (and more severe) issue has manifested itself during my playthrough. Within seconds of loading my current savefile, the game will freeze, the game's audio will begin stuttering, disk I/O will rapidly increase (presumably swap being filled), and the system will become unresponsive. Within a few seconds I assume the low RAM killer kicks in, as Borderlands 2 will close itself- along with my browser, Steam, and Discord. D3D9 logs are flooded with err:   DxvkMemoryAllocator: Mapping memory failed with VK_ERROR_MEMORY_MAP_FAILED when this occurs.
This occurs both on v0.1.2 and the latest master (currently b787cf0). This does not happen on wined3d, although the game does manifest a VRAM error after a short while in this area on wined3d. gallium-nine was not tested.
Every setting maxed out except depth of field (disabled) and texture fade (disabled as part of the "out of video memory" mitigations mentioned in #170). All DLC installed, including the UHD texture pack.
System information

GPU: RX 580, 8GB
Driver: Mesa 19.1.0
Wine version: Proton 4.2-7

Launcher_d3d9.log
I captured an apitrace with wined3d, but the problem does not manifest itself in the retrace, and additionally VK_ERROR_MEMORY_MAP_FAILED does not show up in the d3dretrace d9vk logs, so it won't be of any use.

I have the same issue, and can reproduce it consistently by loading my save file at Sanctuary. A few seconds after spawning and a few seconds into Handsome Jack's line the game will start to stutter before eventually making my desktop environment unusable. I have to force the OOM killer to make the system usable again.
I recorded an apitrace with wined3d here.
The system information:

OS: Arch Linux
GPU: Vega 64
Driver: Mesa 19.1.0
Proton 4.2-7

That's the exact same spot I'm in. I had just gotten into Sanctuary, and was working on the Plan B mission.
-------- Original Message --------
On Jun 24, 2019, 3:35 PM, Janne Pulkkinen wrote:

I have the same issue, and can reproduce it consistently by loading my save file at Sanctuary. A few seconds after spawning and a few seconds into Handsome Jack's line the game will start to stutter before eventually making my desktop environment unusable. I have to force the OOM killer to make the system usable again.
I recorded an apitrace with wined3d here.
The system information:

OS: Arch Linux
GPU: Vega 64
Driver: Mesa 19.1.0
Proton 4.2-7

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

The game no longer freezes as of a0bfc932ca477b7c5973fe5fb843a5f5dcc5b7d3. Thanks for fixing the issue! :frog:

Cool!


error[E0583]: file not found for module float

v 0.2.5 (09b0cf5)
error[E0583]: file not found for module `float`
--> src/corelib/mod.rs:2:1
|
2 | mod float;
| ^^^^^^^^^^
|
= help: to create the module `float`, create file "src/corelib/float.rs"

error[E0583]: file not found for module `int`
--> src/corelib/mod.rs:3:1
|
3 | mod int;
| ^^^^^^^^
|
= help: to create the module `int`, create file "src/corelib/int.rs"

error[E0425]: cannot find function `create_methods` in module `float`
--> src/corelib/mod.rs:44:27
|
44 |         ("Float" , float::create_methods() , vec![]                      , HashMap::new()),
|                           ^^^^^^^^^^^^^^ not found in `float`
|
help: possible candidates are found in other modules, you can import them into scope
|
11 | use crate::corelib::bool::create_methods;
|
11 | use crate::corelib::never::create_methods;
|
11 | use crate::corelib::object::create_methods;
|
11 | use crate::corelib::shiika_internal_ptr::create_methods;
|
and 2 other candidates

error[E0425]: cannot find function `create_methods` in module `int`
--> src/corelib/mod.rs:45:25
|
45 |         ("Int"   , int::create_methods()   , vec![]                      , HashMap::new()),
|                         ^^^^^^^^^^^^^^ not found in `int`
|
help: possible candidates are found in other modules, you can import them into scope
|
11 | use crate::corelib::bool::create_methods;
|
11 | use crate::corelib::never::create_methods;
|
11 | use crate::corelib::object::create_methods;
|
11 | use crate::corelib::shiika_internal_ptr::create_methods;
|
and 2 other candidates

error: aborting due to 4 previous errors

Some errors have detailed explanations: E0425, E0583.
For more information about an error, try `rustc --explain E0425`.
error: could not compile `shiika`.

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

These files are generated with Ruby.
Please try rake build

Works! Thanks


chore(master): release 0.2.0

:robot: I have created a release beep boop
0.2.0 (2024-11-29)
Features

bint: convert u256 to bytes (a270c86)
bint: create easy-bint crate (7a72202)
bint: more implementation for bint (xor, conversion, accessing parts) (c9f3210)
bint: more trait impls for u256 (bdc3716)
bint: reverse_bits for u256 + doc and debug improvements (c39483b)
bint: shift left and right by one (bbae096)
bint: swap parts and swap bytes for u256 (45c4303)
bint: u256 displays and order (b41454a)
bint: u256 with add and shl (86fad87)
cipher: build gcm datatypes and function definitions (b329608)
cipher: ghash (e7fbe19)
cipher: implement parts of gcm_encrypt (f70af0c)
cipher: make gcm encrypt and decrypt work (984effe)
cipher: make GcmEncrypt action work (18133f9)
cipher: PrimitiveAlgorithm enum (1af49e2)
common: run with timeout (8db1e80)
ffield: acccept gcm semantic polynomials (6ebce72)
ffield: general gfmul but with bugs (26345b1)
ffield: mul any polynom (dad38a1)
ffield: poly2block can do gcm sem now (eb33d5d)
oracle: guess the last 13 byte for the test (4e7a2f3)
oracle: make some requests that don't yet lead anywhere (a800db6)
oracle: verify candidate function (c9b73bf)
pad: pad structure (7a3cd0c)
padsim: add padding with pkcs7 in a new crate (4f4969b)
padsim: allow printing out an encrypted block (f400df6)
padsim: encrypt and decrypt with pkcs7 and xor (9410137)
padsim: make it an executable (2b1f0ed)
padsim: server maybe works (5db304e)
padsim: show example q and plaintext when no q was correct (cb615b5)

Bug Fixes

cipher: ghash calculated L badly (6a54805)
cipher: ghash didn't append the modified ciphertext to all (93156ef)
cipher: only do the verbose prints if verbose is actually set (0d118bf)
did not use run_challenges_mt when available (5b1d67f)
ffield: convert back to the requested semantic for gfmul (037e21e)
ffield: convert to the requested semantic, instead of just gcm (214cf58)
oracle: include 0xff case, which for somereason is the 256th byte (a5220e0)
oracle: make the padding oracle abuse work (47d6721)
oracle: verify function was bad (5606b86)
padsim: answers were given in wrong sorting (707b5ad)
padsim: clear answers after evaluation, remove bad assert (ef4f6f5)
padsim: remove unnecessary input length for --encrypt (2eaac05)
padsim: some logs were not prefixed correctly, print indexes of correct q's (2c68c00)
padsim: test for lib used wrong signatures (72e24ec)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v0.2.0
:sunflower:


Storage features

Ok, so our internal solution has storage-based features.
Local, session, you name it.
The problem of course is that synchronization between open runtimes & stuff contains some proprietary IP which I'm not willing to release (for at least this year).
The task is to come up with a simple primitive basic solution that's good enough for open-source.
There are some implementation sketches, and we keep the API open, as in, this library pretends to provide the feature based on its function contract, like with the expectation to provide a codec.
This stuff will be added with a minor release.

Definitely not in scope for the package.


Add Instructions for Polkadot JS <> Subkey

I moved some Alexander .json files to a different computer and tried to restore the secret key using subkey. Polkadot JS obviously finds it because I imported the json to the UI and was able to sign transactions.
Right now our docs basically say "figure it out for yourself."
https://substrate.dev/docs/en/ecosystem/subkey#more-subkey-to-explore
If someone shows me the subkey command I will write the docs for going back and forth.

AFAIK, subkey cannot read those json files. The exercise that I intended the user to figure out on their own was copying a mnemonic from the apps UI and then running subkey inspect "<copied phrase">.
I agree that that exercise could be more clearly stated

If not in subkey, we should have instructions on how to decode that JSON. Will be useful for anyone who wants to port addresses to a new wallet.

Related: https://github.com/substrate-developer-hub/substrate-developer-hub.github.io/issues/171