Remove .tasitid.eth from the pick username screen

The user shouldn't need to wonder what ENS is when doing this

The screen is showing:
Cool. Let's start by picking your Tasit username.
[____].tasitid.eth
[Continue Button]
What should be shown?
Cool. Let's start creating an account.
[Continue Button]
?

I think literally just the current screen without .tasitid.eth. This complexity can be hidden until it’s needed. Or in a clickable info icon.


UI Enhancement: Implement New Responsive Design

UI Improvement - New Responsive Design for Better User Experience
What feature would you like to see?
I have created a new responsive design aimed at enhancing the user experience. The new design ensures that components are fully responsive across all devices, with a focus on using shadcn components for a modern and consistent UI. I have attached images of the new design below to provide a clear idea of the proposed changes.
Why is this feature useful?
This feature will improve the overall look and feel of the project, providing a more seamless and user-friendly experience for users on any device. Additionally, using shadcn components will help maintain a clean, consistent design system, making it easier to manage UI components in the future.
How important is this feature to you?

[x] Must have

Have you seen this feature in other projects?

[x] Yes, I've seen something similar elsewhere

Any other details?
I've attached screenshots of the new design for review below. I'd be happy to adjust or modify any aspects of the proposal based on feedback.
Design Images:

Desktop

Mobile

Your experience level with this project:

[x] I'm new here (first-time contributor)

Would you like to work on this feature?

[x] Yes, I'd like to try implementing this feature

Additional Note:
I would love to take ownership of this task and start working on it. Please assign the issue to me and add the appropriate label so I can proceed with the implementation.
Thank you for considering this enhancement, and I'm excited to contribute further!

Hey @ShubhamKadam098 ! That's absolutely great man ! but can you choose any one of the section to change with rather than the entire homepage ! Could you please say me which section would you like to implement with your design ?

Hi @aswathcm29 ,
Thank you for your feedback! I would love to work on the navbar and hero section, as they currently have some issues that could be improved. I believe my design can enhance their functionality and overall user experience.
Please let me know if that works for you!

Fine @ShubhamKadam098 ,
You can proceed with it , I'm assigning you with the issue


How to obtain the ../mimic_abn/temporal_ids.json file?

I encountered a problem while trying to reproduce this project. How should I obtain the --history ../mimic_abn/temporal_ids.json file?

Hi,
Thanks for your interest in our work.
The temporal_ids.json file contains relations (i.e., progression) between two consecutive images, and can be extracted from the Chest ImaGenome Dataset (https://physionet.org/content/chest-imagenome/1.0.0/), in which you can find the subject_id and object_id.
I will upload a sample file to indicate the data format later so that you can generate this file yourself.
Best,
Ethan

Hi,
I've uploaded a sample for the temporal_ids.json in ./data/mimic_cxr/temporal_ids.json. The subject_id and object_id are directly copied from https://physionet.org/content/chest-imagenome/1.0.0/.
You may create this data yourself, and I will upload my script for processing these data later but it could take some time.
Feel free to reopen the issue if you have further questions.
Best,
Ethan

Thanks for your quick reply!

Amazing work, can you provide specific instructions on which file "temporal_ids.json" refers to in the "Chest ImaGenome Dataset"? Likewise, "progression labels (i.e., better, stable, worse)" in Section 2.2. Thank you.

Hi,
Thanks for your attention.
The Chest ImaGenome Dataset is available at https://physionet.org/content/chest-imagenome/1.0.0/.
Once you downloaded the dataset, you need to unzip the scene_graph.zip file in the silver_dataset. Here is the structure of the dataset:
├── gold_dataset
├── silver_dataset
│   ├── scene_graph
│   │   ├── 10cd06e9-5443fef9-9afbe903-e2ce1eb5-dcff1097_scene_graph.json
│   │   ├── ......

Then, you can read the scene_graph.json in which there is a "relationships" key indicating the relationship between two consecutive images of a region. For example, given a case id 10cd06e9-5443fef9-9afbe903-e2ce1eb5-dcff1097 which is shown in the homepage of Chest ImaGenome, its scene_graph.json file is named as 10cd06e9-5443fef9-9afbe903-e2ce1eb5-dcff1097_scene_graph.json.
Once you open it, pick one relationship in the "relationships" value, then subject_id and object_id are their ids and the predicate is the region-level progression. Take the above id as an example:
'predicate': "['No status change']"
'subject_id': '10cd06e9-5443fef9-9afbe903-e2ce1eb5-dcff1097_left upper lung zone'
'object_id': '4bb710ab-ab7d4781-568bcd6e-5079d3e6-7fdb61b6_left upper lung zone'

Remove the _left upper lung zone then you can get the image id.
In our case, we merge all predicate as the image-level progression, as indicated in our paper.
I also uploaded a sample of temporal_ids.json for reference (https://github.com/wjhou/Recap/blob/main/data/20240101/mimic_cxr/temporal_ids.json).
Best,
Ethan

I appreciate your thorough response. I now comprehend.


Version 1.2.0 breaks complex multiline expressions

Let's say I have some styles with a switch statement that Prettier formats like this:
const Test = styled.div`
  background-color: ${props => {
    switch (p.type) {
      case "success":
        return "green"
      case "danger":
        return "red"
      default:
        return "blue"
    }
  }};
`

This was fine before 1.2.0 but in 1.2.0 I get the following errors:

Expected no more than 0 empty lines
Expected newline after ":" with a multi-line declaration

What's the latest status on this issue (I'm not familiar with the codebase, and so I'm not following the discussion here...)? The problem still exists in v1.3.1.

No one has yet to take on solving the issue, @edahlseng feel free to be the one to do it

@emilgoldsmith, I'm happy to take a look at solving, but I'm completely new to the codebase. Do you have any recommendations on where a good place to start looking may be?

Just wondering if there's any progress with this? I have these linting errors in version 1.3.2 and not sure how to get around it with either disabling the rules globally or disabling them for a file/line which doesn't feel right.


Dropdown Regression - Replaced old twig reference with correct new ref

This PR handles the replacement of old twig references with correct new refs.

Closing out - fix in place with v1.5.0 release


Content permissions final sweep

More concise language for Invite user

@adamsilver Happy for you to take out colons or I can if you haven't?


[Question]: device_info_plus has ITMS-91061: Missing privacy manifest  trouble

What is your question?
ITMS-91061: Missing privacy manifest - Your app includes “Frameworks/device_info_plus.framework/device_info_plus”, which includes device_info_plus, an SDK that was identified in the documentation as a privacy-impacting third-party SDK. Starting February 12, 2025, if a new app includes a privacy-impacting SDK, or an app update adds a new privacy-impacting SDK, the SDK must include a privacy manifest file. Please contact the provider of the SDK that includes this file to get an updated SDK version with a privacy manifest. For more details about this policy, including a list of SDKs that are required to include signatures and manifests, visit: https://developer.apple.com/support/third-party-SDK-requirements.
Checklist before submitting a question

[X] I searched issues in this repository and couldn't find such bug/problem
[X] I Google'd a solution and I couldn't find it
[X] I searched on StackOverflow for a solution and I couldn't find it
[X] I read the README.md file of the plugin
[X] I am using the latest version of the plugin
[X] All dependencies are up to date with flutter pub upgrade
[X] I did a flutter clean
[X] I tried running the example project

You didn't specify the platform or package version, but I assume you refer to macos? In that case, related to https://github.com/fluttercommunity/plus_plugins/issues/3397
Like mentioned there, the package has the privacy manifest in it, so we have no idea why Apple doesn't accept it.

Check the changelog, the privacy manifest was added back in version 10: https://github.com/fluttercommunity/plus_plugins/blob/main/packages/device_info_plus/device_info_plus/CHANGELOG.md
You need to upgrade the dependency


readme updates

@vzDevelopment do you mind adding a review so it clears the review check? thanks

Hi @carimura, I don't think I have write access which is why it isn't working. If I hover over the ticket where I have tried to review the code, it says:

Only reviews by reviewers with write access count toward mergeability

Approved

ah ok.. thanks @vzDevelopment and @zootalures


load_from_array! showing "Cron Jobs - added job with name ..." for previously added jobs

We have over a dozen cron jobs, and each time we deploy, we are seeing a bunch of "Cron Jobs - added job with name ..." messages, even though the jobs have previously been added and no changes were made. Would be nice to only see these messages when jobs are added for the first time.

Hey @KieranP 👋🏼
Actually, on each restart we are cleaning all the jobs and add them again, in order to prevent "removed" jobs to keep appearing in the schedule, see more: #405, #431. So let's say this is the expected behavior.

@markets Thank you for responding and sorry for my delayed response. You said: "we are cleaning all the jobs and add them again". but I'm not sure that is the case, at least, not in the master branch.
When we use load_from_array!, it appears to do two things: Removes old jobs that should no longer be present (via destroy_removed_jobs method) and then insert/replace the remaining (via load_from_array method). It does not seem to erase jobs that existed before and should still exist.
Instead, when a cron job is saved (https://github.com/sidekiq-cron/sidekiq-cron/blob/master/lib/sidekiq/cron/job.rb#L476-L493), it uses hset to replace the existing job information, which in my case, hasn't changed between deploys. The end of that method then always logs out "added job" even though really it replaced it with the exact same info (i.e. no change).
I suspect it would be a relatively simple thing within the save method to fetch all existing jobs (like destroy_removed_jobs already does), compare the old attributes with the new, and only output the log line if a job is new/changed.

@markets we were clearing all jobs but some folks reported issues with the default behaviour so we had to undo it. Ref: https://github.com/sidekiq-cron/sidekiq-cron/pull/427/files
@KieranP could you please check what version you are using? I don't think this should be happening in the latest version.

@sandip-mane Can confirm I am running on the latest version. The current code continues to output "Cron Jobs - added job with name ..." even though the job already existed.

The jobs are not RE-ADDED to the schedule, we are just printing it every time. i.e. We can use the exists check for logger similar to line 490.
https://github.com/sidekiq-cron/sidekiq-cron/blob/d409af416afa83362767880f57bb4bf432a80708/lib/sidekiq/cron/job.rb#L489-L492
@markets let me know if I should make this change.

Yes please @sandip-mane! Feel free to send a PR to improve this.

Got busy with the work and missed it. Hopefully this will be done with #476.

Closed by #476


handle missing token and expired tokens in the custom function

Hi,
I'm using passport-jwt to authenticate some endpoints that accept request both with and without a jwt token in the header.
Right now it looks like passport-jwt handles this by returning a 401 status code when there is no header/authorization in payload.
Would it be possible to handle such logic inside the custom function?
I was originally using my own middleware to handle this, but I couldn't figure out how to modify the req.user object without express complaining about having  only a getter on req.user.
Ge

Hi,
I just forked this repo and got it to work.
In my fork, I defer all error handling to the self._verify function so that users can handle

missing authentication token
invalid tokens with jwt_errors by themselves.

These lead to a change in the contract of the self._verify function, which becomes:
function (req, jwt_error, jwt_token, authorize)
or
function (jwt_error, jwt_token, authorize)

also, I want to allow the authorize call back to not throw an error when the user is missing, because my next middlewares uses the req.user object when it exists, but it is not required.
If you are interested in these I can fix the tests and submit a PR. If not, it's okay.
Thanks for this module!

I have to second what @episodeyang is talking about here. Right now, the strategy obfuscates errors that come built in with jsonwebtoken, upon which the strategy is based. Those implementing this strategy cannot send errors that are present in the jsonwebtoken module nor can they even inspect them.
The verify callback should absolutely include any errors that occurred underneath.

pls help. got 401 Unauthorized, when trying get secure /api.
APP.JS
opts.secretOrKey = app.get("superSecret");

passport.use(new JwtStrategy(opts, function (jwt_payload, done) {
  User.findOne({email: jwt_payload.email}, function(err, user) {
    if (err) {
      return done(err, false);
    }
    if (user) {
      done(null, user);
    } else {
      done(null, false);
      // or you could create a new account
    }
  });
}));
app.use(passport.initialize());
app.use("/api", passport.authenticate("jwt", {session: false}));

/API/LOGIN that generate token
function loginHandler(req, res, next) {
User.findOne({email: req.body.email}, function (err, user) {
return res.json({
token: jwt.sign({email: user.email}, req.app.get("superSecret"), {expiresIn: 120})
});
}
so, my REQ.HEADERS:
{
authorization: "token12312j3jkbskjfskjfbsjkdfnksjdnf"
}
what i'm missing? why i'm got 401 Unauthorized if there are token in req.headers?

+1

I used the following middleware to handle at least the situation when mixed authorized and unauthorized access is desired.
    app.use((req, res, next) => {
        passport.authenticate('jwt', { session: false }, (error, user, info, status) => {
            if (user === false && info && info.message === 'No auth token') {
				// Just unauthorized - nothing serious, so continue normally
            	return next();
			}
			return unauthenticatedError(res);
        })(req, res, next);
    });

+1

var token = jwt.sign({ user: User.id }, config.secret,{
expiresIn:  (1*60),
algorithm: 'HS256'
});
res.json({success: true, APIToken: "JWT " + token});
send request Header  :  JWT TOKEN_GENERATE

I know this is an old issue, I think what you are looking for is the custom callback feature of passport.  That is where you handle failed authentication, JWT parse errors, etc. See http://passportjs.org/docs#custom-callback
Your custom callback would have the signature:
function (err, user, info) { .... }

If a JWT parse error occurs or the JWT is not valid the user will be false and info will contain the error that jsonwebtoken provides explaining why validation of the JWT failed.


Angle brackets and ampersand with prism formater break Command line

Steps to reproduce
Use prism formater and type <,  > or &
Demo:
https://codepen.io/jcubic/pen/pKMwLZ?editors=0010

New error, old Codepen demo show error for html syntax https://codepen.io/jcubic/pen/MqyvEG

Self Note: Need to add unit test for prism.

The problem was that xml and html with Prism is recursive and escape that was added was escaping formatting not only text inside.

It's still broken, unit tests were not created.

The issue is fixed, Codepen demo have update embeded prism.js code.


<IP_ADDRESS> Rendering Errors while using Shaders Mod.

Mod Version:
DynamicSurroundings-1.12.2-<IP_ADDRESS>.jar
Forge Version:
Forge-<IP_ADDRESS>68
Link to crash log (if applicable):
Description:
When used with shaders, there is very strange opaque black shadows on most surfaces.

Screenshot?  I don't experience those issues.  I also need a list of mods in your pack.  There are mods out there that mess with the lighting routines and can futz things up.

This was due to a mod version mismatch on a server.


tower-batch: test fallback verification example.

This exposes an awkward part of the tower-batch API that I think should be fixed before making further changes.

Rebased onto main.


RequestHandle:cancel() cause RangeFileAsyncHttpResponseHandler call onSuccess()

AsyncHttpClient httpClient = ...;

RequestHandle handler = httpClient.get(url, new RangeFileAsyncHttpResponseHandler( new File(saveTo)) {
...
    public void onSuccess(int statusCode, Header[] headers, File file) {
        // if file damaged, redownload it
    }
...
}

when I use the following code:
handler.cancel(true);

onSuccess() will be called, then call onCancel().
It's a critical bug for developers who want to redownload the file when the downloaded file is damaged!
Cancel download will download again.

You should always check file size and/or checksum after downloading, RangeFileAsyncHttpResponseHandler will only ensure, that if the file already exists, it will be downloaded from last byte on to end of file.


Need to extend the footer..

Hello, Love the theme it's been easy to set up.
We are using a creative commons picture for the hero image and need to attribute it correctly.
Is there a way to add that detail to the page footer?
Thank you

Hi @michaelscloud Have you tried asking in the forums for this? Duplicate the footer into your own layouts/partials directory, and from there do anything you like with it.


new user

hello i am trying to install it on kali linux of oracle VM virtua box but by many times cannot install it, so is there any easier way to install it? I thank you again for your help

No need to install it, simply use the Docker image as explained in the README :)
Follow these instructions to install docker: https://www.kali.org/docs/containers/installing-docker-on-kali/
For kali it's a bit specific. Good luck!


Full finetuning

This is an attempt to implement full finetuning (as opposed to efficient finetuning via adapter etc.)
A script for full finetuning (updating all layers).
Todos

[x] Create finetune/full.py script
[x] Add how-to guide
[x] Create generate/full.py script

Well, maybe ignore the last commit. Lazy loading works now when you use 1 device, but it fails when using multiple devices and deepspeed.
The previous commit without lazy loading works with deepspeed.
Maybe that issue with deepspeed & lazy-loading can be circumvented when #118 is finished


Add RSEM

This PR adds RSEM to the pipeline (Fixes #70).
Notes:

I downgraded salmon to 0.14.2 because the env could not be resolved with 1.0.0 even before adding rsem
Rsem will only be activated when the aligner == 'star'. Or is there a sensible way to run RSEM together with 'hisat2'?
Linting fails already for the dev branch. I didn't attempt to fix it, but don't believe I introduce additional lint.

PR checklist

[x] PR is to dev rather than master
[x] This comment contains a description of changes (with reason)
[ ] Ensure the test suite passes (nextflow run . -profile test,docker).
([x]) Make sure your code lints (nf-core lint .).
[x] Documentation in docs is updated
[x] CHANGELOG.md is updated
[x] README.md is updated

Learn more about contributing: https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md

Merged the template already today, so if you wait for around 30 mins, at least the linting should be fine then...

Merge #394 first.


Use Python 3.10 to generate API stub file

APIView server has been using Python 3.10.2 to generate APIView file from wheel. So all automatic reviews were created using Python version 3.10.2.
CI pipeline generates APIView stub file using Python 3.9.x and this stub file is used to generate automatic review revision instead of uploading wheel now. APIView stub file has a lot of diff when running this using 3.9.x v/s 3.10.
This PR is to update Python version to run apistub step to 3.10 so three won't be any false negative diff in APIview which blocks release.

Confirmed that using py310 isn't accidentally supplanting any builds (because we weren't assuring they were using py39). Given it's literally the last actual build step, we're fine 👍


Merge changes from main

Merge this into dev-transparency only once transparency is fully working, then merge from dev-transparency to main

Actually we don't need this pull request as a PR can be created directly from dev-transparency to main and then fix conflict on dev-transparency. However there might be stuff that aren't merge conflicts that would still break the code so its better this way.

Actually, conflicts can be handled without merging on dev-transparency so this is useless.


Add a simple 'run_dex_chain' script

This is the replacement for barge.
For the testing on starfish, we need a simple script to call to start up a local private network or a test chain network.
The run_dex_chain script should do the following:

Start a local private network via docker
Start a local private network directly calling 'geth' and 'node'.
Start a test network chain to rinkeby

wrong repo !


Use pushed build images.

Please read contributing guidelines and remove this line.

#6154  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @charlielye and the rest of your teammates on  Graphite


feature idea: a cleaner start() function

Right now we've got this weird behavior in start() that the API to append to something rendered on the server is different when running it from root. Internally this means there's a whole bunch of if statements that make the code look less than ideal:
  function start (selector, startOpts) {
    if (!startOpts && typeof selector !== 'string') {
      startOpts = selector
      selector = null
    }
    startOpts = startOpts || {}

    _store.model(appInit(startOpts))
    const createSend = _store.start(startOpts)
    _router = start._router = createRouter(_defaultRoute, _routes, createSend)
    const state = _store.state({state: {}})

    if (!selector) {
      const tree = _router(state.location.pathname, state)
      _rootNode = tree
      return tree
    } else {
      onReady(function onReady () {
        const oldTree = document.querySelector(selector)
        assert.ok(oldTree, 'could not query selector: ' + selector)
        const newTree = _router(state.location.pathname, state)
        _rootNode = yo.update(oldTree, newTree)
      })
    }

And in addition the API can be two things:
// basic
const choo = require('choo')
const app = choo()

const tree = app.start()
document.body.appendChild(tree)

// server rendering
const choo = require('choo')
const app = choo()

if (require.parent) {
  module.exports = app
} else {
  app.start('#my-root-node')
}

Now I'm not a fan of this. I'm glad we put it in there to make it at least possible to render on the server, but looking back I think we can create a better API. I'm not a fan of passing in arguments that change the return type, which in turn also must be wrapped in order to export. The upgrade doesn't feel intuitive. It's too many things changing in different directions I feel. With eyes on the upgrade curve (or smooth learning curve, w/e) I reckon this might be a nicer solution:
// basic
const choo = require('choo')
const app = choo()

const tree = app.start()
document.body.appendChild(tree)

// server rendering
const mount = require('choo/mount')
const choo = require('choo')

const app = choo()

if (module.parent) {
  module.exports = app
} else {
  const tree = choo.start()
  mount('#my-root-node', tree)
}

The differences with this might not seem like a lot, but it plays further into the narrative of "removing magic" and only using native DOM methods. I think it would make the code clearer and better communicate intent (answering the important "why" for why the API is the way it is). Internally it also helps the implementation by not bundling bytes unless absolutely necessary:
function start (selector, startOpts) {
  startOpts = startOpts || {}

  _store.model(appInit(startOpts))
  const createSend = _store.start(startOpts)
  _router = start._router = createRouter(_defaultRoute, _routes, createSend)
  const state = _store.state({state: {}})

  const tree = _router(state.location.pathname, state)
  _rootNode = tree
  return tree
}

// mount.js
const onReady = require('on-ready')
const assert = require('assert')
const yo = require('yo-yo')

module.exports = mount

function mount (selector, tree) {
  assert.equal(typeof selector, 'string')
  assert.equal(typeof tree, 'object')

  onReady(function onReady () {
    const oldTree = document.querySelector(selector)
    assert.ok(oldTree, 'could not query selector: ' + selector)
    _rootNode = yo.update(oldTree, tree)
  })
}

Because we're changing the API this would definitely be a breaking change. But I wanted to hear your opinions on this - what do you all think?

:+1: to separating out server functionality. I haven't used it (and don't anticipate needing to) so I don't really know why there's separate mounting logic (why doesn't user just use dom APIs like we do in client). Also it looks like _rootNode would be undefined above.
On a separate note, there are some app options that have to be passed to choo(...) and some that are passed to start(...). I mix them up sometimes. Would it be worth having them all go in the same place? (Probably separate issue but worth considering if doing breaking change to start anyway)

On a separate note, there are some app options that have to be passed to choo(...) and some that are passed to start(...)

#192 would lay out the groundwork for this; in a major version we could deprecate all options passed to choo(), only using .start(opts). Would that be an adequate resolution?

Also it looks like _rootNode would be undefined above

Hm, I think if we could assert if the new node is different from the old node, then a bug a mismatched has happened / a node wasn't morphed but replaced instead. Think that should be reasonable

closing as it's staged on v4 already


v2.1.0 is released but Version is still "2.0.5" ?

https://pkg.go.dev/github.com/googleapis/gax-go/v2
shows Version: v2.1.0 Latest
but
const Version = "2.0.5"

tag 2.1.0 is unexpected one?

Any updates on this?

https://github.com/googleapis/gax-go/releases/tag/v2.1.1


feat(elixir): add prometheus metrics endpoint

Current Behaviour
Metrics generated from elixir code through Telemetry events are exported to influxdb.

Proposed Changes
This PR exposes a http /metrics endpoint that prometheus can scrape.  Metrics exposed are the same than the ones the existing influxdb exporter produce.
Sample metrics page after setting up a pair of  tcp inlet/outlet  against a  ocam_cloud_node locally:

Checks

[X] All commits in this Pull Request are signed.
[X] All commits in this Pull Request follow the Ockam commit message convention.
[X] I accept the Ockam Community Code of Conduct.
[X] I have accepted the Ockam Contributor Licence Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the ockam-network/contributors repository.

@polvorin awesome first PR! A couple of quick notes about commit messages:

chore(elixir): address feedback, read port for env variable

We want to avoid a message like "address feedback" and instead try to describe what's in the patch. In a PR like this one, its often helpful to squash the commit that addresses feadback with the previous commit that had a meaningful message - I often use fixup with an interactive rebase.
chore is a last resort message tag. Prefer other more meaningful tags where possible.
We want to use commit messages to generate change logs. The tags that are considered in change log generation scripts are feat, fix or refactor. Anything that is a functional change should be one of those.


File hierarchy is wrong in Test Coverage explorer (VS Code Insiders)

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.88.0-insider
Commit: b356b209a5a41743b45f25d569a7afb733d347a9
Date: 2024-03-18T16:36:07.814Z
Browser: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Code-Insiders/1.88.0-insider Chrome/120.0.6099.291 Electron/28.2.6 Safari/537.36

The PetClinicRuntimeHints.java is a file and should not have other files as its children.
@connor4312

This bug has been fixed in the latest release of VS Code Insiders!
@jdneo, you can help us out by commenting /verified if things are now working as expected.
If things still don't seem right, please ensure you're on version 3e41bfbe49c8ba3165dfcd3ab54db75430950774 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.
Happy Coding!

/verified


"Lambda" for the Hybrid Loss Term

Hi,
Thanks for your work. However, I have not found in this code where the loss weight (i.e. The lambda=0.001 for L_vlb) mentioned in the article is reflected?
It seems that the lambda=1 in the default codebase.

Hello, I also have this doubt. Have you solved it?


Heap Sort in C++

Description
This issue will cover the heap sort topic
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

Please do assign this to me.

Closing this as the PR got merged


new feature: sideway movement animation

👉 Checklist

Please make sure to check off the following before submitting:

[x ] I have reviewed my submission thoroughly.
[x ] I have tested my code (if submission is related to coding) and run the game before pushing (to make sure the project compile).
[ x] I have run the JUnit tests (if submission is related to coding).
[x ] I have read the Code of Conduct and Contribution Guidelines.

✍ Description of the Pull Request
I have implemented the sideway animation of the spaceship.

🔗 Issue link

Issue reference number and link goes here e.g. 'Fixes/Closes #<issue_number>'.

[ ] This Pull Request fixes the issue : 'Closes #'
[ X] This Pull Request does not fix an issue.

Thanks for taking the time to fill out this Pull Request! ❤ Thanks for contributing to this project 🦖

Well done, thank you so much for your work ! And sorry for the late review of your PR.

No problem, I think the animation can be improved if other image (I put the image of the ship without any modification) is used in the shadow.
best regards

The animation looks really good, you still can make some updates if you want, you're free to do everything you want :)


Update uart core

New UART core add FIFO buffers (32 bytes) into TX and RX. UART core now have two clock inputs, one is for system interface and one is for baudrate generating. FIFOs are used to crossing clock domains. This let CPU running faster. So default system clock is now set to 80MHz. Clock for baudrate generators is still 14,4 MHz and VGA use 31.5MHz.
New UART also add more flexible interrupt request. Interrupt now can be called at full RX buffer, half full RX buffer, received character, empty TX buffer, half empty TX buffer, and transmitted character. Anyway, UART core have only one interrupt request output, so flags in status register are used.
TODO:

[x]  Test UART in real HW
[x]  Rewrite UART chapter in refman
[x]  Rewrite emulator UART core
[ ] Rewrite loader

New core was tested and few bug was fixed.

Loader isn't compatible with new UART core, new quest is:

[ ] Rewrite loader

loader was tested in emulator - worked properly

loader tested in HW - worked properly too


[bug] NeonGradientCard

Describe the bug
The glow (blur) effect is not visible on the mobile browser, but it displays correctly on desktop devices.
Issue on mobile:

To Reproduce
Steps to reproduce the behavior:

Go to https://magicui.design/docs/components/neon-gradient-card using the mobile browser
You will see there is no glow effect the card itself

Expected behavior
It should be same as desktop
Expect on Desktop

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Macos
Browser Chrome
Version 126.0.6478.127

Smartphone (please complete the following information):

Device: iphone x
OS: IOS
Browser Chrome
Version 126.0.6478.153

Additional context
Identified a potential issue and a solution, but need to confirm with the team before moving forward.
Looks like /3 is the issue,  /4 or large works.
"--after-blur": `${dimensions.width / 3}px`,

hi @dong-qian, I checked it the output is quite opposite to what you have mentioned, it works fine.

Hi!
I also tested on safari and mobile safari and it seems to work for now

Going to close this issue but if anyone experiences again please feel free to open


pull request for e2e test at 01/06/2017 23:15:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Where can I setup the new metric alerts?

Hi I see the multiple documents advertising the new monitoring model on Azure SQL database. Now is it possible configure metrics (CPU, DTU, Log IO & Data IO) with the new method?
Regards,
Tlks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 57944e9d-0efa-3503-9fe8-46c91119ecc9
Version Independent ID: 32caa5c0-aac4-75f8-42f8-b483d55a8392
Content: Azure SQL Database metrics and diagnostics logging
Content Source: articles/sql-database/sql-database-metrics-diag-logging.md
Service: sql-database
GitHub Login: @danimir
Microsoft Alias: danil

@Tulkis Thank you for interest in Azure cloud services. We are investigating and will update you when we have additional information to provide.

@Tulkis This functionality is not currently available for Azure SQL Database but will be soon. I do not have a date to provide. This functionality is being rolled out across almost all services but not at the same time.

@Tulkis We will now proceed to close this thread. If there are further questions regarding this matter, please comment and we will gladly continue the discussion.


Clarify existence of FrameworkID in SUBSCRIBE calls.

I wanted to clarify how FrameworkID should or shouldn't be set in SUBSCRIBE calls. Spoke with Anand about this earlier today when I was running into issues with resubscribing.

Thanks for the PR. I couldn't find a way to assign myself as a reviewer here. I would review this and help get it committed.

@hatred No problem, thanks for the help!

@hatred still planning to review this?

@neilconway you had mentioned a while back that this could be clarified better. Can you elaborate on what you were thinking so we can get this merged in?

@vinodkone could you take a look?


Not work in Neovim

Hi joonty,
When I start debug php in neovim, there are some errors:
File "~/.nvim/neobundle/vdebug/plugin/python/start_vdebug.py", line 31, in run
self.runner.run()
File "~/.nvim/neobundle/vdebug/plugin/python/vdebug/runner.py", line 160, in run
self.open()
File "~/.nvim/neobundle/vdebug/plugin/python/vdebug/runner.py", line 47, in open
self.ui.open()
File "~/.nvim/neobundle/vdebug/plugin/python/vdebug/ui/vimui.py", line 75, in open
raise e
AttributeError: delitem
so How to solve these errors?
Thanks

@drwx you need to install the neovim python library: $ pip install neovim

Im running on those same issues even though I have python neovim installed :/

I can confirm vdebug needs some work to work nicely in neovim

For now if you want to use vdebug use vim

True i can confirm that with my exact same settings as neovim vdebug works just fine, guess i'll use that for the project im currently working.
Thanks a lot for the feedback appreciate it, @BlackIkeEagle

I can confirm that vDebug works just fine with neovim

@Taluu You mean it works fine now in the latest versions of neovim? It did not work completely fine with pre 0.1.5 versions I have tested

It seems I am using 0.2.0-dev, but at least it works fine with it

@Taluu that's great news

It works also fine with 0.1.7. :}

I'm running nvim 0.1.7 installed via homebrew on mac os sierra 10.12.12
I installed neovim via pip as well (0.1.9)
Here are my vdebug settings:
let g:vdebug_options["port"] = 9000
let g:vdebug_options["server"] = '<IP_ADDRESS>'
let g:vdebug_options["ide_key"] = 'xyz'

I get the following error after setting a breakpoint and refreshing a page in my application

What should I attribute this error message to?

You will still need to get python 2 support working in Neovim: https://neovim.io/doc/user/provider.html#provider-python
Here is a quick summary. While Neovim is running, see if you already have python 2 support by running :echo has('python'). You will see 0 (meaning not enabled) or 1 (meaning enabled) echoed at the bottom left. If it is a 1, you should be done. Otherwise you will need to make sure python 2 itself is already installed. From the terminal type pip2 to see if you have python 2. If you don't then install python 2 however you do that on your system. Then move on to adding python 2 support for Neovim by running this from the terminal: pip2 install --user --upgrade neovim. That way is recommended over sudo so you don't mess up your distribution later on.

I think this can be closed. I am also using vdebug (master) with Neovim 0.1.7 and 0.2 successfully.

Closing because confirmed working

I was unable to get vdebug to work with vim in Debian 9. However, I have neovim working with still-dtreaming-1's instructions above. Can we put this in the readme? I think a lot more people will encounter this with newer linux installs.


Fucking finaly added page title photo

👷 Deploy Preview for balkantransport processing.
🔨 Explore the source changes: 0d583559da988e6f47806174be2ab661aaeaf417
🔍 Inspect the deploy log: https://app.netlify.com/sites/balkantransport/deploys/6122b0a2fc20b40007c59339


Incorporate Stack Outputs into Stack Spans

Cloudformation stacks can output values (link to AWS doc on outputs) that can be used in other stacks, but this info isn't visible in the converted span data anywhere right now.
It might be cool to add this info somewhere on the span corresponding to each stack (and make it more easily searchable probably too).

I think the info might be findable from the DescribeStacks API (doc for the JS SDK and its response type) but I'm not sure

 Add stack outputs somewhere on the spans


re-ordering idx of test data in features and labels tensors but not in adj

As you said, ind.dataset_str.test.index shows the indices of test instances in graph, for the inductive setting as list object. So it contains the indices of test nodes.
You have changed the indices of the test set with its reordered version in the features and labels tensors but you didn't change anything in the adj tensor. I'm confused. I think that it changes the order of nodes in the features and labels tensors but the order of nodes in the adjacency matrix remains the same. Am I wrong?

Take a look at this issue  #76


Allow rules without versions

The provided examples don't work because they are missing versions. Currently generates this traceback:
Traceback (most recent call last):
  File ".../env/bin/ansible-review", line 77, in <module>
    sys.exit(main(sys.argv[1:]))
  File ".../env/bin/ansible-review", line 70, in main
    errors = errors + candidate.review(options, lines)
  File ".../env/local/lib/python2.7/site-packages/ansiblereview/__init__.py", line 68, in review
    return utils.review(self, settings, lines)
  File ".../env/local/lib/python2.7/site-packages/ansiblereview/utils/__init__.py", line 75, in review
    candidate.version = standards_latest(standards.standards)
  File ".../env/local/lib/python2.7/site-packages/ansiblereview/utils/__init__.py", line 36, in standards_latest
    return max([standard.version for standard in standards if standard.version], key=LooseVersion)
ValueError: max() arg is an empty sequence

Or, if you would prefer, maybe the fix is to update this line:
max([standard.version for standard in standards if standard.version], key=LooseVersion)

It could fall back to some default version number:
max([standard.version for standard in standards if standard.version] or ["0.1"], key=LooseVersion)

I prefer your alternative fix of adding  or ["0.1"] - let me know if you're happy to submit that change instead.

Done

Merged, thanks!


Transpiler introduction section

Closes #28

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: abbycross:x: kaelynjYou have signed the CLA already but the status is still pending? Let us recheck it.

Ok, I believe all the feedback has been incorporated.  There's one broken link that will be fixed once I get #283 done and ready to merge.

Also, looks like merging is blocked till the links all work, so I'll have to put in placeholder text for each link going to an unpublished file.

Okay, I figured out a better strategy rather than a feature branch. We simply won't copy over the transpile folder to production until it's 100% ready.
What this means for this PR:

Please go back to calling the folder transpile and using the official file names for everything
Re the broken links, I agree that it's a good idea to create empty placeholder files for the files you're linking to. You will need metadata for them. And ideally they are the final URLs, but we can always tweak.

Safe to merge this now @Eric-Arellano ?

Merging this now, keeping in mind that filenames and titles are still subject to change...


removing the evil dropbear from quickcheck

Seen the evil dropbear .&. one too many times.
using Disorder.QuickCheck (instead of Test.QuickCheck) could prevent bloodloss.
(was @domdere's idea, honest).

What is the problem in using .&. for just 2 properties and conjoin (I'm not a fan of this name but anyway) for more properties?

The problem is that .&&. Is fine but .&. Is non deterministic.
On Tue, 14 Jul 2015 at 10:19 pm Eric Torreborre<EMAIL_ADDRESS>wrote:

What is the problem in using .&. for just 2 properties and conjoin (I'm
not a fan of this name but anyway) for more properties?
—
Reply to this email directly or view it on GitHub
https://github.com/ambiata/disorder.hs/pull/37#issuecomment-121219632.

Thanks @michaelneale I actually didn't know about .&. I've only used .&&.. It makes sense, I'm not sure where .&. would be really useful.

Yes that was the confusion that inspired Dom to call it the "drop bear".
On Wed, 15 Jul 2015 at 8:04 am Eric Torreborre<EMAIL_ADDRESS>wrote:

Thanks @michaelneale https://github.com/michaelneale I actually didn't
know about .&. I've only used .&&.. It makes sense, I'm not sure where .&.
would be really useful.
—
Reply to this email directly or view it on GitHub
https://github.com/ambiata/disorder.hs/pull/37#issuecomment-121405597.

@etorreborre @domdere Can someone rebase and merge thanks


How to deploy functions automatically in CI?

Hello,
I'm tring to deploy functions automatically using tekton, and ci is expected to be triggered by git commits. I could not find any document mentioning the way to deploy functions in ci, I think there might be a few options:

Since func deploy --remote will create a pipeline to deploy the function, we can reuse the created pipeline and configure a tekton trigger to initialize the pipelinerun
May be it's possible to run func deploy --remote directly inside a tekton task?
Build the image locally and push to a registry. But then how to deploy the image?

Whic one is recommended?

Hello @drriguz,
Yes, this is a use-case which we think is core to the usage of Functions.  I am sorry we don't have documentation or additional resources yet available, but they are on the way!
For now you really have one best option:  Run func deploy --remote from within CI/CD (a GitHub Action, for exampple) which will trigger the build and deploy tekton task.  You will of course need Tekton installed in your cluster.  You will also need to have a container registry ready to go such as docker.io (unless you're running OpenShift which has one built in).
When your CI/CD action runs func deploy --remote, it will send all of the local source code to the cluster for packaging and deployment (no need to run func... from within the cluster; that's automatic.  So your CI/CD action should have the following pseudocode:
On Merge to main:
Check out your Function's source code (its current state)
Pull the latest `func` binary
run `func deploy --remote`

Please re-open if this did not answer your question @drriguz, or join us in the CNCF Slack channel to help put together your CI/CD task.

Please re-open if this did not answer your question @drriguz, or join us in the CNCF Slack channel to help put together your CI/CD task.

Thanks, this solves my problem. In my case, I have a problem building the source in CI because it's air-gapped network, my choice is currently running build on local device and use func deploy --image=xxx  option.


Headers parsing issue

Hello,
Tested with version 2.5.4 of the plug-in
When I set the es.parse.all.req.headers parameter to true, it works fine with HTTP Sampler. However, it doesn't work for some other samplers, like WebSocket Samplers (by Peter Doornbosch) or even Debug Sampler.
In JMeter, the error is:
2019-02-23 23:13:59,218 ERROR i.g.d.j.b.e.ElasticsearchBackendClient: The ElasticSearch Backend Listener was unable to a sampler to the list of samplers to send... More info in JMeter's console.
In the console, the exception is:
java.lang.ArrayIndexOutOfBoundsException: 1
        at io.github.delirius325.jmeter.backendlistener.elasticsearch.ElasticSearchMetric.parseHeadersAsJsonProps(ElasticSearchMetric.java:205)
        at io.github.delirius325.jmeter.backendlistener.elasticsearch.ElasticSearchMetric.getMetric(ElasticSearchMetric.java:88)
        at io.github.delirius325.jmeter.backendlistener.elasticsearch.ElasticsearchBackendClient.handleSampleResults(ElasticsearchBackendClient.java:107)
        at org.apache.jmeter.visualizers.backend.BackendListener.sendToListener(BackendListener.java:267)
        at org.apache.jmeter.visualizers.backend.BackendListener$Worker.run(BackendListener.java:239)

Maybe when there are no headers at all, it tries to parse anyway?
You can easily reproduce the bug with a Debug Sampler.

Hi @ncasaux,
There was indeed an issue where the plugin was trying to parse the headers even though they did not exist. I added a verification and pushed version 2.6.0 of the plugin. It's currently only available as a JAR on this repository (release section) - should be available soon to JMeter-Plugins.
Thanks a lot 😄 !

Hi @delirius325
Sorry about that, but I just tested with the 2.6.0 version, and it does exactly the same thing with a Debug Sampler:
java.lang.ArrayIndexOutOfBoundsException: 1         at io.github.delirius325.jmeter.backendlistener.elasticsearch.ElasticSearchMetric.parseHeadersAsJsonProps(ElasticSearchMetric.java:206)         at io.github.delirius325.jmeter.backendlistener.elasticsearch.ElasticSearchMetric.getMetric(ElasticSearchMetric.java:88)         at io.github.delirius325.jmeter.backendlistener.elasticsearch.ElasticsearchBackendClient.handleSampleResults(ElasticsearchBackendClient.java:130)         at org.apache.jmeter.visualizers.backend.BackendListener.sendToListener(BackendListener.java:267)         at org.apache.jmeter.visualizers.backend.BackendListener$Worker.run(BackendListener.java:239)

@ncasaux
How odd, I'll look into it and release a minor version very soon. Sorry about that!

Hi @ncasaux ,
Sorry for the delay, I just got back from vacation.
Could you send me a sample JMX so that I could debug this issue faster?
Thanks,

Hi @delirius325 ,
I submitted a pull request to fix this issue, if you want to have a look. If you want to test, a test plan with just a "Debug Sampler" will do.


"impacts" requirement in Vulnogram vs. CVE JSON 5.0 Schema

Vulnogram considers CVEs without the "impacts" property as invalid, however it is actually not a required field according to the CVE JSON schema (but if it is provided, it must contain at least one item): https://github.com/CVEProject/cve-schema/blob/master/schema/v5.0/CVE_JSON_5.0_schema.json#L550-L555

Yes done on purpose to reduce the number of clicks to add an impact and to balance the UI layout.
Otherwise it shows as an empty list with an add button and then you have to add it.


Default error page does not work on Windows

Environment

Operating System: Windows_NT
Node Version:     v16.14.2
Nuxt Version:     3.4.3
Nitro Version:    2.4.0
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      -
Runtime Modules:  -
Build Modules:    -

Reproduction
Initial project with "nuxi init". Cannot reproduce on stackblitz, it seems this is a Windows-related issue.
Describe the bug
For some reason this  template compiles incorrectly. The code after "defineProps" tries to access "error" from global scope instead of "props" object, which leads to the "ReferenceError: error is not defined".

Additional context
No response
Logs
No response

Is this a fresh project? I wonder if this is a Vue 3.3 issue. 🤔

Found a workaround by adding "vue": "~3.2.47" to the dependencies and doing a fresh install

The upstream issue has also been fixed: https://github.com/vuejs/core/commit/f25bd37c6707fde19d164d90a38de41168941f4b and released as part of Vue v3.3.2 https://github.com/vuejs/core/blob/main/CHANGELOG.md#332-2023-05-12


tidy and github actions updates

Context: When testing solo-apis codegen for the DCP APIs, found that it fails in the middle of make generate because go mod tidy needs to be called. This is probably due to a new go mod dependency being brought in by the new APIs. Adding a call to tidy before generate-mocks fixes this issue. Merging this in proactively so that the push-to-solo-apis action doesn't fail when we release gloo with the DCP APIs.
Also updated some deprecated github actions stuff

Some missed actions updates here but otherwise LGTM!

whoops, fixed e2a2ed9


Add --no-pager option to uv help

To avoid paging if that's your deal.

Hey @zanieb
I would like to work on this issue
Can you assign me?

I'm confused by this issue, uv help doesn't seem to page its output. I actually couldn't find any other command that uses a pager by default. 🤔
Could it be that I have some local config that messes things up?

Nevermind, disregard my previous comment. I'm dumb and should search better. 🤦♀
I also tested using an outdated version of uv instead of main.


Check if date created correctly

There is no check if DateTime::createFromFormat boolean false return in Service/Yahoo.php:58.
Also these should be added to other providers.
TypeError: Uncaught exception 'TypeError' with message 'Argument 2 passed to Exchanger\ExchangeRate::__construct() must implement interface DateTimeInterface, boolean given, called in /www/versions/763.8/vendor/florianv/exchanger/src/Service/Yahoo.php on line 58' in /www/versions/763.8/vendor/florianv/exchanger/src/ExchangeRate.php:32
in Exchanger\ExchangeRate::__construct called at /www/versions/763.8/vendor/florianv/exchanger/src/Service/Yahoo.php (58)
in Exchanger\Service\Yahoo::getExchangeRate called at /www/versions/763.8/vendor/florianv/exchanger/src/Service/Chain.php (56)
in Exchanger\Service\Chain::getExchangeRate called at /www/versions/763.8/vendor/florianv/exchanger/src/Exchanger.php (54)
in Exchanger\Exchanger::getExchangeRate called at /www/versions/763.8/vendor/florianv/swap/src/Swap.php (91)
in Swap\Swap::quote called at /www/versions/763.8/vendor/florianv/swap/src/Swap.php (51)
in Swap\Swap::latest called at /www/versions/763.8/protected/components/Currency.php (108)

Hey @b1rdex, thanks for the report.
Could your a send a PR with a failing test case please ?


Fast path for disabled template load explain.

Refs #1792

Primarily I just looked over the code now and figured it might make sense to add a fast path to it.


Enhancement of cards

The different cards present in home page needs  a bit of modification like if we hover onto them, a gradient change of color can be observed. Moreover the icons embedded are stuck to each other. I would like to change the UI of the cards and make it more visually appealing to the users. Kindly assign this to me @KorryKatti

no need as of now


Optimize project for the open-source contributions [WIP]

Every project can benefit from some essential prerequisites that make it more inviting, and easier to work with.
I'll try to list those essential steps in this issue.

Note
This is a WIP issue. Expect edits.

1. Documentation
What is the project about? How to contribute? How to build it? Can it be reused?
These are the question that should be answered in this section.
1.1 User-centric

[ ] What is this project about. What sets it apart from similar projects and why should people use it.
[ ] Maybe allow GitHub discussions

1.2 Developer-centric

[ ] https://github.com/AaruBama/memestr/issues/51 (How to build and run the project)
[ ] Add contributing guide
[ ] Add security guide

1.3 Ops

[ ] Introduce issue templates (explain how to best describe the issue)
[ ] Introduce PR templates (explain how to best describe the issue)
[ ] Edit the project description and set the link to the live app there

2. Clean code
Clean code makes it easier to onboard new developers.

[x] https://github.com/AaruBama/memestr/pull/39
[x] https://github.com/AaruBama/memestr/pull/40
[x] https://github.com/AaruBama/memestr/pull/41
[x] https://github.com/AaruBama/memestr/pull/47
[ ] Remove unused and commented out code

3. Formatting rules and restrictions
Nobody likes to argue about "this" approach vs "that" approach. It's pointless, after all, and it is a huge waste of time.
The lack of formatting rules also makes diffs harder to read. Nobody cares about the whitespace changes.
Utilize tools that make all this fade into the background. Set and forget. Focus on writing code, and leave the formatting to the machine.

[x] https://github.com/AaruBama/memestr/pull/43
[x] https://github.com/AaruBama/memestr/pull/46
[ ] Introduce explicit eslint rules (https://github.com/AaruBama/memestr/pull/54)
[ ] Introduce CI checks that fail if code isn't formatted properly, or if some linting rules are broken (make this check required)

#62 fixes 1.1.
Maybe allow GitHub discussions , Sorry I didn't understand this part @nemanjaglumac

https://github.com/features/discussions

Ah that. I've enabled the discussions. Maybe we can start with an announcement of latest release and contribution guidelines.


Add team specific Wikis to Azure DevOps

Is your feature request related to a problem? Please describe.
When using Azure DevOps the Wikis are only available at the project level. Any member of the project could modify and read all the project wikis.
Describe the solution you'd like
It would be nice to have team level wikis, similar to boards and backlogs where only dev team members can have access to (not the whole project members).
Describe alternatives you've considered
Add security settings for wikis on a page by page basis. Only invited members can read or contribute the page, rather than one general security setting for all pages within the same project.
Additional context

Thank you for the feedback! Given that this is not related to docs.microsoft.com, we cannot address the issue in this forum.


Possible to fail when tiles aren’t written?

I just experienced this when running with properties for OpenAddresses:
  23.8%  3/4/2
  24.0%  3/4/2
  24.1%  3/4/2
tile 3/4/2 size is 530305 with detail 7, >500000
could not make tile 3/4/2 small enough

*** NOTE TILES ONLY COMPLETE THROUGH ZOOM 2 ***

So that’s fine, but I think the exit status must have been 0 because it continues to upload the tiles:
2017-05-01 20:56:52,961    INFO: Uploading oa-vpx0wpcf.mbtiles to Mapbox open-addresses's open-addresses.lec54np1
2017-05-01 20:56:53,051   DEBUG: GET /uploads/v1/open-addresses/credentials
2017-05-01 20:56:53,683   DEBUG: /tmp/oa-vpx0wpcf.mbtiles --> b8/_pending/gh0xxgo3kq23vf10mxbvl62jc/open-addresses

Could this be made an error instead? Or should I do something smarter to detect this case?

This is surprising because it intends to exit with EXIT_FAILURE after cleaning up in this case. I'll investigate. Thanks.

I am getting an error exit after intentionally setting a very small maximum tile size:
$ if ./tippecanoe -M100 -z1 -f -o foo.mbtiles ./tl_2015_06001_roads.json; then echo success; else echo failure; fi
…
could not make tile 1/0/0 small enough
*** NOTE TILES ONLY COMPLETE THROUGH ZOOM 0 ***
failure

Are you sure your wrapper script is checking the return value?
(I would also suggest using --drop-densest-as-needed or --drop-fraction-as-needed to drop enough features to make the tiles work instead of failing, but that's a separate issue.)

Looks like Python’s wrapper doesn’t raise an error when the return value is non-zero, so Tippecanoe is doing the right thing and I can fix on my end. Thanks for looking into this, sorry for the false alarm!
Is 500KB a Mapbox service limit?

Yes, the 500K limit is imposed by the Mapbox unpacker for the sake of rendering performance.

The 500KB limit is also a part of the philosophy of using vector tiles, if you are passing around too large of vector tiles there is an excessive amount of data you need to parse on any renderer. This also means larger file transfers to GL clients. In general the density of a 256x256 image on which a tile was originally based can not really show much more information after a point as you run out of visual space. The idea is to therefore to use a higher zoom level in these cases or limit the amount of data you are showing. We could revise it someday, but it would require a lot of thought.


Getting the Neo4j version fails on ubuntu

In case the neo4j-admin --version returns more then the semver version string, getting the version number fails.
E.g. locally on ubuntu 22.04 (and also in a CICD pipeline) neo4j-admin --version returns
WARNING: Max 1024 open files allowed, minimum of 40000 recommended. See the Neo4j manual.
4.2.19

Consequently, the version is not parsed as expected.
Proposed solution: get semver version string with a regex. I will provide a PR for this.

Hi @deeenes ,
This is a follow up fix of the recently merged PR.
Can you have a look at it?
Thanks in advance!


Create & Close still works when canCreate is false.

Another little item.
The Create and Close button displays and carries out its functionality where canCreate is disallowed for that DataObject.
P.S. Great module and I'm having success implementing it so far!

i made a small change in https://github.com/lekoala/silverstripe-cms-actions/commit/d8651e5f250a66bb7f6a0bfe75ee608d5b794f77
but the save itself is delegated to GridFieldDetailForm_ItemRequest::doSave that only checks "canEdit" so probably it's better to fix the framework itself

closing this, feel free to reopen if you think it needs further work


Add apphook config urlconf to settings

This PR adds an easy way to override the shipped urlconf with a custom one

Coverage decreased (-0.1%) to 95.636% when pulling 3e83bc8b7219ea9a445ff2c4b5689c61a33ea0d2 on feature/urlconf_settings into 958d392c6ada1bd40464b5bbf2cefb204ac2dc07 on develop.


remove code style from headings

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

aspnetcore/performance/caching/response.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Rick-Anderson Do you want code styles removed from all headings?

No need to actively remove them but I don't think heading look better without them.


Add in ssh tunnel

SSH tunnel required for mountain access.

Thanks @dmitryduev. Just lemme know when deployed and can go back to testing :)

@mcoughlin prod K is a bit out of date - there's this big stream_id-related update in the pipeline that's been recently merged and is currently being tested on staging on real data. You can test your stuff on staging in the meantime if you want - lmk.


Web interface doesn't allow to set option dhcpv4 'server' when using odhcp

Is there an existing issue for this?

[X] I have searched the existing issues

screenshots or captures
No response
Actual behaviour
When setting up the DHCP server for an interface, there's no way to specify option dhcpv4 'server' when using odhcp. This results in the default value being used, which disables the DHCP server for the interface.
Expected behaviour
UI allows to set the option.
Steps to reproduce

Switch to odhcp.
Create a new interface and enable DHCP for it (default options ok).
Send a DHCP discover on that interface... and get nothing back.

Additional Information
23.05.0

What browsers do you see the problem on?
No response
Relevant log output
No response

You mean -S here?: https://thekelleys.org.uk/dnsmasq/docs/dnsmasq-man.html
That is covered in the init file. Although where would it go? Under DHCP or in the interface section?

No, this is when not using dnsmasq but odhcp instead. The missing option should be in the interface section.


ISLP Labs for Linear Regression fails

In the chapter 3, Linear Regression,

new_df = pd.DataFrame({'lstat':[5, 10, 15]})
newX = design.transform(new_df)
newX

The above snippet throws the following errors:
---------------------------------------------------------------------------
SpecificationError                        Traceback (most recent call last)
Cell In[20], line 3
      1 new_df = pd.DataFrame({"lstat": [5,10,15]})
      2 print(new_df)
----> 3 newX = design.transform(new_df)
      4 newX

File [~/ISLP/islpenv/lib/python3.10/site-packages/pandas/core/frame.py:10166](http://localhost:8888/lab/tree/Chapter3/islpenv/lib/python3.10/site-packages/pandas/core/frame.py#line=10165), in DataFrame.transform(self, func, axis, *args, **kwargs)
  10163 from pandas.core.apply import frame_apply
  10165 op = frame_apply(self, func=func, axis=axis, args=args, kwargs=kwargs)
> 10166 result = op.transform()
  10167 assert isinstance(result, DataFrame)
  10168 return result

File [~/ISLP/islpenv/lib/python3.10/site-packages/pandas/core/apply.py:241](http://localhost:8888/lab/tree/Chapter3/islpenv/lib/python3.10/site-packages/pandas/core/apply.py#line=240), in Apply.transform(self)
    239 if is_dict_like(func):
    240     func = cast(AggFuncTypeDict, func)
--> 241     return self.transform_dict_like(func)
    243 # func is either str or callable
    244 func = cast(AggFuncTypeBase, func)

File [~/ISLP/islpenv/lib/python3.10/site-packages/pandas/core/apply.py:287](http://localhost:8888/lab/tree/Chapter3/islpenv/lib/python3.10/site-packages/pandas/core/apply.py#line=286), in Apply.transform_dict_like(self, func)
    284 if len(func) == 0:
    285     raise ValueError("No transform functions were provided")
--> 287 func = self.normalize_dictlike_arg("transform", obj, func)
    289 results: dict[Hashable, DataFrame | Series] = {}
    290 for name, how in func.items():

File [~/ISLP/islpenv/lib/python3.10/site-packages/pandas/core/apply.py:655](http://localhost:8888/lab/tree/Chapter3/islpenv/lib/python3.10/site-packages/pandas/core/apply.py#line=654), in Apply.normalize_dictlike_arg(self, how, obj, func)
    648 # Can't use func.values(); wouldn't work for a Series
    649 if (
    650     how == "agg"
    651     and isinstance(obj, ABCSeries)
    652     and any(is_list_like(v) for _, v in func.items())
    653 ) or (any(is_dict_like(v) for _, v in func.items())):
    654     # GH 15931 - deprecation of renaming keys
--> 655     raise SpecificationError("nested renamer is not supported")
    657 if obj.ndim != 1:
    658     # Check for missing columns on a frame
    659     from pandas import Index

SpecificationError: nested renamer is not supported

What's causing the blowup?

Re-initialising design as follows before the above invocations resolves the issue. That's missing in the lab text:
design = MS(["lstat"])

Will take a look and see if I can recreate this exception. Have not seen this error before and the exception does not refer to any line in ISLP as far as I can see
Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Linus Fernandes @.>
Sent: Wednesday, August 28, 2024 9:14:01 AM
To: intro-stat-learning/ISLP_labs @.>
Cc: Subscribed @.***>
Subject: Re: [intro-stat-learning/ISLP_labs] ISLP Labs for Linear Regression fails (Issue #27)
Re-initialising design as follows before the above invocations resolves the issue. That's missing in the lab text:
design = MS(["lstat"])
—
Reply to this email directly, view it on GitHubhttps://github.com/intro-stat-learning/ISLP_labs/issues/27#issuecomment-2315768134, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AACTM25OVDYELC6LM2U6VJ3ZTXZMTAVCNFSM6AAAAABNITNCA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJVG43DQMJTGQ.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

https://github.com/intro-stat-learning/ISLP_labs/blob/main/Ch03-linreg-lab.ipynb?short_path=2720fcd
Line 1251


Python3 fixes

I needed those two changes to get lxc-to-lxd working with the non-deprecated pylxd API.
I'm reasonably sure the the quote commit is properly backward compatible, I'm not so sure about the iteritems() one though, if it's not, we'll need a wrapper function which takes a dict and calls the right thing depending on python version.

Updated to use six, completely untested.

👍


fix: undefined export from eleventy package

I curiously started running into the following error today:
Package subpath './src/Plugins/RenderPlugin.js' is not defined by "exports" in<EMAIL_ADDRESS>imported from path/node_modules/eleventy-plugin-og-image/src/OgImage.js

Original error stack trace: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './src/Plugins/RenderPlugin.js' is not defined by "exports" in<EMAIL_ADDRESS>imported from path/node_modules/eleventy-plugin-og-image/src/OgImage.js
    at exportsNotFound (node:internal/modules/esm/resolve:299:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:646:9)
    at packageResolve (node:internal/modules/esm/resolve:824:14)
    at moduleResolve (node:internal/modules/esm/resolve:914:18)
    at defaultResolve (node:internal/modules/esm/resolve:1119:11)
    at nextResolve (node:internal/modules/esm/hooks:791:28)
    at resolve (file://path/node_modules/@11ty/eleventy/src/Util/EsmResolver.js:25:11)
    at nextResolve (node:internal/modules/esm/hooks:791:28)
    at Hooks.resolve (node:internal/modules/esm/hooks:238:30)
    at handleMessage (node:internal/modules/esm/worker:255:24)

This PR aims to address this problem by instead importing RenderPlugin from @11ty/eleventy and then extracting File from RenderPlugin.
Apologies if I'm overlooking something obvious!

Good morning! Which @11ty/eleventy version are you on? There were changes to the RenderPlugin in the latest alpha release where I already expected some hickups but didn't tested yet...

Sorry, I should have mentioned. This is indeed happening with version 3.0.0-alpha.18.

Updated package-lock.json and amended the previous commit message to refer to the correct alpha version!


remove wildcard query functionality

Like the kubernetes plugin we remove wildcard queries support.

I converted this to draft since it contains commit from #17, this is ready but #17 should be reviewed/merged first


Selective password hash synchronization and password writeback block password change for users outside of the selective password sync

Hello,
This page mentions :
Configuring selective password hash synchronization directly influences password writeback. Password changes or password resets that are initiated in Azure Active Directory write back to on-premises Active Directory only if the user is in scope for password hash synchronization.
But in my environments, I don't get this behavior:
When I enabled password writeback, I can change the password for users into the scope of the selective password sync. But users outside of this scope can't change their password from Azure AD anymore.
When a synced user (outside the scope of selective pass sync) try to change his password, I get a message about configuration problem on his account.
Azure AD Connect show event ID 6329 and 33002 (object cannont be found).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a28b3326-1302-1492-3961-0e1d59e12877
Version Independent ID: 7706e19b-5815-ca09-6095-35e98805f41d
Content: Selective Password Hash Synchronization for Azure AD Connect
Content Source: articles/active-directory/hybrid/how-to-connect-selective-password-hash-synchronization.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@bastienperez
Thanks for your feedback! We will investigate and update as appropriate.

Hi @bastienperez,
The article says,
"Password changes or password resets that are initiated in Azure Active Directory, write back to on-premises Active Directory, only if the user is in scope for password hash synchronization."
You say,
"When I enabled password writeback, I can change the password for users into the scope of the selective password sync. But users outside of this scope can't change their password from Azure AD anymore."
I may be misunderstanding your feedback, but the behavior you are describing seems to me to be in line with what is described in the article. Could you please clarify what changes you would like to see to the document and what you are seeing as inconsistent?

Hello @MarileeTurscak-MSFT
The problem is: why synced users outside the scope of selective pass sync are affected by password writeback?
My understanding from the doc is only people in the scope are subject to password writeback. Not all the synced users.

Thanks for the clarification. Just to confirm, are you saying that the users who are outside of the scope for password hash sync are still able to write back their passwords?

are you saying that the users who are outside of the scope for password hash sync are still able to write back their passwords?

The users outside the scope for pass sync are not able to writeback their passwords. Azure AD Connect shows some errors. But this is not really my problem.
My problem is the users outside the scope can't change their password at all (from Azure AD). As far as I understand from the Microsoft docs, the password writeback should occur only for users in the scope for pass sync, but it's not, it's occur for everyone (and failed for users outside the scope).

Thanks for clarifying. I made a pull request to add a note about the behavior for out-of-scope users. https://github.com/MicrosoftDocs/azure-docs-pr/pull/198837

Hello, I've got the same problem. The Microsoft doc is still not accurate.

Changing or resetting the pwd in azure ad needs to write back to on-prem ad and then sync its hash to azure, so if the user is outside of the password hash sync the pwd cannot be changed in azure~


Update compat entry for ChunkSplitters

We released a formally breaking version of ChunkSplitters (v2.0.0), but which does not affect most users. It won´t affect your package, so here I'm proposing the update of the compat entry to accept the 2.0 version.

Thanks!


Use testing data release 0.112

Usually we do this with whatever PR actually needs it

Usually we do this with whatever PR actually needs it

I guess so, but this specific release I need for testing MNE-BIDS 😅 wanted to add a test to MNE later

Then again, I can already add a test to this PR. Will update this branch.

@hoechenberger please merge when all green. thx


[8.0.0] Teleporter packet error.

When connecting to a server with a teleporter in the chunk. It throws an error and instant disconnects the player.
Crash log: http://pastebin.com/6khdX1h7

@aidancbrady I believe you rewrote this stuff recently, right?

Think i narrowed down the issue:
public FrequencyManager getManager(Frequency freq) on line 191 in TileEntityTeleporter returns null if(owner == null || freq == null). This seems to cause the line described in the stacktrace to crash.

Hmm. What's strange is that i actually can't reproduce this in an new world. Have to be some NBT data for v7 portals that is messing this up. But could cause potential issues with users upgrading to v8 and crashing because of this.

Indeed it is.  Just added a check for v7 teleporters, should be well now :)

Excellent :)


fix: remove double url encoding

Describe the bug:
In the case where use_redirect_for_req is set to true (it defaults to false), Samly is URL encoding the query string twice.
How to reproduce:
Consider the following iex snippet that aims to create reproduce the relevant section in Samly.AuthHandler.send_signin_req (I'm just using phoenix to create a test plug conn here):
Mix.install([{:phoenix, "~> 1.7.7"}, {:samly, "~> 1.3"}])
conn = Phoenix.ConnTest.build_conn()
idp = %Samly.IdpData{id: "some_id"}
sp = Samly.RouterUtil.ensure_sp_uris_set(idp.esaml_sp_rec, conn)
{idp_signin_url, req_xml_frag} = Samly.Helper.gen_idp_signin_req(sp, idp.esaml_idp_rec, idp.nameid_format)
Samly.RouterUtil.send_saml_request(conn, idp_signin_url, true, req_xml_frag, "12n2ceviquxiNUWJFagm1WvQfRLe7X5Z")

The result produces the following query string:
?SAMLEncoding=urn%253Aoasis%253Anames%253Atc%253ASAML%253A2.0%253Abindings%253AURL-Encoding%253ADEFLATE&SAMLRequest=fZBPT8MwDMW%25252FSpR7R5r%25252BGbXaToUdmDREtRYO3EIXQaTWGXE68fEpHZOYkHa0%25252FZ7988tXX0PPjtqRsVjwcCH4qsxJDf0BqtF%25252F4E5%25252Fjpo8m2RIMA8KPjoEq8gQoBo0ge%25252BgqR63IBcCDs5629me%25252F7Fcdygi7fx0n7MN0ag3SF6hL7gUMgpCEYi4DWOIbiGWr5y9nGEnL2frCc6g8nOHs%25252Bq8694ijYN2jXZH0%25252Bnn3fZnXP%25252FC3RncG3y%25252FzvV2EhE8tG0d1E9NOwGuC272YZqlcSQiKZfZMpUyTpJQRknGT9HB%25252FIYr85v%25252F1WWs5Tc%25253D&RelayState=98374897slksdf

You can reproduce the segment made by esaml by calling:
:esaml_binding.encode_http_redirect(idp_signin_url, req_xml_frag, :undefined, "12n2ceviquxiNUWJFagm1WvQfRLe7X5Z")

Resulting in:
"?SAMLEncoding=urn%3Aoasis%3Anames%3Atc%3ASAML%3A2.0%3Abindings%3AURL-Encoding%3ADEFLATE&SAMLRequest=fZBBT8MwDIX%252FSuT7RtKWolptp8IOTBqiWgsHbqGLIFLrjDid%252BPmUjkkgpB1tv2d%252Ffvnqc%252BjF0Xi2jgpQSwmrMmc99AesxvBOO%252FMxGg5ikhHjPChg9IROs2UkPRjG0GFTPWwxWko8eBdc53r4Zbns0MzGh%252Bk%252BiA3zaDbEQVMoIJJRvFByIZNWJZhIjLMXEM9n2MkLYj3BWdJh7oCozrvuHPE4GN8Yf7Sdedptv8f1D9ytpb2lt8tcrycR433b1ov6sWknwHUBdq%252FSLE1imcSZSm%252FiVF5nSqlMSThFh%252FMbvsyv%252Fld%252FYy2%252FAA%253D%253D&RelayState=12n2ceviquxiNUWJFagm1WvQfRLe7X5Z"

Which shows that the SAMLEncoding url parameter is already correctly URL encoded. Seeing that that field is hardcoded into esaml (the deflate field) and not controlled by any supplied input, I'm sure the underlying uri_string:compose_query is sufficient to URL encode the query parameters.
I can reproduce this bug with a test SAML IdP setup in docker, and in a pre-production environment with a Microsoft AD setup, but the above snippets are just quicker to get to the same point.
There is still the issue that esaml also double encodes the SAMLRequest. Will link the PR to address that on this issue for reference when I've submitted that patch.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you!


Upload file header

Greetings,
I'm using the POST API call to upload a file in rocketchat, which will be set as an icon, logo afterwards.
Problem is that the default POST call is using application/json, but the file, which is an image, should be treated as multipart/form-data file.
Any suggestions how to change the header in that call?
Thank you in advance.

I need this too,
+1 for attention

you can change the header by setting api.basicHeaders['Content-Type'] = 'multipart/form-data; boundar=' however, im still trying to figure out how to generate the boundary part

although it may be technically possible to do this using the api interface, I ended up deciding to use the driver websocket interface, and it worked way better...
driver.sendMessage({
  msg: "Message goes here",
  rid: "RoomID goes here",
  attachments: [{
    fields: [{
      value: "File goes here"
    }],
    text: "File description goes here"
  }]
})

there are more fields that are allowed, these are just the ones that i used, for the full list of fields, take a look at https://github.com/RocketChat/Rocket.Chat.js.SDK/blob/e507e86faf049751218a08f6488545ec77d33309/src/config/messageInterfaces.ts#L3

@djlazz3 can you be a bit more specific about the "File goes here" part ? I'm trying to simply post an image, I thought I got it to work with a message of the form :
{
  title: "some title",
  attachments : [{
    image_url: "data:image/png;base64,..."
  }]
}

but the android app does not handle data uris. I've tried since then to use an api post at rooms.upload but I can't get it to work, I get answered that application/json is not supported. I got it to work using curl or python requests, but that's really ugly. Thanks for any help !

I finally managed to upload using the following code. Note that this was done in the context of a hubot robot, and I finally used its integrated http client which is an instance of a scoped-http-client, since the http client provided with this sdk messed up with the payload I built.
const upload = (robot, room, data) => {
  //data layout
  //{
  //  contents : filedata to upload
  //  format : format of the data, passed to Buffer.from
  //  mime : mime type of the data
  //  filename : name of the destination file on the chat
  //  options : { added as additional fields in the formdata
  //    key : value
  //  }
  //}

  //thanks to https://gist.github.com/tanaikech/40c9284e91d209356395b43022ffc5cc

  //build formdata for the data
  const uid = require('uid-safe') ;
  let boundary = uid.sync(18) ;
  let form = "" ;

  //options
  if(data.options) {
    for(const opt in data.options) {
      if({}.hasOwnProperty.call(data.options, opt)){
        form += `--${boundary}\r\n` ;
        form += `Content-Disposition: form-data; name="${opt}";\r\n\r\n${data.options[opt]}\r\n` ;
      }
    }
  }

  //file upload
  form += `--${boundary}\r\n` ;
  form += `Content-Disposition: form-data; name="file"; filename=${data.filename}\r\n` ;
  form += `Content-Type: ${data.mime}\r\n\r\n` ;

  const payload = Buffer.concat([
    Buffer.from(form, 'utf-8'),
    Buffer.from(data.contents, data.format),
    Buffer.from(`\r\n--${boundary}--\r\n`, 'utf-8')
  ])

  //not able to post fully through robot.adapter.api, the payload is messed up
  //api login
  robot.adapter.api.login().then( (ack) => {
    //api upload
    robot.http(robot.adapter.api.url)
    .header('X-User-Id', ack.data.userId)
    .header('X-Auth-Token', ack.data.authToken)
    .path(`rooms.upload/${room}`)
    .header('Content-Type', `multipart/form-data; boundary=${boundary}`)
    .post(payload)((err, response, body) => {
      if(err) {
        error.log(err) ;
      }
    })
  }) ;
}


We should always have a loading profile icon on feed.

Hi,
Sometimes I open the feed and some users profile icons do not appear Immediately (Take some time to load), then suddenly load and blinks on the screen. I think this is not good, so I suggest that all profiles on feed always show a loading profile icon with animation until the profile image is loaded. Something like what camelus.app does. See the video:
https://user-images.githubusercontent.com/1178856/213920235-8e4181ad-2999-4000-a1f9-7ae407a20d0c.mp4

We currently display a little robot before the image is downloaded.


Fixes error with providers that don't have model_id

Description
Fixes error with using the chain for providers that don't have model_id field.

cc @baskaryan


Add Doxygen check to Jenkins

Currently only Travis does the Doxygen check: https://github.com/cmu-db/terrier/blob/2d48e68108302ce8d4e9b82fcf7bb80efbaeee8c/.travis.yml#L42
We should add this to all 3 configurations in the Check stage of Jenkins. This would give us 100% CI coverage on Jenkins and allow us to eventually retire Travis.

How much does the group rely on the email notifications of build results from Travis?  If it's important, I can replicate that in Jenkins before Travis is actually retired.  If I remember correctly, all the necessary support is already there in the Jenkins master, it just needs to be configured or reconfigured correctly.

I've never noticed build result emails from Travis. I would say if they do exist, they're not important. Thanks Chad!


removing sample consoleWriter visual from tests

Hi @MatthLee, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Matt Lee (SQL)). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Reviewed 2 of 2 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io


Bug downloading Virus scan warning page from Google Drive URLs

Describe the bug
Recently, some issues were reported with URLs from Google Drive, where we were downloading the Virus scan warning page instead of the data file itself.
See:

#3758
#3773
#3784

Once the PR merged into master and until our next datasets library release, you can get this fix by installing our library from the GitHub master branch:
pip install git+https://github.com/huggingface/datasets#egg=datasets

Then, if you had previously tried to load the data and got the checksum error, you should force the redownload of the data (before the fix, you just downloaded and cached the virus scan warning page, instead of the data file):
load_dataset("...", download_mode="force_redownload")


-c fastbuild defaults to -O3, -c opt defaults to -O2

I may be mistaken, but in the default -c fastbuild mode rules_cuda doesn't pass any -O flags to nvcc, and since nvcc defaults to optimization level 3 it'll be building with -O3.
For -c opt it passes -O2: https://github.com/bazel-contrib/rules_cuda/blob/039ee7bf59790e4d8e7c279d298f618ab5b3d2b5/cuda/private/toolchain_configs/nvcc.bzl#L317
so this looks like -c opt actually results in less optimization?

This behavior is mirrored from https://bazel.build/docs/user-manual?hl=en#compilation-mode

opt means build with optimization enabled and with assert() calls disabled (-O2 -DNDEBUG).

But it seems for fastbuild that I missed

and don't optimize

I not sure if the -O0 will affect the opt level of device code or not. And I also cannot recall if it is the root cause of the absent of that flag. For me, the device code opt should always be enabled by default to avoid unexpected perf issue.

I not sure if the -O0 will affect the opt level of device code or not.

https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html#optimize-level-o, so it works for host code only, great.
But it should be carefull for clang:
https://github.com/llvm/llvm-project/blob/544b4c6d522fa78f65eb850160c0380a0100250d/clang/test/Driver/cuda-external-tools.cu#L31-L45
And https://reviews.llvm.org/D17111#349388

I looked at this again:

It's not actually clear what the default optimization level (for host code) is. The nvcc docs do not specify a default, contrary to what my first message said. The link I posted earlier specified the default for ptxas.
The ptxas default setting is indeed -O3, see here. How about we follow clang here, and use -O0 in dbg and fastbuild?

@siboehm Also updated for nvcc for win.

The ptxas  ... and use -O0 in dbg and fastbuild

Disagree for now. -Xptxas -O0 may make the compilation a bit faster. But also it may results in unuable binary due to heavily skew perf characteristics or not compilable due to too many template tricks.


Why is .tmux.conf.local separate if it is not empty?

To my understanding a local config file serves the purpose of me being to overload single config values that survive an update of the main config file. To achieve that I would assume that .tmux.conf was provided by Oh My Tux and .tmux.conf.local would be optional and empty.
Currently the project however provides both .tmux.conf and .tmux.conf.local, and both files are not empty. So if I want to update Oh My Tmux I will have to change a non-empty file, and later merge my modifications with the upstream changes.
Why is that? Why don't you just merge everything into .tmux.conf and let me optionally create an empty .tmux.conf.local?

Hello @nils-werner 👋
Having a ~/.tmux.conf.local is effectively optional.
The .tmux.conf.local sample file that comes with the repository comes both as a reference file and provides documentation.
The point of not merging everything into ~/.tmux.conf allows people to pull from Oh my tmux! and make their master branch evolve without having to deal with merge conflicts.

Currently the project however provides both .tmux.conf and .tmux.conf.local, and both files are not empty. So if I want to update Oh My Tmux I will have to change a non-empty file, and later merge my modifications with the upstream changes.

It seems you overlooked a crucial step. You're supposed to copy the ~/.tmux/.tmux.conf.local sample file to ~/.tmux.conf.local. Or you can skip this step if you're happy with all default settings.

I am not sure I fully understand...

So I only need ~/.tmux.conf and ~/.tmux.conf.local is optional. OK, I see that, but then my tmux is missing some eyecandy and does not look like the GIF in your README anymore. So technically, .tmux.conf.local is optional, but you're assuming people will be using it, right?
Where can I put my own modifications without changing either ~/.tmux.conf or ~/.tmux.conf.local?

OK, I see that, but then my tmux is missing some eyecandy and does not look like the GIF in your README anymore. So technically, .tmux.conf.local is optional, but you're assuming most people will likely be using both files, right?

Indeed GIF shows off what's possible among everything available.
Yes I assume people follow the installation instructions and create their own copy of .tmux.conf.local by copying from the repository and placing it in their home directory

Where can I put my own modifications without changing either ~/.tmux.conf or ~/.tmux.conf.local? I want to be able to apply my own customizations and bindings without changing any of these two files.

I'm wondering whether you symlinked ~/.tmux.conf.local instead of making a copy. When you make a copy, you can tweak the settings and add all the overrides you want in your own ~/.tmux.conf.local. Once you make a copy, the ~/.tmux.conf.local file lives outside the Oh my tmux! Git repository that you can update without having merge conflicts to solve.

Once you make a copy, the ~/.tmux.conf.local file lives outside the Oh my tmux! Git repository that you can update without having merge conflicts to solve.

Yes, but ~/.tmux.conf.local will still change from time to time and I won't be getting those changes.

Yes, but ~/.tmux.conf.local will still change from time to time and I won't be getting those changes.

That's correct. Pulling the repository will bring you mostly bug fixes.

I am proposing an alternative approach:

Rename .tmux.conf.local to .tmux.config.optional
Gitignore .tmux.conf.local

If I want to modify the behaviour of Oh my Tmux, I will have to create a file .tmux.conf.local where only my modifications live, and none of the upstream code.
Scenario 1: I want to load the optional eyecandy. I will put the line
source -q ~/.tmux.conf.optional

in my .tmux.conf.local. That way both .tmux.conf and .tmux.conf.optional will be updated on git pull and I will never have a conflict.
Scenario 1: I want to change the field tmux_conf_battery_bar_length.
I will put the content
source -q ~/.tmux.conf.optional
tmux_conf_battery_bar_length="5"

in .tmux.conf.local. Again, this change will never produce a conflict and all files from upstream can be updated without an issue.
Additional benefit: I can immediately see all my customizations, because they all live in one small file.

You're over engineering it.

Rename .tmux.conf.local to .tmux.conf.optional
Gitignore .tmux.conf.local

If I want to modify the behaviour of Oh my Tmux, I will have to create a file .tmux.conf.local where only my modifications live, and none of the upstream code.

This is exactly what you get when creating a ~/.tmux.conf.local that contains only a minimal set of directives.
And you can source -q ~/.tmux/.tmux.conf.local from ~/.tmux.conf.local if you want to.

Ah right.

And you can source -q ~/.tmux/.tmux.conf.local from ~/.tmux.conf.local if you want to.

Weirdly enough, when I do that, e.g.
source -q ~/.tmux/.tmux.conf.local

set -gu prefix2

tmux_conf_theme_left_separator_main='\uE0B0'  # /!\ you don't need to install Powerline
tmux_conf_theme_left_separator_sub='\uE0B1'   #   you only need fonts patched with
tmux_conf_theme_right_separator_main='\uE0B2' #   Powerline symbols or the standalone
tmux_conf_theme_right_separator_sub='\uE0B3'  #   PowerlineSymbols.otf font, see README.md

I am not able to override any variables from ~/.tmux/.tmux.conf.local

I am not able to override any variables from ~/.tmux/.tmux.conf.local

Yeah discovered that as well with current tmux.
This is a bug imho. It got me intrigued but I didn't manage to submit a patch yet.
In the meantime you can do
source -q ~/.tmux/.tmux.conf.local

setenv -g tmux_conf_theme_left_separator_main '\uE0B0'
...

Another workaround is to do this in your ~/.tmux.conf.local copy:
source -q ~/.tmux/.tmux.conf.local
source -q ~/.tmux.conf.optional

Also I didn't insist enough on the fact that having a ~/.tmux.conf.local copy that only contains
set -gu prefix2

tmux_conf_theme_left_separator_main='\uE0B0'  # /!\ you don't need to install Powerline
tmux_conf_theme_left_separator_sub='\uE0B1'   #   you only need fonts patched with
tmux_conf_theme_right_separator_main='\uE0B2' #   Powerline symbols or the standalone
tmux_conf_theme_right_separator_sub='\uE0B3'  #   PowerlineSymbols.otf font, see README.md

Will get exactly what you want: Oh my tmux! defaults + your overrides.

Related: tmux/tmux#3091


CHEBI:31236 please define

Could CHEBI: 31236 - aripiprazole please be curated and defined

Now curated. Thanks

Now curated. Thanks


Integrate with Codecov

Integrate with Codecov to make sure all the changes from PR improve the code coverage of tests.
Update the readme with the new badge.

Done in #20


Really fix languages

@mkoistinen @evildmp do this behavior look sane to you? See https://github.com/yakky/django-cms/blob/feature/fix_languages_update/cms/tests/page.py#L83-L91

Coverage remained the same at 90.78% when pulling 98e8cf0a235e06ae553bf67eeacc31aee9815a69 on yakky:feature/fix_languages_update into 5af564879b4222aa00a8ee27fbb7d1b3ae0cbde5 on divio:develop.

Wrong way to solve this. Closing this as the current implementation is better than thi fix


Handle setting eg. PATH in devenv better

Fixes #841

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

18 of 18 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 97.391%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
1428

Relevant Lines:
1458

💛  - Coveralls


refact: function selector of function fragments

Closing because this got old... opening a new one from revamp build branch with local linking working


Cannot find MyContract.setNetwork(network_id) method for truffle-v5

The method doc is: https://trufflesuite.com/docs/truffle/reference/contract-abstractions/#mycontractsetnetworknetwork_id
"truffle": "5.5.15",
"@typechain/truffle-v5": "workspace:^8.0.0",
"typechain": "workspace:^8.0.0",

Hi Leio i am shashi (771892)
i am verified that we can make some changes like "workspace: ^445.0.0"

we can add some kind of functions in the same workflow whit the content of 5.5.16


⚠ ClamAV has degraded performance

In 18ddff1, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in c1cdae5.


Add "Log messages to the console" recipe

See https://github.com/brson/rust-cookbook/issues/61
I choose to replace "Log a debug message to the console" and "Log an error message to the console" by just "Log messages to the console" (which covers info, warn and error), because recipe is (imo) almost the same for the various message levels. Maybe I'm wrong.
I'm still learning and need mentoring, maybe the quality of my PR is a bit poor. Anyway, thanks to @budziq for his precious help.
I could add a text description around this example later, but today I'm not really inspired (and to be fair I'm not fluent at all in english, so I'm a bit scared).

@budziq

as mentioned in #61 (comment) i would suggest making it a more advanced separate example. Something along the lines of "Creating a custom logger". As the trivial consol logging would be implemented in 5 line env_logger snippet

Then in #61:

I would argue that this example is more involved (and rich with important usecase) than minimal (~5 lines) one that would use env_logger. But one of the maintainers would have to decide ;)

I think I totally misunderstood what you wrote in https://github.com/brson/rust-cookbook/issues/61 AND I think I still don't understand! I thought you said "Your example is OK because it has some details". But now, I'm lost.
Thinking about it, I'm not sure anymore I have a sufficient level to do such a PR (english level+rust level+brain level). Honestly, what do you think? Can I give up? (cause maybe it's a waste of time, somebody else would have done better work) If not, will you have the patience to continue to help me

@rap2hpoutre You should definitely not give up :1st_place_medal: as you PR is almost perfect, and please note that this repository is an outreach program for people to learn and be a first step in contribution.
Honestly my english not top notch, so we might have misunderstood, so let me rephrase:

Basic logging can be implemented in a more standard way by utilizing env_logger with the smallest number of lines.
Your example a separate usecase that shows users how to create a basic custom logger that might write to file/ring bells or etc. And IMHO your example (after some polishing) could be included in the cookbook.

@budziq OK so I could:

Re-add the links to (void) "Log a debug message to the console" and "Log an error message to the console" and re-add their "placeholders"
Add one new link to "Create a basic custom logger"
Rename my example to "Create a basic custom logger"
Add a small description like: "Set a basic custom logger ConsoleLogger and log various messages to it" (not sure about the word "to")
Update intro.md after everything is OK

Right?

I agree with @budziq, this example is really valuable but not as the very first log example that we show. I think env_logger would be a better fit for "I just want the log messages to show up." Then we can have this example to show how to define a custom logger.
@rap2hpoutre please rename this example to something like "Log messages in a custom format" and tweak something trivial about it to make it custom, like:
println!("Rust says: {} - {}", record.level(), record.args());

Then please add an example above this one showing a minimal very basic use of env_logger.

@dtolnay Ok thanks. I updated my todo-list above your comment. Ok with this?

Yes that covers everything. Thank you!

Ok I will try to do it tomorrow!

I close this PR because:

It's in conflict, and it has no value to resolve it cause I made mistakes in my commits
My commits were dirty ("oops")
I deleted lines that I did not have to delete
The title, description, etc. are not anymore what it's about.

New clean (I hope) PR here: #74 (with the right title, description, no conflict, no random commit messages, etc.) Thanks to @budziq & @dtolnay for their help!!


Check For Un-Formatted Code

This module will check messages for code-like blocks and, re-post the
message with the proper formatting. If it is already formatted, ignore.

Made some tests and it seems to work. Thanks for your contribution!


Change emoji detection metric. Now draws it to a tiny canvas and chec…

…ks to see that it's all colourful

Looks good! 👍 🎉 🚢
On Chrome on OSX I lose one character (958 emoji vs 957 emoji), but Time To First Emoji doesn't seem to be impacted.
On iOS this version adds a few seconds to TTFE. Not sure how many folks will be using it that way. We can add a device/os/browser switch if needed, as this significantly improves the experience on Linux.