Problem of run sample_bashs

Hi, thanks for your work.
When I run sample_bashs for an easy test, I got the following errors:
pyparsing.exceptions.ParseException: Expected '}', found '='  (at char 1374), (line:67, col:16)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "exp_runner_finetune.py", line 608, in <module>
    clip_wh=[int(x) for x in args.clip_wh]
  File "exp_runner_finetune.py", line 58, in __init__
    self.conf = ConfigFactory.parse_file(conf_path)
  File "/home/pai/lib/python3.6/site-packages/pyhocon/config_parser.py", line 142, in parse_file
    return cls.parse_string(content, os.path.dirname(filename), resolve, unresolved_value)
  File "/home/pai/lib/python3.6/site-packages/pyhocon/config_parser.py", line 192, in parse_string
    return ConfigParser().parse(content, basedir, resolve, unresolved_value)
  File "/home/pai/lib/python3.6/site-packages/pyhocon/config_parser.py", line 455, in parse
    config = config_expr.parseString(content, parseAll=True)[0]
  File "/home/pai/lib/python3.6/site-packages/pyparsing/core.py", line 1134, in parse_string
    raise exc.with_traceback(None)
pyparsing.exceptions.ParseSyntaxException: Expected '}', found '='  (at char 1374), (line:67, col:16)

I am new in Neus and I just want to have a try, so how can I correct it and have a test?
Thanks for your reply.

I have fixed the bugs after adding , at the end of #67 and #68 of confs/finetune.conf.
Like
model {
  finetune_lod = 1,
  h_patch_size = 3,

  ...
}

Maybe different versions of dependencies have different implementations when parsing configure files.


An upcoming commit will improve the completeness page.
Let's close this.


Kibana and Elasticsearch containers deployed separately

I've been trying to deploy Kibana and Elasticsearch containers in different hosts, but Kibana container has not been able to find (or connect with) Elasticsearch. Any pointers?

This should be container configuration issue. feel free to reopen it if you still have issue


review assets building process

The Dockerfile has a flag to build assets or not, this is because the invenio-cli containerize does so and therefore there was a need to duplicate said part of the process. Why? Docker image caching?
Maybe the assets re-built should be done by invenio-cli update.

To put some context here:
There is actually 2 scenarios that the Dockerfile generated image is trying to satisfy:
1- local development / local containerized (under this model they fall in the same scenario)
2- kubernetes deployment
So far, we have taken the approach that the docker image can be made to contain assets for case 2- via $include_assets. The idea (maybe it was a restriction of kubernetes) being that we ship a completely packaged image to kubernetes and it just manipulates it. This image contains static assets in it.
The deployment image is "completely-packaged". On the other hand, the local containerized/development one is not quite: it uses docker volumes to hold data and in particular static assets. We do this so that the nginx container has access to assets that it didn't build / aren't in its container. If this explanation holds and I know nothing about kubernetes, I would suspect kubernetes is serving static assets via the uwsgi server rather than the nginx one or it does some magic to extract the assets into someplace where they can be served by nginx.
Ideally we want an equivalent of docker volume in kubernetes and I believe there are issues about that (sort-of).

What you explain is correct. As clarification on Kubernetes, just specify that it is serving statics through Nginx, therefore option b (t does some magic to extract the assets into someplace where they can be served by nginx.) applies.
Might not be for june. We might want to rethink the steps in the future of the CLI. I would like to find a way of avoid having the $include_assets, but still we need a fully packaged image for cloud deployments.
We can shelve this one for upcoming months WDYT?

Done in the new workflow: flag removed in the dockerfile, using docker cache.


0.15.16 - react-to-markup automount does not work after deploy

Locally JavaScript is being loaded and executed when using this option:
  "options": {
    "react-to-markup": {
      "opts": {
        "automount": true
      }
    }
  }

After a deploy (actually not sure how this is different from the local build) teh JavaScript doesn't work anymore. I get:
GET http://myurl.com/demo/molecules/undefined
GET http://myurl.com/api/react-mount/molecules/my-module 404 (Not Found)

Let me know if you need further details.

Thanks for reporting! I checked back with the project in question and verified this is fixed for<EMAIL_ADDRESS>The earliest patternplate-server version containing the fixes in question is 0.16.4. I'd recommend to update to 0.18, so I opened a PR on the project 🚀.
Feel free to reopen if the problem persists.
Relevant changes

undefined references sinnerschrader/patternplate-server#14f1df5
missing component js sinnerschrader/patternplate-server#14f1df5


Update sbt-scalafix to 0.11.0

Updates ch.epfl.scala:sbt-scalafix from 0.10.4 to 0.11.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" }
}]

labels: sbt-plugin-update, early-semver-major, semver-spec-minor, commit-count:1

Codecov Report
Patch and project coverage have no change.

Comparison is base (4f652ab) 50.58% compared to head (12fa757) 50.58%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #410   +/-   ##
========================================
  Coverage    50.58%   50.58%
========================================
  Files            5        5
  Lines           85       85
  Branches         2        2
========================================
  Hits            43       43
  Misses          42       42

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


microcom: init at 2019.01.0

Motivation for this change
A minimalistic terminal program which supports serial connections and RFC2217 telnet connections.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build microcom

Switched to fetchFromGitHub.

Cleaned up formatting, moved autoreconfHook to nativeBuildInputs.


Resolve code check issues for tern/utils/general.py

The issues raised by prospector for "tern/utils/general.py" are:
tern/utils/general.py
  Line: 66
    pylint: len-as-condition / Do not use `len(SEQUENCE)` to determine if a sequence is empty (col 15)
  Line: 86
    pylint: unidiomatic-typecheck / Using type() instead of isinstance() for a typecheck. (col 11)
  Line: 91
    pylint: unused-variable / Unused variable 'e' (col 4)

This change resolves these issues.
Tests: Tern on debian:buster produced an output of 22161 lines
Signed-off-by: Michael Rohan<EMAIL_ADDRESS>

@mkrohan Have you thought about submitting a PR with a list of commits touching one file at a time instead of waiting to have each commit merged?


REF: Hardcode Keras params

This implements hardcoding of common Keras parameters in BaseWrapper.__init__ as discussed in #37.
The parameters chosen come from Model.compile, Model.predict and Model.fit. Parameters were not hardcoded if:

They don't make sense for Scikit-Learn/Numpy arrays (for example, steps_per_epoch).
Should be fed to fit directly because they depend on the data (ex: sample_weights, class_weights). I think validation_data also falls into this category, but I am not sure if this makes much sense to implement since AFAIK this is not used anywhere else in Scikit-Learn. I am going to leave this for another PR where I'll also deprectate fit's **kwargs.

Codecov Report

Merging #47 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   99.52%   99.50%   -0.02%
==========================================
  Files           3        2       -1
  Lines         418      408      -10
==========================================
- Hits          416      406      -10
  Misses          2        2

Impacted Files
Coverage Δ

scikeras/wrappers.py
99.70% <100.00%> (-0.01%)
:arrow_down:

scikeras/__init__.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d88825...5ce3332. Read the comment docs.

tagging @stsievert in case you want to take a look

@stsievert do you think we are good to go here or is there anything else you see that should be changed?

There might be some missing parameters

The reasons they are not being included are:

steps_per_epoch: the docs say This argument is not supported with array inputs so I think it only makes sense for tf.data, which we do not support here.
sample_weight: this is/will still be handled in fit like Scikit-Learn does.
class_weight: I think this one requires a bit of massaging to make Scikit-Learn's interpretation of this (ref) match up with Keras' (ref). I think Keras maps "integer class indices" to weights while Scikit-Learn maps "class labels" to weights. I'd like to leave this for a separate PR.

Regarding max_epochs/epochs.
I think what Keras does is that it runs for epochs-initial_epoch epochs. Are you proposing that instead we just have a single parameter max_epochs and always start at epoch 0?
And separately, you are suggesting that partial_fit override whatever max_epochs was set to and pass epochs=1 to model_.fit?

And separately, you are suggesting that partial_fit override whatever max_epochs was set to and pass epochs=1 to model_.fit?

Yes. Scikit-Learn's SGDClassifier/SGDRegressor/MLPClassifier do the same thing. Here's the docstring for MLPClassifier.partial_fit: "Update the model with a single iteration over the given data."

I think what Keras does is that it runs for epochs - initial_epoch epochs. Are you proposing that instead we just have a single parameter max_epochs and always start at epoch 0?

I think the difference is semantic. I don't think it's super important. max_epochs provides a little more leeway to perform some early stopping. Sticking with the Keras API isn't a bad choice I think.
I mention it because Scikit-Learn calls this parameter max_iter. In the documentation they always mention max_iter is "the maximum number of passes over the training data (aka epochs)."

Hmm okay. I think what I'd like to do is keep this PR smallish and leave the following parameters for a future PR (that can also contain any logic related to their handling, like what you mention about fit and epochs).

class_weight
epochs/initial_epoch/max_epochs
So I'll remove epochs from here.


Bug Report - "Web Application should only be accessible over HTTPS" policy not having desired effect

**Describe the bug : We have applied the policy "Web Application should only be accessible over HTTPS" with deny effect howevver we are able to create resource (Web-app) with http only.
Steps to reproduce : This issue is reproducable and please confirm if this is by design. I am assuming that once deny policy has been implemented/assigned  to a scope, it must deny to create resource if policy has been implemented.

Hello,
Can we have setup a quick call to discuss this over remote as I am able to create resource post deployment of policy.
@.***
It must stop creation of new webapp without https but it is not working as expected.
Regards | Dev
From: Jack Tracey @.>
Sent: Thursday, April 7, 2022 6:51 PM
To: Azure/Enterprise-Scale @.>
Cc: Dev Kumar @.>; Mention @.>
Subject: Re: [Azure/Enterprise-Scale] Bug Report - "Web Application should only be accessible over HTTPS" policy not having desired effect (Issue #950)
Hey @Dev-MSFThttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FDev-MSFT&data=05|01|Kumar.Dev%40microsoft.com|5fb7e18e8c8f42169e2c08da189983a1|72f988bf86f141af91ab2d7cd011db47|1|0|637849344894043400|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=3NvI1ASdsDNYymq5x%2BU7JXEiSkxTMV115WldzHhSucs%3D&reserved=0,
Thanks for raising this issue, I have tested this policy this morning and it does work as expected:
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F41163455%2F162206759-e3f09355-aff6-4687-bae5-35ac93824d85.png&data=05|01|Kumar.Dev%40microsoft.com|5fb7e18e8c8f42169e2c08da189983a1|72f988bf86f141af91ab2d7cd011db47|1|0|637849344894093436|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=NnjZyOBZGe8zwVy%2BgdFJ83nFp%2FI%2BVOqNJFkDIb51Kk0%3D&reserved=0
Could you provide some more info on your testing and how you repro the issue?
Thanks
Jack

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2FEnterprise-Scale%2Fissues%2F950%23issuecomment-1091730102&data=05|01|Kumar.Dev%40microsoft.com|5fb7e18e8c8f42169e2c08da189983a1|72f988bf86f141af91ab2d7cd011db47|1|0|637849344894093436|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=kw9wOEm5U3Cnj9WrZHbwXUNyG6m%2BpWPB%2FWRWAxepMWY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYTEMKHIHPN5TCTNRZUAWT3VD3ONHANCNFSM5SYKDS4Q&data=05|01|Kumar.Dev%40microsoft.com|5fb7e18e8c8f42169e2c08da189983a1|72f988bf86f141af91ab2d7cd011db47|1|0|637849344894093436|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=9rdQIH7hUZrxMBNzlXwIyojIi2%2FmrK941rJ5WTWoc70%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

Hi @Dev-MSFT,
How are you deploying this? Via the portal?
Reach out to me on "jack dot tracey at microsoft dot com" 😎
Thanks
Jack

Have chatted to @Dev-MSFT offline.
Policy is working as shown in my environment but could be related to the way its being created via portal in their environment and https://github.com/Azure/azure-policy#nonstandard-update-pattern-through-azure-portal


[SPARK-33845][SQL] Remove unnecessary if when trueValue and falseValue are foldable boolean types

What changes were proposed in this pull request?
Improve SimplifyConditionals.
Simplify If(cond, TrueLiteral, FalseLiteral) to cond.
Simplify If(cond, FalseLiteral, TrueLiteral) to Not(cond).
The use case is:
create table t1 using parquet as select id from range(10);
select if (id > 2, false, true) from t1;

Before this pr:
== Physical Plan ==
*(1) Project [if ((id#1L > 2)) false else true AS (IF((id > CAST(2 AS BIGINT)), false, true))#2]
+- *(1) ColumnarToRow
   +- FileScan parquet default.t1[id#1L] Batched: true, DataFilters: [], Format: Parquet, Location: InMemoryFileIndex[file:/Users/yumwang/opensource/spark/spark-warehouse/org.apache.spark.sql.DataF..., PartitionFilters: [], PushedFilters: [], ReadSchema: struct<id:bigint>

After this pr:
== Physical Plan ==
*(1) Project [(id#1L <= 2) AS (IF((id > CAST(2 AS BIGINT)), false, true))#2]
+- *(1) ColumnarToRow
   +- FileScan parquet default.t1[id#1L] Batched: true, DataFilters: [], Format: Parquet, Location: InMemoryFileIndex[file:/Users/yumwang/opensource/spark/spark-warehouse/org.apache.spark.sql.DataF..., PartitionFilters: [], PushedFilters: [], ReadSchema: struct<id:bigint>

Why are the changes needed?
Improve query performance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.

Test build #133045 has started for PR 30849 at commit 2da6885.

Test build #133045 has finished for PR 30849 at commit 2da6885.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133045/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37645/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37645/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37645/

Test build #133051 has started for PR 30849 at commit 090890c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37651/

Test build #133052 has started for PR 30849 at commit f4d8f6b.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37651/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37652/

Test build #133051 has finished for PR 30849 at commit 090890c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133051/

Test build #133052 has finished for PR 30849 at commit f4d8f6b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133052/

Test build #133139 has started for PR 30849 at commit c11dbd0.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37738/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37738/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37738/

Test build #133139 has finished for PR 30849 at commit c11dbd0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133139/


Publish 12/04/2019 3:32 PM PST

Docs Build status updates of commit 3734e57:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2012-ps/msonlinebackup/New-OBRetentionPolicy.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Aren't you exposing sensitive data that could be used by criminals?

Doesn't it lead to more deaths?

Hi,
Our system is based on data that is already openly shared. My judgment has been that I should not presume our analysis of it is better than what those engaged in the conflict have access to already via their intelligence agencies. We have had no official requests for it to be taken down. I hope that our analysis and data can have the opposite effect: that we allow better decisions to be made. At least one major IGO have requested help in how to use the system to brief their leaders, who make decisions about where to send aid.
All that said, I welcome any input on this difficult point.


Add constructor for box from box for compatible Y

Similar to how https://en.cppreference.com/w/cpp/memory/shared_ptr/shared_ptr has a constructor (9) that participates in overload resolution if Y* is compatible with T*, that can work for box<T>.
E.g. something like:
struct A
{
  int x;
};

struct B : A
{
  int y;
};

void example()
{
  immer::box<B> b;
  immer::box<A> a{b}; // should work
}

I don't think there should be concerns with object slicing since the values held are immutable and are not copied/moved by immer. I think implementation-wise this would mean a virtual function or some function pointer in the MemoryPolicy::refcount class that does deletion. What do you think?

Hmmm, I find the suggestion interesting, but I'm not sure supporting sharing in this case (instead of slicing) justifies the added complexity. In any case due to immutability the two cases (slicing or sharing) should be semantically equivalent.
If we go down this road, note that you are most probably using inheritance for composition. One could also consider this other use-case, which is actually supported by shared ptr as well:
struct A { ... };

sturct B
{
    A member;
};

void example()
{
    immer::box<B> b;
    immer::box<A> a{b.member, b};
}

I see what you mean. I'm going to give an extremely contrived example of my usecase:
struct Product
{
  int id;
};

struct Hat
{
  Color color;
};

struct CustomerOrder
{
  immer::box<Product> product;
};

We're writing a HatStore and we know all our products are going to be Hats. In order to avoid excessive templates, I'm keeping CustomerOrder as is, and don't want to have CustomerOrder<Hat>. Some component will want to look at box::immer<Hat> at some point so there will need to be some downcasting involved from Product to Hat.
Without downcasting, sharing and slicing would be semantically equivalent, I agree. Here I was trying to avoid putting more templates than necessary, and that involves "knowledge outside the type system" that all Products happen to be Hats for this particular application.

Hi!
Sorry for the late reply, I was on vacation :)
I see, that is a bit of an unorthodox design, I am unsure yet what the full consequences of that would be (How do you discriminate the types for downcasting? Is there a place where you can query any product? etc.).
Normally you would just store the id in the customer order, and somewhere else in your program you have a immer::map<id, Hat> for hats that you pass around when you need to use hats. (Alternativelly, you can use Product = variant<Hat, ...> and put that in the map).
If this is for a commercial project, send me an email, we can maybe arrange a contract to develop this feature in the library, but maybe I can help you review the design to avoid these pitfalls.


refactor group shared ptr

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Tian Chao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Warn about development kool version

Describe the feature
When you run kool run dev, the installed kool command is replaced by the one built locally. So the user can run it and forget to update kool back to a production version. It would be nice to warn the users that they are using a development version.
Backward compatibility concerns
Would this be BC? No
Use cases
The users are also kool contributors and run kool run dev to test a feature that they are developing and they forget to update kool back to a production version. If they start working on other projects with kool later, they might face some instabilities.

I like this! I guess we can make this safe with:

Change the default variable value to a constant, so we can later check whether the variable value is equal to such constant (meaning it is a development build).
On the root command PreRunPersistent we put a new service for this validation.
In such service, we check:

Are we running on a TTY? (I guess we should only warn about on TTY, so we know nothing will "break" inadvertently due to the output)
Is this a development build?
Now comes the trick part... for tests for example, the version will be development build - should we change it somehow (don't know if possible) to a testing build version?

After enumerating the items above I come to a different idea - what if instead of "warning" the user he/she is using a development build after they use it, we change the kool run dev to instead of override kool from PATH, to actually add a new koold - standing for kool development build, so the user still have original kool, and whenever they want they can use koold for testing the just built environment.
For debug purposes as well, maybe for this development build we could also attach to the version the short git commit, just so users can tell what development build they are running on exactly.
I am tending towards this second idea now that it came to light. Let's hear other thoughts!

Sometimes I like to override the original kool command, sometimes I don't. I usually like to replace it when I need to test the integration between the kool run command and any command without having to change kool.yml to do this.

That is a good point. What if, under a development build, we check for existing koold, and if so, replace any kool on kool run scripts to koold? Too hacky?

Let's add the warning only.

This has a merged implementation, will go into the next release 1.11.0


nss_wrapper: 1.1.7 -> 1.1.8

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/nss_wrapper/versions.
meta.description for nss_wrapper is: "A wrapper for the user, group and hosts NSS API"
meta.homepage for nss_wrapper is: "https://git.samba.org/?p=nss_wrapper.git;a=summary;"

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.1.8 with grep in /nix/store/gc0zg8sa74rizv948vmwrivf5mjm5220-nss_wrapper-1.1.8

directory tree listing: https://gist.github.com/1aef3c097aa48fbb0ead138e5b78d276

du listing: https://gist.github.com/3798ab08e69a876f3d918040377b81bb

Rebuild report (if merged into master) (click to expand)

10 total rebuild path(s)
3 package rebuild(s)
3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
autofs5
nss_wrapper
sssd

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/gc0zg8sa74rizv948vmwrivf5mjm5220-nss_wrapper-1.1.8 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A nss_wrapper https://github.com/r-ryantm/nixpkgs/archive/d9a17ecaceb6f35d85680db748ba62f1eb5c0899.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/gc0zg8sa74rizv948vmwrivf5mjm5220-nss_wrapper-1.1.8
ls -la /nix/store/gc0zg8sa74rizv948vmwrivf5mjm5220-nss_wrapper-1.1.8/bin

darwin is broken on hydra https://hydra.nixos.org/build/113179568


GitLab Pipeline Artifacts/Reports

As a developer, i trigger SCA scans from GitLab pipeline but i would like to see the results (security report with the list of the vulnerabilities) directly in the pipeline execution, either as log or - even better - as a job artifact.
Result would be a pipeline log that summarize all the findings or a job artifact (with the same content as the merge request generated by Frogbot) in HTML.

Hello @teodem and thank you for using Frogbot!
We already have this feature in our future plans! You will be able to see the scan results in the job's execution log.
Stay tuned for future updated!

Hi there, this links also to my last question.
I think it would be beneficial to display also the indirect dependencies. I know what the purpose of Frogbot is, but it would still make sense to report the vulnerabilities along with the pull request.
Otherwise i would need to use Jfrog CLI together with Frogbot for a complete overview of the vulnerabilities, which - in my opinion - increases complexity and maintenance.


feat/CI: Avoid running unit and ingest test when changes are limited to the changelog file

Is your feature request related to a problem? Please describe.
Currently, when any change is made to an open PR all CI jobs will run. This significantly extends CI time that is unneeded when the change is only a changelog update. We don't need to run unit/ingest tests for a changelog update.
Describe the solution you'd like
A check in the CI pipeline that only runs through the linting checks when the changes are limited to the changelog file.
Describe alternatives you've considered
Keep as is and accept extended CI runs for changelog updates

Being addressed by #1484


Eventually revert to upstream ini dependency

This is a reminder that we should revert #2255 once https://github.com/go-ini/ini/pull/115 is merged.

So Maybe we should delete the fork?

@lunny I think yes, we should.

@lunny @andreynering I just deleted it


could not load library "libc++_shared.so"

java.lang.UnsatisfiedLinkError: dlopen failed: could not load library "libc++_shared.so" needed by "libexample-00-helloworldRelease.so"; caused by library "libc++_shared.so" not found

For me I made it work by coping C:\Users\%username%\AppData\Local\Android\sdk\ndk-bundle\sources\cxx-stl\llvm-libc++\libs\%platform%\libc++_shared.so together in .apk
Also check in bx/scripts/toolchain.lua there are this lines:
	if _OPTIONS["with-android"] then
		androidPlatform = "android-" .. _OPTIONS["with-android"]
	end

By default it only builds for android-24 (which is 7.0+) and might be a bit new to your device.
I'm not sure why we need shared c++ lib in a first place though.

I did as you say,but it worked with a new error:
          java.lang.UnsatisfiedLinkError: dlopen failed: cannot locate symbol "__aeabi_memclr4" referenced by "/data/app/com.android.seriaport-2/lib/arm/libexample-00-helloworldRelease.so"...

@jimon

@hellojql yes, as I said, if you compile with android-24 and run on anything below 7.0 you will get __aeabi_memclr4 not found error. So: lookup your android version on a phone/tablet, convert it to API level here https://source.android.com/source/build-numbers and place correct value in bx/scripts/toolchain.lua, after that it should work.
PS. one line got dropped, there are this lines in toolchain file:
	local androidPlatform = "android-24"
	if _OPTIONS["with-android"] then
		androidPlatform = "android-" .. _OPTIONS["with-android"]
	end

just replace android-24 with whatever android-XX is corresponding to your device OS version, or use with-android option to pass this value externally

thanks,it works if I  load the lib as follow :
static {
        System.loadLibrary("example-00-helloworldRelease");
    }

but it fails in a NativeActivity ：
<activity android:name="android.app.NativeActivity"
            android:label="@string/app_name"
            android:screenOrientation="portrait">
            <!-- Tell NativeActivity the name of our .so (strip 'lib' and '.so') -->
            <meta-data android:name="android.app.lib_name"
                android:value="example-00-helloworldRelease" />
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />
                <category android:name="android.intent.category.LAUNCHER" />
            </intent-filter>
        </activity>

@jimon

@hellojql that's how android works, if your shared library needs any other shared library, you need to load it from Java, so just create proxy activity like this:
package %pkg_name%;
import android.os.Bundle;

public class %activity_name% extends android.app.NativeActivity
{
	static
	{
		System.loadLibrary("libc++_shared.so");
	}
}

and refer your %pkg_name%.%activity_name% in <activity android:name= field in android manifest.

@jimon Thanks for replying here! :+1:

what a nice day,thanks a lot! @jimon @bkaradzic

By the way,it seems that we should set ANDROID_NDK_CLANGwhich does not mentioned in here https://bkaradzic.github.io/bgfx/build.html. Is ANDROID_NDK_CLANG necessary? I use ndk-r14band  Ubuntu.
@jimon

@hellojql yeah it should, my current one on Windows:
set ANDROID_SDK_ROOT=C:/Users/%USERNAME%/AppData/Local/Android/sdk
set ANDROID_NDK_ROOT=%ANDROID_SDK_ROOT%/ndk-bundle
set ANDROID_NDK_ARM=%ANDROID_NDK_ROOT%/toolchains/arm-linux-androideabi-4.9/prebuilt/windows-x86_64
set ANDROID_NDK_MIPS=%ANDROID_NDK_ROOT%/toolchains/mipsel-linux-android-4.9/prebuilt/windows-x86_64
set ANDROID_NDK_X86=%ANDROID_NDK_ROOT%/toolchains/x86-4.9/prebuilt/windows-x86_64
set ANDROID_NDK_CLANG=%ANDROID_NDK_ROOT%/toolchains/llvm/prebuilt/windows-x86_64

thank you @jimon

I am confused that many so run with the same error as follows ：
backtrace:
A/DEBUG:     #00 pc 000396c2  /data/app/com.android.testnativeactivity-1/lib/arm/libexample-04-meshRelease.so (_ZN4bgfx7Context12createShaderEPKNS_6MemoryE+49)

Do you come across  the same error as me ? @jimon

I think you need to place example content to sdcard and add permission to read it ... could be other thing though, dunno.

it works,thanks!

I got a problem when I set as follows:
 local androidPlatform = "android-17"
	if _OPTIONS["with-android"] then
		androidPlatform = "android-" .. _OPTIONS["with-android"]
	end

  ....

	configuration { "android-*" }
		targetprefix ("lib")
		flags {
			"NoImportLib",
		}
		includedirs {
			"$(ANDROID_NDK_ROOT)/sources/cxx-stl/llvm-libc++/include",
			"$(ANDROID_NDK_ROOT)/sources/android/support/include",  // add to avoid complie error when platform is 17
			"$(ANDROID_NDK_ROOT)/sources/android/native_app_glue",
		}

after I set this , I can compiled  successfully,but it runs with black screen  in android 19. @jimon

@hellojql if it's about examples, you need to copy examples runtime data to sdcard and provide read access to sdcard in android manifest

also @hellojql first example should work just fine as it doesn't require resources

I GOT the answer,the shader is the problem

@jimon  A hero 4 years later


Update http://passportjs.org/guide/google/

The Passport JS "Google" page is recommending passport-google which is based on OpenID which I understand Google is deprecating. The page should be updated, probably to prefer passport-google-oauth.

the repo you linked was updated 2 years ago - is it still the preferred strategy?

They're both 2 years old, though the one I linked is slightly more recent within that year. Which seems to be the state of a number of passport extras. I'm unaware of whether there are any other Google OAuth projects that are newer. passport-google-oauth is the one I believe I'm using right now.

It appears that the passport-google strategy still recommended in the site's documentation is fully deprecated now, and does not work.


Broken link at end of 'Using an entity as the type of an attribute' section

The link to 'Converting logical entities into resolved entities' is broken, with the link code visible on the page

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 01f765fe-c882-24fc-19e3-79d800ddb030
Version Independent ID: 1029ed07-dac1-00d3-fff1-33af6c1c579d
Content: The Common Data Model logical definitions - Common Data Model
Content Source: common-data-model/sdk/logical-definitions.md
Service: common-data-model
GitHub Login: @MSFTMan
Microsoft Alias: Deonhe

@billgib  Thanks! We'll get this fixed.

@billgib This is is now fixed. Thank you.


Adding auth module with custom configuration creates roles with undefined names.

Describe the bug
Trying to add auth module with custom configuration creates two roles with undefined in the name:
RoleName: !If [ShouldNotCreateEnvResources, 'testam52d79772_sns-role', !Join ['',[ 'sns', 'undefined', !Select [3, !Split ['-', !Ref 'AWS::StackName']], '-', !Ref env]]]
...
RoleName: !If [ShouldNotCreateEnvResources, !Ref userpoolClientLambdaRole, !Join ['',['upClientLambdaRole', 'undefined', !Select [3, !Split ['-', !Ref 'AWS::StackName']], '-', !Ref env]]]

Amplify CLI Version
4.24.3
To Reproduce
# amplify add auth
Using service: Cognito, provided by: awscloudformation

 The current configured provider is Amazon Cognito.

 Do you want to use the default authentication and security configuration? Manual configuration
 Select the authentication/authorization services that you want to use: User Sign-Up & Sign-In only (Best used with a cloud API only)
 Please provide a friendly name for your resource that will be used to label this category in the project: testamplify52d7977252d79772
 Please provide a name for your user pool: testamplify52d79772_userpool_52d79772
 Warning: you will not be able to edit these selections.
 How do you want users to be able to sign in? Username
 Do you want to add User Pool Groups? No
 Do you want to add an admin queries API? Yes
? Do you want to restrict access to the admin queries API to a specific Group No
 Multifactor authentication (MFA) user login options: OPTIONAL (Individual users can use MFA)
 For user login, select the MFA types: SMS Text Message, Time-Based One-Time Password (TOTP)
 Please specify an SMS authentication message: Your authentication code is {####}
 Email based user registration/forgot password: Enabled (Requires per-user email entry at registration)
 Please specify an email verification subject: Your verification code
 Please specify an email verification message: Your verification code is {####}
 Do you want to override the default password policy for this User Pool? No
 Warning: you will not be able to edit these selections.
 What attributes are required for signing up? Email
 Specify the app's refresh token expiration period (in days): 30
 Do you want to specify the user attributes this app can read and write? No
 Do you want to enable any of the following capabilities?
 Do you want to use an OAuth flow? No
? Do you want to configure Lambda Triggers for Cognito? No
Successfully added resource testamplify52d7977252d79772 locally

Expected behavior
RoleName: !If [ShouldNotCreateEnvResources, 'testam955f59ac_sns-role', !Join ['',[ 'sns', '955f59ac', !Select [3, !Split ['-', !Ref 'AWS::StackName']], '-', !Ref env]]]
...
RoleName: !If [ShouldNotCreateEnvResources, !Ref userpoolClientLambdaRole, !Join ['',['upClientLambdaRole', '955f59ac', !Select [3, !Split ['-', !Ref 'AWS::StackName']], '-', !Ref env]]]

Desktop (please complete the following information):
# sw_vers
ProductName:	Mac OS X
ProductVersion:	10.15.5
BuildVersion:	19F101
# node -v
v14.5.0

Hi @akefirad
This issue has been fixed. You can try with the latest version.
Let me know if this works for you?

As far as I can see, no, the undefined is still there:
-      RoleName: !If [ShouldNotCreateEnvResources, 'wefarb1d2d5f67_sns-role', !Join ['',[ 'sns', '1d2d5f67', !Select [3, !Split ['-', !Ref 'AWS::StackName']], '-', !Ref env]]]
-      AssumeRolePolicyDocument:
+      RoleName: !If [ShouldNotCreateEnvResources, 'wefarb1d2d5f67_sns-role', !Join ['',[ 'sns', 'undefined', !Select [3, !Split ['-', !Ref 'AWS::StackName']], '-', !Ref env]]]
+      AssumeRolePolicyDocument:

Let me know what information you need to troubleshoot this.

Just to be clear, I manually changed the names (replaced undefined with the ID). That's why you see it's replacing the ID with a undefined.

Is there any update on this?

Is there any update on this?

Hi @akefirad
Just to reproduce , when you did amplify update auth, which of the following you selected
❯ Apply default configuration with Social Provider (Federation)
  Walkthrough all the auth configurations
  Create or update Cognito user pool groups
  Create or update Admin queries API

For your context ,we have refractored the auth category which has fixed this undefined bug, (though it will not affect any  working flow but still doesnt looks good) as previously this was occuring in auth manual configuration. The problem was we have an sharedID which we used to define sns role which was not being populated before in manual auth configuration.

Hi @akefirad
Just to reproduce , when you did amplify update auth, which of the following you selected
❯ Apply default configuration with Social Provider (Federation)
  Walkthrough all the auth configurations
  Create or update Cognito user pool groups
  Create or update Admin queries API

For your context ,we have refractored the auth category which has fixed this undefined bug, (though it will not affect any  working flow but still doesnt looks good) as previously this was occuring in auth manual configuration. The problem was we have an sharedID which we used to define sns role which was not being populated before in manual auth configuration.

Walkthrough all the auth configurations

Walkthrough all the auth configurations

Hi @akefirad
Closing this as it  has been resolved in our latest version(4.41.2). Feel free to comment if this issue still persists

Hi @akefirad
Closing this as it  has been resolved in our latest version(4.41.2). Feel free to comment if this issue still persists

I'm not sure if the fix is tested against existing stacks. Because it still generates names with undefined as show above.

I'm not sure if the fix is tested against existing stacks. Because it still generates names with undefined as show above.


⚠ SceneTime has degraded performance

In 9d9588a, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1252 ms

Resolved: SceneTime performance has improved in 3ac4ba5.


Circular dependency issue

This is about the issue of circular dependencies using onerobotics kUnit and Strings. I have put together the packages I am using in https://github.com/kobbled/rossum-test.

This is my output using a build folder at the top level of this project:
** rossum ../ -v **
INFO     | This is rossum v0.1.7
DEBUG    | Checking: c:\Users\matt\Dropbox\Programming\Git\rossum-test\KUnit\build\robot.ini
C:\Users\matt\Dropbox\Programming\Fanuc\rossum-0.1.4-distrib\rossum.py:267: DeprecationWarning: The 'warn' method is
deprecated, use 'warning' instead
"source space".format(ROBOT_INI_NAME))
WARNING  | No robot.ini in CWD, and no alternative provided, trying source space
DEBUG    | Checking: c:\Users\matt\Dropbox\Programming\Git\rossum-test\KUnit\src\robot.ini
INFO     | Found robot.ini in source space
C:\Users\matt\Dropbox\Programming\Fanuc\rossum-0.1.4-distrib\rossum.py:286: DeprecationWarning: The 'warn' method is
deprecated, use 'warning' instead
"settings!".format(ROBOT_INI_NAME))
WARNING  | Found robot.ini contains potentially conflicting ktrans settings!
INFO     | Found Roboguide version: V9.1098 (Rev.F)
DEBUG    | Most likely FANUC base-dir: C:\Program Files (x86)\FANUC
INFO     | Using C:\Program Files (x86)\FANUC as FANUC software base directory
DEBUG    | Trying to auto-detect ktrans location ..
DEBUG    | Looking in C:\Program Files (x86)\FANUC\WinOLPC\bin ..
DEBUG    | Found ktrans.exe in C:\Program Files (x86)\FANUC\WinOLPC\bin
INFO     | ktrans location: C:\Program Files (x86)\FANUC\WinOLPC\bin\ktrans.exe
INFO     | Setting default system core version to: V9.10-1
DEBUG    | Trying to find support dir for core version: V9.10-1
DEBUG    | Looking in C:\Program Files (x86)\FANUC\WinOLPC\Versions\V910-1\support ..
DEBUG    | Found V9.10-1 support dir: C:\Program Files (x86)\FANUC\WinOLPC\Versions\V910-1\support
INFO     | Karel core support dir: C:\Program Files (x86)\FANUC\WinOLPC\Versions\V910-1\support
INFO     | ktransw location: ktransw.cmd
DEBUG    | Using build file template: C:\Users\matt\Dropbox\Programming\Fanuc\rossum-0.1.4-distrib\build.ninja.em
INFO     | Source space(s) searched for packages (in order: src, args):
INFO     |   c:\Users\matt\Dropbox\Programming\Git\rossum-test\KUnit\src
INFO     |   c:\Users\matt\Dropbox\Programming\Git\rossum-test
DEBUG    | Searching in c:\Users\matt\Dropbox\Programming\Git\rossum-test\KUnit\src
DEBUG    |   found 1 manifest(s)
DEBUG    | Searching in c:\Users\matt\Dropbox\Programming\Git\rossum-test
DEBUG    |   found 4 manifest(s)
DEBUG    | Found 5 manifest(s) total
DEBUG    | Loaded package.json from c:\Users\matt\Dropbox\Programming\Git\rossum-test\KUnit\src
DEBUG    | Loaded package.json from c:\Users\matt\Dropbox\Programming\Git\rossum-test\errors\src
DEBUG    | Loaded package.json from c:\Users\matt\Dropbox\Programming\Git\rossum-test\Hash\src
DEBUG    | Loaded package.json from c:\Users\matt\Dropbox\Programming\Git\rossum-test\KUnit\src
DEBUG    | Loaded package.json from c:\Users\matt\Dropbox\Programming\Git\rossum-test\Strings\src
INFO     | Found 5 package(s) in source space(s):
INFO     |   KUnit (v1.0.0)
INFO     |   errors (v0.0.1)
INFO     |   Hash (v0.0.1)
INFO     |   KUnit (v1.0.0)
INFO     |   Strings (v0.0.1)
DEBUG    | Checking dependencies for: KUnit, errors, Hash, KUnit, Strings
DEBUG    |   KUnit - deps: Strings
DEBUG    |     satisfied
DEBUG    |   errors - deps: none
DEBUG    |     satisfied
DEBUG    |   Hash - deps: KUnit, Strings
DEBUG    |     satisfied
DEBUG    |   KUnit - deps: Strings
DEBUG    |     satisfied
DEBUG    |   Strings - deps: KUnit, errors
DEBUG    |     satisfied
DEBUG    | Resolving dependencies for: KUnit, errors, Hash, KUnit, Strings
DEBUG    |   KUnit
DEBUG    |     Strings: found
DEBUG    |   errors
DEBUG    |   Hash
DEBUG    |     KUnit: found
DEBUG    |     Strings: found
DEBUG    |   KUnit
DEBUG    |     Strings: found
DEBUG    |   Strings
DEBUG    |     KUnit: found
DEBUG    |     errors: found
DEBUG    | Resolving includes for: KUnit, errors, Hash, KUnit, Strings
DEBUG    |   KUnit
Traceback (most recent call last):
File "C:\Users\matt\Dropbox\Programming\Fanuc\rossum-0.1.4-distrib\rossum.py", line 783, in
main()
File "C:\Users\matt\Dropbox\Programming\Fanuc\rossum-0.1.4-distrib\rossum.py", line 437, in main
resolve_includes(all_pkgs)
File "C:\Users\matt\Dropbox\Programming\Fanuc\rossum-0.1.4-distrib\rossum.py", line 662, in resolve_includes
inc_dirs = dedup(resolve_includes_for_pkg(pkg))
File "C:\Users\matt\Dropbox\Programming\Fanuc\rossum-0.1.4-distrib\rossum.py", line 678, in resolve_includes_for_pkg
inc_dirs.extend(resolve_includes_for_pkg(dep_pkg))
File "C:\Users\matt\Dropbox\Programming\Fanuc\rossum-0.1.4-distrib\rossum.py", line 678, in resolve_includes_for_pkg
inc_dirs.extend(resolve_includes_for_pkg(dep_pkg))
File "C:\Users\matt\Dropbox\Programming\Fanuc\rossum-0.1.4-distrib\rossum.py", line 678, in resolve_includes_for_pkg
inc_dirs.extend(resolve_includes_for_pkg(dep_pkg))
[Previous line repeated 990 more times]
File "C:\Users\matt\Dropbox\Programming\Fanuc\rossum-0.1.4-distrib\rossum.py", line 674, in resolve_includes_for_pkg
abs_inc = os.path.abspath(os.path.join(pkg.location, inc_dir))
File "C:\Users\matt\AppData\Local\Programs\Python\Python37-32\lib\ntpath.py", line 526, in abspath
return normpath(_getfullpathname(path))
File "C:\Users\matt\AppData\Local\Programs\Python\Python37-32\lib\ntpath.py", line 472, in normpath
prefix, path = splitdrive(path)
File "C:\Users\matt\AppData\Local\Programs\Python\Python37-32\lib\ntpath.py", line 141, in splitdrive
p = os.fspath(p)
RecursionError: maximum recursion depth exceeded while calling a Python object

Changed to PR #31

#31 was merged, so closing this one.
Thanks again @kobbled for your contributions.


[8.x] Initialiaze traits when the model is being unserialized

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!


Ableist repository

This is very ableist as the sheer number of brightly flashing GIFs can cause seizures in those with epilepsy. Privacy and security should be inclusive, not exclusive.

I would also like to note that the security measures on this repository (locking issues, etc.) made it very difficult to post. Can you please stop gatekeeping your issues tab? Some people use other Git services like GitLab or Gitea and do not have an account on GitHub, making it impossible to raise important issues like these.


shrinkwrap to override gulp-cssnano dependencies

See https://github.com/olifolkerd/tabulator/issues/2581 for details

Closing as these changes are independent of your pull request to tabulator.


fixed small typo in challenge title

closes #6882

the bug  https://sourceforge.net/p/phpmyadmin/bugs/1696/

:+1:


Require email when creating checkout in API

Currently it is possible to create a checkout without an email:
checkoutCreate(input: {email:""}) {
    errors {
      field
      message
    }
    checkout {
      token
      email
    }
  }

As want to support tracking abandoned checkouts later, checkout without an email has no value from this perspective and would be removed anyway at some point.

I'm in the process of implementing the checkout and I was very surprised to discover that the email was required. Having to duplicate all the cart logic depending on whether the user is logged in or not — including calculations, numbers and currency formatting — would be a lot of useless work as well as useless code shipped to the client browser.
I think Saleor should leave the choice to the developer by not requiring the email, which would still allow to create anonymous checkout on the client-side only. I'll personally create checkouts with fake email address now as I don't have the time to implement it twice.
I'd be glad if you could reconsider this decision as I think it's quite opinionated without much benefit for the user nor the developer experience to be justified.

Is there any plan on changing this behaviour? Because even the new storefront implementation works around this limitation by using a dummy email address in case no email address is present when a product is added to the cart (https://github.com/saleor/react-storefront/blob/779d391419f667d0a2afa823289b14fdef973465/pages/[channel]/[locale]/products/[slug].tsx#L102)

We changed this not so long ago to not require email when creating a checkout instance. It is required to create a payment using the checkoutPaymentCreate mutation and to complete the checkout. This feature is already available in Saleor 3.1.


doc/ui: Skin documentation site to match Numberscope

Now the NavBar appears essentially unchanged when switching between
doc pages (like About or Documentation) and app pages (like the home
page and the 'scope itself).
Resolves https://github.com/numberscope/frontscope/issues/141.

Don't forget to npm install when pulling this PR.

Looks great on desktop, but when I tried to check how it would look on mobile, I noticed this:

I think we should try to avoid making the website look bad on mobile. It's true that users almost certainly won't want to use the app on mobile, but someone might discover it on mobile (e.g. via Twitter), and we need to make a good first impression.

@gwhitney, would it be difficult to fix this? To check how a site will look on mobile on Firefox, right click the page > Inspect > click the mobile devices icon.

Happy to fix. Not sure exactly when, although perhaps I can squeeze it in before I leave, as it should be quick. But what would really help is if you can provide specific feedback on the changes to the portrait view of the page you would like. Is there anything beyond the color mismatch at the top? I guess we should not repeat the word "Numberscope"; should there be anything in place of the second occurrence of Numberscope?
Having a hamburger menu both at the top right and near-top left is not ideal, but I am really not sure what to do about that: one is from the overall-site menu, and the other is from documentation navigation. So my feeling is that we should not sweat this too much as getting the mobile docsite just perfect is probably not worth our effort -- it just shouldn't look too amateurish/broken. That said, if you have any changes for the  portrait arrangement of the docsite navigation controls, especially ones that can be accomplished just with CSS, I am happy to take care of them. But at the moment very specific action items is really helpful given  the pressures on my time.

Perhaps add a media query for mobile that increases the height of the Numberscope navbar so that the docsite navbar is covered up?

I can try to fiddle with it if you're too pressed for time, @gwhitney.

Oh, wait I think covering up the docsite navbar would make it so that you can't navigate using the links in the sidebar on mobile. Hmm... I'll try to think of another solution.

If you want to fiddle, feel free, or just provide specific thoughts on what to do besides the color matching. I can likely get to it sometime tomorrow or Thursday. But I am  very reluctant to obscure all controls for navigating the documentation; I think there needs to be access to the doc outline.  Perhaps I can just color-match and remove all of the doc nav bar except for the doc's hamburger menu, revealing more space for the doc content underneath most of the site navbar, which we would leave alone to match the tool itself?  How does that sound?

How does that sound?

That sounds good.

OK, will try to get to this in the next day or two.

OK I found a few minutes to monkey around with this. How's the latest commit look?

The latest commit looks much better! Thanks @gwhitney. I'm going to merge. (I meant to comment this before merging.)


get_authenticated_users call is not honouring protocol at least at public_map

At least navigating to public_map of a visualization, if you go to the http version, the call to get_authenticated_users is attempted using https anyway, so it fails.
JS should detect request's protocol. Or use base_url javascript variable, which is present and correctly using the same protocol as request's.

There has been no activity on this issue for more several months. We are closing it. If you think this still needs to be addressed please open a new issue.


Add Toki Pona (tok) style guide

I would like to add an L10n style guide for Toki Pona (tok).
This request comes from the initial ask to add Toki Pona to Mozilla Common Voice here.
Creating the style guide is on-going; I will comment here when it is complete!

I've created pull request #208. Ideally, the commits in it should be squashed on merge; I can adjust on my end if that is necessary, as I did not see an option in Github to squash on merge. @peiying2 Let me know if you need any adjustments from me.
Some notes:

The document currently references a page on the Mozilla wiki which does not yet exist. I plan to create this page as soon as we have official word about the status of Pontoon/L10n; my account on the wiki (also @gregdan3) was approved yesterday.
This document has been tentatively approved by multiple other contributing users from Toki Pona's community. I expect to hear back from more users by the end of today, but I do not expect any more changes right now.
I've passed markdownlint locally, but it throws an error for a document I did not modify:

styleguides on  main [!] is 📦 v1.0.0 via  v17.3.0 ❯ npm test

><EMAIL_ADDRESS>test
> node node_modules/mozilla-l10n-docs-linter/linter/markdownlint.js

Using config file: /home/gregdan3/git/tokipona/styleguides/node_modules/mozilla-l10n-docs-linter/linter/markdownlint.json
Searching path: /home/gregdan3/git/tokipona/styleguides
/home/gregdan3/git/tokipona/styleguides/l10ndocs-linter/README.md: 5: MD025/single-title/single-h1 Multiple top level headings in the same document [Context: "# License"]


Setting object property with 'undefined' value to 'undefined' breaks immutability

🐛 Bug Report
const { produce } = require("immer");
const foo = { bar: undefined };

produce(foo, draft => { draft.bar = undefined; }) === foo;

This code evaluates to false when I would expect it to evaluate to true.

Please try again and follow the issue template


Workflow rejection reasons are not properly encoded

References

Fixes #1224

Description
Encode each segment that comes from the function's inputs separately with encodeURIComponent, instead of once at the end with encodeURI.
Instructions for Reviewers
See #1224 for steps on how to test.
List of changes in this PR:

do proper uri encoding in requestService.uriEncodeBody
add unit test

Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes TSLint validation using yarn run lint
[x] My PR doesn't introduce circular dependencies
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@bruno-atmire : If you could rebase this on the latest main, the CI/build process has just been fixed.  Once you pull in the fix, your tests should hopefully succeed.


Consider phasing out noop keybinding if underlying issues were indeed fixed

Bring back the default set of keyboard shortcuts.
https://github.com/stateful/vscode-runme/blob/4cda7c3fad906f5a7a76286866ada03c0deda1ca/package.json#L934-L1013

Is there a link to the original adverse effects? Were you using the same keybindings normally used by vscode notebooks?

Is there a link to the original adverse effects? Were you using the same keybindings normally used by vscode notebooks?

I'm gonna have to go dig a bit. don't know off hand. i believe we have some records of what didn't work in issues/PRs. i'll post them here.


Widgets initialized multiple times when inside nested repeat with dynamic repeat_count

Describe the bug
This issue essentially manifests itself as duplicated widget HTML elements.  In the following screenshot, there are three select_one questions with the title "Should only show one drop-down" in three nested repeats (each with only one entry).  You can see that the select in the outer repeat displays properly, but the nested selects have extra drop-down boxes displayed.

To Reproduce
Create a form with yes_no choices and the following survey:

type
name
label::en
appearance
repeat_count

begin group
group

field-list

integer
count
Repeat Count

begin repeat
outer_repeat
Outer Repeat

${count}

select_one yes_no
outer_select
Should only show one drop-down
minimal

begin repeat
middle_repeat
Middle Repeat

1

select_one yes_no
middle_select
Should only show one drop-down
minimal

begin_repeat
inner_repeat
Inner Repeat

1

select_one yes_no
inner_select
Should only show one drop-down
minimal

end_repeat
inner_repeat

end repeat
middle_repeat

end repeat
outer_repeat

end group
group

Open form
Enter 1 as the "Repeat Count"
See extra HTML elements...

Notes: This only seems to happen inside a nested repeat when one of the repeats has a dynamic repeat_count value which is set at runtime.  It also only happens for some widgets. I have recreated the issue with select_one/select_multiple when the minimal or autocomplete appearances are set and also for text fields using the url appearance.  But it does not happen for select_one/select_multiple when not using any appearance.
Expected behavior
Each question should only have single drop-down regardless of how deep they are nested in repeat groups.
Browser and OS:

OS: Pop!_OS 22.04
Browser: Chromium 112.0.5615.121
enketo-core: 5.18.1 (but can also re-create the behavior on getodk.org/xlsform)

Additional context
Based on my investigation, the duplicate elements are caused by the widgets in the repeats getting initialized multiple times (once for each repeat they are nested in).  Form some widgets/configurations this is fine, but for others it ends up adding duplicate elements to the page HTML. For example, the select widget and the url widget are both adding additional HTML elements to the DOM every time their _init() method is called.

Thanks for that detailed report! As you can see by looking at the nested repeats tag there are unfortunately a lot of issues specific to nested repeats. We're hoping to at some point have an opportunity to rethink how they're implemented but that will likely require targeted funding.
How common are nested repeats for you? It's something we try to discourage unless absolutely necessary. I would expect that with set entities (patients, facilities, etc) and links between them, your platform would prefer other approaches to represent hierarchical data.

@lognaturel thank you for the reply! Unfortunately, I expect that nested repeats are going to become more and more common in the CHT ecosystem. Historically I have not seen them used too often, but as more partners start to come up live on enketo-core 5.x+, they are very interested in pushing the limits of what they can do with repeats! :sweat_smile:
That being said, as you noted, there are probably alternative form implementations we can explore that would reduce the need for nested repeats.  I expect the nested repeats functionality is something we will continue to monitor and evaluate from our end regarding its priority and the need for investment in this area!
(Also, for context, here is the original CHT forum thread where this issue was initially raised.)


Some suggestion

I suggest the following changes:
Separate Class for each framework
have a class for each framework instead of passing a property framework string.
const session = new OakSession(…)

instead of
const session =  new Session({ framework: "oak" })

Framework instance instead of method  callings
pass a framework instance instead of calling use.
const session = new OakSession(app);

instead of
const session = new Session({ framework: "oak" });
app.use(session.use()(session));

Pass options during new calls
const session = new OakSession(app, { path: "/", httpOnly: true, secure: false })

instead of
app.use(session.use()(session, { path: "/", httpOnly: true, secure: false }))

Pass store instance instead of string
import { Session, SqliteStore } from "https://deno.land/x/session/mod.ts";
const store = new SqliteStore()
await store.connect()
const session = new OakSession(app, { store })

instead of
await session.init();

Maybe SqliteStore could even take a sqlite DB instance to have make it more flexible and if none is provided, create a new one.
Minor things

As a general suggestion, I would say that underscore properties/methods are not really necessary with typescript because we can use private instead. That would make the code a bit more readable.
I think there is an export missing for IStore in interface.ts. Maybe call the interface Store and the file store.ts instead?
simplify

if(Object.keys(this._sessionMemoryStore).includes(sessionId)) {
  return true;
} else {
  return false;
}

could be simplified to return Object.keys(this._sessionMemoryStore).includes(sessionId).
references: https://github.com/oslabs-beta/dashport/issues/39

Thanks @timreichen, I took many of your suggestions to heart and started a full rewrite of the library. It will take some time to get all of the original functionality back and will warrant a full version update. Here is the rewrite branch:
https://github.com/jcs224/deno_sessions/tree/rewrite

That is awesome! I looked over with fresh eyes today and thought of some more things. What would you think of:
Make subclasses of Store class
maybe add a Store class and make all other stores subclasses of it. This will prevent code duplication in the future and the session class can take Store as a type that will work with every Store.
SqliteStore with DB instance parameter in constructor
Maybe SqliteStore (or any other db to come) should take a DB instance instead of path. That would give the flexibility to use any sqlite connection and database repo they chose. I think this. would make the stores nice flexible wrappers.
const database = new DB("./database.db")
const store = new SqliteStore(database)

instead of
const store = new SqliteStore('./database.db')

add naming options
default to session but allow the user to change the table name. Same goes with the state.session property in OakSession. Would be nice to have that as default but configurable.
remove lib dir?
Maybe there is no real need for a lib if the store would live top level or in the stores dir? Couldn't Session and SessionData  be combined into Session? Seems the one just uses the other as a property and nothing else.
cleaner Store methods
I think it would make sense to have the methods be more like Map, Set or Indexeddb methods to give it more a js feel.
What would you think of

rename createSession to addSession
rename getSessionById to getSession
rename setSessionVariable to setSession and take an object instead of a single variable key and value. The update of the object should be done outside the function, for example:

const session = store.getSession(sessionId);
const updatedSession = {
...session,
newKey: "newValue"
}
const session = store.setSession(sessionId, updatedSession);

minor things

I would try to avoid any type if possible. There are a lot of cases still.
neat defaults:

constructor (store: Store=new MemoryStore()) {
  this.store = store
}

instead of
constructor (store?: any) {
    this.store = store || new MemoryStore
  }

Thanks, great suggestions again.
The only point I disagree on is making a generic Store class. What I'll probably do is create an interface to enforce certain functions being used for a storage driver. That will help ensure the driver is fully compatible with the library while giving driver creators ultimate flexibility how they implement it.
Overall, my goal is to push as much code out of the library users' code as much as possible. Definitely inspired by the Laravel / Rails ethos of convention over configuration.
Everything else, I'm on board with :smiley: fortunately, most of these improvements are in the guts of the library, not user-facing, so it shouldn't disrupt people who start using it.

The think making it a subclass will be helpful in the future in case of shared method/properties between different store types (like a logger for example). How the subclass implements the driver is still up to the user. I think it would make life a bit easier in the future, but that is up to you.

Thanks for your suggestion.
Also, with regards to TypeScript, I'm very new to it. I understand its benefits, but I only know the basics. Any help or contributions on how to improve that are welcome!


[Map] 2017skycity26

This map by Yrex, along with the other SP maps by the same author on the SP page, are for Unreal and not UT (meaning they won't run in UT with Oldskool but only in Unreal).

URL: https://unrealarchive.org/maps/unreal-tournament/single-player/0/2017skycity26_1af524f0.html
Hash: 1af524f0dae7bf4b5e10069b2afeef8387f759ac
Current name: 2017skycity26

Updated them all


Language tag request for Khamyang

Description
I wonder if we could register an OpenType language tag for Khamyang language. I'm currently working on a font where we'd like to implement letterforms that differ from the Tai Phake and Tai Khamti shapes. Maybe KHY  or KHYG would work?
Page URL
https://learn.microsoft.com/en-us/typography/opentype/spec/languagetags
Content source URL
https://github.com/MicrosoftDocs/typography-issues

Could we possibly also register an OT language tag for Geba (ISO 639-3 kvq)? We have tags for other Karen languages (S'gaw, Eastern Pwo, Western Pwo, Pa'O, Kayah) and I'd like to be able to control Geba shaping via LOCL rules.

'KSU ' has been registered for Khamyang. (The ISO 639 ID is used if there's no conflict and no need to distinguish.)
'KVQ ' has been registered for Geba Karen.


Fixed race condition: small block parallel upload

Seems to fix a race condition in block blob parallel uploads when blocks
are extremely small (1 KB). Need to continue watching for flakey tests
outlined in https://github.com/Azure/azure-sdk-for-net/issues/13221.

/azp run net - storage - ci

@kasobol-msft


Security kconfig cleanup

Kconfig cleanup to remove stuck symbol problem in Pelion and OpenThread.

Closing, included in the upmerge.


[BotContext] duplicate 'logException' assigning on context.logger

Here 'logException' shows up twice, is the second instance supposed to be a different string?

Closing issue per conversation with Stevenic, the original code has been removed.


fix: codeclimate badge

Closes: #57
Goal
Fix Code Climate integration.
Approach

Deleted and re-added repo in Code Climate.
Updated badge image-link

Pull Request Test Coverage Report for Build 712148904

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.094%

Totals

Change from base Build 710677079:
0.0%

Covered Lines:
123

Relevant Lines:
128

💛  - Coveralls

@wraasch merging since this isn't user-facing.


fix exponential subscription

When reconnecting, all active subscriptions prior to disconnection are getting re-subscribed :
https://github.com/askmike/deribit-v2-ws/blob/3a350198b514b4daa1839bc74fa5c26525d3f35f/connection.js#L115-L117
However, notice that they are also getting pushed in the table of subscriptions again :
https://github.com/askmike/deribit-v2-ws/blob/3a350198b514b4daa1839bc74fa5c26525d3f35f/connection.js#L280
This mean that the number of subscriptions will double every reconnection : 2^(reconnection + subscription - 1)
For example, with 2 subscriptions and after 5 reconnections you would end up with 64 subscriptions.
This pull request fix this by checking if the subscription is not already in the array of subscription.

Awesome find!

yes, my production code doesn't seem to run into this but the leak is definitely there. Mind picking up the syntax nit from @lacksfish? I'll merge straight after!

yes, my production code doesn't seem to run into this but the leak is definitely there. Mind picking up the syntax nit from @lacksfish? I'll merge straight after!

I'm surprised. My websocket was definetly hanging up and it seems that this bug is the root cause.
During/After maintenance, where the websocket server seems to code back up and down many times, the websocket client was definetly going crazy by sending tens of thousands of subscriptions message.

In production I am actually extremely careful around websocket closures (through the statusChange events), as such I don't get to reconnecting using this lib often.

Thanks @Xavier59  for the fix, I've released this in v1.0.10 (also on NPM).


Add scene store / recall to OnOff Cluster

Problem

Missing scene store / recall in OnOff cluster commands
Zll callbacks were still present but not used

Change overview

Added scene store / recall
Removed zll callbacks and includes

Testing

Automated testing to test changes
Automated testing for regressions

fast track: small delta, change made by a domain owner.


Disable Shipping V2 SymbolTask on OnPrem TFS

Once approved, I will cherry-pick this change to releases/m121 and releases/m122

@arunkm,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

take or close

Not required as we took alternate option of making combo selection explicit


nginx Log Spam with PHP 8.3

Hi, i recognized that the plugin makes a lot of extra lines on nginx log:
webmail.redacted.org, request: "POST /?_task=mail&_action=refresh HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php8.3-fpm.sock:", host: "webmail.redacted.org"
2024/11/14 21:30:14 [error] 690205#690205: *907408 FastCGI sent in stderr: "PHP message: PHP Warning:  Undefined array key "fetch_headers" in /var/www/vhosts/webmail.redacted.org/plugins/easy_unsubscribe/easy_unsubscribe.php on line 28" while reading response header from upstream, client: <IP_ADDRESS>, server: webmail.redacted.org, request: "POST /?_task=mail&_action=refresh HTTP/2.0", upstream: "fastcgi://unix:/var/run/php/php8.3-fpm.sock:", host: "webmail.redacted.org"

i am using Roundcube 1.6.9 with PHP 8.3 on Ubuntu 20 Focal. Any idea? i am not sure if this warning is new or old. But it creates really large logs.
i checked that code line in easy_unsubscribe.php but i am not sure what i should do here to fix or mute that warning

Hey @vmario89,
I've updated the file easy_unsubscribe.php with the change; this should fix the issue that's going into the log files.
https://github.com/SS88UK/roundcube-easy-unsubscribe/blob/a161ec7afa7a85e9094f6ef835f1db572b181293/easy_unsubscribe.php#L28

thank you very much for your quick look at this. you fixed it! thanks you


Suggest re-logging in when authentication error

Users get an error message when they don't have permission to do something:
Received a bad response from the API

Authentication error [code: 10000]

If you think this is a bug, please open an issue at:
https://github.com/cloudflare/wrangler2/issues/new

We should suggest re-logging in with npx wrangler login and trying again as a first troubleshooting step. This'll be common in particular for the new Pages commands which require a new OAuth grant (given the new additional scopes).

Unfortunately this error comes in a number of situations that aren't related to logging in. We can add the warning, but I hope it doesn't confuse when it doesn't confuse further when it doesn't fix the underlying problem. We should work further on the api side as well giving more specific errors.

@GregBrimble is this handled by the recent PR that added requireAuth() in Pages commands?

Closing this unless a consensus is made to attempt to login, I believe #1197 will help make authentication errors less confusing


Decreased warning verbosity

Muted freesasa warnings throughout code
Muted BiopythonWarning and RuntimeWarning in the notebook

first few lines of 2nd cell

Cleared notebook outputs

vast majority of the deleted lines are warnings in the output

Also, I believe that /tools/BioWrappers.py has no function, shall I delete it altogether?

Great! PR approved.

Also, I believe that /tools/BioWrappers.py has no function, shall I delete it altogether?

For me yes, I checked and it's never used indeed. @cbaakman Can we delete this module?

Great! PR approved.

Also, I believe that /tools/BioWrappers.py has no function, shall I delete it altogether?

For me yes, I checked and it's never used indeed. @cbaakman Can we delete this module?

The deeprankcore.feature.biopython module replaces BioWrappers.py 's functionality. So yes, it can be removed.


[feature] js_func (for javascript) equivalent of py_func

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
n/a
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
iOS, Android
TensorFlow installed from (source or binary):
n/a
TensorFlow version (use command below):
n/a
Python version:
n/a
Bazel version (if compiling from source):
n/a
GCC/Compiler version (if compiling from source):
n/a
CUDA/cuDNN version:
n/a
GPU model and memory:
n/a
Exact command to reproduce:
n/a

Describe the problem
I suggest adding a js_func that allows defining nodes in javascript. This would be similar to the existing py_func. There are many systems (ie iOS and Android) that have JS runtimes but do not have python runtimes.

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

Hi @cancan101, the body of the py_func will not be serialized in a GraphDef. Therefore, you should not use this function if you need to serialize your model and restore it in a different environment.
Also, if you are using TensorFlow.js for development, and are thinking about this in a JS-only context, would you mind re-posting this issue to the tensorflow/tfjs issues?
Thanks!

Interesting to know that the body is not serialized; I had not realized that. I was not thinking of js_func in the context of tfjs. Rather I was thinking of loading a graph on iOS or Android and using the js_func to supply user created functions.

/CC @andrewharp can you take a look since this is desired in mobile?

Nagging Assignee @andrewharp: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 44 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 59 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 74 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 89 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 104 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 123 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 139 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 154 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 169 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 184 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 199 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 214 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Nagging Assignee @andrewharp: It has been 229 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@cancan101,
Please let me know if my understanding is correct here. Looks like this isssue is more related to TensorFlow JavaScript, if you are using TensorFlow.js for development and thinking about this in a Javascript context, could you please try to post this issue to the tensorflow/tfjs issues
Thank you!

No, this is not a tfjs issue. This is about the ability to have a node that can run javascript, similar to the py_func node that runs python code.


Add logos + update Dreamweaver

Adds logos of:

Adobe Animate
Lua
https://github.com/pheralb/svgl/issues/276

Updates the logo of Adobe Dreamweaver to be more consistent with the rest of Adobe icons.

Thanks 🚀🚀


NSInvalidArgumentException, reason: 'data parameter is nil' when parsing FIRUser IDToken

[READ] Step 1: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request make sure the issue title starts with "FR:".

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general Firebase discussion, use the firebase-talk
google group.
For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.

[REQUIRED] Step 2: Describe your environment

Xcode version: 9.3
Firebase SDK version: 4.12.0
Firebase Component: Auth
Component version: 4.6.0

[REQUIRED] Step 3: Describe the problem
When trying to retrieve a user's firebase id token using .getIdToken(), this call stack is thrown:
	0   CoreFoundation                      0x00000001176b51e6 __exceptionPreprocess + 294
	1   libobjc.A.dylib                     0x00000001162c4031 objc_exception_throw + 48
	2   CoreFoundation                      0x000000011772a975 +[NSException raise:format:] + 197
	3   Foundation                          0x0000000115d05cf0 +[NSJSONSerialization JSONObjectWithData:options:error:] + 67
	4   eulerity-ios dev                    0x000000010dc2cd4c -[FIRUser parseIDToken:error:] + 261
	5   eulerity-ios dev                    0x000000010dc2ca3d __53-[FIRUser getIDTokenResultForcingRefresh:completion:]_block_invoke_2 + 82
	6   eulerity-ios dev                    0x000000010dc2d0c4 __51-[FIRUser internalGetTokenForcingRefresh:callback:]_block_invoke + 183
	7   eulerity-ios dev                    0x000000010dc27a97 __65-[FIRSecureTokenService fetchAccessTokenForcingRefresh:callback:]_block_invoke + 93
	8   eulerity-ios dev                    0x000000010dc2531e __38-[FIRAuthSerialTaskQueue enqueueTask:]_block_invoke + 114
	9   libdispatch.dylib                   0x0000000118b7c807 _dispatch_call_block_and_release + 12
	10  libdispatch.dylib                   0x0000000118b7d848 _dispatch_client_callout + 8
	11  libdispatch.dylib                   0x0000000118b85c41 _dispatch_queue_serial_drain + 1305
	12  libdispatch.dylib                   0x0000000118b86556 _dispatch_queue_invoke + 328
	13  libdispatch.dylib                   0x0000000118b8592d _dispatch_queue_serial_drain + 517
	14  libdispatch.dylib                   0x0000000118b86556 _dispatch_queue_invoke + 328
	15  libdispatch.dylib                   0x0000000118b823a0 _dispatch_queue_override_invoke + 726
	16  libdispatch.dylib                   0x0000000118b893c8 _dispatch_root_queue_drain + 664
	17  libdispatch.dylib                   0x0000000118b890d2 _dispatch_worker_thread3 + 132
	18  libsystem_pthread.dylib             0x00000001190a71ca _pthread_wqthread + 1387
	19  libsystem_pthread.dylib             0x00000001190a6c4d start_wqthread + 13

I did not experience this error prior to updating my pod file from 4.4.4 to 4.6.0.
I am getting the same error when I use the preferred method .getIdTokenForcingRefresh(Bool).
Steps to reproduce:
What happened? How can we make the problem occur?
This could be a description, log/console output, etc.
Using FirebaseAuth pod 4.6.0, call the instance method getIdToken() on the current firebase user.

I was just coming here to report this. I'm seeing it, along with 2 others - https://stackoverflow.com/questions/49771555/firebase-auth-error-data-parameter-is-nil-calling-getidtokenforcingrefresh
Easy repro (will crash):
    ```

let currentUser = Auth.auth().currentUser
currentUser?.getIDTokenForcingRefresh(true) { idToken, error in
if let error = error {
// Handle error
return;
}
        // Send token to your backend via HTTPS
        // ...
    }

It seems like Firebase found a workaround. If you run pod install a few library are downgraded:
Installing Firebase 4.5.0 (was 4.12.0)
Installing FirebaseAnalytics 4.0.4 (was 4.1.0)
Installing FirebaseAuth 4.3.1 (was 4.6.0)
Installing FirebaseCore 4.0.10 (was 4.0.19)
Installing FirebaseMessaging 2.0.6 (was 2.2.0)

After that it's working again.

I'm seeing the same issue but was able to fix it by

first logout on the prod (store) build
install & login on the debug build

Gosh. Our team spent 5 h on this task, thanks for hint to roll back to 4.11.0

When someone gets this working with downgraded Pods, it would be helpful to paste the Podfile in this thread for others.

I'm able to successfully use the below versions in my project. If you run pod install, Cocoapods will resolve dependencies for whatever is not in your Podfile.lock. As per Cocoapods docs,

For pods listed in the Podfile.lock, it downloads the explicit version listed in the Podfile.lock without trying to check if a newer version is available

My suggestion is to try replacing references to Firebase in your Podfile.lock with the following, until this issue is resolved by the Firebase SDK team:
PODS:
  - Firebase/Auth (4.8.2):
    - Firebase/Core
    - FirebaseAuth (= 4.4.2)
  - Firebase/Core (4.8.2):
    - FirebaseAnalytics (= 4.0.9)
    - FirebaseCore (= 4.0.14)
  - Firebase/Database (4.8.2):
    - Firebase/Core
    - FirebaseDatabase (= 4.1.4)
  - Firebase/DynamicLinks (4.8.2):
    - Firebase/Core
    - FirebaseDynamicLinks (= 2.3.2)
  - Firebase/Firestore (4.8.2):
    - Firebase/Core
    - FirebaseFirestore (= 0.10.0)
  - Firebase/Messaging (4.8.2):
    - Firebase/Core
    - FirebaseMessaging (= 2.0.8)
  - Firebase/Performance (4.8.2):
    - Firebase/Core
    - FirebasePerformance (= 1.1.1)
  - Firebase/Storage (4.8.2):
    - Firebase/Core
    - FirebaseStorage (= 2.1.2)
  - FirebaseAnalytics (4.0.9):
    - FirebaseCore (~> 4.0)
    - FirebaseInstanceID (~> 2.0)
    - "GoogleToolboxForMac/NSData+zlib (~> 2.1)"
    - nanopb (~> 0.3)
  - FirebaseAuth (4.4.2):
    - FirebaseAnalytics (~> 4.0)
    - "GoogleToolboxForMac/NSDictionary+URLArguments (~> 2.1)"
    - GTMSessionFetcher/Core (~> 1.1)
  - FirebaseCore (4.0.14):
    - "GoogleToolboxForMac/NSData+zlib (~> 2.1)"
  - FirebaseDatabase (4.1.4):
    - FirebaseAnalytics (~> 4.0)
    - FirebaseCore (~> 4.0)
    - leveldb-library (~> 1.18)
  - FirebaseDynamicLinks (2.3.2):
    - FirebaseAnalytics (~> 4.0)
  - FirebaseFirestore (0.10.0):
    - FirebaseAnalytics (~> 4.0)
    - FirebaseCore (~> 4.0)
    - gRPC-ProtoRPC (~> 1.0)
    - leveldb-library (~> 1.18)
    - Protobuf (~> 3.1)
  - FirebaseInstanceID (2.0.8):
    - FirebaseCore (~> 4.0)
  - FirebaseMessaging (2.0.8):
    - FirebaseAnalytics (~> 4.0)
    - FirebaseCore (~> 4.0)
    - FirebaseInstanceID (~> 2.0)
    - GoogleToolboxForMac/Logger (~> 2.1)
    - Protobuf (~> 3.1)
  - FirebasePerformance (1.1.1):
    - FirebaseAnalytics (~> 4.0)
    - FirebaseInstanceID (~> 2.0)
    - FirebaseSwizzlingUtilities (~> 1.0)
    - GoogleToolboxForMac/Logger (~> 2.1)
    - "GoogleToolboxForMac/NSData+zlib (~> 2.1)"
    - GTMSessionFetcher/Core (~> 1.1)
    - Protobuf (~> 3.1)
  - FirebaseStorage (2.1.2):
    - FirebaseAnalytics (~> 4.0)
    - FirebaseCore (~> 4.0)
    - GTMSessionFetcher/Core (~> 1.1)
  - FirebaseSwizzlingUtilities (1.0.0)
  - FirebaseUI (4.5.1):
    - FirebaseUI/All (= 4.5.1)
  - FirebaseUI/All (4.5.1):
    - FirebaseUI/Auth
    - FirebaseUI/Database
    - FirebaseUI/Facebook
    - FirebaseUI/Firestore
    - FirebaseUI/Google
    - FirebaseUI/Phone
    - FirebaseUI/Storage
    - FirebaseUI/Twitter
  - FirebaseUI/Auth (4.5.1):
    - Firebase/Auth (~> 4.2)
  - FirebaseUI/Database (4.5.1):
    - Firebase/Database (~> 4.0)
  - FirebaseUI/Facebook (4.5.1):
    - FBSDKLoginKit (~> 4.0)
    - FirebaseUI/Auth
  - FirebaseUI/Firestore (4.5.1):
    - Firebase/Firestore
  - FirebaseUI/Google (4.5.1):
    - FirebaseUI/Auth
    - GoogleSignIn (~> 4.0)
  - FirebaseUI/Phone (4.5.1):
    - FirebaseUI/Auth
  - FirebaseUI/Storage (4.5.1):
    - Firebase/Storage (~> 4.0)
    - SDWebImage (~> 4.0)
  - FirebaseUI/Twitter (4.5.1):
    - FirebaseUI/Auth
    - TwitterKit (~> 3.0)

We are also experiencing the same issue.

@bryanbartow try rolling back in the interim. Worked for us and we're able to keep moving forward.

@JaredHalpern Yep. Just rolled back to 4.11.0 and everything is back to normal. Thanks.

We're working on a fix. In the meantime, you can workaround by rolling Firebase back to 4.11.0 with FirebaseAuth 4.5.0.

The fix has been pushed to master from #1076 and we're working to get a 4.12.1 release deployed.
See the instructions here and use the 'master' tag if you'd like to try out the fix earlier.

Thank you @paulb777 & @morganchen12 !

4.13.0 is now published to CocoaPods with fix.

Still having this issue on 4.13. Rolling back to 4.11 for now. This really happened at an inopportune moment... That should teach me to update my pods right before release :/

Downgrading the library gives me the following linker error:
Undefined symbols for architecture arm64:
"_kFIRLoggerSwizzler", referenced from:
___63+[FIRSwizzler swizzleClass:selector:isClassSelector:withBlock:]_block_invoke in FirebaseMethodSwizzler(FIRSwizzler_360b26e2244d68994ab8f6788d06111b.o)
ld: symbol(s) not found for architecture arm64
Tried just about everything, still no go.

If anyone is having this issue on 4.13.0, please open a new issue and share your backtrace, Podfile, and Podfile.lock

@Nailer Same here. Looks like Google sign in works, but now Facebook sign in is broken.

@bryanbartow Yeah! That's exactly the login type I was struggling with yesterday.  It was midnight, and I needed to get that stuff sent to apple for review. 0/10 would not recommend.

@bryanbartow Are you getting an error/exception when signing into Facebook? Or when refreshing/force refreshing the token? Is it the same error at the beginning of this thread?

@protocol86 Crashing on [FIRUser parseIDToken:error:]. It's the same error I was getting earlier.

@bryanbartow please post a new issue with your stack trace and Firebase versions.


Unable to exit serial tool

When using ino serial I'm unable to exit by the documented method of "ctrl-a ctrl-x". Nothing happens when entering these key combinations. I've also tried the more Unix-standard ctrl-c, ctrl-q, and ctrl-z exit/suspend commands, but these are also ignored by ino serial.
I'm forced to kill the process, which is frustrating, especially since this needs to be done everytime before ino upload can begin uploading new firmware.

Thx, helpfull

Also if you use screen Ctrl-a conflicts.  The work around is easy:
Ctrl-a,a,Ctrl-x


chore(deps): update dotnet-sdk to v9 (major)

This PR contains the following updates:

Package
Type
Update
Change

mcr.microsoft.com/dotnet/runtime-deps
stage
major
8.0-alpine -> 9.0-alpine

mcr.microsoft.com/dotnet/sdk
final
major
8.0-alpine -> 9.0-alpine

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Not migrating to .NET 9 for now, it's in RC.

 You will not get PRs for any future 9.x releases. But if you manually upgrade to 9.x then Renovate will re-enable minor and patch updates automatically.
If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.


Just-released Safari TP 110 now supports VP9 via WebRTC

See https://webkit.org/blog/10929/release-notes-for-safari-technology-preview-110/ for details (as included in the new note.)

Thanks!


18 create admin app

This closes #18

Overview
Admin app let you add/remove/update users/links/categories/channels.

Testing scenarios

run AdminApp - fill inputs and check that the item you added/edited/removed is right in listbox at each tab.

Notes

We need to add option to allow us adding category for user


Vercel preview deployments broken due to urllib3 issue

Our preview deployments in Vercel are broken because they run in Amazon Linux 2 images, which only have very dated versions of Python, which use old versions of OpenSSL no longer supported by urllib3. This is the following issue: https://github.com/urllib3/urllib3/issues/2168
Official guidance from urllib3: https://urllib3.readthedocs.io/en/latest/v2-migration-guide.html#common-upgrading-issues
I have contacted Vercel support to ask if they have plans to switch build images / make it configurable. Installing Python from source is also possible but didn’t feel like the right thing. It looked like this:
# What we needed updated
yum install openssl11 openssl11-devel
# Dependency for pyenv installer
yum install git
# Dependency for pyenv fetching of Python source
yum install tar
# Dependencies for Python build from source
yum install gcc make patch zlib-devel bzip2 bzip2-devel readline-devel sqlite sqlite-devel openssl11-devel tk-devel libffi-devel xz-devel
# pyenv installer
curl https://pyenv.run | bash
# pyenv initialisation
export PYENV_ROOT="$HOME/.pyenv"
export PATH="$PYENV_ROOT/bin:$PATH"
eval "$(pyenv init -)"
# install desired Python version
pyenv install 3.11
# Switch to the new Python
pyenv shell 3.11

[… our actual project-specific installation steps …]

In the meantime, I’ve pinned our Vercel builds to use urllib3==1.26.16.

In the meantime, I’ve pinned our Vercel builds to use urllib3==1.26.16.

Out of curiosity, how did you do this?
Also, the urllib documentation mentions that we should pin urllib<2 instead of a specific version so that we continue getting security updates.

Good point! Here is the now-updated installation command:
npm install && python3 -m pip install -r requirements.txt && pip install urllib3<2 && python3 -m pip install -e .

It looks like Vercel recently introduced support for defining build commands in their configuration file (or I somehow never saw it until now) – if we did this, here is what our full configuration would look like:
{
  "installCommand": "npm install && python3 -m pip install -r requirements.txt && pip install urllib3<2 && python3 -m pip install -e .",
  "buildCommand": "npm run build && python3 -m sphinx -M html docs/ _build",
  "outputDirectory": "_build/html",
  "github": {
    "silent": true
  }
}

We no longer use Vercel for this theme, so I'm closing this. Preview deployments are now provided by RTD directly.


[now-cli] Fix signal-exit in yarn.lock

Fix https://github.com/zeit/now/pull/3490/files#r363418297.

I don't even really know if this is strictly necessary, since the tarball URL is still as expected. Seems to just be an annoying bug with yarn workspaces (where depending on which directory you run yarn from, sometimes this override is present in the lockfile and sometimes not).


Not able to create new release when access token is given using environment variable

Version 2.6.1
I am trying to publish a new version of app to AppCenter, and the distrubute command fails with error:

Error: failed to create release upload for ....ipa. Missing valid authentication token. Correlation ID: 06e24f3a-a11d-44ca-b100-4c75978d56ef

The same command works with CLI version 2.5.4 (verified by downgrading)
Auth token was provided using environment variable in both cases.

label:Distribute

This could be a side effect of the large changes introduced in #909. We'll circle back with the authors.