Packet buffer is NULL

I have my kinectv2 plugged into a USB 3.0 port, and am getting the following. I get the repeating error "[DepthPacketStreamParser] Packet buffer is NULL", and I also get "[CudaDepthPacketProcessorImpl] cudaGetDeviceCount(&deviceCount): unknown error". I have tried googling, but that got me nowhere. Any thoughts?
... logging to /home/e4e/.ros/log/c71f040c-9764-11e8-88a2-9cb6d0177589/roslaunch-e4e-GS63VR-6RF-18319.log
Checking log directory for disk usage. This may take awhile.
Press Ctrl-C to interrupt
Done checking log file disk usage. Usage is <1GB.
started roslaunch server http://e4e-GS63VR-6RF:36731/
SUMMARY
PARAMETERS

/imu_node/rate: 500
/imu_node/sensor_conf/6Deqbn/frame_id: imu_link
/imu_node/sensor_conf/6K7Fsi/frame_id: imu_link
/imu_node/sensor_conf/n3J/frame_id: base_ultrasonic
/imu_node/sensor_conf/n3J/max: 4.0
/imu_node/sensor_conf/n3J/min: 0.02
/kinect2_bridge/base_name: kinect2
/kinect2_bridge/base_name_tf: kinect2
/kinect2_bridge/bilateral_filter: True
/kinect2_bridge/calib_path: /home/e4e/catkin_...
/kinect2_bridge/depth_device: -1
/kinect2_bridge/depth_method: default
/kinect2_bridge/edge_aware_filter: True
/kinect2_bridge/fps_limit: -1.0
/kinect2_bridge/jpeg_quality: 90
/kinect2_bridge/max_depth: 8.0
/kinect2_bridge/min_depth: 0.1
/kinect2_bridge/png_level: 1
/kinect2_bridge/publish_tf: True
/kinect2_bridge/queue_size: 5
/kinect2_bridge/reg_device: -1
/kinect2_bridge/reg_method: default
/kinect2_bridge/sensor:
/kinect2_bridge/use_png: False
/kinect2_bridge/worker_threads: 4
/kinect2_points_xyzrgb_hd/queue_size: 5
/kinect2_points_xyzrgb_qhd/queue_size: 5
/kinect2_points_xyzrgb_sd/queue_size: 5
/rosdistro: kinetic
/rosversion: 1.12.13
/rtabmap/rgbd_odometry/approx_sync: True
/rtabmap/rgbd_odometry/config_path:
/rtabmap/rgbd_odometry/frame_id: kinect2_link
/rtabmap/rgbd_odometry/ground_truth_base_frame_id:
/rtabmap/rgbd_odometry/ground_truth_frame_id:
/rtabmap/rgbd_odometry/odom_frame_id: odom
/rtabmap/rgbd_odometry/queue_size: 10
/rtabmap/rgbd_odometry/wait_for_transform_duration: 0.2
/rtabmap/rtabmap/Mem/IncrementalMemory: true
/rtabmap/rtabmap/Mem/InitWMWithAllNodes: false
/rtabmap/rtabmap/approx_sync: True
/rtabmap/rtabmap/config_path:
/rtabmap/rtabmap/database_path: ~/.ros/rtabmap.db
/rtabmap/rtabmap/frame_id: kinect2_link
/rtabmap/rtabmap/ground_truth_base_frame_id:
/rtabmap/rtabmap/ground_truth_frame_id:
/rtabmap/rtabmap/map_frame_id: map
/rtabmap/rtabmap/odom_frame_id:
/rtabmap/rtabmap/odom_sensor_sync: False
/rtabmap/rtabmap/odom_tf_angular_variance: 1.0
/rtabmap/rtabmap/odom_tf_linear_variance: 1.0
/rtabmap/rtabmap/queue_size: 10
/rtabmap/rtabmap/subscribe_depth: True
/rtabmap/rtabmap/subscribe_scan: False
/rtabmap/rtabmap/subscribe_scan_cloud: False
/rtabmap/rtabmap/subscribe_stereo: False
/rtabmap/rtabmap/subscribe_user_data: False
/rtabmap/rtabmap/wait_for_transform_duration: 0.2
/rtabmap/rtabmapviz/approx_sync: True
/rtabmap/rtabmapviz/frame_id: kinect2_link
/rtabmap/rtabmapviz/odom_frame_id:
/rtabmap/rtabmapviz/queue_size: 10
/rtabmap/rtabmapviz/subscribe_depth: True
/rtabmap/rtabmapviz/subscribe_odom_info: True
/rtabmap/rtabmapviz/subscribe_scan: False
/rtabmap/rtabmapviz/subscribe_scan_cloud: False
/rtabmap/rtabmapviz/subscribe_stereo: False
/rtabmap/rtabmapviz/wait_for_transform_duration: 0.2

NODES
/rtabmap/
rgbd_odometry (rtabmap_ros/rgbd_odometry)
rtabmap (rtabmap_ros/rtabmap)
rtabmapviz (rtabmap_ros/rtabmapviz)
/
imu_node (tinkerforge_sensors/tinkerforge_sensors_node)
kinect2 (nodelet/nodelet)
kinect2_bridge (nodelet/nodelet)
kinect2_points_xyzrgb_hd (nodelet/nodelet)
kinect2_points_xyzrgb_qhd (nodelet/nodelet)
kinect2_points_xyzrgb_sd (nodelet/nodelet)
rgb_to_imu_tf (tf/static_transform_publisher)
rosbag_record_kinectv2 (rosbag/record)
auto-starting new master
process[master]: started with pid [18329]
ROS_MASTER_URI=http://localhost:11311
setting /run_id to c71f040c-9764-11e8-88a2-9cb6d0177589
process[rosout-1]: started with pid [18342]
started core service [/rosout]
process[rosbag_record_kinectv2-2]: started with pid [18359]
process[kinect2-3]: started with pid [18360]
process[kinect2_bridge-4]: started with pid [18367]
process[kinect2_points_xyzrgb_sd-5]: started with pid [18384]
process[kinect2_points_xyzrgb_qhd-6]: started with pid [18403]
[ INFO] [1533331973.413007328]: Loading nodelet /kinect2_bridge of type kinect2_bridge/kinect2_bridge_nodelet to manager kinect2 with the following remappings:
[ INFO] [1533331973.417676733]: waitForService: Service [/kinect2/load_nodelet] has not been advertised, waiting...
process[kinect2_points_xyzrgb_hd-7]: started with pid [18420]
process[imu_node-8]: started with pid [18435]
process[rgb_to_imu_tf-9]: started with pid [18447]
process[rtabmap/rgbd_odometry-10]: started with pid [18470]
process[rtabmap/rtabmap-11]: started with pid [18496]
process[rtabmap/rtabmapviz-12]: started with pid [18521]
[ INFO] [1533331973.468884969]: Initializing nodelet with 8 worker threads.
[ INFO] [1533331973.482252910]: waitForService: Service [/kinect2/load_nodelet] is now available.
[ INFO] [1533331973.551057648]: [Kinect2Bridge::initialize] parameter:
base_name: kinect2
sensor: default
fps_limit: -1
calib_path: /home/e4e/catkin_ws/src/iai_kinect2/kinect2_bridge/data/
use_png: false
jpeg_quality: 90
png_level: 1
depth_method: default
depth_device: -1
reg_method: default
reg_device: -1
max_depth: 8
min_depth: 0.1
queue_size: 5
bilateral_filter: true
edge_aware_filter: true
publish_tf: true
base_name_tf: kinect2
worker_threads: 4
[ INFO] [1533331973.743803294]: Starting node...
[ INFO] [1533331973.804525700]: Initializing nodelet with 8 worker threads.
[ INFO] [1533331973.804985881]: Initializing nodelet with 8 worker threads.
[Error] [CudaDepthPacketProcessorImpl] cudaGetDeviceCount(&deviceCount): unknown error
[Info] [Freenect2Impl] enumerating devices...
[Info] [Freenect2Impl] 8 usb devices connected
[Info] [Freenect2Impl] found valid Kinect v2 @2:19 with serial<PHONE_NUMBER>47
[Info] [Freenect2Impl] found 1 devices
[ INFO] [1533331973.829692704]: [Kinect2Bridge::initDevice] Kinect2 devices found:
[ INFO] [1533331973.829737190]: [Kinect2Bridge::initDevice]   0:<PHONE_NUMBER>47 (selected)
[ INFO] [1533331973.832932837]: Starting node...
[Info] [Freenect2DeviceImpl] opening...
[Info] [Freenect2DeviceImpl] transfer pool sizes rgb: 2016384 ir: 608*33792
[Info] [Freenect2DeviceImpl] opened
[ INFO] [1533331973.920674954]: [Kinect2Bridge::initDevice] starting kinect2
[Info] [Freenect2DeviceImpl] starting...
[ INFO] [1533331973.930604534]: rtabmapviz: Using configuration from "/home/e4e/.ros/rtabmap_gui.ini"
[ INFO] [1533331974.152765650]: /rtabmap/rtabmap(maps): map_filter_radius          = 0.000000
[ INFO] [1533331974.152791870]: /rtabmap/rtabmap(maps): map_filter_angle           = 30.000000
[ INFO] [1533331974.152803582]: /rtabmap/rtabmap(maps): map_cleanup                = true
[ INFO] [1533331974.152814038]: /rtabmap/rtabmap(maps): map_negative_poses_ignored = false
[ INFO] [1533331974.152823095]: /rtabmap/rtabmap(maps): map_negative_scan_ray_tracing = true
[ INFO] [1533331974.152832893]: /rtabmap/rtabmap(maps): cloud_output_voxelized     = true
[ INFO] [1533331974.152843780]: /rtabmap/rtabmap(maps): cloud_subtract_filtering   = false
[ INFO] [1533331974.152853122]: /rtabmap/rtabmap(maps): cloud_subtract_filtering_min_neighbors = 2
[ INFO] [1533331974.182776257]: rtabmap: frame_id      = kinect2_link
[ INFO] [1533331974.182810715]: rtabmap: map_frame_id  = map
[ INFO] [1533331974.182835593]: rtabmap: tf_delay      = 0.050000
[ INFO] [1533331974.182847950]: rtabmap: tf_tolerance  = 0.100000
[ INFO] [1533331974.182860886]: rtabmap: odom_sensor_sync   = false
[Info] [Freenect2DeviceImpl] submitting rgb transfers...
[Info] [Freenect2DeviceImpl] submitting depth transfers...
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Info] [Freenect2DeviceImpl] started
[ INFO] [1533331974.257529078]: [Kinect2Bridge::initDevice] device serial:<PHONE_NUMBER>47
[ INFO] [1533331974.257556119]: [Kinect2Bridge::initDevice] device firmware: 4.0.3916.0
[Info] [Freenect2DeviceImpl] stopping...
[Info] [Freenect2DeviceImpl] canceling rgb transfers...
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL
[Error] [DepthPacketStreamParser] Packet buffer is NULL

@frushton Hello my friend , I have the same problem.if  you solved it?

hi my friend ,i have the same problem, are you solved it?

Same here on ubuntu 16.04 with kinetic
steps to reproduce:
rosrun kinect2_viewer kinect2_viewer sd cloud
roslaunch kinect2_bridge kinect2_bridge.launch

LOL it's the OpenCV intall being used by default
You can fix by switch to CPU or fix the openCV install to the version they like:
rosrun kinect2_bridge kinect2_bridge _depth_method:=opengl _reg_method:=cpu

Check out this issue:
https://github.com/code-iai/iai_kinect2/issues/371

[Solution]
In issue #371, as highlighted by @fmacrae and @leviresende,
the solution is to simply do the following:

Go to kinect2_bridge.launch under kinect2_bridge package.
Change depth_method parameter value to opengl in line 12 of the file.
Change reg_method parameter value to cpu in line 14 of the file.


What happened to Linux builds on the Microsoft Edge WebDriver page?

One used to be able to find links to Linux builds on the Microsoft Edge WebDriver page. These links no longer appear to be there.
We were using these links to discover the appropriate Edge WebDriver version:
https://github.com/EFForg/privacybadger/blob/3703edfdaac28ea79aa13cf30c1406beac31c3e6/scripts/setup_travis.sh#L10
This is related to #39 / #40.
AB#41824748

Thanks. I've added this to our team's internal backlog to investigate.

Fixed.


ViewColumn Panel’s Close button does not work

ViewColumn Panel’s Close button does not work.
On inspecting, its found that the “X” button viewColumn Panel does not have button element.

@pranavtheway  thank reporting!
There's a problem with z-index.
found a bug.
I'll have to fix it soon.

Fixed in version 3.0.1


LuaPushable is not implemented for std::string::String

Sorry to bother you, again. The LuaPushable trait is not implemented for std::string::String, so Vec is still not a LuaPushable object. It seems like we need to implement this function. https://www.lua.org/manual/5.1/manual.html#lua_pushlstring

Manage to make it work, but I don't know if it is correct to cast const *u8 to const *i8
diff --git a/crates/luajit-bindings/src/pushable.rs b/crates/luajit-bindings/src/pushable.rs
index 39876f2..3e68c92 100644
--- a/crates/luajit-bindings/src/pushable.rs
+++ b/crates/luajit-bindings/src/pushable.rs
@@ -127,6 +127,17 @@ impl<T: LuaPushable> LuaPushable for Vec<T> {
     }
 }

+impl LuaPushable for String {
+    unsafe fn push(
+            self,
+            lstate: *mut lua_State,
+        ) -> Result<c_int, crate::Error> {
+        ffi::lua_pushlstring(lstate, self.as_ptr() as _, self.len() as _);
+
+        Ok(1)
+    }
+}
+
 /// Implements `LuaPushable` for a tuple `(a, b, c, ..)` where all the elements
 /// in the tuple implement `LuaPushable`.
 macro_rules! push_tuple {

It seems like Mlua crate is also using &[u8] for String

closed by 79130ba2c7fd6358181926baeba3e6c7934161c3


Prevent duplicate edges - one _from-_to combination only

Hi, I'm new to ArangoDB and while testing some codes I accidently created multiple edges, and I was wondering how to prevent this.
Example:
_key: 1, _from: "users/user1", _to: "movie/movie1", rate: "3"
_key: 2, _from: "users/user1", _to: "movie/movie1", rate: "3"
_key: 3, _from: "users/user1", _to: "movie/movie1", rate: "3"
Is there a build in way to prevent duplicate entries, like setting to disallow multiple entries of the same _from-_to combination? How do you handle this working with ArangoDB?

You can create a unique hash index on the fields _from & _to. See here for more information about unique hash index. This solution only works in a single server setup because a cluster does not allow unique indexes.


Customisable move/resize window mouse buttons

Addressing the issue #189.
Two new options added to berry and berryc
berryc move_button 1-5
berryc resize_button 1-5

Buttons Tested
1 - Left Mouse Button
2 - Scroll Button (Press Down on Scroll Wheel)
3 - Right Mouse Button

The modifications I've added also allows me to address the issue #117 .
I haven't fixed it yet but I can if you wish @JLErvin

I've made the changes mentioned.
Is there anything else I need to do?


SQL Provisioning topic needed minor update

Fixed one FWLINK in the topic.

@Selcin Thank you for raising this issue.  We're closing old issues.  If you feel this issue should remain open, please comment to let us know that the issue should be reopened.


climbStairs

Climbing Stairs Problem
This program provides a solution to the "Climbing Stairs" problem, a classic example of dynamic programming. The problem can be stated as follows:
Problem Statement:
A person is at the bottom of a staircase with n steps and wants to reach the top. They can take either 1 or 2 steps at a time. The task is to determine the number of distinct ways the person can reach the top of the staircase.
Approach:
Dynamic Programming:
This problem has overlapping subproblems, making it a suitable candidate for dynamic programming.
Define dp[i] as the number of ways to reach the i-th step.
The number of ways to reach step i is the sum of ways to reach the previous step i-1 and the step before that, i-2. This is because the person can arrive at step i by taking a single step from i-1 or a double step from i-2.
Thus, the recurrence relation is:
𝑑𝑝[𝑖]=𝑑𝑝[𝑖−1]+𝑑𝑝[𝑖−2]dp[i]=dp[i−1]+dp[i−2]
Base Cases:
If there are no steps (n = 0), there is 1 way (doing nothing).
If there is one step (n = 1), there is also 1 way to reach it.
Building the Solution:
Create an array dp of size n+1 to store the number of ways to reach each step up to n.
Initialize dp[0] = 1 and dp[1] = 1 as per the base cases.
Use a loop to fill the array from dp[2] up to dp[n] using the recurrence relation.
Finally, dp[n] will contain the number of distinct ways to reach the top of the staircase with n steps.
Example:
For n = 5, the program calculates the ways as follows:
dp[0] = 1
dp[1] = 1
dp[2] = dp[1] + dp[0] = 2
dp[3] = dp[2] + dp[1] = 3
dp[4] = dp[3] + dp[2] = 5
dp[5] = dp[4] + dp[3] = 8
So, there are 8 distinct ways to reach the 5th step.
Complexity Analysis:
Time Complexity: O(n) because we only need to compute each value in dp from 0 to n.
Space Complexity: O(n) for storing the dp array.
This dynamic programming approach efficiently computes the number of ways to climb the staircase, demonstrating how overlapping subproblems and optimal substructure can be leveraged to solve problems effectively.

@pankaj-bind kindly merge the pr . And if there is any issue kindly explain in detail what to change


gradle version update

Should fix a bunch of issues that start appearing with newer Android Studio

and
Unable to make field private final java.lang.String java.io.File.path accessible: module java.base does not "opens java.io" to unnamed module

Even 7.1.1 is pretty old. 8.2.1 is the newest version supported by current stable releases of Android Studio. I think the latest SDK also requires 8+. Can we go all the way to 8.2.1?

Even 7.1.1 is pretty old. 8.2.1 is the newest version supported by current stable releases of Android Studio. I think the latest SDK also requires 8+. Can we go all the way to 8.2.1?

Sure! Let's try


Added dark mode extension

Title: Dark Mode Extension
Description: This is chrome extension that changes day to dark mode vice-versa. This is applicable for all websites.
I added all the codes in the folder named dark mode extension.
Issue No:
#185
Tech stack: Html,css, javascript.
Output:

https://user-images.githubusercontent.com/72568715/159074590-e0420d8e-db65-4799-82d2-5cf27c8bb07a.mp4

Good work @Sulagna-Dutta-Roy
Thanks for contributing 💙


bugfix/379 > price label to be different for 'Manage Sell Offer' and 'Manage Buy Offer'

Ticket: https://github.com/stellar/laboratory/issues/379
Copy for price comes from:
Manage Buy Offer: https://www.stellar.org/developers/guides/concepts/list-of-operations.html#manage-buy-offer
Manage Sell Offer: https://www.stellar.org/developers/guides/concepts/list-of-operations.html#manage-sell-offer

Sanity checked by Eric! Merging.


Crashes with ERROR_OUT_OF_DATE_KHR

Expected Behaviour
Program runs
Example & Steps To Reproduce

env RUST_BACKTRACE=full cargo run --bin example-runner -- --debug-layer

Same thing happens without debug layers as well.
System Info

Rust: rustc 1.49.0-nightly (a85e94927 2020-10-19)
OS: Ubuntu 20.04.1 LTS
GPU: NVIDIA Corporation GM204 [GeForce GTX 970]
SPIR-V: SPIRV-Tools v2020.3 unknown hash, 2020-06-04T23:43:24
Commit: bb94cd8

Backtrace
 ~/p/e/rust-gpu (main) [101]> env RUST_BACKTRACE=full cargo run --bin example-runner -- --debug-layer
   Compiling example-runner v0.1.0 (/home/arong/projects/embark/rust-gpu/examples/example-runner)
    Finished dev [unoptimized + debuginfo] target(s) in 1.96s
     Running `target/debug/example-runner --debug-layer`
INFO:
GENERAL [Loader Message (0)] : Inserted device layer VK_LAYER_KHRONOS_validation (libVkLayer_khronos_validation.so)

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ERROR_OUT_OF_DATE_KHR', examples/example-runner/src/main.rs:1096:18
stack backtrace:
   0:     0x55fe29ea6100 - std::backtrace_rs::backtrace::libunwind::trace::h622bab51c72c4e69
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/../../backtrace/src/backtrace/libunwind.rs:100:5
   1:     0x55fe29ea6100 - std::backtrace_rs::backtrace::trace_unsynchronized::h7e820b882ebd41ee
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:     0x55fe29ea6100 - std::sys_common::backtrace::_print_fmt::h64d46258114db92f
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/sys_common/backtrace.rs:67:5
   3:     0x55fe29ea6100 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h47111d0c1b5f0da5
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/sys_common/backtrace.rs:46:22
   4:     0x55fe29ec795c - core::fmt::write::h1857a60b204f1b6a
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/core/src/fmt/mod.rs:1076:17
   5:     0x55fe29ea27e2 - std::io::Write::write_fmt::h4604516fed3e5731
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/io/mod.rs:1516:15
   6:     0x55fe29ea8585 - std::sys_common::backtrace::_print::h785e7a78d5ef272c
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/sys_common/backtrace.rs:49:5
   7:     0x55fe29ea8585 - std::sys_common::backtrace::print::h108047ac5c4555d5
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/sys_common/backtrace.rs:36:9
   8:     0x55fe29ea8585 - std::panicking::default_hook::{{closure}}::h1d0c271f0d087ebf
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/panicking.rs:208:50
   9:     0x55fe29ea8228 - std::panicking::default_hook::h692753e26f11b7b7
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/panicking.rs:227:9
  10:     0x55fe29ea8c61 - std::panicking::rust_panic_with_hook::h74ddc20305301cd9
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/panicking.rs:577:17
  11:     0x55fe29ea8809 - std::panicking::begin_panic_handler::{{closure}}::h1a9ca6427ceee1d0
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/panicking.rs:484:9
  12:     0x55fe29ea65bc - std::sys_common::backtrace::__rust_end_short_backtrace::h97e27b7ab754adde
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/sys_common/backtrace.rs:141:18
  13:     0x55fe29ea87c9 - rust_begin_unwind
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/panicking.rs:483:5
  14:     0x55fe29ec5831 - core::panicking::panic_fmt::hb15d6f55e8472f62
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/core/src/panicking.rs:85:14
  15:     0x55fe29ec5653 - core::option::expect_none_failed::he492a18657d97593
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/core/src/option.rs:1238:5
  16:     0x55fe298b8631 - core::result::Result<T,E>::unwrap::h84b03395780deb6c
                               at /home/arong/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/result.rs:973:23
  17:     0x55fe298c9c07 - example_runner::main::{{closure}}::hed9bc2edbf08d9ff
                               at /home/arong/projects/embark/rust-gpu/examples/example-runner/src/main.rs:1094:13
  18:     0x55fe298c8a05 - example_runner::ExampleBase::render_loop::{{closure}}::h412d7dfdbc0428e2
                               at /home/arong/projects/embark/rust-gpu/examples/example-runner/src/main.rs:212:17
  19:     0x55fe2986b514 - winit::platform_impl::platform::sticky_exit_callback::h0d38e7a64b54b4c9
                               at /home/arong/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.23.0/src/platform_impl/linux/mod.rs:726:5
  20:     0x55fe298f014b - winit::platform_impl::platform::x11::EventLoop<T>::run_return::h0159bcbe4acde546
                               at /home/arong/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.23.0/src/platform_impl/linux/x11/mod.rs:318:17
  21:     0x55fe298f108a - winit::platform_impl::platform::x11::EventLoop<T>::run::h2424665506b1f479
                               at /home/arong/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.23.0/src/platform_impl/linux/x11/mod.rs:386:9
  22:     0x55fe2986b38e - winit::platform_impl::platform::EventLoop<T>::run::h298f39d37a4690bd
                               at /home/arong/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.23.0/src/platform_impl/linux/mod.rs:642:56
  23:     0x55fe298d2354 - winit::event_loop::EventLoop<T>::run::hbcc3a5253511e0b0
                               at /home/arong/.cargo/registry/src/github.com-1ecc6299db9ec823/winit-0.23.0/src/event_loop.rs:154:9
  24:     0x55fe298c893f - example_runner::ExampleBase::render_loop::h812658a62019b45c
                               at /home/arong/projects/embark/rust-gpu/examples/example-runner/src/main.rs:210:9
  25:     0x55fe29871308 - example_runner::main::h03349b7dbd16079c
                               at /home/arong/projects/embark/rust-gpu/examples/example-runner/src/main.rs:1006:9
  26:     0x55fe2987cf6b - core::ops::function::FnOnce::call_once::h03d977b1992afcc9
                               at /home/arong/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:227:5
  27:     0x55fe298d94fe - std::sys_common::backtrace::__rust_begin_short_backtrace::hca4abd01f72f6d2e
                               at /home/arong/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys_common/backtrace.rs:125:18
  28:     0x55fe298daad1 - std::rt::lang_start::{{closure}}::h0ac2aaf396cd6202
                               at /home/arong/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/rt.rs:66:18
  29:     0x55fe29ea9087 - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::h5867dc20a6af6cac
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/core/src/ops/function.rs:259:13
  30:     0x55fe29ea9087 - std::panicking::try::do_call::h32e8dcce59f53a45
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/panicking.rs:381:40
  31:     0x55fe29ea9087 - std::panicking::try::h7d7b073280e6de2f
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/panicking.rs:345:19
  32:     0x55fe29ea9087 - std::panic::catch_unwind::h801333b3e4e7d79f
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/panic.rs:382:14
  33:     0x55fe29ea9087 - std::rt::lang_start_internal::h2c157bf657c6892a
                               at /rustc/a85e94927622665a9e9022de0d33a890a2e32d43/library/std/src/rt.rs:51:25
  34:     0x55fe298daaa7 - std::rt::lang_start::h6974924f36a5230c
                               at /home/arong/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/rt.rs:65:5
  35:     0x55fe2987173a - main
  36:     0x7f66547300b3 - __libc_start_main
  37:     0x55fe2986b0ce - _start
  38:                0x0 - <unknown>
ERROR:
VALIDATION [VUID-vkDestroyDevice-device-00378<PHONE_NUMBER>)] : Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x55fe2b691fa0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x170000000017, type = VK_OBJECT_TYPE_DEVICE_MEMORY; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x55fe2b691fa0[], VkDeviceMemory 0x170000000017[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/linux/1.2-extensions/vkspec.html#VUID-vkDestroyDevice-device-00378)

ERROR:
VALIDATION [VUID-vkDestroyDevice-device-00378<PHONE_NUMBER>)] : Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x55fe2b691fa0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x190000000019, type = VK_OBJECT_TYPE_DEVICE_MEMORY; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x55fe2b691fa0[], VkDeviceMemory 0x190000000019[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/linux/1.2-extensions/vkspec.html#VUID-vkDestroyDevice-device-00378)

ERROR:
VALIDATION [VUID-vkDestroyDevice-device-00378<PHONE_NUMBER>)] : Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x55fe2b691fa0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x160000000016, type = VK_OBJECT_TYPE_BUFFER; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x55fe2b691fa0[], VkBuffer 0x160000000016[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/linux/1.2-extensions/vkspec.html#VUID-vkDestroyDevice-device-00378)

ERROR:
VALIDATION [VUID-vkDestroyDevice-device-00378<PHONE_NUMBER>)] : Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x55fe2b691fa0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x180000000018, type = VK_OBJECT_TYPE_BUFFER; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x55fe2b691fa0[], VkBuffer 0x180000000018[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/linux/1.2-extensions/vkspec.html#VUID-vkDestroyDevice-device-00378)

ERROR:
VALIDATION [VUID-vkDestroyDevice-device-00378<PHONE_NUMBER>)] : Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x55fe2b691fa0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x1a000000001a, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x55fe2b691fa0[], VkShaderModule 0x1a000000001a[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/linux/1.2-extensions/vkspec.html#VUID-vkDestroyDevice-device-00378)

ERROR:
VALIDATION [VUID-vkDestroyDevice-device-00378<PHONE_NUMBER>)] : Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x55fe2b691fa0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x1b000000001b, type = VK_OBJECT_TYPE_PIPELINE_LAYOUT; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x55fe2b691fa0[], VkPipelineLayout 0x1b000000001b[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/linux/1.2-extensions/vkspec.html#VUID-vkDestroyDevice-device-00378)

ERROR:
VALIDATION [VUID-vkDestroyDevice-device-00378<PHONE_NUMBER>)] : Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x55fe2b691fa0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x120000000012, type = VK_OBJECT_TYPE_RENDER_PASS; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x55fe2b691fa0[], VkRenderPass 0x120000000012[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/linux/1.2-extensions/vkspec.html#VUID-vkDestroyDevice-device-00378)

ERROR:
VALIDATION [VUID-vkDestroyDevice-device-00378<PHONE_NUMBER>)] : Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x55fe2b691fa0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x1c000000001c, type = VK_OBJECT_TYPE_PIPELINE; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x55fe2b691fa0[], VkPipeline 0x1c000000001c[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/linux/1.2-extensions/vkspec.html#VUID-vkDestroyDevice-device-00378)

ERROR:
VALIDATION [VUID-vkDestroyDevice-device-00378<PHONE_NUMBER>)] : Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x55fe2b691fa0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x150000000015, type = VK_OBJECT_TYPE_FRAMEBUFFER; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x55fe2b691fa0[], VkFramebuffer 0x150000000015[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/linux/1.2-extensions/vkspec.html#VUID-vkDestroyDevice-device-00378)

ERROR:
VALIDATION [VUID-vkDestroyDevice-device-00378<PHONE_NUMBER>)] : Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x55fe2b691fa0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x140000000014, type = VK_OBJECT_TYPE_FRAMEBUFFER; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x55fe2b691fa0[], VkFramebuffer 0x140000000014[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/linux/1.2-extensions/vkspec.html#VUID-vkDestroyDevice-device-00378)

ERROR:
VALIDATION [VUID-vkDestroyDevice-device-00378<PHONE_NUMBER>)] : Validation Error: [ VUID-vkDestroyDevice-device-00378 ] Object 0: handle = 0x55fe2b691fa0, type = VK_OBJECT_TYPE_DEVICE; Object 1: handle = 0x130000000013, type = VK_OBJECT_TYPE_FRAMEBUFFER; | MessageID = 0x71500fba | OBJ ERROR : For VkDevice 0x55fe2b691fa0[], VkFramebuffer 0x130000000013[] has not been destroyed. The Vulkan spec states: All child objects created on device must have been destroyed prior to destroying device (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/linux/1.2-extensions/vkspec.html#VUID-vkDestroyDevice-device-00378)

Actually I think this is the same as #103. I'm also using a tiling WM.

Pretty sure this is a dupe of #103 so closing for now


Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

[X] I have checked for that this module doesn't already exist in the module indexes; or I'm proposing the module to be migrated from CARML/TFVM.

Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/ptn/deployment-script/create-kv-ssh-key-pair
Module Details
Why is the module needed?
When creating Virtual Machines in Azure one option for authentication is to use a SSH key pair.
In this scenario, the user has to locally generate and provide the public key.
This creates friction for scenarios where a SSH key is needed;
If the user does not have the correct local tooling
If the user does not have familiarity on how to correctly create the key.
Module path
deployment-scripts/create-kv-sshkeypair
Describe the module.
Takes a Key Vault name, and secret names (for the public/private parts) and uses a bash script with ssh-keygen to create a ssh key pair and then store it in the existing Azure Key Vault.
note: this is existing module from: https://github.com/Azure/bicep-registry-modules/tree/main/modules/deployment-scripts/create-kv-sshkeypair which will be migrated to AVM.
[Update] - Here's the latest version published: https://github.com/Azure/bicep-registry-modules/tree/deployment-scripts/create-kv-sshkeypair/1.0.2/modules/deployment-scripts/create-kv-sshkeypair
Do you want to be the owner of this module?
Yes
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

@vlahane, thank you for proposing this module! As this will most likely be categorized as a pattern module, its approval will require a more thorough assessment. The AVM core team will get back to you soon. Thank you for your patience!

Hi @vlahane,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @vlahane,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
Before starting development, please ensure ALL the following requirements are met.
Please use the following values explicitly as provided in the module index page:

For your module:

ModuleName - for naming your module
TelemetryIdPrefix - for your module's telemetry

For your module's repository:

Repo name and folder path are defined in RepoURL
Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍
You can now start the development of this module! ✅ Happy coding! 🎉
Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

@vlahane, I just pinged you internally regarding the inactivity on this module's development. Please let me know how you're planning to proceed. Thanks!


Retriever with score  #11062

This PR will help to resolve the issue #11062  , please review and let me know

One question what combinations should we allow the user to control ....for example -

The user wants to filter based on the threshold - default option which is already there
The user wants to filter based on the threshold and wants the score of returned docs -  currently not sending any score
The user wants to get the scores of all the docs without threshold

Also appending the score in metadata seemed like a better option since it can be treated as unique key like
how we have for source, etc  [ which the user not explicity change ]. If the user does not want the "score" key, it is fine and he can choose to use it.
Ofcourse we can implement this without having a new search type
Attaching screenshot for point 2

were considering ways to do this in a more native way


How to use Hikaricp with Slick 2.1?

I'd like to use Hickaricp with Slick in play 2.3.3. I've configured the app regarding the instruction:
Step1
  "com.edulify" %% "play-hikaricp" % "1.5.0",
  "com.typesafe.play" %% "play-slick" % "0.8.0" exclude("com.jolbox","bonecp"),
  "mysql" % "mysql-connector-java" % "5.1.32",

Step 2: Disable default dbplugin
Step3:
200:com.edulify.play.hikaricp.HikariCPPlugin
1500:com.typesafe.plugin.CommonsMailerPlugin

Step4:
db.default.hikaricp.file="conf/hikaricp.properties"
dbplugin=disabled

# Slick Evolutions
# ~~~~~
slick.default="models.*"

with hikaricp.properties:
dataSourceClassName=com.mysql.jdbc.jdbc2.optional.MysqlDataSource
dataSource.user=logex
dataSource.url=jdbc:mysql://localhost:3306/logex
dataSource.password=
#maxLifetime=900000
#idleTimeout=300000
#maximumPoolSize=20
#minimumIdle=5

However, when I'm running the app I get the following error:
Configuration error: Configuration error[Slick error : jdbc driver not defined in application.conf for db.default.driver key

I have to specify in application.conf following to make app working:
db.default.driver=com.mysql.jdbc.Driver
db.default.url="jdbc:mysql://localhost:3306/logex"

But it seem that Slick is not using Hikaricp and use old BoneCP with play. I'm wondering how would be a proper way to customize slick with hikaricp?

I experience the same error using play-hikaricp 2.0.1 and play-slick 0.8.1.
I'm also using MySQL and the config matches the one in the docs.

The commit above documents how to use this plugin with play-slick 0.8.1. When using play.api.db.slick.DB.withSession play-slick is smart enough to use the configured pool, instead of opening connections by itself. Also, since dbplugin is disabled, it won't use BoneCP.


HV-1516 Support punycode-encoded domain names

https://hibernate.atlassian.net/browse/HV-1516
@marko-bekhta can you check that it makes sense to you? Thanks!

Ha :) domain names once again. It seems we'll never stop updating the rules for them :)
I was just writing that we could simplify this by adding the dash to the DOMAIN_CHARS_WITHOUT_DASH and it all should work then without additional regex but then it occurred to me that there might be even easier solution to this.
What if instead of matching a plain string we do this:
		Matcher matcher = pattern.matcher( IDN.toUnicode( domain ) );
		if ( !matcher.matches() ) {
			return false;
		}

It will cover the cases from the issue as xn--* stuff will be converted and we would be matching the string without xn-- ?

Yeah, I'm not sure it's a good idea to bet that IDN.toUnicode() will work on already Unicode encoded strings.
Moreover, I'm far from sure the operation is fast.
I don't think what I added is that bad.

@marko-bekhta is the new version of the patch OK with you? If so, I'll merge it!

@gsmet looks good to me, thanks!

Merged! @marko-bekhta thanks for the review.


Empty body responses can violate content security policy

Overview
I have a basic MVC website utilizing OIDC with authorization code flow for authentication. After implementing a content security policy, remote sign out will no longer function.
On remote signout the OpenIdConnectHandler will respond with a response of code 200 but with no body. As a result, browsers will interpret the response by improvising the text/html content. This can result in a content security policy violation based on the browser's improvisation.
Reproduction
I have a repository with the most basic configuration.
Using Chrome, navigate directly to the RemoteSignOutPath (/signout-oidc)
Chrome will report a content security policy violation from the pre element's inline style:

Currently there is limited recourse. I understand I have several options: using 'unsafe-inline', overriding the remote sign out implementation via the OnRemoteSignOut event, or add middleware to change the content security policy for the RemoteSignOutPath specifically. These options are somewhat contrived and not what I would think ideal. However, if there is a better solution that I am overlooking I would appreciate any insight.
I would request consideration for the text/html status code 200 HTTP responses include a body to avoid this browser improvisation.

Additional mitigation: UseStatusCodePages
https://github.com/aspnet/Diagnostics/blob/2f297de23215f981d6ed521868e4f235ee8afa48/samples/StatusCodePagesSample/Startup.cs

It seems worth considering placing a simple text response in the body.


Handling OptimisticWriteLockException and improving logging

This PR is handling OptimisticWriteLockException in JobExecution and also improve logging in FitnessHBTManager

There are lot of log in info mode. Please check if it is required or not ? Would be good if you can do it for this complete class.

@mkumar1984 Currently the log is required to see what the cases optimistic lock exceptions are coming and what are their side effects (since i was not able to reproduce same exception on local) . Once we see no exception , we can definitely convert them to debug

LGTM.


Roll engine 048d70bc0948..5088735e5f54 (2 commits)

https://github.com/flutter/engine/compare/048d70bc0948...5088735e5f54
git log 048d70bc0948de3bad60e2056f186f336cd5aad9..5088735e5f54f7fb34215b6665cb4da1fd8f075d --no-merges --oneline
5088735e5 Clip to clip_rect instead of paint bounds (flutter/engine#8183)
8818a6c41 Roll src/third_party/skia 2c043c288169..4a522b7e916c (3 commits) (flutter/engine#8201)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (jsimmons@google.com), and stop
the roller if necessary.

Trybots failed. These were the failed builds: https://cirrus-ci.com/task/6603398454444032

Commit queue failed; closing this roll.


Prometheus Metrics Support

Current /metric API response is like json format. e.g.
[{"StartTime":"2019-05-28T07:22:43Z","PullCmdCount":0,"PullCmdCountTotal":69,
"BypassCmdCount":0,"BypassCmdCountTotal":0,"PushCmdCount":0,
"PushCmdCountTotal":69,"SuccessCmdCount":1,"SuccessCmdCountTotal":69,
"FailCmdCount":0,"FailCmdCountTotal":0,"Delay":"268.00 ms","AvgDelay":"284.99 ms",
"NetworkSpeed":0,"NetworkFlowTotal":6607,"FullSyncProgress":100,"Status":"incr",
"SenderBufCount":0,"ProcessingCmdCount":0,"TargetDBOffset":136104580201,
"SourceDBOffset":136104587992,"SourceAddress":"redis_src_address:6379",
"TargetAddress":["redis_target_address:6379"]}]

It is appreciated if it supports Prometheus text-based format.
https://prometheus.io/docs/instrumenting/exposition_formats/
It is better to add a /metrics API in order to not break any existing function.

This is a good suggestion, supporting Prometheus API can make makes it easy for our tools to connect to the monitoring end.
This can be our future feature.

Good to hear that.


[NL Interface bug fix] Only remove place strings for which we found a DCID

Previous: used to remove all place strings found even if only some of them got a valid DCID resolution. This was also reported as bug (by @jehangiramjad ) in the NL queries testing for the query: "show me the richest county in California" where NER place detection found "richest county" and "California" as possible places but only found California with a valid DCID. But, "richest county" was also removed from the query for further attribution/classification/SV detection. This meant that the query was not classified as "contained in = COUNTY" because the word "county" was removed.
Now: only removing place strings for which a DCID was found. In the example above, only "California" is removed. See the screenshot below for the debugInfo showing the correct handling + the other screenshot showing correct containedIn = COUNTY attribution.

I will go ahead and merge this, since this has a useful fix.


Updated and added S2 drop shadow tokens

Description

Renamed previous drop shadow tokens from S1 and pointed them to the new 100 S2 drop shadow tokens
Added new drop shadow tokens, 100, 200, emphasized-default, emphasized-hover, elevated

Motivation and context

These tokens reflect the updates to drop tokens foundations in Spectrum 2, allowing more options and flexibility of usage in containers

Related issue

SDS-13341
Types of changes

 [ ] Patch (bug fixes, typos, mistakes; non-breaking change which fixes an issue)
 [x] Minor (add a new token, changing a value; non-breaking change which adds functionality)
 [ ] Major (deleting a token, changing token value type; fix or feature that would cause existing functionality to change)
Checklist:

 [x] I have signed the [Adobe Open Source CLA](https://opensource.adobe.com/cla.html).
 [x] I updated the token in all applicable sets. This applies if updating, adding, or deleting a token that has data across different sets (for example, if the value differs across color themes.)

TESTING spectrum2-non-colors
READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
READING   tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/
TOKENS STUDIO DATA IS NON-COLOR ONLY
STUDIO SYNC SUMMARY
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.🚫 drop-shadow-y
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.🚫 drop-shadow-blur
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-x-100
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-y-100
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-blur-100
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-x-200
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-y-200
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-blur-200
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-default-x
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-default-y
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-default-blur
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-hover-x
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-hover-y
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-hover-blur
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-elevated-x
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-elevated-y
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-elevated-blur

SPECTRUM SYNC SUMMARY
NEW TOKENS: (15) drop-shadow-x-100, drop-shadow-y-100, drop-shadow-blur-100, drop-shadow-x-200, drop-shadow-y-200, drop-shadow-blur-200, drop-shadow-emphasized-default-x, drop-shadow-emphasized-default-y, drop-shadow-emphasized-default-blur, drop-shadow-emphasized-hover-x, drop-shadow-emphasized-hover-y, drop-shadow-emphasized-hover-blur, drop-shadow-elevated-x, drop-shadow-elevated-y, drop-shadow-elevated-blur
MODIFIED TOKENS: (2) drop-shadow-y, drop-shadow-blur
DEPRECATED TOKENS: (5) drop-shadow-x, drop-shadow-y/desktop, drop-shadow-y/mobile, drop-shadow-blur/desktop, drop-shadow-blur/mobile
CHANGED VALUES: (3) drop-shadow-x, drop-shadow-y/desktop, drop-shadow-blur/desktop
CHANGED SCHEMAS: (3) drop-shadow-x, drop-shadow-y, drop-shadow-blur

TEST COMPLETE

TESTING spectrum2-colors
READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
READING   tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-colors/
TOKENS STUDIO DATA IS COLOR ONLY
STUDIO SYNC SUMMARY
UPDATED METADATA - SPECTRUM UUID: spectrum2/alias.Alias.🚫 drop-shadow
UPDATED METADATA - SPECTRUM UUID: spectrum2/alias/dark.Alias.drop-shadow.100
UPDATED METADATA - SPECTRUM UUID: spectrum2/alias/light.Alias.drop-shadow.100
UPDATED METADATA - SPECTRUM UUID: spectrum2/alias/dark.Alias.drop-shadow.200
UPDATED METADATA - SPECTRUM UUID: spectrum2/alias/light.Alias.drop-shadow.200
UPDATED METADATA - SPECTRUM UUID: spectrum2/alias.Alias.drop-shadow.emphasized-default
UPDATED METADATA - SPECTRUM UUID: spectrum2/alias.Alias.drop-shadow.emphasized-hover
UPDATED METADATA - SPECTRUM UUID: spectrum2/alias.Alias.drop-shadow.elevated

SPECTRUM SYNC SUMMARY
NEW TOKENS: (7) drop-shadow-color-100/dark, drop-shadow-color-100/light, drop-shadow-color-200/dark, drop-shadow-color-200/light, drop-shadow-emphasized-default-color, drop-shadow-emphasized-hover-color, drop-shadow-elevated-color
MODIFIED TOKENS: (1) drop-shadow-color
DEPRECATED TOKENS: (2) drop-shadow-color/light, drop-shadow-color/dark
CHANGED VALUES: (1) drop-shadow-color/light
CHANGED SCHEMAS: (1) drop-shadow-color

TEST COMPLETE

This update also included some new colors in S2/Variables. This is the first time we've done this since we formalized this process, and I wanted to make sure this looks OK to you @nabuhasan @KayiuCarlson @mrcjhicks.
I'm thinking we should potentially leave these out from S2/Color as well, since they are not currently used (styles and variables can't be linked to effects right now in Figma) and might cause confusion to have all these colors.
@GarthDB I'm also wondering since it would likely make sense for us to remove drop-shadow-color in a future release from Figma (now that it's deprecated), if we delete it from Token Studio, will this affect your repo? Should we delete from the Figma files only?

I would recommend deleting them in Tokens Studio when we introduce the complex tokens because that will be a breaking change for all the parsers anyway.

Here's a link to the RFC for more details about the complex tokens for drop shadow.

I just shared an update on Slack where I believe that Figma actually supports binding of variables to effects! We may want to reconsider support for this instead of moving with deleting them in Tokens Studio. More in the slack thread.

SYNCING spectrum2-non-colors
READING spectrum-tokens: /spectrum-tokens/packages/tokens/src/
READING   tokens studio: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/
TOKENS STUDIO DATA IS NON-COLOR ONLY
STUDIO SYNC SUMMARY
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.🚫 drop-shadow-y
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.🚫 drop-shadow-blur
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-x-100
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-y-100
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-blur-100
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-x-200
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-y-200
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-blur-200
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-default-x
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-default-y
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-default-blur
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-hover-x
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-hover-y
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-emphasized-hover-blur
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-elevated-x
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-elevated-y
UPDATED METADATA - SPECTRUM UUID: spectrum2/layout.drop-shadow-elevated-blur

SPECTRUM SYNC SUMMARY
NEW TOKENS: (15) drop-shadow-x-100, drop-shadow-y-100, drop-shadow-blur-100, drop-shadow-x-200, drop-shadow-y-200, drop-shadow-blur-200, drop-shadow-emphasized-default-x, drop-shadow-emphasized-default-y, drop-shadow-emphasized-default-blur, drop-shadow-emphasized-hover-x, drop-shadow-emphasized-hover-y, drop-shadow-emphasized-hover-blur, drop-shadow-elevated-x, drop-shadow-elevated-y, drop-shadow-elevated-blur
MODIFIED TOKENS: (2) drop-shadow-y, drop-shadow-blur
DEPRECATED TOKENS: (5) drop-shadow-x, drop-shadow-y/desktop, drop-shadow-y/mobile, drop-shadow-blur/desktop, drop-shadow-blur/mobile
CHANGED VALUES: (3) drop-shadow-x, drop-shadow-y/desktop, drop-shadow-blur/desktop
CHANGED SCHEMAS: (3) drop-shadow-x, drop-shadow-y, drop-shadow-blur

WROTE: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/spectrum2/layout/mobile.json
WROTE: /spectrum-tokens-studio-data/src/tokens-studio/spectrum2-non-colors/spectrum2/layout/desktop.json
WROTE: /spectrum-tokens/packages/tokens/src/layout.json
SYNC COMPLETE
Spectrum Tokens Pull Request
Tokens Studio Pull Request


bower.json

I would like to download chai-jquery using bower but I don't see bower.json file in repository. Still I can find (and download) it on bower.io: http://bower.io/search/?q=chai-jquery.
How it's possible? Can we add bower.json to repository?
I ask because I want to use chai-jquery in my rails project through Rails Assets and it requires bower.json:

You can now require BOWER_PACKAGE_NAME in your stylesheets and JavaScript files—all assets exposed as main in bower.json will be automatically included.

:+1:

At the moment, bower.io can not find chai-jquery anymore (using the provided link).
However, it is still possible to get chai-jquery with bower, and you have 2 ways to do it:
directly on the CLI:
bower install chai-jquery

or by inclusion in your bower.json's dependencies or devDependencies:
  "devDependencies": {
    "chai": "~3.1",
    "chai-jquery": "~2.0"
  }

@Proghat thanks for filing the issue.
@Proghat @jaredmoody @T1st3 if you'd like, any one of you can work on a PR to add the bower.json back in, and I'll merge it :smile:.

just created a PR for it (#70)

@keithamus: this one should be closed (ref: #70)
To make it clear for everybody, bower.json was created in version 2.01 of chai-jquery. Please update if you want this feature!

Thanks @T1st3 :smile:


multiple hosts for callback - same agent

Hi,
Is there any way to add multiple hosts for callback for the same agent? also is there any way to add multiple communication channels and ports such as http and https for the same agent?
such as http://domain1.com:80,http://domain2.org:80, https://domain1.com:443,https://domain2.com:8080
Thank you

Hey sorry for the delay. I completely missed this.
As of right now it's not supported due to it not being an "official" feature of the Mythic HTTP profile. It might be worth heading over to https://github.com/MythicC2Profiles/http and making it a feature request for the profile, so I can officially support it!


[YUNIKORN-2247] Preemption e2e tests should run in separate namespaces

What is this PR for?
as title, make Preemption e2e test run in separate namespaces
What type of PR is it?

[x] - Improvement

Todos
N/A
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2247
How should this be tested?
covered by existing e2e
Screenshots (if appropriate)
N/A
Questions:
N/A

@brandboat could you look at the failed tests? I don't think they're related, also only 2 suites were affected, but still, something happened.

@brandboat could you look at the failed tests? I don't think they're related, also only 2 suites were affected, but still, something happened.

Not related, already fired https://issues.apache.org/jira/browse/YUNIKORN-2291
Thanks for poing out that !


Reexport scroll type

Please add reexport Scrollbars from react-custom-scrollbars-2 in scroll component

Added https://github.com/KasperskyLab/uif/pull/55

Merged #55


dmca notice

Hi I had created a fork of this a while back and just now I have revived a dmca takedown request claiming to be from a enforcment agent for mojang AB
in the request they ask all forks be taken down as well as "https://github.com/PrismarineJS/prismarine-web-client"
they also claim
---"
This user has presumably decompiled and reverse engineered portions of our code to find how to recreate the game. They have leveraged several historical versions of the game as well as other common libraries which are all laid out in the credits documentation.
Their code goes against our EULA and Terms of Use by disabling and allowing unauthenticated connections to servers as well as redistribution the client for local game play
"---
furthermore
they even claim this is not under an open source licence
---"
Is the work licensed under an open source license?
No
"---
they also mention eagle craft for some reason
what is the status on this and other than taking down the fork what should I do.
best regards,
Connor Peach

The DMCA notice wrongly claim this is using EaglerCraft which it is not.
We have submitted a counter notice.
You can decide to do the same at https://github.com/contact/dmca
On Thu, Apr 13, 2023, 14:43 Connorppeach @.***> wrote:

Hi I had created a fork of this a while back and just now I have revived a
dmca takedown request claiming to be from a enforcment agent for mojang AB
in the request they ask all forks be taken down as well as "
https://github.com/PrismarineJS/prismarine-web-client"
they also claim
"
This user has presumably decompiled and reverse engineered portions of our
code to find how to recreate the game. They have leveraged several
historical versions of the game as well as other common libraries which are
all laid out in the credits documentation.
Their code goes against our EULA and Terms of Use by disabling and
allowing unauthenticated connections to servers as well as redistribution
the client for local game play"
furthermore
they even claim this is not under an open source licence
"
Is the work licensed under an open source license?
No
"
they also mention eagle craft for some reason
what is the status on this and other than taking down the fork what should
I do.
best regards,
Connor Peach
—
Reply to this email directly, view it on GitHub
https://github.com/PrismarineJS/prismarine-web-client/issues/345, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR437TFI6ORXSGUULHOT7LXA7YF3ANCNFSM6AAAAAAW5A33EQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Solved


Fix for Data Quality perf and issue other tweaks.

Pull Request Description

Fix bug where DB_Table data quality indicators broke deserialization in the table viz.
Memorization of the untrimmed data quality indicator and move to it being an operation and column function.
If more than 10,000 rows then use a sample for untrimmed.
ALIASes for blank functions.
Fix for Snowflake drill down.
Bug fix for Long and Double columns with Nothings at end.

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[ ] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.
[ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
or the Snowflake database integration, a run of the Extra Tests has been scheduled.

If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

Is it possible to add tests for any of the new functionality?

Tests added for the table viz have been updated to cover the DB Table and sampled data quality indicator.
Will add a test for the column slice.


rustfmt writes to files even if they weren't changed

This means that if you for example run cargo fmt, it will write to all files in the project, meaning cargo build will have to recompile your project, even though nothing changed.
I'm not sure what effects this has on incremental compilation. Does it matter what files were changed, or does it work on the semantic data?

AFAIK incremental compilation bases on hashing, so there should be no effect on that front. However, incr comp will be turned off by default on release builds, so it does have an effect here.


Cancel button behavior for showdatepicker/showtimepicker

Issue #6483

Please email flutter-dev after this patch lands to explain the API change.


Print out TOTP password for login to web interface

We shouldn't allow the origin to start unless an administrative password is set.  To do so, print out a TOTP key periodically until the user logs into the web interface and sets a new one.
Provide a CLI flag to auto-set the password, skipping this setup step.

This was done in #13.


When Undefined isnt undefined.....

Issue Report Checklist

[X] Searched the issues page for similar reports
[X] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[X] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[X] Could not reproduce inside jupyter qtconsole (if console-related)
[X] Tried basic troubleshooting (if a bug/error)

[X] Restarted Spyder
[X] Reset preferences with spyder --reset
[X] Reinstalled the latest version of Anaconda
[X] Tried the other applicable steps from the Troubleshooting Guide

[X] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
Undefined variables can be found from within the scope of an earlier executed program.
What steps reproduce the problem?
Consider two files:
file1.py
qval = 5; print(qval)
and
file2.py
print(qval) ; qval = 2
The editor correctly notes on file2.py that qval is undefined.
However, if first you run file1.py, then the error in file2.py is still flagged by lint but now when you run file2.py it wont fail, instead it will first print the value of "5" and if you run it a second time (or more) you will get the value "2".
What is the expected output? What do you see instead?
I was not expecting Spyder to remember variables that had been defined in a separate file.
Paste Traceback/Error Below (if applicable)

PASTE TRACEBACK HERE

Versions

Spyder version: 4.1.4
Python version: 3.7.3
Qt version: ?
PyQt version: ?
Operating System name/version: Windows 10

Dependencies

PASTE DEPENDENCIES HERE

Hi @Tunneller, thanks for contacting us. It seems that you have activated the option Run in console's namespace instead of an empty one, found under the menu Run -> Configuration per file. Please make sure to deactivate that option in order to prevent variable mixing across multiple runs.


Disable drag and drop

Is possible to disable the drag and drop?

Sorry, here is the answer: https://github.com/luckylooke/dragular/issues/64


v1.7.2 fails to launch on OSX Mojave 10.14.6

I updated to 1.7.2 from 1.7.1 and now the AsciidocFX.app fails to launch. I have tried removing and doing a new install and the same problem exists. The log indicates there is a version incompatibility problem with the javax.servlet.ServletContext class. It looks like two versions of the servlet api have been included.
After I removed the lib/servlet-api-2.2.jar file I was able to launch the application.
asciidocfx.log

Thanks for reporting, I excluded the old dependency from fop. Please re-download the build https://github.com/asciidocfx/AsciidocFX/releases/tag/v1.7.2

Still there is a problem with Catalina 10.15.4

New release is available https://github.com/asciidocfx/AsciidocFX/releases/tag/v1.7.4
Please check if that fix your issue.

Yes it does fix the issue

Thanks


Please upgrade to node-20

Thanks for taking the time to create this action. It is very useful.
Please upgrade your action to use node-20 as node-16 is being deprecated.
Coverage (ubuntu-latest, nightly)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20<EMAIL_ADDRESS>bigmeech/gha-simple-coverage@master. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

I apologize for my delayed response.
Thank you for letting me know. I will upgrade the Node.js to v20.


how to upgrade database when upgrade hue 3.11.0 to 4.5.0

hello, i used hue 3.11.0 and pstgresql database， now i want to upgrade hue to 4.5.0 version。
how can i upgrade database?

./build/env/bin/hue migrate
Will run the migrations. As usual, do a backup of the DB before just in case
On Thu, Dec 5, 2019, 5:59 AM fsilent<EMAIL_ADDRESS>wrote:

hello, i used hue 3.11.0 and pstgresql database， now i want to upgrade hue
to 4.5.0 version。
how can i upgrade database?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cloudera/hue/issues/1008?email_source=notifications&email_token=AAAEMGPCZIXTAYI5FXJJTTTQXC7GBA5CNFSM4JVWF2JKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H6IFK3A,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAEMGMDRQLEVVWL6EK67DTQXC7GBANCNFSM4JVWF2JA
.

3ku(thank you)


Add creating proxy function to http-service

Implement http proxy via express-http-proxy module in http-service.js.
Proxy settings should will be input from monorail.json with key name "httpProxies";
"httpProxies" is supposed to be an array and each proxy element could include 3 items:
(1) Server info, which is a must.
(2) Local/remote paths are optional and will be root path by default if not provided.

I'm working on the unit-test, so please don't merge until the unit-test is done, but anyway, you can first comment on the code.

I was wondering if this been benchmarked?  What is the performance impact, if any, of running the proxy within Node vs. using something like squid?

@zyoung51 I'm sure it's slower, but it's an easy option that we can build in. Anyone packaging RackHD could easily add a proxy layer like squid+Nginx to get a performance gain if it's suited them.

@pengz1 looking good so far. This PR needs a rebase at this point, and I wanted to ask that you plan on updating https://github.com/RackHD/docs/blob/master/docs/rackhd/configuration.rst with a PR describing the format of the array of proxies allowed in the monorail.json file - the 3 sub-components (localPath, remotePath, and server) needed for each proxy are more complex than any of our other configurations today.

(-1 until unit tests are added)

@zyoung51 @heckj
I tried 2 configurations in SH for RHEL bootstrap:

Mount mirror server to ORA (use "mount -t cifs"): bootstrap test costs 691s
Use proxy codes in this PR: bootstrap test costs 628s
Looks proxy is a little faster than the way we used for bootstrap tests.

I also tried 2 configurations in SH for CentOS bootstrap:

Mount mirror server to ORA: bootstrap test costs 691s
Use a proxy mirror repo outside EMC (http://mirrors.zju.edu.cn/centos/): bootstrap test costs 1115s
There is performance downgraded but should be acceptable as it is always slower if we want to get a mirror outside our lab.

@RackHD/corecommitters , @yyscamper , @zyoung51 , @jfrey

@zyoung51 , in this PR, we also fix an unit-test error of SKU pack, please check whether this is expected.
Meanwhile, we found the unit-test of /api/tasks-spec.js will fail in bootstrap.js case, we also fixed it by mocking the template service directly, not via Waterline.

@heckj : the unit-test has been added and together with the fix for https://github.com/RackHD/RackHD/issues/54

+1

:+1:

@heckj
Unit test is updated, could you help to review and +1 if no other concern?

:+1: Unit tests look great, thank you!

+1


Editor - page title bold

Page wizard: Page Title: Bold won’t do anything as it’s bold by default.
By Fay

Isn't that only due to the theme though @FayCross? Now that we have different themes we could in theory bold a page title on a single page?

Yes, it's because of the css. I think this is from my initial comments so I wasn't saying it was a bug, just that we need to change it so that either the css allows it to be changed from the editor or we take the text appearance options off that field in the wizard.

I say we leave this as is... if we take the (B) button away and someone changes the theme then they may want to make it bold on a single page... what do you think @torinfo  @ronm123 ?

Yeah with the default interface and default size and weight it probably ought to remain bold by default to maintain good contrast.
With the source button option on the title field window it's possible to un-bolden anyway e.g. page title test
Just a thought out loud - is it easy and a possibility to add an N for normal button to the left of the B for bold which then adds font-weight: normal; to the span?

I am ok with leaving this as is.
It can be done, but it's not easy, it would need to be a custom button

I'm just going to make an executive decision and close this... there are other css things that can't be overridden by the editor. If it's raised by the community then we can revisit


Mini-cart: layout improvements

Reproduce:

Add at least one item to cart
Mouse over cart to trigger flyout

Issue: The flyout looks quite messy, I'd suggest the following layout improvements:

Display product thumbnail image per line item
Use a font that is much more condensed and that doesn't come in all caps - currently, the product name is larger than the flyout's headline, for instance
Display quantity and style attributes on individual lines, maybe even less prominent than the product name
The subtotal should be right-aligned with the item totals

When clicking on the mini cart dropdown, the window locks onto the screen. Is that intentional? I suggest to only be able to open the mini cart via hover (same for user menu). Also when you open the mini cart, the window just plops up instantly. I think it would be better if we have some kind of animnation, just like the categories of the top navigation.

@kqmpetenz Please see https://github.com/Xceptance/posters-demo-store/issues/124 for the issue you are mentioning.

Issue fixed for poster v2.1.


C++

Gg bro

Yeah

Im Pakistan

I'm in Lagos Nigeria
On Thu, Mar 3, 2022, 10:33 Muzamil King @.***> wrote:

Im Pakistan
—
Reply to this email directly, view it on GitHub
https://github.com/sindresorhus/awesome/issues/2198#issuecomment-1057850060,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXWMSGNBASO5ZKSOTHHSKHDU6CBNDANCNFSM5PZ3UI4A
.
You are receiving this because you authored the thread.Message ID:
@.***>

My watsapp  Number 92<PHONE_NUMBER>8

Alright
On Thu, Mar 3, 2022, 10:55 Muzamil King @.***> wrote:

My watsapp Number 92<PHONE_NUMBER>8
—
Reply to this email directly, view it on GitHub
https://github.com/sindresorhus/awesome/issues/2198#issuecomment-1057870817,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AXWMSGIPVOFQS2JHESFN2KDU6CD7NANCNFSM5PZ3UI4A
.
You are receiving this because you authored the thread.Message ID:
@.***>


Http gap 3359 v2

Needs https://github.com/OISF/suricata/pull/4951 and https://github.com/OISF/libhtp/pull/296

Fixes http sticky server
There should be 29 alerts and not only 28 (as you can count in the pcap with grep -a Omniture http-sticky-server.pcap | wc -l
The missed alert is at packet 8363 (cf Wireshark filter tcp.port == 56401), due to missing first request packet
Adds multiple tests with different HTTP GAP scenarios from https://github.com/OISF/suricata/pull/4951#issuecomment-630782701

gap within the body ✅
multiple different gaps in the same body ✅
gap that starts within body but extends beyond it ✅
gap that is exactly the body size ✅
gap after CL header but before end of headers? : not supported by suricata PR so far
methods: GET/HEAD, POST/PUT, etc : irrelevant ?
etc.

Follows #234 by adding more tests

Can you split things so the GAP'ed flow is in its own test? This way we can limit that to 6.0.0 and keep the other test from failing on 5 and 4.1

Done something in #277
Is it good for you ?


Issue with "symk-opt" in a simple navigation problem

I modeled a simple navigation problem.
We start from a weighted graph with a starting node where it is a robot and each weight for edges represents the cost of the movement of the robot. Moreover, in some nodes there are packages and our objective is to find the path with the lowest cost in order to let the robot moving the packages from their positions to target positions given initially. In any node there can be at most one pack.
When I try to solve the problem optimally, the planner "enhsp-opt" can find a plan which its final cost is equal to 19. On the other hand, the planner "symk-opt" still finds an "optimal" solution but its cost is equal to 29.
It is clear that there is a problem. I don't know if I did something wrong or if there is a problem with "symk-opt" solution, since it is possible to find a better solution.
In the file attached there is my code where I generate the weighted graph, create the problem and compare the solutions between the two planners.
Problem_symk-opt.txt

@speckdavid maybe you can help on this

Thanks for reporting this. There was an issue in the pipeline of up-symk. The cost of the actions were always ignored and the length of the plan was actually optimized instead of the cost of the plan. With the version 1.1.0 it should be fixed.
Please let me know if you encounter any other problems.

It is fixed! Thank you :)


Adding recommendation for certified JBODs

Added bullet point for recommending JBODs are listed as Storage Spaces certified on www.windowsservercatalog.com.

Looks good - let's publish!

Thanks, @Anhansen!


run producer in cunsumer

Hii
Can i run producer into Consumer in kafka-php?

@SunnnyGohil for now you can only run the sync producer while consuming messages, since the control of the event loop is done inside of the classes

thanks for reply @lcobucci
when i run producer into consumer that time i got "Exception 'LogicException' with message 'Cannot run() recursively; event reactor already active" this error.
if you have solution than please help me

@SunnnyGohil the producer should be run in the synchronous mode: https://github.com/weiboad/kafka-php#synchronous-mode

@lcobucci  i aleardy run producer in sync mode but i got error

Can you put your code here?

require '../vendor/autoload.php';
date_default_timezone_set('PRC');
 $config = \Kafka\ConsumerConfig::getInstance();
$config->setMetadataRefreshIntervalMs(10000);
$config->setMetadataBrokerList('<IP_ADDRESS>:9092');
$config->setGroupId('test');
$config->setBrokerVersion('<IP_ADDRESS>');
$config->setTopics(['test']);
$config->setOffsetReset('earliest');
$config->setClientId(1);
$consumer = new \Kafka\Consumer();
$consumer->start(function($topic,$part,$message) use (&$partition){

    $part=(int)$partition;
    $st=@(time()+microtime());
    $data=(array)json_decode($message['message']['value']);
    $data['data']=(array)$data['data'];
            $GLOBALS['log']=$data;
            $config_producer = \Kafka\ProducerConfig::getInstance();
            $config_producer->setMetadataRefreshIntervalMs(10000);
            $config_producer->setMetadataBrokerList('<IP_ADDRESS>:9092');
            $config_producer->setBrokerVersion('<IP_ADDRESS>');
            $config_producer->setRequiredAck(1);
            $config_producer->setIsAsyn(FALSE);
            $config_producer->setProduceInterval(500);
            $producer = new \Kafka\Producer(
                function() {
                    return [
                        [
                            'topic' => 'make',
                            'partId'=>0,
                            'value' => json_encode($GLOBALS['log']),
                            'key' => 'click',
                        ],
                    ];
                }
            );
            $producer->send(true);
});

this is my code

@SunnnyGohil setIsAsyn() does not put the consumer in synchronous mode, if you compare your code with the one in the link I've sent you you'll notice that there are differences in:
$producer = new \Kafka\Producer(
    function() {
        return [
            [
                'topic' => 'make',
                'partId'=>0,
                'value' => json_encode($GLOBALS['log']),
                'key' => 'click',
            ],
        ];
    }
);

$producer->send(true);

thanks @lcobucci
i changes in my code but i got there new exception
"Exception 'Kafka\Exception\Protocol' with message 'unpack failed. string(raw) length is 0 , TO N"

@SunnnyGohil are you using the stable release? If so, could you try with dev-master?

yes @lcobucci  i am using stable release.
my project in on it i can't change it.
can you give me another solution?

i solv this by calling self API

dose partId is work?

@SunnnyGohil can you please tell me how did you solve this issue?

I has this problem too. And have no idea how i can solve it

@dawood @djklim87 it was solved in aforementioned PR, but it never merged.

@Sevavietl yes i saw that, bad that PR did not get merged.
@djklim87 I was able to use producer from consumer using low level api provided. look at https://github.com/weiboad/kafka-php/blob/master/example/protocol/Produce.php
so, you need to use low level api which is used internally anyways to communicate. Let me know if you need more help.

run producer into consumer,can any body solve this issue.

@lijunchen22 refer to https://github.com/weiboad/kafka-php/blob/master/example/protocol/Produce.php
you would need to use low level api as mentioned in above file.

@dawood I try. but it doesn't work. Can you show me your code here?

@lijunchen22
<?
$data = [
    'required_ack' => 1,
    'timeout' => '1000',
    'data' => [
    	[
    		'topic_name' => 'SOME_TOPIC',
    		'partitions' => [
        		[
    				'partition_id' => 0,
    				'messages'     => $eventsToSend,
        		],
    		],
    	],
    ],
];
Protocol::init('1.0.0');
$requestData = Protocol::encode(Protocol::PRODUCE_REQUEST, $data);
$socket = new Socket($kafkaBrokerHost, $kafkaBrokerPort);
$socket->setOnReadable(function ($data): void {
$coodid = \Kafka\Protocol\Protocol::unpack(\Kafka\Protocol\Protocol::BIT_B32, substr($data, 0, 4));
$result = Protocol::decode(Protocol::PRODUCE_REQUEST, substr($data, 4));
echo json_encode($result);
});
$socket->connect();
$socket->write($requestData);

@dawood it work，thanks a million


Fix lint issue with client

Description

Fix issue causing the client not to pass the CI checks

ETA
This issue is expected to be completed within 1 business day or being assigned. Failure to create a pull request or draft pull request will lead to the contributor being unassigned

Hi, i'm Mike,  I have experience in resolving issues like this, can I take this issue?

I will address this issues in the following ways:

Check logs and error
Check Cairo code issues
Typescript Code issue
Check Dependencies
Confirm by running unit test

Can I be assigned to this? I am verify familiar with GitHub actions and the steps I would take to tackle this issue would include:

To first see the details of the check failing and review the logs to identify the cause of the failure.
Make the necessary changes to resolve the error

ETA: 1 day (max)

Would love to tackle this!

I'd be happy to do this.

May I take this issue on?

Hi, I'm John Asogwa, and I will love to work on this issue.
I'm an experienced developer with expertise in debugging CI/CD pipelines and resolving build and test issues.
I estimate this issue can be resolved within 1 business day.
Steps to Resolve
Reproduce the Issue Locally
Run the CI pipeline commands locally to identify the root cause of the failure.
Check for issues in dependencies, TypeScript compilation, or linting.
Inspect and Fix Errors
Resolve any missing dependencies by updating the pnpm-lock.yaml file or adding them to package.json.
Fix TypeScript errors in the source code and ensure all modules and imports are configured correctly.
Address linting and formatting errors to match project standards.
Check CI Environment
Review the CI configuration file for environment mismatches or missing setup steps.
Ensure Node.js and pnpm versions are aligned between local and CI environments.
Validate the Fix
Test the build process locally after applying fixes.
Push the changes and verify the CI pipeline completes successfully.
Final Steps
Once the fix is verified, I will:
Commit the changes to a branch named fix-client-ci.
Open a pull request with a detailed explanation of the issue and resolution.
I’m confident this will resolve the issue, ensuring a smooth CI pipeline for StarkLudo.

Let me handle this issue! I can finish this task today

Is it okay if I take this? first time contributor ETA 24 hours


Update docs on inherited class to support remove

If you need to use removeLayer or clearLayers you'll need this override to ensure layers are unindexed, otherwise they will remain on the map.
See issue https://github.com/makinacorpus/Leaflet.LayerIndex/issues/6

Awsome thanks!


Fix Auth Router Documentation

Fixes #2764

Hmm, this was reported on 0.20.  I'm just going to cherry pick it.

Cherry-picked as cc59744bbd.


Attack animation

Hello,
It seems that localized 'global value' name is messing up the per item attack animation.
On the french version, the popup brings (valeur global) as default but it cannot be saved as such, the system displays 'Custom animation was removed'.
It 'works'  when (global value) is placed instead but I cannot play custom sounds.
Tested on blank world, 1.80-alpha8 / FFG Star wars Enhancements 2.0.0

Thank you again for your work !

I think you're misunderstanding how it works. You cannot set a custom value for one part; you must set a custom value for each of the three fields - animation file, sound file, and number of times to play. If you leave any of them as default, it will unset it instead.

Isn't the (global value) supposed to get the value from the global FFG Enhancement setting ?
Also, when trying to set with default values (copy pasted from the settings), it does not work

(global value) (or the localized version) is supposed to use the values set in the module settings. You can only set custom values in that window when none of them are set to (global value).
What happens when you try to save with your screenshot?

You can only set custom values in that window when none of them are set to (global value).

I do not understand, do you mean the global settings (in Options => FFG Enhanced => Attack animations) must be blank for the custom values to work ?

What happens when you try to save with your screenshot?

It saves but no sounds or animation is played when attacking

This will not work:

Neither will this:

All settings must be set to something other than the default value or it will "remove custom animation".

Can you try changing the skill the weapon is using and let me know if it works for any skill?

The error may actually be somewhere else.
I was testing with 1 animation count, it does not work. But when testing with values of 2 or more, it works.
It seems sound and animation are played 1 time less than the value indicated in "Animation count".

Thanks for offering to take this @bheiskell, looking forward to your fix

Chatting with @wrycu, there may be an off by one bug, causing 1 to become 0 attacks.

I confirmed it's an off by one in my local environment. Looking into how to fix it. (As a work around, set animation count = 2).

Will be released in 2.0.2.


如何修改首页文章顶部与标题之间的距离

Expected behavior (预期行为)
减小首页显示的文章正文顶部与"发表于"一栏之间的距离，现在距离比较大，想缩小一点，更美观

Actual behavior (实际行为)
没找到修改方法
Steps to reproduce the behavior (重现步骤)
NexT Information
Add the  ✔  sign before an item which is affected by this behavior.
NexT Version:

Master
Latest Release
Old version -

NexT Scheme:

All schemes
Muse
Mist
Pisces

Other Information (Like Browser, System, Screenshots)

@jcx70100 in English, please. What style u need? All custom styles may rewrite in source/css/_custom/custom.styl.

@ivan-nginx  Thank you for your attention, my question is: the distance between the title and the top of article is too loog , i want to make it  smaller ,  the picture below may make my problem more clearly:

@jcx70100 ok, i see. That's easy, u may change any custom style u want without edit original Next templates. To do this, in file next/source/css/_custom/custom.styl simply add your any custom css:
.posts-expand .post-meta {
	margin: 3px 0 5px 0;
}

If issue is solved, close it please.

@ivan-nginx  I solved the problem under your tips, you are so kind, thanks very much.
close #1619

close #1619


Clean up scale parameters

The scale parameters in the Scale Conversion and RGB Decomposition tools could probably be tidied.

The indirbase probably doesn't need the splitext portion of the variable definition

Test both tools with non-conforming input file/directory names to make sure the interface doesn't freak out, and still allows the user to select the option manually.

Changed indirbase in RGB, changed variable name to reflect reality in Scale Conversion.
Tested to make sure that the scale (and polarization) variables default to blank if the input file schema doesn't match the expected pattern.


Getting SyntaxWarning: invalid escape sequence '\ '

After upgrading python to 3.12.2 i started getting these annoying warning messages;
INFO: From Writing: bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/jetty/jetty.tar [for tool]:
/private/var/tmp/_bazel_thesayyn/9000763e5f5851865f9d806cb10059e8/sandbox/darwin-sandbox/2378/execroot/distroless/bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_pkg/pkg/private/tar/build_tar.runfiles/rules_pkg/pkg/private/tar/build_tar.py:29: SyntaxWarning: invalid escape sequence '\ '
  """Normalize a path to the format we need it.

I think this was fixed by #815.   Have you tried the latest release or from head?

Using the latest version fixed the warning message for me.


Add support for invitations

See #1687

https://github.com/GitHawkApp/GitHawk/issues/1686#issuecomment-376773449

This is the URL that GitHub uses to "open" the invitation: https://github.com/Nirma/Attributed/invitations
... which appears to not exist in the JSON. Ugh. At least it's easy to compose?

Yikes. Looking at this, and even though the url is easy to construct, the subject itself can't. 😐

Invitation subject URL can be composed as follows:
'https://github.com/' + notification['repository']['full_name'] + '/invitations'

Any help?
No idea why @GitHub don't put it in the JSON!?

Yeah, good question.
The thing is, where we'd want to construct the URL, we do not have access to the notification['repository']['full_name'] unless we break open the JSON parsing. Any idea how we can decently construct it in the Subject?

Funny that this is supported in the watch app as that does not need identifier / URL to display the notification 😂


feat: add dnote/dnote/cli

dnote/dnote/cli: A simple command line notebook for programmers
$ aqua g -i dnote/dnote/cli

How to confirm if this package works well
Reviewers aren't necessarily familiar with this package, so please describe how to confirm if this package works well.
Please confirm if this package works well yourself as much as possible.
Command and output
$ dnote
Dnote - a simple command line notebook

Usage:
  dnote [command]

Available Commands:
  add         Add a new note
  edit        Edit a note or a book
  find        Find notes by keywords
  help        Help about any command
  login       Login to dnote server
  logout      Logout from the server
  remove      Remove a note or a book
  sync        Sync data with the server
  version     Print the version number of Dnote
  view        List books, notes or view a content

Flags:
  -h, --help   help for dnote

Use "dnote [command] --help" for more information about a command.

Thanks!

Released. https://github.com/aquaproj/aqua-registry/releases/tag/v3.145.0


NavigationView: Side buttons of the mouse are interpreted as input

Describe the bug
Side buttons of the mouse, which can be used for forward and backward navigation, also cause an input at a NavigationView. If you hover over an item and have previously selected another item and press the back button of the mouse, this is interpreted as input and back command.
Steps to reproduce the bug

Click on a NavigationViewItem
Hover with the mouse over another NavigationViewItem
Click the side mouse button for back command.
The side mouse button is interpreted as input and back command.

Expected behavior
The side buttons of the mouse should not be interpreted as input.
Screenshots
XAML Gallery from MS Store:

Version Info

NuGet package version:
Microsoft.UI.Xaml 2.4.0-prerelease.200322001

Windows 10 version
Saw the problem?

Insider Build (xxxxx)

November 2019 Update (18363)
Yes

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes>

Mobile

Xbox

Surface Hub

IoT

Additional context

The desired behavior is that mouse button 4 would go to the previous selection and mouse button 5 would go to the go to the next selction, undoing a mouse button 4 input, same as backward and foreword buttons on a web browser.
@ojhad for FYI

FYI these are aka XButton1 and XButton2 in PointerPointProperties.PointerUpdateKind.

@StephenLPeters just for clarification: In the XCG sample, when "Date and Time" is selected, when mouse button 4 is invoked, "Collections" should be selected and when button 5 is invoked, "Dialogs and Flyouts" should be selected?

It would be nice if we could limit the input keys that trigger an activation. The problem is just as relevant for Win32.
Perhaps it would be easiest to determine the input key in the ItemInvoked event.

Thanks for reporting this issue.
I've merged a fix for this issue into our internal repo. The fix should be available in a future release of Windows App SDK.

@kmahone
Will the commit be ported to the WinUI 2 branch?
A porting was already carried out recently:
https://github.com/microsoft/microsoft-ui-xaml/commit/9f7c129eee21caddfcbfb3cd8ff8ff44a0fda396

This is not a fix that we plan to service to WinUI2.

That is very unfortunate to hear 😑


db parameters can now be passed to db_parameter_group module

Addresses #1 as well.
Note: Was tested successfully with Postgres engine in RDS.

Thanks for the contribution! You are the first who participated since the official release of the Terraform registry 👍


Fix: improved the location of the arrows in the default schedule details popup(improvement #568)

Please check if the PR fulfills these requirements

[x] It's submitted to right branch according to our branching model
[x] It's right issue type on title
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[ ] It does not introduce a breaking change or has description for the breaking change

Description

AS-IS

TO-BE

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

ok to test


Menu icon rendered on homepage only

Menu icon is rendered on homepage (modular) only and not on the other pages (i.e. blog). Noticed in quark theme.

That is by design in Quark theme.
If you want the custom menu items to be shown in regular/default pages, you'll need to copy the logic from modular.html.twig (See /templates/modular.html.twig#L34-L41) into partial /templates/partials/navigation.html.twig


Adding QM instances for security and dependability

Diagrams need evaluation

Overall I think the current quality model is not able to correctly represent the metrics involved in the calculation of the "Dependability" and "Security" measures.
For example, MTTF and MTTR cannot be directly calculated from Latency and from the "number of CPU events", but need further processing. At least in my understanding.

The QM for security seems to work for design time as all attributes are related to code-level metrics.
I understood that this diagram aims to calculate a metric for security from other three composite attributes related to Volume, Coupling and Complexity. Those three are also composite attributes.
The semantic of the diagram looks OK for me. However I would like to see an actual implementation in the future.

Closing because included in latest changes to #61


rasterize broken documentation

just a headsup - the example where a shapefile gets rasterized is broken. https://rafaqz.github.io/Rasters.jl/stable/#Rasters.rasterize
My usecase is that I have 2 shapefiles with different coordinate systems. I want to convert them to the same format, and then plot them. Is Rasters the right package for the job?

Thanks, sorry something recent must have broken it. I'm actually rewriting that for the new GeoInterface 1.0 currently, so it will be working soon. An older version will also work.
And no. Raster.jl doesn't manipulate shape data, it just uses existing geometries for rasterizing/masking etc. You can problably do that conversion with ArchGDAL.jl. And geometries will plot with Plots.jl automatically.

Indeed, archgdal turns out to be what I need :)


Remove "Running" from README

Users would get confused if "Running" section shows some unworkable instruction. We should put it back on README once PackageControl thing is done.

Good thinking :)


buildEnv: allow custom environment variables to be set

Motivation for this change
buildEnv allows for a postBuild step, but doesn't provide a mechanism for setting environment variables during that step besides inlining them into the bash string (which could have problems e.g. with special characters). This adds an environment parameter which allows environment variables to be set.
Things done
Not really anything to test here; none of the existing libraries use this. I've build envs of my own using this parameter, and it works.

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[X] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

The commit is authored by 'Test'. Is that intentional? :)

@danbst Whoops, not sure how that happened...

@edolstra This has been sitting here for a while, any chance it could get merged?

/cc @Mic92 bump?

One thing to note is that you can do away with passthru, meta, and buildInputs once you have this.

@adnelson @Mic92 Any update on this pull request?

@GrahamcOfBorg eval

@Mic92 do you wish to keep this open?

I don't think this is useful, since you can do what you want by just doing overrideAttrs on the buildEnv derivation then adding your postBuild and all necessary environment variables there.
I'm in favor of closing this.

In addition to @L-as, for consistency we'd have to allow this everywhere, which is not feasible and not necessary.


Attack String Length for GCG

Hi, thanks for updating this repo. In Appendix A.2 of the paper, you mention that the attack string length for GCG is 20 tokens. I was wondering how to control the attack string length for GCG. Thanks!

Hi, we did not include the GCG attack code in this repo. To change the attack string length and generate new attack strings, please refer to the original GCG repo: https://github.com/llm-attacks/llm-attacks. Thanks.

Thanks for your reply. I can't find the corresponding hyperparameter or function in the GCG codebase to control the attack string length. I am curious about how you did it. Therefore, I will be sincerely grateful if you could provide some information. Thanks.


Updated hamming distance.cpp

Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Fixes #(issue_no)
Replace issue_no with the issue number which is fixed in this PR
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
[x] Documentation Update

Checklist:

[ ] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have created a helpful and easy to understand README.md
[x] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

Pls review PR$1114

@Adarsh357 mention issue number and not PR number

Issue number:#1114
On Tue, 22 Jun 2021, 8:41 pm Amit Kumar Mishra, @.***>
wrote:

@Adarsh357 https://github.com/Adarsh357 mention issue number and not PR
number
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Ayush7614/Daily-Coding-DS-ALGO-Practice/pull/1114#issuecomment-866069270,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASTXC7IKZRCKRP52TZJRXDTTUCRZTANCNFSM4633I3FQ
.


update dockerfile

Signed-off-by: siddontang<EMAIL_ADDRESS>
What have you changed? (mandatory)
Regenerate dockerfile
Please NOTE that:

Do not assume reviewers understand the original issue

What are the type of the changes? (mandatory)
The currently defined types are listed below, please pick one of the types for this PR by removing the others:

Misc (other changes)

Update dockerfile
How has this PR been tested? (mandatory)
Manully
Does this PR affect documentation (docs) or release note? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No
Refer to a related PR or issue link (optional)
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)
PTAL @brson @iamxy

PTAL @brson @iamxy