GEODE-6717 Logging out when all JMX connections are closed

Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[x] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

I was wondering about the same thing as @jujoramos , maybe the numOfJMXConnections should be a thread local?

Sorry, I made a mistake while pushing new commit. I will close this and open new PR. Sorry again for spam.


Occurred error on stack new-template.

Environment

MacOS Mojave 10.14.6
VSCode 1.43.0
stack 1.2
hie 1.2, Git revision 35f62cffb6bae6c3f86113cb0c55f52b7192689d (3841 commits) x86_64 ghc-8.6.5

Reproduction steps
stack new my-project --resolver ghc-8.6.5

Generated sources of new-template.
cd my-project
code . # open vscode

When open Setup.hs on vscode, the error occurred.
Error Message
Fail on initialisation for "/Users/username/src/github.com/username/my-project/Setup.hs".
Could not obtain flags for: "Setup.hs".

This module was not part of any component we are aware of.

Component: ChLibName ChMainLibName with source directory: ["src"]
Component: ChExeName "my-project-exe" with source directory: ["app"]
Component: ChTestName "my-project-test" with source directory: ["test"]

To expose a module, refer to:
https://docs.haskellstack.org/en/stable/GUIDE/
If you are using `package.yaml` then you don't have to manually expose modules.
Maybe you didn't set the source directories for your project correctly.

stack build is completed successfully.
Do you have any idea?

Setup.hs is a special file and hie does not have support for it yet. You should be abale to open other files (inside src or exe dirs) though.
See https://github.com/haskell/haskell-ide-engine/issues/1650

@jneira Thank you.
I will watch #1650 discussion.

Feel free to reopen, if it turns out, it wasnt a duplicate of #1650


Capabilities

Is it possible to request capabilities based on greater than type of a comparison, for example OS version > 10.0.14939?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 47625b86-abd5-ee15-6d61-8bcf81861b96
Version Independent ID: be9a6174-a69b-7aed-d584-5f602fcc5eb4
Content: Build and Release Agents - Azure Pipelines & TFS
Content Source: docs/pipelines/agents/agents.md
Product: devops
GitHub Login: @andyjlewis
Microsoft Alias: alewis

Demands are limited to existence and equality.


Update owlapi-distribution to 4.5.28

About this PR
📦 Updates net.sourceforge.owlapi:owlapi-distribution from 4.5.16 to 4.5.28
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "net.sourceforge.owlapi", artifactId = "owlapi-distribution" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "net.sourceforge.owlapi", artifactId = "owlapi-distribution" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #88.


Configure app base path

Hello,
I'm serving mesos-ui (and the rest of my infrastructure) as a Marathon app behind a reverse proxy. It would be great if there was a way to configure the app base path.
Right now, it is assumed to be /. If mesos-ui is served behind, let's say /mesos-ui, the Javascript and CSS cannot be loaded.
Is this on the roadmap?
Thanks. Antoine.

Hello,
I have same issue. Could you do fix or indicate the way to do the fix ?
Thanks
Benoit


added Keras code

Hi Mohammad,
thanks a lot for adding tf/keras code!
I am not knowledgable about tf/keras but it looks like your implementation of deep4 is missing the batch norm layers.
Is this correct?

Hi,
I know, you are right.
I have added batch norm layers.

Thanks a lot for your efforts. I am a bit hesitant to put it into the main braindecode as I am not sure we will have resources to support two different implementations, this will anyways only have trialwise, not cropped decoding, right? Is there a way to add cosine annealing to your example?


Activity type for groups in VLE

In some VLE systems you have the concept of groups, such as this from Canvas:
https://community.canvaslms.com/docs/DOC-10717

Groups are a small version of a course and used as a collaborative tool where students can work together on group projects and assignments.

I cannot find a sensible activity type to use for these events.  Can you reccommend something or do we need something new?  I could just log it as 'other' but I think we would lose useful information.
https://github.com/jiscdev/xapi/blob/master/vocabulary.md#activity-types

this is calling to as: requirement = recipe for collaboration spaces
I agree: just bucketing as a non-specific resource view is not really a good fit
However: semantic models for collaboration get messy very fast, so I;d be inclined to model this fairly non-specifically in terms of what was done to what... e.g. keep it as simple as "did something [active] in a collaboration space"

Agreed to keep it simple which to me means adding an activity type of 'collaboration_space'.  We can capture more detail in the subtypes if necessary.

I don't know the use cases here, so just checking I understand this:
What we are talking about is a new statement template for:
Agent (Actor) did whatever (verb) in collaboration_space (object)
What we are not talking about is the xAPI actor objectType 'group', which can be anonymous or identified which let us say:
Group (Actor) did whatever (Verb) in whatever activity (object)
Or
whoever (Actor)  did whatever(Verb) to Group (Object)

The first one:
Agent (Actor) did whatever (verb) in collaboration_space (object)
That collaboration space should be attached to a course/module however so I'm not sure if the object needs to be the space or the course/module.  There would also be subtypes to define what the have done in the space e.g. group files, group discussions etc.

I think we can cover the course/module with the courseArea extension.
If it's "Agent (Actor) did whatever (verb) in collaboration_space (object)", then the courseArea fits in context. And a subType for the collaboration_space object makes sense.

For Feb 5th call:
The following was added to the vocab

LabelCollaboration Space
Description A collaborative space where students can work together on group projects and assignments. For example Cavas Groups
IRI http://xapi.jisc.ac.uk/collaboration_space

Double check requirements, is this just a different object that fits in to exisiting VLE statements? This is not a new statement
are examples required anywhere (I'm not sure of use)
Check this is not about the xapi concept of groups in the agent


Greenfields landing zone accelerator, needs none option on On-prem section

Greenfields landing zone accelerator, needs none option on On-prem section
Not all customers are doing a migration and the current options of ExpressRoute or vpn could be confusing. There should be an option for none to make this as simple as possible.

Agree @WKahnZA , will have this released soon

@WKahnZA  adding this to Oct sprint

@shaunjacob Can we have this release in Nov ?

On-prem is being considered to added as a brownfield scenario. Work in progress
@shaunjacob

@prasad3017 and @shaunjacob (@shaunjacobmsft) - I'm following up on this one.  I noticed in the latest UI release, we now say "ExpressRoute (skip)" as an option.  Is this sufficient to close this request, or should we change this to "ExpressRoute or No On-premise Connectivity" to highlight this is the option that should be selected when not making an on-premises connection?

@shaunjacob We will discuss todays sync to discuss about this

@shaunjacob Could you please suggest if we are ready to post the new code this month?


iOS FLAVORS Issue when adding additional dependencies and fails to builds on iOS

I am following the Creating flavors for Flutter->Flavoring Flutter on iOS.
But building failed when just only adding a dependency like "sqflite: ^1.1.1" clone from flutter_flavors.
The error message is "The sandbox is not in sync with the Podfile.lock".
I tried "pod reintegrate, pod install" but the issue still exist until remove the dependency.
My project is building well without any flavors support.

same issue as here

Similar #19252 #1842 #15567 #14648

answer


Old module.json

The module.json was not properly updated for version 12.0.0. It's still the one for version 1.0.0.

Thank you for bringing this to my attention. It's been a few months since I originally started this project, and I had forgotten all the steps I needed to do along the way.
This should now be fixed in v12.0.1


Accessibility Audit: Improper announcement for the "City of Detroit" graphic

ENVIRONMENT
Mobile: OS | OS Ver | Assistive Technology
Pixel 3a XL | Android 12 | Talk Back
PREREQUISITES
Ensure the Screen Reader is on, and go to the homepage. Navigate to the "City of Detroit" logo and observe the screen reader announcement. As you can see in the attached video, the announcement for the "City of Detroit" icon is "Site Logo Graphic icon". The focus should not be shown on the "Site logo" icon as it is not rendering any meaningful information to the user, all the icons which are decorative should not have the focus.
NOTE: I was not able to replicate this in Voiceover in a Chrome on my Macbook.
https://user-images.githubusercontent.com/394908/148608116-f512442d-c076-451e-9343-aa52f61007ef.mp4

No longer valid


I created a tribute page for Dr Br ambedkar

please merge my pull request under the label of hacktoberfest-accepted

Follow all rules in order to get hacktoberfest-accepted tag
https://github.com/shubham7668/WebDev#rules

Okay sure...


PairStore is not synchronised through multiple browser tabs/windows.

Reproduce:

Open the website on two tabs of the same browser;
On both tabs, choose a new pair of fonts;
On the first tab, save this font;
The same pair will not be displayed as saved on the second tab and won't appear on the list of saved pairs in the sidebar;

The isssue is that the new pair should be displayed as saved in the second tab and should also appear in the sidebar.

Fixed.
See 3755fde43a131b9505406d0b7b9a196ddad896cf.


ANN: nipreps/eddymotion team created for maintainers

Permissions are very flexible in GitHub, and people can have access to a repository by being an organization member, collaborator, or specifically invited and empowered on the repository itself. To simplify matters, I created a nipreps/eddymotion team for "maintainers". By adding someone to this team, they get maintainer-level permissions on the repository and this team is also authorized to sign off on releases in the newly created Release environment (you will probably need admin to follow that link).
I have populated the team with a first pass group of people: https://github.com/orgs/nipreps/teams/eddymotion/members
Org admins should feel free to add themselves or anybody else that should be a part of this team.
We can also be more explicit and rename to eddymotion-maint or similar, if you want to have a broader eddymotion team for less privileged contributors.

cc @nipreps/eddymotion

Renamed to @nipreps/nifreeze


FancyZones Error log

Microsoft PowerToys version
"0.45.0"
Running as admin

[X] Yes

Area(s) with issue?
FancyZones, FancyZones Editor
Steps to reproduce
I am using 2 displays, 1 is connected via HDMI cable, another via DP cable. OS: Windows 11 Home Beta 21H2 (Windows Feature Experience Pack 1000.22000.194.0)
Step to reproduce the error:

Wait until the display was turned off (by windows screen off timer).
Wake the screen.
FancyZones will revert to default 1 | 2 | 3 layout from any preset layout. (I assume this is a bug as well)
Open PowerToys from the icon tray.
Navigate to FancyZones
Launch FancyZones Editor.
Close FancyZones Editor.
Error.

✔ Expected Behavior
2 expected outcomes.

When waking the screen, FancyZones should work on the preset layout instead of the default ones.
The FancyZones Editor should close without an Error message.

FZEditorCrashLog.txt
❌ Actual Behavior

FancyZone displays default 1 | 2 | 3 layouts instead of whatever preset layout.
The FancyZones Editor gives an error log.

Other Software
Apps that were open on the desktop
Chrome v93.0.4577.82
Unity Editor v2020.3.14f1 Personal edition
TLauncher 2.82
Spotify
Discord
Whatsapp Desktop client
Tray Icons
Nvidia broadcast
Nvidia experience
Malwarebytes
Steam
FreeDownloadManager
Twinkle Tray

Thank you for reporting! Could you please attach a bug report here?

Duplicate of https://github.com/microsoft/PowerToys/issues/13105

PowerToysReport_2021-09-23-08-57-21.zip

Thank you!

fyi, this was fixed with 0.49.


Remove services/tags/layers from effect-mongodb

We will create a new package for services/tags/layers

We created a new (private) package @effect-mongodb/services


ARROW-16128: [C++][FlightRPC] Fix Flight SQL static build on Windows

Removes non-std initializer list
Sets ARROW_FLIGHT_STATIC to match ARROW_STATIC when ARROW_BUILD_STATIC
and WIN32
Updates the documentation arrow staticly linking on windows to include
the ARROW_FLIGHT_STATIC definition, including an example

The goal of this is to allow flightsql to build easily on Windows.

Could you open a JIRA issue and replace MINOR: in the title of this pull request with ARROW-XXX because this is not a MINOR change?
See also: https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#minor-fixes

My understanding is that after approval I should squash and rename the base commit to align with the pull request name. Is that correct?

The merge script will take care of that.


Cannot read property 'apply' of undefined

address scenario where the value of arguments[i] is undefined

:+1:

Don't pass undefined.

@sokra This was an issue that came up at an Angular presentation by PatrickJS. Windows users that cloned the project and tried to run it (like myself) saw this error while the mac users did not (even with the same version of Node, NPM, etc..) and in the end, was a simple logic issue that I submitted a PR for at https://github.com/rainabba/tapable/commit/5218309c15c0165e1c87990bb086b622df6f838e.
That said, what was the point of your comment and why is this closed without the PR being applied and while the bug exists?

It's maybe a bug, but not here. apply expects objects that have a apply method. The bug is maybe in a higher level which passes something wrong into apply.

"apply expects objects that have a apply method."  So better to leave this code fragile than add the simplest of computational checks to make it more robust?
In a very real-world scenario, an entire project ran on one platform and not another because of something much higher-level (and harder to address) because this project is missing such a simple check to address an assumption you just declared.

So better to leave this code fragile than add the simplest of computational checks to make it more robust?

Yes, I think so.
It's better to throw an error to indicate that there is a error on a higher level, than to silently ignore it and leave the higher level uninformed.

it seems like the preferred "fix" is to provide the user with the correct feedback (suggest that the problem is due to the plugin) otherwise you will get more issues such as this or https://github.com/webpack/webpack/issues/1632

Okay. I that makes sense to me. Thanks for helping me understand. Admittedly, error handling is an error I need to improve in :)

Would it make any sense to then use a similar check with an else to throw a more informative error? Any reason that wouldn't be advisable?


License deed pages have malformed comment appearing above header

All of the license deed pages have a malformed comment which is appearing above the header:
!-- Google Tag Optimize -->
Example URLs:
https://creativecommons.org/licenses/by/4.0/
https://creativecommons.org/licenses/by-sa/4.0/
https://creativecommons.org/licenses/by-nd/4.0/
https://creativecommons.org/licenses/by-nc/4.0/
https://creativecommons.org/licenses/by-nc-sa/4.0/
https://creativecommons.org/licenses/by-nc-nd/4.0/
The legal code pages for the licenses are not affected.
According to web.archive.org it looks like this error was just introduced today (December 1).

thanks for reporting this, @Ythan, we're on it.


Revert breaking changes introduced by PR#3195

Small regression with 'mvcoptions.AllowEmptyInputInBodyModelBinding = true' was also fixed later by b7883ef3bd within PR3117. And my fix was definitely done in wrong place.
Now IsRequired and IsNullable during schema generation are calculated based on AllowEmptyInputInBodyModelBinding as well and that is great.

Ref: https://github.com/RicoSuter/NSwag/pull/3195/files

See also https://github.com/RicoSuter/NSwag/pull/3331 (duplicate)


Help term()->search() with paginate

How to paginate term search
$result = Story::term($terms)->search();
$records = $result->paginate(10);
[Method Illuminate\Database\Eloquent\Collection::paginate does not exist.]

Hey @SergejGuruliov , documentation is in the process of being redone but you can do full text search now with normal get() type queries since v4.2.0
You can do:
$result = Story::searchTerm($term)->paginate(10);
//Or
$result = Story::searchTerm($term)->searchTerm($term)->paginate(10);
$result = Story::searchTerm($term)->orSearchTerm($term)->paginate(10);

See  v4.2.0
Cheers


[New Port Request] srdfdom

Library name: srdfdom
Library description: Parser for the Semantic Robot Description Format (SRDF)
Source repository URL: https://github.com/ros-planning/srdfdom
Project homepage (if different from the source repository):
Anything else that is useful to know when adding (such as optional features the library may have that should be included):

Note: This library has a part that uses python in CMakeLists.txt, should be skipped.
Also catkin is not available in vcpkg.

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


clangd cannot recognize variable defined in linker script

in xxx.c i have:
extern u32 v1; /*in x.lds*/
u32* v2 = &v1; /* error happened here: Initializer element is not a compile-time constantclang(init_element_not_constant) */

while v1 was invoked in my makefile with -T option and just doing well, but clangd cannot recognize it even when i add the specified flags to CompileFlags scope in .clangd file under ${workspaceFolder}
can i have some help or have you encountered the same question? thx.

Sorry, I'm not very familiar with linker scripts. Could you give a complete example (including the script in question, and .clangd and other relevant metadata files) so that I can try to reproduce locally?


Add type parameter variance to Action and other interfaces (e.g. by converting Action.java to Action.kt)

Expected Behavior
It would be nice if the Kotlin compiler could understand that the type parameter in Action<T> effectively means Action<in T>.
There are two possible solutions:
a) convert the interface to Kotlin. That should be trivial as the interface has no dependencies: https://github.com/gradle/gradle/blob/e5fb17dca9812cf1e50846abd71b15bd90e5a732/subprojects/base-services/src/main/java/org/gradle/api/Action.java#L23-L30
One of the implementations could be
public fun interface Action<in T> {
    T.execute(): Unit
}

Just in case you wonder, the following does not work yet:
public fun interface Action<in T>: T.() -> Unit { // <-- inheritance from an extension function is not yet supported
    T.execute(): Unit = this.invoke()
}

b) Attach Kotlin metadata as an annotation to the java interface. That might be a bit more challenging, however, it is the way to go if you absolutely want to keep Action implementation in Java.
The same might be relevant for other interfaces: Provider, Transformer, etc.
Current Behavior
Currently, every usage of Action<...> requires the user to manually specify Actoion<in ...>, and it is quite easy to misuse the action.
Well, in Java it has to be Action<? super T> which has to be duplicated on every usage. Java has no way to enforce that, however Kotlin can declare type variance once, and it would automatically identify errors when using improper types, and it would automatically generate Action<? super T> signatures in the bytecode.
Context

https://youtrack.jetbrains.com/issue/KT-41062#focus=Comments-27-5752006.0-0
https://gist.github.com/vlsi/3e7c6a0aa3f13ec0cfc94c0f7447ceb7

Another case is Provider.
The lack of variance in Provider makes Kotlin DSL weird when it comes to the configuration cache: https://github.com/gradle/gradle/pull/21555/files#r957707942


[Q] Metric data exceeds maximum size of 4.1MB

My log is not synced after 250k steps. When I sync the log manually, the following error occured.
wandb: ERROR Metric data exceeds maximum size of 4.1MB (4.2MB)
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib64/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/usr/local/lib/python3.6/site-packages/wandb/sync/sync.py", line 209, in run
    data = ds.scan_data()
  File "/usr/local/lib/python3.6/site-packages/wandb/sdk/internal/datastore.py", line 131, in scan_data
    record = self.scan_record()
  File "/usr/local/lib/python3.6/site-packages/wandb/sdk/internal/datastore.py", line 115, in scan_record
    assert checksum == checksum_computed
AssertionError

My model is rather large, when wandb.watch(model) is used, the metric file would exceeds 4m soon. How to change this limit?

Hey @bfs18 , I'm not sure if there's an option to change the limit, but you might want to change/decrease the logging frequency as a workaround for the issue.

The other thing that could be causing this is logging numpy arrays or other large data structures in your calls to wandb.log.

Hey @bfs18 , I'm not sure if there's an option to change the limit, but you might want to change/decrease the logging frequency as a workaround for the issue.

Hi @tyomhak , thanks for your reply, I comment the watch line.


Query

May be very stupid question but i found you always used class loss along with main loss function which is mentioned in paper. Class loss is CE loss between targets and predicted logits.
is it something supervised contrastive learning or  am I reading the code wrong.

Just a weird question.
How does it predict logits when target is not defined for the problem(self-supervised) ?
what i mean may be in real target dog is class 1 but in our self-supervised model, it could be class 2.
https://github.com/vturrisi/solo-learn/blob/4c195ca066a24ad6569f713f65137c8e1117a839/solo/methods/base.py#L401
i know it works but don't know how it works ?

hey,
the dataset classes expect that your data is organized in sub-folders (one for each class), so in the targets you actually have the right label

One more thing. I am trying to install umap via  pip resources (pip install umap) where the library doesn't have the functionalitites used in the codebase.  There is a library named umap-learn which matches to the code used in auto_umap.py. Can you please confirm about it ?

Hi, you can find all the required packages for using UMAP at this line:
https://github.com/vturrisi/solo-learn/blob/4c195ca066a24ad6569f713f65137c8e1117a839/setup.py#L8
Also, the best way to install solo-learn with UMAP support is to just run:
pip3 install .[umap]


Add google colab support for notebooks

Description
PR adds support to open the notebooks in Google Colab so that it would be easier for developers to run through the notebooks.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[X] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[X] I stared at the code and made sure it makes sense

Suggested Checklist:

[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[X] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Ooooh ya this is a good idea. Thanks @ravi03071991 !
Question, is the plan here to add this to every single notebook we have in the repo?

Yeah, I believe this will be a valuable experience for developers. I will begin with the most commonly used notebooks and eventually expand to include all of them. Additionally, it would be beneficial to have Google Colab support for any new notebooks we introduce moving forward.

hey @ravi03071991, are still planning to wrap up and land this?

hey @ravi03071991, are still planning to wrap up and land this?

@Disiok I will complete it in the next 2-3 days.

@Disiok The checks aren't running, and I don't have permission to resolve the conflicts. Can you assist me with this?

@Disiok completed the support of google collab for notebooks. Please review and merge.

This is massive! Amazing work@ravi03071991


postgres first line comment shows no results

It seems that having a -- comment on the first line of a cell causes no result to be displayed by postgres.  e.g.,
-- new query
SELECT *
FROM pg_catalog.pg_tables;

Shows no result,. but
SELECT *
FROM pg_catalog.pg_tables;
-- new query

Shows results.

This is easy to fix!
I'll open a PR...
There's so much stuff I want to rewrite in this software though! 😅


Fix remove mappings

Summary
The -r to remove mappings wasn't working correctly. This change fixes that and adds an integration test.
Test plan
There's a new integration test covering this.

Codecov Report

Merging #93 (5b4e244) into main (d9b13ff) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   33.76%   33.74%   -0.02%
==========================================
  Files          40       40
  Lines        6306     6309       +3
  Branches     3451     3454       +3
==========================================
  Hits         2129     2129
- Misses       2298     2300       +2
- Partials     1879     1880       +1

Impacted Files
Coverage Δ

src/OID.cpp
17.71% <0.00%> (-0.16%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Set up fly.io deployment from github repo branch

A concern: How to keep the "flagship" deployment separate from the open source project available to deploy elsewhere? Need a separate repo? Is a releases/prod branch good enough?

Will worry about that later... set a FLY_API_TOKEN env var and things seem to have worked!
https://github.com/lmorchard/pebbling-club/actions/runs/10713189997


Query Metadata from Openstack

Hi,
I am writing the metadata info while launching instances using terraform on Openstack. For Ex, if i launch 3 instances, master_count will be 3. But I am not sure how can i get this info from Openstack.
metadata {
master_count = "${count.index+1}"
myid = "${count.index+1}"
cluster_name= "jenkins_mesos_master"
}
How can I query the metadata similar to the below method used in google?
echo "getting metadata"
MASTERCOUNT=curl -H "Metadata-Flavor: Google" "http://metadata.google.internal/computeMetadata/v1/instance/attributes/mastercount"
CLUSTERNAME=curl -H "Metadata-Flavor: Google" "http://metadata.google.internal/computeMetadata/v1/instance/attributes/clustername"
MYID=curl -H "Metadata-Flavor: Google" "http://metadata.google.internal/computeMetadata/v1/instance/attributes/myid"
until terraform supports math functions, we need to do this here
((MYID+=1))
Thanks,
Govind

I'm not really familiar with OpenStack but you might be able to find an answer here: https://wiki.openstack.org/wiki/MetadataSearchAPI


merge lower into verify

@anandijain some files I changed contain @anand where I think you should pay particular attention to.

this isn't a good idea. we only have solution data for the test suite. lower_one is currently generic to biomodels and the test-suite.
my opinion is to give up on #41 and just do the following once both lower_fns and verify_all are done:
suite = CSV.read("../data/suite.csv", DataFrame)
verified = CSV.read("../data/verified.csv", DataFrame)

suite[!, :file] .= basename.(dirname.(suite.file))
verified[!, :dir] .= basename.(verified.dir)

df = innerjoin(suite, verified; on=[:file => :dir], makeunique=true)

this isn't a good idea. we only have solution data for the test suite. lower_one is currently generic to biomodels and the test-suite
That is a valid point. I haven't thought of this.  Where we don't have true simulation data we call lower_all, for the test suite we call verify_suite. I can also wrap the shared code of verify_case and lower_one in a function to avoid code duplication (which simplifies code maintainance. Would't cost much time and is probably worth it in the long run).


How to make multiple lines in Hardbound-cover.tex

Hi Authors,
I tried to make the multiple lines in Hardbound-cover.tex,
But it was not sussess,
Would you give me any solution?
Thanks,

Hi Authors, I tried to make the multiple lines in Hardbound-cover.tex, But it was not sussess, Would you give me any solution?
Thanks,
Hi, @NamDinhRobotics , thx for your comments,
May I know what's multiple lines means? where should we put it?  and why should we add it? haha, less likely we will update it, as we already graduated, but please keep this repo updated to help more poor NTU PhD or MEng.  🤣

@NamDinhRobotics,
You can try changing the line \put((21cm-\widthof{\textbf{\Large\ttitle}})/2,14){{\Large\textbf{\ttitle}}} to the following:
\put((21cm-\widthof{\textbf{\Huge{Line 1}}})/2,14){{\Huge\textbf{Line 1}}}

\put((21cm-\widthof{\textbf{\Huge{Line 2}}})/2,12.5){{\Huge\textbf{Line 2}}}

where "Line 1" and "Line 2" are your title lines.

Great,
Thank you so much, BII-wushuang,


[Task]: Increase the preview data limit

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks

Increase the limit for suggested templates to show preview data on datasource view tab

Please elaborate, and if possible provide some screenshots.


large_heap_fragmentation_unittest fails: heap_size ends up being > 1GB

The check CHECK_LT(heap_size, 1*1024*1024*1024); fails.
(gdb) p heap_size
$1 =<PHONE_NUMBER>

Version: 2.15
FreeBSD 14.1-STABLE stable/14-n267671-9a8a26aefb36

This test doesn't seem to exist in the latest master revision.


Could you give me BTP upper tester demo which can work on PC

Hi friends,
I'm interested in BLE of Zephyr, I want to do some test for Zephyr BLE using Bluethooth tester.
But I don't find upper tester demo which can communicating with zepher tester(zephyr\tests\bluetooth\tester) through BTP protocol.
Could you give me some upper tester demo which can work on PC ?
Thanks
shijun

There's tools/btpclient.c in BlueZ that you could use: https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/tools/btpclient.c


Add new params to AWS::EC2::VPCEndpoint type

On June 21st, 2018, AWS added CloudFormation support for the following params:

Use the PrivateDnsEnabled property to indicate whether to associate a private hosted zone with the specified VPC.
Use the SecurityGroupIds property to specify the ID of one or more security groups to associate with the endpoint network interface.
Use the SubnetIds property to specify the ID of one or more subnets in which to create an endpoint network interface.
Use the VpcEndpointType property to specify the type of endpoint.

CloudFormation Release History
AWS::EC2::VPCEndpoint CloudFormation

@TheRealBenForce this issue is addresses by this pull request https://github.com/cloudtools/troposphere/pull/1085

@cigan1 did you check my reference above? #1084

@hese1 yes sir I see it. Looks like we need to consolidate. How do we do this?

@cigan1 Added you as a collaborator in my fork, care to add the validator stuff there? Branch name 'update-vpcendpoint-properties'

This was released in 2.3.1 on 2018-07-01.


Extra line breaks added in empty script tags

I know you said in #29 that you were ignoring script tags, but when I have an empty script tag the formatter is taking it from:
    <script src="https://cdn.datatables.net/v/bs4/jszip-2.5.0/dt-1.10.18/b-1.5.2/b-html5-1.5.2/b-print-1.5.2/datatables.min.js"></script>

to
    <script src="https://cdn.datatables.net/v/bs4/jszip-2.5.0/dt-1.10.18/b-1.5.2/b-html5-1.5.2/b-print-1.5.2/datatables.min.js">

</script>

Obviously, this doesn't break anything, but it does make the code look odd.

This has now been fixed in the latest update 😄 But please let me know if you have any other issues.


Remove specific report information out of report controller

Extract card and canvas UI component
Add translations for sales amount report labels

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@53c5c20). Click here to learn what that means.
The diff coverage is 22.22%.

@@            Coverage Diff            @@
##             master     #420   +/-   ##
=========================================
  Coverage          ?   73.44%
=========================================
  Files             ?       67
  Lines             ?     3302
  Branches          ?      336
=========================================
  Hits              ?     2425
  Misses            ?      767
  Partials          ?      110

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53c5c20...ce1d082. Read the comment docs.


Clipboard helpers were added #15

Few functions connected to the windows clipboard were added and a wrapper around it.
will update my pull request in the future, please don't merge yet. created it for the sake of knowing what im doing

Clipboard

Can pass IClipboardData
Can read IClipboardData
Allows subscribe option(Post event is not implemented)

Changed samples a bit
Added a console application sample

Wasn't able to solve my problem with a cancelation token in Clipboard tho, maybe make EventLoop().Run() async? I know it should be wraped in the the using statement, but still.
Issue -> #15
22.06.18 Update:
The Win32Clipboard class was moved into a different PR

@prasannavl well, i know it's been a while ago since i opened the PR but i still want it to be merged.

Hi @Trapov, I'm sorry I haven't been able to catch up on this. I've been struggling with some hand surgeries for the last few months, and has been completely off programming. Just slowly easing back in. Unfortunately, I'm still catching up with a lot of the backlog and it may take a while for me to look into the design.
That being said, could you please make a separate PR for the Constants, and User32/Methods? That should really be helpful, but they don't really require any design thought.
PS: For future reference, I also suggest making separate PRs for direct Win32 items (Methods, Constants, etc), helpers, and library features. That helps in merging smaller isolated items without delays. :)

@prasannavl sorry to hear that, get better. Ok, will do like you said.
Also the feature is not nearly done, there are still some things that aren't tested and have bad design, i want to hear your opinion on those, things such us: cancellation token, getting an image from the cliboard and etc.

@prasannavl ok, now this PR is solely dedicated to pinvoke/helper-methods and constants. I can make another one with the Win32Clipboard control, but it will depend from this branch, since it will use the clipboard functions, constants and helpers; not really sure if that's a great idea.

Thank you for the response.

And the GetFromClipboard that's just the data again

@prasannavl I would do that, but since GetClipboardData returns a pointer, i would have to know it exact length/size, to get a byte[] array from that. I could just go thru it and determine where is the end of the array by checking null values, don't really think it's a good idea tho.
Will fix everything else.

Yeah, Clipboard is not a simple API. It's handles a lot of conversions and complexities. In that case, what do you think about just focusing on text instead in the helpers. Just take a string SetClipboardUnicodeText, and GetClipboardUnicodeText, and use CF_UNICODETEXT for both. And use SetClipboardData that uses NULL for the format. But leave out the Get part for that until we can come up with a better design. Meanwhile, the User32 function can always be used directly utilising the pointer.

Yeah, sounds good.

Additionally, SetClipboardData could have an overload with the exact format constants.

@prasannavl what do you think about those apis?

This is great, actually :+1: Just thinking out loud here: Would it be better to have TryGetUnicodeTextFromClipboard as TryGetClipboardUnicodeText? So it has parity with TrySetClipboardUnicodeText.
And also has the minor side advantage of getting nice and relevant autocomplete with or without fuzzy matching, when you type TryGetClip.

@prasannavl, yea that makes sense. Will do.

@prasannavl done. You will probably want to squash all my commits, or rebase, because they don't make much sense in the context of your repo history, imho.

@Trapov If you're still active, you should rebase and push --force-with-lease. That tends to have a cleaner history across repositories. If prasannavl rebased your branch manually or by using GitHub's "Rebase and Merge Pull Request" feature, then the commit history here will be slightly different than your commit history. This makes tracing commits by their hashes back to their origin a but more difficult.
If there are merge conflicts, then prasannavl's conflict resolutions will likely require a new commit, separate from the merge commit. This is because using a merge commit to store conflict resolutions can lead to those conflict resolutions being lost if merge commits are rebased (--rebase-merges).


Add a 404 template

I need an official 404 template to use for " page not found" errors.
Right now I'm using the default Firebase 404 page.

I'm hoping that the scripts on the page still work when the user is redirected to 404.html.
If they don't, I'll reopen this issue.

They work!


Fixed crc32_combine_gen declaration warning in zlib-ng API.

See #1077.

Passes my local testing without warnings, although I don't have any tests testing this function through the exported API.


feat: Allow copier-templates-extensions as an extra

This allows pipx users to use this:
pipx install copier[templates-extensions]

Or this:
pipx run copier[templates-extensions] <args>

Instead of this:
pipx install copier
pipx inject copier copier-templates-extensions

I think this was mentioned a while back, but never added.
I'm not very familiar with non-PEP 621 backends (Poetry. Just Poetry.), so hopefully I got the syntax correct. Also not sure if you want a min version here.

So, because copier depends on copier-templates-extensions (*)
 and copier is 0.0.0, version solving failed.

(The stuff about limits is bogus, because older versions used to have Python caps, that's not the correct solution and would result in the wrong solve)

I could probably just change the dummy version number, not sure if there's a better way to fix this with the poetry-dynamic-versioning hack.

I assume you installed the poetry-dynamic-versioning plugin, right? If so, it seems that Poetry's dependency resolver does not consider the version computed by the plugin but instead simply uses the version from the metadata. I wonder whether the plugin could be extended to let Poetry use the computed version during dependency resolution. Then, hardcoding a sufficiently high though arbitrary version in our metadata would not be necessary.

I assume you installed the poetry-dynamic-versioning plugin, right?

Ah, no, I was just using my brew-installed poetry, which doesn't support adding plugins. I just unlinked my poetry with brew, then installed poetry with pipx and injected the plugin. That fixed it. Other tools (like PDM or Hatch) usually respect your build-system.requires, but Poetry plugins apparently don't.

Nice! The RTD build is failing because poetry-dynamic-versioning is not installed there. This should be fixed by adding poetry self add "poetry-dynamic-versioning[plugin]" to .readthedocs.yml after Poetry is installed. I'm not sure why the two CI / flake-check ... checks are failing though.

Okay, fixed readthedocs. On the nix jobs (CI / flake-check), it's still giving:
Run copier --version
/Users/runner/work/_temp/ede4b13e-8f0d-4491-9ff7-7771f5b39c64.sh: line 1: copier: command not found

The JRMurr/direnv-nix-action@v3 action fails in the Nix Environment setup step with the following error:
  Because copier-templates-extensions (0.3.0) depends on copier (>=6)
   and no versions of copier-templates-extensions match !=0.3.0, every version of copier-templates-extensions requires copier (>=6).
  So, because copier depends on copier-templates-extensions (*)
   and copier is 0.0.0, version solving failed.

I guess the poetry-dynamic-versioning plugin is missing. Will try to look into it some more.

One could want to add any jinja extension to the Copier env. I think I like it better without this PR. Sorry...😅

I'm wondering if copier-templates-extensions shouldn't be integrated into Copier directly, since we have the --trust flag now. That would solve the "you have to inject an extension into the env" issue, and we wouldn't need the extra here.

Makes sense to me.

You mean deprecate the entire project and integrate missing features here?
Yeah, maybe it makes more sense... I never had the need to use it, to be honest. Maybe we can discuss it in a separate issue?
For now, I'll close this. Having this dependency adds some unneeded burden here. FWIW I'd have to fix the flake and the lock file conflicts, things I didn't need to do until now 😆
Just inject the extension in the pyenv like any other and you're good to go with it.
Thanks anyway!

@henryiii, you can now tell your users to use uv:
uv tool install copier --with copier-templates-extensions

:smile:


Weapon's owner field was incorrectly called hero

Thank you! This was solved in https://github.com/tiangolo/sqlmodel/pull/120, so I'll close this one. But thanks for the effort! :cake:


Why not use Sanic-JWT?

Really like this project, I'm starting to hack with it to fit to a custom project, but the bases are super!. I was wondering why not use the Sanic extension for JWT to adapt de microservice architecture. Also I was wondering to migrate from SQLAlchemy to Gino. What do you think?

Hey thanks! At the time I decided to just use PyJWT since I was familiar with it and the implementation/usage is pretty straightforward. That shouldn't have any impact on being able to use it as a microservice; I'm using this as a backend microservice for a project at the moment.
I've looked into Gino a bit (have a comment pointing to it in db_client.py) and it looks like a great project, though I'm not sure if an async ORM is worth the potential complexity. Gino has documentation on the pro's and con's. At the time I went with SQLAlchemy because it's a more battle-tested and mature project. That said, if you use Gino in your project I'd love to hear how that goes, and if the changes are a net benefit an MR here would be great.


[Bug] GEO_CONTAINS: point in a bigger rectangle doesn't work

compiled on x86_64 Debian Buster
commit 3c6264b9b0c200d9a38bf1f37b9e261127a1d261 (devel branch)
LET geojson =
{   "type": "Feature",
    "properties": {},
    "geometry": {
      "type": "Polygon",
      "coordinates": [[[-100, 60],
          [-100,0],
          [90,0],
          [90,60],
          [-100,60]]]}}

LET ArangoDBCologneOffice = [6.939945, 50.932222]
RETURN GEO_CONTAINS(geojson.geometry, ArangoDBCologneOffice)

// returns FALSE, should return TRUE?

Polygon

Is this a limitation from the s2 index? I found nothing in the ArangoDB documentation.
xref d3/d3-geo/issues/169

const turf = require('@turf/turf');

const a = {
  "type": "Feature",
  "properties": {},
  "geometry": {
    "type": "Polygon",
    "coordinates": [[[-100, 60],
    [-100, 0],
    [90, 0],
    [90, 60],
    [-100, 60]]]
  }
}

const pt = turf.point([6.939945, 50.932222]);
const res = turf.booleanPointInPolygon(pt, a);
console.log(res); // true

Remark added to docs:

A linear ring defines two regions on the sphere. ArangoDB will always interpret
the region of smaller area to be the interior of the ring. This introduces a
practical limitation that no polygon may have an outer ring enclosing more
than half the Earth's surface.

https://github.com/arangodb/docs/pull/135
Can the issue be closed?

@baslr Thanks for reporting.
I am closing this issue as fixed since the missing limitation has been added to the documentation (as shown in the previous comment).


⚠ Bofrost.be has degraded performance

In 5b16d4f, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1514 ms

Resolved: Bofrost.be performance has improved in fe282ac.


Update Campus Map

Update campus map, pull new image from site and expand capability to calculate walking time even off campus (TPS map shows areas off campus).

F16 OK (~150-250 pts)

F17 OK (200 pts)


Upgrade using migration tool from BC14 to BC18.2

I am running the same set of processes that ran successfully migrating BC14 to BC18.0.
For a new customer, I installed 18.2 instead of 18.0.
When I run Start-NAVAppDataUpgrade -ServerInstance BC180 -Name "OurISVApp" -version <IP_ADDRESS>, I now get an error:
Cannot upgrade the extension 'GovCon365 by XTIVIA <IP_ADDRESS>' because one or more
dependencies could not be satisfied. Unsatisfied dependencies:
Application by Microsoft <IP_ADDRESS>
At line:1 char:1

Start-NAVAppDataUpgrade -ServerInstance BC180 -Name "OurISVApp" -vers ...

  + CategoryInfo          : InvalidOperation: (:) [Start-NAVAppDataUpgrade], InvalidOperationException
  + FullyQualifiedErrorId : MicrosoftDynamicsNavServer$BC180/default,Microsoft.Dynamics.Nav.Apps.Management.Cmdlets.
 StartNavAppDataUpgrade

Our app is running in the cloud without adding this dependency.
I also installed it in the demo database OnPrem without problems.
Do I need to add this for the upgrade process only?

Figured it out - difference in behavior between 18.0 and 18.2


Asa 6609 & asa 6586

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Need replace html string text from react component

Issue : - we are facing the shortcode issue. we use shortcode {{email}} for email subscription in content and the server provides content as HTML string on the frontend side. we render string to HTML on the frontend side from dengerouslySetInnerHTML react function..
Example : - let description = '
contect here {{email}} content here {{email}} content here
';
we use react dengerouslySetInnerHTML function that convert HTML string to actual HTML.

I'm doing - replacing {{email}} text from react email component but we are not able to insert react component in the string.
Like -  description.replace('{{email}}', <EmailComponent />)

hmm. how do you normally do this in something like create-react-app or gatsby?

Closing this is because this is not related to RS at all.
About your issue, you can't use the replace function because that will insert strings, not components. + react components placed inside the 'dangerouslySetInnerHtml' function will not work as they are not compiled correctly.
The way you are doing it is dodgy at best... + will cause a ton of issues in regards to webpack compilation, code splitting, etc..
If you want the server to decide what content is shown on the frontend, use configs.
server returns a json object,
e.g.
[
{ "element":"paragraph", "content":"this is paragraph content"},
{ "element":"emailcomponent"}
]

And loop over that array and return the react component or html element in your render function.
Beware that this is not an easy way to create a react app, I'm not going to explain in detail how this will work as it is very project-specific. Consider not serving content from the server if possible if you're unsure on how to make this work otherwise.


remove capitalizedNativeCase from Google presets

This isn't the case, and in many cases can encourage incorrect type annotations. The canonical style guide (plus I'm writing this in my full capacity as a Google engineer), allows both cases equally, see the types on "String object" versus "String value".
For a clearer example- capitalizedNativeCase enforces String over string. However, String is a nullable, object form of string. The Closure compiler will then allow null, which might not be what you want.

LGTM

Thanks! I can't merge this - can you do it?

The next release should be soon?
Somewhat relevant to this - do we want to have a discussion/issue about allowing owners to manage the preset config in separate repos? We would need to add them to our package.json and other users would need to manage the version themselves. (Saying this since there's the ability to create your own preset in 2.0) - could be done for jquery, airbnb, google? @jscs-dev

@hzoo You presumably still have to merge my change, even if I'm waiting for the next release.

Ok done. Thanks @samthor


Menus stopped opening

Kiwi browser was working fine until recently, when menus stopped working.
Affected menus
Those menus are the main menu and the context menus that open when tapping and holding a hyperlink or image for around one second.
Main menu
Contains features like refreshing, bookmarking, opening a new tab, and opening an incognito tab.
Context menus
These appear when tapping and holding a photo or a  hyperlink for a second, and contain options such as "save image" and "open image in new tab".
Behaviour
Sometimes, the context menu does not open after tapping and holding a hyperlink or image, but the page's brightness still gets dim, which is the layer between the menu and the page.
Sometimes, the main menu opens invisibly. This means when tapping on the three-dot icon, no menu visibly appears, but tapping in the location of where the options would appear causes the same behaviour as if the options were tapped.
Also, in conjunction to the aforementioned glitches, pages started crashing frequently, showing "Aw, snap!", and the browser occasionally crashes entirely, which shows the error "Unfortunately, Kiwi has stopped working".
Since it did not happen before, my closest guess is that it might have to do something with the system memory (RAM), but it could also be something else.

Can you provide phone model and android Version for reference

Can you provide phone model and android Version for reference pls

Galaxy Note 9, Android 10.
New clue: the cause appears to be a memory leak. The browser's RAM consumption somehow raises over 1.5GB RAM without any tabs open. Might be caused by an extension. However, I did not install any new extensions for some time.
Resetting the app (deleting user data) might fix the problem temporarily, but I don't want to re-install all the extensions again, and the problem might return.


Repo niceties

As Seeds starts to mature, there are some additional details we should add to the repo. For example:

[ ] Readme with getting started instructions
[ ] License (Apache?)

Updated: to be discussed separately:

[ ] Changelog -- see: https://github.com/semantic-release/changelog
[ ] package.json isn't updating with latest release version -- see: https://github.com/semantic-release/git

Added: I was confused looking at package.json in the repo and still seeing 0.1.0. It seems like the release process is bumping up versions but not creating commits of updating that file. ui-components also seems to have that issue (right now you look at package.json and it's 7.2.2 even those the latest release is 12.x)

On the changelog thing, I suppose we could just link to GitHub releases where stuff it getting captured automatically:
https://github.com/bloom-housing/ui-seeds/releases

Question: on the "to be discussed separately" points, should we create issue(s) for them? Do we still want to discuss them?

@jaredcwhite you can create issues! Is this tickey good to go otherwise

per slack, closing


Update landscape.yml

Reference the official Blender mirror on GitHub.

[x] ~5 minutes after opening the pull request, the CNCF-Bot will post the URL for your staging server. Have you confirmed that it looks good to you and then added a comment to the PR saying "LGTM"?

LGTM


6.0 Update needed: Web API to Azure API Management with VS

In my environment I do not get startup.cs anymore. Only program.cs is available.
How is it possible (and makes sense) to work with startup.cs?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d70145c2-e2ba-77fb-050d-44d18354e370
Version Independent ID: 19c98d91-e5fe-5832-6c75-23e677e469a3
Content: Publish an ASP.NET Core web API to Azure API Management with Visual Studio
Content Source: aspnetcore/tutorials/publish-to-azure-api-management-using-vs.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @codemillmatt
Microsoft Alias: masoucou

@Michael-Grosser,  Thanks for pointing out the issue.   It looks like this topic has not been updated to .NET 6.0 which no longer creates a Startup.cs in the template.   That code now exists in Program.cs.  I am flagging this issue as an update needed for that topic.

I think this is a duplicate of https://github.com/dotnet/AspNetCore.Docs/issues/25341.

Closing as dupe of #25341 which is already focused on a 6.0 update of this topic.


StripeSource should be abstract?

In the pre-1.0 branch - it seems all the Stripe objects are declared as abstract models, but StripeSource is not? See https://github.com/kavdev/dj-stripe/blob/%23162-api-updates-through_2015-07-28/djstripe/stripe_objects.py#L399 Is there a reason for this? There is a djstripe_stripesource table in my database.
The parent class of StripeSource (StripeObject) is abstract, as is the child class of StripeSource (StripeCard).
I came across this issue while trying to figure out the best way to delete cards from the database (which I'm yet to do).
Thank you for developing this library!

Hi @jameshiew! Thanks for using it!
StripeSource polymorphic model (see django-polymorphic because we'll be implementing more than just Cards as sources in the future. If you delete the card, the associated StripeSource entry will also be deleted.
You should really use Card.remove() to make sure the card is deleted properly though. (Docs are coming soon as part of this release, sorry).
If you have more questions, feel free to ask.


[models] Implement HRGAN or MASTER

This paper suggests a new architecture: Holistic Representation Guided Attention Network for text recognition model, inspired from transformers, which oustands SAR both in accuracy & speed.
We should implement this model, but the impressive speed results should be handled carefully (X8 speed compared to SAR), since the experiments are conducted on a GPU, and this model is highly parallelable (no recurrency). Is this new model so fast on CPU ?

This one seems to be even stronger


spectest.data in roast needs some updates

should mention that is used currently by Rakudo but can be adapted for other implementations
any rakudo-specific elements (like "make quicktest") should be called out as rakudo-specific.
Remove RT references - describe where tickets should be opened (roast/rakudo/problem-solving)
Do we have a document on fudging? the paragraph here could be replaced to a more complete doc.

What an Augean stables have you just touched!..

* should mention that is used currently by Rakudo but can be adapted for other implementations

This is defined in README.md. We don't need to mention Rakudo whatsoever.

* any rakudo-specific elements (like "make quicktest") should be called out as rakudo-specific.

They should be removed or rather moved into Rakudo Makefile.

* Remove RT references - describe where tickets should be opened (roast/rakudo/problem-solving)

Only roast or problem-solving. Rakudo repo is for implementation errors.

* Do we have a document on fudging? the paragraph here could be replaced to a more complete doc.

README.md has it.
Similar changes need to be done to the tools too.

@coke Thanks! Few more things were done along the way of fixing spectest.data. :)


[Date component] : The calendar doesn't show and it's impossible to set a date

I'm using firefox (v39) and for every date, I don't see the calendar.
Plus, when I try to update the date in the field, it set the date with random values.
The component isn't usuable in firefox.
For example, when I try to change the date I can have something like that :

Duplicate of https://github.com/KleeGroup/focus-components/issues/146


Unable to save projection processor after clearing first output fields added via Projections

False alarm. This is as expected since at least one output fields need to be added in projection processor. Closing it.


c:\vagrant share inaccessible

It appears that even though the VirtualBox guest tools get properly installed during the Packer build, and that they set u p the c:\vagrant share back to the host machine, the share is inaccessible. The fix is to re-install the Guest Tools, which is annoying.
I've seen reports of this being a problem because of a Windows Update, which should not be the case with our build since all the updates happen BEFORE the installation of the Guest Tools. I will try putting the Guest Tools installer later in the build and see if that helps anything.

Looks like I found the culprit: Virtualbox changed the way the Guest Tools are installed in 4.4 and above. I actually "fixed" this in a previous commit but actually totally botched the commands I was intending to run. Re-fixing it here: https://github.com/luciusbono/Packer-Windows10/pull/20

And we're fixed!


hedge updates

add disable auto set position due to some exchange such as bybit has issue with auto set of position mode.
add logging at interval
move check and cancel active orders to start of tick to cancel the active orders at the correct time
move update of last timestamp to only at the end so that network and exchange error will not skip the current hedge cycle.

@nikpz could you help to merge this fix into the codebase?

Merged the PR in behalf of foundation team to development and will be available on the next version 1.14.0


Dockerize bindle

ref: https://github.com/fermyon/installer/pull/100
~It looks like Using Bindle example can't work on the current master branch, so I use v0.8.0 for testing.~ https://github.com/deislabs/bindle/pull/343#issuecomment-1250080411
Start Bindle

Clone this branch.
Run git reset HEAD~1 to keep Dockerfile.
Run git checkout v0.8.0 to check out to v0.8.0.
Run docker build -t bindle ..
Run BINDLE_TEMP=$(mktemp -d).
Run docker run --name bindle -d --restart=unless-stopped -e RUST_LOG=debug -v $BINDLE_TEMP:/bindle-data -p 8080:8080 bindle.

Start consul & nomad

Run consul agent --dev
Run nomad agent --dev

Start Hippo

Clone the latest Hippo.
Run following commands.

export Database__Driver=sqlite
export ConnectionStrings__Database="Data Source=hippo.db;Cache=Shared"
export ConnectionStrings__Bindle="Address=http://<IP_ADDRESS>:8080/v1"
export Nomad__Driver="raw_exec"
export Jwt__Key="ceci n'est pas une jeton"
export Jwt__Issuer="localhost"
export Jwt__Audience="localhost"
dotnet build
dotnet run

Create a Hippo account with username admin and password p@ssword.

Run Spin

Clone the latest Spin.
Run make build.
Run following commands.

export BINDLE_URL="http://localhost:8080/v1/"
export HIPPO_USERNAME="admin"
export HIPPO_PASSWORD="p@ssword"
export HIPPO_URL="http://localhost:5309"

Run spin new http-rust myapp.
In myapp folder, run spin build.
Run spin deploy.

Hi @vdice, I add Dockerfile for dockerize bindle. May you review it when you have time? Thank you.

It looks like Using Bindle example can't work on the current master branch, so I use v0.8.0 for testing.

I think we may want to ensure that the docs example can run successfully with this image as well.  Or at least by the next tagged release -- so we'll want to create issue(s) around the current failing behavior so that they can be fixed.

I think we may want to ensure that the docs example can run successfully with this image at HEAD as well. Or at least by the next tagged release -- so we'll want to create issue(s) around the current failing behavior so that they can be fixed.

https://github.com/deislabs/bindle/issues/344

Test for Using Bindle example with master branch:
Build and setup bindle-server
# build
make build
docker build -t bindle .

# Setup
BINDLE_TEMP=$(mktemp -d)
echo $BINDLE_TEMP
export BINDLE_KEYRING=$BINDLE_TEMP/keyring.toml
./target/debug/bindle keys create<EMAIL_ADDRESS>-f $BINDLE_TEMP/secret_keys.toml

# Start bindle-server
docker run --name bindle -d --restart=unless-stopped -e RUST_LOG=debug -v $BINDLE_TEMP:/bindle-data -p 8080:8080 bindle
docker logs bindle -f

Sign and push invoice
# setup
export BINDLE_TEMP=<path from bindle-server terminal>
export BINDLE_KEYRING=$BINDLE_TEMP/keyring.toml

# create invoice.toml file
cat <<EOF > invoice.toml
bindleVersion = "1.0.0"
[bindle]
name = "mybindle"
version = "0.1.0"
authors = ["vdice"]
description = "My first bindle"
[annotations]
myname = "myvalue"
EOF

# sign invoice
./target/debug/bindle sign-invoice invoice.toml -o signed-invoice.toml -l<EMAIL_ADDRESS>-f $BINDLE_TEMP/secret_keys.toml

# push invoice
./target/debug/bindle push-invoice signed-invoice.toml

# see invoice
./target/debug/bindle keys fetch
./target/debug/bindle info mybindle/0.1.0

Hi @vdice, it looks like we can't use the latest bindle with Spin. Bindle rejects un-signed invoices after this change https://github.com/deislabs/bindle/pull/300/. I will focus on https://github.com/fermyon/spin/issues/689 to fix this issue first.

Hi @vdice, it looks like we can't use the latest bindle with Spin. Bindle rejects un-signed invoices after this change https://github.com/deislabs/bindle/pull/300. I will focus on https://github.com/fermyon/spin/issues/689 to fix this issue first

@FrankYang0529 Yeah that is why the 0.9.0 release is still in an RC. We were giving everyone time to update to the required signing.

Hi @vdice, I updated docs/README.md. May you help me review it again? Thank you.


DB facade alias support

This failing test highlights the issue that the DB alias for Illuminate\Support\Facades\DB is not properly handled by this plugin.
It could be solved with a new src/Stubs/DBFacadeAlias.stubphp:
<?php

class DB extends Illuminate\Support\Facades\DB
{}

However, I wanted to hear if there is a better solution.

Any progress?

I'm still waiting on feedback from the maintainers.

Sorry but I don't use  facades so I don't have much motivation to make them work with this plugin -- however I  will happily merge any PRs that fix the issue!

IIRC in my initial test the additional stub fixed the issue. But now somehow it doesn't. I'll take this up again when I have more time. Meanwhile if anyone is interested in this, please feel free to sugesst a solution.

I had another look: Does anything speak against making the facade stub function static? Since it's a facade, the function should be called statically anyway.

thanks @mzur !


KAFKA-13207: Skip truncation on fetch response with diverging epoch if partition removed from fetcher

AbstractFetcherThread#truncateOnFetchResponse is used with IBP 2.7 and above to truncate partitions based on diverging epoch returned in fetch responses. Truncation should only be performed for partitions that are still owned by the fetcher and this check should be done while holding partitionMapLock to ensure that any partitions removed from the fetcher thread are not truncated. The PR adds this check. Truncation will be performed by any new fetcher that owns the partition when it restarts fetching.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@dajac @hachikuji Thanks for the reviews, merging.

@rajinisivaram Should we also add it to 2.8 branch?

@dajac Yes, merged to 3.0 and 2.8 as well, thanks.


Init React Native Web

Added how to run it in README file
added the admin-web-app project which can be run and show hello world behavior

When I try to your code I receive the following error:
><EMAIL_ADDRESS>start /tmp/amosss182/admin-web-app
> react-scripts start

sh: react-scripts: command not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>start: `react-scripts start`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/dudas/.npm/_logs/2018-04-17T16_32_36_248Z-debug.log

Why is Travis not able to build the project?

I think the readme is too long we should adopt it for our project

Please note it somewhere that one has to install iojs


SpHandler Fix for detecting data issues feature

This fixes the issue of false positive error of "Fetching [some path] had no results, this might be a data issue", e.g. with yg of no results.

@yanpom to test this change, please try posting to _sp something like this:
PATHS
/no-such-infoton?yg=<somePredicate

SPARQL
SELECT * WHERE { ?s ?p ?o }

(should be 500 before the fix and 200 afterwards).

Tested


Feature request: type-check on the timing of value assigning.

I don't know if this feature request is possible or not but I want to check the type strictly.
For example, the below image defines the ConfigSchema class and tries to assign default value to the default_config variable. But default_config's type will be merged unexpectedly.
Can it report as an error?

Type checking is not currently supported. I have always wanted to do type checking, but when I think about the huge amount of work, I can't take the first step.

Thank you for your quick response.
The reason is very understandable for me. If the time has come, I will help you to debug etc.

Done.


Ability to stop/kill & resume the job

The tool should have ability to resume the job from the point of previous exit. Customers may want to kill a running job (to change throttling speed, etc.), or sometimes a long running job may get killed for various reasons (vm restart, etc.). The tool should write partitions that have been processed and use it as an input during a future run to exclude migrated partitions.

This is a very useful feature for large clusters. May I ask if it is on your roadmap?

@zhaogxd This feature has been implemented & now available as part of release 4.3.0


Generate yaml of existing topic.

Hi,
it will be nice to have options that Kafka Topology Builder can generate yaml of existing topic/acl in Kafka Cluster. It will be useful with migration from imperative create topic to declarative one like this project. In case you forget about same topic it could remove data.

Thanks a lot for your feedback, this issue is related to #59 and would be a great addition. Thanks a lot. BTW: if you get time, contributions are very welcome! :-P

I think generating a YAML from an existing cluster might not be straightforward, especially if the topics/ACLs of cluster were not previously provisioned with the KTB due to:

KTB enforcing a specific naming scheme with a fixed component separator (.) and the topics in the cluster might not conform to it
it might be difficult to recover the any meaningful project structure for producers/consumers/streaming apps from the ACLs present in the cluster.

For extracting and recovering cluster state a data-format which closer models the data which is actually stored in the cluster might be more useful. I did some prelimary work on extracting/applying on that in this branch https://github.com/christophschubert/kafka-topology-builder/tree/introducing-flatDescription.
I also did some initial restructuring of the KTB to make it slightly more modular: topologies are compiled to so-called FlatDescription objects, which can then be applied to the cluster. Hopefully, this will make it easier to also change properties such as the topic naming convention later and could as well serve as a basis for checking naming conventions.


fix: nimbus-beacon rest.allow-origin bad default

If rest.enable is true and rest.allow-origin is not set, allow-origin defaults to null which can't be coerced to a string when building CLI flags for Nimbus. This MR fixes this behavior by adding a null check before building the flag.

Found and added commit for second bug, where data-dir flag was duplicated if it was non-default.


Multiple content

Hi !
I have an foreach to create all of my post and in the div content of my post i add the id (contentmsg) for the embed.js ! and just my first post have embed.js functionnal all other have not embeded have you an idea ?

This example may help you. Instead of using forEach on each id , use EmbedJS.applyEmbedJS() on class.

closing due to inactivity.


Linter: Fix >160 line length test

Pylint was not enforcing line length for any files (all conventions were disabled). I enabled the line length convention (C0301), and fixed all the line length issues, except in the fingerprints and a couple other cases where I ignored them.

LGTM


Specify Entity Resolution Result

In the examples you can send an intent via:
send(rb.intent('CaptureWorldCountry', { country: 'germany' });

Is there a way to specify / mock the entity resolution result from Alexa, so that you can write tests that cover the cases where we have an exact match (ER_SUCCESS_MATCH) or a no match (ER_SUCCESS_NO_MATCH )?
Some thing like:
ER_SUCCESS_MATCH:
send(rb.intent('CaptureWorldCountry', { country: { value: 'germany', id: 'germany' } } );

ER_SUCCESS_NO_MATCH:
send(rb.intent('CaptureWorldCountry', { country: { value: 'germani', id: '' } } );

This would be really helpful in testing the different behaviour depending on an exact match or not.
Thanks!

As of for now I don't think it's possible to add this information to the RequestBuilder due to the lack of implementation. But you could try to build your intent request as you would normally and then manually add the resolutions attribute.
So for example, create your intent request like
let intentRequest = rb.intent('CaptureWorldCountry', { country: { value: 'germany', id: 'germany' } } );

This will store the intent request in your variable as a json object, which you can then manipulate the way you'd like to, so for this example it would be
intentRequest.request.intent.slots.resolutions = { //your entity resolution object here }

Feel free to test around with this.


Fix SVG close tag

Follow #23748
Thanks to @delvh

In the screenshot, the avatar image is misaligned (no space between it and the user name) ..... (IIRC there are many misalignment regressions after an old avatar/image refactoring)
So I'd like to fix this misalignment together.

Codecov Report

Merging #23751 (ec11ff4) into main (f521e88) will decrease coverage by 0.03%.
The diff coverage is 37.70%.

@@            Coverage Diff             @@
##             main   #23751      +/-   ##
==========================================
- Coverage   47.14%   47.11%   -0.03%
==========================================
  Files        1149     1155       +6
  Lines      151446   152496    +1050
==========================================
+ Hits        71397    71855     +458
- Misses      71611    72165     +554
- Partials     8438     8476      +38

Impacted Files
Coverage Δ

cmd/dump.go
0.66% <0.00%> (-0.01%)
:arrow_down:

cmd/web.go
0.00% <0.00%> (ø)

models/actions/run.go
1.64% <0.00%> (-0.08%)
:arrow_down:

models/actions/runner.go
1.44% <ø> (ø)

models/packages/package.go
45.45% <0.00%> (-1.13%)
:arrow_down:

models/user/search.go
77.50% <0.00%> (-6.29%)
:arrow_down:

modules/actions/workflows.go
0.00% <0.00%> (ø)

modules/context/context.go
64.54% <0.00%> (-3.53%)
:arrow_down:

modules/doctor/storage.go
30.65% <0.00%> (-1.29%)
:arrow_down:

modules/setting/git.go
45.45% <ø> (ø)

... and 38 more

... and 47 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

I was unable to create a backport for 1.19, please send one manually. :tea:


CSS Tweak for sizing

Added styling to fix alignment and icon size

@ChristianMurphy Thoughts?

Link to screenshot https://www.dropbox.com/s/p5vmoulbnvpcftx/Screenshot 2018-11-13 15.21.52.png?dl=0


Create windowed_median.cpp

Description of Change

An algorithm to efficiently calculate the median of a sliding window at the back of a stream of values
Checklist

[x] Added description of change
[x] Added file name matches File name guidelines
[x] Added tests and example, test must pass
[x] Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
[x] PR title follows semantic commit guidelines
[x] Search previous suggestions before making a new one, as yours may be a duplicate.
[x] I acknowledge that all my contributions will be made under the project's license.

Notes:

Hi,
Please advise if the current location I chose for this contribution - probability - is appropriate. If not, kindly suggest an alternative within the existing list of directories, or whether I should create a new one (I thought statistics could be a better fit)


RenderBox was not laid out: _RenderListTile#16bbb NEEDS-PAINT NEEDS-COMPOSITING-BITS-UPDATE 'package:flutter/src/rendering/box.dart': Failed assertion: line 1927 pos 12: 'hasSize'

Steps to Reproduce

Execute flutter run on the code sample
...
...

Expected results:
Actual results:

Code sample

Logs

Hi @Arun1297 ,
When opening an issue, please try to provide all or some of the information indicated in the template.

Issue Template
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
- https://flutter.dev/
- https://api.flutter.dev/
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent

If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports

Steps to Reproduce

Please tell us exactly how to reproduce the problem you are running into.

Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.

If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.

1. ...
2. ...
3. ...

Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?

Target Platform:
Target OS version/browser:
Devices:

Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.

Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.

Finally, paste the output of running `flutter doctor -v` here.

Closing this issue, since no information has been provided.
Thank you.


The PR creation popover is covered by github default buttons

First of all, thanks for the great extension.
Looks like Github increased the z-index for these buttons recently.

This issue has been fixed in #1190 (originally reported in #1189). To make sure you are using the latest version of the extension, go to chrome://extensions and force an update. In order to do it, toggle the Developer mode on the right and click Update in the menu shown below the search bar).

Thanks for reporting the bug! Thankfully it’s been already fixed and you should receive the update soon 🙂


Clicking on new field causes blur to occur

On Android, when I am currently on a TextInput and touch on a new field, the keyboard goes away, but the field I just touched is no longer selected.
Ideal behavior would be to focus on the new TextInput, keep the keyboard open (or switch keyboard if type is different), and scroll to new position.

Great! Closing out as the issue is a bigger, React-native issue. Thanks!

@kevinansley I tried to use forked react-native with the fix @coderdave suggested, but it didn't work. And it shouldn't have worked, because keyboardDismissMode='on-drag' (behavior of which that fix addresses) isn't used in this repo. And even when I use ScrollView with two TextInputs, the issue persists.
So, it's definitely something within react-native itself.

And apparently it's the intended behavior.
@kevinansley if you still have this issue, it's actually related to facebook/react-native#17434. And there's the fix right there in this comment. I added keyboardShouldPersistTaps="handled" prop to KeyboardAwareScrollView and voila.

Thanks angly-cat! I ended up finding a solution by using NativeBase Container, Content, and Input controls


Support subscription for Nest.js Federation driver

Is your feature request related to a problem? Please describe.

I am using Graphql Mesh + Graphql-Yoga with nest.js
Wanted to use subscriptions, for real time events. But faced this error Error: No support for subscriptions when using Apollo Federation.
I found in the guild documentation that If I want to use Subscriptions with a Federated Gateway I should use Schema Stitching. As mesh uses schema stitching it should work.
https://the-guild.dev/graphql/yoga-server/docs/features/apollo-federation
The problem is that subgraphs with apollo federation do not support subscriptions.
And if I launch YogaDriver for nestjs, it doesnt support graphql federation syntax with @keys, @external, etc
Describe the solution you'd like
As recently apollo federation added support for subscriptions, tried to enable subscriptions but there is a check in the federation driver, but it has no effect. Maybe I did smt wrong, but should be as apollo-subgraph should support subscriptions now
Another solution would be to support graphql federation syntax  for YogaDriver, but looks like a hacky solution

created a PR https://github.com/dotansimha/graphql-yoga/pull/2966
As @apollo/subgraph version is already 2.4.0, worked for me without updating dependencies
btw, subscriptions from @graphql-mesh are also working


Ability to watch tables in real-time

Is there any interest in allowing users to subscribe to insert, update and delete events on a given table without triggers or notify/listen?
I'm the creator of Lapidus and have been using it in production since the summer with excellent performance and reliability.
I'll be happy to do a pull request adding this functionality, however, it makes use of logical decoding and streaming replication which require additional configuration:

Lapidus requires pg_recvlogical to be present on the system, it uses pg_config to find the correct location of the binary if it cannot be found on the path
Logical replication must be configured
A logical decoding plugin must be installed (decoding_json)
When Massive connects and does it's introspection, it's advisable that it checks for logical replication slots that it created that are inactive and delete them or throw an error or warning when they reach a certain size, it's possible to run out of disk space
A user with replication permission and the relevant bits in pg_hba.conf

I think this amount of configuration/complexity is a bit of a turn off for some massive users, and other than making use of introspection to allow filtering of events by primary keys, Lapidus has no dependencies on having a connection to the database (pg_recv_logical does that part).
I think that it'd be easy enough for introspection to make sure that the server is configured properly and that the provided credentials have replication permissions and provide exact instructions on what files to edit, lines to add or changes to make in order for watch to be enabled. It could be a skeleton function that throws a helpful error if you try to use it when it's not configured.

Well, I'm not Rob, but looking at it I have to ask: what about this technology is so generally compelling that makes it suitable for bundling into a data access toolkit with a distinctly minimalist, "here's your database and what's in it, everything else is on you, go nuts", mindset? Granted, triggers and pub/sub aren't always sufficient for peoples' needs (or you wouldn't have written this), but: we don't do anything with triggers or pub/sub in the first place. Massive reads and writes data; monitoring is a separate concern.

I think it's a good fit because this is the minimalist way of streaming changes that requires no changes to your database, only its configuration. (No triggers, listen/notify, schema changes are needed).
I could see it going both ways.
Since Lapidus and Massive can play nice together maybe there's no point, however, I think that the same people who would appreciate one would appreciate the simplicity of the other.
I would rather not implement a subset of Massive's features in Lapidus if possible (mostly all of the introspection), I'm trying to avoid keeping a "control connection" open to PostgreSQL if I don't need it.

I'm of the mind that pub/sub is a different concern. While it may be handy, it seems like an application concern to me (and I suspect Rob would agree, but you never know...). On the other hand, a complimentary lib, or a pluggable thingy, might be handy...

@xivSolutions Just to clarify, this is not pub sub, this is full streaming of changes at the database level. I just imagined that each table would be an event emitter where you could listen for update, insert, or delete events.

Ahhh...
I thought we had those events in there...
This may have some traction. If they are not there anymore possibly we should add those back in.

I was thinking of issuing a NOTIFY when a document is saved - I'll have a peak at this in v3.

I thought about this some more and I'm keeping Massive's focus on data mapping; an event system necessitating extra setup is more than I want to get into.


URL/DOI exclusive export option

[x] I have verified in the Zotero addons screen that I have the latest release of BBT (https://github.com/retorquere/zotero-better-bibtex/releases/latest) and Zotero installed
[x] I am posting a single question, bug or feature request
[x] I have included a descriptive subject of the problem
[x] I am available for follow-up questions and testing

Your question/suggestion:
I would really like a URL export option that is "export URL if there is no DOI". Right now I store both the URL and DOI for an item in zotero. If it has a DOI I'd like only it to show in the bib export but if it doesn't have a DOI and has a URL I'd like that to show, but there is no reason to show both the URL and DOI in the rendered bibliography.
If you point me to the relevant code I could potentially submit a PR.

The hardest about this would be a coherent UI concept. The current UI part lives here, the part that does the actual export based on the preference settings is here.

Wouldn't setting the DOI/URL preference to DOI already do this?

I have "add urls to bibtex export" as "in a note field" (because the URLs will not show up if I have it as "no"). And I have "when a reference has both a doi and url, export" as "doi", but they both show up in the export. I'm unable to get it to export only the url or doi with preference to doi. Maybe I'm not setting things correctly?

Hmm no, it's just a scenario I hadn't considered before. Can you right-click on an item that has this and submit an error report?

Yes, I'll try to submit later today.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>83 ("fixes #1156")
Install in Zotero by downloading test build <IP_ADDRESS>83, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

I really need to know whether this addresses your concern before I can merge this into a release.

I haven't had time to try it out, day job keeps me busy. Will get to it as soon as I can.

My day job also keeps me busy, and I'm doing this in the little spare time I have left between job, studies, and family.

Aren't we all...

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>19 ("Merge branch 'master' into 1156")
Install in Zotero by downloading test build <IP_ADDRESS>19, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

3683 expired; please try3819 instead.

Assuming fixed

3819 is working as I'd hope. thanks.


Refactor compliance connection to sensor

Description
In the current state, compliance calls the Communicate function every time it wants to send something. This will orphan the gRPC stub created in manageReceivedStream, thus making sensor unable to send any messages to compliance.
This PR aims to solve this problem by reusing the same gRPC stub for receiving and sending messages from/to sensor.
See:

ROX-13383

Checklist

[ ] Investigated and inspected CI test results
~[ ] Unit test and regression tests added~
~[ ] Evaluated and added CHANGELOG entry if required~
~[ ] Determined and documented upgrade steps~
~[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)~

If any of these don't apply, please comment below.
Testing Performed

Manual testing in a maple team mob session

Build ACS with the following variables:

ROX_POSTGRES_DATASTORE         = true
ROX_RHCOS_FAKE_NODE_INVENTORY  = true
ROX_NODE_RESCAN_INTERVAL       = 10s
ROX_RHCOS_NODE_SCANNING        = true

Deploy with ACS with deploy/k8s/deploy-local.sh
Set the re-scan interval with: kubectl -n stackrox set env ds/collector ROX_NODE_RESCAN_INTERVAL=$ROX_NODE_RESCAN_INTERVAL
We should see logs in sensor and compliance of the scans being done.
In the UI go to Compliance and click on Scan Environment
We should see logs in sensor and compliance of the scrape being started.
Kill sensor and check everything should recover.
Kill compliance and check everything should recover.

Yes, I tested the changes as @lvalerom described.
Deployed to Colima, tested killing the Sensor as well as Compliance and observed all connections recovering as well as the UI scan functionality still working.


fix edit module command bug

Codecov Report

Merging #201 into master will increase coverage by 0.41%.
The diff coverage is 72.72%.

@@             Coverage Diff              @@
##             master     #201      +/-   ##
============================================
+ Coverage     58.42%   58.83%   +0.41%
  Complexity      641      641
============================================
  Files           130      130
  Lines          2446     2444       -2
  Branches        282      282
============================================
+ Hits           1429     1438       +9
+ Misses          863      850      -13
- Partials        154      156       +2

Impacted Files
Coverage Δ
Complexity Δ

src/main/java/seedu/address/model/Model.java
100.00% <ø> (ø)
1.00 <0.00> (ø)

...c/main/java/seedu/address/model/module/Module.java
75.00% <ø> (-1.67%)
13.00 <0.00> (-1.00)

...main/java/seedu/address/model/module/ModuleId.java
80.00% <ø> (-3.34%)
6.00 <0.00> (-1.00)

.../address/logic/parser/EditModuleCommandParser.java
64.28% <50.00%> (+17.61%)
2.00 <0.00> (ø)

...a/seedu/address/model/module/UniqueModuleList.java
63.26% <66.66%> (-0.74%)
17.00 <2.00> (ø)

...eedu/address/logic/commands/EditModuleCommand.java
81.39% <77.77%> (+22.42%)
11.00 <2.00> (+2.00)

...rc/main/java/seedu/address/model/ModelManager.java
55.81% <100.00%> (ø)
31.00 <1.00> (ø)

src/main/java/seedu/address/model/Trackr.java
76.08% <100.00%> (ø)
16.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909d502...e1f721b. Read the comment docs.

LGTM