Blade parenthesis parse issue

Laravel Version: 5.4.12
PHP Version: 7.0.15
Database Driver & Version:

Description:
in my template i use
@section('title', 'Hello :)')

which results in error:
Parse error: syntax error, unexpected '?'

imo that's a no-fix, I suggest that you use the other format:
@section('title')
hello :)
@stop

Should be fixed or at least documented for the time being

@themsaid

imo that's a no-fix

No fix? The docs for 5.4 show that it's possible to do that, and it has been in previous versions, seems to me it's a bug. https://laravel.com/docs/5.4/blade

I'm not saying it's not a bug, I just don't think there's an easy way to fix it.

Oh my bad, I interpreted it as "we have no intentions of fixing this."

@themsaid - sadly this is now affecting Laracasts: https://laracasts.com/discuss/channels/site-improvements/blade-braces-in-a-thread-title-breaks-the-page

I had a crack at trying to solve this - but my RegEx skills are not the greatest.
The problem is this line here from Illuminate\View\Compiliers\BladeCompiler:
protected function compileStatements($value)
{
    return preg_replace_callback(
        '/\B@(@?\w+(?:::\w+)?)([ \t]*)(\( ( (?>[^()]+) | (?3) )* \))?/x', function ($match) {
            return $this->compileStatement($match);
        }, $value
    );
}

We need to be able to modify that RegEx to ignore parenthesis inside quotes (both " and "`").
I posted a question on StackOverflow about it here: http://stackoverflow.com/q/43970168/1317935 - I got one answer, but even that doesnt fully solve it, and it creates other situations where the whole thing might fail.
For example - what is the correct response for this:
@section('title', 'Hello") there')
That's going to be very difficult via RegEx.. I think @themsaid is right - that it'll probably have to be a limitation of Blade for this edge case.

Closing as a no-fix, blade has some limitations and that's one of them.


http://maputnik.com/editor/ site is not working

Hello there, I'm not sure if this is a domain issue or something else is that's preventing from Maputnik site to work.
thank you for looking into this.

Looks like the previous registry expiry date of the domain has been yesterday:
Registry Expiry Date: 2017-09-20T11:30:39Z
Currently maputnik.com shows:

@lukasmartinelli Did you extend the domain registry for maputnik.com?

@lukasmartinelli I suggest we just remove the CNAME and use http://maputnik.github.io instead thoughts?

Now is one of them sites:

Yup https://maputnik.github.io/ seems to work now. Will try to reactivate old domain in the meantime we can replace the links.
I like https://maputnik.github.io/ better. I just don't want to make maputnik.com a broken link though.

I like https://maputnik.github.io/ better. I just don't want to make maputnik.com a broken link though.

I think if you reactivate https://maputnik.com it'll start redirecting https://maputnik.github.io -> https://maputnik.com so I think we need to pick either one or the other. I think maputnik.com is everywhere so ideally we'd stick with that. @lukasmartinelli any luck with the domain?

Hi @lukasmartinelli sorry it's me again. So I'd like to get maputnik working again, it's a little broken at the moment. I'm guessing the services are setup to have https://maputnik.com as the domain and are hence failing is an 403 unauthorized and since https://maputnik.com is various places over the internet it'd be good to get this fixed.
Is there anything I can do to help? If payment is an issue I'm happy to pay for the next year.
If you're too busy, feel free to ignore this. I'll start to change over the urls if I don't hear anything on Thursday/Friday on the website and app to https://maputnik.github.io/editor.

If you're too busy, feel free to ignore this. I'll start to change over the urls if I don't hear anything on Thursday/Friday on the website and app to https://maputnik.github.io/editor.
👍 3

I want to move everything over to https://maputnik.github.io/editor.
I also don't like I bought the .com domain initially instead of .org.
If I get it back I will redirect to https://maputnik.github.io

With #175 merged I think its changed everywhere except the https://github.com/maputnik/maputnik.github.io header

@lukasmartinelli you're the only one with perms to change that. On that note any chance I can get admin perms to the repos?

Finally got all 2FA recovered. Purchased domain back and will set up a redirect once done to https://maputnik.github.io.

@orangemug done, changed link!

Thanks @lukasmartinelli, I think we can close this issue now. Yay!

http://maputnik.com/ now redirects! @orangemug @keum @pathmapper

http://maputnik.com redirects, but Google remembers the HTTPS (https://maputnik.com) address. It’s high in the results for “maputnik”. When you click it, you get (in Chrome):

What can we do about it?

Currently the redirect is not working. @lukasmartinelli @orangemug
Whoever is paying for the domain, is this still OK?

whois maputnik.com
Domain Name: MAPUTNIK.COM
Registry Domain ID:<PHONE_NUMBER>_DOMAIN_COM-VRSN
Registrar WHOIS Server: whois.namecheap.com
Registrar URL: http://www.namecheap.com
Updated Date: 2018-09-21T07:20:29Z
Creation Date: 2016-09-20T11:30:39Z
Registry Expiry Date: 2019-09-20T11:30:39Z
Registrar: NameCheap Inc.
Registrar IANA ID: 1068
Registrar Abuse Contact Email<EMAIL_ADDRESS>Registrar Abuse Contact Phone: +1.6613102107
Domain Status: clientTransferProhibited https://icann.org/epp#clientTransferProhibited
Name Server: DNS101.REGISTRAR-SERVERS.COM
Name Server: DNS102.REGISTRAR-SERVERS.COM
DNSSEC: unsigned
URL of the ICANN Whois Inaccuracy Complaint Form: https://www.icann.org/wicf/
>>> Last update of whois database: 2018-09-22T03:52:47Z <<<

@lukasmartinelli owns the maputnik.com domain

On it! Trying to reactivate and bough it back. Checking in a bit again if nameservers updated 🙈 .

The redirect is working again, thanks @lukasmartinelli !

It's not working again, I guess it's the same issue as every year.
Would you mind having a look @lukasmartinelli?


feat(telemetry): configurable collection time

Makes metrics collection time configurable, + reduce collection time in e2e tests  with metrics collection enabled

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#9741  👈
#9710
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Maddiaa0 and the rest of your teammates on  Graphite


Strong tag not working when in an ordered list and the list number is multiple digits

Hi Mark Dig,
I seem to be having an issue when converting some markdown to html. The markdown is as follows:
11.	 __test__ hello
It seems to convert to this:

        est__ hello

I'm not entirely sure how this is happening, or if there are any extensions I can use to bypass this issue. This issue appears on the latest version 0.13.0. Any ideas?
Thanks,
David

Can't reproduce this issue on babelmark
It seems that you have this issue in a context not described here...

I've done some further investigation into this issue and have found the following.
When executing this code:
var html = Markdown.ToHtml("10.\t*test* – test\n\n11.\t__test__ test\n\n", new MarkdownPipelineBuilder().Build());
I get back

            t* – test

            st__ test

However if I were to take out the \t I get this:
var html = Markdown.ToHtml("10. test – test\n\n11. test test\n\n", new MarkdownPipelineBuilder().Build());

test – test

test test

And again this only seems happens if the list numbers are double digits. I also can't recreate this on babelmark.

Looks like a bug in markdig on babelmark... will have to check this...

This should be fixed by commit bb30dc2 and available in 0.13.1


bootstrap template having something like this

"fa-stack fa-4x"
im using a bootstrap template,i dont know what the above means, but it shows an icon or glyficon, of which i want to change, and put my own
what can i do?
thats in the "span class.."
im new here dont know it goes,

@Siplicity14 Perhaps, you'll find value in reading the Examples page for Font Awesome:
https://fortawesome.github.io/Font-Awesome/examples/
This gem is just a wrapper around the core icon library for Rails supportl

Btw, please take any further questions like this to a site like StackOverflow. GitHub Issues are best reserved for discussing feature requests and bug reports.


MSL: Fix calculation of atomic image buffer address.

Fix reversed coordinates: y should be used to calculate the row
address. Align row address to the row stride.
Honestly, I don't know how this worked at all for Epic. It definitely
didn't work in the CTS prior to this.

r32ui_linear_texture_alignment should probably be emitted as a function constant instead, and the option should be the ID. It seems useful for applications that want to ship converted MSL to supply the alignment after converting MSL.

Why not both? Function constants don't work on MSL 1.1 anyway.

r32ui_linear_texture_alignment should probably be emitted as a function constant instead, and the option should be the ID. It seems useful for applications that want to ship converted MSL to supply the alignment after converting MSL.

Why not both? Function constants don't work on MSL 1.1 anyway.

Yes, both is fine I guess. I guess when you're compiling to MSL in runtime you don't really need function constants either.

Just nits, quite curious indeed. I guess they only used 1D images perhaps. Ping @LukasBanana.

Sorry for the late reply. I can confirm the swapped x and y coordinates was a bug. We have it fixed in our P4V repository but not with the addition of variable alignment.


WIP: Firefox

This is a WIP from @nickytonline's forked branch. I ran this on stream to identify the error message my self and also learn how to debug this locally in firefox.
Opening this PR as spike.

Current Error: chrome.storage
https://github.com/open-sauced/ai/issues/237#issuecomment-1668802161
I think I might have narrowed to the chrome.storage in the settings.tsx. There is a storage.local that might be needed instead, for firefox. https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/local
https://github.com/open-sauced/ai/blob/beta/src/popup/pages/settings.tsx#L22
Suggested solution
But TBH, we probably should use a state management library in React instead

@nickytonline thanks for picking this up.


refactor: Moved AuditLogs to DataTable

Question
Answer

Bug fix?
no

New feature?
no

Refactoring?
yes

Build related change?
no

CI related change?
no

Deprecations?
no

Tickets
Closes #55

License
MIT

This PR makes the AuditLog much more useable by moving the previous display in the form of some kind of list into a real DataTable with some fancy colors for the actions and links to the currently existing entities.

Codecov Report
Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (66ca312) 51.30% compared to head (220ed1f) 51.26%.

Files
Patch %
Lines

...oller/Admin/System/AuditLog/AuditLogController.php
0.00%
4 Missing :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #56      +/-   ##
============================================
- Coverage     51.30%   51.26%   -0.04%
  Complexity      770      770
============================================
  Files           183      183
  Lines          2692     2694       +2
============================================
  Hits           1381     1381
- Misses         1311     1313       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


HV-1767 Reduce the overhead of ConstraintHelper initialization in the predefined scope case

https://hibernate.atlassian.net/browse/HV-1767

@yrodiere I addressed your comments.


ABI Generation

Hand-written ABI files are unnecessary and expose developers to risk if they aren't kept up-to-date.
Since we already have #[eosio_action] and #[eosio_table] attributes, it should be fairly straightforward to implement this feature by detecting these attributes and generating a JSON file.

That would be great! Please let me know if you have any questions. Thanks.


Accessing workflow final output

I plan to use hyperopt hyper-parameter optimization toolkit in combination with sciluigi workflows.
Instead of doing exhaustive grid search, hyperopt will (smartly) propose a set of parameters params that I use like this:
task = MyWorkflow(**params)
luigi.build([task], local_scheduler=True)

In my current setup, the final task of the workflow prints the value of the objective into a file.
Therefore, I have to read this file again to let hyperopt know what is the value of the objective for the current set of parameters. It means that I have to know exactly where the workflow will save this file.
I expected task.output() to return the output of the final task but instead it returns a dict with audit and log values. Is there an easy way to access the output of the final task of the workflow?
Even better, is there a way to make the workflow returns the value of the objective directly?
objective = f(task)

Hi @hbredin! Interesting use case, it sounds very similar to what we are doing with machine learning in drug discovery / cheminformatics!
It sounds like you are basically looking for using the workflow task as a "subworkflow", to be a part of a larger workflow. Is that correct?
We have had plans to implement sub-workflow support in SciLuigi. it should not be a big development, but in the end we managed without it, and so other things were prioritized. But now that there is more need for it, we should probably look into implementing this.

Indeed, it would be great to have sciluigi.Workflow implement the standard luigi.Task interface:

.requires(self)
.run(self)
.output(self)

But, really, what I am looking for right now is a standard .output() method that would return the same thing as luigi.Tasks do --  so that I can use workflow.output().path.

FYI, I ended up adding a dummy Hyperopt task at the end of my workflow that write the path of the final task to a temporary file whose path (temp) is provided as parameter:
class Hyperopt(sciluigi.Task):

    temp = luigi.Parameter()
    in_final = None

    def out_put(self):
        return sciluigi.TargetInfo(self, self.temp)

    def run(self):
        with self.out_put().open('w') as fp:
            fp.write(self.in_final().path)

class MyWorkflow(sciluigi.WorkflowTask):

    hyperopt = luigi.Parameter()

    def workflow(self):
        ...
        final_task = self.new_task(...)
        # return final_task

        hyperopt = self.new_task('hyperopt', Hyperopt, temp=self.hyperopt)
        hyperopt.in_final = final_task.out_put
        return hyperopt

Then, to get the path of the output of the final task, here is what I have to do:
# create path to temporary file and add it to the set of parameters
directory = mkdtemp()
params['hyperopt'] = directory + '/hyperopt'

# actually run the workflow with this extended set of parameters
task = MyWorkflow(**params)
luigi.build([task], local_scheduler=True)

# obtain the path of final task output from the temporary hyperopt file
with open(args['hyperopt'], 'r') as fp:
    path = fp.read()

# do something with path...

I will now try to write a decorator for any sciluigi.WorkflowTask that does this change automatically.


Automation Runbook Type Enumeration missing options for Python and Python3

Is your feature request related to a problem? Please describe.
I would like to create a Python3 Azure Automation Runbook through terraform.  Since I believe this is the SDK that backs the API I would like to request an enhancement to azure-mgmt-automation that is required before Terraform can accept Python or Python3 as Runbook types.
Describe the solution you'd like
I would like the class RunbookTypeEnum(with_metaclass(_CaseInsensitiveEnumMeta, str, Enum)) to include Python and Python 3 in the enumeration, then have the swagger enum in the Rest API updated to reflect the new types.  This would allow the Terraform provider team to add the options for these types to their resource in the azurerm provider.
Describe alternatives you've considered
If I cannot terraform something it does not exist.  Until this option can be found in the Terraform provider I am stuck using PowerShell in Azure Automation.
Additional context
This feature is required to fix this issue.

Hi @wjg659  thanks for the feedback. We'll take a look at this and get back to you asap.

Hi, @wjg659 Thanks for your feedback.I have understood your issue, but SDK is generated by swagger.If swaager does not have this parameter, the SDK will not have this parameter。
So you can submit your new issue to https://github.com/Azure/azure-rest-api-specs/issues

Thank you.  I have opened this issue in the azure rest API specs repo to have the swagger modified.


The "cty" header is always added breaking compatibility with certain services

Which version of Microsoft.IdentityModel are you using?
6.18
Where is the issue?

[x] M.IM.JsonWebTokens

Is this a new or an existing app?
The app is in production and I have upgraded to a new version of Microsoft.IdentityModel.
Expected behavior
The cty header addition for JsonWebTokenHandler.CreateToken is controlled by some flag.
Actual behavior
The cty header is added unconditionally.
Possible solution
Since #1588, there seems to be no way to control the addition of the cty header, and there are services (for example Apple ID token service) that require the produced token to contain only specified headers. The header set works just fine in the versions up to and including 6.17. After #1588 was completed, there appears to be no way to control the cty header presence.

@onyxmaster as brockallen pointed out, in a JWE with an inner JWS, the cty is required.
Are you seeing the cty in other than JWE's?
Do you need a back-compat switch?

Thanks for answering.
I don't argue that the cty field is required by the spec. Unfortunately, the Apple ID secret token expectations are quite specific regarding the set of the expected fields (see Generate and Validate tokens -> Creating the Client Secret.
I don't think that Apple is going to change this to match the RFC, breaking all existing code. To generate this token we're using JsonWebTokenHandler.CreateToken, which, since 6.18 creates a JWS with the cty field unconditionally :(
The back-compat switch would be great, or we would be stuck on the 6.17 forever.

I have the same issue with Adobe API after upgrading to 6.18.0. When trying to exchange token (see Exchanging JWT to retrieve an access token) it fails because a new cty header is presented. It would be nice to have ability to control that header.

Yes, some kind of a flag to toggle the field addition would be great, regardless of its default value!
I don’t think you should be sorry for anything, after all it’s some other service not following the spec.

The cty header parameter is added in some cases even when one is creating a JWS. Here is an example that reproduces this:
using System.IdentityModel.Tokens.Jwt;
using System.Security.Cryptography;
using Microsoft.IdentityModel.Tokens;

using var ecdsa = ECDsa.Create();
var key = new ECDsaSecurityKey(ecdsa);
var signingCredentials = new SigningCredentials(key, "ES256");
var header = new JwtHeader(signingCredentials);
var payload = new JwtPayload();
var token = new JwtSecurityToken(header, payload);

Console.WriteLine(new JwtSecurityTokenHandler().WriteToken(token));

Example output:
eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCIsImN0eSI6IkpXVCJ9.e30.AcDSZ_pY6LJRXZWMGdNhWJY1d3uuyCzL97jYcHvflLwRLUGQOc63j1ltSi-IFE8pH5b7iVfT0_wq2YWvs1mwUEH_Acb1kHTcTRiDi_EOfNXP4kaaZjvYGSdPu5yFuO14tKSFULgchMNmJrfUZgQDx4eTLcsok7wCNv_V1FFwkUtwKu1m

Decoded:
{
  "header": {
    "alg": "ES256",
    "typ": "JWT",
    "cty": "JWT"
  },
  "payload": {},
  "signature": "AF2C-PDYpLhqxuRHNULNs6aPrfTT2g_LVi9oofDI1-pBwkvlVrdS-9tnZB4JlFmbKR_9MUJByybK-Um1R43nNgdbAU0Qsv0xV2YQfXGJP84efocWBVA6JCpF_2Wde6WB719XSlakF-3GgI3trCmyOvm23w6WwbLW-Fzkcrt60LaOj7iy"
}

In this case, there is no nesting (the payload is not a JWT), so according to the RFC, adding a cty header parameter is not recommended.
If the cty header parameter is added to the header when the payload is not a nested JWT, some JWT validators seem to treat this as an invalid token; for example, we had trouble validating such tokens using jose4j on Java.

@RojaEnnam make sure to address ^^
@onyxmaster we should apologize, after all these years we know changing a wire format needs a back-compat switch.

Released in 6.20.0.


[TECHDEBT] [P2P] P2P integration with utility for addressBook lookups - (Issue #270)

Description
This PR builds on top of #374 (the base branch is not main in order to highlight the delta of the changes) in order to tend to the TECHDEBT TODOs listed in #270
Issue
Fixes #270
Type of change
Please mark the relevant option(s):

[x] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Major breaking change
[ ] Documentation
[ ] Other

List of changes

Consensus

LeaderElectionModule's electNextLeaderDeterministicRoundRobin now uses Persistence to access the list of validators instead of the static ValidatorMap.
Updated tests (mock configs) accounting for the updated logic

P2P

ValidatorMapToAddrBook renamed to ActorToAddrBook
ValidatorToNetworkPeer renamed to ActorToNetworkPeer

Testing

[x] make develop_test
[x] LocalNet w/ all of the steps outlined in the README

Required Checklist

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have tested my changes using the available tooling
[x] I have updated the corresponding CHANGELOG

If Applicable Checklist

[ ] I have updated the corresponding README(s); local and/or global
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added, or updated, mermaid.js diagrams in the corresponding README(s)
[ ] I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

I think this is ready for another lookie.

@deblasis Can you create a ticket for https://github.com/pokt-network/pocket/pull/378#discussion_r1047894172 for you to handle?

@Olshansk

@deblasis Can you create a ticket for #378 (comment) for you to handle?

https://github.com/pokt-network/pocket/pull/378#discussion_r1049055338

@deblasis Can you create a ticket for #378 (comment) for you to handle?

This is now tracked in #406


Framework-agnostic architecture for examples

Examples are the most important part of the project (even more so than the libraries themselves). We will have hundreds of examples as the project evolves. As we become framework-agnostic, we must reuse as much of this work as possible.
For now, the examples live inside the ariakit package. Each component has an __examples__ folder, and inside that, there are other folders representing each example. Each example has an index.tsx file that exports the example component, and typically a style.css file that uses Tailwind. There are also test files like test.tsx (which currently is still specific to React, but I believe we can abstract that away) and other e2e test files like test-chrome.ts, which are framework-agnostic by default. Each of these examples might contain other files, which might be React-specific, but also pure JS, which could be imported into files from other frameworks.
/
- packages/
  - ariakit/
    - src/
      - component/
        - __examples__/
          - example-name/
            - index.tsx
            - style.css
            - some-other-file.ts
            - test.tsx
            - test-chrome.ts

Currently, we compile the style.css and receive a string:
https://github.com/ariakit/ariakit/blob/817ca4139862a53ddaba80a03d7bf3c7812dab81/scripts/pages/utils.js#L173
We pass this string to Emotion so that the user can modify it right from the page:
https://github.com/ariakit/ariakit/blob/817ca4139862a53ddaba80a03d7bf3c7812dab81/packages/ariakit-playground/src/playground-preview.tsx#L135-L139
https://github.com/ariakit/ariakit/blob/817ca4139862a53ddaba80a03d7bf3c7812dab81/packages/ariakit-playground/src/playground-preview.tsx#L179-L185
We can use this string to build the styles of each framework automatically. For example, I imagine that in Vue, we would put this in a <style> tag in the component file itself. Please correct me if I'm wrong.
For testing, we would have to stop using @testing-library/react for the events and adopt a more generic solution, perhaps using @testing-library/dom or writing our own fireEvent functions. Most functions on the ariakit-test package are not specific to React.  However, we still have to solve the render method, which has to be specific to each framework. Maybe we can rewrite the imports when running the tests.
As for the entry file. I think it could be replaced with something like this:
- index.react.tsx
- index.solid.tsx
- index.vue
- index.svelte

Then we rewrite the imports to the appropriate file when running the tests and building the pages.
Finally, the examples will probably have to live in an examples folder in the root directory similar to blog and docs instead of inside the ariakit package. The example names are already unique and conventionally start with the component name, so there should be no conflict.
/
- examples/
  - example-name/
    - index.react.tsx
    - index.vue
    - style.css
    - shared-file.ts
    - test.ts
    - test-chrome.ts

cc @visualjerk @sarayourfriend @ariakit/vue

Finally, the examples will probably have to live in an examples folder in the root directory similar to blog and docs instead of inside the ariakit package. The example names are already unique and conventionally start with the component name, so there should be no conflict.

This is complicated by TypeScript, unfortunately :disappointed: We won't be able to have React and Vue living happily side-by-side with TypeScript support for Vue SFCs. It may be possible if we only use Vue render function components, but as we've seen in #1849 sometimes it seems that Vue's types may trample on React's and make React JSX invalid in TypeScript's eyes.
I wonder how other project solve this issue. That PR feels like a pretty big mess of TypeScript configuration changes. I'll do a bit more research into how other projects do this. Testing library, for one, has separate repositories and does not use a monorepo. That's a huge infrastructural change, however.

We can use this string to build the styles of each framework automatically. For example, I imagine that in Vue, we would put this in a

We can use this string to build the styles of each framework automatically. For example, I imagine that in Vue, we would put this in a

Thank you for sharing those examples, they are helpful.
It does seem like you're right, we need to push the types down into the individual packages. I was able to do that in the PR, but have been running into some odd issues with TypeScript, specifically with the examples currently. I'll try fiddling around with some of the things those other repos are doing (Headless in particular does not use a root tsconfig.json, which is interesting).

I've applied some of the changes proposed in this issue:

Examples are now in the root directory: https://github.com/ariakit/ariakit/tree/main/examples

Test files don't include any framework-specific code or JSX anymore.
Here's an example:
https://github.com/ariakit/ariakit/blob/3d1c6468ca9bf73aa930395b6bd2ef59dca65225/examples/combobox/test.ts#L1-L26
They don't even need to import the example component directly. This is done in a separate setup file:
https://github.com/ariakit/ariakit/blob/3d1c6468ca9bf73aa930395b6bd2ef59dca65225/vitest.setup.ts#L67-L76
Theoretically, we could have different setup files for each framework while reusing the same test files.
However, the @ariakit/test package still depends on @testing-library/react and uses the act method from React. We can probably replace @testing-library/react with @testing-library/dom and do something about act (maybe make it noop when not using React — I'm not really aware of what conflicts we would face here).

However, the @ariakit/test package still depends on @testing-library/react and uses the act method from React. We can probably replace @testing-library/react with @testing-library/dom and do something about act (maybe make it noop when not using React — I'm not really aware of what conflicts we would face here).

Following update #2900, the @ariakit/test package has eliminated its dependency on react and @testing-library/react. It only uses React when importing from @ariakit/test/react, primarily for the render method.
Furthermore, it no longer depends on act. All functions have transitioned to being asynchronous, using real timers. The package is now safe for use in other frameworks.

Hi folks, I haven't read the full discussion here yet (I will soon!) but I wanted to give a heads up that I'm actively working on a Solid flavor of Ariakit, so I'll help figure this out so it works for all flavors including solid :)
Tracking issue: https://github.com/ariakit/ariakit/issues/4117


Added Metastore/SQL integration tests for python/scala

Modified old tests to work with Spark 3.0 by adding the right spark conf
Added a new test to test Metastore tables and SQL

This has been merged as a part of https://github.com/delta-io/delta/pull/451


Structured log conversion

This PR is a continuation of work done on the Debug 2.0 Enhancement and follows up on the original logs enhancement PR

Adds structured logs throughout controller
Adopts camelCase structured logging keys
Adds "phase skipped due to flags" log.

Logs samples attached.
direct-structured-log-sample.txt
indirect-structured-log-sample.txt
Example of unstructured -> structured conversion
# Unstructured
		log.Info(fmt.Sprintf("Phase [%v] execution FAILED with Error=[%v], Phase.Description=[%v]",
			task.Phase, errorutil.Unwrap(err).Error(), task.getPhaseDescription(task.Phase)))
# Structured
		log.Info("Phase execution failed.",
			"phase", task.Phase,
			"phaseDescription", task.getPhaseDescription(task.Phase),
			"error", errorutil.Unwrap(err).Error())

Example of "skipped phase" message
{"level":"info","ts":1616690995787,"logger":"migration|46d8t","msg":"Velero Backup progress report","migMigration":"f969f980-8d89-11eb-be8b-6b964d3a5d1d","phase":"InitialBackupCreated","backup":"openshift-migration/f969f980-8d89-11eb-be8b-6b964d3a5d1d-7bfs4","backupProgress":["Backup openshift-migration/f969f980-8d89-11eb-be8b-6b964d3a5d1d-7bfs4: 92 out of estimated total of 92 objects backed up (18s)"]}
{"level":"info","ts":1616690995787,"logger":"migration|46d8t","msg":"Skipped phase due to flag evaluation.","migMigration":"f969f980-8d89-11eb-be8b-6b964d3a5d1d","phase":"InitialBackupCreated","skippedPhase":"EnsureStagePodsFromRunning"}
{"level":"info","ts":1616690995787,"logger":"migration|46d8t","msg":"Skipped phase due to flag evaluation.","migMigration":"f969f980-8d89-11eb-be8b-6b964d3a5d1d","phase":"InitialBackupCreated","skippedPhase":"EnsureStagePodsFromTemplates"}
{"level":"info","ts":1616690995787,"logger":"migration|46d8t","msg":"Skipped phase due to flag evaluation.","migMigration":"f969f980-8d89-11eb-be8b-6b964d3a5d1d","phase":"InitialBackupCreated","skippedPhase":"EnsureStagePodsFromOrphanedPVCs"}
{"level":"info","ts":1616690995787,"logger":"migration|46d8t","msg":"Skipped phase due to flag evaluation.","migMigration":"f969f980-8d89-11eb-be8b-6b964d3a5d1d","phase":"InitialBackupCreated","skippedPhase":"StagePodsCreated"}
{"level":"info","ts":1616690995787,"logger":"migration|46d8t","msg":"Skipped phase due to flag evaluation.","migMigration":"f969f980-8d89-11eb-be8b-6b964d3a5d1d","phase":"InitialBackupCreated","skippedPhase":"RestartRestic"}
{"level":"info","ts":1616690996338,"logger":"migration|46d8t","msg":"Skipped phase due to flag evaluation.","migMigration":"f969f980-8d89-11eb-be8b-6b964d3a5d1d","phase":"InitialBackupCreated","skippedPhase":"AnnotateResources"}
{"level":"info","ts":1616690996460,"logger":"migration|xwt5s","msg":"[RUN] (Step 25/48) Waiting for Restic Pods to restart, ensuring latest PVC mounts are available for PVC backups.","migMigration":"f969f980-8d89-11eb-be8b-6b964d3a5d1d","phase":"WaitForResticReady"}
{"level":"info","ts":1616690997061,"logger":"migration|sjm48","msg":"[RUN] (Step 26/48) Quiescing (Scaling to 0 replicas): Deployments, DeploymentConfigs, StatefulSets, ReplicaSets, DaemonSets, CronJobs and Jobs.","migMigration":"f969f980-8d89-11eb-be8b-6b964d3a5d1d","phase":"QuiesceApplications"}

@shawn-hurley here's an early sample of the structured logs transition.

@shawn-hurley @pranavgaikwad this is ready to review.

Going ahead with the merge so we can have this in upcoming release. Next step for logs will be to get the migration name visible in velero logs.

Rebased.


Add basic zIndex support

Android uses View.setZ(), so it only works in 5.0+
If someone wants to take a crack at 4.1, you could probably get all the sibling views, sort them by zIndex, and then call View.bringToFront() on them in order.

Working on 4.1 support.

@tuckerconnelly updated the pull request.

Alright, supports 4.1 :)
Definitely needs a review though

Thanks for working on this @tuckerconnelly, this is a much requested feature. It's cool Android added View.setZ.
The pull request has a lot of commit, it looks like you only want the last one?
Could you please also add example use cases in the UIExplorer (https://github.com/facebook/react-native/blob/master/Examples/UIExplorer/ViewExample.js) and some screenshots / videos to your Test plan? See https://github.com/facebook/react-native/blob/master/PULL_REQUEST_TEMPLATE.md

@tuckerconnelly updated the pull request.

Moved to https://github.com/facebook/react-native/pull/7825 so I could cherrypick onto master


feat: add Playbooks/Enrich-CIRCL-hashlookup

Change(s):

add playbook Enrich-CIRCL-hashlookup using https://circl.lu/services/hashlookup/

Reason for Change(s):

Data enrichment

Version Updated:

N/A

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @juju4, I would appreciate it if you addressed the comments from @rahul0216. Thanks

Hi @juju4, please addressed the comments from @rahul0216. Thanks

Condition to review separately as need testing

Hi @rahul0216, @juju4 has responded to your request, please check it out. Thanks

Hi @rahul0216, @juju4 has responded to your request, please check and provide your feedback. Thanks

Hi @juju4, please addressed the comments from @rahul0216. Thanks

Thanks!


Add short names for Flare and Songbird main and test networks

What it solves
Adds short names for Flare and Songbird main and test networks

I have read the CLA Document and I hereby sign the CLA

recheck


QT warning on stderr during build: "Note: No relevant classes found. No output generated."

Setup -
OS: Jammy 22.04
ROS: Humble
When building with a ROS2 overlay workspace after cloning the git repo, I encounter the following error as a result of colcon build --symlink-install
--- stderr: rviz_2d_overlay_plugins
/home/arrowhead/ros2_ws/src/rviz_2d_overlay_plugins/rviz_2d_overlay_plugins/include/overlay_utils.hpp:0: Note: No relevant classes found. No output generated.
---
Finished <<< rviz_2d_overlay_plugins [9.88s]

Any suggestions?

Hi!
I will try to reproduce this later, but i have a few notes already:

I think your build was successful (as indicated by "Finished", i think colcon would list it as "Failed" or something similar otherwise). Did you try if the plugin was installed and functional despite the note on stderr?
I have not seen this output before, perhaps it's related to --symlink-install? I know that we usually build without that flag.

Also: Could you let me know which compiler you use? I'm pretty sure we only ever tested with clang 14.0.0...

I see this warning/note also occured in the CI build: https://build.ros2.org/job/Hdev__rviz_2d_overlay_plugins__ubuntu_jammy_amd64/2/consoleFull
I guess this must have also occured during our local build, but i know that there are also compiler warnings from clang which have not been resolved yet, so perhaps that just got missed in the noise...
Anyways: Since the binary release seems to work, even with this warning, i suggest you try if it works like that, and i will see if this note can be resolved...

Hey! @ottojo Thanks a ton, for the speedy fix. In any case, symlink install shouldn't affect anything C++ it's for the Python packages in the ws. I will give this a try and close it if everything works well.

I think it was just a header without any QT stuff in it that was given to the MOC. It removes the warning for me, see #16

Please do test if this fixes the issue for you, and feel free to reopen if it doesn't. Also just ping me if you would like me to release a new (binary release) version of the package with this fix...

Gotcha, thanks! So this is what I run into now while trying to scrape an overlay workspace with the bazel rules we have in drake-ros . This happens with the latest commit (a7d7bf082d09de7674c4dc6edb79ae8e853aa250).

--- captured stderr ---
CMake Error at CMakeLists.txt:19 (add_library):
  Target "empty_using_rviz_2d_overlay_plugins" links to target
  "rviz_2d_overlay_msgs::rviz_2d_overlay_msgs__rosidl_generator_c" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?

CMake Error at CMakeLists.txt:19 (add_library):
  Target "empty_using_rviz_2d_overlay_plugins" links to target
  "rviz_2d_overlay_msgs::rviz_2d_overlay_msgs__rosidl_typesupport_fastrtps_c"
  but the target was not found.  Perhaps a find_package() call is missing for
  an IMPORTED target, or an ALIAS target is missing?

CMake Error at CMakeLists.txt:19 (add_library):
  Target "empty_using_rviz_2d_overlay_plugins" links to target
  "rviz_2d_overlay_msgs::rviz_2d_overlay_msgs__rosidl_typesupport_introspection_c"
  but the target was not found.  Perhaps a find_package() call is missing for
  an IMPORTED target, or an ALIAS target is missing?

CMake Error at CMakeLists.txt:19 (add_library):
  Target "empty_using_rviz_2d_overlay_plugins" links to target
  "rviz_2d_overlay_msgs::rviz_2d_overlay_msgs__rosidl_typesupport_c" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?

CMake Error at CMakeLists.txt:19 (add_library):
  Target "empty_using_rviz_2d_overlay_plugins" links to target
  "rviz_2d_overlay_msgs::rviz_2d_overlay_msgs__rosidl_generator_cpp" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?

CMake Error at CMakeLists.txt:19 (add_library):
  Target "empty_using_rviz_2d_overlay_plugins" links to target
  "rviz_2d_overlay_msgs::rviz_2d_overlay_msgs__rosidl_typesupport_fastrtps_cpp"
  but the target was not found.  Perhaps a find_package() call is missing for
  an IMPORTED target, or an ALIAS target is missing?

CMake Error at CMakeLists.txt:19 (add_library):
  Target "empty_using_rviz_2d_overlay_plugins" links to target
  "rviz_2d_overlay_msgs::rviz_2d_overlay_msgs__rosidl_typesupport_introspection_cpp"
  but the target was not found.  Perhaps a find_package() call is missing for
  an IMPORTED target, or an ALIAS target is missing?

CMake Error at CMakeLists.txt:19 (add_library):
  Target "empty_using_rviz_2d_overlay_plugins" links to target
  "rviz_2d_overlay_msgs::rviz_2d_overlay_msgs__rosidl_typesupport_cpp" but
  the target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?

CMake Error at CMakeLists.txt:19 (add_library):
  Target "empty_using_rviz_2d_overlay_plugins" links to target
  "rviz_2d_overlay_msgs::rviz_2d_overlay_msgs__rosidl_generator_py" but the
  target was not found.  Perhaps a find_package() call is missing for an
  IMPORTED target, or an ALIAS target is missing?

CMake Generate step failed.  Build files cannot be regenerated correctly.

Any suggestions are much appreciated! Thanks

I'm not really familiar with the ros/idl/typesupport message generation, and even less so with bazel, so i can't really help with that.
Maybe it's related to this problem?: https://github.com/teamspatzenhirn/rviz_2d_overlay_plugins/issues/14#issuecomment-1380705752
I think that issue was resolved in some other way, but perhaps there is something wrong with the message-package...

Gotcha, thanks for all the help. I will keep investigating this. Perhaps, opening a new issue regarding this would be more apt?


Wrap mdc-chips

Wrap mdc-chips js module in new kmdc-chips module.

@mpetuska I'll take this one.

Thanks. Note that there is already a module ready for it as I had an initial stab at implementing it months ago and had to put it back in the drawer due to shortage of time. Feel free to either build on top of what I've left or remove it and implement from scratch.

@pocharlebois please pull in latest master version from the upstream before starting any work. I've juts merged some significant refactoring.

@pocharlebois are you still planning on implementing this? I've finally found some spare time to get back to this project and could pick this up if you no longer have the capacity to complete it.

@mpetuska we ended up using a different UI paradigm for the project I am working so I didn't end up implementing the mdc-chips. You can unassign me from the issue for the time being and I'll let you know if I have availability to further support the development of his library. Thanks a lot for your amazing work!

Hah, I suspected as much. No worries, thanks for clarifying and all your contributions so far.

Just be be clear, we are still using KMDC :) But the specific chip was not immediately required.


[New game]: Tower Blocks

🎮 Game Request
Game logic and basic description
Blocks will be sliding in different directions. Your aim is to stop them at the right place so as to make the highest tower possible.
Point down the features
Game points
Each time the height of a tower is increased 10 points are scored. When this series breaks, the game ends.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @singh-anushka  ! Thank you for raising an issue 💗 You have been assigned this issue you can start working on the issue 🎮

Hey @singh-anushka ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


cgroups::config::options wrong type?

So according to documentation "cgroups::config::options" should be as a hash.
  cgroups::config::options:
    blabla: 1
    ssadas: 5

but in the config.pp I see this
validate_array($options)

and of course I'm getting following error:
==> default: Error: {"cfs_period_us"=>"2"} is not an Array.  It looks to be a Hash at /tmp/vagrant-puppet/modules-be897c4d40d9e94dadf022aab51dab05/cgroups/manifests/config.pp:12 on node monitor01.us-east-1b.public
==> default: Error: {"cfs_period_us"=>"2"} is not an Array.  It looks to be a Hash at /tmp/vagrant-puppet/modules-be897c4d40d9e94dadf022aab51dab05/cgroups/manifests/config.pp:12 on node monitor01.us-east-1b.public

Is the documentation is deprecated?

just tried following
cgroups::config::options:
  - cfs_period_us: '2'

and as a result got this:
$ cat cgconfig.conf
#
# This file is managed by puppet class cgroups::config
#

mount {
  cpu = /sys/fs/cgroup/cpu;
  cpuacct = /sys/fs/cgroup/cpuacct;
  cpuset = /sys/fs/cgroup/cpuset;
  devices = /sys/fs/cgroup/devices;
  memory = /sys/fs/cgroup/memory;
  freezer = /sys/fs/cgroup/freezer;
}

{"cfs_period_us"=>"2"}

But syntax is something like this
group lab2 {
        cpu {
                cpu.rt_period_us="1000000";
                cpu.rt_runtime_us="0";
                cpu.shares="3";
        }
}

So I wondering, is this module completly messed up or I'm doing something wrong?

The documentation is wrong. If you look at the template it is printing out each option one per line. So it expects something like ['cpu.shares="3"', 'cfs_period_us="2"']
I don't have an explanation for this except that this was one of my very early modules and I did it wrong. I don't have access to this repo anymore so I can't fix it either. If you think you will use this module I could fix it in a fork.

@apowers,
got it, thank you
It definitely will be very useful if you will be able to fork and fix it. I'm going to use it, yes.

Try this: https://github.com/apowers/puppet-cgroups
I haven't done any functional tests so if it doesn't do what you expect please let me know.

@apowers since yesterday I'm getting following error when module is invoked
expected ',' or ']' in array at '{
      "name": "pup'! at /tmp/vagrant-puppet/manifests-846018e2aa141a5eb79a64b4015fc5f3/default.pp:29 on node monitor01.local.public

where line 29 is:
    class { 'cgroups': }

I also tried to invoke this as
    include '::cgroups'

still getting the same error

when I'm testing this with puppet 3 - it works, and in case of puppet 2.7 - i'm getting this error

Look at init.pp line 13; I think Puppet 2.7 doesn't like the trailing comma.

nope :(
I also tried to remove trailing comma from service.pp, same error. Also I was playing with different versions of stdlib, doesn't seem related for me.

oh my... nm, just figured out that it's conflicting with rundeck's puppet module... insane, spend so much time :(

Hey @apowers
I just sent you a pull request, minor changes
Also a template of configuration seems broken. Puppet generates following
#
# This file is managed by puppet class cgroups::config
#

mount {
  cpu = /sys/fs/cgroup/cpu;
  cpuacct = /sys/fs/cgroup/cpuacct;
  cpuset = /sys/fs/cgroup/cpuset;
  devices = /sys/fs/cgroup/devices;
  freezer = /sys/fs/cgroup/freezer;
  memory = /sys/fs/cgroup/memory;
}

group lab2 {
cpu {
cpu.rt_period_us = "1000000";
cpu.rt_runtime_us = "0";
cpu.shares = "3";
}
cpu = "cpu.rt_runtime_us0cpu.rt_period_us1000000cpu.shares3";
}

following string is unformated dublicate:
cpu = "cpu.rt_runtime_us0cpu.rt_period_us1000000cpu.shares3";

this is from hiera:
cgroups::config::ensure:  'present'
cgroups::service::ensure:  'running'
cgroups::service::enable:  'true'
cgroups::config::rules:
  - 'oracle    cpu,cpuset,memory    dbgrp'
  - '@guest    devices              devgrp'
  - '%:rm      devices              devgrp/rm'
cgroups::config::options:
  'group lab2':
      'cpu':
          'cpu.rt_period_us':  "1000000"
          'cpu.rt_runtime_us': "0"
          'cpu.shares':        "3"

Thanks. I'll fix the template tomorrow morning.
On Thu, Sep 3, 2015 at 5:25 PM Stanislav<EMAIL_ADDRESS>wrote:

Hey @apowers https://github.com/apowers
I just sent you a pull request, minor changes
Also a template of configuration seems broken. Puppet generates following

This file is managed by puppet class cgroups::config

mount {
cpu = /sys/fs/cgroup/cpu;
cpuacct = /sys/fs/cgroup/cpuacct;
cpuset = /sys/fs/cgroup/cpuset;
devices = /sys/fs/cgroup/devices;
freezer = /sys/fs/cgroup/freezer;
memory = /sys/fs/cgroup/memory;
}
group lab2 {
cpu {
cpu.rt_period_us = "1000000";
cpu.rt_runtime_us = "0";
cpu.shares = "3";
}
cpu = "cpu.rt_runtime_us0cpu.rt_period_us1000000cpu.shares3";
}
following string is unformated dublicate:
cpu = "cpu.rt_runtime_us0cpu.rt_period_us1000000cpu.shares3";
this is from hiera:
cgroups::config::ensure:  'present'
cgroups::service::ensure:  'running'
cgroups::service::enable:  'true'
cgroups::config::rules:

'oracle    cpu,cpuset,memory    dbgrp'
'@guest    devices              devgrp'
'%:rm      devices              devgrp/rm'
cgroups::config::options:
'group lab2':
'cpu':
'cpu.rt_period_us':  "1000000"
'cpu.rt_runtime_us': "0"
'cpu.shares':        "3"

—
Reply to this email directly or view it on GitHub
https://github.com/seattle-biomed/puppet-cgroups/issues/1#issuecomment-137607437
.

--
Perfection is just a word I use occasionally with mustard.
--Atom Powers--

Thank you!

Updated. See if that works.
For further bugs, please report them in the new repo so that we don't annoy
whoever is monitoring this one.
On Thu, Sep 3, 2015 at 6:25 PM Stanislav<EMAIL_ADDRESS>wrote:

Thank you!
—
Reply to this email directly or view it on GitHub
https://github.com/seattle-biomed/puppet-cgroups/issues/1#issuecomment-137616657
.

--
Perfection is just a word I use occasionally with mustard.
--Atom Powers--

I'll test it today, thank you!

For further bugs, please report them in the new repo
Ok, make sense. The only one question, should I close this ticket or let's keep it open for people who will come from googling for this module so they will be able to find this ticket fast and follow a link to your fork


support pc that doesn't have GPU

I think the smooth performance of applications using this library is really impressive.
By the way, do you have any plans to support running without a GPU?
I tried running it on a Windows PC without a GPU, but I encountered the following error:
thread 'main' panicked at C:\Users\oligami\.cargo\registry\src\index.crates.io-6f17d22bba15001f\wgpu-0.20.1\src\backend\wgpu_core.rs:751:18:
Error in Surface::configure: Validation Error

Caused by:
    Invalid surface

We'd like to get that working, but it's not a priority for us at the moment.


script support

I would like to have the script support. i.g. That should work:
fsi Main.fsx --help

it is not the case with this usage of argu:
let parser = ArgumentParser.Create<Arguments>()
let args = parser.Parse()

my bad? seems to work in current version


Weird Playlist Duplication bug

Well.... Playlists like to dupe songs. A lot.
http://i.imgur.com/CfR9AkB.png
The playlists above are imported straight from plug. I shouldn't have 721 tracks.
There are like 18 copies of "Nightcore - Senpai" down the list.
Please fix ;_;

just tried it too and i'm not having any problems, maybe check if your exported json?

Same bug here...

I was using leveldb so probably only using mysql

It seems like only playlists that were imported as a file are affected by this bug.

Indeed. I don't like deleting many many copies of tracks via PhpMyAdmin. There are literally hundreds upon hundreds of dupes I would need to get rid of. Screencap: http://i.imgur.com/KgJg6lE.png
Also when I say hundreds upon hundreds of dupes, I dont mean hundreds of the same song. I mean hundreds of dupelicated tracks in general. Example in the screencap.

I'll try to look into this a little deeper tonight.  @DerpgonCz wrote the MySQL code, so I've yet to look at it.

@foodbandlt Alright then ;3

If you need a solution immediately you could delete all duplicates on the 'media' table and create a unique constraint for 'cid' and 'pid':
ALTER IGNORE TABLE media
ADD UNIQUE INDEX uq_media (pid, cid);

@virtuaCode Thanks for the help, i'll try when I get some free time.

Fixed in e548a8a

The amount of confusion with that close/reopen there :|

We thought the issue was solved, but after more testing found that it wasn't.  Still needs to be looked into.

I have a couple of users commenting this morning that this https://github.com/musiqpad/mqp-server/issues/9#issuecomment-199803977 is true and still happening.  They are using the DT importer.  Looks like the import works OK, but on refresh they have multiple copies of each song.

@ImGrumpy I will try to check it today


[Poke] Viewing assistant instructions: use TextArea

Description
Allows to read instructions otherwise unreadable
Before

After

Risk & deploy
na

PMRR


Add stress tests for session lock renewal

For more context, refer to #2281

Currently running and monitoring these tests to see if same issue as message lock renewal surfaces.
So far 10 minutes 10 seconds have passed and did not find same issue.

@ramya-rao-a @AlexGhiondea
The cases listed above are different from https://github.com/Azure/azure-sdk-for-js/issues/2363
#2363 was created specifically to address this gap. Let's use it to discuss about this and have scenarios agreed upon before implementing.
Let's have this PR focus on the session lock renewal use-cases.
At this point, inspite of applying associated-link-name fix and the double delay fix, the manual session lock renewal test just failed. (though manual message lock renewal passed just fine).

Just verified newer test runs on both auto and manual session lock renewals, and they both pass as expected! (for 20 min)
Leaving them to run for 24 hours.


Introduce stricter validation around ProvisionerClass name CRDs

RukPak expects to support multiple provisioners in the future. These provisioners will likely be defined through a CRD. We should update the bundle.Spec.ProvisionerClassName and bundleDeployments.Spec.ProvisionerClassName fields to include strict validation matching that of metadata.Name in the k8s api:
# example metadata.Name regex
$ k create configmap test./t
error: failed to create configmap: ConfigMap "test./t" is invalid: metadata.name: Invalid value: "test./t": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

Note: Services have unique metadata.Name requirements, so the names of services cannot be based off a ProvisionClassName that passes this regex.

As a user, I would like to:

have the bundle and bundleDeployment openapiv3 schema reject CRs that include ProvisionerClassNames that cannot be applied to the cluster

To allow provisioner plugin, it may be difficult to implement this validation by

openapiv3 schema reject CRs

We probably implement the validation in the webhook when we define the way to register the plugin provisioner.

We probably implement the validation in the webhook when we define the way to register the plugin provisioner.

I don't think this is true. We should be able to use the metadata.name pattern in the CRD schema of the ProvisionerClassName fields.

I see.  Do we enforce some of these constraint?


Add check preventing users from importing multiple worklists into one

What Issue does this PR resolve? (Link to GitHub Issue, approved features and bugs will be given priority)
Please provide a video demo below, or a screenshot and description of the change.
Tag reviewers for the PR below.

Can you address the prettier checks?

Can you address the prettier checks?

addressed


make variables scoped

Currently variables are saved in a global storage, but I think it's better to make them scoped by collections, like Environments, to avoid naming conflicts. For example we can prefix the variables by collection names.

I like this idea and have pushed some updates. Variables are scoped in version 3.0.0


Landscape Navigation Bar Too Small on iPad

Current Behavior

When an iPad is turned to landscape, the nav bar becomes shorter (due to #2669).  This makes the status bar items (such as the time) touch and overlap with the navigation bar items (like the title).

Expected Behavior

When an iOS device has a size class of Vertical: Compact, the nav bar should be shortened, because the OS hides the status bar automatically.  With a size class of Vertical: Regular (such as on an iPad in landscape), the nav bar should be full height to accommodate the status bar.

The issue is in this file: https://github.com/react-community/react-navigation/blob/master/src/views/Header/Header.js
Your Environment

software
version

react-navigation
1.0.0-beta.15

react-native
0.48.4

node
7.7.1

yarn
1.1.0

are you sure #2676 is related? It handles tab bar, not navbar.

Sorry, meant #2669. I updated

Related to #2794 I think.

@kelset I made both issues and they are related, but still different issues that could be solved independently or at the same time

Hey @SteffeyDev , we released beta.17; does your issue still happen in the latest version?

Looks like this was fixed, thanks guys!  I’ll be ready to start tracking the latest version again as soon as #2794 is fixed

@kelset Not sure if I did check completely enough, or if a later version broke this again, but in beta 21 there is still a slight issue.  When my iPad is in landscape, the nav bar is a few pixels shorter, meaning my bar button icons are very cramped.  I can watch the bar change height when I rotate my iPad.  I don't think this behavior is correct, and the nav bar height should always be 44 points plus status bar height on iPad, regardless of orientation.  I verified that Apple's apps behave this way as well.

Uhm gotcha, thanks for reporting back


Should Boxing day should remove the boxed day from the list of holiday?

In the USA calendar, the 24 on week-end is still listed in the Boxing days.
However in the Australian calendar it is not part of the holiday list anymore.
What is the rule?

I think it is a bug in the Australian calendar apparently

I've always considered that, if the calendar includes a Boxing Day, dec. the 26th should be added to the calendar, whether it happens on a working day or not and that, if there's a "shift rule", you may want to add the extra day to the list of holidays.
It's the same for every calendar in the library. Usually, the label of the day: "<holiday label> shift", or something like this.
Is it answering your question?

I think it is a bug in the Australian calendar apparently

At the federal level, it looks like there's no shift rule. Some Australian States have a shift rule, such as Queensland. See: https://en.wikipedia.org/wiki/Public_holidays_in_Australia#Queensland
What's the bug you're talking about?

I am not talking about the shift rule, just the fact that the 24th is not listed because on the week-end.

the 26th should be added to the calendar, whether it happens on a working day or not

In that case I believe the Australian calendar should list December 24th.


No Events are being emitted.

@YveOms   Same issue here, Does the bot work with prediction V3 or doing nothing?

@Thisuu Check the latest updates. It is working now.


Allow Skill Event to be entered by Submission

Is your feature request related to a problem? Please describe.
I would like if the skills could be entered by a user entering a type of submission.
Describe the solution you'd like
Instead of clicking Report Skill, there would be an area to submit what the user did to complete the skill and even the ability to attach proof (picture/document) of completing the skill.  There would have to be an area in the dashboard that allows for higher level or admin users to approve or deny the submissions.
Describe alternatives you've considered
We've used the BadgeOS plugin for WordPress, for this same functionality, but it lacks the other capabilities that SkillTree provides as well as having to run a full WordPress instance for it to function.
Additional context
Is there something like this feature planned for the project already?  If not, could we have a conversation about the estimated lift to create this by collaboration or contribution.

@adamayd it’s great to hear from you!
This sounds like a very interesting idea! We will discuss it internally and get back to you sometime next week. Thank you very much!

@adamayd
We discussed it internally and here is what we are thinking:
Currently users of integrated applications can ONLY view their skills progress and ranking within that integrated application using SkillTree’s Skills Display Component. Admins of an application can use the SkillTree dashboard to view users skill progress and ranking but not the users themselves. We currently have on our roadmap to add the ability for users to view their ranking and skill progress directly in the dashboard which will probably work well with what you are requesting and is probably a dependency to your request.
With this new capability, non-admin users can then go directly to the Dashboard and view their skills and progress. One idea is to add a self-reporting button – something like “I did it” or “Done” on specific skills; It could also accept an explanation and as you mentioned maybe even screen shots. In this scenario a project admin would be able to enable self-reporting for all the skills or only select skills. Project admins can then also chose whether self-reported skills would have to go through the approval workflow OR just use the honor system.
This is a complicated feature that would touch multiple facets of SkillTree architecture so we are thinking it would make sense to develop it internally. We added this feature to our roadmap projected to be worked on Summer of 2021. However, we very much welcome contributions, the best way is to pick up an unassigned ticket tagged with 'Good First Issue'
Thanks again for such a wonderful idea!!

@sudo-may
This is great news.  I'll take this information back to my team and see what / how we could contribute.  I greatly appreciate you considering this and putting it on the roadmap.  I look forward to working with you in any capacity we can!!

@adamayd fyi - I am picking up this ticket now - we will target it for the next release (1.4.0)

@adamayd fyi - I am picking up this ticket now - we will target it for the next release (1.4.0)

PR: https://github.com/NationalSecurityAgency/skills-service/pull/327

@sudo-may
a couple of things I noticed:

"Submitted Successfully" is in the middle of the other two sentences - this should probably be first, with the other two following it (maybe on a separate line)?
Also, maybe reword the other sentences to "This skill requires approval from a project administrator.  Now let's play the waiting game!"
and the last thing, the approval button, when you go to click it and are hovering over it, the background color it changes to is too dark and you cannot read the text in the button anymore.. we may need to invert the text color I think

merged PR: #356

@adamayd just circling back to let you know that this feature is now available as a part of skills-service:1.4.0 release (current latest is 1.4.3 however). You can also take a look at the Self Reporting sections of the docs. Feedback and comments are welcome. Have a wonderful day!

@sudo-may Thanks for circling back.  I am no longer on the project that was looking at your solution, but I will surely pass this information along.


Problem with LhBarrierBeginStackTrace AFTER the original function is called from a hook handler

Hi, I'm trying to log functions together with a callstack trace.
My hook handler:
LPVOID WINAPI HeapAllocHook(
	_In_ HANDLE hHeap,
	_In_ DWORD  dwFlags,
	_In_ SIZE_T dwBytes
	)
{
	LPVOID result = HeapAlloc(hHeap, dwFlags, dwBytes);
	PVOID pCallStackBackup = NULL;
	LhBarrierBeginStackTrace(&pCallStackBackup);

// Here I call my own logger function which captures stack trace and logs the 'result' and the dwBytes
        Log(result,dwBytes);

	if (pCallStackBackup)
		LhBarrierEndStackTrace(pCallStackBackup);
	return result;
}

The problem is that I get the "The caller is not inside a hook handler." error when calling the LhBarrierBeginStackTrace function in the example above. It looks like that after calling the original HeapAlloc function the LhBarrierBeginStackTrace can't obtain the 'Runtime->Current' pointer as the LhBarrierIntro's DONT_INTERCEPT part will set it to NULL. So when it returns, these functions think that they are outside the hook handler, however it is not the case.
This makes it really awkward for me to capture call stack as I would need to first Save it early to somewhere, then call the original function, then pass the saved callstack to my logger function separately. There could be other scenarios too which can be problematic I guess.
Is there a recommended workaround for this (so this behaviour is intentional), or is it a bug in easyhook?
Thanks in advance!

In the meantime I just commented out the part which zeroed the context like bellow. It seems to fix the problem above, but I'm kind of afraid that I did break something else, or will have some side effects.
ULONGLONG LhBarrierIntro(LOCAL_HOOK_INFO* InHandle, void* InRetAddr, void** InAddrOfRetAddr)
{
.....
DONT_INTERCEPT:
	/*  !!Note that the assembler code does not invoke UnmanagedHookOutro() in this case!! */

	if(Info != NULL)
	{
	/*	Info->Current = NULL;
		Info->Callback = NULL;*/

		ReleaseSelfProtection();
	}

	return FALSE;
}

Are you by chance using a debugger to break on LhBarrierBeginStackTrace? If so, try moving your breakpoint to the next instruction.
Yes what you have commented could cause some issues. Basically the hook is protecting from anything not on the correct thread from accessing the hook info, if using the debugger I have seen the self-protection cause issues (at least in .NET/C#).
There was another request to expose the AcquireSelfProtection and ReleaseSelfProtection, but I'm not convinced that is a good idea yet as it may just hide the underlying issue.

Oh wait - you should not call the original function first. Once you call the original function you lose the context.
i.e. move LPVOID result = HeapAlloc(hHeap, dwFlags, dwBytes); to below where you get the stack trace.

you should not call the original function first. Once you call the original function you lose the context.
Yes that's my observation too.
So there is a limitation then: After the original function is called it is not currently possible to call these functions:

LhBarrierGetCallback
LhBarrierGetReturnAddress
LhBarrierGetAddressOfReturnAddress
LhBarrierBeginStackTrace
LhBarrierEndStackTrace

As these are all referencing the Runtime->Current.
Can this limitation be removed later on?

Providing it is all on the same thread I believe it may be possible. I don't think this will happen until version 2.8 however.

Thanks! I'll workaround for now.


Add embedding scale to nn.Embedding.

Differences between conformer_ctc and conformer_ctc_embedding_scale
conformer_ctc_embedding_scale replaces nn.Embedding with modified
Embedding. Modified embedding contains two changes:

(1) The weight matrix is initialized to the range (-std, std) where
std = 1 / sqrt(embedding_dim)

(2) The output of the embedding is scaled by sqrt(embedding_dim)

Also, conformer_ctc_embedding_scale modifies the PositionalEncoding
in transformer.py. It replaces
self.xscale = math.sqrt(self.d_model)
x = x * self.xscale + self.pe[:, : x.size(1), :]

with
self.pos_scale = 1. / math.sqrt(self.d_model)
x = x + self.pe[:, : x.size(1), :] * self.pos_scale

You can use
diff conformer_ctc/transformer.py conformer_ctc_embedding_scale/transformer.py

to find the exact differences.

Here are the results for this pull-request:
(Only the best WERs of each method are listed)
HLG 1best decoding(no LM rescoring, no attention-decoder rescoring)
(model averaging from epoch-40.pt to epoch-49.pt)
2021-09-08 04:35:32,223 INFO [utils.py:317] [test-clean-no_rescore] %WER 2.99% [1573 / 52576, 134 ins, 244 del, 1195 sub ]
2021-09-08 04:37:53,973 INFO [utils.py:317] [test-other-no_rescore] %WER 6.98% [3652 / 52343, 203 ins, 842 del, 2607 sub ]

(model averaging from epoch-22.pt to epoch-49.pt)
2021-09-07 21:50:25,598 INFO [utils.py:317] [test-clean-no_rescore] %WER 3.05% [1602 / 52576, 140 ins, 287 del, 1175 sub ]
2021-09-07 21:52:46,439 INFO [utils.py:317] [test-other-no_rescore] %WER 6.87% [3597 / 52343, 189 ins, 880 del, 2528 sub ]

HLG decoding + 4-gram LM rescoring (whole lattice rescoring, without attention-decoder)
(model averaging from epoch-19.pt to epoch-48.pt)
2021-09-08 08:07:39,492 INFO [utils.py:317] [test-clean-lm_scale_0.6] %WER 2.66% [1399 / 52576, 159 ins, 126 del, 1114 sub ]
2021-09-08 08:14:59,870 INFO [utils.py:317] [test-other-lm_scale_0.7] %WER 6.00% [3140 / 52343, 234 ins, 484 del, 2422 sub ]

HLG + 4-gram LM rescoring (whole lattice-rescoring) + attention-decoder rescoring
((model averaging from epoch-24.pt to epoch-49.pt)
2021-09-07 22:05:24,962 INFO [decode.py:437]
For test-clean, WER of different settings are:
ngram_lm_scale_1.0_attention_scale_0.6  2.64  best for test-clean
ngram_lm_scale_0.9_attention_scale_0.6  2.65
ngram_lm_scale_1.0_attention_scale_0.7  2.65
ngram_lm_scale_1.3_attention_scale_1.3  2.65
ngram_lm_scale_0.9_attention_scale_0.5  2.66
ngram_lm_scale_0.9_attention_scale_0.7  2.66
ngram_lm_scale_1.0_attention_scale_0.9  2.66
ngram_lm_scale_1.0_attention_scale_1.0  2.66

2021-09-07 22:17:03,741 INFO [decode.py:437]
For test-other, WER of different settings are:
ngram_lm_scale_0.9_attention_scale_0.7  5.91  best for test-other
ngram_lm_scale_1.0_attention_scale_0.9  5.91
ngram_lm_scale_0.7_attention_scale_0.6  5.92
ngram_lm_scale_0.7_attention_scale_0.7  5.92
ngram_lm_scale_0.9_attention_scale_0.5  5.92
ngram_lm_scale_0.9_attention_scale_1.1  5.92
ngram_lm_scale_0.9_attention_scale_1.2  5.92

The results are comparable with the one from the latest master
(https://github.com/k2-fsa/icefall/blob/master/egs/librispeech/ASR/RESULTS.md)
WERs of test-clean and test-other:
test-clean:

this pull-request: 2.64
master: 2.57

test-other:

this pull-request: 5.85
master: 5.94

I think the reason this doesn't make much difference is that since this embedding is only used as an input, leaving it as random vectors works OK since the rest of the network can just figure out what to with it.  But I think it's probably good practice to train it regardless.  There might be setups with larger vocabs, where this matters.


use c extension

If I use C extensions. Cassandra at the time of connection. PHP is also need to require_once the php files lib directory?
e.g:
lib/cassandra/Cassandra.php
lib/cassandra/Types.php
lib/phpcassa/Connection/Connection.php

I suggest doing your imports like this: https://github.com/thobbs/phpcassa/blob/master/examples/basic.php#L17-L22
Once the C extension is compiled, you don't need to include anything special to use it.  Just make sure thrift_protocol.so is added to your php.ini file, as described in the README file.


Vendor dependencies, update k8s to 1.16.3

Following the #322
Will merge after fixing the issue with draughtsman

Tested on gauss.
Needs to be deployed at the same time as https://github.com/giantswarm/draughtsman/pull/95 as both components share the same tiller.

Tested on geckon. Going with this.


Add admin-page link to people-page

Added Admin Page Link to the People Page, a Fix for Issue#53

@FlatBallFlyer Here is a screen shot of new changes based on previous comments/suggestions


how to do batched write using YACassandraPDO?

I want to make 100 inserts with the entire process being atomic. Can I do it with this php driver?

I never used atomic batches with this driver in production, and I know that it is not tested. But it should work.
Have a try with something like:
$db->exec("BEGIN BATCH UPDATE table  set full_name='USER1' where my_key='u1' UPDATE table set full_name='USER2' where my_key='u2' APPLY BATCH;");
But I think best option is to use the new DataStax driver:
https://github.com/datastax/php-driver
It has full support to atomic batch
https://github.com/datastax/php-driver/tree/master/features#batch-statements

But I think best option is to use the new DataStax driver:
https://github.com/datastax/php-driver

Thank you for the link!

@sandro-lex  Thx. Its working.
But when I var_dump it,it gives me 0 even when it inserts all the rows.
Is there any way to get the acknowledgement whether the atomic operation was succesful or not?


xdescribe

want Jasmine's xdescribe. :)

what's xdescribe do?

ah I see, sure I guess there's no harm in that it would be a tiny patch

I would almost prefer _describe( xdescribe( in a big suite might not stand out much, but if that's the convention other frameworks are using it's probably best to keep it the same

in case anyone want documentation for xdescribe. The jasmine documentation works https://jasmine.github.io/2.0/introduction.html#section-Disabling_Suites


Issue with Done Button Enabled State

If you configure Card.io to use your apps theme, it colors the cancel and done buttons as your app's colorButtonNormal color. The issue is, when the button is disabled, it does not turn grey, but remains the colorButtonNormal color, and just loses the ability to be pressed. I am assuming you are setting backgroundTint on the button. I would recommend instead setting the android:theme attribute on the button, and giving it a style that looks something like:
<style name="ButtonTheme">
        <item name="colorButtonNormal">?attr/colorButtonNormal</item>
</style>

Ahh I see. Are you guys looking to avoid appcompat as a dependency? Otherwise, it would be great to change the new Button() call to a new AppCompatButton so that the button would appear more materialized on pre 5.0 devices.


Github Actions Workflow failure

@craig-shenton  - flagging that the github action workflow is failing, any ideas on how to resolve?

@maryamanuelnhsx workflow is up and running again :)

Great! thanks @craig-shenton 😃


added retry for ratelimit error in slack api

Slack api throws 'ratelimit' error when we try to post more than one message per minute per channel as per our subscription.
This usually happens when multiple CI tests are running at the same time and sends error report in slack for us.

Added a delay to retry sending the message in case of ratelimit error.

Can one of the admins verify this patch?

Can one of the admins verify this patch?


[BUG] Incorrect URL in GitHub repo details

The link in the GH repo details is not pointing to anything valid: https://supportukraine.netlify.app/. It should be https://www.assistukrainians.com/.
Nice job with the project btw 👍

Thanks and hey nice catch! Updated the link now to the new domain✌🏻


Fix llvm relo error caused by multiple ports in policy

This is a similar error to the one we already fixed for IPv6 addresses. Here we implement a similar fix. The macros in this case however are a bit more complex because the port policy is a variable length map vs a single structure. This forces the macro to handle variable length maps as well and results in a slightly complex macro.
An alternative solution would have been to extend the code generation to emit more of the bpf codes. This would be a more significant change in design and I think the macro is good enough for the time being.

interestingly 4.8 works, 4.9 gives the errors from jenkins, 4.11 and 4.12 work again.

OK got this working on 4.9 by "unrolling" the for loop over allowed in the macro to make it a series of ternary expressions. Will do some more testing but should resolve the issue reported here although it is not pretty.


Why not use add_resource() to add instance of resource

flask-restful use add_resource() to add resource class to route below
class User(Resource):
    def get(self):
        pass

app = Flask(__name__)
api = Api(app)

api.add_resource(User, ...)

So I can not inject database connection into resource class. Why flask-restful do not use add_resource() to add instance of resource. By that way, I can free to create instance of resources
class User(Resource):
    def __init__(self, db):
        self.__db = db

    def get(self):
        return self.__db.find_one()

app = Flask(__name__)
api = Api(app)
mongo_client= MongoClient('...')
db = mongo_client.gwisp

api.add_resource(User(db), ...)

You can provide resource_class_args/kwargs as keyword arguments when registering a resource, they did be a sequence and mapping respectively.
As for why not provide an instance, it's so any changes you make to the state of the resource during a request is thrown away after the request. Vanilla Foam does the same thing with its class views

Oh, I got it and I have other question
For each request, flask-restful create an instance of resource and free it after that. That's mean

All of instance of resource are the same. It is created by same class, same arguments
Flask have not process request by multi-threading. Memory of instance of resource is safe

So why not use only instance of resource to reduce creation time ?

So why not use only instance of resource to reduce creation time ?

There's ongoing discussion about that on #616

Problem is solved by #616


Look at Rust test runners and decide what features we should add

At least look at cargo test and cargo nextest.
We don't need to implement every feature that other test runners implement, but we should understand them and consider if a feature might be useful. When this issue is done, there should be new issues for the desired features.

I'm going to call this done. I've added a lot of issues for "missing" features. Those issues might be updated, expanded, split apart, etc in the future, but I think I've got all of the functionality called out in issues.


[Bug] - "migrate: parse: read migration: open migrations\postgres\1_init.sql: file does not exist"

Hello there
Thanks for keeping this tool going. I tried to run it for the first time on windows and I'm getting this weird error

Apr 27 04:46:48 FTL Failed initialising processor error="migrate: parse: read migration: open migrations\postgres\1_init.sql: file does not exist"

Any ideas? I'm using the latest release btw (v.1.4.1)

I'll look into it, probably Windows path using backslashes.. I haven't tested it on Windows since I don't use it.

open migrations\postgres

Hi, sorry for not getting back sooner. I can see that you're using Postgresql, would you mind testing with SQLite and see if you get the same error? Of course, first download the latest version just in case.

open migrations\postgres

Hi, sorry for not getting back sooner. I can see that you're using Postgresql, would you mind testing with SQLite and see if you get the same error? Of course, first download the latest version just in case.

Got this error now.
May 13 01:05:33 FTL Failed initialising processor error="migrate: parse: read migration: open migrations\\sqlite\\1_init.sql: file does not exist"
Don't think its progres thats causing the issue. Using latest prerelease BTW

I probably have to move that sql directly inside the code so that it works on Windows, will ping you here when it's done.

https://github.com/golang/go/issues/44305

Hmm actually the path it set correctly migrations\\sqlite\\1_init.sql. I'll setup a VM to test what's actually wrong

Haven't got around to it because of my studies, and priorities lying elsewhere.. Are you doing any path rewrites in your config?

I've setup a VM, and it's as you describe (regardless of config), probably Go embed not embedding the migrations correctly for windows

So sorry this took so long, and it was literally this but I had been looking here instead of down here... I thought the error had an s at the end, but it didn't.


Azerbaijani translation

Hi, i made Azerbaijani translation for Laravel. You can add it too (https://github.com/themahabbat/Laravel-AZ)

Hello,
can you do a pull request with your work please ?
Thank you by advance

Of course.


Change the pattern of exports

Hi @jvandemo ,
Recently I used your generator to create the ng2-highcharts library at npm. It's great! Very usefull.
Than, @NathanWalker pointed me to this discution angular/angular-cli#96 which I think is a very good patter to follow.
It would be nice to have this pattern implemented in this generator. What do you think?

@Bigous — The new pattern has been added today by @NathanWalker so it's in the generator now.
Thanks for your feedback and thanks to @NathanWalker for bringing it to this generator!


User Information

Overview
As a user, I should be able to edit information about myself through a settings page
Right now, we don't have an updated design for the settings page, but this can be a rough draft for now. Currently, the user metadata contains the user's name, major, minor (optional), year, career, and clubs they are a part of. A settings page should allow users to edit this information about them through some form that they can submit to view changes.
For this issue, you will need to look into how to use drizzle in order to make tables and relationships between tables. You will also need to connect the user metadata to a userId within next-auth.

NextAuth stuff can also help with this. The callback can help you set data within the session object

I can work on this. Is it fine if I have the userId (from users table) as a primary key for the userMetadata table?

Yea, that works best since we can access their id directly from the session object


Android: Properly implement OS.native_play_video

It was implemented in Java but not called in the IO wrapper it seems.

Not tested yet. I'm not even sure it compiles :)
The corresponding code has been removed from the master branch it seems @CC @m4gr3d @pouleyKetchoupp), and is now only implemented for iOS. We should maybe look into completing removing it from master and expose native video playback differently (CC @bruvzg @naithar).

We should maybe look into completing removing it from master and expose native video playback differently

Seems reasonable, since iOS doesn't natively display .mp4 without custom codec. Should be also pretty simple to do, since it's separated already.
Video display could probably be done with plugins at this point, at least for master branch.
I guess https://github.com/godotengine/godot/pull/42648 should be redone for 3.2 only.

I've tried to load .mp4 and .ogv files from the project folder in this project: Native Play.zip
But whatever I do I seem to get a FileNotFound error:
11-24 11:34:59.341 11687 11840 W MediaPlayer: Use of stream types is deprecated for operations other than volume control
11-24 11:34:59.342 11687 11840 W MediaPlayer: See the documentation of setAudioStreamType() for what to use instead with android.media.AudioAttributes to qualify your playback use case
11-24 11:34:59.344 11687 11840 W MediaPlayer: Couldn't open BBB.ogv
11-24 11:34:59.344 11687 11840 W MediaPlayer: java.io.FileNotFoundException: No content provider: BBB.ogv
11-24 11:34:59.344 11687 11840 W MediaPlayer: 	at android.content.ContentResolver.openTypedAssetFileDescriptor(ContentResolver.java:1688)
11-24 11:34:59.344 11687 11840 W MediaPlayer: 	at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1518)
11-24 11:34:59.344 11687 11840 W MediaPlayer: 	at android.content.ContentResolver.openAssetFileDescriptor(ContentResolver.java:1435)
11-24 11:34:59.344 11687 11840 W MediaPlayer: 	at android.media.MediaPlayer.attemptDataSource(MediaPlayer.java:1154)
11-24 11:34:59.344 11687 11840 W MediaPlayer: 	at android.media.MediaPlayer.setDataSource(MediaPlayer.java:1112)
11-24 11:34:59.344 11687 11840 W MediaPlayer: 	at android.media.MediaPlayer.setDataSource(MediaPlayer.java:1019)
11-24 11:34:59.344 11687 11840 W MediaPlayer: 	at org.godotengine.godot.GodotIO.playVideo(GodotIO.java:578)
11-24 11:34:59.344 11687 11840 W MediaPlayer: 	at org.godotengine.godot.GodotLib.touch(Native Method)
11-24 11:34:59.344 11687 11840 W MediaPlayer: 	at org.godotengine.godot.input.GodotInputHandler$5.run(GodotInputHandler.java:194)
11-24 11:34:59.344 11687 11840 W MediaPlayer: 	at android.opengl.GLSurfaceView$GLThread.guardedRun(GLSurfaceView.java:1502)
11-24 11:34:59.344 11687 11840 W MediaPlayer: 	at android.opengl.GLSurfaceView$GLThread.run(GLSurfaceView.java:1272)

I'm not really familiar with the Android ecosystem, so I don't know what kind of path I'm supposed to pass exactly. The third button in my project tries to load a file from external storage (with related permission set) but that doesn't work either.
The relevant code is here and seems to localize the URI within the application context, so I guess I have to pass a relative path to the file, but neither BBB.mp4 nor assets/BBB.mp4 seem to work:
https://github.com/godotengine/godot/blob/5a66e66448b201294b26c017fea76310fde5ad74/platform/android/java/lib/src/org/godotengine/godot/GodotIO.java#L572-L584
Help welcome as this is a bit outside my area of expertise :)

When I was testing iOS's Native Video I've had to move .ogv file to user:// directory first and load it from there. I think copying from res:// to user:// worked, but I'm not sure - my latest test project copies the video file by using Xcode build phases directly.

AFAIK, removing res:// from path and then context.getResources().getAssets().open(path); will work.

The way I get the correct paths is by querying the MediaStore.
On Android several paths can refer to a single file but not all paths can be used by all users/applications.
private IEnumerable<string> ListAllVideos()
{
    var items = new List<string>();

    var projection = new string[] { MediaStore.Video.VideoColumns.Data, MediaStore.Video.VideoColumns.DisplayName };
    var cursor = this.ApplicationContext.ContentResolver.Query(MediaStore.Video.Media.ExternalContentUri, projection, null, null, null);

    cursor.MoveToFirst();
    do
    {
        items.Add(cursor.GetString(cursor.GetColumnIndexOrThrow(MediaStore.Video.VideoColumns.Data)));
    } while (cursor.MoveToNext());
    cursor.Close();

    return items;
}

We should maybe look into completing removing it from master and expose native video playback differently

Yea, @pouleyKetchoupp  and I discussed it in the PR to master that removed that code for the Android layer; the idea going forward was, as @naithar mentioned, to leverage plugins instead as they should be more flexible (provide support for more codecs, be an integral and manipulatable part of the scenegraph) than the current implementation.
I've been making some progress on one such plugin, but it still requires some amount of polish before it's stable and ready.
@akien-mga Regarding the issue you're running into, what types of path are expected to be passed to this method? Based on the type, the loading method differs significantly. e.g:

remote path (would need to account for buffering, etc)
local asset path (as they're packaged in the apk, asset files use different loading mechanism than on-device files)
local on device file

Regarding the issue you're running into, what types of path are expected to be passed to this method? Based on the type, the loading method differs significantly. e.g:

remote path (would need to account for buffering, etc)
local asset path (as they're packaged in the apk, asset files use different loading mechanism than on-device files)
local on device file

I don't have strong expectations about this method myself, I was just made aware of its lack of implementation by @timothyparez, while the docs state that it's supported on Android and iOS.
I think the intended use case for this was to leverage the native video decoding of the OS to work around Godot's own limited video decoding features (which might in turn not use the most optimized instruction sets on ARM). So IMO it would be a band-aid for playing local assets from the APK. That seems to be the way it works on iOS too as per https://github.com/godotengine/godot/pull/43811#issuecomment-732830296.
There's probably use cases for playing on-device local files (requires external storage permission), but IMO that can be left out of the scope of unbreaking this feature which we're deprecating in 4.0.
Another option is to edit the doc to remove the mention of Android support, and remove the relevant code in 3.2 too. I first tried exposing the implemented code here as all other native_* videos are also implemented in Android, but without the actual native_play_video code they're all useless.


fix: specify User-Agent when making requests [IA-331]

:tada: This PR is included in version 0.21.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


"Getting started" for Windows:  spress.cmd error

In the "Getting started" page (http://spress.yosymfony.com/docs/getting-started/) it says:
5. Create a wrapping batch script (results in C:\bin\spress.cmd):

      C:\Users\username> cd C:\bin
      C:\bin> echo @php "%~dp0spress.phar" %* > spress.cmd
      C:\bin> exit

the line echo @php "%~dp0spress.phar" %* > spress.cmd is wrong: it should have %%* instead of %*, otherwise the variable gets expanded (to an empty string) during echo and is omitted in the final spress.cmd file — which prevents the spress cmd from passing on additional parameters!
Also, for the same reasons, it would be best to add an % before %~dp0spress.phar, so that even the script path isn't expanded (to the script literal path) during echo, which would allow to create a  spress.cmd file that works even if moved around after creation.
Therefore, the whole line should be changed to:
C:\bin> echo @php "%%~dp0spress.phar" %%* > spress.cmd

Thank you man. I don't use usually Window.

Thanks to you, Spress is really a great software. As for Windows CMD—neither do I use it much. I stumbled across this issue while I was experimenting with the creation of a portable Spress package (with PHP binaries and all, no installation required), which forced me to look into it in detail.
Best regards!

A Spress package sounds interesting. Can you tell me more details about that?

I'm working on a project for a computing-related shared documentation, possibly allowing to use Git version control. So I though of using Spress, because of Markdown ease, code highlighting, ecc.
On Windows  (as usual) even setting up something as simple as PHP might become a deterrant, so I wanted to make sure I could also provide a PHP binary distribution, in standalone format, that could be unzipped along an Spress project to be ready to go—and possibly, one that can work even if on the system other versions of PHP are present.
So far, I've managed to create an archive with PHP binaries (bare minimum configuration, and a few batch scripts) which allow to run an Spress pre-existing project, whithout need to install anything nor change the Windows registry—and worked on a machine with a pre-installed (older) version of PHP.
Linux and Max boxes shouldn't have any problems handling PHP projects. But I think that any Windows project should provide a ready-to-go binary to its potential users—instructions/tutorials end up scaring people even more, since on Windows everything tends to be more complex than needed.
So, basically thats it ... I'm laying the grounds for a sort of collaborative encyclopedia/collection of resources for programmers (sample codes included), based on GitHub and built on Spress. The idea is to have to whole project locally, instead of consulting online, in order to reduce the gap between using it and contributing to it—via Git, any changes and additions become, potentially, contribution to overall project.
It took me many tests with different flat CMS projects to end up finally choosing Spress—for various reasons, I consider it the best tool I've come across so far, at least for the project I have in mind.
Other were discarded for some reason or other.

Hi,
I installed spress on the windows 10.
But the following instruction was not work.
C:\bin> echo @php "%%~dp0spress.phar" %%* > spress.cmd

It would get the error here:
Could not open input file: %~dp0spress.phar

Instead, I changed to the original statement, which is:
C:\bin> echo @php "%~dp0spress.phar" %* > spress.cmd

The spress command then worked.

Another thing is i do the above command on powershell.
The cmd would show like this:

If there is any explanation, it would definitely help other windows users.
I'm not that familiar with those phar things to explain this situation.

This has to do with the fact that in CMD/DOS double percent %% is used for variables, while single percent % is used for parameters.
%0 expands to the the pathname of the batch script itself. (%0 is like an implicit parameter, even when no parameters are passed to the invoked script).
%~dp0 expands to the current script's Drive letter + path (filename excluded). It contains two extended syntax modifiers:

%~d: expands to the Drive letter
%~p: expands to the Path only

which are joined together in %~dp0.
More info can be found here:

http://ss64.com/nt/syntax-args.html
http://ss64.com/nt/syntax-esc.html
http://ss64.com/nt/set.html

@tajmone , thanks for your response. I will read through it.

I know I'm late with the response. The resources refered by @tajmone are very good


error: [Errno 104] Connection reset by peer when doing tail

Context
When doing zappa tail I get:

error: [Errno 104] Connection reset by peer

I have been using Zappa for some time and this has never happened but lately happens quite frequently. Could be an Amazon issue?

Steps to Reproduce
just run Zappa tail dev on any environment
It seems to last for periods of ~ 5 to 10 minutes and then come back. My internet connection is solid.
Your Environment

Zappa version used:
0.44.3

Operating System and Python version:
Ubuntu 14.04
Python 2.7.6

The output of pip freeze:
aniso8601==1.2.1
argcomplete==1.9.2
asn1crypto==0.22.0
base58==0.2.4
boto3==1.4.7
botocore==1.7.14
certifi==2<IP_ADDRESS>
cffi==1.10.0
chardet==3.0.4
click==6.7
cryptography==2.0.3
docutils==0.14
durationpy==0.5
enum34==1.1.6
Flask==0.12.2
flask-marshmallow==0.8.0
Flask-RESTful==0.3.6
future==0.16.0
futures==3.1.1
hjson==3.0.0
idna==2.6
ipaddress==1.0.18
itsdangerous==0.24
Jinja2==2.9.6
jmespath==0.9.3
kappa==0.6.0
lambda-packages==0.16.1
MarkupSafe==1.0
marshmallow==2.13.6
marshmallow-pynamodb==0.6.0
packaging==16.8
placebo==0.8.1
pycparser==2.18
pynamodb==3.1.0
pyOpenSSL==17.2.0
pyparsing==2.2.0
python-dateutil==2.6.1
python-slugify==1.2.4
pytz==2017.2
PyYAML==3.12
requests==2.18.4
s3transfer==0.1.11
six==1.11.0
toml==0.9.2
tqdm==4.15.0
troposphere==1.9.5
Unidecode==0.4.21
urllib3==1.22
Werkzeug==0.12
wsgi-request-logger==0.4.6
zappa==0.44.3

Your zappa_settings.py:

Hmm, haven't seen this yet. Anything you can do to help reproduce? I don't think this is a Zappa issue though.

I have never seen it in so long now it happens so often. However the lambda functions keep operating normally. Let me experiment perhaps it's just Amazon doing something.

So I am still getting this after some time. I was thinking maybe it's because there are a lot of logs? Could that be an issue? It only seems to happen on one project of mine.

I found no solution but it does help to limit logs to like the last day or whatever. It also occurs randomly for me and is just fine lately :/ Weird

Fro the record.  I was having the same issue.  I deleted some log streams and the problem was resolved so I believe that the issue is too large of payload.


Tree builder: use a hash for class lookup

Use a hash lookup for tree builder
Not necessary, but cleans it up a bit and is faster (minimally)

sure, it can be a hash, but it seems you have to construct the hash in a function to avoid the circular dependency on class load

@martinpovolny you like storing string constants, replacing with a constant on first access, or something else?
would be nice for lazy loading.

@kbrock @martinpovolny I do like the clarity, but do not like mutating something that looks like a CONSTANT.  What about an ivar Hash for the caching to be filled in dynamically from a constants hash of strings (as in this code)?

@chessbyte thanks. done

This was on master before Euwe branch was created.


Fix invalid context for Internstudio platform

When torch.cuda.set_device() is lazy, newly created threads for LlamaTritonModelInstance::forward may have no context associated and later cudaMallocAsync will die.
We call cudaSetDevice unconditionally to ensure a valid context is associated.

Hi @lzhangzz If this fix is not applied, in what situations will the issue you mentioned occur? Do you have the minimum reproducible steps? Thanks.

Hi @lzhangzz If this fix is not applied, in what situations will the issue you mentioned occur? Do you have the minimum reproducible steps? Thanks.

In one of our internal platform that uses some form of vGPU, the runtime dies directly when cudaMallocAsync is called from a newly created thread.


Unminified versions of the library don't appear to function

Trying out flowplayer-hlsjs versions, it appears that from the CDN //releases.flowplayer.org/hlsjs/flowplayer.hlsjs.js doesn't work for me in the newest version of FF (without flash installed) but the minified version at //releases.flowplayer.org/hlsjs/flowplayer.hlsjs.min.js does.
Codepen with the minified version (working): https://codepen.io/anon/pen/wmwpYj
Codepen with the unminified version (not working): https://codepen.io/anon/pen/GxKyGv
This is an issue because we want to manage our libraries using npm, and this repository doesn't include the minified versions. Are you not supposed to use the non-minified versions of the library?

The unminified versions contain only the engine plugin, not the hls.js client library. You'll either have to load hls.js in addition , or package it into the plugin (see the Makefile in the repo).
The plugin hasn't been developed for a while though, so we rather recommend to use the hlsjs-lite engine integrated in current player versions. 7.2.5 add event listeners so it has almost the feature set of the external plugin now, minus multiple audio renditions and subtitle support (coming soon).
https://flowplayer.com/docs/player/setup#hlsjs-lite

Thanks @bbbo ! It's a little disheartening to hear that as right on line 15 flowplayer.hlsjs.js says it includes hls.js. https://github.com/flowplayer/flowplayer-hlsjs/blob/master/flowplayer.hlsjs.js#L15
I'll move to using hls.js directly instead, as you suggest. Thanks again!

that's because it will contain the library after running make ;)