HDFS-16092. Avoid creating LayoutFlags redundant objects

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
31m 42s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 17s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 26s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 31s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 11s

trunk passed

+1 :green_heart:
shadedclient
16m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 13s

the patch passed

+1 :green_heart:
compile
1m 18s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 18s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  9s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 52s

the patch passed

+1 :green_heart:
mvnsite
1m 18s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 21s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 12s

the patch passed

+1 :green_heart:
shadedclient
16m 49s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
450m 25s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 46s

The patch does not generate ASF License warnings.

537m  5s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestViewDistributedFileSystemContract

hadoop.hdfs.TestSnapshotCommands

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

hadoop.fs.viewfs.TestViewFSOverloadSchemeWithMountTableConfigInHDFS

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.TestHDFSFileSystemContract

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.web.TestWebHdfsFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3150

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux ab4aeee3e28a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ab0dd989c35136c3b7a025b64a1ef2bf1cf1818e

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/1/testReport/

Max. process+thread count
2590 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 32s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 23s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 15s

trunk passed

+1 :green_heart:
shadedclient
19m 15s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
1m 22s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 22s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 53s

the patch passed

+1 :green_heart:
mvnsite
1m 20s

the patch passed

+1 :green_heart:
javadoc
0m 51s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 30s

the patch passed

+1 :green_heart:
shadedclient
23m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
392m 42s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 45s

The patch does not generate ASF License warnings.

490m 34s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.balancer.TestBalancer

hadoop.hdfs.server.balancer.TestBalancerRPCDelay

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.TestFileChecksum

hadoop.hdfs.TestViewDistributedFileSystem

hadoop.hdfs.TestDFSShell

hadoop.hdfs.TestBlockTokenWrappingQOP

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.hdfs.server.mover.TestMover

hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestReadStripedFileWithDecodingDeletedData

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3150

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 6bfa681cd8c0 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ab0dd989c35136c3b7a025b64a1ef2bf1cf1818e

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/2/testReport/

Max. process+thread count
2439 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 56s

trunk passed

+1 :green_heart:
compile
1m 25s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 15s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  0s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 18s

trunk passed

+1 :green_heart:
shadedclient
18m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 17s

the patch passed

+1 :green_heart:
compile
1m 17s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 17s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 54s

the patch passed

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 48s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 20s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 21s

the patch passed

+1 :green_heart:
shadedclient
18m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
210m  7s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+0 :ok:
asflicense
0m 27s

ASF License check generated no output?

302m 14s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.datanode.TestBlockRecovery2

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.server.namenode.TestListOpenFiles

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.server.datanode.TestDataNodeMXBean

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3150

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 7ece09deaa88 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ab0dd989c35136c3b7a025b64a1ef2bf1cf1818e

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/4/testReport/

Max. process+thread count
1748 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m  0s

trunk passed

+1 :green_heart:
compile
1m 23s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
1m 19s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m  4s

trunk passed

+1 :green_heart:
mvnsite
1m 30s

trunk passed

+1 :green_heart:
javadoc
0m 55s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m 17s

trunk passed

+1 :green_heart:
shadedclient
16m 28s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 16s

the patch passed

+1 :green_heart:
compile
1m 16s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
1m 16s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 51s

the patch passed

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
1m 18s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
3m  8s

the patch passed

+1 :green_heart:
shadedclient
16m  7s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
432m  8s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 47s

The patch does not generate ASF License warnings.

518m 20s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.TestViewDistributedFileSystemContract

hadoop.hdfs.TestSnapshotCommands

hadoop.hdfs.TestDFSShell

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeWithHdfsScheme

hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

hadoop.fs.viewfs.TestViewFSOverloadSchemeWithMountTableConfigInHDFS

hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.web.TestWebHdfsFileSystemContract

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3150

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 8567bd79b47e 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ab0dd989c35136c3b7a025b64a1ef2bf1cf1818e

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/3/testReport/

Max. process+thread count
2525 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3150/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks for the review @jojochuang. The failed tests don't seem related, they are mostly timeout and OOM related flakies.


Connection to Spotify fails - Only Spotify Premium accounts are supported

What version of Music Assistant has the issue?
2023.6.0b6
The problem
I cannot connect to my spotify account. I have a premium subscription but when I try to login I get this error: "Only Spotify Premium accounts are supported".
I created a device password because I normally use Facebook to login into spotify.
How to reproduce

Create password as written here: https://github.com/orgs/music-assistant/discussions/448
Login with the provided username and selected password

Relevant log output
2023-11-13 13:07:15.550 WARNING (MainThread) [music_assistant.providers.spotify] Error while retrieving Spotify token after 0.29 seconds, details:
2023-11-13 13:07:15.550 ERROR (MainThread) [music_assistant.webserver] [281472431698640] Error handling message: CommandMessage(message_id=17, command='config/providers/save', args={'provider_domain': 'spotify', 'values': {'username': 'USERNAME', 'password': 'CLEARTEXT PASSWORD???', 'log_level': 'GLOBAL'}})
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/controllers/webserver.py", line 372, in _run_handler
result = await result
^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/controllers/config.py", line 256, in save_provider_config
config = await self._add_provider_config(provider_domain, values)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/controllers/config.py", line 712, in _add_provider_config
await self.mass.load_provider(config)
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/server.py", line 403, in load_provider
provider = await prov_mod.setup(self, prov_manifest, conf)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/providers/spotify/init.py", line 75, in setup
await prov.handle_setup()
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/providers/spotify/init.py", line 119, in handle_setup
await self.login()
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/providers/spotify/init.py", line 616, in login
raise LoginFailed("Only Spotify Premium accounts are supported")
music_assistant.common.models.errors.LoginFailed: Only Spotify Premium accounts are supported
Additional information
No response
What version of Home Assistant Core are your running
2023.11.2
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
ODROID

What type of Spotify account are you paying for?

It’s a single premium account. Maybe something special about it that I pay it with my phone bill so it payed by my service provider.

Have you tried logging in somewhere else with the device password?

I tried resetting the password again with the page mentioned above. But it threw an unkonw error. So I reset the password and after a few minutes I could login. A little weird and maybe a wrong message from Music Assistant. But now it works. This ticket can be closed.


NGFW-VM HA configure issue

Describe the bug
Trying to configure active-passive HA for NGFW-VM on AWS, but got error "ha1-backup unexpected here"
Expected behavior
The VM series NGFW on AWS is special tailored, according to the admin guide https://docs.paloaltonetworks.com/vm-series/10-0/vm-series-deployment/set-up-the-vm-series-firewall-on-aws/high-availability-for-vm-series-firewall-on-aws/configure-activepassive-ha-on-aws.html
The HA1 port has to be the "management" interface, for the aws routing table requirement, we have to do interface moving HA, can NOT do secondary IP based.
Current behavior
When configure HA with HA1 without backup, it got error "ha1-backup unexpected here"
Possible solution
Since ha1-backup is not configured, the SDK should not try to configure ha1-backup by itself.
Steps to reproduce
The test code:
from panos.firewall import Firewall
from panos.ha import HA1, HA2, HighAvailability

def main():
  fw = Firewall('X.X.X.X', 'admin', '########')
  ha_config = HighAvailability(group_id=1, peer_ip="<IP_ADDRESS>", mode="active-passive", state_sync=True)
  ha1_int = HA1("<IP_ADDRESS>", "<IP_ADDRESS>", "management")
  ha2_int = HA2("<IP_ADDRESS>", "<IP_ADDRESS>", "ethernet1/1")

  fw.add(ha_config).create()
  fw.add(ha1_int).create()
  fw.add(ha2_int).create()

  fw.commit(sync=True, exception=True)

if __name__ == "__main__":
  main()

Screenshots
(.venv) 16:00 % python test.py
Traceback (most recent call last):
  File "/Users/jozhou/src/python/ansible/.venv/lib/python3.9/site-packages/panos/base.py", line 3661, in method
    super_method(self, *args, **kwargs)
  File "/Users/jozhou/src/python/ansible/.venv/lib/python3.9/site-packages/pan/xapi.py", line 741, in set
    self.__type_config('set', query, extra_qs)
  File "/Users/jozhou/src/python/ansible/.venv/lib/python3.9/site-packages/pan/xapi.py", line 805, in __type_config
    raise PanXapiError(self.status_detail)
pan.xapi.PanXapiError:  deviceconfig -> high-availability -> interface -> ha1-backup unexpected here
 deviceconfig -> high-availability -> interface is invalid

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/Users/jozhou/src/python/ansible/panos/test.py", line 17, in <module>
    main()
  File "/Users/jozhou/src/python/ansible/panos/test.py", line 10, in main
    fw.add(ha_config).create()
  File "/Users/jozhou/src/python/ansible/.venv/lib/python3.9/site-packages/panos/base.py", line 645, in create
    device.xapi.set(self.xpath_short(), element, retry_on_peer=self.HA_SYNC)
  File "/Users/jozhou/src/python/ansible/.venv/lib/python3.9/site-packages/panos/base.py", line 3682, in method
    raise the_exception
panos.errors.PanDeviceXapiError:  deviceconfig -> high-availability -> interface -> ha1-backup unexpected here
 deviceconfig -> high-availability -> interface is invalid
(.venv) 16:07 %

Context
NGFW-VM HA pair on AWS same AZ with interface moving of active-passive HA.
Your Environment
NGFW-VM on AWS

Version used: 10.0.6
Environment name and version (e.g. Chrome 59, node.js 5.4, python 3.7.3):
Operating System and version (desktop or mobile):
Link to your project:

Hi Joe,
This looks like a configuration issue. The following code works:
from panos.firewall import Firewall
from panos.ha import HA1, HA2, HighAvailability
from panos.network import EthernetInterface

def main():
    fw = Firewall('<IP_ADDRESS>', 'admin', 'password')
    fw.add(EthernetInterface("ethernet1/1", "ha")).create()

    ha_config = HighAvailability(group_id=1, peer_ip="<IP_ADDRESS>", mode="active-passive", state_sync=True)
    ha1_int = HA1(port="management")
    ha2_int = HA2(ip_address="<IP_ADDRESS>", netmask="<IP_ADDRESS>", port="ethernet1/1")

    fw.add(ha_config)
    ha_config.add(ha1_int)
    ha_config.add(ha2_int)

    ha_config.create()

    fw.commit(sync=True, exception=True)

if __name__ == "__main__":
    main()

The changes here from your code are:

Created ethernet1/1 and set it as to be an 'ha' interface
Remove ip/netmask from HA1 configuration (not needed for management interface)
Add HA1 and HA2 to HighAvailability instance, not to Firewall instance
Issue create() only on the HighAvailability instance (HA interfaces will get created at the same time because they are children of HighAvailability instance)

I hope that helps, let me know if you have further questions.

Was able to reproduce issue, reopening.


Ctrl+Click (CommandNames.DefinitionAndBoundSpan) doesn't return a location TextSpan for triple slash references

The command DefinitionAndBoundSpan doesn't return a TextSpan for triple slash references.
See PR: #19175 for details about ctrl+click implementation.

Found an easy way to add support. Closing the bug.


Correctly populate the externs and nocompile flags for the GWT runner

When using the GWT runner, extern files were no longer properly hoisted when provided as source files. Tests in the npm package distribution were failing because of this.
Fixes #3238

I've imported this PR, added some test cases, and sent it for internal review and testing.


[14.0] ISPN-14957 Allow to get internal cache info using rest

https://issues.redhat.com/browse/ISPN-14957
Backport of #11041

Merged, thanks


Add the ability to carry up to 5 items in an Inventory

The knight/playe rshould be able to pick up nearby objects and drop them. They should be able to carry up to a maximum number of objects, each of which must be less than a maximum weight.
Carried objects have attributes:

Mirror - allows you to see the inventory displayed at the bottom of the screen
Brick - too heavy to carry for anyone except samsun
Glowing Candle - prevents death in dark rooms (mainly little bottle)
Power-Pong Plant - prevents death in the mush-room
Wand - allows you to command characters

relates to #44 #43 #42


test: v20 earlier activation for regtest

Issue being fixed or feature implemented
Currently, on functional tests v20 activates at height 1440 which is later than needed.
What was done?
Reduced the window size of v20 from 480 to 400 which activates v20 at 1200.
Adjusted tests to this change.
Note regarding the window analysis for MN payments in feature_llmq_evo.py (reduced from 256 to 48 blocks):
48 window is enough to analyse 4 MNs and 5 EvoNodes (Weighted count=24)
On my machine using develop:
python3 feature_llmq_rotation.py  145.45s user 30.00s system 68% cpu 4:16.93 total
With this PR:
python3 feature_llmq_rotation.py  119.26s user 24.61s system 62% cpu 3:50.89 total
How Has This Been Tested?
all tests
Breaking Changes
no
Checklist:

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated relevant unit/integration/functional/e2e tests
[ ] I have made corresponding changes to the documentation
[x] I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

I don't understand.... Can you clarify a couple of things pls?

which is later than needed.

needed for what?

On my machine using develop:
python3 feature_llmq_rotation.py 119.26s user 24.61s system 62% cpu 3:50.89 total
With this PR:
python3 feature_llmq_rotation.py 145.45s user 30.00s system 68% cpu 4:16.93 total

so we mine less blocks but it's slower now? how so?

Sorry, the faster time is with this PR and the slower using develop. I mistyped the description. Fixed it

Would need to rebase if #5665  gets merged first.

LGTM but I think I'd prefer #5658 to be merged first


Grafana pre-baked queries reference invalid influxdb datasets

I believe the queries in grafana are wrong:
These are the measurements shown by "SHOW MEASUREMENTS" against influxdb:
name
cpu/node_reservation
cpu/node_utilization
cpu/usage
cpu/usage_rate
filesystem/limit
filesystem/usage
log/events
memory/major_page_faults
memory/node_reservation
memory/node_utilization
memory/page_faults
memory/usage
memory/working_set
network/rx
network/rx_errors
network/tx
network/tx_errors
uptime

Did we change the names of the statistics that were collected? All the grafana queries are things like select hostname, mean(value) from "memory/limit_bytes_gauge" where $timeFilter and container_name = 'machine' group by time($interval), hostname order asc but memory/limit_bytes_gauge is not defined
cf https://github.com/kubernetes/kubernetes/issues/21692#issuecomment-188471149

cf kubernetes/kubernetes#487 same issue...

Fixed

Thank you!

@fgrzadkowski  how do I build only heapster to test on my deployed  alpha 1.2 cluster?

We have release new version that should include this fix v0.20.0-alpha9.

great thank you so much

@fgrzadkowski sorry but I don't see that in the releases for kubernetes
you mean a release on heapster ?
if so how do I add it to the alpha8 deployed cluster / or how do i redeploy with the new release?

I meant heapster release. If you want to update this manually you should update RC definition for heapster on master in /etc/kubernetes/addons/cluster-monitoring or you can update 'cluster/addons/cluster-monitoring/...` and redeploy your cluster.

thanks for the explanation - i really appreciate your help

@innovia @fgrzadkowski
A tiny correction - grafana + influxdb is in a separate docker image. New version is here gcr.io/google_containers/heapster_grafana:v2.6.0-2.

I updated our 1.2alpha8 cluster to use heapster v0.20.0-alpha9 and heapster_grafana:v2.6.0-2.
It's looking great now - thanks!

It looks like there is a similar issue in 1.1.7 and 1.1.8. Is there is a patch for that release?

You will have to port the config files manually. Heapster and grafana should work on the older cluster as well. BTW, please pay attention to new mini-releases of Heapster - 0.20.0 (a big rewrite/refactoring) is still in alpha stage and we are pushing new version with bugfixes every other day. Today we pushed alpha10.

@fgrzadkowski  i've deleted my running rc's for garafana and heapster and re-ran  the create on them and it's working great! thank you so much for the fix


Styles of ScreenshotExample are broken

Description
When navigating to ScreenshotExample the user can't see anything except a blank screen.
Styles of this example are broken

Can you supply a video/screenshot that highlights the problem?

Sure!
This is how it looks currently:

Ah it's also broken for iOS in RN Core (for dark appearance). So this PR should be contributed to Core

https://github.com/facebook/react-native/pull/41222


Feature request. Make restart last session when opening optional.

Hi there,
Thank you for this plugin. It is by far the best project manager for Neovim that I've tested so far, and it actually works :)
Your first feature is "Start where you left off last time." That's great, but I was wondering if this could be optional. I'm using mini.starter when I open Neovim without a path parameter, and I'd love to use both plugins together. I didn't see any parameter in the config documentation.
Thank you in advance.

Done. Now you can add last_session_on_startup = false, to your config

Thank you :)


"HueClient is not initialized. First call RegisterAsync or Initialize." when calling api/config

How can we get basic Bridge information without registering to the Bridge? The API does support it:
http://IP/api/config
returns parts of the Bridge config (like Bridge ID, api version etc.). This is useful if you want to show more to the user when connecting to Bridges.

HueClient Client = new LocalHueClient(B.LocalIP);
Bridge x = await Client.GetBridgeAsync();

doesn't work. The above error returns.

This is possible since version 3.5.2.
See issue: https://github.com/Q42/Q42.HueApi/issues/126
You should use GetConfigAsync


intergrate WLR_LIBINPUT_NO_DEVICES=1 in NixOS configuration file

Hi, im using cage lately on my raspberrypi4b and it works like a charm, starts automatically after booting and displays firefox with the url set, until i realised without a connected keyboard or mouse it results in a black screen as described in
https://github.com/cage-kiosk/cage/wiki/Troubleshooting#cage-does-not-start-without-any-input-devices
...im having difficulties integrating WLR_LIBINPUT_NO_DEVICES=1 to my setup, would anyone be so kind and help me out on how to do this?
my current configuration looks like this;
...
environment.systemPackages = with pkgs; [ cage (...) firefox ];
services.cage = {
enable = true;
user = "user1";
program = "${pkgs.firefox}/bin/firefox -kiosk -private-window https://github.com";
};
thanks in advance for your help!

Please ask this question in a NixOS support channel.


Change icons for header buttons in layer tab

figma file
https://www.figma.com/file/xPemdxTmvPi2homUZ2dyw0/UNDP-GeoHub-UI?node-id=2467%3A439&mode=dev
┆Issue is synchronized with this Wrike task by Unito


Ensure prTester does not block built-in node

pipelines/build/prTester/kick_off_tester.groovy was unnecessarily blocking the built-in node for the whole of the pr pipeline builds, which unfortunately now with the GPG signing on the built-in node causes a deadlock.
I have re-worked the node() context to only where it is needed, just like the standard build pipelines.
Signed-off-by: Andrew Leonard<EMAIL_ADDRESS>

run tests

run tests

run tests

run tests

run tests

@andrew-m-leonard Looks like the pipeline check failed, something about the 17 pipeline trying to load 18 script AFAICT from Blue ocean.

run tests

@andrew-m-leonard Looks like the pipeline check failed, something about the 17 pipeline trying to load 18 script AFAICT from Blue ocean.

I think that may have just been a glitch, i'm re-runnning it


The page information displayed incorrectly when search subscription

Date: 2016/06/02
[Test category]: creative Test
Severity：Minor
[Steps to reproduce]

Login in marketplace as customer;
Subscribe to service for more than 10 times and assign the customer to these subscriptions;
Click on "ACCOUNT->Subscriptions";
Input a space into the search box, then click on the search button;
Click on "MY SUBSCRIPTIONS";
Input a space into the search box, then click on the search button.

[Expected result]
In step 4 and step 6, no subscriptions should be displayed in the screen, and the information of pages should not be displayed.
[Observed result]
In step 4 and step 6, no subscriptions was displayed in the screen, but the information of pages was displayed.

This issue will be not reproducable after resolving issue #127. (Search by 'space' will show all the subscriptions). I checked described case with non-existent text, and it also works as it should.

Issue #127 is closed so I'm closing this one too.

Verified by FNST
[verified-version] V16.0 fix6
[verified-details]The issue cannot be reproduced, so verified.


session-desktop: 1.12.5 -> 1.13.2

Description of changes
Update version
https://github.com/oxen-io/session-desktop/releases/tag/v1.13.2

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hi, you'll have to add yourself to the main maintainer list in a separate commit first for this to work.
See other merged first-timer PRs for examples: https://github.com/NixOS/nixpkgs/issues?q=label%3A"12.+first-time+contribution"+is%3Amerged+

Oh gosh I pressed the wrong button


Remove bad color configs that cause errors

Fixes #18

Closing this PR, as the fix was committed in eb5fc42


⚠ Turnos 24x7 has degraded performance

In e7bd393, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 896 ms

Resolved: Turnos 24x7 performance has improved in fce5567.


Downloading non-stable Chrome driver causing errors

Starting today, my mint-api runs have downloaded chrome driver version 93 when the current, stable version is 92. This causes the scripts to fail because of a version mismatch.
I've tried

manually downloading 92 driver but mint-api just overwrites it with 93 again
installing the chrome beta (v93) but I hit the same issue because chrome stable is still installed

Anyone else experiencing this? I'm running Ubuntu 20.04 and I have a cron job running the mint scripts hourly. I've had hourly runs going to about 6 months without many hiccups. Just today this issue started appearing. Just updated to the newest mint-api via pip today while troubleshooting.

I use Amazon Lightsail, ubuntu 20 as well.
I used this tutorial https://tecadmin.net/install-google-chrome-on-ubuntu-20-04/
For some reason, it works only when I disable the two-step-verification

This is a bug with the logic to get the chromedriver downloaded. As a workaround, download the correct one and set use_chromedriver_on_path=True (and then make sure it is in the path somehow).

Hmm... I take it back. I don't think it's that it's downloading an unstable chromedriver, it's just that your machine hasn't updated to the most recent chrome version yet. Does this problem persist? It might be better to detect the chrome version of what is in your path and then download that version rather than just get the latest. Let me know if you continue to see this issue and perhaps we can investigate this solution.

@jaron-l this is no longer an issue, at least for me.


Don't assume 'window.unwrap'

Fixes #284

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable


Folder index replace in reverse order

This issue might be an extension of  #31 or a bug of the current code.
I needed to rename folders using {{index}}, and I don't know if the current code has a bug because it incorrectly sorts the folders in descending order instead of ascending order (which is the correct order). This only happens in renaming folders, but it works fine when renaming files.
I'm using this command:
renamer --replace '{{index}}' *
When renaming (text) files, it correctly produce:
IMG_5776.txt -> 1
IMG_5777.txt -> 2
IMG_5778.txt -> 3
But with folders it happens the following:
IMG_5778 -> 1
IMG_5777 -> 2
IMG_5776 -> 3
To fix temporarily my issue to rename folders correctly I changed this line (https://github.com/75lb/renamer/blob/master/lib/renamer.js#L59):
results.list = options.files.map(replaceSingle.bind(null, findRegex, options.replace))
to
results.list = options.files.reverse().map(replaceSingle.bind(null, findRegex, options.replace))
But this would obviously brake the functionality of files renaming using index. @75lb Would be nice is this issue would be address. Thanks

Reproduced, looking into this.

Is this still an issue in renamer v1?

fixed and released in renamer v1.0.0.


Gpu-enabled cpu runs are slow

If I build mnist.cu.cpp with -DGINN_ENABLE_GPU=0 and run, single epoch takes ~3.5s. If I build it with -DGINN_ENABLE_GPU=1 and run using the same docker instance (no gpu, falling back to cpu), single epoch takes ~30s.
Could be:

Optimizer flags are not properly set / sufficient

Although, I verified with verbose build that pxtas and compiler options are set to at least O3, is there anything else missing?

nvcc is doing a poor job somehow

Maybe test using cuda > 11.1

Adding missing -march=native -mtune=native into Gpu flags reduced it to ~24s. Adding linkage to Threads reduced it to slightly under 24s but it might not be significant.
Other things I tried:

Ensure same host compiler used for both
Ensure same optimization flags used for both (switched from 03 to 0fast for host side in Gpu)


Cyclic reference and ShouldBeEquivalentTo - is this a valid solution?

Hi,
I want to deep-test two objects for equivalency, but they contain cycles so the library halts with "but it contains a cyclic reference.". I know it is possible to ignore those properties, but I want them tested.
The solution I have found is:

EquivalencyValidator: remove the line
  if (!current.Get<ObjectTracker>("objects").IsCyclicReference(new ObjectReference(context.Subject, context.PropertyPath)))

Create a new IAssertionRule class, and use it (surely this can use some refactoring / improvements):
  private class MyAssertionRule : IAssertionRule
  {

      private List<Tuple<object, object>> _list = new List<Tuple<object, object>>();

      public bool AssertEquality(IEquivalencyValidationContext context)
      {
          var exists = _list.Any(x => object.ReferenceEquals(x.Item1, context.Subject) && object.ReferenceEquals(x.Item2, context.Expectation));
          if (exists)
          {
              return true;
          }
          else
          {
              _list.Add(new Tuple<object, object>(context.Subject, context.Expectation));
              return false;
          }
      }

  }

The reasoning is:

The assertion rule is called for each pair of matching properties.

By removing the "if" line, I don't fail on cycles but I don't ignore them either. Note that by doing so without adding the new rule you will certainly hit the maximum depth limit.

In my rule, if it's the first time I see a given pair of values, then I cannot conclude if they match, so I return false, but I note down that they appeared before together.

If those values are indeed not equivalent, then the process will eventually stop with an error, so it finally won't matter that I noted them down.

If those values are found equivalent by another rule or by finishing the deep inspection, then they were indeed a match, and I have that match on my list, which connects with the following point.

If I have seen this pair of values already, then I can return true, because either they were compared before and they were found to be equivalent - or - this specific pair of objects is being compared right now and this property specifies "the same cycle" in both objects.

An important point is that any given pair of objects will be thoroughly tested once (because the first time I see them I return false).

Am I missing something here? If not, could this be a universal way of dealing with cycles - maybe applied by default?
Thanks and regards,
Fernando

@vossad01 This is still ongoing work, isn't it?

@dennisdoomen I did not have any plans to do anything regarding this item.  If you are thinking of the deprecation of IAssertionRule, I did complete that a while back did not send a PR because I was not sure you would want another deprecation in v3.3, and with Issue 22 behind me now so is my motivation for deprecating the interface.
Skimming back through this, I really do not see this replacing ShouldBeEquivalentTo's behavior and I am not perceiving the value in spending time writing.  If someone valued this enough to submit a thought out PR providing an option for something like this which justifies what the functionality is needed for, there may be value in integrating it but I do not see the case for either of us to write it.
I do find my idea here about moving the Cyclic Reference detection into an IEquivalencyStep intriguing.  A quick look at the code makes me think it should be possible. That would add some more uniformity to the implementation of Equivalence and allow users greater extensibility, including removing the issue the OP faced with needing to modify Equivalency Validator.  However, if that is worth pursing it probably would make sense to create a new issue to track that.

Sorry, but not going to get any priority anytime soon.


⚠ Jenkins Plugins Artifactory has degraded performance

In 3b8e2c3, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1236 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 1f7ec6c after 25 minutes.


Merge together the indigo, jade, and kinetic branches

Maintaining three different branches for different ROS distributions is a pain and also unnecessary, so I've merged all of them together.  This branch builds and all tests pass on indigo, jade, kinetic, and lunar.  Don't look too hard at that commit list, it's ugly.
This PR targets the indigo-devel branch, but after it is merged, we should rename that branch to master, lock down all of the distro-specific branches, and then release a new version (0.3.0) to all distros.
Not very much needed to be changed to make everything compatible, but some notable things are:

Packages that use OpenCV (swri_geometry_util, swri_image_util, swri_opencv_util, and swri_transform_util) have a rosdep on cv_bridge and don't specify a version when calling find_package in their CMakeLists.txt; this means they'll use OpenCV 2 on Indigo and Jade and OpenCV 3 on Kinetic and Lunar.
swri_image_util depends on Qt 5.
Nodes and utilities in swri_transform_util previously used the gps_common/GPSFix message on Indigo and sensor_msgs/NavSatFix (or Pose, or GeoPose, or whatever else was appropriate) on Jade and later.  Now they will all handle all of them.  This is a little ugly in initialize_origin.py because it was basically completely rewritten for NavSatFix support.  The right thing to do would be to rewrite it again to handle every case gracefully, but that's a bit beyond the scope of this PR, so instead it just detects whether your ${ROS_DISTRO} is "indigo" or not and changes behavior appropriately.

I recommend we soak test this in SwRI-owned vehicles for a while before merging. A major change to marti_common affects a lot of projects. We should also verify that the kinetic packages still work as expected. I'm not aware of any projects using Jade, so I'm not too concerned about that.

I found one hitch on Indigo; Mapviz uses swri_image_util, which means that if swri_image_util is switched to Qt 5, Mapviz would need to use Qt 5, and anything that provides a plugin for Mapviz would also need to switch.  In addition, anything that links in OpenCV's highgui module would also require Qt 4.
It's easy to make swri_image_util switch which version of Qt  it links it, but because there's no way in package.xml to make dependencies conditional, that means a cross-distro compatible version has to say it depends on both Qt 4 and 5.  It doesn't hurt anything, but it does mean you'd end up installing a version of Qt you don't need.

Easier solution: remove Qt entirely.  swri_image_util was only using its QPolygonF class to find the intersection of two polygons, but swri_geometry_util can do that even more easily, so Qt is entirely unnecessary in marti_common.  All unit tests pass.

I'm going to set a target to get the necessary tests in on this next week, with the goal to merge by June 2.

What tests are needed? I would love to get this merged as soon as possible.

This totally got pushed off my plate. Sorry about that. @pjreed tested it in Kinetic. I don't care about Jade, but it needs to be tested for Indigo. I'd hate to see a major government client 😉 have problems.

Tested on vehicle, there seems to be an issue with initialize_origin.py in swri_transform_util. When it gets to line 118 it complains that global name '_gps_fix' is not defined.

Ok, @nick-alton, try it again now.


Thanks!

I just wanted to say thank you for this tiny library!
It saves me a lot of time 😊
Here is an example, how I use it in my library

The project is cool!
A suggestion: you can create "an arrow being drawn" with this library by setting the end box's width and height to zero.
https://user-images.githubusercontent.com/25148955/147905833-d08a9968-222b-4d82-8035-f08d937bd753.mp4

The project is cool!
A suggestion: you can create "an arrow being drawn" with this library by setting the end box's width and height to zero.
kazam_screencast_00000.mp4

Unfortunately, something with a video that you've sent, can see nothing(

It's a video showing me dragging an arrow from a block in this canvas.

Ohh now I can watch your video, it was something with my phone.
Yeah, really good idea 🚀


Add East Lansing, MI

To<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: [*** INSERT UNIQUE SUBJECT LINE***]
Message (Don't forget to replace the [x]'s with your information!)
Hello,
My name is [YOUR NAME] and I am a resident of East Lansing. I am writing to demand that funding is reallocated from the ELPD to social and public programs in our community. It is an outrage that 65% of city funding goes towards the Police Department while public works and cultural investment is less than 10% of the city budget. The ELPD has seen a number of high profile abuse and violence claims recently and the budget should reflect that poor performance.
We demand that the City Council defund the East Lansing Police Department. We join the calls of those across the country to defund the police. We demand a budget that adequately and effectively meets the needs of at-risk East Lansing residents during this trying and uncertain time, when livelihoods are on the line. We demand a budget that supports community wellbeing, rather than empowers police.
It is your duty to represent your constituents. I am urging you to completely revise the proposed East Lansing city budget for FY2021. Public opinion is with me.
Thank you for your time,
[YOUR NAME] [YOUR ADDRESS] [YOUR EMAIL] [YOUR PHONE NUMBER]

To<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: [*** INSERT UNIQUE SUBJECT LINE***]
Message (Don't forget to replace the [x]'s with your information!)
Hello,
My name is [YOUR NAME] and I am a resident of East Lansing. I am writing to demand that funding is reallocated from the ELPD to social and public programs in our community. It is an outrage that 32% of city funding goes towards the Police Department while public works and cultural investment is less than 10% of the city budget. The ELPD has seen a number of high profile abuse and violence claims recently and the budget should reflect that poor performance.
We demand that the City Council defund the East Lansing Police Department. We join the calls of those across the country to defund the police. We demand a budget that adequately and effectively meets the needs of at-risk East Lansing residents during this trying and uncertain time, when livelihoods are on the line. We demand a budget that supports community wellbeing, rather than empowers police.
It is your duty to represent your constituents. I am urging you to completely revise the proposed East Lansing city budget for FY2021. Public opinion is with me.
Thank you for your time,
[YOUR NAME] [YOUR ADDRESS] [YOUR EMAIL] [YOUR PHONE NUMBER]

on it now


Created use cases directory and attempted to add the contents of USAG…

…E.md

Fixes
Fixes 119
Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added in line documentation to the code I modified

Short description of what this PR does:

Creates directory
Creates README.md
Adds content based on USAGE.md (USE_CASES.md does not exist)

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Boto sometimes crashing with ConnectionError when listing S3 directory

I'm getting a crash with a ConnectionError error while using moto in conjunction with s3fs. Weird thing is, it's flaky. The exact same tests only fail around 1/3 of the time, and I'm not sure why. This is being tested on pytest using tox. The test order is randomized on every run so that might be why it's flaky, but that still doesn't tell me what's triggering the error.
Platform:

Python: 2.7.14
OS: OSX 10.13.4 (High Sierra)

Package versions:
boto3==1.7.8
botocore==1.10.8
moto==1.3.3
pytest==3.0.7
pytest-randomly==1.2.3
s3fs==0.1.4
tox==3.0.0

When it fails, I get the following crash:
tests/[redacted].py:218: in test_sweep__all_files_match
    [redacted]
[redacted].py:142: in sweep_processed_files_from_s3
    for path in s3.walk(processed_root)
.tox/py27/lib/python2.7/site-packages/s3fs/core.py:561: in walk
    return [f['Key'] for f in self._walk(path, refresh)]
.tox/py27/lib/python2.7/site-packages/s3fs/core.py:552: in _walk
    filenames = self._ls(path, refresh=refresh)[:]
.tox/py27/lib/python2.7/site-packages/s3fs/core.py:368: in _ls
    return self._lsdir(path, refresh)
.tox/py27/lib/python2.7/site-packages/s3fs/core.py:314: in _lsdir
    for i in it:
.tox/py27/lib/python2.7/site-packages/botocore/paginate.py:255: in __iter__
    response = self._make_request(current_kwargs)
.tox/py27/lib/python2.7/site-packages/botocore/paginate.py:332: in _make_request
    return self._method(**current_kwargs)
.tox/py27/lib/python2.7/site-packages/botocore/client.py:314: in _api_call
    return self._make_api_call(operation_name, kwargs)
.tox/py27/lib/python2.7/site-packages/botocore/client.py:599: in _make_api_call
    operation_model, request_dict)
.tox/py27/lib/python2.7/site-packages/botocore/endpoint.py:148: in make_request
    return self._send_request(request_dict, operation_model)
.tox/py27/lib/python2.7/site-packages/botocore/endpoint.py:177: in _send_request
    success_response, exception):
.tox/py27/lib/python2.7/site-packages/botocore/endpoint.py:273: in _needs_retry
    caught_exception=caught_exception, request_dict=request_dict)
.tox/py27/lib/python2.7/site-packages/botocore/hooks.py:227: in emit
    return self._emit(event_name, kwargs)
.tox/py27/lib/python2.7/site-packages/botocore/hooks.py:210: in _emit
    response = handler(**kwargs)
.tox/py27/lib/python2.7/site-packages/botocore/retryhandler.py:183: in __call__
    if self._checker(attempts, response, caught_exception):
.tox/py27/lib/python2.7/site-packages/botocore/retryhandler.py:251: in __call__
    caught_exception)
.tox/py27/lib/python2.7/site-packages/botocore/retryhandler.py:269: in _should_retry
    return self._checker(attempt_number, response, caught_exception)
.tox/py27/lib/python2.7/site-packages/botocore/retryhandler.py:317: in __call__
    caught_exception)
.tox/py27/lib/python2.7/site-packages/botocore/retryhandler.py:223: in __call__
    attempt_number, caught_exception)
.tox/py27/lib/python2.7/site-packages/botocore/retryhandler.py:359: in _check_caught_exception
    raise caught_exception
E   ConnectionError: Connection refused: GET https://(BUCKET_NAME).s3.us-west-2.amazonaws.com/?list-type=2&prefix=(REDACTED)

The code that crashes:
# The Pytest fixture being used
@pytest.fixture(autouse=True)
def s3():
    """Mock S3 and generate all of the S3 directories needed for the tests."""
    with moto.mock_s3():
        fs = s3fs.S3FileSystem()

        fs.mkdir(...)
        # more mkdirs here
        yield fs

# inside the code being tested
for path in s3.walk('bucket/directory_key'):    # <-- boom
    # stuff

I suspect this might be related https://github.com/spulec/moto/issues/1026 but it's listed as being resolved. There's a chance it might be related to https://github.com/spulec/moto/issues/1540 but that looks like the user was querying a non-Amazon site, and this is a query by botocore to amazonaws.com.
Any ideas?

I'm on Linux and tesing with Nose and I get the same error
    return self.client.list_objects(Bucket=bucket_name)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/client.py", line 314, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/client.py", line 599, in _make_api_call
    operation_model, request_dict)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/endpoint.py", line 148, in make_request
    return self._send_request(request_dict, operation_model)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/endpoint.py", line 177, in _send_request
    success_response, exception):
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/endpoint.py", line 273, in _needs_retry
    caught_exception=caught_exception, request_dict=request_dict)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/hooks.py", line 227, in emit
    return self._emit(event_name, kwargs)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/hooks.py", line 210, in _emit
    response = handler(**kwargs)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/retryhandler.py", line 183, in __call__
    if self._checker(attempts, response, caught_exception):
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/retryhandler.py", line 251, in __call__
    caught_exception)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/retryhandler.py", line 269, in _should_retry
    return self._checker(attempt_number, response, caught_exception)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/retryhandler.py", line 317, in __call__
    caught_exception)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/retryhandler.py", line 223, in __call__
    attempt_number, caught_exception)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/retryhandler.py", line 359, in _check_caught_exception
    raise caught_exception
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/endpoint.py", line 222, in _get_response
    proxies=self.proxies, timeout=self.timeout)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/botocore/vendored/requests/sessions.py", line 573, in send
    r = adapter.send(request, **kwargs)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/responses.py", line 572, in unbound_on_send
    return self._on_request(adapter, request, *a, **kwargs)
  File "/home/matteo/.virtualenvs/deepmanager/lib/python3.5/site-packages/responses.py", line 543, in _on_request

This looks like a different error. Your crash is in responses. If you add something like responses.add_passthru('https://goodrx-data.s3.amazonaws.com/') I think that'll fix your bug.

Can you try running against the master of Moto? I'm not able to recreate this.

Sorry for the delay. I just tried it again and it's still failing, albeit much less frequently. Installation's changed a bit:
boto==2.48.0
boto3==1.7.4
botocore==1.10.4
moto==1.3.3
pytest==3.5.1
pytest-mock==1.10.0
pytest-randomly==1.2.3
s3fs==0.1.5
tox==3.0.0

I installed moto as pip install 'git+https://github.com/spulec/moto.git@38a4558'.

For me this broke when upgrading pytest from 3.5.1 to 3.7.1, using moto 1.3.5.

Considering the age of this issue, I'm going to close it - it doesn't look like this is still a problem.
If somebody encounter this problem again with the latest version of Moto, feel free to open a new issue with a reproducible test case.


Linting plugin stopped working in 2.0.0-canary.0

Verify canary release

[X] I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue
n/a
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Mac
Which canary version will you have in your reproduction?
2.0.0-canary.0
Describe the Bug
Upgrading eslint-plugin-turbo breaks/ stops the turbo lifting for functioning:
TypeError: Failed to load plugin 'turbo' declared in '--config » /Users/weyert/Development/Projects/company/company-monorepo/configs/eslint-config/turbo.js': Cannot convert undefined or null to object
    at Function.entries (<anonymous>)
    at Ii.generateKey (/Users/weyert/Development/Projects/company/company-monorepo/node_modules/.pnpm/eslint-plugin-turbo@2.0.0-canary.0_eslint@8.57.0/node_modules/eslint-plugin-turbo/dist/index.js:74:6559)
    at new Ii (/Users/weyert/Development/Projects/company/company-monorepo/node_modules/.pnpm/eslint-plugin-turbo@2.0.0-canary.0_eslint@8.57.0/node_modules/eslint-plugin-turbo/dist/index.js:74:6200)
    at Object.<anonymous> (/Users/weyert/Development/Projects/company/company-monorepo/node_modules/.pnpm/eslint-plugin-turbo@2.0.0-canary.0_eslint@8.57.0/node_modules/eslint-plugin-turbo/dist/index.js:74:10209)
    at Module._compile (node:internal/modules/cjs/loader:1369:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1427:10)
    at Module.load (node:internal/modules/cjs/loader:1206:32)
    at Module._load (node:internal/modules/cjs/loader:1022:12)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:179:18)

Expected Behavior
Able to use the turbo listing rules
To Reproduce
Upgrade to Turbo v2 canary build and try to run the linting rules
Additional context
Appears that code is still referring to pipeline instead of tasks when reading the turbo config file

Looks like @chris-olszewski is ahead of it in #8253

Appears to fixed in the latest canary build

That sounds similar to the error message I fixed in this PR: https://github.com/vercel/turbo/pull/8405
To be specific, renaming eslint-config-turbo to turbo in the ESLint configuration resolves that error.

Still present, same error message


Way to close open menus when opening another one

I have 2 components using React Menu and when I open one and then the other, they both are open and I'd like to have the ability to close the unfocused menu when I open the other.
If that is built in with the blur event, it doesn't seem to be working.

Agreed, see: https://github.com/instructure-react/react-menu/issues/6


Fix bug in relative time display "53 years ago..."

In the tooltip, looks like we have something up with the timestamp handling:

Closing this out as no longer relevant for now. The tooltips are not currently used, and if we return to using them, will likely be a new implementation.


Return None in BaseEstimator._set_preprocessing for None input

Signed-off-by: Beat Buesser<EMAIL_ADDRESS>Description
This pull request changes BaseEstimator to preserve preprocessing=None.
Fixes #915
Type of change
Please check all relevant options.

[ ] Improvement (non-breaking)
[x] Bug fix (non-breaking)
[ ] New feature (non-breaking)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Codecov Report

Merging #916 (22c9a1d) into dev_1.5.3 (27e4cad) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           dev_1.5.3     #916      +/-   ##
=============================================
- Coverage      65.16%   65.15%   -0.01%
=============================================
  Files            201      201
  Lines          17875    17893      +18
  Branches        3275     3303      +28
=============================================
+ Hits           11648    11658      +10
- Misses          4933     4942       +9
+ Partials        1294     1293       -1

Impacted Files
Coverage Δ

art/estimators/estimator.py
68.51% <0.00%> (+0.31%)
:arrow_up:

art/defences/detector/poison/activation_defence.py
84.61% <0.00%> (-1.01%)
:arrow_down:

art/estimators/classification/keras.py
74.48% <0.00%> (-0.60%)
:arrow_down:

...ion/imperceptible_asr/imperceptible_asr_pytorch.py
7.23% <0.00%> (-0.11%)
:arrow_down:

art/attacks/evasion/brendel_bethge.py
57.24% <0.00%> (+1.03%)
:arrow_up:


Documentation for the parsing of a JQuery selector of an input

Hi,
I don't see any documentation for the parsing of a JQuery selector for an input. I was surprised it worked while the parsing of an element (retrieved by getElementById) returns an invalid date.
Did I missed it or should a sub-(sub)section be added in the documention ?
Thanks.

I don't think moment has any jQuery-aware code in it.
Can you share example code?

For example I have a hidden input <input type="hidden"  id="DateLimite" value="08/01/2019" tabindex="2" date-format="DD/MM/YYYY">
And moment($('#DateLimite')).format() returns a date.

Wait, I'm feeling dumb.
It returns the current date and not the date in my input. It does't work either with JQuery.
I'm closing the issue !


chore: store last n headers and add more tx verification

Codecov Report

Merging #62 (aeb617d) into develop (9100ad3) will increase coverage by 0.76%.
The diff coverage is 51.61%.

@@             Coverage Diff             @@
##           develop      #62      +/-   ##
===========================================
+ Coverage    34.20%   34.96%   +0.76%
===========================================
  Files           22       22
  Lines         3362     3406      +44
  Branches       473      471       -2
===========================================
+ Hits          1150     1191      +41
- Misses        2093     2095       +2
- Partials       119      120       +1

Flag
Coverage Δ

unittests
34.96% <51.61%> (+0.76%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/subcmds.rs
0.00% <0.00%> (ø)

src/service.rs
53.61% <16.66%> (ø)

src/protocols/light_client/peers.rs
43.78% <33.33%> (+1.32%)
:arrow_up:

src/storage.rs
87.25% <62.50%> (+1.17%)
:arrow_up:

src/verify.rs
53.19% <82.35%> (+7.21%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Improve russian translation

Editing translation for improve-readability-with-high-contrast-text.russian.md

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

This PR was closed and then re-opened in an attempt to clear a specific Travis build failure.


Bugfix/reject

Summary
Change _error, the member variable  of Promise, in reject funcion. Otherwise, app will crash in function observe(fulfill: PromiseFulfill?, reject: PromiseReject?) after reject a promise
Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.

Thanks for contributing to coobjc!

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 5 committers have signed the CLA.:white_check_mark: iiiCeBlink:white_check_mark: jieliangma:white_check_mark: ValiantCat:x: pengyutang125:x: 念纪念纪 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Bubble sort implementation in Elvish

[lang: elvish]

Hi, I'm sorry, but we don't accept sorting algorithms PRs right now.
I'd love to see Elvish code in the AAA, so feel free to reopen this PR once we reaccept sorting algorithms.


How can I integrated rush with 'lint-staged' package?

Since there is no package.json file in the root folder. I have to install the 'lint-staged' package into all the projects.

I'm just starting with Rush, but for lint-staged I followed the steps in https://rushjs.io/pages/maintainer/enabling_prettier/ i.e. creating an autoinstaller called lint-staged but inside it, I installed lint-staged and everything it needs (like eslint). I defined the command rush lint-staged. The same guide shows how to create a precommit hook, so there I just call lint-staged.
my precommit hook:
node common/scripts/install-run-rush.js lint-staged || exit $?

I'm just starting with Rush, but for lint-staged I followed the steps in https://rushjs.io/pages/maintainer/enabling_prettier/ i.e. creating an autoinstaller called lint-staged but inside it, I installed lint-staged and everything it needs (like eslint). I defined the command rush lint-staged. The same guide shows how to create a precommit hook, so there I just call lint-staged.
my precommit hook:
node common/scripts/install-run-rush.js lint-staged || exit $?

Have you changed the package.json file in sub-projects?

Not for lint-staged, but right now I'm moving the .eslintrc.js to the root of each project since it seems it's the recommended approach.
Just followed the instructions. I used the name rush-husky cause I though I would need husky:
rush init-autoinstaller --name rush-husky
and then my package.json
{
  "name": "rush-husky",
  "version": "1.0.0",
  "private": true,
  "dependencies": {
    "@typescript-eslint/eslint-plugin": "^3.10.1",
    "@typescript-eslint/parser": "^3.10.1",
    "eslint": "~7.7.0",
    "eslint-config-prettier": "^6.11.0",
    "eslint-plugin-prettier": "^3.1.4",
    "eslint-plugin-react": "^7.20.6",
    "lint-staged": "^10.2.13",
    "prettier": "~2.1.0",
    "stylelint": "~13.6.1",
    "stylelint-config-prettier": "^8.0.1",
    "stylelint-config-recommended": "^3.0.0",
    "stylelint-scss": "3.18.0",
    "typescript": "~4.0.2"
  }
}

In common/config/rush/command-line.json
    {
      "name": "lint-staged",
      "commandKind": "global",
      "summary": "Used by the pre-commit Git hook. This command invokes lint-staged to reformat staged changes.",

      "autoinstallerName": "rush-husky",

      "shellCommand": "lint-staged"
    },

In common/git-hooks/pre-commit
#!/bin/sh
# Called by "git commit" with no arguments.  The hook should
# exit with non-zero status after issuing an appropriate message if
# it wants to stop the commit.

# Invoke the "rush lint-staged" custom command to reformat files whenever they
# are committed. The command is defined in common/config/rush/command-line.json
# and uses the "rush-prettier" autoinstaller.
node common/scripts/install-run-rush.js lint-staged || exit $?

And my .lintstagedrc at the root of the Rush repo
{
  "*.{ts,tsx}": "eslint --cache --fix",
  "*.{css,scss}": "stylelint --fix",
  "*.{ts,tsx,css,scss,md}": "prettier --write"
}

package.json is in the root folder of your project or sub-project? It seems that there is no package.json in root folder of rush repo

The package.json I mentioned is in common/autoinstallers/rush-husky/.
rush-husky is the name I chose for my autoinstaller.

@fedemp did you get it to work with vscode-eslint extension?

I recommend read this article:
Build a scalable front-end with Rush monorepo and React — Part 3 | by Alexandru Bereghici | ITNEXT
each project has its lint-staged.only prettier/commitlint in the root.

We recommend not to use Husky with Rush, because it modifies the Git configuration for your working directory (to look for hooks in .husky instead of the standard .git/hooks folder). This modification is sticky, for example it will persist even if you checkout a different branch that is not using Husky, which can result in unintended effects.
Rush already has its own built-in feature for installing Git hooks, documented here: https://rushjs.io/pages/maintainer/git_hooks/

Since there is no package.json file in the root folder. I have to install the 'lint-staged' package into all the projects.

It is okay to use lint-staged in a Rush repo if your commit hook needs to do more than simply invoking Prettier.  (We don't apply ESLint via a Git hook, see this note for details, so we chose the simpler pretty-quick package. But lint-staged is okay, too.)
It is not necessary to add lint-staged as a dependency of every project. Instead, the recommended practice would be to create an autoinstaller folder with the package.json dependencies needed for lint-staged, similar to how Prettier is configured in that article.

@octogonz I still don't know how to use git commitlint in a rushjs project...Can you give me some suggestions?Thanks.


⚠ Jenkins Plugins Artifactory has degraded performance

In 460fbf0, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1139 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 7c90692 after 25 minutes.


Fix grammar errors

I was going through the docs and noticed a few typos so I created this PR.

#sign-off

@nidafarooqui - thanks for the typo fixes!


error with last chance v7 mod

Describe your bug here.
first I can't open the Last-Chance-V7 song from the Last-Chance-V7 non pixel mod and second when I try to download it from the same modloader it never downloads
Steps to reproduce this bug.
first for what I complained they have to download from the Last-Chance-V7 and then try to open any of the 2 songs and with my second complaint they have to try to download it from the integrated modloader
Command Prompt/Terminal logs
Missing file: assets/data/last_chance_v7/last_chance_v7-666.json

Called from backend.Song.loadRawSong (backend/Song.hx line 122)
Called from states.PlayState.create (states/PlayState.hx line 566)
Called from states.PlayState.create (states/PlayState.hx line 1155)
Called from flixel.addons.util.FlxAsyncLoop.update (flixel/addons/util/FlxAsyncLoop.hx line 54)
Called from flixel.group.FlxTypedGroup.update (flixel/group/FlxGroup.hx line 151)
Called from flixel.group.FlxTypedGroup.update (flixel/group/FlxGroup.hx line 151)
Called from flixel.addons.ui.FlxUIState.update (flixel/addons/ui/FlxUIState.hx line 212)
Called from backend.MusicBeatState.update (backend/MusicBeatState.hx line 45)
Called from states.PlayState.update (states/PlayState.hx line 2358)
Called from flixel.FlxState.tryUpdate (flixel/FlxState.hx line 239)
Called from flixel.FlxGame.update (flixel/FlxGame.hx line 749)
Called from flixel.FlxGame.step (flixel/FlxGame.hx line 679)
Called from flixel.FlxGame.onEnterFrame (flixel/FlxGame.hx line 558)
Called from openfl.events.EventDispatcher.__dispatchEvent (openfl/events/EventDispatcher.hx line 426)
Called from openfl.display.DisplayObject.__dispatch (openfl/display/DisplayObject.hx line 1398)

Called from backend.Song.loadRawSong (backend/Song.hx line 122)
Called from states.PlayState.create (states/PlayState.hx line 566)
Called from states.PlayState.create (states/PlayState.hx line 1155)
Called from flixel.addons.util.FlxAsyncLoop.update (flixel/addons/util/FlxAsyncLoop.hx line 54)
Called from flixel.group.FlxTypedGroup.update (flixel/group/FlxGroup.hx line 151)
Called from flixel.group.FlxTypedGroup.update (flixel/group/FlxGroup.hx line 151)
Called from flixel.addons.ui.FlxUIState.update (flixel/addons/ui/FlxUIState.hx line 212)
Called from backend.MusicBeatState.update (backend/MusicBeatState.hx line 45)
Called from states.PlayState.update (states/PlayState.hx line 2358)
Called from flixel.FlxState.tryUpdate (flixel/FlxState.hx line 239)
Called from flixel.FlxGame.update (flixel/FlxGame.hx line 749)
Called from flixel.FlxGame.step (flixel/FlxGame.hx line 679)
Called from flixel.FlxGame.onEnterFrame (flixel/FlxGame.hx line 558)
Called from openfl.events.EventDispatcher.__dispatchEvent (openfl/events/EventDispatcher.hx line 426)
Called from openfl.display.DisplayObject.__dispatch (openfl/display/DisplayObject.hx line 1398)
Called from openfl.display.Stage.__broadcastEvent (openfl/display/Stage.hx line 1178)
Called from openfl.display.Stage.__onLimeRender (openfl/display/Stage.hx line 2177)
Called from lime.app._Event_lime_graphics_RenderContext_Void.dispatch (lime/_internal/macros/EventMacro.hx line 91)
Called from lime._internal.backend.native.NativeApplication.handleRenderEvent (lime/_internal/backend/native/NativeApplication.hx line 375)
Called from lime._internal.backend.native.NativeApplication.exec (lime/_internal/backend/native/NativeApplication.hx line 146)
Called from lime.app.Application.exec (lime/app/Application.hx line 150)
Called from openfl.display.Application.exec (openfl/display/Application.hx line 130)
Called from ApplicationMain.create (ApplicationMain.hx line 137)
Called from ApplicationMain.main (ApplicationMain.hx line 26)

 ===

Commit: 01dc8ab0ee2a7c630e5e4525d7c3b7b92768df1c

Have you modded the build?
Yes, using Mods
If you edited anything in this build, mention or summarize your changes.
No response
What is your platform?
Windows

Missing file: assets/data/last_chance_v7/last_chance_v7-666.json

Hey it still doesn't work and I tried to make it work but it always gets the same error

Hey it still doesn't work and I tried to make it work but it always gets the same error


Bring back v1.7.1 into main

Bring the v1.7.1 changes back to main.

⚠ @Kerollmops and @dureuill for future merges: we never fix git conflict on a release-v* branch because when fixing git conflicts, you brought all commits from main into this branch, meaning we cannot use this branch for future releases (like v1.7.2)
You should follow this guide instead: https://github.com/meilisearch/engine-team/blob/main/resources/meilisearch-release.md#after-the-release-bring-back-changes-to-main

woops, our bad curqui, I had missed that 😨

Don't worry, Tamo noticed it before releasing v1.7.2, so we did not make any mistake in production, which is the most important 😊


Give command/slot bug

Denizen Build: 1614
Spigot Version: git-Spigot-5a40365-f631379 (MC: 1.9.2)
The slot option seems a little wonky? Like it won't always put the item in the correct slot.
When using for example:

give i@item slot:11
The item will appear in slot 11 in the inventory.
When running it at slot:12 next however, it sometimes will put the item at slot 11 instead, stacking with the previous item. This can happen regardless of what slot you specify.
It seems like the first item placed attracts other items that come after or something?

I gave this a shot on my own personal testing server to make sure it wasn't just one side, but it bugged out this way on both servers.

If you want more specific editing than that, use
- inventory set slot:11 o:i@item

Thanks!
Is it possible to set the quantity with inventory?

i@item[quantity=3]

Cheers!


OC_CONFIG_PATH not set correctly in owncloud > 9

Issue description
There is a patch to set the OC_CONFIG_PATH to point outside of the nix store. It dosen't work with any owncloud > 8.2
//cc @matejc

@pstn Would you have any updates on this?

No, I don't even have a test case right now. I had to set up a quick owncloud to export something noticed it, thought I let people know and promptly forgot about it again.
Incidentally I've seen that nextcloud (the fork of which people tell me it's better than the original) supports this option in upstream, so maybe there could be a quick solution for you.


⚠ ClamAV has degraded performance

In 6a8eac5, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 73 ms

Resolved: ClamAV performance has improved in 21040b6.


Reuse docker-compose labels

Hi,
In my use case, I avoid exposing ports and prefer .docker resolution to launch several instances of compose project. This require to export an env var and reuse it as region in dnsdock.
# .envrc
export COMPOSE_PROJECT_NAME=dev

version: '3'
services:
  app:
    labels:
      com.dnsdock.region: ${COMPOSE_PROJECT_NAME}
      com.dnsdock.name: app

What do you think of falling back label com.dnsdock.region to com.docker.compose.project and label com.dnsdock.name to com.docker.compose.service ?
This allow to resolve service as close as possible to compose structure :
$ getent hosts app.$COMPOSE_PROJECT_NAME.docker
<IP_ADDRESS>      app.compose.docker
$

Thanks for dnsdock, it's a lot easier than playing with ports !

Why not use
com.dnsdock.alias: "app.${COMPOSE_PROJECT_NAME}.docker"

@whitecolor COMPOSE_PROJECT_NAME is not always set while label is.


[Flaschenpost] Add bridge

Add a new bridge for the German beverage delivery service Flaschenpost.de.

The feed fetches all current discounted products based on the given zip code.
The user can select which categories to subscribe to.

This is one of those where the tester fails because even though the logic of the bridge expects at least one of the checkboxes to be checked, there is none checked by default.
It would help the automated testing if you made one of the checked by default (water for example).

It would help the automated testing if you made one of the checked by default (water for example).

Checkboxes should never set a default because then they are always true. Since a checkbox is "unchecked" by not sending the parameter, the default gets filled in. Once #2810 is merged, we can change the pr-tester to use some/all of getTestParameters to test bridges.

The json has a syntax error.

The json has a syntax error.

Yep, seems the JavaScript that gets parsed has changed a bit sometime in the last days. I'll look into it and make the regex sturdier.

Thanks


UnhandledPromiseRejectionWarning: TypeError: node.watch.on is not a function

I just tried this node, but I am getting following error from watch node as soon as it is launched.  Is this a version incompatibility or such? Here are my version
10 Jun 18:07:01 - [info] Node-RED version: v1.0.6
10 Jun 18:07:01 - [info] Node.js  version: v14.4.0
10 Jun 18:07:01 - [info] Linux 4.15.0-101-generic x64 LE
10 Jun 18:04:14 - [info] [kubernetes-client-watch:f4e2057d.ef7178] watching https://myhost:6443/api/v1/pods from resourceVersion: 258446
(node:6676) UnhandledPromiseRejectionWarning: TypeError: node.watch.on is not a function
at KubernetesClientWatchNode.node.startWatch (/home/ubuntu/.node-red/node_modules/node-red-contrib-kubernetes-client/src/index.js:336:18)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
(Use node --trace-warnings ... to show where the warning was created)
(node:6676) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)

Are you comfortable seeing what version of the @kubernetes/client-node got installed? This error is quite strange unless the underlying library somehow updated..
Did the node ever work or has it failed from the begining?

{
"_from": "<EMAIL_ADDRESS>"_id": "<EMAIL_ADDRESS>"_inBundle": false,
"_integrity": "sha512-Uhwd2y2qCvugICnHRC5h2MT5vw0a1dJPVVltVwmkeMuyGTPBccsTtpTcSfSLitwOrh4yr+9wG5bRcMdgeRjYPw==",
"_location": "/@kubernetes/client-node",
"_phantomChildren": {},
"_requested": {
"type": "range",
"registry": true,
"raw": "<EMAIL_ADDRESS>"name": "@kubernetes/client-node",
"escapedName": "@kubernetes%2fclient-node",
"scope": "@kubernetes",
"rawSpec": "^0.11.0",
"saveSpec": null,
"fetchSpec": "^0.11.0"
},
"_requiredBy": [
"/node-red-contrib-kubernetes-client"
],
"_resolved"<EMAIL_ADDRESS>"_shasum": "5dbc1d66d3c954af0f3bd294dece884737f5b761",
"_spec": "<EMAIL_ADDRESS>"_where": "/home/ubuntu/.node-red/node_modules/node-red-contrib-kubernetes-client",
"author": {
"name": "Kubernetes Authors"
},
"bugs": {
"url": "https://github.com/kubernetes-client/javascript/issues"
},
"bundleDependencies": false,
"dependencies": {
"@types/js-yaml": "^3.12.1",
"@types/node": "^10.12.0",
"@types/request": "^2.47.1",
"@types/underscore": "^1.8.9",
"@types/ws": "^6.0.1",
"byline": "^5.0.0",
"execa": "1.0.0",
"isomorphic-ws": "^4.0.1",
"js-yaml": "^3.13.1",
"jsonpath-plus": "^0.19.0",
"openid-client": "2.5.0",
"request": "^2.88.0",
"rfc4648": "^1.3.0",
"shelljs": "^0.8.2",
"tslib": "^1.9.3",
"underscore": "^1.9.1",
"ws": "^6.1.0"
},

The node never worked

Sorry had to run out of town. I may need you to console.log(node.watch) at line 335 and see what it spits out. You’ll need to hack the code then restart nodered and watch the nodered output.
This is a strange one to debug but I’m confident we’ll get to the bottom of it for sure.

Here is the code snippet and here the output...
console.log("---- START OF WATCH LOG ----");
console.log("---- Calling console.log(node.watch) ----");
console.log(node.watch);
console.log("---- Done calling console.log(node.watch) ----");
  console.log('Calling node.watch.on("socket", socket => {})');
  node.watch.on("socket", socket => {});
  console.log('Calling node.watch.on("error", err => {})');  **// NEVER GETS HERE**

---- START OF WATCH LOG ----
---- Calling console.log(node.watch) ----
Promise {  }
---- Done calling console.log(node.watch) ----
Calling node.watch.on("socket", socket => {})
(node:22096) UnhandledPromiseRejectionWarning: TypeError: node.watch.on is not a function
at KubernetesClientWatchNode.node.startWatch (/home/ubuntu/.node-red/node_modules/node-red-contrib-kubernetes-client/src/index.js:342:18)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
(Use node --trace-warnings ... to show where the warning was created)
(node:22096) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:22096) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
13 Jun 14:33:53 - [info] [kubernetes-client-watch:PODS Watch] watching https://onapcontrol1ext:6443/api/v1/pods from resourceVersion: 762982

Ok that helps a bit. Give me a minute to dig through the library code and see what I discover.

Ok, sure enough they changed the api with a patch release :( I’ll pin the version down tighter but as a test can you try to add await to line 200 and see what you get?
node.watch = await watch.watch(

That worked. Thanks!

Nice! I’ll keep this open until I snap a new release.
I’m generally interested in understanding use-cases that people are implementing with it. Mind sharing what you intend to implement?

Fixed here: https://github.com/travisghansen/node-red-contrib-kubernetes-client/commit/5b06456130ced3f1201220484438ec818d292a48