Use codecov action

Codecov Report

Merging #34 (4bf097d) into master (567acad) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           16        16
  Lines          581       581
=========================================
  Hits           581       581

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


error "restoreBlocks: given chain isn't a valid continuation" when quickly creating new wallets after startup

Just checking...

[X] This is a cardano-wallet bug.
[X] I am using the latest cardano-wallet release.
[X] I am using the correct cardano-node version for that release of cardano-wallet.

Version
v2021-09-09 (git revision: fca1cdc89dbf56b328d625f7e5c539107e1d01d3)
Platform
nixos/nix:2.3.12 docker image (uname -a output: Linux 33117d699f44 5.10.47-linuxkit #1 SMP PREEMPT Sat Jul 3 21:50:16 UTC 2021 x86_64 Linux)
Installation method
Nix
Network configuration
Private testnet created using this script: https://github.com/input-output-hk/cardano-node/blob/0ed04ab8d0a205691219f04623a3d880545a3f34/scripts/byron-to-alonzo/mkfiles.sh
Context
I'm experiencing this transient cardano-wallet error in CI for about half of the CI runs:
[cardano-wallet.wallet-engine:Error:73] [2021-09-20 13:52:25.85 UTC] f58e2ec8: Unexpected error following the chain: user error (restoreBlocks: given chain isn't a valid continuation. Wallet is at: 891fcd4b<-[9c9290a4-0#0] but the given chain continues starting from: 891fcd4b<-[db619f76-14#0])

I'm running a private testnet using this script (scripts/byron-to-alonzo/mkfiles.sh alonzo && example/run/all.sh) and starting the wallet with this command (run from the same dir that mkfiles.sh was run from):
cardano-wallet serve \
    --node-socket ./example/node-bft1/node.sock \
    --testnet ./example/byron/genesis.json \
    --database ./data \
    --listen-address <IP_ADDRESS>

Importantly, the cardano-wallet instance is started no more than 2 seconds after the node node-bft1 has created its socket file (./example/node-bft1/node.sock) and immediately after startup two new wallets are created.
Here's the full log (including that of cardano-node as well as the client speaking to cardano-wallet): https://gist.github.com/runeksvendsen/c143926249e32b22ee2d184581c9776c. The above error occurs immediately after the second wallet is created at 2021-09-20T13:52:25.8393038Z  (search for "Created new wallet") in the logs here.
NB: @Anviking has suggested waiting for  3k/f slots (60 seconds using the above mkfiles.sh script) until creating the first wallet, to ensure the beginning of the chain is completely stable. This workaround has not been attempted yet.
cardano-node version: 1.29.0 (git revision: 4c5c5694d076c16b695fa0a933867509f39f2493)
cardano-wallet version: v2021-09-09 (git revision: fca1cdc89dbf56b328d625f7e5c539107e1d01d3)
Description
Steps to Reproduce
First, run the cardano-node instances, and be ready to execute the below cardano-wallet "runner" script immediately after.
git clone https://github.com/input-output-hk/cardano-node.git
cd cardano-node/
scripts/byron-to-alonzo/mkfiles.sh alonzo
# run the below script now, in a separate terminal, from this directory
example/run/all.sh

cardano-wallet runner script:
SOCKET_FILE="./example/node-bft1/node.sock"

while ! ls "$SOCKET_FILE" > /dev/null ; do
    echo "waiting for cardano-node..."
    sleep 0.5
done
echo "cardano-node ready!"

cardano-wallet serve \
    --node-socket "$SOCKET_FILE" \
    --testnet ./example/byron/genesis.json \
    --database ./data &

# Generate a wallet.
# Usage: generate_wallet <wallet_name> <passphrase> <recovery_phrase>
# Returns: wallet ID
function generate_wallet() {
    local WALLET_NAME="$1"
    local PASSPHRASE="$2"
    local RECOVERY_PHRASE="$3"

    local WALLET_ID
    WALLET_ID=$(cardano-wallet wallet create from-recovery-phrase "$WALLET_NAME" < <(printf "%s\n" "$RECOVERY_PHRASE" "" "$PASSPHRASE" "$PASSPHRASE") |jq -r .id)
    echo "Created new wallet with ID $WALLET_ID" 1>&2
    echo "$WALLET_ID"
}

# generate two wallets
generate_wallet "test_wallet_1" "some very secret passphrase 1" "$(cardano-wallet recovery-phrase generate)"
generate_wallet "test_wallet_2" "some very secret passphrase 2" "$(cardano-wallet recovery-phrase generate)"

Expected behavior
cardano-wallet is able to follow the chain followed by cardano-node.
Actual behavior
cardano-wallet is not able to follow the chain followed by cardano-node.
[cardano-wallet.wallet-engine:Error:73] [2021-09-20 13:52:25.85 UTC] f58e2ec8: Unexpected error following the chain: user error (restoreBlocks: given chain isn't a valid continuation. Wallet is at: 891fcd4b<-[9c9290a4-0#0] but the given chain continues starting from: 891fcd4b<-[db619f76-14#0])

Jira ticket for tracking: ADP-1148.


fallocate: invalid length value specified

Started getting this error on my actions. Assumed the repo had grown too big, but even re-running previously successful actions causes this error. Log follows.
Run easimon/maximize-build-space@master
Run echo "Memory and swap:"
Memory and swap:
               total        used        free      shared  buff/cache   available
Mem:         7110608      490944     5421356       22792     1198308     6284588
Swap:        4194300           0     4194300

NAME          TYPE SIZE USED PRIO
/mnt/swapfile file   4G   0B   -2

Available storage:
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        84G   58G   26G  69% /
tmpfs           3.4G  172K  3.4G   1% /dev/shm
tmpfs           1.4G  1.1M  1.4G   1% /run
tmpfs           5.0M     0  5.0M   0% /run/lock
/dev/sda15      105M  6.1M   99M   6% /boot/efi
/dev/sdb1        14G  4.1G  9.0G  31% /mnt
tmpfs           695M   12K  695M   1% /run/user/1001

Run set -euo pipefail
Arguments:

  Root reserve:      30720 MiB
  Temp reserve:      100 MiB
  Swap space:        1024 MiB
  Overprovision LVM: false
  Mount path:        /home/runner/work/map-repo/map-repo
  Root PV loop path: /pv.img
  Temp PV loop path: /mnt/tmp-pv.img
  Removing:     dotnet
Removing unwanted software...
... done
Unmounting and removing swap file.
Creating LVM Volume.
  Creating LVM PV on root fs.
fallocate: invalid length value specified
Error: Process completed with exit code 1.

Not sure if this was an issue specific to my action or not - but closing to save you investigating if it is, as I've found another solution.

Well, I've run out of space again, tried this action again, same issue as above.

If not misreading, you're trying to get 30GB root reserve, which might be more than what is available. The error message then is the result of trying to create a disk image file with negative size.


chore(css): remove rtl artifact builds

Description
Now that CSS logical properties are used throughout the project, there is no need for rtl artifacts to be built. This PR removes those builds.
Changelog
New

{{new thing}}

Changed

{{changed thing}}

Removed

remove rtl builds and artifacts
remove Storybook rtl documentation

I think now that we're removing rtlcss we can probably remove the rtl directives in the stylesheets too like this one:
https://github.com/carbon-design-system/carbon-for-ibm-dotcom/blob/main/packages/web-components/src/components/masthead/masthead.scss#L227
I see a bunch of them in the masthead and leadspace styles

if we add the rtl tag will. it trigger a rtl deploy preview?

if we add the rtl tag will it trigger a rtl deploy preview?

Yep!


Please add palemoon (a Firefox fork) to yt-dl's --cookies-from-browser functionality

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm requesting a feature unrelated to a specific site
[X] I've looked through the README
[X] I've verified that I'm running yt-dlp version 2023.07.06 (update instructions) or later (specify commit)
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
Adding  --cookies-from-browser palemoon
Please add palemoon (a Firefox fork) to yt-dl's  --cookies-from-browser  functionality,
I use the current version:
yt-dlp -U
Available version<EMAIL_ADDRESS>Current version<EMAIL_ADDRESS>Current Build Hash: cedf44a9cf3c241520a692c1006d276e6f434d4d945727c47cb1a70d32953f4a
yt-dlp is up to date<EMAIL_ADDRESS>
This is the error I get when tying to use my palemoon cookies:
yt-dlp yt-dlp -v --cookies-from-browser palemoon -f hls-480-0 https://www.dailymotion.com/video/x8kihec
[debug] Command-line config: ['yt-dlp', '-v', '--cookies-from-browser', 'palemoon', '-f', 'hls-480-0', 'https://www.dailymotion.com/video/x8kihec']

Usage: yt-dlp [OPTIONS] URL [URL...]

yt-dlp: error: unsupported browser specified for cookies: "palemoon". Supported browsers are: brave, chrome, chromium, edge, firefox, opera, safari, vivaldi

Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[ ] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
No response

See pinned issue https://github.com/yt-dlp/yt-dlp/issues/2903#issuecomment-1053567469

@coletdjnz Sadly it not works:
$ yt-dlp -v --cookies-from-browser "firefox:~/.moonchild\ productions/pale\ moon/zmoo6b.default/" -f hls-480-0 https://www.dailymotion.com/video/x8kihec
[debug] Command-line config: ['-v', '--cookies-from-browser', 'firefox:~/.moonchild\\ productions/pale\\ moon/zmoo6b.default/', '-f', 'hls-480-0', 'https://www.dailymotion.com/video/x8kihec']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>[b532a3481] (zip)
[debug] Python 3.9.16 (CPython x86_64 64bit) -<EMAIL_ADDRESS>(OpenSSL 1.1.1s  1 Nov 2022, glibc 2.35)
[debug] exe versions: ffmpeg 4.4.2 (setts), ffprobe 4.4.2, rtmpdump 2.4
[debug] Optional libraries: brotli-1.0.9, sqlite3-2.6.0
[Cookies] Extracting cookies from firefox
Traceback (most recent call last):
  File "/usr/lib64/python3.9/runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib64/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/usr/bin/yt-dlp/__main__.py", line 17, in <module>
  File "/usr/bin/yt-dlp/yt_dlp/__init__.py", line 1008, in main
  File "/usr/bin/yt-dlp/yt_dlp/__init__.py", line 962, in _real_main
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 676, in __init__
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 3953, in print_debug_header
  File "/usr/bin/yt-dlp/yt_dlp/YoutubeDL.py", line 3997, in _setup_opener
  File "/usr/bin/yt-dlp/yt_dlp/cookies.py", line 106, in load_cookies
  File "/usr/bin/yt-dlp/yt_dlp/cookies.py", line 123, in extract_cookies_from_browser
  File "/usr/bin/yt-dlp/yt_dlp/cookies.py", line 148, in _extract_firefox_cookies
FileNotFoundError: could not find firefox cookies database in /home/user/.moonchild\ productions/pale\ moon/zmoo6b.default/

the cookies databases exist at that very place:
$ ls ~/.moonchild\ productions/pale\ moon/zmoo6b.default/cookies.sqlite*
/home/user/.moonchild\ productions/pale\ moon/zmoo6b.default/cookies.sqlite
/home/user/.moonchild\ productions/pale\ moon/zmoo6b.default/cookies.sqlite-shm
/home/user/.moonchild\ productions/pale\ moon/zmoo6b.default/cookies.sqlite-wal

--cookies-from-browser "firefox:~/.moonchild\ productions/pale\ moon/zmoo6b.default/"

Don't quote the argument AND escape with backslashes, only do one or the other

@bashonly That was the issue indeed.
Using this code
yt-dlp -v --cookies-from-browser "firefox:~/.moonchild productions/pale moon/zmoo6b.default/" -f hls-480-0 https://www.dailymotion.com/video/x8kihec

works. Thanks.

You could also set an alias in your config file if you want:
--alias cookies-from-palemoon '--cookies-from-browser "firefox:~/.moonchild productions/pale moon/zmoo6b.default/"'

and then use --cookies-from-palemoon in your command lines

Palemoon very significantly diverges from Firefox. I'm honestly surprised that https://github.com/yt-dlp/yt-dlp/issues/2903#issuecomment-1053567469 worked
I guess if it works then it works, but I'm slightly concerned that a future change to cookies.py could break it, given that code wasn't designed for a Firefox 24 fork


feature: server product attributes

Features

[x] Implement API logic to retrieve and map attributes
[ ] Display attributes grouped by attribute_group

[x] Display list of attributes

[ ] Make attributes open bottom dialog on user pression

Screenshots

@VaiTon some files are in conflict

@VaiTon do you feel confident merging this one ?


Images from gitlab get randomly updated

Hi djmaze,
I have an weird Problem with images that are hosted on registry.gitlab.com: Sometimes shepherd updates the image from image:tag@hash to image:tag. After sleeping shepherd updates the image back from image:tag to image:tag@hash. Its always the same image-version, no updates happened in the registry. That only happens with gitlab-images, docker-hub works fine.
Here my log:
[Shepherd] Service idm2cn-dev_api-frontend updated
Wed Jan 20 09:01:34 CET 2021 Service idm2cn-dev_api-frontend was updated from registry.gitlab.com/selma-tud/idm2cn-frontend:master@sha256:280d8f29b2ec118abd682a8c44246fd4a741d8ac4fb63a2b477c0c70bae8438f to registry.gitlab.com/selma-tud/idm2cn-frontend:master

[Shepherd] Service idm2cn-dev_api-frontend updated
Wed Jan 20 09:04:30 CET 2021 Service idm2cn-dev_api-frontend was updated from registry.gitlab.com/selma-tud/idm2cn-frontend:master to registry.gitlab.com/selma-tud/idm2cn-frontend:master@sha256:280d8f29b2ec118abd682a8c44246fd4a741d8ac4fb63a2b477c0c70bae8438f

I actually don't think it's a bug in your software, it looks like somethings wrong with PreviousSpec and Spec. Unfortunately, I can't find anything about it online and would be happy if you could point me in the right direction.

Ok, i investigated a little bit further and found these 2 issues that describe the same problem(One is solved, the other one is still open):
https://github.com/moby/moby/issues/36524
https://github.com/moby/moby/issues/34242
But I still don't understand why it's only happening sometimes and only with gitlab...
As a Workaround i will try to check if $previousImage or $currentImage contains an @, if not no updates will be made

Ok, i investigated a little bit further and found these 2 issues that describe the same problem(One is solved, the other one is still open):
https://github.com/moby/moby/issues/36524
https://github.com/moby/moby/issues/34242
But I still don't understand why it's only happening sometimes and only with gitlab...
As a Workaround i will try to check if $previousImage or $currentImage contains an @, if not no updates will be made

No idea about this (I also do not use Gitlab). Keep us updated if you find out more!

No idea about this (I also do not use Gitlab). Keep us updated if you find out more!

Yes, I will keep an eye on the issues mentioned above. I don't think my workaround should be merged into master, its clearly an docker issue. But if anyone has the same problem:
Inside shepherd I changed:
if [ "$previousImage" == "$currentImage" ]; then

to
if [ "$previousImage" == "$currentImage" ] || [[ "$currentImage" != *"@"* ]] || [[ "$previousImage" != *"@"* ]]; then

which solves it for me.

Yes, I will keep an eye on the issues mentioned above. I don't think my workaround should be merged into master, its clearly an docker issue. But if anyone has the same problem:
Inside shepherd I changed:
if [ "$previousImage" == "$currentImage" ]; then

to
if [ "$previousImage" == "$currentImage" ] || [[ "$currentImage" != *"@"* ]] || [[ "$previousImage" != *"@"* ]]; then

which solves it for me.


Error while installing pointnet2

Hi,
I'm using pytorch 1.5. I was installing pointnet2 in a virtualenv, using python3 setup.py install, and I got the following error:
src/ball_query.cpp:22:27: error: ‘THCState_getCurrentStream’ was not declared in this scope
   22 |     cudaStream_t stream = THCState_getCurrentStream(state);
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1

Can you give me hints on how to solve this?
Thank you in advance!

Hi! I'm in same problem now.
If you solved it, could you share the solution?


GL-AX1800 Support

GL-AX1800 Support

Please update the PR to merge into the next branch, not main.


Docs: Move CODE_OF_CONDUCT.md in the root

Users usually expect the CODE_OF_CONDUCT.md file to be in the root of the project. The same is true for some apps (e.g. https://github.com/sonarwhal/sonar/community).

The scripts in the website need to be updated too, right?

Yes, was planning to do that once this is merged.

The scripts in the website need to be updated too, right?

Yes, was planning to do that once this is merged.

Done.


Fix deprecation warning

This PR fixes the deprecation warning in http://emberjs.com/deprecations/v2.x/#toc_enumerable-contains
The deprecation applies for Ember 2.8+, so anything less than that should break.
I suggest merging this after Ember hits 3.0

Closing, as it's currently breaking on my app..


RetryPriority plugin not supported for RING_HASH/MAGLEV

RING_HASH and MAGLEV both support priority routing, but does not honor LoadBalancerContext::determinePriorityLoad, effectively breaking the RetryPredicate plugins. This also has implications wrt https://github.com/envoyproxy/envoy/pull/7967, as it attempts to target a specific priority using the LB context.
Calling determinePriorityLoad is tricky in the context of ThreadAwareLoadBalancer due to the LBs not having access to the PrioritySet used to compute the priority loads that it uses: only the necessary information is currently snapped into the TLS load balancer, which does not include the entire PrioritySet.
Some options:

Pull the PrioritySet from the TLS cluster. This is probably the simplest solution, but means that the PrioritySet might be out of sync with the priority loads stored on the ThreadAwareLoadBalancer: there might have been another change to the priority loads on the main thread before any given change is propagated to the TLS cluster. For example, if two updates happen right after each other, a request that gets handled between the two dispatcher events to update the TLS cluster might be using the TLS cluster after the first update but the priority loads after both updates.
Store additional data in the the LB factory, sufficient to recreate the PrioritySet on the worker threads and pass it to the LB context. The PrioritySetImpl itself cannot be shared between threads due to being mutable.
Add an overload to determinePriorityLoad that doesn't accept a PrioritySet. This wouldn't make the ThreadAware LBs compatible with the RetryPriority plugins, but would at least allow for the aggregate cluster to target a specific priority.

Open to other suggestions as well.
@yxue

Thanks @snowp for raising the issue.

It seems dangerous to access the mutable data in worker thread from main thread. Is it a common issue? IIRC, accessing data in worker thread from main thread is not recommended.

This seems to be a shortcut. If there is no requirement for using retry plugin for RING_HASH/MAGLEV, we might be able to implement this quickly.

For 1) I wasn't suggesting accessing the main thread PS, but the one that belongs to the thread local ClusterEntry. The calls to chooseHost happens on the worker threads as requests are handled, so accessing the TLS cluster for that thread would be safe (besides the potential inconsistency issue I raised in the original comment).
Assuming you meant 3), I think that would be the easiest way of implementing the behavior necessary for the top level priority selection done by the aggregate cluster, but it does complicate the API a bit.
If you think there is a need to support the priority targeting for all LB impls with the aggregated cluster in the short term it might be feasible step one to add the overload, but I also think that we should try to get the retry plugins working properly for all LB implementations that currently make use of priority routing.


feat(deps): bump css-prefix

Updates css-prefix to v2. Ref https://github.com/stackcss/sheetify/issues/105

Current coverage is 95.94% (diff: 100%)

Merging #107 into master will decrease coverage by 0.05%

@@             master       #107   diff @@
==========================================
  Files             2          2
  Lines           150        148     -2
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            144        142     -2
  Misses            6          6
  Partials          0          0

Powered by Codecov. Last update e0cb38d...263c44a

yep yep yep :+1:


ColdFusion support (also custom Throwables)

At the moment you can only notify about a Throwable, it would be nice to support notifying with an arbitrary exception class, message and stack trace that you've obtained from something like coldfusion.

Punting on this for when or if it comes up again.


glib: Deprecate paramspec new() functions in favour of the builder

@bilelmoussaoui What do you think?

Considering that nothing in gtk4-rs, gtk-rs-core or gstreamer-rs / gst-plugins-rs is using the normal constructors anymore and they're inconvenient to use, let's go ahead with this to get some noise out of the way.


[docs] Update pages with better content design

Improve individual pages with better content design, like distributing content in columns, etc.

Waiting on grid work from DPO.
CC: @coreyvickery @marionnegp


docs: engineering documentation of the multi-tenancy feature [skip CI]

Overview
Engineering documentation of the MT feature
Fixes ATL-4091
Checklist
My PR contains...

[ ] No code changes (changes to documentation, CI, metadata, etc.)
[ ] Bug fixes (non-breaking change which fixes an issue)
[ ] Improvements (misc. changes to existing features)
[ ] Features (non-breaking change which adds functionality)

My changes...

[ ] are breaking changes
[ ] are not breaking changes
[ ] If yes to above: I have updated the documentation accordingly

Documentation

[ ] My changes do not require a change to the project documentation
[ ] My changes require a change to the project documentation
[ ] If yes to above: I have updated the documentation accordingly

Tests

[ ] My changes can not or do not need to be tested
[ ] My changes can and should be tested by unit and/or integration tests
[ ] If yes to above: I have added tests to cover my changes
[ ] If yes to above: I have taken care to cover edge cases in my tests

I'm merging this to have less conflicts after repo transfer.


Remove use of deprecated functions across library #4

This PR is connected to the changes made in #1.Every use of the deprecated functions are refactored to use Color or other equivalent conversion function in colour module.
Closes #4

@amandakrohn could you take a look as well? Then we can create a PR on the main repo


nitrokey-app2: 2.1.4 -> 2.1.5

Description of changes
https://github.com/Nitrokey/nitrokey-app2/releases/tag/v2.1.5
Quite some changes, e.g. qt5 -> qt6.
https://github.com/Nitrokey/nitrokey-app2/compare/v2.1.4...v2.1.5
~Requires #280614 to be merged first.~ Done
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.
ines: https://nixos.org/manual/nixpkgs/unstable/#chap-reviewing-contributions

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 280713 run on x86_64-linux 1

2 packages built:

nitrokey-app2
nitrokey-app2.dist

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1399


WIP Query.fetch_raw

Summary
Adds a method to fetch raw bytes from a query, exposes RawCursor, and adds an additional cursor type (RawCursorNewline) to work with arbitrary formats where a newline character separates rows. See the related examples regarding streaming into a file, as well as streaming separate *EachRow records.
Checklist

[ ] Unit and integration tests covering the common scenarios were added
[ ] A human-readable description of the changes was provided so that we can include it in CHANGELOG later
[ ] For significant changes, documentation in README and https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

Open questions so far:

Error handling. This test returns an error locally, but the contents are off:

Err(BadResponse("{\"s\":0}\n{\"exception\": \"Code: 159. DB::Exception: Timeout exceeded: elapsed 0.100752804 seconds, maximum: 0.08. (TIMEOUT_EXCEEDED) (version <IP_ADDRESS>12 (official build))\"}"))

Fails on the CI for some reason.

This API probably has the same issue as https://github.com/ClickHouse/clickhouse-rs/issues/24
Output formats. Currently, it is parsed from the docs, and every format that is suitable for the output is included. Shall we keep all of them, or only a select subset?


az aks get-credentials    unexpected error

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az aks get-credentials
Errors:
The command failed with an unexpected error. Here is the traceback:
cannot import name 'map_azure_error_to_cli_error' from 'azure.cli.command_modules.acs._helpers' (/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/azure/cli/command_modules/acs/_helpers.py)
Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 556, in execute
    self.commands_loader.load_arguments(command)
  File "/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/azure/cli/core/__init__.py", line 515, in load_arguments
    self.command_table[command].load_arguments()  # this loads the arguments via reflection
  File "/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 313, in load_arguments
    super(AzCliCommand, self).load_arguments()
  File "/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/knack/commands.py", line 104, in load_arguments
    cmd_args = self.arguments_loader()
  File "/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 125, in arguments_loader
    op = self.get_op_handler(self.op_path)
  File "/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 59, in get_op_handler
    handler = import_module(mod_to_import)
  File<EMAIL_ADDRESS>line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/Users/mohanay/.azure/cliextensions/aks-preview/azext_aks_preview/custom.py", line 105, in <module>
    from ._helpers import (
  File "/Users/mohanay/.azure/cliextensions/aks-preview/azext_aks_preview/_helpers.py", line 7, in <module>
    from azure.cli.command_modules.acs._helpers import map_azure_error_to_cli_error
ImportError: cannot import name 'map_azure_error_to_cli_error' from 'azure.cli.command_modules.acs._helpers' (/usr/local/Cellar/azure-cli/2.34.1/libexec/lib/python3.10/site-packages/azure/cli/command_modules/acs/_helpers.py)

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az aks get-credentials --resource-group {} --name {}

Expected Behavior
Environment Summary
macOS-11.6.5-x86_64-i386-64bit, Darwin 20.6.0
Python 3.10.2
Installer: HOMEBREW

azure-cli 2.34.1 *

Extensions:
aks-preview 0.5.70
azure-devops 0.18.0
ssh 0.1.6

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

route to CXP team

@mokainos Apologies for the late reply. Thanks for reaching out to us and sharing this feedback. Could you please update your aks-preview extension and test if you still see the same issue ?

az extension update -n aks-preview

Awaiting your reply.

@mokainos I wanted to do quick follow-up to check if you had a chance to follow my above suggestion. Please let us know if you need any further assistance on this. Awaiting your reply.

@mokainos The action is currently pending on you to follow the above plan. We will now proceed with closure of this github issue. If you need any further assistance on this issue in future, please feel free to reopen this thread. We would be happy to help.


Plugin VGamePad for touchscreen gamepad can only process single touch

Operating system or device - Godot version:
I'm f***ing awesome so I use Ubuntu Studio. All other Operating Systems are inferior and "stoopid"
Issue description:

So I know this is probably in the wrong place, so link me to where I can post this and it will be done!
Steps to reproduce:
Load and install the VGamePad plugin via the asset library, and publish to a mobile device(I used android on my HTC One). It can only process the currently focused control. I have this plugin used to move a 3d character around with the analog stick and an "A Button" for jump...having to release the analog stick to perform a jump is worse than "ET Adventures" and I don't even have a successful movie franchise to fall back on...
Link to minimal example project:

I double dog dare you to pick a fight with that rabid possum in the dumpster!

I know Godot is capable of multitouch, so I suppose this isn't so much an "Issue" as it is me asking for help making multitouch work with this plugin. If it's not a simple edit and is an involved task, can you find me a link to the author's GIThub maybe? Thanks!

You can find the upstream URL in the assetlib, both in editor or the web frontend: https://godotengine.org/asset-library/asset/50
Namely, it's this GitLab repo: https://gitlab.com/DigiGodotPlugins/DigiVGamepad


Models displaying over one another incorrectly

Happens as a result of ObjectGroups not sorting correctly, look into how global positioning (of Groupables assigned to ObjectGroups) is calculated and fix.

Determined cause - object parents aren't being assigned correctly. Working on fix.

Fixed by commit 208939dd2cd603ae0454e0881c698aee6f2b324b


Regenerate controller with aws-sdk-go version v0.42.0

Issue #, if available:
Description of changes:

Regenerate controller with aws-sdk-go version v0.42.0
Add go.local.mod

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/retest

/lgtm


Create MDM Source Category Endpoint

Definition of Ready

[x] Does this meet the INVEST criteria?
[x] Does this have a clearly defined user?
[x] Does this have an estimate?
[x] Does this have acceptance criteria?
[x] Does this have sufficient context (wireframes, business rules, etc.)?
[x] Is this traceable to a feature, epic, or PI?

User Story
As a CAM API user I want to see a list of source categories so that I can include the correct data in my query
Acceptance Criteria
Given that a user has made a GET request to the source category endpoint
When the request is executed
Then the system displays all source categories in JSON format and for each record displays:

source category code
source category description

Does this Story require 508 Testing?

[ ] Implementing a new authoring tool that will produce code / content for the application
[ ] Implementing a 3rd party widget that will be part of the application
[ ] Adding new / updating custom functionality
[ ] Adding new / updating a page template
[ ] Adding new / replacing existing functionality (unless the replacement has already passed 508 testing)
[ ] Full Site Review prior to a scheduled EPA 508 review
[ ] Planning a video that will appear on the application
[ ] Producing a video that will appear on the application
[ ] Producing Training materials
[ ] Producing documents

Context
(User journeys, design mockups, architectural diagrams, business rules, data element definitions)
Testing
Test Case: TC364
Tester: @JanellC
Definition of Done

[x] Have all Acceptance Criteria been agreed to and validated by the scrum team?
[x] Has the code been unit tested and peer reviewed?
[x] Have the functional tests been executed?
[x] Have all defects been reviewed and dispositioned, resolved, or deferred?
[ ] Has the user story been accepted by the Product Owner?
[x] Is the user story ready to be deployed to the test/staging environments?

@tlageman-epa TC364 passed
https://easey-dev.app.cloud.gov/api/master-data-mgmt/source-categories


Microsoft edge websites refused to connect

Is your feature request related to a problem? Please describe.
I would like to be able to visit more websites
Describe the solution you'd like
could you make it so that you can visit any website you like on microsoft edge/bing
Describe alternatives you've considered
You could also add another browser like chrome if that works
Additional context

hey @mustuthebest could you send a screen shot of your issue

As I stated in other issue, not all website allow themselves to be iframed. So it's only natural for them to refuse to connect. We cannot do anything from our side. (Unless, you know, we create our own browser that doesn't provides any limits on iframe and push it in the mainstream XD)


Used different react datepicker for more utility

resolve #530
Might need to change the styling of the date picker.

@jSylvestre I'm not too sure why. How come we don't gitignore our package-lock.json files btw?

@wongband What version of npm are you using? I'm on 6.14.15

@jSylvestre I'm not too sure why. How come we don't gitignore our package-lock.json files btw?

If you don't commit it, then the version of the application everyone else will get is different than what you are running locally. This means that things might work for you, but break on the CI/production/other local machines.

@sprucely I have npm 7.20.5


Template.dynamic is causing an infinite loop

I try to include a template (not a component) from a blaze-component using {{> Template.dynamic}}, but it causes an infinite loop.
Here is a minimal reproduction: https://github.com/mquandalle/blaze-components-template-dynamic. In this example commit-1 is working fine, and then after I transform my template into a blaze component in commit-2 there is an infinite loop.

I was just about to open this ticket too. :)

A workaround that was sufficient for my case of
{{> UI.dynamic template=someTemplateName}}

(where someTemplateName  was a property on the inner data context), was to go with
{{> someTemplate}}

and in component have
someTemplate: ->
  Template[@currentData()?.someTemplateName] or null

Of course, this is even better because an inherited component can then change the behavior if wanted. :-)
But yea, this should be fixed.

Thanks for reporting.


Changing status while showing SVProgress

I have this code:
        SVProgressHUD.show(withStatus: "Getting data...")
        DispatchQueue.main.asyncAfter(deadline: .now() + .seconds(1), execute: {
        CODE
        CODE
        })

Now in some place in my code, during this main queue a want to update the "Getting data" status(label) to something else. I tried
SVProgressHUD.setStatus(" Something Else ")
But it updates de label just before i dismiss the SVProgressHUD.
I know its something related to the threading. But what should be the right way to change the status label while running something on background?
Thanks

I cannot reproduce the issue. This is my code:
- (void)show {
    [SVProgressHUD showWithStatus:@"First"];
    [self performSelector:@selector(show2) withObject:nil afterDelay:4.0f];
}

- (void)show2 {
    [SVProgressHUD setStatus:@"Second"];
}

In general I can not recommend using GUI stuff on the background thread. If you need further investigation provide a demo project.


B-19178 MTO shipment risk of excess banner persistence solution

Agility ticket
Summary
Is there anything you would like reviewers to give additional scrutiny?
Continuation of:
https://github.com/transcom/mymove/pull/12499
Screenshots

Fails

:no_entry_sign:
Yarn Audit Issues Found:
high - PDF.js vulnerable to arbitrary JavaScript execution upon opening a malicious PDF
Package pdfjs-dist
Patched in >=4.2.67
Dependency of @trussworks/react-file-viewer
Path @trussworks/react-file-viewer > pdfjs-dist
More info https://github.com/advisories/GHSA-wgrm-67xf-hhpq
1 high vulnerabilities and 0 critical vulnerabilities found

  Generated by :no_entry_sign: dangerJS against 7f78401bc2b8fec2525f8477738f79d0890830f7


What does it need to work on legenday , ultimate skins ?

I wonder what does the program need to work on those skins, does it need time ? knowledge ?
If its solved, the new patches would be just to add more skins and not to do everything again ?
I may willing to help if its time what it needs.

What do you know about coding?

What has to be done?
Ill help based on that.


docker: support the client only in darwin

Can probably work in other platforms but I only tested this on OSX 10.9.5
cc @offlinehacker @tailhook

maybe should be implemented as a clientOnly argument that gets overridden to true on darwin and  possibly other environments when the server wouldn't work?

Looks good to me

Added the clientOnly flag @fazo96

thanks for the feedback @offlinehacker . I wasn't familiar with stdenv.lib.optional[s] before. I hope this works now.

@offlinehacker @fazo96 , this pull request is ready for review again.


Issues on CF Push

Hi, I`m receiving this error message on CF push:
/tmp/buildpacks/8d05521164c8f2951cf85c9911dbf6f1/bin/detect: line 4: dirname /tmp/buildpacks/8d05521164c8f2951cf85c9911dbf6f1/bin/detect: No such file or directory
/tmp/buildpacks/8d05521164c8f2951cf85c9911dbf6f1/bin/detect: line 4: dirname : command not found
None of the buildpacks detected a compatible application
Exit status 222
Staging failed: Exited with status 222
Destroying container
Successfully destroyed container
Do U have Ideia how to fix this?

Repo moved to attic


Request to support third party Storage Backend without making new migration files

I am using amazon s3 as a file storage backend. It requires me to generate a migration file in the systems' python library directory. This is not elegant.
from django.db import migrations, models
import avatar.models
import storages.backends.s3boto

class Migration(migrations.Migration):

    dependencies = [
        ('avatar', '0001_initial'),
    ]

    operations = [
        migrations.AlterField(
            model_name='avatar',
            name='avatar',
            field=models.ImageField(storage=storages.backends.s3boto.S3BotoStorage(), max_length=1024, upload_to=avatar.models.avatar_path_handler, blank=True),
        ),
    ]

This would be really helpful if supported. I'm using Amazon S3.

This is probably related to #167

This is now controlled by settings.AVATAR_STORAGE. If the issue has not been fixed entirely, please reopen.


Documentation for offline installation

Since microscope computers are often behind a firewall without internet access, we should document how to install LiberTEM packages on such a system.
Rough outline:

Install Conda from stand-alone installer on target system
Create empty environment in offline mode on target system
Create a staging environment with the same OS, architecture and Python version on a system with internet access
pip wheel ... to create wheels

Additional info on how to install a development version from GitHub

Copy wheels to target system
Install wheels with pip in offline mode

Bumped to next release since it keeps cropping up frequently, and even for @sk1p and I it is annoying to figure out each time.

Fixed by #1627


ci: bring back debug builds

... so that we can track how each commit regresses / improves in PR's jobs. AFAIK each PR now builds at least 3-4 times before merging, so it's little cost to build it again on main.

+1. We can track the performance of both compiling and e2e this way, which is related to the developer experience. 🤤


Rate limit exceeded for API_KEY

After about 10 to 20 seconds running fine, I get the error Rate limit exceeded for API_KEY.
Polling might be too fast?
Region: FRA

Can confirm CAN also experiences the same problem.

Can confirm too.
I've tried delaying the polling randomly between 2-10sec, still getting the issue after a while.

Pretty sure there is no solution to this issue until we obtain a new API key. I’m assuming all the botters and people using similar programs all call using the same key.

Interestingly I have yet to see this issue at all agains't EN US. (Been running the updated version of nvidia-clerk for 3+ hours)

Can you post a screenshot/log file of the error you're getting as well?

Chrome instance shows
Rate limit exceeded for API_KEY [9485fa7b159e42edb08a83bde0d83dia]
Program returns
2020/09/22 09:09:06 Unable to unmarshal inventory response data.

Which release version are you using currently?

Well, I was using 1.2.
Just pulled 1.3, and it's been running for 2 minutes. You might have fixed it?

Experienced the issue on 1.3 after running for 10 minutes.

Hey, same error for me running 1.3
Also i have the exact same API key than Coveredz
That said, Discord notifications works perfectly with instant feedback

Interesting, hypothetically if this is true if you start to get throttled you should eventually see some requests succeed again? Looking at other tooling that works similar to this they just attempt retries.

The version from yesterday just retried I think. The version you published today stops and crashes. Maybe that is the "issue"?

Interesting, hypothetically if this is true if you start to get throttled you should eventually see some requests succeed again? Looking at other tooling that works similar to this they just attempt retries.

The program stop after the rate limit error occur, so you have to manually restart everything

The version from yesterday just retried I think. The version you published today stops and crashes. Maybe that is the "issue"?

100% Correct, I'll get a fix out for this shortly (I moved from JSON deserialization to XML and forgot to handle this error apparently).

https://github.com/ianmarmour/nvidia-clerk/releases/tag/v1.5
Who want's to test (I tried the GBR stuff but still wasn't able to get it to trigger)

I'm currently testing 1.5

Auto refresh seems to work

It's working for me. I got the error but it retried and continued correctly. Thanks!

Awesome I'll wait for @Coveredz to actually close out the issue to make sure he see's the new release.

After 30 minutes it stopped refreshing, no error though, just stopped

Can confirm all good now, cheers for the fast fix 👍
@Altris001 Probably unlinked to this issue, mine didn't hang as of now. Suggest opening different ticket if it persists.

Just a visual bug with cmd.exe probably, press enter to see terminal updates is the browser still refreshing if so it's all working properly still.

After 30 minutes it stopped refreshing, no error though, just stopped

I'm trying again to see if this happen a second time


Socketing is broken

Hi there,
I'm right clicking while holding a Socket Gem in my hand and nothing happens. Note this is happening after i got the socket from drop so Socketing is enabled in config.

You need to then right click with the item you want to put the socket on in your hand.


Sfvip Player not found

When i launch sfvip all, it says that it didn't found sfvip player, and when i click on download, it does nothing.

Same problem....

same problem for me too

yes me too


Improve granularity of logging search actions

Summary of Changes
This PR aims to introduce better granularity of logging search user actions.
Why is this needed?
At the moment search logging is handled purely by the action logging tied to the search endpoints in Flask. We log the methods the endpoint was called with, which include search_term and page_index, as well as filters if we are using the query string endpoint.
However because multiple users actions like search bar usage, filtering, & pagination can trigger a search, we do not have any insight into actual user behaviors when it comes to search. For example we cannot easily answer the question "Did the user re-execute a search, or did they just add a filter?" without looking at diffs between logs of the same user and applying assumptions.
Option 1
We can pass a new parameter search_type in every search request from the React application to be logged. This value will specify what kind of search was executed. i.e. update_filter, update_page, update_term, automatic (in the case of inlinesearch). This information would be passed from the redux middleware based on the action that was fired.
Pros:

Our log information will contain a full picture of what was executed as the keyword args will contain every piece of information passed to the search service, now also with a specific search_type
Knowledge of what to log and when to log it will be abstracted away from the component logic, meaning that when writing new components or modifying existing ones does not require having context on what action to fire + what exactly needs to be logged. Components can continue to be written only with an understanding of what actions should be fired.

Cons:

The only con I can think of if the implementation. Our search sagas could potentially be restructured for an easier implementation.

Option 2
We can log an action in the component more granular commands such as search:update_filter, search:pagination.
Pros:

This approach has straightforward implementation of calling logAction in the component whereever it is necessary.

Cons:

Components only have knowledge of the information they were modifying so these logs will not provide context of the full search input. We have logs that have the full search information but no context of what the user did, and will be creating new that have context of what the user did but do not have the full search input information.

Tests
TBD based on approach
Documentation
TBD based on approach
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes, including screenshots of any UI changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes all tests documented in the developer guide

@danwom please prioritize the final filter feature branch PR review based on your bandwidth this week, but I could also use your thoughts on this to come to consensus before investing more work effort.
You will see here I found myself needing to include -- at minimum -- the information that was modified by the user interaction, such as search_term. This because some of our insights relies on having that information in the keyword arguments for the log. I then realized this approach limits the information we can log about the search, because the only place where we have access to the full search input is in the Redux layer and not the components.
If the problem we have to solve is "log the full context of the search to know exactly what is happening", I am now much more convinced the best approach for this case is to update the update the saga logic such that a search_type is passed to the Flask endpoint to be logged. The caveat if that our sagas have to be structured properly and we must ensure that certain sagas are only to be triggered by certain flows.

Latest commit covers the second approach which I currently prefer. It:

Fully deprecates the old logic for for searchings tables
Logs a search_type on all resource endpoints
searchAll and searchResource sagas now require a searchType to be passed for logging, and the appropriate "first-layer" sagas have been updated to include an appropriate search type. Current values are automatic, searchbar, filter, pagination, and external_page_view.

Will wait for comment before pushing updated tests. Also slowly making attempt to establish a clear saga hierarchy in the code.

Use https://github.com/lyft/amundsenfrontendlibrary/pull/396


sct_pipeline: status=1 instead of 200 if label file is missing

When running sct_pipeline -f sct_register_to_template -d $PATH_DATA -p \"-i t2/t2.nii.gz -s t2/t2_seg_manual.nii.gz -l t2/labels.nii.gz -igt ${SCT_DIR}/data/PAM50/template/PAM50_cord.nii.gz\" -pickle 1 -test-integrity 1 -j 127, if "t2/labels.nii.gz" is missing, output status =1 (crash) whereas it should be 200 (file missing).

sct_pipeline has been replaced by sct_run_batch. Closing. :)


Fix Flake8 violations

Master failed: https://circleci.com/gh/astronomer/astronomer-airflow-scripts/22

[#x1B[34m2020-11-18 12:15:46,697#x1B[0m] {#x1B[34mapplication.py:#x1B[0m297} INFO#x1B[0m - Reporting errors#x1B[0m
/home/circleci/project/astronomer/migration_spinner/command_line.py:34:36: F523 '...'.format(...) has unused arguments at position(s): 1
[#x1B[34m2020-11-18 12:15:46,698#x1B[0m] {#x1B[34mapplication.py:#x1B[0m303} INFO#x1B[0m - Found a total of 1 violations and reported 1#x1B[0m

Whoops yeah


hookpoints or way to manipulate compiled css

is there a way to manipulate the output css before it gets saved?
i implement an autoprefixer and think about how i can manipulate the compiled css, so for now my workflow is hardcoded in Compiler.php method compile()
if (statement) {
    $out = do something;
}
return $out;

maybe there is a better way to dothis?

Maybe add methods to the Formatter?

hm i take a look and give it a try.


Add control-label class to label

This class is used only by horizontal-form. But it doesn't affect other layouts. So it's the simplest possible solution.
However a condition could be added which checks if the form helper has a form_class set to 'form-vertical'.

Of course I meant form_class set to "form-horizontal" not "form-vertical". Sorry for the error.

Thanks for the patch @bitrut
I understood what you meant, no worries :) As control-label doesn't affect other layouts, I agree with you this is the simplest and cleanest. It just got merged in and I've added you to CONTRIBUTORS. I will be releasing version 1.1.2 today with several template fixes, including this.
Cheers,
Miguel

Cool. Thanks for your efforts on this project.

Thanks :)

Just a note, that might be something that should be documented at some point in time, this also works with the following in cases where you want to render your own formtag:
helper.form_tag = False


TypeScript support

I don't use TypeScript myself, but it appears popular in the wider Svelte community. I'd appreciate getting a definition file that would provide type annotations for TypeScript users.

JSDocs were added in the recent v2.1.0 release, providing partial TypeScript support, but I'm still interested in a more complete solution. In addition to accepting pull requests, I'm now offering to work on this myself in exchange for sponsoring me.

If interested I have a recent utility NPM package that generates TS declarations from ESM source code. You can easily setup an NPM script to generate the types via the prepublishOnly script or whatever is clever.
The package is here: @typhonjs-build-test/esm-d-ts.
The package itself uses the NPM script method
I haven't bumped this package to "beta" yet, but it is working well and makes it easy to generate TS declarations from ESM source.

@typhonrt I'm not clear on how that's an improvement over the status quo. TypeScript can directly use the existing JSDocs.

You can set a types field in package.json pointing to the d.ts file. This will show up on NPM as the package having TS definitions. Small benefit there.
Not that this applies for your package, but if you are bundling a package with Rollup, etc. providing the d.ts file is useful in that case. That is particularly why I built the tool.

Released in version 2.1.3, thanks to @qu1ncyk! 🎉


Studio Pro 9.11 introduces updatable microflow

@johannahemminger please do a language review here and see if you can identify why the PR build is failing


How can I get Emilia_ZH_EN_pinyin/duration.json？

Checks

[X] This template is only for usage issues encountered.
[X] I have thoroughly reviewed the project documentation but couldn't find information to solve my problem.
[X] I have searched for existing issues, including closed ones, and couldn't find a solution.
[X] I confirm that I am using English to submit this report in order to facilitate communication.

Environment Details
CUDA Version: 12.0；torch 2.0.1+cu118；Python 3.10.15
Steps to Reproduce
Create a new conda environment.
Clone the repository and install as pip package.
Run the command: f5-tts_training with test_train.py.
Stuck there with the following message... (FileNotFoundError: [Errno 2] No such file or directory: 'data/Emilia_ZH_EN_pinyin/duration.json').
✔ Expected Behavior
I download EN-B000024.tar on https://huggingface.co/datasets/amphion/Emilia-Dataset/tree/main and try to train the model with test_train.py file，but it reports an error about duration.json file.I want to know where can I find this duration.json or what's the format of it,Thank you!
Loading dataset ...
Trying to load dataset from: data/Emilia_ZH_EN_pinyin/raw
Traceback (most recent call last):
File "/home/F5-TTS/test_train.py", line 91, in
main()
File "/home/F5-TTS/test_train.py", line 84, in main
train_dataset = load_dataset(dataset_name, tokenizer, mel_spec_kwargs=mel_spec_kwargs)
File "/home/F5-TTS/model/dataset.py", line 210, in load_dataset
with open(f"data/{dataset_name}_{tokenizer}/duration.json", 'r', encoding='utf-8') as f:
FileNotFoundError: [Errno 2] No such file or directory: 'data/Emilia_ZH_EN_pinyin/duration.json'
❌ Actual Behavior
FileNotFoundError: [Errno 2] No such file or directory: 'data/Emilia_ZH_EN_pinyin/duration.json'

I have thoroughly reviewed the project documentation but couldn't find information to solve my problem.

pls check

using English to submit this report in order to facilitate communication.


Unhandled Exception ff version <IP_ADDRESS>9 pre

Description
First thank you for this awesome library .
i'm using FFImageLoading in my project, i was trying to improve the listview performance by updating to last ffimageloading version , but i got an unhadled exception.
Steps to Reproduce
just update ffimageloading to the last version,<IP_ADDRESS>9-pre
Expected Behavior
better performance
Actual Behavior
application crash on loading screen with "System.MethodAccessException: Method FFImageLoading.Forms.CachedImage.set_IsRendererInitialized(bool)' is inaccessible from method FFImageLoading.Forms.Platform.CachedImageRenderer.Init(System.Nullable`1)'" exception
Basic Information
-xamarin forms <IP_ADDRESS>2510
-ffImageLoading <IP_ADDRESS>9 pre
Screenshots

Please make sure:

You have the same FFImageLoading version in all projects
Remove all bin/obj folders & rebuild

that doesn't fix it

I'm quite sure you have different library dll versions colliding somewhere (between projects)

i just updatedto the stable <IP_ADDRESS>3 and it works fine

Have same issue

@maherzaidoune  I have used <IP_ADDRESS>3 version also still not resolved.

@AditCygnet   it works for  me, with  the last xamarin stable release

It's not an FFImageLoading issue but rather Visual Studio's issue. The key is to remove all cached files (like obj, bin folders. I'll close this one.


Fix chunkloading problems w/ Fastcraft

I know NEIDs is currently incompatible with FC 1.21. Crashes haven't occured in 1.22c11 or c13. However, chunkloading is horrendous across both versions. I have contacted Player to see if the problem is on his end or not.

I removed comments from commits (commits not for discussions). Use this issue for discussion.

Got it.

yay =P

Woohoo! Any signs of a release soon?

Please test it with large modpack:
https://drive.google.com/file/d/0B0GYhmakgvItS0l6c2pKSFQ0dVU/view?usp=sharing
https://drive.google.com/file/d/0B0GYhmakgvItTUVaZVU1MW5sZm8/view?usp=sharing
(Yes, now 2 files.)

Tested with RR w/258 mods, frames issues.

What are your PC specs? Are you getting low framerate or framerate drops?

list of mods pls.

Drops. I don't know my specs exactly.

Fastcraft compatibility is live. @Solarstrike if you still experience issues with FPS, open a new issue with following information:

Computer specs
List of mods (Printscreen your mods folder and upload screenshot to imgur or other pic website)
An .zip archive with mods and config folder.
If it applies only to existing world, upload your world folder.

Reopen on account of #16.

Fastcraft compatibility still working, it's just need an update. Not need to reopen this.


Initial support for adding codegen for interaction model

Problem
Interaction model is merged but not enabled.

Summary of Changes
This PR implemented ZAP templates and some necessary API in device and controller to support interaction model.
Testing

Build chip-device-controller and linux lighting app with new interaction model enabled.
Useful snippet for device controller:
./gn_build.sh chip_devctrl_use_interation_model=true chip_app_use_interation_model=true && (yes | sudo pip3 uninstall chip) && sudo pip3 install ./out/debug/linux_arm64_clang/controller/python/chip-0.0-cp38-cp38-linux_aarch64.whl

Build linux lighting app:
gn gen out --args="chip_app_use_interation_model=true" && ninja -C out
1.5 Config IPv6 address on device running controller and device running lighting app

Run chip-device-controller and linux lighting app

In chip-device-controller, run:

connect -ip fd12::2 12345678
zcl OnOff Toggle 12344321 1 0

Fixes #4253

Size diff reports 4K extra code and 1K extra BSS. Are these size diffs expected?

Size diff reports 4K extra code and 1K extra BSS. Are these size diffs expected?

Hi, @mspang @andy31415 , comments are resolved in newer commits

Hi, @mspang @andy31415 , comments are resolved in newer commits

Size diff reports 4K extra code and 1K extra BSS. Are these size diffs expected?

No, this is not expected, I will do some research on the symbols to see the cause of size increase

Size diff reports 4K extra code and 1K extra BSS. Are these size diffs expected?

No, this is not expected, I will do some research on the symbols to see the cause of size increase

Size diff reports 4K extra code and 1K extra BSS. Are these size diffs expected?

After making diff of the symbol table, the 1K extra BSS comes from the gExchange object, and the 4k extra code are all exchange manager realted code.

Size diff reports 4K extra code and 1K extra BSS. Are these size diffs expected?

After making diff of the symbol table, the 1K extra BSS comes from the gExchange object, and the 4k extra code are all exchange manager realted code.

@vivien-apple any more comments?

@vivien-apple any more comments?

@vivien-apple any more comments?

Is there reasons why this PR can't be split in 2 parts ?

One part that generate messages using the IM format
One part that handles the IM

I'm asking that because I'm fine with the part that generate the IM (I still have some review comments but the workflow is fine to me).
But I do have concerns about the part that handle the IM. It does bypass all the ZCL stack, back and forth, and I`m afraid that if we land it as if more work will be added on top of it that will makes it harder and harder to merge back.

@vivien-apple any more comments?

Is there reasons why this PR can't be split in 2 parts ?

One part that generate messages using the IM format
One part that handles the IM

I'm asking that because I'm fine with the part that generate the IM (I still have some review comments but the workflow is fine to me).
But I do have concerns about the part that handle the IM. It does bypass all the ZCL stack, back and forth, and I`m afraid that if we land it as if more work will be added on top of it that will makes it harder and harder to merge back.

@vivien-apple any more comments?

Is there reasons why this PR can't be split in 2 parts ?

One part that generate messages using the IM format
One part that handles the IM

I'm asking that because I'm fine with the part that generate the IM (I still have some review comments but the workflow is fine to me).
But I do have concerns about the part that handle the IM. It does bypass all the ZCL stack, back and forth, and I`m afraid that if we land it as if more work will be added on top of it that will makes it harder and harder to merge back.

Imfact, this PR does not handle the IM messages, it just stopped at the unpacked TLV. (ad17020fb63aee6fc9511200b26c6beef563950c)

@vivien-apple any more comments?

Is there reasons why this PR can't be split in 2 parts ?

One part that generate messages using the IM format
One part that handles the IM

I'm asking that because I'm fine with the part that generate the IM (I still have some review comments but the workflow is fine to me).
But I do have concerns about the part that handle the IM. It does bypass all the ZCL stack, back and forth, and I`m afraid that if we land it as if more work will be added on top of it that will makes it harder and harder to merge back.

Imfact, this PR does not handle the IM messages, it just stopped at the unpacked TLV. (ad17020fb63aee6fc9511200b26c6beef563950c)

@vivien-apple any more comments?

Is there reasons why this PR can't be split in 2 parts ?

One part that generate messages using the IM format
One part that handles the IM

I'm asking that because I'm fine with the part that generate the IM (I still have some review comments but the workflow is fine to me).
But I do have concerns about the part that handle the IM. It does bypass all the ZCL stack, back and forth, and I`m afraid that if we land it as if more work will be added on top of it that will makes it harder and harder to merge back.

The "handler" in your comments are just used for let others reproducing this PR, it does not make sense that one clone the PR to test IM related functions but no app can make use of it.

@vivien-apple any more comments?

Is there reasons why this PR can't be split in 2 parts ?

One part that generate messages using the IM format
One part that handles the IM

I'm asking that because I'm fine with the part that generate the IM (I still have some review comments but the workflow is fine to me).
But I do have concerns about the part that handle the IM. It does bypass all the ZCL stack, back and forth, and I`m afraid that if we land it as if more work will be added on top of it that will makes it harder and harder to merge back.

The "handler" in your comments are just used for let others reproducing this PR, it does not make sense that one clone the PR to test IM related functions but no app can make use of it.

According to conversations with @vivien-apple , I will submit another PR as a follow up, in that PR, I will add DispatchSingleCommand(clusterid, commandId, role, tlvReader, commandObj) to replace InteractionModelEngine::ProcessCommand (and this will remove the std::map in InteractionModelEngine, and modify related tests.

According to conversations with @vivien-apple , I will submit another PR as a follow up, in that PR, I will add DispatchSingleCommand(clusterid, commandId, role, tlvReader, commandObj) to replace InteractionModelEngine::ProcessCommand (and this will remove the std::map in InteractionModelEngine, and modify related tests.

@vivien-apple Please approve or left comment so we can move forward.

@vivien-apple Please approve or left comment so we can move forward.

@vivien-apple any more comments?

Is there reasons why this PR can't be split in 2 parts ?

One part that generate messages using the IM format
One part that handles the IM

I'm asking that because I'm fine with the part that generate the IM (I still have some review comments but the workflow is fine to me).
But I do have concerns about the part that handle the IM. It does bypass all the ZCL stack, back and forth, and I`m afraid that if we land it as if more work will be added on top of it that will makes it harder and harder to merge back.

The "handler" in your comments are just used for let others reproducing this PR, it does not make sense to me that one clone the PR to test IM related functions but no app can make use of it.

My issue is that the handlers are not "just" letting other reproduce/test IM related functions. They do have an impact on how the code of this PR is organised and I think that's partly why the discussion is going back and forth.
On a side note, and this is my personal opinion, a PR is just a mechanism to get an atomic unit of code in the tree, and I don't think one should attach any kind of "project" goals to a single PR.  Smaller changes are easier to produce, easier to review, and easier to fix if it ends up breaking the tree. That's purely a personal opinion and I do understand that you may disagree !

@vivien-apple any more comments?

Is there reasons why this PR can't be split in 2 parts ?

One part that generate messages using the IM format
One part that handles the IM

I'm asking that because I'm fine with the part that generate the IM (I still have some review comments but the workflow is fine to me).
But I do have concerns about the part that handle the IM. It does bypass all the ZCL stack, back and forth, and I`m afraid that if we land it as if more work will be added on top of it that will makes it harder and harder to merge back.

The "handler" in your comments are just used for let others reproducing this PR, it does not make sense to me that one clone the PR to test IM related functions but no app can make use of it.

My issue is that the handlers are not "just" letting other reproduce/test IM related functions. They do have an impact on how the code of this PR is organised and I think that's partly why the discussion is going back and forth.
On a side note, and this is my personal opinion, a PR is just a mechanism to get an atomic unit of code in the tree, and I don't think one should attach any kind of "project" goals to a single PR.  Smaller changes are easier to produce, easier to review, and easier to fix if it ends up breaking the tree. That's purely a personal opinion and I do understand that you may disagree !

@vivien-apple PTAL

@vivien-apple PTAL

@mspang, are your comments all resolved?

@mspang, are your comments all resolved?


Updated SEI on cracks example

Description
Updated plots in SEI on cracks example notebook to improve visibility

@DrSOKane In the updated notebook, all the lines in the plots sit on top of each other. Is this intended?

Ok I just wanted to make sure since the change was changing the plotting styles, but then the plots also changed

Ok I just wanted to make sure since the change was changing the plotting styles, but then the plots also changed

What happened was the code got changed, but the plots never updated. So now I've re-run the code to get the plots right.


Tests fail with Russian locale

Coverage increased (+0.06%) to 90.324% when pulling d7efee199592bdab09626a15fa8fe9153828b420 on artdol:patch-1 into f52c3da7170c9d1379d3bb2efd5b305bc62aa96c on akheron:master.

Jansson should work with any locale. What error did you get?

@artdol could you let us know what error you get without this change?


Bump node to 18

Was able to build and install locally but so far unable to connect to KeeWeb from extension when built from this branch.

Well for some reason tonight when I rebuilt it now it's working :sweat_smile:

Got to love when that happens.
FYI, as of today's changes, ensure your environment uses only one of the following NodeJS versions:

^18.12.0
^20.9.0
>=22.0.0

If KeeWeb is built on any other version; there will be dependency errors and things will break.
Is this PR completely done now?

I'd like to test the chrome extension but haven't yet. That's it

Having trouble connecting to Chrome with local built extension. I think it may be due to the extension ID being different but updating https://github.com/keeweb/keeweb/blob/master/desktop/scripts/const/extension-ids.js and running keeweb locally doesn't solve it for me.

Still not working with node 16 or 18 on master branch, last tag, or this branch. I'm clearly missing something.

@antelle sorry to bug you but do you have any thoughts on what I might be missing here running chrome/chromium extension locally and connecting to keeweb desktop? Firefox works but in Chromium I get no logs in the desktop console which leads me to believe it's not receiving any messages at all. The background extension console says KeeWeb host disconnected Specified native messaging host not found.

Do you have the messaging host config enabled? When you check the checkbox in settings in KeeWeb, it creates the config, but I assume it has a wrong extension ID there

OK I'm not sure why but I got it working on a different computer running Pop OS 22.04 so I'm going to say this is working OK with Firefox and Chrome.

I also successfully tested edge

Did you get all of it working now? I still need to mess with this to get a feel for it. But I'll have to do it after I finish up the stuff with KeeWeb. Don't want to start flip-flopping.

Yeah it's working locally. There does appear to be a validation issue when trying to publish the Firefox addon but I have a separate PR for that

NIce, progress. I'll definitely look into these plugins after I wrap up my end. I spend half my time reading pages of code so that I know what all is done in that segment, trying to get myself familiarized with this app like I would my own. Mainly prepping myself for the Electron v14+ migration since a lot has changed, and I don't want ti keep us running on v13 for too long.


perf(zk): remove redundant assignment

Description
Since acc is contained in a register, addition can be done through 1 instruction. If you do +=, it returns a pointer, so on return inside lambda of std::accumulate, when assigning to acc, more instructions are needed such as loading address and copying values of pointer.

I checked in https://godbolt.org/z/4oojG6fM9 but it turns out that the compiled outputs actually are same. Sorry but for me it seems still better!

LGTM


openapi-generator-cli: 5.0.0 -> 5.1.0

Motivation for this change
Update to latest release.
Works with passthru.tests from https://github.com/NixOS/nixpkgs/pull/119405 as well. (not included here)
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 121900 at 89fffee7 run on x86_64-linux 1

1 package built successfully:

openapi-generator-cli

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/tools/networking/openapi-generator-cli/default.nix:20:3:
   |
20 |   installPhase = ''
   |   ^

Result of nixpkgs-review pr 121900 at [89fffee]

1 suggestion:

Already done in the other PR.


Table accessibility issues

There are a few issues with the aria roles on the current table implementation:

role="grid" should be an attribute on the table element instead of the inner grid
all table rows (including the header row) should have role="row" even if they don't have event handlers like onRowClick

See aria documentation for more details. Elements with role="grid" require descendants with role="row", and elements with role="rowheader" require an ancestor with role="row" which requires an ancestor with role="grid".

Want to submit a PR?
On Mar 4, 2017 12:03 AM, "Jackie Chen"<EMAIL_ADDRESS>wrote:

There are a few issues with the aria roles on the current table
implementation:

role="grid" should be an attribute on the table element instead of
the inner grid
all table rows (including the header row) should have role="row"
even if they don't have event handlers like onRowClick

See aria documentation https://www.w3.org/TR/wai-aria/roles#grid for
more details. Elements with role="grid" require descendants with
role="row", and elements with role="rowheader" require an ancestor with
role="row" which requires an ancestor with role="grid".
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bvaughn/react-virtualized/issues/606, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AABzna-nD3yxjenVvdUzE8XkbCUytE9Kks5riRrlgaJpZM4MTBEn
.

Elements with role="grid" require descendants with role="row"

I think you mean to say that elements with role="row" require an ancestor with role="grid" ? Grid is, by default, a role="grid" but it does not contain role="row" children (because there is no "row" element in Grid).
I also wonder if it would be appropriate to set role for a Grid inside of a Table to "rowgroup" (instead of null).

Thanks for taking the time to educate me on the incorrect use of roles in this case. I really appreciate the PR! I just merged it, with the small addition of adding role="rowgroup" to the Grid inside of a Table. 😄

Re: your comment about Grid having no role="row" children, I believe elements with role="grid" do require descendants with role="row" or role="rowgroup" because they are "Required Owned Elements". I've been using the Accessibility Developer Tools chrome extension and the audit complains when there is only an element with role="grid".
Thanks for the quick review and role="rowgroup" change!

Is there a way how to not add these attributes? You have it wrong and even if that was implemented correctly it's not always what you want, which is our case.
Role grid must be sued only when it's a data grid with implemented keyboard navigation. Using such roles without implementing the rest hurts the accessibility.
I strongly suggest removal of the role grid and I would like to know the motivation behind adding it. This is how to use it properly and believe me, that's not what you wan't in many cases.
https://www.w3.org/TR/wai-aria-practices/examples/grid/dataGrids.html
https://www.w3.org/TR/wai-aria-practices/examples/grid/dataGrids.html


[Migrated] request to change prints to logging or remove them

Originally from: https://github.com/Miserlou/Zappa/issues/2142 by akobig
Hi, I admire the zappa project and use it as my serverless platfrom. one thing that bugs me is the "Instancing.." print
zappa/handler.py
...
55 | print("Instancing..")
...
zappa/handler.py:
...
378 | print("Result of %s:" % whole_function)
379 | print(result)
...
I will appreciate removing or changing that line to debug log. tnx.

I agree, logging should be used in place of print.

marking as duplicate of:
https://github.com/zappa/Zappa/issues/677


[Runtime] Fix concurrent lookups of types by name (again).

Fix a potential false positive if we check a class for a protocol conformance and its superclasses aren't yet instantiated.
This was partially fixed before, but we were incorrectly saying that all superclasses had been instantiated if they had been instatiated by the LAST check in conformsToProtocol. That left us open for a possible false positive in an earlier check to go unnoticed.
This change fixes it by checking for uninstantiated superclasses after each iteration over superclasses, not just the last one.
This change also makes the concurrentTypeByName test much more robust. The original test caught this bug only rarely, but the new one catches it it reliably. We now look up 1000 types per test run. Testing locally, we typically hit the race after less than 100 types.
rdar://82364236

@swift-ci please test

Only took me a year, NBD.

@swift-ci please test and merge


HDDS-2954. Support admin groups

What changes were proposed in this pull request?
Two new properties have been added to support admin groups:

"ozone.administrators.groups"
"ozone.recon.administrators.groups"

These properties are somewhat similar to existing "ozone.administrators" and  "ozone.recon.administrators" (hence the naming) but specify groups the user is directly or indirectly a part of.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2954
How was this patch tested?
unit tests and manual testing

Thanks for the patch @Cyrill . Would you fix the PR title and checkstyle?

@smengcl @Galsza, can anybody approve workflows for the latest changes, please?

@Cyrill this integration test failure looks related:
Error:  Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 49.054 s <<< FAILURE! - in org.apache.hadoop.ozone.om.TestOMDbCheckpointServlet
Error:  org.apache.hadoop.ozone.om.TestOMDbCheckpointServlet.testSpnegoEnabled  Time elapsed: 22.015 s  <<< FAILURE!
Argument(s) are different! Wanted:
httpServletResponse.setStatus(403);
-> at org.apache.hadoop.ozone.om.TestOMDbCheckpointServlet.testSpnegoEnabled(TestOMDbCheckpointServlet.java:234)
Actual invocations have different arguments:
httpServletResponse.setStatus(500);
-> at org.apache.hadoop.hdds.utils.DBCheckpointServlet.doGet(DBCheckpointServlet.java:113)

	at org.apache.hadoop.ozone.om.TestOMDbCheckpointServlet.testSpnegoEnabled(TestOMDbCheckpointServlet.java:234)

https://github.com/apache/ozone/runs/7956795029?check_suite_focus=true#step:4:3098
Can you please check?
TestSecureOzoneCluster can be fixed by merging from master.  Please do that before/after your fix for TestOMDbCheckpointServlet, then push the two changes in a batch.

@adoroszlai with the latest updates from master different tests are now failing. I tried to investigate the reason of the failures but it looks like the pipeline does not collect any logs but SCM. I would be interested in OM and perhaps s3 gateway. Is there any chance to add them?

@adoroszlai Now that the verification tests results are green, can we proceed with reviewing and merging this PR?

Thanks @Cyrill for the patch, @Galsza, @myskov, @smengcl for reviews.


is it possible to run more pool than 1, if so can someone please put the modified text for coins.json here for a sample

is it possible to run more pool than 1, if so can someone please put the modified text for coins.json here for a sample

Did you mean config.json ?

good day yes

@david739 Yes, you can run many pools with 1 instance of MiningCore. This is a question, not a software BUG. Therefore I am converting this into a Discussion.
In the future, please only open a new Issue for problems related directly to the code itself. That is the purpose of opening new Issue; bugs, performance problems, etc. Not for feature requests, not for general questions, not for training you on how to use linux or database software, etc.
Thanks.


Add headers to KNOWN_ISSUES

PR summary
Since the headers parameters in the request bodies must be used as HeadersVar in Golang to prevent collision with the request headers (that are Headers in the Go-wrapped request), it is good to have a section about this different behavior in the KNOWN_ISSUES.
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the
Angular Commit Message Guidelines.
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[x] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Thanks for the reviews @vmatyusGitHub and @bessbd! I'm about to merge this!


fix #521

修复 Docker 下的 bug

Coverage decreased (-0.006%) to 40.285% when pulling 4b0cb840f57c4524f6e6d0e600ba91e185852614 on 40huo:develop into ffefb274b0e0ea178aee319ef06e14371004061e on wufeifei:develop.

Coverage decreased (-0.06%) to 40.23% when pulling 1fa751dcd9a17400031246707633bbe3eae7d385 on 40huo:develop into ffefb274b0e0ea178aee319ef06e14371004061e on wufeifei:develop.


Release Thaumcraft 6 open-source?

Since you’ve announced that you’re retiring from Minecraft modding (https://www.patreon.com/posts/sad-farewell-23967282,) do you think that you could release Thaumcraft 6’s source code so that the community can continue development, fix bugs and potentially port it to newer versions of Minecraft?
You’ve captured lightning in a bottle with this mod, and we are sad to see you go. Long live Azanor, long live Thaumcraft.

it would be a shame to lose mods in the future

It's been announced, and repeatedly noted, that KingLemming (of TeamCoFH), with Azanor's input and continued creative control, will be updating Thaumcraft into future versions.


Math to Maths please! (LOW priority)

Can “Math” be changed to “Maths” on the left hand menu? Obviously respecting internationalisation in case the system finds its way to an American audience?

fixed in #159


Rename

I need a better name for my blog than The Blog of Random.

Whateverland

Strictly Random
Hasard (random in French)
Juhuslik (random in Estonian)
Tychaia (random in Greek)
UnboundMind
HyperRandom

Renamed to "Infinitely Random"
Done in b14d5d1950e84716ccbc8638976a721747874655


Setting rootMargin in initSimpleImg doesn't seem to have any affect

In the global config via:
initSimpleImg({ rootMargin: '800px 800px 800px 800px'})
Nothing seems to change. Am I calling this incorrectly?
Thanks,
Dustin

Hey Dustin,
Simple image use Intersection Observer for image detection.
https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API
rootMargin
Margin around the root. Can have values similar to the CSS margin property, e.g. "10px 20px 30px 40px" (top, right, bottom, left). The values can be percentages. This set of values serves to grow or shrink each side of the root element's bounding box before computing intersections. Defaults to all zeros.
let me know if the above explanation make sense.
cheers
bill

Yah, that makes sense but I just haven't been able to get it to work. Am I calling the global config correctly?

Just played with this a little more. I can see an effect when I use something like:
initSimpleImg({ rootMargin: '-800px 0px -800px 0px'})
Which results in a much narrower window. But no matter how far I go in the positive direction, I can't seem to get it to load more than what is currently in view.
I now have a hunch that this is due to me using an overflow container. Do you know if it's possible to easily account for this in react-simple-img? Thanks!

hmmm everything is driven by interaction observer API with this package 🤔 can you try to set the threshold to be [0]?

how about try rootMargin: '80px 0px 80px 0px' instead of 800px

Same thing. Seems like I can only ever shrink the detection window with negative values.
A related issue is that iOS devices (I've so far only tested on an iPhone 5s) I can't seem to get any of the in-view images to load initially. It always requires a scroll (even the slightest triggers it). I'll submit another issue specifically for this one.

Were you ever able to replicate this on a div with overflow: scroll?


Adding link to Awesome Ktor

Adding link to "Awesome Ktor" to help beginners find other kind of resources than on Ktor Documentation.

Thank you for your contribution @mjovanc.
Your commit is merged, only changed the link title to "Community Resources" :)


Results panel won't show along side script

Can't get the results panel to stay pinned when I use dbeaver. Tried toggling and maximizing the results but still can't get it to show underneath the script. it creates a triangle type arrow to the right of the screen and I can press it and it will show the results in a maximized view.

I have a similar issue. When I started using DBeaver, I had the query on top and the results panel below the query, and all was well. While working on (or with) a lengthy query, I dragged the top of the results panel down, thinking the drag would stop when the panel was almost invisible, but the panel disappeared entirely. and since then I can display it only in maximized form. I do not want this. I want the original arrangement of panels back. Again, nothing I can find in the DBeaver UI has enabled me to restore the former layout since the results panel disappeared. (The setting illustrated above has no effect on the situation.)


Update Composer.json to laravel 9

Thank you for this, it's appreciated!
I merged it on master and will release a new version next week when the tests will be fixed (migration from Travis to GitHub Actions)

As promised, here is the release for Laravel 9 🙂
=> https://github.com/translation/laravel/releases/tag/v1.17


Added Swing app

Added Swing app main entry.
Added picocli to handle input arguments.
Added initialization of database.

Pull Request Test Coverage Report for Build #63
Details

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build #61:
0.0%

Covered Lines:
365

Relevant Lines:
365

💛  - Coveralls


Error generate-form-service.js

angular 6.0.2
node_modules/swagger-angular-generator/dist/forms/generate-form-service.js:74
Object.entries(schema).forEach(([paramName, param]) => {
^
TypeError: Cannot convert undefined or null to object
at Function.entries ()
at walkParamOrProp (node_modules/swagger-angular-generator/dist/forms/generate-form-service.js:74:12)
at makeField (node_modules/swagger-angular-generator/dist/forms/generate-form-service.js:115:24)
at Object.entries.forEach (node_modules/swagger-angular-generator/dist/forms/generate-form-service.js:85:33)
at Array.forEach ()
at walkParamOrProp (node_modules/swagger-angular-generator/dist/forms/generate-form-service.js:74:28)
at makeField (node_modules/swagger-angular-generator/dist/forms/generate-form-service.js:115:24)
at Object.entries.forEach (node_modules/swagger-angular-generator/dist/forms/generate-form-service.js:85:33)
at Array.forEach ()
at walkParamOrProp (node_modules/swagger-angular-generator/dist/forms/generate-form-service.js:74:28)
npm ERR! code ELIFECYCLE

Please try to install rxjs-compat. This repo still uses the RxJS 5 style of imports.

If it did not help, please, share a relevant part of the schema with us.


Python hash() isn't a reliable hash function (changes with every pyth…

…on invocation). Switching to hash lib and matching the xplat style of hashing

:shipit:


Configuration problem

Here is my launch.json
{
    "version": "0.2.0",
    "configurations": [
        {
            "jdkPath": "C:\\Software\\java\\JDK\\bin",
            "name": "Java",
            "type": "java",
            "request": "launch",
            "stopOnEntry": true,
            "cwd": "${fileDirname}",
            "startupClass": "${fileBasename}",
            "options": [
                "-classpath",
                "\"${fileDirname};.\""
            ]
        },
        {
            "jdkPath": "C:\\Software\\java\\JDK\\bin",
            "name": "Java Console App",
            "type": "java",
            "request": "launch",
            "stopOnEntry": true,
            "cwd": "${fileDirname}",
            "startupClass": "${fileBasename}",
            "options": [
                "-classpath",
                "\"${fileDirname};.\""
            ],
            "externalConsole": true
        }
    ]
}

I add "jdkPath" according to the Requirements, but the debugger still not working.
Hope help and more details about configuration.
(by the way, my English is shit... I'm a Chinese student)

Please could you describe the problem. Are any errors being displayed, if so what are they?

Thanks for your reply.
I recorded a .gif for explaining the problem.

I meet the same promble.

@HugHoo @hlxkurapika you solved this?

Will close. If problem persists please re-open.


PPU: Background

Codecov Report

Merging #21 into master will decrease coverage by 1.27%.
The diff coverage is 91.08%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   99.30%   98.03%   -1.28%
==========================================
  Files          28       29       +1
  Lines         724      867     +143
  Branches       94      133      +39
==========================================
+ Hits          719      850     +131
- Misses          4       16      +12
  Partials        1        1

Impacted Files
Coverage Δ

src/ppu/index.js
89.39% <86.40%> (-4.55%)
:arrow_down:

src/6502/cpu.js
100.00% <100.00%> (ø)

src/6502/instructions/operations/bitwise.js
100.00% <100.00%> (ø)

src/6502/instructions/operations/memory.js
100.00% <100.00%> (ø)

src/6502/instructions/operations/stack.js
100.00% <100.00%> (ø)

src/bus/index.js
100.00% <100.00%> (ø)

src/utils/bitfield.js
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06f0792...c6b92f2. Read the comment docs.


Ability to add column alias

Describe the feature
When defining a column for an external table, I would like to add metadata columns like metadata$filename, which are not correct column names.
Describe alternatives you've considered
I don't think there are any?
Additional context
I'm using Snowflake and stage tables have useful metadata that I would like to be in the external tables. At the moment I'm getting the error:
  'METADATA$FILE_LAST_MODIFIED' cannot be used as a column name for external tables.

I think it would be great to be able to add alias to column definition:
- name: metadata$file_content_key
  alias: file_content_key
  description: "Unique key for each file"
  data_type: varchar

Another use case I've run into is when the column name in the source file happens to be value, which Snowflake doesn't allow because of their external table value column. I'd like to alias this column name specifically.
{
 "key": {...},
 "value": {...},
 "meta": {...}
}

take a look at the enhancements i am proposing on this PR and let me know if this solves your needs.

Describe the feature
When defining a column for an external table, I would like to add metadata columns like metadata$filename, which are not correct column names.
Describe alternatives you've considered
I don't think there are any?
Additional context
I'm using Snowflake and stage tables have useful metadata that I would like to be in the external tables. At the moment I'm getting the error:
  'METADATA$FILE_LAST_MODIFIED' cannot be used as a column name for external tables.

I think it would be great to be able to add alias to column definition:
- name: metadata$file_content_key
  alias: file_content_key
  description: "Unique key for each file"
  data_type: varchar

Can you explain more about why you want to have the filename as a named column in the table when you can use the metadata$filename in a table? I am trying to understand the usecase better.


Missing unit tests for the events of the Pausable contract

The contract in contracts/lifecycle/Pausable does not have unit tests for the Paused and Unpaused events.

I'll work on this issue


ERROR: Failed CRC Check on received message.

Hello,
When I launch the demo , I got this error:
Monarco HAT: Failed CRC check on received message.
Buffer: ......
Can  you please help me? I'm using your fresh instalation with assembled monarco, just tried test.
Thanks in advance!

Hello,
this typcally results from multiple processes competing for the SPI bus at the same time. Are you sure there is no other program or service running, which might be trying to use the Monarco HAT in parallel to your Node-RED flow? E.g. the runtime core of REXYGEN (RexCore)?
Let me know.


tslint --test removes too many characters on replaceNode

Bug Report

TSLint version: v1.16.0
TypeScript version: 3.5.2
Running TSLint via: CLI

When testing a self written linter rule that is supposed to detect unsorted entries in a translation dictionary, tslint seems to remove more characters than asked to during the test run. This does not happen when applying the rule to an actual file.
Rule Code
import * as path from "path";
import * as Lint from "tslint";
import * as ts from "typescript";

function isTranslationConstantsFile(sourceFile: ts.SourceFile): boolean {
  const fileName = path.basename(sourceFile.fileName);

  return /translationConstants\w*\.ts/.test(fileName);
}

// tslint:disable max-classes-per-file
export class Rule extends Lint.Rules.AbstractRule {
  public static readonly FAILURE_STRING = "translation constants not sorted alphabetically";
  public static metadata: Lint.IRuleMetadata = {
    ruleName: "sorted-translation-constants",
    type: "formatting",
    description: "",
    optionsDescription: "",
    options: "",
    typescriptOnly: false,
    hasFix: true,
  };

  public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
    if (!isTranslationConstantsFile(sourceFile)) {
      return [];
    }
    return this.applyWithWalker(new Walker(sourceFile, Rule.metadata.ruleName, {}));
  }
}

function getLineEnding(content): string {
  const matched = content.match(/\r\n|\r|\n/);
  return matched || "\n";
}

function comparePropertyAssignmentNodesByName(
  node1: ts.PropertyAssignment,
  node2: ts.PropertyAssignment,
) {
  return node1.name.getText().localeCompare(node2.name.getText());
}

class Walker extends Lint.AbstractWalker<{}> {
  private fix: Lint.Replacement;
  private failureData: ts.Node[] = [];
  private propertyAssignments: ts.PropertyAssignment[] = [];
  private lastName: string | undefined = undefined;

  private getFix = (): Lint.Replacement => {
    if (!this.fix) {
      const lineEnding = getLineEnding(this.sourceFile.getText());

      this.propertyAssignments.sort(comparePropertyAssignmentNodesByName);

      const sortedPropertyAssignmentTexts = this.propertyAssignments.map(node => node.getText());
      const propertyAssignmentsList = sortedPropertyAssignmentTexts.join(`,${lineEnding}  `);
      const replacementText = `{${lineEnding}  ${propertyAssignmentsList},${lineEnding}}`;

      this.fix = Lint.Replacement.replaceNode(this.propertyAssignments[0].parent, replacementText);
    }

    return this.fix;
  };

  private checkNode = (node: ts.Node): void => {
    if (ts.isVariableDeclaration(node) && !node.getText().startsWith("translationConstants =")) {
      return;
    }

    if (ts.isPropertyAssignment(node)) {
      const nodeName = node.name.getText();

      if (this.lastName !== undefined) {
        if (nodeName.localeCompare(this.lastName) < 0) {
          this.failureData.push(node);
        }
      }

      this.propertyAssignments.push(node);
      this.lastName = nodeName;
    }
    ts.forEachChild(node, this.checkNode);
  };

  public walk = (sourceFile: ts.SourceFile): void => {
    ts.forEachChild(sourceFile, this.checkNode);
    this.failureData.map(node => this.addFailureAtNode(node, Rule.FAILURE_STRING, this.getFix()));
  };
}

TypeScript code being linted and fixed
lint test file:
const translationConstants = {
  a: "a",
  c: "c",
  b: "b",
  ~~~~~~ [translation constants not sorted alphabetically]
  d: "d",

  e: "e",
  f: "f",
  g: "g",
  h: "h",

  j: "j",
  i: "i",
  ~~~~~~ [translation constants not sorted alphabetically]
  k: "k",
  l: "l",
};Test

(The Test is just there to make the issue more visible)
fix test file:
const translationConstants = {
  a: "a",
  b: "b",
  c: "c",
  d: "d",
  e: "e",
  f: "f",
  g: "g",
  h: "h",
  i: "i",
  j: "j",
  k: "k",
  l: "l",
};Test

with tslint.json configuration:
{
  "rulesDirectory": ["../../../tslintRules"],
  "rules": {
    "sorted-translation-constants": true
  }
}

Actual behavior
test/tslintRules/sorted-translation-constants/translationConstantsMultipleBlocks.ts.lint: Failed!
Expected (from .fix file)
Actual (from TSLint)
  const translationConstants = {
    a: "a",
    b: "b",
    c: "c",
    d: "d",
    e: "e",
    f: "f",
    g: "g",
    h: "h",
    i: "i",
    j: "j",
    k: "k",
    l: "l",
}t};Test

As the color information is lost, in the last line }t is the actual output, while };Test is from the fix file.
Expected behavior
The fix passes.

💀 It's time! 💀
TSLint is deprecated and no longer accepting pull requests other than security fixes. See #4534. ☠
We recommend you instead use typescript-eslint to lint your TypeScript code with ESLint. ✅
👋 It was a pleasure open sourcing with you!

🤖 Beep boop! 👉  TSLint is deprecated 👈  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋