destroy project observations later

Current Project has_many :project_observations, :dependent => :destroy, which basically makes projects with a lot of observations (e.g. http://naturewatch.org.nz/projects/whau-catchment-life) impossible to delete, because deleting many thousands of observations takes longer than a request, so the request just times out.
This might require doing the entire project deletion in a delayed job, since if we do ProjectObservation deletion after Project deletion we'll probably have integrity issues.

Just a note, renamed the problematic project to
http://naturewatch.org.nz/projects/whau-catchment-life-delete-me
so that our users are totally clear about which one to use :-)

Had comments about the "Whau" name still being on the problematic project, so renamed again to
http://naturewatch.org.nz/projects/test-delete-me


Links did not work, I updated to the path that did

I think you ran into this while I was in the middle of the move to the new GH org for this project.  Since then I've updated the usages below:
Invoke-WebRequest psakezero.com | Invoke-Expression
iwr psakezero.com | iex

I'm going to close this one but thanks for taking the time on the PR!


Confirming model C120 works with no issue and should be added to compatible models list

Is your feature request related to a problem? Please describe.
No, confirming that model C120 is supported by this integration
Describe the solution you'd like
request to Update readme file and add C120 to list of compatible model

I just set up a c120 - and am unable to get the siren to work

updating the firmware will try again after

Added, thank you. Siren does not work on every model and its not possible to detect it.


Dynamically Modify the ApiKey Property

I am posting data to a C# v2 Sendgrid function from SPA’s.
Is there any way to dynamically modify the ApiKey property dynamically? I would like to use different ApiKey’s based on a where the post is coming from using a switch but I don’t see a way to access the ApiKey property. Thanks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 67219504-786d-cb28-da42-e36e227a1c8a
Version Independent ID: 9faa4531-ad36-7fda-c9e5-415aa2c5a400
Content: Azure Functions SendGrid bindings
Content Source: articles/azure-functions/functions-bindings-sendgrid.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Hi @Aurora7Sys Thank you for your feedback! We will review and update as appropriate.

@craigshoemaker can you please share your thoughts here?

cc: @KetanChawda-MSFT
@Aurora7Sys the way you want to approach this is to use runtime binding in order to assign the API dynamically. By using the IBinder interface you can control the instantiation of the SendGridAttribute which gives you the opportunity to decide which API key you want to use.
Here's an example:
using System;
using System.IO;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Mvc;
using Microsoft.Azure.WebJobs;
using Microsoft.Azure.WebJobs.Extensions.Http;
using Microsoft.AspNetCore.Http;
using Microsoft.Extensions.Logging;
using SendGrid.Helpers.Mail;
using Newtonsoft.Json;

namespace Demos
{
    public static class SendMessage
    {
        [FunctionName("SendMessage")]
        public static async Task<IActionResult> Run(
            [HttpTrigger(AuthorizationLevel.Function, "get", "post", Route = null)] HttpRequest req,
            //[SendGrid(ApiKey = "SendGridAPIKey")] out SendGridMessage message,
            IBinder binder,
            ILogger log)
        {
            IActionResult result;

            try
            {
                string key = req.Query["key"];
                string to = req.Query["to"];

                var sender = await binder.BindAsync<ICollector<SendGridMessage>>(new SendGridAttribute(){
                    ApiKey = key
                });

                string apiKey = Environment.GetEnvironmentVariable(key);

                var message = new SendGridMessage();
                message.From = new EmailAddress(Environment.GetEnvironmentVariable("EmailSender"));
                message.Subject = "Dynamic SendGrid API Key";
                message.HtmlContent = $"Using key: {apiKey.Substring(0, 5)}";
                message.AddTo(to);

                sender.Add(message);

                result = (ActionResult)new OkObjectResult("Message sent");
            }
            catch(Exception e)
            {
                log.LogError("Demos.SendMessage", e);
                result = new BadRequestObjectResult("Failed to send message");
            }

            return result;
        }
    }
}

This example is kept simple on purpose. In a production context, you likely do not want to pass the SendGrid API key name with the request.
In the real world you would probably determine the API key by doing a look up based on the recipient's email address or pass in some other data to help determine the API key within the function.
For a full working solution, please refer to this repo: Azure Functions Dynamic SendGrid API Key.
Ultimately this speaks to the need for more in-depth documentation on how to do more runtime binding, which is a priority on my backlog 😉

@craigshoemaker thank you very much. This is what I am looking for!
I will be looking up the key based on the origin of the post.
This makes for a very flexible and useful function. Great work!!!

Glad this helps, @Aurora7Sys!
For now I will ask to #please-close this issue. If you have any more questions, feel free to re-open the issue.


Add consumer distribution test for Failover subscription when update partitions

Motivation
Add consumer distribution test for Failover subscription when update partitions. This test is related to #6610
Modifications
Add unit test
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

Documentation

Does this pull request introduce a new feature? ( no)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


add team overview to "About" page

Section to the added to the “About” page (https://portal.hubmapconsortium.org/docs/about) above Software, below Contact:
https://docs.google.com/document/d/1WmwaDJUc2UxX8leWtw8E48bpyDUodzGuVhSGOuy6Wj4/edit?ts=5f58e7bc

@schwenk102 - would you please make the adjustments in the appropriate markdown file and submit a PR?

I fixed in #34. Closing.


Community name cannot be updated on admin panel

I made a mistake creating a community and wanted to change the name, but it did not let me do it. When I try do it via the edit pencil button on the admin panel community page, I get an error message saying that it failed to fetch as the system is expecting a string.

Also can't update badge name. Getting the same error:

@thewilkybarkid I made another mistake in creating the name of a community and instead of 'Photosynthesis' they want to be called 'Photosynthesis Journal Club'. I tried to update the name but got the same error

Can you change the name from the backend and see if this can be fixed? Thanks!


Implementing Magic number in Go

💥 Proposal
Implementing Magic number in Go.
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


Sample applications demonstrating AE/EE with Data Access API

Sample applications for AE/EE integrated with Data Access API

https://github.com/data-cube/agdc-v2-examples/tree/master/examples/analytics_execution_engine

Sample applications for AEL using the Data Access API

https://github.com/data-cube/agdc-v2-examples/tree/master/examples/ndexpr


Prepare version 3.5.3

New Pull Request Checklist

[x] I have read and understood the CONTRIBUTING guide

[x] I have read the Documentation

[x] I have searched for a similar pull request in the project and found none

[x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

[x] I have added the required tests to prove the fix/feature I am adding

[x] I have updated the documentation (if necessary)

[x] I have run the tests and they pass

[x] I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: ...
Pull Request Description
Publish the version 3.5.3 to be able to use swift 5
...

          1 Warning

:warning:
The CocoaPods podspec was modified but the Carthage project wasn’t. Did you forget to update the xcodeproj?

  Generated by :no_entry_sign: Danger

Codecov Report

Merging #1067 into master will increase coverage by 0.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
+ Coverage   37.52%   38.05%   +0.53%
==========================================
  Files          27       27
  Lines        3944     3944
==========================================
+ Hits         1480     1501      +21
+ Misses       2464     2443      -21

Impacted Files
Coverage Δ

Classes/DDOSLogger.m
61.53% <0%> (+40.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98f18d8...b227382. Read the comment docs.


Test custom images with pre-trained model

I have downloaded the pre-trained models and the huge dataset. Running the vectorization & visualization command with the SU3 dataset works. Now, I would like to test some of my own images with the pre-trained model to see how well it works. However, I'm not sure how to do that. How do I have to organize custom images and what command I have to run to evaluate the pre-trained model with these images?

I also tried to run the prediction command with the SU3 dataset.
python train.py --eval -d 0 -i default --from logs/pretrained-wireframe/checkpoint_latest.pth.tar logs/pretrained-wireframe/config.yaml

However, I'm getting the error that it cannot use a CUDA device. My older Nvidia graphics card is not compatible with cudatoolkit 10.x. But it looks like that the pre-trained model has somewhere saying inside that it wants to run things on CUDA, and not fall back on CPU.

Error log
Traceback (most recent call last):
  File "train.py", line 204, in
    main()
  File "train.py", line 124, in main
    checkpoint = torch.load(resume_from)
  File "/home/brakebein/anaconda3/envs/shapeunity/lib/python3.7/site-packages/torch/serialization.py", line 608, in load
    return _legacy_load(opened_file, map_location, pickle_module, **pickle_load_args)
  File "/home/brakebein/anaconda3/envs/shapeunity/lib/python3.7/site-packages/torch/serialization.py", line 787, in _legacy_load
    result = unpickler.load()
  File "/home/brakebein/anaconda3/envs/shapeunity/lib/python3.7/site-packages/torch/serialization.py", line 743, in persistent_load
    deserialized_objects[root_key] = restore_location(obj, location)
  File "/home/brakebein/anaconda3/envs/shapeunity/lib/python3.7/site-packages/torch/serialization.py", line 175, in default_restore_location
    result = fn(storage, location)
  File "/home/brakebein/anaconda3/envs/shapeunity/lib/python3.7/site-packages/torch/serialization.py", line 151, in _cuda_deserialize
    device = validate_cuda_device(location)
  File "/home/brakebein/anaconda3/envs/shapeunity/lib/python3.7/site-packages/torch/serialization.py", line 135, in validate_cuda_device
    raise RuntimeError('Attempting to deserialize object on a CUDA '
RuntimeError: Attempting to deserialize object on a CUDA device but torch.cuda.is_available() is False. If you are running on a CPU-only machine, please use torch.load with map_location=torch.device('cpu') to map your storages to the CPU.

So, my next thought was that I have to train the model by myself on the CPU. So, I need to run the training command:
python ./train.py -d 0,1,2,3 --identifier baseline config/hourglass.yaml

But there is the next error I cannot resolve. I tried it several times, but it always errors at the same image or data chunk (in the folder that has been created in logs, 3 npz files has been generated, and in viz, 000002_img.jpg has been generated but not the other files (see screenshot)).

logs/.../viz/000000600/

Error log
progress | sum    | jmap   | jdir   | lmap   | joff   | ldir   | dpth   | jdep   | speed
Running validation...                                                                            Traceback (most recent call last):
  File "./train.py", line 204, in
    main()
  File "./train.py", line 200, in main
    trainer.train()
  File "/media/brakebein/Daten4TB/projects/shapeunity/wireframe/trainer.py", line 260, in train
    self.train_epoch()
  File "/media/brakebein/Daten4TB/projects/shapeunity/wireframe/trainer.py", line 200, in train_epoch
    self.validate()
  File "/media/brakebein/Daten4TB/projects/shapeunity/wireframe/trainer.py", line 131, in validate
    self._plot_samples(i, index, H, target, f"{viz}/{index:06}")
  File "/media/brakebein/Daten4TB/projects/shapeunity/wireframe/trainer.py", line 225, in _plot_samples
    mask_target = target["jmap"][i].cpu()
IndexError: index 2 is out of bounds for dimension 0 with size 2

Of course, it would be better to avoid the training process. I just want to test some custom images on your pre-trained model, but it doesn't seem to be trivial. Any help is appreciated.

I still couldn't figure out how to test my own images with the pre-trained model. I would like to input a single image and see what wireframe it predicts.
Any hints or help would be appreciated.

Sorry for missing the issue. Currently testing 3rd images are not supported. If you really want to test it, you need to modify the evaluation script to add a new dataset that includes your images. You need to zero-fill the ground truth entry if they are not available.

Thanks for your response. So I guess anytime soon, you won't implement it to test 3rd images.
So, I will try to modify the script. To zero-fill the ground truth entries: do I just need to use the format of the json files that are accompanied with each image? Or do I need to care about the npz files as well?

I think you just need to fill the image. All other entries can be zero.

Hi @Brakebein may I know if you managed to get the testing on custom images to work?

@Brakebein Any updates on testing on custom images?

No, sorry. I finally tested their 2D approach (https://github.com/zhou13/lcnn) which was actually sufficient for me.

您好，我使用自己的数据测试成功了，具体思路为：首先，自己创建一个data/SU1/001文件夹，并在其中存放512*512的自定义png图片，将自定义图片按照0000/0001/0002的格式重命名；其次，将作者提供的数据(SU3)中的其他对应名称的非png图片数据复制粘贴到该文件夹中；最后，直接使用命令“python train.py --eval -d 0 -i default --from logs/pretrained-wireframe/checkpoint_latest.pth.tar logs/pretrained-wireframe/config.yaml”测试结果即可。


Start markdown

hey

hey

testing

testing2

This is an <h1> header, which is the largest
This is an <h2> header
This is an <h6> header, which is the smallest
$ npm i
install node modules


Optimization WIP

Addresses #2

[x] Improve compile times

[x] Do not download/require bindgen unnecessarily
[x] Eliminate unnecessary lazy_static

[X] ~Document bindings~ (deferred to issue #6)
[x] Make feature flags more coherent
[x] Fix mis/unused features
[x] Make bindgen no longer the default (use pre-generated bindings by default)
[ ] Reconsider Git submodule
[ ] Justify bindgen

Haven't had a chance to glance at this but this has some good info: https://users.rust-lang.org/t/help-creating-a-sys-crate/12624/3?u=m4b
I also didn't realize that pkgconfig doesn't work on windows :/
I think in that case we should probably build the bundled bindings unconditionally?

Build times (user seconds):

Commit
Clean build
Rebuild

Before bindgen (fcc8eaca8c9f95a5b3be005faa93d9421f707355)
3.6
0.6

Before PR (fd451e63490d03b40eb74edc535f95457c0ad079)
179
13

After PR (0c608ec87358cf73f068d064f21ae09466b98ec1)
28
5.8

**Does not include download time

@m4b it looks like Travis-CI is not building pull requests automatically, any idea how to enable this?

In reference to #2:

The feature flags aren't coherent - the lib.rs includes either the bundled or not-bundled depending on the feature flag, but use_system_capstone isn't reflected in this at all, nor is it depended on or dependent of the bundled flag

I purposely made these features independent:

use_bindgen (instead of using the pre-generated bindings)
use_system_capstone (instead of the bundled capstone library)

Why would we want to make the use_system_capstone dependent on use_bindgen?

@m4b In reference to #2:

None of the bindings are documented anymore!

I'm not even convinced this is a motivating usecase for the capstone bindings. As far as I know, the capstone ABI has been pretty rock-solid; I can't remember the last time it was changed, and I suspect it won't change anytime soon.

I think that agree that losing the documentation for the types/functions, however:

Hopefully bindgen will eventually re-add support for adding documentation comments for types. It was disabled because some C++ comments were not valid markdown. See [bindgen issue #800].(https://github.com/rust-lang-nursery/rust-bindgen/issues/800)
Bindgen now generates Rust union types (instead of the confusing BindgenUnions)
The bindgen-generated bindings are generated exactly as expected from the capstone headers. The capstone headers are the documentation.
The HTML documentation generated by cargo doc is very useful. Example: https://docs.rs/capstone-sys/0.3.0/capstone_sys/

Personally, I don't want to find and open and peruse the capstone headers; sure they're documentation I suppose, but they don't show up when browsing docs.rs, which was a really nice feature.
Considering they were previously, its just seems like a feature regression.
Even if we just copy-paste the old doc headers from 0.2 for the pre-generated bindings, I think its better.
E.g., this just is nicer from a user standpoint:

I don't really see the bindings being updated much since it now uses unions, which was probably the last stumbling block, yes? In that case it's probably safe to add the documentation to them, dunno.
On the other hand I can see how that's annoying and tediuous; but its sad to see them go, since they were there before, and it was easy to see what the functions and constants did, etc.
On other notes, since now emits unions, which I think was introduced in 1.19 (yes), and 1.18 won't work (which I just tried on)? We'll need to add that to the README, etc.
Otherwise, this looks 1000% better, great work!
I didn't understand why the compile time tripled, and then I realized the pre-generated bindings file was 8k :]

Should also add 1.19 is required for capstone-rs when this gets pushed

:( I just doc'd everything but i can't push to your branch

Haven't had a chance to glance at this but this has some good info: https://users.rust-lang.org/t/help-creating-a-sys-crate/12624/3?u=m4b
I also didn't realize that pkgconfig doesn't work on windows :/
I think in that case we should probably build the bundled bindings unconditionally?

That post has some good ideas.
We already:

Follow the convention for
a. statically linking the bundled capstone
b. dynamically linking the system capstone
Only write to $OUT_DIR
Run a single command to compile the bundled capstone
Keep a bundled copy of bindgen
Keep a pre-generated copy of the bindgen output

Maybe we should also:

Support Windows better. Luckily, pkg-config is only used when dynamically linking the system capstone, which is not the default. We can try to use the vcpkg crate (or some alternative). We could also state that we only support static linking for Windows. Luckily, the decision to use the bundled bindings is independent of the decision to use bindgen.

@m4b we need to automate the documentation step. I suppose the good news is that we don't need to write code that works in general--our code only needs to understand capstone's doc comments. Since we only need to "autodoc" code to run ourselves, we could even write the code in Python or shell script.
I agree that we should document Rust 1.19 or greater is required. I'll add it to the README.

@m4b I cherry-picked your doc commit and added some clarification as to the provenance of the documentation. Merging per your comment.

@tmfink want me to publish 0.5? Also did you increment the version to 0.5?

A release sounds good--I did not increment the version number.
On Aug 31, 2017 10:00 AM, "m4b"<EMAIL_ADDRESS>wrote:

@tmfink https://github.com/tmfink want me to publish 0.5? Also did you
increment the version to 0.5?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/capstone-rust/capstone-sys/pull/3#issuecomment-326358896,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFBYuAfVpV2OVNwh3VV7gkTxujLIB70rks5sduaPgaJpZM4PG5Zf
.

Ok can you just set to 0.5 and push to master.
Reply to this email directly, view it on GitHub
https://github.com/capstone-rust/capstone-sys/pull/3#issuecomment-326360441,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFBYuCZKrmVyt_lC8x3mvIrEBBIyfpmjks5sdufugaJpZM4PG5Zf
.

ok published, really great work @tmfink, compile times are slim, great defaults, and now has complete capstone bindings with some hacked documentation, literally 1000% better :)


Logout promise not getting fulfilled in some situations

Repro

Login
Wait for a while (not sure what the specific condition here is)
Click "Log-out of uProxy"

Expected
Get logged out
Actual
Nothing appears to happen
As far as I can tell, the promise returned by FreedomNetwork::logout is never getting resolved or rejected

@dborkan sounds a bit like something caused by XMPP disconnection bug... https://github.com/uProxy/uproxy/issues/270  ?

Will take a look, I think I've seen in the past that logout doesn't work right if you've hit #270 (been disconnected already but not realized it)

Cool, probably good to be robust either way. Maybe also need a catch (if
there is an error)?
On Thu, Feb 5, 2015 at 1:35 PM, dborkan<EMAIL_ADDRESS>wrote:

Will take a look, I think I've seen in the past that logout doesn't work
right if you've hit #270 https://github.com/uProxy/uproxy/issues/270
(been disconnected already but not realized it)
—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/issues/863#issuecomment-73100375.

--
Lucas Dixon | Google Ideas

Yeah, it's good to add .catch to our promises
On Thu Feb 05 2015 at 1:44:24 PM iislucas<EMAIL_ADDRESS>wrote:

Cool, probably good to be robust either way. Maybe also need a catch (if
there is an error)?
On Thu, Feb 5, 2015 at 1:35 PM, dborkan<EMAIL_ADDRESS>wrote:

Will take a look, I think I've seen in the past that logout doesn't work
right if you've hit #270 https://github.com/uProxy/uproxy/issues/270
(been disconnected already but not realized it)
—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/issues/863#issuecomment-73100375.

--
Lucas Dixon | Google Ideas
—
Reply to this email directly or view it on GitHub
https://github.com/uProxy/uproxy/issues/863#issuecomment-73101892.

Can anyone replicate this?  For me logout works every time.  In any case I can add catch statements to our logout promises in both the core and UI

We can't reproduce this anymore, but I've cleaned up the log out logic and a bit and added extra debugging in https://github.com/uProxy/uproxy/pull/1012.  I'll close this issue now and we can re-open if we see it again.


Critical bug on Polkassembly.

Hello all,
There is some critical bug happening on Polkassembly right now.
I am logged in as @rtti and have access to his profile/details.

Please look into this ASAP.
Thanks.

Hi,
We are fixing this asap! Thank you for flagging it :)

Fixed


Use different shapes to differentiate Java filetypes, methods and visibility levels

Depends on https://github.com/catppuccin/vscode-icons/issues/161.

Raised #113 to track the status of including visibility icons


KEDA not working with Redis and ScaleType: Job

KEDA not working with Redis and ScaleType: Job. Here is my configuration based on keda-redis sample (https://github.com/patnaikshekhar/KEDA-Redis-Sample)
apiVersion: keda.k8s.io/v1alpha1
kind: ScaledObject
metadata:
  name: redis-scaledobject
  namespace: keda-redis-test
spec:
  scaleType: job
  jobTargetRef:
    template:
      metadata:
        labels:
          service: keda-redis-test-node
      spec:
        containers:
        - image: patnaikshekhar/keda-redis-node:1
          name: consumer
          env:
          - name: REDIS_HOST
            value: redis-master.keda-redis-test.svc.cluster.local:6379
          - name: REDIS_PASSWORD
            valueFrom:
              secretKeyRef:
                name: redis
                key: redis-password
          - name: LIST_NAME
            value: mylist
  triggers:
  - type: redis
    metadata:
      address: REDIS_HOST # Required host:port format
      password: REDIS_PASSWORD
      listName: mylist # Required
      listLength: "5" # Required

Expected Behavior
When no messages are awaiting processing, no jobs are created.
When a message arrives on the queue, KEDA creates a job.
When the job starts running, it pulls a single message and processes it to completion.
As additional messages arrive, additional jobs are created. Each job processes a single message to completion.
Actual Behavior
no jobs are getting created
Steps to Reproduce the Problem

LPUSH mylist message1 message2 message3 message4 message5 message6
kubectl get jobs -n keda-redis-test -w

Specifications

Version: keda-1.1.0
Platform: mac, debian
Scaler(s): redis

@vigneshraaj Can you test  with the latest version to see if it's still an issue? It should be ok AFAIK.

It's working fine with the latest version (keda-1.4.1)


Add Support For Swift Package Manager

Hi,
Is there any chance that support can be added for the Swift Package Manger?
Thanks
John

in progress, #560


Begin simplifying and updating the Get-GateCount sample

This PR begins to simplify the gate count sample by splitting the one Program.cs into several files that are each easier to read, making outputting CSVs optional, and by consolidating common logic into a few extension methods.

Merging in now, with future work tracked in #203. Thanks!


Unit Testing

Add unit testing to the Tetris Library so that changes to the API do not have unforeseen consequences.
This bit me today while adding block shadows. Modifications to the Tetris API are currently very difficult to implement.
Advise using a project like ThrowTheSwitch/Unity for testing. Integration with GitHub CI should be completed too.

See #25 . This integrates the Unity Unit Testing framework. Still need to add robust tests of ttetrislib.

Somewhat a duplicate of #13 . This has been resolved to an acceptable degree for now. Expect adding more unit tests once code coverage metrics have been created.

Somewhat a duplicate of #13 . This has been resolved to an acceptable degree for now. Expect adding more unit tests once code coverage metrics have been created.


[release-2.3] Update squad mapping

Signed-off-by: Kevin Cormier<EMAIL_ADDRESS>

/retest

/test e2e-tests

/retest

/retest

I've updated our ClusterPool configuration, so if this run doesn't deploy anything we'll force this PR through.

I'm not sure what's going on here. Let's get it merged.


BMW integration doesn't work

Describe the issue
The BMW Android app seems to work OK, but in Home Assistant all BMW related entities are "Unavailable". For a short moment they were shown, but soon after that disappeared again.
Expected behavior
BMW entities visible.
Which Home Assistant version are you using?
2024.4.4
What was the last working version of Home Assistant Core?
No response
What is your region?
Rest of world
MyBMW website

[X] I can still successfully login to the BMW MyBMW website and the car status is available there.
[X] I have MyBMW enabled for my vehicle.

Number of cars

[ ] I have 2 or more cars linked to the MyBMW account.
[ ] I have a Mini vehicle linked to my account.

Output of bimmer_connected fingerprint
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response

The BMW api is down every now and then. I had the same issue this morning and now it's working again. The same behavior is seen in a HA Github issue. Closing this issue now, you can reopen if the problem is still there for you after a couple of hours.

BMW seems to have updated their API (and in the process being flaky again).
See https://github.com/home-assistant/core/issues/116145#issuecomment-2083640824.


Module is forcing cluster creation when updating cluster with secret encryption key

I have issues while updating the current cluster to use an Encryption key for secrets
I'm submitting a...

[x] bug report
[ ] feature request
[ ] support request - read the FAQ first!
[ ] kudos, thank you, warm fuzzy

What is the current behavior?
Currently, if supplying Encryption key for secrets module is forcing to recreate the cluster which is obviously causing the issue as a cluster with same name exists
  # module.eks.aws_eks_cluster.this[0] must be replaced
+/- resource "aws_eks_cluster" "this" {
      ~ arn                       = "arn:aws:eks:us-east-1:*******:cluster/test-eks-mytest-kapok" -> (known after apply)
      ~ certificate_authority     = [
          - {
              - data = "**********************"
            },
        ] -> (known after apply)
      ~ created_at                = "2021-02-18 14:45:16.33 +0000 UTC" -> (known after apply)
      - enabled_cluster_log_types = [] -> null
      ~ endpoint                  = "**********************" -> (known after apply)
      ~ id                        = "test-eks-mytest-kapok" -> (known after apply)
      ~ identity                  = [
          - {
              - oidc = [
                  - {
                      - issuer = "https://oidc.eks.us-east-1.amazonaws.com/id/**********************"
                    },
                ]
            },
        ] -> (known after apply)
        name                      = "test-eks-mytest-kapok"
      ~ platform_version          = "eks.5" -> (known after apply)
        role_arn                  = "arn:aws:iam::********:role/test-eks-mytest-kapok20210218144353497300000002"
      ~ status                    = "ACTIVE" -> (known after apply)
      ~ tags                      = {
          - "CostCenterCode" = "6779" -> null
          - "Department"     = "cloudengineering-us" -> null
            "Environment"    = "test"
            "GithubOrg"      = "terraform-aws-modules"
            "GithubRepo"     = "terraform-aws-eks"
          - "Manager"        = "gonzc" -> null
            "Owner"          = "kapok"
          - "OwnerEmailID"   =<EMAIL_ADDRESS>-> null
        }
        version                   = "1.17"

      + encryption_config { # forces replacement
          + resources = [
              + "secrets",
            ] # forces replacement

          + provider { # forces replacement
              + key_arn = "arn:aws:kms:us-east-1:********:key/789e115e-7934-4146-b896-46baafd33e19" # forces replacement
            }
        }

      ~ kubernetes_network_config {
          ~ service_ipv4_cidr = "<IP_ADDRESS>/16" -> (known after apply)
        }

        timeouts {
            create = "30m"
            delete = "15m"
        }

      ~ vpc_config {
          ~ cluster_security_group_id = "sg-086046380bf2d6706" -> (known after apply)
            endpoint_private_access   = false
            endpoint_public_access    = true
            public_access_cidrs       = [
                "<IP_ADDRESS>/0",
            ]
            security_group_ids        = [
                "sg-03d94cde957c15074",
            ]
            subnet_ids                = [
                "subnet-06b9356a56089ac3b",
                "subnet-0934a31b0f092dcf0",
                "subnet-0f43ae8446d5fbe60",
            ]
          ~ vpc_id                    = "vpc-0c2e790ccdda7a9c9" -> (known after apply)
        }
    }

Terraform Error:
module.eks.aws_eks_cluster.this[0]: Creating...

Error: error creating EKS Cluster (test-eks-mytest-kapok): ResourceInUseException: Cluster already exists with name: test-eks-mytest-kapok
{
RespMetadata: {
  StatusCode: 409,
  RequestID: "d7f0364c-c2a0-45c8-86ea-563f849079b7"
},
ClusterName: "test-eks-mytest-kapok",
Message_: "Cluster already exists with name: test-eks-mytest-kapok"
}

If this is a bug, how to reproduce? Please include a code sample if relevant.
Create eks cluster without encryption key for secrets and then try to update same cluster using module with passing encryption key and module will try to create new cluster instead of updating same cluster
What's the expected behavior?
Module should be able to update same cluster without forcing creation of new cluster
Are you able to fix this problem and submit a PR? Link here if you have already.
Environment details

Affected module version:14.0.0
OS:
Terraform version:0.14.6

Any other relevant info

@barryib Any thoughts on this ?

We also just got hit by the same issue. We had our cluster setup without the encryption config and now that we have added the config to use AWS KMS, but the module forces the replacement of the cluster and can not apply the Terraform configuration as it struggles with creating a new cluster with the same name as the old one.

Checking in the provider code looks like https://github.com/hashicorp/terraform-provider-aws/blob/master/aws/resource_aws_eks_cluster.go#L60 is causing the issue!!!
May be it's for the aws provider to fix it

This is a limitation of the EKS platform. You must enable the customer managed key at cluster creation:

...and do remember that, at the current juncture, you can only set this at the cluster creation time (that is, not supported via cluster config updates)

https://aws.amazon.com/blogs/containers/using-eks-encryption-provider-support-for-defense-in-depth/

https://aws.amazon.com/about-aws/whats-new/2021/03/amazon-eks-supports-adding-kms-envelope-encryption-to-existing-clusters/

So shall this be re-opened?

We hit this aswell now, works fine to modify the cluster in AWS Console after creation, but terraform wants to re-create the cluster

It has already been fixed in https://github.com/hashicorp/terraform-provider-aws/blob/v3.47.0/CHANGELOG.md#3470-june-24-2021.


Improve colours on stats page

https://blog.datawrapper.de/beautifulcolors/

Those commits implement a palette for the bars, but it does not yet conform to advice from the blog post linked above.


Discussion: SharePointDSC with non-englisch systems or ISOs

Lately there are a few issues focusing on localization troubles with non-english OSs or SharePoint installs - they are more or less related to #665.
The following issues are related to language issues or use ValueMaps, that will fail with non-english SharePoint setups (tbc.)

#954 with #825 (seems to be the most challenging)
#923
#922
#920
#947

Do we have a chance to switch to internal enums? These should be the same across environments.
For example:
namespace Microsoft.Office.Server.Administration
{
	[System.Flags]
	internal enum UserProfileApplicationUserRights : ulong
	{
		None = 0uL,
		UsePersonalFeatures = 1uL,
		CreatePersonalSite = 2uL,
		UseSocialFeatures = 4uL,
		UseMicrobloggingAndFollowing = 8uL,
		All = 15uL
	}
}

or in other cases the use of internal names (TypeNames) like @NikCharlebois introduced in #923.

Wouldn't it work to do something like this:
$culture = [System.Globalization.CultureInfo]::InvariantCulture
[System.Threading.Thread]::CurrentThread.CurrentUICulture = $culture
$security = Get-SPServiceApplication | Get-SPServiceApplicationSecurity -Admin
$security
This way I get out everything in US English on a Norwegian installation of SharePoint and Windows Server (Norwegian language packs applied on both products). Will this not also be true if you install for example Norwegian Windows Server and Norwegian SharePoint and no US English language packs as the neutral language is always included?

If you want to test this you can't execute the lines one by one. It must be all executed simultaneously for example inside a function.

I'm curious if this would work regardless of any english language pack available.
Like I mentioned in  https://github.com/PowerShell/SharePointDsc/issues/665#issue-269391450 some settings require to be set in the language the product was installed in. If we could find a way to map these values to english we would have solved several language/localization specific errors.

Linking to #947 which also is a language specific issue

For issue #920 I have found a way to retrieve the possible localized values. Do we have other examples, so I can check on my localized environment (Dutch) if I can find a way to retrieve those possible values?

@jensotto Your solution with changing the culture doesn't work in case of the SPResultSource. This code still outputs the localized names:
Add-PSSnapin Microsoft.SharePoint.PowerShell

$culture = [System.Globalization.CultureInfo]::InvariantCulture
[System.Threading.Thread]::CurrentThread.CurrentUICulture = $culture

$serviceApp = Get-SPEnterpriseSearchServiceApplication -Identity "Search Service Application"

$fedManager = New-Object Microsoft.Office.Server.Search.Administration.Query.FederationManager($serviceApp)
$providers = $fedManager.ListProviders()
$providers.Keys

@ykuijs I digged a bit into the code involved with getting this data, and it seems that there are no language transformation of the provider data. Everything is pulled directly from the database. I can't get the data in any other language than the original language that SharePoint was installed with (US English in my case). I don't understand why you get the localized names unless it ties directly to the original language SharePoint was installed with. If that's true there's no way to have SharePoint "translate" this to any other language, and my approach with changing the UI Culture will not work in this situation.

@jensotto I am using a Dutch version of Windows with a Dutch version of SharePoint, so I know for sure that everything that can be in Dutch will actually be in Dutch.
I just tested some more and created a new Managed Metadata service application. When running the following code, I got some worrying results:
$culture = [System.Globalization.CultureInfo]::InvariantCulture
[System.Threading.Thread]::CurrentThread.CurrentUICulture = $culture

$perms = Get-SPServiceApplication | Get-SPServiceApplicationSecurity

foreach ($perm in $perms)
{
    $perm.NamedAccessRights.Name
}

Leestoegang tot termenarchief
Leestoegang en beperkte schrijftoegang tot termenarchief
Volledige toegang tot termenarchief
Full Control
Full Control
Full Control
Full Control

When I don't first set the culture, everything is in Dutch. But when I do set the culture, only a few are converted into English. All MMS permission levels remain in the local language.
Note: When I use the -Admin parameter, all permissions are displayed in English.
Do you have the possibility to test this script on a Norwegian version of Windows/SharePoint?

 So we probably need to do the same as with the SPSearchResultSource for the permissions levels as well.
Out of curiosity: What is the language of the OS you are using?

And are you using a Norwegian version of the SharePoint install, or have you installed the English version with the Norwegian language pack?

I used a US English installation media for both SharePoint and the OS. I've installed a Norwegian language pack for both, and changed the display language to Norwegian for my user account.

I have updated SPServiceAppSecurity to validate the specified permission levels against the possible values from SharePoint. Will submit a PR shortly.


json-jwt allows bypass of identity checks via a sign/encryption

I am getting the error is it resolved in 1.16.6?

The json-jwt (aka JSON::JWT) gem versions 1.16.5 and below sometimes allows bypass of identity checks via a sign/encryption confusion attack. For example, JWE can sometimes be used to bypass
JSON::JWT.decode.

Not according to bundle-audit:
ruby-advisory-db:
  advisories:	877 advisories
  last updated:	2024-03-02 13:38:12 -0800
  commit:	973ee9391883d41454c48851116c774f1bfc78c8
Name: json-jwt
Version: 1.16.6
CVE: CVE-2023-51774
GHSA: GHSA-c8v6-786g-vjx6
Criticality: Unknown
URL: https://github.com/P3ngu1nW/CVE_Request/blob/main/novjson-jwt.md
Title: json-jwt allows bypass of identity checks via a sign/encryption confusion attack
Solution: remove or disable this gem until a patch is available!```

https://github.com/nov/json-jwt/issues/118#issuecomment-1975078892

@nov Yeah I see but the bundle audit still producing the warning CI run it for verification, can you also fix that?

Has v1.16.6 be released, I don't see it in https://github.com/nov/json-jwt/releases

The issue has been resolved by this PR #3876


Can someone explain how to do this?

How does one follow the directions left in the README.md ?
Can someone just explain it to me assuming I am a total imbecile when it comes to this time of stuff?
I am sorry to waste anyone's time with this.

I am especially confused with the "## Run" and "## Develop" steps.

This is the current results i have


Metadata seems to be missing

Bug Description
When I try to install it comes up as unknown.
pip install<EMAIL_ADDRESS>Steps to Reproduce
pip install<EMAIL_ADDRESS>Backtrace
Collecting<EMAIL_ADDRESS>  Cloning https://github.com/PyO3/pyo3.git (to revision v0.23.2) to /tmp/pip-req-build-s2iv13aq
  Running command git clone --filter=blob:none --quiet https://github.com/PyO3/pyo3.git /tmp/pip-req-build-s2iv13aq
  Running command git checkout -q a9678269d4742eb2cd5eda19d6935eaea44f693e
  Resolved https://github.com/PyO3/pyo3.git to commit a9678269d4742eb2cd5eda19d6935eaea44f693e
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: UNKNOWN
  Building wheel for UNKNOWN (pyproject.toml) ... done
  Created wheel for UNKNOWN: filename=UNKNOWN-0.0.0-py3-none-any.whl size=5649 sha256=08fdfea069c13d1752849a066acd828bb2e4759bfd2d6f723c0627eafe8451da
  Stored in directory: /tmp/pip-ephem-wheel-cache-j5t947jl/wheels/4e/cb/1e/0c0c9de8e26d14957e85ce2953049056abecd11392376ed5e4
Successfully built UNKNOWN
Installing collected packages: UNKNOWN
Successfully installed UNKNOWN-0.0.0

Your operating system and version
ubuntu 24.04
Your Python version (python --version)
3.13.0
Your Rust version (rustc --version)
rustc 1.83.0 (90b35a623 2024-11-26)
Your PyO3 version
23.2
How did you install python? Did you use a virtualenv?
****
Additional Info
also happens if I install locally

This isn't a Python package, it's not expected to be installed at all. pyo3 is used by python packages, but it itself is a Rust package.

Ok, I’m struggling to get transformers and qwen to use the latest version so I tried to install it directly after tweaking the toml for transformers.
Maybe am being thick but can’t get qwen and transformers to run on python 3.13, I thought the latest version would fix that.
Sent from Yahoo Mail for iPhone
On Monday, December 2, 2024, 1:17 pm, Lily Foote @.***> wrote:
Closed #4752 as completed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

For transformers, I think the dependency which would have PyO3 is tokenizers? You might be ok if you use a sufficiently new tokenizers release: https://github.com/huggingface/tokenizers/releases/tag/v0.20.2
Not sure about qwen, but the same applies; if you can figure out which dependency is using Rust/PyO3 then you can ask them to update to PyO3 0.22 for 3.13 (or 0.23 for 3.13t).


Added support for run artifacts

Resolves
Fixes #214
Description
Added run artifacts

This is ready for a review

@Brett-Parker resolved the failing test


📈 PaaS-friendly metrics

This PR tries to fix https://github.com/badges/shields/issues/3946 :-)
Current metrics

We are using https://github.com/siimon/prom-client to:

collect default metrics (CPU and memory usage, Node.js-specific metrics), https://metrics.shields.io/d/g_1B7zhik/prom-client-default-metrics
collect custom metrics, https://metrics.shields.io/d/aESRBSjmz/services?orgId=1

Each server expose metrics via /metrics resource, e.g. https://s0.servers.shields.io/metrics (the server is using self-signed SSL certificates)
https://prometheus.io is running at metrics.shields.io is used to fetch metrics from all servers (s0, s1, s2) every 15 seconds
https://grafana.com/grafana/ is running at metrics.shields.io and displays dashboard/charts with out metrics: http://metrics.shields.io
http://metrics.shields.io is namaged via https://github.com/platan/metrics-shields-io-config

Problem we want to solve
After moving to Heroku (or possibly other PaaS), we are not able to access metrics (/metrics endpoint) from specific instance.
Solution
Solution was proposed in this comment

Because the individual servers can't be reached externally, metrics will need to be generated on each server and sent to the metrics server.
This PR is implementation of this idea.

We are still using prom-client to collect all metrics (default + custom). No change in code is needed
All Shields servers convert metrics from returned by prom-client as a JSON to influx format and push it to metrics.shields.io/telegraf every 15 seconds
https://github.com/influxdata/telegraf is running at metrics.shields.io, it accepts metrics send by Shields servers in influx format, it is also converts metrics to prometheus format and expose them via HTTP, metrics expire in Telegraf after 20 seconds (Telegraf can expire metrics automatically, which pushgateway cannot)
Prometheus collect metrics from the Telegraf instance
Metrics are available in Grafana

Why converting to Influx format?
Currently Telegraf cannot accept metrics in Prometheus format in HTTP listener, but there are plans to add such feature.
How to identify instances?
Currently metrics are identified by 2 labels (can be observed at https://metrics.shields.io/d/g_1B7zhik/prom-client-default-metrics):

env - identifies service environment, value „shields-io-production” indicates http://shields.io
instance - identifies particular instance, values: „s0.shields-server.com:443”, „s1.shields-server.com:443” and „s2.shields-server.com:443”

Both labels are added to metrics by Prometheus, metrics in /metrics endpoint do not contain such information.
Now we have add information described above to metrics.
The instance value source can be set using public.metrics.influx.instanceIdFrom configuration property. 3 values are allowed:

env-var- a value will be read from an environment variable with a name defined by the public.metrics.influx.instanceIdEnvVarName configuration property
hostname - a value will be equal to https://nodejs.org/api/os.html#os_os_hostname. This value can be mapped using hostnameAliases`
random, e.g. fyytvm7el

The env value can be defined using public.metrics.influx.envLabel configuration property.
There is also a new configuration property public.metrics.prometheus.endpointEnabled, which allows to enable/disable the /metrics endpoint.
production (VPS at OVH)
We can leave current metrics as they are. But we can also use the new approach. This configuration should enable new metrics and disable the old one:
public:
  metrics:
    prometheus:
      endpointEnabled: false
    influx:
      enabled: true
      url: https://metrics.shields.io/telegraf
      timeoutMilliseconds: 1000
      intervalSeconds: 15
      instanceIdFrom: hostname
      envLabel:  shields-io-production
      hostnameAliases:
        vps71670: s0.servers.shields.io
        vps244529: s1.servers.shields.io
        vps117870: s2.servers.shields.io

+ INFLUX_USERNAME and INFLUX_PASSWORD environment variables.
The code below shows what os.hostname() returns at OVH metrics server:
m@vps580707:~$ hostname
vps580707
m@vps580707:~$ hostname -f
vps580707.ovh.net
m@vps580707:~$ cat hostname.js
const os = require('os');

console.log('hostname: ', os.hostname());
m@vps580707:~$ ./node-v12.16.1-linux-x64/bin/node hostname.js
hostname:  vps580707

I guess our servers should return vps71670, vps244529 and vps117870 for os.hostname() (https://github.com/badges/shields/blob/master/doc/production-hosting.md#badge-servers)
Heroku
I suggest to use https://devcenter.heroku.com/articles/dyno-metadata#dyno-metadata to identify instances.
HEROKU_DYNO_ID can be used as an instance id.
If we want to use Dyno metadata, we have to enable it.
In the staging app(https://shields-staging.herokuapp.com) and in review apps we can use app name (HEROKU_APP_NAME) as an env value. This will give values shields-staging and shields-staging-pr-XXXX. We can send metrics from all env (production, staging, review apps) to http://metrics.shields.io/.
Telegraf is already running at http://metrics.shields.io/ and at http://metrics-test.shields.platan.space (a separate instance I use for testing). Configuration can be found here. I already send some metric from my locally running app to https://metrics-test.shields.platan.space/d/g_1B7zhik/prom-client-default-metrics?orgId=1&from=1586112499614&to=1586113011638&var-env=development&var-instance=rpy2hz7cd
Follow ups:

break out the config into a separate module - https://github.com/badges/shields/pull/4874#discussion_r408379031

Messages

:book:
:sparkles: Thanks for your contribution to Shields, @platan!

  Generated by :no_entry_sign: dangerJS against 282ce88f61d069f947185bdbbb18e0801daaa52f

Metrics from https://shields-staging-pr-4874.herokuapp.com/ can be found in https://metrics-test.shields.platan.space/ (shields-staging-pr-4874 env).

Thanks @paulmelnikow for the review. I will apply your suggestions soon :-)

@paulmelnikow I think I fixed all issues. I will also update PR description.
I would like to enable dyno metadata in our staging/review apps. Is it OK for you that I will do it? https://devcenter.heroku.com/articles/dyno-metadata#usage

@paulmelnikow and @chris48s, thank you for the review 👍
Metrics from https://shields-staging.herokuapp.com are available at https://metrics.shields.io/d/g_1B7zhik/prom-client-default-metrics 🎉 (you have to change env to shields-staging) .

Glad to see this landed! Well done everyone :tada:

@platan Do you want to send me some credentials for the production server through Keybase? Or should I snag them from staging?

I created a separate user for the production. I send you credentials through Keybase.


Relative path issue

h1. Issue Description
Splitting out planning-poker into a separate repo has resulted in an issue with relative paths given the current project setup. On local, the root directory is the planning-poker director while in production the root directory is thorsent.github.io. I.E. paths such as /scripts/* in local need to be /planning-poker/scripts/* in production
h2. Possible Resolutions
I think the easiest fix would be to keep the paths coded appropriately for production, and have grunt copy the necessary files into a /planning-poker/ directory on local that is ignored by git.

So the problem was using absolute paths. Converting them to relative paths fixed it. I.E. /scripts/.js should just omit the leading slash to become "scripts/.js.
Fixed as of commit 0e077a7.
Closing Issue.


Handle a frozen dataset.data array.

Resolves #4157. I added a note to the documentation regarding the fact that frozen data will not support live updates.
Fiddle with v2.7.3
Fiddle with these changes

I just wondered if we should use Object.isExtensible because Object.seal and Object.preventExtensions will cause the same issue.

@nagix I updated to use Object.isExtensible() and added tests for the Object.seal() and Object.preventExtensions() cases.


fix mac_user create_user for running without full disk access

Signed-off-by: Gilbert Liu<EMAIL_ADDRESS>Moving mac_user create_user to use dscl to create user when running without full disk access
Description
The UID is different than what Chef specifies in the sysadminctl command, and this causes later Chef run to fail.
Running sysadminctl command on M1 Mac mini, both macOS 11.4 and 12.0, SIP on, default security level.
# sysadminctl -addUser svc -UID 30023 -shell /sbin/nologin -home /var/svc
2021-06-15 18:29:41.702 sysadminctl[64046:1889653] ----------------------------
2021-06-15 18:29:41.702 sysadminctl[64046:1889653] No clear text password or interactive option was specified (adduser, change/reset password will not allow user to use FDE) !
2021-06-15 18:29:41.702 sysadminctl[64046:1889653] ----------------------------
2021-06-15 18:29:41.748 sysadminctl[64046:1889653] Creating user record…
2021-06-15 18:29:41.796 sysadminctl[64046:1889653] Assigning UID: 30023 GID: 20
2021-06-15 18:29:41.813 sysadminctl[64046:1889653] ### Error:-14120 File:/System/Volumes/Data/SWE/macOS/BuildRoots/e90674e518/Library/Caches/com.apple.xbs/Sources/Admin/Admin-876/DSRecord.m Line:418
2021-06-15 18:29:41.841 sysadminctl[64046:1889653] Home directory is assigned (not created!) at /var/svc

# dscl . -read /Users/svc
...
NFSHomeDirectory: /var/svc
Password: ********
Picture:
/Library/User Pictures/Flowers/Lotus.tif
PrimaryGroupID: 20
RealName: svc
RecordName: svc
RecordType: dsRecTypeStandard:Users
UniqueID: 501
UserShell: /sbin/nologin

dscl . -create /Users/username UniqueID <UID> can create the user with specified UID. But because dscl does not create user homedir like sysadminctl, createhomedir will always run now.
Another caveat is createhomdir only works when the homedir path does not exist, and after setting GID for the user, or it will create nothing. Thus the block is moved to after setting user GID.
dscl cannot set secure token for user. The toggle_secure_token can handle this and is unchanged.
Related Issue
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

@lamont-granquist Could you take a look and let me know if you have any questions?

@lamont-granquist Thanks for approving. So this is ready to merge by someone authorized?

Regarding tests, I copied the file to overwrite the local one and ran chefctl -id twice: first when the users are not created and then with the users created. Both runs succeeded. Tested on 15.17.4.

@bunnypak I rebased this after fixing our current Test Kitchen testing for user creation on macOS. If this passes now that we have a working test again, I'll merge it.


An option to run in detached/daemon mode

Thank you for Overmind! It is great!
Would it be feasible to add a -d/--detach option that launches overmind but doesn't automatically show the output of all commands. I'd love to have overmind running in the background, keeping things alive without needing to keep it open. Right now what I do is start overmind in a tmux session and then disconnect from it to ensure it keeps going after I close my SSH connection.
overmind connect (with no arguments) could be used to bring that back to the foreground.
This could be as simple as starting the main output in a disconnected tmux session that would show up in tmux ls

Hi,
v2.0.3 supports daemonization. Use -D flag to run Overmind in daemon mode, echo command for echoing logs to STDOUT, and quit command for quitting daemonized Overmind.


Premature incompatibily errors in generic classes definitions

Here is simplified example:
class Task <x, a> {
  static spawn: <b> (task:Task<empty, b>) => Task<empty, b>
  spawn <b> ():Task<empty, b> {
    return Task.spawn(this)
  }
}

Here flow reports following error:
  6:     return Task.spawn(this)
                ^^^^^^^^^^^^^^^^ call of method `spawn`
  3: class Task <x, a> {
                 ^ x. This type is incompatible with
  4:   static spawn: <a, b> (task:Task<empty, a>) => Task<empty, b>
                                       ^^^^^ empty

What I actually expect is for flow to report type error when task.spawn() is called on tasks that can fail (Task<error, value>) and report no errors when called on tasks that can not fail (Task<empty, value>).

To be more clear this is a behavior I'm aiming for:
/* @flow */

class Task <x, a> {
  static succeed: <x, a> (value:a) => Task<x, a>
  static fail: <x, a> (error:x) => Task<x, a>
  static spawn: <a, b> (task:Task<empty, a>) => Task<empty, b>
}

Task.spawn(Task.succeed(4))
Task.spawn(Task.fail(4))

Which fails if failing task is spawn, but does not fail if succeeding task is spawn:
    10: Task.spawn(Task.fail(4))
                             ^ number. This type is incompatible with
    6:   static spawn: <a, b> (task:Task<empty, a>) => Task<empty, b>
                                         ^ empty

I just want to enable calling spawn as a method rather than static function.


Compressible agent tool calls

Why are these changes needed?
Add tool support to compressible agent

https://github.com/microsoft/autogen/pull/791
https://github.com/microsoft/autogen/pull/974

Related issue number

Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

@yenif Please take a look at #1024. Can you create a PR that adds generate_tool_reply (modify only client.py and conversable_agent.py only), and add a test for that?
This is changing the core functionalities and we will get more people to review this.

@kevin666aa that's this one https://github.com/microsoft/autogen/pull/974. This pr builds on that PR, so it appears to also include all the same changes until #974 is merged. Normally I'd chain the PRs to diff correctly, but it seems that is not possible on cross fork PRs.
#1005 then builds on this PR, thus it currently shows all of the changes for all 3 PRs

Codecov Report
Attention: 131 lines in your changes are missing coverage. Please review.

Comparison is base (a1e60e8) 26.53% compared to head (64af76a) 19.38%.
Report is 11 commits behind head on main.

Files
Patch %
Lines

autogen/agentchat/conversable_agent.py
18.91%
81 Missing and 9 partials :warning:

autogen/agentchat/contrib/compressible_agent.py
14.81%
21 Missing and 2 partials :warning:

autogen/token_count_utils.py
19.04%
17 Missing :warning:

autogen/oai/client.py
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1004      +/-   ##
==========================================
- Coverage   26.53%   19.38%   -7.15%
==========================================
  Files          28       28
  Lines        3807     3931     +124
  Branches      865      950      +85
==========================================
- Hits         1010      762     -248
- Misses       2726     3055     +329
- Partials       71      114      +43

Flag
Coverage Δ

unittests
19.33% <18.12%> (-7.15%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

I should be able to review this tonight for any updates now that converable tools are merged

Just have one question (might be minor) in my comment. Otherwise LGTM!

I'm not sure if we want to keep maintaining compressible agent. We want to ultimately implement compression as one agent capability similar to teachability. There is discussion in #1073. @kevin666aa @qingyun-wu please indicate who's the current owner  and what's your suggested plan.

I've been thinking about switching to a different strategy, so abandoning CompressibleAgent works for me.

@yenif @sonichi @kevin666aa @qingyun-wu If everyone agrees we can close this PR for now.


Built-in parsing system

Currently we are engaging with Map<String, String> for both insert and select (even that it returns a Map<String, dynamic>) queries. It's better to create some kind of built-in system to parse data to String and back from String based on column type.

Could you provide a pseudo code example of what you suggest? I don't really see what you mean in details

I still don't know what you mean but as it is related to types you can check #26 that presents the new type safe api to see what you think of this approach


Add a metadata table with which collections are in which schemas

Would be helpful to have a metadata views table in Kingfisher, auto populated by views creation, to map collection ids to view names.
Also helpful for this table to store who created it (name of analyst), when, expiration date if known and any other notes (instead of looking in each view for notes).
Use case 1: for any given collection, we can query what views have been generated on it ordered by creation date desc
Use case 2: set up a cron job to delete the views as expiration dates pass.
Use case 3: cross-collection queries - for each view, if we haven't already run a query on the collection ids it covers, and the expiration date hasn't passed, run a query on it.

Closed by https://github.com/open-contracting/kingfisher-summarize/pull/209


Malaria Monthly Routine Form Update

@alou, please work with MEASURE to define the agreed changes to the routine form.
I believe it includes:

PW can now have simple malaria cases.
ANC/SP modifications.

Specific issues have been created for this.


x/pkgsite: rember closed/open tree or make it URL-accessible

The old packages site at https://golang.org/pkg/ used to have the whole packages/subpackages tree expanded (and no way to collapse it). The new page for the same content (https://pkg.go.dev/std) defaults to the tree collapsed. While I understand the motivation for that, I am one of those (and I totally acknowledge that we may be a minority) that liked the full tree being visible by default. However, the site neither remembers the state of open/closed tree, nor does it allow me to have a bookmark that takes me to the page with the tree already in one or the other state.
On top of that, it's very easy to slightly miss the target of the small triangle to open a subtree and e.g. go to the io page instead of opening it to then go to ioutil. This is very frustrating, as once on the io page, I have to navigate back, scroll&find it again, and then carefully open the subtree, then click on ioutil. With the old page, or a pre-expanded tree, this would not happen.
I am aware of the "Expand All" functionality, but it is on the far-right side of the content container, and so inconvenient to use, especially on wide browser windows. My muscle memory anticipates the (old, open) tree on the left side of the page, so I'm always slightly disoriented when looking for the "Expand All" interaction.

This might not be exactly what you're looking for, but if you use a browser's find feature (command + f on a mac) the directories will expand. We could look into adding query param that expands the sections on page load for bookmarking as well.

We could look into adding query param that expands the sections on page load for bookmarking as well.

That would be plenty enough for me, since I mostly care about it when first navigating to the page, and I basically never toggle the expansion off, so remembering state is not strictly necessary.

After the next deploy the URL https://pkg.go.dev/std?expand-directories will render standard library page with an open directory tree.

After the next deploy (later today or tomorrow afternoon) the URL https://pkg.go.dev/std?expand-directories will render the standard library page with an open directory tree.

Fantastic, thank you!


constructor() class method keep's throwing an exception

The exception is:
*** ReferenceError: |this| used uninitialized in anonymous class constructor ***
When I create a class using:
xtag.create( class extends xtag.extensions(myExt){
constructor() { }
} );
It throws the error. When the constructor() method is not used it does not appear.  I believe it is a scoping problem.

I found another missed placed token in the script I was working on. @csuwildcat .
Thanks for all the help.


idea: cortex models list remote & downloaded models

Problem
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Users want to see what models are preconfigured and available via HF/cortexso
Users want to see what models are available to be used locally, they've already downloaded

Success Criteria
A clear and concise description of what you want to happen.
Not sure about this:
# List all available models , including remote models on cortexso available for download
cortex models list

# List models on device only (-l or some other flag)
cortex models --local

Additional context
Add any other context or screenshots about the feature request here.

I am deprecating this issue, as Cortex.cpp should not be handling remote model (this is a Jan Extension concern)


infructescence morphology trait (TO:0000920) and sub-classes.

Created new term:
infructescence anatomy and morphology trait (TO:0000920: A reproductive shoot system anatomy and morphology trait (TO:0000786 which is associated with an infructescence (PO:0006342.
Reported by: cooperl09
Original Ticket: obo/plant-trait-ontology-to-requests/244

Moved ear weight (TO:0000923) to be an ear infructescence morphology trait (TO:0000976), rather than an infructescence weight (TO: 0000583) trait, but kept infructescence weight as a 2nd parent.
Revised def'n: An ear infructescence morphology trait (TO:0000976) that is the weight of an ear infructescence (PO:0025597).


Flutter widget showing empty page when using addContentView from android activity

i am adding flutter to existing android app.
I have created new flutter module from android studio and included that module in my existing android app.
I’m using addContentView() to add flutter view to my activity.
After launching activity the screen shows blank. View is not showing up
Appreciate your help!!

Hi @bitfield66
can you please provide your flutter doctor -v and flutter run --verbose?
Also, to better address the issue, would be helpful if you could post a minimal code sample to reproduce the problem
Thank you

Solved this changing my module name to "app"

Hi @bitfield66
given your last message I feel safe to close this issue,
if you disagree please write in the comments and I will reopen it.
Thank you


snapshot: components no longer need to be copyable

Replaced calls to std::as_const with std::move so that components can
be moved into place instead of copied when reading them in from a
snapshot.

It occurs to me that this should probably have some tests to go along with it. I'll get to that in a bit. Adding tests turns out to be nontrivial because the existing tests assume copyability and updating it will take a bit of effort.

I'll get to that in a bit.

Ok. Ping me if you need help or when you get there. Thanks for contributing.
Also, feel free to add yourself to the list of contributors if you like (file AUTHORS). :+1:

Sorry for the delay, I have the tests working now. Since I can't store the component directly in the tuple of queues (as that would require a copy) I instead store the data that the non-copyable component contains, so that in can be reconstructed later.
I tried running the tests without the changes to snapshot.hpp, and it fails to build as expected. The new tests only compile and run if the std::as_const calls are replaced by std::move.
Let me know if there are any changes you'd like to make.

Sorry for the delay, I have the tests working now.

You've nothing to apologize for. This is an open source project. We do our best in our free time! :wink:

Let me know if there are any changes you'd like to make.

Don't worry. I'm merging it on branch experimental and making some changes there.
Thank you for pointing this out and for spending your time on it. Really appreciated! :+1:


Consider merging request-schema.json into a .py file

Hello,
I've hit a little issue when using jsonrpcserver with PyInstaller:
FileNotFoundError: [Errno 2] No such file or directory: `path-to\\jsonrpcserver\\request-schema.json'

I've submitted a simple hook for PyInstaller which fixes this but I've hit similar issues with python packaging and non-py files many times in the past and I suggest you consider moving the .json data into a .py file unless there's a good reason not to - it can be a new request_schema.py or any of existing files.
This would prevent similar problems with python packaging in various tools without requiring additional effort.
Either way, thanks for the nice library ♥

Yes, good idea. Can’t see any reason not to do this.

This would also avoid the warning that I get with python 3.12:
.../lib/python3.12/site-packages/jsonrpcserver/__init__.py:19: in <module>
    from .async_main import (
.../lib/python3.12/site-packages/jsonrpcserver/async_main.py:7: in <module>
    from .main import default_validator, default_deserializer
.../lib/python3.12/site-packages/jsonrpcserver/main.py:29: in <module>
    schema = json.loads(importlib.resources.read_text(__package__, "request-schema.json"))
/usr/lib/python3.12/importlib/resources/_legacy.py:25: in wrapper
    return func(*args, **kwargs)
/usr/lib/python3.12/importlib/resources/_legacy.py:79: in read_text
    with open_text(package, resource, encoding, errors) as fp:
/usr/lib/python3.12/importlib/resources/_legacy.py:18: in wrapper
    warnings.warn(
E   DeprecationWarning: open_text is deprecated. Use files() instead. Refer to https://importlib-resources.readthedocs.io/en/latest/using.html#migrating-from-legacy for migration advice.


Extra newline at the top

There is an extra newline at the top of every generated HTML file.

Fixed it up, turns out it was because of a newline I mistakenly added to the text var.


Help - Aliases

Command specific help can now be

Merged your fix with an update to prevent merge conflicts.


fix Transfer URI link w/ usd amount after address

In transfer, please add usdadmount after the address in pay me link
https://canary.kodadot.xyz/dot/transfer/?usdamount=20&target=12ZLwasAvpdxDiiMedr11VeKUyQkY3WfneMkswBCAHVvxAqe
->
https://canary.kodadot.xyz/dot/transfer/?target=12ZLwasAvpdxDiiMedr11VeKUyQkY3WfneMkswBCAHVvxAqe&usdamount=20

I think this is where it was introduced

https://github.com/kodadot/nft-gallery/pull/7288

I think this is where it was introduced

fix: Transfer does not respect token amount #7288

No, they are not related.


Added Calculator in JAVA under Basic Desktop Applications

Have you read the Contributing Guidelines ?
Yes
Description

Added Calculator under Basic Desktop Applications in JAVA
Made corresponding changes to README

Fixes #481

Checklist

[X] I've read the contribution guidelines.
[X] I've checked the issue list before deciding what to submit.
[X] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(#481)

Hi @Kushal997-das kindly look into my PR and let me know if any change is required

@photon149 Please check is this PR already exits in other repos or not ?
@abhilipsasahoo03 We found in your last 2 PR'S as a spam , you added same project in multiple repos. this is not acceptable by GSsOC22 so we removed the tags which we added .  Please make sure this PR is not exits in other Repos !

@photon149 Please check is this PR already exits in other repos or not ?
@abhilipsasahoo03 We found in your last 2 PR'S as a spam , you added same project in multiple repos. this is not acceptable by GSsOC22 so we removed the tags which we added .  Please make sure this PR is not exits in other Repos !

Hi @Kushal997-das I think there's a minute confusion. I submitted Instagram Login Page clone to two repositories before it was announced that it was unacceptable (also because I had seen many other participants doing the same). However, I haven't submitted Spotify Landing Page Clone to any other repository. Please let me know why it's marked duplicate.
Also, Calculator in JAVA has not been submitted to any other repository previously.

@prakhar 3062 Have a look .

@prakhar3062 @Kushal997-das @photon149 let me know if any other change is necessary

@Kushal997-das as of this project I don't seem to find any replicas in the GSSOC contributions.
So you can go ahead to check and merge the same.

@abhilipsasahoo03 Done !


[BUG] The float problem

Hello!
As you all know, converting string type to float makes the resulting number less accurate or can lead to some other side effects.
Please see it:
https://github.com/florianv/exchanger/blob/e47537909d6b5d6d5050308020d323e7b75e6176/src/ExchangeRate.php#L62
https://github.com/florianv/exchanger/blob/e47537909d6b5d6d5050308020d323e7b75e6176/src/Service/Cryptonator.php#L62
php -r "echo (string)0.00000050;" # prints 5.0E-7

I propose to make the resulting class accept only string. As a result, we'll get the course in its original form and let the developers not worry about it.

@florianv How soon can you approve the pull-request if I send it to you?

@TimurFlush We'll need to release a new major version for that, since it will break backward compatibility :/


Wizard's footer should have a configurable finish button

In my wizard implementation in https://github.com/fabric8-ui/fabric8-ui/tree/master/src/app/space/wizard for the forge app generator wizard I need to have both next ad finish button at the same time.

Next button to progress the wizard and go next step
Finish indicates you can end the wizard even if some optional step are left.

Since both fabric8-ui/fabric8-ui#1874 and fabric8-ui/fabric8-ui#182 have been closed, I'll close this issue.
As of now, the UX design does not provide a finish button. However, we can revisit this if the design for OSIO changes?


What is the appropriate use of localPartition

Given below is the TPC-H query 17 using velox I have come up with. except the last node, all the other nodes seem to give my expected outcomes.
     tables_referenced : {{"0", "lineitem"}, {"50", "part"}},
     columns_referenced :
         {{"lineitem", {"l_partkey", "l_quantity", "l_extendedprice"}},
          {"part", {"p_partkey", "p_brand", "p_container"}}},

       // ....
         auto lineitems = PlanBuilder(0)
           .tableScan(TPCHParquetReader::getTPCHRowTypeForQuery("lineitem", TPCHQueries::get(17)))
           .planNode();
         auto parts = PlanBuilder(50)
           .tableScan(TPCHParquetReader::getTPCHRowTypeForQuery("part", TPCHQueries::get(17)))
           .planNode();
         auto filtered_parts = PlanBuilder(1)
           .localPartition({0}, {parts})
           .filter("p_brand = 'Brand#23' AND p_container = 'MED BOX'")
           .planNode();
         auto joined = PlanBuilder(2)
             .localPartition({0}, {lineitems})
             .hashJoin({"l_partkey"}, {"p_partkey"}, filtered_parts,
                        "", {"l_partkey", "l_quantity", "l_extendedprice"})
             .planNode();
         auto quantity_by_part = PlanBuilder(3)
           .localPartition({0}, {joined})
           .partialAggregation({0}, {"avg(l_quantity)"})
           .finalAggregation({0}, {"avg(a0)"}, {DOUBLE()})
           .project({"l_partkey as q_partkey", "a0 * 0.2 AS quantity_threshold"})
           .planNode();
         return PlanBuilder(4)
           .localPartition({0}, {joined})
           .hashJoin({"l_partkey"}, {"q_partkey"}, quantity_by_part,
                      "", {"l_quantity", "l_extendedprice", "quantity_threshold"})
           //.filter("l_quantity < quantity_threshold")
           //.partialAggregation({}, {"sum(l_extendedprice)"})
           //.finalAggregation({}, {"sum(a0) AS avg_yearly"}, {DOUBLE()})
           .planNode();

       // ....

The last hashJoin between joined and quantity_by_part is giving the below error.
E0127 07:54:30.097587  6392 Exceptions.h:68] ../velox/exec/Task.cpp754createLocalExchangeSourceslocalExchanges_.find(planNodeId) == localExchanges_.end()Local exchange already exists: 2RUNTIMEINVALID_STATE
E0127 07:54:30.097777  6392 Exceptions.h:68] ../velox/exec/Task.cpp235removeDriverTrying to delete a Driver twice from its TaskRUNTIMEINVALID_STATE
terminate called after throwing an instance of 'facebook::velox::VeloxRuntimeError'
  what():  Exception: VeloxRuntimeError
Error Source: RUNTIME
Error Code: INVALID_STATE
Reason: Trying to delete a Driver twice from its Task

Any help/hints into how local partitioning works is greatly appreciated.

Would you check that the final plan doesn't have any duplicate plan node IDs. I suspect PlanBuilder(1), PlanBuilder(2), PlanBuilder(3) and PlanBuilder(4) would need to be changed to make a bit of space in between the IDs, e.g. PlanBuilder(10), PlanBuilder(20), PlanBuilder(30) and PlanBuilder(40).

Sure, will check and get back to you. I am not from DB world, sorry for naive question. What is reason behind such spacing ?

PlanBuilder is a helper class for building query plans for testing only. Internally, it generated plan node IDs as a sequence. By default, it starts with 0. If you use PlanBuilder two or more times in a single query plan, you'll end up with duplicate IDs. To avoid that, you can provide a starting plan node ID in the constructor, e.g. PlanBuilder(10) will make node IDs as 10, 11, 12, etc. You need to make sure you have enough space between starting plan node IDs, otherwise, you'll have duplicate IDs.

I have changed  the plan Ids, but I am hitting something different now.
  auto filtered_parts = PlanBuilder(50)
           .tableScan(TPCHParquetReader::getTPCHRowTypeForQuery("part", TPCHQueries::get(17)))
           .filter("p_brand = 'Brand#23' AND p_container = 'MED BOX'")
           .planNode();
         auto quantity_by_part = PlanBuilder(20)
           .localPartition({0}, {
             PlanBuilder(0)
               .tableScan(TPCHParquetReader::getTPCHRowTypeForQuery("lineitem", TPCHQueries::get(17)))
               .hashJoin({"l_partkey"}, {"p_partkey"}, filtered_parts,
                         "", {"l_partkey", "l_quantity"})
               //.partialAggregation({0}, {"avg(l_quantity)"})
               .planNode()})

The error says hash join on BitInt key is not supported, AFAIU. Is that true ? or I am doing something wrong here.
Running main() from /build/googletest-j5yxiC/googletest-1.10.0/googletest/src/gtest_main.cc
unknown file: Failure
C++ exception with description "Exception: VeloxUserError
Error Source: USER
Error Code: UNSUPPORTED
Reason: Unsupported filter in parquet reader: BigintValuesUsingHashTable: [2409, 199510] no nulls
Retriable: False
Function: toDuckDbFilter
File: ../velox/dwio/parquet/reader/ParquetReader.cpp

Thank you

Finally got it working with the following:
For every read, it requires additional fragment entry.
  {17, {
       idx: 17,
       tables_referenced : {
           {"0", "lineitem"}, {"50", "part"}, {"100", "lineitem"}, {"150", "part"}
       },
       columns_referenced :
         {{"lineitem", {"l_partkey", "l_quantity", "l_extendedprice"}},
          {"part", {"p_partkey", "p_brand", "p_container"}}},
       plan_builder: []() {
         auto qt = PlanBuilder(10)
             .localPartition({0}, {
                 PlanBuilder(0).
                     tableScan(TPCHParquetReader::getTPCHRowTypeForQuery("lineitem", TPCHQueries::get(17)))
                     .hashJoin({"l_partkey"}, {"p_partkey"},
                               PlanBuilder(50)
                                   .tableScan(TPCHParquetReader::getTPCHRowTypeForQuery("part", TPCHQueries::get(17)))
                                   .planNode(),
                               "p_brand = 'Brand#23' AND p_container = 'MED BOX'",
                               {"l_partkey", "l_quantity"})
                     .partialAggregation({0}, {"avg(l_quantity)"})
                     .planNode()})
             .finalAggregation({0}, {"avg(a0)"}, {DOUBLE()})
             .project({"l_partkey", "a0 * 0.2 as qt"})
             .planNode();
         return PlanBuilder(20)
             .localPartition({0}, {
                 PlanBuilder(100)
                     .tableScan(TPCHParquetReader::getTPCHRowTypeForQuery("lineitem", TPCHQueries::get(17)))
                     .hashJoin({"l_partkey"}, {"p_partkey"},
                               PlanBuilder(150)
                                   .tableScan(TPCHParquetReader::getTPCHRowTypeForQuery("part", TPCHQueries::get(17)))
                                   .planNode(),
                               "p_brand = 'Brand#23' AND p_container = 'MED BOX'",
                               {"l_partkey", "l_quantity", "l_extendedprice"})
                     .planNode()})
             .hashJoin({"l_partkey"}, {"l_partkey"}, qt, "",
                       {"l_quantity", "l_extendedprice", "qt"})
             .filter("l_quantity < qt")
             .partialAggregation({}, {"sum(l_extendedprice)"})
             .finalAggregation({}, {"sum(a0)"}, {DOUBLE()})
             .project({"a0 / 7.0 as avg_yearly"})
             .planNode();
       }
    }},

Thank you @mbasmanova

The error says hash join on BitInt key is not supported, AFAIU. Is that true ? or I am doing something wrong here.

Running main() from /build/googletest-j5yxiC/googletest-1.10.0/googletest/src/gtest_main.cc
unknown file: Failure
C++ exception with description "Exception: VeloxUserError
Error Source: USER
Error Code: UNSUPPORTED
Reason: Unsupported filter in parquet reader: BigintValuesUsingHashTable: [2409, 199510] no nulls
Retriable: False
Function: toDuckDbFilter
File: ../velox/dwio/parquet/reader/ParquetReader.cpp

This is a limitation of Parquet reader that @majetideepak has reported earlier. We can fix it by adding support for BigintValuesUsingHashTable filter to toDuckDbFilter function in velox/dwio/parquet/reader/ParquetReader.cpp
My guess is that this filter is generated dynamically by selective hash join and is being pushed down adaptively during runtime. See https://facebookincubator.github.io/velox/develop/joins.html#dynamic-filter-pushdown


[BUG FIX] WIndows install to correct issue #199

Description
This change correct issue with how the install resource was managing the windows install. Currently it is trying to unzip an archive that isn't named correctly. It was also trying to unzip to a directory that didn't exist so, the powershell_script block was failing silently. Also, when the archive was being moved, it was moving a folder full of files with version specific naming, this was causing the path being set to fail as well.

Added steps to create proper unzip directory in c:\habitat
Corrected the name of the zip archive to be current
Changed how the powershell_script block moves file so that is steps in an extra directory and the path gets set correctly.
Added step to clean up file_cache_path

Issues Resolved
Hab install fails on Windows because it can't find the directory #199
Check List

[x] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

     Synchronizing Cookbooks:
         - cb_habloader (0.1.0)
         - habitat (1.5.1)
         - windows (6.0.1)
       Installing Cookbook Gems:
       Compiling Cookbooks...
       Converging 4 resources
       Recipe: cb_habloader::default
         * hab_install[install habitat] action install
           * remote_file[C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/hab-x86_64-windows.zip] action create
             - create new file C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/hab-x86_64-windows.zip
             - update content in file C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/hab-x86_64-windows.zip from none to 344c14
             (new content is binary, diff output suppressed)
           * archive_file[hab-x86_64-windows.zip] action extract
             - create directory C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/habitat
             - extract C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/hab-x86_64-windows.zip to C:/Users/vagrant/AppData/Local/Temp/kitchen/cache/habitat
           * directory[c:\habitat] action create
             - create new directory c:\habitat
           * powershell_script[installing from archive] action run
             - execute "C:\Windows\system32\WindowsPowerShell\v1.0\powershell.exe" -NoLogo -NonInteractive -NoProfile -ExecutionPolicy Bypass -InputFormat None -File "C:/Users/vagrant/AppData/Local/Temp/chef-script20200207-2936-1uzte63.ps1"
           * windows_path[C:\habitat] action add
             * windows_env[path] action modify

           * execute[hab license accept] action run
             - execute hab license accept

         * hab_sup_windows[Test-run] action run
           * hab_install[Test-run] action install (up to date)
           * hab_package[core/hab-sup] action install
             - install version 1.5.0 of package core/hab-sup
           * hab_package[core/hab-launcher] action install
             - install version 13013 of package core/hab-launcher
           * windows_env[HAB_AUTH_TOKEN] action delete (up to date)
           * windows_env[HAB_SUP_GATEWAY_AUTH_TOKEN] action delete (up to date)
           * hab_package[core/windows-service] action install
             - install version 0.6.0 of package core/windows-service
           * execute[hab pkg exec core/windows-service install] action run (skipped due to not_if)
           * template[C:/hab/svc/windows-service/HabService.exe.config] action create
             - create new file C:/hab/svc/windows-service/HabService.exe.config
             - update content in file C:/hab/svc/windows-service/HabService.exe.config from none to 9a053c
             --- C:/hab/svc/windows-service/HabService.exe.config       2020-02-07 18:28:25.429546700 +0000
             +++ C:/hab/svc/windows-service/chef-HabService20200207-2936-8pjxds.exe.config      2020-02-07 18:28:25.429546700 +0000
             @@ -1 +1,32 @@
             +<?xml version="1.0" encoding="utf-8"?>
             +<configuration>
             +  <configSections>
             +    <section name="log4net" type="log4net.Config.Log4NetConfigurationSectionHandler, log4net"/>
             +  </configSections>
             +  <startup>
             +    <supportedRuntime version="v4.0.30319"/>
             +  </startup>
             +  <log4net>
             +    <root>
             +      <level value="ALL" />
             +      <appender-ref ref="RollingFileAppender" />
             +    </root>
             +    <appender name="RollingFileAppender" type="log4net.Appender.RollingFileAppender">
             +      <file value="logs\Habitat.log" />
             +      <appendToFile value="true" />
             +      <rollingStyle value="Size" />
             +      <maxSizeRollBackups value="10" />
             +      <maximumFileSize value="100MB" />
             +      <staticLogFileName value="true" />
             +      <layout type="log4net.Layout.PatternLayout">
             +        <conversionPattern value="%date - %message%newline" />
             +      </layout>
             +    </appender>
             +  </log4net>
             +  <appSettings>
             +    <add key="debug" value="false" />
             +    <add key="HAB_FEAT_IGNORE_SIGNALS" value="true" />
             +    <add key="launcherArgs" value="--no-color " />
             +  </appSettings>
             +</configuration>
           * windows_service[Habitat] action enable (up to date)
           * windows_service[Habitat] action start
             - start service windows_service[Habitat]
           * windows_service[Habitat] action restart
             - restart service windows_service[Habitat]

       Recipe: cb_habloader::services
         * hab_package[core/7zip] action install
           - install version 16.04/20190523094208 of package core/7zip
         * hab_service[core/sqlserver] action load
           - update core/sqlserver
           -   set strategy to :"at-once" (was :none)
           * execute[hab svc load core/sqlserver --binding-mode strict --url https://bldr.habitat.sh --channel stable --group default --strategy at-once --topology standalone --health-check-interval 30 --shutdown-timeout 8 --remote-sup <IP_ADDRESS>:9632] action run
             - execute hab svc load core/sqlserver --binding-mode strict --url https://bldr.habitat.sh --channel stable --group default --strategy at-once --topology standalone --health-check-interval 30 --shutdown-timeout 8 --remote-sup <IP_ADDRESS>:9632

The 2 linting failures are not something I can correct. They are related to sysvinit and if the version is changed in the spec test, it will be a version that does not support sysvinit by default


Finalize Gambling Phase and test the game flow without Actin'

No need to finalize the Gambling phase.


SharePoint with MS Graph and V2.0 token

I enhanced class ZCL_ADF_SERVICE_GRAPH and corresponding interface by adding methods for SharePoint. Also I added some documentation and a sample report demonstrating the usage.
I'm not sure why it also changed so many DDIC elements. It might because we use different version of abapGit? We're running on S/4 HANA 2020 FP1, maybe this causes the differences.
Maybe you can cherry-pick the real changes?

Thank you for sharing @PaddyCube! We will review within the next 2 weeks. Appreciate the comment to isolate the files with the changes besides the abapGit metadata.

@microsoft-github-policy-service agree [company="BOMAG GmbH"]

@microsoft-github-policy-service agree

@vikasbansal2022 how about merging the test report and the class change ony for the cherry picking?


Update nf-winbase-createsemaphorea.md

Fix the missing "backslash character"

@SweetIceLolly : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks for your contribution, I've merged your changes and they should be live soon.


Python script taking a long time to arm.

I have written a basic autopilot script for my drone, and the SITL simulation works perfectly fine, but I run into some issues on the physical hardware. When I first start up my system, it takes a very long time to become armable, somewhere around 10 minutes. If I just take out the line of code that waits for
is_armable to be true, I get GPS speed errors. I can't seem to find a workaround for the GPS speed errors or the obnoxiously long arming time. I am using a raspberry pi 3 and a pixhawk if that makes a difference.

Hi! First off, sorry, I don't have the answers you're looking for, but I am in the same situation and maybe we can solve this together. Are you still having this problem? What pixhawk are you using? Are you able to connect sometimes but not always?  Did this work for you before and then you got into a crash (or some) and it stopped working?


[BugFix] fix PrintableMap bug when properties contains quotation mark

Fixes #issue
If hive table definition properties contains quotation mark, then we can not handle table definition correctly.
CREATE EXTERNAL TABLE `ex_hive_tbl` (
  `col_tinyint` tinyint(4) NULL COMMENT "column tinyint",
) ENGINE=HIVE
PROPERTIES (
"COLUMN_STATS_ACCURATE"  =  "{"BASIC_STATS":"true"}",
);

And if we use create table like, then we will get error message like
Unexpected input 'BASIC_STATS', the most similar input is {',', ')'}.

And to fix this problem, we have to escape quotation mark in property value.  And for compatibility, we only escape quotation mark when withQuotation = true
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@mergify backport branch-3.1

@mergify backport branch-3.0


net: openthread: Fix bugs detected during Coverity SCA.

Performed static code analysis using Coverity detected some bugs,
which were fixed in this commit.
List of detected bugs:

radio.c

l.108 - clear_pending_events function was declared
but never referenced
l.277 - dereferencing "net_buf_frag_last((*pkt).buffer)",
which is known to be "NULL"

openthread_utils.c

l.35 - dereferencing a pointer that might be "NULL"
l.185 - using index "i" (which may evaluate to -1).

Signed-off-by: Kamil Kasperczyk<EMAIL_ADDRESS>

Could you add Coverity CID numbers to the commit message, otherwise it is very difficult to find these from Coverity web page. Was there an issue for these, if yes, then please add "Fixes #xxxxx" to commit message too.

Setting this PR is a result of misunderstanding and lack of knowledge about working on bugs fixing with Coverity in Zephyr, so I'm closing it. @rlubos @jukkar sorry for bothering, I'm going to join community and create future PRs following the convention.


fix(core): Rename FrontendDist::Dist to Dir

Dist::Dist kinda triggers me and i'd like to rename it to Folder, Dir, or Directory. I started with Dir because Folder sounds weird to me and Directory is so long, but ultimately i'm fine with all 3 so please voice your preference :)
p.s. if you want to stick with Dist::Dist just close this.

Actually wait, now that i see the pr preview i don't like Dir so much anymore D:

Dist::Dist is weird indeed, i didn't notice that
I don't like the word Folder but i use it anyway
I guess I'd go with Directory since Dist::Dir is also too close :joy:


Initial work on properties file

Purpose
Adding basic properties file and config to the pom.xml.
Screenshot

handled in some other PR


chore(blockifier): keccak

This change is

#2197  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


What to improve

Need more tests to the functions

as discussed with TA, this is no longer an issue as we have already included tests in the scripts


Simplify search + filter UI

Blocks #134
Description
Currently our search + filter UI is a bit messy, and takes up a huge part of the screen. Rework our search UI so that it takes up less space at the top, and allow us to implement something like #134 with a better UX.
Implementation Model
We can use an approach made by GitHub's mobile web on how they arrange their search + filter UI for issues. We can hide all the filters behind a popup where all the detailed filter options can live.
https://user-images.githubusercontent.com/6315466/126420178-2ed315fc-ee12-476d-a77f-621ee8c6685b.MOV
Dialog state can be controlled by Headless UI. (bundlephobia)
Tasks

[ ] Implement filter dialog in Search UI
[ ] #347

For those dropping by and wanting to pick this issue, rest assured: I will do this on Saturday.
https://twitter.com/resir014/status/1417857034754564097


Update package dependencies for Redhat 7

Need to update the following packages (epel-repo currently has later versions)
python2-crypto 2.6.1-9
python2-msgpack 0.4.7-3
zeromq 4.1.4-5

Leaving the python2-crypto 2.6.1-9 and python2-msgpack 0.4.7-3 to a later date due to complications with building python34 versions of the packages.


GPUImageView Memory Presure iOS 7.1.2 iPhone 4S

This code cause memory leaks when take 3 or 4 photos :
-(void)viewDidLoad {
[super viewDidLoad];
// Do any additional setup after loading the view, typically from a nib.
_stillCamera = [[GPUImageStillCamera alloc] init];
_filter = [[GPUImageGammaFilter alloc] init];

[_filter addTarget:(GPUImageView*)self.view];

_stillCamera.outputImageOrientation = UIInterfaceOrientationPortrait;
[_stillCamera addTarget:_filter];

[_stillCamera startCameraCapture];

}
-(void)takePhoto{
[_stillCamera capturePhotoAsJPEGProcessedUpToFilter:_filter withCompletionHandler:^(NSData *processedJPEG, NSError *error){
    UIImage *photo = [UIImage imageWithData:processedJPEG];
    NSString *fileName = [NSString stringWithFormat:@"%f.jpeg",[NSDate timeIntervalSinceReferenceDate]];
    [[DiskDispatcher sharedInstance]saveInDisk:processedJPEG withName:fileName completion:^(void){
       // runOnMainQueueWithoutDeadlocking(^{
            _lastPhoto = photo;
            [_imageButton setImage:photo forState:UIControlStateNormal];
        //});
    }];
}];

}

+1

did you resolve this problem?can you give me some suggest,thank you

Yes, I resolved releasing the photo and implementing this

(void)didReceiveMemoryWarning {
[super didReceiveMemoryWarning];
// Dispose of any resources that can be recreated.
[[GPUImageContext sharedFramebufferCache] purgeAllUnassignedFramebuffers];
}

I tried your code. But it gives me No known instance method for selector purgeAllUnassignedFramebuffers and No known class method for selector sharedFramebufferCache error. How can I do this ?

I use purgeAllUnassignedFramebuffers, but it seems not  release memory...

You wrapped the method  [_stillCamera capturePhotoAsJPEGProcessedUpToFilter:_filter withCompletionHandler]   with @autorelasepool  ?