Upgrade jQuery UI version to 1.11.x

We have an issue where a wysiwyg editor in a UI dialog is having its iframe reset when another dialog takes focus and moves to the top of the stack, clearing all the content and rendering the editor unusable.   This would also be an issue with any videos or other iframe elements which get loaded in dialogs. The bug is documented here:
http://bugs.jqueryui.com/ticket/9166
The issue is resolved in jQuery UI 1.11.

@DimaSoroka It looks like this is in the next version of the platform: https://github.com/orocrm/platform/commit/4b581845562ec6da30680e0197fe9387cc7a488e, do you have a hopeful release date for 1.7?

Yes, we are targeting end of April.

Released within 1.7


Started to implement bar handlers

bar_cmd_bindsym is my first victim.
I didn't figure out how to properly send an error when parsing argv[1] (i. e. buttonX).

Looks good save for the minor issues I mentioned.

Spaces issue is everywhere, by the way. Use tabs.

Oh, don't return nothing. Implement those error cases!

Styling is fixed.
I didn't return anything because I didn't know how.
I'll look into it tomorrow.


pritunl-client: 1.3.3329.81 -> 1.3.3343.50

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/pritunl/pritunl-client-electron/releases.
meta.description for pritunl-client is: "Pritunl OpenVPN client CLI"
meta.homepage for pritunl-client is: "https://github.com/pritunl/pritunl-client-electron/tree/master/cli"
meta.changelog for pritunl-client is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.3.3343.50 with grep in /nix/store/x2sxyrzkqgj28awxg8lzzsbfqkr8ssz5-pritunl-client-1.3.3343.50
found 1.3.3343.50 in filename of file in /nix/store/x2sxyrzkqgj28awxg8lzzsbfqkr8ssz5-pritunl-client-1.3.3343.50

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
pritunl-client

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/x2sxyrzkqgj28awxg8lzzsbfqkr8ssz5-pritunl-client-1.3.3343.50 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pritunl-client https://github.com/r-ryantm/nixpkgs/archive/64269e39f0dee210581d68324d50b97e1643d83a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/x2sxyrzkqgj28awxg8lzzsbfqkr8ssz5-pritunl-client-1.3.3343.50
ls -la /nix/store/x2sxyrzkqgj28awxg8lzzsbfqkr8ssz5-pritunl-client-1.3.3343.50/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

pritunl-client

Maintainer pings
cc @bigzilla for testing.

LGTM


vueTsc doesn't support --composite flag

Is your feature request related to a problem? Please describe.
using pnpm create vue@latest to create a new project and choose vitest, the typecheck will be vue-tsc --noEmit -p tsconfig.vitest.json --composite false

Describe the solution you'd like
maybe add a new options to set composite
Describe alternatives you've considered
No response
Additional context
No response
Validations

[X] Read the docs.
[X] Read the Contributing Guidelines.
[X] Check that there isn't already an issue that asks for the same feature to avoid creating a duplicate.

any updates on this?

I would need this too.
A workaround is to create another tsconfig and set composite: false
Example:
// tsconfig.vite-plugin-check.json
{
  "extends": "./tsconfig.vitest.json",
  "compilerOptions": {
    "composite": false
  }
}

// vite.config.ts
checker({
    vueTsc: {
        tsconfigPath: 'tsconfig.vite-plugin-check.json',
    },
})


text overlapping problem solved

Description
Please include a summary of the change and which issue is fixed.
I have made the ".banner-text" class responsive so that the text in that section does not overlap with the About section.
Fixes #401
List any dependencies that are required for this change
none
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
On my local host
UI /UX changes
Attach gif or screenshot for changes.

Before :

- After :

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Requesting @admins to review and merge my PR

Sir, I have made the changes in the css file.


Amcrest sensors do not have unique_id, cannot be renamed

Home Assistant release with the issue:

0.95.4
Last working Home Assistant release (if known):
n/a
Operating environment (Hass.io/Docker/Windows/etc.):

ArchLinuxARM, 32-bit, Odroid XU4
Component/platform:

https://www.home-assistant.io/components/amcrest/
Description of problem:
Amcrest sensors "motion_detected", "online" do not include unique_ids, so they cannot be renamed in the frontend.
According to the HA dev docs (https://developers.home-assistant.io/docs/en/entity_registry_index.html#unique-id-requirements), the sensors should probably use "$SERIAL-motion_detected" and "$SERIAL-online" as the unique ID, which would allow changing the display name and entity_ids in the frontend.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
amcrest:
- name: Garage
  host: garage.camera.local.network
  username: viewer
  password: !secret amcrest.password
  binary_sensors:
  - motion_detected
  - online
  resolution: low
  stream_source: mjpeg
- name: Front Door
  host: frontdoor.camera.local.network
  username: viewer
  password: !secret amcrest.password
  binary_sensors:
  - motion_detected
  - online
  resolution: low
  stream_source: mjpeg
- name: Patio
  host: patio.camera.local.network
  username: viewer
  password: !secret amcrest.password
  binary_sensors:
  - motion_detected
  - online
  resolution: low
  stream_source: mjpeg
- name: Balcony
  host: balcony.camera.local.network
  username: viewer
  password: !secret amcrest.password
  binary_sensors:
  - motion_detected
  - online
  resolution: low
  stream_source: mjpeg

Traceback (if applicable):
n/a

Additional information:

Actually, looks like serial number is no longer available in the amcrest component. Maybe the unique_id can be derived from the hostname?

Or maybe the upstream python-amcrest component could be modified to provide serial number, and then home-assistant could use that.
It looks like the serial number is fetched as part of the initialisation and then cached, so self._api._serial should work too. (But maybe using _serial directly is not a good idea because it's private, so upstream could expose it as a public property instead).


Images not appearing (possible wrong path?)

I tried posting this on Stack Overflow to no avail, but maybe you guys can help me out. I'm trying to implement LiterallyCanvas into a React component. The canvas itself is working, but the images are not being found. At first I thought I just wasn't using the right image URL path, but now I'm not so sure. This embedded file is Canvas.jsx, which is in '/src/containers/'. I am trying to access images that are in '/src/assets/'. To do so, I am using the LiterallyCanvas library's imageURLPrefix option to access '../assets'. Any ideas why the images aren't being found? I'm at a loss here.
import React, { Component } from "react";
import Navigation from './Navigation';
const LC = require('literallycanvas');

import styles from '../styles/components/literallycanvas.css';

class Canvas extends React.Component {
  constructor(props) {
    super(props);

    this.state = {
      prompts: []
    };
  };

  render () {
    return (

        <Navigation />

Canvas Component

          <LC.LiterallyCanvasReactComponent imageURLPrefix="../assets" />

    );
  }
}

export default Canvas;

I took another look at this tonight and I'm still having issues getting this to work. I even tried moving the images into an "img" folder in the root directory and accessing them that way, but that didn't help. I'm not sure what's causing this problem since I was able to get the images to load in your npm_webpack_react demo. I would love to use your widget, so any help would be much appreciated.


default MM TE to 5.38.0

Summary
default MM TE to 5.38.0
Ticket Link

after we merge: https://github.com/mattermost/mattermost-helm/pull/245 i will rebase this PR to get the new ci

looks like 5.38.0 is not ready


Add a name suffix to distinguish AsyncJournalWriter threads

What changes are proposed in this pull request?
There can be multiple AsyncJournalWriter threads, add a thread name suffix to distinguish them.
Why are the changes needed?
Makes jstack debugging easier
Does this PR introduce any user facing changes?
NA

Codecov Report

Merging #13707 (9d3f9f5) into master (8f97988) will decrease coverage by 26.17%.
The diff coverage is 100.00%.

:exclamation: Current head 9d3f9f5 differs from pull request most recent head 0d0bb5a. Consider uploading reports for the commit 0d0bb5a to get more accurate results

@@              Coverage Diff              @@
##             master   #13707       +/-   ##
=============================================
- Coverage     43.76%   17.59%   -26.18%
+ Complexity     9049     2675     -6374
=============================================
  Files          1378     1382        +4
  Lines         79869    80217      +348
  Branches       9713     9748       +35
=============================================
- Hits          34957    14113    -20844
- Misses        41962    64865    +22903
+ Partials       2950     1239     -1711

Impacted Files
Coverage Δ

...alluxio/master/journal/raft/RaftJournalSystem.java
0.00% <ø> (-64.43%)
:arrow_down:

...ava/alluxio/master/journal/AsyncJournalWriter.java
63.20% <100.00%> (-20.28%)
:arrow_down:

...in/java/alluxio/master/journal/ufs/UfsJournal.java
33.91% <100.00%> (ø)

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/wire/AlluxioProxyInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/alluxio/wire/AlluxioMasterInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/job/meta/JobIdGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/stress/BaseParameters.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/client/UnderStorageType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 683 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f97988...0d0bb5a. Read the comment docs.

alluxio-bot, merge this please


Inconsistent behavior of delete key

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows 7 64bits, Godot 3.0 beta1
Issue description:

Clicking on a node and pressing "delete" shows the confirmation window for deleting that node
Clicking on a key frame in the Animator timeline and pressing "delete" deletes said key frame
However, clicking on a file in the filesystem panel and pressing "delete" shows the confirmation window for deleting the node that's currently selected on the scene panel rather than a confirmation window for the selected file.

This behavior is inconsistent and unexpected being that Godot has an otherwise pretty standard UI/UX and can lead to the user accidentally deleting nodes while intending to delete files.

The same is true in visual scripting.  Clicking a function or variable and hitting delete tries to delete a node.


Cannot build

Hi
I followed the README guide, but cannot build the project.
Undefined symbol: _OBJC_CLASS_$_SGScanCode
Undefined symbol: _OBJC_CLASS_$_SGScanView
Undefined symbol: _OBJC_CLASS_$_SGScanViewConfigure
Undefined symbol: _OBJC_CLASS_$_SVProgressHUD
Undefined symbol: _SVProgressHUDDidDisappearNotification
Undefined symbol: _SVProgressHUDStatusUserInfoKey

Any ideas?

its seems like you use M1 cpu Mac，try the first and fifth points @dmattsson
https://developer.tuya.com/cn/docs/app-development/faq?id=Ka5vc94omshzp#title-20-5. M1 芯片的电脑编译 iOS 为什么报错 Undefined symbols for architecture arm64？

Thank you @taojingGino! I managed to solve it by running XCode in Rosetta mode instead.


Short alias in CLI

/kind feature

Which functionality do you think we should add?
Add short aliases for CLI commands. Currently I have to type odo list I would like to be able to type odo ls
Why is this needed?
Currently the CLI is forcing the developers to be very verbose when typing commands which takes time.
I have given a example above with list vs ls.
There is probably more "standard" aliases that could be implemented in the cli to make life easier for developers.

Hi, @NissesSenap to save some typing you can also use autocompletion, this is much more useful than aliases.
If you execute  source <(odo utils terminal bash) (or  source <(odo utils terminal zsh) if you use ZSH) you will be able to do odo li<tab>. Autocompletion should also work for flags. To make it persistent you add the command to your .bashrc .zshrc.

Thanks for the tip @kadel I have done this and as you say it saves some time but I guess me and most developers today is used of doing "ls" or "get" when you want a list of things within kubernetes.
I haven't had time to look at the odo code but I assume it uses a cli framework like cobra or something similar so adding aliases shouldn't be a super big feature but my two cents is that it will make life easier for developers.

Yes, we use Cobra, aliases are not a problem. We are actually already doing it.
In reality odo list is already an alias for odo component list :-)
We will look into making commands a little bit shorter and use common shortcuts that people are used to.


README.md is not compiled

When visiting generator-node/app/templates on Github, README.md hasn't been compiled, breaking it's output.

That's expected. It's just a placeholder readme using lodash templates.

Yeah, sorry for the false positive, I just now realized what was happening.


Add multiplyAdd with fixed gain

It adds an overload of multiplyAdd which accepts a fixed gain.

I'll merge this, since I have already checked SIMD routines for correctness. (externally)
I want this to clean up effects. Is this fine?

I was waiting to push tests on this PR but I suppose this can be added later! Merge it if you need 😄

I've thought there weren't SIMD correctness tests, but in fact there are !
I will add them.


Feature/dops 1786/gh actions concurrency

Description of the Change

Issue

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

Codecov Report

:exclamation: No coverage uploaded for pull request base (iroha2-dev@1f1c8d7). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             iroha2-dev       #1   +/-   ##
=============================================
  Coverage              ?   69.58%
=============================================
  Files                 ?      142
  Lines                 ?    28180
  Branches              ?        0
=============================================
  Hits                  ?    19608
  Misses                ?     8572
  Partials              ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1c8d7...2b9084d. Read the comment docs.


Add documentation for the formatOnSave option

formatOnSave is mentioned in the README, but isn't listed in the default settings within VS Code.

Thanks! :)


Add Parse Hex functionality to Color struct

Description

Motivation and Context

Add Parse Hex functionality to Color struct

How Has This Been Tested?

Screenshots
Types of changes

[x] Improvement (non-breaking change that improves a feature, code or algorithm)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)
[ ] Dependencies (update dependencies and changes associated, has no impact on code or features)
[x] Unit Tests (work on Unit Tests, has no impact on code or features)
[x] Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@josesimoes any obvious reason why the build is failing on installing NBVG?

@josesimoes any obvious reason why the build is failing on installing NBVG?

@Ellerbach yes. Looks like my work on the dotnet tools pre-installed on Azure VMs has been deployed. 😁
I'll fix the pipeline right away.

Looks like my work on the dotnet tools pre-installed on Azure VMs has been deployed

That's a great new then ;-)

Looks like my work on the dotnet tools pre-installed on Azure VMs has been deployed

That's a great new then ;-)

Must have been a test... because it's not there anymore... reverting changes...


Invite collaborators to project

Resolves #5790 and closes #6054. Wraps up work done by @DavidBord, @di and @ewdurbin

@patelneel55 Looks like there's still unresolved comments here, please re-request a review when this is ready.

@di I made the requested changes and also, like you suggested, made the project page display any pending invitations. Accepting it will take you to the accepted project page/project manage page based on your target role and declining it will remove the invite and keep you at the project list page.

\o/


Renaming or deleting views should trigger a recompile

Refactored watcher to include type of change event. Non-edit changes to view files triggers an app restart.
Addresses issue https://github.com/livebud/bud/issues/138

Thanks @dangerzone for your help here! While your PR totally would have worked, I wanted to pass the entire event through. We also need tests for changes introduced :)
Closing in favor of #212


can i change the coordinate scale between overworld and the nether?

Describe your idea
when i create overworld island with 8000 distance, nether island will generate every 1000 blocks which is to tight. I found purpur has some plugins that can change scale between overworld and the nether, can it also do in mod?

No, but you could just increase the distance of the overworld islands.


Fetching remote branches before switching to version branch

Should fix this issue: https://github.com/elastic/apm-agent-android/actions/runs/9129073287/job/25102761808

LGTM.
Probably overkill. The --all means to fetch from all remotes... and I assume the only remote from actions/checkout is origin, so git fetch would accomplish the same. Or could use: https://github.com/actions/checkout?tab=readme-ov-file#fetch-all-history-for-all-tags-and-branches

Yeah, it's a bit overkill. I wasn't aware of the existing action's param for this use case, though it seems to be the cleanest approach, so I just made the changes to use it instead. Cheers!


Dashboard improvements

Pull Request Description

Fix most of https://github.com/enso-org/cloud-v2/issues/1322
Implement https://github.com/enso-org/cloud-v2/issues/1323

Important Notes
N/A
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[x] Unit tests have been written where possible.

2 small fixes. The rest looks nice. QA ✅

Wasn't clear enough. Recent should also be moved similar to Trash
Copy as path works fine for File and Directory for other Asset we need to add type suffix. I will create an improvement for that. Maybe we should store the path on backend side and return in in list directory request
Shouldn't have a download on a local folder. I think this was not implemented

ohhh

Shouldn't have a download on a local folder.

i was wondering what this meant (i was looking in the Drive Bar) - i guess you mean in the context menu

@PabloBuchu i think the small fixes have been addressed now


InvalidParameterException when endpoint_public_access is true endpoint_public_access_cidrs is not set

Issue
InvalidParameterException happens at the second execution of terrafrom apply when endpoint_public_access = true and endpoint_public_access_cidrs is not set.
│ Error: error updating EKS Cluster (xxx) VPC config: InvalidParameterException: Cluster is already at the desired configuration with endpointPrivateAccess: true , endpointPublicAccess: true, and Public Endpoint Restrictions: [<IP_ADDRESS>/0]
│ {
│   RespMetadata: {
│     StatusCode: 400,
│     RequestID: "xxx"
│   },
│   ClusterName: "xxx",
│   Message_: "Cluster is already at the desired configuration with endpointPrivateAccess: true , endpointPublicAccess: true, and Public Endpoint Restrictions: [<IP_ADDRESS>/0]"
│ }
│
│   with module.eks_cluster_staging.aws_eks_cluster.control_plane,
│   on .terraform/modules/eks_cluster_staging/modules/cluster/main.tf line 12, in resource "aws_eks_cluster" "control_plane":
│   12: resource "aws_eks_cluster" "control_plane" {
│

Reproduce

Create cluster with endpoint_public_access = true and without setting value for endpoint_public_access_cidrs
Run terraform apply
Run terraform apply again

Closed with #293


Add skeleton Blazor WebAssembly client

Add skeleton Blazor WebAssembly client that we can continue to build upon in smaller tickets.

While out running I thought of a way I think we should design this for the out-most reusability.
We should continue to build out not only write methods in MLOps.NET, MLOps.NET.Azure and MLOps.NET.SQLite, but also start building out read methods.
E.g. we would most likely want methods such as get all experiments, get all runs etc.
What we then could do is use both this SDK client in the Blazor WebAssembly app and let the Blazor app be purely UI and display logic. Writing this down in this ticket to remember it but will add a Visio diagram shortly.

Hi @aslotte ,
just curious how this will be consumed. Will this be a part of the same nuget package?

Great question so in my mind it will be:

A separate solution, part of the same repo
The Blazor client will consume our Nuget SDK for the heavy lifting
The Blazor client will be eventually packaged in a Docker container so for the end user they will consume this client by pulling the image from e.g. Docker Hub setting the connectionstring and starting the container.

This is a good resource to get started with Blazor WebAssembly: https://devblogs.microsoft.com/aspnet/blazor-webassembly-3-2-0-now-available/

Thank you. Will try it out

@aslotte I guess only drawback would be that we won't be able to access user's file system to access the model file from a client app directly.

I think this client will be consumed by anyone that uses it through a Docker Container running locally or in the cloud, so for anyone using local storage, they'll probably have to mount a drive that's accessible by the client. Definitely something we have to think of though.

On today's stream we had some great input that in a wasm app everything is served in the browser, meaning we can't have connectionstrings etc. So we either need to add an API project or think of another solution to do this. Good thoughts :)
I'm going to spend some time learning a bit about Blazor.

It's actually the same thing as if you would develop an Angular or React app. Everything that needs to be done, should be done through the communication with a server because you can't have secrets in the app itself. I'm however not that familiar we what you actually want to do with this Blazor app, but as a baseline a client app should only consume data via an API and display it. A Blazor server project might make more sense if you want to connect to a lot of infrastructure, dowload files, nuget packages and so on.
Size is also a problem in the Blazor client. If you download Nuget packages or whatever else you need, that would increase the app's footprint. Sure, files get cached by the browser, but size is still a problem.

@danpdc yea, thanks for your input today! After reading up more on it, I do think a Blazor Server App makes more sense for our scenario, especially as the end goal is going to be delivering it as a Docker image.

Totally agree. And I want to get involved. We'll get in touch tomorrow :)

Thanks @danpdc! I may start on a skeleton myself just to learn more about Blazor (which is something I want to pick) but would your contributions!


Some opcodes taking Reg32e despite having 16-bit variations

Hi Herumi,
A minor issue I noticed:
Some opcodes take a "Reg32e" as a parameter, despite the Intel x86/x64 docs saying that a 16-bit register is also allowed for them. (An 8-bit register isn't, though).
The opcodes are lea and cmov*

Thank you for your pointing out. I'll check it later.

I fixed it.


Give admin access to Sandy

https://participedia.net/user/36

@ascott she is stepping into a new version of scott's role as our new Communications and Outreach Associate

@jesicarson i've given sandy admin access now.


Refurbished Withings Body Plus Notebook

The main goal of this task was to refurbish the original Withings Body Plus notebook to utilize the Wearipedia package and append additional sections to match the standard set by the Garmin Fenix notebook.

General comments
The notebook is high quality for sure, but please refrain from directly copying anything from the Garmin notebook (paragraphs, plots). Instead, you should read it as guidance. We'd like all plots to be different from the other notebooks.
There's a few warnings throughout the code, please resolve them.
Introduction
There's no readme, instead link to http://wearipedia.com/wearables/withings-body-plus
"In this guide, we sequentially cover the following five topics to extract from the Withings API:" it's 9 topics
Does step 1-9 truly reflect the guide, or is it copied from the Garmin? Ensure that the sub bulletpoints reflect the writings in the guide
1.Setup
1.1 this should be written in a letter format
1.2 The artificial data should not be generated in the beginning from a gist, it should be generated using the Wearipedia package as done in the garmin notebook
wearipedia python package shouldn't be imported until the data extraction part, see the Garmin notebook
2 Auth
It has steps 1, 2, 3, 4, and 7. Where's step 5, 6?
3 Data extraction
"The overall health data API page" hyperlink does not work, also, keep it short and just call it the API page. Change the order such that the comment on the Wearipedia package comes first.
Also, does it even make sense to keep this paragraph anymore given that we now use the Wearipedia package?
5. Adherence
"that concisely describes when the participant has had their device on and off throughout the entirety of the time period" -> this is written for wearables and not a scale
6. Simple viz
What is pre-treatment and treatment?
7. adv viz
7.1
"First, it's important to know when the user has been wearing the device" -> this is written for wearable not a scale
"We'll interpret step count as a proxy for usage and plot colors accordingly."
You should comment on why we need this plot and then you should comment on what you see after plotting it.
7.2
A part of this plot is related to data cleaning. You should add it under that section.
8. Data cleaning and outliers
"We will use a simple statistical method for detecting outliers. Specifically, we will rely on the assumption that weight and fat ratio percentages roughly do not change very much from one timestep to the next, and that if there is one measurement that very clearly sticks up much higher than the rest surrounding it, then it is likely an outlier."
Is this what you measure? It seems to me that you consider all samples drawn from the same distribution, which doesn't take into account the time dimension. Instead, you could consider looking into the ratio between two weightings and require that they follow a normal distribution.
9 Analysis
In comparison to other notebooks, the synthetic data here has some labels on it. The previous notebooks discussed this, but it is not covered in this notebook. Please take some time out of the sections to discuss this dataset and what challenges it poses in an educational manner with reasonable plots.
9.1
A T-test assumes that data is sampled form a normal distribution, have you tested that assumption?
9.2
The first plot does not make sense to me, how is it convincing?
Also, please give some more intuition on how you are performing the testing.
And why are the two plots with different formatting?

Fixed the comments as well as addressed feedback from Thursday's meeting. Also added additional features such as an auto-start date setter for the visualization and minimized some code blocks.


Decrease log level of "ConfigMaps watch closed" statement

Hi,
I'm currently using the spring-cloud-starter-kubernetes-fabric8-config dependency in to leverage automatic configMap reload when deploying my project in OpenShift. The issue is that my microservices are meant to stay up for a long period of time, therefore resulting in having the following statement logged really often (at random intervals):
io.fabric8.kubernetes.client.WatcherException: too old resource version: 7200362 (11665615) at io.fabric8.kubernetes.client.dsl.internal.AbstractWatchManager.onStatus(AbstractWatchManager.java:273) at io.fabric8.kubernetes.client.dsl.internal.AbstractWatchManager.onMessage(AbstractWatchManager.java:257) at io.fabric8.kubernetes.client.dsl.internal.WatcherWebSocketListener.onMessage(WatcherWebSocketListener.java:93) at okhttp3.internal.ws.RealWebSocket.onReadMessage(RealWebSocket.kt:333) at okhttp3.internal.ws.WebSocketReader.readMessageFrame(WebSocketReader.kt:245) at okhttp3.internal.ws.WebSocketReader.processNextFrame(WebSocketReader.kt:106) at okhttp3.internal.ws.RealWebSocket.loopReader(RealWebSocket.kt:293) at okhttp3.internal.ws.RealWebSocket$connect$1.onResponse(RealWebSocket.kt:195) at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:519) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) at java.base/java.lang.Thread.run(Unknown Source) Caused by: io.fabric8.kubernetes.client.KubernetesClientException: too old resource version: 7200362 (11665615) ... 12 common frames omitted
From what I can see in EventBasedConfigMapChangeDetector.java, you handle this closure by then re-creating a new watch, and this is confirmed by various logs I see in my microservices as well as the automatic reload still functioning correctly despite the previous warning.
Therefore, could it be possible to change the log level of the "ConfigMaps watch closed" statement to debug, as it is already the case for other similar statements in the same class, to avoid polluting the logs ?
Kind regards

yeah, totally doable. we currently have it on warn, which comes before info, so it's always logged.
@ryanjbaxter should I move it to debug? This does not require any changes in main - since we do not use neither watchers, neither fabric8 in main. thank you.

Sure I don't have any strong objection

this can be closed btw... thank you for opening the defect @Jereminet


Derive interval attribute from data if missing

INTERVAL is a recommended, yet only optional header field and therefore may be missing as an xarray attribute. My scripts use this value, so I added a logic to derive it from the data. I have never seen a RINEX file with a variable interval length, so I expect this to be robust.
Maybe this is also useful for others.

I am note sure, but I feel like some test cases are outdated.

Actually the tests were doing their job, the variable names in the PR had to be corrected

I see, thanks!


peer: make PingManager disconnect call async

In this commit, we make all calls to disconnect after a ping/pong
violation is detected in the PingManager async. We do this to avoid
circular waiting that may occur if the disconnect call back ends up
waiting on the peer goroutine to be torn down. If this happens, then the
peer goroutine will be blocked on the ping manager fully tearing down,
which is blocked on the peer disconnect succeeding.
This is a similar class of issue we've delt with recently as pertains to
the peer and the server: sync all back execution must not lead to
a circular waiting loop.
Alternatively, we could have the internal of the call back itself be
async, but I prefer this route as it minimizes assumptions.
Fixes https://github.com/lightningnetwork/lnd/issues/8379

I think before we merge this we should have an itest that showed the prior deadlock issue, which is then resolved by this PR.
Rather than add some new build tag, I think we can instead spin up a skeleton server (just for p2p connections), then have it pass in a purposefully blocking call back into the ping manager.

@coderabbitai review

@ProofOfKeags @ellemouton updated to squash change into first commit (ended up just modifying it as it was more pleasing to the Rebase Gods), and updated the release notes to point to v0.17.4.


Source of tiles for OS 1:25k historic

Abstract: please consider switching the source of tiles for this background.
OS 1:25k historic (OSM) has made a re-appearance.  Which is good, because although it's old information it has details that are useful, such as footpaths and old names.  That info has to be interpreted with care, but it provides clues as to what might be there now.
However, this background has always had problems because not all sheets were available when the tiles were created from National Library of Scotland sources.  If you happen to live in the wrong part of the UK (I do) then there are many missing tiles.  Take a look at this part of the map with the OS 1:25k historic background.  Not good. :(
However, I found an alternative source of tiles in the editor layer index back when this background went walkabout.  These come from the NLS's own digitization of the OS maps.  Using https://geo.nls.uk/mapdata2/os/25000/{zoom}/{x}/{-y}.png as a custom layer gives me a background with full coverage.  I think their offset from true position may be a little greater than the OSM version, but that's OK.
So, would you consider either switching to the NLS version or offering both?  I can cope if you don't because I found out how to make use of the custom layer and found the NLS version in the editor layer index.  Other mappers may not figure out to do those things.

I think that background url you've provided is already in the editor-layer-index under the 1937-61 name: https://raw.githubusercontent.com/osmlab/editor-layer-index/f20589a74fd20e78c4222304f9148ce7c79c1a18/sources/europe/gb/NLS-OS125k1stSeries1937-61.geojson
However the only reason that the OS 1:25k historic (OSM) layer is available in iD is because there is no end_date parameter in the editor-layer-index file. If that was added, then iD would hide it - like the rest of the old OS maps - because it is > 20 years old.
As you say - new mappers might not realise where to get the custom layers. See  #3453 where I raised this issue originally.

@boothym

I think that background url you've provided is already in the editor-layer-index under the 1937-61 name

I don't know which is the officially preferred URL but the one I use is a lot shorter.  I found mine at  the interactive layer index and assumed it was the official way of doing it.  If not, it still works. :)

However the only reason that the OS 1:25k historic (OSM) layer is available in iD is because there is no end_date parameter in the editor-layer-index file. If that was added, then iD would hide it - like the rest of the old OS maps - because it is > 20 years old.

That is sensible for aerial imagery.  In my area Bing is 2012-2013 and Esri is 2016.  There is a small housing estate in town which is incomplete in Bing and complete in Esri (well, after getting house numbers by surveying it, it's clear that more houses are/were planned, but Esri matches what's on the ground right now).  Going back further with aerial imagery would rarely be useful.
However, for OS maps, the 1:25k historic is useful.  Not all the time, but occasionally.  It shows heights of peaks, which OpenData StreetView rarely (never?) does.  It has names for some very small settlements which are not shown on OD SV but which are used in current postal addresses.  It allowed me to correct a very short segment of the path of an already-mapped abandoned railway.  By showing me an old road layout it allowed me to figure out that a section of road that was mapped as part of Castle Street was actually Tenby Road, as postal addresses for some of the houses implied (Tenby Road essentially got bypassed by a new section of road and the layout changed so part of Tenby Road appeared to be a direct continuation of Castle Street).  More importantly, it shows footpaths, most of which are still valid (and visible in aerial imagery if you know they're there) and few of which (unless they pass through woodland) can be inferred from OD SV.
I know non-custom backgrounds, if used while making changes, get added to changeset details.  What happens with a custom layer?  Do I need to add a source tag to each object I add using that layer?  That would not meet the goal of making iD easier to use.
The 1:25k historic is useful.  Especially the version I'm currently using as a custom background which doesn't suffer from the missing sheets problem.  I think we need either separate cut-off dates for maps and aerial imagery, or a historic background sub-menu, or a warning pop-up when selecting an older background, or something.  Because, as has been repeatedly pointed out in #3453, these older OS maps are useful.

Closing here as this is already covered on #3453 , which remains open until someone builds a friendly way of letting users filter or customize the imagery list.


test/net/integration/http fails because the response is not parsed correctly

Hello,
test/net/integration/http (master branch) fails sometimes (approx. once every ten runs) in my box (specs at the end). This seems to happen when the HTTP response is split into too many packets (see the TCP dump below). There seem to be two issues happening:
(1) the HTTP response is (sometimes) ended before parsing the last packet. Specifically, end_response in client_connection.cpp is called too early.
(2) the response is not parsed correctly and the body includes some lines that should belong to the header. Specifically, https://github.com/hioa-cs/IncludeOS/blob/master/src/net/http/client_connection.cpp#L98 is treating the last packet, that has a portion of the header and the body, as just the body.
Here is the output of test.py when failing because of issue (1) (service.cpp was slightly changed to print the response and body before the failing assert):
<vm>      [ Kernel ] Starting HTTP Test Service
<vm> ================================================================================
<vm> ================================================================================
<vm>  IncludeOS v0.10.0-dirty
<vm>  +--> Running [ HTTP Test Service ]
<vm> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<vm> [ Super stack ] Constructing stacks
<vm> [ Super stack ] Creating stack for Nic eth0
<vm>       [ Inet4 ] Bringing up a IPv4 stack
<vm>       [ Inet4 ] Network configured
<vm>                 IP: 		<IP_ADDRESS>
<vm>                 Netmask: 	<IP_ADDRESS>
<vm>                 Gateway: 	<IP_ADDRESS>
<vm>                 DNS Server: 	<IP_ADDRESS>
<vm>      [ Client ] Testing against local server
<vm>      [ Client ] Testing against Acorn
<vm> Response: ===============================> printing the full response before doing the checks.
<vm> HTTP/1.0 200 OK
<vm> Server: BaseHTTP/0.3 Python/2.7.12
<vm> Date: Wed, 05 Apr 2017 19:04:02 GMT
<vm> Content-type: text/plain:
<vm>
<vm> Body:
<vm> ===============================> body is empty
<vm>                 [x] No error
<vm> assertion "res->body() == "/testing"" failed: file "/root/IncludeOS/test/net/integration/http/service.cpp", line 56, function: auto Service::ready()::(anonymous class)::operator()(type-parameter-0-0, type-parameter-0-1) const
<vm> !!! Kill PID: 1, SIG: 6 - IOT trap / ABORT

Here is is the tcpdump for bridge43 for a case of issue (1). The last packet is not included in the HTTP response and that seems to be the reason for the failure.
19:18:47.659514 c0:01:0a:00:00:2a (oui Unknown) > c0:01:0a:00:00:01 (oui Unknown), ethertype IPv4 (0x0800), length 54: <IP_ADDRESS>.57134 > <IP_ADDRESS>.9011: Flags [.], ack 1, win 65535, length 0
        0x0000:  4500 0028 0000 0000 4006 66a4 0a00 002c<EMAIL_ADDRESS>        0x0010:  0a00 0001 df2e 2333 1814 4399 df93 89d8  ......#3..C.....
        0x0020:  5010 ffff d42c 0000                      P....,..
19:18:47.659576 c0:01:0a:00:00:2a (oui Unknown) > c0:01:0a:00:00:01 (oui Unknown), ethertype IPv4 (0x0800), length 146: <IP_ADDRESS>.57134 > <IP_ADDRESS>.9011: Flags [P.], seq 1:93, ack 1, win 65535, length 92
        0x0000:  4500 0084 0000 0000 4006 6648 0a00 002c<EMAIL_ADDRESS>        0x0010:  0a00 0001 df2e 2333 1814 4399 df93 89d8  ......#3..C.....
        0x0020:  5018 ffff b3d5 0000 4745 5420 2f74 6573  P.......GET./tes
        0x0030:  7469 6e67 2048 5454 502f 312e 310d 0a55  ting.HTTP/1.1..U
        0x0040:  7365 722d 4167 656e 743a 2049 6e63 6c75  ser-Agent:.Inclu
        0x0050:  6465 4f53 2f30 2e39 0d0a 436f 6e6e 6563  deOS/0.9..Connec
        0x0060:  7469 6f6e 3a20 636c 6f73 650d 0a48 6f73  tion:.close..Hos
        0x0070:  743a 2031 302e 302e 302e 313a 3930 3131  t:.<IP_ADDRESS>:9011
        0x0080:  0d0a 0d0a                                ....
19:18:47.659591 c0:01:0a:00:00:01 (oui Unknown) > c0:01:0a:00:00:2a (oui Unknown), ethertype IPv4 (0x0800), length 54: <IP_ADDRESS>.9011 > <IP_ADDRESS>.57134: Flags [.], ack 93, win 29200, length 0
        0x0000:  4500 0028 29ce 4000 4006 fcd5 0a00 0001  E<EMAIL_ADDRESS>        0x0010:  0a00 002c 2333 df2e df93 89d8 1814 43f5  ...,#3........C.
        0x0020:  5010 7210 1447 0000                      P.r..G..
19:18:47.659893 c0:01:0a:00:00:01 (oui Unknown) > c0:01:0a:00:00:2a (oui Unknown), ethertype IPv4 (0x0800), length 71: <IP_ADDRESS>.9011 > <IP_ADDRESS>.57134: Flags [P.], seq 1:18, ack 93, win 29200, length 17
        0x0000:  4500 0039 29cf 4000 4006 fcc3 0a00 0001  E..9<EMAIL_ADDRESS>        0x0010:  0a00 002c 2333 df2e df93 89d8 1814 43f5  ...,#3........C.
        0x0020:  5018 7210 1458 0000 4854 5450 2f31 2e30  P.r..X..HTTP/1.0
        0x0030:  2032 3030 204f 4b0d 0a                   .200.OK..
19:18:47.659958 c0:01:0a:00:00:2a (oui Unknown) > c0:01:0a:00:00:01 (oui Unknown), ethertype IPv4 (0x0800), length 54: <IP_ADDRESS>.57134 > <IP_ADDRESS>.9011: Flags [.], ack 18, win 65535, length 0
        0x0000:  4500 0028 0000 0000 4006 66a4 0a00 002c<EMAIL_ADDRESS>        0x0010:  0a00 0001 df2e 2333 1814 43f5 df93 89e9  ......#3..C.....
        0x0020:  5010 ffff d3bf 0000                      P.......
19:18:47.659975 c0:01:0a:00:00:01 (oui Unknown) > c0:01:0a:00:00:2a (oui Unknown), ethertype IPv4 (0x0800), length 90: <IP_ADDRESS>.9011 > <IP_ADDRESS>.57134: Flags [P.], seq 18:54, ack 93, win 29200, length 36
        0x0000:  4500 004c 29d0 4000 4006 fcaf 0a00 0001  E..L<EMAIL_ADDRESS>        0x0010:  0a00 002c 2333 df2e df93 89e9 1814 43f5  ...,#3........C.
        0x0020:  5018 7210 146b 0000 5365 7276 6572 3a20  P.r..k..Server:.
        0x0030:  4261 7365 4854 5450 2f30 2e33 2050 7974  BaseHTTP/0.3.Pyt
        0x0040:  686f 6e2f 322e 372e 3132 0d0a            hon/2.7.12..

====> This next packet is ignored by the HTTP client.

19:18:47.660047 c0:01:0a:00:00:01 (oui Unknown) > c0:01:0a:00:00:2a (oui Unknown), ethertype IPv4 (0x0800), length 127: <IP_ADDRESS>.9011 > <IP_ADDRESS>.57134: Flags [FP.], seq 54:127, ack 93, win 29200, length 73
        0x0000:  4500 0071 29d1 4000 4006 fc89 0a00 0001  E..q<EMAIL_ADDRESS>        0x0010:  0a00 002c 2333 df2e df93 8a0d 1814 43f5  ...,#3........C.
        0x0020:  5019 7210 1490 0000 4461 7465 3a20 5765  P.r.....Date:.We
        0x0030:  642c 2030 3520 4170 7220 3230 3137 2031  d,.05.Apr.2017.1
        0x0040:  393a 3138 3a34 3720 474d 540d 0a43 6f6e  9:18:47.GMT..Con
        0x0050:  7465 6e74 2d74 7970 653a 2074 6578 742f  tent-type:.text/
        0x0060:  706c 6169 6e0d 0a0d 0a2f 7465 7374 696e  plain..../testin
        0x0070:  67                                       g

This is the output of a run failing because of issue (2):
<vm>       [ Inet4 ] Bringing up a IPv4 stack
<vm>       [ Inet4 ] Network configured
<vm>                IP:             <IP_ADDRESS>
<vm>                 Netmask:        <IP_ADDRESS>
<vm>                 Gateway:        <IP_ADDRESS>
<vm>                 DNS Server:     <IP_ADDRESS>
<vm>      [ Client ] Testing against local server
<vm>      [ Client ] Testing against Acorn
<vm> Response:
<vm> HTTP/1.1<PHONE_NUMBER> Internal Server Error
<vm> Server: BaseHTTP/0.3 Python/2.7.12
<vm>
<vm> Date: Wed, 05 Apr 2017 20:25:07 GMT
<vm> Content-type: text/plain
<vm>
<vm> /testing
<vm> Body: ===============================> body includes some header stuff like Content-Type
<vm> Date: Wed, 05 Apr 2017 20:25:07 GMT
<vm> Content-type: text/plain
<vm>
<vm> /testing
<vm>                 [x] No error
<vm> assertion "res->body() == "/testing"" failed: file "/root/IncludeOS/test/net/integration/http/service.cpp", line 56, function: auto Service::ready()::(anonymous class)::operator()(type-parameter-0-0, type-parameter-0-1) const
<vm> !!! Kill PID: 1, SIG: 6 - IOT trap / ABORT

As another datapoint, this hacky change "fixes" the test (no failures in 50 runs). I'm not suggesting this change as the actual fix (it's just a datapoint).
--- a/src/net/http/client_connection.cpp
+++ b/src/net/http/client_connection.cpp
@@ -86,17 +86,11 @@ namespace http {
     else
     {
       // this is the case when Status line is received, but not yet headers.
-      if(res_->header().is_empty() && req_->method() != HEAD)
+      if(req_->method() != HEAD)
       {
         *res_ << data;
         res_->parse();
       }
-      // here we assume all headers has already been received (could not be true?)
-      else
-      {
-        // add chunks of body data
-        res_->add_chunk(data);
-      }
     }

     const auto& header = res_->header();
@@ -121,8 +115,6 @@ namespace http {
         catch(...)
         { end_response({Error::INVALID}); }
       }
-      else
-        end_response();
     }
     else if(req_->method() == HEAD)
     {
@@ -158,7 +150,7 @@ namespace http {
       auto callback = std::move(on_response_);
       on_response_.reset();
       timer_.stop();
-      callback(Error::CLOSING, std::move(res_));
+      callback(Error::NONE, std::move(res_));
     }

     client_.close(*this);

Just in case, this can be reproduced in a Lenovo x1 carbon (Intel(R) Core(TM) i7-5600U CPU @ 2.60GHz), RHEL 7.3, 3.10.0-514.10.2.el7.x86_64. Let me know if you can't reproduce it and need some more info (or tests).
Thanks,
Ricardo

Thanks for a really detailed report! I will look into it.

The hacky change you posted was how it looked before, it's just so expensive. It means we need to concat the response string with the new chunk, and the re parse the whole response again, for every response. It's OK in the test case, but when the responses starts to get a lot of payload it gets really ugly. The problem is the way we parse and concat the response is not good enough. Any ideas on how to improve it are welcome!

If I understands the http_parser correctly it seems the on_headers_complete callback can be used to determine. I tried adding a bool for this (see 	3ac1abf). I ran the test plenty of times without any issue. Would you mind trying?
There are still some changes that can be done on how to build a HTTP response/request, but I'm not sure how yet.

Thanks Andreas. Tested your dev branch and it works (no failures in 50 runs).

Happy to help :) Thanks for thoroughly testing!


container/deploy: Add a --target-imgref option

We want the ability to separate the image that's pulled from its
target reference.  This is what we do today in coreos-assembler
for pure ostree refs - e.g. we deploy via a commit hash, but
still have ostree admin upgrade pull from a ref.
This is equivalent functionality for containers.

Followup https://github.com/ostreedev/ostree-rs-ext/issues/144


Multiple specs error with latest autorest due tag config multiple defination

These specs:
specification/softwareplan/resource-manager/readme.md
and
specification/desktopvirtualization/resource-manager/readme.md
and
specification/iotcentral/resource-manager/readme.md
and
specification/hybriddatamanager/resource-manager/readme.md
fail when processed with autorest 3.1.0-dev.2.
Discussions with @timotheeguerin suggests that they are issues in the swagger redefining tags:
it used to test release_2 but now is testing release_1 with that $ref as an attribute
Builds showing issue:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=748819&view=logs&j=1a6ae1a5-56d5-51f8-8f8d-f67115b54b1a&t=937f187a-1519-5cb7-77a5-47832257e788
https://dev.azure.com/azure-sdk/public/_build/results?buildId=751474&view=logs&j=ac074fc7-7a1e-5636-a7ea-9c59e123a9ef&t=79ef76a9-b720-5417-f045-9a3cbd25ad16

cc  @datr93 and @njuCZ who are the latest people who's touched those files.

The issue in those specs is that the tag config is being defined twice globally in the file. This used to not be a problem as the later ones would get ignored but now the later one will override the first one.
In those specs this result in having multiple tags config being read and so including multiple version specs together.

Adding /specification/iotcentral/resource-manager/readme.md and cc @leni-msft

Adding specification/hybriddatamanager/resource-manager/readme.md and cc @prtank and @ t-prta

Hey, could you point me to some documentation about how these tags should be defined?

@prtank I explained in this reply the problem and solution. The issue is always the same. The tag gets redefined twice and the 2nd (for the same behavior as before) needs to be removed
https://github.com/Azure/azure-rest-api-specs/issues/13147#issuecomment-785322386

Hi Timothee, I did see your comment on having only a single tag in the file. I should've been clearer, could you tell me how the tags work and what they're meant to signify?

If the tags are used to specify which file to pick how should multiple API versions be handled? I remember adding the second tag while adding the second API version.

So before the way it used to read the config the second tag assignment was just being ignore the first one had priority. so it was just like if it was not there.
The config file can be seen as just executing some code and assigning variables. with block condition being if statement.
Not exactly sure what you wanted to do for multi api. You can still have multiple tag condition to load the correct input-file depending on the --tag passed via the cli or default to the one on top if not provided.
So the markdown would look like this
``` yaml
openapi-type: arm
tag: package-2019-06-01-preview
```

### Tag: package-2019-06-01-preview

These settings apply only when `--tag=package-2019-06-01-preview` is specified on the command line.

``` yaml $(tag) == 'package-2019-06-01-preview'
input-file:
  - Microsoft.SoftwarePlan/preview/2019-06-01-preview/softwareplan.json
```

### Tag: package-2019-12-01

These settings apply only when `--tag=package-2019-12-01` is specified on the command line.

``` yaml $(tag) == 'package-2019-12-01'
input-file:
  - Microsoft.SoftwarePlan/stable/2019-12-01/softwareplan.json
```

Thanks for the details Timothee. I have raised PR Fix issue 13147 for HybridDataManager#13296 with the change

Hey Timothee, I see that the PR has been merged. Can i consider this issue closed for HybridDataManager?


Split virtcontainers into smaller packages

From @sameo on February 21, 2018 14:40
Currently all the virtcontainers code lives under the virtcontainers package, making code documentation not clear and all mixed together. See https://godoc.org/github.com/containers/virtcontainers
We should start splitting the code into different logical packages. For example:

api for gathering the https://github.com/containers/virtcontainers/blob/master/documentation/api/1.0/api.md
utils for the externally reachable utilities (things like RunningOnVMM() or SerializeParams()
agent for adding all agent related structures and interfaces

Copied from original issue: containers/virtcontainers#631

From @sboeuf on February 21, 2018 15:37
This will certainly add some complexity into the code since we won't be able to access everything as easily as we do today, due to the fact that everything is from the same package main. Seems like a pretty big change for the purpose of clearer documentation.

Agree. This is necessary.
I am doing some refactoring, but it's not easy, I'll try to upstream some codes piece by piece.

An issue was already opened here: https://github.com/kata-containers/runtime/issues/66
Closing this one as this is a duplicate.
@WeiZhang555 I am fine if you want to work on this but we have higher priority tasks at the moment. And this one is not part of the 1.0 release.


APP-173: Credentials management, C - reviewed.

Can one of the admins verify this patch?

@kaa-leeroy add to whitelist


chore(deps): Resolve security updates

This PR resolves Dependabot security alerts.

:tada: This PR is included in version 2.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Project/Level UI Editor does not have "player_sequence" property

Specific heists like Green Bridge, Diamond Heist and Shacklethorne have a property of player_sequence that allows the level to modify how the player's clothing is.
When you edit a heist's main.xml file and add the player_sequence property into the level object, it loads just fine. All it needs is a UI option that notes the types of player_sequence which are:

spawn_prop_winter_suit
spawn_prop_raincoat
spawn_prop_sneak_suit
spawn_prop_tux
spawn_prop_murky_suit

Edit: Oops forgot some player_sequence's

Changed to 'player_style'

Added, but you'll have to be careful with them, atm BeardLib/editor don't assist you with the packages for the suits and you'll crash if you won't add them.


BadConnectionError - socketcluster-client when requesting from server side. It works fine if the request is issued from the browser.

I have a service that attempts to create a lock on an object and then perform some operations. The process works completely fine when the request is issued from the browser but when trying to do it via server it is failing.
The error that I can see is "BadConnectionError"
socketcluster-client: 16.0.4
socketcluster-server: 16.1.0

I'd need a code example to understand what you're trying to do. Could you provide a minimal example?

Just trying to create a client socket and then connect it.. it seems that it is never able to open the connection and times out.
Its running on nginx - could that be an issue ?
let clientSocket = scClient.create({
"hostname": "[server].com",
"port": 820,
"secure": true,
"rejectUnauthorized": false
})
clientSocket.connect()

Via a nginx reverso proxy you might have some problems because it needs additional settings for WebSockets. An example:
server {
        listen 80;
        listen [::]:80;
        server_name <domain>;
        location / {
                # Reverse proxy
                proxy_pass http://localhost:8000;
                # Send original IP from client to app
                proxy_set_header X-Real-IP $remote_addr;
                # Needed for websockets use
                #proxy_buffering off;
                #proxy_http_version 1.1;
                proxy_set_header Upgrade $http_upgrade;
                proxy_set_header Connection "upgrade";
        }
}

On the client you need to make sure the url points to that domain, and if it has SSL use:
const client = socketclusterClient.create({
  hostname: '<domain',
  port: 443,
  secure: true,
})

See the docs


Does SK has a list of supported embedding models like langchain?

I'd like to know if SK has a list of supported text embedding models like Langchain does.

We will work on getting this added to our Learn site.


Feature Request: Crop 2 images(background-image and image) into a single output image.

Is it possible to provide the source image in a existing background image to crop them into single image using this package.
following is the example working urls for making this feature.
http://subinsb.com/create-profile-picture-framer-web-app/
Git url: https://github.com/subins2000/profile-picture-framer
can this feature implemented in your package ?

This is now easier in 6.0.13:
<ReactCrop>
  <img src="picture-frame.jpg" />
</ReactCrop>


hotfix 2024.1.3: fixed extra removed flows that were being published on event "failover_old_path"

Closes #504
I'm still analyzing other potential related one https://github.com/kytos-ng/telemetry_int/issues/133 though
Summary
See updated changelog file
Local Tests

Simulated/forced failover_old_path events, it no longer is sending extra removed flows

2024-09-03 11:30:31,266 - INFO [kytos.napps.kytos/flow_manager] (thread_pool_app_24) Send FlowMod from KytosEvent dpid: 00:00:00:00:00:00:00:01, command: delete, force: True, total_len
gth: 101,  flows[0, 101]: [{'cookie':<PHONE_NUMBER>5246548803, 'match': {'in_port': 2, 'dl_vlan': 1}, 'owner': 'mef_eline', 'cookie_mask':<PHONE_NUMBER>3709551615}, {'cookie':<PHONE_NUMBER>4063
612495, 'match': {'in_port': 2, 'dl_vlan': 3}, 'owner': 'mef_eline', 'cookie_mask':<PHONE_NUMBER>3709551615}, {'cookie':<PHONE_NUMBER>0674281796, 'match': {'in_port': 2, 'dl_vlan': 7}, 'owne

2024-09-03 11:30:31,325 - INFO [kytos.napps.kytos/flow_manager] (dynamic_single_0) Send FlowMod from KytosEvent dpid: 00:00:00:00:00:00:00:01, command: delete, force: True, total_lengt
h: 386,  flows[0, 200]: [{'cookie':<PHONE_NUMBER>7170692931, 'match': {'in_port': 2, 'dl_vlan': 1, 'dl_type': 2048, 'nw_proto': 6}, 'owner': 'telemetry_int', 'cookie_mask':<PHONE_NUMBER>3709
551615, 'priority': 21100, 'table_group': 'evpl', 'instructions': [{'instruction_type': 'apply_actions', 'actions': [{'action_type': 'add_int_metadata'}, {'action_type': 'output', 'por
t': 17}]}]}, {'cookie':<PHONE_NUMBER>7170692931, 'match': {'in_port': 2, 'dl_vlan': 1, 'dl_type': 2048, 'nw_proto': 17}, 'owner': 'telemetry_int', 'cookie_mask':<PHONE_NUMBER>3709551615, 'pr
iority': 21100, 'table_group': 'evpl', 'instructions': [{'instruction_type': 'apply_actions', 'actions': [{'action_type': 'add_int_metadata'}, {'action_type': 'output', 'port': 17}]}]}

2024-09-03 11:30:31,255 - INFO [kytos.napps.kytos/flow_manager] (thread_pool_app_27) Send FlowMod from KytosEvent dpid: 00:00:00:00:00:00:00:02, command: delete, force: True, total_len
gth: 202,  flows[0, 200]: [{'cookie':<PHONE_NUMBER>5246548803, 'match': {'in_port': 2, 'dl_vlan': 1}, 'owner': 'mef_eline', 'cookie_mask':<PHONE_NUMBER>3709551615}, {'cookie':<PHONE_NUMBER>5246
548803, 'match': {'in_port': 1, 'dl_vlan': 1}, 'owner': 'mef_eline', 'cookie_mask':<PHONE_NUMBER>3709551615}, {'cookie':<PHONE_NUMBER>4063612495, 'match': {'in_port': 2, 'dl_vlan': 3}, 'owne

2024-09-03 11:30:35,418 - INFO [kytos.napps.kytos/flow_manager] (dynamic_single_0) Send FlowMod from KytosEvent dpid: 00:00:00:00:00:00:00:02, command: delete, force: True, total_lengt
h: 404,  flows[0, 200]: [{'cookie':<PHONE_NUMBER>7170692931, 'match': {'in_port': 2, 'dl_vlan': 1, 'dl_type': 2048, 'nw_proto': 6}, 'owner': 'telemetry_int', 'cookie_mask':<PHONE_NUMBER>3709
551615, 'priority': 21100, 'table_group': 'evpl', 'instructions': [{'instruction_type': 'apply_actions', 'actions': [{'action_type': 'add_int_metadata'}]}]}, {'cookie':<PHONE_NUMBER>71706

End-to-End Tests
e2e exec with this branch:
+ python3 -m pytest tests/ --reruns 2 -r fEr
============================= test session starts ==============================
platform linux -- Python 3.11.2, pytest-8.1.1, pluggy-1.5.0
rootdir: /builds/amlight/kytos-end-to-end-tester/kytos-end-to-end-tests
plugins: rerunfailures-13.0, timeout-2.2.0, anyio-4.3.0
collected 267 items
tests/test_e2e_01_kytos_startup.py ..                                    [  0%]
tests/test_e2e_05_topology.py ..................                         [  7%]
tests/test_e2e_06_topology.py ....                                       [  8%]
tests/test_e2e_10_mef_eline.py ..........ss.....x.....x................  [ 23%]
tests/test_e2e_11_mef_eline.py ......                                    [ 26%]
tests/test_e2e_12_mef_eline.py .....Xx.                                  [ 29%]
tests/test_e2e_13_mef_eline.py ....Xs.s.....Xs.s.XXxX.xxxx..X........... [ 44%]
.                                                                        [ 44%]
tests/test_e2e_14_mef_eline.py x                                         [ 45%]
tests/test_e2e_15_mef_eline.py .....                                     [ 47%]
tests/test_e2e_16_mef_eline.py ..                                        [ 47%]
tests/test_e2e_20_flow_manager.py ......................                 [ 56%]
tests/test_e2e_21_flow_manager.py ...                                    [ 57%]
tests/test_e2e_22_flow_manager.py ...............                        [ 62%]
tests/test_e2e_23_flow_manager.py ..............                         [ 68%]
tests/test_e2e_30_of_lldp.py ....                                        [ 69%]
tests/test_e2e_31_of_lldp.py ...                                         [ 70%]
tests/test_e2e_32_of_lldp.py ...                                         [ 71%]
tests/test_e2e_40_sdntrace.py ................                           [ 77%]
tests/test_e2e_41_kytos_auth.py ........                                 [ 80%]
tests/test_e2e_42_sdntrace.py ..                                         [ 81%]
tests/test_e2e_50_maintenance.py ............................            [ 92%]
tests/test_e2e_60_of_multi_table.py .....                                [ 94%]
tests/test_e2e_70_kytos_stats.py ........                                [ 97%]
tests/test_e2e_80_pathfinder.py ss......                                 [100%]
=============================== warnings summary ===============================
= 243 passed, 8 skipped, 9 xfailed, 7 xpassed, 1295 warnings in 12445.82s (3:27:25) =

Looks good to me. How oftern kytos/flow_manager.flow.error is sent? Now that old_path is sent through event. This event notifying an error could not be related to failover flows or current path flows but when it is caught both failover_path and current_path are deleted.

How oftern kytos/flow_manager.flow.error is sent?

flow_manager publishes this a result of either a 1) OFPT_ERROR (unsupported flow) or 2) a socket error, which can happen if force=True isn't set.

but when it is caught both failover_path and current_path are deleted.

Right, for 1), that's safe since it can recover from an ofpt_error. But for 2) since all flows installation is using force=False, then it should respect the exc handling that you implemented with EVCPathNotInstalled which would detect which path failed. But if we were to have force=True for flows installation for either of the entire path then that handler wouldn't be able to different easily as you pointed out.
Let me know if you're seeing any other potential issue here @Alopalao.

I also exercised a bit more the original issue, it no longer happens, tried 10+ times with 100+ EVCs.


[feat/stream-config] Enable Stream config to avoid hardcode in base o…

Enable stream for completion_api
I'm working with Azure OpenAI. which does not support stream features.
Instead of having hardcode stream=True, I enable this config for openai_api.py.

https://github.com/geekan/MetaGPT/issues/1257

right. https://github.com/geekan/MetaGPT/pull/1258 solved this.


the current version is not compatible with ng2-translate 4.0.0

Hello, would you please fix the problem? Because if I used ng2-translate 3.0.0, it would contain bugs.  Thank you a lot.

Will get to it as soon as possible. Thank you for the information.

Solved by 07978e59dc3923c5dbe81f58cb7d2e2924510cbc

Thank you so much +1:

You're welcome :)


Add a compiler flag to disable string pooling

This PR adds a global compiler flag to easily toggle "string pooling" on and off for the small number of libraries that support it. For "realistic" data sets string pooling would most likely slow things down. It is only beneficial here because of how the data set is created by repeating a relatively small number of rows. This leaves pooling enabled, so future runs will be consistent with past results.

@MarkPflug , dont forget RecordParser. You can find by searching "var cache = new InternPool();"

Looks great, thanks Mark! And @leandromoh, I'll do a pass over all tests to double check this applies to RecordParser and other libraries properly.


Add QoS Parameter support to Developer Studio

Description:
Add following parameter support for RabbitMQ Inbound EP configurations
<parameter name="rabbitmq.channel.consumer.qos">1</parameter>
Affected Product Version:
3.8.0
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Already fixed with https://github.com/wso2/devstudio-tooling-esb/pull/198/

@Drifftr : Can you point me to a blog or doc on how to achieve this?


Added English Guide

made detailed instructions
please let me know if i had made a mistake.
i couldn't make a chinese guide, since i don't know chinese
i made a github gist with the same information

What you wrote is wonderful! However, I suggest that you create a new docs folder and put your tutorials in this folder, as is the case with some standard projects. I will merge your requests as soon as you have done so.


Added UI for Resource_Sharing_Form Ref: Issue #11

Super clean with no meaningless commits

@all-contributors please add @Sapphire-Skies for design


use shoelace icons for custom actions

Since the new vi uses shoelace, the corresponding icons must be changed:
https://github.com/viur-framework/viur-core/blob/develop/src/viur/core/modules/user.py#L1057 to "trash"
https://github.com/viur-framework/viur-core/blob/develop/src/viur/core/modules/user.py#L1076 to "interface"
https://serene-allen-537100.netlify.app/components/icon/

fixed by #852


Support Swift 5

Update to Swift 5, and use official Docker images for CI.

@djones6 This PR introduced a number of new warnings when compiling.  They should probably be fixed as soon as you can get to them.  Thanks.

@djones6 Don't worry about the warnings, I fixed them.


add conversion methods for SCDistance

Class should have the following instance-side conversion methods:

[ ] Distance>>asParsec and Distance>>asParsecs
[ ] Distance>>asLightyear and Distance>>asLightyears
[ ] Distance>>asAU
[ ] Distance>>asKiloMeter and Distance>>asKiloMeters
[ ] Distance>>asMeter and Distance>>asMeters
[ ] Distance>>asMiliMeter and Distance>>asMiliMeters

blocked on #15, since a Distance class doesn't exist as of https://github.com/303adastra/StellarCartography/commit/c95903a9e4b81f65d352176d4eb07c5d73dfe4b8


Quanta Toolbar

Transfer code from slots_quanta_split_form_undo branch

@tiberiuichim @avoinea coming along nicely :)

@tiberiuichim I guess the intention was that BlockToolbarItem is used by all the toolbar items, right? But then, how about the PluggableMenuSection?


Story limitations

Hey, I'm looking to work on this project. Care to explain?

Hey, @DsChauhan08! Thank you for expressing interest in collaborating on our novel project. The task at hand involves empowering users to define certain limitations for their stories. These limitations could include factors such as the total number of story parts, the word count or character limit for each story part, or even the maximum number of story parts allowed per user. By implementing these limitations, we aim to provide story creators with a sense of creative directorship over their own narratives.
Here are a few examples of how these limitations can be implemented:

Total Number of Story Parts: Users can set a specific limit on the number of parts that their story can have. For instance, they may choose to allow a maximum of 10 parts for their story. This ensures that the story remains concise and focused.
Word or Character Limit per Story Part: Users can define a limit on the number of words or characters allowed in each part of their story. For example, they may decide to set a maximum of 500 words or 3000 characters per part. This encourages writers to be concise and thoughtful in their storytelling.
Maximum Number of Story Parts per User: To prevent a single user from dominating the storytelling platform, a limitation can be imposed on the maximum number of story parts allowed per user. This ensures that multiple users have the opportunity to contribute and collaborate on the platform.


Fix config history changes styling

Reviewers:
@yujunglo
Fix overlapping rows in changes column in config history

Thanks for the fix. r+


Documentation in plonky2 crate

The plonky2 crate is not documented properly.
Even though the whole thing is open source, anyone who wants to use it must figure out what most of the API does by code digging.
Notable examples include:

many plonky2::plonk::CircuitBuilder methods are undocumented,
many plonky2::gates::gate::Gate methods are undocumented.

As far as I know, there is a lack of adequate tutorials (the PolymerLabs tutorial is super useful for the basics, but it is inadequate if one wants to use the crate in a project) or explanations about the code, which makes it hard for newcomers to understand what is going on in plonky2, and what functions should be used/preferred/avoided.
I can offer to help write the missing documentation, but given my lack of experience I doubt i could be of great help, without someone to ask what each thing does.
If you want me to help please let me know.

Thank you for reaching out! It's true that our main focus recently hasn't been too much around documentation of the plonky2 crate. I'll dedicate some time to it within the next 10 days to help clarify as much as possible the API for external parties.
Because documenting properly the entire codebase would probably be a longer term effort, if you could point me to which parts (apart from CircuitBuilder and Gate) documentation would be useful for external contributors, this would be great!

Thanks for the quick answer!
In this first answer i will focus on gates.
What are gates for?
Part of the problem is that it is not obvious to me what gates are for. All of the traits required for their implementation are public, so I guess you want to leave external users with the possibility to implement their own.
Many people will have repeated units of logic in their circuit, and a natural thing to think (maybe this is a misconception I have) is that one could use Gate for library building with plonky2, i.e. to implement some circuit logic in a standardized way.
Another approach to library building would be to just implement new traits on CircuitBuilder, whose functions implement some standardized logic by using already available functionality as building blocks.
What is not clear to me is when to follow one or the other approach, because no general guidelines are available.
I suggest a good place to put this kind of guideline could be on the documentation of the Gate trait itself.
num_constraints
this one was a somewhat easy catch, but it was not immediately clear to me that, if you are implementing a gate X, and X uses another gate Y, you should not count Y's constraints towards the number of X's constraints.
While this could seem obvious in hindsight, no definition for num_constraints is provided, and this could lead to implementation errors/frustration.
eval_ functions
There are many variants, and getting an intuition of the differencts takes some time. After hours of code digging, I have some idea of what the _circuit suffix means, and about what the _unfiltered/_filtered suffixes mean, but I cannot say my intuition is precise knowledge. Moreover, I could not really understand if this is something the user should even worry about.
I have many more questions, but that is more curiosity than something practically useful.

Thank you for your input, that's really valuable, and will help narrow down the immediate focus for stronger documentation.

Oh god I just realized I skipped over the "(apart from CircuitBuilder and Gate)" parenthesis in your message -.- sorry about that.

No worries, at least you clearly explained what wasn't clear, which can not be obvious for maintainers who have been heavily involved in the library for some time.
I would nonetheless point out, as a global advice for anyone aiming at building on top of plonky2 (or more generally any zk proving system implementation), that building zk-applications / tailored circuits is hard, tedious, error-prone, and should be left to cryptographers or users familiar enough with the cryptographic notions involved, as the consequences of a badly designed circuit can be disastrous.

Thank you for the word of warning. Even though I am not a cryptographer, I do have a mathematical background. I can more or less follow the arguments in the writeup linked in the repo's docs, which alone solved many of my initial doubts. That said, you are absolutely right in saying that anyone in my position can easily do gross mistakes.
However, assuming too many things about how the math maps to the actual code and filling in the gaps with imagination is not a good strategy. This is also a big part in my motivation to properly look around the repo before writing anything with it.
Also, I took too long to edit my previous message, sorry again. In case you didn't read it, I added a couple of sentences about CircuitConfig.

@Gorzorg I've added some documentation in the linked PR which I hope will clear some things out. It's not covering the entire list you gave, nor is as deep as you may have hoped for some of its components, but I intend on expanding it with follow-up PRs whenever I have some time.

I just finished reading the changes. Thank you! While you are right in saying one may wish for more on some components, this is already super useful. Thanks again :)

We'll try putting some more effort on documentation in the near future, feel free to specify any items that you think would deserve more scrutiny!

So, lately I have been busy making a circuit that employs cyclic recursion. While I eventually managed to make it work, I had to understand how to perform the bootstrapping procedure (I am not implying that now I know what I am doing!) one has to make for getting the right circuit data for cyclic recursion.
Even after making it work, I don't really understand why it works exactly, and I don't understand why that procedure cannot be automated. Maybe some documentation could avoid other users similar questions, and clarify my current doubts.

Thanks for the notice @Gorzorg, I'll try getting some time to wrap-up more explicit doc around this area in the coming days!


[Architecture] Calendar Notification Action

Part of the OSS Architecture track
User Story: When someone assigns themselves an issue, the issue's project date (deadline) will create a calendar reminder to the user's email so they know when they ideally need to have the PR turned in by
Task

[ ] Within the .yaml workflow files, configure the a google calendar Action for this project
[ ] Add inline comments

Directions: https://www.youtube.com/watch?v=EvfaxIWDMC4
Resources:

What is an Action
Our current workflows
Getting started with GitHub Actions
How to use Copilot to write your action recording
If you're done with your task and want to suggest one of your own, check out marketplace

I would like to work on this issue for tomorrow's pair programming hour, thank you!

Hi! I tried following the video tutorial to utilize Microsoft graph to see if I can create an event in the user's calendar but my current action fails with the following message: Run anoopt/ms-graph-create-event-msal@v1
⌛ Getting access token...
✅ Got access token
⌛ Getting Graph client...
✅ Got Graph client
⌛ Creating event...
Error: 🚨 Error in createEvent function.
Error: Error
Error: Error
Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
this is my current yml setup:
/Users/GeorgeBigballer/Desktop/Bootcamp/Password-generator/.github/workflows/msGraphEvent.yml

I have registered an application on Azure AD and configured my client id and secrets following the instructions found here: https://github.com/anoopt/ms-graph-create-event-msal

I would like to add a blog in addition to the documentation, to paint a better picture on all these variables required:
https://anoopt.medium.com/github-actions-create-an-event-with-microsoft-graph-using-msal-ee7aa7b49dc7

Hello all, please see pull request #834 for this pull request.
The current working action as outlined in the pull request follows these sequence of steps:

User assigns themselves to an issue
The action triggers a workflow run, and gets the following information : Issue title, assigned date, username
The action appends a comment automatically with a Google Calendar Link that will have the issue's title, a tentative due date for the issue (3 weeks from assignment)
The user then follows the link to create an event in their perspective calendars.
The user is free to modify the due date and when they would like to be reminded


fix: Change Datasource styling fixes

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12165 (c5c95dc) into master (ce1abc9) will decrease coverage by 3.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #12165      +/-   ##
==========================================
- Coverage   65.87%   62.71%   -3.16%
==========================================
  Files         994      994
  Lines       49054    49041      -13
  Branches     4979     4980       +1
==========================================
- Hits        32314    30758    -1556
- Misses      16599    18083    +1484
- Partials      141      200      +59

Flag
Coverage Δ

cypress
?

javascript
61.22% <100.00%> (+<0.01%)
:arrow_up:

python
63.68% <ø> (-0.57%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce1abc9...c5c95dc. Read the comment docs.


Activating and downloading data from planet labs

Planetlabs provides remote sensing data that can be accessed by registered users. Documentation on their API and using custom python package is available, but not much information is provided for R users apart from this post.
I created an extended version of the latter to search, activate and download images from planet labs, see this gist. Could be useful to integrate this into tutorial.

@damianooldoni will follow this up with Stien Heremans.

Next Monday, (August 26th), I meet Stien Heremans to get a look on this.


Floem

[ ] Added an entry to CHANGELOG.md if this change could be valuable to users

what is this pr?

what is this pr?

This is a rewrite of Lapce to use a different UI library (Floem) that will generally work better and be nicer to write. (There's discussion of it in the floem channel on Discord)


Segfaults in LG 5.5.1 caused by rule line length?

Check grammars for ALE50, lines 60-62, if the segfaults in LG caused by rule line lenght greater than particular threshold. Based on that, decide which of three MST-parsing runs have to be re-tried (two failed to open grammar, aother took 200+ hours to complete)
For starters, need to list max lengths of rules (overall, or words/disjuncts separately) for dict files in lines 57-63 for ALE-50 in "Parses" tab:
https://docs.google.com/spreadsheets/d/1o-4acGPxkMIS6-xJDxwjqDWAwIt8qx2xPemu14IZRaU/edit#gid=963717716

ALE50 dictionary line length

CORPUS  Maximum rule length
abs     2008003 bytes (1960.94 Kbytes)
any     4686148 bytes (4576.32 Kbytes)
lge     1082744 bytes (1057.37 Kbytes)
rnd     1616526 bytes (1578.64 Kbytes)
seq     373869 bytes (365.11 Kbytes)
w10     4649181 bytes (4540.22 Kbytes)
w6r     3757744 bytes (3669.67 Kbytes)

It appeares that link-parser failes when rule length is crossing 4 Mb boundary.


Language Issue: displaying English in some fields, even when other languages are selected

Strangely website is displaying other language when selected for a particular language.
when English is selected some other language is displayed in some fields.
when any other language is selected other than English there are many fields which are displaying other than the selected language .
New Microsoft Office Word Document.docx

Duplicates #2440


[Tests] Setup unit test for rest server

Setup unit test for rest server, use Mocha for testing and Chai for Assertion.

do you plan to replace npm with yarn in rest server?

It's not urgent to use yarn, we can replace npm later in another PR.


Cannot make Model implement ParentListItem

What would can i do if for some reason my model class cannot implement the ParentListItem interface? Is there any workaround?

I don't understand how it wouldn't be able to implement it. Please explain.
Otherwise, I suppose you could make another class, implement the interface, and have it contain an instance (object) of your parent model class, but I don't recommend that.

Yea, if you are using objects that are out of your control (from another library etc). You can have an object be a wrapper for that object, and have that wrapper implement the ParentListItemInterface.


Update DEVELOPERS.md

Issue #

update DEVELOPERS.md #659
Changes

-

Flags

Related Issues

Issue #
Pull Request #

Coverage remained the same at 99.584% when pulling dcaa062bda2ef29d69b61c6fd4d65d422ec6c29e on Shivansh2407:patch-1 into fee7d9a9672bc5d04b57ce75848ebf8cb6419872 on accordproject:master.

Yes it is because there I updated only a link of main repo

Thanks @Shivansh2407, however, unfortunately, this is a duplicate PR, @Parikshit-Hooda claimed this one first.  I'll leave this PR for a few days to give @Parikshit-Hooda chance to finish his work in the other PR.
Please see the comment at https://github.com/accordproject/ergo/pull/661#issuecomment-538682969

@irmerk please merge the PR if if you feel the issue is solved

@irmerk please merge the PR if if you feel the issue is solved

@Shivansh2407 you'll want to refer to @mttrbrts's comment here:

Thanks @Shivansh2407, however, unfortunately, this is a duplicate PR, @Parikshit-Hooda claimed this one first. I'll leave this PR for a few days to give @Parikshit-Hooda chance to finish his work in the other PR.
Please see the comment at #661 (comment)

Fixed in #672. Closing this PR.


sync method

hi,  seems you use the sync method, is that a good choice? why not async?

Where exactly?


The ENCODE array is changed in-place every time

function decode(res) {
  const jsonPayload = ENCODE.reverse().reduce((str, coding) => {
    ...
}

Array.prototype.reverse changes the array in place, is this desirable in this case? The second time load is called (and decode too as a result), ENCODE.reverse() should have the same value as ENCODE in the beginning, i.e.
> ENCODE = ['a', 'b']
["a", "b"]
> ENCODE.reverse()
["b", "a"]
> ENCODE.reverse()
["a", "b"]

As long as we can come up with a failing test for this, we should probably just be using reduceRight instead.

Big thanks for the fix!

Thanks for the report!


Python Linter

We are starting to write a large amount of python using varying styles. We should start using a linter to enforce formatting and stylistic guidelines
Pylint seems be the defacto linter. By default it enforces PEP8 which is the official standard. I don't necessarily agree with all of PEP8's standards and we can customize it with a pylintrc, however we should keep that to a minimum
Is it possible to include this with our CI stuff as well? That might be cool

Agreed. I personally prefer to use auto formaters (autopep8 in this case) and just stop having format arguments. Lint rules would be a great add. We can create tasks to run pylint for sure.

I agree too. That way we have consistency across all scripts. I am also in favor of lint rules.


Rates attribute not updating

Describe the bug
The rates have not updated since I updated to the latest version today.  I noticed the current rate was wrong and it's still displaying the rate it was 13.40 this afternoon.
To Reproduce
Unsure.
Expected behavior
Correct rate to show
Home Assistant Version
2023.2.2
Integration Version
5.4.0
Fresh Install?
Upgrade but I've only been using homeassistant for a week.
Home Assistant Logs
This error is appearing in the log
2023-02-05 13:45:55.765 ERROR (MainThread) [custom_components.octopus_energy.api_client] Request failed (https://octopus.energy/api/v1/tracker/E-1R-AGILE-FLEX-22-11-25-D/daily/past/1/0): 503; {"error": "We're currently unable to retrieve tracker data"}
Further info and screenshots.

{   "home_assistant": {     "installation_type": "Home Assistant OS",     "version": "2023.2.2",     "dev": false,     "hassio": true,     "virtualenv": false,     "python_version": "3.10.7",     "docker": true,     "arch": "aarch64",     "timezone": "Europe/London",     "os_name": "Linux",     "os_version": "5.15.76-v8",     "supervisor": "2023.01.1",     "host_os": "Home Assistant OS 9.4",     "docker_version": "20.10.19",     "chassis": "embedded",     "run_as_root": true   },   "custom_components": {     "rpi_gpio": {       "version": "2022.7.0",       "requirements": [         "RPi.GPIO==0.7.1"       ]     },     "sonoff": {       "version": "3.3.1",       "requirements": [         "pycryptodome>=3.6.6"       ]     },     "octopus_energy": {       "version": "5.4.0",       "requirements": []     },     "dwains_dashboard": {       "version": "3.3.0",       "requirements": []     },     "localtuya": {       "version": "5.0.0",       "requirements": []     },     "hacs": {       "version": "1.30.1",       "requirements": [         "aiogithubapi>=22.10.1"       ]     }   },   "integration_manifest": {     "domain": "octopus_energy",     "name": "Octopus Energy",     "config_flow": true,     "documentation": "https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/",     "issue_tracker": "https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/issues",     "ssdp": [],     "zeroconf": [],     "homekit": {},     "dependencies": [],     "codeowners": [       "@bottlecapdave"     ],     "version": "5.4.0",     "iot_class": "cloud_polling",     "is_built_in": false   },   "data": {     "electricity_meter_points": [       {         "mpan": "**REDACTED**",         "meters": [           {             "serial_number": "**REDACTED**",             "is_export": false,             "is_smart_meter": true           }         ],         "agreements": [           {             "valid_from": "2022-12-09T00:00:00+00:00",             "valid_to": null,             "tariff_code": "E-1R-AGILE-FLEX-22-11-25-D"           }         ]       }     ],     "gas_meter_points": []   } }

Hi I am getting the same problem.
Can you help me with a cure?
My error:-
This error originated from a custom integration.
Logger: custom_components.octopus_energy.api_client
Source: custom_components/octopus_energy/api_client.py:264
Integration: Octopus Energy (documentation, issues)
First occurred: 10:06:33 (24 occurrences)
Last logged: 10:17:44
Request failed (https://octopus.energy/api/v1/tracker/E-1R-AGILE-FLEX-22-11-25-E/daily/past/1/0): 503; {"error": "We're currently unable to retrieve tracker data"}

It looks like my assumption with Octopus Energy naming was incorrect when trying to fix tracker based tariffs. I will try and fix as soon as possible, but in the meantime I suggest moving back to the previous update.

Ive got more errors in the log this morning, if these help.

Request failed (https://octopus.energy/api/v1/tracker/E-1R-AGILE-FLEX-22-11-25-D/daily/past/1/0): 503; {"error": "We're currently unable to retrieve tracker data"}
10:13:34 AM – (ERROR) Octopus Energy (custom integration) - message first occurred at February 5, 2023 at 1:43:55 PM and shows up 2460 times
Error doing job: Task exception was never retrieved
10:00:55 AM – (ERROR) Octopus Energy (custom integration) - message first occurred at February 5, 2023 at 2:00:56 PM and shows up 41 times
Unexpected error fetching rates data: 'NoneType' object is not subscriptable
5:02:27 AM – (ERROR) Octopus Energy (custom integration)
Failed to retrieve account
5:02:27 AM – (ERROR) Octopus Energy (custom integration)
Request failed (https://api.octopus.energy/v1/graphql/): 504;  504 Gateway Time-out  504 Gateway Time-out nginx
5:02:27 AM – (ERROR) Octopus Energy (custom integration)

Confirm a full delete and reinstall of the integration has got it working again, I went back to 5.3.1.
Thanks

I'm sorry that this caused such an issue. This should now be resolved in https://github.com/BottlecapDave/HomeAssistant-OctopusEnergy/releases/tag/v5.4.1

Closing issue as this should now be resolved.


fix for issue #89

added additional new line at the end of bullet list
added support for ordered lists

Hi
Thanks for your effort to improve markdown support
I've merged your pull request in currently develop branch and published SNAPSHOT (4.4.3-SNAPSHOT)
Soon I'll arrange a new release


Use pre-commit fork of clang-format instead of local

10/10 would use it again

What exactly wasn't working - I'm curious?

This doesn't require a certain version of clang-format to be installed
locally. Good if you want to use a different version locally but also helps
people who don't have the same setup to "just call pre-commit" for
formatting
On Wed, 1 Nov 2023, 19:26 Abrar Rahman Protyasha, @.***>
wrote:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/ros-controls/ros2_controllers/pull/813#pullrequestreview-1708883326,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA24PYLSER2TCGO7R5OXZDDYCKO5NAVCNFSM6AAAAAA6ZYL66KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBYHA4DGMZSGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Add support for GDTask.Current

Thank you for this library!
Is it possible to add support for GDTask.CurrentId similar to Task.CurrentId?
In my case I need to figure out which task I'm in, to create a subtask.

Most of the source code is from the UniTask library, and I'm not sure if UniTask implements any way to check which task is currently being ran.


Background subsystem throws an error when it tries to call transition_finished after background node isnt in tree anymore.

The problem
When using the background event with a fade time of lets say 3 seconds, while transitioning, we move onto the next background event or end the timeline, an error pops up saying "Error calling from signal 'transition_finished' to callable: 'Node(subsystem_backgrounds.gd)::_on_transition_finished': Cannot convert argument 1 from Object to Object."
To Reproduce
Steps to reproduce the behavior:

Add background event to timeline with fade time of 0
Add a text event
Add background event to timeline with fade time of 3 without any image

System (please complete the following information):

OS: Windows
Godot Version: 4.2.1.stable
Dialogic Version: 2.0.a13

Possible fixes
Disconnecting transition_finished before freeing the node should probably fix it. Or checking if node still exists when calling transition_finished.

I will take a video soon and send it here or in Discord 👍


Replace MASTER_ADDR with OMEROHOST

See gh-5

Since you're fixing this can you add the missing \ after the first line in both examples?

Done.


fix(Bug): Added relavant documentation links to the quickstarts in the notifications category

Summary
Added relevant documentation links to the 5 quickstarts in the "Notifications" category.
The 5 quickstarts are

Atlassian Jira
Email notifications
ServiceNow notifications
Slack notifications
Webhook notifications

Hi @akristen ,
Requesting you to kindly review these changes.
Thank you.. 😀


add INACTIVE notice

Since Pacto is not being used actively, we are not maintaining it and giving the attention required to keep an Open Source project alive and stable.
So this note helps people to have the proper expectation while using it.

Thanks. Will merge when I get to a computer...
On Fri, Sep 23, 2016, 6:19 AM Thiago R. Colucci<EMAIL_ADDRESS>wrote:

Since Pacto is not being used actively, we are not maintaining it and
giving the attention required to keep an Open Source project alive and
stable.
So this note helps people to have the proper expectation while using it.
You can view, comment on, or merge this pull request online at:
https://github.com/thoughtworks/pacto/pull/187
Commit Summary

add INACTIVE notice

File Changes

M README.md
https://github.com/thoughtworks/pacto/pull/187/files#diff-0 (9)

Patch Links:

https://github.com/thoughtworks/pacto/pull/187.patch
https://github.com/thoughtworks/pacto/pull/187.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/thoughtworks/pacto/pull/187, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA2vbqk-KuuaP5jgwKWUegzhPh6oWzNfks5qs6eTgaJpZM4KE0x6
.


Detect node name collisions and throw an error

What this PR does / why we need it:
When there is a container node that contains two or more nodes with the same name a warning is displayed.
Which issue(s) this PR fixes:
Fixes #184
Special notes for your reviewer:
Release note:

When collisions with node names collide, a warning is displayed.

/assign @Kristian-ZH @swilen-iwanow


Web: Use Intl.ListFormat rather than .join(", ") #26936

This PR fixes a web issue by replacing the inconsistent .join(", ") with Intl.ListFormat for accurate and localized list formatting, using a common utility function.
fixes: Use Intl.ListFormat rather than .join(", ") #26936

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@CIC4DA  I'm having  problem with merging while  pull request  here is the ss please  help me figure out how  can I  fix this

Some of these call sites absolutely must not be internationalized, such as when joining CSS selectors.

style: "narrow" is not appropriate for every use. We need to check this on a case-by-case basis, but I think we will usually want the default style: "long". The type may be important in some cases as well.

Safari doesn’t support Intl.ListFormat on macOS 10.15 and earlier, so we need a fallback or polyfill.

Got it, thanks for the heads up! I'll start working on addressing these concerns.
Could you please specify the files or components where we need to be mindful of internationalization,
According to me we could use internationalization with  {style: long, type: conjuctions} in all other files I have changed except in reactions and realm_playground.
If you could update me about this, I will make the required changes in PR with fallback for macOS.

@andersk, Could you please review it again.
I have resolved the following issues:

[ ]  Add a fallback system for MacOs.
[ ]  Files which were not supposed to be internationalized are reverted back to using .join(", ").
[ ]  Introduced { style: "long", long: "conjunction" } could be changed according to use.
[ ]  Refactor tests to test with the new changes.

@andersk could you please review my PR and let me know if there are any tweaks needed,
Thanks.

Since this PR contained a lot of commits, I have resolved that and made a new PR #28453, for this issue.