spark.app.name is overwritten

I have noticed that spark notebook ignores the spark.app.name I have set within the Notebook Metadata in favour of the notebook name itself e.g. spark.app.name=Test.snb. Is this a bug or a misconfiguration on the notebook metadata?

{
"name": "notebook",
"user_save_timestamp": "1970-01-01T00:00:00.000Z",
"auto_save_timestamp": "1970-01-01T00:00:00.000Z",
"language_info": {
"name": "scala",
"file_extension": "scala",
"codemirror_mode": "text/x-scala"
},
"trusted": true,
"customLocalRepo": "notebook",
"customRepos": null,
"customDeps": null,
"customImports": null,
"customArgs": null,
"customSparkConf": {
"spark.cores.max": "4",
"spark.master": "spark://<IP_ADDRESS>:7077",
"spark.app.name": "notebook",
"spark.executor.memory": "4G"
},
"kernelspec": {
"name": "notebook",
"display_name": "notebook"
}
}

if I remember well, it's being overridden by notebook file name (which is default if you don't set it), which allows to consistently identify which notebook is running.
why do you need spark.app.name at all?


[Bug]: The pre-check for multi-database changes fails,and the permission check result is not displayed

ODC version
ODC4.3.0
OB version
No related.
What happened?
The pre-check for multi-database changes fails,and the permission check result is not displayed.

What did you expect to happen?

How can we reproduce it (as minimally and precisely as possible)?
Enter a sql statement for a library that has no permissions.
Anything else we need to know?
No response

Fixed In Commit ffbf2c9250018c2aef3f11dbf83c70f0c7fa8824
------
陈朝俊
Tue Jun 4 20:45:13 2024 +0800

pass


loginWithRedirect with routes : true triggers loginWithIframe causing invalid_state error

Description
I'm trying to use the latest 2.x version of SalteAuth with Angular. Calling loginWithRedirect with all routes secure returns the invalid_state error code "State provided by identity provider did not match local state."
Debugging SalteAuth I found the following occurs in this order:

$$onRouteChanged is getting called during the login. I'm not sure why. Maybe changing from nothing to the initial route?
Since all routes are secured it calls retrieveAccessToken
The user isn't logged in yet so the idToken is expired. This results in loginWithIframe being called
This results in a new call to $loginUrl. This changes the profile's $localState because $loginUrl always sets the $localState to a new uuid
This causes the state mismatch as the loginWithRedirect url passes a different state than what is in profile.$localState

Expected outcome
SalteAuth.loginWithRedirect only calls loginWithRedirect internally and passes the correct state
Actual outcome
SalteAuth.loginWithRedirect passes the wrong state due to both loginWithRedirect and loginWithIframe being called internally
Steps to reproduce

Angular 5 app. I don't know if this matters.
Call loginWithRedirect with a config similar to the one below, routes: true seems particularly important.

this.auth = new SalteAuth({
  provider: 'wso2',
  clientId: authConfig.clientId,
  providerUrl: authConfig.provider,
  responseType: 'id_token token',
  redirectUrl: location.origin + '/authorize',
  redirectLoginCallback: this.handleRedirect.bind(this),
  scope: 'openid',
  routes: true,
  endpoints: ['/api'],
});

@pherrmann Thanks for submitting an issue!
If you end up submitting a PR for this issue then I'd be happy to look at it.
Otherwise I'll try to look into it sometime this week.

I don't immediately have a solution. I'll submit a PR if one comes to me.
The state mismatch alerted me in a round-a-bout way that a second login was occurring while the first one was being processed.
Perhaps, it could check to make sure it's not already processing a login when it falls into the $$onRouteChanged flow. $$onRouteChanged appears to be bound to document 'click' and window 'popstate' events

Created a small demo showcasing the issue out on Glitch.
Demo
https://salte-auth-135.glitch.me
Steps to Reproduce

Enable persistent logs in Chrome (so that the error doesn't get lost)
Hit here to clear your cache for that site.
Navigate to the mini-app.
Login
At this point the error SHOULD occur.

@pherrmann Let me know if v2.1.3 resolves the issue you were seeing!

Your update is an improvement as it's no longer calling login twice. However, it appears I'm ending up with the same issue for a different reason.
After avoiding the extra loginWithIframe call, retrieveAccessToken goes on to make a call to retrieve the access token. This calls $accessTokenUrl which updates the profile's $localState to a new uuid. This results in a state mismatch error and and an extra call to retrieve the access token.
Could $$onRouteChanged check for login promises before calling retrieveAccessToken?
$$onRouteChanged() {
  if (!this.$utilities.isRouteSecure(location.href, this.$config.routes)) return;
  if(!this.$promises.login) { // don't retrieve access token while logging in
    this.retrieveAccessToken();
  }
}


bungeecord/waterfall/multiverse support

What does your feature do?
Someone else had asked this, but I was wondering if there would be a possibility to add support for bungeecord/waterfall so you can do quests that take place over 2 servers. OR multiverse support. This would be very nice for mmorpg servers.
How would people use it?
Well, it might expand features where you can from one world to another to continue the quest. mmorpg server will probably benefit from this.

Essentially duplicate of #312


HDDS-3632. starter scripts can't manage Ozone and HDFS datandodes on the same machine

…
since the service names are same and they both referring to same location for pid files, we can not start both services at once.
Tweak is to export HADOOP_PID_DIR to different location after starting one service and start other one.
It would be better to have different pid file names.
Umas-MacBook-Pro ozone-0.5.0-beta % bin/ozone --daemon start datanode
datanode is running as process 25167.  Stop it first.

What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3632
How was this patch tested?

Started a new cluster with compose/ozonescripts
Fixed the configuration (will be uploaded in a separated jira)
Used ./start.sh
Checked if cluster works (ozone sh + volume, bucket, key create)
Checked if the /tmp/*.pid contains ozone name on the datanodes.

Merging. Thanks the review @adoroszlai @arp7 and @umamaheswararao (and the report @umamaheswararao)


Chrome width resize bug

Platform
MacBook Pro 15" - macOS 10.12.5 - Chrome 60.0.3112.113 (64bit)
Description
Content will not reduce width inside a grid with fixed/fluid/fixed width columns when container is narrowed.
Steps to reproduce
Create page with the following HTML/CSS.

Fixed

Fluid

Fixed

.grid {
  background: lightpink;
  display: grid;
  grid-template-rows: 200px;
  margin: 0 auto;
  width: 98vw;
}

.flf {
  grid-template-columns: 200px 1fr 200px;
}

.element {
  background: lightblue;
  color: #000;
  grid-row: 1;
  height: 200px;
  outline: 1px solid black;
  width: 200px;

  &:nth-child(2) {
    margin: auto;
  }
}

Widen, then narrow, the viewport and witness the content not resize with the container.
Demo
See https://codepen.io/evolutionxbox/full/gxyvzB/

I'm confused as to what you are trying to do. What are the auto margins for?
Can you create a reduced test case that clearly demonstrates what you are experiencing? You currently are:

Using Sass
Including autoprefixer which is adding -ms-grid properties
Have multiple examples in one test case

None of these things are going to help you or me. I'll take another look if you can clarify what you actually think the issue is.

Yep. Indeed I shall.
I posted the other examples to show that the issue does not occur using other variants of fixed unit and fraction units.
As for the SCSS and auto-prefixer, that's a default setting in my code pen. I shall update it and post again to confirm whether the issue is still present.


Better documentation for upgrades

I've just upgraded Shipyard, and due to lack of documentation about which data was stored where, I simply gave up and deleted all the containers and images and reinstalled using the script again.
The best way to fix this would be to make a similar script for upgrading, but simply having ONE simple page where you can see which images to keep and which to recreate would solve this for me.

Thanks for the feedback.
On Jan 12, 2016 7:52 AM, "Tom Fagerland"<EMAIL_ADDRESS>wrote:

I've just upgraded Shipyard, and due to lack of documentation about which
data was stored where, I simply gave up and deleted all the containers and
images and reinstalled using the script again
The best way to fix this would be to make a similar script for upgrading,
but simply having ONE simple page where you can see which images to keep
and which to recreate would solve this for me
—
Reply to this email directly or view it on GitHub
https://github.com/shipyard/shipyard/issues/724.


create a new folder and a new file

add a new file about cluster,and translate it into Chinese in next month

Seems those changes not belong here

I found some English documents and some Chinese documents in this path: website/content/cn/docs/tutorials.
So maybe some more Chinese documents are needed in website/content/cn, am I right?

@wangxy518 @stewart-yu 👋 The https://github.com/kubernetes/kubernetes-docs-zh repo is the place for Chinese localization work. Please reopen this PR there.


Releases page shows the latest + links to past

Fixes #41. Also brings back the RSS link at the bottom.

And the links are blue.


JustifyContent: <left/right> Crashes on Android with No Errors

Description
When adding to the style prop on react native components, if the css property justifyContent is set to "left" or "right" the app crashes on Android immediately and provides no error output.
Screenshots are a bit underwhelming for this bug since no error output is given. justifyContent: "left" is a supported value in web and works for iOS, yet adding this style tag crashed one of my native Android applications. This became a difficult bug to track down since no output was given.
Version
0.69.5
Output of npx react-native info
info Fetching system and libraries information...
System:
OS: macOS 11.6.1
CPU: (32) x64 AMD Ryzen 9 5950X 16-Core Processor
Memory: 516.77 MB / 32.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node
Yarn: 1.22.19 - ~/.nvm/versions/node/v16.17.0/bin/yarn
npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.9.3 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.2, iOS 15.2, macOS 12.1, tvOS 15.2, watchOS 8.3
Android SDK: Not Found
IDEs:
Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
Languages:
Java: 12.0.2 - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 18.0.0 => 18.0.0
react-native: 0.69.5 => 0.69.5
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce

Add the css tag justifyContent: "left" to the style property of any component
Run the application on Android

The application crashes.
Snack, code example, screenshot, or link to a repository

import React from "react"
import {
    View,
} from "react-native"

const CrashyComponent = () => {
    return <View style={{ justifyContent: "left" }}></View>
}

export default CrashyComponent

I think you wanted justifyContent: 'flex-start'

I think you wanted justifyContent: 'flex-start'

Thank you for that suggestion. You are right, that is the value that I ended up using to get the styling to look as expected. However, the fact that there was no error makes me think this is a bug. Normally would see "invalid property value" or similar. left is valid for web and works on iOS, so maybe that is why react-native does not catch the error?

with proper lint setup it does show as error


Invalid SSL certificate Error code 526

Invalid SSL certificate Error code 526
Visit cloudflare.com for more information.
2024-08-06 02:35:57 UTC

Thanks for reporting this! We are aware and working on a fix :)

Yep, I disabled the Cloudflare proxy yesterday but forgot to re-create the simpleicons.org domain on GitHub pages settings. It should be ready in a few minutes 🤞🏼

Yep, I disabled the Cloudflare proxy yesterday but forgot to re-create the simpleicons.org domain on GitHub pages settings. It should be ready in a few minutes 🤞🏼

Still the same problem:

Seems resolved now.


[BEAM-8976] Initalize logging configuration at a couple of other entry points.

Ran across these while trying to do some debugging.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Run Python PreCommit

retest this please

Lint and RAT failed due to "No space left on device."

LGTM. Thanks Robert!

Run PythonLint PreCommit

Run RAT PreCommit


[BUG] - Input Label Placement is Wrong

NextUI Version
2.1.13
Describe the bug
Inputs were working perfect but when I updated NextUI they all started to put the label on top of the placeholder and the description is not showing. I'm not using react-hook-form on my app.
This is a snapshot of my code:

This is snapshot of UI issue:

I fixed this bug, importing Input component from '@nextui-org/input' instead '@nextui-org/react'
I'm working on Next.js 14.0.4 now but I saw the same issue with Next.js 13. Also using pnpm.
I don't know if it's a node package manager issue. Because it was working while we have pnpm-lock and package-lock files (by mistake) on root. It started happening also deleting package-lock to use pnpm-lock instead or removing node_modules and installing or upgrading dependencies again (with pnpm or npm).
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue

Install '@nextui-org/react' using pnpm
Import Input component from '@nextui-org/react'
Give a placeholder prop
Give a label prop

Expected behavior
I expect that importing Input from '@nextui-org/react' that component show the label and  description props correctly.
Screenshots or Videos
No response
Operating System Version
Windows
Browser
Chrome

I also ran into this bug, but under slightly different circumstances. It appears that the labelPlacement prop defaults to "inside" if no initial value or placeholder his provided. Even if labelPlacement is specifically specified as "outside" it will be placed inside unless either (1) an initial non-empty string is provided as a value, or (2) a non-empty placeholder is provided. I was able to work around this by providing a placeholder of " " with a blank space between the quotes. Not exactly a satisfying solution.

Hi @joseuribeh98 @rtopham! I am trying to reproduce this issue, however, I could not. Is this issue currently resolved? Thank you!

Hi @joseuribeh98 @rtopham! I am trying to reproduce this issue, however, I could not. Is this issue currently resolved? Thank you!

Hey there @kuri-sun as I mentioned, I've managed to fix this importing the component from @nextui-org/input. But I haven't tried again importing from @nextui-org/react

Hi @joseuribeh98 @rtopham! I am trying to reproduce this issue, however, I could not. Is this issue currently resolved? Thank you!

Hey there @kuri-sun as I mentioned, I've managed to fix this importing the component from @nextui-org/input. But I haven't tried again importing from @nextui-org/react

Hi there!
I bumped my @nextui-org/react version and encountered this bug too. To fix it, I had to update the theme package (npm i @nextui-org/theme@latest). After that, I switched back to the default input import and the placement was correct.

Not reproducible in latest version


Give error/warning when removing component (service) that is not in the system

Currently, you are allowed to remove a service from another system if they have the same name (I think) but then it breaks the uuid from devices that have the service.

The title of this issue seems to conflict with the description.
Regarding the title, if you call remove_component!(Service, sys, name) and there is no such service stored, it should throw an exception. Are you saying that this doesn’t work? (The exact Service type must be concrete.)
Regarding the description, the function signature is as follows:
function remove_component!(
    ::Type{T},
    sys::System,
    name::AbstractString,
) where {T <: Component}

If the system has a service matching type and name, it will be removed. If you call this on the wrong system, how can we detect that?

I believe this issue was more complicated than this. I'm killing myself here for not adding the code that created this issue, and I'm not able to replicate this issue.
I'm guessing this could be related with #1016, of adding the same service in two different systems, and then trying to remove one, creating issues in another system.
This is my bad, since I can't recall what was the test case I was using for this issue. @jd-lara Do you remember exactly about this issue? If not, we can close it for now, and re-open it once we encounter it again.


Add an option to skip overwriting warning on file upload

SuiteCloud Extension for Visual Studio Code v1.0.3
When uploading a file (SuiteCloud: Upload File), a warning dialogue is displayed, "The file in your account will be overwritten.."

Can an option be added to remove this prompt? It adds an additional step to a frequent part of the development cycle which many users don't require. This warning step does not exist in the CLI or WebStorm plugin.

Thanks for this.
We will look into it.


Remove unnecessary comment for AcceptAction

render_ci_done is not an argument of AcceptAction().
    def __init__(self, handler=None):
        assert handler is None or callable(handler)
        self.handler = handler

Thank you @38elements!
This is merged in: https://github.com/jonathanslenders/python-prompt-toolkit/commit/fab6c92c1ef7a6f79d3414b1f2e7988dbfe4b148


chore(ui): Colocate single-use utility functions in NetGraph

Description
A detailed explanation of the changes in your PR.
Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why
you did not do so. Valid reasons include, for example, "CI is sufficient",
"No testable changes". Feel free to attach JSON snippets, curl commands,
screenshots.
In addition to reviewing your code, reviewers must also review your testing
instructions and make sure they are sufficient.

Current dependencies on/for this PR:

master

PR #6939

PR #6950

PR #6965   👈

This comment was auto-generated by Graphite.


Write the README.md

Should include the following:

[ ] Installation steps. (Steal the ones from here).
[ ] Getting started example.

Assume that this repo is the entry-point for an application developer who has never used Material Motion before.

🎊 My diff is ready for review at http://codereview.cc/D1599


Documentation added

I will merge this pull request, but make a few adjustments aferwards. In the future, please create pull requests on the dev branch instead of the master branch.


[Bug]: OneDrive Auth modal not working on Mobile (iOS)

What happened?
The modal pops up when I click "Auth" but it doesn't include a link to actually authN with OneDrive.
What OS are you using?
iOS (iPhone, iPad)
What remote cloud services are you using?
OneDrive for personal
Version of the plugin
0.4.2
Version of Obsidian
1.4.16
Using password or not

[X] Yes.

Ensure no sensitive information

[X] I ensure that no sensitive information is submitted in the issue.

same issue on android

It looks like the modal contents are pushed off the screen. For what it's worth the modal displays correctly for the Dropbox flow, so I think this should be an easy fix 🤞

I tried to shorten the description before the URL is displayed to match the length of text in the Dropbox modal and that didn't do the trick (see 0.4.8). I think something on mobile is preventing it from loading any text into the modal at all. More investigation is required.

Can also confirm this is happening to me.
IOS 17.03 iPhone 11 Pro
Is there an alternative to get the auth link for now?

Here is the error it looks like I'm seeing on mobile, likely the reason OneDrive is the only one broken:
Uncaught (in promise) ClientAuthError: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: ClientAuthError: openid_config_error: Could not retrieve endpoints. Check your authority and verify the .well-known/openid-configuration endpoint returns the required endpoints. Attempted to retrieve endpoints from: https://undefined/common/v2.0/.well-known/openid-configuration
    at e [as constructor] (plugin:remotely-secure:49:52821)
    at new e (plugin:remotely-secure:49:62154)
    at e.createEndpointDiscoveryIncompleteError (plugin:remotely-secure:49:62837)
    at Function.eval (plugin:remotely-secure:53:3081)
    at d (plugin:remotely-secure:49:45170)
    at Object.eval [as throw] (plugin:remotely-secure:49:44474)
    at d (plugin:remotely-secure:49:44104)

Will need to investigate further. Not sure why it is working on Desktop but getting an invalid authority (my assumption based on error message & undefined in URL) on mobile. Something is odd

Tested on iOS, looks like it's working now! Was able to auth and sync, but didn't test much beyond that. Please open a new bug if sync isn't working (or reopen this one if the modal is broken still for you).

It’s working now. Thanks so much for the quick fix.

No problem!


Enable supplemental params validation with build-params command

Enable build-params command to use values from a BICEP_PARAMETERS_OVERRIDES environment variable  to update the .bicepparam file
This work is to support the Inline overrides use case for az cli
Microsoft Reviewers: Open in CodeFlow

Which milestone is this a part of? We are looking to use both bicepparams and inline parameters with our DevOps pipelines.

Which milestone is this a part of? We are looking to use both bicepparams and inline parameters with our DevOps pipelines.

This'll be available in the Azure CLI & Azure PowerShell upcoming releases on 11/14:
https://github.com/Azure/azure-cli/milestone/135
https://github.com/Azure/azure-powershell/milestone/152


Editor: Nothing shown in overview when the images are wide

Problem
When I open this on my mobile phone, the thumbnail is blank. The grid is enabled.
https://neoneye.github.io/arc/edit.html?dataset=ARC&task=281123b4
https://neoneye.github.io/arc/edit.html?dataset=ARC&task=0934a4d8
It seems like the cellsize was zero.
Solution

Set a minimum cellsize to 1.
If the aspect ratio is too wide/tall, so the cellsize drops below 1, then overdraw on the neighboring pixel.
Maybe render to a temporary image.
Maybe downscale the image to fit inside the container.

Now the ARC dataset can be viewed on a small device, with the grid enabled, and I don't see any more tasks that are blank.


feat: Add new features

Codecov Report
Attention: 142 lines in your changes are missing coverage. Please review.

Files
Coverage Δ

Sources/Trap/Config.swift
100.00% <100.00%> (ø)

Sources/Trap/Datasource/Gesture/Pinch.swift
83.33% <100.00%> (ø)

Sources/Trap/Datasource/Gesture/Pointer.swift
91.53% <100.00%> (+1.53%)
:arrow_up:

Sources/Trap/Datasource/Gesture/Swipe.swift
97.67% <100.00%> (ø)

Sources/Trap/Datasource/Gesture/Tap.swift
100.00% <100.00%> (ø)

Tests/TrapTests/Datasource/GestureTests.swift
95.55% <100.00%> (ø)

Sources/Trap/Datasource/Gesture/Touch.swift
88.62% <78.57%> (-2.35%)
:arrow_down:

Sources/Trap/Datasource/Gesture/Stylus.swift
89.91% <87.87%> (-5.79%)
:arrow_down:

Sources/Trap/Datasource/Gesture/Gesture.swift
68.80% <45.71%> (-8.86%)
:arrow_down:

...Datasource/Gesture/TrapWindowEventDispatcher.swift
0.00% <0.00%> (ø)

... and 1 more

... and 1 file with indirect coverage changes
:loudspeaker: Thoughts on this report? Let us know!.

I've fixed the whitespace issue:
https://github.com/cursorinsight/ci-trap-ios/compare/790198f2d0ed4a9da33e8082c0e3ce3dcd46030a..23de64cc501962105055d90a3cede70178f1148a


Question: Merge Obsidian Notes & Supernote pages?

I started to use Obsidian and have a Supernote nomad as well. I have the same folder structure on both, and same named notes on both. for example, in Obsidian, I have Folder-1/note1.md  and in Supernote I have Folder-1/note1.note
During meetings, I find myself typing on my PC to Obsidian if I have access to separate monitor to host Obsidian, while looking at meeting screens on other monitor.  But if I have only one monitor (ie laptop while in travel), I use my Supernote.
So now I have two notes on the same subject, one hosted in Obsidian and other in Supernote, having data from different timesets. ie I might have taken note today on note1 and tomorrow using Supernote for same note1.  Using your plugin, I can look at both, that is good, I can also copy OCRd text or pictures from supernote note file to Obsidian. But this is very manual process and I did not find the discipline to do it yet. I find myself going back and forth between the two and try to remember which note is newer.
Is there any chance, that the supernote OCRed text notes are mapped between & merged into the Obsidian notes automaticaly on sync based on timestamps?  for example, if I type somethign in my Obsidian, it goes into Supernote note file as text, so when I open my Supernote I can see that text, and if I continue writing on my Supernote on same page, it appears on Obsidian same note when synced, as OCRed text (no pictures needed even if OCR is bad).
I know, pretty difficult to do with conflicts etc. just wondered if there's a more automated way to merge both using timestamps.

I don't know how I would approach this feature. And, personally, it isn't something I have a desire to work on. So, I am going to close the issue. If you come up with a good solution I would be interested to see it though!


Async OnException

Currently the OnException callback isn't async. It cannot be because it is called in a when clause, as the thrown exception is being propagated up the call stack. An alternative solution is to have another (async) callback that is invoked when the user decide to handle the exception. This is prototyped on the branch AsyncOnException (needs more tests).

Alternative is to use throw instead of "throw ex". Page 1 and Page 2


Implement CONNACK packet

Was just messing around and thought this might be of use.

Very thank you for this addition, this very important code


Subscribe to a Language

Sign up to receive a random issue from a random repo from a specified language
We may need a new thing in addition to RepoSubscriptions to store this since a language isn't a repo. Also need a way of adding these issues to the daily email.
cc @DanielleSucher

Hi @schneems, Now that users can save their favorites languages in their profile on codetriage, I could select a random language based of their preference then find a random repo and finally a random issue belong to it. What do you think? I'll be able to work on it.

+1 for this feauture, it gives you a chance to get to know the broader aspects of a language (f.e. ruby is more than rails).

Hi, I tried working on this feature at #361. It's mostly done and with some test. Any thoughts? @schneems


Please add typings for use in Vue+Typescript

It would be awesome if this included typings for use with Vue+Typescript

Can you please give me an example?


Don't map non-alphanumerics to space in titleize()

Fixes #22.
I removed entirely the line that changes non-alphanumerics into spaces; doing so had no negative impact on tests. I may be unwittingly throwing the baby out with the bathwater.
I added a single test to cover the case that I was particularly concerned about.

Thanks!


Run happo via a node script?

I'm trying to run happo via a node script, and I'm running into a lot of issues.
// scripts/happoScript.js
const executable = '<repo path>/node_modules/happo.io/build/cli.js'

const happo = spawn(
  executable,
  happoArgs,
  {
    stdio: 'inherit',
  }
)

If I spawn this off, there's a couple of issues.
The 2nd problem: The script will return a signal before it should. So in my cmd line, the script executes, completes and kicks you back to the command line, and then randomly outputs. It's also confusing as if you mash on ctrl + c, it won't do anything, as you're not actually inside a process.
Let me know if any of this makes any sense at all. Thanks.

Hi @reywright! 👋
Can you describe the use-case behind running happo this way? I'm just trying to understand things better. Also, do you happen to have any error logs? 🙂
From a quick look, I think you could get things working by setting the cwd option for spawn. I just tried this locally, and it worked for one of my projects:
// ~/happoScript.js
const { spawn } = require("child_process");
const path = require("path");

const executable = "node_modules/happo.io/build/cli.js";

const happo = spawn(executable, ["run", "--only", "Button"], {
  stdio: "inherit",
  cwd: path.resolve(process.cwd(), "happo-project")
});

where happo-project is a folder in my home directory (~) where a happo project is located.
Also, while this is most likely not an issue (I don't plan on changing where that cli.js file is located), it's probably better to use the binary instead:
const executable = "node_modules/.bin/happo";

Yeah absolutely, and thank you for the response. So I'll break this up into 2 comments, one describing the intention, and then later on I'll try out some of your suggestions, and see if those work (and if they don't, I'll try to create a working example).
So the the use case: at our company, we have a lot of different repo's, (or packages inside a mono repo) that share similar configuration. We're giving happo a trial period, and so in 2 separate packages, I had to install the same dependencies for happo itself, and 2 separate .happo config files (exactly the same). Now the trick with most dev dependencies in npm world, is they usually culminate in an entry into the scripts field in the package.json, pointing to some sort of cli. So all of the config, packages, etc for happo, all just culminate in something like
scripts: {
   happo: happo dev
}

And the problem, is if we decide to update the configuration in one file, we have to make PR's for 8 different repo's, alter the dependencies in those, etc.
So the idea here is this: what if we could enforce the configuration to be standardized.  Whenever we have a new package or repo that we want to use happo on, we merely need to yarn add this package, and then do the following:
scripts: {
  happo: cool-package happo
}

And then you don't need to pollute that package with all of the specific dev dependencies for happo, and you get the configuration for free.
This actually isn't a new concept though. kcd-scripts, react-scripts, ember-cli-, vue-cli, etc all have this similar concept. You can read through some resources here: https://github.com/reyronald/awesome-toolkits
But yeah this is nice as now we don't need to attempt to copy and paste stuff, as we evolve our happo configuration and such. You can also make this flexible by doing stuff like checking for the existence of a .happo.js file inside the repo that's using these commands, and then use that if it's available, and if not, using the default .happo.js file.
We as a company have a lot of different projects, and not enough people to figure out how to configure stuff, and keep it updated, so providing pre-made configurations for consistency sake is actually pretty important for us.

It’s worth noting that this concept, including in the examples you mentioned, has lots of caveats and often breaks in surprising ways. Having a bunch of PRs and writing a tool to manage those might be easier than this approach.

@ljharb if you have time, could you list a few of those caveats? It doesn't have to be super specific, I'm guessing this is based on seeing issues over a long period of time in your own org? The ones I can think of is webpack config, css-loading, resolving paths relatively to the local package, etc.
@reywright if I remember @flarnie right (we chatted a few days back) you are using Storybook, right? Things might be a little simpler in that case, because I think you can always run happo from the root, but specify a configDir for the happo-plugin-storybook pointing to the local package. The .happo.js (located in the root of the repo) config can then look something like
module.exports = {
  // ... other config
  plugins: [happoPluginStorybook({ configDir: path.join(process.env.HAPPO_PROJECT_DIR, '.storybook') }),
};

With this config, you can invoke happo with something like
HAPPO_PROJECT_DIR="project-a" npm run happo run

This is just an idea though -- let me know if that makes sense or if you need me to expand/explain things!

This user has run into a few :-) cwd confusion, process signals/traps, but also dependency issues; what happens if someone depends on one of the tools (eslint, happo, Babel, etc) directly and they conflict, IDE integration which fully supports eslint as a top level dep but may not necessarily if eslint happens not to be hoisted to the top level; also customization in general, react-scripts forces many CRA users to eject to do even basic enhancements to their linting or transpiling configs.
The OP suggests there’s issues with the happo binary a) not relaying signals properly and b) leaving behind running processes and c) outputting to stdio after the main process has already finished, all of which would be legit bugs - the use case is such, however, that even absent those issues, it might not be trivially achievable.

@ljharb very interesting, and thanks for the feedback.
I honestly just don't see a reality of a tool that can go out to these different repo's and projects and make these PR's you're referring, not only from a functionality perspective, but actually getting approval from the respective engineers on those projects, and then get merged in. Some of the PR's would eventually get stale as well, and subsequent PR's would potentially depend on the previous PR's. I just don't see this being possible.
I think the reality for us, is we'd like to do a lot more standardization across projects, so a lot of the pain points you mention are valid but are tradeoffs we'd potentially be willing to incur... unless it's absolutely not recommended, and I've seen a lot of different teams flourish with the approach.
I think it's harder for react-scripts, as they need to support a much wider audience and the enhancements they may want. For us, we have a much smaller surface area, we actually want to constrict the customization, and we can always evolve our own scripts for our needs. I do think this will be more work than what is trivial already, but the current setup we're running is untenable long term. When you say IDE integration, I'm assuming you're meaning of editors looking for a top level config file in the working project directory... that's a good point... I wonder if some script to symlink them to your working directory would suffice?
Is this something you've tried with your own teams (or know teams that have implemented it) and didn't have good results with it? I've just seen nothing but success stories (even with the pain points).

I’ve seen many issues with the public projects you mention - standard, react-scripts, etc - and we’ve run into similar issues trying to write a robust tool.
Making a bot account that can merge PRs without engineer approval, even, is totally doable.

I'm closing this due to lack of activity. Feel free to reopen if it still needs to be addressed!


Godot editor and game windows stutter and flicker black randomly

Godot version
v4.1.1.stable.mono.official [bd6af8e0e]
System information
Windows 11 GPU - RX 6600 CPU - 10400f - 16 GB RAM, Forward+ Renderer
Issue description
The game will very annoyingly stutter and flicker black... This is happening in Godot v4.1.1-stable and Godot 4.2 dev 5.
I have been using Godot extensively for the past 2 years. This just started happening about 1 week ago at the time of writing this (2023 October 4th).
This issue does not happen in any of my Steam games. Only happens in Godot.
This happens at random. Although I have recently come to see a pattern. Running into this issue is very unlikely if I start up my PC and use Godot for the first 1 - 2 hours. However I start to see this issue appear much more frequently after 2 hours, it just keeps getting worse and worse as the time goes on and I find that I need to restart my PC to temporarily solve this.
Note that only the game window flickers and stutters. In other words the flickering and stuttering are contained within the game window and not the Godot editor.
Restarting Godot does not help. Restarting PC seems to help. Although this could just be the placebo effect.
Nothing suspicious appears in verbose logs or Godot monitors when the flickering happens.
I am using a 60 Hz monitor. No G-Sync or anything fancy like that. I am using a HDMI cable.
https://github.com/godotengine/godot/assets/6277739/9e60cb2a-f559-413c-9527-f5ba615f1f4d
https://github.com/godotengine/godot/assets/6277739/c747e948-5431-42af-8748-1d890c8f8f6c
I have tried searching for all 400+ issues with the keyword "flicker" but no issue looked related to mine.
Steps to reproduce

Create new blank Godot project with Forward+ renderer selected
Set root node to a Node2D
Set the main scene to this Node2D
Run the scene and if you're lucky you will see the black flickers and stuttering (I saw them on first time running the scene but then after that I couldn't reproduce the issue as the issue randomly comes and goes...)

Sometimes I get the flickering on the first try. Sometimes restarting the game 30+ times will give no flickers.
Minimal reproduction project
FlickerTest.zip (this is a blank project with steps to reproduce described above applied in here)
I tried recording the minimal reproduction project flickers with OBS but they did not show up in the video. At least they show up on the video currently attached to this issue.

Can you reproduce this without the desktop overlay in the bottom-right corner (I assume it's a third-party program and not added during editing)?

All of that is from OBS (Open Broadcast Software), what I use to record. Yes, this happens without OBS running.

Update: Sometimes happens in the actual editor now too. The whole editor will sometimes flicker black and the jittery movements can be seen when dragging the view around a scene in a circular fashion.

I have managed to capture the jitters and one black flicker. I have added the video to the issue description above. The black flicker can be noticed around 0:26 to 0:28.

Sometimes when I'm browsing and I click on something, the browser will flash white and whenever I open up windows explorer it will flash white. I don't know if it's related to the black flashes in Godot.

Got the same problem in 4.2-beta1 (had to film the flickering with the phone, since on screen capture it only barely was captured.
If i export the game and run the executable, the issue is not present.
Porting back the project to 4.1.2 also seems to fix the issue (just did a quick test and it seemed fine)
https://github.com/godotengine/godot/assets/44810197/d4e57a15-ac43-4db0-8318-253cfee23b5c

Can you test whether https://github.com/godotengine/godot/pull/80566 resolves this?

In the PR, I click on "Checks" tab and click on "Artifacts" but I get a message saying "The following artifacts have expired and are no longer able to be downloaded."

@Calinou I built Godot from source from the PR #80566 you linked and built my game and tested it and I still get stuttering.
I had some issues initially getting the project to build and had to change <Project Sdk="Godot.NET.Sdk/4.2.0-dev"> to <Project Sdk="Godot.NET.Sdk/4.2.0-dev.1"> in my .csproj because I was getting a Godot.NET.Sdk cannot be found error.
https://github.com/godotengine/godot/assets/6277739/cffb6fef-482c-46ce-bacf-8cc18dafc5fb

I'm having a similar issue:
I've been trying different version of Godot, 4.1.2 - 4.2.1 - 4.0 but I'm facing the same flickering problem on all of them, defining it flickering problem wouldn't be correct, the window goes unresponsive for some microseconds and then comes back to life, causing is to flicker.
Some times this would be random, but on every mouse click this is bound to happend.
Sorry for the poor registration.
https://github.com/godotengine/godot/assets/40642679/4a3a73d1-ce00-4875-a4eb-893cc81d13f5
Does anyone know how to fix this?
I'm really enjoying Godot but it's really unusable like this..

@JynoX This appears to be a different issue: focus is continuously being released and given to the Godot editor window, which causes Windows' "unfocused" title bar color to appear for a split second.
You may have a third-party program installed that interferes with window focus, such as Stardock Fences or Kakaotalk. I'd recommend going through the list of installed programs on your system and remove anything that looks suspicious.
As a mitigation, you can change your Windows' theme settings so that the unfocused window title color is as close as possible to the focused window title color. You can switch to dark mode, or keep light mode and change the theme settings so that window titles aren't influenced by your chosen accent color (this will make the title always white).
You can also run the editor in fullscreen by pressing Shift + F11, which will hide the window title.

Seeing this as well with Godot 4.2.1. I am also using multi monitor. Two of my monitors run at 75hz and one at 144hz. I notice this also only happens to me on my 144hz monitor. Update Continuously does seem to fix it although that comes with it's own weird visual glitches it seems. Happy to provide additional info. I have disabled Geforce replay recording as well as the Xbox game bar.

@frostbytedata, if you can build #87340 from source, that branch may fix this issues by virtue of cleaning up swapchain usage.

@frostbytedata, if you can build #87340 from source, that branch may fix this issues by virtue of cleaning up swapchain usage.

Ok I will give that a shot and report back.

Had a similar issue.
Unplugging the second monitor seemed to have fixed the issue.

I am experiencing the flickering in v4.3.stable.official [77dcf97d8] in the "Running Scene" window, not the editor itself.
Forward+ renderer
Tested with empty project, tested with 2D scene, tested with 3D scene, same results.
Windows 11
NVIDIA GeForce RTX 3070
Two connected monitors.
Acer G246HL Connected via DisplayPort
ASUS VS247 Connected via HDMI
This should be a high-priority issue.

I also experience this on my Macbook M2 Pro (2023).  It happens more frequently sometimes, but then doesn't do it for a while.  I have an older primary (6-7 years) ASUS Monitor (60Hz).  The Mac is connected HDMI out to DVI into the monitor.  I'm running the latest Dev release of Godot (4.4.dev2.mono).  Mac OS: Sonoma 14.6.1
At times I can cause it to happen by expanding the editor to be as big as the monitor is capable, and then shifting the window slightly so that it's not perfectly, and maximally expanded.  Then, by placing the mouse at the edge of the window (so that the resize handles show up) if I move the mouse back and forth between my desktop in the background and the window, I'll get black flickering.  This is the only thing I've been able to reproduce.  I'm not 100%, but it seems to only happen on my ASUS monitor, and not on the Mac Retina display.
I was able to reproduce it, but I was trying to get a better video capture, and now I can't get it to happen.  Also, possibly related, I've noticed that the preview images that display when you mouse over the scene tabs, often are solid black for some reason instead of rendering the corresponding scene preview image.  I don't know if that's related, but now that I can't reproduce the black flashing, those images are rendering correctly.

Can anyone reproduce this with V-Sync disabled in the Editor Settings then restarting the editor?

Also experiencing this problem. For me it only occurs when running a scene. The editor window itself does not flicker.

Can anyone reproduce this with V-Sync disabled in the Editor Settings then restarting the editor?
Edit: When disabling V-Sync, be mindful of #91042.

I left V-Sync enabled in Editor Settings since I am not experiencing this issue with the editor. Instead I disabled V-Sync in Project Settings, then closed and re-opened the editor per your instructions. On the first attempt, this did nothing to resolve the issue. On the second attempt the stuttering halted. Even stranger, on a third attempt I re-enabled V-Sync in Project Settings, restarted the editor and the stuttering did not resume. The stuttering has not resumed whether V-Sync is on or off in all subsequent attempts, though I've only been grappling with this for about an hour. It's worth noting that there was maybe 20 minutes in between attempts 2 and 3. The problem definitely seems V-Sync related, but enabling/disabling it yields inconsistent behavior. I'll probe the issue more tomorrow to see if I can provide more info. Hopefully we can get a fix in time for 4.4.
My relevant specs:

Godot Version: 4.3.stable
Renderer: Mobile
Platform: Windows 11 x64
GPU: ASRock Challenger D AMD Radeon RX 6700XT 12GB
Graphics Driver: AMD Software Adrenalin Edition v23.11.1
Monitor 1 (Primary): Acer Nitro VG240Y P

1920 x 1080
120Hz VRR (AMD FreeSync)
Connected via DisplayPort 1.2

Monitor 2: LG Ultrawide

2560 x 1080
60Hz
Connected via DisplayPort 1.2


Action button in notification

please provide feature for action button in notification

@justjcool Since this project doesn't have any full time developers, all updates are made from the community.  I have added the enhancement flag to denote the feature request, but that being said we need someone in the community to implement it.
If you would like to take a stab at contributing the code, we have a Contribution Guideline document that you can review to get all the information you need on submitting a new feature.


fix: compat with new<EMAIL_ADDRESS>node16 resolution

new typescript version picks up the "types" key instead of the root "typings" when in "node16" resolution mode.
also defined both "require" and "import" bundles so they can be natively required/imported in each mode.

Published in v1.1.2 🎉


Intermittent visual bug

I am using Safari on a 2019 Mac. I have not been able to replicate on Chrome or when I am viewing on an external monitor.

Closing this unless it becomes a major problem in the future.


Missing method for close all "$toasts"

When I have group of $toasts (error form validation messages), then fix the form and submit, I want to close all current $toasts and show new one (maybe a success message if I got lucky).
So something like this.$toast.closeAll().
(And this.$toast.getQueue) could be also nice to have accessable 😇 )
Current behavior: new success message appears at the end of queue and user does not see it until he close manualy all the error $toasts.
Quick fix could be show LIFO (last in - first out) order instead of current FIFO (first in - first out).

@julpat great idea, I'll do that as soon as I have time :) thinking about method clearQueue which will clear all queued toasts.


babel-jest being added as dependency in 7.1.1

Are you submitting a bug report or a feature request?
bug report
What is the current behavior?
babel-jest is a dependency in 7.1.1
What is the expected behavior?
babel-jest should be a devDep
it seems updated in the repo, but in the release, it's a dependency in the release

Duplicate? https://github.com/erikras/redux-form/issues/3498

yup, leaving open until a release

going to leave this open until a new release

this dependency is breaking my tests environment!
please publish a new release without this

Fix published in v7.1.2.


Naming updates

The update utils are currently:
updateResourcesMeta
updateManyResourcesMeta
upsertResource
upsertManyResources
Do we want to rename updateResourcesMeta to be updateResourceMeta since it affects one thing? I'm thinking that we should. @sprjr , what you think?

Update Alright, here's my suggestion:
We rename the store properties to be:
resourceMeta and resourceListMeta. They are currently resourcesMeta and resourcesListMeta.
Then, we update these functions to be updateResourceMeta and updateManyResourceMetas
To throw these changes into a chart:

current
proposed

state.resourcesMeta
state.resourceMeta

state.resourcesListMeta
state.resourceListMeta

updateResourcesMeta()
updateResourceMeta()

updateManyResourcesMeta()
updateManyResourceMetas()

LGTM, only pluralized one more: state.resourceListMetas so it was similar to updateManyResourceMetas - what you think?

current
proposed

state.resourcesMeta
state.resourceMeta

state.resourcesListMeta
state.resourceListMetas

updateResourcesMeta()
updateResourceMeta()

updateManyResourcesMeta()
updateManyResourceMetas()

:+1:! I'll do it

We decided to go with resourceListMeta, since the "list" in this situation is a single "thing" – it's metadata for a single object. That object is the list of other resources.

Resolved in #66


how to read each row and insert into database along with remove unwant white space as well as multiple comma

hello guys, i go through document but have n't find any solution moreover i read all read me but haven't find any solution related to this situatuion
[ Row {
bankcustomers_id: '154491',
customerid: '154491',
title: 'MR ',
firstname: 'Santa          ',
lastname: 'Clause                             ',
dob: '25-Dec-30',
mobileno: '07900 1234567  ',
emailid: 'santa-clause@northpole                       ',
housenumber: '5',
address1: '5 North Street                          ',
address2: 'Pole                                    ',
address3: 'London                                  ',
address4: '                                        ',
address5: '                                        ',
postcode: 'DY3 11X
' }]
above is output is product by csv parser now my problem is that is there any provision to remove this white space at start and last of  charater or  consecutive ,, .and how i can get single column value .how i can remove all mention this is there anybody help me out with this
moreover  i want to insert each row into data base so how i can read row on this function
.on('data', (data) =>{
//    console.log(data)
results.push(data)
})

Duplicate of https://github.com/mafintosh/csv-parser/issues/113


Items spawns as intended but becomes impossible to pick up upon reloading a save

https://www.doomworld.com/forum/topic/136255-hxdd-a-heretic-hexen-wad-merger-now-with-multiplayer-doom-pwad-mode-updated-8152024-083-beta/?page=3&tab=comments#comment-2835404

Posted by Jeanvik
Hi !
Gave a test run to the new HXDD version and sadly a nasty bug managed to get through.
Items spawns as intended but becomes impossible to pick up upon reloading a save. The sprites are still here but walking on them does nothing.
Made the tests with Walpurgis, Quakin Doom and Hexen RPG with HXDD 0.8.3 used as the iWad.
Hope this bit of info will help and thanks again for all your hard work.

This is resolved by using a GZDOOM v13 dev build.
I'll leave this issue up until v13 is released.


v2 testing documentation

Context
follows #271
Requirements

[x] Set up documentation to ensure contributors are aware of the test database and how to interface with it.
[x] Add docstrings and additional documentation providing additional context when tests are run.

@maxachis how much of this documentation would apply to other repos? I'm thinking we should have this figured out in advance of things like https://github.com/Police-Data-Accessibility-Project/data-source-identification/issues/49 so folks know how they should be writing tests

@maxachis how much of this documentation would apply to other repos? I'm thinking we should have this figured out in advance of things like Police-Data-Accessibility-Project/data-source-identification#49 so folks know how they should be writing tests

@josh-chamberlain Here's what I think would generalize across repos:

The test database and how to access it
General principles for how to write tests
Libraries to be used when running tests (e.g., pytest)

@josh-chamberlain I've created documentation on how to run tests for you to review as you see fit!
https://app.gitbook.com/o/-MXypK5ySzExtEzQU6se/s/-MXyolqTg_voOhFyAcr-/~/changes/513/meta/internal-dev-resources/development-testing

this is good, but moving it in-repo to CONTRIBUTING.md shortly #384


Help for delete image

How can we delete the saved image and name from the browser

Hi @jihademir - the GitHub issue tracker isn't meant for support questions like this. That's why we have the following comment in our issue template:
<!-- The GitHub issue tracker is for development discussions and bug tracking.
     Please direct questions to our mailing list at
     https://groups.google.com/forum/#!forum/cmu-openface -->

Happy to help you on our mailing list.
-Brandon.


No documentation comments

To be a first class citizen in the Go ecosystem, all
exported functions, methods and types should have
appropriate documentation comments.
http://golang.org/doc/effective_go.html#commentary
No matter how good the documentation on the website is,
the godoc is the most important thing. Please document
this stuff!

Hi @rogpeppe
We understand that, but the API is not freeze at that time (scheduled for September 2015), so we will do that before the finally launch.

The API should be documented long, long before it's frozen.
Without documentation, I'm sorry to say it's essentially unusable.

Without documentation, I'm sorry to say it's essentially unusable.

Please don't be hyperbolic, it's not constructive.
We agree that the documentation is important, but we haven't been able to make time to look at it yet. As @jinzhu said, it's still very early stages for QOR.

@rogpeppe Thanks for your input… we will prioritize this higher and get these in soon

I suggest to use golint that will help you filling proper comments for godoc.

Is there anything I would be able to do to help in the documentation of QOR? Any specific areas?

@stuartweir Thank you for that. If possible, it would be good to start from a new application, and document things that confuse you. (Sure, we are here to provide any help that you want)

No problem! Alright! I'll do that :+1:

We have added lots of documents, please review each component's readme and godoc


Use couch_tests applications for couch_db_plugin_tests

This fixes the problem with chttpd_plugin_tests. Previously following would fail:
make eunit apps=couch,chttpd tests=callback_test,error_info_test

In order to test this PR you would need to add apache/couchdb-erlang-tests#1 as a dependency in rebar.config.script. You might need to add the app into rel/reltool.config as well.

@kxepal: This one is the same change as in https://github.com/apache/couchdb-chttpd/pull/108 (which you already review).

Right. +1 here as well.


Entries no longer ordered alphabetically

Hi,
For a while now the entries in session-lens are no longer ordered alphabetically. I know session-lens did not change in a long time and I don't know either if it was due to a change in neovim-nightly or an update of Telescope but I find it annoying.
I tried to find means to order the entries myself but without any luck.
Can you reproduce this behavior and possibly fix it?
Thanks
Manuel

Hey @wilriker, if I do look into this it'll probably be directly on this branch of auto-session.
https://github.com/rmagatti/auto-session/pull/161
The list was never really intentionally ordered alphabetically. It can probably be done with some tweaking to the picker sorting though.


Fix breadcrumb visibility bug

PR Fixes:
before :

after :

Resolves #1389
Checklist before requesting a review

[✓] I have performed a self-review of my code
-[✓] I assure there is no similar/duplicate pull request regarding same issue

Already done


How to set this app as the default file explorer app in windows 10

This is better than the default file explorer app. How to set this as the default? (This should open whenever choosing download location in browser or uploading files to some sites or even when clicked on path links and every other file things)
How?

@ShobanChiddarth See https://files-community.github.io/docs/#/articles/replace-file-explorer

Thanks


i18n(fr): translated docs/fr/core-concepts/astro-components.mdx

What kind of changes does this PR include?

Translated content

Description

Closes #4175
Updating the translations for the astro-components.mdx page

Thanks @MattCrl, great work! I'll note that there have been a few changes to this page in the last weeks, sorry for not getting into it before, could you update the PR to include these if possible? 🙏
https://github.com/withastro/docs/commits/main/src/content/docs/en/core-concepts/astro-components.mdx?since=2023-01-13T22:05:10.000Z

Thanks @MattCrl, great work! I'll note that there have been a few changes to this page in the last weeks, sorry for not getting into it before, could you update the PR to include these if possible? 🙏 https://github.com/withastro/docs/commits/main/src/content/docs/en/core-concepts/astro-components.mdx?since=2023-01-13T22:05:10.000Z

Thanks :) I've updated my PR, I found only one modification I hope I didn't miss anything let me know if I did


Update flaky integration tests

Summary
More details in the issue, test_jobs_filter_by_date and test_retrieve_jobs_order fail intermittently because too many jobs are being run in parallel
Details and comments
Fixes #1320

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.023%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4449

Relevant Lines:
5491

💛  - Coveralls


Temporary value dropped while borrowed

I'm trying to use this library to development Stereo Direct Spare Odometry. But I came across this error when building:
error[E0716]: temporary value dropped while borrowed
   --> /home/craig/.cargo/registry/src/index.crates.io-6f17d22bba15001f/factrs-0.1.0/src/variables/se2.rs:145:14
    |
130 |         let xy = if cfg!(feature = "fake_exp") {
    |             -- borrow later stored here
...
145 |             &(Vinv * self.xy)
    |              ^^^^^^^^^^^^^^^^ creates a temporary value which is freed while still in use
146 |         };
    |         - temporary value is freed at the end of this statement
    |
    = note: consider using a `let` binding to create a longer lived value

For more information about this error, try `rustc --explain E0716`.

Hmm, I'm having trouble reproducing this. I tried initializing a fresh repository with cargo init and then cargo add factrs and it built fine. Any chance you could share a minimal example of this occurring? And what version of rust you are using?

Good question. My rust version is 1.75.0. I think this goes away when I upgrade to the latest rust version.
Steps to reproduce:

Checkout v0.1.0 of the library
run rustup default 1.75.0 (Sets the rust version to 1.75.0)
run cargo build

rustup default 1.82.0 to restore the version back to the latest.

It might help consumers of this library to set the rust-version in the Cargo.toml. That being said, thank you for all of the work you guys put into this library

Yup, that's definitely something that we should have and slipped between the cracks. I pin to 1.81 (num-dual recently had an update that pins to 1.81 so that's the lowest we can go) in #14 that should solve this. I'll submit a 0.2.0 release in a few days with the fix.
Let me know if you hit any other kinks or have any other questions - factrs is decently well used internally, but I'm sure there's some edge cases like this that we have missed.
If your implementation is open-source, we'd love to feature it as an example once it's finished too:)


See how many defaults we can have to eventually get to bacalhau serve as the only thing necessary

@wjam Is this done following your work? IIRC I can run bacalhau serve now and it will work, right?

Closing this as a duplicate of #1231.


maximize terminal panel

is it possible to maximize the terminal panel or to add a „voll windows“ button on the top right of the terminal panel?

Great idea. I will be working on this.


Bugfix: Change parameters passed to createSalesChannel() of SalesChannelCreator called from SalesChannelCreateCommand.php

1. Why is this change necessary?
2. What does this change do, exactly?
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Checklist

[ ] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Sven Mäurer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I just verified this is already fixed on the trunk branch, so i will close this PR for now

@keulinho This PR relates to https://github.com/shopware/platform/issues/2784

Seems that we missed to close the open issue, sorry for that, but the change you made was already made here: https://github.com/shopware/platform/commit/a2882ce7f65ee06bb2c41925ed721307fc3b76f1#diff-bb2f2c061f52fd371cb51e94cb8f35f7c3a616dade7d49899242a10f1b43b911R68


marshal objects with read-only properties

In #701 I complained about an object losing its properties.
After more investigation I found the following.
Object I wanted to marshal is gridfs.grid_file.GridOut. This object sets up a lot of its attributes as (read-only) properties which do not end up in the object's __dict__ which according to https://docs.python.org/2/library/stdtypes.html#object.__dict__ should contain only (writable) attributes.
In the marshal method during an objects' introspection the only attributes that are picked up are from the objects __dict__ method. Unfortunately this line https://github.com/flask-restful/flask-restful/blob/fc34689395edc079bd242553d8d17e00c565b366/flask_restful/init.py#L645 is too complicated for me to unwrap what is going on there.
Maybe using the built-in dir() function would be an improvement? Even though it may not cover all attributes it would still help in the situation described above.
Based on this https://bugs.python.org/issue2040 dir() is actually encouraged.

Could someone explain to me what is going on here and why there is a recursion? If I can unwrap this then I could implement it in a way which uses dir(object_to_marshal) to introspect an object's attributes.
 items = ((k, marshal(data, v) if isinstance(v, dict)
              else make(v).output(k, data))
             for k, v in fields.items())

https://github.com/flask-restful/flask-restful/blob/fc34689395edc079bd242553d8d17e00c565b366/flask_restful/__init__.py#L645

@joshfriend could you help me out with this please?


Enable Keras Applications with pretrained Weights to be used inside the Estimator API

Examples like #25670 show you that is impossible to use Keras Applications inside the Estimator API. The issue has to do with some global tensors that Keras creates by itself that live or were created in a separate session, thus, when the Estimator API wants to construct the model_fn it raises an error saying that it found a Tensor from a different graph.
I think Keras should be modified to avoid this behavior, TFHub is nice but it doesn't let you use arbitrary input shapes.

@cgarciae Have you tried to use model_to_estimator? I believe that might work in this case.

@karmel Tested, it doesn't work.

@cgarciae -- thanks; can you provide the code snippet and error output? Thanks--

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Vue-cli 5 open <IP_ADDRESS>:9000 instead of localhost:9000

Version
5.0.0-rc.0
Reproduction link
github.com/vuejs/vue-cli
Environment info
Windows 11

Steps to reproduce
Start a new vue-cli5.0 on windows
What is expected?
Open one the correct url :

Local:   http://localhost:9000/
Network: http://<IP_ADDRESS>:9000/

What is actually happening?
Open
http://<IP_ADDRESS>:9000

everything was working fine on vue-cli4.
My devserver on my webpack config 5 for no vuejs experiments looks like this :
	devServer: {
		open: true,
		compress: true,
		https: true,
		hot: true,
		allowedHosts: 'all',
		historyApiFallback: true,
		port: 9000,
		host: 'local-ip',
		static: {
			directory: path.resolve(__dirname, './app'),
			staticOptions: {},
			watch: true,
		},

	},

important parameter I change when i switch from v4 to v5 :
host: 'local-ip',

Without any extra config in the vue.config.js, when run vue-cli-service serve --open, I also open the <IP_ADDRESS>:8080, but not localhost:8080 as Vue CLI 4.

I had a similar problem.
It is also Windows 11, Vue CLI 5.00-rc.1, When only open: true is set, it will automatically open http://0.0.0: 8080/ first, but it will be reported as:

App running at:

Local: http://localhost:8080
Network: http://xxx.xxx.xxx.xxx:8080

Although it is not a big problem, I always feel confused, and I still hope to be consistent.

我也遇到了类似的问题。
同样是 Windows 11, Vue CLI 5.00-rc.1, 当只设置了 open: true 会先自动打开 http://<IP_ADDRESS>:8080/ ，但 server 启动成功后会报告为：

App running at:

Local:   http://localhost:8080
Network: http://xxx.xxx.xxx.xxx:8080

尽管无伤大雅，却总觉困惑，还是希望能够统一的。

Same here.

When will this problem be fixed？

Still happening on vue-cli 5.0.4. On Windows, yarn serve --open opens a browser tab to http://<IP_ADDRESS>:8080 which results in a 404.

Still happening on vue-cli 5.0.4. On Windows, run command: vue-cli-service serve, first opens a browser tab to http://<IP_ADDRESS>:port/ which results in a 404.

you need to specify the host option, e.g.
vue-cli-service serve --open --host localhost

const port = process.env.port || 7878;
devServer: {
port,
open: {
target: [http://localhost:${port}]
}
}

 const port = process.env.port || 7878; devServer: {     port,     open: {       target: [http://localhost:${port}]     } }

devServer: {     port,     // 自动打开目标网页     open: {       target: [http://localhost:${port}]     },

devServer: {     port,     open: {       target: [`http://localhost:${port}`]     } }

const port = process.env.port || 7878;

devServer: {
    port,
    open: {
      target: [`http://localhost:${port}`]
    }
}

maybe it works
const port = process.env.port || 7878;

devServer: {
    port,
    open: {
      target: [`http://localhost:${port}`]
    }
}

This appears to still be an issue. Overwriting --host isn't a solution. the point of <IP_ADDRESS> is to open allow all incoming traffic for testing purposes. This is really useful when using containers.

This is not changed --host.[To open a specified page in a browser].(https://webpack.js.org/configuration/dev-server/#devserveropen)

This is not changed --host.To open a specified page in a browser.

There is a problem with my code. Need to change http://localhost:${port} to http://localhost.

There is a problem with my code. Need to change http://localhost:${port} to http://localhost.

This will not open the page correctly

If this method doesn't work, you can only change the port manually.

ok,thx

you need to specify the host option, e.g.
vue-cli-service serve --open --host localhost

thank you it works <3

any plan ?

in package.json set this line:
    "serve": "vue-cli-service serve --host <IP_ADDRESS>",


proposal: use unwrap crate

.unwrap_or_else(|err| exit_with_err(format!("{:?}", err))) is ugly.
ref: https://crates.io/crates/unwrap

They are not the same. Exit_with_err wants to exit the process without printing out the stacks. A similar macro can be added to TiKV though.
/cc @ngaut @siddontang

Here we want to exit directly, so the crate is not suitable here.
Let's use unwrap_or_else now.


animation & animationDuration in DOMElement.style are getting obfuscated

Couldn't find if anybody reported or is it even considered a problem, but for some reason compiler renames animation and animationDuration properties when setting style to DOMElement if using ADVANCED_OPTIMIZATIONS.
const test = document.createElement('div')
test.style.animation = 'test'
test.style.animationDuration = '3s'
test.style.padding = '16px'

I would understand if it would rename any style property, but as you can see that padding is not obfuscated

It looks like our externs are missing animation and animationDuration (but have padding here):
https://github.com/google/closure-compiler/blob/6250a23fc5ac60b0a34b7a44e53dc6cfd5bb075d/externs/browser/w3c_css.js#L1533
Probably we just need to add animation and animationDuration to the other CSS 3 externs here:
https://github.com/google/closure-compiler/blob/6250a23fc5ac60b0a34b7a44e53dc6cfd5bb075d/externs/browser/w3c_css.js#L1805
Are you interested in sending in a PR?

Sure, will do. I will also check for other properties

I do not quite understand why w3c_css.js doesn't contain animationName but still isn't obfuscated


⚠ Bofrost.be has degraded performance

In faa5cb0, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1197 ms

Resolved: Bofrost.be performance has improved in 624d902.


CI: Setup a CMake job for MSYS2/MinGW

This keeps dying on me because apparently m4 is not being installed.

This PR requires #2914 to be applied first.

Applied 2914 and it still dies because it cannot find m4.

Applied 2914 and it still dies because it cannot find m4.

It requires some more changes that i will apply one #2914 got merged.

@DennisHeimbigner I have pushed changes for the build to succeeds, but tests needs more changes to succeed.

You repeatedly change if(MSVC) to if(WIN32). Does that work for cygwin?

You repeatedly change if(MSVC) to if(WIN32). Does that work for cygwin?

No, WIN32 is not defined by CMake on CygWin.

@DennisHeimbigner I'm not seeing an issue on my end from the tests, but I don't have a Cygwin environment to run.  It works in MSYS2 with Visual Studio, if you run this manually on your Cygwin environment, does it fail?

DWesl/netcdf-c#2 is a copy of this workflow adapted for Cygwin, which shows a single test failure (a massive improvement over the last time I tried CMake on Cygwin).  I don't recognize the reason for the nc_test4_tst_filter failure from the details provided, so I'd have to dig into that locally, but I suspect that failure is unrelated to the changes in this PR.

I added a section to run tests using CMake.
The CMake section differs from the CMake section here in the action used to install packages (Cygwin instead of MSYS/MinGW) and the build generator used (Unix Makefiles instead of MSYS).  I also specified more full paths to utilities.  Should I make a PR to add that to this PR or this repository?

Thanks!


Bluetooth: Host: Fix re-pairing across local ids

WIP
The test fails because CONFIG_BT_SMP_ALLOW_UNAUTH_OVERWRITE=n. (Works as intended. Test will be updated.)
The solution is to call bt_unpair with the old bond's "name" (local_id, remote_addr). I believe it must be an unpairing. It is not possible to "update" (without an "unpaired" event) the existing bond, like in the common re-pairing case because the bond name cannot be the same since the local id changes.
Fixes: https://github.com/zephyrproject-rtos/zephyr/issues/22049

some comments. Im a bit concerned that you have tests but they're not failing, they should be since the IS_ENABLED() call should not work.

I fixed the IS_ENABLED. The test's were failing without the fix.


New coop components & start 0.1.31

@onmyraedar

should we also add Model to coop/utils.py (why not?)
can we add a randomize: bool = False arg to the Model and ModelList example methods?

I did originally put Model, but doing so produces an error because it's the LanguageModel that inherits from PersistenceMixin (the class that allows you to push/pull from Coop).
Even though we've put LanguageModel there, you can still push an object created with the Model() constructor, though.

@onmyraedar thank you
cc: @johnjosephhorton  this may be useful for the refactoring you're doing


MSID: 90363 Version: 3 DOI: 10.1101/2<IP_ADDRESS>2220

MSID: 90363
Version: 3
Preprint DOI: https://doi.org/10.1101/2<IP_ADDRESS>2220
Step 1. Awaiting reviews
Editorial to post reviews via hypothesis
Useful links:

DocMap: https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v2/by-publisher/elife/get-by-manuscript-id?manuscript_id=90363
New model tracking: https://docs.google.com/spreadsheets/d/1_fHaoOy7hjyocptKtVJRijeNpUY4hBS7Ck_aVmx6ZJk/
Reviews on sciety: https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>2220

For trouble shooting (e.g. no Docmaps available):

DocMap issue addressing: https://miro.com/app/board/uXjVNCwK6EI=/
Explore DataHub DocMaps API: https://lookerstudio.google.com/reporting/4c2f0368-babb-4beb-b5b3-497e7e7b0f08/page/ejphD
Unmatched submissions and preprints: https://lookerstudio.google.com/u/0/reporting/9f86204f-3bf7-477c-9b18-5c5ef141bf69/page/p_gxi57ha93c
Unmatched manuscripts spreadsheet: https://docs.google.com/spreadsheets/d/15QcK8w-ssB7109RQEDtFpJPZ0J5HTGxoHa_2TtpMBbg/edit#gid=1336081641

Step 2. Preview reviewed preprint
Production QC content ahead of publication
Instructions:

QC preview: https://prod--epp.elifesciences.org/previews/90363v3
Update ticket with any problems (add blocked label)
When QC OK, add QC OK label to ticket and add publication date and time to https://docs.google.com/spreadsheets/d/1amAlKvdLcaDp5W8Z8g77NmkwbMF5n_u89ArSqPMO8jg
Move card to next column
(At end of the day post link in #enhanced-preprint and ask for PDF to be generated)

Useful links:

Preprint DOI :  https://doi.org/10.1101/2<IP_ADDRESS>2220
Confirm reviews returned by EPP: https://prod--epp.elifesciences.org/api/reviewed-preprints/90363/v3/reviews
To update the MECA path in the docmap: https://docs.google.com/spreadsheets/d/1mctCQuNFBjSn97Lihy7_vBO6z7-N-oqyLv4clyi6zHg

Step 3: Awaiting search reindex
This step adds the reviewed preprint to the homepage: https://elifesciences.org
The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.
Useful links:

Jenkins pipeline to reindex search can be triggered sooner or monitored here: https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 4: Published! PDF requested
Waiting for PDF to be generated
Useful links:

PDF tracking: https://docs.google.com/spreadsheets/d/106_XeDjmuBae7gexOTNzg60lapeqjl2aRn9DzupGyS8/

Step 5: Introduce PDF to data folder and git repo
Upload PDF to relevent folder in git repo https://github.com/elifesciences/enhanced-preprints-data/
Step 6: Done!

[ ] Kettle is on!

duplicate content in reference, otherwise fine to QC

Well spotted, thanks @rkcook312. Should be fixed in a few hours


、 'Page' object is not iterable

Exception Type: | TypeError
'Page' object is not iterable

I met this issue too

Hi have you solved this issue?

in the template you must missing .object_list
{% for person in people.object_list %}

I got this error too.
it's strange that it's not always present, on one page there is error , but on another page it is ok.
Even I do not use page in html file, it will report error when django render the html page.
I use django 1.11.13
TypeError: 'Page' object is not iterable
E:\venv\imooc\Lib\site-packages\django\template\defaulttags.py
        if not hasattr(values, '__len__'):
            values = list(values)
        len_values = len(values)


Allow hierarchy in ImageFolder dataset

🚀 Feature
Allow hierarchy in ImageFolder dataset.
Motivation
Currently, ImageFolder (more specifically ImageFolder._find_classes()) only scans for directories directly in root. This makes it impossible to use an ImageFolder for datasets that use a hierarchy in their image folders.
An example for such a dataset is Places365. It organizes the image folders by there first letters:
/a/airfield 0
/a/airplane_cabin 1
/a/airport_terminal 2
/a/alcove 3
/a/alley 4
/a/amphitheater 5
/a/amusement_arcade 6
/a/amusement_park 7
/a/apartment_building/outdoor 8

Sometimes a class also has one or multiple subclasses as can be seen in the last line.
Pitch
We could add a recurse=False flag to the constructor of ImageFolder. If recurse is True it should not only scan the root directory but do this recursively for all sub-directories.

Hi,
I think a recurse flag could potentially have some unexpected behavior in DatasetFolder, as make_dataset recurses inside the class folders itself https://github.com/pytorch/vision/blob/5e9ebe8dadc0ea2841a46cfcd82a93b4ce0d4519/torchvision/datasets/folder.py#L35-L62
Instead of passing a recurse argument, I think I would prefer if we subclass DatasetFolder and make _find_classes of the inherited class to perform the recursion inside.
Thoughts?

I completely missed the os.walk in the top level folders. I was under the impression that only the top level folder is searched.
Given that, I think I'll just implement the functionality I need separately in the dataset instead of using an ImageFolder. If some other dataset needs the same in future we can think of generalizing it then.


Load EasyMDE/CodeMirror dynamically, remove RequireEasyMDE

As discussed in:

https://github.com/go-gitea/gitea/pull/17926

This PR makes frontend load EasyMDE/CodeMirror dynamically, and removes RequireEasyMDE.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@62dcf1a). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #18069   +/-   ##
=======================================
  Coverage        ?   45.20%
=======================================
  Files           ?      824
  Lines           ?    91450
  Branches        ?        0
=======================================
  Hits            ?    41341
  Misses          ?    43498
  Partials        ?     6611

Impacted Files
Coverage Δ

routers/web/repo/commit.go
26.99% <ø> (ø)

routers/web/repo/compare.go
44.36% <ø> (ø)

routers/web/repo/editor.go
23.96% <ø> (ø)

routers/web/repo/issue.go
38.82% <ø> (ø)

routers/web/repo/pull.go
30.24% <ø> (ø)

routers/web/repo/release.go
26.51% <ø> (ø)

routers/web/repo/wiki.go
39.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62dcf1a...3338246. Read the comment docs.

I think we can also remove the static CodeMirror copy in public/vendor/plugins/codemirror, which also means EasyMDE will now use the newer CodeMirror version from the npm package.

I think we can also remove the static CodeMirror copy in public/vendor/plugins/codemirror, which also means EasyMDE will now use the newer CodeMirror version from the npm package.

Maybe we can try that in future, but for now, it's quite tricky, some CodeMirror plugins have to be loaded from that directory directly .... I have left comment there, and there are two issue links for CodeMirror.
https://github.com/go-gitea/gitea/pull/18069/files#diff-5eca01f7999043471c646505421dd1362dc17aeba4f600b72ac1c1e76864d7e1R31

I think we can also remove the static CodeMirror copy in public/vendor/plugins/codemirror, which also means EasyMDE will now use the newer CodeMirror version from the npm package.

I'm fairly sure I tried this when I migrated to EasyMDE in the first place but was unable to make this work. I probably added a comment in #13333 somewhere about this.

Right, I remember CodeMirrors plugins being generally incompatible with Webpack's loading mechanism, so that must be the reason for the vendored copy.

Edit: codemirror/CodeMirror#4838 (comment) is related. So I think we'd need to manually load the markdown mode (the only mode we use it for) and other plugins in webpack, similar to codemirror/CodeMirror#5484 (comment).

And this time I added these comments into code. Next time a new developer won't be surprised. 😋

How do you think about this PR? Can we move on?

@go-gitea/maintainers  I will resolve conflicts after #18161 is merged.
But I still need one LGTM, hopefully we can move on, soon.

L-G-T-M bot countered the author's :)

Merged with main branch and conflicts are resolved. If there is no objection in 2 days, we could get this this one merged and move on.


Add ssl related tested cases haproxy where certs are available in nfs mounted volumes

@prachidamle , can you review the test cases aded for haproxy where certs are available in nfs mounted volumes.

Testcases covered look great!

@prachidamle , I have parametrized lb image name (along with few other parameters) in the compose files used for creating Lb services . LB image is now picked up from lb.instance.image setting.

LGTM


Remove big spinner

If removed, how do we:

Stop a slow stepping process (as a developer without admin privs);
Know that a stepping process has/hasn't stopped w.hen using the filter on a long stream

No problem with removing it as such, but its current functionality needs to be retained.


Play ad on source change for playlist

Hi I'm trying to get this working and the plugin works great for the first time playing the player, but then when I'm changing the source using player.src('second-track.mp3'); it just play the track without playing an ad before.
How can I make it to always play an ad when changing the source please? or even better if I'm able to control it per click for each track's link please.

I'm trying my luck also on Stackoverflow, please help if you can: http://stackoverflow.com/questions/42455518/videojs-run-ad-for-each-play-on-source-change

Same Issue +1

Thanks Jonathan :) I will give it a try.


wip: Repo script

The problem with this is that for example for community tars the url is
https://download.kopano.io/community/core:/core-<IP_ADDRESS>.8a1aeef-Debian_10-amd64.tar.gz
while for supported it is
https://download.kopano.io/supported/core:/final/tarballs/core-<IP_ADDRESS>_0%2B43-Debian_9.0-amd64.tar.gz


Rename image for CI

Rename image to csi-driver-shared-resource for CI.

/hold
This will need https://github.com/openshift/release/pull/20801 to merge first.

https://github.com/openshift/release/pull/20801 has merged
/retest

/lgtm

/hold cancel


fixed a bug with location objects not matching

If you would change the location by pushing state for instance it would only change the window.location object but not the global on browser. They should functionally be the same: https://developer.mozilla.org/en-US/docs/Web/API/Location

Also testing it matches document.
fix #192


MQTT In-node repeating messages when deployed using modified nodes/flows

What are the steps to reproduce?
Test flow:
[{"id":"380b9424.fcc454","type":"mqtt in","z":"c0f7a95e.a66d08","name":"","topic":"test/testtopic","qos":"2","datatype":"auto","broker":"73843d1e.7f20dc","x":170,"y":160,"wires":[["a8b9efe1.03a4e"]]},{"id":"a75bc06d.f0bcd8","type":"mqtt out","z":"c0f7a95e.a66d08","name":"","topic":"test/testtopic","qos":"0","retain":"false","broker":"73843d1e.7f20dc","x":410,"y":260,"wires":[]},{"id":"a8b9efe1.03a4e","type":"debug","z":"c0f7a95e.a66d08","name":"","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"true","targetType":"full","x":330,"y":160,"wires":[]},{"id":"cc1366c5.2d0998","type":"inject","z":"c0f7a95e.a66d08","name":"","topic":"","payload":"{\"test\":true}","payloadType":"json","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":180,"y":260,"wires":[["a75bc06d.f0bcd8"]]},{"id":"73843d1e.7f20dc","type":"mqtt-broker","z":"","name":"mqtt","broker":"<IP_ADDRESS>","port":"1883","clientid":"","usetls":false,"compatmode":true,"keepalive":"60","cleansession":true,"birthTopic":"","birthQos":"0","birthRetain":"false","birthPayload":"","closeTopic":"","closeQos":"0","closeRetain":"false","closePayload":"","willTopic":"","willQos":"0","willRetain":"false","willPayload":""}]

Set deploy to modified flows or modified nodes.

Deploy
Inject

Change the mqtt-in node from auto-detect to a parsed JSON object

Deploy
Inject

Change the mqtt-in node from a parsed JSON object to auto-detect

Deploy
Inject

What happens?
Messages are repeated when deploy is set to  modified flows or modified nodes.
What do you expect to happen?
A single response.
Please tell us about your environment:

[x] Node-RED version:0.20.3
[x] node.js version: 10.15.3
[x] npm version: 6.4.1
[x] Platform/OS: 4.14.98-v7+ armv7l GNU/Linux
[x] Browser: Macos/Safari 12.0.3

This has already been fixed in master by https://github.com/node-red/node-red/commit/63829b63822a159951b4d9a11c264944eac75b11
Will be in 0.20.4

You might be too quick @knolleary thanks!


Develop

Coverage remained the same at 92.496% when pulling e9728b0f751d7b716fc4e8a2b645fe7ed32d23ab on develop into 4bee873ecf0a89eb2e0af4c064995e294fcfa8a4 on master.


[Connectedk8s] Upstream Merge for preview features

Tests:

[x] Cluster connect feature enable/disable and proxy command
[x] enable disable feature command
[x] support for azure rbac
[x] default enable of extension
[x] support for cl enable/disable

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[x] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

Connectedk8s

If there is nothing to be enabled, we shouldn't show warning.
Thanks,
Raunak Pandya
From: Arpit Gupta @.>
Sent: 19 March 2021 13:33
To: Azure/azure-cli-extensions @.>
Cc: Raunak Pandya @.>; Comment @.>
Subject: Re: [Azure/azure-cli-extensions] [Connectedk8s] Upstream Merge for preview features (#3001)
@alphaWizard commented on this pull request.

In src/connectedk8s/azext_connectedk8s/custom.pyhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli-extensions%2Fpull%2F3001%23discussion_r597472741&data=04|01|raunakp%40microsoft.com|bf5a3f9d94ad42cd739708d8eaad601d|72f988bf86f141af91ab2d7cd011db47|1|0|637517377686035213|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=cExCcS86TveVDmr3NafoGqY5KSUfqGsmVb4IUrzeqBQ%3D&reserved=0:

   if (aad_client_id is None) or (aad_client_secret is None):

       telemetry.set_user_fault()

       telemetry.set_exception(exception='Client ID or secret not provided for AAD RBAC', fault_type=consts.Client_Details_Not_Provided_For_AAD_RBAC_Fault,

                               summary='Both aad authorization client id and client secret is required to enable AAD RBAC feature')

       raise CLIError("Please provide both aad authorization client id and client secret to enable AAD RBAC feature")

if enable_cl:

   enable_cl, custom_locations_oid = check_cl_registration_and_get_oid(cmd)

   if not enable_cluster_connect and enable_cl:

       enable_cluster_connect = True

       features.append("cluster-connect")

       logger.warning("Enabling 'custom-locations' feature will enable 'cluster-connect' feature too.")

   if not enable_cl:

       features.remove("custom-locations")

       if len(features) == 0:

           raise CLIError("Based on the inputs given and the warnings displayed above, there are no features to be enabled.")

User wanted only CL to be enabled, validation failed for allowing that(warning given), So, nothing to be enabled.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli-extensions%2Fpull%2F3001%23discussion_r597472741&data=04|01|raunakp%40microsoft.com|bf5a3f9d94ad42cd739708d8eaad601d|72f988bf86f141af91ab2d7cd011db47|1|0|637517377686045165|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Le95ADScB%2F5vo4c86R30UpAmp8ZmwmHi5oV%2Fv0%2BfaAY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEPCCHX6ZA2BY5BG4M2MBSDTEMAKHANCNFSM4XOLZBRQ&data=04|01|raunakp%40microsoft.com|bf5a3f9d94ad42cd739708d8eaad601d|72f988bf86f141af91ab2d7cd011db47|1|0|637517377686045165|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=fR%2FcRCtXI6CtzuodVYXFXPEfZ%2BkkdEjpsFie7nrmUPU%3D&reserved=0.

If there is nothing to be enabled, we shouldn't show warning. Thanks, Raunak Pandya From: Arpit Gupta @.> Sent: 19 March 2021 13:33 To: Azure/azure-cli-extensions @.> Cc: Raunak Pandya @.>; Comment @.> Subject: Re: [Azure/azure-cli-extensions] [Connectedk8s] Upstream Merge for preview features (#3001) @alphaWizard commented on this pull request.
________________________________ In src/connectedk8s/azext_connectedk8s/custom.pyhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli-extensions%2Fpull%2F3001%23discussion_r597472741&data=04|01|raunakp%40microsoft.com|bf5a3f9d94ad42cd739708d8eaad601d|72f988bf86f141af91ab2d7cd011db47|1|0|637517377686035213|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=cExCcS86TveVDmr3NafoGqY5KSUfqGsmVb4IUrzeqBQ%3D&reserved=0:

if (aad_client_id is None) or (aad_client_secret is None):
telemetry.set_user_fault() + telemetry.set_exception(exception='Client ID or secret not provided for AAD RBAC', fault_type=consts.Client_Details_Not_Provided_For_AAD_RBAC_Fault, + summary='Both aad authorization client id and client secret is required to enable AAD RBAC feature') + raise CLIError("Please provide both aad authorization client id and client secret to enable AAD RBAC feature") + + if enable_cl: + enable_cl, custom_locations_oid = check_cl_registration_and_get_oid(cmd) + if not enable_cluster_connect and enable_cl: + enable_cluster_connect = True + features.append("cluster-connect") + logger.warning("Enabling 'custom-locations' feature will enable 'cluster-connect' feature too.") + if not enable_cl: + features.remove("custom-locations") + if len(features) == 0: + raise CLIError("Based on the inputs given and the warnings displayed above, there are no features to be enabled.") User wanted only CL to be enabled, validation failed for allowing that(warning given), So, nothing to be enabled. - You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-cli-extensions%2Fpull%2F3001%23discussion_r597472741&data=04|01|raunakp%40microsoft.com|bf5a3f9d94ad42cd739708d8eaad601d|72f988bf86f141af91ab2d7cd011db47|1|0|637517377686045165|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Le95ADScB%2F5vo4c86R30UpAmp8ZmwmHi5oV%2Fv0%2BfaAY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAEPCCHX6ZA2BY5BG4M2MBSDTEMAKHANCNFSM4XOLZBRQ&data=04|01|raunakp%40microsoft.com|bf5a3f9d94ad42cd739708d8eaad601d|72f988bf86f141af91ab2d7cd011db47|1|0|637517377686045165|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=fR%2FcRCtXI6CtzuodVYXFXPEfZ%2BkkdEjpsFie7nrmUPU%3D&reserved=0.

We follow that whenever we can find that out.
But in this case,
How would be know before doing validation of CL rp registation etc, -> we have to give warning here right?, Because this validation is part of a function , and user might want to enable some other fearure along with cl. But if there are no features to be enabled along with it, the no. Of features effectively to be enabled is 0 and thus this warning and exit. Error because, CL enabling failed owing to the absence of registration.


Update Podspec with Cocoapods

You updated your Podspec file but you havent tagged your Git...
Check out
https://guides.cocoapods.org/making/making-a-cocoapod.html

I did tag but when I left the pod trunk push running when I left for lunch, it timed out.
I've pushed it again and so it should now be up on Cocoapods.


putting "https://....." in hostname  config directive results in a malformed URL

My tegola instance is behind a haproxy that handles my ssl termination/offloading.  To meet the requirement that there is no mixed mode (http/https) in the front end, I need to have the URL's being returned within the capabilities.json upgrade the proto from http to https.
To do this, I was told to use the hostname = directive in the `[webserver]' section which I've done below:
[webserver]
port = ":9001"
hostname = "https://myhost.tld"
...

This however results in malformed url's in the capabilites.json
{
  "attribution":"",
  "bounds":[-180,-85.0511,180,85.0511],
  "center":[0,0,0],
   "format":"pbf",
   "minzoom":5,
   "maxzoom":24,
   "name":"locationdata",
   "description":null,
    "scheme":"xyz",
    "tilejson":"2.1.0",
    "tiles":[
         "http://https:%2F%2Fmyhost.tld/maps/location/{z}/{x}/{y}.pbf"
     ],
    "grids":[],
    "data":[],
    "version":"1.0.0",
    "template":null,
    "legend":null,
    "vector_layers" [
        {
            "version":2,
            "extent":4096,
            "id":"subscribers",
            "name":"subscribers",
            "geometry_type":"point",
            "minzoom":5,
            "maxzoom":24,
            "tiles":[
                "http://https:%2F%2Fmyhost.tld/maps/location/subscribers/{z}/{x}/{y}.pbf"
            ]
        },
        {
            "version":2,
            "extent":4096,
            "id":"subscriber_areas",
            "name":"subscriber_areas",
            "geometry_type":"line",
            "minzoom":9,
            "maxzoom":24,
            "tiles":[
                "http://https:%2F%2Fmyhost.tld/maps/radiolocation/subscribers/{z}/{x}/{y}.pbf"
            ]
        }
    ]
}

If it makes any difference I'm running FreeBSD 14.1 as the OS, with tegola from a fresh (today) git pull

in looking at func scheme() I see we do some auto detection for X-forward-for,   This header is considered non-standard though its use fairly ubiquitous.   X-Forward-For has been superseded by RFC7239  Would be well served to implement support for that as well.    haproxy will set this header properly when options forwarded is add to the backend.     The go-forward package  makes handling all of this easy

Thank you for this report. This does sound like a bug.

I'll look at this issue tomorrow.

@dBitech well fixing this turned into a bit of a refactor journey for me. Here's the PR if you want to give it a test: https://github.com/go-spatial/tegola/pull/1004. Note, I have not implemented the forward header enhancement yet. That will happen in a separate issue (#1003)


Disable Raven in test environment

Is the benefit that the exceptions now get displayed in the console?

The main reason for me was to remove the logging to STDOUT, which made running tests withvim-dispatch not as easy

How about moving Raven to only staging and production environments? e80491e

LGTM


Deprecate X509_OBJECT_up_ref_count

Import of openssl/issue/21121 reported by davidben
title:	Deprecate X509_OBJECT_up_ref_count
state:	OPEN
author:	davidben
labels:	branch: master, help wanted, triaged: feature
comments:	0
assignees:
projects:
milestone:
number:	21121
With X509_OBJECT opaque, I don't believe there is anything useful a caller can do with X509_OBJECT_up_ref_count. Despite the name, it doesn't increase the ref-count of the X509_OBJECT itself (X509_OBJECT is not ref-counted). It bumps the refcount of whatever object is stored in the X509_OBJECT, without returning the object or anything.
It's used within the library right after copying some value into an X509_OBJECT, to update the ref-count accordingly. But that's to used in the course of getting an X509_OBJECT into a consistent state, but the public APIs should handle that already.

Not going to do this,  for compatibility with apps/foreign language bindings, etc based on feedback from TB

Actually, I think we can remove this. I can't find any use of it in our ports tree or on codesearch and the reason we still have it is simply that I hadn't noticed that it was unused.


Unused json doc customizations

We recently deleted the following code that had been unused. Do we need to introduce any of the originally intended behavior behind this code?
<!-- CLASS_DETAIL_TEMPLATE BEGIN -->
<xsl:when test="$normal-tparam = 'Allocator'"><xsl:text>__Allocator__</xsl:text></xsl:when>
<xsl:when test="$normal-tparam = 'InputIterator'"><xsl:text>__InputIterator__</xsl:text></xsl:when>
<xsl:when test="$normal-tparam = 'ConstBufferSequence'"><xsl:text>__ConstBufferSequence__</xsl:text></xsl:when>
<xsl:when test="$normal-tparam = 'MutableBufferSequence'"><xsl:text>__MutableBufferSequence__</xsl:text></xsl:when>
<!-- CLASS_DETAIL_TEMPLATE END -->

You know what, this is using the old docca code's mechanism, so it's quite obsolete, and since these are just reformatting the same names, there's no real knowledge to retain here. Nothing to see here...