🌱 Move fmuyassarov to emeritus_approvers

What this PR does / why we need it:
I can no longer commit to contributing to Metal3 as I've moved to another project.

/approve
/lgtm
/test-ubuntu-integration-main

/cherry-pick release-1.1

/cherry-pick release-1.1

/cherry-pick release-0.1


Javascript error when loading the remote entry upfront

Hello,
I am trying to improve the library sharing between shell and microfronts using the feature to load the remote entry upfront:
https://www.angulararchitects.io/aktuelles/dynamic-module-federation-with-angular/ -> Improvement for Dynamic Module Federation

I am attaching screenshots of the code and the error:
zone-evergreen.js:1063 Unhandled Promise rejection: Cannot read property 'init' of undefined ; Zone:  ; Task: HTMLScriptElement.addEventListener:load ; Value: TypeError: Cannot read property 'init' of undefined
at dynamic-federation.js:28
at Generator.next ()
at tslib.es6.js:74
at new ZoneAwarePromise (zone-evergreen.js:1387)
at Module.__awaiter (tslib.es6.js:70)
at initRemote (dynamic-federation.js:17)
at HTMLScriptElement.script.onload [as __zone_symbol__ON_PROPERTYload] (dynamic-federation.js:44)
at HTMLScriptElement.wrapFn (zone-evergreen.js:763)
at ZoneDelegate.invokeTask (zone-evergreen.js:406)
at Zone.runTask (zone-evergreen.js:178) TypeError: Cannot read property 'init' of undefined
at http://localhost:3000/vendor.js:52:25
at Generator.next ()
at http://localhost:3000/vendor.js:195:71
at new ZoneAwarePromise (http://localhost:3000/polyfills.js:1397:29)
at Module.__awaiter (http://localhost:3000/vendor.js:191:12)
at initRemote (http://localhost:3000/vendor.js:41:20)
at HTMLScriptElement.script.onload [as __zone_symbol__ON_PROPERTYload] (http://localhost:3000/vendor.js:68:13)
at HTMLScriptElement.wrapFn (http://localhost:3000/polyfills.js:773:39)
at ZoneDelegate.invokeTask (http://localhost:3000/polyfills.js:416:31)
at Zone.runTask (http://localhost:3000/polyfills.js:188:47)

@manfredsteyer, could you take a look at it? No hurries!

Thanks for the reminder. Look into it asap

Hi, I think the problem is inside your shell app main.ts.
You use in the  loadRemoteEntry function the names with dashes whereas you use underscores in the micro-frontends application names.
Use app_a  instead of  app-a.
Use app_b  instead of  app-b.

Oh! @GillianPerard, I see your answer now! Sorry, and thanks for it.


HWKAPM-593 : Fix for large trace instance diagrams

Moved the instance details table below the DT diagram;
Clicking on the details icon the modal is shown with single trace instance

@ammendonca Looks good, but found a couple of issues:
When I selected the first endpoint, it had 10 instances, selected one and viewed it - all fine.
I then did a different invocation against a second endpoint - I then selected that other endpoint - the top half of the page updated as expected, but the table did not get cleared. The only thing that changed on the table was the endpoint - but there should have only be a single instance.
Thinking that the table should disappear when a new endpoint is selected?
Second issue was scrolling - because I tend to use two fingers on the pad to scroll, this is also the zooming action on the diagram. So now I need to make sure the mouse pointer is located outside the diagram region to be able to scroll down to see the whole table. Not sure what the best option is here, whether to only show fewer rows? Thoughts?

@ammendonca Not actually part of the original issue, but would it also be possible to make the nodes on the instance diagram use the same uri[operation] label structure as in the distributed tracing page diagram? If you want it done as a separate issue, let me know and I will create a jira.

I then did a different invocation against a second endpoint - I then selected that other endpoint - the top half of the page updated as expected, but the table did not get cleared. The only thing that changed on the table was the endpoint - but there should have only be a single instance.
Thinking that the table should disappear when a new endpoint is selected?

Right, it should. I can fix that quickly.

Second issue was scrolling - because I tend to use two fingers on the pad to scroll, this is also the zooming action on the diagram. So now I need to make sure the mouse pointer is located outside the diagram region to be able to scroll down to see the whole table. Not sure what the best option is here, whether to only show fewer rows? Thoughts?

I've faced the same issue several times while testing, but I can't figure a good way to overcome that. Showing fewer rows could be a way, but in case of the screenshot you've shared, we wouldn't have much more space than for a couple of entries (with space for pagination, filtering, etc).
For this reason I'd still prefer just the modal (which when expanded would be as it is now, large and with much space for the diagram).. but depends mostly on how important you think it is to view the DT diagram and the instances information at the same location.

If we went with your suggestion, how would the user move from the expanded diagram view, and back to the collapsed table showing all of the instances?

I'd say we could toggle it to show/hide with the icon we currently have for showing it.

Sounds good to me - @cardosogabriel is this approach ok for you?

Full modal alternative:

Taller area, but not full modal:

@ammendonca My vote would be for the first 'full modal'. Would it also be possible to make the distributed tracing region full page height? Or is this difficult to calculate?

only issue is whether it is intuitive that they should press the details icon again to collapse the table.

only issue is whether it is intuitive that they should press the details icon again to collapse the table.

Right, we can adjust the icon to make it more obvious, change it to a "Hide" button or just add this "Hide" button to the top-right of the diagram.

Would it also be possible to make the distributed tracing region full page height? Or is this difficult to calculate?

I can try, I think with SVG it's hard to achieve this

From the modals, I also prefer the full modal approach.
Suggestions of improvements:

Remove (393 entries shown) from the modal title, since when you are seeing only one detail this information is inconsistent. You can place this information above the table, on the right side, for example.
When seeing only one instance, place the link "Back to full table (383 entries)" above the table, where the filters where. Screenshot here.

Agree with @cardosogabriel. Will fix accordingly.
@cardosogabriel, can you make the Distributed Tracing to have full height instead of the fixed 500px (https://github.com/hawkular/hawkular-apm/blob/master/ui/src/main/scripts/plugins/e2e/html/e2e.html#L24) ? I have been able to almost achieve it, but calc is playing tricks on me. Basically making the card-pf having the full height and then children div having 100% seems to work.

@cardosogabriel looks good

Updated to use the full modal and with @cardosogabriel suggestions.
Also improved checking for EJB/Database type of nodes, being case insensitive.

@ammendonca Works great, thanks!

@cardosogabriel Thanks!


Suggestion: Map Info: Boss Arena y/n

🚀 feature request
Could you add whether the boss is in an arena to the map info?
Thanks!

Hi, thanks for your suggestion. The information is based on the following table:
https://pathofexile.gamepedia.com/Map
Currently this does not include whether the boss is inside an arena or not. As the Wiki is Community driven - we can try reaching out and ask them for a extra HasArena column. Can you ask them? Thanks! 🚀


More friendly test warnings if plugins are not available

If the gdal.input or ogr.input are not available then various tests fail: https://gist.github.com/springmeyer/4cbaaf6218d0b76d8da1d705cf7115ff.
We should modify the tests to print a BIG CLEAR warning that gdal.input is missing rather than let these tests fail.
This will happen when building node-mapnik against the default homebrew mapnik package brew install mapnik because by default homebrew does not build mapnik against GDAL. That would require brew install mapnik --with-gdal.

How can I check the list of available plugins - there is no API.

How can I check the list of available plugins (and recognized)?

var mapnik = require('mapnik');

mapnik.register_default_input_plugins();
console.log(mapnik.datasources());

Output on my system:
[ 'csv',
  'gdal',
  'geojson',
  'ogr',
  'pgraster',
  'postgis',
  'raster',
  'shape',
  'sqlite',
  'topojson' ]

@Arsakes I'll work on getting the plugins documented on mapnik.org later today. Apologies!

Semi-related: mapnik docs have been updated to include a section about plugins right at the top. The available methods have been added to the main mapnik constructor http://mapnik.org/documentation/node-mapnik/3.5/#mapnik.registerDatasource


sipcreator.py: dcp fucnction -clairmeta test additions

@hyz2993 in the case where using sipcreator.py for a dcp - can you add in an extra step to print out a .txt file of the results of clairmeta for the ifiScripts logs folder on the desktop.
currently the results are printed at the end of the script but it would be really handy to also have them in a text file that can be found in the ifiScripts logs folder. naming it after the oe number and clairmeta.
e.g. oe1234_clairmeta_outcome.txt
I'm printing here a recent cli output from sipcreator.py, - that would be what I would suggest would be printed in the .txt file:
_Status : Success
Path : Z:\psm\2023\April\elpis_oe25877\Elpis_FTR-1_F_EN-XX_20_2K_20230209_SMPTE_OV
Size : 58.19 GiB
Total check : 107
Total time : 351.31 sec
Warning(s):

cpl_842d7d47-ec86-4642-b002-9ee7007d576f.xml (Elpis_FTR-1_F_EN-XX_20_2K_20230209_SMPTE_OV)
. Digital Cinema Naming Convention compliance (9.3).
ContentTitle should have 12 parts to be fully compliant with ISDCF naming convention version 9.6, 9 part(s) found
Field TerritoryRating not found in ContentTitle
Field Studio not found in ContentTitle
Field Facility not found in ContentTitle

DCP - Z:\psm\2023\April\elpis_oe25877\Elpis_FTR-1_F_EN-XX_20_2K_20230209_SMPTE_OV - Check succeeded_

This issue has been worked on and updated on #49

This issue has been solved and will be released next week.


Longhorn redeploy PV/PVC recovery

Look into if there is any way to recover PV/PVC's from backup when they don't currently exists, such as during a cluster rebuild, etc.

Closing - Not currently possible


Update Event Grid UT  in spring

Description
Sync codes from https://github.com/Azure/azure-sdk-for-java/pull/37246
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
spring-cloud-azure-autoconfigure


track token position and lengths

This PR updates sqlparse to keep track of token positions and lengths. We actually already have some logic added to our fork of sql-metadata to try to do something similar, but I think it will be more robust to handle this at the sqlparse level because its lexer is seeing the exact original position of each token in the source text whereas sql-metadata has to try to reconstruct positions from sqlparse's output

I feel pretty confident in the tracking given the simplicity of the lexer. It's using the position straight from the regex match that's used to tokenize


add post-start and pre-stop script

What type of PR is this?

/enhancement
Which issue(s) this PR fixes?

Fixes #135
Fixes #145
Fixes #149
What this PR does?
Summary:

Generate post-start.sh script.
Generate pre-stop.sh script.
Add pod disruption budget.
update go.mod request go 1.16+
update test case
Add pvc check to clean up the extra pvc.
modify the rootHost's default value from <IP_ADDRESS> to localhost, refer: percona docker

Special notes for your reviewer?

LGTM

LGTM

disruption budget： https://www.jianshu.com/p/ac43a0876a5b

if do not have updatePVC， it will happe like this

Pod has changed ，but storage do not change

LGTM.


Hi im the owner of PteroController and i kinda need your help can you give me your discord or add me on discord?

My discord: NaysKutzu#5375
Im also using c# winforms and i kinda need ur help

or can you help me here https://stackoverflow.com/questions/76445813/how-can-i-remove-the-ansi-escape-sequences-from-a-string-in-c-sharp

Sorry, but this is kinda the wrong place here this is for issues from Moonlight we are no coding help Center.
Please look on a Coding help Discord sutch like.
https://discord.gg/devsky [this one is in German]


Unable to translate text to another language

Hi. I am using Laravel 5.1. i just installed the waavi package and tried with the translation. But it seems that my text is unable to translate to another language other then the default english. On my blade file i did this {{ trans('messages.member login') }}. when the page is loaded, i saw this Member Login which is correct. But when i tried to switch to  locale 'zh_cn' the text should change to it chinese text. the chinese text has already being entered into the DB. when user tried to switch langauge i put the locale into a Session like this Session::put('locale', 'zh_cn').
is this wrong?
if wrong how do i swap the locale for the chinese text to be shown?
my config/translator.php looks like this
return [

    /*
    |--------------------------------------------------------------------------
    | Default Translation Mode
    |--------------------------------------------------------------------------
    |
    | This option controls the translation's bundle mode of operation.
    |
    | Supported:
    |
    |   'mixed'         Both files and the database are queried for language entries, with files taking priority.
    |   'database'      Use the database as the exclusive source for language entries.
    |   'files'         Use files as the exclusive source for language entries [Laravel's default].
     */
    'source'            => 'database',

    // In case the files source is selected, please enter here the supported locales for your app.
    // Ex: ['en', 'es', 'fr']
    'available_locales' => ['en', 'zh_cn'],

    /*
    |--------------------------------------------------------------------------
    | Default Translation Cache
    |--------------------------------------------------------------------------
    |
    | Choose whether to leverage Laravel's cache module and how to do so.
    |
    |   'enabled'       Boolean value.
    |   'timeout'       In minutes.
    |
     */
    'cache'             => [
        'enabled' => env('TRANSLATION_CACHE_ENABLED', true),
        'timeout' => env('TRANSLATION_CACHE_TIMEOUT', 60),
        'suffix'  => env('TRANSLATION_CACHE_SUFFIX', 'translation'),
    ],
];

Hi!
The easiest way to give the user the ability to switch languages is to use the Translation Middleware that's included (https://github.com/Waavi/translation#uri-localization). With this middleware active in your routes, users visiting http://example.com/en/your_url will get the english version and users visiting /zh_cn/your_url will get the Chinese version.
This middleware will also allow you to show the user a menu to switch languages in your blade templates, for example:

    {{ $currentLanguage->name }}

        @foreach ($altLocalizedUrls as $alt)

url }}" hreflang="{{ $alt->locale }}">{{ $alt->name }}

        @endforeach

Both $currentLanguage and $altLocalizedUrls are set automatically by the translation middleware.
To switch languages manually, you must do \Lang::setLocale('zh_ch'), but this will only work for the current request.
If you want to switch languages based on a variable in Session, you will need to register a new Middleware to do so. I'm trying to work on an update that will allow you to do this.

hi.. i fixed this already.. i created a middleware to set $app->setLocale(Session::get('locale')) .. thx


All hardsuit helmets should protect your eyes from welding

Description

I'm pretty sure that welding helmets are rather scarce too, also the blind effect sucks.
Reproduction

Screenshots

Additional context

Pretty sure this was both discussed and PRed and boiled down to "no because dont buff hardsuits more".

Still think we need to add more welding protection, don't even know if we have welding goggles, that should project your eyes since you can't wear the helmet during eva

Mesons protect your eyes as well. Sunglasses give partial protection

just ask engi for protective glasses, powercreep for the sake of powercreep is not welcomed


Add a GHA to test subctl

This ensures we know whether changes made to the operator are going to
break subctl, before merging them.
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

See https://github.com/submariner-io/submariner-operator/runs/7433523195?check_suite_focus=true for a correct failure related to breaking changes in https://github.com/submariner-io/submariner-operator/pull/2126


Configuring Ranger

:clipboard: Description
I noticed that you installed Ranger but have not yet used it to automate merging PRs, closing issues, or handling other tasks.
Have you had any trouble with it, or need any help configuring it? I am here to help! 👍
If not, feel free to close this issue (or have Ranger do it for you 🙂)

hi @mfix22, thanks for reaching out. We did try to use it a while back on our PRs but were unable to get it to work. I still think we'd really benefit from the functionality, but we didn't really have time to dig into why it wasn't working/what we may have been missing/etc.
If you have any insight on how we could get it working that would be great!
One example of a PR where we tried: https://github.com/badges/shields/pull/3526

Hey @calebcartwright sorry to hear that! I would love to help make sure it is working correctly for you. I see that all the checks passed on your PR, so that is looking good ✅ Did you have any other protections on the master branch at all?
On a fresh clone of the repo, I see that Ranger is working fine, https://github.com/mfix22/shields/pull/1#event-2592619178, so I am assuming it has something to do with your other integrations, most likely CI/CD.
If you could try again with a small/dummy PR, that would be great, otherwise I will try and set up CircleCI on my fork to better recreate the situation.

We use quite a lot of branch protection rules on this repo. My assumption is that one of these rules is preventing repo ranger from being able to merge for us. We have the following rules enabled:

Require pull request reviews before merging
Required approving reviews: 1
Dismiss stale pull request approvals when new commits are pushed
Require status checks to pass before merging
Require branches to be up to date before merging
Include administrators
Restrict who can push to matching branches: Organization and repository administrators, badges/shields-core

Any thoughts?
While its nice that you've proactively contacted us about this, one of the reasons we've not followed this up at all is that its not very obvious how to contact you with a support query. Even if your code is not public, have you considered setting up a public issues-only repo or something?
Thanks

Just wanted to say @mfix22 that a merge queue we could kick off after an approving review that would take care of updating the branch, waiting for tests to pass (except LGTM and Docker, which take too long), and then squash-merging, would be super helpful for this project. I'd estimate it would save 1–2 hours of maintainer time a week.

While it's nice that you've proactively contacted us about this, one of the reasons we've not followed this up at all is that its not very obvious how to contact you with a support query. Even if your code is not public, have you considered setting up a public issues-only repo or something?
Thanks

@chris48s this is great feedback, thank you. We have a public feedback form you can contact me at here: https://reporanger.com/feedback, however, I will also set up a public issues-only repo for tracking bugs/issues here: https://github.com/reporanger/feedback.

@paulmelnikow that is great to hear — I would absolutely love to help you save those hours.
If you add the "squash when passing" label to a PR, Ranger will automatically squash-merge the PR once all the required statuses are passing, following all integration status checks, branch protection rules, etc.
I you can add the label to a branch in need of merging, I can investigate why it might not be being merged.

Can you look at the example @calebcartwright posted? https://github.com/badges/shields/pull/3526

Can you look at the example @calebcartwright posted? #3526

On it 👌

#3880 has the necessary approvals.

This is what we have under "restrict who can push to matching branches".

Do we need to add a user for Ranger?

Hey @paulmelnikow I think you are right! The public status listing shows that the PR has a mergeable_state of clean, which means "good to go", however Ranger is getting the status: blocked which means that is is not able to merge the PR.
Can you try adding Ranger to an approved list you mentioned above? We have never seen this specific set of branch blocking rules before so I really appreciate you are letting me debug this 🙂

I can only add GitHub users. Which user is it?

@repo-ranger is the username.

It's added!

Looks like the PR was merged!

Great! 👍 Thanks for working through this with me. I added another set of logging to our backend that will help me understand this issue faster in the future 👌
Now that we got it working, are there any other features you would like help automating? On other repos I maintain, I configure things like: automatically deleting HEAD branches, deleting ":+1:" comments, stuff like that 🙂

Awesome!
Will it update an out-of-date branch before attempting to merge it? That's the thing we need for this to be useful.

Will it update an out-of-date branch before attempting to merge it?

And would we need that to be done via a dependabot command on dependabot opened PRs to avoid merge conflicts, and if so can ranger support that?

We are actively building out that feature, but trying to figure out how to best fit it in with the rest of Ranger's config.
I will ping in this thread, or in a new issue immediately once the feature ships.

Thanks for helping with this. Even without the ability to auto-@dependabot rebase this will probably save a bit of time.
It would be helpful to mention in the documentation that users need to manually give @repo-ranger write access to master in the branch protection config as well as authorising the app. I suspect we won't be the first users not to understand this.

@chris48s done! reporanger.com/docs — Under the section on "Merging Pull Requests"
Also I have just pushed the feature that will keep a branch up to date as long as your branch protection rules require that. Would you like me to enable that feature for you repo?

Nice. Yes. Lets give it a try. Thanks

@mfix22 I noticed the merge queue is waiting on LGTM to run, which is not a required check, mostly because it is sometimes very slow!
Can I request a feature that only the required checks must pass in order to merge?
Or alternatively, that we can list certain checks to ignore?

The automatic branch updating is working!

Hey @paulmelnikow 👋 looks like Ranger no longer has permission to merge your branches. Did a branch protection rule recently get updated? You might have to give Ranger write access to re-enable PR merging.
You can find how to handle this under the "Branch Protection" section of the Repo Ranger docs

Seems to have just merged one in #5026 no?

Oh, okay. Great!

Thanks for reaching out!
We had an issue where maintainers couldn't click the "Update Branch" button. It might have been due to a setting on the PR or maybe it was some GitHub fluke. See https://github.com/badges/shields/pull/5008#issuecomment-622978456
Maybe that was related?

That could be! Thanks @paulmelnikow. I'm just glad it is still working 👍


Rename FastHotStuffConsensus to FastHotStuffEventLoop

Current dependencies on/for this PR:

feature/proof-of-stake

PR #649

PR #651   👈

This comment was auto-generated by Graphite.


Adding additional sensors/support for battery inverter

Added the integration to HA yesterday, seems to work well so far.
Now I would like to add more sensors, for example to see dc power per string.
Additionally I do have a battery inverter which I would like to connect as well. The integration seems to connect initially, but reports 'Failed to set up' as soon as the inverter is added(didn't try logger yet). I also tried the 'test.py' which connects to both inverters just fine and reports correct data.
Unfortunately I have no experience writing Python or HA integrations. Any hints on which parts of the code need to be edited would be appreciated.
Edit: restarted Homeassistant, now the battery inverter seems to be fine, no more error...

sma_speedwire.py: library to commulicate with SMA inverter

COMMAND_LIST: extend with commands to read from inverter, check https://github.com/Rincewind76/SMAInverter
self.sensors: extend list of sensors
def _fetch(self, command): extend parser to parser added command responses and fill self.sensors
def update(self): call added command

sensor.py: HA sensor

def __init__(self, coordinator, device, sensor): extend wit your added sensors. Check here https://developers.home-assistant.io/docs/core/entity/sensor/

contact me, mb i can help you.


make external links possible by using relURL

cf https://gohugo.io/content-management/menus/#example-site-configuration for a config example


fix: replace deprecated vim.tbl_flatten with vim.iter

Supersedes #43, as #43 broke the column for me.
If backwards compatibility is a concern, I'd be happy to add a code path which feature detects vim.iter.

Updated as suggested, thank you :blush:


blog: author name clickable, description and posts by the author visible

Fix #1120

[X] Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

[X] 🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

[X] Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Built a new Author Page that looks like this:

The link for every author is their sourcePath except .md
If the sourcePath is: authors/dmitry_petrov.md, the link would be: authors/dmitry_petrov.

make author name clickable

Resolved: The link on every blog post for the author's social media handle has been replaced with the link for their author page.

show description and posts by the author

Done. Unfortunately, the authors node in graphql does not have the description field unlike the markdown files of authors. Thus, I was not able to add a great description and had to just add their social media links.
For the future, as #1349 mentions, we can add more links in Blog/Author/index.tsx by passing the required props.

I just made the change that generates a slug at build time and uses that. We may also want to link this page in other places where Author names show up, like the Post index.

Done. Unfortunately, the authors node in graphql does not have the description field unlike the markdown files of authors. Thus, I was not able to add a great description and had to just add their social media links.

I can add a description field here, that's no problem!
Actually, what do we want for descriptions? We could have something like longDescription on blog posts which is externally precompiled markdown in the frontmatter, or we could use the Author's Markdown body content in whole or in part.

Also, I'm open to rolling #1349 into this and adding the multiple links support. It'd make more sense to introduce the schema change with a feature that uses it.

GitHub didn't pick up on the deploy I triggered, but it was sucessful and anyone who's interested in seeing the current Author page can see it here

I added a quick fix to an issue I started to run into where deploy branches have problems re-using their cache. I need to diagnose this more, but since it was so small I added it here to get the deploy rolling.

Things we need to do before we merge/move forward with this:

[ ] Design work for the author page header. It looks quite ugly at the moment.
[ ] Include author descriptions.
[ ] Authors should be clickable on the main page as well as blog page.
[ ] We need to show some summary, or even Twitter/Linkedin/Email icons near the author or when you hover over it on the blog post page
[ ] We need pagination for the author page.

Design work for the author page header. It looks quite ugly at the moment.

Agreed

Include author descriptions.

I have the page adding the body via html currently, which is one possibly way we can handle descriptions. I'm open to changing this to another method if we think it's easier for editors.

Authors should be clickable on the main page as well as blog page.

Agreed, and simple enough

We need to show some summary, or even Twitter/Linkedin/Email icons near the author or when you hover over it on the blog post page

I think the most efficient course of action here would be to roll #1349 into this PR, as it will both affect the design of this page and serve as a source for Author social icons to be added throughout the site.

We need pagination for the author page.

Agreed, and I think the existing pagination logic has needed a touch-up for a while anyway so I'll get to look at it when I re-use it here.
@utkarshsingh99 How would you like to divide the work left on this repo? I'm happy to take as much or as little as you'd like.
I'll start with doing #1349 since I started the issue, and then tackle pagination since that involves the Gatsby APIs heavily. Would you like to iterate on the design of the template? It would help a lot having that done at the same time as these schema changes.
And, of course, if you want or need to drop this I can pick it up. We've gone a little out of the original scope of a copy of the Blog index, after all! You've been a great help either way, so thanks a lot!

Some questions from me:

The link on every blog post for the author's social media handle has been replaced with the link for their author page.

Should author names directly in the blog home page link to their pages too?
UPDATE: I see roger also noted this in https://github.com/iterative/dvc.org/pull/1364#issuecomment-634920420. I vote for yes.

the authors node in graphql does not have the description field unlike the markdown files of authors...
what do we want for descriptions? We could have something like longDescription on blog posts ... or we could use the Author's Markdown body content

Sorry, I'm not understanding this question. I see the author md content as desc already:

What's wrong with that?

I'm open to rolling #1349 into this

@rogermparent if you're taking over I say go for it but if @utkarshsingh99 will be able to continue being the main contributor here I'd recommend we focus on a single issue for now and open a separate PR for that.

GitHub didn't pick up on the deploy I triggered

It did after a while. Heroku probably only fires web hooks every several minutes 🙂

Sorry, I'm not understanding this question. I see the author md content as desc already:
What's wrong with that?

That comment was made before I added the md content as descriptions. I think this method for descriptions is good to move forward with, especially where it's currently how the content is shaped. We can change it later if we decide to make bigger descriptive Author pages.

I'm open to rolling #1349 into this

@rogermparent if you're taking over I say go for it but if @utkarshsingh99 will be able to continue being the main contributor here I'd recommend we focus on a single issue for now and open a separate PR for that.

I actually already did it! That issue at its minimum was actually quite small, and the difference between having an array of multiple links and one link string is huge when designing the template. I'll certainly have to build on it though for features like icons, so I can do that in another issue and let @utkarshsingh99 continue on this one.
If I finish that before this PR is done, we can always merge the new schema and work it into the page here!

Design work for the author page header

Yeah it also has a weird responsive jump from 990px width to 1005px. It should have a max-height/scroll too probably? I was able to do this from DevTools:

[ ] I would add the whole author list needs redesign. I suggest a vertical list with small rows (covering the full width, instead of 3-per-column) per post: the img to the left, and the gray area with meta info in the remaining space. I see author pages more like an archives so no need to be fancy with the design.

Would you like to add links to other places where Author names show up, iterate on the design of the template?

This is a great suggestion for @utkarshsingh99 probably. But if the design stuff is becoming tedious or taking too long please feel free to move on to other issues or developing your GSoD project ideas, Utkarsh. Also if you have issues with Git since you're collaborating with someone else in the same PR, please let us know.

Apologies for the late reply.

Would you like to add links to other places where Author names show up,

Sure. I believe the only places that need to be linked are in the main blog-index which will have to be changed in FeedMeta component? @rogermparent

iterate on the design of the template?

I would definitely like to do it but I'm not particularly sure of what I have to do here. Does this mean going over the points listed in #1364(comment)

But if the design stuff is becoming tedious or taking too long please feel free to move on to other issues or developing your GSoD project ideas

It's no problem. Working on this PR was fun and it would be great to help @rogermparent take this to the finish line.

if you have issues with Git since you're collaborating with someone else in the same PR, please let us know.

Sure. I believe I will have to remove the file mentioned in #1364(comment) by reverting its commit specifically?

@utkarshsingh99

Apologies for the late reply.

No worries!

Sure. I believe the only places that need to be linked are in the main blog-index which will have to be changed in FeedMeta component? @rogermparent

I believe that's the case! I don't see them anywhere else.

I would definitely like to do it but I'm not particularly sure of what I have to do here. Does this mean going over the points listed in #1364(comment)

That's more or less the case. I just started on implementing the data sourcing for multiple links and icons, then overhauling pagination. I'll probably do these in other PRs that can be merged here later on.
If you'd like to copy the existing pagination logic for Blog feeds to get started, you're more than welcome to. The current blog pagination logic uses an unusual generator syntax so it could be difficult to understand, but it's readable enough to copy/paste if you want to get started on making the template pagination-compatible before I get to re-doing pagination.
You could also hard-code and/or define dummy data in consts, just for now while making a design, and then we'll plug real data into it later on when the data sourcing mechanism is done.

Sure. I believe I will have to remove the file mentioned in #1364(comment) by reverting its commit specifically?

I think we'd prefer you just revert with another commit. From what I understand, we have a bot that squashes branches before merge. In this case, we don't have to worry about history and just pushing a new commit that removes the file has no consequences.
Just to confirm, am I correct that we squash merges @shcheklein?

P.S.: What are we going to do about the codeclimate failed checks and its suggested optimizations? I believe keeping certain similar code sections would be inevitable due to their partial difference.

The way I treat codeclimate is to look at it to see if anything addressable jumps out, but otherwise not worry about it. codeclimate being satisfied is optional, despite how the red X looks on GitHub's UI!

Just to confirm, am I correct that we squash merges @shcheklein?

yes, I do squash and merge. (primarily since we tend to have a few commits with some images)

#1375 builds on the quick commit I made here to add special metadata to author links. It's heavily connected to this issue, despite being separate, so I figured I should point it out in a comment here as well as there.
@utkarshsingh99 I could merge this in to whatever you have pushed here, or you could handle it on your own. Your call! It'll probably help a lot having something to design around, and the SocialIcon component will also be useful.

@utkarshsingh99 I actually got a little too excited and went and did the merge myself. I hope the new social icons help you, and more importantly that I haven't clobbered anything you were working on!
Also, a hint on getting links on the blog post indexes: we're using the same FeedMeta component everywhere for author names, it's all about getting the author's slug delivered to FeedMeta to get an author link there.

@rogermparent

@utkarshsingh99 I actually got a little too excited and went and did the merge myself.

Haha, that's okay. I will get on the linking task asap.
About the pagination, since you will be already making a newer pagination logic, I was thinking I would wait for that commit and then add pagination compatibility to the author template, so we won't have to add/delete any unnecessary code altogether. But if you want me to add current logic to the pages so you can test the pagination, I could do it before, if you want.

yes, I do squash and merge. (primarily since we tend to have a few commits with some images)

Okay, I'll do this. Just in case if I have any problem, should I prefer asking these kinds of doubts on Discord?

Haha, that's okay. I will get on the linking task asap.

Great! Thanks a ton!

About the pagination, since you will be already making a newer pagination logic, I was thinking I would wait for that commit and then add pagination compatibility to the author template, so we won't have to add/delete any unnecessary code altogether. But if you want me to add current logic to the pages so you can test the pagination, I could do it before, if you want.

Sounds good to me! I'll have that done sometime tomorrow.

Something I noticed that I should also mention is that we may want to not show the Author line in post items in the Author feed since it's pretty redundant.

A good example (the only one right now) of multiple author links is Dmitry's Author page

[x] I have reverted the commit of the import.md file which was accidentally added here.

[x] Author name is now clickable at the Blog Home page

I have another idea, but I don't think it is relevant here, maybe. In the blog home page, only the Title and the Meta Image of each blog post is clickable.
I think it would be great if we could make the entire component clickable, except the author link and twitter link.
Now the only way I can think of doing this with the author link constraint is by adding an event listener around the Meta component and check if the event's target is not the author link or twitter icon.
Should we do this?

@utkarshsingh99 Nice! I merged in an update of the social icons I added earlier. I already merged your edits to make sure they work together.

we could make the entire component clickable to display the blog post, except the author link and twitter link.
Now the only way I can think of doing this with the author link constraint is by adding an event listener around the Meta component and check if the event's target is not the author link or twitter icon.
Should we do this?

I agree expanding the card component (I think it's Feed/Item?) click area would be a good thing, but I don't like how much the suggested implementation leans on JS to make a link, even if we gate it behind progressive enhancement. An HTML/CSS solution would be best here, and I can think of a couple we can try.
Given the card's design with all the metadata and alternate links at the bottom, I would suggest making the blog link wrap around the image, title, and description while having the FeedMeta outside to contain its own links.
This also feeds into the "We show authors on cards on the pages that only have one author" issue- if we make this separation in the card, we can also make the FeedMeta component change depending on context (e.g. don't show authors on the author pages), making the card component more re-usable for this and future purposes where we may want a different FeedMeta.

Oh no, I meant to push the final social links branch and broke something. I'm sorry, hold on, I'll fix it!

@utkarshsingh99 I mentioned I'd do icons "tomorrow" two days ago, but the social icons ended up ballooning unexpectedly so I wanted to get them fixed and merged ASAP. Anyway, I'll do pagination now in this repo and then you should have all the data you need to make a killer Author page!
With how the Author links are handled now, we can work with additional metadata for them. For example, we already extract the username from Twitter, GitHub, and LinkedIn profiles and expose it via GraphQL in case you want to display a username beside an icon or something.

@utkarshsingh99 I just added pagination to the Author pages! The implementation code is a little ugly, and I haven't migrated the blog's pagination just yet, but this should be enough such that you can get started considering it in the design.
I definitely have to clean it up tomorrow, though.

I'm sorry for being inactive due to the past few days. There was an issue with the internet connectivity due to some weather disturbances in Mumbai.
Please have a look at the new header in the author's page.

we can also make the FeedMeta component change depending on context

I agree with @rogermparent 's idea that we need to have a new FeedMeta component for author page since the author name on the card on author page looks pretty unnecessary.

With how the Author links are handled now, we can work with additional metadata for them. For example, we already extract the username from Twitter, GitHub, and LinkedIn profiles

Thanks! I have used username of the author in the header.
@shcheklein @jorgeorpinel @rogermparent Please let me know if the new design is good and is there anything else in the PR that remains?

Please let me know if the new design is good and is there anything else in the PR that remains

TBH I'm not following this PR's details closely, I'll let Roger or Ivan answer that. Thanks!

@utkarshsingh99 @rogermparent great work! It is definitely a good progress.

is there anything else in the PR that remains?

Please check this comment:
https://github.com/iterative/dvc.org/pull/1364#issuecomment-634982031

Please let me know if the new design is good

Design looks good, way better than it was before, but we still need to involve our designer.

Authors (name and avatar) should be clickable on the main page as well as blog page.

@shcheklein done.
@rogermparent Please check the code quality of the latest commit in FeedMeta, since I had to make some necessary omissions. For some reason, the Link wasn't working wrapped around the gatsby Image component until I removed the className attribute from Link. Might be because of the @mixin link property?

Include author descriptions.

@shcheklein I think this has also been completed in #1364(comment). The author header does show their descriptions.

Design looks good, way better than it was before, but we still need to involve our designer.

Thanks! Sure, I would be happy to make further changes.

[ ] Something funny is happening here marija-ili%C4%87-65b8a53 - https://dvc-landing-author-page-afpkg5.herokuapp.com/authors/marija_ilic
[ ] Need to update @SvetaGr description here - https://dvc-landing-author-page-afpkg5.herokuapp.com/authors/svetlana_grinchenko
[ ] Need to support basic Markdown in descriptions . E.g. to put creator of DVC instead of dvc.org. Check @dmpetrov ' description
[ ] When author has multiple social network links, spacing is wrong:

@shcheklein I just checked.

Something funny is happening here marija-ili%C4%87-65b8a53

This username, is coming from the backend itself in this way. We will have to probably make changes to the encoding of the characters, and I think something along this line might be the solution to all the 3 problems, but on the backend (my guess). I'm not sure of the backend code here, though.

When author has multiple social network links, spacing is wrong

Actually, even the sizes of the icons have changed. I believe @rogermparent made some wilful changes in the previous commits for this? Not sure.
I think if you review the latest code in SocialIcons, I can change that. (There is a username prop that I have added in the component, and it is undefined when called in the FeedMeta (not an error). Leaving it like that doesn't make any changes to the design though, just makes the component resuable). I was just curious if you guys thought it's a good practice or not.
But I still don't think that's the cause for this spacing error.

So should I make a new component to render social icons in Author Header?
That should resolve this problem here.
SocialIconsAuthorHeader
What do you think about the other 3 problems though? @rogermparent

Something funny is happening here marija-ili%C4%87-65b8a53 - https://dvc-landing-author-page-afpkg5.herokuapp.com/authors/marija_ilic

Ah, yeah the URL looked exactly like that at the time when I copy/pasted, something auto-encoded the URL on paste. The automatic behavior with a link string can be fixed in schema, but a quick fix could also include the explicit object syntax for Author links, using the encoded URL for the URL and the proper unicode name as the username. The format for specifying this object is the exact same as how the GraphQL objects look, just in YML.

Need to update @SvetaGr description here - https://dvc-landing-author-page-afpkg5.herokuapp.com/authors/svetlana_grinchenko

I can't help here, I don't know what it needs to be updated to.

Need to support basic Markdown in descriptions . E.g. to put creator of DVC instead of dvc.org. Check @dmpetrov ' description

This can be done the same way descriptionLong is done in Blog posts, by parsing frontmatter Markdown in the Model at build-time.

What do you think about the other 3 problems though?

Hey guys any way this PR can be separated or some aspects extracted into another issue so Utkarsh can finish his contribution and this gets merged? Trying to make it a little easier on him and also he's helping us in parallel with some content improvements that currently are of higher priority.
Thanks

@jorgeorpinel @utkarshsingh99 @shcheklein

Hey guys any way this PR can be separated or some aspects extracted into another issue so Utkarsh can finish his contribution and this gets merged?

From what I understand, we still need our designer to take a look at it and come up with something. I think this PR is in a good enough state such that once the designer is free and gives us his take, we can match this PR to that design.
We're probably not going to want to merge this PR before we get a design, none of its parts other than the social icons make sense standalone, and the social links are already in master, so I think we're already in a good state to leave this PR as it is and revisit it later.

OK the last activity here was almost a month ago. As there doesn't seem to be a plan for the design, should we close this for now?

(and keep the branch)

@jorgeorpinel reassigned to myself. I'll keep track of it. We got distracted by CML on the front-end dev part, but we can go back.

OK I think it's safe to close this as stale at this point 🙂

@jorgeorpinel I assigned it to myself. Let's keep it open. I keep track of it.

OK sure. I forgot you took it over.

Design in Figma
Overview:
Desktop

Mobile

We will need to upload better images for avatar pics. In the design, they are 100x100px.
Author descriptions were mentioned in this thread earlier.
But probably at the first stage, not all contributors will have one:

In desktop social links are the same as in article items.
In mobile the tap target should be 32x32 at least

The rest of the page including pagination was made of reusable components as in here
The major difference is that it has 9 article items of the same size.

@umnikovas excellent stuff! just a few comments:

not exactly clear how do we position social icons on mobile - what is the space between them?
what happens if name is too long to fit into single line?
on mobile text looks a bit too heavy - only a few pixels of the first post are visible? Not sure if it's a problem or not.
descriptions might have links- we should account for that I guess. May be some other markup?

not exactly clear how do we position social icons on mobile - what is the space between them?

Looks like we have a 5px module in spacing.
I kept that system, so we have AuthorName (15px margin) (Icon 32px box)(5px margin)(Icon 32px box)
If there is not enough space for the social block to fit in the same line with the authorName it should wrap to the 2nd line.
The line-height of the Title is big, so there is only a need of a 5px margin-bottom between it and the icon block. And the same 5px margin-top for the description text.

what happens if name is too long to fit into single line?

If its this case as in Wikipedia, we will have to add  in the string. Or maybe there are some more elegant solutions.

on mobile text looks a bit too heavy - only a few pixels of the first post are visible? Not sure if it's a problem or not.

We can add a spoiler for that only in mobile. So the user can scroll for the blog posts faster. And only read about the author if he needs to, by opening up the spoiler. If the spoiler will be only on mobile, probably the description text can still be used in SEO. I think this could be a good thing to do, as the description could be content-rich.

But still, only some part of the first article will fit. There was a suggestion in this thread, that we can try to visualize the cards differently on the author page. Make them smaller. But I think it should be tested. As I don't think users have problems in scrolling.

descriptions might have links- we should account for that I guess. Maybe some other markup?

Don't know how good is an idea to put links in the author description, but we can do that I think:

Can't say what type of markup could be useful in the author description.
Perfectly if the author's description is short and concise.

Ping @rogermparent or @julieg18 would it be possible for this to get taken over? Or should we close for now (turn into issue)? Thanks

would it be possible for this to get taken over?

False alarm, please disregard for now.

We already have #1120 . Closing this for now.


newsraft: 0.21 -> 0.22

Description of changes
Changelog: https://codeberg.org/newsraft/newsraft/releases/tag/newsraft-0.22

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[x] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2991

Result of nixpkgs-review pr 270385 run on aarch64-darwin 1

1 package built:

newsraft

hash is not updated.

Sorry, fixed.


How to push the whole repository files ?

I want to push the whole repository files to another repository but
the source directory needs to have a value and I couldn't find how to
do that in the docs for example do I need to put an empty string in the source directory
or a / ?
- name: Pushes to another repository         uses: cpina/github-action-push-to-another-repository@main         env:           API_TOKEN_GITHUB: ${{ secrets.API_TOKEN_GITHUB }}         with:           source-directory: ""           destination-github-username: "username"           destination-repository-name: "page"           user-email<EMAIL_ADDRESS>         commit-message: commit message           target-branch: master

Sorry that I didn't answer - I usually monitor better the issues in https://github.com/cpina/github-action-push-to-another-repository .
Probably you've found a solution already! If still searching for a solution try with ".", else let me know and I'll try the best way.


could not get NVD data feed hash

Description of Problem:
I get the following error in the logs
"Get http://static.nvd.nist.gov/feeds/xml/cve/nvdcve-2.0-2002.meta: read tcp <IP_ADDRESS>:47180-><IP_ADDRESS>:80: read: connection timed out"
The Clair docker container is running on ECS, the ECS host has network connectivity outbound
Expected Outcome:
Actual Outcome:
Environment:

Clair version/image: Latest
Clair client name/version:
Host OS: Centos 7
Kernel (e.g. uname -a):
Kubernetes version (use kubectl version):
Helm version (use helm version):
Network/Firewall setup:

I also met related issue, maybe you can try update NVD date manually.
All NVD data can be found in https://nvd.nist.gov/vuln/data-feeds.
Download related data and put them into the related path of clair.
For me, it works and not found ralated issue any more.

How would i go about updating this manually? would you mind giving me an example please?

I think the download issue is caused as NVD seem to have disabled the http endpoint.  I'm just testing running the container with an updated https endpoint.

Once I updated the NVD endpoints to https, the vulnerability update completed without NVD errors.

I've now retested with http endpoints, and they're now working again.  Usual NVD reliability >_<

Fixed in #565


kEps is undefined in device code in file (generalized_projection_cuda.cu)	61

Thank you for your project.
I'am Aerospace Engeneer and new in GitHub. I've a problem in building a project on VS2019.
When I run the build, the following error appears in the file generalized_projection_cuda.cu . There is a problem with the "keps" variable.
How to solve this problem?
Settings:
Windows 10
CUDA 11.2
Pytorch 1.12.1

identifier "geomlib::_NV_ANON_NAMESPACE::kEps" is undefined in device code	C:\Users\1\Downloads\interactive-hex-meshing-main\interactive-hex-meshing-main\out\build\x64-Debug\interactive-hex-meshing-main	C:\Users\1\Downloads\interactive-hex-meshing-main\interactive-hex-meshing-main\geomlib\geomlib\generalized_projection_cuda.cu	61

  [197/260] Linking CXX static library vkoo\vkoo.lib
  [198/260] Building NVCC (Device) object geomlib/geomlib/CMakeFiles/geomlib.dir/geomlib_generated_generalized_projection_cuda.cu.obj
  FAILED: geomlib/geomlib/CMakeFiles/geomlib.dir/geomlib_generated_generalized_projection_cuda.cu.obj
  cmd.exe /C "cd /D C:\Users\1\Downloads\interactive-hex-meshing-main\interactive-hex-meshing-main\out\build\x64-
  Debug\geomlib\geomlib\CMakeFiles\geomlib.dir && "C:\Program Files (x86)\Microsoft Visual
  Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -E make_directory
  C:/Users/1/Downloads/interactive-hex-meshing-main/interactive-hex-meshing-main/out/build/x64-
  Debug/geomlib/geomlib/CMakeFiles/geomlib.dir//. && "C:\Program Files (x86)\Microsoft Visual
  Studio\2019\Community\Common7\IDE\CommonExtensions\Microsoft\CMake\CMake\bin\cmake.exe" -D verbose:BOOL=OFF -D
  build_configuration:STRING=Debug -D generated_file:STRING=C:/Users/1/Downloads/interactive-hex-meshing-main/interactive-
  hex-meshing-main/out/build/x64-
  Debug/geomlib/geomlib/CMakeFiles/geomlib.dir//./geomlib_generated_generalized_projection_cuda.cu.obj -D
  generated_cubin_file:STRING=C:/Users/1/Downloads/interactive-hex-meshing-main/interactive-hex-meshing-main/out/build/x64-
  Debug/geomlib/geomlib/CMakeFiles/geomlib.dir//./geomlib_generated_generalized_projection_cuda.cu.obj.cubin.txt -P
  C:/Users/1/Downloads/interactive-hex-meshing-main/interactive-hex-meshing-main/out/build/x64-
  Debug/geomlib/geomlib/CMakeFiles/geomlib.dir//geomlib_generated_generalized_projection_cuda.cu.obj.Debug.cmake"
  generalized_projection_cuda.cu

Hi, thanks for your interest. The kEps is defined at https://github.com/lingxiaoli94/interactive-hex-meshing/blob/f6d3f2f5803bfc60f8325670b1878976983c2a6d/geomlib/geomlib/generalized_projection_cuda.cu#L15, in the very same file. I'm not sure why it is not picked up by your compiler. Could you try if any of the following would work:

Put const float kEps = 1e-8; outside the namespaces.
Use macro #define kEps 1e-8 instead of const float kEps = 1e-8;

@lingxiaoli94 thank you for the advice, they partially helped.
But the build still happens with errors, so what can you advise in this case? I was thinking of running your code on Ubuntu 20.04 ( as a last resort ) so that there would be no errors.
What can I try on Windows?


CustomLearningAdmin.aspx blank after provisioning

After receiving the provisioning is complete email, navigating to my custom learning url//SitePages/CustomLearningAdmin.aspx the page loads the title and search bar for a second and after just loads a blank page.

Thanx for this Michael.  Which browser are you working within?

Google Chrome: Version 73.0.3683.75 (Official Build) (64-bit)

I'm having the same issue, I've tried on the following browsers:
Chrome Version 72.0.3626.121 (Official Build) (64-bit)
Microsoft Edge 44.17763.1.0, Microsoft EdgeHTML 18.17763

I'm having this same issue for
Chrome Version 72.0.3626.121 (Official Build) (64-bit)
I am able to see content in Edge and IE, but these are not the browsers regularly used by my user-base.

#11

Duplicate of #11

We've been able to replicate this issue when the tenant is new and the app catalog was created but 30 minutes didn't elapse before trying to provision using the provisioning service.  For those reporting this issue, please confirm by retrying provisioning to your tenant and see if that corrects the issue.

Hi Julie, I have had this Tenant for 3 years. I just deleted the O365CL sharepoint site and also removed from deleted sites. I then redeployed and it was completed successfully, however I still have the same issue with the blank CustomLearningAdmin.aspx page.

Can you navigate to the CustomLearningViewer.aspx page, and does that work successfully (I'm going to assume no). If you just created the app catalog site collection that would be the same problem even if the tenant isn't new.  The issue is the webparts package cannot be properly deployed in a "new" app catalog site collection without giving it time to "percolate"

Same issue for the CustomLearningViewer.aspx page, is there something I can do the help with the "percolation"?

Basically your site was not provisioned properly.  The web parts are not registered properly and so they won't load in the page. If you've waited the 30 minutes since the app catalog was created and tried reprovisioning then I would say you have two options.

Remove the site collection and whatever app might have ended up in the app catalog and try again. If it still doesn't work I would submit an issue with pnp provisioning (https://github.com/SharePoint/sp-dev-docs/issues).

You can also get a copy of the sppkg file from this repo and manually try uploading that to your app catalog and see if that will fix the issue.

Hi Julie, so I finally got it to work here are the steps performed:

Removed the Custom Learning Site Collection
Removed the appcatalog site collection
Recreated the appcatalog site collection
Redeployed the custom learning package
I received an email stating :

Unfortunately, your request to provision"Custom learning for Office 365" template failed.
Unfortunately, your request to provision"Custom learning for Office 365" template failed.

Unfortunately, your request to provision"Custom learning for Office 365" template failed.

Here is the exception that occurred:Type = System.Net.WebException Message = The remote server returned an error: (404) Not Found. Source = System Status = ProtocolError Response = System.Net.HttpWebResponse Data = [0] = ClientRequest : Microsoft.SharePoint.Client.ClientRequestWrapper TargetSite = System.Net.WebResponse EndGetResponse(System.IAsyncResult) StackTrace = at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult) at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.SPWebRequestExecutor.d__0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientRequest.d__6.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientRequest.d__0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientRuntimeContext.d__0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientContext.d__4.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientContextExtensions.d__7.MoveNext() --- End of stack trace from previous location where exception was thrown --- at Microsoft.SharePoint.Client.ClientContextExtensions.d__7.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientContextExtensions.ExecuteQueryRetry(ClientRuntimeContext clientContext, Int32 retryCount, Int32 delay, String userAgent) at Microsoft.SharePoint.Client.NavigationExtensions.AddNavigationNode(Web web, String nodeTitle, Uri nodeUri, String parentNodeTitle, NavigationType navigationType, Boolean isExternal, Boolean asLastNode, String l1ParentNodeTitle) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionStructuralNavigationNodes(Web web, TokenParser parser, NavigationType navigationType, NavigationNodeCollection nodes, PnPMonitoredScope scope, String parentNodeTitle, String l1ParentNodeTitle) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionStructuralNavigation(Web web, StructuralNavigation structuralNavigation, TokenParser parser, Boolean currentNavigation, Boolean clearNavigation, PnPMonitoredScope scope) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionCurrentStructuralNavigation(Web web, StructuralNavigation structuralNavigation, TokenParser parser, Boolean clearNavigation, PnPMonitoredScope scope) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionObjects(Web web, ProvisioningTemplate template, TokenParser parser, ProvisioningTemplateApplyingInformation applyingInformation) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyRemoteTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation provisioningInfo, Boolean calledFromHierarchy, TokenParser tokenParser) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectHierarchySequenceSites.ProvisionObjects(Tenant tenant, ProvisioningHierarchy hierarchy, String sequenceId, TokenParser tokenParser, ProvisioningTemplateApplyingInformation applyingInformation) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyProvisioningHierarchy(Tenant tenant, ProvisioningHierarchy hierarchy, String sequenceId, ProvisioningTemplateApplyingInformation provisioningInfo) at Microsoft.SharePoint.Client.TenantExtensions.ApplyProvisionHierarchy(Tenant tenant, ProvisioningHierarchy hierarchy, String sequenceId, ProvisioningTemplateApplyingInformation applyingInformation) at SharePointPnP.ProvisioningApp.WebJob.ProvisioningFunction.d__0.MoveNext() in C:\github\sp-provisioning-service\SharePointPnP.ProvisioningApp\SharePointPnP.ProvisioningApp.WebJob\ProvisioningFunction.cs:line 337 HResult = -2146233079 | Here is the exception that occurred:Type = System.Net.WebException Message = The remote server returned an error: (404) Not Found. Source = System Status = ProtocolError Response = System.Net.HttpWebResponse Data = [0] = ClientRequest : Microsoft.SharePoint.Client.ClientRequestWrapper TargetSite = System.Net.WebResponse EndGetResponse(System.IAsyncResult) StackTrace = at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult) at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.SPWebRequestExecutor.d__0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientRequest.d__6.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientRequest.d__0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientRuntimeContext.d__0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientContext.d__4.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientContextExtensions.d__7.MoveNext() --- End of stack trace from previous location where exception was thrown --- at Microsoft.SharePoint.Client.ClientContextExtensions.d__7.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientContextExtensions.ExecuteQueryRetry(ClientRuntimeContext clientContext, Int32 retryCount, Int32 delay, String userAgent) at Microsoft.SharePoint.Client.NavigationExtensions.AddNavigationNode(Web web, String nodeTitle, Uri nodeUri, String parentNodeTitle, NavigationType navigationType, Boolean isExternal, Boolean asLastNode, String l1ParentNodeTitle) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionStructuralNavigationNodes(Web web, TokenParser parser, NavigationType navigationType, NavigationNodeCollection nodes, PnPMonitoredScope scope, String parentNodeTitle, String l1ParentNodeTitle) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionStructuralNavigation(Web web, StructuralNavigation structuralNavigation, TokenParser parser, Boolean currentNavigation, Boolean clearNavigation, PnPMonitoredScope scope) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionCurrentStructuralNavigation(Web web, StructuralNavigation structuralNavigation, TokenParser parser, Boolean clearNavigation, PnPMonitoredScope scope) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionObjects(Web web, ProvisioningTemplate template, TokenParser parser, ProvisioningTemplateApplyingInformation applyingInformation) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyRemoteTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation provisioningInfo, Boolean calledFromHierarchy, TokenParser tokenParser) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectHierarchySequenceSites.ProvisionObjects(Tenant tenant, ProvisioningHierarchy hierarchy, String sequenceId, TokenParser tokenParser, ProvisioningTemplateApplyingInformation applyingInformation) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyProvisioningHierarchy(Tenant tenant, ProvisioningHierarchy hierarchy, String sequenceId, ProvisioningTemplateApplyingInformation provisioningInfo) at Microsoft.SharePoint.Client.TenantExtensions.ApplyProvisionHierarchy(Tenant tenant, ProvisioningHierarchy hierarchy, String sequenceId, ProvisioningTemplateApplyingInformation applyingInformation) at SharePointPnP.ProvisioningApp.WebJob.ProvisioningFunction.d__0.MoveNext() in C:\github\sp-provisioning-service\SharePointPnP.ProvisioningApp\SharePointPnP.ProvisioningApp.WebJob\ProvisioningFunction.cs:line 337 HResult = -2146233079
Here is the exception that occurred:Type = System.Net.WebException Message = The remote server returned an error: (404) Not Found. Source = System Status = ProtocolError Response = System.Net.HttpWebResponse Data = [0] = ClientRequest : Microsoft.SharePoint.Client.ClientRequestWrapper TargetSite = System.Net.WebResponse EndGetResponse(System.IAsyncResult) StackTrace = at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult) at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean requiresSynchronization) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.SPWebRequestExecutor.d__0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientRequest.d__6.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientRequest.d__0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientRuntimeContext.d__0.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientContext.d__4.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientContextExtensions.d__7.MoveNext() --- End of stack trace from previous location where exception was thrown --- at Microsoft.SharePoint.Client.ClientContextExtensions.d__7.MoveNext() --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at Microsoft.SharePoint.Client.ClientContextExtensions.ExecuteQueryRetry(ClientRuntimeContext clientContext, Int32 retryCount, Int32 delay, String userAgent) at Microsoft.SharePoint.Client.NavigationExtensions.AddNavigationNode(Web web, String nodeTitle, Uri nodeUri, String parentNodeTitle, NavigationType navigationType, Boolean isExternal, Boolean asLastNode, String l1ParentNodeTitle) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionStructuralNavigationNodes(Web web, TokenParser parser, NavigationType navigationType, NavigationNodeCollection nodes, PnPMonitoredScope scope, String parentNodeTitle, String l1ParentNodeTitle) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionStructuralNavigation(Web web, StructuralNavigation structuralNavigation, TokenParser parser, Boolean currentNavigation, Boolean clearNavigation, PnPMonitoredScope scope) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionCurrentStructuralNavigation(Web web, StructuralNavigation structuralNavigation, TokenParser parser, Boolean clearNavigation, PnPMonitoredScope scope) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectNavigation.ProvisionObjects(Web web, ProvisioningTemplate template, TokenParser parser, ProvisioningTemplateApplyingInformation applyingInformation) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyRemoteTemplate(Web web, ProvisioningTemplate template, ProvisioningTemplateApplyingInformation provisioningInfo, Boolean calledFromHierarchy, TokenParser tokenParser) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.ObjectHierarchySequenceSites.ProvisionObjects(Tenant tenant, ProvisioningHierarchy hierarchy, String sequenceId, TokenParser tokenParser, ProvisioningTemplateApplyingInformation applyingInformation) at OfficeDevPnP.Core.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.ApplyProvisioningHierarchy(Tenant tenant, ProvisioningHierarchy hierarchy, String sequenceId, ProvisioningTemplateApplyingInformation provisioningInfo) at Microsoft.SharePoint.Client.TenantExtensions.ApplyProvisionHierarchy(Tenant tenant, ProvisioningHierarchy hierarchy, String sequenceId, ProvisioningTemplateApplyingInformation applyingInformation) at SharePointPnP.ProvisioningApp.WebJob.ProvisioningFunction.d__0.MoveNext() in C:\github\sp-provisioning-service\SharePointPnP.ProvisioningApp\SharePointPnP.ProvisioningApp.WebJob\ProvisioningFunction.cs:line 337 HResult = -2146233079

6 minutes later I received another email :

Your request to provision"Custom learning for Office 365" template is now completed!
Your request to provision"Custom learning for Office 365" template is now completed!

Your request to provision"Custom learning for Office 365" template is now completed!

I was able to browse the Custom Learning Site and browse the Admin Page.
Habib

I hit this issue as well. Checking the Chrome Developer Tools, I saw that an AJAX call was failing with net::err_blocked_by_client. I was able to resolve the issue by disabling AdBlock.

Followed @hmank steps and was able to get the package fully installed, but also required disabling the AdBlock Chrome extension on the site like @jwilkes260.


Run configs for Java users

Fixes getappmap/board#269
This PR helps Java users in VS Code.

When the extension starts, the latest version of the appmap Java agent JAR will get downloaded to $HOME/.appmap/java. This will happen regardless of the language of the project.

When a user opens a project, the extension will create a new launch config in .vscode/launch.json called Run with AppMap that will launch their application with the appmap agent. For this to work, the user must have the Extension Pack for Java installed. If they don't, then they will see this message when they attempt to use our launch configuration:

When a user opens a project, the extension will also check to see if they have the Test Runner for Java extension installed (it is part of the Extension Pack for Java). If the user does have it installed, then the extension will add a test config called Test with AppMap. If the user already has a test configuration, then when they attempt to run their tests, they will get a drop down menu:

Appmaps will be generated in tmp/appmap.

The extension will only add a launch config once. If the user deletes the launch config, then the extension will not regenerate one. This is also true of the test config.

How do you feel about $HOME/.appmap/lib ? Would be a bit more standard, especially if we add other language libraries and bin scripts.

How do you feel about $HOME/.appmap/lib ? Would be a bit more standard, especially if we add other language libraries and bin scripts.

I'm fine with $HOME/.appmap/lib but I think I'd want it to be $HOME/.appmap/lib/java so the symlink would be $HOME/.appmap/lib/java/latest instead of $HOME/.appmap/lib/latest because the latter is ambiguous.

How do you feel about $HOME/.appmap/lib ? Would be a bit more standard, especially if we add other language libraries and bin scripts.

I'm fine with $HOME/.appmap/lib but I think I'd want it to be $HOME/.appmap/lib/java so the symlink would be $HOME/.appmap/lib/java/latest instead of $HOME/.appmap/lib/latest because the latter is ambiguous.

Can you use appmap.jar as the latest version? Otherwise the VM configuration is going to be weird looking. A user will be expect the javaagent argument to be a JAR file name.

How do you feel about $HOME/.appmap/lib ? Would be a bit more standard, especially if we add other language libraries and bin scripts.

I'm fine with $HOME/.appmap/lib but I think I'd want it to be $HOME/.appmap/lib/java so the symlink would be $HOME/.appmap/lib/java/latest instead of $HOME/.appmap/lib/latest because the latter is ambiguous.

Can you use appmap.jar as the latest version? Otherwise the VM configuration is going to be weird looking. A user will be expect the javaagent argument to be a JAR file name.

Yeah, good point

:tada: This PR is included in version 0.86.0 :tada:
The release is available on:

v0.86.0
GitHub release

Your semantic-release bot :package::rocket:


generate doc set visibility to private

--visibility=VISIBILITY      Minimum visibility to document a method.
                             One of 'public', 'protected' (the default),
                             'private' or 'nodoc' (show everything)

Hmm, is there a good reason to make private methods be shown by default? I'm not necessarily against it if there is a good reason. But..
I am worried it may confuse new comers, they see a method in the docs then wonder why they can't use it.

I think it should maintain the integrity of the document.
ruby-doc site http://ruby-doc.org/core-2.3.0/Module.html  show Private Instance Methods now.
I want chm files become a good alternative when internet offline.

And, I think rdoc can't handle nodoc and private method in same way.
The end-users maybe never need nodoc methods;
but maybe want/need to use private class/instance methods.

@windwiny Do you think that the stdlib should include the private methods as well?

@Azolo , i think yes.
gem open require scanf .. ,   all is  stdlib Kernel module's Private Instance Methods,
those are very common method, if can not find them's document, that is not good.

Very good argument. I'm convinced.