node version stucked at the terminal even after nvm deactivate

I'm using nvm at my system.
If I run nvm deactivate and which node for confirming I'm using the system node, the node version keep stucked in my terminal. For exemple:
ayrton@localhost ~/workspace/whatever/something-ng                      [14:27:12]
> $                                                                ⬡ 0.12.7 [±develop]

Also, if I open a new terminal, this information keep stucked forever in my terminal:
ayrton@localhost ~/workspace/whatever/something-ng                      [14:30:07]
> $                                                                ⬡ 0.12.7

What theme and plugins are you using? And what OS is this on?

This appears to be by design, at least with the bureau and mira themes: the nvm_prompt_info function will always display the current node version if you have nvm installed for your user, even if no nvm is activated. The test it does is just whether ~/.nvm/nvm.sh exists, not whether nvm has activated anything.
Wouldn't be hard to change it to only output the version info if you have a non-default node activated, and maybe additional nvm info. Thoughts? /cc @isqua (original author of lib/nvm.zsh and bureau theme).

Try fix from pull request “Changed determination nvm in system #2312”

The new code in PR #2312 looks like it will still output the node version at every prompt, regardless of whether an nvm is active or not.

Have a look at PR #4338. With that, you can now distinguish the default node from NVM-managed nodes because it'll say "system" (or "none" if you don't have one installed) instead of the specific version number. Would that work for you?

I'm using bureau theme.
I will test the PRs, just a sec.


Use composer lpv:travis-lint as a pre-release check

An invalid .travis.yml should abort the release process.

Closed with db5fa059a4fdb55c124a48a57a869b695ad5f02e.


Field indicating where this client came from

where did i get this client from.

social media
friend (whom)
other

integrated into #106


CC: "Try out CC" docs

https://airtable.com/tblD3oZPLJgGhCmch/viwTBy1c8OnK6G6t4/recRsegigkmOja6ZN?blocks=hide
https://airtable.com/tblD3oZPLJgGhCmch/viwTBy1c8OnK6G6t4/recgBcKEmT14IkmyJ?blocks=hide
https://airtable.com/tblD3oZPLJgGhCmch/viwTBy1c8OnK6G6t4/recmaoqpaauLYlfbo?blocks=hide

Closing this as I think it's out of date


SyntaxError on authentication command

The simple code below throws a SyntaxError.
var fs = require('fs');

var googleCloudAuthFile = __dirname + '/google_cloud_auth.json';
fs.accessSync(googleCloudAuthFile, fs.F_OK);

var gcloud = require('gcloud')({
  projectId: 'project-id',
  keyFilename: googleCloudAuthFile
});

/vagrant/parse/city-chat-web/node_modules/readable-stream/lib/_stream_readable.js:117
};
 ^

SyntaxError: Unexpected token ;
    at exports.runInThisContext (vm.js:53:16)
    at Module._compile (module.js:387:25)
    at Object.Module._extensions..js (module.js:422:10)
    at Module.load (module.js:357:32)
    at Function.Module._load (module.js:314:12)
    at Module.require (module.js:367:17)
    at require (internal/module.js:16:19)
    at Object.<anonymous> (/vagrant/parse/city-chat-web/node_modules/readable-stream/readable.js:6:28)
    at Module._compile (module.js:413:34)
    at Object.Module._extensions..js (module.js:422:10)

I created a empty project with only gcloud-node installed and the authentication worked. It also successfully made a safeSearch request.
I think that the error in this issue can be an conflict with other package. The package of the real project are:
"dependencies": {
    "apn": "^1.7.5",
    "async": "^1.5.2",
    "express": "^4.13.4",
    "gcloud": "^0.36.0",
    "node-gcm": "^0.14.3",
    "parse-server": "^2.1.6",
    "request": "^2.69.0"
  }

The code from the first post worked for me. Is it possible to get a sample repo that I can clone to see the failure? The details of the Vagrant VM and how Node was installed might be relevant as well.

I've tried this, but the script still executes normally.

@leo-one try Node's stable release, v6.

I'm going to close this out since I can't reproduce. I don't believe this is an issue with our library, but something environment-specific. If you're still stuck, feel free to keep sharing, and I'll gladly help however I can.


Typeparam support for Query Pipeline

Fixed in branch: https://github.com/grainier/ballerina/tree/stream-desugar
Will get merged in #23237


touristbook.xml: Added a default list of Places

Tags are: attractions(11) , onestar(22), twostars(6), threestars(1), bookmarks(0).
Since we haven't implement the other optional fields, I removed them, hence only 3 fields per entry.
Do not merge yet!

Closed the PR as it has already been updated with a new issue and a full PR solution.


Listing all routes within a Mux

Is there any way to list all registered routes within a Mux? This is useful for debugging purposes to ensure everything as it seems, and I'd like to work on some route auto-generation tools. I understand if this isn't feasible, but it'd definitely be nice to have!

There's not really a great way of doing this, unfortunately. Goji accepts routes in multiple forms (i.e., the regex Handle(Func)?(C)?), and there's no type that these four types satisfy except interface{}.
If I may ask, why would being able to list routes be useful for route auto-generation? I'd like to support people auto-generating routes, but I don't quite understand why listing routes would be helpful for this.

Hello, this is an similar question I had on the other zenazn/goji repo .
Therefor I've made an package webdoc it is modified to use the goji.io repo .

@zenazn I sort of figured that might be the case. I should specify, what I was really hoping to do was auto-generate documentation for an API, similar to what @donseba has done in his library. It makes sense though that it might be difficult with so many unique potential entry points into the API.

Since inquiring about this, I've run into a case in which I was using sub-routing functionality with Goji improperly (not respecting that goji.Pat strips matched pieces before passing to sub-routers). I was forced to manually debug which routes exist by dumping variables from: https://github.com/goji/goji/blob/master/router_trie.go#L67. Could the router be leveraged to provide some sort of printable method & route tree?

Hello @derekdowling , I asked @zenazn rougly the same question here : question . and you can read his thoughts about it there.

Ahh, I see this conversation has already been had: https://github.com/zenazn/goji/issues/170 closing.

@derekdowling: I think I can write a middleware layer that would have helped you out there: you can attach it into your muxes and it can print out the pattern and handler that was matched, as well as the path and bound variables.
But sorry about the sub-router confusion: it's easily the most magic part of Goji, and might just be more confusion than it's worth.

Nope, it's definitely a good idea, it probably just requires some better documentation within Goji itself how to set that up. Where would you prefer an example? In the documentation or in the README? I can whip one up.


[release-3.15] Update net and crypto pkgs

Addresses CVE-2024-45338, CVE-2024-45337

/override "OLM-Tests / Run tests"

/override "Run tests"

/override "Run tests"


Add license file to the released grammar files

didn't I just merge this?

I don't remeber re-opening this :D, maybe a bug?


Refactor results pagination overall

The current method is a bit clunky.

Completed and merged into the 3.0 Branch.
Will proceed now to refactor endpoints.


Create a warning system

Should warning be a struct conforming to Node protocol or should messages be redirected to Program.io?

Warnings are redirected to IOProtocol::warning


Support Custom Query Class for Elastic Plugin

It would be nice, to have extension options for custom queries in NEST, to support elastic search plugins.
I want to include support for "IntraFind Elasticsearch Linguistic Plugin" to NEST.
The query type for this plugin is an extension of QueryStringQuery with some additional fields.
I extended QueryStringQuery and added this properties together with annotations to map json accordingly.
    public class IntrafindQueryString : QueryStringQuery
    {
        [PropertyName("search_type")]
        public string SearchType { get; set; }

        [PropertyName("expand_complete_query_with_thes")]
        public bool UseThesaurus { get; set; }

        [PropertyName("exact_boost")]
        public double ExactBoost { get; set; }
    }

But when the complete query is serialized the query name is serialized as "query_string" instead of "intrafind_query_string" because this is defined by JsonPropertyAttribute in IQueryContainer at property QueryString.
I tried to extend QueryContainer to add my own IntraFindQueryStringQuery Property.
But because InternalWrapInContainer in QueryBase is internal I can't write my custom Query into the correct filter property.
Could the method be change to protected? Or is there some better way to do this customization?
    public class IntrafindQueryContainer : QueryContainer
    {
        [PropertyName("intrafind_query_string")]
        public IntrafindQueryString IntrafindQueryString { get; set; }
    }

Hi @agentschmitt there is no way currently other then the RawQuery.
Similarly we have a long open request for aggregations as well: https://github.com/elastic/elasticsearch-net/issues/1016.
I think it would be fantastic if we offered a better story here but its not as straightforward as it might sound and might involve breaking changes making this a 7.x only change. We'll look into this again before the next major version.

Hey there,
I have a similar issue, but instead I was able to do what I understood OP tried to do by extending IScoreFunction and adding it into searchDescriptor phase as stated below.
_esClient.Search<Object>(s => s
    .Query(q => q
        .FunctionScore(fs => fs
            .Functions(new List<IScoreFunction>
            {
                new MyCustomPlugin(new MyCustomPluginFields(){
                    Foo = _foo,
                    Bar = _bar
                })
            })
        )
    )
);

Now, what I'm facing is that when I'm using NEST package from Nuget, it seems to not be able to serialize correctly my plugin statement by sending an empty Functions node to Elasticsearch, but then I've compiled NEST dlls locally and added them to my lab project, then the same code works, my query is generated with my plugin statement as it should.
That's an awkward behavior I've been trying to figure it out for a while but can't seem to understand what's going on. Any help would be highly appreciated.

@nikiz0r When we build a NuGet package we effectively shade our Newtonsoft.Json reference. Meaning we internalize the code and rewrite the types into a new namespace.
This explains the difference in behaviour. You most likely have something like this:
public class MyCustomPlugin : IScoreFunction
{
	public MyCustomPlugin(MyCustomPluginFields fields) => Plugin = fields;

	[JsonProperty("my-custom-plugin")]
	public MyCustomPluginFields Plugin { get; }
	public QueryContainer Filter { get; set ; }
	public double? Weight { get; set; }
}

public class MyCustomPluginFields
{
	public string Foo { get; set; }
	public string Bar { get; set; }
}

The following attribute [JsonProperty("my-custom-plugin")] will be the same Newtonsoft.Json.JsonPropertyAttribute type if you use a local compiled dll vs our production NuGet packages.
If you reference the NuGet package the one we look for internally is Nest.Json.JsonPropertyAttribute which is shaded (internal and not accessible).
So it won't be picked up any more. Luckily the fix is quite straight forward:
public class MyCustomPlugin : IScoreFunction
{
	public MyCustomPlugin(MyCustomPluginFields fields) => Plugin = fields;

	[DataMember(Name = "my-custom-plugin")]
	public MyCustomPluginFields Plugin { get; }
	public QueryContainer Filter { get; set ; }
	public double? Weight { get; set; }
}

public class MyCustomPluginFields
{
	public string Foo { get; set; }
	public string Bar { get; set; }
}

By switching to the `DataMemberAttribute which is part of the BCL you can mark the property for inclusion again.
Given this example:
var settings = new ConnectionSettings(new InMemoryConnection())
	.EnableDebugMode()
	.DefaultIndex("my-index");
var client = new ElasticClient(settings);
var response = client.Search<Object>(s => s
	.Query(q => q
		.FunctionScore(fs => fs
			.Functions(new List<IScoreFunction>
			{
				new MyCustomPlugin(new MyCustomPluginFields(){
					Foo = "elastic_foo",
					Bar = "elastic_bar"
				})
				{
					Weight = 1
				}
			})
		)
	)
);
Console.WriteLine(response.DebugInformation);

I can see the following JSON being emitted.
{
  "query": {
    "function_score": {
      "functions": [
        {
          "my-custom-plugin": {
            "foo": "elastic_foo",
            "bar": "elastic_bar"
          },
          "weight": 1.0
        }
      ]
    }
  }
}

Hope this helps!

Hi @Mpdreamz,
I've applied what you mentioned and it works just as I needed.
Thank you very much.

Closing due to age/inactivity. Please let us know if this issue is still a relevant priority for your usage?


Cannot add comments to pull requests by using keyboard only

Extension version: 0.60.0
VSCode Version: 1.76.2
OS: Windows 11 (where vscode is installed), Arch Linux (where vscode remote is being executed)

Hello,
First of all, sorry if this is not considered a bug. I am reporting that because, as I am not able to perform a task my peers are, I consider this a bug.
First of all, I am a visually impaired user, using Visual Studio code on Windows with the NVDA screen reader to access a remote computer running Arch Linux.
I have been using heavily this extension to enhance my productivity when performing code review. I can perform everything I need but adding comments to lines in the pull request.
Steps to Reproduce:

Find a pr
Press enter on the node or right arrow to expand.
Go past the pr toolbar.
Navigate pr files.
Press enter on one of the files.
From this point, I either navigate on the editor where the file is fully shown or press shift + f7 to navigate on the diffs.
In both editors I cannot find a way to insert comments on lines I need to. My siighted peers report that by clicking on the plus or less sign in front of the line they access this functionality, but I couldn't, even routing cursors, activating objects, using mouse keys, find anything which would allow me to access the comments editor.
I cannot comment on the accessibility of the comments editor because I haven't been able to reach it.

Thanks,
Marlon

@marlon-sousa We have a command "Comments: Add Comment to Current Selection", which you can run from the command palette and will open the comment widget where your cursor is.
If you use VS Code insiders, the command is broken there. I am making a fix now and it should be available next week.


New Firestore APL in SDK

This PR adds new APL - for Google Firestore

Add example to prove that it works

@krzysztofwolski added few improvements + example of usage https://github.com/saleor/saleor-app-template/pull/116

Closing for now, we can re-implement this if monorepo is there. This PR can still work as an example


Support for Instance Neural Radiance Field

Great work, thank you for the code release.
Do you plan on supporting Instance Neural Radiance Field work as well in this codebase in the future? Since it looks like both use a similar backbone and training style + data should be different for both. Thanks!

Thanks @lyclyc52. I will close this issue for now.


[ENG-4470] Reroute to new search

Ticket: ENG-4470
Feature flag: n/a

Purpose

reroute users to the new search page instead of registries discover

Summary of Changes

Change search behavior on registries landing page (osf.io/registries)

Screenshot(s)
This should lead users to the new search page with registries selected as the object-type filter (osf.io/registries)

Side Effects

None

QA Notes

This is for registries landing page (osf.io/registries) and not for the registries discover page (osf.io/registries/discover). The OSFRegistries discover page is being replaced by the new search page

Not going to get rid of the old discover page?

Nvm, didn't read well enough.

Yea, after we re-work the branded discover pages, we should be able to get rid of the old discover page (Assuming we implement it so we don't use templateName = 'discover'; for branded/discover/route.ts or anything like that)


README.md: Fix link to release archives

The releases page doesn't have anything listed:

Thanks, looks good.


TIKA-4271 Support tcpSocket probe

With the active gRPC Server development
(https://issues.apache.org/jira/browse/TIKA-4181), there is need to be able to deploy this Helm chart against the running gRPC service.
As the exposed gRPC service cannot use the HTTP probe, we must adapt the Helm chart to be configurable for a tcp socket
This change identifies tcp in the scheme variable of either probe and ensures the appropriate mechanism is used.
Existing HTTP(S) functionality continues to be supported.

Hi @bartek I'm very sorry about not seeing this earlier. I am trying to work to have more contributors able to commit to this repository. Thank you very much for the contribution.


ENH: Support NumPy array-like inputs to image filters

When a NumPy array-like is passed into Python snake_case interface to
filters, the array-like arguments or standard image keyword arguments
are converted into itk.Image views, and passed to the filter. All image
outputs are converted to NumPy ndarray's if array's were used as
inputs.
Addresses #1136

Well this is exciting!  I'm glad to see that this is such a small code change for you all.

Would it be possible also to handle anything that supports the buffer protocol?

Otherwise this looks great! Thanks for putting it together Matt 🙂

Thanks for the reviews!
Addressed the issue identified by @mrocklin

Would it be possible also to handle anything that supports the buffer protocol?

The intention is to support anything NumPy array-like, e.g. dask.array, with np.asarray:
https://github.com/InsightSoftwareConsortium/ITK/pull/1176/files#diff-7404aefb5771301dd2c2edfe74f17008R48
but, it sounds like this could / should change to np.coerce in the future following the discussion of NEP 30.

Woo!
On Wed, Aug 21, 2019, 6:31 PM Matt McCormick<EMAIL_ADDRESS>wrote:

Merged #1176 https://github.com/InsightSoftwareConsortium/ITK/pull/1176
into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/InsightSoftwareConsortium/ITK/pull/1176?email_source=notifications&email_token=AACKZTFEZN5N56SZHOPWXRLQFXT6JA5CNFSM4IMWGH4KYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTF5GFXA#event-2574934748,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACKZTHEPVPC5CV7JW5G62TQFXT6JANCNFSM4IMWGH4A
.


Image not showing in Team section

Issue Description
Hey, @varun-singhh The images on the sided cards are not showing and because of this, the page is not looking good. I want to add images to it. Please assign me this issue.
Steps to Reproduce (if applicable)

Add images to teams cards
[Step 2]
[Step 3]

Expected Behavior
[Describe what you expected to happen.]
Current Behavior
[Describe what actually happened.]
Possible Solution (optional)
[Provide suggestions or ideas for how to address this issue.]
Additional Context (optional)
[Add any other relevant information here, such as screenshots, related issues, or notes.]

please assign me this issue

This is not a code-level issue that contributors can fix. Thanks though for the issue

I thought it is a bug that's why i raised this issue. Anyway np!


Add virtualenv to dependencies

Needed for running OIDC tests, if nothing else

Er, don't merge this yet... there's something screwy here.  On ubuntu, virtualenv and python-virtualenv are two different packages.  Not sure what the difference is.

AFAICT, python-virtualenv should install the virtualenv program, so the problem in the OIDC test is some other config issue... closing...


feat(forge): Add fuzz tracing on fail and correct verbosity

Closes #332
Works by grabbed the failed counterexample bytes, enabling tracing, and doing a raw call. Tested against failing fuzz test in solmate

Example:

also:
Closes #370


Media type is not detected correctly when file is temporary

Hello,
I'm using the uploadMedia() helper to upload a file to Twitter from a user input (through HTML form).
The file is automatically uploaded to my server in the /tmp folder and I'm trying to upload this file to Twitter which has a .tmp extension, so the detection is not correct because of that:
https://github.com/PLhery/node-twitter-api-v2/blob/ff4c0f5335a360163e57a5761ee3f2eec8180c37/src/v1/media-helpers.v1.ts#L71-L80
I know I can provide the type in the options (and it's working fine), but if that's possible to detect the mime type from the .tmp file, that would be awesome! 😊

Thanks for the suggestion, I feel that it's not trivial to detect it from the content of the file, and this would make the library less light. I don't know if you have any opinion on this @alkihis?
Though i guess you could easily use https://github.com/sindresorhus/file-type/ yourself :)

(maybe we can also add an example on how to use it with file-type to the doc)

Hello, and thanks for the suggestion too :)
Yet a file-by-content detection is not implemented, and it seems not to be an easy task to do this.
We don't want to include a 3rd-party lib into this project, so we don't except to support this kind of detection (at least for now).
Of course, we can include an example with file-type here if needed :)
It's not explicitly specified in the doc (and it should be), but you can give a raw MIME type to the type argument of .uploadMedia.

Documentation and type correction for options.type available in https://github.com/PLhery/node-twitter-api-v2/releases/tag/1.5.0.


Deserialize optional values as Option

Adds support for optional value deserialization.
When deserializing an object, if a field is missing and that field is defined as an option, it is deserialized to None . Otherwise it is deserialized to Some val
This works for the primitive types as well as more complex types, as shown in the added unit tests.
Given the following type:
type name = {
  first : string;
  last : string option;
}
[@@deriving deserializer]

deserializing the following json:
{ "first": "Petri" }

will result in an object
{ first = "Petri", last = None}

This is also 100% from a JSON perspective
I have no idea if this same concept applies to other formats. If not, it would have to take a different approach

This also doesn't handle cases where a value is explicity set as null, that would require changes to specific deserializers.
having to decide what to do with something that's explicitly set as null is always a bit weird anyways

I think perhaps optionals should be serializer dependent, so that serializers that don't support it can return Error.unimplemented.  But it makes it somewhat trickier to implement

This is the other approach I tried: https://github.com/pjlast/serde.ml/pull/3/files
But I simply cannot get this to work with more complex optional fields
I'm open to suggestions, but otherwise this current solution is perhaps the way to go for now. It at least gives me all the functionality I want for JSON deserialization 😄
(optional serialization is a whole nother beast)

Closing in favour of https://github.com/leostera/serde.ml/pull/5 , which handles both null values as well as missing values


Remove pre-requesites installation

Update 6/20/24: Goal changed to eliminate the Sui pre-requesites.
Goals
(1) Should detect the Sui prerequesites missing and automatically (or offer) to the user to install them. Suibase CLI should automatically download, install and upgrade suibase-daemon binaries without user intervention.
(2) The installation of the VSCode extension should have the consequence of installing Suibase CLI and the Sui pre-requesites automatically. Ideally, that means to be fully up and running only by installing the extension!
Related code
VSCode extension for now just do diagnostic... not automated installation:

Excerpt from https://github.com/ChainMovers/suibase/blob/main/typescript/vscode-extension/src/BackendSync.ts
The CLI look for pre-requesites when attempting to build something:

Excerpt from https://github.com/ChainMovers/suibase/blob/main/scripts/common/__globals.sh

Hey @mario4tier ,
As I mentioned during our chat discussion, some of my users (kkomelin/sui-dapp-starter) complained about the complexity of the Sui prerequisites installation.
My suggestion was to develop OS-specific shell scripts to install everything in one line like so:
# Windows
iwr https://get.pnpm.io/install.ps1 -useb | iex
# Linux
wget -qO- https://get.pnpm.io/install.sh | sh -

ref https://pnpm.io/installation
And I thought about suggesting adding them to the main Sui docs/repo because I think it's a higher level problem.
I like the checks which Suibase has. It may be enough. What is the best place to add the scrips from your point of view?

Currently Sui docs offer one-liners for Mac:
brew install sui
# or
choco install sui

I don't know a person who would have brew or choco installed on Linux/Ubuntu. Native package managers here are apt and span. Maybe it's easier to suggest Sui adding a Span package for Linux/Ubuntu and that would eliminate the need of manual dependency install.

I see.
Seems that they are properly now favoring pre-compiled binaries, therefore eliminating the need for most pre-requesites.
IMHO, it is now becoming more urgent to also eliminate having Suibase depends on these Sui prerequesites (which are currently needed for building the Rust suibase-daemon).
===
For suibase, the binary installation should remain to be done with directly downloading "assets". Not brew/choco etc... the reasons are:

updates through brew "lag" the assets release, sometimes by many days. I don't know if better/worst with choco, but this is a part of the process we do not control.

suibase supports forcing an older assets version (needed when Mysten Labs break something in their devnet branch. This did happen twice already). Not sure how to easily manage that with brew/choco.

Thank you @mario4tier ,
Agree, let's leave streamlining Sui cli prerequisites installation to the Sui guys. Can suggest this improvement to them later with lower priority.
As for Suibase, it looks like if we could implement building suibase-daemon in the cloud for all OSs automatically, we would not need to ask users to install Sui prerequisites at all, which would be ideal from my point of view because it would allow to simplify  Suibase and VSCode Plugin checks significantly. Shall we consider this option?

As for Suibase, it looks like if we could implement building suibase-daemon in the cloud for all OSs automatically, we would not need to ask users to install Sui prerequisites at all, which would be ideal from my point of view because it would allow to simplify Suibase and VSCode Plugin checks significantly. Shall we consider this option?

Yes. I fully agree.
I plan to complete this by end of August (will be done with github actions, which already build the suibase-daemon for automated tests).
The Suibase assets will match the way Mysten Labs release their assets, that way we can re-use most of the already done bash script.

@mario4tier That's a good plan! Good luck with that! I have Lunux/Ubuntu if you need some alfa/beta testers. Can also try to setup Windows through VirtualBox.

Done. Suibase does not require Sui prerequisites anymore (notably, rust installation is not needed).
See https://suibase.io/how-to/install.html
===
Advanced users can still force compilation with precompiled_bin: false in suibase.yaml. In this case, Suibase will inform the user to install rustc (if not already done). See force to build locally in docs.

@mario4tier Man, it's insane! Thank you! It's a great UX improment. How did you achieve that?

At high level, Suibase identify the user platform/arch and download the assets from github (when an higher version is detected).
For sui (and walrus in the future), it downloads directly from Mysten Labs.
In the case of suibase-daemon (or any other open-source Rust tool that we choose to integrate later), a Cargo.toml version change in the Suibase repos trig an action (with an automated push) in another sui-binaries repos
After the builds, a last github job verify the assets are valid for all platform/arch before tagging it as "released".

The next step in better UX is that suibase-daemon will periodically check for updates and have some kind of "Release X available" displayed when doing, say, "devnet status".

Thanks for explaining @mario4tier ! That's a solid piece of work. Great


feat: adapt tactics to use optConfig instead of (config)?

Except for convert and convert_to, tactics now use the new optConfig configuration option syntax.
The problem with convert and convert_to is that optConfig isn't compatible with a term following it. This should eventually be possible, but it will depend on core changes.

bors d+

bors r+


Feat/link with icon

Related Ticket(s)
#163
Description
Carbon's link component with the ability to add an inline icon.
Changelog
New

LinkWithIcon component, tests and story

This is really nit picky, but the focus state isn't vertically centered around the link. The top margin is larger than the bottom margin, and ideally it would be equal.
Let me know if this isn't possible or if it's because of the line height. I would have thought the focus outline would be 22px high to match the line height

Can we merge as is since @kennylam isn't in, then we can report an issue for this?

Speaking with @oliviaflory , we will merge as-is, then create an issue based on the comment above.


Runtime Error: The Servant or Craft Essence is not contained

Hello
I've run into this issue multiple times in the past few days, please see attached screenshots.
It's always when selecting a support
screenshot1
screenshot2

I have a potential fix for this, give the pending merge at #222 a try

Please reply on the merge whether it has any issues or not

No reply from user, closing now.


KE-80: try new issue

comment after this

comment that matches

new issue comment without match

comment should match

double key title


Allow fetching code blocks from external source, display reference in code block title

Feature Request
Summary
I am writing a blog post which includes a lot of code blocks.
I would like to:

associate a file name or a URL with every code block (or with most of them)
ideally, place the source code in a separate file, potentially in a different repository

I tried searching for solutions, but was not able to find anything working.
Motivation
Such feature will allow to:

Clearly present files corresponding to code blocks to the reader
Make sure the code blocks are correct. It becomes possible to write tests and execute commands against the code block source code if it's separated from the page markdown body.

I believe this should be a very common problem for blog posts with heavy use of code.
Detailed Description
Perhaps, a code_block_source shortcode could be implemented, which could be used like this:
{{ code_block_source(source="https://my/file/url", language="python") }}

This shortcode would fetch the source contents, render it with syntax highlighting, and add a clickable source reference to the code block (I believe it can be shown before the copy button, or after the language title).
The source argument should accept both local paths and external URLs.

Hi!
Thanks for using tabi and for requesting this cool feature. I like the idea.
I've got a prototype shortcode which does exactly as you request.
Will update soon!

Amazing!
Thank you for writing Tabi :)
I am really enjoying it.

Thank you! I'm glad to hear :)
The feature is added in #305.
It's almost exactly what you requested; to place the code in a code block, you need to add the backticks and language manually. This is necessary so that Zola can handle the syntax highlighting.
The docs should clarify the usage.
Let me know whether this works for your or if you encounter any issues!
Cheers

Thanks!
Yep, I was able to make something similar, but without the source reference, too.
I think it's an important part of this feature, it would be great if you could figure it out :)

Adding the source to the codeblock is easy enough with CSS. The challenge is making the URL clickable without JavaScript—I don't think it's possible.
Do you think this feature is important enough to warrant loading an extra (small) JS file?
Would it be enough to show the path/URL, even if it's not clickable?

I think we can start with just displaying it (can it have a copy button?) and add the other part later.
Honestly, my CSS/HTML/JS knowledge is close to zero, so I don't know what exactly has to be done to enable it.

Adding a "copy" option to the source would require JS too.
The thing is I'm not a big fan of JavaScript. The feature you are requesting is impossible to do without it, though, as we can't modify the HTML of codeblocks; Zola auto-renders them.
That's why I was asking how important the feature was. It's a simple enough change, so I'll add it soon.

Turns out it's not as easy.

If we add the source to the code block (through the new shortcode), it gets rendered as code for the codeblock to show. That is, we can't just add a div or a span. I haven't found a way to escape this and actually render the HTML within the code block.
Creating the HTML manually would allow this, but then we'd lose the syntax highlighting of Zola.

The only solution I see right now is to create another shortcode like add_src_to_codeblock. This will take a single argument, the src. Then a JavaScript file would match each src added by the shortcode to the next codeblock it finds.
This means adding two shortcodes per codeblock with visible source, in the right order, with the same data. Plus, loading the JS file to handle the "joining" of data.

It works, though.

(The URL is clickable.)
I just need to write the docs.

Alright, great!
Do you think we should also have an option to override the displayed source path with something else?
For example, the desired file location could be displayed instead of the original source path, indicating that this code block contents should be placed in the desired path.

Do you think we should also have an option to override the displayed source path with something else?

The src for the codeblock and the src for the text (what's shown in the code block) are independent. So you would do:
{{ add_src_to_codeblock(src="https://example.com/whateverURL") }}

```.gitignore
{{ remote_text(src="https://example.com/the_actual_url.py") }}
```

It's done in #307.
Not a fan of the JavaScript + shortcode + shortcode setup, but I believe it's the best we can do given the constraints.
Check out the documentation and give it a go! Let me know whether it works for you or if you encounter any issues.
Cheers

Thanks, looking great!
The only small issue I found is with formatting with a long url and a small screen.

Thanks for letting me know! Should be fixed with f081a92f5939e141b6dbd7afe8ad1a9519d47f30


python3Packages.pypandoc: 1.7.5 -> 1.8

https://github.com/NicklasTegner/pypandoc/releases/tag/v1.8
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Please rebase this PR on top of the master branch
Auto-merging pkgs/development/python-modules/pypandoc/default.nix
CONFLICT (content): Merge conflict in pkgs/development/python-modules/pypandoc/default.nix
Automatic merge failed; fix conflicts and then commit the result.

Seems like someone else has updated pypandoc in the meantime.


Cow: Watch solarmate

Cow requests the watch of the watch_keyword solarmate. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

solarmate has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by Spevacus in Charcoal HQ. Reason: 'Superseded by this watch'


Chrome full screen tests fail

Only on my local.  Not sure why.  This is a placeholder while I research.

closed in 0.11.0 release


PS is not digitally signed; the URI scheme is not valid.

Running into a couple of issues while attempting to install this solution.
First when trying to run the PS1 file from the downloaded zip it gave me an error message stating ".ps1 is not digitally signed. The script will not execute on the system."
To get around this, I simply copied the content of the ps1 file into a text file and saved that as that as a ps1 file.
This allowed me to enter in the TargetSiteUrl and creds, however it then threw another error below:
"Exception occurred!
Exception Type: System.UriFormatException
Exception Message: Invalid URI: The URI scheme is not valid."
Any ideas as to why these exceptions are occurring?
Also, is the Team Site the only site collection definition this solution will work for?

Hi KSWALP,
this most likely is referring to the Responsive UI package which is one of things available from this repository. We have done some modifications for it, so it should be all good at this point, so will close up this issue. If this is still an issue for you, please reopen or submit a new issue with details. thx.


Errors with Mal.Mdk2.PbPackager

I've been chasing my tail trying to get this to work and I can't seem to decipher the instructions. By what I've read this should work.
Severity	Code	Description	Project	File	Line	Suppression State
Error		The command ""C:\Users\bradd.nuget\packages\mal.mdk2.pbpackager\2.0.12\build..\tools\mdk.exe" restore "C:\Users\bradd\source\repos\Test Script\Test Script\Test Script.csproj" " exited with code 3.	Test Script	C:\Users\bradd.nuget\packages\mal.mdk2.pbpackager\2.0.12\build\Mal.Mdk2.PbPackager.props	14
Build Message:
1>------ Rebuild All started: Project: Test Script, Configuration: Debug x64 ------
1>  Found local ini file: C:\Users\bradd\source\repos\Test Script\Test Script\Test Script.mdk.local.ini
1>  Found ini file: C:\Users\bradd\source\repos\Test Script\Test Script\Test Script.mdk.ini
1>  Successfully determined the binary path of Space Engineers: d:\steam\SteamApps\common\SpaceEngineers\Bin64
1>  Loading Space Engineers assemblies from d:\steam\SteamApps\common\SpaceEngineers\Bin64
Restored C:\Users\bradd\source\repos\Test Script\Test Script\Test Script.csproj (in 261 ms).
1>  The system cannot find the path specified.
1>C:\Users\bradd.nuget\packages\mal.mdk2.pbpackager\2.0.12\build\Mal.Mdk2.PbPackager.props(14,9): error MSB3073: The command ""C:\Users\bradd.nuget\packages\mal.mdk2.pbpackager\2.0.12\build..\tools\mdk.exe" restore "C:\Users\bradd\source\repos\Test Script\Test Script\Test Script.csproj" -interactive" exited with code 3.
========== Rebuild All: 0 succeeded, 1 failed, 0 skipped ==========
========== Rebuild completed at 11:13 PM and took 00.458 seconds ==========

Yep, I broke the latest version, sorry, I am on it

Fixed (?) in v.2.0.13

Just test with v.2.0.13. issues different this time, heres the new messages.
Severity	Code	Description	Project	File	Line	Suppression State
Error		The command ""C:\Users\bradd.nuget\packages\mal.mdk2.pbpackager\2.0.13\build..\tools\mdk.exe" pack "C:\Users\bradd\source\repos\Troubleshoot\Troubleshoot\Troubleshoot.csproj"  -configuration Debug -interactive" exited with code -1.	Troubleshoot	C:\Users\bradd.nuget\packages\mal.mdk2.pbpackager\2.0.13\build\Mal.Mdk2.PbPackager.props	18
1>------ Rebuild All started: Project: Troubleshoot, Configuration: Debug x64 ------
Restored C:\Users\bradd\source\repos\Troubleshoot\Troubleshoot\Troubleshoot.csproj (in 33 ms).
1>  MDK is restoring ingame script project: Troubleshoot
1>  Troubleshoot -> C:\Users\bradd\source\repos\Troubleshoot\Troubleshoot\bin\Troubleshoot.exe
1>  Compilation failed with errors.
1>  /platform:anycpu32bitpreferred can only be used with /t:exe, /t:winexe and /t:appcontainerexe
1>C:\Users\bradd.nuget\packages\mal.mdk2.pbpackager\2.0.13\build\Mal.Mdk2.PbPackager.props(18,9): error MSB3073: The command ""C:\Users\bradd.nuget\packages\mal.mdk2.pbpackager\2.0.13\build..\tools\mdk.exe" pack "C:\Users\bradd\source\repos\Troubleshoot\Troubleshoot\Troubleshoot.csproj"  -configuration Debug -interactive" exited with code -1.

I... don't have an answer for that one. It works just fine for me. Could you please zip up your project?


VS2022 create project wizard not working or VS2022 integration issue

turkeyman reported this on 2023-08-30T07:19:20Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=24119
CC List

r.sagitario

Description
Fresh installation of VS2022 Community
Fresh installation of VisualD 1.4.0-beta
File > New -> Project
Choose "D/VC++ based Windows Application"
Configure a default console app and create the project
Press build, and receive this error:
1>C:\Program Files (x86)\VisualD\msbuild\dcompile.targets(192,5): error MSB4062: The "dbuild.CompileD" task could not be loaded from the assembly C:\Program Files (x86)\VisualD\msbuild\dbuild.17.5.dll. Could not load file or assembly 'Microsoft.Build.CPPTasks.Common, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. Confirm that the  declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask.

added support for VS 17.5 to 17.9 in https://github.com/dlang/visuald/releases/tag/v1.4.0-beta2


Added stateful processing restore state machine to stmgr.

Unittests are on their way for this pr, but I wanted to put this out so that folks can start reviewing the functionality.

Added the first set of unit tests. More coming soon.

Have added more tests

@billonahill I have updated the description of the pr and given specific pointer wrt original design doc.

@billonahill @huijunw Addressed your comments. Please take a look again.
Thanks!


Remove EXIF data from file

Problem
When images are taken with a phone or digital camera, EXIF data is attached to the image file which specifies image orientation. An image taken with a phone in "portrait" view, will actually create a landscape image, but the EXIF data tells the phone to view it as a portrait image. This was messing up the cropping and preview logic because it is heavily based on an images raw width and height, which was being flipped flopped on phones when the image was displayed. This caused the squishy image problem.
Changes - Fixes #3909
Please see the comments in the code for more information, but basically, i'm removing the EXIF data on images entirely, allowing us to work with the RAW image on the front end. But since users can rotate images, if a portrait image appears landscape to the user, they can just rotate it back it's correct orientation.
@DoSomething/front-end
/cc @mikefantini

Looks good to me. I don't think this is a bad solution at all. :+1:

Awesome-sauce :dancer: Nice work! :+1:


legacy: Compatibility fixes for recent Linux

Most importantly, this PR restores functionality on recent Linux kernels by using the bundled libuvc instead of v4l2.
I'm not entirely sure when exactly the breakage occurred, but it must have been some changes to the uvcvideo driver between Linux 4.15 and 4.19. Unfortunately I can't test for the versions in between right now, but using libuvc from 4.16 onward should be fine.

I think something is wrong with the OSX travis config. Looks like something is going wrong in xcode internally there...

@vmatare , thanks  for the PR - we'll review it.
The incompatible changes in UVC subsystem that you've encountered with 4.16 are ,imho, the introduction of the metadata stream node, which made each UVC device to be duplicated in user space (i.e. instead of dev/video0 dev/video1 you have dev/video0 dev/video1 dev/video2 dev/video3.

@ev-mp, yes, I'd also prefer fixing the v4l2 backend since the libuvc backend cannot switch the device off cleanly. I've tried playing around with the subdevice indexing logic. Essentially I tried to increase the index of the depth/infrared stream from 1 to 2, but so far I haven't been able to get that to work since the whole logic around that is complicated as hell. Any guidance would be greatly appreciated ;-)

YES, I think I have gotten the depth stream to work with the v4l2 backend by increasing its index to 3, but now the infrared stream doesn't work. Check out the updated branch. Maybe the infrared stream has a different index now? So far I'm doing trial & error, any way to identify these indices?

The stream indexes are arranged in pairs [even:video_stream/odd:metadata_stream]. In case of R200 with Depth, Ir and Color you should be able to receive video on devices 0,2,4.
To differentiate video from meta streams there is UVC flag V4L2_CAP_META_CAPTURE added for the metadata-only streams.
In case you decide to port/retrofit 4.16+ support to Librealsense1, the I'd recommend to start with looking into the work that was done to introduce this functionality in Librealsense2

Took another approach here: https://github.com/IntelRealSense/librealsense/pull/3929

Closing because it's superseded by #3929.


No Mac workload binary on deployment page

When following directions on pages such as https://www.cockroachlabs.com/docs/v2.1/deploy-cockroachdb-on-aws-insecure.html#step-8-run-a-sample-workload, the workload binary is Linux specific and doesn't work on Macs.
To fix it we could either add a Mac binary or change the directions to use the workload builtin to Cockroach.

We should update the page to use the cockroach workload run tpcc command instead. I'll handle this in conjunction with https://github.com/cockroachdb/docs/issues/3686.

Closing in favor of https://github.com/cockroachdb/docs/issues/5359.


Add missing property shared to Channel

Added with v5.32.0 in mattermost/mattermost-server@6a3bc50
resolves #411

@mkobel I'm sorry about the lack of activity. I'll merge this PR soon after CI passes. (Other PRs you provided also will be merged after CI passes.)
Thank you for your contributions!


add rm

This pr adds a few things, mainly a port of the rm command.  I additionally introduced the bind_command macro for easily binding boxed commands to the engine instance and put stubs in for the open and save commands.  Please please please look over this carefully as it's a pretty critical command and I haven't been sleeping well.  I haven't been able to fully ditch value streams in the helper method's return, as flat_map seems to want an implementation that i haven't been able to figure out yet.  I would love some help smoothing the edges, but hopefully the base looks solid enough.

I'm not sure why this is failing.  I moved the closure into a variable just to grab the type class in my text editor, but moved it back in the last commit.  I'll take a deeper look; sorry if I'm missing something,

@xiuxiu62 looks like you need to run cargo fmt on the code. The CI will check that all the code uses the standard Rust formatting.

Looks good!


Deploy dask.distributed setup with ipython.parallel view

Given an IPython parallel Client or view (not sure which is best) it would be nice to spin up a dask.distributed Scheduler/Worker system.  This lets us hijack some of the work the Jupyter team has done integrating with various job management systems (pbs, ssh, etc..) and their surrounding infrastructure.
This should be relatively straightforward with a moderate understanding of dask.distributed and serves as a good opportunity to get ones feet wet (it also puts a second pair of eyes on this module.)
We want to set up one Scheduler and then a bunch of Workers that all know where the scheduler lives.  Finally we want to return a dask.distributed.Client to the user pointing to that same scheduler.
Example
>>> from IPython.parallel import Client  # note that this is a different Client object
>>> view = Client(...)[:]

>>> from dask.distributed import from_ipython_parallel  # or some better name
>>> c = from_ipython_parallel(view)

>>> c.get({'a': 1, 'b': (lambda x: x + 1, 'a'}, 'b')
2

It would also be great to get feedback (or just changes) to improve the experience of interacting with dask.distributed.  Presumably there are also bugs lying around.

will be closed by #208


Topological sort has a significant performance penalty

I'm using a Graph of type graph.Graph[Resource, Resource] with a hash function that returns the original pointer to build a directed, acylic resource graph. Due to the nature of current implementation, each graph node contains exactly one edge to its parent resource, all the way to a root node.
With 4043 total resources (so v=4043, e=4042 as the root node does not connect to any parent), running inside a Docker on a M2 Pro mac, a Topological Sort using graph.TopologicalSort takes >1.5s (1.876445292s as a typical value), with a significant memory usage of >200M. Upon profiling the heap with pprof, the following is yield:
Memory snapshot for a single request that requires Topological Sorting:
$ go tool pprof mem.pprof
      flat  flat%   sum%        cum   cum%
  332.92MB 96.06% 96.06%   336.85MB 97.19%  github.com/dominikbraun/graph.TopologicalSort[go.shape.struct { Domain string; Instance int64 },go.shape.struct { Domain string; Instance int64 }]

I thought the excessive memory usage might have been caused by the fact that I'm using a struct and basically no hashing (which is, of course, more memory intensive); so I changed to graph.Graph[*Resource, *Resource]. While the below snapshot did not capture the exact memory usage at the moment, the memory allocation from the start of the program after a few request is:
$ go tool pprof --alloc_space mem.pprof
> top1
      flat  flat%   sum%        cum   cum%
  339.98GB 87.45% 87.45%   342.07GB 87.99%  github.com/dominikbraun/graph.TopologicalSort[go.shape.*go.shape.struct { Domain string; Instance int64 },go.shape.*uint8]

...well exceeding 300GB.
Meanwhile, a naive implementation by keeping track of inEdgesCount for each vertex (using adjacentMap provided by graph) takes <20ms, with negligible memory footprint.
Using graph (as "github.com/dominikbraun/graph") v0.23.0.

Thanks for reporting this!


[Request] Support for Sticky Keys

I wasn't able to find this feature. I just want an ability to use Sticky keys like Shift, Ctrl, etc. By sticky keys, I mean,that I just want to use shortcuts like Ctrl+A, etc.

They should just work.  Or do you mean to use Ctrl , A (meaning each key separately) as = to Ctr + A?  That option, AFAICT, doesn't currently exist.


Accessibility issue with hashHistory based links

Description of Issue
We're currently using react-routers hashHistory feature. This results in links with hrefs formatted with a hash: http://engineering.cerner.com/terra-core/#/site/arrange
When running HTML CodeSniffer it reports the following type of errors for all the navigational react-router links.

This link points to a named anchor "/site/arrange" within the document, but no anchor exists with that name.

Additional Details (optional)
This should be easy to resolve by replacing react-router's hashHistory module with react-router's browserHistory module. We'll want to test this change on our supported browsers/devices however, support for the browser history API is pretty wide these days: http://caniuse.com/#search=history
Expected Outcomes

Site links don't create accessibility issues

If this turns out to be a lot of work, we might want to just do the story to upgrade to react-router v4


Npm install showing error

While typing the command (npm install) in the terminal, I got the following error.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/next
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/react-static-tweets
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/abhi/.npm/eresolve-report.txt for a full report.

npm ERR!      /Users/abhi/.npm/_logs/2021-11-24T16_49_58_219Z-debug.log

I even tried with the following commands but didn't work
npm i --legacy-peer-deps
npm install --force

I have same error

Using npm -g install<EMAIL_ADDRESS>as suggested fixed the problem.

use yarn rather than npm

This has been fixed in the latest version. Lots of dependency issues should be resolved in react-notion-x v6 as we're  now bundling the package before publishing.


Insert into multiple tables?

Hello, I can't figure out the recommended way using this module to insert into multiple tables at once.
Eg. I have a chat msg from a user, I want to insert into the users table data about the user, and the msg into the msgs table at the same time.
Eg.
START TRANSACTION;
INSERT INTO table1 VALUES ('1','2','3');
INSERT INTO table2 VALUES ('bob','smith');
COMMIT;

Thanks!
Roo

Hi, json-sql api translates one json query to one sql query.
Assumes that other things will be done outside of this module.


Suppressions are not respected

We're using the Sarif Viewer Build Tab within our Azure DevOps build pipeline.
In our SARIF file, we have some errors that we suppressed as they only exist in unit tests and are not true vulnerabilities. This leads to the following output in the SARIF file:
      "suppressions" : [ {
        "kind" : "inSource"
      } ]

However, the issue still shows up on the Scans tab, which indicates that the suppression isn't being respected.
Please let me know if this issue should instead be filed under the Sarif Viewer Build Tab GitHub project or elsewhere.

@jeffersonking This is fixed now, right?


Taged Gadts

This pull request implements the tagged solution of Gadts. The next step is to properly translate the functions that mention it.
The only change in infrastructure is that I extracted the Constructor to another file to avoid circularity between Type and TypeDefinition (via Type -> Tags -> Constructor -> TypeDefinition).
I also decided to handle building and printing the decoder in Structure instead of TypeDefinition because otherwise I would have to deal with Exp in Type, and I don't think that would make much sense. Following the same strategy, I think it would be beneficial to extract dealing with RecordSkeleton to Structure in the future. Adding structures in Type makes the code harder to maintain becauseInductive is always doing a lot more work than just messing around with the datatypes per se.
Also notice that we have have a dependently typed language now by having Type in Exp :)

I expect the tests to break because I don't think it makes sense to update them just yet.

Wondering if this PR can be closed, as the other one got merged (doing some PR cleaning).

I didn't even remember this exist honestly


System sfx + dynamic import

I can't work out from the docs if SFX can be made to support System.import()?
e.g have main.sfx.js which then uses System.import("some/file/in/a/bundle") to load in additional features, which are also bundled. It'd have to also include the config with bundles: {....
So that means all that's in the HTML is:
<script async src="mainWithSystemJs.sfx.js"></script>

This loads the main bundle. When that does some client side routing, it loads the System.import()s the feature (triggering a bundle load) required.

This is not currently possible, no. SFX bundles should be thought of like running browserify or Rollup - they don't provide any loader interface.

Okay, thanks! I guess concat'ing the main SystemJS file to the bundle would achieve a similar result.

Not quite so. Unless you'd wrap it all in a iife, prepending the main script would affect the global instance,  therefore it could potentially alter the expected behavior of other scripts. Like... If you did so to include a backbone bundle, it would potentially mess with your own jquery version.
Self executing bundles are completely encapsulated.


apiserver not able to resolve service broker internal address

After the successful deployment, when I try to update policy, I am seeing this error in apiserver logs
source":"autoscaler:apiserver","text":"Error occurred during check binding ","log_level":"error","data":{"appId":"f898e6fd-94f5-4eae-825a-ddbb73cd2a4a","error":{"code":"ENOTFOUND","errno":"ENOTFOUND","syscall":"getaddrinfo","hostname":"servicebroker.service.cf.internal","host":"servicebroker.service.cf.internal","port":"6107"}}}

I have checked everything but I am not getting why this url servicebroker.service.cf.internal not getting resolved to service broker ip address. Please give me some suggestions to resolve this.

@Nishanksingla  Do you use the latest code of app-autoscaler-release (https://github.com/cloudfoundry-incubator/app-autoscaler-release)?

I think so. I cloned the repo on 15th March. Service broker is able to resolve the postgres address and is able to connect to it. I don't understand why can't apiserver resolve servicebroker internal address.
Can you please provide me some updates?
Will using the latest code resolve this issue?

@Nishanksingla After cloning app-autoscaler-release, did you update the app-autoscaler in app-autoscaler-release? If so, it may cause the problem. So could you just use develop or master branch of app-autoscaler-release without updating its submodule :app-autoscaler to check whether your issue is still there?

Hi @qibobo
I made it work. What was missing in the initial templates and the template you sent me was consul agent service check for ServiceBroker that's why API server was not able to resolve the servicebroker internal name to its IP.
Can you please explain the terms of policy API? What does stat_window_secs  and breach_duration_secs mean? How do they work?

stat_window_secs is the time interval we aggregate metrics from application instances. Setting this value longer will smooth the metric values, it may reduce impact on potential noisy data points, but this may also cause insensitivity....
breach_duration_secs defines the time period that scaling will be triggered if all the data points during this time period always breach the scaling rule.
For example,  if you set memory usage threshold to be 70%, breach_duration_secs = 120 means the scaling out will happen when memory usage >= 70% for 120 seconds.

stat_window_secs is used to control how to aggregate metrics.
stat_window_secs = 300 means the  metric of an app will be the average of the metrics from each application instance in the past 300 seconds.

closed for no further updates.


Fix x-ui-guardian-bundle to use the graphql-ws methods

Hi,
After updating ui-apollo-bundle to use graphql-ws it seems that a dependent package using the bundle used the subscription client and needed an update too.
In graphql-ws the close method is replaced by the terminate method.
Here is how to fix the problem
index 18d40fd..229cc24 100644
---<EMAIL_ADDRESS>+++<EMAIL_ADDRESS>@@ -67,7 +67,7 @@ export class XUIGuardianBundle extends Bundle<IXUIGuardianBundleConfigType> {

     if (!subscriptionClient) return;

-    subscriptionClient.close();
+    subscriptionClient.terminate()
   }

   async prepare() {

What is strange is that the CI/CD did not report the error. Because there was indeed a typescript error inside the package when I opened the code...
Are you sure the CI/CD runs all the checks in pull requests ?

made it to only run tests on affected packages. (patched x-ui-guardian)
but what you're saying raises a fair point.
i believe, the issue was rather with apollo-bundle update, as it should offer backwards compatibility, it was hard to spot, I think the minimum we can do is add in a pipeline to at least compile all the packages, not necessarily run tests.


fix: use noop metrics provider for otel

What this PR does / why we need it
Uses the noop metrics provider to prevent memory leaks.

Jira ID
DT-2744

Notes for your reviewers

Yeah, I really thought it would be noop by default, but apparently otel was just holding on to metrics waiting to send them somewhere.

Pull Request Test Coverage Report for Build 66e83549-83db-489f-af33-6bdba9e917e4

3 of 3 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 55.556%

Totals

Change from base Build b15a0c77-03fd-4b1f-88c8-9424d8e169a4:
0.03%

Covered Lines:
2245

Relevant Lines:
4041

💛  - Coveralls


feat(metadata): change embed icon to match main website

Summary

Currently, the embeds for the main website and the guide website are inconsistent.

Information

[ ] This PR fixes an issue.
[x] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed).
[ ] This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

[x] I have searched the open pull requests for duplicates.
[x] If code changes were made then they have been tested.

[x] I have updated the documentation to reflect the changes.

[x] If type: ignore comments were used, a comment is also left explaining why.
[ ] I have updated the changelog to include these changes.

https://discord.com/developers/embeds?url=https%253A%252F%252Fdeploy-preview-465--pycord.netlify.app%252F


Job left over from aborted workflow

I noticed
https://cms-gwmsmon.cern.ch/prodview/fabozzi_RVCMSSW_9_0_0GluGluHToZZTo4L_M125_Pow_py8_Evt_13__PU25_reHLTcc7_170327_230233_6021
https://cmsweb.cern.ch/reqmgr2/fetch?rid=fabozzi_RVCMSSW_9_0_0GluGluHToZZTo4L_M125_Pow_py8_Evt_13__PU25_reHLTcc7_170327_230233_6021
which is aborted-archived. From the relval agent. Is that agent fully up to date on the release version ?

Agent is upto date but transition between aborted and aborted-completed happened too fast (faster than the polling cycle). agent misses the update.
 If that is OK with you.

I kill those jobs without permission. 😄

I just condor_rm all jobs from
https://cms-gwmsmon.cern.ch/prodview/prozober_ACDC0_task_HCA-PhaseIFall16GS-00007__v1_T_170331_105036_8804
we ought to get aborted workflows fully under control.

https://cmsweb.cern.ch/reqmgr2/fetch?rid=fabozzi_RVCMSSW_9_0_0ZEE_13__reHLTcc7_170327_174211_5619
https://cms-gwmsmon.cern.ch/prodview/fabozzi_RVCMSSW_9_0_0QCD_Pt_3000_3500_13__reHLTcc7_170327_174200_6576
https://cms-gwmsmon.cern.ch/prodview/fabozzi_RVCMSSW_9_0_0TTbar_13__reHLTcc7_170327_174237_7732
and many others from the relval agent

https://cmsweb.cern.ch/reqmgr2/fetch?rid=pdmvserv_task_JME-PhaseIFall16GS-00006__v1_T_170309_141735_7301 has spewed thousands of jobs while it has been aborted for 15 days.
https://cms-gwmsmon.cern.ch/prodview/pdmvserv_task_JME-PhaseIFall16GS-00006__v1_T_170309_141735_7301

These are the moment I'm totally against of having more agents than needed in production.
gwmsmon doesn't give me the agents running these jobs (and it's archived, so no longer in wmstats), so there we go in agent by agent to locally abort it.

Hmm, I found only 4 jobs on vocms0311, though gwmsmon says PIC has almost 2k jobs pending?!?

I did condor_rm emergency those from 311 because I am baby sitting PIC in running through a backlog.
I hope that there will be no more jobs fro aborted at next agent release, so that noone has to go through the pain full process.
gwmsmon does tell the agent, when clicking on "show debug information"

Sorry, Jean-Roch. The patch is ready. We can patch the current production agents.

@vlimant All the production agents are patched. Please let me know if this happens again.

Seangchan, have you patched only agents up and running? Or you also pushed it into draining and sleeping/ready agents? According to the twiki, some agents are missing it.

I added only active agents (meaning) where I can see in wmstats including draining agent. For the complete list, twiki page is updated.


The RobotEyes library would may to use different folders for baseline image.

Let our test asset contains several test suites. By some reason we need to use separeted baseline images folder for each suite.
We know the folder name should be set to IMAGES_DIR variable.
But when the report generator script start to create visualReport we get exception because IMAGES_DIR variable contains last set value from the last test suite and previous folder names can not be found.
Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/usr/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "........./python3.6/site-packages/RobotEyes/report_generator.py", line 74, in generate_report
    folder_name)
  File "........./python3.6/site-packages/RobotEyes/report_generator.py", line 227, in make_test_table
    for filename in os.listdir(baseline_folder + os.path.sep + folder_name):
FileNotFoundError: [Errno 2] No such file or directory: 'visual_images_original/Test_Case_Name_From_First_Suites'

I image that it can be difficult to implement. It can need to creation of visualReport file during test running.

Im not actively working on this library as I'm busy working on other projects in my free time. If you can work on an implementation, I would be happy to take a look at it


Any notification should come immediately. A user should not have to refresh or kill the app for the notification to land within the bell icon area.

a) Level 2> Recovery Key 1 being backed up on personal device 1.

Verified this issue on dev app v2.0.75(469)


Remove unused variables for using DJ-Registry

The commit 4c1a1fc400d00ad4be963c902d9a92325804d08e introduced the usage
of DJ-Registry so we do not need the corresponding variables in the
configuration file.

Pushed extra files for development environment. Created another PR instead https://github.com/pycontw/pycon.tw/pull/769


Deprecate RuntimeConfig, update code to use new builder style

Which issue does this PR close?
Follow on to

https://github.com/apache/datafusion/issues/12156

Rationale for this change
I hit this while working on https://github.com/apache/datafusion/pull/13424 and was a bit confused
@devanbenz  added a nice builder style API to the RuntimeEnv as well as some backwards compatibility APIs which is great
However all the examples and code still use the old pattern, which means we aren't getting the benefit of the new API
What changes are included in this PR?
Changes:

Make RuntimeConfig deprecated and update all examples to use builder style
Add docs / examples to help migration
Clean up some other uses of state creation

Are these changes tested?
By existing tests and new doc tests
Are there any user-facing changes?
Some APIs are now deprecated, but no APIs are removed

Thanks again for the review @comphead


Data-structure: Section-entities are not connected to Program-entities

When there are multiple programs, with different sections as their content (i.e. the "test"-program and the "demo"-program), the query-endpoints won't group by program and just return all available sections.
To Reproduce

Seed the "dev" program
Use GET /programs endpoint
It lists all sections for both programs

{
  "programs": [
    {
      "name": "test",
      "id": "1a99b002-aac2-4c31-807b-8fa2aff6ed96",
      "narrativeReportTemplate": "...",
      "sectionIds": [
        "1f976156-a696-4762-89ae-6a3f603a4696",
        "b0506dec-a7d2-41c2-84dd-1ee49a47e3b9",
        "67714ccf-55ef-403d-b9b1-0f181310333f",
        "249ba016-a7c4-42b4-9bd0-c9ad17b525fb",
        "949a02db-5bf2-4526-b242-4edcd6269176",
        "cdc89597-0136-45e7-b102-feae6233d072",
        "5a55a3c7-7ac0-4cbd-8d52-b66b0176b612"
      ]
    },
    {
      "name": "demo",
      "id": "570773d5-d7d1-4bae-9b88-71f9bbf6653c",
      "narrativeReportTemplate": "...",
      "sectionIds": [
        "1f976156-a696-4762-89ae-6a3f603a4696",
        "b0506dec-a7d2-41c2-84dd-1ee49a47e3b9",
        "67714ccf-55ef-403d-b9b1-0f181310333f",
        "249ba016-a7c4-42b4-9bd0-c9ad17b525fb",
        "949a02db-5bf2-4526-b242-4edcd6269176",
        "cdc89597-0136-45e7-b102-feae6233d072",
        "5a55a3c7-7ac0-4cbd-8d52-b66b0176b612"
      ]
    }
  ],
  "count": 2
}

This is also the case for the GET [/programs/{programId}/questions-endpoint.
That contains just all questions, regardless of programId it seems.
Additional context
When I look at the different Entity-files, I also can't find a connection between the ProgramEntity and the SectionEntity...
Only between SubSections and Sections (and Programs and Users).

This is only relevant for when the concept of "a fixed list of questions" is not applicable anymore. ;)
For now, to simplify, I've removed the confusion in the dev-seed-script.
See #575


Ingress TLS termination breaks dex connector setup

Checklist

[x] I've searched the issue queue to verify this is not a duplicate bug report.
[x] I've included steps to reproduce the bug.
[x] I've pasted the output of kargo version.
[x] I've pasted logs, if applicable.

Description
We are running nginx ingress controller that terminates TLS. Within the cluster we don't use TLS. I want to connect with MS AzureAD using Dex.
To expose Kargo on the ingress controller, I've set the following settings in values.yaml
api.tls.enabled: false
api.ingress.enabled: true
api.ingress.tls: false
api.oidc.enabled: true
api.oidc.dex.enabled: true
api.oidc.dex.connectors: [<MS AzureAD connector settings]

Problems
Mixed Content
On the login screen, Kargo tries to load insecure resources http:<host>/dex/.well-known/openid-configuration which is blocked and results in an error message
To fix this, I edited the configmap kargo-api to update the issuer to https prefix.
https://github.com/akuity/kargo/blob/c0d47e05abc053505a9e4a53467d31a271212e05/charts/kargo/templates/api/configmap.yaml#L47
Issuer Mismatch
After fixing this, it shows response body issues does not match expectedIssues which needs the same fix in the dex-server secret
https://github.com/akuity/kargo/blob/c0d47e05abc053505a9e4a53467d31a271212e05/charts/kargo/templates/dex-server/secret.yaml#L16
Screenshots

Steps to Reproduce

Use nginx ingress controller to expose Kargo.
Make sure TLS is terminated on Nginx ingress
Use the above mentioned tls settings in the helm chart
Use AzureAD connector with Dex

Version
/ $ kargo version
{
  "Version": "v1.0.3",
  "BuildDate": "2024-10-23T07:31:54Z",
  "GitCommit": "bb7afaad9750dfff61f47dd6c5288acbcdb6bce2",
  "GitTreeDirty": false,
  "GoVersion": "go1.23.2",
  "Compiler": "gc",
  "Platform": "linux/amd64"
}

api.ingress.tls: false

We are running nginx ingress controller that terminates TLS.

These statements seem at odds... unless...
Does your ingress controller have just one wildcard cert and it's terminating TLS before routing?

Correct. It's using a wildcard cert and nginx ingress is holding this wildcard certificate.
In-cluster encryption is handled differently that's why we terminate it at ingress level.

I am running into the same issue. My configuration is a little different though and I'm sure it is atypical as well. I have an A10 load balancer with a wildcard cert that terminates the SSL and connects to a single node port on my cluster. I would expect manually setting the issuer URL in the dex config to override the automatic configuration, but I see the helm chart doesn't use that value.


Can I search logs by Regular Expression  ？

it seams like not working.

Regular is very important for me
thank you sir

Are you trying to search with a regex? We don't support Regex queries (https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-regexp-query.html) as they require a special query syntax.

We don't yet support searching by regex. I'm going to close this for now but if there are more requests for this via this issue we'll reopen it. Also feel free to submit a pr for this as we would be more than happy to review it.


Sortby most-liked when 60+ images

Hello,
I got 1000+ images I would like to sortby most-liked and load 60 at a time.
When I use  "sortBy: most-liked" it looks like instafeed.js loads the 60 recent images and then sort these 60 by most-liked. When I load the next 60 images I get the next 60 recent images and these sorted by most liked.
It looks like it is not posible to sort all 1000+ images by most-liked. And then load 60 at a time?
Is this how instafeed.js works? Or is it a bug?
Kind regards

This is not a bug, but rather a consequence of Instagram's API.  The API does not have a sortBy parameter so all sorting is done once the data is received.  This will force you to make 1000+/60 requests often unless you cache your results (Instagram's API limit is 5000 calls/hour).

Hey @lasbrojen! I'm afraid @OstrichProjects is correct, the sorting isn't something provided by Instagram's API (at least not at the time this library was written), it's just something extra I added in.
At that volume of images, you'll probably want to create a server-side solution that saves images in a database or some other persistent store, and sorts them on the server side.


Save button not working

Save button was redudant with the update button. Both had the same feature, hence removed the save button and fixed the UI of the page.


[Enhancement] Chickens don't seem to spawn in modded biomes, unrestrict this?

While making a modpack of my own for a small group of friends and researching info about compatibility of mods and testing it on my own, it's become apparent that Chickens from this mod do not spawn in any biomes other than Vanilla biomes. When playing in a world with Lost Cities and Biomes O' Plenty, it proves nearly impossible to find the tier 1 chickens that cannot be bred. Would it be possible to add an option to un-restrict what biomes in the overworld / nether independently a chicken is able to spawn in, thus allowing them to spawn in ANY biome so long as the dimension is correct?
(Being able to whitelist specific biome ids/names would also be useful, although I understand that in particular would be asking quite a lot.)

This very much. I've looked into the code and the biome selection is based on hardcoded list of vanilla biomes. This is awful, please rewrite it into dynamic allocation based on Forge-declared biomes and their temperatures.

What mod & MC versions are you using? Its a bit harder to support modded biomes, but I have added some features into newest versions. but some things may not be working.
Also if you want to add in your own spawn controls. You can add a mod like InControl.
@Deuxis That is true for version 1.10 lower versions. But 1.11+ checks for biome types. It may not be ideal still, but it does work with modded biome's I have tested. While temperature may work, I have come across issues with that, when I worked on Enviromine.  Also I dont work on 1.10, only versions going forward. This reason is because when I joined the team I was to only working on version past 1.10.


undefined reference to `evp_cipher_fetch',EVP_MD_get_size while upgrading open ssl from 1.0.2 to 3.0.8

I am able to build the image of openssl 3.0.8 version and when i try to use the openssl image to build kerberos with crytpo as openssl im getting undefined reference to `evp_cipher_fetch',EVP_MD_get_size.
Here is my docker commands that are used for installing openssl 3.0.8 which is running successfully
FROM debian:bullseye

RUN mkdir -p /var/installation-files/openssl3

RUN set -ex
RUN apt-get update -y
RUN apt-get -y install  curl perl build-essential libssl-dev gcc tar

COPY ./enable_fips.sh /var/installation-files
RUN chmod +x /var/installation-files/enable_fips.sh
RUN /var/installation-files/enable_fips.sh

enable_fips.sh contains following code:
#!/bin/sh
set -e
cd /var/installation-files/
curl --output openssl-3.tar.gz https://www.openssl.org/source/openssl-3.0.8.tar.gz
tar -xf openssl-3.tar.gz
cd openssl-3.0.8
chmod +x config
./config
make
make test
make install
ln -s /usr/local/lib64/libssl.so.3 /usr/lib/libssl.so.3
ln -s /usr/local/lib64/libcrypto.so.3 /usr/lib/libcrypto.so.3
now using this as base image im trying to install kerberos  and here is my docker file for the same

FROM newopenssl:latest
# Setting up Environment Variable
ENV PATH=/usr/local/bin:$PATH \
    LANG=C.UTF-8 \
    DEBIAN_FRONTEND=noninteractive
ENV KRB5_KDC_PROFILE=/etc/krb5kdc/kdc.conf
# Setting up variable for Kerberos version
ARG KERBEROS_VERSION=1.18

# Download and Install Openssl and OpenSSL FIPS Component
RUN set -ex \
    && apt-get update \
    && apt-get -y install  perl build-essential bison flex libssl-dev xinetd sudo  wget curl\
    && mkdir -p /usr/local/src/ \
    && cd /usr/local/src/ \
    && curl -O https://kerberos.org/dist/krb5/${KERBEROS_VERSION}/krb5-${KERBEROS_VERSION}.tar.gz \
    && mkdir -p /var/lib/krb5kdc \
    && mkdir -p /etc/krb5kdc \
    && tar -xvf krb5-${KERBEROS_VERSION}.tar.gz \
    && cd krb5-${KERBEROS_VERSION}/src \
    && ./configure --with-crypto-impl=openssl --with-prng-alg=os --localstatedir=/var/lib/ \    # iam getting error in this line
    && make \
    && make install \
    && apt-get remove -y build-essential bison flex mailutils-common \
    && apt-get remove -y --purge mysql\* \
    && apt-get autoclean \
    && apt-get clean
-->
Please help me out to resolve this issue , Here is the error screens shot
<img width="999" alt="Screenshot 2023-10-31 at 2 35 08 PM" src="https://github.com/openssl/openssl/assets/142476796/9bda8cc7-8569-411e-820a-b11ca2759c84">

error screen shot

Are you linking against the 3.0.8 OpenSSL libraries?


list.index does not raise exception

In python when item not found it raises IndexError exception. Here it just returns javascript Array.indexOf call.
Expected solution: check if result is -1 and raise exception for consistency.

it raises ValueError exception (not IndexError) in Python3.9.

By default, in an effort to maintain runtime performance, indexed lookups in Transcrypt default to using native JS lookups that only return undefined for an invalid index. This is the reason that enabling operator overloading for processing negative indices is required, as it will instead call a custom __getitem__ method for handling indexed lookups. As a compromise, I've added index validation to that same __getitem__ method that is used when operator overloading is enabled with the opov pragma. In that case, the following would result in an exception that can be caught:
lst = ['a', 'b', 'c']
try:
    idx_val = lst[4]  # __:opov
    print(idx_val)
except Exception as e:
    print(e)

# index out of range

This feature will be added in v3.9.4


University of Beira Interior in the sistem

@AndrePutoi file(2)/lib/domains/pt/ubi.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@AndrePutoi Pull request merged. Please start requesting the licenses in about an hour, to let the changes to propagate through our system. Thank you.


Implement KeyMatcher trait

Adds a KeyMatcher trait, which is inhabited by nice, ergonomic combinations
of modifier specs and keys.
This is work in progress, it should be unified more with HotKeys.

Quick notes, but basically I don't have time right now to follow up; this should just be considered a source of ideas and I'll almost certainly close the PR.
I think it's possible to address the duplication with HotKey by using this as an ergonomic syntax for converting Into.
I didn't to multi code point string matching, but that's easy, just do an impl for &'static string. There's potentially a lot of complexity around shift and case matching.

I think we should just skip shift magic when dealing with multi code point values, I don't think we even really know the expected behaviour in those cases and we're more likely to make things worse than to improve them? 😬

Actually I don't know of any way to get a multi code point key in macOS. So we should probably do some research to determine if that's even a thing, before we put too much implementation work into it.
In any case, I'm closing this now. Keyboard events need to be reworked, as there's a lot of stuff that just doesn't work at all. But I do not have the bandwidth to get into those deep waters.


Understand HLS Interstitial Query Parameters

When HLS players make a request to obtain a response for Interstitials (either via X-ASSET-List or X-ASSET-URI), the player sends specific query parameters.
We need to understand which parameters are being sent and what has been implemented in hls.js version 1.6 beta, as this will be necessary for requesting the VAST/VAMP from the Ad server.

Its Interstitial query parameters are defined in https://datatracker.ietf.org/doc/html/draft-pantos-hls-rfc8216bis-16#appendix-D.3

Query Parameter / Header
Requirement
Description
Notes/Rules

_HLS_interstitial_id
Required (Recommended)
Contains the quoted ID attribute value of the EXT-X-DATERANGE tag.
Supports interoperability between content producers and decisioning servers.

_HLS_primary_id
Optional (Recommended)
Matches the X-PLAYBACK-SESSION-ID header value of the primary playback session.
- If clients cannot set the header, they must generate a globally-unique value for _HLS_primary_id. - Should be added to interstitial and primary asset requests.

_HLS_start_offset
Optional
Contains the offset in seconds of the playback start point from the beginning of the interstitial.
Only for X-ASSET-LIST requests when starting playback of a live stream in an interstitial.

Rule
Details

Unique Session Identification
Clients must generate a globally-unique value for _HLS_primary_id if unable to set X-PLAYBACK-SESSION-ID.

Consistent Usage
_HLS_primary_id must be included in all requests related to the playback session, including interstitials.

Start Offset Customization
_HLS_start_offset must be included in X-ASSET-LIST requests when starting playback in an interstitial of a live stream.

Request Types
Query parameters apply to: - X-ASSET-URI requests- X-ASSET-LIST requests- Requests for URIs in an X-ASSET-LIST JSON Asset Description.

About the X-PLAYBACK-SESSION-ID: https://github.com/video-dev/hls.js/issues/5770#issuecomment-1694400340

Apple players add a X-PLAYBACK-SESSION-ID header with every http request which contains the same uuid for the asset/player session. HLS.js does not, and is not required to...

From this:

From the previous table, we should understand what is supported in hls.js 1.6  beta
(Optional) Also would be interesting to understand what is supported in iOS and Safari

hls.js
In the process of understanding the Interstitial query parameters, we wanted to understand how hls.js player handled the previously mentioned params.
_HLS_primary_id
This param is added automatically by the player, and the value is set to the sessionId before making the request.
Code:
https://github.com/video-dev/hls.js/blob/7db2f5263ef707b3c9e4ec5dc9a0df56e03fe922/src/loader/interstitial-event.ts#L274-L283
_HLS_interstitial_id
There are no references in the code, the player does not add the ID automatically.
In the tests, we can see that is added directly into the interstitial uri, however, I'm not sure if that would be a real-life case scenario.
Code:
https://github.com/video-dev/hls.js/blob/7db2f5263ef707b3c9e4ec5dc9a0df56e03fe922/tests/unit/loader/playlist-loader.ts#L1801-L1832
_HLS_start_offset
Based on the code, it should be automatically added for live streams with interstitials asset list. It's still to be manually tested.
Code:
https://github.com/video-dev/hls.js/blob/7db2f5263ef707b3c9e4ec5dc9a0df56e03fe922/src/loader/interstitial-asset-list.ts#L32C2-L66C6

About: _HLS_interstitial_id
So basicaly we can build the ASSET List URI taking that into account.
Example form the link you sent @jaram-qualabs :

EXT-X-DATERANGE:ID="mid2",CLASS="com.apple.hls.interstitial",START-DATE="2024-01-12T10:00:25.000Z",DURATION=15.0,X-ASSET-URI="b.m3u8?_HLS_interstitial_id=mid2",X-SNAP="OUT,IN"

Proposal: Replace Existing Interstitial Query Parameter Handling with #EXT-X-DEFINE:QUERYPARAM from HLS Spec
Building on the previous discussion about handling interstitials with _HLS_interstitial_id and _HLS_primary_id as part of the standard, I propose using the #EXT-X-DEFINE:QUERYPARAM functionality defined in the RFC8216bis spec, Section <IP_ADDRESS> as an alternative. While those parameters are valid and part of the standard, this approach is simpler and more practical for dynamic query parameter handling.
I’ve tested this implementation, and it works.

Why Use #EXT-X-DEFINE:QUERYPARAM?

Simpler Implementation: Unlike _HLS_interstitial_id and _HLS_primary_id, this approach handles query parameters dynamically with minimal configuration and complexity.
Standards-Based: Fully compliant with the HLS spec, ensuring compatibility and interoperability with players.
Improved CDN Cacheability: The manifest remains static, with query parameters enabling personalization without affecting cache efficiency.

Working Example
HTML Setup (HLS.js Canary)
<video id="video" controls width="640" height="360"></video>
<script<EMAIL_ADDRESS><script>
  if (Hls.isSupported()) {
    const hls = new Hls();
    const token = "user-session-token"; // Replace with dynamic token logic
    hls.loadSource(`./playlist.m3u8?token=${token}`);
    hls.attachMedia(document.getElementById("video"));
  }
</script>

HLS Playlist
#EXTM3U
#EXT-X-VERSION:3
#EXT-X-TARGETDURATION:11
#EXT-X-DEFINE:QUERYPARAM="token"
#EXT-X-MEDIA-SEQUENCE:0
#EXT-X-PLAYLIST-TYPE:VOD
#EXTINF:10.000000,
segment1.ts?{$token}
#EXTINF:11.200000,
segment2.ts?{$token}
#EXT-X-ENDLIST
#EXT-X-DATERANGE:ID="ad1",CLASS="com.apple.hls.interstitial",
START-DATE="2024-01-12T10:00:25.000Z",DURATION=15.0,
X-ASSET-URI="https://example.com/ad.m3u8?{$token}",
X-SNAP="OUT,IN"

Key Changes

Leverages #EXT-X-DEFINE:QUERYPARAM:

The #EXT-X-DEFINE:QUERYPARAM="token" tag dynamically substitutes {$token} placeholders with the value in the playlist URL’s query string.
Applies consistently to both primary content (segment1.ts) and interstitials (X-ASSET-URI, X-ASSET-LIST).

Dynamic Personalization:

Personalization is handled via a token query parameter appended dynamically at runtime.

CDN-Friendly:

Manifests remain static, allowing efficient CDN caching while maintaining user-specific personalization.

Next Steps for Discussion

Does updating server logic to dynamically append the token query parameter fit our current solution?

Let me know your thoughts or if more examples/tests are needed!

Thanks @fcancela. I updated the samples in the repo. It works perfect with hls.js 1.6 beta.


Query :: Tracking doesn't work with coalesce and conditional

Repro:
                var query = from eVersion in ctx.Entities
                            join eRoot in ctx.Entities
                            on eVersion.RootEntityId equals (int?)eRoot.Id
                            into RootEntities
                            from eRootJoined in RootEntities.DefaultIfEmpty()
                            select eRootJoined ?? eVersion;

                var result = query.ToList();

                // returns 0 elements
                var trackedCount = ctx.ChangeTracker.Entries().ToList();

Currently we have a TrackEntities method around the query, that keeps track of which entities from the result object should be tracked - storing the list of accessors from the resulting object to the entity that is supposed to be tracked.
We compute those accessors using re-linq's AccessorFindingExpressionVisitor which currently doesn't handle Coalesce or Conditional expressions.
@MichaelKetting would you consider adding logic for those operators or perhaps some extensibility points so that we could handle additional nodes?

@maumar Ah, yes. Will need to look into this. When the AcessorFindingExpressionVisitor is used inside the transformation, support for Coalesce and Conditional isn't needed since those can be evaluated inside the SQL query and only the resulting value needs to be handled in memory.
Extension point's a bit tricky due to the way the callgraph is composed but I'll have a look at the implications of Coalesce and Conditional.
I haven't checkout out TrackEntities, am I correct in understanding that you're just tracking the objects returned by the outermost select projection?

@MichaelKetting yes, we only track entities that are part of the final result. TrackEntities method is wrapped around our last Select method. However we compute accessors earlier, because we strip QuerySourceReferenceExpressions at one point in our pipeline.
I guess we could refactor that part in EF code to compute accessors based on entity types rather than query sources themselves. This would probably mean that all entities of a particular type would be tracked/included regardless of their DbSet of origin, but that might be ok. I will look into this from my side also. Thank you for your input!


Unable to load reference cycles

Attempting to follow the docs here: https://asdf.readthedocs.io/en/latest/asdf/extending/converters.html#reference-cycles
If I run the following
import fractions

import asdf

# in the example_project.fractions module
class FractionWithInverse(fractions.Fraction):
    def __init__(self, *args, **kwargs):
        self._inverse = None

    @property
    def inverse(self):
        return self._inverse

    @inverse.setter
    def inverse(self, value):
        self._inverse = value

class FractionWithInverseConverter:
    tags = ["asdf://example.com/fractions/tags/fraction-1.0.0"]
    types = [FractionWithInverse]

    def to_yaml_tree(self, obj, tag, ctx):
        return {
            "numerator": obj.numerator,
            "denominator": obj.denominator,
            "inverse": obj.inverse,
        }

    def from_yaml_tree(self, node, tag, ctx):
        obj = FractionWithInverse(node["numerator"], node["denominator"])
        yield
        obj.inverse = node["inverse"]

class FractionWithInverseExtension:
    tags = FractionWithInverseConverter.tags
    converters = [FractionWithInverseConverter()]
    extension_uri = "asdf://example.com/fractions/extensions/fraction-1.0.0"

with asdf.config.config_context() as cfg:
    cfg.add_extension(FractionWithInverseExtension())

    f1 = FractionWithInverse(3, 5)
    f2 = FractionWithInverse(5, 3)
    f1.inverse = f2
    f2.inverse = f1

    with asdf.AsdfFile({"fraction": f1}) as af:
        af.write_to("with_inverse.asdf")

    with asdf.open("with_inverse.asdf") as af:
        reconstituted_f1 = af["fraction"]

    assert reconstituted_f1.inverse.inverse is reconstituted_f1

I get the following error:
AttributeError: 'NoneType' object has no attribute 'inverse'

The produced file contains
fraction: &id001 !<asdf://example.com/fractions/tags/fraction-1.0.0>
  denominator: 5
  inverse: !<asdf://example.com/fractions/tags/fraction-1.0.0>
    denominator: 3
    inverse: *id001
    numerator: 5
  numerator: 3

Tested on asdf main, 2.15, and all minor versions back to 2.8.

I was missing the obj in the yield. With this change the example works on main and 2.15


Edit pass for Update mac-support-install.md. DO NOT MERGE.

Light copy edit

(Just a technical comment on one of the features of Pull Requests: it is possible to open a PR as a Draft PR instead of a standard PR. This feature is accessible from the [Create Pull Request] button. Draft PRs cannot be merged. If the priority to make sure that the PR does not get merged is a high priority, I really recommend learning how to use this feature.)

Hi, Dan/@Dansimp,
We’ve finished the edit pass of this article. Please review it and let me know if we’ve changed the technical meaning anywhere. You have five business days for the review (If you need longer, let me know).
When your review is complete, and you’re satisfied with the changes, our team will do the final merge to confirm there are no remaining PR issues.
Thanks!