Content updates for Service Worker libraries

New libraries 📚
sw-offline-google-analytics: https://github.com/GoogleChrome/sw-helpers/tree/master/projects/sw-offline-google-analytics . Covered in https://developers.google.com/web/updates/2016/07/offline-google-analytics if you want to link up to it
sw-appcache-behavior: https://github.com/GoogleChrome/sw-helpers/tree/master/projects/sw-appcache-behavior. A service worker implementation of the behavior defined in a page's App Cache manifest - helps migrate users away from AppCache -> Service Worker.
Videos 📹

Totally Tooling Tips: Service Worker Libraries
Totally Tooling Tips: Offline caching with sw-toolbox
Great libraries and tools for building PWAs

Codelabs 💥
Adding a SW with sw-precache
Articles (team/community) 🗞

Getting started with sw-toolbox by Dean Hume
Adding offline support to create-react-app using sw-precache

cc @jeffposnick as an FYI. Is there anything else worth including in the updates?
cc @gauntface Worth linking up to the FCM Web Push library work here too? (we don't currently reference it anywhere). Guess we could link up to https://firebase.google.com/docs/cloud-messaging/js/client?

I put together a draft of some related material as part of the WebFundamentals hack week, linked to from https://github.com/google/WebFundamentals/issues/3453
@jpmedley, I don't know if you've reviewed it yet. If you find it useful, maybe it can just be incorporated into the deliverable tracked by this issue.

That was my plan.

@jpmedley do we think we can get these landed in time for CDS?

Yes.

Here's the result: https://developers.google.com/web/tools/service-worker-libraries/


rtx 1.21.5 release was not completed

👋 looks like the 1.21.5 release was not completed, raise an issue in here for some awareness, https://github.com/jdxcode/rtx/actions/runs/4331559515/jobs/7563471994, thanks!
relates to https://github.com/Homebrew/homebrew-core/pull/124802

Yeah that was weird, I thought I broke it so cut another release but it looks like it was GitHub's API that was failing. It worked on retry.


Add drop-in replacement for http.Get with timeout

Add drop-in replacement for http.Get with timeout
Update README - docker.local IPv6 address which fixes 5 seconds delay (a known IPv6 issue)
test with/without the host entry e.g.: ipdr dig or curl -4/curl -6
hello/test.sh runs in 3m51s vs 0m28s
IPv6 related issues:
https://blog.csuttles.io/post/troubleshooting-a-slow-client/
https://www.math.tamu.edu/~comech/tools/linux-slow-dns-lookup/

@qiangli looks good. A timeout was definitely needed. Merging.

@qiangli looks good. A timeout was definitely needed. Merging.


Socket error

Cannot find address

Since we moved from python to Go Lang this is no longer essential to the project development.


Error reported when processing swagger of DataFactory which has enum with object type

As shown below:

Saw this in GraphRBAC as well. It's more like an existing error on Swagger (type=object, then x-ms-enum modelAsString=true, quite a conflict). I think latest Swagger Validator would forbidden this. But older ones exist.

I am afraid we will not be able to fix the issue for all the existing ones in swagger. It will be helpful if modelerfour can handle it like v1. @fearthecowboy , will this be handled in modelerfour?

DataFactory provides some very bad patterns that I'm not sure we can support.
type:object and modelAsString:true is just plain wrong.  We're not going to carry forward bad code and expect something valid. If they want it to work with V3 generators, they're going to have to fix the input.
Handling of enum values is predicated on them being constant values in the end, and calling it an object and expecting to support an enum for that is just not going to work.


Add aniket-24

resolve #732

@Panquesito7 please review and merge this!

@schmelto @Panquesito7 what all changes are required to merge this PR

Now, is it okay? @Panquesito7


Not able to mock $root

I'm using vue 3 and vue-test-utils v2 . I have a component which uses $root to listen events. When I try to test this component it fails by throwing error 'this.$root.$on'  is not a function.
I have even tried using mounting options 'parentComponent' but not working.
const Parent = {
  data() {
    return {
      $on: jest.fn(),
    }
  }
}
const wrapper = shallowMount(TestComponent, {
  parentComponent: Parent
})

Hi @hilkisahil
If you are using vue v3.2.45, then yes there is a change in vue core that we have to work around in VTU
We already have the fix, and we are going to release it soon
Closing as duplicate of #1869


Support loading service definitions from config files

Adding support loading service definitions from config files, A port of symfony's dependecy-injection config loades. This feature is expiremental as more tests is necessary in adding to release.
This feature supports:

[x] Loading service definitions from directory.
[ ] Loading service definitions should support both container and container builder classes.
[x] Loading service definitions from patterned file or directory.
[x] Loading service definitions from closures.
[x] Loading service definitions from yaml files.
[ ] Loading service definitions from PHP files.
[ ] Added full tests coverage for feature.

Codecov Report

Merging #20 (423ad60) into master (0083004) will decrease coverage by 23.65%.
The diff coverage is 0.00%.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0083004...423ad60. Read the comment docs.


Issue during installation for M1 mac

Hi folks,
I was trying to install the required packages but it seems there is an issue with mecab-python3. Here is the error log I saw:
 × Running setup.py install for mecab-python3 did not run successfully.
  │ exit code: 1
  ╰─> [14 lines of output]
      /Users/yogesh/Projects/Playground/storyteller/.env/lib/python3.10/site-packages/setuptools/installer.py:27: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.
        warnings.warn(
      running install
      /Users/yogesh/Projects/Playground/storyteller/.env/lib/python3.10/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
        warnings.warn(
      running build
      running build_py
      creating build
      creating build/lib.macosx-13.1-arm64-cpython-310
      creating build/lib.macosx-13.1-arm64-cpython-310/MeCab
      copying src/MeCab/__init__.py -> build/lib.macosx-13.1-arm64-cpython-310/MeCab
      copying src/MeCab/cli.py -> build/lib.macosx-13.1-arm64-cpython-310/MeCab
      running build_ext
      error: [Errno 2] No such file or directory: 'mecab-config'
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: legacy-install-failure

× Encountered error while trying to install package.
╰─> mecab-python3

note: This is an issue with the package mentioned above, not pip.
hint: See above for output from the failure.

I am using an M1 Mac so I am not sure if there any additional steps I missed.

Hey @itsyogesh, thanks for opening this issue.
Seems like the issue is coming from mecab-python3. Can you try running this?
pip install mecab-python3

Also, I'm in the middle of making this project pip-installable, so hopefully installing will get a lot easier. Let me know how this goes!

Hey @jaketae, thanks for the response, seems like the issue was getting the mecab either installed from source or brew before installing mecab-python3. Here is where I found out.
https://github.com/SamuraiT/mecab-python3/issues/84
I've gotten it installed and working now. Thanks for all the help. I have added a PR for this too.

Hey @itsyogesh, thanks for digging into this further and offering to open a PR. I've merged the changes. Thank you!


Siegfried HL is not included in the raid list

added with 2ebce9a138bccc46b4260b7bb0c156d9db1cacf2 and 4c37e872035efc760fa7f9ba37c2eed3de4f7541
Note: Raidfinder will go down for around 10minutes at Friday, November 18, 2022 1:00:00 PM [GMT-05:00] for this update.

successfully deployed


regex-try: update dependencies

Closing; the code for this has moved over to https://github.com/bnjbvr/try-regexp.


[Super Mario Maker] NSMBU theme is completely broken

Could possibly be a framebuffer issue, here's the list of resolutions that I got:
CemuViewportSkimmer by MHVuze
=============================
Depending on your CPU and the log size, the processing might take some time.

0, 0, 1280, 720
0, 0, 854, 480
0, 0, 427, 240
0, 0, 106, 60
0, 0, 640, 360
0, 0, 160, 90
0, 0, 256, 256
0, 0, 64, 64
0, 0, 128, 256
0, 0, 32, 64
0, 0, 128, 128
0, 0, 1024, 1088
0, 0, 32, 32
0, 0, 16, 16
0, 0, 8, 8
0, 0, 48, 48
0, 0, 24, 24
0, 0, 4, 4
0, 0, 2, 2
0, 0, 768, 384
0, 0, 384, 192

Found 21 unique viewport resolutions and a total of 176471.

Closed since Mario Maker support was removed e3f015c


Missingness applied to uploaded complete data

Limit dealing with missingness options to complete case when no missingness detected in data, unless appropriate non-response variable supplied, then also offer weighting

Validation added for missing data and MI not removed when complete data detected


This action doesn't work with Groovy instances

When trying to use this action in a Groovy Deephaven instance, the console throws the following error
java.lang.UnsupportedOperationException: python session mode is not enabled

This should be investigated and fixed so that Groovy users get the same <3 as Python users

This is most likely blocked by https://github.com/deephaven/deephaven-core/issues/1480. Once that is resolved we can use other methods in the pyclient to validate the tables without needing python session mode


Develop

Add semantic-release

:tada: This PR is included in version api-v1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Change ORT/atstccfg to use standard TC objects

Changes lib/go-atscfg to take standard lib/go-tc objects, instead of custom stuff. This makes it much easier to use as a library. Users can simply get objects from the TO API, and pass them to generate config, instead of having to build custom objects, with a lot of logic in their app.
As a reminder, it didn't do this at first because the custom objects were what we had in Traffic Ops from the DB; TO config files have now been removed.
This also

changes the comment header to be the real TO URL that ORT has (instead of a magic, possibly-wrong Parameter), use the same generation timestamp on all files, and include the TO IP(s). Should improve debugging.
changes lib/go-atscfg to track non-fatal warnings, and return them in a list, so the library itself doesn't log (libraries should never log)
changes lib/go-atscfg generation funcs to return real errors, instead of an "ERROR: " config file string (again, it did that because TO did it, which has now been removed).
Fixes a bug with ORT not fetching the latest servers, even though they were needed and added to atstccfg/toreqnew.

Sorry for the size. If I tried to make all those things separate, they would've had terrible merge conflicts. For what it's worth, this should be a big improvement in production debugability, safety, better testing, not generating broken files, and better error and warning reporting.
lib/go-atscfg has extensive unit tests, and they pass. Even better, with the custom-object logic now in the library, even more is being unit tested.
I also manually tested generating both edges and mids on our two largest CDNs, they all diff identical, except the comment header and a ip_allow change/fix that's caused by the bug fix.
This is all boilerplate changes, no logic. The actual config logic should be unchanged, and any logic change is a bug.
Also for what it's worth, I'm hoping lib/go-atscfg is getting very close to "stable" and we can start supporting Go Modules and a "version promise" for the library. This is a huge step in that direction.
Includes extensive tests.
No docs, no interface change (outside the non-stable library).
No changelog, no interface change.

[x] This PR is not related to any other Issue

Which Traffic Control components are affected by this PR?

Traffic Ops ORT

What is the best way to verify this PR?
Run unit tests.
Generate config with the master ORT, generate config with this PR, verify no changes (except the aforementioned comment header and corrected ip_allow CIDR).
If this is a bug fix, what versions of Traffic Control are affected?
Not a bug fix. The bug mentioned is in master, not in a release.
The following criteria are ALL met by this PR

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Fixed conflicts


Unable to find out .pipe.yaml in the new application path

What happened:
I switched the application path from playground/ to playground-tmp/, then do a quick sync.
Then looks like piped couldn't find out .pipe.yaml.
Unable to plan the deployment (error while preparing deploy source data (open /tmp/workspace061413939/f9fc56b1-2267-4af3-bbe9-92e0f394353d-planner-769907772/target-deploysource/deploysource240812651/repo/playground-tmp/.pipe.yaml: no such file or directory))

What you expected to happen:
How to reproduce it:
Environment:

piped version:
control-plane version:
Others:

The reason is the directory created after MostRecentSuccessfulCommitHash cannot be read when getting running DSP.
https://github.com/pipe-cd/pipe/blob/6a5cf4389cd6209caf169968249988df7c3615a9/pkg/app/piped/planner/kubernetes/kubernetes.go#L156-L160

This issue happened because
I spent a little bit of time solving it and found out the only way to solve this is letting ApplicationDeploymentReference the GitPath:
--- a/pkg/model/application.proto
+++ b/pkg/model/application.proto
message ApplicationDeploymentReference {
    string deployment_id = 1 [(validate.rules).string.min_len = 1];
    DeploymentTrigger trigger = 2 [(validate.rules).message.required = true];
    string summary = 3;
    string version = 4;
+   ApplicationGitPath git_path = 5 [(validate.rules).message.required = true];

    int64 started_at = 14 [(validate.rules).int64.gt = 0];
    int64 completed_at = 15 [(validate.rules).int64.gte = 0];
}

All changes can be shown through here: https://github.com/pipe-cd/pipe/commit/f215eb8bfa85610d4ce769241e8d121aa98109ac (maybe soon-to-be deleted)
But honestly, it's really odd because an ApplicationDeploymentReference has its own GitPath even though each Application has its own GitPath as well. And all components are assuming an Application has its own immutable Gitpath, and I believe it should keep it.
Besides,

@nakabonne Nice. I totally agree with making GitPath immutable for each application.
So let's do it.
We will have 2 parts:

Updating API to disallow changing the git path value
@cakecatz Update application edit form to not allow updating that field

Right right. Okay, let me pick the first one. And I'm gonna open new issues for each.

Closing since both issues resolves this one.
/close


websocket over HTTP via JSON

I ran into an issue that library cant work via default websocket protocol on a mixed http/wamp server that doesn't support msgpack.
To solve such issue I have created my own fork (https://github.com/CepGamer/autobahn-cpp, not finished yet) that creates websocket connection over http (using http upgrade request) and communicates using this socket. Also I had to translate JSON messages to and from msgpack by creating a wrap (changed get_message_body() function to produce msgpack object from json string and send() function to do the opposite).
It's messed up and not yet ready (lots of copy/paste and hardcode), but I'm planning to finish it. I wanted to know, whether such additions is needed or maybe I am doing it wrong (maybe there is a better way :) ) or I just haven't found it in the lib.
Regards,
Sergei Bolotov

As a suggestion, you might want to do rebases instead of merges if the intention is to get your branch merged back into upstream autobahn-cpp.
We've also recently split out https://github.com/tplgy/json-msgpack from bonefish which handles JSON/msgpack conversions with a minimal amount of extra copies, we should probably also move the WAMP-specific binary handling into that project and see if it can be switched to the Boost license as well.

May I ask you a couple of questions?
What would you recommend on how to implement switch between websocket frames and raw byte exchange via TCP?
Also, I'm using websocketpp to construct frames which introduces new dependency, maybe I should use some other library?

@CepGamer from the spec (on rawsocket handshake):
The first octet is a magic octet with value "0x7F".  This value is
chosen to avoid any possible collision with the first octet of a
valid HTTP request (see here [6] and here [7]).  No valid HTTP
request can have "0x7F" as its first octet.
  By using a magic first octet that cannot appear in a regular HTTP
  request, WAMP-over-RawSocket can be run e.g. on the same TCP
  listening port as WAMP-over-WebSocket or WAMP-over-LongPoll.

rgd websocket: websocketpp is just fine. I would not use a different lib nor reinvent the wheel.

So you can not connect to servers with http/wamp mixed protocols? I think in AutobahnJS it works, doesn't it?

@Bobface Yes, it works in JS and Python (the ones I checked), but, unfortunately, I may only use C++ in my code.

As mention, RawSocket has facilities to support running besides WebSocket on one TCP port.
This is not using HTTP upgrade mechanism, and is a router-side feature - there is nothing to implement in WAMP clients.


Broken link for PowerShell Corpus

"This full corpus can be downloaded from (https://aka.ms/PowerShellCorpus). Stay tuned for the publishing of the labeled data and the tooling used for training."
This link appears to be broken. Is this data still available, and is labeled data still planned to be released? Thank you!

Sorry -- link is not broken!...it's just a one drive link that was blocked on my network.


Added SaveUtility static class with generic methods.

Saving a whole game state with individual variables is hard with playerprefs.
I thought it would be nice to have a static class where we can easily save and load.

thanks!


Investigate building books with CI/CD

Something many have asked for in Jupyter Book is to use various CI/CD deployments for building and hosting books. We should look into this for whatever our "final" book build system is.
A few that we should explore:

TravisCI
CircleCI
GitHub Actions

https://github.com/ammaraskar/sphinx-action

Netlify
Readthedocs

Yes, for sure, and perhaps even multiple options in order to be most helpful for a range of users.


[slack] Prettify result preview unfurling

What changes were proposed in this pull request?

Removing Prettytable and using Tabulate module to make tables (compatible with Py2 and almost 2x faster)
Making pivot result table which enables us to show large number of columns of query result but we can see only 2-3 rows in preview(keeping 2 so that it does not break when lengthy fields are seen)

Much cleaner now and lot more number of columns!

Added tabulate in ext-py but py2 build is still failing showing No module named tabulate. Did I miss anything @romainr ??

How the CI works right now Py2 won't pass before rebuilding the image (as all the ext-py is pre compiled to save a lot of time). I kickstarted it and will rerun the CI when ready in ~1h

recheck


which files should i put into my library?

@tcgumus
The file is "dist/jquery.jsontotable.min.js".
Thanks.


Generic type inferred as supertype if that's the callback parameter type

TypeScript Version:  nightly (2.2.0-dev.20161214)
(Ref: https://github.com/Microsoft/TypeScript/pull/12862#discussion_r92284049)
Code
function f<T>(x: T[], y: (t: T) => void): T[] { return x; }
function g(value: {}): void {}
const x: number[] = f([1, 2], g);

Expected behavior:
Infers f<number>.
Actual behavior:
Infers f<{}>.

Both [1, 2] and g are inference sites for type parameter T, so the inference system looks for a common supertype between candidates number and {} and returns {}.

But, any function of type {} => void should also be a function of type number => void. A function that can take anything can take a number. So maybe we could be a little smarter and not widen T based on a type in that position.

It's not fixed yet.

Actually it's fixed in 3.5! 🎉

I checked following code in ts 3.5.1. The Props is sometimes inferred as the same as its supertype Defaults. The W is working as expected, but X/Y does not work. Could you help me with this? @RyanCavanaugh
playgroud
declare type RequiredKeys<T> = {
  [K in keyof T]-?: ({} extends {
      [P in K]: T[K];
  } ? never : K);
}[keyof T];
declare type MissingProps<Defaults, Props extends Defaults> = Pick<Props, Exclude<keyof Props, RequiredKeys<Defaults>>>;
declare type WithDefaultProps<Defaults, Props extends Defaults> = MissingProps<Defaults, Props> & {
  [P in RequiredKeys<Defaults>]?: Defaults[P];
};
declare function withDefaultProps<Defaults, Props extends Defaults, Ret, RefParam>
(Comp: (props: Props, ref: RefParam) => Ret, defaults: Defaults):
(props: WithDefaultProps<Defaults, Props>, ref?: RefParam) => Ret;

interface Props {
  width: number;
  audioFile: string;
  onPosChange: (ev: any) => void;
}

function Ccc(props: Props) {
  return props.width
}

// ✅ Inferred as: function withDefaultProps<{ width: number; }, Props, number, {}>
const W = withDefaultProps(Ccc, { width: 123 })
// ❌ Inferred as: function withDefaultProps<{ readonly width: 123; }, { readonly width: 123; }, number, {}>
const X = withDefaultProps(Ccc, { width: 123 } as const)
// ❌ Inferred as: function withDefaultProps<{ width: number; }, Props, number, {}>
const Y = withDefaultProps(Ccc, { width: 123, onPosChange: () => {} })

It's not fixed.
$ cat test.ts

function f<T>(x: T[], y: (t: T) => void): T[] { return x; }
function g(value: {}): void {}
const x: number[] = f([1, 2], g);

$ tsc --version
Version 3.5.1

$ tsc test.ts
test.ts(3,7): error TS2322: Type '{}[]' is not assignable to type 'number[]'.
  Type '{}' is not assignable to type 'number'.


release raiwidgets and responsibleai 0.22.0

Description
Release Notes:
v0.22.0

educational materials

Notebook change showing the usage of identity feature and feature metadata by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1627

new features

Responsible AI Dashboard

Vision Dashboard Table View and initial explanation flyout by @jamesbchao in https://github.com/microsoft/responsible-ai-toolbox/pull/1621
Vision dashboard backend without data characteristics tab by @jamesbchao in https://github.com/microsoft/responsible-ai-toolbox/pull/1668
Vision dashboard data characteristics tab by @jamesbchao in https://github.com/microsoft/responsible-ai-toolbox/pull/1675
Vision dashboard cohorts by @jamesbchao in https://github.com/microsoft/responsible-ai-toolbox/pull/1686
Vision model overview metrics by @jamesbchao in https://github.com/microsoft/responsible-ai-toolbox/pull/1688

Error Analysis

NLP Feature Extractors

Add the code for the nlp_feature_extractors to the RAI Toolbox by @ilmarinen in https://github.com/microsoft/responsible-ai-toolbox/pull/1580

bug fixes and tests

Responsible AI Dashboard

[Accessibility] Data analysis scatter chart - use symbol and color to differentiate data series by @RubyZ10 in https://github.com/microsoft/responsible-ai-toolbox/pull/1667
Bump moment-timezone from 0.5.34 to 0.5.35 by @dependabot in https://github.com/microsoft/responsible-ai-toolbox/pull/1677
Add validations for dashboard endpoints by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1672
[Accessibility][reflow] Error analysis tree map & Data explorer & Feature importance Reflow by @RubyZ10 in https://github.com/microsoft/responsible-ai-toolbox/pull/1678
[Accessibility][reflow] Error Analysis heat map & Model overview & Counterfactual & Causal analysis by @RubyZ10 in https://github.com/microsoft/responsible-ai-toolbox/pull/1680
[localization] Localize high chart context menu items by @RubyZ10 in https://github.com/microsoft/responsible-ai-toolbox/pull/1691
for RAI text dashboard, remove radio buttons and legend text when avg of abs value local importances selected by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1683
Vision dashboard UI Fixups by @jamesbchao in https://github.com/microsoft/responsible-ai-toolbox/pull/1687
touch ups from designer feedback to RAI dashboard for text data by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1695

RAIInsights

Update econml to 0.13.1 by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1660
[responsibleai]: Add tests for classification outcome (multiclass) and regression error by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1662
JSON serialize the endpoint output and add tests by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1679
Cache predict() and predict_proba() output by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1702
Reduce the train and test dataset sizes in responsibleai to reduce test time by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1630

Counterfactual

Causal

Add validations for heterogeneity_features in causal manager by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1659
Fix localization for causal tooltips by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1690

Error Analysis

[Accessibility] Error analysis screen reader by @RubyZ10 in https://github.com/microsoft/responsible-ai-toolbox/pull/1663
Add metric computation of mean prediction by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1693
Add support for 'True Y' filter for cohort filtering by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1685
Avoid additional predict call in case of ModelAnalyzer by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1701
release erroranalysis v0.3.10 by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1706

Dataset Explorer

refactor table view into data analysis component by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1673
add mini-table to feature importances view by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1682

Model Overview

[Model Overview] Box plot data for classification probabilities from SDK endpoint by @tongyu-microsoft in https://github.com/microsoft/responsible-ai-toolbox/pull/1689
Change 'Accuracy' to 'Accuracy score' in ModelOverview by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1700

Interpret

[Accessibility][reflow] Individual conditional expectation plot by @RubyZ10 in https://github.com/microsoft/responsible-ai-toolbox/pull/1699

NLP Feature Extractors

update nlp-feature-extractors readme, dependencies and add a release script by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1666
fix nlp-feature-extractors release by renaming requirements file by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1670
add missing positive negative words csv file to attribute extractors by @imatiach-msft in https://github.com/microsoft/responsible-ai-toolbox/pull/1671

other

[localization] LEGO: Pull request from JUNO/hb_a12a4630-4852-4e7d-9cbc-c0e1117da1ab_20220907180147477 to main by @csigs in https://github.com/microsoft/responsible-ai-toolbox/pull/1694
Update CODEOWNERS by @gaugup in https://github.com/microsoft/responsible-ai-toolbox/pull/1696

Checklist

[ ] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[x] Documentation was updated if it was needed.

Codecov Report

Merging #1707 (03df58b) into main (2705bea) will increase coverage by 3.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1707      +/-   ##
==========================================
+ Coverage   89.00%   92.09%   +3.08%
==========================================
  Files         105       86      -19
  Lines        5577     4263    -1314
==========================================
- Hits         4964     3926    -1038
+ Misses        613      337     -276

Flag
Coverage Δ

unittests
92.09% <ø> (+3.08%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

raiwidgets/raiwidgets/__version__.py

raiwidgets/raiwidgets/error_analysis_constants.py

...iwidgets/raiwidgets/explanation_dashboard_input.py

raiwidgets/raiwidgets/interfaces.py

raiwidgets/raiwidgets/fairness_dashboard.py

raiwidgets/raiwidgets/error_analysis_dashboard.py

raiwidgets/raiwidgets/cohort.py

...iwidgets/raiwidgets/fairness_metric_calculation.py

raiwidgets/raiwidgets/__init__.py

raiwidgets/raiwidgets/responsibleai_dashboard.py

... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Hard references to www.facebase.org in Angular templates

On other projects like gpcr-dev I can view HTML and see references to www.facebase.org which are probably supposed to be relative URLs for the current server.  The ones I noticed are related to the XTK viewer but there may be more.

I wouldn't think these would be references to XTK viewer. I would think they may be the help link and another similar one from the chaise configuration. That's where I would suggest looking first:
<base dir>/chaise/chaise-config.js

Okay... I see it. Should have just done a quick repo search. Yes, its the XTK viewer / preview stuff.
The offending lines of code are here:
https://github.com/informatics-isi-edu/chaise/blob/master/record/index.html.in#L107-L108

grep for www.facebase.org in record/index.html.in

The bit of remaining ugliness is that it expects the viewers to be found at the origin host under a specific path.
Embedded image viewer =>
origin + '/_viewer/xtk/view_on_load.html?url=' + PREVIEW_URL

Full size image viewer =>
origin + '/_viewer/xtk/view.html?url=' + PREVIEW_URL

This could be resolved through some annotation but I think we should step back a bit and decide where we want to go with this really, before putting more effort into it right now.

The fix can be viewed here:
https://dev.misd.isi.edu/~schuler/chaise/record/#1/legacy:dataset/id=4409

I still see my browser trying to access facebase.org (in my 3rd party request blocker) and I still see stuff like this with view source:
Enlarge
I am looking at https://dev.misd.isi.edu/chaise/record/#1/legacy:dataset/id=263 for example.


atip: management cluster fixes

Some fixes to clarify the node definitions
Fixes: #291
Fixes: #278

@hardys I just had a suggestion as per the style guide.

Thanks, accepted!


Why we don’t have a file exporter?

We all know that the memory buffer is limited, and the port-based exporter will cause longer I/O blocking, and may have to have a retry mechanism.
Using file expoter and a collection mechanism similar to filebeat can solve this type of problem.

wrong place

wrong place


Why should I use derry instead of other convenient solutions for me?

Why shall I add another dependency to yaml file when I can use code templates build in my code editor. And it will work without extra work after I create a new project.

First of all, derry is not a local dependency or it should be used as one. Derry was meant to be command-line tool that can be used as a script manager for Dart, providing the tooling required for Dart/Flutter development which pub currently doesn't provide. You can read more in README.
Second of all, I don't think you read the Documentation/README at all. Thank you for your interest but both in the readme and pub installation documentation, it is mentioned that derry is to be installed as a global dependency. You don't want to add derry as a dependency to your local pubspec.yaml, you don't have to. To get correlated with the main goal of this package, you even shouldn't do that.
Lots and lots of people have came up with suggestions for a setup I've been missing for my development, and I'm thankful for these suggestions. What you can do instead of using derry is these solutions.

Use Makefile to setup your scripts
Use your editor to configure scripts (which is the same as your suggestion)

I won't make a fake story to promote derry nor I have the intention to. I'll just tell my problems. First, I used Windows and Makefile is not available on Windows. I'll have to do some extra steps that are out of Dart development scope. For this reason, the first solution became inconvenient for me. Secondly, I've recently been using Vim as my main editor, and I really don't want to mess my "very simple terminal coding" experience with extra setups. Not because I don't know the advantages, but because I am a very minimal person that loves barebone terminal coding experience. That's why derry was the best solution for me (at least). It is straight forward in the scope of dart development and configurable as I wanted, and it's also as fast as a repl because of Rust.
If you read the README's Why and How section, you will notice that derry was initially made just for myself.
I'm not forcing you to use derry or promoting it. This is simply an explanation on why I made derry. If other solutions are more convenient for you, please use them. It is the developers' job to make their development as smooth and easier as it can get.
Thank you! for your interest and the time you took to open an issue.


Update Node.gitignore to include VitePress

Include VitePress
Reasons for making this change:

I noticed that VuePress is included in the current gitignore. VuePress has been succeeded by VitePress. This change includes files to be ignored in a VitePress project.

@NdagiStanley could you provide some links to documentation supporting the change?
I just want to keep a good record that supports the change.
Thank you! 🙇

The modification reference can be found in the official VitePress documentation here: https://vitepress.dev/guide/getting-started#file-structure
It mentions:

TIP
By default, VitePress stores its dev server cache in .vitepress/cache, and the production build output in .vitepress/dist. If using Git, you should add them to your .gitignore file. These locations can also be configured.

@NdagiStanley Please note that the VitePress temp and cache directory is .vitepress/cache, not .temp or .cache. It differs from the VuePress v2.x directories.

@NdagiStanley Please note that the VitePress temp and cache directory is .vitepress/cache, not .temp or .cache. It differs from the VuePress v2.x directories.

You are right @caipeter888. I've updated the PR.

Good point @caipeter888
According to the .gitignore docs on pattern format, I should include **/. Sending an update now.

Pada Isn, 23 Dis 2024, 9:23 PM 蔡鑫培Peter @.***> menulis:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/github/gitignore/pull/4543#pullrequestreview-2520586163,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BMI7AEPN5DAM7Q5CCFVX2ZL2HAFFZAVCNFSM6AAAAABS2H3RTSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRQGU4DMMJWGM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Pada Kha, 26 Dis 2024, 12:40 PM Along Azhar @.***>
menulis:

Pada Isn, 23 Dis 2024, 9:23 PM 蔡鑫培Peter @.***>
menulis:

@.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
https://github.com/github/gitignore/pull/4543#pullrequestreview-2520586163,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BMI7AEPN5DAM7Q5CCFVX2ZL2HAFFZAVCNFSM6AAAAABS2H3RTSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRQGU4DMMJWGM
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


⚠ Bofrost.es has degraded performance

In f18dce5, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1620 ms

Resolved: Bofrost.es performance has improved in 928101b.


Implement Format for i64/u64?

When trying to do this:
#[derive(defmt::Format)]
pub struct Instant {
    ticks: i64,
}

it fails because Format is not implemented for i64:
error[E0277]: the trait bound `i64: defmt::Format` is not satisfied

It would be great to be able to print 64-bit integers.

Would also be nice to have i128/u128 while at it.


What does "The rules can include up to 5000 users per policy" mean?

The documentation mentions "The rules can include up to 5000 users per policy.". Can you elaborate what this limitation means?
An auto assignment policy can have multiple Rules. If I have to assign a Package to more than 8000 eligible users, is the recommendation to create two rule for the same package to circumvent the 5000 limit? Or does it mean something else?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3abca3ac-e865-30f7-af10-88a8bbb28334
Version Independent ID: 37220ae8-c01b-4243-abd6-761cd7958f67
Content: Configure an automatic assignment policy for an access package in entitlement management - Microsoft Entra - Microsoft Entra ID Governance
Content Source: docs/id-governance/entitlement-management-access-package-auto-assignment-policy.md
Service: active-directory
Sub-service: compliance
GitHub Login: @markwahl-msft
Microsoft Alias: owinfrey

@MithunChopda
Thanks for your feedback! We will investigate and update as appropriate.

@MithunChopda
The limitation of 5000 users per policy means that a single policy can only evaluate up to 5000 users to determine if they meet the criteria for automatic assignment. If you have more than 5000 users who need to be evaluated, you will need to create additional policies with different rules to cover all the users.
In your case, if you have to assign a package to more than 8000 eligible users, you can create two rules for the same package to circumvent the 5000 limit. You can create two policies with different rules that cover different sets of users, and both policies can be assigned to the same access package.
It's important to note that during this preview, you can have at most one automatic assignment policy in an access package. So, if you need to create multiple policies for the same access package, you will need to wait until this limitation is lifted.

@MithunChopda
We are going to close this thread as resolved but if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.


Update Composer dependencies (2023-06-04-00-13)

Visual regression test passed!
View the visual regression test report


bufio.Reader#ReadLine() returns a wrong result when reading a long line with 1 million chars

Go version
Go 1.21 (go.dev/play)
Output of go env in your module/workspace:
Go 1.21 (go.dev/play)

What did you do?
https://go.dev/play/p/W_LvqY2Qu84
func main() {
	reader := bufio.NewReader(strings.NewReader("abcdefghijklmnopqrstuvwxyz" + strings.Repeat("a", 1000000)))

	line, isPrefix, _ := reader.ReadLine()

	// "abcdefghijklmnopqrstuvwxyz" => correct
	fmt.Printf("Prefix of 'line' after the first call to ReadLine() %v\n", line[:26])

	for isPrefix {
		var tmp []byte
		tmp, isPrefix, _ = reader.ReadLine()
		line = append(line, tmp...)
	}

	// TODO: Why not "abcdefghijklmnopqrstuvwxyz" ???
	fmt.Printf("Prefix of 'line' after complete reading a line %v\n", line[:26])

	fmt.Println(len(line)) // 1000026
}

What did you see happen?
Prefix of 'line' after the first call to ReadLine() [97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122]
Prefix of 'line' after complete reading a line [97 97 97 97 97 97 97 97 97 97 97 97 97 97 97 97 97 97 97 97 97 97 97 97 97 97]
1000026

What did you expect to see?
Prefix of 'line' after the first call to ReadLine() [97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122]
Prefix of 'line' after complete reading a line [97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122]
1000026

ReadString() works correctly
https://go.dev/play/p/Y_PiQYJzEgZ
package main

import (
	"bufio"
	"fmt"
	"strings"
)

func main() {
	reader := bufio.NewReader(strings.NewReader("abcdefghijklmnopqrstuvwxyz" + strings.Repeat("a", 1000000)))

	// This only works on Windows (\r\n), Unix (\n)
	// TODO: how to handle Mac's EOL, which is '\r'?
	line, _ := reader.ReadString('\n')
	line, _ = strings.CutSuffix(line, "\n")
	line, _ = strings.CutSuffix(line, "\r")

	// "abcdefghijklmnopqrstuvwxyz" => correct
	fmt.Printf("Prefix of 'line' %v\n", line[:26])

	fmt.Println(len(line)) // 1000026
}

I am new to Go, so if I am doing smt wrong, please help me correct my code. Thanks!

The returned buffer is only valid until the next call to ReadLine

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.
For questions please refer to https://github.com/golang/go/wiki/Questions

The returned buffer is only valid until the next call to ReadLine

Oh, thanks. I thought that it's a bug. But it's not.


Implementing Debug on derived Diff

The resulting Diff struct from using the derive macro does not implement Debug, it would be nice for, debugging...

Howdy! This is supported via the attr attribute on the original struct or enum, it looks like this:
#[derive(Debug, PartialEq, Diff)]
#[diff(attr(
    #[derive(Debug, PartialEq)]
))]
struct MyStruct {
    ...
}


Linter not noticing changes

Hi, I've installed the verilog linter using the package market directly from atom and had iverilog installed directly from the website. I'm not seeing any warnings/errors pop up when I edit my .vl file. Does this package rely on anything else besides the base linter?

+1

Hi @JmzQ,
I know this is a really late reply, but I think your issue may be that .vl is not a recognized file extension for Verilog. This package uses the "source.verilog" grammar scope, which is probably defined through language-verilog. Since this file type is not recognized by Atom as being Verilog, it is not triggering the linter.


802.11w Management Frame Protection blocking Bonjour / autoconf

On  OpenWrt 19.07.3 r11063-85e04e9f46 as soon as I enable 802.11w Management Frame Protection on the interface where bonjour devices connect, bonjour traffic is blocked. I am using Tivoli Audio Art speakers and Raspberry 4 with OMV 5.
As a consequence I also cannot use WPA3 which requires 802.11w Management Frame Protection to be enabled.

Nothing to do with LuCI GUI.


Update to Field Line Integration

Description
Addresses #(issue)
Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.  Please see CONTRIBUTING.md for more guidelines.
Type of change
Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality
to not work as expected)
This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration

Test A
Test B

Test Configuration:

Operating system
Version number
Any details about your local setup that are relevant

Checklist:

[ ] Make sure you are merging into the develop (not master) branch
[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] Add a note to CHANGELOG.md, summarizing the changes

I hit a button somewhere? Not sure what but I wasn't trying to delete this.


Question regarding decrease in vulnerability count after upgrading to version 9 of dependency-check

I have noticed a significant decrease in the number of vulnerabilities detected after the upgrade, even though the scanned JAR files and the scanning environment remained the same.
Prior to the upgrade, in version 8, the scan reports consistently highlighted a higher number of vulnerabilities compared to the recent version 9. To provide a clearer picture, I have attached two screenshots:

and

Could you explain the reasons behind this decrease in vulnerability count? Are there any specific changes or improvements in version 9 that could have affected the detection algorithm or the way vulnerabilities are reported?

Without more details on which vulnerable dependency was no longer identified, which CVEs are not being reported. Also, is the missing dependency now reported as a related dependency?


Reasonable feature description missing for the built-in Testing Editor Contributions extension

Testing #127368

This extension no longer does anything, I'll just delete it during debt week


Fix for #25. Added CopyTo methods to IStream

Sorry to get this in after it looks like you already cut a release, but I figured while I had the patient open I'd add this stuff in.

No problem.


adds message in send_token

Tron allows users to add a message when sending tokens.

Codecov Report

Merging #29 into master will decrease coverage by 0.03%.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##           master     #29      +/-   ##
=========================================
- Coverage   29.53%   29.5%   -0.04%
=========================================
  Files          32      32
  Lines        1801    1803       +2
  Branches      374     375       +1
=========================================
  Hits          532     532
- Misses       1268    1270       +2
  Partials        1       1

She is not needed now.


Move compose expand/collapse button into text area

As part of the compose box redesign, we should move the compose expand/collapse button into the text area.

This issue is part of #24878.

Live demo with the source code on Repl.it. Here is the decomposed source code archive:
compose-decomposed.zip
The css code is split to decomposed areas but all the js code is in a single file. The file isn't big so it is easier to follow the logic of interactions between html and js.

@zulipbot claim

I would like to work on this issue.

hey @alya , if the issue is not resolved ,i can work on this

hello , if the issue is not resolved yet  ,i can work on this

@zulipbot help wanted i want to claim

@zulipbot claim


Ethan: Watch vegawebtasarim.com

Ethan requests the watch of the watch_keyword vegawebtasarim\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

vegawebtasarim\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


[macOS] pytest creates a notification that cannot be cleared from notification center

Desktop Notifier version: 5.0.0 (current master)
Python version: 3.12.4
Operating System: macOS 13.6.7 (Ventura)

Description
Each time I run pytest on the main branch all the tests pass but my notification center ends up with a notification that does not respond to any kind of user interaction, including attempts to clear it both with the top left X on the individual notification as well as the "Clear All" button on the folded stack of notifications.
Here's a screenshot:

One run of pytest = one more unclearable "Et tu, Brute?" notification so the above screenshot shows the result of 8 runs of pytest.
I ran into something like this before but figured it was my fault and ignored it... eventually after some amount of time (24-48 hours, maybe?) the stuck notifications disappeared. Have not yet restarted the machine since this happened so not sure if that might also clear them.
Note that this only happens running pytest and only the pictured notification without any buttons or reply options. In production usage things are great.

this seems to be fixed


Long decimal values showing for some entities

System Health details
System Information

version
core-2024.11.3

installation_type
Home Assistant OS

dev
false

hassio
true

docker
true

user
root

virtualenv
false

python_version
3.12.4

os_name
Linux

os_version
6.6.54-haos

arch
x86_64

timezone
Europe/London

config_dir
/config

Checklist

[X] I have enabled debug logging for my installation.
[X] I have filled out the issue template to the best of my ability.
[X] This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
[X] This issue is not a duplicate issue of any previous issues..

Describe the issue
I am seeing long decimal values with the new release (2024.11.3) which I have not noticed with the prior release
This shows up for a mix of brands and not all of the stations with the same brand have the issue.  I see this for both B7 and E10 .. more B7 than E10
I am guessing this may be a data source issue but wanted to raise it in case some rounding could be added to the integration.
Although this picture only shows B7 with the issue there are some E10 stations further down the list

Example extracts from developer tools
sensor.asda_xxxxx
Asda xxxxx
Attributes:
id: asda_gcp32gjrtws3
name: Asda xxxx
address: xxxxxxx
postal_code: xxxxx
latitude: xxxxx
longitude: xxxxx
brand: Asda
available_fuels:
E10: 1.357
B7: 1.3969999999999998
fuel_details:
E10: {}
B7: {}
currency: GBP
last_updated: 2024-11-24T23:14:11.488777
next_update: 2024-11-25T23:14:11.660578
props:
source: asda
source_id: gcp32gjrtws3
prevent_cache_cleanup: true
E10: 1.357
B7: 1.3969999999999998
area: xxx
icon: mdi:gas-station
friendly_name: Asda xxxxx
Configuration info

Reproduction steps

view data received by the integration

...
Debug logs
n/a - data rather than code failure

Diagnostics dump
n/a - data rather than code failure

Hi,
This is down to the data source itself (and for the UK this is direct from the owner of the fuel station)
I'm not sure how best to approach this, or even if this is something done deliberately by the suppliers.
I don't want to add in functionality to round up as I want to leave the data intact. At the same time, like you, I do find it frustrating that when shown on tables it's far too long.

In the card you can set the display to a fixed number decimal point numbers. I'd imagine you'd want 3. This way the original figure from the supplier is not altered but your display is neater. I had the problem with distance but it'll work on any numeric display field  - Mine for E10.  Change the 3 in Fixed(3) to how many places you want shown

data: state
name: Price/l
prefix: £
modify: parseFloat(x).toFixed(3)

Thanks Both
@pantherale0 Many thanks for your fast response - I do agree with what you say
@stevephi59 Many thanks for your help with this and providing the code I needed to use - very helpful

Thanks both, I'm going to close this issue for now, but pin for future reference. Really need to wait to see what the CMA comes up with for consumer access to this data because the data sources might change entirely in the future.


Add Github workflow to test PRs

Used a modified version of sprigfuzzy.js (sprigfuzzy_workflow.js) with a GitHub workflow to automatically check for errors in games before merging.
Closes #520

I'm not totally sure how best to test an action so let's make some PRs with it.


Librespot crashes when it cannot find a soundcard

I would think that this bug is related to #50, with the possible added complication that I am running Librespot in a container. As @ashwinvandijk is in the referenced issue, I'm running Librespot in conjunction with snapserver; as a result this container has never had a sound card. Its been running fine for the last year or so but I recently updated to the latest version of everything (wasn't keeping track of version numbers when I did the update) and only now am I experiencing the issue. I thought at first that I could potentially passthrough the hosts sound card, but am banging my head against a poorly documented wall trying to get this working and to be honest I don't really want to as this will mean making it an unprivileged container (I think).
Here's a backtrace with the details:

librespot -n House -b 320 -c /cache
[2019-11-23T13:39:57Z INFO  librespot] librespot 9e2cfe3 (2019-11-06). Built on 2019-11-07. Build ID: QUjVRS3b
[2019-11-23T13:39:57Z INFO  librespot_core::session] Connecting to AP "gew1-accesspoint-a-xr5v.ap.spotify.com:4070"
[2019-11-23T13:39:57Z INFO  librespot_core::session] Authenticated as "deathcakes" !
ALSA lib confmisc.c:767:(parse_card) cannot find card '0'
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
ALSA lib confmisc.c:1246:(snd_func_refer) error evaluating name
ALSA lib conf.c:4528:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
ALSA lib conf.c:5007:(snd_config_expand) Evaluate error: No such file or directory
ALSA lib pcm.c:2495:(snd_pcm_open_noupdate) Unknown PCM default
thread '' panicked at 'The device doesn't support any format!?: DeviceNotAvailable', src/libcore/result.rs:999:5
stack backtrace:
[2019-11-23T13:39:57Z INFO  librespot_core::session] Country: "GB"
0:     0x55e18f597d7b - backtrace::backtrace::libunwind::trace::hfe5db90796807973
at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.29/src/backtrace/libunwind.rs:88
1:     0x55e18f597d7b - backtrace::backtrace::trace_unsynchronized::h34b865a835594335
at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.29/src/backtrace/mod.rs:66
2:     0x55e18f597d7b - std::sys_common::backtrace::_print::h527254ae44989167
at src/libstd/sys_common/backtrace.rs:47
3:     0x55e18f597d7b - std::sys_common::backtrace::print::he85dd5ddddf46503
at src/libstd/sys_common/backtrace.rs:36
4:     0x55e18f597d7b - std::panicking::default_hook::{{closure}}::h847a2eb38b396f14
at src/libstd/panicking.rs:200
5:     0x55e18f597a57 - std::panicking::default_hook::h2ca0f9a30a0e206b
at src/libstd/panicking.rs:214
6:     0x55e18f5984f0 - std::panicking::rust_panic_with_hook::hffcefc09751839d1
at src/libstd/panicking.rs:477
7:     0x55e18f598072 - std::panicking::continue_panic_fmt::hc0f142c930c846fc
at src/libstd/panicking.rs:384
8:     0x55e18f597f56 - rust_begin_unwind
at src/libstd/panicking.rs:311
9:     0x55e18f5b876d - core::panicking::panic_fmt::h2daf88b2616ca2b2
at src/libcore/panicking.rs:85
10:     0x55e18f174471 - core::result::unwrap_failed::had362399ced8ad70
11:     0x55e18f16f72a - rodio::engine::new_output_stream::h3852f1b741d35214
12:     0x55e18f15c29e - rodio::engine::play_raw::h5a53a0b0fb2f6e1b
13:     0x55e18f14cc15 - <librespot_playback::audio_backend::rodio::RodioSink as librespot_playback::audio_backend::Open>::open::h58977b1df0664a61
14:     0x55e18f140ee2 - librespot_playback::audio_backend::mk_sink::hcae3fb23489ef37f
15:     0x55e18f0ae841 - std::sys_common::backtrace::__rust_begin_short_backtrace::h195aa92dfb11796d
16:     0x55e18f0ad569 - std::panicking::try::do_call::h450011732fca44be
17:     0x55e18f5a04fa - __rust_maybe_catch_panic
at src/libpanic_unwind/lib.rs:82
18:     0x55e18f0a9184 - core::ops::function::FnOnce::call_once{{vtable.shim}}::h0439762fa91fa386
19:     0x55e18f588a3f - <alloc::boxed::Box as core::ops::function::FnOnce>::call_once::h42806b83647d4c79
at /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/liballoc/boxed.rs:746
20:     0x55e18f59f8d0 - <alloc::boxed::Box as core::ops::function::FnOnce>::call_once::h83c921c8e826dd1d
at /rustc/eae3437dfe991621e8afdc82734f4a172d7ddf9b/src/liballoc/boxed.rs:746
21:     0x55e18f59f8d0 - std::sys_common::thread::start_thread::h2613204ce513782e
at src/libstd/sys_common/thread.rs:13
22:     0x55e18f59f8d0 - std::sys::unix::thread::Thread::new::thread_start::h4570080769500bcd
at src/libstd/sys/unix/thread.rs:79
23:     0x7fad6f8324a4 - start_thread
24:     0x7fad6f35dd0f - __clone
25:                0x0 -
^C[2019-11-23T13:39:58Z ERROR librespot_playback::player] Player thread panicked!

Like I say I'm trying to get it to work by passing through a sound card to the container and I will let you know if I have any success with this.
Thanks for all the hard work on Librespot btw, its a great program - I appreciate my use case might be slightly obscure so no worries if its not something you want to support.

Not sure what your trying to do, but can't you just use a pipe to snapserver?

Yeah so I didn't include a bit of background - snapserver has been crashing and I suspected it was due to updating Librespot. I can't see any point where snapserver was having problems except when it invokes Librespot so I figured I'd try running it by itself and got this error. Then I found a similar one that wasn't resolved so I thought it might be the same thing!

I am not sure what librespot is supposed to do if there is no audio device present to playback on?
To test the other non playback parts, you can always pipe to /dev/null

That seems fair but like I say it has been working for a little while without throwing this error. If I pipe it to /dev/null I get the exact same trace.
I can't rule out that this is an issue with snapserver, I will carry on digging and let you know what I find out.
Thanks!

To be fair it shouldn't crash so this is a bug to fix. It's just not an interesting bug.

Hang on, the exact same crash when you use the pipe backend? That doesn't make sense. Can you provide the command line you used to pipe it to /dev/null?

Nope my mistake - didn't realise that --backend was specified. Looks like this bug can be closed, apologies for wasting your time. The issue likely lies with snapserver, I will take it up with them.


Feature/use notification

Requested in #643.

Notification.requestPermission() should already contain the prompt. there is no sense to add another one.

Also, there is this convention that websites first ask the user if they would want to allow the site to show notifications and only then trigger the permission grant UI, like this:

@streamich seemed to think there was a reason for an additional prompt.

@kevinnorris I was thinking about something more generic, like
useNotification({
  async doAskPermission () {
    return confirm('Would you like to see notifications?');
  }
});

not sure if it is good API.
@xobotyi the idea is, to prevent user from instinctively clicking "Block" in the permission dialog, many websites implement approach, where they first show user some dialog warning them that permission dialog is about to appear.


IdFix gives blank result when filtering to a single OU

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!
Please check out the Docs to see if your question is already addressed there. This will help us ensure our documentation covers the most frequent questions.

If you are reporting a security related issue, instead of submitting it here, please email<EMAIL_ADDRESS>to ensure it is properly handled to resolution.

Category

[ ] Enhancement
[X] Bug
[ ] Question
[ ] Documentation gap/issue

Version
Please specify what version of IdFix you are using: <IP_ADDRESS>
If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.
Expected / Desired Behavior / Question
I would like to filter IdFix to a single OU (OU=The Name Co,DC=tnc,DC=local) and see it return all the invalid objects in the OU I want to replicate that I see when I do not filter.
Observed Behavior
When I query using the defaults, all of the results come through and I see several invalid objects in the OU I want to filter on. I am having a problem filtering idfix to a single OU (OU=The Name Co,DC=tnc,DC=local) and its sub-OUs. When I query using the filter there are no results.
Steps to Reproduce
Run IdFix query after updating the filter variables. All are default except 'Filter:' containing 'OU=The Name Co,DC=tnc,DC=local' (without quotes). When I click query there are no results.
Suggestion: Add a dialog to select the OU from active directory VIA GUI to filter on rather than text. This would avoid the issue of getting the text wrong.

You
I am having a problem filtering idfix to a single OU (OU=The Name Co,DC=tnc,DC=local) and it's sub-OUs, but when I query the results are blank
Copilot
I’m sorry to hear that you’re having trouble with IdFix. When you’re using IdFix to query a specific Organizational Unit (OU) and its sub-OUs in Active Directory, you need to specify the distinguishedName of the OU1.
In your case, you should enter the value in the format OU=The Name Co,DC=tnc,DC=local2. If you’ve done this and are still getting blank results, it could be due to one of the following reasons:
There might not be any invalid attributes within the specified OU and its sub-OUs.
The user account you’re using to run IdFix might not have the necessary permissions to read the attributes of the objects within the specified OU.
If you’re sure there are objects with invalid attributes and you have the necessary permissions, you might want to try running IdFix again. If the problem persists, please provide more details so I can assist you better. 😊
You
Please tell me more about the filtering format in IdFix. Is 'OU=The Name Co,DC=tnc,DC=local' a valid filter?
Copilot
Yes, the filter ‘OU=The Name Co,DC=tnc,DC=local’ is a valid filter in IdFix. In IdFix, the filter value must be entered in the format OU=The Name Co,DC=tnc,DC=local1. This is known as the distinguishedName of the Organizational Unit (OU) in Active Directory1.
When you enter this value and select Query, IdFix will query for objects containing invalid attributes that will cause directory synchronization errors1. The scope of the query can be limited by entering a valid directory path in the Filter field to use as a start for the subtree search1.
Please note that only one starting point can be designated at a time2. The subtree point will be used for all successive queries until changed2. Deleting the value will reset the query to the whole forest1.
So, if you want to filter the query to the OU The Name Co’ and its sub-OUs in your domain ‘tnc.local’, you would enter ‘OU=The Name Co,DC=tnc,DC=local’ as the filter1. If a blank DataGrid is displayed after execution, then no errors were returned1, which means there are no invalid attributes within the specified OU and its sub-OUs that would cause directory synchronization errors3. 😊
You
Show me some examples of the text you would add to the IDFIX filter to include only a single OU and it's sub OUs.
Copilot
Sure, here are some examples of how you might specify an Organizational Unit (OU) and its sub-OUs in the IdFix filter. Remember, the format is OU=YourOU,DC=YourDomain,DC=com:
If you have an OU named “Marketing” in a domain named “contoso.com”, you would enter:
OU=Marketing,DC=contoso,DC=com
If you have an OU named “Sales” under a parent OU named “Departments” in a domain named “fabrikam.com”, you would enter:
OU=Sales,OU=Departments,DC=fabrikam,DC=com
If you have an OU named “HR” under a parent OU named “UK” under another parent OU named “Europe” in a domain named “adventure-works.com”, you would enter:
OU=HR,OU=UK,OU=Europe,DC=adventure-works,DC=com
Please replace “YourOU”, “YourDomain”, and “com” with your actual OU name and domain information. The DC (Domain Component) part of the distinguishedName should match your domain’s Fully Qualified Domain Name (FQDN). 😊
You
What if there is a space in the name of the OU?
Copilot
If there is a space in the name of the Organizational Unit (OU), you can still include it in the filter in IdFix. Just make sure to include the space in the OU name. For example, if you have an OU named “Human Resources” in a domain named “contoso.com”, you would enter:
OU=Human Resources,DC=contoso,DC=com
Spaces and other special characters are allowed in OU names in Active Directory, and they should be included as is when specifying the OU in tools like IdFix. 😊
You
Why does my OU filtered IdFix query blank?
Copilot
If your IdFix query is returning blank results, it could be due to one of the following reasons:
No Invalid Attributes: There might not be any invalid attributes within the specified Organizational Unit (OU) and its sub-OUs1. IdFix queries all objects with a filter for applicable attributes1. If a blank DataGrid is displayed after execution, then no errors were returned1. This is a good thing1.
Insufficient Permissions: The user account you’re using to run IdFix might not have the necessary permissions to read the attributes of the objects within the specified OU2. You need to have read/write access to your on-premises Active Directory objects to use IdFix2.
Incorrect Filter Format: The filter value must be entered in the format OU=myOu,DC=Contoso,DC=com1. If there is a space in the name of the OU, include the space in the OU name2. Only one starting point can be designated at a time1. The subtree point will be used for all successive queries until changed1. Deleting the value will reset the query to the whole forest1.
If you’ve checked all of these and are still getting blank results, you might want to try running IdFix again. If the problem persists, please provide more details so I can assist you better. 😊
You
I have used the proper filter format for specifying the OU in IdFix where there are multiple invalid attributes but the query is still blank. What did I do wrong? The default query returns hundreds of objects in this OU and its sub-OUs
Copilot
I’m sorry to hear that you’re still having trouble with IdFix. If you’re sure that you’ve entered the filter in the correct format and there are indeed objects with invalid attributes within the specified OU and its sub-OUs, then it’s quite unusual for the query to return blank results1.
Here are a few things you might want to check:
Permissions: Make sure the account you’re using to run IdFix has read/write permissions to your on-premises Active Directory objects2. You need these permissions to use IdFix2.
IdFix Version: Ensure you’re using the latest version of IdFix. Older versions might have bugs or compatibility issues that have been resolved in newer releases2.
Rule Set: Check if you’re using the correct rule set in IdFix. By default, IdFix uses the Multi-Tenant rule set1. If you’re an Office 365 Dedicated customer, you should use the Dedicated rule set1.
Filter Format: Double-check the filter format. It should be in the format OU=myOu,DC=Contoso,DC=com1. Make sure there are no typos or extra spaces.
Active Directory Replication: Ensure that Active Directory replication is working correctly. If there are replication errors, IdFix might not be able to see the latest changes2.
If you’ve checked all of these and the problem persists, it might be a good idea to reach out to Microsoft Support for further assistance. They have access to more resources and can help troubleshoot the issue in more depth. 😊

I was putting it in the wrong field!


From a GitHub Action create a button to code search for the action use

Related to #3008 :slightly_smiling_face:
From e.g. https://github.com/marketplace/actions/urlchecker-action to https://github.com/search?q=urlstechie%2Furlchecker-action+path%3A.github%2Fworkflows%2F+language%3AYAML&type=Code&ref=advsearch&l=YAML&l= (searching GitHub Actions workflow files that reference the action)

Maybe under "Links" like "Open issues" :thinking:

Sounds a "Used by" link. This makes sense and probably GitHub will add it themselves.
Try also sending this feature request to GitHub: https://github.com/contact

I sent the feature request to GitHub, but haven't heard back yet.
To clarify, would the feature also be welcome here?

I'll work on that and hopefully this time give you less work in my PR! :smile_cat:

Too bad one cannot add the version number to the code search :crying_cat_face: (because of the "@").

but I'll use "recently indexed" as a search order, which might help.


[REVIEW] GitHub profile

Github Profile Link:
https://github.com/Pranav016

Only one suggestion may remove the profile view count cause it's inaccurate

Some thoughts:

The profile views can be fake by refreshing and you'll get easy views, up to you if you want to remove it.
These two are not the same height, you can use table markdown to balance the height and width, that's what I did.

Reviewing on a live stream https://www.youtube.com/watch?v=w0ELpv3Z4Wk
Looks good, some thoughts:

profile view counter is not a great feature, we can all just refresh the page
tech skills icons look great, but some people might not know what they are, can you somehow add text to them (think of recruiters, HR etc)
stats boxes could be the same height
I think having a different photo in the banner to your GitHub profile would add more value

Reviewing on a live stream https://www.youtube.com/watch?v=w0ELpv3Z4Wk
Looks good, some thoughts:

profile view counter is not a great feature, we can all just refresh the page
tech skills icons look great, but some people might not know what they are, can you somehow add text to them (think of recruiters, HR etc)
stats boxes could be the same height
I think having a different photo in the banner to your GitHub profile would add more value

Thank you for the valueable feedback, will work on these pointers👍


Meghna Das

Due we close new issues on PR merge and voting is still possible on closed issues I will close this one.


Stack overflow while saving Backbone.js model

I have a simple Backbone.js model:
class Avia.Student extends Backbone.Model

Told you it was simple :-) Anyhow, I'm saving it in the following view (snipped for clarity):
class Avia.StudentView extends Backbone.View

  render: =>
    html = JST['views/student_view_template'](model: @model)
    @el.html(html)
    Backbone.ModelBinding.bind(@)
    $('#save').bind('click', @save)

  save: (e) =>
    e.preventDefault()
    @model.save(
        success: =>,
        error: =>
    )

When I click the save button, @save() is called, but fails with the following error (again, snipped for clarity as obviously it continues for a long time):
Uncaught RangeError: Maximum call stack size exceeded
Backbone.Events.trigger:117
_.extend._onModelEvent:635
Backbone.Events.trigger:117
_.extend._onModelEvent:635
Backbone.Events.trigger:117
_.extend._onModelEvent:635
Backbone.Events.trigger:117

I've tried commenting out Backbone.ModelBinding.bind(@), and I've ensured #save is unique by renaming it to #wooble and changing the associated bindings to match.
I've also tried using the very latest backbone.js from GitHub.
Still the problem persists :-/
(I've also asked this as a question over on StackOverflow because I initially suspected PEBKAC on my part.  I'm still not so sure it isn't.)

Sounds strange ... but also doesn't sound like a backbone problem. Perhaps the issue has something to do with this bit?
Backbone.ModelBinding.bind(@)

I think I came across to the same issue


dispatch firing multiple times inside useEffect hook

Say I have to use dispatch inside useEffect on initial render and then whenever my two state values  changes which are basically user action based ( Equivalent of cDM and cDU) and I code it like this
useEffect(
        () => {
            dispatch(fetchSalesPerf({ filter: 'monthly', duration: 'last3' }))
        },
        [tabIndex, duration ]
    );

Shouldn't this be a single dispatch call firing a single network request?
What I see is that I have multiple API calls for same endpoint flooding my network tab.
I don't have any setInterval in my action creators or epics. But still they go on.
Any way to mitigate this.  I'm linking an issue which is related to this. However, I know that source of trouble is dispatch and not useMappedState. What are your thoughts ?
#18

Qual a solução? Não entendi as soluções acima


Deleting "folded-in" directory with right-click/delete asks to delete parent folder instead

Issue Type: Bug
This is on a remote SSH folder. Not sure if that matters.
I created a folder "layouts" and under that another "Auth", then I decided to delete "Auth" and put an Auth.tsx directly in "layouts" instead. When I right click "Auth" and choose Delete, it shows a confirmation if I want to delete "layouts" permanently rather than the subdirectory "Auth".
Screenshots:

VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.19041
Remote OS version: Linux x64 4.15.0-74-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3930K CPU @ 3.20GHz (12 x 3202)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.94GB (19.14GB free)

Process Argv

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: REDACTED.REDACTED.dk

OS
Linux x64 4.15.0-74-generic

CPUs
QEMU Virtual CPU version 2.5+ (4 x 2294)

Memory (System)
5.41GB (1.71GB free)

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

vscode-react-typescript
inf
1.3.1

remote-containers
ms-
0.94.0

remote-ssh
ms-
0.48.0

remote-ssh-edit
ms-
0.48.0

remote-wsl
ms-
0.41.7

vscode-remote-extensionpack
ms-
0.19.0

debugger-for-chrome
msj
4.12.5

vscode-color
ans
0.4.5

npm-intellisense
chr
1.3.0

jshint
dba
0.10.21

vscode-eslint
dba
2.0.14

vscode-npm-script
eg2
0.3.10

quick-notes
Lia
1.3.2

vscode-cosmosdb
ms-
0.12.0

azure-account
ms-
0.8.8

pdf
tom
0.5.1

It happened again and this time I was able to repro and capture a video of it. This time the sequence was:

Move another file into the parent of the collapsed subfolder
Move the only file out of the collapsed subfolder
Right click the collapsed subfolder and click Delete

Selecting something else in the tree clears out the problem. That's probably why I couldn't repro last time.
Video here: https://youtu.be/_6171PDhzOI

@isidorn The problem here is the tree selection, check out the video.

Got it. You got mulitple selection in the explorer. With compresed items and multiple selection somehow the context is wrongly computed. Hard to repro, and every time I change the get context code something else breakts -> thus assigning to backlog. And can look into this if more users hit this.

I believe we might have fixed this issue. Can anyone reproduce using Visual Studio Code Insiders https://code.visualstudio.com/insiders/


Fix CMS_TOOLBAR_SIMPLE_STRUCTURE_MODE usage

The current usage is not consistent with the rest of the code

Please @FinalAngel review

@yakky LGTM - just to double check, this means the new structure board is the default for 3.2 or? (which we actually want)

Coverage remained the same at 29.187% when pulling 8f08f577d6bc124f2208bef21e3a369a21458491 on yakky:fix/simple_toolbar_setting into 06e50293a41a3b6df6b8de1847eda7bbb3027ed6 on divio:preview.


WIP added a provider for VarDumper

WIP

already exists https://github.com/flint/Brick/blob/master/src/Provider/DebugServiceProvider.php :+1:


Pass

There is currently no option to pass your turn.
That's fine. I don't think there should be. But there does need to be some sort of contingency for when a 0 is rolled, because so far as I can tell, no options will appear.

The code's in there, but I haven't seen a 0 be rolled yet. I can't close this until I know it works.

#77


Impossibility to check libraries

Type: Bug
The assistant cannot provide updated info about a library. It keeps telling me to use functions that are not available since modules' updates many years ago
Extension version: 0.23.0
VS Code version: Code 1.96.0 (138f619c86f1199955d53b4166bef66ef252935c, 2024-12-11T02:29:09.626Z)
OS version: Windows_NT x64 10.0.22635
Modes:

I can not reproduce this. Can you reproduce with latest version of VS Code Insiders and latest pre-release of Copilot Chat extension?
If yes, can you provide reproducible steps?


Swift 4.2

This adds compatibility for Xcode 10 and Swift 4.2, no big changes.

Hello guys, any update for this PR ?

@DwayneCoussement Thanks for the PR! @jhanzo I'm on it. Yesterday evening I updated Xcode and tried it out with SwiftMonkey and of course I got some weird errors when running the tests. I'll do my best to merge the PR and have a release today in the evening.

@DwayneCoussement I am facing some issues with testing SwiftMonkey on Xcode 10. When I reference the library using:
pod 'SwiftMonkey', :git => 'https://github.com/DwayneCoussement/SwiftMonkey.git', :branch => 'Swift4.2'

and then execute pod install and run the tests, I am getting errors like:
Library not loaded: @rpath/libswiftSwiftOnoneSupport.dylib
  Referenced from: /Users/wojciech/Library/Developer/Xcode/DerivedData/TestSwiftMonkey-cuhgvfztlhxtqfhactlejzeqoxgu/Build/Products/Debug-iphonesimulator/TestSwiftMonkeyUITests-Runner.app/PlugIns/TestSwiftMonkeyUITests.xctest/Frameworks/SwiftMonkey.framework/SwiftMonkey
  Reason: image not found)

This is happening as well when I merge your PR and also in the sample app (a new issue has been created).
What's crazy is that I know how to fix it. My UI test target references the generated Pods framework like that (this is configured automatically when running pod install):

I have no idea why it's grayed out but I assume it's not a good sign. Anyway if I manually drag 'SwiftMonkey.framework' from Products it will solve the issue.

This should be happening automatically and in my case the Pods_TestSwiftMonkeyUITests should include SwiftMonkey.
Have you been able to successfully test SwiftMonkey on Xcode 10, or is it just an issue on my side?

Alright, I think I found a possible reason for the errors I'm experiencing. The problem seems to be the New Build System that is enabled in Xcode 10 by default. CocoaPods has an issue open (https://github.com/CocoaPods/CocoaPods/issues/8073) which points to the new system and the  incremental build setting. I've tried setting the compilation mode to "Whole Module" but that didn't help. What did help was a switch to the Legacy Build System.
After I did this I was able to test your PR and everything works fine! Thank you 🎉

@jhanzo I've released version 2.1.1 of SwiftMonkey and SwiftMonkeyPaws!


Make a separate js file for javascript code.

Hi, I'll like to work on this.
Kindly assign it to me

Sure @Sammydepoj
Assigning this to you.

Thank you. Will start working on it asap

If the issue is still open, I would like to contribute, please assign it to me @VG-1

Hi @Ayush-Khandelwal28 , I've worked on the issue. Thank you.


Search for NonGatewayNodes with GatewayLabel absent

When searching for NonGatewayNodes, the function should search for the nodes with missing "submariner.io/gateway" label instead of the label with "false" value.
Filter out the nodes with "node-role.kubernetes.io/master" label as it doesn't allow to schedule the pods on it.

@tpantelis
Please, take a look.
I needed to modify the FindNonGatewayNodes function to meet the requirements.

Hi @dfarrell07 ,
Could you take a look at the patch, please?


Please add a license?

Would you mind adding a license to the project?

I never done that before.
Which license do I choose for "Do whatever you want with this but don't claim it is your own"?

Nevermind, it is the MIT one.
Thanks, done.

Thank you!


Full support for arch,machine & emulator settings

Sorry for new PR, couldn't seem to reopen #174
Add emulator setting support
Completes support from arch and machine when reading current status
Adds a new function newDomainDefForConnection that takes
a domainDef and populates with defaults from the current host
which is more sensible than guessing across distributions
Maps canonical machine types <> actual to avoid changes
Due to the way libvirt works if you specific machine types like pc,isapc
or q35 these get translated into 'canonical' forms, ie. the latest
version
When quering terraform will notice a change, as it would still be
looking for pc and will get something like pc-i440fx-2.9.
Code has been added to assume that if we see 'pc-i440fx-2.9' and it is
canonical for pc then we translate back to pc for terraform.
This could cause issues if you are specifically using pc-i440fx-2.9 as
the machine type in your terraform file.

Close and reopen as travis not actually getting to the tests, seen this a few times no idea why


Specify cache directory with TLDR_CACHE_DIR

What does it do?
Currently the cache will always live in the home directory. This
allows the user to specify a directory to store the cache in with the
TLDR_CACHE_DIR environment variable. If the environment variable is
not set, the default will still be the home directory.
Why the change?
Requested by #37
Also it's been too long since I got to write any C
How can this be tested?

Compile the app with this patch
Run TLDR_CACHE_DIR=/some/path tldr man and note that /some/path/.tldrc is populated with cache data
Run tldr man without the TLDR_CACHE_DIR variable and note that ~/.tldrc is populated with cache data

Where to start code review?
The gethome() function in utils.c
Relevant tickets?
#37
Questions?
Right now setting TLDR_CACHE_DIR to /some/path will result in populating a directory /some/path/.tldrc. Should this instead just put the cache data directly in /some/path and skip the "extra" directory?
Also is it worth computing the result of gethome() only once and caching it? I don't know if calls to getenv() are expensive.

I'd also save cache to XDG_CONFIG_HOME if it's set and TLDR_CACHE_DIR is unset.


FileField hidden

FileFields, such as the one used on the "Import" form for ModelAdmin, are not displayed, it looks like they have opacity set to 0 by this bootstrap rule in node_modules/bootstrap/scss/_custom_forms.scss:
.file input {
  min-width: 14rem;
  margin: 0;
  filter: alpha(opacity = 0);
  opacity: 0;
}

Is this fixed?

Yep, we added an opacity: 1 back for these fields.


Logging terminal is always focused

Note: for support questions, please use stackoverflow. This repository's issues are reserved for feature requests and bug reports.

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, see note at the top of this template.

What is the current behavior?
Logging terminal is always focused

What is the expected behavior?
It should be focused if the users chooses to.

What is the motivation / use case for changing the behavior?
UX

https://github.com/roemhildtg/vscode-arcgis-assistant/blob/master/src/lib/util/logging.ts#L16


between's "and" split like logical operator

Describe the bug
When using between ___ and ____, the line is always split before the and
To Reproduce
Use the between operator in a where clause, such as the following:
select
    radio,
    mcc,
    net as mnc,
    area as lac,
    cell % 65536 as cid,
    cell / 65536 as rnc,
    cell as long_cid,
    lon,
    lat
from
    towershift
where
    radio != 'CDMA'
    and mcc between 200 and 799
    and net between 1 and 999
    and area between 0 and 65535
    and cell between 0 and 268435455
    and lon between -180 and 180
    and lat between -90 and 90

Expected behavior
select
    radio,
    mcc,
    net as mnc,
    area as lac,
    cell % 65536 as cid,
    cell / 65536 as rnc,
    cell as long_cid,
    lon,
    lat
from towershift
where
    radio != 'CDMA'
    and mcc between 200 and 799
    and net between 1 and 999
    and area between 0 and 65535
    and cell between 0 and 268435455
    and lon between -180 and 180
    and lat between -90 and 90

Actual behavior
select
    radio,
    mcc,
    net as mnc,
    area as lac,
    cell % 65536 as cid,
    cell / 65536 as rnc,
    cell as long_cid,
    lon,
    lat
from towershift
where
    radio != 'CDMA'
    and mcc between 200
    and 799
    and net between 1
    and 999
    and area between 0
    and 65535
    and cell between 0
    and 268435455
    and lon between -180
    and 180
    and lat between -90
    and 90

Additional context
% sqlfmt --version
sqlfmt, version 0.5.0

sqlfmt -l 80 test.sql
1 file formatted.
0 files left unchanged.
test.sql formatted.

Thanks for the report, @WestComputing!
I agree with you that a single between ... and ... should fit on a single line if possible. Right now, sqlfmt doesn't try to distinguish between the and after a between and your typical boolean and.
I was going to propose using parens as a workaround, but unfortunately that introduces its own problems.
To fix this, we're going to need to use more context when either parsing or deciding to split a line before the and. I am leaning toward the latter, since we have a (much simpler) precedent for *. I will try to work a fix for this into the next patch release, but I don't have a timeline for that, yet. In the future, sqlfmt will probably have to get smarter about parsing complex chains of boolean operators.
Until then, you can use -- fmt: off comments as a workaround:
select
    radio,
    mcc,
    net as mnc,
    area as lac,
    cell % 65536 as cid,
    cell / 65536 as rnc,
    cell as long_cid,
    lon,
    lat
from towershift
where  -- fmt: off
    radio != 'CDMA'
    and mcc between 200 and 799
    and net between 1 and 999
    and area between 0 and 65535
    and cell between 0 and 268435455
    and lon between -180 and 180
    and lat between -90 and 90  -- fmt: on

Thanks for your speedy response, Ted!
In looking at your code, I didn't think it was going to be a quick fix for the reason you mentioned.
I appreciate your efforts!
-Julian


Create activities manually?

Hello,
First of all, thanks for the gem. I really appreciate your work. About my question, I'm designing some kind of announcement system and I want to create multiple activities. For example  I tried to do following;
PublicActivity::Activity.create!(
  trackable_id: 13,
  trackable_type: 'Announcement',
  key: 'shared.announcement',
  recipient_id: 136130,
  recipient_type: 'User'
)

But trackable and recipient fields set to nil (because of some callbacks?). As far as I understand, I need to do this;
PublicActivity::Activity.create!(
  trackable: Announcement.find(13),
  key: 'shared.announcement',
  recipient: User.find(136130)
)

But this means 2 extra SQL request per activity. How can I solve this? I tried to look for documentation but didn't find an answer.
Thanks!

I haven't looked into why this happens, but you can always do this as a hack:
PublicActivity::Activity.create!(
  trackable: Announcement.new(id: 13),
  key: 'shared.announcement',
  recipient: User.new(id: 136130)
)

Thanks! As an another workaround, I can make it via PublicActivity::Activity.new and save it.

@peyloride did you solve thie issue?

I will close it as solved, if it still happens we can reopen :)


updated message that helps run properly ConfigurationExporterTest on windows

What does this PR do?

At current time I am working on windows 11, and command provided ConfigurationExporterTest fails with error.
Updated command is working properly now, it wil be usefull for windows users :D
Checklist

[x] This is something else

[x] I have updated CHANGELOG.asciidoc

@elasticmachine run elasticsearch-ci/docs


nix-template: replace sha256 with cargoLock

Motivation for this change
Curious if Ofborg hates this.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Yep  error: cannot read '/build/store/196saixvir91aa01x5qasaywfc1js2h4-nix-template-0.2.0-src/Cargo.lock', since path '/build/store/lz1nf0657dqqf586yymym2rpzrx02j12-nix-template-0.2.0-src.drv' is not valid