Hacktoberfest: Request to make the repository eligible for Hacktoberfest

Hello @geekcomputers,
I hope this message finds you well. I am writing to suggest making this repository eligible for Hacktoberfest. I believe that this would attract a lot of good program inputs and could revolutionize the repository to a great extent.
Hacktoberfest is a month-long celebration of open source software run by DigitalOcean and is open to everyone in our global community. It encourages more participation in the open-source community, which grows bigger every year.
Please consider this request, and let's bring more contributors to geekcomputers/Python.
Best regards,
Nitkarsh Chourasia

Great initiative @NitkarshChourasia

Thanks 🙏
On Thu 28 Sep, 2023, 8:19 PM Sarayu Sree Padala, @.***>
wrote:

Great initiative @NitkarshChourasia https://github.com/NitkarshChourasia
—
Reply to this email directly, view it on GitHub
https://github.com/geekcomputers/Python/issues/1985#issuecomment-1739424904,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVTTXYF6WNBJ5VTAWDYLDW3X4WE6BANCNFSM6AAAAAA5JNGAP4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Email and Slack notifications

Orchest currently supports notifying an external HTTP endpoint through webhooks, which serves a variety of use cases. However, we would like to add email notifications as well.
Although Slack notifications can easily be served with webhooks, we would like to document this common use case so that users don't have to figure everything out.

Example on how to set-up incoming webhooks in Slack: https://slack.com/help/articles/115005265063-Incoming-webhooks-for-Slack

Thinking about this a bit more, Slack incoming webhooks expect a payload with a specific structure, which can't be changed from the Orchest side. Maybe a payload customization functionality like the one Read the Docs has would serve multiple use cases:
https://docs.readthedocs.io/en/stable/build-notifications.html#custom-payload-examples

Just checked whether an external workflows tool could turn a custom webhook into a trigger:

Zapier: not in the free plan https://zapier.com/help/create/code-webhooks/send-webhooks-in-zaps
Automate.io: not in the free plan https://automate.io/integration/webhooks
IFTTT: available in the free plan https://ifttt.com/maker_webhooks/triggers/json_event but to parse the JSON body one needs a Pro+ plan https://help.ifttt.com/hc/en-us/articles/4405029291163-Parsing-JSON-body-with-filter-code

Maybe having some "make human readable" flag for webhooks could have a good ROI. What I mean here is that when sending a notification to slack or discord we simply dump the json as the text part of the payload, allowing payloads to be human readable instead of json would make for a good ROI when it comes to improving the experience.
See the logic of post_process_payload in services/orchest-api/app/app/core/notifications/webhooks.py

For reference, this is the code fragment @fruttasecca is referring to:
https://github.com/orchest/orchest/blob/762b6e689dff48430d8953bc1bd94a29bb3e7417/services/orchest-api/app/app/core/notifications/webhooks.py#L174-L192
When I wrote my earlier comment I did not know that we were dynamically making some adjustments to the structure depending on the destination URL.
Apart from the fact that I can document this better, I'd love to find a balance between magic and flexibility here. In my mind, the perfect feature would be:

Orchest has some predefined JSON templates for Slack, Teams, Discord notifications (we implicitly have them now)
Such template is clearly visible in the UI
When the user types the URL of the webhook, the template will change accordingly
The user can modify that template in any way they want

If we try to hide too much complexity, we might be hindering the ability of power users or even just normal users to customize the appearance of their notifications, or adding dumping lots of options to the UI to support niche use cases.


Improves logging for revocation server errors

this improves logging for revocation server errors.  It does not yet fix the problem that the agent will fail silently if there's no connection to the revocation server.  this will require much more zmq development to implement a heartbeat.  i think that's outside the scope of this PR to just improve error handling

ok, this one is all squashed now too

not sure if all my squashing worked @lukehinds

not sure if all my squashing worked @lukehinds

Is this branch based off of master?  It looks like there's a lot of pycryptodomex->cryptography changes in here as well.

i think this is ready to merge.  can someone take a look?

I will take it for a test first thing in the morning, unless you're good to approve @jetwhiz ?


feat: upgrade to awesome dag-pb

needs:

[x] https://github.com/ipfs/interface-ipfs-core/pull/95

One bug, otherwise LGTM.

Thank you for reviewing @haadcode :)


ArangoDB support planned?

Any plans to support ArangoDB? This is their node.js driver: https://github.com/arangodb/arangojs

It is something I have worked on a little. No idea on future release date though


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#718 d2e49d2 Thanks @threepointone! - Validate party names

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Sending notifications using C# FirebaseAdmin 2.4.0 doesn't work. Invalid value at 'message.android.notification.event_time'

Sending notifications using C# with Nuget package "FirebaseAdmin" version 2.4.0 doesn't work.
ERROR: Invalid value at 'message.android.notification.event_time'.
Our currently working FirebaseAdmin version is 1.1.4 and that is using the legacy cloud messaging API. Because of the migration to the new API which need to happend before june 2024, we updated to the latest FirebaseAdmin 2.4.0 that uses the new api with versioning "/V1". We earlier used "SendAllAsync", but are now trying to use "SendEachAsync" do to deprecation.

Our current AndroidConfig looks like this:
Android = new AndroidConfig
{
    Notification = new AndroidNotification
    {
        ClickAction = "FLUTTER_NOTIFICATION_CLICK",
        ChannelId = "fcm_default_channel",
        Icon = "ic_notif",
        EventTimestamp = DateTime.UtcNow //Added afterwards cause of error but didn't resolve our issue.
    },
    CollapseKey = "type_a"
},

Somehow the EventTimestamp is not working properly. Any suggestions?

Anyone?

Actually, I believe I found the reason for this issue. It has to do with the time settings on your computer. One workaround is to change the time settings to English because, currently, if your time settings are set to a region with a different time format, like Europe, it sets event_time in a format like 2024-02-26T<IP_ADDRESS>7372000Z instead of 2024-02-26T07:00:58.787372000Z.
In Version 2.3.0 of the SDK, a commit was made: "Closes #153. Add additional FCM options for Android Notification #203." This changed in particular the FirebaseAdmin/FirebaseAdmin/Messaging/AndroidNotification.cs file.  In this commit, the following code is problematic:
private string EventTimeString
{
    get
    {
        return this.EventTimestamp.ToUniversalTime().ToString("yyyy-MM-dd'T'HH:mm:ss.ffffff000'Z'");
    }

    set
    {
        if (string.IsNullOrEmpty(value))
        {
            throw new ArgumentException("Invalid event timestamp. Event timestamp should be a non-empty string");
        }

        this.EventTimestamp = DateTime.Parse(value, CultureInfo.InvariantCulture, DateTimeStyles.None);
    }
}

In the setter method, CultureInfo.InvariantCulture is used, which employs a standard format for parsing the DateTime but is not used in the getter, which is the source of the problem. This omission causes event_time to use the local time settings instead, leading to the incorrect format. The getter should include CultureInfo.InvariantCulture to ensure consistent formatting:
return this.EventTimestamp.ToUniversalTime().ToString("yyyy-MM-dd'T'HH:mm:ss.ffffff000'Z'", CultureInfo.InvariantCulture);

This is actually an open pull request.
https://github.com/firebase/firebase-admin-dotnet/pull/329
I have even tried reaching out to google support to get some action on this one.
The fix is so simple. I wish a responsible could make sure this fix was pushed out.

To continue using this package I made a local copy of the repo, in file AndroidNotification.cs line 363 I changed
[JsonProperty("event_time")]
to
[JsonIgnore]
And now I can send messages again.
Of course this is not the right way to fix the problem, but nothing has been done since december 23...


Needs more manual pages

I defs thought this was for man and its not, I'm slightly disappointed.

Ha! Give it time. Docs are coming as I hack on it more.


[Docs] Add Threejslive to showcase

[ ] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Interesting site. Please put it the bottom of the list though - for the moment we're adding them "first come first served".

@mbrookes @oliviertassinari Updated showcase.js to move example to the bottom

@ekatzenstein You can also run npm run lint before uploading.

@mbrookes I ran 'npm lint' which uncovered radio button errors, but everything seems fine with this PR.

I'm closing that PR as has been inactive. Feel free to reopen it if you get a green build 🎉 .

@oliviertassinari I'm a little confused, was there a problem with this PR?

@ekatzenstein
/home/travis/build/callemall/material-ui/docs/src/app/components/pages/discover-more/Showcase.js

  102:5  error  Expected indentation of 2 spaces but found 4  indent

  107:4  error  Missing trailing comma                        comma-dangle


feat: add cmlm encoder

It adds universal cmlm encoder

@JoanFM , I am not sure, but it doesn't seem related with my rebase. I did another one, (it seems updated with git log) and it keeps throwing the same error.

@JoanFM , I am not sure, but it doesn't seem related with my rebase. I did another one, (it seems updated with git log) and it keeps throwing the same error.

Hey @carlosb1 , it seems a problem of a last commit that I squashed, I guess you trying to rebase is firing the problem again? Can you maybe create a fresh directly from master and copying these changes?
Sorry for the inconvinience

Hey @carlosb1 , it seems a problem of a last commit that I squashed, I guess you trying to rebase is firing the problem again? Can you maybe create a fresh directly from master and copying these changes?
Sorry for the inconvinience

Hey @carlosb1 ,
it looks really good, I think it is the idea to have a potential preprocessor
I do however would like to see a test where a preprocessor is applied.
Also, please bump the manifest version so that the CI and the tests are fired

The error should be there.

Hey @carlosb1 ,
it looks really good, I think it is the idea to have a potential preprocessor
I do however would like to see a test where a preprocessor is applied.
Also, please bump the manifest version so that the CI and the tests are fired

The error should be there.


Initial draft of SuperNova description

This looks good. I'll make another pass with probably some very minor comments. Meanwhile, can you add a link to this in the toplevel README?

This could maybe be a section for such design notes generally, then a bulleted list of contents and brief description, with this document being the only initial content of /notes.


add bnb_4bit_use_double_quant and low_cpu_mem_usage

Hi @haileyschoelkopf @guijinSON
The parameter bnb_4bit_use_double_quant determines whether or not to use double_quant to quantize the absmax of weight, see here.
The parameter low_cpu_mem_usage will accelerate the loading speed of the model significantly on both CPU and GPU.
Could you please help me review it? Thanks!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Disable logging

Thanks for this package! It has helped me with react-intl and authjs (I saw your message on StackOverflow).
Is it possible to add an option to disable logging? There's lots of logs like Changing destination between middlewares: http://localhost:3000/en (none) -> http://localhost:3000/en (rewrite). This won't be ideal when I release my app.
Thanks in advance!

Hello! Thanks for the issue, I'll add the new option soon!

Shipped in v0.4.0
Documentation - https://nimpl.tech/middleware-chain#custom-logger

Wow that was very fast! And the docs are beautiful, thanks for the amazing work 🙌

I greatly value those who describe issues and I try to solve all problems as quickly as possible. So thank you once again for sharing!)


Resizable

https://github.com/material-table-core/core/blob/9c2e755ac541b644d8d0f61761ba59366b37b50e/src/components/MTableHeader/index.js#L85
Ok I was playing around with resizable columns and find out this getCellStyles function does not use additionalWidth so what happens is when components rerender due to some changes, the size will reset and if you resize just a little it jumps to the size it should have.
And I don't understand the logic of resizing here so idk how to fix it

@pouryapb I can try to help but I'm with you (I'm not the original author) but it's very hard for me to understand some of the logic.
Maybe we can knock this one out together?

Also thanks for spending the time looking into it!

I dig deep in my code and I found that data about column width is in columns tableData and I give table the columns in state and this tableData in columns objects I don't get back, so when any state in my component changes, table reads columns again and loses that tableData. and my component got complicated and I can't find a way to separate material table from the rest. there are some components that open with actions in table (popovers and other stuff) 😞

Would you mind creating a sandbox? So basically when you resize a column, the tableData field is reset?

https://codesandbox.io/s/staging-cdn-t4rcp?file=/src/App.js
a very simple demonstration

after a week I finally had time to dig in code a little more!
tableData is actually there and it has the correct additionalWidth value, I think it's just not considered in first calculations. I'm just trying to make sense of the behavior, I still don't know where I need to make changes...

@pouryapb could you find the error?

@Domino987 No!

Could you look at data-manager.js in setColumn function? Not sure if that is the problem.

for some reasons I can't reproduce the error in demo file in the project, but I think at line 82 of data-manager.js this might fix the issue I have:
const tableData = columnDef.tableData || {         columnOrder: index,         filterValue: columnDef.defaultFilter,         groupOrder: columnDef.defaultGroupOrder,         groupSort: columnDef.defaultGroupSort || 'asc',         width,         initialWidth: width,         additionalWidth: 0,         ...columnDef.tableData,         id: index       };
so it checks if tableData is defined, if not makes it.

@pouryapb  I cannot reproduce that with v3 of material-table.
Can you update the the latest version and see of the error persists?

@Domino987 I still have the problem. some of the actions on my table open a popover and some open a drawer and that causes react to rerender and when it happens columns sizes will reset.

I am sorry, but since I cannot reproduce it in a sandbox with the latest version, there is no way I can help you with it, unfortunatly.


"findUser is not defined"

(node:26680) UnhandledPromiseRejectionWarning: ReferenceError: findUser is not defined
at C:\Users\Desktop\asdfohasdfiop\Discord.js-Bot-master\events\message.js:134:49
at C:\Users\Desktop\asdfohasdfiop\Discord.js-Bot-master\node_modules\mongoose\lib\model.js:4845:18
at processTicksAndRejections (internal/process/task_queues.js:77:11)
(Use node --trace-warnings ... to show where the warning was created)
(node:26680) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:26680) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

solved


Text-value for line is wrong when semicolon is used

[17:05:06] C:\Git\Profiler> $trace = Trace-Script { 1; 2 }
[17:06:20] C:\Git\Profiler> $trace.AllLines | ft

Percent HitCount Duration         Average          SelfDuration     SelfAverage      Name                                 Line Text Path
------- -------- --------         -------          ------------     -----------      ----                                 ---- ---- ----
    100        4 00:00:00.0000225 00:00:00.0000056 00:00:00.0000225 00:00:00.0000056 e6898893-8ded-4ee3-a620-a4c7761c1b25    1 {    e6898893-8ded-4ee3-a620-a4c7761c1b25

[17:06:22] C:\Git\Profiler> $trace.AllLines.CommandHits.Values | ft

Line Column HitCount SelfDuration     Text
---- ------ -------- ------------     ----
   1     31        1 00:00:00.0000048 {
   1     33        1 00:00:00.0000034 1
   1     36        1 00:00:00.0000034 2
   1     38        1 00:00:00.0000109 }

Bonus-question: should the hitcount on the line be 4 in this case ? The line was hit once even though there were 4 command hits.

I think I added if text.length -gt currenttextlenght, then replace it, in your code 1 is the same size as {, so it stays, I should check for '{' explicity as well I think.
This is because I don't know when I encounter which part of the code, I think I will first see the biggest part of the code on the second hit, where { is enter the sb, and then we get more of the sb content.
This worked better when we loaded the whole source from files, because there we get the whole line always.
$t=Trace-Script { 1; 2 } ; $t.Top50Duration | ft ; $t.Top50Duration[0].CommandHits.values | ft

These are the unique values we see per line (but I think I broke it in 3.0.0). I think I need to reconstruct the line better using the column as well.

Hitcount: yes. I tried to get rid of it, but if you do foreach then half of the time accounts for the } events, I was not sure how to get rid of that. I think we have HitCount  which is tracking all the commands on the line added, if we had HitPerUniqueCommand, then each should definitely have 1 in them. This should be in the CommandHits view

I forgot I keep all scriptblocks.


Incorrect dist/es result

Incorrect dist/es result
PropTypes is imported after it was used
Ex: dist/es/ArrowKeyStepper/ArrowKeyStepper.js
line: 201
children: PropTypes.func.isRequired,

line: 225
import PropTypes from "prop-types";

Would be nice to see this fixed


refactor(lib): Remove unused robot protocol

This removes the remnants of the unused "robot protocol",
which was previously used by the CLI, but has been superseded by IPC.
Change-Type: minor
Changelog-Entry: Remove unused robot protocol

previously used by the CLI, but has been superseded by IPC

LOL, replacing one TLA with another TLA, FTW! :slightly_smiling_face:


Xamarin.Forms PCL project not working

Can we add a PCL profile for nuget? We need only FFImageLoading.Forms.dll which is PCL compatible.

Could not install package 'Xamarin.FFImageLoading 1.1.5'. You are trying to install this package into a project that targets 'portable-net45+win+wp80+MonoTouch10+MonoAndroid10+xamarinmac20+xamarinios10', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.

Mmh that's quite weird I tested the Nuget in a Forms project and it used to work.
Maybe I tried only the shared project I think you can have both PCL and shared isn't it?

Yes, Forms project can be shared or PCL (PCL library for almost everything and native project for renderers etc).

It was a lot of pain but I have now a Nuget that should be OK for PCL project too: https://www.nuget.org/packages/Xamarin.FFImageLoading.Forms/1.1.6-alpha4

It still doesn't install. You have to add
portable-net45+wp8+wpa81+win8+MonoAndroid10+MonoTouch10+Xamarin.iOS10
as target for FFImageLoading.Forms.dll

That's weird cause on my XF PCL it did install.. Are you sure you tried the Alpha4 Nuget package?

Yes, I'm sure. Try to install package on library project (it's where App class of Xamarin.Forms resides), not platform specific project.
Something like:

It doesn't need any other file than FFImageLoading.Forms.dll (shared stuff)  - renderers are initialized through dependency injection in platform specific project)

Ok I found what happens. Package does work in XF PCL project but only if it has profile 49.
Since you use profile 78 it doesn't install. I will change that.

Yes, that's a default Xamarin.Forms project profile. Thanks!

Ok a new alpha is on Nuget that should work with profile 78: https://www.nuget.org/packages/Xamarin.FFImageLoading.Forms/1.1.6-alpha5

Works good! Can be closed :)


Broken voting key

https://pixelmon-servers.com/servers/6-NebulaMC doesnt give the key or log the vote

Fixed


Handle Generic 'Dub' as English Dubs

It's hard to tell what language the (Dub) implies, but CR seems to putting it on some episodes.
It looks like CR is doing this for English Dubs.

While this cannot be categorized to a dub language, it is clear that it should be hidden when all dubs are hidden.
This can be seen on https://www.crunchyroll.com/simulcastcalendar?date=2023-02-20

This has been resolved by the latest release


[tool_crash] FileSystemException: Exists failed, OS Error: The device is not ready., errno = 21

Command
flutter pub get

Steps to Reproduce

...
...
...

Logs
FileSystemException: Exists failed, OS Error: The device is not ready.
, errno = 21
#0      _Directory.existsSync (dart:io/directory_impl.dart:94:7)
#1      ForwardingFileSystemEntity.existsSync (package:file/src/forwarding/forwarding_file_system_entity.dart:43:33)
#2      ErrorHandlingDirectory.existsSync.<anonymous closure> (package:flutter_tools/src/base/error_handling_io.dart:479:22)
#3      _runSync (package:flutter_tools/src/base/error_handling_io.dart:573:14)
#4      ErrorHandlingDirectory.existsSync (package:flutter_tools/src/base/error_handling_io.dart:478:12)
#5      PubDependencies.isUpToDate (package:flutter_tools/src/flutter_cache.dart:104:57)
<asynchronous suspension>
#6      Cache.updateAll (package:flutter_tools/src/cache.dart:542:11)
<asynchronous suspension>
#7      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:1143:7)
<asynchronous suspension>
#8      FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1043:27)
<asynchronous suspension>
#9      AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#10     CommandRunner.runCommand (package:args/command_runner.dart:196:13)
<asynchronous suspension>
#11     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:284:9)
<asynchronous suspension>
#12     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#13     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:232:5)
<asynchronous suspension>
#14     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:62:9)
<asynchronous suspension>

[✓] Flutter (Channel stable, 2.2.3, on Microsoft Windows [Version 10.0.19042.1165], locale en-US)
    • Flutter version 2.2.3 at D:\Code\flutter
    • Framework revision f4abaa0735 (7 weeks ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, please use
      `flutter config --android-sdk` to update to that location.

[✓] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[✓] VS Code (version 1.58.2)
    • VS Code at C:\Users\Administrator\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 92.0.4515.131
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 92.0.902.73

! Doctor found issues in 2 categories.

Flutter Application Metadata
Type: app
Version: 1.0.0+1
Material: true
Android X: false
Module: false
Plugin: false
Android package: null
iOS bundle identifier: null
Creation channel: stable
Creation framework version: f4abaa0735eba4dfd8f33f73363911d63931fe03

closing as duplicate of https://github.com/flutter/flutter/issues/81146

i don't seem to understand the problem here!!
On Tue, Aug 17, 2021 at 11:43 AM Taha Tesser @.***>
wrote:

Closed #88339 https://github.com/flutter/flutter/issues/88339.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/88339#event-5167506976, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AVB3U3Z745AA7STITGVWNDLT5IOJZANCNFSM5CJGRG7A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.


fix: fail when input type has @protected directive

test: write .md test with input @protected
test: include original example types
test: load protected directive for input type
feat: add flag to check whether type is input or not
fix: fail when type is input
test: update snapshots

Issue Reference(s):
Fixes #1596
/claim #1596
Build & Testing:

[x] I ran cargo test successfully.
[x] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

[x] I have added relevant unit & integration tests.
[ ] I have updated the documentation accordingly.
[x] I have performed a self-review of my code.
[x] PR follows the naming convention of <type>(<optional scope>): <title>

Summary by CodeRabbit

New Features

Enhanced GraphQL schema capabilities with a new required property "implements" and added an "input" property to identify input types.

Enhancements

Improved validation logic by adding checks for protected input types.

Tests

Added tests to validate handling of protected input types in GraphQL schemas.

Documentation

Updated documentation in tests/execution/input-type-protected-error.md file.

Do you have a suggestion to accomplish this differently @tusharmath? I wasn't able to found the type name anywhere else, so I needed to search for them on config.types. Let me know if there's anywhere else I can found this value.

thanks @ologbonowiwi


Minor inconsistency regarding download size.

The main GitHub page still says Mithril is about 5 KiB gzipped. Meanwhile the "How is Mithril Different" page says it's about 12 KiB gzipped. In actuality it's about 8 KiB gzipped.

8.2 kb according to DevTools

Huh, you're right. Fixed


Allow variables to be used in Operation Chains

For example:
{
    "class": "GetElements",
    "input": "${input}",
    "view": {
        "edge1": {
           "preAggregationFilterFunctions": [{
            "selection": "count",
            "predicate": {
                 "class": "IsMoreThan",
                 "value": "${threshold}"
            }
           }]
         }
    }
}

This is tricky as it cannot deserialise into Java until the variable has been resolved. We may need to use a similar mechanism to how we do it in NamedOperations, where we store the OperationChain in json and resolve the variables before deserialising the operation.

Depends on #1860.

Another use case for this has been identified for reducing duplication in Operation chains.
A simple example is where an different value should be used within the chain based on true or false. At the moment this requires a duplication of the operations across the true and false branches, with the values hardcoded. With variable substitution, there would be no need for duplication in the chain or hardcoding.


Remove navigator comparison and redirect to Navigation guide

The new Navigation guide replaces the Navigator comparison doc. The server will redirect from navigator-comparison.html to navigation.html when this lands.

By analyzing the blame information on this pull request, we identified @caabernathy and @alvaromb to be potential reviewers.

Think of it, the earlier redirect was not going to work properly in the generated static site. I'm fine with keeping the navigator-comparison.html permalink and avoid dealing with redirects.

So is this PR still applicable since you mentioned you wanted to revert?

@caabernathy there is some content updates in this PR, but given the revert I think it makes more sense to split this into two new PRs.

See #8417


[CARBONDATA-3421] Fix create table without column with properties failed, but throw incorrect exception

Problem:
Create table without column with properties failed, but throw incorrect exception: Invalid table properties. The exception should be "create table without column."
Solution:
In CarbonSparkSqlParserUtil.createCarbonTable, we will do some validations like checking tblproperties, is column provided for external table so on. We can add one more validation here to check is column provided for normal table. If not, throw MalformedCarbonCommandException.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

[ ] Any interfaces changed?

[ ] Any backward compatibility impacted?

[ ] Document update required?

[ ] Testing done
UT is added.

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Can one of the admins verify this patch?

add to whitelist

Build Failed  with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3475/

Build Failed with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3678/

Build Failed  with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11742/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3480/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11748/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3683/

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder2.1/3502/

Build Success with Spark 2.3.2, Please check CI http://<IP_ADDRESS>:8080/job/carbondataprbuilder2.3/11773/

Build Success with Spark 2.2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder1/3707/

LGTM


[cda_pl] cannot download videos

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2<IP_ADDRESS>
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

For a free video:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.cda.pl/video/540114ae/vfilm']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 2.7.16 (CPython) - Linux-4.19.0-14-amd64-x86_64-with-debian-10.8
[debug] exe versions: ffmpeg 4.1.6-1, ffprobe 4.1.6-1
[debug] Proxy map: {}
[CDA] 540114ae: Downloading webpage
WARNING: unable to extract default player_json; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 806, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 827, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 532, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/cda.py", line 207, in _real_extract
    self._sort_formats(formats)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 1367, in _sort_formats
    raise ExtractorError('No video formats found')
ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

For a premium video:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://www.cda.pl/video/65105665c/vfilm', u'-u', u'PRIVATE', u'-p', u'PRIVATE']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 2.7.16 (CPython) - Linux-4.19.0-14-amd64-x86_64-with-debian-10.8
[debug] exe versions: ffmpeg 4.1.6-1, ffprobe 4.1.6-1
[debug] Proxy map: {}
[CDA] 65105665c: Downloading webpage
ERROR: This video is only available for premium users.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 806, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 827, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 532, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/cda.py", line 96, in _real_extract
    raise ExtractorError('This video is only available for premium users.', expected=True)
ExtractorError: This video is only available for premium users.

Description

Command used: youtube-dl -v https://www.cda.pl/video/540114ae/vfilm
OS: Linux Debian 10 (Buster)
Sample links:
free: https://www.cda.pl/video/540114ae/vfilm
premium: https://www.cda.pl/video/65105665c/vfilm
I've tested als with "-u" and "-p" arguments - ie. with my premium account credentials (my pass stars from " sign, but I've escaped the whole pass with ' signs), but it didn't work.
My python version is: 2.7.16
While testing downloading, no VPN or Proxy were active. Direct connection only.

You must provide PL proxy/VPN/SSH and account credentials for any work on this.

You must provide PL proxy/VPN/SSH and account credentials for any work on this.

Write me what location are You connecting from, I will check if it works from Your current location first.
Credentials for premium account will be sent later.

I've already checked that.

Ok, here's a 24h access to CG vpn service:

the app: https://www.cyberghostvpn.com/download/cg8/winold/cgsetup_en_jQWW8b8CRmbvrnjSNqM3.exe
where to send login/pass ?

Refreshing a problem. What do do next then ? Do You need additional data ? How cna I download videos from cda.pl ?


use static files  in html templates

Hi, i use Statik for css and js files and wondering if it possible to use compiled html files in templates. Like loginfile, _ := statikFS.Open("/tmpl/login.html")
tHeader, err := tHeader.ParseFiles(loginfile.data)
Thanks.

Couldn't you do something like:
s, err := fs.New()
f, err := s.Open("/tmpl/login.html")
b, err := ioutil.ReadAll(f)
t, err := template.New("login").Parse(string(b))

?

thanks for respond. now i'm using bindata_fs for that.

Closing this issue as it seems @Pechenn sorted this out.


Suggestion: can we make the dev container work with Podman

On a clean Ubuntu 20+ install with podman toolset used instead of docker, dev container startup fails. Once podman toolset is removed and docker is installed, dev container starts as expected. Is it possible to remove the dependencies on docker to expand to developers who do not want to use a paid for toolset?

@dariuszparys is looking into this and validates, what it would require.

Thanks for submitting this one. I had a brief look at this, in the case of podman you usually use it rootless, the changes to the devcontainer.json will result in one that will not start in a regular Docker environment. Here is a work in progress https://github.com/dariuszparys/chariott/blob/chore/podman-support-devcontainer/.devcontainer/devcontainer.json.
I tested this one on Fedora 36, podman rootless and it starts up fine, except for one error message as podman buildx doesn't support the version command. The is coming from the devcontainer cli toolset that is used in vscode. Beside that error the container is starting up fine with the changes
https://github.com/dariuszparys/chariott/blob/9782759e6d0985ccdcad781beb0725b7b84db54f/.devcontainer/devcontainer.json#L19
and
https://github.com/dariuszparys/chariott/blob/9782759e6d0985ccdcad781beb0725b7b84db54f/.devcontainer/devcontainer.json#L67-L69
That said, it does not start on a WSL2 installation that is using the default Docker Desktop integration due to the rootless nature. Docker with WSL2 integration does not support the syntax --userns=keep-id. Therefore, you would need to uninstall Docker Desktop on Windows and activate systemd support for WSL2 as well as install docker inside WSL2 as native runtime. Further you either isolate the container with a user namespace with --userns-remap or use the suggested way described here https://docs.docker.com/engine/security/rootless/ to have a rootless experience with docker as well. Anyway, the details are different, and you would end up with two separate devcontainer.json files.
Considering all this, I'm not sure how we would have a good out of the box experience after cloning the repo to start-up the devcontainer in vscode. We could provide distinct devcontainer files and have a configuration script to put in the correct one after questioning the dev which container engine is in use, but I feel that might be overkill. What do you think @dwhiteddsoft?

The only thing I can think of is to have a script that runs as part of the process that has a large flag/switch logic section based on CPU architecture and maybe platform (in the case of WSL2). I think when we finally get to the resolution of this issue we are going to need that anyways. @juliays and I are still bottoming out some of the ARM issues.

@dwhiteddsoft we updated the README including now some requirements and podman hints.


Does not work on series

Hi . Can it be made to work on series?
Example
https://tv.apple.com/us/show/anastasia-the-mystery-of-anna/umc.cmc.5uu89jcked7763y2qmfgdzjkx
Or how to get a link m3u8 ?

It has been discussed before on https://github.com/MichaelYochpaz/iSubRip/issues/12.
As I mentioned there, this would require some time-consuming code-rewrite, and I've yet to find a TV show that has additional subtitles other than CC.
The show you linked also has only "English (CC)" subtitles, which means there aren't any downloadable subtitles.
I prefer to invest the time I invest on this project in fixing / improving / implementing more useful features.
This is currently at a low priority and probably won't be implemented any time soon.
If you have any further questions / suggestions regarding this topic please use the existing issue I linked above.


[Docs] Remove outdated docs

Remove outdated docs, including:

docs/zh_CN which contains an outdated version of English docs
YARN version related docs
v1 job config examples

Please delete https://github.com/microsoft/pai/blob/xiongyf/remove-outdated-docs/docs/user/job_submission.md since it is outdated and will cause bugs. The new doc for job submission is https://openpai.readthedocs.io/en/latest/manual/cluster-user/quick-start.html .
There are some links to outdated doc in README.md:

deployment-related: such as single-box.md, distributed-deploy.md, how-to-generate-cluster-config.md, faq.md. They should be replaced by https://openpai.readthedocs.io/en/latest/manual/cluster-admin/installation-guide.html, https://openpai.readthedocs.io/en/latest/manual/cluster-admin/installation-faqs-and-troubleshooting.html
submit job: Replace old submission doc with https://openpai.readthedocs.io/en/latest/manual/cluster-user/quick-start.html.
storage: storage.md is for V1 schema. It should be replaced by https://openpai.readthedocs.io/en/latest/manual/cluster-user/how-to-manage-data.html
others

paictl-manual.md still mentions yarn quick-start config. I think https://openpai.readthedocs.io/en/latest/manual/cluster-admin/basic-management-operations.html#pai-service-management-and-paictl is a replacement.
Resource-Requirement I cannot find a proper doc for replacement. But this doc mentions hadoop and zookeeper, which has been removed.


Intercept OGC requests with basic auth by default

This is a solution for #315 to add basic auth credentials (based on geoserver properties) for each OGC request within the interceptor. In case the geoserver or certain services are not protected, this will not break anything.
The main class is BasicAuthHeaderRequest.java (extending our MutableHttpServletRequest), which will actually add the basic auth header. The credentials can be passed in the constructor, which may also be helpful in project solutions with more specific requirements.
The new classes in the de.terrestris.shogun2.util.interceptor.impl package are default implementations for shogun2 and use the credentials from the geoserver.user and geoserver.password properties. They can be seen as a demo on how to use the BasicAuthHeaderRequest class.
The webapp archetype has also been adapted to make use of the new default implementations.

Just a general question: Would it be meaningful to introduce a base implementation for OwsInterceptions? Like
class WmsRequestInterceptor extends OwsInterception implements WpsRequestInterceptorInterface {}

whereas in OwsInterception could have common functionality like a common interceptGetCapabilities method.

Thanks for your comments.
The whole formatting of these files was a crazy mix. I fixed that. Thanks for the hint @chrismayer
Regarding your idea to introduce a new base implementation: Yes. I think this would be possible here, but currently i don't see a real need as this will mainly change the class hierarchy. But feel free to open a PR ;-)
I'll merge now


Failed to obtain access token

I am trying to install this on my QNAP NAS. For this, I basically created a deployment on my linux PC and from there I picked the docker-compose file and fixed it for my NAS and installed it there. On the NAS I have an NPM reverse proxy to resolve subdomain and then the Nginx proxy which comes with this stack.
I am able to see the Sign in with OpenID page on outline with my URL. I get redirected to /uc and can login there, but I get authentication failure from outline. Here is the log message,
ERR Error during authentication | error=Failed to obtain access token stack=InternalOAuthError: Failed to obtain access token
    at OAuth2Strategy._createOAuthError (/opt/outline/node_modules/passport-oauth2/lib/strategy.js:423:17)
    at /opt/outline/node_modules/passport-oauth2/lib/strategy.js:177:45
    at /opt/outline/node_modules/oauth/lib/oauth2.js:191:18
    at ClientRequest.<anonymous> (/opt/outline/node_modules/oauth/lib/oauth2.js:162:5)
    at ClientRequest.emit (node:events:526:28)
    at ClientRequest.emit (node:domain:475:12)
    at Socket.socketErrorListener (node:_http_client:442:9)
    at Socket.emit (node:events:526:28)
    at Socket.emit (node:domain:475:12)
    at emitErrorNT (node:internal/streams/destroy:157:8)
    at emitErrorCloseNT (node:internal/streams/destroy:122:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)

Here is the log from Nginx
<IP_ADDRESS> - - [02/Mar/2023:11:31:51 +0000] "GET /auth/oidc HTTP/1.1" 302 5 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" "<IP_ADDRESS>"
<IP_ADDRESS> - - [02/Mar/2023:11:31:51 +0000] "GET /uc/oauth/authorize/?response_type=code&redirect_uri=http%3A%2F%2Fsubdomain.domain.com%2Fauth%2Foidc.callback&scope=openid%20profile%20email&state=9e386e6e1ebc8227&client_id=050984 HTTP/1.1" 302 0 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" "<IP_ADDRESS>"
<IP_ADDRESS> - - [02/Mar/2023:11:31:51 +0000] "GET /auth/oidc.callback?code=101f5f764c1140f28abcd0d56fedxxxx&state=9e386e6e1ebcxxxx HTTP/1.1" 302 69 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" "<IP_ADDRESS>"
<IP_ADDRESS> - - [02/Mar/2023:11:31:51 +0000] "GET /?notice=auth-error HTTP/1.1" 200 1158 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" "<IP_ADDRESS>"
<IP_ADDRESS> - - [02/Mar/2023:11:31:51 +0000] "POST /api/auth.config HTTP/1.1" 200 100 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" "<IP_ADDRESS>"
<IP_ADDRESS> - - [02/Mar/2023:11:31:53 +0000] "GET /static/service-worker.js HTTP/1.1" 200 11540 "https://outline.gauravk.in/static/service-worker.js" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36" "<IP_ADDRESS>"

Here is the nginx config
server {
  listen        80;
  client_max_body_size 100m;

  # Proxy requests to the bucket "outline" to MinIO server running on port 9000
  location /outline-bucket {
    include /etc/nginx/conf.d/include/proxy.conf;
    proxy_pass http://wk-minio:9000;
  }

  # Proxy any other request to the application server running on port 9001
  location / {
    include /etc/nginx/conf.d/include/proxy.conf;
    proxy_pass http://wk-outline:3000;
  }

  # Static file FOR OIDC Server
  location /uc/static {
    alias /uc/static_root;
  }

  # OIDC Server
  location /uc {
    include /etc/nginx/conf.d/include/proxy.conf;
    proxy_set_header SCRIPT_NAME /uc;
    proxy_pass http://wk-oidc-server:8000;
  }
}

I can see the auth code and state in the Nginx log, but it looks like these don't get passed to outline. I've spent 2 days trying to figure out what could be wrong. I will greatly appreciate any help in getting this to work!

Finally I found the problem. I am using SSL and the OIDC_USERINFO_URI and OIDC_TOKEN_URI were using http.


AUT70: Start shipping kubelet to AWS CloudWatch

This change

removes fluentd-cloudwatch-0.9.1.tgz and uses latest version (fluentd-cloudwatch-0.11.1.tgz). It uncompresses this compressed file and modifies the following template file.

daemonset.yaml file has two configurable volumeMounts and volumes. These items are needed to mount journal and dmesg because the kubelet writes to journald and daemonset.yaml should be similar to DaemonSet defined in https://raw.githubusercontent.com/aws-samples/amazon-cloudwatch-container-insights/master/k8s-yaml-templates/fluentd/fluentd.yaml.

updates image.tag from v1.3.2-debian-cloudwatch to v1.7.4-debian-cloudwatch-1.0 because we are using fluentd-cloudwatch-0.11.1.tgz.

overrides data to include four config files (fluent.conf, containers.conf, systemd.conf and host.conf) taken from https://raw.githubusercontent.com/aws-samples/amazon-cloudwatch-container-insights/master/k8s-yaml-templates/fluentd/fluentd.yaml provided by AWS CloudWatch documentation (https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Container-Insights-setup-logs.html). These config files use the following three log group names.

/aws/containerinsights/Cluster_Name/application: it contains all log files in /var/log/containers
/aws/containerinsights/Cluster_Name/host: it contains logs from /var/log/dmesg, /var/log/secure, and /var/log/messages
/aws/containerinsights/Cluster_Name/dataplane: it contains logs in /var/log/journal for kubelet.service, kubeproxy.service, and docker.service. Please note that kubeproxy is running in pod and will appear in the application group.

adds an environment variable called CLUSTER_NAME. FluentD configuration files need this variable to specify log group names.

removes an environment variable FLUENT_UID=0 because this is for v0.12 images and we do not use these images.

I have raised a separate pull request (helm/charts#18670) on fluentd-cloudwatch to get the changes to daemonset.yaml, README.md and values.yaml in. These changes will appear in the next version of fluentd-cloudwatch so that we will use the fluentd-cloudwatch directly without making changes to their template files.
I tested these changes in Sandbox cluster. There were kubelet log messages in AWS CloudWatch. It showed that the changes were working well.
Author: @adityapahuja

If you have raised a PR upstream, then it might be handy to add a link to the PR in the commit message so we can dig it out easily in the future when we do a "git blame" to remember why we forked/decompressed/vendored the chart

@chrisfarms : I have raised a pull request (https://github.com/helm/charts/pull/18670) on helm/charts repo and added it to the commit message.

I rebased which caused my commit to lose my signature. I have re-signed the commit.


ADF V2- Can we test a linked service connection via the python library?

In the UI, it is possible to test the connection of an already defined LinkedService

We are automating the creation of our pipelines using a mapping table and this library, and as part of our unit testing we test our code by checking if an object got created or not, however we have not been able to automate the testing of our linked service connection, is there a way to test the connection via this library?
The way we do it now is by creating a pipeline and datasets, the creation of  these objects would fail if a reference is not successfully linked to a database/adls/azure storage/etc.

@hvermis ?

These API-s are not available in our swagger/SDK-s, they are only used in our UI.


Feature request: Add a way to save the FTP credentials/details

Per project, so that I don't have to retype all my login details every time I want to transfer a file

This feature already exists, just close the dialog by clicking on "hide" and you can continue your work as long as you are logged in at Codiad.

Reopen if this answer does not fit your feature request.


[Utility] E2E Feature Path Template

Description
This PR introduces one new document related to end-to-end (E2E) features: E2E_FEATURE_PATH_TEMPLATE.md.
E2E_FEATURE_PATH_TEMPLATE outlines a well-defined process for adopting an end-to-end feature path approach, intending to make each feature/task easier to scope, reason about, design, and implement. It includes two main stages:

Feature Specification
Feature Implementation (moving from Proof of Concept to Minimum Viable Product and finally to Production)

It also provides tips and templates for creating GitHub issues and Origin Documents for scoping and tracking E2E features. The goal is to enable internal and external team members individuals to help with the implementation of the utility module.
Issue
Fixes #733
Type of change
Please mark the relevant option(s):

[ ] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Major breaking change
[X] Documentation
[ ] Other

List of changes

Added a list of all needed E2E features (to the best of our current knowledge)
Linked to #754 and #755

/reviewpad summarize

@bryanchriswhite @dylanlott  This is a first iteration and I plan on doing a self-review tomorrow. Don't prioritize it yet (unless you have capacity or are interested), but I submitted it for review to get some early feedback.

@bryanchriswhite @dylanlott I split out the template the list of features into two, so would appreciate if you guys can review this one.


Artifact llvm-fa57c7a6-almalinux-x64 contains install folder, which at least doubles its size.

I noticed this because for the other commit: b74e588e - install folder is not there and the archive size is only about 1 gigabyte.

Should be fixed in #5111, but the LLVM build needs to be re-triggered to upload a correct almalinux tarball.


Invalid "success" response from book_changes (possible race condition)

Issue Description
When querying for a recent ledger by index, sometimes the result doesn't match the expected format.
Steps to Reproduce
Make WebSocket API requests such as the following, replacing the ledger index with the most recent one:
{
  "id": "example_book_changes",
  "command": "book_changes",
  "ledger_index": 88376663
}

The problem is intermittent, so it may take some tries to reproduce. Be sure to keep updating the ledger index with the most recent one as new ledgers are closed.
Expected Result
The API should either return a response in the expected format or an error message.
Example valid response (with non-empty changes):
{
  "id": "example_book_changes",
  "result": {
    "changes": [
      {
        "close": "1303424095097822e-4",
        "currency_a": "XRP_drops",
        "currency_b": "rchGBxcD1A1C2tdxF6papQYZ8kjRKMYcL/BTC",
        "high": "1304070002477734e-4",
        "low": "1302405543037992e-4",
        "open": "1303084400776639e-4",
        "volume_a": "60000000",
        "volume_b": "0.000460371"
      }
    ],
    "ledger_hash": "45765B07A378A94FCB6CEDD3D498E0CC15C73468F5F15AAA779079E67A234EB9",
    "ledger_index": 88376645,
    "ledger_time": 770512422,
    "type": "bookChanges"
  },
  "status": "success",
  "type": "response"
}

Example expected error response if the ledger index is too high:
{
  "error": "invalidParams",
  "error_code": 31,
  "error_message": "Ledger index too large",
  "id": "example_book_changes",
  "request": {
    "command": "book_changes",
    "id": "example_book_changes",
    "ledger_index": 88376663
  },
  "status": "error",
  "type": "response"
}

Actual Result
In some cases the response claims to be a success but it contains the wrong data, apparently some sort of status update on the status of acquiring the requested ledger. Looks like a Ledger Request Object.
{
  "id": "example_book_changes",
  "result": {
    "hash": "63C34CA1EE6CD80B89A035E077A0266BF2AF8F4A5CC729D1B595940D304BC05A",
    "have_header": true,
    "have_state": false,
    "have_transactions": false,
    "needed_state_hashes": [],
    "needed_transaction_hashes": [],
    "peers": 8,
    "timeouts": 1
  },
  "status": "success",
  "type": "response"
}

Environment
Tested using the xrplcluster.com servers running 2.2.0-rc1, but I think this API hasn't been changed much if at all since #4212 two years ago so the problems probably exist in older versions.
The s1.ripple.com cluster mostly goes to Clio servers; I haven't been able to reproduce on there.

@mDuo13 thanks for flagging this issue. What is the correct expected response for this input?
Ledger index is not too high -- As indicated by the "have_header": true, field in the current behavior, this node is aware of the existence of this ledger. But it does not have the state or the transaction information pertaining to this ledger.
The node is in the process of acquiring this ledger from one of its peers. Hence, the specified ledger_index is not too high


2.2.0

@scottgearyau Thanks for pulling.
I'm merging and closing the pull requests, after test ok, I'll bump the version number.
Thanks again.
Thanks


Links to images are broken

Links to images are broken in AsciiDoc, because no anchor is generated on the corresponding image. Need to fix the visit_figure method (use the resolve_id subroutine to get the relevant XML ID).

Fixed by commit 23ace38

Pull request: https://github.com/asciidoctor/docbookrx/pull/59


Adjusting positioning and sizing of notification bar

@spadgett, @sg00dwin

Note:  in order to fit the notification drawer icon and the system status icon, I had to reduce the max width of the branding image from 230px to 196px.  OCP will need to be updated per https://gist.github.com/rhamilto/c5c671d4dba9da2b8b62ff3fe0ad9f41.  I opened https://github.com/openshift/online/pull/1408 to resolve the issue in Online.
IMPORTANT:  the following screenshots were taken with Chrome's "Toggle device toolbar" enabled, thus eliminating the scrollbar.  If you resize your browser window to 320px, the utility nav will wrap to the second line because the toolbar is present, thus consuming 15 additional pixels of horizontal space, which doesn't occur in a true mobile device since the scrollbar is painted above the UI.

TODO:

[ ] Consume pending upstream changes to make expanded drawer layout better at mobile.

@rhamilto I'm not sure if we should just truncate the name :( We might need alternative icons for origin and online as well if necessary. Or maybe scale it smaller?

@rhamilto I'm not sure if we should just truncate the name :( We might need alternative icons for origin and online as well if necessary. Or maybe scale it smaller?

ok.  seems like we should do what we do for OCP and stack vertically.
@sg00dwin, any chance you've got the source file (where fonts aren't converted to outlines) for the stacked SVG?

@rhamilto I do not have a source file for just text.
Looking on the brand product logo page I see Logotype_RH_OpenShiftContainerPlatform_wLogo_RGB_White.svg
(github doesn't support attaching .svg)

Updated to use a stacked logo.  Thoughts @spadgett, @sg00dwin?

In turns out we can squeeze "OPENSHIFT ORIGIN" and "OPENSHIFT ONLINE" in if we reduce the width of the image as well as the right padding on the system status icon.  We'll still need changes for OCP and Online, but I've documented those at https://gist.github.com/rhamilto/c5c671d4dba9da2b8b62ff3fe0ad9f41
@spadgett, I think this is ready for merge.

Thanks @rhamilto


Istio webhook config should use informer/watch to monitor caBundle

Currently, as a mitigation to https://github.com/istio/istio/issues/6069, the CA bundle in the webhook config is periodically checked and re-patched in case it becomes reset (by for example reapplying istio.yaml).
The mitigation is https://github.com/istio/istio/pull/6435
The periodic check should be converted to use informer/watch.

Is this still an issue?
If so, I'd like to help improve this :)

proposed fix: https://github.com/istio/istio/pull/8886


No WebJob for Azure Web App

Hi,
I migrated from Heroku to Azure. I need to run certain Python scripts (batch jobs) once or several times a day and I want to do so in the same codebase as my webapp. I'd be happy doing so in the same instance as my web app.
I have an Azure Web App but it does not contain any WebJobs option:

In the docs, WebJobs are shown as being after the "Scale out" option but this is what I have:

Please correct me if I'm wrong... My understanding is that Azure Web Apps are built on top of Azure App Services. It's not clear to me if that's the reason why it's missing or why it's not available or what I'm supposed to do. I'm overall confused as to how Web Apps  relate to App Service and Linux plan.
If I click option App Service plan from the Web app, it takes me to ASP-gliglishgroup-b7d1, a Linux plan. But I don't have any Webjobs option there either:

At the end of the day, my questions and remark would be:

Why is the option missing?
How am I supposed to run a scheduled Python job instead? Looking for a KISS solution.
The docs could be clearer, if only because they do show up as being part of Web apps in the breadcrumbs:

Thank you for the help!
Best,
Fabien

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 24523dbf-010f-b844-5ff0-88192eac8849
Version Independent ID: d7ef5962-d94c-96d0-bf08-1efffc6d402b
Content: Run background tasks with WebJobs - Azure App Service
Content Source: articles/app-service/webjobs-create.md
Service: app-service
GitHub Login: @msangapu-msft
Microsoft Alias: msangapu

@fabswt
Thanks for your feedback! We will investigate and update as appropriate.

Hi @fabswt, it's not currently available for Azure App Service on Linux. We understand that this is an important feature. Please stay tuned as we work to make to make Linux features in parity with Windows. We don't have any more information to share at this time. Thank you for your understanding #please-close

What's the recommended alternative?

Azure Functions with HTTP trigger would be a good alternative.
https://learn.microsoft.com/en-us/azure/azure-functions/functions-triggers-bindings

Thanks. I was short on time so ended up migrating my workers back to Heroku for now.


模版字符串的提取，如何定制格式？

示例：  "pages.index.sbyyslot": "失败原因：{slot1}"
我想定制的效果："pages.index.sbyyslot": "失败原因：%{slot1}"

我看了下源码没有相关配置，我自己改了下提了个pr

感谢代码贡献🎉

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
此 issue 已被自动锁定，因为关闭后没有任何近期活动。如果有相关 bug，请重新创建一个新 issue。


[BUG] test_get_orbits_from_slc_ids fails: "call not found"

Describe the bug
test_s1_orbits.py::test_get_orbits_from_slc_ids, a test that uses Mocker, fails for me with an AssertionError that says "call not found". I am not sure if this is a problem with the code or a problem with the test.
To Reproduce

Checkout the dev branch
Run the test RAiDER > test > test_s1_orbits.py > test_get_orbits_from_slc_ids
Raises AssertionError: download_eofs(['20150621T120220'], ['S1A'], save_dir='/tmp/pytest-of-garlic/pytest-5/test_aoi_without_xpts0', force_asf=True) call not found

Expected behavior
Test should pass if RAiDER is behaving correctly. If RAiDER is doing something wrong, then I am not able to tell what from this error.
Desktop

RAiDER git tag:

commit 4c413ad7475ca154638c87e98610571de41cb031 (HEAD -> dev, upstream/dev, upstream/HEAD)
Merge: 5b7ba07 a826e07
Author: Jeremy Maurer<EMAIL_ADDRESS>Date:   Fri Jul 5 16:27:39 2024 -0500

    Merge pull request #661 from jlmaurer/fix_gnss_download

    Bug fixes and unit test updates

OS: <IP_ADDRESS>-microsoft-standard-WSL2 x86_64

Additional context
Full error:
/mnt/g/Garlic/Documents/Code/GitHub/RAiDER/test/test_s1_orbits.py::test_get_orbits_from_slc_ids failed: self = <MagicMock name='download_eofs' id='140665354331408'>
args = (['20150621T120220'], ['S1A'])
kwargs = {'force_asf': True, 'save_dir': '/tmp/pytest-of-garlic/pytest-5/test_aoi_without_xpts0'}
expected = call(['20150621T120220'], ['S1A'], save_dir='/tmp/pytest-of-garlic/pytest-5/test_aoi_without_xpts0', force_asf=True)
cause = None
actual = [call(['20150621T120220'], ['S1A'], save_dir='/mnt/g/Garlic/Documents/Code/GitHub/RAiDER', force_asf=True), call(['20150621T120232'], ['S1A'], save_dir='/mnt/g/Garlic/Documents/Code/GitHub/RAiDER', force_asf=True)]
expected_string = "download_eofs(['20150621T120220'], ['S1A'], save_dir='/tmp/pytest-of-garlic/pytest-5/test_aoi_without_xpts0', force_asf=True)"

    def assert_any_call(self, /, *args, **kwargs):
        """assert the mock has been called with the specified arguments.

        The assert passes if the mock has *ever* been called, unlike
        `assert_called_with` and `assert_called_once_with` that only pass if
        the call is the most recent one."""
        expected = self._call_matcher(_Call((args, kwargs), two=True))
        cause = expected if isinstance(expected, Exception) else None
        actual = [self._call_matcher(c) for c in self.call_args_list]
        if cause or expected not in _AnyComparer(actual):
            expected_string = self._format_mock_call_signature(args, kwargs)
>           raise AssertionError(
                '%s call not found' % expected_string
            ) from cause
E           AssertionError: download_eofs(['20150621T120220'], ['S1A'], save_dir='/tmp/pytest-of-garlic/pytest-5/test_aoi_without_xpts0', force_asf=True) call not found

/home/garlic/miniforge3/envs/RAiDER/lib/python3.12/unittest/mock.py:1015: AssertionError

During handling of the above exception, another exception occurred:

mocker = <pytest_mock.plugin.MockerFixture object at 0x7fef337242c0>

    def test_get_orbits_from_slc_ids(mocker):
        side_effect = [
            [Path('foo_start.txt'), Path('foo_stop.txt')],
            [Path('bar_start.txt'), Path('bar_end.txt'),
             Path('fiz_start.txt'), Path('fiz_end')],
        ]
        mocker.patch('eof.download.download_eofs',
                     side_effect=side_effect[0])

        orbit_files = s1_orbits.get_orbits_from_slc_ids(
            ['S1A_IW_SLC__1SSV_20150621T120220_20150621T120232_006471_008934_72D8']
        )
        assert orbit_files == side_effect[0]
        assert eof.download.download_eofs.call_count == 2
        for dt in '20150621T120220 20150621T120232'.split():
>           eof.download.download_eofs.assert_any_call(
                [dt],
                ['S1A'],
                save_dir=str(Path.cwd()),
                force_asf=True
            )
E           AssertionError: download_eofs(['20150621T120220'], ['S1A'], save_dir='/tmp/pytest-of-garlic/pytest-5/test_aoi_without_xpts0', force_asf=True) call not found
E
E           pytest introspection follows:
E
E           Args:
E           assert (['20150621T120232'], ['S1A']) == (['20150621T120220'], ['S1A'])
E
E             At index 0 diff: ['20150621T120232'] != ['20150621T120220']
E             Use -v to get more diff
E           Kwargs:
E           assert {'force_asf':...itHub/RAiDER'} == {'force_asf':...ithout_xpts0'}
E
E             Omitting 1 identical items, use -vv to show
E             Differing items:
E             {'save_dir': '/mnt/g/Garlic/Documents/Code/GitHub/RAiDER'} != {'save_dir': '/tmp/pytest-of-garlic/pytest-5/test_aoi_without_xpts0'}
E             Use -v to get more diff

/mnt/g/Garlic/Documents/Code/GitHub/RAiDER/test/test_s1_orbits.py:173: AssertionError

Oops, I didn't mean to do that.


Implement SQLite support

Disk backed storage

SQLite runs in memory, and backs up its data store in files on disk. While this strategy works well for development, Heroku’s Cedar stack has an ephemeral filesystem. You can write to it, and you can read from it, but the contents will be cleared periodically. If you were to use SQLite on Heroku, you would lose your entire database at least once every 24 hours.

Even if Heroku’s disks were persistent running SQLite would still not be a good fit. Since SQLite does not run as a service, each dyno would run a separate running copy. Each of these copies need their own disk backed store. This would mean that each dyno powering your app would have a different set of data since the disks are not synchronized.

Instead of using SQLite on Heroku you can configure your app to run on Postgres.

https://devcenter.heroku.com/articles/sqlite3


[Snyk] Upgrade zod-to-json-schema from 3.23.2 to 3.23.3

Snyk has created this PR to upgrade zod-to-json-schema from 3.23.2 to 3.23.3.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.

The recommended version was released on 2 months ago.

Release notes

Package name: zod-to-json-schema

3.23.3 - 2024-09-09

3.23.2 - 2024-07-28

    from zod-to-json-schema GitHub release notes

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Manually updated to 3.23.5


Github Actions

Github actions will always run with green tick due to cache always being hit and it thinking there are no changes.:

Fixed.


HDDS-1217. Refactor ChillMode rules and chillmode manager.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
47
Docker mode activated.

_ Prechecks _

+1
@author
1
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1258
trunk passed

+1
compile
54
trunk passed

+1
checkstyle
23
trunk passed

+1
mvnsite
38
trunk passed

+1
shadedclient
828
branch has no errors when building and testing our client artifacts.

+1
findbugs
56
trunk passed

+1
javadoc
29
trunk passed

_ Patch Compile Tests _

+1
mvninstall
43
the patch passed

+1
compile
30
the patch passed

+1
javac
30
the patch passed

-0
checkstyle
19
hadoop-hdds/server-scm: The patch generated 9 new + 0 unchanged - 0 fixed = 9 total (was 0)

+1
mvnsite
34
the patch passed

-1
whitespace
0
The patch has 75 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1
whitespace
1
The patch 19849  line(s) with tabs.

+1
shadedclient
1110
patch has no errors when building and testing our client artifacts.

+1
findbugs
52
the patch passed

-1
javadoc
25
hadoop-hdds_server-scm generated 1 new + 5 unchanged - 0 fixed = 6 total (was 5)

_ Other Tests _

+1
unit
361
server-scm in the patch passed.

+1
asflicense
35
The patch does not generate ASF License warnings.

4174

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-558/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/558

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 88946f220c20 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 7f636b4

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/1/artifact/out/diff-checkstyle-hadoop-hdds_server-scm.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/1/artifact/out/whitespace-eol.txt

whitespace
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/1/artifact/out/whitespace-tabs.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/1/artifact/out/diff-javadoc-javadoc-hadoop-hdds_server-scm.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/1/testReport/

Max. process+thread count
467 (vs. ulimit of 5500)

modules
C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Except protected checkstyle warning, remaining all have been addressed.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
23
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
974
trunk passed

+1
compile
46
trunk passed

+1
checkstyle
19
trunk passed

+1
mvnsite
30
trunk passed

+1
shadedclient
659
branch has no errors when building and testing our client artifacts.

+1
findbugs
36
trunk passed

+1
javadoc
21
trunk passed

_ Patch Compile Tests _

+1
mvninstall
32
the patch passed

+1
compile
23
the patch passed

+1
javac
23
the patch passed

-0
checkstyle
14
hadoop-hdds/server-scm: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
mvnsite
28
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
690
patch has no errors when building and testing our client artifacts.

+1
findbugs
43
the patch passed

+1
javadoc
17
the patch passed

_ Other Tests _

-1
unit
87
server-scm in the patch failed.

+1
asflicense
25
The patch does not generate ASF License warnings.

2849

Reason
Tests

Failed junit tests
hadoop.hdds.scm.chillmode.TestSCMChillModeManager

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-558/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/558

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux bab87144a106 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 618e009

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/2/artifact/out/diff-checkstyle-hadoop-hdds_server-scm.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/2/artifact/out/patch-unit-hadoop-hdds_server-scm.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/2/testReport/

Max. process+thread count
467 (vs. ulimit of 5500)

modules
C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
25
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1003
trunk passed

+1
compile
47
trunk passed

+1
checkstyle
21
trunk passed

+1
mvnsite
33
trunk passed

+1
shadedclient
710
branch has no errors when building and testing our client artifacts.

+1
findbugs
40
trunk passed

+1
javadoc
25
trunk passed

_ Patch Compile Tests _

+1
mvninstall
34
the patch passed

+1
compile
25
the patch passed

+1
javac
25
the patch passed

-0
checkstyle
14
hadoop-hdds/server-scm: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)

+1
mvnsite
25
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
739
patch has no errors when building and testing our client artifacts.

+1
findbugs
46
the patch passed

+1
javadoc
21
the patch passed

_ Other Tests _

+1
unit
101
server-scm in the patch passed.

+1
asflicense
29
The patch does not generate ASF License warnings.

3031

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-558/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/558

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux dec4e4efb76b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 373705f

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/3/artifact/out/diff-checkstyle-hadoop-hdds_server-scm.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/3/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
27
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1042
trunk passed

-1
compile
42
server-scm in trunk failed.

+1
checkstyle
22
trunk passed

-1
mvnsite
27
server-scm in trunk failed.

+1
shadedclient
714
branch has no errors when building and testing our client artifacts.

-1
findbugs
26
server-scm in trunk failed.

+1
javadoc
26
trunk passed

_ Patch Compile Tests _

-1
mvninstall
21
server-scm in the patch failed.

-1
compile
21
server-scm in the patch failed.

-1
javac
21
server-scm in the patch failed.

+1
checkstyle
15
the patch passed

-1
mvnsite
22
server-scm in the patch failed.

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
728
patch has no errors when building and testing our client artifacts.

-1
findbugs
24
server-scm in the patch failed.

+1
javadoc
21
the patch passed

_ Other Tests _

-1
unit
25
server-scm in the patch failed.

+1
asflicense
28
The patch does not generate ASF License warnings.

2920

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/558

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux 81795de089fe 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c072458

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/artifact/out/branch-compile-hadoop-hdds_server-scm.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/artifact/out/branch-mvnsite-hadoop-hdds_server-scm.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/artifact/out/branch-findbugs-hadoop-hdds_server-scm.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/artifact/out/patch-mvninstall-hadoop-hdds_server-scm.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/artifact/out/patch-compile-hadoop-hdds_server-scm.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/artifact/out/patch-compile-hadoop-hdds_server-scm.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/artifact/out/patch-mvnsite-hadoop-hdds_server-scm.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/artifact/out/patch-findbugs-hadoop-hdds_server-scm.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/artifact/out/patch-unit-hadoop-hdds_server-scm.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/testReport/

Max. process+thread count
411 (vs. ulimit of 5500)

modules
C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/4/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
24
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1151
trunk passed

+1
compile
45
trunk passed

+1
checkstyle
20
trunk passed

+1
mvnsite
30
trunk passed

+1
shadedclient
763
branch has no errors when building and testing our client artifacts.

+1
findbugs
40
trunk passed

+1
javadoc
23
trunk passed

_ Patch Compile Tests _

+1
mvninstall
35
the patch passed

+1
compile
24
the patch passed

+1
javac
24
the patch passed

+1
checkstyle
15
the patch passed

+1
mvnsite
25
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
810
patch has no errors when building and testing our client artifacts.

+1
findbugs
45
the patch passed

+1
javadoc
19
the patch passed

_ Other Tests _

+1
unit
88
server-scm in the patch passed.

+1
asflicense
25
The patch does not generate ASF License warnings.

3274

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-558/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/558

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux cb3f416db718 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ddede7a

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/5/testReport/

Max. process+thread count
386 (vs. ulimit of 5500)

modules
C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/5/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1191
trunk passed

+1
compile
45
trunk passed

+1
checkstyle
20
trunk passed

+1
mvnsite
31
trunk passed

+1
shadedclient
751
branch has no errors when building and testing our client artifacts.

+1
findbugs
41
trunk passed

+1
javadoc
24
trunk passed

_ Patch Compile Tests _

+1
mvninstall
33
the patch passed

+1
compile
23
the patch passed

+1
javac
23
the patch passed

+1
checkstyle
15
the patch passed

+1
mvnsite
27
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
797
patch has no errors when building and testing our client artifacts.

+1
findbugs
45
the patch passed

+1
javadoc
20
the patch passed

_ Other Tests _

+1
unit
107
server-scm in the patch passed.

+1
asflicense
26
The patch does not generate ASF License warnings.

3326

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-558/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/558

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux f19be16d66b5 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ddede7a

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/6/testReport/

Max. process+thread count
349 (vs. ulimit of 5500)

modules
C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/6/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Thank You @nandakumar131  for the review.
I have addressed the review comments.

ChillModeExitRule
We can mandate the event handler adding logic of each and every ChillModeExitRule implementation by introducing an abstract abstract TypedEvent<T> getEventType() method in ChillModeExitRule class. Then we can make a call to this method from ChillModeExitRule constructor. This will mandate each and every rule to provide it's EventType and we can add its event handler in ChillModeExitRule.
public ChillModeExitRule(SCMChillModeManager chillModeManager,
    String ruleName, EventQueue eventQueue) {
  this.chillModeManager = chillModeManager;
  this.ruleName = ruleName;
  eventQueue.addHandler(getEventType(), this);
}

Done

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
63
Docker mode activated.

_ Prechecks _

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1409
trunk passed

+1
compile
45
trunk passed

+1
checkstyle
20
trunk passed

+1
mvnsite
33
trunk passed

+1
shadedclient
753
branch has no errors when building and testing our client artifacts.

+1
findbugs
46
trunk passed

+1
javadoc
26
trunk passed

_ Patch Compile Tests _

+1
mvninstall
36
the patch passed

+1
compile
23
the patch passed

+1
javac
23
the patch passed

+1
checkstyle
15
the patch passed

+1
mvnsite
26
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
784
patch has no errors when building and testing our client artifacts.

+1
findbugs
46
the patch passed

+1
javadoc
18
the patch passed

_ Other Tests _

-1
unit
84
server-scm in the patch failed.

+1
asflicense
24
The patch does not generate ASF License warnings.

3572

Reason
Tests

Failed junit tests
hadoop.hdds.scm.node.TestSCMNodeManager

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-558/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/558

Optional Tests
dupname  asflicense  compile  javac  javadoc  mvninstall  mvnsite  unit  shadedclient  findbugs  checkstyle

uname
Linux f9aae31b75bc 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c0427c8

maven
version: Apache Maven 3.3.9

Default Java
1.8.0_191

findbugs
v3.1.0-RC1

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/7/artifact/out/patch-unit-hadoop-hdds_server-scm.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/7/testReport/

Max. process+thread count
394 (vs. ulimit of 5500)

modules
C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-558/7/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.


Adding UI services

Description

Adding UIServices with FullscreenMessage.
Added createFullscreenMessage function to create the message with protocol FullScreenMessageUiInterface
Added MessageMonitor object in UIService to handle whether any message is displayed or not.
FullScreenMessage uses FullscreenUIHandler to handle show, dismiss and openUrl
FullscreenListenerInterface is used to listen for callbacks from FullscreenMessage.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@ravjain-adb I hope we can simplify the code here. For v5, because we have cpp and objc layers, we have to define tons of interfaces and services for the sake of that, and it made our code actually quite complicated. But for swift, we only have one layer, so I think there are several places we can simplify things. Here are some of my ideas:

We can get rid of UIService, extensions can directly create fullscreen message using the FullScreenMessage class.
Change MessageMonitor to a service, it is the one that owns a state. And for now, it only tracks if there is any messge being display, but later I think it is a good place where we can allow app injecting custom behaviors for messages.
Merge FullScreenMessage and FullScreenUIHandler class.
Remove FullscreenListenerInterface, we can add some new onShow/onDismiss methods to the  FullScreenMessage class which accepts closures as parameters.

@ravjain-adb I hope we can simplify the code here. For v5, because we have cpp and objc layers, we have to define tons of interfaces and services for the sake of that, and it made our code actually quite complicated. But for swift, we only have one layer, so I think there are several places we can simplify things. Here are some of my ideas:

We can get rid of UIService, extensions can directly create fullscreen message using the FullScreenMessage class.
Change MessageMonitor to a service, it is the one that owns a state. And for now, it only tracks if there is any messge being display, but later I think it is a good place where we can allow app injecting custom behaviors for messages.
Merge FullScreenMessage and FullScreenUIHandler class.
Remove FullscreenListenerInterface, we can add some new onShow/onDismiss methods to the  FullScreenMessage class which accepts closures as parameters.

+1

merging this into a feature branch so we can play around with it while we're working out the kinks


all: replace os.Setenv with T.Setenv in tests

TB.Setenv was added recently, but no changes have been submitted to update the tests.
Here is a list of all tests using os.Setenv (obtained using grep -F -l "os.Setenv" **/*_test.go):
std
crypto/x509/root_unix_test.go
go/build/build_test.go
go/internal/srcimporter/srcimporter_test.go
internal/execabs/execabs_test.go
net/http/transport_test.go
net/parse_test.go
os/exec/lp_unix_test.go
syscall/exec_unix_test.go
testing/testing_test.go
time/zoneinfo_test.go
time/zoneinfo_unix_test.go

cmd
cmd/cover/cover_test.go
cmd/go/go_test.go
cmd/go/internal/cache/cache_test.go
cmd/go/internal/generate/generate_test.go
cmd/go/internal/modload/query_test.go
cmd/go/internal/vcs/vcs_test.go
cmd/go/internal/work/security_test.go
cmd/internal/pkgpath/pkgpath_test.go
cmd/objdump/objdump_test.go

For the cmd module, however, no tests actually restore the original environment variable, so I will not touch them.
For the std module I plan to only use T.Setenv on this pattern:
defer os.Setenv(key, origValue)
os.Setenv(key, value)

There are some other cases like:

https://github.com/golang/go/blob/master/src/crypto/x509/root_unix_test.go#L84
https://github.com/golang/go/blob/master/src/crypto/x509/root_unix_test.go#L134
https://github.com/golang/go/blob/master/src/time/zoneinfo_unix_test.go#L16

I'm not sure if T.Setenv should be used in a sub test.
There are a few case when the environment variables are not restored, like testing/testing_test.go and net/http/transport_test.go, but probably it is ok.

There seems to be an issue in os/env_unix_test.go.
In  TestSetenvUnixEinval (https://github.com/golang/go/blob/master/src/os/env_unix_test.go#L25) Unsetenv is not called, and in TestExpandEnvShellSpecialVar (https://github.com/golang/go/blob/master/src/os/env_unix_test.go#L46) the error from Setenv is ignored.

In the end there were only a few cases where os.Setenv could be replaced with T.Setenv.


sum.golang.org: improve pseudo version regexp

link<EMAIL_ADDRESS>What did you expect to see?
something like this:
1328
github.com/xgfone/gconf v3.3.0+incompatible h1:Ka0ssV/5iMMf1YgQPR0lQGa6Yp6+e2Y8/P/jOgviCCk=
github.com/xgfone/gconf v3.3.0+incompatible/go.mod h1:v3VqEuUnjlVYVQxIhAobyFZ+8zEJWVEYfmNFaU8On6c=

go.sum database tree
1329
qX5FDdJtUuayYdFSjQNHTxXBFA/6ZV64g5EymKOCmHk=

— gosum.io zm51ZfEc2ervwLzyS4S1H6ext1+8+jcNx0fX8FJHqVDI0cpXHc4pGUwKEbfF/XLZCLvNvbm16RWWc9/wNuIF9CtuAw8=

What did you see instead?
not found<EMAIL_ADDRESS>invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required

/cc @hyangah

The error message here is correct: the repository at github.com/xgfone/gconf at version v3.3.0 includes a go.mod file, so it cannot be used as version v3.3.0 of a module path that lacks a /v3 suffix.
(This is the error message that results from the fix for #32695.)

As far as I can tell this is the fix to #32695 working as designed. Is there a specific detail that led you to expect different behavior from the checksum database? (We don't in general provide checksums for modules that cannot be retrieved using go mod download.)

Thanks @bcmills .

I have met with this trouble after updating the go version from 1.12.7 to 1.13.0.
I have a project, and go.mod is like this.
module ipdb

require (
	github.com/xgfone/gconf v3.7.0+incompatible
	github.com/xgfone/klog v1.10.0
	github.com/xgfone/ship v1.8.0
)

But there is no go.sum, which will be created automatically when running go mod tidy.
When using go 1.12.7, it's ok.
$ go version
go version go1.12.7 windows/amd64
$ ls go.*
go.mod
$ go mod tidy
$ ls go.*
go.mod  go.sum

For go 1.13.0, however, it didn't work. For instance,
$ go version
go version go1.13 windows/amd64

$ ls go.*
go.mod

$ GOPROXY=https://goproxy.io,direct go mod tidy
verifying<EMAIL_ADDRESS><EMAIL_ADDRESS>malformed record data

$ GOPROXY=https://goproxy.cn,direct go mod tidy
verifying<EMAIL_ADDRESS><EMAIL_ADDRESS>reading<EMAIL_ADDRESS>404 Not Found

Then, I ran go mod tidy with GONOSUMDB="*", and it will create go.sum.
$ go version
go version go1.13 windows/amd64
$ GONOSUMDB="*" GOPROXY=https://goproxy.io go mod tidy
$ echo $?
0
$ ls go.*
go.mod  go.sum

Last, I ran go mod tidy again without GONOSUMDB, it's ok, too. That's, When no go.sum, it will report an error; or, it's ok.
$ ls go.*
go.mod  go.sum
$ GOPROXY=https://goproxy.io,direct go mod tidy
$ echo $?
0

31543 says:

Given time before 1.13 is short, I suggest aiming for some cheap but useful improvements.

I agree with that.
@oiooj How had I better do?

Disable SUM DB, like GONOSUMDB="*" above. But not everyone will disable it.
Modify go.mod in github.com/xgfone/gconf and declare the module from github.com/xgfone/gconf to github.com/xgfone/gconf/v3. But it maybe break down some existed projects.
Others...

I am guessing the checksum verification occurs only when the module is downloaded from the Internet to the module cache for the first time. So, once it lands in the local disk (by skipping the sumdb check), go command simply accepts it if the checksum in go.sum and the checksum of the copy in the cache matches.
@xgfone Is it not an option to release the latest version that follows the import versioning rule and ask users to pick the new version with the same import path? Currently go command recognizes up to v1.5.0 in the repo. Maybe v1.6.0 assuming there were not backward-incompatible changes.

GO111MODULE=on GOPROXY=direct go list -m -json --versions github.com/xgfone/gconf
{
	"Path": "github.com/xgfone/gconf",
	"Version": "v1.5.0",
	"Versions": [
		"v1.0.0",
		"v1.0.1",
		"v1.2.0",
		"v1.2.1",
		"v1.3.0",
		"v1.4.0",
		"v1.5.0"
	],
	"Time": "2019-04-24T08:12:22Z"
}

Or if your intention was to stick with v3, yes, I am sorry it needs to fix go.mod to use github.com/xgfone/gconf/v3 (like your option 2) and ask users to switch their import paths or use replace.
BTW it's strange to see go mod tidy accept the invalid incompatible version that other go commands would reject and I think that's a bug. I will file an issue to track the bug separately.

@hyangah Yes, you are right. Tks.
It may be better to declare the module from github.com/xgfone/gconf to github.com/xgfone/gconf/v3 and to replace github.com/xgfone/gconf with github.com/xgfone/gconf/v3. The user only needs to add one replace for the existed project, just like repalce github.com/xgfone/gconf => github.com/xgfone/gconf/v3 3.X.0