client: add CreateWithOptions function to client.KeysAPI

Allows you to optionally Create nodes with:

A TTL
In order generated keys
Ignore existing node values

@bcwaldon Ok this new version of the patch now uses a new func.

@bcwaldon ping.

@chirino I talked to the etcd devs a bit offline about this and we came to the following conclusion:
The Create operation is effectively a Set w/ a requirement that the key not already exist (i.e. prevExist=false). A Create-In-Order operation does not behave like a Set - it offloads the responsibility of picking the key to the server. Trying to share an interface between these two methods is only going to confuse users of this library and make the testing matrix more complex for the existing code. Given that Create == Set but Create-In-Order != Set, the functionality you are introducing needs to be implemented independently of the Set codepath. This means a new CreateInOrder (actually, CreateSeq is preferred) method on the KeysAPI and a new method in the HTTP implementation. This new CreateSeq function can have a CreateSeqOptions struct if necessary, but it clearly should not expose any functionality that is intended for a normal Create/Set.

What interface is it that we are sharing?  Are you saying the CreateWithOptions is exposing functionality that is not valid for a Create?  If so what is it?

@chirino The shared interface I'm referring to is the concept of "Create". A Create and a Create-In-Order are conceptually different operations. CreateWithOptions(key, value, CreateOptions{InOrder: true}) is totally different than CreateWithOptions(key, value, CreateOptions{InOrder: false}), so I'd like to see the distinction made in the method name, not a boolean.

I don't agree they are different operations.  They are both create operations.
How would you create a non-ordered node with a TTL?  Right with my change it would be something like:
CreateWithOptions(key, value, CreateOptions{TTL: 3000})?
Are you saying keep the CreateWithOptions func and also add a CreateInOrder function?
What if you want to set the TTL on for an in-order node?  Should we also have a CreateInOrderWithOptions func?

Before we can talk about code, we need to agree that these are fundamentally different operations. We cannot agree on an API until we understand what functionality we're trying to expose. So here's how I see it:
Create

node will not be created unless another node does not exist at provided key (Compare-and-Swap based on existence)
user decides full key at-which value will be written
user provides value
user may provide TTL

Create-In-Order

there is no comparison operation, like there is in a Create (CAS based on existence)
user does not decide full key at-which value will be written
user provides value
user may provide TTL

As you can see, there are two incredibly important differences:

Create is a CAS operation, while Create-In-Order is not
Create requires the user to provide a full key, while Create-In-Order does not

Given how important those differences are, I am not willing to accept an API that distinguishes between them using a boolean. That approach hides a very important decision behind a seemingly innocuous flag.
To your question about how you would "create a non-ordered node with a TTL":
KeysAPI.Set("/foo", "val", SetOptions{TTL: time.Second, PrevExist: true})

So, I do not see any changes necessary to the existing code, only additions. I don't know if this actually works, but this is effectively what I want to see:
commit a4ab23891aef11cded81210b10bfb0e745ffaa45
Author: Brian Waldon<EMAIL_ADDRESS>Date:   Fri Mar 20 09:07:55 2015 -0700

    client: rough CreateInOrder operation

diff --git a/client/keys.go b/client/keys.go
index 71852a6..0a88bfd 100644
--- a/client/keys.go
+++ b/client/keys.go
@@ -109,6 +109,11 @@ type KeysAPI interface {
 	// Update is an alias for Set w/ PrevExist=true
 	Update(ctx context.Context, key, value string) (*Response, error)

+	// CreateInOrder creates a new node in the given directory. The server
+	// chooses a unique key in the provided directory, returning the created
+	// Node in the Response.
+	CreateInOrder(ctx context.Context, dir, value string, opts *CreateInOrderOptions) (*Response, error)
+
 	// Watcher builds a new Watcher targeted at a specific Node identified
 	// by the given key. The Watcher may be configured at creation time
 	// through a WatcherOptions object. The returned Watcher is designed
@@ -161,6 +166,14 @@ type SetOptions struct {
 	TTL time.Duration
 }

+type CreateInOrderOptions struct {
+	// TTL defines a period of time after-which the Node should
+	// expire and no longer exist. Values <= 0 are ignored. Given
+	// that the zero-value is ignored, TTL cannot be used to set
+	// a TTL of 0.
+	TTL time.Duration
+}
+
 type GetOptions struct {
 	// Recursive defines whether or not all children of the Node
 	// should be returned.
@@ -289,6 +302,25 @@ func (k *httpKeysAPI) Update(ctx context.Context, key, val string) (*Response, e
 	return k.Set(ctx, key, val, &SetOptions{PrevExist: PrevExist})
 }

+func (k *httpKeysAPI) CreateInOrder(ctx context.Context, dir, val string, opts *CreateInOrderOptions) (*Response, error) {
+	act := &createInOrderAction{
+		Prefix: k.prefix,
+		Dir:    dir,
+		Value:  val,
+	}
+
+	if opts != nil {
+		act.TTL = opts.TTL
+	}
+
+	resp, body, err := k.client.Do(ctx, act)
+	if err != nil {
+		return nil, err
+	}
+
+	return unmarshalHTTPResponse(resp.StatusCode, resp.Header, body)
+}
+
 func (k *httpKeysAPI) Delete(ctx context.Context, key string, opts *DeleteOptions) (*Response, error) {
 	act := &deleteAction{
 		Prefix: k.prefix,
@@ -454,6 +486,28 @@ func (a *setAction) HTTPRequest(ep url.URL) *http.Request {
 	return req
 }

+type createInOrderAction struct {
+	Prefix string
+	Dir    string
+	Value  string
+	TTL    time.Duration
+}
+
+func (a *createInOrderAction) HTTPRequest(ep url.URL) *http.Request {
+	u := v2KeysURL(ep, a.Prefix, a.Dir)
+	form := url.Values{}
+	form.Add("value", a.Value)
+	if a.TTL > 0 {
+		form.Add("ttl", strconv.FormatUint(uint64(a.TTL.Seconds()), 10))
+	}
+	body := strings.NewReader(form.Encode())
+
+	req, _ := http.NewRequest("POST", u.String(), body)
+	req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
+
+	return req
+}
+
 type deleteAction struct {
 	Prefix    string
 	Key       string

I would really like to see this move forward. @chirino are you willing to make the changes required, or do you want someone else to pick this up?

Alternatively I've gone ahead and made those changes in my own fork, since I'm implementing something using the new etcd api which uses this functionality:
https://github.com/coreos/etcd/compare/master...ecnahc515:create_options_inorder_api
/cc @bcwaldon

@ecnahc515 has added CreateInOrder to handle In order generated keys. The A TTL or Ignore existing node values should use Set to make it.
Thanks for the contribution!


feat: support SaslHandshakeRequest v1

If SaslHandshakeRequest version is v0, a series of SASL client and
server tokens corresponding to the mechanism are sent as opaque packets
without wrapping the messages with Kafka protocol headers. If
SaslHandshakeRequest version is v1, the SaslAuthenticate
request/response are used, where the actual SASL tokens are wrapped in
the Kafka protocol. The error code in the final message from the broker
will indicate if authentication succeeded or failed.

References:
https://kafka.apache.org/protocol#sasl_handshake
https://kafka.apache.org/protocol#The_Messages_SaslHandshake
https://kafka.apache.org/protocol#The_Messages_SaslAuthenticate

@bai can you take a look?
This is a very interesting change as this allows clients using SASL Plain to get a meaningful message in case of an authentication failure.

Many thanks! (And thanks for poking me!) 💯


updated code to refresh the workflow section when anything is changed in FileEdit section

Also adding back WB prepublication pipeline papers to the Sort page

Thanks @azurebrd


Survey Form

Add  Header to create the heading  content

Add form section for collecting credentials

Add inputs to enter user information

Add textarea  to type user content.

Add readMe file.

Requires Changes 👍
Hi @mohashyne

You have done a good job so far!
You still need to work on some issues, but you are almost there! 🫡
Highlights

Follows GitHub flows ✅
Descriptive PR title and summary ✅
Good commit messages ✅

Required Changes ♻

Before merging to the main branch, it is recommended to install the linters file in your repository and check for linter errors and fix them if required. Linters can identify certain programming errors earlier on that you may not have noticed while writing code. To make your code look professional standard and well-organized we prioritize using linters in every PR's. 😅
I suggest you check your CSS files and work with element and class properties (please check the comments below). 🫡
I suggest you also check your index.html file to fix some highlighted issues (from the comments below). 🫡
It is always recommended to document your repository so that you could keep track of your changes. maybe you could do that later. 😉

Optional suggestions

[OPTIONAL] You can go through your index.html and styles.css files again and organize the code to make it look cleaner, simpler to read, and more professional. ✨ You could add comments to your code to keep track of your code and identify which section play responsible for which part. 😉

Cheers and Happy coding!🍻💻
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Consider adding a background-img, because the green color isn't very pleasing to the eyes of users when they are using your site. They could stop visiting your sites immediately. To make your site look amazing and cleaner, you have to work with its design and pick up a color that could potentially be interesting to many.

Please review the whole html and css code, and reorganize them with the best practice of HTML and CSS semantics. As that will be needed if you wish to create an interesting site for your users.

For reference, please take note of how your project should look at the end.
Your Design:

Required Design:


remove circular dependency between StorageCommunicationEnpoint and StorageProxy initialization

Nice! Things are looking a lot cleaner.

thanks! it's going to get even better in the next PRs :)

Nice! Things are looking a lot cleaner.

thanks! it's going to get even better in the next PRs :)


Add image description to the gallery scroller

Currently, the image takes full height and thus description would cover the image. Need to find a workaround for that.

This is going to be a bit delayed. The dependent library for the full-screen preview is bit of a crap. I will probably need to work on this majorly.


Bump minimum version of HA required

Proposed change
Since zwave and ozw were removed in 2022.4, this PR sets that version as the new minimum. Since this change will be read by HACS as soon as it's merged, it should only be merged when the zwave and ozw code removal gets released
Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:

Codecov Report

Merging #279 (695121c) into main (efd4995) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   84.14%   84.14%
=======================================
  Files          10       10
  Lines         801      801
=======================================
  Hits          674      674
  Misses        127      127


Add instructions how to open in Android Studio

Addressing issue: https://github.com/googlesamples/android-architecture/issues/47

LGTM 👍


Cron in chef-client cookbook ignores daemon_options

The cron functionality ignores the daemon_options attribute, this will add the daemon_option to the cronjob.

Hi. I am an automated pull request bot named Curry. There are commits in this pull request whose authors are not yet authorized to contribute to Chef Software, Inc. projects or are using a non-GitHub verified email address. To become authorized to contribute, you will need to sign the Contributor License Agreement (CLA) as an individual or on behalf of your company. You can read more on Chef's blog.
GitHub Users Who Are Not Authorized To Contribute
The following GitHub users do not appear to have signed a CLA:

@gerr1t

Please sign the CLA here.

Hi. Your friendly Curry bot here. Just letting you know that all commit authors have become authorized to contribute. I have added the "Signed CLA" label to this issue so it can easily be found in the future.

Rebased and merged as eb4214fe019fbb5adc3964d32d0e08e52ca970a8


added en-st baseline for jw300 test set and autshumato evaluation set

I've added baseline BLEU scores for the

JW300 test set
Autshumato Evaluation set

In both cases, the model was trained on JW300 training data.
The original Masakhane notebook was split into processing and training notebook in order to run them on seperate Google Collab instances (as the processing step managed to consume the time allocation for a Collab instance).
Custom code was added to the training and testing notebook in order to calculate the BLEU score using multiple human translation references provided by the Autshumato evaluation set. The BLEU score calculation for the JW300 testing set was unaltered.
Results for each set are detailed in the README.md file present in each folder.

Awesome! :sunglasses:
Can you please add the results to languae_pairs.md as well?

Done!


[feat] check for valid url targets

I would like to be able to pre-flight check whether the URLs in the images.yml are still valid and can be downloaded or raise an error if they are unavailable.
Thus I would suggest that  check.py should raise an error on r.status_code so one can act upon invalid URL definitions
comments?
ralf

Fixed with https://github.com/osism/openstack-image-manager/commit/e5dc12acb5b4d57ded11d685d0f92b78d39d62fd


Silence the Autoprefixer message being printed with all build logs

The following is printed with every build, which gets kind of annoying when looking at the logs:
Replace Autoprefixer browsers option to Browserslist config.
Use browserslist key in package.json or .browserslistrc file.

Using browsers option cause some error. Browserslist config
can be used for Babel, Autoprefixer, postcss-normalize and other tools.

If you really need to use option, rename it to overrideBrowserslist.

Learn more at:
https://github.com/browserslist/browserslist#readme
https://twitter.com/browserslist

Given how we're using Autoprefixer, with a number of build-specific configs, simply changing the option name seems like the easiest solution here.
(I'm also adding a couple of newlines at the autoprefixer call-sites, to aid readability.)

/botio-linux preview

Thank you for cleaning up the logs!


refactor: Allow reusing the same operator to speed up tests

This PR refactor the behavior tests to allow using the same operator.

I think the benefits are not significant, and it adds to the mental burden of maintainers. 👀

tests are faster
tests are happened on the same operator (like real use cases)
more hidden errors are exposed
easier to add new test suite

I believe the benefits is good enough.

I think the benefits are not significant, and it adds to the mental burden of maintainers. 👀

tests are faster
tests are happened on the same operator (like real use cases)
more hidden errors are exposed (I fixed at least 5 bugs in this PR)
easier to add new test suite

I believe the benefits is good enough.

If it's just for the sake of speed, I don't think the benefits are significant.
Adding those you mentioned would be sufficient.

Are there any points need to pay attention to? Please update them in the behavior tests' readme.

No.


Add created time to aid package

Backend part of the  https://github.com/LSFLK/MedicinesforLK/issues/411
When rolling this fix to an existing db, following db change is needed.
ALTER TABLE AID_PACKAGE ADD COLUMN `DATETIME` DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP

Don't we need to add the dateTime field in AidPackage schema as well

added thanks


FadeIn background for Select not working in android

Description
FadeIn background for Select not working in android
CodeSandbox/Snack link
https://snack.expo.dev/GL2OpdsK9
Steps to reproduce
1.Run the example in android device using expo
NativeBase Version
3.3.x
Platform

[X] Android
[ ] CRA
[ ] Expo
[ ] iOS
[ ] Next

Other Platform
No response
Additional Information
HI , select box backdrop is fading in nicely in IOS , but in android its sliding up instead of fade in , its not looking good.. how to chage the animation of backdrop or make the background fully transparent. thank you.

Thanks for reporting this @vishnuc. We'll look into this.

This is still an issue on version 3.4.18. On Android devices, the backdrop translates from the bottom of the page to the top instead of fading in. It works fine on iOS. Is there a way to temporarily disable the backdrop, or make it transparent?

I have the same issue with Actionsheet on version 3.4.19, the backdrop transition should be fading instead of sliding

I fixed this issue by adding defaultProps to Modal component in my custom theme like this:
Modal: {       defaultProps: {         _overlay: {           useRNModalOnAndroid: false,         },         _backdrop: {           _pressed: {             opacity: 0.4,           },         },       },     },

I fixed this issue by adding defaultProps to Modal component in my custom theme like this:
Modal: { defaultProps: { _overlay: { useRNModalOnAndroid: false, }, _backdrop: { _pressed: { opacity: 0.4, }, }, }, },

This works, but if your using full screen modals in Android the snackbar covers the modal. Haven't explored ways around that but you can always add margin to the top of your modal to push it below the snackbar.

@surajahmed @Viraj-10 still having issue on 3.4.28


Run clipmenud after the display manager is started

In cases of starting the display manager manually from tty, the DISPLAY variable is not yet set and clipmenud is crashing.

Hi! This doesn't appear to be a standard unit, so you're probably going to have to add it as a drop-in.
Another way to provide $DISPLAY if X is not started yet is with systemctl --user import-environment.

You are right. Turns out this didn't even fix it on my machine as I'm starting sway by executing sway from the tty and not through systemd. I'll close the PR, thanks for the input!


[275]fixed in user/findByEmail need respons -404 Not found

Here is the result:
First screenshot is when we enter invalid data that doesn’t exist in database.

Second screenshot is when we enter invalid data that doesn’t match email.

Third  screenshot is when we enter existing email in DB.

I agree with you! I changed it)


Dragged item is not visible

Hello together, i have the issue that the item i am dragging is invisible. This means that the item i am actually dragging is just an empty container (see picture)
Anybody knows what could be the issue here?
Thanks a lot.

Solved by including the ng-sortable css file.


[Role Request] Install xPU OS

Description:
A role that installs an OS on the given xPU, this role will optionally download the OS if given a URL, and push the image, then it will wait till the operation is finished and the xPU is up with the correct OS.
This role should assume the conditions for the operation are already met (for example in Nvidia, that RSHIM is disabled on the host), this needs to be part of the playbook around it or customer assumptions
Input:
os_file_location(String) - can be a local file or a url, if url we will download it, if local file we will use it
os_config_file(string) - path to a local file, a configuration file to pass to the installation
Output:
Installed version/error

network boot example : https://docs.nvidia.com/networking/display/bluefieldbmcv2310/boot+configuration


no reload sysyem daemon, no respiring

the device do not respir after jb once do not open “reload system daemon” , please help to slove the problem, thanks.
Device (please complete the following information):

iOS Version: 12.1
iOS Device: iphone 6pm
unc0ver Version: 3.1.2

Place an "x" between the brackets if true:

[ ] this is a bug others will be able to reproduce
[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[ ] this issue is present on the latest version of unc0ver

Logs
If applicable, add logs or error messages here.

Toggle RSD back on. This is an essensial option in order for the jailbreak to work.


[ASK] office 2021和visio2021 LSTC激活失败

Office 21, Office21Standard2021VL_KMS_Client_AE edition
•	许可证说明: Office 21, VOLUME_KMSCLIENT channel
•	产品密钥的最后五个字符: 78VT3
•	错误代码: 0x8007007B
•	错误信息: 文件名、目录名或卷标语法不正确。
Office 21, Office21VisioPro2021VL_KMS_Client_AE edition
•	许可证说明: Office 21, VOLUME_KMSCLIENT channel
•	产品密钥的最后五个字符: K2HT4
•	错误代码: 0x8007007B
•	错误信息: 文件名、目录名或卷标语法不正确。

请看教程

Please see the tutorial

What does he did that was wrong?

Please see the tutorial

What does he did that was wrong?

There is no wrongdoing here in my opinion. My solution is to clean all the permits and reinstall them, and KMS activation finally works.


[web] Random images in grid of cards are not displayed when scrolling

Using Image.network instead of ImageCard works as expected.
Maybe related to https://github.com/flutter/flutter/issues/47328?
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: ImageGrid(),
    );
  }
}

class ImageGrid extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return GridView.builder(
      gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
        crossAxisCount: (MediaQuery.of(context).size.width / 180).floor(),
        childAspectRatio: 2.4,
      ),
      itemCount: 1000,
      itemBuilder: (BuildContext context, int index) {
        return ImageCard('https://picsum.photos/seed/$index/300/200');
      },
    );
  }
}

class ImageCard extends StatelessWidget {
  const ImageCard(this.url);

  final String url;

  @override
  Widget build(BuildContext context) {
    return Card(
      color: Colors.red,
      child: Image.network(url, fit: BoxFit.cover),
    );
  }
}

[✓] Flutter (Channel master, 1.20.0-3.0.pre.78, on Mac OS X 10.15.5 19F101, locale en-CH)
    • Flutter version 1.20.0-3.0.pre.78 at /Users/ben/flutter
    • Framework revision 2962912d68 (25 hours ago), 2020-06-27 00:59:50 -0700
    • Engine revision fc0e27210c
    • Dart version 2.9.0 (build 2.9.0-19.0.dev 63cf56d925)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/ben/Library/Android/sdk
    • Platform android-29, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.8.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.41.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.7.1

[✓] Connected device (3 available)
    • macOS desktop • macos      • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server    • web-server • web-javascript • Flutter Tools
    • Chrome        • chrome     • web-javascript • Google Chrome 83.0.4103.116

• No issues found!

Hi @cbenhagen
the fact that the issue does not occur using simply Image.network,
leads me to think that the problem are the widget being rebuilt,
sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: ImageGrid(),
    );
  }
}

class ImageGrid extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return GridView.builder(
      gridDelegate: SliverGridDelegateWithFixedCrossAxisCount(
        crossAxisCount: (MediaQuery.of(context).size.width / 180).floor(),
        childAspectRatio: 2.4,
      ),
      itemCount: 1000,
      itemBuilder: (BuildContext context, int index) {
        return ImageCard(url: 'https://picsum.photos/seed/$index/300/200', key: ValueKey(index));
      },
    );
  }
}

class ImageCard extends StatelessWidget {
  const ImageCard({this.url, Key key}) : super(key: key);
  final String url;

  @override
  Widget build(BuildContext context) {
    return Card(
      color: Colors.red,
      child: Image.network(url, fit: BoxFit.cover),
    );
  }
}

as expected using a key this behaviour does not occur;
does this fix the issue for you?
Thank you

Hi @cbenhagen
I'm experiencing this when running with current master 1.20.0-3.0.pre.78 and dev 1.20.0-2.0.pre, but not with beta 1.19.0-4.2.pre. Does beta work as expected for you?

@iapicca the workaround you suggested does not work here.
@VladyslavBondarenko Yes this bug is not present in the beta.

I tried also with iOS and Android, it seems to work as expected there.

flutter doctor -v
[✓] Flutter (Channel master, 1.20.0-3.0.pre.100, on Mac OS X 10.15.5 19F101, locale en-GB)
    • Flutter version 1.20.0-3.0.pre.100 at /Users/nevercode/dev/flutter
    • Framework revision f2f48df3af (3 hours ago), 2020-06-29 22:19:55 -0700
    • Engine revision a974b78117
    • Dart version 2.9.0 (build 2.9.0-19.0.dev f91547d6dd)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/nevercode/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.0.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.0

[✓] Connected device (5 available)
    • Redmi Note 7       • 6345c469                                 • android-arm64  • Android 9 (API 28)
    • Nevercode’s iPhone • b668e524315069f3db3661ac11ff1f66afafebdb • ios            • iOS 13.5
    • macOS desktop      • macos                                    • darwin-x64     • Mac OS X 10.15.5 19F101
    • Web Server         • web-server                               • web-javascript • Flutter Tools
    • Chrome             • chrome                                   • web-javascript • Google Chrome 83.0.4103.116

• No issues found!

Actually this is also reproducible in the beta.

@goderbauer, @yjbanov  have you run across anything similar to this on native mobile?
Basically while the images inside the cards are still waiting for network request to complete, if you scroll the view up and down really fast, it looks like it reuses the card element somehow but picture is not repainted (the picture itself is there but instead of loading new image into it and repainting it just stays blank).
Only reproducable if you scroll really fast (with half the image still loading) and then scroll the opposite direction.

I've not seen this on native mobile and also couldn't reproduce it there just now.
/cc @dnfield

It's possible that ScrollAwareImageProvider is getting messed up on web, but given that this works with a plain Image.network, that wouldn't be the first place I'd check.

This also happens when using PhysicalModel directly instead of the whole Card widget. I changed the title and the example accordingly.

Landed in master.

Still not completely fixed. Recycled canvas is used multiple times.


Unable to run npm start command

Upon cloning the project and successfully running npm install, I get the following error after running npm start:
C:\GitHub\victor-hugo>npm start

><EMAIL_ADDRESS>start C:\GitHub\victor-hugo
> gulp server

[14:20:01] Requiring external module babel-register
[14:20:04] Using gulpfile C:\GitHub\victor-hugo\gulpfile.babel.js
[14:20:04] Starting 'hugo'...
[14:20:04] Starting 'css'...
[14:20:04] Starting 'js'...
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: spawn hugo ENOENT
    at exports._errnoException (util.js:1026:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:359:16)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)
    at process._tickCallback (internal/process/next_tick.js:98:9)
    at Module.runMain (module.js:606:11)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3

npm ERR! Windows_NT 10.0.14393
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Users\\dfross.AHCM\\AppData\\Roaming\\npm\\node_modules\\npm\\bin\\npm-cli.js" "start"
npm ERR! node v6.9.0
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: `gulp server`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'gulp server'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the victor-hugo package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     gulp server
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs victor-hugo
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls victor-hugo
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     C:\GitHub\victor-hugo\npm-debug.log

I am running Windows 10 (64), Node 6.9.0, NPM 3.10.8

Are you sure you have hugo installed and available in the path? It looks like the start command fails to find hugo....
Make sure to follow the install instructions from here: http://gohugo.io/

Oh wow. Rookie mistake.  Thanks! Close.


Bug: Incorrect public IP got displayed after stop/start a EC2 instance

Rancher server can connect to the name instance but the displayed public IP is incorret. AWS arranged a new public IP but the rancher UI does not catch it.

@zhang8473 this is a duplicate of #388
There is a documented work-around that you can use:
http://docs.rancher.com/rancher/faqs/troubleshooting/#what-do-i-do-if-the-ip-of-my-host-has-changed-due-to-reboot


Fixing positional parameter cannot be found

To avoid specifying "-Tasks" parameter name each time.
From about_parameters:

Parameter Position?
This setting indicates whether you can supply a parameter's value
without preceding it with the parameter name. If set to "0" or "named,"
a parameter name is required. This type of parameter is referred to as
a named parameter. A named parameter can be listed in any position
after the cmdlet name.

If the "Parameter position?" setting is set to an integer other than 0,
the parameter name is not required. This type of parameter is referred
to as a positional parameter, and the number indicates the position
in which the parameter must appear in relation to other positional
parameters. If you include the parameter name for a positional
parameter, the parameter can be listed in any position after the
cmdlet name.

Sorry, what are you trying to fix?

BTW, the quote you provided seems to be just wrong. Parameter positions normally start with 0.

This is to avoid specifying parameter name when invoking the script:
    .\build.ps1 build,test

BTW, the quote you provided seems to be just wrong. Parameter positions normally start with 0.
Strange. I have PS, Version: 5.1.16299.431.

.\build.ps1 build,test

I can do this as it is. Give a problem case example and describe what wrong is.
I have the same help as you. As I said, it is wrong. You may submit a help bug to PS.

Example:
0> help Get-Variable -Parameter Name

-Name <String[]>
    Specifies the name of the variable. Wildcards are permitted. You can also pipe a variable name to Get-Variable .

    Required?                    false
    Position?                    0
    Default value                None
    Accept pipeline input?       True (ByPropertyName, ByValue)
    Accept wildcard characters?  false

Name is positional parameter, not named. And its position is 0.

Ok, it's something with PS. At about_functions_advanced_parameters it says from 0. 😕  Locally I get different results when only Position=1 specified. The error is when it was given more parameters:
In script:
Param (
	[parameter(Position=1)]
	[string[]] $Tasks,
	[string] $configuration = $null,
	[string] $artifactsDir = $null,
	[string] $xTest = $null,
	[switch] $sShow = $false,
	[string[]] $sFilter = $null
)

$ Get-Help .\run.ps1 -full

run.ps1 [-Tasks <String[]>] [-configuration <String>] [-artifactsDir <String>] [-xTest <String>] [-sShow]
    [-sFilter <String[]>] [<CommonParameters>]

PARAMETERS
    -Tasks <String[]>
        See "./run.ps1 ?" for list of tasks. Specifies the tasks to be invoked on direct calls.

        Required?                    false
        Position?                    named
        Default value
        Accept pipeline input?       false
        Accept wildcard characters?  false

$ .\run.ps1 build,test -sShow
C:\coding\gameo\gameoemergency\run.ps1 : A positional parameter cannot be found that accepts argument 'System.Object[]'.
At line:1 char:1
+ .\run.ps1 build,test -sShow
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [run.ps1], ParameterBindingException
    + FullyQualifiedErrorId : PositionalParameterNotFound,run.ps1

It runs when [CmdletBinding(PositionalBinding = $false)] given.

I cannot repro your problem.
Script:
Param (
	[parameter(Position=0)]
	[string[]] $Tasks,
	[string] $configuration = $null,
	[string] $artifactsDir = $null,
	[string] $xTest = $null,
	[switch] $sShow = $false,
	[string[]] $sFilter = $null
)

if ([System.IO.Path]::GetFileName($MyInvocation.ScriptName) -ne 'Invoke-Build.ps1') {
	Invoke-Build $Tasks $MyInvocation.MyCommand.Path @PSBoundParameters
	return
}

task build {
	"building"
}
task test {
	"testing"
}

Command:
./run.ps1 build, test -sShow

All works fine.


[BI-1222] Fixes to BrAPI lists

Description
Adds following list support for brapi lists:

External references
Create date
Made searching lists easier by removing "search by owner" requirement.
Made some fixes to PUT list
Converted brapi types (germplasm and observation variables) to breedbase types (accessions and traits) and back.

Is based on BI-1251, so includes some extra germplasm changes not done in this card.
Dependencies

Should be run with BI-1085 on bi-api and bi-web.

Testing

Import a germplasm file BI-1251_file_parents.xls
Specify unique list name (description is optional)
Should be successful. Check breedbase lists api for the new list.
Import the same germplasm file.
Specify a duplicate list name
An error should be display.
Changing the name to a unique name will result in a successful import.

I also noticed that when I tried to call to /brapi/v2/lists from insomnia, that I got a 401. If I logged into Breedbase in the browser, and then went to the same endpoint, things worked just fine.

Let's chat about this. On my local instance I can successfully call that endpoint without authorization.


Modified vars to use config file

JIRA link
Change description
Work checklist

[ ] Tests added where applicable
[ ] UI changes meet accessibility criteria

Merge instructions
We are committed to keeping commit history clean, consistent and linear.  A BREAKING CHANGE can be part of commits of any type,
types other than fix: and feat: are allowed, for example build:, chore:, ci:, docs:, style:, refactor:, perf:, test:, and others,
footers other than BREAKING CHANGE: <description> may be provided.

CI: No IaC security warnings found


Our first impression: We like it!

Hello!
We've tested many of the kits made by devs focused on improving the React project. From simple to complex. Every project tested had something apart with their own pros and cons. In terms of performance, it's hard to tell unless we port one of our medium project in the React ecosystem and test it in real world servers.
The features within this foundation are a solid way on how to combine the business logic inside applications. SSR is a great adition too. It should be a SSR branch to let other play and change things to improve the process.
Glad you have a sponsorship program, we shall take in consideration investing in the future of this dev project.
So I would say we want to start porting our project using this foundation. It's time consuming because it's angular based. We also intent using the SSR feature made here by tomazy. We know there will be a need for improvements, because of the complexity that we should implement.
BUT it's a solid foundation with an extra atention for not losing the best approach criteria. AND that's not an easy-to-find these days!
To conclude,
A lot of Effort, Research and Love we've found between the coding lines :-)
Congrats!

Thanks, we much appreciate comments like this, we don't get them very often! This certainly just made my day! 😊
All due to the amazing team and collaborators we have!
👏 @oliverturner 👏
👏 @datapimp 👏
👏 @gihrig 👏
👏 @amilajack 👏
👏 @chaintng 👏
👏 @sedubois 👏
👏 @samit4me 👏
👏 @Dattaya 👏
👏 @justingreenberg 👏


New version: leezer3.OpenBVE version <IP_ADDRESS>

Result: Installation Failed

Manifest
Add/Remove Programs

Name
openBVE

Version
<IP_ADDRESS>

Publisher
The OpenBVE Project

ProductCode

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 7153
Microsoft Reviewers: Open in CodeFlow

@stephengillie It looks like the bots missing silent commands.

@stephengillie It looks like the bots missing silent commands.

Which commands?

When I detected inno type, this installer can be completely unattended.


How to target all classes in a specific package

I know that to log all methods of a class, I can use the following approach:
@AndroidAopMatchClassMethod(
    targetClassName = "com.example.main.MainActivity",
    methodName = ["*"],
    type = MatchType.SELF
)
class MatchActivityMethod : MatchClassMethod {
    override fun invoke(joinPoint: ProceedJoinPoint, methodName: String): Any? {
        Logger.e("${joinPoint.targetClass.simpleName}: $methodName()")

        return joinPoint.proceed()
    }
}

So how can I log all methods of all classes in a certain package?
I tried the following approach, but it doesn't work:

targetClassName = "com.example.main.*"

Let me first say the conclusion. This library does not support this approach.
AndroidAOP currently only matches methods of a certain class, and does not match only a certain method regardless of which class it is. Because the author thinks that doing so is almost meaningless. Doing so often will result in many classes or methods that do not want to be added to the aspect being added, which is not conducive to everyone managing and controlling their own code (a bit out of control~)

Can you please tell me what is the actual scenario in which you do this? I will close this issue

Recently, I have been taking over the maintenance of a new project on my all. Since the project has no documents, I am not familiar with the project's structure, some workflows are encountering ARN errors due to loops.
Therefore, I want to print the logs of all the methods that will be called to understand the project's structure and identify the places where infinite loops are occurring.
I know that I can achieve this with the following code using AspectJ:

@ Aspect
public class ActivityLifecycleLogAspect {
private static final String TAG = ActivityLifecycleLogAspect.class.getSimpleName();
// Define the package you want to target
private static final String TARGET_PACKAGE = 'com.your.package.name';

@Pointcut('execution(* *(..)) && within(' + TARGET_PACKAGE + '..*)' +
          '&& !within(ActivityLifecycleLogAspect)')
public void logActivityLifecycle() {}

@Before('logActivityLifecycle()')
public void log(final JoinPoint joinPoint) {
    Log.v(TAG, 'log: ' + joinPoint.toLongString());
}

}

I would be happy if you can make it with AndroidAOP

Many other friends have mentioned this feature before, but the reasons are not sufficient. I think the reason you mentioned is still valuable, so I will add this feature to the next version. It will be launched tonight at the earliest

Thank you!
Please make it possible to target not only the classes within a package but also all the classes in all its sub-packages.

Thank you! Please make it possible to target not only the classes within a package but also all the classes in all its sub-packages.

That's for sure, the new version 2.0.2 with this feature has already been released.


Scrolling Issue on Time Picker

Summarized code:
import { Dropdown } from 'react-native-element-dropdown';
export default function App() {
    const [eventDate, setEventDate] = useState();
    return (
        <ScrollView>
            <View style={styles.container}>
                <View>
                    <Text>Date of Event: {eventDate}</Text>
                    <DateTimePicker
                        date={eventDate}
                        timePicker
                        todayContainerStyle={{
                            borderWidth: 1,
                        }}
                        onChange={params => setEventDate(params.date)}
                    />
            </View>
        </ScrollView>
    );
}

Concern:

I selected a date
Clicked on the time
Time picker view shows up
When I try to scroll up or down to select the time, the app registers as me scrolling the entire app view up or down, while time picker itself is lagging.

I suspect the component isn't designed to ignore ScrollView by default, is this an expected behavior?

Please upgrade to the latest version I changed the time picker component. https://github.com/farhoudshapouran/react-native-ui-datepicker/commit/e7d93648680d4f10ee5aec77244d633abe128254

Sorry to bother, but are you sure this problem has been solved? I'm having this issue too.


Easy way to make trace points NO-OP in production

I was thinking about testing a logger backend, so, it would be quite problemtic if my logger will start sending debug logs by itself in release mode.
I guess it might be achieved somehow by telling hut to use a noop backend? Any suggestions how it might be done? Or maybe any better ideas?
Thanks!

Hi,
In release mode snabbkaffe uses hut logging, which can be configured via macro flags [1]. I imagine you can simply define HUT_NOOP macro in the beginning of all logger_journald .erl files?
[1] https://github.com/tolbrino/hut#supported-logging-backends

Hi @seriyps ! Did this answer your question? Can we resolve this issue?


Give id-token write permissions to release workflow for npm provenance

Issue
Refs: https://github.com/aws/aws-sdk-js-codemod/pull/813#issuecomment-2020807392
Description
Give id-token write permissions to release workflow for npm provenance
Testing
CI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The release workflow failed
[changeset-release/main 7b9e82a] Version Packages
 3 files changed, 7 insertions(+), 6 deletions(-)
 delete mode 100644 .changeset/new-meals-sell.md
/usr/bin/git push origin HEAD:changeset-release/main --force
remote: Permission to aws/aws-sdk-js-codemod.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/aws/aws-sdk-js-codemod/': The requested URL returned error: 403
Error: Error: The process '/usr/bin/git' failed with exit code 128
Error: The process '/usr/bin/git' failed with exit code 128


Themes need to be updated

None of the themes where made with v4 features in mind, and there are issues that need to be fixed such as in the default black and white theme the tag drop down text is black rendering it unreadable.

Fixed with https://github.com/chaosdrop/FlatNotes/commit/779c154feecea0ede51851cc28dd3b36a3b6c406


Changed upgrade process.

This should fix #2648

I will look at those after Tech Days - sorry - have been heads down

No problem, I thought you would be busy in preparation for tech days. Since there are workarounds or just comfort feature. I wanted to wait until after the tech days


The big cleanup, part 1

This PR is a precursor to implementing automated version detection and splitting the crate into three.

Drastically reduced amount of copy/paste in the codebase.
Enums like Precision etc are now repr(int), can use discriminants instead matching.
Removed all non-libpcap bindings from raw.rs.
Removed explicit panics (get_datalink, list_datalinks) -- we assume that Capture<Active> is activated and don't check for that in all the other places either, this seemed inconsistent.
Removed most explicit unwraps and panics, folded them into the error type.
Rename all raw::Struct_foo to raw::foo, remove extraneous typedefs in raw.
Moved PacketHeader to lib.rs; raw.rs now only contains bindings.
Always use #[cfg(windows)] to detect Windows platform.
Error::new() now never fails/panics, even upon malformed UTF-8.
Add support for running clippy, fix clippy issues.
Run most code through rustfmt.

@ebfull ^

Reviewing this tomorrow, wish me luck!

I did a high level pass and I'm very impressed. Good work! It can be merged if you're happy with it.
One bit of feedback: can we change Travis to run rustfmt and clippy against the codebase?
Don't block on me, but if I have some more time early this week I will try to do a more thorough review and look for any subtle coding mistakes.

Thanks -- yea, I'd merge this in the next few days so I can base the next big PR (version detection) off this branch.
Re: Travis, clippy - I could definitely add (on nightly only). Rustfmt - I'd keep manual since it's not 100% ideal at this point and sometimes formats things in a weird fashion (e.g. I've reported an issue upstream while formatting this crate); for now it's easier to run cargo fmt and then inspect the diff manually. Most of the code here is now rustfmt-compliant.

@ebfull if there are no concerns re: this PR, I'd hit the green button :)


Allow overriding the default grids

Fixed a missing !default which prevented the number of columns in a grid from being updated.

Thanks for the update. I'll check this out.

You are correct, sir! Thanks.


Error in postSickbeard.py urllib Python 3

I seem to be having an issue with the postSickbeard.py script:
Output:
2020-09-07 09:44:50 - qtfaststart - INFO - Writing output...
2020-09-07 09:44:53 - SickbeardPostProcess - ERROR - Unexpected exception.
Traceback (most recent call last):
File "C:\\MediaServer\\Software\\Converter\\postSickbeard.py", line 44, in
refresh = json.load(urllib.urlopen(sickbeard_url))
AttributeError: module 'urllib' has no attribute 'urlopen'

Taking a quick gander over to the python forums someone suggested the following code:
import sys

if sys.version_info[0] == 3:
    from urllib.request import urlopen
else:
    # Not Python 3 - today, it is most likely to be Python 2
    # But note that this might need an update when Python 4
    # might be around one day
    from urllib import urlopen

# Your code where you can use urlopen
with urlopen("http://www.python.org") as url:
    s = url.read()

print(s)

8883f0d3dc07f1305f368ad6fc36e518709e655c
That should fix it

sweet! :D thanks


[BUG] Documentation shows wrong repository link for setup

in https://unity-atoms.github.io/unity-atoms/introduction/quick-start#github-url
the repository still shows "AdamRamberg" in
    "com.unity-atoms.unity-atoms": "https://github.com/AdamRamberg/unity-atoms.git#master",

https://github.com/unity-atoms/unity-atoms/pull/257


$in not implemented in selector option?

Hey,
is it possible that $in currently can't be used as selector option? The following example returns wrong results
newsDB.find({selector: {id: {'$in':[798159]}}}).then(function (result) {console.log(result)});

Am i doing something wrong?
Cheers,
Antony

Hi @ThinklabsGbR this should help you https://github.com/nolanlawson/pouchdb-find/issues/120

Bascially you ned another selector combined with $in for that query to work.

Ah i see..thanks very much, now it is working as expected!
Cheers,
Antony

Excellent.

On 26 Nov 2015, at 1:14 PM, Thinklabs<EMAIL_ADDRESS>wrote:
Ah i see..thanks very much, now it is working as expected!
Cheers,
Antony
—
Reply to this email directly or view it on GitHub https://github.com/nolanlawson/pouchdb-find/issues/124#issuecomment-159885123.


My custom quote is not displaying

when i write ?quote= my quote in provided URL ,
It is displaying blue link in preview, i am attaching the screenshot , check it out

done solved


Updated: datagrip 2019.3.3

${}

a25f5096-fb60-45c3-bd2b-423ea7209e39

Newer version of datagrip (2019.3.4) is now available in master. c5f435834a6f70099d184781769e0fdbe56cef3f


image build for integration test

Changelog category (leave one):

Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...

Image rebuild

Documentation entry for user-facing changes

[ ] Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

This is an automated comment for commit ba69fe575f20f3cc1d6c76ee60f4f129f10e47f1 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success
Check nameDescriptionStatus
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success


Rename addattributeprocessor config name from "attributes" to "add-attributes"

This come from comment in a PR: https://github.com/open-telemetry/opentelemetry-service/pull/152#discussion_r303931449

Closed via #166


Download fails

when trying to download the integration in HACS I get this error:
Download failed - Got status code 404 when trying to download https://github.com/georgezhao2010/midea_ac_lan/releases/download/v0.3.22/mieda_ac_lan.zip

me, too

Same, been wanting to download for a few weeks, but every time I try it fails.  It says check the logs, but the logs just say the same... Failed to download.

same here, unable to download

@georgezhao2010 , there is a typo in the link on hacs "https://...mieda_ac_lan.zip" should be "https://...midea_ac_lan.zip"

will this update automatically in HACS? Currently it's still the wrong URL, does the fix need to be reviewed by someone?

Maybe we should wait for the pull request to be merged.

Installed the alternative #595 and it's working great!  Anybody know how to add that to HACS to replace this one? Just to make it easier for others in the future... I'm pretty new to HA so I don't know how that process works.


v-validate.initial is broken for custom validations

Versions:

VueJs: #.#.#
Vee-Validate: 2.5+

Description:
Steps To Reproduce:

Would you mind adding a reproduction sample for it?


Change the value of meta.crossplane.io/source

Description of your changes
This PR changes the value of meta.crossplane.io/source to fix the source code link.
I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

/test-examples="examples/administrativeunits/unit.yaml"

/test-examples="examples/app/roleassignment.yaml"

/test-examples="examples/applications/application.yaml"


Add missing \

Add missing \ in some equations in order to represent the set {(1), (2), (3), (4)}

thanks!


Info to put on website

[x] more info on the venue
[x] (preliminary) tutorial program
[ ] (preliminary) conference program
[ ] sponsors
[ ] locations of tuts/conf/sprints
[x] info about sprints
[ ] how people can apply for financial support
[ ] the members of the organization and committees (about)
[ ] info on what project are sprinting

@pya you might be the one who has the best view of who has what role in the organization. If you give me a quick overview, I can collect who participated in reviews and then compose an about-page.

That is our current structure (may need to be updated):

Local/Catering
Thomas Pohl
Sepideh Alassi
Susanne Greiner

Tutorials
Emmanuelle Gouillart

Program/Keynotes
Federico Vaggi

Communication
Pierre de Buyl

Coordination
Mike Müller

Accounting
Mike Müller

Video recording
Thomas Pohl

Sponsoring
Mike Müller

Web Site
9.1 Statitic
Pierre de Buyl
Mike Müller
9.2 Tito (registration)
Mike Müller
9.3 PaperCall
Mike Müller

Outreach (incl. general advertisement)
Pierre de Buyl

Help Desk
Susanne Greiner
Miroslav Šedivý

Here is a snippet of code to query the people who rated submissions:
import requests

token = 'your_papercall_api_token'

# Query all submission ids
all_ids = []
for state in ('submitted', 'accepted', 'rejected', 'waitlist'):
    url = 'https://www.papercall.io/api/v1/submissions?_token=%s&per_page=999&state=%s'
    all = requests.get(url % (token, state)).json()
    all_ids.extend([x['id'] for x in all])

# Collect all reviewers
reviewers = set()
for id in all_ids:
    url = 'https://www.papercall.io/api/v1/submissions/%s/ratings?_token=%s'
    ratings = requests.get(url % (id, token)).json()
    for rating in ratings:
        reviewers.add(rating['user']['name'])

# Print a list
for reviewer in sorted(reviewers):
    print(reviewer)

The result:
Alexander Hendorf
Almar Klein
Emmanuelle Gouillart
Fabian Pedregosa
Federico Vaggi
Kyle Kastner
Nelle Varoquaux
Nicolas P. Rougier
Pauli Virtanen
Thomas Kluyver
Valerio Maggio

I'm running out of time, and since this is not urgent, I leave it to someone else (or me, the week before the conf) to add this to the website.

Do we need to put the sponsors on the website?

Yes, I am about to prepare a page. So far we Enthought, The PSF, Python Software Verband,  and Python Academy. We can take all the infos and logos  from last years page. @almarklein can you prepare a markdown page? I can add the missing details.


Cache api data and images so that in case of network error we can show user some data instead of blank screen

/assign

/assign

@DonnieBLT For this issue, I am going to cache data only for "Issues" screen as that is the first landing screen of our app after authentication. Should I be caching Api data for leaderboards and all too?

Is this issue still being worked on or has it been fixed?
If not, may I work on it?


Specialization Trees

I just started using this game system and am entering things in from the book. Things look really good and I love the work you've put into it.
My issue is with specialization trees. When I created a new specialization, it does not allow me to enter text into any of the fields aside from the main one. There is no edit button to click on to enable text entry.

You drag talents into the boxes.

Isn't an issue but some sort of helper text/icon so instructions can be given. This would help clear up confusion for new users.

Not sure why not being able to add text to the various fields isn't an issue?

On 07/02/2021 1:56 PM Rysarian<EMAIL_ADDRESS>wrote:

Isn't an issue but some sort of helper text/icon so instructions can be given. This would help clear up confusion for new users.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/StarWarsFoundryVTT/StarWarsFFG/issues/934#issuecomment-873252525 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AUUR23W6TRXG2YIJ3WNQIOTTVYRY7ANCNFSM47M75MTA .

Talents can have automatically applied modifiers depending on if that talent is purchased on the spec tree.

Not sure why not being able to add text to the various fields isn't an issue?
…
On 07/02/2021 1:56 PM Rysarian @.***> wrote: Isn't an issue but some sort of helper text/icon so instructions can be given. This would help clear up confusion for new users. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub #934 (comment) , or unsubscribe https://github.com/notifications/unsubscribe-auth/AUUR23W6TRXG2YIJ3WNQIOTTVYRY7ANCNFSM47M75MTA .

Just some confusion at play here I think, those talent boxes are not manual entry fields, you drag talent items onto them.

right.  Here's the thing. I was creating a new specialization tree.  I have no way to edit the description fields for those talents on the specialization tree.  Or am I supposed to be linking those to a talent item?

On 07/04/2021 1:42 AM Rysarian<EMAIL_ADDRESS>wrote:

Talents can have automatically applied modifiers depending on if that talent is purchased on the spec tree.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/StarWarsFoundryVTT/StarWarsFFG/issues/934#issuecomment-873547643 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AUUR23UARQINLIFDJHE5WR3TWANFVANCNFSM47M75MTA .

Yup just drag the talent item onto that slot and voila.

Ah cool...that makes sense.  Thank you!

On 07/06/2021 3:38 PM Matt Stoolman<EMAIL_ADDRESS>wrote:

Yup just drag the talent item onto that slot and voila.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/StarWarsFoundryVTT/StarWarsFFG/issues/934#issuecomment-875128614 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AUUR23XDML2OJ6OMHYXJJF3TWOAXPANCNFSM47M75MTA .


[CERT-TEST-FAILURE] [TC-ICDB-1.3] Test failed - DUT Fails to Refresh Entry with New Key - Receives Status 0x87 (CONSTRAINT_ERROR) in Step 2b

Feature Area
Area:ICDPhase2
Test Case
TC-ICDB-1.3
Reproduction steps
At step 2b. According to the test plan, when the DUT receives a Check-In message with a Check-In Counter ICDCounter2 indicating that 2^31 counter values have been used, the DUT should refresh its entry with a new key Key2 via the RegisterClient command to the TH with the following details:
CheckInNodeID: CheckInNodeID
MonitoredSubject: MonitoredSubID
Key: Key2
However, in the current SDK, TH receiving the status 0x87 (CONSTRAINT_ERROR)
Command used to launch the DUT :./lit-icd-app --enable-key<PHONE_NUMBER>5566778899AABBCCDDEEFF
Command used to launch the TH: ./chip-tool pairing onnetwork 1 20202021
After the successful pairing entered to interactive mode using mentioned command - ./chip-tool interactive start
step 1 : TH sends {C_REGISTER_CLIENT} command.
CheckInNodeID: CheckInNodeID
MonitoredSubject: MonitoredSubID
Key: Key1
icdmanagement register-client 112233 1 hex:abcdef1234567890abcdef1234567890 0 1 0

[1725270357.500] [23820:23822] [DMG] Received Command Response Data, Endpoint=0 Cluster=0x0000_0046 Command=0x0000_0001
[1725270357.501] [23820:23822] [TOO] Endpoint: 0 Cluster: 0x0000_0046 Command 0x0000_0001
[1725270357.501] [23820:23822] [TOO]   RegisterClientResponse: {
[1725270357.501] [23820:23822] [TOO]     ICDCounter:<PHONE_NUMBER>
[1725270357.501] [23820:23822] [TOO]    }

icd wait-for-device 1 30 [1725270362.672] [23820:23820] [TOO] Command: icd wait-for-device 1 30
[1725270362.674] [23820:23822] [TOO] Peer is a registered LIT ICD.
[1725270362.674] [23820:23822] [TOO] Please trigger the device active mode.
[1725270368.005] [23820:23822] [EM] >>> [E:31729r S:0 M:254352686] (U) Msg RX from 0:88BEE2F5BF9325A3 [0000] --- Type 0000:50 (SecureChannel:ICD_CheckInMessage) (B:57)
[1725270368.005] [23820:23822] [EM] Handling via exchange: 31729r, Delegate: 0xaaaac19b25d0
[1725270368.006] [23820:23822] [ICD] Check In Message processing complete: start_counter=3083289412 offset=1 nodeid=<000000000000
Step 2a :
generaldiagnostics test-event-trigger hex:00112233445566778899AABBCCDDEEFF 0x0046000000000003 1 0

[1725270369.053] [23820:23822] [DMG] 	InteractionModelRevision = 11
[1725270369.053] [23820:23822] [DMG] },
[1725270369.053] [23820:23822] [DMG] Received Command Response Status for Endpoint=0 Cluster=0x0000_0033 Command=0x0000_0000 Status=0x0
[1725270369.053] [23820:23822] [DMG] ICR moving to [AwaitingDe]

STEP 2b - waited DUT refresh its entry with a new key Key2 via {C_REGISTER_CLIENT} command to TH: - CheckInNodeID: CheckInNodeID
MonitoredSubject: MonitoredSubID
Key: Key2**
However, in the current SDK, TH receiving the status 0x87 (CONSTRAINT_ERROR)

[1725270378.016] [23820:23822] [DMG] InvokeResponseMessage =
[1725270378.016] [23820:23822] [DMG] {
[1725270378.016] [23820:23822] [DMG] 	suppressResponse = false,
[1725270378.016] [23820:23822] [DMG] 	InvokeResponseIBs =
[1725270378.016] [23820:23822] [DMG] 	[
[1725270378.017] [23820:23822] [DMG] 		InvokeResponseIB =
[1725270378.017] [23820:23822] [DMG] 		{
[1725270378.017] [23820:23822] [DMG] 			CommandStatusIB =
[1725270378.017] [23820:23822] [DMG] 			{
[1725270378.017] [23820:23822] [DMG] 				CommandPathIB =
[1725270378.017] [23820:23822] [DMG] 				{
[1725270378.017] [23820:23822] [DMG] 					EndpointId = 0x0,
[1725270378.017] [23820:23822] [DMG] 					ClusterId = 0x46,
[1725270378.017] [23820:23822] [DMG] 					CommandId = 0x0,
[1725270378.017] [23820:23822] [DMG] 				},
[1725270378.017] [23820:23822] [DMG]
[1725270378.017] [23820:23822] [DMG] 				StatusIB =
[1725270378.017] [23820:23822] [DMG] 				{
[1725270378.017] [23820:23822] [DMG] 					status = 0x87 (CONSTRAINT_ERROR),
[1725270378.018] [23820:23822] [DMG] 				},
[1725270378.018] [23820:23822] [DMG]
[1725270378.018] [23820:23822] [DMG] 			},
[1725270378.018] [23820:23822] [DMG]
[1725270378.018] [23820:23822] [DMG] 		},
[1725270378.018] [23820:23822] [DMG]
[1725270378.018] [23820:23822] [DMG] 	],
[1725270378.018] [23820:23822] [DMG]
[1725270378.018] [23820:23822] [DMG] 	InteractionModelRevision = 11
[1725270378.018] [23820:23822] [DMG] },
[1725270378.018] [23820:23822] [DMG] Received Command Response Status for Endpoint=0 Cluster=0x0000_0046 Command=0x0000_0000 Status=0x87
[1725270378.018] [23820:23822] [ICD] RegisterClient command failed: IM Error 0x00000587: General error: 0x87 (CONSTRAINT_ERROR)
[1725270378.018] [23820:23822] [ICD] Re-registration with new key failed with error : IM Error 0x00000587: General error: 0x87 (CONSTRAINT_ERROR)

Bug prevalence
Everytime
GitHub hash of the SDK that was being used
708558881bf6e5b0dac3c09489124907927b6cd2
Platform
raspi
Anything else?
Test Plan Reference :
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/icdbehavior.adoc#tc-icdb-1-3-icd-check-in-protocol-client-response-dut_client
PFA Logs
TC-ICDB-1.3 - LIT-APP.txt
TC-ICDB-1.3 validation log.txt

working on the fix


Add fn to the list of invalid primitive values

I don't think a dangling fn is necessarily a problem, and the motivation for dangling references being UB (we want to be able to speculate dereferences) doesn't apply to there. But I suppose there's no harm in being overly broad in the nomicon until an explicit decision has been made.

I don't think a dangling fn is necessarily a problem

I thought it had to be forbidden because it could be called from safe code.

That's a good point, handing a dangling fn to safe code is certainly a one-way ticket to UB. However, there's a distinction between invariants that can be assumed to hold by other code, and invariants where it's instant UB to ever produce a value that violates it. In this case, safe (or sound unsafe) code can certainy assume fns are callable, but we may want to allow careful unsafe code to produce a dangling fn value if it's never called.

What does it even mean for a fn to be "dangling"? Usually, the part of memory where the assembly is stored is not considered "valid" for access by the program.

I thought it had to be forbidden because it could be called from safe code.

Safe code requires way more than we can make insta-UB. For example, safe code requires that a fn pointer will actually, when executed, not crash. We cannot even make this part of the definition of UB as that would make it cyclic.
So, we have to separate the discussion about invariants that must always be maintained lest you get UB, and the (much stronger) invariants that safe code can rely on. (Given how often I have written that in the last week, I should probably make this my next blog post.^^)

For now should I change this to forbid only null fn pointers?

Yeah, I think that makes most sense. We certainly cannot have them be NULL.

@RalfJung

What does it even mean for a fn to be "dangling"?

Not pointing to a function (of the right signature and ABI). Since we don't have a solution for code being unloaded at run time, that mostly just means making up an address that doesn't contain code and type-punning it to a fn value.
@nox

For now should I change this to forbid only null fn pointers?

I think either is fine. It's not that bad if the nomicon said something about dangling fns that turned out to be wrong, and as you noted on IRC this text doesn't really make the distinction @RalfJung explained.

Updated.


Integrate new PoST using AES

Motivation
Integrates the changes in post from https://github.com/spacemeshos/post/pull/103
Changes
New algorithms for generating and verifying proofs have been implemented. This PR integrates those.
Test Plan

Existing Tests need to pass.
New tests where applicable

TODO

[x] Explain motivation or link existing issue(s)
[x] Test changes and document test plan
[x] Update documentation as needed

DevOps Notes

[x] This PR does not require configuration changes (e.g., environment variables, GitHub secrets, VM resources)
[x] This PR does not affect public APIs
[x] This PR does not rely on a new version of external services (PoET, elasticsearch, etc.)
[x] This PR does not make changes to log messages (which monitoring infrastructure may rely on)

bors try

bors try

bors try

bors try

bors try

bors try

bors try

bors merge


--credentials filepath option for authentication from a file

Now that I'm building time-limited credentials in #27 it's getting pretty inconvenient to pass them as the --access-key and --secret-key and --session-key arguments.
I'm going to support a new option called --credentials which, if provided, is treated as the path (or - for stdin) to a JSON or INI file containing credentials.
The idea is that this will work:
% s3-credentials create mybucket --duration 15m > creds.json
% s3-credentials list-bucket mybucket --credentials=creds.json

It's a shame -c is already used as a shortcut for --create-bucket - maybe for this one I'll have a short option with a different letter, perhaps -x? Or -a for authentication?

I'm going to use --auth instead, for consistency with https://github.com/dogsheep/twitter-to-sqlite and so I can use -a as the shorter option.

Documentation: https://github.com/simonw/s3-credentials/blob/f7989bce2d4029f2d1ade098acb461995a149291/README.md#common-options


How to configure proxy?

I set http and https proxy before invoke hacknews_tui
export https_proxy=http://<IP_ADDRESS>:6152;export http_proxy=http://<IP_ADDRESS>:6152
But it did not work. I didn't find how to config http proxy in config file either.

Hi @sleetdrop. I have never used proxy server before, so I'm not sure how this works as well as how to implement the support. I'll try to read more about those when I have time.
That said, any PR is welcome.


Production Release - November 9th 2024

What does this PR do?

Create a Production build from the main branch

[x] I have verified that I am promoting the main branch, and not another development branch

What are the Trello stories being promoted in this release (please link)?

https://trello.com/c/aPsr8GIg/52-update-website-to-include-unabridged

Infrastructure Changes

[x] Relevant environment variables (and s3 uploads) have been updated before deployment

 Update website to include Unabridged


fix: VA, USA (counties -> cities)

all population errors resolved; 38 cities renamed from county; minor caps fix.

Ok this is awesome, but it does break the timeseries for 3/25 because the county names are different:
 yarn timeseries -l "VA, USA" -d 2020-3-25 -e 2020-3-25

Returns
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Buena Vista City, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Fairfax City, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Franklin City, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Lynchburg, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Manassas City, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Richmond City, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Roanoke City, no cache present

We will have to have a special case for those

Yeah I tried to take a look at this, but there is a lot to untangle. Can you go back and make it work for 2020-3-25?

@aed3 Are you able to review this change? I think you did a lot of work on VA's county/city names too right?

Ok this is awesome, but it does break the timeseries for 3/25 because the county names are different:
 yarn timeseries -l "VA, USA" -d 2020-3-25 -e 2020-3-25

Returns
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Buena Vista City, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Fairfax City, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Franklin City, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Lynchburg, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Manassas City, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Richmond City, no cache present
  ⚠ Cannot go back in time to get https://public.tableau.com/views/VirginiaCOVID-19Dashboard/VirginiaCOVID-19Dashboard.pdf?:showVizHome=no&Locality=Roanoke City, no cache present

We will have to have a special case for those

Those are the cities which were initially wrong, so there is no data for them the first day Virginia was being scraped. The fix would be to no check for them on that day,

Ok great, merging! Thanks for the review @aed3 !


add support for dotnet7 to alt:v

Description
add Support for dotnet7
All Submissions:

[x] Have you ensured there aren't other open Pull Requests for the same update or change?
[x] Have you created a new branch for your changes and PR from that branch and not from your master branch?

request from:
https://github.com/parkervcp/yolks/pull/43#issuecomment-1368214431


showing backup progress notice

Hi, Thank you for valuable extension!
It is so helpful extension, but there is one thing missing...
sometimes, it is not easy to check whether it is working or not.
so could you add some notification or progress bar when it is working ?
It will be perfect extension if it is added! 👍

This is not possible, because Joplin provides not status bar for plugins:
I already asked about this at the forum of Joplin, because my backup runs for about 20-30 minutes.
When a error occurese, then an error message should pop up.


Wallet password/name component implementation

Checklist

[ ] JIRA - <LW-8049>
[ ] Proper tests implemented
[ ] Screenshots added.

Proposed solution
This PR adds a component combining both password and name step on onboarding flow, this keeps the previous functionality of each component but combined into one.
Adds two new post hog events for the next click action of this component

onboarding | new wallet | wallet name & password | next | click
onboarding | restore wallet | wallet name & password | next | click

This component is designed to be used in the AB test, but, while we are waiting for the final implementation of Post Hog remote feature flag,  will be hidden behind an environment variable flag
Testing
To enable this feature the environment variable USE_COMBINED_PASSWORD_NAME_STEP_COMPONENT has to be set to true
Screenshots

Allure report
allure-report-publisher generated test report!

smokeTests: ❌ test report for 2258e109

passed
failed
skipped
flaky
total
result

Total
31
1
0
0
32
❌

@DominikGuzei  I think adding a basic fade-in effect when an element becomes visible is a good idea. I've tried different animations for this with the prototype, but a simple fade-in still seems better than other options or just suddenly appearing.
examples:
https://github.com/input-output-hk/lace/assets/8201486/579125e4-27f4-48fe-8660-e8704256d5f9
https://github.com/input-output-hk/lace/assets/8201486/3c70738c-d437-4ba9-bbca-953c13d6550f
https://github.com/input-output-hk/lace/assets/8201486/dce35701-0547-4daf-9d8a-9dd7e7735031
https://github.com/input-output-hk/lace/assets/8201486/c6c2519c-18dc-48a8-b8f8-21520cc73cdb

@jplorek-atix please merge the latest main branch

Small comment: When you access to the 'Let's set up your new wallet' step, the prompt is set in the 2nd (password) field instead of the first field (name)

@milagi added in e85262c


Initialize on several assemblies produces error in test discovery

Hello team Verify
We use Verify with Verify.DocNet in several test assemblies and updating to version 2.1.1 produced a errors in the test output saying that certain tests could not be discovered. The error was not recognized as a proper error and was difficult to find. The only symptom we had to go on was that tests just disappeared.
The messages in the test output were like the following :

MSTestAdapter failed to discover tests in class '[NameOfTestClass]' of assembly '[NameOfDLL]' because The type initializer for '' threw an exception..
No test is available in [NameOfDLL]. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.

We had to dig through the changes for this version and found that adding the following verification in our code fixed the discovery.
[ModuleInitializer]
public static void OnModuleInitialise()
{
    if (!VerifyDocNet.Initialized) // <- Added this line
        VerifyDocNet.Initialize();
    VerifyImageMagick.RegisterComparers(threshold: 1, ImageMagick.ErrorMetric.Absolute);
}

We think that the message "..The type initializer for ''.." comes from the error that is now thrown from the static VerifyDocNet.Initialize() method, but we're not sure because the origin message ("Already Initialized") isn't present, but i've seen that this sort of exception can have an inner exception that carries that sort of information, so maybe it's been lost by testhost.exe.
The verification isn't mentioned in the documentation on you github, so we're wondering if there's actually another cleaner way to do it, or if there's another fix that's necessary in the initialization code for Verify.DocNet.
Thanking you in advance !
Loren

do your test projects reference each other?

i thought i might have VerifyImageMagick.RegisterComparers in two projects. and one referencing the other. but that doesnt seem to be the case
can u provide a repro?

I'll see what I can do about a minimal repro for you. Might be a day or two
Thanks for having a look :)

Sorry, I gave it a go with a simple setup, but couldn't reproduce the bug.
I haven't found the time since, and it might be quite long to find the difference. I might have to leave it there.
We have a correction one way or another. Thank you for your time :)


Changing default behaviour of weight saving?

Currently the weight is saved every 500 steps which quickly fill up hard disk space. Is it possible to change that so it updates the weight during training?

Sure!
please do this:
model = GReaT(llm='distilgpt2', epochs=50,  save_steps=400000)


Always add GL objects to a context's doomed* lists.

Any pyglet program that spins up threads that eventually end up running python code, be that directly, or by playing audio, is vulnerable to extremely rare segfaults provoked by the garbage collector calling the __del__ method of VertexArrays or ShaderPrograms from foreign threads while the GL context of those objects is active.
This commit should fix this by unconditionally delaying the deletion of such objects into their context's doomed list.
Arcade appears to be using a strategy similar to this to navigate around the issue already: https://github.com/pythonarcade/arcade/issues/876, https://github.com/pythonarcade/arcade/blob/a5a0cd70e5482f0b23583226da8d0762119c373d/arcade/gl/context.py#L332
This could have been implemented differently by:

Comparing threading.current_thread() to threading.main_thread() or somehow recording the GL context's active thread as well and comparing against that, but i decided against it. That check would be unnecessary work for the only gain of calling the deletion function immediately; delaying the object deletion by one frame should not cause any harm.
Taking control of the garbage collector. Way too easy for this to go wrong.

Judging by the and False in delete_buffer, this problem may have been encountered and dealt with already some time ago. It's difficult to tell, as that dates back to the initial commit here: https://github.com/pyglet/pyglet/commit/2971856930543767fce6c73f29af9945c8bfa295
This could introduce more frequent leaking of OpenGL objects, as contexts do not delete resources when they are destroyed.
VAOs can easily be deleted in destroy, but for object spaces there'd need to be some kind of usage counter that causes the context to only delete the objects when it's the last one sharing it. Even that may be undesirable in case objects can somehow survive without a context, but i can't seem to find any info on that.
The leaking may not be too much of a problem, as most apps don't create an unbounded amount of windows/contexts in their lifetime, but it should be considered.
Edit: I additionally noticed that the classes Framebuffer, Renderbuffer, Shader and possibly the headless display still directly call gl functions in their __del__ methods, so this commit does not secure against everything.

While this change does seem necessary for some threading improvements, I feel like there may be some gotchas. It looks like these functions were guaranteeing that calling those functions meant either immediate deletion as long as you were in the main context or dooming it until it could be. If that's no longer the case, it could be a breaking change. For instance if you've never used a thread and you call del on a texture, then normally that's going to be immediately removed. However, that will no longer happen. If that's the case, I feel we may need to include a way to have an immediate deletion for some of these as well for people who aren't going to be using threading.
I am not 100% sure on the best practices though on how we should separate the behavior, or if it's even necessary.

I feel we may need to include a way to have an immediate deletion for some of these as well for people who aren't going to be using threading.

These changes behave similar whether multiple threads are present or not. Though for a program that only ever uses the main thread the doomed lists are a practically useless delay, yes.

While this change does seem necessary for some threading improvements

They do not improve threading, they prevent bad OpenGL calls causing a segmentation fault. Currently pyglet can and does segfault with programs that use a number of threads larger than one, especially easily if throwaway functions such as Label.draw are used.

For instance if you've never used a thread and you call del on a texture, then normally that's going to be immediately removed. However, that will no longer happen.

You are absolutely right with the textures and their immediate deletion being desirable. Textures can be extremely large and secretly deferring their deletion is definitely a bad idea, i did not quite think of that.
I never mentioned it, but i did miss a delete method on textures in the past. I think such a method on textures (and other objects) that simply assumes the user knows what they're doing and calls glDeleteTextures (or equivalents) would be a great addition.
While CPython does call __del__ immediately once the user removes all references to a texture, making a client pick apart all locations where it may be referencing a texture and then hope none was overlooked and __del__ will be intransparently called is unstable. A way of explicit deletion is far better than this implicit one.
It makes sense to keep __del__ as an emergency deletion mechanism only in case more basic users simply don't care about managing their resources. Having a "punishment" of a one-frame memory hog for that is acceptable imo, but yeah, you're right, constitutes a behavior change. Reverting the unconditional dooming and adding threading.current_thread() is threading.main_thread() would effectively make deletion immedate and safe again.
__del__ will remain necessary for the immediate user-facing things like shapes, sprites, windows, labels, textures and players. I think it may be a very good idea to remove as many finalizers as can be considered non-public and ensure the others are safe.

The project i am using for testing this primarily is https://github.com/nwg-piotr/squarely. (The name may have been a tiny influential factor :^) )
Originally i used it to test the audio branch, but after noticing the segfaults and investigating, it became my goto for this.
It uses a thread to make highscore board requests, plays audio and draws a few labels each frame, making it trigger the problem with some amount of likelihood:
Fatal Python error: Segmentation fault

Current thread 0x00007fd52e3eb6c0 (most recent call first):
  File "/home/square/Code/python/pyglet/pyglet/gl/base.py", line 397 in delete_vao
  File "/home/square/Code/python/pyglet/pyglet/graphics/vertexarray.py", line 43 in __del__
  File "/home/square/Code/python/pyglet/pyglet/media/drivers/openal/interface.py", line 251 in unqueue_buffers
  File "/home/square/Code/python/pyglet/pyglet/media/drivers/openal/adaptation.py", line 205 in _handle_processed_buffers
  File "/home/square/Code/python/pyglet/pyglet/media/drivers/openal/adaptation.py", line 193 in _update_play_cursor
  File "/home/square/Code/python/pyglet/pyglet/media/drivers/openal/adaptation.py", line 231 in _get_write_size
  File "/home/square/Code/python/pyglet/pyglet/media/drivers/openal/adaptation.py", line 241 in refill_buffer
  File "/home/square/Code/python/pyglet/pyglet/media/mediathreads.py", line 56 in run
  File "/home/square/.pyenv/versions/3.8.17/lib/python3.8/threading.py", line 932 in _bootstrap_inner
  File "/home/square/.pyenv/versions/3.8.17/lib/python3.8/threading.py", line 890 in _bootstrap

Thread 0x00007fd53f3b9040 (most recent call first):
  File "/home/square/Code/python/pyglet/pyglet/gl/lib.py", line 80 in errcheck
  File "/home/square/Code/python/pyglet/pyglet/graphics/vertexbuffer.py", line 130 in __init__
  File "/home/square/Code/python/pyglet/pyglet/graphics/vertexbuffer.py", line 219 in __init__
  File "/home/square/Code/python/pyglet/pyglet/graphics/vertexdomain.py", line 125 in __init__
  File "/home/square/Code/python/pyglet/pyglet/graphics/vertexdomain.py", line 315 in __init__
  File "/home/square/Code/python/pyglet/pyglet/graphics/__init__.py", line 307 in get_domain
  File "/home/square/Code/python/pyglet/pyglet/graphics/shader.py", line 920 in vertex_list_indexed
  File "/home/square/Code/python/pyglet/pyglet/text/layout.py", line 563 in place
  File "/home/square/Code/python/pyglet/pyglet/text/layout.py", line 1850 in _create_vertex_lists
  File "/home/square/Code/python/pyglet/pyglet/text/layout.py", line 1369 in _update
  File "/home/square/Code/python/pyglet/pyglet/text/layout.py", line 1445 in _init_document
  File "/home/square/Code/python/pyglet/pyglet/text/layout.py", line 1481 in on_style_text
  File "/home/square/Code/python/pyglet/pyglet/event.py", line 401 in dispatch_event
  File "/home/square/Code/python/pyglet/pyglet/text/document.py", line 390 in insert_text
  File "/home/square/Code/python/pyglet/pyglet/text/formats/plaintext.py", line 11 in decode
  File "/home/square/Code/python/pyglet/pyglet/text/__init__.py", line 191 in decode_text
  File "/home/square/Code/python/pyglet/pyglet/text/__init__.py", line 446 in __init__
  File "/home/square/Games/raw_python/squarely/squarely/game_objects.py", line 1523 in score_label
  File "/home/square/Games/raw_python/squarely/squarely/game_objects.py", line 1493 in update_score_labels
  File "/home/square/Games/raw_python/squarely/squarely/tools.py", line 543 in update_scores
  File "main.py", line 423 in update
  File "/home/square/Code/python/pyglet/pyglet/clock.py", line 217 in call_scheduled_functions
  File "/home/square/Code/python/pyglet/pyglet/app/base.py", line 224 in idle
  File "/home/square/Code/python/pyglet/pyglet/app/base.py", line 163 in run
  File "/home/square/Code/python/pyglet/pyglet/app/__init__.py", line 76 in run
  File "main.py", line 448 in main
  File "main.py", line 496 in <module>
zsh: segmentation fault (core dumped)  PYTHONFAULTHANDLER=1 PYENV_VERSION="arcade_runner38" python3 main.py

I think i'll come up with changes similar to the ones i outlined soon, but since they will be different from this PR, i'll do that in a new one.


Get rid of Jira/Unito comments in GH

It seems the entire GH has been polluted by Jira notifications.
Can we get rid of that and remove all of the pollution?

┆Issue is synchronized with this Jira Task by Unito

All of those notifications should be removed from existing issues. There is really no reason for that to be there.

We should also revoke permissions of the bot so it cannot make this mess again.

its done... Jira comments are not synced with gh now..

I still see the messages on the issues.


Is there a way to include nvim-qt on Windows?

Hi,
This is the first time I have used bob, is there a way to include nvim-qt? I did not see it mentioned in the readme. In the case that it actually should be available, there are the steps I took to get started:
bob install nightly
bob use nightly
ls C:\Users\xxx\AppData\Local\bob\nvim-bin\

    Directory: C:\Users\xxx\AppData\Local\bob\nvim-bin

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----        18/03/2023   9:10 PM        4768768 nvim.exe

Currently you can just copy nvim-qt to the nvim-bin folder, if you really need it I will simply add it and create a new release

Having nvim-qt copied automatically would be much appreciated as I use it frequently. Copying only nvim-qt.exe to the bin folder was not sufficient in my test. I had to copy all the dependencies out of nvim-win64 to the bin folder to use nvim-qt.

Fair enough, I will try proxying nvim-qt just like nvim bin.
Also sidetracking a bit why do you bother using nvim-qt for a neovim gui? there are much better alternatives like gonvim.

Every few months I try goneovim, fvim and neovide. Each time I have encountered issues I can't easily ignore. Stuff like blank tabs, obscured completion popups from the cursor moving sporadically, occasional crashes and other strange rendering issues. Nvim-qt has never been my first pick for a GUI, but it has been reliable, so I haven't had much patience with the other options to try find workarounds unfortunately.

@Kamholtz can you copy the bob exe from the PR's actions artifacts? once downloaded rename bob to nvim-qt, add it to nvim-bin and run nvim-qt.exe from the cmd line

I can confirm it's working for me @MordechaiHadad. Thank you very much!

I can confirm it's working for me @MordechaiHadad. Thank you very much!

Awesome you can keep it like this and you wont have to touch nvim-bin again, Ill add a feature for bob to auto add nvim-qt to nvim-bin.
Also I assume you use a config, did you feel any increase in startup time(became slower)?

Also I assume you use a config, did you feel any increase in startup time(became slower)?

I use a reasonably large personal config, I did not notice an increase in startup time.

@Kamholtz can you remove nvim-qt, switch to a different version and see if nvim-qt is automatically copied to nvim-bin/

I have downloaded the artifacts from comit 83e6906 and have confirmed that after removing nvim-qt, I can use a different version and observe nvim-qt being copied to nvim-bin. I have been able to successfully switch between nightly and stable.
I see that there have been further changes since that commit. Let me know if you're ready for me to do another test.

that's awesome to hear, if you can try current build, if it works fine I will create a new release!

Using the artifacts from 7d4c0b7b0dbf13f7cd9bf971c8b3e9c27517d82d  I have confirmed that the executables appear in nvim-bin after the command bob use nightly. I have also confirmed that I can switch from nightly and stable successfully.
Thank you for taking the time to support this!


CSRF Token Expired Expired causes a crash in GridField Item Requests

In 3.6.1(and I'm assuming previous 3.x chain) if the CSRF token expires (or does not match) the page will crash rather than displaying the CSRF expired message. The crash is caused in the Form class on line 383 where it calls controller redirectback. I think a potential fix would be to simply define redirectBack in GridFieldDetailForm_ItemRequest wrapping the top level controller's redirect back.
Full Error:
[Error] Uncaught Exception: Object->__call(): the method 'redirectback' does not exist on 'GridFieldDetailForm_ItemRequest', or the method is not public.
framework/core/Object.php:780

Object->__call(redirectBack,Array)
Form.php:383
ResourceGridField_ItemRequest->redirectBack()
Form.php:383
Form->httpSubmission(SS_HTTPRequest)
RequestHandler.php:288
RequestHandler->handleAction(SS_HTTPRequest,httpSubmission)
RequestHandler.php:200
RequestHandler->handleRequest(SS_HTTPRequest,DataModel)
RequestHandler.php:222
RequestHandler->handleRequest(SS_HTTPRequest,DataModel)
GridFieldDetailForm.php:102
GridFieldDetailForm->handleItem(GridField,SS_HTTPRequest)
GridField.php:981
GridField->handleRequest(SS_HTTPRequest,DataModel)
RequestHandler.php:222
RequestHandler->handleRequest(SS_HTTPRequest,DataModel)
RequestHandler.php:222
RequestHandler->handleRequest(SS_HTTPRequest,DataModel)
Controller.php:158
Controller->handleRequest(SS_HTTPRequest,DataModel)
LeftAndMain.php:464
LeftAndMain->handleRequest(SS_HTTPRequest,DataModel)
AdminRootController.php:92
AdminRootController->handleRequest(SS_HTTPRequest,DataModel)
Director.php:385
Director::handleRequest(SS_HTTPRequest,Session,DataModel)
Director.php:149
Director::direct(/admin/my-model-admin/MyModel/EditForm/field/MyModel/item/422/ItemEditForm,DataModel)
main.php:191

+1
We've been seeing this issue on one of our sites for a little while, but have been unable to pinpoint the exact cause.

It's the call to redirectBack() in Form, the only fix I can think of would be to define a wrapper in GridFieldDetailForm_ItemRequest that calls the top level contoller's redirect back.

Makes total sense. It's been a pain to troubleshoot, since we have thus far been unable to reliably reproduce. Glad to see a well-known name in the SS community reporting this issue.

the fundamental issue is really that the ItemRequest is passed to a form as the controller when it is not a controller.
this is a duplicate of https://github.com/silverstripe/silverstripe-framework/issues/3760

#3760 was a bug for the v4 series, though, and has already been fixed. This bug affects the v3 series, and is still an issue. Therefore, I don't think this bug should've been closed.

@jchenevey that issue was reported in 2015, long before the real development of 4 started. It's been closed because the issue is fixed in 4 (there are a lot of issues in 3 which are being closed as fixed in 4 because the effort vs reward of fixing in 3 isn't there).
If someone wishes to move redirectBack onto RequestHandler instead of Controller and allow Forms to work with RequestHanlder objects instead of Controllers then that would no doubt be accepted into the 3 branch.

see https://github.com/silverstripe/silverstripe-framework/issues/3760#issuecomment-300436176


Remove JUPYTER_IMAGE env variable from notebook container

JIRA: RHOAIENG-13602
Description

Simply remove the env variable from the codebase as mentioned.
How Has This Been Tested?

Try to create a workbench, and make sure it can successfully run.
Test Impact

N/A, just modified the mock data based on the change.
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[ ] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

/hold
IDE conversations is happening


add doc page for using GPUs with EKS-A

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm

/cherry-pick release-0.18


drivers: serial: ns16550: Add IOPORT_ENABLED check condition

io_map check to enable LPSS DMA initialization is kept under condition IOPORT_ENABLED.
This fixes the error caused in case of no io-mapped UART instances in dts of a board because io_map variable not defined.
Signed-off-by: Anisetti Avinash Krishna<EMAIL_ADDRESS>

You could probably simplify the code with something like the following:
#define NS16550_IO_MAPPED(cfg) COND_CODE_1(UART_NS16550_IOPORT_ENABLED, (cfg)->io_map, false)

You could probably simplify the code with something like the following:
#define NS16550_IO_MAPPED(cfg) COND_CODE_1(UART_NS16550_IOPORT_ENABLED, (cfg)->io_map, false)

Looks like a good approach for other checks, but does not help with this one.