🐞 Jump to def do not support alias import

What is the issue?
@jlongtine reports that jumps to definition do not supported aliased import.
To fix this issue, we must find a way to register imported package and his aliases in the file.
:bulb: This issue will be updated when we will have more details on it
Log output
No response
Steps to reproduce
No response
Dagger version
culls 0.3.3
OS version
/

Quick example/repro:
Works
package test

import (
	"dagger.io/dagger"
	"dagger.io/dagger/core"
	"strings"
)

dagger.#Plan & {
	actions: stuff: op: core.#Nop & {
		input:  strings.TrimSpace("testing...   ")
		output: "testing..."
	}
}

Doesn't work
package test

import (
	dg "dagger.io/dagger"
	"dagger.io/dagger/core"
	"strings"
)

dg.#Plan & {
	actions: stuff: op: core.#Nop & {
		input:  strings.TrimSpace("testing...   ")
		output: "testing..."
	}
}


Feature request: foldingathome service, make passkey and account-token option and passkey-file, account-token-file

As of right now there's no secure option to pass a string/file to --passkey and --acount-token arguments in fahclient making it basically impossible to store the nix file with this service in git repo and etc... Would really be glad if someone added passkey and account token options directly to the declaration of the module

Add a :+1: reaction to issues you find important.

@zimbatm Could you please look into it?

Sorry, my backlog is full right now


Blog post: Introduction to GraphQL and GraphBack

Motivation
Blog post from the point of view of the person trying to start with GraphQL explaining concepts and introducing graphback
CC @MStokluska for ideas/discussion

The idea for now is to create an entry level introduction to GraphQL, with no front end covered. Something clear - but not oversimplified. Make it a little bit difficult so whoever is going to follow the tutorial will appreciate what GraphBack can do !
My primary target audience are students that are only starting with client server architecture and REST. So 3rd - 4th years in college.
Any suggestions ?

Sound like very good plan. Over the next week we are going to focus on generating client so you could get that for free

@wtrocki think this can be closed?


[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-01-01

If you are a MSFT employee you can view your work branch via this link.
Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-python

Can one of the admins verify this patch?

Automation for azure-sdk-for-js

Automation for azure-sdk-for-ruby

Automation for azure-sdk-for-go

Validation status before changes introduced in this branch/PR
Not mandatory to be fixed with this PR, these are the results of the validation before your changes, please refer to the following link:
https://portal.azure-devex-tools.com/app/branch/bgsky/azure-rest-api-specs/dev-consumption-Microsoft.Consumption-2019-01-01...master

Automation for azure-sdk-for-java

@bgsky thanks for the details, yes agree with you, validation errors has nothing to with this PR, approving.
Created an issue https://github.com/Azure/azure-rest-api-specs/issues/5625 to fix the examples. Please triage this with in your team and assign it to the right dev.

@anuchandy Thanks for your comments. Consumption will propose a new preview version to address scope validations.


[zh] Sync /concepts/configuration/secret.md

Sync with the en version #34291
content/zh-cn/docs/concepts/configuration/secret.md

Preview: https://deploy-preview-37049--kubernetes-io-main-staging.netlify.app/zh-cn/docs/concepts/configuration/secret/

/approve

/lgtm


Items are too far down if app is launched horizontally

I'm setting up the TabBar correctly, everything works and looks fine when I'm starting the app in portrait orientation. Although, if I start it holding iPhone horizontally and then turning it to portrait, icons somehow are too far down and I can see ~60% of them.
What can cause this or how can I avoid it?

Same issue, were you able to solve this?


Iphone 6 Jailbreak Exploiting 21/38

message:
Jailbreak Completed
JailBreak Completed with Status:
Exploited kernel_task.
Set HSP4 as TFP0
Unexported kernel  task port
Dumped APTicket
Overwrote boot nonce
Logged slide.
Logged ECID.
Enable Auto Updates.
Remounted RootFS
Enabled App Revokes
Created jailbreak directory
The device will now respring.
And nothing, no cydia install, what can i do??
Airplane mode on and wifi on

u0 doesnt have full support for 4k decides, so Cydia isnt bunled yet.

interesting, thank you :D well i wait for next update


chore(test): move navigation_spec off of the control flow

@cnishina , could you take a look at this PR, please
I have checked that TravisCI run configs that should be disabled now. I have added a fix to .travis.yml. I think it is the simplest way to skip long tests that are flaky on Travis, but maybe you would prefer to do it in a different way.

Reference #4995

Thank you!


fix(sdk): deduct already retrieved amount

What this PR does / why we need it:
This PR deducts already retrieved amount from the amount required to cover for the outputs, and network fee. Builder like InstantTrader that are built on top of PSBTBuilder retrieve UTXOs on their own, and let PSBTBuilder only fetch additional if there's a need.
Also, change output has been decoupled from outputs for keep a clear separation of user provided outputs and auto-calculated (change) output.

Tested.
Standard BTC send tx
New inscription tx
Instant-trade existing inscription tx


Discrepancy in makemore_part1_bigrams single sample draw

When I run the makemore_part1_bigrams notebook, in the cell where we draw a single sample based on probability distribution in the first row of N, I get a different sample ( 'c' ) compared to the one in the video ( 'm' ). Everything else until then seems to be the same, with manually seeded generator, I'd expect even this to match exactly.
Value in this repo (and the video):

My run:

I have pushed the full run until this cell in the commit here.
What am I missing?

This seems to be bug in pytorch 2.0.0 when calling multinomial with num_samples=1. If you run the same code using pytorch 1.13.1, you will get the correct result.

Thank you! This solves the problem. Thread to the original discussion here.


Trying to fix Out-of-Memory on unit tests (with TransNet changes)

Fixes #437
Includes changes from #434
Proposed Changes

Renames some unit tests to be more friendly to filtering/matching
Changes Pytest CI to split tests up per invokation, hopefully avoiding the out-of-memory error (this can be tweaked to use different splits in the future). Coverage report should be automatically merged together.

Checklist

[x] I have read the CONTRIBUTING guide
[x] My PR is based from the current GaNDLF master
[x] Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change
[x] Function/class source code documentation added/updated
[x] Code has been blacked for style consistency
[x] If applicable, version information has been updated in GANDLF/version.py
[x] If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file
[x] Usage documentation has been updated, if appropriate
[x] History has been updated, if appropriate
[x] Tests added or modified to cover the changes; if coverage is reduced, please give explanation
[x] If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3,4]

Marked as ready for review so that @sarthakpati can merge ASAP if the tests pass before I wake up in the morning. This has all Sofia's changes so credit goes to her.


v1.10 backports 2021-05-26

#16126 -- docs: various fixes to documentation, notably Getting Started Guides (@nbusseneau)
#16263 -- docs: Fix Helm instructions for BGP (@xentobias)
#16293 -- docs: Fix WireGuard spelling (@gandro)
#16081 -- docs: Update troubleshooting for 1.10 (@twpayne)
#16268 -- pkg/k8s: ignore namespace events that do not change labels (@aanm)
#16288 -- docs: remove 1.7 upgrade guide and add upgradeCompatibility for 1.9 (@aanm)
#16211 -- envoy: Remove request headers from response access logs (@jrajahalme)
#16286 -- pkg/k8s: set right logic to ignore ipcache errors (@aanm)

Skipped:

#16274 -- .github: Fix scheduled end-to-end tests (@pchaigno)
(Relevant check_changes checks are absent from v1.10.)
#16310 -- .github: Fix concurrency group comment triggers (@pchaigno)
(Relevant concurrency and check_changes checks are absent from v1.10.)

Once this PR is merged, you can update the PR labels via:
$ for pr in 16126 16263 16293 16081 16268 16288 16211 16286; do contrib/backporting/set-labels.py $pr done 1.10; done

My bad, switching to draft until https://github.com/cilium/cilium/pull/16269 is merged.

https://github.com/cilium/cilium/pull/16269 was merged, this needs a rebase.

Closing in favour of #16384.


ci: spike plato static analysis

Ticket Number
UCD-831 (ish)
Description of change
POC of static analysis?
this tool hasn't picked up on es2021 yet so i had to knock the linting rules back to es2020, that may be reason enough to decline this PR;
in the meantime, unless anyone's merged into master and published over my cheeky test-publish:
https://foundry4.github.io/appeal-planning-decision/PLATO_appeals-service-api-complexity/index.html
Checklist

[ ] Requires infrastructure changes
[ ] If adding or remove environment variables (e.g. in docker-compose.yaml) then I have updated the appropriate Helm chart
[ ] I have updated the documentation accordingly
[ ] My commit history in this PR is linear
[ ] New features have tests
[ ] Breaking change (team conversation required)

Important
Please do not merge from master (please only rebase). This keeps the history linear and easier to debug.

It doesn't seem to have broken the lining so I don't think that'll be a problem. I can't remember why I changed to es2021 (probably for either optional chaining or ??) but it seems to pass with es2020 so it's not the end of the world


Godot crashes on Fedora 34 on launch

Godot version:
3.3.stable.mono.official
OS/device including version:
Fedora 34
OpenGL ES 3.0 Renderer: Mesa Intel(R) Iris(R) Plus Graphics 640 (Kaby Lake GT3e) (KBL GT3)
Issue description:
There's a crash on application launch. No project needs to be loaded. At a high level, I'm suspicious this is due to Fedora's move from pulseaudio to pipewire. Additionally installing the pulseaudio-libs-devel library has no effect. I have also verified that /lib64/libpulse.so.0 does exist - which I believe is provided as a pass through to pipewire.
Godot Engine v3.3.stable.mono.official - https://godotengine.org
OpenGL ES 3.0 Renderer: Mesa Intel(R) Iris(R) Plus Graphics 640 (Kaby Lake GT3e) (KBL GT3)
OpenGL ES Batching: ON
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib64/libc.so.6(+0x3d310) [0x7f6768fac310] (??:0)
[2] AudioDriverPulseAudio::pa_sink_info_cb(pa_context*, pa_sink_info const*, int, void*) (??:?)
[3] /lib64/libpulse.so.0(+0x1bc46) [0x7f6749c95c46] (??:0)
[4] /usr/lib64/pulseaudio/libpulsecommon-14.2.so(+0x45683) [0x7f6749c37683] (??:0)
[5] /usr/lib64/pulseaudio/libpulsecommon-14.2.so(pa_pdispatch_run+0x15f) [0x7f6749c3808f] (??:0)
[6] /lib64/libpulse.so.0(+0x14813) [0x7f6749c8e813] (??:0)
[7] /usr/lib64/pulseaudio/libpulsecommon-14.2.so(+0x4ac27) [0x7f6749c3cc27] (??:0)
[8] /usr/lib64/pulseaudio/libpulsecommon-14.2.so(+0x4c79f) [0x7f6749c3e79f] (??:0)
[9] /lib64/libpulse.so.0(pa_mainloop_dispatch+0x1b3) [0x7f6749ca2573] (??:0)
[10] /lib64/libpulse.so.0(pa_mainloop_iterate+0x3a) [0x7f6749ca2bca] (??:0)
[11] AudioDriverPulseAudio::detect_channels(bool) (??:?)
[12] AudioDriverPulseAudio::init_device() (??:?)
[13] AudioDriverPulseAudio::init() (??:?)
[14] AudioDriverManager::initialize(int) (??:?)
[15] OS_X11::initialize(OS::VideoMode const&, int, int) (??:?)
[16] Main::setup2(unsigned long) (??:?)
[17] Main::setup(char const*, int, char**, bool) (??:?)
[18] ./Godot.64(main+0x69) [0xe40d79] (??:?)
[19] /lib64/libc.so.6(__libc_start_main+0xd5) [0x7f6768f96b75] (??:0)
[20] ./Godot.64() [0xe410ae] (??:?)
-- END OF BACKTRACE --
Aborted (core dumped)

Steps to reproduce:
Boot a fresh download of the currently available Godot Mono 64-bit binary on Fedora 34.
Minimal reproduction project:
No project required.

Could you test the following?

Does the official 3.2.3 work?
Does the Fedora package godot work?

The current one in F34 is godot-3.2.3-2.fc34, though there's a pending update to 3.3 which will be pushed to stable tomorrow: https://bodhi.fedoraproject.org/updates/FEDORA-2021-b7350a1a03
It would be good to test both if you can.

You can also try starting the Godot binary with the --audio-driver ALSA command line argument.

3.2.3.stable.mono.official - crashes the same way with the same backtrace
3.2.3-2.fc34 (from dnf) - crashes the same way with generally the same backtrace
3.3.stable.mono.official with --audio-driver ALSA - crashes the same way with the same backtrace when loading a project, however it at least opened the project manager window.

So, the actual window shows up, then it crashes which makes it seem like it's a runtime error. Maybe there's a bug in the pipewire passthrough?

3.3.stable.mono.official with --audio-driver ALSA - crashes the same way with the same backtrace when loading a project, however it at least opened the project manager window.

This is because the command line argument isn't passed on from the project manager to the editor. If you edit a project directly from the command line by specifying the path to a project.godot file along with --audio-driver ALSA, it should work.

Ahh I see, I didn't realize it wasn't passing through. That appears to be a valid workaround, thank you for unblocking me! Anything else I can help with around figuring the root of this bug out?

I'm also on Fedora 34 and don't have this issue. Since this appears to be related to Pulseaudio somehow. Fedora 34 switched to Pipewire as the new default for audio. Maybe there was some issue when you upgraded to Fedora 34? Have you tried to manually (re)install pipewire-alsa and pipewire-pulseaudio?


About the U_part

Hi, thanks for your works. I'm confused with the U_part in the code now. It seems mismatching with the Algorithm 1 ProSparse self-attention in the paper that U=mln n which is not multiplied by the factor c.
U_part = self.factor * np.ceil(np.log(L_K)).astype('int').item() # c*ln(L_k)]

Hi, thanks for your works. I'm confused with the U_part in the code now. It seems mismatching with the Algorithm 1 ProSparse self-attention in the paper that U=mln n which is not multiplied by the factor c.
U_part = self.factor * np.ceil(np.log(L_K)).astype('int').item() # c*ln(L_k)]

Hi, in our implementation, we set U_part to c*m*ln(n) to make the value of U_part not too small, so as to ensure the stability and better effect of the model.

Thank you for your answer!


Updating release notes

Fixes #4074
This fixes the counts, but also reduces the list by excluding "obsoleted" terms for the "changed labels" and "changed definitions" sections.

You should also try this..


Regenerated EventGrid data plane SDK based to include new event types.

Regenerated EventGrid data plane SDK based to include new event types.

Can one of the admins verify this patch?

Codecov Report

Merging #2607 into master will increase coverage by <.01%.
The diff coverage is 62.79%.

@@            Coverage Diff             @@
##           master    #2607      +/-   ##
==========================================
+ Coverage   56.24%   56.24%   +<.01%
==========================================
  Files        6434     6447      +13
  Lines      140006   140130     +124
==========================================
+ Hits        78743    78819      +76
- Misses      61263    61311      +48

Impacted Files
Coverage Δ

.../container_registry_image_pushed_event_data_py3.py
80% <100%> (ø)
:arrow_up:

...id/models/iot_hub_device_deleted_event_data_py3.py
80% <100%> (ø)
:arrow_up:

azure-eventgrid/azure/eventgrid/models/__init__.py
100% <100%> (ø)
:arrow_up:

...id/models/iot_hub_device_created_event_data_py3.py
80% <100%> (ø)
:arrow_up:

.../azure/eventgrid/models/event_grid_client_enums.py
100% <100%> (ø)

...container_registry_image_deleted_event_data_py3.py
80% <100%> (ø)
:arrow_up:

azure-eventgrid/azure/eventgrid/version.py
100% <100%> (ø)
:arrow_up:

...ages_available_with_no_listeners_event_data_py3.py
36.36% <36.36%> (ø)

...messages_available_with_no_listeners_event_data.py
36.36% <36.36%> (ø)

...ages_available_with_no_listeners_event_data_py3.py
36.36% <36.36%> (ø)

... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdb837...5fb80b0. Read the comment docs.


dedicated directory for pulse transformations in the transpiler

In #5752 there is some code added to compile to pulses (by adding specific pulse calibrations for gates). These ended up in the scheduling folder but that's not a suitable place, as that folder is more about timing of gates via delays.
Pulse compilation is analogous to the defcals in openqasm3, so we should create a place for those and consolidate any other pulse transformations that are currently happening in Qiskit under there.

Is this moving file from one folder to another ?

Is this moving file from one folder to another ?

Hi @amitracal yes, qiskit/transpiler/passes/scheduling/calibration_creators.py and qiskit/transpiler/passes/scheduling/rzx_templates.py should be moved to a new folder specifically for pulse compilation. And if there is any similar pulse transformation code elsewhere in Qiskit that should also be moved into the new folder

I am new and I would like to work on this issue if its ok.

I am actually working on it, can you please choose another one ?

ok

Closing this issue as it was taken care of in #6759


package-shared unittest functions should not be under version(unittest)

Package-shared artifacts used only for unittesting should not be versioned with version(unittest) because that precludes unittesting one or more modules against the build library. Example:
make std/experimental/logger.test

has link-time errors. This PR fixes them.

Incidentally there's a speedup too:
make -j8 BUILD=debug unittest

takes 48 seconds on my laptop, whereas
make -j8 BUILD=debug std.test

takes 45.

Also tried on a big iron at work with -j64, 24s with the old unittest target, 20s with the new one (debug mode).

LGTM

Auto-merge toggled on

@andralex  https://github.com/D-Programming-Language/phobos/pull/3400


Minor fixes

change in PhaseSlopeIndex.jl

squeezing psi_std before return

changes in example.jl:

removing Random.randperm from imports
replacing NaN with 0 for plotting the psi_std
replacing psi_se with psi_std
replacing standard error with standard deviation (in text)

Codecov Report

Merging #4 (9fc7325) into master (f61ce73) will decrease coverage by 2.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   68.25%   65.81%   -2.45%
==========================================
  Files           1        1
  Lines         126      117       -9
==========================================
- Hits           86       77       -9
  Misses         40       40

Impacted Files
Coverage Δ

src/PhaseSlopeIndex.jl
65.81% <100.00%> (-2.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f61ce73...9fc7325. Read the comment docs.


Solution to #19917, alternative GUI for codelens that preserves line heights

In #19917 people raised the issue of codelens making text jump, and went to great length devising a solution with caching, animation delays and etc. Despite the effort spent, the existing solution only partially mitigates the issue, but introduces a lot of complexity for a "half measure."
I propose a much simpler GUI that will preserve line heights and allow for codelens to still run in one go:

Add a new column next to line numbers and show counts there. This way line heights will remain unchanged. And it be possible to quickly hide/show it without triggering a laggy reflow.
I feel that 16/9 screen are becoming more common than 4/3 or 5/4 screen these days. Why not to use extra screen width that now comes for free?
@jrieken @lonix1

Great idea for another reason - codelens sometimes feels like a distraction/messy, sitting right above my code, but it's still so useful. This is a nice compromise.

Add a new column next to line numbers and show counts there

You say counts but reality is that there are longish labels in there. I have hard time imagining how this should look. Given the sample below can you mock up something (photoshop, paint...)

Code lenses are horizontally oriented (partially long text, expand to the right), a number column will almost never give even a remotely similar experience. What might be a good use for such an extra column is to add markers for code lense lines. They are sometimes difficult to spot.

It's true that one can only stuff so much info into a narrow column - so it can have only a marker that represents the codelens. And on hover it shows a popup with the whole horizontal text.
Then codelens is there, you know it's there and can see it, but it doesn't get in your way until you need it.

@jrieken Shure! Give me a day or two

@jrieken Shure! Give me a day or two

Thanks - remember, nothing crazy needed just some quick sketches "on paper". I share the same scepticism as @mike-lischke as most code lens are designed to fill a row

I uploaded mockups to
https://github.com/baybal/vscode-gui-design-mockups
First idea is to use some onhover popups and a "tip" icon that will trigger them. I think this has more or less clear implementation way. A very easy way to avoid reflows without API change. The downside is that things like warnings are kind of obscure until you hover over them. For that, I suggest to have colour variation or graphic effect put onto tip icon if there are warnings like messages in the lens.

Second, is to expand on the customisable "tip" and display some kind of "shorthand" representation to lens messages. This will require API changes, and we may explore this is you are ready for them.

Third idea is to put a column left or right of the text, where a wrapped text of the lens will be show. You can add some spacing or separators in between lens messages. If lens messages will overlap, you can put text-overflow: ellipsis on the text, or some visual effect to signal the overlap. The user will be then able to click on or hover over the particular lens to raise it. This design also allows avoiding text reflow, but the amount of effort to code it seem to be bigger to me that the two above. It also allows to preserve existing VS "comic book" style popups more or less unchanged.
If you want to lookup existing implementations, you can check how Google Docs does comments, and edit suggestions. MS Word has something similar, but doesn't layout comments nearly as much as good as Google Docs do.

@jrieken @lonix1

@baybal Your ideas are awesome. So neat... less cluttered than current codelens. Thanks for your efforts, I hope this will be seriously considered!

Is this like the gitlens gutter?

While I appreciate the nice designs from @baybal  (which however also have usability issues like the mid gray text on a light gray background -> difficult to read), I'm generally not very fond of these ideas. The code lenses are not only about git commits, which indeed could go into a space-saving popup. Instead they can show all kind of information (like reference counts for methods/rules), which must not be hidden permanently, or they will be totally useless. Code lenses are a totally different UI element than gutter information, and serve different purposes.
I stand by my previous verdict: if we can avoid frequent animations then the current implementation is totally fine.

I think he took git information only as an example.
I agree that codelens is also about method references, etc. That is what I am most interested in.
But I like the idea of hiding that info until it is actually needed. Personally I find that info to be noise most of the time, until I actually need it (in which case it is right there in the margin, will be shown on hover).

@jrieken Yes, that UI is also fine, if there will be provisions for "smart" wrapping and/or multi-line output with rolodex effect (probably using z-order)
@mike-lischke exact choice of colour scheme was not my concern here, but yeah, I think something like code lens text should also be theme stylable, and not hardcoded
I also provided opinion above what I think about code lens output that has to be visible all the time: use some kind of shorthand output that will later be expanded in a more complete popup. Like "R:5" for reference count

Moving them out of the editor would make actions like running tests much less convenient:

If they're moved out, please make it a user or extension preference. I'd prefer the editor shift than have these actions not immediately visible.

fyi - there is an exploration item about rendering code lenses at the end of lines: https://github.com/microsoft/vscode/issues/90235


fix the readme

@shrawani21 Kindly add the labels to this issue and assign me.
There is a problem in the preview of the Readme file.
I'll fix the Readme file: make the headings look better and create proper links.

Hey @arpy8 @shrawani21 , I can fix the readme file and update it into more appealing and easy to understand for users and other contributors. I can also add a table of content to make the navigation easier. And I could add detailed instructions on installation, setup and contributions. I can begin working on this issue right away. Let me know if there are any specific details or guidelines I should be aware of before I start.
Can you assign me this issue under GSSoC'24 as a contributor?

@arpy8 @shrawani21  Can you please assign this issue to me. I can improve the README file to make it more user-friendly, including adding a table of contents and detailed setup instructions.


Array syntax parsing compiler error

The following program causes a segfault during build.
pub fn main() -> %void {
    var b: u8[40] = undefined;
}

Run with the following command:
zig build_exe test.zig

Current master branch compiler with release mode.
565ac3e27acedcd8dd2e39eff07de571bbcc3a1b

I presume I haven't missed anything and this syntax is invalid in all cases. If so, it would be good to have a good parse error for this since it is quite an easy mistake to make especially if one is more familiar with c array declarations.

Thanks for the report. Fixed


Install/run Consul under consul user

Not as root.

@smn: ready for review

:+1:

@smn: I nearly made things extra not idempotent :(
This is why we use puppet and not shell scripts

Obsolete.


Add edpm_multipathd role

Add edpm_multipathd role to install, configure and run the multipathd daemon. Also configure nova-compute with the necessary volume mounts in order to interact with the multipath subsystem.
Jira: OSP-26557

It seems that the edpm-ansible-molecule-edpm_nova job is failing complaining about missing /etc/multipath.conf
Probably this new role should be called before edpm_nova role?
cc @cjeanner @raukadah

@ASBishop can you take a look at the edpm-ansible-molecule-edpm_nova job log?
https://review.rdoproject.org/zuul/build/1bcc0befd4bd40c18884fbc06f2b8e3f

recheck

recheck

recheck

recheck

recheck

recheck
lots of gateway timeouts

recheck

/retest


On the react interface, add "Determination" and "Review" buttons

Upon click
If draft exists, load the draft, if no draft, create a draft
Collapse the leftmost screening sidebarS
Shift the proposal page left and replace status/notes with a determination/review form
Autosave draft as things are inputted
Have a X/Close icon in the top right of that pane
Upon click of X/Close, resize/go back to all default view

@frjo seems like this requires respective APIs to create/edit/retrieve reviews and determinations. Given that the reviews and determinations apps are now kind of similar, apis implementation would also be somewhat similar. So we can focus first on review APIs and then determination APIs:

First problem that comes to mind is, given that our fields are dynamic how will frontend know what fields to show in the form:

To solve this we can have an endpoint(submissions/id/reviews/fields) to list details of all the fields available in the review form of a submission. Which frontend can use to construct the form.
We can get the fields by using get_fields_for_stages for a submission.

Second, we also need to have a serializer defined to validate the submitted data from frontend:

This requires us to create serializer fields dynamically from streamfield blocks, we can do this similar to how we create form fields from streamfield blocks.

Once the data is validated from serializer we can do all the processing that we do while handling the form data and save the Review object.

@sks444 Implementing this first for Reviews sounds good. Will be easy to replicate that for Determinations later.

Making a TODO of things done and of things needs to be done to help the development process:

[ ]  Get a dynamic serializer working with only a few stream field blocks

[ ]  /submissions/id/reviews/fields Develop an api to list available review fields according to a submission stage, which frontend would use to submit a review.

[ ] /submissions/id/reviews/ Develop an api to create reviews, validate the post data through dynamic serializer and save the review object. Should also return the serialized review object in the response which should be same as the response of /submissions/id/reviews/id.

[ ]  /submissions/id/reviews/id Develop an api to get the details of a review, response should also include opinions on the review, and fields like recommendation, score, visibility along with recommendation comments and other submitted answers.

[ ] /submissions/id/reviews/ Develop an api list all the reviews on a submission. Cunstruct the serializer based on the context data and only include the fields which are included there.

[ ] /submissions/id/reviews/id Develop an api to update/edit a review, this should fairly be similar to create review api.

[ ] /submissions/id/reviews/id/ Develop an api to delete a review.

[ ] /submissions/id/reviews/id/opinions Develop an api to create review opinions on a review, include it in the SubmissionReviewViewSet with action, no need to create a separate ViewSet. I think review opinion options could be hardcoded in frontend, as it is only Agree and Disagree.

[ ] Check if correct users has right permissions on all the apis. May need to develop permission classes for write and read review and include it in the view.

[ ] Make support of other stream field blocks to dynamic serializer.

[ ] Make support for custom field serialization to dynamic serializer. I.e. ScoredAnswerField

[ ] Structure code, create a review directory, where review views, utils and mixin could be included.

[ ]  Write documentations where needed.

[ ]  Get the react developer to start implementing the review apis in frontend. And make improvements to the apis according the frontend requirement.

[ ] Write unit tests for all the apis for which tests are possible.

[ ] Start working on the determination apis.

Some Updates:

Create a mapping of form fields to serializer fields. A reference could be taken from how rest framework maps model field to serializer field. Use this mapping to get serializer field class from form field class from stream field blocks.

Seems like mapping is not necessary for now as the form fields we use has respective fields with same name in Serializer. We can implement this later maybe while implementing determination apis if needed.

/submissions/id/reviews/ Develop an api list all the reviews on a submission. Cunstruct the serializer based on the context data and only include the fields which are included there.

List view of reviews with django forms is pretty good. So I have commented out the apis for this for now. Maybe we can do this later once the initial feature of review has been implemented in frontend.

Make support for custom field serialization to dynamic serializer. I.e. ScoredAnswerField

[ ] This is still in TODO. ScoredAnswerField accepts inputs in form of list, so I am using ListSerializer for now. But the validation of the values in the list has to be done.

TODOs:

[ ]  Allow create and edit apis to be saved as draft.

Along with above two only the testing of the apis is remaining.
All the work has been pushed at https://github.com/OpenTechFund/hypha/pull/2101
Here is a link to postman collection of the apis which can be imported for testing purposes. We can not use the automatic generated doc for post apis as the tool doesn't yet support dynamic serializer.

I was able to create and submit a review within the React app.

@frjo, next, I have been working on the determination apis.
We are planning to not support the old determination django forms in the api and react interface. Basically we will only show Add determination button in React app for funds which have set new streamfield forms. And not show for funds which uses old determination forms.
Since they are being deprecated, it wouldn't be worth the effort of handling two flows in the apis. Here are the steps that we need to do for the support:

Check if streamfield form is not attached render api fields for old django forms.
Handling the two flows of and saving and retrieving the submitted data: as earlier we used to save it in data field instead of form_data.
Handling the grouping of fields for the detail page.

There are other benefits of not having this in our code like cleanliness and consistency with our review api code.
Let us know your opinion on this.

@sks444 Definitely the right call to not support the old determinations forms in the API/React app.

Open funds on test site doesn't have the stream field determination form attached.
Add determination feature in react is only available on submissions for funds which have the determination form attached. I have added new fund https://test-apply.opentech.fund/add-determination-test-react-app/ which can be used for testing purposes.


Find a way to check power usage

Is this checking something like the voltage being pulled? Or the CPU usage?

I think it would be cool to know how much power your cpu is using, and then how much battery percentage is being used in general

I'm on it

Awesome!!

I cannot find a way to check the individual power consumption of the CPUs only the power consumption of the entire machine. Which is not that useful anyway because the amount of power being consumed by a computer varies depending on the hardware.

That's alright, I wasn't sure if there was a way to find it. I'll probably close the issue, or put a pin in it or something, if we happen to stumble upon a way to calculate that info in the future.

I think u can check the current TDP on Intel CPUs

Oh! That would be cool!

Try cat /sys/class/power_supply/BAT0/power_now  and see if it works on your system
It should return the current CPU TDP in µW

It has these two

yeaaa the voltage is the voltage, u can calculate the TDP if you have current, but without that its useless because Intel has disabled voltage modification to patch a hardware venerability
The charge is just how much juice you've got left
Try power_now on your desktop

It doesn't look like it's there

sad
hmm maybe there's some other ways to find it

lol i spent like 2 hrs digging, only found this

I figured it out we can use ohms law by taking .../BAT0/voltage_now and multiplying that by .../BAT0/current_now to find the wattage

See https://github.com/polybar/polybar/blob/master/src/modules/battery.cpp

I figured it out we can use ohms law by taking .../BAT0/voltage_now and multiplying that by .../BAT0/current_now to find the wattage

Yea but that's what I was saying before, we only have the voltage and the charge, current is missing

I figured it out we can use ohms law by taking .../BAT0/voltage_now and multiplying that by .../BAT0/current_now to find the wattage

Yea but that's what I was saying before, we only have the voltage and the charge, current is missing

current_now is the current

I figured it out we can use ohms law by taking .../BAT0/voltage_now and multiplying that by .../BAT0/current_now to find the wattage

Yea but that's what I was saying before, we only have the voltage and the charge, current is missing

current_now is the current

We don't have current_now on our laptops, only voltage_now and charge_now

I figured it out we can use ohms law by taking .../BAT0/voltage_now and multiplying that by .../BAT0/current_now to find the wattage

Yea but that's what I was saying before, we only have the voltage and the charge, current is missing

current_now is the current

We don't have current_now on our laptops, only voltage_now and charge_now

I have it on my computer strange...

Yeah, might be something with the newer Intel systems' BIOS (there was a vulnerability regarding to IccMax and VCCIN a few months ago on intel 8th - 10th gen processors, maybe the manufactures released BIOS that locked the current down to patch it)

Ahh, hm, we can check if it exists and if it does, calculate it, if not, then don't but I'm not sure

It has these two

em I thought u already checked it lol

It doesn’t exist on my new laptop (X1 Extreme running i7-8850H), but it does for my very old laptop (T60 running Core 2 Duo)

Yee, we could have something in code saying
if voltage_now.exists() && charge_now.exists() {
    then calculate
} else {
    don't
}

Sure, but we probably can't use TDP to do much useful things (like auto limit clockspeed based on TDP) because it seems like a lot of computers don't have it)

yea, we can put it on the back burner and not worry about it unless someone wants to work on it

yee


Get keyboard input when app is not in focus

Electron version: 0.3.7
Operating system: Mac

Wondering if it is possible to get keyboard input when the app is not in focus? Similar to electron.screen.getCursorScreenPoint(), I would like something like electron.keyboard.on('keypress'). I don't even need the key codes pressed, trying to implement "idle" detection for my app.
Any advice would be much appreciated

You will need to use the native platform APIs to detect system idle time, either by writing a native Node module or using node-ffi, this was discussed previously in https://github.com/atom/electron/issues/1528

Thanks!


tuya fan firmware 1.2.2

i fugured i would try my luck again I am trying to flash a tuya based ceiling fan that has firmware 1.2.2 and mcu 1.2.2 it tells me when I try that it doesn't result in a success and exits I am using the option that says version 1.2.2 light is there a different  option I should try if need be I can attempt to do a dump of the existing flash.
Here are photos of the board and model info if it helps

Fan and light are different firmwares (even if the fan has a light).  You'll probably need to dump this one.

thank you i kind of figured it would be different but was unsure how to see if I can figure out the dumping of the firmware as this will be my first time having to lol

I should also add, that is an unlabeled module, so it is no guarantee it is Beken.  It could also be Realtek or LightningSemi.
https://github.com/tuya-cloudcutter/tuya-cloudcutter/wiki/FAQ#im-not-sure-what-module-is-in-my-device-how-do-i-find-out is the only guidance we have, but it is far from perfect.

I will give that a rea and the second antenna is for the RF remote I would assume and the date on the box is 2022 so I would love love to find out it has a 8266 just because it might be simpler lol

based on mac address is is either a bekten or a realtek

well I tried lightleak to dump the chip and all got was that the device failed to stop responding so I guess I will now pull the chip and see what happens


upgrade apache drill

The url for 1.7.0 has disappeared and none of the mirrors seem to provide it any longer.

Not a simple fix. There are breaking changes between 1.7 and 1.8 or 1.9


Images on Header is ruptured after running document.merge_templates() - 'The picture can't be displayed'

Problems:
Images on Header is ruptured after running document.merge_templates()

I have tested that the images is ruptured right after running the code :
       document.merge_templates([giaTriFields], separator="page_break")
Expected Behavior
Should be show as the template docx file:

Solved :
🚫🚫 Do not use .merge_templates : # document.merge_templates([giaTriFields], separator="page_break")
✅✅Change to .merge: document.merge(**giaTriFields)
Your Environment

Python version: Python 3.8.19
docx-mailmerge version: docx-mailmerge2 0.8.3

Thanks for the detailed report.
If the header/footer contain an image or something that contains an unique ID, the proper way is to use merge and not merge_templates.
I just noticed you mention the solution yourself.
The right implemenatation that takes care of this is a little bit more difficult. I have already fixed it and will include it in a next release. However, it only works if you have just one row in the replacements, which is equivalent to the merge() function anyways.


add cors config to caddy (stats)

https://github.com/threefoldtech/grid_deployment/commit/eed9487eb64667ff5e88595c20bbae9979243ea4
this issue was resolved by @hossnys , just adding it to the repo


Get initial RTD build working

Requires some tweaking of the readthedocs.yaml configuration apparently.

Build is functioning and jupyter notebook syntax highlighting works as well.
There is an existing issue with the API docs not generating, but that is due to a packaging issue that will be fixed elsewhere.


Hover doesn't work properly with Selenium

I.Hover('some-selector') isn't working properly on Selenium. The mouse moves, however, it doesn't appear to be scoping the hover in the context of the browser window.

Confirmed issue in Selenium provider, will fix this week. Thx Judah

Fixed correctly, finally.

About time, boy! ;-) Fix FluentAutomation bugs instead of TC Startup Weekend, eh?

for about 30 reasons, Startup Weekend didn't happen for me. Hopefully
Eric does something awesome.
On Sat, Feb 11, 2012 at 11:10 PM, JudahGabriel
<EMAIL_ADDRESS>wrote:

About time, boy! ;-) Fix FluentAutomation bugs instead of TC Startup Weekend, eh?

Reply to this email directly or view it on GitHub:
https://github.com/stirno/FluentAutomation/issues/42#issuecomment-3925822


Add support for :scope

Hi.
It would be awesome to include a shim for the scope pseudoelement. This allows to select direct children of an element. For example:
ul.querySelectorAll(':scope > li:nth-child(odd)');

You can see an implementation here:
https://github.com/oscarotero/d.js/blob/master/d.js#L332

so few lines, yet so much room for improvements ... I'll consider this change, thanks for filing it

v2 is out with :scope support :tada:


yelp2018使用单卡和4卡数据并行也都跑不出来，请问是正常的吗？

Hi,
we use a single A100 GPU card for training, and it runs smoothly with current code. Maybe you can try with a GPU with larger memory.


Disable Spamassassin Subject Tag

Is there a way to disable the sa_spam_subject_tag in /etc/amavis/conf.d/20-debian_defaults?
Spamassassin shall not add ***SPAM*** to the mail subject.

Hi @elbracht, true this file and let me know (not tested)

I found the following on https://wiki.apache.org/spamassassin/SubjectRewrite:
Warning: if you are running SA through amavisd or qmail-scanner, those apps do their own message rewriting and SpamAssassin cannot perform these rewrites.

Is it possible to change the amavis configuration outside the container?

Implemented in #596


Errors with mysql driver

Hi, I am using remote mysql database from my webhosting provider and sometimes I get errors like this
node:27) DeprecationWarning: MessageEmbed#addField is deprecated and will be removed in the next major update. Use MessageEmbed#addFields instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
There was an uncaught error Error: Connection lost: The server closed the connection.
    at Protocol.end (/home/container/node_modules/mysql/lib/protocol/Protocol.js:112:13)
    at Socket.<anonymous> (/home/container/node_modules/mysql/lib/Connection.js:94:28)
    at Socket.<anonymous> (/home/container/node_modules/mysql/lib/Connection.js:526:10)
    at Socket.emit (node:events:525:35)
    at endReadableNT (node:internal/streams/readable:1358:12)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  fatal: true,
  code: 'PROTOCOL_CONNECTION_LOST'
}
There was an uncaught error Error: Cannot enqueue Query after fatal error.
    at Protocol._validateEnqueue (/home/container/node_modules/mysql/lib/protocol/Protocol.js:212:16)
    at Protocol._enqueue (/home/container/node_modules/mysql/lib/protocol/Protocol.js:138:13)
    at Connection.query (/home/container/node_modules/mysql/lib/Connection.js:198:25)
    at /home/container/utils/db/mysql.js:78:21
    at new Promise (<anonymous>)
    at DatabaseExample.getThreadsInGuild (/home/container/utils/db/mysql.js:77:16)
    at Object.run (/home/container/commands/threads.js:11:30)
    at Client.<anonymous> (/home/container/index.js:158:11)
    at Client.emit (node:events:513:28)
    at InteractionCreateAction.handle (/home/container/node_modules/discord.js/src/client/actions/InteractionCreate.js:83:12) {
  code: 'PROTOCOL_ENQUEUE_AFTER_FATAL_ERROR',
  fatal: false
}
There was an uncaught error Error: Cannot enqueue Query after fatal error.
    at Protocol._validateEnqueue (/home/container/node_modules/mysql/lib/protocol/Protocol.js:212:16)
    at Protocol._enqueue (/home/container/node_modules/mysql/lib/protocol/Protocol.js:138:13)
    at Connection.query (/home/container/node_modules/mysql/lib/Connection.js:198:25)
    at /home/container/utils/db/mysql.js:78:21
    at new Promise (<anonymous>)
    at DatabaseExample.getThreadsInGuild (/home/container/utils/db/mysql.js:77:16)
    at Object.run (/home/container/commands/threads.js:11:30)
    at Client.<anonymous> (/home/container/index.js:158:11)
    at Client.emit (node:events:513:28)
    at InteractionCreateAction.handle (/home/container/node_modules/discord.js/src/client/actions/InteractionCreate.js:83:12) {
  code: 'PROTOCOL_ENQUEUE_AFTER_FATAL_ERROR',
  fatal: false
}

commands are failing and threads are not being reopened.
When I restart the bot it works for some time but then again this.

Can you fix it?
https://stackoverflow.com/questions/37619977/error-cannot-enqueue-query-after-fatal-error-in-mysql-node

I do not get the same error on my host but I'll make sure connection gets handled correctly when implementing MySQL on v2


Support watchify pipe output option

The watchify docs say:
--outfile=FILE, -o FILE

This option is required. Write the browserify bundle to this file. If
the file contains the operators `|` or `>`, it will be treated as a
shell command, and the output will be piped to it.

Problem is that if you provide the outputfile something like the examples given
-o 'exorcist static/bundle.js.map > static/bundle.js'

globify does not recognise it as such and creates a folder instead.

This is related to Issue #11, since supporting output to stdout would also support piping to other programs.


Generic Map?

Thoughts on adding a generic map similar to map from clojure? I've seen some call it fmap (the haskell naming) and figure it would be a pretty easy addition.
usage
(fmap #'1+ '(1 2 3 4))

@Gavinok Thanks for the thoughts.  Interesting idea.  For lists, of course, there is already mapcat, but Clojure's map accepts multiple collection types. It also yields a lazy sequence as output, which I'm explicitly avoiding for now.  I will have to think about whether a generic implementation makes sense here.  Going to leave this issue open in case anyone else wants to weigh in.


ol.Style.Icon offset/anchor + rotate

Hi, I have the following problem: I have an wind direction arrow with coordinates and I have a background image which points to the same coordinate as wind direction arrow. This arrow needs to be moved to the correct position relative to the background image (inside the white circle) and rotated there. So far I haven't found a solution how to do it...
This is what I want to achieve: https://i.imgur.com/Fu7i9vX.png. This is the code I use: https://jsfiddle.net/AJR80/phwq2v1k/. In the JSFiddle wind arrow has large red background for testing purposes to see the image edges.
Is it possible to do what I want or is there a go around available?
Cheers,
Antti

It is possible by specifying a custom geometry for the 2nd style, with an offset from the original geometry. See https://jsfiddle.net/phwq2v1k/4/.

Thanks! I'll have a go with that solution!

Okay, it kind of worked since the code moves the arrow to new coordinates. I bit hackish way to solve the problem. Is there a way to solve this in another way with offsets/anchors whatever without altering coordinates? Was expecting Openlayers to support this kind of operation.

How do you solve the rotation of the wind direction icon angle?


ECLI (and PP) extensions

Manually merged (without the judicialis parts to keep relying only on official sources).


number of matches

Is it possible to specify the number of matches that will be further used for evaluation (for example for findEssentialMat )   in  the code?

Hi,
you can select matches with data['mconf'].


HitomiError [INVALID_VALUE]: extension must be valid

Description of bug
An error occurs randomly when I try to get image URIs of this gallery: 3165326
It also occurs on other gallery, and I had no reason to single out this gallery.
Though I had no idea what's the clear cause that would trigger this bug.
Code:
import hitomi from 'node-hitomi';

(async () => {
    const getImageUrl = async function getImageUrl(image: hitomi.Image, extension: "avif" | "webp", options: { isThumbnail?: boolean | undefined; isSmall?: boolean | undefined; }) {
        await hitomi.ImageUriResolver
            .synchronize()
            .catch(err => {
                return Promise.reject(err)
            });

        return await hitomi.ImageUriResolver.getImageUri(image, extension, options);
    }

    hitomi.getGallery(3165326)
        .then(g => {
            g.files.forEach(v => {
                getImageUrl(v, "webp", {})
                    .then(u => console.log(u))
            })
        })
        .catch(e => console.log(e))
})();

Output:
HitomiError [INVALID_VALUE]: extension must be valid
    at w.getImageUri (D:\Projects\Sandbox\node_modules\node-hitomi\library\index.js:1:4749)
    at getImageUrl (D:\Projects\Sandbox\main.js:13:61)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

Note that the error would happen inconsistenly.
About 2 out of 5 tries results in this error, and it doesn't persistently happen on one same image.
Expected behavior
No error happen and it would return the image URI as intended
Screenshots

Environment

OS: Windows 10
Version

NodeJS: 20.10.0
Package: 8.0.6

Even after several dozen attempts across different operating systems using the provided code, I was unable to reproduce the issue. I believe additional context about your environment will be necessary for further investigation.

Could you tell me what could cause this error?

According to the verification logic, the extension error might occur either because an invalid extension was used, or because the image lacks the corresponding has property (e.g., hasWebp).
Since I suspect it's the latter in your case, to troubleshoot, it would be helpful to check the Gallery.files array to ensure that all images can generate a webp uri.

That's the weird part
The error is inconsistent, which means there is time when the error didn't occur.
The tested gallery is only one, and it's confirmed all images can generate webp uri.
Although the error can also occur in other gallery.
Is it possible the error origins from getGallery() method?
It could be that it returns an incomplete result at Gallery.files, since that's the values used for ImageUriResolver.getImageUri()

After checking several raw gallery responses, I discovered the cause of this strange behavior.
While I'm not certain exactly when it happened, it seems that after hitomi dropped support for legacy image extensions, they modified their code to bypass the validation logic when retrieving webp images.
Additionally, I believe the issue was further compounded by a problem in the switch-case logic, leading to unpredictable errors.
So I have published a new version of the package that fixes this problem, and if the error persists, please let me know!

After several tests, it seems like the fix indeed solved this error.
I'll close it with this, thank you for your hard work!


fix: add manual dispatch

Trying to debug why the workflow won't trigger automatically on release

Trying to debug why the workflow won't trigger automatically on release

Github by default doesn't allow you to trigger workflows from other workflows. you need to build the "deploy to container registry" into the main workflow. you CAN trigger this if you manually create the tag though. at least that's what I've found previously based on what it seems like you're looking for

Trying to debug why the workflow won't trigger automatically on release

Github by default doesn't allow you to trigger workflows from other workflows. you need to build the "deploy to container registry" into the main workflow. you CAN trigger this if you manually create the tag though. at least that's what I've found previously based on what it seems like you're looking for

Thanks for clarifying this!


Update dependencies and workflows

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (419f185) to head (9c60873).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #163   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           68        68
  Lines         1395      1395
  Branches       104       104
=========================================
  Hits          1395      1395

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Run integration tests on external pull requests

Right now we don't run integration tests on external pull requests because there is no way to securely use the credentials to handle the VMs.
This leads to the increasingly frequent external PRs to break master. For instance https://github.com/weaveworks/scope/issues/2175

https://github.com/weaveworks/scope/pull/2135 is a great example of a PR in which we need integration tests for better quality assurance.

CC @marccarre

Jenkins' GitHub plugin has a bot that asks on external PRs if it is "ok to test". When someone whitelisted by the config comments "ok to test" on the PR (after testing that circle.yaml is not modified to print the credentials), Jenkins runs the test.
Could CircleCI have something like that?

Related: https://github.com/weaveworks/scope/issues/2193 and  https://github.com/weaveworks/scope/issues/2270

As a remark, it's possible to mimic the same setup in a fork (e.g. https://github.com/kinvolk/scope have done it), it requires setting up your own infrastructure, which is hard and and creates a lot of friction.

Why do we have "Build forked pull requests" turned off at CircleCI when there is a separate setting "Pass secrets to builds from forked pull requests" that meets the requirement stated at the top?

@2opremio You said you had some ideas to fix this. Do you think you could summarise them here?


Does it still using dev branch? why not stable branch

Btw I have successfully used the package and it's working perfectly fine I just wondering why it's still use the dev branch

I think it's on stable version, v13

Then change the description lol
On Tue, Aug 24, 2021, 5:08 PM Ankit Malik @.***> wrote:

Closed #3 https://github.com/DiabolusGX/djs-buttons-pagination/issues/3.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DiabolusGX/djs-buttons-pagination/issues/3#event-5200205560,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMXTCNDVZ2A2FVWVYDC3BSDT6ODT3ANCNFSM5CWTIFKA
.


RA crash when calling println! in proc-macro

Hello, I came across this issue while tinkering with one of my own macros. It seems the use of a println!() in a derive macro causes it to happen:
#[proc_macro_derive(Hello)]
pub fn hello(_: proc_macro::TokenStream) -> proc_macro::TokenStream {
    println!("fail"); // This will cause the error
    proc_macro::TokenStream::new()
}

I'm using rustc 1.5.0 & RA v0.2.513
Originally posted by @pauldorehill in https://github.com/rust-analyzer/rust-analyzer/issues/7103#issuecomment-794577271

Using println! / eprintln! is useful for debugging macros that don't work: getting a message that the macro server crashed can be at bit misleading... it can make you think that some of the code you changed has caused something to go very wrong even if the macro is working 🙃
As an aside if you use eprintln! the console prints all the vscode error json fail{"message":"struct is never constructed: ...}

Yes, eprintln is fine, println isn't.

I believe it ignores any lines that don't start with {.

That's something we could do as well, isn't it? (We could even collect those lines and show them somewhere...)


Enable Trace Logs on IBM MQ provider Classes

Hi there,
I am trying to print the headers that are being sent while putting the message on MQ using this starter.
I tried setting the property as mentioned in Logging section but the IBM MQ logs are not printed. Can somebody please let me know on how to enable the trace logs for the ibm mq provider classes ?
The package makes use of the logging capabilities within Spring. You can enable tracing of this specific component in your application's properties file by setting logging.level.com.ibm.mq.spring.boot=TRACE. Otherwise it uses the standard inheritance of logging configuration from logging.level.rootdownwards.

MQ JMS classes can be traced with a system property. Set com.ibm.msg.client.commonservices.trace.status to "ON".
Also read the docs here.
But that might be way too much information as that's the kind of trace primarily intended for IBM service to interpret. While you can see the message you've sent, it's going to be buried in a lot of other stuff.


Feature: add focus to shell input when click anywhere

When click to shell, I want my mouse will focus to command input. This PR will add a function javascript to detect onclick (check not selecting text too).

Thanks @flozz for review my code.
I'll close this PR since it has already in https://github.com/flozz/p0wny-shell/pull/23

Thanks @flozz for review my code.
I'll close this PR since it has already in https://github.com/flozz/p0wny-shell/pull/23


admin api support help message

Issues associated with this PR
Your PR should present related issues you want to solve.
Sign the CLA
Make sure you have signed the CLA
Solutions
You should show your solutions about the issues in your PR, including the overall solutions,
details and the changes. At this time, Chinese is allowed to describe these.
UT result
Unit Test is needed if the code is changed, your unit test should cover boundary cases, corner cases, and some exceptional cases.
And you need to show the ut result.
Benchmark
If your code involves the processing of every request, you should give the Benchmark Result
Code Style

Make sure Goimports has run
Show Golint result

Codecov Report

Merging #804 into stable will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           stable     #804      +/-   ##
==========================================
+ Coverage    55.5%   55.55%   +0.05%
==========================================
  Files         232      232
  Lines       23625    23634       +9
==========================================
+ Hits        13112    13130      +18
+ Misses       9313     9306       -7
+ Partials     1200     1198       -2

Impacted Files
Coverage Δ

pkg/admin/server/server.go
89.65% <100%> (+0.36%)
:arrow_up:

pkg/admin/server/apis.go
40.56% <100%> (+4.85%)
:arrow_up:

pkg/module/http2/server.go
81.77% <0%> (+0.07%)
:arrow_up:

pkg/module/http2/transport.go
78.73% <0%> (+0.29%)
:arrow_up:

pkg/stream/stream.go
60% <0%> (+13.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff58694...df2b7d0. Read the comment docs.


Added external link to nexrender-action-template-unzip

I see there is already another package on the same topic, but this has a different approach that tackles following issues:
1st: the structure of files within the ZIP might differ from one to another - a user could zip files in the root or a directory within the zip or whatever (users can be messy)
2nd: the name of .aep file is not known and in fact, is not important - the ZIP templates are being worked by the .zip basename.

Amazing! Thanks for the new action! :D


[Feature][cherry-pick][branch-2.5] use Array for DLA (#12952)

What type of PR is this：

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_fe_unittest

run starrocks_fe_unittest


onBlur is not called when year/month mode is activated

I'm Submitting a ...

[X] Bug report
[ ] Feature request
[ ] Support request

Steps to Reproduce
Configure datepicker in year or month mode.
Expected Results
User selects year/month and the blur event will triggered.
Actual Results
Blur event isn't triggerd at all when in mode month/year.

I don't think this is a bug.  The blur event isn't supposed to trigger when selecting year or month.  Selecting the year then triggers the month to be displayed, then clicking on month triggers the day to be displayed.  Only when the day is finally selected will the blur event be triggered.

You have misunderstood me.
I'm talking about when the component isn't in date mode configured. Event is missing when the component is an month picker or an year picker.

I too came across this when using dateFormat={'MM/YY'}. It seems that onBlur is called for the <input/> but not for the <div class="rdtPicker"/>.


Add Feature Policy for Autoplay

What do you think @mounirlamouri?

Whoops!
There were 1 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/updates/2017/09/autoplay-policy-changes.md#L155 - '

lgtm
/cc @rebeccahughes

I've reopened it at https://github.com/google/WebFundamentals/pull/5364

Looks good, do we want to mention its behind chrome://flags for now?

That is a great idea. I'll update the PR to incorporate these changes as well.


It messes the absolute paths

After the image upload the server responds with the following:
{"image":{"url":"/tinymce_assets/AQEAAAAAAAAAB7Ho8_zNDQUAAA9CQA==.png"}}

And the editor displays the image just fine. However, once I persist the output that the editor generates the path gets messed up and turns into the following:
../tinymce_assets/AQEAAAAAAAAAB7Ho8_zNDQUAAA9CQA==.png

My bad. Turns out it's TinyMCE itself trying to be too smart


"Delivery fee" causing unmatching of purchases

Colorado implemented a $0.27 delivery fee per order, or not, depending on if the order has sales tax or not.  This makes the tagger not match entries from your credit card because it is off by $0.27 cents.

Thanks for filing. To help inspect what's going on I've placed a small order and selected a CO address. I saw the fee you were describing and will take a closer look at what the amazon data says to see if this is feasible to detect automatically.

Note for myself, details on the law are here.

@uofm-matt Hi Matt, I have implemented this feature and it should be functional as of release 1.53. Please try again and let me know if you run into any issues. I'll preemptively close assuming it works.

@jprouty I downloaded it and gave it a try and it errored out on me while downloading the csv files.  It's worked before except for the tagging, is it likely on my end?  Attached is the error.

What platform/OS are you running on? I'll see if I can replicate

Windows 11 with Chrome 106.

I am unable to replicate it myself. Can you attach the logs from C:\Users\jeffp\MintAmazonTagger\Tagger Logs (where jeffp is your windows user)? Please look for the latest log file that contains logs similar to the error you see in the window. Thanks

After working on https://github.com/jprouty/mint-amazon-tagger/issues/116 tonight, I am convinced you are running into the same issue. Please try 1.54 and see if that helps. Also, it doesn't happen 100% for me, and re-running it up to 4 times should ensure you get through regardless (based on an untested hypothesis). Let me know how it goes!

Wasn't sure where you'd like the logs, but here they are.   Still having issues with 1.54 erroring while trying to download the csv files.
2022-09-30_08-44-23.log

Thanks for the logs. Yes, your stack trace is identical to issue https://github.com/jprouty/mint-amazon-tagger/issues/116. Let's keep this issue closed and reopen it if the CO Retail fee functionality doesn't work. Please follow on issue 116 for resolution of the report download issue.


os/exec: CommandContext should also cause the stdout/stderr pipes to be closed

I'm trying to run a process and kill it if it takes too long. So I create a command with a timeout context. Then, when the context expires and the process is not done, it will be killed. This approach works fine unless my Go process is reading from the process's stdout/stderr and the process forks and gives its stdout to its child. Then, cmd.Wait() will not exit until the child is done writing to stdout. I think that is unexpected because once the context expires, cmd.Wait() should unblock.
Here is a minimal example that reproduces my issue:
package main

import (
	"bytes"
	"context"
	"log"
	"os/exec"
	"time"
)

func main() {
	log.SetFlags(0)

	ctx, cancel := context.WithTimeout(context.Background(), time.Second)

	cmd := exec.CommandContext(ctx, "bash", "-c", "echo -n foo; sleep 5")
	stdout := &bytes.Buffer{}
	cmd.Stdout = stdout

	start := time.Now()

	err := cmd.Start()
	must(err)

	err = cmd.Wait()
	cancel()

	log.Println("took:", time.Since(start))
	log.Println("expected it to take:", time.Second)
	log.Println("stdout:", stdout)
	log.Println("wait error:", err)
}

func must(err error) {
	if err != nil {
		panic(err)
	}
}

So what I'm proposing is that the stdout/stderr pipes should be closed once the process dies and the context has expired. This will allow the copying goroutines to exit and cmd.Wait() to unblock after the context expires as expected.

There is a similar problem with setting the stdin of the command as then Wait() will block until one of the started goroutines is done copying from the stdin reader. This isn't something that can be fixed without breaking the Go API promise though. But I'm not sure how many instances there are of a stdin reader that also cannot be closed concurrently.

In general, cancelling a context is a "please" request: please stop what you're doing, because I don't care. You don't know that the operation is done until the usual operation returns, either with a "I stopped because you said please stop" error or some other result, and the calling code can react accordingly. It's not at all clear that forcibly ending stdout/stderr, making reporting that result impossible, is the right answer here.
exec.CommandContext makes things a bit unclear already because it sends SIGKILL, but it might be best not to overload it further.
There's also the more general problem that the child can exit and the wait system call can return but the copying of stdout/stderr hangs because of grandchildren holding the pipe open (can't find in issue tracker right now but I thought it existed).
Note that if you are having this problem you can change your exec.Command to hand it an os.Pipe directly and then choose to stop reading when cmd.Wait returns. In fact, Go 1.10 will support SetReadDeadline on os.Pipes, so you can SetReadDeadline(0) on the read end once cmd.Wait returns.
But further special semantics in CommandContext seems not right.

I would rather the stdout/stderr be forcefully closed instead of hanging a goroutine in my program. I cannot see any circumstances where this would not be the expected behaviour, especially considering CommandContext sends a SIGKILL.
If this is not something you want to change in CommandContext, I propose we at least add docs explaining and warning of this behaviour. If that is fine with you, I can whip up the patch.

@nhooyr Doc patches are always welcome.

Sounds good. Just waiting to see what @rsc's wants to do.


MacVIM Rendering

Category

[ ] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[x ] Vim
[ ] Neovim
[ ] Etc.

OS

[ ] Linux
[ x] Mac OS X
[ ] Windows
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[x ] bash
[ ] zsh
[ ] fish

fzf 0.17.1 (brew), and MacVim 8.0 patches 1-1207
For testing, I've stripped .vimrc down to just:
call plug#begin('~/.vim/plugged')
Plug '/usr/local/opt/fzf'
Plug 'junegunn/fzf.vim'
call plug#end()
And removed .gvimrc complete
Using vim & FZF from within the terminal works perfectly.  However, if I use GUI mode (i.e. mvim), the rendering of the results pane for FZF gets corrupted.  It appears that the mvim rendering can't "keep up", and it fails to clear some lines, shows color encoded as ESC codes instead of the colors, etc.  Screenshot attached.
I'm guessing this isn't really an FZF problem, but I'm stumped, and can't find anyone else who seems to have this problem.  Is there an FZF setting I'm overlooking that will let mvim 'keep up'?

I've noticed a similar issue, although it doesn't seem to be related to color codes.  It's more like the terminal view has ghosting from previous text:

We'll just have to wait until the terminal feature of macvim becomes more stable and reliable.
For the time being, you'll have better experience with GUI versions of Neovim, such as VimR which I think is pretty nice (it even has a builtin markdown previewer).

@junegunn Just out of curiosity, do you believe the issue to be specifically related to the terminal feature in MacVim, or do you think it has to do with the fzf renderer?

The former, because the rendering is much more stable on the terminal emulator of Neovim.

This issue definitely lives in MacVim, you can use the script utility to confirm that the same sequence of bytes results in different results in iTerm2 and MacVim. https://github.com/macvim-dev/macvim/issues/579#issuecomment-342925823

Is there a way to disable usage of terminal in the meantime? Judging from https://github.com/junegunn/fzf/blob/master/plugin/fzf.vim#L394 there doesn't seem to be a user-configurable toggle.

Actually, it's not as important, as the alternative (launching a separate iterm) is also ugly. Guess we'll need to wait till :terminal gets fixed in Vim8 :(

I try FZF with VIM today, all works well. Except terminal rendering problem. Now, I know what's going on.

I haven't dug into this issue in any more depth (nor have I ever opened the source code for MacVim or fzf, so I'm by no means an expert here), but what I've noticed from living with this issue daily is:

The output is mangled, but the darkened line of the current selection is generally right, so you can kinda scroll through the items and choose the right one.
The issue seems to be timing related, because typing too quickly will cause output to get put into the input stream. You may need to backspace over the invalid input to correctly locate your file.

Fixed in MacVim https://github.com/macvim-dev/macvim/pull/651

Confirmed. FZF works great in MacVim as of Snapshot 146. Thank you @ichizok and @splhack!


Fix Docker configuration for Gitlab CI

Description

Just missing the services I believe according to @rocode?

This should provide the temporary fix for GitLab CI #2549
Rationale
Quick fix for those using GitLab CI
Use case(s) / visualization(s)

I'm hoping to just completely eradicate the need for this setup with a follow-up PR for completely non-Docker approach on CI that supports celery, too.

Thanks @rocode! Also, I've configured Travis to use a non Docker approach which cuts down the CI runtime by 1.5 minutes. Do you mind if I ping you again so that you can test that PR (when I find the time to copy and paste the config file and rewrite the tests) on Gitlab CI?

Thanks @rocode! Also, I've configured Travis to use a non Docker approach which cuts down the CI runtime by 1.5 minutes. Do you mind if I ping you again so that you can test that PR (when I find the time to copy and paste the config file and rewrite the tests) on Gitlab CI?

Sounds good! Our current CI is about ~5 minutes, so that will be very appreciated.

@rocode Ah, I might as well get you started. My current Travis configuration is extremely wacky at the moment, but the gist of it, in Travis, is to use the built-in services. To avoid the entire Docker thing, you just need to add the environment variables that are in the .envs directory.
AFAIK in my config, that would be:
- USE_DOCKER="no"
    - TEST_TWO_SIDED_PROPOSING_NRMP_ALGO_X_TIMES=100
    - DATABASE_URL="postgres:///mydatabase"
    - REDIS_URL="redis://localhost:6379/0"
    - CELERY_BROKER_URL="redis://localhost:6379/0"

and my services are Postgres and Redis.
For celery, use this: - celery multi start beat worker -A config.celery_app --pool=solo
And your script should be pytest.

@rocode Ah, I might as well get you started. My current Travis configuration is extremely wacky at the moment, but the gist of it, in Travis, is to use the built-in services. To avoid the entire Docker thing, you just need to add the environment variables that are in the .envs directory.
AFAIK in my config, that would be:
- USE_DOCKER="no"
- DATABASE_URL="postgres:///mydatabase"
- REDIS_URL="redis://localhost:6379/0"
- CELERY_BROKER_URL="redis://localhost:6379/0"

and my services are Postgres and Redis.
For celery, use this: - celery multi start beat worker -A config.celery_app --pool=solo
And your script should be pytest.


Adding bark recipes via CraftTweaker does not keep item/block metadata

Adding recipes will default to metadata 0 on both the block, and the output.
mods.roots.Bark.addRecipe("melon", <minecraft:melon_block>, <minecraft:sand>); works as intended.
mods.roots.Bark.addRecipe("pumpkin_to_red_sand", <minecraft:pumpkin>, <minecraft:sand:1>); will still output normal sand, instead of red sand.
mods.roots.Bark.addRecipe("mossy_brick_to_gray_dye", <minecraft:stonebrick:1>, <minecraft:dye:8>); will use normal stone bricks instead of mossy stone bricks, and output an ink sac instead of gray dye.

This is my fault for failing to specify that the metadata currently isn't being recorded, although I did specify the quantity. I ran out of time before the initial release and it slipped my mind in the interim: I actually need to refactor how everything is stored in the bark recipes to get it to work as expected.

This should be in the next release, however it will still be looking specifically for a block rather than for a block state -- so blocks with variants will still be difficult/impossible to implement.

Thanks! Perhaps adding support for the metadata wildcard <minecraft:stonebrick:*> to use the old behavior could help with blocks that have multiple states. Of course, it won't be perfect.


Doesn't work with Polymer Syntax extension

Because of this setting with 'Polymer Syntax' extension for vs code:
"files.associations": {
    "*.html": "polymer"
}

snippets do not autocomplete in html files, any way to fix this/ work around?

hi,
maybe this would work (not tested):
{
    "contributes": {
        "snippets": [{
            "language": "html",
            "path": "./snippets/snippets.json"
        }, {
            "language": "polymer",
            "path": "./snippets/snippets.json"
        }]
    }
}

AFAIK polymer-language sets the language support, so snippets should just advertise support for polymer?
https://github.com/jonathanwolfe/language-polymer

wrong repo actually, my bad

NP


Freezes in a large Org file

evil-snipe works fine for me in normal code files/small Org files. However when I try to perform a s/S search in a very large Org file which contains over 10000 lines, Emacs simply freezes and I had to press C-g to get out of it.  Any idea what happened and how I might debug it? This is observed using Spacemacs on Windows. I'm yet to test it on Ubuntu.
System Info :computer:

OS: windows-nt
Emacs: 24.5.1
Spacemacs: 0.105.22
Spacemacs branch: develop (rev. 64a0cc2)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: helm
Layers:

(auto-completion better-defaults spell-checking syntax-checking semantic chrome search-engine typography games restclient colors eyebrowse themes-megapack gtags vim-powerline evil-snipe unimpaired fsharp emacs-lisp haskell org markdown html yaml shell-scripts javascript c-c++)

What is evil-snipe-scope set to? If it's set to 'buffer (or worse, `'whole-buffer'), it tries to scan the rest of the document to highlight all matches.
I know what to change to improve highlight performance, but in the meantime, you can fix this by setting it to 'visible (only scans the visible portion of the buffer) or 'line (only scans the current line), depending on your preference.
Let me know if that helps!

To be more specific: (setq evil-snipe-scope 'visible) or (setq evil-snipe-scope 'line)

Sorry, was occupied by something else and didn't try it out until today. Limiting the scope worked. Thanks.

Now, highlighting will only focus on the visible window. This should resolve any performance concerns caused by scanning entire files. Feel free to reopen if that isn't the case.


Autocomplete for external object instance

simply
i have class
namespace Model;
use Wplib\Reviews;
use Model\Base;
class Reviewmodel extends Base{
	private $wpReviewClass;
	/**
	 * contructor
	 * @return			nothing
	 */
	public function __construct() {
		parent::__construct();
		$this->wpReviewClass = new Reviews();
	}
        ............................
}

now using
$this->wpReviewClass->{no auto suggests here}

You are missing a docblock with a @var tag above your $wpReviewClass variable to indicate what type it is:
class Reviewmodel extends Base{
    /**
     * @var Reviews
     */
    private @wpReviewClass;

    ...

This should make it work. The exact requirements for autocompletion perhaps weren't entirely clear, the readme on the main page has been updated to contain more detail about what is needed to get autocompletion working properly.

@hotoiledgoblinsack  no that does not work either.

Your project is manage with composer ?

Well some part of it.
The api folder uses composer, you can see the vendor folder.
the app does not, thought he autocomplete I am asking is from this.
In the plugin settings I have mentioned the index.php from this folder.
But the suggestion does not work for any case.

Ok,
The problem is the following :
The plugin, in order to work, needs that the opened folder is the root folder of your composer.json. It also needs that your class autoloading is managed by composer.
So, if your class autoloading is managed by composer in your "api" folder, then, if you open your window on the "api" folder, it will work.
For "app", it will, unfortunately, doesn't work.

seems I have stick to Komodo Edit then.

Ok, pull requests to improve the situation are always welcome. If you have any further questions, feel free to open another ticket.


feat: add cloud-init deployment

Add cloud-init deployment

@gmale @slawlor

Please separate the cloud init bits to another readme in a doc/ folder. Then just list a pointer to it in the readme. We're going to add more common deployments in the future, and I don't want the main page cluttered for the bulk of our users.
Thanks

Done!


Seat stays booked after time slot elapses

Hi,
Thanks for this project. I was wondering if there was a way for the seats to be freed after the time slot elapses. As of now, it stays booked even after the time-slot has elapsed.

My bad - I was getting familiar with the interface. I had to move the slider to see the seat icons change. Apologies ~


[flake8-bugbear]: Implement rule B031

Implement rule B031 for flake8-bugbear:

Using the generator returned from itertools.groupby() more than once will do nothing on the second usage. Save the result to a list if the result is needed multiple times.

resolves: #2954

@MichaReiser Thanks for the review! I'll look at your points and the ecosystem checks later in the evening.

These ecosystem checks are really helpful! Thank you to whoever implemented them! ❤

(Gonna merge to keep things chugging along, but @MichaReiser let me know if you have any follow-ups.)


display failed pipeline tests

Parses pipeline test reports for failures and logs errors in console:

updated test:mocha:report script in root package.json to use a multi reporter which generates both json and junit reports. Results from json reports are printed in the console of a pipeline run.
Updated PR from original: https://github.com/microsoft/FluidFramework/pull/13355

Closing for new PR: https://github.com/microsoft/FluidFramework/pull/14702
This branch seems to be running into some build issues and I couldn't successfully run git clean. Applying the same changes to a fresh branch seems to resolve the issue.


Setting CMAKE_CXX_STANDARD (for STIR, ITK etc)

Every package has different ways to set the C++ standard, which is problematic as libraries and .h files aren't necessarily compatible, leading to crashes or linking problems, see e.g. https://github.com/CCPPETMR/SIRF-SuperBuild/issues/161. It seems therefore safer that if we compile stuf ourselves, to try and convince the package to use a particular C++ version.
At present, we set CMAKE_CXX_STANDARD to 11 for STIR. This hasn't create problems yet, but I do get warnings with ITK (that ITK was compiled with a more recent C++ standard).
There's a few possibilities:

relying on the packages and their default choices for the particular compiler we're using (wouldn't currently for STIR)
attempting to enforce a C++ standard

Seems to me that we need to find out what C++ version is used for Gadgetron and build boost with the same version (as in #161), but also build ITK, STIR and whatever with the same version. I hope that for all CMake packages, this just means specifying CMAKE_CXX_STANDARD (I haven't check the ITK code).

This is important but I don't think urgent, and wouldn't break backwards compatibility. I';; therefore assign to v2.1, but please comment if you disagree.


Hotfix/incorrect item eligiblity types

Fix incorrect property types set in ItemEligibiltyResult causing a breaking bug when performing a checkCancellationEligibility call.
Property type changes:
itemId - changed from integer to string
transactionId - changed from integer to string

Thanks, I'll get this merged as well.
Looks like it's another instance where the eBay documentation say it's one type but the API is returning another.

Correct. I believe I have spotted an additional documentation/api conflict in the Error type. I'll be submitting another PR shortly.
Thanks again.


OfferThroughput can be set to 400

For a tutorial it's enough to set OfferThroughput to 400. See chapter 'Create a graph'.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c5192394-5028-f577-e382-14c126b39ab1
Version Independent ID: 6e908eec-b16a-b09e-bf4a-4b982c804337
Content: Azure Cosmos DB: Develop with the Graph API in .NET
Content Source: articles/cosmos-db/tutorial-develop-graph-dotnet.md
Service: cosmos-db
GitHub Login: @LuisBosquez
Microsoft Alias: lbosq

@StefH
Thanks for the feedback! We are currently investigating and will update you shortly.

@LuisBosquez In the Create a graph section, the C# code sample sets the R/U to 1000. Is this necessary for the tutorial?
DocumentCollection graph = await client.CreateDocumentCollectionIfNotExistsAsync(      UriFactory.CreateDatabaseUri("graphdb"),      new DocumentCollection { Id = "graphcollz" },      new RequestOptions { **OfferThroughput = 1000** });
Maybe this is intentional, so wanted to bring this to your attention.
Regards,
Mike

@StefH @Mike-Ubezzi-MSFT Thanks for pointing the issue, it's not necessary for the throughput to be 1000, initially all our docs used 1000 RUs for most of the tutorials, but the minimum value currently is 400, we will update the doc.

#please-close

@StefH We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.

Thank you.


Add Docker config

Didn't we want to add SimpleCov to this PR?

@torresga I had forgotten to push the latest changes 🤦🏻♀ Here they are!


tooltip.x position error on line chart

Using the customTooltips on line chart, the tooltip.x position is incorrect after the half of the chart.
The behavour is visible also in the line-customTooltips.html example.

Looking at the standard tooltip behaviour I found that the position change is related to the tooltip position. After the half of the chart it moves on the other side of the dot. Like in the pie chart with the above/below value of yAlign. But there is no xAlign in the tooltip object and I can't find a way to mimic it. Any suggestion?

I experience the same issue. It might have something to do with responsiveness? With Chart.defaults.global.responsive = true; I notice a slight offset when hovering on the right side of the chart.

+1, same issue, responsive is not the problem...

Experiencing this too, I have 4 tooltips and 3 and 4 are in the wrong x Position

+1 for wrong tooltip.x position and tooltip.width when hovering second half of the chart

The issue seems to come from that bit of code:
			//Decide whether to align left or right based on position on canvas
			if (this.x > this.chart.width/2){
				this.x -= this.xOffset + this.width;
			} else {
				this.x += this.xOffset;
			}

https://github.com/nnnick/Chart.js/blob/930b16a0af59201dcfcd1594b0e7540db4d04c9f/Chart.js#L1396-L1401
Removing that fixes the wrong tooltip.x problem, with the downside that the tooltip won't switch sides on the second half of the chart.

Huzzah! The first alpha of Chart.js 2.0 has landed and should fix this issue. Check out the release and try it out! We've got a lot of momentum right now, so please help us test so we can launch 2.0 Gold by the end of the month.
https://github.com/nnnick/Chart.js/releases/tag/v2.0-alpha
I'm closing this issue for now, but if you have implementation questions or find bugs, please create a jsfiddle and post the link here and we'll reopen this issue and get it fixed.


[SMO-454] Include nm-configurator in Elemental images

nmc should be available in Elemental shipped images by default for declarative networking support.

[ ] Clarify maintenance and support
[ ] Submit to elemental-obs
[ ] Submit to SL Micro 6.1

Is nmc already packaged somewhere ?

Yes I can see it here: https://build.opensuse.org/package/show/isv:SUSE:Edge:EdgeImageBuilder/nm-configurator

Great, then it needs to be added to https://github.com/rancher/elemental-obs/tree/dev plus a respective "zypper in" call in SL-Micro-Base-Container 😉

The package is not part of Micro and we don't need to ship it to Micro.
The package is maintained in Edge and we don't need to maintain it further.


Improving dob

Small clean up on sort.
Improved DOB format

Now dob are stored as LocalDate format with the Java8 update
dob parser is smart to allow single digits for date and month, 2 or 4 digits for year
also allows month name to be entered instead
however is restricted to day-month-year

please merge asap

Changes Unknown when pulling 402b20ca0f84f54ea97ade7637be358f8abb704f on Juxarius:improving_dob into ** on CS2103AUG2017-T13-B1:master**.

Changes Unknown when pulling f8950a2f43fb9f43d1a7fb6c89e74d11835e6383 on Juxarius:improving_dob into ** on CS2103AUG2017-T13-B1:master**.

Changes Unknown when pulling f8950a2f43fb9f43d1a7fb6c89e74d11835e6383 on Juxarius:improving_dob into ** on CS2103AUG2017-T13-B1:master**.


Use node_modules resolution algo

Reopened after returning! Redux of #42.
Hope this is adequate! I'll let you do the version bump etc.

Turns out two things are broken.
One is that I was reading from config and not opts.
the other is that resolve-from seems to be completely broken:
$ ls -la node_modules | grep grunt
drwxr-xr-x   11 drewp  staff    374 Dec  9 15:59 grunt
drwxr-xr-x   12 drewp  staff    408 Dec  9 15:59 grunt-cli
drwxr-xr-x   13 drewp  staff    442 Dec  9 15:59 grunt-legacy-log
drwxr-xr-x   12 drewp  staff    408 Dec  9 15:59 grunt-legacy-log-utils
drwxr-xr-x   11 drewp  staff    374 Dec  9 15:59 grunt-legacy-util
drwxr-xr-x    6 drewp  staff    204 Dec  9 15:59 grunt-svgmin
$ node --version
v5.1.1
$ node
> var rf = require('resolve-from')
undefined
> rf('.', 'grunt-svgmin')
null

So I'm going to switch back to require-resolve.

No, it is correct. grunt-svgmin doesn't have a main entry point. Same with the core resolve:
~/dev/load-grunt-tasks master
❯ node
> require.resolve('grunt-svgmin')
Error: Cannot find module 'grunt-svgmin'

yes, I just noticed this too. newest commit has a workaround.

ok, should be good to go now.

ok, should be good!

Thanks! Just published a new release ;)


Feature Request : Fail on Threshold parameter

Feature Request : Introduce a new parameter, failOnThreshold, which should allow the operator to specify the threshold at which builds should fail.
One of string: "low" or "medium" or "high" or "critical"
Example configuration : 'Report on all issues, but only fail build for Critical issues'
- task: SnykSecurityScan@1
  inputs:
    serviceConnectionEndpoint: 'mySnykToken'
    testType: 'app'
    failOnThreshold: 'critical'
    monitorWhen: 'always'

We're happy to pick this issue up and contribute it back, @maxjeffos sound like a worthwhile feature?

Hi @dylan-asos, my team is taking over Jeff's work here. You can proceed with creating a PR for it 👍
I suggest you to simplify the logic in finding if threshold is reached. You don't need to bring additional dependency. You can instead map severities to their ordinal to find if threshold is matched. Here's rough code sample:
function getSeverityOrdinal(severity: string): number {
  switch (severity) {
    case Severity.CRITICAL:
      return 3;
    case Severity.HIGH:
      return 2;
    case Severity.MEDIUM:
      return 1;
    case Severity.LOW:
      return 0;
  }
  throw new Error(`Cannot get severity ordinal for ${severity} severity`);
}

export async function doVulnerabilitiesExistForFailureThreshold(filePath: string, threshold: Severity) : Promise<boolean> {

  const file = await fsPromises.readFile(filePath, 'utf8');
  const json = JSON.parse(file);
  const thresholdOrdinal = getSeverityOrdinal(threshold);

  for (const vulnerability of json['vulnerabilities']) {
    if (getSeverityOrdinal(vulnerability['severity']) >= thresholdOrdinal) {
      return true;
    }
  }

  return false;
}


feat: BCH using chronik

Related to #412

Description
Sets up Chronik for BCH.
Essentially meaning BCH network should now work normally, just as XEC does.
Test plan
Change config
Config should change now, check config/example-config.json. You can remove obsolete variables like grpcClient...URL, chronikClientURL and add the new networkBlockchainURLs variable:
  "networkBlockchainURLs": {
    "ecash": "https://xec.paybutton.io",
    "bitcoincash": "https://chronik.pay2stay.com/bch"
  },

...besides modifying networkBlockchainClients so that it says:
  "networkBlockchainClients": {
    "ecash": "chronik",
    "bitcoincash": "chronik"
  },

Also, remove the property networksUnderMaintenance so it won't inactivate BCH.
Now, after rebooting the containers, bitcoincash should sync and work normally.

Remarks
When working on this issue, I found some issues with Bitcoin Cash in the client.

Click-to-copy in the QR code doesn't grab the amount
OnSuccess being triggered with a different amount than the one in the button.

I'll create a PR in the client to fix those.

Also we do already have a task for click-to-copy not working right on BCH: https://github.com/PayButton/paybutton/issues/417

Let's address the BCH success trigger in https://github.com/PayButton/paybutton/pull/403 instead.

Also we do already have a task for click-to-copy not working right on BCH: PayButton/paybutton#417

Alright

Let's address the BCH success trigger in PayButton/paybutton#403 instead.

I don't follow.

Update 'Under Maintenance' network message

You have to remove it from your paybutton-config.json. Forgot to mention it in the description, updated.

* eCash is showing as disconnected for me in /networks
* Error when visiting /payments and /dashboard:

Could you confirm you are still getting those now?

I don't follow.

It's a client-side issue so let's just make sure it's working in https://github.com/PayButton/paybutton/pull/403.

@chedieck Before we merge this, what could we do for tests as I don't see any thing new added for this one.

@chedieck Before we merge this, what could we do for tests as I don't see any thing new added for this one.

Just added some tests, making sure chronik works for both ecash and bitcoincash.


Set up a Github runner

We use to have a self-hosted github runner to run our e2e tests in the past. But due some issue we lost the instance and we rely on the VM created by @kravciak which could die anytime as well. Therefore, we need to create a new runner in GCP for our CI jobs.

By the way, if you want a no-maintenance method to achieve that, you can use cirun.io for the same.


Async User Defined Functions (UDF)

Is your feature request related to a problem or challenge?
I would like to use async code in an UDF. I couldn't find an example or API documentation on how to do that. It would be nice if it would be possible/documented.
Describe the solution you'd like
datafusion::physical_plan::functions::make_scalar_function() accepts functions which return a Future.
Describe alternatives you've considered
Creating another tokio runtime and offloading the async function onto it.
The main runtime waits in the UDF till async function is done with execution.
Additional context
No response

I agree there is currently no good way to make a scalar function async.
You could potentially use a table provider and write to your function like INSERT INTO your_table SELECT ... 🤔
That might not work for your usecase however

My idea was to do something likes this:
SELECT call('localhost:3000', num, letter FROM (SELECT * FROM (VALUES (1, 'one'), (2, 'two'), (3, 'three')) AS t (num,letter))

It would probably work with your example.
CREATE EXTERNAL TABLE your_table STORED AS CSV WITH HEADER ROW LOCATION 'localhost:3000';
INSERT INTO your_table SELECT * FROM (VALUES (1, 'one'), (2, 'two'), (3, 'three')) AS t (num,letter);
SELECT * FROM your_table;

And on insert call endpoint and store returned value. Seems cumbersome to use and implement.

@alamb wouldn't it be possible to turn the SQL statement
SELECT call('localhost:3000', num, letter FROM (SELECT * FROM (VALUES (1, 'one'), (2, 'two'), (3, 'three')) AS t (num,letter))

into a LogicalPlan. Rewrite the Expr::ScalarUDF to a Expr::SubQuery with an LogicalPlan::Extension.
The Extension would point to a custom ExecutionPlan, in which I could run async code.
Similar to what is done in datafusion/core/tests/user_defined_plan.rs.

@alamb wouldn't it be possible to turn the SQL statement

Yes, that sounds like it would work (I am sorry I didn't suggest that)
If you get it to work, I think it would be a great example to include in DataFusion to show both the power of the existing extension APIs and custom table functions)

I got an example working which replaces an UDF with a user defined Extension.
The extension processes RecordBatches in an async function.
It works great with VALUES as inputs but not with a csv file.
I will clean it up and create a PullRequest. I hope you can help me figure out why inputs from VALUES is processed different to a csv files.

I filed https://github.com/apache/arrow-datafusion/issues/7926 to track user defined table functions

@alamb this is very useful for me now but it is blocking, any chance I can resume the existing work?

Sure -- sounds good to me @edmondop
What I would personally suggest doing is make an example showing what you are trying to do -- and then with that example modify the DataFusion APIs acoordinatly. That way you'll both have the API changes needed as well as an example of what you were trying to do that serves as documentation


Add Server.poll_timeout method

As per #200 I was looking for a way to have Rouille run in a thread, in a way which I could interrupt when the application shutdown.
Just calling poll in a loop seemed very wasteful. For my purposes just calling poll with a short (~10ms or so) sleep was okay, but seemed like it'd be easy/useful to add a poll_timeout method consistent with tiny_http's recv_timeout

I've had the same need for a server, and was about to make the same PR. It seems like the simplest and cleanest solution to being able to shut down the server from the same thread.
For the moment, I did the same delay-based solution, but it's a needless waste, as the main reason for using rouille is the fact that it's so snappy and lightweight!!