Need help: missing port in address

Hi, I need help, there's something missing on my side.
I'm trying to run examples from v4
I run service without errors:
dima@Dimas-MBP ~/g/g/v/helloworld (main)> go run server/main.go --server grpc --server_name helloworld.srv                                                                                11:40:16
2021-11-24 11:43:04  file=v4@v4.4.0/service.go:206 level=info Starting [service] helloworld.srv
2021-11-24 11:43:04  file=v4@v4.0.0-20211111140334-799b8d6a6559/grpc.go:894 level=info Server [grpc] Listening on [::]:49954
2021-11-24 11:43:04  file=v4@v4.0.0-20211111140334-799b8d6a6559/grpc.go:725 level=info Registry [mdns] Registering node: helloworld.srv-2a7e786e-ca6c-4ac8-983a-ca3495df5075

But client always fails. And the same is for other examples in go-micro repo
dima@Dimas-MBP ~/g/g/v/helloworld (main)> go run client/main.go --client grpc                                                                                11:43:41
2021-11-24 11:44:03  file=client/main.go:22 level=fatal {"id":"go.micro.client","code":503,"detail":"connection error: desc = \"transport: Error while dialing dial tcp: address [[fd55:XXX:a505]]:49954: missing port in address\"","status":"Service Unavailable"}
exit status 1

It seems mdns is not resolving...

Could be ipv6 issue, I'll take a look.

Could be ipv6 issue, I'll take a look.

Thank you. Also, looking at possible mdsn issues in Mac.
I've been thinking that using etcd would be best option because the service will be working in kuber anyway

Perhaps this could help?
https://github.com/hashicorp/mdns/blob/f504e0b3c01cf50e077ab6805546fa95ed9f2933/client.go#L111

Your ipv6 address [[fd55:XXX:a505]]:49954 cannot be parsed by net.SplitHostPort

Your ipv6 address [[fd55:XXX:a505]]:49954 cannot be parsed by net.SplitHostPort

fd55:e0da:f8c9:3:cd7:c048:5b48:a505

Your ipv6 address was wrapped by [[]], should be [].

try run your server with --server_advertise [fd55:e0da:f8c9:3:cd7:c048:5b48:a505]:port

Your ipv6 address was wrapped by [[]], should be [].
This is a part of log entry, so brackets could be added by a loger

dial tcp: address [[fd55:e0da:f8c9:3:cd7:c048:5b48:a505]]:53813: missing port in address","status":"Internal Server Error"

No, the logger will not add that.

Actually, I just took the example, didn't change anything.
Ok

I know, but I cannot reproduce your issue and I could not figure out who updated your ipv6 address.

I will use another service discovery, considering that it will be working in K8S anyway.
Is there any documentation regarding how to run service and client with different service providers, such as etcd and kubernetes?
Also, if I debug service/client locally, what is the best practice, is it to run with a service provider running in localhost?

I tested it in the kubernetes
Server:
Starting transaction-persistence
2021/11/24 20:17:17 debug logging disabled
2021/11/24 20:17:17 debug logging disabled
2021-11-24 20:17:17  file=v4@v4.4.0/service.go:206 level=info Starting [service] transaction-persistence
2021-11-24 20:17:17  file=server/rpc_server.go:820 level=info Transport [http] Listening on <IP_ADDRESS>:9845
2021-11-24 20:17:17  file=server/rpc_server.go:840 level=info Broker [http] Connected to <IP_ADDRESS>:37177
2021-11-24 20:17:17  file=server/rpc_server.go:654 level=info Registry [kubernetes] Registering node: transaction-persistence-4148a175-ca8a-41d2-9f9f-7acd5971726f

The client:
2021-11-24 21:28:30  file=tx-persistence-client/main.go:33 level=fatal {"id":"go.micro.client","code":500,"detail":"connection error: dial tcp <IP_ADDRESS>:9845: connect: connection refused","status":"Internal Server Error"}

Process finished with exit code 0

I used skaffold to deploy it in kubernetes

Locally it fixed.
I did nothing, just added grpc plugins and added to scaffold env variables:
MICRO_CLIENT:grpc
MICRO_SERVER:grpc
And run services and client with micro run.
But server still uses http:
2021-11-25 00:57:34  file=v4@v4.4.0/service.go:206 level=info Starting [service] transaction-persistence
2021-11-25 00:57:34  file=server/rpc_server.go:820 level=info Transport [http] Listening on <IP_ADDRESS>:9845
2021-11-25 00:57:34  file=server/rpc_server.go:840 level=info Broker [http] Connected to <IP_ADDRESS>:60980
2021-11-25 00:57:34  file=server/rpc_server.go:654 level=info Registry [mdns] Registering node: transaction-persistence-29358234-6a1c-45eb-9663-01af34f9b263

So you set your server address to <IP_ADDRESS>:9845?

I didn't change the address. I realised that I can update env variables like MICRO_***
Do you mind if I create service and client with default config?
Because after I switch to grpc transport it stopped working, the client fails with error:
2021-11-25 03:03:28  file=tx-persistence-client/main.go:33 level=fatal {"id":"go.micro.client","code":500,"detail":"service transaction-persistence: not found","status":"Internal Server Error"}
exit status 1

I'll ping once I've posted sample project

@xpunch
I've created server and client and run it with
skaffold run
or
micro run
The output is the same:
Server:
kubectl --kubeconfig=/Users/dima/Library/Caches/JetBrains/GoLand2021.2/kubernetes/micro-client/api-provider/config logs micro-server-6f75f65568-kl9rq --container=micro-server --namespace=default --follow=true
Starting micro
2021-11-25 10:26:40  file=v4@v4.4.0/service.go:206 level=info Starting [service] go.micro.server
2021-11-25 10:26:40  file=v4@v4.0.0-20211124174154-b25d744f5c51/grpc.go:894 level=info Server [grpc] Listening on [::]:39919
2021-11-25 10:26:40  file=v4@v4.0.0-20211124174154-b25d744f5c51/grpc.go:725 level=info Registry [kubernetes] Registering node: go.micro.server-4337b2f8-7552-495b-b6ac-1531bddb41e6
2021/11/25 10:26:40 debug logging disabled
2021/11/25 10:26:40 debug logging disabled

Client:
2021-11-25 13:16:59  file=micro-client/main.go:33 level=fatal {"id":"go.micro.client","code":500,"detail":"service transaction-persistence: not found","status":"Internal Server Error"}

It's a known issue: https://github.com/asim/go-micro/issues/2140.

I'll close this issue too.


How to change baseUrl in angular 11

We have generate some angular services using NSwag, but we didn't succeed in changing the base url of every service request.
There is no docs regrading an angular 11 client.
Can someone provide angular 11 client consume NSwag angular service and change the baseurl from the client(aka component) ?
@RicoSuter

Hi. Just add this in your app.module:
export const API_BASE_URL = new InjectionToken<string>('API_BASE_URL'); //baseUrlTokenName
...
providers: [
        {
          provide: API_BASE_URL,
          useValue: environment.apiUrl
        }
]

thank you!!


Example test failure on macOS 13 with latest JDK 8

Issue Type: Bug Report

Write the following environmental information.

OS version: macOS 13 x86_64
Java version: openjdk@8 1.8.0+362
Embulk version: v.0.9.24
Your Embulk configuration (YAML): N/A
Plugin versions: N/A

Write all what you did, e.g. your commands executed

Performing regression testing for the newest JDK 8 in Homebrew. embulk is the only failing dependent, and only failing on macOS 13. We use the embulk example test to verify functionality.

Write what you expected and observed actually

Expected the test would complete successfully like it does on other macOS versions and Linux.
Relevant GitHub Actions run: https://github.com/Homebrew/homebrew-core/actions/runs/3977849956/jobs/6819316022#step:10:133

Hello, @p-linnane
Thank you for reporting this issue.
I suppose this error relates to JRuby <IP_ADDRESS> (or JDK 1.8) on macOS 13.
(Not embulk itself)
I'll investigate this error (But I don't have a test environment yet.)
I copied this error.
And the Embulk team doesn't maintain a Homebrew formula of Embulk.
==> FAILED
Full test embulk output
  ==> Testing embulk
  ==> /usr/local/Cellar/embulk/0.9.24/bin/embulk example ./try1
  Picked up _JAVA_OPTIONS: -Duser.home=/Users/brew/Library/Caches/Homebrew/java_cache -Djava.io.tmpdir=/private/tmp
  2023-01-22 04:06:07.095 +0000: Embulk v0.9.24
  Creating ./try1 directory...
    Creating ./try1/
    Creating ./try1/csv/
    Creating ./try1/csv/sample_01.csv.gz
    Creating ./try1/seed.yml
  Run following subcommands to try embulk:
     1. embulk guess ./try1/seed.yml -o config.yml
     2. embulk preview config.yml
     3. embulk run config.yml
  ==> /usr/local/Cellar/embulk/0.9.24/bin/embulk guess ./try1/seed.yml -o config.yml
    Timeout::Error: execution expired
  /usr/local/Homebrew/Library/Homebrew/formula.rb:2489:in `gets'
  /usr/local/Homebrew/Library/Homebrew/formula.rb:2489:in `block in system'
  /usr/local/Homebrew/Library/Homebrew/formula.rb:2462:in `open'
  /usr/local/Homebrew/Library/Homebrew/formula.rb:2462:in `system'
  /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/embulk.rb:30:in `block in <class:Embulk>'
  /usr/local/Homebrew/Library/Homebrew/formula.rb:2301:in `block (3 levels) in run_test'
  /usr/local/Homebrew/Library/Homebrew/utils.rb:605:in `with_env'
  /usr/local/Homebrew/Library/Homebrew/formula.rb:2300:in `block (2 levels) in run_test'
  /usr/local/Homebrew/Library/Homebrew/formula.rb:968:in `with_logging'
  /usr/local/Homebrew/Library/Homebrew/formula.rb:2299:in `block in run_test'
  /usr/local/Homebrew/Library/Homebrew/mktemp.rb:77:in `block in run'
  /usr/local/Homebrew/Library/Homebrew/mktemp.rb:77:in `chdir'
  /usr/local/Homebrew/Library/Homebrew/mktemp.rb:77:in `run'
  /usr/local/Homebrew/Library/Homebrew/formula.rb:2577:in `mktemp'
  /usr/local/Homebrew/Library/Homebrew/formula.rb:2293:in `run_test'
  /usr/local/Homebrew/Library/Homebrew/test.rb:45:in `block in <main>'
  /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib/ruby/2.6.0/timeout.rb:108:in `timeout'
  /usr/local/Homebrew/Library/Homebrew/test.rb:50:in `<main>'

Thank you for your response. Please let me know if I can help test.

Hello, @p-linnane
Could you try zulu8 instead of openjdk.
It worked fine on my environment.
M1 mac
  uname -a
Darwin palolovalley.local 22.3.0 Darwin Kernel Version 22.3.0: Thu Jan  5 20:49:43 PST 2023; root:xnu-8792.81.2~2/RELEASE_ARM64_T8103 arm64

macOS 13
sw_vers
ProductName:		macOS
ProductVersion:		13.2
BuildVersion:		22D49

zulu java 1.8.0_362
java -version
openjdk version "1.8.0_362"
OpenJDK Runtime Environment (Zulu <IP_ADDRESS>-CA-macos-aarch64) (build 1.8.0_362-b09)
OpenJDK 64-Bit Server VM (Zulu <IP_ADDRESS>-CA-macos-aarch64) (build 25.362-b09, mixed mode)

embulk 0.9.24
embulk --version
embulk 0.9.24

try embulk example
% embulk example hoge
2023-02-04 12:42:45.612 +0900: Embulk v0.9.24
Creating hoge directory...
  Creating hoge/
  Creating hoge/csv/
  Creating hoge/csv/sample_01.csv.gz
  Creating hoge/seed.yml

Run following subcommands to try embulk:

   1. embulk guess hoge/seed.yml -o config.yml
   2. embulk preview config.yml
   3. embulk run config.yml

% embulk guess hoge/seed.yml -o config.yml
2023-02-04 12:42:51.530 +0900: Embulk v0.9.24
2023-02-04 12:42:51.977 +0900 [WARN] (main): DEPRECATION: JRuby org.jruby.embed.ScriptingContainer is directly injected.
2023-02-04 12:42:52.758 +0900 [INFO] (main): Gem's home and path are set by default: "/Users/hsato/.embulk/lib/gems"
2023-02-04 12:42:53.109 +0900 [INFO] (main): Started Embulk v0.9.24
2023-02-04 12:42:53.250 +0900 [INFO] (0001:guess): Listing local files at directory '/private/tmp/hoge/csv' filtering filename by prefix 'sample_'
2023-02-04 12:42:53.250 +0900 [INFO] (0001:guess): "follow_symlinks" is set false. Note that symbolic links to directories are skipped.
2023-02-04 12:42:53.251 +0900 [INFO] (0001:guess): Loading files [/private/tmp/hoge/csv/sample_01.csv.gz]
2023-02-04 12:42:53.259 +0900 [INFO] (0001:guess): Try to read 32,768 bytes from input source
2023-02-04 12:42:53.287 +0900 [INFO] (0001:guess): Loaded plugin embulk (0.9.24)
2023-02-04 12:42:53.295 +0900 [INFO] (0001:guess): Loaded plugin embulk (0.9.24)
2023-02-04 12:42:53.302 +0900 [INFO] (0001:guess): Loaded plugin embulk (0.9.24)
2023-02-04 12:42:53.305 +0900 [INFO] (0001:guess): Loaded plugin embulk (0.9.24)
in:
  type: file
  path_prefix: /private/tmp/hoge/csv/sample_
  decoders:
  - {type: gzip}
  parser:
    charset: UTF-8
    newline: LF
    type: csv
    delimiter: ','
    quote: '"'
    escape: '"'
    null_string: 'NULL'
    trim_if_not_quoted: false
    skip_header_lines: 1
    allow_extra_columns: false
    allow_optional_columns: false
    columns:
    - {name: id, type: long}
    - {name: account, type: long}
    - {name: time, type: timestamp, format: '%Y-%m-%d %H:%M:%S'}
    - {name: purchase, type: timestamp, format: '%Y%m%d'}
    - {name: comment, type: string}
out: {type: stdout}

Created 'config.yml' file.
% embulk run config.yml
% embulk run config.yml
2023-02-04 12:43:11.074 +0900: Embulk v0.9.24
2023-02-04 12:43:11.603 +0900 [WARN] (main): DEPRECATION: JRuby org.jruby.embed.ScriptingContainer is directly injected.
2023-02-04 12:43:12.721 +0900 [INFO] (main): Gem's home and path are set by default: "/Users/hsato/.embulk/lib/gems"
2023-02-04 12:43:13.258 +0900 [INFO] (main): Started Embulk v0.9.24
2023-02-04 12:43:13.306 +0900 [INFO] (0001:transaction): Listing local files at directory '/private/tmp/hoge/csv' filtering filename by prefix 'sample_'
2023-02-04 12:43:13.307 +0900 [INFO] (0001:transaction): "follow_symlinks" is set false. Note that symbolic links to directories are skipped.
2023-02-04 12:43:13.307 +0900 [INFO] (0001:transaction): Loading files [/private/tmp/hoge/csv/sample_01.csv.gz]
2023-02-04 12:43:13.329 +0900 [INFO] (0001:transaction): Using local thread executor with max_threads=16 / output tasks 8 = input tasks 1 * 8
2023-02-04 12:43:13.332 +0900 [INFO] (0001:transaction): {done:  0 / 1, running: 0}
1,32864,2015-01-27 19:23:49,20150127,embulk
2,14824,2015-01-27 19:01:23,20150127,embulk jruby
3,27559,2015-01-28 02:20:02,20150128,Embulk "csv" parser plugin
4,11270,2015-01-29 11:54:36,20150129,

Thank you.


Use nullable Float64 pandas dtype for Double

Changes the primary dtype for the Double logical type from float64 to Float64
updates pandas requirement to 1.2.0 and Dask requirement to 2021.02.0 beacause those are the releases where the Float64 was added
Certain tests broke - need to investigate if those are pandas bugs and if so were they fixed in later releases?

can't convert from ['1', '2', '3'] to [1.0, 2.0, 3.0] when using Float64 dtype
pd.qcut doesnt work on Float64
doing df.replace changes the dtype back to float64

Closes #264

Currently waiting on a Koalas dependency that seems to be incorrect: In their docs, they list pandas 1.2.0 as a minimum dependency for using the Float64Dtype, but they specify  'numpy>=1.14,<1.20.0',  in their setup.py.
(issue)

Blocked until Koalas fixes the 1.2.0 restriction: https://github.com/databricks/koalas/issues/2137

Closing due to the discussion here:
https://github.com/alteryx/woodwork/issues/264


feat: update DEPENDENCIES, add check to CI

WHAT
Updates the DEPENDENCIES file, adds a check to the CI that verifies the DEPENDENCIES file is up-to-date
WHY
compliance with Eclipse
FURTHER NOTES

currently there are still IPLab reviews open:

https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9261
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9262
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9263
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9264
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9265
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9266
https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/9267

Closes # <-- insert Issue number if one exists

I would recomment to grep over the new dep file for the search-string "rejected" in the status column. A rejected lib means you are not allowed to use it.

that is a good idea, thanks. in that case we could let the job fail.

Just to demonstrate how this will look like:

Nice. can you show this in the office hour too? I think we are also planing something very simimliar

Nice. can you show this in the office hour too? I think we are also planing something very simimliar

I had already talked with @SebastianBezold about it. I can definitely share this, but unfortunately i won't be able to make it to the Office Hour on Friday July 7, 2023. Feel free to show it, or I can send out an email to the mailing list.

@paullatzelsperger no worries, there is another Office Hour next Week on the 14th Of July :-)


Fix/stringable sort

This PR replaces an older one. This is a safe fix, where we type cast column value to string when ordering. This is more inline in how the Eloquent method that is overwritten works too.
There is a simple test to show how you can now pass objects that implement Stringable as a $column variable for orderBy method.
I wasn't sure where to add that mockable class, so I did put it directly into QueryTest.php file.

You can also see all tests passing from my own workflows here https://github.com/apeisa/laravel-mongodb/actions/runs/2681478769

@divine Is it possible to merge this?

Thanks for the suggestion, didn't know about the str() helper, makes the test much cleaner!
Not sure I understand your request:

Also, point me where exactly that library converts this to the stringable object.

If you are referring to the Filament library - I don't think it matters (this fix is not about Filament only). I mean the Eloquent orderBy method that we are overriding allows multiple objects (in addition to string). Most of them are Queryable-objects, but it also accepts Illuminate\Database\Query\Expression -objects, which are stringable ones.
So we could use also $age = new \Illuminate\Database\Query\Expression('age'); where we now have str('age'); to make that point more clear.
So this fix simply make it possible to give any stringable object for orderBy method, instead of pure string. Of course, we could check also if the object is Expression, only then we do type cast to string, but I think this code is cleaner and more future-proof this way.

Codecov Report

Merging #2420 (f670c5f) into master (ad4422a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #2420   +/-   ##
=========================================
  Coverage     87.62%   87.62%
  Complexity      676      676
=========================================
  Files            31       31
  Lines          1551     1551
=========================================
  Hits           1359     1359
  Misses          192      192

Impacted Files
Coverage Δ

src/Query/Builder.php
89.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad4422a...f670c5f. Read the comment docs.

@divine @Smolevich any hope to get this merged for the next release?

Thanks!


cmake: provide aliases for zephyr build commands

With introduction of cmake, I felt annoying having 4 commands when we used to have one to build.
Following discussion during cmake PR review, here is a proposal to provide short set of aliases for usual build commands, and maybe avoid some basic build issues.
I introduced "builds" subdir to ease full build directories cleaning. I could have use a prefix such as build_, but having a 'builds' subdir does the same thing, is safer and easier to manipulate with in line commands.
Aliases are populated once for all in ~/zephyrrc file when sourcing zephy-env.sh
Provide zcmake, zmake and zclean aliases to ~/.zephyrrc file
Binaries are build under builds/
Usage:
zcmake  <flash/debug .. KOPTION>: clean build
zcake  <flash/debug .. KOPTION>: make
zclean: erase builds dir
This is purely based on my day to day usage and then might not fit all needs.
It does not intend to replace official commands as it's better for users to learn full commands.

for example, instead of using aliases, I use this script:
https://gist.github.com/2952a9be6dbab5912d49052829d4dac5
I put this in $HOME/bin
and use it this way:
# zb BOARD=<board> [run|flash|..]

@nashif, tested and working nicely. Thanks for having shared.
I'm closing PR


While filtering dashboard sales and The month option should be dark in the Dark theme.

Terms

[X] Before you openning this issue, i have checked if the issue has already been reported.

Bagisto Version(s) affected
master
Issue Description
While filtering the dashboard with month So The month option should be dark in the Dashboard of the admin panel in the Dark theme.
Preconditions
enable the Dark Theme
Steps to reproduce

Go to the 'admin panel'
Click on the 'dark mode button'
Click on the 'date'
Click on the 'month'
See the error

Expected Result
It should be shown in the dark.
Actual Result
It is showing in the light theme.
Screenshots

Additional context
No response

please assign this issue to me


cloud reader, iOS Chrome browser, EPUB fails to load (okay in Safari)

test URL:
http://readium-cloudreader.divshot.io/?epub=epub_content%2Faccessible_epub_3

A similar / related issue?
https://github.com/readium/readium-js-viewer/issues/351

Any ideas how this issue can be moved forward?  I am keenly interested in getting readium-js-viewer functional in the Facebook embedded browser for iOS.  Let me know if some experiments might aid in a diagnosis, maybe I can gather some information.

@davedmiller in the description of your other issue (#351) you claim that the Readium cloud reader works fine in Chrome for iOS. Yet this fails in my tests (thus this issue). Could you please check at your end, and report which version of iOS you are using? Many thanks!

While I am sure that I had Readium working in iOS Chrome at one point, I am unable to confirm that today.  I too am seeing a failure when I attempt to load Readium in iOS Chrome.  What I see in that instance is very similar to what I see when loading Readium-JS-Viewer in the iOS Facebook app embedded browser, which is an infinite spinner.  I don't know exactly when this behavior changed...it was some time ago, possibly around the time that 8.3 came out.

Which version of iOS?  7 or 8?

I have experienced the same issue using the readium-shared-js code in our custom built wrapper. The issue occurs on iOS 7/8 with the latest version of Chrome from the app store.
I also used a UIWebView test project (https://github.com/paulirish/iOS-WebView-App) and the UIWebView was able to load the reader in iOS 7/8, so it seems to be Chrome specific.

All of my testing has been on iOS 8.

I have been working on this issue and #351 & #352 for some time now.  Issue #112 seems to be related.
In the file iframe_zip_loader.js at line #19 I have added this:
...
isIE = true;
...
To resulting in:
...
define(['URIjs', 'readium_shared_js/views/iframe_loader', 'underscore', './discover_content_type'], function(URI, IFrameLoader, _, ContentTypeDiscovery){
var zipIframeLoader = function( getCurrentResourceFetcher, contentDocumentTextPreprocessor) {

    var isIE = (window.navigator.userAgent.indexOf("Trident") > 0 || window.navigator.userAgent.indexOf("Edge") > 0);
    isIE = true;

    var basicIframeLoader = new IFrameLoader();

    var self = this;

    var _contentDocumentTextPreprocessor = contentDocumentTextPreprocessor;

    this.addIFrameEventListener = function (eventName, callback, context) {
        basicIframeLoader.addIFrameEventListener(eventName, callback, context);
    };

...
I have not completed all of my testing yet, but this change has made it so the following environments fully load my epubs, the infinitely spinning spinner is gone..  The environments include:

Facebook embedded browser on Kindle Fire 7 OS version 4.5.5 (KF7FB),
Facebook embedded browser on Android 5.1.1 Nexus 9 (N9FB),
chrome on ios 8.4.1 (iPhoneChrome), and
Facebook embedded browser on ios 8.4.1 (iPhoneFB).

Actually the iPhoneFB environment was "sort of kind of" working before, but was clearly having problems with layout etc.  The change I described above has cured those issues too.
Now I could use a little help. I am not entirely sure what string to look for in the userAgent for these environments and devices.  I include the userAgents I have observed here:
On KF7FB
UserAgent:Mozilla/5.0 (Linux; Android 4.4.3; KFASWI Build/KTU84M) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/<IP_ADDRESS> Mobile Safari/537.36 [FB_IAB/FB4A;FBAV/<IP_ADDRESS>.273;]"
On N9FB
UserAgent:Mozilla/5.0 (Linux; Android 5.1.1; Nexus 9 Build/LMY48I; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/44.0.2403.117 Safari/537.36 [FB_IAB/FB4A;FBAV/<IP_ADDRESS>.131;]"
On iPhoneChrome
UserAgent:Mozilla/5.0 (iPhone; CPU iPhone OS 8_4_1 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) CriOS/44.0.2403.67 Mobile/12H321 Safari/600.1.4"
On iPhoneFB
User-Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 8_4_1 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Mobile/12H321 [FBAN/FBIOS;FBAV/<IP_ADDRESS>.273;FBBV/13822349;FBDV/iPhone7,1;FBMD/iPhone;FBSN/iPhone OS;FBSV/8.4.1;FBSS/3; FBCR/AT&T;FBID/phone;FBLC/en_US;FBOP/5]
It would be helpful if someone smarter than I, could review these useragents and suggest some detection code to set isIE true for these environments.
Thanks,
Dave

@davedmiller Good find on where the problem is located. I looked over the source and the isIE is only used in 4 places. Instead of trying to determine isIE which is problematic for many reasons you listed, would it make sense instead to determine if the function needed is available? IE 10 for example added Blob support and revokeObjectUrl().
https://developer.mozilla.org/en-US/docs/Web/API/URL/revokeObjectURL
https://developer.mozilla.org/en-US/docs/Web/API/Blob
See here for example of checking if the standard/preferred way is available and falling back if not:
https://github.com/bibliolabs/readium-shared-js/blob/master/js/views/cfi_navigation_logic.js#L698
Setting it up this way futures proofs the code when the preferred/standard is finally implemented across all browsers. Admittedly this will not always work when there are browser specific implementation bugs, but those can happen with any browser.

@davedmiller thank you for the detailed analysis.
Please bear in mind that the document.open/write/close() method breaks XHTML (XML) namespaces and CSS selectors including such as epub:type (because only the text/html content type is supported). Conversely, the Blob-URI method supports application/xml+html documents, which is why we use it everywhere possible. The isIE=true trick seems like a good idea at first glance, but a better long-term solution would be to figure-out why Blob-URI does not work on MS Trident and Edge.
https://github.com/readium/readium-js/blob/develop/js/epub-fetch/iframe_zip_loader.js#L100
if (!isIE) {
                var contentType = 'text/html';
                if (attachedData.spineItem.media_type && attachedData.spineItem.media_type.length) {
                    contentType = attachedData.spineItem.media_type;
                }

                var documentDataUri = window.URL.createObjectURL(
                    new Blob([contentDocumentData], {'type': contentType})
                );
            } else {

                iframe.contentWindow.document.open();

                    iframe.contentWindow.document.write(contentDocumentData);
            }

@davedmiller @matwood there's a good discussion thread on document.open/write/close() vs. Blob-URI here:
https://github.com/readium/readium-js/issues/86#issuecomment-65820675
(includes a test EPUB file)

@danielweck I did not mean to imply that one should always set isIE to true.  As a 'temporary' fix for the mobile FB embedded browser and Chrome on iOS only.  Without such a change, the current user experience is that the pages never load, and the user cannot read the content.  With this change, albeit with some parsing errors, the user experience is that the pages load and the user can read the books.
Long term, I think you are right, there needs to be a better solution.  I will endeavor to find a better solution, time permitting.  Maybe we should be contacting Google, Microsoft, and Facebook to get changes made to their browsers.
In the meantime, I need to improve the current user experience and will put in a short term fix for my companies use.

@davedmiller great! :)

Just a comment:  While there is nothing wrong with trying to convince the browser-makers to make changes, the sad fact is that their agenda is pretty different from ours and, even if they want to, their timelines and feature-lists are heavily constrained.  So for us, it is not a viable strategy - at least in the short term.

I'm not sure the exact cause yet, but the underlying issue is that the UIWebview sometimes does not call the onload event after the iframe.setAttribute("src", documentDataUri);. I am having the same problem while integrating the viewer into a Cordova iOS app. It looks like the iframe fails to load the Blob and continues on like nothing happened. The iframe also does not contain the blob data after the above call which supports my theory that it fails. Currently I believe it may be related to this bug:
http://stackoverflow.com/questions/23355179/safari-doesnt-call-iframe-onload-when-src-is-not-valid-site
The odd thing is that my test basic UIWebview app works, and taking the isIE path works. The main difference I have seen so far is the baseURI of the iFrame is a file:/// in the cordova app instead of http:// in the UIWebview app. The good news is that I believe we have finally found the exact issue, and now just need to figure out a fix/work around.

Thanks @matwood
As a potential solution, I like the idea of polling for the readyState, using a _.once() callback (or similar) to ensure the onload logic is not invoked more than once. Something like:
    var doc = iframe.contentDocument || iframe.contentWindow;
    if (doc.document) doc = doc.document;
    var _timer = setInterval(function() {
        if (doc.readyState == 'complete') {
            clearInterval(_timer);
            ONCE_ONLOAD_CALLBACK();
        }
    }, 100);

What do you think?

@danielweck I'm going to try that shortly, although I'm not sure it will work because when I debug the code it looks like setting the blob on the iframe silently fails. So while I think the issue is related it may not be the same thing.
At this point I also really want to know the exact trigger of the problem :)

I believe this is caused by the same issue with the Blob URIs not being accepted by the iframe.
https://github.com/readium/readium-js/issues/72

@danielweck I wanted to confirm that the solution with the time does NOT work because the iframe is failing to load the blob. I'm fairly confident the createObjectUrl is the culprit and is not something I can without having access to UIWebViews source code. I'm going to look for work around.
I see the code comments and you explained above that using document.write breaks other functionality. Is this also true for using src or srcdoc?

@matwood, I would strongly encourage you to look at the feature/WKWebView branch and look into using WKWebView instead of UIWebView.  I am not sure why this feature branch has not been merged to develop and master.

The problem with the WKWebView is that it will not fix Chrome on iOS or Cordova. Neither has moved to the WKWebView fully yet.

As a final follow up to this issue I'm retracting my statement above about createObjectUrl being the culprit. After trying to make something work with src and srdoc I finally got an origin access error. In Cordova the baseURI of the iframe is a file:/// as is the documentDataUri. I believe these are causing browser security issues [1]. Hopefully my research here helps someone else fix the issue if possible, but for now I'm going to detect Cordova[2] and Chrome iOS[3] and follow the IE path.
[1] The UIWebView works fine loading the same code from a website. It only fails when loading the code from the devices file system.
[2] iframe.baseURI.match('file:///')
[3] window.navigator.userAgent.match('CriOS')

I am experiencing the same issue as describe above, I believe.  Using the most recent chrome browser on an IPad (IoS 9.3.5), a hybrid app using readium-js-viewer master branch, the iframe.onload() function never executes.  If I change 'isIE' to true, then it does.

Please try the following fix from this Pull Request: https://github.com/readium/readium-js/pull/73
(in fact, to make things simpler in your tests, just force var isIE = true;, and check the results)


app-emulation: Upgrade Docker 20.10.24 to 20.10.25

CI: http://jenkins.infra.kinvolk.io:8080/job/container/job/packages_all_arches/1872/cldsv

[x] Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
[ ] Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

systemd.sysext.custom-docker failed for 20.10.25, because 20.10.25 binaries are still not available in neither https://download.docker.com/linux/static/stable/x86_64/ nor https://download.docker.com/linux/static/stable/aarch64/

Ok, let's wait for now. Added on-hold.

As it is outdated, and the missing tarballs will not be available, I would like to suggest closing the PR.

Yeah, updating to 24.x would be a better way forward. Closing then.


Feature/dev 1327 integrate idf 5 1

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 19 committers have signed the CLA.:x: zhp0406:x: nileshkale123:x: muhaidong:x: BetterJincheng:x: freakyxue:x: mahavirj:x: Isl2017:x: ESP-YJM:x: jack0c:x: Weijian-Espressif:x: zwx1995esp:x: gytxxsy:x: kelin6:x: zhaoweiliang2021:x: KonstantinKondrashov:x: ginkgm:x: chshu:x: xieqinan:x: luomanruomuhaidong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm sorry, I pushed this to the wrong target! It was intended for our fork, not the upstream!


Fix busy_handler_timeout tests

@flavorjones: This should fix CI, no need to revert

Debugging now.

@flavorjones: It seems that windows-latest does release the GVL with busy_timeout 😳:
["busy_handler_timeout", [".", ".", ".", ".", ".", ".", ".", ".", ".", ">", ".", ".", ".", ".", ".", ".", ".", ".", "."]]
["busy_timeout", [".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ">", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", ".", "."]]

Do you see something wrong in the tests, or is Windows just behaving differently with threads?

You know what, why do we need a test that the busy_timeout holds the GVL? That isn't actually necessary. The test that busy_handler_timeout allows the work thread to work while retrying is the test that is necessary. I'm just going to delete the other test.

@flavorjones: Removing that test, as fully expected, brings us to green. I see you just reverted, so I will need to add back the actual method, but that is easy enough. If you agree that the one test about busy_timeout is actually superfluous, I will add the method back, keep the new test, and we can move forward with that. Let me know and I will do this tomorrow (headed to bed now)

@flavorjones @tenderlove This adds the code back with a single robust test that asserts the new code behaves how we want. Should be good to go

@flavorjones @tenderlove: Is there anything I need to do to get this reviewed? Not trying to be pushy, only proactive. If you simply are busy in the short-term and can't review PRs in this repo, I understand. I'm only pinging because I know as a maintainer on a level probably with 10x or 100x fewer notifications, it is easy to "mark something as read" and then it slips into the ever-flowing stream of notifications and things to consider.

@fractaledmind no worries, thanks for pinging. CI is green and the patch seems good, so I'll merge!


[Resolve Errors] [Review Warnings] edge case handling of VALIDATION_IN_PROGRESS

Using Get Submission Latest fetch - No long polling enabled
Account for if VALIDATION_IN_PROGRESS is received on initial fetch

I think this has been resolved?


Mojibake problem: â"

Hi,
U+00E2  â       [Ll] LATIN SMALL LETTER A WITH CIRCUMFLEX
U+0022  "       [Po] QUOTATION MARK
SHOULD BE:
U+2126  Ω       [Lu] OHM SIGN

Example:

Breed meetbereik van 10k - 1Tâ"

Is it possible to fix this?

Same problem with ambiguous quotation marks.


Support lower versions of Laravel

Can you kindly lower the requirements for Laravel Framework, please?
At least support the LTS versions.

In our projects, we only use the latest Laravel version, so it does not make sense for us to support older versions (such as LTS).


Investigate whether fsync system call is needed for fs backend atomic rename operation

Rumor has that on Linux one needs to call fsync after temp file has been written out first before calling rename syscall, otherwise we could end up with an empty file in the new location during system crashes.

This is almost certainly true, because rename is a metadata-only operation. However, a call to fdatasync should suffice because rename by virtue of being atomic must anyway sync all metadata needed to find and open the file (or at least, if there's a crash, the rename must have either succeeded or it did not).

can I take it ?


Typo: Missing the word "not" for the new LaTex option

When attempting to build a LaTex PDF I am getting the warning:
WARNING: audio option is supported for latex builder

I think it should be:
WARNING: audio option is NOT supported for latex builder

This is fixed in sphinxnotes-lilypond==1.5.1


[feature req: Color Highlight of Active bracket]

When you are inside of a bracket ( some text here), while you write inside of it, it will highlight those bracket.

I second to that: I really wish only the current active bracket would be highlighted, and not any open/close brackets.
function foo() {
    if () {
       // if cursor is here, only the if opening/closing brackets are hilighted
    }
}

"bracketPairColorizer.highlightActiveScope": true


Address already in use: JVM_Bind

Hey there! First of all thank you for creating this tool as Ubisoft doesn't seem to be particulary keen on providing actual support neither to their games and their launcher, nor their users. However, we cannot seem to make this work.

Environment
Windows 7 Ultimate 6.1 (build: 7601: Service Pack 1)

Symptoms
Right after launching the tool, this error message appears (see also attached image), it can only be closed:

Port 443 may be blocked, please close any applications using it (webservers and so on).
java.net.BindException: Address already in use: JVM_Bind

Troubleshooting done
Identified possibly interfering applications

port 443 is used by PID 4, reserved by system\smss.exe, the session manager, which shouldn't be killed or closed
port 443 might be used by Skype if a certain setting is left checked, it has been uninstalled

At this point, we're pretty much stuck. Have you maybe experienced something like this? Where were we going wrong? Thank you in advance.

This means indeed that some other application is already listening to TCP 443. You can find out which one exactly it is by using a tool like this: https://docs.microsoft.com/en-us/sysinternals/downloads/tcpview

As you can see, I'm using Visual SVN, which has a HTTPS service running on localhost. You can try visiting https://localhost/ and see where you arrive.
So when I want to use the tool, I need to open the Windows services view (services.msc), and stop the Visual SVN Webserver before launching the tool. I can restart it after I'm done playing Ubi games and shut down the launcher & tool.
Hope this helps.

Thank you for your reply, I'll get back to you if it has been sorted out.


Deploy Letta Server behind reverse proxy

Is there a way to deploy the Letta server behind a reverse proxy, thus changing the base URL?

What exactly do you mean by a reverse proxy in this case? You can set the port using --port when you run letta server, but Letta itself will just run on localhost. If you want to expose the server with a static IP you could try ngrok or use a standard deployment stack w/ Docker. (please reopen if needed)


Replace mlutil.callbackOn() with func.bind()

The standard built-in function provides the same functionality.

Hi, Mike:
Ordinarily, I would also expect built-in operations to be more performant as well as cleaner, but it appears that bind() has a fundamental design issue:
http://stackoverflow.com/questions/17638305/why-is-bind-slower-than-a-closure
Unless we have some confirmation that v8 has come up with a way to make bind() as fast as a closure, maybe we should continue to use closures.
If that sounds right, please close the issue.

Thanks for the explanation, Erik.


Register rfid to user-objects

No idea what was originally intended here.

I mean if I don't even know what it means, it does us no good here. I think what was meant was posting the RFID to a user in the case that no RFID was registered for the attendee. This has been implemented on the OW4 side.


Unable to filter

Description
Unable to filter data
Using postman i am doing a PATCH to settings to make search_terms filterable
    "filterableAttributes": [
      "restricted_to_groups",
      "tags",
      "search_terms"
    ],

If i then do a GET on settingsin postman i can see the filterableAttributes have been saved ok
Then i clicked update on the collection in the strapi plugin dashboard
If i do the GET on settings in postman again i can see that it has lost the filterableAttributes i previously set and it is an empty array again.
If i do a search with "filter" like search_terms='test' i would expect zero results. But i just get the same results i get without the filter.
It is my understanding that after setting the filterableAttributes you must re-index but i am losing the setting on doing so.
Expected behavior
When adding filter to query the results will be updated accordingly
Current behavior
No effect adding filter
Screenshots or Logs
If applicable, add screenshots or logs to help explain your problem.
Environment (please complete the following information):

Meilisearch version: v30.5
strapi-plugin-meilisearch version: v0.8.2
Strapi version: v4.5.3

I had the same issue on meilisearch v29, i updated to v30.5 to see if it was any better but same results

Might be similar to #631
Did you add your settings in the Meilisearch plugin configuration file?
// plugins.js

module.exports = () => ({
    //...
    meilisearch: {
        myCollection: {
            settings: { filterableAttributes: ["restricted_to_groups"]}
       },
    }
})

I updated my previous response, it was not formated correctly

@bidoubiwa no, will try that

You can close this it works with that plugin config thanks

Nice 🔥


Try to listen on random port for login command

We will still fallback to the old port if this doesn't work for some reason.
It's better to do this rather than pick a random port, at least then it's easily addressable by the user.
Requires a backend and frontend update.

Task linked: CU-862j2cj1e spacectl web Login broken if another service is bound on port 8020

Note: finding open ports then binding is always susceptible to race conditions, but this should be fine 👍

This PR is already approved, but I want to note that a possible alternative is to make the getOpenPort function return a net.Listener, and use that with server.Serve(l) (instead of server.ListenAndServe()).
(The getOpenPort function would need a different name in this case, though.)
That way we never actually close the listener we already have.
For reference, (*http.Server).ListenAndServe doesn't do much more than that.


Add the new Boost icon to the list of icons

 (1) Reactions: Add the new Boost icon to the list of icons


SWS-164 Wire Graph to backend.

Wire the graph screen with the backend API.
Also uses breadthfirst layout so that the thingies overlap less

https://issues.jboss.org/browse/SWS-164

Pull Request Test Coverage Report for Build 105

1 of 6 (16.67%) changed or added relevant lines in 1 file are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.7%) to 45.884%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/ServiceGraph/ServiceGraphPage.tsx
1
6
16.67%

Files with Coverage Reduction
New Missed Lines
%

src/pages/ServiceGraph/ServiceGraphPage.tsx
2
58.7%

Totals

Change from base Build 97:
0.7%

Covered Lines:
200

Relevant Lines:
336

💛  - Coveralls

On 28 Feb 2018, at 12:12, abonas wrote:

is this todo documented somewhere outside of code? JIRA?

Yes inside SWS-164 Jira and I think I also added it to SWS-165,
but can make it more obvious.

calling that kind of api do not receive any resource, they receive a
specific representation of the entities/resources in that namespace.
that should be an input parameter on a GET request on a namespace
resource, not a separate api.

Right. With that argumentation, it should perhaps even a
media type and not a queryParam that tells the type of result.
On the other hand, a resource does not necessarily be a 'leaf'
in a tree, but can be a compound (which then probably has links
to more data). E.g. a bill, that then also links out to individual line
items (descriptions).
It is exposed like this on the server for now, so the UI has to follow
it.

Right. With that argumentation, it should perhaps even a
media type and not a queryParam that tells the type of result.
On the other hand, a resource does not necessarily be a 'leaf'
in a tree, but can be a compound (which then probably has links
to more data). E.g. a bill, that then also links out to individual line
items (descriptions).
It is exposed like this on the server for now, so the UI has to follow
it.

yes, I commented on that api on server side as well in the PRs that added it.
media type also makes sense.
having "graphs" in plural is even more confusing

@pilhuhn if you merge https://github.com/swift-sunshine/swsui/pull/56 you'll get namespace param

We are missing live updating of this data, right?

On 28 Feb 2018, at 16:52, Matthew Wringe wrote:

We are missing live updating of this data, right?

Yes. And without this PR we miss any real data :-)

True, lets skip live data and get this PR in :)

yes, I commented on that api on server side as well in the PRs that added it. media type also makes sense. having "graphs" in plural is even more confusing

@abonas  Please add a jira for saturn team and we'll iterate on the graphs rest api in sprint 2.

For linking the live data to a particular namespace, that is now being tracked in https://issues.jboss.org/browse/SWS-176

@mwringe I am waiting on #56 being merged and will re-do on top of this then.

@jshaughn @mwringe https://issues.jboss.org/browse/SWS-181


[Bug]:  youtube music is not connecting

Consent

[X] I have searched the existing issues and verified that there is no open issue for the same subject.
[X] I understand that the YTMDesktop Elgato Plugin has NO affiliation with Google, YouTube or the YTMDesktop application.

Current Behavior
it was working since I downloaded the plugin, I didnt even need to touch any settings and it worked but since yesturday it just stopped working. The YTM app I'm using doesnt even have the botton that gives you the host numbers like vidoes tell me.
Expected Behavior
I expecte it to just keep working like how it was.
Steps To Reproduce
1.I got back onto my pc and it gave me the warning symbole on the play-pause botton.
2. I havent gotten it to work ever since I got back onto my pc yesturday.
OS
Windows
OS Version
10
Plugin Version
v2.1.0
YTMDesktop Version
v3.3.2
How did you download the software?
Elgato Store
Anything else?

idk if it helps but its the picutre of the remot controle botton not being there in the app to connect the stream deck to it.

Hello and thank you for opening this ticket.
For some reasons your YTMDesktop version doesn't even look similar to the one I'm using

Which one do you use? Because v3.3.2 of YTMDesktop isn't known to be as well. The latest one is v2.0.2.

After some research I found out that you're using a different kind of application and I've to inform you that this version is not supported by me. The only reason why it worked in the past is that it's probably a fork / clone of the original one.
For now I don't have the intention to support other kinds of youtube music apps except YTMDesktop, therefore I gonna /close this ticket.
If you still have questions or you think this is an error, feel free to comment or even reopen this issue.

Hi thanks for informing me that I'm using the wrong version but the version that is supported by you is not available to me. When I click on the YTMDesktop in the description but it brings me to an error screen stating that it so no where to be found. That is why I'm using this one right now The original version I was using before this one was working fine but I deleted it after it stopped working thinking it would fix the problem but when I went to go find it again it was gone.

That's because the repository of the original is temporarily down. They're working on it right now.
In the meantime, I created my own build for it located here https://github.com/XeroxDev/ytmdesktop/actions/runs/8168815730


Memory problem with connector version 0.5.0

When I followed the tutorial to download the Spark connector version 0.5.0 and the latest Clickhouse-JDBC, I used spark-SQL with grpc to read the Clickhouse data, and the following error occurred
xenon. clickhouse. except ion . CHServerException: [GRPC] default@localhost :9100}/ssb [241] DB: :Exception: Memory limit (total) exceeded: would use 64.76 GiB (attempt to allocate chunk of<PHONE_NUMBER>0 bytes), maximu55.58 GiB. OvercommitTracker decision: Query was selected to stop by OvercommitTracker.. server C lickHouseNode luri=grpc:// loca lhost : 9100/ ssb a999451279

Which Spark and ClickHouse versions you are using? And is the ssb table a partitioned table? Please provide your ssb table schema and scales, and the Spark query SQL.
Basically, the connector will discover the clickhouse table's partition, and spilt the spark table scan operator into SELECT <required_columns> FROM <clickhouse_db>.<clickhouse_tbl> WHERE _partition_id=<partition_id> by paritions, then retrieve data in streaming mode, so it would not expected huge memory usage. Could you please try HTTP mode and see what happens?

@pan3793 Hello, may I ask if this problem has been solved？

Sorry, there is no further investigation.

Sorry, there is no further investigation.


Some racer matches and other stuff

Can func_8001B834 asm be deleted?

yep i forgot that one good call


Fix Local Volumes Node Affinity

Description
This ps fixes an issue that makes it possible that some pods mounting local volumes were scheduled in remote clusters.
When the local real PV has no node affinities this bug makes also the virtual PV not have node affinities. Now if the real PV has no affinity only the virtual PV affinities are taken (i.e. node not in virtual nodes).
How Has This Been Tested?

[x] locally
[x] add now unit test

/test

/rebase test=true

/host Still to perform some tests on CrownLabs

/unhold Everything seems to work smoothly

/merge


Fix docker build issue on Windows

Currently ballerina docker command seems to be failing on Windows due to three reasons:

Resource path /docker/image/Dockerfile is being constructed with Windows file separator
Fabric8 docker-client defaults its temporary directory to "/tmp" [1] and that is being invalid on Windows
Default docker host is being set to UNIX Docker socket and it does not work on Windows

This pull request fixes these issues by changing the resource path of the Dockerfile template to "/docker/image/Dockerfile", setting "tmp.dir" to dynamically generated temporary directory and adding a validation to check whether the user has provided docker host parameter if the OS is Windows.
Sample usage on Windows:
ballerina docker echoService.bsz
ballerina: docker host parameter is required

ballerina docker -H https://<IP_ADDRESS>:2376 echoService.bsz

[1] https://github.com/fabric8io/docker-client/blob/v1.2.1/client/src/main/java/io/fabric8/docker/client/impl/BaseImageOperation.java#L27

@chamilad Thanks for pointing! README.md is now updated, please review.


Decide on mechanism for annotating experimental APIs

Category
User level API changes
Describe the feature you'd like to request
Before releasing the  APIs in #75 we need to decide how to distinguish experimental APIs from stable.
We should at least document stability in java-doc comments. This is easy add, but easy for users to miss.
A more robust mechanism might take advantage of Java annotations  Annotations support automated processing in ways that could allow us to reflect the annotation into the javadocs or write a tool that warns when using an experimental API. Some options are:

Use @Deprecated. This feels like an abuse of the annotation, but according to JEP 277: Enhanced Deprecation (which seems pretty official), "deprecating" experimental APIs is one of the intended use cases for the annotation. Advantages to this are that there's no additional libraries/code we need to use it, and library consumers get a warning from the compiler when using it without need to apply any other checks. Deprecation annotation show up in JavaDocs, and we can use the separate @deprecated javadoc tag to explain that it's
Use @Beta from Guava. This feels more semantically correct, but ISTM that @Beta isn't intended for use outside of Guava. We already depend on Guava, so this doesn't add any new dependencies. Library consumers would need to add an extra tool to their build if they want to verify that they don't depend on beta APIs.
Define a custom annotation. We could make this @Experimental to be consistent with the Rust library. Custom annotations will show up in the docs if we add @Documented to the annotation definition. Unless we write it ourselves, there wouldn't be any tool to automatically check that the annotation isn't used. Writing that tool would be easy. See https://stackoverflow.com/a/1754823

We could also consider excluding these features from the mean release. They could then be released in a separate version, e.g., 3.0.1 would exclude these features while 3.0.1-experimental would have all experimental features
Describe alternatives you've considered
.
Additional context
No response
Is this something that you'd be interested in working on?

[ ] 👋 I may be able to implement this feature request
[ ] ⚠ This feature might incur a breaking change

@john-h-kastner-aws I added an Experimental annotation to my partial evaluation PR. I'm happy to revert it if we don't want to mix concerns or add this issue reference to my PR if you think that's the right way forward.

Resolved to @Experimental options by #75


Added 2 new books in C and Python

What does this PR do?
Add resource(s)
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
2 books one for C and the other for python
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

This appears not to be an authorized distribution. Please see docs/CONTRIBUTING.md guidelines.


remove object meta validation from webhook

Description
Remove object meta validation from webhook. It's not needed because kubernetes use default validation for object meta.
Related issue(s)
See also #250

/test all

/test pre-serverless-integration-k3s

/test pre-serverless-integration-k3s

/lgtm


Update reconciler-test to latest commit in release-1.10

Changes

Update reconciler-test to latest commit in release-1.10
Incorporates https://github.com/knative-extensions/reconciler-test/pull/573

/lgtm

@ReToCode or @creydr  we need this on the 1.11 midstream branch, as well.
Would one of you mind doing that?

@ReToCode or @creydr we need this on the 1.11 midstream branch, as well. Would one of you mind doing that?

I can take care of this on Monday


Add fastboot check

This PR disabling app.import that is not allowed in ember fastboot. Maybe there are another way to fix this then I am ready to implement it, just let me know.

Im not sure this is how we want to coordinate these two concepts, hardcoding fastboot in this addon seems funky.
@tomdale any thoughts?

@stefanpenner Not sure of a better option at the moment; ideally we will eventually have a first-calss notion of "targets" in Ember CLI. I think that is the right approach long-term.

Not relevant anymore


Loading of Puppet Types/Functions etc. should rescue errors and not crash

From - https://github.com/lingua-pupuli/puppet-vscode/issues/349
What Versions are you running?
OS Version: N/A
VSCode Version: N/A
Puppet Extension Version: 0.11.0
Puppet Agent Version: N/A
PDK Version (if applicable): N/A
What You Are Seeing?
D, [2018-08-13T16:11:23.271452 #9328] DEBUG -- : [PUPPET LOG] [err] Could not autoload puppet/parser/functions/hiera.rb: cannot load such file -- hiera
E, [2018-08-13T16:11:23.273468 #9328] ERROR -- : [PuppetHelper::_load_default_functions] Error loading function puppet/parser/functions/hiera.rb: Could not autoload puppet/parser/functions/hiera.rb: cannot load such file --
 hiera ["C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in require'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:inrequire'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/hiera_puppet.rb:1:in <top (required)>'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:inrequire'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in require'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/parser/functions/hiera.rb:1:in<top (required)>'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/autoload.rb:68:in load'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/autoload.rb:68:inload_file'",
 "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/autoload.rb:194:in load'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:364:inload_function_file'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:424:in block in _load_default_functions'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:421:ineach'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:421:in _load_default_functions'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:71:inload_functions'",
 "c:/Users/mchen6/My Programs/VS Code/data/extensions/jpogran.puppet-vscode-0.11.0/vendor/languageserver/lib/puppet-languageserver/puppet_helper.rb:76:in `block in load_functions_async'"]

What is Expected?
It shouldn't crash
How Did You Get This To Happen? (Steps to Reproduce)
Output Log

Merged as part of sidecar.  Closing.


Extractor Crash JS function 'encodeURIComponent' - version update 1 hr prior.

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.02.08. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[ X] I've verified and I assure that I'm running youtube-dl 2019.02.08

Before submitting an issue make sure you have:

[X] At least skimmed through the README, most notably the FAQ and BUGS sections
[ X] Searched the bugtracker for similar issues including closed ones
[ X] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[X] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2019.02.08
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
horace@horace-P57:~$ youtube-dl https://www.youtube.com/watch?v=_ehkBNd03yQ
[youtube] _ehkBNd03yQ: Downloading webpage
[youtube] _ehkBNd03yQ: Downloading video info webpage
[youtube] _ehkBNd03yQ: Downloading js player vflP40QgO
ERROR: Signature extraction failed: Traceback (most recent call last):
File "/snap/youtube-dl/64/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 1226, in _decrypt_signature
video_id, player_url, s
File "/snap/youtube-dl/64/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 1134, in _extract_signature_function
res = self._parse_sig_js(code)
File "/snap/youtube-dl/64/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 1201, in _parse_sig_js
initial_function = jsi.extract_function(funcname)
File "/snap/youtube-dl/64/lib/python3.5/site-packages/youtube_dl/jsinterp.py", line 245, in extract_function
raise ExtractorError('Could not find JS function %r' % funcname)
youtube_dl.utils.ExtractorError: Could not find JS function 'encodeURIComponent'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
(caused by ExtractorError("Could not find JS function 'encodeURIComponent'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
horace@horace-P57:~$ youtube-dl --version
2018.12.09

Error message was converted to strikethrough text. In case it doesn't attach, have copied below.
horace@horace-P57:$ youtube-dl https://www.youtube.com/watch?v=_ehkBNd03yQ
[youtube] _ehkBNd03yQ: Downloading webpage
[youtube] _ehkBNd03yQ: Downloading video info webpage
[youtube] _ehkBNd03yQ: Downloading js player vflP40QgO
ERROR: Signature extraction failed: Traceback (most recent call last):
File "/snap/youtube-dl/64/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 1226, in _decrypt_signature
video_id, player_url, s
File "/snap/youtube-dl/64/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 1134, in _extract_signature_function
res = self._parse_sig_js(code)
File "/snap/youtube-dl/64/lib/python3.5/site-packages/youtube_dl/extractor/youtube.py", line 1201, in _parse_sig_js
initial_function = jsi.extract_function(funcname)
File "/snap/youtube-dl/64/lib/python3.5/site-packages/youtube_dl/jsinterp.py", line 245, in extract_function
raise ExtractorError('Could not find JS function %r' % funcname)
youtube_dl.utils.ExtractorError: Could not find JS function 'encodeURIComponent'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
(caused by ExtractorError("Could not find JS function 'encodeURIComponent'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see https://yt-dl.org/update on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.


Task/history UI

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 58.309%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
200

Relevant Lines:
343

💛  - Coveralls


How to correlate patient_ids

Dear Fjeg,
Thank you for making this work available.
I am trying to convert complementary normal cases from DDSM which are not present in CBIS-DDSM.
I realized that the Patient IDs do not match, for instance, CBIS-"Calc-Test_P_00038_LEFT_CC" may lead to think that is related to DDSM-"C-0038-1"  or some other 0038 (as DDSM has some duplicated numbers), but it is not.
Is there any way to relate patient IDs from CCSM to CBIS-DDSM so that I can convert remaining images from an exam?
Best regards,
Daniel

Hi,
if you have converted the DDSM Images you can compare them to retrieve the patient id mapping.
There was one problem with the optical density mapping see other issue but other than that you get pixelperfect CBIS-DDSM images if they are included.


make volume attachment limit as configurable

There are 2 level of checks involved in this
1.) CSI Driver checks for the limit depending on the number of cores node. Check the code
NodeGetInfo
https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/blob/master/pkg/ibmcsidriver/node.go
2.) VPC IAAS itself does not allow more than 12 limits it needs to be increased with exceptional approval via support ticket
https://cloud.ibm.com/docs/vpc?topic=vpc-attaching-block-storage&interface=ui
As part of this fix we can try to remove the hardcoded check and accept this as configurable parameter
Refer similar logic for CPU and memory limit we have taken user input as part of config map
https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/blob/564aa688c069300ef4350fa9d7ec5c841a32a257/deploy/kubernetes/driver/kubernetes/manifests/config-map.yaml#L67
https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/blob/564aa688c069300ef4350fa9d7ec5c841a32a257/deploy/kubernetes/driver/kubernetes/manifests/node-server.yaml

I am working on this issue.

PR: https://github.com/kubernetes-sigs/ibm-vpc-block-csi-driver/pull/141

We have increased our volume per worker quota to 50 at the infrastructure level but the CSI driver is still limiting us to 12.
This fix is required urgently for the MQ team to deliver to a large customer.  Please prioritize this as it is currently blocking for us.

sure @nortonp1806

Test case logs: volume-testing.zip

5.2 addon will be releases soon with this fix.

Hi @arahamad , can we close this issue?

we can close this issue as fix is released as well


Extract shared test library to avoid #[path] directives

What have you changed? (mandatory)
This PR is based on PR #3362 and does similar jobs as in PR #3360.
This PR extracts shared test library (test utils, raftstore for tests and storage for tests) into standalone workspaces, so that it can be both used in benches and tests without the ugly #[path] directive (usually also needs a #[allow(dead_code)].
Since these extracted workspaces are dev dependencies, the previous benches/bin/tikv-bench is also slightly refined to work with these new workspaces. During refinement, criterion is introduced so that our bootstrap code to setup the test can be just removed.
What are the type of the changes? (mandatory)

Improvement (non-breaking change which is an improvement to an existing feature)

How has this PR been tested? (mandatory)
Makefile
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No.
Does this PR affect tidb-ansible update? (mandatory)
No.
Refer to a related PR or issue link (optional)
Please merge this PR first: #3362
Benchmark result if necessary (optional)
Add a few positive/negative examples (optional)

/run-integration-tests

@siddontang Done

To reviewers: note that this PR used criterion.rs to replace our test harness. However since it runs each benchmarks 100 times, it is really slow. We may need to seek for alternatives, for accept this time cost in raftstore benchmark (for a more precise result).

I don't think we need to run each benchmark 100 times, it's unacceptable. Please do make things getting fast.

Sample size is adjusted. It is much faster now.

@BusyJay @zhangjinpeng1987 PTAL

So is it proven that workspace is good for build cache? How much does it speed up the compilation?

@BusyJay The finding is that,

for fresh compile, it will not speed up either debug mode or release mode compile.
for re-compile over a changed source code, it will not speed up debug mode compile (since debug mode compile has incremental compile). However for release mode or benchmark, workspace separated is very very useful, from the following aspects:

The benchmark you are written can be targeting at a single or few workspaces, not a total TiKV library any more, which is very fast to be compiled, even if you are adjusting the workspace source code.
The separated workspace will not be re-compiled if it is not changed. (However notice that in release mode, link might be the most expensive stage)

/run-integration-common-test

@Hoverbear Yes. This can be an alternative solution. Since workspaces are beneficial for speeding up benchmark compiling according to current investigations, these are directly converted into separated workspaces so that in future we don't need to convert module to workspace again.

@Hoverbear Before we find better solutions than separated workspace for the compile time issue, I prefer to keep it now, since it's the only way for now.

@siddontang I made some change to resolve conflicts. Please approve again, thanks!

/run-integration-tests

Please sign off your all commits. See https://github.com/tikv/tikv/blob/master/CONTRIBUTING.md#signing-off-the-commit
If you have already pushed some commits before, you can use git rebase -i master --signoff to resign them off.

@siddontang My rebase will fail because of conflicts :(

@overvenus  @siddontang Done, git rebase will fail into conflicts. I used git diff && git apply to generate a fresh working copy. Please re-approve. Thanks!


Set the test_suite variable to avoid TypeError in setuptools

When running 'python setup.py test' or 'tox' under Python 2.7 in both Ubuntu and in MacOS, I would get these errors:
$ python setup.py test
running test
Traceback (most recent call last):
  File "setup.py", line 134, in <module>
    'Programming Language :: Python :: 3.2',
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py", line 152, in setup
    dist.run_commands()
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 972, in run_command
    cmd_obj.run()
  File "/Users/stanhu/.virtualenvs/raven/lib/python2.7/site-packages/setuptools/command/test.py", line 136, in run
    cmd = ' '.join(self.test_args)
TypeError: sequence item 1: expected string, NoneType found

It turns out this was happening because self.test_args was ['-v', None]. The extra None parameter was inserted when both self.test_suite and self.distribution.test_suite were set to None.
I'm not sure how this ever worked before, but setting the test_suite variable fixed the issue for me.

Ok, I finally reproduced it.

Thanks for the pull request.


Issues when executing build-s3-dist.sh

Hi,
A couple of issues when running build-s3-dist.sh (running from Ubuntu on AWS Cloud9):
pip install -t . crhelper returns an error:
DistutilsOptionError: can't combine user with prefix, exec_prefix/home, or install_(plat)base
Following SO answers by changing it to pip install --user --install-option="--prefix=" crhelper resolved it.
Also, some of the commands in the script produce output which I'm not sure is expected:
copy yaml templates and rename
cp: cannot stat '/home/ubuntu/environment/genomics-secondary-analysis-using-aws-step-functions-and-aws-batch/deployment/*.yaml': No such file or directory
mv: cannot stat '*.yaml': No such file or directory
Updating code source bucket in template with XXXX-pipeline-distribution
sed -i '' -e s/%%BUCKET_NAME%%/XXXX-pipeline-distribution/g /home/ubuntu/environment/genomics-secondary-analysis-using-aws-step-functions-and-aws-batch/deployment/global-s3-assets/*.template
sed: can't read : No such file or directory
sed -i '' -e s/%%SOLUTION_NAME%%/XXXX-Pipeline/g /home/ubuntu/environment/genomics-secondary-analysis-using-aws-step-functions-and-aws-batch/deployment/global-s3-assets/*.template
sed: can't read : No such file or directory
sed -i '' -e s/%%VERSION%%/1.0/g /home/ubuntu/environment/genomics-secondary-analysis-using-aws-step-functions-and-aws-batch/deployment/global-s3-assets/*.template
sed: can't read : No such file or directory

Finally (and maybe related to the above), there's no ./dist folder to upload to S3 when the script is done.
Thanks in advance,
Ury

@ury -
These are a couple of variances due to differences in Linux distributions and MacOS.
The crhelper install doesn't throw a traceback when using Amazon Linux 2 for a Cloud9 instance. Even with the traceback under Ubuntu, the crhelper package still gets installed into the desired target path:
./source/setup/lambda

You can safely ignore the sed errors. They are due to the -i '' option provided, which is necessary with the version of sed on MacOS, but not with sed on LInux.
All assets get built into two folders:

./deployment/global-s3-assets:  contains the main solution installation template and required asset bundles.
./deployment/regional-s3-assets:  contains only the installation asset bundles and sample data used for the solution.

These match with the process that AWS Solutions uses to enable global deployment of solutions.

Thanks Lee,
I proceeded per your clarifications.  There are a couple of instructions in README.md that I wasn't sure about:

aws s3 cp ./dist/ s3://my-bucket-name-<aws_region>/$SOLUTION_NAME/$VERSION/ --recursive --acl bucket-owner-full-control --profile aws-cred-profile-name

./dist - which folder is that?  I assumed it refers to the deployment folder and used it when uploading to S3.
And then:

Deploy the solution to your account by launching a new AWS CloudFormation stack using the link of the solution template in Amazon S3.

you clarified that the template resides in the ./deployment/global-s3-assets folder, so I used the link for the template in that folder
When I create the stack, I get the following error:
Error occurred while GetObject. S3 Error Code: NoSuchKey. S3 Error Message: The specified key does not exist. (Service: AWSLambdaInternal; Status Code: 400; Error Code: InvalidParameterValueException; Request ID: 41067856-0c25-4845-99ed-4516f64a0b1d)
In the template, I understand that the following file is expected: [bucket_name]-[region_name]/[solution_name]/[version]/SetupLambdaBundle.zip, and in my case the file resides in  [bucket_name]-[region_name]/[solution_name]/[version]/global-s3-assets/SetupLambdaBundle.zip.
To match the above, I uploaded only the global-s3-assets folder to S3 and launched the stack creation process again.  This time it lasted longer, but failed during the Setup resource creation:

Failed to create resource. Code Build job 'GenomicsWorkflow-Setup:c82b0974-a7a4-4031-a4be-1b343e176964' in project 'GenomicsWorkflow-Setup' exited with a build status of 'FAILED'.

At this point, I think I should wait for your insights regarding the above, as I did at least one thing wrong.

@ury -
I'm curious about your use case here. Are you attempting to install the solution as is, or have you customized it and wanting to deploy the customized assets?

Hi Lee,
At this point, I'm attempting to install it as-is.

Ok, in that case it's better to use the "Launch" button found on this page:
https://aws.amazon.com/solutions/genomics-secondary-analysis-using-aws-step-functions-and-aws-batch/?did=sl_card&trk=sl_card
The assets are already deployed globally, allowing you to install the
solution in any supported region.
The README instructions are if you want to deploy a customized version.
On Fri, May 22, 2020, 11:24 PM Ury Alon<EMAIL_ADDRESS>wrote:

Hi Lee,
At this point, I'm attempting to install it as-is.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/awslabs/genomics-secondary-analysis-using-aws-step-functions-and-aws-batch/issues/1#issuecomment-632994029,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACYIZXJ2MONHHOO4THNG5DRS5TZLANCNFSM4M6EKE3A
.


missing head route?

When I try the basic example in the README and then run curl -I http://localhost:3000/ I get
HTTP/1.1 404 Not Found
Content-Type: text/html, charset=utf-8

instead of the header. I wonder if defining any route should also create a 'head' route
and/or one should be able to create a head route separately?

Well, at least you should be able to create a head route.

Is it possible? I could not find how to do that.

it would be possible via
https://github.com/ufobat/Bailador/blob/master/lib/Bailador/Route.pm#L127 https://github.com/ufobat/Bailador/blob/master/lib/Bailador.pm#L11) .
Something like this should work.
app().add_route('HEAD' => sub {]);
but there is no (not yet?) syntactical suggar for it:
https://github.com/ufobat/Bailador/blob/master/lib/Bailador/Route.pm#L133
https://github.com/ufobat/Bailador/blob/master/lib/Bailador.pm#L24
it should be just a small change, I think.

Still an open question: What should happen if there is only POST defined for a route and someone asks for HEAD ?

I think this implementation is a bit problematic, because

it is "magic" so i would rather have this implemented in a Bailador::Feature, maybe? I thought thats a good place to put special behaviour implementations, maybe the gradual fits in a feature as well?. but thats just an idea

the code only does not render the body if you use the auto-render mechanism, if you call self.render() in your code of the route the body would probably printed as well

the whole code would be calculated, for example get is something that's starts a mp3 stream. noone would ever consume it and it might not get terminated and delivered and maybe in memory for ever

so my suggestions are:
Bailador::Feature::AutoHead which,

generates a HEAD route for each GET route, unless you specified one manually
changes the behavour of render() for auto generated head routes because, it must omit the body (also if you call render() manually.


Subtitles are huge on plex after remuxing.

Not a big issue but i turn off embedding subs and make a external srt file instead. But it seems like the subtitles are HUGE after conversion. I uploaded an example, this is on plex web player and subtitles are on  "Normal" Even setting it to Tiny makes it look huge.

Script has nothing to do with subtitle size
From: foizashik
Sent: Tuesday, August 13, 2019 10:10 PM
To: mdhiggins/sickbeard_mp4_automator
Cc: Subscribed
Subject: [mdhiggins/sickbeard_mp4_automator] Subtitles are huge on plex afterremuxing. (#1044)
Not a bit issue but i turn off embedding subs and make a external srt file instead. But it seems like the subtitles are HUGE after conversion. I uploaded an example, this is on plex web player and subtitles are on "Normal" Even setting it to Tiny makes it look huge.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Quick google search
https://forums.plex.tv/t/huge-subtitles-on-ps3/69426/9
From: foizashik
Sent: Tuesday, August 13, 2019 10:10 PM
To: mdhiggins/sickbeard_mp4_automator
Cc: Subscribed
Subject: [mdhiggins/sickbeard_mp4_automator] Subtitles are huge on plex afterremuxing. (#1044)
Not a bit issue but i turn off embedding subs and make a external srt file instead. But it seems like the subtitles are HUGE after conversion. I uploaded an example, this is on plex web player and subtitles are on "Normal" Even setting it to Tiny makes it look huge.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Error while adding ElasticSearch datastore

Describe the bug
The following error pops up while trying to add elasticsearch as a datastore

Feel free to attach screenshots as well.
To Reproduce
Try adding an elasticsearch instance as a datastore
Version
What is the version of Horreum ?
Been using the latest deployed on internal network.
git rev-parse HEAD

Java
What is the version of Java ?
java -version

PostgreSQL
What is the version of PostgreSQL ?
psql --version

OS
Which Operating System (OS) is used ?
Browser
Which is the version of your browser ?
Chrome
Tip
Use ``` before and after the text to keep the output as is.

@shashank-boyapally thanks for reporting this issue, it is a UI bug.
Please select a team from the drop-down and try again.
We will fix the drop-down so users need to select a team (or a default is chosen) before allowing you to define a new datasource


Port spouse example to Postgres-XL

Shared sequence seems to be a big bottleneck for Postgres-XL. Key change is a radical UDF used to assign bigint IDs (by creating a new table to replace the old one).

This looks great. Adds new UDF for fast fast sequence assignment similar to the existing UDF for greenplum.


📝 Draggable sidesheet story

resolves #2490

Neat feature! We have also had questions about something similar for Table columns, so this might ball up into a utils function or maybe use a third party lib.
Has this been tested by @equinor/eds-ux ? This is a feature we want to promote?
From a  a11y point of view, I felt like maybe the the "drag anchor" could have had a bigger clickbound for easier interaction?

Has this been tested by @equinor/eds-ux ? This is a feature we want to promote?
From a a11y point of view, I felt like maybe the the "drag anchor" could have had a bigger clickbound for easier interaction?

@lucasveil is going to take a look and we talked about it on friday standup also.
The drag anchor size is similar to slack and vs code, but yes of course those are mildly annoying too. It could be resized while keeping it visually similar but i suspect too big could be problematic also, you don't want to trigger it accidentally.


Release 2.1.1

Test evidence - https://gist.github.com/bbaugher/404ac7f685efb20bb53c76aacc5dfe4a

+1 for release

+1

Got enough +1s, releasing

Released,

https://github.com/cerner/cerner_kafka/tree/v2.1.1
https://supermarket.chef.io/cookbooks/cerner_kafka/versions/2.1.1


Update toolchain version.

There were some syntax changes preventing this from compiling on the latest nightly.
I also updated the rust-toolchain file format: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

Ah, no rustfmt in this nightly.  I'll wait for the next nightly with rustfmt.


Reduce the redis data footprint

I did some tests and found that we can decrease the data footprint for redis by a lot without incurring too much performance cost. The different tests weren't run a lot of times so there's some variance but they're within that range and without any significant differences.
Benchmark description: Generate 2000 random spans (fixed random seed) with a max depth of 7
Binary thrift protocol (what's currently in use for redis)
Client stats:
serialized:25,240,095 bytes
average time:91,314ms
Redis stats:
used_memory_human:50.06M
total_net_input_bytes:102,621,358
Compact thrift protocol
Client stats:
serialized:16,964,527 bytes (67% of original)
average time:101,474ms
Redis stats:
used_memory_human:42.12M
total_net_input_bytes:94,344,292
Snappy with binary protocol
Client stats:
serialized:14,030,192 bytes (55% of original)
average time:83,171ms
Redis stats:
used_memory_human:39.33M
total_net_input_bytes:88,606,829
Snappy with compact protocol
Client stats:
serialized:11,239,468 bytes (44% of original)
average time:85,112ms
Redis stats:
used_memory_human:36.65M
total_net_input_bytes:88,606,829

A working commit that addresses this
https://github.com/openzipkin/zipkin/pull/709

Snappy compression with the compact protocol was merged to master


Update pulsar kerberos and cli document

Motivation
A minor improvement for pulsar kerberos and cli document.

run java8 tests


Add cell clustering steps in

What is the purpose of this PR?
Closes #365. Closes #417. Cell clustering is the final major non-visualization-heavy step, which this PR addresses.
How did you implement your changes
We can piggyback off of the results we get from pixel clustering since we use the SOM and meta clusters assigned there. Also, there is no need for batch processing or subsetting because there are far fewer cells than there are pixels.
Remaining issues
A few things I'm waiting from Candace:

99.9% normalization: do we need it for the consensus clustering step or not? UPDATE: yes, we will.
Decay rate parameter: do we need the alpha to be customizable, or will a default of 0.05 to 0.01 work? UPDATE: yes, alpha should be customizable.
Possibly more to come

Testing will be held off until these are resolved.

For the time being, I'm going to leave 99.9% normalization in. We can always remove it if needed.

Still haven't added testing functions (added and restructured a lot of functions), but cluster_pixels/run_trained_som are several orders faster when we precompute the row sums and remove the cbind call.

In addition to the code review comments being addressed, the tests have (finally) been added!


$returnURL sometimes called twice by SumUp

I use the following to perform a checkout on my site:
        try {
            $sumup = $this->sumUpInstance();
            $checkoutService = $sumup->getCheckoutService();
            $checkoutResponse = $checkoutService->create($amount, $currency, $checkoutRef, $payToEmail, $description, $payFromEmail, $returnURL);
            $checkoutId = $checkoutResponse->getBody()->id;
            //  pass the $chekoutId to the front-end to be processed
        } catch (\SumUp\Exceptions\SumUpAuthenticationException $e) {
            echo 'Authentication error: ' . $e->getMessage();
        } catch (\SumUp\Exceptions\SumUpResponseException $e) {
            echo 'Response error: ' . $e->getMessage();
        } catch (\SumUp\Exceptions\SumUpSDKException $e) {
            echo 'SumUp SDK error: ' . $e->getMessage();
        }

When the provided $returnURL is accessed, the booking is marked as "Paid" and a confirmation email is sent.
However, it seems that sometimes SumUp will access this URL twice, at basically the same time, resulting in the customer receiving two confirmation emails (despite a check on if it's already been marked as paid).
Is this an issue on SumUp's side that is causing this duplicate callback to the $returnURL?

Did you find a way to avoid that double call? I exactly have the same problem right now. That return_url webhook is called twice instantly, making it complicated to handle with asynchronous functions.

I may be wrong, but I think I did implement a workaround by calling the SumUp API when the confirmation page loaded, to instantly get the payment status meaning the payment got logged as paid at my end, before SumUp even made the double webhook call. I've since switched to Stripe.


Add post install for bower install in new packages

Should we add a block for
  "scripts": {
    "postinstall" : "bower install"
  },

It seems a lot of people don't realize they need to add this once adding bower dependencies to cause bower installs to cascade along with npm.
It would add a little time to general npm installs based on how many packages you have, but I doubt it would be much, and if it's a concern someone can always remove the post install scripts for deployment so life is easier on new devs.

Yes. This is related to https://github.com/linnovate/meanio/issues/65 and I think it should be enabled by default. It will have to be to support a complete mean package abstraction.

This would automatically execute a bower install by default for all packages in your view?

Yeah, as the npm install cascades through the packages it would cause the bower install to cascade along with it.


Fix seeking control

SEEK_STEP isn't used in MainWindow.
L150 is a fix to dynamically update the seek_time_control widget when we change the current output.

Thank you for fixing those


Sound Null Safety

Please do something for sound null safety so we can like the package in pub.dev

https://github.com/andronasef/iconify_flutter/pull/10

updated 😥
and sorry for late update


Remove dotnet dependency to start WebListener

PR Summary
WebListener.exe (which was already being built) is sufficient to start web listener. Remove the dependency on dotnet being present to start the web listener.
Use Start-Process instead of Start-Job to launch the WebListener.
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[x] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

@PaulHigin @daxian-dbw Feedback has been addressed, please have another look.

@TravisEz13 Can this be merged?

@TravisEz13 Can this be merged?


'SwitchTo' not working properly after 'within' call

What are you trying to achieve?
I wish to use the method switchTo to navigate between frames.
What do you get instead?
Element is no longer valid error

Provide console output if related. Use --verbose mode for more details.

2019-01-14T16:07:46.524Z INFO webdriver: DATA
node.js:94
Object {using: "css selector", value: "frame[name="Menu"]"}
node.js:94
2019-01-14T16:07:46.541Z DEBUG webdriver: request failed due to status 10
node.js:94
2019-01-14T16:07:46.544Z WARN webdriver: Request failed due to Element is no longer valid
node.js:94
2019-01-14T16:07:46.545Z INFO webdriver: Retrying 2/2
node.js:94
2019-01-14T16:07:46.547Z INFO webdriver: [POST] http://<IP_ADDRESS>:4444/wd/hub/session/ce4b6712-b276-4f73-9696-bc89ab6cd366/element/ed90a4ca-0bd5-43f5-a4c8-d90fffee52f1/elements
node.js:94

Details

CodeceptJS version: 2.0.3
NodeJS Version: 8.9.4
Operating System: Windows 10
Protractor || WebDriverIO || Nightmare version (if related) WebDriver
Configuration file:

WebDriver: {
      url: '--TEST URL--',
      browser: 'chrome',
      host: '<IP_ADDRESS>',
      port: 4444,
      logOutput: './output/webdriverio/log.txt',
      logLevel: 'silent', // TODO: leave silent for now, update webdriverio version to check if logOutput is working properly
      screenshotOnReject: false,
      uniqueScreenshotNames: true,
      debug: false,
      smartWait: 5000,
      disableScreenshots: true,
      windowSize: '1024x768',
      desiredCapabilities: {
        acceptInsecureCerts: true,
        timeouts: {
          script: 60000,
          'page load': 10000
        }
      }

I made a within call
within(x, () => {
I.click('ok');
});

then I try to switch frame
I.switchTo(); \\move to parent context
I.switchTo(myframe); \\move to target frame

In this case codeceptjs understand that my frame is inside the element 'x' used in within call before, what is wrong.
The call for webdriver should be:
[POST] http://<IP_ADDRESS>:4444/wd/hub/session/ce4b6712-b276-4f73-9696-bc89ab6cd366/frame
{
"id":"webDriverFrameId"
}
instead of:
[POST] http://<IP_ADDRESS>:4444/wd/hub/session/ce4b6712-b276-4f73-9696-bc89ab6cd366/element/ed90a4ca-0bd5-43f5-a4c8-d90fffee52f1/elements
This id 'ed90a4ca-0bd5-43f5-a4c8-d90fffee52f1' corresponds to within context used previously.

nothing on this yet, I am also experiencing a similar issue with within().
Context is still not cleared after within() block has finished.


Performance optimisations (ideas wanted)

This is not optimised for running over a vpn or slow network. This is a list of ideas of things that could be investigated to improve performance:

in companion generate checksum for bitmaps and only send if not already 'known' by this remote. Instead of being sent every bitmap when the page changes, we could be more intelligent and only be sent new images if the checksum from above hasnt changed
compression of the bitmaps? (rle, png, gz)

The checksum is a great idea. I used to do this in a streamdeck app I had before Companion and it dramatically improved performance in load times.

The checksum is a great idea. I used to do this in a streamdeck app I had before Companion and it dramatically improved performance in load times.

look at: https://facebook.github.io/zstd/ for compression. Very fast, should be good enough and wide support for it.
Also these assets of 72x72 pixels rgb-values ?? Might be good to compress in one go, all images in one bulk to get better overall compression ratio... a good thing about zstd is that you can train it on a set of representative data for compression yielding better rates even for small sets like 72x72x3 bytes per icon (if not batched together).
No matter what I would add a small hook as soon as possible to the icon-pipeline, this hook should hash the data and create some statistics over unique hashes over time.
My guess is that you see many new hashes early on but most of them will be repeated moving forward in time.

look at: https://facebook.github.io/zstd/ for compression. Very fast, should be good enough and wide support for it.
Also these assets of 72x72 pixels rgb-values ?? Might be good to compress in one go, all images in one bulk to get better overall compression ratio... a good thing about zstd is that you can train it on a set of representative data for compression yielding better rates even for small sets like 72x72x3 bytes per icon (if not batched together).
No matter what I would add a small hook as soon as possible to the icon-pipeline, this hook should hash the data and create some statistics over unique hashes over time.
My guess is that you see many new hashes early on but most of them will be repeated moving forward in time.