Error Upon Opening RealSense Viewer

Required Info

Camera Model
D435

Firmware Version
v2.17.0

Operating System & Version
Linux (Ubuntu 16)

Kernel Version (Linux Only)
4.19.8-v7+

Platform
Raspberry Pi

Issue Description
After installing the SDK for the Intel RealSense Depth Camera, I opened the RealSense Viewer to use the camera. The viewer recognizes that a camera has been plugged into the USB port, but it outputs an error upon booting. I’ve also tried opening other applications such as rs-capture, rs-color, and res-depth-quality, but the first two don’t open and the last loads indefinitely. From my understanding, it may have something to do with starting the device. A picture for reference can be seen down below.

Hi @ShadowHunter0510
Is the camera working correctly on another PC, perhaps on Windows?
One thing to get off the troubleshooting list is to run firmware update on a separate Windows PC.
Usually this error has something to do with camera firmware / calibration

Hey @dorodnic
For clarification, do I update the firmware on the camera itself following these directions in this link or on the actual PC itself? I’ll try downloading the SDK for my Windows PC and see if the camera works there. I’m relatively new to all of this, so I’m sorry if I’m slow to understand.

Hi @ShadowHunter0510
I recommend to do the firmware update on a Windows PC.
We will do our best to assist with any question you might have.

Hi @dorodnic
I just downloaded the SDK onto my Windows PC and the Intel RealSense Depth Camera works fine on it. However, it still does not work on the Raspberry Pi through Ubuntu Mate. What troubleshooting steps can I follow?

Hi @dorodnic
Another update: After running the DFU tool and obtaining the .bin file that contains the latest firmware, I'm having trouble installing the firmware on the camera. Before updating the camera, I check that my camera is in the updatable devices list. Then, when I enter the path and filename, the camera disconnects from my computer by itself and says that no device was connected, even though it previously acknowledged that it recognized the presence of a camera. A picture can be found down below.

Could you please check the camera firmware version? This can be done from the Viewer, by clicking on the (i) icon under device name.

It's <IP_ADDRESS>, as shown in the picture of my last comment as well.

The name is Intel RealSense USB2. The details under "physical port" has some gibberish. Should Windows computers support USB 3? I know that the Raspberry Pi only supports USB 2.0.

Thank you,
I believe firmware update is at the moment limited to x86 Windows / Ubuntu 16.04 and to USB3.
I think firmware update can make a significant difference (hope it will resolve the issue on the Pi), because USB2 support was officially added after 5.9.2

Thank you @dorodnic
Should I now try to update the firmware through Ubuntu instead because my Windows PC doesn't support USB 3.0?

Hi @dorodnic
After installing the firmware on another computer, I am pleased to say that the camera is functioning on my Raspberry Pi! Thank you for your help!

Hi @ShadowHunter0510
Glad it helped!
The reason other examples don't work is because of USB2. In general, USB3 is strongly recommended if you want to use RealSense depth-cameras, since the bandwidth from multiple streams easily saturate USB2 capacity.
USB2 is partially supported by the firmware specifically to enable platforms like the Raspberry Pi, but you don't really get 100% of camera functionality this way.
I'd recommend considering something like ROC-RK3328-CC which is slightly more powerful ARM single-board computer, or the Up-Board which has Raspberry Pi form factor and Intel CPU. Both support USB3.
IMHO the best way to get started is with python.
We have fairly detailed tutorial on detecting objects with estimated distance -
Distance to Object
You can even try live it in the browser by clicking on
If you decide to go with C++, rs-dnn opencv example is very similar.

Hey @dorodnic
Thanks for all of your suggestions! I've been checking out the ROC-RK3328-CC and I'm definitely considering buying it because of its similar functionalities. I noticed that it has a TF card reader instead of a MicroSD card reader. Since all of my files, including the Intel RealSense SDK and Ubuntu Mate, are located on the SD card, I would not have to reinstall everything, correct? I believe that the MicroSD card can be inserted in the reader.

I believe the board can boot from a MicroSD card (at least the one I tested could).
Not sure if it is compatible with the Pi image, I never tried it.

Hi @dorodnic
I have another question that I haven’t been able to figure out. Once I write some code for the Intel RealSense Camera and compile it, how do I run it live? What I would feasibly like to do is take current live video from the camera, analyze the scene with the code, and have the Raspberry Pi send some output. Since I’m not particularly well-versed in this kind of software to hardware translation, I’m a bit confused.

Hi @ShadowHunter0510
Perhaps its best to open a new issue since the original problem is now resolved.
In python example the line cfg.enable_device_from_file("../object_detection.bag") makes it run from previously collected recording. If you remove it, the demo will try to connect to a live camera.
Now you can just put everything starting from frameset = pipe.wait_for_frames() is a while-loop and once you get a bounding box and the distance, send them over the network for example (or log to file, or anything else). This completely depends on your application and interests. You could play with OpenCV Kalman_filter to tracked detected objects in the scene, use depth to cut only the detected object, you could use depth to make sure detected object is real, and not just a flat picture, etc...


mysterious failure when loading note-refactor

I happened to have the console open when firing up obsidian this morning, and noticed the following message:
Loading Note Refactor plugin
VM269:1 Uncaught (in promise) SyntaxError: Unexpected token  in JSON at position 0
    at JSON.parse (<anonymous>)
    at eval (eval at <anonymous> (app.js:1), <anonymous>:5913:47)
VM270:1 Uncaught (in promise) SyntaxError: Unexpected token  in JSON at position 0
    at JSON.parse (<anonymous>)
    at eval (eval at <anonymous> (app.js:1), <anonymous>:5913:47)

I don't understand what's beinge complained about here, but it does seem to be a problem with the plugin, so I am reporting it.

This could be caused by a corrupt or invalid settings file, the data.json in the plugin folder.


Style Intro Page (Home.js) and Include Intro Markdown

The intro page, component Home.js, should look decent and include the Intro Markdown.
Refer to someone who created the Markdown to determine how it should be displayed.

Picking this up now!

In progress. This currently displays the introduction.md and still needs:

[ ] Scroll bar
[ ] Styles
[ ] Clarity of navigation

https://github.com/NorthwestGreenChemistry/PrISM/pull/46


ms-vscode-remote.remote-wsl activation error

[2020-07-16 15:00:25.859] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode-remote.remote-wsl {"startup":false,"extensionId":{"value":"ms-vscode-remote.remote-wsl","_lower":"ms-vscode-remote.remote-wsl"},"activationEvent":"onResolveRemoteAuthority:wsl"}
[2020-07-16 15:00:25.860] [exthost] [info] ExtensionService#loadCommonJSModule file:///c:/Users/aavkoprivi/.vscode/extensions/ms-vscode-remote.remote-wsl-0.44.4/dist/extension
[2020-07-16 15:00:25.865] [exthost] [error] Activating extension ms-vscode-remote.remote-wsl failed due to an error:
[2020-07-16 15:00:25.865] [exthost] [error] TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
	at validateString (internal/validators.js:112:11)
	at Object.join (path.js:375:7)
	at Function.Module._nodeModulePaths (internal/modules/cjs/loader.js:590:37)
	at Module.load (internal/modules/cjs/loader.js:777:23)
	at Module._load (internal/modules/cjs/loader.js:693:12)
	at Module._load (electron/js2c/asar.js:717:26)
	at Function.Module._load (electron/js2c/asar.js:717:26)
	at Function.t._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:974:348)
	at Function.i._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:943:839)
	at Function.n._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:940:198)
	at Module.require (internal/modules/cjs/loader.js:820:19)
	at require (internal/modules/cjs/helpers.js:68:18)
	at Function.s [as __$__nodeRequire] (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:33:205)
	at h._loadCommonJSModule (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:945:34)
	at h._doActivateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:835:599)
	at h._activateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:834:692)
	at Object.actualActivateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:832:453)
	at h._activateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:601:405)
	at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:601:83
	at Array.map (<anonymous>)
	at h._activateExtensions (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:601:71)
	at h.activateByEvent (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:598:546)
	at h._activateByEvent (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:833:300)
	at h.$resolveAuthority (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:842:313)
	at processTicksAndRejections (internal/process/task_queues.js:85:5)
[2020-07-16 15:00:25.974] [exthost] [info] eager extensions activated
[2020-07-16 15:54:16.538] [exthost] [info] extension host started
[2020-07-16 15:54:16.547] [exthost] [info] ExtensionService#_doActivateExtension ms-vscode-remote.remote-wsl {"startup":false,"extensionId":{"value":"ms-vscode-remote.remote-wsl","_lower":"ms-vscode-remote.remote-wsl"},"activationEvent":"onResolveRemoteAuthority:wsl"}
[2020-07-16 15:54:16.547] [exthost] [info] ExtensionService#loadCommonJSModule file:///c:/Users/aavkoprivi/.vscode/extensions/ms-vscode-remote.remote-wsl-0.44.4/dist/extension
[2020-07-16 15:54:16.554] [exthost] [error] Activating extension ms-vscode-remote.remote-wsl failed due to an error:
[2020-07-16 15:54:16.554] [exthost] [error] TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type undefined
	at validateString (internal/validators.js:112:11)
	at Object.join (path.js:375:7)
	at Function.Module._nodeModulePaths (internal/modules/cjs/loader.js:590:37)
	at Module.load (internal/modules/cjs/loader.js:777:23)
	at Module._load (internal/modules/cjs/loader.js:693:12)
	at Module._load (electron/js2c/asar.js:717:26)
	at Function.Module._load (electron/js2c/asar.js:717:26)
	at Function.t._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:974:348)
	at Function.i._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:943:839)
	at Function.n._load (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:940:198)
	at Module.require (internal/modules/cjs/loader.js:820:19)
	at require (internal/modules/cjs/helpers.js:68:18)
	at Function.s [as __$__nodeRequire] (c:\Program Files\Microsoft VS Code\resources\app\out\vs\loader.js:33:205)
	at h._loadCommonJSModule (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:945:34)
	at h._doActivateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:835:599)
	at h._activateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:834:692)
	at Object.actualActivateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:832:453)
	at h._activateExtension (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:601:405)
	at c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:601:83
	at Array.map (<anonymous>)
	at h._activateExtensions (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:601:71)
	at h.activateByEvent (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:598:546)
	at h._activateByEvent (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:833:300)
	at h.$resolveAuthority (c:\Program Files\Microsoft VS Code\resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:842:313)
	at processTicksAndRejections (internal/process/task_queues.js:85:5)
[2020-07-16 15:54:16.873] [exthost] [info] eager extensions activated

Yeah. No idea without steps.
Duplicate of https://github.com/microsoft/vscode/issues/80971
@aeschli The stack trace is in the require call to load the wsl remote extension. At that time (when the resolver is loaded), the wsl remote extension is the only extension loaded in the extension host, so no other extension could be causing this.
My best guess is that @vkoprivica has some environmental variables set which completely mess up the code loading of nodejs. @vkoprivica Did you ever customize your environmental variables?


I have this problem

It is not seeing the weapons and ult orbs

when i press tab it's giving crash

heeey can you help me??

@therealpintoss Any news about this issue? I'm having the same problem.

no, same

@therealpintoss Does this happen only when you press Tab?


New unit tests

Travis stopped working for some reason, and MAI needs new tests anyway. Build this once the docs are all set up.

Completed with https://github.com/arosen93/mof-adsorbate-initializer/commit/bca1a9924004753840503b656a68f3c28140d32e


Add flags to strip symbols during compilation

You get a nice 7M savings when the binary is stripped of extra symbols.
╰ ls -lah ./src/go/src/github.com/kolide/fleet/build/fleet
-rwxr-xr-x 1 tlambiris users 23M Nov 19 20:06 ./src/go/src/github.com/kolide/fleet/build/fleet

╰ ls -lah ./src/go/src/github.com/kolide/fleet/build/fleet
-rwxr-xr-x 1 tlambiris users 16M Nov 19 20:09 ./src/go/src/github.com/kolide/fleet/build/fleet

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I'm going to close this, but happy to reopen if there's new activity.


Ability to build and run mac and ios apps on a NON mac machine

Describe the solution you'd like to see:

Ability to build and run mac and ios apps on a non mac machine
https://github.com/sickcodes/Docker-OSX works well on Local Linux, Github and Digital Ocean ( as it provides nested virtualisation)

You can follow instructions to build for macOS on other computers at https://developer.fyne.io/started/cross-compiling.
Also available is https://github.com/fyne-io/fyne-cross that manages all the development tools for you.
Be aware that Apple licensing does not allow you to build iOS apps on anything other than Apple Mac hardware.


Add Python3.7 to CI

@dainnilsson hi! can you please review this PR?

Hi. It doesn't look like the Travis build for this is passing: https://travis-ci.org/Yubico/python-fido2/builds/438250516

@dainnilsson fixed


Refreshing a context variable errors if the context is removed

Hi 👋 ,
I had a context test, which had one variable password. This context AND the variable were created from terraform.
Later on, I wanted to create the context outside of terraform. It ends up the state looking for a non-existant context_id (even if the name were the same).
In fact, I switched from a resource to a data because the context is finally created outside from terraform.
I had a weird error You don't have permission to list environment variables in this context, but the real underlying error was like if the context_id didn't exist anymore.
Can we make the state refreshing only rely on context name and not on somewhat id?
Workaround: I had to make a terraform state rm circleci_context_environment_variable.password because this variable state refresh failed before.

Your suggestion breaks with provider guidelines, IDs should be used wherever available over ambiguous identifiers like names. Terraform resources should not have implicit name matching behavior. Existing resources should be import-ed by ID as needed.
However, it does seem like there's a behavioral change needed here. If the parent context is gone, a variable should be removed from state entirely.

Couple of small issues were present leading to this bug, see #67.
As for the fact that the returned error is "you don't have permission" rather than "context not found," that's because Circle has mis-implemented this. Applications should generally return 404 when the user doesn't have access to a resource to avoid disclosing its existence. Instead Circle returns a 403, always. #67 adds that to the HTTP client so that 403 is treated as an expected error.


<EMAIL_ADDRESS>Add persist

close: #13635

Can anyone review this request?

@aliesbelik Hi, sorry to bother you. Is there any problem blocking merging it?

/verify


About "subjectively-inspired temporal pooling"?

@lidq92 Thanks for your sharing. The article says before and after frames are taken into account.（《Qality Assessment of In-the-Wild Videos》formula 7，8，9）But I find the code consider only one frame,relative_score[d][i] = self._sitp(q[i, :x_len[i].item()]).I can't find any code to store the before and after frames. Would you please explain it for me? Thank you very much!!

I may be understand the meaning of the code.


feat(Canvas): add support for displaying output in Jupyter Notebook

Giving your branch a spin now to see if I can find the issue you mentioned on discord.

Well I got it to work and it must be a TypeScript or Deno quirk. If you bind it in the constructor then the Deno kernel picks it up:
  constructor(width: number, height: number, gpu = false) {
    this[$display] = this[$display].bind(this);

Could you point me which one is not working here? Is it canvas.ts or svgcanvas.ts?

Could you point me which one is not working here? Is it canvas.ts or svgcanvas.ts?

@bartlomieju it's canvas.ts

Thanks, I'll try to take a look ASAP.

I just tried this and I got:

I think this is related to https://github.com/denoland/deno/issues/20528

So the underlying issue is that this error is raised:
TypeError: Cannot read properties of undefined (reading 'encode')\n    at [Jupyter.display] (file:///Users/ib/dev/skia_canvas/src/canvas.ts:215:38)\n    at <anonymous>:4:33

However I don't yet understand why that's the case. The transpiled output looks correct and AFAIK this should be the class intance in this case. I will consult with the team and get back to you.

The bug causing it to not render properly has been fixed: https://github.com/denoland/deno/pull/20789

I had to jump to https://github.com/denoland/deno/commit/cbddf5756e07fbbe10bd35d23bb9e9c0c685442a to make it work though because deno main can't load this module right now (#61).

Awesome fix @rgbkrk - I'll cut a release once that fix makes it to stable.

The fix for ffi is on main.

1.37.2 is out with the fix, feel free to ship 🚢

I've released 0.5.5:


GitHub OAuth compatibility

Is it possible to use Githb OAuth feature for with this?
Getting the following:
GET https://github.com/login/oauth/authorize/.well-known/openid-configuration net::ERR_FAILED 404

I haven't used OIDC with Github before, are you sure it support OIDC and not just OAuth?

Wikipedia says No OIDC for github:
https://en.wikipedia.org/wiki/List_of_OAuth_providers


Fix fixtures folder.

When you run the tests of this package directly all tests pass but when you run them from the script script/run-package-tests.js from Atom/Pulsar the tests fail. That is because the project folder is not set correctly when there are other tests running along with these ones. If you set the project folder manually before each test then the tests pass always.

This looks fantastic, but I'd like to go ahead and get our testing running on PR's before merging in if you don't mind.

@confused-Techie I tried to put the current version of the code in Atom to run the test and it looks like it won't run. In this commit the tests were changed to run in jasmine 3 which is not compatible with the version that comes with Atom. Should we revert that? ... since this is a core package it should support the same version as the rest of the editor.

YEAHHH, Atom uses a very old Jasmine version...

I vote for reverting, @fabianfiorotto

@confused-Techie it's actually not that simple. Atom does not depends on a Jasmine framework, it contains the source of one, with some slight modifications.
Changing this file means we get an updated Jasmine, but have to keep this modified file updated (more code to maintain). It also means we break all tests that we have today, without exception (hurray for backwards compatibility, it would be so wonderful if at least one JavaScript library could have it...)

@confused-Techie it's actually not that simple. Atom does not depends on a Jasmine version, it contains the source of one, with some slight modifications.
Changing this file means we get an updated Jasmine, but have to keep this modified file updated (more code to maintain). It also means we break all tests that we have today, without exception (hurray for backwards compatibility, it would be so wonderful if at least one JavaScript library could have it...)

My lord is that horrendous. Okay so then yeah we gotta step this one down. And that means in the future to update our testing framework it'd be literally easier to scrape all tests, and rewrite from scratch in a framework that makes sense.
In that case lets hope that theres no big issues we introduce using an older testing framework.
So in that case hopefully we can revert this repos existing tests to whatever they had before the updated the framework

So while we may not be able to test here, this PR is a bit old and looks like it has 2 approvals.
Just wanting to confirm that your approval is still accurate @mauricioszabo since I know I was the one saying it would be nice to test, and you had mentioned reverting the jasmine change.
Should we merge this and worry about reverting that change later on?

I missed this PR, sorry. Merging now :)


Selection shape is not rectangular when selecting over multiple lines of text

I'm using 0.10.7.  If I have a number of lines of text selected by click and dragging the mouse over the text I get the following selection:

This also happens if I use the keyboard to select across multiple lines.
However if I triple click on a single line of text or click and drag over all the text on a single line I get:

I'm not styling the selection path at all and this only occurs if I select multiple lines.
This ONLY occurs if I select text, if I select/drag at the end of a paragraph (and drag to the next paragraph) the first paragraph selection is a rectangle.  For example:

Any idea what's going wrong?

I recall long ago seeing something like this before and thought it had been fixed. I wonder if this a regression or something new ?
It looks like interparagraph spacing is messing up the selection path.  I'll have a look during the week .....

I've tried 0.10.5 and the problem is there too.  It's definitely related to the padding on the paragraph node.  If I don't set any padding (on the bottom) of the node then it draws a rectangle.  I think it's using the text size as the starting height of the selection box rather than the line size + padding.  In the examples I gave each line was a paragraph.
If I try selecting multiple lines within a paragraph then it draws rectangle, it's only on the final line of paragraph (when there's bottom padding) that the problem occurs.

Thanks for checking and the feedback. Can you provide the CSS you're using to set the inter-paragraph spacing as I'm not able to replicate the problem with my efforts. Even better would be a simple demo that show the problem. Thanks.

I'm using the css:
-fx-text-alignment: left;-fx-line-spacing: 0.0pt;-fx-padding: 0 3px 11.2pt 3px;
for the paragraph.
After doing some testing the culprit seems to be the combination of setting -fx-line-spacing AND -fx-padding.  Setting them individually without the other and things work fine.  The alignment doesn't matter.
Hope this helps, if you still can't reproduce it let me know and I'll try and create a minimum demo for the problem.

Sorry Gary, I've tried various ways of replicating the behavior without success ?  So I'll need the minimum demo from you.
Also having scanned through various sections of code, could you try:  -fx-line-spacing: 0.01; instead of 0.0 and see what happens.

When the line spacing is above 0 then the selection is a rectangle, when it is <= 0 then it has the weird shape.  Although even at <= 0 the intra-paragraph selection block is a rectangle.  It's only when you select some text on the last line of the paragraph and select part of another paragraph that it happens.
I'll try and get the demo together.

Just to add a bit more detail.  I dug into what shape the SelectionPath is drawing when the line-spacing is less than 0.  I did this to make sure it wasn't something I was doing that was causing it.
For the image below it drew the following box (via the drawing commands move to and line to), the first number is the X coord, the second is the Y coord:
MOVE: 0.0, 57.400001525878906
LINE: 1316.0, 57.400001525878906
LINE: 1316.0, 96.46666036315105
LINE: 0.0, 78.4000015258789
LINE: 0.0, 57.400001525878906

I believe the problem is in lines:
LINE: 1316.0, 96.46666036315105
LINE: 0.0, 78.4000015258789
here the line is dropping down to Y coord 96 but then a line is being drawn back to Y coord 78.  If I'm reading it right I think the second line should be drawing back to Y coord 96.

Sorry to spam, I haven't had chance to do the demo yet but looking at the ParagraphText code I think the issue may lie in the "getRangeShapeSafely(int, int)" method.  At line 382 it is using getHeight to get the bottom right location of the selection which is the reason why it's using the padding.  However at line 387 it gets the line spacing and applies that but only if the value is positive.
Anyway, just a thought.

So I think the solution is to add the following after line 382 in the same code block:
int bottomLeftIndex = bottomRightIndex + 1;
shape[bottomLeftIndex] = new LineTo(0.0, getHeight());

Would that mean that bottom line included the padding though?  But I think it's on the right track.
I've also got the minimum demo ready now, see below:
import javafx.scene.*;
import javafx.scene.layout.*;
import javafx.scene.control.*;
import javafx.stage.*;
import javafx.application.*;

import org.fxmisc.richtext.*;

public class SelectionTest extends Application
{

    public static void main (String[] args)
    {

        Application.launch (args);

    }

    @Override
    public void start (Stage stage)
    {

        String lorem = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque interdum sollicitudin dui gravida posuere. Vestibulum eros sem, tempor eu diam non, ultrices interdum nunc. Ut facilisis lobortis mi et euismod. Nullam convallis orci nec ornare hendrerit. Nunc a nibh turpis. Proin bibendum dignissim imperdiet. Mauris vitae tincidunt arcu. Donec euismod vitae nibh at vulputate.\n"
        + "Morbi vehicula pretium fermentum. Donec efficitur turpis vel sem placerat, in posuere erat aliquam. Praesent sodales blandit neque, in condimentum nisi vehicula sit amet. Quisque tincidunt quis nulla vel cursus. Nunc quis ex velit. Curabitur libero urna, cursus dignissim mollis eu, tincidunt eu purus. Nulla id ullamcorper ligula.\n"
        + "Donec at ante ut felis feugiat suscipit eget at metus.  Phasellus eget purus lobortis, sodales enim sit amet, fringilla tortor. Duis ac massa quis nisl convallis laoreet vitae quis lorem.\n"
        + "Etiam eu eros accumsan, rhoncus purus vel, dictum odio. Pellentesque velit nisl, interdum ac semper id, cursus sed augue. Curabitur velit sem, accumsan eu purus et, dapibus sagittis odio.\n"
        + "Integer dictum odio eget tellus tempus suscipit. Aliquam id nisl ut massa feugiat ullamcorper. Sed non finibus purus, nec aliquet mi. Vestibulum at ante turpis. Ut at metus euismod odio ultricies tristique at ut arcu. Fusce vestibulum tortor eros, sit amet elementum nunc consequat sit amet. Nullam scelerisque aliquam turpis, at ultricies odio tristique non. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia curae; Curabitur maximus sodales lectus. Nulla mauris sapien, congue vel felis ut, eleifend egestas lorem. Nulla vitae congue magna.\n"
        + "Etiam ut sapien auctor, cursus ex a, tincidunt lorem. Aliquam aliquam faucibus tortor, nec pretium lorem dapibus eu. Integer faucibus sem id lectus maximus pulvinar. Morbi ex neque, convallis id risus id, varius semper elit. Nunc dapibus semper erat, eget tristique risus posuere sed. Sed ornare tincidunt rhoncus. Cras odio metus, tristique vitae velit in, rhoncus euismod nisi. Nullam justo enim, elementum in mauris at, iaculis vehicula nulla.\n"
        + "Nullam rutrum, metus vitae lobortis elementum, risus augue convallis nisi, non vestibulum sem ipsum nec lacus. Morbi vel nisl vel augue pulvinar placerat. Fusce dignissim, odio eget sagittis molestie, turpis arcu fringilla purus, ullamcorper porttitor elit sapien quis enim. Integer neque metus, accumsan ut diam at, venenatis varius libero. Vivamus porttitor vehicula massa eu porta. Etiam a ipsum sit amet erat placerat dictum. Donec eget metus sed justo tincidunt egestas. Integer at erat elit. Nam ipsum turpis, gravida sit amet suscipit ac, porttitor vulputate nunc. Maecenas luctus rutrum ipsum non blandit.";

        InlineCssTextArea t = new InlineCssTextArea ();

        t.setParagraphInsertionStyle ("-fx-padding: 0 0 50px 0;-fx-line-spacing: -10px;");

        t.replaceText (0, 0, lorem);
        t.setPrefWidth (500);
        t.setPrefHeight (500);

        Scene sc = new Scene (t);
        stage.setScene (sc);
        stage.sizeToScene ();
        stage.show ();

        t.selectAll ();

    }

}

Great, thanks for that will submit PR to fix.


cross build two dotty versions

It has been kind of recommended to build for the last two versions of dotty. This PR adds M2 though we still need to solve some issues to get to publish for dotty

Thank you @cquiroz


Replace request with node-fetch

Background

After August 15 2021, Harvest's new infrastructure will return an error on GET requests with content in the BODY payload. Requests matching this pattern will receive an error 400.
What do I need to do before August 15?
Please review your usage of Harvest’s API and adjust all GET requests to send an empty BODY payload following the HTTP 1.1 spec. We strongly recommend doing this well before August 15, 2021 in order to avoid any issues.
If you have any questions on the upcoming change or the steps described here, please reply to this email and we’ll be happy to help.
Thank you for using Harvest!
Take care,
The Harvest Team

Overview
This PR is really quite large, but was elaborated under the (mistaken) belief that the upstream was no longer maintained. Here's the bones:

Add some basic linting guidelines (not enforced by test/travis/CI yet)
Retire istanbul (I'm sure there are better code-coverage options, but I didn't have time to research them
Replace lodash dependency with (smaller) lodash.pick
Remove lodash CamelCase dependency (rename api files)
Replace request with node-fetch for http client
Ensure localized http options (instead of persistent this.options)

User story
As a user of Harvest's API, I would like to use a modern, supported http client library so that I can continue using Harvest's API after August 15 (when they will summarily reject any GET or HEAD request that contains a body)

push


[DNM] limit lock cf's level to 3

this will trigger compaction more frequently, this is useful for lock cf.
@siddontang @BusyJay PTAL

LGTM
Please create an issue later.

LGTM, Please merge master.

This PR cause some compatible issues, close it.


Quickly survey other projects' guides and write first one for Helidon

ReSTful web service guide is in progress. Working with Romain on what parent pom structure we should use.

Merged.


spinnaker-infra-eks-nodes Cloudformation fails to deploy

parameter value ami-0e7ee8863c8536cce for parameter name NodeImageId does not exist.
Rollback requested by user.

The AMI is located in us-west-2, I'm deploying into ap-southeast-2 so I'll just find the equivalent - but would be good to reference in the docs that the default AMI is in us-west-2 and other regions needs to search for an ami name of amazon-eks-node-1.10-v20190220 in their chosen region.


Update app-insights-cloudservices.md

Added some detail for the requests, dependencies and exceptions & correlation for worker roles

Hi @SoubhagyaDash, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no contribution license agreement is required at this point. Real humans will now evaluate your PR.

TTYL, AZPRBOT;

Fix a couple of validation errors:
s=http://azure.microsoft.com/documentation/articles/(.*)/=%1.md=
s=] (=](=
Otherwise, this is fine. Please accept.

closing per Alan.


Property based testing

The tests for get_fluxsite_comparisons(), and get_fluxsite_tasks() should probably use a property based testing approach rather than testing results against hard coded values.
https://github.com/CABLE-LSM/benchcab/blob/e160bba8324042821d196efb759b534f611327f4/tests/test_fluxsite.py#L394
https://github.com/CABLE-LSM/benchcab/blob/e160bba8324042821d196efb759b534f611327f4/tests/test_fluxsite.py#L422
Properties we could test:

Test tasks are distinct
Test number of comparisons is correct ($N = C^{N_r}_2 N_f N_c$ where $C^n_k$ is the binomial coefficient, $N_r$ is the number of realisations, $N_f$ is the number of forcings and $N_c$ is the number of science configurations).
Test number of tasks is correct (express as a product of the number of branches, forcings, science configurations)

Putting it at low priority since there is no development of the fluxsite feature planned in the near future. The tests are working now and will not break unless the fluxsite feature is developed further.


[BUG]: Subtitle fontsize is not consistent in portrait mode

Version
6.4.2
What platforms are you having the problem on?
Android
System Version
Android 14
On what device are you experiencing the issue?
Real device
Architecture
Old architecture
What happened?
When I run video in portrait mode in fullscreen, the subtiles style is constant and does not change even after I apply subtitleStyle.

Reproduction
repository link
Reproduction
run the basic app from example in portrait mode and subtitle with default style will be seen where fontsize not consistent.

This issue is reproduced on the sample

We are also seeing this issue.

This is a regression coming from this change: https://github.com/TheWidlarzGroup/react-native-video/pull/3830

6.5.0 has been released


A bit of clean up in graph

Creation doesnt work yet. Just a bit of clean up before the C# conversion.

Runtime changes detected. pull request created. CI running:


Added Add, Subtract, and Difference methods

Refactored Prev and Next to use Add and Subtract respectively

Coverage increased (+0.1%) to 97.727% when pulling 931f03b803990e500143bd7ea721b6c43d986750 on xkizer:ZSB-463 into 6e4f36da80211eed10570b18331bed80e2826d49 on stoewer:master.


Incorrect array fill example

docs/v8-tips/inline-initialization.md
var array = []
for (var i = 0; i < 10; i++) array[0] |= i  // Oh no!

Should not there be array[i] |= 0 instead of repeated modifying of one first element? The same for next "correct" example.

I think you're right, can you create a PR of this?

I tried to avoid this part :)
Ok, I'll create soon.


segfault in grpc c++ server

it failed with the following errors:
E0429 13:24:22.785300033    1842 chttp2_transport.c:1327] ignoring out of order new stream request on server; last stream id=16777215, new stream id=60009136
E0429 13:24:22.785365059    1842 stream_map.c:74] assertion failed: count == 0 || keys[count - 1] < key

I'll take a look at the crash shortly, but I'm curious what kind of client
you're talking to? That looks like the client sent some very broken http2.
On Wed, Apr 29, 2015, 6:33 AM romange<EMAIL_ADDRESS>wrote:

it failed with the following errors:
E0429 13:24:22.785300033 1842 chttp2_transport.c:1327] ignoring out of
order new stream request on server; last stream id=16777215, new stream
id=60009136
E0429 13:24:22.785365059 1842 stream_map.c:74] assertion failed: count ==
0 || keys[count - 1] < key
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405.

It's a load test of grpc++ async interface using grpc++ client code :)))
I am just playing with grpc trying to understand if it's mature enough.
The client code is below.
struct MyContext {
  ServerRequest req, resp;
  ClientContext context;
  grpc::Status status;
  std::unique_ptr<::grpc::ClientAsyncResponseReader<::be::ServerRequest>> reader;
};

for (int i = 0;  i < FLAGS_num_requests; ++i) {
      std::unique_ptr<MyContext[]> context(new MyContext[FLAGS_num_bursts]);
      for (int j = 0; j < FLAGS_num_bursts; ++j) {
        MyContext& cur_context = context[j];

        chrono::system_clock::time_point deadline = chrono::system_clock::now() +
            chrono::milliseconds(FLAGS_deadline_ms);
        cur_context.context.set_deadline(deadline);
         cur_context.req = FillMySampleRequest();
        ++count;
        cur_context.reader = stub->AsyncCall(&cur_context.context, cur_context.req, &cq, nullptr);
        CHECK(cq.Next(&got_tag, &ok));

        cur_context.reader->Finish(&cur_context.resp, &cur_context.status, tag(j));
      }
      for (int j = 0; j < FLAGS_num_bursts; ++j) {
        CHECK(cq.Next(&got_tag, &ok));
        uint64 index = uint64(got_tag);
        const grpc::Status& status = context[index].status;
        RecordStatus(status);
      }
     } // for FLAGS_num_requests

I'll take a look then - any chance of sending a PR with your setup to save me reproing it?

Pr? Whats this?
On Apr 29, 2015 5:44 PM, "Craig Tiller"<EMAIL_ADDRESS>wrote:

I'll take a look then - any chance of sending a PR with your setup to save
me reproing it?
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97453010.

Pull request :)

Or - you know, I'd happily take a zip file too.

Looks like that log message was bogus... fixed it with #1406 - we'll try to get that integrated quickly.
Hopefully that will give enough information that I can stop scratching my head over what's going on here.

Can you re-run your test at least with latest code @romange?
The error message has been improved, which I hope gives me a hint as to what the problem is.

Hi Craig
I'm inbutc+3  thats why im unresponsive during your day.
Will check today...
On Apr 30, 2015 1:04 AM, "Craig Tiller"<EMAIL_ADDRESS>wrote:

Can you re-run your test at least with latest code @romange
https://github.com/romange?
The error message has been improved, which I hope gives me a hint as to
what the problem is.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97601452.

No worries. Look forward to hearing how it goes!
On Wed, Apr 29, 2015, 10:36 PM romange<EMAIL_ADDRESS>wrote:

Hi Craig
I'm inbutc+3 thats why im unresponsive during your day.
Will check today...
On Apr 30, 2015 1:04 AM, "Craig Tiller"<EMAIL_ADDRESS>wrote:

Can you re-run your test at least with latest code @romange
https://github.com/romange?
The error message has been improved, which I hope gives me a hint as to
what the problem is.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97601452.

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97667380.

Now it fails at the following staclktrace. Not sure how to compile grpc
with debug information to get more info..
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff46d2700 (LWP 1425)]
0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
(gdb) where
#0  0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
#1  0x00007ffff7bce4a1 in grpc::DeserializeProto(grpc_byte_buffer*,
google::protobuf::Message*) () from /usr/lib/libgrpc++_unsecure.so.0
#2  0x00007ffff7bcfb4d in grpc::Server::RunRpc() () from
/usr/lib/libgrpc++_unsecure.so.0
#3  0x00007ffff7bd1cb6 in grpc::ThreadPool::ThreadFunc() () from
/usr/lib/libgrpc++_unsecure.so.0
#4  0x00007ffff6809bf0 in ?? () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007ffff6eab182 in start_thread (arg=0x7ffff46d2700) at
pthread_create.c:312
#6  0x00007ffff627747d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb) f 1
#1  0x00007ffff7bce4a1 in grpc::DeserializeProto(grpc_byte_buffer*,
google::protobuf::Message*) () from /usr/lib/libgrpc++_unsecure.so.0
On Thu, Apr 30, 2015 at 8:51 AM, Craig Tiller<EMAIL_ADDRESS>wrote:

No worries. Look forward to hearing how it goes!
On Wed, Apr 29, 2015, 10:36 PM romange<EMAIL_ADDRESS>wrote:

Hi Craig
I'm inbutc+3 thats why im unresponsive during your day.
Will check today...
On Apr 30, 2015 1:04 AM, "Craig Tiller"<EMAIL_ADDRESS>wrote:

Can you re-run your test at least with latest code @romange
https://github.com/romange?
The error message has been improved, which I hope gives me a hint as to
what the problem is.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97601452.

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97667380.

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97669551.

--
Best regards,
Roman

here is another one. I know how to reproduce it now. All I need to do is it
to run one rpc client to my server and send the load test traffic
And then to run another one from other machine and connect it to the same
server.
(gdb) r
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /home/ubuntu/grpc_server --port 50001
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

[Switching to Thread 0x7ffff46d2700 (LWP 1434)]
0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
(gdb) where
#0  0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
#1  0x00007ffff7bce4a1 in grpc::DeserializeProto(grpc_byte_buffer*,
google::protobuf::Message*) () from /usr/lib/libgrpc++_unsecure.so.0
#2  0x00007ffff7bcfb4d in grpc::Server::RunRpc() () from
/usr/lib/libgrpc++_unsecure.so.0
#3  0x00007ffff7bd1cb6 in grpc::ThreadPool::ThreadFunc() () from
/usr/lib/libgrpc++_unsecure.so.0
#4  0x00007ffff6809bf0 in ?? () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007ffff6eab182 in start_thread (arg=0x7ffff46d2700) at
pthread_create.c:312
#6  0x00007ffff627747d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:111
On Thu, Apr 30, 2015 at 11:01 AM, Roman Gershman<EMAIL_ADDRESS>wrote:

Now it fails at the following staclktrace. Not sure how to compile grpc
with debug information to get more info..
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff46d2700 (LWP 1425)]
0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
(gdb) where
#0  0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
#1  0x00007ffff7bce4a1 in grpc::DeserializeProto(grpc_byte_buffer*,
google::protobuf::Message*) () from /usr/lib/libgrpc++_unsecure.so.0
#2  0x00007ffff7bcfb4d in grpc::Server::RunRpc() () from
/usr/lib/libgrpc++_unsecure.so.0
#3  0x00007ffff7bd1cb6 in grpc::ThreadPool::ThreadFunc() () from
/usr/lib/libgrpc++_unsecure.so.0
#4  0x00007ffff6809bf0 in ?? () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007ffff6eab182 in start_thread (arg=0x7ffff46d2700) at
pthread_create.c:312
#6  0x00007ffff627747d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb) f 1
#1  0x00007ffff7bce4a1 in grpc::DeserializeProto(grpc_byte_buffer*,
google::protobuf::Message*) () from /usr/lib/libgrpc++_unsecure.so.0
On Thu, Apr 30, 2015 at 8:51 AM, Craig Tiller<EMAIL_ADDRESS>wrote:

No worries. Look forward to hearing how it goes!
On Wed, Apr 29, 2015, 10:36 PM romange<EMAIL_ADDRESS>wrote:

Hi Craig
I'm inbutc+3 thats why im unresponsive during your day.
Will check today...
On Apr 30, 2015 1:04 AM, "Craig Tiller"<EMAIL_ADDRESS>wrote:

Can you re-run your test at least with latest code @romange
https://github.com/romange?
The error message has been improved, which I hope gives me a hint as
to
what the problem is.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97601452.

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97667380.

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97669551.

--
Best regards,
Roman

--
Best regards,
Roman

the sample code is located here:
https://gist.github.com/romange/2bd5feaf4e9f61eb5e51
On Thu, Apr 30, 2015 at 11:05 AM, Roman Gershman<EMAIL_ADDRESS>wrote:

here is another one. I know how to reproduce it now. All I need to do is
it to run one rpc client to my server and send the load test traffic
And then to run another one from other machine and connect it to the same
server.
(gdb) r
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /home/ubuntu/grpc_server --port 50001
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

[Switching to Thread 0x7ffff46d2700 (LWP 1434)]
0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
(gdb) where
#0  0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
#1  0x00007ffff7bce4a1 in grpc::DeserializeProto(grpc_byte_buffer*,
google::protobuf::Message*) () from /usr/lib/libgrpc++_unsecure.so.0
#2  0x00007ffff7bcfb4d in grpc::Server::RunRpc() () from
/usr/lib/libgrpc++_unsecure.so.0
#3  0x00007ffff7bd1cb6 in grpc::ThreadPool::ThreadFunc() () from
/usr/lib/libgrpc++_unsecure.so.0
#4  0x00007ffff6809bf0 in ?? () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007ffff6eab182 in start_thread (arg=0x7ffff46d2700) at
pthread_create.c:312
#6  0x00007ffff627747d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:111
On Thu, Apr 30, 2015 at 11:01 AM, Roman Gershman<EMAIL_ADDRESS>wrote:

Now it fails at the following staclktrace. Not sure how to compile grpc
with debug information to get more info..
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff46d2700 (LWP 1425)]
0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
(gdb) where
#0  0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
#1  0x00007ffff7bce4a1 in grpc::DeserializeProto(grpc_byte_buffer*,
google::protobuf::Message*) () from /usr/lib/libgrpc++_unsecure.so.0
#2  0x00007ffff7bcfb4d in grpc::Server::RunRpc() () from
/usr/lib/libgrpc++_unsecure.so.0
#3  0x00007ffff7bd1cb6 in grpc::ThreadPool::ThreadFunc() () from
/usr/lib/libgrpc++_unsecure.so.0
#4  0x00007ffff6809bf0 in ?? () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007ffff6eab182 in start_thread (arg=0x7ffff46d2700) at
pthread_create.c:312
#6  0x00007ffff627747d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb) f 1
#1  0x00007ffff7bce4a1 in grpc::DeserializeProto(grpc_byte_buffer*,
google::protobuf::Message*) () from /usr/lib/libgrpc++_unsecure.so.0
On Thu, Apr 30, 2015 at 8:51 AM, Craig Tiller<EMAIL_ADDRESS>wrote:

No worries. Look forward to hearing how it goes!
On Wed, Apr 29, 2015, 10:36 PM romange<EMAIL_ADDRESS>wrote:

Hi Craig
I'm inbutc+3 thats why im unresponsive during your day.
Will check today...
On Apr 30, 2015 1:04 AM, "Craig Tiller"<EMAIL_ADDRESS>wrote:

Can you re-run your test at least with latest code @romange
https://github.com/romange?
The error message has been improved, which I hope gives me a hint as
to
what the problem is.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97601452.

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97667380.

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97669551.

--
Best regards,
Roman

--
Best regards,
Roman

--
Best regards,
Roman

ok, I succeeded to deploy libraries with debug symbols.
here is the updated stacktrace (@git
commit ceb20ae45c0deaf10b386baf47f19e3c17149589)
#0  grpc_byte_buffer_reader_create (buffer=0x0) at
src/core/surface/byte_buffer_reader.c:46
#1  0x00007ffff7bcec81 in GrpcBufferReader (buffer=,
this=0x7ffff2ecfb20) at src/cpp/proto/proto_utils.cc:103
#2  grpc::DeserializeProto (buffer=, msg=msg@entry=0xfcebe0)
at src/cpp/proto/proto_utils.cc:162
#3  0x00007ffff7bd03ad in Run (this=0x7ffff2ecfcc0) at
src/cpp/server/server.cc:129
#4  grpc::Server::RunRpc (this=0xfe20b0) at src/cpp/server/server.cc:432
#5  0x00007ffff7bd2526 in operator() (this=0x7ffff2ecfe10) at
/usr/include/c++/4.8/functional:2464
#6  grpc::ThreadPool::ThreadFunc (this=0x1050000) at
src/cpp/server/thread_pool.cc:54
#7  0x00007ffff680abf0 in ?? () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#8  0x00007ffff6eac182 in start_thread (arg=0x7ffff2ed0700) at
pthread_create.c:312
#9  0x00007ffff627847d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:111
have fun :)
On Thu, Apr 30, 2015 at 11:47 AM, Roman Gershman<EMAIL_ADDRESS>wrote:

the sample code is located here:
https://gist.github.com/romange/2bd5feaf4e9f61eb5e51
On Thu, Apr 30, 2015 at 11:05 AM, Roman Gershman<EMAIL_ADDRESS>wrote:

here is another one. I know how to reproduce it now. All I need to do is
it to run one rpc client to my server and send the load test traffic
And then to run another one from other machine and connect it to the same
server.
(gdb) r
The program being debugged has been started already.
Start it from the beginning? (y or n) y
Starting program: /home/ubuntu/grpc_server --port 50001
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

[Switching to Thread 0x7ffff46d2700 (LWP 1434)]
0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
(gdb) where
#0  0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
#1  0x00007ffff7bce4a1 in grpc::DeserializeProto(grpc_byte_buffer*,
google::protobuf::Message*) () from /usr/lib/libgrpc++_unsecure.so.0
#2  0x00007ffff7bcfb4d in grpc::Server::RunRpc() () from
/usr/lib/libgrpc++_unsecure.so.0
#3  0x00007ffff7bd1cb6 in grpc::ThreadPool::ThreadFunc() () from
/usr/lib/libgrpc++_unsecure.so.0
#4  0x00007ffff6809bf0 in ?? () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007ffff6eab182 in start_thread (arg=0x7ffff46d2700) at
pthread_create.c:312
#6  0x00007ffff627747d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:111
On Thu, Apr 30, 2015 at 11:01 AM, Roman Gershman<EMAIL_ADDRESS>wrote:

Now it fails at the following staclktrace. Not sure how to compile grpc
with debug information to get more info..
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffff46d2700 (LWP 1425)]
0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
(gdb) where
#0  0x00007ffff799714e in grpc_byte_buffer_reader_create () from
/usr/lib/libgrpc_unsecure.so.0
#1  0x00007ffff7bce4a1 in grpc::DeserializeProto(grpc_byte_buffer*,
google::protobuf::Message*) () from /usr/lib/libgrpc++_unsecure.so.0
#2  0x00007ffff7bcfb4d in grpc::Server::RunRpc() () from
/usr/lib/libgrpc++_unsecure.so.0
#3  0x00007ffff7bd1cb6 in grpc::ThreadPool::ThreadFunc() () from
/usr/lib/libgrpc++_unsecure.so.0
#4  0x00007ffff6809bf0 in ?? () from
/usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007ffff6eab182 in start_thread (arg=0x7ffff46d2700) at
pthread_create.c:312
#6  0x00007ffff627747d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb) f 1
#1  0x00007ffff7bce4a1 in grpc::DeserializeProto(grpc_byte_buffer*,
google::protobuf::Message*) () from /usr/lib/libgrpc++_unsecure.so.0
On Thu, Apr 30, 2015 at 8:51 AM, Craig Tiller<EMAIL_ADDRESS>wrote:

No worries. Look forward to hearing how it goes!
On Wed, Apr 29, 2015, 10:36 PM romange<EMAIL_ADDRESS>wrote:

Hi Craig
I'm inbutc+3 thats why im unresponsive during your day.
Will check today...
On Apr 30, 2015 1:04 AM, "Craig Tiller"<EMAIL_ADDRESS>wrote:

Can you re-run your test at least with latest code @romange
https://github.com/romange?
The error message has been improved, which I hope gives me a hint
as to
what the problem is.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97601452.

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97667380.

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-97669551.

--
Best regards,
Roman

--
Best regards,
Roman

--
Best regards,
Roman

--
Best regards,
Roman

Interesting. after approximately 12 minutes of high load it crashed again with the following errors.
ubuntu@ip-10-0-2-16:~> E0503 09:30:48.353769674    1869 chttp2_transport.c:1398] ignoring out of order new stream request on server; last stream id=16777215, new stream id=1
E0503 09:30:48.353829023    1869 stream_map.c:74] assertion failed: count == 0 || keys[count - 1] < key

You have 24bit overflow in that id.

I can't think where... This'll be fun.
On Sun, May 3, 2015, 2:46 AM romange<EMAIL_ADDRESS>wrote:

You have 24bit overflow in that id.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-98460864.

It looks as if i am literally the first one who tried to use grpc :D
On May 3, 2015 5:36 PM, "Craig Tiller"<EMAIL_ADDRESS>wrote:

I can't think where... This'll be fun.
On Sun, May 3, 2015, 2:46 AM romange<EMAIL_ADDRESS>wrote:

You have 24bit overflow in that id.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-98460864.

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-98488530.

Can you share your test with us? Might save some turnaround time Monday. I'd really like this failure to be not there.

Sure. I've sent you a gist couple of days ago. Did you see it?
On May 3, 2015 6:28 PM, "Craig Tiller"<EMAIL_ADDRESS>wrote:

Can you share your test with us? Might save some turnaround time Monday.
I'd really like this failure to be not there.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-98495419.

I guess I missed it
On Sun, May 3, 2015, 8:35 AM romange<EMAIL_ADDRESS>wrote:

Sure. I've sent you a gist couple of days ago. Did you see it?
On May 3, 2015 6:28 PM, "Craig Tiller"<EMAIL_ADDRESS>wrote:

Can you share your test with us? Might save some turnaround time Monday.
I'd really like this failure to be not there.
—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-98495419.

—
Reply to this email directly or view it on GitHub
https://github.com/grpc/grpc/issues/1405#issuecomment-98496018.

here it is:
https://gist.github.com/romange/2bd5feaf4e9f61eb5e51

I think this should be resolved at this point. Can you confirm romange?

LGTM


New output items appended using the new API does not update the Notebook Document

Version: 1.54.0-insider
Commit: 6ac9a3ecb3698e82bf901f11bbb5940f6bc3c197
Date: 2021-02-12T05:12:31.721Z
Electron: 11.2.3
OS: Darwin x64 20.3.0

Steps to Reproduce:

Use the new API and update an existing output by appending to it as follows:

    edit.appendNotebookCellOutputItems(
        this.editor.document.uri,
        this.cell.index,
        existing.id,
        [.. new items .. ]
    );

THis works as expected, the UI is updated with the new output.
However when inspecting the Notebook Cells output (API), the new output item is not available.
NotebookDocument.cells[...].outputs[0].outputs <- this array doesn't get updated, only the UI gets updated.
I.e. it looks like VSCode is only updating the UI and not the underlying Notebook Cell output objects.

Unfortunately I cannot provide a sample code as this is still a WIP (we're updating our code to use the latest notebook API, its still only a change I have locally).
Oh yes, we need this information so that we can take the notebook and persist it to a file.
@jrieken @rebornix /cc

Does this issue occur when all extensions are disabled?: N/A

However when inspecting the Notebook Cells output (API), the new output item is not available.
NotebookDocument.cells[...].outputs[0].outputs <- this array doesn't get updated, only the UI gets updated.

Do have a full code sample for that?

this is fixed via https://github.com/microsoft/vscode/issues/116711 @jrieken right?

this is fixed via #116711 @jrieken right?

I am pretty sure that's unrelated

Do have a full code sample for that?

Again, the UI is updated, but looking at the cells.outputs.outputs, we only have the first entry in there.
Here's the code where we update existing output
https://github.com/microsoft/vscode-jupyter/blob/4f7f1d5641b8fc766c968d881ea8e1dfc91c5118/src/client/datascience/jupyter/kernels/cellExecution.ts#L663
Here are the tests for this scenario https://github.com/microsoft/vscode-jupyter/blob/301c4a95460e46f808bfbf7b296e6ab9542affd3/src/test/datascience/notebook/executionService.vscode.test.ts#L351


Could Not Select Multi Images

Current only one image can be selected and display

Not sure what is the problem


Save Commitment after CheckMutation

In UpdateEntry, we're currently saving the commitment after we verify the request validity but before we verify the mutation. We might want to save it after both verification operations pass.
@gdbelvin what do you think?

Sounds good

Now that Key Transparency is storing commitments as mapleaf.ExtraData, this is no longer an issue.


Azure App Configuration Push Task@6: Prefix not appended to Key value

With version 6 of the AzureAppConfigurationPush task, we no longer see the supplied prefix values being appended to the keys in our configuration. Version 3 works without issue in that our prefixes appear on the keys. We do see the ".appconfig.featureflag" appear on both versions but I am unsure if that is due to us providing that value in the prefix or if azure is managing that regardless. I have not tested versions between. Our prefix value does have a colon : in it, if that matters.
Our working version 3 code:
- task: AzureAppConfigurationPush@3
              displayName: "some display name"
              inputs:
                azureSubscription: ${{ parameters.azureSubscription }}
                AppConfigurationEndpoint: ${{ parameters.appConfigurationEndpoint }}
                ConfigurationFile: "${{ configurationFile }}"
                Separator: ';'
                Depth: ${{ parameters.depth }}
                Prefix: ".appconfig.featureflag/${{ somePrefixValueWith:ColonInIt }}"
                Label: ${{ parameters.label }}
                ContentType: "application/vnd.microsoft.appconfig.ff+json;charset=utf-8"
                Strict: ${{ parameters.strict }}

Our version 6 code:
- task: AzureAppConfigurationPush@6
              displayName: "some display name"
              inputs:
                azureSubscription: ${{ parameters.azureSubscription }}
                AppConfigurationEndpoint: ${{ parameters.appConfigurationEndpoint }}
                ConfigurationFile: "${{ configurationFile }}"
                Separator: ';'
                Depth: ${{ parameters.depth }}
                Prefix: ".appconfig.featureflag/${{ somePrefixValueWith:ColonInIt }}"
                Label: ${{ parameters.label }}
                ContentType: "application/vnd.microsoft.appconfig.ff+json;charset=utf-8"
                Strict: ${{ parameters.strict }}
                ImportMode: ${{ parameters.import_mode }}
                DryRun: ${{ parameters.dry_run }}
                Tags: ${{ parameters.tags }}

Our team requires the use of the prefix, so we will stay with version 3 for the immediate time being, but we would appreciate any insight that can be provided.

Hello @j-noel-b , to make sure I understand, with the Azure App Configuration Push@6, you are unable to add the prefix ".appconfig.featureflag/someprefix"  when pushing feature flags ?
This is cause Keys cannot start with the reserved prefix for feature flags. The update was introduced from version 5.

Hello @j-noel-b , to make sure I understand, with the Azure App Configuration Push@6, you are unable to add the prefix ".appconfig.featureflag/someprefix" when pushing feature flags ? If so this is cause keys cannot start with the reserved prefix(".appconfig.featureflag/") for feature flags. The update was introduced from version 5.

Sorry @MaryanneNjeri the copy-paste from v3 got away from me writing this ticket.
Ultimately, we want to send a prefix value with a colon in it. Such as Our:Prefix
However, even sending a basic text block produces no prefix that I can see in our feature manager.
Our feature json:
{
"FeatureManagement": {
"Feature1": false,
"Feature2": true
}
}
Our task call:
- task: AzureAppConfigurationPush@6
              displayName: "some display name"
              inputs:
                azureSubscription: ${{ parameters.azureSubscription }}
                AppConfigurationEndpoint: ${{ parameters.appConfigurationEndpoint }}
                ConfigurationFile: "${{ configurationFile }}"
                Separator: ';'
                Depth: ${{ parameters.depth }}
                Prefix: "OurPrefix"
                Label: ${{ parameters.label }}
                ContentType: "application/vnd.microsoft.appconfig.ff+json;charset=utf-8"
                Strict: ${{ parameters.strict }}
                ImportMode: ${{ parameters.import_mode }}
                DryRun: ${{ parameters.dry_run }}
                Tags: ${{ parameters.tags }}

The keys we end up with:
.appconfig.featureflag/Feature1
.appconfig.featureflag/Feature2

Hello @j-noel-b , to make sure I understand, with the Azure App Configuration Push@6, you are unable to add the prefix ".appconfig.featureflag/someprefix" when pushing feature flags ? If so this is cause keys cannot start with the reserved prefix(".appconfig.featureflag/") for feature flags. The update was introduced from version 5.

Sorry @MaryanneNjeri - the copy-paste from v3 got away from me in writing this ticket. I sincerely apologize for the confusion in the description.
Here is our feature json:
{
"FeatureManagement": {
"Feature1": false,
"Feature2": true
}
}
here is our v6 task:
- task: AzureAppConfigurationPush@6
              displayName: "some display name"
              inputs:
                azureSubscription: ${{ parameters.azureSubscription }}
                AppConfigurationEndpoint: ${{ parameters.appConfigurationEndpoint }}
                ConfigurationFile: "${{ configurationFile }}"
                Separator: ';'
                Depth: ${{ parameters.depth }}
                Prefix: "OurPrefix"
                Label: ${{ parameters.label }}
                ContentType: "application/vnd.microsoft.appconfig.ff+json;charset=utf-8"
                Strict: ${{ parameters.strict }}
                ImportMode: ${{ parameters.import_mode }}
                DryRun: ${{ parameters.dry_run }}
                Tags: ${{ parameters.tags }}

And here are the keys I am seeing in our feature manager:
.appconfig.featureflag/Feature1
.appconfig.featureflag/Feature2

Whereas I would expect to see:
.appconfig.featureflag/OurPrefixFeature1
.appconfig.featureflag/OurPrefixFeature2

Ultimately, we would like a colon in our prefix value such as Our:Prefix but I can't seem to get the basic text of OurPrefix to append.

@j-noel-b I see, seems there was a regression from version 5 of not appending prefixes for feature flags. We can look into maybe appending prefixes for feature flags.

@MaryanneNjeri - thank you so much for the confirmation - much appreciated.

@j-noel-b @MaryanneNjeri
Can i ask im having a nightmare of a time deploying the configuration file to the app config do you have an example of what your file that worked prior to this change looked like.
You have no idea how much of a saviour you would be if you could.
or if anyone else can as nothing ive attempted in the past five days seems to work....

@CMarshall92Shawbrook to make sure I provide a relevant example, I'd like to know what content profile are you using ? ["appconfig/default" or "appconfig/kvset"] to import the settings from the config file.

Don't know what I'm doing wrong but I need them to appear under the feature manager
config.json
config in my yaml
{   "EDRCodes":{     "Codes":["D041"]   },   "FCReasonCodes":{     "ReasonCodes":["F398"]},   } }
task in my yaml
`

${{ if ne(parameters.FEATURE_FLAG_CONFIG.CONFIG_FILE, '') }}:

task: AzureAppConfigurationPush@6
displayName: 'Deploy App Configuration Feature Flags To ${{ parameters.RESOURCE_NAME }}'
inputs:
FileContentProfile: "appconfig/default"
azureSubscription: '$(Service_Connection)'
AppConfigurationEndpoint: '$(RESOURCE_URL)'
ConfigurationFile: ${{ coalesce(parameters.FEATURE_FLAG_CONFIG.CONFIG_FILE, '') }}
Strict: ${{ coalesce(parameters.FEATURE_FLAG_CONFIG.STRICT, true) }}
ImportMode: ${{ coalesce(parameters.FEATURE_FLAG_CONFIG.IMPORT_MODE, 'All') }}
Separator: ':'
`

So I tried the appconfig/kvset example and it worked but went into the configuration explorer and nothing appeared under the feature manager any ideas why this is the case?
{
  "items": [
    {
      "key": ".appconfig.featureflag/Beta",
      "value": "{\"id\":\"Beta\",\"description\":\"Beta feature\",\"enabled\":true,\"conditions\":{\"client_filters\":[]}}",
      "label": "dev",
      "content_type": "application/vnd.microsoft.appconfig.ff+json;charset=utf-8",
      "tags": {}
    }
  ]
}

@CMarshall92Shawbrook seems you are trying to import feature flags, with the appconfig/default content profile  feature flag import requires adherence to feature-management schema.  Some more examples can be found here

So I tried the appconfig/kvset example and it worked but went into the configuration explorer and nothing appeared under the feature manager any ideas why this is the case?

In your configuration explorer under Manage view > Settings ensure the option to "Include feature flags in the configuration explorer" is enabled

Please let me know if this helps

Can confirm that worked apologies for derailing this issue just thought it may have been related hopefully this will help out people in the future anyways. Is this 'Include feature flags in configuration explorer' mentioned in the docs if not might be worth adding as im sure i never once came across that

Somehow missed that thanks, side note and last question is there a way to include the labels and descriptions in that schema
{
  "FeatureManagement": {
    "FlagOne": {
      "Properties": {
        "Label": "Test Label",
        "Description": "Some Description"
      },
      "Label": "Test Label",
      "Description": "Some Description"
      "EnabledFor": [
        { "Name": "AlwaysOn", "Label": "Test Label", "Description": "Test Description" }
      ]
    },
  }
}

as none of the options above seemed to allow me to add a description or label


Remove linker hacks and add test coverage for musl linking.

Redo of https://github.com/google/iree/pull/7512 now that https://github.com/google/iree/pull/7721 set up linking the musl builtins on the system linker path too.
I also removed the RiscvLinkerTool now that the embedded linker is used by default. The system linkers now mainly exist for platform-specific file formats, linker options, or debug information, and the RiscvLinkerTool wasn't providing much benefit.
Relates to https://github.com/google/iree/issues/4717

PTAL


Added Github Link to right hand side of nav bar

Nothing major here, just added Github link to nav bar


ADD edge to compatible browsers

The new Edge works just as fine as Firefox and Chrome.

👍
On Mon, Feb 19, 2024 at 7:14 PM John McCann Cunniff Jr <
@.***> wrote:

Merged #471 https://github.com/AnubisLMS/Anubis/pull/471 into main.
—
Reply to this email directly, view it on GitHub
https://github.com/AnubisLMS/Anubis/pull/471#event-11855251878, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMEVVGHV5GIK43JDYT244LYUPTH7AVCNFSM6AAAAABDNPSN7GVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHA2TKMRVGE4DOOA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


mldg reuse method from trainerbasic

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5b59ccc) 95.27% compared to head (dd51a01) 95.27%.
 Consider uploading reports for the commit 4ceec35 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
- Coverage   95.27%   95.27%   -0.01%
==========================================
  Files         128      128
  Lines        4824     4823       -1
==========================================
- Hits         4596     4595       -1
  Misses        228      228

Flag
Coverage Δ

unittests
95.27% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat: nodeclaim.spec.minimumPriceImprovementPercent

Fixes #1440
Implementation component of #1433.
Description
This PR adds a configurable MinimumPriceImprovementPercent to the NodeClaim spec. This allows users control over how large of a cost improvement should be required for consolidation to disrupt pods operating on a node to replace it with a cheaper alternative.
How was this change tested?
TBD. This PR is currently a draft for implementation discussion.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

4 of 11 (36.36%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 78.069%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/disruption/consolidation.go
3
6
50.0%

pkg/apis/v1/zz_generated.deepcopy.go
1
5
20.0%

Totals

Change from base Build<PHONE_NUMBER>0:
-0.04%

Covered Lines:
8832

Relevant Lines:
11313

💛  - Coveralls


Large request post data causes Bugsnag_Client::notify() to fail

Background:

My Application imports emails sent to it by Mandrill.
The emails contain a large encoded excel spreadsheet.
Stupidly, I wasn't using any sort of queuing system, so Mandrill hit my URL webhook end point, and then the application synchronously tried to import from the spreadsheet, which can take a long time.

Every time that the email was attempted to be imported, the max_execution_time was being hit, causing an PHP Fatal error:  Maximum execution time of 60 seconds exceeded error. This has been happening for a couple of weeks, and none of these errors have appeared on my Bugsnag account.
After some debugging, I've worked out that the POST data in the original request by Mandrill is larger than the Bugsnag POST data limit, so when Bugsnag tries to notify about the Maximum execution time of 60 seconds exceeded error I get a 400 (bad request) response, and therefore the error is never logged. The docs state that a 400 bad request indicates that the payload was too large.
You can see here that the Bugsnag library never considers the size of the $_POST variable before adding it to the $requestData.
Do you think it would be sensible to check the size of the post data just before sending the curl request. Then, if the size is larger than the Bugsnag post data limit (which isn't mentioned in the docs so I'm not sure what that is), the POST data (or params to use the term actually used in $requestData) would be truncated sufficiently so that the POST data falls below the Bugsnag limit. Alternatively, the POST data could be excluded all together. Ultimately, given that Bugsnag have set a POST data limit, to me it makes sense to make sure that the Bugsnag library never tries to send a request with POST data larger than that limit.
As I was relying on Bugsnag to notify me of any errors, I was not made aware the imports were failing until a couple of weeks later when the customer alerted me.
(For the record, I'm in the process of implementing a queuing system to handle this, so the original request from Mandrill with the massive post data should very quickly be handled and a job added to the queue. That said, if some other unrelated error occurs during this request, once again that error would never reach Bugsnag).

Thank you for the thorough report, @philbates35.

Do you think it would be sensible to check the size of the post data just before sending the curl request.

Definitely. There are two fixes which would significantly improve usage here, the first is to add the actual payload size limit to the documentation (which I'm fixing now) and the second is to truncate the payloads to that size.
This behavior was recently implemented for other notifier libraries, notably Ruby (bugsnag/bugsnag-ruby#288, bugsnag/bugsnag-ruby#290) and Java (bugsnag/bugsnag-java#35). The general strategy is to check the payload size, trim long strings, and then if needed, truncate long arrays (which tend to be stacktraces).
The PHP implementation should do something similar to the other notifiers, as well as exposing the maximum payload size, if you or other users want to implement payload truncation in the before notify callback in a way which makes more sense for your reports.
I'll work on this after some documentation updates, unless someone beats me to it. In the meantime, a payload under 1Mb should be accepted.

The limit currently stands at 512k. I have now fixed this. What we do is break up batch requests if they're too large, and as a last resort, strip out the meta data too.

This fix will ship with v1.9.0.


Add exception wrapper functions for the ndjson read and write functions

Functions are adapted from the existing functions for normal json.
Added const in some existing functions.
resolves #488

Sweet, this looks good!


NUT-08: mint fee return any overpaid amount

Change NUT08 to reflect that should return any over paid amount on a melt even if it is greater then the fee_reserve this avoids wallets having to swap before a melt to get the correct amount.

[ ] Nutshell
[x] CDK
[ ] Nutmix
[ ] gonuts
[ ] ...

Just one thing to consider: This is changing the existing behavior of a mint. So I think it would be a good idea to signal this change to the wallet by adding a flag to the info-endpoint like supports_overpaying: true or something like that. So the wallet knows exactly how the mint will react.
Otherwise it will be hard for a wallet to figure out what the current behavior of the mint is. The mint is signaling that it supports NUT-08 but not how it will treat an overpayment.

Just one thing to consider: This is changing the existing behavior of a mint.

I don't think is actually changing the behavior of the mint and this is how nutshell implements it already @callebtc could you confirm?


www/nginx: quick fix for trusted CAs pem

Hi. just quick fix for troubles with trust_upstream_*.pem files after update to 1.20 with upstream tls verify enabled and trusted CAs selected

Had come up with exactly the same solution before finding this PR. Can confirm that it fixes the problem.

Had come up with exactly the same solution before finding this PR. Can confirm that it fixes the problem.

@fabianfrz
thanks for watching this!
may I add https://github.com/opnsense/plugins/pull/1991 to this PR? a working SNI directives can be critical for upstream verification to work. so upstream can choose the right cert on request from nginx

@fabianfrz
thanks for watching this!
may I add https://github.com/opnsense/plugins/pull/1991 to this PR? a working SNI directives can be critical for upstream verification to work. so upstream can choose the right cert on request from nginx

Does this fix the trust_upstream_* files not being put in place correctly?

root@gw:~ # ls -l /usr/local/etc/nginx/key/trust_upstream*
-rw-------  1 root  wheel  3 Jan 23 22:07 /usr/local/etc/nginx/key/trust_upstream_5037b17e-fc0d-452a-9b59-da40823f7550.pem
-rw-------  1 root  wheel  3 Jan 23 21:53 /usr/local/etc/nginx/key/trust_upstream_acc62566-fd6f-4488-8b88-a7022399cb56.pem
-rw-------  1 root  wheel  3 Jan 23 22:05 /usr/local/etc/nginx/key/trust_upstream_d9229681-d046-4320-a741-276a3d7ae71e.pem

Size is 3 bytes, obviously not right, and saw some other users with that problem at the opnsense forum as well.
This broke my nginx-Server since I upgraded to OPNsense 20.7.8, had to disable upstream certificate verification for now to get it back up and running. Hope to see a fix being deployed soon :/

Does this fix the trust_upstream_* files not being put in place correctly?

root@gw:~ # ls -l /usr/local/etc/nginx/key/trust_upstream*
-rw-------  1 root  wheel  3 Jan 23 22:07 /usr/local/etc/nginx/key/trust_upstream_5037b17e-fc0d-452a-9b59-da40823f7550.pem
-rw-------  1 root  wheel  3 Jan 23 21:53 /usr/local/etc/nginx/key/trust_upstream_acc62566-fd6f-4488-8b88-a7022399cb56.pem
-rw-------  1 root  wheel  3 Jan 23 22:05 /usr/local/etc/nginx/key/trust_upstream_d9229681-d046-4320-a741-276a3d7ae71e.pem

Size is 3 bytes, obviously not right, and saw some other users with that problem at the opnsense forum as well.
This broke my nginx-Server since I upgraded to OPNsense 20.7.8, had to disable upstream certificate verification for now to get it back up and running. Hope to see a fix being deployed soon :/

Merged due to maintainer timeout, thank you! ❤

Merged due to maintainer timeout, thank you! ❤

@fichtner
thanks!!

@fichtner
thanks!!


Use expit for sigmoid in vae example

This seems to improve performance a bit. On master
%timeit objective_grad(combined_init_params, 0)
102 ms ± 4.16 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

and with this change
%timeit objective_grad(combined_init_params, 0)
68.9 ms ± 1.38 ms per loop (mean ± std. dev. of 7 runs, 10 loops each)

Nice catch, and thanks for profiling!


After removing and adding back the universe data messages are not sent

Hi All 👋
Nice to meet you ;)
I have a project using sACNKit and found edge case in which the socket termination message is always sent instead of message for universe.
In my case the problem occurs when doing such operations:

Start sACNSource and add a single universe to it
Call removeUniverse with the number of above universe
Add again the same universe again

As far as I figured out the removeUniverse registers socket in the socketsShouldTerminate dictionary, which later is never cleaned out. In effect the sendDataMessages method instead of picking up the right message, always sends the socketTerminationMessages. This happens in this line:
let messages = socketsShouldTerminate[interface] != nil ? socketTerminationMessages : universeMessages

The intuition says me that probably we should clean the socketsShouldTerminate dictionary at some point, but I'm not that familiar with the whole code to be able to quickly find proper place.
If you could take a look I would be more than grateful 🙇 . Or you can leave me a hint where it should be cleaned and I will prepare a PR with the changes. Just let me know what suits you better ;)

Hi @WojciechTrzasko nice to meet you too. Thanks for reporting this.
Off the top of my head I think you might be onto the right track with emptying the dictionary. I will take a look at this and look to get this resolved. Universe termination in general is a bit of a tricky problem to resolve properly which is why many implementations don't do it right and just stop sending!
Appreciate you sending this over!

Thanks @dsmurfin 🙇
I was guessing this is not an easy task and this is why I first decided to ask you for help. If you see a place where I could help somehow, just let me know 😉.

@WojciechTrzasko this has been resolved in v1.1.1.
I have revised how universe termination is handled. Your issue would have only occured if you had a single present and then removed that, otherwise the dictionary would have been emptied. However, when looking into this I found that non-terminating universes were also being impacted when when terminating another, so I have reworked how this functions. It's now much cleaner.
Thanks again for finding this and letting me know!


Using a container twice in the same page (state and action conflict)

Hi, I have a ProductGrid container that has its own actions, reducer, selectors and sagas.
This container can be configured by query options.
I have another container HomePage that need to do something like this
<ProductGrid category='cat1' />
<ProductGrid category='cat2' />

But since the ProductGrid selector only select from one global domain, the data will conflict. Also saga watchers will conflict (takeLatest) when both grids want to dispatch a FETCH_PRODUCT action.
What's the best way to solve this kind of issue ?

Is it possible to show an example of your ProductGrid reducer? That will certainly make it easier to help. Just guessing here, so I'm probably wrong, but it sounds like product grid will need to be an array and each item has a category key so you can select them based on the passed in prop?

this is my reducer
{
  status: {
    isLoading: false,
    success: false,
    error: null,
  },
  query: {},
  ids: [],
}

and I can understand your idea, and thinking about it, I believe it can work.
I will end up with something very similar
[{
  status: {
    isLoading: false,
    success: false,
    error: null,
  },
  query: {},
  ids: [],
}]

The downside is that for every action (FETCH, SUCCESS, ERROR) I have to make an equality check for the query object to know where to save the ids. Same for the selector I have to select the one that matches the query object in this.props.
But yeh I believe this might be a good solution 👍

I've never seen reusing containers like this. I think it can be refactored into a dumb component. Are you using ProductGrid in any container other than HomePage? If not, can you make ProductGrid a dumb component and feed the data/actions via props from HomePage? That means you'll have to move actions, reducers, sagas to HomePage's actions, reducers and sagas.

@KarandikarMihir I'll be reusing it in most of my pages actually

@KarandikarMihir yes but I will still have to have an array in the state to save different result of products with different query objects, right ? I just moved that logic to the App level

Alright! How do you like my second solution? Moving everything to app level and reusing it as a simple component.

Yup! I think you'll want to use object instead of an array for better state management. So your state might look something like this-
1: {
  products: [
    { pid: 1, pname: 'abc' },
    { pid: 2, pname: 'pqr' }
  ]
},
2: {
  products: [
    { pid: 55, pname: 'aaa' },
    { pid: 66, pname: 'bbb' }
  ]
}

And in one of your containers-
...
render() {
  return (
    <div>
        {
          this.props.gridIds.map((id) => {
            return (
              <ProductGrid key={id} data={this.props.grid[id].products} />
            )
          })
        }
    </div>
  )
}

You'll have to normalize your data. See normalizr. It's a painful process, but once you get the idea, your app will be in much better shape. Hope that helps.

ok so lets say I have these pages HomePage, CategoryPage and BrandPage

HomePage will display two grids ProductGrid

one with query { category: 'cat1' }
and one with query { category: 'cat2' }

CategoryPage has one ProductGrid with query {category: 'cat3'}
BrandPage has one ProductGrid with query {brand: 'brand1'}

Now you can see why I cant move all the logic for fetching all grids in the App and If I moved it to the Page Level I will have a lot of duplicate code and I dont like that.
It would be really nice if I can do something like this <ProductGrid query={...} /> in any place and it works, but that wont work in case of two grids exist in the same page. see what I mean?
So I think actuallly having a more complicated state like this inside the ProductGrid reducer will be much better and will work in all my cases
{
  productGrid: [{
    status: {
      isLoading: false,
      success: false,
      error: null,
    },
    query: {},
    ids: [],
  }]
}

It's a little bit harder to manage tho. Also I'm using normalizr ;)

I think I'm missing an important piece of the puzzle. Based on what you're saying, I'd say this an ideal situation to move everything to App level to reuse ProductGrid properly. But you're saying the exact opposite of this :sweat_smile: Also you're using normalizr! Wonder why this is happening. I'm out of tricks.

So your edit on having products attribute in the category entity now makes sense. But this query object can be more complicated than {category:...}. It can be something like this {category:..., brand:...., topSales, ....}.
And the problem for me in moving everything to the App is that the App cant define an action/reducer for each grid I have in the application, I will endup with something like this in the App actions file for example

FETCH_BY_CATEGORY_GRID_1
FETCH_BY_CATEGORY_GRID_2
FETCH_BY_BRAND_GRID_1
....etc
That will be too much dont you think ?

Yeah. That doesn't look good. Why are you creating so many action creators? Is it because you have radically different URLs of endpoints and URL params? Generally, you'd use the one URL but different URL params to fetch the desired data, which means only one action creator is enough. And then store it in such a manner that the components can easily access the data (like the way I've written in the example).

Is it because you have radically different URLs of endpoints and URL params?

If this is the case, it looks like an ideal application for GraphQL.
If you need to learn more about GraphQL, I can recommend this course, and there are others.


Code quality could be better

I know that the bar for GDScript code is not very high, and I consider myself quite tolerant when it comes to other's people code, but there are a couple of issues here that make me not want to even touch this plugin:

You like using Dictionarys way too much. I feel like 99% of the dictionaries in this code should just be replaced with classes for better readability and maintainability
You inherit the classes that you have from very strange bases, like PackedDataContainer. I'm not sure you understand what this class even does, but inheriting from it does absolutely nothing in this context. You should inherit from Resource or better yet RefCounted if you don't need any of the Resource's functionality.

There are other strange things that I noticed, but those are relatively minor. Fixing just these 2 should not take a lot of time and will immediately improve code quality by an order of magnitude, from my point of view at least

When it comes to data structures, the priority is optimisation. I'm not sure if using classes would do any good.
The inheritance only serves one purpose. When you click on the inspector button to add a resource, it shows you the list of compatible resources. If the resources didn't have a common parent, it would show you the entire list of Godot resources that you'd have to scroll through. The issue is that when the plugin was created, Godot didn't support exporting custom resources. In order to do that, the parent had to be a native Godot resource. This is why I chose as parent unrelated resources. I tried to change it in the last version, however if you change the parent class, Godot resets every data associated with it. All previous users would lose everything they made, which is not good.

There is no world where using dictionaries (HashMaps) instead of classes gives you any performance benefits. Classes have compact static layout as a rule, and even in the worst case they are just implemented as the same hash maps under the hood. You are sacrificing clarity and type checker protections to get either absolutely nothing(best case) or reduced performance(worst case).
If the changing base class of a resource results in data loss, this is a bug, because it shouldn't happen. Resource system in godot is very flexible in regards to changes, and even if you change the base class, godot doesn't care and doesn't reset your data.

And if you want proof that Dictionaries are in fact worse in terms of performance, here you go a little test:
func test_normal_class_init() -> Array:
	var objsArray := []
	var perfBefore := Time.get_ticks_usec()
	for i in 10000:
		var new_obj := TestClass.new()
		new_obj.member_str_1 = "hi"
		objsArray.push_back(new_obj)
	var timePassed := Time.get_ticks_usec() - perfBefore
	print("test_normal_class_init perf is ", timePassed)
	return objsArray

func test_dict_init() -> Array:
	var objsArray := []
	var perfBefore := Time.get_ticks_usec()
	for i in 10000:
		var new_obj := TestClass2.make_dictionary()
		new_obj["member_str_1"] = "hi"
		objsArray.push_back(new_obj)
	var timePassed := Time.get_ticks_usec() - perfBefore
	print("test_dict_init perf is ", timePassed)
	return objsArray

func test_class_access(clarr: Array):
	var perfBefore := Time.get_ticks_usec()
	var s := 0
	for i in 10000:
		var t = clarr[i].member_var_10 + clarr[i].member_var_12
		s += t
	var timePassed := Time.get_ticks_usec() - perfBefore
	print ("test_class_access perf is ", timePassed, " res ", s)

func test_dict_access(clarr: Array):
	var perfBefore := Time.get_ticks_usec()
	var s := 0
	for i in 10000:
		var t = clarr[i]["member_var_10"] + clarr[i]["member_var_12"]
		s += t
	var timePassed := Time.get_ticks_usec() - perfBefore
	print ("test_dict_access perf is ", timePassed, " res ", s)

func _ready():
	var clObjs := test_normal_class_init()
	var dictObjs := test_dict_init()
	test_class_access(clObjs)
	test_dict_access(dictObjs)

test_class.gd: https://pastebin.com/Cg99WRuG
test_class_2.gd: https://pastebin.com/KaVUkq1S
Results:
test_normal_class_init perf is 86306
test_dict_init perf is 82488
test_class_access perf is 3321 res 0
test_dict_access perf is 6537 res 0

Creating objects has slightly more overhead(not really surprising, due to constructors being run)
When it comes to data access, class objects are 2x better in this test than dictionaries

Interesting. I'll probably make that change one day.


Bump Dependencies #10332484564

Bumps dependencies for product-is. Link : https://github.com/wso2/product-is/actions/runs/10332484564

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Redundant with https://github.com/wso2/product-is/pull/20878


adding error in case keyword search can't be optimized

This pull request includes a change to the run method in the chatreadretrieveread.py file. The change adds a check for the presence of choices in the chat completion response and raises a ValueError if no choices are returned.
Error handling improvement:

app/backend/approaches/chatreadretrieveread.py: Added a check to ensure that the chat completion response contains choices and raises a ValueError if it does not.

*updating calls to check for content filtering

@dayland do we need both calls on lines 397 and 428? Seems like we only need the call on 428


toil: metrics for nonstandard cluster support status

Which issue this PR addresses:
https://msazure.visualstudio.com/AzureRedHatOpenShift/_workitems/edit/10614778
What this PR does / why we need it:
As an SRE, I want to be able to use metrics dashboards and alerts to determine if feature flags are set such that they disable parts of the ARO Operator, and also to know if a "contact support" banner is being displayed in their console.
By doing this, we can more easily monitor the fleet and keep track of snowflake or unsupported clusters
Test plan for issue:
Unit test
Manual test via local RP
Is there any documentation that needs to be updated for this PR?
N/A

All things told, LGTM. I'm not seeing caching, and pagination is there, excellent. Callout on this testing, excellent format and very clear! Nice work.
I left a few nits on names of things if you want to have a look.

@SudoBrendan Hi Brendan, thanks a lot for the review!


Fixes a stack overflow on windows.

Not quite sure why collect causes the error, but extend doesn't.

Seems like it's failing a number of the tests? Also, this feels like an issue worth reporting upstream.

The tests are overflowing their stacks as well on this branch and on main... I have no idea why they would. Do they pass on your machine?

I think I see what is happening, there seems to be some stack issue in debug mode that causes the stack overflow in addition to the one I attempted to fix. Resolving that issue may remove the need for this PR

Ah, I wonder if it's the into_iter over the new array that does it. It probably ends up copying the array to the stack inside the generated Iterator. Using iter instead should do the trick

Codecov Report

Merging #16 (923bec5) into main (0f1ca3b) will increase coverage by 2.16%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   36.36%   38.52%   +2.16%
==========================================
  Files          14       13       -1
  Lines         605      571      -34
==========================================
  Hits          220      220
+ Misses        385      351      -34

Impacted Files
Coverage Δ

src/algorithms/allocs.rs
0.00% <0.00%> (ø)

src/algorithms/cutoff.rs
0.00% <0.00%> (ø)

src/algorithms/enumerate.rs
0.00% <0.00%> (ø)

src/algorithms/escore.rs
96.29% <ø> (ø)

src/algorithms/naive.rs
0.00% <0.00%> (ø)

src/algorithms/popular.rs
0.00% <0.00%> (ø)

src/algorithms/precalc.rs
0.00% <0.00%> (ø)

src/algorithms/sigmoid.rs
0.00% <ø> (ø)

src/algorithms/vecremain.rs
0.00% <0.00%> (ø)

src/algorithms/weight.rs
0.00% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b680cd...923bec5. Read the comment docs.

That seems to have done the trick. I have switched my initial attempt with your suggestion.


KinematicBody2D::move_and_collide() detects collision but returns null.

Operating system: OS X 10.11.6
Godot version: Godot 3 (91adb58)
Issue description:
I'm using move_and_collide() to move a KinematicBody2D and detect collision against a StaticBody2D.
I want the collision to happen only at edges so I'm using a CollisionPolygon2D with Build Mode set to Segment for the static body.
The collision works as expected and the kinematic body stops at edges, but move_and_collide()  returns null if the collision points are parallel.
For example if an edge of the kinematicbody's collision shape is parallel to an edge of the staticbody's collision shape.
I would expect to receive a KinematicCollision2D as return value when collision occurs.
Steps to reproduce:

Add a StaticBody2D with a CollisionPolygon2D (Build Mode = Segment) to the scene.

Add a KinematicBody2D with a Rectangle collision shape to the scene.

Use move_and_collide() to move the kinematic body against the static body.

Link to minimal example project:
segment_collision.zip

LineShape2D have a similar issue (I wonder if related), an intermitent null-KinematicCollisio2D as collision result.

it seems segments are broken, i will give it a test

Also seeing this with a CircleShape2D which is move_and_collided against a RectangleShape2D. No time to make a proper repro case now, just noting that it might not be related to lines.
It seems to work when entering the rectangle from the right, top and bottom, but not from the left.

I tried to fix this, the problem is that you are trying to collide with the internal part of the polygon, which will likely not work due to how the physics engine works. I have no idea how to fix this in a way that is not a mess, so kicking to 3.2

Seems fixed in 966c68b.