Running EF core migration bundles on linux with Active Directory Default as connection string.

Executing migration bundle built using Azure Pipelines
  pool:
     vmImage: ubuntu-latest

Does not work. I expected the migration to be executed as the Service Connections MSI (which has sql permissions)
Instead I get the error:
SharedTokenCacheCredential authentication failed: Persistence check failed. Data was written but it could not be read. Possible cause: on Linux, LibSecret is installed but D-Bus isn't running because it cannot be started over SSH.

Appsettings:
{
    // This file is published together with the EF Core Migration Bundles in DevOps
  "ConnectionStrings": {
    "CONNECTION_STRING": "Server=tcp:XXXX.database.windows.net,1433;Initial Catalog=sqldb-xxxx;Authentication=Active Directory Default"
  }
}

Azure pipelines task to build the bundle
  - task: DotNetCoreCLI@2
            displayName: Build EF Core Migration Bundle
            inputs:
              command: custom
              custom: ef
              arguments: migrations bundle (irrelevant arguments omitted)
          - task: CopyFiles@2
            displayName: Copy EF Core Migration Bundle AppSettings
            inputs:
              Contents: 'src/Migrator/appsettings.json'
              TargetFolder: MigrationBundle
              flattenFolders: true

Azure pipelines task to run the ef bundle output:
              - bash: |
                    chmod +x MigrationBundle
                    ./MigrationBundle --verbose
                  displayName: Deploy Database sqldb-$(projectName)
                  workingDirectory: $(Agent.BuildDirectory)/drop/MigrationBundle
                  failOnStderr: true

The error is chinese to me, and I don't have control over what is running on the linux hosted agent.
Is this scenario supported or should we use windows agents if we want the service connections MSI?
Minor update: I read https://github.com/Azure/azure-sdk-for-net/issues/17052 but I have no Idea how to apply this workaround to EF Core.
Update: added stack trace from pipeline logs
Microsoft.Data.SqlClient.SqlException (0x80131904): SharedTokenCacheCredential authentication failed: Persistence check failed. Data was written but it could not be read. Possible cause: on Linux, LibSecret is installed but D-Bus isn't running because it cannot be started over SSH.
 ---> Azure.Identity.AuthenticationFailedException: SharedTokenCacheCredential authentication failed: Persistence check failed. Data was written but it could not be read. Possible cause: on Linux, LibSecret is installed but D-Bus isn't running because it cannot be started over SSH.
 ---> Microsoft.Identity.Client.Extensions.Msal.MsalCachePersistenceException: Persistence check failed. Data was written but it could not be read. Possible cause: on Linux, LibSecret is installed but D-Bus isn't running because it cannot be started over SSH.
   at Microsoft.Identity.Client.Extensions.Msal.MsalCacheStorage.VerifyPersistence()
   at Microsoft.Identity.Client.Extensions.Msal.MsalCacheHelper.VerifyPersistence()
   at Azure.Identity.MsalClientBase`1.GetClientAsync(Boolean async, CancellationToken cancellationToken)
   at Azure.Identity.MsalClientBase`1.GetClientAsync(Boolean async, CancellationToken cancellationToken)
   at Azure.Identity.MsalPublicClient.GetAccountsAsync(Boolean async, CancellationToken cancellationToken)
   at Azure.Identity.SharedTokenCacheCredential.GetAccountAsync(Boolean async, CancellationToken cancellationToken)
   at Azure.Identity.SharedTokenCacheCredential.GetTokenImplAsync(Boolean async, TokenRequestContext requestContext, CancellationToken cancellationToken)
   --- End of inner exception stack trace ---
   at Azure.Identity.CredentialDiagnosticScope.FailWrapAndThrow(Exception ex)
   at Azure.Identity.SharedTokenCacheCredential.GetTokenImplAsync(Boolean async, TokenRequestContext requestContext, CancellationToken cancellationToken)
   at Azure.Identity.SharedTokenCacheCredential.GetTokenAsync(TokenRequestContext requestContext, CancellationToken cancellationToken)
   at Azure.Identity.DefaultAzureCredential.GetTokenFromSourcesAsync(TokenCredential[] sources, TokenRequestContext requestContext, Boolean async, CancellationToken cancellationToken)
   at Azure.Identity.DefaultAzureCredential.GetTokenImplAsync(Boolean async, TokenRequestContext requestContext, CancellationToken cancellationToken)
   at Azure.Identity.CredentialDiagnosticScope.FailWrapAndThrow(Exception ex)
   at Azure.Identity.DefaultAzureCredential.GetTokenImplAsync(Boolean async, TokenRequestContext requestContext, CancellationToken cancellationToken)
   at Azure.Identity.DefaultAzureCredential.GetTokenAsync(TokenRequestContext requestContext, CancellationToken cancellationToken)
   at Microsoft.Data.SqlClient.ActiveDirectoryAuthenticationProvider.AcquireTokenAsync(SqlAuthenticationParameters parameters)
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.<>c__DisplayClass146_1.<<GetFedAuthToken>b__1>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.Data.SqlClient.SqlInternalConnectionTds.GetFedAuthToken(SqlFedAuthInfo fedAuthInfo)
   at Microsoft.Data.ProviderBase.DbConnectionPool.CheckPoolBlockingPeriod(Exception e)
   at Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)
   at Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at Microsoft.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at Microsoft.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry, SqlConnectionOverrides overrides)
   at Microsoft.Data.SqlClient.SqlConnection.Open(SqlConnectionOverrides overrides)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerConnection.OpenDbConnection(Boolean errorsExpected)

@roji I am unsure if that move makes sense, as there is no problem with SQL Client. I'm afraid it might die out here.
I don't have control over whether or not "D-bus" is running. It is the azure hosted build agent that wouldn't have it enabled. My problem is with EF migration bundles generating a bundle that does not work when run on Azure DevOps hosted agents.
So if it needs to be moved I guess it could be moved to some azure-pipelines github...

@MichielCornilleKenze I will try to test M.D.S on ubuntu-latest. Meanwhile can you try other ubuntu version except latest or try to launch D-bus. Here is similar discussion on ubuntu forum https://askubuntu.com/questions/135573/gconf-error-no-d-bus-daemon-running-how-to-reinstall-or-fix.

I currently worked around this by using "Active Directory Default" , a windows-latest hosted agent, Azure CLI task and letting DefaultAzureCredential use AzureCLI Authentication.

I don't know a lot about Azure pipelines, but I ran into the same issue when executing dotnet-ef database update from a GitLab docker runner.
Steps to reproduce:
docker run -it mcr.microsoft.com/dotnet/sdk:6.0 /bin/bash
apt update && apt install -y libsecret-1-0
dotnet tool install -g dotnet-ef --version 6.0.5
[copy or mount a project to container for testing purposes]
~/.dotnet/tools/dotnet-ef database update

Results in the same issue:
[...]
SharedTokenCacheCredential authentication failed: Persistence check failed. Data was written but it could not be read. Possible cause: on Linux, LibSecret is installed but D-Bus isn't running because it cannot be started over SSH.

My solution was to set the environment variables for Azure.Identity: https://docs.microsoft.com/en-us/dotnet/api/azure.identity.environmentcredential?view=azure-dotnet
I'm using an App Registration to deploy, so I executed the following commands:
export AZURE_TENANT_ID=XXX
export AZURE_CLIENT_ID=XXX
export AZURE_CLIENT_SECRET=XXX
~/.dotnet/tools/dotnet-ef database update

and it worked. :+1:
I initially thought I can use az to authenticate, which was wrong. Installing the Azure CLI as described here and executing the following resulted in the same issue.
az login --service-principal --username XXX --password XXX --tenant XXX
Hope this helps somebody.

Is there any progress on this?

Hi
not sure if this one is alive but I'm getting the same error on my Mac after build ing a bundle with dotnet ef migrations bundle -r osx-arm64.
Microsoft.Data.SqlClient.SqlException (0x80131904): The operation was canceled.
---> System.Threading.Tasks.TaskCanceledException: The operation was canceled.
at System.Net.Http.HttpClient.HandleFailure(Exception e, Boolean telemetryStarted, HttpResponseMessage response, CancellationTokenSource cts, CancellationToken cancellationToken, CancellationTokenSource pendingRequestsCts)
at System.Net.Http.HttpClient.g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
at Microsoft.Identity.Client.Http.HttpManager.ExecuteAsync(Uri endpoint, IDictionary2 headers, HttpContent body, HttpMethod method, ILoggerAdapter logger, CancellationToken cancellationToken)    at Microsoft.Identity.Client.Http.HttpManager.ExecuteWithRetryAsync(Uri endpoint, IDictionary2 headers, HttpContent body, HttpMethod method, ILoggerAdapter logger, Boolean doNotThrow, Boolean retry, CancellationToken cancellationToken)
at Microsoft.Identity.Client.Http.HttpManager.SendGetAsync(Uri endpoint, IDictionary2 headers, ILoggerAdapter logger, Boolean retry, CancellationToken cancellationToken)    at Microsoft.Identity.Client.OAuth2.OAuth2Client.ExecuteRequestAsync[T](Uri endPoint, HttpMethod method, RequestContext requestContext, Boolean expectErrorsOn200OK, Boolean addCommonHeaders, Func2 onBeforePostRequestData)
at Microsoft.Identity.Client.OAuth2.OAuth2Client.DiscoverAadInstanceAsync(Uri endPoint, RequestContext requestContext)
at Microsoft.Identity.Client.Instance.Discovery.NetworkMetadataProvider.SendInstanceDiscoveryRequestAsync(Uri authority, RequestContext requestContext)
at Microsoft.Identity.Client.Instance.Discovery.NetworkMetadataProvider.FetchAllDiscoveryMetadataAsync(Uri authority, RequestContext requestContext)
at Microsoft.Identity.Client.Instance.Discovery.NetworkMetadataProvider.GetMetadataAsync(Uri authority, RequestContext requestContext)
at Microsoft.Identity.Client.Instance.Discovery.InstanceDiscoveryManager.FetchNetworkMetadataOrFallbackAsync(RequestContext requestContext, Uri authorityUri)
at Microsoft.Identity.Client.Instance.Discovery.InstanceDiscoveryManager.GetMetadataEntryAsync(AuthorityInfo authorityInfo, RequestContext requestContext, Boolean forceValidation)
at Microsoft.Identity.Client.AuthorityInfo.AuthorityInfoHelper.IsAuthorityAliasedAsync(RequestContext requestContext, AuthorityInfo requestAuthorityInfo)
at Microsoft.Identity.Client.AuthorityInfo.AuthorityInfoHelper.ValidateSameHostAsync(AuthorityInfo requestAuthorityInfo, RequestContext requestContext)
at Microsoft.Identity.Client.AuthorityInfo.AuthorityInfoHelper.CreateAuthorityForRequestAsync(RequestContext requestContext, AuthorityInfo requestAuthorityInfo, IAccount account)
at Microsoft.Identity.Client.Instance.Authority.CreateAuthorityForRequestAsync(RequestContext requestContext, AuthorityInfo requestAuthorityInfo, IAccount account)
at Microsoft.Identity.Client.ClientApplicationBase.CreateRequestParametersAsync(AcquireTokenCommonParameters commonParameters, RequestContext requestContext, ITokenCacheInternal cache)
at Microsoft.Identity.Client.ApiConfig.Executors.ClientApplicationBaseExecutor.ExecuteAsync(AcquireTokenCommonParameters commonParameters, AcquireTokenByRefreshTokenParameters refreshTokenParameters, CancellationToken cancellationToken)
at Azure.Identity.AbstractAcquireTokenParameterBuilderExtensions.ExecuteAsync[T](AbstractAcquireTokenParameterBuilder1 builder, Boolean async, CancellationToken cancellationToken)    at Azure.Identity.MsalPublicClient.AcquireTokenByRefreshTokenCoreAsync(String[] scopes, String claims, String refreshToken, AzureCloudInstance azureCloudInstance, String tenant, Boolean async, CancellationToken cancellationToken)    at Azure.Identity.MsalPublicClient.AcquireTokenByRefreshTokenAsync(String[] scopes, String claims, String refreshToken, AzureCloudInstance azureCloudInstance, String tenant, Boolean async, CancellationToken cancellationToken)    at Azure.Identity.VisualStudioCodeCredential.GetTokenImplAsync(TokenRequestContext requestContext, Boolean async, CancellationToken cancellationToken)    at Azure.Identity.CredentialDiagnosticScope.FailWrapAndThrow(Exception ex, String additionalMessage)    at Azure.Identity.VisualStudioCodeCredential.GetTokenImplAsync(TokenRequestContext requestContext, Boolean async, CancellationToken cancellationToken)    at Azure.Identity.VisualStudioCodeCredential.GetTokenAsync(TokenRequestContext requestContext, CancellationToken cancellationToken)    at Azure.Identity.DefaultAzureCredential.GetTokenFromSourcesAsync(TokenCredential[] sources, TokenRequestContext requestContext, Boolean async, CancellationToken cancellationToken)    at Azure.Identity.DefaultAzureCredential.GetTokenImplAsync(Boolean async, TokenRequestContext requestContext, CancellationToken cancellationToken)    at Azure.Identity.CredentialDiagnosticScope.FailWrapAndThrow(Exception ex, String additionalMessage)    at Azure.Identity.DefaultAzureCredential.GetTokenImplAsync(Boolean async, TokenRequestContext requestContext, CancellationToken cancellationToken)    at Azure.Identity.DefaultAzureCredential.GetTokenAsync(TokenRequestContext requestContext, CancellationToken cancellationToken)    at Microsoft.Data.SqlClient.ActiveDirectoryAuthenticationProvider.AcquireTokenAsync(SqlAuthenticationParameters parameters)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds.<>c__DisplayClass147_1.<<GetFedAuthToken>b__1>d.MoveNext() --- End of stack trace from previous location ---    at Microsoft.Data.SqlClient.SqlInternalConnectionTds.GetFedAuthToken(SqlFedAuthInfo fedAuthInfo)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds.GetFedAuthToken(SqlFedAuthInfo fedAuthInfo)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds.OnFedAuthInfo(SqlFedAuthInfo fedAuthInfo)    at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)    at Microsoft.Data.SqlClient.TdsParser.Run(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds.CompleteLogin(Boolean enlistOK)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds.AttemptOneLogin(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean ignoreSniOpenTimeout, TimeoutTimer timeout, Boolean withFailover)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds.LoginNoFailover(ServerInfo serverInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString connectionOptions, SqlCredential credential, TimeoutTimer timeout)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds.OpenLoginEnlist(TimeoutTimer timeout, SqlConnectionString connectionOptions, SqlCredential credential, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance)    at Microsoft.Data.SqlClient.SqlInternalConnectionTds..ctor(DbConnectionPoolIdentity identity, SqlConnectionString connectionOptions, SqlCredential credential, Object providerInfo, String newPassword, SecureString newSecurePassword, Boolean redirectedUserInstance, SqlConnectionString userConnectionOptions, SessionData reconnectSessionData, Boolean applyTransientFaultHandling, String accessToken, DbConnectionPool pool)    at Microsoft.Data.SqlClient.SqlConnectionFactory.CreateConnection(DbConnectionOptions options, DbConnectionPoolKey poolKey, Object poolGroupProviderInfo, DbConnectionPool pool, DbConnection owningConnection, DbConnectionOptions userOptions)    at Microsoft.Data.ProviderBase.DbConnectionFactory.CreatePooledConnection(DbConnectionPool pool, DbConnection owningObject, DbConnectionOptions options, DbConnectionPoolKey poolKey, DbConnectionOptions userOptions)    at Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)    at Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)    at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)    at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection)
at Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)    at Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource1 retry, DbConnectionOptions userOptions)
at Microsoft.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource1 retry, DbConnectionOptions userOptions)    at Microsoft.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource1 retry, SqlConnectionOverrides overrides)
at Microsoft.Data.SqlClient.SqlConnection.Open(SqlConnectionOverrides overrides)
at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerConnection.OpenDbConnection(Boolean errorsExpected)
at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.OpenInternal(Boolean errorsExpected)
at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.Open(Boolean errorsExpected)
at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerDatabaseCreator.<>c__DisplayClass18_0.b__0(DateTime giveUp)
at Microsoft.EntityFrameworkCore.ExecutionStrategyExtensions.<>c__DisplayClass12_02.<Execute>b__0(DbContext _, TState s)    at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerExecutionStrategy.Execute[TState,TResult](TState state, Func3 operation, Func3 verifySucceeded)    at Microsoft.EntityFrameworkCore.ExecutionStrategyExtensions.Execute[TState,TResult](IExecutionStrategy strategy, TState state, Func2 operation, Func`2 verifySucceeded)
at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerDatabaseCreator.Exists(Boolean retryOnNotExists)
at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerDatabaseCreator.Exists()
at Microsoft.EntityFrameworkCore.Migrations.HistoryRepository.Exists()
at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Migrate(String targetMigration)
at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.UpdateDatabase(String targetMigration, String connectionString, String contextType)
at Microsoft.EntityFrameworkCore.Migrations.Design.MigrationsBundle.ExecuteInternal(String[] args)
at Microsoft.EntityFrameworkCore.Migrations.Design.MigrationsBundle.<>c__DisplayClass6_0.b__0(String[] args)
at Microsoft.DotNet.Cli.CommandLine.CommandLineApplication.Execute(String[] args)
at Microsoft.EntityFrameworkCore.Migrations.Design.MigrationsBundle.Execute(String context, Assembly assembly, Assembly startupAssembly, String[] args)

@nilshjalmarson increase the command and connect timeouts


a shared vignette/tab on multichannel buf*processes

the same way we have multithreading one, it would be good to have a shared multichannel explainer, especially on channel orders, instead of having examples for each buf*process.
The same would happen in Pd and maybe in SC @tedmoore ?

The same would happen in Pd and maybe in SC @tedmoore ?

Totally. This is a great idea.

Tis done in Max.

I didn't get a review for this, is it normal? I can review the max one as i do the pd one I reckon...

Ah woops. I replaced multichannel with multithreaded in my head. I went back and dropped in the blocking attribute patcher but thats not what this is talking about 😂. Reopening.


[Network] Add Load Balancer SKU support

Adds SKU support for Load Balancer create, as well as VMSS create.

This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[X] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

[X] Each command and parameter has a meaningful description.
[N/A] Each new command has a test.

(see Authoring Command Modules)

This won't pass CI due to the fact that the SDK hasn't been released, but I've tested manually so it should be good for review. When the final SDK is generated, I'll get it green.

Suggest following adjustment:

Please apply newer NRP api-version on Public-IP resource as well
Standard LB needs standard Public-IP.
Based on error I got, the allocation method of Public IP address should be Static
Please expose --sku from Public-IP's create command as well

@yugangw-msft updated based on your feedback and added a test for VMSS create and LB create to ensure those scenarios work.

@yugangw-msft I think everything should be good now if you can take a second look.

Codecov Report

Merging #4292 into master will increase coverage by <.01%.
The diff coverage is 84.37%.

@@            Coverage Diff             @@
##           master    #4292      +/-   ##
==========================================
+ Coverage   70.15%   70.15%   +<.01%
==========================================
  Files         475      475
  Lines       29769    29795      +26
  Branches     4575     4584       +9
==========================================
+ Hits        20883    20904      +21
+ Misses       7434     7430       -4
- Partials     1452     1461       +9

Impacted Files
Coverage Δ

...ure-cli-vm/azure/cli/command_modules/vm/_params.py
96.62% <100%> (+0.02%)
:arrow_up:

...twork/azure/cli/command_modules/network/_params.py
93.47% <100%> (+0.04%)
:arrow_up:

...etwork/azure/cli/command_modules/network/custom.py
62.53% <75%> (+0.06%)
:arrow_up:

.../azure/cli/command_modules/vm/_template_builder.py
87.55% <80%> (-0.22%)
:arrow_down:

...e/cli/command_modules/network/_template_builder.py
83.8% <83.33%> (-0.51%)
:arrow_down:

...zure-cli-vm/azure/cli/command_modules/vm/custom.py
74.49% <85.71%> (+0.02%)
:arrow_up:

...dback/azure/cli/command_modules/feedback/custom.py
31.25% <0%> (ø)
:arrow_up:

...li-cloud/azure/cli/command_modules/cloud/custom.py
13.79% <0%> (ø)
:arrow_up:

...nent/azure/cli/command_modules/component/custom.py
16.26% <0%> (ø)
:arrow_up:

src/azure-cli-core/azure/cli/core/util.py
69.73% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bacaf80...f902b4e. Read the comment docs.

@yugangw-msft I added the test verifications.

@tjprescott, cool, please go head merge.
//CC: @christiankuhtz


incorrect work of the getCells

отсчет строк начинается с 1, а вот столбцов от 0. то есть при попытке записать в ячейку "E2"
Api.GetActiveSheet().GetCells(2, 5).SetValue("");
запись происходит не в "E2", а в "F2".

Hi, please do not use the Russian language in issue reports - we are an international community and only allow English in issue reports (you can translate it via an online translator), so other people would find those reports if someone else faced similar issue
Also please add more details about your environment - which version of DocumentServer/DesktopEditors are you using

Hi, I'm sorry, I'll try using google translator. the count of rows starts from 1, but the columns start from 0. That is, when considering the cell "E2"
Api.GetActiveSheet().GetCells(2, 5).SetValue("");
the entry is not in "E2", but in "F2".  that is, the coordinates of "A1" do not start from (1, 1), but from (1, 0). I used ONLYOFFICE Desktop Editors v <IP_ADDRESS>

@evildeadhc HI! Yes, the behavior of the method is not as expected. Formed the bug in our private repository bug 56159


Nick: Watch coolwellnessspa.in

Nick requests the watch of the watch_keyword coolwellnessspa\.in. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

coolwellnessspa\.in has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Mast in Charcoal HQ


IDVA6-1518: Refactor manageUsersController and fix invalid email search

Improve code structure and readability
Fix bug: invalid email searches now return empty results

This change re-arranges the conditional logic, to ensure that if a search is performed with an invalid email, we show the default search results (as if no search was performed), instead of empty search results.

CI: No security warnings found


Update on RELBENCH Documentation Needed

Dear RELBENCH Team,
I hope this message finds you well. I am reaching out to bring to your attention an issue regarding the documentation for RELBENCH, specifically concerning the README file.
I recently noticed that the RELBENCH version has been updated, bringing with it several improvements and new features, which I commend the team for. However, upon reviewing the README documentation, I observed that it has not been synchronized with the latest changes in the package. More specifically, the instructions for acquiring datasets and performing certain operations appear to be outdated.
I found that following the procedures outlined in the current README leads to discrepancies and issues that prevent successful execution. Fortunately, I discovered that the templates provided in the Google Colab notebooks for RELBENCH reflect the correct methodology for working with the updated package. By adhering to the guidelines within these templates, I was able to successfully retrieve datasets and conduct the necessary operations without any hindrance.
Given the importance of up-to-date documentation for users seeking to integrate RELBENCH into their workflows, I kindly request that the README file be revised to align with the current version of the package. This would ensure that all users have clear and accurate instructions, preventing confusion and saving them from unnecessary troubleshooting.
Thank you for your attention to this matter. Your efforts in maintaining and improving RELBENCH are greatly appreciated, and I look forward to seeing the documentation updated to match the excellence of the software itself.
Best regards,
Yu

Thanks for your feedback @Yuuuuuuu1328. The README is now up-to-date. Sorry for the delay on our side. We are working towards releasing v1.0.0 officially, and getting everything synced up as we go along.


aws-nuke: 2.23.0 -> 2.24.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/rebuy-de/aws-nuke/releases.
meta.description for aws-nuke is: Nuke a whole AWS account and delete all its resources
meta.homepage for aws-nuke is: https://github.com/rebuy-de/aws-nuke
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.24.1 in filename of file in /nix/store/jzg7dcf3db662m8fkjsd1n7va9ik8x2g-aws-nuke-2.24.1

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
aws-nuke

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jzg7dcf3db662m8fkjsd1n7va9ik8x2g-aws-nuke-2.24.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A aws-nuke https://github.com/r-ryantm/nixpkgs/archive/4da542f6934abeeea80e4aebe4f14d68056afdb7.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jzg7dcf3db662m8fkjsd1n7va9ik8x2g-aws-nuke-2.24.1
ls -la /nix/store/jzg7dcf3db662m8fkjsd1n7va9ik8x2g-aws-nuke-2.24.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

aws-nuke

Maintainer pings
cc @grahamc for testing.

Result of nixpkgs-review pr 250751 run on x86_64-linux 1

1 package built:

aws-nuke


Adding external apps and Azure Communication Services

Docs Build status updates of commit d06babf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/overview.md
:bulb:Suggestion
View
Details

msteams-platform/overview.md

Line 207, Column 207: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/azure/communication-services/overview' will be broken in isolated environments. Replace with a relative link.
Line 211, Column 47: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/azure/communication-services/concepts/teams-interop' will be broken in isolated environments. Replace with a relative link.
Line 211, Column 377: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/skype-sdk/appsdk/skypeappsdk' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/overview.md
92
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Hi @tophpalmer,
Please incorporate the changes as suggested.

Docs Build status updates of commit a6144b8:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/overview.md
:bulb:Suggestion
View
Details

msteams-platform/overview.md

Line 207, Column 201: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/azure/communication-services/overview' will be broken in isolated environments. Replace with a relative link.
Line 211, Column 47: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/azure/communication-services/concepts/teams-interop' will be broken in isolated environments. Replace with a relative link.
Line 211, Column 377: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/skype-sdk/appsdk/skypeappsdk' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@v-abirade thank you for the feedback, changes are committed!

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/overview.md
92
7
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/overview.md
91
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit dd05186:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/overview.md
:bulb:Suggestion
View
Details

msteams-platform/overview.md

Line 207, Column 235: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/azure/communication-services/overview' will be broken in isolated environments. Replace with a relative link.
Line 209, Column 47: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/azure/communication-services/concepts/teams-interop' will be broken in isolated environments. Replace with a relative link.
Line 211, Column 154: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/skype-sdk/appsdk/skypeappsdk' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/overview.md
91
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 1597567:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/overview.md
:bulb:Suggestion
View
Details

msteams-platform/overview.md

Line 207, Column 235: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/azure/communication-services/overview' will be broken in isolated environments. Replace with a relative link.
Line 209, Column 83: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/azure/communication-services/concepts/teams-interop' will be broken in isolated environments. Replace with a relative link.
Line 211, Column 154: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/skype-sdk/appsdk/skypeappsdk' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Acrolinx Scorecards
We do not currently enforce a minimum score for content merged to the default branch. This will change in the future.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/overview.md
91
8
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit f912e7a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/overview.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[IDE] Allow typeCheckASTNodeAtLoc to type check declarations

We need the ability to type check declarations when entering using typeCheckASTNodeAtLoc for solver-based cursor info.
This causes more context to be type checked for code completion and breaks some type completion after dot if the base type is not fully qualified because the type checker will mark TypeRepr as invalid. But since we don’t actually need to run the type checker for type member completion, we can just not call typeCheckContextAt for TypeIdentifierWithDot completions.

@swift-ci Please smoke test

@swift-ci Please smoke test

@swift-ci Please SourceKit stress test


No audio rendering in IPython

VSCode Version: 1.43.2
OS Version: MacOS 10.15.3

Steps to Reproduce:

Run the following code in a IPython cell
Observe that the audio is grayed out.

import numpy as np
from IPython.display import Audio
Audio(np.random.rand(16000), rate=16000)

Does this issue occur when all extensions are disabled?: Yes
There have been numerous reports that the audio (and video) is not working in IPython cells, however I think the root cause are not the missing codecs reported in https://github.com/microsoft/vscode-python/issues/3405 and https://github.com/Microsoft/vscode-python/issues/3456. The example above does not use a codec, just plain samples.
For anyone doing datascience with audio, this bug kills the use of IPython in VSCode.
btw, https://github.com/microsoft/vscode/issues/80196 is tagged wrongly as 'caused by an extension'.

@bliep This comes from the python extension, so please file it there: https://github.com/Microsoft/vscode-python


Jdb 17 implementation of notifications

add toaster notifications
simplify toaster use

hey my friend @BenIzak can you look my code if it is nice ? thanks

Good. but your function is not safe, there is not enough security, in some cases you risk the toaster will not appear or worse
For example, try this :
ToastShow("test error message", 10)

my friend rebase your code PLEASE 😊


pico-examples pico_w httpd build fails on Windows -- makefsdata.py is generating invalid variable name

When trying to do a full build of pico-examples on Windows, it fails on the httpd example with:
In file included from C:/Program Files/Raspberry Pi/Pico SDK v2.0.0/pico-sdk/lib/lwip/src/apps/http/fs.c:39:
P:/pico-examples/build/pico_w/wifi/httpd/generated/pico_fsdata.inc:199:36: error: stray '\' in program
  199 | static const unsigned char data_img\rpi_png[] = {
      |                                    ^

So there's a \ in the variable name.
The Python script that's generating this file is assuming UNIX-style path separators.
The fix would be to simply use os.sep instead of "/". Let me know if this sounds reasonable and I can open a PR for it.

The code tries to replace invalid characters with "_". I guess it needs to do this for backslash as well as forward slash?
    # make a variable name
    var_name = str(file.relative_to(input_dir))
    var_name = var_name.replace(".", "_")
    var_name = var_name.replace("/", "_")
    data_var = f"data_{var_name}"
    file_var = f"file_{var_name}"

Apologies, I thought I tested this on Windows.

So maybe we can make it a bit more foolproof by substituting something like r"[^a-zA-Z_\d]+" in the string with _ to get valid characters?

...which is exactly equivalent to r"\W" ? https://docs.python.org/3/library/re.html#regular-expression-syntax :wink:

...which is exactly equivalent to r"\W" ? https://docs.python.org/3/library/re.html#regular-expression-syntax 😉

Yep, that would be a good idea, I personally stay away from character classes which morph based on the locale in use -- but I guess r"\w+" with the re.ASCII flag will do nicely in this case.

Has  this problem been resolved
E:/Raspy/pico/pico-examples-eclipse/pico_w/wifi/httpd/generated/pico_fsdata.inc:203:36: error: stray '' in program
203 | static const unsigned char data_img\rpi_png[] = {

Looks like it. Please check the develop branch.

Thanks how do I pull the branch    with git?
On Fri, Nov 1, 2024, 7:45 AM Peter Harper @.***> wrote:

Looks like it. Please check the develop branch.
—
Reply to this email directly, view it on GitHub
https://github.com/raspberrypi/pico-sdk/issues/1793#issuecomment-2451745009,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFPZOBGD4PGSDMYKPF57G43Z6NSXJAVCNFSM6AAAAABMJ3CKV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJRG42DKMBQHE
.
You are receiving this because you commented.Message ID:
@.***>

Thanks how do I pull the branch with git?

To check out the develop branch of pico-sdk into a new directory:
git checkout -b develop https://github.com/raspberrypi/pico-sdk.git

To update an existing git checkout of pico-sdk from master to develop:
git checkout develop
git pull

### new problems using the develop branch
[ 62%] Building CXX object pico_w/bt/pan_lwip_http_server/CMakeFiles/picow_bt_example_pan_lwip_http_server_background.dir/E_/Raspy/pico/pico-sdk/src/rp2_common/pico_cxx_options/new_delete.cpp.obj
arm-none-eabi-g++.exe: error: E:/Raspy/pico/pico-sdk/src/rp2_common/pico_cxx_options/new_dele: No such file or directory
arm-none-eabi-g++.exe: fatal error: no input files
compilation terminated.

Did you do a make clean on your project after switching the pico-sdk branch?

Closing this as it's supposed to be fixed.

Closing this as it's supposed to be fixed.
it is not fixed  still  the same problem using the  develop branch

@Walter1604 the error message you've posted above is different to the error message initially reported in this issue; so it's probably best if you open a new separate issue, with a demonstration of how to reproduce your problem. Thanks.

Ok, I will do that.
On Fri, Nov 8, 2024 at 10:02 PM Andrew Scheller @.***>
wrote:

@Walter1604 https://github.com/Walter1604 the error message you've
posted above
https://github.com/raspberrypi/pico-sdk/issues/1793#issuecomment-2453098333
is different to the error message initially reported
https://github.com/raspberrypi/pico-sdk/issues/1793#issue-2459087398 in
this issue; so it's probably best if you open a new separate issue, with a
demonstration of how to reproduce your problem. Thanks.
—
Reply to this email directly, view it on GitHub
https://github.com/raspberrypi/pico-sdk/issues/1793#issuecomment-2465988174,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFPZOBEOFGXUKU44ASTRZJTZ7VUNBAVCNFSM6AAAAABMJ3CKV2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVHE4DQMJXGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Add resource viewer to storybook

@ibagha JSON for a resource viewer can be previewed through the storybook
Some notes:

Color mismatch when resource is in warning

Same panel above does not auto update with new data
There is no visual difference between implicit and explicit connections
Storybook only: different subcomponents sometimes don't show up. e.g. adding a label component to a node and text component to another results in only one visible at time

Signed-off-by: GuessWhoSamFoo<EMAIL_ADDRESS>

Closing this in favor of using local content instead.

Closing this in favor of using local content instead.


Is there a non async version of the latest release?

This is a great library we Thank you!
Amazon is requiring everyone to stop using PA API 4 and use PA API 5 by March 9th 2020.
Our app uses Nager.AmazonProductAdvertising v1.2.2.
Upgrading to v2.06 does not have the sync methods. (That I can see)
By any chance are there a non async methods for this library available which utilizes PA API 5?
Thank you.

No, it is not available

ok, I assumed so. Thanks for the quick reply.

Hello,
Do you have any plan to develop non-async version api functions?
Because, I have been using old version of  Nager.AmazonProductAdvertising in my web sites.
I tried to use async functions of latest Nager,  but I am not able to do it yet.
So, the simplest solution is to use non-async functions.
I want to know the future plan of Nager.AmazonProductAdvertising project.


Get Player XP?

Is there any way that we can get the player's XP (their total, not their level) through this API?

My npm package supports this via the .inventory.get() method (see get-inventory for an example of how to retrieve all inventory).
For whatever reason, Niantic returns the player stats as an "inventory item"; you can weed it out by doing something like (once you've retrieved the items):
_.each(items, function(item) {
  if (item.inventory_item_data.player_stats) {
    console.log(item.inventory_item_data.player_stats);
  }
});

This yields something like:
Carls-MacBook-Pro:pokemon-go carldanley$ node example.js
{ level: 18,
  experience: Long { low: 182936, high: 0, unsigned: false },
  prev_level_xp: Long { low: 140000, high: 0, unsigned: false },
  next_level_xp: Long { low: 185000, high: 0, unsigned: false },
  km_walked: 42.41663360595703,
  pokemons_encountered: 498,
  unique_pokedex_entries: 67,
  pokemons_captured: 402,
  evolutions: 38,
  poke_stop_visits: 256,
  pokeballs_thrown: 1003,
  eggs_hatched: 45,
  big_magikarp_caught: 4,
  battle_attack_won: 69,
  battle_attack_total: 70,
  battle_defended_won: null,
  battle_training_won: 5,
  battle_training_total: 18,
  prestige_raised_total: 2012,
  prestige_dropped_total: 96000,
  pokemon_deployed: 22,
  pokemon_caught_by_type:
   { buffer: <Buffer 08 01 10 80 80 80 80 b0 83 92 b2 14 3a 5b 0a 40 00 84 ec b5 0f 19 69 6f ff 4c e9 7a 82 60 02 ae 1f de cb 04 cc 5d 4e 3b 28 8a ad 06 bb f1 89 84 dc 3f ... >,
     offset: 5943,
     markedOffset: -1,
     limit: 5964,
     littleEndian: true,
     noAssert: false },
  small_rattata_caught: 2 }

we are working on it


Add password protection in console sessions

It currently asks for a name to log info, but with multiple folks having access any one can use anyone's name. Would be great to have a password issued to each user so they can use to only login using their password.

I was just thinking about this. I don't think console1984 should provide its own authentication mechanism, but it would be nice to be able to plug an existing authentication mechanism. Maybe something like this?
config.console1984.user_authentication = proc do
  username = Console1984.supervisor.current_username # this will use the configured username resolver or ask for a username as needed
  user = User.find_by(username: username)
  raise "Invalid username" if user.nil?
  password = $stdin.getpass("Password: ")
  raise "Invalid password" unless user.valid_password?(password)
  raise "Not an admin" unless user.is_admin?
end

Then console1984 would call the user_authentication callable if it's set, or keep the current behavior if not.
This is a just a rough example, but I'd be happy to submit a PR if the maintainers would be open to such a feature. @jorgemanrubia wdyt?

I like the idea @olivier-thatch 👍

No, sorry, I've been very busy with an ongoing project and probably won't get a chance to work on this in the next few weeks.

I temporarily override the gem to handle it with Devise users
module Console1984
  class Supervisor
    def current_username
      if Console1984.config.ask_for_user_if_empty
        unless @current_username.present?
          email = ask_for_value "Please, enter your email"
          user = ::User.find_by(email: email)
          return raise Console1984::Errors::MissingUsername unless user.present?
          password = ask_for_value "Password: "
          return raise Console1984::Errors::MissingUsername unless user.valid_password? password
        end
        @current_username ||= user.email
      else
        @current_username ||= username_resolver.current.presence || handle_empty_username
      end
    end

    private
    def handle_empty_username
      if Console1984.config.ask_for_username_if_empty
        ask_for_value "Please, enter your name:"
      else
        raise Console1984::Errors::MissingUsername
      end
    end
  end

  class Config
    remove_const(:PROPERTIES) if (defined?(PROPERTIES))

    PROPERTIES = %i[
      session_logger username_resolver ask_for_username_if_empty shield command_executor
      protected_environments protected_urls
      production_data_warning enter_unprotected_encryption_mode_warning enter_protected_mode_warning
      incinerate incinerate_after incineration_queue
      protections_config
      base_record_class
      debug test_mode
      ask_for_user_if_empty
    ]

    attr_accessor(*PROPERTIES)

    private
    def set_defaults
      self.session_logger = Console1984::SessionsLogger::Database.new
      self.username_resolver = Console1984::Username::EnvResolver.new("CONSOLE_USER")
      self.shield = Console1984::Shield.new
      self.command_executor = Console1984::CommandExecutor.new

      self.protected_environments = []
      self.protected_urls = []

      self.production_data_warning = DEFAULT_PRODUCTION_DATA_WARNING
      self.enter_unprotected_encryption_mode_warning = DEFAULT_ENTER_UNPROTECTED_ENCRYPTION_MODE_WARNING
      self.enter_protected_mode_warning = DEFAULT_ENTER_PROTECTED_MODE_WARNING

      self.incinerate = true
      self.incinerate_after = 30.days
      self.incineration_queue = "console1984_incineration"
      self.ask_for_username_if_empty = false
      self.ask_for_user_if_empty = false

      self.base_record_class = "::ApplicationRecord"

      self.debug = false
      self.test_mode = false
    end
  end

  class Shield
    private
    def prevent_invoking_protected_methods
      Console1984::ProtectionsConfig.new(YAML.safe_load(File.read(Console1984::Engine.root.join("config/protections.yml"))).symbolize_keys)
    end
  end
end

Console1984.config.ask_for_username_if_empty = false
Console1984.config.ask_for_user_if_empty = true

A custom resolver worked for us:
config.console1984.username_resolver = CustomResolver

class CustomResolver
  include Console1984::Freezable

  def current
    # user/pass/totp auth here
  end
end

I did a similar approach to @grk, ( at first I forked #116 but the more I read the source code, the more I figured out a built-in approach )
Here is a full example implementation for email/password with devise with comments explaining my "technical" decisions.
# frozen_string_literal: true

# Custom username resolver for console1984 to authenticate
# administrators to production console
module CustomConsole1984
  class UsernameResolver
    include ::Console1984::Freezeable # Inspired by the default resolver provided by the gem.
    include ::Console1984::InputOutput # to access `ask_for_value` built-in helper

    def current
      email = ask_for_value("Please, enter your email:")
      password = ask_for_password
      user = User.find_for_authentication(email: email)

      raise "User with email: `#{email}` not found" unless administrator

      is_valid = user.valid_for_authentication? { user.valid_password?(password) }

     # it's important to return a string representing a username for console1984
     # i recommend prepending with the `id` because the username value will be stored in `Console1984::User` table
     # This will allow to properly distinguish user, and is a safe approach IMO
      is_valid ? "#{user.id}_#{user.full_name.sub(' ', '_')}" : raise("Authentication failed for user `#{email}`")
    end

    private

    # helper to hide password typing, similar to any `sudo ...` command in UNIX.
    def ask_for_password
      puts Rainbow("Please, enter your password:").green

      password = $stdin.noecho(&:gets).chomp until password.present?
      password
    end
  end
end

then in config/application.rb do the following.
 require_relative '../lib/my_path_to_resolver'

config.console1984.username_resolver = CustomConsole1984::UsernameResolver.new # Important to instantiate an instance.

I also wanted to send a slack notification after each successful rails console connection.
Initially I tweaked it inside the username resolver, but it felt dirty, and I also wanted to send the reason
After reading the source code, I found there is a session_logger config ( undocumented option though :/ ) So instead of reinventing the wheel, knowing that I just wanted to augment/enhance the default session logger, I did the following
# frozen_string_literal: true

module CustomConsole1984
  class SessionLogger < ::Console1984::SessionsLogger::Database

    # reopen `start_session` method
    def start_session(username, reason)
      super

      SlackMonitoring::AlertWhenAdministratorConnectsToProdConsole.call(username:, reason:)
    end
  end
end

You can also create your own logger but the interface/contract is a bit heavy, (as well as undocumented :/ ) So I personally recommend my approach 🤷🏼♂
Finally add the following in config/application.rb
# important, this require must be called AFTER `Bundler.require(*Rails.groups)`
require_relative '../lib/my_path_to_resolver'

# ...

config.console1984.session_logger = CustomConsole1984::SessionLogger.new # important to create an instance.


Optimise CSV querying

Trying to run
SELECT
  *
FROM
  csv
LIMIT 1

On a 250MB csv takes >1 minute on my machine.
This might tie into transactions/memory caching in parts.

Running queries on the 250MB file (incl joins and such) can use >10GB of RAM

The RAM issue might have been partly fixed by #25; not sure if much more can be done though.


Missing license info

Hi
Would you mind providing license information for this project/repository?
Thanks!

I am not sure. But feel free to use it commercially. There are no limits basically. I am thinking on MIT, but on the other hand I would like to have ability to have some commercial opportunity in the future.
If only GitHub sponsorship would work I would gladly make everything MIT like most of my other work on Github.


Bugfix: env value_from_input was ignored

In case of Env being specified via value_from_input, the actual value of the value_from_input is ignored and just its not-Noneness is checked. We fix it here to use it. Current buggy state has the unfortunate consequence of having to name the env var the same as the parameter

additionally, would you mind if I add value_from_param, which would make the var resolve to f"{{{{workflow.parameters.{param_name}}}}}" instead? That's something I use quite often as well

@Trollgeir thank you for your message, and apologies for my late reply, and what appears to be a hasty and misguided PR O:)
my original reason for opening the PR was that the Docker images I'm scheduling are expecting some Environment variables with dots in their name -- which is troublesome here, since the current code seems to use the same name for env var and for the param name, and thus a dot in the name gets refused by Argo param name validation
I can't objectively call it a bug, and I can do a workaround via Env(name=dot_param_name), value=f"{{{{workflow.parameters.{sanitize(dot_param_name)}}}}}").
However, I'd be happier if I could specify it in a less {{{{}}}}-manner, but not sure if you guys will think a fix systemic. I can just add some _sanitize_for_argo function that replaces dots with underscore and call it in env.py:L61 and task.py:L710. Does that look legit?
If I get what you say and what the code suggests, I can just do this for global params, right?:
global_param = Param(name=sanitize(dot_param_name), value="<something>")
env = Env(name=dot_param_name, value_from_input=global_param)
create_worklflow(..., global_param, ..., create_task(..., env, ...))

I then agree it makes no sense to add value_from_workflow_param. However, since I'll be touching it, would you mind if I add a dataclass postinit auto validation that complaints if both value and value_from_input is specified? That would seem wrong use to me, right?

my original reason for opening the PR was that the Docker images I'm scheduling are expecting some Environment variables with dots in their name -- which is troublesome here, since the current code seems to use the same name for env var and for the param name, and thus a dot in the name gets refused by Argo param name validation

Ah, nice catch! Yeah this is something I hadn't thought of, and obviously we need to fix.

I can't objectively call it a bug, and I can do a workaround via Env(name=dot_param_name), value=f"{{{{workflow.parameters.{sanitize(dot_param_name)}}}}}").

Great, I hope this will suffice until we get a fix out!

However, I'd be happier if I could specify it in a less {{{{}}}}-manner, but not sure if you guys will think a fix systemic. I can just add some _sanitize_for_argo function that replaces dots with underscore and call it in env.py:L61 and task.py:L710. Does that look legit?

I think that there's an easier workaround than sanitizing the fields. The generated parameters which are used to feed-forward the envs can be called whatever we want. In my initial implementation I just defaulted them to have the same name as the env-variable. However, I think we could possibly just generate some argo-friendly hash values for names, like env-variable-<generated-hash>. Hash could also be a checksum based on the env-name, which guarantees uniqueness. What do you think?

hmmm, the hash thing may be inconvenient for any sort of debugging/troubleshooting -- eg, when you are looking at some workflow that has failed overnight, you often check out the parameters. I always log all the input configuration at the start of the container, so I would not be affected; but I guess some users may be inspecting the params, and this makes it a bit inconvenient
but from implementation PoV/reliability, its definitely a good idea and I like it :) I'd lean toward hash(env_name) than toward say uuid4, to have at least stability in the param names.
maybe a good compromise would be to take first ~32 characters of env, remove all that Argo doesnt like, and append the hash of the original value. This way, you get around the total length limitation and bad characters, you retain some readability, but you dont risk introducing a collision by sanitisation

hmmm, the hash thing may be inconvenient for any sort of debugging/troubleshooting -- eg, when you are looking at some workflow that has failed overnight, you often check out the parameters. I always log all the input configuration at the start of the container, so I would not be affected; but I guess some users may be inspecting the params, and this makes it a bit inconvenient. (The output parameters / global parameters would still have ok names -- but still, it could be nuissance a bit)

Wouldn't it be fairly obvious what ENV it's referencing in the value though?

maybe a good compromise would be to take first ~32 characters of env, remove all that Argo doesnt like, and append the hash of the original value. This way, you get around the total length limitation and bad characters, you retain some readability, but you dont risk introducing a collision by sanitisation

We could, we just need to implement the sanitation function :)

I've put together a simple sanitisation function and used it in this case, let me know if you'd rather see it differently :)


(Bug) Add Locale Detection

Description
Cross-platform locale detection has been added @johnsmith-gooddollar
Also:

The render in case async loading was not yet completed was an important fix to prevent Jest tests from making empty renders, so I added it back in.
Since the catalog.js files are now generated again every time the project is build I have added them back to .gitignore.

@alecsantos96  already implemented, closing it
Please fix the following bugs ASAP

https://github.com/GoodDollar/GoodDAPP/blob/master/src/components/invite/Invite.js
and the similar issue is possible here:
https://github.com/GoodDollar/GoodDAPP/blob/master/src/components/browserSupport/components/UpdateIOS.js

@alecsantos96 i tried to fix \n but got this. please apply the correct fix
P.S. add me to thew Telegram () or Skype alex_cyberneticist

P.P.S. please also fix the tests being failing


v3.0.0 tag is missing

There seems to be no v3.0.0 on this page, did you forget to create a tag?
https://github.com/librariesio/semantic_range/tags

Also I'd like to see some Changelog or GH release description with changes.


dvc: 3.56.0 -> 3.57.0

https://github.com/iterative/dvc/releases/tag/3.57.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 359295

x86_64-linux

:white_check_mark: 26 packages built:

dvc (python312Packages.dvc)
dvc-with-remotes
dvc-with-remotes.dist
dvc.dist (python312Packages.dvc.dist)
python311Packages.dvc
python311Packages.dvc-gdrive
python311Packages.dvc-gdrive.dist
python311Packages.dvc-hdfs
python311Packages.dvc-hdfs.dist
python311Packages.dvc.dist
python311Packages.dvclive
python311Packages.dvclive.dist
python311Packages.mmcv
python311Packages.mmcv.dist
python311Packages.mmengine
python311Packages.mmengine.dist
python312Packages.dvc-gdrive
python312Packages.dvc-gdrive.dist
python312Packages.dvc-hdfs
python312Packages.dvc-hdfs.dist
python312Packages.dvclive
python312Packages.dvclive.dist
python312Packages.mmcv
python312Packages.mmcv.dist
python312Packages.mmengine
python312Packages.mmengine.dist


Added 2captcha support

solves CAPTCHAs at runtime

I updated it again and improved the error handling

Instructions to test this PR (as we have to low CAPTCHA rates):

[ ] open your scan.py https://github.com/evenly-epic-mule/pokeminer/blob/3cf34beccc82f2ef1a4a66002f8ef8d272c4a90f/scan.py#L271
[ ] replace if account.get('captcha'): with if False and account.get('captcha'):

=> now all accounts will be added to the extra queue
as soon as Pokeminer uses one of the CAPTCHAed Accounts, it will notices that it has a CAPTCHA on it and tries to solve it

I tested and works fine :)

Heh, I merged this locally before you rebased it just now, now GitHub is confused.


Clear Chat Window Button doesn't do its job...

The "Clear Chat Window" button clears the chat window, but the chat history reappears when the user sends a new query. I need to fix this so the button functions properly.

fixed issue wasnt clearing model outputs


zero width non-joiner (ZWNJ) renders as its Unicode codepoint <200c>

This problem is already reported here but the conceal solution has side effects and is not desired. The Gnome terminal with BiDi support renders ZWNJ correctly but when I run Vim inside Gnome terminal, it shows ZWNJ as <200c> using the same font; I use Vazir font in the screenshots but the same happens with the ubiquitous  Liberation Mono font.
The word فارس‌ی in Gnome Terminal:

The same word in Vim run inside Gnome Terminal:

To reproduce type or copy/paste the word س‌ی  in both the Gnome terminal and Vim to see the differences. A ZWNJ resides between the letters س and ی.

I can reproduce that.

duplicate of #204

I don't think it's a duplicate. Support for special Unicode character is a different issue from Bidi rendering, despite some overlap (It's better to divide a big topic like bidi into smaller problems anyways). I'd prefer to keep the discussion here to avoid hijacking the original issue.

I think there is a solution that is a middle ground. Not complete conceal and not conceal that replaces with whitespace either.
I just noticed this behavior while editing a Vim help file (syntax.txt): Lines such as:
TEX				*tex.vim* *ft-tex-syntax* *latex-syntax*

have conceal for asterisks * that are not shown unless in Visual or Insert mode.

That is concealing

It is a stronger type of concealing I just realized is possible in Vim. The conceal I'm used to, at least in LaTeX and Markdown, is that characters are unconcealed as soon as the cursor is in the same line with them. This is not the case with help filetype. They are unconcealed only in Visual and Insert modes, and they're not replaced with whitespace characters.
Would it be possible to ship a solution like the one you provided: https://vi.stackexchange.com/questions/17900 to be the default with Vim? Perhaps toggle-able behind a command similar to :list. ZWNJ is not the only Unicode control character. There are dozens more: https://en.wikipedia.org/wiki/Category:Control_characters

@faridcher you mentioned that "conceal solution has side effects and is not desired". Can you clarify what these unintended side effects are?

@avidseeker it hides certain markups. This is of paramount importance while editing plain text dominant files like TeX (as opposed to a programming language). Imagine you had to toggle conceal mode to properly see character "a" in English. The ZWNJ in plain text (conceal=0) is great both for editing as well as reading.

Conceal hides markup? Can you give an example .tex document?
I think Vim should already have a selective conceal where  is hidden but markup is not.


pyenv: deactivate: command not found

Today, I get a strange error as above when I create a Python VirtualEnv by
$ mkvirtualenv Django

with virtualenvwrapper.sh installed in python userbase directory. I don't know what happened. This error can be eliminated by using virtualenv.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/27600987-pyenv-deactivate-command-not-found?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F282009&utm_medium=issues&utm_source=github).

There is a activated one before already?

No, I think. If there was an activated one of python virtualenvs, the deactivate command should make it exit. However, it reports the same error after executing deactivate command. In addition, it works well if  workon  is executed firstly and then deactivate it.

not an issue of pyenv.


Update databricks-sentiment-analysis-cognitive-services.md

Hi, I'm the author of the Spark Event Hubs connector. Just updating it the latest version :)

@sabeegrewal looks good! #sign-off


try out Anthropic models

ideally, we'd make it possible to swap them easily

see https://github.com/the-full-stack/ask-fsdl/tree/charles/anthropic-models
swapping won't be easy -- will need a separate final prompt for each model, based on rejiggering from a shared base (for sanity's sake).

this is a great opportunity to do a model eval -- maybe as a wandb report


Item translations aren't reloaded after lang switching

when opening the sidepanel and updating a value in english and then saving
if you toggle to french and then toggle back to english you dont end having the most update to date value

Originally posted by @nasouh94 in https://github.com/plank/laravel-media-manager/pull/95#pullrequestreview-1108066670

@nasouh94 does it cache it somewhere in the frontend or does it make an api request on every toggle?

@a-drew even if you close the MM and reopen it, it will display the old value so it is being cached in the MM somewhere. It is not doing an API request on every toggle but maybe it can just make sure to update the cached object once changes have been submitted

@rileymcmaster @a-drew if i remember correctly a request only fires on page load thats why closing the MM wouldn't do much. I think you're approach Riley with updating the object based on the response of the submission request might the way to go.


Bug fix and refactor

Solved #78
Refactored printProgress, now it's called put and it works using a switch case.

Solving #60 too

We could call it puts


how to format 'in press' articles?

Hi,
I'm wondering how I should format JSON file to allow citation.js to show in press articles properly.
Thanks!

The status property should be set to "in press".

Thanks! It works!


says Cannot connect. Is the API-Key correct and the internet connection working? when trying to set it up

says Cannot connect. Is the API-Key correct and the internet connection working? when trying to set it up

I'm also getting this error. Super frustrating as I just fixed my instance.

I am getting the same. I even applied for a new API Key because I thought it was invalid. I verified that I have internet on my homeassistant instance by opening a terminal and pinging google and curling icanhazip.com and it returned my public IP.


⚠ Elibs has degraded performance

In b8278bd, Elibs (https://elibs.unmer.ac.id) experienced degraded performance:

HTTP code: 200
Response time: 6732 ms

Resolved: Elibs performance has improved in 6fbd842.


Add Haskell support

Description

Added a Haskell section to show the version of GHC being used by Stack. Imitates spaceship-prompt's implementation.
Also fixed a typo in docs/Options.md (s/SHIP/FISH).
Motivation and Context

Brings parity between spaceship-prompt and spacefish regarding Haskell support.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

[x] I have tested using MacOS
[ ] I have tested using Linux

Checklist:

[x] I have checked that no other PR duplicates mine
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have updated the tests accordingly.

Happy to help! 😄


feat: Support first order types

Add first order types support like ZIO Prelude's wrapAll and variants (option/either/unsafe/...) as well as equivalent methods for RefinedTypeOps and ...Further.
Support for Cats' Functor and ZIO Prelude's Covariant and documentation are still in WIP.
Closes #202

@ajaychandran I chose to name the methods with the suffix All instead of F for two reasons:

I find it clearer (tho it can be a bit less intuitive for single-value containers like Future, Option, IO etc...)
Names with F are sometimes confusing. For example, the first order version of refineFurther becomes refineFFurther vs refineAllFurther (`refineFurtherF is less confusing but it does not looks very natural to me).


PRL618-Add-Case-Number

Before creating a pull request make sure that:

[X] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
PRL-618 Add Case Number
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

Closing 103 and will create a fresh one.


GLIBC_2.38 + plugins version issue.

Describe the bug

I cannot use both the webhook nor the postgres sinks as they complain about
/lib/x86_64-linux-gnu/libm.so.6: version GLIBC_2.38' not found (Looks a lot like #271)

Plugins can't be listed/removed after install

To Reproduce

Install abipara cli from scratch
Install webhook (v0.5.0) and/or postgres (v0.6.0) sink plugins with the cli
Problem 1: run a script using one of these plugins, see the error above.
Problem 2:

$ apibara plugins list =>
Error: cli operation failed
├╴at cli/src/plugins.rs:257:10
├╴Plugin --version output does not match spec
╰╴Failed to get plugin version: apibara-sink-webhook
$ apibara plugins remove sink postgres
Error: cli operation failed
├╴at cli/src/plugins.rs:257:10
╰╴Plugin --version output does not match spec
Expected behavior
No error :)
Software

OS: Ubuntu
Version 22.04.3
Apibara version 0.4.2
Programming language and version (Rust, Cargo, Typescript) : TS

Additional context
edit: nothing, it was unrelated.

We definitively need to support Ubuntu 22.04 which ships with glibc 2.35.

I made a new release that fixes this issue. Feel free to reopen if that's not the case.
BTW it's the first time I hear about the issue with the cursor, so if it happens again open an issue for it and I'll take a look!


Move css-band-aid fork to bless

Brings the latest changes from css-band-aid back to bless. This converts the src from CoffeeScript to ES6 using Babel as its transpiler.
Should address #44, #37, #45, #38, #33, #27, and #8
It doesn't auto merge at the moment, but this PR does contain a lot of changes...

The v4 branch is currently comprised of the following:

cli
importer
parser
reporter

The importer, parser, and reporter all have specs and it would be great not to lose those.

I think those are new since we forked, I'll take some time to review those and see how well they port over.

It would be good if everything in src/ (maybe not cli stuff) had an equivalent spec file.
I think the documentation / comments on v4 are valuable too.

Ideally I would think that once this is merged to the v4 branch, we just merge it to master and cut the v4 alpha release, then iterate from there. It would be nice to have the v4 release out within the next week. Then we wouldn't have to worry about explicit v4 docs since it would be the latest published version.

I agree about the testing aspect, we could have done more unit tests as opposed to integration there than we did.
I think the parser tests are encapsulated here:

https://github.com/css-band-aid/css-band-aid/blob/master/test/chunkFile.js
https://github.com/css-band-aid/css-band-aid/blob/master/test/cli-chunker.js

They could use some better names, but they are both higher level integration tests.
We didn't get around to adding tests for the count reporter so yes that is also lacking at the moment.

I'm thinking that reporters will need a little more thought since the cli tool is doing two different commands and both would need different reporters. I like your direction to make the reporter more pluggable; I think it's worth looking at but I think that could happen in a follow on PR.

I like your direction to make the reporter more pluggable
That decision was guided by being able to write unit tests for an external reporter

I think it's worth looking at but I think that could happen in a follow on PR
Could we create issues for any regressions?

I still see the value in our current integration tests, so perhaps we could migrate those over an integration folder for now. I agree that there is an absence of low-level unit tests, but I don't think those should stop an alpha release. We'll create an issue/multiple issues for the missing unit tests.

@paulyoung Do you have anything else you wish to address with this?

Do we need to commit the source maps in the fixtures? I can't imagine they're being used for anything.

It doesn't look like it so I think we should probably remove and ignore them.

They are needed, we are using them as expected output when source maps are turned on from the cli engine here: https://github.com/css-band-aid/css-band-aid/blob/master/test/cli-chunker.js#L41
They are generally obscure so they have been checked manually, then we just check that the output remains the same as the last time we manually checked that the source maps were working.

Do you have any other concerns @paulyoung?

@mtscout6 :ship:

Merged to master in 7cd3a194518b7eaa65b9f8b12c897356feb45a39


chore: add dev env to doppler:pull:dev

:tada: This PR is included in version 1.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


ENYO-2258: Defer reflow when hidden, do it when shown

Reflowing a Control when it's hidden generally doesn't make sense,
since a) it's wasteful to spend cycles laying out something that
can't be seen; and b) the layout may depend on measuring the
Control's children, and they can't be accurately measured if
they're not showing.
We therefore defer reflow in the case where we're hidden, and
wait until we're shown.
In the case where we are explicitly hidden (i.e., showing is
false), we defer immediately. We can't inexpensively detect the
case where we're showing but an ancestor is hidden, so to handle
that case we rely on the layout to do its measurements and let
us know (by returning true) if we need to reflow again the next
time we are shown.
Enyo-DCO-1.1-Signed-Off-By: Gray Norton<EMAIL_ADDRESS>

I think there is an easy way to make cases where the ancestor is hidden more readily detactable.
Whenever a Control changes it's showing state, it waterfalls an onShowingChanged event to it's descendants. Currently, this event is not propagated when it runs into a hidden descendant.
Instead of stopping propagation and doing nothing, you could send a new event that lets descendants know they're hidden instead.
For example:
showingChangedHandler: function(inSender, inEvent) {
    if (inEvent.showing && !this.getShowing()) {
        // Send new accurate event.
        this.sendShowingChangedEvent();
        return true;
    } else {
        // Proceed waterfalling unchanged
        return false;
    }
}

This probably requires a little coordination to work well in combination with the absoluteShowing property, but it should work. I've got an imperfect - but considerably better than nothing - version running in enyo 2.4 that's doing a pretty decent job.
By the way, you could use a task queue to defer all kinds of actions when a component isn't showing. Aside from reflows, animations could also be deferred and/or fast-forwarded.


searchEntry attributes type is private

  const parsedAttribute = entry.attributes.map(
    (attr: ldapjs.Attribute) => {
      let field: Field = {
        key: attr.type,
        val: attr.vals as string[],
      };
      return field;
    },
  );

when I needed to check whether object has desired attributes I couldn't read it's type - Attribute class is written by default:
    private type: string;
    readonly buffers: Buffer[];

    /**
     *  Array of string values, binaries are represented in base64.
     *  get: When reading it always returns an array of strings.
     *  set: When assigning it accepts either an array or a single value.
     *       `Buffer`s are assigned directly, any other value is converted to string and loaded into a `Buffer`.
     */
    vals: string | string[];

    readonly json: AttributeJson;

    /** Stringified json property */
    toString(): string;

    static isAttribute(object: any): object is Attribute;
    static compare(a: Attribute, b: Attribute): number;
}

I recommend switching type's access to readonly or create getter in order to avoid such situations

What is this?

wrong package, my bad - need to type guys from types/ldapjs

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


Add new or with_capacity for std lists

With the current set of list operations in std.collections, creating a new list requires loading a constant empty list and pushing elements in a loop. Should we have a new_list operation?
Alternatively, we could have some new operation that creates an new empty list, but tries to pre-allocate memory for a given number of elements.

usual question - ops or standard library? given allocation will be done via the ptr extension, I suspect these are standard library functions.


exclude disks with "none" for the filesystem

http://cloudly.dracon.biz/server/06-af-cd-3f-a9-98/

done


[bug]: Trained textual inversion triggers not found

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Linux
GPU vendor
AMD (ROCm)
GPU model
RX 6700 XT
GPU VRAM
12GB
Version number
3.6.2
Browser
Firefox 122.0
Python dependencies
No response
What happened
Attempted to use my custom trigger <trainingTest>, but it was not recognized. The log files only show this:
Warn: trigger: "<trainingTest>" not found
What you expected to happen
To be able to select the embedding from the list
How to reproduce the problem
Train a set of images using the invokeai-ti command. Upon completion, load up the main web UI, and try using the trigger.
Additional context
The training completed without issue, and I do have a file located in invokeai/embeddings/trainingTest/learned_embeds.bin
Discord username
No response

Closing this for the following reasons:
I was following the training guide listed https://invoke-ai.github.io/InvokeAI/features/TRAINING, which I have been informed is now deprecated. Instead the separate training project https://github.com/invoke-ai/invoke-training should be used.
This appears to be a duplicate of https://github.com/invoke-ai/InvokeAI/issues/4305
The previous configuration of the embeddings folder no longer exists, and is meant to be replaced with the autoimports/embeddings folder. Dropping the files there works correctly.


Simplification of "add" methods

Most of the classes have a long list of "add_this()", "add_that()" methods. Since Python makes introspection very easy, couldn't we replace all of these with a single "add()" method per class, which would do the right thing based on the object type?
This would greatly simplify the API and make it easier for users.
For example:
doc = NeuroMLDocument(id="my_doc")
net = Network(id="my_net")
doc.add(net)   # instead of doc.add_network(net)
pop = Population(...)
net.add(pop)   # instead of net.add_population(pop)

Functionality like this is best added in the helper_methods.py. Should be straightforward to add it to the core classes there, and so enable @apdavison's suggestion in the first comment
Adding "Help required" label for anyone interisted in contributing...


completeFunctionCalls does not work properly with commit characters

It looks like the autocompletion is broken. At least, it's pretty annoying.

VSCode Version: VSCode 1.9.0
OS Version: macOS Sierra

Steps to Reproduce:

Create a new javascript file
Start typing console.log and press the ( key. It will autocomplete to the following.

console.log((message), optionalParams)

I also don't want the autocompletion kicking in because it's really annoying. I don't want to always remove the , optionalParams manually. It works counter productive in my opinion.

Not for me:

I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

Still failing here. Another use case where it is failing.

I removed all my custom keybindings as well, no dice.

@SamVerschueren We change how suggestions can be accepted when typing certain commit characters, like ( which should accept a proposal and insert that character. Other samples are . or ;. Because they are very context sensitive (function, statement, member) the extension can now define that.
I assume this is in TypeScript - fyi @mjbvz
If this is getting to annoying you can turn this off with the acceptSuggestionOnCommitCharacter setting

Also, are you using the TypeScript setting to insert function completions with parens and params filled in?

@jrieken Aha, I found out that I had added this rule to my settings.json
"typescript.useCodeSnippetsOnMethodSuggest": true

I turned it off and things seem to work fine now. This happened both in JavaScript and TypeScript.

That could impact this but I have issues reproducing this. @mjbvz I am not able to use useCodeSnippetsOnMethodSuggest anymore. I see some guard have been added, but the simple test (console.log) fails for me...

@jrieken Are you using macOS as well? Not sure if I can run a command to show more details of my system that might be of interest.

Ok, I was able to reproduce. This is what happens step by step:

use "typescript.useCodeSnippetsOnMethodSuggest": true
type console.log
see log being suggested, type (
the suggestion inserts log(message, optionalParams) and put the cursor around message because the suggestion is a snippet
because ( was a commit character we still insert it at the start of the selection
because ( is also an electric character we also insert ) at the end of the selection
:bug: log has been completed to log((message), optionalParams)

@mjbvz We shouldn't make ( a commit character when the suggestion is also being inserted as method/function/ctor snippet.

Wow, thanks for looking into this @jrieken! Much appreciated!

@jrieken Similar behavior exists in 1.8 when you type a . to complete a method signature. You'd end up with something like console.log(.)
I think we need to make useCodeSnippetsOnMethodSuggest or the completion items smarter in these cases. Or we could rethink the entire flow so that only ( completes a method signature when useCodeSnippetsOnMethodSuggest is enabled. The current behavior of useCodeSnippetsOnMethodSuggest just feels broken in  many instances today.

@mjbvz I added this rule to my keybindings.json which prevents the . from doing that.
{
		"key": ".",
		"command": "-acceptSelectedSuggestion",
		"when": "editorTextFocus && suggestWidgetVisible && suggestionSupportsAcceptOnKey && editorLangId == 'typescript'"
	}

Yes, we should turn off commit characters when completing a method/function/ctor with its invocation.  Agreed, this was already bad in 1.8 but now it's worst because we added ( as commit character and only since the latest api tweak you can actual have instance-based commit characters.
I would still push this the Jan recovery release because it is a regression that makes the feature unusable, tho arguable no one uses that feature anyways

Thanks @jrieken ! If there's anything I can help you with like testing the nightly build, let me know!

Autocomplete for java is also not working. For java, (,[,{,'," none of these auto complete anymore in MacOS Sierra 10.12.3. On my windows 10 After I closed folder, and restarted VSCode it worked once. Now it doesn't work at all, even after closing folder and restarting.

Removing milestone. Will do this whenever #42544 is completed

Moving to https://github.com/microsoft/TypeScript/issues/51758


Feature Request: Announce "best lap time"

Would be very simple and useful if a new best lap was announced

I guess it should work across all results of all pilots for a current race. Do you see the same?

I was thinking each pilot would be notified if they have a new personal lap record.
A best lap of the day across all pilots would also be good.
Also it's sometimes hard to hear the first beep as your cross the line for the first time - maybe a double beep would be preferable.


Text input on iOS/Safari is broken when using VoiceOver

Users can't interact with a text input using VoiceOver on iOS/Safari. The logic that updates the text field's state is broke when we switched to shadow dom.
The current logic uses domDocument.activeElement == editableElement to determine if the input field currently has focus, but this condition always returns false. We have to use flutterViewEmbedder.glassPaneShadow!.activeElement in order to get the active element instead of domDocument.activeElement throughout the update() function.
https://github.com/flutter/engine/blob/4cb5be089e587d71bf9b283cb72d21668baf81be/lib/web_ui/lib/src/engine/semantics/text_field.dart#L365-#L392

Update: After some investigation I realized that the issue is not completely related to domDocument.activeElement. We still need to update the code at some point, but replacing domDocument.activeElement with flutterViewEmbedder.glassPaneShadow!.activeElement does not automatically resolve the issue of the keyboard not showing up.


ISPN-13315 Support PEM files as key/trust stores

https://issues.redhat.com/browse/ISPN-13315
Depends on an unreleased version of Elytron with https://issues.redhat.com/browse/ELY-2212

@tristantarrant Actually if you're good with the doc suggestions I can go ahead and merge.

You cannot merge, because we need an Elytron release


Upgrading to higher version of typescript

Hey,
thank you for putting this together. I had some difficulties get it running with the latest version of vue. Upgrad Typescript to something over 4.3.5 solved the issue.
With kind regards.

Hey @reyemb ,
Feel free to push a PR with the versions that worked for you so that I can merge
Have a nice day
Fanilo


Correct config_defaults.yaml filenames

The actual default config filename is config_default.yaml, but the documentation says config_defaults.yaml. Took me a bit to figure out what I was doing wrong!

Oops! Thank you for catching this.


Rotated Ellipse and Rectangle annotations resize and move controls not working correctly

Rotated Ellipse and Rectangle controls not working.
When annotating Image tasks using an ellipse or rectangle label, I have noticed the resize controls do not work as expected anymore. Also moving them around seems snappy and sometimes they do not move at all.
I am running on Label Studio 1.4, with the latest changes pulled from the master branch
To Reproduce
Here is my Labeling Config
<View>
  <Header value="Select label and click the image to start"/>
  <Image name="image" value="$image" zoom="true" zoomControl="true" rotateControl="true"/>
  <EllipseLabels name="ellipse" toName="image" opacity="0.9" choice="multiple">
    <Label value="Ellipse" background="#06c44c"/>
  </EllipseLabels>
  <RectangleLabels name="tag" toName="image">
    <Label value="Rectangle" background="blue">
    </Label>
  </RectangleLabels>
</View>

Use the above code as your labeling config
Try labeling any image
Rotate the annotation and try resizing it or moving it around
See the error

Expected behavior
Resizing and moving should work normally when rotated or not.
Screenshots
https://user-images.githubusercontent.com/38419676/151362131-e24e0a03-e733-46a1-ab6c-5979f7b2bdfe.mp4
https://user-images.githubusercontent.com/38419676/151362146-448410d1-be43-42fa-9325-3169128d6ccd.mp4
Environment:

Arch Linux 64 bit
Label Studio Version 1.4 (Installed directly from github)

DEV-1155

Max Tkachenko commented: test text


make jQuery optional

unminified, jQuery is ~50% of a simple brisket app's client side bundle. right now it's a required dependency on the server and client for Brisket. if jQuery is optional, user has the option to save 250k from client side bundles.

based on https://github.com/jashkenas/backbone/pull/3542 and several experiments, the only way to make jQuery optional in a browserify or webpack bundle is to ignore it when invoking the bundler. for this issue, best we can do is remove brisket dependence on jQuery i.e. don't use jQuery methods directly or indirectly.
the two places that do that are https://github.com/bloomberg/brisket/blob/master/lib/application/Backbone.js#L13 and placement methods in https://github.com/bloomberg/brisket/blob/master/lib/viewing/ViewRelationship.js


--no-color should be the default

I was using this plugin in our deployment pipeline and with the latest update the --no-color broke our automation as we didn't know we need to explicitly turn it off since we are piping through jq.  IMO by default the color should be off, to where you have to explicitly turn it on.
Just a thought

@jwhitcraft, it makes sense to turn the colour off by default. I'll do the necessary changes.

@jwhitcraft, I again thought about not setting the colour by default. The colouring is targeted mainly at the ones who execute it locally. If we turn off the colour by default, it hampers the local execution.
For automations such as your use case, we can still set the flag --no-color.

Makes sense, can the readme be updated to show all the options for the command then?  Currently --no-color isn't listed there.

The cli document is updated with all available commands and flags here


related logs and other features

I have some question like:-
1.Can twilio provides a trigger until participant didn't;t join or we use "TVIRoomDelegate" for this?
2.Can we have chat option available during audio as well video call (one to one and Group chat)?
3.Is twilio provide call logs?
4.Can we start recording during call or when we stared from?
5.Can we join user anonymously as observer without participant?
please attached link for iOS app
Thanks

In response to your questions:

1.Can twilio provides a trigger until participant didn't;t join or we use "TVIRoomDelegate" for this?

The func room(_ room: TVIRoom, participantDidConnect participant: TVIRemoteParticipant) delegate method is called when remote participants join the room. From your question, it appears that you are looking for a notification that a remote participant did not join the room? Am I reading that correctly?

2.Can we have chat option available during audio as well video call (one to one and Group chat)?

You should be able to use Twilio Programmable Chat alongside the TwilioVideo.framework in your application.

3.Is twilio provide call logs?

Yes, you can access the Room Logs from your Twilio account by heading to the following page: https://www.twilio.com/console/video/logs/rooms/

4.Can we start recording during call or when we stared from?

There is currently no iOS API to turn on recording during a call. You can do a couple things to enable recoding when a room is created, however. The first is to enable recordings for all rooms. This is done in the Twilio Console from the Room Settings page. In the Default Settings section you can specify that Recording is enabled. Therefore all rooms will have recordings enabled when participants join the room. The other thing you can do is create the room via the REST API and set the RecordParticipantsOnConnect parameter to true. Using this method you could decide when creating specific rooms that you want it to be recorded. You can see the REST API documentation for further information. An important note is that recordings are only supported for Group rooms.

5.Can we join user anonymously as observer without participant?

All connections to the room will cause a participant to be added to the room. To act as an observer, the joining participant just wouldn't share their local audio and video tracks. This would allow the observing participant to receive the other audio and video tracks without publishing any of their own tracks.
I hope this answers your questions. Let us know if you have any further questions.
Ryan

@paynerc
Thanks for response I got your points and first is exactly what I m looking for?
3.Is twilio provide call logs?
Yes, you can access the Room Logs from your Twilio account by heading to the following page: https://www.twilio.com/console/video/logs/rooms/
So can we saw in my iOS app?

@paynerc
Any update?

@paynerc  please close it.