Unable to increase the MaxDepth of the JSON Serialization (Newtonsoft)

I have used the Bot Framework Composer to build my bot. It is based on DotNet (TargetFramework: netcoreapp3.1). Details of the Composer version I use: Version: 2.1.1, Electron: 8.2.4.
In addition to enabling Slack, Skype and Teams, I have enabled Webex too via Bot.Builder.Community.Adapters.Webex adapter.
I get the error below whenever my DialogStack exceeds a certain nested limit:
The reader’s MaxDepth of 64 has been exceeded. Path ‘DialogState.dialogStack.$values[0].state._adaptive.actions.$values[0].dialogStack.$values[0].state._adaptive.actions.$values[0].dialogStack.$values[0].state._adaptive.actions.$values[0].dialogStack.$values[0].state._adaptive.actions.$values[0].dialogStack.$values[0].state._adaptive.actions.$values[0].dialogStack.$values[0].state._adaptive.actions.$values[0].dialogStack.$values[0].state._adaptive.actions.$values[0].dialogStack.$values[0].state.options.choices[0]’.
I debugged a little and found that whenever the nesting level of dialogStack exceeds 8 in conversation.DialogState, the I get into the error above. From various documentations, I understood that I can overwrite this limit to a larger value by adding the below line in the ConfigureServices method of the Startup Class (Startup.cs).
services.AddControllers().AddNewtonsoftJson(options => {
options.SerializerSettings.MaxDepth = 256;
});
However, the above ended up not solving my issue. Any quick help will be highly appreciated.
Notes:

I have this package reference in my csproj file: PackageReference Include="Microsoft.AspNetCore.Mvc.NewtonsoftJson" Version="3.1.20"
I written a couple of custom functions which require me to use the below:
using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using Newtonsoft.Json.Serialization;

@ramfattah can you verify that the snippet shown in the readme notes is correct. Thanks.
https://github.com/microsoft/botbuilder-dotnet/releases/tag/4.17.1

Thank you @johnataylor.
I tried a similar one (without the AddHttpClient()). After your response, I tried your code snippet and it did not work. The entire Startup.cs is pasted below. I tried with a higher value like 128 too, which didn't work either.
`
using Microsoft.AspNetCore.Builder;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.StaticFiles;
using Microsoft.Bot.Builder.Dialogs.Adaptive.Runtime.Extensions;
using Microsoft.Bot.Builder.Integration.AspNet.Core;
using Microsoft.Extensions.Configuration;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Hosting;
using Bot.Builder.Community.Adapters.Webex;
using System;
namespace ComplianceCowBot
{
public class Startup
{
public Startup(IConfiguration configuration)
{
Configuration = configuration;
}
    public IConfiguration Configuration { get; }

    // This method gets called by the runtime. Use this method to add services to the container.
    public void ConfigureServices(IServiceCollection services)
    {
        services.AddHttpClient().AddControllers().AddNewtonsoftJson(options =>
        {
            options.SerializerSettings.MaxDepth = HttpHelper.BotMessageSerializerSettings.MaxDepth;
        });
        services.AddSingleton<IBotFrameworkHttpAdapter, WebexAdapter>();
        services.AddBotRuntime(Configuration);
    }

    // This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
    public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
    {
        if (env.IsDevelopment())
        {
            app.UseDeveloperExceptionPage();
        }

        app.UseDefaultFiles();

        // Set up custom content types - associating file extension to MIME type.
        var provider = new FileExtensionContentTypeProvider();
        provider.Mappings[".lu"] = "application/vnd.microsoft.lu";
        provider.Mappings[".qna"] = "application/vnd.microsoft.qna";

        // Expose static files in manifests folder for skill scenarios.
        app.UseStaticFiles(new StaticFileOptions
        {
            ContentTypeProvider = provider
        });
        app.UseWebSockets();
        app.UseRouting();
        app.UseAuthorization();
        app.UseEndpoints(endpoints =>
        {
            endpoints.MapControllers();
        });
    }
}

}
`

Thanks for the update @RamkumarManavalan.
We are investigating further.

Any updates, team? Thanks.

Can you try SDK version 4.19.1?  There were some MaxDepth issues corrected in 4.19.0.  You'll likely have to edit the csproj directly.

Hi @RamkumarManavalan,
Have you had a chance to update the Bot.Builder NuGet packages to 4.19.1 to see if that fixes this issue?

@RamkumarManavalan please reopen this if you are still having problems. Thanks.

Hi @RamkumarManavalan,
Have you had a chance to update the Bot.Builder NuGet packages to 4.19.1 to see if that fixes this issue?

updating the Bot.Builder package to latest version resolved the issue for me

@tracyboehrer @johnataylor @RamkumarManavalan @rampaged @SanKumar0632 ,can some one help me how to update the Bot.Builder , i am having issues in the bot composer, Thanks!!

@Madhav980 If you are using DotNet, then update the csproj Microsoft.Bot.* packages to the latest version 4.21.2.  If you are still having problems, open a new issue in this repo.


Option to switch between the Ballerina SDK versions in the VSCode status bar

Description:
Since different users are using different Ballerina versions, and a single user might be working on different Ballerina versions at the same time, it would be better to have an option to select the appropriate Ballerina SDK by clicking on the status bar.
This will be also useful to easily capture the version when a user is reporting an issue.
The following depiction is from the vscode-python.

Suggested Labels:
Area/Settings , Type/Improvement
Suggested Assignees:

Affected Product Version:
sl-alpha-1
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

Moved to https://github.com/wso2/ballerina-plugin-vscode/issues/31


Add common dicts and an expression for multi-year

Pull request details
Describe the changes made in this pull request
This PR is meant to add some common sets/expressions that prepares for the parallel work for multi-year:

Add a dict for investable years per asset
Add a dict for pairs of (year, asset) of starting years
Add an expression to incorporate the above-defined two dicts. This is not yet complete, but it sets a base that allows @datejada and me to branch for there.

List of related issues or pull requests
Closes #778
Collaboration confirmation
As a contributor I confirm

[ ] I read and followed the instructions in README.dev.md
[ ] The documentation is up to date with the changes introduced in this Pull Request (or NA)
[ ] Tests are passing
[ ] Lint is passing

@datejada I want to mention that this expression is currently defined for a in Ai[y], which is only true for the accumulated investments. However, for the final expression we want, it should be for a in A, because we need to consider initial capacity as well (they don't have to be investable). I don't see it directly how to do this. Maybe we can discuss further, or if you will do something just let me know.
@abelsiqueira this PR is done by @datejada and me together, it is currently doing what we want, but we are not sure if there are better ways to code it. Do you have any suggestions?

@datejada I want to mention that this expression is currently defined for a in Ai[y], which is only true for the accumulated investments. However, for the final expression we want, it should be for a in A, because we need to consider initial capacity as well (they don't have to be investable). I don't see it directly how to do this. Maybe we can discuss further, or if you will do something just let me know.
@abelsiqueira this PR is done by @datejada and me together, it is currently doing what we want, but we are not sure if there are better ways to code it. Do you have any suggestions?

Thanks @gnawin, I agree, the expression should be on A rather than Ai, but it is fine, I will take of it once I start my part since this expression if for the simple formulation 😉


Inspiration from Concurrent ML / Hopac

Moved from https://github.com/scalaz/scalaz/issues/1868
Hello,
I've witnessed with great excitement the recent development in effect-full/asynchronous programming, like the IO monad in scalaz by @jdegoes (and other Scala libs). Also, the need to work around the lack of green threads is pressing in other languages. I've been reading @wingo 's path to implement concurrency in Guile (and Lua) -- he drew inspiration from Concurrent ML. Indeed it seems like, although it has a branding problem, Concurrent ML is what smart people recommend/use.
So my question would be, if there is something we could learn from CML or, more specifically, Hopac (which is a CML inspired library for F#)?
There's this hierarchy like
                           Job<_>
                            |
                           Alt<_>
                            |
      +-------+--------+----+-----+--------+--------+
      |       |        |          |        |        |
     Ch<_>  Latch   Mailbox<_>  MVar<_>  Proc   Promise<_>
                                                    |
                                                  IVar<_>

The most interesting types there are MVar, IVar and Channel. In Scala(z) it could be described by a typeclass hierarchy like
trait AutoCloseableAsync[C, M[+_, _]] {
  def close(c:C): M[Exception, Unit]
}

trait CloseableAsync[C, M[+_, _]] extends AutoCloseableAsync[C, M] {
  def close(c:C): M[IOException, Unit]
}

trait Job[Jb[_, _]] extends Monad[Jb] {
  def delay[E, A](j: Unit => Jb[E, A]): Jb[E, A]
  def thunk[E, A](j: Unit => A): Jb[E, A]
  def raises[E, A](e: E): Jb[E, A]
  def tryIn[E1, E2, A, B](j: Jb[E1, A])(fa: A => Jb[E2, B])(fe: E1 => Jb[E2, B]): Jb[E2, B]
  def catches[E1, E2, A](j: Jb[E1, A]): Jb[E2, E1 \/ A]
  def using[E, A : AutoCloseableAsync, B](x: A)(fa: A => Jb[E, B]): Jb[Exception \/ E, B]
  def using[E, A : CloseableAsync, B](x: A)(fa: A => Jb[E, B]): Jb[IOException \/ E, B]
  def using[E, A, B](x: A)(fa: A => Jb[E, B])(dispose: A => Jb[E, Unit]): Jb[E, B]
}

trait Event[Evnt[_, _]] extends Job[Evnt] {
  def never[E, A]: Evnt[E, A]
  def choose[E, A](e1:Evnt[E, A], e2:Evnt[E, A]): Evnt[E, A]
  def choose[E, A](es:Evnt[E, A]*): Evnt[E, A]
  def choose[E, A](es:Iterable[Evnt[E, A]]): Evnt[E, A]

  def withNackJob[E, A, Prms[_, _]:Promise_, Jb[_, _]:Job](f: Prms[E, Unit] => Jb[E, Evnt[E, A]]): Evnt[E, A]
}

trait Promise_[Prms[_, _]] extends Event[Prms] {
  def read[E, A, Evnt[_, _]:Event](p:Prms[E, A]): Evnt[E, A]
  def start[E, A, Jb[_, _]](j:Jb[E, A]): Jb[Void, Prms[E, A]]
}

trait IVar[Ivr[_, _]] extends Promise_[Ivr] {
  def empty[E, A]: Ivr[E, A]
  def fill[E, A, Jb[_, _]](i:Ivr[E, A])(x:A): Jb[E, Unit]
}

trait Channel[Ch[_, _]] extends Event[Ch] {
  def give[E, A, Evnt[_, _]:Event](ch:Ch[E, A])(x:A): Evnt[E, Unit]
  def send[E, A, Jb[_, _]:Job](ch:Ch[E, A])(x:A): Jb[E, Unit]
  def take[E, A, Evnt[_, _]:Event](ch:Ch[E, A]): Evnt[E, A]

  def tryGive[E, A, Jb[_, _]:Job](ch:Ch[E, A])(x:A): Jb[E, Boolean]
  def tryTake[E, A, Jb[_, _]:Job](ch:Ch[E, A]): Jb[E, Maybe[A]]
}

trait Latch[Ltch[_, Unit]] extends Event[Ltch] {
  def create[E](count:Int): Ltch[E, Unit]
  def await[E, Evnt[_, _]:Event](l: Ltch[E, Unit]): Evnt[E, Unit]
  def decrement[E, Jb[_, _]:Job](l: Ltch[E, Unit]): Jb[E, Unit]
  def increment[E, Jb[_, _]:Job](l: Ltch[E, Unit]): Jb[E, Unit]
}

trait MVar[Mvr[_, _]] extends Event[Mvr] {
  def empty[E, A]: Mvr[E, A]
  def read[E, A, Evnt[_, _]:Event](m:Mvr[E, A]): Evnt[E, A]
  def fill[E, A, Jb[_, _]](m:Mvr[E, A])(x:A): Jb[E, Unit]
  def take[E, A, Evnt[_, _]:Event](m:Mvr[E, A]): Evnt[E, A]
}

trait Mailbox[Mlbx[_, _]] extends Event[Mlbx] {
  def empty[E, A]: Mlbx[E, A]
  def send[E, A, Jb[_, _]](m:Mlbx[E, A])(x:A): Jb[E, Unit]
  def take[E, A, Evnt[_, _]:Event](m:Mlbx[E, A]): Evnt[E, A]
}

trait Proc[Prc[_, Unit]] extends Event[Prc] {
  def start[E, A, Jb[_, _]:Job](j:Jb[E, Unit]): Jb[Void, Prc[E, Unit]]
  def bind[E, A, Jb[_, _]:Job](f: Prc[E, Unit] => Jb[E, A]): Jb[E, A]
  def self[E, Jb[_, _]:Job]: Jb[E, Prc[E, Unit]]
  def join[E, Evnt[_, _]:Event](p:Prc[E, Unit]): Evnt[E, Unit]
}

Then there's also a Stream implementation -- kind of like
sealed trait Cons[A]
case object Nil extends Cons[Void]
case class ConsCase[A](value: A, next: Promise[Cons[A]])

type Stream[A] = Promise[Cons[A]]

What do you guys think of this? Can Scalaz 8 take something from CML/Hopac? This is not a deeply thought through proposal, just very rough (not even complete) sketch to kick off a discussion.

This should go into Cats Effect.


Wire up weapons and powers with attributes

Current dependencies on/for this PR:

main

PR #64   👈

This stack of pull requests is managed by Graphite.


Enhancements to Workflow Executions table

TL;DR
This updates the execution tables to make information more compact and exposes the time spent in a queued state for each task execution
Type

[ ] Bug Fix
[x] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[x] Code documentation added
[x] Any pending items have an associated Issue

Complete description

Removed the "Last Run" column for workflow executions and now showing that information below the execution id
Changed the header for "Duration" in the Node/Task executions table to also show "Queued Time" in smaller print
Duration column values now also include a value for time spent in queue (when rendering rows for Task Executions), in less-emphasized type
Added an additional line of information under the start time column to display the time in the local timezone
Increased test coverage for some of the formatting functions.

Tracking Issue
https://github.com/lyft/flyte/issues/141
Follow-up issue
NA
Before

After

Codecov Report

Merging #63 into master will decrease coverage by 0.05%.
The diff coverage is 32.67%.

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   57.23%   57.18%   -0.06%
==========================================
  Files         362      363       +1
  Lines        5745     5806      +61
  Branches      789      799      +10
==========================================
+ Hits         3288     3320      +32
- Misses       2457     2486      +29

Impacted Files
Coverage Δ

src/components/Executions/Tables/constants.ts
100.00% <ø> (ø)

src/components/Executions/Tables/styles.ts
100.00% <ø> (ø)

src/components/Theme/muiTheme.ts
100.00% <ø> (ø)

...ents/Executions/Tables/WorkflowExecutionsTable.tsx
31.81% <12.50%> (+1.17%)
:arrow_up:

...ponents/Executions/Tables/nodeExecutionColumns.tsx
29.72% <16.66%> (-3.61%)
:arrow_down:

src/components/Executions/utils.ts
22.52% <17.39%> (-1.35%)
:arrow_down:

...ponents/Executions/Tables/taskExecutionColumns.tsx
36.53% <23.07%> (-1.76%)
:arrow_down:

...nts/Executions/Tables/workflowExecutionColumns.tsx
26.92% <23.07%> (-1.65%)
:arrow_down:

...onents/Executions/Tables/ExecutionsTableHeader.tsx
35.29% <28.57%> (-1.07%)
:arrow_down:

src/common/constants.ts
100.00% <100.00%> (ø)

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cac813...139cad3. Read the comment docs.


Add command-line invocation

Is your feature request related to a problem? Please describe.
Add documentation  to show how to run program via command-line

Pull requests:

https://github.com/Senzing/docker-python-demo/pull/28
https://github.com/Senzing/docker-python-demo/pull/29
https://github.com/Senzing/docker-python-demo/pull/36


Inventory bugs out with new update (Non-beta)

Friend is having the same issue, with only GoonMod installed. Opening the inventory anywhere causes this to happen, consistently, and the game softlocks: http://steamcommunity.com/sharedfiles/filedetails/?id=434975694

+1. Identical Issue. Locks on inventory screen. Identical image.

https://github.com/goontest/GoonMod/blob/0d6df7b46a544140e2a1b513bf53940dbddb5824/GoonMod/lua/BlackMarketGUI.lua follow intructions

https://github.com/goontest/GoonMod/archive/master.zip
replace goonmod/lua/blackmarketgui.lua for inventory fix and goonmod/goonbase.lua to re enable goonmod


Install fails

Hi, I'm giving mdbook-keeper a go. I've tried installing it today with cargo install mdbook-keeper and I get the following compilation error:
error[E0308]: mismatched types
   --> C:\Users\rose\.cargo\registry\src\index.crates.io-6f17d22bba15001f\mdbook-keeper-0.3.1\src/lib.rs:359:42
    |
359 |         let test_results = self.real_run(preprocessor_config, root, &mut book)?;
    |                                 -------- ^^^^^^^^^^^^^^^^^^^ expected `toml::map::Map<std::string::String, Value>`, found `Map<String, Value>`
    |                                 |
    |                                 arguments to this method are incorrect
    |
    = note: `Map<String, Value>` and `toml::map::Map<std::string::String, Value>` have similar names, but are actually distinct types
note: `Map<String, Value>` is defined in crate `toml`
   --> C:\Users\rose\.cargo\registry\src\index.crates.io-6f17d22bba15001f\toml-0.5.11\src\map.rs:32:1
    |
32  | pub struct Map<K, V> {
    | ^^^^^^^^^^^^^^^^^^^^
note: `toml::map::Map<std::string::String, Value>` is defined in crate `toml`
   --> C:\Users\rose\.cargo\registry\src\index.crates.io-6f17d22bba15001f\toml-0.7.8\src\map.rs:32:1
    |
32  | pub struct Map<K, V> {
    | ^^^^^^^^^^^^^^^^^^^^
    = note: perhaps two different versions of crate `toml` are being used?
note: method defined here
   --> C:\Users\rose\.cargo\registry\src\index.crates.io-6f17d22bba15001f\mdbook-keeper-0.3.1\src/lib.rs:330:12
    |
330 |     pub fn real_run(
331 |         &self,
332 |         preprocessor_config: PreprocessorConfig,
    |         ---------------------------------------

For more information about this error, try `rustc --explain E0308`.
error: could not compile `mdbook-keeper` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
error: failed to compile `mdbook-keeper v0.3.1`, intermediate artifacts can be found at `C:\Users\rose\AppData\Local\Temp\cargo-installVXZYnk`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

I am using mdbook v0.4.35, and rust/cargo version cargo 1.73.0 (9c4383fb5 2023-08-26)
I hope this is useful information to you. I couldn't find a similar bug report for this project.

I think you can just use cargo install mdbook-keeper --git https://github.com/tfpk/mdbook-keeper.git until a new version gets published.

This has now been fixed :)


 IF YOU DO NOT FOLLOW THE FORMAT OR MAKE A GENERIC TOKEN REQUEST YOUR ISSUE WILL BE DELETED WITHOUT COMMENT
YOUR JUSTLIST MUST FOLLOW THE JSON SPECIFICATION
https://github.com/justswaporg/justlists/blob/main/example.justlists.ts
Checklist

[x] I understand that this is not the place to request a token listing.
[x] I have tested that my JustList is compatible by pasting the URL into the add a list UI at justswap.org.
[x] I understand that filing an issue or adding liquidity does not guarantee addition to the justlists website.

Please provide the following information for your token.
JustList URL must be HTTPS.
JustList URL:
JustList Name:
Link to the official homepage of the JustList manager:

alasly alasyl

Please submit the correct information, invalid information will cause the issue to close


Update etcd controllers version

Issue #, if available:
https://github.com/aws/eks-anywhere/issues/3283
Description of changes:
Trigger dev bundle build.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Add API to allow customization of the debug console's input box prompt from code

VSCode Version: 1.8.1
OS Version: OS X

Currently there is no way to customize the debug console's input box prompt - it is always '>'. It would be useful to allow the debug adapter to set the prompt to something different to indicate the context in which the code will execute (in what namespace, etc.)

I would be satisfied if there were a way for an extension to set the debug console prompt - it wouldn't have to be set form the debug adapter.

I would be satisfied if there were a way for an extension to set the debug console prompt - it wouldn't have to be set form the debug adapter.

This goes into the direction of extensions being able to do UI contributions which is not on our immediate plan. Might conisder adding this if we open this door some time in the future

I don't think this is a UI contribution so much as setting the state for the project that the UI uses to render itself - no different then outputting text to a console. There is no new element added, just a change in the content that is displayed from '>' to some other string.

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!


Rework of NMEA2000 fast packet protocol to match TP/ETP

Describe your changes
Reworked the fast packet protocol implementation to align with the updated implementation of the (extended) transport protocol. They use the same base class now for the session, and the dependency on the CanLibProtocol is now completely removed. Also since the FastPacketProtocol class is now a more standalone module we should be able to test it more easily
How has this been tested?
I made sure the 3 examples (namely fast_packet_protocol, nmea2000_generator and nmea2000_parser) are still functioning correctly. And the unit-tests of the nmea2000 message interface are also still working fine, indicating that those messages utilizing the fast packet protocol are still correctly transferred.
Note: This library and its authors are not affiliated with the National Marine Electronics Association in any way.

Failed conditions
 E Reliability Rating on New Code (required ≥ A)

Sorry Sonar, I disagree hahah. None of your issues seem like a problem to me


Updating to 2.2.0 with Live Query launch

Current coverage is 86.34%

Merging #1093 into master will not affect coverage as of ce4fdc9

@@            master   #1093   diff @@
======================================
  Files           91      91
  Stmts         5749    5749
  Branches      1240    1240
  Methods          0       0
======================================
  Hit           4964    4964
  Partial         13      13
  Missed         772     772

Review entire Coverage Diff as of ce4fdc9

Powered by Codecov. Updated on successful CI builds.

Can I just update my parse server to the master branch and get to be able to use the Live Queries?

When is live query available on Android?


moveit - add batch options

Sometimes a folder can have several subfolders that contain manifests that must be moved seperately.
a proposition:
add an optional -o to declare an output, and then all other preceding arguments form a list of inputs that are looped through.

this was pretty much implemented with masscopy.py


TODO cleanups

Remove TODOs which were already handled
Fixed 2.10.x build (although probably not hugely necessary at this point)
Better documentation of Hintable
Creation of a hybrid runtime that has runtime lookup of statically generated picklers (but not reflection-generated picklers).
Deprecated 'share' notions in pickling, as these have some "fun" corner case explosions.

Possibly review by @eed3si9n, @phaller or @heathermiller

Maybe start writing release note for 0.11.0?

@eed3si9n Yeah, still trying to decide on whether or not I can fix the "hybrid" pickling case (i.e. static-generated picklers but dynamically looked up using partial tags).   We have a lot of the components in place and we sort of do it for full runtime picklers, but it's super ugly if you mix static + dynamic right now (as you know).   I was hoping I could fix it for 0.11.x, but probably just should punt that rework for 1.0

@eed3si9n  Ok, this is ready for a second look, added release notes, cleaned up your comments.

LGTM


GH-1189: Asynchronous server-side processing in a request/reply scenario

Resolves #1189

support Mono and Future
support kotlin suspend
Auto detect async reply
@SendTo for @KafkaHandler after error is handled

Refactor MessagingMessageListenerAdapter

move BatchMessagingMessageListenerAdapter#invoke and RecordMessagingMessageListenerAdapter#invoke to MessagingMessageListenerAdapter
move KafkaListenerErrorHandler to MessagingMessageListenerAdapter
add @Nullable to KafkaListenerErrorHandler

@artembilan Hi

It's kind of weird, I ran the ./gradle check locally and it passed.

Probably some race condition.
Since coroutine is an async you might have some thread barrier to wait for the reply to be fulfilled.

Probably some race condition.
Since coroutine is an async you might have some thread barrier to wait for the reply to be fulfilled.

After kafka client 2.4 producer use sticky partition, it random chose partition and topic default partitions is 2.

After kafka client 2.4 producer use sticky partition, it random chose partition and topic default partitions is 2.

So, consider to configure that @EmbeddedKafka to provide just one partition per topic.

So, consider to configure that @EmbeddedKafka to provide just one partition per topic.
Thanks, nice idea.

Sorry i do some wrong when git rebase action, should i reopen RP to keep the RP clean?

I believe you can just do git rebase main if your main is up today.
if that doesn’t help, no worries: we will rebase and squash on merge.
we didn’t forget about you: just busy with some other urgent stuff.
thank you for updates anyway !

Thanks for your patient answer, i solved the problem.


User invitation

Summary
As an owner of a Team, Organization or BillingEntity
I want to invite other users (existing or not)
So that they can collaborate with me on the Team, Organization or BillingEntity.
Context
Allowing other users to collaborate with me, is an involved process. It requires the other person having an existing user account on the platform. Then I must know that person's username. This then allows me to add that users as a member/owner of Teams, Organizations and BillingEntities.
Instead, I want to send an invitation, using the person's email address. The rest then just happens.
The requirements for this are documented at https://kb.vshn.ch/appuio-cloud/references/functional-requirements/portal.html#_feature_send_invitations and https://kb.vshn.ch/appuio-cloud/references/functional-requirements/portal.html#_feature_accept_invitations. The architecture can be found at https://kb.vshn.ch/appuio-cloud/references/architecture/control-api-invitation.html.
Out of Scope
No response
Further links
No response
Acceptance Criteria
Scenario: List Invitations
  When I visit the portal
  And I press "Invitations" on the left hand menu
  Then I see a list of all invitations I have access to

Scenario Outline: Create Invitation
  When I visit the invitations list
  And I press the button "Invite user"
  And I select <entity> along with an access level
  And I press "invite"
  Then I am on the invitation list
  And I see an entry for created invitation
  And I see a success message

  Scenarios:
    | entity        |
    | Organization  |
    | Team          |
    | BillingEntity |

Scenario: Bulk invitation
  When I am on the new invitation view
  And I have filled the fields for an invitation
  Then another set of fields apear allowing me to add another invitation
  When I press "invite"
  Then an invitation is created for each of them

Scenario: Accept Invitation
  Given I have received an invitation email
  When I follow the link in the email
  Then I am logged in to the appuio cloud portal
  And I see a notification naming the entities I have been added to
  And I am on the detail view of the entity if I have been invited to only a single entity

Implementation Ideas
No response

@corvus-ch The API docs specifically mention status conditions like email send failures. Should the portal display those conditions in any way? What are possible action points for a user when there are failures in the status?

@corvus-ch The API docs specifically mention status conditions like email send failures. Should the portal display those conditions in any way? What are possible action points for a user when there are failures in the status?

Yes, that information should be made available to the users. It is not the user's turn to act, but our. So, it should be of an informational kind.
One thing I need to add on our side is to have monitoring of such errors.

First iteration: PR #509

I would propose to format the date more human friendly, also I'm not pleased with how the individual targets are displayed. Maybe it's better to completely omit them and only show the main condition(s).

Yes definitely, please parse the dates and display them in a more human form (preferably take the users' locale into account).

:+1:

As for the targets, can we use an icon for BillingEntity, Organization, and Team (with a hover showing the actual entity name)? The icon then is followed by the Human friendly name of the entity (spec.displayName with fallback to metadata.name) followed by the access level in brackets.
Example: $ be-2345 (viewer)

Hover generally isn't mobile/tablet friendly, so I'd avoid that. I'll come up with a different proposal.

I do not see a need to have a redeemed flag for each and every target. The fact the invitation is redeemed, applies to all targets so one indication is enough.

yeah, me too. I'll remove it later on.

@ccremer We recently were discussing "Bulk invitation". I do now remember the use case that lead to this. It is actually a multi-user, multi-entity use case. I am not so sure anymore this is actually needed. So in the spirit of agile and MVP, I decided to drop this for the first iteration.

@corvus-ch Ack. Just to double-check my understanding: A single invitation is multi-entity capable, since the targetRefs is an array: https://kb.vshn.ch/appuio-cloud/references/architecture/control-api-invitation.html#_object
Would you also drop this single-user, multi-entity case?

Would you also drop this single-user, multi-entity case?

Let us scope it as: what ever can be done with a single invitation object. So yes, as targetRefs is an array, this includes the use case to invite a single user to multiple entities (for instance, viewer on an Organization and admin on a team, or any other possible combination).

@corvus-ch I believe this can be closed now.


Better to crop images or use as is

Is it better to crop the "normal" images or combine them in a large image for anomaly detection?

There are two sizes. Since squares and rectangles are "normal" images, what resolution should I keep them at?
The data includes square portraits and rectangular full-body images—pallettes and sometimes clothing accessories.

Abnormal images would be text and impossible body areas.

My question was, should I crop the data to train the "normal" dataset? The alternative is masking, where I manually remove and use the remaining image as the typical image. I'm currently at 1024x1024. My first thought was to do 512x512 resolution.

@Ivorforce says a rule of thumb is for every ten training samples; you can train one weight.

@Ivorforce says a rule of thumb is for every ten training samples; you can train one weight.

That's called the 1 in 10 rule.

So, what number of typical images do I need to get?
@Ivorforce doesn't know and suggests starting with 10_000 and seeing if that's enough.


Test repos

Description
Changes proposed in this pull request:

Add simple details view for Repositories
Add tests for Git Repositories
Introduce filterWithNoValue command and use it for Deployments test

Related issue(s)
Closes #546

Wow, I have never seen core dumped in Prow logs...
/retest


leave single global and replace window.onload

@zhuharev I'll test and merge it to master soon, Thanks


Will it do versioning/releasing?

I mean like https://github.com/semantic-release/semantic-release. I'm asking because versioning/releasing is something we must do for every project (either manually or automatically). If Rome wants to provide all the tooling someone needs to create stuff, then perhaps it should also handle that.

Yeah it could. We'll also have the ability later on to build module type signatures, which would be an additional layer of checks for a breaking change.

Closing since the question has been answered.


Look into creating a GitHub Badge for each app

I envision the badge being a part of the List of Apps table on the home readme.
Docs on create custom github badges:

https://docs.github.com/en/enterprise-cloud@latest/apps/creating-github-apps/registering-a-github-app/creating-a-custom-badge-for-your-github-app
https://gist.github.com/afig/be5ab20c50062dba7cb835e30206659a

Chains can then add the badge to their repository.
Maybe not the most elegant, but this seems like an easy win to allow chains to advertise their use of specific apps.

Stale/no current interest


403 Error

The workflow fails with error:
Error: failed to generate report API: googleapi: Error 403: The caller does not have permission, forbidden

I'm experiencing the same, with no further information provided... Followed all the steps outlined here. Can't even get it to run with just my user account via the CLI... Unsure on what permission may be missing

Thanks for flagging this issue Victor and Evan. We're investigating the issue now and will provide you an update soon if it's a bug or if there's missing configuration instructions.

Update: We've identified the issue. We're blocking Essentials tier Checks accounts from calling the API, which is a bug. We'll be submitting a fix to enable the API for the Essentials tier and rolling out a new version of the API. I'll send an update here as soon as that change is live.
Appreciate your patience!

The fix is now live in production and you should no longer get a 403 error. Let me know if you run into any further issues and thank you for using our CI/CD functionality!

Works for me now, thanks for the quick fix!

I've checked it with the CI workflow I was trying and looks like it works
now! Thanks for the quick fix on this one!
On Wed, Jun 12, 2024 at 3:00 PM Evan Otero @.***> wrote:

The fix is now live in production and you should no longer get a 403
error. Let me know if you run into any further issues and thank you for
using our CI/CD functionality!
—
Reply to this email directly, view it on GitHub
https://github.com/google-checks/checks-app-scan-github-action/issues/3#issuecomment-2163972770,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BIWXT4YXPJJQJ4EOVK7ZEYLZHDAIJAVCNFSM6AAAAABI2YHGDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRTHE3TENZXGA
.
You are receiving this because you commented.Message ID:
@.***
com>


Python buildout is broken after change to use wheels internally

I'm still struggling with namespace packages after this change https://github.com/NixOS/nixpkgs/pull/11086 to use wheels internally.
In short, why does namespaces work when package with namespace packages (e.g. zope.deprecation) is in PYTHONPATH, but fail when the same path is added into sys.path? /cc @domenkozar @cillianderoiste
Particularly, all zc.buildout generated scripts with /nix/store paths are broken because of this.
Is this different from the known setuptools issue? As a workaround, using wrapProgram for buildout generated scripts would make namespaced packages directly importable (because wrapProgram would generated PYTHONPATH and sys.path in scripts have no longer any effect). Yet, because setuptools is still broken, e.g. zope.configuration fails to find packages.

An another issue. For some reason I'm not able to override propagated build inputs for a Python package. My use-case is adding extra run-time dependencies for zc_buildout_nix so that it can use those instead of installing new packages (zc_buildout_nix is patched version of buildout so that it prefers existing local packages).
For example,
pythonPackages.zc_buildout_nix.overrideDerivation(args: {
  propagatedBuildInputs = [ pythonPackages.pyramid ];
})

would not add pyramid-packages into scripts generated from zc_buildout_nix, but adding that propagatedBuildInputs directly into the expression (pkgs/development/python-modules/buildout-nix/default.nix) would work.
@cillianderoiste Would you be able to reproduce this? You have been using buildout-nix.

@datakurre for namespaces, I'll take a look as soon as I find some time. We should really fix this issue.
For overrideDerivation see http://lists.science.uu.nl/pipermail/nix-dev/2015-March/016452.html and https://github.com/NixOS/nixpkgs/issues/4855

@domenkozar Thanks. I got overrideDerivation working and zc.buildout-nix works now as expected.
About namespaces. For me it seems that there is no solution in sight for setuptools. Using PYTHONPATH instead of sys.path would work some use-case, but still everything using setuptools API would probably stay broken.
Do you think it would be possible to prevent wheel from excluding namespace init.py-files in bdist_wheel? (And is there still more code in PIP for preventing to install them?)

That was my feeling - we'll have to dig into how namespaces work and patch setuptools (in a way hopefully that can be submitted upstream).

Well, if I only knew what's the real issue. So far, I've found the following related setuptools issues

https://bitbucket.org/pypa/setuptools/issues/462 (zc.recipe.egg)
https://bitbucket.org/pypa/setuptools/issues/97 (find_packages)

I can add my proposal for 462 as a patch to fix zc.recipe.egg installation https://github.com/datakurre/nixpkgs/commit/6d863bb4daf984e870b9a8b59502e746a370222a
I can also patch find_packages to interpret all directories containing modules under some sub directory as a namespace package: https://github.com/datakurre/nixpkgs/commit/eea32ab9e03c3d0ce3194310fb7a9b6989a05895 (well, should add a test that such directory is empty...)
Yet, I cannot make implicit namespace packages magically importable in Python 2.x. Even the proposed fixes in setuptools have only been for Python >= 3.3. Should I try importlib2? And I must be missing something, because import works for namespace packages in PYTHONPATH (even it doesn't for packages added into sys.path).

Possibly the difference between PYTHONPATH working and sys.path not is that PYTHONPATH processes .pth-files, which do include information about namespace packages. I'll, try to populate sys.path using site.addsitedir next (it should process pth-files).

I think, I stop trying to patch setuptools and try to learn if wheel / pip could be set to leave init.pys into packages.
My current understanding is that there are two ways to make namespace packages work with Python < 3.3 (PEP420): 1) either each namespace package should have that special init.py declaring a namespace or 2) there should be .pth-file defining those packages. Implicit PEP420 namespace packages only work on Python >= 3.3, so therefore broken support for implicit namespace packages in setuptools is not a relevat issue for Python 2.7.
Possibly those two ways for declaring namespace packages cannot be mixed in the same package and therefore wheel / pip have opted to use .pth-files to support Python < 3.3 (which also makes it easier to manage those packages with RPM or other legacy package managers, because there are not conflictin namespace init.pys in packages).
Currently, non-buildout based Python software with namespace packages in nixpkgs work, because rely on PYTHONPATH, which does read .pth files to register namespace packages on Python 2.7. Buildout created scripts fail, because they rely on updating sys.path, which does not trigger reading .pth-files. And because Python 2.7 does not support implicit namespace packages, those packages cannot be imported. Using site.addsitedir instead of updating sys.path in buildout generated scripts could fix this, because site.addsitedir does read .pth-files.
@domenkozar Did I miss something in above?
I still don't know, why zope.configuration / z3c.autoinclude fails to locate packages (e.g. zcml in plone.app.contenttypes fails to load module from plone.app.contenttypes...). I may still to try to look into that, but probably I move to figuring out, if somehow namespace init.pys could still be used instead of .pth-files on Python 2.7.

Just found that z3c.autoinclude has copy of setuptools' find_packages (it reasoned that it was safer to copy the method than try to import it from setuptools) , which knew nothing about implicit namespace packages. Fixing that made nix-built Plone start.

@domenkozar So, finally, I see the the following options:
a) Somehow fix wheel and pip to preserve namespace markers __init__.pys and rely on them instead of .pth files when building and installing package for Python 2.7. This should fix everything to work as before.
b) Do nothing, but recommend wrapping buildout generated files with makeWrapper.
Obviously, z3c.autoinclude should either be fixed in upstream or patched in nixpkgs. I already have a Python 3 fixed version of that so, maybe I should try to get that merged with find_packages supporting implicit namespace packages.
Fixing find_packages in setuptools to find implicit namespace packages may not be trivial, because upstream would probably want to fix it only for Python >= 3.3. find_packages use-case in z3c.autoinclude is a bit different and affects only Python 2.7.

@datakurre not sure I understand option a), can you elaborate?

@domenkozar About a). At least my issue seem to be that packages with namespace marker __init__.pys get packed and installed so that those markers get removed and replaced with "implicit" namespace packages and .pth file (to support Python < 3.3, I'd guess). Preventing that (preserving and relying namespace __init__.py files) should fix these issues. But I don't know yet, why wheel does that (adds .pth file and removes namespace packages), is that configurable or otherwise fixable.

Similar issue (no answer): https://mail.python.org/pipermail/distutils-sig/2014-March/023992.html

In short, I'm interested, which code removes namespace markers and why. Probably for a good reason, but I'd like to know. Some setuptools command seems to have code for clearing them ("install_lib"), but haven't managed to test yet if it's it.

I'll give this a deeper look in Feb.

@domenkozar Have you got any new ideas for this?
To summarize:

buildout-generated scripts are broken, because of setuptools' namespace package __init__.py's being removed by wheel packaging; workaround would be to not rely on buildout-generated scripts or wrap them to have all packages in PYTHONPATH

Yet, because of z3c.autoinclude using (copied) setuptools' find_packages, Plone will remain broken until __init__.py's reappear or z3c.autoinclude is fixed to find packages without namespace __init__.py's (but because that's not fixed even in setuptools itself, it's hard to guess the "right" solution without side-effects).

Yet, one workaround, you proposed, was to design something for installing Plone-requirements as a bundle (to them into a single nix package).
I could arrange some time to work around this in the next week (the 1st week of March), but I'm not yet familiar enough with Nixpkgs' python packaging internals to get forward alone.

@datakurre hopefully I'll have some time this weekend :) Thanks for being persistent, this one is important to fix.

@datakurre I'll finally have time to dig into this one, can you provide me a way to reproduce this easily? Just something I can run and debug

Ok. This example is nonsense, but should show the issue. Given
default.nix:
with import <nixpkgs> {};
stdenv.mkDerivation {
  name = "env";
  buildInputs = [
    (pythonPackages.zc_buildout_nix.overrideDerivation(args: {
      postInstall = "";
      propagatedNativeBuildInputs = [
        (buildPythonPackage {
          name = "zc.recipe.egg-2.0.3";
          src = fetchurl {
            url = "https://pypi.python.org/packages/source/z/zc.recipe.egg/zc.recipe.egg-2.0.3.tar.gz";
            md5 = "69a8ce276029390a36008150444aa0b4";
          };
          propagatedBuildInputs = [
            pythonPackages.zc_buildout_nix
            pythonPackages.setuptools
          ];
          installPhase = pythonPackages.setuptools.installPhase;
          doCheck = false;
        })
      ];
    }))
  ];
}

buildout.cfg:
[buildout]
parts = zc.buildout
versions = versions

[zc.buildout]
recipe = zc.recipe.egg
eggs = zc.buildout

[versions]
setuptools = 18.2
zc.recipe.egg = 2.0.3

Result
$ nix-shell --run buildout
$ bin/buildout
Traceback (most recent call last):
  File "bin/buildout", line 9, in <module>
    import zc.buildout.buildout
ImportError: No module named zc.buildout.buildout

The default.nix setup zc_buildout_nix, which is just like buildout, but always prefers /nix/store-installed eggs found in its own PYTHONPATH. The buildout.cfg just creates bin/buildout-script, which only includes paths form nix-store. bin/buildout fails, because zc is a new style namespace package, which is not supported by sys.path-approach of zc.buildout.

@domenkozar The easiest way to fix the above, I think, would be to opt-out from wheels/pip removing setuptools namespace __init__.pys. What I read, that removal is there only to please packaging tools, which install all packages into single tree and break when to packages own same namespace __ini__.py. Although, could be hard to get a such option to upstream.
A good enough alternative would be to provide that bundle install (installing multiple Python packages as a single Nix-package) with option to select between wheel and legacy install. That would also fix issues with circular deps.

I've played our with recursive pth loader, I'm getting closer but it still doesn't work.
diff --git a/pkgs/development/python-modules/generic/default.nix b/pkgs/development/python-modules/generic/default.nix
index 1fdbd4f..fa18a23 100644
--- a/pkgs/development/python-modules/generic/default.nix
+++ b/pkgs/development/python-modules/generic/default.nix
@@ -3,7 +3,7 @@
    (http://pypi.python.org/pypi/setuptools/), which represents a large
    number of Python packages nowadays.  */

-{ python, setuptools, unzip, wrapPython, lib, bootstrapped-pip
+{ python, setuptools, unzip, wrapPython, lib, bootstrapped-pip, recursivePthLoader
 , ensureNewerSourcesHook }:

 { name
@@ -68,7 +68,7 @@ python.stdenv.mkDerivation (builtins.removeAttrs attrs ["disabled" "doCheck"] //
     ++ (lib.optional (lib.hasSuffix "zip" attrs.src.name or "") unzip);

   # propagate python/setuptools to active setup-hook in nix-shell
-  propagatedBuildInputs = propagatedBuildInputs ++ [ python setuptools ];
+  propagatedBuildInputs = [ recursivePthLoader ] ++ propagatedBuildInputs ++ [ python setuptools ];

   pythonPath = pythonPath;

diff --git a/pkgs/development/python-modules/recursive-pth-loader/sitecustomize.py b/pkgs/development/python-modules/recursive-pth-loader/sitecustomize.py
index 057e779..ccaf7f3 100644
--- a/pkgs/development/python-modules/recursive-pth-loader/sitecustomize.py
+++ b/pkgs/development/python-modules/recursive-pth-loader/sitecustomize.py
@@ -38,6 +38,8 @@ for path_idx, sitedir in enumerate(sys.path):
                     continue

                 if line.startswith(("import ", "import\t")):
+                    print line
+                    exec line
                     continue

                 line = line.rstrip()

I already forgot pth files. But I'm missing, how that would help buildout generated scripts.

Because that's where namespace magic happens:
[nix-shell:~/dev/nixpkgs]$ cat /nix/store/7f6rf1dd1k6s6r86r743bdawm8yqjac0-python2.7-logilab-constraint-0.6.0/lib/python2.7/site-packages/logilab_constraint-0.6.0-py2.7-nspkg.pth
import sys, types, os;p = os.path.join(sys._getframe(1).f_locals['sitedir'], *('logilab',));ie = os.path.exists(os.path.join(p,'__init__.py'));m = not ie and sys.modules.setdefault('logilab', types.ModuleType('logilab'));mp = (m or []) and m.__dict__.setdefault('__path__',[]);(p not in mp) and mp.append(p)

And those were already read, if the package was in PYTHONPATH, but not, when it was dynamically added into sys.path. You are able to patch that?

(triage) any updates?

I'll retry my example next week and report back (I haven't got any new ideas for fixing this).

Are there any updates to this issue, please?

I don’t remember why I did not report back, but I did move to use zc_buildout_nix-package and contributed that to make it work in my use cases.
That said, I still have an extra patch over it to make bin/-scripts have correct interpreter https://github.com/datakurre/nix-files/blob/master/overlays/custom/plone-env/default.nix#L68

Assuming fixed


Added support for different join types in QuerySet.df()

The current 'include' parameter for QuerySet.df does not allow outer joins. In the context of our project (getting all the Biosamples and FeatureSets for a given Artifact) we need some more flexibility to allow the outer join. Therefore I propose the following changes to the .df method in the lnschema_core and lamindb repos (tested and working for our use case, joining Artifact with FeatureSet and Biosamples)

Oh, wow! Awesome! Can you please add a test for this?
Somewhere around here: https://github.com/laminlabs/lamindb/blob/2d32fd46fd7905b287f2ae972121630c1b33edab/tests/test_queryset.py#L19-L27
And you should bump the lnschema-core git submodule within lamindb so that it points to your changes there: https://github.com/laminlabs/lnschema-core/pull/392

@Koncopd, can you help Ivan to get tests to pass?

Or better, make a "CONTRIBUTING.md" doc that explains how to set up & install things to outsiders?
The important thing is to also explain how to checkout and install submodules.

The current error is a formatting error. Ivan, you need to run the below so that the linter is live:
pre-commit install

Yep, i will add the guide.

Thanks @falexwolf for bringing up these points! I tried to reformat the code with ruff but have not been able to figure out yet how to inspect the formatting unfortunately. I also added unit tests in a new commit/bumped to the changed lnschema-core.

This is how you do it, Ivan:
(py310) falexwolf@mbpalex lamindb % pre-commit run --all-files
prettier.................................................................Passed
nbstripout...............................................................Passed
ruff.....................................................................Passed
ruff-format..............................................................Failed
- hook id: ruff-format
- files were modified by this hook

1 file reformatted, 88 files left unchanged

detect private key.......................................................Passed
check python ast.........................................................Passed
fix end of files.........................................................Passed
mixed line ending........................................................Passed
trim trailing whitespace.................................................Passed
check for case conflicts.................................................Passed
mypy.....................................................................
Passed

(py310) falexwolf@mbpalex lamindb % git diff
diff --git a/lamindb/_query_set.py b/lamindb/_query_set.py
index aee1957c..829b6b9d 100644
--- a/lamindb/_query_set.py
+++ b/lamindb/_query_set.py
@@ -97,7 +97,9 @@ class QuerySet(models.QuerySet, CanValidate):
     """

     @doc_args(Registry.df.__doc__)
-    def df(self, include: str | list[str] | None = None, join: str = "inner") -> pd.DataFrame:
+    def df(
+        self, include: str | list[str] | None = None, join: str = "inner"
+    ) -> pd.DataFrame:
         """{}."""
         # re-order the columns
         exclude_field_names = ["created_at"]
Submodule sub/lnschema-core c12081d0..1f64e123 (rewind):
  < Added support for different join types in QuerySet.df()
Submodule sub/wetlab 88613bea..d7aea9ab:
  > ✅ Add system check

(py310) falexwolf@mbpalex lamindb % git add .
(py310) falexwolf@mbpalex lamindb % git commit -m "Fix linting"
prettier.................................................................Passed
nbstripout...........................................(no files to check)Skipped
ruff.....................................................................Passed
ruff-format..............................................................Passed
detect private key.......................................................Passed
check python ast.........................................................Passed
fix end of files.........................................................Passed
mixed line ending........................................................Passed
trim trailing whitespace.................................................Passed
check for case conflicts.................................................Passed
mypy.....................................................................Passed
? Choose a gitmoji: ♻  - Refactor code.
? Enter the commit title [11/48]: Fix linting
? Enter the commit message:
[savchuki/dev 70aaf936] ♻ Fix linting
 3 files changed, 5 insertions(+), 3 deletions(-)

I pushed these changes directly here on the branch.

I'm just seeing that you added the test! Thank you! Will merge this after polishing.


relationship pivot fix

I have problem with new relationships in 1.0. Then create relationship, I set pivot table, but that value ignored. Then creating new bread element, I have an error: Table '#table1#_#table2#' doesn't exist , but in settings there is table #table2#_#table1#. In 0.11.14 I could fix it easy:
return $this->belongsToMany(Project::class, '#table2#_#table1#');
in model class.
That solution for 1.0

Solves #1842.
Can we get this merged?

I'm good with this.  Thanks @WolandV!


Linker Errors while building tensorflow from source

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
No
Source
source
Tensorflow Version
2.11
Custom Code
Yes
OS Platform and Distribution
Debian GNU/Linux 10
Mobile device
No response
Python version
3.7
Bazel version
6.1.1
GCC/Compiler version
LLVM 12
CUDA/cuDNN version
11, 8
GPU model and memory
T4
Current Behaviour?
I'm trying to build tensorflow from source via the tutorial (using configure.py). However, when I do so, I run into linker errors, such as

ld.lld: error: undefined symbol: tensorflow::Tensor::Tensor()
>>> referenced by nn_interface.cc
>>>               nn_interface.o:(nn::NNInterface::Infer(tensorflow::Scope&, tensorflow::ClientSession&)) in archive bazel-out/k8-opt/bin/cc/nn/libnn_interface.a
>>> referenced by nn_interface.cc
>>>               nn_interface.o:(nn::NNInterface::Infer(tensorflow::Scope&, tensorflow::ClientSession&)) in archive bazel-out/k8-opt/bin/cc/nn/libnn_interface.a
>>> referenced by nn_interface.cc
>>>               nn_interface.o:(nn::NNInterface::Infer(tensorflow::Scope&, tensorflow::ClientSession&)) in archive bazel-out/k8-opt/bin/cc/nn/libnn_interface.a
>>> referenced 3 more times

I have tried running this multiple times, with both gcc/llvm, and via the config script/through a dependency in my project. When I build TF as a monolithic build, everything works fine, but when I try to build using the TF defaults, I always run into linker issues. What could be going on?

Standalone code to reproduce the issue
git clone <tensorflow>
cd tensorflow
./configure

Relevant log output
ld.lld: error: undefined symbol: tensorflow::Tensor::Tensor()
>>> referenced by nn_interface.cc
>>>               nn_interface.o:(nn::NNInterface::Infer(tensorflow::Scope&, tensorflow::ClientSession&)) in archive bazel-out/k8-opt/bin/cc/nn/libnn_interface.a
>>> referenced by nn_interface.cc
>>>               nn_interface.o:(nn::NNInterface::Infer(tensorflow::Scope&, tensorflow::ClientSession&)) in archive bazel-out/k8-opt/bin/cc/nn/libnn_interface.a
>>> referenced by nn_interface.cc
>>>               nn_interface.o:(nn::NNInterface::Infer(tensorflow::Scope&, tensorflow::ClientSession&)) in archive bazel-out/k8-opt/bin/cc/nn/libnn_interface.a
>>> referenced 3 more times

I should mention that I am using my own toolchain, but is it essentially just clang. Code here: https://github.com/p3achyjr/p3achyGo/blob/main/toolchain/BUILD
I noticed that the generated CUDA toolchain file adds CUDA include paths, whereas I just add c/c++ include paths. Could this have something to do with it?

@p3achyjr
Sorry for the late reply, As per the documentation, TF v2.11.0 requires 8.1 cuDNN and 11.2 CUDA version.Could you please make sure to follow the instructions mentioned here and check the tested build configuration as well. Please let us know if it helps?
Thank you!

I tried using gcc 8 and gcc 9 today, and both failed. gcc8 gave the standard "lld undefined symbol". gcc failed much more catastrophically--It says the following command failed.
cd /home/axlui/.cache/bazel/_bazel_axlui/f4685961e4a033eb3c5c8f3ed28f41d5/execroot/__main__ &&   exec env -     CUDA_TOOLKIT_PATH=/usr/local/cuda-11.3     CUDNN_INSTALL_PATH=/usr/local/cuda     GCC_HOST_COMPILER_PATH=/usr/bin/x86_64-linux-gnu-gcc-8     LD_LIBRARY_PATH=/usr/local/cuda/lib64:/usr/local/nccl2/lib:/usr/local/cuda/extras/CUPTI/lib64     PATH=/home/axlui/.cache/bazelisk/downloads/bazelbuild/bazel-6.1.1-linux-x86_64/bin:/home/axlui/.local/bin:/usr/lib/llvm-12/bin:/home/axlui/.local/bin:/usr/local/cuda/bin:/opt/conda/bin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/local/go/bin     PWD=/proc/self/cwd     PYTHONPATH=/home/axlui/p3achyGo/python:/usr/lib/llvm-12/bin:/home/axlui/.local/bin:/usr/local/cuda/bin:/opt/conda/bin:/opt/conda/condabin:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games:/usr/local/go/bin     PYTHON_BIN_PATH=/opt/conda/bin/python3     PYTHON_LIB_PATH=/bin     TF_CUDA_COMPUTE_CAPABILITIES=7.5     TF_CUDA_VERSION=11     TF_CUDNN_VERSION=8   external/local_config_cuda/crosstool/clang/bin/crosstool_wrapper_driver_is_not_gcc @bazel-out/k8-opt/bin/cc/main-2.params

When I run this by hand, it spits out tons of linker errors, such as:
/usr/bin/ld: mkl_nn_ops.cc:(.text.startup._Z41__static_initialization_and_destruction_0ii.constprop.218+0x731f): undefined reference to `tensorflow::shape_inference::BatchMatMulV2Shape(tensorflow::shape_inference::InferenceContext*)'
/usr/bin/ld: mkl_nn_ops.cc:(.text.startup._Z41__static_initialization_and_destruction_0ii.constprop.218+0x7372): undefined reference to `tensorflow::register_op::OpDefBuilderWrapper::operator()()'
/usr/bin/ld: mkl_nn_ops.cc:(.text.startup._Z41__static_initialization_and_destruction_0ii.constprop.218+0x7437): undefined reference to `tensorflow::register_op::OpDefBuilderWrapper::operator()()'
/usr/bin/ld: mkl_nn_ops.cc:(.text.startup._Z41__static_initialization_and_destruction_0ii.constprop.218+0x750c): undefined reference to `tensorflow::register_op::OpDefBuilderWrapper::operator()()'

Maybe you could take a look at how I've setup the build? I don't know if I'm using it right. https://github.com/p3achyjr/p3achyGo/blob/main/cc/nn/BUILD


Add title tags to images

I'm new to the home automation world and found this site invaluable. The one thing that bugged me is that I couldn't remember what each of the icons were when browsing by device category.
I've added a title tag to each image so visitors can hover over the image and get a tooltip.

good idea, thanks!


MongoDB Scalers open many open connections

Report
After connection problems between keda components inside the cluster the MongoDB scaler makes many new request to MongoDB Database which caused that the connection limit was reached. The number of connections per minute was higher as configured.
Expected Behavior
If connection issues appear, Keda should not spawn new connections from a scaler which are more frequently spawned then configured.
Actual Behavior
Keda spawns more sacler connections connections than expected.

Steps to Reproduce the Problem

Logs from KEDA operator
example

KEDA Version
2.13.1
Kubernetes Version
1.28
Platform
Amazon Web Services
Scaler Details
MongoDB
Anything else?
No response

Hello @MichaelMayer-askui ,
Thanks for reporting! Do you see any error in keda-operator logs? Could you confirm the KEDA version you are using?

Hello @JorTurFer ,
The versions i can confirm, all keda components on version 2.13.1, see screeshoot.

The only error message from keda-operator which i receive is the following:
mongodb_scaler	failed to query DATABASE in COLLECTION_NAME, because of server selection error: context deadline exceeded, current topology: { Type: ReplicaSetNoPrimary, Servers: [{ Addr: ATLAS_URL.mongodb.net:27017, Type: RSSecondary, Tag sets: diskState=READY,availabilityZone=AZ,nodeType=ELECTABLE,provider=AWS,region=AZ,workloadType=OPERATIONAL, Average RTT:<PHONE_NUMBER> }, { Addr: ATLAS_URL.mongodb.net:27017, Type: RSSecondary, Tag sets: provider=AWS,diskState=READY,region=AZ,workloadType=OPERATIONAL,availabilityZone=AZ,nodeType=ELECTABLE, Average RTT: 3196250 }, { Addr: ATLAS_URL.mongodb.net:27017, Type: Unknown, Last error: dial tcp IP:27017: connect: connection refused }, ] }	{"type": "ScaledJob", "namespace": "NAMESPACE_NAME", "name": "SCALED_JOB_NAME", "error": "server selection error: context deadline exceeded, current topology: { Type: ReplicaSetNoPrimary, Servers: [{ Addr: ATLAS_URL.mongodb.net:27017, Type: RSSecondary, Tag sets: diskState=READY,availabilityZone=AZ,nodeType=ELECTABLE,provider=AWS,region=AZ,workloadType=OPERATIONAL, Average RTT:<PHONE_NUMBER> }, { Addr: ATLAS_URL.mongodb.net:27017, Type: RSSecondary, Tag sets: provider=AWS,diskState=READY,region=AZ,workloadType=OPERATIONAL,availabilityZone=AZ,nodeType=ELECTABLE, Average RTT: 3196250 }, { Addr: ATLAS_URL.mongodb.net:27017, Type: Unknown, Last error: dial tcp IP:27017: connect: connection refused }, ] }"}
github.com/kedacore/keda/v2/pkg/scalers.(*mongoDBScaler).getQueryResult
	/workspace/pkg/scalers/mongo_scaler.go:231
github.com/kedacore/keda/v2/pkg/scalers.(*mongoDBScaler).GetMetricsAndActivity
	/workspace/pkg/scalers/mongo_scaler.go:240
github.com/kedacore/keda/v2/pkg/scaling/cache.(*ScalersCache).GetMetricsAndActivityForScaler
	/workspace/pkg/scaling/cache/scalers_cache.go:130
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getScaledJobMetrics
	/workspace/pkg/scaling/scale_handler.go:830
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).isScaledJobActive
	/workspace/pkg/scaling/scale_handler.go:879
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers
	/workspace/pkg/scaling/scale_handler.go:262
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop
	/workspace/pkg/scaling/scale_handler.go:182

This message occurs after the high amount of connection is open and the database refused more.

Is your connection using mongo+svr scheme? v2.13.1 doesn't support it. I mean, if you are using Mongo Atlas based on mongo+srv scheme, it could be the problem itself. The support for the scheme was added 3 weeks ago: https://github.com/kedacore/keda/pull/5566
Maybe you could try the main tag setting the scheme as it's explained in next version docs: https://keda.sh/docs/2.14/scalers/mongodb/

Yes the connection string is in mongo+svr scheme. I will test, if the problem will be resolved by adjusting the connection string.
Now I am surprised that it works. I used this config for now ~1 year without any issues. The problems occurred right after the update to v2.13 from v2.12.
Should this not produce an error regarding wrong configuration?

Should this not produce an error regarding wrong configuration?

It could be, I don't remind related changes but they definitively could be there, for example the mongo pkg has been updated too


Migrate from Optional to the build-in c# Nullable Reference Types

Hi,
do you have any experience in migration from this Optional library to the new c# built-in Nullable Reference Types?

Hi!
Do you mean migrating away from Optional to use nullable reference types instead or making Optional play better with nullable references types? (the latter is mostly done in the develop branch, but needs to be refreshed a bit)
If you mean migrating away from Optional I think it should be fairly easy, but will definitely require some manual effort to do so.

Thanks @nlkl for reply.
Im thinking mostly about full transition from Optional to NRT.
That new support from C# 8.0 language is very simple and it is built in compiler. In result that native mechanism for null-checking provide better control and is much more resistant for fools-like-me :)


Types with large records leave the screen.

Take Navigation.program as an example, this has a large type
program
    :  Parser data
    -> { init : data -> (model, Cmd msg), update : msg -> model -> (model, Cmd msg), urlUpdate : data -> model -> (model, Cmd msg), view : model -> Html msg, subscriptions : model -> Sub msg }
    -> Program Never

It would be great if this could be formatted differently to fit the screen:
program
    :  Parser data
    -> { init : data -> (model, Cmd msg)
       , update : msg -> model -> (model, Cmd msg)
       , urlUpdate : data -> model -> (model, Cmd msg)
       , view : model -> Html msg
       , subscriptions : model -> Sub msg
       }
    -> Program Never

I was about to open the same issue. Found it here: http://package.elm-lang.org/packages/agrafix/elm-bootforms/10.0.0/Html-Form-Input-Date

Looks like it's caused by white-space: pre. It looks fine if you remove this line but I assume it was added for a good reason?

See #219 which has an image of the problem in elm-lang/core@Platform


Title Case Composition Swapchain

Casing for composition swapchain has been updated to adhere with the rest of the document.

Thanks, @BL1NDX3N0N. When used in the middle of a sentence (so that casing issues are eliminated), it's "composition swapchain". So it looks like this content is already correct, so I'll close the PR.
Thanks!
-Steve

I will be sure to keep an eye out for that. Have a good day.


Test to find if the longhorn volume is getting automounted

Signed-off-by: Keith Lucas<EMAIL_ADDRESS>

The related issue has been verified in https://github.com/longhorn/longhorn-engine/pull/723.


Update goreleaser and build darwin arm64 binary for homebrew

I think this will fix the error this pluto user is encountering. Currently goreleaser is not populating a section for Darwin arm64 for m1 chips. https://github.com/FairwindsOps/pluto/issues/224


fix(orchestrator): fix the common package reference version

The common package version was bumped by the bot but its references have not been updated.

/approve

/lgtm


[BUG] sendViaRelay works in Chrome but not Firefox

What happened?
Firstly, thanks for making this framework - I have a chrome extension, works great.
I'm trying to port the extension to firefox. I've narrowed down the issue to a hanging call to @plasmohq/messaging:
var resp = await sendViaRelay({
      name: "get-email"
    });

As context, I'm calling sendViaRelay within our web app, which is within an iframe, inside of popup.ts:
import { useState } from "react"
import { sendToBackground } from "@plasmohq/messaging"

function IndexPopup() {
    const [data, setData] = useState("")

    return (

    )
}

export default IndexPopup

This is working in Chrome (the only trick there was making sure to set all_frames: true), but for some reason, Firefox doesn't seem to like sendViaRelay (I'd show a console log error message, but sadly, firefox doesn't allow you to see console messages for iframes within popup - makes this more challenging!).
Is sendViaRelay and firefox not playing nice a known thing?
Version
Latest
What OS are you seeing the problem on?
MacOSX
What browsers are you seeing the problem on?
Firefox
Relevant log output
I'd show a console log error message, but sadly, firefox doesn't allow you to see console messages for iframes within popup - makes this more challenging!

(OPTIONAL) Contact Details
<EMAIL_ADDRESS>Code of Conduct

[X] I agree to follow this project's Code of Conduct
[X] I checked the current issues for duplicate problems.

Is sendViaRelay and firefox not playing nice a known thing?

This is likely the case - if you're already investigating this, can you take a look at what port API is FF supporting and do they expose them under the chrome namespace or the browser namespace? - We might need to add the polyfill to messaging API in the next version. Would love some help on investigating this!

ah @louisgv, this looks like a known problem:

Google Chrome uses chrome while Mozilla Firefox, the old Microsoft Edge and Safari also support the browser-neutral browser

It looks like Mozilla has a pretty extensive polyfill for going from browser API to chrome API: ...so it seems like the need would be to go from chrome.runtime to browser.runtime for Firefox/Edge support, and use Mozilla's polyfill to get chrome support.
There's of course this little gem from the Chromium bug report:

One key difference to note while adding this is that the WebExtensions spec is largely promise-based, while the chrome.* APIs are callback-based. Oh, and as a stop-gap solution, Mozilla has had a polyfill [2] out for a while to help people use the same extension code in Chrome and Firefox (and Edge) both.

Which means that places like sendMessage's callback need to be changed? I don't have the skill to switch things over to using the polyfill, but would be happy to test a build of @plasmohq/messaging & do some tweaking.

It looks like Mozilla has a pretty extensive polyfill for going from browser API to chrome API: ...so it seems like the need would be to go from chrome.runtime to browser.runtime for Firefox/Edge support, and use Mozilla's polyfill to get chrome support.

One issue with this polyfill is that it's more or less just a promisified module over browser instead of an actual polyfill. And it throws on API unavailable at import - which is nuts! - IMO Polyfill should not throw runtime errors on import. If API is unavailable, mock stuff out or have a fallback hatch, or throw on invocation.
The error it throws break a bunch of stuff in a manner that has no way to go around them lol
@kenkantzer-truss The new Relay API should decoupled from the chrome.runtime stuff so you can now walk around this issue. I've created a PR to switch over to the new promise API as well, which will hopefully fix the issue you are having with chrome runtime:
https://github.com/PlasmoHQ/plasmo/pull/462

oo, thanks @louisgv - is this PR in @plasmohq/messaging 0.1.4 yet? happy to I give it a try!

@weltan yup, please try it out!


Popover uses deprecated "innerRef"

Hi there,
I've been trying to use your "Popover" component and it seems to work as expected with the "Button" component from your library, but when I tried  my own button component, I get an error:
styled-components.browser.esm.js:1969 The "innerRef" API has been removed in styled-components v4 in favor of React 16 ref forwarding, use "ref" instead like a typical component.
I also tried with a basic component, without styled-components, and I get the same error, but this time from React itself.
I'm using:

React version 16.6.1
Styled Components version 4.1.1

As a quick fix on Popover children I'm passing innerRef prop to ref attribute, but I would like to avoid doing this...
I believe this lines should be updated:
https://github.com/segmentio/evergreen/blob/2b6b76df27638eff32fb391bc2c8ea1ff7a081df/src/popover/src/Popover.js#L298-L301
Thank you,
Alexandru Robert Comanescu

I'd also like to know how to get it working for custom components :D or a bit of documentation there would be helpful

This affects Tooltip component and should probably be updated there as well.
Exact error:
Warning: React does not recognize the `innerRef` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `innerref` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

I just ran into this problem, causing my popover not to show on-screen.
Here's a temporary workaround:
// HOC to apply innerRef to ref
function withInnerRef (WrappedComponent) {
  return function WithInnerRef ({ innerRef, ...rest }) {
    return <WrappedComponent ref={innerRef} {...rest} />
  }
}

// Usage with styled-components
const MyCustomButton = withInnerRef(styled.button`
  /* custom styles */
`)

Or, if you fancy a one-liner:
const withInnerRef = C => ({ innerRef, ...rest }) => <C ref={innerRef} {...rest} />

Of course this is not ideal; I'd like to work on a fix for this.

+1 here when I use Emotion as trigger:
 `innerRef` is deprecated and will be removed in a future major version of Emotion, please use the `ref` prop instead in the usage of `ReactiveSearch-SortOptions--Trigger`

Thank you for the workaround :)

Closing this as innerRef has been fully removed in v5. Trigger components are now required to support ref or ref-forwarding.


Update please podspec in cocoapods repo.

Hi! Upload please podspec with AFNetworking 3.0 in cocoapods repo.

Done.


Add option for toggle effect

By default, instaFilta uses jQuery toggle(true/false) to hide or show targets. There should be an option to pass in whatever effect you like (fadeToggle, slideToggle etc).
The option should be allowed to be false, in case the user wants to hide/show using CSS classes alone instead of jQuery.

This has now been implemented, check out new options for effects and duration.
Bonus: Also added onFilterComplete callback.


HADOOP-14661. Add S3 requester pays bucket support to S3A

Description of PR
This change introduces support for "requester pays" S3 buckets (HADOOP-14661).
There was already some discussion and patches made available (e.g. #250), although the code base has changed a bit since then.
One concern for me is that unused options have been added both to the S3ClientCreationParameters (in March 2021) and SDK RequestFactory (in May 2021, as part of auditor changes). I've adopted the former approach which allows me to add the relevant header to all S3 requests in a fairly obvious place. Please let me know if either implementation method is preferred or if both are needed.
In summary:

Add some information to the main S3A documentation
Add example of error and how to fix/configure to troubleshooting doc
Add options to configure requester pays in S3A (fs.s3a.requester-pays.enabled) when creating S3A filesystem, which uses S3ClientFactory to create a new S3Client also taking this option
Add the required header inside S3ClientFactory if option was configured
Add new integration test which talks to publicly available usgs-landsat bucket (new version, not old) which is configured to require requester pays ('usgs-landsat' on Registry of Open Data on AWS).

How was this patch tested?
I created an EC2 instance and an S3 Bucket in eu-west-1 and ran the tests against the global S3 endpoint.
mvn -Dparallel-tests -DtestsThreadCount=16 clean verify

Note, the request pays specific tests introduced do not use the developer supplied bucket.
For code changes:

[x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[x] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[x] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 29s

trunk passed

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  7s

trunk passed

+1 :green_heart:
shadedclient
20m 30s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 20s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 43 new + 5 unchanged - 0 fixed = 48 total (was 5)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  7s

the patch passed

+1 :green_heart:
shadedclient
20m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  3s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

94m 41s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3962

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint

uname
Linux 1231c1f93b1c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4abf17d729a179b9fd787378de493daff05a3707

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/1/testReport/

Max. process+thread count
683 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
46m 44s

trunk passed

+1 :green_heart:
compile
0m 46s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 46s

trunk passed

+1 :green_heart:
javadoc
0m 27s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  8s

trunk passed

+1 :green_heart:
shadedclient
20m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 38s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 38s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 19s
/results-checkstyle-hadoop-tools_hadoop-aws.txt
hadoop-tools/hadoop-aws: The patch generated 11 new + 5 unchanged - 0 fixed = 16 total (was 5)

+1 :green_heart:
mvnsite
0m 35s

the patch passed

+1 :green_heart:
javadoc
0m 18s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  6s

the patch passed

+1 :green_heart:
shadedclient
20m 21s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  6s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

101m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3962

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint

uname
Linux 7b369d7a1a2f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b3c8ff2192d9500f8455d252a728caf5e6865db3

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/2/testReport/

Max. process+thread count
751 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  3s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  2s

codespell was not available.

+0 :ok:
markdownlint
0m  2s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
56m 44s

trunk passed

+1 :green_heart:
compile
0m 44s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 24s

trunk passed

+1 :green_heart:
mvnsite
0m 42s

trunk passed

+1 :green_heart:
javadoc
0m 23s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  4s

trunk passed

+1 :green_heart:
shadedclient
23m 49s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 16s

the patch passed

+1 :green_heart:
mvnsite
0m 33s

the patch passed

+1 :green_heart:
javadoc
0m 16s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  7s

the patch passed

+1 :green_heart:
shadedclient
23m  3s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 39s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

117m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3962

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint

uname
Linux 1a17c8ea41c4 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a401c3632a4b9e61092c08ed617befaf54bf7359

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/3/testReport/

Max. process+thread count
571 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Looks good to me.

@mukund-thakur would you be able to review this PR?

Sure will check early next week.

CC @steveloughran  @mehakmeet

Thanks for the comments, I have just pushed a few changes.
I also removed unused configuration from the RequestFactoryImpl - I am assuming since its under .impl package, it's fair game to remove without deprecation.

I am assuming since its under .impl package, it's fair game to remove without deprecation.

yes. though we do regularly found out where that's not always true (s3 client factory, store context). how do we find out? change things and see what breaks, then add comments in the javadocs to warn others

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 15s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 41s

trunk passed

+1 :green_heart:
javadoc
0m 22s

trunk passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m  6s

trunk passed

+1 :green_heart:
shadedclient
24m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 39s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
0m 39s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 37s

the patch passed

+1 :green_heart:
javadoc
0m 15s

the patch passed with JDK Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
1m 15s

the patch passed

+1 :green_heart:
shadedclient
23m 54s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 39s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

97m 39s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3962

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell markdownlint

uname
Linux 1d61db7c6595 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ae8e812e11148bcf007d51fbf94356229df4fae1

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.14+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/7/testReport/

Max. process+thread count
568 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3962/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@steveloughran I caught those after I pushed most of the other fixes from the last feedback and pushed a second commit ae8e812e11148bcf007d51fbf94356229df4fae1.
There's two Yetus comments, latest one seems happy. Are we good to merge?

merged to trunk, will cherrypick to 3.3 locally, retest and if all is good merge there too

Thanks Steve, Mukund, and Monthon for the reviews!


[language][vm] split Container::General/Resource into Container::Locals/VecR/VecC/StructR/StructC

Summary
This replaces Container::General/Resource with Container::Locals/VecR/VecC/StructR/StructC to allow clearer separation of roles.
Test Plan
cargo test

@dariorussi No is_valid_arg is not updated in this PR but I'll be working on it soon.

@bors-libra r=dariorussi

:pushpin: Commit f8f9733 has been approved by dariorussi

:hourglass: Testing commit f8f9733fa3984e6defbb49e5b17ae38197510a41 with merge 29f0dac774c89fd20f49ba0e8d4a174264098b8a...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: dariorussi
Pushing 29f0dac774c89fd20f49ba0e8d4a174264098b8a to master...


Google colab export failure

Traceback (most recent call last):
File "/usr/local/bin/ns-export", line 5, in
from nerfstudio.scripts.exporter import entrypoint
File "/usr/local/lib/python3.10/site-packages/nerfstudio/scripts/exporter.py", line 39, in
from nerfstudio.exporter import texture_utils, tsdf_utils
File "/usr/local/lib/python3.10/site-packages/nerfstudio/exporter/texture_utils.py", line 34, in
from nerfstudio.exporter.exporter_utils import Mesh
File "/usr/local/lib/python3.10/site-packages/nerfstudio/exporter/exporter_utils.py", line 28, in
import pymeshlab
File "/usr/local/lib/python3.10/site-packages/pymeshlab/init.py", line 11, in
from .pmeshlab import *
ImportError: /usr/local/lib/python3.10/site-packages/pymeshlab/lib/libmeshlab-common.so: undefined symbol: _ZdlPvm, version Qt_5
Reproduced by trying to export a mesh from nerfstudio on Google Colaboratory:
The command is:
!ns-export poisson --load-config outputs/unnamed/nerfacto/2023-10-13_101133/config.yml --output-dir exports/mesh/ --target-num-faces 50000 --num-pixels-per-side 2048 --normal-method open3d --num-points 1000000 --remove-outliers True --use-bounding-box True --bounding-box-min -1 -1 -1 --bounding-box-max 1 1 1

@Reznox7 This link will help you.


Container e2e is in a terminated state

What steps did you take and what happened:
Setup a minimal Kubernetes cluster using kubeadm with a single controlplane and single worker node.
Installed Calico.
Installed Sonobuoy to a Client with full access to the cluster.
Run Sonubuoy until it failed with the following error messages.
What did you expect to happen:
Successfully return results.
Anything else you would like to add:
Environment:

Sonobuoy version: v0.56.6
Kubernetes version: (use kubectl version): 1.23.6
Kubernetes installer & version: Kubeadm 1.24.0
Cloud provider or hardware configuration:
OS (e.g. from /etc/os-release): Rocky Linux 8.5
Sonobuoy tarball (which contains * below)

See complete terminal output below:
sonubuoy_fail.txt

If you could provide any logs for the e2e or worker containers that would be great. The --wait output is helpful to see as things run but it doesn't have the entirety of the info needed to debug a problem.
If you can either look in the tarball under podlogs... and/or the output from sonobuoy logs -p e2e, that would be helpful.

I've confirmed that v0.56.6 of sonobuoy and v1.23.6 k8s on a 2 node cluster like yours works fine, but I'm using a kind cluster.
If its a matter of it failing but only for calico or for kubeadm I'd be very curious why.

Thank you for your quick response. Attached you will find the sonobuoy logs -p e2e.
sonobuoy.logs.e2e.txt

It seems odd because the pods read as the phase "RUNNING" but the containers seem to be not ready. You should look into the status of those pods and see if you can fix those and rerun sonobuoy.

Thank you for your help. I found the issue and indeed it was not Sonobuoy. I did open the port for Calico in the firewall but forgot to make the rule permanent , so the pods failed after a restart. I works now.


Align bullets with first row of each item in FormattedList

MWE
using Markdown
using MakieSlides
using GLMakie
GLMakie.activate!()
fig = Figure()
MarkdownBox(fig[1,1], md"""
## Shopping list

---

- Cookies (I want the special ones with cookies on top of cookies)
- Milk
- Bananas
""")

display(fig)

yields the following if an item in the list happens to need a line break:

I would like an option to toogle whether the bullets align with the vertical center of the first row of each item, like it is done here on github, e.g.

Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

Idea
Right now this is implemented using a grid layout with two columns. The first one contains vertically centered Labels with the itemization symbols (either bullets or numbers) and the second one has the Labels with the text in it.
To address the above, we could perhaps also apply the scatter trick as suggested in #15, that is, replace the labels with an LScene and plot the symbols using scatter and position them with the boundingbox information from the item's labels.
EDIT: Update MWE to actually work.

Positioning item symbols with halign = :top, valign = :left improves things, but it is still not perfect.