Moving a window while cycling through spaces

First, I'd like to say I am really enjoying yabai. I've spent some time tweaking my config and have found myself looking for a solution to move windows without explicitly stating which space first.
For example - I'm currently using the following to loop through spaces with alt + space:
alt - space : yabai -m space --focus "$(yabai -m query --spaces --display \ 0 | jq 'reverse | nth(index(map(select(.focused == 1))) - 1).index')"
Is it possible to select a window, cycle through spaces, and drop it in the active space? This pattern would almost resemble a drag and drop, better yet, select and drop.
Using jq, I'm able to query for the active window id, as far as I know I can't set variables in my skhdrc. Is it possible to store this value somehow? If I could get over this hump I feel like the rest would come together fairly easily.
If I can clarify anything please let me know. It could be that this is simply not possible.

as far as I know I can't set variables in my skhdrc. Is it possible to store this value somehow?

I assume what you mean is that you would use one bind to select a window, and then press some other bind to actually perform the move operation?
If that is the case the only option I can think of right now would be to write the window id to some file /tmp/whatever and read that same file back in, when hitting the other bind.

@koekeishiya Thanks for the suggestion. I managed to get the following working:
Extract and store the currently focused window with:
echo $(yabai -m query --windows --window | jq -r '.id') > /tmp/window-id
Move window to focused space, and focus window:
yabai -m window $(cat /tmp/window-id) --space $(yabai -m query --spaces --space | jq -r '    .index') \ && yabai -m window --focus $(cat /tmp/window-id)
🎉

You can also use pbcopy and pbpaste instead of the temp file I suppose. echo “whatever” | pbcopy and pbpaste to retrieve it. This clobbers your clipboard, but I think it is possible to set which pasteboard to use in case that is a problem.

On 27 Apr 2020, at 22:00, Max Jowett<EMAIL_ADDRESS>wrote:
@koekeishiya https://github.com/koekeishiya Thanks for the suggestion. I managed to get the following working:
Extract and store the currently focused window with:
echo $(yabai -m query --windows --window | jq -r '.id') > /tmp/window-id
Move window to focused space, and focus window:
yabai -m window $(cat /tmp/window-id) --space $(yabai -m query --spaces --space | jq -r '    .index') \ && yabai -m window --focus $(cat /tmp/window-id)
🎉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/koekeishiya/skhd/issues/124#issuecomment-620201860, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABPDZV3IXI6B2DBU4RZLV43ROXP5LANCNFSM4MPZV46A.


No Metadata Available

We are just starting to use the tools.  Using the input tool we get the following on pressing "verify":
"The query was successful but no records were returned.  No metadata is available to generate output fields."
Assume this means we cannot use the "add field" facility, and that it cannot read the meta data from Neo4j (v4.4.8 enterprise)  - but I'm not sure.
Its just a test query: MATCH (t:Team) RETURN t.name and works ok in Neo4j browser.  We are using a specific database, not a default.
I'm not sure what could be wrong.

I can get the tool to work if remove the database name (there is some data in our default database)

Can you confirm the version of Graphyx that is installed?
The message suggests there are no Team nodes in your nba database. How many records does the query return in browser?
Once I know the version of Graphyx you have, I'll spin up a test instance and do some testing on my side to try and recreate the issue.

Yes, running Graphyx v1.0.6 (downloaded last Friday).  There were a few records returned.  See below for a new simple query.  When I tried using the default database (database left blank in graphyx tool) I could get a (different, but similar) query to work. But still can't get the specific database we are using to work when validate button is pressed.  See following screen shots of browser results and graphyx settings.

I'm still looking into this, but so far I have been unable to replicate.
Are you familiar with Alteryx's HTML Developer Tools?

No, I'm not familiar with those.  Did you try with a non default DB?  I tried some different cypher queries for the input tool but all fail in the same way.  I also tried same connection, but for the default DB (i.e. blank in tool db field) and they all work, when cypher returns a non-null value.  I as mentioned, I can use the export tool to load data into neo4j in that same "cedb" database.  Note, the database name is all lowercase chars in neo4j.

Yes, I frequently use the input tool with non-default DBs. I remember a version of the tools had the 'neo4j' database name embedded in the HTTP request, so the custom DBs weren't working. But that was from last year and should not be present in 1.0.6.
I will be updating the tools to 1.0.7 today or tomorrow. If ok with you, let's wait until it's available and see if it fixes your issue.

That's fine thanks

Apologies for the delay on this - the day job caught fire and required my attention.
I just released version 2.0.0 of the connectors. Try removing version 1 and installing version 2.
Note that version 2 is a breaking change. The URL you need to specify is no longer the HTTP endpoint, but rather the bolt endpoint. For you, that might be something like bolt://dai.mip.com.au:7687.
Let me know if you continue receiving the error and we can troubleshoot.


DS-448: Upgrade node v20 and npm packages

READY FOR REVIEW
Summary

Upgrade node v20 and npm packages

Review By (Date)

End of sprint

Criticality

3

Review Tasks
Setup tasks and/or behavior to test

Make sure everything works as expected

@sherakama content is coming from Storyblok and I've never used it before (I only signed in before to accept space invitations). How can I add this test script in Storyblok? Thanks.

Every day is a good day to learn new things. Log in to Storyblok and navigate to the development Space https://app.storyblok.com/#/me/spaces/118608/dashboard
Here, all the content is test content. You can create your own and play around with what you need to. Changes in that space won't automatically trigger a preview build to rebuild so you'll have to manually trigger a build on Netlify but your localhost should be connected to the same development space and you can see changes reflected there immediately.

@sherakama content is coming from Storyblok and I've never used it before (I only signed in before to accept space invitations). How can I add this test script in Storyblok? Thanks.

Every day is a good day to learn new things. Log in to Storyblok and navigate to the development Space https://app.storyblok.com/#/me/spaces/118608/dashboard
Here, all the content is test content. You can create your own and play around with what you need to. Changes in that space won't automatically trigger a preview build to rebuild so you'll have to manually trigger a build on Netlify but your localhost should be connected to the same development space and you can see changes reflected there immediately.
You can also spend some time levelling up your knowledge of the CMS service by going through their developer documentation: https://www.storyblok.com/docs/guide/introduction

@sherakama When I opened the Content section, I can't access anything (see screenshot above).
I read Storyblok documentation a little bit but I think this is out of scope of this PR. I can try to spend more time to get myself familiarize with Storyblok later. Can you test script tag in Storyblok since you can access it and are already familiar with it? I've added the sanitize options back. Thanks

@sherakama When I opened the Content section, I can't access anything (see screenshot above).

@stfurkan I went and checked all of the Storyblok spaces and it looks like we added your non-sso account. So I've gone ahead and swapped it out with your SSO account. Please try again.

@sherakama When I opened the Content section, I can't access anything (see screenshot above).

@stfurkan I went and checked all of the Storyblok spaces and it looks like we added your non-sso account. So I've gone ahead and swapped it out with your SSO account. Please try again.

Thanks @sherakama :)
It seems like we have a block (Embed Card) just for script tags. I used it and it's working. You can test it and see the alerts below. What should we do in this case?
https://dev--stanford-alumni.netlify.app/editor/?access_key=oO88EgKVEE7ShBwjFvEa8Qtt&path=test-furkan&_storyblok=412807424&_storyblok_c=page&_storyblok_version=&_storyblok_lang=default&_storyblok_release=0&_storyblok_rl=1701297164043&_storyblok_tk[space_id]=118608&_storyblok_tk[timestamp]=1701297163&_storyblok_tk[token]=72f36c934680005f8efebeaf80718ea16f29296d

Well, that was a fun surprise. 😆


[en] update custom-resources

Make it clear that the main API server delegates request to the user-created API server.

Explanation for API aggregation, not standalone API server.

Hi 👋
It looks like you've got two very similar PRs? https://github.com/kubernetes/website/pull/30406
Can you combine them to just one?

@geoffcline
Done!

/lgtm

/approve


latest JAR is lose efficacy URL

Download the latest JAR is only 200+Byte sizes

@my9074
Hi
please retry.
https://search.maven.org/remote_content?g=jp.wasabeef&a=recyclerview-animators&v=LATEST

@my9074
Hi.
How do?
compile 'jp.wasabeef:recyclerview-animators:1.2.3'


End of life for pouchdb-server ?

Hi,
@garethbowen, @marten-de-vries
I noticed that there hasn't been any new release since september 2019 and  there is quite a queue of dependabot PR's including some security related.
Does this means that pouchdb-server support has come to an end ? If so it would be nice if it was mentioned in the README.md so people know its time to move on.
Kind regards,
Hans

Looks a little abandoned 😬

This project was lasted updated at version: 4.2.0 on Sep 25, 2019, after a security issue (that was never addressed in change log...). There should be a stale/dead notice added to the readme. This project should also be closed or find a new maintainer.


Toggling the translation doesn't change the tool tip version

Bismillah.
I'm submitting a ...

[x] bug report
[ ] feature request
[ ] other

Current behavior:

Changing the translation still shows sahih when you hover over the word instead of the translation you picked
Expected / new behavior:

The tooltip should show the same version as the translation you picked from the drawer menu
For issue, please provide steps to reproduce it:

Select any surah
Select a translation other than sahih
Hover over one of the words
The tooltip shows a different version

Anything else:

Insha'allah this might not be a bug and rather something still a WIP. Also i would like to contribute my free time on working with this repo and no one has replied back to me for the backend-api request.

Salam brother @nasir-scalestack

The tooltip should show the same version as the translation you picked from the drawer menu

We only have one word by word english translation, so this isn't possible.

I would like to contribute my free time on working with this repo
Awesome, can you send your email? Let's discuss the issues and backend api on slack.


Abnormally long response time for 503 with v<IP_ADDRESS>

Hi there.
Compared to the old API (v0.9.7), the new API (v<IP_ADDRESS>) is more harsh in terms of rate limiting (http error 503), and occasionally there will be abnormally long response times. Here is the log.
Nov 04 01:10:14 xx bash[34204]: [GIN] 2024/11/04 - 01:10:14 | 503 |  8.028877771s | yy | POST     "/translate"
Nov 04 01:10:15 xx bash[34204]: [GIN] 2024/11/04 - 01:10:15 | 503 |  9.015709551s | yy | POST     "/translate"
Nov 04 01:12:42 xx bash[34204]: [GIN] 2024/11/04 - 01:12:42 | 200 |  6.550092592s | yy | POST     "/translate"
Nov 04 01:12:45 xx bash[34204]: [GIN] 2024/11/04 - 01:12:45 | 200 |  4.331374575s | yy | POST     "/translate"
Nov 04 01:13:10 xx bash[34204]: [GIN] 2024/11/04 - 01:13:10 | 200 |  5.601068367s | yy | POST     "/translate"
Nov 04 01:13:14 xx bash[34204]: [GIN] 2024/11/04 - 01:13:14 | 200 |  3.802606237s | yy | POST     "/translate"
Nov 04 01:30:07 xx bash[34204]: [GIN] 2024/11/04 - 01:30:07 | 503 |        21m30s | yy | POST     "/translate"
Nov 04 01:30:07 xx bash[34204]: [GIN] 2024/11/04 - 01:30:07 | 503 |        37m58s | yy | POST     "/translate"
Nov 04 01:32:55 xx bash[34204]: [GIN] 2024/11/04 - 01:32:55 | 200 |  3.491551547s | yy | POST     "/translate"
Nov 04 01:32:55 xx bash[34204]: [GIN] 2024/11/04 - 01:32:55 | 200 |  3.557510218s | yy | POST     "/translate"

Sorry but I couldn't find a way to reliably reproduce this phenomenon.

I use the latest version https://github.com/OwO-Network/DeepLX/releases/tag/v1.0.1
the same

the same

Maybe your requests are too frequent. Maybe a proxy pool is a good choice.

agreed, the use case is "Immersive Translate".  It will make concurrent requests


Getting CORS Issue while using OAuth 2 Client Credentials flow

Hi @justinyoo,
I am facing below CORS Issue while using OAuth 2 Client Credentials flow.

Access to fetch at 'https://login.microsoftonline.com/MyTenantId/oauth2/v2.0/token)' from origin 'http://localhost:7057' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

If I disable Chrome  browser security as below it works.

"C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" --disable-web-security --disable-gpu --user-data-dir=C:/Users/[My user name]/AppData/"

I am describing  OAuth 2 Client Credentials flow on my API with OpenApiSecurity attribute with the Flows property pointing to my (client credentials) configuration:
 `[OpenApiSecurity(ClientCredAuthFlow.SchemeName, SecuritySchemeType.OAuth2, Flows = typeof(ClientCredAuthFlow))]`

My Client credentials configuration is as below
public class ClientCredAuthFlow : OpenApiOAuthSecurityFlows
{
    private string _authTokenRefreshUrl = Environment.GetEnvironmentVariable("AuthTokenRefreshUrl");
    private string _tenantId = Environment.GetEnvironmentVariable("TenantId");
    private string _clientId = Environment.GetEnvironmentVariable("ClientId");
    public const string SchemeName = "ClientCredAuthFlow";

    public ClientCredAuthFlow()
    {
        var scope = string.Concat("api://", _clientId, "/.default");

        this.ClientCredentials = new OpenApiOAuthFlow()
        {
            Scopes = { { scope, "Default scope defined in the app" } },
            TokenUrl = new Uri(string.Format(_authTokenRefreshUrl, _tenantId))
        };
    }
}

How I can deal to this CORS issue.
I tried allowing CORS using local.settings.json as below
`{
"IsEncrypted": false,
"Values": {
},
"Host": {
"LocalHttpPort": 7071,
"CORS": "*"
}
}`
But still getting same error.

@vinodrpatgithub Thanks for reaching out! Assuming that you're using Azure AD's OAuth2 client credential flow.
When I look at your code snippet, I see your scope setting is slightly different:
var scope = string.Concat("api://", _clientId, "/.default");

According to the Microsoft Graph document, it should be https://graph.microsoft.com/.default.
Have you tried that?

Thanks @justinyoo for your response.
I tried using 'https://graph.microsoft.com/.default' but I am not able to get token with it. Microsoft Graph document, mentioned applicationID Uri with .default suffix as well as below.
The value passed for the scope parameter in this request should be the resource identifier (application ID URI) of the resource you want, affixed with the .default suffix. For the Microsoft Graph example, the value is https://graph.microsoft.com/.default.
Also my _authTokenRefreshUrl  is 'https://login.microsoftonline.com/{0}/oauth2/v2.0/token'

Let me try on my end and get back to you.

Hi @justinyoo , I have added sample code for your reference here - https://github.com/vinodrpatgithub/AzureAd-oAuth-ClientCred-OpenApi . Few settings needs to be updated in ''appsettings.json" and "local.settings.json" from Azure Ad app.
Please let me know if you need any additional details.

I have the same issue (and code setup) for both Client Credentials, and I see similiar problems for the Authorization Code flow that the CORS policy is blocking communication between the Swagger UI page and the AAD token endpoints.
Happens both when running locally and when hosted in Azure functions app.

Please make sure that you can't use the client credential auth flow on SPA. The client credentials workflow document describes that it needs a server or daemon, instead of SPA (Swagger UI in our case).
We can't use the authorisation code auth flow either due to the lack of support of PKCE certificate. We will start supporting this feature when the OpenAPI spec v3.1.0 is supported.

Thanks @justinyoo for the clarification


[BUG]: AnythingLLM desktop fails to start

How are you running AnythingLLM?
AnythingLLM desktop app
What happened?
On OSX 15.0 with anythingLLM 1.6.7, launching the desktop app does not open any window (does create a taskbar button and an electron/anythingllm menu but no window opens).
Running from the terminal, a window does open but it just shows a splash screen ("loading workspaces"). In the terminal I see the following error:
$ /Applications/AnythingLLM.app/Contents/MacOS/AnythingLLM
[Preferences] preference config stored at /Users/user/Library/Application Support/anythingllm-desktop/config.json
Prisma schema loaded from prisma/schema.prisma
Datasource "db": SQLite database "anythingllm.db" at "file:/Users/kosta/Library/Application Support/anythingllm-desktop/storage/anythingllm.db"

Already in sync, no schema change or pending migration was found.

EPERM: operation not permitted, open '/Applications/AnythingLLM.app/Contents/Resources/backend/node_modules/.prisma/client/index.js'

Prisma schema loaded from prisma/schema.prisma
Error:
EPERM: operation not permitted, open '/Applications/AnythingLLM.app/Contents/Resources/backend/node_modules/.prisma/client/index.js'

[OllamaProcessManager] Ollama will bind on port 51418 when booted.
[Preferences] Will load window with last know bounds.
node:internal/modules/cjs/loader:1087
  throw err;
  ^

Error: Cannot find module '.prisma/client/index'
Require stack:
-<EMAIL_ADDRESS>- /Applications/AnythingLLM.app/Contents/Resources/backend/server.js
-
    at node:internal/modules/cjs/loader:1084:15
    at Function._resolveFilename (node:electron/js2c/utility_init:2:3040)
    at node:internal/modules/cjs/loader:929:27
    at Function._load (node:electron/js2c/asar_bundle:2:13327)
    at Module.require (node:internal/modules/cjs/loader:1150:19)
    at require (node:internal/modules/cjs/helpers:110:18)
    at Object.<anonymous> (/Applications/AnythingLLM.app/Contents/Resources/backend/node_modules/@prisma/client/index.js:2:6)
    at Module._compile (node:internal/modules/cjs/loader:1271:14)
    at Object..js (node:internal/modules/cjs/loader:1326:10)
    at Module.load (node:internal/modules/cjs/loader:1126:32) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
<EMAIL_ADDRESS>    '/Applications/AnythingLLM.app/Contents/Resources/backend/server.js',
    undefined
  ]
}

Node.js v18.16.1
2024-09-22 09:33:44.540 AnythingLLM[10928:7789349] +[IMKClient subclass]: chose IMKClient_Legacy
2024-09-22 09:33:44.540 AnythingLLM[10928:7789349] +[IMKInputSession subclass]: chose IMKInputSession_Legacy
[collector] info: Collector hot directory and tmp storage wiped!
[collector] info: [production] AnythingLLM Standalone Document processor listening on port 8888.
^C[Preferences] Saving last_bounds preference.

Looking in the node_modules directory, I see that there is no .prisma folder.
Are there known steps to reproduce?
No response

Attempting to run 1.6.6 yields the same error.

Not sure exactly what happened but after restoring the app from trash it suddenly works, I will close for now.

Maybe had AnythingLLM open at the same time in BG while mounting the new one?


Feat: Table for transactions page

Describe the feature
I want to create a transaction table on transaction page which will tell the transactions made by the person
Hope you would assign this task to me
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Bhavishya2601  can you please mention your Pull Request here?


Need 404 page

This is the design that we have in Figma.

For the DS website, we can remove the search bar.

I think that works.

I have an example ready in PR #572.
One important difference is that we don't have a search box on the Design System site yet. Open to suggestions if there's anything else we can do at this time. I tried linking to a site-specific Google search, but Google hasn't indexed our site yet.
It's also important to note that this page will not appear for 404s in our PR preview site. The PR preview sites are a little special and don't support this yet. But it should work in production.

Looks good to me.

Cool, I merged it into the site to stop the bleeding, for now. We can change it any time.

Another thing to consider:

Asking "Did you find what you're looking for?" right underneath "We can't find what you're looking for." is a little silly. But I could see the argument for keeping some form of feedback here, since we may be able to solicit very useful information in this situation.
I may put in an additional PR to suppress page feedback on the error page, for now.

I had the same thought @xjensen. If i'm not mistaken, most people arrive at a 404 because:

Typo (in which case the form is not helpful)
Broken link (in which the case form may be helpful)

@adam-little That sounds right. If I had to guess, broken links would be the more common case. On Drought, for example, most of the 404s were due to outdated links on Google.


Possible workaround to edit line not in Constants.xaml

Wondering if it's possible to find a workaround to values that are not directly in the Constants.xaml file but on any other theme file.
I have the following in DerivedStyles\PlayButton.xaml

Since an animation is used, I can't use a DynamicResource and have to set the color directly. A possible solution would be to indicate in the constants file:

File to edit
Number of line to edit
Property to edit

Format: File, Line, Property
In my case, for example:
ThemeApiVersion: 1.9.0
Id: Harmony_d49ef7bc-49de-4fd0-9a67-bd1f26b56047
Name: Harmony
Author: darklinkpower
Version: 0.90
Links:
    - Name: Playnite Forums thread
      Url: https://playnite.link/forum/thread-457.html

to
ThemeApiVersion: 1.9.0
Id: Harmony_d49ef7bc-49de-4fd0-9a67-bd1f26b56047
Name: Harmony
Author: darklinkpower
Version: 0.90
Links:
    - Name: Playnite Forums thread
      Url: https://playnite.link/forum/thread-457.html

DirectProperties:
- File: DerivedStyles\PlayButton.xaml
  Line: 160
  Property: To
- File: DerivedStyles\PlayButton.xaml
  Line: 167
  Property: To

This would allow the extension to modify themes to a greater extent since anything could be modified.

I think this would be a pain to implement and wouldn't work reliably so I'll be closing it.


max zoom

hello,
thank u for the great code!
i have a issue i sucssed to start the zoom that i want with [zoom] but how i limitid it?
is there option to limit the zoom. on google maps the soulotion is very simple   map.setOptions({ minZoom: 5, maxZoom: 15 });
how we can get the same result on agm?
thanks,
Mati

ok, after check its very simple we can see all inputs and outpus in the directive.
and we can pass maxZoom and minZoom


Removing autogenerated RSTs from doc/source/schemas after build.

The make docs (and mvn package) command auto-generates a collection of .rst files in doc/source/schemas, that are then committed to the repository. This is made worse by the fact that changing file x.avdl results in an update to the corresponding autogenerated x.rst, but not an update of any y.rst for y.avdl which imports x.avdl. This in turn causes inconsistent documentation to be generated when changes to record definitions in frequently included .avdl files are made.
This PR aims to solve the situation by explicitly removing the autogenerated rst files from git, and by adjusting the Makefiles to automatically scrub all these autogenerated files at the end of make docs.

Pulled it down, ran make docs and was happy to see the source tree not polluted by the autogenerated .RSTs.
+1, @mbaudis as the original shell developer for this mind taking it for a spin?

-1 sadly.  This was added to make the readthedocs build work.  It will go away
with the conversion to protocol buffers.
Maciek Smuga-Otto<EMAIL_ADDRESS>writes:

The make docs (and mvn package) command auto-generates a collection of .rst
files in doc/source/schemas, that are then committed to the repository. This is
made worse by the fact that changing file x.avdl results in an update to the
corresponding autogenerated x.rst, but not an update of any y.rst for y.avdl
which imports x.avdl. This in turn causes inconsistent documentation to be
generated when changes to record definitions in frequently included .avdl files
are made.
This PR aims to solve the situation by explicitly removing the autogenerated
rst files from git, and by adjusting the Makefiles to automatically scrub all
these autogenerated files at the end of make docs.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
You can view, comment on, or merge this pull request online at:
https://github.com/ga4gh/schemas/pull/551
Commit Summary
• Removing autogenerated RSTs from doc/source/schemas after build.
File Changes
• M .gitignore (5)
• M Makefile (5)
• M doc/source/schemas/Makefile (3)
• D doc/source/schemas/common.rst (107)
• D doc/source/schemas/metadata.rst (185)
• D doc/source/schemas/metadatamethods.rst (237)
• D doc/source/schemas/methods.rst (7)
• D doc/source/schemas/readmethods.rst (554)
• D doc/source/schemas/reads.rst (407)
• D doc/source/schemas/referencemethods.rst (379)
• D doc/source/schemas/references.rst (199)
• D doc/source/schemas/variantmethods.rst (475)
• D doc/source/schemas/variants.rst (297)
Patch Links:
• https://github.com/ga4gh/schemas/pull/551.patch
• https://github.com/ga4gh/schemas/pull/551.diff
—
Reply to this email directly or view it on GitHub.*

this will be fixed in the conversion to prootocl buffers


coprocessor: decode_time and decode_duration using BufferReader

What have you changed?
use BufferReader of codec component to decode time and duration.
What is the type of the changes?
Improvement
How is the PR tested?
unit test
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect tidb-ansible?
No

Any benchmark result?

/run-all-tests

/merge


Add fancy navbar component

I want to add a new component using Pure React.

Pls come up with a minimal and that follows the design pattern


Be able to setup FileArchiver to run before retention hits the database and not run per event

In order to eliminate double logging I would like to be able to run FileArchiver as a archiver and not second data recorder.  I mean retention system should be able to trigger FileArchiver to backup the events that will be wiped out.

Hi @cilerler - thanks for this note, I gave some thought to how this might be done, but it seems I never managed to follow up via the ticket. Sorry about that!
Implementing this would require a substantial overhaul of the Seq retention processing system, which is unlikely in the near future (it's very perf-sensitive so takes time to change).
I'll close this as I think the "eager" archiving is a workable option for now, but I'll definitely keep the possibility of doing this upon deletion in mind.
Thanks again, and sorry again for the slow response!
Nick

Thank you for the update @nblumhardt


Raids scouting plugin

Adds a raids scouting feature to the raids plugin.
Blacklisted rooms are displayed in red

Depends on  #487 and #591

Okay idk how all these other commits got added in here lmao :-( my bad

Okay idk how all these other commits got added in here lmao :-( my bad

git rebase -i is your best friend when it comes to squashing extraneous commits like that


MINIFI-515 Use a repository location with long lived versions for the…

… commons-daemon Windows binary files.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically master)?

[ ] Is your initial contribution a single, squashed commit?

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

I honestly don't know if it makes any difference, but would you want to use repo.maven.apache.org?

we need to make sure the repo location we use is appropriate for frequent builds/mirroring and not pull directly from apache

the one listed is maven central, so I think it ticks all those boxes


UserVisibleServiceTimeoutException

Anyone has Idea what this means?
I am trying to run a dotnet core 3.1 project in dev-spaces.
It worked when I trued to run with "Local Proecess with Kubernetes"
I have created a privace space. I also tried the bicycle sample project in this space, and worked OK.
I have tried to search for UserVisibleServiceTimeoutException, nowhere to be found.
Thanks in advance..
λ azds space list

Name          DevSpacesEnabled

cert-manager  False
default       False
lifecycle     False
production    False
staging       False
test          True
test/bernt    True
Part of the error message:
"spaceName": "test",
"devSpacesConfigName": "develop",
"exception": {
"ClassName": "Microsoft.VisualStudio.Containers.Tools.Common.ContainerToolsException",
"Message": "Timed out after 1m trying to list azds pods.",
"Data": null,
"InnerException": {
"ClassName": "Microsoft.Azure.DevSpaces.Common.Exceptions.UserVisibleServiceTimeoutException",
"Message": "Timed out after 1m trying to list azds pods.",
"Data": null,
"InnerException": null,
"HelpURL": null,
"StackTraceString": "   at Microsoft.Azure.DevSpaces.Client.ServiceClients.ExecSignalRServiceClient.d__27.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.Azure.DevSpaces.Client.ServiceClients.ExecExceptionStrategy.<>c__DisplayClass3_0.<b__0>d.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)\r\n   at Microsoft.Azure.DevSpaces.Client.ServiceClients.ExecExceptionStrategy.d__41.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd(Task task)\r\n   at Microsoft.Azure.DevSpaces.Client.ManagementClients.ServiceManagementClientImplementation.<ListAzdsPodsAsync>d__55.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.Azure.DevSpaces.Client.ManagementClients.ServiceManagementClientImplementation.<GetAzdsReleaseInnerAsync>d__54.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.Azure.DevSpaces.Client.ManagementClients.ServiceManagementClientImplementation.<GetAzdsReleaseAsync>d__53.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.Azure.DevSpaces.Client.Extensions.OwnedExtensions.<>c__DisplayClass2_02.<b__0>d.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.Azure.DevSpaces.Client.Utilities.AutofacUtilities.d__31.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at Microsoft.Azure.DevSpaces.Client.Utilities.AutofacUtilities._Handle[T](Exception e, ILog log, IOperationContext operationContext, Boolean isRecurse)\r\n   at Microsoft.Azure.DevSpaces.Client.Utilities.AutofacUtilities.<TryRunWithErrorPropagationAsync>d__31.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Common.Client.DevSpacesServiceClient.<>c__DisplayClass25_0.<b__0>d.MoveNext()\r\n--- End of stack trace from previous location where exception was thrown ---\r\n   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)\r\n   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)\r\n   at Microsoft.VisualStudio.Azure.DevSpaces.Tools.Common.Logging.PerfLoggerExtensions.d__3`1.MoveNext()",
"RemoteStackTraceString": null,
"RemoteStackIndex": 0,
"ExceptionMethod": "8\nMoveNext\nMicrosoft.Azure.DevSpaces.Client, Version=1.0.3571.658, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a\nMicrosoft.Azure.DevSpaces.Client.ServiceClients.ExecSignalRServiceClient+d__27\nVoid MoveNext()",
"HResult": -2146233088,
"Source": "Microsoft.Azure.DevSpaces.Client",
"WatsonBuckets": null
},
"HelpURL": null,
"StackTraceString": null,
"RemoteStackTraceString": null,
"RemoteStackIndex": 0,
"ExceptionMethod": null,
"HResult": -2146233088,
"Source": null,
"WatsonBuckets": null
},
"operationName": "GetKubeCtlExecCommand",
"stage": "End",
"elapsedTime": "00:01:04.6196522",
"completionState": "Error"
"ClassName": "Microsoft.VisualStudio.Containers.Tools.Common.ContainerToolsException",
"Message": "Timed out after 1m trying to list azds pods.",
"Data": null,

Maybe misleading: When I try azfs up --verbise, I get this.
It seems to have problem with private nuget repository.
Normal build succeeded. Dows one have to treat private nuget repositories especially?
Step 11/16 : RUN dotnet restore "api/api.csproj"
---> Running in fada577685a5
Determining projects to restore...
/src/api/api.csproj : error NU1101: Unable to find package Portal.Events. No packages exist with this id in source(s): nuget.org
/src/api/api.csproj : error NU1101: Unable to find package xxx. No packages exist with this id in source(s): nuget.org
Restored /src/api.core/api.core.csproj (in 10.95 sec).
Failed to restore /src/api/api.csproj (in 10.96 sec).
Restored /src/xx/xxx.csproj (in 252 ms).


feat: add proposals api and view

Types of changes

[ ] Bugfix
[x] New feature
[ ] Refactoring
[ ] Breaking change (any change that would cause existing functionality to not work as expected)
[ ] Documentation Update
[ ] Other (please describe)

Description

add proposals api url
add proposals api view

Steps to Test This Pull Request
Steps to reproduce the behavior:

Go to 'http://localhost:8000/api/proposals/'

Expected behavior
response will be

num_proposal_talk
num_proposed_tutorial
num_stage_1_reviews
num_stage_2_reviews

Related Issue
#1127

PR 不直接指到 master branch 嗎？
flake8 沒過，記得修一下

Codecov Report
Patch coverage has no change and project coverage change: -0.06 :warning:

Comparison is base (aeeaa7b) 69.46% compared to head (7891117) 69.40%.

:exclamation: Current head 7891117 differs from pull request most recent head 0d39f03. Consider uploading reports for the commit 0d39f03 to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
- Coverage   69.46%   69.40%   -0.06%
==========================================
  Files          82       84       +2
  Lines        3357     3380      +23
==========================================
+ Hits         2332     2346      +14
- Misses       1025     1034       +9

Impacted Files
Coverage Δ

pycontw2016/urls.py
85.71% <0.00%> (ø)

proposals/api/views.py
50.00% <0.00%> (ø)

proposals/api/urls.py
100.00% <0.00%> (ø)

proposals/management/commands/recent_proposals.py
98.76% <0.00%> (+1.23%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Initial suggestions for plugin release

Thanks @ajmaradiaga for this new plugin. Great work 🎉 !!
The basic structure looks good so far. While using the plugin, we did come up with a few suggestions based on our best practices:
config/btp.spc

We should have a single file named btp.spc under the config folder that will contain a basic connection for the plugin (see  namecheap plugin for reference)
Could you please update the btp.spc file to follow the format of the namecheap plugin
Can you mention which of these parameters are required and which are optional as done in the namecheap plugin
We should mention values for all the config arguments however commented out and the values should be in the format of the actual values (however incorrect)
We should also add details to set these parameters via the environment variable (if any)

docs/tables/*

We should have a folder called docs under which we will have a single file called index.md (reference) and individual table docs for each table
The table docs should be named as eg > btp_datacenter.md (note: The table names should be singular)
Each table doc should have the following parts >

A heading in the format > # Table: btp_datacenter
A description of the table
A number of queries which will have the title followed by the query (Note: We do not include the query outputs in the docs)

docs/index.md

Needs to be added (reference)

btp/*

Please add the configuration for setting the config arguments via the environment variable
The table file names should be in singular and in snake_case for example : table_btp_accounts_directories.go
The table file name should be in sync with the table name in the code
It is better to print the type of error when we encounter any like connection_error or api_error for easier debugging if needed

btp/table_btp_datacenter

The name of the file should be table_btp_datacenter.go
The function name should be tableBTPDatacenter
The name of the table should be btp_datacenter
The column descriptions should end with a .
The geo_access column does not have a description we should add it
It is better to use d.EqualsQualString["region"] instead of equalQuals["region"].GetStringValue()

btp/table_btp_directory

The name of the file should be table_btp_directory.go
The function name should be tableBTPDirectory
The name of the table should be btp_directory
The column descriptions should end with a .
The directory_type and parent_guid1 columns do not have a description we should add it
It is better to use d.EqualsQualString["region"] instead of equalQuals["region"].GetStringValue()

btp/table_btp_global_account

The name of the file should be table_btp_global_account.go
The name of the table should be btp_global_account
The name of the list call should be listGlobalAccounts
The column descriptions should end with a .

btp/table_btp_subaccount

The name of the file should be table_btp_subaccount.go
The name of the table should be btp_subaccount
The name of the list call should be listSubaccounts
The column descriptions should end with a .
The parent_type column does not have a description we should add it

btp/plugin.go

The list of tables should be sorted in ascending order

btp/utils.go

Please rename the btp.go file to utils.go

bt/types.go

Rename to types.go

README.md

Please update the file to follow the format of the namecheap plugin
Please include all the necessary sections as mentioned above

CHANGELOG.md

Please draft an initial Changelog for the plugin release, an example would be as follows:

## v0.0.1 [TBD]

_What's new?_

- New tables added
  - [btp_datacenter](https://github.com/ajmaradiaga/steampipe-plugin-btp/blob/main/btp/table_btp_datacenter.go)
  - [btp_directory](https://github.com/ajmaradiaga/steampipe-plugin-btp/blob/main/btp/table_btp_directory.go)
  - [btp_global_account](https://github.com/ajmaradiaga/steampipe-plugin-btp/blob/main/btp/table_btp_global_account.go)
  - [btp_subaccount](https://github.com/ajmaradiaga/steampipe-plugin-btp/blob/main/btp/table_btp_subaccount.go)

Please note that the example contains the name in singular assuming that the changelog will be added after updating the table names.
Makefile

The path is incorrect please update it to

go build -o<EMAIL_ADDRESS>*.go

Follow-up questions

A couple of follow-up questions:

How are we handling the resource not found errors?
Do the APIs support pagination? I did not find any reference to it, but I want to make sure that we have checked that box before releasing it.
While working with the APIs did you encounter rate limit errors?
Please refer to https://steampipe.io/docs/develop/plugin-release-checklist#data-ingestion for more information

Please let us know if you have questions, happy to help 👍

Thanks for all the suggestion. Great timing as I'm currently working on the plugin and I will dedicate some time to make it "hub-ready"

@madhushreeray30, I've made some progress on the suggestions that you've specified in this issue. The changes are in a separate branch... you can have a quick look here - https://github.com/ajmaradiaga/steampipe-plugin-btp/tree/plugin-feedback

@madhushreeray30 everything is now ready for a review


Update to OpenCensus 0.24.0

@chingor13

This needs to fix usage of a private constant. See the change I made in your previous PR #788


Add resistance for moving mouse Between Monitors near boundary

Description of the new feature / enhancement
Toggle in Mouse Utilities that makes movement between monitors "Sticky," i.e, you need to move the mouse faster/farther to get from one display to another
Scenario when this would be used?
Clicking buttons on the edge of the screen is difficult because the mouse jumps to the other monitor. This makes moving the mouse to another monitor more intentional, and less likely to happen accidentally.
Supporting information
This is part of an old piece of software called Dual Monitor Tools. As described by their website:

The cursor is allowed to move between screens, but there is some resistance to moving between the screens. You can adjust the resistance using the Resistance to movement between screens slider.

Source: http://dualmonitortool.sourceforge.net/dmt_cursor.html

@ActualBest looks like this man had the opposite situation - possible solution? https://www.youtube.com/watch?v=U9ZgCBIgGg8

Adding resistance would be great in situations where the PC is playing event media, and the output device is acting as a second monitor. It would be nice to prevent the mouse from moving to the second screen. Options to add resistance or to prevent it completely, allowed with a hot key, would give a bit more flexibility.


allow default branch to be set

GHRepository did not provide a method to set the default branch.
Note that https://github.com/kohsuke/github-api/pull/189 is required for this to work.

Kohsuke Kawaguchi » github-api #342 SUCCESS
This pull request looks good
(what's this?)


Autocomplete not working

e.g.
@singleton
@dataclass
class Configuration:
    """Implementation fixed configuration."""

    history_length: int
    """TOOD"""

    frequency: timedelta
    """Frequency f (i.e. duration per round) given in seconds."""

and
config = Configuration("asdf")

then config. does not autocomplete in vs code

See e.g. https://stackoverflow.com/questions/71870864/how-to-write-a-dry-wrapper-that-works-with-intellisense-in-python


“record not found" Never should an Error!!!!!!!!!!!!!!!!!!!!!!!!!!

Your issue may already be reported! Please search on the issue track before creating one.
What version of Go are you using (go version)?
Which database and its version are you using?
Please provide a complete runnable program to reproduce your issue. IMPORTANT
Need to runnable with GORM's docker compose config or please provides your config.
package main

import (
	"github.com/jinzhu/gorm"
	_ "github.com/jinzhu/gorm/dialects/mssql"
	_ "github.com/jinzhu/gorm/dialects/mysql"
	_ "github.com/jinzhu/gorm/dialects/postgres"
	_ "github.com/jinzhu/gorm/dialects/sqlite"
)

var db *gorm.DB

func init() {
	var err error
	db, err = gorm.Open("sqlite3", "test.db")
	// db, err = gorm.Open("postgres", "user=gorm password=gorm DB.name=gorm port=9920 sslmode=disable")
	// db, err = gorm.Open("mysql", "gorm:gorm@tcp(localhost:9910)/gorm?charset=utf8&parseTime=True")
	// db, err = gorm.Open("mssql", "sqlserver://gorm:LoremIpsum86@localhost:9930?database=gorm")
	if err != nil {
		panic(err)
	}
	db.LogMode(true)
}

func main() {
	if /* failure condition */ {
		fmt.Println("failed")
	} else {
		fmt.Println("success")
	}
}

Do you need a new keyboard? Your ! key seems to be broken


server2 SCSI controller in use

VirtualBox version:
VirtualBox-6.1.x86_64
Vagrant Version:
Vagrant 2.2.7
OS:
Linux 5.4.19-200.fc31.x86_64
Error during vagrant up server2
Stderr: VBoxManage: error: Storage controller named 'SATA Controller' already exists VBoxManage: error: Details: code VBOX_E_OBJECT_IN_USE (0x80bb000c), component SessionMachine, interface IMachine, callee nsISupports
It is the first time that i use vagrant, but I fixed it in modifying Vagrantfile in this way
diff Vagrantfile Vagrantfile.ori
24,27c24,25
<     if not File.exist?(file_to_disk1)
<       server2.customize ['storagectl', :id, '--name', 'SATA Controller', '--add', 'sata', '--portcount', 2]
<       server2.customize ['storageattach', :id,  '--storagectl', 'SATA Controller', '--port', 1, '--device', 0, '--type', 'hdd', '--medium', file_to_disk1]
<     end
-----------------------------
>     server2.customize ['storagectl', :id, '--name', 'SATA Controller', '--add', 'sata', '--portcount', 2]
>     server2.customize ['storageattach', :id,  '--storagectl', 'SATA Controller', '--port', 1, '--device', 0, '--type', 'hdd', '--medium', file_to_disk1]

I hope that this could be helpful.

I changed some things around. Run vagrant destroy -f && git pull && vagrant up to implement them.

Also the environment uses virtualbox 6.0 and vagrant 2.2.6, not sure if that is what could be causing it

I got the new version but still the same error:
==> server2: Running 'pre-boot' VM customizations...
A customization command failed:

["storagectl", :id, "--name", "SATA Controller", "--add", "sata", "--portcount", 2]

The following error was experienced:

#<Vagrant::Errors::VBoxManageError: There was an error while executing `VBoxManage`, a CLI used by Vagrant
for controlling VirtualBox. The command and stderr is shown below.

Command: ["storagectl", "da9434a5-af82-427c-9421-e0ffb337bc9c", "--name", "SATA Controller", "--add", "sata", "--portcount", "2"]

Stderr: VBoxManage: error: Storage controller named 'SATA Controller' already exists
VBoxManage: error: Details: code VBOX_E_OBJECT_IN_USE (0x80bb000c), component SessionMachine, interface IMachine, callee nsISupports
VBoxManage: error: Context: "AddStorageController(Bstr(pszCtl).raw(), StorageBus_SATA, ctl.asOutParam())" at line 1078 of file VBoxManageStorageController.cpp
>

Please fix this customization and try again.

I have tried to update VBoxGuestAddition, but still the same error.
To fix it I have changed the "if" mentioned in the bug request, could be that in the new Virtual Box version something is changed in how to handle the SATA Controller.
So far is not a big deal.

I only run into this error with I run vagrant up multiple times. Are you sure you're only running vagrant up once? If so, would you mind creating a PR with you fix so I can test it? Thanks in advanced.

Sorry I didn't get this message.
You are right I get this only after the first up.
I will test even if the suspend and resume procedure I got the same error.
In any case I will open the PR tonight or tomorrow.
Sorry again for the late reply
On Sun, 23 Feb 2020 at 20:09, rdbreak<EMAIL_ADDRESS>wrote:

I only run into this error with I run vagrant up multiple times. Are you
sure you're only running vagrant up once? If so, would you mind creating
a PR with you fix so I can test it? Thanks in advanced.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rdbreak/rhcsa8env/issues/13?email_source=notifications&email_token=ADXKCQZKCQY5IO3G5ZHYPADRELJZBA5CNFSM4KZCAFMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMWF52Y#issuecomment-590110443,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADXKCQYO6NP6VYNOIWWL74DRELJZBANCNFSM4KZCAFMA
.


fix highlighting for seat, mouse_warping, focus_wrapping

Thanks! Would you mind adding a test for the seat keyword?

Good point, seat wasn't working at all :) Should be fixed.

I've split the commits into more atomic ones since I'll eventually be adding the relevant ones to upstream vim.
Thanks for your work!

Thanks a lot. I'll try to produce more granular commits next time if that's preferred!


CRB-410 Deploy log4sdc infrastructure v1.2

JIRA Ticket
SDC-5102
Summary
Implements API Gateway, SQS message queue, ElasticSearch publisher lambda function, and ElasticSearch components to ensure unified logging, alerting, and notification infrastructure and its future utilization.

@JeffUssing  Per previous discussion: test plan is still being worked on; the rest of files should be in fair shape and ready for review. Thanks! -v

Test plan has been updates as well.


Previous/Next articles order

Bug Report
Environment
Zola version: 0.18.0
tabi version or commit: 124c31eea62b1f992061ea6088298ddeb0f3e3da
Expected Behavior
I would expect the previous/next articles link to be in the same order as paginated posts and usual browser configuration i.e.
previous article on the left (with an arrow pointing to the left) and next article on the right (with an arrow pointing to the right).
Current Behavior
The previous article is on the right and the next article is on the left
From Zola documentation (https://www.getzola.org/documentation/content/section/#date), pages are sorted by date from most recent to oldest which means most recent page has lowest id.
Maybe switching page.lower and page.higher in tempates/page.html would be enough but I was not able to test it yet.
Step to Reproduce
Just set up a minimal site with two articles and set show_previous_next_article_links to true in config.toml.
It can also be observed in the demo site (e.g. https://welpo.github.io/tabi/blog/mastering-tabi-settings/ which is the last article will have a link to previous article on the right).

I had some time to propose a fix.
I let you have a look at it and tell me if there is anything to change or if I misunderstood the expected result of this feature.
Many thanks in advance.

I'm not sure about this.
I looked for some examples:

Substack appears to do it the way you expect it to work
Tim Pope's blog works as it's implemented in tabi
Most other random blogs I visited, if they had the feature, it worked as it's implemented in tabi

So I'm not sure there's a standard. I see merits to both approaches.
Unless there's an authoritative guideline somewhere, my approach would be to add a custom option so users can invert the current order.
Perhaps a very verbose variable like invert_previous_next_article_links.

Thanks for the head's up.
It felt obvious to me at first.
For people writing left to right, what is written (so the past/previous) is on the left and what has to be written (so the future/next) is on the right. In the same way, timelines have time flowing from the left (past) to the right (future).
But after searching a bit about the topic, I am far less confident.
I was not able to find any authoritative guideline either and I understood such a consideration may be localized as well (people writing from right to left may have different feelings).
When looking at how zola works, the paginator has previous page on the left and next page on the right.

Nevertheless, as posts are ordered most recent first, next page means previous posts...
It doesn't help much.
I'll implement invert_previous_next_article_links variable and add in the documentation what is the default order and what is the reverse one.
I was wondering if there were anything special to take into account if the language displayed is right to left (RTL).
It seems zola supports RTL but did you do anything special for tabi?
In addition, what do you think about adding "Prev: " and "Next: " just before the article title in order to completely remove any ambiguity?
If it makes sense to you, I could implement another very verbose variable like label_previous_next_article_links to add the labels only if wanted.
Last but not least, has "‹ ›" been used on purpose instead of "← / →" used for similar links?
If it was not, I can take care of using the arrow instead.
Thanks for your help and guidance.

I'll implement invert_previous_next_article_links variable and add i the documentation what is the default order and what is the reverse one.

Great! Thank you.

I was wondering if there were anything special to take into account if the language displayed is right to left (RTL).
It seems zola supports RTL but did you do anything special for tabi?

I haven't done much in this regard besides some testing and i18n strings. I don't think we need to do anything for this feature.

In addition, what do you think about adding "Prev - " and "Next - " (with translations) just before the article title in order to completely remove any ambiguity?

I wanted to keep this section minimal to accomodate for long titles, but after some local testing I think this can work. We can use the already existing prev and next i18n strings, like: $prev: [article title].

If it makes sense to you, I could implement another very verbose variable like label_previous_next_article_links to add the labels only when configured.

Let's skip the variable and implement it globally.

Last but not least, has "‹ ›" been used on purpose instead of "← / →" used for similar links?
If it was not, I can take care of using the arrow instead.

I used "‹ ›" to reduce the amount of space this section took up, trying to avoid wrapping long titles. However, since it seems unavoidable, let's use ← →.

Thanks for working on this. If you need any help (like documentation or any implementation details), don't hesitate to reach out!

I haven't done much in this regard besides some testing and i18n strings. I don't think we need to do anything for this feature.

:+1:

I wanted to keep this section minimal to accomodate for long titles, but after some local testing I think this can work. We can use the already existing prev and next i18n strings, like: $prev: [article title].

This is exactly what I planed. Nevertheless, I change a bit the format to make it more language agnostic.
Feel free to tell me if it doesn't suit you.

Let's skip the variable and implement it globally.

:+1:

I used "‹ ›" to reduce the amount of space this section took up, trying to avoid wrapping long titles. However, since it seems unavoidable, let's use ← →.

It makes sense but I am no sure it will have a huge impact because the arrow size is not that big with the policy used.

I implemented the changes we discussed about the best I could.
I let you have a look at the PR and provide your feedback.
Many thanks.

I was wondering if maybe it could be interesting to have the label above the title instead of prepended to it (maybe in a format similar to the metadata at the beginning of the article) or even the other way around (the link on the label : prev or next and the title in grey just below).

That might work… If you have something ready, I'd love to have a look!

I would propose something like that

It wraps pretty well and is easy to distinguish from the rest whether it is standard as in the previous screenshot, followed by comments as in:

or narrowed as in:

I am not a UI/UX expert but I have the feeling the link between prev/next link and the title below is easy to understand.
I only have one doubt about the font-weight. I used the same as the article meta but I am not sure it is readable enough (even if it suits me).
I thought it would make more sense to have the link on prev/next as for pages so I only focused on this proposal.
It has the advantage to keep the most space for title (no need to worry about angle brackets or arrows anymore).
Nevertheless, if you think it would be better the other way around, it wont be too complex to change.
As I might not be so much available in the coming days, I'll push a commit so you can look at the code which has been used to generate the capture.
Feel free to provide any feedback and I'll update it when possible or modify it if you prefer.
Thanks again for your help.

Great job! I've made some minor changes. Visually, I used the sans-serif font, as the serif one is "reserved" for the article paragraphs.
I've improved accessibility by hiding the paragraph with the label. Otherwise screen readers would announce it twice: once for the next/prev link (good job with the aria-describedby), then again for the article title.
Minor change: Truncated long titles will get "…" at the end.

I've merged the PR #261.
Hopefully everything's all right with my latest changes. Do let me know if you encounter any issues.
Thanks for your great work on this!

That's really great.
Many thanks for always being supportive and providing so many advice.


Add ResponseDemux

Part of #5996
This was first prototyped in https://github.com/quantumlib/Cirq/pull/5982 as _ResponseListener, but this version operates a bit differently: StreamError responses are now handled.
Leaving this as draft until the request client and stream handler are implemented, in case requirements to this class change.
cc @maffoo @wcourtney

I don't see any changes. Looks like maybe you meant to rename the file but didn't git add the new file?

That's exactly it 😂 so that's how you create an empty PR...
Updated

I'm also considering whether this can be made more general eventually and potentially be added to duet. In the current form, the demux logic depends on the response type.

Added cancellation handling. The cancellation callback of making a CancelQuantumJob() unary call will be passed into the demux upon initialization.
The goal is for users to be able to cancel a job by pressing Ctrl-C during a sampler.run() call. As a result, the job will be cancelled regardless of the stream request type.

Ready for review. Usage of this class can be found here

Syncing with @maffoo on stream client design offline. This implementation could potentially be out of date.

This is now stale with respect to the latest design. Closing.


Implement mov, PC

Another quick implementation, the code was already there.

Thank you @aaronjamt! I have just seen your MR and will look at it soon :slightly_smiling_face:

Hi @aaronjamt. When testing this I discovered that the program counter was being advanced after being written to. I have made a small refactoring to the emulator logic to correct this.
Thanks for adding this missing instruction :+1:


Create technical spec for additional ontologized fields

Tech spec.

Notes from 05/02 weekly meeting:

Include dev stage documentation - current state, artifacts, how are they produced.
Look for opportunities for hardening above (e.g. can the CLI generate the development stage ancestors in case the version of the pinned ontology changes).

See technical spec.


Drop homeUrl option in favour of a relative path for redirect

Changes in this pull request
Dropped support for the homeUrl option.
Reasoning
This option is solely used for redirecting from the docs/index.html page to the docs/stable directory. Currently, the plugin achieves this by way of an absolute URL, i.e. it requires to know where the docs will live in production and joins /stable onto the end of that path.
If the option was not provided, it will attempt to guess at it by scouring your package.json and converting your listed git repository into a github pages URL.
This would then be used to produce an index.html with the following (example) content:
<meta http-equiv="refresh" content="0; url=https://citkane.github.io/typedoc-plugin-versions/stable"/>

However, the same task can be accomplished by simply always outputting index.html as follows:
<meta http-equiv="refresh" content="0; url=stable"/>

As the index.html always lives at the root of your docs, it can simply point to the stable directory via a relative path as above, i.e.:

If index.html is located at https://citkane.github.io/typedoc-plugin-versions, it will redirect to https://citkane.github.io/typedoc-plugin-versions/stable
If index.html is located at http://localhost:5501/docs, it will redirect to http://localhost:5501/docs/stable

This has the added benefit of eliminating the possibility of accidentally committing a localhost docs path to your main branch while testing locally!
Implementation details

homeUrl removed from options
Removed utility functions from etc/utils.ts as they no longer serve any purpose:

getGhPageUrl
makeIndex

Updated tests to reflect changes
Updated README.md to reflect the changes
Version bump to 0.1.0 to indicate a breaking change (due to the fact that two previously exported functions have been removed from the API)

I have done some testing, but due to the nature of this repository requiring Linux for running builds and therefore being unsuitable for local testing in my dev environment via npm link, I would advise thorough testing in your own dev environment.

Not sure the cause of the code style issues in your CI tests 😅

I'm guessing it's just because prettier doesn't like the formatting of a couple of the files, so I've ran prettier -w on them, but I notice you've now removed the CI from being affected by PRs targeting dev :)
Ping me if you run into any issues with the PR!

That all looks good.
Always better to get rid of unneeded complexity!

Not sure the cause of the issues in the CI tests sweat_smile

I added Prettier to enforce consistent styling. See the new  developer guideline wiki page with simple usage to auto format all code. Could you run that and see if the CI tests pass. I will merge then.

I have done some testing, but due to the nature of this repository requiring Linux for running builds and therefore being unsuitable for local testing in my dev environment via npm link, I would advise thorough testing in your own dev environment.

Is this because of build.sh? If so, I may rewrite it to be a build.js. I think :pray: calling it from the "build" script in package.json as "node ./build.js" can launch without the need for the linux #!/usr/bin/env.
Any other ideas for a workaround welcome.

but I notice you've now removed the CI from being affected by PRs targeting dev

Nope. I changed nothing...
https://github.com/citkane/typedoc-plugin-versions/blob/e04bffeff530c60c9b4a4f42edcbd357e56cc642/.github/workflows/test.yml#L2-L11
I am not sure why your change is not triggering a re-test. Any ideas?
I will merge your PR for now regardless.
build.js works, and I will include this in the dev branch shortly. It would be great if you could confirm if that resolves building in Windows.

Is this because of build.sh? If so, I may rewrite it to be a build.js. I think 🙏 calling it from the "build" script in package.json as "node ./build.js" can launch without the need for the linux #!/usr/bin/env.
Any other ideas for a workaround welcome.

That's one part of it - Windows can't run that script.
But in part, I believe some of it has to do with how you are packing things up for distribution to npm - you copy a lot of files into dist. When installing locally via npm link, node and TS have a hard time understanding what is going on even if I manually attempt to recreate the desired output of your build.sh, so I think it has to do with how what is installed via npm remotely and what is installed via npm link not matching up and I haven't spent enough time finagling with it to figure it out - to properly make use of npm link I'd have to wipe the project folder except for dist, then move the contents into the root, since the contents of dist seems to be what you are actually publishing if I'm not mistaken?
My suggestion for making it easier for interop between different dev environments - and to make it possible to locally test your package via npm link before publishing it - throw away the build script entirely and just use tsc to compile, and use the files property of package.json to tell npm what to include in the uploaded package. See my own project for an example:
https://github.com/toebeann/signals/blob/943d6593934e8c1e6a6cd0152b1edd8739118113/package.json#L48-L53.
Then, you can do away with only publishing the contents of the dist folder by specifying it in your package publishing workflow, and also do away with copying package.json etc into that folder via a build script, and therefore do away with the build.sh entirely.
Notice how I don't have my readme or package.json included, what actually gets published to npm for my project is this:

(dist just contains the .js and .js.map files generated by tsc, types contains my .d.ts and .d.ts.map files)
I could put together a PR for you that should do the job, if you'd like?

I am not sure why your change is not triggering a re-test. Any ideas?

Ah I think it's the types option of your PR. On my own repos I have mine set up like the following:
 pull_request:
    branches: ["main"]
    paths:
      [
        "**.ts",
        "jest.config.js*",
        "package-lock.json",
        ".github/workflows/npm-test.yml",
      ]

i.e. I don't specify the types, but that it should only be triggered if any of those files are changed in a commit. Bc my test will only have a different result if any of my .ts files are changed (including tests), package-lock.json is changed (indicating different versions of dependencies), my jest config is changed (I recently migrated from mocha to jest - it's quite nice), or my test workflow itself is changed!

I forgot to mention btw, you can make use of npm pack to test what is going to be uploaded to npm when you publish. npm pack generates a .tgz archive which includes everything that would be uploaded to npm :)

@citkane I can confirm that the move from build.sh to build.js does indeed resolve the issue with the npm run build command on windows, which means I can now run npm test reliably but testing how the package operates from another local project via npm link is still an issue due to the above.
Some of the tests via npm test fail on Windows, however:
14 passing (48ms)
  3 failing

  1) Unit testing for typedoc-plugin-versions
       creates symlinks
         creates a stable version symlink:

      did not link the stable symlink correctly
      + expected - actual

      -false
      +true

      at Context.<anonymous> (test\index.spec.ts:83:11)
      at processImmediate (node:internal/timers:466:21)

  2) Unit testing for typedoc-plugin-versions
       creates symlinks
         creates a dev version symlink:

      did not link the dev symlink correctly
      + expected - actual

      -false
      +true

      at Context.<anonymous> (test\index.spec.ts:91:11)
      at processImmediate (node:internal/timers:466:21)

  3) Unit testing for typedoc-plugin-versions
       handle file operations correctly
         maps correct output paths:

      root path not resolved correctly
      + expected - actual

      -false
      +true

      at Context.<anonymous> (test\index.spec.ts:110:11)
      at processImmediate (node:internal/timers:466:21)

I haven't dug into the cause of this - the symlinks you create do seem to work in the distributed package on my Windows environment, so it's likely something to do with the test methodology itself.

you copy a lot of files into dist.

I started by going down the npm "files" route as you have suggested, and I can't recall the reasons why I changed course.
If  we accept that it is what it is for a minute, could you please check if just running npm run build on the latest dev works for you on windows. I have changed the script to .js
I am running manual smoke tests from external document builds, not by using npm link, but rather npm i -D path/to/typedoc-plugin-version/dist. This does the 'npm link' and updates package-lock and tends to stop the complaining (in linux anyway)
This will probably give you a warning that typedoc has been loaded twice when you build the docs. This is because of peerDependecies losing there s£$t altogether when things are linked locally: https://github.com/npm/npm/issues/5875
You will probably have to do the same workaround trick from the typedoc-plugin-version build - ie. npm i -D ../path/to/your/document/node_modules/typedoc
Got to run. Will look again tomorrow.

If we accept that it is what it is for a minute, could you please check if just running npm run build on the latest dev works for you on windows. I have changed the script to .js

I can confirm that the move from build.sh to build.js does indeed resolve the issue with the npm run build command on windows

^ already done 😅 sorry I typed a lot so it's easy to miss heh
Ah yes I forgot entirely you could use npm i to install from a local path. I've always just enjoyed the convenience of not needing the path info for npm link so I've grown accustomed to it haha. I'll give things a try with npm i using paths and get back to you. Have a pleasant evening!

Yep, using npm i as you described with paths definitely works for me (did have to make sure they are both using the same installation of typedoc as you described). I'll try remember that in future for other non-npm link compatible packages! Been so wrapped up in my own bubble that I forgot about that option completely 😅
npm test is still failing on Windows due to those 3 symlinks tests above, but the symlinks are definitely generated by your plugin when generating documentation for one of my projects, so I assume that the test methodology for those tests just doesn't work on Windows. Not a big issue - might be worth just instructing mocha to skip those tests on win32 since I can confirm that your package does create symlinks as needed in my dev env (win 11). I could attempt to write variants of the tests that work on win32 when I have the time, but no promises on that happening soon as at some point I need to get back to work on my own projects etc. 😅

Thanks for the updates, I'll take a few moments shortly to test and get back to you.
And no need to apologise or explain for taking time to reply at your own pace, regardless of whether you're recovering from surgery or not! (Wishing you a speedy recovery!) I understand that my communication style can be a little frantic, but I do understand you have a life haha. I think we've managed to communicate and coordinate well also :)

See 40d6078#commitcomment-82022752 . This should hopefully resolve auto testing on updates to PR's without the need for specifying files. The behavior is default, and I have observed it to work as expected  on the typedoc workflow.

Yep this is basically what I was alluding to above, I just also tend to refine it to only kick in when specific file types have changed in a pull, bc for example, there's no need to run mocha/jest tests if the only thing that has changed is the README.md. Though as you are also running a prettier format check, it makes sense to just let it run on everything!

See this commit, which sets string paths correctly in tests for posix/windows ("/" vs ""). I would appreciate if you would confirm if tests are now passing in windows. I can publish 0.1.0 after that.

❯ git reset --hard upstream/dev
HEAD is now at b8bfcec Remove "homeUrl" from test stub

❯ git pull upstream dev
From https://github.com/citkane/typedoc-plugin-versions
 * branch            dev        -> FETCH_HEAD
   b8bfcec..74ce5fd  dev        -> upstream/dev
Updating b8bfcec..74ce5fd
Fast-forward
 .github/workflows/test.yml | 1 -
 test/index.spec.ts         | 8 ++++++--
 test/stubs/stubs.ts        | 5 +++--
 3 files changed, 9 insertions(+), 5 deletions(-)

❯ npm i

up to date, audited 354 packages in 945ms

52 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

❯ npm test

><EMAIL_ADDRESS>test
> prettier -c . && nyc mocha

Checking formatting...
[warn] .eslintrc
[warn] .github\workflows\docs.yml
[warn] .github\workflows\release.yml
[warn] .github\workflows\test.yml
[warn] .prettierrc.json
[warn] build.js
[warn] package-lock.json
[warn] package.json
[warn] README.md
[warn] src\assets\versionsMenu.js
[warn] src\etc\hooks.tsx
[warn] src\etc\utils.ts
[warn] src\index.ts
[warn] src\types.ts
[warn] test\hooks.ts
[warn] test\index.spec.ts
[warn] test\stubs\stubs.ts
[warn] tsconfig.json
[warn] typedoc.json
[warn] Code style issues found in 19 files. Forgot to run Prettier?

❯ npx prettier -w .
.eslintrc 43ms
.github\workflows\docs.yml 55ms
.github\workflows\release.yml 11ms
.github\workflows\test.yml 10ms
.prettierrc.json 3ms
build.js 17ms
package-lock.json 168ms
package.json 39ms
README.md 72ms
src\assets\versionsMenu.js 19ms
src\etc\hooks.tsx 327ms
src\etc\utils.ts 73ms
src\index.ts 31ms
src\types.ts 10ms
test\hooks.ts 10ms
test\index.spec.ts 34ms
test\stubs\stubs.ts 9ms
tsconfig.json 3ms
typedoc.json 3ms

❯ npm test

><EMAIL_ADDRESS>test
> prettier -c . && nyc mocha

Checking formatting...
All matched files use Prettier code style!

  Unit testing for typedoc-plugin-versions
    ✔ loads and parses options
    retrieving package version
      ✔ retrieves patch value from package.json
      ✔ throws error if version not defined
      ✔ retrieves minor value from package.json
      ✔ discards patch from semantic version string
    parses and processes directories
      ✔ retrieves semantically named directories into a list
      ✔ groups semantic versions correctly with highest patch
    creates browser assets
      ✔ creates a valid js string from the sematic groups
    creates symlinks
      ✔ creates a stable version symlink
      ✔ creates a dev version symlink
      ✔ creates all minor version links
    handle file operations correctly
      ✔ maps correct output paths
      ✔ does not error if .nojekyll is not present
      ✔ copies .nojekyll to the document root if exists
      ✔ copies static assets into the target version folder

  15 passing (42ms)

-----------|---------|----------|---------|---------|-------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-----------|---------|----------|---------|---------|-------------------
All files  |    88.7 |    76.59 |      84 |   88.61 |
 src       |      60 |        0 |   33.33 |   58.62 |
  index.ts |      60 |        0 |   33.33 |   58.62 | 45-46,54-67
 src/etc   |   97.87 |       80 |    90.9 |   97.87 |
  utils.ts |   97.87 |       80 |    90.9 |   97.87 | 36,60
-----------|---------|----------|---------|---------|-------------------

Tests now pass on Windows! Although I do have to run prettier -w . first after checking out, as git is automatically applying CRLF line endings to every file on checkout in Windows and this blocks the tests from running.
You could consider reordering the test script to nyc mocha && prettier -c . so that the code tests run first and then it checks the formatting after (assuming no errors in the code test), though I'm not sure if that would have a knock on effect at all to your workflows.
I think if you create a .gitattributes file with * text eol=lf it should mean that even on Windows, line endings are normalized to LF, which would prevent the line endings from being converted to CRLF when checked out on Windows, and I believe it would even normalize them to LF when committing.
You could also consider setting prettier to the auto line ending setting, though I'm not a big fan of that approach, though, as I do think consistent EOL across the project is a good thing.

I think if you create a .gitattributes file with * text eol=lf it should mean that even on Windows, line endings are normalized to LF

The docs appear to agree with you, and I have this implemented. Thanks, would have taken me a while to figure this.

You could consider reordering the test script to nyc mocha && prettier -c .

I prefer it in the order it is ATM, but the above point should make this moot.

You could also consider setting prettier to the auto line ending setting, though I'm not a big fan of that approach, as I do think consistent EOL across the project is a good thing.

I agree with you.
v0.1.0 is now published and released! :fireworks: :sparkler: :partying_face: :champagne:
Thanks again.

Now live @ https://toebeann.github.io/signals 🚀 and soon more of my projects😅


Make hyperlinks clickable in notes without special markdown syntax

Some markdown flavors parse links event without the hyperlink syntax [https://github.com](https://github.com). Is this possible to implement with the markdown parser that you use for the description/notes input?

Not an exact solution, but if you just want a shorter syntax for links, you can do:
<https://github.com/>

Oh thank you, I wasn't aware of that markdown syntax.

This is what linkding uses: https://python-markdown.github.io/
Doesn't look like there is an existing extension for that.

Looks like there are some third party extensions that make do the trick if you're interested: https://github.com/Python-Markdown/markdown/wiki/Third-Party-Extensions#url-conversion. I think this could be valuable shorthand to provide additional links as context to each bookmark.
Related: https://github.com/Python-Markdown/markdown/issues/789


use picocolors instead nanocolors

REMINDER
@antfu Talking with patak seems nanocolors will be closed in favor of picocolors: https://twitter.com/sitnikcode/status/1445344583005704197?s=20
picocolors seems also be fast and using less space on disk.
I need to do some tests later and I'll provide a new PR using this new package: seems also chalk will add esm support if we want back to chalk in a future.

We've already bikeshedded this quite a bit, but would you consider using kolorist for this task @antfu ?
It's small, deps free, fully ESM, and most importantly, by the preact guy @marvinhagemeister, so it's reliable as an army tank.
Here's all the code it has https://github.com/marvinhagemeister/kolorist/blob/main/src/index.ts
Would love to make a PR


Public memo/comment id sharing URL not found

Describe the bug
Unlike to memo/message id "native" URLs (e.g. https://domain.ext/m/7dHurf6QN7kjoKgdHeEXdK), memo/message id sharing URLs (e.g. https://domain.ext/m/memos/266) are resulting in a 404 error page (i.e. The page you are looking for can't be found.)
Therefore the references / backlinks feature - which makes use of sharing URLs - isn't properly working.
Browser independent.
Steps to reproduce

create new public memo/comment or pick an old one and open the three dots menu
select Share
select Link
go to the link

The version of Memos you're using
0.21.0
Screenshots or additional context

Duplicated with https://github.com/usememos/memos/issues/3148


[SPARK-35979][SQL] Return different timestamp literals based on the default timestamp type

What changes were proposed in this pull request?

For the timestamp literal, it should have the following behavior.

When spark.sql.timestampType is TIMESTAMP_NTZ: if there is no time zone part, return timestamp without time zone literal; otherwise, return timestamp with local time zone literal

When spark.sql.timestampType is TIMESTAMP_LTZ: return timestamp with local time zone literal

Why are the changes needed?

When the default timestamp type is TIMESTAMP_NTZ, the result of type literal should return TIMESTAMP_NTZ when there is no time zone part in the string.
From setion 5.3 "literal" of ANSI SQL standard 2011:
27) The declared type of a <timestamp literal> that does not specify <time zone interval> is TIMESTAMP(P) WITHOUT TIME ZONE, where P is the number of digits in <seconds fraction>, if specified, and 0 (zero) otherwise. The declared type of a <timestamp literal> that specifies <time zone interval> is TIMESTAMP(P) WITH TIME ZONE, where P is the number of digits in <seconds fraction>, if specified, and 0 (zero) otherwise.

Since we don't have "timestamp with time zone", we use timestamp with local time zone instead.
Does this PR introduce any user-facing change?

No, the new timestmap type and the default timestamp configuration is not released yet.
How was this patch tested?

Unit test

Test build #140643 has started for PR 33215 at commit 043d99b.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45155/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45155/

Test build #140651 has started for PR 33215 at commit 381db36.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45161/

Test build #140657 has started for PR 33215 at commit da7ce20.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45161/

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45168/

Test build #140643 has finished for PR 33215 at commit 043d99b.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140643/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45161/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45168/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45168/

Test build #140651 has finished for PR 33215 at commit 381db36.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140651/

Test build #140659 has started for PR 33215 at commit 4e90fb9.

Test build #140657 has finished for PR 33215 at commit da7ce20.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45170/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140657/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45170/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45170/

Merging to master/branch-3.2

Test build #140659 has finished for PR 33215 at commit 4e90fb9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140659/


Logical replication supports multiple masters

Logical replication supports multiple masters, global deployment of the enterprise, and unitary functionality.

We already had a prototype work on this topic. We can roll it out with the distributed version if we can get additional resources.


Use the remaining half bit in the refcount to bypass ObjC deallocation overhead

We can use the new setAssociatedObject interposition function to make this safe. 1.1-1.5x win on a huge variety of benchmarks.
#ifdef'd out for platforms that don't have the new interposition function, and guarded with __builtin_available so it'll back-deploy
Fixes rdar://36825362

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - 25fa3bd1dbebf21234598469ed28291289d97c5d

Build failed
Swift Test Linux Platform
Git Sha - 25fa3bd1dbebf21234598469ed28291289d97c5d

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 25fa3bd1dbebf21234598469ed28291289d97c5d

Build failed
Swift Test OS X Platform
Git Sha - 25fa3bd1dbebf21234598469ed28291289d97c5d

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - f705b7732ce1e780b0f5596cdd308ac05020d78b

Build failed
Swift Test OS X Platform
Git Sha - f705b7732ce1e780b0f5596cdd308ac05020d78b

Need a compiler-rt fix; it's currently only building for Intel in Swift CI

@swift-ci please test and merge

@swift-ci please test and merge

I'm told that the linux failures are irregular and were seen this morning, gonna retry

@swift-ci please test linux platform

Build failed
Swift Test Linux Platform
Git Sha - 67c72191d86b42237f43da633c14b29018f7beff

@swift-ci clean test Linux

Build failed
Swift Test Linux Platform
Git Sha - c51294671bf2b9587f4de57ed834633359d84db3

@swift-ci please test linux platform

Build failed
Swift Test Linux Platform
Git Sha - c51294671bf2b9587f4de57ed834633359d84db3

@swift-ci clean test Linux

Build failed
Swift Test Linux Platform
Git Sha - c51294671bf2b9587f4de57ed834633359d84db3

@swift-ci please test linux platform


feat(client): add ability to include SO_REUSEADDR option on sockets

Closes #1599

Looks great, thanks!


Unexpected Errors second stage alignment

In the Masif search process after running the descriptors, I am. Unable to run  the second_alignment_nn. Py successfully the pretrained model doesn't load. Any hint can u provide the correct pretrained.hdf5 file. Thanks. Hoping for a positive response

Hi ! Could you provide more info? Can you show the error? Are you running it in docker?

Perhaps I have the same error while using precomputed data (running in docker, GPU is visible). Here is the output ./second_stage_masif.sh
root@ID:/masif/comparison/masif_ppi_search/masif_descriptors_nn# ./second_stage_masif.sh 100
2021-10-04 07:57:10.612890: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 AVX512F FMA
['/masif/source//masif_ppi_search/second_stage_alignment_nn.py', '../../../data/masif_ppi_search', '100', '2000', '1000', 'masif']
Loading patch coordinates for 2I32_A_E
Traceback (most recent call last):
  File "/masif/source//masif_ppi_search/second_stage_alignment_nn.py", line 114, in <module>
    read_point_cloud(
NameError: name 'read_point_cloud' is not defined


ServerError msal-browser outlook add-in on Android

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
3.13.0
Wrapper Library
Not Applicable
Wrapper Library Version
None
Public or Confidential Client?
Public
Description
When trying to initiate login/authentication to get user-tokens in an Outlook add-in on Android, both acquireTokenPopup and loginPopup produces ServerErrors without a lot more info. All is working as it should in both browser, in-app on desktop, and in-app on iOS.
We are initializing the client as seen in the codesnippet, same with how the token-fetching is being done.
Again, there are some very aggressive ways we've been trying now as might see from the above code, but to no avail on any of our approaches. So far, it seems that all the approaches we've had, errors before even trying to trigger a popup to be opened, as the android Outlook app errors immediately, without a popup opening/closing, only showing the page that would be the opener of said popup.
We're at an impass on where to continue now, as we can't seem to figure out any more approaches on what to do next.
Error Message
ServerError
with the most we got out of stack-traces is that it fails on const a = this.nestedAppAuthAdapter.fromBridgeError(n); in NestedAppAuthController.js, in the function acquireTokenInteractive
MSAL Logs
Seeing Android is somewhat impossible to debug, this is the closest we've gotten getting verbose logs.
[Fri, 03 May 2024 14:38:15 GMT] : []<EMAIL_ADDRESS>: Info - Emitting event: msal:acquireTokenStart
[Fri, 03 May 2024 14:38:15 GMT] : []<EMAIL_ADDRESS>: Info - Emitting event: msal:acquireTokenFailure
[Fri, 03 May 2024 14:38:15 GMT] : []<EMAIL_ADDRESS>: Info - Emitting event: msal:acquireTokenStart
[Fri, 03 May 2024 14:38:15 GMT] : []<EMAIL_ADDRESS>: Info - Emitting event: msal:acquireTokenFailure
[Fri, 03 May 2024 14:38:15 GMT] : []<EMAIL_ADDRESS>: Info - Emitting event: msal:acquireTokenStart
[Fri, 03 May 2024 14:38:15 GMT] : []<EMAIL_ADDRESS>: Info - Emitting event: msal:acquireTokenFailure
[Fri, 03 May 2024 14:38:15 GMT] : []<EMAIL_ADDRESS>: Info - Emitting event: msal:acquireTokenStart
[Fri, 03 May 2024 14:38:15 GMT] : []<EMAIL_ADDRESS>: Info - Emitting event: msal:acquireTokenFailure
ServerError

Network Trace (Preferrably Fiddler)

[ ] Sent
[ ] Pending

MSAL Configuration
{
  auth: {
    clientId: import.meta.env.VITE_PISTACHIO_MICROSOFT_CLIENT_ID,
    authority: 'https://login.microsoftonline.com/common',
    supportsNestedAppAuth: true,
  },
  system: {
    loggerOptions: {
      logLevel: LogLevel.Verbose,
      loggerCallback: (_level, message, _containsPii) => {
        this.errorCode.msg += `${message}\n\n`;
        return;
      },
    },
  },
}

Relevant Code Snippets
import {
  PublicClientNext,
  type IPublicClientApplication,
  type AuthenticationResult,
  LogLevel,
  Configuration,
} from '@azure/msal-browser';

export class MicrosoftClient {
  private errorCode: Record<'msg', number | string>;
  private client: IPublicClientApplication | null = null;
  private loginHint = '';
  private userAccount: AuthenticationResult | null = null;

  constructor(errorCode: MicrosoftClient['errorCode']) {
    this.errorCode = errorCode;
  }

  async init() {
    this.errorCode.msg = 'MS-I';

    // Initialize MSAL. MSAL need's a loginHint for when running in a browser.
    const accountType = Office.context.mailbox.userProfile.accountType;
    this.loginHint =
      accountType === 'office365' || accountType === 'outlookCom'
        ? Office.context.mailbox.userProfile.emailAddress
        : '';

    const msalConfig: Configuration = {
    auth: {
      clientId: '__INSERT_CLIENT_ID_HERE__',
      authority: 'https://login.microsoftonline.com/common',
      supportsNestedAppAuth: true,
    },
    system: {
      loggerOptions: {
        logLevel: LogLevel.Verbose,
        loggerCallback: (_level, message, _containsPii) => {
          this.errorCode.msg += `${message}\n\n`;
          return;
        },
      },
    },
  };
    this.client = await PublicClientNext.createPublicClientApplication(msalConfig);

    await this.client?.initialize();
  }

  async getToken() {
    const client = this.client;
    if (!client) {
      throw new Error('Client not initialized');
    }

    this.errorCode.msg = 'MS-TKN-1\n\n';

    const currentAccount = client.getAccountByUsername(this.loginHint);
    const tokenRequest = {
      scopes: ['openid', 'profile', 'User.Read', 'ThreatSubmission.Read', 'Mail.ReadWrite.Shared', 'Mail.Send.Shared'],
      ...(currentAccount?.idTokenClaims?.login_hint && { loginHint: currentAccount?.idTokenClaims?.login_hint }),
      ...(currentAccount?.idTokenClaims?.sid && { sid: currentAccount?.idTokenClaims?.sid }),
      ...(currentAccount && { account: currentAccount }),
    };

    this.errorCode.msg = 'MS-TKN-2\n\n';
    this.userAccount = await client
      ?.acquireTokenSilent(tokenRequest)
      .catch(() => {
        this.errorCode.msg += 'MS-TKN-3\n\n';
        return client.ssoSilent(tokenRequest);
      })
      .catch(() => {
        this.errorCode.msg += 'MS-TKN-4\n\n';
        return client.acquireTokenPopup({
          ...tokenRequest,
        });
      })
      .catch(() => {
        this.errorCode.msg += 'MS-TKN-5 STAGE\n\n';
        return client.loginPopup({
          ...tokenRequest,
        });
      })
      .catch((e) => {
        this.errorCode.msg += `MS-TKN-7-${e}\n\n`;
        throw e;
      });

    this.errorCode.msg = 'MS-TKN-8';
    await client.hydrateCache(this.userAccount, tokenRequest);
  }
}

Office.onReady(async () => {
  const microsoftClient = new MicrosoftClient({msg: 'no-error'});
  await microsoftClient.init();
  const token = await microsoftClient.getToken();

  console.log({ token });
});

Reproduction Steps

Set up an outlook add-in with the scopes ['openid', 'profile', 'User.Read', 'ThreatSubmission.Read', 'Mail.ReadWrite.Shared', 'Mail.Send.Shared']
Publish said add-in to your own AAD-tenant
Add code supplied to the add-ins main.ts file
Run the add-in on an email to start the auth-token flow
See it error

Expected Behavior
To not crash and spit out a ServerError, but instead open a popup like every other environment and platform Outlook runs on.
Identity Provider
Entra ID (formerly Azure AD) / MSA
Browsers Affected (Select all that apply)
Other
Regression
No response
Source
External (Customer)

@kasperrt have you involved the Android auth team to help here? NAA completely relies on the hub to authenticate and in this case the hub is the native android auth stack. Let me try see if I can pull the right people here.
cc @codexeon do we know who can help here?

@kasperrt This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

This has not been solved yet no.
@sameerag I havent been in contact with the Android team now, I assumed the tag from you here should be sufficient as of now?

@kasperrt This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

This has not been solved yet no.
@sameerag I havent been in contact with the Android team now, I assumed the tag from you here should be sufficient as of now?

Still unsolved.
Do I need to keep bumping this @sameerag every few days to ensure that it doesn't get closed?


Update GA4 naming conventions

What
The changes in this PR update the naming conventions in our GA4 analytics implementation (e.g. addressing capitalisation in variable names and replacing references to Google Tag Manager with Google Analytics where appropriate). The key changes are:

Renaming Ga4EnhancedEcommerceTracker to Ga4EcommerceTracker
Renaming GOVUK.analyticsGA4 to GOVUK.analyticsGa4
Replacing instances of gtm with ga4 where appropriate

Not all instances of gtm have been replaced with ga4. This is because these changes only relate to the GA4 upgrade; this PR does not remove instances of gtm from older analytics implementations.
These changes are breaking as static and finder-frontend are referencing old values (e.g. GOVUK.analyticsGA4 rather than GOVUK.analyticsGa4). PR #2888 in finder-frontend and PR #2892 in static have been raised to update the values accordingly in these applications.
Why
To improve the naming conventions in our GA4 analytics implementation.
Visual Changes
N/A

Thanks @andysellick. Yeah, basically there was a merge conflict with my CHANGELOG so I resolved it in GitHub, which resulted in the strange commit. I think I can squash it into the previous commit though to make things a bit tidier.