compatibility with Ember 2.14

When I create a new Ember project using ember-cli 2.14.1 and install ember-moment as the only addon, the app doesn't boot:
ember s

TypeError: ember-moment/utils/get-owner.js: Property object of MemberExpression expected node to be of a type ["Expression"] but instead got null
at Object.validate (/home/jonne/Temp/test-upgrade/node_modules/babel-types/lib/definitions/index.js:109:13)
at Object.validate (/home/jonne/Temp/test-upgrade/node_modules/babel-types/lib/index.js:505:9)
at NodePath._replaceWith (/home/jonne/Temp/test-upgrade/node_modules/babel-traverse/lib/path/replacement.js:176:7)
at NodePath._remove (/home/jonne/Temp/test-upgrade/node_modules/babel-traverse/lib/path/removal.js:58:10)
at NodePath.remove (/home/jonne/Temp/test-upgrade/node_modules/babel-traverse/lib/path/removal.js:30:8)
at PluginPass.CallExpression (/home/jonne/Temp/test-upgrade/node_modules/babel-plugin-transform-es2015-modules-amd/lib/index.js:42:12)
at NodePath._call (/home/jonne/Temp/test-upgrade/node_modules/babel-traverse/lib/path/context.js:76:18)
at NodePath.call (/home/jonne/Temp/test-upgrade/node_modules/babel-traverse/lib/path/context.js:48:17)
at NodePath.visit (/home/jonne/Temp/test-upgrade/node_modules/babel-traverse/lib/path/context.js:105:12)
at TraversalContext.visitQueue (/home/jonne/Temp/test-upgrade/node_modules/babel-traverse/lib/context.js:150:16)

The broccoli plugin was instantiated at:
at BroccoliMergeTrees.Plugin (/home/jonne/Temp/test-upgrade/node_modules/broccoli-plugin/index.js:7:31)
at new BroccoliMergeTrees (/home/jonne/Temp/test-upgrade/node_modules/ember-cli/node_modules/broccoli-merge-trees/index.js:16:10)
at Function.BroccoliMergeTrees [as _upstreamMergeTrees] (/home/jonne/Temp/test-upgrade/node_modules/ember-cli/node_modules/broccoli-merge-trees/index.js:10:53)
at mergeTrees (/home/jonne/Temp/test-upgrade/node_modules/ember-cli/lib/broccoli/merge-trees.js:85:33)
at Class.treeFor (/home/jonne/Temp/test-upgrade/node_modules/ember-cli/lib/models/addon.js:521:30)
at project.addons.map.addon (/home/jonne/Temp/test-upgrade/node_modules/ember-cli/lib/broccoli/ember-app.js:557:22)
at Array.map (native)
at EmberApp.addonTreesFor (/home/jonne/Temp/test-upgrade/node_modules/ember-cli/lib/broccoli/ember-app.js:555:32)
at EmberApp._addonTree (/home/jonne/Temp/test-upgrade/node_modules/ember-cli/lib/broccoli/ember-app.js:956:29)
at EmberApp._processedExternalTree (/home/jonne/Temp/test-upgrade/node_modules/ember-cli/lib/broccoli/ember-app.js:1009:25)

Hi, just upgraded and I'm getting the same error. Alson on<EMAIL_ADDRESS>

The issue seems to be that Babel can't transpile the
require('ember-getowner-polyfill')
in get-owner.js. I'm checking if I can make it work by disabling some babel plugins

I'm seeing the same error with ember-cli: 2.12.3 and ember-moment: 7.4.0. Downgrade to ember-moment: 7.3.1 fixed the issue.

 But babel doesn't deal with it. For now, I'm going with a fork of this project. Does anyone have an idea for a real fix?

@jonnedeprez Thank you for your temporary solution. :bow:

This addon should be updated to depend on<EMAIL_ADDRESS>directly. The newer versions of that polyfill are a true polyfill, so there is no need to require a custom module like is done now. Once that is updated the aaddon/utils/get-owner.js file should be removed (or simplified to just export default Ember.getOwner).

Versioned as 7.4.1 - thanks everyone


GC problem quick hacking

This PR provides a fast fix for the GC problem in the current version of Peloton. In some cases, the current version of Peloton cannot guarantee that the number of started transactions equals to the number of ended transactions. That is, there exists certain transactions that never terminate. This causes the GC to suspend because the GC reclaims expired versions only if all the transactions in an expired epoch have been committed. The current fix is to timeout those outstanding transactions.
Please note that a better solution must be made to fully address this problem.

Coverage decreased (-0.3%) to 65.74% when pulling 5605b14ab1db431972ab3e85c8bc929026092a3c on yingjunwu:gc-debug into 839406b90dcea7318002004183b6c18d7dbe0d6f on cmu-db:master.


Use DeepAR for second-level data

When using DeepAREstimator for second-level data, both get_lags_for_frequency and time_features_from_frequency_str do not support freq = 'S'. It is possible to support second-level data in these two functions? Or is it possible to disable lags_seq and time_features in DeepAREstimator?

@changebo you can disable lags and time features by setting lags_seq=[] and time_features=[] when constructing a DeepAREstimator

Thanks @lostella for the quick response.
Setting lags_seq=[] gives the following error:
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-2-8d72adaab90e> in <module>
      3     context_length=args.context_length,
      4     lags_seq=[],
----> 5     time_features=[])

/redacted/python3.6/site-packages/gluonts/core/component.py in init_wrapper(*args, **kwargs)
    441                 self.__class__.__repr__ = validated_repr
    442
--> 443             return init(self, **all_args)
    444
    445         # attach the Pydantic model as the attribute of the initializer wrapper

/redacted/python3.6/site-packages/gluonts/model/deepar/_estimator.py in __init__(self, freq, prediction_length, trainer, context_length, num_layers, num_cells, cell_type, dropout_rate, use_feat_dynamic_real, use_feat_static_cat, cardinality, embedding_dimension, distr_output, scaling, lags_seq, time_features, num_parallel_samples)
    180         )
    181
--> 182         self.history_length = self.context_length + max(self.lags_seq)
    183
    184         self.num_parallel_samples = num_parallel_samples

ValueError: max() arg is an empty sequence

I guess a workaround is to set lags_seq=[0]. But setting time_features=[] gives a error message that's harder to decipher, when training the model.
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-4-53d8e27af0c7> in <module>
----> 1 predictor = estimator.train(train_data)

/redacted/python3.6/site-packages/gluonts/model/estimator.py in train(self, training_data)
    201     def train(self, training_data: Dataset) -> Predictor:
    202
--> 203         return self.train_model(training_data).predictor

/redacted/python3.6/site-packages/gluonts/model/estimator.py in train_model(self, training_data)
    187             net=trained_net,
    188             input_names=get_hybrid_forward_input_names(trained_net),
--> 189             train_iter=training_data_loader,
    190         )
    191

/redacted/python3.6/site-packages/gluonts/trainer/_base.py in __call__(self, net, input_names, train_iter)
    243
    244                     with tqdm(train_iter) as it:
--> 245                         for batch_no, data_entry in enumerate(it, start=1):
    246                             if self.halt:
    247                                 break

/redacted/python3.6/site-packages/tqdm/_tqdm.py in __iter__(self)
   1020                 """), fp_write=getattr(self.fp, 'write', sys.stderr.write))
   1021
-> 1022             for obj in iterable:
   1023                 yield obj
   1024                 # Update and possibly print the progressbar.

/redacted/python3.6/site-packages/gluonts/dataset/loader.py in __iter__(self)
    186         assert self._cur_iter is not None
    187         while True:
--> 188             data_entry = next(self._cur_iter)
    189             self._buffer.add(data_entry)
    190             if (

/redacted/python3.6/site-packages/gluonts/transform.py in __call__(self, data_it, is_train)
    345     ) -> Iterator:
    346         num_idle_transforms = 0
--> 347         for data_entry in data_it:
    348             num_idle_transforms += 1
    349             try:

/redacted/python3.6/site-packages/gluonts/transform.py in __call__(self, data_it, is_train)
    296         self, data_it: Iterator[DataEntry], is_train: bool
    297     ) -> Iterator:
--> 298         for data_entry in data_it:
    299             try:
    300                 yield self.map_transform(data_entry.copy(), is_train)

/redacted/python3.6/site-packages/gluonts/transform.py in __call__(self, data_it, is_train)
    296         self, data_it: Iterator[DataEntry], is_train: bool
    297     ) -> Iterator:
--> 298         for data_entry in data_it:
    299             try:
    300                 yield self.map_transform(data_entry.copy(), is_train)

/redacted/python3.6/site-packages/gluonts/transform.py in __call__(self, data_it, is_train)
    300                 yield self.map_transform(data_entry.copy(), is_train)
    301             except Exception as e:
--> 302                 raise e
    303
    304     @abc.abstractmethod

/redacted/python3.6/site-packages/gluonts/transform.py in __call__(self, data_it, is_train)
    298         for data_entry in data_it:
    299             try:
--> 300                 yield self.map_transform(data_entry.copy(), is_train)
    301             except Exception as e:
    302                 raise e

/redacted/python3.6/site-packages/gluonts/transform.py in map_transform(self, data, is_train)
    866             data[self.target_field], self.pred_length, is_train=is_train
    867         )
--> 868         self._update_cache(start, length)
    869         i0 = self._date_index[start]
    870         features = self._full_range_date_features[..., i0 : i0 + length]

/redacted/python3.6/site-packages/gluonts/transform.py in _update_cache(self, start, length)
    854         )
    855         self._full_range_date_features = np.vstack(
--> 856             [feat(self.full_date_range) for feat in self.date_features]
    857         )
    858         self._date_index = pd.Series(

/redacted/python3.6/site-packages/numpy/core/shape_base.py in vstack(tup)
    232
    233     """
--> 234     return _nx.concatenate([atleast_2d(_m) for _m in tup], 0)
    235
    236 def hstack(tup):

ValueError: need at least one array to concatenate

@changebo sorry, my bad - you must have at least one lag index. For example, lag_seq=[1]: this indicates that to output a predictive distribution for time t, the RNN takes as input z[t-1], where z is the time series. Regarding the empty list of time features, there must be some problem with stacking zero vectors, I'll have to look into this deeper, because I guess this should be allowed.

Thanks, @lostella! Let me know if there's anything I can help with. I would be happy to help fix it.

Hi,
Does that mean that this trick allows to train on any sequence data, whatever the frequency? I am dealing with machine data with no timestamp, just order number.
I am very interested in any workaround or future development you may have on this topic.
Thanks,
Alex

Hello @lostella,
Quick followup, would you be able to help clarify the matter?
Thanks,
Alex

@alexcombessie we do rely on the assumption that observations have a fixed frequency; the fact that you have an absolute reference time for them is not really important I would say.
If there’s not even a concept of frequency, and you just have sequences of numbers, you can in principle apply the same models (sequence2sequence models are applied in NLP where there’s no time involved either) but whether or not they are well suited is for the experiments to say, I would say.

Thanks for your reply.
Although my data may not be sampled regularly, I plan to resample it before modeling at the second or millisecond level.
In that case, would DeepAR be a good fit ? If so, do you have any advice apart from the trick mentioned earlier in the thread ?
Related question: are there other models within gluon-ts which would be applicable to below second frequency?

@alexcombessie you may want to look into WaveNet: that was originally designed for generating audio signals.

So within this library, you are suggesting: DeepAR, seq2seq and wavenet. Can I use the same syntax for the three of the them ?
What about other models such as deepstate or note?

Well I think the best thing is to try, since I don’t really know about your use case. Also be advised that lots of pieces in the models may have been tailored to larger granularities (say above 1min), so while I’m suggesting to try, I cannot say whether they will work well for sub-second data.
About the models settings, it’s better to check the docstring of each of them to see which options are supported.

Alright, I will test and let you know what I find.
At some point it would be great to have seconds (and below) fully supported as canonical freq parameters. This is already the case for pandas.Timestamp so I would expect most models in gluon-ts to support it the same way. I understand that for some models there is a hard limit (for instance prophet cannot forecast below the minute). But there shouldn't be a global canonical frequency limit for all models.

Hi @lostella,
Hope all is well. Just wondering what is the status of this feature request in your roadmap?
We are still interested on our side. While we understand there are some "non-official" ways to do it now, we would rather wait for an official support through pandas freq strings.
Cheers,
Alex

Hi @lostella,
gluonts==0.5.0
I followed the previous post by setting lag_seq=[0] in the training and the model is trained successfully while the in the evaluation using backtest.backtest_metrics, the following error shows up:
.local/lib/python3.6/site-packages/gluonts/model/deepar/_network.py in get_lagged_subsequences(F, sequence, sequence_length, indices, subsequences_length)
    150             f"{sequence_length}"
    151         )
--> 152         assert all(lag_index >= 0 for lag_index in indices)
    153
    154         lagged_values = []

AssertionError:

Is there a plan to enable the 0 lag training?

@ziranfeng I think you should set the lags to [1] (the error message should be fixed, since lags are supposed to be positive)

FYI @StanislasGuinel


Update how-to-parse-a-string.md

Contributes to: #11913
I prefer to keep it as Contributes not Fixes to leave the issue open, as there can be much more details and more ways to access the data be added. This is just a little bit of detail added.

@Youssef1313
I think that we can change this from "contributes to" to "fixes" by providing a few links.  The articles under querying XML trees provide several examples for accessing the content in XML elements.
Do you want to add selected links to the "See Also" section?

Thanks for making the additional changes, @Youssef1313. I'll merge your PR now.


Combining jobs filter with Source filter is not working

A picture is worth a 1000 words :)

fixed in https://github.com/sic2/isamuni/commit/d8b5ac3eff025ccad65da1772d9d3428a3f2571d#diff-84be0acbf1f2d42a6821fdb2d24788b9R90 (misplaced parenthesis)


[Module Proposal]: Terraform module for Azure SQL Server

Check for previous/existing GitHub issues/module proposals

[X] I have checked for previous/existing GitHub issues/module proposals

Terraform or Bicep?
Terraform
Module Classification?
Resource Module
Module Name
Module Name - avm-res-sql-server
GH Repo name - terraform-azurerm-avm-res-sql-server
Module Details
Please refer to the this CARML Bicep module as it already implements RBAC, Locks, Tags, and Private Endpoints
https://github.com/Azure/ResourceModules/tree/main/modules/sql/server
Do you want to be the owner of this module?
No
Module Owner's GitHub Username
No response

@PankajMeshramCSA  I can take this up if no owner yet. Please assign to me

@herms14 - I see you have raised 3 other proposals. Lets work on those proposals.

@mbilalamjad - FYI - Please pay attention to the module name and GH repo name. I have updated based on the specs

@prjelesi please update the modules index to make sure that Tim is showing up as owner (instead of Bilal currently), thanks!

....in a pattern that is now becoming a little familiar 😂, here's a starter from me that covers the base sql server resource and an elastic pool child resource example, with passing E2E tests;
https://github.com/kewalaka/terraform-azurerm-avm-res-sql-server
there's more child resources to add (notable, the database!), but what is there is a decent foundation & is going to continue to align with what I need for the moment.
If there is another version our there, can we get it in the open, please & thank you 🙂?
cc @timchapman

additional use cases added to my AVM-style repo - notably the database child resource, also added private_endpoint E2E test/example:
https://github.com/kewalaka/terraform-azurerm-avm-res-sql-server
As per feedback in https://github.com/Azure/Azure-Verified-Modules/issues/359 (and in support of my own use case) I've also coded it so the database child resource can optionally use an existing sql server parent.
I've added some validation checks for things I've stumbled across, but there are lots of permutations with what is supported at what scales and skus.. so there is much more that can be added.  I also need to add auditing & vuln. assessments for my use case.
Keen to link up with @timchapman and combine efforts, but I needed something to use as a basis whilst the official one is progressed.

@mbilalamjad are you able to comment on the approximate timeframes for review, please?
Would you confirm this review is based on some internal work that hasn't been made public yet?
just trying to figure if i should fix the issues I tag above, or if the official is close enough to wait
cc @davidkarlsen

Hi @timchapman,
Performed a review of the module and have the following recommendations. As per the contribution process the PR needed to be reviewed by the AVM core team but since it was already merged with out a review from the avm-core-team-technical therefore I created an issue for tracking.
https://github.com/timchapman/avm-res-compute-sql-vm/issues/1

Repo needs to be setup in the Azure GitHub Org
_header.md needs to be updated
readme.md needs to be generated as per spec SNFR15 & TFNFR2
support.md needs to be updated
locals.telemetry.tf needs to be updated
Outputs haven't been defined in output.tf per specs RMFR7 & TFFR2
Consider setting a constraint on maximum major version of Provider per spec TFNFR26 in terraform.tf file.
Exclude terraform.tfvars file from the repo
None of the interfaces have been implemented as per spec RMFR5
Declaration of provider in module should be as per spec TFNFR27 in main.tf
After reviewing the main.tf, see multiple issues there in coding style, would recommend following the VM module here. https://github.com/Azure/terraform-azurerm-avm-res-compute-virtualmachine
Default E2E testing hasn't been done as per spec SNFR2, also consider adding additional examples giving the criticality of this module.
CODEOWNERS file needs to be updated as per spec SNFR9

For now, I'll move this back to "In Development". Once you've actioned the above, please let us know, we'll can do another review before clearing it for publishing 0.1.0 to the terraform registry.
CC: @matt-FFFFFF, @segraef, @PmeshramPM

@mbilalamjad Bilal Amjad FTE are you able to comment on the approximate timeframes for review, please?
Would you confirm this review is based on some internal work that hasn't been made public yet?
just trying to figure if i should fix the issues I tag above, or if the official is close enough to wait
cc @davidkarlsen

Thanks @kewalaka for the comment, the review above was based on a repo that Tim was working on, tagging @timchapman here to consider teaming up with you and combine both his and your module implementation into the official repo which needs to be setup.

Hi @timchapman I believe my version covers many of the points raised by the review.  It is implemented from scratch following AVM specs.
Let's get this work out in the open, then I can help address the issues raised.

@mbilalamjad reviewing the repository you link above - this code is for the wrong resource.  The code in that repository is for the SQL Server VM, whereas this issue relates to the Azure SQL Database resource (i.e. the PaaS version that isn't a "managed instance").
The SQL VM needs to be in a separate module proposal & resource because that would come under the microsoft.sqlvirtualmachine/sqlvirtualmachines namespace (i.e. this one).
This version that I shared above is for the correct resource.  There's a few minors that I noted are needed to address your review comments, but I think it is very close to a v0.1 (i.e. it implements the right patterns, interfaces, e2e tests etc).
I'm yet to receive any feedback from @timchapman on previous comments, @PmeshramPM are you able to help get us in contact?  I'm happy to work via github issues or can be contacted by the email on my profile.
thanks!

@mbilalamjad Bilal Amjad FTE reviewing the repository you link above - this code is for the wrong resource. The code in that repository is for the SQL Server VM, whereas this issue relates to the Azure SQL Database resource (i.e. the PaaS version that isn't a "managed instance").
The SQL VM needs to be in a separate module proposal & resource because that would come under the microsoft.sqlvirtualmachine/sqlvirtualmachines namespace (i.e. this one).
This version that I shared above is for the correct resource. There's a few minors that I noted are needed to address your review comments, but I think it is very close to a v0.1 (i.e. it implements the right patterns, interfaces, e2e tests etc).
I'm yet to receive any feedback from @timchapman Tim Chapman FTE on previous comments, @PmeshramPM Pankaj Meshram FTE are you able to help get us in contact? I'm happy to work via github issues or can be contacted by the email on my profile.
thanks!

Hey @kewalaka, this issue and the repo is for Microsoft.Sql/servers

@mbilalamjad Bilal Amjad FTE reviewing the repository you link above - this code is for the wrong resource. The code in that repository is for the SQL Server VM, whereas this issue relates to the Azure SQL Database resource (i.e. the PaaS version that isn't a "managed instance").
The SQL VM needs to be in a separate module proposal & resource because that would come under the microsoft.sqlvirtualmachine/sqlvirtualmachines namespace (i.e. this one).
This version that I shared above is for the correct resource. There's a few minors that I noted are needed to address your review comments, but I think it is very close to a v0.1 (i.e. it implements the right patterns, interfaces, e2e tests etc).
I'm yet to receive any feedback from @timchapman Tim Chapman FTE on previous comments, @PmeshramPM Pankaj Meshram FTE are you able to help get us in contact? I'm happy to work via github issues or can be contacted by the email on my profile.
thanks!

Good catch @kewalaka, let me update this issue proposal to reflect the same, @timchapman please take note and kindly setup the repo in Azure accordingly, will update the module index accordingly. @kewalaka as for your module please submit a new proposal and we'll take that forward accordingly

It would be good if this can be hosted centrally and rapid releases (onboarding one and one additional feature) - then we could start using it and evolve from there. I'd rather avoid depending on non-central repos and untagged releases. WDYT?

It would be good if this can be hosted centrally and rapid releases (onboarding one and one additional feature) - then we could start using it and evolve from there. I'd rather avoid depending on non-central repos and untagged releases. WDYT?

hi @davidkarlsen I'm in a similar boat - I have debated posted some of the resources I have to the public terraform registry, I've resisted doing this to date to avoid confusion, at the moment I'm sync'ing them into another space and tagging them there.
please, don't rely on my repos 😂
it does need to be balanced against having a good-enough v0.1, we don't want a situation where something is so far from the spec that it causes several painful breaking changes to align, which once published is not a great first impression from the consumer's point of view.
On the rapidity - I do favour the approach to release early with the parent resource & any absolutely necessary children first, though, agreed.

Reached out to @timchapman offline, this proposal will be updated accordingly here based on his input.

Reached out to @timchapman offline to check-in on any updates or support needed, he or I will update accordingly.


Support init-accessor of properties

Hi, I think it would be awesome if the C# 9.0 init-accessors for properties would be supported. Consider following example:
    public interface IRunnable
    {
        void Run();
    }

    internal class Runnable : IRunnable
    {
        internal IHelloWorldPrinter HelloWorldPrinter { private get; init; }

        public void Run() => HelloWorldPrinter.DoIt();
    }

    public interface IHelloWorldPrinter
    {
        void DoIt() => Console.WriteLine("Hello World!");
    }

    internal class HelloWorldPrinter : IHelloWorldPrinter
    {
    }

Without the init-accessor feature I would prefer construtor injection over property injection, because for the latter the property would need to become mutable. In my opinion the init-accessor is changing the game. In the example above, if constructor-injected, then the constructor would initialize a readonly field or get-only property anyway. So by supporting init-accessor the dependency could be injected into the "get-only" (of course there is also the init) property right away.
Additionally, that way the dependencies which are not relevant for the constructor but later on could be separated from the constructor.
One little caveat is of course that the init-injected properties cannot be used in the constructor, because they'll be initialized by the runtime after the constructor run through.

In the future CSharp plans to support required properties. https://github.com/dotnet/csharplang/issues/3630
Init properties can only be set at construction, but don't have to be set. Required properties have to be set at construction.
As such I think it makes more sense to wait for required properties and support them, then to support init properties.
We could view init properties as optional dependencies, i.e. - if we have something that can provide it then use that, otherwise ignore it, but I'm not sure if that would be best for users or not.

Didn't know about this proposal. Considering that, you are right the required properties would be a better fit for what I suggested.


How to use

Would love to try this out but have zero idea how I am supposed to set this up, the instructions state run ng build, but there clearly is some preliminary steps to get to there. Does anybody have a guide that might help.

The Frontend cannot work alone, you also require the REST API. The best way to start is by using the docker setup: https://github.com/snypy/snypy-docker


Expose certain helper and data types to consumers

In which branch or foundry version should this feature be added?
0.8.x + V9
Is your feature request related to a problem? Please describe.
It is currently clumsy to use already exported helper types like ConstructorDataType or downright impossible to compose a narrowed down version of things like ItemData, because it's components are not exposed.
Describe the solution you'd like
Both publicly available helper types and Document data components should be exposed in an easy to use manner.
Describe alternatives you've considered
For the helper types, one can import them directly from src, but that seems like accessing an internal API. As for the other problem, I have not found a solution.
Additional context
The reason I want to compose my own ItemData, is that I can override the data fields in my own item sub classes, if I already made sure in the constructor, that the data is correct.

I, too, am trying to create a subclass of ItemData. Unfortunately, it is not concrete enough to extend, yielding this error:
An interface can only extend an object type or intersection of object types with statically known members.ts(2312)
(alias) type ItemData = DocumentData<ItemDataSchema, ItemDataProperties, PropertiesToSource<ItemDataBaseProperties>, ItemDataConstructorData, documents.BaseItem> & ItemDataProperties & {
    ...;
}
import ItemData

This makes it impossible to extend and requires reimplementation in its entirety. I think a non-trivial portion of the problem is that ItemData and its subcomponents use derived information from globals for overriding so that templated changes can be configured.

The main problem is that ItemData is an intersection type. The reason for that is to be able to do type narrowing based on checking .type and the data configured by the user. Unfortunately, it is not possible for interfaces to derive from intersection types.
This means that it is not possible to derive from DocumentData classes when using the types. We didn’t find any other way to get the type narrowing and decided to go this way because inheriting from DocumentData is done only very rarely while type narrowing is extremely useful.
Unless we find a way to redesign the whole system how custom types are configured, this is a limitation we will have to live with.

To be honest, I still haven’t seen a valid use case for extending any DocumentData class. What are you actually trying to achieve?

Recursively embeddable items.

You should be able to do that already with Documents that allow custom data though. If it is the same data as the root item, you don't need to reconstruct the documentdata, just reference it. And foundry wouldn't fill that data automatically for you on first creation anyway. I have something similar, but I just stick to my system relevant data and fill that myself.

In my case, it's not necessarily the same data as the root item. Each item can be tweaked, have its mode switched, and lots of other things. I'm not sure what you mean by

And foundry wouldn't fill that data automatically for you on first creation anyway.

The only issues with foundry I've encountered so far are that it will filter embedded content it doesn't recognize when sending to the database, and it will error on parents of items that are not Actors being sent to the server.
Both of those can be solved code side without issue.
But to take advantage of a lot of the document functionality that exists for embedded Items, such as the permissions system, without essentially reimplementing quite a bit of existing functionality, requires adding new embedded types, which requires custom ItemData to define a new schema.

The thing is that foundry doesn't officially support items nested in other items. Even if you get the non system specific data layout in there, foundry will neither read or write it on its own. With permissions for example you would have to write them on your own and also enforce them on your own. I mean if you find an easy way to do that, I would be all ears. I need something like that for my system sooner or later.

Yeah, I've been messing around with various approaches pretty much non-stop over the past week. I've got a few viable paths, and a few of them use a sub-class of ItemData (doable right now even without the helpers exposed, just not as pretty). I think I'm on the verge of a breakthrough idea that reduces the amount of code that needs to be written as well as increasing the future-proofness significantly.
If it works out, I'll share it for sure.
Caveat: I'm essentially working around the foundry server-side issues, so when I talk about getting the behavior, I mean client side. So it does rely a bit on no one in the game intentionally breaking things, which they could do, because you can't trust the clients. So... I wouldn't use it for competitions that matter, but for games between friends, it should be fine.

I'm very confused by your idea. Even if you subclass ItemData to add additional embedded types, all of that will simply be rejected by the server side. Because the server side uses the standard ItemData which does not contain all of your stuff in it’s Schema.
This is very much on the edge of what may or may not be possible with foundry. If trying to make it work, I suggest to get a working prototype with plain JavaScript first.
But even if you get it work, as I said previously, the limitation of not being able to to subclass ItemData in the types isn’t going anywhere unless somebody comes around and lifts it. I highly doubt any of the current maintainers will do it.

I have several working prototypes (with Typescript) that I'm refining into the approach I like best. You're correct that if the data is sent to the server, the server will reject it. The trick is to intercept the data just before it's sent to the server, prevent the normal call to the server, preserve the data on the server via some other mechanism that will replicate correctly (I'm currently using flags on the parent), resume just after the call to the server would return (this is the tricky bit which I am evaluating solutions for, restore from the alternate persistence mechanism, and continue.
My proof of concept works for items in items. I'm not sure if it automatically works correctly for items in items in items without more work, as I haven't built enough to test that yet. (But I don't believe it does as there's a general exception for grandparents in the Foundry core.)

OK, I understand. Thanks for the explanation.
My point still stands, though. I'm actually pretty that sure it’s impossible to allow subclassing ItemData while allowing narrowing based on type. The underlying problem is this:

Narrowing .data.data based on checking .data.type is extremely useful for systems, so we want it
That means, the thing containing the data.data and data.type, i.e., ItemData / ActorData need to be sum types.
That makes it impossible to subclass ItemData / ActorData. TypeScript simply does not allow that.

I don’t see any way to solve this dilemma.

Postponing this for the V9 types.


[BUG] Remove code failure caused due to certain combination of parameters inside _load_provided_dataset()

Reference Issues/PRs

Fixes #3169
What does this implement/fix? Explain your changes.

Modify _load_provided_dataset() under datasets/_data_io.py to inhibit failures from data-type conversions.
Add return_type parameter to load_UCR_UEA_dataset() under datasets/_single_problem_loaders.py giving even more flexibility.

PR checklist

For all contributions

[ ] I've added unit tests and made sure they pass locally.
[x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG] indicating whether the PR topic is related to enhancement, maintenance, documentation, or bug.

@achieveordie, looks like there is one more problem:
the legacy data loader used some mtype strings that are not on the list of mtype, but were aliased, e.g., "numpy3d" would be interpreted as "numpy3D".
I fear we need to keep doing this to ensure downwards compatibility, the best way is probably via an alias dictionary.
Aliases I know of:

"np3d", "np3D", "numpy3d", for "numpy3D"
"np2d", "np2D", "numpy2d", "numpy2D",  for "numpyflat"

I wonder whether this is worth deprecating, or whether we should just "silently" accept these - ensuring downwards compatibility, but not mentioning in the docstring.
I would also change this in the notebooks that break, since we replaced by mtype strings. I.e., change the "numpy3d" in the notebooks to "numpy3D",  and so on.

Could you point me to the legacy data loaders that aren't making use of _load_provided_dataset()? We're checking for the mentioned aliases in load_from_tsfile() which is the only function that is invoked from _load_provided_dataset(), so as long as these loaders make use of the private loader functions, aliases can still be passed and corrected for, unless I'm incorrectly understanding the problem at hand.

According to the failure in run-notebook-examples and its traceback, one of the loaders (not legacy but "green" and used in many examples) is load_arrow_head which is directly calling _load_provided_dataset as far as I can tell.

Got it. Wouldn't it be better to use a private function to correct this behaviour instead of defining a (global?) alias dict; especially since the number of aliases are very small.
If you'd like lookup-based implementation, I'll revert to that.
I'll make this ready for review after the altered version of #3250 is accepted, I think everything else works fine.

Got it. Wouldn't it be better to use a private function to correct this behaviour instead of defining a (global?) alias dict; especially since the number of aliases is very few?

Yes, I would fix it in the private function - I was not suggesting a global alias dict.
I was simply suggesting to use a local alias dict.

Ah, I misunderstood you, sorry :)
Hope everything is in its right place now; thank you so much for helping me out throughout the pull request.

are the remaining failures going to be resolved once we merge the converter fix?

Yes, I checked the logs, they are the same errors that will be fixed from that PR.

failures are unrelated to this PR but are likely caused by today´s release of pmdarima 2.0.0


EXCEPTION CAUGHT BY SCHEDULER LIBRARY (Form)

════════ Exception caught by widgets library ═══════════════════════════════════════════════════════

The following NoSuchMethodError was thrown building _FormScope:
The getter 'initialValue' was called on null.
Receiver: null
Tried calling: initialValue

User-created ancestor of the error-causing widget was:
  Form-[LabeledGlobalKey<FormState>#7e514]
When the exception was thrown, this was the stack:
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:51:5)
#1      _FormBuilderSegmentedControlState.initState (package:flutter_form_builder/src/fields/form_builder_segmented_control.dart:62:21)
#2      StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:4068:58)
#3      ComponentElement.mount (package:flutter/src/widgets/framework.dart:3919:5)
#4      Element.inflateWidget (package:flutter/src/widgets/framework.dart:3101:14)
...
════════════════════════════════════════════════════════════════════════════════════════════════════

════════ (2) Exception caught by rendering library ═════════════════════════════════════════════════
The _ScaffoldLayout custom multichild layout delegate forgot to lay out the following child:
User-created ancestor of the error-causing widget was:
  Scaffold ════════════════════════════════════════════════════════════════════════════════════════════════════

flutter doctor -v
[√] Flutter (Channel stable, v1.9.1+hotfix.2, on Microsoft Windows [Version 10.0.18362.356], locale en-AU)
    • Flutter version 1.9.1+hotfix.2 at C:\Flutter\flutter
    • Framework revision 2d2a1ffec9 (2 weeks ago), 2019-09-06 18:39:49 -0700
    • Engine revision b863200c37
    • Dart version 2.5.0

[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at C:\Users\Marvin\AppData\Local\Android\Sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = C:\Users\Marvin\AppData\Local\Android\Sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
    • All Android licenses accepted.

[√] Android Studio (version 3.5)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin version 39.0.3
    • Dart plugin version 191.8423
    • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)

[√] Connected device (1 available)
    • Redmi 4X • 2be0bae7d630 • android-arm64 • Android 7.1.2 (API 25)

• No issues found!
Process finished with exit code 0

@leemuljadi This is a question better suited for StackOverflow, since most probably it's related to the implementation. The getter 'initialValue' was called on null.
Please provide a small self-contained app that demonstrates the problem. You can include small examples inline if they're enclosed by backticks, or just provide a public link to a github "gist" - https://gist.github.com/.

Okay thanks, @BondarenkoStas !


fix(masthead): Prevent focusing hidden elements

Related Ticket(s)
Fixes #5895
Description
Prevents focus going to hidden elements by paginating the dds-top-nav element when elements that overflow the scroll container receive focus

Changelog
Changed

Masthead top-nav items will focus as hidden elements are focused to via keyboard navigation

@andy-blum Is this a fix for when user tabs through the overflow menu items? I believe this is already being worked on by @ariellalgilmore in her PR here: https://github.com/carbon-design-system/carbon-for-ibm-dotcom/pull/7085
The bug ticket mentions focus going to hidden menu items when the search field is open instead of focusing on the search input. Is that related to the overflow menu items?

Our QA team is not able to reproduce the issue (#5895), since there is already a PR for the overflow tabbing we can close this PR.


References not correct for nested lists with equal key names

The follow model expose problems with references:
list a {
  key id;
  leaf id {type string;}
  list b {
    key id;
    leaf id {type string;}
  }
}

The b id leaf is marked to have 2 references.

Maybe you could help me interpreting the spec:
The section about the key statement states

Each such leaf identifier MUST refer to a  child leaf of the list.  The leafs can be defined directly in substatements to the list or in groupings used in the list.

I understood that any leaf that is a child of a list would be a candidate, but your example seems to suggest that only single elements can be ids (which makes semantically sense, of course).
So should I change the linking such that it doesn't look into substatements of nested lists?

My interpretation is that the leaf identified by the key statement must be defined directly in the list (or in the top level of a used grouping). So yes, the linking should not look into the substatements.

Thanks, I can confirm those semantics using pyang.


num of mbox_conf layers

Hi chuanqi305,
I tried to train my own dataset according to your instructions, and I found that there're 6 mbox_conf layers: conv11, conv13, conv14_2, conv15_2, conv16_2, conv17_2. It's a mistake or I misunderstand someting here?
One more question: why should I change the name of mbox_conf layers? If I change the names, we should also change the name for some "bottom" and "top" names, right?
Thanks.

For the conv11 layer， mbox_conf output is 63 = 21 * 3,
and for the other layers, mbox_conf output is 126 = 21 * 6.
You need not change the bottom and top names, just change the name of mbox_conf layers, to avoid weight shape conflict (if your class number is just the same as VOC, there is no conflict).


change program::cli callback to have optopt as the third parameter

wrong repository, moved to https://github.com/datagraph/libdrycli/pull/1


New Javadocs using dokka

Userdocs task will now generate dokka html docs. You can see an example hosted here. In order to get dokka to work I had to update to gradle 5. This meant switching to replaymod forgegradle. If anyone knows a better way to do the package exclusions please let me know since I spent ages trying to get it to work but i'm sure there is a better way.

superseded by #270


Focus can be lost from carousel after long press left / right

Steps to reproduce:

Run UI components examples app with the latest version of @lightningjs/ui package installed (v1.2.2).
Open "Carousel displayed as Row" page.
Long press left/right for 1 - 2 seconds, then press right/left (the opposite direction) twice. It may be necessary to repeat this several times and alternate between long pressing left & right keys. E.g. long press right, left, left, long press left, right, right...

Result:
Focus is lost. It can be recovered by pressing up/down, but it's no longer possible to control the carousel until the page is refreshed.
The following error is visible in the console:
Carousel.js:133 Uncaught TypeError: Cannot read properties of undefined (reading 'componentIndex')   at StateMachineRouter.navigate (Carousel.js:133:58)     at StateMachineRouter._attemptNavigation (CollectionWrapper.js:209:25)     at StateMachineRouter.left (CollectionWrapper.js:184:21)     at StateMachineRouter._handleLeft (CollectionWrapper.js:436:21)     at StateMachineRouter.focusBottomUpEvent (lightning.js:13920:55)     at StateMachineRouter._receiveKeydown (lightning.js:13943:48)     at lightning.js:13736:26     at _keydownListener (lightning.js:11415:17)
This issue has been raised by the Metrological QA team for an app we are developing. It is a medium priority issue and has contributed to a delay in release of our app.

Hi Brendan,
Sorry for the inconvenience, this issue should be resolved with version 1.2.3. Thank you for reporting!


Rate us

Is your feature request related to a problem? Please describe.
Users should be able to rate the website and provide review.
Optional implementaiton : sending mails to the user for their review and saying thank you.
Describe the solution you'd like
the review along with the rating should be stored in the database with the user.
Create API for the purpose.

Hey @haseebzaki-07 it's yours.
Do remember you have 3 days to complete this issue.
And I'd you like the project do consider to give the repo a star 🌟

Sure @Suraj-kumar00

hey @Suraj-kumar00 A backend API will work along with the frontend component. Where should I place the frontend component.
Could I set up the mongoDB database for the purpose, , a schema for ratings ??

hey @Suraj-kumar00 A backend API will work along with the frontend component. Where should I place the frontend component. Could I set up the mongoDB database for the purpose, , a schema for ratings ??

Hey can you help me to work on the issue no. #2 ? Because if that will be working fine you can easy do this take as well. And yeah that's a huge take to do to migrate the backend and database. Let me know if you can.

sure I will help with the migration @Suraj-kumar00 . Please let me know where to start from.

Can you please look at the issue first understand that and after that you have any questions let me know

@Suraj-kumar00 I know working with prisma and postgres but am new to supabase. So I think It will take decent amount of time.

Okay let me know if can share with you at tuts but you can also find them on yt actually that same Tech stack I'm  working for my college project that's why I can give it time, it'll benefit you a lot in terms Learning and all. But happy to see  that you are willing to work on this

@Suraj-kumar00 Bro I'll love to work on this but for now I am concerned in climbing up on the leaderboard. give me other issues that u think are important and this I'll come back when I get some time.

Okay then ease check issue i have created one more today.


Implement Features for Generating and Rendering Mock Data in Browser

Description:
This pull request introduces a significant enhancement to the project's UI and API functionality as outlined in the project requirements, enabling the rendering of data points in the browser and facilitating interactive data display through point-clicking functionality. Additionally, it establishes a mock API to efficiently transmit the extensive dataset to the frontend.
Features Implemented

[UI] Generated mock data and render 1M points in a browser, utilizing the regl-scatterplot library (referenced via https://github.com/flekschas/regl-scatterplot). Given the challenge of finding suitable mock data, random number generation was employed to fulfill this requirement and subsequent ones.

[UI] Implemented functionality to enable users to click on individual points within the rendered data visualization to access associated data, (instead of image, text, audio, video, I used the random points data).

[Stretch] Implemented a stretch goal feature wherein a preview of the associated data is displayed when users zoom in sufficiently on the data visualization.

[API]  Developed a mock API to facilitate the transmission of 1M points from the backend to the frontend.

Challenges:
One of the primary challenges encountered during the implementation process was the difficulty in finding suitable mock data for the project requirements. As a workaround, random number generation was utilized to simulate the required data points.
Test Plan:

Verify that mock data is successfully generated and rendered in the browser interface.
Confirm that clicking on individual data points displays associated image, text, audio, or video data.
Test stretch goal feature to ensure that previews of data details are shown when zoomed in sufficiently.
Validate the functionality of the mock API in transmitting 1 million data points to the frontend.

Screenshots/GIFs:
https://github.com/facebookresearch/MultiModalExplorer/assets/50773261/de6466f5-4ae0-4ee8-8c48-f5e48111bc0d

I know that a lot of these files come straight from the template. for files to be in this repo we need to keep a copyright header on them:
/**
 * (c) Meta Platforms, Inc. and affiliates. Confidential and proprietary.
 */

I know that a lot of these files come straight from the template. for files to be in this repo we need to keep a copyright header on them:
/**
 * (c) Meta Platforms, Inc. and affiliates. Confidential and proprietary.
 */

So, just to be clear, what I need to do is add this header to all generated files, right?

yes, all files that contain code have to have a license header.

Hi @adaorachi Overall this looks great!
I mainly have minor feedback in terms of naming, adding comments when needed. Feel free to merge when ready.

Thank you @somya for your extensive review.
I'll begin working on implementing the recommended changes.


Added topic on libs working together

@alandefreitas I have updated the PR based on the feedback.

@alandefreitas I made the change - change all references to Boost C++ Library to Boost or Boost Library, added a section to the combined libraries for MySQL, and added a section on debugging.

@alandefreitas Just Boost sounds friendlier, so I have run with that.


Close full screen scrcpy from Windows tablet

I am running full screen scrcpy on a Windows tablet. Is it possible to close scrcpy from a full screen?  With a tablet there is no keyboard, and no Windows title bar. If it's not a dumb question, then this is a feature request.

your tablet probably runs windows 10, and there are Multitasking (on desktop, it opens with Win-Tab or by a button in dock). almost nobody knows that actually you can open Multitasking panel with swipe from the left side on tablets, and Notifications with swipe from the right side. try this.

@gaussandhisgun Sorry, I should have mentioned that this is Windows 7

@gaussandhisgun Sorry, I should have mentioned that this is Windows 7

You got a tablet touchscreen working in WIndows 7?...bravo.
On windows 8.1 the best I could come up with to end scrcpy is a swipe from the right, then tap on Start then tap a icon which is a shortcut to run a batch file which contains; taskkill /im scrcpy.exe.
I would welcome any pointers on setting up a similar kill task / icon on the android client side.

@soopacrucial  The win32 gesture API is fully functional on Windows 7-10. It's the Windows 7 GUI that is touch screen deficient. My C++ app uses many of the common gestures; they all work just fine and have the same functionality on Windows 7-10.  I'm shelling out to scrcpy to take a few photos from a USB connected Smartphone.

RndyP, that makes sense, thanks for clarifying. By the sound of it, you might then also welcome a way to trigger the end of the scrcpy session from the Android side?


ranged through an array to make social-follow.html more efficient

not sure if this is helpful, but I made the social-follow.html more succinct by ranging through all of the repetitive code.
This could probably be improved by making sure the title and aria-label attributes are correctly capitalized for each link.  I used humanize to try to achieve this, but it does not split 'Stack Overflow' into two words or correctly capitalize 'LinkedIn.'

Thanks for this. We'll review right after the holiday.

I think this most recent commit fixes most of the capitalization issues.  The only remaining problem is that 'Stack Overflow' still renders as one word instead of two.

Thanks @zjrohrbach and sorry for not addressing your PR sooner as it did make a lot of sense. I just merged #422 which refactors the whole social logic of the theme!


Valor sheet accuracy fixes

Changes / Comments
Sheet: Valor

Bugfix: Added SP values for skills "Polearm Wielder" and "Ranged Weapon Wielder".
Bugfix: Vitality Limit could be leveled up.
Bugfix: Guts-based techs (e.g. healing core) wouldn't update when changing Guts value.

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[x] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

Can someone clarify this failed check? Sheet.json points to images/preview.png, which does exist. I didn't change sheet.json at all since the last commit. What do I need to do here?

@ProfessorProf I think you're fine. The validator expects the preview to be in the root directory of the sheet. If it's unchanged, I think we're okay. Merging.


Impossible to specify custom zIndex with classes (using DialogProps)

Is your feature request related to a problem? Please describe.
I have DatePicker in different cases.
1)
Simple page -> DatePicker
2)
Simple page -> DetailViewDrawer -> FiltersModal -> DatePicker
And for 1 - it works.
For 2 - doesn't work. I can not see Dialog because my FiltersModal has higher zIndex than regular MuiModal that is used by DatePicker
Describe the solution you'd like
I investigated suggested proposals 552 and 955.
And I used DialogProps:
const styles = () => ({
  modalRoot: {
    zIndex: 5000,
  },
});

function Calendar({
  classes,
} = {}) {
  return (
    <DatePicker
      DialogProps={{
        classes: {
          dialogRoot: classes.modalRoot,
        },
      }}
    />
  );
}

With this settings following layout is generated (when DatePicker is opened):

As you can see, the top most element that I can reach with DialogProps is

However I need to change zIndex of MuiModal-root for particular DatePicker.
Can you help me?
Can I reach some how low level ModalProps?

@volodalexey Is this issue resolved?

@nikhilaggala unfortunately no.

@volodalexey So, is there any workaround?

@nikhilaggala I do not know (

Please provide a full reproduction test case with the latest version (v4.0.0-alpha.5 as we are writing). This would help a lot 👷 .
A live example would be perfect. This codesandbox.io template may be a good starting point. Thank you!


refactor: Curated List - Vue Composition API

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[ ] Feature
[x] Refactoring

What's new?

[x] PR closes #3772
[x] WIP, branching from https://github.com/kodadot/nft-gallery/pull/3771
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

wfm 🚀

@preschian whats the payment range for this, i cannot tell from the linked tickets


[Identity] Throw CredentialUnavailableException from credentials not supporting ADFS

Fixes #14639

Both VS and VSC credentials will work only if VS / VSC was able to authenticate. If they fail for ADFS, shouldn't we get CredentialUnavailableException without any changes?

Both VS and VSC credentials will work only if VS / VSC was able to authenticate. If they fail for ADFS, shouldn't we get CredentialUnavailableException without any changes?

No, currently with the VisualStudioCodeCredential if a refresh token exists we will attempt to get an access token with it. This will make a call to the ADFS STS to get a token which will fail, and result in an AuthenticationFailedException rather than a CredentialUnavailableException. Since neither Visual Studio nor Visual Studio Code support authenticating with ADFS we can short circuit trying to obtain a token from them and continue to credentials later in the chain by throwing the CredentialUnavailableException.

Maybe then throw it right in the VisualStudioCredentialOptions / VisualStudioCodeCredentialOptions?


fix xmonad/xmonad#21

this seems to fix the regression(i've tested with dzen2 and plasmashell) but i'm not sure that this wouldn't cause the issue (couldn't reproduce it), fix of which caused the regression

The right answer here is that docksEventHook should watch for the strut properties changing and flush the cache. I've had a note about that in my stuff for a while (because we don't currently see it at all, so even without caching we don't react to struts changing until something forces the layout to run).

I should probably describe the full implementation.

docksEventHook should be mandatory.
manageDocks should select for property events on every dock window it (un)manages. It should also retrieve any strut information on the window and broadcast it with refresh to the layout, along with the window's XID.
docksEventHook should check for PropertyNotify events on struts and broadcast with refresh to the layout.
The strut cache (probably a Map Window ...) can now be stored in the avoidStruts constructor, and consulted when laying out the workspace. XQueryTree() is not needed, so it should not be slow on a workspace with many windows (remember that Decoration adds a bunch of windows! Easy way to get quadratic behavior from XQueryTree, and for that matter anything that iterates the StackSet).
docksEventHook should also watch for DestroyWindow events and broadcast-with-refresh to the layout, so avoidStruts can remove the strut for that window from the cache.

You need to broadcast-with-refresh so that xmonad will re-layout the workspace after a strut change; otherwise the strut will only take effect when something else forces a re-layout. (Docks get doIgnore-d, so will not trigger a re-layout.)
This requires at least two new "internal" struts-related messages: one to indicate the current strut for a window, and the other to delete the window from the cache.

Oh, another note re slowness of the current implementation: caching won't help much, because the real problem is that XQueryTree on the root window will return every window the X server knows about. This includes but is not limited to:

top level windows
unmanaged windows
unmapped windows (i.e. on workspaces that aren't visible)
internal windows: many toolkits will use a separate window for (almost) any UI element that can be clicked. Some will use one for every single UI element, no matter how simple.

You can easily be iterating through thousands of windows looking for the one or two that have struts. I don't recall the code offhand, but if it does not already restrict itself to direct children of the root window, it's also issuing two getProperty calls for each of those windows.

@geekosaur but how to watch on strut property changes on unmanaged windows?

@geekosaur done

can this be merged?

I am in no position to merge this or even decide whether it should be, but as someone who has had contributions accepted in the past I'd like to comment on this a bit anyway:
I really don't like your commit messages, they make it very difficult to review the changes. "fix xmonad/xmonad#21" is very much github-specific and is of no value to anyone who (a) for some reason doesn't have access to github/the internet at the moment, or (b) doesn't already know that it's exactly github they need. And then it doesn't explain what was wrong and what was done to make it better. The other commits look like a series of "change this" and "change that" and "code review amendments" etc. and in my opinion the entire branch should be appropriately rearranged and perhaps some of the commits squashed to tell a clear story of what was wrong and how it was fixed. @geekosaur's comments here could be a good material to put in the commit messages.
Here are some good tips on creating nice commits that are a pleasure to read, review and merge:
http://who-t.blogspot.cz/2009/12/on-commit-messages.html
https://github.com/erlang/otp/wiki/Writing-good-commit-messages

Aside from agreeing with liskin above, I don't see anything wrong here offhand. I'd prefer having more people test it before merging, but as about th only way we'd get any testing is to merge it....


[BUG] <Pull the latest version of docker image deployment service, the email function cannot be used normally>

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
docker pull tancloud/hertzbeat:latest
docker run -d -p 1157:1157 -p 1158:1158 --name hertzbeat tancloud/hertzbeat
访问localhost:1157启动默认帐户：admin/hertzbeat
消息通知---->新增接收对象---->填写邮箱信息---->测试报错
报错信息为：
触发告警测试失败!
[Email Notify Error] Mail server connection failed; nested exception is javax.mail.MessagingException: Could not connect to SMTP host: smtp.qq.com, port: 587; nested exception is: javax.net.ssl.SSLException: Unsupported or unrecognized SSL message. Failed messages: javax.mail.MessagingException: Could not connect to SMTP host: smtp.qq.com, port: 587; nested exception is: javax.net.ssl.SSLException: Unsupported or unrecognized SSL message
Expected Behavior
No response
Steps To Reproduce
centos7.9
内核版本为6.7.1-1.el7.elrepo.x86_64
关闭防火墙
Docker version 25.0.0, build e758fe5
Docker Compose version v2.24.1
Environment
HertzBeat version(s):
docker pull tancloud/hertzbeat:latest

Debug logs
No response
Anything else?
No response

hi, 发送邮件通知需要你提前配置自己的邮件服务器地址等参数，在系统设置页面。

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Hi, sending email notifications requires you to configure your own email server address and other parameters in advance on the system settings page.

已经搞定了，三克油，感谢官方

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿

Already done, three grams of oil, thank you official


More screenreader improvements

Screenreaders treat all DIVs as role="group" by default, which impacts depth calculation. An element which is visually at the "top level" of CodeMirror, such as a widget, should have a depth of zero.
Since CM has a nest of DIVs, this throws off the depth calculation significantly. This PR overrides the role of several DIVs with presentation, thereby fixing the depth calculation.
@marijnh , I can't help but wonder if the elt() function shouldn't just assign this by default. Virtually everything from the <pre> nodes on up to just before the wrapper should be probably have role="presentation"

If you want, you can define an eltP function which calls elt and then adds this role, and use that for all places that currently explicitly set role to presentation. Doing it by default for all elements created seems a little too magical/unexpected.

Good call. Done.

Great. Merged as 0b00c0e1


Add user_variable.yml file to rpcd

This repo is for deploying an opinionated version of OpenStack using
os-ansible-deployment. There are instances where the defaults that a
Rackspace deployment will use differ from the upstream deployment
project. This commit creates a user_variables.yml file to use for
specifying these defaults and so this file should be used instead of
the one in os-ansible-deployment.
The user_variables.yml file in os-ansible-deployment currently sets two
variables that are not specified by default, by the associated roles.
These variables, ssl_protocol and ssl_cipher_suite, are specified in
this new file.
Support have requested that the nova configuration option
[cinder]/cross_az_attach be set to False and so is set here to override
the upstream default of True.
The script update-yaml.py is added, for use when running an AIO, so
that the user_variables file added by this commit can be merged into
the one copied by bootstrap-aio.sh. Variables defined in the rpcd
user_variables.yml file will override those in the one supplied by
bootstrap-aio.sh.
Closes-bug: https://github.com/rcbops/rpc-openstack/issues/203
(cherry picked from commit 748a7259cc4f4e4193c4cc6eaf44a84f9057f8b9)

Asking to ask. Since this is a behavior change people will have to learn, have we submitted some docs to the upgrade docs part of the guide for folks upgrading?

/cc @git-harry who authored original commit
(on a side note, I did amend this project's README.md to incorporate this change, that change will get backported to kilo branch once this merges)

:+1:

:+1: LGTM backport

@mattt416 please rebase this.

I think this is made redundant by https://github.com/rcbops/rpc-openstack/pull/261

Yeah, #261 implements this with a more up-to-date user_variables file. closing.


How to start periodically task inside falcon?

I am going to build all-in-one application: web, RMQ consumer, periodically tasks, etc. I can't understand how to do it with falcon. I can't access Asyc::Task.current directly, because it is not initialized inside config.ru. Could you explain how can I do that?

@sergio-fry I guess this is no longer relevant but let me just leave it here.
https://github.com/socketry/timers
require 'timers'

timers = Timers::Group.new

five_second_timer = timers.after(5) { puts "Take five" }
every_five_seconds = timers.every(5) { puts "Another 5 seconds" }

loop { timers.wait }

We can probably change this so that the config.ru is constructed within the top level async block... let me check.

@webgago thanks!

@ioquatix some time has passed since the original question was asked, but still...
Is there a way to spawn an async task that operates concurrently in relation to Falcon's spawned request-related tasks? The code below seemingly achieves the goal but is it possible to do that with async only?
def subscribe
  Thread.new do
    @redis.subscribe("app_#{APP_ID}") do |on|
      on.message do |channel, message|
        LOGGER.debug "message on channel #{channel}: #{message}"
        MUTEX.synchronize { SubService.new(channel, deserialize(message)) }
      end
    end
  end
end

The thread in the code above is instantiated when the application starts and keeps waiting for sub messages. When received, it intervenes between whatever Falcon is doing. Is it possible to achieve this behavior without threads? Perhaps, by adding this as a task to Falcon's main event-loop? How can I achieve that?


Fix type definitions file

Still miss success method definition.

Wasn't really looking at the definitions themselves, just moving them out of the declare module block.


The event 'eval'

This is a question is regarding #16.  It seems that this event only gets triggered when I click on the plotted chart with a slight move of the graph.  How can I get the same data returned without me physically clicking on the graph?  Or is there a way to trigger the 'eval' in the code?

That's right, when you attach a listener to the instance the event was
already fired, I guess you can fire the "draw" event to make function plot
rebuild the graph e.g. instance.fire('draw')
On Tuesday, July 28, 2015, sonnyk22<EMAIL_ADDRESS>wrote:

This is a question is regarding #16
https://github.com/maurizzzio/function-plot/issues/16. It seems that
this event only gets triggered when I click on the plotted chart with a
slight move of the graph. How can I get the same data returned without me
physically clicking on the graph? Or is there a way to trigger the 'eval'
in the code?
—
Reply to this email directly or view it on GitHub
https://github.com/maurizzzio/function-plot/issues/19.

Sorry, it should be instance.emit('draw')
On Tuesday, July 28, 2015, Mauricio Poppe<EMAIL_ADDRESS>wrote:

That's right, when you attach a listener to the instance the event was
already fired, I guess you can fire the "draw" event to make function plot
rebuild the graph e.g. instance.fire('draw')
On Tuesday, July 28, 2015, sonnyk22<EMAIL_ADDRESS><javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:

This is a question is regarding #16
https://github.com/maurizzzio/function-plot/issues/16. It seems that
this event only gets triggered when I click on the plotted chart with a
slight move of the graph. How can I get the same data returned without me
physically clicking on the graph? Or is there a way to trigger the 'eval'
in the code?
—
Reply to this email directly or view it on GitHub
https://github.com/maurizzzio/function-plot/issues/19.

awesome!  it worked!  thanks

as of v1.9.4 the call has been replaced with instance.draw()


AdapterFile: suppress warnings of removed file cache entries

This can happen for example when multiple requests access the same expired cache entry.
One of them unlinks the file first and the other tries to remove nonexistent file and logs error.
And because of statcache, it doesn't even have to happen right after the is_file check.
I suppressed only the lines I found in the logs.

This change is

This looks good to me.


token variable in the wrong place

Updated the token variable being passed to the faults function, not on the module name.

Thanks @HawtDogFlvrWtr.


How do I generate single file script from it ?

Since the focus is competitive coding we would need to generate a single file once coding is done.
I suppose it is possible with libraries like this
I havent tried using libraries for competetive coding earlier so I am not aware of what most competitive coders who are using libraries are doing.
I would like to know what process the author is following.

I use a tool called online-judge-tools to combine files into one.
onilne-judge-tools


Comments have stopped working

IntenseDebate hasn't seen any development work for years - and now it appears to be completely broken.
Will investigate https://github.com/jacobwb/hashover-next as a replacement.

Experimenting with https://commentics.com - need to import the old comments.


Refactor #seedlist, and add #installed method to Xcode

This is needed for a better integration with https://fastlane.ci

Sorted #seedlist
#seedlist is public now
Xcode object has installed attribute that's not cached

Related to https://github.com/fastlane/ci/pull/819

Thanks for the comments @segiddins, will update the PR 👍

@segiddins updated ✅

Unfortunately https://developer.apple.com/download/more/ doesn't expose the exact build number of each Xcode release, so we can't use that to identify and download an Xcode release, will try to come up with something better


proxies update and bid strategy deprecations

Docs Build status updates of commit bb6bd56:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Advertising/bingads-13/campaign-management-service/campaign-management-value-sets.md
:warning:Warning

Details

Advertising/bingads-13/campaign-management-service/criterionadditionalfield.md
:warning:Warning

Details

:warning:Warning

Details

Advertising/bingads-13/campaign-management-service/addvideos.md
:bulb:Suggestion

Details

Advertising/bingads-13/campaign-management-service/cashbackadjustment.md
:bulb:Suggestion

Details

Advertising/bingads-13/campaign-management-service/criterioncashback.md
:bulb:Suggestion

Details

Advertising/bingads-13/campaign-management-service/deletevideos.md
:bulb:Suggestion

Details

Advertising/bingads-13/campaign-management-service/getvideosbyids.md
:bulb:Suggestion

Details

Advertising/bingads-13/campaign-management-service/updatevideos.md
:bulb:Suggestion

Details

Advertising/bingads-13/campaign-management-service/video.md
:bulb:Suggestion

Details

Advertising/bingads-13/ad-insight-service/getbidlandscapebyadgroupids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getbidlandscapebykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getbidopportunities.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedbidbykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedbidbykeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedpositionbykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedpositionbykeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/ad-group.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/campaign.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkdownloadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkuploadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/keyword.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbidstrategies.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addconversiongoals.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addimportjobs.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addkeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlistitemstosharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addnegativekeywordstoentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addsharedentity.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adduettags.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adgroup.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/appealeditorialrejections.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversionadjustments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyproductpartitionactions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/batcherror.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/biddableadgroupcriterion.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/biddablecampaigncriterion.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/bidstrategy.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-data-objects.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.

Advertising/bingads-13/campaign-management-service/campaign-management-value-sets.md

Line 55, Column 140: [Warning-file-not-found] Invalid file link: 'getadgropucriterionsbyids.md'.

Advertising/bingads-13/campaign-management-service/criterionadditionalfield.md

Line 10, Column 83: [Warning-file-not-found] Invalid file link: 'getadgropucriterionsbyids.md'.

[Warning-RepositoryOwnerPermissionInsufficient] Owner eric-urban of repository https://github.com/MicrosoftDocs/Advertising-docs has lost Admin permission. Please use Transfer Owner via Docs portal https://ops.microsoft.com to assign a new owner.

Advertising/bingads-13/campaign-management-service/addvideos.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Reserved.' is duplicated in 'bingads-13/campaign-management-service/addvideos.md(7,14)', 'bingads-13/campaign-management-service/cashbackadjustment.md(7,14)', 'bingads-13/campaign-management-service/criterioncashback.md(7,14)', 'bingads-13/campaign-management-service/deletevideos.md(7,14)', 'bingads-13/campaign-management-service/getvideosbyids.md(7,14)'....

Advertising/bingads-13/campaign-management-service/cashbackadjustment.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Reserved.' is duplicated in 'bingads-13/campaign-management-service/addvideos.md(7,14)', 'bingads-13/campaign-management-service/cashbackadjustment.md(7,14)', 'bingads-13/campaign-management-service/criterioncashback.md(7,14)', 'bingads-13/campaign-management-service/deletevideos.md(7,14)', 'bingads-13/campaign-management-service/getvideosbyids.md(7,14)'....

Advertising/bingads-13/campaign-management-service/criterioncashback.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Reserved.' is duplicated in 'bingads-13/campaign-management-service/addvideos.md(7,14)', 'bingads-13/campaign-management-service/cashbackadjustment.md(7,14)', 'bingads-13/campaign-management-service/criterioncashback.md(7,14)', 'bingads-13/campaign-management-service/deletevideos.md(7,14)', 'bingads-13/campaign-management-service/getvideosbyids.md(7,14)'....

Advertising/bingads-13/campaign-management-service/deletevideos.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Reserved.' is duplicated in 'bingads-13/campaign-management-service/addvideos.md(7,14)', 'bingads-13/campaign-management-service/cashbackadjustment.md(7,14)', 'bingads-13/campaign-management-service/criterioncashback.md(7,14)', 'bingads-13/campaign-management-service/deletevideos.md(7,14)', 'bingads-13/campaign-management-service/getvideosbyids.md(7,14)'....

Advertising/bingads-13/campaign-management-service/getvideosbyids.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Reserved.' is duplicated in 'bingads-13/campaign-management-service/addvideos.md(7,14)', 'bingads-13/campaign-management-service/cashbackadjustment.md(7,14)', 'bingads-13/campaign-management-service/criterioncashback.md(7,14)', 'bingads-13/campaign-management-service/deletevideos.md(7,14)', 'bingads-13/campaign-management-service/getvideosbyids.md(7,14)'....

Advertising/bingads-13/campaign-management-service/updatevideos.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Reserved.' is duplicated in 'bingads-13/campaign-management-service/addvideos.md(7,14)', 'bingads-13/campaign-management-service/cashbackadjustment.md(7,14)', 'bingads-13/campaign-management-service/criterioncashback.md(7,14)', 'bingads-13/campaign-management-service/deletevideos.md(7,14)', 'bingads-13/campaign-management-service/getvideosbyids.md(7,14)'....

Advertising/bingads-13/campaign-management-service/video.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Reserved.' is duplicated in 'bingads-13/campaign-management-service/addvideos.md(7,14)', 'bingads-13/campaign-management-service/cashbackadjustment.md(7,14)', 'bingads-13/campaign-management-service/criterioncashback.md(7,14)', 'bingads-13/campaign-management-service/deletevideos.md(7,14)', 'bingads-13/campaign-management-service/getvideosbyids.md(7,14)'....

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit f1a68dc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/campaign-management-service/cashbackadjustment.md
:bulb:Suggestion

Details

Advertising/bingads-13/campaign-management-service/criterioncashback.md
:bulb:Suggestion

Details

Advertising/bingads-13/ad-insight-service/getbidlandscapebyadgroupids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getbidlandscapebykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getbidopportunities.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedbidbykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedbidbykeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedpositionbykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedpositionbykeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/ad-group.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/campaign.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkdownloadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkuploadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/keyword.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbidstrategies.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addconversiongoals.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addimportjobs.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addkeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlistitemstosharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addnegativekeywordstoentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addsharedentity.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adduettags.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addvideos.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adgroup.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/appealeditorialrejections.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversionadjustments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyproductpartitionactions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/batcherror.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/biddableadgroupcriterion.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/biddablecampaigncriterion.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/bidstrategy.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-service-operations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-value-sets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaigntype.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/conversiongoaladditionalfield.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/conversiongoaltrackingstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/criterionadditionalfield.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.

Advertising/bingads-13/campaign-management-service/cashbackadjustment.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Defines the CriterionCashback Data Object.' is duplicated in 'bingads-13/campaign-management-service/cashbackadjustment.md(7,14)', 'bingads-13/campaign-management-service/criterioncashback.md(7,14)'.

Advertising/bingads-13/campaign-management-service/criterioncashback.md

Line 7, Column 14: [Suggestion-duplicate-descriptions] Attribute 'description' with value 'Defines the CriterionCashback Data Object.' is duplicated in 'bingads-13/campaign-management-service/cashbackadjustment.md(7,14)', 'bingads-13/campaign-management-service/criterioncashback.md(7,14)'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 0c32ce9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/ad-insight-service/getbidlandscapebyadgroupids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getbidlandscapebykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getbidopportunities.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedbidbykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedbidbykeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedpositionbykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedpositionbykeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/ad-group.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/campaign.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkdownloadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkuploadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/keyword.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbidstrategies.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addconversiongoals.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addimportjobs.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addkeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlistitemstosharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addnegativekeywordstoentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addsharedentity.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adduettags.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addvideos.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adgroup.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/appealeditorialrejections.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversionadjustments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyproductpartitionactions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/batcherror.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/biddableadgroupcriterion.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/biddablecampaigncriterion.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/bidstrategy.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-service-operations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-value-sets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaigntype.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/cashbackadjustment.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/conversiongoaladditionalfield.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/conversiongoaltrackingstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/criterionadditionalfield.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/criterioncashback.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 25d1bc9:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Advertising/bingads-13/ad-insight-service/getbidlandscapebyadgroupids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getbidlandscapebykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getbidopportunities.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedbidbykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedbidbykeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedpositionbykeywordids.md
:white_check_mark:Succeeded

Advertising/bingads-13/ad-insight-service/getestimatedpositionbykeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/ad-group.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/campaign.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkdownloadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/getbulkuploadstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/bulk-service/keyword.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadextensions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroupcriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addadgroups.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addads.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addaudiences.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbidstrategies.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addbudgets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigncriterions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addcampaigns.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addconversiongoals.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addexperiments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addimportjobs.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addkeywords.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlabels.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addlistitemstosharedlist.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addnegativekeywordstoentities.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addsharedentity.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adduettags.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/addvideos.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/adgroup.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/appealeditorialrejections.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversionadjustments.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyofflineconversions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/applyproductpartitionactions.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/batcherror.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/biddableadgroupcriterion.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/biddablecampaigncriterion.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/bidstrategy.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-data-objects.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-service-operations.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign-management-value-sets.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaign.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/campaigntype.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/cashbackadjustment.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/conversiongoaladditionalfield.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/conversiongoaltrackingstatus.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/criterionadditionalfield.md
:white_check_mark:Succeeded

Advertising/bingads-13/campaign-management-service/criterioncashback.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel