Cant login in the bot.

Hello there,
I am install this project on my server. But I found The bot cant be login, I dont receive email code
[root@localhost api.csgotrade.cn]# node index.js
info: Updating Game Files...
info: Logging in bot1
debug: bot1 Generating TOTP Code from shared_secret
debug: bot1 About to connect
info: Logging in bot2
debug: bot2 About to connect
info: Listening for HTTP on port: 1739
info: Connected to the database
debug: Fetched items_game_cdn.txt
debug: Fetched csgo_english.txt
debug: Fetched items_game.txt

Hey, this seems to be an issue with the node-steam library dependency. For some reason, the entire server list is invalid and the only server that does work is commented out. If you don't update your server list manually - all your connections will time out and keep looping forever. Here is the issue and the temporary fix: github.com/seishun/node-steam/issues/434

Hey, I have changed server.js. I am using this json https://api.steampowered.com/ISteamDirectory/GetCMList/v1/?format=json&cellid=0
But I get a new problem with it.
info: Updating Game Files...
info: Logging in bot
debug: bot Generating TOTP Code from shared_secret
debug: bot About to connect
info: Listening for HTTP on port: 1739
info: Connected to the database
debug: Fetched items_game_cdn.txt
debug: Fetched csgo_english.txt
debug: Fetched items_game.txt
info: bot Connected
error: Error logging in bot: eresult=5, eresult_extended=5, client_supplied_steamid=765611988475987**, count_loginfailures_to_migrate=0, count_disconnects_to_migrate=0
error:  Error: Disconnected
    at SteamClient._disconnected (/home/wwwroot/api.csgotrade.cn/node_modules/steam/lib/steam_client.js:186:24)
    at Connection.emit (events.js:182:13)
    at TCP._handle.close (net.js:598:12)

@BPatrick92    I have uncommon the {host: '<IP_ADDRESS>', port: 27017}, while the bot still not work. Now not clear where is the problem?  Do you know？ thanks！

@koalayby That server is no longer working, you need to grab list of all working steam official servers in order for it to work. From this website(https://api.steampowered.com/ISteamDirectory/GetCMList/v1/?format=json&cellid=0).
Go into /lib/bot.js. In the logIn(username, password, auth, show_in_game) function (line 22) paste
this.servers = [{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27017},{"host":"<IP_ADDRESS>","port":27019},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27018},{"host":"<IP_ADDRESS>","port":27017}];
And it should work.
@Xuchenhao I personally tried using 2FA/Secret key (phone) but it doesn't work for me. The email verification process specified in their documentation is working for me.

Make sure you have an account that doesn't send 2FA keys to phone but instead sends to email (the old way)

Go to config.js and leave auth: "" blank but fill in the user: "yourusername" and pass: "your password" then run, you will see something like "error: Error logging in bot: eresult=5, eresult_extended=5, client_supplied_steamid=76561198134534, count_loginfailures_to_migrate=0, count_disconnects_to_migrate=0`

Check the email that the bot is tied to, you should get an email that says "Allow new computer" that also contains the secret/2fa. Take this secret and paste it into the auth: "" in config.js.

Run and you should get "info: bot Log on OK

@BPatrick92 Could you file an issue for the 2FA bug? Make sure that the system time on your computer/server is accurate. Last time I checked (a year ago), it worked fine.
I was thinking of switching to node-steam-user/node-globaloffensive since it is far more robust than node-steam/node-csgo from some other projects I've worked on. Open to PRs for this.

@BPatrick92 , was struggling on this and wondering why no email triggered. Your solution works. You the man!

#20 Shows this is still an issue but should be fixed in https://github.com/seishun/node-steam/commit/8f0f68bc244bc02fd38c585bbe956b9546c562a0
I'll close this again when a release with this commit is published or the issue is resolved.


GAWB-3291: Remove timeouts

Addresses:
Needed for, but does not complete https://broadinstitute.atlassian.net/browse/GAWB-3291
Also addresses reported production sentry errors (search Sentry for DatabaseMatching or SocketTimeoutException).
See Also:
Consent UI PR that is not completed yet. The two can proceed separately - they are related but not dependent. Will update this PR with notes once that is complete.
Changes

Primary change is to remove the timeout for ontology calls which was set to 10 seconds. That's much too low for match checking which is fairly resource intensive.
Minor refactoring to clean up the code a bit.
Added swagger doc for the undocumented API.
Errors are being correctly reported to Sentry, so no need for logging changes.

Testing
Existing tests covered the timeout case already so no need for more.

[ ] Submitter: Include the JIRA issue number in the PR description
[ ] Submitter: Make sure Swagger is updated if API changes
[ ] Submitter: Check documentation and code comments. Add explanatory PR comments if helpful.
[ ] Submitter: JIRA ticket checks:

Acceptance criteria exists and is met
Note any changes to implementation from the description
Add notes on what you've tested

[ ] Submitter: Update RC_XXX release ticket with any config or environment changes necessary
[ ] Submitter: Update FISMA documentation if changes to:

Authentication
Authorization
Encryption
Audit trails

[ ] Submitter: If you're adding new libraries, sign us up to security updates for them
[ ] Tell the tech lead (TL) that the PR exists if they wants to look at it
[ ] Anoint a lead reviewer (LR). Assign PR to LR

Review cycle:

LR reviews
Rest of team may comment on PR at will
LR assigns to submitter for feedback fixes
Submitter rebases to develop again if necessary
Submitter makes further commits. DO NOT SQUASH
Submitter updates documentation as needed
Submitter reassigns to LR for further feedback

[ ] TL sign off
[ ] LR sign off
[ ] Product Owner sign off
[ ] Assign to submitter to finalize
[ ] Submitter: Verify all tests go green, including CI tests
[ ] Submitter: Squash commits and merge to develop
[ ] Submitter: Delete branch after merge
[ ] Submitter: Test this change works on dev environment after deployment. YOU own getting it fixed if dev isn't working for ANY reason!
[ ] Submitter: Verify swagger UI on dev environment still works after deployment
[ ] Submitter: Inform other teams of any API changes via hipchat and/or email
[ ] Submitter: Mark JIRA issue as resolved once this checklist is completed

Pull Request Test Coverage Report for Build 85

11 of 17 (64.71%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 61.547%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

consent-ws/src/main/java/org/broadinstitute/consent/http/service/DatabaseMatchingServiceAPI.java
11
17
64.71%

Totals

Change from base Build 70:
-0.03%

Covered Lines:
4813

Relevant Lines:
7820

💛  - Coveralls


A2C

Add A2C
We'd be able to work on A3C only after Distributed stuff. Once we have that we can also target D4PG, R2D2, etc

Added in #119


implemented hash-table

Signed-off-by: muskankhedia<EMAIL_ADDRESS>Implemented the hash table to save the hash value for every type and URL in the config file.

Please rebase on top of aquibbaig:tsdb-v2

Closing this PR as by mistake I have made the PR to the master branch instead to the tsdb-v2 branch.

aquibbaig:tsdb-v2

we shouldn't be required to PR other than bench-routes. That preserves commit rights and better code confidence. :smiley:


Memory optimisations for notifications have resulted in epochMillis not being set correctly for notifications

Describe the bug

We are now re-using the same AtNotificationBuilder object in the NotifyVerbHandler every time. However, we are not explicitly setting the notificationDateTime in the verb handler. As a result, the notificationDateTime that is used is not the current time, but is instead either the time the AtNotificationBuilder was first created (when the verb handler was created at server startup) or when it was 'reset' during the last previous execution of the verb handler.
The code as it stands is vulnerable to race conditions. Right now If we are going to reuse a single AtNotificationBuilder then we need to wrap the entire body of NotifyVerbHandler.processVerb in a try {get mutex; ...; ...; } finally {release mutex}
As it's possible that other bugs were introduced in these code changes, the changes should be re-reviewed in detail.

Steps to reproduce
Send some notifications.
Expected behavior
epochMillis should be correct
Screenshots
No response
Smartphones
No response
Were you using an atApplication when the bug was found?
No response
Additional context
Bug observed by @ralfeus

@gkc ack

@gkc  and @VJag :
Following are the proposed code changes to fix the issue:

Move the entire processVerb method into a try and finally block where we acquire the mutex lock when entering and release the lock after completion.
Explicitly set the notification DateTime to the atNotificationBuilder in the NotifyVerbHandler.processVerb method and NotificationUtil.storeNotification method.
Call reset method in finally block on processVerb instead of having calls to reset method in various places in the processVerb method. (or) call reset method during the start of the processVerb so that the previous notification data is reset and DateTime is updated to the current date time before processing the notification. Along with #2, calling the reset method at the start of processVerb would be an additional check.

@kalluriramkumar 1 and 3 are good.

I think the ask is to set the notification date time to now when the Notification bean is created and not used the one from the NotificationBuilder.

@gkc may I know if the way 2 is stated is what you had in mind?

@kalluriramkumar 1 and 3 are good.

I think the ask is to set the notification date time to now when the Notification bean is created and not used the one from the NotificationBuilder.

@gkc may I know if the way 2 is stated is what you had in mind?

At the moment, the notificationDateTime is a private member in AtNotification. So, if we wanted to set date time directly on atNotification object, we have to make it public or expose a getter and setter.

Not really I think the default value will be now(). Is the idea to set it from the value taken in the verb from SDK? If not then now() will probably do. Otherwise, if the intent is to set it right when the notification is sent out to the recipient then it has to be exposed.

@kalluriramkumar 1 and 3 are good.

I think the ask is to set the notification date time to now when the Notification bean is created and not used the one from the NotificationBuilder.

@gkc may I know if the way 2 is stated is what you had in mind?

At the moment, the notificationDateTime is a private member in AtNotification. So, if we wanted to set date time directly on atNotification object, we have to make it public or expose a getter and setter.

Or could call builder.reset() at the start of the verb processing - i.e. before using the builder rather than after.

Thanks @kalluriramkumar - I've approved the PR. Can you add a label to this issue for estimate on number of SPs effort this took, please?

Thanks @kalluriramkumar - I've approved the PR. Can you add a label to this issue for estimate on number of SPs effort this took, please?

Thank you, @gkc. Spent 4SP on this issue.


chore: creates .env only if not exists

Following up to #595
Given post install creates an .env based on .env.example
it is useful to happen only if .env doesn't exist
similar to what other open source projects do.

Thanks @ggiak but I'm going to go forward with https://github.com/roots/bedrock/pull/595


Robj from String/&str, and arrays/vectors thereof

This PR makes it possible to create Robj from String or &[String.
For example, changing the hello example to this would work, which wouldn't work before:
#[extendr]
fn hello() -> String {
    "hello".to_owned()
}

what's the purpose of impl<'a> From<&'a [String]> for Robj?
Suppose we have aVec<String>, it will be coerced to &[String], so Robj::from::<Vec<String>> is also implemented.
But your implementation first constructs an Iterator, conversion String to slices, and then collect them into a new vector.
So that is to say, it construct a new vector of slices out of a vector of string. But is this necessary?
Why not directly having an Robj containing Vec<String> instead of Vec<&str>?

I realized that I don't need to implement Froms related to String separately from those related to &str in the first place. The AsRef<str> trait could make it possible to implement both at the same time. However, when I tried:
impl<S> From<S> for Robj
where
    S: AsRef<str>,
{
    fn from(val: S) -> Self {
	unsafe {
            let val = val.as_ref();
	    // ...

I got this error:
upstream crates may add a new impl of trait `std::convert::AsRef<str>` for type `*mut libR_sys::SEXPREC` in future versionsrustc(E0119)

Also, as for &str-related traits, currently only From<&'a [&str]>, i.e. borrowed slices, is implemented, but not its owned counterpart, so I cannot write:
#[extendr]
fn hello() -> [&'static str; 2] {
    ["hello", "world"]
}

or
#[extendr]
fn hello() -> Vec<&'static str> {
    vec!["hello", "world"]
}

for example.

There is now a "From" for vectors of string-like objects.
We should handle iterators too in returns and input parameters.
fn sum(a: Iterator<Item=f64>) -> f64 { a.sum() }


Issue: protobuf-cpp and protobuf-python have potential Denial of Service issue reported for v0.58.0

The parsing and memory management vulnerability in ProtocolBuffer’s C++ and Python implementations can trigger an out of memory (OOM) failure when processing a specially crafted message, which could lead to a denial of service (DoS) on services using the libraries.
Affected  version is >= 3.20.0, < 3.20.2 and patched version should be 3.20.2
Issue reported with Splunk Otel Collector v0.58.0 and I did verify v0.61.0 also bundled with same version of package. Please let me know the timelines for fixed version of Splunk Otel Collector.
./usr/lib/splunk-otel-collector/agent-bundle/lib/python3.8/site-packages/protobuf-3.20.1-py3.8-nspkg.pth

@kumachop2 thanks for reporting this. The most recent version now picks up protobuf 3.20.3 from the Smart Agent bundle.


Create dark variant

Would be nice to have a dark GTK Paper theme variant.
Thanks!

@dbrodie Thanks for the suggestion, being that I don't actively use Paper GTK anymore, I didn't even think of that.
It can be found in the Chrome store at https://chrome.google.com/webstore/detail/paper-gtk-dark/kjpdhkfonpgopioenjbjoonbipifcaeo (as soon as Google publishes it).


Rubocop refactroing

Hello,
When I run rubocop in project I was found many offenses,
more than that I saw rubocop auto correction can correct 190 offenses of 274.
27 files inspected, 274 offenses detected, 190 offenses corrected
What do you think about auto correct offenses and may be I can correct others ~60 offenses by hands?
I can create pr.

Currently there is no rubocop config yet.
Let us a few days to add it to the project and we try to fix stylish after that.


make squash merge work with github flow

@Bowbaq had a good idea. since git town likes to squash merge, but it closes your PR rather than merging... what if the flow was: git reset master -> make a single commit (the same commit that would be your squash commit) -> force push to your pull request -> click merge on github. this would allow other tools that look at the status of a pull request to still recognize when PRs get merged in.

Great idea! That's the commit style that most open-source projects require (at least Rails does). All feature branches have to be squashed into a single commit, then merged together. I'm totally fine with adding a configuration option to Git Town to make git ship behave like this if desired.
I don't want to get rid of the current "squash commit" behavior, since it is the cleanest. The "squashed-merge" behavior described above requires two commits, and pollutes the history on master with a lot of  merge commits. I feel it is only so popular because of shortcomings of GitHub, particularly its inability to handle squash merges properly, even when it knows about them.

yeah, i agree it is a workaround for the fact that github doesn't understand the squash/merge flow. still would be cool!

Is it possible to have a separate command added that just does the squash/merge and doesn't worry about the rest of the process? I think this has more utility than just for github-style merged, but a Git Town command like that would enable a github-style merge workflow without any debate about which style is better.

@acmcarther do you mean something like git squash-branch that squashes all commits that exist in a feature branch into a single commit?

@kevgo @acmcarther a second command (with docs that say "friendly with the way github tracks whether branches are merged") makes sense to me

As an aside one company just starting to use git town really wants this
feature.
On Sat, Oct 10, 2015 at 4:11 PM matt handler<EMAIL_ADDRESS>wrote:

@kevgo https://github.com/kevgo @acmcarther
https://github.com/acmcarther a second command (with docs that say
"friendly with the way github tracks whether branches are merged") makes
sense to me
—
Reply to this email directly or view it on GitHub
https://github.com/Originate/git-town/issues/673#issuecomment-147133795.

--
Alex PeacheyDirector of EngineeringOriginate - Las Vegas+ 1<PHONE_NUMBER>

One thing to keep in mind here is that as an individual command ("git squash-branch"), this will cause a rewrite of Git history, and hence require a force-push of the respective feature branch. Which will cause problems if there is more than one collaborator on the branch, if the branch has child branches, or the developer uses multiple machines to develop. So this is obviously dangerous, goes against best practices, and in my opinion is a Git anti-pattern, especially when a tool like Git Town is used.
The only situation where I see this being useful as a stand-alone command is when somebody makes a PR from a fork against the upstream repo without commit rights, and that repo requires single-commit feature branches (like for example the Rails project does).
If the developer has commit rights, this command has no use, because history will be squashed when shipping. So, at this point, I'm fine with extending git ship with a configuration option that instead of squash-merging into master, squashes all commits into one on the feature branch, and then merges that single-commit feature branch into the main branch, then deletes the branch.
The only difference this would make is that GitHub shows "merged" instead of "closed".
Is that what you have in mind here?

Generally, being able to use github's standard workflow would be a boon to a simpler github integration. Simply put, being able to squash-sync just as easily as I can ship or sync or hack would be amazing. Then I could push the green button, or keep working on my branch, same as people always have when they squash.
If we bundle that functionality into ship, that satisfies most of my use cases though.

I don't want to miss also that this sort of merge strategy plays nicer with tools that integrate into github expecting pull requests to be merged, not closed, like Jira, or really anything using the github v3 api.

Git Town is not just a loose set of git macros where one can pick whatever is useful and disregard the rest. That's what git-extras is. Using Git Town this way misses the point of it, and prevents most of the synergy between the different commands, as well as the value that this brings.
Git Town is based on the idea that vanilla Git is too low-level and generic to be productive as an everyday developer tool. Hence we built an opinionated, high-level Git workflow support system that should be followed or extended instead of being avoided or fought against. It intentionally goes beyond the limitations of existing tools that are closer to vanilla Git (like GitHub), and does things better.
Not using git ship, and using the green merge button on Github, for example, doesn't clean up shipped branches from the developer machine, and is completely incompatible with our "child branches" feature. So I'm 100% okay with extending git ship to perform squashed merges (this feature has been on our roadmap for a long time, and is even mentioned in the screen cast), but I'm against recommending to merge on GitHub. At least without further insights into how exactly that impacts the rest of Git Town.
I think what most people want are correctly merged PRs, not pressing the green button on GitHub, so this should address this requirement. What do you think?

Honestly, if it doesn't play nice with the GitHub lifecycle, that's a show stopper for me. The fact that PRs get closed instead of being merged breaks an assumption baked into GitHub, and into all the tools that interface with it. It doesn't matter to me if things get merged in the UI, or by an API call (which would allow to do whatever cleanup is needed)

The improved git ship command that performs traditional merges is fully compatible with GitHub's lifecycle.

There are a number of scenarios where the merge button on GitHub needs to be used and/or the outcome of using it is desired. The two biggest that come to mind are:

On an OSS project you contribute to, they often have rules where a single person or group of people merge and merge by using the button on GitHub. Having an option to do the squashing, force pushing, and prepping the branch on the PR for merge with the button is desired here. There are downsides as pointed out like branch cleanup cannot happen, etc.

On a project that is housed on GitHub, some tools expect the PRs to be closed with a merge using the button on GitHub. There is also a visible difference looking at PRs closed by Git Town and PRs closed via the GitHub button. Many organizations do not like these differences. It's not that they want to see the little merge bubbles, what they want is for it to look like a "normal" GitHub project. Having an option here that would squash, force push to the PR branch, use the GitHub API to merge, and then clean up all branches would be desired here. You get all the benefits of the current git ship, but with the added benefit of it looking "normal" on GitHub.

Cool, great suggestions and conversation everybody! These are legitimate use cases. So it looks like we need to add a new configuration option called "ship-using-merges" (or something like that). When activated, it changes the behavior of several Git Town commands:

git new-pull-request squashes the commits into one before creating the pull request. This is safe, since that commit squashing has to happen anyways when shipping. So we can as well do it now. This allows to use the green merge button on GitHub without adding a mess to the main branch.

git ship re-squashes commits again if there are multiple commits in the feature branch, then does a normal merge.

git prune-branches can use a different strategy that allows it to find branches that have already been shipped more reliably now.

When making a pull request against an upstream repo, the "ship-using-merges" mode is automatically activated, even when it is otherwise disabled.
This configuration option is set per repository. I'm fine making "ship-using-merges" the default, because its more idiot proof and compatible.
@charlierudolph @allewun @ricmatsui what do you think?

@charlierudolph would love to hear your take on this, since I'm thinking about taking this one on as one of the next steps. This is a major improvement in compatibility with GitHub, but it also adds a good amount of complexity.

git new-pull-request squashes the commits into one before creating the pull request. This is safe, since that commit squashing has to happen anyways when shipping. So we can as well do it now. This allows to use the green merge button on GitHub without adding a mess to the main branch.

I find value in preserving commit history for a pull-request when reviewing a PR. Am I alone in this?

Yeah, that's a downside of this approach. Ideally even commits that address changes get squashed away here. If we don't do this aggressively, we run into the issue that somebody clicks the big green "merge" button on GitHub, and we mess up the Git history with WIP commits.

Overall the Git Town team agrees that advantages of this approach seem to outweigh the disadvantages, so we are going to make this the new standard behavior.
I have created milestone GitHub compatible merging behavior to track development of this feature. It contains tickets #705, #706, and #707 that allow us to build this functionality in pieces.
Thanks for the suggestion and the great feedback, please keep it coming!

cool!

Closing as 4.2.0 now merges via the GitHub API when applicable


update pom.xml to support release of SNAPSHOT version

For our users, they are using the released version; however, for our platform developers, it might be convenient to use the snapshot version for the dependencies instead of building all repositories locally with light-bot. Let's find out how to config the pom.xml to release the snapshot version.

Yes we really need to introduce snapshot versions which would be very helpful for developers.
To enable snapshot version, all we have to do in POM file is change version to say 1.6.0-SNAPSHOT to mark it as the SNAPSHOT (under development) version. Then every time we run mvn deploy, it will deploy version like 1.6.0-SNAPSHOT-{timestamp}-{counter} to central repository/artifactory. Developers can continue using version 1.6.0-SNAPSHOT which will fetch latest version for 1.6.0-SNAPSHOT-* from central repo. By default maven downloads given SNAPSHOT version once per day but can be configured to check central repo every time we run the build.
Once the development is completed for v1.6.0, to release it as a Stable Version, here are the steps we have to follow:

Remove -SNAPSHOT from the version in POM file
Run mvn clean install (which will build and deploy jar in local .m2 repo & we can verify the build)
Run mvn deploy (which will deploy release version into central repository)
Change version in POM file to 1.7.0-SNAPSHOT to start developing new features (change minor version to reserve patch versions for bug fixes on 1.6.0)

We can use maven release plugin to do all these steps for us but this plugin is not that reliable and its hard to recover if something fails.  So I recommend doing it manually.

@santoshaherkar Thanks a lot for the nice step by step explanation. I have updated most of the repositories to simplify the dependencies version with only version.light-4j in the properties. This significantly simplifies the version-upgrade light-bot configuration to update all repositories in batch pre-release and post-release. I will try it out with your step to update all versions to -SNAPSHOT.

While I was working on the light-bot configuration, I realized that we cannot blindly update all related repositories to a snapshot version in the master branch. For example, the light-codegen is used by a lot of users to scaffold projects on the latest released version and light-example-4j contains all the examples upgraded to the latest release so that users can try them out. I am thinking to create release branches for these repositories and make them as default branch and update the master branch with snapshot versions to ensure our tests are on the same branch consistently. What do you think?

The first snapshot version 1.6.1-SNAPSHOT was released last night. For more details regarding to the implementation, please visit https://doc.networknt.com/tool/light-bot/task/release-snapshot/


Improve Snowflake bind array inserts operations using adbc_ingest()

Problem: Bulk inserting a pyarrow table using adbc_ingest creates a bind array insert operation for every record batch. It takes 3 hours to insert 36 million rows across 3,000 record batches created by the pyarrow multithreaded CSV reader using adbc_ingest().
If you reorg the data into 36 record batches of 1 million rows each the same adbc_ingest() call only takes 3 minutes..
Sample code:
new_recordbatch = {column: [] for column in my_data.schema.names}
new_batches = []
rows = 0

for batch in my_data.to_batches():
    for column in my_data.schema.names:
        new_recordbatch[column].append(batch[column])
    if rows < 1000000:
        rows += batch.num_rows
    else:
        print(rows)
        new_arrays = []
        for column in my_data.schema.names:
            new_arrays.append(pa.concat_arrays(new_recordbatch[column]))
        new_batches.append(pa.RecordBatch.from_arrays(new_arrays, schema=my_data.schema))
        new_recordbatch = {column: [] for column in my_data.schema.names}
        rows = 0

if rows > 0:
    new_arrays = []
    for column in my_data.schema.names:
        new_arrays.append(pa.concat_arrays(new_recordbatch[column]))
    new_batches.append(pa.RecordBatch.from_arrays(new_arrays, schema=my_data.schema))

new_table = pa.Table.from_batches(new_batches)

cursor = adbc_conn.cursor()
cursor.adbc_ingest(table_name="xyz", data=new_table, mode="append")
cursor.execute("commit")

Forgot to add
adbc_ingest() needs something similar to https://arrow.apache.org/docs/python/generated/pyarrow.dataset.write_dataset.html which supports max_partitions=None, max_open_files=None, max_rows_per_file=None, min_rows_per_group=None, max_rows_per_group=None,
to control/optimized bulk insert throughput..

The original source are csv files and every column in the schema are just string types..
I can confirm that when reading the csv files using multithreaded arrow you end up with a pyarrow table / recordbatch reader that produces record batch lengths of 12k, 13k, 114k, etc..
The adbc ingest function just happens to send multiple snowflake insert ? ? ? ? array inserts that match 12k, 13k, 114k, etc rows inserted in the history log.
By merging multiple record batch arrays into lengths of 1 million before calling adbc ingest I can see 1 million row bind inserts in Snowflake.
Each bind insert is taking 5 seconds so 36 bind inserts takes 3 minutes..
Before with 3000 record batches the same bind insert was taking 3 hours..

@davlee1972 The PR (#1456) including this improvement merged last month and is slated for the upcoming 0.10.0 release. The details are available on the current dev docs build.

@joellubi - I just installed and tested it..
For 100 million records x 8 columns across 1,000 CSV files..
0.9.0 took 5.5 hours.
0.9.0 took 17 minutes with my custom 10 million row record batching.
0.10.0 took 2 minutes using default settings without any custom record batching..
Thanks.. Marking this closed..


migrate to ESM

Why

We have three dependencies that migrate to Pure ESM.
To update these dependencies, we have to migrate cli-kintone to ESM.

https://github.com/kintone/cli-kintone/pull/18
https://github.com/kintone/cli-kintone/pull/37
https://github.com/kintone/cli-kintone/pull/96

I think there are no negative effects on users because cli-kintone is provided as an executable and cannot be depended on by other packages.
What

migrate to ESM

Inquier v9 maybe also relate to this PBI:
https://github.com/SBoudrias/Inquirer.js/releases/tag/inquirer%409.0.0


A cask for Janus VR

Could you please squash your commits?

Running 'git rebase -i' yields nothing.  It says there's no operation to be performed

See the link, as it should explain it. Done in #11529. Thank you.


cant upload

if i upload my module something about error of python trace back (most resent call last):
file c:users/user/appdata/roaming/blender foundation/blender/4.0/scripts/addons/roblox-blender-plugin/lib/get_selected_objects.py",line 66, in get_selected_objects for selected_objects in context.selected_ids:
attributerror: 'context' object has no attribute 'selected_ids'. did you mean 'selected_bones'?
that's the error I'm getting pls help

I have the same issue

Solution:
https://github.com/Roblox/roblox-blender-plugin/issues/32#issuecomment-1816527799

Thanks for flagging! This plugin did not work with Blender 4.0 but this issue has been resolved in the latest release:
https://github.com/Roblox/roblox-blender-plugin/releases/tag/v1.0.2


chore: Bring master in-line with upstream

Brings the master branch in-line with latest changes from the upstream repository

@lwaddicor Feel free to ignore this; just opening it up as I've had to build a branch with the upstream changes to resolve a dependency issue I'm having.
For context, while in the process of updating the version of https://github.com/opencontainers/runc on https://github.com/multiplay/multiplay-go I ran into a dependency issue caused by this fork being out of sync with changes in the upstream

Out of interest I wonder if this fork is needed anymore, I got the windows preshutdown hook stuff upstreamed a while ago. Not sure what else (if anything) is different

Good to know, didn't look like anything else was different tbh

I think @lwaddicor is correct. The only other changes we had here we're additional sysctl support which I upstreamed ages ago, so we should indeed be able to remove this now.

Nice, yeah confirmed the pre-shutdown stuff is there upstream - https://github.com/multiplay/golang-sys/commit/b6458a4ca117e97c19a5fd843400b3b8874db9bd
Shall close, thanks both.
@lwaddicor When time allows, we should find a moment to update multiplay-go to point back at the upstream instead of this fork


False positive on Lint/UselessAssignment

Expected behavior
Not to be false positive on Lint/UselessAssignment when a variable is proc/lambda with argument(s)
Actual behavior
The following code is false positive on Lint/UselessAssignment: Useless assignment to variable - add_bang. (Lint/UselessAssignment)
  add_bang = ->(value) { "#{value}!" }
  add_bang('bang')

I noticed any variable with proc/lambda with argument(s) is evaluated false positive on Lint/UselessAssignment.
Steps to reproduce the problem
See the code above
RuboCop version
$ rubocop -V
0.48.1 (using Parser <IP_ADDRESS>, running on ruby 2.3.1 x86_64-darwin16)

Technically, if all you want to do is invoke the lambda, you could do:
->(value) { "#{value}!" }['bang']

@Drenmi that's a short reproducible example. I need to use this kind of code for #map or other purposes. I guess this is bug than something else :)

@deepj are you sure it is a bug? In your example you can't call add_bang like that. You can do add_bang.('bang'), add_bang.call('bang'), or add_bang['bang']

@backus Thanks for correcting me. Just very overworked and mixed up several things into one.


feat: add execute function

This PR adds an execute function so it's possible to run PLPGSQL directly.

Can you clarify the need to execute anonymous functions?

Right now, I use it to create multiple dynamic triggers but there are probably other use cases as well 😊

Can you share a code example? Anonymous functions are a very feature, and I want to make sure to only add them when really needed. Sounds like a good trigger implementation would better solve the problem.

A very what feature? 😊
Stripped down I use something like this:
BEGIN
    IF NOT exists_trigger('triggers', 'prepare') THEN
      CREATE TRIGGER prepare
        BEFORE INSERT OR UPDATE OR DELETE ON triggers
        FOR EACH ROW
        EXECUTE FUNCTION prepare();
    END IF;
END;

I think a trigger implementation could simply reuse this execute functionality so we could have both.

I am closing this pull request as I don't believe it is a good feature for the driver. The method is just a wrapper for some short SQL without doing anything substantial. I believe this should be better executed with raw statements as a long PLPGSQL will only be a few characters longer.


best practice for reading large amounts of data

What is the best way to read a large amount of data from a database (say 20,000 records) without reading everything into one result array? Is there any type of cursor functionality?

Currently there is no cursors at the BoltHold level, but Bolt itself supports cursors, and getting it directly from the source is one option.
https://godoc.org/github.com/timshannon/bolthold#Store.Bolt
You could have cursor-like functionality by using the MatchFunc query.
bolthold.Where("Name").MatchFunc(func(ra *bolthold.RecordAccess) (bool, error) {
			// if record matches my criteria call func to process on this record
                       // always return false so values don't get added into memory of matching records
		}),

I could see adding a ForEach method that runs a query for each matching record of a query.  It would basically do the same thing as the above.

Added https://github.com/timshannon/bolthold/issues/74 to track adding a forEach method.
It should be possible, but there may be some complications with Or's and skips.  We'll see.

You can now use ForEach for this:
err := store.ForEach(boltholdWhere("Id").Gt(4), func(record *Item) error {
	// do stuff with record

	// if you return an error, then the query will stop iterating through records

	return nil
})

nice!  thanks for implementing this, I look forward to trying it.


Hey Frind Look into this there are rust bindings for node!

💥 Proposal
https://github.com/neon-bindings/neon
we could refactor this to use them I know that this needs no additional explanation as getting gyp and node bindings out of the way is logical next step to get this even running on deno or other engines.

@reconbot hahhahaha sorry good job :)


Improve coverage of symbols

Hi @nox,
The maintainer of the extension hasn't been seen for 2 months.
I have opened a fork: https://github.com/KalitaAlexey/vscode-rust
I would be glad if you open the PR in my repo.

I have opened a fork

Any reason why you didn't actually fork the repository?

@nox,
It was fork for a long time.
I made it be a normal repository not far ago.


feat(): Add controls to exclude certain domains

A control to exclude certain domains would be useful.

Added in https://github.com/lauritzh/dead-domain-discovery/pull/15


Enable verbose/quiet options

Adds verbose and quiet options to archiveFiles task. Exact implementation of this is a little different for each tool:

tar
zip (Unix)
7-zip (windows)

quiet
N/A
-q
N/A

verbose
-v
-v
-bb[0-3] (logging level, 0 is default, 3 is most verbose)

Fixes #7817

Good to merge.


Not working with public dashboards

Describe the bug
The Zabbix plugin is failing on public dashboards because the queries are not using the Public dashboards endpoint
Expected behavior
The Zabbix plugin does not extend DataSourceWithBackend and it is making a request directly to the Grafana Backend.
Public dashboards override this query and use another endpoint, so each backend plugin needs to extend this class.

Hello everyone, I ran into the same problem. Does anyone have any ideas how to solve it?

Same issue here.  We were really hoping for this functionality, as we are constructing a public dashboard using aggregated Zabbix services to inform the University user community about the status of various IT services.

Is this issue from Typescript or Golang side, can anyone tell? thanks

@zoltanbedi we are also facing the same issue, any update on this? Thanks

Public dashboard feature should still work despite the warning. Are you seeing that not working? @atifzia

Is there any workaround for this at the moment?

@zoltanbedi I think the issue is within grafana. Because grafana is handling the session of users.
Can you please verify that?
I have tried to hit the following url from postman and i was getting unauthorized error
http://localhost:3001/api/ds/query

@sulaiman21 this is still not supported for zabbix and sadly you can't set auth_anonymus_enabled in cloud.

Is there any workaround for this? I don't want the general public to be able to make changes to dashboards, so I need auth for making changes, but there are a few dashboards that I need to be public.

@sulaiman21 this is still not supported for zabbix and sadly you can't set auth_anonymus_enabled in cloud.

This worked for me in the docker version by setting it in grafana.ini - but it seems that special considerations are required for view permissions to prevent undesired data leaks

This is still not working.
Here is a link that describes how to make the data source compatible:
https://grafana.com/docs/grafana/latest/dashboards/dashboard-public/#supported-data-sources

This is still not working. Here is a link that describes how to make the data source compatible: https://grafana.com/docs/grafana/latest/dashboards/dashboard-public/#supported-data-sources

grafana-zabbix seems to have both properties set to true in plugin.json, so the problem is likely not that.
I have noticed that public dashboards do work on some dashboards, but I have yet to find the culprit.

+1

+1

+1

+1

+1


Can't generate a zipfile in default template

liftoff 1.4.1 when I fix the default template and add an zipfile ，it runs error，please look the pictures

Liftoff doesn't know what to do with that zip file because it's trying to run it through the templating library. Why do you need to add a zip file to all of your projects? What do you expect to happen here?

3ks,got it!


Feature Request: @fanout directive

One thing that's currently hard to express in bramble is when multiple services want to "contribute" to a list of objects.
For example, I have something built on top of a big event stream, each of which represents some "Transaction", but different subsystems might "claim" that transaction and enrich it with additional data / interpretation.
For example, one transaction might represent a purchase that someone has made; while another might represent a salary payment; while another might represent recurring bill payment.
Each of these systems wants to index, store, and report on only their set of objects, but then in the merged API, we want to present a stream of all relevant transactions.
One component of this would be the ability to have something like a Union or Interface where different services have different implementations, and I know that's on your radar as something to support in the long run.
That can be worked-around for now though, by defining a boundary type, and each service adds it's own property to:
type Transaction @boundary {
  purchaseOrder: X
}
...
type Transaction @boundary {
  salaryPayment: X
}
...

However, there's no way to merge these queries across multiple services; the consumer of the API needs to make separate queries to each service and then merge them.
Something like a @fanout directive might solve this:
// service A
type Query {
  transactions: [Transaction!]! @fanout
}

// service B
type Query {
  transactions: [Transaction!]! @fanout
}

Bramble could then recognize, for fields tagged @fanout with the same boundary type and arguments, it can forward the query to all of these services, and then just concatenate the results.
I'm not sure how much this enroaches on Brambles philosophy of staying simple, so I totally get if this isn't something you want to support, but I just thought I would raise it as someone whose using (and loving) Bramble, but has a couple of pain points with it.

Hi @Quantumplation
Yes combining two resolvers into one result isn't easily doable. We have a few usages of your first suggested work around in our graph.
Unfortunately I think that's the best way to approach it. Combining multiple resolvers into one result would make things like pagination very difficult but it also conflicts with one of Brambles core design ideas, which is that a Field always maps to exactly one Service.
You're welcome to try other ideas on a fork and if they suit we can bring them back in but for now I think it will conflict with our attempt at saying simple.

@pkqk No worries, I totally understand wanting to keep things simple :)
We're about a full week into using bramble for a fairly complex API (all mocked out with dummy data for now, to trial it), and it's been working fantastically.  We're planning on using bramble heavily, and may end up with a number of upstream contributions / plugins / etc.
Is there somewhere we can stay in touch so I can occasionally throw questions your way about how to structure these things before going through the effort of a full PR / Issue writeup, to get alignment before investing a significant amount of work into any particular idea? each issue just feels like I'm being really heavy-weight / annoying :sweat_smile:

@Quantumplation I'm on the gopher slack with this same username so you can ask me there (I'll try and check it) we don't have a channel though as some other project took the #bramble name there.


Release 2018.9.14

Reviewer: self-merging

Description:
PRs in the release:

#295 return early if e.data is undefined
#296 Expand failed HTTPS protection to the entire hostname
#298 Anonymous alert when HTTPS upgrades fail

Reviewer Checklist:

[ ] Ensure the PR solves the problem
[ ] Review every line of code
[ ] Ensure the PR does no harm by testing the changes thoroughly
[ ] Get help if you're uncomfortable with any of the above!
[ ] Determine if there are any quick wins that improve the implementation

PR Author Checklist:

[ ] Get advice or leverage existing code
[ ] Agree on technical approach with reviewer (if the changes are nuanced)
[ ] Ensure that there is a testing strategy (and documented non-automated tests)
[ ] Ensure there is a documented monitoring strategy (if necessary)
[ ] Consider systems implications

Closing this since it contains untested changes just merged. Opened #302 instead


Documentation: Using router with function syntax

Hello,
Could someone give an example how to use the function syntax in combination with a router? Maybe that could be added to https://oxygenframework.github.io/Oxygen.jl/stable/#Routing-Macro-and-Function-Syntax
This is very easy following the documentation on the macro syntax, but how to do it with function style?
BG Stefan

Thankfully the usage is exactly the same. Here's an example from the tests:
https://github.com/OxygenFramework/Oxygen.jl/blob/v1.5.13/test/routingfunctionstests.jl#L15

Thank you for the hint!
BG Stefan


Fixed Updatifier - Now it works on SpongeVanilla

Note: Once you ship the annotation, you no longer need to load after Updatifier.
This could make Updatifier work properly without adding 01 before its jar's name. In the production jar, the Updatifier api will be included, which only contains the annotation and an abstract UpdatifierService.

This wouldn't cause issues if the server already has Updatifier installed, correct?


There is no Command window.

In 1299 you were able to reach commands like "/greeting" etc. from Command menu as you can see below.
By the way, when you type "/greeting" into chat screen greeting animation happens.

Of course they're many commands which were used in common.

This issue was moved to ApexKO/OpenKO#36

I don't believe that the command window is being loaded into the client at all. Looks like we should make a new UI class for curtail (cmd window). I can start laying out the class and the H hotkey to open/close the window. Unless I haven't found it which I'd like confirmation that I'm not missing something.

It isn't implemented, no.

Started working on this. Something goofy is happening when opening/closing dialog. Will have to add strings for commands.
[] Fix opening and closing of UI w/ 'H' key.
[] Add commands to UI window
[] Process commands
CUICurtail Commit

I know it's minor, but the name of that class is confusing. It's not the first thing I'd think of when trying to find that UI; perhaps it should be renamed such that it's at least similarly named to its name in UIs_us.tbl, e.g. CUICmdList?

I agree. I'll be changing the name. The reason I started with curtail is that's what it is called in the .dxt file and that's how I originally tracked it down. Lol idk what curtail even means feels like that got lost in tranlation.

Is there an example where strings are loaded into some portion of the UI that can be selected?  I'm having trouble deciding how this should work and haven't found a good example yet.  I'm assuming I'll place the commands on icons or something of the sort.  Then when an icon (whatever) is selected load a subset of commands.  Then upon an icon subset selection, the command gets handled.

Huh? I don't follow.
There's 2 listboxes; one for the command groups and the other for the selected commands.
You populate the first with the command groups from the resources, and then upon selection repopulate the command list itself with the selected commands.
All of the strings are loaded via _LoadStringFromResource().
When the commands are triggered, you trigger its respective command via handler in CGameProcMain. Likewise when it should prompt for string input (e.g. for names), upon submission it should trigger the respective command there with the provided input as an argument.
If command handling via chat is in a good place (it may need to be reverted and the command order updated if not, because a lot of stuff related to resources was tampered with early on in this repo), this should be fine. If not, that also needs to be addressed independently of this UI.

Made some progress.. it might be cleaner to create a list object for each category. Then I can load the strings in once on initialization and after that display the correct list based on what category a user selects.
CUICmdList Commit 3

@twostars I've implemented a map instead that I iterate over to pull in the text resources. Hopefully, this is a little cleaner than manually loading in each resource.
CUICmdList Commit 4

Regarding the extra commands being loaded, I wouldn't worry about them. In my implementation I just left them.
Can always just remove them from the TBL itself if they bother you, but they don't harm anything.

I appreciate all the suggestions you made on the last commit.
CUICmdList Commit 5

bool CUICmdList::ReceiveMessage(CN3UIBase* pSender, uint32_t dwMsg)
{
	if (NULL == pSender) return false;

	if (dwMsg == UIMSG_BUTTON_CLICK)
	{
		if (pSender->m_szID == "btn_cancel")
			SetVisible(false);
	}
	else if (pSender == m_pList_CmdCat) {
		uint8_t iSel = m_pList_CmdCat->GetCurSel();
		UpdateCommandList(iSel);
	}
	else if (pSender == m_pList_Cmds) {
		uint8_t iSel = m_pList_Cmds->GetCurSel();
		ExecuteCommand(iSel);
	}

	return false;
}

Each individual case here that handles the event should be returning true.
Additionally, it should default back to passing it to CN3UIBase::ReceiveMessage() so it can feed it back up the chain.
Finally, these cases:
	else if (pSender == m_pList_CmdCat) {
		uint8_t iSel = m_pList_CmdCat->GetCurSel();
		UpdateCommandList(iSel);
	}
	else if (pSender == m_pList_Cmds) {
		uint8_t iSel = m_pList_Cmds->GetCurSel();
		ExecuteCommand(iSel);
	}

These need to be more specific about the event we're actually handling here, e.g.:
	else if (dwMsg == UIMSG_LIST_SELCHANGE)
	{
		// Changed the selected group
		if (pSender == m_pGroupList)
			UpdateList(GetSelectedGroup());
	}
	else if (dwMsg == UIMSG_LIST_DBLCLK)
	{
		// Double-clicked a command
		if (pSender == m_pCommandList)
			SelectCommand(GetSelectedCommand());
	}

(I was lazy and just copied it straight from mine, so don't mind that :P)

@twostars what was the artist/station you were listening to earlier on your last twitch stream? It was good haha I'd like to hear more.

Can you be more specific? Just goes through Youtube's suggestions, but if I had an idea of which song (I was streaming for 8 hours, lol) I can probably narrow it down.

The reason I couldn't get any more specific is that I had no clue what was being said and I liked it all haha. It was like Japanese or Chinese pop music. I figured you were streaming some station. Wasn't looking for a specific song just the station 😄

Was probably Kana Nishino (nightcore version) then.

That's it! Haha alright sorry for spamming here I was too interested ><

Added in a new class and made some slight changes to CUICmdList. Starting to get things functioning together. Commands are being sent down to the chat command handler. Seems to work at least the commands that are being handled.
Commit 6

We can close this one.


Creator: Generating Adapter (download ZIP) gives no feedback

You can't see if anything is going on, nor can you do anything here.

This seems to be a bug.
Can you describe how you ended up with this empty screen?

I filled out the adapter creation wizard and clicked on "download ZIP"

Fixed.


Any CSS variable name containing the substring "content" causes weird, broken output

I finally isolated a weird bug that kept happening in my Next.js project.
If you use the substring content as part of a CSS variable name, then whenever you try to read that variable using the var() CSS function, styled-jsx compiles it into weird vendor-prefixed gibberish.
Reading a variable named --foo-bar
This compiles correctly.
export default () => (

hello world

)

// Output (correct):
import _JSXStyle from "styled-jsx/style";
export default (() =>

hello world

    <_JSXStyle styleId={2358650767} css={"p[data-jsx=\"2358650767\"]{color:red;width:var(--foo-bar)}"} />

);

Reading a variable named --foo-content
This compiles to gibberish.
export default () => (

hello world

)

// Output (gibberish):
import _JSXStyle from "styled-jsx/style";
export default (() =>

hello world

    <_JSXStyle styleId={161648215} css={"p[data-jsx=\"161648215\"]{color:red;width:-webkit-foo-content);width:-moz-foo-content);width:foo-content)}"} />

);

Reading a variable named --content-foo
This also compiles to gibberish, but a different kind.
export default () => (

hello world

)

// Output (gibberish):
import _JSXStyle from "styled-jsx/style";
export default (() =>

hello world

    <_JSXStyle styleId={477030615} css={"p[data-jsx=\"477030615\"]{color:red;width:-webkit-r(--content-foo);width:-moz-r(--content-foo);width:r(--content-foo)}"} />

);

this must be a bug in Stylis our css processor cc @thysultan

Patched in 3.2.18

@thysultan thank you.
@giuseppeg can you bump the stylis dependency and republish?
By the way, why does styled-jsx not use ^ or ~ semver ranges for its dependencies? What's the advantage of opting out of patch updates?

By the way, why does styled-jsx not use ^ or ~ semver ranges for its dependencies? What's the advantage of opting out of patch updates?

@callumlocke I didn't make that call. @leo / @rauchg may be able to answer that question. I imagine that the reason is that even patches can introduce regressions. This also was a pre-yarn decision iirc which we might revisit.

@callumlocke I just released 1.0.11 which includes the fix. Thanks for the bug report!


Update DataSets, accounting for pre-1.11 lack of user-agent

1.10 and 1.11 don't contain user agents so we need to show the full dataset for 1.12+.

[x] Update processAuditlog.py to include non e2e.test traffic

Current data set seems to ONLY have e2e, and not others.
Let's inspect the data set as created, and update the script to allow all user-agents.

@zachmandeville and I paired on this yesterday.
We removed the filter and we'll now have the full logs for all user agents for next sprint.

@zachmandeville can you ensure this was merged?

It is not merged yet, @hh , but i can be easily after https://github.com/cncf/apisnoop/pull/109 is merged; or if you wanted to pair with me on some git-rebasing-foo.


Custom ingressClass resource didn't create

Use case:
Two charts deployment:
1. kong with the default setting
2. kong-internal: with IngressClass: kong-internal
...
ingressController:
      resources:
        requests:
          cpu: 50m
          memory: 64Mi
      ingressClass:  kong-internal
...

When I check the ingress class
#kubectl get ingressclass -A

NAME   CONTROLLER                      PARAMETERS   AGE
alb    ingress.k8s.aws/alb             <none>       44d
kong   konghq.com/ingress-controller   <none>       252d

Expected:
I expected to see two Kong ingressClass but I see only one which the default and I didn't see the custom one that I created

Do you have a particularly old version, something older than chart 2.8.0? helm repo update should pull down the latest one.
This was originally broken, but was fixed a while back: https://github.com/Kong/charts/commit/4f49605c16f66031a62c15e79d5784e2233cbd66
I don't see an obvious reason the test to determine if we create the class would fail: unless I'm misreading the truth table we only don't if it doesn't exist or if your cluster doesn't support IngressClass, neither of which appear true for your environment.

Do you have a particularly old version, something older than chart 2.8.0? helm repo update should pull down the latest one.
This was originally broken, but was fixed a while back: 4f49605
I don't see an obvious reason the test to determine if we create the class would fail: unless I'm misreading the truth table we only don't if it doesn't exist or if your cluster doesn't support IngressClass, neither of which appear true for your environment.

I was using old chart but when I updated it, it didn't work so I had to clean the existing resources and create them again. This did the trick and worked!


Add files via upload

@elena-tyshchenko file.zip: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@elena-tyshchenko file.zip: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@elena-tyshchenko file.zip: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@elena-tyshchenko file.zip: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@elena-tyshchenko file.zip: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@elena-tyshchenko file.zip: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@elena-tyshchenko You weren't supposed to upload file.zip file directly. It was expected that you unzip file.zip file, fork SWOT repository, add unzipped file to your forked SWOT repository to an appropriate folder (lib/domains/org/st-andrews/students/), and make a new pull request.
I am sorry, I have to close the request without merging. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for the understanding!


[hw_printer_network] Keeps on trying to connect, even though found

Hi there, I have noticed that the hw_printer_network module keeps on trying to connect to the 9100 port of each network printer every 2 seconds or so, even though it has found all (1) of them. This code is executing. I would expect a delay of at least 5 seconds because of the sleep, but I think that two main loops are running in parallel.
Other than that - why are connection reopened all the time and not cached until they time out? Is there a design reason for that or was that just not implemented yet?

hello, @thomaspaulb
Yes, it's not implemented yet. What improvements could you offer?
regards

Well, am currently facing a blocking issue with this, because when the
module runs a while, port 9100 of the printer gets really overloaded with
all the requests and starts lagging.
I have to come up with a solution; my thinking would be to:

change the online check to a regular ping
do this asynchroneously and cache the results
the http status check would just return the cached values, or place the
check in the queue when it is an ip address not currently known
coexist better with the usb driver, by getting rid of "without_usb" and
other refactoring. Here i am not sure if its best to keep the current
solution of extending the escpos driver or registering as a separate
network_escpos driver.

Any suggestions before i start on it?
Op 1 dec. 2017 08:39 schreef "Dinar"<EMAIL_ADDRESS>
hello, @thomaspaulb https://github.com/thomaspaulb
Yes, it's not implemented yet. What improvements could you offer?
regards
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/it-projects-llc/pos-addons/issues/513#issuecomment-348424101,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZf9HPjo4YsSl4h73l5xvTH2bKouSYGks5s761EgaJpZM4QwaNJ
.

coexist better with the usb driver, by getting rid of "without_usb" and
other refactoring.

I have made this offer to get rid of the print delay in the 'network' printer. If we do not point out that USB printer isn't used then self.queue will always have checking of USB printer connection. Because of it, the task to immediate print will not be done

Well, that is true. But I think if we remove this, there should be now two drivers with separate queues running - one for the USB, and one for network. If we then remove lines such as this one so that the second driver handles network printers only, both USB and network printers should be handled well, and don't need to wait on each other since they have separate queues and threads?

@thomaspaulb Yes, I agree with you.
@yelizariev What do you think?

@GabbasovDinar I trust you

Thanks guys - now working on it, will submit a PR this week.

Hi Thomas,
I downloaded your module pos_printer_network, and the pos freezes after the step 'Connecting to posbox), if I activate reeceipt printer for posbox.
Do you have an explanation ?
Thanks
sebastien

Hi Robin, it is not my module but it was made by @GabbasovDinar. I just
made some changes in this PR, but they are not fully tested yet. Are you
using the main branch or the branch as changed by me?
On Wed, Dec 27, 2017 at 10:57 PM, robinshakty<EMAIL_ADDRESS>wrote:

Hi Thomas,
I downloaded your module pos_printer_network, and the pos freezes after
the step 'Connecting to posbox), if I activate reeceipt printer for posbox.
Do you have an explanation ?
Thanks
sebastien
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/it-projects-llc/pos-addons/issues/513#issuecomment-354183601,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZf9GCLmDhgN2xlUk3f5p9F797LO8WNks5tEr1TgaJpZM4QwaNJ
.

I wanted to test your changes from your PR because I had the problems you found with the other module.
and the pos ddoes not start with the version of your module pos_printer_network.
Do you think I can use your hw_printer_network module with the pos_printer _network of gabbasovdinar ?

@robinshakty Unfortunately I haven't tested the work of @thomaspaulb so I can't answer Your question. But I will check it soon...
regards

@robinshakty Could you post a screenshot or literal copy of the error in the browser console that accompanies the freeze?

@robinshakty I have rebased this PR onto the latest 10.0 branch, maybe that could help.
As to your question if you can use this hw_printer_network module with the old pos_printer _network module, it should be possible, I just removed some Javascript that is not needed anymore, but both versions should work. But if you post the error, we can find out if there is still any bug with that.


[website] Certificate expired

Mon Aug  6 09:18:27 BST 2018
The Let's Encrypt certificate has expired:

Expired: Sunday, 22 July 2018 at 19:21:20 British Summer Time

Regards,

Why is this closed site still have expired certificate.

Tue Nov  6 11:56:46 GMT 2018
@L3rchal:
Repo owner/site admin has not acknowledged nor responded to this issue.
Am closing all outstanding issues I've raised that are in this state.


NullPointerException occurs in running a tutorial code building a simple LwM2M Client

Question
I am new to this leshan LwM2M library so please understand me even if my question is a stupid one.
I tried to strictly follow the instructions given by https://github.com/eclipse-leshan/leshan/wiki/Getting-Started-:-Client but I failed to run the tutorial code.
I added specified maven dependencies with 2.0.0-m14 for the leshan library version under the  tag in my pom.xml.
I put the example code in my main function, resulting in the following code:
package com.jjh.maven.leshan_client_example;

import org.eclipse.leshan.client.LeshanClient;
import org.eclipse.leshan.client.LeshanClientBuilder;
import org.eclipse.leshan.client.endpoint.LwM2mClientEndpointsProvider;

public class App
{
    public static void main( String[] args )
    {
    	String endpoint = "..." ; // choose an endpoint name
    	LeshanClientBuilder builder = new LeshanClientBuilder(endpoint);
    	LeshanClient client = builder.build();
    	client.start();
    }
}

It successfully compiled but gave me a NullPointerException with endpointsProvider. The full error message looks like this:
Exception in thread "main" java.lang.NullPointerException: Cannot invoke "org.eclipse.leshan.client.endpoint.LwM2mClientEndpointsProvider.init(org.eclipse.leshan.client.resource.LwM2mObjectTree, org.eclipse.leshan.client.request.DownlinkRequestReceiver, org.eclipse.leshan.client.endpoint.ClientEndpointToolbox)" because "endpointsProvider" is null
	at org.eclipse.leshan.client.LeshanClient.<init>(LeshanClient.java:123)
	at org.eclipse.leshan.client.LeshanClientBuilder.createLeshanClient(LeshanClientBuilder.java:364)
	at org.eclipse.leshan.client.LeshanClientBuilder.build(LeshanClientBuilder.java:328)
	at com.jjh.maven.leshan_client_example.App.main(App.java:13)

In my understanding it seems that I need to call builder.setEndpointsProviders explicitly as builder.endpointsProvider is never initialized with the example code.
Is the tutorial code incomplete? or did I miss something?
If the example code is incomplete, can I ask where I can find a working and concise tutorial code for building a simple client (expecting much simpler code than LeshanClientDemo.java)
Thanks in advance.

Thanks @sbernard31
You are right! I could make it run by modifying the Leshan version from 2.0.0-m14 to 1.5.0


v0.3 Season of Discovery Api.lua error

1x Equipmate/Api.lua:144: Usage: IsPlayerSpell(spellID)
[string "=[C]"]: in function `IsPlayerSpell'
[string "@Equipmate/Api.lua"]:144: in function `TestItemForClassAndSlot'
[string "@Equipmate/Api.lua"]:199: in function `GetItemsForInvSlot'
[string "@Equipmate/Equipmate.lua"]:716: in function `Update'
[string "@Equipmate/Equipmate.lua"]:677: in function <Equipmate/Equipmate.lua:676>
[string "=[C]"]: in function `Show'
[string "@Equipmate/Equipmate.lua"]:109: in function <Equipmate/Equipmate.lua:93>
[string "@Equipmate/Equipmate.lua"]:144: in function <Equipmate/Equipmate.lua:143>

Locals:
(*temporary) = nil

Unfortunately the stack trace is not very helpful to figure out which item tripped this up.
Edit: This was on a L25 warrior

Some kind of reproduction.
It seems to happen when mouse-ing out of a paperdoll slot.

Fixed in #tag/Equipmate-0.31


Update to work with object capabilities changes in Pony 0.49.0

This fails CI because it needs tonight's nightly release. I've verified locally this works. Merging.


ELF backend to program loader

Implement an ELF backend to the program loader (implement ProgramLoader, Binary and BinarySection for ELF, similar to how it's done for RVL format)

Done in 011e3aa


Write documentation for our test artifact generators, test artifact and test repository annotations

Task Description
We need to document how to use the @TestArtifact and @TestRepository (and their alias annotations for the various layout providers) work.
The page should be placed under the Developer's Guide under the Writing Tests and be called Test Repository And Test Artifact Annotations.
The work for this will have to be done under the strongbox-docs project.
Tasks
The following tasks will need to be carried out:

[ ] Add documentation for the various implementations of the ArtifactGenerators for each of the layour providers.
[ ] List and document the available implementations for the supported layout providers, along with some examples of how to use them (MavenRepository, MavenTestArtifact, NugetRepository, NugetTestArtifact, NpmRepository, NpmTestArtifact, PypiRepository, PypiTestArtifact, RawRepository, RpmRepository, RpmTestArtifact).
[ ] Add some notes for the TestArtifactContext.

Help

Our chat
Points of contact:

@carlspring
@sbespalov
@steve-todorov

@carlspring
I would like to contribute on this. Let me know how to get started on this.

@simrandeep11 ,
You could start by taking a look at the classes mentioned above and writing an article in the strongbox-docs project as mentioned in the task's description.

This looks interesting I can get started on this

Ok I will have a look and get back.

@carlspring
I had a glance over the code and I am sorry I will not be able to devote sufficient time for this task right now as I am occupied with some important office work for next 2 weeks.
@Tapan123456
If you are still interested you can take over.

I would love to try helping this project, may I?

Hi @ZivGrin ,
Feel free to give it a go and to join our chat channel!

hey! I wanted to work on thi issue. may I ?

Hi!
Feel free to do so!

hey! Can I help on this issue ?

Hi! I would like to contribute. Can I help on this issue?

@kanwarpreet25 , @Radhika14soni ,
Have you guys had a look at the code mentioned above? That's the starting point. Have you built the project?

Hi, is anyone working on this atm,  can I contribute to this?

Hi, @steve-todorov is this issue closed? I have gone through the documentation there i find the Test Repository and Test Artifact already there. Is there anyrhing that i can do ?

hey, is anyone currently working on this issue? I would love to contribute

I would recommend you pick another project.

I would like to contribute on this. Let me know how to get started on this.


Updates?

Hi,
Is this project still being developed/worked on?
Thanks

Hello @KittyDreadful
No sorry, but this code in this repo is not currently being maintained. We recommend you use the Delivery Plans feature that is core to Azure DevOps.


Teacher_forcing does not work when using TopKDecoder

Hi, I did not see where the teacher_forcing is used when using TopKDecoder.

Closing this for now


fix(otelglobal): remove linter warn when parsing status_code

Addresses issue described in #671

looks like the PR is blocked by https://github.com/open-telemetry/opentelemetry-go-instrumentation/pull/674


force_fallback produce invalid span

In<EMAIL_ADDRESS>related https://github.com/botika/yarte/issues/211
With parse impl of syn::Expr:
ywrite_html!(buf, "{{ @ }}");

works correctly, error is spammed by syn with fallback span.
And for this with Punctuated::parse_terminated:
ywrite_html!(buf, r#"{{> hello_ex my_card body="foo" }}"#);

not works, panic with Invalid span with no related FileInfo!

Would you be able to provide a minimal repro using proc-macro2 only, independent of yarte and syn?

It is much more complicated than I expected, I cannot replicate it separately. It will take a little longer.
On the other hand, I got stable / nightly mismatch  panic in the trybuild tests of yarte.
The implementation is very stable but from the error messages it seems that it operates with both types of Span when it should be forced to fallback.
I will try to reproduce it but it will take a little longer.

I'll close this in the absence of a way to reproduce. Feel free to open a new issue if you nail down what's happening.


Multiples instances of the same tag

Hi, RiotControl dont support multiples instances of the same tag handled by one store, did you find a workaround ?

@Mariick you have to come up with unique namespaces for your events.
Like action:tagName for all similar tags or action:tagName:tagInstanceID for specific instance of a tag.

Thank you @rma4ok ,   @jimsparkman  already answer me in another thread on RiotJS's github (https://github.com/riot/riot/issues/1312#issuecomment-156885632) , i just forget to close this one.


Could QuickInfo add Opcode and Description info

QuickInfo tooltip offers the following feature,

Could QuickInfo support the following info(It is from https://github.com/HJLebbink/asm-dude/wiki/IMUL ),

I had two reasons not to add that info in the performance info.

I cannot do that without handpicking the descriptions and opcodes for each combination of instruction and operand. The performance info is from Agner Fog and the descriptions are from the wiki. These sources are not very comparable. I think it would be difficult to figure out (with some Python) which description should be matched to a performance line. E.g. line with IMUL r8 and IMUL m8 should have the same description and IMUL r,r would be described differently.

Other issue is that there is no obvious place to put that description on a line. The descriptions of IMUL are short compared to those of others.

If you have an idea how to solve both issue, do let me know. I do think that having the description would be useful.

I think we don't need handpick those info. AsmDude can add option in Visual Studio's Options window, which just like,

When "Performance" is enabled, Quickinfo displays performance info. When "Description" is enabled, Quickinfo displays the descriptions are from the wiki.
There are 1457 instructions in the wiki, which descriptions are the same with Intel's manual,e.g.,

Sorry for the unrelated question, but my AsmDude doesn't How to show the opcode when I hover over an instruction. It does show pretty much everything else. Anybody knows if there's an option that I have to enable for this? I can't figure it out.


Hyperband/bayesopt cleanup

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Changes for #1488


chore: replace caip properties with their high-level counterparts

Description
Updates web to support breaking changes introduced in https://github.com/shapeshift/lib/pull/604.
Note, requires https://github.com/shapeshift/lib/pull/604 to be published, and assumes the new version number will be 4.0.0.
Contributes to https://github.com/shapeshift/unchained/issues/398.
Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[x] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
Closes https://github.com/shapeshift/web/issues/1629
Risk
Medium. In theory, this is nothing more than a refactor, but the surface area is large and app usage should be tested well.
Testing
Check that all parts of the app still function as expected.
Screenshots (if applicable)
N/A

Closing in favor of https://github.com/shapeshift/web/pull/1736


Expose list of "todos" in problems/:slug endpoint

We've done a list of todos per language (/tracks/:id), but it would be useful to have the inverse, as well.

The todo endpoint contains exercises that are marked as "deprecated" or "foregone" in the config.json.

Ah, yepp. You're right, we need to filter those out.

The deprecated/foregone problems are filtered out as of 83cc2193012cf30a0c9ef8fafc3f04d5d8b33a85
We still need to add the todos in the problem, though.

@kytrinyx Maybe I'm mis-reading this issue, but I'm still seeing a deprecated problem here
http://x.exercism.io/tracks/rust
My understanding is that Accumulate is deprecated, but I still see it as a todo for Rust.

Rust doesn't have any deprecated problems: https://github.com/exercism/xrust/blob/master/config.json#L39-L41

Ah! We deprecate them by track. I did not get that at all.
If Accumulate is deprecated, should we create an issue for all tracks asking them to deprecate it?

I read through that thread recently, and it didn't feel like we had all come to a conclusion. Once I can figure out what the consensus is I'll submit an issue everywhere.

I've asked about posting to all the tracks about deprecating accumulate. https://github.com/exercism/x-common/issues/129#issuecomment-245139276
I believe this issue is taken care of.


Comment preprocess: check group exists before sending email

In the comment preprocess, we send emails to the comment readers. Reviewers/Submitted groups are created when reviews are posted, so this group might not exist if comments are posted before reviews.
We should check the group exists before sending the email.

@celestemartinez could you provide a use case for Emilia to reproduce this issue? I don't see that this is happening now.

This happened when a user tried to post a comment visible to Reviewers/Submitted. However, the Reviewer/Submitted groups are created when a review is posted. If the comment is posted before any reviews are posted for that paper, we will get this error.
I don't think PCs usually enable comments that early in the venue's workflow, but this error will happen if they do.
You can use the test_iclr_conference_v2.py to test this. Try to post a comment with Reviewer/Submitted to any paper except Paper#1.


Log file size

update documentation with update code option
change logging to use venus log rotation by default

See my comments.
I've also tried the update on my installation: Forgot to "uninstall.sh/install.sh" myself... Should we make this hint more visible?

this is now also better in documentation


Clean no issues

Describe the bug
Description of the bug here.
Steps to reproduce
Steps to reproduce here.
Additional context
Additional context here.

Start it

Perma ban


Unable to change root password for database if provided via environment variable ORIENTDB_ROOT_PASSWORD

OrientDB Version: 3.2.32
Java Version: openjdk 11.0.23
OS: Alpine
Expected behavior
If the value of ORIENTDB_ROOT_PASSWORD is changed in the new password should be consumed.
Actual behavior
When ORIENTDB_ROOT_PASSWORD is changed, database is unable to use new password, instead continues to use old password.
When the OSystem database is deleted then only new password is consumed.
Steps to reproduce

Download and start OrientDB server by running ORIENTDB_ROOT_PASSWORD="password" server.sh command.
Try accessing the studio. Should be accessible.
Change the password and run again. Should not be accessible.

Extra Findings
If password is provided via orientdb-server-config.xml file as provided below
    <users>         <user name="root" password="Root@1234" resources="*" />         <user name="guest" password="admin" resources="connect,server.listDatabases,server.dblist" />     </users>
Then I am able to login database with both passwords. One provided via environment variable and one provided in xml file at the same time.

Hi,
Yes I think that password as today is retrieve and stored somewhere else, I do agree this may not be the best behavior, I will see if this can be corrected.

Hi,
This should be fixed in 3.2.33 let me know if you can verify it.
Regards

Hi @tglman,
Thanks for resolving the issue. I verified it is now resolved. If new password set via environment variable it is considering the new password.
Only one thing I found new is, now the database console logs shows the database password.

Was this intentional as previously it was "INFO  Found ORIENTDB_ROOT_PASSWORD variable, using this value as root's password [OServer]".

Hi,
Thank you for checking this, yes we should not log the password, that strange, I will double check this and make sure it doesn't happen, will leave this open till I make sure is not logged

Hi,
The logging of the password should be fixed in 3.2.34, closing this, feel free to reopen it if you see still some problem.
Regards


[PE-D] Inconsistent in app behaviour vs app prompt

For addexpense, the app's command failure result message states that,
Cost should only contain numeric characters without spaces up to only 2 decimal places, and it should not be blank

which seems to suggest amount with more than 2 d.p. is invalid. Whereas in fact, it is considered as valid and rounded.

Labels: severity.Low type.FeatureFlaw
original: JeffZincatz/ped#6

@kheekheekhee x * 100 % 1 == 0


Camera with lerp does not center on followed sprite

This can be observed in the following example by moving the character around. When the camera is catching up from above or left of the character, it doesn't stop at the center of the sprite.
I wrote this issue in a hurry. Please let me know if I can provide any other information.
var game = new Phaser.Game(800, 600, Phaser.CANVAS, 'phaser-example', { preload: preload, create: create, update: update, render: render });

function preload() {
    game.load.image('background','assets/tests/debug-grid-1920x1920.png');
    game.load.image('player','assets/sprites/phaser-dude.png');
}

var player;
var cursors;
var debugLine;
var debugLine2;

function create() {
    game.add.tileSprite(0, 0, 1920, 1920, 'background');
    game.world.setBounds(0, 0, 1920, 1920);
    game.physics.startSystem(Phaser.Physics.P2JS);
    player = game.add.sprite(game.world.centerX, game.world.centerY, 'player');
    game.physics.p2.enable(player);
    player.body.fixedRotation = true;
    cursors = game.input.keyboard.createCursorKeys();

    game.camera.follow(player, Phaser.Camera.FOLLOW_LOCKON, 0.1, 0.1);
    debugLine = new Phaser.Line(0, 0, 0, game.camera.view.height);
    debugLine2 = new Phaser.Line(0, 0, game.camera.view.width, 0);
}

function update() {
    player.body.setZeroVelocity();

    if (cursors.up.isDown) {
        player.body.moveUp(300)
    }
    else if (cursors.down.isDown) {
        player.body.moveDown(300);
    }
    if (cursors.left.isDown) {
        player.body.velocity.x = -300;
    }
    else if (cursors.right.isDown) {
        player.body.moveRight(300);
    }

    debugLine.centerOn(game.camera.view.centerX, game.camera.view.centerY);
    debugLine2.centerOn(game.camera.view.centerX, game.camera.view.centerY);
}

function render() {
    game.debug.text("Arrows to move.", 32, 32);

    game.debug.geom(debugLine, '#ff0000');
    game.debug.geom(debugLine2, '#ff0000');
}

I was able to reproduce this, and I think a quick fix to your issue is to add to your create() method:
game.camera.roundPx = false;
The key issue seems to be that the camera position increment may have no effect if the increment is too small and gets rounded off when roundPx is true. Specifically: https://github.com/photonstorm/phaser/blob/v2.6.2/src/core/Camera.js#L624-L635 may be incrementing this.view.x by small values which always get rounded to the same integer during this.view.floor().
I'm not sure if this is "technically" a bug because maybe this is what should happen if roundPx is true, but it is definitely unexpected. Is there a reason that roundPx is true by default? And if roundPx is true, could we store the exact unrounded position in view and rather round this.displayObject.position? I'd be happy to take a stab at this if this sounds like a possible solution.

Thanks @kevinAlbs - you're right. Just adding: game.camera.roundPx = false; to the above example fixes it just fine. I'm happy with that as a solution really, the property is there to be changed on a case-by-case basis, and this is such a case.


Danger should de-duplicate identical messages/warns

I've been using Danger to lint Localization changes in our app with something like this...
modified_files.grep(/Localizable.strings$/).each do |file|
  message("Localization has changed. You may need to do a translation job.")
  fail("#{file} failed to lint with plutil") unless system("plutil -lint #{file}")
end

This ended up creating a message for each Localization file.
We should de-duplicate messages and warnings that are exactly the same, possibly adding a number to signify it happened more than once.
e.g. "Localization has changed. You may need to do a translation job. (4)"

I started agreeing, but I'm not 100% on it yet.
I think a better way to handle this is to consider the system thing something to filter out successful plist items. You could expose what files have changed here  e.g.
unlinted_plists = modified_files.grep(/Localizable.strings$/).reject { |file| system("plutil -lint #{file}") }
fail("#{unlinted_plists.join(", ")} failed to lint with plutil") if unlinted_plists.count > 0

In most de-dupe cases,  I think you're going to want to actually show some kind of value of what failed as the build is external to you - and usually hard to access.


Issues with B009 and B010 autofix

I found that running the autofix for B009 and B010 can break code in a very specific circumstance, specifically when it is applied to:

https://github.com/asdf-format/asdf/blob/ae9b77cdc8d69f1f1fd136ff48c9a523a86c18af/asdf/types.py#L85
https://github.com/asdf-format/asdf/blob/ae9b77cdc8d69f1f1fd136ff48c9a523a86c18af/asdf/types.py#L149

Will deeply break my code.
Based on this discussion thread: https://github.com/astropy/astropy/pull/14275#discussion_r1072555924, I think the issue is in how python handles __X access meaning this issue is likely limited to only cases where the attribute being set or gotten is of the form __X.
I think the solution might be to avoid making an autofix when the fixed string in question has the prefix __ but no suffix __.

Oh interesting! Will fix now.

Thank you for flagging this.

Ah right, ok, the double underscore causes name mangling.

Thanks for such a fast response!

Oh sorry @charliermarsh - didn't see you were already fixing! 😅

No prob! Thanks so much for hopping on it!


ECS: Missing link to task on container details panel

Leftover from #2026
Here's an example: In the Socks shop demo, the rabbitmq container links to its host and its container by image but not to its ECS task.

I'm looking through the report, but I don't understand what field causes that top link to appear?

for posterity: that top link is populated from the parents field of the returned node in detail view, which is a render.detailed.Node, NOT a report.Node, the conversion between the two for the parents field explicitly describes behaviour for each topology type, and didn't list ECS topologies, so they were ignored despite being in the report's parent field.


$sqlpsreg

incorrect value for registry key on Windows system hosting SQL Server 2019 instance ?
I had to change key name to
HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\PowerShell\1\ShellIds\Microsoft.SqlServer.Management.PowerShell.sqlps150

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca91cbd9-efe5-1de5-7da6-6137b0437a3d
Version Independent ID: 836f506c-0e26-8277-1a9f-451853e0d21b
Content: Load the SMO Assemblies in Windows PowerShell - SQL Server
Content Source: docs/powershell/load-the-smo-assemblies-in-windows-powershell.md
Product: sql
Technology: scripting
GitHub Login: @markingmyname
Microsoft Alias: maghan

@mco100,
Apologizes for the delayed response.
We are looking into this.

@mco100,
We do not recommend doing it that way.
The actual version after “.sqlps” is dependent on the version of SQL Server installed on the machine (150 is good for SQL2019, 140 is good for SQL2017, etc…)
Hope this helps.
Thank you.

We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion, and we will reopen the issue. To see what the community is wanting, please visit the UserVoice site.


SDX: URL entered in comments fields not displayed as expected (PFA)

Expected behaviour
On the image file the URL entered for comments must be displayed clearly
Actual behaviour
URLin the comments field is not displayed as expected. (Please find the attachment)
Steps to reproduce the behaviour

Enter all the mandatory information and
enter a lengthy URL into the comments filed
submit Survey

Additional information
Issue exits for all the eQ surveys
Browser
Operating System
Screenshot

https://github.com/ONSdigital/sdx-transform-cs/commit/7f7e5441d89173cd52cc5a23a22e391379561d3d was without a description of the fix so I've added it to https://github.com/ONSdigital/sdx-transform-cs/commit/611f4b28460d3c74495dda6cd9bdeaf48b8ed161

Fixed in release v1.2.0


Notification system on contactForm module

$this->context->controller->errors/success no working in module for notification.
I make notification like ps_emailsubscription module.

fix condition get $id_customer_thread

Thank you!


Allow strategist to call harvest

The harvest() method on vaultCore should also be able to be called by the strategist role. This a method that should not be able to cause the contract to lose current funds, and it something that occasionally needs to be called and does not need to go through the entire governance process.
Contract change checklist:

[ ] Code reviewed by 2 reviewers. See template and example.
[ ] Unit tests pass
[x] Slither tests pass with no warning
[x] Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Note sure why this test is failing (at least failing locally).

Note sure why this test is failing (at least failing locally).

Thanks @franckc for pointing out the two harvests! Updated so I'm now changing the permissions on both, and that fixed the failing test.

Thanks @franckc for pointing out the two harvests! Updated so I'm now changing the permissions on both, and that fixed the failing test.


WIX: enable Developer Mode with SwiftPM

SwiftPM requires Developer Mode to function properly. Instead of asking users to enable it manually, we can enable it through the installer.

This change is

A brief explanation on what SwiftPM uses this for: SwiftPM needs Developer Mode to create symbolic links with the SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE flag (see CreateSymbolicLinkW), or it will throw an error on every successful build.

It’s really confusing though. May you check the key HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\AppModelUnlock\AllowDevelopmentWithoutDevLicense on your machine? If the value is 1, there should be other application that already enables it.

>reg query HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\AppModelUnlock\AllowDevelopmentWithoutDevLicense
ERROR: The system was unable to find the specified registry key or value.

It is not confusing at all, it is well documented at https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-createsymboliclinkw

According to the document and the implementation of swift-corelibs-foundation and swift-package-manager, there should always be a SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE flag passed to CreateSymbolicLinkW. If Developer Mode isn’t enabled, there should be error thrown. Did I miss any point?

SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE does not mean that you can create the symbolic link without the privilege.  It means that the process does not need to be running in an elevated context.  You still need SE_ALLOW_CREATE_SYMBOLIC_LINK_PRIVILEGE.  Enabling Developer Mode will reduce the security on the system allowing untrusted code execution amongst other things.  One of the things it enables is effectively every process receiving that security permission, thus allowing the creation of symbolic links.
I've generally been very intentional about the Windows port.

Further verified: https://forums.swift.org/t/stochastic-errors-resolving-dependencies-and-or-building-with-feb-18-2021-snapshot
The developer mode is most definitely not the correct thing, and I don't think that is something that the installer should be doing by default.

In fact, I’ve already tried to alter user permission through WiX, and that seems impossible. There’s not even a way to grant that through the shell AFAIK.
Using Developer Mode is one of the solutions, and maybe the only one possible for an installer.

Another point is that there’s no secpol.msc on Windows 10 Home. Developer Mode  (by registry key), meanwhile, is available on all versions.

Application through a GPO should be possible to automate.  You should be able to create a C# Custom Action to apply the GPO.


refactor: refactor and switch to duende identity lib

:tada: This PR is included in version 2.2.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[alarm] On new alarm, time is reset on dow change

Affected hardware version
Bangle 2
Your firmware version
2v12.126
The bug
On creating a new alarm or changing a previously created one, a changed time (Hours and/or Minutes) is reset on opening the day of week selection menu.
I usually go through and set the configs from top to bottom, when doing so I often need to set the time twice.
I would suggest to either save the time on each change or move the day of week selection menu to the top.
Steps to reproduce:

Open New Alarm >
Change Hours   12 or Minutes   0
Open Days   SMTWTFS
Go back :red_circle:

-> Time values are reset to Hours   12 and Minutes   0

Bug found! I'll send a PR later.


Feature request

I request to add functionality of auto otp using some otp retriever app. Also auto captcha as slots in metro cities are running out very quick.

@hpk22
I did few improvements recently. There are two modes available now i.e Auto and Manual. In Auto mode everything is automated. Unlike other booking scripts/utilities, the user does not need to feed otp every now and then. You can go through the documentation about how it works.


Getting include paths to work in self-hosted version

Hi,
I'm trying to self-host CE, but I can't manage to make it recognize my custom include directories.
eg given

a file /tmp/tutu/foo.hpp
the following request:

{
  "options": {
     "userOptions": "  -I/tmp/tutu "
  },
  "source": "#include <foo.hpp>"
}

curl -H "Content-Type: application/json"  -X POST http://<IP_ADDRESS>:10240/api/compiler/%2Fusr%2Fbin%2Fg%2B%2B/compile -d '$MY_API_REQUEST'

I get a dreaded <source>:1:10: fatal error: foo.hpp: No such file or directory
I tried looking in the README but couldn't find any mention of include restriction... is this a supported use-case ?

found it: the argument name should be userArguments, not userOptions as said in the readme

Thanks for the bug: we'll update the readme!