Regualtion term for GO:0060378

Hello,
Would it be possible to add a positive and negative regulation to GO:0060378:regulation of brood size for the PMID:19575016?
Thank you
Rossana

Hi Rossana,
I was wondering what other annotations you might be making for this paper, especially with respect to apoptotic process.
It seems that measuring brood size is a way for the authors to assess the role of CSP-2 in germ cell apoptosis.
Based on the additional biochemical experiments in the paper, do you think an annotation of CSP-2 to:
GO:2001271 (negative regulation of cysteine-type endopeptidase activity involved in execution phase of apoptosis) with annotation extensions of
occurs_in(WBbt:0006796),directly_negatively_regulates(UniProtKB:P42573)
where
WBbt:0006796 = germ cell
UniProtKB:P42573 = CED-3
would be sufficient for capturing the biological process studied in the paper?
Thanks,
--Kimberly

Hi Kimberly,
Thank you very much for your comments.
I was going to capture this biological finding by using
GO:1990001:inhibition of cysteine-type endopeptidase activity involved
in apoptotic process.
However, I would like also to capture the brood size phenotype that is
shown in table 1.  In this table, they also  report that the double
mutant of ced-9 and csp-2 is sterile which I am capturing with
GO:1905516:positive regulation of fertilization. I think annotating both
phenotypes would provide extra information.
I hope it makes sense.
Thank you
Rossana
On 15/12/2016 14:32, vanaukenk wrote:

Hi Rossana,
I was wondering what other annotations you might be making for this
paper, especially with respect to apoptotic process.
It seems that measuring brood size is a way for the authors to assess
the role of CSP-2 in germ cell apoptosis.
Based on the additional biochemical experiments in the paper, do you
think an annotation of CSP-2 to:
GO:2001271 (negative regulation of cysteine-type endopeptidase
activity involved in execution phase of apoptosis) with annotation
extensions of
occurs_in(WBbt:0006796),directly_negatively_regulates(UniProtKB:P42573)
where
WBbt:0006796 = germ cell
UniProtKB:P42573 = CED-3
would be sufficient for capturing the biological process studied in
the paper?
Thanks,
--Kimberly
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/geneontology/go-ontology/issues/12869#issuecomment-267341429,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVNSF8Tdlb0kUToj0Yl81D7LyI-DZ7Scks5rIU-VgaJpZM4LN7qf.

Hi Rossana,
Yes, I think that GO:1990001:inhibition of cysteine-type endopeptidase activity involved in apoptotic process would also be fine to use.
Wrt the brood size annotations, I guess I would just try to capture the underlying process rather than the phenotype.  Along those same lines, do you think that ced-9 and csp-2 play a role in the actual process of fertilization or is the sterility of the double mutant actually the combined effect of reducing activity of two negative regulators of germ line apoptosis?
Thanks,
--Kimberly

Is creation of the two new requested terms still warranted?

Hi,
In the use cases for these terms, annotating to the positive and negative regulation terms, rather than the regulation parent term (GO:0060378), makes the most sense since measurement of brood size would necessarily inform the directionality of the effect.
However, wherever possible, I would encourage curators to annotate to a more informative BP term that illustrates how the reduced brood size phenotype comes about.

+1  to @vanaukenk
We want to encourage capturing the mechanism of the regulatory process as much as possible. This is essential to be able to 'declare' something regulatory in LEGO.

Added:
[Term]
+id: GO:0090727
+name: positive regulation of brood size
+namespace: biological_process
+def: "Any process that increases brood size. Brood size is the number of progeny that survive embryogenesis and are cared for at one time." [GOC:rz]
+is_a: GO:0060378 ! regulation of brood size
+created_by: tanyaberardini
+creation_date: 2016-12-19T15:07:32Z
+
+[Term]
+id: GO:0090728
+name: negative regulation of brood size
+namespace: biological_process
+def: "Any process that decreases brood size. Brood size is the number of progeny that survive embryogenesis and are cared for at one time." [GOC:rz]
+is_a: GO:0060378 ! regulation of brood size
+created_by: tanyaberardini
+creation_date: 2016-12-19T15:07:32Z


Avoid MissingPluginException in iOS

Register always to avoid MissingPluginException in iOS

http://blog.z7ge.com/archives/flutter-missingpluginexception-bu-yao-huang 希望能帮到你


Corrected a copy/paste typo

I found what looked to be a copy/paste typo from the X12 documentation section. The functional ACK name in EDIFACT was given incorrectly as a 997 which is for X12. I entered the correct name for the functional ACK in EDIFACT.
Thanks, Ben

@clineer : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@divyaswarnkar, please review this contribution and sign off if you approve? Thanks!

#sign-off . Thanks for making these updates.


Improve the ENet channels documentation in NetworkedMultiplayerENet

This closes https://github.com/godotengine/godot-docs/issues/3598.

Cherry-picked for 3.2.3.


Updating CAN Frames and Adding Tests

Description

Updates some old CAN Frames and adds new ones. Tests implemented for each.

commits and changes messed up, replacing with new PR


Optimize kubeanoperation spec.image tag

What type of PR is this?

/kind bug
What this PR does / why we need it:

automatically set the spray-job image version , fix #363

Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

/lgtm


⚠ Bofrost.be has degraded performance

In aeb9632, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2054 ms

Resolved: Bofrost.be performance has improved in 76dbd98 after 6 minutes.


fix(device): fixed detect method of supporting Touch Event

BUG: In baidubox, some iOS, userAgent is ‘Mozilla/5.0 (iPhone; CPU iPhone OS 11_1_2 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) BaiduBoxApp/10.0.0 iPhone; CPU iPhone OS 11_1_2 like Mac OS X Mobile/15B202 Safari/602.1 baiduboxapp/<IP_ADDRESS> (Baidu; P2 11.1.2)’
FIX: Refer from modernizr library detect method https://github.com/Modernizr/Modernizr/blob/master/feature-detects/touchevents.js#L40

Coverage decreased (-0.003%) to 98.084% when pulling 75c401e3383529081a18573921e4348b81145763 on zhangbobell:master into c4f41bd05953ec11ac0acec1efb418173b855fcf on fex-team:master.


[SPARK-10845] [SQL] Makes spark.sql.hive.version a SQLConfEntry

When refactoring SQL options from plain strings to the strongly typed SQLConfEntry, spark.sql.hive.version wasn't migrated, and doesn't show up in the result of SET -v, as SET -v only shows public SQLConfEntry instances. This affects compatibility with Simba ODBC driver.
This PR migrates this SQL option as a SQLConfEntry to fix this issue.

Merged build triggered.

Merged build started.

Test build #43052 has started for   PR 8925 at commit f90be1a.

LGTM

Thanks for the review. Merging to master.

Test build #43052 has finished for   PR 8925 at commit f90be1a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43052/
Test PASSed.

I backported this into branch-1.5.


Empty service should implement Service.Run

Signed-off-by: Josh Curl<EMAIL_ADDRESS>

Hum.. I missed that one :sweat: Thanks !
LGTM 🐯


Test binding collision on label instead of raw attributes

Fixes collision matching for mapping discrepancies where binding types differ but values are the same (eg. trigger axis and trigger button should collide)

Thank you. We'll need to be careful in the future not to create colliding labels for bindings.

yeah I was a little fuzzy on this.. might want to validate labels as unique on boot


Build codegen for all crossbuilds

The codegen project is not detecting mimaPreviousArtifacts the way anything else is.  If we cross build it like everything else, it appears to work.  And there's really no reason that we can't, even if it is primarily used in today in the SBT plugin.

Eh, guess there is a reason.

Nah.


Idea for exercise (CNN on MNIST data: handwriting digit classification)

I can give this one a try, as I had done this as a practice before. But, if you could give me some time then I can do this by the end of this week.

@aarpit1010 Excellent ! Thanks for volunteering. Of course, take your time. The whole point of open source contribution is to do so when you have time and enjoy doing so. Be sure to check out the updated contributing guidelines. I wrote down more details on the format which should be helpful.


iam policy management

Description
Adding function to delete IAM policies
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[x] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

cloudinfo.DeleteIamPolicyByID added

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 1.27.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Versioned installation paths

Currently the VSCode Dafny IDE extension installs a specific version of Dafny.  To use a different version, users have to install Dafny manually and point the extension to that.  It would be nice to make this easier.
I've recently implemented auto-installation for Dafny in Emacs (I'm porting the Emacs mode to use LSP), and in that code I used the following design:

There is a user setting to specify which version of Dafny to use.  The plugin has a hardcoded list of known versions that it is compatible with, and the value of that setting must be one of these.  It defaults to the highest known version.
The Dafny binary that the IDE uses is either the one the user specified manually, if any, or the one corresponding to the "version" user setting above.
If the binary corresponding to the selected version is not installed, the IDE downloads that version of Dafny and saves it to a version-dependent path, which makes it easy to check whether a given version of Dafny is installed.

I experimented with this in Emacs first since changing the VSCode extension wasn't trivial (given that we already had many live installs).  But since we are in fact publishing a new Dafny extension under dafny-lang, it might be worth making a similar change to the Dafny VSCode extension, to make it easy for users to switch versions (just change the version and restart the server or IDE).
If we decide to do this, it would be best to do it soon; this way we wouldn't have to worry about backwards compatibility, since we're publishing a new plugin.

Providing this feature should be straightforward and probably only dafnyInstallation.ts (besides the settings).
I see that there is a demand to support multiple Dafny versions from within the language server. In the future, Dafny will support project files making this functionality a bit obsolete. However, the implementation should be no big deal and it still allows configuring the default Dafny version. Moreover, depending on when Dafny project files will arrive, it could be a nice feature in combination with VSCode's workspace specific settings in the meantime.

In the future, Dafny will support project files making this functionality a bit obsolete.

I think most of the code to solve this issue would become part of the project implementation, wouldn't it?

I think so. But I believe it might still be useful besides the project feature since it allows people to configure their default Dafny version.


mod_ssi: enhance support for ssi vars

Try ssi_vars if ssi_cgi_env does not have a matching var name.
Allow var names to also include digits after the initial letter or underscore.

Thanks! Merged in d8e028e06900b781bebfe2f52cc7254444a31716


⚠ ClamAV has degraded performance

In 025909d, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in 86d23d7.


Sprinkles-like API

Using VE directly allows usage of Sprinkles which dramatically reduces friction of usage, is this planned or possible to use with macaron?

What are the main use cases that you see of sprinkles that macaron doesn't provide right now?

Ease of use, sprinkles doesn't use normal CSS properties, it's more like tailwind. You're intended to create many sprinkles and mix them together for "Atomic CSS"

I actually came to the Macaron GitHub issues today to request a feature similar to Sprinkles and found this ticket! Timely!
I actually didn't know what Sprinkles was but I wanted something like it. I'm basically looking for a CSS-in-JS level of ergonomics but with extracted, atomic CSS like Tailwind offers. I like the extracted, atomic CSS because it deduplicates any CSS properties you used and creates super tiny CSS files. Making it unnecessary to worry about things like "above the fold CSS" vs the rest of the CSS.
I was hoping Stitches would get there eventually (at least with extracted CSS) but Stitches seems to be slowing down right now and rumors have started that it's considered "feature complete". So I've come to Macaron in hopes to find what I'm looking for!

I'm not sure if I'm comfortable with expanding the scope of macaron's core lib to include atomic css, though it should be very easy to use sprinkles with macaron's compiler to get colocated styles. With this setup you can define the sprinkles in any file, and not be restricted to .css.ts files, and this would work with macaron's build plugin.
Just install @vanilla-extract/sprinkles and then when calling functions like defineProperties or createSprinkles wrap them inside macaron$ exported from @macaron-css/core like:-
import { macaron$ } from "@macaron-css/core"
import {
  defineProperties,
  createSprinkles
} from '@vanilla-extract/sprinkles';

const responsiveProperties = macaron$(() => defineProperties({
  conditions: {},
  // etc..
}))

export const sprinkles = macaron$(() => createSprinkles(
  responsiveProperties,
));

After this you can use these like you normally would use sprinkles. Macaron will extract all the css of sprinkles styles


AdminJS is not defined in .entry.js

When running adminjs with a custom component the auto-generated .entry.js errors out and doesn't render the custom react component.

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
.entry.js:3 Uncaught ReferenceError: adminjs is not defined
    at .entry.js:3

I also get this warning in the console from my backend app:
P.S. I've noticed you guys use @rollup/plugin-replace in this bundler file adminjs/src/backend/bundler/config.js
@rollup/plugin-replace: 'preventAssignment' currently defaults to false. It is recommended to set this option to `true`, as the next major version will default this option to `true`.
No name was provided for external module 'adminjs' in output.globals – guessing 'adminjs'

This is how I am loading the component in the config object
dashboard: {
      handler: async () => {
        return { some: 'output' }
      },
      component: AdminJS.bundle('./my-dashboard-component'),
    },

Yes, I m also having similar trouble while trying to import and use adminjs in a custom component.

This is fixed in 5.0.1


Documentation edits on location-based AR

⚠ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠
What kind of change does this PR introduce?

Fix typos and grammatical errors.
Update links.

Can it be referenced to an Issue? If so what is the issue # ?
No.
How can we test it?

No testing required.
Summary

Does this PR introduce a breaking change?
No.
Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser
Other information

all good, thank you so much! merging


Eric's "[Docs] Use relative links to documents in the README" Breaks PyPi links

Commit 75ede485c9d25c6f458de4e98cfbccce20f0f6a3 breaks PyPi links for obvious reasons.
My suggestion is to revert.

Sorry about that; it honestly never crossed my mind to check the effects on the PyPi page because I rarely ever read them for any project, instead just going right to the GitHub page (or wherever the code is hosted).  It would be nice if we had a separate README for PyPi, but I don't think it's worth the effort just for the sake of working, relative links on GitHub which don't suddenly switch branches on the user.  So :+1: from me on reverting the commit.  I don't mind reverting it myself if you want, but I'd prefer to leave that to you, simply because I think it's more "appropriate" for you to revert the erroneous commit.

How do you recommend removing, or "reverting" a commit?
On Thu, Nov 12, 2015 at 8:31 PM, Eric James Michael Ritz <
<EMAIL_ADDRESS>wrote:

Sorry about that; it honestly never crossed my mind to check the effects
on the PyPi page because I rarely ever read them for any project, instead
just going right to the GitHub page (or wherever the code is hosted). It
would be nice if we had a separate README for PyPi, but I don't think it's
worth the effort just for the sake of working, relative links on GitHub
which don't suddenly switch branches on the user. So [image: :+1:] from
me on reverting the commit. I don't mind reverting it myself if you want,
but I'd prefer to leave that to you, simply because I think it's more
"appropriate" for you to revert the erroneous commit.
—
Reply to this email directly or view it on GitHub
https://github.com/hypatia-engine/hypatia/issues/124#issuecomment-156302741
.

How do you recommend removing, or "reverting" a commit?

For something that's already in a branch that we cannot rebase, e.g. master and develop, I suggest this:
$ git revert --edit -s <hash of the commit>

This will create a commit that reverses the changes of the given commit, also signing-off on it (-s) and giving you a chance to add any information (--edit) about the reason for the reversion.  In this case, for example, you could link to this discussion with a simple GitHub-Issue: #124 so that people in the future could see why the revert was necessary.


PDF download

Hello,
the old documentation on readthedocs offered the option to download the entire documentation as PDF or even epub.
Would be great to have this option again or to at least display all content on a single page such that it can be printed as pdf.

Hello @danimoh, thank you for your suggestion. I will look into it and get back to you.

Hello @danimoh, thank you for your patience. This feature can not be implemented at the moment, but we will keep this in mind for a next version.


fix: disable pretty print in production

This disables pretty printing in production. This is because the pretty
print functionality requires a pino-pretty package to be installed and
that is currently only a dev dependency.

Looks good!


no-extraneous-dependencies causes errors for not imported @types/*

Hello I'am facing a similar issue reported here and there @ljharb asked to open another issue if it is still happening on version 2.23.4.
My scenario is:
node: v12.22.1
import { difference } from 'ramda';
import { v4 as uuid } from 'uuid';

causes:
  error  '@types/uuid' should be listed in the project's dependencies, not devDependencies  import/no-extraneous-dependencies
  error  '@types/ramda' should be listed in the project's dependencies, not devDependencies  import/no-extraneous-dependencies

package.json
"eslint": "^7.31.0",
"eslint-plugin-import": "2.23.4",

config:
"import/no-extraneous-dependencies": [
            "error",
            {
                "devDependencies": ["**/*.d.ts", "**/*.test.*", "**/*.spec.*", "test-utils/**/*"]
            }
        ]

Am I doing something wrong?

Can you provide a reproduction?

I'm seeing this problem as well. My config is simlar, and my versions are below:

eslint-plugin-import:  2.27.5
eslint-plugin-import-resolver-typescript : 2.23.5
typescript: 5.0.4
typescript-eslint/parser: 5.48.0

I have the same problem with packages from @types/*, e.g. @types/react.
import { useEffect, useState } from "react";

'@types/react' should be listed in the project's dependencies, not devDependencies.eslintimport/no-extraneous-dependencies

It seems that getModuleRealName() causes the issue of intepreting any import of react as @types/react.
https://github.com/import-js/eslint-plugin-import/blob/6b95a021938139726b3f862beb37012d6e2afab2/src/rules/no-extraneous-dependencies.js#L213C27-L213C44

I think https://github.com/import-js/eslint-import-resolver-typescript/issues/265 may be the cause of this

Duplicate of https://github.com/import-js/eslint-import-resolver-typescript/issues/265

Please follow the README more carefully:
https://github.com/import-js/eslint-plugin-import#typescript
See also https://github.com/import-js/eslint-plugin-import/blob/7a21f7e10f18c04473faadca94928af6b8e28009/config/typescript.js#L17

More generally, please use the config/typescript config from this plugin, which sets that.


GOOS when provided otherwise default to LOCAL_OS

Previously it was not possible to download envoy binary
if you were on darwin, this change allows us to
specify envoy binary platform via GOOS

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: costinm
Assign the PR to them by writing /assign @costinm in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

bin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @Nino-K. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

@Nino-K: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
410f315fe5ef8b309e32ddc3c0cdc10e01b71c36
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

/assign @costinm

@Nino-K: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
410f315fe5ef8b309e32ddc3c0cdc10e01b71c36
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
410f315fe5ef8b309e32ddc3c0cdc10e01b71c36
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
410f315fe5ef8b309e32ddc3c0cdc10e01b71c36
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-bookInfoTests-v1alpha3.sh
410f315fe5ef8b309e32ddc3c0cdc10e01b71c36
link
/test e2e-bookInfo-envoyv2-v1alpha3

prow/istio-unit-tests.sh
410f315fe5ef8b309e32ddc3c0cdc10e01b71c36
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
410f315fe5ef8b309e32ddc3c0cdc10e01b71c36
link
/test istio-pilot-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
410f315fe5ef8b309e32ddc3c0cdc10e01b71c36
link
/test istio-unit-tests

prow/istio-pilot-e2e.sh
410f315fe5ef8b309e32ddc3c0cdc10e01b71c36
link
/test istio-pilot-e2e

prow/e2e-bookInfoTests-v1alpha3.sh
410f315fe5ef8b309e32ddc3c0cdc10e01b71c36
link
/test e2e-bookInfo-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Nino-K: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Black formats pyenv builtin library files outside of project folder

Apologies in advance if I am missing something obvious, but I am not sure how I managed to do this.
I used black . from my project directory, thinking it would format my project files, instead, I accidentally formatted my entire pyenv venv builtin library 😂
~/dev/kit
(venv) ❯❯❯ which black
/Users/gtalarico/dev/kit/venv/bin/black
~/dev/kit
(venv) ❯❯❯ black .
reformatted /Users/gtalarico/.pyenv/versions/3.7.0/lib/python3.7/_bootlocale.py
reformatted /Users/gtalarico/.pyenv/versions/3.7.0/lib/python3.7/__future__.py
reformatted /Users/gtalarico/.pyenv/versions/3.7.0/lib/python3.7/_dummy_thread.py
reformatted /Users/gtalarico/.pyenv/versions/3.7.0/lib/python3.7/abc.py
reformatted /Users/gtalarico/.pyenv/versions/3.7.0/lib/python3.7/bisect.py
reformatted /Users/gtalarico/.pyenv/versions/3.7.0/lib/python3.7/_weakrefset.py
reformatted /Users/gtalarico/.pyenv/versions/3.7.0/lib/python3.7/base64.py
... (my entire venv builtin lib)

Operating system: MacOs
Python version: 3.7.0
Black version: 18.9b0
Relevent Environment Variables:
PATH=/Users/gtalarico/dev/kit/venv/bin:/usr/local/opt/openssl/bin:/usr/local/opt/openssl/bin/:/Users/gtalarico/.pyenv/shims:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
PIPENV_DEFAULT_PYTHON_VERSION=3.7
PWD=/Users/gtalarico/dev/kit
PYENV_SHELL=fish
PYENV_VERSION=3.7.0
PYTHONSTARTUP=/Users/gtalarico/.pythonrc
SHELL=/usr/local/bin/fish
VIRTUAL_ENV=/Users/gtalarico/dev/kit/venv
VIRTUAL_ENV_DISABLE_PROMPT=1

Clearly we need to make sure virtualenv itself is blackened ;)

Looks like there's a symlink in ~/dev/kit/venv that points to the actual virtualenv, which is why black formats it. You can exclude it with command line flags

Awesome, thanks Zsol.
Seems obvious now.... it just followed the symlinks inside venv...
I usually use virtualenvwrapper so I am not used to having the virtualenv inside my project folders.
black . --exclude venv/  works as expected


Link to "uncaught exception recommendations" document on non-nodejs worker uncaught exceptions.

If user code throws an exception outside of the scope of function execution, it results in an uncaught exception.
Example:
module.exports = function(context, req) {
  context.log("start", context.invocationId);
  setTimeout(function() {
    var wrong = missing.var;
    context.log(wrong);
  }, 3000);
  context.log("ending!", context.invocationId);
  context.done();
}

Results in:
[error] Worker ##### uncaught exception:  ReferenceError: missing is not defined.
The root cause is usually confusion with async code. Although these errors should be minimized with: https://github.com/Azure/azure-functions-nodejs-worker/commit/e97f785607f06c5474d1a6dcaf576529eaca69db, it's worth considering if we want to make it a fatal exception as it is currently (where we filter for exceptions that come from the language worker and treat all else as user code and not fatal).
cc: @pragnagopa

Per discussion with @fabiocav, it's dangerous and bad practice to not exit the node process on uncaught exception (node docs). Instead, we should link to documentation that gives examples of common coding patterns / mistakes that would lead to this (async work not being scoped properly).

@mhoeger
I'm not sure if this is the right place to ask, but I'm hosting a nodejs/express app on azure which exits in spite of an "on uncaughtException" handler.

node 10.15.2. 64 bit (I did the "languageWorkers:node:defaultExecutablePath" "trick" as well as add the path to the 64 bit node version to iisnode.yml)
gemlin javascript 3.4.0
express 4.16.4

Problem:

nodejs gets killed in spite of "on uncaughtException" handler
the reason is an exception in an async callback. The "open" function of a connection in  "gremlin/lib/driver/connection.js" installs an error handler which throws an ECONNRESET (caused by TLSWrap.onread) . The error handler in this "open" function is installed like this:  this._ws.on('error', (err) => this._handleError(err)). Since it happens asynchronously in the library (without any error callback or rejection), it's uncaught and I can't do anything about it. (I could uninstall all error listeners of the web-socket but that's probably bad.) I've also tried to add an error handler to the websocket (._connection._connection._ws). It didn't help either.
Therefore I've implemented an "on uncaughtException" listener.

I've implemented the "on uncaughtException" listener for various reasons:

My app is doing some scaffolding during startup, so it takes ~ 30 seconds to restart.
I'm the one who needs to decide if the process should be killed, not iisnode. If the error is well known and I know that the app doesn't get instable, it should continue running.
For debugging/testing purposes I want to see/log all uncaught errors and not automatically restart the app.

The "on uncaughtException" handler works fine in our dev and test environments but it does not get fired on azure.
So I'd kindly ask if I'm doing something wrong or if it is true that iisnode kills node.exe in case of an uncaught error. And if it does, how does it know about it in spite of the "on uncaughtException" handler.
Any ideas are much appreciated, thanks a lot
Tom

@thomas-mindruptive - apologies about the delayedresponse! just to clarify - is this an nodejs/express app that is running on azure app service or azure functions?

@mhoeger - No prob, it's a nodejs/express app on azure app service.
Best


enhance: ask user for OpenAI key and store it in the cred store

I made some pretty substantial changes to this PR:

We now use SysPrompt to ask the user (which means I had to move it to its own package in order to avoid an import cycle)
We only prompt the user for the token when it is actually needed

This involved creating a custom error type and checking for it in a couple places, which is a bit gross but is the cleanest solution I could come up with for this

We will need to make sure this works with @tylerslaton's UI, once he has prompting support


Handle Set method (like flag.Value).

This allows values with the necessary methods for custom flag parsing to
work out-of-the-box with envconfig. To retain reasonable backwards
compatibility, Decoder takes precedence over Setter.

@extemporalgenome thanks for this! Brilliant, making the interface a subset of flag.Value. Wish I had done it that way the first time, so backwards compatibility wouldn't be an issue.
Just one little tweak in the code (commented inline) and then it'd be great to have a note about this in the README.

@extemporalgenome this is merged, thank you!


tikv-server: allow set timeout and hearbeat ticks

So we can change ticks without recompilation.
@siddontang @hhkbp2 PTAL

LGTM

@siddontang PTAL

Rest LGTM


Getting #75 to green

I found that without merging master into this branch was causing many errors and that we needed to add rdoc as a development dependency to even run with 1.8.7.
After upgrading rspec and mocha as well, I only have a single failure with 1.8.7 -- all green on 1.9.2-p320 and 1.9.3-p545.
Ruby 1.8.7-p374
Failures:

  1) Gmail client (Plain) instance should deliver inline composed email
     Failure/Error: client.deliver do
       expected: true value
            got: false
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-expectations-2.14.5/lib/rspec/expectations/fail_with.rb:32:in `fail_with'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-expectations-2.14.5/lib/rspec/expectations/handler.rb:36:in `handle_matcher'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-expectations-2.14.5/lib/rspec/expectations/syntax.rb:53:in `should'
     # ./spec/client_spec.rb:104
     # ./spec/client_spec.rb:25:in `mock_client'
     # ./spec/client_spec.rb:103
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/example.rb:114:in `instance_eval'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/example.rb:114:in `run'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/example.rb:254:in `with_around_each_hooks'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/example.rb:111:in `run'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/example_group.rb:390:in `run_examples'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/example_group.rb:386:in `map'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/example_group.rb:386:in `run_examples'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/example_group.rb:371:in `run'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/example_group.rb:372:in `run'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/example_group.rb:372:in `map'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/example_group.rb:372:in `run'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/command_line.rb:28:in `run'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/command_line.rb:28:in `map'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/command_line.rb:28:in `run'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/reporter.rb:58:in `report'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/command_line.rb:25:in `run'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/runner.rb:80:in `run'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/gems/rspec-core-2.14.8/lib/rspec/core/runner.rb:17:in `autorun'
     # /Users/alex/.rvm/gems/ruby-1.8.7-p374/bin/rspec:23

Finished in 25.97 seconds
43 examples, 1 failure, 12 pending

Failed examples:

rspec ./spec/client_spec.rb:102 # Gmail client (Plain) instance should deliver inline composed email
/Users/alex/.rvm/rubies/ruby-1.8.7-p374/bin/ruby -S rspec ./spec/client_spec.rb ./spec/gmail_spec.rb ./spec/mailbox_spec.rb ./spec/message_spec.rb failed

This issue was moved to gmailgem/gmail#107

This PR was moved to gmailgem/gmail#137


Default to current user for pd schedule override?

I'm wondering if it would make sense to default to your own user for scheduling overrides? That's my most common use case to schedule a short override if I'm doing some work that might trigger an alarm:
pd schedule override add --end="in 15 minutes" --id="123ABCD" -u "ABCD123"

would become:
pd schedule override add --end="in 15 minutes" --id="123ABCD"

But I could still specify it if I was to schedule an override for some other user.

I do think that makes sense in general, I am somewhat worried about accidentally putting in an override that you didn't intend... what do you think about a -m/--me flag just to make it clear what you're doing?

Yep that would work for sure!

Basically I've been hoping for this hubot functionality in the PD slack app for years: https://github.com/hubot-scripts/hubot-pager-me
But CLI will work great too!

hey so I just put --me in 0.1.15 RC, and i am planning to promote that to stable next week barring any uncaught bugs... that should resolve both your issues... i will check out the hubot stuff, thanks for the link...

Hi @mwarkentin i just promoted 0.1.15 to stable, which should resolve this for you... can you check it out and let me know?

@martindstone thanks, just caught up on my GH notifications so didn't see this until now.
Works perfectly, thanks!
❯ pd schedule override add --end="in 1 minutes" --id="ABCDE12" --me
Adding an override to schedule ABCDE12... done


Change UI component theme to match ncsu red&white theme

Added the red and white theme with some wolf tweaks


Timeout error in IOSXE if prompt contains parenthesis

Trying to connect a cisco ios device withouth privileged level, depending device prompt, I get timeout error:
8HE2>

Works ok

27N2(2960_PoE)>

Get timeout error.

Code used:
oneeq =  {
            'host': 'ip',
            'auth_username': 'user',
            'auth_password': 'pass',
            'default_desired_privilege_level': 'exec',
            "auth_strict_key": False,
            "transport": "asyncssh",
            "driver": AsyncIOSXEDriver
        }
...
async def _fetch_data(self,device):
        driver = device.pop("driver")
        async with driver(**device) as conn:
            responses = await conn.send_commands(["show version", ])
            return responses
...

But It works if I define my own PrivilegeLevel with pattern including "(" and ")" :
...
'default_desired_privilege_level': 'miexec',
'privilege_levels': {
    'miexec': (
        PrivilegeLevel(
            pattern=r"^[\w.\-@/:()]{1,63}>$",
            name="miexec",
            previous_priv="",
            deescalate="",
            escalate="",
            escalate_auth=False,
            escalate_prompt="",
        )
    ),
},
...

(please sorry my english and really thanks for your work)

👋 hey there, thanks for raising this!
do you know what platforms the ( and ) are supported in the hostname on?
Id have to go look more but I worry that a pattern like that may overlap w/ config modes of varying flavors (like somehost(config) and some host(tacacs+config) (or something like that)).
basically all of these would need to not be compromised and id want to know which platform(s) this hostname stuff is allowed in before changing anything.
so, worst case this is a "not broke wont fix" and you can handle it like you already have done, but if it seems like this is something we should support (due to it being broadly supported in iosxe devices) we can look at updating the core pattern(s).

ah update. this works on my old 3560cx but it complains about illegal characters... so if thats the same for most places id say "not broke wont fix" and you can support it yourself. but still open to having my mind changed there :)
C3560CX#conf t
Enter configuration commands, one per line.  End with CNTL/Z.
C3560CX(config)#hostname a(foo)
% Hostname contains one or more illegal characters.

a(foo)(config)#

Thought this was interesting because I was doing some work with a client that uses parentheses in some of their hostnames and so I wrote my own. Something like this would pass your tests:
PRIVS = {
    "exec": (
        PrivilegeLevel(
            pattern=r"^[\w.\-@/:()]{1,63}>$",
            name="exec",
            previous_priv="",
            deescalate="",
            escalate="",
            escalate_auth=False,
            escalate_prompt="",
        )
    ),
    "privilege_exec": (
        PrivilegeLevel(
            pattern=r"^[\w.\-@/:()]{1,63}#$",
            name="privilege_exec",
            previous_priv="exec",
            deescalate="disable",
            escalate="enable",
            escalate_auth=True,
            escalate_prompt=r"^(?:enable\s){0,1}password:\s?$",
            not_contains=["(conf", "(ipsec", "tcl)"],
        )
    ),
    "configuration": (
        PrivilegeLevel(
            pattern=r"^[\w.\-@/:()]{1,63}(?=(\((?:conf|ipse)[\w.\-@/:+]{0,28}\)#))",
            name="configuration",
            previous_priv="privilege_exec",
            deescalate="end",
            escalate="configure terminal",
            escalate_auth=False,
            escalate_prompt="",
            not_contains=["tcl)"],
        )
    ),
    "tclsh": (
        PrivilegeLevel(
            pattern=r"^([\w.\-@/+>:()]+\(tcl\)[>#]|\+>)$",
            name="tclsh",
            previous_priv="privilege_exec",
            deescalate="tclquit",
            escalate="tclsh",
            escalate_auth=False,
            escalate_prompt="",
        )
    ),
}

Tested on the following (a bit redundant, but you get the idea):
@pytest.mark.parametrize(
    "priv_pattern",
    [
        ("exec", "csr1000v>"),
        ("exec", "csr1000v(lab)>"),
        ("privilege_exec", "csr1000v#"),
        ("privilege_exec", "csr1000v(lab)#"),
        ("privilege_exec", "csr_1000v#"),
        ("privilege_exec", "csr_1000v(lab)#"),
        ("configuration", "csr1000v(config)#"),
        ("configuration", "csr1000v(lab)(config)#"),
        ("configuration", "csr1000v(conf-ssh-pubkey-data)#"),
        ("configuration", "csr1000v(lab)(conf-ssh-pubkey-data)#"),
        ("configuration", "csr1000v(conf-isa-prof)#"),
        ("configuration", "csr1000v(lab)(conf-isa-prof)#"),
        ("configuration", "csr1000v(config-sg-tacacs+)#"),
        ("configuration", "csr1000v(lab)(config-sg-tacacs+)#"),
        ("configuration", "819HGW(ipsec-profile)#"),
        ("configuration", "819HGW(lab)(ipsec-profile)#"),
        ("tclsh", "819HGW(tcl)#"),
        ("tclsh", "819HGW(lab)(tcl)#"),
        ("tclsh", "+>"),
        ("tclsh", "+>(tcl)#"),
    ],
    ```
Not saying you should consider including it, but there are cases where it's useful (i.e., when you don't have full control over the environment or you're performing discovery).

Thank you for the great library.

@mickyhale boom, I love it! glad to see that not contains gettin some use! will take a closer peak this weekend. Regardless of if we add this or not, really, really appreciate ya sharing this as it will now be searchable and available for everyone!

sorry for the delay here. I think for now I'm going to close this as @mickyhale solution is perfect and doesn't require any changes to scrapli. @mickyhale if you are keen to it -- we could maybe add a cisco_iosxe+ platform to scrapli community with your priv levels so its even easier for folks to consume -- but no pressure there, just if you're feeling feisty :D


push_notifications: Replace PyAPNs2 with aioapns

PyAPNs2 is keeping us stuck on old unmaintained versions of various requirements (Pr0Ger/PyAPNs2#122, Pr0Ger/PyAPNs2#126; see #18400 for an analysis of the fallout), so this is an experiment to see if we like aioapns better. This doesn’t actually use aioapns in an asynchronous way; that would come later.
Testing plan: Tested on staging with Tim.

Not having seen any reports of further issues on staging, I'm merging this, thanks @andersk!
@alexmv FYI.


[Suggestion]: azuremonitor setup script still uses azureRM not AZ

Which Hack?
007-AzureMonitoring
Suggestion
[Suggestion]: azuremonitor setup script still uses azureRM not AZ
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Closing this issue as it will be addressed in the upcoming Azure Monitoring hack refresh.


JS urls without ".js" a the end of the path are saved as "index"

{
  ...
  "dependencies": {
    "example": "https://example.com/path/to/js?with-options=in-url"
  }
}

results in:
.
└── example
    └── index

1 directory, 1 file

rather than:
.
└── example
    └── index.js

1 directory, 1 file

Ah this would be fixed by: https://github.com/bower/bower/issues/561#issuecomment-46561041
I could set:
{
  ...
  "dependencies": {
    "example/index.js": "https://example.com/path/to/js?with-options=in-url"
  }
}

wip

@rajzshkr ?

This issue can be achieved by using pluggable resolvers. But Adam ( @sheerun ) is still accepting a PR for this. So I wil be fixing it shortly.

@rajzshkr ah thanks, that would be super

I'm even getting something similar with urls ending in .js, if I remove /blob/master/jquery.elastic.source.js I get a file called index with the html contents and if I add it on I get a files called index.js with the same contents. It never downloads the .js file.
bower install --save jquery-elastic="https://github.com/janjarfalk/jquery-elastic/blob/master/jquery.elastic.source.js"
{
  "name": "jquery.elastic.source",
  "_cacheHeaders": {
    "Content-Type": "text/html; charset=utf-8"
  },
  "main": "index.js",
  "_source": "https://github.com/janjarfalk/jquery-elastic/blob/master/jquery.elastic.source.js",
  "_target": "*",
  "_originalSource": "https://github.com/janjarfalk/jquery-elastic/blob/master/jquery.elastic.source.js",
  "_direct": true
}

You just want to use the github repo for that
On 6 Feb 2016 09:27, "X O"<EMAIL_ADDRESS>wrote:

I'm even getting something similar with urls ending in .js, if I remove
/blob/master/jquery.elastic.source.js I get a file called index with the
html contents and if I add it on I get a files called index.js with the
same contents. It never downloads the .js file.
bower install --save jquery-elastic="
https://github.com/janjarfalk/jquery-elastic/blob/master/jquery.elastic.source.js
"
{
"name": "jquery.elastic.source",
"_cacheHeaders": {
"Content-Type": "text/html; charset=utf-8"
},
"main": "index.js",
"_source": "https://github.com/janjarfalk/jquery-elastic/blob/master/jquery.elastic.source.js",
"_target": "*",
"_originalSource": "https://github.com/janjarfalk/jquery-elastic/blob/master/jquery.elastic.source.js",
"_direct": true
}
—
Reply to this email directly or view it on GitHub
https://github.com/bower/bower/issues/2151#issuecomment-180725173.

Using just the repo gives the same results but with the html file being used as the contents and a file called index being in the root directory without anything else.

you can do bower install jquery-elastic now
https://github.com/janjarfalk/jquery-elastic/pull/29

What was the command you ran to get this error?

Using just the repo gives the same results but with the html file being used as the contents and a file called index being in the root directory without anything else.

I tried all of these and each gave me the same results. I made sure to delete the entry out of the bower.json and the directory in bower_components before trying with the next one.
$ bower install --save "https://github.com/janjarfalk/jquery-elastic"
$ bower install --save "https://github.com/janjarfalk/jquery-elastic/tree/master"
$ bower install --save jquery-elastic="https://github.com/janjarfalk/jquery-elastic/tree/master"

@OmgImAlexis none of those are the correct invocation. They will all try to download the GitHub webpage.  Read this getting started guide http://bower.io/#install-packages

Even with bower install https://github.com/janjarfalk/jquery-elastic/blob/master/jquery.elastic.source.js I'm getting this though.
That's one of the ways that's listed.

@OmgImAlexis that's a URL to the HTML web page describing the JS file.
# install the registered package
bower install jquery-elastic
# or install with GitHub short-hand
bower install janjafalk/jquery-elastic
# or if you really want to install with the URL
bower install https://raw.githubusercontent.com/janjarfalk/jquery-elastic/master/jquery.elastic.source.js

@graingert you are correct, @OmgImAlexis  URL seems to be html page of github, instead you can use bower install https://raw.githubusercontent.com/janjarfalk/jquery-elastic/master/jquery.elastic.source.js. This works for me.

@graingert that should be converted into a usable URL, I don't see why you should have to provide a raw path for it.

This is not an actual issue but intended behaviour.
When you're fetching from GitHub, Bower "knows" that and uses the GitHub resolver, which expects a bower.json file (hence the PR by @graingert is a good idea). If you however try installing the raw version from GitHub that will also work and naturally rename it to index.js. Again, this is by design and  also discussed in this old issue.
Just to illustrate: if you try to bower install http://benmann.de/test.js this will also result in a file called index.js in a folder named test > bower_components/test/index.js. It's a way of standardization and if you really need to change it, you will have to use a custom resolver.
That being said, I'm closing this issue (as it is not a real issue).
If there are further questions please feel free to ask! :)

@BenMann I don't think @OmImAlexis 's issue is anything to do with this ticket

@graingert Whoops, you're right. The issue totally changed subject. Let's try to figure this out anyway! :)
Can you provide a (not) working example of this behaviour? I'm not sure if the actual issue is the options you want to provide in the URL or if I'm missing something. I guess you can still use a postintall hooks right now to solve this and just rename the file, in case the URL options are causing this (very likely).

ping @graingert.
I'm still unsure what the options might be useful for — Can you provide an example?

As Bower is deprecated, we encourage now using Yarn for installing packages


[GEP-18] Auto-renew secrets which are about to expire

How to categorize this PR?

/area security
/kind enhancement
/merge squash
What this PR does / why we need it:
This PR adds new functionality to the secrets manager:

All secrets will now get issued-at-time and valid-until-time labels. For certificate secrets, both values are deduced from the generated certificate itself. For non-certificate secrets the valid-until-time is empty unless explicitly provided via the new Validity(time.Duration) option for Generate. The issued-at-time is the current time (for existing secrets it will be time of the first reconciliation, so it is a little imprecise here, but it doesn't matter given that this entire functionality is pretty new).
Based on this information, the secrets manager can trigger automatic renewal of secrets which have reached 80%+ of their validity. This is done in the New function by listing all existing secrets and checking those two labels.

Which issue(s) this PR fixes:
Part of https://github.com/gardener/gardener/issues/3292#issuecomment-1036058890
Special notes for your reviewer:
This does now drop functionality for renewing the ingress TLS secrets, however, the loki-tls secret was already adapted to the new secrets manager as part of #5664 and another PR for adapting the others will follow soon.
/invite @timebertt
Release note:

The secrets manager is now able to automatically renew secrets which are about to expire. This is done as part of the regular reconciliation flows when the respective secret has reached 80% of its validity.

/retest

/assign


Added ultraleap to the core

XRTK - Mixed Reality Toolkit Pull Request
Overview

Added ultraleap repo to the core https://github.com/XRTK/XRTK-Core/pull/595

/azp run


Adds the auto generator tool initial merge to Docker.DotNet

@jstarks There are still two outstanding PR's for specgen but they are small so we can either complete them there and merge across or I can just make the changes here inline with the PR's that they change for Docker.DotNet model code. Do you have a preference?

Resolves: https://github.com/ahmetalpbalkan/Docker.DotNet/issues/52

All outstanding specgen PR's have now been merged and this is ready.

Please squash the first 5 commits into one by me. We don't need commits with titles like "Stuff" :)

Can you add instructions on how to use this somewhere? Maybe it would be nice to set it up so that you just call go generate.

I was trying to do this just as a merge of the old repo then add the vendor/instructions. Would you prefer I do that all as one PR?


apply plugin: 'com.google.ar.sceneform.plugin' breaking code

I've right clicked on the .obj file and clicked on Import scene form asset. Then
@ #apply plugin: 'com.google.ar.sceneform.plugin'
sceneform.asset('sampledata/ArcticFox_Posed.obj',
'default',
'sampledata/ArcticFox_Posed.sfa',
'src/main/assets/ArcticFox_Posed')
added to my app's gradle file, followed by error message

Unable to find method 'com.android.build.gradle.api.ApplicationVariant.getMergeResourcesProvider()Lorg/gradle/api/tasks/TaskProvider;'.
Possible causes for this unexpected error include:Gradle's dependency cache may be corrupt (this sometimes occurs after a network connection timeout.)
Re-download dependencies and sync project (requires network)The state of a Gradle build process (daemon) may be corrupt. Stopping all Gradle daemons may solve this problem.
Stop Gradle build processes (requires restart)Your project may be using a third-party plugin which is not compatible with the other plugins in the project or the version of Gradle requested by the project.In the case of corrupt Gradle processes, you can also try closing the IDE and then killing all Java processes.

I'm using the following configurations:

mac os High Sierra - Version 10.13.6 (17G7024)
Android Studio - 3.1.3
My app's gradle file

apply plugin: 'com.android.application'

android {
    compileSdkVersion 28
    defaultConfig {
        applicationId "myfirstapp.example.com.helloar"
        minSdkVersion 26
        targetSdkVersion 28
        versionCode 1
        versionName "1.0"
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
    compileOptions {
        sourceCompatibility 1.8
        targetCompatibility 1.8
    }
}

dependencies {
    implementation fileTree(dir: 'libs', include: ['*.jar'])
    implementation 'com.android.support.constraint:constraint-layout:1.1.3'
    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'com.android.support.test:runner:1.0.2'
    androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
    // Provides ArFragment, and other UX resources.
    implementation 'com.google.ar.sceneform.ux:sceneform-ux:1.11.0'
    implementation 'com.google.ar:core:1.11.0'

    // Alternatively, use ArSceneView without the UX dependency.
    implementation 'com.google.ar.sceneform:core:1.11.0'
}

apply plugin: 'com.google.ar.sceneform.plugin'

sceneform.asset('sampledata/ArcticFox_Posed.obj',
        'default',
        'sampledata/ArcticFox_Posed.sfa',
        'src/main/assets/ArcticFox_Posed')

can you please tell me the issue. I've seen many forums but didn't get any solution.
My references:

https://www.youtube.com/playlist?list=PLsOU6EOcj51cEDYpCLK_bzo4qtjOwDWfW
https://developers.google.com/ar/develop/java/quickstart

I've upgraded my android studio to 3.4.2 and it's working now.
Thanks


[Feature request] Support a 'depth' option for no-relative-parent-imports

I find the no-relative-parent-imports rule to be very useful, but perhaps a bit too stringent. There's enough cases where reaching up one level makes more sense than creating a new package - but too many for it to make sense to add eslint-disable-line import/no-relative-parent-imports to all the exceptions.
I think it would be enormously helpful if this rule had an option to allow ../, but disallow ../../ and so on. Reaching up one level is quite common and not always a bad practice, but once you get to reaching up two and three levels, that's a code smell for sure.

Once you can reach up one level, you can make a chain of "reach up one level" and easily get to more than one. I don't think there are that many cases where it makes sense to reach up even one level.

Once you can reach up one level, you can make a chain of "reach up one level" and easily get to more than one.

Fair concern, but I don't think that it necessarily makes this request pointless.
I really have to disagree about reaching up one level though. What if we have some utility that we use in foo/bar and in foo/bar/baz we also need that utility. I'm all for moving things to packages to maintain a more tree-like project structure, but this is the kind of thing that, when taken to the logical extreme, can result in dozens of packages that work around just a couple dozen cases of import { something{ from '../utils'`.
In my studying of a number open source repos while determining which rules were worth our time, I found a number of them relied on relative parent imports, even when they had a monorepo. I think you'd be harder pressed to find a substantial codebase entirely devoid of relative parent imports.
Examples:

https://github.com/palantir/blueprint/tree/develop/packages/core/src (used extensively)
https://github.com/ianstormtaylor/slate/tree/main/packages/slate-react/src  (used extensively)
https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-cli/src/handlers/plugin.ts#L2  (used sparingly)

Could Gatsby move their reporter into its own package in their monorepo? Yeah definitely, but to avoid a single line of '../reporter' - it may not necessarily make sense in real life even if it does on paper; only the maintainers are going to understand why that choice was made.
Or could Slate move the components, hooks, plugins, and utils all into their own packages? Sure - but this is a perfect example of how quickly this can get unwieldy. There is some developer time cost involved in creating those additional packages which can definitely outweigh the benefits of doing so in this case.
I feel like this is the kind of rule that could be more helpful if it were more configurable - especially since the current "all of nothing" configuration precludes the possibility of fixing the issues that already exist over time. If there were a way to limit levels you could reach, then a project that already has issues flagged could potentially be fixed over time by reducing the maximum allowable parent levels, with a default of zero.

Dozens of packages sounds great to me - the more the better. It almost always makes sense to extract something to a small package.
In small packages, I think this rule provides much less value - relative imports are fine there. In a monorepo or larger packages tho, I think it's exceedingly important to avoid them.

Agh I'm inclined to agree now, two months later, but at the same time the rule does still seem limiting. It's easy to find fault though and I can't suggest any better option than what already exists.
The overhead of creating so many packages for one or two is just a huge pain. Maybe in some months there will be a popular tool to help eliminate that overhead. That's the best hope for this, I think.


Use of field plaintext_original

I would like to clarify a conceptual doubt regarding use of the "encrypt" function described in the sample section of "Key Encapsulation". The execution confirms successful execution of the "assert" command, confirming encrypt and decrypt operations. When validating the field named plaintext_original with a Python print command, I get a binary field which does not match any standard decode methods like: UTF-8, or ISO-8859-1. After calling the encrypt function, the plaintext_original gets unreadable, likely the field gets modified by the C language processing. Is there a way to set a value for plaintext_original and keep it unmodified and validate it at the end of the encode/decode process?

@kpdemetriou  in some cases , this is required to encrypt a custom message(plain_text) using public key , so there is no way to do that ? or should i implement it myself ?

@kpdemetriou
then what about asymmetric ? what if i want to encrypt a message using public key such that could be decrypted only using private key ?

The KEMs provided in this module are not meant to encrypt arbitrary plaintext directly. Rather, you can use plaintext_original and plaintext_recovered to key a symmetric cipher like AES to achieve bulk encryption of content.

Are you able to give an example of how this is done?


skiff-template needs a mobil menu

the header of the skiff-template varnish2 branch looks bad on mobile.
we should add a mobile menu.

converted menu example in skiff template to be mobil friendly


Install mage via cli

I get an error when I try to install Magento via cli using install.php
composer.json
"require": {     "magento-hackathon/magento-composer-installer": "~3.0",     "aydin-hassan/magento-core-composer-installer": "*",     "openmage/magento-lts": "1.9.4.x-dev" },
error
Fatal error: Uncaught Error: Call to a member function insert() on bool in <root>/htdocs/app/code/core/Mage/Core/Model/Resource/Resource.php:133
any idea?

After a brief analysis I noticed that two files are missing in /app/etc/

local.xml.additional
local.xml.template
They aren't excluded in composer.json

Workaround: copy files from vendor/magento-repo

Hey, I’m not currently able to look at this I’m living out of my tent/car for some months. If you want to send a PR I can take a look when I get decent internet at some point but not in a position to debug and write code atm, sorry!
Sent from my iPhone
On 6 Jun 2019, at 17:02, Simone Gualtieri <notifications<EMAIL_ADDRESS>wrote:
After a brief analysis I noticed that two files are missing in /app/etc/

local.xml.additional
local.xml.template
They aren't excluded in composer.json

Workaround: copy files from vendor/magento-repo
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/AydinHassan/magento-core-composer-installer/issues/49?email_source=notifications&email_token=AAVPX2XB36EMTGAKC5DMT73PZEDGBA5CNFSM4HT7V7XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXCYKBY#issuecomment-499483911, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAVPX2SN5Q5OT6TLPJNIRJDPZEDGBANCNFSM4HT7V7XA.


Stream lags behind on slow connection

Hello, I have noticed that my MSE streams start to lag behind when I use chrome's network throttling. I would like to know if that's intended behavior, or if it can be configured so that streams use only latest data.

This is a known behavior and a major disadvantage of MSE streams. It is very channel sensitive and only works well if the data channel is larger than the bitrate of the video. This is a TCP connection and it is not capable of losing data.

@franconoronha See https://github.com/AlexxIT/go2rtc/issues/1308#issuecomment-2469527200


Remove deprecated serviceAccount field from *Run 🌳

Changes
This removes the deprecated serviceAccount field from TaskRun and
PipelineRun in favor of the newly added serviceAccountName (in
previous release) to match more closely the kubernetes API.
Closes #1219
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>/cc @bobcatfish @afrittoli
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[ ] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.
Double check this list of stuff that's easy to miss:

If you are adding a new binary/image to the cmd dir, please update
the release Task to build and release this image.

Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
Remove deprecated serviceAccount field from TaskRun/PipelineRun in favor of serviceAccountName

@vdemeester rebase? 👼

oh boy.. I need to rebase indeed :joy:

/lgtm

/approve

woot thanks @vdemeester !!


Anything to Contribute?

Hi @Soham-Chakraborty-8455
I would like to contribute to your project as I liked it.
Is there any way I can help with my contribution?

Yeah sure,
My repo would be live by 17th October.You can surely contribute henceforth.
On Sat, 15 Oct 2022, 22:22 Mriganka Paul, @.***> wrote:

Hi @Soham-Chakraborty-8455 https://github.com/Soham-Chakraborty-8455
I would like to contribute to your project as I liked it.
Is there any way I can help with my contribution?
—
Reply to this email directly, view it on GitHub
https://github.com/dsc-iem/DermAssistApp-Hacktoberfest22/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AWKS4VVERXWZ64ARP3JA2SLWDLONPANCNFSM6AAAAAARF7K5VA
.
You are receiving this because you were mentioned.Message ID:
@.***>

If you allow me to contribute on your project I will gladly do it as well. @Soham-Chakraborty-8455

My Project is live and ready to accept contributions now. Feel free to contribute to the issues. Happy Contributing !!!


There are some bugs in your code

Hi, you have done great work on CWS. However, there are some typos in your code. e.g., https://github.com/akibcmi/SAMS/blob/b17378bb08d445f540ac0cb5680023c2fb710a58/train/prf1.py#L34.
Could you please check your code and fix these typos? Thanks.

Thank you for your help.
We have fixed it.

Hi, you have done great work on CWS. However, there are some typos in your code. e.g.,
https://github.com/akibcmi/SAMS/blob/b17378bb08d445f540ac0cb5680023c2fb710a58/train/prf1.py#L34
.
Could you please check your code and fix these typos? Thanks.

Thank you very much for your help. We will check our code and fix typos.

By the way, I want to ask a question about the pre-processing of data.  In https://github.com/akibcmi/SAMS/blob/555a3f82d19b2daa4d4ed3fc24abc0264b3c295a/data/data.py#L159. The labels are all set to 1, but why?

By the way, I want to ask a question about the pre-processing of data. In
https://github.com/akibcmi/SAMS/blob/555a3f82d19b2daa4d4ed3fc24abc0264b3c295a/data/data.py#L159
. The labels are all set to 1, but why?

All gaps between characters in one word are not word boundary. As a result, all these labels are set to 1.

But in your paper, you declare that 1" indicates word boundary. In your reply, you mean that 1" is not word boundary in your code? Thanks.


TFLM: implement new memory planning API.

This is a test.
https://unhashable.com/stacked-pull-requests-keeping-github-diffs-small/

@wangtz  Can you please resolve conflicts? Thanks!

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

@wangtz  Gentle ping to resolve conflicts. Thanks!

It has been 14 days with no activity and the awaiting response label was assigned. Is this PR still valid? Assigning the stalled label. Please comment to reassure me that this is still being worked on.

It has been 43 days that this pull-request has stalled. Please create a new pull-request with the requested changes.


packaging for PyPi

see https://github.com/msiemens/tinydb/issues/319#issuecomment-744789790

@eugene-eeo if you have a minute could you give me some input on how to package it correctly? I managed to create a test package here https://test.pypi.org/project/TinyDBTimestamps/0.2.0/ but after installing it with python3 -m pip install --index-url https://test.pypi.org/simple/ --no-deps TinyDBTimestamps I can not import it. I'm getting ModuleNotFoundError: No module named 'TinyDBTimestamps'. I'm sure it's just some naming issue. Any help would be much appreciated.

you need to import timestamps_middleware instead, since that's the name of the directory in the root folder.
probably want to rename it to tinydb_timestamps though, otherwise users would have to do:
import timestamps_middleware
# instead of
import tinydb_timestamps


Allow configuration of gzip compression level

Thanks, rebased and merged. I guess the rebase confused github, closing PR.


x/xerrors: xerrors.As unable to take in literal as target argument

What version of Go are you using (go version)?

$ go version
go version go1.13.1 darwin/amd64

Does this issue reproduce with the latest release?
I believe so
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/me/Library/Caches/go-build"
GOENV="/Users/me/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/me/go"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/usr/local/Cellar/go/1.13.1/libexec"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/wf/rt6m9wzx4js08mbqtbczcycm0000gn/T/go-build670191544=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

See goplay link:
https://play.golang.org/p/NAROTLJUM9H
What did you expect to see?
I expected to be able to use the xerrors.As using a literal argument like xerrors.As(testcase, &Err{})
What did you see instead?
xerrors.As(testcase, &Err{}) panics.
It seems like it's unwrapping the interface{} argument, deref-ing the pointer at the same time(*Err -> Err). The struct itself doesn't implement error, as the error interface was implemented using a pointer receiver. This causes input validation to fail and panic.

This is working as intended. If Err implements the error interface with a pointer receiver, the type that implements it is *Err, so you have to pass a pointer to that (**Err) to xerrors.As. &Err{} gives you a value of type *Err, which is why your first call in the playground works (you're taking the address of an *Err, which is an **Err) but the second doesn't.

This is how the language works.  It doesn't seem to be a bug.

I suppose my understanding of the function was out of line with the implementation, as I was assuming symmetry between xerrors.Is and xerrors.As where there isn't any.
More clarifying my understanding for the next person who comes along via google. Thanks!

Is there any chance that we can have some documentation stating that xerrors.Is(x, y) being true doesn't imply that xerrors.As(x, y) would be true then? I realise the language doesn't work in a way that allows complete symmetry between these calls. However, in the api it looks like xerrors.Is(x, y) implies xerrors.As(x, y) whereas that's not the case.
I'm happy to throw together a PR for this if needed.


_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 40s
the patch passed

+1 :green_heart:
compile
0m 31s
the patch passed

+1 :green_heart:
javac
0m 31s
the patch passed

+1 :green_heart:
shadedjars
6m 31s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 28s
hbase-client in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m 26s
hbase-client in the patch passed.

28m 34s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1857

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a1f0b92f751b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c2b1f0174

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/1/testReport/

Max. process+thread count
201 (vs. ulimit of 12500)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

This one is only used in BlockingRpcConnection?

@Apache9 , I did look at NettyRpcConnection as well but I couldn't find references to retries.

This one is only used in BlockingRpcConnection?

@Apache9 , I did look at NettyRpcConnection as well but I couldn't find references to retries.

Then please put the configuration in BlockingRpcConnection?

Looks good overall. Does it make sense to also add a small test to cover the configuration?

I tried to look at existing tests for

This one is only used in BlockingRpcConnection?

@Apache9 , I did look at NettyRpcConnection as well but I couldn't find references to retries.

Then please put the configuration in BlockingRpcConnection?

Sure, Let me move to BlockingRpcConnection

@Apache9 @virajjasani , Moved the config to BlockingRpcConnection as discussed. Please have a relook.

Looks good overall. Does it make sense to also add a small test to cover the configuration?

@HorizonNet , I do not see any existing UTs for BlockingRpcConnection. The change is to do a lookup from Conf and fall back to default. This is a standard lookup pattern and must have already been covered at various test cases. I think it would be an overkill to add a new test class for just one config lookup test. Please let me know if you strongly insist.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
4m 26s
master passed

+1 :green_heart:
compile
0m 28s
master passed

+1 :green_heart:
shadedjars
6m  5s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 29s
hbase-client in master failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  1s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed

+1 :green_heart:
javac
0m 27s
the patch passed

+1 :green_heart:
shadedjars
5m 40s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 26s
hbase-client in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
1m  6s
hbase-client in the patch passed.

24m 39s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1857

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 56b4f5d8f74a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c2b1f0174

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/2/testReport/

Max. process+thread count
274 (vs. ulimit of 12500)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 18s
Docker mode activated.

-0 :warning:
yetus
0m  4s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 19s
master passed

+1 :green_heart:
compile
0m 30s
master passed

+1 :green_heart:
shadedjars
7m  5s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 32s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 30s
the patch passed

+1 :green_heart:
compile
0m 30s
the patch passed

+1 :green_heart:
javac
0m 30s
the patch passed

+1 :green_heart:
shadedjars
6m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 27s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 24s
hbase-client in the patch passed.

30m 16s

Subsystem
Report/Notes

Docker
Client=19.03.11 Server=19.03.11 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1857

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 3b212d7d1835 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2c2b1f0174

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/2/testReport/

Max. process+thread count
219 (vs. ulimit of 12500)

modules
C: hbase-client U: hbase-client

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1857/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache9 , Thanks for the review.  Do you mind taking a look at the below PRs with the same change for other branches.
Branch - 2 : https://github.com/apache/hbase/pull/1856/files
Branch - 1: https://github.com/apache/hbase/pull/1854/files

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 45s
Docker mode activated.


⚠ Bofrost.de has degraded performance

In fc2def9, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1685 ms

Resolved: Bofrost.de performance has improved in 2bb1b2a after 13 minutes.


[bugfix] Prevent infinite 302 when embedded jetty and behind LB (backport)

See https://github.com/apereo/cas/pull/4784/

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.8 out of 10 committers have signed the CLA.:white_check_mark: julienhuon:white_check_mark: fmartelli:white_check_mark: marqc:white_check_mark: mmoayyed:white_check_mark: dima767:white_check_mark: sgottschalk:white_check_mark: leeyc0:white_check_mark: tsschmidt:x: leleuj:x: dfish3rYou have signed the CLA already but the status is still pending? Let us recheck it.


Unable to record two browsers simultaneously

Hello!
I need to simultaneously open several pages (2 or more) using a Puppeteer and record each of them in a separate file by Puppeteer-stream. Scripts (.js files) are supposed to be run separately, but simultaneously.
When I run more than one recording, the files get broken. I began to understand the library code and found that when the getStream(...) function is launched, the index is not taken into account when allocating a port for the UDP stream. Corrected, the necessary audio and video gets into the files, but they still turn out to be broken. When recording for 15 seconds, less gets into the file and the audio plays normally, and the video freezes and slows down.
How can this be fixed?

you need install the latest version and add an offset to the base port in the getstream method:
in browser1:
const stream = await getStream(page, {
	transmission: {
		basePort: 8000,
	},
}

in browser2:
const stream = await getStream(page, {
	transmission: {
		basePort: 9000,
	},
}


(docs) update docs/mypy_plugin.md

Change Summary

remove just which adds verbiage
add the to correct article agreement

Related issue number
N/A
Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

oof, just saw this :/

Minimal change and the fork has been deleted so I can't update this.


Enable sudo for iptables so an on_connect script can set DNAT and for…

…ward connections correctly.
I have an openvpn.conf running this patch with the following changes:
script-security 2
client-connect /etc/openvpn/on_connect.sh

With an on_connect.sh of:
#!/bin/bash

/usr/bin/sudo /sbin/iptables -t nat -A PREROUTING -p tcp --dport 80 -j DNAT --to-destination $ifconfig_pool_remote_ip
/usr/bin/sudo /sbin/iptables -t nat -A PREROUTING -p tcp --dport 443 -j DNAT --to-destination $ifconfig_pool_remote_ip

exit 0

This needs to potentially occur outside the container if run without --privilege correct?

Ive bene trying to make this patch but have two issues. When adding using sudo the on_connect.sh fails as it needs a password
We trust you have received the usual lecture from the local System
 Administrator. It usually boils down to these three things:

     #1) Respect the privacy of others.
     #2) Think before you type.
     #3) With great power comes great responsibility.

 sudo: a terminal is required to read the password; either use the -S option to read from standard input or configure an askpass helper
 sudo: a password is required

and when trying to remove the sudo command (hey, im desperate LOL)
DNAT: Could not determine whether revision 2 is supported, assuming it is.
DNAT: Could not determine whether revision 2 is supported, assuming it is.
Fatal: can't open lock file /run/xtables.lock: Permission denied

Ive tried added --privileged to my docker-compose etc.
Any ideas, or better still, any way to get this pulled so it doesn't need an amateur like me hacking around!?

@917huB check the sudoers file that's included with the patch.  Make sure that it's being applied as well with the correct permissions.  It's set as is:
Defaults:nobody !requiretty
nobody ALL = NOPASSWD: /sbin/iptables
so as long as you're running /sbin/iptables as user nobody it shouldn't require a password.  Even if you're not coming from a tty.
So either the sudoers isn't there or you're not running as nobody.

@doug-w thank you, it was an oversight on the permissions.
Traffic is now being passed from internet > Google Cloud VPS > on-premise hosted web server fine now. I am however unable to access the internet from the on-prem web server host through the VPS (curl ifconfig.co for example). I'm  out of my depth here with iptables and would be grateful of any pointers that might accelerate my learning. Thanks again for your support.


Resource reservation for kube and system daemons

How to categorize this issue?
/area robustness
/kind enhancement
/priority normal
What would you like to be added:
Kubelet configuration can be used to reserve resources for kube and system daemons. Reserved resources are deducted from the node's capacity. Node allocatable resources can also be enforced by kubelet on three cgroups: system (eg. system.slice), kube (eg. runtime.slice) and pods (kubepods). If resources are enforced, relevant cgroup controllers are configured (cpu.shares, memory.limit_in_bytes, ...)
The shoot worker kubelet config should allow configuration of the following attributes: SystemReserved, KubeReserved, SystemReservedCgroup, KubeReservedCgroup, EnforceNodeAllocatable.
Why is this needed:
Currently, gardener does not support resource reservation, and the following default configuration is used:
enforceNodeAllocatable:
- pods
kubeReserved:
  cpu: 80m
  memory: 1Gi

This configuration deducts 80m and 1Gi from node's capacity, and enforces the allocatable resources on the kubepods cgroup. For example, on a 8 CPU, 32 GB node, the kubepods cgroup would be configured with 8110 cpu.shares and<PHONE_NUMBER>0 memory.limit_in_bytes.
In gardener nodes, kubelet and docker run as systemd services under the system.slice cgroup, which is configured with default values (eg. 1024 cpu.shares). The existing configuration can lead to starvation of kube components on nodes with high pod density and burstable, resource-intensive workloads: pods are not limited from consuming most of the node's resources and
appropriate resources cannot be assigned to the kube/system cgroups.

Thanks for opening this issue and the description @guydaichs.
Did I get it correctly that in your case, the values for the system-reserved cgroup were too low and thus the kube components where throttled? Btw. which kube components do you mean besides the kubelet process?
Have you tested the very same scenario with higher system-reserved values and saw the throttling not happening?
I'm not generally voting against this request but also wonder if we can use some more decent default values.

Hi @timuthy,

Did I get it correctly that in your case, the values for the system-reserved cgroup were too low and thus the kube components where throttled? Btw. which kube components do you mean besides the kubelet process?
Have you tested the very same scenario with higher system-reserved values and saw the throttling not happening?

I refer to kubelet and docker. Our performance tests showed that increasing system.slice cpu shares improved the average pod start time by 30%, when multiple pods are scheduled on a certain node at a high rate.

I'm not generally voting against this request but also wonder if we can use some more decent default values.

I think that the default values are fine for most cases, and don't see a reason to change them in general.
Our scenario involves large VMs, high pod density and turnaround, bursting workloads, and the pod init time has an impact on end-user experience. Kubelet and docker can consume as much as 2 cpu and 8GB on our nodes. Our use-case isn't typical, and some tuning is required in order to optimize certain operations.
If you prefer to reduce the number of exposed parameters, it would probably be sufficient to only expose kube-reserved. We can use it to control the cpu share ratio between system components and pods.
WDYT?

/assign @guydaichs
Thanks for picking up this task!

Following the discussion in #2574, I updated the requirement in this issue: only SystemReserved, KubeReserved should be exposed.


Fix the reference docs

They aren't being shown https://quart.palletsprojects.com/en/latest/reference/api.html

hi @pgjones, can I work on it?

Sure, this is the local command https://github.com/pallets/quart/blob/main/tox.ini#L32 - I think the only issue is that it isn't clear how to run that with Read the docs - or whether it should be run beforehand and committed to the repo.
I'm not sure what Flask does, but that might also be a solution.

I'm not sure what Flask does, but that might also be a solution.

I almost want to use Flask's texts, can I use them?
The problem is probably because there used to be a file docs/reference/source, it was working locally, but the source/ is in Sphinx's gitignore and can't commit files in the docs/source/.

I think sphinx-apidoc -e -f -o docs/reference/source/ src/quart/ creates the file from the current source code. If so I think we need a way to run this as part of the docs build.
Unless the issue is that that file needs to be created manually?

I don't think there is much difference in principle. so Supposedly, if a new module is added in the future, it can be added manually::
.. automodule:: foo

.. autoclass:: Boo

I think Flask use this method,  Of course, it better if a single file could be created automatically not many files. what do you think?


CI for Node

Initializes with two players (3 ms), Starts the game with a random player, Sets the current player to be whoever it is not (1 ms)


ModuleNotFoundError: No module named 'instance'

我在Ubuntu20.04 ROS noetic运行时出现了这个问题，请问应该怎么解决？
process[cs_driver-2]: started with pid [3625]
Traceback (most recent call last):
  File "/home/jh/catkin_ws/devel/lib/cs_driver/cs_driver_node.py", line 15, in <module>
    exec(compile(fh.read(), python_script, 'exec'), context)
  File "/home/jh/catkin_ws/src/cs_elibot/cs_driver/scripts/cs_driver_node.py", line 2, in <module>
    from cs_driver.cs_driver import CSDriver
  File "/home/jh/catkin_ws/src/cs_elibot/cs_driver/src/cs_driver/cs_driver.py", line 3, in <module>
    from cs_driver.get_joint_position_server import GetJointPositionService
  File "/home/jh/catkin_ws/src/cs_elibot/cs_driver/src/cs_driver/get_joint_position_server.py", line 4, in <module>
    import instance as instance
ModuleNotFoundError: No module named 'instance'
[cs_driver-2] process has died [pid 3625, exit code 1, cmd /home/jh/catkin_ws/devel/lib/cs_driver/cs_driver_node.py __name:=cs_driver __log:=/home/jh/.ros/log/b4978b20-3541-11ef-a4fb-4146dfe0aedf/cs_driver-2.log].
log file: /home/jh/.ros/log/b4978b20-3541-11ef-a4fb-4146dfe0aedf/cs_driver-2*.log

Python 版本为3.8


Update maker docs or defaults to Fiddle's config

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description
The docs for makers' configs are lacking. I often have to look at Electron Fiddle's forge.config.ts to find common sense defaults (example: making a normal .exe on Windows).
Proposed solution
We could do one or both:

update the docs to show all the possible config
update the default values to closer align to what is in Fiddle

Alternatives considered
We could put a link to Fiddle's forge.config.ts at the top of the maker's docs
Additional information
Happy to help with either or both solutions. Just want some confirmation or suggestions from maintainers first.

Thanks for submitting this issue! I think adding an example would be a great idea. I can take a look at this when I get the chance, but PRs welcome!

Closing this issue for now, feel free to reference this issue/ tag me as a reviewer


Implementation of brand list endpoint

Hi! I would like to participate in the development process.
I have implemented this endpoint: List of certified brands
I hope I have done it correctly

https://github.com/diPhantxm/ozon-api-client/issues/1 Should mention issue i guess to save history of developing.
Honestly, i dont have any api keys yet to test it properly, but documentation was very self explanatory enough to create implement this endpoint


Subworkflows don't use package upgrades

Subworkflows need to be opened, upgraded and saved back, no automatic upgrade happens.

I know, and tried it. Unfortunately bumping the version number makes the package initialization fail, and I thus cannot open them. I’ll try to edit them manually.
Matthias

On 30 Apr 2015, at 21:12, Remi Rampin<EMAIL_ADDRESS>wrote:
Subworkflows needs to be opened, upgraded and saved back, no automatic upgrade happens.
—
Reply to this email directly or view it on GitHub https://github.com/VisTrails/VisTrails/issues/1070.

vistrails-dev mailing list
<EMAIL_ADDRESS>http://lists.vistrails.org/mailman/listinfo/vistrails-dev

I should have done all the necessary changes on ALPS in our alps-mpl branch (I imported ALPS from your SVN server). Is there something I forgot?

I needed the open and save the ShowMplPlot.xml file and everything worked as long as I left the version number at 2.2.0.
I now bumped the version number of ALPS from 2.2.0 to 2.2.1 and get this error even if I comment out the subworkflows:
Critical message:
Error changing version
InvalidPipeline: Pipeline has errors. Please see the detailed message for more information.
Missing version 2.2.0 of package org.comp-phys.alps
Upgrading workflow failed.
Output port "self" of module "MplXYPlot" exists, but signatures differ "(org.vistrails.vistrails.basic:Module)" != "(org.vistrails.vistrails.matplotlib:MplPlot)"
Time:
2015-04-30 21:26:09,015
Location:
/Applications/VisTrails/VisTrails.app/Contents/Resources/lib/python2.7/vistrails/gui/vistrail_controller.py, line 564

On 30 Apr 2015, at 21:22, Remi Rampin<EMAIL_ADDRESS>wrote:
I should have done all the necessary changes on ALPS in our alps-mpl https://github.com/VisTrails/VisTrails/compare/v2.2...alps-mpl branch (I imported ALPS from your SVN server). Is there something I forgot?
—
Reply to this email directly or view it on GitHub https://github.com/VisTrails/VisTrails/issues/1070#issuecomment-97935193.

vistrails-dev mailing list
<EMAIL_ADDRESS>http://lists.vistrails.org/mailman/listinfo/vistrails-dev

Yes, MplXYPlot now uses the "value" output port. An upgrade is necessary for the rename, which I provided on branch alps-mpl (50e2c1bf).

It does not seem to work though, even using that.
Matthias

On 30 Apr 2015, at 21:31, Remi Rampin<EMAIL_ADDRESS>wrote:
Yes, MplXYPlot now uses the "value" output port. An upgrade is necessary for the rename, which I provided on branch alps-mpl (50e2c1b https://github.com/VisTrails/VisTrails/commit/50e2c1bf402d634bbd7368cf0fcbc0f0a7bc7c63).
—
Reply to this email directly or view it on GitHub https://github.com/VisTrails/VisTrails/issues/1070#issuecomment-97938102.

vistrails-dev mailing list
<EMAIL_ADDRESS>http://lists.vistrails.org/mailman/listinfo/vistrails-dev

Just to clarify: the problem happens when I bump the ALPS version number from 2.2.0 to 2.2.1

On 30 Apr 2015, at 21:35, Matthias Troyer<EMAIL_ADDRESS>wrote:
It does not seem to work though, even using that.
Matthias

On 30 Apr 2015, at 21:31, Remi Rampin<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Yes, MplXYPlot now uses the "value" output port. An upgrade is necessary for the rename, which I provided on branch alps-mpl (50e2c1b https://github.com/VisTrails/VisTrails/commit/50e2c1bf402d634bbd7368cf0fcbc0f0a7bc7c63).
—
Reply to this email directly or view it on GitHub https://github.com/VisTrails/VisTrails/issues/1070#issuecomment-97938102.

vistrails-dev mailing list
<EMAIL_ADDRESS><EMAIL_ADDRESS>http://lists.vistrails.org/mailman/listinfo/vistrails-dev

vistrails-dev mailing list
<EMAIL_ADDRESS>http://lists.vistrails.org/mailman/listinfo/vistrails-dev

I see. From the log you posted, it looks like it doesn't upgrade to 2.2.1; did you change the target version numbers from 2.2.0 from 2.2.1 in handle_module_upgrade_request(), in init.py?

Thank you, that helped!

On 30 Apr 2015, at 21:43, Remi Rampin<EMAIL_ADDRESS>wrote:
I see. From the log you posted, it looks like it doesn't upgrade to 2.2.1; did you change the target version numbers from 2.2.0 from 2.2.1 in handle_module_upgrade_request(), in init.py?
—
Reply to this email directly or view it on GitHub https://github.com/VisTrails/VisTrails/issues/1070#issuecomment-97942987.

vistrails-dev mailing list
<EMAIL_ADDRESS>http://lists.vistrails.org/mailman/listinfo/vistrails-dev

ALPS now seems to work well on my Mac, and the latest package that works is uploaded to our server. I’ll start on the Windows builds now.
Matthias

On 30 Apr 2015, at 21:48, Matthias Troyer<EMAIL_ADDRESS>wrote:
Thank you, that helped!

On 30 Apr 2015, at 21:43, Remi Rampin<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
I see. From the log you posted, it looks like it doesn't upgrade to 2.2.1; did you change the target version numbers from 2.2.0 from 2.2.1 in handle_module_upgrade_request(), in init.py?
—
Reply to this email directly or view it on GitHub https://github.com/VisTrails/VisTrails/issues/1070#issuecomment-97942987.

vistrails-dev mailing list
<EMAIL_ADDRESS><EMAIL_ADDRESS>http://lists.vistrails.org/mailman/listinfo/vistrails-dev

vistrails-dev mailing list
<EMAIL_ADDRESS>http://lists.vistrails.org/mailman/listinfo/vistrails-dev

The Win32 version also works but is not yet on the server. I’m struggling with memory corruption caused by Boost.Python on Win64. Knowing which compiler Python was built with might help resolve the issue.
Matthias

On 30 Apr 2015, at 22:21, Matthias Troyer<EMAIL_ADDRESS>wrote:
ALPS now seems to work well on my Mac, and the latest package that works is uploaded to our server. I’ll start on the Windows builds now.
Matthias

On 30 Apr 2015, at 21:48, Matthias Troyer<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
Thank you, that helped!

On 30 Apr 2015, at 21:43, Remi Rampin<EMAIL_ADDRESS><EMAIL_ADDRESS>wrote:
I see. From the log you posted, it looks like it doesn't upgrade to 2.2.1; did you change the target version numbers from 2.2.0 from 2.2.1 in handle_module_upgrade_request(), in init.py?
—
Reply to this email directly or view it on GitHub https://github.com/VisTrails/VisTrails/issues/1070#issuecomment-97942987.

vistrails-dev mailing list
<EMAIL_ADDRESS><EMAIL_ADDRESS>http://lists.vistrails.org/mailman/listinfo/vistrails-dev http://lists.vistrails.org/mailman/listinfo/vistrails-dev

vistrails-dev mailing list
<EMAIL_ADDRESS><EMAIL_ADDRESS>http://lists.vistrails.org/mailman/listinfo/vistrails-dev

vistrails-dev mailing list
<EMAIL_ADDRESS>http://lists.vistrails.org/mailman/listinfo/vistrails-dev