Compile to ES2015

I'm using Jest for testing, which runs in a Node environment, and it fails on this add-on because the import statements are not compiled down to ES2015 (Node doesn't yet support ES6 modules):
[...]/node_modules/storybook-readme/with-readme.js:1
({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import React from 'react';
                                                                                ^^^^^^

SyntaxError: Unexpected token import

Jest has a transformer called babel-jest that can transform ES6 modules, but by default everything in node_modules is ignored for performance reasons. The workaround, which is far from idea, is to remove node_modules from the list of ignored transform patterns (in package.json):
"jest": {
  "transform": {
    "^.+\\.js$": "<rootDir>/node_modules/babel-jest"
  },
  "transformIgnorePatterns": []
}

it is related to react-app (from create-react-app) babel preset.
https://github.com/facebookincubator/create-react-app/issues/3334
I would like to use react-app preset but I think I will make the same babel config as at storybook https://github.com/storybooks/storybook/blob/master/.babelrc

I had a similar problem but im using it with Vue components and storyshots.
Instead of removing node_modules completely from transformIgnorePattern I was able to make it work with something like this:
"/node_modules/(?!(storybook-readme|rockey-react|@storybook/.*\\.vue$))"
One thing I was not able to do, is use the __docs property. I had to add this config for jest:
"^.+\\.md?$": "markdown-loader-jest" to be able to use markdown files. The custom webpack.config.js from storybook is not used at all when running jest tests with storyshots

If you are running into this issue when using Jest for testing I suggests using mocking. I think it is the correct way to handle this because it is not your responsibility to test that this plugin works. Here is how I solved this. Some googling can help you find this info as well.

Note: I import like this import { withReadme } from 'storybook-readme';

// ./src/__mocks__/storybook-readme.js

export const withReadme = (readmes, callback) => callback;
export default withReadme;

This allows the storybook render function to get passed back correctly. You might need to tweak based on you implementation.

If you are running into this issue when using Jest for testing I suggests mocking. I think it is the correct way to handle this because it is not your responsibility to test that this plugin works. Here is how I solved this. Some googling can help you find this info as well.

Note: I import like this import { withReadme } from 'storybook-readme';

// ./src/__mocks__/storybook-readme.js

export const withReadme = (readmes, callback) => callback;
export default withReadme;

This allows the storybook render function to get passed back correctly. You might need to tweak based on you implementation.

Could you create a more detailed description of how this is done?


Khd not receiving key strokes

Hi,
I decided to try chunkwm and khd today and have been trying to set things up for the past few hours. I used brew to install both of them and took the example configurations in the chunkwm repo (khdrc, chunkwmrc). Chunkwm seems to be working fine but Khd does nothing. I gave the chunkc commands through terminal manually and they work.  I looked into similar issues and have tried the following:

Re-check accessibility api access
Secure keyboard entry is disabled
Reinstalled khd
Tried by running manually through the keyboard using khd command as well after disabling service. It loads fine (parses the modifiers, literals and commands and prints them out on screen) but then does nothing.

I installed khd with and without using the --with-logging option in brew but can not find any logs generated either in /usr/local/var/log/khd or /tmp/khd. khd -p seems to work as it tells me what keys were pressed (Assuming it doesn't execute the simulated key press).
Can someone point me to what I might be doing wrong here? I'd greatly appreciate it as I have been stuck for quite some time and can not figure it out.

Update: It seems that the khd service is still  not working. It works fine when I load it manually using the command khd in the terminal but when I use brew services start khd, it shows that khd is running but does not accept any key binds.


Check connectivity calculations

We need to understand from where do the differences in iCOH and PPC come from before merging the new calculation into master branch.
Notebook in the matrix_compute branch: DEMO_compute_sync_test.ipynb

ICOH and COH are fixed, but PPC will be omitted for the alpha version.


InitialCameraUpdate to my custom place and after 2 seconds MoveToRegion to CurrentLocation

Hi
I want to show my custom place when map open , and its ok by set InitialCameraUpdate="35.11, 54, 4.5, 0, 0".
Then I want to get CurrentLocation by geolocator : CurrentPosition = await _geolocator.GetPositionAsync();  (I did in ViewModel)
Finding CurrentPosition takes 1 or 2 seconds.
How can I MoveToRegion to the CurrentPosition after this 1 or 2 seconds?

[x] Android
[x] iOS
[x] UWP

Noone ?!

I think you should call _geolocator.GetPositionAsync() in previous page.
class PreviousPage {
    async void onButtonClick() {
        var pos = await _geolocator.GetPositionAsync(); // 1 or 2 seconds
        this.Navigation.PushAsync(new MapPage(pos));
    }
}


added neuropath attributes as new csvs

Added remaining neuropath attributes for the new neuropath template.

Let's remove Filename from the neuropath template

@ameliakallaher I added in the validation rules that will make Braak, CERAD, brainWeight, and PMI only required in the neuropath template and optional in any other templates.
I also added the new pmiUnits column as a requirement to the neuropath template -- might as well collect the units instead of assuming.
I also renamed the neuropath template to "neuropath_metadata_template" since it's not really an assay. Just a style thing, but I figured if we wanted to do it we should do it now before it's been 3 years and it's all over everything 😅
We can double check the test templates that get generated but I think we should be good to go!

Update: I know why the workflow is breaking, it has to do with the template menu vs template csv again, clearly it's not a robust enough function so I'll come back with a more sophisticated fix on Monday.

The component-based 'required' rule finally works as expected -- values are required in the neuropath template, not individual human template, and brain weight is required in model-ad. Verified that the test manifests look as we want them to.


Improve the grenade prediction because it causes fps drops when you're moving

title explains it all : )

Osiris uses game's built-in grenade prediction so it can't be optimized unless we implement it ourselves.

Osiris uses game's built-in grenade prediction so it can't be optimized unless we implement it ourselves.

oh, i didn't know, sorry.


Updating changelog for next version

Signed-off-by: Mohammed Zeeshan Ahmed<EMAIL_ADDRESS>

@mohammedzee1000 Can you resolve conflicts on this PR?

based on latest changlog this pr is no longer needed
/close


The word run was written twice

I'm new and trying to figure out how to help...
Spell check is the best I've got right now.

Sorry for the slow review; merged, thanks @mcloota!


[Feature request] Frontend files

As UMC for M1, it generates frontend files.
It is not implemented in UMC for M2.
Please consider this feature

@KiuNguyen This is in the roadmap. It will be a separate repo with with the files needed to generate frontend files. Most probably will be called Umc_Frontend.
I will close this issue for now since it is not related to the Umc_Base module.


KAFKA-8644. The Kafka protocol generator should allow null defaults for bytes and array fields

LGTM. Thank you for the patch and the review.
Merging.


Update buildx plugin to v0.10.0

https://github.com/docker/buildx/releases/tag/v0.10.0
I noticed, that compose plugin updates are performed by @docker-library-bot in automated manner. But as week passed since buildx release, and there is no automated update, I decided to raise this issue.

Scraping issue fixed in 4d1d884a47c011987bc530e4a9418c8d710aa0ae, version updated in 5ecac9af14c03e24685e478f1c8ddd7f156883d4 &<PHONE_NUMBER>8a23c0c5c423331093640dfeecac63 :bow:
Thanks for the prod! :+1:


Aggregate validations errors in validator runner

Description of changes:
This helps debugging since the validation errors are printed at the end of the program. Until now we only printed "validations failed" and the user needed to scroll through previous logs to find the different errors.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/approve


[BUG] node pool implicitly substitutes zero-sized node pool with a single-worker nodepool

For some reason, an OCI OKE module does not allow its consumers to create a zero-sized node pool, at the same time OCI OKE allows us to do so.
If I will specify the following node pool configuration:
node_pools = {
  "playground": {
    "shape": "VM.Standard.E3.Flex",
    "ocpus": 8,
    "memory": 64,
    "node_pool_size": 0,
    "boot_volume_size": 150,
    "label": {
      name="playground"
    },
  },
  "services": {
    "shape": "VM.Standard.E3.Flex",
    "ocpus": 6,
    "memory": 24,
    "node_pool_size": 0,
    "boot_volume_size": 75,
    "label": {
      name="services"
    },
  }
}

OKE module will replace 0 with 1 and will attempt to create a node pool with a single worker in a node pool.
https://github.com/oracle-terraform-modules/terraform-oci-oke/blob/4.x/modules/oke/nodepools.tf#L24
    # set quantity to a minimum of 1 to allow small clusters.
    size = max(1, lookup(each.value, "node_pool_size", 1))

Closed in #401


[stable/k8s-spot-rescheduler] Add support for node selector and tolerations

/assign @viglesiasce

/assign @unguiculus

/ok-to-test

/assign

Please merge in the latest master to make CircleCI happy.

Merged.

/lgtm


Refinement in the L.Control.SyncView.js:_pullView function

This PR implements the following:

parsing of Lat and Lon to 6 digit float;
trigger dynamic sync / update of the proximity-origin-summary Lat and Lon elements (eventually present in case check/selection of "Show (anyway) the Origin coordinates as summary in the Exposed Form" option

This implementation syncs with latest improvements implemented in Geofield version 8.x-1.61., greatly aimed to enhance dynamic sync between Origin coordinates input and Origin coordinates summary elements.

@itamair refer to https://www.drupal.org/project/leaflet/issues/3254562#comment-15806814, I partly implement the "parsing of Lat and Lon to 6 digit float" logic for 1.9.3 release.
BTW, hard-coded with .geofield-lat-summary and .geofield-lon-summary shouldn't be a good idea when working with downstream integration, therefore sorry that I reject this idea.


excessive logging from homebridge-purpleair-sensor plugin

Describe The Bug:
The homebridge-purpleair-sensor plugin writes excessively to homebridge.log. Most of the output has little or no value. Actual errors are cryptic.
To Reproduce:
This is consistent behavior when the plugin is running.
Expected behavior:
I would not expect a plugin to write excessively to the homebridge.log, in fact this is the only plugin that is doing so.
 Looks like an issue introduced by @Asherlc's latest changes. Will fix it soon.

I published v1.5.1. Can you give it a try?


Filter "View Stories" page based on trigger labels

Summary
This issue partially relates to the question fo pagination in #455: In its current form, the Public Experiences pages does not allow for filtering for certain trigger categories (and does not display the detailed labels). To both improve navigation and allow people make informed decisions we could improve this page by allowing filtering:
Deadline
Mid-April, 2023;
Suggested solution

[ ] Implement pagination (#455)
[ ] Change trigger-display on experience cards to include detail of which labels are present
[ ] Add filtering buttons on top of page to allow people to select which trigger categories should be included in results

For the last point:

The filtering options/buttons should probably be "No triggering experiences", the individual trigger categories, as well as "All experiences"
The default should be "no triggering experiences"
Filtering needs to persist both for search and changes pagination pages

Who can help?

@helendduncan
@gedankenstuecke

Updates

This idea was further cemented in a meeting on 21/04/23


PIn to old dask and dask-expr versions

Change Description

[ ] My PR includes a link to the issue that I am addressing

Solution Description

Code Quality

[ ] My code builds (or compiles) cleanly without any errors or warnings
[ ] My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

[ ] I have added a function that requires a sync_tables command, and have added the neccesary sync_tables call

Bug Fix Checklist

[ ] My fix includes a new test that breaks as a result of the bug (if possible)
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

[ ] I have added or updated the docstrings associated with my feature using the NumPy docstring format
[ ] I have updated the tutorial to highlight my new feature (if appropriate)
[ ] I have added unit/End-to-End (E2E) test cases to cover my new feature
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

[ ] Any updated docstrings use the NumPy docstring format

Build/CI Change Checklist

[ ] If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
[ ] If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

[ ] Any new or updated docstrings use the NumPy docstring format.
[ ] I have updated the tutorial to highlight my new feature (if appropriate)
[ ] I have added unit/End-to-End (E2E) test cases to cover any changes
[ ] My change includes a breaking change

[ ] My change includes backwards compatibility and deprecation warnings (if possible)

Closing debugging PR


Remove installation and examples from readme

Readme should only have information about LMCache project (scope, goal etc.)
For installation and examples, we should link our docs page
Some examples on the readme are outdated and don't work and should be removed anyway
Should add citation keys for both CacheGen and CacheBlend

Let's keep it in README.
Not all user wants to visit our docs page.

It's not usual to have detailed installation in READMEs for large projects, especially if a doc page exists. I feel we might want to follow that convention. READMEs are for project information.
For example:

https://github.com/vllm-project/vllm/blob/main/README.md
https://github.com/langchain-ai/langchain/blob/master/README.md

@ApostaC @KuntaiDu Let's hear your views on this, we can keep the README with installation and quickstart setups if you think that's better.

Keep as is for now.


Update documentation to v1.1

Pull Request Test Coverage Report for Build 61

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 82.747%

Totals

Change from base Build 60:
0.0%

Covered Lines:
1717

Relevant Lines:
2075

💛  - Coveralls

Nice job! UI mockup is awesome!


csrftoken validation fail.

the csrftoken parameters is not validation at the server side for null values. For Instance, If the user sends request with csrftoken completely removed is successfully processed by the server. Apparently. X-CSRFToken header is not used within the admin console. This void the usage of csrftoken throughout the application.
Can you please release a patch for this ?

Please check the latest veersion and get back if the issue is persist.


[FEATURE REQUEST] Customize requests messages

Hello,
Is your feature request related to a problem? Please describe.
I would like the ability to customize the messages automatically logged by pino-http (request completed and request errored).
Describe the solution you'd like
Since version 5.0.0 of pino-http, two new options were added: customSuccessMessage and customErrorMessage to do this. So in the end my feature request is only updating the dependencies and publishing a new version. However, the types package is not up to date, so it might not be possible right now.
Describe alternatives you've considered
I haven't considered any alternative yet.
Additional context
Nothing to add.
Thank you!

Thanks, if you are ready to monitor for typings you can ping me when it's done or even create PR by yourself 👍

Hey @na-ji pino-http@5 and it's types are merged in master and shipped in 1.2.0. So I'm closing this


Discover writeable zigbee properties?

First off, awesome project! And thanks for updating it to support 2.68's new weirdly-changing tmp file database -- I went to fork it to add this support, and said "wow, someone already fixed it!"
This is not a trouble ticket, more a "brainstorm how to achieve a thing in a way that doesn't break other peoples' use cases and could eventually get merged" ticket.
I'm using this on a Wink hub to communicate with a RPI-based home automation system to do some time-of-day-based control of Osram Lightify color-temp controllable bulbs (Zigbee ID 50393095, according to aprontest -l -m(#)). I manually edited wink-mqtt.js to allow me to read/write this property.
Aprontest -l -m(#) also exposes a named list of properties and a flag for read-only or read-write.
Looks like this isn't in the apron db, only available through aprontest itself.  Might be possible to parse the output of aprontest with a regex or similar to scrape property names and read/write status. Naive thought is "why not expose all r/w properties?" Two potential problems:

my lightify bulbs expose several properties that are meaningless (hue/saturation/red/green/blue -- guess maybe OSRAM uses the same firmware for their more expensive RGBW bulbs too?)
Some people may want to use zigbee switches, which might expose state as a read-only property.

In the case of potential problem 1, there's a promising read-only property called ZB_ColorMode (value: 2) that might be used to specify which type of bulb it is, but that's a solution only to my specific Lightify use case, not the general case.  Potential problem 2 is a bit less tractable -- maybe it's worth cooking up a new config file to let me configure the endpoints I want for each device?
If I built that, would it be likely to get merged, or is it too much silly complexity for an edge case?

I contemplated adding name support too, but like you said it's not in the
database. If you add ID 50393095 to the zigbeeAttributes variable will it
return anything?
What bulb is this you're using? I'll pick one up and test it out.
I'm totally open to contributions of any kind. I cobbled this together for
my own use and know it could use work.
On Sun, Sep 18, 2016 at 7:29 PM Ryan Spicer<EMAIL_ADDRESS>wrote:

First off, awesome project! And thanks for updating it to support 2.68's
new weirdly-changing tmp file database -- I went to fork it to add this
support, and said "wow, someone already fixed it!"
This is not a trouble ticket, more a "brainstorm how to achieve a thing in
a way that doesn't break other peoples' use cases and could eventually get
merged" ticket.
I'm using this on a Wink hub to communicate with a RPI-based home
automation system to do some time-of-day-based control of Osram Lightify
color-temp controllable bulbs (Zigbee ID 50393095, according to aprontest
-l -m(#)). I manually edited wink-mqtt.js to allow me to read/write this
property.
Aprontest -l -m(#) also exposes a named list of properties and a flag for
read-only or read-write.
Looks like this isn't in the apron db, only available through aprontest
itself. Might be possible to parse the output of aprontest with a regex or
similar to scrape property names and read/write status. Naive thought is
"why not expose all r/w properties?" Two potential problems:

my lightify bulbs expose several properties that are meaningless
(hue/saturation/red/green/blue -- guess maybe OSRAM uses the same firmware
for their more expensive RGBW bulbs too?)
Some people may want to use zigbee switches, which might expose state
as a read-only property.

In the case of potential problem 1, there's a promising read-only property
called ZB_ColorMode (value: 2) that might be used to specify which type of
bulb it is, but that's a solution only to my specific Lightify use case,
not the general case. Potential problem 2 is a bit less tractable -- maybe
it's worth cooking up a new config file to let me configure the endpoints I
want for each device?
If I built that, would it be likely to get merged, or is it too much silly
complexity for an edge case?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/danielolson13/wink-mqtt/issues/12, or mute the thread
https://github.com/notifications/unsubscribe-auth/AEs5GLE36Y3dFv234bgyh1W5eoeOUmmZks5qrclxgaJpZM4KADPb
.

Don't worry about picking up a bulb, totally happy to test/hack on it from my end! I did indeed add 50393095 to the zigbeeAttributes variable and I can verify that it's responding. The range of valid values is strange (in the neighborhood of 350-450 IIRC, as discovered by poking it with aprontest).
The bulb in question is an OSRAM Lightify Tunable White 60," for what it's worth.  I may pick up an Osram RGBW Lightify just to see if that ZB_ColorMode flag is different...


⚠ Processors has degraded performance

In 2c46ae9, Processors ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 47 ms

Resolved: Processors performance has improved in 90a02d8.


Clarify meaning of HTCONDORCE_CORES

@djw8605 Could you take a quick look at this?

Looks good to me


Non standard output between core and plugins?

Describe the bug
context
When I format files, I get output lines that sometimes start with "Failed", sometimes "Warning:", and sometimes "error:". It can be a bit confusing.
expectation
I would expect all warnings to start with "warning:", and errors associated to these warnings be appended at the end of the warnings, since these errors do not cause the program to stop (also see #434).
bug
I'm actually not sure which lines come from plugin, from core, or why they differ.
Example:
% make format
Warning: Failed formatting content of a yaml code block (line 214 before formatting). Filename: /media/data/dev/website/docs/posts/save-pytest-logs-as-artifact-gitlab-ci.md
Failed formatting content of a yaml code block (line 177 before formatting). Filename: /media/data/dev/website/docs/posts/save-pytest-logs-as-artifact-gitlab-ci.md
error: Failed to parse at 1:1: Unexpected token Indent
Warning: Failed formatting content of a python code block (line 276 before formatting). Filename: /media/data/dev/website/docs/posts/unify-logging-for-a-gunicorn-uvicorn-app.md
error: Failed to parse at 1:1: Unexpected token Indent
Warning: Failed formatting content of a python code block (line 306 before formatting). Filename: /media/data/dev/website/docs/posts/unify-logging-for-a-gunicorn-uvicorn-app.md
error: Failed to parse at 1:1: Unexpected token Indent
Warning: Failed formatting content of a python code block (line 319 before formatting). Filename: /media/data/dev/website/docs/posts/unify-logging-for-a-gunicorn-uvicorn-app.md
error: Failed to parse at 1:1: Unexpected token Indent
Failed formatting content of a python code block (line 248 before formatting). Filename: /media/data/dev/website/docs/posts/unify-logging-for-a-gunicorn-uvicorn-app.md
error: Failed to parse at 1:1: Unexpected token Indent
Failed formatting content of a python code block (line 272 before formatting). Filename: /media/data/dev/website/docs/posts/unify-logging-for-a-gunicorn-uvicorn-app.md
error: Failed to parse at 1:1: Unexpected token Indent
Failed formatting content of a python code block (line 282 before formatting). Filename: /media/data/dev/website/docs/posts/unify-logging-for-a-gunicorn-uvicorn-app.md
error: Failed to parse at 4:6: Unexpected token '%'
Warning: Failed formatting content of a python code block (line 276 before formatting). Filename: /media/data/dev/website/docs/posts/how-to-deal-with-jinja2-spacing.md
error: Failed to parse at 6:6: Unexpected token '%'
Warning: Failed formatting content of a python code block (line 292 before formatting). Filename: /media/data/dev/website/docs/posts/how-to-deal-with-jinja2-spacing.md
error: Failed to parse at 4:6: Unexpected token '%'
Failed formatting content of a python code block (line 269 before formatting). Filename: /media/data/dev/website/docs/posts/how-to-deal-with-jinja2-spacing.md
error: Failed to parse at 6:6: Unexpected token '%'
Failed formatting content of a python code block (line 285 before formatting). Filename: /media/data/dev/website/docs/posts/how-to-deal-with-jinja2-spacing.md
Warning: Failed formatting content of a toml code block (line 157 before formatting). Filename: /media/data/dev/website/docs/posts/docker-compose-django-postgres-nginx.md
Warning: Failed formatting content of a toml code block (line 383 before formatting). Filename: /media/data/dev/website/docs/posts/docker-compose-django-postgres-nginx.md
Failed formatting content of a toml code block (line 124 before formatting). Filename: /media/data/dev/website/docs/posts/docker-compose-django-postgres-nginx.md
Failed formatting content of a toml code block (line 329 before formatting). Filename: /media/data/dev/website/docs/posts/docker-compose-django-postgres-nginx.md
error: Failed to parse at 1:1: Unexpected token Indent
Failed formatting content of a python code block (line 151 before formatting). Filename: /media/data/dev/website/docs/posts/adding-links-to-formatted-and-syntax-highlighted-code.md
error: Failed to parse at 4:5: Unexpected token 'entry_points'
Warning: Failed formatting content of a python code block (line 42 before formatting). Filename: /media/data/dev/website/docs/posts/write-and-use-a-tox-plugin-from-inside-your-package.md
error: Failed to parse at 4:5: Unexpected token 'entry_points'
Failed formatting content of a python code block (line 39 before formatting). Filename: /media/data/dev/website/docs/posts/write-and-use-a-tox-plugin-from-inside-your-package.md
Warning: Failed formatting content of a yaml code block (line 124 before formatting). Filename: /media/data/dev/website/docs/posts/add-alembic-migrations-to-existing-fastapi-ormar-project.md
Failed formatting content of a yaml code block (line 126 before formatting). Filename: /media/data/dev/website/docs/posts/add-alembic-migrations-to-existing-fastapi-ormar-project.md

problem
I think we could gain at standardizing error messages a bit :slightly_smiling_face:
Typically, adding the plugin name would make it clear to which repository/project we should report an issue when something doesn't work as expected.
Reproduce the bug
git clone https://github.com/pawamoy/website --depth=1 /tmp/repro
cd /tmp/repro
python -m venv .venv
. .venv/bin/activate
python -m pip install mdformat-mkdocs[recommended]
python -m mdformat docs/posts --ignore-missing-references

List your environment
% python -V
Python 3.11.5
% mdformat --version
mdformat 0.7.17 (mdformat_tables: 0.4.1, mdformat_wikilink: 0.2.0, mdformat_admon: 2.0.2, mdformat_gfm: 0.3.6, mdformat_footnote: 0.1.1, mdformat_frontmatter: 2.0.8, mdformat_simple_breaks:
0.0.1, mdformat_mkdocs: 2.0.8, mdformat_config: 0.1.3, mdformat_ruff: 0.1.3, mdformat_web: 0.1.0, mdformat_beautysh: 0.1.1)
% uname -r
6.8.5-arch1-1

Thanks for the issue!
Yes, there should be lots of room for improvement here.
One issue is plugins that invoke a code formatter in a subprocess. I think they should pretty much always send the subprocess's stderr to subprocess.DEVNULL as is done here, to not mix it up with mdformat's stderr, but I don't think there's any way mdformat can (or should) enforce that.

Apart from capturing everything at the file-descriptor level, using for example failprint, yep, no way to enforce that. I wouldn't particularly recommend using failprint as it's a potential can of worm for cross-platform compatibility :slightly_smiling_face:
Even if it's not enforced, it shouldn't be hard to convince plugin authors to update their code (or to send PRs, which I could do too) if there's documentation that goes in this direction.
Anyway, happy to help any way I can here!


AIO CPU Locked Tensor

Restoring the functionality of the cpu locked tensor in the AIO library.

@jomayeri, need to re-enable these unit tests
https://github.com/microsoft/DeepSpeed/blob/8cded575a94e296fee751072e862304676c95316/tests/unit/ops/aio/test_aio.py#L81


DepthWise Transposed Conv error

A short version of my code is:
import onnx
import torch
import torch.nn as nn
import tvm
import tvm.relay as relay

class UpSample16(nn.Module):
    def __init__(self, in_chan):
        super(UpSample16, self).__init__()
        self.conv1 = nn.ConvTranspose2d(in_chan,
                           in_chan,
                           kernel_size=(32, 1),
                           stride=(16, 1),
                           padding=(8, 0),
                           groups=in_chan,
                           bias=False)
        self.conv2 = nn.ConvTranspose2d(in_chan,
                           in_chan,
                           kernel_size=(1, 32),
                           stride=(1, 16),
                           padding=(0, 8),
                           groups=in_chan,
                           bias=False)

    def forward(self, x):
        x = self.conv1(x)
        x = self.conv2(x)
        return x

input_shape = (1, 3, 768, 768)
shape_dict = {'0': input_shape}
mdpth = './tmp/play.onnx'
opt_level = 3
target = 'cuda'

print('export')
dummy_in = torch.randn(*input_shape)
model = UpSample16(3)
torch.onnx.export(model, dummy_in, mdpth, opset_version=11)

print('load')
model = onnx.load(mdpth)
print('compile')
mod, params = relay.frontend.from_onnx(model, shape_dict, dtype='float32', opset=11)
with relay.build_config(opt_level=opt_level):
    intrp = relay.build_module.create_executor('graph', mod, tvm.gpu(), target)

print('inference')
import cv2
import numpy as np
impth = '000000000139.jpg'
im = cv2.imread(impth)
im = cv2.resize(im, (input_shape[2:][::-1]))
im = (im - np.array([123, 117, 104])) / np.array([58.4, 57.1, 57.4])
im = im.transpose((2, 0, 1))[np.newaxis, :]

out = intrp.evaluate()(tvm.nd.array(im.astype('float32')), **params).asnumpy()

There seems to be two problems:

when the target is cuda, there will be core dump error. When the target is llvm, there will not be problems until "inference".
If I set the groups of the nn.ConvTranspose2d to be 1, there will be no problem(llvm target). However, when I set groups=in_chan, which means "depthwise-conv-transpose2d", there will be problem with compiling.

Please take a look at this, if it is brought by my bad usage of tvm, please correct me. Thanks a lot :)

Thanks for reporting the problem, it would be great if you can open a new trouble shooting thread on https://discuss.tvm.ai/ where the community can jump in and help :)

It does not support the situations of groups!=1, and you must set groups as default (1) in nn.ConvTranspose2d.


Mac OS X: docker-machine: 'status' is not a docker-machine command [critical]

Hi,
I'm using Kitematic to manage Docker containers on Mac OS X (rel. El Capitan); with VirtualBox 5.0.16 r105871 (latest version).
Every time I shut down Kitematic, the Docker VM is lost and I need to re-create it (and I lose all images and all containers).
I get this error in particular:
Encountered an error: Error: Command failed: /usr/local/bin/docker-machine status default,docker-machine: 'status' is not a docker-machine command. See 'docker-machine --help'.
And, obviously, the VM doesn't start and I need to destroy and create it back.
Besides, 'docker-machine --help" doesn't list the "status" command.
Is this a docker-machine issue?

Solved seconds after posting, sorry.
I've installed Vagrant Docker provider after Docker Toolbox; and the Vagrant Docker provided had installed a very old version of docker-machine (the 0.3.1) that doesn't support the "status" command.
I'm closing the issue.


Add min-height property to admin panel

Brief description:

Should be:

How to achieve it:
Apply a min-height: 100vh property to the correct element

@annakukova please, help him out when you have the time

Issue is persistent on desktop versions as well:


Update title to react instead reaccionar

[X] I have read freeCodeCamp's contribution guidelines.
[X] My pull request has a descriptive title (not a vague title like Update index.md)
[X] My pull request targets the master branch of freeCodeCamp.
[X] None of my changes are plagiarized from another source without proper attribution.
[X] My article does not contain shortened URLs or affiliate links.

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

Thanks! Also fixes the first title syntax.


Service order during downgrade

I noticed that when downgrading the Pulsar version, the same order of updates (1. zookeeper, 2. bookkeeper, etc) is used as during an upgrade.  I would have thought that the order would be reversed during a downgrade, i.e. the pulsar proxy would be updated first, then broker, etc.

I would have thought that the order would be reversed during a downgrade

This matches what I would expect as a user since it limits the version matrix on the live cluster. I am not very familiar with the requirements on the upgrade order though.

Also it's not obvious to understand whether the pulsar version change to the a newer or older since we don't know the internal ZK/BK versions

This is a pretty good/interesting point.

Also it's not obvious to understand whether the pulsar version change to the a newer or older since we don't know the internal ZK/BK versions

Why would you need to know this?  Is there a case where the pulsar version would be higher but the internal ZK/BK version is lower, or vice versa?  If so, then you are already upgrading/downgrading in unexpected ways.


Uncaught TypeError: Cannot read property 'indexOf' of undefined

Open the imdone-atom pane
Click the list icon with numbers in front to create a new list
Give the list a name and press enter
Crash

Atom Version: 1.0.4
System: Microsoft Windows 8.1
Thrown From: imdone-atom package, v1.1.9
Stack Trace
Uncaught TypeError: Cannot read property 'indexOf' of undefined
At C:\Users\Anthony\.atom\packages\imdone-atom\node_modules\imdone-core\lib\repository.js:342

TypeError: Cannot read property 'indexOf' of undefined
  at Repository.getFullPath (C:\Users\Anthony\.atom\packages\imdone-atom\node_modules\imdone-core\lib\repository.js:342:11)
  at Repository.repo.fileOK (C:\Users\Anthony\.atom\packages\imdone-atom\node_modules\imdone-core\lib\mixins\repo-fs-store.js:80:18)
  at EventEmitter.<anonymous> (C:\Users\Anthony\.atom\packages\imdone-atom\node_modules\imdone-core\lib\mixins\repo-watched-fs-store.js:72:14)
  at emitTwo (events.js:87:13)
  at EventEmitter.emit (events.js:169:7)
  at EventEmitter.FSWatcher.emit (C:\Users\Anthony\.atom\packages\imdone-atom\node_modules\imdone-core\node_modules\chokidar\index.js:365:31)
  at C:\Users\Anthony\.atom\packages\imdone-atom\node_modules\imdone-core\node_modules\chokidar\index.js:281:18
  at FSWatcher.<anonymous> (C:\Users\Anthony\.atom\packages\imdone-atom\node_modules\imdone-core\node_modules\chokidar\index.js:247:7)
  at emitTwo (events.js:87:13)
  at FSWatcher.emit (events.js:169:7)
  at FSEvent.FSWatcher._handle.onchange (fs.js:1215:12)

Commands
     -5:16.7.0 settings-view:open (atom-text-editor.editor.is-focused)
  3x -4:30.2.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -4:24.6.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -1:04.6.0 imdone-atom:tasks (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "disabledPackages": [
      "eslint",
      "atom-lint",
      "lcov-info",
      "sublime-tabs"
    ]
  }
}

Installed Packages
# User
autocomplete-paths, v1.0.2
build, v0.43.0
color-picker, v2.0.11
imdone-atom, v1.1.9
linter, v1.3.2
linter-coffeelint, v1.0.2
linter-jshint, v1.1.4
mocha-test-runner, v0.4.4
travis-ci-status, v0.16.0

# Dev
No dev packages

I believe I've found the issue.  It's in imdone-core where it checks if the path is to .imdone/config.json.  Since you're running on windows it needs to be using a backslash .  I'll get it patched tonight.

Fixed with imdone-core 1.2.2

I'm seeing this issue now, but when trying to open the pane initially. Does it not like the project folders I have included?


AttributeError: 'NoneType' object has no attribute 'pipeline'

Hello,
I ran the GUI and, in inference mode, selected an index file of a pretrained model and the path of the audio file to be processed. But I run into the following error:
2023-10-19 09:33:29 | WARNING | infer.modules.vc.modules | Traceback (most recent call last):
  File "/home/jupyter/Retrieval-based-Voice-Conversion-WebUI/infer/modules/vc/modules.py", line 185, in vc_single
    audio_opt = self.pipeline.pipeline(
AttributeError: 'NoneType' object has no attribute 'pipeline'

Traceback (most recent call last):
  File "/opt/conda/lib/python3.10/site-packages/gradio/routes.py", line 437, in run_predict
    output = await app.get_blocks().process_api(
  File "/opt/conda/lib/python3.10/site-packages/gradio/blocks.py", line 1349, in process_api
    data = self.postprocess_data(fn_index, result["prediction"], state)
  File "/opt/conda/lib/python3.10/site-packages/gradio/blocks.py", line 1283, in postprocess_data
    prediction_value = block.postprocess(prediction_value)
  File "/opt/conda/lib/python3.10/site-packages/gradio/components.py", line 2586, in postprocess
    file_path = self.audio_to_temp_file(
  File "/opt/conda/lib/python3.10/site-packages/gradio/components.py", line 360, in audio_to_temp_file
    temp_dir = Path(dir) / self.hash_bytes(data.tobytes())
AttributeError: 'NoneType' object has no attribute 'tobytes'```

Another question, don't I have to input a pth file also?

Thanks,
Kevin

I had the same problem.

And did you manage to fix it?

+1 hope a solution

I have the same exact issue on my mac.

Yes, it's strange bug. Sometimes I also saw that error, in that case I choose one standard model and convert one mp3 file, after that choose back custom model and it begin work fine without error... until I restart RVC server

any news on this? Bug still persist, having the same issue. Tried a lot of things without success.

I guess it's because the program cannot parse non-windows file paths. I checked similar error analysis articles, which mentioned this. I encountered the same error under Linux, but everything was normal under Windows.

@Tr-AIL thats an interesting point. But would that mean that no one actually made this work on Mac or Windows? I always assumed since the tutorial talks about Mac.  Or do you mean the paths that we provide in the UI?

thanks for replying. I managed to find a solution for myself and got it running, it might have had multiple reasons. The error originates from a problem where an asset is not correctly loaded.

Wrong file paths: indeed in one of the earlier versions the filepath was wrong. It was fixed in a later update and should work now.
Fault on my side, wrong use of the program. I did not run the full train, so the dropdown to chose a voice was empty. If any asset that is needed is empty it might throw the above mentioned error.

Oh, nice. Thank you for sharing!
On Thu, 9 May 2024 at 11:22, Patrik Jäkel @.***> wrote:

thanks for replying. I managed to find a solution for myself and got it
running, it might have had multiple reasons. The error originates from a
problem where an asset is not correctly loaded.

Wrong file paths: indeed in one of the earlier versions the
filepath was wrong. It was fixed in a later update and should work now.
Fault on my side, wrong use of the program. I did not run the full
train, so the dropdown to chose a voice was empty. If any asset that is
needed is empty it might throw the above mentioned error.

—
Reply to this email directly, view it on GitHub
https://github.com/RVC-Project/Retrieval-based-Voice-Conversion-WebUI/issues/1445#issuecomment-2102386392,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALIUFQX2BQK7YI22SNIN4QTZBNE6JAVCNFSM6AAAAAA6G3SPL6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSGM4DMMZZGI
.
You are receiving this because you commented.Message ID:
<RVC-Project/Retrieval-based-Voice-Conversion-WebUI/issues/1445/2102386392
@github.com>

Make sure that the .pth model file is placed into assets/weights/<NAME>.pth, and .index model file is logs/<NAME>/added_<...>.index
Notice that .pth file name and folder name in logs are the same.

solution：

2024-07-19 17:06:03 | INFO | infer.modules.vc.modules | Loading: assets/weights/mi-test.pth
2024-07-19 17:06:04 | INFO | infer.modules.vc.modules | Select index: logs/mi-test/added_IVF1043_Flat_nprobe_1_mi-test_v2.index
2024-07-19 17:06:44 | INFO | infer.modules.vc.pipeline | Loading rmvpe model,assets/rmvpe/rmvpe.pt

Reinstalling the exact packages in the requirements.txt fixed it on my end :
pip install -r requirements.txt
Some versions had mismatches and caused these weird types of incompatibility glitches.


Update extravar and playbook urls

Fixed the playbook and extravars get urls

Fixes the list of playbook and extravars in the New Activation and New Job forms following the RBAC PR

We actually have a bug open (AAP-7409) to remove the trailing slashes on the API side in order to align with the API design guide. So I think this change should not go ahead?

Indeed, if this bug is accepted: https://issues.redhat.com/browse/AAP-7409 (I see no reason not to.) This PR would be unnecessary.

@ttuffin, @Alex-Izquierdo - AAP-7409 was not yet assigned - I have asked in the team chat to see if someone can work on this. If not - we can merge this PR and revert when the API is fixed

Closing as it was fixed on the api side https://github.com/ansible/eda-server/pull/284


webapp config container set with slot returns main config not slot config

Describe the bug
When updating a container configuration slot it returns the main config instead of the slot config. (known when changing image)
To Reproduce

Setup webapp container with a deployment slot
Run `az webapp config container set -n  -g  -s  -i

Expected behavior
config should be of the slot not of its parent prod
Environment summary
Docker, linux, concourse

Looks like it also doesn't actually update the slot as well.

It was working ok for me.
I'm happy to help out I just need some direction to find the command to fix.

@john681611 I had the same issue I believe - Issue 8808
Solution for me was to upgrade from 2.0.52 to 2.0.60.

Unable to repro this one - please upgrade to the latest CLI version & re-try. Thank you.


After Resetting esp, data not receive in serial monitor.

In my esp8266, i tried to send data from esp to computer. Without pressing reset, everything working fine. But if i press reset button, serial monitor not receiving any data.
How to solve this issue?

This is related to the status of DTR and RTs of the serial port. There should be a level that affects the startup of esp after reset, which is related to the structure of the hardware design. At present, you can disconnect the device and use the serial assistant to debug it. I'll see how to fix it later.

This bug has been fixed in https://github.com/openblockcc/openblock-desktop/releases/tag/v2.2.2


Sequence Diagram Link Broken

Link to the sequence diagram of the transcription pipeline on Transcripts README broken on some devices.

From my Windows computer, it's OK. (image 1)

From @Extheoisah MacOS, it's this way (image 2)

From my Android mobile device, it's this way (image 3)

Good catch @rejeses. Initially I thought that this is an issue with rendering mermaiid diagrams on mobile phone, but it's not, as this one works on mobile.
It has to do with that click-to-expand functionality that I have there. I am trying to figure out what the issue is. If not solved, I will just move the sequence diagram somewhere else.


Task: Good defaults for artifact storage

We shouldn't require much ceremony around specifying a directory to store tarballs and so on; it should Just Work.
Ideally it would be shared across projects so multiple projects building an image on the same base wouldn't redownload it a bajillion times. But that conflicts a bit with MSBuild's model around intermediate files, so we'll have to design a solution.
The solution is probably just "take the defaults from #6".

We'll need this caching ability before our initial previews, so adding this to the preview7 milestone.

This is done!


Add support for LDR (SIMD regs - B, H, S, D)

All tests for these instructions containing floating-point code. Floating-point is disabled and so tests invoving floating-point will not pass through till https://github.com/AliveToolkit/alive2/issues/982 is resolved
Add suitable tests and add support

Resolved in https://github.com/tanmaytirpankar/alive2/commit/8527a0d460b02c71213060b76b283cd989f9cfc2


Buttons have incorrect sizes

Describe the bug
While documenting https://github.com/github/primer/issues/263, I realized that Primer React buttons have incorrect sizes when compared to Figma references and Primer CSS implementation, usually being 2px taller than expected.
This issue is probably due to borders being ignored in the calculation after specifying line-height + padding.
The total height of regular buttons should be 32px on the medium size, 28px on the small size, and 40px on the large size.
Related
https://github.com/github/primer/issues/41 (on "Using borders")

I actually like the 2px higher buttons better, and I'd advocate for updating Figma instead. This is just my personal preference though, and I defer to you and the rest of the team.

@mperrotti we're trying to stick with a 4 or 8px grid for component sizes, to make sure that components can work well together. I guess that's another thing we should document in our interface guidelines 😄.

Also the icon sizes don't correlate to the expected button sizes. So I'm assuming we don't change the size of icons for buttons which have them.
https://github.com/primer/octicons/blob/main/docs/content/packages/react.mdx#sizes

This is all fixed. Is the fix ideal? Maybe not. But the issue doesn't exist any more with the new Button component


Windows Defender shows warning on Setup installer download

Hi,
This was reported on the security mailing list, but I don't believe there is any actual vulnerability, it's more a concern.
It looks like windows defender is finding that the installer has a virus here are the screenshots provided by original reporter. I'll send them here.

@Carreau please refer to this document
https://docs.microsoft.com/en-us/windows/security/threat-protection/microsoft-defender-smartscreen/microsoft-defender-smartscreen-overview
Our app is not code-signed yet. It could be possible reason.
"Microsoft Defender SmartScreen determines whether a downloaded app or app installer is potentially malicious by:
Checking downloaded files against a list of reported malicious software sites and programs known to be unsafe. If it finds a match, Microsoft Defender SmartScreen shows a warning to let the user know that the site might be malicious.
Checking downloaded files against a list of files that are well known and downloaded by many Windows users. If the file isn't on that list, Microsoft Defender SmartScreen shows a warning, advising caution."

This is how SUSE Rancher Kubernetes Desktop has solved the electron Microsoft code-signing for their opensource project:
https://github.com/rancher-sandbox/rancher-desktop/pull/405


listKeys option for Keyvault

Is your feature request related to a problem? Please describe.
Need a feature to check if a key exists in vault or not so that I can avoid creating a key which already exists.
Due to limitation of bicep functions and existing feature, I'm unable to succeed. More info : [#4023]
In this link I came to know that listkey option is not implemented for Keyvault.
https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/bicep-functions-resource#implementations
Describe the solution you'd like
If I have option to listKeys, I can make use of filter to determine whether a key exists or not so that in next line I can avoid deploying key.
BTW., I just want the metadata of the key not the value of the key. For example : name, expiry date and so on.

You can do the next best thing today - using a deployment script, write a PowerShell script to list each of the keys in your Key Vault via Powershell's Get-AzKeyVaultKey cmdlet. If you don't need it to be generically applied, I recommend doing any filtering in the Powershell script itself (passing in parameters as necessary), but if you must do it in ARM, at least you could apply a lambda function to any of the output values.

@WhitWaldo Thank you for your assitance. I used Az CLI to list the keys and convert the result as json in the format which I can use it as parameter for Bicep deployment.
In general, its is possible to maintain IaC in Bicep but for every bits and pieces I had to write scripts to connect or make Bicep scripts work or some times I feel Bicep script cannot do it at all without PS, Az CLI, ARM.

Documentation: https://learn.microsoft.com/en-us/azure/key-vault/keys/quick-create-template?tabs=CLI#creating-key-using-arm-template-is-different-from-creating-key-via-data-plane states following about keys:

It's only possible to create new keys. It isn't possible to update existing keys, nor create new versions of existing keys. If the key already exists, then the existing key is retrieved from storage and used (no write operations will occur).

REST API spec:

Creates the first version of a new key if it does not exist. If it already exists, then the existing key is returned without any write operations being performed. This API does not create subsequent versions, and does not update existing keys.

I have no idea why the this description is not visible on autogenerated Bicep documentation.


update walkthrough.py to comply with python convention

Is there an easy way to add a form or browser for input and output?


Commands case insensitive

Make commands case insensitive and add tests in AddressBookParserTest.

Codecov Report

Merging #117 (f3ba593) into master (ef98523) will increase coverage by 1.70%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##             master     #117      +/-   ##
============================================
+ Coverage     68.47%   70.17%   +1.70%
- Complexity      595      619      +24
============================================
  Files           100      100
  Lines          2106     2102       -4
  Branches        259      260       +1
============================================
+ Hits           1442     1475      +33
+ Misses          576      531      -45
- Partials         88       96       +8

Impacted Files
Coverage Δ

...ddress/logic/commands/person/ViewGroupCommand.java
40.00% <ø> (+40.00%)
:arrow_up:

...ess/logic/commands/person/ViewScheduleCommand.java
100.00% <ø> (ø)

...ss/logic/commands/schedule/DeleteEventCommand.java
75.00% <ø> (ø)

...s/logic/commands/schedule/FreeScheduleCommand.java
100.00% <ø> (ø)

...u/address/model/person/IsTagInPersonPredicate.java
42.85% <0.00%> (+42.85%)
:arrow_up:

...dress/logic/commands/schedule/AddEventCommand.java
72.72% <100.00%> (-4.20%)
:arrow_down:

...ress/logic/commands/schedule/EditEventCommand.java
96.15% <100.00%> (-0.52%)
:arrow_down:

.../seedu/address/logic/parser/AddressBookParser.java
100.00% <100.00%> (+33.33%)
:arrow_up:

...a/seedu/address/model/schedule/RecurFrequency.java
70.00% <100.00%> (+1.03%)
:arrow_up:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef98523...f3ba593. Read the comment docs.


Fix leader election configuration

During tests, resources aren't reconciled fast enough since
chaos duck kills pods continuously and they need to acquire
leases faster.
Similar to https://github.com/knative-sandbox/eventing-kafka/pull/1068/files
Signed-off-by: Pierangelo Di Pilato<EMAIL_ADDRESS>

/lgtm
/hold several tests are failing

/unhold they are failing everywhere investigating them in https://github.com/knative-sandbox/eventing-kafka-broker/pull/1656

/unhold

/cherry-pick release-1.2


How to paginate cassandra ?

Hello,
I am new to quill, and in need to paginate cassandra dataset. But unable to find any example or hint how to do ? Can you give an example. I am using CassandraAsyncContext.
Thanks
Version: ( 0.9.0)
Module: ( quill-cassandra)

@sasajib Pagination with Cassandra doesn't seem trivial and there are a few alternatives, how would you do it using CQL directly?

Closing since we haven't heard back from the user.


[WIP] Forward client cert in header

In some cases, the application needs to use client certificates (from mTLS, including custom ingress mTLS). While Envoy supports x-forwarded-client-cert, current Istio implementation does not use it (i.e uses the default SANITIZE mode)
This PR configures Envoy to forward (and not forward) following this rules:

forward_only for ingress Envoy: allow certificate will be forwarded to the next hop.
append_forward for sidecar inbound: allows both certificate from previous hop (i.e ingress) and certificate between previous hop and current hop be presented to application.
sanitize for sidecar outbound: prevent application put anything to the x-forwarded-client-cert header.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: rshriram
If they are not already assigned, you can assign the PR to them by writing /assign @rshriram in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
f5036a20083c350545439ec77656a71326487052
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
f5036a20083c350545439ec77656a71326487052
link
/test istio-presubmit

prow/istio-unit-tests.sh
e0ec79de544c67964f81d0455fb343d7c4637149
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
e0ec79de544c67964f81d0455fb343d7c4637149
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/test istio-unit-tests

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
249e8a143ec5b6ab48d51389adb6fc86aeb704fe
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.


Adding batch of changes related to community feedback

Updates ATAT CSP API version to 0.3.0

Reviewing now.

Everything looks compliant with Open API 3.0, also checked it locally in my linter and there were no issues. My only input would be maybe moving securitySchemes to underneath schemas and examples so it is right next to security when looking at the spec (minor improvement to readability).


ble_server txPower allways -21 on arduino

Hello,
I am new in BLE world so may be I ask something strange but:
I try BLE_server.ino and BLE_scan.ino example
and got: Advertised Device: Name: MyESP32, Address: 30:ae:a4:59:21:4e, txPower: -21
and about 1m distance of successful scanning.
I try:
BLEDevice::init("MyESP32");
BLEDevice::setPower(ESP_PWR_LVL_P7);

but still get the same result.
Also I try
BLEDevice::init("MyESP32");
esp_err_t errRc=::esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_DEFAULT, ESP_PWR_LVL_P7);
errRc=::esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_ADV, ESP_PWR_LVL_P7);
errRc=::esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_SCAN, ESP_PWR_LVL_P7);

and
Serial.println("Characteristic defined! Now you can read it in your phone!");

  Serial.printf("ESP_BLE_PWR_TYPE_DEFAULT=%d \n", ::esp_ble_tx_power_get(ESP_BLE_PWR_TYPE_DEFAULT));
  Serial.printf("ESP_BLE_PWR_TYPE_ADV =%d \n", ::esp_ble_tx_power_get(ESP_BLE_PWR_TYPE_ADV));
  Serial.printf("ESP_BLE_PWR_TYPE_SCAN  =%d \n", ::esp_ble_tx_power_get(ESP_BLE_PWR_TYPE_SCAN));

on server side I'v got:
Starting BLE work!
Characteristic defined! Now you can read it in your phone!
ESP_BLE_PWR_TYPE_DEFAULT=7
ESP_BLE_PWR_TYPE_ADV =7
ESP_BLE_PWR_TYPE_SCAN  =7
but on scan side
Scanning...
Advertised Device: Name: MyESP32, Address: 30:ae:a4:59:21:4e, txPower: -21
Devices found: 1
Scan done!
and only 1m distance.

Also try to compile using ESP32 DevModule (the same result)

Hi, sorry for late reply.
Could you try with some other values from this range:
https://github.com/espressif/esp-idf/blob/master/components/bt/include/esp_bt.h#L157-L164

So I made some more investigation.

The fact is that using any value and both BLEDevice::setPower(ххх)
or

esp_err_t errRc=::esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_DEFAULT,xxx);
errRc=::esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_ADV, xxx);
errRc=::esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_SCAN ,xxx);

```In a BLE_scan.ino example I'v got:
Advertised Device: Name: MyESP32, Address: 30:ae:a4:59:21:4e, txPower: -21

2. Also fact that maximum scan distance is less then 1m
3. It's seems to me that if I use ::esp_ble_tx_power_set I can change tx power
    3.1 If I try
     esp_err_t errRc=::esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_DEFAULT,ESP_PWR_LVL_P9);
     errRc=::esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_ADV, ESP_PWR_LVL_P9);
     errRc=::esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_SCAN ,ESP_PWR_LVL_P9);
    I can got scan in about 1m range.
   3.2 if is try ESP_PWR_LVL_N12 I still can got scan but in a range !!! about 2сm
4. it's also seems to me that if I use BLEDevice::setPower(ххх) with any values I'v got some middle range the same to esp_ble_tx_power_set and ESP_PWR_LVL_P3
5. I add
 pAdvertising->start();
  Serial.println("Characteristic defined! Now you can read it in your phone!");
  Serial.printf("ESP_BLE_PWR_TYPE_DEFAULT=%d \n", ::esp_ble_tx_power_get(ESP_BLE_PWR_TYPE_DEFAULT));
  Serial.printf("ESP_BLE_PWR_TYPE_ADV =%d \n", ::esp_ble_tx_power_get(ESP_BLE_PWR_TYPE_ADV));
  Serial.printf("ESP_BLE_PWR_TYPE_SCAN  =%d \n", ::esp_ble_tx_power_get(ESP_BLE_PWR_TYPE_SCAN));

and if I use BLEDevice::setPower in BLE_server.ino Serial monitor  I'v got some thing like this:
Starting BLE work!
Characteristic defined! Now you can read it in your phone!
ESP_BLE_PWR_TYPE_DEFAULT=7
ESP_BLE_PWR_TYPE_ADV =5
ESP_BLE_PWR_TYPE_SCAN  =5

And I include file with some debug info (debug->verbose) etc may be it help. The main problem for me is that the longest range is 1m only
[debug_esp32_ble.txt](https://github.com/nkolban/esp32-snippets/files/2246218/debug_esp32_ble.txt)

Tomorrow i will try to perform the same tests to confirm it.

tomorrow never comes :)

Yes, sorry for that. Ive been over 10 month at work away home. Now im back and for few days i dont touch esp32. I will do this test just i need to rest.

Never mind. It's just a pun comes to my head.

And what about distance? I can got any signal only in about 1m distance

Its possible you have issue with esp32 board. I can scan for esp32 from about 15 m with no issue.

Yes, it's possible, but I have no problem with WiFi. And as far as I know WiFI and BLE share the same radio module.
I have 4 TTGO LoRa OLED v1 boards and all of them work the same way.
May be someone have experience with that boards? Please tell me if BLE work’s fine or not.

Just found this thread. As @chegewara stated, the TxPower reported in the advertising data is not updated (appears it's stays at -21dBm, regardless of what is set - see  here).
Of course that still doesn't explain the poor range you're experiencing. WiFi & BLE share the same radio on the ESP32, but the WiFi stack & Bluetooth stack can have completely different settings, so operation in WiFi doesn't really affect bluetooth operation (apart from proving the antenna interface is OK).
I'm not clear on the 'LoRa' part of these boards. Do they have another radio for operation at 868/915MHz or 433/470MHz?

About LoRa radio. It's completely separate module. sx1278 or sx1276, depending of frequency  (868/915MHz or 433/470MHz). It's have it's one antenna and communicate with main chip throw SPI.
About WiFi - BLE: I of course understand that stacks are completely different. I mention it only to avoid questions about antenna or some other hardware problems.

I came across this video (Andreas Spiess) that does some RF Testing of some ESP32/LoRa boards (the TTGO is covered). He criticizes the on-board ESP32 antennas, and points out they are easily shorted when soldering (if you aren't very careful). Possibly something to look at?

:) once more. WiFi work perfect. And I don't do any soldering with that modules.

In BLEAdvertising.cpp is the default value
m_advData.include_txpower = true;
So it looks like an issue in the the implementation of
esp_ble_gap_config_adv_data

https://github.com/espressif/esp-idf/issues/2284


LS: Suggest function names from common traits

@Arcticae commented on 13.11.2024, 15:49:00:

Feature Request
Describe the Feature Request
We should implement a file completion suggestion that will also auto-import the trait in the nearest scope, upon selection (within a popup like shown below)

Describe Preferred Solution

Describe Alternatives

Related Code

Additional Context

If the feature request is approved, would you be willing to submit a PR?
(Help can be provided if you need assistance submitting a PR)

[ ] Yes
[ ] No

@mkaput commented on 14.11.2024, 05:33:44:

I think this might be related, though it refers to a code action, not completion starkware-libs/cairo#6647?


float-placement-figure doesn't do anything

It looks like the option float-placement-figure that was introduced in #95 isn't present in the template anymore.
I'm not sure when this was removed, but the default figure placement was set to htbp here, 2 years ago.
To change the figure placement to H, I had to change this in the template itself, and add \include{float} as float-placement-figure doesn't do anything anymore. It would be good to update the documentation on this or reintroduce the functionality, as it is otherwise confusing to see this in the readme :)

https://github.com/Wandmalfarbe/pandoc-latex-template/issues/315 this is related i think

That was probably a mistake when merging with the default template. I'll see how I can restore the old behavior of float-placement-figure.

Hello @Wandmalfarbe, I'm still encountering some issues with image placement, but it appears that I've found a temporary solution for now.
% Override default figure placement To be within the flow of the text rather
% than on it's own page.
\usepackage{float}
\makeatletter
\def\fps@figure{H}
\makeatother

-H disable_float.tex

[H] not working for me, including the the above solution (which I may not have implemented correctly – I replaced the original template code with those 4 lines).
What has worked is to use this solution:https://tex.stackexchange.com/questions/2275/keeping-tables-figures-close-to-where-they-are-mentioned for completely avoiding float environment:
text
\begin{minipage}{\linewidth}
\begin{center}
\includegraphics[width=.6\linewidth]{example-image}
\captionof{figure}{An example image not including a Wombat}
\end{center}
\end{minipage}
even more text


Implement contact caching for box-box collisions

Description
Add contact caching for box-box collisions (can't do for voxel before refactor)

changed when and how the unrelate of the CollidingWith happens
added a new "shape" type to geom to contain the feature info and the ids
changed functions to use this ^
added a new struct to contain the feature id
added new sections in systems to check if the collisions was already happening in the previous section and if so update them instead of replacing them

References:

need to add

Checklist

[ ] Self-review changes.
[ ] Evaluate impact on the documentation.
[ ] Add entry to the changelog's unreleased section.

Is this meant to be included in 0.5? If so change the milestone later. I'll set it to 0.6 for now


Password reset throws error with django 3.1

Hello,
recently updated django to version 3.1 and the password reset view throws error:
django.urls.exceptions.NoReverseMatch: Reverse for 'password_reset_confirm' with keyword arguments '{'uidb64': 'MTA', 'token': 'a88hdr-5fb0f72acbe1e9d2b81b7810dee31037'}' not found. 1 pattern(s) tried: ['usermanagement\/password-reset/confirm/(?P[0-9A-Za-z_\-]+)/(?P[0-9A-Za-z]{1,13}-[0-9A-Za-z]{1,20})/$']
If i roll back to django 3.0 it works again.

Hi @IIFelix, thanks for raising this issue. I'll investigate this evening.

The problem here is that the resulted token length is longer than the length defined in the URL pattern.
I believe that the recent changes with the hashing algorithm are responsible for this
check,
https://github.com/django/django/blob/99abfe8f4d3caebcd73548f5bf9e4755bdfed318/django/contrib/auth/tokens.py#L64

Can you show us all your URLS on your app @IIFelix ? In Django Rest Auth we have this URL for password_reset_confirm:
path('password/reset/confirm/', PasswordResetConfirmView.as_view(), name='rest_password_reset_confirm'
This URL pattern does not accept kwargs or patterns, so this suggest you might be having an issue with a custom URL that has overridden this one.

All our tests currently pass in Django 3.1
Tox output
  python3.5-django22: commands succeeded
  python3.6-django22: commands succeeded
  python3.7-django22: commands succeeded
  python3.8-django22: commands succeeded
  python3.6-django31: commands succeeded
  python3.7-django31: commands succeeded
  python3.8-django31: commands succeeded

Passing build in Circle CI

Can you show us all your URLS on your app @IIFelix ? In Django Rest Auth we have this URL for password_reset_confirm:
path('password/reset/confirm/', PasswordResetConfirmView.as_view(), name='rest_password_reset_confirm'
This URL pattern does not accept kwargs or patterns, so this suggest you might be having an issue with a custom URL that has overridden this one.

I think he may followed the demo project, here is a past issue with an exmaple for what I did back then at the first time I did that
https://github.com/jazzband/dj-rest-auth/issues/22#issue-590571052

If I'm right, you should follow Michael's suggestion and use the mentioned url pattern instead of the one in the demo project.
it should work as expected

But thanks for raising this, now, I know that password reset token length got increased which is better.
Also, this should be taken in considration with other packages which are using regex for this part.

My urls inside the usermanagement app look like this:
`from django.urls import path, include
from rest_framework.routers import url
from . import views
from django.views.generic import TemplateView
urlpatterns = [
url(r'^password-reset/confirm/(?P[0-9A-Za-z_-]+)/(?P[0-9A-Za-z]{1,13}-[0-9A-Za-z]{1,20})/$',
TemplateView.as_view(template_name="password_reset_confirm.html"),
name='password_reset_confirm'),
path(r'', include('dj_rest_auth.urls')),
path('registration/', include('dj_rest_auth.registration.urls'))
]
`
As @mohmyo commented i just copied the passwort reset confirm url from the demo project.
If i replace the url i got from the demo with the one from @iMerica i get this:
Reverse for 'password_reset_confirm' not found. 'password_reset_confirm' is not a valid view function or pattern name.
In your faq (https://dj-rest-auth.readthedocs.io/en/latest/faq.html) at point 2 it's mentioned i should check the urls from the demo project, that's why i copied it.

Sorry, I think we were confusing the path for dj-rest-auth itself and the path that is used internally by Django for a password reset template that is used to send the email.
I'm using this one at my project
path('password-reset/confirm/<uidb64>/<token>/', TemplateView.as_view(), name='password_reset_confirm'),

Works now with your path!
Also had to change the django rest framework 'url' module to the 'path' module from django urls.

Glad it helped

Hi, first of all thanks @mohmyo - your solution worked.
I don't understand however why this is not default behavior in dj-rest-auth - why do we have to wire in Django's password reset template manually?
As a newcomer I'd expect this to work by default in an auth package. There may be a design consideration here, I'm just trying to understand it.
Would it not be good to at least add it to the docs in installation? I'd be happy to amend it if it's suitable and someone can explain the rationale.

I think @iMerica can put more details on the table regarding design or to address this clearly.
I agree that this should be added to the docs's FAQ section at least considering the number of issues and questions triggered by this.

Thanks @mohmyo . Please consider putting this on the demo project.. The FAQ directs users to check the demo folder for fixing this issue, which does not work.


chore: add codeql scanning

Description of changes
Add Github CodeQL scanning in preparation for the sunset of LGTM. This PR does not remove LGTM from the current developer workflow. LGTM will be removed in a subsequent PR.
CodeQL provides insight into potential vulnerability issues in the codebase by performing static analysis of the code. These issues are visible to maintainers in the Security tab on Github.

Issue #, if available

Description of how you validated changes
Changes were validated in my own fork of Amplify CLI.
Checklist

[x] PR description included
[x] yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #11518 (c37ba46) into dev (4a4bd61) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev   #11518   +/-   ##
=======================================
  Coverage   49.41%   49.41%
=======================================
  Files         698      698
  Lines       33788    33788
  Branches     6928     6928
=======================================
+ Hits        16695    16696    +1
+ Misses      15557    15556    -1
  Partials     1536     1536

Impacted Files
Coverage Δ

...li/src/domain/amplify-usageData/getUsageDataUrl.ts
100.00% <0.00%> (+12.50%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Is the section Unchanged files with check annotations added by the CodeQL and will be present in subsequent PRs?

@Amplifiyer Yes

@Amplifiyer Yes

Is there a way to turn them off for unrelated files (files that didn't get changed in the PR)? Right now it seems noise.

@Amplifiyer I was looking into that yesterday afternoon. I didn't see any clear option to do that. I'll do some more digging, but my current thought is no. That said, it shouldn't fail a PR due to files not included in that change. I tested on my own fork and PRs were passing after merging this change into my own dev branch.


fix: Add coordinator host to just run-regtest

Now that we open the channel directly to the coordinator, we started relying on
this variable to be set correctly at startup.

bors r+


GA Week: How to deal with marketing params

Problem
Having marketing parameters in pageviews makes things like /articles/1 and /articles/1?fb_id=3 count as two different pageviews, whereas they're the same page.
Solution
Strip out irrelevant marketing parameters
Questions:

Is there an whitelist  rather that blacklist?

Updated the exclusion criteria to remove all common string add ons on the new clean GA account. Will monitor generally in future to spot any other unwanted strings creeping in.


Getting to production

Hi,
I like your project and was interested if there are any plans to bring this to production one day.

Hi, thanks for reaching out.
I kinda stopped working on this project recently, mainly because it was more of a PoC rather than a well crafted, production ready library (there are better ones out there implemented in Rust).
I'll definitely get back to work on it but I can't tell you when and how. To get this to production, I (or contributors, if any) must fix issue #1. That's the main step, alongside that there's also issue #2 and some of the missing features. It shouldn't take too long to get it ready, but some stuff could have been implemented in a better/more efficient way.
I'll look into all of this in the near future (hopefully).
Have a nice day and thanks again!

Updated issue #2 with some more research...

What crates would you recommend for production?


Default limit of RDP/SSH connection per Bastion Host?

Can we add "Default limit of RDP/SSH connection per Bastion Host?" in the FAQ page?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 03ec4426-bfc1-b046-500d-38b2ca89c71d
Version Independent ID: cdacb6c7-1d83-c62b-9204-f04d9955722c
Content: Azure Bastion FAQ
Content Source: articles/bastion/bastion-faq.md
Service: bastion
GitHub Login: @cherylmc
Microsoft Alias: cherylmc

@isshukla , As of today Azure Bastion supports 25 concurrent connections. But this number will change when the product is GA.
You can see the documentation getting updated once the product becomes GA.


Send an AssetEvent when modifying using get_id_mut

Fixes #321

This change makes sense to me. I could see also updating get_with_id to call self.get in a similar way:
pub fn get_with_id(&self, id: HandleId) -> Option<&T> {
  // - self.assets.get(&Handle::from_id(id))
  self.get(&Handle::from_id(id))
}

As a tangent from your change, I'm curious if you or anyone else knows why we have divergent names get_with_id and get_id_mut. I think all things being equal it'd be nice if those names were harmonized as get_with_id and get_with_id_mut or get_id and get_id_mut, but I think any changes there should be separate and discussed with @cart  first.

I think 'get_with_id()` is the better name. Another pr for that would be welcome.


[SECURITY] Use HTTPS to resolve dependencies in Maven Build

Want to take over the Java ecosystem? All you need is a MITM!
Update: Want to take over the Java ecosystem? All you need is a MITM!

This is a security fix for a  vulnerability in your Apache Maven pom.xml file(s).
The build files indicate that this project is resolving dependencies over HTTP instead of HTTPS.
This leaves your build vulnerable to allowing a Man in the Middle (MITM) attackers to execute arbitrary code on your or your computer or CI/CD system.
This vulnerability has a CVSS v3.0 Base Score of 8.1/10.
POC code has existed since 2014 to maliciously compromise a JAR file in-flight.
MITM attacks against HTTP are increasingly common, for example Comcast is known to have done it to their own users.
This contribution is a part of a submission to the GitHub Security Lab Bug Bounty program.
Detecting this and Future Vulnerabilities
This vulnerability was automatically detected by LGTM.com using this CodeQL Query.
As of September 2019 LGTM.com and Semmle are officially a part of GitHub.
You can automatically detect future vulnerabilities like this by enabling the free (for open-source) LGTM App.
I'm not an employee of GitHub nor of Semmle, I'm simply a user of LGTM.com and an open-source security researcher.
Source
Yes, this contribution was automatically generated, however, the code to generate this PR was lovingly hand crafted to bring this security fix to your repository.
The source code that generated and submitted this PR can be found here:
JLLeitschuh/bulk-security-pr-generator
Opting-Out
If you'd like to opt-out of future automated security vulnerability fixes like this, please consider adding a file called
.github/GH-ROBOTS.txt to your repository with the line:
User-agent: JLLeitschuh/bulk-security-pr-generator
Disallow: *

This bot will respect the ROBOTS.txt format for future contributions.
Alternatively, if this project is no longer actively maintained, consider archiving the repository.
CLA Requirements
This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.
It is unlikely that I'll be able to directly sign CLAs. However, all contributed commits are already automatically signed-off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin
(see https://developercertificate.org/ for more information).
- Git Commit Signoff documentation

If signing your organization's CLA is a strict-requirement for merging this contribution, please feel free to close this PR.
Tracking
All PR's generated as part of this fix are tracked here:
https://github.com/JLLeitschuh/bulk-security-pr-generator/issues/2

Codecov Report

Merging #204 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #204      +/-   ##
============================================
- Coverage     72.54%   72.46%   -0.09%
  Complexity     3358     3358
============================================
  Files           341      341
  Lines         14348    14348
  Branches       1617     1617
============================================
- Hits          10409    10397      -12
- Misses         2961     2971      +10
- Partials        978      980       +2

Impacted Files
Coverage Δ
Complexity Δ

...andler/request/DeleteDistributionGroupHandler.java
77.77% <0%> (-22.23%)
3% <0%> (ø)

...server/connection/ConnectionDispatcherRunable.java
81.57% <0%> (-5.27%)
9% <0%> (-1%)

.../tuplestore/manager/TupleStoreManagerRegistry.java
80.79% <0%> (-3.39%)
50% <0%> (-2%)

...uplestore/manager/TupleStoreZookeeperObserver.java
78.88% <0%> (-3.34%)
19% <0%> (-1%)

...ion/membership/ZookeeperBBoxDBInstanceAdapter.java
77.48% <0%> (-1.99%)
26% <0%> (-1%)

...va/org/bboxdb/network/client/BBoxDBConnection.java
75.17% <0%> (-1.78%)
54% <0%> (ø)

...bboxdb/distribution/zookeeper/ZookeeperClient.java
62.31% <0%> (-0.49%)
49% <0%> (ø)

...torage/sstable/compact/SSTableServiceRunnable.java
69.56% <0%> (ø)
33% <0%> (+1%)
:arrow_up:

.../distribution/region/DistributionRegionSyncer.java
82.85% <0%> (+1.71%)
38% <0%> (+1%)
:arrow_up:

...xdb/network/client/tools/TupleListFutureStore.java
94.82% <0%> (+3.44%)
11% <0%> (+1%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56af2c...6470bb5. Read the comment docs.


EmbedMany persistence doesn't create empty array

Hi there! I've encountered a tricky problem and couldn't find a appropriate solution. I have document with EmbedMany field like
    // It is configured to use discriminator map I think it doesn't has
    // any influence on my question so i omitted the details.

    /**
     * @ODM\EmbedMany(
     *     discriminatorField="t",
     *     discriminatorMap={"a"="ClassA"}
     * )
     */
    protected $comments = array();

So the problem is: when i'm trying to save (persist & flush) new document with empty comments field - ODM doesn't creates comment field at all. And i need to have empty array there to be able to run $size queries on this field.
I've debugged a little bit and found the root of the problem. PersistenceBuilder (line 77-80)
    // @ReferenceMany and @EmbedMany are inserted later
    if ($mapping['type'] === ClassMetadata::MANY) {
        continue;
    }

It skips this field here, and never "inserts it later" due to the fact that no EmbedDocument is scheduled to persist/insert.
So could somebody give me an advice how to deal with this?

@ofetisov you can use $ifNull:
db.col.aggregate([
    {
        "$project": {
            someValue: 1,
            nb: { "$size": { "$ifNull": [ "$array", [  ] ] } } }
    }
]);

@malarzm Thank you for quick response! Yes, I know about $ifNull but i would prefer to have empty array in my DB. Maybe there is some way to configure embedMany?

Maybe there is some way to configure embedMany?

Sorry, there is not or at least I can't recall it :)

@malarzm bad news =( But in any case thank you for your time.

@malarzm Very bad news indeed. We ran into serious problems due to this too. Why I think this is a bug and not a feature?

Mongo itself supports empty array with embedded documents so no reason to say that it is a bad practice.
It is inconsistent with other field types that respect default php value including empty arrays.

Of course that you can always work around in isolated example but imagine you have some heavily object oriented solution where every piece of final logic (think query) is separated in various parts of the code. Then you can run into big troubles.
Thanks for considering fixing that.

@josefsabl I never said it is a bad practice nor that it shouldn't be fixed :P We'll certainly appreciate a PR. Quick solution would be indeed to have a configuration option for EmbedMany and ReferenceMany that would tweak PersistenceBuilder behaviour and change $unset when collection is removed to $set with empty array.
Looking at this if it might be also worth working on #1039 at the same time (that one is in my plans)

Hello, I have the same problem.  Any hook to unlock the situation until it is gonna be fixed?

I've made a PR, I hope you will acceptd!
https://github.com/doctrine/mongodb-odm/pull/1624


Array.blit very slow in 64bit programs compared to Buffer.BlockCopy and Array.Copy

Please provide a succinct description of the issue.
In a 32bit exe Buffer.BlockCopy, Array.Copy and Array.blit run with the times below on my PC when running F# 4.0 (FSharp.Core.dll is 4.40.23413.0)
BenchmarkDotNet=v<IP_ADDRESS>
OS=Microsoft Windows NT 6.2.9200.0
Processor=Intel(R) Core(TM) i7-4960HQ CPU 2.60GHz, ProcessorCount=8
Frequency=2533208 ticks, Resolution=394.7564 ns, Timer=TSC
HostCLR=MS.NET 4.0.30319.42000, Arch=32-bit RELEASE
JitModules=clrjit-v4.6.1080.0

Type=BenchmarkByteArrayCopy  Mode=Throughput

          Method | ArraySize |     Median |    StdDev |
---------------- |---------- |----------- |---------- |
 BufferBlockCopy |        32 | 20.7475 ns | 0.2331 ns |
       ArrayBlit |        32 | 45.5956 ns | 0.4286 ns |
       ArrayCopy |        32 | 30.4521 ns | 0.1700 ns |
 BufferBlockCopy |        33 | 20.6930 ns | 0.4244 ns |
       ArrayBlit |        33 | 45.6194 ns | 0.7939 ns |
       ArrayCopy |        33 | 30.4692 ns | 0.1779 ns |
 BufferBlockCopy |       128 | 22.7526 ns | 0.4133 ns |
       ArrayBlit |       128 | 47.4659 ns | 0.6781 ns |
       ArrayCopy |       128 | 32.4409 ns | 0.2617 ns |
 BufferBlockCopy |       129 | 24.2886 ns | 0.3718 ns |
       ArrayBlit |       129 | 47.8088 ns | 0.6581 ns |
       ArrayCopy |       129 | 32.8520 ns | 0.7031 ns |
 BufferBlockCopy |       512 | 26.4369 ns | 2.0953 ns |
       ArrayBlit |       512 | 50.7762 ns | 0.9780 ns |
       ArrayCopy |       512 | 35.9572 ns | 1.2363 ns |
 BufferBlockCopy |       513 | 27.8609 ns | 2.0420 ns |
       ArrayBlit |       513 | 51.8372 ns | 1.4033 ns |
       ArrayCopy |       513 | 36.6213 ns | 2.9354 ns |

// ***** BenchmarkRunner: End *****

In a 64bit exe Array.blit is very slow compared to the 2 other functions and its own 32bit time
BenchmarkDotNet=v<IP_ADDRESS>
OS=Microsoft Windows NT 6.2.9200.0
Processor=Intel(R) Core(TM) i7-4960HQ CPU 2.60GHz, ProcessorCount=8
Frequency=2533208 ticks, Resolution=394.7564 ns, Timer=TSC
HostCLR=MS.NET 4.0.30319.42000, Arch=64-bit RELEASE [RyuJIT]
JitModules=clrjit-v4.6.1080.0

Type=BenchmarkByteArrayCopy  Mode=Throughput

          Method | ArraySize |      Median |    StdDev |
---------------- |---------- |------------ |---------- |
 BufferBlockCopy |        32 |  19.7775 ns | 0.6260 ns |
       ArrayBlit |        32 | 283.1109 ns | 3.7490 ns |
       ArrayCopy |        32 |  19.3542 ns | 0.8748 ns |
 BufferBlockCopy |        33 |  19.8364 ns | 0.1969 ns |
       ArrayBlit |        33 | 282.3611 ns | 1.9398 ns |
       ArrayCopy |        33 |  19.2031 ns | 0.1164 ns |
 BufferBlockCopy |       128 |  21.7473 ns | 0.7311 ns |
       ArrayBlit |       128 | 291.3455 ns | 3.9101 ns |
       ArrayCopy |       128 |  21.1886 ns | 0.6586 ns |
 BufferBlockCopy |       129 |  22.3929 ns | 1.3163 ns |
       ArrayBlit |       129 | 288.2049 ns | 6.1969 ns |
       ArrayCopy |       129 |  21.5314 ns | 0.8811 ns |
 BufferBlockCopy |       512 |  25.4675 ns | 2.0725 ns |
       ArrayBlit |       512 | 290.6998 ns | 2.3029 ns |
       ArrayCopy |       512 |  24.7855 ns | 1.6994 ns |
 BufferBlockCopy |       513 |  25.7124 ns | 2.1878 ns |
       ArrayBlit |       513 | 288.8875 ns | 2.5716 ns |
       ArrayCopy |       513 |  24.9870 ns | 2.1522 ns |

Repro steps
Provide the steps required to reproduce the problem
1.Create an F# console app with the code below
2.Get Benchmarkdotnet from nuget (or paket)
3.Run 32bit and 64bit versions in release mode from the command line
type BenchmarkByteArrayCopy () =

    [<Params(32, 33, 128, 129, 512, 513)>]
    member val public ArraySize = 0 with get, set

    member val Src:byte array =  [||] with get, set
    member val Dst:byte array =  [||] with get, set

    [<Setup>]
    member this.SetupArrays () =

        this.Src <- Array.zeroCreate<byte> this.ArraySize
        let rnd = System.Random()
        for ctr = 0 to this.ArraySize - 1 do
            this.Src.[ctr] <- byte (rnd.Next() % 255)
        this.Dst <- Array.zeroCreate<byte> this.ArraySize

    [<Benchmark>]
    member this.BufferBlockCopy () =
        System.Buffer.BlockCopy( this.Src, 0, this.Dst, 0, this.ArraySize)

    [<Benchmark>]
    member this.ArrayBlit () =
        Array.blit this.Src 0 this.Dst 0 this.ArraySize

    [<Benchmark>]
    member this.ArrayCopy () =
        System.Array.Copy( this.Src, 0, this.Dst, 0, this.ArraySize)
        assert (this.Src = this.Dst)

[<EntryPoint>]
let Main args =
    BenchmarkRunner.Run<BenchmarkByteArrayCopy>() |> ignore
    0

Expected behavior
64bit Array.blit performance is not 6x slower than 32bit.
Actual behavior
64bit Array.blit performance is6x slower than 32bit.
Known workarounds
use System.Array.Copy or System.Buffer.BlockCopy instead
Related information
OS=Microsoft Windows NT 6.2.9200.0
Processor=Intel(R) Core(TM) i7-4960HQ CPU 2.60GHz, ProcessorCount=8
Frequency=2533208 ticks, Resolution=394.7564 ns, Timer=TSC
F# 4.0 - FSharp.Core.dll is version 4.40.23413.0

I can reproduce this. It is only slower when blit is in an external assembly:

BenchmarkDotNet=v<IP_ADDRESS>
OS=Microsoft Windows NT 6.1.7601 Service Pack 1
Processor=Intel(R) Xeon(R) CPU E5-1650 v3 3.50GHz, ProcessorCount=12
Frequency=3410136 ticks, Resolution=293.2434 ns, Timer=TSC
HostCLR=MS.NET 4.0.30319.42000, Arch=64-bit RELEASE
JitModules=clrjit-v4.6.1076.0;compatjit-v4.6.1076.0
Type=BenchmarkByteArrayCopy  Mode=Throughput
                 Method | ArraySize |        Median |     StdDev |

--------------------------- |---------- |-------------- |----------- |
ArrayBlit |        32 |   268.0323 ns |  3.1238 ns |
MyLocalArrayBlit |        32 |    21.1963 ns |  0.6323 ns |
MyExternalArrayBlit |        32 |   268.1077 ns |  2.0329 ns |
MyExternalArrayInlinedBlit |        32 |    19.6023 ns |  0.3112 ns |
ArrayBlit |        33 |   271.1886 ns |  2.0877 ns |
MyLocalArrayBlit |        33 |    21.2814 ns |  0.3889 ns |
MyExternalArrayBlit |        33 |   266.3843 ns |  1.6139 ns |
MyExternalArrayInlinedBlit |        33 |    19.7673 ns |  1.1605 ns |
ArrayBlit |       128 |   269.2543 ns |  1.8650 ns |
MyLocalArrayBlit |       128 |    23.1813 ns |  0.5487 ns |
MyExternalArrayBlit |       128 |   269.8834 ns |  2.6315 ns |
MyExternalArrayInlinedBlit |       128 |    21.5356 ns |  0.9052 ns |
ArrayBlit |       129 |   276.4029 ns |  5.4407 ns |
MyLocalArrayBlit |       129 |    23.3213 ns |  0.2310 ns |
MyExternalArrayBlit |       129 |   269.4831 ns |  1.9089 ns |
MyExternalArrayInlinedBlit |       129 |    21.7304 ns |  1.3845 ns |
ArrayBlit |       512 |   272.4070 ns |  2.0908 ns |
MyLocalArrayBlit |       512 |    26.2724 ns |  1.9182 ns |
MyExternalArrayBlit |       512 |   275.3414 ns |  3.5161 ns |
MyExternalArrayInlinedBlit |       512 |    24.6548 ns |  1.2643 ns |
ArrayBlit |       513 |   272.9451 ns |  1.7053 ns |
MyLocalArrayBlit |       513 |    26.5051 ns |  1.6400 ns |
MyExternalArrayBlit |       513 |   272.1443 ns |  2.3032 ns |
MyExternalArrayInlinedBlit |       513 |    25.4807 ns |  1.9037 ns |
ArrayBlit |     70000 | 2,748.9391 ns | 47.1668 ns |
MyLocalArrayBlit |     70000 | 2,478.7418 ns | 54.3376 ns |
MyExternalArrayBlit |     70000 | 2,748.8373 ns | 61.9645 ns |
MyExternalArrayInlinedBlit |     70000 | 2,461.5293 ns | 55.8059 ns |

Simply inlining blit fixes this specific issue, but that's surely not the right fix?

@rojepp @Ian144 Could you share your performance testing scripts please?  I'd like to verify that putting an inline on the Array.blit function fixes this
I don't understand why inlining would help here specifically - but looking at the above it seems it does. Perhaps the JIT treats this as a special intrinsic in certain circumstances, but not for generic code.

@rojepp @Ian144   I've pushed a possible fix for this issue

Hi Don
My script is listed in the issue, I've copied it below.
thanks, Ian

Create an F# console app with the code below
Reference Benchmarkdotnet from nuget (or paket)
Run 32bit and 64bit versions in release mode from the command line

type BenchmarkByteArrayCopy () =
[<Params(32, 33, 128, 129, 512, 513)>]
member val public ArraySize = 0 with get, set

member val Src:byte array =  [||] with get, set
member val Dst:byte array =  [||] with get, set

[<Setup>]
member this.SetupArrays () =

    this.Src <- Array.zeroCreate<byte> this.ArraySize
    let rnd = System.Random()
    for ctr = 0 to this.ArraySize - 1 do
        this.Src.[ctr] <- byte (rnd.Next() % 255)
    this.Dst <- Array.zeroCreate<byte> this.ArraySize

[<Benchmark>]
member this.BufferBlockCopy () =
    System.Buffer.BlockCopy( this.Src, 0, this.Dst, 0, this.ArraySize)

[<Benchmark>]
member this.ArrayBlit () =
    Array.blit this.Src 0 this.Dst 0 this.ArraySize

[<Benchmark>]
member this.ArrayCopy () =
    System.Array.Copy( this.Src, 0, this.Dst, 0, this.ArraySize)
    assert (this.Src = this.Dst)

[]
let Main args =
BenchmarkRunner.Run() |> ignore
On 08/07/2016 14:39, Don Syme wrote:
@rojepphttps://github.com/rojepp @Ian144https://github.com/Ian144 Could you share your performance testing scripts please? I'd like to verify that putting an inline on the Array.blit function fixes this
I don't understand why inlining would help here specifically - but looking at the above it seems it does. Perhaps the JIT treats this as a special intrinsic in certain circumstances, but not for generic code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/Microsoft/visualfsharp/issues/1251#issuecomment-231361575, or mute the threadhttps://github.com/notifications/unsubscribe/ALzOdwlRZFm30VvBsP9JujC5zC70AavCks5qTlL_gaJpZM4IwLsm.

Merged the PR above, hence closing this.


non-precached-url :: [{"url":"/"}] on SvelteKit

Hey, I am using the following configuration:
import { sveltekit } from '@sveltejs/kit/vite';
import { VitePWA } from 'vite-plugin-pwa';
import type { UserConfig } from 'vite';

const mode = process.env.NODE_ENV as 'development' | 'production';

console.log(mode)

const config: UserConfig = {
	server: {
		hmr: {
			clientPort: 80
		}
	},
	define: {
		__DATE__: `'${new Date().toISOString()}'`,
		__RELOAD_SW__: false
	},
	plugins: [
		sveltekit(),
		VitePWA({
			srcDir: './src',
			mode,
			strategies: 'injectManifest',
			filename: 'service-worker.ts',
			scope: '/',
			base: '/',
			manifest: {
				short_name: 'Example PWA',
				name: 'Example PWA',
				start_url: '/',
				scope: '/',
				display: 'standalone',
				theme_color: '#ffffff',
				background_color: '#ffffff',
				icons: [
					{
						src: '/img/pwa-192x192.png',
						sizes: '192x192',
						type: 'image/png'
					},
					{
						src: '/img/pwa-512x512.png',
						sizes: '512x512',
						type: 'image/png'
					},
					{
						src: '/img/pwa-512x512.png',
						sizes: '512x512',
						type: 'image/png',
						purpose: 'any maskable'
					}
				]
			},
			devOptions: {
				enabled: mode === 'development',
				type: 'module',
				navigateFallback: '/'
			}
		})
	]
};

export default config;

service-worker.ts:
import {
	cleanupOutdatedCaches,
	createHandlerBoundToURL,
	precacheAndRoute
} from 'workbox-precaching';
import { NavigationRoute, registerRoute } from 'workbox-routing';

declare let self: ServiceWorkerGlobalScope;

self.addEventListener('message', (event) => {
	if (event.data && event.data.type === 'SKIP_WAITING') self.skipWaiting();
});

// self.__WB_MANIFEST is default injection point
precacheAndRoute(self.__WB_MANIFEST);

// clean old assets
cleanupOutdatedCaches();

let allowlist: undefined | RegExp[];
if (import.meta.env.DEV) allowlist = [/^\/$/];

// to allow work offline
registerRoute(new NavigationRoute(createHandlerBoundToURL('/'), { allowlist }));

As long as I am running in dev mode, everything seems to be okay - the worker is running, and I am not getting any errors.
As soon as I build & preview, I get this error:
service-worker.js:2 Uncaught non-precached-url: non-precached-url :: [{"url":"/"}]     at V.createHandlerBoundToURL (http://xxx.io/service-worker.js:2:1255)     at ne (http://xxx.io/service-worker.js:2:5578)     at http://xxx.io/service-worker.js:2:28886

I included everything in the root +layout.svelte, regarding your example.
In the +page.server.ts I am doing a redirect - user logged in -> /dashboard / not logged in -> /auth/login
I don't think the redirect is the problem since everything is running smoothly in dev.
I already checked the other issues for this topic (https://github.com/vite-pwa/vite-plugin-pwa/issues/120), but I could not find any solution for this problem.
Thanks in advanced - Alex
px envinfo --system --binaries --browsers --npmPackages "{svelte,@sveltejs/*,vite}"
  System:
    OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
    CPU: (16) x64 Intel(R) Core(TM) i9-9900KS CPU @ 4.00GHz
    Memory: 5.36 GB / 15.54 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 16.14.0 - ~/.nvm/versions/node/v16.14.0/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 8.4.1 - ~/.nvm/versions/node/v16.14.0/bin/npm
  Browsers:
    Chrome: 105.0.5195.125
  npmPackages:
    @sveltejs/adapter-node: 1.0.0-next.99 => 1.0.0-next.99
    @sveltejs/kit: 1.0.0-next.525 => 1.0.0-next.525
    svelte: ^3.52.0 => 3.52.0
    vite: ^3.2.0 => 3.2.0

@Cluster2a the problem here is kit, and how it works: the current version is not yet ready to work with latest kit changes (from 358+ version IIRC)
We have a new custom plugin for kit here but not yet released: https://github.com/vite-pwa/sveltekit
To make this plugin working again with the latest kit (358+) we need Vite 3.1+ with the new sequential hook (Rollup): the problem is kit prerender process will be triggered in the writeBundle hook and this plugin need access to generated html pages once this process finish (this is why we need Vite 3.1+) but before the kit closeBundle hook runs (it will run the adapter to copy files to the corresponding build folder).
This plugin will run on its own closeBundle hook but it is running in parallel with the kit ones and so pwa plugin will not have access to the pages generated by the kit prerender process (it is running in parallel with the kit writeBundle and it is finishing before it)

@userquin, thanks for the input - I thought I am doing something wrong since I am not that familiar with service worker.
Is there any ETA for your custom plugin?

Any update on this? I'm using vite 3.2.2 and your sveltekit plugin but get the same error.